Constantly re-runs command on osx

Environment:
uname -a:
Darwin 18.7.0 Darwin Kernel Version 18.7.0: Tue Aug 20 16:57:14 PDT 2019; root:xnu-4903.271.2~2/RELEASE_X86_64 x86_64

rustup -Vv:
rustup 1.20.2 (13979c968 2019-10-16)

rustc -Vv:
rustc 1.38.0 (625451e37 2019-09-23)
binary: rustc
commit-hash: 625451e376bb2e5283fc4741caa0a3e8a2ca4d54
commit-date: 2019-09-23
host: x86_64-apple-darwin
release: 1.38.0
LLVM version: 9.0

cargo -Vv:
cargo 1.38.0 (23ef9a4ef 2019-08-20)
release: 1.38.0
commit-hash: 23ef9a4ef8a96d09b1fd67b2f4e023f416bb1ff1
commit-date: 2019-08-20

Issue: whenever I run cargo watch with any command, the command keeps being rerun. When I run with debug, I see a line that says
*** Paths updated: [PathOp { path: "/path/to/project/src", op: Some((empty)), cookie: None }]
before each run.
Here's an example output of a run (the command here was cargo watch -w src/ -s "echo hi"  --debug --postpone):
*** Paths updated: [PathOp { path: "/path/to/project/src", op: Some((empty)), cookie: None }]
[Running 'echo hi']
*** Sending SIGTERM (int: 15) to child process
*** Waiting for process to exit...
*** Launching child process
*** Assembled command "sh" "-c" "echo hi; echo [Finished running. Exit status: $?]"
*** Waiting for filesystem activity
hi
[Finished running. Exit status: 0]
*** Received SIGCHLD

^ That block above just repeats ad infinitum.
note that I didn't modify anything in that directory. I assume this is related to the latest fsevent release but I wanted to make an issue just in case.

Oops, sorry, misclicked.
When did you install cargo-watch? Was it from source/with cargo install or from a binary release?

It was with cargo install, a few months back. I recently reinstalled with
cargo install --force cargo-watch, but I'm reasonably certain that was
after the behavior started.
On October 18, 2019 at 12:10:52 AM, Félix Saparelli (
<EMAIL_ADDRESS>wrote:
Oops, sorry, misclicked.
When did you install cargo-watch? Was it from source/with cargo install or
from a binary release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/passcod/cargo-watch/issues/131?email_source=notifications&email_token=AAAUBTFRSGA3TIDMYH3Y7M3QPEZMXA5CNFSM4JCBQHA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBSP5II#issuecomment-543489697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUBTGIEZLIBDPCX2FWWATQPEZMXANCNFSM4JCBQHAQ
.

Hmm, I'll investigate; in the meantime could you try the binary release, see if that works? I'm not exactly expecting it to, mostly trying to reduce variables.

The same things happens on Windows 10 when running 'cargo watch -x run' but not when watching 'check' or 'build'. The command just keeps running itself no matter if you change the sources or not.

Now that I've restarted my machine, I haven't been able to reproduce this with any regularity. It has happened once or twice, (both with the binary release and from source), but I'm not sure it's a cargo-watch problem anymore.


Add ability to sort swaps in Trades view

Part of fixing #181. This should also improve performance when rendering large amounts of swaps since only the ones visible will get rendered.

I think the headers need some kind of :hover state to make it clear they can be clicked. And give the headers { cursor: default; user-select: none; }. We don't want the hand cursor in a native app, except for actual links.

All the headers are aligned with their column except for the Status header. I think it should be aligned too.

The default sort is by date (when you open the Trades view), but it's not indicated in the Date header.

The Status column has centered content which makes it hard to align. Should we change it to be left aligned instead?

👍

Yeah, technically it is, but by the DB. Felt weird making the component aware of that so I added a prop with a default value instead.

👍

Good idea. Used --active-text-color. Dunno if we should use something more subtle?

I think it's a little bit too bright. I would go with this color: hsla(216, 27%, 80%, 1). Also add a slight transition to it, like transition: color 0.3s.
I would also add some padding on the text instead of margin, so it's highlighted even when I put my mouse here:

I think it's a little bit too bright. I would go with this color: hsla(216, 27%, 80%, 1). Also add a slight transition to it, like transition: color 0.3s.
I would also add some padding on the text instead of margin, so it's highlighted even when I put my mouse here:

Fixed. I used hsla(216, 27%, 20%, 1) for the Light theme.

This looks great @kevva, good stuff 🎉
Interested to hear your thoughts on https://github.com/atomiclabs/hyperdex/pull/468#discussion_r209997229 but happy to merge as is.
Btw, after playing around with the sorting, I'm not sure sorting in asc/desc is that useful for all of the properties, for example, base/quote currency and status.
It would be great if people could set a filter that will limit the selection to things like:

Only trades with a status of complete|failed|unmatched
Only trades involving the currency KMD
Only trades on the trading pair CHIPS/KMD

Obviously out of the scope of this PR, just putting it out there.

Btw, after playing around with the sorting, I'm not sure sorting in asc/desc is that useful for all of the properties, for example, base/quote currency and status.

Probably not, but I think it's better to stay consistent through all properties. Also, I think that's what most users are familiar with.

It would be great if people could set a filter that will limit the selection to things like:

Yup, adding filters is next on my list.

Sorry, when I said sort by amount I meant by fiat amount, not by unit amount.
E.g:
1 BTC
500 MKD
5 ETH

But I suppose if we do that we should probably also include the fiat amount to make it clear.
E.g:
1 BTC ≈ $6,068.83
500 KMD ≈ $490.91
1.5 ETH ≈ $387.885

But then that's going to break the layout so maybe just forget about that (sorry)

Sorry, when I said sort by amount I meant by fiat amount, not by unit amount.

Yeah, I know, left a comment in https://github.com/atomiclabs/hyperdex/pull/468#discussion_r210021086. But in case don't use the fiat amount, we should at least use the coin amount instead of the symbol.

@kevva But sorting by amounts before symbol is not very helpful. Then you'll have 500 KMD, 1.5 ETH, 1 BTC.

Yep, I think you should revert to how it was previously, sort by currency, then by amount.
As Sindre suggests a sortable separate column for the fiat value of the trade would be useful and avoid all confusion but not sure if we have enough space to permit that.

As Sindre suggests a sortable separate column for the fiat value of the trade would be useful and avoid all confusion but not sure if we have enough space to permit that.

We do in the Trades view, but not in the compact one in Exchange.

We do in the Trades view, but not in the compact one in Exchange.

Perfect.
I'm thinking once GTC orders are implemented we should even change the "Recent Swaps" list to "Open Orders". So it'll only list the in-progress swaps. That will encourage users to use the actual trade history for viewing historical trades. At the moment there is a bit of usage overlap.
This is also how GDAX/Coinbase Pro do it.

I think adding a new fiat column should be done in a separate PR though. I would like to ship this for the public launch.

Yep agree 👍

@kevva can you revert to sorting by base/quote currency unit, then amount. (sorry)
Then I think this is good to merge.
Good stuff ✨

Really nice work, @kevva. This is exactly what I had in mind.

🎉

Yep, spot on @kevva ⭐


Increase timeout for periodic E2E test job ci-gardener-e2e-kind-ha-multi-zone-upgrade-release-v1-65

/kind enhancement
What this PR does / why we need it:
The periodic E2E test job ci-gardener-e2e-kind-ha-multi-zone-upgrade-release-v1-65 has been failing while deleting seed/cluster, mostly due to an early exit error caused by a timeout. To address this issue, the timeout has been increased from 1 hour to 1 hour and 15 minutes. This issue only happens with this release job.
Prow job links:

1638419944154599424
1637936557220433920
1637755184073412608
1637694785298894848
1637513589453492224
1637332393373208576

Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc: @rfranzke

@rfranzke

Where are the 15m coming from/why do you think this is enough?

What I observed from the failed jobs was that the tests passed and the timeout occurred while tearing down the setup with make gardener-down and make kind-down. If we give a few more minutes, the teardown can be completed successfully.
From the successful jobs, I observed that the test duration was mostly around 58-60 minutes.
Prow jobs links

1637271994619662336
1637453190725111808
1637573988005711872

OK, thanks! Shouldn't we update the timeout also for the other release branches and the master branch? Also, maybe we go to 1h30m directly to have even a bit more buffer time?

It's happening only for release branches and not master.

OK, thanks! Shouldn't we update the timeout also for the other release branches and the master branch? Also, maybe we go to 1h30m directly to have even a bit more buffer time?

It is only happening for release branches and not master.

Well, what's the difference on these branches that didn't make us spot it on master as well yet? I guess that's just random behaviour and it could also hit us on master?

The definitions in https://github.com/gardener/ci-infra/tree/32b72a3f0acfad099319899b29c16847ad3ad37f/config/jobs/gardener are missing, or?

Sorry I didn't get it.

Well, what's the difference on these branches that didn't make us spot it on master as well yet? I guess that's just random behaviour and it could also hit us on master?

Yes, I agree with you that it may happen on the master branch as well. Therefore, I have increased the timeout to 1hr30 in all places to prevent similar issues in the future.


Mobs randomly teleport upwards when chasing the player

If you anger a mob so it chases you, it sometimes randomly teleports upwards while doing so.
This is definitely the case for the stone monster and the sand monster in mobs_animal.
Just punch the monster on a flat world and run away and look what happens.
I have also observed this for numerous mobs in mobs_mc.
Testing environment:

Minetest 0.4.16
Minetest Game 0.4.16
mobs d31010216ad2e707b811ebcb95bfe184190441b8
mobs_animal 1561ec14477bb1663ebaaf4813b334e54d0ca193

A related issue is that zombies from mobs_mc fall through a 1-node thick floor sometimes when chasing you.

I've been testing for an hour now and cannnot get any monsters to randomly teleport up while being chased, although the mobs_mc does have some animation issues which causes jumpy animation that mobs_monsters does not...  I did however see the zombie fall through a 1 node thick floor but on mobs_monsters stone monsters and the like with similar settings did not?!

Fixed.

Sadly, no. Not fixed.
Tested with a stone monster on a flat world in Creative Mode. I just punched it with a shovel and quickly backd off. It took only a few seconds for the weird teleport bug to occour again.
I also just nuked minetest.conf beforehand, just in case.

mobs bc13ef741022d61d75e5d2b5d8f01938931d8bf7
mobs_monster 1561ec14477bb1663ebaaf4813b334e54d0ca193
mobs_animal cadacac5aa399eeb55b51430456f36776ad6221c

WTF? Why do I still have this bug?

Okay, some more details:
In mobs_monster, this appears to happen for stone monster, sand monster and dirt monster.
But it doesn't seem to happen for spider and lava flan and tree monster.
Also, when I say “teleporting”, I mean the mob just suddenly appears a short distance above the previous location. I also noted it's not just the model but the whole selection box which moves. So I guess we can safely discard the “broken model animation” hypothesis.

I know that the engine itself has issues with entity collision which results in entities (not just mobs) going through solid walls, so maybe it's related to that in some weird way as I dont see them teleporting a short distance up here (fixed 19th July 0.4.16 dev build)... also, are they walking OVER any specific node when they move up ? snow ? flowers etc.

No, they just walk over simple nodes, like “Dirt with Grass”.
Also, remember I only tested in MT 0.4.16, not in bleeding edge versions.
Do you care to point me to the offending MT commit / issue?

Still not fixed.

mobs: 28dc0d8be5450ad5289c5b1053af83881ae1004c
mobs_animal: c1799f203cb1b0854df17d95e6a1ff4104559dfd
Minetest / Minetest Game: 0.4.16

Why is this issue still closed?
Here's a reliable way to reproduce this for me:

Build a 1×1 pathway made out of blocks (e.g. bronze block) in the sky
Spawn a dirt monster
Punch it so it starts chasing
Fly to the end of the platform, make sure the monster is still trying to follow you
The dirt monster should teleport a small distance above for no apparent reason in seemlingly random intervals

@tenplus1 Hmm, I guess I found the reason.
There are two setpos in the mod code. This one looks suspicious:
-- attempt to unstick mob that is "daydreaming"
self.object:setpos({
   x = s.x + 0.1 * (random() * 2 - 1),
   y = s.y + 1,
   z = s.z + 0.1 * (random() * 2 - 1)
})

And indeed, when I insert a debug output before this part, this is exactly what causes these weird teleportations!
What is the point of this code? Is there a reason for it? Because these random teleportations are so annoying! Whatever you attempt to fix or work around here, a plain setpos just seems wrong. There must be a better way.


Expose Expression in top-level module

It's sometimes useful to pass around CVXPY expressions. Importing the Expression class in the top-level cvxpy module would let users write informative/correct type annotations for functions that accept or return Expression objects.
For example, a user could then write a function with the signature
def construct_problem(...) -> Tuple[Dict[str, cp.Expression], cp.Problem]:

where the dictionary's values hold CVXPY expressions of interest.
Describe the solution you'd like
Import Expression in the top-level __init__.py.
Describe alternatives you've considered
An alternative is to write cp.expressions.expression.Expression, but this feels clumsy.

Sounds good to me!


PrintPreview

This PR implements a print preview dialog and an associated plot action.
The source is PyMca. I also looked into Qub, but their print preview handles only raster images, without SVG capabilities.
TODO:

[x] dialog
[x] action or toolbar

TODO: fix centering of comments in addSvgItem

Question : should the print preview action remain in its own module (currently silx.gui.plot.actions.printpreview), or moved to silx.gui.plot.actions.io together with PrintAction, or should we have a common module for both print actions outside of io, or should io become a package including print preview?
If I add print preview to actions.io, we are getting close to 1000 lines. Moreover, the print preview action relies on dedicated widgets, whereas the other io actions are mostly widget less, so for me it makes sense to give it a separate module..

I transmogrified the actions into tool buttons, to separate the geometry setting from the print preview.

PrintPreviewDialog has some attributes with dostring, Are they part of the API?
If so, it would be better to have some methods to access them to follow Qt-style API.

In terms of functionality it seems to be fine.
@t20100 I let you decide concerning the API to approve the merge.

I'll see that with @PiRK when he's back.

LGTM, to merge when CI is happy.


images_upload_handler doesn't work for TinyMCE 6

As you may know, the feature has changed a bit in version 6.
Kindly check the comment below for details.
Thanks to @rsevs3.
The outcome is -

If using image_upload_url, the code doesn't embed the csrf token in the request headers so the corresponding django view has to be csrf exempted, which is insecure.
If using images_upload_handler, the new const wouldn't be called.

Just some additional information for this, the way that images_upload_handler works is different.
See: https://www.tiny.cloud/docs/tinymce/6/image/#images_upload_handler
In the new example code, example_image_upload_handler is declared as a const, so is not a property of the window object.
See for more info: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const#description
I am fairly new to coding and have virtually no JS experience, so I do no know how to rewrite this to make it work. I have played around with putting the example code into init_tinymce.js and modifying to suit, which works, but isn't easily user changeable, so not a good solution. I have spent all day trying to find a nice solution, but it is beyond my skill levels currently.
Originally posted by @rsevs3 in https://github.com/jazzband/django-tinymce/issues/426#issuecomment-1472369152

Yeah I cannot figure out how to get my images_upload_handler to work. And I don't want to use images_upload_url as there are hidden form elements I am appending to the XHR request in order to handle some bits in the view (without constructing crazy URLs).

i have an issues when i create tinymce in model it give error and can not make data base

I have image uploads working in my project, so I will post my solution here in case it helps, but note that I have currently hardcoded my image upload URL into the javascript function - for security reasons, I don't want to be using inline javascript, and I don't want to use eval.
Anyway, I have created my own init_tinymce.js script that overrides the default one, and in it I have:
"use strict";
// We need to override init_tinymce because it uses eval, which means we
// would need to allow unsafe_inline in our Content Security Policy.
// We need a custom images_upload_handler which works with Django (sets
// the right CSRF header), so include that in the init here
// Solution adapated from https://github.com/tinymce/tinymce/issues/3942
// NOTE: upload URL currently hardcoded into this JS
const images_upload_handler = (blobInfo, progress) =>
  new Promise((resolve, reject) => {
    let xhr = new XMLHttpRequest();
    xhr.open("POST", "/backend_api/content/upload/image/");
    const csrftoken = document.querySelector(
      "[name=csrfmiddlewaretoken]"
    ).value;
    xhr.setRequestHeader("X-CSRFTOKEN", csrftoken); // manually set header

    xhr.onload = function () {
      if (xhr.status === 403) {
        reject({ message: "HTTP Error: " + xhr.status, remove: true });
        return;
      }
      if (xhr.status !== 200) {
        reject({ message: "HTTP Error: " + xhr.status });
        return;
      }

      let json = JSON.parse(xhr.responseText);

      if (!json || typeof json.location !== "string") {
        reject("Invalid JSON: " + xhr.responseText);
        return;
      }

      resolve(json.location);
    };

    let formData = new FormData();
    formData.append("file", blobInfo.blob(), blobInfo.filename());

    xhr.send(formData);
  });

{
  function initTinyMCE(el) {
    if (el.closest(".empty-form") === null) {
      // Don't do empty inlines
      var mce_conf = JSON.parse(el.dataset.mceConf);

      mce_conf["images_upload_handler"] = images_upload_handler;

      const id = el.id;
      if ("elements" in mce_conf && mce_conf["mode"] == "exact") {
        mce_conf["elements"] = id;
      }
      if (el.dataset.mceGzConf) {
        tinyMCE_GZ.init(JSON.parse(el.dataset.mceGzConf));
      }
      if (!tinyMCE.get(id)) {
        tinyMCE.init(mce_conf);
      }
    }
  }

// FIle continues with ready(), initializeTinyMCE(), etc.

I also had this issue, tried using stuff proposed in #356 but images_upload_handler didn't work. So after checking tinymce documentation I rewrote their const declaration like this and it worked:
function image_upload_handler(blobInfo, progress) {
    return new Promise((resolve, reject) => {
          const xhr = new XMLHttpRequest();
          xhr.withCredentials = false;
          xhr.open('POST', '/example_upload_api');
          xhr.setRequestHeader('X-CSRFToken', Cookies.get("csrftoken")); // add csrf token
          // rest of the code from tinymce documentation
          xhr.upload.onprogress = (e) => {
              progress(e.loaded / e.total * 100);
          };
          xhr.onload = () => {
            if (xhr.status === 403) {
              reject({ message: 'HTTP Error: ' + xhr.status, remove: true });
              return;
            }

            if (xhr.status < 200 || xhr.status >= 300) {
              reject('HTTP Error: ' + xhr.status);
              return;
            }

            const json = JSON.parse(xhr.responseText);

            if (!json || typeof json.location != 'string') {
              reject('Invalid JSON: ' + xhr.responseText);
              return;
            }

            resolve(json.location);
          };

          xhr.onerror = () => {
            reject('Image upload failed due to a XHR Transport error. Code: ' + xhr.status);
          };

          const formData = new FormData();
          formData.append('file', blobInfo.blob(), blobInfo.filename());

          xhr.send(formData);
    })
}


GitHub Actions are not up-to-date

Right now, the CI is failing because of the use of deprecated/unsupported GitHub Action versions.
Things that needs to be done:

[x] Upgrade each GitHub Action to the latest major version available
[x] Upgrade the Node.js version that is used to use the latest LTS version, which is 20 as of today
[x] Replace the use of @master version with the latest available major version (@vX) for all actions that are still using it
[x] Remove the use of nelonoel/branch-name to use something like described here: https://stackoverflow.com/a/58035262

Just a FYI I talk to someone that is using these components and upgraded them in a fork, see https://github.com/spwoodcock/openlayers-elements
He asked if we would be interested in merging & I proposed that we have a discussion on how to governance the components. It might be that we move them to an independent github org so others can easier contribute as well. So we should finish those discussions before we work on the code again.

Done!


Pinned repositories of an organization.

Proposed Method
.pinned_repository()
Description
Create a method that returns the details of pinned repository of an organization.

Output Sample
[
    {
        "name":"",
        "link":"https://github.com/Clueless-Community/clueless-official-website",
        "detail":"This is Clueless official website where you can make your developer profile as well as meet new people across the world.",
        "top_lang":"TypeScript",
        "stars":"60",
        "forks":"129"

    },
    ....
]

To what class it belongs?
Organization
Note

Make all the changes in the github/organization.py file.
Use a private method  __scrape_page to scrape the page.
Include the method in the documentation.md file.
Upload a screenshot with the PR, demonstrating the method.

Please assign me this issue under JWOC

Sure @ayushanand308, go ahead.

On it?

Hi @nikhil25803 is this issue still open. Please assign it to me.
Thank you !!

@nikhil25803  I am almost done working on it and I will be soon making a PR.

@nikhil25803  I have made a PR. Can you review and tell me if you want any changes?


Incorrect import statements in notebooks/attack_membership_inference.ipynb

Describe the bug
Incorrect import statements in notebooks/attack_membership_inference.ipynb
To Reproduce
Steps to reproduce the behavior:
Start the notebook notebooks/attack_membership_inference.ipynb
Both "Rule-based attack" and "Train attack model" fail to run due to import errors.
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-3-e4caf591daac> in <module>()
      1 import numpy as np
----> 2 from art.attacks.inference import MembershipInferenceBlackBoxRuleBased
      3
      4 attack = MembershipInferenceBlackBoxRuleBased(art_classifier)
      5

ImportError: cannot import name 'MembershipInferenceBlackBoxRuleBased'

Expected behavior
Should import the classes and run the code.
System information (please complete the following information):

OS: MacOS
Python version: 3.6.9
ART version or commit number: 065ac24e7f5ec124f6cfe39ce21f085f4c87a401
TensorFlow / Keras / PyTorch / MXNet version: TensorFlow 2.4, Keras 2.4.3 torch 1.6.0+cu92, MXNet 1.6.0

I have an incoming pull request for this.

Hi @evansakmar Thank you very much, that's really great!


Fix InfoBlox NIOS DNS for CIM compliance

As per current documentation (https://splunk.github.io/splunk-connect-for-syslog/main/sources/vendor/InfoBlox/) InfoBlox NIOS DNS data is not CIM compliant and the current recommendation is to use Splunk Stream (which has not been updated in over a year).
I would like to request that the SC4S team fix the InfoBlox NIOS DNS data to be CIM compliant.

We will review this, SC4S provides metadata for sourcetype, source and addon.

Hi @rjha-splunk, do you have any updates on this?  Do you have more technical details regarding why InfoBlox NIOS DNS data is not CIM compliant at this time?
Thanks!

Hi @jnudell what do you mean by CIM compliance here, SC4S prepares metadata to handover to TAs.
Can you please elaborate it in detail?

The issue is fit for Sales and Support ticket,Unfortunately SC4S team can't extend help here.

Splunk support directed me to post the issue here on GitHub.  Are you indicating that this issue, which is called out in the SC4S notes (https://splunk.github.io/splunk-connect-for-syslog/main/sources/vendor/InfoBlox/) will never be resolved by the SC4S team?

hi @jnudell , i think there is a misunderstanding , the CIM compliance as i mentioned earlier is taken care not by SC4S team but other teams in Splunk, we just provide metadata to the TAs.
We are not sure what is needed to be fixed here, from SC4S side we are preparing data as documented, Please mention the ticket number i will look into and talk to support and as well please let me know your CSM.

Ok, we have spoken and I will pursue this via the TA teams.


Store full entity dfs in separate trie

@kmax12 and @rwedge this resolved the performance issues in a benchmark I wrote, but we should definitely run it against the EntitySets tests as well. I put this in a separate PR to make it easier to see the changes, but it should probably be merged into #572. This makes the logic a bit more complicated, so let me know if anything needs to be clarified.
If there is an aggregation of a uses_full_entity feature the aggregation
should not be calculated on the full entity. Previously because we only
had one set of dfs this was not possible.
Now, we always store the "filtered" df in df_trie, and if necessary also
store a full df in large_df_trie.
If any features at a given node require a full df we first calculate
them. Then we extract the filtered df from the result and use this to
calculate any remaining features. Because FeatureSet.uses_full_entity is
True for features which have a dependent uses_full_entity feature the
large df does not need to contain any of the not_full_entity_features.

@rwedge and @kmax12 this required a more substantial change than I expected. The values stored in the feature trie are now 3-tuples of:

A boolean representing whether the full entity is needed for this node. Previously I was inferring this based on whether there are any features which need a full entity, but the full entity might be needed even if this is not the case. For example: if the only target feature is PERCENTILE(MEAN(customers.transactions)) then there are no features on customers, but we still need the full entity so that the every row in transactions can get its relationship variable to the target entity.
A set of feature names representing the features which need to be calculated on the full entity.
A set of feature names which do not need to be calculated on the full entity.

Previously the features were partitioned into those two groups by checking whether any dependents of each feature are uses_full_entity. This is not correct because it does not take into account the path to each feature. For example, if we are calculating two features MEAN(log.value) and CUM_SUM(customers.SUM(sessions.MEAN(log.value))) (see this test), MEAN(log.value) should only be calculated on the full entity when it is on the path through customers. When it is calculated for the target it should only be calculated for the given instance_ids.


Can't add SQL Server Datasource

when I click the Test Button, After a few minutes，it say: " Request faild with http 504 status" ；
and there is not log in the server.
Davinci version: 0.3-beta 8;
MSSqlserver 2018

Which jdbc driver are you using?

lib/mssql-jdbc-7.4.1.jre8.jar    and lib/mssql-jdbc-6.4.0.jre8.jar   ; it doesn't work!
our sqlserver version: Microsoft SQL Server 2016(SP2-CU8)(kb4505830)-13.0.5426.0(X64)

this issue has been soloved after I change the parameter ' spring_datasource_test_on_borrow  ' from true to false.
because in the docker-compose.yml. this parameter has been set to true .
thank @xxxllluuu for help me to test this issue very much.


Kanban board issue

We are two people that work on the Recipe app project.
@SaeqaSultani
@LIBERCOSOFT
The link of the project

Hi @SaeqaSultani
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project with the link to your repository instead of the link to your kanban board. Kindly change the link and make sure your kanban board follows microverse requirements.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @Team
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔Good issue description
Required Changes ♻

[ ] kindly create cards for the following:

Make sure there are no N+1 queries happening.

Create a navigation menu that allows users to open all of the pages you created.

[ ] You are also missing some cards on your board for the technical setup: Technical setup;

Set up the repository on GitHub and use Gitflow
Set up RSpec and Capybara testing libraries

please add it 🤗

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A
Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Approved ✔
Hi @,
Great job, Your project is complete!  There is nothing else to say other than... it's time to close this issue and start working on the project :shipit:
GOOD LUCK 🤞

(Changes Required) Aspects to improve: ♻

N/A

[Optional] suggestions:

N/A

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
**Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear, and please remember to tag me in your question so I can receive the notification**
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


formatting, merging, ocd

formatting
merging back to master

Codecov Report

Merging #280 into master will decrease coverage by 0.12%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master    #280      +/-   ##
=========================================
- Coverage   67.22%   67.1%   -0.13%
=========================================
  Files          22      22
  Lines        1071    1067       -4
  Branches       90      90
=========================================
- Hits          720     716       -4
  Misses        335     335
  Partials       16      16

Impacted Files
Coverage Δ

poseidon/poseidonMonitor/Config/test_Config.py
100% <ø> (ø)
:arrow_up:

...ntrollerAbstraction/proxy/mixins/test_jsonmixin.py
94.73% <ø> (ø)
:arrow_up:

...bstraction/test_NorthBoundControllerAbstraction.py
100% <ø> (ø)
:arrow_up:

...llerAbstraction/NorthBoundControllerAbstraction.py
31.37% <0%> (ø)
:arrow_up:

poseidon/poseidonMonitor/test_poseidonMonitor.py
96.42% <100%> (-0.04%)
:arrow_down:

poseidon/poseidonMonitor/poseidonMonitor.py
41.52% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983f8cc...5b25256. Read the comment docs.


MM-34055 Re-add border to Markdown preview

We switched to using a box-shadow for the post textbox recently, but we had box-shadows disabled for the Markdown preview for some reason, so that caused the border of the Markdown preview to disappear. I can't see any reason why we would've needed to specify that there's no box-shadow for that before, so I just removed the line responsible for it.
Ticket Link
https://mattermost.atlassian.net/browse/MM-34055
Screenshots

Oops :P

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   ba4045c83..fcca17295  cloud        -> upstream/cloud
   0fccbe4d7..ab6be4866  master       -> upstream/master
   47f29f02d..fd59b528f  release-5.34 -> upstream/release-5.34
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
warning: The last gc run reported the following. Please correct the root cause
and remove .git/gc.log.
Automatic cleanup will not be performed until the file is removed.

error: pack-objects died of signal 9
fatal: failed to run repack

Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
warning: The last gc run reported the following. Please correct the root cause
and remove .git/gc.log.
Automatic cleanup will not be performed until the file is removed.

error: pack-objects died of signal 9
fatal: failed to run repack

Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
warning: The last gc run reported the following. Please correct the root cause
and remove .git/gc.log.
Automatic cleanup will not be performed until the file is removed.

error: pack-objects died of signal 9
fatal: failed to run repack

+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#7747-upstream-release-5.34-1617049254
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#7747-upstream-release-5.34-1617049254'
Branch 'automated-cherry-pick-of-mattermost-webapp-#7747-upstream-release-5.34-1617049254' set up to track remote branch 'release-5.34' from 'upstream'.

+++ About to attempt cherry pick of PR #7747 with merge commit ab6be48665de4818707050fcf2056295125f27f2.

error: could not apply ab6be4866... MM-34055 Re-add border to Markdown preview (#7747)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU sass/components/_post.scss
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.


Cannot See Mini Cart on Venia Store on Top Right Corner

I am unable to see the mini cart on top right corner after creating a new project using demo-store.all-0.9.0.zip from latest release here https://github.com/adobe/aem-cif-project-archetype/releases and installing it through package manager in my AEM 6.5. Do I need to install it separately? I am following this integration through https://www.adobe.io/apis/experiencecloud/commerce-integration-framework/getting-started.html

Hi @atif92 to get the shopping cart, checkout etc working you need one extra step. See https://www.adobe.io/apis/experiencecloud/commerce-integration-framework/tutorials.html#!AdobeDocs/commerce-cif-documentation/master/tutorials/03-shopping-cart-dispatcher.md

Also, see https://github.com/adobe/aem-core-cif-components/tree/master/dispatcher
This preconfigured is primary for local development and must be adjusted for your production setup needs.

@mhaack I agree I would need Dispatcher Set Up to route my cart component to Magento, What I was referring to is why the UI itself isnt there, where as the like I shared shows the UI of cart and button to add product to card is atleast there.

The UI (mini cart icon, etc) will only be visible if you have Dispatcher installed and access the demo site via the dispatcher. The cart JS tries to load the shopping cart. These calls will fail without the dispatcher (you can see that in the browser console) and no mini cart icon is rendered.
Hence Dispatcher config is a must, for now, to get it working. (I see in the intro video AEM is accessed via localhost:4502, not sure how this was done, normally the mini cart should not be visible if AEM is accessed directly)

Thanks alot. That helped


Add badges links.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Codecov Report

Merging #26 (33b1864) into main (6583d15) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   98.25%   98.25%
=======================================
  Files           3        3
  Lines         172      172
=======================================
  Hits          169      169
  Misses          2        2
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6583d15...33b1864. Read the comment docs.


Asynchronous Chat

Hello,
First, I would like to express my sincere thanks for sharing your source code.
Currently, I'm using the HemulGM wrapper for OpenAI, and your code will be invaluable as I integrate Mistral into my tests. With the HemulGM code, implementing asynchronous chat functionality is straightforward, as events are triggered when the result is ready. Specifically, these events include:
TOpenAIChat.OnChat: Triggered when the response is complete.

TOpenAIChat.OnBeginWork: Marks the start of the process.
TOpenAIChat.OnEndWork: Indicates the end of the process.
 => These events are particularly useful for displaying a wait cursor or similar indicators during processing

Can we imagine implementing something similar on your side?
Best regards,

Hello,
First and foremost, thank you for your interest in this project. Your request is both insightful and greatly appreciated. I’ll make sure to add it to my list of pending tasks.
Currently, I am waiting for Mistral.AI to release the API extension for agent creation, which is a critical piece that I am eagerly anticipating.
In the meantime, if you’re looking to quickly establish an asynchronous mode, you could implement a "temporary" solution as follows:
Create methods:
procedure MyClass.DoOnWorkStart(Sender: TObject);
…
procedure MyClass.DoOnWorkEnd(Sender: TObject);
…
procedure MyClass.DoOnChat(Sender: TObject);
…

Using the first Chat (non-Stream) example, we can quickly create an asynchronous task as follows:
// system.Threading;

var Task: ITask := TTask.Create(
  procedure()
  begin
    TThread.Synchronize(TThread.Current,
      procedure
      begin
        var Chat := MistralAI.Chat.Create(
          procedure (Params: TChatParams)
          begin
            Params.Model('mistral-tiny');
            Params.Messages([TChatMessagePayload.User(Memo2.Text)]);
            Params.MaxTokens(1024);
          end);
        try
          for var Choice in Chat.Choices do
            Memo1.Lines.Add(Choice.Message.Content);
          DoOnChat(Chat);
        finally
          Chat.Free;
        end;
        DoOnWorkEnd(Self);
      end);
  end);
DoOnWorkStart(Self);
Task.Start;

I am aware that this is only a draft solution. I will dedicate more time to it as soon as I have finished the Wrapper for Delphi, which will allow the use of Anthropic APIs for its models.
Best regards,

Hello,
A new version has been released to handle asynchronous chat (streamed and non-streamed).
Best regards


Evaluation : ldc_sad_hmm is missing

The evaluation script tools/eval.sh needs the repository ldc_sad_hmm (https://github.com/aclew/ldc_sad_hmm). It needs to be cloned manually within the VM in /home/vagrant.
Julien explained me that there was some copyright problems. Should we remove that from the documentation ? Or should we add the git clone in the Vagrantfile ?

Still waiting for LDC to give permissions so we can include it, but until then we don't officially have permission to distribute the ldc_sad_hmm code, so can't include it in the repository. This might be in another Issue, essentially: keep pestering LDC to make their tool open source, so we can include it for public use. Until then we probably need to keep cloning it manually using our 'private' copy https://github.com/aclew/ldc_sad_hmm)

Would it help if I contacted Chris Cieri?  With whom have you been in contact on this so far?
--Brian

On Oct 9, 2018, at 10:54 AM, Eric Riebling<EMAIL_ADDRESS>wrote:
Still waiting for LDC to give permissions so we can include it, but until then we don't officially have permission to distribute the ldc_sad_hmm code, so can't include it in the repository. This might be in another Issue, essentially: keep pestering LDC to make their tool open source, so we can include it for public use. Until then we probably need to keep cloning it manually using our 'private' copy https://github.com/aclew/ldc_sad_hmm https://github.com/aclew/ldc_sad_hmm)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/srvk/DiViMe/issues/47#issuecomment-428224463, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXzuSnu621P7UvLqmFYph6yyGTfEDuhks5ujLiQgaJpZM4XTbfh.

ldc_sad and its eval have been removed


qedf kernel module missing for iscsi

Flatcar Version 2512.2.1
We are trying to install Flatcar on our new kit. We are not able to see our storage through the  host bus adapter because the the HBA kernel module is absent. This does work with redhat.
The old kit was working with Flatcar because it was using qla2xxx

This is with Red Hat

Thank you for your request and please pardon the inconvenience while bringing up your new hardware with Flatcar Container Linux. We'll look into adding the kernel module.

Modules are included in Apha-2605 (released last Thursday) and will undergo the regular stabilisation process.
I'll close this issue, please test with Alpha-2605 and re-open if you encounter any issues.


Fix Unicode string length detection (closes #35)

Possible solution of the issue with sending strings with two- or more byte Unicode characters (#35).
What it does is encode the string with haxe.io.Bytes and use its length instead of the original one. It seems to work properly.

Thank you so much @kotwys ❤ ❤ ❤  Already updated here https://lib.haxe.org/p/colyseus/
From version 0.14 on I'd like to have the process of releasing on GitHub/haxelib automated, it is a bit tedious to do it all manually :) Cheers!

Glad to help 😃


[UX] Check for duplicate wallet/contract window

Each click on a wallet or contract opens a new window without checking if the window was already open.

The default file explorer of VSCode does not seem to open duplicate windows when clicking a file so this feels like deviating behaviour from the default.

I removed the activation event from package.json which was triggering a wallet and/or contract being opened in a new window every time a user clicked on a wallet or contract on the side bar. Now a wallet/ contract opens up only once in the same window, so should be much less clutter. Should double check to make sure that this is what we want.


My % operator somehow is not working

Describe your problem and how to reproduce it:
my answer to the exercise is correct, however when i click on execute the tests it puts me that i did not use the operator% while i did it.
Add a Link to the page with the problem:
https://www.freecodecamp.dev/learn/javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript
Tell us about your browser and operating system:

Browser Name: Lenovo
Browser Version: chrome 83 on windows 10
Operating System: windows 10

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

Hello~!
I was able to reproduce this bug. After some digging, it looks like the % operator test will fail if the line does not end with a ;.
I am not sure if this is considered a bug as ending lines with ; is a good practise, but if there is agreement that this should be changed I believe I can update the test to not require the semi-colon.

ok i will try thanks!

IT WORKED THHHAAANKKKSSS

BRRUUUUH


Brainfeed: a tool for domain experts to find recent and relevant public discourse on topics they are familiar with

Title
Brainfeed
A tool for domain experts to find recent and relevant public discourse on topics they are familiar with
Leaders
Yohan Yee (Mattermost: yohan, Twitter: @therealyohanyee)
Collaborators
Chi-Hsun (Eric) Chang (Mattermost: eric-ch-chang , Twitter: @chchang8305)
Brainhack Global 2021 Event
BrainHack Toronto
Project Description
Brainfeed is a proposed tool that is aimed at scientists to keep track of active and relevant public discussions on topics that they are familiar with. The general idea is that in forums such as Reddit, links to scientific articles are posted and a public discussion often follows; in these discussions there are often questions or misconceptions that may be best clarified by experts. Brainfeed seeks to track these discussions and notify experts when there are discussions/questions that are relevant to them.
Initial development of this project is aimed at tracking neuroimaging-related discussions on Reddit, but this tool could in principle be extended to any scientific field and could also track other forums such as Twitter. Details on getting started, resources, etc... are available in the README.md doc on the project Github page (https://github.com/yohanyee/brainfeed)
Link to project repository/sources
https://github.com/yohanyee/brainfeed
Goals for Brainhack Global
A list of specific goals for this Brainhack, along with future goals, can be found in the Github README.md file.
The general goal for Brainhack Toronto is to lay down the general framework and structure of the project, along with some basic code aimed at the specific goals listed in the README.md file; further development can occur after the event and will be coordinated through a Brainhack mattermost channel (https://mattermost.brainhack.org/brainhack/channels/brainfeed).
Good first issues

issue one: how to best classify posts as being relevant (neuroimaging related) or not?

issue two: how do we structure the post/comment database?

Issue three: what is the most engaging way to display discussions to experts?

Communication channels
For Brainhack Toronto 2021: https://discord.gg/6pq9RgtM
After the event, we will transition to the Brainhack Mattermost channel for further development: https://mattermost.brainhack.org/brainhack/channels/brainfeed
Skills

Python (to scrape public discussions on scientific articles): any skill level
NLP / text classification (to classify if discussions/questions are relevant): any skill level
UX/UI (to display relevant discussions in a meaningful manner): any skill level

Onboarding documentation
See README.md
What will participants learn?
Some skills that may be learned:

web scraping via Python APIs
text mining and classification
interfacing with databases (Firestore database)

Data to use
No response
Number of collaborators
more
Credit to collaborators
Contributors will be listed in a file on Github (probably the README.md using the all-contributors github bot )
Image
Leave this text if you don't have an image yet.
Type
data_management, other
Development status
1_basic structure
Topic
other
Tools
other
Programming language
Python, html_css, javascript
Modalities
not_applicable
Git skills
0_no_git_skills, 1_commit_push
Anything else?
Topic: scientific communication
Things to do after the project is submitted and ready to review.

[ ] Add a comment below the main post of your issue saying: Hi @brainhackorg/project-monitors my project is ready!
[ ] Twitter-sized summary of your project pitch.

Dear @yohanyee Thank you very much for this exciting project. I will make it published but in the meantime, if you would like to add a project-specific image to your issue please drop it in somewhere in the issue we will make it appear alongside this info on our website!
Enjoy your participation to the Brainhack :tada: 🤗

Thanks @complexbrains and @Remi-Gau ! We don't have an image yet, but will add one when we create that and drop it into the issue/notify you.
Twitter summary below:
Want to know when the public is talking about brains, and jump into the discussion? Help us develop Brainfeed: a tool to find and track such discussions


Optimal transport

Codecov Report

Merging #7 (39fbcd4) into master (bb9f43e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            2         2
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9f43e...39fbcd4. Read the comment docs.


Page not found

In Chapter 6 Interacting with Lean under Using the Library, the link in the second bullet https://github.com/leanprover/lean4/tree/master/src/Std leads to a page that is not available.

Fixed in #47, and pushed to the main site sometime last week.


fuelup check

Closes #16
(note: this merges into #62)
Now that we have DownloadCfg in #62 it's much easier to support fuelup check, since all we need to do is to build the cfg and compare it with the current version running on the machine.
Usage
$ fuelup check
forc - update available: v0.14.5 -> v0.15.1
fuel-core - up to date: v0.8.0
fuelup - up to date: v0.1.2

~There is definitely a more elegant way of handling checks - i.e. we shouldn't panic on each command but simply collect the results and print it all at the end. For example, if fuel-core was not installed, fuelup check would panic, but ideally it should do something like this~:
Have since updated this PR by not panicking if the component cannot be found/run, instead showing a not found message. I was wondering if there should be an action message here i.e. if any of forc, forc-fmt, forc-explore, or forc-lsp are missing or outdated, should we add a reminder to do fuelup install? Then again it might be intentionally not updated on purpose (if say forc has a breaking change that breaks a dev's project). Due to this reason I decided not to include this action message.
Also included plugins in the check.
$ fuelup check
forc - up to date: v0.15.1
 - forc-fmt - up to date: v0.15.1
 - forc-explore - update available: v0.12.2 -> v0.15.1
 - forc-lsp not found
fuel-core - up to date: v0.8.0
fuelup - up to date: v0.1.2

I added in checks for plugins as well:
$ fuelup check
forc - up to date: v0.15.1
 - forc-fmt - up to date: v0.15.1
 - forc-explore - update available: v0.12.2 -> v0.15.1
 - forc-lsp not found
fuel-core - up to date: v0.8.0
fuelup - up to date: v0.1.2

Brings up the question of how we should treat the plugins packaged together with forc - should we consider the plugins shipped with forc to just be forc as well? I would assume so and hence in this implementation I indent the checks for the plugins under the check for forc.

Converting back to draft for now since changes from #62 need to be merged here

Updates:

Updated this command to use semver::Version following changes to #62
Updated usages of components to use a struct component containing these constants instead
Moved plugin constants into a similar setup as above

Converting this to a draft and marking this as blocked until #63 is cleared.

Here's what I came up with with the presentation of fuelup check - this is different from rustup check because we want to show forc and fuel-core versions separately within the same toolchain (rustc, cargo, etc. all share the same versioning, which doesn't work for us):

It's a bit verbose/long, especially if we have multiple toolchains, since fuelup check lists all toolchains under /toolchains and checks the versioning for all of them.
This can be shortened however - since the plugin binaries are still packaged together with forc we don't have to show the versioning for the plugins. So we can do something like this as well:

Or if we want to show slightly more info:

I think the last one has the best balance between showing enough info and not stretching the output vertically too much. I'd pick either the last or the first one.
P.S.: I realized after taking the screenshots that I was missing a : after Update available, please pretend it's there 😅

Last one looks good. I'm actually leaning towards the second since the information on the bundled plugins takes up a lot of horizontal real estate. The first definitely has too much redundancy.

Last one looks good. I'm actually leaning towards the second since the information on the bundled plugins takes up a lot of horizontal real estate. The first definitely has too much redundancy.

Agreed on the last one taking too much horizontal real estate as well, leaning towards the second one myself. What about not specifying that they're plugins and just listing them instead?

With that said I think I like the 2nd one more because it's short and sweet and it's implicit that the plugins are packaged with forc anyway, so I'm updating it to that

Maybe add a more verbose option that explicitly lists bundled plugins?


perf: update Incremental Clustering to use pandas dataframe for data processing.

Currently, the input file format for incremental clustering is a CSV file.
Instead of reading this data as a pandas data frame, each line in the CSV file is read separately, and the columns are accessed by integer-based indexing.
This leads to non-vectorizable code and additional nested loops that impact performance. Additionally, this makes the code cluttered and difficult to comprehend.
The task is:

[x]  update the code to use the pandas dataframe as a standardized data format.
[x]  allow vectorized operation on dataframe for improved performance.
[x] add type hints for enhanced readibility
[x] add user based indexing for faster operations

first pass complete

Will open separate issue for testing if required.


EKS (L7) SSL Termination at ELB - Proxy Protocol and HTTP to HTTPS redirection

Describe the bug
I have a working Ambassador setup where I have terminated SSL on the Classic ELB (using ACM certificate). I have also enabled proxy protocol using the ELB annotation but when I enable HTTP to HTTPS redirection, it gets stuck in a https loop.
I also want to have HTTP to HTTPS redirection too along with the proxy protocol. I think I need some options set here but can't figure them out.
To Reproduce
Steps to reproduce the behaviour:

Patch the service

---
apiVersion: getambassador.io/v2
kind:  Module
metadata:
  name:  ambassador
spec:
  config:
    use_proxy_proto: true
    use_remote_address: false
    x_forwarded_proto_redirect: true

---
apiVersion: getambassador.io/v2
kind: Host
metadata:
  name: ambassador
spec:
  hostname: "*"
  selector:
    matchLabels:
      hostname: wildcard
  acmeProvider:
    authority: none
  requestPolicy:
    insecure:
      action: Route
      # action: Redirect # Redirection loop

Expected behaviour
I would expect Ambassador to behave normally and have the HTTP to HTTPS redirection working smoothly :)
Versions (please complete the following information):

Ambassador: v1.12.1
Kubernetes environment: EKS
Kubernetes Version: v1.19.8

Related tickets

https://github.com/datawire/ambassador/issues/1571

please post your service definition

Closing the issue. I have regenerated the manifests using the official link and things worked for me.


How to add custom attributes and options?

In the readme it states:

Attributes and Options: Define custom attributes and options for cart items to handle variations like size and color.

How is this done?

We are adding this feature: https://github.com/binafy/laravel-cart/tree/feat/add-options


fix: [BUG] unsafeClient evaluationOptions vs manifest #425

I should probably add some tests 🙃

I should probably add some tests 🙃

added.


Interactively install Apollo

moving interactive installation to docker compose

push apollo docker image with gpu optimiation build to university repo /openbolty/apollo


Update index.mdx

Description
Noticed this line
import { type SuiClientOptions } from<EMAIL_ADDRESS>should be updated to
import { getFullnodeUrl, type SuiClientOptions } from<EMAIL_ADDRESS>because getFullnodeUrl is used later on.
Recommendation is to update this file to reflect the README https://github.com/MystenLabs/sui/tree/f9dd2b1e12507ee0ba5861ca616fbfe3fadd098d/sdk/dapp-kit
Type of Change (Check all that apply)

[x ] user-visible impact

Thanks for spotting this!  I think there is another PR up with the same fix: https://github.com/MystenLabs/sui/pull/16356


Broken link ()

Found on page:
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-resource-manager/grant-access-to-create-subscription.md
Paragraph:
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-resource-manager/grant-access-to-create-subscription.md#audit-who-created-subscriptions-using-activity-logs
The link behind the text "elevate access" (https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/active-directory/role-based-access-control-tenant-admin-access.md) is broken.
It should point to https://docs.microsoft.com/en-us/azure/role-based-access-control/elevate-access-global-admin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4569359f-ed2e-1c44-1d75-059f21434f50
Version Independent ID: ac69b995-6fc0-903c-d05d-2386b350f2aa
Content: Grant access to create Azure Enterprise subscriptions
Content Source: articles/azure-resource-manager/grant-access-to-create-subscription.md
Service: azure-resource-manager
GitHub Login: @adpick
Microsoft Alias: adpick

@Lemraj Thanks for the feedback! We are currently investigating and will update you shortly.

@Lemraj confirming the broken link has been fixed. Thanks again for catching this.

@femsulu & @BryanTrach-MSFT : This link is still broken!

@Lemraj I just confirmed again, from multiple clients, that the broken link works as expected. Can you send me a screenshot of what you see? Perhaps try deleting cache or using an InPrivate browsing session to see if that helps.

@femsulu I tried that also!
Visit the page:
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/active-directory/role-based-access-control-tenant-admin-access.md
This page is a link found on the page:
https://github.com/MicrosoftDocs/azure-docs/blob/master/articles/azure-resource-manager/grant-access-to-create-subscription.md


GDScript with "$." crashes the editor

Godot version
v4.0.dev.custom_build.7aebb8f81
System information
Windows 10
Issue description
When you start typing $. in the script editor, it throws unhandled exception:
read access violation. p_subscript->base was nullptr. in modules\gdscript\gdscript_analyzer.cpp line 2731
Steps to reproduce
Start the script editor, define any function and try to type $. in function body.
Minimal reproduction project
No response

When writing $. , the GDScript analyzer expects to have an expression like object.attribute because of the dot (Token::PERIOD)
But in this case, the base is $ and it is parsed as a get_node expression on nothing, which means null.
Then later when Godot wants to get the base type, it crashes at gdscript_analyzer line 2731:
if (p_subscript->base->type == GDScriptParser::Node::IDENTIFIER) {

The issue is rather more deeper. The parser should not recognize $. as subscript.

Because of the dot, the parser will go to GDScriptParser::parse_attribute and create a subscript whose base is nullptr:
https://github.com/godotengine/godot/blob/fdccc0b2195813d7874a7d9b97fff46081772e1e/modules/gdscript/gdscript_parser.cpp#L2543-L2570
Here p_previous_operand is indeed null.
Don't know if a subscript is sometimes allowed to have a null base, but if not, another solution would be to stop it here and generate an error.

The parser should generates "illegal node name" error or similar. Fix this on the analyser level is a mistake IMHO.

Indeed, it already does it in parse_get_node:
https://github.com/godotengine/godot/blob/fdccc0b2195813d7874a7d9b97fff46081772e1e/modules/gdscript/gdscript_parser.cpp#L2706-L2707
(the return nullptr will go to p_previous_operand in parse_attribute just after)
But it will still continue to the analyzer layer nonetheless.
Making the fix in GDScriptAnalyzer::reduce_subscript is not wrong too I think.
This method really needs p_subscript->base to be non-null to do its job, then if the base is null, there is nothing to reduce and the method should stop directly. It will make at least this method more robust.

You are a little right, but fix this in the analyser only masks the real problem in the parser. I have no time to analyse the whole parser code, but at firce glance, it requires some parser code refactoring.

I understand the idea, if the error is catched in the first layers, the better it will be.
That's why in parse_attribute, I am wondering if we could return nothing is the base (p_previous_operand) is null. It's just I don't know if a null base could be valid or not...

#50259 , has same issue. Also it has no operator involved just adding a quotation mark makes it crash. I believe that parser shouldn't consider this as an operator so that analyzer need not have to deal with it.
I am going through parser code to understand this better, however, if someone feels that I am totally off track feel free to correct :)

Indeed, they are linked, same reason => the subscript base in null.
Adding a quotation mark ends the string, which make the following text executed as code.
PR #49897 does fix the case describe in https://github.com/godotengine/godot/issues/50259#issue-939117789


introduce  a schema/interface/specification for payload images

introduce a schema/interface/specification for payload images
One goal of the operator is to be runtime agnostic. We want to be able to easily onboard runtimes other than kata-containers.
Currently the controller code is still very specific to kata-deploy. @bpradipt, @fidencio and I brainstormed a bit how we can make it generic. This issue serves to kick off the discussion . We are looking for input from runtime developers and everyone interested.
Given that

runtimes already have a way to deploy on clusters,
we don't want to duplicate installers,

the idea is to offer an interface for runtime installers that is so simple that it can be easily mapped to existing operations.
Via the Custom Resource the following can be specified:

installation type
payload image
operation
volume
hostRequirements

operations
We keep it simple and start with

pre-install
install
uninstall
post-uninstall

payload image
We already have payloadImage defined in our CRD. It should contain binaries, config files etc that are required or the deployment of the runtime. The entrypoint accepts an argument that maps to the operations <pre-install|install|uninstall|post-uninstall|...>
volumes
Installers require access to paths on the host filesystem. Here a set of volumes are configured that are required when running the operations
hostRequirements
We'll use the node-feature discovery operator where possible to check cluster nodes for capabilities that runtimes require the host to have in order to function properly.
For NFD see: https://kubernetes-sigs.github.io/node-feature-discovery/stable/get-started/index.html
example
An example CcRuntime CR definition:
apiVersion: confidentialcontainers.org/v1beta1
kind: CcRuntime
metadata:
  name: ccruntime-sample
  namespace: confidential-containers-system
spec:
  # Add fields here
  runtimeName: kata
  config:
    installType: bundle
    payloadImage: quay.io/confidential-containers/runtime-payload:v0 # installer binary
    operation: <pre-install|install|uninstall|post-unihnstall>
    installVolumes:
      volumeMount:
        - name: some-config-dir
          mountPath: /host/path/to/dir
    hostRequirements:
      nodeSelector:
        feature.node.kubernetes.io/cpu-vmx: 'true'
        ...

Question: what are we missing?

One more thing that came to my mind. How does the installer signal that it's done with installing/uninstalling the runtime on a given node? kata-deploy for example adds a label to the node. I think we should make that configurable in the CcRuntime config as well.

One more thing that came to my mind. How does the installer signal that it's done with installing/uninstalling the runtime on a given node? kata-deploy for example adds a label to the node. I think we should make that configurable in the CcRuntime config as well.

What exactly do you want to make configurable, @jensfr?  The label added or what will be used to notify the installer?
I'd go for one specific format, settle on that, with one specific label.
Having different ways to do that adds more complexity without actually bringing much benefit to the table as, IMHO, the operator should be enforcing a pattern.


KAFKA-8855; Collect and Expose Client's Name and Version in the Brokers (KIP-511 Part 1)

This PR implements the first part of KIP-511, namely:

update the ApiVersionsRequest/Response to the auto-generated ones;
bump the versions of ApiVersionsRequest/Response;
add ClientSoftwareName and ClientSoftwareVersions in the ApiVersionsRequest;
add validation for those two fields and handle error in the client;
implement the proposed fail-back mechanism.

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks, @dajac .  This looks pretty close to being ready to go.  I left a few comments.

@cmccabe Thanks for the review. I have addressed all your comments.

LGTM

retest this please

retest this please

Failing tests
JDK 8 and Scala 2.11

org.apache.kafka.connect.integration.ConnectWorkerIntegrationTest.testAddAndRemoveWorker
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSinkConnector
kafka.api.SslAdminClientIntegrationTest.testCreateTopicsResponseMetadataAndConfig

JDK 11 and Scala 2.12

org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSinkConnector

JDK 11 and Scala 2.13

org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSinkConnector

They are unrelated to the changes made in this PR.

I ran tests locally and got another failing test:

ReassignPartitionsClusterTest. shouldPerformMultipleReassignmentOperationsOverVariousTopics

I wanted to confirm that the failing tests in CI are flaky ones.

Those tests pass for me locally.  Committing

hi my friend,i don't know why you have to "add ClientSoftwareName and ClientSoftwareVersions in the ApiVersionsRequest;"。 It seems that the software version number doesn't work.


Dependency problems?

I was checking this out and it looks pretty neat, but I'm new to golang and don't know the fyne library, but I cloned it and was trying to run it (I'm on a windows system so I had to type the cmds in run manually), but it wouldn't build, and I got this output (in powershell):
PS C:\Users\Xavier\Documents\stuff\textadventureengine> go build
go: downloading fyne.io/fyne/v2 v2.1.2
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c
go: downloading github.com/yuin/goldmark v1.3.8
go: downloading github.com/go-gl/glfw/v3.3/glfw v0.0.0-20211024062804-40e447a793be
go: downloading github.com/fredbi/uri v0.0.0-20181227131451-3dcfdacbaaf3
go: downloading github.com/goki/freetype v0.0.0-20181231101311-fa8a33aabaff
go: downloading github.com/srwiley/oksvg v0.0.0-20200311192757-870daf9aa564
go: downloading github.com/srwiley/rasterx v0.0.0-20200120212402-85cb7272f5e9
go: downloading golang.org/x/image v0.0.0-20200430140353-33d19683fad8
go: downloading github.com/go-gl/gl v0.0.0-20210813123233-e4099ee2221f
go: downloading golang.org/x/net v0.0.0-20210405180319-a5a99cb37ef4
go: downloading golang.org/x/text v0.3.3
package textadventureengine
        imports fyne.io/fyne/v2/app
        imports fyne.io/fyne/v2/internal/driver/glfw
        imports fyne.io/fyne/v2/internal/driver/common
        imports fyne.io/fyne/v2/internal/painter/gl
        imports github.com/go-gl/gl/v3.2-core/gl: build constraints exclude all Go files in<EMAIL_ADDRESS>
Running go run textadventureengine gave me similar output:
PS C:\Users\Xavier\Documents\stuff\textadventureengine> go run textadventureengine
package textadventureengine
        imports fyne.io/fyne/v2/app
        imports fyne.io/fyne/v2/internal/driver/glfw
        imports fyne.io/fyne/v2/internal/driver/common
        imports fyne.io/fyne/v2/internal/painter/gl
        imports github.com/go-gl/gl/v3.2-core/gl: build constraints exclude all Go files in<EMAIL_ADDRESS>
Do you know what I can do to make it work?

I'm also new to opening issues, so if anything could be clarified or I miss the point slightly, please tell me.

@xavier2910 hey! You're fine on the phrasing and all. Unfortunately I started this project a couple years ago and only worked on it for a few days as a way to learn some Go, and hadn't really used Go before that and haven't used it since. I don't really have any insight. Feel free to steal any of the concepts and organization of the project or try forking it and fixing it up, whatever seems best to you. The project when I stopped working on it was very rudimentary and I was just starting to be able to create, write, and read files. The engine overall is not super useful.

Thanks for the prompt answer! I think I'm using a newer version of go, that's the problem. (1.17 vs 1.20) I might fork it.

By the way, do you know if there's a good tool for managing different versions of go? I've worked with things such as ghcup or stack for haskell which automatically install the compiler the project is marked for, and am curious if go has a similar tool available.

Like I said, I don't really have experience with Go in any capacity past a few days a couple years ago, but I would assume that there is, since there's things like that for Haskell like you mentioned or NVM for Node, etc.


Developer documentation for @angular-devkit/schematics is misleading and incomplete

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

schematics
Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
unknown
Description
 A clear and concise description of the problem...
The angular-devkit CONTRIBUTING.md file, explaining how to build and locally install angular-devkit, points to the angular-cli README.md, https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
However, these instructions only include npm linking instructions for angular-cli, not any of angular-devkit.  These instructions do not result in a locally installed schematics command, for instance.
🔬 Minimal Reproduction

Following the instructions at https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
git clone https://github.com/angular/angular-cli.git
yarn
npm run build
cd dist/@angular/cli
npm link
does not result in the schematics command calling the locally built angular-devkit/schematics-cli or use of the locally built angular-devkit/schematics
🔥 Exception or Error

🌍 Your Environment

Anything else relevant?

The modified instructions in https://github.com/angular/angular-cli/pull/15781 work for me to get a local schematics change to work, but I hope there is a simpler way.

I'd prefer that this issue, complete lack of usable instructions for how to build and test the schematics engine/framework, not be conflated with the idea of improving documentation of how to use the existing schematics engine.  For instance, most or all of the examples of schematics I found by googling use and explain chain, the solution for passing a Tree & Rules between schematics #15739, whereas I couldn't find any information at all about how to develop e.g. bug fixes.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent changes.


hq3_2: music room stops playing

final train stops playing when melody is finished :O

random? w/e


NodePattern: Add <> for matching children in any order.

These can be used multiple times in the same sequence as well as
nested.
Limitations: A sequence can only contain a single ellipsis (contained
or not within a <> sequence).
Other implementation changes:

Captures are now an array (i.e. capture0 is now captures[0])
Temporary variables like temp1 were renamed to node1.
Reading tokens until a delimiter was factorized into tokens_until

Example of produced code:
# Pattern: (hash <(pair (:sym $_)) $...>)

(captures = Array.new(2)) && node0.is_a?(RuboCop::AST::Node) &&
node0.children.size >= 0 &&
node0.is_a?(RuboCop::AST::Node) && node0.hash_type? &&
(captures[1] = []) && node0.children[0..-1].each_with_object({}) { |child1, matched2|
  case
    when !matched2[0] && child1.is_a?(RuboCop::AST::Node) &&
child1.children.size == 1 &&
child1.is_a?(RuboCop::AST::Node) && child1.pair_type? &&
(node3 = child1.children[0]).is_a?(RuboCop::AST::Node) &&
  node3.children.size == 1 &&
  node3.type == :sym &&
  (captures[0] = node3.children[0]; true) then matched2[0] = true
      else captures[1] << child1
    end
}.size == 1

Fixes #6841

Fixed a few small things and even found a strange JRuby bug, all green now.

Fantastic work, @marcandre!

Please correct me if I'm mistaken, but it seems there's a minor mistake in the description:
# Pattern: (hash <(pair (:sym $_)) $...>)

should probably be:
# Pattern: (hash <(pair (sym $_)) $...>)

@pirj Both are valid and should give you similar results. Using :sym will generate node.type == :sym (note: only when it is at the beginning of a sequence!), while sym will generate node.sym_type? (in any position), and unless it is redefined by the user, sym_type? returns type == :sym :-)
HTH

PS: I believe you are right though that (sym ...) is probably more usual and better than (:sym ...). I modified my description above accordingly.

What makes this change double as awesome is that it also works for matching arguments, not only in a hash. 💯


Misssing Chinese translation docs: https://kubernetes.io/blog/2022/05/05/volume-expansion-ga/

This is a Bug Report
Problem:
misssing Chinese translation docs: https://kubernetes.io/blog/2022/05/05/volume-expansion-ga/
Proposed Solution:
add Chinese translation docs in website Kubernetes Blog
Comments
/language zh
/assign

/triage accepted

already fix


Fix h265 HVCC format(mkv file) decode issue

fix h265 extra data cannot parsed properly issue

+1

Hi popkartyeah:
Please get latest upstream code and sqash you commit to one.
thanks.

+1， @lizhong1008,please help to review this

+1

+1

lgtm :+1:

thanks Jun and Yun


Disable remote issue tracking by default.

Replaced by https://github.com/almighty/almighty-core/pull/1447

Codecov Report

Merging #1446 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
- Coverage   60.46%   60.33%   -0.13%
==========================================
  Files         117      117
  Lines       11108    11108
==========================================
- Hits         6716     6702      -14
- Misses       3740     3753      +13
- Partials      652      653       +1

Impacted Files
Coverage Δ

main.go
0% <0%> (ø)
:arrow_up:

remoteworkitem/github.go
77.14% <0%> (-22.86%)
:arrow_down:

models/transaction.go
50% <0%> (-20%)
:arrow_down:

remoteworkitem/scheduler.go
53.65% <0%> (-9.76%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7917ac...24ad5d2. Read the comment docs.


Feature Request: Expose all members of high-level objects

I notice that the exposition of members of high-level objects is still quite incomplete. This leads to situations where the user is left clueless, e.g. when trying to retrieve environment parameters after a simulation (or estimation) from the environment.
One example I can give is the body object, which does for example not have its radiation_pressure_interface member exposed. I am sure there are many more instances of this.
There are more issues with this, namely that there is no RadiationPressureInterface class exposed in python, such that - even if the class was exposed as a member of body - the members of RadiationPressureInterface (or rather the parameters defining the instance of that class) are not accessible to the tudatpy user.
A good example of this is the aerodynamic_coefficient_interface, which is given as a member of the body class, but the AerodynamicCoefficientInterface class itself is inaccessible to the tudatpy user because it has not yet been exposed.
So in short: If you want to improve tudatpy and the docs that come with it (nicely linking all the connections between objects and their members), a makeover from this "completeness" point of view could be a good start.

There are more issues with this, namely that there is no RadiationPressureInterface class exposed in python, such that - even if the class was exposed as a member of body - the members of RadiationPressureInterface (or rather the parameters defining the instance of that class) are not accessible to the tudatpy user.
Another example of this is the aerodynamic_coefficient_interface, which is given as a member of the body class, but the AerodynamicCoefficientInterface class itself is inaccessible to the tudatpy user because it has not yet been exposed.

I can take care of this, little by little.
I do encourage anyone to drop new elements in this thread when they see that something is still missing, using checkboxes for each element to be exposed so that I can follow whether something has been done already or not.
(cc @DominicDirkx @FilippoOggionni @geoffreygarrett)


Can't connect

I always encountered an error window when i try to connect/open agar.io

You mean an error window which tells you to update to latest version?

<3


auto scheduler/Ansor auto_scheduler.auto_schedule do not auto exit

when I use auto scheduler to tune GPU batch_matmul or CONV2D program, the python did not quit even if the tune auto_scheduler.auto_schedule call is finished. I must use ctrl +c to manually stop the search thread.

the program is just like this:

found a solution: call os._exit(os.EX_OK)  after auto_scheduler.auto_schedule()

Did you del measure_ctx at the end, as suggested by the tutorial?

We should call del measure_ctx explicitly.
We do this in the last section of the tutorial. But it is not emphasized in the tutorial.
@luchangli03 Would you mind sending a PR to improve the tutorial?

#6660


Please add Docker support？

Could you please add Dockerfile and some use info.

https://github.com/aoliynik/oracle-exporter

Great work


Update prometheus documentation

Proposed Changes

(Describe the changes and rationale behind them)

Small improvements to the prometheus documentation.
Related Issues

(Github link to related issues or pull requests)

Thanks for the PRs!
However, I've decided to no longer pursue the further development of this add-on. Up until now it has only been in edge, and was never released stable.
Feel free to pick up the sources to publish your own.
../Frenck


Must set AutoSize to false before setting Width

Must set AutoSize to false before setting Width

I get this exception a lot now when trying to upgrade TGD.  Is it a temporary measure?
It seems like this is an attempt to prevent two conflicting sizing mechanisms (auto and Width).  If it is here to stay then why instead not just make AutoSize a Dim e.g.
myView.Width = Dim.AutoSize()
// Or
myView.Width = Dim.AutoWidth(myView)
// Or
myView.Width = Dim.AutoSize(myView,width: true)

If it were a Dim then it wouldn't be possible to set both, Width would either be auto or other.
Maybe a View has to implement IAutoSizeable or something to support this approach.

This is temporary, but only because AutoSize is going away once I finish Dim.Auto.
The reason this is in there now is before AutoSize was not deterministic w.r.t. when/where Height/Width got set.
I refactored the code in #3202 to simplify it ahead of finishing Dim.Auto. To make it all understantable I removed all code that tried to allow changes to Width/Height work (it never could be cause of race conditions).
Before setting those properties if AutoSize is on was supposed to work, but didn't really.
Now setting those properties if AutoSize is on is an error.

This is temporary, but only because AutoSize is going away once I finish Dim.Auto.

So the new way to autosize is going to be Dim.Auto? Maybe the way for me to progress here would be to just set AutoSize to false anywhere I am setting a Dim property or creating a View.

This is temporary, but only because AutoSize is going away once I finish Dim.Auto.

So the new way to autosize is going to be Dim.Auto? Maybe the way for me to progress here would be to just set AutoSize to false anywhere I am setting a Dim property or creating a View.

The only built-in views that enable AutoSize = true are Button and Label.

This is temporary, but only because AutoSize is going away once I finish Dim.Auto.

So the new way to autosize is going to be Dim.Auto? Maybe the way for me to progress here would be to just set AutoSize to false anywhere I am setting a Dim property or creating a View.

The only built-in views that enable AutoSize = true are Button and Label.

So we should set AutoSize to false prior to adjusting Height or Width of either of these elements? My entire application locks up if I tinker with an element's height or width it seems.

This is temporary, but only because AutoSize is going away once I finish Dim.Auto.

So the new way to autosize is going to be Dim.Auto? Maybe the way for me to progress here would be to just set AutoSize to false anywhere I am setting a Dim property or creating a View.

The only built-in views that enable AutoSize = true are Button and Label.

So we should set AutoSize to false prior to adjusting Height or Width of either of these elements? My entire application locks up if I tinker with an element's height or width it seems.

Correct.


Publish the 2022 Cilium security audits

Fixes: #23791
Because Sphinx is the way that it is, I had to add some logic to force newlines between file downloads. Also because reST gonna reST, I had to leave whitespace before each newline in order to mollify the linter.

The result is pretty OK.

Note: You can do “quote reply” by clicking on the ellipsis menu of a comment to cite the previous message, which should be easier to follow than editing my own messages :)

Maybe a naive question, but why not just use a regular list?

~The directives fail to render when they're bulleted.~ Bullets aren't enough to force newlines.

You need a blank line between your paragraph and the list items, otherwise it's all part of the same paragraph:

    The 2022 security audits for Cilium are available:

    - :download:`Cilium Security Audit 2022 <audits/CiliumSecurityAudit2022.pdf>`
    - :download:`Cilium Fuzzing Audit 2022 <audits/CiliumFuzzingAudit2022.pdf>`

Also, would it make sense to have a page dedicated to audits?

I thought about this. I'm open to it, but like I think you're saying, nothing feels quite right. thinking
UPDATE: Maybe a page banner limited to pages in the security/ path?

Could work, although I'm not sure it deserves this much attention (and not sure if worth spending time on how to set up the banner for some pages only - although I think Sphinx allows it rather easily). Your call

Note: You can do “quote reply” by clicking on the ellipsis menu of a comment to cite the previous message, which should be easier to follow than editing my own messages :)

Is there any notification advantage? What's the benefit to quoting that specific way?

You need a blank line between your paragraph and the list items, otherwise it's all part of the same paragraph:

So it does. I'll add a commit for code review.

Your call

Let's do it this minimal way and observe how much traffic we get.

Note: You can do “quote reply” by clicking on the ellipsis menu of a comment to cite the previous message, which should be easier to follow than editing my own messages :)

Is there any notification advantage? What's the benefit to quoting that specific way? It's not a hardship for me to select and copypaste as opposed to selecting and making GH copypaste. :-)

Oh sure that works, too. No notification advantage. My point was simply that any of those is better than answering inside someone else's post, because the latter makes it harder to follow the conversation.

You need a blank line between your paragraph and the list items, otherwise it's all part of the same paragraph:

So it is. I'll add a commit for code review.

Thanks! Would you mind squashing these three commits together, please?

Your call

Let's do it this minimal way and observe how much traffic we get.

Sounds good to me :)

My point was simply that any of those is better than answering inside someone else's post, because the latter makes it harder to follow the conversation.

I still don't follow. Are you saying you would prefer quoting an entire paragraph rather than only enough of a line to establish reference?

Thanks! Would you mind squashing these three commits together, please?

Done!

Doc change only and passing the relevant workflows, this is ready to merge.

I mean that your did your first reply on this thread not by quoting, but by editing my message directly:

Oh shoot, I'm so sorry about that, @qmonnet! I didn't even catch that I'd done it, so thank you for pointing it out. 😳

Oh shoot, I'm so sorry about that, @qmonnet! I didn't even catch that I'd done it, so thank you for pointing it out. :flushed:

I thought it was intentional at first, but figured that after all it had to be an accident :smile: All good, and apologies for the confusing discussion - let's move on! :rocket:


storage-options.md needs updating

This article is too old. Several aspects need to be updated.
For example the ultra SSD regions are now not only in East US 2.
In addition to LRS, ZRS, GRS, now we have GZRS etc..
This is a great article but lack of updating.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3acd2fd4-b22c-5c11-e891-cc4993d9891e
Version Independent ID: 1acbff98-4a94-53f5-dd45-8f22637602b4
Content: Review your storage options - Cloud Adoption Framework
Content Source: docs/ready/considerations/storage-options.md
Service: cloud-adoption-framework
Sub-service: ready
GitHub Login: @BrianBlanchard
Microsoft Alias: brblanch

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 403280

It appears this was addressed some time ago.  If help is still needed, please feel free to re-open with additional details.


Misc small changes to libzbc/lib

I annotated the ZBC_LOG_ERROR commit with a list of calls to zbc_error() that should be considered for a change to a different error level, such as WARNING or INFO or DEBUG.

David,
I manually pulled and applied all your patches with the exception of the patch "reorder ZBC_LOG_ERROR above ZBC_LOG_WARNING". I did not apply it because warning messages are for critical conditions (invalid drives or unexpected SG errors). In that view, enabling only these messages make sense without the user getting also (potentially) a lot of "normal" error messages due for instance to the system state (no memory etc). The WARNING level should really be called "alert" or "critical" to be more explicit.
Thanks !


github actions fixes

Run action-updater on our CI yml file. It will fix the issue with API rate limit (which is due to setup-ffmpeg, as well as the warnings about set-output and nodejs versions

note that action-updater apparently grabbed v1.1.0 for setup-ffmpeg, so make sure to set it to v2


Add placeholder DefineSection method.

This enables 2.0.0 code generation to not error.

aspnet/Razor#1254

@Eilon I good to get this in?


Shaft displacement seems too high on static analysis

I was looking at our tutorial and I think the values for displacement on the static analysis seem too high.

Can you confirm these values @rodrigomoliveira1 ?

Because it's multiplied by 1000.
When I removed the units from the plot graphs, I should've removed this too.
It was supposed to convert from meters to milimeters. So, actually the displacement is 0.000746

PR #313 closes this issue


Add instructions for cloning and debugging

Add some instructions for getting the latest source code from the master branch.
Also add a link to some instructions for how to debug the compiler.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ScottHutchinson sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @ScottHutchinson


Cannot modify header information

Hi all,
Thanks for this great auth you are providing. I like it a lot but now I am facing some issue and I cannot solve them after 2 days of sleepless work.
PHP Version 7.0.33
Warning: Cannot modify header information - headers already sent by (output started at /home1.../login.php:1) in /home1/....vendor/delight-im/auth/src/Auth.php on line 78
and after that when a successfull login happens I have:
Warning: session_regenerate_id(): Cannot regenerate session id - headers already sent in /home1/..../vendor/delight-im/cookie/src/Session.php on line 66
and again ...
Warning: Cannot modify header information - headers already sent by (output started at /home1/...../login.php:1) in /home1/.../login.php on line 175
I have to admit thay my dumb host provider changed something and it is no longer working.
What I tried is:

Check the  for balnk spaces -> no result
remove line 78 on Auth.php -> noresult
Pray for your help :)

I think the provider won't let me modify the http.conf as mentioned here: https://github.com/delight-im/PHP-Auth/issues/77
Please help ....

Update...
After finding a damned  at the beginning of my login page I landed to:
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 78
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 83
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 85
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 88
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 89
Warning: Cannot modify header information - headers already sent by (output started at /home1/..../index.php:1) in /home1/....../vendor/delight-im/auth/src/Auth.php on line 90
Location: https://..mywebsite../dashboard.php
Warning: Cannot modify header information - headers already sent by (output started at /home1/.../index.php:1) in /home1/.../index.php on line 31

Partial fix is removing the   echo ("$headerusl"); from my index.php but now when I log out:
Fatal error: Uncaught Delight\Auth\HeadersAlreadySentError in /home1/..../vendor/delight-im/auth/src/Auth.php:550 Stack trace: #0 /home1/...../vendor/delight-im/auth/src/Auth.php(518): Delight\Auth\Auth->setRememberCookie(NULL, NULL,<PHONE_NUMBER>) #1 /home1/..../vendor/delight-im/auth/src/UserManager.php(404): Delight\Auth\Auth->deleteRememberDirectiveForUserById(69) #2 /home1/.../vendor/delight-im/auth/src/Auth.php(430): Delight\Auth\UserManager->forceLogoutForUserById(69) #3 /home1/.../User_Logout.php(22): Delight\Auth\Auth->logOutEverywhereElse() #4 {main} thrown in /home1/.../vendor/delight-im/auth/src/Auth.php on line 550

I don’t think that other issue (which you referenced in your first message) is related.
Why would you want to change anything in your server configuration?
Removing random lines from your own application code or from this library doesn’t seem like a proper solution, either.
Instead, you need to fix the actual problem, which should be pretty easy to find:
Somewhere before you create an instance of Auth or before you call methods on that instance, you are already sending output to the client, i.e. text or data.
The issues https://github.com/delight-im/PHP-Auth/issues/26 and https://github.com/delight-im/PHP-Auth/issues/44 and https://github.com/delight-im/PHP-Auth/issues/143 are related, but it’s not always leading or trailing whitespace, it can be visible text as well.


Word count - page is annoying

It keeps updating itself after I delete it

https://user-images.githubusercontent.com/7611700/224320429-10cdaaf7-9bdb-4ad9-96ee-361c88d6998d.mp4

As the video shows, it's really difficult to delete it.

Logseq: 0.8.18
macOS: 13.2.1

Should be fixed in the latest version.

Should be fixed in the latest version.

Thanks.

Sorry for the late response. Been busy at work. Can you try v2.4.4. Caveat is the count needs to be in the first block (like how you are doing in your example).

https://user-images.githubusercontent.com/7611700/228141022-e470e21c-f94d-41b3-bde3-b231bb510237.mp4
I'm using 2.4.7, and it seems all fine. Just one little question: why does the second word counter not work?

Thanks a lot!