AI Services: a way to dynamically switch models

Discussed in https://github.com/langchain4j/langchain4j/discussions/1834

Originally posted by devcxl September 25, 2024
I have now stored the intelligent agent model and prompt word configuration in the database, along with some other parameters. Can someone tell me how to dynamically switch models during program runtime, similar to a dynamic switching tool?

@langchain4j  The change "AI Services: a way to dynamically switch models" will be merged？It's very useful when I need to create a model with a custom header, whitch the values come from the http request.


The file, val_seen_instrs.json, is not provided.

Hi,
The FAO dataset does not provide the file, val_seen_instrs.json, which is needed to run the given code for agent training. Could you please provide it?
Thanks.

@chenguanqi Hi, did you solve this issue? How did you get the val_seen_instrs.json file?


Remove SSH keys from any shipped image

We should by default remove any ssh keys generated during the image build process.  They should be regenerated on first boot of the real hardware, but to ensure the same keys are not ever used on multiple systems these should be erased just in case.

Fixed by f437f9763be558ab6d78746f4c65546cb049ea98


doc/example/pre-processing updates for v2.5.0 Part1

Part 1
-[x] improve tc track pre-processing script for obs
-[x] updates new data to all machines
-[x] doc updates
Part 2
-[] example run scripts/tutorial updates
-[] expected image updates
closes #459

Hey Tom, would you help review this PR? I will make another PR for example run script changes, that are outside of acme_diags/


mlx_lm.lora need an option to set --eos-token

Hi,
Please help to add an option "-eos-token" to run a LORA fine-tuned Qwen llm with mlx_lm.lora.
Thanks,
Nan

If I used the fused model with mlx_lm.generate, I found it cannot answer questions with the training datasets, but it works with mlx_lm.lora with the adapters.npz. Thanks.

If I used the fused model with mlx_lm.generate, I found it cannot answer questions with the training datasets, but it works with mlx_lm.lora with the adapters.npz. Thanks. Are there any options I need to modify for running the mlx_lm.fuse ?

Yeah, a fused model will experience performance degradation due to the quant-dequant operation. Therefore, making the generate command to be able to load the base model and adapters would be a better solution.

If I used the fused model with mlx_lm.generate, I found it cannot answer questions with the training datasets, but it works with mlx_lm.lora with the adapters.npz. Thanks. Are there any options I need to modify for running the mlx_lm.fuse ?

Yeah, a fused model will experience performance degradation due to the quant-dequant operation. Therefore, making the generate command to be able to load the base model and adapters would be a better solution.

Thanks.

Hi!
Is there a benchmark to evaluate the perplexity degradation for quantization?


Git is removed as part of build dependency

Git is required when pip installing packages(requirements) that are pointing to a github location. This is not possible right now as git is removed in the Dockerfile as its part of build dependency. Installing git later on is a pain as we have to switch the user to root and install it and then create another image.
Or is it expected that the users who require other dependencies, fork the repo ?

I recommend creating your own repo with a Dockerfile that extends from this one, switching to ROOT to make changes then back to AIRFLOW.
It may seem like work but realistically you will want to install a range of extras beyond just git as you start using Airflow, for example a hook that pulls git automatically.
FROM puckel/docker-airflow
USER root

...

USER airflow
ENTRYPOINT ["/entry.sh"]

In my opinion the use case of "I am new to airflow and want to install my own python package from github via requirements.txt" should not require forking the dockerfile.
Including git on the base image will fix this with minimal cost to those not using git.


Passing Option<ImportedType> to host leaks ImportedType

This leak happens here where our binding instruction generation doesn't account for the fact that it needs to free the table index slot.

Fixed in https://github.com/rustwasm/wasm-bindgen/pull/1882


[BEAM-7005] gbk streaming load tests

It's a clone of my other PR made to check if phrase triggering is consistent in failing to launch my load tests

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run seed job

Run Load Tests Java GBK Streaming Dataflow

Phrase triggering here does not work, closing


[wast] Rename extern.internalize and extern.externalize

The following instructions were renamed in wasm-gc (https://github.com/WebAssembly/gc/pull/447):
extern.internalize -> any.convert_extern
extern.externalize -> extern.convert_any

The tests should be fine (hopefully) once this PR is merged: https://github.com/WebAssembly/testsuite/pull/70

Thanks! With that merged you should be able to include the submodule update as part of this PR

I had to update the submodule, and the snapshot files as well...
Sorry, this PR turns out to bet more complex than expected.


VS Code not responding (V>=1.54)

Since version 1.54, VS Code does not respond after launching.
The welcome page comes up to the screen but no buttons are clickable or highlighted when the cursor moves over it. The only thing i can do is close the window and have the warning : "VS Code does not respond"
Please find attached the output from running "code --verbose" : log.txt
VS Code version : 1.54
No extensions installed
System Info :
OS : CentOS Linux 7 (64-bit)
Proc : Intel Xeon CPU E5-1603 0 @ 2.80GHz × 4
Graphics : Quadro 600/PCIe/SSE2
RAM : 8Go
GNOME Version 3.22.2

@deepak1556 I'm seeing
Error: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /d/msabathi/TÃ©lÃ©chargements/VSCode-linux-x64/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node)

a lot in the log file

/duplicate https://github.com/microsoft/vscode/issues/115784
Please install gcc-5 or higher as a workaround.


Integration test for node selection (PR)

Description:

Related issue(s):
Fixes: https://github.com/hashgraph/hedera-sdk-cpp/issues/167
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Hey @deyanzz what's going on with this PR? It was opened a while ago but I'm not sure if it's complete/ready to review

Hey @deyanzz what's going on with this PR? It was opened a while ago but I'm not sure if it's complete/ready to review

Yes, I was hanging around with this PR for too long. I was wondering how exactly to implement the algorithm for node selection. I was searching for a similar tests in the Java SDK, but I found only one test to change the network in ClientTest.java.
Unfortunately, I wasn't able to find any kind of integration test for node selection in the JavaScript SDK.
Definitely, it's better to start a discussion in this PR to think about the best algorithm for node selection.

Hey @deyanzz what's going on with this PR? It was opened a while ago but I'm not sure if it's complete/ready to review

Yes, I was hanging around with this PR for too long. I was wondering how exactly to implement the algorithm for node selection. I was searching for a similar tests in the Java SDK, but I found only one test to change the network in ClientTest.java. Unfortunately, I wasn't able to find any kind of integration test for node selection in the JavaScript SDK.
Definitely, it's better to start a discussion in this PR to think about the best algorithm for node selection.

The algorithm is already implemented in Network::getNodeAccountIdsForExecute(), the tests just need to make sure that correct nodes are picked. I'm thinking for now it may be best to wait to implement these tests after we are able to simulate node connectivity behavior (i.e. we're able to control multiple nodes in a local setup and are able set them to be healthy/unhealthy). Having this will allow us to test the full breadth of node selection. I'd recommend closing this PR for now and putting this task on the back burner until we have that functionality, which I believe will be a part of the FST tool that the hedera-local-node team is working on at the moment.

@deyanzz are you good if I close this for now?

@deyanzz are you good if I close this for now?

Sorry for my late response. I'm preparing a commit, where will introduce a new test similar to setNetworkWorks from the Java SDK.
Also, I've done some minor refactoring for ClientIntegrationTest.

With commit 191d6506134a21971575ac68acf8da885625be1b I moved all of the unit tests for min & max backoff time into ClientTest.
Also, I'm suggesting to add a new integration test SetNetworkIsWorkingCorrectly in ClientIntegrationTest.
Created new issue #522  to track missing integration test for node selection.


Malayalam Translation Progress

For New Translators
To translate a page:

Check that no one else has claimed your page in the checklist and comments below.
Comment below with the name of the page you would like to translate. Please take only one page at a time.
Clone this repo, translate your page, and submit a pull request!

Before contributing, read the glossary and style guide (once they exist) to understand how to translate various technical and React-specific terms.
Please be prompt with your translations! If you find that you can't commit anymore, let the maintainers know so they can assign the page to someone else.
For Maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:
- [ ] Some Page (@exampleusername) #12345

When PRs are merged, make sure to mark that page as completed like this:
- [x] Some Page (@exampleusername) #12345

This ensures your translation's progress is tracked correctly at https://translations.react.dev/.
Main Content
To do before releasing as an "official" translation. Please translate these pages first.
Note that each section has an index page, which needs to be translated too.
Learn React

[ ] Quick Start

[ ] Tutorial: Tic Tac Toe
[ ] Thinking in React

[ ] Installation

[ ] Start a New React Project
[ ] Add React to an Existing Project
[ ] Editor Setup
[ ] React Developer Tools

[ ] Describing the UI

[ ] Your First Component
[ ] Importing and Exporting Components
[ ] Writing Markup with JSX
[ ] JavaScript in JSX with Curly Braces
[ ] Passing Props to a Component
[ ] Conditional Rendering
[ ] Rendering Lists
[ ] Keeping Components Pure

[ ] Adding Interactivity

[ ] Responding to Events
[ ] State: A Component's Memory
[ ] Render and Commit
[ ] State as a Snapshot
[ ] Queueing a Series of State Updates
[ ] Updating Objects in State
[ ] Updating Arrays in State

[ ] Managing State

[ ] Reacting to Input with State
[ ] Choosing the State Structure
[ ] Sharing State Between Components
[ ] Preserving and Resetting State
[ ] Extracting State Logic into a Reducer
[ ] Passing Data Deeply with Context
[ ] Scaling Up with Reducer and Context

[ ] Escape Hatches

[ ] Referencing Values with Refs
[ ] Manipulating the DOM with Refs
[ ] Synchronizing with Effects
[ ] You Might Not Need an Effect
[ ] Lifecycle of Reactive Effects
[ ] Separating Events from Effects
[ ] Removing Effect Dependencies
[ ] Reusing Logic with Custom Hooks

API Reference

[ ] react: Hooks

[ ] useCallback
[ ] useContext
[ ] useDebugValue
[ ] useDeferredValue
[ ] useEffect
[ ] useId
[ ] useImperativeHandle
[ ] useInsertionEffect
[ ] useLayoutEffect
[ ] useMemo
[ ] useReducer
[ ] useRef
[ ] useState
[ ] useSyncExternalStore
[ ] useTransition

[ ] react: Components

[ ] <Fragment> (<>)
[ ] <Profiler>
[ ] <StrictMode>
[ ] <Suspense>

[ ] react: APIs

[ ] createContext
[ ] forwardRef
[ ] lazy
[ ] memo
[ ] startTransition

[ ] react-dom: Components

[ ] Common (e.g. <div>)
[ ] <input>
[ ] <option>
[ ] <progress>
[ ] <select>
[ ] <textarea>

[ ] react-dom: APIs

[ ] createPortal
[ ] flushSync
[ ] findDOMNode
[ ] hydrate
[ ] render
[ ] unmountComponentAtNode

[ ] react-dom/client: Client APIs

[ ] createRoot
[ ] hydrateRoot

[ ] react-dom/server: Server APIs

[ ] renderToNodeStream
[ ] renderToPipeableStream
[ ] renderToReadableStream
[ ] renderToStaticMarkup
[ ] renderToStaticNodeStream
[ ] renderToString

Navigation and UI
We suggest to leave most of the UI translation until the end. We plan to do some invasive changes to the website folder layout and components, so postponing this until your translation is almost complete would make it easier to merge the changes from our side later. It might make sense to translate the homepage above the fold early, but leave the rest for later. As individual pages get translated, you can change the page titles in the corresponding sidebar files. Finally, when you're translating the navigation, make sure to test both desktop and mobile layouts.

[ ] Homepage (currently in HomeContent.js)
[ ] Sidebars (currently in src/sidebar*.json)
[ ] Top-level navigation (currently in TopNav.tsx)

When You're Ready...
After everything above is translated, add your language to deployedLanguages in Seo.tsx of the original reactjs/react.dev repository.
Secondary Content
These API pages should ideally be translated too, but they're less urgent and can be done after the others:

[ ] Legacy React APIs

[ ] Children
[ ] cloneElement
[ ] Component
[ ] createElement
[ ] createFactory
[ ] createRef
[ ] isValidElement
[ ] PureComponent

Optional Content
These aren't the main translation targets, but if you'd like to do them, feel free to expand the list to include their subpages:

[ ] Community
[ ] Blog
[ ] Warnings

Maintainer List
This translation is maintained by:

@adarshm07
@asimkt

If you want to become a maintainer, ask them to add you. If the original maintainers are no longer responsive, raise an issue in the main translations repository.

I would like to take up the translation of the page Describing the UI/ Your First Component

@JACOBIN-SCTCS Please share your PR.
@gaearon I will take care of updating the issue at https://github.com/reactjs/ml.react.dev/issues/2. Could you please close this issue.

@asimkt I think I do not have permission to close this issue. can you do that

We will wait for @gaearon to do that. Meanwhile we can move the discussion to #2

Thanks @gaearon.
Yes, I didn't have edit access to update this issue since I missed the invite. So I checked some other repo, saw people creating another issue, and followed suit.
I've accepted the invitation and closed the other issue now.

Hi, I would like to translate the Installation page.

@dev-thakku Done. Please share your MR shortly.

@dev-thakku Done. Please share your MR shortly.

Could you please check the PR #6?

Hi @gaearon
I am interested in translating Adding Interactivity and would like to take up the task.

Hey @Amjad-RA Please free to contribute and create an MR as mentioned as per the documentation. Let me know if you need any help. If you reply with a confirmation I will update the checklist.

Hey @Amjad-RA Please free to contribute and create an MR as mentioned as per the documentation. Let me know if you need any help. If you reply with a confirmation I will update the checklist.

@asimkt  Please update the checklist and lock the block

Hello @asimkt, based on our previous conversations in the old PRs, I have concluded that we need to create documentation for beginners who may have limited exposure to English and programming terminologies. Therefore, we should use simple Malayalam and focus on explaining things in a way that a non-technical person can easily understand, rather than just providing a word-by-word translation. Do you agree with this approach?
I also have a suggestion. If possible, we can create and maintain a glossary for common terminologies. This will make the documentation more readable and consistent.
eg:-
User - ആപ്പ് ഉപയോഗിക്കുന്ന ആൾ/ ഉപഭോക്താവ് / യൂസർ -(This is just an example. We need to discuss and finalize the most appropriate wording.)

@Amjad-RA Totally agree on this point. 🙌
Let's create a glossary. I'm only curious about the timing of when to create. Sharing some thoughts: This is the current status of documentation for reference.

Here, I've used common terms like components, prop as English words. Should we continue using that? Because eventually developers have to get all other contents in English. If we keep Malayalam words for that, they may have this extra learning curve.

These are the other common words I can think of which needs to be in a glossary:

Application
Mockup
Design
Programming
Tutorial

May be we can cover some basic pages and get an alignment on the terminologies later? Otherwise, I feel like we may get delayed on the details instead of putting in the time and effort more efficiently. Once we've covered all the basics, will we create the glossary and share it with future contributors? Please share your thoughts.

@asimkt, Could you please check the PR #51?

@asimkt, Could you please check the PR #51?

Looks good as a starting point. As mentioned in that MR, I suppose we will reword some of the section? Some "കട്ടി മലയാളം“ may not work for our usual audiencr. 😄

@asimkt, Could you please check the PR #51?

Looks good as a starting point. As mentioned in that MR, I suppose we will reword some of the section? Some "കട്ടി മലയാളം“ may not work for our usual audiencr. 😄

Yeah sure, will recheck😄

I would like to take up translation of Importing and Exporting Components


Missing requried keys: [:id] in the controller test

Hi,
I am trying to test the redirection in my controller but I am having some problem. I am using rspec-rails 3.5.2
The failing test:
      describe "POST create" do
        let(:valid_data) { FactoryGirl.attributes_for(:public_achievement) }

        context "valid data" do
          it "redirects to achievements#show" do
            post :create, achievement: valid_data
            expect(response).to redirect_to(achievement_path(assigns[:achievement]))
          end
        end
     end

The create action in the controller
    def create
      @achievement = Achievement.new(achievement_params)
      if @achievement.save
        redirect_to achievement_url(@achievement), notice: 'Achievement has been created'
      else
        render :new
      end
    end

The error:
1) AchievementsController authenticated user POST create valid data redirects to achievements#show
 Failure/Error: expect(response).to redirect_to(achievement_path(assigns[:achievement]))

     ActionController::UrlGenerationError:
       No route matches {:action=>"show", :controller=>"achievements", :id=>nil} missing required keys: [:id]

Hi @jeffreyyong ,
you should use parenthesis   with assigns  method
try this change:
  describe "POST create" do
        let(:valid_data) { FactoryGirl.attributes_for(:public_achievement) }

        context "valid data" do
          it "redirects to achievements#show" do
            post :create, achievement: valid_data
            expect(response).to redirect_to(achievement_path(assigns(:achievement)))
          end
        end
     end


MinCostFlow uses too small inifinity value

In the original implementation, dist array in a dual refinement process is initialized with numeric_limits<T>::max(). Though in our implementation, we calculate the sum of cost among all the edges, and use that sum to initialize dist array, since we don't have trait that returns the maximum possible value of T.
Though there can be a shortest path which costs the sum of all the edges, e.g. in case all but one edge have cost 0, and in that case we don't update the shortest path tree, which makes the algorithm stop prematurely.
Initializing cost_sum by 1 should solve the issue, though we might want another name for the variable.
Picked from a slack thread.

Just noticed that we have a trait BoundedAbove now.


Fix #43 array_merge 0 args given

See TypistTech/imposter-plugin#43

Fix ArrayUtil::flatten for null or empty arrays

Do you think we need a more robust implementation like: https://github.com/illuminate/support/blob/fe658b6365fdd2d9cfe50c207f262d93bf3cfd3d/Arr.php#L200-L224

That implementation seems better.  The current implementation isn't recursive and wouldn't flatten an arbitrary n-dimensional array.

Should be fixed in https://github.com/TypistTech/imposter/pull/85
Thanks for the PR


Unable to post episode to anchorfm: Error: No element found for selector: #email

Hello,
Just tried to upload an episode via Github action
I get
Error: Unable to post episode to anchorfm: Error: No element found for selector: #email
at postEpisode (/src/anchorfm-pupeteer/index.js:157:15)
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async main (/src/index.js:37:5)
Did you encounter this kind of issue ?
Thanks

Could you please specify which version of the action are you running?

Testing the action on tag 2.0.0 gives me the same error of @jordanscience. It appears that this issue might be related to the Node.js version used in that particular version of the action (cause on the logs i see deprecated warns on node install). However, if I update the action to use tag v2.3.0, the issue is resolved, and the YouTube video is successfully published to Anchor.fm.

Exactly, you just needed to update to the latest version. All good then!


I have completed the project with the instructions provided

The sprint challenge has been completed as requested.

Rubric:

[x] Home page matches design files.
[x] Navigation appears.
[x] Header appears.
[x] Boxes accurately styled.
[x] About page matches design files.
[x] Navigation and header match Home page.
[x] Header image has About page image.
[x] Home navigation links back to index.
[x] Can walk me through how code made files match, sharing at least one concrete programming decision.
No time for stretch

Comments:

Great job finishing everything with ten minutes to spare!
Excellent job going back through and making time to proofread your code.
Great job adding comments in to pieces of code you might need to reuse later.
Try a stretch goal or two next time.


Include Open Data

For all topic suggestions we have an etherpad collecting material and ideas: https://pad.okfn.org/p/OpenScience101topicsuggestions


[Atlantis] Add possibility to specify an ImagePullSecrets for pulling images from private registry

Signed-off-by: Valentin Landemaine<EMAIL_ADDRESS>Helm Atlantis
Add possibility to specify an ImagePullSecrets for pulling images from private registry
Enable the possibility to specify an ImagePullSecrets for pulling images from private registry, if you want to use your own atlantis image for example.
EDIT: Fix also storageClass to storageClassName
@jkodroff
@lkysow
@jeff-knurek
@sstarcher
Checklist

[x] DCO signed
[x] Variables are documented in the README.md

/ok-to-test

I'v made the changes, it's ok fo you ?

Please squash your commits into a single commit.

It's ok

The DCO check is failing

Should we bump this to 1.X.0 since a breaking change was made.

Should we bump this to 1.X.0 since a breaking change was made.

Yes, we should. But then did you want to standardize the rest of the values.yaml to be camel case? If so, one of us can pull these commits into our own branch and also make those changes so there's a single PR with the 1.0.0 bump.

I'm fine with that if @vlandemaine-orange does not mind.

I made changes for switching all snake case variables to camel case and bump the version to 1.2.0. It's Ok for you ? I cannot made more commits, i don't have the time.

/lgtm

We missed serviceAccountSecrets.credentials-staging and also removing the atlantis prefix from atlantisDataStorage.
Let's not be in too much of a rush to merge these PRs without thorough review please. The consequences of waiting a bit longer are worth it over having to bump versions often (in my opinion).
Also I didn't realize we were already at 1.0.0. This should be a BC-breaking bump to 2.0.0.
I will make these changes when I have some time.

We also need to add an UPGRADING section to our readme as per https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md#versioning

The chart is not working when imagePullSecrets is specified, i don't know why because it's working on my first commit..
Error: YAML parse error on atlantis/templates/statefulset.yaml: error converting YAML to JSON: yaml: line 89: mapping values are not allowed in this context
@lkysow


Function to load all images in prefixed path

Description
To simplify loading all image assets in the specified (or default) path into the cache.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors and are passing (See Contributor Guide).
[x] My PR does not decrease the code coverage, or I have a very special case and explained on the PR description why this PR decreases the coverage.
[x] I updated/added relevant documentation (doc comments with ///) and updated/added examples in doc/examples.
[x] I have formatted my code with ./scripts/format.sh and the Flame analyzer (./scripts/analyze.sh) does not report any problems.
[x] I read and followed the Flame Style Guide.
[x] I have added a description of the change under [next] in CHANGELOG.md.
[x] I removed the Draft status, by clicking on the Ready for review button in this PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md).
[x] No, this is not a breaking change.

Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

From the API standpoint, there are now the following methods:
Images.load(String filename)
Images.loadAll(List<String> filenames)
Images.loadAllImages()
Images.loadAllFromPattern(Pattern pattern)

This is somewhat confusing, in particular, the 2nd and the 3rd methods sound too similar, and it's not immediately clear from their names what the difference is. So, perhaps we could go with something like
Images.load(String filename)
Images.loadList(List<String> filenames)
Images.loadAllAssets(Pattern? pattern)

These are only for images though, not for all assets (like audio for example).
We do have the loadAll pattern for passing in a list in different places in the API too.
What about:
> Images.load(String filename)
> Images.loadAll()
> Images.loadList(List<String> filenames)
> Images.loadAllAssets(Pattern? pattern)

@st-pasha I can't come up with any better names, do you have any other suggestions by chance?
I'd like to keep the loadAll for the list, since that pattern is used both in dart and in other places in Flame.
And I think it is clearer for the user to have the method that loads from a pattern and the one that loads all images separate, instead of relying on a nullable argument. Any ideas from @flame-engine/flame-colab maybe?

@st-pasha I can't come up with any better names, do you have any other suggestions by chance?
I'd like to keep the loadAll for the list, since that pattern is used both in dart and in other places in Flame.
And I think it is clearer for the user to have the method that loads from a pattern and the one that loads all images separate, instead of relying on a nullable argument. Any ideas from @flame-engine/flame-colab maybe?

I am ok the current choice of names, can't think on better options too.


after update of visual studio code ,no buid on save,no go to defination,every things is messed up

Issue Type: Bug
Updated vscode to version 1.30.2
after thati am not able to peek defination ,auto indendation is not working,
build on save is not happening.
VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:49:48.319Z)
OS version: Linux x64 3.10.0-862.9.1.el7.x86_64

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz (2 x 2500)

GPU Status
2d_canvas: unavailable_softwarechecker_imaging: disabled_offflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabled_readbackwebgl2: unavailable_off

Load (avg)
0, 0, 0

Memory (System)
5.67GB (1.84GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
100%

Extensions: none

Error: Error: spawn EACCES
after reinstalling go extension

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

can you please suggest how to install it in centos

when tried to install manually
Installing 1 tool at /root/bin
  gocode

Installing github.com/mdempsky/gocode FAILED

1 tools failed to install.

gocode:
Error: spawn /bin/go EACCES

Sorry I am confused by your response. I believe you are using the Go extension and they do not work properly for Go files?

yup

things were fine before installing updates,after vscode update i am facing these issues


Translation / i18n support

Preflight checklist

[X] I could not find a solution in the existing issues, docs, nor discussions.
[X] I agree to follow this project's Code of Conduct.
[X] I have read and am following this repository's Contribution Guidelines.
[ ] This issue affects my Ory Cloud project.
[X] I have joined the Ory Community Slack.
[ ] I am signed up to the Ory Security Patch Newsletter.

Describe your problem
Currently, text can't be translated. It's hardcoded in React components.
Describe your ideal solution
Add support for i18n / translation so we can translate / change any text in components.
Workarounds or alternatives
None
Version
latest
Additional Context
No response

In progress here https://github.com/ory/elements/pull/130

This has now been added to the latest version


Dev Ops chores

add tests to grunt jshint

add 'use strict' s

console.logs

TravisCI wants nodemon to be installed globally ?

Make TravisCI use real API keys

Replace tabs with spaces


AutoBitLocker resource incorrectly identifies Fixed vs Removable drives

Current implementation of AutoBitLocker resource uses Get-Volume to differentiate between Fixed and Removable drives. This does not work correctly as there are drives reported as Fixed, yet Bitlocker evaluates them as Removable and therefore applies different GPO settings to them. I saw this for certain HP SAS controllers, VMware can also behave this way (https://kb.vmware.com/s/article/1012225) - seems to be related to the way storage controller reports disk capabilities to the OS.
Instead of using Get-Volume, I found \root\cimv2\security\microsoftvolumeencryption:Win32_EncryptableVolume.VolumeType property to correctly report volume types as evaluated by Bitlocker:
0 - OS volume
1 - Fixed volume
2 - Removable volume

Do you have example output where Get-Volume report the wrong type, but CIM reports it correctly? Labeling this as a bug and help wanted.

Sure, I found that even my SSD drive connected via USB dongle behaves this way:
gwmi -Namespace root\cimv2\security\microsoftvolumeencryption win32_encryptablevolume -filter "DriveLetter='F:'"|select driveletter,volumetype|fl

driveletter : F:
volumetype  : 2

get-volume -driveletter "F"|select driveletter,drivetype|fl

driveletter : F
DriveType   : Fixed

I see that you referenced this issue in commits. You are welcome to send in a PR resolving this! 🙂

Will do once I have time to test the fix, possibly over the weekend.
From: Johan Ljunggren<EMAIL_ADDRESS>Sent: 25 May, 2018 15:17
To: PowerShell/xBitlocker<EMAIL_ADDRESS>Cc: Martin Vokurek<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [PowerShell/xBitlocker] AutoBitLocker resource incorrectly identifies Fixed vs Removable drives (#11)
I see that you referenced this issue in commits. You are welcome to send in a PR resolving this! 🙂
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FxBitlocker%2Fissues%2F11%23issuecomment-392054497&data=02|01||a9efab4419dc4dd439f508d5c241c212|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636628510031169200&sdata=TFTX3LlaqD0mJraCFcYopw%2FRJKIzJQNW1ZlPj%2FFkmNw%3D&reserved=0, or mute the threadhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASQqdkUrvof2nSB8dLHy-zRe_ejN9xPiks5t2AQ5gaJpZM4UM_Nd&data=02|01||a9efab4419dc4dd439f508d5c241c212|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636628510031169200&sdata=U93pQOIVgi7UVWZoJM1%2FE1QPl32RX1JTWIO9BGqjInU%3D&reserved=0.


[FEATURE] What should happen when ToC is long enough to have a scrollbar

On posts/setup_site, there's a scrollbar on the ToC since there are so many headers. When you scroll past the last element, the ToC doesn't automatically scroll down.
It'd be distracting to automatically scroll the scrollbar. A solution would be to decrease the depth of the ToC, but this doesn't feel optimal.

Decreasing depth of the scrollbar does not work. It completely breaks the active element highlighting as soon as you reach a heading that's not shown in the ToC.


fix: Virtualize=true conflicts with Class="multiline-text" in FluentDataGrid

🐛 Bug Report

According to https://www.fluentui-blazor.net/DataGrid, both props are valid to put in a PropertyColumn.
However, Virtualize=true will ruin Class="multiline-text". In another word, if there are too many chars, it will overwrite on other things.
💻 Repro or Code Sample
<FluentDataGrid Items="@filteredMaintenanceRecords" Virtualize=true<EMAIL_ADDRESS>    <ChildContent>
        <PropertyColumn Property="@(c => c.ID)" Title="ID" Sortable="true"<EMAIL_ADDRESS>IsDefaultSortColumn  Tooltip="true" />
        <PropertyColumn Property="@(c => c.equipment.Manufacturer)" Title="生产厂家" Tooltip="true" />
        <PropertyColumn Property="@(c => c.equipment.Description)" Title="设备名称" Tooltip="true" />
        @* Maybe more columns here *@
        <PropertyColumn Property="@(c => c.DateTimeReportedOn)" Title="报修日期时间" Tooltip="true" Class="multiline-text" />
        <PropertyColumn Property="@(c => c.DescriptionOfMalfunction)" Title="故障现象" Tooltip="true"  Class="multiline-text" />
        <PropertyColumn Property="@(c => c.DateTimeEstimatedComplete)" Title="预计完成时间" Tooltip="true" Class="multiline-text" />
        <PropertyColumn Property="@(c => c.DateTimeCompleted)" Title="实际完成时间" Tooltip="true" Class="multiline-text" />
        <PropertyColumn Property="@(c => c.MaintenancePerformedBy)" Title="维修工程师" Tooltip="true" Class="multiline-text" />
    </ChildContent>
    <EmptyContent>

没有数据

    </EmptyContent>
</FluentDataGrid>

🤔 Expected Behavior

😯 Current Behavior

💁 Possible Solution
Upon inspection from the client side, there are 2 key attributes that are culprit:

Disabling them on the rows will fix it

Notice that I only disabled these props on the first 3 rows, other rows are still cramped.

🔦 Context
I want to have virtualize loading with EF Core and multiline-text at the same time.

🌍 Your Environment

OS & Device: Windows PC
Browser Microsoft Edge, Google Chrome
.NET 8.0.300-preview.24203.14 and Fluent UI Blazor library Version 4.6.1 and 4.7.0

It can work I think, buy you must set ItemSize. For virtualize to work, all rows need to be the same height

For virtualize to work, all rows need to be the same height

That's where the problem is.

That's where the problem is.

Understood. But tha is a Blazor limitation, not a Fluent UI issue.

How unfortunate, but thanks anyway.


{Data Structure }: Add {Queue} [Python]

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the
below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the commit guidelines for this project.
[ ] My code follows the standard code structure.
[ ] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[ ] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[ ] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

Comment on 3ad41f7da1af6c17d67c834651eff0b86fb22f5f, file queue/python/queue.py, line 28.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp67rd4td0/queue/python/queue.py
+++ b/tmp/tmp67rd4td0/queue/python/queue.py
@@ -25,7 +25,7 @@
     q.enqueue(True)
     print("Size of queue is : " + str(q.size()))
     print("Element on front is : " + str(q.front()))
-    print (str(q.front()) + " is Deleted ")
+    print(str(q.front()) + " is Deleted ")
     q.dequeue()

Comment on 3ad41f7da1af6c17d67c834651eff0b86fb22f5f, file queue/python/queue.py, line 28.
E211 whitespace before '('
Origin: PycodestyleBear (E211), Section: all.autopep8.

Man!! Read the contribution guideline.


[Calling] Fix Settings for Audio Only & Auto-Token Functionality (w/Azure CLI)

Purpose

Fix settings menu
auto-token w/azure cli (time saving) (disabled)

Auto Token will fetch and install a token as if it were in your local.properties if

You have az azure cli installed
You have run az login
You have set AZURE_COMMUNICATION_CONNECTION_STRING environment variable to a valid Azure Communication Resource (Available in keys via the azure.portal.com).
You have omitted your ACS_TOKEN from your local.properties

If all the above is true, Tokens will be fetched and installed for you upon installation of the demo.
Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[ ] Tested for background mode
[ ] Unit Tests Included
[ ] UI Automated Tests Included

How to Test

Open...
Click on...

What to Check
Verify that the following are valid

...

Other Information

@ahammer ,
Re: I think it will be good idea to have separate repo for token help? perhaps that web and iOS can also leverage. May be having a discussion with PM to have repo and CLI instructions can help.
You have az azure cli installed
You have run az login
You have set AZURE_COMMUNICATION_CONNECTION_STRING environment variable to a valid Azure Communication Resource (Available in keys via the azure.portal.com).

@ahammer , Re: I think it will be good idea to have separate repo for token help? perhaps that web and iOS can also leverage. May be having a discussion with PM to have repo and CLI instructions can help.
You have az azure cli installed You have run az login You have set AZURE_COMMUNICATION_CONNECTION_STRING

https://learn.microsoft.com/en-us/cli/azure/communication/identity/token?view=azure-cli-latest
The instructions for setting up and utilizing Azure CLI for communication services token's is on that page.
The usage instructions for the Android Readme will be done after, when merging back to Develop I can add to the Readme.md under the "getting started" for android and reference/link that it uses that method under the hood to work.
This gradle function doesn't apply to iOS or Web directly, but I'd encourage the use of Azure CLI when it logically makes sense, as in this case.


Preliminary color fix

partially for #72, but does not fully resolve it
works as a temporary solution until we find a better way
We will need a real fix in the future

Isn't it true that both color_temp and xy_color are present in the HA state ?

Isn't it true that both color_temp and xy_color are present in the HA state ?

It depends. At least in the case of group lights, if all RGB lights are turned off, the xy_color and hs_color disappear from the state.

It depends. At least in the case of group lights, if all RGB lights are turned off, the xy_color and hs_color disappear from the state.

Most attributes will not be present if a light is off. Only when the light is on, these attributes will be present.
Exception is a few defaults like the friendly_name and supported_features

Most attributes will not be present if a light is off. Only when the light is on, these attributes will be present.
Exception is a few defaults like the friendly_name and supported_features

resolved in #196


tf.image.resize_bilinear has nearest neighbor gradients when downscaling

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 16.04

TensorFlow installed from (source or binary):
binary

TensorFlow version (use command below):
v1.2.0-5-g435cdfc 1.2.1

Python version:
3.5.2

Describe the problem
When using tf.image.resize_bilinear to downscale, the gradients of the output w.r.t. the input is the same as what we get from nearest neighbors. For instance, using the code below you can confirm that the gradients are being sparsely backpropagated to specific pixels of the input image.
Source code / logs
import numpy as np
import tensorflow as tf

if __name__ == '__main__':
    session = tf.Session()

    x = tf.placeholder(tf.float32, shape=[None, 16, 16, 3])
    x_low = tf.image.resize_bilinear(x, (4, 4))
    loss = tf.reduce_sum(x_low)
    loss_grad = tf.gradients(loss, x)

    grad = session.run(loss_grad, {x: np.ones([1, 16, 16, 3], dtype=np.float32)})[0]
    grad = grad[0, ...].transpose(2, 0, 1)
    print(grad)  # should not be sparse, but it is

    session.close()

The output is:
[[[ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]]

 [[ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]]

 [[ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.  1.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]
  [ 0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.  0.]]]

It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 248 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 264 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 279 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 294 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 309 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 324 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @aselle: It has been 339 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@saeta, did you ever look at the gradients. @ankitkv, what did you want it to do? As an aside, you may not want to use a bilinear downsample filter, something like a box area filter (take the destination pixel size and make it into a box that overlaps all pixels on the source image). There's no primitive in tensorflow that does this to my knowledge.

@aselle Thank you. Your comment really helped.
I was expecting the tensorflow bilinear downsampling behavior to be similar to that of pillow's, but apparently it's not. For me the resize_area op seems a better choice.

Nagging Assignee @saeta: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @saeta: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Smoke test for the Oracle WebLogic

Smoke test is built using same concepts as existing smoke tests in this repo and in opentelemetry-java-instrumentation. It covers officially supported WebLogic versions - WLS 12 on Java 8 and WLS 14 on Java 8 and 11.
Because of yet unclear (work in progress) legal arrangements for building and publishing shared images with WebLogic (which could be used in GitHub actions and environments alike), test is expecting local WebLogic images. If there are no images, then test is ignored. To build local development images of Oracle WebLogic one has to follow the instructions in src/weblogic/README.md and download some files from Oracle, while agreeing to its development license terms.
Because the smoke test for WLS has one more dimension in addition to just jdk, SmokeTest and SpringBootTest were updated to provide a supplier function for the image name lookup instead of an abstract method taking jdk as an input argument. This part sort of redoes PR https://github.com/signalfx/splunk-otel-java/pull/25 while solving the issue https://github.com/signalfx/splunk-otel-java/issues/20

Spring boot smoke tests are currently failing because of this: https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/1546


Feature Request: Send specific question to ChatGPT

Can someone please add another feature to send desired part of text as a question to Chat GPT and get a response that will stay on a screen for some time?

Implemented in transcribe - https://github.com/vivekuppal/transcribe/


chore(main): release 0.6.8

:robot: I have created a release beep boop
0.6.8 (2023-09-14)
Dependency Updates

deps: bump github.com/statnett/controller-runtime-viper from 0.3.1 to 0.3.2 (#581) (0678abc)
deps: bump github.com/vektra/mockery/v2 from 2.33.1 to 2.33.2 (#555) (ead6d8c)
deps: bump k8s.io/api from 0.28.1 to 0.28.2 (#572) (b29755a)
deps: bump k8s.io/apimachinery from 0.28.1 to 0.28.2 (#574) (c52884f)
deps: bump k8s.io/client-go from 0.28.1 to 0.28.2 (#573) (a10ec96)
deps: bump sigs.k8s.io/controller-runtime from 0.16.1 to 0.16.2 (#569) (0cf7c38)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/statnett/image-scanner-operator/releases/tag/v0.6.8 :sunflower:


Using executors seems to fail and then break the app

In attempting to reproduce CDI-based scheduling as seen in https://balusc.omnifaces.org/2024/10/how-to-migrate-from-ejb-to-cdi.html , I found that scheduling a bean-method-call task in the ManagedScheduledExecutorService doesn't seem to work at all, and then also creates a situation where modifying the app design means the app can't find CDI until an HTTP restart.
Other code in that method, like just a sysout, does not cause this trouble.

It looks like it's not necessarily related to the CDI-startup bit at all. I just tried kicking off a task in the non-scheduled executor and it similarly didn't finish (without logging trouble) and also eventually broke the app.

Interestingly, it doesn't ALWAYS cause trouble. I restarted HTTP and then immediately tried this and it worked. It could be something to do with modifying the design of the app.

It seems like this trouble also crops up when the app unloads due to its normal timeout, so the problem is likely that any use of executors "poisons" the app such that it can't reload, and modifying the design just accelerates the process.

I've been poking around to see how Concurrency could be "tainting" the app, and it's not clear. The trouble with not finding the CDI container seems to be that at some point the NotesContext isn't set, but it sure seems like it always should be, and debugging didn't show any times when getCurrentUnchecked() returned null. I kind of wonder if it's related to ClassLoader shuffling and Domino's tendency to aggressively re-use threads, but nothing is standing out.


D ui3 305 agis implement highlight for individual features e.g. from receive report

Introduce struct holding LayerURI (represented as string because this is how native API is treating LayersURI), featureId, MapMember (actual layer object on the map)
Adapt Report building and Highlight functionality to use this instead of flat string with LayerURI
Add functionality to select individual features if FeatureID is available

converting to draft to update documentation


Reaction to React Hooks?

Just wanted to open a discussion about the new React Hooks which was announced at ReactConf.  I reach for React when I do a SPA currently (although we have a non-critical IT only app we built in Blazor as well), and React Hooks have me pretty excited, because it groups similar logic together much like Feature Folders do for a folder structure.
Wrapper Hell
One of the things they discussed that React Hooks is solving is "Wrapper Hell" where you have tons of components nested beneath each other.  Specifically they call out Context, which is very close to how Cascading parameters work in Blazor with the <CascadingValue> wrapper component.
Curious what the Blazor team thinks about this and if there are any thoughts around perhaps doing something similar to what the React team is moving to with Hooks and getting rid of the need for the wrapper component.
My quick thoughts would be something like making global state injectable instead of using a wrapped component... or having access to some grab bag off of the BlazorComponent base class where you could do something like .Get<T> and have it magically grab your value for you.  Those are my crappy 1 minute ideas, but feels like Blazor could do something similar to remove the need for the wrapper component and keep the component trees less nested and easier to follow.
React is getting rid of lifecycle methods
React is also moving away from lifecycle methods like componentDidMount (OnInit/OnInitAsync in Blazor).  They're mostly doing this so that setup (addEventListener) and cleanup (removeEventListener) is wired up in the same spot instead of separate lifecycle methods which led to bugs when you forgot to cleanup for instance.  Curious to hear other's thoughts on this and how it would apply to Blazor.  I personally haven't done any cleanup of my Blazor components, but maybe I'm causing a memory leak I don't know about.
Obviously it's very early days in React Hooks land, but the concepts behind them makes a lot of sense.
Just wanted to generate some discussion.  Thanks!

Thanks for contacting us, @scottsauber.
We have no plans to do this in the near future.


Modernization framework support for sharepoint 2019?

Is modernization framework supported for on premise environment? i.e. if i have classic pages in sp 2013, and if farm is migrated to SP 2019- onpremise. Can I convert classsic page to modern with this framework?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12c9c192-eb6e-5c54-f03f-7f66d43f92e6
Version Independent ID: 328da4aa-fa66-0491-6a8d-94189f14e060
Content: Transform classic pages to modern pages
Content Source: docs/transform/modernize-userinterface-site-pages.md
Product: sharepoint
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Hi @rohit404404 , the modernization framework only supports SharePoint Online as target for the modernized pages. You can use it to transform your SP2013 and/or SP2019 classic pages into modern pages living in SharePoint Online. We've no plans to enable page transformation to transform pages into SP2019.

Thank you @jansenbe  Any documetation url stating same? ( not that i dont trust you)

@rohit404404 the SharePoint Modernization Framework is part of the PnP Framework, the PnP Framework only supports SharePoint Online as stated here.

Thank you everyone for your response.


Currently points to a non existing endpoint resulting in a 404

https://github.com/payid-org/payid/blob/a23650e1cf8d27b9e742c5f5dd4e04a97fe860c0/src/html/index.html#L248

Thanks for opening this issue!

Fixed in https://github.com/payid-org/payid/pull/562


continueLength is not used in the XSLT and could be removed

The <continueLength> element is used in the xsd schema and in some assertions. But it is not used in the xsl file. If it is no longer used then it should be removed.

I had been using this tag so that you can write a 200 as 50fr 50bk but set continueLength to 200
rather than writing 50fr 50bk 50fr 50bk, however, this hasn't been translated over to the xslt, and isn't used in the length calculating function.
I could either add this so that the length will be calculated correctly, or remove the continueLength which would mean the 200 is represented as 2x(50fr 50bk) which still makes sense.

I am happy to keep it in, but I suspect that it then needs to be used in the XSLT. I would need a detailed explanation of how exactly this works. I am busy writing the documentation, so all these questions come up.

Could you please keep it and explain how exactly it works?

By setting the continueLength of a continue to something larger than what its contents actually are you are expecting the contents of the continue to repeat.
Instead of writing a continue as 50fr 50bk 50fr 50bk which would be swum as a 200,
you set continueLength to 200 then the contents of the continue will just be 50fr 50bk, which the swimmers would then repeat to get to the total length of 200.

Thanks for the documentation. I created an example to test the <continueLength> element. It is available here:
/bookExamples/swiML-documentation/continueLength.xml

When giving this instruction:
    <instruction>
        <continue>
            <continueLength>200</continueLength>
            <instruction>
                <length>
                    <lengthAsDistance>50</lengthAsDistance>
                </length>
                <stroke>
                    <standardStroke>freestyle</standardStroke>
                </stroke>
            </instruction>
            <instruction>
                <length>
                    <lengthAsDistance>50</lengthAsDistance>
                </length>
                <stroke>
                    <standardStroke>backstroke</standardStroke>
                </stroke>
            </instruction>
        </continue>
    </instruction>

I get this unexpected result:

Could you please enable the <continueLength> element?

Should be working now

Yes, this error is now gone, but the calculation of the total length is still wrong. In the example file, the total should be 300, not 200.

For consistency reasons and to be able to express different types of length, the <continueLength> element should be treated the same way as the <length> element. It should include <lengthAsDistance>, <lengthAsLaps> and <lengthAsTime>. It should also be assured that the unit used is compatible with the instructions included. The easiest would be to ensure that they all use the same unit.

This error occurs again not in the program length, but in the calculation of the simplified repetition. Have a look at the file jasiMasters/JasiMasters2024041401.xml

The two enclosed continue elements are summed up to only 50 meters although the continueLength is set to 100.

tested and okay.


Add API-coverage documentation

Motivated by https://github.com/dask-contrib/dask-expr/issues/233
We need a space to document the available API coverage, and to leave notes about current limitations.

Do you propose rendering proper docs or just a readme or something like this?

Do you propose rendering proper docs or just a readme or something like this?

I think it would be fine to add this information to the README  in the short term. Once someone has time to set up a proper doc framework, we can move the information into a dedicated/rendered page. Wdyt?

Yeah that sounds good.

Yeah that sounds good.

I threw up #235 in the short term, but I certainly welcome other (better) solutions :)


[lnd] remove tor.streamisolation check

causing repeated problems when users setting it to false in the config so needs disabling in lnd.check.sh

Keep open for testing during RC2

So far no problems - closing for v1.8.0 release.


People icon in an Adaptive Card

**Build Pipeline - **

Build Pipeline
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/5937987175

Engineering team Approved the PR:

Engineering team Approved the PR:


Text completion fails with non-default model passed in as argument

When trying to use the flan-t5-base model in place of the default model text-completion, the pipeline fails:
Error: File not found. Could not locate "/models/onnx/quantized/google/flan-t5-base/causal-lm-with-past/tokenizer_config.json".

Closing this after seeing in the docs that FLAN-T5 is used for seq-to-seq tasks only

Hi! It appears as though you are using the the wrong pipeline. You should be using "text2text-generation" instead of "text-generation".

For example, see the tags of the models:

FLAN-T5: https://huggingface.co/google/flan-t5-base (text2text generation)
GPT2: https://huggingface.co/gpt2 (text generation)

Oops, I meant to close this issue but looks like I clicked the button twice last night. Sorry about that 👍


Custom labels

Not urgent, but while I think of it - there might be some use for a mechanism for constructing custom label text e.g.:
e.g. handlebars.js / jinja2 syntax:
{{ chain }}:{{ resno }} {{ bfactor }}
Or more compact/cryptic printf style, with precision
%c:%r %.1b

would be nice indeed! there is already sprintf (https://github.com/arose/ngl/blob/master/lib/sprintf.es6.js) in ngl which includes named arguments and can be used for number formating :)

I suppose once a new sprintf version is released (https://github.com/alexei/sprintf.js/pull/161), we can have this goodness https://github.com/fredludlow/ngl/tree/sprintf-labels, right?

Yup, that's the idea, or we can just reference a specific git commit in the sprintf.js repo?

or we can just reference a specific git commit in the sprintf.js repo?

fine by me too


{Storage} Fix secondary storage account read access

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

better to have a test. 😸

sure. will add it later.

Storage


Boardwalk Fehler

Version of Boardwalk:1.2
Version of Android:5.0.2
Device model:samsung galaxy tab A
Description of the problem:

I HAVE THE SAME DEVICE ERROR EVERYTHING


[HOLD QA] @swm/navigation refactor

Details

Copy of https://github.com/Expensify/App/pull/18605 with the newest main branch merged.
Tests
Most of the regression testing will come from Applause running through the App tests and logging any navigation errors (unusual results). Since there are virtually limitless combinations and flows within the App, we will only create a couple specific ones which we will ask Applause to go through and we can use to test the PRs. We would also ask QA to run full regression on the main PR before we merge these changes.
Note: For all of these, we should test them on all platforms (except resizing on mobile)
Deep link to authenticated page when signed out (pending route)
In Notes app for example, write a link to Settings page: https://new.expensify.com/settings
Be signed out on the testing device
Click on the link
Verify you have been navigated to the sign in flow
Sign in
Verify you have been correctly navigated to the Settings page after signing in
Deep link from notification
Have the App in the background on your testing device signed into User A account
From User B account, send a message to to User A
As user A, click on the new message notification
Verify the App has opened and you have been navigated to the correct chat
Correct Back button behavior when deep linking
Be signed in to the App on you testing device
In Notes app for example, write a link to Settings page: https://new.expensify.com/settings
Click on the link and verify you have been navigated to the Setting page
Click back button (either in desktop web or Android physical back button)
Verify you have been navigated to the Notes app (or wherever you have clicked the link on)
Smooth navigation after resizing
On web, in wide layout, sign in and navigate to the Concierge chat
Resize the browser window so its narrow enough so it switches to the mobile layout
Verify that you are in the Concierge chat
Click the UP button
Verify you have been navigated to the LHN
Navigate to Settings page
Resize the window back to wide view
Verify the Settings page is open in the RHP
Verify you can see the Concierge chat in the background
Verify Up button behavior after navigating to a nested page
Send a message which includes this link to someone: https://new.expensify.com/settings/about
Click on the link from the message
Verify you have been navigated to the About page
Click Back button (either browser back button or Android physical back button)
Verify you have been navigated back to the chat
Click the link again to get to the About page
Click the Up button
Verify you have been navigated to the Settings page
Click the Up button again
Verify you have been navigated to the original chat
Test all deep links
Note: We had issues with deep links recently and to prevent this we will add new regression tests which will test all the possible deep link routes in the App. We won't write them down here as it's not tightly connected to the core idea of this doc, but noting it here so we don’t forget about this.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/32481228/0076f24a-4693-4b6e-accd-47b113c332ac

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://github.com/Expensify/App/assets/32481228/a0f088b1-3e9a-4e3f-8f76-022b78d35a5a

iOS
https://github.com/Expensify/App/assets/32481228/6698ecbe-2a48-4563-b275-12c178679e83

Android
https://github.com/Expensify/App/assets/32481228/99a008c2-5b44-4684-a5a8-2d23de99b231

Use the links below to test this build in android and iOS. Happy testing!

QA results so far:

https://github.com/Expensify/App/issues/19384 I have seen this when using the app, but its not consistent, sometimes the composer is focused sometimes its not, not sure what are the best reproduction steps
https://github.com/Expensify/App/issues/19383 this one might be from main, I dont think its related to our branch - we can build new version later and confirm
https://github.com/Expensify/App/issues/19381 - this is definitely a bug
https://github.com/Expensify/App/issues/19380 - I think this is related to the url matching logic and it should work in staging and production

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/19263/NewExpensify.dmg
https://19263.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/19263/NewExpensify.dmg
https://19263.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/19263/NewExpensify.dmg
https://19263.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/19263/NewExpensify.dmg
https://19263.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/19263/NewExpensify.dmg
https://19263.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/19263/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/19263/index.html

desktop :computer:
web :spider_web:

❌ FAILED ❌
https://19263.pr-testing.expensify.com

The QR code can't be generated, because the Desktop build failed

@WoLewicki i dont think the latest commit has been correct

Not on Hold anymore, but we need to clean this up, the latest commit had incorrect merge I believe.

This is not on hold anymore, but we should clean this up and make internal release again

Triggered a build here https://github.com/Expensify/App/actions/runs/5191341385

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@0xmiroslav Has reviewed most of this code already as part of the other PRs.

@0xmiroslav done 🚀

Some other comments on what to look at in following PRs:

check if patch for @react-navigation/native is still needed
fix tests by either another approach for rendering heavy ReportScreen or properly handling navigation in tests
look deeper at logic for getIsReportFullyVisible since part of it was needed due to drawer being able to cover the report screen
fix flows for Task in RHP
Remove close props from HeaderWithBackButton if it is meant not to be used there anymore
check some weird navigation flows with browser back buttons and RHP

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.25-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

.

staging.new.expensify.com/settings

staging.new.expensify.com/settings

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.25-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Strip prefix path between git root and crate root

This allows git repos to be used where the crate isn't rooted at the
root of the git repository.
Fixes #85

Oh, and changes to the CrateExtras struct affect the lockfile. You'll need to repin (though I'd do so after a rebase since I'd just made a repinning change as well)

For testing you could add tools/cargo_bazel/test_data/metadata/git_repos/Cargo.toml with the following contents:
[package]
name = "git-repos"
version = "0.1.0"
edition = "2018"

# Required to satisfy cargo but no `lib.rs` is expected to
# exist within test data.
[lib]
path = "lib.rs"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
tracing = { git = "https://github.com/tokio-rs/tracing.git", rev = "1e09e50e8d15580b5929adbade9c782a6833e4a0" }

Then run bazel run //tools/cargo_bazel/test_data/private:metadata_generator and you'll have a lockfile and metadata you can use for testing, similar to what's in test.rs. Then I'd write a test that asserts LockfileAnnotations are made with a tracing crate that has a strip_prefix. It may also be easier to move the logic for finding the repo root into a function and test that directly 😄


Custom error handling won't allow setting headers in the error backend anymore

Previously, when using nginx Ingress Controller version 0.9.0-beta.11 (using Lua to get the error message from the user-defined custom error backend) we could set some headers like X-Request-ID in the custom error backend and have the client see those headers.
Now, I'm trying to upgrade to version 0.9.0-beta.13 which uses a different fastcgi+Go based error handler. It seems like this version does not allow the user to see the headers we set in the custom error backend anymore.
From our point of view, this is a regression between those two versions.

@juhtie01 this is fixed in master. I will publish a temporal image an post the link in this issue so you can use that until we release a new version


Is it possible to run command on running container with docker remote api

I'm using stilliard/pure-ftpd. I would like to open ftp users with remote api. I couldn't find any example about this on remote api documentation.
Output of docker version:
Client version: 1.6.2
Client API version: 1.18
Go version (client): go1.2.1
Git commit (client): 7c8fca2
OS/Arch (client): linux/amd64

Output of docker info:
Containers: 1
Images: 19
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 21
 Dirperm1 Supported: false
Execution Driver: native-0.2
Kernel Version: 3.13.0-79-generic
Operating System: Ubuntu 14.04.4 LTS
CPUs: 1
Total Memory: 490 MiB
Name: ubuntu-512mb-fra1-01
ID: ESQR:OTJT:T3KB:EE77:CZLO:PUVR:ZR7N:6J66:3OLN:YHSU:ZAMC:LALR

I am not sure I understand what you mean by "open ftp users", but you can use the exec endpoint to run extra commands in a running container, see here

Also, the IRC channel #docker on freenode is probably the best place for this kind of question since it's not really an issue or a feature request :)
See here for a quick intro to IRC if needed.

Thank you.


Create docker compose

See https://github.com/PathwayCommons/factoid/issues/771

docker-compose is a no-go with docker and CUDA: https://github.com/docker/compose/issues/6691. Should still be able to get the docker container itself working.


Update to the latest version of spectral

Chore summary
Currently this extension is on v5 of spectral. The latest version of Spectral is 6.3.0. Let's update it to use the latest.
Tasks

[ ] Bump spectral version to 6.3.0
[ ] Test that it still works 🚀

Hey team! Please add your planning poker estimate with ZenHub @lottamus @P0lip

You can try this extension instead. It is based on Spectral 6.1.0:
https://marketplace.visualstudio.com/items?itemName=chuntaoliu.openapi-linter

That alternative extension might be a good alternative for now. But would love to have the official stoplight / spectral extension at v6.

We've scheduled this upgrade for the near future, please stay tuned!


Root menu opening in the extended desktop monitor (dual monitors setup)

Hi,
I have a dual-monitor setup where my Trays, that include icons, menu, clock, etc are on the left screen, and the right screen is used mainly as an extended desktop to where i drag windows.
The issue is when I mouse click near the right hand side of the left monitor, the Root menu will appear on the right monitor. (i believe it should detect i am clicking near the edge of the screen, and thus appearing on the left).
I hope I'm describing this issue clearly.

Unfortunately, I lack a dual monitor setup to test. Just to be sure, this is a recent build (2.3.6 or later) correct?  JWM should be confining menus to a particular screen, though it's possible that JWM is initially selecting the wrong screen.  Does it help to make the tray smaller?

Yes, this is occurring with the last build available (2.3.6).
Making the tray small doesn't help in this because i have two root menus one on the left and one on the right, where i keep logoff, shutdown, etc)

It's strange that the menu is spanning screens like that.  I could see the menu appearing on the wrong screen in your second example, but the menu show always show up completely on one screen.  Is JWM compiled with Xinerama support and is Xinerama supported by your X server?
Running jwm -v should tell you if JWM was compiled with Xinerama, you should get something like:
compiled options: confirm debug icons jpeg png shape xbm xft xinerama xpm xrender.
I imagine the X server would output whether Xinerama is enabled in a log file.

I installed jwm via the package manager of my distribution but it was compiled with Xinerama nonetheless. the output of my jwm -v is compiled options: confirm fribidi icons jpeg nls png shape svg xbm xft xinerama xpm xrender could this be related with my xrandr config?
i have xrandr --output VIRTUAL1 --off --output eDP1 --off --output DP1 --off --output DP2 --off --output HDMI2 --off --output HDMI1 --mode 1280x1024 --pos 1280x0 --rotate normal --output VGA1 --mode 1280x1024 --pos 0x0 --rotate normal

I think this should be fixed as of snapshot 1598.  Please let me know if that works for you!
Thanks!

Unfortunately it didn't work. I compiled and installed. jwm -v gave me the version 2.3.7 so i believe it is correctly installed.

So this fixed it for me.  Are you sure it's actually running the new version?  You should be able to just run jwm -v to verify the right executable and then jwm directly in the terminal to cause JWM to replace the old process.

actually it worked! there was a conflict with jwm versions installed. The menu is showing in the correct screen now. Solved!
Many thanks

Awesome! Thanks!


[FEATURE] Improve test coverage for HuggingfaceTextEmbeddingTranslator.java

We need to improve test coverage in our repo.
This issue will target only to improve test coverage for HuggingfaceTextEmbeddingTranslator.java
From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2Falgorithms%2Ftext_embedding%2FHuggingfaceTextEmbeddingTranslator.java

@dhrubo-os I would like to attempt this as a first project.

Sure, assigning to you.

@kmcarranza any update on this?

@dhrubo-os Hello. I still working on this code and I hope to have something to push Monday. Thank you.