Enforce Select queries on Connection::executeQuery

Related to https://github.com/phpstan/phpstan-doctrine/issues/545
If you're okay adding something like this here, I can do the same rule for executeStatement @ondrejmirtes.

Do you agree with adding such rule to phpstan-doctrine repository @ondrejmirtes or should I implement this in my own project ? The issue is described in https://github.com/phpstan/phpstan-doctrine/issues/545#issue-2132391594

I rebased the branch.
Do you agree with adding such rule to phpstan-doctrine repository @ondrejmirtes or should I implement this in my own project ? The issue is described in https://github.com/phpstan/phpstan-doctrine/issues/545#issue-2132391594

I think this rule isn't generally applicable. As you said, these patterns are fine with a single DB connection.

I think this rule isn't generally applicable. As you said, these patterns are fine with a single DB connection.

Ok, I'll keep it for my project then.
Thanks for your answer

@VincentLanglet We would use such rule, is it open-sourced somewhere else or should I copy it?

@VincentLanglet We would use such rule, is it open-sourced somewhere else or should I copy it?

You're free to copy it (and expose it in a package if you want) ; my project is for work so it's private...

and expose it in a package if you want

Thanks! We have several generally usable Doctrine related rules, but I never found enough time+priority to open-source it. So maybe one day it may become part of that.


Moving File#fsync, File#flock_exclusive, File#flock_shared, and File#flock_unlock methods toIO::FileDescriptor - Fixes #9793

Moved File#fsync, File#flock_exclusive, File#flock_shared, File#flock_unlock to IO::FileDescriptor
https://github.com/crystal-lang/crystal/issues/9793#issuecomment-703103653

Please change the title of this PR, right now it's basically empty.

Please change the title of this PR, right now it's basically empty.

Thank you @oprypin. Changed title to match with issue heading


quadsToFacts and factsToQuads do not roundtrip

Versions<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>import { Parser } from 'n3';
import { factsToQuads, quadsToFacts } from 'hylar-core';

const parser = new Parser({ format: 'text/n3' });
const quads = parser.parse(`
@prefix : <#>.
{ :subject :predicate :object } = :graph.
`);

const facts = quadsToFacts(quads);
const quads2 = factsToQuads(facts);

Expected behavior: quads, facts, and quads2 should each contain a representation of two quads:

subject = #subject, predicate = #predicate, object = #object, graph = some blank node;
subject = the same blank node, predicate = http://www.w3.org/2002/07/owl#sameAs, object = #graph, graph = default graph.

Observed behavior: quads and facts as expected; quads2 contains a representation where both quads have graph = default graph.
Cause: quadToFact constructs a Fact whose graphs property is the original quad’s graph as a Term object, but factToQuad passes that object through stringToTerm which expects it to be a string. stringToTerm does not find a .length property on the graph Term object, concludes it must be an empty string, and returns the default graph.

Thanks for reporting this!
I've created a PR that should resolve this (https://github.com/jeswr/hylar-core/pull/156/files) however I want to add a few more tests to ensure that this does not introduce any breaking changes for how triples are inferenced before merging it to the main branch.
Would this fix introduce any breaking changes in the project you are working on?

I’m not very far into my project yet. In fact, I am not even sure whether I should try to use proper quads (i.e. rely on the graph property) in my application. I am an absolute noob in RDF and I confess I have not read all available specs.
How is inferencing expected to work across graphs anyway? Suppose:
@prefix : <#>.
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>.
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>.

:Foo a rdfs:Class.
:prop a rdf:Property; rdfs:domain :Foo; :rdfs:range :Foo.

:john :said {:foo :prop :bar}.

It looks like a reasoner should be able to infer that :foo a :Foo. :bar a :Foo., but in which graph should those two quads be? Probably not in the default graph because that inference is based on what John said; but also probably not in the graph that represents what John said. Especially if we start inferring from things said by different people.

:tada: This issue has been resolved in version 1.1.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

It looks like hylar-core is currently just adding new quads to the default graph (I ran tests on version 1.1.4 and 1.1.5 of hylar-core). When I have time I will look at the original implementation of HyLAR to see if this is the intended behavior or a bug I introduced when extracting the core of the engine (the latter would seem likely).


Support unary operators

There are currently a few opcodes that one would expect to use in a operator style (a opcode b) rather an a functional style (opcode(a, b)) but they are unary rather than binary (1 arg instead of 2). e.g !, ~, b~.
This PR adds support for these so we can write stuff like assert(!x).

Hah! That is true. I just got into a pattern of wrapping the expression in
assert to make a statement without thinking wether it's valid or not - as
you say I'm just testing the teal output here.
This should raise a type error though so it brings up another issue. Thanks!
On Thu, Sep 22, 2022, 9:26 AM nullun @.***> wrote:

@.**** commented on this pull request.
In tests/test.py
https://github.com/Hipo/tealish/pull/5#discussion_r977247038:

       'pushbytes "\x00\x00\x00\x00\x00\x00\x00\x00"',

       'b~',

       'assert',

I appreciate you likely already know and are just checking the translation
is correct, but assert can only accept uints. Would
assert(btoi(b~"\x00\x00\x00\x00\x00\x00\x00\x00")) be a better test here?
—
Reply to this email directly, view it on GitHub
https://github.com/Hipo/tealish/pull/5#pullrequestreview-1116451307, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADPAZDNSU6I6Q2F4SRQ6G3V7P3Z3ANCNFSM6AAAAAAQSWDUBI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Article arrequest

Related Issue
No response
Description
We have a new article getting ready to be published that will require a graphic.  Pr #977
Title: Creating a Historical Data Dashboard with InfluxDB and Node-RED
The graphic can be some what similar to the graphic created for https://flowforge.com/blog/2023/07/connect-node-red-to-influxdb/

Hi @iskerrett would this image make sense?

Or the Node-RED app should be in FFcloud?

Yes, thanks

Yes, thanks

Do you mean "yes, it makes sense as it is", or "yes, it should be inside a cloud with FF logo as it is here"?

Yes, thanks

Do you mean "yes, it makes sense as it is", or "yes, it should be inside a cloud with FF logo as it is here"?

Sorry I respond to the first question 'would this image make sense?'.  Yes it does make sense.  We don't need the FF Cloud logo here.


[core] open up visibility of build steps

Description of the issue:
Jib-core has all the internals to introspect an image (check its "dockerfile" or equivalent - typically grab it entrypoint and layers) but it is not public and jib enforces to create a tar - and loose some of these info - or another image - and then use docker to get the info instead of jib.
Concretely exposing Image would benefit the library IMHO.
Expected behavior:
Build steps should be usable outside the builder API of jib - or a new (introspect/fetch) builder api enabling to use steps more precisely.

Closing as part of cleanup. Please re-open if it's still relevant.

@mpeddada1 was it fixed? If not it is worth keeping it open I guess.

@rmannibucau thanks for the question. Changed the status to "Close as not planned"  given the availability of a workaround (https://github.com/GoogleContainerTools/jib/issues/2045) and as we don't plan on implementing this any time soon. We're happy to re-open this issue as we gain more interest from the community.

Well workaround is to use reflection and request mainly changing the scope of some classes, would a PR help so solve that or is the feature unwanted in upstream codebase?

@rmannibucau Relaxing visibility on these APIs would enable usecases for Jib codebase that we don't want to support. Every new public API removes our ability to refactor the codebase, since people end up depending on those.
You are welcome to use Jib codebase for inspiration, but as a team, we are intentionally restricting open surfaces to make Jib both fit for purpose and easier to maintain.

Ok, then if this particular issue is not desired, the linked one should be reopened since use case is not handled (whatever tech solution is used).

We are not planning to support the repackaging usecase with Jib, sorry.


TerraformStartDirectoryPlugin - Change the starting execution workspace directory

https://github.com/manheim/terraform-pipeline/issues/309

Codecov Report

Merging #398 (0308abf) into master (f7ec7b6) will decrease coverage by 0.39%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   81.11%   80.72%   -0.40%
==========================================
  Files          53       54       +1
  Lines        1483     1494      +11
  Branches      323      326       +3
==========================================
+ Hits         1203     1206       +3
- Misses        125      130       +5
- Partials      155      158       +3

Impacted Files
Coverage Δ

src/TerraformStartDirectoryPlugin.groovy
27.27% <27.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ec7b6...0308abf. Read the comment docs.

Thanks for the contribution!  It's looking good so far.
No rush if this is a WorkInProgress, but before you're ready to merge, the coverage reports show a lack of coverage in 2 methods - withDirectory, and addDirectory.
Typically for configuration methods like withDirectory, I simply validate that the method is fluent (that it can be chained with other methods, by returning itself).  Eg: FlywayMigrationPlugin.withEchoEnabled() - https://github.com/manheim/terraform-pipeline/blob/95077845e4324d4ba45850fbd3c573ff97fe8a6a/test/FlywayMigrationPluginTest.groovy#L71-L79
For methods like addDirectory, it's exercising Jenkinsfile DSL methods.  MockWorkflowScript is available to make testing those methods easier.  There usually 2 general things I test for:

if it's meant to wrap around other code, it's REALLY important that the wrapped code actually executes.  A failure to execute the wrapped code means the Stages basically do nothing.  So for all Jenkinsfile DSL closure methods like addDirectory, you'll typically see a runsTheNestedClosure to guarantee that a problem like that doesn't slip through.  https://github.com/manheim/terraform-pipeline/blob/95077845e4324d4ba45850fbd3c573ff97fe8a6a/test/FlywayMigrationPluginTest.groovy#L84-L94
it does the thing it was intended to do.  In your case, call the Jenkinsfile DSL dir method.  That's can be accomplished by a verify assertion on MockWorkflowScript.  Eg: https://github.com/manheim/terraform-pipeline/blob/95077845e4324d4ba45850fbd3c573ff97fe8a6a/test/FlywayMigrationPluginTest.groovy#L96-L108

Looks great, thanks for the contribution!


Release 0.3.4 - Changes to environment data source

Changes

#255 - Add new datasource dbtcloud_environments to return all environments across an account, or all environments for a give project ID

Behind the scenes

Move the dbtcloud_environment datasource to the Terraform Plugin Framework

CI passed 🚀


Not able to login Into Linux Academy

I am able to login into Linux academy from browser, but via linuxacademy-dl command line i am unable to login . My account is not also free account, i have purchased via by paying money, i have passed the username and password also in "" or '' inside this quote also .
C:\Windows\system32>linuxacademy-dl help
Username / Email<EMAIL_ADDRESS>Password:
ERROR    Unknown Exception
ERROR    list index out of range
Traceback (most recent call last):
File "c:\python27\lib\site-packages\linuxacademy_dl\cli.py", line 203, in main
output_folder, args['use_ffmpeg'], args['video_quality']

File "c:\python27\lib\site-packages\linuxacademy_dl\linux_academy.py", line 10
9, in init
course_id=self.get_course_id(course_url),
File "c:\python27\lib\site-packages\linuxacademy_dl\linux_academy.py", line 12
5, in get_course_id
return int(url.rsplit("/", 1)[1])
IndexError: list index out of range
INFO     Please report this issue on https://github.com/vassim/linuxacademy-dl/i
ssues. Make sure you are using the latest version. Be sure to call linuxacademy-
dl with the --debug flag and include its complete output.
C:\Windows\system32>linuxacademy-dl -u<EMAIL_ADDRESS>-p xxxxxxxxxxxxx
https://linuxacademy.com/cp/courses/lesson/course/1711/lesson/1/module/171 --de
bug
INFO     Debug log file created at C:\Users\Eamrban\linuxacademy-dl\log\log_2018
-06-23_16-06-00.log
DEBUG    Python: CPython 2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, 20:53:40) [M
SC v.1500 64 bit (AMD64)]
DEBUG    Platform: Windows-7-6.1.7601-SP1 [6.1.7601]
DEBUG    OS: Windows - 7 6.1.7601
INFO     Logging in ...
ERROR    Username or email not found! Please try again.
C:\Windows\system32>

Check #60 pull request ;)

Does not see to work if you login using google account.


multiple worlds setting

What and How?
A way to exclude worlds (which have no effect on the plugin) would be nice. So that you can deactivate it on one world, but not on another and the setting on world 1 has no effect on world 2.
Why?
It makes sense for several worlds.
Are there alternatives?
not really
Checks

[X] I have used the search at least once to check if my idea has already been suggested and perhaps already implemented.

Anything else
No response

So something like this in the config?
# A list of worlds where the plugin won't be enabled
worlds-blacklist:
  list:
    - "no_plugin"
    - "no_plugin2"

  # If true, the list of worlds above will act as a whitelist, meaning only those worlds will have the plugin enabled
  act-as-whitelist: false

Yes, exactly. Is it ready inside? I hadn't seen it in the wiki.

Yes, exactly. Is it ready inside? I hadn't seen it in the wiki.

No, no, it doesn't exist yet, I just wanted to make sure we were on the same page. I'll get it implemented right now!

Done; here's the dev build: https://github.com/srnyx/personal-phantoms/actions/runs/6857212230
Haven't tested it at all yet, and I used a new logic for it (that I haven't used in my other projects), so I'm not sure if it'll work
If you use the dev build, let me know how it goes and if you encounter any issues!

I'll try it out straight away. What I also just realised, a reload command would be quite good (to apply changes in the configs).

What I've just noticed is that you don't store the values (whether phantoms are activated or deactivated) in a file at all?

The list is maintained in the config.yml file, which is where you have to set the values

I mean each individual player.

I mean each individual player.

Oh, you want each player to be able to toggle per-world?

I am sorry if I have caused some confusion. My question about where the data is stored was not related to my original question, but was meant in general. I haven't found this data anywhere (whether a player has just deactivated a phantom or not).

I am sorry if I have caused some confusion. My question about where the data is stored was not related to my original question, but was meant in general. I haven't found this data anywhere (whether a player has just deactivated a phantom or not).

Oh I see, I'd like to keep this issue related to the original then. If you have other questions about the plugin (like that), you can ask in my Discord server.

https://github.com/srnyx/personal-phantoms/commit/fb5a029f625cd1b36dbeed705647c61159b47da0


Enhance : Header bar

The header bar has the group name -> format it to Caravel CSS standard to make it fit well @M4n0x
group name to large in the sidebar

/cib


Made site more attractive  by making some changes in css

I want to make timer more effective with shadow and look clear.
Make some changes in background of the buttons.
I want to add more customised buttons and easy to understand language.

I would like to work on this project . Please assign it to me .

How to contribute
On Mon, Jun 3, 2024, 10:39 PM Ishita Karmakar @.***>
wrote:

I would like to work on this project . Please assign it to me .
—
Reply to this email directly, view it on GitHub
https://github.com/sk66641/Random-Disco-Light-Simulator/issues/148#issuecomment-2145723030,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2V3FMNH76RZ3XQSUFVL6VTZFSPMHAVCNFSM6AAAAABIWRSZNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG4ZDGMBTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I would make the styling better by making it visually appealing and would enhance the presence by diversifying the color palette and would make it look attractive.

@piyushsahujtp
To know about contributing to our project or any project, you can checkout Learn.md

@sk66641 Assign this too if he is inactive.

@piyushsahujtp
Could you please give an update over this issue as it has been pending for over two weeks?

I'm working on it .

Yes, I am working on it.
On Sat, Jun 15, 2024 at 3:01 PM Sanu Kumar @.***> wrote:

@piyushsahujtp https://github.com/piyushsahujtp
Could you please give an update over this issue as it has been pending for
over two weeks?
—
Reply to this email directly, view it on GitHub
https://github.com/sk66641/Random-Disco-Light-Simulator/issues/148#issuecomment-2169243372,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2V3FML36EQTVQJCOGWQL7DZHQCXNAVCNFSM6AAAAABIWRSZNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGI2DGMZXGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

PR #264 by @piyushsahujtp  for this issue was not valid and it seems that no further action is needed at the moment as there has already been so many changes in the css file that has resolved this issue.

Ok, thanks for the update.
On Sun, Jun 16, 2024, 3:40 AM Sanu Kumar @.***> wrote:

PR #264
https://github.com/sk66641/Random-Disco-Light-Simulator/issues/264 by
@piyushsahujtp https://github.com/piyushsahujtp for this issue was not
valid and it seems that no further action is needed at the moment as there
has already been so many changes in the css file that has resolved this
issue.
—
Reply to this email directly, view it on GitHub
https://github.com/sk66641/Random-Disco-Light-Simulator/issues/148#issuecomment-2170941895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2V3FMI5W5WDH32MUREQ3H3ZHS3UPAVCNFSM6AAAAABIWRSZNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZQHE2DCOBZGU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Implement missing MetaData #unwrap methods

The driver currently implements some #unwrap methods but for MetaData

implement DatabaseMetaData#unwrap
implement ParameterMetaData#unwrap
implement ResultSetMetaData#unwrap
use for spaces for indentation where spaces are used
use tabs for indentation where tabs are used

Accepted the pull request. Thank you for your contribution!

Accepted pull request. Thank you for your contribution!


standardizing getter output

in phoenix code, i've started to standardize the message objects in the {key:, value:} form, for two reasons:

i can modify that wrapper object without modifying the content of the message, so i can stick on new data (eg msg.wasRead = true)
it gives me access to the msg's key

problem is that the getters are inconsistent on the output format and sometimes won't let you get it in this form

createFeedStream cant get it with keys
createHistoryStream cant get it with keys
createLogStream can only get it with keys
messagesByType respects keys opt
messagesLinkedToMessage cant get it with keys
all other link-based getters use their own format

so i'm thinking we should update the first 3 of those to respect the keys opt, and then update messagesLinkedToMessage to work like the other link-based getters
that sound good?

there's a similar problem with add, but with a different cause
muxrpc only supports callbacks with (err, value) and add does (err, value, key) so the key doesnt get sent over the wire. that's a problem for some of my code right now (i need the key)
for add i propose we either

change the cb to (err, {key:, value:}) - my preference, but possibly more work
change muxrpc to support multiple args in the callback

This is a good idea.
I'd prefer add to cb {key, value}. there might be one or two plugins that use this,
but we can change them.

ok, i'll make the changes in this branch

and then update messagesLinkedToMessage to work like the other link-based getters

looking more deeply, it makes sense that messagesLinkedToMessage is different than the other link-based getters. i updated it to have a keys: opt instead

done


Import type definition from worker script causing script to be loaded in main thread instead

Describe the bug
Importing type definition from worker script causing script to be loaded in main thread, in this case crashing the app.
The following works:
import type { WorkerFunction } from './worker.js'

But not the following:
import { WorkerFunction } from './worker.js'
import { type WorkerFunction } from './worker.js'

I've tried to reproduce this on a fresh installation on codesandbox, but was unable to.
Reproduction
https://github.com/TalismanSociety/talisman-web/pull/908
Steps to reproduce

Clone the repo
Check out the above branch
Copy /apps/web/.env.example to /app/web/.env
Go to /apps/web/src/domains/staking/substrate/validator/recoils.ts
Change import type { WorkerFunction } from './worker.js' to import { type WorkerFunction } from './worker.js'
Run the development env using the following

yarn
yarn dev

Observe that the app will now crash

System Info
System:
    OS: macOS 14.0
    CPU: (10) arm64 Apple M2 Pro
    Memory: 78.25 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.0/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm
    pnpm: 8.7.4 - ~/.nvm/versions/node/v18.17.0/bin/pnpm
    bun: 1.0.16 - /opt/homebrew/bin/bun
  Browsers:
    Edge: 120.0.2210.61
    Safari: 17.0

Used Package Manager
yarn
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This is not a bug. import type { foo } and import { type foo } has a different meaning.
https://www.typescriptlang.org/tsconfig#verbatimModuleSyntax


Refactor: Get rid of cas and casp names in project.

Our main application module is still called casp. We need to rename it, so all of the application imports should be changed from from casp.module_name.submodule_name.* to ... from cellarium_cloud.module_name.submodule_name.*?

@mbabadi please confirm what the name of the main application module should be like.


add resources to datapackage.json

The datapackage.json file describes the publicbodies dataset according to the Tabular Data Package specification. It currently references only the data/gb.csv resource. Should be updated with references to all resources in the dataset.
Note: considering each resource has to list all fields in the schema, in order to save some repetitive work, this probably should be done preferably after deciding on the pending changes to the schema (e.g. #61 #65 #68).

@augusto-herrmann great. I also note that Data Package spec supports shared schema http://dataprotocols.org/data-packages/#resource-schemas

👍
@augusto-herrmann I can update the datapackage.json, unless you are already in process. Thanks for bringing this to the forefront!

A very pertinent  observation, @rgrp, thanks!
I only really looked into this matter today. It seems the current datapackage.json is not passing schema validation with goodtables.
$ goodtables schema data/gb.csv --schema datapackage.json
...
  File "... /local/lib/python2.7/site-packages/goodtables/processors/schema.py", line 91, in schema_model
    raise e
jsontableschema.exceptions.InvalidSchemaError

But goodtables does not give a detailed description on what the actual problem preventing validation was.
@todrobbins, feel free to assign this issue to yourself if you're already into it.

Hi @augusto-herrmann goodtables expects a JSON Table Schema (example), not the full datapackage.json.
That being said, several updates to the datapackage.json do need to be made to match the current specification.  For example, license should probably be changed to an object (not an array), a field in the resources array has a name not an id, and probably some other issues.

@danfowler great points. As an aside re goodtables can we raise an issue on goodtables about it supporting tabular data packages out of the box?

A very keen observation, @danfowler.
+1 for @rgrp's suggestion. It would be very useful to check for correctness of tabular data packages on the CLI with goodtables.

@augusto-herrmann @danfowler @rufuspollock did Tabular Data Package support ever land in Good Tables? I'm currently working on a review of our datapackage.jsonand would appreciate any new insights to inform that process.

@pwalsh can you confirm? Looks like frictionless-data/goodtables-py #66 was merged and tested.

Hi @todrobbins goodtables-py and goodtables.io can both work with the datapackage.json.

@todrobbins @augusto-herrmann @rufuspollock @pwalsh  so now that goodtables.io supports Data Packages, we need to update this Data Package to the latest specs: http://specs.frictionlessdata.io/.  Goodtables.io doesn't like how it is currently structured:

I tried updating datapackage.json to current specification on a local branch. On my local machine it validates:
$ datapackage validate datapackage-with-repeated-schema.json
Data package descriptor is valid

But goodtables.io never finishes the job (and I have no idea why it would take long, anyway, considering that on my local machine it validates quite fast).
Also, some of the CSV files do present validation errors with the goodtables CLI. gr.csv, np.csv and us.csv are reported to have duplicate rows. se.csv has a blank header. nz.csv is reported to have an encoding problem. It would be nice to have an individual badge for each file. Is this possible with goodtables.io?

@augusto-herrmann great. I also note that Data Package spec supports shared schema http://dataprotocols.org/data-packages/#resource-schemas

@rufuspollock that link no longer works. I could not find a "shared schema" anywhere in the current specifications. I have thus created a topic on the Frictionless Data forums to discuss it.

With this PR datapackage.json is up to speed.


Update gradle plugin docs for 3.0 stable

#162  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rbro112 and the rest of your teammates on  Graphite


Get All Queue Items

Add a feature for getting all items in the Job Queue.

The XML schema for this API can be found at `/queue/api/schema
I will return to this task when I have more time available.


add ability to override compile command in generated req file

cc @nvie

@jazzband-bot

cc @davidovich

This would be great. We're currently running sed on the generated files to change this comment and point to the right command.

This PR is missing some tests.


RC 0.0.2 RPM fails to run postint

https://github.com/crowdsecurity/cs-blocklist-mirror/blame/a616d389a72e5398d200d67629d76681e758fd6f/rpm/SPECS/crowdsec-blocklist-mirror.spec#L66
@mmetc

I will work on these quick fixes


Vodafone - Different number of jobs on scrappers.peviitor.ro then on Vodafone Careers

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/src/vodafone/index.html
Browser: Chrome
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in browser
Click on 'Run Scraper' button
Check section 'Jobs'
Go to Vodafone logo
Click on Careers
Check jobs on Vodafone Careers

EXPECTED RESULTS:
The number of jobs on https://scrapers.peviitor.ro/src/vodafone/index.html is the same as the number of jobs on Vodafone Careers
ACTUAL RESULTS:
The number of jobs on https://scrapers.peviitor.ro/src/vodafone/index.html (198) is different then on Vodafone Careers (192)

The scraper also extracts some jobs from outside the country, but the number of jobs on peviitor is correct.


Splits test file

and places helper functions in a seperate file.
@kevgo

@kevgo, apveyor/branch is failing. it seems to be stalling somewhere. Should we still merge?

That was a hickup on Appveyor's side, I re-ran the build and it went through fine. I think one of their build boxes must have gone down while our test was running on it. Good to ship!


fix: Fixing markdown for truncated column descriptions in the table

Signed-off-by: Kristen Armes<EMAIL_ADDRESS>Summary of Changes
Markdown styling has been available for table and column descriptions, but it would not display the styling correctly for the truncated descriptions that are displayed in the table detail page under each column name. This is a small change to address that so the markdown will display correctly.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[X] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[X] PR includes a summary of changes.
[X] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[X] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

@kristenarmes @allisonsuarez do we allow markdown for column description as well? if so, could you point me the code where the limit of comment length for table and column level comment?

@feng-tao Here is the default config that defines max lengths for both. Markdown has been around for both table and column descriptions, but it just wasn't displaying correctly in the description preview under each column name before

interesting, I thought we only supported table comment markdown before :) It must be a long time since I look at this code


Use a binary search when trying to find source mappings

Last one before I go :)
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1886121 which is the first non-compiler stack when searching PRISM for "Razor" 😁
The benchmark results look pretty good, but are actually probably worse than real world, as the benchmark code has the number of locations being mapped increases with the size of the file. In the real world, I expect large files will get a huge speed boost in normal scenarios, which just map one or two positions. I could write another benchmark that just maps one location, but that feels unnecssary.

Method
Job
Toolchain
Blocks
Mean
Error
StdDev
Median
Min
Max
Allocated

Loop
Job-EJEXYW
.NET 7.0
1
121.41 ns
1.919 ns
1.971 ns
121.31 ns
119.08 ns
126.19 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
1
28.79 ns
0.599 ns
1.064 ns
28.43 ns
27.52 ns
31.64 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
1
142.07 ns
1.635 ns
1.529 ns
141.90 ns
140.08 ns
144.52 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
1
94.94 ns
0.402 ns
0.376 ns
94.80 ns
94.52 ns
95.58 ns
-

Loop
Job-EJEXYW
.NET 7.0
2
449.88 ns
4.307 ns
3.818 ns
448.83 ns
443.90 ns
457.20 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
2
55.77 ns
1.152 ns
1.183 ns
55.39 ns
54.30 ns
57.89 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
2
497.05 ns
9.147 ns
8.556 ns
496.95 ns
480.13 ns
512.26 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
2
163.87 ns
1.271 ns
1.127 ns
163.58 ns
162.38 ns
166.17 ns
-

Loop
Job-EJEXYW
.NET 7.0
3
1,011.49 ns
11.453 ns
10.153 ns
1,008.33 ns
995.00 ns
1,034.09 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
3
97.23 ns
0.657 ns
0.582 ns
97.06 ns
96.46 ns
98.49 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
3
996.09 ns
4.405 ns
3.904 ns
995.91 ns
991.04 ns
1,004.37 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
3
285.21 ns
1.583 ns
1.403 ns
285.13 ns
283.20 ns
287.96 ns
-

Loop
Job-EJEXYW
.NET 7.0
4
1,405.87 ns
16.051 ns
13.403 ns
1,406.58 ns
1,382.90 ns
1,435.57 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
4
183.43 ns
1.812 ns
1.606 ns
183.30 ns
180.03 ns
185.58 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
4
1,416.94 ns
7.961 ns
6.216 ns
1,417.48 ns
1,403.39 ns
1,425.49 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
4
433.39 ns
4.250 ns
3.549 ns
433.57 ns
422.44 ns
436.62 ns
-

Loop
Job-EJEXYW
.NET 7.0
5
2,202.38 ns
25.393 ns
22.510 ns
2,193.64 ns
2,162.36 ns
2,251.37 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
5
250.77 ns
1.980 ns
1.852 ns
250.79 ns
247.58 ns
254.48 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
5
2,357.81 ns
23.776 ns
21.076 ns
2,354.44 ns
2,333.86 ns
2,397.57 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
5
595.56 ns
4.201 ns
3.508 ns
593.86 ns
591.79 ns
602.14 ns
-

Loop
Job-EJEXYW
.NET 7.0
10
9,368.65 ns
49.970 ns
44.297 ns
9,355.35 ns
9,315.63 ns
9,442.22 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
10
480.49 ns
3.440 ns
2.873 ns
479.57 ns
476.41 ns
485.98 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
10
9,078.03 ns
74.415 ns
69.608 ns
9,066.05 ns
8,993.93 ns
9,217.77 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
10
1,314.53 ns
24.266 ns
54.772 ns
1,295.18 ns
1,251.01 ns
1,462.78 ns
-

Loop
Job-EJEXYW
.NET 7.0
20
39,055.48 ns
774.517 ns
1,825.628 ns
38,457.61 ns
36,896.37 ns
43,645.76 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
20
1,127.51 ns
21.360 ns
18.935 ns
1,121.38 ns
1,106.39 ns
1,182.33 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
20
35,422.53 ns
220.508 ns
184.134 ns
35,422.35 ns
35,079.98 ns
35,730.04 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
20
2,840.21 ns
16.334 ns
13.639 ns
2,841.09 ns
2,820.72 ns
2,868.34 ns
-

Loop
Job-EJEXYW
.NET 7.0
30
82,537.95 ns
468.859 ns
415.631 ns
82,460.77 ns
81,912.99 ns
83,465.56 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
30
2,014.56 ns
24.341 ns
22.768 ns
2,016.66 ns
1,970.81 ns
2,055.29 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
30
78,869.85 ns
797.527 ns
706.987 ns
78,931.62 ns
76,675.37 ns
79,690.09 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
30
4,575.58 ns
28.790 ns
25.522 ns
4,567.62 ns
4,535.05 ns
4,623.71 ns
-

Loop
Job-EJEXYW
.NET 7.0
40
143,284.01 ns
1,612.976 ns
1,346.908 ns
142,920.01 ns
141,638.59 ns
146,687.81 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
40
2,748.96 ns
51.230 ns
52.610 ns
2,738.13 ns
2,693.60 ns
2,875.02 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
40
137,274.99 ns
1,108.642 ns
982.782 ns
137,014.59 ns
135,858.52 ns
139,426.73 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
40
6,500.32 ns
63.546 ns
56.332 ns
6,502.47 ns
6,352.88 ns
6,585.41 ns
-

Loop
Job-EJEXYW
.NET 7.0
100
900,451.51 ns
3,086.598 ns
2,887.205 ns
899,910.60 ns
896,588.23 ns
906,437.74 ns
-

BinarySearch
Job-EJEXYW
.NET 7.0
100
9,992.34 ns
170.209 ns
150.886 ns
9,979.46 ns
9,794.22 ns
10,284.17 ns
-

Loop
Job-DSHCRS
.NET Framework 4.7.2
100
935,231.61 ns
4,127.210 ns
3,860.595 ns
935,746.78 ns
926,698.73 ns
942,571.48 ns
-

BinarySearch
Job-DSHCRS
.NET Framework 4.7.2
100
20,033.10 ns
221.366 ns
184.851 ns
19,969.20 ns
19,801.28 ns
20,436.52 ns
-

    foreach (var mapping in generatedDocument.SourceMappings)

Being greedy here, but can this one be binary-searched too?

Refers to: src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorDocumentMappingService.cs:362 in da79973. [](commit_id = da79973f341ff3d7427db028002f711dbc3b3367, deletion_comment = False)

    for (var i = generatedDocument.SourceMappings.Count - 1; i >= 0; i--)

and here?

Refers to: src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorDocumentMappingService.cs:718 in da79973. [](commit_id = da79973f341ff3d7427db028002f711dbc3b3367, deletion_comment = False)

Being greedy here, but can this one be binary-searched too?

That loop checks the mapping.OriginalSpan and hence the array is not ordered. It might be beneficial to sort then binary search, but I don't know. Maybe based on a heuristic of file size?
We could also change how we store the mappings, and store a reverse map, but need to work out if that's worth it, since that loop didn't show up in PRISM (or shows up lower?). Also if we're changing how the compiler produces the data, we can change to allow us to use the built in binary search method, and not need the lambda, but again that might not be worth it.
TL;DR I'm OOF for two weeks from Monday and ran out of time 😁

Logged https://github.com/dotnet/razor/issues/9293 to follow up on some of your suggestions @ToddGrun


copyright issue

skidded https://github.com/quickdaffy/quickmind

please stop
you are legally using the code, sure, but please stop opening useless issues


The smallest depth camera

What is the smallest depth camera that voxelsdk is known to support?

If you meant smallest in terms of resolution, then in voxelsdk we support all TI 3DTOF chipsets. All of these can be configured to use smaller ROIs than the maximum.

No, I meant in term of hardware, like this one:

The only one that you can commercially order at this time is this one:
http://www.ti.com/tool/OPT8241-CDK-EVM
The others are reference designs that TI does not currently sell.


l18n: Add zh_TW translation

[ ] Waiting for review.

Looks good to me :) Is there a reason why you marked it as draft, or is it good to go?

I have unresolved that comment. Sorry for collapsing it accidentally 😢


Improve CLI for flint_masking

Some interest has been received around using some of the masking operations for use via a cli. Upon inspection it was pretty clear the cli was out of date and fairly primitive.
This change improves the CLI, and marks an early version of the minimum box car artifact masker as deprecated and to be removed.
A separate erosion mode based on the shape of the restoring beam has also been added.
Some other bits of dead code has been removed, and some light reordering of the internals / keyword parameters.
Tests have been added for some of the new features, and some have been modified in anticipation of removing the older minimum box car artifact masker.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 92.40506% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (ddc2686) to head (a5b8161).

Files with missing lines
Patch %
Lines

flint/masking.py
92.40%
6 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   59.79%   60.32%   +0.53%
==========================================
  Files          33       33
  Lines        5686     5727      +41
==========================================
+ Hits         3400     3455      +55
+ Misses       2286     2272      -14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Not recognising my photons

I installed the Firmware Updater today. Connected my photons (2 different ones) and neither were recognised.
Both have an app installed. Do they need to be reset first?
Some of the docs talk about "devices" and some refer only to "Electrons" so I'm not clear whether photons are even supported?

Forget me... I connected a Photon and it has worked.
The other two devices are Spark Core v1.0 devices.


Add support for emitting pointer types for nullable columns

pgx/v4 supports passing and scanning into pointer types for nullable columns instead of using the standard library Null<Type> representation, which is super handy if you wind up interfacing a lot with, say, generated Protocol Buffer files using the proto3 optional flag.
This PR adds a new configuration option emit_pointers_for_null_types, which, as per the documentation line added:

If true and sql_package is set to pgx/v4, generated types for nullable types are emitted as pointers (ie. *string) instead of database/sql null types (ie. NullString). Defaults to false.

This change would be a significant quality-of-life improvement for me, but I obviously don't know if it generally fits with the philosophy of sqlc, so consider this a suggestion and please feel free to provide any feedback (including, but not limited to bike-shedding of the choice of name for the configuration parameter, if we see this feature fit for sqlc.)
Lastly, thanks all for building this tool. It's genuinely saved me tons of hours writing the same pesky boiler plate with limited guarantees.

how can I try this out? I have been looking at the alternative which is to manually override but that is pretty tedious. would like to try this out just don't know how to include it.

This was implemented before (named a bit differently), but it has been removed. #814 has a list of needed overrides. Which is a bit tedious to copy around I'd say.

@mvrhov so is it just recommend to add them manually then I'm guessing?
Thanks for this list as it does help.

For now I guess. I do like this PR because then I don't have to copy a bunch of lines into each project.

 Any chance this could be considered for a merge, despite prior history, @mvrhov?

@nickbruun It's not my decision on what's getting merged.

@mvrhov I understand – mostly just wondering what historical context you can provide since it sounds like this was tried before?

@nickbruun Sorry that I'm just getting around to getting this reviewed. I know it's been months since it was opened.
I'm onboard with this change and would like to get it merged for the pgx/v5 release https://github.com/kyleconroy/sqlc/issues/1823

Let me review the changes from pgx/v5 and I'm happy to update in accordance :)

would be good to have this feature in v5

Is this going to be merged soon? I'm using sqlc, gqlgen and gqlgenc, getting an error about String is incompatible with database/sql.NullString and I'd much rather use the pointers for null types.

Oh wow, I totally got behind on developing a coherent view on pgx/v5. Thanks for merging this!


Auto Notification of new Istio release or patching security fix of supported release

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
We are building cluster using Kubernetes and Istio as control plane and we are finding it difficult to update or upgrade istio releases. One problem is 1) Updating istio in cluster for a critical security fix 2) Upgrade to new version of Istio when existing version is not supported or when new release is available.
Questions:

How clients of istio will get notified about new releases or security fix for version they are using? Is there is any auto notification system?
What are the guidelines to keep istio in cluster updating with security or critical bug fixes?
It is a security concern if we don't pick security fixes for the istio version we are using in cluster. Suggest us way to keep cluster updated with Istio.

Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[X ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X ] Security
[X ] Test and Release
[X ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply) X
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Istio release and cve patch will be notified at multiple places: Istio slack announcement channel, istio discuss forum (https://discuss.istio.io/c/announcements/5), and istio.io news which you can subscribe with rss. The recommendation is always upgrading Istio ASAP when a security fix release is available, or is there some other guidelines you are looking for?

How to update Istio for same version to pick security/bug fixes? As multiple istio components will be already deployed in cluster, how do we bring patched istio to cluster? Can you share instructions how to do?

Is Istio component safe to upgrade to next version in production clusters with high traffic?

See istio upgrade guide: https://istio.io/latest/docs/setup/upgrade/
And yes, it is safe to upgrade Istio with live traffic.

How to update Istio for same version to pick security/bug fixes

And to clarify, any bug fixes and security fixes will be shipped with a new version of Istio.

How to update Istio for same version to pick security/bug fixes

And to clarify, any bug fixes and security fixes will be shipped with a new version of Istio.

with minor version release?

https://discuss.istio.io/c/announcements/5

IS it possible to enable email notification when new release available? and if yes, how?

Yeah you can turn on email subscription at istio forum.

One more question: For bug fixes/security issues, Do you patch all supported versions at that time?

Yes

Actually we have a complete doc about this: https://istio.io/latest/docs/releases/security-vulnerabilities/#public-disclosure


Subctl: change subctl info cmd to subctl show networks

This is sub-issue of  https://github.com/submariner-io/submariner-operator/issues/359
See enhancement: https://github.com/submariner-io/enhancements/blob/master/submariner-operator/issue-359-subctl-info-status.md

@manosnoam this part is merged now, I added you as QE and added the QE label

Thanks @maayanf24 and @mangelajo
Will it work when KUBECONFIG points to more than one cluster (i.e. merged KUBECONFIG) ?

On subctl version: dev - built from git ref: devel-1-g6dc3413
I get
subctl show networks
Error: unknown command "show" for "subctl"

On subctl version: dev - built from git ref: devel-1-g6dc3413
I get
subctl show networks
Error: unknown command "show" for "subctl"

... which is perfectly normal, you built v0.4.0 (6dc2413 is the tagged commit). You need at least 0eb4ab8a.

I've downloaded and extracted that version this morning (after #493 was already merged) from:
https://github.com/submariner-io/submariner-operator/releases/download/devel/subctl-dev-linux-amd64.tar.xz
I'll try again...

The dev tarball publication is messed up, you need https://github.com/submariner-io/submariner-operator/releases/download/devel/subctl-v0.4.0-12-g0eb4ab8-linux-amd64.tar.xz


Remove maven-settings.xml.gpg

This removes the encrypted file from the repository and uses the recommended approach in GitHub to publish to Maven Central
See https://docs.github.com/en/actions/publishing-packages/publishing-java-packages-with-maven#publishing-packages-to-the-maven-central-repository

Can we merge this one?

@middagj I think we are safe to merge this PR.


⚠ ClamAV has degraded performance

In 1820556, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 86 ms

Resolved: ClamAV performance has improved in c6a08c4 after 535 days, 3 hours, 5 minutes.


Add timestamps to output messages

There have been some problems with timeouts. This should help narrow down where some of the time is going.

@shenki suggested that I add the ability to use syslog while I'm at it, reworked the patch. I've also thrown in some minor fixes aswell.

Had two reviews on the mailing list.  Looks fine by me.  Not sure who is suppose to 'maintain' this package, but I'll go ahead and merge.


wal: fix CRC corruption on writes following write tears

lgtm. Thanks!
Defer to @xiang90

LGTM.
Before merging this, @gyuho can you run this patch with failpoint enabled and qps=2500?

@xiang90 Ok let me test run this with failpoints.

@heyitsanthony Let's get this merged! Confirmed this fixed the wal corruption issue.


Using join with ActiveQuery causes quoting of the second column in ON condition

Example:
$query->leftJoin(
    'procedural_tasks_bases_positions',
    ['procedural_tasks.base_id' => 'procedural_tasks_bases_positions.base_id']
);

Generated SQL:
ON "procedural_tasks"."base_id"='procedural_tasks_bases_positions.base_id'

Why this 'procedural_tasks_bases_positions.base_id' is quoted? It shouldn't be like so.
As the result I have the error:
ERROR: invalid input syntax for integer: "procedural_tasks_bases_positions.base_id"

As a workaround we can wrap right part with yii\db\Expression or write it as string, but array is more readable and cleaner IMO.

Can confirm, always had to do something like
$query->leftJoin(['r' => $subquery], ['r.id' => new Expression('[[b]].[[id]]')]);

why do you think that this array syntax should work? the documentation states that it is the same syntax as used in WHERE where you have column => value relation and not column => column...?
If you want to have a column to column comparison, you have to use a simple string.

this is a duplicate of #7549 btw

It's weird. Why not to use array syntax as an alternative as it's done in where condition, etc.?

And most of the times with join we need column => column association, not column => value.

how would you decide whether 'somestring' => 'somestring' is column => column or column => value?

@cebe i've never seen sql where column => value condition has been used in ON. Have you?
I agree with @arogachev in this case.
Can you give more detailed explanation?

this is quite common:
JOIN sometable s ON s.type = 'whatever' AND s.id = otherid

ohhh, sorry, you're right :smile:


set_data_source method is not exists

Hi,
trying the example code shown in the descripion page reveals that the method set_data_source() is not present in the main plugin functions.
Is it possible to have a working example demo?
Thanks in advance.
-j

Hi jospic,
It was my fault, I refactored some code and forgot to create a new branch, I'm still learning to use GitHub correctly.
I will update the documentation as soon as possible, thanks for the feedback.


Added accessTier check to download call for BlobHandler.ts to fail on…

… archived blobs.
#2473
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination

For Azurite V3, please send PR to main branch.
For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in Upcoming Release section in ChangeLog.md.
Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

@microsoft-github-policy-service agree


Can't be set '/' proxy path in Angular17

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Angular start fails when setting a '/' proxy path.
Screenshot:

It looks like Angular returns the proxy data directly after startup, but in fact proxyConfig should only be for HttpClient.
Minimal Reproduction

Create new angular
Add proxy.conf.json config:

{
  "/": {
    "target": "http://localhost:9103/",
    "secure": false,
    "changeOrigin": true,
    "headers": { "Connection": "keep-alive" }
  }
}

Add "proxyConfig": "proxy.conf.json" in angular.json

"serve": {
  "configurations": {
		"development": {
+			"proxyConfig": "proxy.conf.json"
		}
  }
}

Update app.config.ts

import {
  APP_INITIALIZER,
  ApplicationConfig,
  Injectable,
  inject,
} from '@angular/core';
import { provideRouter } from '@angular/router';

import { routes } from './app.routes';
import { HttpClient, provideHttpClient } from '@angular/common/http';
import { Observable } from 'rxjs';

@Injectable({ providedIn: 'root' })
class StartupService {
  private http = inject(HttpClient);

  load(): Observable<any> {
    return this.http.get('/');
  }
}

export const appConfig: ApplicationConfig = {
  providers: [
    provideRouter(routes),
    provideHttpClient(),
    StartupService,
    {
      provide: APP_INITIALIZER,
      useFactory: (startupService: StartupService) => () =>
        startupService.load(),
      deps: [StartupService],
      multi: true,
    },
  ],
};

Exception or Error
No response
Your Environment
Angular CLI: 17.0.0
Node: 18.16.0
Package Manager: yarn 1.22.19
OS: darwin x64

Angular: 17.0.1
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0
@angular-devkit/build-angular   17.0.0
@angular-devkit/core            17.0.0
@angular-devkit/schematics      17.0.0
@angular/cli                    17.0.0
@schematics/angular             17.0.0
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?
No response

It looks like Angular returns the proxy data directly after startup, but in fact proxyConfig should only be for HttpClient.

I don't know where this expectation comes from, but it does not align with my expectation. All traffic goes through the proxy server, so routing / to a different host will then cause all requests to be proxied as requested.


Core Update fails to stop core

Describe the bug
During a core update, the script is supposed to stop core relay and forger before applying changes.
It doesn't.
To Reproduce
A > U
Y

Seems to have been fixed by now.


Update BillingInfo.cs (Adding PayPal)

Adding ability to create billing info for PayPal payers.

@aknazhansk Thanks a lot for catching this! I will review today.

:+1:


Add simple clean option for overwriting existing installation.

Potentially fixes #121.

I'm sorry, but as I said in the issue, this isn't the place for this functionality.
You'll need to create a script that is using the installer API and implement the clean function in that script, calling it before invoking installer.install.

You'll need to create a script that is using the installer API and implement the clean function in that script, calling it before invoking installer.install.

How do I access this root_scheme variable before invoking installer.install? It's using an API internal to installer _process_WHEEL_file normally so can't easily fetch it from an external script AFAIU without using an internal unstable API.

It's looking up Root-Is-Purelib key in the WHEEL file. You can access it yourself, by looking it up by parsing the file using parse_metadata_file.


Update README.md

Description
I've completed a content review and made edits to the README.md file as part of AHA Epic DAF-303. This review is related to the following issues:
https://github.ibm.com/GoldenEye/issues/issues/7807
https://github.ibm.com/Bluemix/docs/issues/10672
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

No release required.

/run pipeline

:tada: This PR is included in version 1.1.5 :tada:
The release is available on:

GitHub release
v1.1.5

Your semantic-release bot :package::rocket:


Error event on form

Describe the feature
Let's say I want to track user's failed attempts at submitting, or I want to track whenever a field shows an error message, shouldn't there be an error event on the <FormKit> component?

I want to track via Google Tag manager every time a user tries to submit a form that has some errors in it/I want to track users input errors :)


🐛 [firebase_dynamic_links] Null safety warning missing

I upgraded my Flutter app to Null Safety after running flutter pub outdated --mode=null-safety, which prints:
Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

Package Name       Current  Upgradable  Resolvable  Latest

direct dependencies: all support null safety.

dev_dependencies:
build_runner       ✗1.11.5  ✗1.11.5     ✗1.11.5     ✗1.12.1
json_serializable  ✗4.0.2   ✗4.0.2      ✗4.0.2      ✗4.0.2
You are already using the newest resolvable versions listed in the 'Resolvable' column.
Newer versions, listed in 'Latest', may not be mutually compatible.

This leads one to assume that the app will run in sound null safety once you put all the required !s and ?s.
But, when trying to run the app after making all changes, the firebase_dynamic_links package  throws the following error:
Error: A library can't opt out of null safety by default, when using sound null safety.
This is because it uses the language version comment // @dart=2.9, which seems to trick flutter pub outdated --mode=null-safety into reporting full null safety support.
Please upgrade firebase_dynamic_links to null safety.

Hi @wolframm
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/5207.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you


Extended Database, EntityFrameworkCore, Validation and Mapping support added

Merge override:

CI/build - 4 failures expected; UnitTestEx needs this version to correct.
security/snyk - False positives; do not need updated Newtonsoft.Json packages as no direct dependency (not used) in identified packages.


Pagination usage by Table

Problem statment
Pagination is a useful tool for segmenting data in views, so users only see what they need, and we don't have to fetch a gajillion (real number, probably) results for them all at once. However, our pagination does fetch quite a bit. With a page size of 10, we're fetching 6 pages worth of content on the first load. To effectively tell whether or not we need to be fetching this much data on first load, we can implement app insights to show the number of times any given page number is viewed on each table.
Acceptance criteria

[x] Insights can be broken up table-by-table since not all tables serve the same purpose and each table may have different needs
[x] Azure can query the AppEvents table and find insights on which pages of a table are access, and by whom (membership metadata)
[ ] Dashboard item shows the trend of page use per-table

Developer notes

We'll need to settle on a unique event name wherever the Pagination component is rendered (e.g., "Daily Data" versus "Submissions"), but the implementation should be fairly simple!  We can track pageSize and pageNumber as custom metrics of this event.

//Pagination Usage by Table
let usg_events = dynamic(["Daily Data | Table Pagination", "Submissions | Table Pagination"]);
let mainTable = union customEvents
| where timestamp > ago(90d)
| where isempty(operation_SyntheticSource)
| extend name =replace("\n", "", name)
| extend name =replace("\r", "", name)
| where '*' in (usg_events) or name in (usg_events)
| where true;
let byTable = mainTable;
let queryTable = () {
byTable
| extend dimension = customDimensions["tablePagination"]
| extend dimension = iif(isempty(dimension), "", dimension)
};
let byCohortTable = queryTable
| project name, dimension;
let topSegments = byCohortTable
| summarize Events = count() by name, dimension
| summarize make_list(dimension,1000);    //Returns a dynamic JSON array of all the values of Expr in the group. Needed here.
let topEventMetrics = byCohortTable
| where dimension in (topSegments);
let otherEventUsers = byCohortTable
| where dimension !in (topSegments)
| extend dimension = "Other";
otherEventUsers
| union topEventMetrics
| summarize Events = count() by name, dimension
| order by dimension asc
| render columnchart
with (
xtitle="Table",
ytitle="Counts",
title="Pagination Usage by Table")

Two possible solutions for adding Member_type:

Make a table similar to what you did with the PageView by Page by Member type, so that you can see the total clicks/views of each pageNumber by member type (in separate columns)
Create a chart showing PageNumber on the x-axis, membership type by color on a stacked bar chart. Much like our existing charts, but instead of date being the x-axis, it is PageNumber.

// Table View
let usg_events = dynamic(["Daily Data | Table Pagination", "Submissions | Table Pagination"]);
let mainTable = union customEvents
| where timestamp > ago(30d)
| where isempty(operation_SyntheticSource)
| extend name =replace("\n", "", name)
| extend name =replace("\r", "", name)
| where '*' in (usg_events) or name in (usg_events)
| where true;
let byTable = mainTable;
let queryTable = () {
byTable
| extend dimActiveMembership = todynamic(tostring(customDimensions["activeMembership"]))
| evaluate bag_unpack(dimActiveMembership)
| extend member_type = iif(isempty(memberType), "unauthenticated", memberType)
| extend dimTablePagination = todynamic(tostring(customDimensions["tablePagination"]))
| evaluate bag_unpack(dimTablePagination)
};
let byCohortTable = queryTable
| project name, member_type, pageSize, pageNumber;
let topSegments = byCohortTable
| summarize PageCount = count() by name, member_type, pageSize, pageNumber
| project
["Event Name"] = name,
["Page Size"] = pageSize,
["Page Number"] = pageNumber,
p = pack(strcat(member_type, " Table Page Count"), PageCount) //Creates an object that contains keys and values i.e. {"prime-admin Table Page Count", "3"}
| summarize b = make_bag(p) by ["Event Name"], ["Page Size"], ["Page Number"] //Creates a dynamic JSON property bag (dictionary) of all the values of expr in the group.
| evaluate bag_unpack(b) //transforms the bag keys in the make_bag() output into columns
| order by ["Event Name"] asc, ["Page Size"] asc, ["Page Number"] asc;
topSegments


Support "Select All" for usual non-editable text (not only for TextField)

Currently we can only Copy it. We can implement Select All in the bounds of a single SelectionContainer

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Default Laravel AUTHENTICATION and laravel-admin. Help please

Laravel Version: 5.6
PHP Version: 7.2
Laravel-admin: 1.6

Description:
How can I use the default Laravel user model for authentication in my admin interface?
for example: if I'm authenticated in my web-site using default laravel authentication (make:auth) and if I'm an administrator, I want to be automatically authenticated in my admin interface also. how can I do it?
P.S. sorry for my english.

Hi,
It's not the purpose of laravel-admin, If you do so, you lose all the roles permissions controls.
But you can do something in "Admin/Middeware/Authenicate.php".


Adding whitespaces in a list of comma-separated values in an option argument throws an error

ATM, if you run a command that has an option that receives a list of comma-separated values as argument and you add whitespaces before or after the comma, for instance:
foo@bar:~$ zos create MyContract --init initialize --args 42, foo, bar

the following error will be thrown:
Error parsing arguments: SyntaxError: Unexpected token ] in JSON at position 6
    at parseArgs (/home/jota/work/zeppelin/zos/packages/cli/lib/utils/input.js:38:15)
    at Object.parseInit (/home/jota/work/zeppelin/zos/packages/cli/lib/utils/input.js:50:20)
    at Command.<anonymous> (/home/jota/work/zeppelin/zos/packages/cli/lib/commands/create.js:44:36)
    at Generator.next (<anonymous>)
    at fulfilled (/home/jota/work/zeppelin/zos/packages/cli/lib/commands/create.js:4:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

This is because the commander.js parse function always expects a comma-separated list of values without spaces (for options), or otherwise it will interpret the second value as another commander.js option.

I just encountered this with zos call. The actual problem is that zos call --help yields the following output:
...
--args <arg1, arg2, ...>  arguments to the method to execute
...

There's a space between arg1 and arg2, which made me think that I should also add a space when providing the arguments for my call.

Reopening because I ran into this issue still in 10/08/2020 both --help and the sdk docs show the white spaced and I got an even more cryptic error "network name must be specified" event though I did specify explicitly. This fix should be simple. Edit the SDK docs and the help message.


Merge join and init methods in videoroom demo

I don't really understand an advantage of splitting Room#init() and Room#join() into separate functions. This design leads to a weird implementation in index.ts:
room.init().then(() => room.join());

which basically means that room.join() and room.init() are called synchronously one after another. I couldn't imagine any use case of calling the room.init() without calling the room.join(), at least in terms of our demo.
If there are no clear disadvantages of merging those functions into one (e.g. simply join) I would suggest doing so.

Makes sense, PR is welcomed :)

cc @mickel8 @Rados13

I think I did it in this way as I couldnt use async functions in Room constructor so I moved Room initialization to async init function. Maybe we could make join async and move init into it?

I have created pull request closing this issue: https://github.com/membraneframework/membrane_demo/pull/165
@mickel8
I am not sure if making join async is the best option - I did it in such a manner that room.join() is now blocking. I cannot think about a situation in which something could be done meanwhile .join()'s execution.  On the other hand, making .join() asynchronous could lead to misleading usage of it as somebody could not be aware that he needs to await for it.

I think I did it in this way as I couldnt use async functions in Room constructor so I moved Room initialization to async init function. Maybe we could make join async and move init into it?

The pattern with entering async function is to create an async entry point, something like main and then run everything async inside of it (In our case running the main). Making the Room to be the entry point seems wrong.

On the other hand, making .join() asynchronous could lead to misleading usage of it as somebody could not be aware that he needs to await for it.

Most of the stuff regarding the Room is asynchronous so there is no way to skip that, anyone who uses JS should be aware of its behaviour but I can agree on that it should be a single callback.


Improve master and server logging.

Terrastore master and server console logging should be improved in order to:

- Clearly show if master or server is running.
- Clearly show the master/server version.
- Integrate application-specific and terracotta-specific logging.
- Provide an easy way to customize server logging.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 8 Feb 2010 at 11:29

Both master and server specify node type (master or server) and include version
in
every line of the stdout logs.

Moroever, server logs can be configured by changing the terrastore-logback.xml
file
into Terrastore home.

Original comment by<EMAIL_ADDRESS>on 12 Feb 2010 at 3:43

Changed state: Fixed


Fix broken npos check

Because 4 was being added to the result of rfind, the subsequent check for npos will always fail. This also means there is a risk later on of argsStart being > argsEnd. By adjusting the logic to add 4 after the npos check, the npos check will now work and the subsequent check for argsStart >argsEnd is no longer required.

@nickrandolph Hey Nick! Can you push a new update to close out this PR?

I've moved the npos change to this branch, which will be going into main as soon as a dependent change is merged.
https://github.com/microsoft/ProjectReunion/blob/user/aeloros/startuptasks/dev/AppLifecycle/AppLifecycle.cpp


https://github.com/pnp/office365-cli/issues/615 - add Microsoft Teams…

https://github.com/pnp/office365-cli/issues/615
Add a Microsoft Teams team.

Rebased and Reopened the PR after the merge conflicts.


Compress buttons.html

This is still valid HTML, while saving 39 bytes :)

Sorry about the build failure. Just fixed CI config in master.

Ah, OK I thought it was my mistake that's why I also updated the dist file.

The dist must be updated. I do have a check for consistency between src and dist, to prevent someone from inject malicious code in to minified js without being noticed.

I rebased the branch. BTW, shouldn't buttons.js be buttons.min.js and maybe loaded async or defer?

The workflow is roughly like this:

Parent page load <script async defer src="https://buttons.github.io/buttons.js"></script>.
Create <iframe> for button on DOMContentLoaded.
<iframe> load <script src="buttons.js"></script>.

The <script> in step 3 is at the same URL as the <script> in step 1. When the browser loads the <script>  in step 3, it would be fetched from browser's cache. Thus, it's not necessary to mark it as async defer.

Ah, makes sense then.


Error in Andriod: Attempt to invoke virtual method on a null reference

With the following dependencies
"react": "^0.14.8",
"react-dom": "^15.3.1",
"react-native": "^0.32.0",

It does work with the following dependencies :
"react": "15.3.2",
"react-native": "^0.34.1",

Re-installed the package.. but the issue persists. I'm using your example as mentioned.

Here same

Here solved after upgrading react-native.

Same problem here


Investigate Azure Service Bus concurrent session handling

Signed-off-by: Joni Collinge<EMAIL_ADDRESS>Description
Adds new certificate test for using sessions with the Azure Service Bus Topics PubSub component. I added this when trying to reproduce the behavior reported in the following issue: https://github.com/dapr/components-contrib/issues/3281. The test does not reproduce the issue but does add better coverage for concurrent session processing. The original issue may be linked to an invalid session ID being used so I've also added some simple validation on the session ID and message ID properties on a message.
This PR relies on the changes made here: https://github.com/dapr/go-sdk/pull/490
Issue reference
Please reference the issue this PR will close: https://github.com/dapr/components-contrib/issues/3281
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

@ItalyPaleAle just to make you aware this PR relies on this change in the Go SDK https://github.com/dapr/go-sdk/pull/490 - once that is merged I can bump this PR.

@ItalyPaleAle just to make you aware this PR relies on this change in the Go SDK dapr/go-sdk#490 - once that is merged I can bump this PR.

Sounds good. I'll move the PR to draft then until that is ready


Calling getCornerPoints throws an Uncaught (in promise) 23302432

I am trying to get the cornerPoints from a scanned image to see how wide the pdf atcually is.
However, when scanner.getCornerPoints(paperContour, image) the console will throw an ambigous error in the opencv.js file as follows uncaught (in promise) 23302432.
Below is a minimal example which shows this error (image with pdf not included)
<!DOCTYPE html>

    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Test</title>

Hello!
It seems like you misassigned the paperContour variable. It should be:
const paperContour = scanner.findPaperContour(cv.imread(image));

getCornerPoints accepts a contour as the parameter. You're passing the parsed image, not the contour.
Hope this helps!

Sorry my bad.
Works now.
Thanks so much.