Updating ClusterRole for logging-operator

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
Slack-Link

License
Apache 2.0

What's in this PR?
Fixes a bug, when installing the logging-operator-stack via helm-chart in a K8s-Cluster with PSP admission controller enabled (fluentd-pod is not starting)
Because of a missing permission, the logging-operator is not able to pass the use-permission for PodSecurityPolicies to the fluentd-pods. Giving the logging-operator-role the use-permission, fixes this issue. I put in the "*" because the verbs-list meets all verbs.
Slack-Link: https://community-banzaicloud.slack.com/archives/CGMPPBZBK/p1599121640017600
Checklist

[x ] Code meets the Developer Guide
[x ] User guide and development docs updated (if needed)
[x ] Related Helm chart(s) updated (if needed)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Updated MonoGame example

Hi, while working with TiledCS I made an updated example on how to use it with MonoGame.
It uses as much shorthands as possible and features basic tile scaling and flipping.
You can get the repo here.

That is just soo awesome, thanks a lot!! This will certainly help out other MonoGame users. Will add your repo to the readme so others can see it too. :D

I'm glad it helps, without your package would have been a nightmare to use a tilemap ✌


add new styles to phase banner, updated docs, and added to home examp…

@craig-d Both the styles and the markup will need updating in the live build. I have updated the docs and also put it in the home page example.

Looks good!


chore: Remove link locale

@nschonni : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified removal of link locale in all respective files.


API to change the in-command colours?

What new feature should Elvish have?
Right now, these are the default colors in Elvish:

But I quite like the blue color scheme that Fish uses; so I would like to be able to set those colors myself, if possible.
I looked into the store and edit hooks; but couldn't find the related hooks.
Output of "elvish -version"
0.20.1+official
Code of Conduct

[X] I agree to follow Elvish's Code of Conduct.

And so far no one has been motivated enough to write the necessary code.

An example of being motivated to work on a change that might not otherwise happen any time soon is my work to replace the Elvish daemon and dependency on the BoltDB project with a far simpler, traditional, flat-file store for shell history. When I started using Elvish I often encountered errors involving the daemon. I haven't encountered any of those problems in several years but still dislike that Elvish interactive history is stored in a huge binary blob that requires a dependency of a large project and the need for all Elvish instances to talk to a daemon over RPC to manipulate the history store. So for approximately four months I have been working on a series of changes to replace that daemon and BoltDB dependency with a far simpler mechanism that stores the history in a simple JSON encoded flat-file.
I haven't felt strongly enough about being able to customize the editor theme because the existing default theme works well enough for me given I use a terminal with a "light" (rather than "dark") background. The Elvish default colors are different from those I customized Fish, Ksh, or Bash to use but are "good enough". Passionate users like yourself, @IngwiePhoenix, are encouraged to submit changes that will benefit all users.

Closing as this is a duplicate.
I'm rewriting the TUI stack pretty soon and customizable theme will be one of the things that'll be supported.


Fixed slide width

Can swiber be like?  :
slidesPerView: auto,
freeMode: true,
slidesFixedWidth
swiper itself makes sliderPerView?

Yes

Do you want to ask a question? Are you looking for support? The Swiper forum and Stack Overflow are the best places for getting support

Please, don't use GitHub issues for questions


v0.19 breaks container methods

Describe the bug
Here's my container which works fine on v0.18.1:
# frozen_string_literal: true

require 'dry/system/container'

class App < Dry::System::Container
  use :env, inferrer: -> { ENV['RACK_ENV'].to_sym }
  use :logging

  configure do |config|
    config.logger = Logger.new($stdout)

    config.auto_register = %w[
      lib/report_service/services/persistence/repos
      lib/report_service/operations
      lib/report_service/workflows
    ]
  end

  load_paths!('lib', 'system')
end

However I just tried to update to 0.19 but when booting up it throws this error:
...gems/dry-configurable-0.12.1/lib/dry/configurable/config.rb:106:in `method_missing': undefined method `auto_register=' for #<Dry::Configurable::Config:0x00007f823e24be00> (NoMethodError)

And I try to comment the config.auto_register= lines, it then breaks with:
...system/container.rb:19:in `<class:App>': undefined method `load_paths!' for App:Class (NoMethodError)

To Reproduce
Update from 0.18.1 to 0.19.
Expected behavior
I would expect the container to boot up.
My environment

Affects my production application: I'm not deploying this
Ruby version: 2.6.5
OS: macos 10.15.7

Have you read the changelogs though? :)

Oh! my bad. Thank you for pointing it out.


Require is not defined - react-datepicker.min.js

Fresh install, typical React project:
npm install react-datepicker --save
import DatePicker from 'react-datepicker';
Pages crashes with
react-datepicker.min.js?1928:1 Uncaught ReferenceError: require is not defined

You'll need moment.js as a dependency. Please post your dependency tree if
you have already included moment.
On do 11 feb. 2016 at 20:34 Alex Wilmer<EMAIL_ADDRESS>wrote:

Fresh install, typical React project:
npm install react-datepicker --save
import DatePicker from 'react-datepicker';
Pages crashes with
react-datepicker.min.js?1928:1 Uncaught ReferenceError: require is not defined
—
Reply to this email directly or view it on GitHub
https://github.com/Hacker0x01/react-datepicker/issues/347.

I have<EMAIL_ADDRESS>installed. Which part of the tree do you want me to post... it's too big for npm to show it all I think

here's package.json
{
  "name": "gdc-submission-system-ui",
  "private": true,
  "version": "0.3.20-spr1",
  "repository": {
    "type": "git",
    "url": "https://github.com/NCI-GDC/submission-ui.git"
  },
  "homepage": "https://github.com/NCI-GDC/submission-ui",
  "author": "OICR",
  "dependencies": {
    "d3": "^3.5.12",
    "filesaver.js": "0.2.0",
    "graphiql": "^0.4.5",
    "graphql": "^0.4.14",
    "history": "1.13.0",
    "isomorphic-fetch": "^2.2.0",
    "lodash": "^3.10.1",
    "moment": "^2.11.1",
    "normalize.css": "3.0.3",
    "rc-tooltip": "^3.3.1",
    "react": "^0.14.0",
    "react-addons-css-transition-group": "^0.14.6",
    "react-datepicker": "^0.21.0",
    "react-dnd": "^2.0.2",
    "react-dnd-html5-backend": "^2.0.2",
    "react-dom": "^0.14.6",
    "react-faux-dom": "^2.1.1",
    "react-icons": "^1.0.3",
    "react-motion": "^0.3.1",
    "react-redux": "^4.0.6",
    "react-router": "1.0.2",
    "redux": "^3.0.5",
    "redux-api-middleware": "v1.0.0-beta3",
    "redux-localstorage": "1.0.0-rc4",
    "redux-localstorage-filter": "0.1.1",
    "redux-router": "1.0.0-beta4",
    "redux-thunk": "^1.0.3"
  },
  "devDependencies": {
    "autobind-decorator": "1.3.2",
    "babel": "^6.3.26",
    "babel-core": "^6.4.0",
    "babel-eslint": "^4.1.6",
    "babel-loader": "^6.2.1",
    "babel-plugin-lodash": "^1.1.0",
    "babel-plugin-react-transform": "^2.0.0",
    "babel-polyfill": "^6.3.14",
    "babel-preset-es2015": "^6.3.13",
    "babel-preset-react": "^6.3.13",
    "babel-preset-react-hmre": "^1.0.1",
    "babel-preset-stage-0": "^6.3.13",
    "babel-register": "^6.3.13",
    "babel-runtime": "^6.3.19",
    "babel-plugin-transform-regenerator": "6.3.26",
    "chai": "3.4.1",
    "chalk": "1.1.1",
    "compression-webpack-plugin": "0.2.0",
    "connect-gzip-static": "1.0.0",
    "conventional-changelog": "^0.5.3",
    "css-loader": "0.23.0",
    "david": "7.0.0",
    "eslint": "1.5.1",
    "eslint-config-airbnb": "0.1.0",
    "eslint-loader": "1.0.0",
    "eslint-plugin-babel": "^3.0.0",
    "eslint-plugin-react": "3.4.2",
    "expect": "1.13.0",
    "express": "4.13.3",
    "express-http-proxy": "0.6.0",
    "extract-text-webpack-plugin": "0.9.1",
    "file-loader": "0.8.4",
    "flow-bin": "^0.20.1",
    "graceful-fs": "4.1.2",
    "isparta-instrumenter-loader": "1.0.0",
    "karma": "0.13.19",
    "karma-chai": "0.1.0",
    "karma-chai-sinon": "0.1.5",
    "karma-chrome-launcher": "0.2.1",
    "karma-cli": "0.1.1",
    "karma-coverage": "0.5.3",
    "karma-mocha": "0.2.1",
    "karma-mocha-reporter": "1.1.1",
    "karma-phantomjs-launcher": "0.2.1",
    "karma-sauce-launcher": "0.3.0",
    "karma-sourcemap-loader": "0.3.6",
    "karma-webpack": "1.7.0",
    "mocha": "2.3.4",
    "phantomjs": "1.9.18",
    "phantomjs-polyfill": "0.0.1",
    "react-addons-test-utils": "0.14.0",
    "react-hot-loader": "1.3.0",
    "react-modal": "0.6.0",
    "react-transform-catch-errors": "1.0.0",
    "react-transform-hmr": "1.0.1",
    "redbox-react": "1.1.1",
    "redux-logger": "2.0.4",
    "sinon": "1.17.2",
    "sinon-chai": "2.8.0",
    "style-loader": "0.13.0",
    "url-loader": "0.5.6",
    "webpack": "1.12.2",
    "webpack-dev-middleware": "1.2.0",
    "webpack-dev-server": "1.12.0",
    "webpack-hot-middleware": "2.4.1",
    "escope": "3.3.0"
  },
  "engines": {
    "node": ">=0.10.0"
  },
  "scripts": {
    "start": "GDC_FAKE_AUTH=1 BASE=submission NODE_ENV=development make -j test server",
    "server:dev": "GDC_FAKE_AUTH=1 BASE=submission NODE_ENV=development make server",
    "server:stage": "GDC_FAKE_AUTH=1 NODE_ENV=stage make build server",
    "server:prod": "GDC_FAKE_AUTH=1 NODE_ENV=production make build server",
    "test": "make prepare"
  }
}

I'm not sure what's on line react-datepicker.min.js?1928, any chance to check if there's anything relevant?

@alex-wilmer, could you link us to the project that shows this problem (preferably a minimum-viable-project that shows this)?  This could be any number of things, but I suspect it might have to do with the webpack setup.

Abandoned

Webpack usually has the configuration:
  module: {
    noParse: /\.min\.js/
  }

so the file react-datepicker/dist/react-datepicker.min.js is not being parsed. This file uses the require function which is NodeJS specific function.

use
import DatePicker from 'react-datepicker/dist/react-datepicker';

This is still an issue it seems.
I'm using webpack 2.4.1, with react/react-dom 15.6.
I dug a little deeper and found out it was the react-onclickoutside package. When removing all of these calls, my app built properly. So then I tried re-adding the onClickOutside calls and upgrading to the latest version 6.1.1.
Voila it worked.
Will send a PR shortly.


add option to not blank out diagonal in plot_mod_heatmap

Thanks @rmarkello! I agree about the parameter name, mask_diagonal is better. Should I change it on my end and then do another pull request?

Codecov Report

Merging #55 into master will decrease coverage by 0.56%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   64.29%   63.73%   -0.57%
==========================================
  Files          22       22
  Lines        1249     1260      +11
==========================================
  Hits          803      803
- Misses        446      457      +11

Impacted Files
Coverage Δ

netneurotools/plotting.py
7.42% <0%> (-0.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0923c2e...fd4c051. Read the comment docs.


Adding senstoken.com to blacklist.

https://etherscan.io/address/0x22374A2E9E19bcea56E64F9De3329670CD1a458c#comments

https://urlscan.io/result/730d5f9d-4f1a-4c07-943d-b8a32d10023f#summary


Use namespaces with qhub actions to allow for dev/staging/prod

We create 3 branches :

dev => dev.jupyter.training.qhub.dev
staging => dev.jupyter.training.qhub.dev
production => => jupyter.training.qhub.dev

Modify qhub render to render when there is a merge on master
Add 3 jupyter-pr actions

Merge dev => in terraform actions , add var namespace = dev and endpoint url as dev.jupyter
Merge to staging => in terraform actions , add var namespace = staging and endpoint url as staging.jupyter
Merge to prod => in terraform actions , add var namespace = prod and endpoint url as prod.jupyter

Note: Make sure the state is maintained and duplicate resources are not created.
cc @dharhas @costrouc @tylerpotts

This would also required that we output three IPs for three namespaces.

What is the cost impact of this? Would dev/staging be running all the time?

I think only staging should do the job. We won't need dev. The cost impact would be an extra-ip cost, Also we would need one node for general nodegroup that would be running all the time
@costrouc Is this correct ?

On gcp the base additional cost would be $200/month. @prasunanand did you mean for dev and staging to point to the same url? Also this may take a few steps to get right and I think it would be good to rely on qhub init to get it setup right.

@dharhas if we don't want this to run all the time we need to work on testing and automation.

That might be a good long term goal, but it isn't necessary in the short term. We just need to understand costs and communicated that in the docs. i.e. bare cluster with no staging base cost is $200/mo, adding a staging cluster is an extra $200/mo.


Implement generating graphs from Waldur API data

Changing milestone to 3rd as creating graphs from data does not seem to be in scope yet.

Changing milestone to 4th as this is not a very high priority feature.

Back to 3rd, as at the moment we are prioritizing functionality.

Associated functional requirement: 4

Also provides implementation for request 'get_totalcosts' and UC-7.

Postponed to 4th iteration


Maven build fails

Hi there,
Tried to build from command line but the maven build fails with error message:
Could not find artifact com.aliyun.odps:odps-sdk-udf:jar:0.13.0

you may find the package in http://help.aliyun.com/view/11108327_13506337.html

bug fixed


video_player HLS plays on iOS but without sound

Steps to reproduce

Im using video_player 2.9.2 and I tried playing .m3u8 like the example below.

https://vz-1505cdb4-0af.b-cdn.net/4029bcb6-f1e8-4606-a708-c811db0e1061/playlist.m3u8
I tested it on both Android and iOS, but on iOS, there was no sound.

Then I tried using media_kit 1.1.11, and the video played correctly on iOS with sound. (same file .m3u8 above)

This is what the playlist.m3u8 looks like:
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="96a",URI="audio/96a/audio.m3u8",NAME="Default"
#EXT-X-STREAM-INF:BANDWIDTH=600000,RESOLUTION=352x240,AUDIO="96a"
video/240p/video.m3u8
Expected results

The video should play with sound on both Android and iOS.

Actual results

Works correctly on Android (video and sound)
No sound on iOS (only video plays)

Code sample
Code sample
  @override
  void initState() {
    super.initState();
    _controller = VideoPlayerController.networkUrl(Uri.parse(
        'https://vz-1505cdb4-0af.b-cdn.net/4029bcb6-f1e8-4606-a708-c811db0e1061/playlist.m3u8'))
      ..initialize().then((_) {
        // Ensure the first frame is shown after the video is initialized, even before the play button has been pressed.
        setState(() {});
      });
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.4, on macOS 14.4.1 23E224 darwin-arm64, locale en)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.95.3)
[✓] VS Code (version 1.85.2)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Hi @christianr11, can you check if you're able to play the audio with a native iOS AVFoundation AVPlayer? That is what flutter uses under the hood for iOS video. You can use the swiftui sample code from https://github.com/flutter/flutter/issues/111457#issuecomment-1245424598 to test. I tested the sample with the url but the video does not play, so this is either an issue with the avplayer or an issue with your video. Can you confirm if you get the desired behavior with the swiftui sample?

Hi @danagbemava-nc , I tested it with the SwiftUI sample from https://github.com/flutter/flutter/issues/111457#issuecomment-1245424598, the video plays but there's still no sound.

Hi @christianr11, the unfortunately, this is not an issue with the flutter video_player plugin. It's either an issue with your video or a bug in AVFoundation player. The video_player plugin on iOS/macOS wraps around functionality from the native library so if it doesn't work with the native player as well, there's not much we can do to fix it. You may try reporting this on the apple forums to see anyone offers a solution but given that at this point, it doesn't work with the native video player either, I'll be closing this.
Thank you


Could not find block with ID ****

Once running main.py
/notion-graph-view/env/lib/python3.10/site-packages/notion_client/client.py", line 126, in _parse_response
raise APIResponseError(response, body["message"], code)
notion_client.errors.APIResponseError: Could not find block with ID: **************************. Make sure the relevant pages and databases are shared with your integration.
I could not find the option to share the specific page with an integration. How can this be done?

Please refer to the README file, you have to create an integration at https://www.notion.so/my-integrations. Then share your target Notion page to the integration account.

Thank you for replying so quickly.
I have created an integration, but I could not find anywhere how to share
the page. I have found this now, since it was not under sharing, but I had
to create a new connection from a Notion page.
On Wed, 12 Oct 2022 at 15:13, Steve Sun @.***> wrote:

Please refer to the README file, you have to create an integration at
https://www.notion.so/my-integrations. Then share your target Notion page
to the integration account.
—
Reply to this email directly, view it on GitHub
https://github.com/stevedsun/notion-graph-view/issues/8#issuecomment-1276154676,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENAQ26EDDRHQ5PLGGPV4ITWC22OBANCNFSM6AAAAAARDAMSOE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Move if ( is ( a, b ) ) return true; to isEqual?

I think that seems more reasonable?

Yeah but then the question becomes: why stop there?


All replication slots are in use

PGSync version: 2.1.9
Postgres version: 13
Error Message (if any):
cursor.execute(statement, parameters)
psycopg2.errors.ConfigurationLimitExceeded: all replication slots are in use
HINT:  Free one or increase max_replication_slots.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/pgsync/base.py", line 857, in fetchone
    row = conn.execute(statement).fetchone()
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1286, in execute

 ret = self._execute_context(
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1842, in _execute_context
    self._handle_dbapi_exception(
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 2023, in _handle_dbapi_exception
    util.raise_(
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/util/compat.py", line 207, in raise_
    raise exception
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line 1799, in _execute_context
    self.dialect.do_execute(
  File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 717, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.OperationalError: (psycopg2.errors.ConfigurationLimitExceeded) all replication slots are in use
HINT:  Free one or increase max_replication_slots.

You will need to increment max_replication_slots as described here

To add to the above; if your schema name changed, pgsync will attempt to create a new replication slot with the new name whilst the old slot still exists.
If you only need the new replication slot, drop the old one with:
-- list the current slots
select * from pg_replication_slots;
-- drop the old slot
select pg_drop_replication_slot('your_slot_name');

thanks for to quick reply @toluaina @voyc-jean
I'm using a GCP managed Postgress instance on which I have multiple DB, like devdb, stagedb, qadb etc, and my current max_replication_slots is set to a maximum limit of 32, here In this scenario to increase max_replication_slots from 32 to a higher number it will require an upgrade on Postgres instance which cost to the company. which might be a case we will not go for increasing slot value. is there any other way we can drop a slot periodically which is already synced with elastic?

@AnkitKundariya When you drop a replication slot, Postgres will remove the WAL logs and new transactions will no longer be 'recorded'. Therefor, there's no way for pgsync to 'replay' those changes and sync them to Elasticsearch once the replication slot is dropped.
Your Elasticsearch index will obviously still remain populated up the the point where the replication slot was dropped, but if you want to start syncing again you'll have to re-index.
Are you certain that all 32 of your replication slots are actually active?

@AnkitKundariya
I would second @voyc-jean suggestion and clean up unused replication slots.
-- list the current slots
select * from pg_replication_slots;
-- drop the unused slot
select pg_drop_replication_slot('your_slot_name');


Menu Item offset? Deface

Is the Roles supposed to be a sub item under users?

Seems like its at the root level. Is this a  known issue?

+1

Hello @VitaliyAdamkov
I fixed this issue with this pull request (https://github.com/boomerdigital/solidus_user_roles/pull/8). It was merge into master. Just use master version and should be fine.
Regards

Beg my pardon, but as i can see, this pull request does not fix the 'Menu Item offset' issue..

Hello @VitaliyAdamkov
What I did was to put a fonts awesome icon that pushes the 'Role' word to the right, it makes it aligned with the rest of the menu elements. However, I have the 'Role' menu as an independent module, not as sub-module of the 'Users' as you pointed out (I'm not sure why, I didn't notice that before). That fix worked for me, but you are right about the offset in the sub-module, it is not fixed yet.
Regards


ArgumentNullExceptions from within SDK when looking at objects in HoloLens

Describe the bug
When in a HoloLens application, the app just randomly crashes and restarts quickly, throwing an error in the output log. This usually happens just once when looking at an object in the beginning, then doesnt happen anymore.
EDIT: Seems to happen on first detection of my hand
EDIT2: Ok nope, also happens without hand present
EDIT 3: By crashing i mean that it just throws a big exception, the view is gone for a while and then pops back up. I am interning for a company this summer working on a HoloLens project, but my internship will end soon, so I will probably not look at this again :(
Error output:
Exception thrown: 'System.NullReferenceException' in Microsoft.MixedReality.Toolkit.SDK.dll
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.Diagnostics.StackTrace.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.Reflection.Metadata.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.IO.FileSystem.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.Collections.Immutable.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.IO.FileSystem.Primitives.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.Runtime.Handles.dll'.
'UnityTest.exe' (CoreCLR: CoreCLR_UWP_Domain): Loaded 'C:\Data\Users\DefaultAccount\AppData\Local\DevelopmentFiles\Template3DVS.Release_x86.rhelsen\System.Threading.Overlapped.dll'.
Exception thrown: 'System.IO.FileLoadException' in System.Private.CoreLib.ni.dll
Exception thrown: 'System.IO.FileLoadException' in System.Private.CoreLib.ni.dll
NullReferenceException: Object reference not set to an instance of an object.
at Microsoft.MixedReality.Toolkit.Input.GGVPointer.OnPreSceneQuery()
at Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointer(PointerData pointer)
at Microsoft.MixedReality.Toolkit.Input.FocusProvider.UpdatePointers()
at Microsoft.MixedReality.Toolkit.Input.FocusProvider.Update()
at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.<>c.b__68_0(IMixedRealityService service)
at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.ExecuteOnAllServices(Action`1 execute)
at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.UpdateAllServices()
at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.Update()
at Microsoft.MixedReality.Toolkit.MixedRealityToolkit.$Invoke53(Int64 instance, Int64* args)
at UnityEngine.Internal.$MethodUtility.InvokeMethod(Int64 instance, Int64* args, IntPtr method)
(Filename:  Line: 0)
Creating controller model from platform SDK
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
Failed to obtain controller model from driver
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
Failed to create controller model from driver, defaulting to BaseController behavior
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
Creating controller model from platform SDK
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug.bindings.h Line: 45)
Exception thrown: 'System.ArgumentNullException' in System.Runtime.WindowsRuntime.dll
Exception thrown: 'System.ArgumentNullException' in System.Private.CoreLib.ni.dll
ArgumentNullException: Value cannot be null.
Parameter name: source
at System.WindowsRuntimeSystemExtensions.AsTask[TResult](IAsyncOperation`1 source, CancellationToken cancellationToken)
at Microsoft.MixedReality.Toolkit.WindowsMixedReality.Input.WindowsMixedRealityController.d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.b__6_0(Object state)
at UnityEngine.UnitySynchronizationContext.WorkRequest.Invoke()
(Filename:  Line: 0)
To reproduce
Steps to reproduce the behavior:

HoloLens app running
Look at something

Expected behavior
No random ArgumentNullExceptions from within the SDK.

We've seen this in the past in the context of holographic remoting, but in non-remoting scenarios I haven't been able to hit this - if there's a project you have that reliably repros this that would be awesome to share

Here's a link to the zipped assets and projectsettings: https://we.tl/t-UIih42bLsB
Unpacking these and building etc should run a little project on hololens that reproduces the error fairly reliably. It seems to be a little random when it gets thrown, and it happens only once per run I think.

Closing out some old issues - this one I don't think we ever got to the bottom of (I think that after the info was shared out I was also on leave for a bit, so I'm not sure that folks got a chance to take a peek).
We've made a lot of changes to the MRTK since this however (i.e. since the RC2.1). If folks are still seeing this definitely open a new issue (min repro again being super helpful for identifying what's up).


Use boot count to detect reboot if it exists

to fix #61
related to https://github.com/lyft/Kronos-Android/issues/61#issuecomment-1035936886
Using the difference between deviceCurrentTime and deviceElapsedTime can trigger false negative on isFromSameBoot.
To avoid this false-negative case, this PR uses boot count from Settings.Global.BOOT_COUNT.
For case when bootCount is not available to the device (e.g. without Android or android sdk below 24) this PR uses bootCount only when it's available. When there is no bootCount, it uses the same algorithm that has been used before this PR.

This is a great find! I never knew this setting existed. Curious to know how well this might be working with testing.


param-names and param-types overlapping

Actual Behaviour
param-names and param-types under Parameters section are overlapping.

Expected Behaviour
There should be well spacing between param-names and param-types.

Steps to reproduce it

Go to https://p5js.org/reference/#/p5.SoundFile
Move to Parameters section

Screenshots of the issue

Would you like to work on the issue?
YES
I suggest to convert the Parameters list to a table like Methods table. If NO, I would simply add spacing between them

Can be it a case of defineing a min-width on the left column instead of a hard coded width so it can expand if required?

Using min-width, we will lose the alignment.
Ex:

You could also remake this with flex alignment. The column on the left will then stretch out to be as large as the widest element, and it could be done with proportions.

@Rahulm2310 Yeah I didn't think of that. I think @nedjulius' suggestion of using flex could possibly work. I want to avoid using tables if at all possible as it isn't really semantic. If you can try flex out for this it would be great! Thanks.

Hmm, that seems to be a nice idea. Thanks! @nedjulius @limzykenneth

@nedjulius I tried using flex, but still the alignment is lost.

@Rahulm2310 it depends on how you use it. I imagine that you might have to get rid of the list to make sure everything aligns according to the max-width value (as you want two items per row), but also it's possible to achieve this by adding flex display to the single list item. Could you show your implementation?

I think instead of getting rid of the list, display:flex; justify-content:space-between assigned to each list item will work for now. Thanks! @nedjulius


Breaks on /^$/gmi (Specifically the next time the regex is changed.)

Sought out this extension to get some visual feedback when editing regexes, as I often use them in my day to day work.  However, when starting from the "empty line" regex above (/^$/gmi) and extending it, the extension host will terminate.
Versions:

Visual Studio Code 1.5.2
Ubuntu 16.04

Reproduction steps:
Two open editor panes.  Left is set to javascript, right is set to plain text.  Extension is enabled and cursor is in regex body.
plain text pane:
# Email Test Cases #

Pulled from https://blogs.msdn.microsoft.com/testing123/2009/02/06/email-address-test-cases/

TODO: Remove invalid test cases that should in fact be valid, such as the one assuming TLD validation.

## Valid Email Addresses ##

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

## Invalid Email Addresses ##

plainaddress
#@%^%#$<EMAIL_ADDRESS>@domain.com
Joe Smith<EMAIL_ADDRESS>email.domain.com
email<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>(Joe Smith)
email@domain
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
javascript pane:
var emailPattern = /^$/gmi;

To trigger an extension failure, place the cursor between ^ and $ in the javascript pane and enter a character such as e.
Expected result:
Right pane has 0 entries highlighted until finished changing /^$/gmi to something like /^email.*$/gmi, at which point entries matching that regex should become highlighted.
Actual result:
[Error] Extension host terminated unexpectedly.  Please reload the window to recover. [Reload Window]
[Error] Error from the extension host: channel closed [Close]

@SMEmp Thanks for the detailed steps to reproduce!


Add lock to shutdown_fd() callback in udp_server.c

No significant performance differences

jenkins: test this please

No significant performance differences

Test failures: #10554 #9153 #10766


Make hostname a global variable

the hname variable from main() is used in almost every function and is always passed as an argument
this makes the code unnecessarily verbose and confuses the reader
the variable should be made global and static in both mpub and msub

done in 5efb6bd


Feature/UI base path

Fix #299
I have added a property to deal with a root path on the UI side.
The property is named uiBasePath and the default value is /
Tested with the dev mode in my use case and also tested after a build, directly from the jar.

Have a look to this:
https://github.com/quarkiverse/quarkus-quinoa/issues/299#issuecomment-1495467230

Please make sure your use case can't be solved in the Vite app, because from what you said it seems to be the case.
Let's not make the Quinoa config more complex with something that we don't need (yet anyway).

I just get why we have so much trouble to clearly understand each other. This bug is a bug only when we use the "forward to dev server mode".  A you forward always on / , it will fails because the dev server cannot response. When the ui is compiled, it will work fine.
I'll change the props name but I assume that quinoa.path is not correct anymore. Maybe quinoa.devserver.path ?

Moved to quinoa.dev-server.path

I've seen your PR changes and note, thanks!
There is indeed a problem, but there might be an easier fix, I'll keep you up to date on my investigation...

I've tested dev-mode and prod mode, both works fine!

Here is the example app: https://github.com/ia3andy/vite-sub-path

Ok the host bug is in vite when the host is not set to <IP_ADDRESS>, this also works:
quarkus.quinoa.package-manager-install=true
quarkus.quinoa.dev-server.port=5173
quarkus.quinoa.build-dir=dist
quarkus.quinoa.package-manager-install.node-version=18.15.0
quarkus.http.root-path=/foo

    "start": "vite --base=/foo/ --host=<IP_ADDRESS>",
    "build": "vite build --base=/foo/",

And this time localhost:5173/foo/index.html is served (vite has a few bugs it seems :))

Hi @ia3andy ,
Indeed this solution looks more convenient.
I tried it and it works fine but it looks like spa-routing does not work. Did you try on your side?
I'll continue to test it.

Hi @ia3andy ,
Indeed this solution looks more convenient. I tried it and it works fine but it looks like spa-routing does not work. Did you try on your side?
I'll continue to test it.

I'll give a try, I haven't tested SPA routing with root-path.

@smoothdub I've tested spa-routing and it seems to work:
https://github.com/ia3andy/vite-sub-path/commit/00ea13c7401ca7ea61372dbd85c5c2dff732571a
with quarkus dev, I can hit http://localhost:8080/foo/some-route

@ia3andy Indeed it's working fine on your sample, even if I import my web app into it. Could it be because I'm still on Quarkus 2?

@ia3andy Indeed it's working fine on your sample, even if I import my web app into it. Could it be because I'm still on Quarkus 2?

To try with Quarkus 2, you need:

apply the fix on the 1.x branch of quinoa and build
switch to 999-SNAPSHOT for quinoa
make sure it's resteasy-reactive (not classic)
enable spa

@ia3andy I migrated my project to quarkus 3, still the same issue. I will continue my investigation

@smoothdub what's your config? what url exactly is not working?

@smoothdub what's your config? what url exactly is not working?

Could you change your PR with the fix please, so we can merge this

Could you change your PR with the fix please, so we can merge this. Please also rebase to 1 commit (or create a new PR)

@ia3andy you can always squash them on merge with the Squash Commit button...


Rename test_met_util.py to test_grid_to_obs_util.py

Moved the get_date_from_path() from met_util.py to grid_to_obs_util.py, therefore, make similar changes to the unit test and rename test_met_util.py to test_grid_to_obs_util.py

Removed the tests that were commented out in test_met_util.py and moved that code with updated directory to the dummy data in internal_tests/pytests/grid_to_obs_util/test_grid_to_obs_util.py


[PushNotificationIOS] Error: PushNotificationIOS.getBadgeCount is not a function.

As title, I have no idea about this. I just follow docs from official site but get this error.
here is my package and version
    "react-native": "^0.12.0",
    "react-native-device-info": "^0.5.1",
    "react-native-fbsdkcore": "0.0.5",
    "react-native-fbsdklogin": "0.0.5",
    "react-timer-mixin": "^0.13.3"

2015-12-08 16:11:26.740 [error][tid:com.facebook.React.JavaScript] 'Error: PushNotificationIOS.getBadgeCount is not a function. (In \'PushNotificationIOS.getBadgeCount()\', \'PushNotificationIOS.getBadgeCount\' is undefined)\n stack: \n  <unknown>                index.ios.bundle?…:1574\n  <unknown>                index.ios.bundle?…:58645\n  wrappedResolvedCallback  index.ios.bundle?…:58525\n  resolve                  index.ios.bundle?…:58465\n  <unknown>                index.ios.bundle?…:58529\n  wrappedResolvedCallback  index.ios.bundle?…:58525\n  resolve                  index.ios.bundle?…:58465\n  wrappedResolvedCallback  index.ios.bundle?…:58534\n  resolve                  index.ios.bundle?…:58465\n  <unknown>                index.ios.bundle?…:63012\n  <unknown>                index.ios.bundle?…:48637\n  __invokeCallback         index.ios.bundle?…:6311\n  <unknown>                index.ios.bundle?…:6227\n  guard                    index.ios.bundle?…:6182\n  <unknown>                index.ios.bundle?…:6227\n  <unknown>                index.ios.bundle?…:6224\n  perform                  index.ios.bundle?…:7769\n  batchedUpdates           index.ios.bundle?…:17281\n  batchedUpdates           index.ios.bundle?…:7072\n  <unknown>                index.ios.bundle?…:6223\n  guard                    index.ios.bundle?…:6182\n  processBatch

@andyyou getBadgeCount is a method you call on the native event passed back from the event listener.
Take a look at the example from UIExplorer here: https://github.com/facebook/react-native/blob/master/Examples/UIExplorer/PushNotificationIOSExample.js#L74.
Here you can call getBadgeCount on notification and it should work.
Hope this helps!

@christopherdro Sorry for bother you and thanks your explain. by the way if I have A and B users, B's app is not active during A send notification. popInitialNotification is the method I need when B start the app next time right? I can't find more example.

@andyyou I agree that the examples for PushNotifications are limited. I will try to get work on them when I get a chance.

Thanks :)


problems

How does it works??

Maybe try to set your Board to Arduino Mini ?

Thanks, I would try

OOPS, it doesn't work

Have you updated to the latest Arduino IDE version ?  I use Arduino Nano

Arduino Nano should work tho..

Hmm, so, I don't know why I cannot complie this code

It's 1.8.4 arduino IDE version

There is the 1.8.5 update, but I don't thinks that's the problem..
I also noticed that the first line chnaged betwin your two screenshots:
#include <Keyboard.h> to #include ""Keyboard.h", maybe that could be the problem..

I have tried all variants of this line like "Keyboard.h", <Keyboard.h>, 'Keyboard.h'

Thank you for help, but I have burned my arduino while I was brazing a button to it(((

@FCucumberGames  D: Oh noes!
https://github.com/Nurrl/Duckuino/issues/12#issuecomment-261359817 temporary workaround(too late sadly)

@Nurrl we should find a more permanent fix. Also, go ahead and push v2 if you think it's ready. I'll worry about the code optimizer later.

@Plazmaz The problem is that v2 isn't ready, I didn't made the support for DEFAULTDELAY..

And we need to figure out how to load modules without evil(eval()) also..

Hi @FCucumberGames, the v2.0-pre has been released, can you try to compile your code again ?

No, it still doesn't work. It's the same problem

@FCucumberGames If you still have the problem, I'll reopen this.


[kraken] kraken deposit addresses

This pull request adds support for protocols and tags to Kraken

any progress on this PR?
if not I will have to close it


Changes to allow to locate the app and Translation to Brazilian Portuguese

How does one set their language in this?

To add a new language, you could select the Raiblocks Project -> Info -> Localizations. There, you can see all the languages that the application currently supports. To add a new language, you could click the + button, choose the language and select only the Localizable.strings file.
In the file tree, you can see the Localizable.strings in the Raiblocks folder. If you expand you can see the languages, there is a file for each language. Choose the language you want to translate. The strings on the left side should be in English, the strings on the right side should be the translations.
If a new text is inserted into the application, it is necessary to call the localized() function ("".localized()) and add this text in all the files to be translated. If you don't add, the application uses the English text, by default.
If you change some text in English the application can't find the translation and will be shown the text in English too, until someone changes int the localizable file with the translation.
PS: I am trying to improve my communication in English, if anything is not clear, you can ask again and I will try to explain in other ways.

I was more asking about the user's experience in the app, how they select from English or Brazilian Portuguese
Keep practicing your English, glad to have you here :)

It's automatic, if the iPhone is set to Portuguese, the app will show in Portuguese, otherwise show in english.

The NanoWalletCompany is no longer supporting this app. See https://nanowalletcompany.com/ for details. Closing.


Image mixup for Gearhulks from Kaladesh Inventions

The Kaladesh Inventions edition of the Gearhulks in Kaladesh return the regular images of the Gearhulks.
Thanks for delivering a great service! 💃

this is a problem with mtgjson https://github.com/mtgjson/mtgjson/issues/226 i'll pull in the fix once it's live


correct chown to chmod

Please provide a description for what this PR is for.
sorry for the typo error. should use chmod instead of chown. also remove hadolint statement.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: clyang82
To complete the pull request process, please assign mandarjog
You can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

mixer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test istio-unit-tests-master

integ-telemetry-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-telemetry-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-unit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test istio-unit-tests-master

integ-telemetry-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clyang82, howardjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests-master

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-telemetry-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-new-install-k8s-presubmit-tests-master

integ-security-k8s-presubmit-tests-master
3618ef8502c36fe57de27ce594f02bd52a1a2ae6
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-presubmit-tests-master


[FR] - Removal of margin Fee advertisements in wallets for a Performance based metric to mitigate "Race to the bottom"

External
I propose the margin"Fee" section is replaced in the wallet with an actual ROS (return on stake) from the 3rd party sites that track this data such as pooltool (or other trusted 3rd party sites) to be aggregated inside the "SMASH" meta servers the same way data is aggregated for pool registration and this removes the "wallet" advertisement option of a low fee in exchange for one of an actual solid statistic based on pool performance.
The low numbers advertised seem to be the barrier for most delegates they automatically assume the low  margin fee = high reward. This would allow the wallet rankings and pool choices not to be made on false pretense by assumption a low fee relates to a high return but based on actual returns not the low arbitrary numbers advertised in the wallet. This should have a compounding ripple effect that should combat this race to the bottom by removing the focus from the "low" margin numbers to that of the performance rate on the pool. which actively tracks the pools return.
The metrics inside the wallet would then consist of Pledge + ROS + Saturation giving a more accurate view of a pools performance. New pools being added to the network could be exempt from the "ROS" penalty in rankings for a entry period until they have produced sufficient rewards to be calculated and ranked appropriately inside the wallet. example:  If $LIFETIME_ASSIGNED = NULL then exclude ROS rankings and base solely on pledge and saturation factors inside wallet.
I know there is a small chance this can be implemented in time before launch, however in the interim before these changes can be included i suggest the "margin" advertisements be removed from the wallets until the accurate performance from these changes can be included this should help reduce the race to the bottom on the basis of "subjective low margin" at the start and focus more on the pledge and existing rank factors included as the changes are made.
Describe alternatives you've considered
"minpoolcost"
Minpoolcost has now just made this a race to minimum pool cost vs min margin there needs to be a better solution to keep attracting growth to the network to support it for the long term and reduce the focus on these ultra low subjective "margin fees" and pending race to the bottom.

I'll pass this on to Philipp and Lars.  Delegator choices should be made on ranking (i.e. long-term network utility), which is dominated by ROS, pledge and saturation (as well as performance).  Margin and cost have some impact on this.  Even a small pledge will raise the relative ranking, allowing greater margin and cost for

The way I read this is that you are asking that wallets should rank pools not based on their cost and margin alone, but instead calculate the expected ROS, and rank by that, is that right?
If so, I have some good news: that is exactly how pools will be ranked. Ranking in Daedalus will be done based on non-myopic utility, which is just the ROS (in a non-short sighted way, i.e., expecting that everyone else makes informed delegation decisions as well). The non-myopic utility is also exposed via the API, so other tools can use it as well.
@glitch40, can you confirm that that is indeed what you are asking for?

@kantp I think he is simplu asking for removal from the UI, TBH I am against, as I think delegates should have as much information available, with that said a ? icon next to "Pool margin:" with hover an explanation could not hurt...

The way I read this is that you are asking that wallets should rank pools not based on their cost and margin alone, but instead calculate the expected ROS, and rank by that, is that right?
If so, I have some good news: that is exactly how pools will be ranked. Ranking in Daedalus will be done based on non-myopic utility, which is just the ROS (in a non-short sighted way, i.e., expecting that everyone else makes informed delegation decisions as well). The non-myopic utility is also exposed via the API, so other tools can use it as well.
@glitch40, can you confirm that that is indeed what you are asking for?

Yes and no,
I already knew about the rank calculation this is more about the psychological games being played on display inside the wallets with the margin fee.
There is a lot that has been learned from ITN and the assumptions being made on "ROS" for stake holders they are making choices based on the displayed margin fees advertisements in the wallets which are not telling the true story as far as actual "ROS"  performance of a pool for those stake holders.
The proposal was to not use the wallet as a billboard advertisement of ultra low fees suggesting a higher return but instead to use the actual return calculations displayed so stake holders can base their choice off of the return (performance of a pool) not the suggested "low margin" because they assume the fee equals a higher return when it has very little to do other than a gimmick and easy advertisement in the wallet which leads to games being played of constantly adjusting fees vs pool performance.

It seems like basic game theory here... Wal-Mart does not advertise what their profit margin is when you go to buy shampoo. They advertise that they are going to get you the products you need at a price you can afford. I fully support the idea of removing margin and fees from the wallets in lieu of displaying merely ranking and performance metrics to any investor casual enough to base their decision solely on the wallet alone.
If other pools manage to out-advertise, pledge and/or perform me and get the delegation, so be it. However, the percentages/fees that I'm charging to provide a competitive service should NOT be part of the equation for an investor IMO.

@kantp please can you review this, otherwise we can advise to go down the CIP route

Closing this. If this is still relevant please re-open.


sitemap loader : got an unexpected keyword argument 'verify'

System Info
langchain-0.0.207, osx, python 3.11
Hi @eyurtsev
I am using this example from the docs
and get the error below .
Any idea ? im kind of stuck.
Seems to work with version 202 - everything above seems broken
TypeError: ClientSession._request() got an unexpected keyword argument 'verify'
from langchain.document_loaders.sitemap import SitemapLoader
sitemap_loader = SitemapLoader(web_path="https://langchain.readthedocs.io/sitemap.xml")

docs = sitemap_loader.load()

sitemap_loader.requests_per_second = 2
# Optional: avoid `[SSL: CERTIFICATE_VERIFY_FAILED]` issue
sitemap_loader.requests_kwargs = {"verify": True}

Who can help?
No response
Information

[X] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[X] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
run code mentioned above
Expected behavior
the sitemap loader should return a list of documents

Generated by a 🤖
Answer
The issue seems to be caused by the use of the verify keyword argument in the requests_kwargs dictionary. The aiohttp library, which is used by LangChain, does not use the verify keyword argument for SSL verification. Instead, it uses ssl keyword argument.
To fix the issue, you can change the verify keyword to ssl in the requests_kwargs dictionary:
from langchain.document_loaders.sitemap import SitemapLoader
sitemap_loader = SitemapLoader(web_path="https://langchain.readthedocs.io/sitemap.xml")

docs = sitemap_loader.load()

sitemap_loader.requests_per_second = 2
# Optional: avoid `[SSL: CERTIFICATE_VERIFY_FAILED]` issue
sitemap_loader.requests_kwargs = {"ssl": True}

This should resolve the TypeError you are encountering.
Sources

langchain/document_loaders/sitemap.py

This response is meant to be helpful and give you a place to start. It is not meant to be a precise solution.
Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

thanks for the quick response. Appreciate you looking into it @devstein but it seems not to fix it.
Different keyword - same error :-)
Any other suggestion ?
Traceback (most recent call last):
File "/Users/heiko/Documents/GitHub/SiteSavvy/createIndexFromSitemap.py", line 61, in
docs = loader.load()
^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/langchain/document_loaders/sitemap.py", line 120, in load
soup = self.scrape("xml")
^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/langchain/document_loaders/web_base.py", line 198, in scrape
return self._scrape(self.web_path, parser)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/langchain/document_loaders/web_base.py", line 188, in _scrape
html_doc = self.session.get(url, verify=self.verify, **self.requests_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.11/site-packages/requests/sessions.py", line 600, in get
return self.request("GET", url, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Session.request() got an unexpected keyword argument 'ssl'

thanks @devstein I will try this out in the coming days and come back. right now it somehow worked for me to downgrade langchain and I want to finish some work before digging deeper into it. Appreciate you feedback

Hi, I am also facing the same issue. I tried your suggestions,
    sitemap_loader = SitemapLoader(web_path="https://langchain.readthedocs.io/sitemap.xml", verify=False)
TypeError: __init__() got an unexpected keyword argument 'verify'

I tried the following to fix the error. I edited the file venv/lib/python3.9/site-packages/langchain/document_loaders/web_base.py and removed verify=self.verify from lines 113 and 188
Looks like session.get does not take the paramter verify anymore. I am not sure about the right way to fix this.

This issue is caused by the latest commit - https://github.com/hwchase17/langchain/commit/2eec687474252cd8083da09ccc5ac5bf89a59611
Can you help me if this has something to do with requests version? I do not see the session.get having verify option in latest requests lib as well.

The fix is being discussed here. https://github.com/hwchase17/langchain/pull/6519

I still have this error when running the instruction code from LangChain document in my Jupyter Notebook.


No error on function with a invalid byref type parameter

Today and in the past, this compiles:
let f (x: byref<int> option) = ()

This should give an error explaining the parameter has an invalid type.
This hasn't been a problem because if you try to use the parameter or call the function, the compiler will throw. Regardless, we should throw even on this case and similar ones.

Resolved in 15.9.


Add a jobs posting page form

Context
We want to be able to add job postings. The first task is creating a form for entering a job.
This issue concerns creating a responsive form where users can add a job posting.
It should look something like this:

Expected Behavior

We are using the following components (already in the codebase) and they should not need updating: https://catalyst.tailwindui.com/
As for responsiveness, it should work like this page: https://catalyst-demo.tailwindui.com/settings
It should have the same sized text and work as shown in that page too (https://catalyst-demo.tailwindui.com/settings)
The labels and text values/placeholders should have the same as shown in the design (figma below)
This page should be feature flagged with a flag called "course-video". For an example of a feature flag see https://github.com/codu-code/codu/tree/develop/app/(app)/feature-flag-example

This is a frontend-only task that requires only the frontend aspects.
Another issue can be created to handle error handling and data validation.
Another issue can be created to handle wiring up to backend and stripe.
Additional info
Figma link to steal the text and placeholders: https://www.figma.com/design/EQIZDCfdHsQ9aG1YDK6QB5/Job-posting?node-id=0-1&t=7WoZSVfZOSM9W2aB-1

Hi Niall ! Would love to take a stab at this one, can you assign it to me under the hacktoberfest label ?

Done @slashexx

I can try this one

Hi, apologies I've got something coming up for the next few days so I won't be able to work on this. Hence I've unassigned myself, please assign this issue to someone else.
Apologies !


No push to remote repo

Hi
Thanks for this great repo! I am running into some - what I guess- basic issues.
I managed to run locally ktra, add my user and initialize with a gitlab repo as described in the book.
As well the configuration step and pushing a project into the index works - almost.
cargo publish --allow-dirty --token --TOKEN--
Updating `http://gitlab.ngs-ai.lab/eschmid/crate_ngsai/` index
Compiling abc v0.2.3 (/home/eschmid/Projects/AgnosticBamCounter/target/package/abc-0.2.3)
    Finished dev [unoptimized + debuginfo] target(s) in 35.39s
   Uploading abc v0.2.3 (/home/eschmid/Projects/AgnosticBamCounter)

So that looks good to me and the ktra index/repo reflects as well this new addition.
What is though unexpected, is that the gitlab did not receive any commit, pushes - nada.
Any idea what prevents the proper push - but no error message at all ?
Update
Sorry just to add, if I try then to add the above as a dependency for an empty project, I get
cargo build
    Updating `http://gitlab.ngs-ai.lab/eschmid/crate_ngsai/` index
error: no matching package named `abc` found
location searched: registry `http://gitlab.ngs-ai.lab/eschmid/crate_ngsai/`
required by package `goo v0.1.0 (/home/eschmid/Projects/goo)`

So it checks in the right place, but obviously the index contains nothing because the above step only did local index changes but did not push to the remove repo

Looks like your issue is related to #20

I think the problem was that I established the GitHub page without the json initially. When I tried then later it would obviously fail and I add the json file
Afterwards the described issue appeared. I think it might be a problem of order as deleting everything and repeating the steps in the proper order fixed the issue now


integration test: test what happens when the ordering service is stopped and restarted

This is not an issue for the token-sdk. The smart client handles the submission of a transaction to fabric.


⚠ Secret Website 3 has degraded performance

In 9809ad2, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 17390 ms

Resolved: Secret Website 3 performance has improved in 2e1221d after 46 minutes.


Bug: multiplication of Point by negative const produces wrong results

from fastecdsa.curve import P256
from fastecdsa.point import Point

xs = 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
ys = 0xc093ae7ff36e5380fc01a5aad1e66659702de80f53cec576b6350b243042a256
S = Point(xs, ys, curve=P256)

print(S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0xc093ae7ff36e5380fc01a5aad1e66659702de80f53cec576b6350b243042a256
# (On curve <P256>)
print((-1)*S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0xc093ae7ff36e5380fc01a5aad1e66659702de80f53cec576b6350b243042a256
# (On curve <P256>)
print(-S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0x3f6c517f0c91ac8003fe5a552e1999a68fd217f1ac313a8949caf4dbcfbd5da9
# (On curve <P256>)
print((-1-P256.q)*S)
# X: 0x2754ffb5ff6ff19af1bb2fe0ef25a22d3a28731031d319afa9bf707c3595d58d
# Y: 0x3832af93a61dc91177c094f3c1723e5a3f4e29cc9fbc862da05be393b54a9a9e
# (On curve <P256>)

version 2.1.5

This does look like a bug for the -1 * S case. I think in general multiplication by negatives isn't handled well ever since the scalar %= self.curve.q was removed in this commit. @bbbrumley @JJChiDguez - do you remember why this modular reduction was removed in the aforementioned commit?

I am agreed with you, scalar %= self.curve.q must be included... I guess it was removed by accident, those commits are concerning on the special case when the output point is degenerated (in short Weierstrass, the point at infinity does not have affine representation).

Fix is in commit d394335b6b6f71604a50f0c8336e62abd45936ff. Added a test and also double checked in the command line -
In [1]: from fastecdsa.curve import P256
   ...: from fastecdsa.point import Point
   ...:
   ...: xs = 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
   ...: ys = 0xc093ae7ff36e5380fc01a5aad1e66659702de80f53cec576b6350b243042a256
   ...: S = Point(xs, ys, curve=P256)

In [2]: print(S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0xc093ae7ff36e5380fc01a5aad1e66659702de80f53cec576b6350b243042a256
# (On curve <P256>)

In [3]: print((-1)*S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0x3f6c517f0c91ac8003fe5a552e1999a68fd217f1ac313a8949caf4dbcfbd5da9
# (On curve <P256>)

In [4]: print(-S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0x3f6c517f0c91ac8003fe5a552e1999a68fd217f1ac313a8949caf4dbcfbd5da9
# (On curve <P256>)

I think the intention was to do print((-1+P256.q)*S) in the last case rather than print((-1-P256.q)*S)? That also gives the expected result -
In [5]: print((-1+P256.q)*S)
# X: 0xde2444bebc8d36e682edd27e0f271508617519b3221a8fa0b77cab3989da97c9
# Y: 0x3f6c517f0c91ac8003fe5a552e1999a68fd217f1ac313a8949caf4dbcfbd5da9
# (On curve <P256>)

I am agreed with you, scalar %= self.curve.q must be included... I guess it was removed by accident

No, it was very much on purpose.
There is no guarantee the point is an order q point. So always reducing scalars modulo q is not computationally correct.
@AntonKueltz d394335b6b6f71604a50f0c8336e62abd45936ff is a regression.

If you want to handle negatives, I suggest

Do the scalar multiplication by the absolute value
If the scalar is negative, invert the result

Ah right, the reduction has to be by the order of the point being scaled if I remember correctly. I'm surprised the test suite didn't catch this regression when I added it back in, everything looks green still. @bbbrumley is there any fix for this that doesn't involve point counting? (I suppose this is also possibly indicative of a bug in the C code, either around assuming unsigned for the scalar or something in the ladder code).

The above method is implemented in 184beb6bcc6e52fff98cd393c310979cb49ead44, I don't think I ever fully realized the negative unary operator is commutative when doing point multiplication, nice trick.

The above method is implemented in

LGTM!

I'm surprised the test suite didn't catch this regression when I added it back in, everything looks green still.

Indeed ... I have to think about what the best test looks like in this case. In terms of the stock curves that come with fastecdsa, the only curves that can detect that kind of regression are W25519 and W448.

In terms of the stock curves that come with fastecdsa, the only curves that can detect that kind of regression are W25519 and W448.

Yes, I was thinking this too, the NIST curves all mask this issue, and I think indeed that was the origin of the %= q code as all the curves initially provided in this package were NIST curves. I can't think of a good way to test this off the top of my head either, will leave the issue open and think on it a bit. For now I'll merge the fix so that it's not causing further issues.

There is no guarantee the point is an order q point. So always reducing scalars modulo q is not computationally correct.

Can not we use the (precomputed) order of the curve? Useful also if somebody puts a huge scalar.

Can not we use the (precomputed) order of the curve? Useful also if somebody puts a huge scalar.

fastecdsa doesn't have the precomputed order of the curve. It only has the (prime) order of the generator point.

Can not we use the (precomputed) order of the curve? Useful also if somebody puts a huge scalar.

I'm not opposed to this approach but I would need someone to point me to the relevant literature or PR this as I'm a bit rusty on the details.

I'm not opposed to this approach but I would need someone to point me to the relevant literature or PR this as I'm a bit rusty on the details.

Ideally you'd add the cofactor h to the curve class
https://github.com/AntonKueltz/fastecdsa/blob/master/fastecdsa/curve.py
Then @hellman is correct -- you could do
        scalar %= self.curve.q * self.curve.h

h is 1 for all the NIST curves over prime fields. I believe it's 8 for W25519 and 4 for W448.
But it might be a breaking change. (Which I would selfishly be against, because I'm already working around it in another project.)
But OTOH this is, indeed, technically the better way to handle it.
It is also possible to "simply" calculate the cofactor on-the-fly for curves of cryptographic interest. I contributed the OpenSSL code for that some time ago. (In that notation, OpenSSL "n" is fastecdsa "q", and OpenSSL "q" is fastecdsa "p".)

Just to be clear: you cannot always calculate the cofactor like I give in the pointer. So in the end, you need the fallback code anyway -- i.e. no scalar reduction, and sign considerations -- which is what you've merged already.
For curves already built into fastecdsa, this doesn't matter because h is a precomputed constant. It's only a question of custom curves instantiated with the Curve class.

Revisiting this issue - given that the fallback code is needed anyway I'm in favor of keeping things as they are and not introducing an additional cofactor field. If anyone has objections we can discuss here.


Sample for retries with Cloud Spanner should use same SpannerConnection

(As filed by @benwulfe originally)
This is technically a sample bug. When spanner throws a transient fault, you should really try to use the same session on subsequent retries as spanner gives higher priority to retries in high contention scenarios. This can be achieved in the ADO.NET provider by using the same open connection (which reserves a single session for use).
So really the sample here:
https://cloud.google.com/spanner/docs/getting-started/csharp/#performing_retries_on_read-write_transactions
should demonstrate that. Instead of creating a new spanner connection each time, maybe we can create a helper method that takes in an open connection.

Closing for now as the Spanner provider has changed massively - reusing the same connection won't reuse the same session necessarily. At some point we'll want to add better retry handling that can reuse the session anyway, but until that point the samples don't need to be changed.


docs: add more option descriptions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[N/A] Have you written new tests for your changes? Here's an example.

[N/A] Have you successfully run brew tests with your changes locally?

Added more descriptions to the man page for command options not currently described and two more external taps, plus other random docs fixes.

Thanks so much for your repeated, excellent contributions!  You rock, @EricFromCanada!


Saving slices and adding them to dashboards directly from explore view

Coverage decreased (-0.5%) to 80.808% when pulling a124a872c31f44912eca5df5e8917c47125e289c on mistercrunch:save_slice into 4191b75966bdfec22a4dcb04eb62f6884765d55d on airbnb:master.

Coverage decreased (-0.6%) to 80.769% when pulling b18f62af90cd74c3b01e95f6e986c19a3a9ee721 on mistercrunch:save_slice into 4191b75966bdfec22a4dcb04eb62f6884765d55d on airbnb:master.

Coverage decreased (-0.4%) to 80.895% when pulling fca5ba9f8238743380bff9cc45cd957f528acb87 on mistercrunch:save_slice into 4191b75966bdfec22a4dcb04eb62f6884765d55d on airbnb:master.

Coverage decreased (-0.4%) to 80.927% when pulling 38f2d262730984296da0c9cdf6b66fc1d1be3b1f on mistercrunch:save_slice into 4191b75966bdfec22a4dcb04eb62f6884765d55d on airbnb:master.

@ascott, we should schedule time for pair programming on how to start moving towards React. i'm having a little bit React-refactor-timid. Let's take a solid first stab at it together this week.

+1 to pair programming. we could refactor this into react together.

Coverage decreased (-0.4%) to 81.01% when pulling b537645da991c82b91e324bc6a71292e902fd48f on mistercrunch:save_slice into 7a7f61a2965e0f869328da3308fae92dab859365 on airbnb:master.

ok I'm merging this for now since it addresses commonly used broken user flow, we can start refactoring to react next.


Request fast mobile-optimized face mesh

Coming soon!

We've decided not to include this in VideoKit. A better place for this is [Function](https://github.com/fxnai/fxn3d].


Google Chat has deprecated name and icon

It still has the name Hangouts and old icon.

I'd like to work on it.

what should be the replacement instead of Hangouts?

It's Google Chat now
https://en.wikipedia.org/wiki/Google_Chat
You can find the icon here https://simpleicons.org/?q=google chat

what should i put in cdn.filestackcontent.com?

what should i put in cdn.filestackcontent.com?

I think this URL isn't used anymore.

what should i put in cdn.filestackcontent.com?

I think this URL isn't used anymore.

How will the icons get displayed? i mean from where will it fetch the icon?

Either you have to upload that google chat icon to the fIlestackcontect CDN and send me the handle or one api key is needed for uploading.

No need for this fix, since we already have Google Chat.


Do not require postBuild to be executable

This is hard for windows users and from the GitHub UI,
and provides dubious benefits. So let's remove the requirement!
Fixes #240

Restarted travis. Otherwise looks good to me.

I think this test failure is real. But I don't understand why. The test suggests that the build should not succeed, and it doesn't. So the test should pass?

The failing test had a strict check for the postBuild error message, which needs to be updated now that the postBuild line is slightly changed. I added a commit that should make it a bit more relaxed.


Hiding boundaries on single row layout

Hey great work on this! Really smart and Apple-Esque implementation. I'm currently using the single row layout (numberOfRowsPerMonth = 1). Everything is working great, except that the boundary dates really do not make sense for this layout. You'll get a jump from (example May to June goes 31, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 29, 30, 31 and then back to 1 for June).
Is there a way to prevent these dates from showing, or a possibility to include this feature?
Also, is it possible to add the ability to set specific starting and ending dates for single row layout? Right now it will give the entire month it seems. So if I set the startDate as the beginning of this week and the end date today, it will give me all of May to July 9th, where I would like just this week (Sun to Sun).
Last question - currently scrollToDate scrolls to the beginning of the screen with 1 row layout. Is it possible to add the option to specify the scroll position? Perhaps let position: UICollectionViewScrollPosition = self.direction == .Horizontal ? .Left : .Top could reference a new parameter on scrollToDate?

Same problem here

Yes, this is the final upgrade of the calendar I have to work on.
I did not think about it because in my project because i do not use single rows.
Upgrade is coming soon after i finish work on the other issues. I'm almost done with them.

Thinking on your other suggestions now

Thank you 👍

Just one more thing, this:
*** Assertion failure in -[UICollectionViewData validateLayoutInRect:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit_Sim/UIKit-3512.60.7/UICollectionViewData.m:399
and this:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'UICollectionView received layout attributes for a cell with an index path that does not exist: <NSIndexPath: 0xc000000000000016> {length = 2, path = 0 - 0}'
get when you work with week calendar (one row).
And that can only happen if start app in single row, if you first start with 6 rows and then open view with single row, everything is ok.

@miff i've been doing many updates.
Since the latest update, I do not see this issue occurring.
The latest update is on master branch. I have not released a version 3.0.2 for it yet. Any change you can test it to see if its still crashing for you?

@krisanthony Ok. you have mentioned 3 suggestions, that should be tracked on 3 separate issues.

It doesn't make sense to have boundaryDates with single row mode
Add the ability to set specific starting and ending dates for single row layout? Right now it will give the entire month
Scroll to date positioning.

Can you create these 3 and close this one? Thanks.
I do not want to create them because I want because my username will be tracked as the issue creator.
After creating the 3 new ones, then close this one.

Ok done!


Remove deprecated CameraRoll component

Please select one of the following

[ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
[x] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
[ ] I am making a fix / change for the macOS implementation of react-native
[ ] I am making a change required for Microsoft usage of react-native

Summary

Remove the CameraRoll component from react-native. This was deprecated in 0.61 and removed in 0.64, so this is a potentially breaking change that will eventually be needed for the 0.64 merge.
Changelog

[macOS] [Removed] - Removed deprecated CameraRoll component
Test Plan
Since CameraRoll is an iOS-only component, this should effectively be a no-op. However, I did a quick sanity check that RNTester still compiles and runs as normal.

Before we remove it from here can we update SDX-Platform to start consuming the RNC version?

Before we remove it from here can we update SDX-Platform to start consuming the RNC version?

It's not used in SDX-Platform, and it's had a deprecation warning on it for a while, so I think we're probably okay to just remove it outright.

Before we remove it from here can we update SDX-Platform to start consuming the RNC version?

It's not used in SDX-Platform, and it's had a deprecation warning on it for a while, so I think we're probably okay to just remove it outright.

Do we not need to remove references to it first from SDX-Platform? Or are there none?


Code for print function

hello guys, sorry for Google Translate:)
could you tell me where I can find the code for the print function of all pdf pages?

https://github.com/mozilla/pdf.js/blob/master/web/pdf_print_service.js


Update addPageDir API for integrations

Currently the API for integrations looks like this:
const {
  patterns,
  entrypoints,
  injectPages()
} = addPageDir({...})

injectPages()

The problem with this API is that entrypoints is not a live array, if the patterns object is updated it will not be reflected inside entrypoints. Instead we should encourage the user to use Object.values(patterns) to compile an array of entrypoints from the live pattern reference.
Another tweak that could be made is renaming patterns to routes or pages. patterns is an object of pattern keys and entrypoint values so it would make since to rename this something more semantically correct
Also need to document manipulating the patterns object to add/remvoe pages
Future
Maybe adding utilities like addPage or removePage, although this can already be done fairly easily by manipulating the patterns object.

I updated the Integration API to:
const {
  pages,
  injectPages
} = addPageDir(pageConfig)


Can't install with Laravel Framework 9.2

Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires mll-lab/laravel-graphql-voyager v1.0.2 -> satisfiable by mll-lab/laravel-graphql-voyager[v1.0.2].
- mll-lab/laravel-graphql-voyager v1.0.2 requires illuminate/console 5.5.* || 5.6.* || 5.7.* || 5.8.* || ^6 || ^7 || ^8 -> found illuminate/console[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ...,
8.x-dev] but these were not loaded, likely because it conflicts with another require.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Made a fork and edited it till it worked, not sure on the exact versions to put in composer.json however.
https://github.com/LiamKarlMitchell/laravel-graphql-voyager/blob/master/composer.json
To load it in my project temporarily until its fixed here I put this in my projects composer.json
    "repositories": {
        "laravel-graphql-voyager": {
            "type": "vcs",
            "url": "https://github.com/liamkarlmitchell/laravel-graphql-voyager"
        }

Then I ran
sail composer require mll-lab/laravel-graphql-voyager:master

Fixed with https://github.com/mll-lab/laravel-graphql-voyager/releases/tag/v2.0.0


Auction relatedProcessID

depends on https://github.com/openprocurement/openregistry.lots.loki/pull/42

Pull Request Test Coverage Report for Build 152

40 of 40 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 95.967%

Totals

Change from base Build 147:
0.04%

Covered Lines:
2332

Relevant Lines:
2430

💛  - Coveralls


random: Replace system random calls with STL

I hit a deadlock when generate() was calling syscall(SYS_getrandom, buf, n, 0) on an embedded system. I went with a standard solution, which cut down on some code and should be more portable. I also removed the apparently unused generate_64() function. If that function is truly needed, I can update to include it.
Tested with gcc on linux, unable to test on windows.

Hello.
This looks like a good change. I asked @tampsa to review this when he has time. We will test windows and give feedback if changes are needed. Thanks!
BR, Joni Räsänen

Hi,
Thanks for the pull request, it looks good. We tested it and will merge it.
-Heikki Tampio


Gauge artifact remains after a column hit >100%

There appears to be a drawing bug, and I'm fairly certain it's in the underlying termui package.
When a containers hits >100% CPU usage, the bar will go red, but when it drops below 100% again, there's one red "pixel" stuck on the right. From a cursory glance at termui, I'd say that percentage should have an extra check for "if it's >100, cap it at 100".
Is this something that should be bumped up to termui, or is it something that can be caught in ctop itself?

I think the underlying issue is that ctop doesn't normalize CPU use based on cores. I.e. if you have 4 cores, your total cpu usage can go up to 400% (...). It should be trivial to divide this reported number by the number of CPU cores available.

Over 100% CPU on multicore system is a common thing to see, so I'm not sure that CPU normalization is the right answer here.  But can confirm the bug; after going over 100%, a red pixel is stuck.

@mcampbell for detail view I agree, only the gauge would need to be normalized to a 0-100 scale to not overlap the additional comments. Imho, displaying "144%" is still valid, so this is just a rendering issue.

Yes, 100% (normalized =) agree there; apologies if I misunderstood your intent.

Thanks all for the input; maximum gauge percent(drawn) has been capped as part of the  latest release.


Reek cleanup

Added reek linting, cleaned up issues that were found, and added support for jruby-9.

Coverage decreased (-1.1%) to 98.901% when pulling 04eebfbde073315bdd03edfe147d32feadfce48c on reek_cleanup into 2356add6a35c013bdd7c4138a9e8ff0c53a0a731 on master.


Use Azure DevOps UI Colors to match with the current theme

Hi,
First of all, thank you for this great extension.
It gives me exactly what I need.
However, there is one small thing that bothers me
When using the dark theme, the text of the response cannot be read.

This change adapts the result box to the currently selected theme.
Dark:

Light:

Hi, thank you for your commit. From the looks of it, it should work just fine, but when these variables that are in azure devops ui (I double checked to make sure they are there) are used, it fails to compile for me. It gives a Syntax error Unclosed block. It does appear like it compiles on your end, otherwise you wouldn't have the screenshots. Very strange unexplainable behaviour. Anyhow, I'm publishing a workaround for it.

If you know of a fix, that'd be great. Unsolved mysteries.

Hi,
it seems like an issue with webpack --mode development / production.
On my side i only ran npm run build:dev
I should have used npm run build
Running with npm run build:dev it works fine

with npm run build i get the same error:


fix: remove react cdn

Description
Please include a summary of the change and which issue is fixed.
List any external dependencies that are required for this change.
Addresses: AB#FILL_IN_YOUR_ISSUE_ID
Checklist

[ ] My code follows the style guidelines of this project
[ ] Documentation and comments is added where needed.
[ ] My code is covered by tests.
[ ] UX has reviewed relevant UI contributions.

Definition of Done

[x] PR title and description are to the point and understandable
[x] I have performed a self-review of my own code

@Gustav-Eikaas du merger denne når du mener det er forsvarlig ;)


Issue with esvm_demo_apply_exemplars

Hi,
When trying to run your code, I get an error saying
"Undefined function or variable 'features' "
Error in esvm_detect>esvm_detectdriverBLOCK (line 255)
templates = zeros(S(1),S(2),features,length(models));
"features" looks like an integer value which has not been initialized. Can you tell me what value it should take?
I am running this code on Windows XP.

Hi, I am able to work around that issue. It seems that Matlab was not able
to locate the function "features" in the features directory.
On Thu, Jan 19, 2012 at 4:25 AM, Tomasz Malisiewicz <
<EMAIL_ADDRESS>
wrote:

Hey, you must have checkout out the code in the middle of an edit.  That
line has since then been changed, let me know if you are still having
issues, or if the issue went away.
--Tomasz

Reply to this email directly or view it on GitHub:
https://github.com/quantombone/exemplarsvm/issues/45#issuecomment-3554765

Ok cool, I replaced features.m with esvm_features.m to avoid conflict with Pedro's features.m
If you do a git pull, you'll get the most recent changes which are working as advertised.
--Tomasz


XML documentation tags: outdated information about Intellisense tooltips

The section about the <summary> tag says "The text for the <summary> tag is the only source of information about the type in IntelliSense".
This is no longer correct, since some version of VS2019 the contents of <remarks> are also displayed in the tooltip.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3bcb925f-ef72-9a64-3762-c0b4a96f9dc4
Version Independent ID: d135d0a6-53d2-1567-0b1b-7aae5e07739f
Content: Recommended XML documentation tags for a class and its members
Content Source: docs/csharp/language-reference/xmldoc/recommended-tags.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Thanks for noting this @mdro
I've added this to our backlog to address when we next update this article. I've also added the "up for grabs" label if anyone wants to submit a PR in the meantime.

I'm not seeing the remarks in the Tooltip. Can you share a screenshot?

I'm not seeing the remarks in the Tooltip. Can you share a screenshot?

I'm getting some error while uploading, but it's simply summary, empty line, remarks in the box.
Note that it does not appear for the standard library or any of the handful of Nuget.org packages I checked. Presumably they don't include their remarks in the code or strip the xml file.
But it does work for our own code, even when consumed as packages from our private repo.

I do see remarks in the IntelliSense XML files for the .NET library. So I'm not sure what's causing the remarks to display in your case.


Add support for exec credentials for kubernetes and helm providers

Describe the solution you'd like
I want to be able to use exec credentials with the kubernetes provider.
Describe alternatives you've considered
I have considered installing the cli in the job before the terragrunt action but that didn't work.
Additional context
I get:
Error: Kubernetes cluster unreachable: Get "https://<guid>.gr7.us-east-1.eks.amazonaws.com/version": getting credentials: exec: executable aws not found
│
│ It looks like you are trying to use a client-go credential plugin that is not installed.
│
│ To learn more about this feature, consult the documentation available at:
│       https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins
│
│   with helm_release.argocd,
│   on argo.tf line 1, in resource "helm_release" "argocd":
│    1: resource "helm_release" "argocd" {

When I try to use these credentials:
data "aws_eks_cluster" "main" {
  name = var.cluster_name
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.main.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.main.certificate_authority[0].data)

  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    args        = ["eks", "get-token",
        "--cluster-name", data.aws_eks_cluster.main.name,
        "--role-arn", var.deployer_iam_role_arn]
  }
}

provider "helm" {
  kubernetes {
    host                   = data.aws_eks_cluster.main.endpoint
    cluster_ca_certificate = base64decode(data.aws_eks_cluster.main.certificate_authority[0].data)

    exec {
      api_version = "client.authentication.k8s.io/v1beta1"
      command     = "aws"
      args        = ["eks", "get-token",
        "--cluster-name", data.aws_eks_cluster.main.name,
        "--role-arn", var.deployer_iam_role_arn]
    }
  }
}

The action actually runs as part of a Dockerfile, so it won't have access to anything you install outside of the container it runs.
If you would like to have Terragrunt available in the GitHub Actions runner you are operating in, consider using a tool like mise-action to install Terragrunt directly, along with any other tools you want to use before running Terragrunt.


zsh, history file in metafied format improperly imported

I recently imported history of zsh into atuin and found that many lines of history were not properly imported. I googled and found stackoverflow question which mentioned thread in the zsh-users-help mailing list, which suggests that:

the history file is saved in metafied format.

i.e in order to unmetafy, each line should go through unmetafy.
Demonstration of the issue
Command executed:

History file:
$ cat ~/.tmp/aaa/history
:<PHONE_NUMBER>:0;историу�
$ cat ~/.tmp/aaa/history | hexdump -C
00000000  3a 20 31 36 38 33 35 38  38 30 38 34 3a 30 3b d0  |:<PHONE_NUMBER>:0;.|
00000010  b8 d1 81 d1 82 d0 be d1  80 d0 b8 d1 83 ef bf bd  |................|
00000020  0a                                                |.|
00000021

Importing into atuin:
$ export HISTFILE=~/.tmp/aaa/history
$ atuin import zsh

and result is improperly imported text:

I would expect to see following line in history:

Interesting. The equivalent rust would be
fn unmetafy(s: &mut [u8]) -> &mut [u8] {
    const META: u8 = 0x83;

    let mut p = s.iter().position(|&c| c == META).unwrap_or(s.len());

    let mut t = p;
    while p < s.len() {
        s[t] = s[p];
        p += 1;
        if s[t] == META {
            s[t] = s[p] ^ 32;
            p += 1;
        }
        t += 1;
    }
    return &mut s[..t];
}

I've confirmed this is equivalent to the C output, but I can't get either to actually work with your input. There must be more to this

Interesting. I've spent few more minutes trying to figure out what's going on and it seems that my test history file was somehow corrupted at the first record. I just added few more test records and they were properly proceeded by unmetafy function.
Source:
$ cat history_test.txt
:<PHONE_NUMBER>:0;историу�
:<PHONE_NUMBER>:0;историу�
:<PHONE_NUMBER>:0;историу�2
:<PHONE_NUMBER>:0;историу�3

Converted:
$ cat history_test.txt | ./unmeta
:<PHONE_NUMBER>:0;истори�Ͽ�
:<PHONE_NUMBER>:0;история
:<PHONE_NUMBER>:0;история2
:<PHONE_NUMBER>:0;история3

Here is my test history file for you to play and/or add to tests:
history_test.txt

Yeah I would just remove the first line from the testing since as you noted, it's somehow corrupted.
use std::io::{self, Read, Write};

fn unmetafy(s: &mut [u8]) -> &mut [u8] {
  // use code above...
}

fn main() {
    let mut x = Vec::new();
    io::stdin().read_to_end(&mut x).expect("test1");
    let mut out = std::io::stdout();
    out.write_all(unmetafy(&mut x)).expect("test2");
    out.flush().expect("test3");
}

After removing the corrupted line, the other lines seem to have the correct output in rust (using https://git.sr.ht/~breadbox/chd to verify output):
$ cat history_test.txt | ./unmeta | chd
00000000:     3A    20    31    36    38    33    36    34     :   1 6 8 3 6 4
00000008:     34    36    31    34    3A    30    3B   438     4 6 1 4 : 0 ; и
00000010:    441   442   43E   440   438   44F    0A    3A     с т о р и я ␊ :
00000018:     20    31    36    38    33    36    34    34       1 6 8 3 6 4 4
00000020:     39    36    30    3A    30    3B   438   441     9 6 0 : 0 ; и с
00000028:    442   43E   440   438   44F    32    0A    3A     т о р и я 2 ␊ :
00000030:     20    31    36    38    33    36    34    34       1 6 8 3 6 4 4
00000038:     39    36    32    3A    30    3B   438   441     9 6 2 : 0 ; и с
00000040:    442   43E   440   438   44F    33    0A           т о р и я 3 ␊


Support for Jpegli

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Jpegli is the new JPEG encoder from Google, open source, which is very good, and that would be really good if Squoosh implemented it
Does other service/app have this feature?
I don't think so
Additional context
Squoosh is by Chrome Labs, which is by Google, so that would be a good showcase of Jpegli for Google

Duplicate of #1408


Updated code for new Atom API.

I really appreciated this package, i.e. the notion of not necessarily folding all comments. But, it was broken (or broken with my version of Atom, which I think has the newer Atom API). I spent a little bit of time to fix it -- I think it works now.
Thanks again for putting this package out. Hopefully this helps.

Hey there! Thanks for this @etep! I have a PR that @ghivert has been working on here at #8. Would love for you two to work together on this one and figure out the cleanest way to get this pulled in :grinning:

I think it's always good to conform to new API, but Lines.startsWith("//") doesn't work with every other type of comment no ? What about /*, # or ; comment ?
If everything works, doesn't matter for me as long as behavior remains the same ! :)

Hi -
I appreciate this repo being available, it gave me enough breadcrumbs to get done what I wanted done. I had to fix it first, then change its behavior slightly. The fix is cleaner in the following sense: detecting whether a line is a comment is handled by editor.isBufferRowCommented(row). But, some of my desired functionality still bled over into the pull request, as identified by Guillaume. I didn't mean for that to happen, and it makes sense to remove my boutique functionality.
After doing this, my first experience with hacking Atom, and practically first time writing coffeescript, I figured it would be useful in general. I didn't even realize Guillaume had another pull request in flight.
Let me know specifically what you want ...
... a new pull request with my specific functionality removed (no check for //, e.g.)
... some kind of update to this pull request
... or you just grab the relevant parts of this and merge it in on your own, or something else

Maybe we could merge our two pull requests ?
isBufferRowCommented :+1:
    isBufferRowCommented: (bufferRow) ->
    if match = @lineForBufferRow(bufferRow).match(/\S/)
      scopes = @tokenForBufferPosition([bufferRow, match.index]).scopes
      new TextMateScopeSelector('comment.*').matches(scopes)

It consists to watch the scopes. So, it seems to have the exact same behavior as hasScopeForBufferRow. Maybe just this would work ? Don't need "//" or ";" or other things.

Just merged in the other PR which should fix this up. Thank you so much for the contribution though @etep!


Biomass Reclaimer Does Not Work (DoAfter?)

Description
Title explains it. Can't drag people into biomass reclaimers, it just cancels the bar when it reaches full

FYI this PR fixes it:  https://github.com/space-wizards/space-station-14/pull/14609/files#diff-29a1f0c3607b956992071ceee1f1dce8bd2c3604c3190a702f758c3565a53601  So hopefully it gets finished/merged soon ^.^


error when playing files with certain characters

When I try to play files that have Japanese characters in the file name I get the error
line 235, in __bind
    raise MiniaudioError(MA_RESULT_STR[ma_res])
just_playback.ma_result.MiniaudioError: MA_DOES_NOT_EXIST

the same might happen with other characters as well but I haven't tested it

Hi @jimmy-taylor-1,
Could you try installing v0.1.8 ? Let me know if it solves your problem.

Unfortunately this seems to have made the problem worse, now i get this error for every file I try to play
line 55, in load_file
    self.__bind(lib.load_file_w(self.__ma_attrs, path_to_file.encode('utf-16le')))
TypeError: initializer for ctype 'wchar_t *' must be a cdata pointer, not bytes

Do you have Microsoft's C/C++ compiler installed ? If you do try installing the attached file with
pip install just_playback-0.1.8.tar.gz
just_playback-0.1.8.tar.gz

Unfortunately this seems to have made the problem worse, now i get this error for every file I try to play
line 55, in load_file
    self.__bind(lib.load_file_w(self.__ma_attrs, path_to_file.encode('utf-16le')))
TypeError: initializer for ctype 'wchar_t *' must be a cdata pointer, not bytes

I was getting the same error, even when directly compiling from source. I got mine working by simply removing the encoding,
so from:
if platform.system() == 'Windows':
        self.__bind(lib.load_file(self.__ma_attrs, path_to_file.encode('utf-16le')))

to:
if platform.system() == 'Windows':
        self.__bind(lib.load_file(self.__ma_attrs, path_to_file))

Also, when compiling from source, there is a little bit difference in the code, but you can still remove the utf16le encoding part completely and it will solve the issue.
Note: this isn't the right solution and we should perform some type of validation before deciding and going on with the encoding, but works for now.


Performance improvements

Good good ;)

What About the problem with duplicate tokens?

According to the the documentation of a HashSet it os noted an issue since it returns a boolean if the it is already existed

Sorry I did not see the change set where you replaced with  hashset. Good good


[1515] Stage SPIs from GIAS

Context

https://trello.com/c/4h5TboLZ/1515-able-to-onboard-fe-schools-from-gias
First step to get SPIs (Speical Post 16 institutions) from GIAS into the service
Second step will be to move from staging area to actual records

Changes proposed in this pull request

No longer exclude SPIs when staging schools

Guidance to review

closing as no longer needed