Fix iOS frame regression

#9138 caused a 0.4ms average frame draw latency increase on flutter_gallery_ios__transition_perf's average_frame_build_time_millis and 1500ms regression on microbenchmarks_ios's stock_build_iteration.
Suspect due to there being 2 SlideTransitions instead of 1.

The obvious next question is: if you comment out one of the SlideTransitions, does it resolve itself? :-)

How is this a regression if you are doing more transitions?

Will try.
Just from debugging timeline, not too clear yet.
Seems like there's 2 parts to this. The heavy building part at the beginning where the whole tree is built out I assume. And the animating part in the middle.
https://screenshot.googleplex.com/k1RVRXjT2LM
https://screenshot.googleplex.com/bPOnpiwcuUj
Over 12 frames, the cumulative rendering time increased by 1.4ms (not scientific, I just ran it locally and warmed it once).
The first build path got 3.6ms slower.
I think the entirety of it came from the 'animate' phase of the frame. Was 3.7ms cumulatively over 18 frames (~300ms). 11.6ms after the patch. Other phases are comparable to before.
@chinmaygarde will do a bit more digging to see if we can make it better but yes, a bit of apples and oranges. We're animating 2 routes instead of 1 before.

Animating extra routes doesn't actually push any more frames, per se.
Interesting that it'd be in the animate phase. That implies we're doing a lot more work with AnimationControllers, Animation objects, and so forth. Maybe there's something we can do to coalesce the work, fire fewer notifications, or some such.

Ya, it's the same 18 frames either way.
Removing the extra SlideTransition doesn't change which I think implies the cost comes from the fractional offset tween animation calculation that happens regardless of whether it's read out.
One the one hand, there is inevitably more math that needs doing to get the right UI behaviour but I wonder if there are redundant calculations like you're saying.

Tried the previous custom curve function method. Same 12ms of cumulative animation work. I think the cost comes from the listening and consumption of the secondaryAnimation (ha, using new word) signal. Just gotta figure out if it's due to the extra triggering or the computation the triggering causes.

Trying an incremental diffing approach
The Android material transition
1- As-is on head with the transformed position transition curve driving the animation: 5.7ms of animation
2- The untransformed linear route animation triggering with the position transition curve value still used: 5ms of animation
3- Just triggering from a merged listenable of the untransformed linear route animation and secondary animation without doing anything with the secondary animation: 31ms of animation
Ding ding ding, we have a winner.
Seems like AnimatedWidget doesn't really do anything besides triggering setState on listenable notifications. So it's just from the repeated build() calls on the page transition objects whether anything changes or not.

For completeness and for my curiosity, I carried out the remaining steps that #9138 does:
4- Take the secondary animation trigger, pipe it through a transformation calculation of similar complexity as the primary animation. No change in latency.
5- Take the secondary animation's transformation calculation, actually use the output value in the widget's build with a SlideTransition. No change in latency (as seen already in https://github.com/flutter/flutter/issues/9205#issuecomment-291690130).
So ya, the cost is from the overhead of triggering extra build calls on the page below that used to not have to re-build when a page goes above it.

More brain dumping:
Interestingly the added cost wasn't really from the execution of the build() method. I put the entire AnimatedWidget's build in a try finally and traced it. It was called 21 times for 0.48ms before step 3 and called 36 times for 0.65ms after step 3.
It's also not inside the animate phase but just queued somehow in the animate phase and ran in the build phase which definitely makes sense.
So it's somewhere deeper in the framework where having an AnimatedWidget listen to an additional input signal to queue up more setState() calls is doing this and increasing the animate phase latency.

A bit more digging:
Easier with a picture
Before listening to secondaryAnimation

After listening to secondaryAnimation

Without any listeners attached, the secondary animation barely did anything initially. In the second image, it took more or less as much time as the primary animation did which is mostly expected.
If you guys agree, I would remove the regression label since we doubled the animation work at more or less linearly double the cost.
Maybe there is still some room optimizing the secondaryAnimation framework itself. As seen in the graphs, in both before and after the ratio of the AnimatedWidget subclass and its childrens' work vs lower level framework work was high for the primary animation.
For the secondary animation, it seems like TransitionRoute._updateSecondaryAnimation can occasionally take up the majority of the time before starting to 'do real work'. Though looking at the git blame chain on that part of the file seems to show that there's a bunch of features in there and the various computations present are probably for good reasons.
Closing this bug for now since there's probably diminishing returns for trying to optimize _updateSecondaryAnimation. The optimizability seems also device dependent. With the Cupertino feature fully turned on, the runtime looks a lot more expected most of the time too.

I'm adopting this bug for perf improvements at that layer. I don't want to lose your research.

Some things to look into:

Would removing the try/catch in notifyListeners help?
The common case seems to be a single listener, but we always allocate an entire copy of the entire list every time regardless. would a fast-path for the single-listener case in notifyListeners help?

It also seems crazy that we would spend that much time doing the Animate phase in general, especially compared to the Build and Paint phases.

I can take another look again tomorrow


Kinesis S3 Sink: extend to support storing enriched events to S3

:+1:

Hey @kazjote - please let us know:

What processing tool you want to use with the enriched events in S3 (Hadoop / Spark / Hive / something else)
What format you would like the enriched events stored in (sequence files? parquet?)
What folder structure you would like the enriched events partitioned into

Thanks for your interest in the topic.

I am using Spark to analyze data
Anything that Spark can read will do
The best would be split by appId

I think for starters we just follow the Secor project and write new line delimited raw text files for enriched events. This will let them be picked up by Spark and Spark Streaming.

It works for me. For debugging purposes we are using mainly Ruby scripts - reading parquet files could be problematic with Ruby (however, still possible with JRuby)


vd's sign information in integer multiply-add instructions.

In integer multiply-add instructions, for expample, the vwmaccsu, only the sign information of vs1 and vs2 is given, but for vd I can't see it's sign information in spec. Is vd  always treated as a signed number in all integer multiply-add instructions? Thanks for your time.

If either operand is signed, the result is signed. The spec doesn’t explicitly say so because this is implicitly true.

If either operand is signed, the result is signed. The spec doesn’t explicitly say so because this is implicitly true.

Yes, but I mean that vd is also used as an operand. What's the signed information about vd as an operand?

The addition with vd is performed the same way whether you interpret the bits of vd as encoding a signed (two's complement) or unsigned integer. I think it makes more sense to think of vd (input and output) as a signed integer, but this interpretation doesn't change the semantics of the instruction.

For accumulating operations, the signedness of the accumulator doesn’t matter, because it’s just modular arithmetic. (The signedness of the multiplicands does matter, by contrast.)

But, conceptually, what Nick wrote matches how I think about these operations.


3D-viewer v2

Todo [WIP]

[ ] Fix memory leak https://github.com/lbryio/lbry-desktop/issues/1863

@seanyesmunt if you can tell @jamesbiller how to run this version he can confirm the issue has been fixed

@james try this build here: http://build.lbry.io/app/build-3096_commit-612dd80/
I'll test it out today as well.

Looks good!

@btzr-io definitely noticing an improvement with memory usage after leaving the 3d model (takes a few seconds) - it does seem to release the memory allocated. If you open multiple after another, you can still get pretty high usage on some 3d models.
@jamesbiller how's this working on your PC?

@tzarebczan It's been working a hell of a lot smoother! Good work

Ready for review and more testing.

@btzr-io The new controls are awesome! It looks good from testing, I'll let @skhameneh do the dev review since he has a better understanding of the threejs stuff.


Stream audio directly to Clubhouse's backend?

Hi, huge thanks for your work!
Is there a way to stream audio from my computer directly to clubhouse? 🤔

I am working on it and searching about agora things which Clubhouse uses in behind the scense. There is plan to release audio SDK* for Clubhouse, however, still information is not enough, yet. Also, if you're interested on only-listening from PC, you can use Bluetooth A2DP Sink or AirPlay server such as Lonelyscreen. In current, Clubhouse only detects headset/speakers which has a microphone.

Thanks for your answer. I want to stream my DJ set to clubhouse tho, thank you for idea with lonelyscreen. Clubhouse only detects a wire headsets/speakers?

Clubhouse only accepts external devices which has a mic, otherwise it will switch automatically to internal speaker.

Please, refer: https://github.com/Seia-Soto/clubhouse-api#voice-support

For future discussions, refer #7 .
Closing this issue due to inactivity.


Navigation Bar?

It's me, again. This time I'm having an issue with navigation bars. The project is now converted in Swift so I imported the header files in a bridging header. Every ViewController is instantiated with Storyboard ID and I've embedded in every view controller with a Navigation Controller but none of the navigation bars actually showed up. I tried creating the Navigation Bar programatically but it sucked and it was looking so lame and the Interface Builder way was much better! So, how can I do it?
Here's the project: https://github.com/MhTheDev/ESTabBarControllerTest
Help?

Ah! Fixed it! It turns out you had to make a navigation controller for every Navigation Controller embedded in every other ViewController and instantiate it.


No results from the functree 2 web

Hi,
I am trying to use https://bioviz.tokyo/functree2/analysis/mapping/ with my data, but there was no results coming out. I don't know why. could you please help me have a look what's wrong? Here I attached my data and result page screenshot.
Thank you so much.
test.txt

Hello,
To solve you problem please trim the empty column in the input file before submitting it to Functree 2.
sed 's/\t$//' test.txt -i
test.txt
Kind regards,
Youssef

Thank you so much. It's working now.


New module 'spring-cloud-aws-r2dbc'

Is your feature request related to a problem? Please describe.
Reactive Relational Database Connectivity (R2DBC) is getting more and more attention. spring-data-r2dbc has recently been released as 1.0.0.RELEASE. I would now love to use it, when connecting to an AWS RDS instance - but not without having the nice features of spring-cloud-aws-jdbc like connection pooling or failover support.
Describe the solution you'd like
In my mind the easiest solution will probably be to add another module to this repository called something like spring-cloud-aws-r2dbc. It could surely re-use most of the code used in spring-cloud-aws-jdbc, maybe extracting the common parts into another module would be a good thing to do. For handling the connection pooling, one could use r2dbc-pool, which has been stably released recently as well. There are probably some other places it didn't see yet, where replacing JDBC by R2DBC might be difficult.
Describe alternatives you've considered
Alternatively, one could simply use spring-data-r2dbc directly as well, but then features like connection pooling, failover support and instance resolving would be missing.
Additional context
I can try and work on a PR, although I'm not sure, if I will manage to do it within a reasonable time frame. Additionally, I would like to discuss, whether the general approach suggested is viable or not.

Any updates regarding this?

Currently, spring-cloud-aws doesn't block to use rd2bc, you can use it as you can use jdbc even without the spring-cloud-aws-jdbc module. Most of the supported databases by AWS RDS have a r2dbc driver. Connection Pool is offered by spring-boot auto-configurations already and regarding to "failover support" using multi AZ or rds proxy is something that the infrastructure can manage.


Game full should be able to take from game assignments

It should also show in the game book

What specifically do you mean here?
I certainly think that during game signup it would be useful to display "game full", and we can do that.  Is there more?

If you set the flag on the game it displays it during game choices. But it'd be nice to show it in the game book as well, so people can see whether or not they want to sign up (late). We get that every year.
And, like today, someone dropped out, and two, three games opened up that are pretty popular.
Some of it is also I don't want to have to set the flag: just count of players from game assignments against the max should do

A trigger on game assignments should do the trick. Count game assignments that have gm = 0 and if it equals or exceeds the max player, set the Full flag.
I don't know that I'd want to unset the Full flag: at ACUS we set it manually on GM request.


add logos for new tech members

Let me know if I put these in the wrong file. Planning to update for all new members

Not needed anymore @ChrisHuie - membership pages come from wordpress now.


chore: Generate Redirect file from MS Docs Pack

One article had the redirect metadata to itself and was removed

Sorry, we can't take these changes to config json files as we are changing a lot of things internally. Closing it without merging.


Add transforms between ISN datums

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.01%. Comparing base (1399a30) to head (764c90a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   96.92%   97.01%   +0.09%
==========================================
  Files           3        3
  Lines          65       67       +2
==========================================
+ Hits           63       65       +2
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Select radio by label update for User Rights page

"I select the radio option "No Access" for the field labeled "User Rights" in the dialog box" in B.2.6.100 - Basic Privileges fails since it cannot properly select the radio button in the User Rights page.
This fix lets the browser select the User Rights radio buttons properly. I know this command actually lives in online_designer.js but I was still able to writ the Gherkin to properly work. Let me know if I should try a different approach and I'd be happy to modify the feature tests as well.

@aldefouw, I have a docs question for this: the Gherkin Step Builder doesn't show that a base element can be specified for this but the actual code shows that you can:
/**
 * @module Interactions
 * @author Adam De Fouw<EMAIL_ADDRESS> * @example I select the radio option {string} for the field labeled {string}
 * @param {string} option - option we want to select from the radio options
 * @param {string} field_label - the label on the field we want to select
 * @description Clicks the radio option on the field specified
 */
Given('I select the radio option {string} for the field labeled {string}{baseElement}', (radio_option, field_label, base_element) => {
    let outer_element = base_element.length > 0 ?  window.elementChoices[base_element]: window.elementChoices['']
    cy.get(outer_element).within(() => {
        cy.select_radio_by_label(field_label, radio_option)
    })
})

Where/how would I update this?

@aldefouw, I also have a docs question for this: the Gherkin Step Builder doesn't show that a base element can be specified for this but the actual code shows that you can:
/**
 * @module Interactions
 * @author Adam De Fouw<EMAIL_ADDRESS> * @example I select the radio option {string} for the field labeled {string}
 * @param {string} option - option we want to select from the radio options
 * @param {string} field_label - the label on the field we want to select
 * @description Clicks the radio option on the field specified
 */
Given('I select the radio option {string} for the field labeled {string}{baseElement}', (radio_option, field_label, base_element) => {
    let outer_element = base_element.length > 0 ?  window.elementChoices[base_element]: window.elementChoices['']
    cy.get(outer_element).within(() => {
        cy.select_radio_by_label(field_label, radio_option)
    })
})

Where/how would I update this?

Thanks for bringing this up ... this is documentation that fell out of date.  To fix the documentation, we just need to replace the existing comment:
*@example I select the radio option {string} for the field labeled {string}
with
@example I select the radio option {string} for the field labeled {string}{baseElement}
From there, we need to run npm run docs:build in the redcap_cypress directory.  (I mistakenly had this at rctf level before I deployed the documentation to redcap_cypress - so you'll see that in the scripts.)
I'll push that fix to the main branch of RCTF but without a tag.  (No reason to deploy this code because it only has changed the docs - it will, however, be caught up when you sync your fork to main so will be included in the next v1.0.103 release).
Good catch!

Documentation updated / fixed for v1.0.102

Moving over @aldefouw's comment made in #13 in reference to this specific change:

@schatto1 - Apologies but I'll need to do some additional review on this one.
I feel like there was a specific reason why const parent = Cypress.$($text).parent() was used
instead of:
const parent = Cypress.$($text) even if it doesn't work for this specific case.
Unfortunately the file history did not give me a clue. I usually try to provide an edge case description in the commit message but I didn't in this case: 5707a9f

Would you think it's better if I added a new step definition/command that was specific for selecting radio buttons within the User Rights page?

@schatto1 - will need to review the specific issue to let you know how to proceed.  Apologies for the delay in review - today has been a day where I was completely meeting blocked all day.
I will give this a look over after kiddos go to bed if I get a chance.
Otherwise we can circle back next week.

Next week is totally fine- no rush!

@aldefouw, I believe this change is required for B.2.6.100.  I believe it's safe per my previous comment.  Any concerns about merging this?


Grafana dashboard does not reappear in grafana after shutdown

Bug Description
Read this post on discourse.

Hi, We are continuously tinkering with the COS-stack and grafana-agent. One thing I noticed is that dashboards sent from grafana-agent doesn’t reappear in grafana after the computer has been of for a couple of days. Even though the relation is still maintained.
After booting the machine

After redoing the relation

Alert rules does appear. Any idea why?
To Reproduce

Environment
juju 2.9.42
Relevant log output
-

Additional context
No response

A similar issue was discovered by @amandahla.
To reproduce:

Pack commit b812866392f15c40c5fb809f496f4e3cc5b7b603 from https://github.com/canonical/synapse-operator/pull/17
Set update status hook interval to 5m:  juju model-config update-status-hook-interval=5m
Deploy the following bundle.
The dashboard isn't there: juju ssh --container grafana gr2/0 ls /etc/grafana/provisioning/dashboards even though it is present in relation data (juju show-unit gr2/0

bundle: kubernetes
applications:
  gr2:
    charm: grafana-k8s
    channel: edge
    revision: 87
    series: focal
    resources:
      grafana-image: 56
      litestream-image: 37
    scale: 1
    constraints: arch=amd64
    storage:
      database: kubernetes,1,1024M
    trust: true
  loki-k8s:
    charm: loki-k8s
    channel: edge
    revision: 96
    series: focal
    resources:
      loki-image: 80
    scale: 1
    constraints: arch=amd64
    storage:
      active-index-directory: kubernetes,1,1024M
      loki-chunks: kubernetes,1,1024M
  pr2:
    charm: prometheus-k8s
    channel: edge
    revision: 135
    series: focal
    resources:
      prometheus-image: 114
    scale: 1
    constraints: arch=amd64
    storage:
      database: kubernetes,1,1024M
    trust: true
  synapse:
    charm: ./synapse-operator/synapse_ubuntu-22.04-amd64.charm
    series: jammy
    resources:
      synapse-image: ghcr.io/canonical/synapse:e9c2a9adc72c40d31e5fc3a1651ed834a91170482c588679471ba42680d98bea
    scale: 1
    options:
      server_name: banana
    constraints: arch=amd64
    storage:
      data: kubernetes,1,1024M
relations:
- - pr2:grafana-source
  - gr2:grafana-source
- - synapse:metrics-endpoint
  - pr2:metrics-endpoint
- - gr2:grafana-dashboard
  - synapse:grafana-dashboard

Fixed in https://github.com/canonical/grafana-k8s-operator/pull/247


Type error in callback function body when using union type.

In the snippet below, callback argument passed to callAsynchonously causes a compilation error This condition will always return 'false' since the types 'ResourceState.LOADING | ResourceState.FAILED' and 'ResourceState.LOADED' have no overlap..
export const enum ResourceState {
    LOADING = 1,
    LOADED = 2,
}

export type Resource<T> = |
{
    status: ResourceState.LOADING,
    data?: never,
} | {
    status: ResourceState.LOADED,
    data: T,
};

function callAsynchonously(fn: Function) {
    setTimeout(fn, 1000);
}

export function doSomething() {
    const resource = { status: ResourceState.LOADING } as Resource<any>;

    if (resource.status !== ResourceState.LOADED) {
        callAsynchonously(() => resource.status === ResourceState.LOADED);
    }
}

Since the callback runs asynchronously, resource.status may have changed to ResourceState.LOADED when it is invoked. So typescript should not treat this as an error.
Note: If I change the Resource type to:
export type Resource<T> = {
  status: ResourceState.LOADING | ResourceState.LOADED | ResourceState.FAILED,
  data?: any,
};

it compiles OK.
Playground link here: https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=26&pc=1#code/KYDwDg9gTgLgBAYwgOwM72MgrgWzgJWFQiygWAGUYBDGYOAbwCg5W4AZAeQEEARASQByAcTgBeOAEYANCzZc+AUV7i4AJlkBfJk1CRYcGAE8w9QsVLkAPABUAfKoA+TZmzjpaWVAC4CREmSUNHQAdAoCIrJuACa01AD8vsjAAG7AUFpwjoxyrB4wXr7mAeRUtMBhPLzKUWyxNL42WgDcOgBmWMgIMACWKIjUADaD3KhGXQAWKCSog0YAFG3IvgBind19yACUOW6owDA2PTjAJDCLyNJSAAy3W63auuDQ8B1dvf3REBQQJzATPWQAHN5jtXGwkGh4FB-JZ6BIGO5goU-BZAmVQuEhKJNHBqKhUSVgFZqMgjHZWrk4D02nB5jC0eQQvkvHAAIRiCTFOEYirhZRgqluBBDEZjSbTLxzeag8QOBlE5nIgmcrmw9HBPlVAWtNzabRAA
TypeScript Version:: 3.7+ (possibly earlier versions too).

See #9998


Layouts with automatic cell sizing crash when the side insets are non-zero

New issue checklist

[x] I have reviewed the README and documentation
[x] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 2.1.0
iOS version(s): 10.2
CocoaPods/Carthage version: DNA
Xcode version: 8.2.1
Devices/Simulators affected: All test cases affected (7 Simulator/6s Plus)
Reproducible in the demo project? (Yes/No): Yes
Related issues: None

Self-sizing cell layouts, as shown in the SelfSizingCellsViewController example, break when the inset.right or inset.left values for the section controller are non-zero.
The following console output is shown when inset.left is set to 10, instead of the current value of 0, in the example SelfSizingSectionController.
2017-01-23 21:00:30.619 IGListKitExamples[17836:3387117] The behavior of the UICollectionViewFlowLayout is not defined because:
2017-01-23 21:00:30.619 IGListKitExamples[17836:3387117] the item width must be less than the width of the UICollectionView minus the section insets left and right values, minus the content insets left and right values.
2017-01-23 21:00:30.619 IGListKitExamples[17836:3387117] Please check the values returned by the delegate.
2017-01-23 21:00:30.620 IGListKitExamples[17836:3387117] The relevant UICollectionViewFlowLayout instance is <UICollectionViewFlowLayout: 0x7ff28ec159a0>, and it is attached to <IGListCollectionView: 0x7ff28f030200; baseClass = UICollectionView; frame = (0 0; 414 736); clipsToBounds = YES; gestureRecognizers = <NSArray: 0x60000005d220>; layer = <CALayer: 0x600000035920>; contentOffset: {0, -64}; contentSize: {0, 0}> collection view layout: <UICollectionViewFlowLayout: 0x7ff28ec159a0>.
2017-01-23 21:00:30.620 IGListKitExamples[17836:3387117] Make a symbolic breakpoint at UICollectionViewFlowLayoutBreakForInvalidSizes to catch this in the debugger.

[This set of messages is shown a whole bunch of times, presumably for each separate self-sizing view in the controller.]

@HarshilShah This seems to be a flow layout problem. After setting insets to 10, the width of the section is containerWidth + 10 + 10, which is larger than the width of the collectionView. This is not allowed in UICollectionViewFlowLayout.

@zhubofei This solved it, thanks!


HOC witchStyle does not accept static default props

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When using HOC withStyles, the style object does not accept props set statically in the class. Instead, in the props of the styles object, I get props specified directly when using the component
Expected Behavior 🤔
The props of the style object should show all props, including the default props
Steps to Reproduce 🕹

There is nothing unusual here, part of the page (for convenience) on which I call this component and hang an event handler on it.

// Setting page.jsx
import { Component } from 'react';
import { Grid, Box } from '@material-ui/core';
import withWidth from '@material-ui/core/withWidth';

import {
  DashboardSection,
  DashboardInput,
} from '../../components/DashboardLayout';

class SettingPage extends Component {
  constructor(props) {
    super(props);

    this.state = { email: '' };
  }

  handleChangeEmail = event => {
    event.preventDefault();
    this.setState({ email: event.target.value });
  };

  render() {
    return (
      <>
        <DashboardSection
          mt={6}
          mb={5}
          container
          direction="column"
          label="Personal Data"
          component={Grid}
        >
            <Grid item xs={12} md={6}>
              <DashboardInput
                fullWidth
                name="email"
                label="Email"
<EMAIL_ADDRESS>                onChange={this.handleChangeEmail}
              />
            </Grid>
        </DashboardSection>
      </>
    );
  }
}

export default withWidth()(SettingPage);

I need to get the height from the props in the style object, so I wrap the component in the HOC and pass the function height: props => console.log (props). Pay attention to the types and default values in the component class.

// Dashboard input component
import PropTypes from 'prop-types';

import { PureComponent } from 'react';
import { withStyles } from '@material-ui/core/styles';
import { FormControl, InputLabel, InputBase } from '@material-ui/core';

const styles = theme => ({
  formControl: {
    margin: theme.spacing(-2, 0),
  },
  inputLabel: {
    fontWeight: 'bold',
  },
  inputBase: {
    height: props => console.log(props),
    marginTop: theme.spacing(4.5),
    padding: theme.spacing(0, 2.5),
    backgroundColor: theme.palette.secondary.main,
  },
});

export class DashboardInput extends PureComponent {
  static propTypes = {
    label: PropTypes.string,
    height: PropTypes.number,
    fullWidth: PropTypes.bool,
    classes: PropTypes.object.isRequired,
  };

  static defaultProps = {
    label: 'Label',
    height: 50,
    fullWidth: false,
  };

  render() {
    const { fullWidth, label, classes, ...other } = this.props;
    return (
      <FormControl
        variant="filled"
        fullWidth={fullWidth}
        className={classes.formControl}
      >
        <InputLabel shrink className={classes.inputLabel}>
          {label}
        </InputLabel>
        <InputBase
          className={classes.inputBase}
          inputProps={{ 'aria-label': 'naked' }}
          {...other}
        />
      </FormControl>
    );
  }
}

export default withStyles(styles)(DashboardInput);

The console log will return this object, here the props that were passed when the component was called, but there are no props of the default height.

{
	fullWidth: true,
	name: "email",
	label: "Email",
	placeholder<EMAIL_ADDRESS>
	onChange: ƒ
}

Context 🔦
I wanted to create dynamic styling of a class component based on props. This will help a lot in a particular situation where there are reusable components with distinct styles and a default style.

The solution to this problem (for me) is very simple - override the value in the height function by height: ({ height = 50 }) => height, but I'm not sure that this is a good practice for everyone.

Your Environment 🌎

Tech
Version

Material-UI
v4.5.2

React
v16.10.2

Browser
Google Chrome v79.0.3945.8

Next.js
v9.1.1

Sorry for my English, I do not often practice this language.

I think this was already reported in #18124 which already has a fix pending merge.


Debug console stop listening output

VSCode Version: 1.39.2, 1.40.0-insider
OS Version: Windows 10.0.18362

Suddenly the debug console stop listening to output changes, restarting application, vs code, OS didn't help.
I suspect it related to "Clear Console" button in the debug console windows, since as far as i know the problem starting after i click it.
Im developing dart 2.5.0 application, using aqueduct 3.0.0 which using dart isolate (which may be contributing to the issue)
Steps to Reproduce:

Init aqueduct default project
When i start the debugging (using f5) only the first row is displayed on debug console:

After invoking something in debug console, console, the rest output will be shown:

Any later output will not be shown until you triggering debug console, or stopping debugging process.

For sanity check, i try manually running the application via terminal, using pub run ./bin/main.dart and it seems running normally.
Edit:
When application outputing error 'debug console' able to immediately show the message. Maybe it's related to what message is send to output.

Its seems, that closing "debug console" panel, than open it again also updating the output in "debug console"

@mjbvz :
I have the same problem with 1.39 too.  It doesn't reproduce with 1.38.1.
In my code, I send output events to VS Code. After triggering a breakpoint, VS Code debug console stops updating.
If I switch to "Terminals" window, then switch back to "Debug Console" window, all missing messages show up.
The problem happens on OS X. It also happens on Windows that is used via. Remote Desktop.

Hi, @mjbvz and @isidorn ,
I have similar problem with 1.39 too.  It doesn't reproduce with 1.38.1.
In my code, I send output events to VS Code. After triggering a breakpoint, VS Code debug console stops updating.
If I switch to "Terminals" window, then switch back to "Debug Console" window, all missing messages show up.
The problem happens on OS X. It also happens on Windows that is used via. Remote Desktop.

I just discovered this too (after some time of debugging my extension assuming I've broken it, since I recently added output buffering!).
I'm logging when I sent OutputEvents like this:
protected logToUser(message: string, category?: string, colorText = (s: string) => s) {
	console.log(`Sending ${JSON.stringify(message)} to ${category}`);
	const output = new OutputEvent(message, category);
	this.sendEvent(output);
}

And they show up in the Chrome dev tools console, but not in the VS Code Debug Console. As mentioned above - switching to the terminal and back causes them to appear. This seems like a fairly serious regression in the current stable build @isidorn.

/confirm

we also hit the issue too in version 1.40.0

Based on the comments. Seems to be only happening with dart.
@dantup can you please create a reproducable sample with Mock Debug so I can reproduce this on my machine and investigate further into this issue. Concise repro steps without aqueduct would be great. Thanks

@isidorn I tried to make a small repro but could not - I think timing may be a factor, but I'm not sure exactly what the implementation of this looks like.
I don't believe this is specific to Dart, @Sen-real mentions having this problem in his extension above too (and some of the other commentors might not be using Dart, they didn't say).

@isidorn and @DanTup : I'm not working with Dart. My extension works with my debug adapter exe, which communicates with VS Code via STD IN / STD OUT. As debug adapter isolates debugee from VS Code, it could be reproduced with any kind of language running on debugee.
Hope this could be helpful to identify the source of this regression - VS Code Debug Console will refresh on time, as long as the message text to print ends up with '\n'.

I could reproduce using while loop returning output to console with interval (using vscode 1.40.0), https://github.com/itsnuba/vs-dart-issue
i could reproduce the issue in different machine using this method, but not using different language (i've test it in nodejs)
this only affecting debugging using f5, there is no issue directly running the script using terminal.
Maybe like @Sen-real said, it has something todo with how dart debugee comunicate with vs, but im sorry, im lacking expertise in this matter to test it further.

@isidorn here's a simple repro using Mock Debug:
https://github.com/DanTup/vscode-repro-83906
The code change is just inserting this:
setTimeout(async () => {
	this.sendEvent(new OutputEvent("\none"));
	await new Promise((resolve) => setTimeout(resolve, 1000));
	this.sendEvent(new OutputEvent("\ntwo"));
	await new Promise((resolve) => setTimeout(resolve, 1000));
	this.sendEvent(new OutputEvent("\nthree"));
	await new Promise((resolve) => setTimeout(resolve, 1000));
	this.sendEvent(new OutputEvent("\nfour\n"));
	await new Promise((resolve) => setTimeout(resolve, 1000));
	this.sendEvent(new OutputEvent("five"));
	await new Promise((resolve) => setTimeout(resolve, 1000));
	this.sendEvent(new OutputEvent("\nsix"));
}, 2000);

Open a .md file, place a breakpoint somewhere (to stop the process exiting when you run), hit run, and you'll see one/two/three/four/five all appear at once instead of 1 second apart, because they're not rendered until the first output event that ends in a newline. Switching to the Terminal and back to Debug Console will then cause six to appear.

@dantup Thanks for the nice repro steps. I was able to reproduce and fix the issue.
You can try vscode insiders tomorrow which should have the fix. Thanks a lot!

@isidorn will the fix require that the message start with a newline? Although I used that as an example, I can't make guarantees about the output events since they come from an external process which could send whatever characters it wanted chunked however it wants - (for example there could be newlines in the middle of messages, or even none at all)?

No, the fix does not require that the message starts with a newline.
The fix should work for all output events. Thanks

Ok great, I must've read too much into the change :) I'll test in insiders tomorrow - thanks!

No, you were on a good track. Just the change consists of two parts
Make sure to split if new entry starts with \n and make sure to fire change event if we append (which we were not doing previously)

@isidorn thanks! The buffering is fixed, however now there are unexpected newlines. In the source there is exactly one newline between each message, but the output in Insiders looks like this:

Because the data is coming from an external process, we can't ensure that the output events will have newlines in any particular place, so I think it's important VS Code doesn't add new ones. This might mean VS Code needs to append an OutputEvent into an existing line if there was new newline sent at the end of the previous one or the start of the new one?

@dantup thanks for letting me know. I had word wrap disalbed in the debug console and thus I did not see this one.
However I have pushed a fix now. You can try it out tomorrow and let me know. Sorry about that

Great, will do - thanks!

Fix looks good (with and without newlines), thanks!

Thanks, adding verified label


Distance and Direction: Rings tool - created graphic is not labeled (ArcGIS Pro)

build 11 Jan 2017 13:51 ArcGIS Pro addin

Can't include a screenshot of what it looks like in ArcMap as it's not labeling either #259

@nfeuerstein I can't show you what it looks like from the ArcMap addin as that's not working either, but here is what the labels looks like from the widget:

We are able to create labels on the top of targets in ArcGIS Pro using the Visibility add-in. We should look at this as a possible way forward.

Labels are still a limitation in Pro.

Closing. Graphics are not labeled in ArcGIS Pro. #544 has been created to handle the labels on created rings.


Method Illuminate\View\View::__toString() must not throw an exception, caught ErrorException

When i click on browse server then this happen. And also send it server for ckeditor is also not working

Make sure you run php artisan vendor:publish --tag=lfm_view --force.


Support most callables

Fixes #114

Missing a test with classmethod?

No, it's here: https://github.com/scipp/sciline/blob/1a75b95cef64887bdeeed8fd16899fcc20044192/tests/pipeline_test.py#L1495


Feature request: support "partial sync" of multiple selected packages

Current behavior: if you select multiple packages in the IntelliJ 'project' view, right-click and click 'Partially Sync...', it only syncs one of them. (IntelliJ IDEA 2017.x, ijwb: 2<IP_ADDRESS>.3)
Requested behavior: if you select multiple packages, and partially sync, include all of those packages in the sync.
Background: we have two java webapps that are frequently run side-by-side. On the command-line, we can build both simultaneously with bazel, but in IntelliJ we have to build+run them one at a time (or sync everything on every pull, which is really slow). This could be a pretty significant time-saver for us.
Also, no promises, but: is this something that might be suitable for an outside contribution? I'd imagine it's not super involved, but I haven't dug in yet either.

I have a change for this under review. Should be released in a couple of weeks.


[Feature] log Best Alignment and added option to log alternative alignments

Thanks for this feature suggestion

At the moment I do not see that many people would use that feature. I tend not to change a well working and rather critical part of the adapter removal process.
Kind regards, Johannes


Added more docs about yii\db\Connection::dsn property [skip ci]

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

related #16126

Merged. Thank you!


emacs-libvterm: 2019-04-28 -> 2019-07-22

Motivation for this change
To bring latest features of the package, especially on https://github.com/akermu/emacs-libvterm/commit/6e722680efab57b17c06731cf174c28f5e8e88b2
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is my first contribution to this repository. Forgive me for not understanding the PR workflow, but I have tested execution of the package as a package override with the hash.

Everything is fine from here. Congratulations on your first nixpkgs PR! :tada:


Add example for unattended baggage

Why this change?
Add unattended baggage example.
What does this PR include?

Example query for unattended baggage
Rudimentary support for vqpy.cross_vobj_property
Patches on vqpy.impl.frame.Frame to support vqpy.cross_vobj_property

User API changes
Users could add decorator vqpy.cross_vobj_property to properties of VObj to access properties of VObj's of a certain type within the function that computes the property. The list of properties will be passed to the function in format of List[property1], List[property2], ....
Note that decorator vqpy.property() still required.
Example:
@vqpy.property()
@vqpy.cross_vobj_property(vobj_type="Person", vobj_num="ALL", vobj_input_fields=("id", "tlbr"))
# function decorator responsible for retrieving list of properties
# Person_id and Person_tlbr given as a list of track_id's and tlbr's
def owner(self, Person_id, Person_tlbr):
    ...

vobj_type: type of VObj's needed
vobj_num: number of VObj's, currently always set to "ALL"
vobj_input_fields: list of names of properties to retrieve from VObjs

New dependencies included
None

Below changes may be made in new PRs.

User Interface

[ ] Currently user needs to decorate property with two decorators:  @vqpy.property() and @vqpy.cross_vobj_property(),  more natural to have only one @vqpy.cross_vobj_property()decorator.

Internal implementation

[ ] Currently Vobjs are stored on frame, while frame also serves as an attribute of each vobjs. We will remove the circular reference and add querying on frame for the vqpy.cross_vobj_property, instead of querying on vobj.


FP16 huggingface accuracy 6 models got failed

🐛 Describe the bug
Please refer to https://github.com/intel/torch-xpu-ops/actions/runs/8995661712/job/24710982088, there are 6 models got failed.
Error info
Run failed with return code:  -11
Output:  None
Error:  None
============ Summary for huggingface float16 inference accuracy ============
num_total: 40 (should be 46)
num_passed: 39
num_failed: 1
pass_rate: 97.50%
============ Summary for huggingface float16 training accuracy ============
num_total: 40 (should be 46)
num_passed: 40
num_failed: 0
pass_rate: 100.00%
Versions
#188
Driver: 803.29 LTS
Bundle: 0.5.0
PyTorch: 2024-05-07 nightly release
XPU OPS: d110623bbfeb0895d57609a649b17419985ac48e

The following reporducer got segmentfault on fp16 but passed on fp32:
import torch
from torch import tensor, device
import torch.fx as fx
from torch._dynamo.testing import rand_strided
from math import inf
import torch._inductor.inductor_prims

import torch._dynamo.config
import torch._inductor.config
import torch._functorch.config
import torch.fx.experimental._config

torch._inductor.config.fallback_random = True
torch._inductor.config.freezing = True
torch._inductor.config.triton.cudagraphs = True
torch._functorch.config.unlift_effect_tokens = True
torch._functorch.config.debug_partitioner = True

isolate_fails_code_str = None

from torch.nn import *
class Repro(torch.nn.Module):
    def __init__(self):
        super().__init__()

    def forward(self, arg0_1):
        isnan = torch.ops.aten.isnan.default(arg0_1);  arg0_1 = None
        any_1 = torch.ops.aten.any.default(isnan);  isnan = None
        return (any_1,)

def load_args(reader):
    buf0 = reader.storage(None, 2097152, device=device(type='xpu', index=0), dtype_hint=torch.float16)
    reader.tensor(buf0, (1, 1024, 1024), dtype=torch.float16, is_leaf=True)  # arg0_1
load_args._version = 0
mod = Repro()
if __name__ == '__main__':
    from torch._dynamo.repro.after_aot import run_repro
    with torch.no_grad():
        run_repro(mod, load_args, accuracy=False, command='run', save_dir=None, tracing_mode='real', check_str=None)

The crash happends in triton, I've submitted a issue to the team: https://github.com/intel/intel-xpu-backend-for-triton/issues/1073

This issue is moved to IGC team, the JIRA: https://jira.devtools.intel.com/browse/GSD-9082

The fix for segmentfalut will be in next rolling driver and next LTS driver.

This PR https://github.com/pytorch/pytorch/pull/126261 will make Inductor generator hint for triton that input tensor is divisible_by_16 , so that triton can avoid the segmentfault path.
@mengfei25 @chuanqi129 @riverliuintel @EikanWang  After This PR merged, we expect the 6 failed model can pass the accuracy test.

@mengfei25  PR https://github.com/pytorch/pytorch/pull/126261 has been landed, please verify.


Create dataset loader for Multilingual Open Relations

NusaCatalogue: https://indonlp.github.io/nusa-catalogue/card.html?open_relation_id

Dataset
open_relation_id

Description
This dataset provides the set of automatically extracted relations obtained using cross-lingual annotation projection method. The data covers 61 languages, including Indonesian. Relation extraction is the task of assigning a semantic relationship between a pair of arguments. For example, from the sentence "Soekarno lahir di Jawa Timur", the relation <"Soekarno", born_in, "Jawa Timur"> is expected to be extracted.

License
Unknown

#self-assign


EFO_0010787 is obsolete

EFO_0010787 was obsoleted correctly in EFO but not picked up by our process. Please investigate why this was not detected.

confirmed okmay by @ala-ebi


Cosmos (ATOM) integration

(Hopefully) closes #92

Rebasing, will squash & improve the commit messages

Have rebased, can't figure out how to upload without having to download my (now squashed) commits - will create a new PR

@jamesscaur You can also force push instead of creating new PRs 😅

@jamesscaur You can also force push instead of creating new PRs 😅

Ah, thanks - will remember for next time.


Add distributed storage backend using raft

Raft consensus protocol helps to build distributed application cluster. This makes app to run as daemon on server side.
Available major libraries are,

hashicorp-raft
etcd

This feature & #5 need to be work in conjunction to achieve distributed storage layer.

Planning to go head with hashicorp-raft for the simplicity compared to etcd version. During the implementation other factors may favor etcd-raft.


IP Address not 192.168.

My personal IP address for my network is not the required 192.168. but it starts with 10.0. Is there a workaround to this or some way to convert my IP address to be what is needed? Sorry, my knowledge is quite limited.

Hi there, thanks for reporting. I'll fix it soon.

@NobodySleep please test this version: https://github.com/redphx/joydance/archive/refs/heads/feature/fix_local_ip.zip

It worked out! I was able to connect the joycon and use it!

Glad to hear that. Which version of JD & platform do you have?


Add notarization

This adds notarization functions and calls to them.
For this to work in the Github action, we need two new bits of information set as an env var:
DEV_ACCOUNT
NOTARY_PASS

Where DEV_ACCOUNT is the account the notary passcode has come from and NOTARY_PASS is the notary passcode itself.

Added the repo secrets, let's see if this works :D

This couldn't sign, so the notarization wasn't tested. We may have to YOLO to test that part :(

Why don't you steal the pattern from nudge?

I forgot nudge did this :D I recently had to do this for another project, so I was familiar with this one.

I forgot nudge had this, actually :D I recently had to do this for another project, so I was familiar with this pattern.

Will --wait actually wait for it to be done? If so, that pattern is much nicer.

Added the nudge method, hoping I got all the bits right. I think we can get away with just notarizing the package due to the nature of the contents.

Will --wait actually wait for it to be done? If so, that pattern is much nicer.

yep!


Pre-season 6 legality indicators are not showing up

I probably broke caching of legality. Or something else.

d412d80.


Upgrade JPA (2.0 -> 2.1) + Hibernate (4.x -> 5.x)

Please don't merge yet. This should be merged with all the other IP BOM PRs.

@manstis @Rikkola could you please quick review this?


modified matchEquation to accept new equation format

Fixes #2593

Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

[ ] Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
[ ] Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
[ ] Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
[ ] Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@MirceaS I didn't notice this during the meeting, looks like you have some merge conflicts which need addressing before this can be merged.


fix Win_Drive_Info_Get.ps1 script

fixes missing } and fix SystemDrive check

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thanks!


OSX: Add basic support

Add OSX-specific definitions for CMake and Jake.

Will have to update the chromium deps by including the required gn and clang-format binaries for OS X.

Done!
First Travis log: https://travis-ci.org/aisouard/libwebrtc/jobs/179231773


LSP: Fix wrong parentheses for function call autocompletion

GDScriptLanguage::complete_code() already defines its own insert_text field. Instead of coming up with our own (naive) logic we should reuse that. It also adds the parentheses to function calls but its algorithm is smarter and already considers edge cases like e.g. type hints.
For this to have any effect we also have to send the insertText field already during the completionRequest and not only during resolve. But this is actually the recommended behavior according to the LSP specification so it's a step in the right direction anyway.

Fixes godotengine/godot-vscode-plugin#184
Fixes godotengine/godot-vscode-plugin#323

Thanks!

Is this eligible for a 3.x cherry-pick? This would be needed to also fix https://github.com/godotengine/godot-vscode-plugin/issues/184 in 3.x.

Cherry-picked for 3.5.


error when installing and updating dependencies

Trying to install and test quic-go, I met a problem with go get -t -u ./....
I get many errors with the message "use of internal package not allowed".
What I did is clone quic-go, cd into the directory and invoked the above instruction. Is that the correct procedure ? In case it matters, I'm using go1.9.1 on linux.

Same problem with go1.9.2.
Executing go test ./... yields the same error.
../../../ As I said, I tried with ... which is specified in the README. This is what causes the problem.
If I do as you say, I manage to create a program using QUIC. Maybe, the README should then be updated if we are not supposed to write go get -t -u ./... literally, and type go get -u github.com/lucas-clemente/quic-go. Dumb user as me misunderstand it. This is because ... is a possible valid value for go get.

This sounds like a problem with your GOPATH. go get -t -u ./... is literally correct.
I'm closing this issue. Feel free to open a new one if you have any problems.

That is possible. Since I use gvm, my GOPATH contains two paths. So it could be a go tool issue.
xxx@marc:~$ echo $GOPATH
/home/xxx/.gvm/pkgsets/go1.9.2/global:/home/xxx/Sources/go

This should be allowed.


[Feature] remove label

Would love to see a way to remove the label without braking the VSU or QSU

nevermind


Move sig-storage tests to storage subdir

What this PR does / why we need it:
Continue the cleanup. Some storage tests where defined in VM/compute group.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test pull-kubevirt-e2e-k8s-1.20-sig-compute

@mhenriks Another set (2) of storage tests

/lgtm
/approve


atom -w requires the entire window be closed, not just the tab

This is slightly inconvenient when one uses atom -w for things like git commit messages, it'd be great if just closing the tab that was opened was enough to cause the process to exit.

@alex This sounds very similar to https://github.com/atom/atom/issues/863 -- would you consider your suggestion a duplicate of that? If not -- can you clarify the difference?

@izuzak I don't think I can answer that without knowing more about the internals of atom: if closing the window on closing the last tab would produce the effect of the "atom -w" process exiting, then absolutely feel free to close this as a dupe.

@alex :cool:

if closing the window on closing the last tab would produce the effect of the "atom -w" process exiting, then absolutely feel free to close this as a dupe.

You can double-check that using a package.

@izuzak thanks!


Update GitHub pages gem

update gem file to match what we see in docs

@hectorsector is this even needed?  This was a part of the troubleshooting I was doing, but if you're PR is building just fine then we can probably discard this one

I think it's a good idea to bump the pages gem. Doesn't break anything and the site is building in preview.

@hectorsector the error on CI is document tree depth exceeded.  Placing this here in case we need to chase down errors later.  The preview seems to be building appropriately.
I'll merge this so I look cool 😉


Parameter -DetailedObject is not available on all Get-* cmdlets

Is your feature request related to a problem? Please describe.
I noticed that Get-RubrikReport did not have a -DetailedObject switch
Describe the solution you'd like
I would like the -DetailedObject parameter to be added to Get-RubrikReport and all other cmdlets that currently do not support -DetailedObject
To generate a list with all cmdlets that do not support this use the following command, investigate which of these cmdlets have an {id} endpoint that could specify additional information and implement the -DetailedObject switch parameter for those cmdlets.
gcm -module rubrik -name get* | ? {$_.parameters.keys -notcontains 'DetailedObject'}

Describe alternatives you've considered
Updating documentation for these cmdlets
Additional context

Iterated over all Get- cmdlets and compared output from different endpoints to validate which cmdlets should get -DetailedObject
Green = Already had -DetailedObject
Blue = No difference between id and regular query, or no -id query possible
Orange = Added -DetailedObject


Exception: Cannot read property 'methodName' of null

Android: 9, 10, 11 and 13
react-native-gainsight-px: 1.9.0
react-native: 0.71.7
From Firebase Crashlytics:
Non-fatal Exception: io.invertase.firebase.crashlytics.JavaScriptError: Cannot read property 'methodName' of null
       at .createError(address at index.android.bundle:1:4112559)
       at .anonymous(address at index.android.bundle:1:4112538)
       at .tryCallOne(InternalBytecode.js:53:16)
       at .anonymous(InternalBytecode.js:139:27)
       at .apply((native):0:0)
       at .anonymous(address at index.android.bundle:1:238172)
       at ._callTimer(address at index.android.bundle:1:237118)
       at ._callReactNativeMicrotasksPass(address at index.android.bundle:1:237283)
       at .callReactNativeMicrotasks(address at index.android.bundle:1:239271)
       at .__callReactNativeMicrotasks(address at index.android.bundle:1:141552)
       at .anonymous(address at index.android.bundle:1:140642)
       at .__guard(address at index.android.bundle:1:141393)
       at .flushedQueue(address at index.android.bundle:1:140553)
       at .invokeCallbackAndReturnFlushedQueue(address at index.android.bundle:1:140496)

I'm suspecting this line:
https://github.com/Gainsight/px-react-native-sdk/blob/759f0eb4a104a64798df809ebafe62d5320fd925/lib/GainsightPX.js#L123

I was sending undefined event to Gainsight.


Environment variable containing "=" in value

Hi,
If I have an environment variable which contains an "=", it does not behave properly. For example,
environment-variables: key1=this-is-=some=value

gets stored as key1=this-is-

Referenced in #10


Redux setup and feach data

In this PR I have done

configure redux with redux/toolkit
Hit api (booking_api) from react
fetch automobiles from api and display in main page
finish main and side bar with there style

Hi @fithamlak  ,
STATUS: APPROVED! 🥇 💯

Your milestone is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

[ ] All linters passed
[ ] Setup works fine

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


perf: improve has_tabs_or_newline performance

This seems to slightly reduce the instruction count for url_aggregator, but please run local benchmarks to verify
Before:

ada_url -> instructions/url=2.55753k
ada_url_aggregator -> instructions/url=2.76077k

After:

ada_url -> instructions/url=2.55742k
ada_url_aggregator -> instructions/url=2.76044k

@anonrig good to go


Special formatting for Pull Request trains

Where it would be used: https://github.com/pulls and in the tab Pull Requests of a repo.
I use Pull Request trains for development.
That is useful to split the task into minor parts to facilitate pull request reviews.
So, for example (a bad example), if I would create a CRUD and I would like to create 4 pull request (one for each letter), this is how the PR train would look like:
<base branch> <- crud_c <- crud_r <- crud_u <- crud_d
When this happens, I would like some visual to make it easier to recognize these PR trains in the list.
Something like this:
- Pull request of C of CRUD
  |- Pull request of R of CRUD
     |- Pull Request of U of CRUD
     |  |- Pull Request of D of CRUD
     |- Pull request of fixes on R of CRUD

Unfortunately this is just one of the many complex workflows available and it'd probably require constant tweaking to adjust to everyone's preferences and internal uses.
As such, it can't be part of Refined GitHub


Add cleanWorkDir flag to control retention of temporary files (resolves #686)

First commit is the test only

The first build passed but should have failed. It failed as expected on my local machine, I'm not sure what is going on

You pushed both commits. Is that intentional?

Also, you need to make https://github.com/BD2KGenomics/toil/pull/687/files#diff-92b64e753eea47c35c71afa81657c763R455 conditional, or remove it. It is pretty br0000000tal to log that a job failed, but delete the log file that contains all of the info about why the job failed. Right now, toil takes a snippet of the end and prints that from the leader, but that's not sufficient if you have log files with huge error messages. E.g., I'm debugging a contig mismatch issue in the GATK right now, and the error message is >4000 lines long.

Or, actually, if you remove the truncate file call before writing back the log file to the global file store and print a user accessible URL to where the log file is written in the file store, that'd work too. It is much easier to debug if toil does not destructively modify the logs generated by failed jobs.

I changed the behavior so that the full log file is saved in the work directory and its path is logged and reported back to the user. However, if the new cleanWorkDir flag is not set that work directory can be deleted and your log file will be lost regardless

I still think that deleting the log file by default is really bad behavior in general. At the very least, it should be saved back to a jobstore or etc.

The truncation is @benedictpaten's idea and it seems reasonable to me. We can't just upload arbitrarily large log files to the job store. We have to draw a line somewhere, for the sake of time and space.  If all else fails, you still have --cleanWorkDir as a last resort.

Just this one thing, otherwise great.

One more thing: could you please file a PR against master that cherry-picks your fixes for #683 and #686?

The truncation is @benedictpaten's idea and it seems reasonable to me. We can't just upload arbitrarily large log files to the job store. We have to draw a line somewhere, for the sake of time and space.  If all else fails, you still have --cleanWorkDir as a last resort.

I strenuously disagree. This log truncation thing is the single most frustrating thing I've run across in a batch scheduling system (considering YARN, multiple LSF installs, SGE, etc.). From my perspective, in an analysis pipeline, logs are data. You should be checking logs for errors and warnings at the end of the pipeline.
Anyways, we're talking about a batch system that is meant for processing files that are multiple hundred gigabytes and we're cribbing over uploading log files that are typically <10MB. At the very least, can you expose this truncation setting as a user modifiable flag? As a user of the system, I would disable log truncation 100% of the time.

The reason the log is saved in the job store is that it can be logged on the master. It would be problematic if the leader had to print a 10MB log from every node in a 1000 node cluster.
I do see your point about logs being data and I am open to discussing a change in Toil that accommodates that use case. I feel like this PR/issue is not the place to discuss that change, though.

I do see your point about logs being data and I am open to discussing a change in Toil that accommodates that use case. I feel like this PR/issue is not the place to discuss that change, though.

That's fair. If you don't have someone from your side with bandwidth to implement that change, I would be game to contribute that change after we're done with the ADAM recompute. I'll drop the logging bit on this PR for now, open a new issue, and we can move on.

I thought there was a parameter for this? Anyhow, it's trivial to add or
turnoff rotating logging if we want. I've definitely been in situations
where a firestorm of job failures, each with large log files bright a
network to its knees, so by default I'd favor the switch turned on, but
perhaps that's my hpc/network filesystem bias.
Benedict
(from phone, forgive extra typos)
On Feb 22, 2016 8:53 PM, "Frank Austin Nothaft"<EMAIL_ADDRESS>wrote:

I do see your point about logs being data and I am open to discussing a
change in Toil that accommodates that use case. I feel like this PR/issue
is not the place to discuss that change, though.
That's fair. If you don't have someone from your side with bandwidth to
implement that change, I would be game to contribute that change after
we're done with the ADAM recompute. I'll drop the logging bit on this PR
for now, open a new issue, and we can move on.
—
Reply to this email directly or view it on GitHub
https://github.com/BD2KGenomics/toil/pull/687#issuecomment-187529564.

I thought there was a parameter for this? Anyhow, it's trivial to add or turnoff rotating logging if we want.

Not to my knowledge, but if I'm just being ignorant, then I'd be glad to be educated...

Please continue discussion of log truncation in #697. This PR is about retaining work dir.

First commit message has # in the wrong place.


The documentation is not in sync with the implem

Hello, I had a question about the lockHash in the ERC20HoldableToken contract.
https://github.com/ConsenSys/UniversalToken/blob/f82d0e1b39aaaebcf45c85c61f88f188311fde12/contracts/tokens/ERC20HoldableToken.sol#L128
In the comment of lockPreimage, it says that the hash algorithm is keccak256 but below, it uses sha256.
holds[holdId].lockHash == sha256(abi.encodePacked(lockPreimage))

Which one is intended to be used?

Thanks for flagging @aBMania : fixed in this commit.


Multiple search engine filter peptides (Proteogenomics)

Description of feature
In proteogenomics studies we are probably interested only in peptides that have been identified by multiple  search engines (more than one search engine). Do we have a way to filter in ConsensusID for peptides identified with both search engines.

Yes I think it is the -min_support parameter of consensusid

@da

ok. @ypriverol

Is this issue already implemented @daichengxin ?

yes.


Having issues with Vapi_python dependencies.

Vapi Python SDK version: 0.1
Python version: 3.11
Operating System: Windows 11

Description
As according to instructions provided in the Readme file, I installed vapi_python using the following command:
pip install vapi_python
And I executed the following code to test the connection:
from vapi_python import Vapi

if __name__ == "__main__":
    vapi = Vapi(api_key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)
    vapi.start(assistant_id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)

(Please note that the key id and assistant id work and they have been anonymized)
I am getting the following error when executing this code:
Traceback (most recent call last):   File "E:\code\python_playground\vapi_test.py", line 1, in <module>     from vapi_python import Vapi ImportError: cannot import name 'Vapi' from 'vapi_python' (X:\Users\vihan\AppData\Local\Programs\Python\Python311\Lib\site-packages\vapi_python\__init__.py)
Can someone explain me the cause of this error or an alternative to avoid it? The pip package installation of vapi_python is successful.

Same

same

Vapi Python SDK version: 0.1
Python version: 3.11
Operating System: Windows 11

Description
As according to instructions provided in the Readme file, I installed vapi_python using the following command:
pip install vapi_python
And I executed the following code to test the connection:
from vapi_python import Vapi

if __name__ == "__main__":
    vapi = Vapi(api_key=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)
    vapi.start(assistant_id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)

(Please note that the key id and assistant id work and they have been anonymized)
I am getting the following error when executing this code:
Traceback (most recent call last): File "E:\code\python_playground\vapi_test.py", line 1, in <module> from vapi_python import Vapi ImportError: cannot import name 'Vapi' from 'vapi_python' (X:\Users\vihan\AppData\Local\Programs\Python\Python311\Lib\site-packages\vapi_python\__init__.py)
Can someone explain me the cause of this error or an alternative to avoid it? The pip package installation of vapi_python is successful.

I figured it out... its the pypi we have to install from git,,, the pypi has been delted all files are empty.!

same issue

I have also run into this problem and have resorted to using the API with requests and basically putting together my own internal package.

What's the endpoint to send a message to the Assistant from the User? I couldn't figure it out.

Update
I'm getting an error with one of the dependencies of Vapi, now. It says that the daily package is not found, and I can't locate the correct daily package on Pypi or pip.
File "X:\code\Chatbot\backend\app.py", line 4, in <module>     from models import Models   File "X:\code\Chatbot\backend\models.py", line 18, in <module>     from vapi_python import Vapi   File "X:\code\Chatbot\backend\venv\Lib\site-packages\vapi_python\__init__.py", line 3, in <module>     from .vapi_python import Vapi   File "X:\code\Chatbot\backend\venv\Lib\site-packages\vapi_python\vapi_python.py", line 3, in <module>     from .daily_call import DailyCall   File "X:\code\Chatbot\backend\venv\Lib\site-packages\vapi_python\daily_call.py", line 18, in <module>     class DailyCall(daily.EventHandler):                     ^^^^^^^^^^^^^^^^^^ AttributeError: module 'daily' has no attribute 'EventHandler'

hey y'all, sorry about the delay. try now: https://pypi.org/project/vapi-python

hey y'all, sorry about the delay. try now: https://pypi.org/project/vapi-python

This isn't working, I have tried it today.

Hi there, sorry for the delay. Seems I'm unable to reproduce on my end on a fresh install.
Can you try
pip uninstall vapi-python
pip uninstall daily-python
pip install vapi-python

Same. @jordancde even your latest uninstall/reinstall doesn't work

Okay, I figured out the cause, the dependency daily-python does not exist for Windows (https://pypi.org/project/daily-python/0.7.4/#files)
Trying in WSL now

@namanyayg did you find the solution?

WSL2 seems to work (WSL1 won't, don't bother trying). But it seems to have much worse latency than Vapi Web.

Confirmed with Daily. They expect to have Windows support by July.

Same error on raspberry pi zero, how could I confirm if underlying module is responsible ?

same error

windows is not supported: https://github.com/daily-co/daily-python/issues/7

I have solved with:
!sudo apt-get install portaudio19-dev
!pip install vapi-python

Confirmed with Daily. They expect to have Windows support by July.

Any news on that ? Working with wsl is so limiting.
Thanks.

I believe they have started work on it, let me check the ETA

End of Oct or Mid Nov~

End of Oct or Mid Nov~

any update on this? thanks


Text Color

Hi, thanks for your hard work. I have a question, is it possible to generate data with only black or white text and with full opacity(no trasparency at all) only by tweaking config params?

@lorisgir Hi, I am also confused about how to disable transparency. Could you give any suggestions? Thanks!

Hi, I didn't really figure it out. I just managed to set custom font and color to the text


add option to respect .eslintignore

Because it would be handy. We can probably just do similar to what the atom plugin does here (though I don't think we can do the find-cached thing...)

Here's a starter test for this:

test('wont modify a file if it is eslint ignored', async () => {
  await formatFiles({_: ['src/**/ignored*.js'], write: true})
  expect(fsMock.readFile).toHaveBeenCalledTimes(1)
  expect(fsMock.writeFile).toHaveBeenCalledTimes(1)
  expect(fsMock.readFile).toHaveBeenCalledWith(
    expect.stringMatching(/applied/),
  )
  expect(fsMock.writeFile).toHaveBeenCalledWith(
    expect.stringMatching(/applied/),
  )
  const ignoredOutput = expect.stringMatching(/3.*?files.*?ignored/)
  expect(console.log).toHaveBeenCalledWith(ignoredOutput)
})


feat: rate limit worker

fixes FTD-2074, FTD-2142

Added some unit tests (mostly written by ChatGPT)

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr

/release-pr


[stats] replicator scheduler crashed counter not inrcementing

I set up a _replicator document with an incorrect URL in it, and let the replication scheduler attempt to access it a few times in a row.
Repeated fetches of /_node/couchdb@localhost/_stats showed that couch_replicator.jobs.crashed.value stayed at 0 and never incremented.
Steps to Reproduce (for bugs)
Create a _replicator document of this form:
{
    "_id": "my_rep",
    "source": "http://does.not.resolve.wohali.rules/foo",
    "target": "http://<IP_ADDRESS>:5984/bar",
    "create_target": true
}

and let it cycle through a few nxdomain errors (as evidenced by couch.log).
Context
Trying to put together an open source CouchDB monitoring solution, and failing to get useful stats out of the new scheduler.
Your Environment

Version used: 2.1.0
Browser Name and version: n/a
Operating System and version Debian 8 (jessie)

Took a look at this one.
Saw the same behavior. There could be 3 reasons for not noticing the crashed guage being bumped.

There is a fairly high retries_per_request default value of 10 used to retry failed requests. Requests are tried 10 times with exponentially increasing sleep amounts in between, starting at 0.25 seconds. That mean that there could be up to 4 minutes of retrying the same failed request before the job fails and scheduling replicator reports a crashed status for it.  I made a PR to reduce the default number of tries to 5 so there would be up to 8 seconds worth of retries instead. This makes more sense now that the scheduling replicator is used, as it can better handle reporting and backing off when errors occurs. This means that for quite a while (tens of minute or hours) the status for the replication job might be in the running state since it wasting time retrying that request.

Replications will uniformly pick one node in the cluster to run on which doesn't have to be the node which processed the document update request. To detect the crashed stats update would have to know which node to check for changes. I made this mistake so mentioning it here just in case. Perhaps there is a case there in general for aggregating stats for all nodes.

Crashed status is only reported after the replication job has crashed and is waiting to run next (possibly being penalized if it crashed too many times in a row). However as soon as it is given a chance to run again, it gets counted as running. While in that state it won't bump the crashed guage. This was done such that he total number is always equal running + pending + crashing. So the effect of this is that the crashing count will periodically go down for a bit when job is attempting to run, then when it fails it will be bumped back up. Before the PR above, this could take quite a while, but even with it might still take up to 15 seconds (8 seconds worth of retries + stats updates happen with a delay of 5 seconds).

@nickva Thanks, this all makes sense. I'd like to not lose track of point 2 above. Could you file a new enhancement issue for this concept so we can add it to the backlog?


Swap in base58_check for base64 in most places

Swap in base58_check in most places that base64 was being used. Didn't do it for lite client, can do that if this PR is OK.
Tagged this PR as WIP to see if CI passes.
Renamed Base58_check.base58_check to Base58_check.encode and Base58_check.base58_check_decode_exn to Base58_check.decode_exn.

Should we just start at 0x00 and increment?

We can do that, but we may want particular values in order to get base58 strings that begin with certain characters to make them recognizable as a given type. I think Bitcoin does that.
Maybe it's enough to put them in numeric order?


Cant play in Android Devices

I coludnt play in android devices.
I use Mx player and vlc player.
How to solve this problem?

You can't play because this script didn't get the redirector link actually.
This only get the download link, no streaming.

yes but you can stream from the download link


[Bug]: Rate Limit Exceeded in DDGAPIWrapper Search Function

Describe the Bug
The original DDGAPIWrapper raises a DuckDuckGoSearchException due to exceeding DuckDuckGo API's rate limits. This prevents the application from retrieving search results effectively.
Error Message
duckduckgo_search.exceptions.DuckDuckGoSearchException: _get_url() https://duckduckgo.com/ DuckDuckGoSearchException: Ratelimit

Steps to Reproduce

Integrate the original DDGAPIWrapper class into your project.

Invoke the run method multiple times rapidly, for example:

python -m metagpt.roles.researcher "tensorflow vs. pytorch

The application raises a DuckDuckGoSearchException with the message Ratelimit.

Sample Code of the original DDGAPIWrapper:
import asyncio, json
from concurrent import futures
from typing import Literal, Optional, overload
from pydantic import BaseModel, ConfigDict
from duckduckgo_search import DDGS

class DDGAPIWrapper(BaseModel):
    model_config = ConfigDict(arbitrary_types_allowed=True)
    loop: Optional[asyncio.AbstractEventLoop] = None
    executor: Optional[futures.Executor] = None
    proxy: Optional[str] = None

    @property
    def ddgs(self):
        return DDGS(proxies=self.proxy)

    @overload
    def run(self, query: str, max_results: int = 8, as_string: Literal[True] = True, focus: list[str] | None = None) -> str:
        ...

    @overload
    def run(self, query: str, max_results: int = 8, as_string: Literal[False] = False, focus: list[str] | None = None) -> list[dict[str, str]]:
        ...

    async def run(self, query: str, max_results: int = 8, as_string: bool = True) -> str | list[dict]:
        loop = self.loop or asyncio.get_event_loop()
        future = loop.run_in_executor(self.executor, self._search_from_ddgs, query, max_results)
        search_results = await future

        if as_string:
            return json.dumps(search_results, ensure_ascii=False)
        return search_results

    def _search_from_ddgs(self, query: str, max_results: int):
        return [
            {"link": i["href"], "snippet": i["body"], "title": i["title"]}
            for (_, i) in zip(range(max_results), self.ddgs.text(query))
        ]

if __name__ == "__main__":
    import fire
    fire.Fire(DDGAPIWrapper().run)

Expected Behavior
The DDGAPIWrapper.run method should perform DuckDuckGo searches and return the specified number of results without triggering rate limit errors, even under multiple concurrent requests.
Actual Behavior
The method intermittently raises a DuckDuckGoSearchException with the message Ratelimit, indicating that the application is sending too many requests to the DuckDuckGo API in a short period.
Analysis
Cause:
The original script lacks mechanisms to control the frequency of API requests. Rapid or concurrent calls to the run method exceed DuckDuckGo's rate limits, resulting in exceptions.
Impact:
Failed search operations disrupt the application's functionality, leading to an inability to retrieve necessary search results.
Proposed Solution
Enhance the DDGAPIWrapper by implementing rate limiting, retry mechanisms, and caching to prevent exceeding DuckDuckGo's API rate limits.
Modifications in DDGAPIWrapper (Script 2):

Introduced libraries for rate limiting (aiolimiter), caching (aiocache), and retries (tenacity).

Defined DuckDuckGoSearchException to handle specific search-related errors.

Implemented AsyncLimiter to restrict to 1 request per second.

Utilized tenacity to retry failed requests with exponential backoff upon encountering rate limit exceptions.

Added caching to store search results for 5 minutes, reducing redundant API calls.

Improved exception handling to differentiate between rate limit errors and other issues.

Changed the main execution to use the cached_run method, leveraging caching and enhanced functionalities.

Modified DDGAPIWrapper:
import asyncio, json
from concurrent import futures
from typing import Literal, Optional, overload
from pydantic import BaseModel, ConfigDict
from aiolimiter import AsyncLimiter
from aiocache import cached, Cache
from aiocache.serializers import JsonSerializer
from tenacity import retry, wait_exponential, stop_after_attempt, retry_if_exception_type
from duckduckgo_search import DDGS

# Custom exception for DuckDuckGo search errors
class DuckDuckGoSearchException(Exception):
    pass

class DDGAPIWrapper(BaseModel):
    model_config = ConfigDict(arbitrary_types_allowed=True)
    loop: Optional[asyncio.AbstractEventLoop] = None
    executor: Optional[futures.Executor] = None
    proxy: Optional[str] = None
    rate_limiter: AsyncLimiter = AsyncLimiter(max_rate=1, time_period=1)

    @property
    def ddgs(self):
        return DDGS(proxies=self.proxy)

    @overload
    def run(self, query: str, max_results: int = 8, as_string: Literal[True] = True, focus: list[str] | None = None) -> str:
        ...

    @overload
    def run(self, query: str, max_results: int = 8, as_string: Literal[False] = False, focus: list[str] | None = None) -> list[dict[str, str]]:
        ...

    @retry(
        retry=retry_if_exception_type(DuckDuckGoSearchException),
        wait=wait_exponential(multiplier=1, min=4, max=10),
        stop=stop_after_attempt(5),
        reraise=True
    )
    async def run(self, query: str, max_results: int = 8, as_string: bool = True) -> str | list[dict]:
        loop = self.loop or asyncio.get_event_loop()

        async with self.rate_limiter:
            try:
                future = loop.run_in_executor(self.executor, self._search_from_ddgs, query, max_results)
                search_results = await future
            except Exception as e:
                if 'Ratelimit' in str(e):
                    print(f"Rate limit hit for query: {query}. Retrying...")
                    raise DuckDuckGoSearchException("Rate limit exceeded") from e
                else:
                    print(f"An error occurred: {e}")
                    raise DuckDuckGoSearchException("An error occurred during search") from e

        if as_string:
            return json.dumps(search_results, ensure_ascii=False)
        return search_results

    def _search_from_ddgs(self, query: str, max_results: int):
        return [
            {"link": i["href"], "snippet": i["body"], "title": i["title"]}
            for (_, i) in zip(range(max_results), self.ddgs.text(query))
        ]

    @cached(ttl=300, cache=Cache.MEMORY, serializer=JsonSerializer())
    async def cached_run(self, query: str, max_results: int = 8, as_string: bool = True) -> str | list[dict]:
        """Cached version of the run method."""
        return await self.run(query, max_results, as_string)

if __name__ == "__main__":
    import fire
    api_wrapper = DDGAPIWrapper()
    fire.Fire(api_wrapper.cached_run)

Outcome
The application seems to have successfully mitigated rate limit issues.
I am saying this because I am using models inferred by ollama API endpoints, such that I have encountered issues with respect to token counting, which ollama community is still tackling.
So, it would be grateful for anyone who is able to test this proposed solution and see whether it does solve problems relating to DDG while not introducing other errors.
But overall, some comments on the proposed fix:

The AsyncLimiter ensures that search requests do not exceed 1 request per second, adhering to DuckDuckGo's rate limits.

The retry mechanism automatically handles transient rate limit errors by retrying failed requests with exponential backoff.

Caching reduces redundant API calls for identical queries, optimizing performance and further preventing rate limit breaches.

Boiler-plate for custom exceptions for future debugging and maintenance.

@cnm13ryan  Thank you very much for your advice. Using tenacity is indeed an effective approach. However, I suggest defining a separate DDGSearchRatelimitException, and only retry when a DDGSearchRatelimitException is triggered, rather than retrying on any exception.

@cnm13ryan  And, feel free to raise a PR :)


Requirements: Set / change amount of consumed ingredient per day.

manual change of amount of ingredient per day


All translation sources default to 'en' [Bug]

Googletrans version:

[ ] 4.0.0rc1
[x] 3.1.0a0
[ ] 3.0.0
[ ] 2.x

I'm submitting a ...

[x] bug report
[ ] feature request

Current behavior:

No matter the specified src, the returned translation specifies src=en.
Expected behavior:

The src should be whatever I specify it as. For example, src=tr should be a translation from Turkish.
Steps to reproduce:

test = translator.translate('merhaba', src='tr', dest='ar')
print(test)

Returns
Translated(src=en, dest=ar, text=merhaba, pronunciation=merhaba, extra_data="{'translat...")

Related code:

insert short code snippets here

See above
Other information:

I had the same problem. Upon investigation I noticed that I got a 429: Too many requests response instead of a 200. Is there a limit on requests that one can make?

I had the same problem. Upon investigation I noticed that I got a 429: Too many requests response instead of a 200. Is there a limit on requests that one can make?

Think this is the same issue: [https://github.com/ssut/py-googletrans/issues/121]

I have the same problem but it seems to only occur with large texts. I don't seem to get the 429: Too many requests

Apparently the length limit is 5000


Maximizing the window crashes the modeler (segfault)

Describe the bug
When trying to maximize the modeler window, the application crashes with a segfault. It seems to only affect the 5.23 version. I tested 5.17 and 5.22 and they both work as expected
Steps to reproduce

(Run Ubuntu on X.org, don't know if required)
Start the modeler
Use one of the following:

Click the "maximize" window decoration button
Drag the window to the top of the screen

The application crashes:

./camunda-modeler
INFO app:main:bootstrap starting Camunda Modeler v5.23.0
INFO app:cli parsing [
  '/opt/camunda-modeler/camunda-modeler-5.23.0-linux-x64/camunda-modeler'
] in '/opt/camunda-modeler/camunda-modeler-5.23.0-linux-x64'
INFO app:flags searching for flags.json in paths [
  '/opt/camunda-modeler/camunda-modeler-5.23.0-linux-x64/resources',
  '/home/tannerli/.config/camunda-modeler/resources'
]
INFO app:flags found []
INFO app:flags active {}
INFO app:error-tracking Cannot initialize Sentry:  Crash reports not enabled.
INFO app:plugins searching for plugins/*/index.js in paths [
  '/opt/camunda-modeler/camunda-modeler-5.23.0-linux-x64',
  '/opt/camunda-modeler/camunda-modeler-5.23.0-linux-x64/resources',
  '/home/tannerli/.config/camunda-modeler/resources',
  '/home/tannerli/.config/camunda-modeler'
]
INFO app:plugins found plug-in entries []
INFO app:plugins registered []
INFO app:main:bootstrap received ready
INFO app:workspace restoring /home/tannerli/some.bpmn
INFO app:main:bootstrap received client-ready
INFO app:main window focused
INFO app:workspace saving
Segmentation fault (core dumped)

Expected behavior

No crash
Maximized window

Environment

OS: Ubuntu 24.04
Camunda Modeler Version: 5.23
Execution Platform: Camunda 7
Installed plug-ins: None

Additional context
No response

Fixed with nightly and to be shipped with next modeler release.
Closing as duplicate of https://github.com/camunda/camunda-modeler/issues/4299.