Retain same font-size in fullscreen and normal view

Can we have option to maintain same font-size as normal view in fullscreen and instead of changing font size we can adjust number of rows in fullscreen view.
I tried this by using changing number of rows depending on the height available for the container in any view (normal or fullscreen), but that leads to recreation of the whole player because number rows are changing in the player (rows option).
Can we have some functionality around this:

Option to adjust font-size or rows in case switching to fullscreen view or height/width change.
When some of the options in the player changes, don't re-create the whole player, instead just re-render the player efficiently.

Информация

Dynamically changing number of columns/rows is a can of worms I'm willing to open :)
You can't reliably do that without breaking display of recordings which include fullscreen programs like vim, man, mc, and many others. The reason is: when you resize your terminal the running program (e.g. vim) can react to that by redrawing its UI for the new terminal size, but during playback in asciinema player this program (vim) is not running and therefore there's no way for the player to know how to redraw a screen without making it garbage. Truncating / padding the rows could a compromise option, but that's not supported by asciinema's virtual terminal at the moment.


Upgrade jeo to version 0.6.

Includes a package renaming from org.jeo to io.jeo
Artifacts also available in maven central to removing boundless
repository reference.

Thanks Justin!  Please see my email (CC'ed to dev list) on getting an ICLA signed.  Just comment here when you've done that and I'll verify then merge the pull request.


feat: implement LENGTH function

Fixes #1297.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

47 of 61 (77.05%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 98.689%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/executor/evaluate/function.rs
5
6
83.33%

core/src/ast_builder/expr/function.rs
0
4
0.0%

test-suite/src/function/length.rs
29
38
76.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
44953

Relevant Lines:
45550

💛  - Coveralls


[CH] Support asynchronous reading of hdfs

Description
Profile the reading process of hdfs, get the following statistical data.
ReadBufferFromHDFS

time cost
value

wait time on next call nextImpl
322414628 ns

executiont time on nextImpl
284697436 ns

execution time on seeking
4874510 ns

and the total pipeline rumtime cost is

It's worth a try to make the reading asynchronously. When the processors of pipeline are busy, we could prefetch next block from hdfs.

There is a data race on read buffer in AsynchronousReadBufferFromHDFS.  It replaces ReadBufferFromHDFSImpl::internal_buffer with AsynchronousReadBufferFromHDFS::memory each time to load a next batch. When a new async task has been submitted, but the content of AsynchronousReadBufferFromHDFS::memory has not been copied out, then the data will be flushed by the async task.


Sto relnotes 2023 07 12 doc 6189

Harness Developer Pull Request
This PR includes the STO July 12 release notes and a new feature:

Security Testing Orchestration release notes
Set up target baselines

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Fixed nomination bug caused by missing validators

Previously the change in the missing validators caused our SCP votes to
change from 'Yes' to 'No' triggering asserts in the SCP code. This has
been fixed by introducing lower and upper bound of acceptable missing
validators.
fixes: #2152

I am not really understanding the lower and upper bounds.

The idea here is that, the previous way of implementing what is considered acceptable missing validator was too strict. Instead of equality, NodeA will check the candidate from NodeB in the following way:
Current missing validators in NodeA(=X) ⊆ candidate containing missing validators from NodeB(=Y) ⊆ missing validators in NodeA before the nomination round(=Z)
If both of those conditions true, then NodeA will accept the candidate.
As the nodes exchanges preimages througout nomination(implemented in a separate ticket), the X and Y will both converge to [] or at least a stable set of missing validators, so:

the nomination round will end and not last forever
nodes don't change their votes from 'Yes' to 'No'

added docs as Chris suggested, but kept the variable names - with the docs it is easier to undersand without changing the variable names (at least I think)


[MH] Improve FK Performance and Compatibility pt. 2

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw1DKmbKhg2MIECH/recLQknmolY1ZtTaX
Description: In 19.2 and older versions, CockroachDB validates FK constraints "during" inserts, updates, and deletes in-between every row changed. Postgres, most other SQL databases, and the SQL standard, require FK constraints to be validated at the end of the statement because it is more accurate (FKs should not prevent insertions mid transaction) and performant. Delaying the constraint till the end of transaction improves performance because it limits repeated checks throughout the transaction. CockroachDB’s implementation of Foreign Key constraints now match PG and other SQL engines. Further, the CBO now plans FKs which will improve performance for both single and multi-region deployments. This work also applies to FKs using CASCADE.
Foreign key constraints provide referential integrity between two tables by ensuring the entry in one table is a valid entry in the other. Customers often can't achieve their performance requirements when enabling Foreign Keys. TPC-C testing demonstrates that workloads with FKs can handle 34% fewer warehouses. In fact, Many POC customers complain about write query performance (both in one data center and in distributed settings) when enabling foreign keys constraints.  This is problematic because it negates one of the value propositions for a SQL relational database as it leaves customers data susceptible to invalid data. Further, our current implementation is not completely compatible with third-party tools. In 19.2 we delivered an experimental version of improved functionality but it did not alleviate performance concerns.
Team: Andrew Woods, Richard Loveland, Radu Berinde, Justin Jaffray
Github Tracking Issue: https://github.com/cockroachdb/cockroach/issues/15157 https://github.com/cockroachdb/cockroach/issues/25809 https://github.com/cockroachdb/cockroach/issues/26786 https://github.com/cockroachdb/cockroach/issues/26795 https://github.com/cockroachdb/cockroach/issues/23580 https://github.com/cockroachlabs/support/issues/224 https://github.com/cockroachdb/cockroach/issues/33467 https://github.com/cockroachdb/cockroach/issues/16491 https://github.com/cockroachdb/docs/issues/4003 https://github.com/cockroachdb/cockroach/issues/36859 https://github.com/cockroachdb/docs/issues/4788 https://github.com/cockroachdb/docs/issues/5967

I'm going to bump this item to 20.2, as not all of these feature updates are going to be ready for 20.1.
We can document the individual improvements in FK performance as they come up in release notes.

@ericharmeling, I'm sorry it's hard to track this one. Can you track down the relevant release note issues and confirm with @awoods187 and devs that they cover all of the improvements in 20.1?

Hey @ericharmeling. We do have a bit of work to do here. Foreign Keys are now planned by the CBO and no longer require an experimental flag. What got bumped is Foreign Key Cascade which still use the old implementation. This is a small docs project to remove the experimental flag and mention that they are planned using the CBO. After FK cascade lands in 20.2, we will have another small project to update that FKs don't use an extra index but mostly the user will just experience better FK performance. cc @RaduBerinde


Unable to set source attribute on image to Static Property

I have tried to set the property of source using following:
                  Image {
		  Source: Data.MySource
		}

But that threw error saying Unresolved Reference. I did manage to work around it via....
                   Image {
		  Source: bind set [
			Source: Data.MySource
		  ]
		}

Not sure if this is intentional or not?

Can you try using fully-qualified name for the Data object? Something like this:
Image {
  Source: MyApp.Data.MySource
}

Also, what are the types of Data and MySource?

Have tried full name. Here is the class its referring to:
namespace TestAPP.ViewModel
{
   public class Data1
    {
        public const string MySource= "TestText";
    }
}

As I say, this works:
 TextBlock {
		  Text: Data1.MySource
		}

But this doesnt
Image {
		  Source: Data1.MySource
		}


docs: Fix doc home page

The document formatting was broken because of a missing </p> and the links needed to be updated from the readme.
Before:

After:

have you tested this works in CI?

Moving into PR#124


Error With _cls ktlTarget is undefined 0.22.12

Hi Norm
We are getting this error when calling _cls without a ktlTarget:

_cls=[border-top]
It points to this line in addRemoveClass:

In this area of code:

We are on version 0.22.12 it is not an issue on 0.22.10
Thanks Craig

I pushed a fix and uploaded the dev version, if you want to try it out.
Norm

Thank you I'll test in the morning.


TradaComs26v3 file Charge lines contain = sign in TCOD TariffDescription

Hi, I am a NOOB when it comes to EDI files and so far I have 1.5 weeks of experience!
In a TradaComs file the vendor seems to think its ok to have = in the Tariff Description below
CCD=13+4+:Additional Cyclic Re (Balance to be charged=20.26)+:::+++++++++++83000+1000:ZZ:+++83000+83:+A+S+20000+'
Please advise how I should parse this and the presence of the = sign in the Tariff Description causing the VATP Vat Rate percentage to be parsed incorrectly.

Further research https://www.ibm.com/docs/en/i/7.3?topic=clause-symbols-used-in-picture shows that X(40) should allow 40 characters from the EBCDIC character set.
https://en.wikipedia.org/wiki/EBCDIC shows that ( ) and = are valid characters

Hi @ianpowell2017 and thanks for your interest in the library.
Generally in any of the 3 well known EDI formats the grammar is what makes the allowed character set. The only invalid chracters would be those that are part of the grammar delimiters. And in many cases even those can be escaped so that they can take part of a component value. Keep in mind that generally Tradacoms is the UK style of EDIFact. They are in a sense verry similar with slight differences in conventions about the implicit tags/segments they use for groups messages as well as default chracters they use for delimiters/separators.
Are you trying to serialize or deserialize?

Hi, thanks for the response.
I am trying to deserialise and I get errors when the sender includes = in the text.

You can check out the nuget package for the v2.0.0-beta02 that contains this enhancement.


reflect changes of 0.23.0 release

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   83.12%   83.12%
=======================================
  Files          19       19
  Lines        2276     2276
=======================================
  Hits         1892     1892
  Misses        384      384

Impacted Files
Coverage Δ

src/crate/crash/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a839ef0...b987d76. Read the comment docs.

Coverage remained the same at 83.128% when pulling b987d76fd901af50349c58c5ed75ce41e9af198c on m/reflect-0.23 into a839ef0737a11f6017d8c8064de3f3a115d33030 on master.


Reload js in control panel

Question
i'm building a module in the Control Panel of a Craft cms 4 site that should show a list of inputs and a button should add new fields, i copy your "Load More" example, the code work perfecy, it add new fields, but all the input in the page stop to work, i mean there are no events and the classes are reset.
I read in this article https://putyourlightson.com/plugins/sprig#javascript that i need to use afterSwap to force the js to re-render, but i don't know what i need to write in the afterSwap, i'm in the Control Panel, which js script write in the fields?
Here the field in twig:
{{ forms.timeField({     label: 'Time'|t('plugin-handle'),     id: 'time',     name: 'time',     value: '12:30',     required: true, }) }}
Here the html of the element before the sprig reload:
<input type="text" id="time-time" class="text ui-timepicker-input" name="time[time]" value="12:30" size="10" autocomplete="off" placeholder=" " dir="ltr" aria-labelledby="time-label" aria-describedby="time-time-format">
Here the html of the element after the sprig reload:
<input type="text" id="time-time" class="text" name="time[time]" value="12:30" size="10" autocomplete="off" placeholder=" " dir="ltr" aria-labelledby="time-label" aria-describedby="time-time-format">
Additional context
in the first image the element has all the events and the classes, on the top we see that there is the list of selectable times, in the second it is a simply input without times

Versions

Plugin version: 2.6.7
Craft version: 4.8.4
Sprig Plugin: 2.7.3

Calling Craft.initUiElements() after a re-render should reinitialise the UI elements like time fields. So here’s how you might do it inside the component:
{% if sprig.isRequest %}

{% endif %}

Reference: https://github.com/craftcms/cms/blob/0ee238caffda1bd3b2f56c10a7a30bd6935dd2cb/src/web/assets/cp/src/js/Craft.js#L1905

Thanks for the fast reply.
It not help me, i saw in \vendor\craftcms\cms\src\templates_includes\forms\time.twig:70 that it include a js tag with some instruction that manage the TimeField, if i run manually the TimeField work nice.
What i miss / wrote incorretly?
What should i do fix it?
The craft-sprig-core is installed and i wrote Sprig::bootstrap(); i the Module file of my custom module

Whenever I have a field like that, that includes its JavaScript in the template within {% js %} tags, I try to exclude it from the markup that is replaced, for example:

    {{ forms.timeField() }}

        ...

If you cannot do this, and the field must be replaced, then you’ll need to either manually run the JavaScript code:
{{ forms.timeField({ id: 'time', ... }) }}

Or you may be able to load the contents of the {% js %} tag inline:
{{ forms.timeField() }}

{% if sprig.isRequest %}
	{% for registeredJs in craft.app.view.js %}
		{% for codeBlock in registeredJs %}

		{% endfor %}
	{% endfor %}
{% endif %}


Let airflow run to accept regex task pattern not only task_id

backfill allows regex pattern as parameter. airflow run should allow the same for 'task_id'

Well airflow run is designed to run a single task instance. If you need multiple then airflow backfill is the way to go.

Agree. Closing.


Provide wasi-stub binary

Providing a prebuilt binary for wasi-stub would speed up automated packaging of plugins that use it.
Currently they have to build it on their own, which makes use cases like xtask slower than they need to be.

I guess it could be done pretty easily using github action


add actions MoveCursorToView, PageDownAndMoveCursor, PageUpAndMoveCursor

This PR adds three new actions:

CursorToViewTop
CursorToViewCenter
CursorToViewBottom

Both the first and last actions apply an offset of scrollmargin to avoid the view jumping when the user hits a cursor movement key.

Please squash the commits into one, there is no point in having a broken commit immediately followed by a commit that fixes it.

Currently it's hard to identify the difference from the usual Page{Up|Down} to PageUp,CursorToViewTop resp. PageDown,CursorToViewBottom. Do I something wrong?

Well, PageUp and PageDown just move the view, leaving the cursor where it is. So you could have a cursor, multi-cursor, selection or multi-selection, you could PageDown a number of times, then PageUp back to where you where and your cursors/selections would be untouched.
Page[Up|Down],CursorToView[Top|Center|Bottom]  give you the option to have the cursor in a predictable place when you page up or down. The CursorToView[Top|Center|Bottom] actions are useful by themelves as well, especially when you have a view that's over 100 lines tall and would like to move the cursor without holding down the arrrow keys.

Would be nice to have a CursorKeep for chaining to provide the possibility to align the behavior to many other editors.

Don't worry, that's coming up in the next PR. Instead of CursorKeep we're going to either modify the CursorPage[Up|Down] actions or create new ones that keep the cursor at the same relative location in the view while paging up/down.

Well, PageUp and PageDown just move the view, leaving the cursor where it is.

Well, yes...but more precise it changes the view to scrollmargin (used with default value on my end) and from there moves the lines. When I combine/chain them with CursorToViewTop resp. CursorToViewBottom I had the same effect. Except I did something wrong.
When I combined the default bindings with CursorToViewBottom then the cursor was indeed kept in the middle and the views scrolled, but just till I reached 50% of top or end. A further PageUp/-Down key didn't moved it to the top or end.
So maybe it is just me having again the totally wrong expectation.

When I combined the default bindings with CursorToViewBottom then the cursor was indeed kept in the middle and the views scrolled, but just till I reached 50% of top or end. A further PageUp/-Down key didn't moved it to the top or end. So maybe it is just me having again the totally wrong expectation.

I think you mean CursorToViewCenter. Anyway, your desired Page Up/Down behavior will be implemented in my next PR. (I already have the code ready to go).

I think you mean CursorToViewCenter.

Yes.

Anyway, your desired Page Up/Down behavior will be implemented in my next PR. (I already have the code ready to go).

Are we still talking about CursorToViewCenter? In case of yes, why not here? We try to add a action, which doesn't fit in its behavior to CursorToViewTop & CursorToViewBottom (reaching first and last line via consecutive PageUp/PageDown keys).
Since I'm still puzzled about CursorToViewTop & CursorToViewBottom I trust you guys that they have their purpose.

Are we still talking about CursorToViewCenter? In case of yes, why not here? We try to add a action, which doesn't fit in its behavior to CursorToViewTop & CursorToViewBottom (reaching first and last line via consecutive PageUp/PageDown keys).

Yeah, I think I haven't been able to make myself clear so far. The purpose of CursorToView[Top|Center|Bottom] is not to reach lines via PageUp/Down keys. The CursorTo... actions are completely independent of Page[Up|Down]. Their only purpose is to move the cursor to the top or bottom (accounting for scrollmargin) or the center of the view. In other words, their primary purpose is not to be chained with Page[Up|Down], but to be used as independent actions with their own key bindings. For instance, I have Alt-[q|w|e] bound to CursorToViewTop, CursorToViewCenter, and CursorToViewBottom.
You can certainly chain them with Page[Up|Down] or any other action if you wish, but their purpose is not to implement the correct Page up/down behavior by chaining them with the Page[Up|Down] actions.
To recap: this PR is solely to implement the CursorToView... actions. The next PR will implement the page up/down behavior you want as single actions, without any need for chaining anything.

@JoeKar I also don't quite get your point. CursorToViewCenter moves the cursor to the view center, simple as that. CursorToView{Top,Center,Down} actions are independent of Page{Up,Down} (although of course can be chained with them, just like with any other actions.)
Also to remind just in case: Page{Up,Down} should not be confused with CursorPage{Up,Down}.
...If we change the behavior of CursorPage{Up,Down} to be nano-like, perhaps CursorToViewCenter,CursorPage{Up,Down} will do what you want? I.e.: CursorToViewCenter will move the cursor to the center if it isn't already there, and then CursorPage{Up,Down} will either move the cursor one page up/down if we are not on the first/last page, or move the cursor to the first/last line if we are already on the first/last page.

The purpose of CursorToView[Top|Center|Bottom] is not to reach lines via PageUp/Down keys. The CursorTo... actions are completely independent of Page[Up|Down].

@JoeKar I also don't quite get your point. CursorToViewCenter moves the cursor to the view center, simple as that.

Ok guys, excuse me. I was too stubborn and fixed/focus on this other "use case" (most probably it isn't even one in that combination) and totally ignored the stand-alone purpose. So let us bring this to an end here.


issues #226, #227, #155

fixes #226

fixes #227

almost #155

https://github.com/odota/ui/issues/155#issuecomment-252042343

Not yet ready for merge 🐰

ready for merge?

This LGTM, I'll merge (if there were any other changes you wanted to make, please open a new PR)


Clean Dropdown listeners if component is destroyed

This change prevents leaving dangling listeners that will keep causing errors if the component is destroyed while the dropdown is open.

Will release patch in next few days, thanks

This is released in v3.14.1, thanks for the fix.


Unknown command wsserver - solved

I kept getting this error after following the manual install version on a debian server.  I finally added a slash to BobWiki in the node command and it worked. - "node ./tiddlywiki.js Wikis/BobWiki  --wsserver" did not work but "node ./tiddlywiki.js Wikis/BobWiki/  --wsserver" did.  Hope this saves some others a bit of time.

I am running (check any that apply, put an x inside the [ ] to check a box, like this: [x]):

[ ] Windows
[ ] OSX
[x] Linux
[ ] Other

and using

[x] The nodejs version
[ ] The single file executable

Before posting I read issue guidelines and:

[x] I am using the newest version
[x] The answer to my question isn't listed in the documentation or this isn't
a question
[x] This is not a duplicate issue
[x] I have not done anything that required me to set acceptance to
I Will Not Get Tech Support For This

That is odd. I will experiment a bit but I don't think I have run into this. If I can repeat it I will try and make.sure the.trailing / is optional

Ok This is embarrassing.  I logged in to duplicate and it didn't make a difference.  I cycled back through my  commands and saw that I was entering BobWiki as Bobwiki. Like 7 times.  And then I spelled it correctly the time I put the trailing / in.  I'll fall back on my usual excuse - I work nights and I rarely even know what day it is.
I apologize for any time wasted.


Add test dataset and a gridding test that uses it.

Closes #7

This is close enough for now; #11 will improve on the organization of things, but is a more drastic change.


Code Getting Messy

The code among the (currently) three libraries has gotten a bit messy. In particular the scene management code in tk-graphics. This needs to be fixed ASAP before it starts creeping further.

This can also include tidying up the Readme files. They don't actually say anything at this point.


Prepublish Checklist: Try Checkpoint State Management

Context
We're introducing "triggers" to the PPC in this next release so we need a way to tell what checkpoint we're at and what triggers are available. Since there's multiple paths to the same result, I thought we should try a little state machine.
Summary
introduce idea of state machine to track available interaction of prepublish checklist by checkpoints
Relevant Technical Choices
Sets up a small state machine to manage the current state of the prepublish checklist by "checkpoints" (how I'm thinking about these new triggers to expose recommendations and high priority items staggered).
To-do
If we like this direction we should write some tests in this branch 🙃
User-facing changes
None
Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[ ] I have tested this code to the best of my abilities
[ ] I have verified accessibility to the best of my abilities (docs)
[ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[ ] I have added documentation where necessary
[ ] I have added a matching Type: XYZ label to the PR

Fixes #

I think they work well together, but I think there's an argument for just killing all the code I wrote and just scheduling state machine dispatches in the ppc inside of effects that run on story change. Anyway, just something to keep in mind when I get my draft PR up later today and you're checking it out.

Possibly a good question here is if there's a likelihood that the code you've written to watch for checks is going to be useful for other areas of the editor (say, FTUE perhaps?). This might be good to get Morten and Will to weigh in once the code's up (not tagging since it's kinda premature).

I think they work well together, but I think there's an argument for just killing all the code I wrote and just scheduling state machine dispatches in the ppc inside of effects that run on story change. Anyway, just something to keep in mind when I get my draft PR up later today and you're checking it out.

Possibly a good question here is if there's a likelihood that the code you've written to watch for checks is going to be useful for other areas of the editor (say, FTUE perhaps?). This might be good to get Morten and Will to weigh in once the code's up (not tagging since it's kinda premature).

Yea I definitely think we can already migrate the useUserOnboarding functionality into just being a FTUE action called on a story trigger. But yea, we'll see how much UX keeps utilizing these implicit user flows based on story mutations. Does seem to be a common trend lately across FTUE and PPC


Documentation

Is there any documentation or tutorial please ?

No. This is just a random project I was working on a while ago. I haven't worked on it in  a while. However, if you want a tutorial about hexagonal maps in unity, you may want to check out quill18creates series on it or this article: http://www.redblobgames.com/grids/hexagons/


remove deprecated uses of http protocol options

Fixes https://github.com/istio/istio/issues/29735
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ X] Does not have any changes that may affect Istio users.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b374ac3bdbbd925ce6aa487318bd580872c5dc6d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is not ready for review yet. Still working on some refactoring.

/retest

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
b374ac3bdbbd925ce6aa487318bd580872c5dc6d
link
/test unit-tests_istio

lint_istio
fa7db5882f0a8073c6311b58db0d6cc6137b192f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
fa7db5882f0a8073c6311b58db0d6cc6137b192f
link
/test lint_istio

unit-tests_istio
fa7db5882f0a8073c6311b58db0d6cc6137b192f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
432a2771937262fd380bdacc77a0393f882cbcaf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Most of the changes are to move functions form cluster to cluster_builder so that they can access the httpProcoolOptions stored in cluster builder - That is to update those options in multiple functions and finally marshal it.

Can you split the cluster refactor and the deprecated http protocol options? Then it will be easier to review.

Can you split the cluster refactor and the deprecated http protocol options? Then it will be easier to review.

Yes. I will do


Adding files for control board v2.0.1+2+3

Also, updates to arduino shield, and updates to pcb assembly READMEs

This replaces the older draft PR here: https://github.com/nasa-jpl/open-source-rover/pull/198

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

Might want to do a rebase, this seems to be re-introducing a bunch of files that were already deleted in the target branch

Sure about that? Here's the diff:

Are you saying that the hierarchy of electrical/pcb/control_board and electrical/pcb/arduino_uno_shield is not what we want?

Is it doable to correct that atrocious sheild typo? :smiling_face_with_tear:

Is it doable to correct that atrocious sheild typo? 🥲

oh boy, i hadn't even noticed that. Has that just always been there? I suppose it's fixable...

@apollokit can you remove the old files? I think it's best if they're not part of v2.

@apollokit can you remove the old files? I think it's best if they're not part of v2.

done

Merging this now to be done with it


bfloat16 overflow during training session

I tried vanilla pytorch training loop using bfloat16, the loss got overflow, https://github.com/mesolitica/malaya/blob/5.1/pretrained-model/mamba/causallm-130m-bf16.ipynb
so I tried vanilla pytorch training loop using fp32, the loss is ok, https://github.com/mesolitica/malaya/blob/5.1/pretrained-model/mamba/causallm-130m-fp32.ipynb
I thought maybe because no gradient clipping and etc, so I tried using HuggingFace trainer with Deepspeed, https://github.com/mesolitica/malaya/blob/5.1/pretrained-model/mamba/causallm-130m-trainer-deepspeed-bf16.ipynb, the loss got overflow.
so I removed deepspeed and use fp32 in HuggingFace trainer, https://github.com/mesolitica/malaya/blob/5.1/pretrained-model/mamba/causallm-130m-trainer-fp32.ipynb, the loss is ok.

If bfloat16 is not working, deepspeed is not going to work.

We don't use deepspeed, just Pytorch AMP (bf16) to train models. Can you try that?

Model parameters should be in fp32, just like in Pytorch AMP docs.

Looks good on amp bf16, https://github.com/mesolitica/malaya/blob/5.1/pretrained-model/mamba/causallm-130m-trainer-bf16.ipynb, and I saw there is 2.8B checkpoint, what is the batch size and it use 2k context length right based on the paper? Is it the 2.8B model fit in a single A100 80GB?

The 2.8B uses total batch size of 1M tokens (following GPT3 paper), and seqlen=2k. Activation memory should be around the same as an optimized transformer (e.g. with FlashAttention), so it should fit in a single A100 80GB (you might need to adjust gradient accumulation to fit).
For models around 1B-3B on 8xA100s, sharding the optimizer states (e.g. with Pytorch distributed optimizer, equivalent to ZeRO-stage1) will help reduce the amount of memory needed.

Thanks!

I tried with Zero2 FP32, sometime not overflow, sometime overflow, after that tried 1e-6 lr and 0.1 gradient norm, no longer overflow but 0.1 gradient norm is too low for pretraining.

Thanks for your explorations! I added a little warning to the README about the dtype, but it's quite useful for people to post their observations here. We've actually never seen these types of instabilities during training; as Tri said, we just use native PyTorch AMP.

I am using pytorch's FSDP with bf16 for training. Looks like I encountered similar issue with NaN loss.

I am using pytorch's FSDP

what is your auto_wrap_policy? if you don't mind sharing it
@binxuan

I am using pytorch's FSDP

what is your auto_wrap_policy? if you don't mind sharing it @binxuan

This worked for me:
from mamba_ssm.modules.mamba_simple import Block
from torch.distributed.fsdp.wrap import transformer_auto_wrap_policy

auto_wrap_policy = partial(
    transformer_auto_wrap_policy,
    transformer_layer_cls={Block,},
)

I was also able to pretrain a 200m mamba lm on 12b tokens yesterday in bf16 without issue. Testing fsdp + bf16 right now and everything works as expected as well.

Hi, I am using pytorch_lighting trainer with bf16-mixed precision, i.e., model params in f32 and bf16 to train the model (pytorch_lightning also use Pytorch AMP under the hood), to train Mamba on DNA data, however, the training is still
quite unstable

Weirdly, I trained using the same code and same model (different size) with f16-mixed precision on NLP data (wiki103), and such instability did not occur. Any suggestion?

Hi, I am using pytorch_lighting trainer with bf16-mixed precision, i.e., model params in f32 and bf16 to train the model (pytorch_lightning also use Pytorch AMP under the hood), to train Mamba on DNA data, however, the training is still quite unstable

Weirdly, I trained using the same code and same model (different size) with f16-mixed precision on NLP data (wiki103), and such instability did not occur. Any suggestion?

I also have observed similar instabilities with using PL trainer. In my case I am creating custom embeddings which I concantenate along with the text embeddings from mamba before feeding them to the mixer model. I have tried lowering the learning rate, disabling AMP but my loss goes to nan values.

I also have observed similar instabilities with using PL trainer. In my case I am creating custom embeddings which I concantenate along with the text embeddings from mamba before feeding them to the mixer model. I have tried lowering the learning rate, disabling AMP but my loss goes to nan values.

I have similar issues.

@gpantaz  and @lwang2070  were you able to fix the issue of bf16 or fp16 training with PL? I also see training issues for my model.

No sadly :/

Similar issue here.  I am using pytorch_lighting trainer with [bf16-mixed] precision + ddp_strategy ="deepspeed_stage_2".
The same code with same hyper-parameter is Okay on A100-SXM4-80GB even I tune larger learning rate,
but failed on RTX A6000 and 4090.


decancer automatically lowercases all characters

Hi there,
I'm experiencing an issue where decancer automatically lowercases all uppercase letters. As far as I understand, this is unintentional behavior (since it is not documented anywhere I looked). If it is intentional, could we have an option that keeps the case of non-violating characters?
Issue Details

decancer Version: 2.0.2
macOS Version: 14.3.1
Chip: Apple M2 Pro
Architecture: arm64
Node.js Version: v20.4.0
Behavior: The package automatically converts all uppercase letters to lowercase.
Expected Behavior: The case of non-violating characters should be preserved.

Minimal Reproduction
import decancer from "decancer"

console.log(decancer("Test").toString()) // Expected output: "Test", actual output: "test"
console.log(decancer("TeSt").toString()) // Expected output: "TeSt", actual output: "test"

Hi! Yes, unfortunately this is an intentional design decision. All characters are lowercased in order to ease the comparison checks later.

May i ask why you would want this to be a feature? Because the purpose of the output of decancer is for comparison, not to display (it's NOT for formatting!)

May i ask why you would want this to be a feature?

I'm working on a Discord bot that cleans up the display names of members (You seem to be familiar with what Discord and its bots are) so I'm just trying to replace the characters that are strange.
I was originally using https://www.npmjs.com/package/@aero/sanitizer but decancer is more performant which is what attracted me to it.

Ah, i see, i could make a feature that lets you customize how the curing process works, though that would be breaking (for some bindings) therefore would be for a major update.

I see. How would adjusting the curing process look like from a dev perspective?

Things like ```js
decancer(text, {
retainCapitalization: true
})
or
```js
const config = decancer.config({
  retainCapitalization: true
})

decancer(text, config)

Yeah that would be very nice

Please note that this change would be major and breaking (therefore for v3.0.0) - and such change would be time consuming. Be patient!

No problem and thanks for your quick replies!

@net-tech Quick question regarding the ambiguity of capitalization: Some unicode characters, like 🆑 are shown in uppercase CL, do you think decancer should output them in uppercase as well? (Despite 🆑 technically being neither a lowercase nor uppercase character)
If yes, this can be ambiguous when the package says retainCapitalization.

I would just keep it simple

Hai! By 19 February 2024, this issue has been resolved in the latest commit. At the moment you just need to wait until v3.0.0 is out.

Thank you soo much for that offer! ❤ I've never gotten a donation before -- i'm afraid at the moment donation links won't be available until 22 April 2024. I'll let you know once it's available!

No problem. When it's available let me know via this issue or<EMAIL_ADDRESS>It will be a small amount but I'm still dedicated to giving something

It's finally here!
For your use case, it's probably either
const output = decancer(string, {
  retainCapitalization: true
})

Or if you call decancer() multiple times, you can do
const options = decancer.options({
  retainCapitalization: true
})

const output = decancer(string, options)

Or if you want for decancer to keep capitalization and not cure characters from the world's major foreign scripts, you can do
// output is a javascript string
const output = decancer.format(string)

Cheers! If you have any problems or found any bugs, please be sure to let me know! Happy coding! Much love :heart::heart:

Thank you so much!

:heart:

Hey @net-tech! Due to a slight hiccup in the cure_char_inner function, this bug apparently still persists by v3.0.0, i'm so sorry for this. 😭 This bug should be fixed by the latest update, v3.1.2! :heart:

Hey @net-tech! Due to a slight hiccup in the cure_char_inner function, this bug apparently still persists for ASCII characters by v3.0.0, i'm so sorry for this. 😭 This bug should be fixed by the latest update, v3.1.2! :heart:

No problem! Thanks for letting me know.

@net-tech Hai! You can now support me through donations at ko-fi. So sorry for the delay, setting it up took a while!

Just donated! Thank you for setting it up and for fixing the issue!

Thank you so much for the donation! I'm glad that my project helped yours! :heart:


hiccup-cli not found in Melpa repository

The hiccup-cli package is not found when trying to install it via M-x package-install hiccup-cli. The same goes when looking up the package directly in melpa.org search bar, only package found is html-to-hiccup.

Has the package been taken down?

Sorry, It's in review right now https://github.com/melpa/melpa/pull/7387 :grimacing:

Sorry, It's in review right now melpa/melpa#7387 grimacing

Gotcha, sorry I didn't check first.
Thank you :)

No problem, I didn't think it would take this long to get it merged. I'll close this once it's on MELPA and you'll be notified.

It's on Melpa now https://melpa.org/#/hiccup-cli
(Not you still need to compile the cli locally, still need to figure out how to do that using CI/CD)


api: add api-approved.kubernetes.io annotation to CRD

What type of PR is this?
/kind bug
What this PR does / why we need it:
This commit adds the following annotation
api-approved.kubernetes.io: "https://github.com/kubernetes-csi/external-snapshot-metadata/pull/2".
Refer to https://github.com/kubernetes/enhancements/pull/1111 for more details.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

None

/cc @PrasadG193
/cc @carlbraganza

/ok-to-test


admin-status-overview: show used RAM Memory

on the status-page there is some information about RAM Memory usage (all free, free, buffered). but the most important value "used Mem" is missing.
please add that value.
maybe these all four values should be resorted?

Used ram is the inversion of "free".


computational resources needed for inference

i downloaded dataset from here to run gama_inf.py. i can read the wav file with a normal file path like this:
    {
        "audio_id": "YUChcduGcOSc.wav",
        "input": "",
        "dataset": "Audioset_Strong",
        "task": "open-ended question",
        "instruction_output": [
            {
                "instruction": "Considering the sequence and timing of the audio events, deduce the timing of the interruption in the conversation.",
                "output": "The conversation was likely interrupted around the 2.318-second mark, when the man's speech ends and snoring sounds start."
            },
            {
                "instruction": "Analyze the presence of grunting sound in the audio after the man speaks. What could that indicate?",
                "output": "The presence of a grunt sound after the man speaks could indicate that he is expressing anger or frustration."
            },
            {
                "instruction": "Assess the overall atmosphere inferred from the audio events. How do the man's speech, the impact sounds, and the snoring sound contribute to the atmosphere of the scene?",
                "output": "The scene could depict a humorous or awkward situation where a person falls asleep while someone is talking, indicated by the man's speech, followed by impact sounds and then snoring."
            }
        ],
        "timestamp_events": "['(Mechanisms-0.012-4.853)', '(Generic impact sounds-0.13-0.379)', '(Generic impact sounds-0.435-0.92)', '(Tap-1.007-1.181)', '(Generic impact sounds-1.187-1.454)', '(Male speech, man speaking-1.616-2.318)', '(Generic impact sounds-2.61-2.728)', '(Grunt-3.032-4.723)', '(Generic impact sounds-4.716-4.853)']"
    },

however, there are some files like this:
"audio_id": "/fs/nexus-projects/audioset/unbalanced_wav/OBPySxWxlcE.wav"

i need to manually delete the part /fs/nexus-projects/audioset/unbalanced_wav/. i am just wondering is there anything special about unbalanced dataset? or it is fine just mix together with others. Thanks!

That is just the path of the audio, there is nothing special about it. You just need to update the current aduio_id which is the path to the audio to the path to downloaded audio.


[SPARK-6514][SPARK-5960][SPARK-6656][SPARK-7679][STREAMING][KINESIS] Updates to the Kinesis API

SPARK-6514 - Use correct region
SPARK-5960 - Allow AWS Credentials to be directly passed
SPARK-6656 - Specify kinesis application name explicitly
SPARK-7679 - Upgrade to latest KCL and AWS SDK.

Merged build triggered.

Merged build started.

Test build #32711 has started for   PR 6147 at commit 373b201.

@cfregly

Test build #32711 has finished for   PR 6147 at commit 373b201.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32711/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32860 has started for   PR 6147 at commit f23ea77.

Test build #32860 timed out     for PR 6147 at commit f23ea77     after a configured wait of 150m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32860/
Test FAILed.

test this please.

Merged build triggered.

Merged build started.

Test build #32876 has started for   PR 6147 at commit f23ea77.

Test build #32876 has finished for   PR 6147 at commit f23ea77.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32876/
Test FAILed.

test this please.

Merged build triggered.

Merged build started.

Test build #32890 has started for   PR 6147 at commit f23ea77.

Test build #32890 timed out     for PR 6147 at commit f23ea77     after a configured wait of 150m.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32890/
Test FAILed.

test this please.

Merged build triggered.

Merged build started.

Test build #32922 has started for   PR 6147 at commit f23ea77.

Test build #32922 has finished for   PR 6147 at commit f23ea77.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SerializableAWSCredentials(accessKeyId: String, secretKey: String)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32922/
Test PASSed.

@tdas:  Looks like you forgot to bring over the docs/streaming-kinesis-integration.md and 2 examples (JavaKinesisWordCountASL and KinesisWordCountASL) changes from my original PR:  https://github.com/apache/spark/pull/5882/files
how do you suggest we proceed?  i believe the samples - if left unchanged - would use the old deprecated/experimental API.

Since this has passed, let me merge this. I will pull over the examples in another PR.


Remove permissions handling and put in control of user

https://github.com/1fabiopereira/react-native-pitch-detector/blob/127fb45dac647e7fe018f8be66b90e538141da71/src/internal/permissions/index.ts#L7
This stuff can all be handled externally and bloats the scope of the repo - are you happy for me to move this out?

@marksyzm No problem, you can remove them, just remember to update the doc if necessary, when you send the PR I will review it.

Is there still any plan to do this?  I'd like to use something other than the old version of react-native-permissions that is a dependency here.


Update Envoy upstream

Pulls in the fix from https://github.com/envoyproxy/envoy/pull/8467.
Signed-off-by: Michael Rebello<EMAIL_ADDRESS>

Looks like this resulted in a bit of a size increase. Since we need these fixes, I'm going to merge and defer investigating to https://github.com/lyft/envoy-mobile/issues/447


Analyze operation legacy request

Describe the feature:
When an analyze operation is performed, the request generated to ES contains the text to analyze as the body of the request and the rest of parameters in the query string. This is maintained by ES for backward compatibility and has limitations (text cannot start by '{') as described here: https://www.elastic.co/guide/en/elasticsearch/reference/2.3/indices-analyze.html. I have looked in your code base and seen this is done in: ElasticClient (https://github.com/elastic/elasticsearch-net/blob/2.x/src/Nest/Indices/Analyze/ElasticClient-Analyze.cs).
I would suggest to pass all the parameters in the body of the request as json as described in the above ES documentation link.

Thanks for opening this @macebalp; I agree that it would be better to use the json payload to call _analyze, since it handles starting { in the text.


Fix xUnit 2 warnings

Fixed 394 warnings
todo

[ ] BufferingTargetWrapperOverflowAction.cs from https://github.com/NLog/NLog/pull/2276

unfortunately no (large) improvement in build/test time :(


Extend TemplateMark to support admonitions

As discussed on the weekly tech WG calls on 2020-11-18 and 2020-11-25 - I have proposed an annotation feature that allows lawyers, parties and counterparties to easily include notes to themselves/each other in the template text.
This already exists in many common markdown extensions as 'admonitions' (also called call-outs) - which is generally rendered as a coloured block (sometimes with coloured headings). See here for examples.
To be decided:

what syntax we would adopt for this (eg three colons vs three exclamation points); and
whether inline admonitions are also required.

@jeromesimeon with all of the work done recently on extensions to TemplateMark, I thought I would re-agitate this issue. Can you put it on your list of possible extensions to see if there is any demand for it?

Hi @OliverTod,
thanks for the ping. I remember looking at possible extensions and I think this one should be relatively easy. What I’m not so clear about is the usecase for contracts / agreements.
would you have a few examples of usage that would help motivate this extension?
thanks!

Here is an example, taken from an agreement I am currently converting:

You can see that there are admonitions that will make their way into the final agreement and also 'notes' which are used for negotiation/development purposes.

Another example from the same agreement:

An example from a random Cloud SaaS provider:

Another random example, this time from Uber, of American drafting that uses ALL CAPS for emphasis (but which could be better done in an admonition):


Build failed due to use of deprecated Android v1 embedding.

After flutter run, Build failed due to use of deprecated Android v1 embedding.

new error


fix links on download page

And another fix @CyberShadow, @braddr.

Good to see the year-in-URL scheme go away.

Yeah, can you also look at #934.


llvm[openmp] build failure

Host Environment

OS: Windows
Compiler: MSVC 16.6.3

To Reproduce
Steps to reproduce the behavior:
./vcpkg install llvm[openmp]
Failure logs
>_ vcpkg install llvm[openmp]
Computing installation plan...
The following packages will be built and installed:
    llvm[clang,core,disable-abi-breaking-checks,disable-assertions,disable-clang-static-analyzer,enable-rtti,lld,openmp,tools]:x86-windows
Starting package 1/1: llvm:x86-windows
Building package llvm[clang,core,disable-abi-breaking-checks,disable-assertions,disable-clang-static-analyzer,enable-rtti,lld,openmp,tools]:x86-windows...
-- Note: llvm only supports static library linkage. Building static library.
-- Using cached D:/vcpkg/downloads/llvm-llvm-project-llvmorg-10.0.0.tar.gz
-- Extracting source D:/vcpkg/downloads/llvm-llvm-project-llvmorg-10.0.0.tar.gz
-- Applying patch 0001-allow-to-use-commas.patch
-- Applying patch 0002-fix-install-paths.patch
-- Applying patch 0003-fix-vs2019-v16.6.patch
-- Using source at D:/vcpkg/buildtrees/llvm/src/org-10.0.0-32c002c70c.clean
-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: ninja -v
    Working Directory: D:/vcpkg/buildtrees/llvm/x86-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      D:\vcpkg\buildtrees\llvm\config-x86-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
  ports/llvm/portfile.cmake:168 (vcpkg_configure_cmake)
  scripts/ports.cmake:76 (include)

Error: Building package llvm:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: llvm:x86-windows
  Vcpkg version: 2020.06.15-nohash

Additionally, attach any relevant sections from the log files above.

config-x86-windows-out.log
install-x86-windows-dbg-err.log

Confirmed, this issue could repro, check the history, that feature added by https://github.com/microsoft/vcpkg/pull/10295, and it  has never worked with feature.

Looks same issue with https://bugs.llvm.org/show_bug.cgi?id=40557#c2

Thanks very much. Does it mean we should wait for llvm team fixing CMake module files?

@PhoebeHui @tan-wei Let me check this issue. I think OpenMP doesn't support build without LLVM test tools (lit, FileCheck).

@yurybura, thank you as always!
After some investigation, found it requires feature 'utils', which setting 'LLVM_INCLUDE_UTILS' to 'ON', then it configured successfully.
However, it start to build failed with 'ninja: error: 'lib/libomp.dll.lib', needed by 'lib/libomp.libd', missing and no known rule to make it'


Something weird when debugging in a local container on macOS

Stumbled over a really strange initdb failure when debugging an issue:
$ /usr/local/bin/initdb --username="${POSTGRES_USER}" ${POSTGRES_INITDB_ARGS} ${PGDATA}/new/
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with this locale configuration:
  locale provider:   libc
[...]
creating configuration files ... ok
running bootstrap script ... 2024-10-09 02:29:08.221 UTC [661] FATAL:  data directory "/var/lib/postgresql/data/new" has wrong ownership
2024-10-09 02:29:08.221 UTC [661] HINT:  The server must be started by the user that owns the data directory.
child process exited with exit code 1

This error makes no sense:
FATAL:  data directory "/var/lib/postgresql/data/new" has wrong ownership
HINT:  The server must be started by the user that owns the data directory.

I'm the correct user (postgres):
$ id
uid=70(postgres) gid=70(postgres) groups=70(postgres),70(postgres)

And the new data directory is owned by this user:
$ pwd
/var/lib/postgresql/data
$ ls -la
total 4
drwx------    4 postgres postgres       128 Oct  9 02:15 .
drwxrwxrwt    1 postgres postgres      4096 Oct  9 01:49 ..
drwx------    2 postgres postgres        64 Oct  9 02:15 new
drwx------   25 postgres postgres       800 Oct  9 01:54 old
$ ls -la new/
total 0
drwx------    2 postgres postgres        64 Oct  9 02:33 .
drwx------    4 postgres postgres       128 Oct  9 02:33 ..

For reference, the exported environment is:
$ env | sort
CHARSET=UTF-8
COLLATE=unset
CTYPE=unset
ENCODING=UTF8
HOME=/var/lib/postgresql
LANG=C.UTF-8
LC_COLLATE=C
LOGNAME=postgres
MUSL_LOCPATH=/usr/share/i18n/locales/musl
OLDPATH=/usr/local-pg16
OLDPWD=/var/lib/postgresql
PAGER=less
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PGDATA=/var/lib/postgresql/data
PGTARGET=17
PGVER=16
PG_MAJOR=17
PG_VERSION=17.0
POSTGRES_DB=postgres
POSTGRES_INITDB_ARGS=--encoding=UTF8
POSTGRES_PASSWORD=password
POSTGRES_USER=postgres
PWD=/var/lib/postgresql/data
SHELL=/bin/sh
SHLVL=1
TERM=xterm
USER=postgres

Even deleting the "new" directory and letting initdb create the directory itself results in the same problem:
$ rmdir new
$ ls -la
total 4
drwx------    3 postgres postgres        96 Oct  9 02:34 .
drwxrwxrwt    1 postgres postgres      4096 Oct  9 01:49 ..
drwx------   25 postgres postgres       800 Oct  9 01:54 old
$ /usr/local/bin/initdb --username="${POSTGRES_USER}" ${POSTGRES_INITDB_ARGS} ${PGDATA}/new/
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with this locale configuration:
  locale provider:   libc
  LC_COLLATE:  C
  LC_CTYPE:    C.UTF-8
  LC_MESSAGES: C
  LC_MONETARY: C
  LC_NUMERIC:  C
  LC_TIME:     C
The default text search configuration will be set to "english".

Data page checksums are disabled.

creating directory /var/lib/postgresql/data/new ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default "max_connections" ... 100
selecting default "shared_buffers" ... 128MB
selecting default time zone ... UTC
creating configuration files ... ok
running bootstrap script ... 2024-10-09 02:37:53.803 UTC [801] FATAL:  data directory "/var/lib/postgresql/data/new" has wrong ownership
2024-10-09 02:37:53.803 UTC [801] HINT:  The server must be started by the user that owns the data directory.
child process exited with exit code 1
initdb: removing data directory "/var/lib/postgresql/data/new"

This is occurring on macOS in an ARM64 container based upon our 17-bookworm tag build:
$ uname -a
Linux 20f2bc871b87 6.10.4-linuxkit #1 SMP Mon Aug 12 08:47:01 UTC 2024 aarch64 Linux

Pretty sure it's something to do with the bind mount, as a workaround of using /tmp/new as the new data directory works fine:
$ /usr/local/bin/initdb --username="${POSTGRES_USER}" ${POSTGRES_INITDB_ARGS} /tmp/new/
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with this locale configuration:
  locale provider:   libc
  LC_COLLATE:  C
  LC_CTYPE:    C.UTF-8
  LC_MESSAGES: C
  LC_MONETARY: C
  LC_NUMERIC:  C
  LC_TIME:     C
The default text search configuration will be set to "english".

Data page checksums are disabled.

creating directory /tmp/new ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default "max_connections" ... 100
selecting default "shared_buffers" ... 128MB
selecting default time zone ... UTC
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok
syncing data to disk ... ok

initdb: warning: enabling "trust" authentication for local connections
initdb: hint: You can change this by editing pg_hba.conf or using the option -A, or --auth-local and --auth-host, the next time you run initdb.

Success. You can now start the database server using:

    /usr/local/bin/pg_ctl -D /tmp/new/ -l logfile start

20f2bc871b87:~/data$ mv /tmp/new .

I'll close this issue as I was more putting it here as reference in case others hit the same problem.
If this issue actually happens to people using our image, then we could probably change our initdb command to use the /tmp directory as I did above manually for the workaround.  In theory that shouldn't have follow on side effects from what I can tell. :smile:

As a data point, the pg_upgrade command in the same container exhibits the same problem:
$ /usr/local/bin/pg_upgrade --username="${POSTGRES_USER}" --link -d "${OLD}" -D "${NEW}" -b "${OLDPATH}/bin" -B /usr/local/bin --socketdir="/var/run/postgresql"
Performing Consistency Checks
-----------------------------
Checking cluster versions                                     ok

*failure*
Consult the last few lines of "/var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log" for
the probable cause of the failure.

connection to server on socket "/var/run/postgresql/.s.PGSQL.50432" failed: No such file or directory
	Is the server running locally and accepting connections on that socket?

could not connect to source postmaster started with the command:
"/usr/local-pg16/bin/pg_ctl" -w -l "/var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log" -D "/var/lib/postgresql/data/old" -o "-p 50432 -b  -c listen_addresses='' -c unix_socket_permissions=0700 -c unix_socket_directories='/var/run/postgresql'" start
Failure, exiting

The pg_upgrade_server.log file has this:
$ cat /var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log
-----------------------------------------------------------------
  pg_upgrade run on Wed Oct  9 02:51:51 2024
-----------------------------------------------------------------

command: "/usr/local-pg16/bin/pg_ctl" -w -l "/var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log" -D "/var/lib/postgresql/data/old" -o "-p 50432 -b  -c listen_addresses='' -c unix_socket_permissions=0700 -c unix_socket_directories='/var/run/postgresql'" start >> "/var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log" 2>&1
waiting for server to start....2024-10-09 02:51:51.413 UTC [1080] FATAL:  data directory "/var/lib/postgresql/data/old" has wrong ownership
2024-10-09 02:51:51.413 UTC [1080] HINT:  The server must be started by the user that owns the data directory.
 stopped waiting
pg_ctl: could not start server

The pg_ctl: could not start server line is particularly ironic, considering that pg_ctl itself when run using mostly default arguments starts it fine:
$ pg_ctl -D "${NEW}" -l logfile start
waiting for server to start.... done
server started
$ ps -ef
PID   USER     TIME  COMMAND
    1 postgres  0:00 bash /usr/local/bin/docker-entrypoint.sh postgres
   31 root      0:00 /bin/bash
   59 postgres  0:00 -sh
 1181 postgres  0:00 sleep 5
 1184 postgres  0:00 /usr/local/bin/postgres -D /var/lib/postgresql/data/new
 1185 postgres  0:00 postgres: checkpointer
 1186 postgres  0:00 postgres: background writer
 1188 postgres  0:00 postgres: walwriter
 1189 postgres  0:00 postgres: autovacuum launcher
 1190 postgres  0:00 postgres: logical replication launcher
 1191 postgres  0:00 ps -ef

In fact, launching PG using the arguments that pg_upgrade claims didn't work, does in fact work:
$ "/usr/local-pg16/bin/pg_ctl" -w -l "/var/lib/postgresql/data/new/pg_upgrade_output.d/20241009T025151.356/log/pg_upgrade_server.log" -D "/var/lib/postgresql/data/old" -o
 "-p 50432 -b  -c listen_addresses='' -c unix_socket_permissions=0700 -c unix_socket_directories='/var/run/postgresql'" start
waiting for server to start.... done
server started
20f2bc871b87:~/data$ ps -ef
PID   USER     TIME  COMMAND
    1 postgres  0:00 bash /usr/local/bin/docker-entrypoint.sh postgres
   31 root      0:00 /bin/bash
   59 postgres  0:00 -sh
 1208 postgres  0:00 /usr/local-pg16/bin/postgres -D /var/lib/postgresql/data/old -p 50432 -b -c listen_addresses= -c unix_socket_permissions=0700 -c unix_socket_directories=/var/run/postg
 1209 postgres  0:00 postgres: checkpointer
 1210 postgres  0:00 postgres: background writer
 1212 postgres  0:00 postgres: walwriter
 1213 postgres  0:00 postgres: logical replication launcher
 1215 postgres  0:00 sleep 5
 1216 postgres  0:00 ps -ef

So I have no idea what the heck is going wrong with it, but I'm not really interested in going down the rabbit hole of debugging this to completion at this stage.  More important stuff to focus on, so I'll probably just swap to doing this debugging in an x86_64 vm on Linux.

@justinclift
I have exact same issue, and there is another workaround, which is by adding
chown -R postgres "${OLD}" and chown -R postgres "${NEW}" right after mkdir "${OLD}" and mkdir "${NEW}"

Thanks @jasonkit.  Yeah, it's a weird behaviour that doesn't seem to make sense.  I kind of wonder if there's some weird corner case the arm architecture stuff is having happen in this instance.
Are you using Apple Silicon, or something else? :smile:

@justinclift

Are you using Apple Silicon

Yes, but this issue seems not related ARM architecture.
I guess this issue is caused by what described in https://github.com/docker/for-mac/issues/6734#issuecomment-1813380412
Indeed when I switch to use gRPC FUSE (You can set that in Docker Desktop's Setting > General > Choose file sharing implementation for your containers), the issue is gone.
This issue is also gone if we are doing volume mount instead of bind mount.
Seems using VirtioFS for bind mount having some race condition in setting uid and gid on the mounted folder/files...

Awesome, there are workarounds. :smile:
When I'm next trying this stuff I'll probably give those a try. :smile:


Bumped version to 0.11.2

Codecov Report

Merging #252 (2702eac) into main (eabde1d) will decrease coverage by 2.04%.
The diff coverage is 94.09%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   92.80%   90.75%   -2.05%
==========================================
  Files          33       34       +1
  Lines        5306     6067     +761
==========================================
+ Hits         4924     5506     +582
- Misses        382      561     +179

Flag
Coverage Δ

unittests
90.75% <94.09%> (-2.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

qoqo/src/circuit.rs
90.46% <ø> (ø)

qoqo/src/lib.rs
9.09% <0.00%> (-3.41%)
:arrow_down:

roqoqo/src/circuit.rs
81.51% <ø> (-0.39%)
:arrow_down:

roqoqo/src/lib.rs
4.47% <ø> (-65.80%)
:arrow_down:

...oqo/src/measurements/basis_rotation_measurement.rs
97.94% <ø> (-0.70%)
:arrow_down:

...measurements/cheated_basis_rotation_measurement.rs
96.72% <ø> (-1.67%)
:arrow_down:

roqoqo/src/measurements/cheated_measurement.rs
98.14% <ø> (-0.94%)
:arrow_down:

...src/measurements/classical_register_measurement.rs
93.10% <ø> (-3.57%)
:arrow_down:

...c/measurements/measurement_auxiliary_data_input.rs
97.08% <ø> (-2.22%)
:arrow_down:

roqoqo/src/operations/define_operations.rs
90.00% <ø> (-10.00%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f34a4...2702eac. Read the comment docs.


Nesting the Tooltip inside the MenuItem prevents the tooltip from appearing.
<DropdownMenu
  menuItems={(close) => [
    <MenuItem onClick={onClickHandler}>
      <Tooltip content="content"> // will not appear
          Item title
    </Tooltip>
  // ...

Inserting a  between the Tooltip and MenuItem allows both the tooltip to appear and the menu item to handle its click, but it is not easy to find this solution.
<Tooltip content="content">

    <MenuItem onClick={onClickHandler}>Item title</MenuItem>

</Tooltip>

Expected Behavior
Wrapping a Tooltip around a MenuItem should show a tooltip on hover and not block the menu item click.
Link to minimal repro
https://stackblitz.com/edit/github-lx2rzk
Steps To Reproduce
Wrap a tooltip around a menu item in a dropdown menu.
Anything else?
@itwin/itwinui-react v3.5.0

Thanks for reporting this.
Of all the cases you mentioned, these two are totally invalid and should not be used:
<Tooltip>Text</Tooltip> // ❌

<Tooltip>
  … // ❌
</Tooltip>

(See docs for supported child elements)
The main issue about MenuItem is still valid and should be fixed:
<Tooltip>
  <MenuItem>…</MenuItem>
</Tooltip>

However, for better UX, consider using a sublabel instead of tooltip.

That's a great point about the sublabel, thanks! I'll see if it makes sense in our context.

@HaveSpacesuit I spent some more time looking into it, and realized that you just need to pass a value to MenuItem make onClick work.
This is because:

Tooltip (via floating-ui) merges event handlers and tries to check for certain properties of the event object.
Menuitem invokes onClick with the value passed to it.

The combination of the two fails if you don't pass value.

See full corrected code
<DropdownMenu
  menuItems={(close) => [
    <Tooltip content='Action 1' placement='right' key={1}>
      <MenuItem
        startIcon={<Svg2D />}
        onClick={() => {
          close();
          alert('Action 1');
        }}
        value={1}
      >
        Run 2D
      </MenuItem>
    </Tooltip>,
    <Tooltip content='Action 2' placement='right' key={2}>
      <MenuItem
        startIcon={<Svg3D />}
        onClick={() => {
          close();
          alert('Action 2');
        }}
        value={2}
      >
        Run 3D
      </MenuItem>
    </Tooltip>,
  ]}
>
  <IconButton aria-label='More options'>
    <SvgMore />
  </IconButton>
</DropdownMenu>

Hope that helps! And of course, sublabel will still work better than tooltips, so try using that if possible.

Oh, that's weird. Thanks for the explanation. I ended up going with the sublabels 🙂 but it's good to know this work around if I need it.


Proposal: Move @vue/* Packages to devDependencies

Summary
This PR proposes moving the vue language core package from dependencies to devDependencies in the package.json. The main motivation for this change is to address issues with libraries that encounter conflicts due to peer dependencies when using vite-plugin-dts. One such example is prettier-plugin-tailwind, which breaks in certain scenarios.
Background
Currently, the Vue core language packages are listed under dependencies, which means they are included in the production bundle. However, it seems that these packages are only necessary during the development phase (e.g., compiling .vue files). Moving them to devDependencies might reduce unnecessary dependencies in production builds and resolve conflicts with other tools.
Motivation
I've encountered issues when using vite-plugin-dts in combination with some libraries that rely on peer dependencies. One notable example is prettier-plugin-tailwind, which breaks due to conflicting peer dependencies when Vue language packages are installed globally as part of dependencies. By moving these packages to devDependencies, this issue can potentially be mitigated.
However, I must mention that I am not fully familiar with the project architecture and its use cases. While I believe this change could resolve some dependency conflicts, I can't confidently say whether moving it to devDependencies would introduce other unforeseen issues in the production environment. There might be cases where these packages are required at runtime, which I'm unaware of.
I would appreciate feedback from the maintainers or anyone more knowledgeable about the project. If this change is not feasible or introduces new problems, I'd be happy to collaborate on finding alternative solutions to the dependency conflict.
Please let me know if there are additional tests I should run or if there is something I am overlooking that might break with this change.
Thank you for your time and consideration!

This plugin depends @vue/language-core when emitting declaration files, but not when building itself. So it's necessary to include this package in the production bundle. or it will crash those vue project.
I will consider to list the @vue/language-core and @microsoft/api-extractor under the peer depandencies in the next major version (because this causes breaking change for users).

This plugin depends @vue/language-core when emitting declaration files, but not when building itself. So it's necessary to include this package in the production bundle. or it will crash those vue project.
I will consider to list the @vue/language-core and @microsoft/api-extractor under the peer depandencies in the next major version (because this causes breaking change for users).

Perfect! Thanks for your reply


Add teritori asset on Osmosis frontend

declare chain info
declare ibc asset
declare pool:utori

Signed-off-by: dpierret<EMAIL_ADDRESS>

looks good to me

LGTM, ready to be merged.


Adding fixes to solve warning messages

After recompiling on Lassen, I didn't get the same warning messages as before. However, I still kept the same fixes and things will compile with no warnings/errors. For the record, the error we got before was:
`/g/g0/belcher6/Umpire/src/umpire/resource/MemoryResourceTypes.hpp(46): warning: missing return statement at end of non-void function "umpire::resource::resource_to_string"
/g/g0/belcher6/Umpire/src/umpire/resource/MemoryResourceTypes.hpp(57): warning: missing return statement at end of non-void function "umpire::resource::string_to_resource"`
So we added an "Unknown" Resource Type to return if the end of the function was reached. This should solve the problem that came up before.

LGTM

LGTM


Exception thrown in sample full_screen_exclusive

When running the sample full_screen_exclusive, I get an exception: read access violation.
In FullScreenExclusive::prepare, window->create_surface is called, with window being nullptr.
Produced on Win10 with NVIDIA GPU.

Same here. the window is null for me too. I did approve the sample and I'm 100% sure it worked back then.
Maybe broken due to #716. @tomadamatkinson can you take a look?


Enable Page Caching

Enables page caching for

/
/how
/info

using actionpack-page_caching. Pages are cached to /public, where they are then served statically by Rails (though this could be changed in the future, using a frontend server like Apache/Ngnix to serve /public).
Testing is added to confirm that pages actually cache.

This isn't going to be the way we solve this in the end; more stuff required to do caching. Closing PR for now, will make a new one when this branch is ready.


Pickadate 3.5.6 (directive doesn't work with editable=true)

The directive seems to be not working with Pickadate.js 3.5.6
See sample:
http://plnkr.co/edit/7j2j09

same here

Thanks for reporting ! I'll try to fix.

I've upgraded the demo directory to latest versions for each dependencies, and I can't reproduce the issue from the plnkr. Any idea ? Please try using the demo from this project.
https://rawgit.com/Toilal/ng-pickadate/master/demo/index.html

I can reproduce only when some options are given...

The issue is related to editable option. This option is quite unclear for me, but removing this option makes the plnkr work.

It's a threading issue in pickadate.js project. https://github.com/amsul/pickadate.js/issues/542


Remove inputs for disk cache in bazel

[x] Forked repo is synced with upstream -> github shows no code delta outside of the desired.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
[x] Tests are passing? https://github.com/microsoft/DeepGNN/blob/main/CONTRIBUTING.md#run-tests
[x] PR is labeled using the label menu on the right side.

Previous Behavior
Inputs parameter is still passed to github actions, but it is never used.
New Behavior
Removed: inputs variable and pip cache. Single pip cache item was > 1Gb.
Updated python actions versions.


Use non-www to the codegen website

The GraphQL Code Generator hyperlink seems to be broken. The actual link that is working is: https://the-guild.dev/graphql/codegen

Thanks! We also added a redirect, so it should work as-is. But yeah, we prefer non-www links.


Documentation inconsistency regarding programming model

According to https://cloud.spring.io/spring-cloud-static/spring-cloud-stream/current/reference/html/spring-cloud-stream.html#_annotation_based_support_legacy and the javadoc of @StreamListener the annotation-based configuration is deprecated and will be removed in the future.
However, according to https://cloud.spring.io/spring-cloud-static/spring-cloud-stream-binder-kafka/current/reference/html/spring-cloud-stream-binder-kafka.html#_imperative_programming_model the functional programming model is merely the preferred approach and the @StreamListener-based approach is still a valid alternative.

The documentation may have changed since this issue was open, but I don't see any mention of deprecating the annotation method. The docs currently read: For compliance with legacy style applications we still support this annotation-based programming model
It still might be good for some clarity about longer term plans. If annotation-based was due for deprecation then is there any  rough timescale?

@andrashatvani sorry just found the deprecation notice https://github.com/spring-cloud/spring-cloud-stream/blob/master/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/annotation/StreamListener.java#L30-L31
NOTE: It is no longer recommended to use StreamListener in favor of functional programming model.
 * It will be deprecated and subsequently removed in the future.

So I agree. Would be good to have the documentation consistent on the planned deprecation.


[release-1.1] Admit eviction on completed virt-launcher pods

This is a manual cherry-pick of https://github.com/kubevirt/kubevirt/pull/12451
Release note

Fix: eviction requests to completed virt-launcher pods cannot trigger a live migration

/hold
release 1.3 (https://github.com/kubevirt/kubevirt/pull/12495) and release 1.2 (https://github.com/kubevirt/kubevirt/pull/12496) first.
/cc @orelmisan @davidvossel

/unhold

/approve

Looks like you're also backporting 0827137 (#11532)
Is there any chance you could make that backport explicit? (i.e. cherry-pick that commit first and amend the PR description).
Thanks

Looks like you're also backporting 0827137 (#11532) Is there any chance you could make that backport explicit? (i.e. cherry-pick that commit first and amend the PR description). Thanks

Right! I thought I was picking just a little part of the PR, but didn't realize that was an entire commit.
Adjusted. Thank you!

/retest
@jean-edouard can you have a second look? Thanks

/retest


fixes this code that broke in 0.8.15 and works now

plus with additional outline in the file pane

Awesome! Thank you very much :smile:

i can add some more from the forums i didn't get them are you looking for a comprehensive list here @kmaasrud ?

i can add some more from the forums i didn't get them are you looking for a comprehensive list here @kmaasrud ?

Add as much content as you want @tallguyjenks , I'm glad to have help in adding content!


Need maximum/minimum date range prop

Right now, there is no way (that I can discern) to pass in a prop that will create a maximum date that is allowable for the datepicker. For example, a user can make the date 2000003 and the results will simply be NaN within the UI calendar. Would be great to get a prop that lets us set a maximum or minimum date rate rage, a la the HTML max/min attribute for date input type.

You could write a disable function in your data that limits the maximum date. Something like:
<datepicker :disabledDates="disabledFn"></datepicker>

//////////////////////////////////////////////////////////////////////////////////////////

  data() {
    return {
      disabledFn: {
        customPredictor(date) {
          if (date.getFullYear >= 2100) {
            return true; // returns true if disabled
          }
        }
      }

There are a few options for this sort of thing, but the function option should give you enough flexibility to do what ever you want. Check out charlie's example:
https://codesandbox.io/s/mpklq49wp


identity-appsupport: Add QR code generation and scanning composables.

This adds Compose Multiplatform support for QR code generation and scanning.
A future change will start using this in the wallet app, currently it's only used in samples/testapp.
This adds dependencies on https://github.com/alexzhirkevich/qrose and https://github.com/kalinjul/EasyQRScan which are under the MIT and Apache 2.0 license, respectively. These depencies are wholly hidden behind the ScanQrCodeDialog and ShowQrCodeDialog in case we want to swap these out in the future. For example, for the scanning part we likely want to just use MLKit directly.
Test: New screens in samples/testapp for testing. Tested on Android and iOS.

Screenshot:


[FEATURE] Get rid of the dependency on OpenSearch core

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
Get rid of the dependency on OpenSearch core. Introducing new OpenSearchTransport based on Apache HttpClient 5, with no dependencies on OpenSearch's core RestClient.
Issues Resolved
PoC for https://github.com/opensearch-project/opensearch-java/issues/262
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock @dlvenable the PoC for getting rid of the dependency on OpenSearch core, basically more or less the amount of code we would need to copy / paste from core (I think I could reduce it a bit but that would not be a game changer there). It should help us to assess the go / no-go decision.

I love it. It's a lot smaller than I thought it would be and it's mostly boilerplate (+ tests?).

Sure, a few sketches need to make it compete and testable (just wanted to hear your opinion first), I'll wrap it up shortly.

@dblock @VachaShah got stuck on this one https://github.com/opensearch-project/opensearch-java/issues/47 :(

@dblock @andrross @VachaShah I think the POC is ready

This is real progress!
What's the path to delete https://github.com/opensearch-project/opensearch-java/blob/f1fbe833d7cd925018b7ed3f9cd1c0684e25b993/java-client/build.gradle.kts#LL149C5-L149?

Thanks @dblock ! This is what we have discussed here [1], basically easy steps:

for 3.0.0, make RestClient optional (as the dependency)
recommend to use Apache HttpClient 5 based transport instead

[1] https://github.com/opensearch-project/OpenSearch/issues/5424#issuecomment-1334412578

This is real progress!
What's the path to delete https://github.com/opensearch-project/opensearch-java/blob/f1fbe833d7cd925018b7ed3f9cd1c0684e25b993/java-client/build.gradle.kts#LL149C5-L149?

Thanks @dblock ! This is what we have discussed here [1], basically easy steps:
* for 3.0.0, make RestClient optional (as the dependency)

* recommend to use Apache HttpClient 5 based transport instead

[1] opensearch-project/OpenSearch#5424 (comment)

I may be confused, but that's the plan for removing the legacy rest client from OpenSearch right? Why can't we remove the dependency on OpenSearch from opensearch-java right now?

This is real progress!
What's the path to delete https://github.com/opensearch-project/opensearch-java/blob/f1fbe833d7cd925018b7ed3f9cd1c0684e25b993/java-client/build.gradle.kts#LL149C5-L149?

Thanks @dblock ! This is what we have discussed here [1], basically easy steps:
* for 3.0.0, make RestClient optional (as the dependency)

* recommend to use Apache HttpClient 5 based transport instead

[1] opensearch-project/OpenSearch#5424 (comment)

I may be confused, but that's the plan for removing the legacy rest client from OpenSearch right? Why can't we remove the dependency on OpenSearch from opensearch-java right now?

That would be hard breaking change: since we never deprecated RestClientTransport, just removing it without any notice is probably not a good idea. We at least could start with deprecating RestClientTransport, and removing in the next version, I think that would be less impactful.

That would be hard breaking change: since we never deprecated RestClientTransport, just removing it without any notice is probably not a good idea. We at least could start with deprecating RestClientTransport, and removing in the next version, I think that would be less impactful.

Sorry, I'm only now learning exactly how this client works, so please bear with me! In order to use the client from opensearch-java, a user must construct a transport like the following:
Transport transport = new RestClientTransport(restClient, new JacksonJsonpMapper());
OpenSearchClient client = new OpenSearchClient(transport);

That example uses RestClientTransport, which itself uses the (low-level) RestClient from OpenSearch core. This PR introduces ApacheHttpClient5Transport which can be used in place of RestClientTransport. However, all users of opensearch-java will have to change how they instantiate their client, so we can't remove RestClientTransport without breaking things. Is all that correct?

However, all users of opensearch-java will have to change how they instantiate their client, so we can't remove RestClientTransport without breaking things. Is all that correct?

Precisely, thanks @andrross !

I think "Get rid of the dependency on OpenSearch core" is probably a misnomer for this change. Maybe something like "Add OpenSearchTransport implementation based on Apache HttpClient 5" instead? Until we can remove RestClientTransport I don't think we're getting rid of the dependency.
Also, can we recommend this new approach in the user guide now?

I think "Get rid of the dependency on OpenSearch core" is probably a misnomer for this change. Maybe something like "Add OpenSearchTransport implementation based on Apache HttpClient 5" instead? Until we can remove RestClientTransport I don't think we're getting rid of the dependency.
Also, can we recommend this new approach in the user guide now?

Yeah, the title stems from feature / POC work :D (we didn't know ahead of time if it is going to be successful or not), I will update the comment and title, @dblock no objections? Thanks @andrross !

Thanks for this work @reta !
In regards to releasing, you added these new features, but did not remove any old features. I agree with this approach to provide a clean migration for users.
With that, should we have this be a new 2.x release instead of 3.0?

Thanks @dlvenable !

With that, should we have this be a new 2.x release instead of 3.0?

I think for 2.x we could do same thing using Apache HttpClient 4.x (which is what 2.x is using). The reasoning behind that - no new dependencies are going to be introduced but the new transport only. What do you think?

Thanks @dlvenable !

With that, should we have this be a new 2.x release instead of 3.0?

I think for 2.x we could do same thing using Apache HttpClient 4.x (which is what 2.x is using). The reasoning behind that - no new dependencies are going to be introduced but the new transport only. What do you think?

Is it possible to do this in a way where the public-facing part of the API doesn't have to change when the underlying Apache HttpClient changes? i.e. call the public API ApacheHttpClientTransport That way users don't have to change their code when the dependency is updated.

Thanks @reta @andrross and @dlvenable! Let's talk about what we want to merge. I think we should

Make this PR as "added OpenSearchTransport", document how to use it
In a separate PR, "deprecate RestClientTransport (and possibly other classes)", and mark the deprecated classes as such, document the recommended way to use the client
Backport 1) and 2) to 2.x, continue a 2.x line of releases.
In 3.0/main delete the deprecated code.

Is it possible to do this in a way where the public-facing part of the API doesn't have to change when the underlying Apache HttpClient changes? i.e. call the public API ApacheHttpClientTransport That way users don't have to change their code when the dependency is updated.

This is not really possible, the Apache HttpClient 4 and Apache HttpClient 5 are very different: we could hide some (like fe HttpHost) but everything from credentials to TLS configuration does require package change. However, if we do ApacheHttpClient4Transport in 2.x, we could keep it in 3.x as well - zero change for users.

Is it possible to do this in a way where the public-facing part of the API doesn't have to change when the underlying Apache HttpClient changes? i.e. call the public API ApacheHttpClientTransport That way users don't have to change their code when the dependency is updated.

This is not really possible, the Apache HttpClient 4 and Apache HttpClient 5 are very different: we could hide some (like fe HttpHost) but everything from credentials to TLS configuration does require package change. However, if we do ApacheHttpClient4Transport in 2.x, we could keep it in 3.x as well - zero change for users.

Makes sense. I'm slowly getting up to speed here :) So HttpClient 4 and 5 are actually distinct packages that can exists side-by-side (org.apache.httpcomponents.httpclient vs org.apache.httpcomponents.client5.httpclient5). Is that right? Assuming that's true, why is it a breaking change to add the new HttpClient 5 dependency in 2.x?

 Makes sense. I'm slowly getting up to speed here :) So HttpClient 4 and 5 are actually distinct packages that can exists side-by-side (org.apache.httpcomponents.httpclient vs org.apache.httpcomponents.client5.httpclient5). Is that right?

That's right.

Assuming that's true, why is it a breaking change to add the new HttpClient 5 dependency in 2.x?

This is true. There are no concerns regarding breaking change, my concern is "new dependencies are going to be introduced", it may be very surprising to see that within minor version update (may be I am overly cautious).

Assuming that's true, why is it a breaking change to add the new HttpClient 5 dependency in 2.x?

This is true. There are no concerns regarding breaking change, my concern is "new dependencies are going to be introduced", it may be very surprising to see that within minor version update (may be I am overly cautious).

The tl;dr is that this PR will add a new dependency (Apache HttpClient 5) and create a new ApacheHttpClient5Transport class that will be the new recommended approach for creating a client, as opposed to the existing RestClientTransport that depends on OpenSearch core. The specific question is whether adding the HttpClient5 dependency should be considered a breaking change, or can it be added in the next minor release on 2.x? @wbeckler @dlvenable @dblock What do you think?

Assuming that's true, why is it a breaking change to add the new HttpClient 5 dependency in 2.x?

This is true. There are no concerns regarding breaking change, my concern is "new dependencies are going to be introduced", it may be very surprising to see that within minor version update (may be I am overly cautious).

The tl;dr is that this PR will add a new dependency (Apache HttpClient 5) and create a new ApacheHttpClient5Transport class that will be the new recommended approach for creating a client, as opposed to the existing RestClientTransport that depends on OpenSearch core. The specific question is whether adding the HttpClient5 dependency should be considered a breaking change, or can it be added in the next minor release on 2.x? @wbeckler @dlvenable @dblock What do you think?

Please note that right now Apache HttpClient 5 comes with OpenSearch core 3.0.0, nothing is added to opensearch-java (as you can see, the build dependencies have not changed in this pull request).

@reta , I did not actually see a dependency change in this PR (no modification to the build file). It seems that we are pulling in Apache HTTP Client 5 via a transitive dependency.
We may want to explicitly add this dependency now that the project itself depends on it.

Thanks @reta, this looks good to me!
I believe the remaining open question is whether to backport this to 2.x (with a slight change to explicitly declare the HttpClient5 dependencies) or instead introduce an ApacheHttpClient4Transport. In either case this change will be needed on main.

Is this dependency already in the 2.x line? If so, we are not adding a new dependency. If not, we can make this optional at runtime to address the concern of adding new dependencies. End users would need to add it to their build files to use the transport.

The specific question is whether adding the HttpClient5 dependency should be considered a breaking change, or can it be added in the next minor release on 2.x?

In my opinion, this is not breaking since it is compatible with HttpClient4. If we really want, it is possible to make this an optional dependency on 2.x using feature variants. End users would have to add this dependency or get a runtime error.

@dlvenable We are getting HttpClient5 on the main branch via a transitive dependency. For the 2.x branch it would have to be added a new dependency.

I merged it. @reta backport or not?

I merged it. @reta backport or not?

Let me try to do this on Monday (the automatic one won't work, we need explicit dependencies), thanks @dblock !


Automatic PDF Title with JS Variables

Hi!
It would be nice to have automatic PDF title during creation, using JS Variables. Something like Nunjucks, Moment.js etc.

I don't understand what you mean. In the case you want to create embeds with names, you use the commands Handwritten Notes: Create and embed from favorite template or Handwritten Notes: Create and embed and open from favorite template, they automatically create a hw note with the parent note name + the timestamp.

Thank you! I didn't saw that first time  I tried yours plugin, now it becomes important part of my workflow. I hope you are doing well, cheers and once again thank you for your time and work. :)


MultiLine Property

Looks like "MultiLine" property doesn't work with all Krypton controls.

Or maybe im doing something wrong?

From the screenshot I read a "short text" proprerty, maybe there's a "long
text" too?
Il giorno ven 3 mar 2017 alle 06:09 holgworknote<EMAIL_ADDRESS>ha scritto:

Looks like "MultiLine" property doesn't work with all Krypton controls.
[image: scr]
https://cloud.githubusercontent.com/assets/20695413/23538945/dc848c02-fff0-11e6-8739-55e63ac02025.PNG
Or maybe im doing something wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ComponentFactory/Krypton/issues/27, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AA5eLMkShfG7Smmm_QdPPdY2fxNoNAScks5rh6B6gaJpZM4MR3r8
.

With "long text"  MultiLine property doesn't work too.

The KryptonLabel control does not support wrapping. Use KryptonWrapLabel instead.
From the documentation (emphasis mine):

KryptonWrapLabel
Use the KryptonWrapLabel control when you need to functionality of the standard Windows.Forms.Label control but with the text color and font of the Krypton palette system. Unlike the KryptonLabel control this KryptonWrapLabel control inherits directly from the standard Windows.Forms.Label class and so it performs the same automatic wrapping of text onto multiple lines. This is the one circumstance for which this control is recommended instead of the KryptonLabel control. If you need text to span multiple lines then this is the control to use.

Okay, but how can I make multiline header description?

If you're talking about the Description field of a KryptonHeader control, you shouldn't have to change anything in the state settings. It will automatically support a multi-line value and should size itself correctly.

If you want to specify a multi-line value using the designer, click the drop-down button next to the value, which provides a multi-line text editor.

Otherwise you can just specify a line break in code, e.g.
kryptonHeader1.ValuesPrimary.Description = "Description\nLine 2"

Thx, thats what i mean!


HTTP 500 Error after Login

Hi,
I was able to work with Cachet, then reset cache and worked on the Dashboard and now I'm having HTTP 500 after Login.
Here is the Error Log, how can I recreate the cache table? Thanks
Next exception 'Illuminate\Database\QueryException' with message 'SQLSTATE[42S02]: Base table or view not found: 1146 Table 'cachet.cache' doesn't exist (SQL: select * from cache where key = laravel7ec732b12835315c2bd06d42db0f0f83b06bce18:lockout limit 1)' in C:\Bitnami\wampstack-5.6.22-0\apache2\Cachet-2.2.4\vendor\laravel\framework\src\Illuminate\Database\Connection.php:713

Wrong project. Not using Docker Sorry


Add surforama as reader for .obj files

Opening stuff from the CLI is fine, but if I already have a napari window open with surforama installed, and try to open an .obj file, it complains there's no plugin to read it:
NoAvailableReaderError: No plugin found capable of reading /scicore/home/engel0006/diogori/BZ_Napari_2024/membranorama/T17S1C3M4.obj

Done in #18


Retrieve Saved Profiles

It seems that the official app can sync profile data (e.g. retrieve the stored macros, layout, and backlight information).
This should be done automatically, but currently this is a low priority.

I do not have the time to add new features to the app.


fixed string operation, added small bits of coverage

Coverage increased (+0.43%) to 82.1% when pulling 47900a19a6cc383d97219edb8f501a8cdc093ec3 on more_coverage into c1b3a89b5963c2308ba7cd4a7750c69665a8638f on master.

Coverage increased (+0.43%) to 82.1% when pulling 47900a19a6cc383d97219edb8f501a8cdc093ec3 on more_coverage into c1b3a89b5963c2308ba7cd4a7750c69665a8638f on master.

Changes Unknown when pulling 4d56b166ae9834bb7254099bfc6e7188f8ce3910 on more_coverage into ** on master**.

Changes Unknown when pulling 4d56b166ae9834bb7254099bfc6e7188f8ce3910 on more_coverage into ** on master**.


fixed variable in loop

This change is already on main (must've been another commit): https://github.com/Planning-Inspectorate/infrastructure-environments/blob/main/app/stacks/uk-west/appeals-service/app-service-config.tf#L11


"Better user experience" than what?

An adjective was used in comparative form without an antecedent, and, thus, the sentence was not inherently clear.

I signed the CLA

Thanks @morrissinger - I added one more word and merged.

Landed as https://github.com/angular/angular.js/commit/9278ae67c6f8195042b673d397554af3ba6d461f - sorry put the wrong "Closes" issue number in the commit.


polymodulus, bitsize, bitsizes

I am using the security level SecurityLevel.tc128 and want to use polyModulusDegree=1024
what combinations of bitSizes [-,-,-] can i have and what should be the bitsize?

This is a very low polyModDegree, as such you will not be able to have more than 1 bit size specified for the coeffModulus.
If you’re using BFV scheme, you could use The seal.CoeffModulus.BFVDefault function To generate these value(s).
You can also use morfix.io/sandbox to also rapidly test different parameters.