Huge memory is used when using skywalking-agent.

I'm confused by this case, little requests, but huge memory is used when using skywalking-agent.
Does skywalking-agent trace the motanStatsLog? Do lots of work to record info about motanStatsLog into ringbuffer?

Does skywalking-agent trace the motanStatsLog?

I don't remember we did that. You can read the motan plugin codes, it is very simple. We just use motan header to propagation across processes, that is all.

Its code is simple. I noticed skywalking using bytebuddy to do bytecode injection. Does bytebuddy used huge memroy? It seems doesn't use memory of xmx, xms.
If I change jdk1.8 to jdk1.7, the memory delta added will become much less.

Does bytebuddy used huge memroy?

No, it will not. Byte Buddy is stable libs. Of course, code manipulation has risk. The cost should be perm size or meta space in different JDK.

One possible reason is are you using some dynamic class mechanism? Or motan using?
I have known, some debug tool could trigger this issue, such as Spring dev tool.

I used gperftools to have a analysis like this:
first is using skywalking-agent:

second is not using skywalking-agent:

Tomorrow I will try btrace to print stack to have a look.

It Seems these had memory leak below:

Try to do the thread dump to find out who makes the leak.

I will keep this open with no milestone. Let's see what is going on.

memory malloc is huge.

Could you take a look, which objects cause the leak?

From I known, we didn't.
@raphw Do you know anything in byte-buddy could trigger this?

If I can have a heap dump, I can have a look. Potentially, some class loader does not clean up its resources when Byte Buddy requests class files.

Are these the reasons as below? It seems very similar as what I met.
https://dzone.com/articles/native-memory-leak-example
https://docs.oracle.com/javase/8/docs/api/java/lang/instrument/ClassFileTransformer.html#transform-java.lang.ClassLoader-java.lang.String-java.lang.Class-java.security.ProtectionDomain-byte:A-

@hepyu Could you upload a dump file here? @raphw is the byte-buddy author, he knows much more things about class loaders and byte codes than me.

How I provided the dump file? email or something else?

@raphw Do you have any prefer place to go?

@raphw @wu-sheng here is dump file that only dump live objects.
https://github.com/hepyu/tech-docs/blob/master/skywalking/heap-dump-live-lbs-6G-DisableExplicitGC-JDK1.8.bin
Do you need all objects dumped file? its large, 1.7G, I just try upload to git now.

@raphw The dump file that contains all object is too large, much more than up limitation of git. Could you please provide email or some other way if you need to analysis.
I just remove sensitive codes from project, later will upload to git to help to locate problem.

I just remove sensitive codes from project, later will upload to git to help to locate problem.

I think demo codes and a guide to reproduce the error should be helpful.

@wu-sheng @raphw the example project is : https://github.com/hepyu/bird
the method to start is:

Its just start com-bird-lbs-service only, with javaagent skywalking-agent, its enough to check over.
@raphw I'm so sorry, because china network fire wall, its so slow to upload file to dropbox even I used vpn, I has tried twice, all failed. May I transfer the dump file directly to your gmail?

That is hard to say. If they load too many classes in dynamic, Byte Buddy will make the situation worse.
@raphw do you have time to check the dump?

@wu-sheng
We checked motan code again, its only support jdk dynamic way, like this:

I attend a tech-meeting yesterday, have a deep communication with JiaQi Lin that from dangdang, your friend. I noticed that dangdang used skywalking so deeply.
So I still want to find a low coost way to solve this problem to use skywalking-agent.
So we checked the dubbo code, dubbo both support javassist and jdk dynamic load.
If we draw lessons from dubbo to implement a javassit for motan , is it a efficiency way? Because we could use dubbo code about javassist.
what do you think?
I really want to have some advices from you, thanks a lot.

Glad to hear you have a good chat.  Dangdang and its arch team support our project from a long time ago.
From what you have found, could you consider to upgrade jre for your application? I assume that is the safest and easiest way, unless @raphw found the root cause.
Do javaassist stuffs should help, what I am not sure how the motan team think about this.

I have planned to look into it this evening.

I have planned to look into it this evening.

Thanks. @raphw

@wu-sheng
Upgrade jre version maybe not appropriate, because we have used JDK8, the thing happen. When degrade to JDK7, it works much better. Upgrade jre to more higher version is not in our plan, just be cautious.
In order to avoid the useless work, we of course will have a try using dubbo that running in the javassist model to validate the key.
About motan team thing, We checked their issue and code, although they didn't provide other way except jdk dynamic implement, but they provide spi mechanism to support other proxy mechanism implements.
referer:
https://github.com/weibocom/motan/issues/612
https://github.com/weibocom/motan/blob/092aabca33108cbe6970776dd506b44681ae8e32/motan-core/src/main/java/com/weibo/api/motan/proxy/spi/JdkProxyFactory.java

how about trying to upgrade the minor version? just for test.

@raphw I have processed, please receive again.3Q a lot.

how about trying to upgrade the minor version? just for test.

Yeah, you are right, I'll try!

@hepyu Could you invite me to the repository again? I misclicked.

There are two service, lbs-service is motan-rpc-provider, and lbs-web is motan-rpc-consumer.
The bad thing only occur in the lbs-web.
Because motan-provider only use static proxy, it works much better, memory only added 100M~200M if xmx=xms=6000M, using JDK8.

@raphw please git pull again, there exists some error about shell start scripts.
like this:

this url could used to validate:
http://your-lbs-web-ip:9082/lbs/currentLocation/55
and result like this:

in start shell, only default jvm param, if replay the scene，should use large xmx and xms, I used this:
-XX:MetaspaceSize=256m -XX:MaxMetaspaceSize=256m -Xms6000M -Xmx6000M
JDK8 of course.
If memory is not enough, I advice that use default jvm mem param for lbs-service starting, and large mem jvm param for  lbs-web starting.

I thought you had a dump in the repo. Do I need to run the app? Preferably, I would just look at the dump. You can mail me at rafael(dot)wth(at)gmail.com if that is easier.

@raphw
I think that it seems need to run app. Because dump is so small. I doubt the native mem leak.
@wu-sheng
upgrade minor version to the latest version: 1.8.0_181-b13, the problem is still exist. I will try JDK9 and JDK10 tomorrow.

@wu-sheng
I discussed with the author of motan. It seems the  most likely reason, coincide with gperftools analysis result.
https://github.com/weibocom/motan/issues/756

@rayzhang0603  Glad to see you join the discussion.

@raphw Thanks for the analysis.
For exclusion namespaces, I definitely could choose some. Stage monitor's settings help.

It is important for performance and for reducing memory consumption, to cache type descriptions by defining a custom type strategy that applies some caching.

Could you point out how to define a custom type strategy? I am not sure

@raphw Also, what is this ignore for? https://github.com/stagemonitor/stagemonitor/blob/6804a0fe506c3f7fd210f8c05332d9648fbf3fce/stagemonitor-core/src/main/java/org/stagemonitor/core/instrument/AgentAttacher.java#L238

I set the agent in this way first. https://github.com/apache/incubator-skywalking/commit/433cf3a8fdebbcdbc4a6a4c0316c22c49b814933
@hepyu Could you try cherry-pick to your branch to give a try?

@raphw 3Q a lot ~
@wu-sheng 3Q a lot either, I will try!

@wu-sheng
We had tried skywalking-3.2.6 in dubbo-2.5.3, its phenomenon most likely motan with skywalking-3.2.6.
But considered with dangdang using scale about skywalking, deep performance test, and deep investigation about skywalking&motan&dubbo.
We had decided that still to use skywalking-3.2.6 as trace facilities.
About extra overhead memory cost, even to 3.2.6, performance test and underlying implementation has proved that its just acceptable and almost constant, just increase acceptable mem to fix it. We really don't want to invade into the code level even if one letter.
Especially dangdang scale practice give us much more confidence, they had proved the stability and usability in the product env about scale.

@hepyu Choose any version you like, that is totally your choice.:)  Just we still could work on your scenario to avoid too many memory costs.

@hepyu Choose any version you like, that is totally your choice.:) Just we still could work on your scenario to avoid too many memory costs.

Of course, the latest master code has been deployed on our test env, we hope to keep watching the newest progress of skywalking, we are very interested in the lots of practical features.

Of course, the latest master code has been deployed on our test env, we hope to keep watching the newest progress of skywalking, we are very interested in the lots of practical features.

Good to know. the latest master code is the latest 5.x codes? Do you cherry-pick my PR to your running codes? That PR is still open, in another branch.

Good to know. the latest master code is the latest 5.x codes? Do you cherry-pick my PR to your running codes? That PR is still open, in another branch.

Yes, 5.x. I noticed that master now is 6.x, I had not upgrade.
I just did a base benchmark about delta mem cost using bird project in different jdk version, from jdk8(contains two minor versions) to jdk10.
https://github.com/hepyu/tech-docs/blob/master/skywalking/skywalking-3.2.6-with-jdkversion-mem-cost-base-referer.doc

I set the agent in this way first. #1682
@hepyu Could you try cherry-pick to your branch to give a try?

How could I use this pr? Did it has pushed the master?
Should I use like this:
I git pull the latest master and compile, then use the skywalking-agent.jar?

@hepyu Which company are you at now?

Coohua company.

I set the agent in this way first. #1682
@hepyu Could you try cherry-pick to your branch to give a try?

How could I use this pr? Did it have pushed the master?
Should I use like this? If not right, then how, I just work first like this way.....
I git pull the latest master and compile, then use the skywalking-agent.jar?

Is this branch?

@wu-sheng I meant binary locator, not type locator. It is really mostly about avoiding IO as it generates a bunch of garbage, especially on older VMs. The ignore matcher you refer to is exluding any type that is loaded by a class loader that fulfills a certain condition. Excluding by class loader is done before even looking at the type, therefore such exclusing is very effective. If a class loader is known to not generate any types of interest, this is a good exclusion. It will not alter the result but lead to higher performance. Especially Groovy is problematic here as it needs to generate a lot of boring filler byte code to implement its dynamic features.

the result with skywalking-agent-6.0.0-alpha-adjust-agent-setting.

jdk version is:

It seems the method to validate is not correct. I read the response from @raphw again, considered with the opportunity of actual "leak".
In my understanding, Its not the real leak as generally speaking. Its occur just because huge native call when transform jar files from local disc, and remaining os mem is not enough to continue before app recycled them.
It seems the correct method contains two dimensions.

Replay the actual scenes(weibocom/motan#756) with using skywalking-agent 3.2.6 and 6.0.0-alpha-adjust-agent-setting. If it is not killed when using skywalking-6.0.0-alpha, it will be proved worked.
"weibocom/motan#756" in english, its main idea is that when jvm heap and remaining os mem is small, the os/kubernetes will kill the "jvm instance"/"docker instance".

2.In the machine that owns enough mem to run gperftools to analysis the result again, compare with below:

If the key of result below is much less than above, it will be proved worked.
like Java_java_util_zip_xxx

Am I right about above two dimensions to validate? @raphw @wu-sheng .

 Usually validate method is invalid in my understanding.
Is my uderstanding correct?

Yeah, the gperftools result seems validate my first dimension point.
jvm version:

the result of gperftools with skywalking-agent-6.0.0-alpha:

the result of gperftools with skywalking-agent-3.2.6:

It seems the key is Java_java_util_zip_Inflater_init.
The premise of two test is the same:
export LD_PRELOAD=/app/3rd/gperftools/lib/libtcmalloc.so
export HEAP_PROFILE_TIME_INTERVAL=10
And print heap per 10 seconds, and fetch eleventh heap as above.

Do the new codes work or not? Can you make yourself more clear? Look like it works.

Do the new codes work or not? Can you make yourself more clear? Look like it works.

I mean the new codes won't reaction to java heap.
And new codes works according to the gperftools analysis.
I will test it on the k8s&docker env to replay the original scene.

I mean the new codes won't react to java heap.

Yes, that is sure. I am thinking about clearing type pool through some timeout mechanism.

I mean the new codes won't react to java heap.

Yes, that is sure. I am thinking about clearing type pool through some timeout mechanism.

I have some question, if type is not used, just not used, why do some timeout mechanism?

I have some question, if type is not used, then not used. why do some timeout mechanism?

I mean type pool in byte-buddy. @felixbarny suggests me to do so. Just same as @raphw mentioned, binary locator, https://github.com/stagemonitor/stagemonitor/blob/6804a0fe506c3f7fd210f8c05332d9648fbf3fce/stagemonitor-core/src/main/java/org/stagemonitor/core/instrument/AutoEvictingCachingBinaryLocator.java#L34

I have some question, if type is not used, then not used. why do some timeout mechanism?

I mean type pool in byte-buddy. @felixbarny suggests me to do so. Just same as @raphw mentioned, binary locator, https://github.com/stagemonitor/stagemonitor/blob/6804a0fe506c3f7fd210f8c05332d9648fbf3fce/stagemonitor-core/src/main/java/org/stagemonitor/core/instrument/AutoEvictingCachingBinaryLocator.java#L34

Got it, 3Q a lot, I will learn it ~~

First, The new codes worked, improved a lot.
The evidence：
Java_java_util_zip_Inflater_init from gperftools decreased from
"0.6   0.6%  99.9%     47.9  52.3% Java_java_util_zip_Inflater_init"
to
"0.0   0.0%  99.9%      2.0   1.8% Java_java_util_zip_Inflater_init"
The change above means many irrelevant class is ignored.
The columns desc:

I had backup the gperftoos, in order to check after.
https://github.com/hepyu/tech-docs/tree/master/skywalking/issue-1666
Second, I tried to restore failed scene in our k8s env, failed. Because we had upgraded the resources. This problem ought to occur in some extreme case: when io, mem resources arrived at some critical point.

I intend to use it to reduce the perm size after most code weaver works done.
Yeah, this is very useful !  I love it~

GA will be the codes you have tested. The timeout needs more tests than ignore.
Do you have any solution about your k8s env? I am sure what happens there. If ignore works, should not cause too many memory costs.

Do you have any solution about your k8s env? I am sure what happens there. If ignore works, should not cause too many memory costs.

Do you want me to have a test in the k8s env?If agent-3.2.6 fail, and agent-6.0.0 success, then validate ok.Is this mean?
If it is, I had done these things, but couldn't restore, becuase we have upgraded the k8s env, from one machine to two machine, even restore to the same resource, both agent-3.2.6 and agent-6.0.0 are ok, none will be failed.
like this as I wrote:

@wu-sheng
I mean its cost is too expensive, about k8s and docker, we are just try to use, they are only used in the test env. Just have a try, we are not very familiar with them, I just learn to use them.
And all test app are deployed in the k8s, if I restore to the original crime scene, it will cost too time. Because the k8s are used and dockers are deployed every day, its hard to restore to original scene.
And another reason is that it will have a big influence to our business development progress, and cost several colleague time, at least one day.The worst is that maybe still have no chance to restore it.
Because I guess:
This problem ought to occur in some extreme case: when io, mem resources arrived at some critical point.
It becomes much more difficult to restore it.
And in the other word, In china, especially for not big startup company, its so expensive.
Especially we almost confirm where it is and delta resources are limited in a constant range.
So I think we could confirm effect with gperftools analysis result instead.I think this is the efficiency way to solve the problem.

If the current code version works, that is good. I am ok if you are inconvenient. I think we have some conclusions already.
The ignore is definitely good. Right? If all test cases are passed in our env, I will merge the PR and cherry pick it to 5.x. 5.0.0 GA will release next week.

In an occasional cause, we found the reason why jvm instance in k8s would be crashed.
Because the resource of k8s cluster in our dev/test env is so few especially the cpu resources, then processing speed of jvm instance would be substantially reduced.
Eventually lead to data were piled up in the memory, then crashed. Old version of skywalking accelerated this process.


Property changed notification documentation

Hi. I've found in the documentation that a propertyName-changed event should be fired for properties with notify: true. However it seems that a property-name-changed event is fired instead

From the docs: In order to configure camel-case properties of elements using attributes, dash- case should be used in the attribute name.. I assume we mean this should also be applied to change event names as well, but could be more explicit about it.

@ tpluscode Thanks for highlighting the inconsistency.
@arthurevans Can we make

When a property is set to notify: true, an event, propertyName-changed, is fired whenever the property value changes.

read

When a property is set to notify: true, an event, property-name-changed, is fired whenever the property value changes.

instead?

+1 saw it but was too lazy to PR'ed... :)

Ah, sure. Can you clarify what property-name-changed means, though?
Are we saying that the event takes the dash-case version of the name? Or that the literal name is added?

I think we are talking about the dashed case version of the name!

This issue was moved to Polymer/docs#1437


refactor!: Provider dependencies standartization

Context
As per this conversation, we need a refactoring action to standardize the Provider dependencies in order to enhance the DbSyncProvider parameters to provide it a logger and finally adding the same log line described in the same conversation.
Proposed Solution
Important Changes Introduced

restructure Asset directory to be aligned with all other providers
standardize DbSyncProvider dependencies, create interface DbSynProviderDependencies
add debug log on DbSyncProvider health check
align all provider dependencies structure

BREAKING CHANGE:

all provider constructors are updated to use a standardized form of deps

Rebased with master and commits are squashed.

What is meant here by "to be reconsidered"?

They should not be nested under a db-sync scope as they can be used in other contexts. For now you could just leave these interfaces where they were, and only move the db-sync models into the new directory.

What is meant here by "to be reconsidered"?

They should not be nested under a db-sync scope as they can be used in other contexts. For now you could just leave these interfaces where they were, and only move the db-sync models into the new directory.

Aham, both interfaces are not coupled with db-sync at all, only the actual implementations could be, like DbSyncNftMetadataService.
So I'll move both types out of Asset/DbSyncAssetProvider, good catch!

Commits are squashed and ready for merge once the CI pass.


Fixed #33781 -- Restored alignment for admin split-field timezone war…

…nings.
Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
Refs ticket-33750 and ticket-27207.
A slightly more specific selector to remove the unwanted margin/padding, and restore the font-weight.
Before f3e2bb0833105f43efc0cc6f19c8465bc1b1a785:

With this adjustment:

Thanks @felixxm 👍


Create Image Output

Produce images from the text. Might be useful for creating heat maps. Visualizing might be fun to do.
For rendering images:

node canvas: https://github.com/Automattic/node-canvas

Things to try:

Render image with text.

Render in "page" somehow.

Render a different color for each punctuation. This would be a step toward creating heat maps.

I'm considering using - https://github.com/devongovett/pdfkit


add postgresql questions

Summary of changes
I have added two postgresql questions and successfully tested them with the documentation links locally.
One question was about the syntax for deleting a database and the other was about the default port number.
Checklist

[x] I have read and followed the contribution guidelines.
[x] I have read through the Code of Conduct and agree to abide by the rules.
[ ] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[x] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[x] I have provided a summary of my changes.

closes #XXXXX

Hi, thank you for your quick response. I have committed the change as requested.
Almost had a perfect contribution 😅


panic: Header called after Handler finished

**server code**

	service := micro.NewService(
		micro.Name(configure.SERVER_NAME),
		micro.Version("latest"),
		micro.Address(configure.HOST),
		//micro.WrapHandler(AuthWrapper),
	)
	service.Init()
	protos.RegisterSendMessageServiceHandler(service.Server(), handle.NewService())
	protos.RegisterAuthHandler(service.Server(), handle.NewAuthService())

	if err := service.Run(); err != nil {
		log.Fatal(err)
	}

**question descirbe**
it can run in go client, but when i change python or php as client,   server will be shuttle down, but all processes have been implemented,   and no response has been received.

**serve run info**
$ go run message_server.go --registry=consul
2019/09/10 15:28:32 Transport [http] Listening on <IP_ADDRESS>:8881
2019/09/10 15:28:32 Broker [http] Connected to [::]:50335
2019/09/10 15:28:32 Registry [consul] Registering node: srv.wechat.message-f9e6a                                                                                937-04f3-46f0-921f-94ed3acc9efc

**error**
panic: Header called after Handler finished

goroutine 14 [running]:
golang.org/x/net/http2.(*responseWriter).Header(0xc000006008, 0xc00029afc0)
<EMAIL_ADDRESS>                                                                                server.go:2564 +0xa0
github.com/micro/go-micro/transport.(*httpTransportSocket).Send(0xc0001321e0, 0x                                                                                c000004920, 0x0, 0x0)
<EMAIL_ADDRESS>                                                                                go:297 +0x509
github.com/micro/go-micro/server.(*rpcServer).ServeConn.func2(0xc00002c4a0, 0xc0                                                                                00100f60, 0x11e9ce0, 0xc0001321e0, 0x0, 0x0, 0xc00028c080)
        D:/go/pkg/mod/github.com/micro/go-micro@v1.9.1/server/rpc_server.go:153                                                                                +0xb6
created by github.com/micro/go-micro/server.(*rpcServer).ServeConn
        D:/go/pkg/mod/github.com/micro/go-micro@v1.9.1/server/rpc_server.go:138                                                                                +0x538
exit status 2

I'm not sure you should be registering two different handlers in one service. I'm not exactly sure what the behaviour is like when you do that. In practice, your service should be simple and be doing only one thing hence it should have only one handler.

This is unrelated to having two handlers registered in one service. You can register as many as you want.
The issue was that in the http2 request path we can write the response after the handler has exited. I've now added a read lock in the server transport that should prevent the socket from being closed before the data has been written.

Cool. Like I said I was not sure. Good to hear you found what the problem was.
Can you link the PR to this issue, so it's closed automatically once the bug fix is merged in?

Fix https://github.com/micro/go-micro/commit/6ec32805d013ec219796b2c5c25186372b0b20c1


Add a thread cache for the GC's ExtentMap lookups

It sounds like we are using a lookup to save a lookup which seems self defeating, however, we expect:

The hit rate to be very high, as each entry maps 1GB of RAM.
The thread cache to be hot - or at least in need to become so anyways, so we potentially save one miss.
We can save TLB entries for the application.
We won't run into false sharing when the heap grows.

The cache could be added there and passed down to any other function that would require it.
The behavior can be similar to jemalloc's rtree tsd:
https://github.com/jemalloc/jemalloc/blob/d577e9b5880906dbd4ab04fb61de5650170ac08b/include/jemalloc/internal/rtree_tsd.h#L4
https://github.com/jemalloc/jemalloc/blob/d577e9b5880906dbd4ab04fb61de5650170ac08b/src/rtree.c#L205-L231

The trie: https://github.com/snazzy-d/sdc/blob/master/sdlib/d/gc/emap.d

We want the new cache to be added in https://github.com/snazzy-d/sdc/blob/master/sdlib/d/gc/tcache.d

Done in 08f0f113


Changes to References in Demo section

What does this PR do?
This PR changes the way the references looked and interacted in the Demo section of the Timewarp site.
Fixes #61

Changes made

Enhanced reference formatting to resemble clickable links for better user recognition.

Implemented a hover effect that changes the reference color to blue, providing visual feedback on interaction.

Introduced icons to visually categorize references based on their field, improving information organization and scannability.

Thank you very much for the opportunity to contribute into the repository. Really excited to be in the open source community.


Delegate Rendering of Separator and Value to Renderer

Description
This PR refactors the rendering logic by delegating the responsibility of rendering separators and values from individual items to the MenuRenderer. The changes include:

Moving the render logic from each item to the MenuRenderer. Allowing the MenuRenderer to decide how to render the value, enabling customization of the separator.
This refactor enhances the flexibility and maintainability of the rendering process by centralizing the rendering logic within the MenuRenderer.

Changes

Updated MenuRenderer to handle the rendering of separators and values.
Removed rendering logic from individual items.
Also adjusted the way view works in ItemInput, now when backspaces is pressed while the view is scrolled, it moves the characters to the right immediately until view is zero, this fixes the situation in previous releases where when I start deleting the characters and I reach the colon, I can't see the next character I am deleting.

Screenshots/Video (if applicable)

Checklist
General Requirements

[x] I have kept this PR in draft until all the required tasks are completed.
[ ] I have reviewed the contributing guidelines for this project.
[ ] I have tagged this PR with breaking-change if it introduces a breaking change.
[ ] I have checked that this PR does not introduce any breaking changes unless explicitly stated.
[ ] I have checked that changes generate no new warnings.
[ ] I have performed a self-review of my own code
[ ] I have built and tested ALL the examples to ensure that I haven't broken anything.

Refactor/Enhancement

[x] This PR is a code refactor.
[x] I have tagged this PR with enhancement.
[x] I have made changes to the code that improve readability/performance/maintainability.
[ ] I have added documentation for the changes if necessary.
[ ] I have generated and reviewed the documentation locally if necessary.

Moving the render logic from each item to the MenuRenderer. Allowing the MenuRenderer to decide how to render the value, enabling customization of the separator.

Think it's a bad idea.. MenuRenderer shouldn't decide how to render value, item should. I am trying to add change when item has multiple widgets and draw them. Now all responsibility goes to renderer, it's not right I think. In version 4 we moved logic from menu into items, now it moved from items but into renderer.

Moving the render logic from each item to the MenuRenderer. Allowing the MenuRenderer to decide how to render the value, enabling customization of the separator.

Think it's a bad idea.. MenuRenderer shouldn't decide how to render value, item should. I am trying to add change when item has multiple widgets and draw them. Now all responsibility goes to renderer, it's not right I think. In version 4 we moved logic from menu into items, now it moved back from items but into renderer.

Delegating rendering to the MenuRenderer separates the concerns of data representation and rendering. Items focus on their data and behavior, while the renderer handles how they are displayed.
The new menu controls that you're add would still work, all you would need to do is to pass thetext and the value which can be a concatenated string eg.
text = "Time"
value = "00:00:00"

text = "Distance"
value = "100 km"

This will get rendered appropriately like Time:00:00:00 or Distance:100 km, the item doesn't need to decide how the text and the value should be rendered, it should just provide the value in the way it should be rendered and the renderer renders it. In summary the logic of concatenated the Controls still remains in the item, you will only have to play with the blinker position.

What if I have small screen and I want to render
Time:00:00 on normal mode and
e:00:00:00 on edit mode?
Your implementation of Renderer knows about concept of text, value, separator and holds code how to render it.
Why not just allow items to hold that concepts and know how to render them? Just pass to item a display where to render, start point and end point.

What if I have small screen and I want to render Time:00:00 on normal mode and e:00:00:00 on edit mode? Your implementation of Renderer knows about concept of text, value, separator and holds code how to render it. Why not just allow items to hold that concepts and know how to render them? Just pass to item a display where to render, start point and end point.

I am planning to open a new PR which will handle horizontal scrolling of the items so, it's still a WIP, so the issue of no small display will be effectively gone (Hopefully 😃)
And I I guess your example here is already the case for ItemInput, item input currently modifies how it is rendered by just passing the value as the text currently in view (you implemented that and nothing has changed there, it's still possible to render only what is visible)

Check this out https://github.com/ShishkinDmitriy/LcdMenu/blob/feature/add-multidimentional-items/src/BaseItemManyWidgets.h#L50

Here's a video of the WIP
https://github.com/user-attachments/assets/304cbe20-b7f3-4bd9-8cc4-e43f53453ae0

Looks great! How it works with Rotary? It has no LEFT and Right commands.

Looks great! How it works with Rotary? It has no LEFT and Right commands.

I you have only a RotaryEncoder, you're out of luck 😃, you can't shift it by command, I am thinking of adding like a timed shift (but not in the same WIP), that someone can enable to automatically h-scroll items when they are in focus like an animation.
If items have the possibility to shift the view programatically (for display purposes) then all the cases I see in your WIP can be handled eg when using only a rotary encoder and I type a char I can decide to shift the whole view instead of just the view the value occupies.

I did this way:
https://github.com/user-attachments/assets/9fc41c95-cfe1-4e20-a278-ea2cc82dc12a
Item has 3 slots, every time you ENTER control move to next, and draw method tries to draw it up to blinker. After ENTER on last widget, it release. So item controls what to show, also we can combine and allow LEFT and RIGHT, but if no such commands, blinker should control view

I did this way:
Recording.2024-10-08.121622.mp4
Right now keep text maybe not a good idea, maybe show value would be better.
Item has 3 slots, every time you ENTER control move to next, and draw method tries to draw it up to blinker. After ENTER on last widget, it release. So item controls what to show, also we can combine and allow LEFT and RIGHT, but if no such commands, blinker should control view.

Looks really nice! Can't wait for that PR to be ready, will be a huge improvement.
I see it integrating well with my changes as the renderer provides the possibility to move the cursor and start/stop blinker, this would be implemented like you did in input item, you'll just need to play with the cursor position, calculate the available view space and then adjust the value to display before sending to the renderer, just like how iteminput currently does to shift texts when typing.
I see you wrote a lot of code (well commented 💪), and you unfortunately need to refactor a lot 😬 sorry!


github: workflows: Refactor upstream build workflow

This updates the manifest in the upstream build workflow before setting up the Zephyr project. This way the manifest is correct from the very beginning, speeding up the setup process. The manifest is also updated using a YAML processor, which is more robust.

[...] speeding up the setup process

Just curiosity, why it is faster?

For reference, yq is installed by default on Ubuntu and MacOS Github images. However, I believe it is not available on Windows.


level 100 displayed as 00

At homepage, when finished level 100, it displays that the last level is 00 (and next one is 101)
See screenshot

Changed the level indicator to 4 digits, so this will work correctly until stage 9999.
If you ever reach that level, you definitely have too much time.


Add dance till your death by phtheven hocking

Song Name
dance till your death
Artist Name
phtheven hocking
Source
Youtube
Youtube Link
wkPKR-BHVi9_xs8W
Direct File Link
No response
Song ID
1
Extra
Created from Auto Nong.
Created for level: 114082

''accept''

reject


clstm.i and clstm.h are not in sync

clstm_wrap.cpp:11671:21: error: ‘struct ocropus::INetwork’ has no member named ‘d_inputs’
   if (arg1) (arg1)->d_inputs = *arg2;
                     ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_inputs_get(PyObject*, PyObject*)’:
clstm_wrap.cpp:11705:35: error: ‘struct ocropus::INetwork’ has no member named ‘d_inputs’
   result = (Sequence *)& ((arg1)->d_inputs);
                                   ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_outputs_set(PyObject*, PyObject*)’:
clstm_wrap.cpp:11823:21: error: ‘struct ocropus::INetwork’ has no member named ‘d_outputs’
   if (arg1) (arg1)->d_outputs = *arg2;
                     ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_outputs_get(PyObject*, PyObject*)’:
clstm_wrap.cpp:11857:35: error: ‘struct ocropus::INetwork’ has no member named ‘d_outputs’
   result = (Sequence *)& ((arg1)->d_outputs);
                                   ^
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_inputs_set(PyObject*, PyObject*)’:
clstm_wrap.cpp:11671:21: error: ‘struct ocropus::INetwork’ has no member named ‘d_inputs’
   if (arg1) (arg1)->d_inputs = *arg2;
                     ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_inputs_get(PyObject*, PyObject*)’:
clstm_wrap.cpp:11705:35: error: ‘struct ocropus::INetwork’ has no member named ‘d_inputs’
   result = (Sequence *)& ((arg1)->d_inputs);
                                   ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_outputs_set(PyObject*, PyObject*)’:
clstm_wrap.cpp:11823:21: error: ‘struct ocropus::INetwork’ has no member named ‘d_outputs’
   if (arg1) (arg1)->d_outputs = *arg2;
                     ^
clstm_wrap.cpp: In function ‘PyObject* _wrap_INetwork_d_outputs_get(PyObject*, PyObject*)’:
clstm_wrap.cpp:11857:35: error: ‘struct ocropus::INetwork’ has no member named ‘d_outputs’
   result = (Sequence *)& ((arg1)->d_outputs);
                                   ^

This also means clstmimg.cc is not used at all.
https://github.com/tmbdev/clstm/search?utf8=✓&q=d_inputs

The Python wrapper can be built after deleting the d_inputs and d_outputs fields from INetwork in clstm.i. Then in IPython, running net.backward() outputs Kernel died, restarting.

Adding d_inputs and d_outputs to the INetwork in both clstm.h and clstm.i still has the same problem.

Yes, I'm in the middle of developing. I will try and tag a reasonable and working version later.

The tag is the same version that caused the above errors. The backward method can't run.
net.backward()

Kernel died, restarting

Let me see whether I can track down an older working version and set up the branches so that that becomes the default branch.

The Python swig code has been updated; there is a small test case (test-lstm.py) now.
There is also a separate branch now for the old version with separate derivatives.


BibConvert: modify oaiharvest xsl template

Adjusts the template to new CERN report numbering schema.

Signed-off-by: Sebastian Witowski<EMAIL_ADDRESS>

Hi,
I have been updating the XSLT used in arxiv harvesting on CDS (since the departments have changed) and I'm not sure if this is very useful for Invenio in general (since those fields are quite CERN-specific). In case we shouldn't update this XSLT with CERN-related transformations, please close this PR.
The corresponding PR for CDS is here [https://github.com/CERNDocumentServer/invenio/pull/171]

Thanks, amended commit log and merged as 9b537ede9aa05670a3f8b3170c3b11216f8dbe21.


Add some examples of normalization using tactics

In particular norm [UnfoldOnly ...] was unused in the examples.
@mtzguido could you take a look at this example?

Thanks for the example Tej, I'm adding some comment inline.


Emmet: Wrap with abbreviation doesnt work when abbr contains {}

VSCode Version: 1.21
OS Version: Any

Steps to Reproduce:
Use ul>li{hello} to wrap some text using the Emmet: Wrap with Abbreviation command
Expected:

    		helloHello world

Actual:

    		Hello world

This gets worse during live preview that's available in the Insiders.
By the time {he is typed, the text is wrapped inside <he>Hello world</he>
Also try ul>li{hello}+li.bye

Upstream issue: https://github.com/emmetio/expand-abbreviation/issues/20

Also, abbreviation cannot be expanded with TAB if it contains {} or [], only with enter

@vedranjaic Please provide an example

Ahh sorry, it is actually a problem with the way or the order of typing, for example:
I would usually move my cursor throughout the abbreviation to edit something
And then putting the cursor back at the end of the line (either by pressing "Home" or "Cmd+ArrowRight" or clicking the mouse at the end)
And then pressing Tab to expand the abbreviation, but this way I get the usual "Tab" space instead of the expanding.
I have to delete what ever the last character is and re-type it... Because this way you jump-start the Emmet recommendation tooltip and the ability to expand the abbreviation either by "Tab" or "Enter"

@vedranjaic If you want emmet expansion to be triggered on tab in the absence of the suggestion widget, see https://code.visualstudio.com/docs/editor/emmet#_using-tab-for-emmet-expansions

@ramya-rao-a working, thanks!

\closedWith dc5a3da

\closedWith dc5a3da


Connecting to the blockchain from the web application

Sample Javascript code
eos = Eos.Localnet();
eos.getBlock(3).then(result => {console.log(result)});

Error :
api error => http://<IP_ADDRESS>:8888/v1/chain/get_block {"block_num_or_id":3} TypeError: NetworkError when attempting to fetch resource. eos.js:23186:7
fetchMethod/</< http://localhost:5000/js/EOS/eos.js:23186:7
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://<IP_ADDRESS>:8888/v1/chain/get_code. (Reason: CORS header ‘Access-Control-Allow-Origin’ does not match ‘true’).

You probably need to add <IP_ADDRESS> to access-control-allow-origin in your config.ini.

@regularjack i have tried it and i am still getting the same error.

What's the exact configuration line you added to your config.ini?

@nsjames please find the below.
The local IP and port to listen for incoming http connections. (eosio::http_plugin)
http-server-address = <IP_ADDRESS>:8888
Specify the Access-Control-Allow-Origin to be returned on each request. (eosio::http_plugin)
access-control-allow-origin = true
Specify the Access-Control-Allow-Headers to be returned on each request. (eosio::http_plugin)
access-control-allow-headers = true
Specify if Access-Control-Allow-Credentials: true should be returned on each request. (eosio::http_plugin)
access-control-allow-credentials = false
and thank you for your youtube videos, it really helped me alot to get started

try access-control-allow-origin = *

Great! Close it up ;)

Im having this same issue, which config.ini did you change?

@tcpaul the one in
Mac OS: ~/Library/Application Support/eosio/nodeos/config
Linux: ~/.local/share/eosio/nodeos/config

access-control-allow-origin = *
why <IP_ADDRESS> do not work?
it is not safe enough in product environment to enable all source, is there any better way?

+1 @gpmn

I don't think <IP_ADDRESS> is only a loopback so it'll be exposed to the general network and might be dangerous if users have keosd open on it. localhost can also be spoofed to be externally connectable, so if security is a concern it's always best to use the manually defined <IP_ADDRESS> loopback.


Poor plot updating performance

Update the function draw_plot() in legoReactory.py to be much faster and more efficient. See matplotlib_animation.

Helpful links:

Embeded matplotlib animation in wxpython window
Matplotlib animation api


Create a new marshal through the factory and remove generics on the marshal

lgtm

@AlecStrong quick update here and then 0.4.2?

sounds good


Registering a CWL results in a weird error message

I got this error message:
" Fields that are missing from file: [] "
When I registered a tool based on this CWL:
https://github.com/ICGC-TCGA-PanCancer/OxoG-Dockstore-Tools/blob/896c090590443379bd2184344835ef505b23f8d7/clean_vcf.cwl
This happened in the staging environment.

@jpatricia

I could not reproduce the issue, as the file itself is not missing anything, but there was a problem with refreshing the page as the file is being copied and edited to a new Tool. After refreshing the tool and the page, the warning is gone, and it was not supposed to be there from the beginning since the file is correct.

Just saw this again "Fields that are missing from file: []"
Also, grammar, should be something like "Warning: there are fields missing from the descriptor: [cwlVersion]"

This looks completely fixed as of 1.1


Fix issue of adopted resource for both DBClusterParameterGroup and DBSubnetGroup

Issue #, if available:
https://github.com/aws-controllers-k8s/community/issues/1389
Description of changes:
Fix issue of adopted resource for both DBClusterParameterGroup and DBSubnetGroup

for DBClusterParameterGroup, it's due to the rename issue that DBParameterGroupFamily need be called Family and DBClusterParameterGroupName need be called Name
for DBSubnetGroup, synced with @RedbackThomson , it's due to rds output status of DBSubnetGroup doesn't have SubnetIDs, and it only has Subnets. SubnetIdentifier, so we need to use hook to append each of them.

With these above fixed, adopted resource should work for all available RDS CRDs now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/lgtm


Providing Authorization Control for a Business Configuration Maintenance Object

Tutorials: https://developers.sap.com/tutorials/abap-environment-authorization-control.html
The Step 3 of this tutorial talks about a configuration to be done in Workzone. It actually is done within the Fiori Launchpad of the SAP ABAP Runtime Environment where the objects are being created.
The role mentioned SAP_BR_ADMINISTRATOR - Administrator is also part of this environment.

My understanding is that SAP Build Work Zone, standard edition is the new name of SAP Launchpad in BTP
https://community.sap.com/t5/technology-blogs-by-sap/sap-launchpad-service-is-now-sap-build-work-zone-standard-edition/ba-p/13569593
Please note: SAP Launchpad service has been rebranded to ´SAP Build Work Zone, standard edition´


winget installer

can you add a function to install winget with the winget script you show in one of your videos if winget isn't installed this gonna make it easy for anybody to start using your utility as easy as possible
thanks for your work !

Hi @YusufKhalifa1 the winutil already makes a check in the system to see if winget is installed and if not make the installation process, what we can do is change the process and instead of just installing winget, also update the Desktop App Installer to make sure that is in the latest version.
You can check the function in the script in the following link
https://github.com/ChrisTitusTech/winutil/blob/main/winutil.ps1#L171

Hi @dennyamarojr installing winget on systems that doesn't have msstore justike windows enterprise, the script I mean here is the script that was mentioned in one of his articles here:
https://christitus.com/installing-appx-without-msstore/
I hope you understand

I completely understand and did you check the reference in the script I post a time ago?

In the image you can see that the verification already checks if the winget is present and if is too old, and make the use of the winget-install.ps1 script that @ChrisTitusTech show in the video.
Maybe needs to change the code to just verify if winget is installed and the if not installed run the command including
Set-PSRepository -Name 'PSGallery' -InstallationPolicy Trusted
Install-Script -Name winget-install -Force
which is not been used, just winget-install.ps1 and is not using the above command.

Just updated the standalone winget installer and working on implementing this into the script original issue is #347
Closing this.


Expose IResizeLayer in dynamo.conversion.impl

torch.ops.aten.resize.default is doing something like resizing the data's memory instead of what we expect for resize a image.
For resizing an input from [4, 4] to [2, 2]:
        [ 0.6648, -0.2868,  1.6206, -1.5967],
        [-0.0517, -0.3060,  0.2485, -0.2226],
        [ 0.9132,  0.2043,  0.5740,  0.4163]])]
trt:  [tensor([[-0.0766,  0.0715],
        [ 0.9132,  0.4163]], device='cuda:0')]
torch:  [tensor([[-0.0766,  0.3599],
        [-0.7820,  0.0715]])]

Similarly, if we resize an input from [4, 4] to [8, 8], we have:
          0.0000e+00,  0.0000e+00,  0.0000e+00],

for filling output.
TensorRT's IResizeLayer is more likely to be torch.nn.functional.interpolate, which emphasize more on interpolating.

PR linked : https://github.com/pytorch/TensorRT/pull/2488


Fix unitary synthesis for parameterized basis gates in Target

Unitary synthesis with parameterized basis gates in a target fails. This PR provides a fix.
Replace parameterized RXX with RXX(pi / 2) and parameterized RZX with RZX(pi / 4).
Closes #10082
EDIT
Explanation
Say you have a Target with RXXGate(theta) as the only entangling gate (theta is a Parameter).  When transpiling at opt level 3, an uncaught TypeError exception occurs in the try block here.
https://github.com/Qiskit/qiskit-terra/blob/e924ea9f6bae15bc67b704ebcdacda194480603e/qiskit/transpiler/passes/synthesis/unitary_synthesis.py#L709-L715
because it's not possible to convert RXXGate(theta) to a matrix of floats (it occurs when Operator tries to convert theta to a float). That's where the error is thrown, because it's the first place that the assumption that the gate is "concrete" is tested. But this assumption is necessary at many subsequent points in the flow. Apparently the 2q decomposers are unable to choose values for theta, so modifying the code to allow sending the gate as-is is not an option. So we need to choose some values. The values I chose here are copied from those chosen in qiskit 0.23. It seems reasonable to restore the behavior of 0.23 before considering whether to improve on it.
It looks like the latest point at which we can do the conversion (if we want to do it only once per call to _decomposer_2q_from_basis_gates) is when constructing available_2q_basis, which is what I've done here. This is inefficient because this is done every time a unitary in the circuit is converted, rather than once before converting all unitaries. I think quite a bit of computation could be lifted from _decomposer_2q_from_basis_gates out of the loop over circuit elements.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 9 (88.89%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 85.816%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/transpiler/passes/synthesis/unitary_synthesis.py
8
9
88.89%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
2
91.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
70600

Relevant Lines:
82269

💛  - Coveralls

Uh oh. It looks like the transpiled circuit is different on Windows than it is on Mac and Linux.
        opcount = circ.count_ops()
        self.assertEqual(opcount["rz"], 8)

On Windows, the count of rz gates is 9, rather than 8.

Fixing the rng seed here 9b406e4 (#10090)  did not fix the discrepancy between Windows and the other platforms. I don't have easy access to Windows, or I would check if terra 0.23 also had the same behavior.
In fact, I don't know if it's reasonable to ask that compiling on  Linux and Windows gives the same result. If it is, I'll have to dig a little more.

I suppose in the short run, I can condition the test on the platform. I think I can see the Windows output in the error log. If not, I can bite the bullet and install Windows in a vm.

I can have a look - I've got a Windows computer with a sufficient dev environment.  I suspect it's differences in BLAS version somewhere along the line.


[GSK-1419][GSK-1383] Make dataset, model as suite input in Suite and upload them automatically

Description

Related Issue
[GSK-1383] Make dataset and model as suite input, when generating the test suite from scan
[GSK-1419] Add the possibility to set default run parameters to a test suite
Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[x] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

Checklist

[ ] I've read the CODE_OF_CONDUCT.md document.
[ ] I've read the CONTRIBUTING.md guide.
[ ] I've updated the code style using make codestyle.
[ ] I've written tests for all new methods and classes that I created.
[ ] I've written the docstring in Google format for all the methods and classes that I used.

@Inokinoki is this ready to review?


Unable to build v1.69, v1.70 on Windows - loading libboost_locale unexpectedly stops

Hello,
I'm trying to use boost as a dependency in building CGAL over here. The building process seems to be working fine, despite a few warnings one can ignore which are independent from Boost itself.
Alas, upon attempting to build boost on Windows (10, 1809 build 17763.615, x64 arch), the build process halts once it attempts to dlopen("libboost_locale"). I can also confirm it is the only dll that can not be dlopen-ed.
I'm not sure if this is a consequence of attemping to use cross-compiled binaries or not, so I'm not totally sure if the issue pertains to the builder, i.e. the build process, or if the cross-compilation alone is the issue here.
EDIT: Can confirm it happens with 1.70 as well.

Also, this should be an obvious one: libboost_signals is still present in 1.69, which doesn't allow for a successful build (won't write deps.jl since the product can't be verified).

Thanks a lot for testing and reporting this!
I will remove libboost_signals for a rebuild of 1.69 and also libboost_stacktrace_addrline which according to the docs is only valid for POSIX platforms:
https://www.boost.org/doc/libs/1_70_0/doc/html/stacktrace/configuration_and_build.html
I don't understand the problem with libboost_locale, do you get any errors when doing the dlopen? (I don't have a windows machine to test this...)

No problem, whatever I can do to help!
About libboost_locale: I first tested it on a VM, running the REPL. I just plainly attempted to dlopen the dll and it quit the REPL immediately, dropping me back into my command prompt. Tried on my regular Windows machine trying to rule out a possible system configuration fault, unfortunately observing the same behavior. Couldn't really trace the cause of this.
I then attempted to build it myself, even with the aid of BinaryBuilder's wizard to check the output products. It was evident that neither libboost_signals nor libboost_stacktrace_addr2line were included, so that was seamless. However, libboost_locale was and the issue remains. I'm assuming, at this point, it has to do with the cross-compilation process. Official boost binaries for Windows obtained from the website work fine, including the misbehaving libboost_locale (however, I'm assuming those were built using MSVC and not the mingw toolchain).
A simple hacky solution right now would be disabling the libboost_locale product when writing the dependencies file, possibly referring to this issue as a potential justification of why it's not included. This is clearly no solution for software that requires libboost_locale, of course.
I'll be looking into it further as well to see if I can find a reason why this happens.

builds without these products are in progress tagged as 1.69.0-1 and 1.70.0-1, will take some time until all targets are done.

That's awesome to hear!
About this issue: Not sure if it should remain open until a more permanent less hacky solution is found or not.
Thanks for the help and for listening! :+1:


Update postgres to <IP_ADDRESS>

Looks good, thanks! :+1:
Next time, please include the name of the Cask that is being updated in your commit message. That way, if we have to look back at history, we can easily tell which Cask is being updated in the commit. :ok_hand:


Allow zero chars in string

I can make a patch to allow subj, for this I want to add method InBuffer which checks for offset is it in the buffer. Okay?

For the moment it is not clear for me how you are going to solve the problem.
But you see 20 years ago I kept functions call at min so the code would be faster.
BTW you non-capturing group patch does add some additional calls and loops (to get capturing group by Idx from full groups list) and I am afraid that already slow down TRegExpr a bit..
May be we need some performance tests as well so we could see clearly that we do not sacrifice performance by new patches?

I can do optimization of GetSubExprArrayIndex

make it "inline" (will be no function call)
add variable NonCaptureExists:bool, which is set when first non-capture group is found, flag is checked in function to work faster

You that sounds(!) good but with modern CPU - multi-levels cache, branch predictions and so on I do not believe this is possible to understand what is good for performance just theoretically.
If we had some performance tests - easy to run and to compare change. Even as CI - so if we drop performance significantly they will be red.
And only with such a tests we could understand if we really need that..

solved


Update to the "GetTime" function for async

I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.
Category

[x] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Updated the functions that are used to perform the dynamic loading of the packages.
I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.
Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to 'master' branch. Released documents are in live branch.
(DELETE THIS PARAGRAPH AFTER READING)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/dynamic-loading.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add links in markdown files

Hi there!
Thank you for your contribution, very useful addition to the guides making the user experience easier.


Subheadings do not appear on the webpage as links in  jykyll theme

check this

Didn't get you

On the left hand side there should be links for what is Variable? (change that to what is a variable as well ), Declaration,Multiple Assignments

@Chaitya62 i think we should use cayman as the documents aren't lengthy to have those sidebars now .what say @nurdtechie98 ?

Ya it looks cool but then depends on whether we need the presentation to be formal

Let's decided after 90% of documentation is done

@inishchith  try using h2(##) instead of h3(###) for those subheadings will work probably

@Chaitya62  @inishchith  it works added to my pr close the issue


Error

Hi
I have this error on my iPad.

On my iPhone run thia script without problems.
Thanks
Marc

Can you go into you icloud drive files and look in the scriptable folder and then in the homebridgeStatus folder. There should be a hbLogo file. My guess is that is has not been downloaded yet. So press the download button and run the script again

Ok yes. It works now. Thank you very much.

Nice 👍🏻


use official github-pages deploy workflow

GitHub now officially supports pages deployment from Actions

Just an official solution. Feel free to close it if not needed.


Add auto sizing explanation to demo

Add explanation/demo of how the grid works

Add explanation/demo of how the auto sizing works with percentage-base sizing

Added in v0.4.6.


Fix a few typos

  Caution: Large pull request
This public repo applies limits on the number of files that can be merged in a single pull request (PR):

Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
Block Block message and PR is blocked - 100

This pull request will change 41 files, which exceeds the warning limit of 41.
Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.
The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.
To merge this pull request
If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

To reject this pull request
If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.
* You must have write or triage access to this repo to add labels.

@Blake-Madden, I highly suggest that you break this PR into smaller chunks. It spans too many different areas of responsibility. Use the top-level folders as delineators.

@Blake-Madden, I highly suggest that you break this PR into smaller chunks. It spans too many different areas of responsibility. Use the top-level folders as delineators.

Got it. I reverted and then pushed edits just to the "security" folder.


Added google clone

🛠 Fixes Issue (Number)
#522
👨💻 Changes proposed

✅ Check List (Check all the applicable boxes)

[x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots

google logo is missing

Okay let me add .

Please check I added all the changes.


fix: the laggy issue when scrolling at a large folder

Hi, I added a new idx property to the File type, it should resolve this problem. (Needs the latest main branch of Yazi)
BTW what Lua formatting tool are you using, and could you add its configuration file? My StyLua default configuration is a bit mismatched with it :)

Hey, thanks for your contribution!
I don't really know what I'm using for the StyLua, I don't think that I have a custom file. If you don't mind you can add yours to the repo and format with it.

Okay, let me add it!

I already updated yazi and tested this, it's working as expected.
Thank you  again for your help making this plugin better @sxyazi!


Seal Keycloak and Argo CD secrets

This PR leverages the enhanced GitOps pipeline introduced by #106 to consolidate all secrets in the same dir and manage them through Sealed Secrets. Specifically

The Argo CD secret got refactored to make it work w/ Sealed Secrets
The Keycloak deployment got refactored to create an initial admin user through a sealed secret
Argo CD and Keycloak sealed secrets got generated using the pub key of the Sealed Secrets controller running in kitt4sme.collab-cloud.eu

Also docs got updated to take the above changes into account

Got rid of the manual procedure to create the Keycloak initial admin
Mentioned you need to generate valid secrets after the cluster bootstrap procedure

Notice this PR also implements a solution for #70 since now the Keycloak admin user is safely created during the bootstrap procedure without any manual intervention.

Demo steps

Follow the cluster bootstrap procedure to create a Kitt4sme cluster in a Multipass VM.
As part of the procedure generate Keycloak and Argo CD sealed secrets with your own passwords.
Redeploy the Keycloak and Argo CD sealed secrets.
Browse to http://vm-ip/auth and log onto Keycloak with user name admin and the password you used to generate the sealed secret earlier.
Browse to http://vm-ip/argocd and log onto Argo CD with user name admin and the password you used to generate the sealed secret earlier.
Set up Argo CD SSO as explained in the security how-to.
Browse to http://vm-ip/argocd and log onto Argo CD through Keycloak.


missing transpileDependencies config

I have some dependencies component provided with TypeScript and have no dist file, is there any way to transpile these dependencies ?

you can use source.include transpile dependencies


feat: add cargo dependency tests

Trying to identify all the different scenarios how a developer could have a near-sdk dependency in their Cargo.toml. A few corner cases are not working, I feel like it would be worth it to add patch section support, not sure about renamed and platform-specific dependencies. Either way, will be handled in a follow-up PR.
Also, I had to remove common Cargo workspace for all integration tests since it was causing a lot of hard-to-overcome issues (e.g. patch section should be in the root Cargo.toml, local dependency clashing with one pulled from Github). The downside is that it increases the test build time. Btw, if you have run the integration tests on your machine at least once in the past, I recommend doing cargo clean before running them on this PR as the residual files from the previous approach can cause issues with this PR.

Welp, now Github Actions are failing because there is not enough disk space on our runner 🥴

Welp, now Github Actions are failing because there is not enough disk space on our runner 🥴

Hmm, we should probably drop the cache for these small libraries. I'll do that now


Using and handling cached audio files

Given a repeated prompt, without a specified output path, the system will make a new call to synthesize audio, download the audio, and play the audio. The files are by default cached to /tmp with a md5 hash of the text and a timestamp. That is done here: https://github.com/aws-robotics/tts-ros1/blob/80a1b40728af7e9006ce00de9e92c13f870dc8a6/tts/src/tts/synthesizer.py#L115
It would be nice if the hash was done on the entirety of the request to be sent without a timestamp and the system would check the storage location to see if the same request has already been returned. If it had been, then the prior audio could be used. Over time, that could build up a large number of files, so it would be nice to be able to set a maximum cache size and have the least-recently used file deleted upon exceeding the maximum.

@mjsobrep we are taking a look. thanks for submitting this!

cool, thanks

Hey @mjsobrep, these suggestions make sense to us and we'll consider scheduling this work in the future. In the meantime we'd greatly appreciate any contributions.

Alright, sounds good. If I get a chance over the next month or so, I will see if I can knock something together.


Add Credit Karma to company list

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2436 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2436   +/-   ##
=======================================
  Coverage   69.31%   69.31%
=======================================
  Files         146      146
  Lines       11242    11242
=======================================
  Hits         7792     7792
  Misses       3450     3450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7159475...be829f0. Read the comment docs.

hey @greg-finley-ck, please amend your commit message and PR title to reference a JIRA issue, like so
[AIRFLOW-xxxx] Adds CreditKarma to companies list
Thanks

Welcome!


suggestion: class name strings

TypeScript Version:  2..x
I just started using literal strings and it's a wonderful feature. Given Typescript's integration with HTML it would be nice to tap into that knowledge. In particular be able to declare that a string is the name of a CSS class in the project.
Also, for convenience, might as well have an HTMLColor type predefined.  Even better if a field like backgroundColor would be defined as an HTMLColor (though # strings may be hard to fit into that model)

Can you show some examples? Are you trying to validate that class names passed as strings must match the set of classes that are available? The term project is a bit vague. would this involve TypeScript inferring class names by parsing CSS files? This seems interesting but its not clear what you have in mind.

First, I realize I'm thinking of Visual Studio not TypeScript and it is VS not TS that does the class handling for HTML. Added it to TS would involve parsing the file so maybe that involves more of a change than simply building on an existing capability.
But to clarify
I have a classes .logAlert and .logMild" and have added
 type logClass = null | "logAlert" | "logMild"

The definition of HTMLElement attributes like backgroundColor comes from lib.d.ts. Currently backgroundColor is defined to be string | null. I am afraid we can not make it a list of values as colors in CSS can be any RGB color.

I understand the problem -- that's why I mentioned the # problem.


cooking: fix cooking#set

Coverage increased (+0.6%) to 94.798% when pulling e4f9e170ccb8de940929756187b319f27b3f9417 on fix/set-plugin into 5b0656da43d95af49137e4a754a0f47b5ec9265f on master.


[Monitor user documentation] The user manual on the wiki should get a Monitor tab.

The user manual on the wiki should get a Monitor tab. I am prepared to write stuff while I am piloting the Monitor. I'm sorry to say that I simply don't know how to create a new tab on that page!
Could someone assist me by creating a tab, so I can use my limited wiki skills to add text?
No pressure, of course!

@pelderson During the past couple of days I have made a start with writing text for a monitor tab in the wiki.  Perhaps give me a couple of days to finalize this initial text, so that you can start with your corrections and further additions from that?

A monitor tab has been added in the OpenStreetMap wiki.


Netty backend

As I see, we doesn't have an examples with Netty as a backend.
It looks strange while we declare that Play support both backends equally 😞
Also, examples with Netty as e2e tests will help us to check Netty backend and be sure that all is fine.
I propose to use Netty for all Java examples and Pekko HTTP for Scala examples.
@mkurz WDYT?

Hi Sergey,
see

#526

I added a flag --netty to the test script to run all the sample tests with the netty backenda as well. And also add a note to all readmes so users see how to use the netty backend.
This is inspired by the TechEmpower FrameworkBenchmarks where we do the same basically:

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/play2-java/play2-java.dockerfile#L5
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/play2-java/play2-java-netty.dockerfile#L5

What do you think?

BTW, updated the benchmarks to Play 3: https://github.com/TechEmpower/FrameworkBenchmarks/pull/8722


CONTRIBUTING.md - Building - Step 3 - gulp installDependencies fails with error TS7006: Parameter 'pr' implicitly has an 'any' type.

Environment data
dotnet --info output:
.NET SDK:
 Version:   7.0.408
 Commit:    03a0111c2e

Runtime Environment:
 OS Name:     nixos
 OS Version:  24.05
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /nix/store/8ycn4yw0lc02dlziirqjs9islr03nar1-dotnet-sdk-7.0.408/sdk/7.0.408/

Host:
  Version:      7.0.18
  Architecture: x64
  Commit:       544c7e6eb3

.NET SDKs installed:
  7.0.408 [/nix/store/8ycn4yw0lc02dlziirqjs9islr03nar1-dotnet-sdk-7.0.408/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 7.0.18 [/nix/store/8ycn4yw0lc02dlziirqjs9islr03nar1-dotnet-sdk-7.0.408/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 7.0.18 [/nix/store/8ycn4yw0lc02dlziirqjs9islr03nar1-dotnet-sdk-7.0.408/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

VS Code version: 1.89.1
C# Extension version: current main, commit 745d6efcb96f0e10a3b744273e1e2dac2a022bf3
OmniSharp log
N/A
Steps to reproduce

Follow the extension build steps available in CONTRIBUTING.md
On step 3 of the Building section, gulp installDependencies fails with the following message:

❯ gulp installDependencies
[10:55:39] Requiring external module ts-node/register
tasks/localizationTasks.ts:130:36 - error TS7006: Parameter 'pr' implicitly has an 'any' type.

130     if (listPullRequest.data.some((pr) => pr.title === title)) {

Current gulp version used:
❯ gulp --version
CLI version: 2.3.0
Local version: 4.0.2

Expected  behavior
The extension build process should succeed.
Actual behavior
The extension build process fails.
Additional context
None that I can think of, feel free to ask for any missing detail.

@gautaz what node version do you have?

Hello @dibarbet, here it is:
❯ node --version
v22.0.0

Looking back at the contributing guide, v18 is recommended, I inferred that subsequent major versions would stiil work, seems this is not the case.
Perhaps recommended should be replaced by mandatory?

Looking back at the contributing guide, v18 is recommended, I inferred that subsequent major versions would stiil work, seems this is not the case.
Perhaps recommended should be replaced by mandatory?

I can update the wording - we don't explicitly block newer versions, so if a newer version works then its absolutely fine to use it.  But we do not test other versions and there are often changes that make things not work properly.


Make sure we actually run tests at runtime

Because almost the entire library is constexpr, the majority of our tests look like this:
constexpr bool test_xxx() {
    // test code
    return true;
}
static_assert(test_xxx());

TEST_CASE("xxx") {
    REQUIRE(test_xxx());
}

That is, we do a constexpr test during compilation (which has the added benefit of testing for many guises of UB), and then again at runtime using Catch.
Unfortunately, compilers are getting increasingly smart at noticing that they've already calculated the result of test_xxx(), so they can optimise the run-time version to just REQUIRE(true), which isn't exactly in the spirit of what we want as it means we never actually execute the tests at runtime! It also means that the tested functions never show up in our code coverage measurements.
As a workaround, this commit adds an otherwise-useless template <bool = true> to every test_xxx() function. Then in the runtime version we explicitly call test_xxx<false>() to force a separate instantation which should hopefully show up in CodeCov.
This probably won't do wonders for our compile times, but we'll see...

Well, that was a complete waste of time.
It looks like GCC is perfectly capable of executing test_xxx<false>() at compile-time and using that, even though we didn't explicitly ask for it.
Ah well, never mind.


Clean up Embedded Assumptions in Artifact Metadata Parsing

[x] Test-Content crashes if the Get-ChildItem doesn't resolve, so just revert all the readmeContent to a simple if path isn't null check.
[x] Handle Nonexistent changelog.

@Azure/azure-sdk-eng

/check-enforcer override


Feature Request: Support rabbitmq_user with multiple vhosts.

RabbitMQ has the ability to give a single user access to more than one vhost.  It would be nice to be able to take advantage of this from a recipe.
in our case, it is for a master admin user that has admin access to all vhosts, such as:
# Create a user for administration of all vhosts
rabbitmq_user "overall_admin" do
  vhost ["/", "foo", "bar"]
  password overall_admin_password
  permissions ".* .* .*"
  tag "administrator"
  action [:add, :set_permissions, :set_tags]
end

:+1:


Export and import CSV files [0.5 days]

Add the ability to export and import your progress as a CSV file.

We want the ability to save our progress if we have to turn off or switch to a different computer, so there should be an option to dump all important data to some sort of persistent storage such as CSV or db. Important data would mainly be the time any completed Steps were accomplished. Furthermore, it would also be necessary to add importing such a file back into the program to resume progress.


Fix rowset_meta race condition for commit_txn in TxnManager

This PR is to fix rowset_meta race condition for rowset_meta modification in commit_txn

for #3329

@caiconghui Hi, Why prepare_txn, rollback_txn, delete_txn don't need this txn_lock?

@caiconghui Hi, Why prepare_txn, rollback_txn, delete_txn don't need this txn_lock?

@kangkaisen txn_lock to protect txn itself, and txn_map_lock to protect txn_map

@caiconghui Hi, Why prepare_txn, rollback_txn, delete_txn don't need this txn_lock?

Only commit_txn and publish_txn has rowset meta modification. So I think the txn lock is mainly to protect the rowset meta of the specified txn.

txn_lock to protect txn itself

what's the meaning of protect txn itself ?

Only commit_txn and publish_txn has rowset meta modification. So I think the txn lock is mainly to protect the rowset meta of the specified txn.

@caiconghui  Hi. If @morningman is right. Please rename _txn_mutex and _txn_shard_size, current name is confusing.

txn_lock to protect txn itself

what's the meaning of protect txn itself ?

Only commit_txn and publish_txn has rowset meta modification. So I think the txn lock is mainly to protect the rowset meta of the specified txn.

@caiconghui Hi. If @morningman is right. Please rename _txn_mutex and _txn_shard_size, current name is confusing.

how about _rowset_meta_mutex,  _rowset_meta_shard_size? @kangkaisen

how about _rowset_meta_mutex, _rowset_meta_shard_size? @kangkaisen

@caiconghui OK. I agree with you.

I think TxnManager is better to not know the RowsetMeta concept.

I think TxnManager is better to not know the RowsetMeta concept.
It's only to know the Transaction concept, so I think the previous name is OK.

TxnManager has known the RowsetMeta concept.
_txn_mutex normally means we should get this lock for most of txn operations, but we only get it when commit_txn and publish_txn
We really use _txn_mutex to protect the rowset meta.

I think TxnManager is better to not know the RowsetMeta concept.
It's only to know the Transaction concept, so I think the previous name is OK.

TxnManager has known the RowsetMeta concept.
_txn_mutex normally means we should get this lock for most of txn operations, but we only get it when commit_txn and publish_txn
We really use _txn_mutex to protect the rowset meta.

I think the txn_lock really ensure the commit_txn and publish_txn be atomic function, which not only include rowset_meta modification, function also need to find, insert or find and then delete the txn from txn_map.
@kangkaisen @morningman @chaoyli

You can use the _txn_mutex still


add example how to run a command within a pod

I was missing the run command with --command flag in the cheat sheet and always googeling around when I needed it. So I thought it would be nice to add it. I hope this helps others too. Thank you.

@JamborJan GitHub says that there is a merge conflict. It would be great if a rebase is performed.

@JamborJan Hey there, it looks like this needs a rebase before we can properly merge changes. It would great if you could follow up so we can move forward with your first contribution! Thanks for your efforts so far 🙌

/close
Long time no response.


feat: add secContext options

Expose securityContext fields for all containers. Not adding any default fields for now :)
Add simple GHA to test if the chart can be installed

Hi @Demonsthere, thank you very much! It looks good to me.

Ups, yeah :D Still working on that, moving to draft for now

Now it's working as intended 😉

Thanks!


OSX: can't use, because of 404 missing https://github.com/electron/electron/releases/download/vbitbucket_link/electron-vbitbucket_link-darwin-x64.zip

when trying to use: nativefier on the cmdline the following error occurs:
Downloading electron-vbitbucket_link-darwin-x64.zip
Error: GET https://github.com/electron/electron/releases/download/vbitbucket_link/electron-vbitbucket_link-darwin-x64.zip returned 404
Error: Failed to find Electron vbitbucket_link for darwin-x64 at https://github.com/electron/electron/releases/download/vbitbucket_link/electron-vbitbucket_link-darwin-x64.zip
at Request. (/Users/rt/.nvm/versions/node/v6.5.0/lib/node_modules/nativefier/node_modules/nugget/index.js:170:61)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at Request.onRequestResponse (/Users/rt/.nvm/versions/node/v6.5.0/lib/node_modules/nativefier/node_modules/request/request.js:986:10)
at emitOne (events.js:96:13)
at ClientRequest.emit (events.js:188:7)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:472:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:105:23)
at TLSSocket.socketOnData (_http_client.js:361:20)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at TLSSocket.Readable.push (_stream_readable.js:134:10)
at TLSWrap.onread (net.js:543:20)
packaging [========================================          ]
Strangely it seems to work when explicit setting cmdline-parameter: -p
Something like:
works
nativefier -p osx -name helloworld http://www.example.com
doesn't work
nativefier -name helloworld http://www.example.com

I am very sorry, the problem was in front of the monitor.
instead of the parameter: -n
i used: -name
which is wrong, should have been: --name
this choked on the next parameter: -p osx
If used correctly, there is no issue. MAybe the parameters could be validated better, and the corresponding error-message. But it's definately no issue. My error. Sorry.


Use more inclusive wording

Replace 'he' with 'they' as not all "pros" are men.

Good idea. Thanks!


added additional stories to snapshot

Fixes #1733
Added the additional stories to snapshot testing in story-based-tests.js file.It adds it to the DOM snapshots and image snapshots.

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[x] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[x] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[x] Review the appropriate Storybook stories. Open http://localhost:9001/.
[x] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

I'm not sure what's going on in this pull request. Is it complete?

No, it is not complete. Actually I mistakenly deleted the branch from where I make the pr. So don't consider it. I will make another pr with corrections regarding the same.


Wrong comments order

sm.comment_sort = 'top'
sm.comments.replace_more(limit=None)
sm.comments.list()

This code returns a list of comments in this order:

But on the site the order is different:

https://www.reddit.com/r/AskReddit/comments/kchdyk/medical_examiners_what_was_the_weirdest_but/?sort=top
I use latest praw on Windows.

Like due to Reddit not being able to decide the order. I've noticed before that sometimes when I reload a post the order of comments with similar numbers of votes will change even if the upvotes don't appear to.

Like due to Reddit not being able to decide the order. I've noticed before that sometimes when I reload a post the order of comments with similar numbers of votes will change even if the upvotes don't appear to.

Most of the comments sm.comments.list() returns in correct order. But there is definitely a problem with some of them.

Most of the comments sm.comments.list() returns in correct order. But there is definitely a problem with some of them.


Mvp 773 - Footer links and content

Content created for Cookies and Contact page. Screenshots below

@johnkane1 under 'Post' should we include the name of the organisation as it's not shown on the page anywhere else?

@sinclairs re Cookies specific to our service - Adrian provided these last year for John. Do you know if they are still relevant or if we need to add anything else? Thanks

Looks great! Theres a close button on the contact but not cookies? What does that button do? Don't think we need it -  do all the new links open in a new tab? I think thats the pattern from what I've seen in other services

Looks great! Theres a close button on the contact but not cookies? What does that button do? Don't think we need it - do all the new links open in a new tab? I think thats the pattern from what I've seen in other services

Close was copied from the other service I looked at (passport office), can simply remove it though.  I can change the hrefs for the links to do that too.

Pushed following changes

added missing third bullet on cookies page
links now open in new tabs
removed close button
updated first line of post address

Thanks @johnkane1


[BUG] Subtype codes not matching due to string vs int

Bug/Defect description
Infrastructure subtype code is unable to find equivalent subtype code in the subtype_code file when it exists.
Steps to reproduce
Create an infrastructure file that has only numerical values in the subtype_code.
Use a subtype_file that contains both numerical and string values in the subtype_code.
This will cause a Key error to occur when LDAR-Sim tries to find the subtype_code key from the infrastructure file in the subtype_file.
Evidence
You will get a Key Error.
Expected behavior
In theory, the subtype codes should match and both be considered as strings instead of ints compared to strings.
Inputs and Parameters
No response
Version Number
3.1.0
Additional Context
This bug should not be encountered by the average user. It is something that may arise for those who create a master subtype_file and re-use this single file for multiple different simulations with different infrastructure file. Specifically when users use a subset of subtype codes that consist entirely of numerical values, while the subtype file contains both numerical and text subtype codes.

No longer relevant with v4 update.


Timeline for development branch merge

What is the timeline for the development branch (which is required for pyNeuromL) to be merged into master and get a PyPI release?

Not soon I'm afraid... The NeuroML 2 repos are only merged to master when there is a full beta release (incl schema, Java APIs etc.), next one is for NML v2beta4, in hopefully 3 months (but that's what I would probably have said 3 months ago...).

@rgerkin, soon, very soon...

@rgerkin the development version has been merged to master at the NML v2beta4 release, and the latest stable version (a few commits ahead) has been released to pip.
This does create a bit of a discrepancy, but it's in line with the other NML2 repos where there is a distinction between the development and master codebases (that developers may want to contribute to; merges take place at major NML2 releases) and the latest stable binary releases (e.g. of jNeuroML) which most people will want; they just want the latest most well tested version.


How to integrate AD B2C in bot service?

I'm trying to integrate Azure AD B2C in my bot service. But I don't know how to do it?

For help with these types of questions, post your question on Stack Overflow.


feat: add pnpm support

Fixes #145

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@penx regarding the error you are getting:

Unable to process command '::add-path::/home/runner/setup-pnpm/.bin' successfully.
The add-path command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true.

Perhaps this is due to the older version of PNPM's github action in this PR? The example file uses<EMAIL_ADDRESS>but the latest is<EMAIL_ADDRESS>(not to mention pnpm 5.4.3 is superceded by 6.3.x now)

How can use this version of the action?

Hi all, just to let you know I'm taking a break for a couple weeks and will pick this up again after that. If someone wants to pick it up in the meantime they are more than welcome to.
Also check #382 which is what I personally need and is very similar.

@bahmutov can you take a look at this PR?

I've:

updated the following dependencies to the latest versions

cypress
pnpm/action-setup
pnpm

Rebased off master and rebuilt dist
Updated the pnpm lock file

but this still fails with
Run ./
  with:
    working-directory: examples/basic-pnpm
    build: pnpx cypress info
    record: false
    config-file: cypress.json
/home/runner/setup-pnpm/node_modules/.bin/pnpm install --frozen-lockfile -C
undefined
 ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL  Command failed with ENOENT: install --frozen-lockfile -C
spawn install --frozen-lockfile -C ENOENT
Error: The process '/home/runner/setup-pnpm/node_modules/.bin/pnpm' failed with exit code 1

https://github.com/penx/github-action/runs/3589281020?check_suite_focus=true

This was intentionally in draft as I was picking up someone else's PR to see if it would build on CI with some minor modifications.
It didn't, and I'm not sure what to do next to resolve the issues I'm afraid. I don't personally need pnpm support but will be happy to try out any suggestions - or even better if someone wants to pick it up then feel free.

I think the comment here https://github.com/cypress-io/github-action/issues/145#issuecomment-884808726 may also be the way forward - i.e. if you are using pnpm, manage the dependency install yourself and then pass install:false to this action.

Closing in favour of the workaround detailed above


I could not find what I was looking for a item is not an clickable

Hi! I have a documentation issue on InstantSearch.js, I could not find what I was looking for which is:
On an item listing I am not able to click or select the item

Could you explain what you mean? If you want a way to go to a detail page from a result, you can simply add a link to that result in the item template. Does that make sense?

Otherwise you can show us

@roshandhabekar can you give us more details on what you're trying to achieve?

@roshandhabekar I'm closing this issue for now. Please open a new one if you have more details :)


fix(Subject): make value parameter for next non-optional

Prevents emitting undefined on strictly-typed Subjects
BREAKING CHANGE:
If you are using TypeScript called next() without a value before, TypeScript will error. If the Subject is of type void, explicitely pass undefined to next().
closes #2852

Coverage remained the same at 97.078% when pulling 64ba901f31291cce2072e230a424ab12b20913b2 on felixfbecker:next-not-optional into cd9626a4f93cac6f631d5a97dd9c9b2aa8e4b5db on ReactiveX:master.

Given't that I've personally written a lot of code that calls Subject next() without an argument, I'm not sure how I feel about this one. @david-driscoll ... is there some way to have the best of both worlds here? Like a no-argument override that only exists for Subject<void>?
cc @kwonoj

afaik there isn't great way. Thought of defeult generic bit, but neither <T=void> nor <T=never> doesn't work - default generic seems only works when value is actually supplied.

I'm still thinking about this one. Consulting some TypeScript folks for a second opinion. FWIW: I'm totally on the fence about this change.


refactor get_objects to use ES when object is op

current implementation of lastnetworkops will call _get_object : https://github.com/oxarbitrage/bitshares-python-api-backend/blob/master/api.py#L522 with operation_id
this situation makes non possible to run all the explorer backend with 1 node as we need plugin elasticsearch and account_history activate at the same time. this is not possible in 1 node.
need to change _get_object to get data from ES when object type is operation or make new call for this purpose.

I think this is fixed and can be closed.

yea, thanks.


Android: Edge-to-edge navigation bar

I want to make my app look edge-to-edge on Android devices, as shown in the following article.
I have used the StatusBar component with the following props to get a fully transparent status bar.
<StatusBar translucent={true} backgroundColor={'transparent'} />
However, it has been impossible for me to get the navigation bar fully transparent. I have found these two unsuccessful approaches in styles.xml:
Using <item name="android:navigationBarColor">@android:color/transparent</item> I get the following result:

Notice that I am getting a white background instead of a transparent one.
Using <item name="android:windowTranslucentNavigation">true</item> I get the following result:

Notice that I am getting a translucent background instead of a completely transparent one. However, at least the app is being drawn under the navigation bar.
React Native version:
0.61.4

For anyone having this issue. This is what I did:
Add this to MainActivity.java:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) {
            Window w = getWindow(); // in Activity's onCreate() for instance
            w.setFlags(WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS, WindowManager.LayoutParams.FLAG_LAYOUT_NO_LIMITS);
        }

And add the necessary imports:
import android.os.Build; // Added
import android.view.Window; // Added
import android.view.WindowManager; // Added

This was taken from StackOverflow


LRN has not been registered, ConvBatchnormScaleReluPool has not been registered error with Anakin inference engine

I followed below link for running CNN benchmark it
https://github.com/PaddlePaddle/Anakin/tree/developing/benchmark/CNN
https://github.com/PaddlePaddle/Anakin/blob/developing/docs/Manual/Converter_en.md
Steps I followed:

I downloaded below model files for alexnet
caffe.proto
https://github.com/BVLC/caffe/blob/master/src/caffe/proto/caffe.proto
alexnet.prototxt
https://github.com/BVLC/caffe/blob/master/models/bvlc_alexnet/deploy.prototxt

alexnet.caffemodel
 http://dl.caffe.berkeleyvision.org/bvlc_alexnet.caffemodel

Then I used below Anakin converter to convert it into Anakin
https://github.com/PaddlePaddle/Anakin/blob/developing/docs/Manual/Converter_en.md

Now when I run run.sh for benchmark following below link
https://github.com/PaddlePaddle/Anakin/tree/developing/benchmark/CNN

I get below error:
0| 16:01:55.00997| 0.221s| main_thread| input.cpp:19]  |-- shape [3]: 227
FTL| 16:01:55.00997| 0.221s| main_thread| factory.h:37] LRN has not been registered!
***  fatal error: stack trace: ***
5             0x417c99 _start + 41
4       0x7f7289445830 __libc_start_main + 240
3             0x417b77 main + 791
2             0x425815 anakin::test::EngineTest::run_all(char const) + 789
1             0x41c264 NetTest_net_execute_base_test::net_execute_base_test() + 2420
0       0x7f728a75bbec anakin::Net<anakin::saber::TargetType<(anakin::saber::TargetTypeEnum)4>, (anakin::saber::DataType)1, (anakin::Precision)0, (anakin::OpRunType)1>::Net(anakin::graph::Graph<anakin::saber::TargetType<(anakin::saber::TargetTypeEnum)4>, (anakin::saber::DataType)1, (anakin::Precision)0>&, bool) + 172
Aborted (core dumped)*
With Resnet50 model i get below error
FTL| 15:21:08.00991| 0.244s| main_thread| factory.h:37] ConvBatchnormScaleReluPool has not been registered!
***  fatal error: stack trace: ***
5             0x417c99 _start + 41
4       0x7f310fec8830 __libc_start_main + 240
3             0x417b77 main + 791
2             0x425815 anakin::test::EngineTest::run_all(char const*) + 789
1             0x41c264 NetTest_net_execute_base_test::net_execute_base_test() + 2420
0       0x7f31111debec anakin::Net<anakin::saber::TargetType<(anakin::saber::TargetTypeEnum

LRN and other OP have been added in https://github.com/PaddlePaddle/Anakin/pull/515, wait for merge

Thanks for the update!
Can you check one issue(FPE error) i raised with Anakin(AMD GPU backend) ?
https://github.com/PaddlePaddle/Anakin/issues/516