Some keys don't work sometimes in the SCM viewlet's input box.

VSCode Version: 1.11-insider
OS Version: Win10

Steps to Reproduce:
Sometimes, when I'm typing a commit message, some keys such as Space don't work at all in the viewlet, whereas the work in other apps and even other editor panes in vscode. The bug happens intermittently, and probably when I alt-tab directly to SCM view in vscode from some other app. This is the case from the day the vscode changed GIT to SCM. Didn't report the issue due to utter laziness on my behalf.
Lately, I figured out a way to beat the bug. It seems like the focus is set to the diff list below the textarea, but when I type letters, they get typed in the commit message box. But when I type space, it doesn't work. So, I try to reset the focus by pressing Tab or Shift-Tab, and space starts working again.

This doesn't make much sense. Does it reproduce after a machine reboot? Does it reproduce with --disable-extensions?

As I said, It happens intermittently... Yes, it does happen after a machine reboot too - although it's so rare that I've encountered this maybe 5-7 times since SCM was introduced in insider. I don't think I can use --disable-extensions when I don't have a reproducible case yet.

Closing until we get repro steps.


Default config from ruby file for gcov plugin

Ceedling plugins can set default config via defaults.yml file.
Sometimes it is useful to set default configuration in ruby similarly to default.rb file. It helps to use more sophisticated code, for example configure tool executable with FilePathUtils.os_executable_ext().
The new defaults_gcov.rb file also add usage of CC, CPPFLAGS, CFLAGS to gcov compiler and CCLD, LDFLAGS, CFLAGS, LDLIBS to linker tool by default and solve #509.
I also wonder whether to change extra_params expansion in build_command_line method:
    executable = "\"#{executable}\"" if executable.include?(' ')
    command[:line] = [
      executable,
-      extra_params.join(' ').strip,
+      build_arguments(extra_params, *args),
      build_arguments(tool_config[:arguments], *args),
      ].reject{|s| s.nil? || s.empty?}.join(' ').strip

to use elements runtime substitution for specific files, like CFLAGS variable in the #509, but I'm not sure if :flags: section should have this functionality.

@CezaryGapinski -- I apologize for merging #521 first and forcing you to have to clean up the merge. I really appreciate all the work you've been doing on this project! Sorry about making more work for you!

@CezaryGapinski -- I apologize for merging #521 first and forcing you to have to clean up the merge. I really appreciate all the work you've been doing on this project! Sorry about making more work for you!

@mvandervoord I've rebased this branch so I think it should be fine now.


Use staging for performance?

This is more of a feature request, of course :)
https://mpickering.github.io/papers/staged-sop.pdf Pickering, Loeh, Wu, [2020] Staged Sums of Products"
https://kosmikus.org/StagedSOP/staged-sop-haskell-symposium-talk.pdf

Also this seems to overlap with the recent research of @gallais et al on Frex, though I'm not sure what stage (:wink:) that work is at.

I have looked at those SOP articles before, but only superficially. I'm not sure, however, whether we have the necessary metaprogramming machinery for that in Idris2. Do you have any hints in that direction? Thanks anyway for the articles. The Frex one is new to me.


japanese plugin v1.0

Can translates text of most if not all widgets into japanese, can also chat in japanese. can use DeepL api to translate thing more accurately.
This plugin is targeted for Japanese players who can't read English but want to play this game.
Currently some widgets are set not to be translated because I havent provided a translation for that part, and bad translation can cause confusion.
Can selectively choose not to translate if desired in config section.

could someone help me with this error?
i have added third party dependency then ran
gradlew --write-verification-metadata sha256
after adding deepL dependency in package/verification-template/build.gradle
`FAILURE: Build failed with an exception.

Where:
Initialization script '/home/runner/work/plugin-hub/plugin-hub/package/target_init.gradle' line: 61

What went wrong:
Could not determine the dependencies of task ':runelitePluginHubPackage'.

Dependency verification failed for configuration ':runtimeClasspath'
2 artifacts failed verification:
- annotations-20.1.0.jar (org.jetbrains:annotations:20.1.0) from repository MavenRepo
- annotations-20.1.0.pom (org.jetbrains:annotations:20.1.0) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.4/userguide/dependency_verification.html#sec:troubleshooting-verification

Open this report for more details: file:///tmp/pluginhub-package6013681569718307465/japanese/repo/build/reports/dependency-verification/at-1712326246275/dependency-verification-report.html

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
build: 6498ms
package failed
net.runelite.pluginhub.packager.PluginBuildException: japanese: build failed
at net.runelite.pluginhub.packager.PluginBuildException.of(PluginBuildException.java:54)
at net.runelite.pluginhub.packager.Plugin.build(Plugin.java:536)
at net.runelite.pluginhub.packager.Packager.buildPlugin(Packager.java:215)
at net.runelite.pluginhub.packager.Packager.lambda$buildPlugins$0(Packager.java:155)
at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: org.gradle.tooling.BuildException: Could not execute build using connection to Gradle installation '/home/runner/.gradle/wrapper/dists/gradle-7.4-all/aadb4xli5jkdsnukm30eibyiu/gradle-7.4'.
...
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
... 1 more
Caused by: org.gradle.internal.exceptions.LocationAwareException: Initialization script '/home/runner/work/plugin-hub/plugin-hub/package/target_init.gradle' line: 61
Could not determine the dependencies of task ':runelitePluginHubPackage'.
...
Caused by: org.gradle.api.internal.tasks.TaskDependencyResolveException: Could not determine the dependencies of task ':runelitePluginHubPackage'.
...
... 75 more
Caused by: org.gradle.api.internal.artifacts.verification.DependencyVerificationException: Dependency verification failed for configuration ':runtimeClasspath'
2 artifacts failed verification:

annotations-20.1.0.jar (org.jetbrains:annotations:20.1.0) from repository MavenRepo
annotations-20.1.0.pom (org.jetbrains:annotations:20.1.0) from repository MavenRepo
If the artifacts are trustworthy, you will need to update the gradle/verification-metadata.xml file by following the instructions at https://docs.gradle.org/7.4/userguide/dependency_verification.html#sec:troubleshooting-verification

Open this report for more details: file:///tmp/pluginhub-package6013681569718307465/japanese/repo/build/reports/dependency-verification/at-1712326246275/dependency-verification-report.html
...
at target_init_6d8nx9ehfn6xp8roxihe52luu$_run_closure1$_closure6$_closure10.doCall(/home/runner/work/plugin-hub/plugin-hub/package/target_init.gradle:61)
at target_init_6d8nx9ehfn6xp8roxihe52luu$_run_closure1$_closure6$_closure10.doCall(/home/runner/work/plugin-hub/plugin-hub/package/target_init.gradle)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
... 143 more`

remove the gradle wrappers you committed

remove the gradle wrappers you committed

is that the one in plugin-hub, or in my plugin?

Keep this line thirdParty("com.deepl.api:deepl-java:1.4.0") { because "japanese" }
Delete

package/verification-template/gradle/wrapper/gradle-wrapper.jar
package/verification-template/gradle/wrapper/gradle-wrapper.properties
package/verification-template/gradlew
package/verification-template/gradlew.bat

Is this something which could be added to the existing Polywoof hub plugin? It already supports translation via DeepL as one of its backends is why I suggest it.

This plugin does many different things from the polywoof's translation plugin, and there are also reasons it cant be added to polywoof:

this plugin translates the widget text and menu entries, but polywoof only creates an overlay which displays translation. Looking at polywoof  README, it probably won't accept my plugin's feature to be added:

Widget Text and UI are untouched to prevent confusion of misleading translations

the file size is very close to the 10Mib limit because the Japanese characters are inserted as png images.

The file size is huge because there are many Japanese characters, multiplied by the number of colors. Originally wanted to include 8 colours, but because of the limit I reduced it to 4, also discarded many uncommon characters which made up 30% of the whole set.

plugin's settings are in Japanese because it assumes the player doesnt konw any English.

I want to make OSRS accesible to Japanese gamers because I'm sure they'll love it, but I dare say many of them are allergic to English.
You might ask if theres a demand for such Japanese translation project, but I have seen few reddit posts asking for Japanese translations, and also know people who want to invite their Japanese friends or use it themselves on X and my Japanese RS discord server

I don't think this plugin will work how you think it does as you aren't using resource directories when accessing your translate data

I don't think this plugin will work how you think it does as you aren't using resource directories when accessing your translate data

do you mean I must place all resources (images, translations) directly under src/main/resources directory, and under src/main/resources/someFolder/ ?

No, the issue is you're accessing the images via the filesystem, rather than from the resources, see: https://github.com/runelite/plugin-hub?tab=readme-ov-file#plugin-resources
Basically, this only works because those png files exist on your filesystem. If you were to build this plugin into a jar and run it on another computer, or remove your copy of the repository from your filesystem, this would encounter errors trying to read the now-nonexistent files.

thanks, I made the difference for reading files. Im guessing i can leave the code for writing to file

The file writing should be changed to a path under ~/.runelite. You can lean on the RUNELITE_DIR constant from the client, eg. new File(RUNELITE_DIR, "japanese"), for a location to write to. As-is, it looks like it would write to some location on the user's system relative to the cwd where RuneLite was run from instead of a fixed path.
Don't use enabledByDefault = false as it's confusing for users to install a plugin which isn't enabled right away.
I haven't yet reviewed the code of the deepl dependency, but the rest of this pulgin's code seems fine to me.

will work on the other things you mentioned from tomorrow, but i have undone the version changes

The file writing should be changed to a path under ~/.runelite. You can lean on the RUNELITE_DIR constant from the client, eg. new File(RUNELITE_DIR, "japanese"), for a location to write to. As-is, it looks like it would write to some location on the user's system relative to the cwd where RuneLite was run from instead of a fixed path. Don't use enabledByDefault = false as it's confusing for users to install a plugin which isn't enabled right away.
I haven't yet reviewed the code of the deepl dependency, but the rest of this pulgin's code seems fine to me.

well, that didnt work..
ill try resolve it from "resolve conflicts" button on

changes I made to my plugin itself:
all files that were in the resource folder are now instead downloaded from a github repository I created to the external file (inside RUNELITE_DIR)
So they are read and wrote not as stream but as normal files.
because of this, I do
final BufferedImage image = ImageIO.read(externalCharImg);
instead of
final BufferedImage image = ImageUtil.loadImageResource(getClass(), filePath);
in JapanesePlugin.java, line 94
Is this alright?
ps:
I made these change becuase

I wanted to use all colors of japanese characters (instead of half, by using yellow instead of white, etc)
no need to make PRs for when I update translations, which is going to happen very often

Would it help if I remove the deepL dependency?
If checking the deepL stuff is taking time, I thought removing it might be better for both of us, because ultimately I aim to translate everything by hand, and when thats achieved DeepL would be unnecessary. (although deepL will help users understand untill that happens)
I know reviews take time and everyone involved are volunteers, so I appreciate you guys works.

i would like to hault for some time
I foud "runelingual" plugin, which is still in development, but does pretty much the same thing but supports multiple languages in 1 plugin
it would be better if I collaborated with them, right?
it would take some time to migrate things, but if its for the better i will

That would  be preferred, yes

hard choice but I think I should do that, more work now but less in the future
can i close this pr?

got it, ty


Update document

Hi @amendx
I edited directly on Github and created two commits and I don't know how to undo that.
Another thing I want to ask is:
Do you have any plan on adding language support to the document?
I'm interested in translating it to Traditional Chinese.

@ga676005 I'll consider the multi-language support for the docs. I'll let you know


Installation of the ce edge channel on Ubuntu fails

I submitted pull request #7 to fix this.
I’ll provide more detail here:
This problem is caused by the task that installs ce edge on Ubuntu (the last task in “tasks/ce/os/ubuntu.yml”). It calls the “yum” installation handler instead of the “apt” installation handler.
It becomes obvious that this is a typo if the file is viewed in its entirety.  You’ll notice that all tasks are “apt” based, except the last line that notifies a “yum” handler (which fails on non-yum systems), and the correct “apt installation handler” exists and works.

Merged.


TRSv2-384 - Update fitness function revision id

Codecov Report
Base: 32.51% // Head: 32.51% // No change to project coverage :thumbsup:

Coverage data is based on head (4a727f2) compared to base (44d91b3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #191   +/-   ##
========================================
  Coverage    32.51%   32.51%
========================================
  Files           91       91
  Lines         3266     3266
  Branches       552      552
========================================
  Hits          1062     1062
  Misses        2204     2204

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


404 when tryingto login account

Hi,
I just went from cakebaked as it suddenly stopped working 2 weeks ago. I got an error when trying to login localhost:3456 I get a 404 error. I uninstalled the nodes and installed applestrudel but I get the same error when trying to initiate the account. I enter the credentials, get the verification SMS and then land on a 404 error page.
Any help is welcome!

same here

Same here!

Still happening can't authenticate

Same for me, also from Germany

As I found out in #143 I did not have 2FA activated and thus I always got the 404 message. After I activated 2FA and tried again I got the "successfully obtained cookie" message and the nodes said ready. So for me activating 2FA solved the issue


Report: The top X populated capital cities in a region where X is provided

A report containing the following columns

Name.
Country.
Population.

Provide a Report on the top number populated capital cities in a region where the number is provided.
e.g. provide a report on the top 5 populated capital cities.


On Windows 24H2 can't use any functions provide by kubevpn (eg access Service IP or Pod IP)?

@zouchengli you can enable Windows feature Virtual Machine Platform (VMP). after turn

reference doc:
link1
link2

Does anybody know WHY this helps? Checkpoint has fixed their client VPN agent somehow, and now it works without hack described in this issue. What is the root casuse ? I could not find any official microsoft exmplanation. What is broken exactly.

Does anybody know WHY this helps? Checkpoint has fixed their client VPN agent somehow, and now it works without hack described in this issue. What is the root casuse ? I could not find any official microsoft exmplanation. What is broken exactly.

I tried to figure out why, but no cause was found. looks like NativeTun read and write is normal


create protocol

[ ] mix erf20 and erc721
[ ] balance

[ ] totalBalance
[ ] stakeBalance
[ ] saleBalance

[ ] stake(amount)
[ ] withdraw(amount)
[ ] mint(uri, role)

openzeppelin stacks

[ ] erc1155 to use multi token
[ ] math to calc apy and fee

uniswap doesn't support erc1155 so use erc20 and erc721


feat: add npm: schema imports

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


openGemini Q&A

If you have any questions about the installation and deployment of openGemini, syntax usage, or anything else, you can ask here.

Question：Why does the data and wal folders not exist in the ts-store data directory after a small amount of data is written?
Answer：It's normal.
In a single-node, this problem does not occur.
In a cluster, only a small amount of data is written and all data may store on one node of the cluster. As a result, other nodes do not have data, and no data and wal directories exist. The two directories exist on the node where the data is stored.

问题现象： K8s（KubeEdge）部署，8010端口起不来
问题原因：
定位方法：

检查配置文件是否正确，如果不正确，修改正确后，清空ts-store、ts-meta的数据目录，再重新拉起 --结束
如果全部配置文件是正确的：访问任意一个meta节点，

唯一管理员应该怎么创建？

参考文档 https://docs.opengemini.org/zh/guide/security_user/user_manage.html

move to here: https://github.com/openGemini/openGemini/discussions


How do you translate in game coordinates to the dbkeys?

Sorry for asking a dumb question, but  do you have a sample, if I know two coordinates that create a cube, how do I find the keys which contain those coordinates?

I know this is a really old thread, but jut want to thank you for your work.
My kid started playing a while ago, and after building a "perfect" world in single player mode on his tablet, we set up a private server so more of us could play toghether, even while not on the same network, and he really, really, REALLY wanted to keep on building in the same world on that server,  This tool allowed me to ensure that I could copy the world from android to the server, while still allowing him to keep all his assets, including ownership of tamed animals. I had to fetch the entities from various coordinates and modify the owner-tag, as the UniqueID of his user apparently changed when moving from single player to a player on the server.
In the process I used your PowerShell code to create python tool to convert coordinates to keys, and while doing that I discovered a small issue with your code.  If the X or Z is negative, but small (< 16) your code will convert it to e.g.  x = -13 -> ChunkX = 0 -> key 00000000.  But while trying to get data fram the LevelDB I discoverd that this really should be key FFFFFFFF.
So it makes me wonder if your convesion of all negative values are off by one, or if this ONLY happens for values close to 0?
Eg. should your "-413" really be E6FFFFFF, or have you verified that E7FFFFFF is actually correct?
I currently have a simple "if x < 0; x = x - 16" (and the same for z) but have not tested it for larger negative values of x or z to validate the theory.

Thanks! I'm glad it was helpful. At least one other person used this for keeping a player whole when moving from server to local or vice-versa.
I went through a phase of doing two's compliment wrong, and that's probably what happened in this code. I'll take a look at it.

Oh, it's not a two's compliment problem as I'm relying on the native signed dword int to handle that.
Okay, I just confused myself a lot working through this, but I mostly see the problem. My C# isn't doing integer division like I expected; it's discarding the fraction which only works for positive results.  Oddly enough, Python integer division is working as math expects, so I'm not sure why your code is having trouble...or maybe you just noticed it's off from mine...mine's wrong, and not just by 1...more like 1 and 1/16.

Hi, and thanks for looking at it so long after.  I have so far managed to fix what I needed to fix, but it is still good to make it right.
I discovered the issue when I created python code.  Python also discards fractrions, so e.g.
>>> int(-0.1)
0

Or
>>> int(-13/16)
0

So my code worked like yours.  But then I could not find the items I was expecting after calculating the key for negative coordinates, but I found them buy manually searching through all the neighbor-coordinates.
I was just not sure if this was JUST related to negative values in the first blockchunk or not. (E.g. if fffffffff goes from 0-(-15) or from (-1 to -16).  But I think I have resolved all my issues now.

Huh, weird. I just pulled up python on my Ubuntu-on-Windows and got
Python 2.7.17 (default, Nov  7 2019, 10:07:09)
[GCC 7.4.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> int(-13/16)
-1

But I just noticed that's python2...here's python3 on the same system:
Python 3.6.9 (default, Nov  7 2019, 10:44:02)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> int(-13/16)
0

Ok, this seems to work the same (and correctly for our purposes) in both:
>>> import math
>>> int(math.floor(-13/16.0))
-1

Yeah. I am using python3, so that explains the diff.
Added math.floor now, and it works as expected, and i do believe that this will give the correct coordinates after trying to fetch entities from different locations in the game.

Awesome. I'm pretty confident in the chunk key being right using math.floor (in any language), but I have a lot to figure out about block encoding as Bedrock changed that quite radically in 1.2.13.

Here it is in Go:
const (
	chunkSize = 16
)

// SubChunkKey builds the levelDB key for the sub chunk at the given x/y/z coordinates.
//
// https://minecraft.fandom.com/wiki/Bedrock_Edition_level_format#NBT_Structure
func SubChunkKey(x, z, dimension int32, y int) ([]byte, error) {
	x = int32(math.Floor(float64(x) / chunkSize))
	z = int32(math.Floor(float64(z) / chunkSize))
	y = int(math.Floor(float64(y) / chunkSize))

	key := make([]byte, 0)

	key = append(key, littleEndianBytes(x)...)
	key = append(key, littleEndianBytes(z)...)

	if dimension != 0 {
		key = append(key, littleEndianBytes(dimension)...)
	}

	key = append(key, []byte{47}...) // 47 is the SubChunkPrefix key type tag
	key = append(key, byte(y))

	return key, nil
}

func littleEndianBytes(i int32) []byte {
	b := make([]byte, 4)
	binary.LittleEndian.PutUint32(b, uint32(i))
	return b
}

// Tests

func TestSubChunkKey(t *testing.T) {
	testSubChunkKey(0, 0, 0, "00000000000000002F00", t)
	testSubChunkKey(16, 16, 16, "01000000010000002F01", t)
	testSubChunkKey(-1, 32, -1, "FFFFFFFFFFFFFFFF2F02", t)
}

func testSubChunkKey(x, y, z int, want string, t *testing.T) {
	b, err := SubChunkKey(int32(x), int32(z), 0, y)
	if err != nil {
		t.Errorf("unexpected error returned: %s", err)
	}

	got := strings.ToUpper(hex.EncodeToString(b))

	if want != got {
		t.Errorf("unexpected key '%s': expected '%s'", got, want)
	}
}


Update sample10.cshtml

A redundant </head> tag was removed.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@natalya-k  Thanks!


Update to latest bosh-utils for Windows fixes

Newer versions of bosh-utils have fixes for Windows. To do this is running update-deps all that is required?
If not then in order to use the latest version of bosh-utils it seems that the following dependencies are required:

doublestar
fs
gouuid

Also NewWriterLogger only requires two parameters, so main has to be updated.

Had a room full of Windows users trying to use BOSH earlier, and got hit by #1821.
The BOSH Lite Vagrant solution is deprecated. The lack of a working bosh create-env is a huge barrier to Windows users being able to learn BOSH, and also Concourse by merit of bosh create-env being one of two documented means to get a local Concourse working.

The way I see it there are two stages to this:

getting it working on Windows
evaluating how things currently work in light of improving the cross platform experience.

Unfortunately at the moment the amount of time that I can work on this is very limited. I try to work to get more of BOSH working on Windows when I can. I try to make my efforts in helping with stage 1 public for bosh-cli and bosh-virtualbox-cpi-release. I'm using the following:

tar that comes with git for Windows
I think the current branch is using the MinGW bash (also comes with git for Windows), but I've also been trying Windows Subsystems for Linux (I've only tried Ubuntu, but I recommend MinGW as there are complications mentioned here)
RubyInstaller for Window (I'm using 2.3.3) and the Devkit (I see that from Ruby 2.4 it isn't a separate install)
VirtualBox

Make sure each of those are on your path, e.g. using Powershell either something like the following for Windows Subsystems for Linux (and change changes) $env:PATH = "C:\Windows\System32;C:\Program Files\Oracle\VirtualBox;C:\Program Files (x86)\Git\usr\bin;RUBY_PATH\bin;RUBY_DEV_PATH\bin;RUBY_DEV_PATH\mingw\bin;" + $env:PATH or the following for MinGW bash env:PATH = "D:\Program Files\Oracle\VirtualBox;C:\Program Files (x86)\Git\usr\bin;RUBY_PATH\bin;RUBY_DEV_PATH\bin;RUBY_DEV_PATH\mingw\bin;" + $env:PATH, where you'd need to add your location for RUBY_PATH and RUBY_DEV_PATH.
As those are my development branches, they aren't ready for general usage but they can fork to work for your computer and then generalised to be ready for a pull request.
With regard to stage 2, I've tried to write up all the issues as I see them in bosh-notes.
Any help that you or people that you know could contribute to this effort would be greatly appreciated. I'm generally on the Cloud Foundry Slack, so probably ask questions there and I can try to improve this post so that more people can help with this. I could possibly even add this to bosh-notes, but I didn't as my branch is development work rather than stable.

Removing the Stale label, and possibly #20 is updating the dependencies as required.
Re-testing on Windows would be necessary though.


rust-analyzer is much slower than IntelliJ when finding references for some symbols

Discussed on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/perf.20issues
textDocument/references is taking about a minute for a particular symbol, whereas IntelliJ "Find Usages" finishes in a second or two. perf reports that most of the time is being spent in chalk_solve::recursive::Solver<I>::solve_goal .
The symbol is pub struct Context in Materialize: https://github.com/MaterializeInc/materialize/blob/b0d54ed86b2e951a4696ebba7f988868a7f2433e/src/dataflow/render/context.rs#L58

Besides "find all references" (where the profiler points mostly to chalk), analysis-stats is also pretty slow:
   9.21%  rust-analyzer  libc-2.31.so                         [.] _int_malloc
   7.58%  rust-analyzer  libc-2.31.so                         [.] _int_free
   6.69%  rust-analyzer  libc-2.31.so                         [.] malloc
   3.67%  rust-analyzer  rust-analyzer                        [.] <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T,I>>::from_iter
   3.19%  rust-analyzer  libc-2.31.so                         [.] malloc_consolidate
   3.10%  rust-analyzer  rust-analyzer                        [.] <chalk_ir::Ty<I> as chalk_ir::fold::SuperFold<I,TI>>::super_fold_with
   1.99%  rust-analyzer  rust-analyzer                        [.] <salsa::derived::DerivedStorage<DB,Q,MP> as salsa::plumbing::QueryStorageOps<DB,Q>>::try_fetch
   1.91%  rust-analyzer  libc-2.31.so                         [.] unlink_chunk.isra.0
   1.66%  rust-analyzer  rust-analyzer                        [.] core::iter::adapters::process_results
   1.58%  rust-analyzer  rust-analyzer                        [.] core::ptr::drop_in_place
   1.56%  rust-analyzer  libc-2.31.so                         [.] realloc
   1.51%  rust-analyzer  libc-2.31.so                         [.] __memmove_avx_unaligned_erms
   1.50%  rust-analyzer  libc-2.31.so                         [.]<EMAIL_ADDRESS>   1.39%  rust-analyzer  rust-analyzer                        [.] core::hash::impls::<impl core::hash::Hash for [T]>::hash
   1.31%  rust-analyzer  rust-analyzer                        [.] <T as chalk_ir::could_match::CouldMatch<T>>::could_match
   1.21%  rust-analyzer  rust-analyzer                        [.] indexmap::map::IndexMap<K,V,S>::insert
   1.10%  rust-analyzer  rust-analyzer                        [.] <std::collections::hash::map::DefaultHasher as core::hash::Hasher>::write

Triage: "find all references" on Context now takes 870 ms on my system:
   40 textDocument/references             874ms

And analysis-stats is still slow-ish, but better than before:
Database loaded:     501.89ms, 506minstr
  crates: 50, mods: 286, decls: 5154, fns: 3637
Item Collection:     8.55s, 90ginstr
  exprs: 186966, ??ty: 1493 (0%), ?ty: 2435 (1%), !ty: 217
Inference:           28.83s, 253ginstr
Total:               37.38s, 344ginstr

Closing for now, but please reopen if needed.

Triage: "find all references" on Context now takes 870 ms on my system:
   40 textDocument/references             874ms

And analysis-stats is still slow-ish, but better than before:
Database loaded:     501.89ms, 506minstr
  crates: 50, mods: 286, decls: 5154, fns: 3637
Item Collection:     8.55s, 90ginstr
  exprs: 186966, ??ty: 1493 (0%), ?ty: 2435 (1%), !ty: 217
Inference:           28.83s, 253ginstr
Total:               37.38s, 344ginstr

Closing for now, but please reopen if needed.


Open url in system browser?

If the markdown file have url,and I want to open the url in my system browser instead of opening in MarkdownView.if add this feature i think will be better.

noted will fix this in the next release

Hi,
can you upload an update to jitpack with this feature implemented?
Thanks


Card img issue

<Card title="title" url='' img='/src/assets/img/logo.svg'
              footer={""}
              >

              </Card>

This does not load the image when npm run build

Hey @conquestace, thanks for submitting the issue!
Astro handles images from the /src folder a bit differently because of optimizations that they run on it. There's two options:
1. Getting your image from the /public folder
Images won't be optimized this way and this is how you would use it:
<Card img='/logo.svg'>

2. Getting the image from the /src folder
You'll have to import the image in the front matter of your file and then access it's src attribute:
---
import logo from '../assets/img/logo.svg'
---

<Card img={logo.src}>

Let me know if this solves it for you!

Thank you. I am still a new web-dev and I understand now.

No problem @conquestace and good luck! :)


Logs

One of these days we should take a swing at adding otel logs to otel-cli. I don't know if it'll work out but it feels worth exploring.
e.g. (having not dug into logs at all)
otel-cli logs hello
Any future plans to add logs?
Thanks!

#44 metrics is discussed there.

I left space for logs and metrics in the code. It's mostly a matter of doing the work of designing the CLI and straightforward coding. We'll keep this open and hopefully get to it soon.

Oh yeah... will also need to write the testing servers for logs & metrics too, I'd like to get testing in place right away this time. The current clievent server isn't very expandable and will need either refactored or separate log/metrics servers created alongside it.


metrics: remote networking: no calls to init_env

None of the remote networking metrics tests call init_env from the common metrics routines. They probably should to ensure we have a clean and stable environment, at least on the host, before we invoke the tests.
It is unclear what to do on the server side, if anything, though.

/cc @GabyCT @MarioCarrilloA

@grahamwhaley I will add that to the remote tests


minified files are formatted/re-idented

if i @ importing minified files like vendor css it doesn't make any sense to reident them before/on concatenation.

never mind, the answer will be rework does that and nothing one can do.


Yes/No message spamming global chat when clicking many times on it.

What is your Quests version / build number (do not say "latest")?
The Latest version on date so 4.1.3
Describe the problem and how to replicate it. Any console errors to post using a pastebin?
I did my quests with Citizens for a Server and since i updated Quests for 1.18, we can now click on Yes/No if we want to accept it. When we click one time there is no problem but if we click again in the chat on Yes or No, it's sending a message for everyone (so Yes or No). Is it possible to fix it so clicking on this message only work once or maybe making an option to disable clicking on chat to accept a quest please cuz i already know some players will make jokes just by spamming right click on the Yes or No. Thanks
Here is the screen when i click only once so it work nice :
Screenshot_3
But here is what it makes when i click several times on "Yes" (my messages are in French) :
Screenshot_4

@datatags Any chance you're aware of a fix for this?

Well, it's directly caused by this code here:
            final TextComponent component = new TextComponent("");
            component.addExtra(ChatColor.YELLOW + getQueryText(context) + "  " + ChatColor.GREEN);
            final TextComponent yes = new TextComponent(getSelectionText(context, 1));
            yes.setClickEvent(new ClickEvent(ClickEvent.Action.RUN_COMMAND, Lang.get("yesWord")));
            component.addExtra(yes);
            component.addExtra(ChatColor.RESET + " / ");
            final TextComponent no = new TextComponent(getSelectionText(context, 2));
            no.setClickEvent(new ClickEvent(ClickEvent.Action.RUN_COMMAND, Lang.get("noWord")));
            component.addExtra(no);

It could happen with any other clickable prompt though, because the way clickable text is currently handled is sort of a quick-n-dirty fix. Here's a review of the situation, if nothing else to help me think through it again:
Clicking on a clickable prompt just chats the text in the embedded click event, and it's handled entirely by the client, so there's no way of separating chat resulting from clicked text from typed chat.
Another way of doing it, and a better way, would be to add another command, like /quests choice X so the server could ignore the command if the player isn't in a conversation. The main barrier to this is using Player#chat doesn't register as conversation input, as you previously discovered. The way to get around this is to use Conversation#acceptInput manually using the args from the command, but we then have to maintain a reference to any conversations players are in, since there's no method on a player to get the conversation it's in.
A third way that works around those problems (but may create its own) would be to embed an extra string in the message sent when clicking, like instead of the player chatting yes or 1, the player would say Quests Chat Input#yes or Quests Chat Input#1 and whatever follows the # would be the conversation input. The side effects here are requiring a filter layer on prompt input, so whether a player chats 1 (manually) or Quests Chat Input#1 (using the clickable message), the acceptInput function will get 1 regardless.
I'd be willing to help with these solutions if you like, let me know what you think.

Is it possible to make an option to disable clickevent ?

Is it possible to make an option to disable clickevent ?

That should be easy enough. The code above would just need to have a config check for a non-clickable menu, and the lines here and here would just need to have || clickableMenusDisabled added to the end.
I'm not familiar with how Quests manages the config though

Thanks for the detailed response. I'm thinking the command would be preferable, but I'm also wondering if it's possible to create our own click handler overriding ClickEvent. Not in a position to check this at the moment.
A configuration option is probably a good idea regardless. All config options go through https://github.com/PikaMug/Quests/blob/main/api/src/main/java/me/blackvein/quests/Settings.java

Thanks for the detailed response. I'm thinking the command would be preferable, but I'm also wondering if it's possible to create our own click handler overriding ClickEvent. Not in a position to check this at the moment.

I'm pretty sure that's not possible since the client has to understand what to do with the click event.

A configuration option is probably a good idea regardless. All config options go through https://github.com/PikaMug/Quests/blob/main/api/src/main/java/me/blackvein/quests/Settings.java

I might take a look at doing that this evening then if I have time.

Perfect ! If you can let me know when this will be added so i can add it directly into my server to avoid spams in my chat as quickly as possible x) thanks again guys !!

I'm pretty sure that's not possible since the client has to understand what to do with the click event.
I might take a look at doing that this evening then if I have time.

You were right, the class is final.
Sure, but don't lose sleep over it.

You were right, the class is final.
Sure, but don't lose sleep over it.
Edit: I noticed that this triggers the PlayerChatEvent and AsyncPlayerChatEvent. Perhaps a config setting and prescribing an anti-spam plugin might be sufficient.

Good idea, you'd just have to make sure it doesn't interfere with the quests editor where you might click the same number more than once, or interfere with legitimately accepting quests with a couple minutes or so delay.

@MrShiluk33 Your options for resolving this are updating to the latest development build and, after running the plugin once, setting clickable-text: false in your config.yml file...
and/or
...use an anti-spam plugin like https://www.spigotmc.org/resources/chatcontrol™-the-ultimate-chat-plugin-500-000-downloads-1-2-5-1-16-4.271/ (not affiliated)


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[ ] I understand that this is not the place to request a token listing.
[ ] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[ ] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

Good

Sorry, your issue will be closed as you did not submit your information in the correct format.


IdentifierExpression is reversed when calling Table after I

I've run into a bug where I("table.column") and I("column").Table("table") give different results in the final sql which is not the documented behaviour:
From("table").Select(I("table.column")) // SELECT "table"."column" FROM "table"
From("table").Select(I("column").Table("table")) // SELECT "column"."table" FROM "table"

Additionally:
I("table.column").GetTable() // table
I("table.column").GetCol() // column
I("table.column").GetSchema() // <blank>
I("column").Table("table").GetTable() // table
I("column").Table("table").GetCol() // <nil>
I("column").Table("table").GetSchema() // column

In the middle of a slight refactor, then Ill take a look at this.

Hi @ssttevee in the new version of goqu I made a few changes that should make this a little more clear. I have added three new methods:

S(schema string) - This will create a new identifier with the schema set
T(table string) - This will create a new identifier with the table set
C(col string) - This will create a new identifier with the column set.

I(iden string) still exists but it is primarily used for parsing an identifier that is seperated by a . character, if you have a specific part of an Identifier (Schema, Table or Col) you should use one of the new methods to be more explicit about which part you are using.
Your example above could change to the following
From("table").Select(I("table.column")) // SELECT "table"."column" FROM "table"
From("table").Select(C("column").Table("table")) // SELECT "table"."column" FROM "table"

//or
t := T("table")
From(t).Select(t.Col("column")) // SELECT "table"."column" FROM "table"

Hope this helps!

@doug-martin Given the changes introduced in 7.0.0 to how identifiers are constructed (goqu.S, goqu.T and goqu.C), this can probably be closed.

@doug-martin Given the changes introduced in 7.0.0 to how identifiers are constructed (goqu.S, goqu.T and goqu.C), this can probably be closed.

Haha yep seems we commented at the same time!

@doug-martin Nice! What are the odds? 😆


Adding pluggable storage support for realtime upload

First phase of pluggable storage support for realtime includes replacing filesystem-level calls with pinotFS calls.
See #3420 for more details

Codecov Report

Merging #3541 into master will increase coverage by 0.06%.
The diff coverage is 63.15%.

@@             Coverage Diff              @@
##             master    #3541      +/-   ##
============================================
+ Coverage      70.8%   70.86%   +0.06%
  Complexity        4        4
============================================
  Files           997      997
  Lines         45760    45767       +7
  Branches       6135     6135
============================================
+ Hits          32400    32434      +34
+ Misses        11235    11203      -32
- Partials       2125     2130       +5

Impacted Files
Coverage Δ
Complexity Δ

...er/api/resources/LLCSegmentCompletionHandlers.java
63.81% <63.15%> (-1.02%)
0 <0> (ø)

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
0% <0%> (ø)

...mpl/dictionary/DoubleOffHeapMutableDictionary.java
65.45% <0%> (-9.1%)
0% <0%> (ø)

...e/operator/dociditerators/SortedDocIdIterator.java
59.45% <0%> (-5.41%)
0% <0%> (ø)

...r/filter/predicate/PredicateEvaluatorProvider.java
65.21% <0%> (-4.35%)
0% <0%> (ø)

...e/operator/dociditerators/BitmapDocIdIterator.java
60.71% <0%> (-3.58%)
0% <0%> (ø)

...inot/transport/netty/NettyTCPClientConnection.java
82.31% <0%> (-3.41%)
0% <0%> (ø)

.../impl/dictionary/BaseOffHeapMutableDictionary.java
81.03% <0%> (-2.88%)
0% <0%> (ø)

...not/broker/requesthandler/RangeMergeOptimizer.java
89.7% <0%> (-1.48%)
0% <0%> (ø)

...ata/manager/realtime/RealtimeTableDataManager.java
41.17% <0%> (-1.48%)
0% <0%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a834a49...343a5bf. Read the comment docs.


fix: update react files to use jsx extension

This PR reapplies the reverted changes from #169 to use the .jsx file extension for the React component files.
Closes #170

The code quality gate has failed but these are existing issues. They're being picked up because of the file renames. I'm going to go ahead with merging these changes since the code quality issues will be fixed in PR #169 .


Add events on app CRs

Toward https://github.com/giantswarm/giantswarm/issues/16981
There was a discussion between @fiunchinho on this, https://gigantic.slack.com/archives/C01P7P3BS2C/p1619601080015300
and I think it would be okay with app-admission-controller to emit events since,

it would be the single endpoint to validate app CRs.
It will emit events when it spots the differences between the specs.

WDYT?
Checklist

[ ] Update changelog in CHANGELOG.md.

Tested in ginger
Events:
  Type    Reason      Age   From                      Message
  ----    ------      ----  ----                      -------
  Normal  AppUpdated  54s   app-admission-controller  version has been changed to `1.1.1`
  Normal  AppUpdated  2s    app-admission-controller  version has been changed to `1.1.0`

Events:
  Type    Reason      Age    From                      Message
  ----    ------      ----   ----                      -------
  Normal  AppUpdated  3m2s   app-admission-controller  version has been changed to `1.1.0`
  Normal  AppUpdated  2m49s  app-admission-controller  version has been changed to `1.1.1`
  Normal  AppUpdated  1s     app-admission-controller  appConfigMap has been resetted

resetted is wrong, right?

I think it looks good! nice job

@rossf7  I checked the kube-state-metrics and it doesn't gather metrics about event resources as default.
https://github.com/kubernetes/kube-state-metrics/blob/master/docs/cli-arguments.md
So we either need to enable it from kube-state-metrics app or gather metrics ourselves. But I doubt we need to do it actually given the fact that the event resources have a 1-hour lifetime as default.
https://github.com/kubernetes/kubernetes/issues/52521
Moreover,  app-admission-controller emits events right just before it would admit app CRs' changes and only if it see the actual difference between old and new spec. (e.g. change from the .spec.version)
So I don't think the number of events would be increased by these changes in none of the cases.
If you still want to have a metric on these events, do you perhaps know any metrics for event resources other than kube-state-metrics?

If you still want to have a metric on these events, do you perhaps know any metrics for event resources other than kube-state-metrics?

@tomahawk28 That's a shame kube-state-metrics doesn't gather this. But the admission controller emits its own metrics so I think we could add our own.
https://github.com/giantswarm/app-admission-controller/blob/867987245b295d4a728a9708663b4ea520ea6efc/pkg/metrics/metrics.go

But I doubt we need to do it actually given the fact that the event resources have a 1-hour lifetime as default.

Yes, that's a good point. Let's see how it goes. We can add a custom metric later if we need one.


Request for containers / docker

I'd be willing to do this one

😀

Closed in ba47939

I might talk a bit about vagrant too here, since I use it for some related tasks (virtual machine management and provisioning), and it's worth contrasting vm's vs containers


⚠ Bofrost.be has degraded performance

In 78f8878, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2383 ms

Resolved: Bofrost.be performance has improved in d5ae84e.


Remove InteractorTestHelper.kt

Description
We're discouraging the use of Interactor tests in favor of using Node tests.
The reasoning here is that unit tests are about units, not classes. And in the case of a node-based architecture, the unit is the node. Also by writing node tests you are also covering the integration of different node parts.
Check list

[X] I have updated CHANGELOG.md if required.
[X] I have updated documentation if required.

@mapm14 can you please update the changelog?

Approved with the issue.
MviCoreExampleNode should not accept node connectors for their children, it looks strange.

it also makes MVI Core example crash


Periodic noise conversion pitch error

The SN76489 periodic noise sounds like a bass bass near A1~A2, but the sound is very high after conversion.
landfex.zip

I noticed this and I think it is not a bug. The periodic noise part shares the same frequency register of AY8910 tone channel C, so unexpected result can be obtained with some songs.
I already tried to use AY8910's envelope to simulate the periodic noise but I had not got good result yet.
Another approach is to multiply the frequency of periodic noise if the channel 2 is not used by other part. I will try such approach in future.

I just thought about it for a while and then I've implemented the functionality to shift the pitch of the periodic noise which can also be controlled by the following option.
  -D periodicNoisePitchShift=n
    Specify the pitch shift amount of the periodic noise conversion. pow(2, -n) will be multiplied to the frequency. The
    default value is 2.

However, it does not allow for fine pitch tuning, so don't expect much. Even if this approach is taken, the bass part of landfex.zip still seems to be detuned. I suspect that the audible pitch of the periodic noise may be different from the theoretical pitch, but I can't actually confirm this with the real SN76489 hardware. If a frequency-pitch table for the periodic noise of the SN76489 exists somewhere, please let me know.
Further, side-effects possibly be introduced by this patch. If you find something wrong, please open the new issue.


Move Report Extension on GitHub to Functions View

Fix: #290

Ideally, I would like to remove it from the Extension title view and add a new View as Help and Feedback and that will happen for the Report Issues for the extension. But want to keep it for the next iteration. So for this release, having Issues with Function Title should be good.


fix(helm): Accept dependency in requirements.yaml from charts directory

This change allow the use of charts from the charts sub-directory of the current chart in requirements.yaml. It checks the version. It leaves the chart in place.
Closes #3221

ping @splisson ^^

Hey @splisson, thanks again for the PR. I noticed there are a ton of changes being made to existing function signatures but no unit tests to cover these cases. Would you mind writing these such that we can ensure the code works the way it should? Thanks!

Sure

I wonder if this is not similar to this PR that I made a while ago.
https://github.com/kubernetes/helm/pull/3987

@sgandon Any updates on this PR? Is the problem fixed? I'm still seeing the problem in 2019. I'd appreciate if you can still see this comment..

It too one year for someone to review my PR #3987, and a few days to fixed proposed changes. Let's hope it does not take another year to have it merged.

It's pretty frustrated to see this happen.. Although I've also found the way to work around it, it would be great if they can merge it... Been tracing this issue for half a year already. Thanks @sgandon.
Happy helming?? Lol

Hi @splisson, sorry for leaving this one dangling for so long. This PR seems much cleaner than the proposed solution in #3987. If you would be willing to rebase this PR, that would be great. If not, pleas elet us know and someone else can carry this PR forwards. Thanks!

it looks like a few stray commits snuck in here (like fca5c6b). Let me know once this has been fixed up and I'll be happy to review again.

I reverted 2 of them
Is that what you meant?
Sébastien

On Oct 1, 2019, at 10:47, Matthew Fisher<EMAIL_ADDRESS>wrote:
it looks like a few stray commits snuck in here (like fca5c6b). Let me know once this has been fixed up and I'll be happy to review again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry @splisson, but a git revert is slightly different than removing the commit from the history.
What I suggest you could do is run a git rebase --interactive master. It will open a new window which you can remove commits from the branch history entirely by removing them from the timeline.
More info here: https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history#interactive-rebase

fixed up in https://github.com/helm/helm/pull/6578. Thanks @splisson! :)

Thanks matt
Sébastien

On Oct 3, 2019, at 15:20, Matthew Fisher<EMAIL_ADDRESS>wrote:
fixed up in #6578. Thanks @splisson! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add a referrer tag to the Feedback module; bump Sentry version

This PR:

Adds a referrer tag to the feedback module
Bumps sentry version to 5.24.2

Production

[ ] Accounts
[ ] Android
[ ] API documentation
[ ] Atlas
[ ] Data
[ ] Geographic Analytics Extension for Tableau
[ ] GL JS Private Preview
[ ] GL JS Seats
[ ] Help
[ ] Homepage
[ ] iOS
[ ] Japan
[ ] Mapbox GL JS
[ ] MTS
[ ] Playground
[ ] Studio manual
[ ] Traffic signs
[ ] Unity SDK
[ ] Vector tiles

Internal

[ ] Docs starter kit
[ ] Documentation
[ ] Platform


[docs] Add documentation for using PFElements in React+TypeScript projects

I'm currently putting a PFElement-based component into a React project written in TypeScript.  Adding PFElements to standard React is easy (Kyle has gone from no project, to a React project with a PFElement in less than 3 minutes), but TypeScript complicates things a bit.
So far, I've run into two things that need to happen to make a PFElement work seamlessly in React+TS.
1. add the element name to the JSX.IntrinsicElements interface
declare global {
  namespace JSX {
    interface IntrinsicElements {
      'rh-edmund-abbott': EdmundAbbottProps;
    }
  }
}

2. create a type representing the attributes of the element
interface EdmundAbbottProps extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLElement>, HTMLElement> {
  product: string;
  version: string;
}

I don't have it all figured out yet.  For example, in step 1, TS complains about augmenting the global scope outside the root module (which is App.tsx in this case).
We may also need to provide a .d.ts file containing all the type definitions.  I'm guessing the code from step 2 would belong in that file, and perhaps other type definitions as well?
@KamiQuasi may have feedback here!

cc @Djfaucette and @zhawkins who have some React experience too and might have ideas/thoughts

I'm also using PFElements in a TypeScript app and the following is all I had to add to my declarations.d.ts file:
declare namespace JSX {
  interface IntrinsicElements {
    "pfe-card": any;
    "pfe-cta": any;
    "pfe-datetime": any;
    etc...
  }
}

Essentially we want the JSX engine to recognize all of those strings as valid HTML/XML, so adding it to an interface works.
We could, maybe, be more specific with the typings we give to tags, but at this stage of the game (not using TypeScript anywhere in our project) don't know that we would have a way to track that effectively as attributes evolve over time.

Is there anything that a component can offer that would help with this for users or is it a case of needing more documentation?

I think we need more docs either way. I can't think of a straightforward solution, but it's probably worth taking a look at component libraries that use TypeScript for some inspiration.

We can add this to https://github.com/patternfly/patternfly-elements/blob/58b1ae602790a4532c9dc485c2f8bb36f81a1d44/docs/framework-integration/react.md


Unable to process films/TV shows with commas in "title"

Version Number
1.19.0
What branch are you on?
master
Describe the Bug
When attempting to add a film with a comma in the title, it never actually locates the film. There might already be a fix for this, but I also noticed that search behavior was modified in #100, so I wanted to check if this was going to be in conflict. An example of a film: "Crazy, Stupid, Love". This would need to be processed as one title, not 3, but If I am understanding correctly, #100 modified search behavior by parsing the search into 3 separate titles.
Is there a simple way around this, other than defining an alt_title?
There is no thrown exception, it simply ignores the title and continues to process.
Regards,
K
Relevant Collection/Overlay/Playlist Definition
No response
Logs
No response

Do you have an example of what it is you are trying to run?
If a string has a comma, you should wrap the string in quotation marks otherwise it is read as a list

I discovered that this was not actually the issue!~ I really appreciate the quick response!
I had a colleague check my work, and my deduction was incorrect. That same colleague happens to be a movie buff and pointed out my error in the title:
Correct title: "Crazy, Stupid, Love." A PERIOD!? I didn't think to actually check against the IMDB..
Another example that he was able to correct: "Dude, Where's my Car?" title had the comma and the apostrophe, but obviously not the question mark.
For posterity, I was using the following:
<collection_name>
plex_search:
any:
title.is:
- "Crazy, Stupid, Love" # was missing the period
P.S. I joined the discord, so if I run into similar issues - Ill ask there first before submitting an issue =)

I have made multiple mistakes that lead to an incorrect deduction. I am going to let this issue rest and revisit another time. We were able to bypass the issue by setting an alt_title.
Regards,
K


Compaction Failures Similar to #2941 on Upgrade From 2.x to 3.1.1

Description
we're seeing a similar issue to https://github.com/apache/couchdb/issues/2941 with random compactions on shards when upgrading from 2.x to 3.1.1. But might be completely unrelated. The compaction metadata file blew up to about 500gb over 24 hours for a shard that is about 30gb constantly hitting this error. Similarly we're also seeing large disk io on the nodes this is happening on versus nodes this is not happening on like in #2941. I've deleted the compaction files like discussed in the previous issue and seems to be working fine now, the compaction is running and the errors have stopped. disk io has gone back down.
<0.5181.0> -------- exit for compaction of ["shards/60000000-7fffffff/core_activations.1589336264"]: {badarith,[{couch_file,get_pread_locnum,3,[{file,"src/couch_file.erl"},{line,730}]},{lists,map,2,[{file,"lists.erl"},{line,1239}]},{lists,map,2,[{file,"lists.erl"},{line,1239}]},{couch_file,read_multi_raw_iolists_int,2,[{file,"src/couch_file.erl"},{line,719}]},{couch_file,handle_call,3,[{file,"src/couch_file.erl"},{line,507}]},{gen_server,try_handle_call,4,[{file,"gen_server.erl"},{line,636}]},{gen_server,handle_msg,6,[{file,"gen_server.erl"},{line,665}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,247}]}]}
-------- CRASH REPORT Process (<0.32443.1691>) with 3 neighbors crashed with reason: bad arithmetic expression at couch_file:get_pread_locnum/3(line:730) <= lists:map/2(line:1239) <= couch_file:read_multi_raw_iolists_int/2(line:719) <= couch_file:handle_call/3(line:507) <= gen_server:try_handle_call/4(line:636) <= gen_server:handle_msg/6(line:665) <= proc_lib:init_p_do_apply/3(line:247); initial_call: {couch_file,init,['Argument__1']}, ancestors: [<0.3352.1692>], message_queue_len: 0, messages: [], links: [<0.3352.1692>], dictionary: [{couch_file_fd,{{file_descriptor,prim_file,{#Port<0.1924847>,92}},"..."}},...], trap_exit: false, status: running, heap_size: 28690, stack_size: 27, reductions: 13483
an example of a shard I haven't cleaned up yet
-rw-r--r-- 1 1501 1501  16G Dec  9 17:13 core_activations.1589323247.couch
-rw-r--r-- 1 1501 1501 4.0G Dec  9 17:11 core_activations.1589323247.couch.compact.data
-rw-r--r-- 1 1501 1501 159G Dec  9 17:13 core_activations.1589323247.couch.compact.meta
Steps to Reproduce
Upgrade to 3.1.1 from 2.x mid compaction
Expected Behaviour
Compaction to complete as expected
Your Environment
If any specific environment details would be helpful just let me know

CouchDB version used: 3.1.1
Browser name and version:
Operating system and version: centOS

Are you able to test the fix that was merged in https://github.com/apache/couchdb/pull/3001 ?

I was under the impression the fix was included in 3.1.1 which we directly upgraded to from 2.x according to the release notes under bug fixes
https://docs.couchdb.org/en/latest/whatsnew/3.1.html

Yup, you're right, my mistake.
@nickva Does this look like anything that #3001 would have missed?

This looks like a different failure from #3001.
@bdoyle0182 what version of 2.x was running on the old nodes? What Erlang VM version, OS (which version of CentOS), and file system was used?
Looking through the issues so far it's first instance of badarith error from that part of the code I think.

Looking at the code the crash is coming from https://github.com/apache/couchdb/blob/23b98345f0db38214eaad33b159cf10dd9deaf72/src/couch/src/couch_file.erl#L729-L730
It looks like Pos (position) there is not an integer but something like undefined or eof.
That gets called from couch_file:pread_terms which is only called from the compactor's copy_meta_data: https://github.com/apache/couchdb/blob/23b98345f0db38214eaad33b159cf10dd9deaf72/src/couch/src/couch_bt_engine_compactor.erl#L554-L555
or compactor's merge_doc_ids https://github.com/apache/couchdb/blob/23b98345f0db38214eaad33b159cf10dd9deaf72/src/couch/src/couch_bt_engine_compactor.erl#L662-L669

Current couchdb: 3.1.1
Previous couchdb: 2.3.1
Current erlang: <IP_ADDRESS>
Previous erlang: 19.2
centos: CentOS Linux release 7.9.2009

Just to update the compaction did successfully complete after being re-triggered so just deleting the compaction files seems like a fine remediation.

@bdoyle0182 makes sense, thanks for confirming. This probably is an upgrade issue, we have upgrade code to handle the main .couch files but not necessarily the .compact.* files I think.
@davisp I wonder if we can automatically detect the upgrade scenario and auto-delete or at least ignore the older compaction files when the format is upgraded?
We should update the docs to advise users to complete compactions on the 2.x nodes before they are upgraded to 3.x, or alternatively to delete the .compact.meta and .compact.data after the upgrade.


JGRP-2848 Composite message additions

This change borrows the optimization from BatchMessage to not serialize dest and src for each message. And it adds the possibility to add a Collection of messages.

Applied manually (instead of rebasing)


Django 1.9 compatibility - AppRegistryNotReady

After upgrading to django 1.9 and running python manage.py check, I get the following error:
Traceback (most recent call last):
  File "./manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/core/management/__init__.py", line 350, in execute_from_command_line
    utility.execute()
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/core/management/__init__.py", line 324, in execute
    django.setup()
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/apps/registry.py", line 85, in populate
    app_config = AppConfig.create(entry)
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/apps/config.py", line 90, in create
    module = import_module(entry)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/__init__.py", line 9, in <module>
    from permission.utils.logics import add_permission_logic
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/utils/logics.py", line 6, in <module>
    from permission.logics import PermissionLogic
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/logics/__init__.py", line 7, in <module>
    from permission.logics.author import AuthorPermissionLogic
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/logics/author.py", line 6, in <module>
    from permission.conf import settings
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/conf.py", line 10, in <module>
    from permission.handlers import LogicalPermissionHandler
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/handlers.py", line 5, in <module>
    from permission.utils.permissions import get_app_perms
  File "/path/to/virtualenv/lib/python2.7/site-packages/permission/utils/permissions.py", line 9, in <module>
    from django.contrib.auth.models import Permission
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/contrib/auth/models.py", line 4, in <module>
    from django.contrib.auth.base_user import AbstractBaseUser, BaseUserManager
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/contrib/auth/base_user.py", line 49, in <module>
    class AbstractBaseUser(models.Model):
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/db/models/base.py", line 94, in __new__
    app_config = apps.get_containing_app_config(module)
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/apps/registry.py", line 239, in get_containing_app_config
    self.check_apps_ready()
  File "/path/to/virtualenv/lib/python2.7/site-packages/django/apps/registry.py", line 124, in check_apps_ready
    raise AppRegistryNotReady("Apps aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.

The issues seems to be permission/utils/permissions.py", line 9 where it is trying to import from django.contrib.auth.models import Permission during project setup.

Hum... Thanks for reporting. We will check it. Probably the line should be loaded in each functions I guess.

A second compatibility break is in permission/compat.py which is throwing:
cannot import name 'add_to_builtins
    try:
        from django.template.base import add_to_builtins
    except ImportError:
        from django.template.loader import add_to_builtins

https://docs.djangoproject.com/en/dev/releases/1.9/#django-template-base-add-to-builtins-is-removed

We are working on this https://github.com/lambdalisue/django-permission/pull/50 :-)


Refactor templates to not need to use rice box

There's no real need to not just put the templates into .go files in the first place.

I did some refactoring work, and because we need to iterate over all the page contents, right now using rice seems to be okay for those particular templates. We should avoid using them in other places however.


Default ® to 250.

Initializing the register ® to 0 does not save bytes compared to 0. Initializing the register to 250 would save 2 bytes. The number 250 is certainly useful, such as encoding lists of shorts using  “<encoding>’b250.

Doesn't “<encoding>‘‘ achieve the same effect, without the constant?

Ah, yes. I forgot about that. Closing.


chore: update @prettier/plugin-xml to v2.0.1

It's not released yet, but there are some hotfixes.
https://github.com/prettier/plugin-xml/tags

Prettier v2.6.1 is released.
https://github.com/prettier/prettier/releases/tag/2.6.1


quick patch for login in passive mode

Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
-SSOAgentConfig is singleton, so changing data with request should be synchronized or use copy of data
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
https://github.com/asgardio/asgardio-java-saml-sdk/pull/8
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]

use stressTest from https://github.com/boulik/tomcat-saml-agent-stressTest

Checklist (for reviewing)
General

[ ] Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
[ ] Is the PR labeled correctly?

Functionality

[ ] Are all requirements met? Compare implemented functionality with the requirements specification.
[ ] Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

[ ] Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
[ ] Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
[ ] Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

[ ] Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
[ ] If this is a bug fix, are tests for the issue in place?  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
[ ] If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

[ ] Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[ ] Are all UI and API inputs run through forms or serializers?
[ ] Are all external inputs validated and sanitized appropriately?
[ ] Does all branching logic have a default case?
[ ] Does this solution handle outliers and edge cases gracefully?
[ ] Are all external communications secured and restricted to SSL?

Documentation

[ ] Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
[ ] Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
[ ] Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

Closing the PR as no improvements were done to the existing logic.

Hi Gayashan,
i wrote issue for this pull request - https://github.com/asgardio/asgardio-tomcat-saml-agent/issues/27.
Could you reopen this pull request? I made changes from your comment.
Thank you.

Hi Gayashan,
any update for this pull request?
Thank you.


Can't talk to Lanette/Not able to pick up Pokemon

Hi, I think my english Pokemon Emerald save got into a glitched state. It started out pretty smooth, but then some weird stuff happened near the end of the transfer.
I was transferring from my english copy of Crystal, and it linked up just fine. I wanted to transfer over my shiny Lugia and Ho-oh (after around +50 hours lol). It was able to see them just fine, but then this is where things got weird... The names were all random characters, but everything else looked fine with them. I was hoping this was just a visual glitch, but when I confirmed, usually the GBC game is supposed to reset itself after a completed transfer, but this did not, it stayed on the transferring screen until I reset the game, and I made the discovery that they were not gone from my Crystal game thankfully. But then I checked out my Emerald game and went to talk to Lanette, she didn't say her special dialogue she would usually say to give the transferred Mons... So I decided to try the transfer again, but this time with a different cable, I'm no longer able to transfer because it says I haven't picked my Mons yet...
So now I'm here, hoping that if I provide my save file, that maybe you could look at it? Keep in mind, I'm still able to play the game normally, just not able to use the tool anymore.
Any help will be greatly appreciated!

The location to pick up the Pokemon has been updated. In Emerald it’ll be southeast of the Pokemon Center in Sootopolis.

Oh good! Thank you so much! This was it!

Glad you got it figured out! The glitched names aren't supposed to happen (obviously lol). I want to try and figure out what went wrong:

Did you start a transfer, cancel it, and then do another transfer without reloading the program?
Were the names of the Pokemon still glitched when you received them in Emerald?

No, the transfer was a clean start, both Crystal and PT. And yeah, the names of the pokemon were still glitched after transfer, and even a hidden Parasect that I didn't see when confirming the transfer. Something I will say is that I did do a transfer with Silver as well, just to make sure it wasn't the mons that were glitched or something. And that worked perfectly, no glitched names or anything like what happened with Crystal. I'll try and perform the transfer again with Crystal and provide screenshots/footage this time. But other than that, I love this tool!

Thanks for the confirmation!! That's really strange that it would specifically have issues with the nicknames and not anything else... I'll definitely do some more research and see what happened- this isn't the only time this issue has come up.


Single field validation request fails when data model path contains æ,ø,å

Description of the bug
When triggering single field validation, we pass the full path in the data model to the backend when validating. If the path contains æ. ø. or å (or probably any other invalid characters), the backend seems to fail with a 400 response.
We should probably wrap the value with encodeURIComponent() as we do other places. Make sure this works on the backend and is received correctly in custom code.
Steps To Reproduce

Have a data model path containing æ, ø or å
Trigger single field validation on it

Additional Information

https://altinn.slack.com/archives/C02EVE480G2/p1696931326644729
#1506
#979

Closing this, as single field validation is no longer a thing in v4+, so this should no longer be an issue.


v4 docs Missed navbar color scheme name changes

Change d6b6a20a0daaed70ec6f395dd813ea460b394e6c missed two doc mentions
of previous names when changing to new:

.navbar-default  -->  .navbar-light
.navbar-inverse  -->  .navbar-dark

Thanks!


_trans_status set outside a transaction

If any query fails it sets _trans_status to FALSE. This causes any subsequent transaction (using trans_begin() or trans_start()) to fail as _trans_status is only reset during trans_complete().
It is possible to get a query failure, fix the issue and then attempt a transaction. The way the code works not the transaction will always fail even though all the queries within the transaction were successful. Shouldn't _trans_status be set to true during trans_begin when the 'START TRANSACTION' is done?

On looking further the issue is bigger than I thought. The documentation has the following description for "strict mode";
"When strict mode is enabled, if you are running multiple groups of transactions, if one group fails all groups will be rolled back."
That is not true as transaction will be committed when level 0 of the transaction is reached.  As the code stands now the a query  failure in or out of a transaction will cause all future transaction to fail. A query failure will have no effect on and transaction that has been committed.
Query faulure only effect previous queries is the transactions have been nested. Take a look at the following;
$this->db->trans_start();
//first queries
$this->db->trans_complete();
$this->db->trans_start();
//second queries
$this->db->trans_complete();
$this->db->trans_start();
//third queries
$this->db->trans_complete();
If the first queries complete it will be committed at the first trans_complete(). If the second queries do not complete the first transaction can not be rolled back as it has already been committed. The third  queries will roll back only in "strict mode".
Look at a nested query;
$this->db->trans_start();
//some transaction
$this->db->trans_start();
//inside transaction
$this->db->trans_complete();
//last queries
$this->db->trans_complete();
In this case the commit only happens on the outside trans_complete(). Therefore all previous queries, after the first trans_start(), are rolled back. The trans_strict flag is meaningless as it only effects resetting on the outside trans_complete().
The issue comes in choosing where to reset the _trans_status flag. Currently it is set in trans_complete(). The problem with it being there is that queries before the transaction can set that flag to false and the transaction will fail.
I think it should be done in trans begin and the following line should be changed;
$this->_trans_failure = ($test_mode === TRUE) ? TRUE : FALSE;
Should be ;
if ($this->trans_strict === FALSE)
{
$this->_trans_status = ($test_mode === TRUE) ? FALSE : TRUE ;
}
This resets the _trans_status flag on the outermost transaction with strict mode off and makes test_mode work. Currently test mode does not work as _trans_failure in not accessed anywhere. In the event that "strict mode" is on subsequent transactions will fail if any query fails. Right now any transaction fails if any previous query fails reguardless of "strict mode".

Joe
You’re gonna have to explain this one to me
M
From: jklovanc
Reply-To: bcit-ci/CodeIgniter
Date: Tuesday, August 4, 2015 at 4:46 PM
To: bcit-ci/CodeIgniter
Cc: Podium 1
Subject: Re: [CodeIgniter] _trans_status set outside a transaction (#4026)
On looking further the issue is bigger than I thought. The documentation has the following description for "strict mode";
"When strict mode is enabled, if you are running multiple groups of transactions, if one group fails all groups will be rolled back."
That is not true as transaction will be committed when level 0 of the transaction is reached. As the code stands now the a query failure in or out of a transaction will cause all future transaction to fail. A query failure will have no effect on and transaction that has been committed.
Query faulure only effect previous queries is the transactions have been nested. Take a look at the following;
$this->db->trans_start();
//first queries
$this->db->trans_complete();
$this->db->trans_start();
//second queries
$this->db->trans_complete();
$this->db->trans_start();
//third queries
$this->db->trans_complete();
If the first queries complete it will be committed at the first trans_complete(). If the second queries do not complete the first transaction can not be rolled back as it has already been committed. The third queries will roll back only in "strict mode".
Look at a nested query;
$this->db->trans_start();
//some transaction
$this->db->trans_start();
//inside transaction
$this->db->trans_complete();
//last queries
$this->db->trans_complete();
In this case the commit only happens on the outside trans_complete(). Therefore all previous queries, after the first trans_start(), are rolled back. The trans_strict flag is meaningless as it only effects resetting on the outside trans_complete().
The issue comes in choosing where to reset the _trans_status flag. Currently it is set in trans_complete(). The problem with it being there is that queries before the transaction can set that flag to false and the transaction will fail.
I think it should be done in trans begin and the following line should be changed;
$this->_trans_failure = ($test_mode === TRUE) ? TRUE : FALSE;
Should be ;
if ($this->trans_strict === FALSE)
{
$this->_trans_status = ($test_mode === TRUE) ? FALSE : TRUE ;
}
This resets the _trans_status flag on the outermost transaction with strict mode off and makes test_mode work. Currently test mode does not work as _trans_failure in not accessed anywhere. In the event that "strict mode" is on subsequent transactions will fail if any query fails. Right now any transaction fails if any previous query fails reguardless of "strict mode".
—
Reply to this email directly or view it on GitHubhttps://github.com/bcit-ci/CodeIgniter/issues/4026#issuecomment-127797894.

What is unclear?

@jklovanc I got some clues from what you wrote, but the sheer size of your comment and it going back and forth between different issues does make it unclear.
The original issue reported by @keynote is fixed with the above commit. Please open a new one for what else you see as problematic, and possibly try to format it better. :)

I am actually both people that submitted. The code change I submitted needs to be done in every driver and I do not have the time or inclination to fix your code. I tried to re-submit but the system blanked my input half way through editing. It goes back and forth a bit because there are two issues that are intertwined.  Maybe this will be a better explanation.
First transaction after a failed query always fails.
All drivers use  _trans_status to track is a query has failed. It uses true on no failure and false on failure. That variable is set in three places;

True as a default on initialization.
False if a query fails.
True in trans_complete() if "strict mode" is of and the transaction is at nesting level 1. This is done after the rollback is done.
Take a look at the following scenario.
The class is initialized. This will set _trans_status to true.
A query fails. This will set _trans_status to false
A transaction is started. No change to _trans_status. It is still false.
Queries complete correctly.  No change to _trans_status. It is still false.
Trans_complete() is run.

Since _trans_status is false trans_rollback() will be run and all queries will be ignored.
If trans_strict is false, _trans_status is set to true.

As you can see the query ran before transaction will cause the transaction to rollback even though no queries failed in the transaction. This happens not matter what "strict mode" is set to.
Another issue I found was that there is a variable _trans_failure that is set in trans_start() but never used.
Solution
The following changes need to be made to all the drivers as the problem exists in every driver.

The code to update _trans_status in trans_complete() needs to be removed.
The following changes need to be made to trans_start();

remove the following line.

$this->_trans_failure = ($test_mode === TRUE) ? TRUE : FALSE;

replace with the following code;

if ($this->trans_strict === FALSE)
{
$this->_trans_status = ($test_mode === TRUE) ? FALSE : TRUE ;
}

I honestly do not understand how your forking gets code back into the main repository.

After you've made those changes, all you need to do is to create a "Pull Request" (you'll have a button for that), which is basically the same as telling us this "I've made some changes that I want you to have, you can get them from repository X, branch Y." The difference being that we don't have to do that manually and it is easier to look at the diff, comment back and forth with you on it, automate testing, etc.
The GitHub Help pages should be helpful if you can't quite understand it yet.
I'll continue the rest of the conversation in #4032 once I go through all the details and relevant pieces of code. :)


Use FQNs in Javadocs

In some cases Javadocs need to reference other classes. If the code does not use the referenced class, it does not import it, and in order to reference this class and not have a full name (which is hard to read) we currently import the class. This is not good because it obfuscates the real dependencies of the importing class.
In order to avoid this, we need to use the following syntax in links:
/**
 * ...
 * If we need to create a {@link org.spine3.base.Command Command}...
 * ...
 * {@linkplain org.spine3.event.EventBus#post(Event) Posting to EventBus} can be done ...
 *
/

Make sure to use short class name or any meaningful text replacement instead of just FQN. We do not want FQNs in Javadocs (unless there is a really good reason for this).
Please  update:

the code which currently imports in order to reference a class in Javadoc. Please update all the sub-projects.
the coding guidelines so that all future use cases follow the above convention.

@alexander-aleksandrov, please pay attention to {@linkplain } syntax. There's a difference with {@link }.

@alexander-aleksandrov please see if we can turn an inspection in Codacy that can help us spotting  such issues automatically.

Started to work on this. You can see PR here.

It is done please review.

Add to JavaCodeStyle changes about FQN in Javadoc

@alexander-aleksandrov please have a better code sample. Do not use BNF, please.

@alexander-yevsyukov Issue resolved and can be closed.


Impossible to create a Rolling Node + Trying to change theme without success

Quite New to Xcode and AudioKit,
So for my App,
I have tried many times to changes the "theme" of Slider Colours.
I change it in the "Common" files, in the "AKView" file, but nothing happens in my project...
What should I do ?
Also, is there a working example of a rolling output node out there ? I'm having a lot of difficulties implementing it...
Thanks  ! :)

I use the rolling plot daily on an app I am developing, so I know it works.  I am able to change its color no problem.  Could you share a project with me so I can follow up appropriately?  There's not enough information for me to keep this open as an issue, and it probably should have been posted to StackOverflow instead.  Anyway, let me know what I can do to help - a shared project would be best.


Cannot use EventStreams.eventsOf with MenuItem

 MenuItem menuItem = ...;
 EventStream<ActionEvent> stream = EventStreams.eventsOf(menuItem, ActionEvent.ACTION);

Doesn't work because MenuItem doesn't extend Node.
This is just a minor inconvenience because I can simply adjust that method for MenuItem.

You are right, thanks for reporting.
A while back I created a ticket asking for a common superinterface for objects that receive events. I included Node and Scene as examples, and now I added a comment about MenuItem.
In the meantime, I can add the method to EventStreams.


implement scoped-slots instead of DOM manipulation

.. but it's not user friendly to pass templates in parent components for e.g. adding an icon to a button component


Change working directory for Python actions to allow relative paths

Fixes #2095.
FYI @cclauss

pg2/1408 approved.

I'm going to stash this as part of merging #1940.


[Feature Request]: Syncing with Ente Auth?

What is your idea?
I don't know how far of a stretch this is (probably too far) but both apps are open source
if it was possible to make 2fa guard as the front end of the ente auth windows app
that would be great as it would allow syncing between different devices while using that nice design of 2fa guard

Hello, thanks for your request.
This feature is out of the scope of this project. It would not only require a lot of work, but it could easily break due to changes in the storage libraries used by ente auth. You can export and import tokens manually from Ente auth to 2FAGuard and vice versa.


Startup name

Despite everything working fine so far, I've run into an issue related to the startup name. Even though i  changed the name in the builder, after creating the client, the application still keeps its name "Quasar Client". I don't know if I did something wrong or that it's a bug.

It changed later.


Add branch protection rule: Require linear history

Enforcing a linear commit history prevents collaborators from pushing merge commits to the branch. This means that any pull requests merged into the protected branch must use a squash merge or a rebase merge. A strictly linear commit history can help teams reverse changes more easily. it also makes it easier to review the Git timeline, as it won't look like a giant ball of spaghetti.

/assign @GuoRentong

/assign @GuoRentong

/assign @jeffoverflow

/close


Dev container runner

Change dev container dockerfile/launch file to work with VS Code
Add --passivesetup to attempt to run setup but accept failure without crashing the application
Fixes tornado's empty-list issue with options

Made an error in branch selection; fixed.


NPM Package

Hi,
If is possible, please, add support for npm package.
Thanks

NPM package is already there. See it here


Followup PR for host without a owning cluster (6894)

@gmcculloug @bdunne
Please Review

@billfitzgerald0120 Can you change the commit message and PR title to reflect what this change actually fixes or tests.  In the commity message body, perhaps reference the corresponding upstream PR that this add tests for?
We really shouldn't reference downstream specifics like "5.5.z" unless it's necessary to explain something.

Updated title for better explanation of fix.
Needed to fix the spec test to be consistent with the merged one.
Removed MiqServer.seed(s) and add stub(s) for :allowed_storages.

@billfitzgerald0120 Please also update the commit message...if you need help someone can probably help you

@gmcculloug
Please Review


[TOPI] Conv2d Schedule for Intel HD Graphics Target fails and produces wrong output

nnvm.compiler.build()  fails for intel_graphics target.
sample model https://s3.amazonaws.com/download.onnx/models/opset_3/resnet50.tar.gz
error log
Traceback (most recent call last):
  File "C:\Users\rg\Documents\Visual Studio 2015\Projects\nnvm_tvm_resnet\src\nnvm_tvm_igpu_.py", line 144, in <module>
    graph, lib, params = nnvm.compiler.build(sym, tvm.target.intel_graphics(), input_dict, params=params)
  File "C:\tvm\nnvm\python\nnvm\compiler\build_module.py", line 294, in build
    graph = graph.apply("GraphFusePartition").apply("GraphFuseCompile")
  File "C:\tvm\nnvm\python\nnvm\graph.py", line 234, in apply
    check_call(_LIB.NNGraphApplyPasses(self.handle, npass, cpass, ctypes.byref(ghandle)))
  File "C:\tvm\nnvm\python\nnvm\_base.py", line 75, in check_call
    raise NNVMError(py_str(_LIB.NNGetLastError()))
nnvm._base.NNVMError: TVMCall CFunc Error:
Traceback (most recent call last):
  File "C:\tvm\python\tvm\_ffi\_ctypes\function.py", line 54, in cfun
    rv = local_pyfunc(*pyargs)
  File "C:\tvm\nnvm\python\nnvm\top\nn.py", line 164, in compute_contrib_conv2d_NCHWc
    strides, padding, layout, out_layout)
  File "<decorator-gen-40>", line 2, in conv2d_NCHWc
  File "C:\tvm\python\tvm\target.py", line 345, in dispatch_func
    return dispatch_dict[k](*args, **kwargs)
TypeError: _decl_conv2d() takes from 6 to 7 positional arguments but 9 were given

call stack hits from here :
https://github.com/dmlc/tvm/blob/fd1a572058aef5a07e1e1032e26e67fe1906f9b2/nnvm/python/nnvm/top/nn.py#L169-L170
https://github.com/dmlc/tvm/blob/fd1a572058aef5a07e1e1032e26e67fe1906f9b2/nnvm/python/nnvm/top/nn.py#L192-L193
and further calls intel_graphics schedules below .
But conv2d implementation for Intel graphics missed  " layout," & " out_layout," function parameters.as shown below :
https://github.com/dmlc/tvm/blob/fd1a572058aef5a07e1e1032e26e67fe1906f9b2/topi/python/topi/intel_graphics/conv2d.py#L60
https://github.com/dmlc/tvm/blob/fd1a572058aef5a07e1e1032e26e67fe1906f9b2/topi/python/topi/intel_graphics/conv2d.py#L99
On solving this error by passing default prarmeters as 'layout =None" & " out_layout=None" , It compiled successfully .
But now the prediction output results[inference]  turned to be wrong  with tvm.target.intel_graphics() !
[ I tested in default mode ie. target='opencl' the prediction result is good ] .
why the Inference output changes when using tvm.target.intel_graphics() ?

@rajh619 Are you using opt_level= 3? It seems that recent PRs have changed the layout transferring api. I haven't update accordingly yet. But it should work for opt_level = 2. I have tested on Intel Graphics HD500. Also which hardware are you running on?

@Laurawly   Yes you are correct ,i was using opt_level=3 .
I have tried it with opt_level=2 and found it is working . but as i said before while using opt_lvl=2 , the prediction accuracy changes a lot , which is a major concern as the output changes !
I have a test script to test here . If i set target='opencl'  the prediction is correct .But if target is set to tvm.target.intel_graphics() ,the prediction is wrong .
@tqchen  this issue is w.r.t current implementation . should  we move to the forum ?

@rajh619 What's your hardware specification? I tested both the performance and accuracy on Intel HD graphics  500 and there's no problem on that hardware.

@rajh619  the community will always trying to solve the problem together, be it on forum or issue ;) The forum is preferred because issues are for actionable items we aggressively close issues and expect issues to be active actionable items that can get closed in an expected time span (so we won't have pile of  issues that get missed).

@rajh619 can you check if _alter_conv2d_layout for intel HD is running when you turned opt level 3? I think instead of this, x86's _alter_conv2d_layout is running. This is the cause of the bug.

@Laurawly  my hardware specs are : iGPU -Intel HD 4600 and CPU is - intel core i5 (4590s) ,8GB .
Using  opt_lvl=2 , the accuracy changes .
I have tried the resnet50 model mentioned below :
https://s3.amazonaws.com/download.onnx/models/opset_3/resnet50.tar.gz
you can load the model and check the change in  accuracy with this script :
https://gist.github.com/rajh619/bbcbb2e776c7c24a016bb61bf1a2d156

@Laurawly  I have an update :
I tested in Intel HD Graphics 520 .The prediction is correct  for opt_lvl =2 .
Also i modified the code , to use opt_lvl =3 ,and the prediction is correct.
The problem i think is ,  I was using Intel HD 4600  which is not  "Intel® Processor Graphics Gen9" category . Also i can see improvement in performance too !
It will be great if schedules for other operations like dense ,pooling etc  is available.
Thanks

Thanks for all the discussions, this issue is closed, let us move further discussions to the forum


unable to log in side Then and given

up to date to the latest version 1.16.0 (2019-08-28)
When doing.
Given('some description', () => {      cy.log("12321");      Cypress.log({message: '123213'});       console.log('sdfsdf');  });
or
When('some description', () => {      cy.log("12321");      Cypress.log({message: '123213'});      console.log('sdfsdf'); });
nothing gets logged anywhere... any idea's ? or is this a bug?

Thanks for the report. I don't have a way to verify today but Could you please try 1.12.0? Just change it in the package.json and run npm install
That will give me something to start thinking about ;)

i will now will report in few min

no succes :-1: not with  1.16.0 or with 1.12.0

seem to be something else non issue thnx mistake on my end


Remove broken/obsolete test

This test is currently failing 1/3 of the time. The order of Services()
is not defined, AND its implemented differently in all registries. We
already have other tests that verify this works properly if we have
different times set on the service (which does have a defined ordering),
so this test is just validating incorrect assumptions.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
26545a0b9b7966d241db003f1a47587676c6f4c8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
26545a0b9b7966d241db003f1a47587676c6f4c8
link
/test lint_istio

gencheck_istio
26545a0b9b7966d241db003f1a47587676c6f4c8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
26545a0b9b7966d241db003f1a47587676c6f4c8
link
/test gencheck_istio

lint_istio
ef0b53e358b1b2fabfd97194f5ce300e1949ad4f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ef0b53e358b1b2fabfd97194f5ce300e1949ad4f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ad7ce4faa033d0d5118c6a0e5baee9564df2f514
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
ad7ce4faa033d0d5118c6a0e5baee9564df2f514
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
ad7ce4faa033d0d5118c6a0e5baee9564df2f514
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest