Android Crash with Expo

Testing the @maplibre/maplibre-react-native with Expo 49 on Android and iOS.   Expo config plugin works. Successfully built on EAS for both Android and iOS. iOS launches and renders. Android launches and crashes on MapView.

MapboxConfigurationException
Using MapView requires calling Mapbox.getInstance(Context context, String apiKey, WellKnownTileServer wellKnownTileServer) before inflating or creating the view.

com.mapbox.mapboxsdk.maps.MapView in initialize at line 138
com.mapbox.mapboxsdk.maps.MapView in <init> at line 126
com.mapbox.rctmgl.components.mapview.RCTMGLMapView in <init> at line 160
com.mapbox.rctmgl.components.mapview.RCTMGLAndroidTextureMapView in <init> at line 14
com.mapbox.rctmgl.components.mapview.RCTMGLAndroidTextureMapViewManager in createViewInstance at line 29
com.mapbox.rctmgl.components.mapview.RCTMGLAndroidTextureMapViewManager in createViewInstance at line 12

It seems like a MapBox Api Key is required on Android even if you aren't using Mapbox tiles.
Steps to Trigger Behavior

Implement MapView without sources in order to render the default MapLibre style.
Do not setAccessToken on the MapLibreGL configuration.
Build on an android device or simulator
Launch the app and it will crash on MapView.

Confirm an Mapbox Access Token resolves the issue

Add MapLibreGL.setAccessToken(TOKEN)
Build and launch. Will not crash on MapView.

This problem only affects Android. iOS works fine without the Mapbox Access Token.
Version(s) affected

Platform: Android
OS version: Android 10
Device type: moto g(7)
Emulator/ Simulator: no
Development OS: OSX 13.5
maplibre-react-native: 9.0.1
React Native Version  0.72.3

Closing. It's right there in the Getting Started Readme and Android/install.md.

Note that the Android SDK is slightly peculiar in that it requires setting an access token, even though it will be null for most users (only Mapbox authenticates this way)


Error while running migration

After build my plugin with the GUI
I try to run a migration and I get
mkdir(): No such file or directory
after debug, I've found
"/var/www/html/Modules/Wharehouse/Database/migrations/" // vendor/tomatophp/filament-plugins/src/Services/Concerns/GenerateMigrations.php:18
I'm on MacOsx with Colima + Dev environment

fixed

Thanks, i will try tonight


chore: Developer branch for nim

Only nim will be passing tests since I changed the c function names and only modified that code to match.

c functions needed to be changed because the linker was detecting duplicate symbols with c-kzg (since the c functions are named exactly the same thing)

Renaming the methods and the the nim changes can be ported to master


package.json: added missing caret in quasar-framework version

Tiny PR like asked in http://forum.quasar-framework.org/topic/94/quasar-v0-9-1-is-out/6

Thank you!


More helpful error messages

Rather than the user having to scroll through the mess of the backend debugger log in the Terminal, we can send the exception message along with the event type back to the extension, which then logs it in a distinct "Daffodil" Output tab.
The user then clicks the "show logs" to switch to that tab.
The current errors are:

ErrorEvent.UnhandledRequest: if the backend receives a type of request it doesn't understand
ErrorEvent.LaunchArgsParseError: if the backend can't parse the launch args when starting a DAP session
ErrorEvent.RequestError: the backend had a problem executing a request; this includes runtime exceptions from Daffodil like schema compilation
ErrorEvent.SourceError: used during an experiment for having backend-provided source files, not used currently
ErrorEvent.UnexpectedError: used when a watch expression can't be evaluated; this error seems to be redundant and could perhaps be merged with RequestError

The PR doesn't display the particular the error type, only the underlying message. The user can look at the regular logs for the details.
Fixes #931.

What types of error messages are affected by this change?

@arosien How do we test this PR?

@arosien For future notice, normally 2 green checkmarks are desired before merging in a PR.

@arosien For future notice, normally 2 green check marks are desired before merging in a PR.

there were 2: @hdalsania and @shanedell

I don't think @hdalsania is a Daffodil committer or PMC. Although we definitely appreciate reviews from non-committers/PMC, and doing so is a good way to show commitment to the project and earn the merit to become one, their votes do not count towards the required 2 +1's ASF requires merge. The green checkmark is a good indication of this since non-committers only get a grey checkmark when they approve a PR.


Fix test failures

Fixes remaining failures due to new interfacee of  onyo new and turns remaining cases of raise RuntimeError("TODO: ... into pytest.skip("TODO.... This should re-establish a "green" CI pipeline (provided #468 merged), so we can stop the hackathon related phase of merging things that don't pass.

LGTM


Fix problematic backward of take & embedding

Description
Fix for #11314
Checklist
Essentials

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Modify the backward of take and embedding to use the previous AddTakeGrad kernel

Comments
@leezu I've used the script in #11314 and verified this can pass more than 3000 trials.

Benchmark script:
import mxnet as mx
import numpy as np
import time

N = 50000
ctx = mx.gpu(0)

embedding = mx.gluon.nn.Embedding(N, 300)
embedding.initialize(ctx=ctx)
# print(embedding.weight.data().asnumpy())
i = 0
np.random.seed(1)
idx = mx.nd.array(np.random.randint(0, N, size=(1024, 160)), ctx=ctx)
# idx = mx.nd.zeros((1,1), ctx=ctx)

print(np.max(np.bincount(idx.asnumpy().flatten().astype(np.int64))))

a = time.time()
for i in range(500000):
    with mx.autograd.record():
        emb_in = embedding(idx)
        # print(emb_in)
        loss = emb_in.sum()
        # print(loss)
        loss.backward()
print(time.time() - a)

Benchmark results:
Original implementation:<PHONE_NUMBER>9050598
New Implementation:<PHONE_NUMBER>5785522
Slowdown is negligible after switching to new kernel.

Thanks @haojin2!  Also it seems that the AddTakeGradLargeBatch kernel and related code is unused now and should be removed?

@leezu I'm encountering some unit test problems in this and will debug that a bit. The benchmarks were on a single K80 on my dev machine, I'll also do a benchmark on a p3 tmr. I'll run a check on whether this is still used elsewhere or we may even need to bring it back if we observe a severe performance regression on V100, I'll keep it for now and marking this PR as WIP. Will let you know once I've got the latest results. Thanks for your quick reply!

@leezu I found that my fix is only slightly faster than turning MXNET_FORCE_ADDTAKEGRAD on with the previously shown benchmark scripts, I think we're good with the current implementation now?

Ok, thanks for looking into this! In that case we should make MXNET_FORCE_ADDTAKEGRAD the default behavior and delete the AddTakeGradLargeBatch kernel.

@Roshrini I believe this should be addressed before freezing code for MXNet 1.3. The MXNet 1.3 release is likely to be used a lot on P3 instances with Cuda 9.2, meaning that the buggy backward pass of the Embedding operator will hit many users.

@leezu I would be preferring the original AddTakeGrad as that required minimal code change.

Is this complete? I see some discussions on dev@ about this bug

First of all, great work diving into this @haojin2.
One concern I have is that the overhead of running the imperative python loop would dominate the performance, and make the two implementations seem equivalent in terms of execution time.  Would it be possible to run the same test prefixed with nvprof and then past the kernel execution time summary?

@KellenSunderland One argument that I would like to make here is that end-to-end performance is what matters most to actual users, since that's what they would experience on their end. On the other hand, as the LargeBatch kernel is exhibiting flaky problematic behavior, I don't think it should be kept (I think one other guy on the dev list thread about this is also agreeing with this point), not to mention here it's not even making any fundamental performance difference.
In conclusion, I think the LargeBatch version should be got rid of anyways, but I shall investigate whether the new general take grad kernel or the AddTakeGrad kernel is giving a better performance using some kind of profiler, does that sound good to you?

I'll also do some researches on my side, thanks for bringing this issue up!

Actually looking at a quick profile it seems it should be pretty representative.  Mostly GPU work going on.  Attaching screenshot.

@KellenSunderland So I think there should be not much difference between the two versions of the kernel?

Yes, I'd agree based on these measurements.
On Wed, Jul 25, 2018 at 11:08 AM Hao Jin<EMAIL_ADDRESS>wrote:

@KellenSunderland https://github.com/KellenSunderland So I think there
should be not much difference between the two versions of the kernel?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/11795#issuecomment-407845375,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHGTE2YxPEWgjyoRWT3YV-NnM3XgyAzbks5uKLQwgaJpZM4VT6UG
.

@leezu The AddTakeGrad kernel can pass more than 3500 trials on the reproduction script, I think this PR should be a good fix without any fundamental performance loss.

@KellenSunderland Thanks for the help on profiling!

Could be a valid point Xingjian.  Are you seeing differences when measured
with nvprof?  Can you post a summary?
On Mon, Aug 26, 2019, 8:45 AM Xingjian Shi<EMAIL_ADDRESS>wrote:

I find the previous performance test was conducted using time.time(). It’s
not safe to do that due to the tremendous overhead of the imperative API in
MXNet. We should rely on nvprof in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABYZGE5LIWKYDBHYIQHFJE3QGP3BDA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYSTQ#issuecomment-524912974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYZGEYRTSCQE3Q55QNSOH3QGP3BDANCNFSM4FKPUUDA
.

Would you help profile the change? I think the current change should not have passed the code interview.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Kellen Sunderland<EMAIL_ADDRESS>Sent: Friday, August 30, 2019 5:42:43 AM
To: apache/incubator-mxnet<EMAIL_ADDRESS>Cc: Xingjian SHI<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [apache/incubator-mxnet] Fix problematic backward of take & embedding (#11795)
Could be a valid point Xingjian. Are you seeing differences when measured
with nvprof? Can you post a summary?
On Mon, Aug 26, 2019, 8:45 AM Xingjian Shi<EMAIL_ADDRESS>wrote:

I find the previous performance test was conducted using time.time(). It’s
not safe to do that due to the tremendous overhead of the imperative API in
MXNet. We should rely on nvprof in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABYZGE5LIWKYDBHYIQHFJE3QGP3BDA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYSTQ#issuecomment-524912974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYZGEYRTSCQE3Q55QNSOH3QGP3BDANCNFSM4FKPUUDA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABHQH3TLFEDO3Z6PGSEBIXTQHEIUHA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RRHLY#issuecomment-526586799, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHQH3RIP6DA7SN26CH5JI3QHEIUHANCNFSM4FKPUUDA.

I’ll do that later if you do not have time. Currently, there are lots of other urgent issues for me so I’m asking for help.
Thanks,
Xingjian
Get Outlook for iOShttps://aka.ms/o0ukef

From: Xingjian SHI
Sent: Friday, August 30, 2019 7:43:41 AM
To: apache/incubator-mxnet<EMAIL_ADDRESS>apache/incubator-mxnet<EMAIL_ADDRESS>Cc: Comment<EMAIL_ADDRESS>Subject: Re: [apache/incubator-mxnet] Fix problematic backward of take & embedding (#11795)
Would you help profile the change? I think the current change should not have passed the code interview.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Kellen Sunderland<EMAIL_ADDRESS>Sent: Friday, August 30, 2019 5:42:43 AM
To: apache/incubator-mxnet<EMAIL_ADDRESS>Cc: Xingjian SHI<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [apache/incubator-mxnet] Fix problematic backward of take & embedding (#11795)
Could be a valid point Xingjian. Are you seeing differences when measured
with nvprof? Can you post a summary?
On Mon, Aug 26, 2019, 8:45 AM Xingjian Shi<EMAIL_ADDRESS>wrote:

I find the previous performance test was conducted using time.time(). It’s
not safe to do that due to the tremendous overhead of the imperative API in
MXNet. We should rely on nvprof in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABYZGE5LIWKYDBHYIQHFJE3QGP3BDA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYSTQ#issuecomment-524912974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYZGEYRTSCQE3Q55QNSOH3QGP3BDANCNFSM4FKPUUDA
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-mxnet/pull/11795?email_source=notifications&email_token=ABHQH3TLFEDO3Z6PGSEBIXTQHEIUHA5CNFSM4FKPUUDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5RRHLY#issuecomment-526586799, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABHQH3RIP6DA7SN26CH5JI3QHEIUHANCNFSM4FKPUUDA.


how to run a cleanup function before exiting

Hi all,
I created an application with Status Menu interface and now looking for a way to do some cleanup work before exiting the application. It looks like by default there is always one item created for exiting named "Quit something". I have not found a way to hook to that item, so I also created one item called "Quit something" which can trigger my cleanup functions. Then I end up with two items both used for quiting, which does not look nice.
Does anyone know how to inject a clean up function into the default quit? Alternatively, it would also be great if we can simply remove the default quit from the menu.
Thanks a lot for any hint.
Best regards,
Yang

Currently, the script is only run in the Status Menu interface when the menu is opened. There is no way to hook into when the application quits. It's necessary to have a "Quit AppName" menu item at the bottom, because otherwise there would be no way graphical way to quit the app.

Hi Sveinbjorn,
Thanks a lot for your quick response!
Currently what I am doing is to produce another "Quit" item in the menu. If it is clicked, then some code will run to quit the actual application running behind the status menu, and then print "QUITAPP\n" to quit the status menu. It works quite good. I can understand the need of having a "Quit AppName" at the bottom, but as long as we can have a button in the status menu which does a similar job, then it is no longer mandatory. In the meanwhile, my naive guess is that as long as status menu can receive a "QUITAPP\n" to quit, it should also be able to receive another command which is executed before it processes "QUITAPP\n" request...
Best regards,
Yang

I've always equivocated about the right balance when it comes to Platypus: power vs. complexity. I've chosen to err on the side of simplicity with Platypus. It's unlikely that such hooks will be added in the future. But your point is well made and represents a legitimate use case.


Hide routes already in use in route selector in GTFS+ route_attributes editor.

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[na] The description lists all applicable issues this PR seeks to resolve
[na] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
This client-requested improvement PR changes the route selector in the GTFS+ route attributes so that only the routes not in use (plus the current route) are shown in the selector drop-down. Routes that appear in other rows of the tables are not shown in the drop-down. (Does not include validation of cases where the same route_id appears in multiple entries in this table).

Tested, worked great!

FYI, MTC requested removing the limit on the number of routes displayed so that all routes are shown in the dropdown. I left a FIXME comment to note that change in https://github.com/ibi-group/datatools-ui/pull/797/commits/7c7c5997f0ecc9c6f5c722af3324e86766859223.


Bumb actions/checkout to enforce later node version

Version 2 of the checkout action uses node12 which is deprecated and will be forced to run on node16. The main change of version 3 is to use node16.

Thank you so much for keeping the CI/CD pipeline up to date.

Thank you so much for keeping the CI/CD pipeline up to date.

An up-to-date CI pipeline helps even more if you incorporate the new tests into the workflow. Eventually, we can then transition to automate the deployment.


[SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

What changes were proposed in this pull request?
This PR proposes to show ignored configurations and hide the warnings for configurations that are already set when invoking SparkSession.builder.getOrCreate.
Why are the changes needed?
Currently, SparkSession.builder.getOrCreate() is too noisy even when duplicate configurations are set. Users cannot easily tell which configurations are to fix. See the example below:
./bin/spark-shell --conf spark.abc=abc

import org.apache.spark.sql.SparkSession
spark.sparkContext.setLogLevel("DEBUG")
SparkSession.builder.config("spark.abc", "abc").getOrCreate

21:04:01.670 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.

It is straitforward when there are few configurations but it is difficult for users to figure out when there are too many configurations especially when these configurations are defined in a property file like 'spark-default.conf' maintained separately by system admins in production.
See also https://github.com/apache/spark/pull/34757#discussion_r769248275.
Does this PR introduce any user-facing change?
Yes.

Show ignored configurations in debug level logs:
./bin/spark-shell --conf spark.abc=abc

import org.apache.spark.sql.SparkSession
spark.sparkContext.setLogLevel("DEBUG")
SparkSession.builder
  .config("spark.sql.warehouse.dir", "2")
  .config("spark.abc", "abcb")
  .config("spark.abcd", "abcb4")
  .getOrCreate

Before:
21:13:28.360 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; the static sql configurations will not take effect.
21:13:28.360 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.

After:
20:34:30.619 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
20:34:30.622 [main] DEBUG org.apache.spark.sql.SparkSession - Ignored static SQL configurations:
  spark.sql.warehouse.dir=2
20:34:30.623 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
  spark.abcd=abcb4
  spark.abc=abcb

Do not issue a warning and hide a configuration already explicitly set (with the same value) before.
./bin/spark-shell --conf spark.abc=abc

import org.apache.spark.sql.SparkSession
spark.sparkContext.setLogLevel("DEBUG")
SparkSession.builder.config("spark.abc", "abc").getOrCreate  // **Ignore** warnings because it's already set in --conf
SparkSession.builder.config("spark.abc.new", "abc").getOrCreate  // **Show** warnings for only configuration newly set.
SparkSession.builder.config("spark.abc.new", "abc").getOrCreate  // **Ignore** warnings because it's set ^.

Before:
21:13:56.183 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
21:13:56.356 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
21:13:56.476 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.

After:
20:36:36.251 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
20:36:36.253 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
  spark.abc.new=abc

Do not issue a warning and hide runtime SQL configurations in debug log:
./bin/spark-shell

import org.apache.spark.sql.SparkSession
spark.sparkContext.setLogLevel("DEBUG")
SparkSession.builder.config("spark.sql.ansi.enabled", "true").getOrCreate  // **Ignore** warnings for runtime SQL configurations
SparkSession.builder.config("spark.buffer.size", "1234").getOrCreate  // **Show** warnings for Spark core configuration
SparkSession.builder.config("spark.sql.source.specific", "abc").getOrCreate  // **Show** warnings for custom runtime options
SparkSession.builder.config("spark.sql.warehouse.dir", "xyz").getOrCreate  // **Show** warnings for static SQL configurations

Before:
09:10:22.183 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
09:10:22.356 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
09:10:22.476 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
09:10:22.536 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; the static sql configurations will not take effect.

After:
10:39:54.870 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
10:39:54.872 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
  spark.buffer.size=1234
10:39:54.988 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
10:39:54.988 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
  spark.sql.source.specific=abc
10:39:55.107 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
10:39:55.108 [main] DEBUG org.apache.spark.sql.SparkSession - Ignored static SQL configurations:
  spark.sql.warehouse.dir=xyz

Note that there is no behaviour change on session state initialization when configurations are not set. For example:
import org.apache.spark.sql.SparkSession
spark.sparkContext.setLogLevel("DEBUG")
SparkSession.builder.getOrCreate

But the session state initialization can be triggered now for static SQL configurations set after this PR. Previously, it was not triggered. This would not introduce something user-facing or a bug but worth noting it.
For runtime SQL configurations, the session state initialization in this code path was introduced at https://github.com/apache/spark/pull/15295.
How was this patch tested?
It was manually tested as shown above.

cc @cloud-fan, @dongjoon-hyun @AngersZhuuuu @yaooqinn @maropu FYI when you find some time to review :-).

Test build #146522 has started for PR 35001 at commit f58f6c3.

Test build #146527 has started for PR 35001 at commit f710487.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50998/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50998/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50998/

20:36:36.253 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
spark.abc.new=abc

I feel this could be a bit confused. Users may thought the value abc doesn't take effect for the conf spark.abc.new. However, it does. The thing is, it's actually the second set doesn't take effect here rather than the value itself.

Test build #146522 has finished for PR 35001 at commit f58f6c3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146522/

Test build #146527 has finished for PR 35001 at commit f710487.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146527/

I feel this could be a bit confused. Users may thought the value abc doesn't take effect for the conf spark.abc.new. However, it does. The thing is, it's actually the second set doesn't take effect here rather than the value itself.

This actually was already there. The problem here is that users, for example, might pass some source specific options that Spark side does not now. Maybe we can filter out Spark's runtime configuration here though. Let me take a look while I am here.

@Ngone51, the current change should address your comment (see 3. in Pr desscription)

Test build #146543 has started for PR 35001 at commit ae4616c.

Maybe we can have a UT in SparkShellSuite?

Maybe we can have a UT in SparkShellSuite?

There is actually a bug I guess from switching to log4j 2 (see SPARK-37729). I would prefer to add it after this gets resolved.

Maybe we can have a UT in SparkShellSuite?

There is actually a bug I guess from switching to log4j 2 (see SPARK-37729). I would prefer to add it after this gets resolved.

Got it, thanks.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51018/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51018/

Merged to master.

Thanks guys for your reviews.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51018/

late lgtm

Test build #146543 has finished for PR 35001 at commit ae4616c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146543/


Add Activity Tags Enricher

Fixes https://github.com/RehanSaeed/Serilog.Enrichers.Span/pull/44
/cc @seungyongshim

Also of intrest is that logs in OT will be supported soon'ish, so there should be no need for this package anymore:
https://github.com/open-telemetry/opentelemetry-dotnet/issues/2076

Thanks for the PR.


Network bonding does not work on resinOS for the raspberry pi

Once a network bonding connection has been configued the wlan0 interface constantly changes state between up and down.
[  221.450505] brcmfmac: brcmf_cfg80211_reg_notifier: not a ISO3166 code
[  221.463964] cfg80211: World regulatory domain updated:
[  221.476026] cfg80211:  DFS Master region: unset
[  221.480549] cfg80211:   (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp), (dfs_cac_time)
[  221.504399] cfg80211:   (2402000 KHz - 2472000 KHz @ 40000 KHz), (N/A, 2000 mBm), (N/A)
[  221.519556] cfg80211:   (2457000 KHz - 2482000 KHz @ 20000 KHz, 92000 KHz AUTO), (N/A, 2000 mBm), (N/A)
[  221.536193] cfg80211:   (2474000 KHz - 2494000 KHz @ 20000 KHz), (N/A, 2000 mBm), (N/A)
[  221.551359] cfg80211:   (5170000 KHz - 5250000 KHz @ 80000 KHz, 160000 KHz AUTO), (N/A, 2000 mBm), (N/A)
[  221.567994] cfg80211:   (5250000 KHz - 5330000 KHz @ 80000 KHz, 160000 KHz AUTO), (N/A, 2000 mBm), (0 s)
[  221.584514] cfg80211:   (5490000 KHz - 5730000 KHz @ 160000 KHz), (N/A, 2000 mBm), (0 s)
[  221.599638] cfg80211:   (5735000 KHz - 5835000 KHz @ 80000 KHz), (N/A, 2000 mBm), (N/A)
[  221.614565] cfg80211:   (57240000 KHz - 63720000 KHz @ 2160000 KHz), (N/A, 0 mBm), (N/A)
[  221.637127] test: link status definitely down for interface wlan0, disabling it
[  222.247059] test: link status definitely up for interface wlan0, 0 Mbps full duplex

the wlan0 interface also does not start correctly on boot
root@440eecc:~# journalctl -u NetworkManager | grep -e wlan0
Aug 15 13:50:59 440eecc NetworkManager[657]: <info>  [1502805059.6753] keyfile: new connection /etc/NetworkManager/system-connections/bond-slave-wlan0 (bfbf0ba8-29d0-4040-a345-1b1a247871ae,"bond-slave-wlan0")
Aug 15 13:51:00 440eecc NetworkManager[657]: <info>  [1502805060.5653] wifi-nl80211: (wlan0): using nl80211 for WiFi device control
Aug 15 13:51:00 440eecc NetworkManager[657]: <info>  [1502805060.5663] device (wlan0): driver supports Access Point (AP) mode
Aug 15 13:51:00 440eecc NetworkManager[657]: <info>  [1502805060.5703] manager: (wlan0): new 802.11 WiFi device (/org/freedesktop/NetworkManager/Devices/3)
Aug 15 13:51:00 440eecc NetworkManager[657]: <info>  [1502805060.5742] device (wlan0): state change: unmanaged -> unavailable (reason 'managed') [10 20 2]
Aug 15 13:51:01 440eecc NetworkManager[657]: <info>  [1502805061.1612] device (wlan0): set-hw-addr: set MAC address to BE:B7:E6:43:83:EE (scanning)
Aug 15 13:51:01 440eecc NetworkManager[657]: <info>  [1502805061.5008] device (wlan0): supplicant interface state: init -> starting
Aug 15 13:51:01 440eecc NetworkManager[657]: <info>  [1502805061.5870] sup-iface[0x53d818,wlan0]: supports 5 scan SSIDs
Aug 15 13:51:01 440eecc NetworkManager[657]: <info>  [1502805061.5897] device (wlan0): supplicant interface state: starting -> ready
Aug 15 13:51:01 440eecc NetworkManager[657]: <info>  [1502805061.5899] device (wlan0): state change: unavailable -> disconnected (reason 'supplicant-available') [20 30 42]
Aug 15 13:51:02 440eecc NetworkManager[657]: <info>  [1502805062.1209] device (wlan0): supplicant interface state: ready -> inactive
Aug 15 13:51:02 440eecc NetworkManager[657]: <info>  [1502805062.4348] policy: auto-activating connection 'bond-slave-wlan0'
Aug 15 13:51:02 440eecc NetworkManager[657]: <info>  [1502805062.4589] device (wlan0): Activation: starting connection 'bond-slave-wlan0' (bfbf0ba8-29d0-4040-a345-1b1a247871ae)
Aug 15 13:51:02 440eecc NetworkManager[657]: <info>  [1502805062.4604] device (wlan0): state change: disconnected -> prepare (reason 'none') [30 40 0]
Aug 15 13:51:02 440eecc NetworkManager[657]: <info>  [1502805062.9702] device (wlan0): set-hw-addr: reset MAC address to B8:27:EB:F6:6C:EC (preserve)
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0063] device (wlan0): supplicant interface state: inactive -> disabled
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0080] device (wlan0): supplicant interface state: disabled -> inactive
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0124] device (wlan0): state change: prepare -> config (reason 'none') [40 50 0]
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0135] device (wlan0): Activation: (wifi) access point 'bond-slave-wlan0' has security, but secrets are required.
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0137] device (wlan0): state change: config -> need-auth (reason 'none') [50 60 0]
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0367] device (wlan0): state change: need-auth -> prepare (reason 'none') [60 40 0]
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0389] device (wlan0): state change: prepare -> config (reason 'none') [40 50 0]
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.0401] device (wlan0): Activation: (wifi) connection 'bond-slave-wlan0' has security, and secrets exist.  No new secrets needed.
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.3022] device (wlan0): supplicant interface state: inactive -> associating
Aug 15 13:51:03 440eecc NetworkManager[657]: <info>  [1502805063.4323] device (wlan0): supplicant interface state: associating -> 4-way handshake

To reproduce, run the following commands from the hostOS and look at the dmesg/journalctl logs
// Create the bond connection
nmcli con add type bond ifname test bond.options "mode=balance-rr,miimon=100"

// Assign ethernet slave
nmcli con add type ethernet ifname eth0 master test

// Assign wifi slave
nmcli con add type wifi ssid <SSID> ifname wlan0 master test
nmcli con mod bond-slave-wlan0 wifi-sec.key-mgmt wpa-psk
nmcli con mod bond-slave-wlan0 wifi-sec.psk <PASSWORD>

// Activate
nmcli con up bond-slave-eth0
nmcli con up bond-slave-wlan0

I noticed that the brcmfmac firmware versions are different
resinOS brcmfmac: Firmware version = wl0: Aug 29 2016 20:48:16 version <IP_ADDRESS> (r640327) FWID 01-4527cfab
Raspbian brcmfmac: Firmware version = wl0: Aug  7 2017 00:46:29 version <IP_ADDRESS> (r666254 CY) FWID 01-f8a78378
This is fixed by copying the contents of /lib/firmware from a raspbian image into /resin-rootA/lib/firmware on a resinOS image.  Could you add a comment here about your findings?

@agherzan pretty sure it's just a case of making sure updating the brcmfmac firmware to brcmfmac: Firmware version = wl0: Aug  7 2017 00:46:29 version <IP_ADDRESS> (r666254 CY) FWID 01-f8a78378

Will be fixed when https://github.com/resin-os/resin-raspberrypi/issues/121 gets fixed (firmware updated).


Intellij Syntax Hightlighting Seemingly not correct

Hi, just checking out the latest and greatest (0.5.2+6-10d43572) and noticed Intellij syntax highlighting odd behaviors:
For the following:
@JSImport("rc-slider/lib/Slider", JSImport.Default)
@js.native
object Slider extends js.Object {
}

@react object ReactSlider extends ExternalComponent {
  case class Props(
                    defaultValue: Double,
                    value: Double,
                    disabled: Boolean,
                    min: Double,
                    max: Double,
                    step: Int
                  )
  override val component = Slider

Intellij purports that I need to call the object like so:
ReactSlider(
                      ReactSlider.Props(
                          defaultValue = 5.0,
                          value = 5.0,
                          disabled = false,
                          min = 0.0,
                          max = 300.0,
                          step = 5
                      )
            )

If I don't explicitly set Props argument, I get Reassignment to val error and lots of red.
Also, the following:
div(
          sharedState.Consumer{ stuff =>
            ApolloProvider(stuff.client)(
              div(
                ReactSlider(...)
              )
            )
          }
        )

Is riddled with "type mismatches" (claiming that ReactElement isn't being returned even though it is) when really there are none.
However, none of these are true errors and everything runs fine if I ignore that error

Interestingly these problems all go away if I Invalidate Caches and Restart in Intellij.
So it's repeatable, but avoidable as well! Basically you have to make sure never to click Import Changes pop up and I leave Auto-Import off.

Could you share the code that results in the Reassignment to val error? I tested locally and things seemed to work fine. For the second two, those look like they may be some weird interaction with an IntelliJ bug, so I'll have to dig a bit deeper.

Sure, and forgive me but I can't seem to reproduce the exact syntax highlighting error for the first bullet above but it's effectively the same end result: Cannot resolve symbol  followed by prop name.
As before, if I instead construct the component without keyword args, or explicitly construct props it works without highlighted errors (TestFunct(TestFunc.Props(first = "f", second = 1)))

import org.scalajs.dom
import slinky.core.FunctionalComponent
import slinky.core.annotations.react
import slinky.web.ReactDOM
import slinky.web.html.div

import scala.scalajs.js.annotation.{JSExportAll, JSExportTopLevel}

@react object TestFunc {
  case class Props(first: String, second: Int)

  val component = FunctionalComponent[Props] { props =>
    div(s"${props.first} ${props.second}")
  }
}

@JSExportTopLevel(name="entrypoint") @JSExportAll
object Entry{

  def main(args: Array[String]): Unit = {
    ReactDOM.render(AppTest.main(), dom.document.getElementById("root"))
  }
}

object AppTest {

  type Props = Unit

  val main = FunctionalComponent[Props] { _ =>
    div(
      TestFunc(first = "f", second = 1)
    )
  }
}

Perhaps it was saying Reassignment to val before instead of Cannot resolve symbol due to how my source code files were organized. Not sure though, I'm far from a Jet Brain specialist!

just tested on slinky 0.6.0 and reassignment to val issues still present

Another syntax highlighting issue that popped up today is when I use scalajs either expression for a type:
@JSImport("react-csv", "CSVLink")
@js.native
object CSVLink extends js.Object

@react object CsvDownloadLink extends ExternalComponentWithRefType[CsvLinkRef] {
  case class Props(
                    data: js.Array[js.Object] | String,
                    filename: String,
                    separator: String = "\t",
                    target: String = "_blank"
                  )
  override val component = CSVLink
}

If I instantiate this with a String for data, it works fine and there are no syntax errors, but instantiating with data as a js.Array[js.Object] generates syntax error even though the code compiles and runs just fine:
Expression of type Array[Object] doesn't conform to expected type Array[Object] | String

@evbo thanks for the reports, I'll try to take a look at them soon (might not get to this for 2ish weeks since I have finals 😢 ). As far as I remember, IntelliJ generally has trouble with Scala.js union types. Does IntelliJ still complain if the @react annotation is not used?

@shadaj good question, if I remove the @react the syntax error changes to the one I was seeing before: reassignment to val

@shadaj  .. I can provide more examples of where union types fall apart:
@react object Orange extends ExternalComponent {
  case class Props(param1: Double | Int, param2: Seq[Double | Int])
}

# Works
Orange(param1 = 5)

# IntellIJ will be underline param2 as being invalid with the following message:
# Expected: Seq[Double | Int], Actual: Seq[Int]
Orange(param2 = Seq(5))

If the above problems are IntelliJ it wouldn't surprise me. However, in Slinky 0.6.2 I'm getting another interesting IntelliJ warning when I try creating a function that returns a component as a generic ReactElement (I just need jsx):
val component: ReactElement = (props: PropsType) => TheComponent(...)

fruitless type test: a value of type PropsType => TheComponent.component.Result cannot also be PropsType => ReactElement(but still might match its erasure)

I think this warning is completely valid, but I'm not sure what to do about the warning. If I instead try to be more specific with its type, I can no longer get it to compile:
type ReturnComponent = PropsType => TheComponent.component.Result
val component: ReturnComponent = (props: PropsType) => TheComponent(...)

gives error:

type mismatch;
[error]  found   : TheComponent.component.Result
[error]     (which expands to)  slinky.core.KeyAddingStage
[error]  required: ReturnComponent
[error]     (which expands to)  PropsType => slinky.core.KeyAddingStage

So I'm fine ignoring the warning as valid, but ideally a warning has a fix. Is there a type safe way in this case? I've tried returning TheComponent(...).withKey("some key") but still get the same error.

I may be wrong about my understanding but the first example doesn't look correct. You aren't returning a ReactElement but instead returning a component. If you were to return TheComponent.render() it would be a ReactElement.
The second example looks sort of right although not sure if Slinky understands the case class. Any reason you wouldn't just rely on type inference ?

So, when writing functional components you need to wrap the function in FunctionalComponent so that Slinky transforms the function into a component instead of just leaving it as a regular Scala function. IntelliJ should then pick up that you are defining a functional component and generate the appropriate apply methods.

here's how to reproduce in IntelliJ IDEA 2019.1: idea-IC-191.6183.87
@react object TheComponent  {
  case class Props(stuff: Int)
  val component = FunctionalComponent[Props] { props =>
    div("div")
  }
}

type ReturnComponent = Int => ReactElement

for {
  a <- Some("")
  funcThatGivesComponent: ReturnComponent = (someInt: Int) => TheComponent(  // warning given here
    someInt
  )
} yield "result"

Javascript frameworks can require you to pass the external components functions that can produce new components, with some argument (someInt) allowing you to customize the component. For instance, "react table" does this a lot.

given how old this issue is and the code example I once had is totally gone now (react table has since migrated to hooks) I recommend closing this issue since no other comments concur my findings.
this is probably and hopefully old news ;)


Fail to install together with awscli due to the colorama dependency

Describe the bug
A clear and concise description of what the bug is.
I cannot install runpod with awscli together as the latter requires colorama<0.4.5.
To Reproduce
Steps to reproduce the behavior:
pip install runpod >= 1.3.7 awscli
Additional context
It is critical to install both packages for https://github.com/skypilot-org/skypilot/pull/2360

Works for runpod==1.3.0 but does not work for any version runpod>=1.3.1.

Yes, it works with 1.3.0, but since runpod has a bunch of API changes through those versions, e.g. the ~/.runpod/credentials.toml is renamed to ~/.runpod/config.toml, it would be nice that we can use the latest runpod package. ; )

Works for runpod==1.3.0 but does not work for any version runpod>=1.3.1.

Yes, it works with 1.3.0, but since runpod has a bunch of API changes through those versions, e.g. the ~/.runpod/credentials.toml is renamed to ~/.runpod/config.toml, it would be nice that we can use the latest runpod package. ; )

Yep, was just trying to figure out where the problem started happening, seems runpod didn't have colorama in its requirements.txt prior to version 1.3.1.   I am not really sure why something like colorama needs versions to be locked.

Thanks for the feedback guys, updated the requirements to be colorama >= 0.2.5, < 0.4.5


Rename the project

There is already a pbench project on read the docs. This needs a new name. Be sure to update all the references in the code.

I think I like Rayne. According to Google's search AI, Rayne means

Scandinavian origin: A gender-neutral name that means "good counselor and friend".

Rayne seems available in PyPI and Read the Docs.


fix(define): should not stringify vite internal env

Description
Some Vite internal env values(e.g plugin-legacy __VITE_IS_LEGACY__) will be stringified, which may cause the value type to be incorrect in import.meta.env object

Additional context

What is the purpose of this pull request?

[x] Bug fix
[x] New Feature
[x] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Ah I didn't anticipate this bug, if you have define import.meta.env.SOMETHING: "rawIdentifier". import.meta.env should be:
{
  SOMETHING: rawIdentifer
}

instead of a string. I think we need to do this generically for all define that defines a raw identifier, not just for plugin-legacy.

LGTM

/ecosystem-ci run


Rework schema customisation setup for the Declarative DSL interpreter

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

The merge queue build has started. Click here to see all failures if any.

The merge queue build has failed. Click here to see all failures.

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


SPIKE Monitoring strategy for Confirmation email in vets-api

Goal - figure out what we want to measure/monitor/alert and how to use the available tool to achieve that

[ ] Consult with the vets-api team to understand what could be used for Monitoring
[ ] Discuss and document strategy and approach within our team
[ ] Possibly review Prometheus, Grafana, Sentry, statsd
[ ] Alerts - should we be alerted, when and where

Timebox - 3 days
Assumption:

Implementation of the monitoring will be done in a different card (#74)

Some useful resources:

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/engineering/grafana-overview.pdf
https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/engineering/sentry-configuration.md
https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/engineering/sentry-tagging-standards.md

Some information provided by John Paul:

right now, there’s no automatic alerting in sentry outside of the slack channel which is effectively a firehose
the sentry10 rollout, which continues to be imminent, among other things, should allow us to notify teams about their errors (based on tags for example) through slack
the current monitoring solution remains prometheus/grafana
pagerduty is managed by OI&T with a pretty hard limit on users. I think we might be able to temporarily get you a few folks in during launch, but the links between the various tools require OIT admins and occasionally dsva admins which can make it complicated. As a rule we haven’t been incorporating pagerduty outside of support but i don’t have a strong objection.
most of the prom/grafana is for internal tracking (eg SLOs). @Keifer [VSP/BE Tools] is likely the best person on be-tools to talk to and he’s on vacation this week
but the soon solution is going to be app perf monitoring with DataDog, and I believe ops is still planning to move to DataDog over prometheus as part of new infrastructure.
you should be able to get to grafana. @kam on the VAOS team shared a custom dashboard as they get ready to launch just yesteday http://grafana.vfs.va.gov/d/EmC4pa6Wz/vaos-alerts?orgId=1&from=now-3d&to=now

Session with @Keifer scheduled for Wednesday 7/15/2020 at 2:30 PM EDT

Let's make sure that VA Notify is part of External Services - SLO Report:
http://grafana.vfs.va.gov/d/pEgVdRlZk/external-service-performance-indicators?orgId=1

Notes: https://docs.google.com/document/d/1K-VdJbGFBbTBsv8J9X2exhV2lMPJz3QwR4MynsgnK5I/edit#
Recommendations:
Grafana

Add Form526ConfirmationEmailJob to Job Queue Dashboard - Asked Keifer
Investigate vanotify data showing N/A on External Service Performance Indicators Dashboard -> Asked Keifer
Make dashboard for vanotify: Calls to govdelivery (later: other services), Calls from vets-api, Errors/failures, availability of service. - Requires sending a request in the #vfs-platform-support channel and they will create the dashboard for us

Sentry

Create a new sentry team (instructions here) - can specify a path/url that we want to “own” if an error happens
Future - once sentry10 is available on vets-api, set up alerting to our slack channel


did not work with new Cloudflare worker script syntax !

grate tools, but need update...
[https://github.com/EtherDream/jsproxy/blob/master/cf-worker/index.js](javascript:void(0);)
did not work with new Cloudflare worker script syntax.

like this working version:
https://github.com/likebeta/cloudflare-worker-jsproxy/blob/master/cloudflare-worker.js


2 seperate uploads, only one green tick

Hi Team! I uploaded validators in two batches yesterday (27th of February). But only one of them have the green tick mark here https://github.com/benjaminchodroff/ConsensusLayerWithdrawalProtection/commits/main. Please confirm all validators will be submitted.

I have provided more details in the pull request: https://github.com/benjaminchodroff/ConsensusLayerWithdrawalProtection/pull/167
If you need more validators to be uploaded, please open a new pull request. You can see all your validators have been included in the mainnet folder. It appears you have no further validators to upload. I'll close this issue as it appears to be solved.


Add badge with counter when displayed notification is repeated

Description:

This is to avoid repeating notifications. Whenever a new notification is about to be displayed, check if it already exists and show badge with increased counter

I like the idea. @jbibla had some ideas about not showing notifications at all, as far as I remember.

it's true! we are abusing the notifications.
https://github.com/cosmos/voyager/issues/1266#issuecomment-429463764
@fedekunze please provide an example of a notification that should appear as they do now, and the situation where more than one should be displayed at a time.
😄


releng: Update release-managers doc

Related issue: https://github.com/kubernetes/sig-release/issues/2152
/hold until https://github.com/kubernetes/sig-release/pull/2156 merges.
/assign @jeremyrickard
/cc https://github.com/orgs/kubernetes/teams/release-managers
/milestone v1.27
/priority important-soon

#2156 is in.
/hold cancel

/milestone 1.27

/approve

https://github.com/kubernetes/sig-release/pull/2156 merged
/lgtm


Deprecation of all magic numbers for supported features

As of Home Assistant Core 2024.1, all usage of magic numbers for supported features is deprecated, and each entity platform has provided an EntityFeature enum to replace them.
There will be a one-year deprecation period, and the magic numbers will stop working in 2025.1 to ensure all custom integration authors have time to adjust.
Entity None (<class 'custom_components.winix.fan.WinixPurifier'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <FanEntityFeature.SET_SPEED|PRESET_MODE: 9>, please create a bug report at https://github.com/iprak/winix/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

See https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation/ for more information.

What version of integration are you using?

I was on 1.1.4, didn't see it addressed in the release, but I see it in this commit.  Sorry for the noise.

No problem. That was just some code cleanup, I don't think this was a warning at that point.


Adding values to a multiselect box

With this code
$this->crud->addField([
    'label' => "Department",
    'type' => 'select_multiple',
    'name' => 'departments',
     // the method that defines the relationship in your Model
    'entity' => 'departments', // the method that defines the relationship in your Model
    'attribute' => 'department_name', // foreign key attribute that is shown to user
    'model' => "App\Models\DepartmentNames", // foreign key model
    'pivot' => true, // on create&update, do you need to add/delete pivot table entries?
    'text' => "- Select -"
]);

It populates the box but the select has no values so the array submitted is empty
<select class="form-control" name="department[]" multiple="">
    <option value="">-</option>
    <option value="">Account Management</option>
    <option value="">Services</option>
    <option value="">Customers</option>
   <option value="">Technical</option>
</select>

Hi @WeAreLeith ,
Well if you don't allow empty responses for this field you can:
A) create a validation rule for it (in the corresponding FormRequest);
or
B) specify 'allows_null' => false, for this field;
Hope it helps someone, despite the late reply.
Cheers!


About the insertion position of the summary

Can it support inserting summaries into the head instead of the tail?
Thanks!

The plugin currently supports extracting summary either at the page level or at the block level. If I understand correctly, what you're asking is whether we can add the summary at the top of the page (for page level extraction) and above the block (when that block is summarized)?
If yes, then it is doable. I may need to add another configuration which, when changed, performs what you're requesting. For block extract it's easier. Page extracts may be a little more tricky. Usually, the first block can contain either normal text or page properties so I'll have to check that.

The plugin currently supports extracting summary either at the page level or at the block level. If I understand correctly, what you're asking is whether we can add the summary at the top of the page (for page level extraction) and above the block (when that block is summarized)?
If yes, then it is doable. I may need to add another configuration which, when changed, performs what you're requesting. For block extract it's easier. Page extracts may be a little more tricky. Usually, the first block can contain either normal text or page properties so I'll have to check that.

Yes, you understand me. Because the summary information is more expected to be seen in the header.
Summary information is now displayed at the bottom by default, and may be ignored in future viewing.
I'd love to know your workflow too, if the summary is at the bottom, don't you have similar troubles?

@skyline-123 This issue is resolved with the latest version v2.0.5. I've added a new setting "keepSummaryAbove" which is set to false by default but if you set it true it achieves the desired behavior.


Height and width were swapped in PinholeCamera.

Motivation and Context

This was causing frames from rgba_sensor to be stretched.
Before:

After:

How Has This Been Tested

With this fix, frames pulled from the rgba_sensor are no longer stretched when specifying a width of 640 and height of 480.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

The test scenes in the repository look OK. This will require more investigation.

I was running into this pretty often as well. Would it help if spec_->resolution was a struct with named width and height attributes instead of a two-component array of values without any defined order? Not sure how that would fit into the Python side, tho.

I was running into this pretty often as well. Would it help if spec_->resolution was a struct with named width and height attributes instead of a two-component array of values without any defined order? Not sure how that would fit into the Python side, tho.

That is a good idea, and would help us prevent future confusion.  Having a simple struct and exposing that through pybind would likely help us better handle the change of convention between the gfx APIs and the tensor dimensions on the python side.

Agree. We need to do something about using vector for dimensions where height and width are different order. I will work on a proposal for that. I don't want to fix that in this change because I think it will require some discussion. The order used in resolution is also part of the public python API so cannot be changed so easily:
src/esp/bindings/bindings.cpp:      .def_readwrite("resolution", &SensorSpec::resolution)
examples/stereo_agent.py:    left_rgb_sensor.resolution = [512, 512]
So cool if I just land this fix for now and in parallel working on a long term solution.

Agree. We need to do something about using vector for dimensions where height and width are different order. I will work on a proposal for that. I don't want to fix that in this change because I think it will require some discussion. The order used in resolution is also part of the public python API so cannot be changed so easily:
src/esp/bindings/bindings.cpp: .def_readwrite("resolution", &SensorSpec::resolution)
examples/stereo_agent.py: left_rgb_sensor.resolution = [512, 512]
So cool if I just land this fix for now and in parallel working on a long term solution?

Sounds good to me.  I believe this bug fix shouldn't break any python-side logic but I'm not 100% certain.

Sounds good to me. I believe this bug fix shouldn't break any python-side logic but I'm not 100% certain.

This bug fix only affects a function that was added by me in SimulatorWithAgents PR #141. So currently the only users of this function are the js bindings code.


When deploying marketplace, 2 tags shows in side bar

Bug Description
OpenPAI sidebar shows 2 same tags of marketplace
Reproduce Steps
test case 1 in #209
Screenshots

Additional Info

Version Info

openpaimarketplace version:
OpenPAI cluster version:
Browser type (edge, chrome, safari):
OS version:

Upgrade marketplace from previous version without changing the services-configuration.yaml file, the auto added marketplace item may cause duplicate marketplace tags in webportal.
Admin can either set webportal.marketplace: false to avoid the auto added item, or remove the old marketplace item from webportal.plugins to delete the old one.


no tooltip for truncated values in the properties grid of query plan view.

no tooltip for truncated values in the properties grid of query plan view.

Fix is available, so proposing to take for Feb.


do not use inline_recursion if using clang

What does this change do?
checks if using clang under header_start.h and header_end.h
Is it related to an exisiting bug report or feature request?
Fixes #191
Pre-merge checklist

[X] I've read CONTRIBUTING.md
[X] I've rebased my changes against the current HEAD of origin/master (if necessary)
[ ] I've added new test cases to verify my change
[X] I've regenerated toml.hpp (how-to)
[ ] I've updated any affected documentation
[ ] I've rebuilt and run the tests with at least one of:

[ ] Clang 6 or higher
[ ] GCC 7 or higher
[ ] MSVC 19.20 (Visual Studio 2019) or higher

[ ] I've added my name to the list of contributors in README.md

Thanks!


SSL documentation

Related to https://github.com/ReactiveMongo/ReactiveMongo/pull/286 .

@sgodbillon Now this is rebased


New Yang's Recurve missing a stat

2.6.1 Yang's Recurve (PTR) is missing the 50% Resource Cost Reduction it's supposed to have.

55%

Fixed.


reproduce plugin

Hi author!
The plugin is great，could I reproduce the plugin to mcbbs? I marked you as the author in the MCBBS，Users download the plugin in your original github or Nukkitx.

Hi, thank you. Yes, you can :)


Ability to use UNION with implicitly cast-able values/columns without explicit cast

Use case:
Schema retrieval on JDBC/ODBC (Progress) driver site
Feature description:
SELECT 1::INTEGER
UNION
SELECT null

SELECT 1::regclass
UNION
SELECT 1::INTEGER

in 4.8 this leads to:
UnsupportedFeatureException[Corresponding output columns at position: 1 must be compatible for all parts of a UNION]

Similar issue happen on 4.7.x with UNION ALL
SELECT 1::INTEGER
UNION ALL
SELECT null

-> UnsupportedFeatureException[Corresponding output columns at position: 1 must be compatible for all parts of a UNION]

I'm not sure this is a bug. Sounds more like a feature to me and I'm not sure if we should extend UNION to allow implicit casts.
We currently allow implicit casts in many places and had the impression that it was a bit of a mistake and too lenient.
I think we can allow NULL literals because they are kind of a bottom value fitting any type, but other than that I'd tend to keep the current semantics.

I'm not sure if we should extend UNION to allow implicit casts.

I wrote that really more in the sense of PG compatibility:
SELECT 1::INT8 as a UNION SELECT 2.01 as a                                                                             ;
  a
------
    1
 2.01
(2 rows)

SELECT 1.0::FLOAT8 UNION SELECT 1::INTEGER;
 float8
--------
      1
(1 row)


CLI Crashing Problems

When I open the Windows Cli file, it opens perfectly, and I entered the correct mail and password, but after that the application stops, and when I try to open it again, it gives this error.
screenshot of the error
https://te.legra.ph/file/8a58db5eeddc04b58a7fb.jpg

That error is due to Cloudflare blocking you. It can't be fixed.


Duplicate?

We also have https://github.com/orbitdb/orbitdb-test-utils. Are these the same?
If so, we should close one of them (given the name of the previous, I think we could delete that one?).

Hmm! I totally missed that you did that. Yours seems more mature and I think it's literally the same code - I just copied the latest utils folder from ipfs-log, which may have some updates.

That's totally fine :) I like your repo better because it follows the naming convention of all orbitdb repos (orbit-db with a dash).
Up to you, I have no strong preference. We can keep using this repo (just make sure it's the latest code, which I believe it is if you copied it from ipfs-log/orbitdb).

@aphelionz 	Have you closed down the other repo?

All set


Revert copyright to initial year

According to http://www.copyright.gov/circs/circ01.pdf (See screenshot of relevant section below) , listing the first year of publication in the copyright is enough

Oh that's nice! I didn't know that, thanks for the contribution!


Higher CPU than Intel i7 6700 K but still get on 6-7 sol/s

Hi,
I have a workstation with this configuration
I have total 10 workstation with this configuration.
BUT I think zcash mining is not properly working on my system.
Operating System is WIN 10 64 BIT with 2 Xeon processor and 32 GB ram with 8Gb AMD GPU
Processors Information
Processor 1 ID = 0
Number of cores 8 (max 16)
Number of threads 16 (max 32)
Name Intel Xeon E5 2650 v2
Codename Ivy Bridge-EP/EX
Specification Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz
Package (platform ID) Socket 2011 LGA (0x0)
CPUID 6.E.4
Extended CPUID 6.3E
Core Stepping M0/M1
Technology 22 nm
TDP Limit 95.0 Watts
Tjmax 89.0 °C
Core Speed 2940.2 MHz
Multiplier x Bus Speed 30.0 x 98.0 MHz
Rated Bus speed 3528.3 MHz
Stock frequency 2600 MHz
Instructions sets MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, EM64T, AES, AVX
L1 Data cache 8 x 32 KBytes, 8-way set associative, 64-byte line size
L1 Instruction cache 8 x 32 KBytes, 8-way set associative, 64-byte line size
L2 cache 8 x 256 KBytes, 8-way set associative, 64-byte line size
L3 cache 20 MBytes, 20-way set associative, 64-byte line size
FID/VID Control yes
Turbo Mode      supported, enabled
Max non-turbo ratio 26x
Max turbo ratio     34x
Max efficiency ratio    12x
Max Power       150 Watts
Min Power       60 Watts
O/C bins        none
Ratio 1 core        34x
Ratio 2 cores       33x
Ratio 3 cores       32x
Ratio 4 cores       31x
Ratio 5 cores       30x
Ratio 6 cores       30x
Ratio 7 cores       30x
Ratio 8 cores       30x
TSC         2600.1 MHz
APERF           3000.0 MHz
MPERF           2599.9 MHz
Temperature 0       45°C (113°F) [0x2C] (Core #0)
Temperature 1       50°C (122°F) [0x27] (Package)
Power 0         59.22 W (Package)
Power 1         46.80 W (IA Cores)
Power 3         12.42 W (Uncore)
Voltage 0       1.00 Volts (VID)
Processor 2 ID = 1
Number of cores 8 (max 16)
Number of threads 16 (max 32)
Name Intel Xeon E5 2650 v2
Codename Ivy Bridge-EP/EX
Specification Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz
Package (platform ID) Socket 2011 LGA (0x0)
CPUID 6.E.4
Extended CPUID 6.3E
Core Stepping M0/M1
Technology 22 nm
TDP Limit 95.0 Watts
Tjmax 89.0 °C
Core Speed 2940.2 MHz
Multiplier x Bus Speed 30.0 x 98.0 MHz
Rated Bus speed 3528.3 MHz
Stock frequency 2600 MHz
Instructions sets MMX, SSE, SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, EM64T, AES, AVX
L1 Data cache 8 x 32 KBytes, 8-way set associative, 64-byte line size
L1 Instruction cache 8 x 32 KBytes, 8-way set associative, 64-byte line size
L2 cache 8 x 256 KBytes, 8-way set associative, 64-byte line size
L3 cache 20 MBytes, 20-way set associative, 64-byte line size
FID/VID Control yes
Turbo Mode      supported, enabled
Max non-turbo ratio 26x
Max turbo ratio     34x
Max efficiency ratio    12x
Max Power       150 Watts
Min Power       60 Watts
O/C bins        none
Ratio 1 core        34x
Ratio 2 cores       33x
Ratio 3 cores       32x
Ratio 4 cores       31x
Ratio 5 cores       30x
Ratio 6 cores       30x
Ratio 7 cores       30x
Ratio 8 cores       30x
TSC         2600.1 MHz
APERF           3000.0 MHz
MPERF           2599.8 MHz
Temperature 0       52°C (125°F) [0x25] (Core #0)
Temperature 17      55°C (131°F) [0x22] (Package)
Power 16            56.86 W (Package)
Power 17            44.53 W (IA Cores)
Power 19            12.33 W (Uncore)
Voltage 16      1.00 Volts (VID)
But get only 6-7 h/s for zcash nicehashv0.3a
WHY?????????????

Any one help ??

dual cpu in my workstation with Intel Xeon E5 2650 v2Intel Xeon E5 2650 v2
I get 500h/s on XMR mining with these CPU's
but on Zcash :( :(

Those numbers are extremely low for a CPU like that. Does the miner say it is using AVX when running? Did you change -t paramters?

low ......................   Xeon E5 2650 V2 with 16 cores and having 2 CPU in one system
I use -t parameters with more options
-t 6,-t16 and others but still not getting much hashes

Intel i7 6700K having only 8 cores ??

Please see image ??

ANY ONE THEIR FOR HELP

how long did you leave it running? it needs like 15-30 minutes to stabilize speed

Only 4-5 minutes running but not in upper image it is only starting of miner.
You mean to say CPU will take time to stable .
OKAY I'll start running it and contact again after one hours......
THANK YOU :)

cool, i'll be watching github
On Thu, Nov 3, 2016 at 10:21 AM, Tej Kumar<EMAIL_ADDRESS>wrote:

Only 4-5 minutes running but not in upper image it is only starting of
miner.
You mean to say CPU will take time to stable .
OKAY I'll start running it and contact again after one hours......
THANK YOU :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nicehash/nheqminer/issues/115#issuecomment-258094321,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5ZMNE7zc8V2174AvwtB12np8sWPPmMks5q6aeLgaJpZM4KoFGC
.

Hi Again ,
after running half an hour it show like this
what is the meaning of
2016-11-03 15:19:54.734446][0x000047b8]: Speed [300 sec]: 5.58667 I/s, 10.5333 Sols/s
[2016-11-03 15:20:05.060819][0x000047b8]: Speed [300 sec]: 5.58 I/s, 10.43 Sols/s
[2016-11-03 15:20:15.362824][0x000047b8]: Speed [300 sec]: 5.58333 I/s, 10.47 Sols/s
[2016-11-03 15:20:25.713438][0x000047b8]: Speed [300 sec]: 5.56667 I/s, 10.3867 Sols/s
[2016-11-03 15:20:26.240409][0x00003ef0]: stratum | Submitting share #29, nonce<PHONE_NUMBER>0000000000000000000000000000000000000000000022
[2016-11-03 15:20:26.512115][0x000042b0]: stratum | Accepted share #29
[2016-11-03 15:20:27.073641][0x00004184]: stratum | Submitting share #30, nonce<PHONE_NUMBER>0000000000000000000000000000000000000000000021
[2016-11-03 15:20:27.378639][0x000042b0]: stratum | Accepted share #30
[2016-11-03 15:20:36.023100][0x000047b8]: Speed [

ok,
a) can you post your command line plz
b) can you try closing those ~15 programs you are running while mining, and tell me speed again after ~30 minutes?

I use these on 3 systems
nheqminer.exe -u tjsangariya.tej -p x -t 16 -e 1
nheqminer.exe -u tjsangariya.tej -p x -t 16 -e 0
nheqminer.exe -u tjsangariya.tej -p x -t 16
I am a programmer so I'll work together with this but my other 2 system are free for this and they also have same output

a) you should be using AVX2 -not- AVX1 and -not- SSE2 , if you just remove -e it should autodetect the right one to use (provided you compiled the right one)
b) dont use 16 on 16cores HT , as mentioned in other bugs -and- documention, you should start at the number of -actual cores- for -t (in your case -t 8) and then start upping , -t 9 , -t 10 , -t 11 , to find which -exact- number of threads suits your 16core HT (no, its NOT 16, it never is)

Please see these 2 images having 2 physical processors and their configurations
and suggest the value of -t ??

Hello buzztiaan
Please reply my 10 workstation waiting for mining on Zcash ??

i already told you

dont use 16 on 16cores HT , as mentioned in other bugs -and- documention, you should start at the number of -actual cores- for -t (in your case -t 8) and then start upping , -t 9 , -t 10 , -t 11 , to find which -exact- number of threads suits your 16core HT (no, its NOT 16, it never is)

this isnt 'general help' this is for CODE issues, move to irc channel on freenode, #zcash-mining

:( :(


[AIRFLOW-4746] Implement GCP Cloud Tasks' Hook and Operators

Hello,
Here is an ticket related to GCP on Jira:
https://issues.apache.org/jira/browse/AIRFLOW-4746
Lots of love

@mik-laj @potiuk here is a PR waiting for a review
https://github.com/apache/airflow/pull/5402

Can you do a review too?  all eyes are very helpful.

Merged!


Add Open Category

Overall it looks very great. We should add tests/benchmark_open_category.py that allow miner to benchmark their endpoint and receive scores.
N_RUN=5

Get prompts from our server
Call miner endpoint to get images
Get scores from reward server
We should also add rate limit on the reward server for non validator ips

this pr mean we only add general prompt style. Can we add specific style for later updates @ViktorThink ?


Traduction problem

Hello all,
This is not a big problem.

How can i do to change the wrong traduction ? (I'm french).
I'd like the card says " a été fermé" ou "Fermé" for "was closed".
(same problem with "was opened").
Thanks.
My configuration :
-) shuttter card : v1.4.0
-) Home Assistant 2023.3.4
-) Supervisor 2023.03.1

Hello,
This value comes from HA. But you can replace it with the percentage so you won't see this bad translation.
To do it, just add this parameter in the card :
always_percentage: true

Thanks for your answer


Rich text label crash

When trying to resize Rich text label demo example all the way down in godot editor, editor crashes every time, and when trying to resize project window all the way down, it crashes too.  Also there some random crashes when typing long text inside [fill][/fill]
Deleting [fill][/fill] part fixed all the problems.

The editor still crashes when I type something long inside [fill][/fill]. Try press for example 'E' button inside existing [fill] tag to recreate problem. For me minimal number of words inside text in order to get error is 3. Also for me error never occured if I try to type at the end of the text.

Looks like a duplicate of #2688.


virt-operator: Fix AppComponent value in common-instancetypes

What this PR does / why we need it:
Previously kv.Spec.ProductComponent was not honored in all places when handling resources from common-instancetypes (e.g. deleting them and in tests). This extracts the existing logic to get the correct AppComponent value into a helper function and calls it in every place where the value is needed.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[x] Community: Announcement to kubevirt-dev was considered

Release note:

None

/cherry-pick release-1.1

/retest-required

/retest

/lgtm

/retest-required

/retest-required

/retest


Set up a virtual environment

An isolated environment to which developers can switch and then start contributing. I would prefer Python 3 environment. This might also require minor refactoring of the code too.

I'll start with this, this seems easy. :|

Great! Mention me if you run into any issues.

@abinashmeher999 I have made the environment. Just to be sure that I did that correctly, can you tell me how does one commit a virtual environment?
Also, what next?

This is the fun part. You can't commit all of the virtual environment. So it would be great if you could write a script(bash script would do) that creates the virtual environment and then prints the instructions to change into it.
Also you will need to freeze dependent packages into requirements.txt using pip freeze.

Yes I've already created the requirements.txt file. Actually, that was the only new addition to the project after creating virtual environment as all others are in .gitignore.
Also, by bash script I assume you mean a MakeFile, so I'll create the same.

No not a makefile. A simple .sh file would do, with all the commands that you executed to create it. Also test the Python 3 environment once with the sample code.

@ayuhsya  I see that you have committed the changes on the master branch itself. It is a bad practice to do so. Say you made all your changes to the master branch, you send the PR and let's assume didn't get merged because of some issues. Now you want to work on top of the latest master. Where do you pull that branch to? I hope you understand.

@abinashmeher999 can I setup virtual environment  in python 2.7 I am very much familiar with this.

@harshcrop We will be going to use Python 3 in the future because since we are dealing with wikipedia here and there will lots of unicode characters. And handling unicode is lot less painful in Python 3. Besides making a virtualenv for Python 3 is not very different from how you would do that for Python 2.7.
@ayuhsya Has already completed doing it. It would be pointless to the same thing again. Pull from @ayuhsya's commits from his master into a new branch and see if you can complete the PR.

@abinashmeher999 okay make new branch again can check his repo

Sorry didn't get you.

@abinashmeher999 I am asking that what I have to do now if this task is completed so, can I set up virtual environment for me in my repo and push into my branch and start working on new issue. That what I am asking you??

 Try #3

okay doing it

@abinashmeher999 Yes I know that we don't work on the master branch. But this task wasn't that major so I didn't bother creating a new branch. :neutral_face:

@ayuhsya You will realise that even a small task doesn't justify working on the master once you are on your second PR(not first) to this repo. Because the work needed then just to clean up is more than just creating a new branch.

Okay, I'll do things on new branch now. But what do I do to send pull request/what else is left to do in this issue?

@ayuhsya Have a look at this.

Addressed in #11.


added contributing.md file

What does this PR do?

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

added contributing.md file


Cc UI structure

This branch is about folder and file structure in CC UI, I dont know why the branch name did not change here, since it changed in gitHub desktop. I added information about the files in the README -file for you to get better understanding of what a file/folder is for. The reason that there are so many folders is to keep it tidyier and that all items/css/etc used in the tsx can be placed in the same folder, so they are easier to find.
This has been made as modeled in figma:
https://www.figma.com/file/eAGHe7brWxyw8W80xRHlXE/Connected-Circularity-team-library?node-id=432%3A3911

the pages-folder is bit buried under the components folder, I suggest removing it directly under src

the ui - folder and it's content seems unnecessary, is it needed?

actually yes, i need to delete it

I still need to create something to make sure users are all logged in to get in to other pages.


Overwrite assistants

I redefined the general and dev assistant to use gpt-4 by default. The help-option now lists the assistants twice:
positional arguments:
  {dev,general,bash,general,dev}

I've opened #17 to address this issue :)


IronPython 2.7.7: No data is available for encoding 0

I try to use python modules from C# project but Python.CreateEngine() throws exception
System.Reflection.TargetInvocationException: 'Failed to load language 'IronPython 2.7.7': No data is available for encoding 0. For information on defining a custom encoding, see the documentation for the Encoding.RegisterProvider method.'

TargetFramework: netcoreapp2.0
Visual Studio 2017 CE
Installed packages
<PackageReference Include="IronPython" Version="2.7.7" />
<PackageReference Include="IronPython.Interpreter" Version="2.7.4" />
<PackageReference Include="IronPython.StdLib" Version="2.7.7" />
<PackageReference Include="System.CodeDom" Version="4.4.0" />
<PackageReference Include="System.Text.Encoding.CodePages" Version="4.4.0" />

Sounds like you're trying to use it in a .NET Core app? We haven't released a .NET Core package yet.

Yes, .NET Core. Is support in plans? There are some approximate date?

Yes, we plan to support .NET Core (in fact the code is already merged in this repo if you wanted to build it yourself). We don't have an approximate date at this point but hopefully before the end of the month?

There is a beta release with .net core 2.0 support at https://ci.appveyor.com/project/AlexEarl/ironpython2/build/<IP_ADDRESS>-397/artifacts.

Hi - I've installed the IronPython v2.7.8-beta1 from nu-get and am getting the following error when I try to install the same version of StdLib...
Severity	Code	Description	Project	File	Line	Suppression State
Error		Unable to resolve dependencies. 'IronPython 2.7.8-beta1' is not compatible with 'IronPython.StdLib 2.7.8-beta1 constraint: IronPython (>= 2.7.8 && < 3.0.0)'.			0

@Quanghoster Ok, this should definitely be resolved when the final version is released. I'll also look into how to specify the versions so it works with pre-releases.


fix: show label for filters in filter box in explore

Bug: Doesn't show label in filters for FilterBox
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TEST PLAN
Added test for Filter box label
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10412 into master will decrease coverage by 6.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10412      +/-   ##
==========================================
- Coverage   70.68%   64.37%   -6.32%
==========================================
  Files         600      544      -56
  Lines       32147    30545    -1602
  Branches     3255     2886     -369
==========================================
- Hits        22724    19663    -3061
- Misses       9322    10704    +1382
- Partials      101      178      +77

Flag
Coverage Δ

#cypress
55.46% <ø> (-0.29%)
:arrow_down:

#javascript
?

#python
69.76% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...plore/components/controls/FilterBoxItemControl.jsx
12.96% <ø> (-61.12%)
:arrow_down:

...uperset-frontend/src/dashboard/util/dnd-reorder.js
0.00% <0.00%> (-100.00%)
:arrow_down:

...rset-frontend/src/dashboard/util/getEmptyLayout.js
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/dashboard/util/getFilterScopeFromNodesTree.js
0.00% <0.00%> (-93.48%)
:arrow_down:

superset-frontend/src/views/datasetList/Button.tsx
6.66% <0.00%> (-93.34%)
:arrow_down:

.../src/dashboard/components/FilterIndicatorGroup.jsx
11.76% <0.00%> (-88.24%)
:arrow_down:

...c/explore/components/controls/withVerification.jsx
9.09% <0.00%> (-87.88%)
:arrow_down:

...uperset-frontend/src/utils/getClientErrorObject.ts
0.00% <0.00%> (-87.10%)
:arrow_down:

...src/dashboard/components/gridComponents/Header.jsx
10.52% <0.00%> (-86.85%)
:arrow_down:

...rc/dashboard/components/gridComponents/Divider.jsx
13.33% <0.00%> (-86.67%)
:arrow_down:

... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae9f3a...c12c9ff. Read the comment docs.

@villebro Hi, fixed bug that you mentioned, @rusackas added assertion as proposed, it just was removed somehow in previous commit :)

@villebro added


translation adjustment and link to cdn

translation adjustment + link to cdnjs with newer Foundation versions added

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM 👍 :dart:
Thank you for the PR ✨ 🎉
We're happy to accept these changes and look forward to your future contributions :clap:
Happy coding! :octocat:


fix(#1763): filepicker's filetype filter when selecting files

Test Code
To test the issue change the accept=".jpg, .pdf" portion to test file types and MIME types (ex image/*, image/bmp, ...). Note: the . is required.
import { GoAFileUploadCard, GoAFileUploadInput, GoAFormItem } from "@abgov/react-components";
import { useState } from "react";

interface Uploader {
  upload: (url: string | ArrayBuffer) => void;
  abort: () => void;
}
interface Upload {
  name: string;
  file: File;
  uploader: Uploader;
}

class MockUploader implements Uploader {
  private processId?: any;

  public onprogress: (percent: number) => void = (_: number) => { };
  public onabort: () => void = () => { };
  public onfail: (err: string) => void = (_: string) => { };
  public oncomplete: () => void = () => { };

  upload(_url: string | ArrayBuffer) {
    let progress = 0;

    this.processId = setInterval(() => {
      progress += Math.random() * 10;
      this.onprogress(progress);
      if (progress >= 100) {
        this.oncomplete();
        clearInterval(this.processId);
      }
    }, 200);
  }

  abort() {
    // implement your logic to abort file upload
    console.log("implement logic here");
  }
}

export function BlankPage() {

  const [uploads, setUploads] = useState<Upload[]>([]);
  const [progressList, setProgressList] = useState<Record<string, number>>({});

  function deleteFile(file: Upload) {
    setUploads((uploadz) => {
      return uploadz.filter(u => u.name !== file.name);
    })
  }

  function uploadFile(file: File) {
    const reader = new FileReader();
    reader.onload = (e: ProgressEvent<FileReader>) => {
      if (!e.target) return;
      const url = e.target.result;
      const uploader = new MockUploader();

      setUploads(old => [...old, { name: file.name, file, uploader }]);

      uploader.onabort = () => console.log("Aborting upload");
      uploader.onfail = (err: string) => console.log("Upload failed: ", err);
      uploader.oncomplete = () => console.log("File upload complete");
      uploader.onprogress = (percent: number) => {
        setProgressList(old => ({ ...old, [file.name]: percent }));
      };

      if (url) {
        uploader.upload(url);
      }
    }
    reader.readAsDataURL(file);
  }

  return <>
    <GoAFormItem label="Upload a file">
      <GoAFileUploadInput onSelectFile={uploadFile} maxFileSize="100MB" accept=".jpg, .pdf" />
      {uploads.map(upload => (
        <GoAFileUploadCard
          key={upload.file.name}
          filename={upload.file.name}
          type={upload.file.type}
          size={upload.file.size}
          progress={progressList[upload.file.name]}
          onDelete={() => deleteFile(upload)}
          onCancel={() => deleteFile(upload)}
        />
      ))}
    </GoAFormItem>
  </>
}

Hi @chrisolsen, could you please give me a example about what is been fixed? Thanks very much

Issues is verified on Chrome, Firefox, and edge for react and angular, for mobile and desktop site

:tada: This PR is included in version 1.17.0-alpha.36 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.17.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.20.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.20.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adding 'user_type' field to 'User' model

Added a choice-field (Owner / Seeker) to the base user model.
Altered admin.py to view these changes.
Migration file was auto-generated.
fix #42

This field is not needed.
One to one connections can be accessed from both directions.
--closed--


Specify that all should be a tuple

We've had some conversation about this on slack in the past, and settled on tuple, but never specified it in the dev guide.

A tuple seems right to me given that you don't want someone to change the content, but there is a problem that the Python docs themselves use a list: https://docs.python.org/3/tutorial/modules.html#importing-from-a-package
Not sure if we want to require tuple or just allow Sequence.

The other downside of tuple is that:
__all__ = ("myfunc")

is not what you want but
__all__ = ["myfunc"]

will work without having to worry about the trailing comma.

Yeah, there's a tradeoff either way. Having ("myfunc") is caught immediately on import, and we don't have a lot of single-object modules. Should we have a poll?

I'm happy to let @ktlim decide.

It's really hard to search for __all__ tuple list on Slack :)
A GitHub search for __all__ = ( gives 234K code results; __all__ = [ gives 963K code results.
The "caught immediately on import" for a missing trailing comma gives a less-than-fully-helpful error (AttributeError: module 'y' has no attribute 'm').
https://stackoverflow.com/questions/66098828/using-list-instead-of-tuple-in-module-all gives some more arguments for list over tuple (including that it is sometimes useful to extend a list programmatically).  "Accidentally" modifying __all__ seems pretty unlikely.
I would prefer to go with the syntax in the Python docs, so until the docs give a tuple example, we should stick with list.

Note that even cpython is internally inconsistent: the somewhat newer asyncio and tomllib use tuple, while most other modules seem to use list (including ones where it's required due to modification).


not compatible with lens 6.0

In the last lens version this extension it's not compatible.

You can manually patch and build this yourself for now. If you clone the repo and edit the package.json to
"engines": {
"lens": "^6.0.0"
}
Then build and package as described in the readme.

Thank you that worked.


integration-tests-sentry-cli.yml failing

error: API request failed
caused by: sentry reported an error: unknown error (http status: 501)
DEBUG   2023-03-23 08:17:21.033209 +01:00 skipping update nagger because session is not attended
stdout: > Rewriting sources

Adding source map references
Bundled 0 files for upload
Uploaded release files to Sentry

Stopping the test-server ... /STOP request failed: Unable to read data from the transport connection: Connection reset by peer. - killing the server process instead
ParentContainsErrorRecordException: /Users/user/Github/sentry-dart-plugin/integration-test/scripts/test.ps1:72
Line |
72 |          $Callback.Invoke()
|          ~~~~~~~~~~~~~~~~~~
| Exception calling "Invoke" with "0" argument(s): "The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Source map not uploaded"

@vaind do you know if something changed in the CLI? didn't check it yet but the integrations are failing.
IIRC upload-dif is now an alias to debug-files upload maybe the APIs changed too? Related to https://github.com/getsentry/team-mobile/issues/97
Just a hunch tho, have not investigated it yet.

Do you mean this change from the latest release? https://github.com/getsentry/sentry-cli/releases/tag/2.15.2
fix: Make sourcemap injection on upload opt-in (https://github.com/getsentry/sentry-cli/pull/1534)
sinde the error you've pasted says Source map not uploaded

@denrase this part is still very flaky.

Checking symbol server output
Verifying debug symbol upload...
app.so: count=3 - OK
libapp.so: count=3 - OK
libflutter.so: count=6 - OK
libhello_santry.so: count=12 - MISSING
Server received '3' instead.
libhello_santry.so.sym: count=4 - OK
Error: Process completed with exit code 1.

For some reason, libhello_santry.so is constantly changing, not sure why.

@denrase this part is still very flaky.

Checking symbol server output
Verifying debug symbol upload...
app.so: count=3 - OK
libapp.so: count=3 - OK
libflutter.so: count=6 - OK
libhello_santry.so: count=12 - MISSING
Server received '3' instead.
libhello_santry.so.sym: count=4 - OK
Error: Process completed with exit code 1.

For some reason, libhello_santry.so is constantly changing, not sure why.

I'd suggest looking at the reusable workflow... I did away with the strict checks. See a sample test script and CI job in sentry-dotnet.


A fix for the duplicate tree missing orphans problem.

This fix assumes that the create and copy tree usage is the same
as merkleeyes. That is, after each save, two copies of the
tree are made, and all three copies are accessed.

I don't think this is how we want to fix this. It leaks way too much of the ABCI abstraction into the tree library

I agree, the iavl code should not have to know (or guess, in this case) how it is getting used.
This only affects nodes that have persisted, for the others the GC tracks the pointers correctly and doesn't free the node while it is referenced by any of the trees. In a sense, because the copies of the trees are not independent, we're basically rolling our own persistent GC (but by searching to track references, not explicitly keeping track of them).
Suggestions?


docs: Add sync_to_translation_status.er

Create Erg scripts and resolve #345 🎉

Partially using Python to solve some problems Erg can't seem to do now
Currently probably not supporting Windows

CI to automatically synchronize translation_status
Currently there are items that do not work because the URLs are incorrect, correction of the URLs or file names will fix it

@mtshiba @C-BJ

Thank you so much!