socket connection is not connected although pusher:connection_established event was fired

Hi,
I have a problem with Pusher that I need support. Whenever I use the app, then press power button to turn screen off, the socket connection will be closed. When I turn on again, I listen to connectionStateDelegate to make connection again. However, it cannot auto re-subscribe to existing channels because socket connection is not connected. Please check the code below:
    private func handleConnectionEstablishedEvent(json: PusherEventJSON) {
        if let data = json["data"] as? String {
            if let connectionData = getPusherEventJSONFromString(data), socketId = connectionData["socket_id"] as? String {
                updateConnectionState(.Connected)
                self.socketId = socketId

                print("socket: \(socketId) - connected: \(self.socket.isConnected)") // this shows connected: false

                for (_, channel) in self.channels.channels {
                    if !channel.subscribed {
                        if !self.authorize(channel) {
                            print("Unable to subscribe to channel: \(channel.name)")
                        }
                    }
                }
            }
        }
    }

As you can see, the log in the middle of the function is what I used to debug, it prints out connected: false.
According to my debug, this code did enter the authorize(channel) but socket is not connected so it cannot call to pusher server (no debug log on pusher server as well).
Sometime this works fine, because socket can make connection before this method is called. But most of the time it won't work.... I don't know why handleConnectionEstablishedEvent is called when event pusher:connection_established is fired, but still socket connection is not ready. Could this be pusher server problem or the WebSocket library problem (Starscream)?
In the meantime, I will switch back to libPusher (ObjC library) which didn't have this problem in my other apps. But libPusher is kinda outdated so I would like to use this library more. Hope you guys can have this resolved soon. Thank you.

There might be a bug here but I just want to make a few things clear about how the library should be working by default.
If you haven't explicitly set autoReconnect to false then upon disconnection all channels will have their subscribed property set to false.
Upon reconnection, the client will receive a pusher:connection_established event which will then re-establish subscriptions to channels that were previously subscribed to, prior to the disconnection.
As I say, this is the default behaviour. You don't need to handle calling connect again or anything like that.
If a pusher:connection_established event is received then the socket connection is definitely open. It can't receive it otherwise.
It looks like there could be a scenario where the pusher:connection_established event is received over an open socket and the socket is then immediately closed, before the handling of the connection established event has completed. However, this seems incredibly unlikely. If you're able to reliably reproduce this or provide steps for doing so then please could you provide a sample project or a list of steps to reproduce?

@thanhn08 have you encountered this problem again?
If so, could you try with PusherSwift 1.0.0 (the latest release) to see if it's still occurring?

@thanhn08 any updates or can I close the issue?

Sorry i have been too swamped. I will check this soon tonight or tomorrow.
On Jul 7, 2016 17:54, "Hamilton Chapman"<EMAIL_ADDRESS>wrote:

@thanhn08 https://github.com/thanhn08 any updates or can I close the
issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pusher/pusher-websocket-swift/issues/51#issuecomment-231046391,
or mute the thread
https://github.com/notifications/unsubscribe/ABLmIm6q1P3lQtrk75xibRXNlES-_URkks5qTNrcgaJpZM4IsYhA
.

Hi @thanhn08, if this is still relevant to you, please could you try using PusherSwift 3.1.0 (the latest release) to see if it's still occurring?

Closing as stale - if this is still occurring then we can reopen 👍

I can reproduce the same issue on 2.0.1. Could you include a fix for it or give a hint where I should look?

You are processing the first message to get the code based on which you set the value for connected, but when that message is processed, you also call the delegate method for received message. Thus you end up calling the delegate method for a message handling before actually updating the socket connection.

@CataD256 I'm not sure I understand what you're saying. The when you say "delegate method", which delegate method do you mean? Do you mean the debugLog method? If so, that shouldn't have any impact as it's just there for debugging. It's not doing anything to change state internally. If you're referring to a different delegate method, please let me know which one 🙂
I'm also not quite sure what you mean by this:

You are processing the first message to get the code based on which you set the value for connected

The only thing I've just seen is that in this line: https://github.com/pusher/pusher-websocket-swift/blob/fe6563ba9ff08b755a8ff4b4c2323b177fdfdb7b/Source/PusherWebsocketDelegate.swift#L35 I might need to include the case where the connection state is already marked as disconnected. You could try testing that to see if that fixes it for you?

I traced the code and got to the following scenario:

I can confirm that yes, websocketDidReceiveMessage is called before websocketDidConnect is called. That's to be expected though, as the pusher:connection_established message is sent on connection. That's also what this library (PusherSwift) uses to determine when a connection is established and therefore when to set the connectionState property to .connected.
As you can see here, the websocketDidConnect delegate function is not used at all: https://github.com/pusher/pusher-websocket-swift/blob/master/Source/PusherWebsocketDelegate.swift#L106
I guess my real question is, what's the problem with what currently happens?
I've tried (using the included iOS Example app) calling disconnect() and connect() over and over again on the Pusher object and the channels always seem to resubscribe. Is that where your problem is occurring - lack of resubscription?

This is the way I use the library.
    internal func connectIfNeeded() {
        if pusher.connection.connectionState == .Disconnected {
            self.pusher.connect()
        }
    }

    internal func subscribeToChannel(listId: Int, delegate: PusherManagerProtocol) {
        connectIfNeeded()
        let channelName = "channel_list_\(listId)"
        self.subscribedChannel.append(channelName)
        let channel = self.pusher.subscribe(channelName)

        for event in events {
            channel.bind(event.rawValue, callback: { (data) in
                delegate.onEventReceived(event, data: data)
            })
            self.subscribedChannelEvents.append(event)
        }
    }

    internal func unsubscribe(completion: (() -> ())? = nil) {
        self.pusher.unbindAll()
        subscribedChannelEvents.removeAll()

        for item in self.subscribedChannel {
            self.pusher.unsubscribe(item)
        }
        subscribedChannel.removeAll()

        self.pusher.disconnect()

        if completion != nil {
            completion!()
        }
    }

I alternate calling "subscribeToChannel" and then "unsubscribe". Would this, in your opinion lead to som inconsistency, or could it make a channel end up not being able to subscribe?

It obviously depends a bit on the context of your specific use case but for the general case I've got a few notes about how you're interacting with the library.
If you want a client to stop receiving events from Pusher, the only thing you really need to do is to call self.pusher.disconnect(). That should be enough. That will leave all event handlers tied to any channels that were subscribed to when disconnect was called, and will keep track of all the channels themselves that were subscribed to.
That means that if you then want to reconnect, all you need to do is call self.pusher.connect(). You don't have to worry about calling subscribe, or worry about calling unsubscribe or unbind(All) when disconnecting in the first place.
If you don't just want to disconnect and instead you want to have a "fresh" state when someone does something that calls the internal func unsubscribe(...) in your code above, then I'd recommend just calling self.pusher.disconnect() and then when someone wants to reconnect with no channel subscriptions etc, then just assign a new Pusher client object to self.pusher, i.e. self.pusher = Pusher("YOUR_APP_KEY", options: YourPusherClientOptions).

I'll try with reinstantiating my pusher object. Will let you know of the outcome :)

@CataD256 Any luck?

Hey @hamchapman! I tried the recreating the pusher object every time I want to subscribe to a channel, but I can still randomly reproduce the issue. I could give you the state of the connection and channels when that happens. Trying to call reconnect does not seem to help when I get in that state.

Interesting. And yeah, having the state of the connection and the channels when the issue occurs would definitely be handy!
Also, just to be clear, is the issue that subscriptions aren't reestablished when you then call connect again?

It happens on the first try also, not necessarily on re-subscription.

Subscriptions sometimes don't work even when just calling connect() for the first time?
Would you be able to create a project that contains code that will recreate the issue? That would be a massive help with debugging this. Thanks!

#108 should fix this issue. I'll be releasing a version 4.0.2 today :


0.8.2 change, new error

On the latest version, 0.8.2 I am getting caught with the error, App must be running before you can run middleware!, here,  but not on previous releases. Using spf as a requirement of Sanic-Cors.
Output:
Starting...
[2019-08-20 07:44:33 -0400] [66363] [DEBUG]

                 Sanic
         Build Fast. Run Fast.

[2019-08-20 07:44:33 -0400] [66363] [INFO] Goin' Fast @ http://<IP_ADDRESS>:8000
[2019-08-20 07:44:43 -0400] [66363] [ERROR] Exception occurred while handling uri: 'http://<IP_ADDRESS>:8000/'
Traceback (most recent call last):
  File ".../venv/lib/python3.7/site-packages/sanic/app.py", line 910, in handle_request
    response = await self._run_request_middleware(request)
  File ".../venv/lib/python3.7/site-packages/spf/framework.py", line 533, in _run_request_middleware
    "App must be running before you can run middleware!"
AssertionError: App must be running before you can run middleware!
[2019-08-20 07:44:43 -0400] [66363] [DEBUG] CORS: Request to '/' matches CORS resource '/*'. Using options: {'origins': ['.*'], 'methods': 'DELETE, GET, HEAD, OPTIONS, PATCH, POST, PUT', 'allow_headers': ['.*'], 'expose_headers': None, 'supports_credentials': False, 'max_age': None, 'send_wildcard': False, 'automatic_options': False, 'vary_header': True, 'resources': '/*', 'intercept_exceptions': True, 'always_send': True}
[2019-08-20 07:44:43 -0400] [66363] [DEBUG] CORS: Cannot find the request context. Is request already finished?
[2019-08-20 07:44:43 -0400] [66363] [DEBUG] CORS: Cannot find the request context. Is request already finished?
[2019-08-20 07:44:43 -0400] - (sanic.access)[INFO][<IP_ADDRESS>:54246]: GET http://<IP_ADDRESS>:8000/  500 144
[2019-08-20 07:44:48 -0400] [66363] [DEBUG] KeepAlive Timeout. Closing connection.

Python 3.7.4 (but same error with earlier versions)
sanic==19.6.2
Sanic-Cors==0.9.8.post3
Sanic-Plugins-Framework==0.8.2
Test to reproduce error:
from sanic import Sanic
from sanic.response import json
from sanic_cors import CORS

import asyncio

app = Sanic(__name__)

CORS(app, resources=r'/*')

async def hello(request):
    return json({"hello": "world"})

app.add_route(
    hello,
    '/',
    methods=['GET', 'POST']
)

def run():
    loop = asyncio.get_event_loop()
    srv_coro = app.create_server(
        host='<IP_ADDRESS>',
        port=8000,
        return_asyncio_server=True,
        asyncio_server_kwargs=None,
        debug=True
    )
    asyncio.ensure_future(srv_coro)

    try:
        loop.run_forever()
    except KeyboardInterrupt:
        loop.stop()

if __name__ == '__main__':
    print('Starting...')
    run()

Thanks for this report.
In 0.8.2 some changes needed to be made to the order some things run, to ensure compatibility with Sanic 19.6 (particularly ASGI mode), so I'm guessing theres a side-effect of that which is causing this.
I will look into it.

Ok, so I've found the problem.
In pre-v0.8.2, the Sanic-Plugins-Framework before-run initialisation routine was configured to run on before_server_start. This worked great until ASGI support was added. In ASGI mode, the server never runs the before_server_start trigger.
So in v0.8.2 the initialisation routine was changed to run on after_server_start which is in most cases not very different in logic, and sanic.run() and ASGI mode both support it.
Unfortunately it looks like using app.create_server() like in your example, it never triggers the after_server_start event. So Sanic-Plugins-Framework never executes its initialisation routine.
I will need raise this with the Sanic devs as a potential issue going forward, particularly for plugin creators.
As a temporary fix, you can force the run of the _on_server_start method in Sanic-Plugins-Framework, like this:
from sanic import Sanic
from sanic.response import json
from sanic_cors import CORS
from spf import SanicPluginsFramework
import asyncio

app = Sanic(__name__)
spf = SanicPluginsFramework(app)
cors = spf.register_plugin(CORS, resources=r'/*')

async def hello(request):
    return json({"hello": "world"})

app.add_route(
    hello,
    '/',
    methods=['GET', 'POST']
)

def run():
    loop = asyncio.get_event_loop()
    srv_coro = app.create_server(
        host='<IP_ADDRESS>',
        port=8000,
        return_asyncio_server=True,
        asyncio_server_kwargs=None,
        debug=True
    )
    asyncio.ensure_future(srv_coro)
    spf._on_server_start(app, loop)
    try:
        loop.run_forever()
    except KeyboardInterrupt:
        loop.stop()

if __name__ == '__main__':
    print('Starting...')
    run()

Thanks @ashleysommer, I can confirm this works for my application.

@jmbott  I've created a post on the Sanic community forum about this issue.
https://community.sanicframework.org/t/triggering-after-server-start-event-when-running-asyncio-server/385
Feel free to join in.

@jmbott
Good news, a fix for this in Sanic Core has been accepted, and will be in the next release of Sanic:
https://github.com/huge-success/sanic/pull/1676


Out of the box issues with Typescript

Wrapping my Application around <MuiPickersUtilsProvider utils={MomentUtils}> just plain out refuses to compile with said errors.
Is this something only related to bad typing?

Please provide the reproduction on codesandbox

Provide an example how to reproduce it

Closing due to inactivity


RR-823: Use new goal summary card on overview

Use the new goal summary card on overview. As we no longer use the goal numbering I've also removed that logic from the mapper and moved the sorting into the template as per view archived goals.
Minor tweaks to styling and changed "last updated" to "last updated on".
I'll rename from v2 in a separate PR. As the old one is removed here it would've made the diff difficult to read.

Still waiting for final confirmation on the ticket which is why this is "DO_NOT_MERGE"

This change is now sanctioned so removed the do not merge


[New term] Theme Switcher for Dark and Light mode

1. Please describe why this term needs to be added
What this term is about? (briefly)

This is about adding a theme switcher (new feature, these days trending on every website)

Why this term needs to be added? (briefly)

Because the website's dark and light modes, affect our eyes so users can switch according to their lightning.

Feature demo = https://mandeepdev.vercel.app/
2. Checklist

[X] The suggested term fits the cloud native definition or is essential to understanding cloud native terms. (We hope to avoid adding general or broad terminologies)
[X] There is no existing issue yet. (shift+click to check existing issues)
[X] I understand that maintainers will assess if the term should be part of the Glossary. (Please be patient)
[ ] I want to work on this term. (If not checked, maintainers will assign another volunteer)

(Note)
Maintainers will assign a label after assessment procedure.
(from triage/awaiting to triage/accepted or triage/not accepted)
A contributor can be assigned to this issue after the issue get the triage/accepted label.
The assignee needs to check Style Guide.

Hi @mandeepsng
I think Theme Switcher is a too general term and not suitable as a cloud native term.
Why do you think Theme Switcher fits the cloud native definition ?

Because the website's dark and light modes, affect our eyes so users can switch according to their lightning and
hard to read when light off, dark mode is very useful at that case.
and this is cool trending feature in now days.

I guess that what @mandeepsng suggests is the feature in the CNCF Glossary website that toggles dark mode and light mode, and that he just picked an wrong issue template.

Hi @jihoon-seo
Thank you for your reply.
So what should be an exact template for this?

For now and for this case, you can open a blank issue with no issue template:

thank you
should I close this now?

You can edit this issue, but it might be easier to close this and open a new one.

ok


Updated deployment template to use string substitution when applicable

Describe what this PR does and why we need it:
This PR fixes yaml errors when using characters in a password
Changes proposed in this pull request

Use strings for config map

CI failed


Fix post merge test failures

Fixes #531 with the following upgrades:
Improved threading unit test code to make it more robust:

Delete the destructive os.chdir() call.
Pass the working directory to subprocess.Popen() call instead.
Shifted the backup and restore of existing run_config.yml into a context manager to ensure resources are properly restored in the event of an exception or crash.
(tested by CTRL-C breaking the threading unit test)

Also took the chance to enable debug output in input/utils/read.py VideoThread.__del__ as the subprocess.Popen() no longer crashes upon exit on Nvidia Jetson Xavier Ubuntu 18.04 (tested).

LGTM


Python

Description 📜
Added Video for Errors and its Types in Python. Elaborated What are erros and its Types, What are various types of exceptions and how to handle them with try , except  block.
Fixes # <713>

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[ ] Doc#umentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] Java#Script
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@Randrita I have added the links

@Randrita Thank you!!


Update README.md

put semicolon on the same line as last statement

it is practical to have semicolon on separate line.
PR declined.


Add string-utils extension

Description
In my day to day job I often find myself checking the length of a String, mainly to check if it fits database constraints. As I'm too lazy to open VSCode for that, I figured out that a Raycast Extension will be a good time saver.
As it's not enough to make it an extension, I extended the scope to have an extension that allow multiple operations on Strings, the final goal being to replicate CyberChef operation within Raycast itself.
Current Operations implemented :

Get String Length
Reverse String
To Lower Case
To Upper Case

Screencast
https://streamable.com/qfdy3q
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
Thanks for your contribution 🔥
Have you tried this extension, it might be doing what you're after 🙂
Also Change Case can manipulate strings

Ah Indeed i did not found it first time ! I'm closing as those are way more completes


improve podman commit documentation and error messages

document --format|-f in the commit man page.  also, improve the error
message when user tries to use -m with the oci image format.
Resolves: 765
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM once the docker vs Docker issue is resolved.

bot, retest this please

@rh-atomic-bot r+


Toggl Windows App Issue on Multiple Monitor Setup

💻 Environment
Platform: Windows
OS Version: N/A
Toggl Version: 7.4.252
🐞 Actual behavior
If you have left the program on your secondary screen when turning off the computer and restart without secondary screen it is still on the secondary screen even though you can't see it. I can only see the visual effect of the window maximising and minimising to a screen which is not there.
You can see the client flashing by the roboform popup in the lower right hand corner (and that pop up in unrelated). Please note, no other screen is connected. This effectively makes the desktop client unavailable for me until I connect to two screens and bring it back to the primary screen.
💯 Expected behavior
App should recognize active display set and should accommodate view to active display(s).
🔨 Steps to reproduce
See "Actual Behaviour" for information
📦 Additional info
https://app.intercom.io/a/apps/ayixs927/inbox/inbox/2137598/conversations/19951536312
(Case link includes screenshot for reference)

The problem happens because Utils.visibleOnAnyScreen() method does not account for DPI of the monitor. We account for DPI in some other places, but not separately per monitor.
To make it work correctly we need to implement per-monitor DPI awareness, see #2066.

Case link


Document Num.Str

I think this is an infrastructure problem.

Let me keep this open, and I'll use to fix the tests.

FYI I may be wrong but I opened https://github.com/JJ/perl6-doccer/pull/2


Duplication of file search results

Issue Type: Bug

All extensions disabled, empty settings file, no working changes
Use file search

The pullRequestNode.ts file appears 4 times, some other results are duplicated, others appear only once.
VS Code version: Code - Insiders 1.38.0-insider (20dd80d91a76cbe80fb1d1979c3a9f02d94ba161, 2019-08-29T14:02:52.867Z)
OS version: Darwin x64 18.7.0

Seems that these entries were left over from the PR extension which used to set a path on URIs but doesn't anymore


Brainpool curves are not supported in Java 17

Expected Behavior
I expected all unit tests to run correctly under Java 17.
Actual Behavior
Unit tests that use brainpool curves fail.
Steps to Reproduce the Problem
master * % java -version
openjdk version "17.0.6" 2023-01-17
OpenJDK Runtime Environment Temurin-17.0.6+10 (build 17.0.6+10)
OpenJDK 64-Bit Server VM Temurin-17.0.6+10 (build 17.0.6+10, mixed mode)

master * % ./gradlew test

Welcome to Gradle 7.5!

Here are the highlights of this release:
 - Support for Java 18
 - Support for building with Groovy 4
 - Much more responsive continuous builds
 - Improved diagnostics for dependency resolution

For more details see https://docs.gradle.org/7.5/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :identity:compileJava
Note: /Volumes/Projects/DVV/identity-credential/identity/src/main/java/com/android/identity/internal/Util.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :identity-android:compileDebugJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :identity-android:compileReleaseJavaWithJavac
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :identity:test

com.android.identity.internal.UtilTest > coseSignAndVerify_brainpoolP256r1 FAILED
    java.lang.IllegalStateException at UtilTest.java:471
        Caused by: java.security.SignatureException at UtilTest.java:471

com.android.identity.internal.UtilTest > coseSignAndVerify_brainpoolP384r1 FAILED
    java.lang.IllegalStateException at UtilTest.java:494
        Caused by: java.security.SignatureException at UtilTest.java:494

com.android.identity.internal.UtilTest > coseSignAndVerify_brainpoolP512r1 FAILED
    java.lang.IllegalStateException at UtilTest.java:517
        Caused by: java.security.SignatureException at UtilTest.java:517

com.android.identity.keystore.BouncyCastleKeystoreTest > testEcKeySigningAllCurves FAILED
    org.bouncycastle.operator.RuntimeOperatorException at BouncyCastleKeystoreTest.java:492
        Caused by: java.security.SignatureException at BouncyCastleKeystoreTest.java:492

com.android.identity.keystore.BouncyCastleKeystoreTest > testEcKeyEcdhAllCurves FAILED
    java.lang.AssertionError at BouncyCastleKeystoreTest.java:640
        Caused by: java.security.InvalidAlgorithmParameterException at BouncyCastleKeystoreTest.java:617

com.android.identity.mdoc.request.DeviceRequestParserTest > testDeviceRequestParserReaderAuth_brainpoolP256r1 FAILED
    java.lang.IllegalStateException at DeviceRequestParserTest.java:243
        Caused by: java.security.SignatureException at DeviceRequestParserTest.java:243

com.android.identity.mdoc.request.DeviceRequestParserTest > testDeviceRequestParserReaderAuth_brainpoolP384r1 FAILED
    java.lang.IllegalStateException at DeviceRequestParserTest.java:243
        Caused by: java.security.SignatureException at DeviceRequestParserTest.java:243

com.android.identity.mdoc.request.DeviceRequestParserTest > testDeviceRequestParserReaderAuth_brainpoolP512r1 FAILED
    java.lang.IllegalStateException at DeviceRequestParserTest.java:243
        Caused by: java.security.SignatureException at DeviceRequestParserTest.java:243

com.android.identity.mdoc.sessionencryption.SessionEncryptionTest > testBrainpool256 FAILED
    java.lang.IllegalStateException at SessionEncryptionTest.java:161
        Caused by: java.security.InvalidAlgorithmParameterException at SessionEncryptionTest.java:161

com.android.identity.mdoc.sessionencryption.SessionEncryptionTest > testBrainpool320 FAILED
    java.lang.IllegalStateException at SessionEncryptionTest.java:161
        Caused by: java.security.InvalidAlgorithmParameterException at SessionEncryptionTest.java:161

com.android.identity.mdoc.sessionencryption.SessionEncryptionTest > testBrainpool384 FAILED
    java.lang.IllegalStateException at SessionEncryptionTest.java:161
        Caused by: java.security.InvalidAlgorithmParameterException at SessionEncryptionTest.java:161

com.android.identity.mdoc.sessionencryption.SessionEncryptionTest > testBrainpool521 FAILED
    java.lang.IllegalStateException at SessionEncryptionTest.java:161
        Caused by: java.security.InvalidAlgorithmParameterException at SessionEncryptionTest.java:161

168 tests completed, 12 failed, 4 skipped

> Task :identity:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':identity:test'.
> There were failing tests. See the report at: file:///Volumes/Projects/DVV/identity-credential/identity/build/reports/tests/test/index.html

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 45s
111 actionable tasks: 111 executed

I have fixed the issue locally by adding the BouncyCastleProvider as the first provider in the list instead of appending it to the end of the list (as the tests currently do). I can submit a PR with these changes if this is suitable? Or should we prefer the default provider and use BouncyCastle only for the tests that use brainpool curves?


IE bug - mat-datepicker is not giving the correct year date when typing a date with a year of two digits

What is the expected behavior?
The expected behavior is to convert 01/12/17 to 01/12/2017 on blur (when user clicks away)

it's working fine in Chrome browser

What is the current behavior?
The current behavior in (IE browser) is that mat-datepicker converts 01/12/17 to 01/12/1917
What are the steps to reproduce?
try the link in IE browser to see the issue
try the link in Chrome to see the expected behavior
https://material.angular.io/components/datepicker/overview
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 7
Typscript: 3.1.6
Browser Affected: IE browser
Is there anything else we should know?
thank you

@ayoubde From what I understood this is the expected behavior of IE. You can see that this was described in MDN Compatibility notes (Date.parse). You can just follow the advice that was given on the notes section or you could redirect this problem to Microsoft Community Support

@Aleksandyr thank you for the response. I will review the notes in the meantime and see if it works.

@Aleksandyr  I resolved it.
I used moment.js library to solve it.
I installed moment library  (npm install --save moment)
I also installed material-moment-adapter (npm install --save @angular/material-moment-adapter )
In app.module.ts file I wrote the code below:
import { MAT_MOMENT_DATE_FORMATS, MomentDateAdapter } from '@angular/material-moment-``adapter';
import { DateAdapter, MAT_DATE_FORMATS, MAT_DATE_LOCALE } from '@angular/material/core';
providers: [
{ provide: DateAdapter, useClass: MomentDateAdapter, deps: [MAT_DATE_LOCALE] },
{ provide: MAT_DATE_FORMATS, useValue: MAT_MOMENT_DATE_FORMATS },
]
in my datepicker component I did the following
import * as _moment from 'moment'; const moment = _moment; myDate = new FormControl(moment());


ShaderMaterial doesn't save with sensible defaults

Godot version:
3.2 rc3
OS/device including version:
ArcoLinux
Issue description:
When creating a ShaderMaterial and assigning it a shader, Godot will not supply the shader params with sensible defaults, but instead assign null to anything which wasn't set manually.
uniform vec4 base_color : hint_color;
uniform vec4 pattern_color : hint_color = vec4(1);
uniform sampler2D pattern_texture : hint_albedo;
uniform vec2 pattern_size = vec2(1);
uniform vec2 pattern_offset;
uniform vec4 black : hint_color = vec4(.06, .09, .16, 1);
uniform vec4 white : hint_color = vec4(1., .91, .83, 1);
uniform bool shadeless;
uniform bool specular;
uniform float spec_softness : hint_range(0, 1) = 0.01;
uniform float spec_size : hint_range(0, 1) = 0.01;
uniform float threshold : hint_range(0, 1) = 0.;
uniform float softness : hint_range(0, 1) = 0.2;

[gd_resource type="ShaderMaterial" load_steps=2 format=2]

[ext_resource path="res://Source/Shaders/DaisyShader2.shader" type="Shader" id=1]

[resource]
shader = ExtResource( 1 )
shader_param/base_color = null
shader_param/pattern_color = Color( 1, 1, 1, 1 )
shader_param/pattern_size = Vector2( 1, 1 )
shader_param/pattern_offset = null
shader_param/black = Color( 0.06, 0.09, 0.16, 1 )
shader_param/white = Color( 1, 0.91, 0.83, 1 )
shader_param/shadeless = null
shader_param/specular = null
shader_param/spec_softness = 0.01
shader_param/spec_size = 0.01
shader_param/threshold = 0.0
shader_param/softness = 0.2

As seen above, many params are saved as null, when they should be colors, vectors or booleans.  In the editor, these always default to, e.g. black, Vector2(0, 0), and false.
This works up until the point where you attempt to access this param in code later in, e.g. (bool)shaderMat.GetShaderParam("specular"), in which case you get a game crash and a confusing error about something somewhere being null; your first thought is to wonder if the shader material itself is null, but it doesn't seem to be, and you would hardly guess it's due to a value type being null.
In an ideal Godot, ShaderMaterial resources would be saved with sensible defaults for its value types; it makes sense for a sampler2d to be possibly null, but checking for a null bool is not intuitive, and checking every param you access for null is tedious.

Should we require defining default values for each uniform in the shader? Explicit may be better than implicit here.


Add maturity level to readme

Description
Per earlier chat thread, the Source Kafka plugin is in stable state wrt/ commands, flags, API etc. Also in addition it's shipped within our RH product.
Changes

Add maturity level to readme

Reference

Fixes #132
/cc @rhuss

/retest

/approve
/lgtm


DRILL-4801: Setting extractHeader attribute for CSV format does not p…

…ropagate to all drillbits

+1


Another issue on performance

Hi, i generated 86400 points with interval 1 second, from yesterday to today
let data = [];
let date = new Date(new Date().getTime() - (60*24)*60000);
// And then push every one second new point to data
for (let i = 0; i < 60*24*60; i++) {
  date = new Date(date.getTime() + 1000);
...

I create plunker
Have any idea what can help me?

that is just too much data, you should do a pan to load more, so only a few datapoints are downloaded first and more data gets incrementally downloaded as the user pans to see the past

also 0.7 beta has some performance improvements which almost improves the performance by 100% when there is lot of data, no difference with 0.6 when there is small amount of data displayed

Oh, thank, I am try do it now
Note: i use 0.7 beta on my local project too

Yeah, load more work perfectly, thanks again

but i add two features to my loadMore function
initial set
this.handleDownloadMoreInProgress = false;
on

when will this this.handleDownloadMoreInProgress become false again?
The way I would recommend is, to deal with this on userland, where if there are 2 successive calls to downloadMore, the user should cancel the prior download and download the latest only. also a debounce of say 200ms would also help
By doing this way, when one reaches the left most candle and there is nothing more to download the handleDownloadMore would simply do nothing

handleDownloadMore(start, end) {
    ...... ( here all code from your example )

    // Check if download more now
    if ( this.handleDownloadMoreInProgress ) return;

   // Set state for render
    this.setState({
      handleDownloadMoreInProgress: true,
    }, () => {
      // set local true
      this.handleDownloadMoreInProgress = true;
      .....

      setTimeout(() => {
        // simulate a lag for ajax
        this.setState({
          ....
          handleDownloadMoreInProgress: false, // become false
        }, () => {
          // become false for local
          this.handleDownloadMoreInProgress = false;
        });
      }, 300);
    });

 }

render() {
const {
      data, handleDownloadMoreInProgress,
      ....
    } = this.state;
   return <ChartCanvas
        ....
        panEvent={!handleDownloadMoreInProgress}
        zoomEvent={!handleDownloadMoreInProgress}
}

but i do not understand how combine updating data and load more example

oh handleDownloadMoreInProgress is already in userland, I understood it as a change in ChartCanvas.js, although I still recommend a debounce
RE updating data, I am not sure what the problem is, they are both independent of each other, kindly explain the problem

my problem is i have copy your EdgeIndicator and change
const x1 = Math.round(xScale(xValue)),
y1 = Math.round(yScale(yValue));

to
const x1 = 0// Math.round(xScale(xValue)),
y1 = Math.round(yScale(yValue));

for always see edge indicator
also change helper
const { plotData } = moreProps;

to
const { fullData: plotData } = moreProps;

why is x1 = 0 ? do you want to show the EdgeIndicator of the left most candle?

scratch that, what is your itemType? last I guess
if so, then the change
- const { plotData } = moreProps;
+ const { fullData: plotData } = moreProps;

should be enough no?

No, i want see line from edge indicator olways from left to right my chart, and for edgeindicator show always only last point of all data no matter when i pan now

ok, so the x1 = 0 is to get the line from the start of the chart.
Still not following why that is a problem for updating data, last(fullData) will continue to remain the same after the pan to add more

Problem becase when panToLoadMore you calculated new data and it is not full

huh
xScaleProvider(calculatedData.slice(-rowsToDownload).concat(prevData));
.concat(prevData) will make it full right?

On this case i have  full data with 86400 points, and it very lags,
for chart work normally here we slice our data to 180 points
when we have panToDownloadMore, we again slice initialData to 180 points back, and we dont pass full 86400 points to our chart, we pass only 180 points always, i right?

If i use concat, my data can be very big again

initially show 180 points, then when you pan, say you download 100 more, now after this
the linearData [] is of length 100 + 180, so fullData would be the 280 points

Oh, you have right

Maybe you can tell me what i do write in componentWillReceiveProps for append new data to state and dont lost my pan position

in 0.7 the secret to not losing pan position is to not change seriesName or xExtents that is all, you could send in a new data[] with data appended.

I can push new data to state and that all?

yes

Huh, i do not understand what is wrong
plunker

Oh, i fix it, plunker,
but when pan to left, and wait i see free space

Huh, please help, what wrong ?
componentWillReceiveProps(props) {

    const { data: prevData, ema26, ema12, macdCalculator, smaVolume50 } = this.state;
    const { data: inputData } = props;

    /* SERVER - START */
    const dataToCalculate = inputData.slice(-1);

    const calculatedData = ema26(ema12(macdCalculator(smaVolume50(dataToCalculate))));
    const indexCalculator = discontinuousTimeScaleProviderBuilder()
      .indexCalculator();

    const { index } = indexCalculator(
      prevData.concat(calculatedData)
    );
    /* SERVER - END */

    const xScaleProvider = discontinuousTimeScaleProviderBuilder()
      .withIndex(index);

    const { data: linearData, xScale, xAccessor, displayXAccessor } =
      xScaleProvider(prevData.concat(calculatedData));

    this.setState({
      linearData,
      data: linearData,
      xScale,
      xAccessor, displayXAccessor,
    });

  }

that is correct, are you expecting the end to be shown when a new candle is added?

No, i take screen now

Not following, is every thing good?

https://youtu.be/Klg3mP9ysp0

the problem here is App is adding data to the end every second, and the pan to load more is adding data to the front,
but the next second App is adding data to the end without the values already added by the pan to load more, checkout the first and last data in the render method to see this

So, maybe you can create worked example with dynamic update and load more on pan?

Sure that would be useful, I would appreciate if you can make that contribution. I am afraid I will not be able to do that now


Model deployed with new data but still get sample answers or no answers.

- [ `x`] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Followed the steps for local deployment and used azd up for deployment. Removed everything from /data folder and added one pdf with ~30 pages.

Any log messages given by the failure

No log messages. I can see md5 file created for the PDF I added.

Expected/desired behavior

The app is still answering questions from sample data or there is nothing in response.

OS and Version?

Windows 11

azd version?

azd version 1.5.0 (commit 012ae734904e0c376ce5074605a6d0d3f05789ee)

Versions

Mention any other details that might be useful

there is one escape character issue while running prepdocs.py as part of azd up.
Running "prepdocs.py"
C:\Users\Kreshnaa\rag\scripts\prepdocs.py:166: SyntaxWarning: invalid escape sequence '\d'
epilog="Example: prepdocs.py '..\data*' --storageaccount myaccount --container mycontainer --searchservice mysearch --index myindex -v",
C:\Users\Kreshnaa\rag\scripts\prepdocs.py:308: DeprecationWarning: There is no current event loop
loop = asyncio.get_event_loop()

So I am not sure if the file is even getting picked up for processing.
The app says this as list of data sources - which is not what I uploaded or not the default ones.

Hm, not sure where that syntax error is coming from. Did you modify scripts/prepdocs.py, scripts/prepdocs.sh, or scripts/prepdocs.ps1?
I recommend running either ./scripts/prepdocs.sh or ./scripts/prepdocs.ps1 on its own (depending what OS you're on), so that you can debug the syntax error.

Actually, both of those are warnings, not errors, so that shouldn't break your code. What version of Python are you using? What else is in your logs after those warnings?

I had the same error when I had something other than a pdf document in my docs folder


Document Use of falcosidekick.config.existingSecret In Values File

After a lot of searching I have been unable to find documentation or examples for the use of the falcosidekick.config.existingSecret value. I may have missed it, but I think this would be excellent area to provide an example or two. I would like to be able to reference my slack webhook url (falcosidekick.config.slack.webhookurl) from an existing secret to avoid having to put it in my values file or configure it manually each time. I have found others online with similar desires but have yet to find a solution. Any feedback or links to existing documentation I may have missed are more than welcome. Thanks!

Hi,
The secrets are used as env vars, and these env vars are used to configure falcosidekick:
          envFrom:
            - secretRef:
                name: {{ include "falcosidekick.fullname" . }}
            {{- if .Values.config.existingSecret }}
            - secretRef:
                name: {{ .Values.config.existingSecret }}
            {{- end }}

A secret file is created by the chart and populated with the values from the values.yaml:
data:
  # Slack Output
  SLACK_WEBHOOKURL: "{{ .Values.config.slack.webhookurl | b64enc }}"
  SLACK_CHANNEL: "{{ .Values.config.slack.channel | b64enc }}"
  SLACK_OUTPUTFORMAT: "{{ .Values.config.slack.outputformat | b64enc }}"
  SLACK_FOOTER: "{{ .Values.config.slack.footer | b64enc }}"
  SLACK_ICON: "{{ .Values.config.slack.icon | b64enc }}"
  SLACK_USERNAME: "{{ .Values.config.slack.username | b64enc }}"
  SLACK_MINIMUMPRIORITY: "{{ .Values.config.slack.minimumpriority | b64enc }}"
  SLACK_MESSAGEFORMAT: "{{ .Values.config.slack.messageformat | b64enc }}"

You can also, create a secret by yourself and use it here. Just respect the same syntax by specifying the env vars. You can find them all in the docs of each output.
As you can see, first are used the "default" env vars from the secret file created by the chart, then those from the secret file you specify, it means the env vars from your file will override the previous ones.
Is it clearer?

Can we close this issue? Thanks.


configuration item nacos server

console println nacos config info to password
INFO:
2021-01-14 01:28:18,526 - org.apache.skywalking.oap.server.starter.config.ApplicationConfigLoader -1441 [main] INFO  [] - Provider=nacos config=password has been set as xMxxxxxxxxxxx

Yes, we print all the info in the logs, you could close INFO level logs. Because from the level of OAP core, we can't tell what is secret information, now.

Yes, we print all the info in the logs, you could close INFO level logs. Because from the level of OAP core, we can't tell what is secret information, now.


feat(Timers): cleanup, support API changes, persistent timers, stopwatches

Description
This PR adds a few updates to the Timers extension:

MenuBarExtra support (thanks @marcjulianschwarz)
Inline Argument support for the Start Custom Timer command
Stopwatch support (start and stop multiple stopwatches, with renaming and viewing functionality similar to the timers)
Persistent timer support (ring the timer alert sound until dismissed, when a timer finishes) [closes #2724]
Support new Raycast form validation
Add hooks for state management functions
Create formatUtils file for various date and time formatters

Screencast
The nature of this extension makes screen recordings a bit difficult, but here are some screenshots that help showcase the changes:

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Is it also possible to copy the time to the clipboard?

Not yet ;) I can add it if you would like - or feel free to PR into ThatNerdSquared/timers-for-raycast and I will add it here ASAP.

I converted this into a draft until you're ready 🙂

Thanks @pernielsentikaer - it's ready for review now. Sorry for the delay 😅

Thanks @pernielsentikaer!


docs: add the shell-completion support in optimus cli

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.369%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3409

Relevant Lines:
5296

💛  - Coveralls


cl_abap_conv_codepage doesn't exist on NW 752 SP04

Great, very helpful, i replaced it, thanks!

https://github.com/oblomov-dev/ABAP2UI5/commit/a2f481dda5eab0e655865c4181ffd1dcc7a4ff09


add support for iam role for tasks

point to Prorsum package with fix for get ecs credentials
detect if AWS_CONTAINER_CREDENTIALS_RELATIVE_URI is present
and set static var serviceHost to enum MetaDataServiceHost
determine logic to getCredentials in MetaDataService from
serviceHost
add support for Expiration on Credential
check if Credential is nearExpiration and call getCredential
if within 5 mins or Expiration is past

@noppoMan any chance to look at this yet?

@noppoMan checking in again, would love to get this PR merged in

@jonnymacs maybe he's busy with other commitments. He didn't respond to my other PRs either.. I'm asking him on email

Hello @noppoMan! Great to hear from you.
Yes, the MetaData struct can adopt the Codable protocol, so I went ahead with that change in addition to camel casing.

@jonnymacs
Awesome! merging.
Thanks again for your contribution!

@jonnymacs
I invite you to aws-sdk-swift-core and aws-sdk-swift as collaborator.


Adds repository to package.json

From the npm docs.
"Specify the place where your code lives. This is helpful for people who want to contribute. If the git repo is on GitHub, then the npm docs command will be able to find you."

thanks @thefabulousdev will get this implemented as well as additional documentation soon.


Links, small edits, and renamed files

Files are named unit-test--.md to keep them clean from other files.

Validation Status: Successful
JobID: 30c66763-2d71-46e8-94fa-ea19b1f15132

Articles to review
The articles impacted by this PR were staged review at:

http://taco.visualstudio.com/en-us/docs/unit-test-01-primer/
http://taco.visualstudio.com/en-us/docs/unit-test-02-environments/
http://taco.visualstudio.com/en-us/docs/unit-test-03-basic-testing/
http://taco.visualstudio.com/en-us/docs/unit-test-04-chutzpah/
http://taco.visualstudio.com/en-us/docs/unit-test-05-tdd/
http://taco.visualstudio.com/en-us/docs/unit-test-06-debug/
http://taco.visualstudio.com/en-us/docs/unit-test-07-mocks/


[WIP][SPARK-31579][SQL] Floor div to div

What changes were proposed in this pull request?

This is a proof-of-concept PR for replacing floorDiv in localRebaseGregorianToJulianDays() to only div so that performance can be improved.
For this, we need to ensure that utcCal.getTimeInMillis % MILLIS_PER_DAY == 0
If my method to verify the above is correct, then I will update this PR to simply remove floorDiv and add div.
For SPARK-31579 @MaxGekk
Why are the changes needed?

Better and faster performance
Does this PR introduce any user-facing change?

No
How was this patch tested?

Unit testing.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hi, @Sudhar287. Is this PR still WIP? I set WIP in the title though.

Thanks for the response @maropu! This is not a work in progress.
This is a working proof of concept. I was asked to share my findings before I made the 1 line code change.

Ah I see. But, I think you don't need to open a new PR for that purpose.

Okay. But how else should I share my findings? My idea was to simply update this PR once the proof is validated...

If you want to discuss this topic, I think you should do in the JIRA side by showing your PoF patch in your local (forked) repository.

Right. Got it!


Adds approximate nearest neighbor similarity searching tools

This adds three new tools for

building an approximate nearest neighbor index based on all video clip features in a directory
a server loading the index into memory and responding to queries
a client making calls against the server returning indices and distance for now

Todo

[x] figure out upstream faiss 1.6 avx2 compilation issue
[ ] add to Dockerfile.gpu
[x] instead of indices write out metadata and return from server
[x] think about client interface: maybe make video feature path + clip index based

Patching faiss on our own here to enable AVX2 compilation until upstream fixes it: https://github.com/moabitcoin/ig65m-pytorch/pull/27/commits/e2b2a3fb383f9d9e6ab5f9feb13e3d1850985933

Merging this into master! We now have

an approximate nearest neighbor index creation tool
a tool for loading the index into memory (slow) and serving queries (fast)
a tool for querying the index server

Dockerfiles have been updates to compile faiss in a multi-stage setup (first stage compiles and builds wheels, second stage installs only from wheel), and patch it in-place to make it compile for avx2 instruction sets.


sudo timestamp reset may break scripts

brew doctor output
Your system is ready to brew.

Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
HOMEBREW_VERSION: 4.3.12-10-g6e9947d
ORIGIN: https://github.com/Homebrew/brew
HEAD: 6e9947d570e64a840a40c46aa001610574589314
Last commit: 20 minutes ago
Core tap HEAD: faa508ab98e669454be141eee7791b68bd0225ce
Core tap last commit: 6 minutes ago
Core tap JSON: 30 Jul 16:08 UTC
Core cask tap JSON: 30 Jul 16:08 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vi
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 11
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4/bin/ruby
CPU: 11-core 64-bit arm_lobos
Clang: 15.0.0 build 1500
Git: 2.45.2 => /opt/homebrew/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-arm64
CLT: <IP_ADDRESS>.1.1708646388
Xcode: N/A
Rosetta 2: false

What were you trying to do (and why)?
Run brew commands within a script that has acquired sudo access and expects to keep it throughout execution.
What happened (include all command output)?
After using brew, the script proceeded to run additional commands under sudo, and I was prompted again for a password.
Eventually, the script called Ansible to execute a playbook on the local machine. The first task step that required sudo access failed, because there was no terminal to get a password from.
TASK [geerlingguy.mac.homebrew : Ensure Homebrew parent directory has correct permissions (M1).] ***********************
fatal: [localhost]: FAILED! => changed=false
  module_stderr: |-
    sudo: a password is required
  module_stdout: ''
  msg: |-
    MODULE FAILURE
    See stdout/stderr for the exact error
  rc: 1

Even after ensuring that Ansible was called with sudo, that access was lost after a step in the playbook called brew to install a missing formula. The next step that required sudo failed in the same fashion.
What did you expect to happen?
For the script to execute to completion, with sudo access available for all script commands (and Ansible steps) following execution of brew.
Step-by-step reproduction instructions (by running brew commands)
# Reproducing the Ansible issue is tricky in this medium. To reproduce the problem just on the scripting side, run these commands in a script or at the command line.

sudo date; brew --prefix; sudo date

This recent PR introduced the new behavior. https://github.com/Homebrew/brew/pull/17694

Duplicate of https://github.com/Homebrew/brew/issues/17905, WONTFIX sorry.

I understand the reason for the change. However, IMO this new behavior is an overreach.

The problem is in formula privilege escalation, but the removal of sudo occurs for any execution of brew. The scope of the fix is too broad. (Reducing the scope wouldn't fully fix this problem, to be fair.)
An executable should not alter its calling environment as a side effect. brew should restore sudo access for ensuing processes, even if it blocks it for itself.

brew should restore sudo access for ensuing processes, even if it blocks it for itself.

@bhavanki If you can provide details (ideally a pull request) for how this is technically possible: we'd love that. We haven't been able to figure out how to do this yet.

The problem is in formula privilege escalation, but the removal of sudo occurs for any execution of brew.

Almost all executions of Homebrew (not just installs) may require reading potentially untrusted Ruby code. It's hard to scope this much more tightly than it is currently, unfortunately.

Thanks for continuing the conversation.

brew should restore sudo access for ensuing processes, even if it blocks it for itself.

@bhavanki If you can provide details (ideally a pull request) for how this is technically possible: we'd love that. We haven't been able to figure out how to do this yet.

Yeah, I doubt access can be restored (especially if you all haven't discovered how to). With some further experimenting, I did find a workaround for leaving access in place. It works because sudo caches credentials by user and by TTY, so if the brew command runs in its own TTY, it can freely do away with any inherited access (in fact, I think it never gets it).
This Stack Overflow answer proposes using the script command for this purpose, and it seems to work. I created this shell function to call instead of brew in my own script.
brew() {
  script -q /dev/null "$(command -v brew)" "$@" | sed 's/\r//g'
}

(This is for macOS. Also, the script command seems to emit rogue carriage return characters, hence the sed usage.)
I don't imagine that this exact mechanism could work in brew, but maybe something else adjusting the TTY might. Anyway, hopefully this will solve the problem within my own script.
And, just for completeness: Ansible lets you supply a "become" password which is equivalent to prompting for sudo. It's an extra prompt for the user, but lets Ansible run steps requiring sudo without requiring it to be established ahead of time. It's probably the "right" way anyway.

The problem is in formula privilege escalation, but the removal of sudo occurs for any execution of brew.

Almost all executions of Homebrew (not just installs) may require reading potentially untrusted Ruby code. It's hard to scope this much more tightly than it is currently, unfortunately.

Ah, understood, that's too bad!

Thanks @bhavanki!


Make the default output less verbose, but add a --verbose/-v flag for extra detail

Taking at stab at https://github.com/silvermine/dynamodb-table-sync/issues/8
This does change the default program behavior to make it less verbose - I don't know if that's OK with you or not.
The (proposed) Default output:

Master table us-west-2:attribute_values_preprod
Approx. item count: 113567
Key schema: { hash: 'id', range: 'key' }
Slave[1] table us-west-2:attribute_values_eric
Approx. item count: 0
Key schema: { hash: 'id', range: 'key' }
......(1%)..........(2%)...........(3%)..........(4%)..........(5%)...........(6%)..........(7%)...........(8%)..........(9%)..........(10%)...........(11%)...........(12%)..........(13%)...........(14%)..........(15%)..........(16%)...........(17%)..........(18%)...........(19%)..........(20%)..........(21%)...........(22%)..........(23%)...........(24%)..........(25%)...........(26%)..........(27%)..........(28%)...........(29%)..........(30%)...........(31%)..........(32%)..........(33%)...........(34%)...........(35%)..........(36%)...........(37%)..........(38%)...........(39%)..........(40%)...........(41%)..........(42%)..........(43%)...........(44%)..........(45%)...........(46%)...........(47%)..........(48%)..........(49%)...........(50%)..........(51%)...........(52%)..........(53%)..........(54%)...........(55%)..........(56%)...........(57%)...........(58%)..........(59%)..........(60%)...........(61%)..........(62%)...........(63%)..........(64%)..........(65%)...........(66%)..........(67%)...........(68%)...........(69%)..........(70%)..........(71%)...........(72%)..........(73%)...........(74%)..........(75%)..........(76%)...........(77%)..........(78%)...........(79%)..........(80%)...........(81%)..........(82%)...........(83%)..........(84%)...........(85%)..........(86%)..........(87%)...........(88%)..........(89%)...........(90%)..........(91%)..........^C
Synchronization completed. Stats:
us-west-2:attribute_values_eric
Had 113567 items that were the same as the master
(we did not scan the slave to find if it had "extra" items that the master does not have)
Had 0 items that were different from the master
Was missing 0 items that the master had

With (proposed) -v or --verbose flags:

Master table us-west-2:attribute_values_preprod
Approx. item count: 113567
Key schema: { hash: 'id', range: 'key' }
Slave[1] table us-west-2:attribute_values_eric
Approx. item count: 0
Key schema: { hash: 'id', range: 'key' }
Scanning us-west-2:attribute_values_preprod
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 50 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 100 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 150 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 200 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 250 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 300 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 350 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 400 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 450 of approximately 113567 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
...
HUGE MULTI SCREEN PAGES
...
us-west-2:attribute_values_eric
Had 113567 items that were the same as the master
(we did not scan the slave to find if it had "extra" items that the master does not have)
Had 0 items that were different from the master
Was missing 0 items that the master had

I also tweaked a couple console.log that I think should be console.error instead

@jthomerson PR updated, thanks!

    at /Users/eric/Work/dynamodb-table-sync/src/Synchronizer.js:171:25
    at _fulfilled (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:854:54)
    at /Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:816:13)
    at /Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:624:44
    at runSingle (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:137:13)
    at flush (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:125:13)
    at process._tickCallback (internal/process/next_tick.js:61:11) TypeError: Cannot read property '_opts' of undefined
    at /Users/eric/Work/dynamodb-table-sync/src/Synchronizer.js:171:25
    at _fulfilled (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:854:54)
    at /Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:883:30
    at Promise.promise.promiseDispatch (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:816:13)
    at /Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:624:44
    at runSingle (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:137:13)
    at flush (/Users/eric/Work/dynamodb-table-sync/node_modules/q/q.js:125:13)
    at process._tickCallback (internal/process/next_tick.js:61:11)

Synchronization completed. Stats:```

There's a bug here somewhere

I'm seeing another bug, not sure if it is also in master, digging into it:
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 51986 of approximately 52036 items from the master table to its slaves
Comparing batch of 50 from master to 50 from slave us-west-2:attribute_values_eric
Status: have compared 52036 of approximately 52036 items from the master table to its slaves
(100%)
Starting to scan slave us-west-2:attribute_values_eric for extra items
Scanning us-west-2:attribute_values_eric
Status: have compared 50 of approximately 113992 items from the slave table to the master
Status: have compared 100 of approximately 113992 items from the slave table to the master
Status: have compared 150 of approximately 113992 items from the slave table to the master
...
...
Status: have compared 51986 of approximately 113992 items from the slave table to the master
Status: have compared 52036 of approximately 113992 items from the slave table to the master
(100%)
Synchronization completed. Stats:

us-west-2:attribute_values_eric
Had 52036 items that were the same as the master
Had 0 items more than master

The count estimate seems to be double.

 Stats:

us-west-2:attribute_values_eric
Had 52036 items that were the same as the master
Had 0 items more than master
Had 0 items that were different from the master
Was missing 0 items that the master had

I need to dig into whether or not the "Had 0 items more than master" is accurate - dynamodb console is showing extra items:

vs the source/master table:

For reference, I just tried the master branch and it also is returning:

Status: have compared 51986 of approximately 113992 items from the slave table to the master
Status: have compared 52036 of approximately 113992 items from the slave table to the master
Synchronization completed. Stats:
us-west-2:attribute_values_eric
Had 52036 items that were the same as the master
Had 0 items more than master
Had 0 items that were different from the master
Was missing 0 items that the master had

So this PR itself isn't a regression.

Dynamodb fixed itself  shrug.  So I'm done with this PR.

@onebytegone @jthomerson I didn't want to add dependencies to your project, but if you are aware off another module that can be used to wrap the progress indictators I can refactor to start using that instead of the roll-my-own wrapper.

@jthomerson are there still requested changes?

@jthomerson testing this now with the requested changes.

@jthomerson
Current PR refreshes the line on the percentages, and ticks are for the percentage, with the final (100%) at the end.

Scanning us-west-2:attribute_values
Status: Comparing approximately 1010002 items from the master table to its slaves
(2%)...............................................

This is in<EMAIL_ADDRESS>

Thanks for the contribution @er1c!


typo: Double word "use"

@nschonni : Thanks for your contribution! The author, @heidisteen, has been notified to review your proposed change.

#sign-off thanks!


Using image in html img tag returns 404 (Not Found)

Versions
Angular CLI: 1.5.2
Node: 8.9.1
OS: darwin x64
Angular: 5.1.1
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
@angular/cli: 1.5.2
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.41
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.2
@schematics/angular: 0.1.10
@schematics/schematics: 0.0.10
typescript: 2.4.2
webpack: 3.8.1
Repro steps
In your html component create a img tag. e.g.
Observed behavior
The image does not render. In my browser I get a 404 Not found. This doesn't change regardless if I use a absolute or relative path.
Desired behavior
My image should appear.
Mention any other details that might be useful (optional)
My images were working and then I deleted my cache and all of sudden they would not render anymore.

I'm going to need a repro for this. Where is the image being loaded from? Maybe it's not in your assets, or you are deploying to a location where the image path is different.

 --HTML page
And below is the folder structure.

Please help me

I got the solution
I had to put the image to the /src/assets folder. Angular is now able to find the image.

Looks like it has been unanswered above.


"HttpPost" should be "HttpPOST" under Actions

On https://docs.microsoft.com/en-us/outlook/actionable-messages/message-card-reference#actions
HttpPost no longer works in OWA.

Thanks for reporting. It looks like it is properly cased in the document except for the one link in the list of actions. Easy enough to fix :).


Error: Configuration cannot be loaded: {"message":"Invalid handler specified"}

Hello,
at first thank you a lot for doing this one! :)
Never the less I have an issue. I installed via HASS and when I want to add the integration it gives me the error:
Configuration cannot be loaded: {"message":"Invalid handler specified"}

Can you help me? Am I doing something wrong?
Thank you a lot

OK I found out problem -> I had in _configuration.yam_l old modbus integration defined -> when I deleted it -> it seems it is working -> I was able to set up the integration.

Thank you for taking the time to test the integration (it helps a lot with detecting issues that I might miss in my testing).
Yeah the error given if pymodbus < 3.0.0 is used is sadly really generic.
Not using integrations that use 2.x.x versions of pymodbus solves your issue (for example the solaredge modbus tcp integration latest version will work with this integration enabled while older versions won't).
When the integration gets stable enough I will look into getting the core modbus integration up to 3.x.x of the pymodbus package.
So that users can add this integration in conjunction with their existing modbustcp integration setup to allow for a less breaking switchover.
Will leave this issue open for now so that anyone having the same problem can more easily find the solution

@aheadley thanks for contributing a work-around for people running their own dockerized HA
So to update on the co-existence issue between the modbus integration and this integration:
I submitted a PR to update the core version but it seems that the maintainer of the integration wants to wait for the 3.1.x release before updating.
Expected timeline for the pymodbus 3.1.0 version is somewhere in december.
So it would be a reasonable expectation that around january of 2023 this and the built in modbus integration will be able to co-exist.

That is a shame as I have a need for both the victron and the existing modbus set up.  Any workaround to get them to both work?

Not in the same home assistant instance.
Since, there can only be one pymodbus library version installed per homeassistant core runtime environment.
You could try running 2 homeassistant instances and link them together with the remote homeassistant integration "https://github.com/custom-components/remote_homeassistant".
Otherwise the only option is to wait until the integrated modbus integration also starts using a v3.x.x pymodbus version.

got this error as well Config flow could not be loaded: {"message":"Invalid handler specified"} from what I gather on the comments this is not really ready to be intergrated into home assistant well I guess I will stick to my old method of build the sensors by hand in modbus

@trentjw to clarify on your statement:
The integration is ready to be integrated into home assistant.
Currently it's just a choice between the build-in modbus integration with yaml configuration and this integration(/multiple other custom modbus integrations like: solaredge multi modbus) that have already moved to the pymodbus > 3.x.x release.
The core modbus integrations maintainer stated that the core modbus integration will also update to 3.x.x once the pymodbus 3.1.x release has been made.
This is planned for this month so in a month or two the core modbus integration will be able to be run again in parallel with this integration.

Closing this issue as from 2023.2.0 and onwards home assistant core modbus integration uses pymodbus 3.1.1.


Any plans to migrates it to the .NET Core?

I'm doing work on this project every few months.  As long as there aren't too many active requests I might be able to look at this in the next batch.
I'll have to see what's different about that environment though (e.g. which libraries / APIs are not available) before committing.

thanks a lot, dude.
I'm waiting for it.


recent messages not updating on list page if last message is an attachment

keeping it open to merge it to master.


redirecting signup to login

@Trisha-tech please assign this issue to me under GSSOC PR completed

@Trisha-tech please assign this issue to me under GSSOC PR completed

Hello @sahithi000 , Go for it
All the best

Please assign me this issue under GSSoc'24.

hello,please assign me the issue.

please assign this task to me

Please assign this issue to me under GSSOC' 24


[SPARK-38011][SQL] Remove duplicated and useless configuration in ParquetFileFormat

What changes were proposed in this pull request?
Currently, we called ParquetWriteSupport.setSchema(requiredSchema, hadoopConf) when ParquetFileFormat buildReaderWithPartition, and this helper method set org.apache.spark.sql.parquet.row.attributes and parquet.writer.version, actually,  the former is already set and latter is useless when parquetRead
Why are the changes needed?
duplicated configuration
Does this PR introduce any user-facing change?
no, duplicated configuration only
How was this patch tested?
Existing tests

A similar situation exists in ParquetScan#createReaderFactory

A similar situation exists in ParquetScan#createReaderFactory

Thanks a log for your reminder, updated

@cloud-fan Could you please take a look when you have a time? Thanks

thanks, merging to master!

@Yikf The PR description mentions that we already set parquet writer version. Can you point where it is set after this change?

Also, should ParquetWriteSupport.setSchema be removed altogether if it is not used?

@Yikf The PR description mentions that we already set parquet writer version. Can you point where it is set after this change?

writer version is useless when reading

Yes, I see. I missed the context, needed to click to expand the code. I thought the code was removed from the write path.


Use []byte for HTTP methods with retry

This MR is addressing #364.
It is changing the type of the body argument from io.Reader to []byte for all HTTP methods with retry functionality and a body.
This ensures that the body is not read upon the first request and then gone for good.
I additionally added a test, ensuring that this is indeed the case.

Thanks for the changes! Just kicked off a build.

Build passed and this change looks good, so going to merge this in. Thanks for your contribution!

Thanks for reviewing it and in general for this great repo :slightly_smiling_face:


upgrade opentelemetry version to 1.12.0

I have projects using fabric-sdk-java that also use opentelemetry at 1.12.0, which clashes with the transitive dependency from here. Would appreciate if we can upgrade it to the latest version of 1.12.0.
@bestbeforetoday could someone please help me figure out what went wrong with the build here?

I guess something must have changed in the opentelemetry APIs so the code that uses them in fabric-sdk-java no longer compiles:
src/main/java/org/hyperledger/fabric/sdk/helper/Config.java:[29,42] cannot find symbol
  symbol:   class OpenTelemetrySdkAutoConfiguration
  location: package io.opentelemetry.sdk.autoconfigure

@atoulme Any ideas or recommendations?

You can look at this PR for inspiration: https://github.com/hyperledger/fabric-chaincode-java/pull/236/files#diff-e66a996c2a7f2aec49e5918f45a177a04933fe9e62c7f1beb65855df7034d0a6L36

hey @bestbeforetoday @atoulme I have fixed the compilation problem, however now it fails with the following:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19:49 min
[INFO] Finished at: 2022-03-24T13:50:24Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.owasp:dependency-check-maven:6.5.3:check (default) on project fabric-sdk-java:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
[ERROR]
[ERROR] kotlin-stdlib-common-1.4.0.jar: CVE-2020-15824
[ERROR]
[ERROR] See the dependency-check report for more details.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
##[error]Bash exited with code '1'.

However I can't see how this is related to my changes.
Any ideas what is going on here?

hey @bestbeforetoday thanks for the reply. in the meanwhile, could you tell me if there is anything else I need to do for this PR to be accepted?

Once #194 is in, you should be able to rebase and get this passing.

hey @bestbeforetoday I did the rebase and it seems like for some reason it dismissed your approval, could you please approve it again?

thank you! when should we expect a new release?

https://github.com/Mergifyio backport release-2.2

@Mergifyio backport release-2.2


There is no function in slot after swapping slot with production which has a repository connected

OS: Win 10
Build Version: 20220228.3
Repro Steps:

Create a Linux Node.js Function App.
Deploy a JavaScript/TypeScript project to this Function App.
Expand the Function App -> Deployment node -> Connect a repository to it.
Create a slot for this Function App.
Execute "Swap Slot" action with production.
Check whether there is a function in slot or not.

Expect:
There is a function in slot.
Actual:
There is no function in slot.

More Info:
This issue also reproduces for Python Functions App.

Does anything else get swapped like the Application Settings or Files?  I'm wondering if maybe the entire swap did nothing or if just the function triggers aren't swapping.

@nturinski Both the Application Settings and Files are swapped.

@v-ruizh we're thinking this is a timing issue. Can you try reproing again but check the Functions node after waiting for a few minutes?

@wwlorey This issue also reproduces after waiting for a few hours. Refresh can't fix this issue.

@v-ruizh I just noticed, but in the screenshot, there are no functions in the production app either.  Is the function app being deployed correctly?

@nturinski Yes, the function app being deployed correctly. Function exists in the production app before swapping slot.


Leak when creating many tf.layers.Conv2D with tf.eager

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 16.04.3 LTS

TensorFlow installed from (source or binary):  binary

TensorFlow version (use command below): ('v1.5.0-0-g37aa430d84', '1.5.0')

Python version: Python 3.5.2

CUDA/cuDNN version:  cuda-9.0

GPU model and memory: TITAN X (Pascal)

Exact command to reproduce:

see gist https://gist.github.com/matpalm/93680534c5c53d6e7836d3aea1a3bbb3
for minimal reproduction. run this script and watch loop times increase.
Describe the problem
each creation of a tf.layers.Conv2D is slower than the one before. have a project based on evolutionary algorithm that creates many instances of tf.layers.Conv2D for fitness evaluation and over time entire process slows down. it's not expected this loop should slow down.
Source code / logs
see gist above

just upgraded to v1.6.0-0-gd2e24b6039 1.6.0 & same behaviour

Will finish investigating on Monday. Looks like it's due to some overzealous caching.
Thank you for the excellent bug report.

The more worrying/unexpected issues here were PyObject leaks due to missing Py_DECREFs in our C code. Those are now fixed, although some of the changes haven't synced to github yet (give them a day or so).
The main issue is that there's a bit of variable_scope code run by Layers which means creating new Layers in a loop will take quadratic time (closing a variable_scope is linear in the number of existing variable_scopes). We'll fix that eventually (potentially by removing variable_scope in TF2.x), but there's a relatively easy workaround in the meantime. You can either wrap your Layer creation in a with tfe.EagerVariableStore().as_default(): block or reset the default graph on each iteration. This will ensure that variable_scope names don't build up in this dictionary.

Awesome! Thanks for the work around, I'll give that a go ASAP. Do you want
me to close?
On Tue, Mar 13, 2018, 09:01 Allen Lavoie<EMAIL_ADDRESS>wrote:

The more worrying/unexpected issues here were PyObject leaks due to
missing Py_DECREFs in our C code. Those are now fixed, although some of the
changes haven't synced to github yet (give them a day or so).
The main issue is that there's a bit of variable_scope code run by Layers
which means creating new Layers in a loop will take quadratic time
(closing a variable_scope is linear in the number of existing
variable_scopes). We'll fix that eventually (potentially by removing
variable_scope in TF2.x), but there's a relatively easy workaround in the
meantime. You can either wrap your Layer creation in a with
tfe.EagerVariableStore().as_default(): block or reset the default graph
on each iteration. This will ensure that variable_scope names don't build
up in this dictionary.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/17590#issuecomment-372476513,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABULd8zrKtsV3bz37zM060ecs5rIhQzks5tdvAagaJpZM4SkNEM
.

You may want to use a build after https://github.com/tensorflow/tensorflow/commit/e2020e64360a4f9beeb48f388fb74ab1c4b1f847#diff-62c686d1c3d926dc05023a1ccd4d603c to avoid the PyObject leaks. Let me know if you run into any issues.


Improve bin count selection range

The current binning algorithm doesn't produce rounded boundaries. The boundaries of each bin are pretty roughly chosen so they end up being weird numbers like 34.20592.
It would be better if we could determine the selection ranges with nicer defaults in mind.
Part of #342

I had some thoughts regarding this issue.
The range of the bin would be defined by the algorithm we are going to implement in #375 . Once that is solidified we would be using that to determine the number of bins. With that in picture, the issue of having good edges somehow becomes mutually exclusive to the algorithm. For making the edges more "readable" we would have to mutate the bin sizes rendering the algorithm moot. Even if that is fine, the numeric profile UI would change a bit because we will no longer have the max element at the end. It would be somewhere just before the last bar.
Any thoughts on this @bcolloran ?

tl;dr: i think good edges are not that important if there is a tradeoff that we have to make
--
@djbarnwal I guess that, up reflecting on it, my take is that the bin edges might not matter. One question: are these weird bin edge numbers ever shown to the user? I was trying to poke around in the UI and I couldn't spot any tooltips or other displays that printed the numeric value of any bin edge.
I guess I'd also say that if the task is to clearly depict a distribution, the bins and bin edges really are not the important part -- they are kind of an implementation detail that can be hidden from the person reading the plot. In the limit (kind of literally...) you can depict a distribution by plotting a kernel density estimate, which doesn't have bin edges b/c it doesn't have bins, and imo KDE plots are often the best way to display many distributions.
Another less commonly used but often superior way of drawing distributions is to do so by binning not in the data space, but in the CDF space. For example, rather than binning heights in steps of (100cm-120cm],(120cm-140cm],..., you bin the (sorted) obervations by quantile, for example (0%-2%], (2%-4%], ... ,(98%,100%]. If you go this way, then you know that every bin contains the same number of observations, but that also means that the bins will have uneven lengths. However, it doesn't matter for the purposes of drawing the distribution. See e.g. this https://aakinshin.net/posts/qrde-hd/ (I can't find a great reference, but this will hopefully get the idea across). I mention this not to suggest that we should implement something like this right now, but just to provide another example where the bin edges don't matter.
Having taken some time to think about this more deeply, it also makes me reconsider the conversation we had in some other context about the bin edge aliasing that I was seeing -- we're just using histograms as a tool to show distributions, but the placement and edges of the bins are just an implementation detail, not something we need to show the user. So perhaps we should not have the 1px of space between bins.

@djbarnwal , Do we have open questions here or are we completing this as won't do?

@magorlick We are not sure if we correctly understand what's needed here or what's the understanding behind having rounded selections. We were waiting for @hamilton to provide his thoughts on this when he's back.

this has been superceded by #1473


findAllReferences: forEachRelatedSymbol can always include shorthand destructuring

Sequel to #23028: turns out this parameter isn't needed.

Sorry, should have run rename tests too -- some tests do change, though I think in a beneficial way. If we're at a location with both property and local meaning (e.g. at x in for ({ x } in y)) we will rename both.


Add method to MovingWindow that waits for a number of samples

Up to now there was no clean way to wait until the MovingWindow got updated with a certain number of samples.
In this PR we introduce a wait_for_samples method that finishes once the number of samples arrived.

FYI @idlir-shkurti-frequenz

Oh, I also noticed in your last PRs that it seems you have your editor configured to a maximum line length of maybe 50 chars? Ideally it should be 88 to match black's config.

I've reworked the implementation. Now the user can get a channel that sends a None when the a certain number of samples arrived. That has the advantage that we can plug it into our channels select mechanism.

Will this not be part of v1 milestone?

Will this not be part of v1 milestone?

Let's see. This change is not breaking so it can be v1.1.x too. But let's try to get it in.

I think we should close it and come back to it, once @cwasicki has finished all the changes.

The code changes here look unrelated to what I am working on.

The code changes here look unrelated to what I am working on.

Right, ignore my comment ;)

This is quite old. It we need it we can reopen the PR or start from scratch.

Is there another way to know if the moving window was updated?

Is there another way to know if the moving window was updated?

No there isn't.
This pr was closed, not because we don't want to support it, but rather since nobody is working nor anyone was asking for this feature. So as it appears there is no need for this feature.

It turns out this is required in the Forecast actor.  Only yesterday evening, Christoph showed me the place where he's using a while loop that could be replaced with this, just a little bit after we were talking about closing this issue.  But I think not top priority, so we can pick this up again soon.

It turns out this is required in the Forecast actor. Only yesterday evening, Christoph showed me the place where he's using a while loop that could be replaced with this, just a little bit after we were talking about closing this issue. But I think not top priority, so we can pick this up again soon.

Okay, thanks for the notice. I'll put it back on my todo list.


Feedback to Demo LiveCamera Sample - Face API

[Enter feedback here]
Hi,
I try to Re-build the Live Camera Sample - but how to add Microsoft.ProjectOxford for the app?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 183e5251-798f-9f67-b0d7-20d68230b31d
Version Independent ID: 775c2385-f03a-fc5c-a5dd-1fd64e678bc3
Content: Example: Real-time video analysis - Face API - Azure Cognitive Services
Content Source: articles/cognitive-services/Face/Face-API-How-to-Topics/HowtoAnalyzeVideo_Face.md
Service: cognitive-services
GitHub Login: @SteveMSFT
Microsoft Alias: sbowles

Thanks for the question! We are investigating and will update you shortly.

@thienanh2018 Hi, you need to get the required NuGet packages. Right-click on your project in the Solution Explorer and select Manage NuGet Packages; then, find and install the following package:
Microsoft.Azure.CognitiveServices.Vision.Face 2.2.0-preview.
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion ^^.


i18n (ja) Created translation for guides/integrations-guide/db/.

Description (required)
This PR adds a new fully translated page for japanese guide page on Astro DB.
https://docs.astro.build/ja/guides/integrations-guide/db/

Related issues & labels

Suggested label: Japanese Translation, Astro DB

Translation by @SnowDingo(Same for Discord and Github)

英語の原文とはまだ詳しく比較できていませんが、日本語訳を一通り読んで、気になったところにコメントしてみました。

@shuuji3 さん、変更点は全て修正して壊れていたリンクも修正しておきました。
良ければ承認よろしくお願いします。

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note
Locale

src/content/docs/ja/guides/astro-db.mdx
Localization changed, will be marked as complete. 🔄
ja

src/content/docs/ja/guides/integrations-guide/db.mdx
Localization added, will be marked as complete. 🔄
ja

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Thanks @SnowDingo, these pages had a few updates recently, would you be up to update them here?
https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/astro-db.mdx?since=2024-04-08T13:35:58.000Z
https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/integrations-guide/db.mdx

Dear @yanthomasdev.
I will work on these additional changes, but is it possible to merge this PR first?
I believe it will be better if I make separate PRs for the updates on the Astro DB guide since this PR is slowly getting buried with the new PRs.
Thank you
Snowdingo

I will work on these additional changes, but is it possible to merge this PR first?
I believe it will be better if I make separate PRs for the updates on the Astro DB guide since this PR is slowly getting buried with the new PRs.

We do have a way to do so, but that's limited to pages being updated (not added). Since we're adding a new page that unfortunately won't work, so we'll have to wait until it's completely updated. But don't worry, we'll get to it eventually!

I will work on these additional changes, but is it possible to merge this PR first?
I believe it will be better if I make separate PRs for the updates on the Astro DB guide since this PR is slowly getting buried with the new PRs.

We do have a way to do so, but that's limited to pages being updated (not added). Since we're adding a new page that unfortunately won't work, so we'll have to wait until it's completely updated. But don't worry, we'll get to it eventually!

Thank you for your reply.
If the process is like the one you mentioned, I will work on updating my translation so it matches the updates in the original document.
Thank you
Snowdingo


Issue due date

Fixes #2533.
Blocked by go-gitea/go-sdk#103.
This PR adds the ability to add due dates to issues. This works similar to milestones, but for single issues. Due date can be managed via the api.
Due dates are shown in the issue list, overdue issues are marked in red.
Screenshots

TODO

[x] Update go-sdk once its merged

Codecov Report

Merging #3794 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3794      +/-   ##
==========================================
- Coverage      23%   22.92%   -0.09%
==========================================
  Files         126      126
  Lines       24894    24997     +103
==========================================
+ Hits         5728     5731       +3
- Misses      18289    18389     +100
  Partials      877      877

Impacted Files
Coverage Δ

models/issue_comment.go
29.46% <0%> (-1.03%)
:arrow_down:

models/pull.go
17.35% <0%> (-0.02%)
:arrow_down:

routers/repo/issue.go
0.92% <0%> (-0.04%)
:arrow_down:

models/issue.go
30.12% <0%> (-1.21%)
:arrow_down:

modules/process/manager.go
73.91% <0%> (+4.34%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d3c54...3ae5b7a. Read the comment docs.

LGTM

@Morlinest  could you please re-review/approve the changes I made?

I found something interesting in issue_comment.go:426, it updates the issue when I create a comment. This destroys my routine, as it updates the issue back to the old deadline right after I updated it to the new one.
This seems like a bug, should I fix that in a seperate pr?

For me - yes, it looks like bug. Now you see reason why I wanted you to change comment/code, to prevent this kind of bugs.

@Morlinest I see, I've created a pr to fix that: #3855

need @JonasFranzDEV @Morlinest 's approvals.

@lunny I already approved it here: https://github.com/go-gitea/gitea/pull/3794#issuecomment-383282018

@Morlinest thanks!

@lafriks OK, I'll change it back to how it was before.

@lafriks Done.

@Morlinest about doing post for removing due date?


Fix cargo features syntax

+1

Can you add the part for generating the doc as well please?

Updated

Great, thanks!


Use unique url hash for built-in catalog git dir

This PR fixes https://github.com/rancher/rancher/issues/30594. But we should discuss the behavior that whether user is allowed to change the system charts url.


Assert arrays shapes...

... and if they are broadcastable.
Add a util function for that.

Done in #20