Remove "drop" mention from create_* docs when the result doesn't implement Drop

Closes #624
Ash doesn't implement Drop intentionally, to not be too opinionated about holding (heap) references to their parent objects (Device->Instance->Entry) and ensuring they are destroyed in the right order.  As such, reword the create documentation for Instance and Device to mention their respective destroy_* function instead of referring to them as being "droppable".
Note that Entry is droppable as it does not have a Vulkan destroy function and the dynamically loaded library (behind the "loaded" feature) is kept alive only for the lifetime of Entry.

The documentation is quite hard to read now, I'm thinking about rewording it to simply mention that a device must (in terms of ordering, and in terms of something you should do to prevent object leaking) be destroyed before the parent Entry/Instance is destroyed.

Otoh the proposed sentence is hard to bolt on to to be valid for the duration of its usage, I'll think of something better when my mind is clear :)

I have given this one more pass, let me know what you think including nits! It's pretty non-trivial to explain this correctly.
For one I was thinking about moving (_not_ [dropped][`drop()`]) into a separate (loose standing paragraph) sentence stating something along the lines of Note that this **must** be destroyed using [`destroy_xxx()`] as this type does not implement [`drop()`] semantics; with our without justification. Perhaps reword it to clearly state that (implicitly) dropping it is simply not enough.


Use bash on windows for functional tests(i.e. with cram)

Windows 10 actually comes with bash(c:\shell.w32\bash.exe) and we can use it to unify our func tests for both win and *nix.

AFAIK you need to enable the Linux Subsystem as a Windows Feature, so bash not available by default.
It's trivial to install it, though.


Applies updated styling and formatting

Updates to latest .NET 8 MAUI components
Updated styling to latest eShop styles
Consolidated workflows

@michaelstonis  need to update nugets on the unit tests projects


Update ha addons

Changes:

update the Home Assistant Addons (nightly and regular) to the latest version of the underlying rust application
add option in the Home Assistant addon configuration to specify the update interval (defaults to 60500ms to be more on the safe side)
specify the branch in the name of the image created by nightly build action. this allows to refer to the latest image of a specific branch and is used in the dockerfile for home assistant

The nightly addon currently still specifies my own fork in the dockerfile. This can be changed once the build action of this repo is updated with the changes of this PR.

Nothing, just used the main branch as the source by mistake (which had the same contents as this one, just inconvenient for me to use it for a PR)


The users enable this feature to automatically stage all the changes when we save the files.
Steps to reproduce the issue:
open vs code and enable git: smart commit feature .
open two files example: index.html and app.js
publish the repository on github
edit the two files and save only one file
now in source control tab you can see that the changes you made was automatically staged and ready to commit.
when you put the commit  message and click commit button it pop a window that tells that a unsaved file is there and have a option "save all and commit" button
when we click that button the unsaved file gets saved, staged, commited and pushed to github origin with that commit message we put previously.but the file we saved earlier stayed on staged area .
 We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

@gjsjohnmurray Sir, I raised this issue again because the issue already there but the assignee was inactive please check that. he didn't even label the issue under bug category

@Gobinath-B there is no Service Level Agreement associated with issues posted here. If you need guaranteed rapid response to VS Code issues I respectfully suggest that you engage a consultant on suitable terms.

@gjsjohnmurray  I have no idea who will be responsible for the issues related to git hub and source control


Theoretically there is the possibility of overflow.

In the file the file /eos/libraries/chain/include/eosio/chain/wasm_interface_private.hpp , theoretically there is the possibility of overflow in line 46 of the function parse_initial_memory.
Look at the code:
const U32 base_offset = data_segment.baseOffset.i32;
const Uptr memory_size = (module.memories.defs[0].type.size.min << IR::numBytesPerPageLog2);
if(base_offset >= memory_size || base_offset + data_segment.data.size() > memory_size)

the memory_size is less than 0x2100000，and the same as base_offset. If we construct a data_segment.data is more than 0xffffffff - base_offset In 32-bit machine, it will cause a overflow.
In fact the data is more than 4Gb. So it just exists in theory. But I think the code should like below:
if(base_offset >= memory_size || uint64_t(base_offset) + data_segment.data.size() > memory_size)

THX :)

This is not true, "32bit uint + 64bit uint" will result in 64bit uint. This is a sample program:
#include <stdio.h>
#include <iostream>
int main(int argc, char **argv) {
  uint32_t a = 10;
  uint64_t b = 0xffffffff;
  std::cout << (a + b);
  return 0;
}

output:<PHONE_NUMBER>

the vector::size will return a size_type typed number, so in 32-bit machine the  data_segment.data.size() will return a uint32 number.

eosio couldn't be compiled as 32-bit binary anyway.


Extend TranslationTask, Dictionary and architecture

Hi fairseq team!
I'm working on extending fairseq with my custom architecture.
Basically I created a custom Dictionary subclass (supporting bpe-encoding), and I want to add my custom TranslationTask subclass that knows how to load such model.
I also want to be able to declare my custom architecture.
At the moment I don't see a way to do that without changing the code (preprocess.py, train.py, interactive.py ecc..). The main problems I see are two:

There is no way to include a custom module that register new architectures or tasks. Something similar to tensor2tensor's --t2t_usr_dir.
The pre-process script make the assumption that the only available Dictionary is the standard one, and it does not ask the task to provide its implementation.

So I would like to ask if there is some option I missed and this is actually already possible or, if not, would you accept a pull request enabling this feature?
At the moment I ended up cloning all python scripts in fairseq home folder.. and this is definitely a bad idea!
Thanks!

Thanks for driving these improvements @davidecaroselli! Btw, we have a new engineer who is looking into improving support for character-level models, who is now also looking at merging Tokenizer into Dictionary like we discussed in the other thread. Closing this for now, but I’ll keep you updated.

Thanks @myleott for the amazing support!


Add integration test demonstrating use of PersistentVolumeClaims for inter-build caching

Functional example of #52
Proposed Changes

Test defines a PersistentVolumeClaim which is attached first to a build that populates the cache, then another build reads the cache

Release Note

NONE

@ImJasonH you should sync with @srinivashegde86 who has been moving some of our common test code into knative/pkg to better enable this.
In the meantime, it might be interesting to write such a test in the knative/serving repo?

#341 instead


Incorrect commands

creating new route:

runing ember serve:

It seems like the node.exe is redundant. Tried with Ember.js-2018.2.1-0 and Ember.js-2018.1.2-0.

@makepanic any ideas?

Sounds like https://github.com/Turbo87/intellij-emberjs/issues/191#issuecomment-379168826
Basically it seems like the cmd generation on windows is broken.

I can check on Windows. Send me or give the link to patched Ember.js-2018.1.2-0


New Support for model lookups from models

For discussion -- want to discuss interactively and also make sure this is really going to add enough value in the app for the additional API complexity.

The term "owned" models could be formalized in this release and potentially renamed as
-"linked"? "hosted"? "mounted? "hoisted"? :-), "created" etc. etc.

Method could be called onCreated, onMounted, etc.  (although mounting has a specific historical meaning in the react rendering phases, and I think when we call this method is not exactly that.
Would still like a way to pass props (or at "initial" props) to the new model, and it can be done fairly easily for the models created by "create" -- the problem is how to do it cleanly for useLocalModel.
See Toolbox branch for additional usages of the new API.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[X] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[X] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[X] Updated doc comments / prop-types, or determined not required.
[X] Reviewed and tested on Mobile, or determined not required.
[X] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Looks great - took a while to grok, but I think I understand it all :)
In terms of the naming, I'm leaning towards onCreated over onLinked - it lends itself more closely to being an initialisation lifecycle step, and pairs well with the model: creates() syntax. We could also consider init() as a kind of analog to HoistService's calling initAsync()?
I'm not sure I understand the difficulty in passing initial props when using useLocalModel() - couldn't we leave that up the app, and then the dev can just pass it through the hook in the render method as currently?

I think this looks great! Going to clean up a lot of code for me.
I think the terminology could use some discussion, though what you have here may be the best. I find "owned" to be a little confusing since models are always "owned" by either a component or another model - perhaps "mounted"?
Some thoughts I had while looking it over and thinking about how I would want to use this in apps:

We could consider passing the modelLookup to the onLinked method to allow consistent initialization of child models (having the parent model call onLinked on any child models it constructs/owns). May especially be useful for the (anti?) pattern of having models which may exist both as an owned model or unowned, so they can have a consistent initialization pattern regardless of the context in which they exist.
We could also then consider automatically calling onLinked on any "managed" models which have been instantiated so the boilerplate in the parent model isn't necessary in most cases.

I think we are trying to avoid adding more decorators to a certain extent but would be really nice if I could just do something like the following:
class MyModel extends HoistModel {
    @lookupModel(ParentModel) myParentModel;
}

and then have the base HoistModel implementation inject my references for me.

Lots of great ideas swirling around -- would like to schedule a brainstorming meeting to discuss with all interested parties


improvementSync stats cache while task finished, doesn't need to query column_statistics table.

Before, when analyze job finished, the last finished task will query column_statistics table to get the latest stats for each column and update the stats cache in all FEs. Query for column_statistics could be slow and unnecessary.
This pr remove the query logic, move the update cache logic to each task. When the task finished, it already have the latest stats for that column in memory, simply update cache use the data in memory.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


filament::backend::Platform::retrieveBlob on Adreno 506

Describe the bug
I thought the Platform::retrieveBlob crash was solved in 1.40.4 by opengl: fix b/290670707 : crash when using the blob cache, however there are still some users getting this crash.
I noticed that +95% of these crashes happen on Adreno 506 devices.
To Reproduce
Steps to reproduce the behavior:

Go https://www.lambdatest.com, create a free account
Select an Adreno 506 device, I used the Moto G6
Run any app that uses ModelViewer to render a model
Wait a few seconds, it'll crash

Screenshots
There should a cube above the arrow but it's rendering nothing

Logs
https://gist.github.com/victorbrndls/d364d1c82e795bed69fcbe59e8028d53
Crashed: Thread: SIGSEGV  0x0000000000000038
#00 pc 0x153063 libfilament-jni.so (filament::backend::Platform::retrieveBlob(void const*, unsigned long, void*, unsigned long)) (BuildId: 27cee80154c5ac995e6320e801e5c129bec11fe6)
#01 pc 0x11ba0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#02 pc 0x11bd0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#03 pc 0x11c00 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#04 pc 0x11ba0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#05 pc 0x11bd0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#06 pc 0x11c00 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#07 pc 0xfc984 libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#08 pc 0x8bdc4 libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#09 pc 0x11ba0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#10 pc 0x11bd0 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#11 pc 0x11c00 libandroid.so (BuildId: 6ca7c5cb01ece365f4aea339728222bc)
#12 pc 0x92bac libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#13 pc 0x92b90 libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#14 pc 0x2af2e libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#15 pc 0x92b90 libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)
#16 pc 0x151548 ld-android.so (BuildId: 26b7e37338cf51d1e52f65c49bd6ad33)
#17 pc 0x269b6 libc.so (BuildId: 70c0bef1f8b2d414312145553219d07a)

Smartphone

Device: Moto G6
OS: Android 9

It has also happened on an Oppo A3s.
Additional context
Using Filament 1.40.4

@pixelflinger

I think retrieveBlob is a red herring because libandroid is definitely not calling it.

Hi there,
I've also been getting a lot of crashes on phones with GPU Adreno 506. Further details below:
Smartphone:

OPPO CPH1903, OPPO CPH1851, HUAWEI HWDUB-Q, Motorola Moto G (5S) Plus, Phones with GPU Adreno 506
OS: Android 8.1 (nearly all crashes seem to be from this particular OS so not sure if it plays a part, also looks like highest upgradable Android OS for these devices)

Filament Version: 1.34.0

Log:
backtrace:
  #00  pc 0x000000000099d738  /vendor/lib64/libllvm-glnext.so (llvm::Module::setModuleIdentifier(llvm::StringRef)+156)
  #01  pc 0x000000000099d5f8  /vendor/lib64/libllvm-glnext.so (ESXLinker::bcConstruct()+1172)
  #02  pc 0x000000000099fc18  /vendor/lib64/libllvm-glnext.so (SOLinker::linkShaders(QGLC_LINKPROGRAM_DATA*, QGLC_LINKPROGRAM_RESULT*)+180)
  #03  pc 0x0000000000997298  /vendor/lib64/libllvm-glnext.so (CompilerContext::LinkProgram(unsigned int, QGLC_SRCSHADER_IRSHADER**, QGLC_LINKPROGRAM_DATA*, QGLC_LINKPROGRAM_RESULT*)+492)
  #04  pc 0x0000000000a75370  /vendor/lib64/libllvm-glnext.so (QGLCLinkProgram(void*, unsigned int, QGLC_SRCSHADER_IRSHADER**, QGLC_LINKPROGRAM_DATA*, QGLC_LINKPROGRAM_RESULT*)+104)
  #05  pc 0x00000000001c4ef4  /vendor/lib64/egl/libGLESv2_adreno.so (EsxShaderCompiler::CompileProgram(EsxContext*, EsxProgram const*, EsxLinkedList const*, EsxInfoLog*)+2360)

If this is a seperate issue, I can log another issue. Thank you.

I meet the same problem, and it was solved in 1.42.0

I meet the same problem, and it was solved in 1.41.0我遇到了同样的问题，在1.41.0中解决了

this commit solves the crash.
workaround a crash with some adreno drivers Mathias Agopian 2023/8/1, 05:41


[MB-14480] Move history should only show one entry for excess weight notification dismissal

Jira ticket for this change
Summary
This PR removes the duplicate dismiss weight move event and replaces it with blank details inline with the decision to not make a template for change of status noted in Confluence document on Move statuses in PO9.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

Find a new move as the TOO and submit a HHG shipment
Log in as the prime to update the shipment estimated weight.  That should trigger the excess weight qualified at.
Log back in as TOO, locate the move and go to move task order.
There should be a notification of that states the move is at risk for being overweight. Click the x to dismiss it.
Go to move history. There should only be one entry for dismissing the weight risk.

Screenshot
Before

After

Messages

:book:
:link: MB-14480

  Generated by :no_entry_sign: dangerJS against 1a4cd79f6972f2fa53d27db00ccd81ad4d8c1703


Add note about theme.id when customization is used

Fixes https://github.com/wintercms/winter/issues/1214

@bennothommo @LukeTowers
So should I close this? Did we decide to fix the Theme class so its is is always the same css friendly identifier?

@mjauvin I believe so, there's a private PR that @bennothommo is working on right now that should fix wintercms/winter#1214


View boundary attributes in mesh-explorer [view-bdr-dev]

This is a smallish change to the mesh-explorer miniapp which views boundary attributes by skinning a 3D mesh to produce a 2D mesh consisting of its boundary elements.
Currently this mesh skinning function does not support mesh nodes defined using a discontinuous grid function.  This limitation can be revisited after merging PR #716 or PR #1194.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

https://github.com/mfem/mfem/pull/1231
@mlstowell
@tzanio
@drzisga + @bslazarov
01/13/20
⌛due 02/03/20
⌛due 02/10/20

How should I test it? It compiles and runs without any problems. However, I am not sure how to test the new features.

However, I am not sure how to test the new features.

Build mesh-explorer (in miniapps/meshing) and open a mesh with boundary attributes, e.g. ../../data/beam-hex.mesh)?

Compiles fine, valgrinded - everything is ok, works fine as well!

Thanks @bslazarov! @drzisga, do you have time to take a look?

Merged in next for testing ...


Have toggle option for facets on mobile only if facets are present

@sihugh noticed that on https://www.gov.uk/prepare-eu-exit/going-and-being-abroad the 'show more search options' link is visible on mobile, even though there are no more search options. This change fixes that.

Example where there this link should be present: /news-and-communications
Example where it shouldn't be present: /prepare-eu-exit/going-and-being-abroad

Could you write a test for this?


[fix] electron-builder on mac

fix npm run package:mac on mac-os

Note that normally, electron-builder automatically picks-up icon files inside the buildResources folder (typically: icon.icns and icon.ico which contain multiple resolutions).
https://github.com/readium/readium-desktop/blob/4155769dae1684e136371d2c786816156adda2cc/package.json#L96-L97
...but right now this special folder contains the following subfolder icon:
https://github.com/readium/readium-desktop/tree/4155769dae1684e136371d2c786816156adda2cc/resources
This is why the icon reference must be explicit, as per this PR's fix.
See documentation:
https://www.electron.build/icons

I am merging this, but I will file a separate issue about the electron-builder icon files expected by default inside the buildResources folder.

A duplicate appeared during a merge (need to find when), so I pushed a hotfix directly in the develop branch:
https://github.com/readium/readium-desktop/commit/209b4513844848e1d19c606a1d186d85eb89741b

Okay, looking at the package.json history, it seems that the squash performed by GitHub when merging the PR must have picked-up some code differences with the develop branch that your PR did not originally contain.
https://github.com/readium/readium-desktop/commits/develop/package.json
So, to avoid this problem, in the future before merging PRs, I suggest the owner of the source branch does a git pull (i.e. fetch + merge) in their local develop branch (in their cloned / forked repository), then a git merge develop inside their PR branch.


[WIP] Implement CIP-0067

Implementation of CIP-0067 which is a prerequisite for CIP-0068.

Thanks for this @keyan-m , it's a very nice addition to elm-cardano!
I've done the following few changes:

extracted Crc8 into its own module
added tests for Crc8
added tests for Cip67

Let me know what you think and if I've done changes you find unclear.

I think you've made nice improvements, thank you :)

One last thing. Can we get rid of rtfeldman/elm-hex? I haven't checked which functions are called from it but it would be nice if we don't need another dependency.

One last thing. Can we get rid of rtfeldman/elm-hex? I haven't checked which functions are called from it but it would be nice if we don't need another dependency.

It's used for toDecimal and fromDecimal in Bytes.Comparable. These two were needed for implementing the CRC-8 digest, which requires bitwise operations (it obviously can be found without them, but I believe this is the most optimized implementation). The bitwise operations available in Elm's core library work with Int values, hence the conversions of Bytes to decimals.
I myself don't love the extra dependency, but it's a very minimal package, and I haven't been able to find another way around it... Perhaps developing a complete CRC package for Elm? 😅

Alright, I removed the dependency by leveraging elm/bytes encoders and decoders directly since they have a few stuff dealing with U8 and U16 already. All tests are passing so it should be good.

Thanks @keyan-m !
There is still the decoder which is a TODO, but we can deal with that later when we actually start decoding stuff.

OK nice, I should've looked at Bytes a bit more carefully!


FIX: added CPyRAM support

Codecov Report
Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 33.97%. Comparing base (692c6e4) to head (3bac66c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4676       +/-   ##
===========================================
- Coverage   80.75%   33.97%   -46.79%
===========================================
  Files         120      119        -1
  Lines       54694    54641       -53
===========================================
- Hits        44170    18566    -25604
- Misses      10524    36075    +25551


undefined method order_from_params for #Administrate::Field::NestedHasMany

Hi All,
I have two models DashboardParameterKey which has_many DashboardParameterValue.
I am facing an issue where I am unable to add / edit DashboardParameterKey records and see this exception undefined method order_from_params for #<Administrate::Field::NestedHasMany:0x00007fb5a080e5f0> excluded from capture: DSN not set
below is my relevant code
class DashboardParameterKey < ApplicationRecord
  has_many :dashboard_parameter_values, dependent: :destroy
  accepts_nested_attributes_for :dashboard_parameter_values, allow_destroy: true, reject_if: :all_blank
end

class DashboardParameterValue < ApplicationRecord
  belongs_to :dashboard_parameter_key
end

require "administrate/base_dashboard"
class DashboardParameterKeyDashboard < Administrate::BaseDashboard
    ATTRIBUTE_TYPES = {
     dashboard_parameter_values: Field::NestedHasMany,
    }.freeze
end

Any help in addressing the issue will be really great, thanks.

The term "DSN" makes me think of the sentry-raven error reporter (doc), I see that Administrate uses that gem (I guess for its example app) but I don't know how it could be the cause of what you observe. The exact error message you got seems to be thrown here:
https://github.com/getsentry/raven-ruby/blob/7121d3cf845b1b5769cd4d5f7d7ccf37b38518c6/lib/raven/instance.rb#L107
You may find more information by looking at the stack trace of the error.

I think @sedubois is on to something there. Also @aksharj, would it be possible to paste the whole exception trace? Thank you,

Hi @pablobm @sedubois many thanks for your reply. Here is the full exception trace. Any help in fixing this would be really really great.
undefined method `order_from_params' for #<Administrate::Field::NestedHasMany:0x00007fe2c8d6ec70> excluded from capture: DSN not set

ActionView::Template::Error (undefined method `order_from_params' for #<Administrate::Field::NestedHasMany:0x00007fe2c8d6ec70>):
    19: %>
    20:
    21: <% if field.resources.any? %>
    22:   <% order = field.order_from_params(params.fetch(field.name, {})) %>
    23:   <% page_number = params.fetch(field.name, {}).fetch(:page, nil) %>
    24:   <%= render(
    25:     "collection",

administrate-field-nested_has_many (1.1.0) app/views/fields/nested_has_many/_show.html.erb:22:in `___sers_imcglobal__rvm_gems_ruby_______gems_administrate_field_nested_has_many_______app_views_fields_nested_has_many__show_html_erb__514099133466338727_70305991622440'
actionview (5.2.3) lib/action_view/template.rb:159:in `block in render'
activesupport (5.2.3) lib/active_support/notifications.rb:170:in `instrument'
actionview (5.2.3) lib/action_view/template.rb:354:in `instrument_render_template'
actionview (5.2.3) lib/action_view/template.rb:157:in `render'
xray-rails (0.3.2) lib/xray/engine.rb:27:in `render_with_xray'
actionview (5.2.3) lib/action_view/renderer/partial_renderer.rb:344:in `block in render_partial'
actionview (5.2.3) lib/action_view/renderer/abstract_renderer.rb:44:in `block in instrument'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `block in instrument'
activesupport (5.2.3) lib/active_support/notifications/instrumenter.rb:23:in `instrument'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `instrument'
actionview (5.2.3) lib/action_view/renderer/abstract_renderer.rb:43:in `instrument'
actionview (5.2.3) lib/action_view/renderer/partial_renderer.rb:333:in `render_partial'
actionview (5.2.3) lib/action_view/renderer/partial_renderer.rb:312:in `render'
actionview (5.2.3) lib/action_view/renderer/renderer.rb:49:in `render_partial'
actionview (5.2.3) lib/action_view/renderer/renderer.rb:23:in `render'
actionview (5.2.3) lib/action_view/helpers/rendering_helper.rb:33:in `render'
/Users/imcglobal/.rvm/gems/ruby-2.5.3/bundler/gems/administrate-710850922a8e/app/helpers/administrate/application_helper.rb:7:in `render_field'
/Users/imcglobal/.rvm/gems/ruby-2.5.3/bundler/gems/administrate-710850922a8e/app/views/administrate/application/show.html.erb:46:in `block in ___sers_imcglobal__rvm_gems_ruby_______bundler_gems_administrate__________a_e_app_views_administrate_application_show_html_erb__2740327399816530191_70306004580360'
/Users/imcglobal/.rvm/gems/ruby-2.5.3/bundler/gems/administrate-710850922a8e/app/views/administrate/application/show.html.erb:37:in `each'
/Users/imcglobal/.rvm/gems/ruby-2.5.3/bundler/gems/administrate-710850922a8e/app/views/administrate/application/show.html.erb:37:in `___sers_imcglobal__rvm_gems_ruby_______bundler_gems_administrate__________a_e_app_views_administrate_application_show_html_erb__2740327399816530191_70306004580360'
actionview (5.2.3) lib/action_view/template.rb:159:in `block in render'
activesupport (5.2.3) lib/active_support/notifications.rb:170:in `instrument'
actionview (5.2.3) lib/action_view/template.rb:354:in `instrument_render_template'
actionview (5.2.3) lib/action_view/template.rb:157:in `render'
xray-rails (0.3.2) lib/xray/engine.rb:27:in `render_with_xray'
actionview (5.2.3) lib/action_view/renderer/template_renderer.rb:54:in `block (2 levels) in render_template'
actionview (5.2.3) lib/action_view/renderer/abstract_renderer.rb:44:in `block in instrument'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `block in instrument'
activesupport (5.2.3) lib/active_support/notifications/instrumenter.rb:23:in `instrument'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `instrument'
actionview (5.2.3) lib/action_view/renderer/abstract_renderer.rb:43:in `instrument'
actionview (5.2.3) lib/action_view/renderer/template_renderer.rb:53:in `block in render_template'
actionview (5.2.3) lib/action_view/renderer/template_renderer.rb:61:in `render_with_layout'
actionview (5.2.3) lib/action_view/renderer/template_renderer.rb:52:in `render_template'
actionview (5.2.3) lib/action_view/renderer/template_renderer.rb:16:in `render'
actionview (5.2.3) lib/action_view/renderer/renderer.rb:44:in `render_template'
actionview (5.2.3) lib/action_view/renderer/renderer.rb:25:in `render'
actionview (5.2.3) lib/action_view/rendering.rb:103:in `_render_template'
actionpack (5.2.3) lib/action_controller/metal/streaming.rb:219:in `_render_template'
actionview (5.2.3) lib/action_view/rendering.rb:84:in `render_to_body'
actionpack (5.2.3) lib/action_controller/metal/rendering.rb:52:in `render_to_body'
actionpack (5.2.3) lib/action_controller/metal/renderers.rb:142:in `render_to_body'
actionpack (5.2.3) lib/abstract_controller/rendering.rb:25:in `render'
actionpack (5.2.3) lib/action_controller/metal/rendering.rb:36:in `render'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:46:in `block (2 levels) in render'
activesupport (5.2.3) lib/active_support/core_ext/benchmark.rb:14:in `block in ms'
/Users/imcglobal/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
activesupport (5.2.3) lib/active_support/core_ext/benchmark.rb:14:in `ms'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:46:in `block in render'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime'
activerecord (5.2.3) lib/active_record/railties/controller_runtime.rb:31:in `cleanup_view_runtime'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:45:in `render'
/Users/imcglobal/.rvm/gems/ruby-2.5.3/bundler/gems/administrate-710850922a8e/app/controllers/administrate/application_controller.rb:24:in `show'
actionpack (5.2.3) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
actionpack (5.2.3) lib/abstract_controller/base.rb:194:in `process_action'
actionpack (5.2.3) lib/action_controller/metal/rendering.rb:30:in `process_action'
actionpack (5.2.3) lib/abstract_controller/callbacks.rb:42:in `block in process_action'
activesupport (5.2.3) lib/active_support/callbacks.rb:109:in `block in run_callbacks'
sentry-raven (2.9.0) lib/raven/integrations/rails/controller_transaction.rb:7:in `block in included'
activesupport (5.2.3) lib/active_support/callbacks.rb:118:in `instance_exec'
activesupport (5.2.3) lib/active_support/callbacks.rb:118:in `block in run_callbacks'
ahoy_matey (3.0.0) lib/ahoy/controller.rb:45:in `set_ahoy_request_store'
activesupport (5.2.3) lib/active_support/callbacks.rb:118:in `block in run_callbacks'
activesupport (5.2.3) lib/active_support/callbacks.rb:136:in `run_callbacks'
actionpack (5.2.3) lib/abstract_controller/callbacks.rb:41:in `process_action'
actionpack (5.2.3) lib/action_controller/metal/rescue.rb:22:in `process_action'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `block in instrument'
activesupport (5.2.3) lib/active_support/notifications/instrumenter.rb:23:in `instrument'
activesupport (5.2.3) lib/active_support/notifications.rb:168:in `instrument'
actionpack (5.2.3) lib/action_controller/metal/instrumentation.rb:32:in `process_action'
actionpack (5.2.3) lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
activerecord (5.2.3) lib/active_record/railties/controller_runtime.rb:24:in `process_action'
actionpack (5.2.3) lib/abstract_controller/base.rb:134:in `process'
actionview (5.2.3) lib/action_view/rendering.rb:32:in `process'
actionpack (5.2.3) lib/action_controller/metal.rb:191:in `dispatch'
actionpack (5.2.3) lib/action_controller/metal.rb:252:in `dispatch'
actionpack (5.2.3) lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
actionpack (5.2.3) lib/action_dispatch/routing/route_set.rb:34:in `serve'
actionpack (5.2.3) lib/action_dispatch/journey/router.rb:52:in `block in serve'
actionpack (5.2.3) lib/action_dispatch/journey/router.rb:35:in `each'
actionpack (5.2.3) lib/action_dispatch/journey/router.rb:35:in `serve'
actionpack (5.2.3) lib/action_dispatch/routing/route_set.rb:840:in `call'
apipie-rails (0.5.15) lib/apipie/static_dispatcher.rb:66:in `call'
xray-rails (0.3.2) lib/xray/middleware.rb:38:in `call'
apipie-rails (0.5.15) lib/apipie/extractor/recorder.rb:137:in `call'
rack-attack (5.4.2) lib/rack/attack.rb:182:in `call'
warden (1.2.8) lib/warden/manager.rb:36:in `block in call'
warden (1.2.8) lib/warden/manager.rb:34:in `catch'
warden (1.2.8) lib/warden/manager.rb:34:in `call'
rack (2.0.7) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.0.7) lib/rack/etag.rb:25:in `call'
rack (2.0.7) lib/rack/conditional_get.rb:25:in `call'
rack (2.0.7) lib/rack/head.rb:12:in `call'
actionpack (5.2.3) lib/action_dispatch/http/content_security_policy.rb:18:in `call'
rack (2.0.7) lib/rack/session/abstract/id.rb:232:in `context'
rack (2.0.7) lib/rack/session/abstract/id.rb:226:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/cookies.rb:670:in `call'
activerecord (5.2.3) lib/active_record/migration.rb:559:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
activesupport (5.2.3) lib/active_support/callbacks.rb:98:in `run_callbacks'
actionpack (5.2.3) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
railties (5.2.3) lib/rails/rack/logger.rb:38:in `call_app'
railties (5.2.3) lib/rails/rack/logger.rb:26:in `block in call'
activesupport (5.2.3) lib/active_support/tagged_logging.rb:71:in `block in tagged'
activesupport (5.2.3) lib/active_support/tagged_logging.rb:28:in `tagged'
activesupport (5.2.3) lib/active_support/tagged_logging.rb:71:in `tagged'
railties (5.2.3) lib/rails/rack/logger.rb:26:in `call'
ahoy_matey (3.0.0) lib/ahoy/engine.rb:22:in `call_with_quiet_ahoy'
sprockets-rails (3.2.1) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/request_id.rb:27:in `call'
rack (2.0.7) lib/rack/method_override.rb:22:in `call'
rack (2.0.7) lib/rack/runtime.rb:22:in `call'
activesupport (5.2.3) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (5.2.3) lib/action_dispatch/middleware/static.rb:127:in `call'
rack (2.0.7) lib/rack/sendfile.rb:111:in `call'
sentry-raven (2.9.0) lib/raven/integrations/rack.rb:51:in `call'
railties (5.2.3) lib/rails/engine.rb:524:in `call'
puma (3.12.1) lib/puma/configuration.rb:227:in `call'
puma (3.12.1) lib/puma/server.rb:660:in `handle_request'
puma (3.12.1) lib/puma/server.rb:474:in `process_client'
puma (3.12.1) lib/puma/server.rb:334:in `block in run'
puma (3.12.1) lib/puma/thread_pool.rb:135:in `block in spawn_thread'

@aksharj your Administrate gem seems to be pinned to revision 710850922a8e which I was unable to locate (latest is 0.13.0), and your administrate-field-nested_has_many is version 1.1.0 (latest is 1.2.0). You could give a try again after updating both gems to the latest released versions?

hi @sedubois, thats awesome, many thanks for your reply. that fixed it.


0.4.0dev merge to main

The 0.4.0dev branch has been the de-facto main branch for the last ~2 months, so I think we should merge here as well.
The major change is the new CLI-based reconstruction workflows that depends on the alg-dev branch of waveorder.
I have tested this branch on hummingbird and other microscope quite extensively. Some bugs still exist (I ran into #368 again this morning), but they are documented and will be solved ahead of recOrder's next release.

Tests are failing because we're updating recOrder's 0.4.0dev and waveorder's alg-dev branches together. When we're closer to merging them both, I'll make another waveorder release and fix the tests.

waveorder will need a dev release and the depency will need to be updated for the tests to pass here.

All tests are passing except for the napari hub preview page. @clinton-huynh needs this to merge, so I'll open a separate issue to remind us to fix napari hub before the 0.4.0 release.


Add Chime app

Project URL
https://github.com/ChimeHQ/Chime
Category
Editors
Description
Built for macOS
Chime was designed to be a model citizen on the Mac. Even its extensions are native.
Checklist

[x] Edit applications.json instead of README.md.
[x] Only one project/change is in this pull request
[x] Screenshots(s) added if any
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

@pahnev Thanks!


Podcast: add SuperScalar Deep Dive

Two commits here
First one is a refactor of the podcast linking includes so I can reuse component in an non-newsletter podcast.
I tried to keep the diff small including spacing, but you can check using the commands: (provided in another PR by @harding)

Checkout this branch
Build the tip: make clean all (all tests should pass except the fixme)
Backup the generated site: cp -a _site _new_site
Checkout the merge root, something like git reset --hard HEAD^2
Build the site again: make clean build
Diff the resultant HTML: diff -ruN _site _new_site | colordiff | less -R

Second adds the SuperScalar podcast. I am using dropbox to host the audio file before publication, so the timestamp seeking might be slow.
Current publication targeting for 10/31.
If there are better ways to jekyll this, open to suggestions. @harding if this ruins hugo compatibility, let me know.

Tested ACK.  The code changes look fine to me.  Viewed the preview page for this podcast and was able to play from beginning; seeking didn't work for me but @bitschmidty notes that's probably an issue with the temporary staging on dropbox.  Viewed the preview page for several previous podcasts and everything LGTM.
Thanks @bitschmidty!


Offline caching

Given how Sass Guidelines is a single long text document, I can only assume some people would like to save it as a read for their flight, where they have not much to do. Therefore it would be nice if we could use some application cache to make the reading experience available offline.

Will do!

Sweet! Feel free to open a PR against gh-pages. :)

It's basically only the different language versions, right? :)
The rest of the website is one file anyway and there is no routing or something the like.

Yep. We should be caching all the languages, that's it. :)

And the assets, stylesheets, javascript etc., right?

check out PouchDB.com’s setup, also https://github.com/gr2m/appcache-nanny/ might be helpful.

Yep, we need to cache the assets as well. Basically, we need to cache what is needed so that the site is usable while offline.

Did it by hand, see #290


Better context menu for selecting members

In NodeClickListener
So for fields:

[x] Access
[x] Search uses
[x] Default Value
[x] Edit Definition (This brings up menu containing)

[x] Name
[x] Desc
[x] Signature

And methods:

[x] Access
[x] Search uses
[ ] Local Variables
[x] Opcodes
[ ] AST Flow chart
[ ] Edit Definition (This brings up menu containing)

[x] Name
[x] Desc
[x] Signature
[ ] Max Locals
[ ] Max Stack

In the future most of these will be compacted into a single window. For instance:

de82297fada6d80a3a0c2a377d5e388e68101a00 lets you access the variable table from the member context menu. I'm closing this despite not finishing the AST flow chart. I'll handle flow charts and applications of them in another issue.


Set default native arg passing to Legacy on Windows.

PR Summary
The committee agreed to a new PSWindowsNativeCommandArgPassing experimental feature.  When this feature is enabled:

On Windows

$PSNativeCommandArgumentPassing = Windows

Non-Windows

$PSNativeCommandArgumentPassing = Standard

When this feature is disabled:

On Windows

$PSNativeCommandArgumentPassing = Legacy

Non-Windows

$PSNativeCommandArgumentPassing = Standard

Additionally, new telemetry metric will be added for native command execution to inform the mode being used.

PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[ ] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[x] Issue filed: https://github.com/MicrosoftDocs/PowerShell-Docs/issues/9739

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

I understand there will be difference between stable and preview versions. However, the native arg passing feature is already official, so making an official feature behave differently seems confusing.
Introducing a new experimental feature for the different arg passing behavior in preview versions sounds like a good idea. A doc issue needs to be opened for the new experimental feature.

@daxian-dbw We should probably advertise that Windows mode is still experimental and changes will continue until we can get to an acceptable level of compatibility

@PowerShell/powershell-committee Please review this PR and decide whether this PR should be closed or accepted.

@PowerShell/powershell-committee discussed this.  We agreed to a new NativeCommandArgPassingWindowsMode experimental feature.  When this feature is enabled:

On Windows

$PSNativeCommandArgumentPassing = Windows

Non-Windows

$PSNativeCommandArgumentPassing = Standard

When this feature is disabled:

On Windows

$PSNativeCommandArgumentPassing = Legacy

Non-Windows

$PSNativeCommandArgumentPassing = Standard

Additionally, new telemetry metric will be added for native command execution to inform the mode being used.

@ImportTaste, this is marked to backport to 7.3.  So, 7.3 will change to Legacy as well.

@PowerShell/powershell-committee  Are we okay with making this change to 7.3 after it has been release?

PS-Committee decided to make this feature stable in 7.4, so the default will be Windows in 7.4.  Based on the telemetry, it seems that most Windows (like 99%) have not changed the default in 7.4 previews to Legacy or Standard.


Roadmaps for 1.4 release

Training Operator 1.3 operator has been released for few months. It's time to build wishlist for the next release.  Community is collecting roadmaps for kubeflow 1.5 release as well (Jan or Feb?). https://github.com/kubeflow/community/issues/535
I think for the next release, we can put more time to build a decent elastic training story.

@gaocegege is working on PyTorch parts and the large PR has been merged.
On the other hand, mpi-operator v1 has been integrated into training-operator and we can enrich the elastic work (expose arbitrary worker to scale in instead of just operating the numbers) based on what @zw0610 did in the past.
If we do have additional time, we can revisit tensor flow elastic training story.

There's some more meaningful tasks like GenericJob which can support flexible framework is nice to have. Supporting different gang definition maybe something worth to explore as well. Feel free to brainstorm the ideas and we can summarize a roadmap and then recruit contributors and release managers.
/cc @kubeflow/wg-training-leads

Migrating notes from today's community meeting:

Training Operator ROADMAP for Kubeflow 1.5: https://github.com/kubeflow/community/issues/535

We will present it at the next community meeting.

Draft roadmap and initial thoughts https://github.com/kubeflow/training-operator/issues/1496

Create draft presentation based on above issue
Support MPI Operator v1 in universal Training Operator

V1 MPI controller - completed but need to double check with contributors whether manifests are ready for KF1.5
V2 MPI controller - not migrated to common operator yet https://github.com/kubeflow/training-operator/issues/1479

Better test coverage:

https://github.com/kubeflow/training-operator/issues/1311
https://github.com/kubeflow/training-operator/issues/1497


TypeError in Middleware When Using Bytenode with NestJS

Issue: TypeError in Middleware When Using Bytenode with NestJS
Description
In a NestJS backend project, after creating a custom middleware (SessionMiddleware) and bundling the project with Webpack and Bytenode, a TypeError: Class constructor SessionMiddleware cannot be invoked without 'new' is encountered when attempting to run an endpoint that uses the middleware.
Project Details
Environment:

Node.js: v20.18.0
npm: v10.8.2
pnpm: v9.9.0
NestJS CLI: v10.4.5
Bytenode: v1.5.6

Middleware Code
import { Injectable, NestMiddleware } from '@nestjs/common';
import { Request, Response, NextFunction } from 'express';
import { SessionService } from './session.service';

@Injectable()
export class SessionMiddleware implements NestMiddleware {
  constructor(private sessionService: SessionService) {}

  async use(req: Request, res: Response, next: NextFunction) {
    // Middleware logic to validate and process session data
    next();
  }
}

Middleware Registration in Module
import { Module, MiddlewareConsumer, RequestMethod } from '@nestjs/common';
import { AuthController } from './auth.controller';
import { SessionMiddleware } from './session.middleware';

@Module({
  controllers: [AuthController],
  providers: [SessionMiddleware],
})
export class AuthModule {
  configure(consumer: MiddlewareConsumer) {
    consumer.apply(SessionMiddleware).forRoutes(AuthController);
  }
}

Webpack Configuration
The project is bundled with Webpack and includes Bytenode to create an executable file. Below is the Webpack configuration used:
const path = require('path');
const { CleanWebpackPlugin } = require('clean-webpack-plugin');
const webpack = require('webpack');
const BytenodeWebpackPlugin = require('@herberttn/bytenode-webpack-plugin');

const WebPackIgnorePlugin = {
  checkResource: function (resource) {
    const lazyImports = [
      '@nestjs/platform-express',
      '@nestjs/terminus',
      '@nestjs/swagger',
      'class-transformer',
      'class-validator',
      'oracledb',
    ];
    if (!lazyImports.includes(resource)) return false;
    try {
      require.resolve(resource);
    } catch (err) {
      return true;
    }
    return false;
  },
};

module.exports = {
  mode: 'production',
  target: 'node',
  entry: {
    server: './src/main.ts',
  },
  devtool: 'source-map',
  module: {
    rules: [
      {
        test: /\.tsx?$/,
        use: {
          loader: 'ts-loader'
        },
        exclude: /node_modules/,
        include: [path.resolve(__dirname, 'src')],
      },
    ],
  },
  resolve: {
    extensions: ['.tsx', '.ts', '.js'],
  },
  node: {
    dirname: false,
  },
  plugins: [
    new CleanWebpackPlugin(),
    new webpack.IgnorePlugin(WebPackIgnorePlugin),
    new BytenodeWebpackPlugin({ keepSource: true }),
  ],
  optimization: {
    minimize: false,
  },
  performance: {
    maxEntrypointSize:<PHONE_NUMBER>,
    maxAssetSize:<PHONE_NUMBER>,
  },
  output: {
    path: path.resolve(__dirname, 'prod'),
    filename: '[name].js',
  },
};

package.json Overview
Scripts:

Build: nest build
Run: start, start:dev, start:prod, start:executable, start:obfuscated
Testing & Linting: test, test:watch, test:cov, lint
Obfuscation: build:obfuscated

Dependencies:

NestJS Modules: @nestjs/core, @nestjs/common, @nestjs/platform-express, @nestjs/jwt, etc.
Databases: pg, typeorm, redis, cache-manager, etc.
Utilities: bcrypt, axios, morgan, winston, etc.
Web Security: passport, passport-jwt, passport-local

DevDependencies:

Build Tools: webpack, webpack-cli, ts-loader
Testing & Linting: jest, eslint, typescript
Obfuscation: javascript-obfuscator, @herberttn/bytenode-webpack-plugin

Error
Upon calling an endpoint that uses the SessionMiddleware, the following error is thrown:
TypeError: Class constructor SessionMiddleware cannot be invoked without 'new'
    at Object.use (/path/to/@nestjs/core/middleware/utils.js:64:24)
    at /path/to/@nestjs/core/router/router-proxy.js:9:23
    ...

Expected Behavior
The SessionMiddleware should initialize and handle requests as expected without errors.
Actual Behavior
The middleware fails to instantiate due to a TypeError, indicating that the class constructor cannot be invoked without new.
Additional Context

The issue occurs only after bundling with Webpack and using Bytenode.
Without Bytenode, the project works as expected.

Steps Tried for Troubleshooting

Verified dependencies for lazy loading with Webpack Ignore Plugin.
Confirmed middleware works when not bundled with Bytenode.

@herberttn Can you look into this issue please?

@tbareich could you create a repo with a sample project for me to test this? I'm not familiar with NestJS projects.

@tbareich could you create a repo with a sample project for me to test this? I'm not familiar with NestJS projects.

You can find the repository here: https://github.com/tbareich/nestjs-middleware. Please take a look at the README file.

I guess I found the cause of the error. I will make some tests and get back to this issue.

The issue is that<EMAIL_ADDRESS>uses the .toString() function to test where a middleware is a class or not. Bytenode removes the source code, so the test returns false here.
To solve the problem, add a static method to your middleware class:
static toString() {
    return 'class LoggerMiddleware';
  }

Thank you very much, Mr. @OsamaAbbas . I really appreciate your help 🙏


[Q] How do I add Audio Description to a TS file?

I read about Audio and Audio Description and from what I have understood, they are differnet and have their own descriptior tags(since audio description has to play at the same time as audio and its not a different audio choice), how do i add audio description .aac file to a ts file? I searched online everywhere and i cannot find sample files so the next best thing is to generate my own ts file. I need this file to test a media playback code to check if it can parse and play Audio Description.(I did not write the code, its some old company code so i am not sure how it works, but i need to check if i can use it or not).

Hi @Mewankyrshan
If you want to add an audio track to an existing service, you need a MUX. TSDuck is not a MUX.
TSDuck is able to update the signalization and add all required descriptors in the PMT for instance. However, the muxing of the new audio track, from a .aac file or whatever, needs another tool, typically ffmpeg or equivalent.

I could add the audio track to my ts file using ffmpeg, thanks a lot. And I'm guessing I should use tsduck to update the pmt of the new audio track?

I should use tsduck to update the pmt of the new audio track?

Exactly.

I was just about to ask a similar question, and I was also leaning on needed a muxer. I am guessing from the conversation above this is not possible:
We extract an the audio data from a TS 'chunk' (hls TS output from TS duck). We then process this into several audio files, and wanted to add them to the original TS 'chunk'. While I have found ways to do this with TSDuck it is not ideal, or simply does not work. e.g.
tsp -I file --interleave KSTS_video.ts KSTS_audio.ts -O file KSTS_merge.ts

The problem we have with FFmpeg is it does not map any SCTE data property or at all. So I guess my question would be is this flow maybe possible.
Extract and process the data. Combine the processed data with the original file into a new file. Use TS duck to extract and insert any non AV data into the new file? If this is not possible or would be super cumbersome, is there any TS muxer other than FFmpeg that you can recommend?

The problem we have with FFmpeg is it does not map any SCTE data property or at all.

@SteveMcFarlin, you are right, ffmpeg is known to destroy everything in the TS which is not video or audio from the processed service. There is a solution for that:

Encapsulate all PID's to preserve into a tunnel PID which is signaled as a data PID of the service.
Pipe through ffmpeg, doing the audio/video processing. It won't alter the data PID.
Pipe through TSDuck again to restore the encapsulated PID's from the tunnel.

In the TSDuck user's guide, there is an example which encapsulates the EIT PID to preserve it through ffmpeg. Based on this example, you can encapsulate any number of PID's into the tunnel. Please carefully read the description of the encap and decap plugins.

Thank you so much.


DESKTOP some improvements

some fixes

change textarea to some not editable presentation control in general app view
add masked text field for password in connect window :smile:
prepare blank frames for rest of functionalities (clickable in left menu)

important stuff:

call /logout via jsoup on "rozłącz" click (from menu) [BUT before that please read next point >> ]
most important: please add some class which will handle communication with server in "complex" way , I mean sth like: add class HotelServerConnection() and inside there should be some atributes for storing cookies, csrf, maybe username, hostname etc, this class should be instanced after app is started and this class should contain "must be" such methods: login() [which will call server via jsoup and save some data in class atributes = it's what there is done now in connectwindow but move it to mentioned method); logout() [which will call /logout via jsoup, we need to use response cookies previous saved in class while login method was triggered]; AND MOST important make getRequest() and postRequest methods which will encapsulate logic related to proper CSRF and session cookies handling, YOU KNOW aim of that everything is to centralize way in which we will communicate with our server, aim is to have all JSOUP stuff in one place, so instead playing with jsoup everytime, we will simply invoke getRequest(String url) with some url param ex. /api/client/asa?adsd and it will return server response in shape of plain json string and then we will use json package to manipulate (JSONArray, JSONObject etc). For postRequest(String url, String data) data param will be string with some json formatted data, and response will be the same as in getRequest.. SO that's it how I see this communication in our case, there is session, csrf token and everything else in usual way, THE main adventage is that we have really the same endpoints at server both for client side logic in js and for desktop app..  MOREOVER please think about how our app should act while waiting for server response, maybe we should throw whole stuff to other thread and so on...

przewijanie panelu w pionie jak content się nie mieści (dodaj klient - zmniejsz wysokość okna)


Deploy on Arbitrum Testnets

https://developer.arbitrum.io/intro/

The fact that multiple chains can run in parallel is a crucial perk to off-chain scaling technology. Currently, on Ethereum mainnet, there are 2 Arbitrum chains: one Arbitrum Rollup chain, called "Arbitrum One," and one AnyTrust chain, called "Nova"; users and developers can pick whatever suits their security / transaction cost needs.

An Arbitrum AnyTrust chain doesn’t have the same decentralization / trustlessness / permissionless security guarantees of a Rollup chain, and thus can offer lower fees. Rollup and AnyTrust are similar in many ways, though have one key difference: whereas in Rollup, all data is posted on L1 (which allows anyone to permissionless join as a validator), in AnyTrust, data is managed off-chain. In the case of a challenge, an AnyTrust chain reverts back to “rollup mode”; the security assumption here is that at least 2 of the committee members are honest (i.e., they will provide the data when it’s necessary). Keeping the data off-chain in the happy/common case means the system can charge the user significantly lower fees. For applications that require high transaction throughput and don’t require the full decentralization that rollups provide, AnyTrust could be a sensible tradeoff.

GD: for the time being, we'll just deploy on Arbitrum One Testnet, until some specific support is requested for Arbitrum Nova.

Arbitrum/Ethereum Differences:

Time in L2 is tricky; the timing assumptions one is used to making about L1 blocks don't exactly carry over into the timing of Arbitrum blocks.
Arbitrum's L2 block hashes should not be relied on as a secure source of randomness.
The L2 fees an Arbitrum transaction pays essentially work identically to gas fees on Ethereum. Arbitrum transactions must also, however, pay an L1-fee component to cover the cost of their calldata.
Arbitrum transaction receipts include two additional fields: l1BlockNumber, gasUdedForL1.

Block numbers and time:

Arbitrum blocks are assigned their own L2 block numbers, distinct from Ethereum's L1 block numbers.
But,,,,,,,,    accessing block numbers within an Arbitrum smart contract (i.e., block.number in Solidity) will return a value close to (but not necessarily exactly) the L1 block number at which the Sequencer received the transaction.
Arbitrum blocks have their own block numbers, starting at 0 at the Arbitrum genesis block and updating sequentially.
A client that queries an Arbitrum node's RPC interface (for, ie., transaction receipts) will receive the transaction's Arbitrum block number as the standard block number field. The L1 block number will also be included in the added l1BlockNumber field.

Nitro Goerli Rollup Testnet: This testnet (421613) uses the Nitro rollup tech stack; it is expected to be the primary, stable Arbitrum testnet moving forward. Users can now use Alchemy, Infura, and QuickNode to interact with the Arbitrum One.

Let's go for **Arbitrum Nitro Goerli" deployment.

Bridging 0.5 GoerliETH to 0.5 AGOR in Arbitrum Nitro Goerli:

L1 tx: https://goerli.etherscan.io/tx/0xc2613cc10de0425e8f3aafc2856ea884aa4e19153826d944e853314366714c6c
L2 tx:

Arbitrum Nitro Goerli:

Chain id: 421613
RPC: https://goerli-rollup.arbitrum.io/rpc
Explorer: https://goerli.arbiscan.io, https://goerli-rollup-explorer.arbitrum.io

Goerli faucet can be used on ETH/L1, and then bridge those to ARB/ETH/L2 via the Arbitrum Bridge dapp:

https://bridge.arbitrum.io/

(works the same of all Arbitrum chains, as long as they're available on preferred web wallet)

Arbitrum Nitro Goerli:
* Chain id: 421613

* RPC: https://goerli-rollup.arbitrum.io/rpc

* Explorer: https://goerli.arbiscan.io, https://goerli-rollup-explorer.arbitrum.io

I sent an Infura URL over Telegram, just in case you want to use that!

Bridging GoerliETH from L1 to L2 takes like 20-30 minutes.

Script "arbitrum:goerli" added to Web3 RPC gateway. It works seamlessly.

Deployed and verified contracts in Arbitrum Nitro Goerli:

Witnet Solidity Bridge:

WitnetDecoderLib: 0x9Ef886Df202100FFc1b38388b3591e0031E53045
WitnetParserLib: 0x7d0a71D7D797b7b2637F682e4cB47f66602e59F3
WitnetProxy: 0xa6a6b2cBE9Ce5B8fF94729F1eC402efc5042AbBF
WitnetRequestBoardTrustableDefault: 0x17c7b4E454689EF181dE1FfA6eC59b3D146344bD

Witnet use cases:

WitnetPriceRouter: 0xAafb2D27E2E0f83dcE501a2879aaD710ec377403
WitnetRandomness: 0xB0C5d40A7658b2ab28360aFa6eB5bAeb2fFe86c3

Witnet price feeds:

Price-ETH/USD-6: ``

Related PRs:

https://github.com/witnet/witnet-solidity-bridge/pull/296
https://github.com/witnet/witnet-price-feeds/pull/145
https://github.com/witnet/data-feeds-explorer/pull/271

Both evm accounts for pollers and bridges have been authorized.

Create new bridge stack in bootstrap host, named as "bridgearbitrumgoerli".

Created change request on https://docs.witnet.io.


Deepstream Support

Add deepstream recipes support and deepstream docker fix

Backport GStreamer 1.14 from warrior for deepstream docker support
Add recipe for deepstream-5.0 (core libraries, GStreamer plugins, samples, python binding)
Add recipe for deepstream python apps
Add python 3.6 recipe from python 3.7 recipe as base, since deepstream python binding requires python3.6

Thanks for the work on this. A couple of questions...
We already have gstreamer 1.14 recipes in meta-tegra/contrib, so we don't need those recipes repeated.  Can you try deepstream with the contrib recipes?
Is the older Python 3.6.x really a requirement?  Does deepstream not interoperate with newer versions? It would be good to see if we can drop this dependency, especially since as a BSP layer, we'd be breaking compatibility rules with the python3-dir and gpgme changes.
If down-revving is a hard requirement, that complicates things.  I'd be OK with adding, say, a python36_3.6.9.bb recipe (to the contrib sub-layer) that installs its interpreter as ${bindir}/python3.6,  and then force the deepstream-related python scripts to use python3.6 instead of python3 in their shebang lines.  Then instead of replacing python3-dir.bbclass, we could have a python36-dir.bbclass that points variables to the 3.6 paths, and reference that where there is the version-specific dependency. As long as it can be installed alongside the normal python3 and not conflict, and we can keep the blast radius for that change restricted to just the deepstream-related dependents, that should work OK and not require retesting every other python package in all layers to see if they all still work.

Hi @madisongh , thanks for reviewing this, we are excited to contribute to your project. To answer some of your questions:

Yes, we are going to try with the contrib recipes. At the time we added GStreamer 1.14 to the fork the support was not in place yet. If it works with the contrib that would be great!

Regarding the Python 3.6.x support. We found that deepstream python bindings depend on Python 3.6.x version. We agree this is not ideal and we were kind of surprised about this as well. The problem is not related with the python scripts per se, but with the bindings file (pyds.so) which is a dependency of the python apps (https://github.com/NVIDIA-AI-IOT/deepstream_python_apps).

Let us know your thoughts.

Yeah, it's a shame that NVIDIA didn't open-source the python bindings. That doesn't leave us with a whole lot of options.
One option would be to just omit the Python bindings library altogether, or at least package it separately from the main deepstream package (which may require some packaging workarounds to ignore the missing dependency on libpython3.6m.so).  That would at least make deepstream usable for C/C++ applications.  Folks that want to use the python bindings could go down the path of using the DS-5.0 NGC container, or could in their own distro/layer switch out to python 3.6 and include the python bindings package in their builds that way.
Another option would be to do what I mentioned earlier, creating a python 3.6 that could co-reside with normal python.  We could still package the deepstream python bindings separately, and then only if someone needed them would the extra python be included in their builds.  I think it's doable, but there could be some complications in this approach that I've missed.
A third option, which I expect would be quite a bit of work, would be to read through the NVIDIA documentation on the python bindings and write your own implementation of them that we could then build against whatever version of python is current.  From a brief glance at the DS docs, it looks like the bindings are more than just simple wrappers around the DS C API, though, so this could be a big hassle to maintain.
My preference, I guess, would be to start with the first option, just to get the base functionality in place, then figure out the python bindings issue later.  How does that sound?

It sounds like a good plan. It would help to absorb the support sooner and later focus on the python support. Unfortunately, since most of the ML and AI work is usually done in python this would become a must at some point. We are going to prepare the changes as discussed and be back to you soon.
I believe the best way to go would be adding the additional instance of Python 3.6 along with the default version, so both can co-exist somehow or at least leave Python 3.6 as an optional selection. I agree with you than trying to re-do the bindings might be more time consuming and likely quite difficult to maintain on later versions of Jetpack.
We are really interested in merging these changes to your project and improve the Jetson support. We have prepared this wiki for the community and we want it to point to the original project only :)
https://developer.ridgerun.com/wiki/index.php?title=Yocto_Support_for_NVIDIA_Jetson_Platforms

@mmadrigal Sounds good. Hopefully, NVIDIA will open-source the bindings in future versions of the SDK, so we won't have to have janky workarounds like this for too long.
Thanks!

Hi @madisongh , the team has done the changes and it is ready for you to review. We left the python bindings support on a separate branch in our fork, we will work on this later.
Also, we tested with the contrib recipes for GStreamer 1.14 and everything seems to work as expected :) we are going to update our wiki to use the contrib.

Thanks again for putting this together! Some refinements to consider for the future:

It would be nice to split the SDK up further, if possible, even if NVIDIA continues to release it as one giant blob.  That might take some work, and probably more understanding than I have about how the plugins and libraries are used.
I see NVIDIA provides sources for at least some of the libraries and gstreamer plugins.  At some point, it would be great to build what we can from source instead of using their prebuilt binaries.  That might help with the gstreamer version problem, too, if the plugins can be compiled against whatever the current version of gstreamer is in the tree.  That's worked out well for the other plugins NVIDIA provides in the BSP (most of the time, at least).
Likewise for the samples - build them from source instead of installing the prebuilts, maybe as a separate recipe.


Code Reference Indicator

Display the references count for methods, properties & interfaces. This functionality already exists in Visual Studio,. See here: https://dailydotnettips.com/find-the-references-easily-code-reference-indicator-in-visual-studio-2013-preview/

For JavaScript and TypeScript these settings are available:

A suitable extension would be needed for other languages.


Solidarity report and doctor

Soldiarity Report/Doctor
should use the .solidarity file to report the values of any given machine.
This would be ideal for people filing tickets.  If I identify my technology depends on 20 things in my solidarity file.  Then I could add "Please run yarn solidarity report" with my repo issue template, and it would give me results.
Like ignite doctor but for free.

Goal - Incorporate Trevor's envInfo in this process.
Wish driven development
solidarity report
This will capture the OS from envinfo.  We should also grab arch & cpu (feature of envinfo?)  TODO for Trevor.
Then we will use gluegun's print.table (I think that's right - probably needs me to update it).   To outline the values of each item in the .solidarity requirements.

ENV will print their values,
CLI will print versions,
FILE/DIR will print their permissions/existence.

If a user types solidarity report --verbose we can include packages (provided by envinfo).

I think given PR-121 is merged we can probably close this. If there are outstanding issues/changes, we can create a different ticket?

Let's do a quick meeting and jam on it, then close when we've written the next ticket.  Ping me on chat when you can.

Lots of progress on this found in https://github.com/infinitered/solidarity/tree/report_update
Running solidarity report on a project produces:
# ⚠ Environment Report:
-----------------------------------------------------------------------------------
### System

| System Basics | Value                                         |
| ------------- | --------------------------------------------- |
| OS            | macOS High Sierra 10.13.1                     |
| CPU           | x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz |
| Report Info   | 11/27/2017, 12:33:30 AM (in 0.41s)            |

### Commands

| Binary        | Location                     | Version    | Desired    |
| ------------- | ---------------------------- | ---------- | ---------- |
| watchman      | /usr/local/bin/watchman      | 4.7.0      | *ANY*      |
| node          | /usr/local/bin/node          | 8.6.0      | 8.6.0      |
| applesimutils | /usr/local/bin/applesimutils | 0.5.12     | *ANY*      |
| xcrun         | /usr/bin/xcrun               | 35         | 35         |
| detox         | /usr/local/bin/detox         | *UNKNOWN*  | *ANY*      |
| emulator      | /usr/local/bin/emulator      | *UNKNOWN*  | *ANY*      |
| react-native  | /usr/local/bin/react-native  | 0.47.2     | 0.47.2     |
| code-push     | /usr/local/bin/code-push     | 2.0.1-beta | 2.0.1-beta |
| npm           | /usr/local/bin/npm           | 5.5.1      | 5.5.1      |
| xcodebuild    | /usr/bin/xcodebuild          | 9.1        | 9.1        |
| yarn          | /usr/local/bin/yarn          | 1.1.0      | 1.1.0      |

### Environment Variable

| Environment Var | Value                                |
| --------------- | ------------------------------------ |
| $ANDROID_HOME   | /usr/local/Cellar/android-sdk/24.4.1 |

### Filesystem

| Location       | Type | Exists |
| -------------- | ---- | ------ |
| ./package.json | File | ✔ YES |
| ./ios          | Dir  | ✔ YES |
| ./android      | Dir  | ✔ YES |

-----------------------------------------------------------------------------------

Which when pasted in github looks like so:
⚠ Environment Report:

System

System Basics
Value

OS
macOS High Sierra 10.13.1

CPU
x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz

Report Info
11/27/2017, 12:33:30 AM (in 0.41s)

Commands

Binary
Location
Version
Desired

watchman
/usr/local/bin/watchman
4.7.0
ANY

node
/usr/local/bin/node
8.6.0
8.6.0

applesimutils
/usr/local/bin/applesimutils
0.5.12
ANY

xcrun
/usr/bin/xcrun
35
35

detox
/usr/local/bin/detox
UNKNOWN
ANY

emulator
/usr/local/bin/emulator
UNKNOWN
ANY

react-native
/usr/local/bin/react-native
0.47.2
0.47.2

code-push
/usr/local/bin/code-push
2.0.1-beta
2.0.1-beta

npm
/usr/local/bin/npm
5.5.1
5.5.1

xcodebuild
/usr/bin/xcodebuild
9.1
9.1

yarn
/usr/local/bin/yarn
1.1.0
1.1.0

Environment Variable

Environment Var
Value

$ANDROID_HOME
/usr/local/Cellar/android-sdk/24.4.1

Filesystem

Location
Type
Exists

./package.json
File
✔ YES

./ios
Dir
✔ YES

./android
Dir
✔ YES

Special thanks to envInfo.   All I have left is finishing up tests.


Sleep Mode

Hi,
we recently got our aircon and when integrating it with HA, I realized that the aurcon also supports a sleep mode. Sleep mode is different to quiet/eco mode as it‘s increasing the temperature over a set period of time (adjustable to some point) by a few degrees to adjust for the human body‘s temperature change during sleep.
Is it possible to integrate sleep mode in this integration?

Hi,
Depends on how it works, I haven't seen anything that resembles sleep mode in the feature list they provide... but Panasonic isn't always using logical names...
I need to know what your device reports as features, and what happens when you activate sleep mode in the app.

this is the interesting part though. the app itself doesn't offer a setting like that; it's only to be set in through the remote. it works in addition to the mode you have set.
is there any debug logging i can enable and then set the through the remote which might show some useful information if panasonic sends this preset to their backend?

@muhlba91 you could enable debug logging, that will log the raw api responses. But if it's only on the remote, it's probably some built in curve, you could probably create an automation in HA that does the same thing.

@muhlba91 unfortunately there are quite a few HVAC modes & options that are not controllable through the API, but exists via IR remotes or bluetooth. it's quite a shame that in 2024 "api first" is not yet the standard way of implementing things for Panasonic.


[Help wanted] Support Android

TODO

[x] Follow https://github.com/k2-fsa/sherpa-ncnn/tree/master/android/SherpaNcnn to support Android

Closing via #59


As proposed here https://github.com/PanDAWMS/pilot/pull/127#issuecomment-294744079

Why are you hardcoding file names in SiteInformation.py? Cheers, Paul

I can't understand the question. I don't use any filenames.

p = "--maxEvents=2 --inputHITSFile HITS.06828093._000096.pool.root.1 --outputRDOFile RDO_20c37551-abfd-4ce1-b0ae-09a0a5b72484.root --useTestASetup --useTestXRootD"

This is test code. It is in the section name == "main", so it is not invoked if it's pilot.
The next time, please use inline comments feature in Github to comment or reference the code directly.

OK thanks. I will test it.

2017-04-26 15:15:18| 31513|RunJob.py   | !!FAILED!!3001!! Exception caught in RunJob: get() takes at most 3 arguments (4 given), Traceback (most recent call last):
File "RunJob.py", line 1728, in
ec, runCommandList, job, multi_trf = runJob.setup(job, jobSite, thisExperiment)
File "RunJob.py", line 600, in setup
ec, job.pilotErrorDiag, cmd, job.spsetup, job.JEM, job.cmtconfig = thisExperiment.getJobExecutionCommand(job, jobSite, self.__pilot_initdir)
File "/scratch/Panda_Pilot_29105_1493219705/PandaJob_3350317981_1493219714/ATLASExperiment.py", line 371, in getJobExecutionCommand
x=si.getLocalROOTSetup()
File "/scratch/Panda_Pilot_29105_1493219705/PandaJob_3350317981_1493219714/ATLASSiteInformation.py", line 759, in getLocalROOTSetup
if os.environ.get("TestXRootD", 'True', 'False') == 'True' or hasattr(self, 'xrootd_test') and self.xrootd_test:
TypeError: get() takes at most 3 arguments (4 given)
Please fix.


subquery or nested_query support

Hi!
I need to use subquery or nested_query.
Like Query Data Source in druid docs http://druid.io/docs/latest/DataSource.html
Is it possible?
Thank you!

Hi @kisakov, could you kindly move this issue to the new ruby-druid/ruby-druid repository? Thank you!


feat: add setnickname, addrole and removerole commands

Draft because why in gods name can a non-admin/moderator use the commands despite the commands having having permissionLevel: PermissionLevels.Administrator/Moderator.
Taken from addrole:
@ApplyOptions<SkyraCommandOptions>({
    cooldown: 10,
    description: language => language.tget('COMMAND_ADDROLE_DESCRIPTION'),
    extendedHelp: language => language.tget('COMMAND_ADDROLE_EXTENDED'),
    requiredGuildPermissions: ['MANAGE_ROLES'],
    permissionLevel: PermissionLevels.Administrator,
    usage: '<user:username> <role:rolename> [reason:...string]',
    usageDelim: ' '
})

Barring duration all requests are fixed so I'm de-drafting this. If you want duration we're going to have to look together because I cannot figure out for the life of me how to extend ModerationCommand.


Code action to remove unused declaration removes license comment

TypeScript Version:  2.7.0-dev.20171226
Code
/**
 * @license
 * Suppose this was the text of a copyright license.
 */

import {basename} from 'path';

Running with noUnusuedLocals gives a warning about basename. Typescript also provides a Code Action to remove the declaration for basename.
Expected behavior:
Applying the code action to remove the declaration only removes the import statement, it does not remove the license comment.
Actual behavior:
The import statement and the license comment are removed.

Two potential solutions:

An empty line between the comment and the statement could be taken as an indication that the comment isn't attached to the statement, and so removing the statement would not remove the comment.

A comment that contains the text @license could be taken as an indication that the comment should not be automatically deleted.

Related: https://github.com/Microsoft/TypeScript/issues/13411

A comment that contains the text @license could be taken as an indication that the comment should not be automatically deleted.

We already generally consider a comment that starts the file and begins with /*! as "pinned" and should not be moved or deleted. We usually advise using this for licenses.

This works now


chore: event persister for A/B tests

I think evaluation_event.proto and goal_event.proto should be in proto/eventpersister_dwh directory.

@cre8ivejp @masaaania
Thank you! I've updated.

@cre8ivejp Could you review this PR again? Thank you.

@cre8ivejp
Done. Thank you!


FAQ for drift-correction

Re-opening https://github.com/fluxcd/flux2/pull/1297

/label documentation
This looks like it has a merge conflict, please rebase

Thanks again for the work you put into this PR. It needs some more work to be in a state to be merged. I'm closing it as it has been without updates for a while. If you wish to reopen it once the requests have been addressed, please go ahead - we are happy to take another look at it!


Node Click Event Causing Interruptions in drag drop and other functions.

Problem: iAm showing a modal on click upon a node. (i think 'nodeClick' event gets triggered on mouseDown) So now i am not able to move nodes. Because modal(dialog) gets appear on window immedieately after node click start.
Expected: there should be a nodeSelection event, which should gets triggered on mouseUp event when user not dragged node.

same here.

Yes please.

Yes please.

@888x  did you found any solution on this?


claim_search Plugin API

In order to improve the content discovery and search capabilities of the LBRY network the SDK needs a way to use 3rd party search services.
Version 1 of the proposed API will be JSON RPC to aid in development and debugging, once the design has proven itself in practice and the data structures exchanged have solidified we may consider switching to a binary protocol such as protobufs.
SDK will require two end points exposed by a search service in order to be compatible; they are described below:
search_features
This end point will only be called once on SDK startup to find out the features offered by the search service. Expected response string values with brackets are meant to be filled in:
Request: Plain GET with no arguments.
Response:
{
  "id": "[short name: 'lighthouse']",
  "version": "[version: '1.0']",
  "name": "[friendly label: 'LBRY Lighthouse Search']",
  "configuration": {  # any configs affecting search results users should know about
    "[config field]": "[config value]",
  },
  "filter": {  # the filter arguments which can be passed to the search end point
    "[field name]": {
      "type": "[field data type: string, integer, date, etc]",
      "constraints": ["comparison", "fts", "range", "etc"],
  },
  "order_by": {  # the order_by arguments which can be passed to the search end point
      "type": "[field data type: string, integer, etc]"
  },
  "metadata": {  # extra metadata returned by search results for every single claim
      "type": "[field data type: string, integer, etc]",
  }
}

id: SDK will use the {id}-{version}-{hash(configuration)} to uniquely identify a search service internally.
name: potentially could be displayed in a UI where user can pick from several search services
configuration: SDK does not expect any structure for this, it's mostly informational and will be passed to clients as-is, it may be used for A/B testing or other metrics
filter: SDK will enforce that client doing searches only use these filters, constraints may be left off and defaults to just exact equality comparison, comparison means that values will be in the format of ">332", "=<32", etc and fts would mean that this field can support advanced full text search operations, etc. range takes comma delimited values for high, low values "39,22"
order_by: SDK will enforce that for client requests
metadata: additional metadata search service provides ontop of what the SDK includes in the standard search responses already (for example, this may be some full-text-search metrics or content trending information, etc), it will simply be passed to clients as-is

search
This end point performs the actual search. It accepts a request with filters, order_by and pagination parameters (limit and offset) and responds with claims_ids and any extra metadata.
Request:
{
  "filter": {
    "[field name]": "[value]",
  },
  "order_by": [["[field1]", "desc"], ["[field2]", "asc"]],
  "offset": 0,
  "limit": 20
}

Response:
[  # claim_id is the only required value to be in the result
  {"claim_id": "[claim_id]", "[metadata field 1]": "[metadata value 1]", ...}
]

Work Flow

On startup SDK will call search_features and cache the result for the duration of the running process.
As clients connect to the SDK, the SDK will respond with the available search services and their features and configs as was reported by search_features.
As SDK receives claim_search requests from clients it will validate that the filter fields and order_by fields are accepted by the search service.
SDK forwards a clients search request to the search service passing appropriate limit/offset.
For each claim returned by search service the SDK will check the claim against the block/filter lists and if any of the claims are blocked it will increase the offset value and send another search request, it will continue to request search and verify result against block/filter lists until either search service no longer returns claims or until the page_size requested by client has been filled up.
As part of verifying results against block/filter lists and preparing the response SDK will look up each claim_id in it's own local database to get the latest txid:nout for the claim and all other metadata needed to return a consistent response regardless of which search service was used.

Looks roughly good to me. Some comments/thoughts:

It is metadata intended only for extra data? For example, a search score or something like this? I think this is meant this way, but confirming. It may make sense to label this xxx_metadata rather than just metadata since unlabeled metadata is basically assumed to be claim metadata.
Can methods be called just claim_search and claim_search_features rather than new top-level naming?

I updated the write up with explanation of the feature fields. But here is further explanation: metadata is specific to the search service, for example, if we move trending out of the SDK and into a search service then the search service may want to provide some extra information about the trending of a particular claim, or if full text search was used there may be some relevancy decimal for each of the result rows, etc. The SDK will simply just pass this down to the client, so search service can put whatever it wants in there. This field is totally optional and the search service may opt to have no extra metadata (therefore its results will just be claim_ids).
The APIs and even protocol is completely different. Currently the SDK wallet servers expose claim_search as a binary protobuf protocol which returns txid:nouts (there aren't even claim_ids in that response). I think it's already confusing as it is with SDK having two completely different incompatible claim_search APIs (one local used by app and one on wallet server used by client SDK), I'm not sure having a 3rd API end point named the same will help things. But having said that I don't feel too strongly about the name, if there is broader consensus to name the RPC function in lighthouse claim_search and claim_search_features i'd be happy to update this issue.


make ”private” the default

One less keyword to have to deal with. It’s more like go

@PaperPrototype
It's more like go but also more fragmented, at least if we allow both implicit private and explicit private.
I can see how you have public and package modifiers (without private) and everything else is private. This is only very similar to go in the sense that there is only one way to express private.
However, wouldn't it be clearer and easier to understand if every symbol had a visibility modifier without any implicit assumptions?

@avivcarmis

However, wouldn't it be clearer and easier to understand if every symbol had a visibility modifier without any implicit assumptions?

No, I really believe that it would be very easy to understand, everything is private by default. It's a simple rule as long as there are not exceptions (which there shouldn't be). I wish more languages did that tbh. Like C# has private by default, but then also has private?! I'm like what the hell..
Also, an idea is to make things immutable by default like rust, and introduce a mut keyword... haha, but thats for another issue

Let's do it. Omit private keyword, make everything private by default. Will you be able to open a PR updating the visibility section in the spec here ? That's simply updating the readme file in this repo.

@PaperPrototype regarding const assignments, there's a open discussion here. Please weigh in so we could make a decision

GG


Clang libc6 version dependency

compiling libchromiumcontent from source is listed as a way to compile other projects on Debian Wheezy that use it. The issue is Debian 7 stable uses libc6 2.13, when projects like Atom.io package libchromiumcontent .so as a build dependency (:confounded:) which is compiled against libc6 2.14. So I clone this repo, and it now ALSO requires libc6 2.14:
../../third_party/llvm-build/Release+Asserts/bin/clang: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by ../../third_party/llvm-build/Release+Asserts/bin/clang)
../../third_party/llvm-build/Release+Asserts/bin/clang: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.15' not found (required by ../../third_party/llvm-build/Release+Asserts/bin/clang)
../../third_party/llvm-build/Release+Asserts/bin/clang: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by /home/nmartinssd/Projects/libchromiumcontent/vendor/chromium/src/third_party/llvm-build/Release+Asserts/bin/../lib/libstdc++.so.6)
ninja: build stopped: subcommand failed.

Is this intentional? it seems clang which is packaged with libchromiumcontent now also requires libc6 2.14 or  higher

Hey there,
It's been a long time coming but the libchromiumcontent repository is being archived as it is no longer used in the Electron build system (🎉 this is a good thing).
If your issue is still relevant to Electron in it's current build system (please verify first) then you should probably raise a similar issue on electron/electron.
Thanks 😄


Jira table template sometimes gets messed up

I really like the default table template however often times it does not scale well enough and one line is not shown correctly.
Expected:
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+
| Issue          | Summary                                                                                | Type         | Priority     | Status       | Age        | Reporter     | Assignee     |
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+
| foo            |                                                                                |              |              |              |            |              |<PHONE_NUMBER>10 |
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+

Actual:
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+
| Issue          | Summary                                                                                | Type         | Priority     | Status       | Age        | Reporter     | Assignee     |
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+
| foo            |                                                                                |              |              |              |            |              |<PHONE_NUMBER>1011
|
+----------------+------------------------------------------------------------------------------------------------------------------------------------------------+--------------+--------------+--------------+------------+--------------+--------------+

This happens on both my Linux as well as on my Mac machine. My hint is that the content of one of the column is too long and there's an off by one error.

Yeah, the table configuration is a bit brittle.  It is a bit tricky to wedge it in with the current templating output, but I think we could provide more helper functions template functions to make this better.  I will try to come up with something better.

While the template feature is nice, it would also be good with a simpler way to specify columns to include - eg. something like jira list --table=Key,Summary,Type,Status,MyField:.customfield_11050

I've got a PR to attempt to kind-of-fix this in #295. It doesn't address the issue where some values are much longer than a given column assumes, but it does make the column widths easier to tweak, and adjusts some of them to maybe-more-reasonable values. If anyone takes issue with the new values I picked, it will be easy to change since they're all specified at the top of the template instead of spread throughout.
It would be nice to be able to grow/shrink column widths according to the longest/shortest value for that column in a range, but that would have to be implemented as a template helper function, since the go template syntax scopes variables to the control structure they're declared inside of, and we'd have to iterate over range.issues to find the field widths. Maybe I can hack on that next.


Upgrading btrfs-progs requires changes in nixos-generate-config.pl & install-grub.pl btrfs logic

Issue description
Running nix-rebuild switch on a system with a btrfs root, would usually produce:
updating GRUB 2 menu...
activating the configuration...
setting up /etc...
setting up tmpfiles

I now get:
building Nix...
building the system configuration...
updating GRUB 2 menu...
Btrfs did not return a path for the subvolume at /
warning: error(s) occurred while switching to the new configuration

Steps to reproduce
If I revert  Ic0cef0425eff1db8ddc07e78ea5aa16eb4a9666b which updated btrfs-tools everything works as expected.
Technical details

System: (NixOS: 17.09.git.2e81962 (Hummingbird))
Nix version: nix-env (Nix) 1.11.8
Nixpkgs version: "17.09.git.2e81962a71"

Meh, I did run one of the btrfs install tests but not the simple one.... So the output of the tools has changed somewhat, btrfs subvolume show used to print:
machine# /mnt is toplevel subvolume

But now in the same case it prints:
machine# /mnt
machine# 	Name: 			<FS_TREE>
machine# 	UUID: 			-
machine# 	Parent UUID: 		-
machine# 	Received UUID: 		-
machine# 	Creation time: 		-
machine# 	Subvolume ID: 		5
machine# 	Generation: 		4
machine# 	Gen at creation: 	0
machine# 	Parent ID: 		0
machine# 	Top level ID: 		0
machine# 	Flags: 			-
machine# 	Snapshot(s):

... which confuses this logic in nixos-generate-config.pl:
399     # Is this a btrfs filesystem?
400     if ($fsType eq "btrfs") {
401         my ($status, @id_info) = runCommand("btrfs subvol show $rootDir$mountPoint");
402         if ($status != 0 || join("", @id_info) =~ /ERROR:/) {
403             die "Failed to retrieve subvolume info for $mountPoint\n";
404         }
405         my @ids = join("", @id_info) =~ m/Subvolume ID:[ \t\n]*([^ \t\n]*)/;
406         if ($#ids > 0) {
407             die "Btrfs subvol name for $mountPoint listed multiple times in mount\n"
408         } elsif ($#ids == 0) {
409             my ($status, @path_info) = runCommand("btrfs subvol list $rootDir$mountPoint");
410             if ($status != 0) {
411                 die "Failed to find $mountPoint subvolume id from btrfs\n";
412             }
413             my @paths = join("", @path_info) =~ m/ID $ids[0] [^\n]* path ([^\n]*)/;
414             if ($#paths > 0) {
415                 die "Btrfs returned multiple paths for a single subvolume id, mountpoint $mountPoint\n";
416             } elsif ($#paths != 0) {
417                 die "Btrfs did not return a path for the subvolume at $mountPoint\n";
418             }
419             push @extraOptions, "subvol=$paths[0]";
420         }
421     }

Reverting it but keeping this open so we can eventually update it.

Fixed by https://github.com/NixOS/nixpkgs/commit/801c920e95642ec663d4aa486c81e5443e25b182.


Does not work with Laravel 5.0.*

This L5 Modular does not work with Laravel Version 5.0.*

I've just checked v1.0.0 - works fine :)


Create a PR template

Create a PR template where person can clearly state the changes he/she made, need any change in documentation etc..

@96RadhikaJadhav,  I have created an issue as requested. You can work on this issue. You are requested to join the Discord server using this link for any doubts. Try to complete it within 3 days.

@Harshal0902 Can you please assign this issue to me?

@Harshal0902 Can you please create another issue to add code of conduct and assign that to me?

@96RadhikaJadhav,  sorry to inform you but Code of Conduct Issue is supposed to be done by another participant, as he is busy with another issue, he will do in after that.

@96RadhikaJadhav, sorry to inform you but Code of Conduct Issue is supposed to be done by another participant, as he is busy with another issue, he will do in after that.

Okay :(


chore: release 1.1.1

:robot: I have created a release *beep* *boop*
1.1.1 (2019-05-17)
Bug Fixes

use latest proto-loader with fixed types (#508) (1afee35)

Release is at https://github.com/googleapis/gax-nodejs/releases/tag/v1.1.1

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart: