Change response type to contain Either a ResponseError

This seems to be another hint at the fact that we should change this to something like Either a ResponseError but that would be a breaking change so I would at least do that in a separate PR whereas this is only breaking if you rely on the behavior on invalid json-rpc messages.

Originally posted by @cocreature in https://github.com/alanz/haskell-lsp/pull/189#issuecomment-541631689

Revisiting this, I think it is something we should do.
interface ResponseMessage extends Message {
	/**
	 * The request id.
	 */
	id: number | string | null;

	/**
	 * The result of a request. This member is REQUIRED on success.
	 * This member MUST NOT exist if there was an error invoking the method.
	 */
	result?: string | number | boolean | object | null;

	/**
	 * The error object in case a request fails.
	 */
	error?: ResponseError;
}

is pretty explicit that result and error are (a) mutually exclusive and (b) one of them should be present.
Well, the requirement for something on error is not as explicit, but is pretty strong. And we already have this behaviour encoded in out test generators.

I'd like to tackle this issue. I suppose the solution is to change ResponseMessage
from:
data ResponseMessage a =
  ResponseMessage
    { _jsonrpc :: Text
    , _id      :: LspIdRsp
    , _result  :: Maybe a
    , _error   :: Maybe ResponseError
    } deriving (Read,Show,Eq)

to:
data ResponseMessage a =
  ResponseMessage
    { _jsonrpc :: Text
    , _id      :: LspIdRsp
    , _result  :: Either ResponseError a
    } deriving (Read,Show,Eq)

combining _result and _error into single _result :: Either ResponseError a. Is this the desired solution?
However, I'm not sure I get

so I would at least do that in a separate PR whereas this is only breaking if you rely on the behavior on invalid json-rpc messages.

Could @cocreature please clarify?
I can also try to do PRs to dependent projects: ghcide, haskell-language-server (what else?) to accommodate this breaking change.

I think this is worth doing, as it clarifies the usage of the message.  The important thing is to ensure that well formed JSON is generated and consumed.
Erroneous JSON (either both or neither fields present) should generate a JSON error, and get dealt with as usual.

I can also try to do PRs to dependent projects: ghcide, haskell-language-server (what else?) to accommodate this breaking change.

I don't thing that is an absolute requirement.  This will go out with a major version bump anyway, and downstream projects tend to be tightly locked to a major version already.


add the BIOM file formats to skbio.io

Depends on:

[x] binary/text mode (#831)

Updating following our email conversation:

[ ] read(a_biom_file, into=biom.Table) should produce a biom.Table object
[ ] write(a_table, format='biom-format-1.0.0', into=a_ascii_file) should write a BIOM format v1.0.0 table (e.g., JSON)
[ ] write(a_table, format='biom-format-2.1.0', into=a_hdf5_file) should write a BIOM format v2.1.0 table (e.g., HDF5)
[ ] Table.read and Table.write should work as expected

cc @gregcaporaso @ebolyen

Include:

[ ] read(file, into=xray.Dataset)
[ ] write(xray.Dataset, format='biom-format-2.1.0')

@ebolyen and @wasade, I'm sure you guys may have discussed at length but I wanted to check. With xray.Datasets, how is metadata going to be handled?. All in all these seem like great additions!

@ElDeveloper We haven't actually discussed that in any detail. I think xray gives an attrs property for metadata on a dimension, but I'm not sure how we would choose to use that specifically.

Theres very little (ie none) on the metadata of an in memory biom table at
this point. That should probably be changed going forward as we don't find
out about metadata issues until write. So, ya, we haven't but should.
Another possibility are pandas tables per axis?
On Aug 7, 2015 12:30 PM, "Evan Bolyen"<EMAIL_ADDRESS>wrote:

@ElDeveloper https://github.com/ElDeveloper We haven't actually
discussed that in any detail. I think xray gives an attrs property for
metadata on a dimension, but I'm not sure how we would choose to use that
specifically.
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/scikit-bio/issues/828#issuecomment-128803549.

Long-term that might a good solution, but it would force a composite object. Which is probably desirable to avoid until we know more about how this structure behaves and have had a chance to interact with it in non-trivial ways.

biom-format v1.0.0 is ascii, while biom-format v2.1.0 is binary. create_format supports the encoding type, but I don't believe it supports both binary and ascii at the same time. One strategy would be to have two formats, but wasn't sure if that was the best way to proceed here.

@wasade We would need two formats anyhow as the sniffers should be independent. Then resolving the version is actually the same as figuring out what format it is in the first place. We don't have any real precedent for naming the format with a version, so anything sensible should work.
Also I'm not even sure how the registry could support both kinds of files for the same format, they are different objects entirely in Python.

I guess I'm not sure how to resolve the ambiguity of table.write(fh), is that biom-format-2.1.0, biom-format-1.0.0, or is dependent on the type of fh? Reading in I think is fine by just having multiple formats, but the writing is where I'm still unsure on as Table has two different ascii representations and a binary one.

I think I might be misunderstanding the problem.
Those formats would all be bound to the format name. So someone would say:
skbio.io.write(table, into=fh, format='biom-format-2.1.0') or whichever one they wanted.

Ah, okay. So it would raise if fh was incompatible with the requested format?

yes, the registry enforces the constraints you place on it. So it won't work if you give it an incompatible file source.


Error in a random place as a response to an unrelated type import

Steps to reproduce:

git clone git@github.com:rpominov/flow-bug.git
cd flow-bug
npm i
npm run flow — No errors!
go to app/router/buildUrl.js and uncomment the import.
npm run flow
error:

app/store/types.js:15
 15: export type Dispatch<A> = (<R>(a: Thunk<A, R>) => R) & ((a: A) => void)
                                       ^^^^^^^^^^^ function type. Callable signature not found in
  7: export type Action = CUAction | MSAction
                          ^^^^^^^^^^^^^^^^^^^ object type

Sorry for kinda complicated example, it's as far as I could reduce it from our big project. I'm guessing that some kind of circular dependency might be involved in import tree, but even in that case it results in a random error.

Seems to be fixed in<EMAIL_ADDRESS>(see https://github.com/rpominov/flow-bug/commit/95beed3a858cbf195121f2c27d3bda702bc3a804)


⚠ Bofrost.be has degraded performance

In 8e701d0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1506 ms

Resolved: Bofrost.be performance has improved in f46e008.


Question about disk hits and environment variables

Hey everyone. So we are gearing up for a trial run of Rez for our department at Imageworks. There has been a good amount of interest, and if all goes well we will have a strong case to make for other departments to adopt.
One concern that we have is the extra number of disk hits it will take when looking for plugins/scripts/libraries etc. Since every package installs itself into its own location, we face the possibility of having to search through many more directories than we currently do. We are being diligent with the number of packages we are creating, but it seems to me that over time the number of paths is only going to grow.
I'm curious if other studios have run into this problem, and if so, how they solved it. We have talked about having some sort of process that takes a resolved environment and centralises (or localises) all of its data into a single directory, although that seems fraught with problems... any insight would be much appreciated.
Thanks!

Hey Taisuke, you should read my post yesterday that talks specifically
about this exact problem ;) Will find and paste...
On Wed, Feb 1, 2017 at 7:16 AM, ttanimura<EMAIL_ADDRESS>wrote:

Hey everyone. So we are gearing up for a trial run of Rez for our
department at Imageworks. There has been a good amount of interest, and if
all goes well we will have a strong case to make for other departments to
adopt.
One concern that we have is the extra number of disk hits it will take
when looking for plugins/scripts/libraries etc. Since every package
installs itself into its own location, we face the possibility of having to
search through many more directories than we currently do. We are being
diligent with the number of packages we are creating, but it seems to me
that over time the number of paths is only going to grow.
I'm curious if other studios have run into this problem, and if so, how
they solved it. We have talked about having some sort of process that takes
a resolved environment and centralises (or localises) all of its data into
a single directory, although that seems fraught with problems... any
insight would be much appreciated.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/380, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjqSjj4Cb6DulDB8evwYpuAehwojPCaks5rX5angaJpZM4LzH3G
.

Hey all,
So, I've thought a lot about this. And I think there's a good way to solve
the problem, though suites isn't where to do it.
Rez contexts lack anywhere on disk where packages have the opportunity to
update the filesystem in a way that's specific to that context. In other
words, it'd be nice if a package could create (soft/hard) links somewhere
on the filesystem for a given resolve, rather than appending PYTHONPATH.
IMO this feature should be added. You should be able to configure a
location on your NFS where these 'context filesystems' go, and rez should
know when it can reuse them. If this is not configured, the context
filesystem would be created in /tmp (almost certainly in the same tmpdir
that rez already creates). If adding a context to a suite, you should be
able to tell rez to put the context filesystem within the suite.
It'd work something like this:
# in package.py
bind_fs = [
    {
        "source_path": "{root}/python"
        "dest_path": "python"
        "hardlink": True
    }
]

def commands():
    env.PYTHONPATH.append("{root}/python")

Here, the 'bind_fs' entry is telling rez that as part of this package's
actions, it needs to hardlink everything in the package under
{root}/python, into the 'python' directory in the context filesystem. The
following PYTHONPATH.append call actually knows to map the path its given
back to the new bound path. It will avoid appending identical paths. The
bind_fs call also tracks everything that happens, and uses this info to
create a hash, and it's this hash that decides where the context fs is
stored on disk.
So for example, let's say we have a maya_utils and nuke_utils package. This
is what happens:

the resolve is done
the commands are run. Two bind_fs entries are found - one for
maya_utils, one for nuke_utils.
a hash is generated, unique to the list of fs bindings that have
occurred (could just be a hash of a list of (path, is_soft_link) for
example).
the PYTHONPATH.append call in both cases become the same path - only one
append occurs.
Now we have the hash, we know the context filepath. It might be:
/rez/context_fs/ab295c32fa2486fdd126.
If that path doesn't exist, it is created, and the bindings are executed

this creates the relevant links for each package, in that dir. If the
path does exist, it's reused. So here, we end up with /rez/context_fs/
ab295c32fa2486fdd126/python/mas_utils and /rez/context_fs/
ab295c32fa2486fdd126/python/nuke_utils created.

The rez-env is started as per usual.

(2) is a little off, because initially I thought that bind_fs() calls
belonged in the commands. That actually complicates things, and it's better
off if the fs bindings are stored separately to the commands.

On Wed, Feb 1, 2017 at 7:28 AM, Allan Johns<EMAIL_ADDRESS>wrote:

Hey Taisuke, you should read my post yesterday that talks specifically
about this exact problem ;) Will find and paste...
On Wed, Feb 1, 2017 at 7:16 AM, ttanimura<EMAIL_ADDRESS>wrote:

Hey everyone. So we are gearing up for a trial run of Rez for our
department at Imageworks. There has been a good amount of interest, and if
all goes well we will have a strong case to make for other departments to
adopt.
One concern that we have is the extra number of disk hits it will take
when looking for plugins/scripts/libraries etc. Since every package
installs itself into its own location, we face the possibility of having to
search through many more directories than we currently do. We are being
diligent with the number of packages we are creating, but it seems to me
that over time the number of paths is only going to grow.
I'm curious if other studios have run into this problem, and if so, how
they solved it. We have talked about having some sort of process that takes
a resolved environment and centralises (or localises) all of its data into
a single directory, although that seems fraught with problems... any
insight would be much appreciated.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nerdvegas/rez/issues/380, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABjqSjj4Cb6DulDB8evwYpuAehwojPCaks5rX5angaJpZM4LzH3G
.

Yes! This is exactly what we are looking for. Sorry about not reading your earlier post, and thank you for re-posting :)


Option for prompt before auto-correct

The ktlint -F option to auto-correct is great, but can you please add the ability to confirm before auto-correcting an instance of an issue? Something like the attached image would be nice to see how your source file will be modified.

alternatively - would you be open to a PR adding this option?

@jbarr21 @hzsweers absolutely!
If you have the time to make a PR - that would be perfect (I can assure you that it will be merged in). If not, (sooner or later) I'll take care of it myself.

@shyiko Doing a little code triage. It looks like this issue can be closed since the PR has been merged.

that PR is separate, this issue still exists

Closing issue due to lack of progress.


Update create-a-phone-system-call-queue.md

Removing licensing information and placing references as it is now centralized in the planning article.  Updated information on external transfers for Overflow and Timeout.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@msmikedavis PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Android: calling .remove() before addMarker() has finished will cause app crash

Hi Masashi,
when I load the map (with many markers) and change the page (and remove the map with that change) before addMarker queue, the App will crash with this error:
W/art     (10479): Attempt to remove local handle scope entry from IRT, ignoring
D/AndroidRuntime(10479): Shutting down VM
E/AndroidRuntime(10479): FATAL EXCEPTION: main
E/AndroidRuntime(10479): Process: net.nachbarschaft, PID: 10479
E/AndroidRuntime(10479): java.lang.IllegalArgumentException: Released unknown imageData reference
E/AndroidRuntime(10479): 	at com.google.l.a.cd.a(Unknown Source)
E/AndroidRuntime(10479): 	at com.google.maps.api.android.lib6.c.db.c(Unknown Source)
E/AndroidRuntime(10479): 	at com.google.maps.api.android.lib6.c.aj.a(Unknown Source)
E/AndroidRuntime(10479): 	at com.google.android.gms.maps.model.internal.t.onTransact(SourceFile:204)
E/AndroidRuntime(10479): 	at android.os.Binder.transact(Binder.java:380)
E/AndroidRuntime(10479): 	at com.google.android.gms.maps.model.internal.zzl$zza$zza.zzn(Unknown Source)
E/AndroidRuntime(10479): 	at com.google.android.gms.maps.model.Marker.setIcon(Unknown Source)
E/AndroidRuntime(10479): 	at plugin.google.maps.PluginMarker$8.onPostExecute(PluginMarker.java:818)
E/AndroidRuntime(10479): 	at plugin.google.maps.AsyncLoadImage.onPostExecute(AsyncLoadImage.java:134)
E/AndroidRuntime(10479): 	at plugin.google.maps.AsyncLoadImage.onPostExecute(AsyncLoadImage.java:18)
E/AndroidRuntime(10479): 	at android.os.AsyncTask.finish(AsyncTask.java:632)
E/AndroidRuntime(10479): 	at android.os.AsyncTask.access$600(AsyncTask.java:177)
E/AndroidRuntime(10479): 	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645)
E/AndroidRuntime(10479): 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime(10479): 	at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime(10479): 	at android.app.ActivityThread.main(ActivityThread.java:5221)
E/AndroidRuntime(10479): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(10479): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime(10479): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
E/AndroidRuntime(10479): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

This is a big bug. I can't force the user to wait until all markers are loaded.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10702921-android-calling-remove-before-addmarker-has-finished-will-cause-app-crash?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

.remove() should stop every async task (ie. downloading markers) immediatly or we need to provide some .stop() methods

http://stackoverflow.com/questions/21523202/released-unknown-bitmap-reference-setting-marker-in-android
this is at the end something similar to my problem.

Here is a video for proof:
https://youtu.be/74R9ngJ4f7c

Not bug. Ofcource you shouldn't remove the marker before completing the addMarker().
Because the addMarker is asynchronize method.

It is a bug. I can't detect when the async adding is finished.

You need to add extra if/else statements inside of the code to prevent crash

No. AddMadker has a call back.
On Wed, Apr 8, 2015, 6:56 AM Hirbod<EMAIL_ADDRESS>wrote:

It is a bug. I can't detect when the async adding is finished.
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90924357
.

iphone does not crash...

It is not relared.
On Wed, Apr 8, 2015, 6:57 AM Masashi.K<EMAIL_ADDRESS>wrote:

No. AddMadker has a call back.
On Wed, Apr 8, 2015, 6:56 AM Hirbod<EMAIL_ADDRESS>wrote:

It is a bug. I can't detect when the async adding is finished.
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90924357
.

You don't use callback at all????
map.addMarker({
  options
}, function() {
   // Adding is completed.
});

On Wed, Apr 8, 2015, 6:59 AM Masashi.K<EMAIL_ADDRESS>wrote:

It is not relared.
On Wed, Apr 8, 2015, 6:57 AM Masashi.K<EMAIL_ADDRESS>wrote:

No. AddMadker has a call back.
On Wed, Apr 8, 2015, 6:56 AM Hirbod<EMAIL_ADDRESS>wrote:

It is a bug. I can't detect when the async adding is finished.
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90924357
.

I use the callback, but it is not related to that. It is the AsyncTask which try to add something to the map which doesn't exist anymore. I will check the callback now..

Google Maps Android API v2 and Google Maps SDK for iOS are completely
different software.
Thus different behaviors are correct.
On Wed, Apr 8, 2015, 7:02 AM Masashi.K<EMAIL_ADDRESS>wrote:

You don't use callback at all????
map.addMarker({
  options
}, function() {
   // Adding is completed.
});

On Wed, Apr 8, 2015, 6:59 AM Masashi.K<EMAIL_ADDRESS>wrote:

It is not relared.
On Wed, Apr 8, 2015, 6:57 AM Masashi.K<EMAIL_ADDRESS>wrote:

No. AddMadker has a call back.
On Wed, Apr 8, 2015, 6:56 AM Hirbod<EMAIL_ADDRESS>wrote:

It is a bug. I can't detect when the async adding is finished.
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90924357
.

I've checked, I don't use the callback. And again, I know that this is different, but It should not crash when you check the marker reference.

                $rootScope.map.addMarker({

                    position: latLng,
                    uid: obj["uid"],
                    firstname: obj["firstname"],
                    picture: obj["picture"],
                    isFavorite: obj["isFavorite"],
                    isMe: obj["isMe"],
                    picture_profile: obj["picture_profile"],
                    icon: {
                        url: obj['icon'],
                        //url: $rootScope.nncache.toInternalURL(obj['icon']),
                        size: {
                            width: 30,
                            height: 36
                        }
                    },
                    markerClick: $scope.onMarkerClick

                });

No. The plugin already provides callback that is only way to work all
statements safely.
On Wed, Apr 8, 2015, 7:19 AM Hirbod<EMAIL_ADDRESS>wrote:

            $rootScope.map.addMarker({

                position: latLng,
                uid: obj["uid"],
                firstname: obj["firstname"],
                picture: obj["picture"],
                isFavorite: obj["isFavorite"],
                isMe: obj["isMe"],
                picture_profile: obj["picture_profile"],
                icon: {
                    url: obj['icon'],
                    //url: $rootScope.nncache.toInternalURL(obj['icon']),
                    size: {
                        width: 30,
                        height: 36
                    }
                },
                markerClick: $scope.onMarkerClick

            });

—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90930538
.

Discussion is very difficult with you today. I don't use the callback. Tell me how to prevent crashing and I will go your way.

What I say is logic.
I don't have a overall progress and I can't determine when the AsyncTask inside of Java is over.
And when I remove the map, the AsyncTask still runs and try to add a marker to the map which does not exist anymore. It is impossible to prevent this on JS side, the only way is to make the AsyncTask more safe
if marker then add else do nothing

This plugin does not consider the develper remove the map during
map.addMarker()
In order to implement your order, I need to write buch of if statements.
On Wed, Apr 8, 2015, 7:30 AM Hirbod<EMAIL_ADDRESS>wrote:

What I say is logic.
I don't have a overall progress and I can't determine when the AsyncTask
inside of Java is over.
And when I remove the map, the AsyncTask still runs and try to add a
marker to the map which does not exist anymore. It is impossible to prevent
this on JS side, the only way is to make the AsyncTask more safe
if marker then add else do nothing
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90933245
.

Yeah, but this should be done this way from the beginning. You can never assume that something is "there" for sure.

Or I need a cancel() method for the async task to trigger from JS-Side. This should be the easiest way if you could provide something

Or much simpler: .remove() should kill all async tasks before removing markers and map.

(I back from breakfast)
That might be better idea.
On Wed, Apr 8, 2015, 8:05 AM Hirbod<EMAIL_ADDRESS>wrote:

Or much simpler: .remove() should kill all async tasks before removing
markers and map.
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90943811
.

But sadly I do not have enough know how with java and the architecture to send a pr :(

ok
On Wed, Apr 8, 2015, 8:08 AM Hirbod<EMAIL_ADDRESS>wrote:

But sadly I do not have enough know how with java and the architecture to
send a pr :(
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90945111
.

If you could fix this soon, I will push another small donation to you :)

Since you are getting into this plugin deeply, I  recommend you start to
learn Android java programming any time now.
That helps you to understand how work this plugin.
On Wed, Apr 8, 2015, 8:10 AM Hirbod<EMAIL_ADDRESS>wrote:

If you could fix this soon, I will push another small donation to you :)
—
Reply to this email directly or view it on GitHub
https://github.com/wf9a5m75/phonegap-googlemaps-plugin/issues/482#issuecomment-90945792
.

I guess I'll never develop for android again :D
I'll stick on Obj-C and web-development. I'm an experienced PHP developer.

That's very disappointed answer for me :(

I'm just kidding. I will, but as you may also know... time is the problem.

Yes, large time will be required to learn Android programming, but I hope you understand the Android part of this plugin little by little.
Even me, I haven't experienced Objective-C programming for real before starting this plugin, but now I'm better (I don't believe I'm an expert of Objective-C though).

This bug also happen without crosswalk

As I said, this plugin does not consider to reload the page, because nobody like that.

This has nothing to do with reload. It has to do with .remove()

Reload (which will also just do a .remove() onBeforeUnload)
https://youtu.be/74R9ngJ4f7c
Only .remove()
https://youtu.be/ETpYfZIekYQ
I do need to remove the map when I change the page. Otherwise the performance is bad. I can't just hide an reattch, I've tried that, the performance is very sluggish in that case.

I'm terribly busy.

I talked with some people, everybody agreed with me, that using references without a bulletproof check isn't the "good" way, even when it is a special case. Nonetheless, I can't wait, as this is a production ready app. I've changed my code and refactored everything and I don't rely on .remove() anymore, instead, I reattach my map to the new div.
This will increase memory and will release less memory then before but also has some benefits, as the map will reload super fast right now. So, I'll leave this open, maybe you decide to change the code, when not, I'm fine with it, as I'm the only one who complains

Nobody remove the map such as you tested.
You shouldn't remove the map until the markers are loading.
Decreasing the memory, use map.clear() and map.setDiv(null)
This plugin is not product level software. It's just free software.
Developing of this plugin is not my occupation, it's my hobby.
Increasing issue reports that using the way I'm not designed for are really increased my stress.
So I have been considering to discontinue this plugin recently.
If you want to use perfect software, please use alternatives:
such as Google Maps JavaScript API v3, or mapbox.js
They develops their software for enterprise with many developers.
This plugin's developer is just one person, and my private time is very limited.
I stopped receiving the e-mails from github from last night.
It means I will reply the issues but very slow.
However this certainly decrease my stress.

You should really consider to read and understand first, before you write something. As I told you, I fixed it and it is fine now. Nobody support this project more then me (after you), I don't know why you're so harsh the last weeks, as I try to help were I can.

And I also try to help making this "hobby project" perfect. No need to be stressed.

As a follow up to this, my Open Charge Map app has just been updated with the latest version of this plugin and crashes on some devices. I'm setting the icon as a markerOption, rather than using marker.setIcon. This suggests that we're setting the icon elsewhere when the marker is not ready or has been cleared (my app is clearing markers regularly, so could be related).
The app got a 1-star review from a grumpy user because of this, so I've patched my version to catch the exception if it occurs ( in PluginMarker.java onPostExecute) - will see if that stops the reported crashes.

In my case this was caused by me using map.clear(); to clear all markers on a map. What solved it for me was to iterate through the markers and remove them individually , one by one, instead of the catch-all clear.
This solution was what I used : http://stackoverflow.com/a/21887173

The crash should not happen in the new version anymore, as I've wrapped a try/catch block around it


fix #45: Code block comments treated as headings

This PR fixes #45. It ignores # in code blocks.

Nice Job!

Thanks a lot @betrue12, it works. 👍


Ruby rejects tap{|;_1|} but YARP accepts it

Similar to #1546, same for ->(;_1){}
irb(main):001> eval 'tap{|;_1|}'
(irb):1:in `eval': (eval):1: _1 is reserved for numbered parameter (SyntaxError)
	from (irb):1:in `<main>'
	from bin/console:8:in `<main>'
irb(main):002> YARP.parse 'tap{|;_1|}'
=>
#<YARP::ParseResult:0x00000001047fa0a8
 @comments=[],
 @errors=[],
 @source=#<YARP::Source:0x0000000104678838 @offsets=[0], @source="tap{|;_1|}">,
 @value=
  @ ProgramNode (location: (1,0)-(1,10))
  ├── locals: []
  └── statements:
      @ StatementsNode (location: (1,0)-(1,10))
      └── body: (length: 1)
          └── @ CallNode (location: (1,0)-(1,10))
              ├── receiver: ∅
              ├── call_operator_loc: ∅
              ├── message_loc: (1,0)-(1,3) = "tap"
              ├── opening_loc: ∅
              ├── arguments: ∅
              ├── closing_loc: ∅
              ├── block:
              │   @ BlockNode (location: (1,3)-(1,10))
              │   ├── locals: [:_1]
              │   ├── parameters:
              │   │   @ BlockParametersNode (location: (1,4)-(1,9))
              │   │   ├── parameters: ∅
              │   │   ├── locals: (length: 1)
              │   │   │   └── @ BlockLocalVariableNode (location: (1,6)-(1,8))
              │   │   │       └── name: :_1
              │   │   ├── opening_loc: (1,4)-(1,5) = "|"
              │   │   └── closing_loc: (1,8)-(1,9) = "|"
              │   ├── body: ∅
              │   ├── opening_loc: (1,3)-(1,4) = "{"
              │   └── closing_loc: (1,9)-(1,10) = "}"
              ├── flags: ∅
              └── name: "tap",
 @warnings=[]>

YARP also accepts these
tap{|a;a,_1,a!,a?|}
->(a;a,_1,a!,a?){}

Looks like it's fixed in #1588 and #1628


[UI] Ability to select between the 2 LB options for AKS

related to https://github.com/rancher/rancher/issues/23715

close in favor of: https://github.com/rancher/rancher/issues/29908


Intellisense for configs

Now that JS configs are implemented (#124) and we have type checking (#117 #118) we can add intellisense to the config files.
There are two popular ways to do this that I'm aware of:

a function that just returns the first argument (which is typed)

import { defineConfig } from '@bluecadet/launchpad';

export default defineConfig({
   // ...
})

using jsdoc @type annotation

/** @type {import('@bluecadet/launchpad').LaunchpadConfig} */
export default {
   // ...
}

It should be pretty easy to support both, but I'm particularly fond of the first one, as that enables us to more easily accept a callback for the config argument and pass context later down the line if we want:
import { defineConfig } from '@bluecadet/launchpad';

export default defineConfig((ctx) => ({
   // ...
   property: ctx.env.EXAMPLE_ENV_VARIABLE
   // ...
}))

Agreed! First option seems preferable and I like the option for a callback.
Is the naming and pattern of defineConfig() something you've seen in the past? My head is still stuck in OOP land and I imagined exporting an instance of a Config object, that could or could not be extended. But my understanding from your other PR is that this would support autocompletion because the return type of defineConfig would be Config, right? So that would eliminate the need to explicitly call new Config({...})?

Yeah, defineConfig() is used by sanity, vite, astro. I've also seen the latter pattern (@type import(...)) used by tailwind, sveltekit, nextjs.
The defineConfig function would look something like this in js/jsdoc
/**
 * @param {Config} config
 * @returns {Config}
 */
function defineConfig(config) {
	return config;
}

Because the parameter has a defined type, users would see intellisense hints and autocomplete when populating that parameter, similar to how they would get hints when populating new Config([param]) only if the Config class constructor parameter is typed.
We could definitely use a Config class as the default export, but that does have the small downside of duplication in documentation that was mentioned in #118:
class Config {
  /**
   * @type {string} this type can only be seen when accessing the property on a Config instance
   */
  foo;

  /**
   * @param {object} options
   * @param {string} options.foo this type can only be seen when constructing a new Config instance with `new Config({ foo: 'bar' })`
   */
  constructor({
    foo
  }) {
    this.foo = foo;
  }
}

// vs

/**
 * @typedef Config
 * @property {string} foo this type and description can be seen when constructing and when accessing an object with type `Config`
 */

Thanks for the breakdown!
I like the simplicity of defineConfig(), and that there's no additional type descriptions needed.
What I like about the import method is that it feels a bit more freeform and makes the syntax of the file itself just a tad more legible and straightforward.
But you make a really good point about documentation, so let's go with the defineConfig() approach! 💯


Gate Bors on Clippy

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

bors r-

:confused:
bors merge


Skip TensorFlow dependent tests if Tensorflow is not installed

Skip TensorFlow dependent tests
fixes #106

I'm doing some similar work on featuretools right now
EvalML did some work like this previously: https://github.com/alteryx/evalml/issues/2922
I think there should be a way to run the unit tests without tensorflow installed, but the tensorflow tests should run (and fail) if tensorflow is not installed

Fixes #107


I2C not working anymore

After last changes in I2C, it seems the logic of the busy_wait macro is not correct.
I've been able to patch it locally and will push a clean proposal tomorrow (@thejpster asked me to file an issue).
Basically, checking for BusBusy everywhere is not correct as it will always be set between START and STOP, so during a transaction, we should not return an error (that's what I'm currently seeing).
Previous code was basically adapted from stm32f30x-hal and I see that the busy_wait macro has been changed (no more flag as parameter) and is not really busy_waiting on anything but the BUSY bit. The macro is now wrapped in loop{}. Was is not better to have the busy wait inside the macro ? Maybe there's something I'm not seeing here.
The original code was doing things like:

wait for busbsy to be clear
do something
wait for busy to be clear
do something
....

I see that previous code was wrongly looking at all mcs bits without waiting for busy to be clear, but maybe the cleaning went too far ? At least with my patch that reverts back the logic above, my application is working correctly again.

@dtwood any thoughts on this one?

@dtwood?


Generates sourcemap by default spec failing

:wrench: change test to reconcile dependency bump of<EMAIL_ADDRESS>References #81
<EMAIL_ADDRESS>Regression failure reference
https://github.com/mozilla/source-map/pull/236
In particular the following diff:
https://github.com/mozilla/source-map/pull/236/files#diff-72d90d7b160cfdc50eee99b2a33c871cL320
https://bugzilla.mozilla.org/show_bug.cgi?id=889492

thank you @snuggs! sorry for the long delay


[CI] - Systemd Notify + Quarkus 3

This issue will be opened and closed depending on the state of https://github.com/quarkiverse/quarkus-systemd-notify build against Quarkus 3.
If you are interested in being notified, please subscribe to this issue.

Closing as main is already Quarkus 3


manager: errors triggered when getting status from replica in error mode

[longhorn-manager-sn5d7] time="2019-09-11T16:39:30Z" level=fatal msg="Error running restore backup command: failed to get restore status: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:10002: connect: connection refused""
[longhorn-manager-sn5d7] , error exit status 1
[longhorn-manager-sn5d7] time="2019-09-11T16:39:36Z" level=error msg="failed to get Backup Restore Status: Failed to execute: /var/lib/rancher/longhorn/engine-binaries/yasker-longhorn-engine-055000a/longhorn [--url <IP_ADDRESS>:10000 backup restore-status], output , stderr, time="2019-09-11T16:39:36Z" level=error msg="Failed restoring backup tcp://<IP_ADDRESS>:10000 on %!s(MISSING)"ntime="2019-09-11T16:39:36Z" level=fatal msg="Error running restore backup command: failed to get restore status: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial tcp <IP_ADDRESS>:10002: connect: connection refused\""n, error exit status 1"
[longhorn-manager-sn5d7] E0911 16:39:36.119366       1 engine_controller.go:572] fail to update status for engine test-e-24c052e7: Failed to execute: /var/lib/rancher/longhorn/engine-binaries/yasker-longhorn-engine-055000a/longhorn [--url <IP_ADDRESS>:10000 backup restore-status], output , stderr, time="2019-09-11T16:39:36Z" level=error msg="Failed restoring backup tcp://<IP_ADDRESS>:10000 on %!s(MISSING)"
[longhorn-manager-sn5d7] time="2019-09-11T16:39:36Z" level=fatal msg="Error running restore backup command: failed to get restore status: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:10002: connect: connection refused""
[longhorn-manager-sn5d7] , error exit status 1

Reproduce steps:

Create a volume, attach it.
Monitoring the manager log.
Delete one replica.

Engine controller will report above errors before the error replica is removed from the engine.

We should aggregate the engine status command if possible, and don't error out in this kind of situation.

Also need to get rid of following error message:
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-984kn] time="2019-09-16T23:10:42Z" level=info msg="Engine image ei-9d551fae for instance manager longhorn-system/instance-manager-r-dfa4b14f has been deleted"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[longhorn-manager-m9t7r] time="2019-09-16T23:10:42Z" level=warning msg="Cannot find matching replica by the address[tcp://<IP_ADDRESS>:10000] in engine purge/restore status for volume[t1]"
[

Validation: Passed


Update CustomDataLoaderOnSL.ipynb

issue #699

I have read the CLA Document and I hereby sign the CLA

hi,@Ming,
origin version(Chinese):

new version(English):

LGTM

Hi, @zoeStartover, Good for your English translation.  .please commit your po file and the screenshot of the Chinese version.

LGTM

You also need to add a PO file to provide the Chinese version.

You also need to add a PO file to provide the Chinese version.

Thank you for your review. I have already added the corresponding PO file and you can check in file changed. I am not sure you refers to that PO file.


[FLINK-7835][cep] Fix duplicate() in NFASerializer.

R @aljoscha

Merging this.

Can I directly use these changes in the release-1.3.2 tag or there in between dependencies?

I think you can but you will have to recompile flink.

While applying the patch it's giving a lot of conflicts. I think due to changes in between. So why I had doubts. I'll apply these changes manually.

Yes, I think manually is the safest bet.

Yeah, But I think 1.4 will take some more couple of weeks. As unable to restore the state, So it's necessary to change for me.

I think I have to wait for 1.4 cause there are a lot of changes in other files too between 1.3.2 release and this commit.

Sorry to hear that @shashank734 . But on the bright side, the RC0 for Flink 1.4 is out:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/PREVIEW-Release-1-4-0-release-candidate-0-td20237.html
So you can try it and also help us test it.

Great


Figure out authentication

Right now users can verify their identity with their client by signing a message, but there is no way to verify their identity with other users. For all you know, the person you are talking to could be lying about their identity.
Additionally the host server could lie about other user's identity, though not sure if this would be a separate issue involving e2e encryption or not.
I think one solution would be the user signing a message verifying they are playerId in world uri and send it to others, but that would be very annoying UX. So maybe we can automate this by letting the user sign a single message to verify their identity with their client, then the client can take over and use another set of public / private keys - which would be marked as verified in the signature - for authentication with other users, the host, and potentially for e2e encryption 🤔

ok progress on this, don't have the specifics yet but it can be handled by the user's home server

going to split this into smaller issues, I think I have it "figured out", just need to implement it for certain aspects of the protocol.


[SPARK-13665][SQL] Separate the concerns of HadoopFsRelation

HadoopFsRelation is used for reading most files into Spark SQL.  However today this class mixes the concerns of file management, schema reconciliation, scan building, bucketing, partitioning, and writing data.  As a result, many data sources are forced to reimplement the same functionality and the various layers have accumulated a fair bit of inefficiency.  This PR is a first cut at separating this into several components / interfaces that are each described below.  Additionally, all implementations inside of Spark (parquet, csv, json, text, orc, svmlib) have been ported to the new API FileFormat.  External libraries, such as spark-avro will also need to be ported to work with Spark 2.0.
HadoopFsRelation
A simple case class that acts as a container for all of the metadata required to read from a datasource.  All discovery, resolution and merging logic for schemas and partitions has been removed.  This an internal representation that no longer needs to be exposed to developers.
case class HadoopFsRelation(
    sqlContext: SQLContext,
    location: FileCatalog,
    partitionSchema: StructType,
    dataSchema: StructType,
    bucketSpec: Option[BucketSpec],
    fileFormat: FileFormat,
    options: Map[String, String]) extends BaseRelation

FileFormat
The primary interface that will be implemented by each different format including external libraries.  Implementors are responsible for reading a given format and converting it into InternalRow as well as writing out an InternalRow.  A format can optionally return a schema that is inferred from a set of files.
trait FileFormat {
  def inferSchema(
      sqlContext: SQLContext,
      options: Map[String, String],
      files: Seq[FileStatus]): Option[StructType]

  def prepareWrite(
      sqlContext: SQLContext,
      job: Job,
      options: Map[String, String],
      dataSchema: StructType): OutputWriterFactory

  def buildInternalScan(
      sqlContext: SQLContext,
      dataSchema: StructType,
      requiredColumns: Array[String],
      filters: Array[Filter],
      bucketSet: Option[BitSet],
      inputFiles: Array[FileStatus],
      broadcastedConf: Broadcast[SerializableConfiguration],
      options: Map[String, String]): RDD[InternalRow]
}

The current interface is based on what was required to get all the tests passing again, but still mixes a couple of concerns (i.e. bucketSet is passed down to the scan instead of being resolved by the planner).  Additionally, scans are still returning RDDs instead of iterators for single files.  In a future PR, bucketing should be removed from this interface and the scan should be isolated to a single file.
FileCatalog
This interface is used to list the files that make up a given relation, as well as handle directory based partitioning.
trait FileCatalog {
  def paths: Seq[Path]
  def partitionSpec(schema: Option[StructType]): PartitionSpec
  def allFiles(): Seq[FileStatus]
  def getStatus(path: Path): Array[FileStatus]
  def refresh(): Unit
}

Currently there are two implementations:

HDFSFileCatalog - based on code from the old HadoopFsRelation.  Infers partitioning by recursive listing and caches this data for performance
HiveFileCatalog - based on the above, but it uses the partition spec from the Hive Metastore.

ResolvedDataSource
Produces a logical plan given the following description of a Data Source (which can come from DataFrameReader or a metastore):

paths: Seq[String] = Nil
userSpecifiedSchema: Option[StructType] = None
partitionColumns: Array[String] = Array.empty
bucketSpec: Option[BucketSpec] = None
provider: String
options: Map[String, String]

This class is responsible for deciding which of the Data Source APIs a given provider is using (including the non-file based ones).  All reconciliation of partitions, buckets, schema from metastores or inference is done here.
DataSourceAnalysis / DataSourceStrategy
Responsible for analyzing and planning reading/writing of data using any of the Data Source APIs, including:

pruning the files from partitions that will be read based on filters.
appending partition columns*
applying additional filters when a data source can not evaluate them internally.
constructing an RDD that is bucketed correctly when required*
sanity checking schema match-up and other analysis when writing.

*In the future we should do that following:

Break out file handling into its own Strategy as its sufficiently complex / isolated.
Push the appending of partition columns down in to FileFormat to avoid an extra copy / unvectorization.
Use a custom RDD for scans instead of SQLNewNewHadoopRDD2

@rxin @nongli @cloud-fan @liancheng @yhuai

Test build #52439 has started for PR 11509 at commit ac54278.

Test build #52439 has finished for PR 11509 at commit ac54278.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52439/
Test FAILed.

@marmbrus InternalRow is not a public API, so we will have buildScan() to return an RDD of Row for external libraries?

@davies agree, we should have a default internalScan that delegates to external version while doing the Row => InternalRow.  We can then make that method private[spark] so that only we can override it.  I'd also really like to get rid of RDDs here so that we can manage broadcasting the conf, etc.  SPARK-13682 tracks finalizing this interface.

Test build #52493 has started for PR 11509 at commit 3b7e3a8.

Test build #52498 has started for PR 11509 at commit 4b53adb.

Test build #52493 has finished for PR 11509 at commit 3b7e3a8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52493/
Test FAILed.

Test build #52498 has finished for PR 11509 at commit 4b53adb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52498/
Test FAILed.

Did one pass on this, looks great!  All the comments are minor, it's fine to be addressed later.

Test build #52582 has started for PR 11509 at commit fd65bcb.

Test build #52590 has started for PR 11509 at commit 3e5c7b7.

Test build #52590 has finished for PR 11509 at commit 3e5c7b7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52590/
Test PASSed.

Going to merge this in master.
We should rename HiveFileCatalog to MetastoreFileCatalog.  cc @andrewor14

Test build #52582 has finished for PR 11509 at commit fd65bcb.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52582/
Test FAILed.

i believe the need to pass all files along (e.g. inputFiles: Array[FileStatus]) instead of just the input paths came from the need to cache it so that stuff looked snappy on s3 which has slow meta operations.
however it is not very realistic to pass along all files for real datasets, since it can easily be size 100k+ (and some people reported using millions of files on mailing list).
because of this inputFiles param we now need driver programs with 16G of heap or larger (before 1G was enough), and even then it doesn't always work on very large datasets. i would hate to see inputFiles make it into spark 2.0 api, instead of just inputPaths.

@koertkuipers improving the efficiency of working with large files was certainly a goal in this refactoring and this API is definitely not done yet.  That said, I'm not really sure that the correct thing to do is to avoid listing all of the files at the driver.  Every version of Spark SQL has done this listing AFAIK during split planning even before we added a caching layer.

if it did then it was not always in the apis i think? i remember the apis
having paths: Seq[String] instead of files: Seq[FileStatus]. by explicitly
requiring the user to list all files in the api you make it impossible not
to, even if it turns out it is not always necessary. for 1mm files thats no
joke.
i found it was relatively straightforward to revert back to paths:
Seq[String] once i ripped out the cache, modified partition discovery, and
disabled some kind of data size estimation. so i more or less assumed it
wasn't used anywhere else. but i might have missed split planning.
On Tue, Mar 8, 2016 at 1:26 PM, Michael Armbrust<EMAIL_ADDRESS>wrote:

@koertkuipers https://github.com/koertkuipers improving the efficiency
of working with large files was certainly a goal in this refactoring and
this API is definitely not done yet. That said, I'm not really sure that
the correct thing to do is to avoid listing all of the files at the driver.
Every version of Spark SQL has done this listing AFAIK during split
planning even before we added a caching layer.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/11509#issuecomment-193902037.


[Docs]: Embed Appsmith

Is there an existing issue for this?

[X] I have searched the existing issues

Documentation Link
https://docs.appsmith.com/advanced-concepts/embed-appsmith-into-existing-application
Discord/slack/intercom Link
No response
Describe the problem and improvement.
Rehaul the doc

Duplicate #2054


Release a newer version of lib

I am considering using this library in a new project at my company, and have made a generic wrapper over this library using the Req method of the library, which is committed in master but unavailable when installed using glide. I have already submitted the test cases for the same and raised a PR for it.

Why do I need to release a newer version of this library?


WIP: implement bazel build

fixed: #545

[x] Add bazel
[ ] Use bazel on Travis
[x] Use bazel to create docker image
[ ] Use bazel to push docker image

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

we had no follow-up with this issue, I am closing


VAC Errors Only In Deathmatch and Casual

Every time I play Deathmatch and Casual and have plenty of kills (usually 30-40), I get VAC Error then I revalidate file integrity and 1 file always gets corrupted. How and Why? How to fix? I'm fed up. -_-
Edit 1: Happens with and without Skin Changer.

FOV lower than 30 and don't use antiaim

FOV lower than 30 and don't use antiaim

Not using Anti-Aim and FOV is the default (unchanged).

Did you check your hard disk or ssd?
Sometimes it's an disk error which cause an VAC Kick.

FOV lower than 30 and don't use antiaim

Not using Anti-Aim and FOV is the default (unchanged).

I think Shiv3RPolak talking Aimbot Weapon FOV (which you definitely has not set to "default" 0, which == disabled) and not Visual FOV.
There is option "Max angle delta" which divide aimbot into steps of set radius per tick (put ~25 for avoiding VAC errors). Unfortunately, this option works only if Auto Shoot is enabled (and Auto Shoot works only if "Max angle delta" > 0).
So you have only two solutions:

Use aimbot FOV 255, Max angle delta 25-30 and Auto Shoot On (for any nearest enemy, but can delays up to (255/30) / (1/64) = 544ms before shoot as theoretical maximum for the most distant target)
Use aimbot FOV 25-30 and manually aim and shoot chosen target withing this radius (currently cheat don't draw FOV radius indication but FOV 30 is about half of viewscreen, so enough just seeing enemy somewhere in front of you)

The first variant is preferable for instant raging everyone on Casual / DM / GunGame, second one - for HvH in MM / Wingman when you prefer to shoot enemy cheater over random guy in side of you.
About files integrity and corrupted file - this is a common Steam bug and absolutely not related to cheats. You will get this error even if play few games without any cheats, exit the game without any errors and run "revalidate file integrity" again. You can freely ignore it. Next time getting VAC error just reboot your PC - this will reset VAC error without wasting time on checking 20GB of game files.

FOV lower than 30 and don't use antiaim

Not using Anti-Aim and FOV is the default (unchanged).

I think Shiv3RPolak talking Aimbot Weapon FOV (which you definitely has not set to "default" 0, which == disabled) and not Visual FOV.
There is option "Max angle delta" which divide aimbot into steps of set radius per tick (put ~25 for avoiding VAC errors). Unfortunately, this option works only if Auto Shoot is enabled (and Auto Shoot works only if "Max angle delta" > 0).
So you have only two solutions:

Use aimbot FOV 255, Max angle delta 25-30 and Auto Shoot On (for any nearest enemy, but can delays up to (255/30) / (1/64) = 544ms before shoot as theoretical maximum for the most distant target)
Use aimbot FOV 25-30 and manually aim and shoot chosen target withing this radius (currently cheat don't draw FOV radius indication but FOV 30 is about half of viewscreen, so enough just seeing enemy somewhere in front of you)

The first variant is preferable for instant raging everyone on Casual / DM / GunGame, second one - for HvH in MM / Wingman when you prefer to shoot enemy cheater over random guy in side of you.
About files integrity and corrupted file - this is a common Steam bug and absolutely not related to cheats. You will get this error even if play few games without any cheats, exit the game without any errors and run "revalidate file integrity" again. You can freely ignore it. Next time getting VAC error just reboot your PC - this will reset VAC error without wasting time on checking 20GB of game files.

Tried both of your solutions. Still getting Error. Should I try changing Injector? Which Injector do you use?

Use one of Daniels injectors would be fine. He have one which removes the PE Header which is quiet nice because it produces an executable instead of dll its very handy.

Use one of Daniels injectors would be fine. He have one which removes the PE Header which is quiet nice because it produces an executable instead of dll its very handy.

Lemme give it a chance and I will let you know.

Use one of Daniels injectors would be fine. He have one which removes the PE Header which is quiet nice because it produces an executable instead of dll its very handy.

I am still getting errors but way less than earlier. Earlier, every 2/3 Deathmatch or Casual used to give VAC error and now it's 1/5 Deathmatch or Casual.
Looks good though.


Language for Beacon press for Rebecca Harris

First pass on page 2: https://docs.google.com/document/d/12YvUWZ2xZceTFeqq64NRzXEu_QYR_Y7TwCjwYCI026M/edit#

dunzo!


Feature request: Json prettifier

It could be nice that you can chose to use json prettifier on the Response Body.
Some thing like:
https://chrome.google.com/webstore/detail/json-formatter/bcjindcccaagfpapjjmafapmmgkkhgoa?utm_source=chrome-app-launcher-info-dialog

I just checked I did indent the json result.
By prettier you mean syntax highlighter?

i mean syntax highlighter and ability to fold part if the json you are not interested in.

i mean syntax highlighter and ability to fold part if the json you are not interested in.

I can already see the ability to fold part of json (by clickling on opening braces). Syntax highlighter would be a good addition 👍 .

Rolled out on V. 0.1.115
Use preview button to show JSON viewer.


Populate funding rate inside offer in the maker

Hard-code "0.0" until UI creates means for choosing funding rate.
Partial fix for #244

bors r+


500 error on project after adding repository on version 1.0.0

When i trying go to project page, i have 500 error and in logs i have:
Started GET "/projects/grodzina" for <IP_ADDRESS> at 2015-03-19 13:22:54 +0100
Processing by ProjectsController#show as HTML
  Parameters: {"id"=>"grodzina"}
  Current user: wmp (id=38)
  Rendered plugins/redmine_contacts/app/views/projects/_contacts.html.erb (1.4ms)
  Rendered plugins/redmine_git_hosting/app/views/common/_git_urls.html.erb (13.2ms)
  Rendered plugins/redmine_git_hosting/app/views/projects/_git_urls.html.haml (38.7ms)
  Rendered projects/show.html.erb within layouts/base (51.1ms)
Completed 500 Internal Server Error in 157.2ms

ActionView::Template::Error (undefined method `[]' for nil:NilClass):
    1: <% repositories = Array.wrap(repository) unless repositories %>
    2: <% if repositories.map(&:available_urls).flatten.reject { |m| m.blank? }.any? %>
    3:   <% repositories.sort_by { |r| r.is_default ? 0 : 1 }.each do |repository| %>
    4:     <% # Skip repository without URLs %>
    5:     <% next if repository.available_urls.empty? %>
  lib/redmine/hook.rb:111:in `block in render_on'
  lib/redmine/hook.rb:61:in `block (2 levels) in call_hook'
  lib/redmine/hook.rb:61:in `each'
  lib/redmine/hook.rb:61:in `block in call_hook'
  lib/redmine/hook.rb:58:in `tap'
  lib/redmine/hook.rb:58:in `call_hook'
  lib/redmine/hook.rb:158:in `call_hook'
  app/views/projects/show.html.erb:63:in `_app_views_projects_show_html_erb___74486739514800919_38840900'
  app/controllers/projects_controller.rb:163:in `show'

Hi!
Can you try with 1.0.3 version?

One (or many) of your repositories seem to not have an associated entry in GitExtra table.
How  to fix :
redmine$ cd <redmine root dir>/plugins/redmine_git_hosting
redmine$ git checkout v1.0.x
redmine$ cd <redmine root dir>
redmine$ bundle exec rake redmine_git_hosting:migrations_tools:check_git_extras_presence

redmine@redmine2:~/redmine$ bundle exec rake --trace redmine_git_hosting:migrations_tools:check_git_extras_presence
Your Gemfile lists the gem redcarpet (~> 2.3.0) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of just one of them later.
Your Gemfile lists the gem vcard (~> 0.2.8) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of just one of them later.
rake aborted!
Don't know how to build task 'redmine_git_hosting:migrations_tools:check_git_extras_presence'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/task_manager.rb:62:in `[]'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:149:in `invoke_task'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:106:in `each'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:106:in `block in top_level'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:115:in `run_with_threads'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:100:in `top_level'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:78:in `block in run'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:176:in `standard_exception_handling'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/lib/rake/application.rb:75:in `run'
/home/redmine/.rvm/gems/ruby-2.1.1/gems/rake-10.4.2/bin/rake:33:in `<top (required)>'
/home/redmine/.rvm/gems/ruby-2.1.1/bin/rake:23:in `load'
/home/redmine/.rvm/gems/ruby-2.1.1/bin/rake:23:in `<main>'
/home/redmine/.rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15:in `eval'
/home/redmine/.rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15:in `<main>'
redmine@redmine2:~/redmine$


Remove code for deprecated fabric based remote runner

Fabric runner has been deprecated almost half a year ago now so it's only time to get rid of the unused code.
Totals:

1 direct dependency

-728 lines of code

Resolves #2160.

LGTM. Thanks for doing this.

Awesome.
+1


Specific gravity shows extreme high % ABV.

My configuration is iSpindel with Fermentrack (I am using it only to follow fermentation) and recently I noticed that graphs shows extreme ABV. Specific gravity seems to be ok as plato.
what could be the issue?

Fermentrack is designed to work with SG for gravity measurements not Plato so it not strange that you get high ABV values. Change the setting in the iSpindel to send SG instead of Plato and you would be fine. There is an update coming that will allow you to show Plato on the graphs instead of SG.

oh dear. Thank you for that.

hm... there is no setting i iSpindel to send SG.
iSpindel sends only angle.
where should I change it then ?

So where I have to change it.
I delted sensor, created it again and it's showing Plato ....

or do I have to change formula ?
I used https://github.com/universam1/iSpindel/blob/master/docs/Kalibrierung_en.xlsm

If there is no way to convert in ispindel you need to calibrate it to send SG

thank you for helping.
I found a way to add calibration points from my excell file into fermentrack and then performed claibration from fementrack itself.


Update note about RCTLinking to account for the addition of auto-linking in 0.60

Problem
The note telling people to "link RCTLinking to your project" is out of date due to the introduction of auto-linking in React Native 0.60.
The note is quite confusing for users who are simply directed to this article explaining how to link a now nonexistent .xcodeproj file to their main Xcode project.
Solution
Step 3 from the referenced article is still required as auto-linking will not add the header files for RCTLinkingManager (located in the LinkingIOS folder) into the header search paths. As such I have tweaked the wording of the note and updated the link to point to step 3.

Just curious, what does "Step 3" actually do?
I don't have RCTLinking in the header search paths and it seems to work fine. Do I still need to add it?


Can't access shared folder

Hi,
since upgrading to v0.17 today, i can't access to network path, i have this error when accessing a shared folder :
Value does not fall within expected range.

@duke7553

@boscorelly Hmm... could you please upload your log file? That way, we'll have the context this exception occurs in.

@yaichenbaum Actually, I can guess why this happened. Let me author a potential fix really quick.

debug_fulltrust.txt
debug.txt

i just tried with 0.17.4 to access the root of the shared folders, and app crashed
debug.txt
debug_fulltrust.txt

and problem is still present :

Hi,
glad to see you fixed part of the problem :)
Now, i can access \x.x.x.x but when i try to access \x.x.x.x\folder while clicking the name of the folder in the drop down list, i got this error : ERROR_NOTAFOLDER
But if i click the same item in the explorer list, it works.

same here in <IP_ADDRESS>

0.21.0 idem
2020-10-26 12:42:46.6730|ERROR|Files.App|Invalid URI: The format of the URI could not be determined.|System.UriFormatException: Invalid URI: The format of the URI could not be determined.
at SharedLibrary!+0xafcaa0
at System.Uri..ctor(String) + 0x17
at Files.Helpers.PathNormalization.NormalizePath(String) + 0xea
at Files.UserControls.HorizontalMultitaskingControl.d__10.MoveNext() + 0x65b
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task) + 0x70
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task) + 0x38
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task) + 0x17
at System.Runtime.CompilerServices.TaskAwaiter.GetResult() + 0xb
at Files.BaseLayout.d__58.MoveNext() + 0x424
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.b__7_0(Object) + 0x1e
at System.Action1.Invoke(T) + 0x28    at System.Threading.WinRTSynchronizationContext.Invoker.InvokeCore() + 0x33    at System.Runtime.InteropServices.McgMarshal.ThrowOnExternalCallFailed(Int32, RuntimeTypeHandle) + 0x21    at __Interop.ComCallHelpers.Call(__ComObject, RuntimeTypeHandle, Int32) + 0xb8    at __Interop.ForwardComStubs.Stub_11[TThis](__ComObject, Int32) + 0x24    at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x3d --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() + 0x21    at Microsoft.AppCenter.Utils.ApplicationLifecycleHelper.<.ctor>b__17_1(Object, UnhandledErrorDetectedEventArgs) + 0x75    at System.EventHandler1.Invoke(Object, TEventArgs) + 0x2e
at __Interop.Intrinsics.HasThisCall__23[TArg0](Object, IntPtr, Object, TArg0) + 0x36
at Files!+0x13452c0


No Game settings tab

Installed module today (12/30/24). Enabled the Module.  When I go to Module settings, Elevated Module is not listed.  Uninstalled,  went to game, then reinstalled.
Any ideas?

Are you using Foundry v12? If so, it won't work.
If you are using v11, open the browser console and filter for error messages. Usually if the module does not load, it is because of some error early in the load process.

Thanks for the reply
Yes on Foundry V12 .
Are there any plans for v12?
Zack
On Mon, Dec 30, 2024 at 4:20 PM caewok @.***> wrote:

Are you using Foundry v12? If so, it won't work.

If you are using v11, open the browser console and filter for error

messages. Usually if the module does not load, it is because of some error

early in the load process.

—

Reply to this email directly, view it on GitHub

https://github.com/caewok/fvtt-elevated-vision/issues/119#issuecomment-2566029685,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/BJ6DRGC7IN2ZZVIGFIYXTN32IHPOHAVCNFSM6AAAAABUMXLBMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGAZDSNRYGU

.

You are receiving this because you authored the thread.Message ID:

@.***>

Yep.


White screen on some service

Is it normal that some services like Skype gives white screen ?

I also have this occasionally, Refresh does not help, Quit and restart helps.

Hello guys,
I read some other opened issues here about the same problem.
Some said it's hardware acceleration, others said it was Electron causing this issue.
In my case, even with the i386 version with Electron up to date it still happens.
Regards.


[Bug]: Missing dSYM / DWARF on iOS release warning

What happened?
Releasing iOS app with OneSignal SDK v5.2.1 i got warning about missing DWARF file for OneSignal framework. Overall AppStore allows me to upload. But this warning didn't exist until Xcode v16.
MAUI v8.0.92
NET SDK 8.0.403
OneSignal v5.2.1
XCode v16

Steps to reproduce?
1. Create app and including OneSignal from nuget.
2. Select iOS target. Create required provisioning profile. Release an archive.
3. Open Xcode -> Window -> Organizer.
4. Select App archive, then validate or Distribute command in the right pane.
5. Get warning from AppStore.

What did you expect to happen?
Release without warnings
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @alexsmi-noveo thanks for reporting.
This is a new warning as of Xcode 16 and can be safely ignored.
To omit the warning, you can follow the suggestion from this Apple thread: https://forums.developer.apple.com/forums/thread/763731


Added comment extraction and parsing

Added rst file for comment extraction and parsing

Thanks! I'll fix some formatting later.


Messages missing even after sync

On newer clients (but not on 1.12.4 web) messages just disappear, even after i sync the last 25 ones.

This is a bug caused by the app not resetting properly. Deleting the app data and setting it up again will fix it.

Can confirm that fixed the issue, thanks!


Alpha into beta

Description
Merge the latest alpha changes into beta
Breaking Changes
JIRA Link
Checklist

There are 12 code smells, but its for deprecated calls and changing the autogen files from polkadot.js
I think we should ignore the smells for this PR. We might want to change the deprecated stuff in a later PR, but I figure we can put it off until the deprecated becomes breaking.

:tada: This PR is included in version 15.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0-alpha.16 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add descriptions for every conversion

Every conversions should be add description the usage information of different, and help developer to write correct code.

:+1:


Fix typo in supervised_losses.py

continous -> continuous

Thank you for your pull request to fix a typo. However, this piece of code, imported from the Baby AI environment, remains unused in our algorithm. Given the reasons discussed above, I am closing this pull request. I encourage you to propose these changes to the original repository where they could be more beneficial. Thank you.


Add def file for react

This covers React, ReactDOM and PropTypes. However it doesn't cover full API for React since this PR is implemented based on the assumption that the user is writing JSX. So some methods aren't implemented, e.g. React.createElement

This change is

Thanks, merged!


Update index.md with katharsis-servlet as a Java implementation

Hi,
I've cut a release of katharsis-servlet which is an adapter module for katharsis-core, so I think it might be good to add this module info as an implementation in the page.
This adapter module provides a generic adapter for traditional servlet/filter based Java web applications. This module is based on katharsis-core like katharsis-rs is, but katharsis-servlet provides servlet/filter bridges while katharsis-rs provides JAX-RS container filter bridge.
Please let me know if you have any questions.
Regards,
Woonsan

Thank you!


Update PyPi with latest code.

When you get a chance can you update your tarball on PyPi to the same code you have on GitHub? It's a little bit behind (2012-11-16).
https://pypi.python.org/pypi/Flask-SSLify

this is fixed

There is a 1.5 version on PyPI, but no corresponding Git tag on the repo yet.


Stuck on loading bar when opening WebUI

When I access the webUI, I get redirected to /indexstate-redirect for a moment, then to /playback.
But it only loads indefinitely there.

I tried running the image two ways, first with docker-compose
version: "3"

networks:
  internal:

services:

  app:
    image: jbonjean/volumio:latest
    networks:
      - internal
    ports:
      - 3000:3000
    restart: always
    volumes:
      - ./music:/var/lib/mpd/music/:ro
      - ./data:/data
      - /etc/localtime:/etc/localtime:ro
    environment:
      - HOST=http://localhost:3000/
      - PGID=1000
    devices:
      - /dev/null:/dev/snd

then as a command
docker run --restart=always -d --name volumio \
  -e HOST=http://<IP_ADDRESS>:3000 \
  -p 3000:3000 \
  -v ./data:/data \
  --device /dev/snd \
  jbonjean/volumio

But the results are the same both times. What am I doing wrong?

The value for the environment variable HOST must match the URL you are using to access the WebUI. From your screenshot, you should set HOST=http://<IP_ADDRESS>:3000.

That worked, thanks!


Prompt dialog and Numeric Keyboard support

Would it be possible to build in support for your prompt dialogs to assign specific keyboards. For example, I would like to create a pin dialog that will require the Numeric only keyboard on devices. The secure options work nicely for this. I have had a look and could not find a way to do this currently.

Yes - use Acr.UserDialogs (https://github.com/aritchie/userdialogs - also on nuget). This functionality is already there

Thank you. Are those replacing this repository?

yes


Unable to pickle an BaseModel with validate_call

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hey hey,
I have stumbled upon an issue on which I can't find a solution. I have a BaseModel which is a value to UserDict.  The user dict has a validate_call on which when we set an item to the dict we validate it. All is good until I try to pickle the Dict that has validation call in it with a BaseModel as value.
Note: same thing worked with validate_arguments in V1
The error I get is rather weird:
Traceback (most recent call last):
  File "/home/ubuntu/monkey/monkey/check.py", line 60, in <module>
    pmd = pickle.dumps(my_dict)
          ^^^^^^^^^^^^^^^^^^^^^
AttributeError: Can't pickle local object 'GenerateSchema._common_field_schema.<locals>.json_schema_update_func'

Any info will be much appreciated.
Example Code
import pickle

from collections import UserDict
from pydantic import (
    BaseModel,
    validate_call,
    PositiveInt,
    ConfigDict,
    field_serializer,
)

class OtherModel(BaseModel):
    number: float

class MyDict(UserDict[PositiveInt, OtherModel]):
    @validate_call
    def __setitem__(self, key: PositiveInt, value: OtherModel):
        super().__setitem__(key, value)

print(OtherModel.model_json_schema())
my_dict = MyDict({1: OtherModel(number=1.0)})

pmd = pickle.dumps(my_dict)  # This is where I get the error
print(pickle.loads(pmd))

Python, Pydantic & OS Version
pydantic version: 2.4.2
        pydantic-core version: 2.10.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/mcus/monkey-venv/lib/python3.11/site-packages/pydantic
               python version: 3.11.4 (main, Jun  7 2023, 12:45:48) [GCC 11.3.0]
                     platform: Linux-5.15.0-60-generic-x86_64-with-glibc2.35
             related packages: mypy-1.6.0 typing_extensions-4.8.0 email-validator-2.0.0.post2

@ilija-lazoroski,
Thanks for reporting this! This does look like a bug 🐛 . I was able to replicate this. We'll look into a fix!

Hey @sydney-runkle maybe I can contribute and try to solve this issue. Of course I will need some help and guidance about how that is done in pydantic but since the label good first issue, maybe I can do it in my free time. What do you say?

The problem is probably because validate_call does not use functools.wrap which makes the wrapped function unpickable. Since @ilija-lazoroski you want to work on this one, I will skip continuing this issue.

I was able to run the example without any issues. I would be happy to help if the issue is still relevant in some configuration and you can provide more details in order to replicate the error.
The configuration I used to run the code successfully is:
 pydantic version: 2.4.2
        pydantic-core version: 2.11.0
          pydantic-core build: profile=release pgo=false
                 install path: /Users/adolfovillalobos/Documents/open-source/pydantic/pydantic
               python version: 3.9.16 (main, Jul 11 2023, 13:05:19)  [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]
                     platform: macOS-13.0-arm64-arm-64bit
             related packages: email-validator-2.0.0.post2 pydantic-extra-types-2.1.0 typing_extensions-4.7.1 pydantic-settings-2.0.3 mypy-1.1.1

I ran the following code (modified prints for clarity):
import pickle

from collections import UserDict
from pydantic import (
    BaseModel,
    validate_call,
    PositiveInt,
    ConfigDict,
)

class OtherModel(BaseModel):
    number: float

class MyDict(UserDict[PositiveInt, OtherModel]):
    @validate_call
    def __setitem__(self, key: PositiveInt, value: OtherModel):
        super().__setitem__(key, value)

print(f"model_json_schema: {OtherModel.model_json_schema()}")
my_dict = MyDict({1: OtherModel(number=1.0)})

pmd = pickle.dumps(my_dict)  # This is where I get the error
print(f"pickle.loads: {pickle.loads(pmd)}")

The output was:
model_json_schema: {'properties': {'number': {'title': 'Number', 'type': 'number'}}, 'required': ['number'], 'title': 'OtherModel', 'type': 'object'}
pickle.loads: {1: OtherModel(number=1.0)}

PD: I also ran the code using 3.11 and obtained the same output.

@AdolfoVillalobos All info that you need to replicate is in the issue. I can see there is some differences between what I have provided as info and yours. For example python version.
I will try with yours info but we cant really run python v3.9

@ilija-lazoroski I understand.  As I run the code using python 3.11.4 (details below), the only major difference that I can see at the moment (besides the python version) is the pydantic-core version (I'm using 2.11.0 and you are using 2.10.1).
Going through the chain of calls made by the validate_call decorator, It seems that:

The  __call__ method from ValidateCallWrapper  uses the output of the create_schema_validator method as the validator.
create_schema_validator actually outputs an instance of SchemaValidator , which is obtained from the pydantic-core module. As I understand, pydantic-core is written in Rust. See: https://github.com/pydantic/pydantic/blob/b7d92817ac2223237b5d341227de3eff7a84b350/pydantic/plugin/_schema_validator.py#L20C10-L20C10

In other words, could It be that the issue actually came from the pydantic-core module, and somehow got solved somewhere between versions 2.10.1 and 2.11? Just thinking out loud here.

PD: Python 3.11.4 configuration
 pydantic version: 2.4.2
        pydantic-core version: 2.11.0
          pydantic-core build: profile=release pgo=false
                 install path: /Users/adolfovillalobos/Documents/open-source/pydantic/pydantic
               python version: 3.11.4 (main, Jul 20 2023, 08:47:22) [Clang 14.0.3 (clang-14<IP_ADDRESS>.1)]
                     platform: macOS-13.0-arm64-arm-64bit
             related packages: email-validator-2.0.0.post2 pydantic-extra-types-2.1.0 typing_extensions-4.7.1 pydantic-settings-2.0.3 mypy-1.1.1

I also thought of that. I will try it and see. When i was writing the issue that was the latest pydantic-core version.


fix(details): Concurrent request for resolvers

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2070-1 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2070-fabric8-planner.badger.fabric8.io

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2070-2 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2070-fabric8-planner.badger.fabric8.io


[BUG] Tooltip is not tracking trigger element when resizing window

Bug description
resizing the window does not move the tooltip along with the anchor element
Version of Package
v5.18.0
To Reproduce
codesandbox: https://codesandbox.io/p/sandbox/react-tooltip-resize-tracking-mszsgp?file=%2Fsrc%2FApp.tsx%3A6%2C17
Expected behavior
Expected the tooltip to track the trigger element upon page resize
Desktop (please complete the following information if possible or delete this section):

OS: MacOS
Browser: Chrome
Frameworks [e.g. React 17/18, Vite]

Additional context
Not sure if this is considered a bug as the behaviour is not explicitly stated on the docs, but floating-ui seems to support the resize using autoUpdate and the library already tracks scrolling

We indeed do not track page resize. We'll leave this open so we can try using autoUpdate() in the future.
Until then, my suggestion is to use closeOnResize.

<EMAIL_ADDRESS>now uses floating-ui's autoUpdate() function.


How fire trigger after delete ICollection of Entities

Hello
Thank you for this wonderful extension, i have an issue whene i try to fire the trigger after deleteing IColletion of enyity.

I'm not getting the question, can you clarify your issue? thanks.

For example i have a trigger after deleting a Student and the latter is a child of the School, so when i try to delete School with a Collection of Students the trigger of Student not working.

Thanks for your feedback.
I did not understand everything, except me I want that once a School will be deleted at the same time we delete the Students childs and for each Student we trigger a Trigger.


Update for v2 api

@stevenmiller888 Here's the update for the Drip integration. Let me know if there's anything else that needs to change.

@amillet89 @ndhoule @f2prateek Can you review Ian's PR? We'll also need to expose the API token in our interface for them.

@stevenmiller888 Any word on this?

Sweet, LGTM!

@iantance forgot to ask, but would we need to update our analytics.js integration as well? Might confuse users if the server side and client integrations work differently.

I don't think an update to analytics.js should be necessary. The v2 upgrade
only applied our REST API, and it's only the server side integration that
isn't working currently. Analytics.js pushes calls to our JS API. The
client side version is being used successfully by a number of our customers.
On Mon, Mar 23, 2015 at 6:44 PM, Prateek Srivastava <
<EMAIL_ADDRESS>wrote:

@iantance https://github.com/iantance forgot to ask, but would we need
to update our analytics.js integration as well? Might confuse users if the
server side and client integrations work differently.
—
Reply to this email directly or view it on GitHub
https://github.com/segmentio/integration-drip/pull/1#issuecomment-85286118
.

Cool, just checking. Thanks for the PR!


Link provided in 'Golden configuration promotion' is broken

Hello,
In the middle of this page, there is a link to 'Golden configuration promotion'  (Under section When refreshing from sandbox environment to production environment);   this link is broken.
Can this be resolved please.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d28e8cc-5110-f01b-db76-94479ec2fa91
Version Independent ID: f0710707-9ff2-84a1-30c7-1f0d44e3a0d7
Content: Refresh database - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/database/database-refresh.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

@harishmohanbabu, thanks for making us aware of this issue!  I've fixed the link.  The update will be published soon.
The link goes to this topic: Golden configuration promotion.


Consider running latency tests in sequence

          Maybe latency tests should not run in parallel on the same machine? This hack may hide latency introduced from round trips that don't require much compute?

Originally posted by @elsirion in https://github.com/fedimint/fedimint/pull/4524#discussion_r1525955009

dev call: @dpc mentions that we should track performance of latency tests over time


Backport Changes from Prague

[ ] https://github.com/ethereum/execution-specs/pull/1016#discussion_r1806864829

Closed since #1051 already covers this


Add remarks on TerminateProcess for already terminated processes

Calling TerminateProcess to terminate an already terminated process results in access denied error. There are multiple threads on the Internet discussing TerminateProcess failure with ERROR_ACCESS_DENIED despite having the handle opened with full access. But none of them have clarity on this special case.

@Cutuy : Thanks for your contribution! The author(s) have been notified to review your proposed change.


proper way to load more

having a hell of a time getting it to load more without causing the last card to be skipped or crashing to occur due to something or another.
•What method should loadmore be called in
•What should be called after more data has been loaded.

I did it in the wasChosenWithDirection function
    if self.charts.count <= 5 {

        // GetObjects and make charts
        getObjectsAndMakeCharts()

    }

Also my load function doesn't just the last card, it knows the position of the card being loaded (i.e. 0, 1 or 2) and loads the correct array element.


OSError

Hi,
I catch the following error:
OSError: SavedModel file does not exist at: EQTransformer/ModelsAndSampleData/EqT_model.h5/{saved_model.pbtxt|saved_model.pb}
Could you, please help me with this?
Thanks in advance.

Hello, I am also facing the same problem. Have you found a way to resolve it?
Thank you


fix(docs): Fix undefined method File::defaultValue() in README.md

There is a call to an undefined method defaultValue() in the File example of the README.md.
I just removed that line.

Thanks Solal! 🙌


Changed IRC references to Libera.Chat.

We have been Libera-ted

Thanks y'all for reviews :star2:


How to make a ".exe" for both 32-bits and 64bits?

Hello,
Anyone could help me on how to create a single Windows binary for a Node.js application that will both work on 32-bts System and on x64 one too please?
Thank you in advance.

A 32-bit binary will run on either Windows 32-bit or 64-bit. This is the simplest solution. Specify x86 for the arch: https://github.com/zeit/pkg#targets

Thank you.
The fact is that even if a 32-bit app will run on a x64 platform, it is not optimized to do so :(. Is there any tool available in pkg to create an installer that will bundle both 2 versions of the app (x86 and x64) that will install the right version?

I don't believe that pkg has any tools to create any installer itself. You can create both binaries using pkg and then use an installer creator, like NSIS, to create an installer that can choose which arch to install at runtime.
Other hacks to achieve a fat binary would likely be outside pkg's intended use.

In my  package.json I have kept following configuration and it created build for both 32 and 64 bit Windows machine
"pkg": {
"assets": [
"xxx//*",
"xxx//"
],
"scripts": "xxx/**/.js",
"targets": [
"node8",
"x86"
]
},


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4639

Questions ?
Please refer to the Backport tool documentation


isSet() deprecated warning

Please choose your issue template from the following options:
1. 🐛Bug-Report
If something isn't working as expected 🤔
Expected behavior
Run without warnings.
Current behavior
Runs with the warning that isSet() is deprecated.
Steps to reproduce

Clone the repository into a virtual environment.
Download dependencies.
Run the 20-20-20-Eyesafe-project.py file in terminal.

Possible Solution
Convert the isSet() to is_set().
Detailed Description (screenshots, code snippets etc.)
I noticed this while checking that the requirements.txt file was working correctly.

Issue has been added to contrihub

Can I work on this? Im getting this error in the contrihub page - Assignment Request for Issue #5 of 202020-Eyesafe-Project cannot
be made by you currently.


feat: store strong references of task objects

Fixes #63
Save strong references of tasks/futures so that they are not lost mid execution due to GC.

@kohlisid FYI. The codecov failure could be resolved by https://github.com/numaproj/numaflow-python/pull/67#discussion_r1138831711


PHP Generated page not rendering in Save & Preview

Describe the bug
PHP generated page is not rendering
Version
v<IP_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
On Save & Preview, the page does not render properly.

! ALWAYS INCLUDE AN EXAMPLE URL WHERE IT IS POSSIBLE TO RE-CREATE THE ISSUE !
Expected behavior
Preview should show page
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version Version	10.0.19043 Build 19043

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

No URL = No Help


The result of each dataset?

Could you report the result of each dataset (e.g. CIFAR10, ImageNet)

I'm still training the model on ImageNet and finding the hyperparameters.

The hyperparameters reported in  do not work well? Since training ImageNet from scratch is time-consuming, I am trying to reproduce the results in CIFAR10 & CIFAR100. But even I have tried many strategies to finetune the EfficientNet, it did not work well on CIFAR10(86.29) CIFAR100(66.57)

The training code is from PyTorch ImageNet example, the settings of hyperparameters do not work well for my code. Now I am training the model with the gradual warmup.

I am also trying the settings in the official implementation

So what are the F1 score and F5 score for your current setting? And what is the GPU hours u need to train?

I am trying to reproduce the results reported in EfficientNet: Rethinking Model Scaling for Convolutional Neural Networks in small scale datasets first.

So what are the F1 score and F5 score for your current setting? And what is the GPU hours u need to train?

The best top1 accuracy I got is ~ 68% (efficientnet_b0) on the validation set.
I just retrained the model
Epoch:   3% 8/300 [4:35:28<167:28:14, 2064.71s/it]
Train:  86% 8618/10010 [28:49<04:52,  4.75it/s]

I tried this config with 5 epochs gradual warmup and got 93.81 % top1 acc.
Config(
        use_cuda: True
        data_parallel: True
        num_epochs: 90
        output_dir: experiments/cifar10
        model: {'name': 'efficientnet_b0', 'num_classes': 10, 'in_channels': 3}
        dataset: {'name': 'cifar10_dataloaders', 'root': 'data', 'batch_size': 64, 'image_size': 224, 'num_workers': 16}
        optimizer: {'name': 'SGD', 'lr': 0.025, 'weight_decay': 0.0001, 'momentum': 0.9, 'nesterov': True}
        scheduler: {'name': 'MultiStepLR', 'milestones': [30, 60, 80], 'gamma': 0.1}
        config: configs/cifar10.yaml
        root: None
        resume: None
        backend: nccl
        init_method: tcp://<IP_ADDRESS>:23456
        world_size: 1
        rank: 0
)
Files already downloaded and verified
Files already downloaded and verified
Epoch:  62% 56/90 [2:01:20<1:13:14, 129.24s/it, train loss: 0.3861, train acc: 86.65%, valid loss: 0.2026, valid acc: 93.50%, best valid acc: 93.81]
Train:  45% 351/782 [00:51<01:06,  6.53it/s, train loss: 0.3861, train acc: 86.70%.]

I'm trying EffNet-B0 on CIFAR100 and couldn't get the reported results. What could I be missing? I'm using the same hyperparameters mentioned.

I'm trying EffNet-B0 on CIFAR100 and couldn't get the reported results. What could I be missing? I'm using the same hyperparameters mentioned.

The dataset in reported results is CIFAR10

I see, seems like EfficientNet is hyperparameter-sensitive.  Do you have any source where I can refer to for CIFAR100?

@narumiruna hello, any update on reproducing the paper results by training with this repo? Thank you!


Add font faces

@rgerstenberger nailed the select box bug, added system fonts to constants/index.js FontMap, as well as finished with the font mapping for all the imported font faces.

Aside For branch names go with feature-name-of-feature if feature dev, if bug bug-name-of-bug or if it's tech debt or other work chore-name-of-work-being-done e.g. feature-text-font-editing

I know we haven't solved the width/height thing yet but let's keep the initial drag and drop working properly. Please update the initial width/height in elements based on the new default font settings.

@rgerstenberger updated styling. Ready for re-review

@mdaxtman the spacing and padding looks off. Also, the closed select box font size looks to big:

And I think the check icon is too small or maybe that's because the font size is too big and making it look small.

LGTM!

latest screens:


Dimensions in Unity

How can I get the width/height of a MovieClip (LWF.Movie) that has been loaded into Unity?
Something like this would be great for example:
lwf.SearchMovieInstance("ExampleInstanceName").width
But that doesn't exist. Right now all I can do is get all of the Renderers of the GameObject that LWFObject is attached to and calculate the width using all of their bounding boxes, this isn't very good however since it becomes affected by things like GameObject scale/rotation.
I know I can get the stage size of the flash from "lwf.width" and "lwf.height" but that isn't good enough, I'd like to be able to get the width/height of the movieclips inside the flash as well.

Use Movie.RequestCalculateBounds or LWFObject.RequestCalculateBoundsMovie.
movie.RequestCalculateBounds((m) => {
    LWF.Bounds b = m.GetBounds();
    Debug.Log(string.Format("{0} {1} {2} {3}", b.xMin, b.xMax, b.yMin, b.yMax));
});

Thanks for trying to help. It looked promising but unfortunately it didn't work. I tried the following inside a LWFObject:
void FixedUpdate() {
	string mcInstanceName = "topbar";
	LWF.Movie m = lwf.rootMovie;
	if (mcInstanceName!=null) {
		m = lwf.SearchMovieInstance(mcInstanceName);
	}
	m.RequestCalculateBounds((mov)=> {
		Debug.Log("test1");
	});
	RequestCalculateBoundsMovie(mcInstanceName, (mov)=> {
		Debug.Log("test2");
	});
	Debug.Log(lwf.rootMovie.GetBounds());
	Debug.Log(lwf.SearchMovieInstance(mcInstanceName).GetBounds());
}

The output every time it was executed was alway Null from the two GetBounds() calls and "test1"/"test2" was never printed, meaning that none of the callbacks were ever called.

I recommend you to use Unity debugger to track why the callback was never called. Anyway GetBounds() doesn't work in your code snippet, it should be in the callback.

I don't intend to correct any of LWF's code though, I don't have the time, but it's good for the developer(s) of LWF to know that something is broken with RequestCalculateBounds. It would be nice with a method that returns the bounds immediately (no "request" required), I'm assuming it would take at least a frame before that calculate callback arrived which isn't too useful.

Ok, I've found and fixed the problem db15f61d7daa18781e18989ec3df63ddf3472fea .

Great job dude, everything's working! Thanks!