DDPG is on-policy?

Oops, sorry. I typed the issue in the wrong repo. I'm trying to figure how to delete the issue.

wrong place haha ;)


PHOENIX-6168 PHOENIX-6143 breaks tests on linux

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
13m 52s
master passed

+1 :green_heart:
compile
0m 34s
master passed

+1 :green_heart:
javadoc
0m 16s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
9m 53s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 29s
phoenix-tracing-webapp in the patch passed.

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

35m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-905/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/905

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 792be7957a0a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 0936c09

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-905/1/testReport/

Max. process+thread count
91 (vs. ulimit of 30000)

modules
C: phoenix-tracing-webapp U: phoenix-tracing-webapp

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-905/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[xmsh]Upgrade version to 0.5.2.

Upgrade version to 0.5.2.
NOTE: Xmsh needs to use gcc with version greater than 7.1 under linux.
Related: #6618.

/azp run

/azp run

@cbezault What is the gcc version of ci system used in Linux now?

/azp run

Due to this branch has been deleted, open a new PR #7155.


AutoModelWithLMHead, Sequence Classification and Question Answering

Added new AutoModels, as long as the accompanying tests. Updated the TorchHub configuration file to redirect to those AutoModels.

Not sure torch.hub will work directly. We should check with @VictorSanh.

Just checked the integration with Pytorch Hub, it works on my end. For example, you can try it out with:
import torch
torch.hub.load('huggingface/pytorch-transformers:automodels', 'autoModelWithLMHead', 'distilbert-base-uncased')

Ok, I think we are all good with this. Happy to have torch.hub integration again.


Vision moved to beta stage

LGTM

Changes Unknown when pulling 8a500c0e68e76eaf2a76720072f72eb90632b7ce on vam-google:master into ** on GoogleCloudPlatform:master**.


EnableDialinConferencing not applicable to SfBO

Based on the following work item, 1451047, EnableDialinConferencing is not applicable to SfB Online.
So I added EnableDialinConferencing to the section "The following parameters are not applicable to Skype for Business Online: ".
Title: 1451047 Remove EnableDialinConferencing as a MeetingPolicy knob that can be customized by tenant admins
URL: https://skype.visualstudio.com/SBS/_workitems/edit/1451047

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/New-CsConferencingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


drop PHP 5.4 check

@samsonasik develop branch is already updated
https://github.com/zendframework/zend-log/blob/develop/composer.json#L17

yes, but my changes not only update minimum php version, it changes other codes too


P48

It says:
That’s because $apply launches $digest, and the $applyAsyncqueue drainage therein from a finally block.
It would be more descriptive and correct if it was something like:
That’s because $apply launches $digest, and the $$applyAsyncQueue is drained as part of the finally block therein.

Fixing, thanks


Create a Snap package for linux distors

https://snapcraft.io

Is there any progress on this issue?

We'll work on packaging closer to the alpha release in a couple of months.

We are working full steam on preparing the code base to be released. Hopefully we'll have a first preview version available in the very beginning of 2016
https://www.reddit.com/r/Database/comments/3l72ga/new_object_database_edgedb_soon_to_be_released/

Edgedb is a great idea but painfully slow development is really discouraging. A formal road map/Timeline and an proper installer package will encourage developers to try Edgedb and contribute.

@ansarizafar +1

Our internal timeline for releasing first alpha is 2-3 months. Things will go faster after that.

Is there any chance of a stable release with JavaScript bindings this year?

Beta release with node bindings yes.

I understand your frustration, but there's nothing you can do to change our schedule. We have enough things to worry about right now and are actually busy working on edgedb and many related things. Please stop complaining here, it's not productive.

We now have the packaging infra and will ship native packages for many linux distributions. No need for snap packages now; closing this.


Provide general advice like using en_US_POSIX or setLocalizedDateFormatFromTemplate

As discussed on Slack, here are the suggestions / rules I always give to anyone willing to use a custom date format:

If possible it’s better to always avoid providing the dateFormat yourself, because it’s so easy to get it wrong for other locales by doing it yourself, you’re gonna run into some fallacies. A good set of rules are the following:

Use dateStyle and timeStyle whenever you can instead of dateFormat
If you need a specific format that can’t be achieved by dateStyle and timeStyle, then at least use df.setLocalizedDateFormatFromTemplate(…), or df.dateFormat = DateFormatter.dateFormat(fromTemplate:…options:…locale:…) to make sure it auto-adapts to the user’s locale; never use a direct String format as the dateFormat field to format dates for UI.
If you need to parse ISO Dates / “internet dates” used not for UI but for JSON or API, etc, preferably use ISO8601DateFormatter
In last resort, if you need to parse a date for JSON or API that doesn’t fall into ISO8601 format, but that also isn’t intended for UI and should not depend on the user’s locale/region/language because it’s a format for the API not for presenting in UI, then that’s the only case when you can use a fixed string in df.dateFormat like df.dateFormat = "yyyy-MM-dd'T'HH:mm:ssZ" BUT when you do that, then ALWAYS also set df.locale = Locale(identifier: "en_US_POSIX"). This is a special locale for your DateFormatter that guarantees that the formatting/parsing won’t depend on the phone’s locale and is designed exactly for parsing those “internet dates with fixed format”

@davedelong suggested that we post that advice on nsdateformatter.com as we think that could be very valuable to a lot of people.
The think is, I'm not sure how to do this. Do we want a new page / tab next to "Examples / Reference / About" on the website, with this as static content? Do we want something else, maybe some ⚠  icon next to the Locale dropdown linking to said advice? I'm open to suggestions.
(Also, I just copy/pasted my Slack message verbatim here, but we might need a more appropriate wording to present that as static content on the website ofc)

I think a new tab is probably the best place for it. Maybe "Guidance" ?

Yeah, tho tbh even though I think a new tab is probably the most suited, I'm a little concerned that people are not gonna click on it ever and that the advice might not be visible enough. But at least it would be a start :P

I hear you. Let's start there, and maybe consider a little message near the top that you can click on to reveal the guidance.
"Psst! Before you use a custom date format, make sure and read this"

Sounds good. Will give it a try this evening.
Since it's just static content, it's all just about adding code to Resources/Views/index.leaf right?

I think a new tab is probably the best place for it. Maybe "Guidance" ?
Best Practices?

Yep. Feel free to ping me on Slack if you run into any issues.

On Apr 1, 2020, at 8:02 AM, Olivier Halligon<EMAIL_ADDRESS>wrote:
Sounds good. Will give it a try this evening.
Since it's just static content, it's all just about adding code to Resources/Views/index.leaf right?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/subdigital/nsdateformatter.com/issues/20#issuecomment-607235292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOOBGUK5IXBFF6J5TAR7DRKM3NBANCNFSM4LY4J5VQ.

I like it

On Apr 1, 2020, at 8:03 AM, Shawn Bierman<EMAIL_ADDRESS>wrote:
I think a new tab is probably the best place for it. Maybe "Guidance" ?
Best Practices?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/subdigital/nsdateformatter.com/issues/20#issuecomment-607235825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOOBHAXSDY2RV22RFJXYLRKM3RVANCNFSM4LY4J5VQ.


Added README.md and screenshot

Screenshot is cut off a little bit from the right side. I suggest to use built-in Haiku ScreenShot app which has an option to take screenshot of only active window.

Fixed it, my bad.

Screenshot is cut off a little bit from the right side. I suggest to use built-in Haiku ScreenShot app which has an option to take screenshot of only active window.

I'll keep your advice in my mind, thanks a lot for the constructive feedback!

Now fonts look corrupted somehow? Could you tell how did you take this screenshot?

Now fonts look corrupted somehow? Could you tell how did you take this screenshot?

In all honesty, I took a screenshot on a host machine and fixed the original screenshot, since I had the source file ready to go and I wasn't really aware of the font-related consequences. I'll do it the legitimate way this time, huge apologies for that one.

I force-pushed a squashed version of the last 3 commits together and save a bit of unnecessarily extra work.

Thanks! Looks good now :)

Actually, if you're up to it it would be even better to show how this app actually looks like when it shows a diff. As right now way too simple :)

Personally, I think that the screenshot would get unreasonably big. @diversys
If that's not a problem, then I can work on that with a simple "Lorem Ipsum" sample file and maybe the pig latin version of it.

Please do!


Jumbo emojis don't seem to work on mobile

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
Issue in one concise sentence.
Jumbo emojis don't seem to work on android using the latest release from github
Environment Information

Device Name: OnePlus 5t
OS Version: 8.0
Mattermost App Version: 1.13
Mattermost Server Version: 4.10

Steps to reproduce
How can we reproduce the issue?
Jumbo emoji
Expected behavior
Describe your issue in detail.
Larger emoji
Observed behavior
What did you see happen? Please include relevant error messages and/or screenshots.
No difference in emoji size
Possible fixes
If you can, link to the line of code that might be responsible for the problem.

Hi @Sloth-on-meth,
Support for jumboemojis was added in server v5.4, so I believe you'll just need to upgrade and it will work.

There is a ticket for adding Jumbo emoji to the mobile app https://mattermost.atlassian.net/browse/MM-12353

Sorry, server version is 5.4.0.
https://mattermost.atlassian.net/browse/MM-12353
Closed


consider release-please to improve release process

https://github.com/google-github-actions/release-please-action It's has been using in gyp-next and works pretty great so far as I observed (https://github.com/nodejs/gyp-next/blob/master/.github/workflows/release-please.yml
).
Maybe it's also good here too.
@rvagg What do you think ?
cc @targos @richardlau

Maybe, I'm not totally opposed to it. What we're doing now doesn't scale very well because it's basically coming down to me managing the releases.
But the install base of node-gyp is very large. 6M weekly downloads. And it's in critical path in CI systems for a very large number of installs. So we have security and stability concerns that should give us pause. And this is all outside of npm where they at least have some stability gating when pulling node-gyp in. So my concern would be the ease with which releases can be made and pushed into people's production pipelines. The write-access on this repo is fairly broad right now because we can gate releases with npm write access.

GitHub Actions now have environment protection rules and environment secrets: https://github.blog/changelog/2020-12-15-github-actions-environments-environment-protection-rules-and-environment-secrets-beta/
Maybe that can be used to protect an npm token and only allow a subset of collaborators to publish the package?

The write-access on this repo is fairly broad right now because we can gate releases with npm write access.

Maybe only use it for changelog generate and release PR. remove npm publish step from the workflow.

Maybe only use it for changelog generate and release PR. remove npm publish step from the workflow.

yes, I was thinking that this might be a good way to get started, gate publish on a human for now and see how we go.
I'd be ok with exploring this switch, it'll help with getting things merged and maintaining a changelog, but we're all going to have to be educated in the commit message pattern (I'm not quite there yet but have been trying to adopt it in other projects). We're clearly not scaling by sticking with the clean merge patterns and metadata of nodejs/node.


Export git package and git client

This PR exports the git package that had been internal for some time, no behavior changes here. It also adds in a new git client type that will be used for interacting with a local git repository. It is heavily inspired by this work done by @mislav. Right now the only exported methods on the git client are Command which is the base method, similar to Do for http.Client, that all other methods will use to execute commands and Remotes which lists remotes for the local repo. The reason I added Remotes is because it is needed within go-gh. I think for the initial version these are the only two that will be supported but more will be added in the future as necessary.
TODO:

[ ] Fill in missing tests
[ ] Add documentation

@mislav Thanks for the feedback! You have raised some good points. It is possible that this work should be started in cli/cli, I mostly started it here due to https://github.com/cli/cli/issues/5544 where we had targeted it for extraction. We can take it off that list though if you don't think it is valuable to have in go-gh though.

Offline, we have decided now is not the right time to introduce this feature into go-gh but rather start with an implementation in cli/cli and see how that goes and when we feel more confident in this direction then extract it at a later date.


The enhanced BitmapScanner

What changes were proposed in this pull request?
The enhancements for bitmap scanner are below:
1. Refactoring BitMapScanner and abstract the common BitmapReader
2. Add BitmapReaderV1 based on the original BitMap Scanner for backward compatibility
3. Add BitmapReaderV2 to directly get row Id list from fiber caches

How was this patch tested?
mvn clean test package and all the tests passed.

The disabled three fiber manager test cases are turned on by default. Thanks.

Sorry for the conflicts, can you update this?

The existing guava cache has the listener to be called back when the cache entry is evicted. That is not a good approach to use call back everywhere the fiber cache is used. Thanks.


Support folders with only a main.pony

but only if they are not already part of a corral.json folder. In that case, the corral.json data describes the sub-folders fully.

@mfelsche
Should this have gotten a CHANGELOG entry?

Good point, I'll add one post-factum.


PyPI prerelease version badge

:clipboard: Description
I just published a prerelease of tinyobjloader:
https://pypi.org/project/tinyobjloader/#history
As far as I can tell, there isn't a badge for displaying the latest prerelease version.
It looks like if there are only prereleases, they do show correctly, e.g.
https://img.shields.io/pypi/v/black

:link: Data
It looks like the data source we use now includes both of the releases for this project, 0.1 and 2.0.0rc5.
https://pypi.org/pypi/tinyobjloader/json
:microphone: Motivation
It's common for projects to run prereleases for a long time, and it's useful to show users the latest published prerelease.

As far as I can tell, there isn't a badge for displaying the latest prerelease version

I think the reason we haven't done this is: With PyPI, we defer to the registry to tell us which is the "latest" version. Beyond that, PyPI's API doesn't explicitly mark releases as pre-release or stable. This means we would have to make our own decision about which releases are pre-release and which are stable.
Most (all?) packages on PyPI follow PEP440 rather than semver, so we'd need a javascript implementation of PEP440 for that case (which is a thing that does exist https://github.com/renovatebot/pep440 ). I'm not 100% sure if PyPI enforces PEP440 or not though. If it does, "all package versions are PEP440-compliant" is a reasonable assumption and we could just roll with that. If it doesn't, we're then on shaky ground with that assumption as there will inevitably be some packages in the registry with non-compliant versions.

I don’t know if PyPI enforces PEP440 either. It does seem to normalize version numbers (e.g. if you upload a package with beta6 it will allow fetching it with beta6 but at least lists it as b6: https://pypi.org/project/polliwog/#history

Beyond that, PyPI's API doesn't explicitly mark releases as pre-release or stable.

Prereleases are defined in PEP440 and fortunately would be relatively easy to detect using regex.
One option that would solve my use case would be to have an option that returns the latest release by date. There are upload dates in the JSON, although they might have to be aggregated across the various sdists and wheels.
I know you worked a lot on the GitHub release badges so I bet you have this problem a lot more in your head than I do. 🤔

Just thinking about it in slightly more detail..
PyPI does flag releases as pre-release in the front-end (its just not exposed via the API):

Looking at the warehouse source, the code for doing that is:
https://github.com/pypa/warehouse/blob/1fbb4ac752e68b5840b9e09b68e44a165569bfa6/warehouse/migrations/versions/e7b09b5c089d_add_pep440_is_prerelease.py#L29-L34
so we could replicate the same method for identifying whether a version is stable or pre-release but I think we'd still want to use https://github.com/renovatebot/pep440 for comparing/sorting versions to determine the latest in the pre-release case.

It would be great if we can get a Pre Release PyPI version badge just like NPM @ next. +1

latest in the pre-release case.

latest by release date or greatest version number?

Here's some discussion around making an API https://github.com/pypa/warehouse/issues/4663

Thanks :+1:  I've subscribed to https://github.com/pypa/warehouse/pull/8615 - we'll see how it plays out

Looks like that won't happen soon.

One option that would solve my use case would be to have an option that returns the latest release by date.

This is probably the way to go, and would work well for the project I'm thinking of right now, https://github.com/hylang/hy.

Another option would be to add a parameter to the badge that allows to specify a specific version (or add another endpoint for that). E.g. /pypi/pyversions/:packageName?version=v0.0a1.

The NuGet Version badge supports pre-releases.

It would be really nice if there was a similar option for PyPI.

+1 to the pre option. If you have both Python and NuGet packages, your badges and want to show the latest, your badges look a little weird

I again encountered a project where it would be very beneficial to have a pre-release version badge.

I don't think this is that difficult. Updating pypi-helpers.js would work parsing pre-release versions, right?
function parsePypiVersionString(str) {
  if (typeof str !== 'string') {
    return false;
  }

  const versionPattern = /^(?<major>\d+)\.(?<minor>\d+)(?:\.(?<patch>\d+))?(?<prerelease>[a-z]+\d+)?$/;
  const match = str.match(versionPattern);

  if (!match) {
    return false;
  }

  const { major, minor, patch = 0, prerelease = '' } = match.groups;

  return {
    major: parseInt(major),
    minor: parseInt(minor),
    patch: parseInt(patch),
    prerelease,
  };
}

// Sort an array of PyPI versions low to high.
function sortPypiVersions(versions) {
  return versions.sort((a, b) => {
    const versionA = parsePypiVersionString(a);
    const versionB = parsePypiVersionString(b);

    if (versionA.major !== versionB.major) {
      return versionA.major - versionB.major;
    }

    if (versionA.minor !== versionB.minor) {
      return versionA.minor - versionB.minor;
    }

    if (versionA.patch !== versionB.patch) {
      return versionA.patch - versionB.patch;
    }

    // Handle pre-release versions (a0 < b0 < rc0)
    if (versionA.prerelease && versionB.prerelease) {
      return versionA.prerelease.localeCompare(versionB.prerelease);
    }

    // If one version is pre-release and the other is not, the pre-release version is lower
    if (versionA.prerelease) {
      return -1;
    }

    if (versionB.prerelease) {
      return 1;
    }

    // Versions are identical
    return 0;
  });
}

// Example usage:
const versions = ['1.11', '1.11a1', '1.11b2', '1.11rc1', '1.12', '2.0'];
const sortedVersions = sortPypiVersions(versions);
console.log(sortedVersions); // ['1.11a1', '1.11b2', '1.11rc1', '1.11', '1.12', '2.0']

export {
  parseClassifiers,
  parsePypiVersionString,
  sortPypiVersions,
  getLicenses,
  getPackageFormats,
}

Ping - actually we like the pre-release versions to have some visibility so that they get some testing before the next release. Have had over 10 pre-releases now, and will likely have another 10...


Loosen Accept header check to allow starts with :api_json

Allow the check for the Accept header to begin with */* (All media types)

For example, "*/*;q=0.8"

Fixes #799

@lgebhardt just checking in, what do you think about loosening up the check for a valid Accept header so that the check matches that the header string begins with the "all media types" or :json_api mime type?

@pixelhandler The first change for allowing "*/*;q=0.8" seems fine to me. But I have my concerns that by loosening things up regarding the media type parameters on "application/vnd.api+json;version=1" we are in violation of the spec:

Clients that include the JSON API media type in their Accept header MUST specify the media type there at least once without any media type parameters.

But maybe I'm reading it wrong. I'd like to get @dgeb's opinion.

I should add I have no issue with allowing a configuration option to allow this, but I want to make sure the defaults adhere to the spec.

@lgebhardt this is my motivation https://github.com/EDMC/api-versions#versions-are-specified-by-header-not-by-url
Here is a tongue and cheek article on the subject: https://www.troyhunt.com/your-api-versioning-is-wrong-which-is/
This article seems to confirm the Accept header is how to version an API endpoint, https://blog.pivotal.io/pivotal-labs/labs/api-versioning
And I generally agree with http://blog.steveklabnik.com/posts/2011-07-03-nobody-understands-rest-or-http#i_want_my_api_to_be_versioned

@lgebhardt I can change this PR to remove the support for application/vnd.api+json;version=1 and do that in a separate PR cc\ @dgeb

I can change this PR to remove the support for application/vnd.api+json;version=1 and do that in a separate PR

@pixelhandler Please do so, but open an additional issue instead of PR to discuss.
There's a lot to unpack here, not least of which would be my preference to get JSONAPI out of the vendor tree and into the standards tree. But regardless, we can have a discussion about media type params in a separate issue if you like. I would like to get the change to */* merged sooner than later.

@pixelhandler I see you just commented here: https://github.com/json-api/json-api/issues/406#issuecomment-253261749
That's probably the best place for the discussion, since JR will simply follow the spec. Thanks for bringing this up!

@lgebhardt @dgeb I revised the PR and squashed the commit, thanks for the feedback.

@pixelhandler Thanks!

@lgebhardt you're welcome. It's a pleasure to use this gem !

And I generally agree with http://blog.steveklabnik.com/posts/2011-07-03-nobody-understands-rest-or-http#i_want_my_api_to_be_versioned

@pixelhandler I tend to agree with @steveklabnik's comment in the intro:

Since I've posted this, I've refined a few of my positions on things. Everyone learns and grows, and while I still stand by most of what I said, I specifically don't agree that versioning the media type is how to properly version APIs. Hypermedia APIs should not actually use explicit versioning, but I'd rather see a version in the URI with HATEOAS than no HATEOAS and versioned media types.

I'm approaching the versioning from the standpoint that a server will support multiple versions simultaneously. In JR this is easily done with the URI and name-spaced resources. It would not be an easy retrofit to allow version switching based on the media type. However I can see using the media type version as a version check. Are you designing your server to speak multiple versions, or using the version to indicate the current version that the server is speaking? Hope that question makes sense.


fix(workspace): fix glob pattern detection

Description

closes https://github.com/vitest-dev/vitest/issues/6499

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[x] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[x] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Any predictions for the conclusion of this problem?

hi @hi-ogawa! i saw isDynamicPattern mentioned here, and i just wanted to let you know that today's tinyglobby release added support for it, meaning you don't need to copy the implementation from fast-glob anymore :-)


Crash when trying to make an item with recipe book

The game crashes when trying to make an item using the recipe book.
I am using also the Better Recipe Book mod. So, it might be an incompatibility issue.
Crash Logs: https://mclo.gs/N1rDv2P

Yes, Better recipe book's mixin is crashing.


DASH Live cannot transition from completely unencrypted content to encrypted content later in the live presentation

Have you read the FAQ and checked for duplicate open issues?
Yes - Nothing open, but this looks like a regression: https://github.com/google/shaka-player/issues/1360, I don't think I can re-open an issue this old.  In 2.4.7, this bug doesn't exist.
What version of Shaka Player are you using?
3.0.10
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Demo App
If custom app, can you reproduce the issue using our demo app?
NA
What browser and OS are you using?
Chrome on Macos
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
NA
What are the manifest and license server URIs?
https://content.uplynk.com/playlist/4f1a9815a1af43d5ba64465d85bf11cf.mpd?ad=sintelads
https://content.uplynk.com/wv
What configuration are you using?  What is the output of player.getConfiguration()?
No special config -- I mean I can easily reproduce with the public appspot demo.  So whatever config is default for the demo:
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://content.uplynk.com/playlist/4f1a9815a1af43d5ba64465d85bf11cf.mpd?ad=sintelads;panel=CUSTOM CONTENT;build=uncompiled
What did you do?

The demo url is specifically designed to reproduce the issue quickly (honestly this would be a good sample stream for the demo app)-- You just start playback, it will always start in unencrypted ads.  It will run through roughly 45 seconds of ads, and then try to transition into content which is encrypted
What did you expect to happen?
I would like it to work as well as it does on shaka 2.4.7
What actually happened?

The transition into content after 45 seconds fails with: Shaka Error MEDIA.VIDEO_ERROR (3,,PIPELINE_ERROR_DECODE: audio error during playing, status: PIPELINE_ERROR_DECODE) every time.  It works on shaka 2.4.7

You need to configure the license server before playback starts if you expect to see encrypted content later.  The following works fine for me:
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://content.uplynk.com/playlist/4f1a9815a1af43d5ba64465d85bf11cf.mpd?ad=sintelads;license=https://content.uplynk.com/wv;panel=HOME;build=uncompiled

Ah, ok.  I don't need to configure the license url normally because shaka will read it out of the mslaurl attribute (ms:laurl xmlns:ms="urn:microsoft" licenseUrl="https://content…..’) in the manifest.
As an example without a license server configured:
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://content.uplynk.com/playlist/6c526d97954b41deb90fe64328647a71.mpd?ad=bbbads&delay=25;panel=CUSTOM CONTENT;build=uncompiled
I guess I expected that laurl to get picked up and add the license server when a new period shows up with it for the first time.  Perhaps this can be a feature request?

Unfortunately we can't initialize EME after playback has started.  We need to setup EME before playback starts, so it either needs to be in the first manifest or the configuration.  The browser sets up special media pipelines for protected content and many/most browsers don't allow switching while content is playing.

Also, I think you can just change the license server URL after playback has started.  So you could add a dummy value to the configuration and change it later.  I guess we could add support for a dummy value that gets filled from the manifest later.


Incorrect element name

The game should not use cd-quiz-game as a containing element, because that's not what it's called.
It should use q-n-eh.

Resolved!


chore(deps): upgrade compiler dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-compiler-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4473

Questions ?
Please refer to the Backport tool documentation


Jbaker/fix range validation

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #139
Summary:

Fixes issue where selecting a start date on a required range datepicker was causing validation to run on the end date input before blur of the datepicker.
Added doc example for range with required.
Updated README.md to be based on the latest template.
Remove improperly committed readme template.

Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.0.5 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Icons not loading in mitmweb - potential fontawesome issue?

Steps to reproduce the problem:

Launch mitmweb with mitmweb --set block_global=false --web-iface <IP_ADDRESS>.
Navigate to port 8081 on the mitmweb IP address.

Any other comments? What have you tried so far?
I see square instead of what I assume are fontawesome icons.

I think this might be similar to https://github.com/mitmproxy/mitmproxy/issues/3397 - and maybe even https://github.com/mitmproxy/mitmproxy/issues/3034 - however, will let developers decide.
System information
^Cvictorhooi@mitmproxy:~$ mitmproxy --version
Mitmproxy: 4.0.4
Python:    3.6.7
OpenSSL:   OpenSSL 1.1.1  11 Sep 2018
Platform:  Linux-4.18.0-1006-gcp-x86_64-with-Ubuntu-18.10-cosmic

Hello! Thank you for the report. It seems to be duplicate of https://github.com/mitmproxy/mitmproxy/issues/3397


Problem with RDMAvsTcpBenchmark of DiSNI over SoftRoCE

Hello,
After a hard and long time spent trying to compile Soft-iWARP (without success), I found a module RXE (kernel: 4.9.0-8-amd64) and Soft-RoCE that works without any problems (sudo apt-get -t stretch-backports install rdma-core ibverbs-providers ibverbs-utils libibverbs-dev librdmacm-dev).
I've successfully compiled and installed DiSNI on the virtual machines (Debian on VirtualBox).
The basic, simple example (com.ibm.disni.examples.SendRecv*) works like a charm.
However, I have problem with com.ibm.disni.benchmarks.RDMAvsTcpBenchmark*
Sometimes it finishes as it should, sometimes it hangs. I've added some diagnostic outputs in the classes, and sometimes it hangs after 2000 iterations of the RDMA loop, sometimes after 1942 iterations and so on.
Then I have also changed the value that is being send. Client sends current iteration number, server sends the minus current iteration number. The received value is not always the next expected value (eg. 0, 1, 1, 3, 3, 4, ... or -1, -2, -4, -5, -5, -6, -7, -8, -9, ...)
I does not have a clue, where I should look what causes the problem so I'm unable to find a solution.
Best regards,
Marek
---cut---
server-101$ java -cp disni-2.0-jar-with-dependencies.jar:disni-tests.jar com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkServer -a <IP_ADDRESS> -k 3000
client-102$ java -cp disni-2.0-jar-with-dependencies.jar:disni-tests.jar com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkClient -a <IP_ADDRESS> -k 3000

...
jstack prints (GC and other JVM threads ommited) on the server:
"main" #1 prio=5 os_prio=0 tid=0x00007f577800a800 nid=0x773 waiting on condition [0x00007f577fa75000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000000f5c061f0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
        at java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:403)
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkServer.runRDMA(RDMAvsTcpBenchmarkServer.java:116)  # clientEndpoint.getWcEvents().take();
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkServer.launch(RDMAvsTcpBenchmarkServer.java:159)
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkServer.main(RDMAvsTcpBenchmarkServer.java:48)
"Thread-1" #10 prio=5 os_prio=0 tid=0x00007f5778189000 nid=0x784 runnable [0x00007f57575bc000]
   java.lang.Thread.State: RUNNABLE
        at com.ibm.disni.verbs.impl.NativeDispatcher._getCqEvent(Native Method)
        at com.ibm.disni.verbs.impl.RdmaVerbsNat.getCqEvent(RdmaVerbsNat.java:165)
        at com.ibm.disni.verbs.IbvCompChannel.getCqEvent(IbvCompChannel.java:77)
        at com.ibm.disni.RdmaCqProcessor.run(RdmaCqProcessor.java:120)
        at java.lang.Thread.run(Thread.java:748)
"Thread-0" #9 prio=5 os_prio=0 tid=0x00007f57781f2800 nid=0x783 runnable [0x00007f575c1c8000]
   java.lang.Thread.State: RUNNABLE
        at com.ibm.disni.verbs.impl.NativeDispatcher._getCmEvent(Native Method)
        at com.ibm.disni.verbs.impl.RdmaCmNat.getCmEvent(RdmaCmNat.java:193)
        at com.ibm.disni.verbs.RdmaEventChannel.getCmEvent(RdmaEventChannel.java:75)
        at com.ibm.disni.RdmaCmProcessor.run(RdmaCmProcessor.java:68)
        at java.lang.Thread.run(Thread.java:748)

on the client:
"main" #1 prio=5 os_prio=0 tid=0x00007f274000a800 nid=0x748 waiting on condition [0x00007f2749ece000]
   java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x00000000f5c24ab0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
        at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
        at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
        at java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:403)
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkClient.runRDMA(RDMAvsTcpBenchmarkClient.java:115)  # endpoint.getWcEvents().take();
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkClient.launch(RDMAvsTcpBenchmarkClient.java:156)
        at com.ibm.disni.benchmarks.RDMAvsTcpBenchmarkClient.main(RDMAvsTcpBenchmarkClient.java:46)
"Thread-1" #10 prio=5 os_prio=0 tid=0x00007f2740209800 nid=0x759 runnable [0x00007f26f9bf4000]
   java.lang.Thread.State: RUNNABLE
        at com.ibm.disni.verbs.impl.NativeDispatcher._getCqEvent(Native Method)
        at com.ibm.disni.verbs.impl.RdmaVerbsNat.getCqEvent(RdmaVerbsNat.java:165)
        at com.ibm.disni.verbs.IbvCompChannel.getCqEvent(IbvCompChannel.java:77)
        at com.ibm.disni.RdmaCqProcessor.run(RdmaCqProcessor.java:120)
        at java.lang.Thread.run(Thread.java:748)
"Thread-0" #9 prio=5 os_prio=0 tid=0x00007f2740202000 nid=0x758 runnable [0x00007f26f9cf5000]
   java.lang.Thread.State: RUNNABLE
        at com.ibm.disni.verbs.impl.NativeDispatcher._getCmEvent(Native Method)
        at com.ibm.disni.verbs.impl.RdmaCmNat.getCmEvent(RdmaCmNat.java:193)
        at com.ibm.disni.verbs.RdmaEventChannel.getCmEvent(RdmaEventChannel.java:75)
        at com.ibm.disni.RdmaCmProcessor.run(RdmaCmProcessor.java:68)
        at java.lang.Thread.run(Thread.java:748)

Attaching output and modified files:
vbox-101.txt
vbox-102.txt
RDMAvsTcpBenchmarkServer.java.txt
SendRecvClient.java.txt
SendRecvServer.java.txt
RDMAvsTcpBenchmarkClient.java.txt

@petro-rudenko Can you take a look at this?

Interesting - reproduce on my environment. So overall barrier is working - it sending after receiving. The issue with stall data on some iterations:
RDMA: 0 < 301
recv    0
send    0
RDMA: 1 < 301
recv    0
send    -1
RDMA: 2 < 301
recv    2
send    -2

Checking.

@faramir thanks, can you please call postRecv.execute() after endpoint.getWcEvents().take(); like in #38 PR. With it got consistent result.

Thank you @petro-rudenko . Results are consistent now.
However, I'm still facing problem with the occasional deadlock. Eg. server sends -1195 and waits for receiving message by client, and the client sends 1196 and waits for receiving message by server... Are you able to reproduce also this issue?
        /* Server */
        for (int i = 0; i < loopCount + 1; i++) {
            // Recv PING
            clientEndpoint.getWcEvents().take();
            postRecv.execute();
            System.out.println("recv\t" + recvBuf.asIntBuffer().get(0));
            recvBuf.clear();

            //Send PONG
            sendBuf.asIntBuffer().put(0, -i);
            System.out.println("send\t" + sendBuf.asIntBuffer().get(0));
            postSend.execute();
            clientEndpoint.getWcEvents().take();
            sendBuf.clear();
[server-101.txt](https://github.com/zrlio/disni/files/2679288/server-101.txt)
[client-102.txt](https://github.com/zrlio/disni/files/2679289/client-102.txt)

        }

        /* Client */
        for (int i = 0; i < loopCount + 1; i++) {
            // Send PING
            sendBuf.asIntBuffer().put(0, i);
            sendBuf.clear();
            System.out.println("send\t" + sendBuf.asIntBuffer().get(0));
            postSend.execute();
            endpoint.getWcEvents().take();

            // Recv PONG
            endpoint.getWcEvents().take();
            postRecv.execute();
            System.out.println("recv\t" + recvBuf.asIntBuffer().get(0));
            recvBuf.clear();
        }

server$ java -cp disni-2.0-jar-with-dependencies.jar:disni-tests.jar com.ibm.disni.benchmarksDMAvsTcpBenchmarkServer -a <IP_ADDRESS> -k 3000
client$ java -cp disni-2.0-jar-with-dependencies.jar:disni-tests.jar com.ibm.disni.benchmarksDMAvsTcpBenchmarkClient -a <IP_ADDRESS> -k 3000

Example output files atteched.
client-102.txt
server-101.txt

I haven't looked at the RdmavsTcpBenchmark in too much detail, but a quick glance made me wonder if there is not a bug with the receive posting. I think the receive at the client should always be posted prior to sending a request. Moving the receive posting just before reaping the event it not enough, the response might already have come back.

What I have just seen (in the output client-102.txt and server-101.txt): on the server, just before freeze, it "received" two times the same value:
RDMA: 1193 < 3001
recv    1193
send    -1193
RDMA: 1194 < 3001
recv    1194
send    -1194
RDMA: 1195 < 3001
recv    1194
send    -1195

while on the client it sends the right values:
RDMA: 1193 < 3001
send    1193
recv    -1193
RDMA: 1194 < 3001
send    1194
recv    -1194
RDMA: 1195 < 3001
send    1195
recv    -1194
RDMA: 1196 < 3001
send    1196

One of the interesting recording of this problem is available here: https://youtu.be/QSt9wZqkloo (after a while, just before freezing, client received next notification and go one step forward).

For me doesn't reproduce, but yes try as @patrickstuedi suggested. Client:
 for (int i = 0; i < loopCount + 1; i++) {
            System.err.println("RDMA: " + i + " < " + (loopCount + 1));

            postRecv.execute();
            // Send PING
            sendBuf.asIntBuffer().put(0, i);
            sendBuf.clear();
            postSend.execute();
            System.out.println("send\t" + sendBuf.asIntBuffer().get(0));
            wc = endpoint.getWcEvents().take();

            // Recv PONG
            wc = endpoint.getWcEvents().take();
            System.out.println("recv\t" + recvBuf.asIntBuffer().get(0));
            recvBuf.clear();
        }

I tried it. Unfortunately, the freezing is still there.
I decided to do simpler test - Client sends only messages to Server, Server receives only messages. That test also lead to deadlock.
/* Client */
for (int i = 0; i < loopCount + 1; i++) {
    System.err.println("RDMA: " + i + " < " + (loopCount + 1));
    // Send PING
    sendBuf.asIntBuffer().put(0, i);
    sendBuf.clear();
    System.out.println("send\t" + sendBuf.asIntBuffer().get(0));
    postSend.execute();
    endpoint.getWcEvents().take();
}

/* Server */
for (int i = 0; i < loopCount + 1; i++) {
    System.err.println("RDMA: " + i + " < " + (loopCount + 1));
    // Recv PING
    postRecv.execute();
    clientEndpoint.getWcEvents().take();
    System.out.println("recv\t" + recvBuf.asIntBuffer().get(0));
    recvBuf.clear();
}

I've tried to invoke clientEndpoint.postRecv(clientEndpoint.getWrList_recv()) instead of using postRecv variable every time in the loop, and to invoke free() after execution, but all those attempts do not help - freeze is still there.

Is there any size limit ?
when I run RDMAvsTcpBenchmarkClient -a IP -k 3000 -s 16384,
RDMA result:
Total time: 1363.831266 ms
Bidirectional bandwidth: 0.06712907722339899 Gb/s
Bidirectional average latency: 0.454610422 ms
TCP result:
Total time: 1800.555879 ms
Bidirectional bandwidth: 0.05084692757541461 Gb/s
Bidirectional average latency: 0.600185293 ms
when I run RDMAvsTcpBenchmarkClient -a IP -k 3000 -s 32768,
blocked at RDMAvsTcpBenchmarkClient::client channel set up
RDMAvsTcpBenchmarkServer -a IP -k 3000 -s 32768
blocked at RDMAvsTcpBenchmarkClient::client channel set up
PS: Linux 5.0.2 soft-roce


Fix linux LD_LIBRARY_PATH

For issue #14

Possible there is a better way that doesn't include the ./generated/0.0.1/linuxpart, just dunno too much about gyp :worried:

Thanks!


Update v1 OpenAPI specification

Expand option is not documented for balance, without we you cannot see balance also sdks doesn't have that option
{
    "cursor": {
        "pageSize": 15,
        "hasMore": false,
        "data": [
            {
                "users:001:coupons": {}
            },
            {
                "users:001:credit": {}
            },
            {
                "users:001:debit": {}
            }
        ]
    }
}

After that
{
    "cursor": {
        "pageSize": 15,
        "hasMore": false,
        "data": [
            {
                "users:001:coupons": {
                    "EUR/2": 5000,
                    "USD/2": 1000
                }
            },
            {
                "users:001:credit": {
                    "EUR/2": 5000,
                    "USD/2": 1000
                }
            },
            {
                "users:001:debit": {
                    "EUR/2": 5000,
                    "USD/2": 1000
                }
            }
        ]
    }
}

Hello @cv65kr,
Thank you for your contribution!
The Ledger V1 API does not provide an expand field. It has been introduce in Ledger V2 whose API spec is in the V2.yml file.
Which version of the Ledger have you tested your expand call with?

Hi @Shiroy v2


Removing the --write-annotations option

The --write-annotations option was created for the purpose of saving the overlaid annotations that used to exist on YouTube videos in an .annotations.xml file. However, YouTube deprecated their annotations feature in 2017 and later removed annotations from all existing videos in early 2019.
To my knowledge the option serves no purpose today, so it should be okay to either deprecate it or remove it outright. This would allow for some cleanup throughout the code and documentation where annotations are currently mentioned.

This would allow for some cleanup throughout the code and documentation where annotations are currently mentioned.

There really isn't much cleanup that can be done in the code by deprecating this. The only thing that changes is that it will no longer appear in the docs


Add updated Drupal info to Vite article

The Issue

@mortona42 provided infos about Drupal https://github.com/mandrasch/my-ddev-lab/issues/2, thx!

How This PR Solves The Issue

add info to Vite article

Manual Testing Instructions
Automated Testing Overview

Related Issue Link(s)
https://github.com/mandrasch/my-ddev-lab/issues/2
Release/Deployment Notes

Awesome, will pull when you say.

Ok!


(WIP) enable auto reload without livereload

Added a grunt task to (re)load the app automatically.
Unfortunately, livereload is not well-supported on platforms other than Mac:

Windows version is still alpha (and I don't want to develop on it).
For Linux, only guard-livereload is available, which is no more maintained.

So I looked for a way to make grunt automatically reload the app without livereload,
then found one to use Chrome's --load-and-launch-app= option.
According to the doc, Chrome just reloads the app when already launched.
That is, it is possible to reload automatically by executing google-chrome --load-and-launch-app=app/ continuously by grunt watch.
That's why I sent this pull request.
But there's a problem I have to discuss with you:
I should extract some variables to be more flexible or DRY (as written as TODOs).
But where should I put the variable? The top level of Gruntfile or other?
I'm sorry but I'm new to grunt.
I'm glad if you give me some advice!
Thanks!

Can one of the admins verify this patch?

test this please

Sorry, I found the added tasks doesn't work well, and I'm actually satisfied without the tasks.
So I'll close.
Thanks for reviewing.


EHealth-1246: delete user tokens

Changes Unknown when pulling c6ba575119595dfe07d81317dca26c4aec3aa7ee on EHealth-1246 into ** on master**.


Sub-Categories do not display/navigate correctly in Storefront.

What I'm trying to achieve
Trying to organize some products into subcategories.
Steps to reproduce the problem
Using Saleor version 2.11

Create categories with subcategories, then place products in the subcategories.  I did this via GraphQL.
In the storefront, click on a Category which contains a Subcategory.

What I expected to happen
When clicking on a top level category, I expected to see its sub-categories.
When clicking on a sub-category, I expected to see the products within it.
What did happen:
When I click on a category, the sub-categories are not displayed, instead I see products from within sub-categories displayed as if they were in the parent.
When I click on a product, the product page is displayed, but the breadcrumb is not right: It displays the sub-category name as if it was the parent category, eg. "Home > Subcategory" rather than the expected "Home > Category > Subcategory".
BUT if I click on the sub-category name in the above breadcrumb, it displays a page which correctly shows what I expected to see initially:  A bread crumb in the form "Home > Category > SubCategory", with the items that are assigned to the subcategory displayed below.
Using GraphQL I've looked at the data for category and product, it looks correct.  I've attached this information.
It seems there is a bug in the category display logic of the storefront when subcategories are used.
Screenshots

System information
Operating system: Server Debian 10, Browser Windows 10
Browser: Firefox 89.0.1 (Also tried Chrome 91, same results)
categories,.txt
product.txt
Thanks!
PS: In addition to this issue, it also seems that within the Dashboard, when trying to change the category of a product that is in a sub-category, when clicking.. only the current setting is displayed and it's not possible to select another category.  This is not currently a problem for me because my catalog is being configured via graphql, but it does seem broken.  I will submit this as another issue under saleor-dashboard if it is helpful.  Thanks!

I have tried this with version 3.0 and the behavior is the same.


/size endpoint which only calculates the image size

GET /size/id/a/b/c?/d?
Response (200):
{
    "width": 1337,
    "height": 3232
}

Closed due to this being implemented in https://github.com/dangeredwolf/FixTweet/pull/12.


Bump containerd to v1.4.9-k3s1

Proposed Changes
Bump containerd to v1.4.9-k3s1
Types of Changes
containerd
Verification
kubectl get nodes -o wide; check containerd version
Linked Issues

#3853

User-Facing Change

The embedded containerd has been updated to v1.4.9-k3s1

Further Comments

Codecov Report

Merging #3858 (42833c0) into master (a109798) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3858   +/-   ##
=======================================
  Coverage   11.60%   11.60%
=======================================
  Files         136      136
  Lines        8831     8831
=======================================
  Hits         1025     1025
  Misses       7582     7582
  Partials      224      224

Flag
Coverage Δ

inttests
0.69% <ø> (ø)

unittests
11.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a109798...42833c0. Read the comment docs.


Problem with login

Request:
client.login().then(console.log)
Response from instagram:
{ authenticated: false, user: true, status: 'ok' }
But not signed in
Why?

Facing the same issue. I think Instagram has introduced another set of security measures.  Instagram login page calling an event on visiting the insta login page logging_client_events . I think it is causing the block.

Are you still dealing with this issue ? If not can you close this issue please ?

Are you still dealing with this issue ? If not can you close this issue please ?

Has anyone solved this problem?


Frames don't close if an exception occurs

To reproduce:

Run

(define (loop x)
  (if (= x 0)
      (/ 1 0)
      (loop (- x 1))))
(loop 2000)

in a new file

Run (define x 5) in the console
Open the environment viewer and hit "finish executing the program"

Expected:
The global frame should be open with x = 5
Actual:
2000 other frames are open.
Fix:
Add a client-side check to skip over frames from a previous execution that have closed. Perhaps look at their most recent assignment, and compare it to start_i of the present expr?

Resolved by #68 .


fix: Jhont/test/outdated packages

Fixes #
#minor
Description

Specific Changes

Testing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.062%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.4%

Covered Lines:
20353

Relevant Lines:
22913

💛  - Coveralls


list slice() produces seg fault

[1,2]->slice(0,1) produces a segmentation fault. Furthermore, a few list functions, including extend and sort, return undef where they should have a list value
Valgrind
==1230116==  Access not within mapped region at address 0x0
==1230116==    at 0x41CE12: inc_strong_ref (refcount.c:38)
==1230116==    by 0x41CE8E: inc_ref (refcount.c:60)
==1230116==    by 0x417933: vm_push (VM.c:142)
==1230116==    by 0x419B19: vm_NEWSPECIALSTR (VM.c:613)
==1230116==    by 0x41A5F7: vm_INIT_MC_SPECIAL (VM.c:733)
==1230116==    by 0x41C0DB: vm_run (VM.c:1090)
==1230116==    by 0x402164: YASL_execute (yasl.c:148)
==1230116==    by 0x403429: main_file (main.c:67)
==1230116==    by 0x403723: main (main.c:163)

list.slice should have been removed a long time ago. It was replaced with built-in syntax: ls[start:end] to match indexing.
list.extend and list.sort work in place, so they intentionally don't return any values.


Agent Type: Arbitrageur

In the /arbiter/crates/simulate/src/ directory, implement an Arbitrageur trait for agents.

[x] Consume and monitor events #142
[ ] Send swaps based on events using the agent call_data()

Looking at the structure. Lets tackle this next. We can put it in the agent module.

I can think of some ways we can accomplish this. Let me outline an idea for a SimpleArbitrageur:

[ ] The SimpleArbitrageur struct should have two pools/exchanges (addresses, properties) and store their current prices.
[ ] Spawn two threads that listen to prices on each pool. As each price changes, record the new prices.
[ ] Compute the price differences between each pool after each price change and determine if this difference surpasses the no-arbitrage bounds.
[ ] When a large enough price is detected, compute the optimal arbitrage quantity.
[ ] Build and execute two transactions to capture the arb.
[ ] Store the information over execution history so we can record the simulation.


Update install instructions to match the minimum version for examples

The suggested version in the README does not match the API currently used on the examples.
Compiling client-go/examples/out-of-cluster-client-configuration/main.go fails if one follows the instructions on the README.md. The minimum compatible version is<EMAIL_ADDRESS> This was fixed by updating to the latest release (v0.19.0) in #851
Closing this PR, but thanks again! :pray:


Delete pairsToMultiParams from CollectionCompat traits

#4310 merged cleanly into 0.22, but we should still mop it up. Note that in 0.22, there's a new, third copy in src/main/scala-3.
Leaving for @valencik, since he started these.

seems like this one was done and merge. thanks again!


Change value of color variable "madang"

new hex code for madang: #78EB81

@myueksel Please change the hex value on GitHub directly

pull request is done


Drilldown Menu with Responsive Toggle Has Wrong Height After Reopening

I have a Drilldown Menu inside of a Top Bar with a Responsive Menu toggle. The first time you open the menu, it is the correct height. But if you open the menu, navigate to a submenu that is taller, navigate back to the root menu, then close and open the responsive menu, the Drilldown will now have the wrong height (the taller height of the submenu). I am using auto height.
What should happen?
The Drilldown menu's height should match the (sub)menu displayed.
What happens instead?
The height matches the submenu instead of the displayed menu.
Possible Solution
See commit below.
Test Case and/or Steps to Reproduce (for bugs)
Test Case: https://codepen.io/anon/pen/vwabWK
How to reproduce:

Shrink window to display Title Bar on small screen size.
Open the menu.
Click link "One" to open submenu.
Go back to the main menu.
Open and close the menu using the hamburger icon, and see that the main menu is now too tall.

Your Environment

Foundation version(s) used: 6.5.3

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one.
[x] The issue title and template are correctly filled.

Hi @Buddierdl,
Thanks for reporting this.


Q: changes on model

I'm trying to add a reset button to my forms therefore I need to detect changes on the model. I hope ember-cp-validation can help here as that automatically validates properties anyway, maybe I can hook into something...?

@basz I do not believe this library provides such a hook. I suggest looking into the following addons:

ember-time-machine
ember-buffered-proxy
ember-changeset + ember-changeset-cp-validations

Thanks! Perfect


1322887   document   updates

Please review

Docs Build status updates of commit bb574a2:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/tabs/design/tabs.md
:warning:Warning
View
Details

msteams-platform/tabs/design/tabs.md

Line 195, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/what-are-bots#in-a-one-to-one-chat' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 47cc6af:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/tabs/design/tabs.md
:warning:Warning
View
Details

msteams-platform/tabs/design/tabs.md

Line 195, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/microsoftteams/platform/bots/what-are-bots#in-a-one-to-one-chat' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Necessity of Autostart

Hi,
Would it be possible to take the drone off manually, switch to pos-hold, switch to guided/offboard, and then run the MRS code as usual, essentially bypassing the autostart altogether?

Found an option in the config file. Sorry for the confusion

Yes, there are multiple ways. If you want to take off by service, you can set handle_takeoff: false in the autostart's config. You still need to arm the drone and switch to offboard using a transmitter (service in the simulation), but then the takeoff can be triggered by uav_manager/takeoff service. Alternatively, there is the option to takeoff fully-manually using an RC control and switch the system in mid-air. That is call midair activation and can be triggered by the uav_manager/midair_activation service. Just beware, when you do that, the system will go into the offboard mode automatically. So it is a good practice to pre-set the offboard switch into the "on" position before you activate that service.

Thank you, Tomas, for the detailed response.
We tried to do a midair activation, but the pixhawk refused to switch to offboard. Is there any particular px4 param that must be set before the midair activation?
In addition to this, we also tried to take off directly with the autostart, however, the motor-thrust behavior was concerning. We have applied the proper motor-thrust values as per the MRS documentation. Since we are not using a rangefinder, I was wondering if the behavior seen is because of that. (We are using GPS-baro)
https://github.com/user-attachments/assets/eec0fdc2-b663-48a8-9dbf-79f6e9076542
The log analysis did not raise any concerning errors either.
PS: We are really excited to work with your vast framework. Thank you for making it open source and for all the support to the framework.

@johnd2010 thanks for providing all the data! Yes the video suggest there is something wrong. I will check that soon. I would recommend to wait till I get back to you.
Regarding the midair activation: No, there is nothing to be set on the PX4 side. From the PX4 Point-of-view, nothing special happens. Do you have the "tmux logs" from that flight as well?

Thank you Tomas,
The logs have been uploaded here
https://drive.google.com/drive/folders/1nGns4tBBWTW7FV5b54aPlwPy_dMc4zCe

Hi Tomas,
We had the opportunity to try out one more time and we increased the param value max_position_difference of the land_off_tracker from 0.7 to 1.0
Upon this change, the take off was smooth. Can you please let us know if this value is reasonable or if there is a safer way to achieve this by tuning a different param ?
In the context of mid air Activation, is there a default waiting period for the control switch from pos_hold to offboard?
Thanks again, for all the support


Allow unlimited

… to default the limit to 10 twice in the same conditional, we have effectively eliminated limit=0 and so every use of paginate MUST be paginated.  It is now possible to say limit=0 in a query param to override the APIs limit

Coverage increased (+2.8%) to 96.774% when pulling 555db1b17f3bfd1fb2388b8e07ba4cd9765d0e4c on chadfurman:bugfix/allow-unlimited into efc935d19fd92043e588f690b848de0ab86d57b4 on expressjs:master.

@chadfurman can you write a quick example of that use case?

Coverage increased (+2.8%) to 96.774% when pulling 804f61049ba740129027fe4fb3dccddf2c445ca0 on chadfurman:bugfix/allow-unlimited into efc935d19fd92043e588f690b848de0ab86d57b4 on expressjs:master.

Sure.
  var index = function(req, res, next) {
    var filter  = {};
    var options = {
      page:  req.query.page || 1,
      limit: req.query.limit || 20;
      lean:  true
    };

    if (req.query.interview) {
      filter.interview = new ObjectId(req.query.interview);
    }

    if (req.query.recording) {
      filter.recording = req.query.recording === 'true';
    }

    Media.paginate(filter, options, function(err, media, pageCount) {
      if (err) {
        next(err);
      } else {
        res.json({
          object:   'list',
          has_more: paginate.hasNextPages(req)(pageCount, media.length),
          data:     media
        });
      }
    });
  };

There is no way that I can query this index endpoint without having a limit imposed on me by the middleware.  I cannot, in the front end, set the limit to 0 with a query parameter.
This PR fixes that.

For security reasons, I had that hard limit on pagination.  Does this allow users to simply modify the querystring to have ?limit=0 and get infinite results?  If so, this is a security issue.

Otherwise we'd need to document how to impose limits using the ratelimit package.

It does allow ?limit=0 to get infinite results.

That's a security issue, I can't accept
On Apr 6, 2016 1:07 PM, "Chad Furman"<EMAIL_ADDRESS>wrote:

It does allow ?limit=0 to get infinite results.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/expressjs/express-paginate/pull/19#issuecomment-206467827

Hey! Just peering in as the discussion seems interesting.

Otherwise we'd need to document how to impose limits using the ratelimit package.

Sure, isn't that up to developers and not really on scope of this package? :-)

That's a security issue

Isn't it rather a performance issue?
Cheers!

okay, I'll accept, good argument @simison /cc @chadfurman

Released v0.2.0 and added note to Readme.

👍  Keep up the good work everyone.
@niftylettuce seeing your nick+avatar on my Github feed always makes me smile!

Ah, +1 for the mention of the "All" option in the dropdown!


Use %ProgramFiles% and %LocalAppData% to locate chrome.exe more critically

Because Program Files folder and Program Files (x86) folder are not always under C: drive,
and Local folder is not always under %UserProfile%\AppData.

@mvdan
Hi, I've added fall-back paths with C:\ and %UserProfile%.
According to documentation, the result of filepath.Join is always Cleaned, which does not contain extra slash on the right.

Sorry, but I didn't mean duplicating the entries. For each one of those, you check the var version if the var is defined, otherwise you check the older hard-coded path we have in master.

Also, I know that filepath.Join cleans. But Join(foo, "bar") is still simpler than Join(foo, "/bar")

In my opinion, findExecPath makes a best-effort to find the browser. It does not have to cover all cases. The users can always use chromedp.ExecPath to specify the path if findExecPath does not work. Closing.


Logic issue for llm.openai/vector.enabled()

Affected version(s): Only affects 1.7.4
Introduced in https://github.com/grafana/grafana-experimental/pull/90
Currently we returning the healthcheck details when we call llm.openai.enabled() or llmvector.enabled().
But we check !enabled which always returns true.
We should change the enabled logic in grafana-experimental, so it return the correct value.
We should maybe change the current enabled logic to be healthCheckDetails.

Thinking we can go with an alternative instead, which is update all other LLM features to use the 1.7.4+ approach
Leaning towards that as an easier route since we don't need to release a new version of grafana-experimental and bump it.
We also already have one feature using the 1.7.4 approach (dashboard AI), so would need to change that back if we modify this. Will update llmexamples-app to show the new approach


Specify IPAMConfig when creating a IPvlan network

Before you start, we need a little bit more information from you:
Use Case (delete as appropriate): Using Portainer at Home
Have you reviewed our technical documentation and knowledge base? Yes

Question:
I am trying to create a network with the following configuration through portainer
networks:
  my_ipvlan_net:
    driver: ipvlan
    driver_opts:
      parent: enX0
      ipvlan_mode: l2
    ipam:
      config:
        - subnet: <IP_ADDRESS>/24
          gateway: <IP_ADDRESS>

How can I specify the IPAM options?

The options in driver_opts can be added by clicking Add driver option and filling in the fields. Your subnet and gateway are configured in the IPV4 Network configuration section.

Thank you @jamescarppe.


HDDS-1582. Fix BindException due to address already in use in unit tests. Contributed by Mukul Kumar Singh.

The fix is to use Socket.bind in place of server sockets. The biggest difference is that ServerSocket will do accept and listen after binding to the socket and this will keep the sockets in TIME_WAIT state after close. Please refer, https://docs.oracle.com/javase/tutorial/networking/sockets/definition.html

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
65
Maven dependency ordering for branch

+1
mvninstall
605
trunk passed

+1
compile
286
trunk passed

+1
checkstyle
69
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
867
branch has no errors when building and testing our client artifacts.

+1
javadoc
149
trunk passed

0
spotbugs
310
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
513
trunk passed

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

+1
mvninstall
513
the patch passed

+1
compile
272
the patch passed

+1
javac
272
the patch passed

-0
checkstyle
35
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
93
patch has no errors when building and testing our client artifacts.

+1
javadoc
145
the patch passed

+1
findbugs
533
the patch passed

_ Other Tests _

-1
unit
181
hadoop-hdds in the patch failed.

-1
unit
1863
hadoop-ozone in the patch failed.

+1
asflicense
48
The patch does not generate ASF License warnings.

9128

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.container.common.impl.TestContainerPersistence

hadoop.ozone.om.TestScmSafeMode

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/844

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 980db0d9713b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a315913

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/testReport/

Max. process+thread count
5058 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-844/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


add Dataflow notifications

I think we also need some settings for FCM_DJANGO, like
FCM_DJANGO_SETTINGS = {
    "APP_VERBOSE_NAME": ".............",
    "ONE_DEVICE_PER_USER": False,
    "DELETE_INACTIVE_DEVICES": True,
    "UPDATE_ON_DUPLICATE_REG_ID": True,
}
FIREBASE_PROJECT_ID = env.str("FIREBASE_PROJECT_ID")


Big scrape 2023

The last big scrape was completed in March 2022. This is a tracking bug for a fall 2023 big scrape, which I am assigning to myself.
Modulo issues discussed in #507 and #508 everything seems to be working.

This was completed in #525 just a bit late.


Issue 126 - New Terraform modules for VPN and VWAN brownfield scenarios

Overview/Summary
Initial release of updated Terraform modules for AVS deployments for VPN and VWAN.
This PR fixes/adds/changes/removes

Adds new Terraform content for AVS deployments including VPN and VWAN

Breaking Changes

None

Testing Evidence

Deployed each module in the GBB subscription.  Requesting additional reviewers as part of the pull request feedback.

As part of this Pull Request I have

[ ] Checked for duplicate Pull Requests
[ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated relevant and associated documentation.

@ScottHolden  kindly check this

Hello @rvandenbedem  Could you please review this and approve. Jon and I have tested. We had few other colleagues also tested.

#sign-off


Removing bower_components and fixing typo

@sayedihashimi I've found this advice about it, but do you have a more official URL handy for us to point to?

Adding @madskristensen and @DamianEdwards who were more involved in the discussion regarding this than I was.

th

There are basically two workflows we want to support going forward:

 People reference ./wwwroot/lib/bower_components directly (this is also how our default template is configured too)

 People use build steps to copy files under bower_components to ./wwwroot

We don’t want to special case bower_components for SCC since for workflow #1, people would want to check in ./wwwroot/lib/bower_components.

@shiftkey, does Barry's comment  address your concerns?

@balachir :thumbsup:

..

hi guys I would like to learn as much about what is going on and how I we meaning my kids as this is the reason I am doing this although this is very exciting and one day when I can make a game that my children will play and tell there friends that my dad made this I can not wait thanks for this to all the pioneers who layed the ground work that's all for now

Secund tool sbyte soget in body take only setup so var stage info tecnology process


Polish up pulsar plugins to remove unnecessary dynamic value , set peer at consumer side

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

Set peer at consumer side
remove unnecessary dynamic value , instead to get field through consumer/producer(this) object  .

In  pulsar serviceUrl means a cluster , and  pulsar support   cluster-level failover , so It's inappropriate to hold serviceUrl as  it might be updated , Refer to  https://pulsar.apache.org/docs/client-libraries-java .
I'm  sure that my  code format style is correct .I  formatted a little code follow current style  ,   Thanks

@codelipenghui Could you recheck this? We are formatting the peer and MQ tags for this new dashboard.
https://skywalking.apache.org/docs/main/next/en/setup/service-agent/virtual-mq/

In pulsar serviceUrl means a cluster , and pulsar support cluster-level failover , so It's inappropriate to hold serviceUrl as it might be updated , Refer to https://pulsar.apache.org/docs/client-libraries-java .

As it is updated in time, so, we may have different cluster addresses when Pulsar cluster scales out

I think cluster-level failover  is not   scales out .
For  cluster-level failover  , we organize each cluster to a service , it's clear .
For  a cluster , It's inevitable if the cluster changed  whether  automatically or manually .


implemented flush method for AsynchronousLogstashHandler

Hi!
I want to resolve #13  issue.
I'll be glad to hear some feedback from you.
Thank you!

Unfortunately, it's not that easy :(.
LogProcessingWorker is a seperate thread but you call force_flush_queued_events from the main thread (or any other thread in your application) and the further flush operation is processed within this thread instead of the LogProcessingWorker thread which is dedicated for these operations.
In the best case this could lead to locking issues (when two threads try to operate on the same queue), in the worst case really bad things might happen.
The queue handling as well as the other logic in LogProcessingWorker should be kept in the seperate thread.
My suggestion is to use a new Event and handle it similarly to the existing shutdown_event:

add a flush_event attribute to LogProcessingWorker
set the event in the force_flush_queued_events method
in https://github.com/d1skort/python-logstash-async/blob/93fcc1cf681956ad9fbad33e385a54305fa84949/logstash_async/worker.py#L112 add a check like the one for shutdown_event, e.g.:

    force_flush = self._flush_requested()
    self._flush_queued_events(force=force_flush)

in _flush_queued_events clear the event (with self._flush_event.clear())

This method should be thread-safe, I think.

wow, thanks for review!
I totally get it, if you don't mind, I will finish this PR :)

Sure, cool!

Thanks!

Thanks for your work. I'll add a note to the docs about this feature soon.


Support arbitrary Hadoop filesystem for output

It would be useful to be able to run Eggo to write outputs to HDFS or the local filesystem (for testing). Currently, only S3 is supported.
This might be a bit more involved than simply changing URLs, since Luigi has different types of target for different filesystems, e.g. S3FlagTarget vs. HdfsTarget vs. LocalTarget. Also, the use of aws cp should be replaced by hadoop fs -put.

This also has the benefit of not needing the AWS CLI to be installed on all nodes in the cluster (currently installed via fab setup_slaves).

See PR at https://github.com/bigdatagenomics/eggo/pull/49


how to add gradient color in stacked bar chart

hello , i would like to add a gradient color in stacked bar chart , anyone know how to implement it?

Hi @akshPairroxz 👋
Thanks for requesting this feature. It is now available in version 1.2.36🎉
Below is a sample Stacked Bar chart.

The code for the above chart is-
const stackData = [
  {
    stacks: [
      {
        value: 10,
      },
      {
        value: 20,
        marginBottom: 2,
      },
    ],
    spacing: 15,
    label: 'Jan',
  },
  {
    stacks: [
      {value: 10},
      {
        value: 11,
        marginBottom: 2,
      },
      {
        value: 15,
        marginBottom: 2,
      },
    ],
    label: 'Mar',
  },
  {
    stacks: [{value: 14}, {value: 18, marginBottom: 2}],
    spacing: 15,
    label: 'Feb',
  },
  {
    stacks: [{value: 7}, {value: 11, marginBottom: 2}],
    label: 'Mar',
  },
];

return <BarChart stackData={stackData} />

Now, just add the prop showGradient to the <BarChart> component, and it results in-

It takes white as the gradient color by default. We can change it using the gradientColor prop.
The different bars can be given different values of gradientColor and color. Similarly, each section of a bar can be given different values of gradientColor and color. Here is an example-

The code for the above chart is-
const stackData = [
  {
    stacks: [
      {
        value: 10,
      },
      {
        value: 20,
        marginBottom: 2,
      },
    ],
    spacing: 15,
    label: 'Jan',
  },
  {
    gradientColor: 'blue',
    stacks: [
      {value: 10},
      {
        value: 11,
        marginBottom: 2,
      },
      {
        value: 15,
        marginBottom: 2,
      },
    ],
    label: 'Mar',
  },
  {
    stacks: [{value: 14}, {value: 18, gradientColor:'green', marginBottom: 2}],
    spacing: 15,
    label: 'Feb',
  },
  {
    stacks: [{value: 7}, {value: 11, marginBottom: 2}],
    label: 'Mar',
  },
];

return <BarChart stackData={stackData} showGradient />

Also, instead of passing the showGradient prop directly to the <BarChart> component, we can pass it to individual bars or bar sections to apply gradient effect only to them.
I hope it helps.🤗

wow , that's great , thanks for the update.


Try to delete potentially dead sockets after a timeout.

@hlaf Thank you!
You might want to look at the v1.0 branch.  I rewrote / cleaned up a lot, and handle cleaning up dead sockets better (the man page is wrong.  ssh-add does not always return 2 when it can't connect to the agent)

@wwalker Don't mention it!
Actually, I should be thanking you for sharing -- and maintaining -- this incredibly useful tool!
Thanks for pointing me to the v1.0 branch, the code is indeed much clearer and the control flow easier to follow (imho).


Docs and demo are down

still down.
If this is an abandoned project PLEASE REMOVE IT FROM GitHub, so as to not waste other people's time.

whoa @ursomniac calm your tits ! are you paying for their time, no? either have a courage to maintain it all by yourself or move on...


Add result aggregation for query templates

The new default behaviour is, that each result from the instances of a query template will be counted as the result of the query template. This is done by forcing the query instances to use the id of the query template in the results.
The query templates are considered as queries as well, but they won't be executed.
The option for this behaviour is individualResults. If this option is turned off, the instances will use their own id respective to
their location, where the queries are stored, for the results. The ids of the query templates need to be changed for this option in that way, that they are the last ids of every query, otherwise problems occur with the result processing. The ids of every other
query need to be pushed forward accordingly, to fill in the gaps.
The serialization of the query instaces needed to be changed as well, so that the query instances can be mapped back to their
templates.
The query handler also needs to differentiate between the number of executable queries and the number of queries, that
will be presented in the results, otherwise, too few queries might be executed.
Todo:

[ ] Tests
[ ] Documentation

Also, the result model probably needs to be changed, so that it includes the relation between query templates and their instances.


Allow customized compile in Aqua algorithms

What is the expected enhancement?
Currently Aqua uses wrapper.compile() in Terra. This function is a bit restrictive as is, because you can only choose to skip_transpiler or go through the default transpiler flow.
We will update this function to take a PassManager argument (Issue #1083 in Terra).
When that is done, can we also update the compile of Aqua to expose this? The skip_transpiler will then just be identical to passing an empty pass manager: pass_manager=PassManager().

@ajavadia  will those passes be initialized by a string name? or anything can be represented in the JSON? I think in the UI we need to have a way to let users configure what passes they would like to use.
I guess this is similar to the issue of the setting of backend #153
@manoelmarques @woodsp-ibm

yes we dont want to do this a string.

From the perspective of easily integrating our library with minimal dependencies, it would be great if the user could define the pass manager and pass it to setup_quantum_backend
(my related comment on terra: https://github.com/Qiskit/qiskit-terra/issues/1083#issuecomment-436963519)


Web View Not Editor  Code

why did get connect filed error?

How can I edit code and  run this in iPad？

The current code is not properly initializing the game view, so the code editor isn't there. This got busted in the last, unfinished wave of refactoring. We'll need to adjust the view hierarchy so that the game view is created whenever you enter a level.


Fuzzy about the function in Observable.swift

Thanks for your time!This project is really awesome!I dont understand the whole meaning of funcs in Observerable.swift,Could you please convert it into some Objective-C style funcs?Many thanks

Hi, it's the Observer pattern.
You can find information here:
https://developer.apple.com/library/ios/documentation/Swift/Conceptual/Swift_Programming_Language/Properties.html#//apple_ref/doc/uid/TP40014097-CH14-ID262
http://blog.scottlogic.com/2015/02/11/swift-kvo-alternatives.html
Happy coding!

Thanks, @vietstone . Can we close this issue now @nice2m ?

@vietstone Thanks a lot !   ;-)

@JakeLin much clearer,and Yes you can handle this issue  you like,Thank you for your time.

Thanks @nice2m


Add a Jenkinsfile to define CI in the repository

This defines the jenkins job configuration in code, in the repository.
Once merged and existing PRs are rebased on this change, the containerd Master and containerd-PRs jobs on jenkins.dockerproject.org can be disabled/deleted.
In the future we can also add improvements like recording test results, etc.

@mikedougherty so I should merge this even though the new ci job failed?

ah, yes indeed.
it failed because it doesn't trust a jenkinsfile from a non-collaborator. once it's in master it should start passing just fine. and that will be visible here: https://jenkins.dockerproject.org/job/docker/job/containerd/job/master/ (currently 404 until it detects the jenkinsfile on the branch).

and we're off to the races :)
https://jenkins.dockerproject.org/job/docker/job/containerd/job/master/1/consoleFull


How to use col.Find

Greetings,
I'm having a heck of a time trying to get the find feature to return true or false or even the results. By the looks of it, it returns null but I still can't get it just quite right. Obviously, I'm doing something wrong here but can't see what it is.
I was trying to get the function to return false if the value is null and true otherwise. I would really like to know how to receive the results of a search? I'm using C#; a complete code example would be quite helpful.
The connection string is in place using a password for encryption.
        using (var db = new LiteDatabase(DBConn(LITEDBROOT, strDBDIME)))
        {
            var col = db.GetCollection<MyDBClass>();
            var customerName = col.Find(x => x.UserName == strUserName && x.DIME.Contains(strDIME));
            // I can see my query in the results view but don't know how to retrieve it and confirm that it is there.
            bool NullX = customerName == null; // Keeps coming up false.
            if (NullX == true)
            {
                // Do nothing
                //MessageBox.Show("Not Found");
                return false;
            }
            else if (NullX == false)
            {
                //MessageBox.Show(customerName.UserName);
                return true;
            }
            return false;
        }

Any help will be appreciated. Thank you in advance.

Hi @BigPacket, Find method returns IEnumerable data type. Will be never null. If you only want if exists or not data, you can use Exists method (return a bool)
using (var db = new LiteDatabase(DBConn(LITEDBROOT, strDBDIME)))
{
    var col = db.GetCollection<MyDBClass>();
    return col.Exists(x => x.UserName == strUserName && x.DIME.Contains(strDIME));
}

I figured I was doing something wrong. This worked well. Thanks so much!


llvmPackages_{10,11}.compiler-rt: restrict build to current arch

Motivation for this change
Fix llvmPackages_10.compiler-rt and llvmPackages_11.compiler-rt on staging-next.
These packages were broken by #114817 (see https://github.com/NixOS/nixpkgs/pull/114817#issuecomment-802709527).
While I'm here, use darwinArch for all compiler-rts, which is a no-op on x86_64-darwin.
I assert this change is correct in that nixpkgs only targets a single architecture at once, so building for extra platforms is unnecessary work. The alternative is to remove the -arch argument from the cc/bintools wrappers (revert fc0456bed1372ccff51fc6fd578e5d2a09d64534, b26e0bac8dab068e54b0c8ee1bf8fd5fe5683b39 and 8feb949ab540130063d1c57db7244024887c4ed9).
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I like this change. If we ever want to support multi-arch stuff, I would make cc-wrapper more clever by e.g. only adding an -arch if none is passed, not reverting those commits :).

#115435 is merged now, should this target some other branch now?

/rebase master


web todo: examples input: autofocus on new input box

When you hit "new" you should get autofocused on the new box. It should save on a click away.
I made the editable table from:
https://devexpress.github.io/devextreme-reactive/react/grid/docs/guides/editing/

Couldn't get it to set the focus, but as a start it creates the new row in editing mode.


id attribute has been removed from tN Introduction to book

This one has an id attribute in production, but not in develop


chore(main): release 1.4.23

:robot: I have created a release beep boop
1.4.23 (2024-06-15)
Miscellaneous Chores

deps-dev: bump phpunit/phpunit from 11.2.0 to 11.2.1 (#150) (ec7bca7)
deps-dev: bump symfony/http-client from 7.0.7 to 7.1.1 (#142) (e5db6ba)
deps: bump symfony/property-access from 7.0.7 to 7.1.1 (#143) (3dca8ac)
deps: bump symfony/serializer from 7.0.7 to 7.1.1 (#144) (ad1a76b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/cedricziel/mattermost-php/releases/tag/v1.4.23 :sunflower:


refactor: unify context in webpack module

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[ ] All new and existing tests are passing.

Codecov Report

Merging #5054 into dev will increase coverage by 0.09%.
The diff coverage is 96.93%.

@@            Coverage Diff             @@
##              dev    #5054      +/-   ##
==========================================
+ Coverage   94.98%   95.08%   +0.09%
==========================================
  Files          72       72
  Lines        2414     2421       +7
  Branches      615      614       -1
==========================================
+ Hits         2293     2302       +9
+ Misses        101       99       -2
  Partials       20       20

Impacted Files
Coverage Δ

packages/webpack/src/config/client.js
96.29% <100%> (+0.46%)
:arrow_up:

packages/webpack/src/config/server.js
100% <100%> (ø)
:arrow_up:

packages/webpack/src/utils/postcss.js
91.83% <100%> (-0.48%)
:arrow_down:

packages/webpack/src/builder.js
94.68% <100%> (ø)
:arrow_up:

packages/webpack/src/config/modern.js
100% <100%> (ø)
:arrow_up:

packages/builder/src/context/build.js
100% <100%> (ø)
:arrow_up:

packages/webpack/src/utils/perf-loader.js
100% <100%> (ø)
:arrow_up:

packages/webpack/src/utils/style-loader.js
94.11% <100%> (-0.17%)
:arrow_down:

packages/webpack/src/config/base.js
95.45% <89.65%> (ø)
:arrow_up:

packages/vue-renderer/src/renderer.js
95.85% <0%> (+1.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9391d7...07f95f8. Read the comment docs.


extended benchmark with dynamic process creation

Although the real world benchmarks contained dynamic process
instantion/creation, it was absent as a primitive.
Added 3 cases.
The expected slowness of non-distinguising output was not observed!
distinguis by order was 10 times slower (so number of steps reduce by
factor of 10)

Appveyor failed twice due to time out while tests did pass, yet caching was not finished yet.


Vscode Neovim runner.

Hi,
Thanks for this amazing plugin. I use Neovim in VS Code  and wrote a simple runner for it.
Please add into the plugin.
if vim.g.vscode then
    -- Custom vim-test Strategy for VS Code Terminal
    -- Runs test commands in the VS Code terminal when using Neovim in VS Code.
    -- Focuses the terminal, clears it, and sends the test command.
    vim.cmd([[
        function! VSCodeStrategy(cmd)
            " Optional: Focus the VS Code terminal
            " call VSCodeNotify('workbench.action.terminal.focus')
            " Clear the terminal
            call VSCodeNotify('workbench.action.terminal.sendSequence', {'text': "clear\n"})
            " Send the test command to the terminal
            call VSCodeNotify('workbench.action.terminal.sendSequence', {'text': a:cmd . "\n"})
        endfunction

    let g:test#custom_strategies = {'vscode': function('VSCodeStrategy')}
    let g:test#strategy = 'vscode'
    ]])
else
    vim.g["test#strategy"] = "vimux"
end

Hi! Thank you for contributing, you can use https://github.com/vim-test/vim-test/pull/766 as a guide for adding a new strategy to the repository. You are most of the way there, just make sure you adhere to code organization and style.
I suggest taking a look at it and https://github.com/vim-test/vim-test/pull/770 to see which options can be reimplemented in your strategy. I would suggest naming it neovim_vscode for consistency.


Parse additional options

Parse classless static routes option 121, 249 using compact address & mask format (from rfc3422)
Parse PXE related options 93, 94 (from rfc4578 & errata)
Parse Stateless autoconfigure option 116  (rfc2563)

printIPaddressCompactMaskAddress may access data outside of the buffer if the option contains malformed data
I will change it to make two passes, verify the data and fallback to a hexdump + message

Please review and test my changes, I have no easy way to test options 121/249

Please review and test my changes, I have no easy way to test options 121/249

`
OPTION: 121 (  9) Classless Static Route    Malformed
f4c0a80204c0a801
fd
OPTION: 249 ( 16) MSFT - Classless route    <IP_ADDRESS>/24 via <IP_ADDRESS>
<IP_ADDRESS>/24 via <IP_ADDRESS>
`
Your changes look good. Correctly detects invalid response.Spacing is correct even though the code insert above doesn't reflect that.
Testing with various invalid data revealed error in my code however, #4  corrects.


Suddenly getting 400 response (bad request)

I've been running this package for about 1 year now. Suddenly (within the last month or two?) all amazon requests return a 400 response (bad request). Not sure if something changed in the API or if my keys were disabled or something?
Any insight would be great!
Thanks

NM! I figured it out, the server date was off so the signature was "expired". Thanks anyway, great package!

Glad you managed to solve this, thank you for using the package!
--

On Thursday, Apr 05, 2018 at 10:13 pm, Brian Mix<EMAIL_ADDRESS>(mailto:notifications@github.com)> wrote:
Closed #21 (https://github.com/JoeDawson/amazon-ecs/issues/21).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/JoeDawson/amazon-ecs/issues/21#event-1559725849), or mute the thread (https://github.com/notifications/unsubscribe-auth/AA9oICoqRN2n0zwkafMNXSm74t7TTNniks5tloj9gaJpZM4TJIXK).


fix(amdTranspiler): Fix exception "Node not found in array"

Would you mind explaining in the commit, what the problem was?
I assume, the fact that the only return statement does not refer to the name (symbol) of the class?

@codeworrior done. Thanks for asking. This made me questioning the code again, as some parts were not covered. Now it should work as expected in all cases.


Add Open Policy Agent CLI

Signed-off-by: yankeexe<EMAIL_ADDRESS>
Add Open Policy Agent CLI for arkade get
Description

Motivation and Context

[ ] I have raised an issue to propose this change (required)

How Has This Been Tested?

Create binary for Linux and installed the OPA.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Hey @alexellis , can you please review this? 🙂

Thanks for the PR @yankeexe - just need a rebase on this please as I've been busy adding new tools into these files.