Retrieve "socket.data" from sockets

https://github.com/socketio/socket.io-admin-ui/blob/main/lib/index.ts#L338-L366
Why is data not included? All custom data are added to socket.data since v4 I believe.

@darrachequesne
I've opened a PR on this matter a while back but I'm stomped, can't seem to make it work.
Could you take a look?
https://github.com/socketio/socket.io-admin-ui/pull/34
Cheers

This was implemented in https://github.com/socketio/socket.io-admin-ui/commit/3773fe4b1cbf2206708e1f21ce65f430a522527f and included in version 0.3.0:


Unit 3 _TLAaron_Shahnam

added a link to my package
https://test.pypi.org/project/lambdata-skhabiri/

created a new repo and uploaded a package based on that:
git hub repo: https://github.com/skhabiri/lambdata_sk
pypi url: https://test.pypi.org/project/lambdata-skproj/

created a new repo with package:
https://test.pypi.org/project/lambdata-skhab/
https://github.com/skhabiri/lambdata

Link to repo:
https://github.com/skhabiri/lambdata
####################
Link to package:
https://test.pypi.org/project/lambdata-skhab/
#######################
Here is a colab file that imports the package and test it:
https://colab.research.google.com/drive/1lA-SDlPhGYH0WuTt9j5HmkbYkQxFr0_8?usp=sharing
#########################


Waiting for DomainEndpointOptions

When will you publish a new release?
I am waiting for this commit:
https://github.com/cloudtools/troposphere/commit/260b6d495308779d987b11f79c45cc8c4fd4a015

This was included in Release 2.6.4.


[RDBMS] az postgres flexible-server geo-restore/replica: Introduce read replicas and geo-restore

Related command

az postgres flexible-server geo-restore
az postgres flexible-server replica create
az postgres flexible-server replica list
az postgres flexible-server replica stop-replication

Description
Introduce replicas and geo-restore for PostgreSQL flexible server:

Replica location can be different from primary server location.
Restored and geo-restored servers can decide whether to be geo-redundant or not.
From a server with public access, we can only:

create a replica with public access.
geo-restore with public access

From a server with vnet, we can only:

create a replica with a vnet in same region.
geo-restore with a vnet in paired region.

Changes in code:

Add geo_redundant_backup argument in functions flexible_server_create and flexible_server_restore.
Add functions flexible_server_georestore, flexible_replica_create, flexible_replica_stop.
Refactor vnet, subnet and private dns zone provisionings in method flexible_server_provision_network_resource.
Update azure-mgmt-rdbms to version 10.2.0b5.

Testing Guide

See examples in _helptext_pg.py and updated tests.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

RDBMS


Handle start time & repeats

Support startTime for delayed start of the cron (1h from now, for example)
Support for repeats (trigger 3 times only, for example)
Support custom logic to stop (delete) job, so app can stop the job with any logic they want
Removed unused struct

I am quite concerned with the fragility of having a second-tick based approach for processing jobs on the queue. I am quite keen for us to move to a priority queue based approach as soon as possible.

We are not using second-tick, second is just the granularity chosen to keep the jobs. We will use priority queue to optimize the ticker since it is more efficient than re-sorting on every iteration.


Specify project dependencies in pyproject.toml; delete requirements.txt

Added project dependencies for poetry. The versions are obtained by default by installing ferret with the minimum possible python version (3.7, as setup.py requires python>=3.7). As the required packages are now listed in pyproject.toml, requirements.txt is not needed anymore.
The installation was done and verified using "SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True pip install .", "pip install ." gave the pip error that is already known and talked about under "Getting started" on the main page.

A final note: Starting from Python 3.8.1 it gets correctly installed with "pip install ." ( so without SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True) and works with the example in ReadMe.md.
When testing Python 3.7.6, the following error occurs:
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:

Downgrade the protobuf package to 3.20.x or lower.
Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

Apparently because protobuf 4.x.x is installed by another dependency. A workaround for this is to run "pip uninstall protobuf" and " pip install protobuf==3.20.3", after which everything works correctly.
A nicer fix could be to add a protobuf dependency in pyproject.toml and install the correct version depending on the python version, but for this I wanted your insight if it is necessary (also because python 3.7 is quite old at this point).

In the newest commit, python 3.8 is now the minimum version. The package gets correctly installed using "pip install ." and runs the example code with no problem.

@cesarc09 I've edited the file as it was not supporting python=3.8.0 previously.


Popup visible not set in mono

Godot version: 3.1.1 Mono (using C#)
OS/device including version: Windowsn10 Edu
Issue description:
When I call PopupCentered in the Script of my Popup it pops up, but IsVisible returns false.
If I call Show, IsVisible stays false.
I expect it to be true because I can see it.
Steps to reproduce:

Call PopupCentered or Show in a Popups script
Call IsVisible on the same script

project.zip
You can find the popup by clicking on the start button and then [esc]
The Code is in  Scripts/Popup.cs
(My Popup gets Closed by pressing escape without my code if i tab out before pressing it, maybe that's an other issue, so i debugged with GD.Print)

Everything is working just fine. I just didnt know that a popup gets closed by pressing [esc]


Error from solver: EPIPE "write"

Seems I can't get our CI unstuck on ocaml-rtree as the solver keeps failing: https://ocaml.ci.dev/github/geocaml/ocaml-rtree/commit/611d25bb6a303931c245ec69a463a871c118352b/variant/(analysis)
	2023-10-05 20:51.11: New job: Analyse
2023-10-05 20:51.11: Checking out commit 611d25bb. To reproduce:
                       git clone --recursive "https://github.com/geocaml/ocaml-rtree.git" && cd "ocaml-rtree" && git fetch origin "refs/pull/22/head" && git reset --hard 611d25bb
2023-10-05 20:51.11: Exec: "cp" "-a" "--" "/var/lib/ocurrent/var/git/ocaml-rtree.git-f1e70cb14ba1d0820d4be9356e6f434c9aa4d49c1205a25791f6ae6257af1bbf/.git"
                           "/tmp/git-checkout3fdf4bc"
2023-10-05 20:51.11: Exec: "git" "-C" "/tmp/git-checkout3fdf4bc" "submodule"
                           "deinit" "--force" "--all"
2023-10-05 20:51.12: Exec: "git" "-C" "/tmp/git-checkout3fdf4bc" "reset"
                           "--hard" "-q" "611d25bb6a303931c245ec69a463a871c118352b"
2023-10-05 20:51.12: Exec: "git" "-c" "protocol.file.allow=always" "-C"
                           "/tmp/git-checkout3fdf4bc" "submodule" "update"
                           "--recursive" "--init" "--no-fetch"
2023-10-05 20:51.12: Found OCamlFormat version '0.26.0' in dotfile
2023-10-05 20:51.12: Solving with opam-repository commit: https://github.com/ocaml/opam-repository.git#refs/heads/master (4fec1114629a054deee2e73a113727b0ef5cbf9f)
2023-10-05 20:51.12: Waiting for worker…
Building on arm64-jade-1.equinix.ci.dev-10
2023-10-05 20:51.12 [INFO] Solving for rtree.dev
2023-10-05 20:51.38: Job failed: Error from solver: Failed: Unix.Unix_error(Unix.EPIPE, "write", "")

@mtelvers it looks like the old solver is running again on jade-1. It's logging a message that doesn't exist in the new version, and its size matches the old service binary:
$ strings /usr/local/bin/solver-service | grep "Killed by signal"
Worker %d finished. Killed by signal<EMAIL_ADDRESS> finished. Killed by signal

It looks like the "live" branch didn't get updated after the merge (note: the test deployment was done from the "staging" branch).

@talex5 I have pushed to live and updated the workers.

Thanks - @patricoferris does that help?

It seems this might have just stopped OCaml-CI from working entirely? I'm just getting 500 errors ?

I think that's unrelated to this issue. Looking at the ocaml-ci log, I see things like:
Failed to get head of ocaml/opam-repository:refs/heads/master
[...]
GitHub API error: 403 Forbidden -- Resource not accessible by integration

This means that the analysis job can't run. Separately, the web UI seems to handle that by returning a 500 internal error:
07.10.23 11:14:36.284       dream.log  INFO REQ 68411 GET /github/ocaml-multicore/eio/commit/69c622fa0184606164bfbb6a257768c87d2a9d29/variant/%28analysis%29 <IP_ADDRESS>:55160 Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0
07.10.23 11:14:36.330                       REQ 68411 Internal server error: Failed: No job for variant "(analysis)" yet


http-parser does not correct sanitize NUL characters in header values

As described in CVE-2019-9900 and https://github.com/envoyproxy/envoy/issues/6434, http-parser will not reject headers containing NUL in header values (beyond the first character) as required by RFC 7230.
This leads to potentially serious security vulnerabilities for projects, e.g. Envoy that depend on http-parser, as they are likely to expect RFC value sanitization of any headers that are passed. See https://github.com/envoyproxy/envoy/issues/6434 for an example of this and our announcement at https://groups.google.com/forum/#!topic/envoy-announce/VoHfnDqZiAM.
The Node.JS security WG were contacted about this issue on initial discovery.

Really sad to hear that!
Would you care to share your test case with us?
I've tried reproducing it from the description, but it appears that ASCII code 0 is not accepted as a part of header value:
diff --git a/test.c b/test.c
index c3fddd5..af7f7b7 100644
--- a/test.c
+++ b/test.c
@@ -3555,6 +3555,35 @@ test_simple (const char *buf, enum http_errno err_expected)
   test_simple_type(buf, err_expected, HTTP_REQUEST);
 }

+
+void
+test_raw_type (const char *buf,
+               size_t len,
+               enum http_errno err_expected,
+               enum http_parser_type type)
+{
+  parser_init(type);
+
+  enum http_errno err;
+
+  parse(buf, len);
+  err = HTTP_PARSER_ERRNO(&parser);
+  parse(NULL, 0);
+
+  /* In strict mode, allow us to pass with an unexpected HPE_STRICT as
+   * long as the caller isn't expecting success.
+   */
+#if HTTP_PARSER_STRICT
+  if (err_expected != err && err_expected != HPE_OK && err != HPE_STRICT) {
+#else
+  if (err_expected != err) {
+#endif
+    fprintf(stderr, "\n*** test_simple expected %s, but saw %s ***\n\n%s\n",
+        http_errno_name(err_expected), http_errno_name(err), buf);
+    abort();
+  }
+}
+
 void
 test_invalid_header_content (int req, const char* str)
 {
@@ -4316,6 +4345,9 @@ main (void)
   test_simple("GET / HTTP/11.1\r\n\r\n", HPE_INVALID_VERSION);
   test_simple("GET / HTTP/1.01\r\n\r\n", HPE_INVALID_VERSION);

+  test_raw_type("GET / HTTP/1.0\r\nHello: w\0rld\r\n\r\n",
+      sizeof("GET / HTTP/1.0\r\nHello: w\0rld\r\n\r\n") - 1, HPE_INVALID_HEADER_TOKEN, HTTP_REQUEST);
+
   // Extended characters - see nodejs/test/parallel/test-http-headers-obstext.js
   test_simple("GET / HTTP/1.1\r\n"
               "Test: Düsseldorf\r\n",

Nevermind, this diff reproduces it:
diff --git a/test.c b/test.c
index c3fddd5..adfd1e6 100644
--- a/test.c
+++ b/test.c
@@ -3555,6 +3555,35 @@ test_simple (const char *buf, enum http_errno err_expected)
   test_simple_type(buf, err_expected, HTTP_REQUEST);
 }

+
+void
+test_raw_type (const char *buf,
+               size_t len,
+               enum http_errno err_expected,
+               enum http_parser_type type)
+{
+  parser_init(type);
+
+  enum http_errno err;
+
+  parse(buf, len);
+  err = HTTP_PARSER_ERRNO(&parser);
+  parse(NULL, 0);
+
+  /* In strict mode, allow us to pass with an unexpected HPE_STRICT as
+   * long as the caller isn't expecting success.
+   */
+#if HTTP_PARSER_STRICT
+  if (err_expected != err && err_expected != HPE_OK && err != HPE_STRICT) {
+#else
+  if (err_expected != err) {
+#endif
+    fprintf(stderr, "\n*** test_simple expected %s, but saw %s ***\n\n%s\n",
+        http_errno_name(err_expected), http_errno_name(err), buf);
+    abort();
+  }
+}
+
 void
 test_invalid_header_content (int req, const char* str)
 {
@@ -4316,6 +4345,9 @@ main (void)
   test_simple("GET / HTTP/11.1\r\n\r\n", HPE_INVALID_VERSION);
   test_simple("GET / HTTP/1.01\r\n\r\n", HPE_INVALID_VERSION);

+  test_raw_type("GET / HTTP/1.0\r\nHello: waa\0rld\r\n\r\n",
+      sizeof("GET / HTTP/1.0\r\nHello: waa\0rld\r\n\r\n") - 1, HPE_INVALID_HEADER_TOKEN, HTTP_REQUEST);
+
   // Extended characters - see nodejs/test/parallel/test-http-headers-obstext.js
   test_simple("GET / HTTP/1.1\r\n"
               "Test: Düsseldorf\r\n",

Sorry, I should have read more information from that envoyproxy issue before posting previous message!

Should be fixed by https://github.com/nodejs/http-parser/pull/469. Thank you for report.

@indutny thanks for the fix. I left a few minor comments, please don't block on me here though.


Update bash completion for env --shell

This adds bash completion for #4449 (which is not merged yet)

LGTM


[SPARK-9831] [SQL] fix serialization with empty broadcast

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

test this please

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

test this please

Test build #1464 has started for   PR 8117 at commit d21ac71.

Merged build triggered.

Merged build started.

Test build #1464 has finished for   PR 8117 at commit d21ac71.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #1468 has started for   PR 8117 at commit d21ac71.

test this please

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test build #1468 has finished for   PR 8117 at commit d21ac71.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

This failed SparkR test is unrelated, I'm going to merge this into master and 1.5.


⚠ AGEG website (redirect) has degraded performance

In 48d8f0d, AGEG website (redirect) (https://ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 3342 ms

Resolved: AGEG website (redirect) performance has improved in dcf3c54.


When I click in the datetime field, the time 01:01 pm appears and Now is greyed out

How can I make the current local time show up by default?  How can I make the now button appear to be enabled?

To show the now button simply add the option todayBtn: false when you create the datetimepicker.
To set the current time use this command $('#date').datetimepicker('setDate', new Date()).


Adding gitignore

Adding gitignore and adding also rhoas.env to gitignore

@pacostas I have nothing against the commit messages without the prefix chore: since we are not going to release this repo etc...I mean not a blocker but after some years in the team following that practice I can share that yeah that helped to look commits later when using git log --oneline

I agree, I changed it from fix: to chore:

other thing -- not a blocker for me -- to have a lot of stuff in a .gitignore file but in other hand I start to think that it make no sense at all to have things that we probably never will use

maybe just add the rhoas.env and keep the thing concise as possible is the best option.

I removed as much as possible, almost half of the file size.

I agree, we can add more stuff in case we need to. Right now I cant think something on the top of my head. Let me know if you think it would be valuable to add these too.
node_modules/
#System Files
.DS_Store
Thumbs.db

I agree, we can add more stuff in case we need to.

Agree, and in that spirit, a quick question: Are you using this?
rpt2_cache

Other thing is not sure if you noticed that we already have a .gitignore file :+1:
https://github.com/nodeshift-starters/reactive-example/blob/kafkajs/.gitignore

#System Files
.DS_Store
Thumbs.db

Other thing is, I'm not sure if you noticed that we already have a .gitignore file +1
https://github.com/nodeshift-starters/reactive-example/blob/kafkajs/.gitignore

Yes, this PR applies to this file.

I agree, we can add more stuff in case we need to.

Agree, and in that spirit, a quick question: Are you using this?
rpt2_cache

No ATM

I agree, we can add more stuff in case we need to. Right now I cant think something on the top of my head. Let me know if you think it would be valuable to add these too:
node_modules/
#System Files
.DS_Store
Thumbs.db

Added it.

@helio-frota are we good to land it?

@pacostas so according to the previous conversations I was thinking that we agreed to add only the things we are using.
Here you can see the original and the new content:

It would be good to add the required things only, as you suggested in your first comment:

:+1:

Force Pushed with Helio's suggestions


move to 'anexia' organization

prepares the new URLs to move this repo to the anexia organization
updates codecov to @v3
add test instructions to README

Codecov Report

Merging #4 (24bd671) into main (20994f0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   96.00%   96.00%
=======================================
  Files           3        3
  Lines          25       25
=======================================
  Hits           24       24
  Misses          1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat(playSession): add playsession report

Codecov Report

Merging #480 (eb4eb03) into develop (c8ceebf) will decrease coverage by 4.30%.
The diff coverage is 89.85%.

@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
- Coverage    64.75%   60.44%   -4.31%
===========================================
  Files          217      218       +1
  Lines        11712    11782      +70
===========================================
- Hits          7584     7122     -462
- Misses        4128     4660     +532

Impacted Files
Coverage Δ

mediaPlayer/MediaPlayer.h
100.00% <ø> (ø)

mediaPlayer/analytics/AnalyticsCollectorImpl.h
85.71% <ø> (ø)

mediaPlayer/analytics/IAnalyticsPlayer.h
100.00% <ø> (ø)

mediaPlayer/analytics/AnalyticsCollectorImpl.cpp
31.96% <33.33%> (+0.87%)
:arrow_up:

mediaPlayer/MediaPlayer.cpp
73.52% <66.66%> (-0.93%)
:arrow_down:

framework/utils/uuid.h
100.00% <100.00%> (ø)

framework/tests/dataSource/ipList.h
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/demuxer/demuxerUnitTest.cpp
0.00% <0.00%> (-100.00%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0.00% <0.00%> (-93.85%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0.00% <0.00%> (-93.62%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ceebf...eb4eb03. Read the comment docs.


Add es modules build target

Fixes #5024
Fixes #5011

Changelog Entry
Add the dist/webchat-esm.mjs distribution, to make WebChat easier to import in environments preferring ES modules
Description
Added a new build step into the bundle package for WebChat ESM target. It uses tsup producing the build in a single step.
The following configureation steps are taken:

minify depending on environment
ensure there are no big dependencies duplicated, via adding --hoist flag, and a plugin for microsoft-cognitiveservices-speech-sdk
code splitting is disabled for now
target browsers set to chrome 100, firefox 100, safari 15: y. 2021 - 2022.
metafile emitted for debugging purposes
enforce esm format
react and react-dom are baked-in for now with isomorphic-* packages
fix js files using JSX syntax to reflect usage, so esbuild won't fail on them
fix NODE_ENV usage, so it gets stripped off from the final build

Design
Additional configuration for tsup was applied in order to inject isomorphic dependencies. I had to re-shuffle dependencies and devDependencies, to maintain the tsup convention about excluded from the bundle dependencies.
The esbuild bundler which is used by tsup will include every dependecy path into the resulting bundle if paths don't match.
There are two ways to work around it:

We hoist dependencies, so there's only one path (done in the PR)
We resolve all dependencies using a custom plugin to avoid duplication

Specific Changes

Introduced tsup to bundle ESM distribution
Added --hoist flag and updated .lock files
Changed package version to match hoisted where possible
Fixed NODE_ENV usage
Renamed .js files using JSX syntax to .jsx
Fixed Webpack config aliases to match hoisted deps paths
Fixed isomorphic-react-dom package main entry

-

[ ] I have added tests and executed them locally
[ ] I have updated CHANGELOG.md
[ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

[ ] Accessibility reviewed (tab order, content readability, alt text, color contrast)
[ ] Browser and platform compatibilities reviewed
[ ] CSS styles reviewed (minimal rules, no z-index)
[ ] Documents reviewed (docs, samples, live demo)
[ ] Internationalization reviewed (strings, unit formatting)
[ ] package.json and package-lock.json reviewed
[ ] Security reviewed (no data URIs, check for nonce leak)
[ ] Tests reviewed (coverage, legitimacy)

Closing in favor of the #5148


[Feature] Return a non-zero exit code if login fails

Current Behavior
Calling regctl registry login with invalid credentials returns a zero exit code. When used in GitHub Actions, the step passes despite the login failure.
$ regctl registry login ghcr.io --user "<username>" --pass "<invalid-password>"
time="2024-05-25T06:01:28Z" level=warning msg="Changing login user for registry" host=docker.io new=<username> orig=githubactions
time="2024-05-25T06:01:28Z" level=warning msg="Changing login password for registry" host=docker.io
time="2024-05-25T06:01:28Z" level=warning msg="Failed to ping registry with credentials" err="failed to ping registry ghcr.io: unauthorized"

Expected Behavior
Return a non-zero exit code so other commands are halted.
Example Solution

Version
0.6.1
Environment

Running as binary or container:
Host platform:
Registry description:

Anything else

https://github.com/regclient/regclient/blob/105aee14f726fd3348be77bba5c118cbce40aea9/cmd/regctl/registry.go#L312-L316

Thanks for the suggestion. This is fixed in #751. I can see how some would consider that a breaking change, but since there's a flag, it's easy enough for them to go back to skipping the ping, and this feels like the right behavior. Hopefully this doesn't trigger a back and forth of different users with different use cases looking for different behaviors.

Thanks!
On Sun, May 26, 2024 at 8:14 AM Brandon Mitchell @.***>
wrote:

Thanks for the suggestion. This is fixed in #751
https://github.com/regclient/regclient/pull/751. I can see how some
would consider that a breaking change, but since there's a flag, it's easy
enough for them to go back to skipping the ping, and this feels like the
right behavior. Hopefully this doesn't trigger a back and forth of
different users with different use cases looking for different behaviors.
—
Reply to this email directly, view it on GitHub
https://github.com/regclient/regclient/issues/750#issuecomment-2132255465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG6JLSJFIMMQDVA6OEKFVLZEH36JAVCNFSM6AAAAABIIUBU56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGI2TKNBWGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


Adds nameOverride/fullnameOverride to values.yaml

Version: Helm v2.8.0
The chart skeleton generated by the create commands does not pass the checks enforced by helm lint --strict.
Console Output
$ helm create my-chart
Creating my-chart

$ helm lint --strict my-chart/
==> Linting my-chart/
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/: render error in "my-chart/templates/service.yaml": template: my-chart/templates/_helpers.tpl:15:14: executing "my-chart.fullname" at <.Values.fullnameOver...>: map has no entry for key "fullnameOverride"
Error: 1 chart(s) linted, 1 chart(s) failed

$ egrep 'nameOverride|fullnameOverride' my-chart/templates/_helpers.tpl
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}}
{{- if .Values.fullnameOverride -}}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}

$ egrep 'nameOverride|fullnameOverride' my-chart/values.yaml # nothing

As you can see, _helpers.tpl optionally tries to use values that are not defined in the values.yaml. From a strict linting standpoint, I think this error makes sense because it seems like a poor practice to blindly reference a value variable.
Does it make sense to add the 2 variables listed above to the values.yaml template?

I think this seems fair, though I'd love to get someone from the chart maintainer team to have a look at this for a quick once-over. :)

also would you mind signing the CLA? Thanks!

@bacongobbler sure, I'll sign the CLA today.

Closing this PR since the change has already been added to the latest version of Helm


TextButton documentation is missed

What was expected to happen?
Going to https://wave.free-now.com/ I am expecting to see TextButton but I don't. There is a hint they exist within the Playground at https://wave.free-now.com/components/button
Reproduction
Go to https://wave.free-now.com/components/button and there is no showcase for TextButton.
Question. Shall we create a new page to showcase the TextButton or within the same Button component page?

@duranmla Since this is a variation of a button I guess it should be inside the button. Currently there we have a short not at the beginning:

Renders a button tag. This module exposes two types of buttons  and

and then an example in the Example block. But probably we could feature all the variants in the "Combinations" block.
@agonzalezUX what do you think?

I've also herd from a developer in my team that they weren't aware of the text button. I'd suggest we either add a second documentation page (which I would prefer) or add a bigger section to the existing button documentation that explains the difference and has examples for both.

@snapsnapturtle Good point.
I would be in favour of the second option - adding a bigger section and list all the button types. In most design system there is usually one section for buttons:

Orbit
GitHub’s design system
Material

This is already implemented here https://wave.free-now.com/?path=/docs/components-button-textbutton--docs


Update chrome.css

Compatible with Zen browser 1.0.1-a.4

This and #448 are for the Now Playing Indicator mod. Just wanted to note that.


1.15.2: _pywrap_tensorflow_internal.so differs between builds

System information

OS Platform and Distribution: openSUSE-Tumbleweed-20200324
TensorFlow installed from (source or binary): source
TensorFlow version: 1.15.2
Python version: 3.8
Installed using virtualenv? pip? conda?: built with rpm spec
Bazel version (if compiling from source): 0.24
GCC/Compiler version (if compiling from source): gcc9 and gcc10
CUDA/cuDNN version: -
GPU model and memory: -

Describe the problem
While working on reproducible builds for openSUSE, I found that
our tensorflow-1.15.2 package varied across builds.
See https://reproducible-builds.org/ for why this matters.
The variations do not occur when disabling ASLR for the build.
The previous 1.13.2 version built with python-3.7 still did build reproducibly.
Provide the exact sequence of commands / steps that you executed before running into the problem
build tensorflow twice from scratch:
osc checkout openSUSE:Factory/tensorflow && cd $_
osc build --noservice --keep-pkg=RPMS
and compare resulting _pywrap_tensorflow_internal.so content
Any other info / logs
/usr/lib64/python3.8/site-packages/tensorflow_core/python/_pywrap_tensorflow_internal.so differs in assembler output
by building without Link Time Optimization (LTO), I could see that exactly one .o file differed in the build environment
Binary files /var/tmp/build-root.10/.mount/home/abuild/rpmbuild/SOURCES/BAZEL/_bazel_abuild/089fd2236bcbfcbcf994cdf39cd6bcb6/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/mlir/lite/_objs/tensorflow_lite_legalize_tf/prepare_tf.pic.o and /var/tmp/build-root.10b/.mount/home/abuild/rpmbuild/SOURCES/BAZEL/_bazel_abuild/089fd2236bcbfcbcf994cdf39cd6bcb6/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/compiler/mlir/lite/_objs/tensorflow_lite_legalize_tf/prepare_tf.pic.o differ
also the asm diff contained

  lea    offset(%rip),%rsi        #   <_ZTSZN4mlir16PassRegistrationINS_3TFL12_GLOBAL__N_129PrepareCompositeFunctionsPassEEC4EN4llvm9StringRefES6_EUlvE_ + ofs>

that comes from
tensorflow-1.15.2/tensorflow/compiler/mlir/lite/transforms/prepare_composite_functions_tf.cc
which is very close to the prepare_tf.cc file used to create the differing .o file
It is possible that the nondeterminism comes from within gcc9 and gcc10 triggered by some special feature used in prepare_tf.cc but to prove that, I would need a preprocessed version of that compilation. Due to the size and complexity of the build process, I did not manage to get that yet.

extra info: our openSUSE tensorflow2-2.1.0 package is also not affected

tensorflow-1.15.3 still has these variations in tensorflow_lite_legalize_tf/prepare_tf.pic.o

looking at the diff of build trees again, I found this diff
+++ org_tensorflow/bazel-out/k8-opt/genfiles/tensorflow/compiler/mlir/lite/transforms/generated_prepare_tf.inc
@@ -289,7 +289,7 @@
 */
 struct GeneratedConvert0 : public RewritePattern {
   GeneratedConvert0(MLIRContext *context)
-      : RewritePattern("tf.FusedBatchNorm", {"tf.Add", "tf.Mul", "tf.Rsqrt", "tf.Sub", "tf.Const"}, 1, context) {}
+      : RewritePattern("tf.FusedBatchNorm", {"tf.Const", "tf.Rsqrt", "tf.Add", "tf.Mul", "tf.Sub"}, 1, context) {}

generated by a bazel call of /bin/bash -c source external/bazel_tools/tools/genrule/genrule-setup.sh; bazel-out/host/bin/external/local_config_mlir/mlir-tblgen -I external/local_config_mlir/include -I external/org_tensorflow -I $(dirname tensorflow/compiler/mlir/lite/transforms/legalize_patterns.td)  -gen-rewriters tensorflow/compiler/mlir/lite/transforms/legalize_patterns.td -o bazel-out/k8-opt/genfiles/tensorflow/compiler/mlir/lite/transforms/generated_legalize_tf.inc
from tensorflow-1.15.3/third_party/mlir/tools/mlir-tblgen/mlir-tblgen.cpp - so rather not a gcc bug.

Can you check against master please? We won't be able to fix this on patch releases since it seems to be a significant amount of change.

There seems to be a large difference from v1.15.3..master and master branch lacks the third_party/mlir/tools/mlir-tblgen dir. I have trouble building that as a package.
Was mlir-tblgen dropped? Or does some magic only pull it in at release time?

third_party/mlir is now moved to be a part of LLVM. The location inside TF repo was only temporary.
It is expected that there are differences between master and r1.15, but the question is is the current builds are reproducible or if we should work towards making them be (likely). Since we cannot add major changes to release branches after final release, we know that r1.15 based builds are not reproducible.

I built that llvm master mlir-tblgen and when omitting the --gen-rewriters param, it even created reproducible output. Otherwise it was
llvm-project/build/bin/mlir-tblgen -I $(pwd)/inc -o generated_legalize_tf.inc --gen-rewriters legalize_patterns.td ; md5sum generated_legalize_tf.inc
Included from legalize_patterns.td:21:
SOMEPATH/inc/tensorflow/compiler/mlir/tensorflow/ir/tf_ops.td:66:1: error: Record `TF_ConstOp' does not have a field named `successors'!

def TF_ConstOp : TF_Op<"Const", [NoSideEffect]> {
^

I tried to compare it to the mlir-tblgen from 1.15.3 but that coredumped on the same call.
But this one worked with --gen-rewriters and was also reproducible now. so something else probably missing in this test setup.
so it seems I know too little to properly debug that.

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Broken automated builds on Docker Hub

Building fails with "Build failed: Dockerfile not found at ./Dockerfile". Problem appeared after v1.4.0-rc1 https://hub.docker.com/r/containous/traefik/builds/

Maybe this Docker Hub repository is deprecated and we should use https://hub.docker.com/r/library/traefik/ ?

Oops, indeed, we refactored this repo to add multi arch for the official image. It appears that it messed up the containous/traefik build :(
/cc @ldez

This should be fixed now.

Thanks a lot. Could you, please, force rebuild of tags?

@OndroNR We recommend to use the official Docker image https://hub.docker.com/r/library/traefik/.
https://hub.docker.com/r/containous/traefik/ is for our testing/experimental/backup images.


Add code samples for cancelling a job

We have code samples for get_job and list_job, but not for cancel_job, which we should add.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2fa34395-1c02-a784-313b-88821893b9cc
Version Independent ID: 4b2ffdd9-4943-ca31-d038-d1a22087a648
Content: Manage optimization jobs - Azure Quantum
Content Source: articles/optimization-job-management.md
Service: azure-quantum
Sub-service: optimization
GitHub Login: @KittyYeungQ
Microsoft Alias: kitty

This shows how to cancel a Job using its id. The id of a Job can be found using the list_jobs method, or by viewing the information in the Job Management tab of your Azure Quantum workspace in the Azure portal:
job = workspace.get_job('5d2f9cd70f55f149e3ed3aef')
workspace.cancel_job(job)

print(job.details.status)
> Cancelled

Good point, thanks for suggesting this @frtibble.


FLEX-3319 Now saves device relay status after retrieval

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AdHocManagementService.java#L114: Method has 8 parameters, which is greater than 7 authorized.

All is well.

SonarQube analysis reported 3 issues
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 AdHocManagementService.java#L113: Method has 8 parameters, which is greater than 7 authorized.
 AdHocManagementService.java#L89: Method has 8 parameters, which is greater than 7 authorized.
 AdHocManagementService.java#L91: Remove this unused method parameter "messageType".

All is well.

All is well.

I would like to reduce duplicate code, so I logged a new item FLEX-3407


IndexError: boolean index did not match indexed array along dimension 0; dimension is 1500 but corresponding boolean dimension is 3001

File "E:/Swin-Transformer-Semantic-Segmentation-main/tools/train.py", line 163, in
main()
File "E:/Swin-Transformer-Semantic-Segmentation-main/tools/train.py", line 152, in main
train_segmentor(
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\apis\train.py", line 118, in train_segmentor
runner.run(data_loaders, cfg.workflow)
File "D:\anaconda\envs\swinseg\lib\site-packages\mmcv\runner\iter_based_runner.py", line 134, in run
iter_runner(iter_loaders[i], **kwargs)
File "D:\anaconda\envs\swinseg\lib\site-packages\mmcv\runner\iter_based_runner.py", line 67, in train
self.call_hook('after_train_iter')
File "D:\anaconda\envs\swinseg\lib\site-packages\mmcv\runner\base_runner.py", line 309, in call_hook
getattr(hook, fn_name)(self)
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\core\evaluation\eval_hooks.py", line 31, in after_train_iter
self.evaluate(runner, results)
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\core\evaluation\eval_hooks.py", line 44, in evaluate
eval_res = self.dataloader.dataset.evaluate(
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\datasets\custom.py", line 337, in evaluate
ret_metrics = eval_metrics(
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\core\evaluation\metrics.py", line 210, in eval_metrics
total_area_label = total_intersect_and_union(results, gt_seg_maps,
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\core\evaluation\metrics.py", line 95, in total_intersect_and_union
intersect_and_union(results[i], gt_seg_maps[i], num_classes,
File "E:\Swin-Transformer-Semantic-Segmentation-main\mmseg\core\evaluation\metrics.py", line 48, in intersect_and_union
pred_label = pred_label[mask]
IndexError: boolean index did not match indexed array along dimension 0; dimension is 1500 but corresponding boolean dimension is 3001
When I used swin Transformer training my datasets, it came out this kind of problem, is that the reason?

Same issue. I have all set to 512, yet I get this error message.
Server error: boolean index did not match indexed array along dimension 0; dimension is 512 but corresponding boolean dimension is 448


docs: update the meaning of genesis transactions

What this PR does / why we need it?
This PR:

Update the meaning of each transaction in genesis.
Update the Pull Request template.

What is the impact of this PR?
No Breaking Change

CI Settings

CI Usage
Tip: Check the CI you want to run below, and then comment /run-ci.
CI Switch

[ ] Coverage Test
[ ] E2E Tests
[ ] Code Format
[ ] Web3 Compatible Tests
[ ] OCT 1-5 And 12-15
[ ] OCT 6-10
[ ] OCT 11
[ ] OCT 16-19
[ ] v3 Core Tests

CI Description

CI Name
Description

Chaos CI
Test the liveness and robustness of Axon under terrible network condition

Cargo Clippy
Run cargo clippy --all --all-targets --all-features

Coverage Test
Get the unit test coverage report

E2E Test
Run end-to-end test to check interfaces

Code Format
Run cargo +nightly fmt --all -- --check and cargo sort -gwc

Web3 Compatible Test
Test the Web3 compatibility of Axon

v3 Core Test
Run the compatibility tests provided by Uniswap V3

OCT 1-5 | 6-10 | 11 | 12-15 | 16-19
Run the compatibility tests provided by OpenZeppelin

LGTM


When will stage3.py be released?

When can we expect to see parameter-state partitioning, i.e., stage3.py released in deepspeed/runtime/zero?
Fairscale seems to have released an initial implementation a couple days ago.

Issue is irrelevant now, thanks @jeffra @samyam @ShadenSmith @tjruwase and others!


Outdated doc?

Can I create locally redundant storage, geo-redundant storage, and zone-redundant storage managed disks?
Azure Managed Disks currently supports only locally redundant storage managed disks.
==> is this still true?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f329597-345e-2f0c-2db3-26b1277ef428
Version Independent ID: e184dc65-2103-8629-c857-a4873744a54e
Content: Frequently asked questions about disks - Azure Virtual Machines
Content Source: articles/virtual-machines/faq-for-disks.yml
Service: storage
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

Thanks for the feedback! We are currently investigating and will update you shortly.

@gbeaud No, that's outdated, ZRS is supported as well. We'll update the article later today. Thanks for making us aware. :)
#please-close


Keep getting Collection was modified; enumeration operation may not execute.

If I run SF service for some time I keep seeing this exception.

Is it an issue in OMEX.System?

Solved by deleting Omex.System :)


Docs and examples

Will do this post-release

This desperately needs some attention now that we've made so many amazing improvements! :)

Tutorials
How-to guides
Explanation
API Reference


ofc-bootstrap failed to install cert-manager

When deploying OFC on EKS, cert-manager-webhook pod ends in a CrashLoopBackOff
Expected Behaviour
cert-manager-webhook Pod should be in Running state

Current Behaviour
cert-manager-webhook Pod ends in CrashLoopBackOff state
Possible Solution
There is an issue with API aggregation certificates on EKS (see https://github.com/jetstack/cert-manager/issues/1220 and https://github.com/aws/containers-roadmap/issues/152).
A possible solution is to use helm chart v0.6.6 (which use v0.6.2 of cert-manager)
Steps to Reproduce (for bugs)

Launch an EKS cluster
Configure OFC init.yml and run ./ofc-bootstrap

Context
The process of ofc-bootstrap didn't complete successfully.

Kubernetes:
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.5", GitCommit:"753b2dbc622f5cc417845f0ff8a77f539a4213ea", GitTreeState:"clean", BuildDate:"2018-12-06T01:33:57Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11+", GitVersion:"v1.11.5-eks-6bad6d", GitCommit:"6bad6d9c768dc0864dab48a11653aa53b5a47043", GitTreeState:"clean", BuildDate:"2018-12-06T23:13:14Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}
Operating System and version (e.g. Linux, Windows, MacOS):
Amazon Linux 2
Link to your project or a code example to reproduce issue:
Just run ofc-bootstrap to provision OFC over EKS

Hi thank you for raising this issue. Would you like to work on the fix?
Alex

I've fixed this issue, thank you for reporting it. 👍


Support a Mac?

Thanks for the great work. Any chance this could be made to work on a Mac? I don't have a linux machine and initially don't want to faff around with a Pi.

Thanks for your interest. I believe it should work relatively easily on a Mac, since PyTorch has Mac support.

Could you give me any tips on how to do it?

For PyTorch, the official documentation is here. You can scroll down to see installation instructions on Mac. However, you'd be limited to the CPU-only version (I think), which precludes much faster GPU-based routines. Our readme also has this notice for Macs:

Additional notes for Mac OS X:
GLUT is already installed on Mac OS X, so that step isn't needed.
If you have issues installing pyaudio, this may be the issue.


why alpha

In this step, how exactly does alpha=0.015 get it? For a new data set, how should the corresponding alpha value be calculated? Looking forward to your answer

Hi @18370029656,
We selected the alpha value based on the forward and backward error maps of the validation set, and we found it generalized well to the test set. An ideal alpha value should be able to highlight regions with absent correspondence, e.g., tumor and resected tumor region, while excluding the regions with valid correspondence.  A more rigorous way to choose the alpha is to measure the overlap (e.g. Dice score) of thresholded region and the tumor region of the validation set.


Test coverage for a custom test library (like postman) ?

Hi, thanks for such a piece of work !
I didn't really understood how to do that:

I have a nodeJS process running on localhost:9999
I have a custom test library that are targeting routes of an express api (same behaviour than postman)
I run my tests like "nyc npm run test-api" and test-api is node -e 'require(./core-scripts)(run-tests)'

Here is my config:
module.exports = {
    all: true,
    include: ['**/server/**/*'],
    exclude: ['*.spec.js'],
    reporter: ['json-summary', 'text'],
    'report-dir': './.jarvis'
};

And here is a sample of my report:

Can you help me understand why all is red and to 0 ?
Thanks for your lights :)
EDIT: now I understand that it is not working because the server is not started with nyc command. How may I do that ? And how to output the coverage report ?

Did you instrument the code?

Hi, thx for your answer. I was exactly wondering how to do that properly ?

Ask a developer to use help you as it is not only about running a command , but the application after that will need to be serving the instrumented folder which means it will have to run no the original source code but instrumented... then you run your test against that and the report will be created

Much more clear to me now :)
Could be good to have this concept explained in the doc also.
Thank you very much :)

Much more clear to me now :)
Could be good to have this concept explained in the doc also.
Thank you very much :)

Glad it helped :-)


Breadcrumb label not perfectly aligned with tab label when tabs disabled

Steps to Reproduce:

disable tabs (workbench.editor.showTabs set to single)
make sure breadcrumbs are enabled
open a file at root (e.g. index.js)

=> 🐛 notice how the breadcrumb label is not nicely aligned to the editor label, it is slightly more to the top:

Compare this with the "description" part of a tab that is perfectly aligned on the bottom (hacked here using dev tools to repeat index.ts):

The "description" part is in a span called label-description:

While the breadcrumb is in a span called label-name:

Pointers to CSS for breadcrumbs: https://github.com/microsoft/vscode/blob/1aecebe3ebbb5ce354d74abdc097b2e39c0e97bd/src/vs/workbench/browser/parts/editor/media/singleeditortabscontrol.css#L29
I suspect that this maybe an issue with how rendering works in the browser: in the case without breadcrumbs, there is 2 span next to each other (tab name, tab description) while in the breadcrumbs case the span is isolated, making it maybe harder to align to the span in the other div 🤔
Opening for help wanted for a CSS wizard to look into.

Hi @bpasero!
As far as I understand the issue is that the file name isn't aligned correctly with the breadcrumb as follows:

Here I gave the anchor tag the same inherited line-height + 0.1em, so what's your opinion?

I think it's fix the issue .

Your suggested fix is:
.monaco-workbench .part.editor > .content .editor-group-container > .title > .label-container > .title-label > .monaco-icon-label-container > .monaco-icon-name-container > .label-name{
	line-height: calc(var(--editor-group-tab-height) + 0.1em);
}

I also think that breadcrumbs is missing the same directive of line-height as the tab label has, but the +0.1em feels like a hack to me, whats the justification?


"un-deletable selections" when updating data and rows are selected

When the user selects a row and then updates data already loaded in a px-data-table,
selectedRows is not updated, leading to un-deletable selections.
The problem is that selectedRows is not updated when data is changed, and _internalData does not contain any reference to objects that are still referenced by selectedRows
It's impossible to remove selected rows using the usual "select/unselect"
logic, because aha-table::_selectRow is using strict equality to compare rows in selectedRows with the newly selected/unselected one.
Expected behavior and actual behavior:
I expect that, when I update the px-data-table, I can safely un-select a previously selected row.
The actual behavior is that the previously selected row is still in the selectedRows property,
and the un-select adds a copy of the now-un-selected row to selectedRows.
The behavior is made more visible by the "Selected (1)" label becoming "Selected (2)", even though
the user would expect it to become "Selected (0)".
Steps to reproduce the problem:

Create a px-data-table with the selectable attribute set to true. Preload it with data.
Select a row
Assign a new array to the px-data-table
Deselect the selected row
You now have two selected row in the table, but no one is actually selected!

Environment (component version number, Browser (including version), operating system, hardware, etc):
This problem is still present in the latest version. Tested on Chrome and Firefox on both Linux x64 and Windows 7 x64.
Code examples help us better understand the issue
Here you can find a simple jsfiddle reproducing the issue.

By the way, #51 looks closely related (and I noticed that behavior too!).


Awesome books: with ES6

Awesome books: with ES6
Overview
In this project, the Awesome books app code was refactored. The goal was to make it more organized by using modules while practising the use of ES6 syntax in the project
Project Objectives

[x] Re-create the Awesome books app following the rules:

[x] Use ES6 syntax.
[x] Divide code into modules. the following modules were created:

[x] BookList.js: for BookList class
[x] book.js: for the book class
[x] datetime.js: for the time function
[x] luxon: the downloaded luxon library

[x] Display the current date below the navigation bar.

[x]  For this requirement we use a library Luxon

DEMO LINK

Live Demo Link

Hello @fmanimashaun 👋,
This is an additional review as a result of the second opinion request.

Nice implementing the requested changes 👍

Arrow function expressions are ill-suited as methods(they don't have their own bindings), and they should not be used as constructors or methods.

   class BookListing {
     constructor() {
       ...
     }
      displayList = (text) => {
         this.text = text;
      }
   }
console.log(new displayList ('Hello world'));

// It will throw an error that says displayList is not a constructor.

It is much more advisable to use a traditional function for classes, calling them with the new keyword throws an error.

As this was the only reason that your project was not approved it will be approved as soon as possible. Please ask for another review in your Dashboard and the next Code Reviewer will mark it as approved right away :)
Keep rocking 🚀!

@bimbolabuari thanks for your input!

Hi @fmanimashaun,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights
✔ No linter errors ✔ Used Gitflow ✔ Work documented professionally
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Ismailco Thanks


Primary key in cache objects set to invalid value

Hi.
I think primaryKeyStringValue of RBQObjectCacheObject is set to an invalid value when the primary key is of type NSInteger. FRC returns correct number of sections and rows but method [RBQFRC objectInRealm:atIndexPath:] always returns nil.
When replacing following code (line 30) in file 'RBQObjectCacheObject.m':
cacheObject.primaryKeyStringValue = @((NSInteger)primaryKeyValue).stringValue;
with:
cacheObject.primaryKeyStringValue = ((NSNumber *)primaryKeyValue).stringValue;
It works as it should
Seems like "[RLMObject primaryKeyValueForObject:];" returns an NSNumber* not an NSInteger.

Yes this is a bug. Looking in the Realm code base, all RLMObject subclasses override objectForKeyedSubscript: to call RLMDynamicGet function, which returns an NSNumber for the numerical properties. I will push an update to fix. Thanks!

Ok the changes should now be live. Updated the version to v1.4.8, and updated pod. Neither the example project or our other projects using the code had primary keys that were not strings, so this slipped by. Thanks again!


Fix setup.py warnings

$ python -m build
/home/ogajduse/.virtualenvs/pytest-fixture-tools/bin/python: No module named build.__main__; 'build' is a package and cannot be directly executed
(pytest-fixture-tools) [Thu Aug 15 10:36:34 ogajduse pytest-fixture-tools] (master) RC:1
$ python setup.py build
/home/ogajduse/repos/pytest-fixture-tools/setup.py:6: SetuptoolsDeprecationWarning: The test command is disabled and references to it are deprecated.
!!

        ********************************************************************************
        Please remove any references to `setuptools.command.test` in all supported versions of the affected package.

        By 2024-Nov-15, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.
        ********************************************************************************

!!
  from setuptools.command.test import test as TestCommand
/home/ogajduse/.virtualenvs/pytest-fixture-tools/lib/python3.12/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'tests_require'
  warnings.warn(msg)
running build
running build_py
copying pytest_fixture_tools/__init__.py -> build/lib/pytest_fixture_tools
copying pytest_fixture_tools/plugin.py -> build/lib/pytest_fixture_tools

https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

@webknjaz Mind doing a review of #8?

You linked the issue itself 😂

Probably meant #9

Oh, yes. I was in a hurry for lunch at that moment. :smiley:


First class workloads in Istio

(thoughts after discussion with @mandarjog @louiscryan)
There is currently a gap in Istio model for naming and assigning config to workloads. We've made a simplifying assumption early on that workloads (e.g. pods) carry source service attribute, and that drives the entire Istio request processing workflow from pilot configuring envoys to mixer selecting configs for a request. We need to address this soon, as it creates constant tension within the model (examples: not allowing dual service pods, source labels referring to pod labels rather than service labels, prioritizing app label as special, etc).
For Pilot (cc @rshriram):

the selection of local instances should not be based on service model, but instead on the workload description. Sidecar proxy should expose the ports that are declared by the workload. HTTP features would require an extra annotation on the pod to enable HTTP filtering. The inbound listeners can be opened prior to registration with the service, and remain open for the lifecycle of the workload. Concretely, service/deployment model needs to expose an interface:

func WorkloadDescription(id string) []Port

which can be used either statically through injection or dynamically through xDS.

the selection of rules by source should be driven by the source workload properties. The workload has a unique identity, labels, and may or may not have multiple services associated through the service model. Concretely, the config model needs to be oriented towards this interface:

func RouteRules(sourceWorkloadSelector LabelOrNameSelector, destinatioService LabelOrNameSelector) []RouteRule

Secondary, the selection of rules for inbound traffic should be avoided. Once we permit workloads with no services, we no longer control the traffic from it. We should find another solution for WS protocol support.
For Mixer (cc @mandarjog, @ayj ):

the server side proxy can only reliably supply destination.workload attributes. Destination services need to be inferred either by Pilot or by Mixer and supplied dynamically. All configuration within Mixer filter should dynamically adjust and allow multiple destination.services.

source.workload instead of source.service makes some sense. The need for destination.workload is less clear to me.
A server Proxy/Mixerclient needs to invoke Check() conditional on local route/domain/port info (e.g. destination.service) for things like Quota and APISpec and not simply rely on Mixer to disambiguate.

@ayj agree that destination workload should always lead to derivation of a derivation service. I can't come with a case when a workload can address another workload without a name. This derivation can be made deterministic with mTLS and authority enforcement. I'm suggesting here that either Mixer or Pilot needs to push the derived attribute down to the proxy.

I think it is reasonable to make most decisions based on the identity and
attributes of the workload - both for source and destination.
source.service doesn't make any sense - a workload initiates the request,
and it may belong to multiple services with no way to
determine in which capacity it is acting.
destination.service is also tricky - what if a request is made directly to
the IP.
My only concern is to make sure this is implemented in a way that is
flexible enough for VMs. Ideally the workload itself
in case of VMs should be able to supply the information without additional
complexity and overhead, since the workload
info is quite deterministic and can be know by the workload.
Another important concept that is starting to become important is that of
'canonical name' - where a workload or
service may be associated with multiple names, but for purpose of policy
and logging wants to use a specific
name. If such a 'canonical name' becomes a feature - I think it should
override any workload or service identity that
may be guessed/derived by us.
Costin
On Tue, Nov 14, 2017 at 5:18 PM, Kuat<EMAIL_ADDRESS>wrote:

@ayj https://github.com/ayj agree that destination workload should
always lead to derivation of a derivation service. I can't come with a
case when a workload can address another workload without a name. This
derivation can be made deterministic with mTLS and authority enforcement.
I'm suggesting here that either Mixer or Pilot needs to push the derived
attribute down to the proxy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/1727#issuecomment-344454663, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6k7tEomFZlDuau7GBVVbYXWM2Q8Aks5s2jvcgaJpZM4QeOhc
.

destination.service is also tricky - what if a request is made directly to
the IP.

Mixerclient defines policy (e.g. quota, apispec, authn) per service. Pilot can provide service identity through authority (e.g. domain:port) with some reasonable default behavior (e.g. falllback default service name).

ping @rshriram. I'd like to eliminate HostInstances use and use workload IP as the query key. This has several implications:

inbound calls are TCP by default (override requires pod annotations)
health ports are extracted from pod template and are opened up automatically.
mTLS vs health ports are reconciled per pod.
mixerfilter needs conditional attributes.

Well, I am glad that you have finally decided to ditch the host level sidecar :). While this is generally in the right direction, my main concern is that we are losing a bunch of out of the box features that users have become used to so far. The key feature being metrics for inbound http, and the access logs on the inbound path.
Not worried about websockets because it works out of the box with tcp listener in the inbound path. Another issue is tracing, though its not that bad, because if a user is going to modify the service to propagate trace headers, adding port level annotation is not a big deal.
Why can't we detect the listener type based on the port name, if present in the right format, like http-foo ?
We already do (2), unless you mean that we no longer have to explicitly extract health ports and create TCP listeners for them.
(3) what do you mean? what is mTLS port? This still does not solve the mTLS with health check issue. This is not going to solve the mixer filter not working for health check  issue either since the mixer expects or wants to derive destination.service attribute, and that is not available until the readiness probes pass.
(4) what type of conditional attributes?

Re-assigned to @rshriram since he's driving v1alpha2 design. Workloads ultimately should be surfaced there.

I think this issue is stale. The new networking APIs are in place and we've ironed out some of the attribution concerns and others are being tracked elsewhere.


(ecmascript) Missing BigInt type

Describe the issue
BigInt is not highlighted as type the same way Number is.

Which language seems to have the issue?
ecmascript and therefore also javascript
Sample Code to Reproduce
let bi = BigInt('1');

Expected behavior

Additional context
Also seems to be missing BigInt64Array and BigUint64Array.
See List of built-ins.

We should added these missing types to ecmascript#TYPES.


Trouble: "Username is already taken"

Good morning
I have been working on the mount this project since a few weeks ago, and I have just discovered the litvak project,
I have performed the entire procedure as indicated on its website: http://traccar.litvak.su/installation.html
However I have not managed to make the devices visible on the map, I also have problems creating new users since the following message always appears:
"Username is already taken"
Where could I find the solution to this problem?
Thanks in advance.

Litvak project is not an official Traccar project, so you should ask your question on their issue tracker:
https://github.com/vitalidze/traccar-web/issues


esp_lcd_panel_init method does not return error (IDFGH-10494)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
For example, with the ssd1306 panel, the esp_lcd_panel_init method always returns ESP_OK.
static esp_err_t panel_ssd1306_init(esp_lcd_panel_t *panel)
{
    ssd1306_panel_t *ssd1306 = __containerof(panel, ssd1306_panel_t, base);
    esp_lcd_panel_io_handle_t io = ssd1306->io;
    esp_lcd_panel_io_tx_param(io, SSD1306_CMD_DISP_OFF, NULL, 0);
    esp_lcd_panel_io_tx_param(io, SSD1306_CMD_SET_MEMORY_ADDR_MODE, (uint8_t[]) {
        0x00 // horizontal addressing mode
    }, 1);
    esp_lcd_panel_io_tx_param(io, SSD1306_CMD_SET_CHARGE_PUMP, (uint8_t[]) {
        0x14 // enable charge pump
    }, 1);
    esp_lcd_panel_io_tx_param(io, SSD1306_CMD_MIRROR_X_OFF, NULL, 0);
    esp_lcd_panel_io_tx_param(io, SSD1306_CMD_MIRROR_Y_OFF, NULL, 0);
    return ESP_OK;
}

right. we may consider checking the result of each esp_lcd_panel_io_tx_param call.


French and Spanish traits

About the PR

Added French and Spanish as speech traits.
Why / Balance

Now that we have seprate speach section to traits they can be added as discussed in #27129.
Could possibly raise the cost for any of them if deemed necesassy but one should be good for them.
Technical details

Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Added French and Spanish speech traits.

Can I ask you to sort them by cost?

my life's work.. blessed day... thankyou forever

Can you make the Russian accent not a trait?

sure thing

not a word in russian :trollface:

not a word in russian :trollface:

no russian in here

Thank you for your contribution!

probably because it would be a little chaos with all that cyrillic replacements

excuse me, why?

a large proportion of raiders are russian and the trait will likely increase admin workload


Add the ability to pass additional columns through to opportunity

We have several custom columns on Opportunity in Salesforce that we would like to make available downstream on opportunity_enhanced.
See this Segment package PR for an example of how the dbt community has done this elsewhere.

This has been added! :)

This has been added! :)


Bug: Default date value specification editor is throwing cast compilation error

Similar issues

[X] I have searched and found no existing similar issues

How are you using Studio?
Legend Query
Current and expected behavior

Steps to reproduce
No response
Model data
No response
Environment
No response
Possible solution and workaround
No response
Contribution

[X] I would like to work on the fix for this issue

Reopened, see the issue in https://github.com/finos/legend-studio/issues/1460 when drag-and-drop a derived property with a parameter of type Date, we automatically populate a dummy value of type StrictDate, causing a compilation error


[improve][broker] Use separate IO event loop group for internal client.

Motivation
In the current implementation, we use the broker IO event loop group for internal clients. If the internal client uses a lot of threads or the exception handling is not good (such as frequent exception thread). It will affect the throughput of the entire broker.
Modifications

Use the separate IO event loop group for the internal clients.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[x] doc-not-needed
(Please explain why)

Matching PR in forked repository
PR in forked repository:

If the internal client uses a lot of threads or the exception handling is not good (such as frequent exception thread). It will affect the throughput of the entire broker.

please elaborate more on this. What do you mean with "internal client uses a lot of threads" or "exception handling is not good"? Please provide examples.
I can see why this is needed since the Pulsar code is not non-blocking. Running synchronized methods on Netty IO threads is harmful since it will become a performance bottleneck. We should make these problems visible and eventually address them.
To detect blocking code, there's https://github.com/reactor/BlockHound that could be used. Netty comes with BlockHound integration. BlockHound could be used in unit tests and integration tests to ensure that blocking method calls aren't done on Netty IO threads. With Pulsar we'd have long ways to fullfil this requirement. This just shows that we need a better concurrency model to guide the future development of Pulsar in Pulsar 3.0 and beyond that. The current situation is more or less a mess from a concurrency model perspective.

Hi @lhotari
Thanks for your professional explanation.

Adding more threads and thread pools (event loops) is a bandaid to the problem, but doesn't solve the root cause.

I totally agree with you, but in the current implementation, we have too much historical baggage and potential impact. For this situation, my recommendation is to lower the sphere of influence first. Then keep making it even better.
Another problem is that we share the IO pool with all replicators. This means that if we have too many replicators on the broker, they will compete for resources with the broker. Plus, by design, I don't think it's a good idea for one component to compete with the entire broker. For example, a problem with a topic or replicator should not affect the entire broker.
Please let me know what you think. thanks!

we have too much historical baggage and potential impact.

It would be good to clarify this if you have something specific to point out. I can see that there are issues with blocking code. It would be useful if you could point out clear examples of problems.

Another problem is that we share the IO pool with all replicators. This means that if we have too many replicators on the broker, they will compete for resources with the broker.

Sharing the IO pool isn't a problem on its own. They will compete on the same resources even in the case of using separate thread pools.
There's a detail in Pulsar that the BookKeeper client uses the Pulsar Broker IO threads by default, code at https://github.com/apache/pulsar/blob/df5e0e1869ff7ce55489e4a7853172fa37b2b59d/pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java#L95-L97
What do you think about that solution? :)

Close this PR and try to fix the root probelm.


Delete key not working on the linux Keyman distribution of the Engram layout

I am able to use the Delete key with the Keyman distribution of the Engram layout on macos, but not on linux.  Any suggestions for a fix?  @sunaku, @Tristen-Sinanju, @caga?

The delete key isn't remapped in our XKB file, so it should be inherited from the standard US (basic) layout.
Can you try running xev in a graphical terminal and then press the delete key?  I get this output on my side:
KeyPress event, serial 37, synthetic NO, window 0x7800001,
    root 0x6ab, subw 0x0, time 14982585, (-248,-19), root:(623,459),
    state 0x2000, keycode 119 (keysym 0xffff, Delete), same_screen YES,
    XLookupString gives 1 bytes: (7f) ""
    XmbLookupString gives 1 bytes: (7f) ""
    XFilterEvent returns: False

KeyRelease event, serial 37, synthetic NO, window 0x7800001,
    root 0x6ab, subw 0x0, time 14982663, (-248,-19), root:(623,459),
    state 0x2000, keycode 119 (keysym 0xffff, Delete), same_screen YES,
    XLookupString gives 1 bytes: (7f) ""
    XFilterEvent returns: False

KeyRelease event, serial 36, synthetic NO, window 0x5600001,
root 0x7bf, subw 0x0, time 11276225, (1038,456), root:(1038,485),
state 0x0, keycode 36 (keysym 0xff0d, Return), same_screen YES,
"   XLookupString gives 1 bytes: (0d) "
XFilterEvent returns: False

Hmm, that looks correct to me.  Maybe something else is interpreting your delete key?
Are you running ibus (for the keyman version of Engram) alongside the XKB version?
See https://discourse.gnome.org/t/delete-key-not-working/5627/3

Thank you, @sunaku, but I don't have a ~/.cache/ibus/compose/ directory.
Also, to be clear, I'm not currently using your xkb file; I'm using Keyman to remap keys.

Thanks for clarifying - I really was thinking this was an issue with my XKB implementation so far! :sweat_smile:
Do you have dead keys enabled in your IBus config?  It's another symptom in that Gnome bug report.

Got it -- thanks!  Until Keyman fixes this, I'll recommend people use setxkbmap:
linux ➤ setxkbmap -query                                                                  git:master
rules:      evdev
model:      pc101
layout:     us,us
variant:    engram,basic
linux ➤ setxkbmap -layout us,us -variant engram,basic -option grp:ctrls_toggle


Multiple Zones, Cleanup multiplier?

Is it possible to define "per accessory" multiple Zones? (including a Multiplier…)?
config?

…got it myself… Closing…


Incorrect syntax near 'or'.

We have written the needed data into your clipboard because it was
Issue Type: Bug
Hi guys,
Please paste the following in a new query window and you will see that ADS doesn't recognise a valid statements and throws 2 errors "Incorrect syntax near 'or'." and "Incorrect syntax: 'ALTER PROCEDURE' must be the only statement in the batch.":
create or alter procedure di.usp_dupa
as
BEGIN
select * from di.GlobalVariables
end
go
Thanks
Daniel
Azure Data Studio version: azuredatastudio 1.23.0 (d296b6397e0acfddc57e9085e736e084969cdaeb, 2020-10-13T23:03:09.799Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.85GB (4.66GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

agent
Mic
0.47.0

dacpac
Mic
1.6.0

import
Mic
1.1.0

profiler
Mic
0.11.0

azdata-sanddance
msr
3.1.0

too large to send. Please paste.

This looks to be a duplicate of #7745 which was closed due to inactivity. In there it was mentioned that this was occurring when connected to an Azure SQL DB.
I can reproduce this when testing on the simplified script mentioned in that issue when pointing to an Azure SQL DB:
create or alter procedure procTest
as
begin
 print (1)
end
go

Hi santivarm I confirm we use Azure SQL databases.

This should be fixed in the next release of ADS - if you are able to verify this on the latest version of our insiders builds that would be great!
https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main


[ENH] add non-duplicate (multi)index to sktime data specification and input checks

We should enforce non-duplicate row and column indices as part of the data specification.
This will need to be ensured in the _check functions in the datatypes module, and the specifications in the AA_datatypes_ notebook need to be updated accordingly.

Following a suggestion by/discussion with @grzegorzrut in https://github.com/alan-turing-institute/sktime/pull/2325.
We probably want to enforce that there are no duplicate (loc) indices in any pandas data containers (rows and columns).
We already enforce that indices are ordered monotonically increasing, but the checks/conversions do not enforce, or guarantee, non-duplicate (loc) indices.
As a matter of fact, probably much of our code would break if passed containers with duplicate indices - and it is currently also not tested.
A design question for the start, for discussion.
For implementation, a check for it would need to be added to the _check modules in datatypes.

Ok, I now think it should be - any diverging opinions?

I believe that there's a flag that could help with that.
As a side note, duplicated indices might cause problems in pandas. I'm working on the extension of the WindowSummarizer to time windows/lags and can't get rid of these errors for some reason - will write about it in the nearest future.


Deal with transition lists with entries which describe the same molecule but with a different (non-conflicting) set of accessions…

This seems to happen when users cobble together transition lists from multiple sources to flesh out the set of measured fragments.

It might be easier to understand the code if you move "MoleculeNameAndAccessions" into a top-level class in its own file.
Then, make it so that SmallMoleculeTransitionListReader makes an array of MoleculeNameAndAccessions with one entry per row, and fills it in with the information from the grid.
And, then, the logic of merging those MoleculeNameAndAccession values could be done by a static method in the class "MoleculeNameAndAccessions" which modifies an array in place:
public static void GetConsensusAccessionNumbers(MoleculeAccessionNumbers[] moleculeAccessionNumbersArray)
In that way, you can move the logic of merging accession numbers into a class which is separate from "SmallMoleculeTransitionListReader" and would be easier to test separately.
I am thinking that it's probably cleaner to use array MoleculeAccessionNumbers[] instead of a Dictionary<int, MoleculeAccessionNumbers> since you know how many rows there are and most of the rows will probably have a value.

Thanks for the review, I'll look at these refactorings.
The dictionary thing is needed because the input rows may be sorted by mass before final parsing, so we need a mapping from the original index value.

@nickshulman if you have a moment to give this (with your suggested refactoring) the blessing I'd be grateful, thanks


icu/glib static linking in libcommon

is it necessairy to statically link icu and glib in libcommon?
this makes it hard to build ClickHouse on other Distributions.

It is for more easy deployment.
With static linking it has runtime dependencies only on libc.
To build ClickHouse on other distributions, there are several ways:

Build ICU, GLib2 from sources and use compiled static libraries (install to /usr/local as default: libraries is searched there).
Change static linking to shared (.a to .so) in libs/libcommon/CMakeLists.txt

We don't have official packages for other distributions, but see below...
To install ClickHouse on other distributions, you often don't need to rebuild it and could use .deb packages.
So, package for Trusty depends on libc6 2.19..2.20 and package for Precise depends on libc6 2.15..2.16.
To determine libc version of your system, run ldd --version or run /lib/x86_64-linux-gnu/libc.so.6 or /lib64/libc.so.6 as executable.
If you have matching version, just install debian packages by unpacking manually:
ar x clickhouse-server-base_1.1.53988_amd64.deb
sudo tar -x -C / -f data.tar.xz

tar xf control.tar.gz
sed -r -i 's/update-rc.d.+/true;/' ./postinst
sudo ./postinst

ar x clickhouse-server-common_1.1.53988_amd64.deb
sudo tar -x -C / -f data.tar.xz

ar x clickhouse-client_1.1.53988_amd64.deb
sudo tar -x -C / -f data.tar.xz

sudo service clickhouse-server start

Also it's possible to build ClickHouse on Ubuntu Trusty with experimental option to depend only on older libc.
If you need it, do the following steps:

Temporarily obtain a server, VM or container with Ubuntu Trusty.
Build ClickHouse according to the instructions: https://github.com/yandex/ClickHouse/blob/master/doc/build.md,
but instead of ./release --standalone do GLIBC_COMPATIBILITY=1 ./release --standalone.
Install generated packages on target system with manual unpacking.

How can you specify dir where libicu is located? If it's not in system dir.

You may add 'link_directories' entry into root CMakeLists.txt file.

hi,I followed your advice above to build clickhouse on Ubuntu Trusty ,and i want to start up clickhouse on centOS 5.5 whose glibc is 2.5.then It shows that it need glibc 2.10.so,i try to upgrade glibc to 2.10,but it seems that the 2.5 glibc is dependency of many things in centos5.5.Is there a way to start clickhouse on centos5.5?

Could you afford at least CentOS 6?
It is possible to make compatibility with glibc 2.5, but it requires additional amount of work.

I just copy file  which glibc-2.14 installed, to centos5.5 ,now the glibc  update to 2.14.I dont know whether this approach is right,but it works.


Create LED Feedback

Create a system to give feedback to the driver via an LED strip.
This will involve finding a controller for the LEDs. This controller will have to be able to handle the current wanted in addition to being compatible with the rules.
Then a subsystem has to be created where one can request the wanted state of the LEDs on the robot. (Feel free to choose a creative name).

Already finished and opened pull request. Not sure if it actually works though


Make Logging and Hub categories available at initialization

Right now, it is impossible for callers to use the Logging or Hub categories until we've called Amplify.configure. This needs to be changed so that default plugins can use the logger and hub during initialization and configuration flows.
We've made partial progress toward that--the Hub and Logging categories are the first to be configured, but that isn't sufficient for (for example) setting up a Plugin that uses the logger during its initialization.

@palpatim it seems like this one is fixed, can you confirm?

Yep, confirmed.


[FYI] Type Definitions Don't Work in HScript

https://github.com/NQNStudios/hank/blob/b8c6eca1e1ba06c661d79a1efa4cce37ad4fb41b/examples/TheIntercept.hank#L25
FYI, there are no type definitions of any kind in HScript ( see limitations ). I just saw your comment, so I thought I'd mention it.

I saw that. Kind of disappointing--I wonder if you can even important types? Like, what if I wanted to have complex enums in my Hank script and use pattern matching?
I know there are some forks that extend hscript, which might be worth looking into.

It might be better to implement that in the language itself. I know you said you kind of lean away from hacking the language, but I think it is going to be necessary to add language features if we don't want to have you writing a bunch of Haxe for the story logic. I'm not 100% sure or anything, but that is my initial thought.
Your exercise of porting that Ink game could be a good test to see how things will play out and what design decisions you might want to make.


Request: Support MQTT over Websockets

Hi,
would it be possible to add the option in the app, to connect via web sockets? I'm trying to connect with a javascript browser app and the browser only allows communication over web sockets.

Hi @Tomp0801
We will check the possibilities.

Hello, is this possible by any chance?

Can you try connecting to port 8080 for WebSocket connection @connected-tcaceres

Can you try connecting to port 8080 for WebSocket connection @connected-tcaceres

It works using chrome extension "MQTT Box" but I have not gotten it to work on the browser unfortunately.


Update Code - Proof_Of_ContributionSnapshot3.md

New feature was added: User can now download any model from ollama library within the app (settings menu) and it will load it as an active model.
https://github.com/MorpheusAIs/Morpheus/pull/658/commits/9ca6638fa80c24d14986721a77229e33865e0b53

Hi @zanknaf.  This the feature looks promising.  It's being tested now. Please wait to submit the proof of contribution until the feature is integrated into the next release. Thank you @zanknaf


More configurable Map asset

Thanks for the great library. I just want to drop some ideas.
Instead of using Yii::$app->params how about we use the assetManager features.
http://www.yiiframework.com/doc-2.0/guide-structure-assets.html#customizing-asset-bundles
here's my proposal
class MapAsset extends \yii\web\AssetBundle {

    public $options = [];

    public function init() {
        $this->js[] = 'https://maps.googleapis.com/maps/api/js?' . http_build_query($this->options);
    }

}

In the Yii config we can use this
    'components' => [
        'assetManager' => [
            'bundles' => [
                'dosamigos\google\maps\MapAsset' => [
                    'options' => [
                        'key' => 'this_is_my_key',
                        'language' => 'id',
                        'version' => '3.1.18'
                    ]
                ]
            ]
        ],
    ],

Great


Make header styling consistent everywhere

Instead of only styling headers for the landing page, style them across the entire site.

:+1:

One comment both otherwise :+1:


Extension suggestion

Tools look great, would be awesome to see a year, month, and season extension set added!

Thanks @Flangvik,
Adding month's list is a great idea. I will add following list in the tool.
months : [January, February, March, April, May, June, July, August, September, October, November, December]
mon : [Jan, Feb, Mar, Apr, May, Jun, Jul, Aug, Sep, Oct, Nov, Dec]

You can print year directly in pattern, This will print 20XX,
In future I am also adding ranges like [2000-2099] to make number input easy.
cook 20:n:n

Seasons list might not be useful for everyone, but you can easily add list for yourself by customzing tool Read here https://github.com/giteshnxtlvl/cook#customizing-tool
This also gives me Idea to add time and dates ranges and patterns in the tool.
Thanks :)

Awesome @giteshnxtlvl, I have to disagree on the season's list tho. When performing password spraying attacks I very often see Winter2020! Spring2021! etc. Either way great stuff!

Hi @Flangvik
I have added lists in the new update.
I have also added 3 new features, you might like to check Int Ranges and Patterns/Functions.
Please feel free to share any suggestions to add in patterns.

Awesome stuff @giteshnxtlvl, great work and keep it up! :)

Thanks @Flangvik, I am glad you like them.

no problem
giteshnxtlvl @.***>, 23 Nis 2021 Cum, 21:31 tarihinde
şunu yazdı:

Thanks @Flangvik https://github.com/Flangvik, I am glad you like them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/giteshnxtlvl/cook/issues/6#issuecomment-825843481,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJIKUPR3NOMFGVIT5XXGGRDTKG4GJANCNFSM42U2NLMQ
.


In Rust trait, should pop return a value?

@hirzel brought this up in a PR:

I think pop should not return anything. I can see from the implementation of some of the aggregation algorithms that it lowers the oldest item and returns that. There are two problems with that. First, it is wasteful to do the lowering if that return value gets discarded by the caller. Second, and more importantly, not all aggregation algorithms hold on to that oldest item, so it is unavailable to be lowered and returned. Specifically, Two-Stacks Lite and DABA Lite don't keep around singleton partials for the front portion of the queue, since that portion is optimized for eviction, where it makes more sense to keep around partials for larger sublists.

I had a similar reaction when @segeljakt first designed FifoWindow. The main reason for doing it is that is lines up with Rust conventions. Regarding point 1, I don't think it's a major concern: if the return value of pop is unused, and the call to pop itself is inlined, dead-code elimination should avoid any overhead (even the call to lower should go away).
Point 2 is more of a concern, but I admit I don't fully follow it. Is the problem that in some cases, the partial result from the thing being evicted is nonsensical to return?

Consider this example for Two-Stacks Lite, from page 7 of the arXiv paper:

When we pop "c", the data structure does not contain anything that is just "c". And returning "cd..g" is arbitrary as well as inconsistent with how other algorithms would behave.

Yes, agreed, I understand now. I will submit a PR soon which changes the trait so that pop does not return a value.


[3.x] Implement OS agnostic InputEventGesture with Pan, Pinch, and Twist

this is shamelessy inspired by Federico-Ciuffardi's job on #36953
I have some ideas to implement thresholds to limit the amount of
emitted events but it will be implemented later.
this to be linked to #13139

[gd_scene load_steps=3 format=2]
[ext_resource path="res://icon.png" type="Texture" id=1]
[sub_resource type="GDScript" id=1]
script/source = "extends Node2D
const MAX_ZOOM = 0.5
const MIN_ZOOM = 0.1
onready var cam = $Camera
func _ready():
cam.zoom.x = 0.2
cam.zoom.y = 0.2
func _unhandled_input(e):
if e is InputEventGesturePan:
_move(e)
elif e is InputEventGestureTwist:
_rotate(e)
elif e is InputEventGesturePinch:
_zoom(e)
func _move(event):
cam.offset -= (event.get_delta() * cam.zoom).rotated(cam.rotation)
func _rotate(event):
var fccp = (event.position - get_camera_center_offset())
var fccp_op_rot =  - fccp.rotated(event.rotation)
cam.offset -= ((fccp_op_rot + fccp) * cam.zoom).rotated(cam.rotation - event.rotation)
cam.rotation -= event.rotation
func _zoom(event):
var zf = clamp(cam.zoom.x * event.factor, MIN_ZOOM, MAX_ZOOM)
var zd = zf - cam.zoom.x
var from_camera_center_pos = event.position - get_camera_center_offset()
cam.offset -= (from_camera_center_pos * zd).rotated(cam.rotation)
cam.zoom = zf * Vector2.ONE
func camera2global(position):
var camera_center = cam.global_position + cam.offset
var from_camera_center_pos = position - get_camera_center_offset()
return camera_center + (from_camera_center_pos * cam.zoom).rotated(cam.rotation)
func get_camera_center_offset():
return get_viewport().get_visible_rect().size / 2
"
[node name="Node" type="Node2D"]
script = SubResource( 1 )
[node name="Sprite" type="Sprite" parent="."]
texture = ExtResource( 1 )
[node name="Camera" type="Camera2D" parent="."]
rotating = true
current = true

For the record, I plan to focus on getting #39055 finalized and merged first, then we can update and merge this PR too for 3.5 ideally.
When we get to it though, we might need to change some things for 3.x specifically to avoid breaking compatibility (i.e. keeping the old names for the existing events and just update their implementation + add Twist).

For the record, I plan to focus on getting #39055 finalized and merged first, then we can update and merge this PR too for 3.5 ideally.
When we get to it though, we might need to change some things for 3.x specifically to avoid breaking compatibility (i.e. keeping the old names for the existing events and just update their implementation + add Twist).

Dude, im sorry but good luck getting this pr finished anytime...


Seperate windows are not resizable

The non-main windows are not resizable.

Some windows would have no benefit of being resizeable

They would for my workflow. I don't like having a ton of small windows around, I often tile stuff to the sides or maximize them.

Currently usable windows now dont have a maximum size anymore


[BUG]

Bug Description
First time I play something it plays OK, but when the queue ends it doesnt actually clear or stop the queue, so my song ends and when I play something else it shows that the song was added to the playlist but never plays.
The queue never actually clears after the end.
Expected Result
A clear and concise description of what you expected to happen.
Versioning:

NPM Version [e.g. v6.14.9]
Module Version [e.g v6.4.0]

And also even the queue finish the isPlaying function shows as true, but should be false.

Looking into it.

Should be fixed in the last PR #73, I will push the changes to NPM in 1-2 days.


Getting Started with PyTorch

NOTE: We tend to stray away  or tend not to publish reviews/comparisons of commercial product offerings.
Brief Summary:
PyTorch is a fast-growing library for machine learning. It's especially common in research, being used by OpenAI and academic researchers alike. In this tutorial, we will setup PyTorch and use it to classify images of handwritten numbers.
Key Takeaways:

Install PyTorch (the tutorial would be on Windows)
Download image data to integrate with PyTorch (we'll use the KMNIST dataset)
Learn the basic concepts of PyTorch (tensors, neural network models)
Build an image classifier neutral network model

References:
Please list links to any published content/research that you intend to use to support/guide this article. (If none, please indicate 'N/A'.)

https://pytorch.org/tutorials/beginner/deep_learning_60min_blitz.html
https://pytorch.org/get-started/locally/
https://visualstudiomagazine.com/articles/2020/06/08/getting-started-pytorch.aspx
https://pytorch.org/docs/stable/torchvision/datasets.html#kmnist
https://github.com/rois-codh/kmnist

Thank you for your topic suggestion. Per the message posted in Slack last week, we are pausing acceptance of new articles until further notice while we work through the backlog of submitted drafts. We will notify you when we are ready to accept new topic suggestions. Thank you for your patience.

Thank you for your topic suggestion. Per the message posted in Slack last week, we are pausing acceptance of new articles until further notice while we work through the backlog of submitted drafts. We will notify you when we are ready to accept new topic suggestions. Thank you for your patience.


1MB Upload limit

please add to the Nginx Config file:
http {
    ...stuff...
client_max_body_size 100M;
    ...stuff...
}```

By default the limit is 1

Changed the documentation, added your fix to the document and credited you at the top as a contributor.
Thank you for the find on that one.


licence??

MIT, added this to a repo
https://github.com/Jamminroot/intag/commit/4dc34f8f666db89d41ac39119b79f13c703055ae
https://github.com/Jamminroot/intag/blob/master/LICENSE


Add Docker Compose configuration for development purposes

What this PR does / why we need it: Simple dev workflow enhancement to allow running core with its dependent services.  In the future, I hope to make this debuggable.
I'm open to changing it the PR as it stands was expecting:

make changes (IDE would likely incremental compile)
docker-compose up would compile as necessary and run
manual testing whatever
shut down and repeat

I haven't yet built a whole dev workflow, so there may be an alternative that is better.  One idea from @mrzzy is to keep the code container with just a shell running and use docker exec to run mvn or other commands.
Eventually I would like a whole debugging setup but this seemed worthwhile as a separate PR.
Which issue(s) this PR fixes:  N/A
Does this PR introduce a user-facing change?: No
NONE

/assign @zhilingc

👍 Thanks for the PR. I can finally retire my hacked together docker-compose dev setup to develop Feast Core. It would be nice see to something similar for Feast Serving.

Thanks for this again. I'm wondering if it makes sense to update the Development Guide to include this flow? That could make it easier for new users to get up to speed.

@woop sure, I'll add the docs if you are ok with the approach.

This flow isn't typically one that I would use. @khorshuheng would you mind reviewing? You had thoughts on this before.

/lgtm

/approve


Oncoplot Genes in At Least A Number of Samples Option

It would be nice to have an option similar to top that allowed the user to specify all genes with variants in at least a minimum number of samples. I'm trying to plot all genes mutated in 3 or more patients out of 20 and using trial and error to set top but it could be made easier.

Hi,
I have added minMut argument to oncoplot.
Usage:
# Draws all genes with 5% mutation rate (if minMut <1, it will be considered as % mutated)
oncoplot(maf = laml, minMut = 0.05)

# Draws all genes with 5 alterations
oncoplot(maf = laml, minMut = 5)

Please check this and let me know if it works as expected..

Very convenient!


Implement LaTeX tag completion

It would be nice to have a completion for tags such as \begin{ and \chapter{ etc. including the proper suggestion after \begin{, i.e. list, enumerate, equation, etc. I am not sure whether some kind of completion engine for LaTeX already exists that could be used here (I checked the builtin completers of YCM and they all seem to use/query some already existing library/engine (see, e.g., python completer which uses Jedi).
If there is no such engine and nobody has worked on this already, I might give it a try and do it from scratch. However, I am not sure if it is wise to basically create a new library to handle all the LaTeX commands (i.e. one has to somehow define what values are possible after a \begin{) by hand. Maybe there is a more intelligent way to create such a tool. Any ideas?

Hi,
It would be nice indeed, but I don't know any library that does that for LaTeX (maybe a simple dictionary lookup is enough for such purpose).
I won't have time to work on that though. If you want to give it a try, don't hesitate.
Thanks a lot,
Best,
Corentin

I will go ahead and implement this. Unfortunately I don't have much spare time either so don't expect much any time soon. However, you can leave this issue open and I will provide updates here.

After giving it some more thought, I'm not going to do this. I realized this is a huge undertaking with little benefit. After all, the identifier completion of YCM does contain all of the tags I use within the file and I rarely use any other tags.

Sorry for the late answer, I definitely agree with you.
I'm closing this one, we can always reopen it if we feel the need.
Best


Update main.tex to add contents from the paper

Update main.tex to add contents from the paper.

pre-commit.ci autofix


Scout Rust graph libraries

Look for graph libraries to be used as an addition to self-implemented data structures or basic algorithms.

https://github.com/petgraph/petgraph

https://crates.io/crates/daggy
https://github.com/sebschmi/abstract-datastructures-rs
https://github.com/sebschmi/bigraph-rs

https://chiselapp.com/user/fifr/repository/rs-graph/doc/release/README.md
https://github.com/purpleprotocol/graphlib
https://github.com/yamafaktory/hypergraph


[BUG] Test DeletePitMultiNodeIT.testDeleteWhileSearch is flaky

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch" -Dtests.seed=CE842172B3367A4B -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-MX -Dtests.timezone=Europe/London -Druntime.java=20

from
Gradle Check (Jenkins) Run Completed with:
RESULT: UNSTABLE ❕
TEST FAILURES:
1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch
URL: https://build.ci.opensearch.org/job/gradle-check/21640/
CommitID: https://github.com/opensearch-project/OpenSearch/commit/7d261931a92516ced757da26c22da7c6dbd0758d
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Removed the search label and added indexing to direct this to the right place.
cc: @anasalkouz

Fixed in https://github.com/opensearch-project/OpenSearch/pull/10946


Allow sorting of stream members

Once #21233 is merged, both the Create stream and stream subscribers UI will have tables of stream members. We should allow both of these tables to be sorted in the same ways as the Organization settings > Users table (same UI, same sorting functions).

@zulipbot claim

@zulipbot claim

@zulipbot claim

@alya just for confirmation should I work on this issue? Because it has been almost a year since this issue was opened.

Yep, this is still a fine one to work on -- thanks!


Signals

This PR adds the (optional) ability to include lists of group memberships in SAML assertions, and then act on membership in those groups to manage Django User's staff, active, and superuser attributes.
As mentioned above, if you don't add any groups to the settings.py, nothing will happen differently than before.
Users without membership in any of the configured groups are not touched.
It is recommended to use the SAML IdP to determine who is and is not allowed to log in; then those that are allowed to login should belong to one of the configured groups.

Much like the parallel PR for sal-saml, this implementation does nothing to users who are not members of any of the configured groups.
If the consensus is that we should instead let all users who are not members of the higher-level tiers of access get defaulted into a base-level, in this case probably "active" and NOT superuser or staff, than I can modify the PR and update the docs to match.

@sheagcraig can you add this to the readme please?