Type checker doesn't detect usage of optional properties

Hello {{name}}!

Today is **{{% return now.toISOString() %}}**.

{{last}}

namespace<EMAIL_ADDRESS>
@template
concept HelloWorld {
    o String name
    o String last optional
}

Context
This is detected if last is used in a TS expression, but not as a simple variable.
Expected Behavior
Should raise an error that {{last}} is being used and is an optional.
Actual Behavior
Runtime failure:
Error: No values found for path '$['last']' in data [object Object].

Possible Fix

Steps to Reproduce

Existing issues

[ ] Stack Overflow issues
[ ] GitHub Issues

Context

Your Environment

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):
Link to your project:

Hello @dselman permit me to work on this issue


Supports Raw Json only

Modified to support only raw data ( otherwise tx_id causes issues) .  Travis removed as of limited use ( tests use exec.Command which means they need an installed version and are not true unit tests)

 (8) Test Harness Posts Encrypted/Signed Submission to EQ RabbitMQ

Readme aside , my linter and formatter is missing most of these . Do you use any specific linter settings.
Regards
Torrance
Andrew Torrance
Senior Consultant
E Andrew.Torrance<EMAIL_ADDRESS>[cid:image02678b.PNG@de6894b5.429eb71a]http://www.qa.com/Consulting
Proud training partners to the:                               With:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>aws-restart.comhttps://aws-restart.com
Follow us on:
[Facebook]http://www.qa.com/facebookqac [LinkedIn] http://www.qa.com/linkedinqac  [Twitter] http://www.qa.com/twitterqac  [Glass Door] http://www.qa.com/glassdoorqac
W
Salford Quays
Greater Manchester
M50 3YJ
QA Consulting Services Ltd is a company registered in England and Wales. Registration Number 5962875

From: J Gregory<EMAIL_ADDRESS>Sent: 10 October 2017 14:51
To: ONSdigital/sdx-encrypted-submitter
Cc: Torrance, Andrew; Author
Subject: Re: [ONSdigital/sdx-encrypted-submitter] Supports Raw Json only (#3)
@necrophonic commented on this pull request.

In README.mdhttps://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=r5p1FN-pZ-2ZJuSZeMrup-IyPr2c4pOz0Bob3Qt9hY3BBqm0peLNORSGfHk-Sa6ons5CUJu-Va74Gg1Xx2ZnJkwEYiQB3ytmWW3Y8gc_czF1WQjX0XrTq8D8glPXiin7uc0Nl1hx1n05PLBUWLmr2RdlTVY8b6KfWEiacOIeSVJ8xkM7bfD4nONUuOwmrWpZmpLGVkMI1SZ6gPPoJlySd9V88a2Wi0DwNPyj7Fkz3KFSTZcSAm-yeSbScWo-aYpvHUJuUNDzy2PK2-5_fwRDPma8G8uF_6GgqsrH3u5aXcM:

@@ -66,14 +101,310 @@ vhost: "%2f"
routingkey: "survey"

-Example sdx-submitter.yml working locally on developer machine
+Example sdx-encrypted-submitter.yml working locally on developer machine
+
+
+### License
+
+Copyright (c) 2016 Crown Copyright (Office for National Statistics)
+
+Released under MIT license, see [LICENSE](LICENSE) for details.
+

Why are there almost 300 blank lines been added?

________________________________

In authentication/authentication.go<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=73CbITwFXLshyzv35SIGIKd-3Q_SSUnt7oBGaAzO5kLmVgOFfGTPWWD4VKsDcvqE6OGFwTtYFC_krfEvoTVFYlgAe6EGKkmgbyYB7gPGfeC0yrsOivFjuyEGUFi1SMixEIODZAZmdSp-s3KwDa7HGGhEtQMKp7C3p3gFRNUdo5ZshYF5yI3t5mvXvm2DwQmJiX8fSlgsf-9AA03TidJsVKIq8kOJ9QXpx10aQM09jvjy2X7TsftiymauqbyUJvBVRyVSqQq8VA1CFGQC9LXgQROw9KuJOcdsHd7MxnE0zlQ>:

> @@ -0,0 +1,153 @@
+package authentication
+
+import (
+       "crypto/rsa"
+       "crypto/sha1"
+       "crypto/x509"
+       "encoding/pem"
+       "fmt"
+       "gopkg.in/square/go-jose.v2"
+       "gopkg.in/square/go-jose.v2/jwt"
+       "io/ioutil"
+)
+
+// wraps raw data in JWT and JWE

Comments on exported functions should start with the name of the function:

// GetJwe is a thing that does a thing
func GetJwe( ... ) { ... }

________________________________

In authentication/authentication.go<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=3Db_1oIV2UX2i76CJ8hOShC_zr-vxHY1pEv-0WpYXK6QCDPUxHLK6e7PBh2300sQG7YaEbYDSNLwvwShTWAaBJ5JjTgFcRh1vM4SsdOxuEO-nt3ZjKNRXEyjXZGAm_nyhyCyyzjghN39MnjYJHD7YsndD5oI2JmTU1U61scO833eAU7buaNolTmLN9oZHtLuKjrSfiu2zCs0wUm-dmWaJi4EmlB0Pxgrni-JJ7mnoFde30xpH8cC2UZmy4ojx1OxJiiBaPzRR744dKzrEch2ghBkC5yNjUEGQjSudU9hF-0>:

> +import (
+       "crypto/rsa"
+       "crypto/sha1"
+       "crypto/x509"
+       "encoding/pem"
+       "fmt"
+       "gopkg.in/square/go-jose.v2"
+       "gopkg.in/square/go-jose.v2/jwt"
+       "io/ioutil"
+)
+
+// wraps raw data in JWT and JWE
+func GetJwe(rawClaims interface{}, signingKeyPath string, encryptionKeyPath string) (string, *TokenError) {
+
+       privateKeyResult, keyErr := loadSigningKey(signingKeyPath)
+

No blank line

________________________________

In authentication/authentication.go<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=jXr0Y0X2lgJb85tJYKgXu7Gul2EKhMF7g2GVw7dOwfPKOLAvemJs-ubQKoBCljxcKu2aqku4rJu6FM4w5u_cIp4pttu1Bztpd6Z32QhBX14SedAkPG-TgFdl2tv44zAtyG68oAsCYs3Us9Kx9LnDYdvEsMpJANIoXD-GQ8VBkpvvk--InJZwxmeKfD7CA8nyDBxKqJ5MfpxNHUjhlybmIc1yFAz3RWVy7QABY5AMGtIvPHt0abunUZc93oFTgpmdI-PoU2NWvvZpgrIwAjiQldOrWYu4kQF7wc4ucaDLdG0>:

> +     signer, err := jose.NewSigner(jose.SigningKey{Algorithm: jose.RS256, Key: privateKeyResult.key}, &opts)
+       if err != nil {
+               return "", &TokenError{Desc: "Error creating JWT signer", From: err}
+       }
+
+       encrypter, err := jose.NewEncrypter(
+               jose.A256GCM,
+               jose.Recipient{Algorithm: jose.RSA_OAEP, Key: publicKeyResult.key, KeyID: publicKeyResult.kid},
+               (&jose.EncrypterOptions{}).WithType("JWT").WithContentType("JWT"))
+
+       if err != nil {
+               return "", &TokenError{Desc: "Error creating JWT signer", From: err}
+       }
+
+       token, err := jwt.SignedAndEncrypted(signer, encrypter).Claims(rawClaims).CompactSerialize()
+

Should avoid blank lines between the method call and the error handler

________________________________

In sdx-encrypted-submitter.go<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=-uTcf7XxUIkTw42w5Iq3NICvwyfwzIrbwABFaAJJAGswMHoE4lwoisFXYhO1hgiRurJul-_ADxgAF524yJk7jy3e0h-mtagQ8tpVevDia0q-92fXprbKnU2eSlZSRqj4CQFk-1ZxX4ZWQwk8rW-eIKlrJwAP0RnJKYwrgYKod7wlY-n9JCYAyQ3wFO5t14sc3QcLeeMiWQz6OrXy6O5kAgglRYcFC433ETSiM72aCYD1fWz3rJToJtP7fS8nLzn_4DhUu-rgqBsdLw1WmKd3e1cDxqqHtN_m8utmRdDMDUs>:

>       exitOnError(messageError, "could not read message body")

-       // If encrypt specified then encrypt
-       // if sign specified then sign
+       var mappedData map[string]interface{}
+       fileErr := json.Unmarshal(message, &mappedData) //file contents are arbitrary Json
+       txID = fmt.Sprintf("%v", mappedData["tx_id"])
+       exitOnError(fileErr, "Could not marshal Json from input file")
+
+       jwe, tokenError := authentication.GetJwe(mappedData, config.SigningKeyFile, config.EncryptionKeyFile)
+       message = []byte(jwe)
+       if tokenError != nil {
+               exitOnError(errors.New(""), fmt.Sprintf("%s %s", (*tokenError).From, (*tokenError).Desc))
+

No blank line

________________________________

In sdx-encrypted-submitter.go<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=_BMYrTUJvYH6LPrf9D5s4wQ2WtbXOqWBTVK9FgXpTLPJKluLYIf--UEf8ICnRVO-L1ZlG2RrRSpsKWaqhXIew_1UzSBpQu-G2Hh7g9vidP-_N0eNRGG_7JYWAea9cDmPgsx4-q7aYDfnqsQaEqNnNnc51DMME092cEURxdIr594azZgpk3ZCViVtOfbMLrK2aw-95DEBy__48SDV6OkFZ2fZdwPMxe3IFDXjuIGAn7vmRLdhVSj4cKHySYvVsTblsNz8MvXBetlw5JZRijqZreTOzH_FqDdSC9q4FajyNV8>:

>       exitOnError(rabbitError, "unable to send message to rabbitmq")

       fmt.Printf("message from file:'%s' published to exchange:'%s' using routing key:'%s\n", config.MessageFilePath, config.Exchange, config.RoutingKey)
}

func exitOnError(err error, msg string) {
       if err != nil {
-               fmt.Println("%s: %s", msg, err)
+               fmt.Println(msg, " - ", err)
               os.Exit(1)
       }
}

// Consider adding stdin reading here to support piping ?

For comments like this, prefix with a \\ TODO

________________________________

In README.md<https://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=ILAcU1Ju2KmZQMeByqYrozk5dAyerufVLl7CCE0p4QcZbnoAZQnkAR_UPO7Ida6HxH9cPkxR0iQD_63SwdjzDw4rMZEAeWI_fLQd43Ghr4O1WzW-WSztBSpw-gECF5melJiHdhmV_o1akNTCwHGK7hTg77bKNU3aC1M3vkcQb3K36hECDP3D3AZCE83PKnIuQYnTK5U2UMhj4pJRhNhGz6H_bl--ZlSg5_szKl4OA__UaROSXRrofTM2UoV2nnswoFpLykZGgI0Qy6ANP6V3Y1dWrOhMFmbgObemUnba0LI>:

> @@ -66,14 +101,310 @@ vhost: "%2f"
routingkey: "survey"

-Example sdx-submitter.yml working locally on developer machine
+Example sdx-encrypted-submitter.yml working locally on developer machine
+
+
+### License
+
+Copyright (c) 2016 Crown Copyright (Office for National Statistics)
It's 2017

In authentication/authentication.gohttps://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=7xiuzWcqyTa0_NCZXqbXcBVoY06uAvSCc1gAeUkoU1wimzucncN_Gfai7w5RL0lMTZrAsTiW4NtgdPAyrqP1-lyET1WaAcBQ4uLHsuSkAroVM-lBi5piVVdbWsbbaUWYLjk6_8ZrXZAITmQgfVkjY3nfGw4wBNbD_cfGye93nFzc9vAGtu4JL7D36ZTzMwlN4H_5pQ9dd8yvIakDJoXOlbozcnurLjq0AL1LgPbsEmqv1vJlVI9yZOq3J5zlQCS9OnG93L7x9dXtchvd6G1qqFg6bGHaofMGpZCFqUW1lSc:

if err != nil {

          return nil, &KeyLoadError{Op: "parse", Err: "Failed to parse encryption key PEM"}

  }

  kid := fmt.Sprintf("%x", sha1.Sum(keyData))

  publicKey, ok := pub.(*rsa.PublicKey)

  if !ok {

          return nil, &KeyLoadError{Op: "cast", Err: "Failed to cast key to rsa.PublicKey"}

  }

  return &PublicKeyResult{publicKey, kid}, nil

+}
+
+// TokenError describes an error that can occur during JWT generation
+type TokenError struct {
Why custom errors?

In authentication/authentication.gohttps://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=sEXdrQyMtjtgF70l7FRHn6pLmEa678WULSnpxBhFNAMZdEmQf5OewbZAsQhoZanYUAskW9tW90j5dKfC1AWeV5eq8aLPowIeRwM54cCQofQNVXunbHRs3yspmkY7HHMX7ai6S6ugB_UBsMdNREgcbVPGS754dearqIFBEmHdmOGEQe_8qt3mosrAiwvT-7wPjlW5CYNqiV0UEEtKTJfIbrz_BiS9IHQoD4zpzMDbF3ezk3hR7k6ZPtugSo2uR-vSL7uZxI2LBgpfSQ8hJ9AEoa2u22IYnlirOLsJX09ouDs:

+import (

  "crypto/rsa"

  "crypto/sha1"

  "crypto/x509"

  "encoding/pem"

  "fmt"

  "gopkg.in/square/go-jose.v2"

  "gopkg.in/square/go-jose.v2/jwt"

  "io/ioutil"

+)
+
+// wraps raw data in JWT and JWE
+func GetJwe(rawClaims interface{}, signingKeyPath string, encryptionKeyPath string) (string, *TokenError) {
+

  privateKeyResult, keyErr := loadSigningKey(signingKeyPath)

Just err is idiomatic rather than ``keyErr`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=tynvfomUlU21sWXPjGigAkzmtDUL8_zcq5NFqnalNEljuSdqm3pvPhBcMUe0EJWFlFgvAL4iSsBOBmfQezWhIJ_dG0whVMwF3vZ9dTCGdfrHdcfEsO-SInqKbFk5qpb5MsAC50qWvRHpfXAVK09uaCV74vt0wzf2aB_oduRnpIlJYIaLfmz1qtHs0IIDyf0mh2-C3hB_mudYxXvOc4rYKA0RiDkEFXI_2NjbThgSMJs2u3CfKvikWdlYgfjTcVwxv__UpjUfjJAYniOzVg1FOcDzf3uWBIbf_ervSLvy4uZ8FQ3C1oJr9sXNd5CGk2NS, or mute the threadhttps://url4.mailanyone.net/v1/?m=1e1uw8-0004Dj-3H&i=57e1b682&c=8Nu0Zl7LiAjXoAVxRiwywz8tAxYgLCsPoBk6F0tNke-_doHuvpPtflEG2YDBM1rZ80eG1U0GNGi498l797W5X-AeAvZmjZDQyOVmAmsjutyFSWh6ZT_461Y8Uji9M1RshiJmWdAJZF9BKtIqi20zcnEyrIkgSvPwwhLQwPwT2eQsRs4wSnNWTITHdZeaXhEjyjVIjP-mIpnVW8t6Rm0d6XYfvEKeNNHv-DnCTCdrvipp8HxyLi2BUOkzkKBAFIZNnhDlpaKlw97a-MPwDeSTU0snDDg0s-gNEozqdH3PbYByF0PhaNzOCn4c0XvwySz-6mtTUccsTHiGTESwEWD2UQ.

QA works with organisations to transform performance through learning. We are dedicated to making our clients more successful through the provision of world-class training services.
To find out more visit www.qa.com
The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer.
QA Ltd. Rath House, 55-65 Uxbridge Road, Slough, Berkshire,SL1 1SG.
QA Ltd. is a company registered in England with company registration number:2413137

there should be a Makefile with this

Thats odd . I dont get exit status 1 . I think I need to dig ...
Andrew Torrance
Senior Consultant
E Andrew.Torrance<EMAIL_ADDRESS>[cid:imagec94064.PNG@044b3e89.4199e84f]http://www.qa.com/Consulting
Proud training partners to the:                               With:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>aws-restart.comhttps://aws-restart.com
Follow us on:
[Facebook]http://www.qa.com/facebookqac [LinkedIn] http://www.qa.com/linkedinqac  [Twitter] http://www.qa.com/twitterqac  [Glass Door] http://www.qa.com/glassdoorqac
W
Salford Quays
Greater Manchester
M50 3YJ
QA Consulting Services Ltd is a company registered in England and Wales. Registration Number 5962875

From: David Mort<EMAIL_ADDRESS>Sent: 16 October 2017 14:12
To: ONSdigital/sdx-encrypted-submitter
Cc: Torrance, Andrew; Author
Subject: Re: [ONSdigital/sdx-encrypted-submitter] Supports Raw Json only (#3)
@davidmort commented on this pull request.

In sdx-encrypted-submitter_test.gohttps://url4.mailanyone.net/v1/?m=1e45CU-0005E2-3n&i=57e1b682&c=DeaeM6hiJmf8gyL8Av6OOsIk5sNqVcOsdJjTqyAasTKEyUA12VQM3lmHbO1KEFDzzDypxzR7zlxO1qaNfqtbNQccNAczkFZ53EBKe-9Wu7Yd1yNi-Y6mWHd2K12qsgC_4iBohsvRumJh-5mJpGMM7DfItqOzU-CUtvxTJM-edY6Qr-KfpS9C41z2qVNbivBRywRz0eyCQ7tUn__q95p79T2dbHxT2nLjZ2lm5MM9LCl16QPmAtWZeacwuVryeJebvFkvOlWlxU_PWh2O7Xu5wFe6q-VRwchiptqiU9cbFkQ:

"testing"

+)
+
+// Note these are integration tests that assume that the sdx-encrypted-submitter has been installed
+
+func TestNotSupplyingAnyArgument(t *testing.T) {
+

  cmd := exec.Command("sdx-encrypted-submitter", "-e","something.txt", "-s", "somethingelse.txt")

  output, err := cmd.CombinedOutput()

  if err == nil {

          t.Error("No error when one was expected")

  }

  var expected = "could not read message body  -  no file name supplied\n"

  var actual = string(output)

  if actual != expected {

          t.Error("expected ", expected, "got ", actual)

doesn't look like this test is working, the code actually returns "could not read message body - no file name supplied\nexit status 1\n", so maybe change the expected to that too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://url4.mailanyone.net/v1/?m=1e45CU-0005E2-3n&i=57e1b682&c=W8jugEuDPsn5hbddnKaewZhf8FKz0Z0YAGNa2BNh-vRNLEjqJbcwet9nKqDWQzuAZey-IZDGo6Egnp41ldKnMJqRbWH5qSOIodXh034cqiVOoGzMrp4nWlaKhl3UJ842GnK52sjxV5P-RPgAZQyUXy0_-4O1_uPJlJbNQSok7sFYbjtBjJzPywUc9atQhVDKwpuJ4hHXNRiHW8tLWOiDc0p94Dcp7NFUzOhnUF8pZ5U6K3FzE86nCEgt8TRzd0ZFEq2RsrULCdOc2ruAhFaAP7B0kxPWS3ALZ5g6MLBbd1jpLPCgBGWgGHVfCS9xJiT8, or mute the threadhttps://url4.mailanyone.net/v1/?m=1e45CU-0005E2-3n&i=57e1b682&c=i4Yjpy2kLuFlcZbYy_AU7CpYakGU9QaNjoldWDX4yFwuXQrCzsZuu99NbIS83kaUgqdFP96Gaeh2Sn7tHLdpBYYUgH1Xz7sMalEKZU3e_qhFbgV2AesITtpkfM6x66ZnVxnQJdI7CVCbgzSoQwu-OR1hS74PQbS1SURThALOYF4gUbKC-IFb11LGvgDs2Im-2R7jJyT8OZJWnZReTGHK0siaJAOH9087WofTL5o9Yu5MMl4C0BmXECzIvagA9MQ-PoVkQry3g123Q6xJrLCpxvociBRP-b5WEqrXGpqN8qjqGmCohPpAd0zEQHWmSO8Q06iacNNhWXeW9hLB6SowUw.

QA works with organisations to transform performance through learning. We are dedicated to making our clients more successful through the provision of world-class training services.
To find out more visit www.qa.com
The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer.
QA Ltd. Rath House, 55-65 Uxbridge Road, Slough, Berkshire,SL1 1SG.
QA Ltd. is a company registered in England with company registration number:2413137

Can I grab you for 2 mins please . The issue I have is that the authentication directory is currently not in github it is only committed as part of this . If I point to it then it does not build and tests fail . I can understand using github paths if the packages are built independently , but in this case they are not, they are all built together . If I point to GitHub , I suspect I may be always 1 build behind in the authentication in that it grabs the existing version in github , uses that to build. Then I commit any changes so that I am 1 build behind ? Hopefully I am wrong.
Regards
Torrance
Andrew Torrance
Senior Consultant
E Andrew.Torrance<EMAIL_ADDRESS>[cid:image18297e.PNG@e31c328d.4a8e2ac8]http://www.qa.com/Consulting
Proud training partners to the:                               With:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>aws-restart.comhttps://aws-restart.com
Follow us on:
[Facebook]http://www.qa.com/facebookqac [LinkedIn] http://www.qa.com/linkedinqac  [Twitter] http://www.qa.com/twitterqac  [Glass Door] http://www.qa.com/glassdoorqac
W
Salford Quays
Greater Manchester
M50 3YJ
QA Consulting Services Ltd is a company registered in England and Wales. Registration Number 5962875

From: David Mort<EMAIL_ADDRESS>Sent: 18 October 2017 09:24
To: ONSdigital/sdx-encrypted-submitter
Cc: Torrance, Andrew; Author
Subject: Re: [ONSdigital/sdx-encrypted-submitter] Supports Raw Json only (#3)
@davidmort commented on this pull request.

In sdx-encrypted-submitter.gohttps://url4.mailanyone.net/v1/?m=1e4jeQ-0004LM-55&i=57e1b682&c=WX2nt__GLid7RNXLwMfMVQwMKQRR54oKCfYj8fkqPni3gb5wCrxy1QHYDIHlfOHLhVjJbTRUIS_ceEas7Tv3HpOIQoaK15V9r7XmcO-mcvN5bxTyAxMYUbMVRZBbl2gvk2vV0VUi0x6ScqX_-P3v9Ke02jlWmoG0cjXJfazf7mISrDSsrzbhh-rkDlAyJwfxxnmoPCKRZrvBds7gL_xlL6X75QUCo3j8TqvEu2dFZdStRPhLu_GKXVGbySaPtu8ZXAc1V3WJRfoCek4uApsZDfoXAFzNV8JYE4QU5sPagZ4:

@@ -9,10 +10,10 @@ import (
"io/ioutil"
"os"
"path/filepath"

  "sdx-encrypted-submitter/authentication"

its to do with the fact that the code is hosted in github and making your code "go get"-able, please read the "Choose a good import path (make your package "go get"-able)" section in the go documentation https://blog.golang.org/organizing-go-codehttps://url4.mailanyone.net/v1/?m=1e4jeQ-0004LM-55&i=57e1b682&c=dn5b2GCpNh90xtJ8-9zVxbMOsGD6-GgPvo2CTSMNVXw5WZxMNgPcsohw2eUeOnK6embRO33V9jnaF9tWkv8YMAcQQhE-1cM_XkcxsRP_ui1XcLDch1ok5bT02McDO7WFKNBcNa3i-hh1E1Dvofc-KVLOTArj0YhdFbeNVSZG-qtE2RaaR8nCecMBfA7ssOJzwr_lzpoFhqdXGH5AnrNcgX1Zhv2TYB_WFZfK3DutpPsihYFVgpqJbaGokAzKICaj
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://url4.mailanyone.net/v1/?m=1e4jeQ-0004LM-55&i=57e1b682&c=WX2nt__GLid7RNXLwMfMVQwMKQRR54oKCfYj8fkqPni3gb5wCrxy1QHYDIHlfOHLhVjJbTRUIS_ceEas7Tv3HpOIQoaK15V9r7XmcO-mcvN5bxTyAxMYUbMVRZBbl2gvk2vV0VUi0x6ScqX_-P3v9Ke02jlWmoG0cjXJfazf7mISrDSsrzbhh-rkDlAyJwfxxnmoPCKRZrvBds7gL_xlL6X75QUCo3j8TqvEu2dFZdStRPhLu_GKXVGbySaPtu8ZXAc1V3WJRfoCek4uApsZDfoXAFzNV8JYE4QU5sPagZ4, or mute the threadhttps://url4.mailanyone.net/v1/?m=1e4jeQ-0004LM-55&i=57e1b682&c=QF6QmKQ_A8fzfAn-wce2QhpkNIzdLzGZKws2ylPoOgxF5jxDBPnk69j53T-uQBJP_PI6fwlx0o983mcVE4P5dvmrtHkorIJSVoARD91-GtHopGmfN1NEJWbJu4Gazaj0Z4oHfLT_G-A8RwPfQVfovufILuLzLBJcjCPY_Jx9Dw7JX4YqMLurv_DLDXB7Y-JXB4YD6LFqNoDbsPQS5NTeqojITcS1tbEoKG6tMeTANqtBnT336lzDJNeMCp9WHzo0DANsvz9t84ph6U31hpxYF0N3rqoBcHQcfpwLhqTOQ_8aB0F0Es3f9IYuy2pF8VlCm5WtmBYabkDDEERsV5yfVA.

QA works with organisations to transform performance through learning. We are dedicated to making our clients more successful through the provision of world-class training services.
To find out more visit www.qa.com
The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete the material from any computer.
QA Ltd. Rath House, 55-65 Uxbridge Road, Slough, Berkshire,SL1 1SG.
QA Ltd. is a company registered in England with company registration number:2413137

Tested against my local docker compose install using an RCI survey example


2021.07b Sprint Plan

The SAP team plans to address the following issues in our 2nd iteration (sprint) in July 2021:

#117
#119

The iteration lasts 2 weeks and ends on August 2, 2021.

Sprint Results
Closed

#117

Open

#119


Threading issue with startPollingThread (sanitizer report)

Hello,
The following program (minimal reproducible example) is causing ThreadSanitizer warnings:
#include "fmtlog/fmtlog.h"

int main(int argc, char** argv)
{
  fmtlog::startPollingThread();
  fmtlog::setLogLevel(fmtlog::DBG);
  logd("test: reloading");
  fmtlog::stopPollingThread();

  return 0;
}

Compiled with the following line:
clang++-12 -DFMTLOG_HEADER_ONLY -DFMT_HEADER_ONLY -stdlib=libc++ -fno-omit-frame-pointer -fsanitize=thread -g -std=c++20 -o main main.cpp

Output:
% ./main
==================
WARNING: ThreadSanitizer: data race (pid=21198)
  Read of size 1 at 0x00000100d370 by thread T1:
    #0 fmtlogDetailT<0>::startPollingThread(long)::'lambda'()::operator()() const /home/matthijs/t5/./fmtlog/fmtlog-inl.h:331:14 (main+0x5146b9)
    #1 decltype(std::__1::forward<0>(fp)(std::__1::forward<fmtlogDetailT<0>::startPollingThread(long)::'lambda'()>(fp0)...)) std::__1::__invoke<fmtlogDetailT<0>::startPollingThread(long)::'lambda'()>(0&&, fmtlogDetailT<0>::startPollingThread(long)::'lambda'()&&...) /usr/lib/llvm-12/bin/../include/c++/v1/type_traits:3694:1 (main+0x5145cd)
    #2 void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fmtlogDetailT<0>::startPollingThread(long)::'lambda'()>(std::__1::tuple<0, fmtlogDetailT<0>::startPollingThread(long)::'lambda'()>&, std::__1::__tuple_indices<>) /usr/lib/llvm-12/bin/../include/c++/v1/thread:280:5 (main+0x5144e5)
    #3 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fmtlogDetailT<0>::startPollingThread(long)::'lambda'()> >(void*) /usr/lib/llvm-12/bin/../include/c++/v1/thread:291:5 (main+0x513a35)

  Previous write of size 1 at 0x00000100d370 by main thread:
    #0 fmtlogDetailT<0>::stopPollingThread() /home/matthijs/t5/./fmtlog/fmtlog-inl.h:345:19 (main+0x4c23e7)
    #1 fmtlogT<0>::stopPollingThread() /home/matthijs/t5/./fmtlog/fmtlog-inl.h:607:31 (main+0x4c2376)
    #2 main /home/matthijs/t5/main.cpp:8:2 (main+0x4bf462)

  Location is global 'fmtlogDetailWrapper<0>::impl' of size 10496 at 0x00000100aa80 (main+0x00000100d370)

  Thread T1 (tid=21200, running) created by main thread at:
    #0 pthread_create <null> (main+0x44d02b)
    #1 std::__1::__libcpp_thread_create(unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-12/bin/../include/c++/v1/__threading_support:509:10 (main+0x5139a9)
    #2 std::__1::thread::thread<fmtlogDetailT<0>::startPollingThread(long)::'lambda'(), void>(0&&, fmtlogDetailT<0>::startPollingThread(long)::'lambda'()&&...) /usr/lib/llvm-12/bin/../include/c++/v1/thread:307:16 (main+0x513581)
    #3 fmtlogDetailT<0>::startPollingThread(long) /home/matthijs/t5/./fmtlog/fmtlog-inl.h:330:11 (main+0x4c231e)
    #4 fmtlogT<0>::startPollingThread(long) /home/matthijs/t5/./fmtlog/fmtlog-inl.h:602:31 (main+0x4c228a)
    #5 main /home/matthijs/t5/main.cpp:5:2 (main+0x4bf456)

SUMMARY: ThreadSanitizer: data race /home/matthijs/t5/./fmtlog/fmtlog-inl.h:331:14 in fmtlogDetailT<0>::startPollingThread(long)::'lambda'()::operator()() const
==================
ThreadSanitizer: reported 1 warnings

Is this something to worry about?
Regards, Matthijs

The reported data race should be on volatile bool threadRunning, this variable is used to notify the polling thread to exit so it's expected behavior, you can ignore the warning. Thanks.


Module resolution not correct in atom-typescript in @types

I'm having a problem with tsc correctly finding values and atom-typescript failing. I have all of the relevant types installed under node_modules/@types

atom-typescript: 11.0.4
linter: 2.2.0

atom-typescript in app lint:
Error	Typescript	Cannot find module 'http'.	4:23
Error	Typescript	Cannot find module 'https'.	5:24
Error	Typescript	Cannot find module 'fs'.	6:21
Error	Typescript	Cannot find module 'path'.	7:23
Error	Typescript	Cannot find module 'child_process'.	8:23
Error	Typescript	Cannot find module 'bunyan'.	12:25
Error	Typescript	Cannot find module 'config'.	13:25
Error	Typescript	Cannot find module 'hashids'.	14:26
Error	Typescript	Cannot find module 'lodash'.	15:20
Error	Typescript	Cannot find module 'passport'.	17:27
Error	Typescript	Cannot find name 'require'.	18:28
Error	Typescript	Cannot find module 'phantom'.	19:26
Error	Typescript	Cannot find module 'restify'.	20:26
Error	Typescript	Cannot find name 'require'.	21:17
Error	Typescript	Cannot find name 'require'.	24:18
Error	Typescript	Cannot find module 'mailgun-es6'.	25:26
Error	Typescript	Cannot find name 'process'.	38:12

tsc: 2.2.1

tsc output:
>> tsc src/index.ts
src/generalFns.ts(34,14): error TS2693: 'Promise' only refers to a type, but is being used as a value here.
src/routes/customers/index.ts(9,48): error TS2694: Namespace 'Logger' has no exported member 'Logger'.
src/routes/invoices/index.ts(35,48): error TS2694: Namespace 'Logger' has no exported member 'Logger'.
src/routes/invoices/index.ts(335,21): error TS2304: Cannot find name 'SalesOrder'.
src/routes/types.ts(6,64): error TS2694: Namespace 'Logger' has no exported member 'Logger'.

tsconfig:
{
  "compilerOptions": {
    "outDir": "./build",
    "rootDir": "./src",
    "target": "ES5",
    "module": "commonjs"
  },
  "compileOnSave": false,
  "filesGlob": [
    "./src/**/*.ts"
  ]
}

One thing that I noticed is that it does find the module for moment, but the moment d.ts is located in the module directory and not in the @types directory.
How to I get atom-typescript to resolve in the same way as tsc?

Typescript (both tsc and atom-typescript because it uses tsserver which shares code with tsc) will automatically pick up all of the types installed in node_modules/@types. I just tried it with your exact Typescript version and tsconfig.json.
Things to try:

Restart Atom
Make sure there's only one node_modules and one tsconfig.json file in the project
Run npm i @types/node to make sure they're installed (top level directory)
Rebuild the project from the ground up in a new directory

P.S. filesGlob is not a supported tsconfig.json property. You should use include instead.

@guncha None of the above helped. It looks like there are other people having the same issue.
#1307 #1209 #1142 #1059 and possibly #994

I kept reading the issues and discovered that there was a project in my deps that had a dep to a typescript that was in the 1.8.x version.  I added a dep in my project for the currently installed typescript (2.2.x) and everything works fine. For anyone else who is having this issue, make sure there is no out dated typescript dependency. (You can view all depends by running npm ls in the base directory.)


Problem details returned as application/json

Error responses using the RFC 7807 Problem Details format are being returned as application/json instead of application/problem+json

Addressed with 7898fc2 (available in v5.9.0)


irmin-containers: partially revert 046ec54f38103e00561fa71144e6466e97…

…7aa63c
This did contain an unrelated change which ; the generive functors are needed
for Irmin_containers.Linked_log as there is some global state.
Any given instantiation of Linked_log is not interoperable with any other,
since the instantiations define pools over which the logs are shared
Spotted by @CraigFe

Thanks. There is a CHANGES entry about this that I think also needs removed / edited.

Fixed.


The value is modified while setter is called

Dear Author,
I found while setter is called,the private backend value is already modified.

Do you mean that when the public property is called that the private backing variable already reflects the value? If so, then yes, that is by design. The main reason for SetProperty is, so that if there are rules that you have in the property setter that those are applied when a value is set in the inspector. Does that make sense?


add SpellBinding

A daily word puzzle game (construct words using specified letters) has been up for about a month at:
gemini://tilde.cafe/~spellbinding/

@stacksmith Please open a PR and add it to the README.md.


Is the Video.js adapter supposed to allow for controlling iframes with videojs?

http://jsfiddle.net/q815knga/7/
I thought that the adapter would allow for controlling an embedded iframe through player.js. Am I looking at this all wrong?

Wonder the same...

No, if you are using an embedded iframe, vjs doesn't enter the picture.
http://jsfiddle.net/j8e0y2k6/


fix yet another KeysByIdUsage bug

In this case, dealing with a primary key that doesn't have any key flags and no subkeys.

r? @oconnor663


"service component could not start" Source: SQL Server Import (Extension)

Issue Type: Bug
When I start Azure Data Studio I get notification staying that;
"service component could not start"
Source: SQL Server Import (Extension)
Then, If I try to run the import wizard, I get the following;
command 'flatFileimport.start' not found
Azure Data Studio version: azuredatastudio 1.11.0 (460c739a8d90bdbbde39e01abfb8ecdc278ea787, 2019-09-06T17:09:00.875Z)
OS version: Linux x64 5.0.0-29-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2942)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
15.55GB (4.00GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
0%

@rmvp can you ensure that you have the latest version of the import extension?

@chlafreniere
Name: SQL Server Import
Id: microsoft.import
Description: SQL Server Import for Azure Data Studio supports importing CSV or JSON files into SQL Server.
Version: 0.10.0
Publisher: Microsoft
VS Marketplace Link: undefined?itemName=Microsoft.import

I'm going to close this as a duplicate of #2716 since they seem to be the same. Please use that one for updating with further information!


Style input

Is it possible to style the time picker input?
I've added a custom class, but the styles seem to be getting ignored.

You can either add !important to force apply any CSS properties or use a higher priority CSS selector for the target <input />.
Check JSFiddle Sample here.

Duplicates of #77


Expose the git_commit_header_field function.

This accesses individual header fields in the object database representation of commit objects. These header fields can be seen by running the following command in a git repository:
git cat-file -p $(git rev-parse HEAD)

Thanks!


Update Content-Security-Policy for "wildcard directive" findings

See : CG145 and 2021-V007-RA-5 and 2021-V008-RA-5
In order to provide exemplary web security, and remove Zap findings, we should update Kibana and account.fr to use comprehensive content-security policies.
For Kibana (7.6?) the policy is:
content-security-policy |script-src 'unsafe-eval' 'self'; worker-src blob: 'self'; style-src 'unsafe-inline' 'self'

the finding is:

The following directives either allow wildcard sources (or ancestors), are not defined, or are overly broadly defined:
img-src, connect-src, frame-src, frame-ancestors, font-src, media-src, object-src, manifest-src, prefetch-src, form-action
The directive(s): frame-ancestors, form-action are among the directives that do not fallback to default-src, missing/excluding them is the same as allowing anything.

Based on https://w3c.github.io/webappsec-csp/#parse-serialized-policy, I think the policy should be something like: Content-Security-Policy: default-src 'self'; script-src 'unsafe-eval' 'self'; worker-src blob: 'self'; style-src 'unsafe-inline' 'self'  where we've added default-src: 'self'
This should be configurable based on the csp.rules settings at https://github.com/elastic/kibana/blob/master/docs/setup/settings.asciidoc
For account.fr, the CSP for, say, https://account.fr.cloud.gov/signup is:
content-security-policy: default-src 'self'; script-src 'self'; connect-src 'self'; object-src 'self'; frame-ancestors 'self'; img-src 'self' *.cloud.gov; style-src 'self' *.cloud.gov *.googleapis.com; font-src 'self' fonts.gstatic.com *.cloud.gov

The ZAP report is:

The following directives either allow wildcard sources (or ancestors), are not defined, or are overly broadly defined:
form-action
The directive(s): form-action are among the directives that do not fallback to default-src, missing/excluding them is the same as allowing anything.

It seems like we should a) remove the googeapis.com, b) add form-action

Security considerations
[note any potential changes to security boundaries, practices, documentation, risk that arise directly from this story]

@pburkholder does that mean we can close this issue?


new version 0.5.4 is bugged, dont generate output files, seems that it doesnt download resorces either...

new version 0.5.4 is bugged, dont generate output files, seems that it doesnt download resorces either...
the last version 0.5.3 has perfectly worked, its only a prob of the new one
(first installed the new over the old version, after i saw that the eroor occures i deinstalled buzz and installed the new fresh. but changed nothing. still same error)
PS: windows

update:
old resources in .cache\whisper deleted, now loading of new ones works. ok
but generating output files is buggy, sometimes an output file is generated, sometimes not.

and "if" an output file is generated, sometimes its correct, sometimes its an empty file...

That's really weird. Are you on Mac/Windows?

windows.
especially the high profile causes problems.
try just a test mp3 (which mi the last version always! worked fine) bereis the 4th or 5th time.
no output file. in the log it looks the same as if everything had worked, there is absolutely nothing apparent.
and as I said also the other 3 profiles, sometimes it works and it comes out a file (which is sometimes ok sometimes empty)
or it comes also none at all out.
the old version also tested again, which works without problems. the problems are exclusively in the 0.5.4
Translated with www.DeepL.com/Translator (free version)

nach dem 8. versuch im high profil kam endlich überhaupt eine datei raus ^^
diese war leer.
der 9. versuch gab dann wieder eine aus, diesmal war sie in ordnung...
absolut seltsam

Could you try this build: https://github.com/chidiwilliams/buzz/suites/9247184069/artifacts/432520528?

yess :) this build works perfect :)
tried all4 profiles, every single one worked first try great :)
is it wanted that the generated file opens itself after generating? (but also does not bother ^^)
may i ask what the problem was? was really a strange behavior ^^

ach, und wo ich grad dabei bin noch eine frage.
ich denke du nutzt pyinstaller (onedir) um eine exe zu genereieren oder ?!?
aber was mich interessieren würde, womit erstellst du aus dem (one)dir den installer in form einer einzelnen exe. gibts dafür ein spezielles programm? :)

Great. Glad to hear it works fine.
Yes, I thought it might be a good idea to open the file after generation so it's easy to find and use immediately. But I'm happy to take feedback/add an option to disable if it's not useful
The problem was on this line. Basically, I had some code that cleaned up the transcription process and I was calling it after the transcription ends but before the file gets written. So sometimes, the file will get written before the clean up finishes, and other times the clean up will finish first and stop the file from getting written. I moved the clean up code to run after the file gets written.
I use InnoSetup to create the .EXE from the PyInstaller files. You can find the config here and here.

ah, ok, that explains it ^^ but good that the fix for it was an easy one ^^


Run parseDiagnostics on failed CargoTasks

This pull request makes the promise returned form CargoTask.execute resolve into the output of the cargo task and CommandService.runCargo to run that output through parseDiagnostics.
This makes errors from failed cargo builds show up as diagnostics.
Fix for #50

Thank you for contribution :)


Add documentation

This PR will document all relevant functions and types, and provide a proper README.

I think most parts of the code should be documented now (up to less relevant, internal functions). What is left to be done is add a proper README and maybe document the examples with some explanations.

Do you want to wait with the README or go ahead and do it right away? I am very much okay with already adding these docstrings, it's not that much work to change them afterwards if need be.
I also still want to make some minor changes and clean up some of the files/folders, so it's better to first merge this such that we don't get merge conflicts, as writing docstrings touches large parts of the codebase.
Will you mark it as non-draft whenever you feel like its ready? I'll try and review asap then

I think we can add the README also later. But I will add some comments to the examples tomorrow morning. Then this PR should be ready to merge! I hope this will avoid most merge conflicts.

This should be ready to review now. I haven't yet added any comments for the test scripts in PEPSKit.jl/examples/ since they will be converted to proper tests anyway at some point.


Recommend a @Verbose flag to minimize RAISERROR messages.

We have a nightly job that uses the DatabaseBackup procedure to back up numerous databases. If the job fails, we look to the Job History. But these backup jobs are full of status messages from RAISERROR - so many that the text is truncated and we get no indication of what the actual error was! (See the attached jpg)
Recommend a @Verbose bit flag to let the user turn these off once the procedure is productionized, so that only actual errors are included in the Job History log. If @Verbose = 0, only actual errors are displayed.
In the procedure, the code would be IF @Verbose = 1 RAISERROR...('%s',10,1,@StartMessage) WITH NOWAIT
Thanks!

I am aware of the issue with the Job History. The reason for that is that there is a limitation for how many characters that can be stored in the message column in msdb.dbo.sysjobhistory.
https://docs.microsoft.com/en-us/sql/relational-databases/system-tables/dbo-sysjobhistory-transact-sql?view=sql-server-ver15
I recommend that you use SQL Server Agent output - files to get the complete output.
The downside with a less verbose mode, is that it will be very difficult to troubleshoot it, when there is an error.

I'll research how to use SQL Server agent to output this to a file, thanks. But if @Verbose was an option you could turn it on when you did have to troubleshoot.
Thanks for all you do.

Try executing MaintenanceSolution.sql on a server and then have a look at the jobs (Job Properties / Steps / Edit / Advanced).

Very kind, thanks.
On Sat, Oct 24, 2020 at 11:53 AM Ola Hallengren<EMAIL_ADDRESS>wrote:

Try executing MaintenanceSolution.sql on a server and then have a look at
the jobs (Job Properties / Steps / Edit / Advanced).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/olahallengren/sql-server-maintenance-solution/issues/429#issuecomment-716039034,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFJSAHMUW3HVWN4AUSKBVD3SMMPEHANCNFSM4S3VEZIQ
.


[SUPPORT]What's the reading behavior for MOR table?

Hi,
I have a MOR table that contains both base parquet files and log avro files.
There are two end users that do the snapshot query on this table, I would ask what's the reading behavior for MOR table.
I would guess there are two options as follows ,not sure which one is correct, or both are incorrect.

Each end user does their own merge during their query period. And the merge will be done  with a separate compaction process. That means，after the users finish query，the base files and log files are still not merged。

When the first user starts to query the data, it does the merge on the fly. When the second user query comes， it has to  wait util the on-going merge is done

Could you please help answer? Thanks!

Could someone help answer this question?

According my understand.First is right.
https://hudi.apache.org/docs/table_type
s#merge-on-read-table.
each snapshot query(merge base / columnar file + row based delta / log files)
https://hudi.apache.org/docs/compaction/
compaction will merge basefile and delta log file

your 1st answer is pretty much correct. If there are multiple users querying concurrently, each will do the merge by themselves in memory and will get to read the merged final snapshot of all records.

your 1st answer is pretty much correct. If there are multiple users querying concurrently, each will do the merge by themselves in memory and will get to read the merged final snapshot of all records.

Thanks for the helpful answer!
That means, merge can only be done with compaction process? sync or async? Thanks

yes, you are right.

yes, you are right.

Thanks @nsivabalan  for the confirmation!


derive macro error for wrong style of attribute syntax is misleading

#[derive(Debug, Serialize, Deserialize)]
pub struct Config {
    download: PathBuf,
    #[serde(skip_serializing_if(Option::is_none))]
    storage: Option<PathBuf>,
    upload: bool,
}

The above code will cause the following compiler error:
error: unknown serde field attribute `skip_serializing_if`
  --> src/main.rs:10:13
   |
10 |     #[serde(skip_serializing_if(Option::is_none))]
   |             ^^^^^^^^^^^^^^^^^^^

however, there is a field attribute skip_serializing_if.
It would be more helpful to recognize the wrong syntax and suggest the correct syntax instead:
error: expected key = value syntax, e.g. `skip_serializing_if = "..."`
  --> src/main.rs:10:13
   |
10 |     #[serde(skip_serializing_if(Option::is_none))]
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I expect this will be painstaking due to the number of possible serde attributes, but the result is possible in theory.
I'd like to take a stab at implementing it if you're happy with the stated goal. I've done similar for much simpler and smaller) proc macros of my own in the past.
If not, no worries. It might make serde slightly slower to compile anyway for what is only a minor papercut for beginners (or muppets such as myself) :)

As of syn 2 (serde_derive 1.0.157+), the error is better.
error: expected `=`
 --> src/main.rs:6:32
  |
6 |     #[serde(skip_serializing_if(Option::is_none))]
  |                                ^


MauveMultiThreadLoadTest failing on openjdk9 j9 Linux x86-64 build

MauveMultiThreadLoadTest is failing on openjdk9 j9 Linux x86-64 build with following error:

First failure detected by thread: load-1. Not creating dumps as not running on an IBM JVM

Build: https://ci.adoptopenjdk.net/view/System tests/job/openjdk9_j9_systemtest_x86-64_linux/

More failure: https://ci.adoptopenjdk.net/view/System tests/job/openjdk9_hs_systemtest_aarch64_linux/lastSuccessfulBuild/artifact/openjdk-tests/TestConfig/test_output_15196514317511/TestTargetResult.tap/view/

Closing this issue as we are no longer supporting Java 9 builds. Will open separate issue if this shows up in Java 8 or Java 11.


Updating trackers dynamically has been broken

Expected Behavior
The user should be able to update the list of images they are looking for dynamically.

Current Behavior
With the recent commits this functionality has been broken, the list of images is not updated as expected.

Possible Solution
Re-implement the code modified by #84 and @Stending - should review our merging criteria too - this code should not have been merged.

Steps to Reproduce (for bugs)

Open the example repo, update the plugin to the current master branch and see that the functionality is broken.
Context

This is a breaking change where there should not be one

Your Environment

Cordova version used: 6.3
Plugin version used: 3.0.2
Plaforms affected: iOS

Correction - this was caused by #81 and @dsgriffin
I will reinstate the removed method and open a PR


Getting Error -> W18: Invalid character in group name

I'm using monokai.nvim for a long time and enjoying it. I haven't changed my setup (as far as I know), but now I get this error-message
Error detected while processing nvim_exec() called at /home/metamorph/.local/share/nvim/site/pack/packer/start/monokai.nvim/colors/monokai.vim:1:
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
W18: Invalid character in group name
-- More --
...

After hitting a Enter a view times, neovim is using monokai normally. Maybe it's just me, but if someone got the problem too and got a solution, I'd be glad to know ;-)
PS.:
 >> nvim --version
NVIM v0.8.0-dev
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

 >> lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.1 LTS
Release:        22.04
Codename:       jammy

I got the same problem with (at least an)other colorscheme(s)* too. Maybe it's some weird change in the neovim-dev-branch.

same error: ellisonleao/gruvbox.nvim / no error: kartikp10/noctis.nvim

Solution: Had to update to the latest version, seems to be an (ubuntu)-ppa-problem:
Switched from:
(the stable Version [NVIM v0.8.0-dev] seems out of date [2022-03-24] and something is breaking the newest versions of plugins)
[Neovim Stable : “Neovim PPA” team](https://launchpad.net/~neovim-ppa/+archive/ubuntu/stable)

to neovim-nightly
[Neovim Unstable : “Neovim PPA” team](https://launchpad.net/~neovim-ppa/+archive/ubuntu/unstable)

and everything works fine and as expected.

This seems to also happen on Debian Bookworm, where the latest available neovim version is 0.7.2.
Is there possibly a workaround for this - other than installing neovim from the source?


No error reports

Type: Performance Issue
I don't understand why I have  revision marks (red) on many variable types defined in other files (but included in the project).
When I press F12 on a marked variable, it opens the definition and then removes the red revision mark. Is it am imtellisense problem?
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: Yes

System Info
|Item|Value|
### Tasks
- [ ] Add a draft title or issue reference here
### **```**

|---|---|
|CPUs|11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 x 2304)|
|GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled|
|Load (avg)|undefined|
|Memory (System)|31.67GB (20.84GB free)|
|Process Argv|--crash-reporter-id ce8b4ffc-a0a2-48cb-8b13-90f7fac5d4f4|
|Screen Reader|no|
|VM|0%|

Process Info

CPU %	Mem MB	   PID	Process
0	    97	 31440	code main
0	   296	  2464	window [1] (modules.c - HighBay - Visual Studio Code)
0	    43	 13260	   utility-network-service
0	    77	 19216	fileWatcher [1]
0	   108	 19668	   gpu-process
0	    28	 20352	   crashpad-handler
0	   106	 30168	shared-process
0	    75	 32908	     ptyHost
0	   150	 31196	extensionHost [1]
0	   200	  9264	     c:\Users\andrea.capoccia.vscode\extensions\ms-vscode.cpptools-1.15.4-win32-x64\bin\cpptools.exe
0	     5	 20424	       "c:\Users\andrea.capoccia.vscode\extensions\ms-vscode.cpptools-1.15.4-win32-x64\bin\cpptools.exe"
0	    42	 30484	         c:\Users\andrea.capoccia.vscode\extensions\ms-vscode.cpptools-1.15.4-win32-x64/bin/cpptools-srv.exe 9264 {CB21F230-B86D-4698-96BD-764DA0DF48C5}
0	    11	 28256	           console-window-host (Windows internal process)
0	    40	 31892	         c:\Users\andrea.capoccia.vscode\extensions\ms-vscode.cpptools-1.15.4-win32-x64/bin/cpptools-srv.exe 9264 {91EA6E25-EFD8-40BD-AA17-A68A7DA057A5}
0	    11	 32652	           console-window-host (Windows internal process)
0	    11	 30152	       console-window-host (Windows internal process)
0	   108	 30548	     electron-nodejs ("C:\Users\andrea.capoccia\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Users\andrea.capoccia\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=31196)
0	    90	 31476	window [2] (Segnalazione problemi)

Workspace Info

|  Window (modules.c - HighBay - Visual Studio Code)
|    Folder (HighBay): 4940 files
|      File types: d(1178) o(1178) crf(958) _2i(369) lst(334) txt(329) h(184)
|                  c(136) htm(21) py(15)
|      Conf files:;

Extensions (14)

Extension|Author (truncated)|Version
---|---|---
bracket-pair-toggler|dzh|0.0.3
todo-tree|Gru|0.0.226
vscode-language-pack-it|MS-|1.78.2023051009
python|ms-|2023.8.0
vscode-pylance|ms-|2023.5.40
jupyter|ms-|2023.4.1011241018
![2](https://github.com/microsoft/vscode/assets/75210557/6f19a716-8821-4e44-b1f0-3c85820a1800)
![3](https://github.com/microsoft/vscode/assets/75210557/e950e053-fd04-47d6-baca-cf49aba822cf)
![1](https://github.com/microsoft/vscode/assets/75210557/cd8f23a9-8fb2-4009-a890-ea2ca6272963)

jupyter-keymap|ms-|1.1.0
jupyter-renderers|ms-|1.0.15
vscode-jupyter-cell-tags|ms-|0.1.8
vscode-jupyter-slideshow|ms-|0.1.5
cmake-tools|ms-|1.14.31
cpptools|ms-|1.15.4
cpptools-extension-pack|ms-|1.3.0
cmake|twx|0.0.17

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30610679
282f8724:30602487
pyind779:30671433
f6dab269:30613381
vscrpc:30673769
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
pythonfmttext:30731395
pythoncmv:30739700
fixshowwlkth:30730052
showsbindicator:30730056
pythongtdpathcf:30739705

![2](https://github.com/microsoft/vscode/assets/75210557/deb0bbe2-dc80-46c3-ab52-767019d060a7)
![3](https://github.com/microsoft/vscode/assets/75210557/2770f34d-81b6-4a57-b318-4a761cf13a48)
![1](https://github.com/microsoft/vscode/assets/75210557/e0b4d05a-140a-4b70-a418-0075591ce6c2)

What language is this for? Please share steps to reproduce the issue

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Language is for C.
I start opening VScode rigt clicking on the project folder, open with VSCode.
The project has some folders.

Every folder has 2 subfolders named "src" and "inc".  "Src" subfolders contain the .c files and "inc" subfolders contain .h files.
For example the "lib" folders has:

"src" subfolder with "modules.c" file
"inc" subfolder with "modules.h" file

When I open modules.c in VSCode I find the types and other things highlighted in red.

Now I press F12 (go to definition) and automatically VSCode open the "modules.h" files with the definitions of types.
Then I go back to the "modules.c" and the variables are not highlighted:

I'm using C/C++ extension, in the includePath there is:  _"${workspaceFolder}/",_**, so every files on the project should be included.
This is my c_cpp_properties.json files:
{
"configurations": [
{
"name": "Win32",
"includePath": [
"${workspaceFolder}/**",
"C:\Keil_v5\ARM\ARMCC\include\",
"C:\Keil_v5\ARM\Pack\ARM\CMSIS\4.5.0\CMSIS\Include",
"C:\Keil_v5\ARM\Pack\Keil\SAMR21_DFP\1.1.0\Device\SAMR21\Include"
],
"defines": [
"rand=_rand",
"HOST_ADAPTER",
"WLCON_WIFI",
"WATCHDOG",
"CONSOLE_UART=1",
"CONSOLE_SPEED=115200",
"PROFILE_MODULES ",
"PHY_AT86RF233"
],
"cStandard": "c99",
"intelliSenseMode": "windows-gcc-arm",
"compilerPath": "C:\ST\STM32CubeIDE_1.12.0\STM32CubeIDE\plugins\com.st.stm32cube.ide.mcu.externaltools.gnu-tools-for-stm32.10.3-2021.10.win32_<IP_ADDRESS>301161003\tools\bin\arm-none-eabi-gcc.exe",
"mergeConfigurations": false,
"forcedInclude": [
"C:\Keil_v5\ARM\Pack\Keil\SAMR21_DFP\1.1.0\Device\SAMR21\Include\samr21g18a.h"
]
}
],
"version": 4
}

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Using xchammer after make install fails with the error 'Fatal error: Missing XCHammerAssets: file Sources/XCHammer/Generator.swift'

Hello:
Using xchammer from /usr/local/bin after make install does not work. It fails with the following error:
'Fatal error: Missing XCHammerAssets: file Sources/XCHammer/Generator.swift, line 776'

I am running macOS Mojave 10.14.6 (18G103), and I have tried this with Xcode 10.3 and 11. I have tried commit f5fe4657eb751ababfa4ad5986afaa691910080f from xchammer (last one at master at the time of writing).
You can reproduce the issue by running the following script:
set -eou pipefail

# Clone XCHammer repository
tmp_dir=$(mktemp -d -t xchammer-XXXXXXXXXX)
git clone "https://github.com/pinterest/xchammer" "$tmp_dir"
cd "$tmp_dir"
git checkout f5fe4657eb751ababfa4ad5986afaa691910080f

# Clean previous installation if needed
rm -rf /usr/local/bin/xchammer
rm -rf /usr/local/bin/xchammer.app

# Install XCHammer
make install

# Patch the makefile, so instead of using the binary from the actual directory, use it from /usr/local/bin
sed -i '' 's/$(ROOT_DIR)\/$(PRODUCT)\/Contents\/MacOS\/XCHammer/xchammer/g' "Makefile"

# Run
make run # This fails with the error 'Fatal error: Missing XCHammerAssets: file Sources/XCHammer/Generator.swift, line 776'

If this is not working, how are you usually using xchammer in Pinterest?
Thanks!

I'm seeing the same error.

I've tried last year 0.2 release and it did work...
For some reason it seams that XCHammer is an old unsupported internal pinterest project.

@rahul-malik your feedback would be very much appreciated :)
PD: Also, did you manage to publish the part 2 of https://medium.com/pinterest-engineering/developing-fast-reliable-ios-builds-at-pinterest-part-one-cb1810407b92? I would like to know more about how you are using Bazel in Pinterest ;)

@yuriy-yarosh - XCHammer is currently used by all developers at Pinterest. The docs should be updated ideally to how we've set it up internally
@acecilia - Can you try the bazel instructions in https://github.com/pinterest/xchammer/blob/master/Docs/XCHammerFAQ.md ?

@acecilia @yuriy-yarosh - I just tagged a new release for you to try. Please let me know if this works for you https://github.com/pinterest/xchammer/releases/tag/0.3

@rahul-malik thanks for your answer :) I had a look at the FAQ, but I can not make it work (I do not see any installation or setup instructions in the FAQ).
I run the script I attacked in the first comment of the issue, and I am still getting the same error: Fatal error: Missing XCHammerAssets: file Sources/XCHammer/Generator.swift, line 788:
set -eou pipefail

# Clone XCHammer repository
tmp_dir=$(mktemp -d -t xchammer-XXXXXXXXXX)
git clone "https://github.com/pinterest/xchammer" "$tmp_dir"
cd "$tmp_dir"
git checkout tags/0.3

# Clean previous installation if needed
rm -rf /usr/local/bin/xchammer
rm -rf /usr/local/bin/xchammer.app

# Install XCHammer
make install

# Patch the makefile, so instead of using the binary from the actual directory, use it from /usr/local/bin
sed -i '' 's/$(ROOT_DIR)\/$(PRODUCT)\/Contents\/MacOS\/XCHammer/xchammer/g' "Makefile"

# Run
make run # This fails with the error 'Fatal error: Missing XCHammerAssets: file Sources/XCHammer/Generator.swift, line 776'

I can not find information about how to install xchammer, only the indication on the readme about using make install, which is not working for me.

@rahul-malik thanks.

So I figured out the issue and a work around.
xchammer generate xchammer.yml fails
because it gets installed a symlink to /usr/local/bin
Which then looks for resources in /usr/local/bin
Workaround is
to call it directly
e.g.
/usr/local/bin/xchammer.app/Contents/MacOS/xchammer generate xchammer.yml

@mpalczew Yayyy that made it, thanks for the trick! Finally the following script works:
set -eou pipefail

# Clone XCHammer repository
tmp_dir=$(mktemp -d -t xchammer-XXXXXXXXXX)
git clone "https://github.com/pinterest/xchammer" "$tmp_dir"
cd "$tmp_dir"
git checkout tags/0.3

# Clean previous installation if needed
rm -rf /usr/local/bin/xchammer
rm -rf /usr/local/bin/xchammer.app

# Install XCHammer
make install

# Patch the makefile, so instead of using the binary from the actual directory, use it from /usr/local/bin
sed -i '' 's/$(ROOT_DIR)\/$(PRODUCT)\/Contents\/MacOS\/XCHammer/\/usr\/local\/bin\/xchammer.app\/Contents\/MacOS\/xchammer/g' "Makefile"

# Run
make run

I don't have permission to push a new branch, otherwise I would have a PR.
Here's a patch.
diff --git a/Makefile b/Makefile
index bf78e98..de15594 100644
--- a/Makefile
+++ b/Makefile
@@ -30,7 +30,8 @@ archive: build-release
 install: archive
        mkdir -p $(PREFIX)/bin
        ditto $(PRODUCT) $(PREFIX)/bin/$(PRODUCT)
-       ln -s $(PREFIX)/bin/$(PRODUCT)/Contents/MacOS/xchammer $(PREFIX)/bin/xchammer
+       echo '#!/bin/sh\n$(PREFIX)/bin/$(PRODUCT)/Contents/MacOS/xchammer $$@\n' > $(PREFIX)/bin/xchammer
+       chmod +x /usr/local/bin/xchammer

 uninstall:
        unlink $(PREFIX)/bin/xchammer

As for #267 the problem is still there when generation is done with xcode_project rule. Does someone have a pointer to understand what is going on here?


Execution timeout on flights.php.

Check that too much data is not being pulled from the database when flights.php is being accessed causing a PHP timeout.

commit 7ca251f65938b6383e67e76d6ba8bb7e2d5c52e4


fix: passes correct data to buildStateFromSchema on account page

Description
Fixes https://github.com/payloadcms/payload/issues/3980
When a user saved their profile from the account page, the form fields would clear out.

[x] I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[x] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

Do the change to the Live Preview tests need to be included in this PR?

@jacobsfletch no, but I am about to merge to main. I struggled too hard trying to get e2e to work to remove them now.
The only change is moving where a var is imported from so tests would run locally.


hoow to run facebook data mining ??

In the newer version of Facebook API, all methods to extract public data is deprecated and it is available to limited users mainly for organizations.


Upmerge 0.4.6 into zephyr

@pdgendt is there a counterpart PR in the main tree?

@pdgendt is there a counterpart PR in the main tree?

scratch that, saw it.


Add neuron bounding box function.

Implemented in neurom.core.neuron.
Imported into neurom.ezy.

@mgeplf Please have a look if you have a moment. I'm sure this can be simplified.


Add breakeven options + take profit, multi take profit + stoploss options

Sorry, but I don't have inmediate plans for adding these ones.

Hmm that’s to bad was looking forward. Think I’m gonna invest some learning ccxt


For Gigaset Keeper/Gtag gigaset.count gives wrong values

Okay first of thanks for the great adapter and sorry for the long description!
I just got a Gigaset Keeper and set it up for Radar, the value of count makes weird changes and gives wrong values sometimes.
Example: (for this one I have scan frequency set to 30 sec and after 8 times it declares device absent)

If Keeper is around then I have gigaset.here and gigaset.btHere as true which is correct and the count resets to 0 at the beginning. Now when the device is not there anymore, the btHere is false and technically at count= -9 it should change gigaset.here to false as well. This works sometimes but sometimes the numbers just jump from -1 to -4 within the 30 seconds, or -7 to -11 and the gigaset.here stays as true.

Some other times when the device goes absent the count number stays stuck at a certain value i.e "-3" and does not change even if device is there again and btHere and gigaset.here are true. (this causes issues for scripts to check for presence)

And occasionally it works as intended.

What makes me wonder is my iPhone was the first one to be connected with radar and I haven't had this issue with it. It only happens to objects under the Gigaset device.
I tried reinstalling the Adapter, re-configuring it, deleting the object and restarting it multiple times, unfortunately that did not solve the problem and the bigger issue is that its not consistent, at anytime any of the above 3 cases could happen.
Any clue?
Thanks in advance!

Sorry for late reply after Easter-Holidays!
Ok, that's strange!
The adapter sends a scan via Noble BT-module and this module normally lists the devices found.
If it goes up within one scan more than once it could be only if Noble lists the same device multiple times, but if it goes down multiple times then it's strange because it cannot 'be not here' multiple times!
I hope you are not running BLE-Adapter at the same time because it also uses Noble and interferes with Radar. This is the only problem I know at the moment.
The only other idea I have is that Noble did not finish the scan in the 30 seconds and is re-scanning before finishing.
Can you log the value with history and look when and how it happens and see the history?

No worries! Happy Easter btw!
I thought I attached a screenshot of the logs but seems that I forgot, here is the log when posting this issue. I did not have BLE before but after I had this issue I installed it to try it, the issue continued but now BLE is removed, I will monitor the log and send another one later on.

**Just in case BLE will interfere now, is there a way to make sure its completely removed other than removing the instance/deleting the adapter?

Ok, good to see. Actually G-Tags are BT-LE and only Noble can find them. Other BT devices can answer also to l2ping command but I see in your log that l2ping generates a lot of errors, even some like 'operation already in progress'...  The host is down can happen if the device is out of reach, others should not happen.
Can you check with 'sudo l2ping -c1 BTMACADDRESS' on commandline if it works for your devices which are near?
CHeck also how long it takes if a device is not here. If you have too many devices to test which take a too long time then we may get in  conflict with the 30 seconds. L2ping takes up to 7 seconds for me if a device is not ready and completes in 2-3 seconds if a device is here and answers (like my mobile at the moment)..
How many devices do you test and can it be that they need more than the 30 seconds?

Correction: I used radar for my iPhone without having BLE on, when I got the Gigaset Keeper I used BLE to get the MAC address of my device (stupid, i know since I could have simply checked unknown BT object in Radar). Anyhow and the log I posted above is when BLE was still installed, so as you said maybe BLE interfered and it was scanning during other scans.
I will test it through out the day tomorrow and see if the problem persists, for now I will also keep scans at 30 sec intervals.

Okay i posted before reading your reply.
l2ping actually caused me a huge network issue when my Raspberry Pi 3 was working on WiFi, while its on WiFi every time the l2ping command is sent (also manually) it jams my whole network, anything streaming on the internet or on local network (apple tv, chromecast ...etc) will start lagging for few seconds and then it stops. This happens every time I run sudo l2ping with BTMAC.
After days of trying to solve it, it turns out that the issue only happens when the Pi is on Wifi and I couldn't find a reason for it anywhere. For now my Pi is connected over ethernet and the problem does not occur.
For now i only have 2 devices on Radar, later on there will be 4. in total.
When entering sudo l2ping directly it does not take that long to give back a result, so I doubt that it needs more than 30 seconds.
As you said and as I wrote in the other reply maybe BLE is indeed causing the problem, does BLE use l2ping as well?
If not then I am not sure why it generates a lot of errors. Any other Ideas regarding that?
Sorry for bothering you with long text!!!
Thanks in advance!

l2ping should not generate anything on the network (W-LAN), it pings only on Bluetooth and tries to find a certain bluetooth-MAC!
Anyhow, when new Raspi 3+ was announced I have seen a test comparison of his W-Lan and the old Raspi-3 one: The old Raspi could handle only the first 3-4 channels of W-Lan very well, so if your router used a higher one it was generating a lot of error-retry traffic. Now I know as well why I had problems also!

Exactly I found it weird that something that just pings BT is affecting my network, but literally every time I type in Putty l2ping -c1 "BTMAC" and press enter, network jams, and 100% reproducible.
Anyhow I am checking the logs further now, I have restarted my Pi and set Radar to 60 seconds.
The "operation already in progress" keeps popping out.

radar.0
2018-04-09 22:59:45.465
debug
Noble found  Gigaset

radar.0
2018-04-09 22:59:14.461
debug
l2ping for ***_iPhone err: "Error: Command failed: l2ping -c1 6X:XX:XX:XX:XX Can't connect: Operation already in progress "

radar.0
2018-04-09 22:59:14.321
debug
Error: Command failed: l2ping -c1 6X:XX:XX:XX:XX Can't connect: Operation already in progress

On the other side the Gigaset is counting normally with no issues so far. (usually one of the issues happen within few minutes)
I will keep monitoring it and keep you posted! As for the errors I have no clue :/

Okay update about Gigaset, so today in the morning the count was at 114 and then i refreshed the page and suddenly it switches the .here to false and the count is suddenly -18. For my iPhone it was also -18 which didnt make sense since BT on my phone was off since yesterday evening and the count was at about -870 or so.
I don't know what causes this sudden change but its causing my presence scripts to react to false information.

Ramizh,
did you set your iPhone IP also to watch? if yes, it will flag it .here if either the BT or the PI is visible.
I really have a problem generating the error message you have: '...  Operation already in progress '.
I never get this, and it's from l2ping internally.  Do you get it only with iPhone?
p.s.: On my list for new Radar2-Adapter is to support also IPV6 which many services start to use now.

Hello,
Any new ideas by any chance?

I cannot reproduce the problem in my environment at the moment, the only difference for me is that I use BT 4.0 USB sticks instead of the built in Raspi BT because I use and test on different older Raspi's and also OrangepPi's .

Hello Frankjoke,
I know you havent been able to reproduce the problem, but I got another set if Gigaset Keepers and I tried out with them, same issue for the count number happens. Now the the device is found it switches to true but the count stays at the negative number of the previous state.
Has anyone else reported such a problem?

Please switch to radar2 adapter. I will not make changes to older radar anymore.


Use unix line endings instead of dos.

Contributions: We are not currently taking public contributions - see our contributions policy. However, we are accepting issues and we do want your feedback.

Description
Unix line endings should be used instead of dos so that there are no warnings on mac.
Tests
Run codegen, no dos line endings in codegened files were found.
Documentation
N/A
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Test this also on a Windows machine. Just ran it and now I'm getting the warnings on windows ;)

@jessicafalk The code is now using System.Environment.NewLine, please have a look. I think it throws warnings if you codegen with an open editor but when you reopen it OK and you can now codegen without closing.

@martinzlocha You'll want to check in any generated code that changed too

@jamiebrynes7 Thats not needed in this case because this change doesn't affect the generated code which we have checked in.

Oh my, somewhere some generated code that should be checked in.. hasn't been :/

do we want to add that generated code back in in this PR or a separate one?

I was just looking at the generated code and I realized that if we use System.Environment.NewLine we have those two lines end with CRLF but all others are only LF. Also the issue with using System.Environment.NewLine in committed code is that every time someone commits on different OS it will ask him to commit the code generated files. Even though its not the nicest of solutions I think we should be using "\n" everywhere.
@jessicafalk I will add the codegened files here.

Tested on mac and everything seems to work fine.

@jessicafalk @martinzlocha normally I'd argue the generated code should be added back in with a separate PR as this is a codegen change so it would make this review easier. However given this is the one place where the exhaustive generated code will act differently from the other generated code (checking it in changes the line endings) I think it's fine to do it as a driveby.

@zeroZshadow Yes I should change the name of the PR. I realized that changing all line endings to unix is not practical and this is a better solution. I will change the pr name.

However because it is now platform specific, the tests will constantly show up as changed as some of us work on unix systems and the others on windows.

@zeroZshadow Just tested this on Mac and after codegening there have been no changes picked up by git so I think it should be fine. If something arises though we can have a look again and convert everything to just /n


Add switches to control how child items get selected in Install-DBO*

From slack.
Add -Include, -Exclude and possibly -NoRecurse to control how child items in folders get added.

Resolved in #67


How to integrate with logstash-logback-encoder in json format

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
We use logstash-logback-encoder in custom json format, but failed to print TID in log file.

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking: 6.5.0
OS: linux or windows
JRE: JDK8
logback-core: 1.1.11

Which company or project?
test

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Add dependency in maven pom.xml

<dependency>
          <groupId>net.logstash.logback</groupId>
          <artifactId>logstash-logback-encoder</artifactId>
          <version>5.1</version>
      </dependency>
  <dependency>
          <groupId>org.apache.skywalking</groupId>
          <artifactId>apm-toolkit-logback-1.x</artifactId>
          <version>6.5.0</version>
      </dependency>

config logback xml

<encoder class="net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder">
            <providers>
                <mdc/>
                <timestamp>
                    <timeZone>UTC</timeZone>
                </timestamp>
                <provider class="org.apache.skywalking.apm.toolkit.log.logback.v1.x.logstash.TraceIdJsonProvider"/>
                <pattern>
                    <pattern>
                        {
                        "level": "%level",
                        "ip": "${IP}",
                        "service": "${APP_NAME:-}",
                        "trace": "%X{X-B3-TraceId:-}",
                        "TID": "%X{TID}",
                        "tid": "%X{tid}",
                        "span": "%X{X-B3-SpanId:-}",
                        "exportable": "%X{X-Span-Export:-}",
                        "pid": "${PID:-}",
                        "thread": "%thread",
                        "class": "%logger{1.}:%L",
                        "message": "%message",
                        "stackTrace": "%exception{10}"
                        }
                    </pattern>
                </pattern>
            </providers>
        </encoder>

No TID in log file.
log example:

{"@timestamp":"2019-12-06T07:52:10.162+00:00","level":"INFO","ip":"<IP_ADDRESS>","service":"dlsgateway","trace":"","TID":"","tid":"","span":"","exportable":"","pid":"17352","thread":"http-nio-8989-exec-1","class":"com.netflix.loadbalancer.DynamicServerListLoadBalancer:222","message":"Using serverListUpdater PollingServerListUpdater","stackTrace":""}

With above configuration, faield to print TID, but with below configuration, it works:
 <encoder class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">
            <layout class="org.apache.skywalking.apm.toolkit.log.logback.v1.x.TraceIdPatternLogbackLayout">
                <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level logger_name:%logger{36} - [%tid] - message:%msg%n</pattern>
            </layout>
        </encoder>

Please help how to handle it.  Appreciate your help.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x]  Question or discussion
[ ]  Bug
[ ]  Requirement
[ ]  Feature or performance improvement

Question

What do you want to know?
We use logstash-logback-encoder in custom json format, but failed to print TID in log file.

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking: 6.5.0
OS: linux or windows
JRE: JDK8
logback-core: 1.1.11
Which company or project?
test
What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Add dependency in maven pom.xml

<dependency>
          <groupId>net.logstash.logback</groupId>
          <artifactId>logstash-logback-encoder</artifactId>
          <version>5.1</version>
      </dependency>
  <dependency>
          <groupId>org.apache.skywalking</groupId>
          <artifactId>apm-toolkit-logback-1.x</artifactId>
          <version>6.5.0</version>
      </dependency>

config logback xml

<encoder class="net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder">
            <providers>
                <mdc/>
                <timestamp>
                    <timeZone>UTC</timeZone>
                </timestamp>
                <provider class="org.apache.skywalking.apm.toolkit.log.logback.v1.x.logstash.TraceIdJsonProvider"/>
                <pattern>
                    <pattern>
                        {
                        "level": "%level",
                        "ip": "${IP}",
                        "service": "${APP_NAME:-}",
                        "trace": "%X{X-B3-TraceId:-}",
                        "TID": "%X{TID}",
                        "tid": "%X{tid}",
                        "span": "%X{X-B3-SpanId:-}",
                        "exportable": "%X{X-Span-Export:-}",
                        "pid": "${PID:-}",
                        "thread": "%thread",
                        "class": "%logger{1.}:%L",
                        "message": "%message",
                        "stackTrace": "%exception{10}"
                        }
                    </pattern>
                </pattern>
            </providers>
        </encoder>

No TID in log file.
log example:

{"@timestamp":"2019-12-06T07:52:10.162+00:00","level":"INFO","ip":"<IP_ADDRESS>","service":"dlsgateway","trace":"","TID":"","tid":"","span":"","exportable":"","pid":"17352","thread":"http-nio-8989-exec-1","class":"com.netflix.loadbalancer.DynamicServerListLoadBalancer:222","message":"Using serverListUpdater PollingServerListUpdater","stackTrace":""}

With above configuration, faield to print TID, but with below configuration, it works:
 <encoder class="ch.qos.logback.core.encoder.LayoutWrappingEncoder">
            <layout class="org.apache.skywalking.apm.toolkit.log.logback.v1.x.TraceIdPatternLogbackLayout">
                <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level logger_name:%logger{36} - [%tid] - message:%msg%n</pattern>
            </layout>
        </encoder>

Please help how to handle it. Appreciate your help.
Requirement or improvement

Please describe about your requirements or improvement suggestions.

Get solution for this, just add the Converter in logback.xml:
<configuration>
<conversionRule conversionWord="tid" converterClass="org.apache.skywalking.apm.toolkit.log.logback.v1.x.LogbackPatternConverter"/>

<!--appender-->
<appender name="logstash" class="ch.qos.logback.core.rolling.RollingFileAppender">
        <file>${LOG_PATH:-.}/${APP_NAME}/${APP_NAME}_json.log</file>
        <rollingPolicy class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
            <fileNamePattern>${LOG_PATH:-.}/${APP_NAME}/${APP_NAME}_json.log.%d{yyyy-MM-dd}.gz</fileNamePattern>
            <maxHistory>30</maxHistory>
        </rollingPolicy>
        <encoder class="net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder">
            <providers>
                <timestamp>
                    <timeZone>UTC</timeZone>
                </timestamp>
                <pattern>
                    <pattern>
                        {
                        "level": "%level",
                        "ip": "${IP}",
                        "service": "${APP_NAME:-}",
                        "tid": "%tid",
                        "pid": "${PID:-}",
                        "thread": "%thread",
                        "class": "%logger{1.}:%L",
                        "message": "%message",
                        "stackTrace": "%exception{10}"
                        }
                    </pattern>
                </pattern>
            </providers>
        </encoder>
    </appender>

</configuration>

Thans anyway.

If this missed in the document, could you send a pull request to add this in the document?

If this missed in the document, could you send a pull request to add this in the document?

Sure, my pleasure.

If this missed in the document, could you send a pull request to add this in the document?

@wu-sheng  wired problem, it doesn't work anymore, now the tid in log printed as "TID:[Ignored Trace]", what can  I do with that? Look into the source code of Agent,
org.apache.skywalking.apm.agent.core.context.AbstractTracerContext, it chooseIgnoredTracerContext but not TracingContext, How to fixed it?

Ignored should only show up when agent can't connect to backend. Is this your case?

Ignored should only show up when agent can't connect to backend. Is this your case?

Bingo, agent disconnet from the backend for some unknown reason, I restart the backend, and it works again, thank you very much.
Where can I locate this info for document?  How about in FAQ？

Ignored should only show up when agent can't connect to backend. Is this your case?

@wu-sheng  Bingo, agent disconnet from the backend for some unknown reason, I restart the backend, and it works again, thank you very much.
Where can I locate this info for document? How about in FAQ

Take an across check with this doc, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-logback-1.x.md. If yours is still missing there, update this doc, please.

Take an across check with this doc, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-logback-1.x.md. If yours is still missing there, update this doc, please.

Good, I'll update that tomorrow.

Take an across check with this doc, https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-logback-1.x.md. If yours is still missing there, update this doc, please.

Good, I'll update that tomorrow.

[https://github.com/apache/skywalking/pull/4019](pull request for this)


Refactor options

See gatling/gatling-enterprise-plugin-commons#149 for teh corresponding changes in the enterprise-commons library


Plugin Flattener: not loading the correct Remix plugin

It's trying to load this
https://unpkg.com/@remixproject/plugin
Which is not used anymore I think?

I have created an issue for him
https://github.com/Destiner/remix-flattener/issues/1


The warning "The structure of inputs doesn't match the expected structure" when training a functional model

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
v2.13.1-0-gf841394b1b7 2.13.1 (Nightly: v1.12.1-119104-gf8fd6f53fa3 2.19.0-dev20241204)
Custom code
Yes
OS platform and distribution
Windows 11 23H2 22631.4460
Mobile device
Windows 11 23H2 22631.4460
Python version
3.10
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When the model is functional, not Sequential, the warning has occured:
Epoch 1/5
<path-to-python>\lib\site-packages\keras\src\models\functional.py:225: UserWarning: The structure of `inputs` doesn't match the expected structure: ['keras_tensor']. Received: the structure of inputs=*
  warnings.warn(

Yes, the warning message has interrupted on parenthesis. When I've run the same code in Nightly, the warning message is:
Epoch 1/5
<path-to-python>\lib\site-packages\keras\src\models\functional.py:237: UserWarning: The structure of `inputs` doesn't match the expected structure.
Expected: ['keras_tensor']
Received: inputs=Tensor(shape=(None, 10))
  warnings.warn(msg)

After the warning, the training continues normally, but because of this warning, I can't be sure that the model works as I expect.
I've traced the source and found that in Lib\site-packages\keras\src\tree\optree_impl.py on line 95 comparasion of expected and actual structure failed. Now I place the traced variables here:
>>> a
<tf.Tensor 'data:0' shape=(None, 10) dtype=float64>
>>> b
[<KerasTensor shape=(None, 10), dtype=float32, sparse=False, name=keras_tensor>]
>>> a_structure
PyTreeSpec(*, NoneIsLeaf)
>>> b_structure
PyTreeSpec([*], NoneIsLeaf)

The data passed to the fit function fully corresponds to the documentation. The warning appears independently of whether I use numpy array or PyDataset as dataset of fit function.
Standalone code to reproduce the issue
from keras.models import Model
from keras.layers import Dense, Input, Flatten, Concatenate
from keras import utils
import numpy as np
import tensorflow as tf

class SamplesSet(utils.PyDataset):

    def __init__(self, batch_size, **kwargs):
        super().__init__(**kwargs)
        self.batch_size = batch_size

    def __len__(self):
        return 1

    def __getitem__(self, idx):
        x1 = np.random.uniform(size=10*self.batch_size).reshape((self.batch_size, 10))
        y = np.arange(self.batch_size)
        return x1, y

train = SamplesSet(100)
x1_train = np.random.uniform(size=10*100).reshape((100, 10))
y_train = np.arange(100)

input1 = Input(shape=(10,))
l1 = Dense(1)(input1)
d2 = Dense(1, activation='sigmoid')(l1)
model = Model(inputs=[input1], outputs=[d2])
model.compile(loss='binary_crossentropy', optimizer='adam', metrics=['accuracy'])
print(model.summary())

history = model.fit(x1_train, y_train, epochs=5, verbose=1)
# In the all cases below warning occures too
# history = Model.fit(train, epochs=5, verbose=1)
# ret = model.predict(np.arange(10)[np.newaxis,:])
# ret = model.predict(tf.constant([[0,1,2,3,4,5,6,7,8,9]]))

Relevant log output
No response

The warning you’re encountering is caused by a mismatch between the structure of the inputs passed to the model and what TensorFlow expects. Specifically, TensorFlow is identifying inputs as a standard tf.Tensor, while the expected input structure is a KerasTensor. The issue seems to originate from the type or structure of data passed during the model's construction or training.
Below is the updated code that avoids the warning by ensuring that inputs are correctly structured:
from keras.models import Model
from keras.layers import Dense, Input
import numpy as np
Generate sample training data
x1_train = np.random.uniform(size=10 * 100).reshape((100, 10)).astype(np.float32)  # Ensure dtype matches Keras expectations
y_train = np.random.randint(2, size=(100,)).astype(np.float32)  # Binary targets for the loss function
Define the model architecture
input1 = Input(shape=(10,), name="keras_tensor")  # Explicitly name the input
l1 = Dense(1)(input1)
d2 = Dense(1, activation="sigmoid")(l1)
model = Model(inputs=input1, outputs=d2)
model.compile(loss="binary_crossentropy", optimizer="adam", metrics=["accuracy"])
print(model.summary())
Train the model
history = model.fit(x1_train, y_train, epochs=5, verbose=1)
output:
Model: "model"

Layer (type)                 Output Shape              Param #
keras_tensor (InputLayer)    [(None, 10)]              0
dense (Dense)                (None, 1)                11
dense_1 (Dense)              (None, 1)                2
Total params: 13
Trainable params: 13
Non-trainable params: 0

Epoch 1/5
4/4 [==============================] - 0s 2ms/step - loss: 0.6933 - accuracy: 0.5000
...
if you require SamplesSet for data loading, ensure its output tensors are converted to tf.float32 and comply with the Keras structure. For example:
x1 = tf.constant(x1, dtype=tf.float32)
y = tf.constant(y, dtype=tf.float32)

@yuvashrikarunakaran please pay attention this line:
model = Model(inputs=[input1], outputs=[d2])

in your code was turned into:
model = Model(inputs=input1, outputs=d2)

I use lists because this problem originally came from multi-input model, I've just made this model as simple as possible. If we came back to lists, the warning will occure again.

Accordind the documentation:

Note: Only dicts, lists, and tuples of input tensors are supported. Nested inputs are not supported (e.g. lists of list or dicts of dict).

But documentations doesn't explain which type in which case should be used. I found that when I use a tuple instead of list, the problem disappears:
from keras.models import Model, load_model
from keras.layers import Dense, Input, Flatten, Concatenate
import numpy as np

x1_train = np.arange(10*100).reshape((100, 10)).astype(np.float32)
x2_train = np.arange(5*100).reshape((100, 5)).astype(np.float32)
y_train = np.arange(100).astype(np.float32)

input1 = Input(shape=(10,), name='keras_tensor')
l1 = Dense(1)(input1)

input2 = Input(shape=(5,))
l2 = Dense(1)(input2)

conc = Concatenate(axis=1)([l1, l2])
fl = Flatten()(conc)
d2 = Dense(1, activation='sigmoid')(fl)
model = Model(inputs=(input1, input2), outputs=(d2,))

model.compile(loss='binary_crossentropy', optimizer='adam', metrics=['accuracy'])
print(model.summary())

history = model.fit([x1_train, x2_train], y_train, epochs=5, verbose=1)

But when I saved the model and loaded it back, the problem occures again:
from keras.models import Model, load_model
from keras.layers import Dense, Input, Flatten, Concatenate
import numpy as np

x1_train = np.arange(10*100).reshape((100, 10)).astype(np.float32)
x2_train = np.arange(5*100).reshape((100, 5)).astype(np.float32)
y_train = np.arange(100).astype(np.float32)

input1 = Input(shape=(10,), name='keras_tensor')
l1 = Dense(1)(input1)

input2 = Input(shape=(5,))
l2 = Dense(1)(input2)

conc = Concatenate(axis=1)([l1, l2])
fl = Flatten()(conc)
d2 = Dense(1, activation='sigmoid')(fl)
model = Model(inputs=(input1, input2), outputs=(d2,))

model.save('model.keras')
model = load_model('model.keras')

model.compile(loss='binary_crossentropy', optimizer='adam', metrics=['accuracy'])
print(model.summary())

history = model.fit([x1_train, x2_train], y_train, epochs=5, verbose=1)

@yuvashrikarunakaran please pay attention this line:
model = Model(inputs=[input1], outputs=[d2])

in your code was turned into:
model = Model(inputs=input1, outputs=d2)

I use lists because this problem had originally came from multi-input model, I've just generalized this model as simple as possible. If we came back to lists, the warning will occure again.

Thank you @Alouettesu, I had the same warning and your suggested fix silenced it for me!

@Alouettesu,
I tried to execute the mentioned code on tensorflow v2.17 and haven't observed the mentioned warning. Kindly find the gist of it here and provide if my understanding is different. Thank you!

@tilakrayal,
I don't know anything about what environment Colab is using, but the warning has occured on my local machine on version 2.13 (Windows 11), version 2.19.0-dev (Nightly, Windows 11) and version 2.18 (WSL). Please get me know if another information about my environment is necessary.


exception in train.py

It seems like that sometimes the train.py will throw exception when calculating loss?
Loss.cu:102: operator(): block: [0,0,0], thread: [6,0,0] Assertion input_val >= zero && input_val <= one failed.

I came across this error too. It seems to be some CUDA kernel problem and it happens randomly, and it may not occur as well. I did not make it to debug though. I simply ran train.py several times in parallel and there can hopefully be a successful one without error.

I go through the code and find that 2 reasons could cause this exception:

the label of gt/tempo_gt include -1 for masking, fixed version:

            valid_gt = gt.clone()
            valid_gt[gt == -1] = 0
            loss = loss_func(pred, valid_gt)
            weight = (1 - torch.as_tensor(gt == -1, dtype=torch.int32)).to(device)
            loss = (weight * loss).mean(dim=(0, 1)).sum()

            valid_tempo_gt = tempo_gt.clone()
            valid_tempo_gt[tempo_gt == -1] = 0
            loss_t = loss_tempo(torch.softmax(tempo, dim=-1), valid_tempo_gt)
            weight = (1 - torch.as_tensor(tempo_gt == -1, dtype=torch.int32)).to(device)
            loss_t = (weight * loss_t).mean()

return value and try/catch should be added to these two functions, fixed version:

def infer_beat_with_DBN(beat_pred, beat_gt, dbn_model, fps):
    #beat_pred: (B, L), estimation result
    weight = (1 - torch.as_tensor(beat_gt == -1, dtype=torch.int32))
    beat_pred = (torch.sigmoid(beat_pred) * weight).detach().cpu().numpy()
    #beat_pred = (beat_pred / fps)
    beat_gt = torch.as_tensor((beat_gt - 0.5) > 0, dtype=torch.int32).detach().cpu().numpy()
    batch_score = []
    for idx in range(beat_pred.shape[0]):
        #if (beat_gt[idx] == 0).all():
        #    continue
        if np.sum(beat_gt[idx]) < 2:
            continue
        try:
            beat_pred_batch = dbn_model(beat_pred[idx])
        except:
            return {"fmeasure": 0, "cmlt": 0, "amlt": 0}
        beat_gt_batch = np.nonzero(beat_gt[idx])[0] / fps
        score = madmom.evaluation.beats.BeatEvaluation(beat_pred_batch, beat_gt_batch)
        batch_score.append(score)
    batch_score = madmom.evaluation.beats.BeatMeanEvaluation(batch_score)
    return {"fmeasure": batch_score.fmeasure, \
            #"cemgil": batch_score.cemgil, \
            #"cmlc": batch_score.cmlc, \
            "cmlt": batch_score.cmlt, \
            #"amlc": batch_score.amlc, \
            "amlt": batch_score.amlt}

def infer_downbeat_with_DBN(beat_pred, downbeat_pred, downbeat_gt, dbn_model, fps):
    #beat_pred: (B, L), estimation result
    beat_pred = torch.sigmoid(beat_pred).detach().cpu()
    downbeat_pred = torch.sigmoid(downbeat_pred).detach().cpu()
    combined_act = torch.cat((torch.maximum(beat_pred - downbeat_pred, torch.zeros(beat_pred.shape)).unsqueeze(-1), downbeat_pred.unsqueeze(-1)), dim=-1)
    #beat_pred = (beat_pred / fps)
    weight = (1 - torch.as_tensor(downbeat_gt == -1, dtype=torch.int32)).unsqueeze(-1).detach().cpu()
    combined_act = (combined_act * weight).numpy()

    beat_gt = torch.as_tensor((downbeat_gt - 0.5) > 0, dtype=torch.int32).detach().cpu().numpy()
    batch_score = []
    for idx in range(beat_pred.shape[0]):
        #if (beat_gt[idx] == 0).all():
        #    continue
        if np.sum(beat_gt[idx]) < 2:
            continue
        try:
            beat_pred_batch = dbn_model(combined_act[idx])
            beat_pred_batch = beat_pred_batch[beat_pred_batch[:, 1]==1][:, 0]
        except:
            return {"fmeasure": 0, "cemgil": 0, "cmlc": 0, "cmlt": 0, "amlc": 0, "amlt": 0}
        beat_gt_batch = np.nonzero(beat_gt[idx])[0] / fps
        score = madmom.evaluation.beats.BeatEvaluation(beat_pred_batch, beat_gt_batch)
        batch_score.append(score)
    batch_score = madmom.evaluation.beats.BeatMeanEvaluation(batch_score)
    return {"fmeasure": batch_score.fmeasure, \
            #"cemgil": batch_score.cemgil, \
            #"cmlc": batch_score.cmlc, \
            "cmlt": batch_score.cmlt, \
            #"amlc": batch_score.amlc, \
            "amlt": batch_score.amlt}

Thank you very much! It helps a lot!


[@spec2ts/openapi] [bug] schema with "oneOf" keyword ignores "properties" keyword

I encountered a bug when attempting to generate types for the following JSON schema:
openapi: 3.0.3
info:
  title: example
  version: 1.0.0
paths:
  /example:
    get:
      responses:
        200:
          description: OK
          content:
            application/json:
              schema:
                type: object
                properties:
                  name:
                    type: string
                  value:
                    type: integer
                oneOf:
                  - properties:
                      value:
                        minimum: 0
                        maximum: 5
                  - properties:
                      value:
                        minimum: 10
                        maximum: 15

Expected result:
The library detects that there's an overlap between the properties names of $.oneOf and $.properties and generates a type that satisfies all specifications:
export interface GetExampleResponse {
    name?: string;
    value?: number;
}

Actual result:
The library ignores $.properties when $.oneOf is present. It also does not detect there's an overlap between the elements of the $.oneOf array and generates a type union that's redundant.
export type GetExampleResponse = {
    value?: any;
} | {
    value?: any;
};

I think the reason for this is either:

due to a design decision made by the initiator of the project (poke @SomaticIT) in which case all of the following should be ignored, or
scared into the misunderstanding of jsonschema validation vs annotation concepts we had when writing the core-parser, which is what I'll try to explicit below.

After diving into jsonschema drafts I get the impression that we are considering it as a "cumulative properties" model or worse a "singleton datatype" model, where it should be considered a "cumulative hierarchical constraints" model for building a datatype, starting from type unknown which "validates anything", narrowing/combining the type for each constraint and circuit breaking with never type which "validates nothing".
This would imply a complete rewriting of the parse function, so I'll dive into it and give it a try but let's talk about it so we can avoid wasting time 😅


KAFKA-4756: The auto-generated broker id should be passed to MetricRe…

…porter.configure

@junrao does this look OK to you?

@cmccabe : Thanks for the patch. LGTM


multiple samples fail with undefined field 'targets' in struct with beta 3 and beta4

mutual-ssl sample throws errors when executed
openjdk version "1.8.0_162"
ubuntu 16.04
ballerina-platform-0.970.0-beta3
error
error: ./mutual-ssl.bal:50:5: undefined field 'targets' in struct 'ballerina.http:ClientEndpointConfig'
compilation contains errors

with . https://github.com/ballerina-platform/ballerina-examples/pull/301/ the issues are fixed

samples like observe-tracing still has the issue so will reopen the ticket

This is fixed now. Can you open separate issues for each sample if there are broken


Does the nbdev-0.0.1.vsix file need to be updated before local installation?

I'd like to use the latest PR that got merged #2 , but I assume the vsix file has to be built first. I didn't see instructions for building it locally from the repo though.

 Thanks!