SNI by benwaffle - to release/0.6

What's the oldest OS you are looking to target? On CentOS 8, openssl-devel has version 1.1.1k

@benwaffle The write permission is gone... Could you add it again?
Photon supports multiple SSL versions, not less than 1.0.1 .
You can also build Photon from source, without the dependencies of the shared libs on your host.

@beef9999 I think it's gone because the other PR was closed. You can try reopening it, or just creating your own branch.

@benwaffle @BigVan New tag v0.6.16 for overlaybd

@benwaffle The CI couldn't pass in CentOS 8 with OpenSSL 1.1.1
https://github.com/alibaba/PhotonLibOS/actions/runs/8258635109/job/22591213202


Bug fix in log_file_access

In many cases, like if a file is copied, log_file_access is called without size, which makes it crash:
0x100014cc: Error while calling API handler for KERNEL32.CopyFileW:
Traceback (most recent call last):
  File "speakeasy/speakeasy/windows/winemu.py", line 1126, in handle_import_func
    rv = self.api.call_api_func(mod, func, argv, ctx=default_ctx)
  File "speakeasy/speakeasy/winenv/api/winapi.py", line 77, in call_api_func
    return func(mod, self.emu, argv, ctx)
  File "speakeasy/speakeasy/winenv/api/usermode/kernel32.py", line 3258, in CopyFile
    self.log_file_access(_dst, 'write')
  File "speakeasy/speakeasy/winenv/api/api.py", line 215, in log_file_access
    profiler.log_file_access(run, path, event_type, data, handle,
  File "speakeasy/speakeasy/profiler.py", line 200, in log_file_access
    fa['size'] += size
KeyError: 'size'

Because of this
        for et in ('write', 'read'):
            if event_type == et:
                for fa in run.file_access:
                    if path == fa.get('path') and fa['event'] == et:
                        fa['size'] += size
                        return

So here is a simple fix for it.

Good catch, merged.


Send a email error and other typos

Send an Email button (URL:  site.com/contact) when clicked:
ErrorException in Factory.php line 564:
Cannot end a section without first starting one. (View: /home/vagrant/Code/site/resources/views/about/contact.blade.php)

Also, minor issue:
typo "a" => "an"
Submit an Email

Another typo under social footer Gloogle+ => Google+

for #3, found the resources\lang\en\globals.php
line #250:
'google_label'           => 'Gloogle+',
changed to:
'google_label'           => 'Google+',

for #2, found the resources\lang\en\globals.php
line #293:
'send_a_email_label'     => 'Send a email',
changed to:
'send_a_email_label'     => 'Send an email',


Update for Linux 6.1 kernel

Is it easy to update this for the Linux 6.1 kernel? NixOS 23.05 switched to that as the default, and the upstream raspberrypi/linux repo now defaults to the rpi-6.1.y branch.

It should be an easy update. I am in progress on similar changes: I rebuilt my pis with 23.05 yesterday and am upgrading them to the 6.1 kernel to test with today. Assuming that all goes well I'll merge the kernel-6.1 branch into master.
I pushed the 5.15 and 6.1 kernels along with other packages from the overlay built against nixos-23.05 into cachix, so hopefully that saves you some time.

https://github.com/tstat/raspberry-pi-nix/pull/5


No autostart of MagicMirror²

After a fresh installation of Raspbian Strech i had problems with the autostart of MagicMirror².
The Problem seems to be that the script /etc/systemd/system/pm2-root.service starts in the root environment.
I changed the lines:
USER=root to USER=pi
Environment=PM2_HOME=/root/.pm2 to Environment=PM2_HOME=/home/pi/.pm2
PIDFile=/root/.pm2/pm2.pid to PIDFile=/home/pi/.pm2/pm2.pid
Now everything works as expected.
I'm not sure if it is an Raspbian, PM2 or an MagicMirror² Issue
Edit: "sudo pm2 startup systemd -u pi" generates the /etc/systemd/system/pm2-pi.service file but with the Environment and PIDFile set to the root directory

To setup the Startup Script, copy/paste the following command:
sudo env PATH=$PATH:/usr/bin /usr/lib/node_modules/pm2/bin/pm2 startup systemd -u pi --hp /home/pi

or use my script which does all the work
see  fixuppm2.sh  (last entry on the page here)
https://github.com/sdetweil/MagicMirror_scripts

Hi,
did not have these issue in my last installations. I already use your the scripts of you @sdetweil.
That's why I closed the ticket two years ago.


_FillValue = nan, with no missing_value, data saved w/o _FillValue or missing_value

This comes up in 2018 Saildrone data. The attributes include only a _FillValue, not a missing_value
and it's NaN
/home/users/ansley/projects/saildrone/ferretScripts> ncdump -h /home/data/saildrone/saildrone_arctic_2018/daily_files/1020/saildrone-gen_5-arctic_2018-sd1020-20180701T000000-20180701T055959-1_minutes-v2.1531526478435.nc | grep longitude
        double longitude(trajectory, obs) ;
                longitude:_FillValue = NaN ;
                longitude:coordinate = "latitude longitude timestamp" ;
                longitude:standard_name = "longitude" ;
                longitude:units = "degrees_east" ;
...

When this variable is written to a new file, it has neither a missing_value nor a _FillValue attribute
yes? save/file=a.nc/clobber longitude
 LISTing to file a.nc
yes? use a.nc
yes? show att longitude
     attributes for dataset: ./a.nc
 LONGITUDE.units = degrees_east
 LONGITUDE.axis = X
 LONGITUDE.long_name = LONGITUDE
 LONGITUDE.history = From /home/data/saildrone/saildrone_arctic_2018/daily_files/1020/saildrone-gen_5-arctic_2018-sd1020-20180701T000000-20180701T055959-1_minutes-v2.1531526478435.nc

This comes from the rather convoluted handling of these two attributes in Ferret. Internally we match only one bad-value flag. If there are both _FillValue and missing_value attributes then when the data is read, any values that match the _FillValue are replace with the missing_value and that is what's stored as the bad-value for skipping data in computations. On output, the missing_value is written, but containing the actual values in the data -- if ithad been different then it now contain the value of missing_value in the input file.  In the case where _FillValue was different on intput from missing_value, it will not be written unless the user specifically forces it to be output.  The missing_value attribute will in general be written instead.
If a file contains NaN as a _FillValue or missing_value attributes, ferret allows this but substitutes its default missing-value -1.e34. On output the -1.e34 will be written as the missing_value attribute. (Ferret isn't set up to write out NaN's.)
So here we have a case that finds a hole in all this logic.  The file has only a _FillValue attribute. When Ferret opens the file it notes this, and when data is read, it fills in any NaN's with -1.e34 and marks the bad-data flag as -1.e34.  It'll then work with the data correctly.  When it writes the data however, it sees that the _FillValue attribute from the original file is not the same as the bad-value flag and so does not write the _FillValue attribute.  It also hasn't written a missing_value attribute because there was not one in the original file.
The fix in cdf_list.F, is to add a test, if _FillValue from the file of origin differs from the bad-flag AND it's not  NaN, then do not write it. If the _FillValue was NaN, then write -1.e34.   In any other case where _FillValue will be different from the value in the original file and where it's not the same as the bad-flag, it's different from the bad-flab because there was a missing_value flag and we will have written a missing_value attribute.

This is fixed and a test for it added to the benchmarks.

In GitHub as of 5960f853bd4d0fbed1a349c7c94bca3e5793f6ce


Bump version to 1.9.0

Description

Test Plan

Related Links

Sure! Is there any action item for me to get my PR in this release?


Handle missing data noted with //// for all the various cases.

Missing data may be replaced with slashes anywhere. Only one place is handled currently, add handling for all.

There is a few specific handling and a catch all otherwise. I think that's good enough for now.


Hang on the error during profiling: flamegraph.svg: no such file or directory

> kubectl flame POD-ID -t 1m -f /tmp/flamegraph.svg -l java CONTAINER-NAME
Verifying target pod ... ✔
Launching profiler ... ✔
Profiling ... Error: open /tmp/async-profiler/flamegraph.svg: no such file or directory

The job pod under error status and logs out:
{"type":"progress","data":{"time":"2020-10-02T03:03:30.473657566Z","stage":"started"}}
{"type":"error","data":{"reason":"exit status 1"}}

kubectl-flame version:
v0.1.4, Commit: 52a33a1bfeeeead31d9b77dcf29d4f2fbe92a300, Build Date: 2020-10-01T05:55:08Z

k8s version:
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.2", GitCommit:"f5743093fd1c663cb0cbc89748f730662345d44d", GitTreeState:"clean", BuildDate:"2020-09-16T21:51:49Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.13-eks-2ba888", GitCommit:"2ba888155c7f8093a1bc06e3336333fbdb27b3da", GitTreeState:"clean", BuildDate:"2020-07-17T18:48:53Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Any idea?
Thanks!

i am assuming you are also seeing segfaults in the java container's log? i am seeing the same behavior.

Hi @zhiyanliu
Please upgrade to v0.1.5 and check if #18 fixed the profiling problem.
Regardless, better error handling is something I am aware of and hope to fix very soon.

Nice! will have a try later. Thanks for working on this.

Hi @edeNFed, I verified Version: v0.1.5, Commit: 5cb73b3, it fixed this issue on my spring-boot app.


add git information docs reference and example

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

It seems that this PR is related to a Discord post https://discord.com/channels/755913899261296641/1181347411940102294 about merge queues.
Please describe in the added documentation in what situations additional environment variables are needed to be set up as when I look at the results of running .github/workflows/example-recording.yml sometimes the branch is correctly recorded in Cypress Cloud and sometimes not.
Does .github/workflows/example-recording.yml need to be updated?

@MikeMcC399

If "Cloud" means "Cypress Cloud" then please change the terms to say "Cypress Cloud" explicitly.
Good call.

Does it relate to https://github.com/cypress-io/github-action#automatic-pr-number--url-detection and should it be placed adjacent to this section?
It appears some of the info might be more readable with different structuring. Let me know if this grouping is a viable option.

It seems that this PR is related to a Discord post https://discord.com/channels/755913899261296641/1181347411940102294 about merge queues.
Correct. The main goal here is to make it as simple as possible for users to find their answers in the documentation.

Does .github/workflows/example-recording.yml need to be updated?
Possibly, but it's not a necessity.


Removing a memory region does not delete/hide data vars in that region

Repro steps:

Open a.txt
Add a memory region: bv.memory_map.add_memory_region("a", 0xdeadbeef, b'A'*0x8)
Rename the variable a in main
Notice bv.data_vars now includes<PHONE_NUMBER>: <var 0xdeadbeef: void>
Remove the memory region: bv.memory_map.remove_memory_region("a")
Notice that bv.data_vars still includes<PHONE_NUMBER>: <var 0xdeadbeef: void>

I think this is also true with functions, or any other analysis artifacts related to the newly added memory region

I can see the desire for this in the UI but having the remove_memory_region API do that seems a little heavy handed as you should just be able to remove the data vars and functions in that region with the API easily as well.

I believe I've been affected by this issue. I'm using the debugger with a Windows binary. When I'm debugging, I define some structures in memory (heap, stack) for the analysis. After doing this several times, I started noticing that my decompilation started getting trashed by "random" symbols defined in the middle of the code.
What I think is happening is that the data variable defined on the heap survives between runs and then when I'm unlucky the .text is rebased to overlap when the ASLR places the binary over an address which was heap/stack. in some previous run.
I haven't kept track of all the addresses so I'm not 100% sure this is what's happening but it seems consistent with the description in this bug.


Stale environment for integrated terminal

I was having a problem where direnv failed loading the Nix shell due to an invalid NODE_OPTIONS flag, but only in the VS Code integrated terminal. Outside of VS Code direnv had no issue loading and NODE_OPTIONS was unset. I wasn't setting NODE_OPTIONS anywhere, such as .envrc or .env. Eventually I found reference to NODE_OPTIONS in ~/.config/Code/User/workspaceStorage/33633d8607204d6980a785c25990590d/state.vscdb.backup. It's an SQLite DB, and in the ItemTable table there's a row with key terminal.integrated.environmentVariableCollections where the value is a JSON blob and that shows the environment variable is from mkhl.direnv. Knowing that, I ran direnv: Reset and reload environment, which got rid of the NODE_OPTIONS environment variable.
It seems like somehow the direnv VS Code extension isn't properly updating the direnv environment in the integrated terminal. I had set that environment variable like 3 weeks ago to test something and then remove it and I've definitely rebooted my computer, reloaded VS Code, exited VS Code, exited the integrated terminal (typing exit to clear history), etc. I assumed re-opening VS Code would reload the environment properly.
What's interesting is that I find no logging of the direnv extension setting NODE_OPTIONS in the VS Code logs. rg --no-ignore NODE_OPTIONS -l ~/.config/Code/logs returns zero direnv results.

I was having a problem where direnv failed loading the Nix shell due to an invalid NODE_OPTIONS flag, but only in the VS Code integrated terminal. Outside of VS Code direnv had no issue loading and NODE_OPTIONS was unset. I wasn't setting NODE_OPTIONS anywhere, such as .envrc or .env. Eventually I found reference to NODE_OPTIONS in ~/.config/Code/User/workspaceStorage/33633d8607204d6980a785c25990590d/state.vscdb.backup. It's an SQLite DB, and in the ItemTable table there's a row with key terminal.integrated.environmentVariableCollections where the value is a JSON blob and that shows the environment variable is from mkhl.direnv. Knowing that, I ran direnv: Reset and reload environment, which got rid of the NODE_OPTIONS environment variable.

The direnv extension keeps a cache of the modified environment in the workspace state, that's the SQLite file you found. It's there to speed up the initial load and hopefully get the environment in place before other extensions try to use it, and has caused your issue.
What is weird is that you state the environment was only present in integrated terminals, which to me would imply that it was not present in other tasks, and the two managed environments had gotten out of sync. Is that what you meant?

It seems like somehow the direnv VS Code extension isn't properly updating the direnv environment in the integrated terminal. I had set that environment variable like 3 weeks ago to test something and then remove it and I've definitely rebooted my computer, reloaded VS Code, exited VS Code, exited the integrated terminal (typing exit to clear history), etc. I assumed re-opening VS Code would reload the environment properly.

This is leaning very heavily on assumptions and the word properly…
A .envrc file can make a series of updates to a given environment, inside you can read, set and unset environment variables.
Strictly speaking, not setting an environment variables means that you don't care about its value, and if you needed a variable to be unset you'd need to, well, unset it.
Removing a definition somewhere doesn't automatically unset a variable because there's no notion of where the variable came from, that's just not part of what environment variables are.
That said, I agree that matching your intuition would be valuable, i.e. if this extension worked more like a shell that starts from a well-known environment and only loads changes to it from known sources.
The problem there is that starting from a cache, then undoing its changes and running direnv from a clean environment, and then determining whether that led to changes from the cached environment is much harder than what we currently do.
I'm planning to try this at some point (or accept patches for it!) but to me that would be an enhancement, not a bugfix.

What's interesting is that I find no logging of the direnv extension setting NODE_OPTIONS in the VS Code logs. rg --no-ignore NODE_OPTIONS -l ~/.config/Code/logs returns zero direnv results.

I'd be very curious what you expected to find there, or how often you've managed to find something valuable there already?
I believe that files there would be generated by a LogOutputChannel, which is a quite recent feature and not yet present in the VS Code version we require. Instead we log to an OutputChannel which I don't think is persisted in a file, and I haven't gotten around to checking out the new API yet.

What is weird is that you state the environment was only present in integrated terminals, which to me would imply that it was not present in other tasks, and the two managed environments had gotten out of sync. Is that what you meant?

Sorry, should have been more clear here. I meant my terminal outside of VS Code (Alacritty). I couldn't yarn start with the VS Code integrated terminal, but I could with Alacritty. I entirely restarted VS Code several times, and the only thing that helped was explicitly running direnv: Reset and reload environment.

Strictly speaking, not setting an environment variables means that you don't care about its value, and if you needed a variable to be unset you'd need to, well, unset it.

What I mean here is if I add an env var to .env and load that via dotenv_if_exists, then remove it from .env and direnv reload I expect the env var to be gone.

I'm planning to try this at some point (or accept patches for it!) but to me that would be an enhancement, not a bugfix.

If it's not a bug, how is this supposed to work? The user needs to be aware of when the env changes and manually run direnv: Reset and reload environment or click the icons?

I'd be very curious what you expected to find there, or how often you've managed to find something valuable there already?

Looking for the added: <some_var> logs. They are there, for example:
❯ rg --no-ignore 'added: PGUSER' -l ~/.config/Code/logs
/home/austin/.config/Code/logs/20230424T100806/window2/exthost/output_logging_20230424T122404/2-direnv.log

If it's not a bug, how is this supposed to work?

Like I said, if a variable needs to be unset then one should unset it.
Also like I said: What you're expecting would be obviously strictly better.

Looking for the added: <some_var> logs. They are there, for example:

Oh all outputs get persisted there, nice. TIL, thank you!


Get truncateHl7Fields to work for integration tests

User Story
As a developer I want to be able to write integration tests that take the receiver's truncation fields into consideration.
Description/Use Case
Currently, if you write a test using a receiver that has truncateHl7Fields set, it will not actually truncate those fields.
Risks/Impacts/Considerations
Dev Notes
Acceptance Criteria

[ ] When truncateHl7Fields is set on a receiver used in the integration tests, those fields actually get truncated.

Will carry over to next sprint

I think this was fixed by Lucero's change because it is working now, so I updated MO's testing to better reflect their settings and show that it is working.

Deployment complete today, marking this as done per Jessica mentioning that it was just waiting on deployment


Website favicons get removed when audio plays

Example of youtube video with audio playing

@vinceliuice can u fix this ?


Fix quote item

Added missing fields from QuoteItem
Added missing ProductRefOrValue struct
Added missing fields from Quote
Changed visibility to public for most fields in QuoteItem

Again merging forward.


Download blob files

How to download blob files which are generated dynamically on server ?
URL: blob:https://www.xyz.com/401a7e1a-d8de-4b6c-b1ad-5c2dc9944134
So firstly it throws exception that download supports only https or http urls

Can you quote the exact exception (and perhaps stack trace)?
Apart from that, what happens if you try the same with the plain old WebView?

I have same problem plz help me download blob file

@ocram
I need to download a dynamically generated XLS (or PDF, CSV) file. Exported from alasql. It works just fine with Chrome but with WebView, its a challenge. Any insights as to how to achiveve this would be wonderful.

@utkarshns Have you solved this problem?

@DanteAndroid
Sort of.
Added a DownloadListener to the webView, which catches the blobUrls and passes them to the JavaScriptInterface class where I fire a GET request on that URL in javascript itself. I collect all the response data and then pass it on to the Java function defined in Android code to write the file.
Caveats in the method:
I can't find the fileName, fileType using these blobUrls.

Probably, what you did here, @utkarshns, was indeed the best solution.

@utkarshns Yeah, I've found it as well, post here for those have need: Download blob file from webview
And I met your caveats as well. I wonder why Chrome can download file with correct name.

Is it also works in nativescript too??

I wants to download the file
I used this in my code:
    ngOnInit() {
            let webview: WebView = this.webViewRef.nativeElement;

            if (isAndroid) {

                webview.on(WebView.loadStartedEvent, function () {
                    webview.android.getSettings().setBuiltInZoomControls(false);
                    webview.android.getSettings().setJavaScriptEnabled(true);
                    webview.android.getSettings().setJavaScriptCanOpenWindowsAutomatically(true);
                    webview.android.getSettings().setAllowFileAccess(true);
                    webview.android.getSettings().setPluginsEnabled(true);
                    webview.android.getSettings().setAllowContentAccess(true);
                    webview.android.getSettings().setAllowFileAccess(true);
                    webview.android.getSettings().setAllowFileAccessFromFileURLs(true);
                    webview.android.getSettings().setAllowUniversalAccessFromFileURLs(true);
                    webview.android.getSettings().setDomStorageEnabled(true);
                    webview.android.getSettings().setDefaultTextEncodingName("utf-8");

                    webview.android.setDownloadListener(new android.webkit.DownloadListener({
                        onDownloadStart(url, userAgent, contentDisposition, mimetype, contentLength) {
                            let request = new android.app.DownloadManager.Request(android.net.Uri.parse(url));
                            request.setMimeType(mimetype);
                            let cookies = android.webkit.CookieManager.getInstance().getCookie(url);
                            request.addRequestHeader("cookie", cookies);
                            request.addRequestHeader("User-Agent", userAgent);
                            request.setDescription("Downloading file...");
                            request.setTitle(android.webkit.URLUtil.guessFileName(url, contentDisposition, mimetype));
                            request.allowScanningByMediaScanner();
                            request.setNotificationVisibility(android.app.DownloadManager.Request.VISIBILITY_VISIBLE_NOTIFY_COMPLETED);
                            request.setDestinationInExternalPublicDir(android.os.Environment.DIRECTORY_DOWNLOADS, android.webkit.URLUtil.guessFileName(url, contentDisposition, mimetype));
                            let dm = utils.ad.getApplicationContext().getSystemService(android.content.Context.DOWNLOAD_SERVICE);
                            dm.enqueue(request);
                        }
                    }));
                });
            }

But still i'm getting blob error.

did anyone fixed this issue?
I'm getting blob URLs in my webpage but not sure how can I download file from it.


feat(either): add future interoperability

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
This change will help concatenate synchronous and asynchronous calls by transforming an Either into a Future. This way, we won’t need to manually map the call; instead, by invoking the method, we make it asynchronous, allowing us to use async maps.
Added/updated tests?
We encourage you to keep the quality of the code by creating test.

[x] Yes
[ ] No, and this is why: please replace this line with details on why tests
have not been included
[ ] I need help with writing tests

[optional] What gif best describes this PR or how it makes you feel?

Hi @Wolfremium13!
Thanks for your job! :D
Could you modify the following things?

Create an Interface that represents a Rol, for example Futurible (you can propose another option for the name).
This interface has the toFuture method, so any monad that implements this need to implement this method
Finally, to check this, the best approach from my point of view, it is to create a Rol based test suit for that interface. So, in the same test suit we can check the expected behavior for all monads we select to implement the Rol. In addition, we can check which monads are supporting synchrony, and we have a clear way to extend it to more monads.

If you have any questions, do not hesitate to ask 😄
We have some examples with matchable and monad interfaces about Rol based testing


Custom css animations/transitions support

Have you thought about this?

What do you mean?  It supports custom animation values.

If I want to configure animation via css?

So the flow in this case would be:
Insertion:

When element is just inserted in DOM it gets some class animate-in (css animation is performed)
Waites animation/transition end, removes this class

Removal:

When element is going to be removed from DOM it gets some class animate-out (css animation is performed)
Waites animation/transition end, removes element from DOM.

@whitecolor Have you read the docs on this?  For example: https://github.com/bitovi/can-animate/blob/master/doc/when.md or https://github.com/bitovi/can-animate/blob/master/doc/style.md#use
You can do pretty close to what you are doing.  I'm not sure if we can do it via className (not all browsers support CSS animations).  However something like:
<div can-animate-when="inserted" can-animate-style="opacity: 1">

cc @jandjorgensen

I'm not sure if we can do it via className (not all browsers support CSS animations)
why care too strongly about old browsers, anyway all mordern browsers and even mobile do support css animations

@justinbmeyer this actually pretty easy to implement, it would be also good to have before remove hooks API.

Why this code doesn't work?
var oldRemove = can.remove;

can.remove = function (wrapped) {
    return oldRemove.apply(this, arguments);
};

the error:
 Potentially unhandled rejection [1] TypeError: Cannot read property 'attributes' of undefined
    at addAttributesCallback (http://bbooks-reader.local:7001/bower_components/canjs/view/stache/stache.js:100:14)
    at Object.parser.close (http://bbooks-reader.local:7001/bower_components/canjs/view/stache/stache.js:154:6)
    at parseEndTag (http://bbooks-reader.local:7001/bower_components/canjs/view/parser/parser.js:115:15)
    at String.replace (native)
    at HTMLParser (http://bbooks-reader.local:7001/bower_components/canjs/view/parser/parser.js:160:16)
    at stache (http://bbooks-reader.local:7001/bower_components/canjs/view/stache/stache.js:106:3)
    at Object.can.view.register.fragRenderer (http://bbooks-reader.local:7001/bower_components/canjs/view/stache/stache.js:312:11)
    at Function.can.extend.register.can.(anonymous function).$view.(anonymous function).renderFunc (http://bbooks-reader.local:7001/bower_components/canjs/view/view.js:404:25)
    at Constructor.can.Component.can.Construct.extend.setup (http://bbooks-reader.local:7001/bower_components/canjs/component/component.js:300:30)
    at Function.can.extend.newInstance (http://bbooks-reader.local:7001/bower_components/canjs/construct/construct.js:114:23)

I think jan got remove working
Sent from my iPhone

On Feb 26, 2015, at 2:09 PM, Alex<EMAIL_ADDRESS>wrote:
@justinbmeyer this actually pretty easy to implement, it would be also good to have before remove hooks API.
—
Reply to this email directly or view it on GitHub.


Contributor instructions missing critical step

xjava/README.md should explain that after cloning xjava locally, the x-api server must be restarted to serve newly added problems.
I don't know if this would be true for pre-existing problems that have been modified.

The xapi server doesn't use the xjava track directly. It includes xjava as a submodule. So if you have both the xapi and xjava, these don't conflict.

That said... if you want to check how this would work out in x-api, then you would need to cd to xapi/tracks/java and do a git pull... and then restart the server.

I think I may have mis-explained the issue, or I don't understand what you mean.
I was describing the step where you run x-api locally to serve your local xjava and make sure the exercism fetch java <myproblem> correctly serves the exercise.

Yeah, I think we probably explain that wrong in the docs, now that you bring it up.

So FMI does the server load everything into memory at start, or is it pointing at a previous commit of the xjava repository, so it doesn't see changes made after startup?

It's pointing at a previous commit in the xjava repository. Each track is checked out separately and the repo that's living underneath x-api/tracks needs to be updated with the commit.
This is something that I've been doing manually whenever I need to and have completely and utterly forgotten to document.

@kytrinyx I still think I'm not explaining this correctly.  This is an issue I'm seeing locally when running x-api on my dev machine to test fetching a newly added exercise from my local copy of x-java.
I think the mistake I made was running rackup before changing config.json in the x-java root directory (local copy) to include the name of the new exercise.
It appears x-api is able to serve changes to the exercise directories without a restart.  EG, add or change a test, no problem-- the changes are downloaded on the next exercism fetch.  But it didn't see the change to config.json without restart, so it thought it didn't have that route.
I discussed this with @jtigger, and it got us to wondering what other files x-api reads only at startup.  In other words, what changes in the local xjava would require an x-api restart when developing?
Thanks!

Aaaaah, yeah that is totally not the discussion I was having! Thank you so much for clarifying. I actually haven't looked at which files are cached after the first time they're read.
I think we should assume that any file could be cached and that the server should be restarted on any change to a local xjava file.

Yes, we can thank @jtigger for realizing that you and I were having two
different conversations  :)
I'm fine with telling them to restart after any change, @jtigger?
On Sun, Mar 13, 2016 at 1:10 PM, Katrina Owen<EMAIL_ADDRESS>wrote:

Aaaaah, yeah that is totally not the discussion I was having! Thank you so
much for clarifying. I actually haven't looked at which files are cached
after the first time they're read.
I think we should assume that any file could be cached and that the server
should be restarted on any change to a local xjava file.
—
Reply to this email directly or view it on GitHub
https://github.com/exercism/xjava/issues/100#issuecomment-196002707.

--
Matt Morgan
Director of Technology
Dulcet Software LLC
(734) 926-8142

Thank you @jtigger!

Closed by #113


BMI160 I2C communication sporadically fails. Using FIFO and WATERMARK

In my use case I configure BMI160 ACC to sample at 50Hz rate and I configure interrupt watermark level to 75 (interrupt each ~1sec).
Sporadically communication of I2C fails during bmi160_get_fifo_data(). While reading size of FIFO, usually I receive NACK after reading first of two bytes. Retry after 5ms doesn't help. It happens sporadically after 5-15 mins of work.

I'm facing similar problem. Even with a delay added between ISR and I2C transfer, the issue occurs once in a while. Interrupts every 50ms.


Program not launching

Hello,
I am on windows 10.
I installed GCC.
I downloaded libdeflate and copy cczdecrypt.exe inside the folder.

But when i try to run cczdecrypt.exe i only see a cmd prompt flashing.
Can you provide me some assitance ?
Thanks

cczdecrypt is invoked from the command-line the same way you invoked gcc (which isn't required for running the program anyway, it's only for compiling from source).
To use the program you'll need to pass the encryption key to the program (run cczdecrypt --help for more info).
By the way, I'm not sure which tutorial you followed but your gcc is 7+ years out of date. The latest version is 13.2, which you can get from the MSYS2 project's MinGW.

Hello,
Thank you for your quick reply.
With MiniGW, i can now use cczdecrypt --help.
I just need to ask my coworkers for the key, miss that part...
Thanks again !
K.


fix(sab): check for sab before using it

Context
SAB requires a secure context, and stack viewport can work without it (although MPR still needs a secure context https and CORS headers to work), but this will solve making the viewer actually work in the stack viewport at least.
https://community.ohif.org/t/dicom-images-infinite-loading/831/2?u=jbocce

Changes & Results
Check for SAB before using it

Testing
Run viewer against an unsecure context (localhost is secure by design), run it against an ip

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

[] I have run the yarn build:update-api to update the API documentation, and have
committed the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] "OS:
[] "Node version:
[] "Browser:

CC @Ouwen I think this is what you were talking in the office hours


Improved error handling.

Following example of how to handle parsing error is far from ideal. Happy to discuss changes.
public static void ErrorHandling(ErrorCode errorCode)
        {
            switch (errorCode)
            {
                case ErrorCode.OptionValueMissing:
                    logger.LogError("Could not execute command. Value was not specified for one of the options.");
                    break;
                case ErrorCode.RequiredOptionMissing:
                    logger.LogError("Could not execute command. Some required options were missing.");
                    break;
                case ErrorCode.InvalidOptionsFormat:
                    logger.LogError("Could not execute command. Format!!!!!!!!");
                    break;
                default:
                    logger.LogError("Could not execute command due to some general error.");
                    break;
            }
            logger.LogInformation("Try `help --command <command>` to see more details.");
        }

So do we only expect to adjust error messages here? What is the problem that we actually want to solve?

@jmarlew - take this for example: "Could not execute command. Some required options were missing." - clearly we know which missing command cause the program to fail - but as consumer you are only getting enum value. The question is - how we could provide better information on what happened - without creating 4+ custom exceptions..
Ideally I would want to have something like:
public static void ErrorHandling(ErrorCode errorCode, SomeParams errorContext) {

    logger.LogError("Could not execute command. Value was not specified for the following option: {errorContext.MissingOption}");

}

as consumer you are only getting enum value - what scenarios do you expect? When a user of netCLI library can be interested in more detail about the error(s)?
As a user I would expect to use a custom library like this so I don't need to bother about handling typical errors (like ones described in this issue).
I guess that in 99% cases you would expect that user will not introduce custom error handling, because default handling is enough - it displays a message about what's wrong.
For remaining 1% I would introduce an interface that may be implemented and used to override the default behaviour.
Most basic definition of this interface could look like:
public interface ICliErrorHandler
{
    void HandleError(ErrorCode errorCode);
}

but we may aim at something more like:
public interface ICliErrorHandler
{
    void HandleOptionValueMissing(OptionValueMissingContext context);
    void HandleRequiredOptionMissing(RequiredOptionMissingContext context);
    //...
}

and default netCLI implementation would introduce virtual methods so final consumer may inherit from the default class and use it as a base and eg. override handling for only one error type.

I opt for creating a custom exception that will get a list of properties with invalid values or properties missing and, based on that, build an appropriate message. As I don't see any other behavior after exception occurs other than logging it, this will also simplify the ErrorHandling method, leaving there only a single line:
logger.LogError(CustomException.Message)

@MarcinIN, your proposal requires that all exception will need to fit into interface ErrorCode errorCode, SomeParams errorContext, required them to be related to Options (Params).
I also think that displaying only a single error per run could be quite frustrating when a couple of the parameters are not supplied / are not supplied correct.
Approach with passing Exception into the ErrorHandling message allows passing there AggregateException which will bundle couple exception together, allowing to display them at once, example:
Could not execute SomeCommand. Following required option was not supplied: Option1, Option2.
Could not execute SomeCommand. Values were not specified correctly for following options: `Option3`.


Send directly to elasticsearch

Hi,
We want to use the extension to send directly to our elasticsearch node.
In the elasticSearchTarget we see that there is a post method
https://github.com/index0h/yii2-log/blob/master/src/ElasticsearchTarget.php#L39
However we can not find where this posts to as no dsn is associated with the ElasticSearchTarget.
Is there a way to post to an elastiocsearch node and bypass logstash?
-S.

Hi

However we can not find where this posts to as no dsn is associated with the ElasticSearchTarget.
ElasticsearchTarget uses yiisoft/yii2-elasticsearch all connection configuration is stored there.

In case of two and more connections you should set up ElasticsearchTarget::$componentName property


Small fix graph_extraction_prompt.py

Sorry for the delay @Zochory. After some recent updates, we no longer use this section of code. It has been removed entirely in the most recent updates so I will close this for now. Thank you for the contribution though!


Logs created with Stackdriver integration can't be exported to BigQuery

The logs we create have a struct called format_parameters with fields which have names that are just numbers, as well as {OriginalFormat}. These are passed to us by ASP.NET Core, but we could probably parse the strings if necessary.
Currently any field name that's just a digit is converted into _ when exported to BigQuery, which leads to duplicate fields, so the entry can't be exported at all.
A couple of options:

Add _ as a prefix to the field name
"Understand" the {OriginalFormat} and numbered fields, and handle them separately, e.g. as an array for the values and a separate field for the original format.

These would change the format of any existing logs, so I'll at least need to look at how long we've been formatting parameters like that.
cc @henkmollema who may have thoughts on this.

Okay, so I've done a bit of digging, and:

The parameters were added in 24473e16838d9e56d98b08d8cf8845c9cad89397 on April 3rd 2018 - so they've been in for about a year. (Release 3.0.0-beta01 was on April 16th 2018)
This was not in 2.0, and 3.0 hasn't been released, so we at least wouldn't be breaking a GA release

I'm going to prototype at least one PR, maybe two, for the different options. I want to at least check that adding _ as a prefix would give us a valid export.

Extended support for parameters from logging scopes were added later: https://github.com/googleapis/google-cloud-dotnet/pull/2385.  I'm not sure where the fields with numbers come from. The structure of a log entry should look like this:
message: "message Corge"
scope: "first 42 => second Baz => "
format_parameters:
  "Qux": "Corge"
  "{OriginalFormat}": "message {Qux}"
parent_scopes:
  [
    {
      "Bar": "Baz"
      "{OriginalFormat}": "second {Bar}"
    }
    {
      "Foo": "42"
      "{OriginalFormat}": "first {Foo}"
    }
  ]

Does the array parent_scopes result in fields with numbers?

Looking through the logs I do see the numbers appear:

@henkmollema: Interesting - I haven't been looking at parent scopes at all. It was the format_parameters that I've seen as numbers, and that's presumably just because I've used them that way in my Noda Time logging. (I'd been treating the format string as a regular string.Format-style string.)
If that's the case, then a) I can fix Noda Time myself with the current version; b) it's less of a breaking change to add the underscore at the start for "just digits" keys, as it will affect fewer users.
The parent_scopes part should be okay, as that's a genuine array, rather than an object with numbers as keys.

I see, option B sounds good to me.  👍


Using quotes for liquibase.percona.options doesn't always work

Hey,
im not sure im using the liquibase.percona.options properly, but when i try to set options i get weird errors saying that they are not a valid variable name.
Ex (i modified my /usr/bin/liquibase file to support the java system properties) so it tries to run the following command now:
java -cp ...libs... liquibase.percona.options="--critical-load=\"Threads_running=160\" --alter-foreign-keys-method=\"auto\"" liquibase.integration.commandline.Main --logLevel=info --contexts=test --username=test --password=test --url=jdbc:mysql://localhost/test --driver=com.mysql.jdbc.Driver --classpath=/usr/share/java/mysql.jar:/test/database/ --changeLogFile=databaseChangeLog.xml update
which results in the following error (edited before and after):
........
INFO 7/17/19 8:26 AM: liquibase: databaseChangeLog.xml: ***: Executing: pt-online-schema-change --critical-load="Threads_running=160 --alter-foreign-keys-method="auto --alter="***" --host=localhost --port=3306 --user=test --password=*** --execute D=test,t=test
Usage: pt-online-schema-change [OPTIONS] DSN
Errors in command-line arguments:
   * Invalid --critical-load: "Threads_running is not a variable name
   * Invalid --alter-foreign-keys-method value: "auto
pt-online-schema-change alters a table's structure without blocking reads or
.......

Any ideas whats going wrong?
EDIT: Managed to get it working using the --config option, good enough for what i need.

Great that you got it working via the --config file.conf option.
I think, it has something to do with the quotes, as you can see, they ended up in the arguments of pt-osc:

Invalid --alter-foreign-keys-method value: "auto

I suspect, it has something to do with the method joinQuotedArguments.
In your case, you wouldn't need the extra quotes (since there are no spaces), so it should work if you just use
-Dliquibase.percona.options="--critical-load=Threads_running=160 --alter-foreign-keys-method=auto".
I think, I'll keep this open, since obviously the option/space/quote handling is wrong.

Thanks for fixing anyway :)


Lua 5.3 compatibility

It seems like Lua 5.3 doesn't like it when you put floats into long tensors. Simply taking the floor explicitly (which is what Lua 5.2 does implicitly) seems to work.

Thanks!


Bazel initial commit, take 2

Only bazel file additions, no changes to existing code.

Replaced by #71


Unable to add Erc20 Tokens to MEW . Tokens disappear when I log out

I have tried several times to add my tokens to MEW and after adding them as soon as I log out the custom added tokens disappear and I have to add them again. I know I am adding the tokens correctly because it shows how many tokens I have when I add it but why can't it stay. Why does it disappear and I have to create custom token again when I log back in?

Are you using Firefox? I can't reproduce but we are aware of reports of this happening.

I use Google Chrome.
Christiana Okhipo
<EMAIL_ADDRESS>
On Aug 2, 2017, at 9:25 PM, Taylor Monahan<EMAIL_ADDRESS>wrote:
Are you using Firefox? I can't reproduce but we are aware of reports of this happening.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Please add ReSpeaker 4-Mic Array support!

sudo journalctl -f -u respeakerd
-- Logs begin at Thu 2019-02-14 08:11:59 -02. --
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24242ms)INFO  -- The source's negotiated info: name: alsa_input.platform-soc_sound.seeed-source, rate: 48000, format: float32le, channels:4, flat volume: 1  [pulse_collector_node.cc:404]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24242ms)INFO  -- Initialize RingBuffer successed.   [pulse_collector_node.cc:426]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24253ms)INFO  -- Connected to PulseAudio server.  [pulse_collector_node.cc:493]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24253ms)INFO  -- PulseCollectorNode thread started.  [pulse_collector_node.cc:506]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24253ms)ERROR -- VepAecBeamformingNode fail to read microphone config file, error[-1]: no such file.  [vep_aec_beamforming_node.cc:184]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: (24254ms)INFO  -- PulseCollectorNode thread joined.  [pulse_collector_node.cc:635]
fev 24 20:21:40 jarvis respeakerd_safe[1321]: Can not start the respeaker node chain.
fev 24 20:21:40 jarvis respeakerd_safe[1321]: /usr/bin/respeakerd_safe, linha 88:  1355 Falha de segmentação  /usr/bin/respeakerd --source="${SOURCE}"
fev 24 20:21:40 jarvis systemd[1]: respeakerd.service: Main process exited, code=exited, status=139/n/a
fev 24 20:21:40 jarvis systemd[1]: respeakerd.service: Failed with result 'exit-code'.

Hi @oangelo , since the ReSpeaker 4-Mic Array board has no output codec, it's hard to tune the algorithms to work perfectly, the AEC algorithm needs strict collaboration of the capture and playback codec. We decide not to support the 4-Mic Array with librespeaker after we've done many experiments.

I see, thanks.


SonarCloud findings

Spike Goal
Look at SonarCloud findings and determine what finding should be fixed before CA go live.
Timebox
1 Day
Notes
A new backlog task should be created for each item to be addressed.

Started this morning

Reviewed. Second review by @halprin. We determined no items are necessary for go-live. Moving to done.

Reviewed. Second review by @halprin. We determined no items are necessary for go-live. Moving to done.

And for those digging through this issue later, that doesn't mean that the current items aren't worth doing.  It just means the aren't worth doing before CA go-live.

This seems great, thanks for verifying @jherrflexion and @halprin .


Fantom support

Flashloan Aggregator(infinite) added on Fantom.
Closes #71
Routes added-

Route 9 - Aave V3
Route 10 - FLA self route

Additional chnages in FLA-

AdminModule added
addNewRoutesAndEnable , updateRouteImplementations, changeRouteStatus, getEnabledRoutes functions added
fallback added for callback functions

Additional chnages in Resolver -

AdminModule added
addNewRoutes , updateResolverImplementations functions added
Resolver implementations added
mapping of route to resolver address created

Lint the code over the end


Add sass requirement

Neat adds it's stylesheets to the Sass load paths however we are not
requiring sass explicitly. Previously, Sass was being required
implicitly through bourbon however, as of bourbon-5.0 Sass is no longer
required in the gem itself resulting in an error within Neat.
Resolves https://github.com/thoughtbot/neat/issues/429

:+1:, thanks @dgalarza!


Override or omit the need for "!!"

Thank you for this tool.
Sometimes the value you want to replace has to be in a pre-defined valid format, which the !! wrapper breaks. Is there a way to override this behaviour?

Do you have a case where !! appears in the output string and should remain there? Can you give an example where this breaks?

incompetent user error - disregard.


Type of stochastic oscillator

I use type() of indicators in my code and found out that the type of stochastic oscillator is defined as "RSI" although I expected "STO". Is it on purpose?
https://github.com/rrag/react-stockcharts/blob/master/src/lib/indicator/stochasticOscillator.js#L11

I had it fixed in the next branch, I suggest you try with that npm install -S react-stockcharts@next make sure to review the [breaking changes](I had it fixed in the next branch, I suggest you try with that npm install -S react-stockcharts@next make sure to review the breaking changes)


Error building cassandra 3.11

./gradlew build

Configure project :
Inferred project: priam, version: 3.12.0-SNAPSHOT

FAILURE: Build failed with an exception.

What went wrong:
com.google.common.util.concurrent.ExecutionError: java.lang.NoClassDefFoundError: nebula/plugin/dependencylock/DependencyLockPlugin$LockVersionConstaint

java.lang.NoClassDefFoundError: nebula/plugin/dependencylock/DependencyLockPlugin$LockVersionConstaint

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED in 1s
This wasn't happening just a few weeks ago.
528b22a8802afb641436e276b454ea66dc5821d4 is the sha I'm using.
Help appreciated.
Thanks.

@amr46 This was due to the fact that gradle 4 and netlifxoss did not play well. Updated to latest gradle 4.4 and netflixoss. If you pull latest code it should work.

Testing it now - it was also broken in master FYI.

@amr46 Yes, master is not going to build as is. There are multiple things which are wrong in master branch and as it stands it is more or less deprecated because I hardly know folks who are still using C* 1.x. We plan to merge 3.x to master but it is not high on priority list.
fyi: 3.x (C* 2.x and 3.0.x) and 3.11 (C* 3.11) are branches where major development work is going on.

can you guys give us a workaround to build?
I tried several tags but still failed to build.

@vuminh88 @amr46 does it work for you now? Ensure that you have done a rebase of your 3.x and/or 3.11 branches to latest.
master branch as it stands is deprecated. We need to do a full merge of 3.x to master. See #601

@amr46 @vuminh88 sandeepgajjam Fixed master so it will build now with fix: #648
Ensure you rebase your master to latest and then do gradle build.


Document substr() now returning an empty string instead of FALSE when the truncation happens on boundaries

This is not a minor bc break, many libs/frameworks use false !== substr() in practice see
https://github.com/php/php-src/blob/php-7.0.0RC6/UPGRADING#L430

Hi!
Strictly comparing substr()'s return value to false is not necessarily invalid still. substr() may still return false if:

The start position is greater than the string: substr("abc", 4)
The end position is a negative number that has an absolute value that is greater than the string length: substr("abc", 0, -4)
The end position is less than 0, and the last position minus the start position plus the string length is less than 0: substr("abc", 3, -1)

substr() is a common function though, so a quick note in the Changes section may be helpful. I'll add that in soon.
Thanks,
Tom

I was thinking about this... It seems a bit dangerous for a framework to behave in a special way when substr() returns false, other than to say that the input was invalid. substr() should not be used to validate the string's length or provide other guarantees about the string's structure. Thinking long term, frameworks and libraries should only expect that substr() will return the substring of characters that meet the index criteria supplied. The fact that it returns false at all is PHP trying to help you realize that you made a mistake to even call the function with those parameters. An empty string in those cases would at least reduce the possible function return types.


VOLT -> ELECTRIC_POTENTIAL_VOLT

With the latest HomeAssistant update the integrations stops running. In the logs are errors mentioning the VOLT import could not be found.
After manually changing VOLT -> ELECTRIC_POTENTIAL_VOLT on line 30 and 67 in sensor.py things are working again.

Fixed in v1.0.3


Mock/stub rails method

Hi! At first thanks a lot for that awesome library!
Rails newbie here. I have a method in my application
def direct_request?
  // logic here
end

Usually it returns false, but I want it to be true  in some scenarios when I call cy.visit().
I tried to create command with following code
Dashboard::BaseController.any_instance.stubs(:direct_request?).returns(true) and call it in my test cy.app('set_direct_request')  but it doesn't work.
Is it possible to mock/stub it ? Thanks in advance!

Unfortunately, currently there is no way to stub methods 😿
It's a pretty tricky thing to do and hopefully someone one day will figure it out 🙏🏽
I the meantime you could look at using a "flag"
def direct_request?
  return true if ENV['SKIP_DIRECT_REQUESTS']
  // logic here
end

set_direct_request.rb
  ENV['SKIP_DIRECT_REQUESTS'] = command_options['skip']

in cypress
  // enable
  cy.app('set_direct_request', { skip: true } )

  // disable
  cy.app('set_direct_request', { skip: false } )


Fundamental Data Types Need Implementing

Full capabilities of the framework cannot be utilised for mod development until a wider set of REObject and general RE:Engine data types have been implemented.
As an example, the app.ropeway.PlayerManager requires a RopeWayPlayerManager class to be implemented in ReClass_Internal.hpp. There are several bespoke data types defined in the REEngine, which REObjects such as the PlayerManager make use of; app.ropeway.PlayerDefine.PlayerType is one such type that PlayerManager uses which is not currently defined anywhere.
By assembling a more comprehensive collection of objects and types which describe the structures being used within the REEngine, more power can be leveraged from the RE2-Mod-Framework.
I can see that ReClass_Internal.hpp was generated from ReClass.NET - @praydog what was the process you used to construct the very detailed and thourough set of data for RopewayIlluminationManager (app.ropeway.IlluminationManager)? If you can describe the tools and processes you used, I can investigate this issue.

Just spoke with @praydog - the process is as such:

I use ReClass.NET to create what's in ReClass_Internal.hpp. You can use the re2.rcnet file in the reversing folder with ReClass. It has a built-in generate C++ header button. You can attach it to re2.exe to get a live view of memory for any class you want, kind of like Cheat Engine's memory dissector. You can also modify any value you want in the class, also like Cheat Engine.
In regards to process, it's pretty easy with ReClass, just input the address next the class created. To create proper inheritance, you'll need to create a class instance at the start of the class, this tells ReClass to make the class inherit from whatever class instance is at the top. From there, you'll need to give the class a proper size (which can be found with ObjectExplorer). From there, I'd match up with what I'm seeing in ObjectExplorer in ReClass, and create the proper types. There are probably some videos somewhere on using the tool.
For some fields, you will need to do manual reverse engineering work with IDA if you can't seem to match the value up to anything in ReClass. Each field has a function used to retrieve the value (you can see this in VariableDescriptor).
If you plan on making a PR with changes to ReClass_Internal, don't commit changes to re2.rcnet, it is in a binary format which makes it extremely hard to collaborate with unfortunately. I can manually add the changes made to re2.rcnet if it's not too large of a diff.

I have made some progress with the RopeWayPlayerManager given the above method described, however a useful capability would be to view the current value for a variable field in the ObjectExplorer. @praydog I have tried extracting values from the VariableDescriptor void* function as you have described but I have had no luck; any suggestions as to how we can get this rendering name to the field name in the ObjectExplorer?

Pull the latest commit, I've added support for viewing the values if you click on the field now.


mqtt.js connecting issue

I am running a mochi websocket server behind traefik reverse proxy,
in browser I am testing it with mqtt.js
the issue I met is that the connection just give 400,
and server log shows nothing,
when I use postman with ws related headers the server log shows unexpected EOF,
how should I approach the issue?
thanks

or does mqtt.js directly working with the websocket listener? does it need any additional configuration?

MQTTX supports WebSocket connections to the broker server. You can try using MQTTX to connect to your broker in your environment. If MQTTX also encounters the same issue, then you can try connecting to the broker separately without using the proxy. If the problem doesn't occur when not using the proxy, then you need to investigate the cause related to the proxy.

thank you for the help,
for MQTTX I encoutered an issue during testing, my endpoint has path in url, e.g wss://domain/api/mqtt/v1
at the UI of mqttx it seems path is not supported there,
is there known mqtt websocket client that support path can be used for testing?

Hi,
I tested locally, using mqttx as client and mochi mqtt as server, the error remain same for me,

import (
	"log"
	"os"
	"os/signal"
	"syscall"

	mqtt "github.com/mochi-mqtt/server/v2"
	"github.com/mochi-mqtt/server/v2/hooks/auth"
	"github.com/mochi-mqtt/server/v2/hooks/debug"
	"github.com/mochi-mqtt/server/v2/listeners"
	"github.com/rs/zerolog"
)

func main() {

	sigs := make(chan os.Signal, 1)
	done := make(chan bool, 1)
	signal.Notify(sigs, syscall.SIGINT, syscall.SIGTERM)
	go func() {
		<-sigs
		done <- true
	}()

	server := mqtt.New(nil)
	l := server.Log.Level(zerolog.DebugLevel)
	server.Log = &l

	_ = server.AddHook(new(debug.Hook), &debug.Options{
		ShowPacketData: true,
	})
	_ = server.AddHook(new(auth.AllowHook), nil)

	ws := listeners.NewWebsocket("ws1", ":1882", nil)
	err := server.AddListener(ws)
	if err != nil {
		log.Fatal(err)
	}

	go func() {
		err := server.Serve()
		if err != nil {
			log.Fatal(err)
		}
	}()

	<-done
	server.Log.Warn().Msg("caught signal, stopping...")
	server.Close()
	server.Log.Info().Msg("main.go finished")
}

the mochi mqtt server code is like above, pretty much like copied from example,
I build and run it within wsl of windows environment,  the server started normally with logs,
then in browser localhost:1882 gives bad request, I guess it means windows -> wsl is ok,
then within MQTTX ui, I tried ws://localhost:1882 for path part I tried to enter nothing,
in this case it gives bad request as well,
does anybody tested with mqtt.js before? is there working example by any chance?
thanks

I spent some time writing this demo, you can take a look. Connecting to Mochi with mqtt.js is not an issue; perhaps there is a problem between your WSL and Windows. My environment has Mochi broker running on Windows, and this demo is also running in a web browser on the same computer.
Here is the demo's code:`

Document

Send Message

`

@alexmengyuan Has this issue been resolved? Can we close this issue now?

thank you for the help, my problem solved now, it turn out to be a traifik proxy auth issue as suspected..


Git add all and git commit

Example:
$ gac "commit message"

The alias gcam does almost the same thing already.
Also, if we are very precise, your gac alias isn't properly positioned since the list of aliases should be sorted alphabetically :wink:.

Hm, seems that my PR command is actually have been created.
Since then, I will close this PR.


Reduce minimum footprint to 3 VMs and other improvements

Changelog

Reduced minimum footprint to 3 VMs by moving some logic from template to script
Improved logging and parameter validation (stripping special characters from password fields)
Improved error checking in script so deployment fails if script runs into issues
Changed logging so passwords are no longer logged to log files or intermediate config files

Isaac already reviewed via his merge of this branch with his


Fix token input

Mapbox and Maptiler access tokens were swapped.
Demo: https://2475-67726921-gh.circle-artifacts.com/0/artifacts/build/index.html

@orangemug should we remove the Mapbox token input from the export modal?
Currently it has no purpose because it's not part of the style URL and not included in the style.
It's still there because it was needed for the gist export which we removed (ref https://github.com/maputnik/editor/issues/239).

Sorry for the delay, it's been a busy stressful week last week. Merging!
With regards to Mapbox should we instead fix it to make the Mapbox token append to mapboxgl.accessToken = "<access_token>"?

With regards to Mapbox should we instead fix it to make the Mapbox token append to mapboxgl.accessToken = "<access_token>"?

Sorry, I don't understand what you are suggesting.
I was referring to the export modal. When downloading a style, we are exporting a JSON file. The Mapbox token isn't included in this JSON style file (unlike Maptiler and Thunderforest keys which are e.g. appended to the source URL in a style).
So I think we don't need the Mapbox token input in the export modal...

Sorry @pathmapper I think I confused myself as well 😁
So in theory you could provide a ?access_token={key} query param for a Mapbox data source and set Mapbox Access Token in style settings/export style. Maputnik would then do the key replacement on render/export.
Although I guess because we haven't got a fallback token for Mapbox I guess that really wouldn't be useful right now.
So yeah good idea, lets remove Mapbox Access Token from the style settings/export modal.

So in theory you could provide a ?access_token={key} query param for a Mapbox data source

@orangemug that's what I've tried, but it doesn't work like this, see:
https://jsbin.com/rodukofiwi/1/edit?html,output

because we haven't got a fallback token for Mapbox

There is still the token from @lukasmartinelli in
https://github.com/maputnik/editor/blob/master/src/config/tokens.json#L2, we just removed the Mapbox styles and source in
https://github.com/maputnik/editor/pull/391/files.
As mentioned in https://github.com/maputnik/editor/issues/385#issuecomment-619422965 with the new Mapbox pricing the free map loads / month might be enough.

lets remove Mapbox Access Token from the style settings/export modal

I would keep it for the style settings modal, because it is still functional, e.g.
https://maputnik.github.io/editor?style=https://rawgit.com/mapbox/mapbox-gl-styles/master/styles/satellite-v9.json
For the export modal I don't see currently any use unless it is possible to include the token somehow in the style so that such a style would work in GL JS without setting
mapboxgl.accessToken = '<your access token here>' like in
https://docs.mapbox.com/mapbox-gl-js/example/simple-map/.

As mentioned in #385 (comment) with the new Mapbox pricing the free map loads / month might be enough.

'Up to 50,000 Free' - yeah you're right @pathmapper, we might as well put a token back in and see. If we register our own we can see at what rate we're using it also. Also I believe with Mapbox you can lock them to a single domain now, which I don't think was possible when Maputnik was first created.
With regards to export maybe we should add an option to export as html?... Probably one for later though, I'm fine with just removing it for now.

If we register our own we can see at what rate we're using it also

:+1:

Also I believe with Mapbox you can lock them to a single domain now

Yes, it's possible with URL restrictions:
https://docs.mapbox.com/accounts/overview/tokens/#url-restrictions

With regards to export maybe we should add an option to export as html?

That's a good idea -> https://github.com/maputnik/editor/issues/705
I'm also fine with leaving the token input, now that we are planning to use it :-)


RamanShiftCorrectionFeature find_peaks FWHM

The 'width' parameter in RamanShiftCorrectionFeature's call to scipy.signal.find_peaks should probably be tied to Spectrometer.fwhm rather than a hardcoded constant for all spectrometers.  (The current implementation has apparently been found to work on all tested units, but it still seems like a design weakness.)

Internal user reported that RamanShiftCorrection was failing on some X-Series units during characterization...this could well be related. Bumping priority.

Can we get more info about how RamanShiftCorrection is failing?

And can we make this into a separate issue? You can link them by referencing the issue number. That way I can solve the above reimplement without shadowing a potentially still active bug.


Move/copy TODOs and investigations to Issues

I'd like to clean the document from "TODOs" and "to research", "to check" and move them here as Issues. We can also keep them in the document and link the threads here.

Imo they should still be present in the document, so that readers understand that the omission is a known problem.

TODOs rightfully have reputation once they putted in the document or code, nobody usually want to touch them. I think they are better to be issue.

TODOs rightfully have reputation once they putted in the document or code, nobody usually want to touch them. I think they are better to be issue.


White square notification icon in Android Nougat

Any reason why in Android Nougat the notification icon is a white square? Icon shows correctly in other versions of Android

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#images

@macdonst its not working in nougat.. but working in lower versions. Same issue happening for me. and i don't wana push image via server side.

@Barathwaja read the docs above and the links to the Android docs.

@macdonst those phonegap plugin are old.. You posted one snapshot of android nougat with a white one notification check you comments in one post. That's what I'm getting and again I'm telling that they are sending payload from server side .. for image too..
It's working for all OS other than nougat.

@macdonst
check the below image.
Red marked.

@Barathwaja please stop commenting on every issue. You are not going to get a different answer. Your problem is clearly explained in the docs, in Android docs and an host of other issues in this plugin. Your icon does not have transparent pixels so that is why it shows up as a white/grey box.


User/ryanbod/fix unittests

Summary of the Pull Request
This PR fixes the following Unit Tests

References

PR Checklist

[ ] Applies to #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Hotkeys_ShouldUpdateHotkeys was broken due to code accidentally being removed, that was re-added.
AppLastZoneMoveWindows_ShouldSetValue2True_WhenSuccessful was broken because the ColorPickerIsEnabledByDefault was setting a static callback that wasn't being removed and thus being fired on other tests.

Validation Steps Performed

Ran the above unit tests.

@laviusmotileng-ms .  You will need these changes to get Settings running in CI.

think you need to rebase due to changes from https://github.com/microsoft/PowerToys/pull/5166

@laviusmotileng-ms . You will need these changes to get Settings running in CI.

I'll pull the changes. Its not a lot.


Android tv problem

I'm submitting a ...

[ ] bug report
[ ] feature request
[*] support request

General infomration
Prerequisites

[ ] Are you running the latest version?

Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Context (Environment)
Installation

[*] I installed the plugin via zip from the Releases page
[ ] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[ ] Linux (ARM)
[*] Android

Additional informatin on the environment
[Descripe your environment a bit more detailed, are you using LibreElec f.e.]
Debug log
[Please include a link to your debug log (use something like http://pasted.co/dcc1cc4a) or similar, please do not paste]
Other information
[e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, etc.]
Android TV x86 os
Screenshots
[Please add a screenshot if that helps understanding your problem]
[You can erase any parts of this template not applicable to your Issue.]

http://pasted.co/dcc1cc4a log


0.16.0

@cs-victor-nascimento I think we are ready to merge this to master, yes?

Yes! Let's do it! :+1:

Done!


Docs links are broken

Hello,
all the documentation related links in the readme are broken:
https://github.com/dataui/crud/wiki#why
https://github.com/dataui/crud/wiki/Controllers#description
https://github.com/dataui/crud/wiki/Services#description
https://github.com/dataui/crud/wiki/Requests#description

+1

The documentation is now deployed at  https://github.com/gid-oss/dataui-nestjs-crud , links are updated accordingly.


Fix typo in dd helper method docblocks

WHY
Typos in DocBlocks reduce readability of the code and makes it harder to understand underlying methods actions and intents.
BEFORE - What was wrong? What was happening before this PR?
dd method in Backpack\CRUD\app\Library DocBlocks had a typo in them
AFTER - What is happening after this PR?
dd method in Backpack\CRUD\app\Library DocBlocks don't have a typo in them
HOW
How did you achieve that, in technical terms?
I used my great english skills and my keyboard backspace (™ pending) button to remove extra u from the word Duumps.
Is it a breaking change?
No
How can we test the before & after?
Use built in feature in every developer called eyes. Confirm that typo is truly gone.

Hello @Kasparsu
Thanks a lot, i will ask @pxpm to check and merge if everything is ok.
Thanks again.

Excellent PR, thank you @Kasparsu . So well written too, thank you for taking the time to explain how you achieved it. And of course, thank you for using your proprietary method 🙏 (hope we won't be infringing on your TM when it's accepted).


Target stats in Robust BatchNorm Layer

Hello, I was wondering what is the purpose of target_mean and target_var line 18 and 19 in the bn_layers.py file: https://github.com/BIT-DA/RoTTA/blob/67e34c900cdd355fc07e55edd4c577ea7b8ebcc9/core/utils/bn_layers.py#L18
It seems that these variables are not used. Same for current_mu and current_sigma.
Additionally could you give more details on how the behavior of the Robust Batch Norm differs from the one of the normal Batch Norm (which also update its stats with moving average).
Great work by the way!

Thank your for your explanation it is clear now! I guess I got confused with the unused variables.


Error with missing null check in $Shape field

Hello, I have a problem, or maybe a bug. When I try to define $Shape of any type, all fields will be maybe, and user have to check it before using. But example below is correct in case with undefined string field. Why flow is missing potential bug with calling method on undefined?
type Sometype = {
  stringField: string,
  numberField: number,
}

type ShapeOfSometype = $Shape<Sometype>

const emptyshape: ShapeOfSometype = {} // No errors!
const shapeWithString: ShapeOfSometype = { stringField: "string content" } // No errors!
const shapeWithNumber: ShapeOfSometype = { numberField: 42 } // No errors!

// Case with undefined string field "a",
// but flow doesn't says anything about null check!
shapeWithNumber.stringField.toLowerCase();

// Correct way to check it before using string methods
if (shapeWithNumber.stringField) {
  shapeWithNumber.stringField.toLowerCase();
}

Link to try flow with working (or not) example.
https://flow.org/try/#0C4TwDgpgBAyg9gWwqSUC8UDeAoKUDOwATgJYB2A5gGIkQA2AJgFwHHkUA0uUZArggCMIRGvWY9+QolwC+2bCmgwAFgENIAeQBm8JIvRQAJCvUQAPLuTgIAPnkBjOGUJQICMKHxrILE5p2IVqgYmDJQAPThUABycK5ERHBE+ACE2I7OwATeEADqJMDKMGyUvjnalvohrKSUoowsAESEtRRQGcAQZMCNUGGRMXHCiclpGS5epvmF0ZLCZaYVgVVYEoLC9eIALABMfRFRsfEjqfIDAMKq+NAA7gXKULxkDBBa5BAMNexQb2JQjapGlwBgJeFktHQ4DcoAw4BB8GQAORZfCqED4KCqMggQrfVQCOBgiR0Oj2ZQQewAazSk0g02Us3WRAAdC12JtmcA4AAZKHCS7XAAUAEoANxnKLnJJEClZG5oqBc9rkqlQApQIRaJLQXj4b5syhQPTKOAMfDYEhaKCC2l5e6MqSskrUWiMYVYbi2+kO4RO1ocrm8m78q4QEXiuRAA

It seems like Flow doesn't need a refinement check for  $Shape types even though the docs do say  $Shape marks every field optional.
However, the behavior you are looking for is possible with a little workaround. Link
type Sometype = {
  stringField: string,
  numberField: number,
}

type ShapeOfSometype = {...$Shape<Sometype> , [any]: empty  }

const emptyshape: ShapeOfSometype = {} // No errors!
const shapeWithString: ShapeOfSometype = { stringField: "string content" } // No errors!
const shapeWithNumber: ShapeOfSometype = { numberField: 42 } // No errors!

const n:number = emptyshape.numberField; // error
const s:string = emptyshape.stringField; // error
shapeWithNumber.stringField.toLowerCase(); // error

// Correct way to check it before using string methods
if (shapeWithNumber.stringField) {
  shapeWithNumber.stringField.toLowerCase();
}

This is a big issue for us, the behaviour linked in the docs was the assumed behaviour - it also makes the most sense - and was in reasonably widespread use across our codebase.
For simplicity here are two try flow links simply showing the issue and a workaround. A fix would be lovely.
Issue (try flow link):

/* @flow */

type A = {
	a: string;
};

function f(v: $Shape<A>): A {
	return v; // This *should* throw an error, but it doesn't
}

Workaround (try flow link):
/* @flow */

type FixedShape<T> = {
	...$Shape<T>,
  	[any]: typeof undefined,
}

type A = {
	a: string;
};

function f(v: FixedShape<A>): A {
    // $ExpectError
	return v; // This *should* throw an error, and it does
}

Note that we have chosen to use [any]: typeof undefined instead of [any]: empty because :

it is undefined
flow's concept of empty's behaviour in short circuiting of booleans does not match undefined

Errors if you use the safe replacement, $Partial: https://flow.org/try/#0C4TwDgpgBAyg9gWwqSUC8UDeAoKUDOwATgJYB2A5gGIkQA2AJgFwHHkUA0uUZArggCMIRGvWY9+QolwC+2bCmgwAFgENIAeQBm8JIvRQAJAAVVRYCVV0APLuTgIAPnkBjOGUJQICMKHxrIFhV1CG07fQxMGSgAehioADk4LyIiOCJ8AEJsNw9gAgCIAHUSYGUYNkogwrDEe1RI1lJKUUYWACJCZoooXOAIMmB2qGi4xOThNIzs3M9-EJKyhMlhapDavQcDTAlBYVbxABYAJhHY+KSUqaz5MYBhVXxoAHdS5SheMgYILXIIBia7CgvzEUHaqnaXDGAl4+S0dDgzygDDgEHwZAA5Pl8KoQPgoKoyCAykDVAI4LCJHQ6C5lBAXABrbLzSCLZTLPZEAB0XXYBy5wDgABlEcIHk8ABQASgA3Ld4nd0kR6flnrioILenTGVBSlAhFp0tBePggbzKFA9Mo4Ax8NgSFooBKWcU3hypDzKtRaIwpVhuC62e7hJ7uvzBSLnmLHhBpXK5EA
https://flow.org/en/docs/types/utilities/#toc-partial


fix: few things missing to handle disable_query

Fixing https://github.com/darkweak/souin/issues/327

Thank you @frederichoule for that PR! 🙏


Update guidance on validDomains

Added wildcard guidance and example

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
81
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
22
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit d99f954:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
81
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
22
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit b6959c8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
81
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
22
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit 02b5b06:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Hi @surbhigupta12 this is ready from our side. Thanks!

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
81
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
22
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit c1e3bb3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 15b73b5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
93
81
link
:white_check_mark:

msteams-platform/resources/schema/manifest-schema.md
94
22
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Learn Build status updates of commit a07ba16:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/deploy-and-publish/appsource/prepare/teams-store-validation-guidelines.md
:white_check_mark:Succeeded
View

msteams-platform/resources/schema/manifest-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Set VERSION back to master

The pre-commit hook easily leaks unwanted info into PRs :-)
Fixes: f414001bec ("Add nix-shell options in Readme")

This broke a few things since there's a hidden newline in the file, so now the name gets rendered as, eg:
nix-repl> inputs.mach-nix.packages.x86_64-linux.mach-nix.meta.name
"python3.7-mach-nix-master\n"

Oops, sorry about that. It seems @DavHau has already fixed it: 6112ea975fb678c242e145a68b088a17c5d88951.

Yep I just fixed it since I was working on the project anyways. After refactoring the version management (see https://github.com/DavHau/mach-nix/issues/277), this whole version file thing should not be an issue anymore.


Force "order:random" support on non-supporting boorus

Is your feature request related to a problem? Please describe
I've always wanted to sort my search results randomly in Gelbooru, just like in Danbooru. But it doesn't seem to support it
Describe the solution you'd like
So, is there a way to force this feature, through this program? I found another repository that seems to support this feature, but I'm not sure how it works https://github.com/AtlasTheBot/booru

Random support for all sites, using order:random on sites that support it and using a bit of magic on sites that don't

It would be great if this feature gets implemented here too

From what I see, https://github.com/AtlasTheBot/booru supports order:random on other sources by searching for 100 images, shuffling them, then returning the n first results.
Grabber could do the same (using the maxLimit information provided by some sources), but it wouldn't work on sources that don't support the limit setting (and therefore always return the same number of images). Or it could by loading multiple pages instead of fiddling with the number of images per page.


mime: FormatMediaType fails to detect non-ASCII bytes

What version of Go are you using (go version)?

go version go1.11.2 linux/amd64

Does this issue reproduce with the latest release?
yeah.
What operating system and processor architecture are you using (go env)?
irrelevant.
What did you do?
https://play.golang.org/p/mkEHhue4cKm
Tried FormatMediaType with different unicode characters in parameter values.
What did you expect to see?
One of:

FormatMediaType encoding parameters with any unicode characters as per RFC 2231 section 4.
FormatMediaType consistently accepting all unicode characters. That's probably not really compliant with current standards, but works with few email clients I tried. I like RFC 6532, but it doesn't have any mention of Content-Type or Content-Disposition though, so this option can probably be ignored.
FormatMediaType consistently rejecting all characters impossible to represent by US-ASCII.

What did you see instead?
Only characters covered by ISO-8859-1 are detected as unicode and cause encoding failure.
Characters whose rune values (actual unicode values, not UTF-8 encoded) aren't & 0x80 pass test and are included in output.
Additional info & reporter's opinion
I noticed this looking at source code of FormatMediaType and noticing that it contains if character&0x80 != 0 check, however it iterates thru string with range value (not range []byte(value) which would be correct).
I really don't like that it doesn't at least support RFC 2231 encoding, now I will either need to reimplement this function myself, or encode filename parameter using either mime.BEncoding or mime.QEncoding.
Adding proper check there and failing to encode could cause some issues if implementations relied on old broken behavior, I guess.

This issue seems like it is really two separate issues:

The current validation checks runes instead of bytes.
Ideally you'd like RFC 2231 encoding.

(1) is a bug-fix. (2) is a feature request; please file it separately.

CC @mpvl @bradfitz


extends... in jsconfig causes warnings in editors

Describe the bug
VSCode gives type warnings in vanilla js
Removing the following from jsconfig.json fixes this:
"extends": "./.svelte-kit/tsconfig.json"

This shouldn't happen if you are not using typescript.
Reproduction
Create a brand new SvelteKit project, skeleton, no typescript.
Add following to index.svelte ```html

{$session.lang}

VSCode will now mark `lang` with a warning/error saying `Property 'lang' lang does not exist on type 'Session'`

### Logs

_No response_

### System Info

```shell
System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 Intel(R) Core(TM) i7-9850H CPU @ 2.60GHz
    Memory: 13.28 GB / 31.71 GB
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.3.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (99.0.1150.46)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.33
    @sveltejs/kit: next => 1.0.0-next.302
    svelte: ^3.44.0 => 3.46.4

Severity
annoyance
Additional Information
No response

From the reproducible it sounds like the warning is expected. The config which the jsconfig extends from turns on type checks für JavaScript(Svelte) files. If you don't want that, you can change it to
{
  "extends": "./.svelte-kit/tsconfig.json",
  "compilerOptions": {
    "checkJs": false
  }
}

I might have explained it wrong, the warning is not expected since I do not expect to have type checks turned on if not using TypesScript.  Maybe this is just a matter of setting checkJS to false if the user chooses to not use TS in the template ?

Related #4427. Both seem to have stemmed from checkJs being true now in the generated tsconfig since it was never brought up earlier.

You both are right. The previous behavior was to only introduce a jsconfig without setting something like checkJs. We should most likely revert this part (although it's arguably helpful to have type checking by default for JS projects, too).

Cross-posting from #4495:

I almost wonder if we need to have two separate prompts when setting up a project, where if you don't opt in to TypeScript-the-language you can still opt in to typechecking:
? Use TypeScript? › Yes

? Use TypeScript? › No
? Add typechecking for JavaScript? › No / Yes

Personally I would choose No and Yes, but I don't know if I'm in a sufficiently small minority that that would be annoying for most non-TypeScript users.

We can close this now, as jsconfig.json is only generated if you choose 'Type-checked JavaScript' when scaffolding the project, and the extended config doesn't include checkJs (it's part of the default jsconfig.json if you opt in)


LiveIntent UserId module: Extend LiveIntent's User Id Module To Return sharedId

🏷 Type of documentation

[ ] new bid adapter
[ ] update bid adapter
[x] new feature
[ ] text edit only (wording, typos)
[ ] bugfix (code examples)
[ ] new examples

📋 Checklist

[x] Related pull requests in prebid.js or server are linked -> https://github.com/prebid/Prebid.js/pull/10978

We decided to close this pr for now since other topic has priority on our side.


Make a fully functional app from snapshot

Is your feature request related to a problem? Please describe.
This feature request is motivated by #62. When jest preview couldn't show an Image component from NextJS in Jest Preview. The reason is that Image Component requires javascript to be loaded.
So the question is. Can we make Jest Preview shows a fully functional app on browser?
Describe the solution you'd like
Instead of just a static HTML page, Jest Preview can serve a fully functional/ interactive SPA in the browser
Describe how should jest-preview implements this feature
Have no idea. This is a very hard problem. Need to understand how Jest process javascript, bundling (if they do?) (might be to see the Jest cached in cache folder?)
Describe alternatives you've considered

Can we modify next.config.js to

// next.config.js
module.exports = {
  reactStrictMode: true,
+  images: {
+   loader: "custom",
+ },

Reference: https://github.com/vercel/next.js/discussions/19065
Image

Idea:
Take a Vite project as an example: Can we start/ build the app to have some bundled .js files? Then inject it directly into the HTML snapshot?
This way, users can still see the HTML immediately after debug() triggered. They can integrate with the app since we add
    <script type="module" src="/src/index.tsx"></script>

We need to modify Preview Server in cli/server/previewServer.js to have Vite serve the index.html file in .cache, instead of connect
In another words:
We will have a Vite app, but not the fixed index.html, we have a dynamic HTML file, generated by preview.debug()
How about other frameworks?
I frankly don't know. But I can see the feasibility to make it work with Vite. Let's try this!!!!!!!

Vite supports creating a server of our own. I see the light at the end of the road!!
https://vitejs.dev/guide/api-javascript.html#createserver

Note that in https://github.com/nvh95/jest-preview/pull/122, we are trying to unify CSS Modules's class names to be the same in Windows and Linux in Jest Preview. However. It is not the default behavior when we process the CSS modules in development mode. We need to revisit #122 when implement #84

To achieve this, we need to

Hydrate the markup
Inject the script

One useful resource:
https://github.com/jsdom/jsdom#executing-scripts


New rule: Style/StringLiteralsInInterpolation

Style/StringLiteralsInInterpolation:
  EnforcedStyle: double_quotes

This means strings used within string interpolation will have double quotes instead of the default single quotes e.g. from:
result = "Tests #{success ? 'PASS' : 'FAIL'}"
to
result = "Tests #{success ? "PASS" : "FAIL"}"
I like this since it fits with string muscle memory

Just seen this is already in the styleguide :joy:


Build(deps-dev): Bump @babel/core from 7.20.12 to 7.21.0 (#4700)

Pull request opened by the merge tool on behalf of #4700

Merged in c5503db71729304a4d4392fee5bf25a2bdbdf23a


Add Labeller

Pull Request
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#16
#15  👈
#14
#13
#12
#4
#3
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite


The "Variables" page should describe the constant declarator

I could only find constant mentioned on one of the perl 5-to-6 pages, which isn't where the meat of the documentation lives. When it's described, it would be helpful to list the non-obvious differences between constant and my or our. For example, constant variables can't have a type constraint.

I would say this should go to the Variable page. In fact, constant is used in several examples.


User avatars broken

OSM made a change in avatar storage. It used to be local on OSM servers and now the URL retrieved from the user API call is relative and resolves to an AWS URL.
Some discussion / background / info here: https://github.com/openstreetmap/openstreetmap-website/pull/2296#issuecomment-511984574

The relative URL regression was fixed upstream. The problem may just go away.

I think this fixed itself..


crash report issue workflow

Crash report issue workflow
Description
Add an extra step to the fuzzer workflow to create an issue if a crash was found
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.
[ ] CHANGELOG has been updated.

Ignore the test job failure. It was fixed by #1315