WSL2 locks when operating on an NTFS file system

I have "stress-tested" WSL2 as described here: http://www.simxon.com/articles/20190614-wsl2-and-still-waiting.html
If the home directory of my calculation resides on the root file system, everything works - but as slowly as with WSL1. If the home directory resides on an NTFS file system, everything stops with no error messages appearing. The job just goes down to 0 % CPU.

Thanks for filing, this is likely an issue with our 9P server. @SvenGroot can you take a look?

Do you have a concise repro of the problem that I can attempt? I read through your articles but it's unclear exactly what commands I should run to get into the state you're in.

Hi Sven,
Sounds like a reasonable demand 😉. Do you have a way to receive data amounts of, say, 5 GB?
Regards, Kim
Fra: Sven Groot<EMAIL_ADDRESS>Sendt: 14. juni 2019 18:44
Til: microsoft/WSL<EMAIL_ADDRESS>Cc: kimrj<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Emne: Re: [microsoft/WSL] WSL2 locks when operating on an NTFS file system (#4134)
Do you have a concise repro of the problem that I can attempt? I read through your articles but it's unclear exactly what commands I should run to get into the state you're in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/microsoft/WSL/issues/4134?email_source=notifications&email_token=AEC66ANRZY6NNOU6C5TJO63P2PDFHA5CNFSM4HYGVDP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXLDRI#issuecomment-502182341 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEC66ANFI766U6V5KB7NH53P2PDFHANCNFSM4HYGVDPQ .  https://github.com/notifications/beacon/AEC66AOQSSERX4O4GZ7ZXWDP2PDFHA5CNFSM4HYGVDP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXLDRI.gif


Switch from networkx to retworkx

Retworkx is apparently faster and preferred by Qiskit: https://github.com/Qiskit/retworkx
The transition should be smooth!

Benchmark networkx decoding time vs retworkx decoding time.


user docs: Highlight currently selected user docs article.

Fixes #7053.
Note: Third commit (user docs: Apply highlights to documentation indexes) is optional and can be dropped if unnecessary. Without that commit, Index links in documentation sidebars will not be highlighted.

Merged all three, thanks @synicalsyntax!


[HUDI-37] Persist the HoodieIndex type in the hoodie.properties file

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
write index type configs into hoodie.properties during dataset creation time. it makes sense for the index to be not changeable after dataset creation
Brief change log
1、add indextype  param in HoodieTableMetaClient.java  initTableType method.
2、the table create client support add indextype
HoodieSparkSqlWriter.scala
BootstrapExecutor.java
DeltaSync.java
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@vinothchandar @n3nash  can you help to review? Thanks

@lw309637554 Change itself looks good to me. However, wondering if we should also

Add some check to throw an error if the index type is different in hoodie.properties than it's configured. some changes are compatible for e.g using GLOBAL_BLOOM and then switching to BLOOM/SIMPLE . but reverse is not.
I think it's high time we introduce a builder pattern init the table properties. those overloaded initXX are hard to read. If interested, we can do that in a separate PR.
Should we also add something to upgrade downgrade logic to persist this for existing datasets.

Thanks , i will think about

@lw309637554 Change itself looks good to me. However, wondering if we should also
Thanks @vinothchandar

Add some check to throw an error if the index type is different in hoodie.properties than it's configured. some changes are compatible for e.g using GLOBAL_BLOOM and then switching to BLOOM/SIMPLE . but reverse is not.
OK, i will add it.

I think it's high time we introduce a builder pattern init the table properties. those overloaded initXX are hard to read. If interested, we can do that in a separate PR.

OK, i interested.

Should we also add something to upgrade downgrade logic to persist this for existing datasets.
OK, i will try it.

@lw309637554 Change itself looks good to me. However, wondering if we should also

Add some check to throw an error if the index type is different in hoodie.properties than it's configured. some changes are compatible for e.g using GLOBAL_BLOOM and then switching to BLOOM/SIMPLE . but reverse is not.

add compatible check in AbstractHoodieClient.createMetaClient(). now check the case you mentioned, if have other case need to add ?

I think it's high time we introduce a builder pattern init the table properties. those overloaded initXX are hard to read. If interested, we can do that in a separate PR.

i will land it in https://issues.apache.org/jira/browse/HUDI-1315

Should we also add something to upgrade downgrade logic to persist this for existing datasets.

yeah have add in AbstractUpgradeDowngrade.createUpdatedFile()

Thanks , i will think about

@lw309637554 is this ready for re-review? please lmk

@lw309637554 is this ready for re-review? please lmk

yeah, i think it is ready.  Completeness of compatibility checks in AbstractHoodieClient.createMetaClient()  need your suggestion.

@vinothchandar please help to review again ,thanks.

@lw309637554 will do in the next 1-2 days. thanks for your patience

@lw309637554 will do in the next 1-2 days. thanks for your patience

thanks

@vinothchandar  can you help to review again?  Now get the index type from Hoodie.indexType()  and resolved your comments. Thanks

@lw309637554  Will do, this week!

Codecov Report

Merging #2136 (45e8eca) into master (6310a23) will decrease coverage by 43.30%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #2136       +/-   ##
=============================================
- Coverage     53.67%   10.37%   -43.31%
+ Complexity     2849       48     -2801
=============================================
  Files           359       50      -309
  Lines         16565     1783    -14782
  Branches       1782      211     -1571
=============================================
- Hits           8892      185     -8707
+ Misses         6916     1585     -5331
+ Partials        757       13      -744

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudihadoopmr
?
?

hudispark
?
?

huditimelineservice
?
?

hudiutilities
10.37% <0.00%> (-59.72%)
0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 We are close. Some issues around index creation at various places, needs to be taken care of though

@vinothchandar  yes , we are  so close. have resolved as your suggestion. can you help to review again. Thanks so much.

I thought of one more scenario. @lw309637554 Love to get your thoughts. Let's say the table was created with GLOBAL_BLOOM and then we allow writes with BLOOM (which can create duplication across partitions. then we also allow later writes with GLOBAL_BLOOM. The current checks bring a lot of value. Just pointing out that its not fully bulletproof. wdyt
other than this, if we can think about metaClient creation, PR is ready

@vinothchandar  thanks.

about the GLOBAL_BLOOM-> BLOOM -> GLOBAL_BLOOM scenario have two option
option 1: check GLOBAL_BLOOM incompatible with BLOOM strict. It will be concise
option 2: update the index in hoodie properties when the index changed. it will be too heavy
wdyt？
about metaclient creation have resolved

option 1: check GLOBAL_BLOOM incompatible with BLOOM strict. It will be concise

yes. but that takes the flexibilty away. I have seen users start with global bloom and then move to bloom, for perf reasons for eg.
actually. option 2, seems like the right thing to me. but I can see that it's heavy weight. Ideally, hoodie.properties is a hudi file group, that can take updates or is versioned as well. that's also a large change.
So, I am actually bit puzzled. :|  Let me think more.
if you have any other way out of this, please let me know as well .

option 1: check GLOBAL_BLOOM incompatible with BLOOM strict. It will be concise

yes. but that takes the flexibilty away. I have seen users start with global bloom and then move to bloom, for perf reasons for eg.
actually. option 2, seems like the right thing to me. but I can see that it's heavy weight. Ideally, hoodie.properties is a hudi file group, that can take updates or is versioned as well. that's also a large change.
So, I am actually bit puzzled. :| Let me think more.
if you have any other way out of this, please let me know as well .

@vinothchandar thanks , i think we can do as option2.
just like AbstractUpgradeDowngrade update the properties. but at index persist scenario, we can retain the old properties endwith the version of timestamp

yes. I am also wondering if we should log these to the metadata table in RFC-15. its a much better model in some sense, since it's fully self managed. Do you mind we hang on to this PR for now, until we land RFC-15 into master?
you can checkout the rfc-15 feature branch for now, if you are curious

yes. I am also wondering if we should log these to the metadata table in RFC-15. its a much better model in some sense, since it's fully self managed. Do you mind we hang on to this PR for now, until we land RFC-15 into master?
you can checkout the rfc-15 feature branch for now, if you are curious

thanks , i will checkout rfc-15, and try to  land this feature on rfc-15 branch, wdyt?

@vinothchandar : do you think we need to make this release-blocker?

@lw309637554 @vinothchandar : can you folks get this to completion, its been open for a while. Would be nice to have this in. We might also add more documentation in fax or somewhere as to what switches are compatible.

@lw309637554 @vinothchandar : can you folks get this to completion, its been open for a while. Would be nice to have this in. We might also add more documentation in fax or somewhere as to what switches are compatible.

sorry for my late. Now metatable is ready , i will implement this use meta table.

Closing this PR, in favor of new approach.


Fix Reshuffle implementation in Java SDK

This fixes the Reshuffle default implementation to preserve all metadata and be a true no-op, whereas before it did not preserve the pane info.
Regarding update compatibility, my understanding of runners that have long-lived streaming jobs and perform updates, as of this writing:

Flink: overrides Reshuffle
Samza: overrides Reshuffle
Dataflow v1: overrides Reshuffle
Dataflow v2: executes default implementation

As such, I don't think there's a need to use our new --update-compat-version flag.
I'll see about a one-off test to confirm, but we don't really have infrastructure for this testing, since it is the runners' physical plans that need to remain compatible, so the problem is beyond Beam's scope.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @robertwb

Failure was :runners:spark:3:test https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/28710/testReport/junit/org.apache.beam.runners.spark.translation.streaming/ResumeFromCheckpointStreamingTest/testWithResume/

run java precommit

The failure in the AWS2 tests was the same Spark resume from checkpoint test. It shouldn't even have been run in that suite. It looks like our invocations are a bit messed up (@damccorm FYI but I'm assuming this is just the same as it was in Jenkins).

run java precommit

I get the impression this somehow actually slows things down. Everything looks like a timeout. Or perhaps it just invalidates too much of the Gradle cache?

https://ge.apache.org/s/s6jldnngfhe32/tests/overview?outcome=FAILED#:runners:java-fn-execution:test-5-org.apache.beam.runners.fnexecution.control.remoteexecutiontest-11-testbundleprocessorthrowsexecutionexceptionwhenusercodethrows-44
I haven't figured out if this is flaky or environmental. I can't repro it locally.

run java precommit

@robertwb finally green - I don't think this accomplishes everything from the dev thread, just the SDK implementation. It does not impact runners that override or specially translate reshuffle.

run dataflow validatesrunner

run flink validatesrunner

run spark validatesrunner

run samza validatesrunner

OK, I added the capability to outputWindowedValue to the SDK (somewhat naively IDE-guided refactor) and used it in Create in order to write a basic test of what I think we want.

Gotta go through and poke a few more files

What's the status on this?

java precommit timed out - perhaps due to cache invalidation due to modifying core SDK

The outputWindowedValue change has been merged independently, shrinking this one. I'll check it over to make sure the residual change makes sense and is adequately complete.

Failure is the error on master fixed by #29798 (using \n instead of %n in a format string)

Noting that this was green but I went ahead and added the old expansion as an option using the new update compat flag. I am going to use the flag to test compatibility on Dataflow v1. We expect the override makes this change irrelevant, so we don't want to actually bug users. And on v2 we want the incompatibility.

Added internal Dataflow test that reloads the pipeline with changing the compatibility flag.

It seems the newly added test testReshufflePreservesMetadata not working for all runners:
beam_PostCommit_Java_PVR_Samza:  https://github.com/apache/beam/actions/runs/7399747764/job/20131866953
beam_PostCommit_Java_PVR_Spark3_Streaming: https://github.com/apache/beam/actions/runs/7399737943/job/20131836389
beam_PostCommit_Java_PVR_Spark3_Batch: https://github.com/apache/beam/runs/20340841429
beam_PostCommit_Java_ValidatesRunner_ULR also


Architect Security Agent

I think Sepes need to grow and find its own before we tackle this feature.

Obsolete task. Closing


Port 10711 which is exposed by one of the internal thrift server is not documented

In the "Default Ports of WSO2 Products" document[1], port 10711 which is exposed by one of the internal thrift servers is not documented.
[1]https://is.docs.wso2.com/en/latest/references/default-ports-of-wso2-products/#wso2-identity-server-ports

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Pending transformations

There should be a way to know when the user adjusts a transformation, before validating it (like selecting a crop area).
This would also help to create a "preview canvas", (ie. creating an other canvas where the crop or other transformation can be applied safely).

This should also resolve #66


[BUG] MIN(str, str) and MAX(str, str) functions fail

Describe the bug
Queries with functions MIN and MAX called with 2 arguments of type string fail and produce incorrect response
To Reproduce
curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query":  select MAX (\"Apple\",\"Banana\") from calcs limit 1;"}''
JSON does not allow non-finite numbers.
curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query":  select MIN (\"Apple\",\"Banana\") from calcs limit 1;"}''
JSON does not allow non-finite numbers.

Expected behavior
According to Tableau's definition:

With strings, MAX finds the value that is highest in the sort sequence defined by the database for that column. It returns Null if either argument is Null.
Example
MAX ("Apple","Banana") = "Banana"

The server log is not verbose:
[2021-11-11T05:00:09,303][WARN ][o.o.s.l.u.QueryDataAnonymizer] [6a3601a40d1d]  Caught an exception when anonymizing sensitive data
[2021-11-11T05:00:09,303][INFO ][o.o.s.l.p.RestSqlAction  ] [6a3601a40d1d]  [bab60cbb-d175-4c45-806f-b05fc08bd5fe] Incoming request /_plugins/_sql:  select MAX ("Apple","Banana") from calcs limit 1;
[2021-11-11T05:00:09,313][WARN ][stderr                   ] [6a3601a40d1d]  line 1:20 no viable alternative at input 'MAX ("Apple",'
[2021-11-11T05:00:09,316][WARN ][o.o.s.l.e.AsyncRestExecutor] [6a3601a40d1d]  [bab60cbb-d175-4c45-806f-b05fc08bd5fe] [MCB] async task got an unknown throwable: JSON does not allow non-finite numbers.
[2021-11-11T05:00:49,952][WARN ][o.o.s.l.u.QueryDataAnonymizer] [6a3601a40d1d]  Caught an exception when anonymizing sensitive data
[2021-11-11T05:00:49,952][INFO ][o.o.s.l.p.RestSqlAction  ] [6a3601a40d1d]  [116a891b-0786-4e32-b28b-18219b626782] Incoming request /_plugins/_sql:  select Min ("Apple","Banana") from calcs limit 1;
[2021-11-11T05:00:49,962][WARN ][stderr                   ] [6a3601a40d1d]  line 1:20 no viable alternative at input 'Min ("Apple",'
[2021-11-11T05:00:49,965][WARN ][o.o.s.l.e.AsyncRestExecutor] [6a3601a40d1d]  [116a891b-0786-4e32-b28b-18219b626782] [MCB] async task got an unknown throwable: JSON does not allow non-finite numbers

@Yury-Fridlyand Thanks for reporting this issue, will take a look and make it fixed I ECE we have resources.

This issue affects TDVT tests:

exprtests/standard\setup.agg.max.txt
exprtests/standard\setup.agg.min.txt

Reference: https://opensearch.org/docs/latest/opensearch/aggregations/
By default, OpenSearch doesn't perform aggregations on string values.  We would have to understand how to map a MAX([strings]) to a valid OpenSearch query (not necessarily an aggregation) before tackling this issue.


Facebook - Activity Exceptions: Value cannot be null. Parameter name: invalid activity-missing Conversation.Id

Version
4.2.2
Describe the bug
It seems a conversation arrived via the Facebook channel that was potentially missing key data.  I can't tell if the BotFramework got things wrong or something went wrong on the Facebook side
The first exception was dealing with a missing From details (which is understandable as I believe it started in the Web Chat Plugin that doesn't start new conversation with a user opt-in thus allowing access to the users profile data).
Value cannot be null. Parameter name: invalid activity-missing From.Id
Occured on this line:
var userState = await _accessors.AAUserStateAccessor.GetAsync(turnContext, () => new AAUserState(), cancellationToken);
The code I have written to handle exceptions contains this:
await _accessors.ConversationState.LoadAsync(turnContext, false, cancellationToken);
await _accessors.ConversationState.ClearStateAsync(turnContext, cancellationToken);
await _accessors.ConversationState.SaveChangesAsync(turnContext, true, cancellationToken);

So then the next exception in the stack was
Value cannot be null. Parameter name: invalid activity-missing Conversation.Id
This occured on this line:
await _accessors.ConversationState.LoadAsync(turnContext, false, cancellationToken);
Then once all of this had happened the final exception happened in my OnTurnError global handler:
Object reference not set to an instance of an object.
On this line:
await context.SendActivityAsync(Constants.ErrorMessage);
options.OnTurnError = async (context, exception) =>
{
    var ai = new TelemetryClient();
    ai.TrackException(exception);

    logger.LogError($"Exception caught : {exception}");
    await context.SendActivityAsync(Constants.ErrorMessage);

    await _conversationState.LoadAsync(context);
    await _conversationState.ClearStateAsync(context);
    await _conversationState.SaveChangesAsync(context);

    // https://github.com/Microsoft/BotBuilder/issues/5175
    //wait _conversationState.DeleteAsync(context);
};

Which is suggesting that context was in fact null!!
To Reproduce
Steps to reproduce the behavior:

Start a new conversaion via Web Chat Plugin

I can understand the From property being null due to the optin issues on Facebook when using the Web Chat Plugin but I'm not sure that it makes sense that the ConversationId is null.
I have now also updated this particular bot to v4.3.1 of the SDK.
[bug]

The fixes for the facebook messenger handover protocol are in production (including standby events).  This sample has been modified to demonstrate: https://github.com/EricDahlvang/FacebookEventsBotExpanded

The fixes for the facebook messenger handover protocol are in production (including standby events).  This sample has been modified to demonstrate: https://github.com/EricDahlvang/FacebookEventsBotExpanded

Using the Virtual Assistant template, i keep getting:
ArgumentNullException: invalid activity-missing Conversation.Id
at  Microsoft.Bot.Builder.ConversationState.GetStorageKey
Please check the issue opened here issue
This only happens on Facebook Channel.

@marcasmar94  Which Facebook Messenger events have you subscribed to?

Webhoook  is subscribed to:

messages
messaging_postbacks
messaging_optins
message_deliveries
standby
message_echoes
messaging_handovers

It seems message_echoes was causing these issues, As soon as i Unsubscribed from this event in Facebook settings, the exceptions were gone.
Thank you @EricDahlvang  for pointing me to the right direction!


Add ViewRenderer

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Controller example
class SiteController
{
    private ViewRenderer $viewRenderer;

    public function __construct(ViewRenderer $viewRenderer)
    {
        $this->viewRenderer = $viewRenderer->withControllerName('site');
    }

    public function index(): ResponseInterface
    {
        return $this->viewRenderer->render('index');
    }
}

or
class SiteController
{
    private ViewRenderer $viewRenderer;

    public function __construct(ViewRenderer $viewRenderer)
    {
        $this->viewRenderer = $viewRenderer->withController($this);
    }

    public function index(): ResponseInterface
    {
        return $this->viewRenderer->render('index');
    }
}

Container default custom config:
\App\ViewRenderer::class => [
        'withViewBasePath()' => ['@root/customviews'],
        'withLayout()' => ['@root/customviews/layout/main'],
    ]

I think it would be better to add $viewBasePath and $layout to __constructor params.


Handle websocket client handshake responses

WebSocket client handshake response data should also be re-fired after handshaking.
I want to handle websocket client handshake responses (i.e., response headers), but the responses will not be re-fired after handshaking.
So, if we want to handle them, we need to insert a channel handler that handles FullHttpResponse and verify response messages in the same way as what io.netty.handler.codec.http.websocketx.WebSocketServerHandshaker#finishHandshake does,  and then we can handle them safely (, right?).
If there is no problem, I will create a PR like:

Adds WebSocketClientProtocolHandler.HandShakeComplete class that has response information.
Fires it after handshaking completes (at WebSocketClientProtocolHandshakeHandler#channelRead)

by referring WebSocketServerProtocolHandshakeHandler.
(in short, client handshake completion events will be almost the same as server handshake completion events.)
Expected behavior
WebSocket client handshake response data should be available for handling them manually.
Actual behavior
They are not available, while WebSocket server handshake request data are available.
Minimal yet complete reproducer code (or URL to code)
Netty version
4.1.20
JVM version (e.g. java -version)
OS version (e.g. uname -a)

Please create a pr to show the idea as I not fully understand what the problem is or what is proposed

ping.

i am now busy, so i will make a PR soon


Add a hook to intercept ValidationError

Codecov Report

Merging #21 (7ab2d84) into main (81138cc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   92.57%   92.60%   +0.03%
==========================================
  Files          11       11
  Lines         687      690       +3
==========================================
+ Hits          636      639       +3
  Misses         51       51

Impacted Files
Coverage Δ

aiohttp_pydantic/injectors.py
95.23% <100.00%> (+0.05%)
:arrow_up:

aiohttp_pydantic/view.py
94.36% <100.00%> (+0.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81138cc...7ab2d84. Read the comment docs.


[feat] Add -x option to exclude values

Hey, this was useful for me so I opened this PR.
-x (eXclude values) enabled --dump-all and remove specified values.
I tested it locally and it works fine for me. Attaching a picture of the help.

Hi. Could you add conflicts_with to the clap definition. I guess -x and -a should not be used at the same time.
The build is red because of formatting so I guess cargo fmt should fix it.

Hi. Could you add conflicts_with to the clap definition. I guess -x and -a should not be used at the same time. The build is red because of formatting so I guess cargo fmt should fix it.

That was quick! Thanks, I added the conflicts with formatting.

@bomgar can I help release it to brew? my team will be happy to have it 😃
I saw it here:
https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/fblog.rb
is it just a matter of updating the release url and the first sha256? or is there more to it?

Oh i didn't know it was added to core. There is a formula in this repo here: https://github.com/brocode/fblog/tree/master/Formula
I don't own a Mac so I can't help you with that. My guess is that the url and checksums should be enough. As far as I know you can execute formulas locally to test everything.
If it is part of central I should probably delete the formula here 🤔

seems like it is, as brew install fblog returns fblog 3.1.2, so it's probably save to delete the formula here.
I'll see if I can bump the version myself.
Thanks again for you help :)

Tested locally and opened a PR for core.
https://github.com/Homebrew/homebrew-core/pull/94722


Dependency to Microsoft.Tpl.Dataflow does not allow package manager console to update or reinstall all packages in a solution in one shot.

I believe the dependency to Microsoft.Tpl.Dataflow should be removed, and most probably replaced with System.Threading.Tasks.Dataflow. The mentioned dependency causes package manager console to fail when trying to update or reinstall all Nuget packages in a solution (e.g. using update-package -reinstall), forcing the user to reinstall packages one-by-one, which can be tedious in a very large solution (e.g. with 100+ projects, which is my case). Found the following issue which was opened 1 year ago, but the same problem still persists today: https://github.com/dotnet/corefx/issues/24547 .  Thank you in advance.

Hi, I am seeing the dependency in the latest version of "Microsoft.AspNet.WebHooks.Custom" which is currently on 1.2.1.  I am attaching a screenshot as well directly from VS.  I hope I have posted it to the right place here!  There was no feedback link (in VS), so I clicked on the abuse link (out of frustration I have to admit, it gave me a really hard time and I lost many hours because of it), which right on top said "please do not use this form to report a bug in a package you are using", with a link to contact the owners of the package instead.  I did that and someone from your team responded and suggested I open an issue here on Github.

@nnookbakhsh ah, you're talking about a WebHooks package for .NET Framework. This is an issue for the aspnet/AspNetWebHooks repo. I'll move it there…

This issue was moved to aspnet/AspNetWebHooks#30


A new release

@lindell could you release a new version with latest changes (ITF refactoring) and upgrade *.min.js files/links in README?

Released v3.11.0


MJPEG support for DRM

Note that this is slower because we convert MJPEG
to RGBA.
Signed-off-by: Chris Richardson<EMAIL_ADDRESS>

I was wondering if there is a way to switch from X to the console programmatically, so that DRM could be tested too?
At the moment I just use ctrl-alt-f1 / f7 to switch between the two.

I was wondering if there is a way to switch from X to the console programmatically, so that DRM could be tested too?
At the moment I just use ctrl-alt-f1 / f7 to switch between the two.

Apparently (just found this out) you can use sudo chvt 1, and then sudo chvt 7 to return. So it would indeed by good to run the DRM tests automatically using this...

I see those DRM tests are not happy... the test machine is headless, maybe that's what makes the difference?

Yeah it could well be because it's headless, as I do check the return code from the call.
Just added a sleep statement in case that makes a difference.

Actually just pulled the HDMI cable from my display, and also get 'RuntimeError: Failed to reserve DRM plane'

I think you can run a "fake" display which might do what we want. Try putting video=HDMI-A-1:1920x1080@60D on the end of your /boot/cmdline.txt file and reboot. Does that work at all?

Yes, that seemed to work.
The only difference I noticed was some printed messages after running examples/overlay_drm.py that said
commit failed
commit failed

Yes, I think so. Do all the DRM examples produce messages like that? And is it just a few, or is it an "every frame" kind of thing?

And you'll need a micro-to-regular HDMI adaptor for that dummy plug!! :)

Ah, I worked out why I got that message, it prints it when headless, if you're on the Xserver VT.
So if you do 'sudo chvt 1' and then run the overlay_drm.py demo, it works fine :)
Don't really need the hdmi dongles now heh.
Would you be able to enable that command line parameter on the test server?

Right, I've done that and rebooted it. Give it a couple of minutes and cross your fingers!

Thanks for doing that, looks like it ran the DRM tests :)
Test list file X: /home/pi/_work/picamera2/picamera2/tests/test_list.txt
Test list file DRM: /home/pi/_work/picamera2/picamera2/tests/test_list_drm.txt
Running 55 tests

Running /home/pi/_work/picamera2/picamera2/examples/overlay_drm.py... 	PASSED
Running /home/pi/_work/picamera2/picamera2/examples/preview_drm.py... 	PASSED
Running /home/pi/_work/picamera2/picamera2/examples/capture_circular_nooutput.py... 	PASSED
...

Yes. looking good. Do you want to merge?

Yeah, if you could merge that'd be cool.


sys/freebsd: fix sockaddr structures

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

Codecov Report

Merging #1248 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1248   +/-   ##
=======================================
  Coverage   67.56%   67.56%
=======================================
  Files         120      120
  Lines       20984    20984
=======================================
  Hits        14178    14178
  Misses       6131     6131
  Partials      675      675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34bf944...21aebe7. Read the comment docs.

It looks like these commits should be squashed.

Yes, I agree.

Looks good to me. Could you squash your changes per the contribution guidelines?

Looks good to me. Could you squash your changes per the contribution guidelines?

Done in the latest commit.


[wip] [5 of #107] add dynamic options

This encapsulates the state that does change, as highlighted in #124, in a single, relatively lenient object, and changes most function signatures to accept inputs, options or both.

continues #107

@bollwyvl: I haven't tested this one out. :crossed_fingers:

On the next PR

refactor the installer provider

One of the first "irregularities" is that runInstaller is allowed to calculate its own outputPath, which requires access to mutable state. If we split up that behavior, we can get a lot of reuse, where it will be more straightforward to add additional "well-known" installer providers.
The idea here is to break up the installer provisioning step even more. There should be a significant net negative line count in setup.ts, and encapsulate the logic more succinctly along with its effects.
This is where we want to leave enough breathing room to handle micromamba #75 without actually building it right now.

LGTM @bollwyvl gave it a quick look :)

Yeah, had another look I don't see anything else glaring at this step.


Bug: cannot run PHPUnit testing in CI 4.5.1 appstarter

PHP Version
8.1
CodeIgniter4 Version
4.5.1
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
cli-server (PHP built-in webserver)
Database
n/a
What happened?
Cannot run phpunit.
Steps to Reproduce
$ composer create-project codeigniter4/appstarter ci451
Creating a "codeigniter4/appstarter" project at "./ci451"
Installing codeigniter4/appstarter (v4.5.1)
  - Installing codeigniter4/appstarter (v4.5.1): Extracting archive
Created project in /home/kenji/tmp/ci451
Loading composer repositories with package information
Updating dependencies
Lock file operations: 33 installs, 0 updates, 0 removals
  - Locking codeigniter4/framework (v4.5.1)
  - Locking fakerphp/faker (v1.23.1)
  - Locking laminas/laminas-escaper (2.13.0)
  - Locking mikey179/vfsstream (v1.6.11)
  - Locking myclabs/deep-copy (1.11.1)
  - Locking nikic/php-parser (v5.0.2)
  - Locking phar-io/manifest (2.0.4)
  - Locking phar-io/version (3.2.1)
  - Locking phpunit/php-code-coverage (10.1.14)
  - Locking phpunit/php-file-iterator (4.1.0)
  - Locking phpunit/php-invoker (4.0.0)
  - Locking phpunit/php-text-template (3.0.1)
  - Locking phpunit/php-timer (6.0.0)
  - Locking phpunit/phpunit (10.5.20)
  - Locking psr/container (2.0.2)
  - Locking psr/log (3.0.0)
  - Locking sebastian/cli-parser (2.0.1)
  - Locking sebastian/code-unit (2.0.0)
  - Locking sebastian/code-unit-reverse-lookup (3.0.0)
  - Locking sebastian/comparator (5.0.1)
  - Locking sebastian/complexity (3.2.0)
  - Locking sebastian/diff (5.1.1)
  - Locking sebastian/environment (6.1.0)
  - Locking sebastian/exporter (5.1.2)
  - Locking sebastian/global-state (6.0.2)
  - Locking sebastian/lines-of-code (2.0.2)
  - Locking sebastian/object-enumerator (5.0.0)
  - Locking sebastian/object-reflector (3.0.0)
  - Locking sebastian/recursion-context (5.0.0)
  - Locking sebastian/type (4.0.0)
  - Locking sebastian/version (4.0.1)
  - Locking symfony/deprecation-contracts (v3.5.0)
  - Locking theseer/tokenizer (1.2.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 33 installs, 0 updates, 0 removals
  - Installing psr/log (3.0.0): Extracting archive
  - Installing laminas/laminas-escaper (2.13.0): Extracting archive
  - Installing codeigniter4/framework (v4.5.1): Extracting archive
  - Installing symfony/deprecation-contracts (v3.5.0): Extracting archive
  - Installing psr/container (2.0.2): Extracting archive
  - Installing fakerphp/faker (v1.23.1): Extracting archive
  - Installing mikey179/vfsstream (v1.6.11): Extracting archive
  - Installing sebastian/version (4.0.1): Extracting archive
  - Installing sebastian/type (4.0.0): Extracting archive
  - Installing sebastian/recursion-context (5.0.0): Extracting archive
  - Installing sebastian/object-reflector (3.0.0): Extracting archive
  - Installing sebastian/object-enumerator (5.0.0): Extracting archive
  - Installing sebastian/global-state (6.0.2): Extracting archive
  - Installing sebastian/exporter (5.1.2): Extracting archive
  - Installing sebastian/environment (6.1.0): Extracting archive
  - Installing sebastian/diff (5.1.1): Extracting archive
  - Installing sebastian/comparator (5.0.1): Extracting archive
  - Installing sebastian/code-unit (2.0.0): Extracting archive
  - Installing sebastian/cli-parser (2.0.1): Extracting archive
  - Installing phpunit/php-timer (6.0.0): Extracting archive
  - Installing phpunit/php-text-template (3.0.1): Extracting archive
  - Installing phpunit/php-invoker (4.0.0): Extracting archive
  - Installing phpunit/php-file-iterator (4.1.0): Extracting archive
  - Installing theseer/tokenizer (1.2.3): Extracting archive
  - Installing nikic/php-parser (v5.0.2): Extracting archive
  - Installing sebastian/lines-of-code (2.0.2): Extracting archive
  - Installing sebastian/complexity (3.2.0): Extracting archive
  - Installing sebastian/code-unit-reverse-lookup (3.0.0): Extracting archive
  - Installing phpunit/php-code-coverage (10.1.14): Extracting archive
  - Installing phar-io/version (3.2.1): Extracting archive
  - Installing phar-io/manifest (2.0.4): Extracting archive
  - Installing myclabs/deep-copy (1.11.1): Extracting archive
  - Installing phpunit/phpunit (10.5.20): Extracting archive
11 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating optimized autoload files
26 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.

$ cd ci451/
$ composer test
> phpunit
PHPUnit 10.5.20 by Sebastian Bergmann and contributors.

Cannot open bootstrap script "/home/kenji/tmp/ci451/system/Test/bootstrap.php"
Script phpunit handling the test event returned with error code 2

Expected Output
No error.
Anything else?
No response

I do not know why this defect exists, as it should have been verified to pass testing at the time of release.

The XML seems to be copied from the codeigniter 4 dev branch. It works because there is a folder ./system

@neznaika0 I remember now. There was the bug, but the fix is not yet released.
The file is copied from
https://github.com/codeigniter4/CodeIgniter4/blob/master/admin/starter/phpunit.xml.dist#L5

Okay, I didn't check the history either.
Directed by Robert B. Weide

Closed by v4.5.2.


JWT Authentication: Getting 404 'route_not_found' When Using WebSockets

Description:
I'm using Envoy Gateway and adding an extra authentication layer based on JWT authentication with GitHub OIDC. It works perfectly with HTTP and gRPC traffic, but it doesn't seem to work when using WebSockets.
HTTP Route:
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: test-app
  namespace: gateway
spec:
  hostnames:
  - test-app.[redacted]
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: gw-public
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: test-app
      namespace: test-app
      port: 80
      weight: 1
    matches:
    - headers:
      - name: x-claim-github-repository
        type: Exact
        value: myorg/myrepo <- [redacted]
      path:
        type: PathPrefix
        value: /
status:
  parents:
  - conditions:
    - lastTransitionTime: "2024-12-26T14:25:29Z"
      message: Route is accepted
      observedGeneration: 28
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-12-26T14:25:29Z"
      message: Resolved all the Object references for the Route
      observedGeneration: 28
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs

Security policy:
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: SecurityPolicy
metadata:
  name: test-app-github-oidc
  namespace: gateway
spec:
  jwt:
    providers:
    - audiences:
      - gh-proxy
      claimToHeaders:
      - claim: repository
        header: x-claim-github-repository
      extractFrom:
        headers:
        - name: x-github-jwt
          valuePrefix: 'Bearer '
      issuer: https://token.actions.githubusercontent.com
      name: github-oidc
      recomputeRoute: true
      remoteJWKS:
        uri: https://token.actions.githubusercontent.com/.well-known/jwks
  targetRefs:
  - group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: test-app

When testing this from GH Action:
  # Send WebSocket request with websocat
  websocat -v -v \
    -H="x-github-jwt: ***" \
    wss://test-app.[redacted]/hello-ws
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
[DEBUG websocat::lints] Substituting StdioClass with AsyncStdioClass at the left
[INFO  websocat::lints] Auto-inserting the line mode
[DEBUG websocat] Done third phase of interpreting options.
[DEBUG websocat] Done fourth phase of interpreting options.
[DEBUG websocat] Preparation done. Now actually starting.
[DEBUG websocat::sessionserve] Serving Line2Message(AsyncStdio) to Message2Line(WsClient("wss://test-app.[redacted]/hello-ws")) with Options { websocket_text_mode: true, websocket_protocol: None, websocket_reply_protocol: None, udp_oneshot_mode: false, udp_broadcast: false, udp_multicast_loop: false, udp_ttl: None, udp_join_multicast_addr: [], udp_join_multicast_iface_v4: [], udp_join_multicast_iface_v6: [], udp_reuseaddr: false, unidirectional: false, unidirectional_reverse: false, max_messages: None, max_messages_rev: None, exit_on_eof: false, oneshot: false, unlink_unix_socket: false, unix_socket_accept_from_fd: false, exec_args: [], ws_c_uri: "ws://<IP_ADDRESS>/", linemode_strip_newlines: false, linemode_strict: false, origin: None, custom_headers: [("x-github-jwt", [66, 101, 97, 114, 101, 114, 32, 101, 121, 74, 48, 101, 88, 65, 105, 79, 105, 74, 75, 86, 49, 81, 105, 76, 67, 74, 104, 98, 71, 99, 105, 79, 105, 74, 83, 85, 122, 73, 49, 78, 105, 73, 115, 73, 110, 103, 49, 100
[DEBUG websocat::stdio_peer] get_stdio_peer (async)
[DEBUG websocat::stdio_peer] Setting stdin to nonblocking mode
[DEBUG websocat::stdio_peer] Setting stdout to nonblocking mode
[DEBUG websocat::stdio_peer] Installing signal handler
[DEBUG websocat::sessionserve] Underlying connection established
[INFO  websocat::ws_client_peer] get_ws_client_peer
[DEBUG websocat::net_peer] Setting up a race between multiple TCP client sockets. Who connects the first?
[INFO  websocat::net_peer] Connected to TCP [redacted]:443
[DEBUG websocat::stdio_peer] restore_blocking_status
[DEBUG websocat::stdio_peer] Restoring blocking status for stdin
[DEBUG websocat::stdio_peer] Restoring blocking status for stdout
websocat: WebSocketError: WebSocketError: Received unexpected status code (404 Not Found)
[DEBUG websocat::stdio_peer] restore_blocking_status
[DEBUG websocat::stdio_peer] Restoring blocking status for stdin
[DEBUG websocat::stdio_peer] Restoring blocking status for stdout
websocat: error running
Error: Process completed with exit code 1.

I'm seeing the following in Envoy logs:
2024-12-26 14:35:33.571][66][debug][upstream] [source/common/upstream/cluster_manager_impl.cc:1826] removing hosts for TLS cluster token_actions_githubusercontent_com_443 removed 1
[2024-12-26 14:35:33.989][45][debug][conn_handler] [source/common/listener_manager/active_tcp_listener.cc:160] [Tags: "ConnectionId":"4583"] new connection from <IP_ADDRESS>:65472
[2024-12-26 14:35:34.009][45][debug][http] [source/common/http/conn_manager_impl.cc:385] [Tags: "ConnectionId":"4583"] new stream
[2024-12-26 14:35:34.009][45][debug][http] [source/common/http/conn_manager_impl.cc:1135] [Tags: "ConnectionId":"4583","StreamId":"3806770929837629847"] request headers complete (end_stream=false):
':authority', 'test-app.[redacted]'
':path', '/hello-ws'
':method', 'GET'
'x-github-jwt', 'Bearer [redacted]'
'connection', 'Upgrade'
'upgrade', 'websocket'
'sec-websocket-version', '13'
'sec-websocket-key', 'PlEnaALt04CrzzILn7qtHQ=='

[2024-12-26 14:35:34.009][45][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"4583"] current connecting state: false
[2024-12-26 14:35:34.009][45][debug][router] [source/common/router/config_impl.cc:1974] route was resolved but final route list did not match incoming request
[2024-12-26 14:35:34.009][45][debug][jwt] [source/extensions/filters/http/jwt_authn/filter.cc:168] Called Filter : setDecoderFilterCallbacks
[2024-12-26 14:35:34.009][45][debug][jwt] [source/extensions/filters/http/jwt_authn/filter.cc:53] Called Filter : decodeHeaders
[2024-12-26 14:35:34.009][45][debug][jwt] [source/extensions/filters/http/jwt_authn/filter.cc:114] Jwt authentication completed with: OK
[2024-12-26 14:35:34.009][45][debug][router] [source/common/router/router.cc:457] [Tags: "ConnectionId":"4583","StreamId":"3806770929837629847"] no route match for URL '/hello-ws'
[2024-12-26 14:35:34.009][45][debug][http] [source/common/http/filter_manager.cc:1025] [Tags: "ConnectionId":"4583","StreamId":"3806770929837629847"] Preparing local reply with details route_not_found
[2024-12-26 14:35:34.009][45][debug][http] [source/common/http/filter_manager.cc:1067] [Tags: "ConnectionId":"4583","StreamId":"3806770929837629847"] Executing sending local reply.
[2024-12-26 14:35:34.009][45][debug][http] [source/common/http/conn_manager_impl.cc:1825] [Tags: "ConnectionId":"4583","StreamId":"3806770929837629847"] encoding headers via codec (end_stream=true):
':status', '404'
'date', 'Thu, 26 Dec 2024 14:35:33 GMT'
'connection', 'close'

What I don't understand is why it doesn't match the route, because during the handshake process, it uses the HTTP protocol, and we see in the logs that the JWT token is being sent. My question is: is JWT authentication supposed to work with WebSockets?
I'm assuming that there is no reason why JWT can't be validated. After the upgrade, it should receive a 101 status, the connection becomes a WebSocket, and everything should work because the connection will stay open. Anyway, even if this doesn't work, I'd like to understand why the JWT isn't being matched.
If I delete the security policy and header matching from the HTTPRoute, I can access the hello-ws endpoint without issues.

@njegosrailic Can you access the hello-ws endpoint if removing the x-claim-github-repository matching condition and the recomputeRoute: true in the SecurityPolicy ?

@zhaohuabing I can access the endpoint if I remove the header matching in the HTTPRoute. It also works with recomputeRoute: true set in the SecurityPolicy.


[Feature]Location spoofing

Localization for some games depends on the VPN country under which we access the site. See if you can make a substitution for the desired country without using a VPN

Duplicate #79


Implement UMD build scripts

This allows redux-router to be run in the browser and hosted on CDNs. Redux-router is available in the browser as window.ReduxRouter.

Why is envify necessary?

It's useful if there's code here that relies on process.env at all, but looking through it, it's not used at all here. Should I take it out or leave it in in case it does get used in the future?

Yeah, please remove it :-) We can always re-add it, if it´s ever necessary.

Removed.

Hey, it would be nice if you could modify the package.json accordingly. So the UMD build can be served by npmcdn.com.
Take a look at the bottom section "Suggested Workflow" here: https://npmcdn.com/#/

@Morfent Are you still going to fix this?

I will when I get around to it. I have other priorities i need to deal with first before i can get back to this.

Okay, thanks for the feedback. I will leave this open then.

That should do it, I believe.

LGTM, @mjrussell could you give this a quick look, too.

Hm Im not as familiar with UMD. Do you need to add lib to the files now that its defined to include dist?

I'm not entirely sure, since I've never published an npm package before. Here's the output from attempting to run npm publish, if it helps:
morfent@kennel:~/Documents/redux-router> npm publish

><EMAIL_ADDRESS>prepublish /home/morfent/Documents/redux-router
> npm run clean && mkdir dist && npm run build

/
><EMAIL_ADDRESS>clean /home/morfent/Documents/redux-router
> rimraf lib && rimraf dist && rimraf server.js

/
><EMAIL_ADDRESS>build /home/morfent/Documents/redux-router
> npm run build:commonjs && npm run build:umd && npm run build:umd:min

/
><EMAIL_ADDRESS>build:commonjs /home/morfent/Documents/redux-router
> babel src --out-dir lib && cp lib/serverModule.js server.js

src/ReduxRouter.js -> lib/ReduxRouter.js
src/__tests__/ReduxRouter-test.js -> lib/__tests__/ReduxRouter-test.js
src/__tests__/init.js -> lib/__tests__/init.js
src/__tests__/reduxReactRouter-test.js -> lib/__tests__/reduxReactRouter-test.js
src/actionCreators.js -> lib/actionCreators.js
src/client.js -> lib/client.js
src/constants.js -> lib/constants.js
src/historyMiddleware.js -> lib/historyMiddleware.js
src/index.js -> lib/index.js
src/isActive.js -> lib/isActive.js
src/matchMiddleware.js -> lib/matchMiddleware.js
src/reduxReactRouter.js -> lib/reduxReactRouter.js
src/replaceRoutesMiddleware.js -> lib/replaceRoutesMiddleware.js
src/routeReplacement.js -> lib/routeReplacement.js
src/routerStateEquals.js -> lib/routerStateEquals.js
src/routerStateReducer.js -> lib/routerStateReducer.js
src/server.js -> lib/server.js
src/serverModule.js -> lib/serverModule.js
src/useDefaults.js -> lib/useDefaults.js
|
><EMAIL_ADDRESS>build:umd /home/morfent/Documents/redux-router
> NODE_ENV=development browserify -s ReduxRouter --detect-globals lib/index.js -o dist/redux-router.js

|
><EMAIL_ADDRESS>build:umd:min /home/morfent/Documents/redux-router
> NODE_ENV=production browserify -s ReduxRouter --detect-globals lib/index.js | uglifyjs -c warnings=false -m > dist/redux-router.min.js

npm ERR! Linux 4.1.27-24-default
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "publish"
npm ERR! node v4.4.5
npm ERR! npm  v2.15.5
npm ERR! code ENEEDAUTH

npm ERR! need auth auth required for publishing
npm ERR! need auth You need to authorize this machine using `npm adduser`

npm ERR! Please include the following file with any support request:
npm ERR!     /home/morfent/Documents/redux-router/npm-debug.log

Looking at react-router-redux's setup seems to indicate we should - https://github.com/reactjs/react-router-redux/blob/master/package.json

I added the list of files that react-redux-router uses in package.json.

Looks good to me

Nice!

I published a version with your update to npm.


feat: Make Stylize's .bg(color) generic

This PR makes .bg(color) generic accepting anything that can be converted into Color; similar to the .fg(color) method on the same trait

Does this need any updated tests?

There weren't any tests for this. I think there's no implementations for From objects into Color in Ratatui. There's crossterm::style::Color -> ratatui::style::Color but that test will only work for the crossterm backend.

As every impl needs to change this is a breaking change

This is strictly breaking but in practice I don't think it'll break code because Stylize is fairly new and people may have not had the chance or reason to implement it. In the past we've merged similar "strictly breaking but not breaking in practice" changes in patch releases. Thoughts?
Open to suggestions on making this protected.

Open to suggestions on making this protected.

No opinions - I know that I hate seeing traits in other libs that I'd like to be able to implement even if they later change them in the lib, but can't because they're not exposed, so I'd lean towards just keeping it as is, and dealing with breaking changes in the usual manners (communicating when we can, being mindful of the changes, etc.)

Also - 0.26.3 was slated to be a bugfix / no breaking changes release tomorrow, to make it easy for broken apps to just be fixed without any changes required. (version spec 0.26.2 will actually use 0.26.3 automatically when resolving, but it won't use 0.27.0)

Should I revert this PR until 0.27.0?


SSA Support Features

Context
With the shift from First Responsders to Shared Services Advisors, we need to have processes in place that are sustainable for .NET Eng Services to manage and straightforward for our customers to use (for self-service processes). This epic will address any processes, services, et cetera, that are required to achieve that goal.
Business goals

[ ] New processes/features/services are sustainable for .NET Eng Services devs and product devs
[ ] Documentation is provided for product devs to be able to use new processes/features/services

As a team, we have decided what is supported within SSA and what is part of our Ops team. Details can be found at https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng Services Wiki/1096/SSA-vs-Ops.md


Atama reload config not working

When I add a new keybind and trigger the "reload ~/.atamanrc.config File" action, nothing changes. Restarting the IDE works for changing keybinds (although it’s slow).

I saw recently that if the file is open in the editor, the reload does not work. But if the file is closed, it works as expected

@sonofhypnos  Do you save your file after editing it? Intellij is keeping file edits in temporary buffer before saving. Try saving the file by using File -> Save All... before launching config reload command

I will close this issue because there are no steps to reproduce. Please reopen it If you can provide steps to reproduce


historical nightlies get 404

In trying to install a history nightly, like:
> rustup update nightly-2016-02-11

I am getting a 404.  I looked in the directory to confirm that the build failed that day, but it appears to have succeeded:
https://static.rust-lang.org/dist/2016-02-11/
But the particular file rustup is looking for isn't there:
error: could not download file from 'https://static.rust-lang.org/dist/2016-02-11/channel-rust-nightly.toml.sha256' to '/Users/jturner/.multirust/tmp/746z4ulh9xnbk95b_file
info: caused by: http request returned an unsuccessful status code: 404

I had a quick chat with @alexcrichton, and mentioned that this may be a possible bug where rustup doesn't support the earlier build artifacts, yet.

There is the same issue when trying to install a specific version of rust for example:
$ rustup install 1.3.0
info: syncing channel updates for '1.3.0-x86_64-unknown-linux-gnu'
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-1.3.0.toml.sha256' to '/home/loic/.multirust/tmp/jkly3tjqktf4sf6i_file

Yes, same problem as https://github.com/rust-lang-nursery/rustup.rs/issues/502. The fallback from v2 to v1 manifests is broken.


test: behaviors-message_on_lock_failure (2024-02-26 22:11:50.886267+00:00)

automatic test cleanup


DPL-609 [BUG] In Limber, plates in the "LTHR-384 Lib PCR 1" and "LTHR-384 Lib PCR 1" columns of the "Heron -384 V2" Kanban board display date stamps of a few days BEFORE the users have created them.

Describe the bug
[BUG] Plates in the "LTHR-384 Lib PCR 1" and "LTHR-384 Lib PCR 2" columns of the "Heron -384 V2" Kanban board display date stamps of a few days BEFORE the users have created them.
To Reproduce
Need to confirm if this applies to all plates in these columns - it seems to.
Expected behaviour
The date shown is the "creation" date of the plates in the database. However this does not tie in with what the user is expecting.
Is there something about the previous step that creates these plates earlier?
This may or may not be easily fixable. First task is to work out why this is happening.
Screenshots
See screenshot

Highlighted plates were created on the 18/12/2022.
Additional context
Ana G has reported this.

After discussing with Sara we would like to understand:

What do the states pending, passed, and created mean on the Kanban board ?

The cards only display one date, which if any state does this date relate to?

The lab would really like the displayed date on the card to relate to the start of the operation represented by the column on the plate. Do we have a way to know this? Does it map to one of the above states?

Once we've clarified what data is available - let's go through possible options with Sara.

Possibly this is the timestamp of when the tag plate was created. The tag plate physically becomes the LTHR PCR plate, as samples are transferred into the tag from the parent plate at this step rather than a completely 'new' child plate being made. The 'child' plate (the tag plate + samples from parent) is given a new plate purpose and label. A quirk of how tagging is done.

Adam did notice and notify us that there were some cards in training that looked like they shared a heritage with cards in the right-most column.  The preference would be that those only appear once, but this also sounds like another requirement that may have low impact so we're going to go ahead with a production release and monitor for issues like that that could be raised as new tickets.
The other thing noted was that updated at dates were not always completely up to date in the training environment, but this is to be expected since training is not looking at the live production data.


Fix navigation for small screens

@zjedi sorry for the inconvenience, this fixes the problem you mentioned.

(the flex was only needed for the small screens, on large screens the flex direction should be column not row)

@zjedi sorry for the inconvenience, this fixes the problem you mentioned.

no problem, thanks for the fix!

@susnux The top menu for smaller screen is not left-aligned, is that intentional? It used to be centered like the content itself.


AVRO-4070: Optimize Check Max Collection Length for New Collections

What is the purpose of the change

This pull request improves file read performance by skipping needless checks, fixing AVRO-4070.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.

Hello,
I'm working through the project using different techniques. This code came to my attention by profiling the following benchmark, not a specific benchmark for this method.
Nothing crazy, but this area of the code consumed roughly 1.2% of total cpu time in my personal (read: dated) system. After the change it was roughly 1% of cpu time. So the savings were roughly 0.2% in this array-heavy workload.
Thanks.
https://softwaremill.com/data-serialization-tools-comparison-avro-vs-protobuf/


LazyLattice and LazyConcept

Hi :)
I am currently testing WIP demo implementation of something i call LazyLattice (and LazyConcept).
Typical application is when you wanna construct Lattice with one concept and find its upper and lower neighbours (and nothing more).
Biggest priority was to keep the API as close as possible, because users could want to use Concept and LazyConcept as interchangeable arguments to other functions.
The whole magic is here and here.
Are you interested in this feature in the main branch? It is still work in progress (no docstring, API not complete etc.). This feature is necessary for my research so I will implement i anyway (in fcapsy package, which should still keep compatibility).
Ideas are welcomed :) (btw I feel that this feature is more important than https://github.com/xflr6/concepts/pull/15)
Small demo:
from concepts import Context

c = Context.fromstring('''
           |human|knight|king |mysterious|
King Arthur|  X  |  X   |  X  |          |
Sir Robin  |  X  |  X   |     |          |
holy grail |     |      |     |     X    |
''')

lazy_concept = c.lazy_lattice[["King Arthur"]]
# <LazyConcept {King Arthur} <-> [human knight king]>

len(c.lazy_lattice)
# 1

lazy_concept.upper_neighbors
# (<LazyConcept {King Arthur, Sir Robin} <-> [human knight]>,)

len(c.lazy_lattice)
# 2

lazy_concept.lower_neighbors
# (<LazyConcept {} <-> [human knight king mysterious]>,)

len(c.lazy_lattice)
# 3

lazy_concept.upper_neighbors
# (<LazyConcept {King Arthur, Sir Robin} <-> [human knight]>,)

len(c.lazy_lattice)
# 3 - nothing was added

Codecov Report

Merging #22 (6fc1b9c) into master (e1d73a8) will decrease coverage by 3.76%.
The diff coverage is 43.80%.

:exclamation: Current head 6fc1b9c differs from pull request most recent head 89137f7. Consider uploading reports for the commit 89137f7 to get more accurate results

@@             Coverage Diff             @@
##            master      #22      +/-   ##
===========================================
- Coverage   100.00%   96.23%   -3.77%
===========================================
  Files           23       25       +2
  Lines         1462     1567     +105
===========================================
+ Hits          1462     1508      +46
- Misses           0       59      +59

Impacted Files
Coverage Δ

concepts/lazy_lattice_members.py
41.53% <41.53%> (ø)

concepts/lazy_lattices.py
44.44% <44.44%> (ø)

concepts/contexts.py
99.50% <75.00%> (-0.50%)
:arrow_down:

concepts/__init__.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d73a8...89137f7. Read the comment docs.

just rebased to current master, no changes :)


handle multiple agg results

handle multiple intermediate aggregation results with the same name.

Codecov Report

Merging #2035 (131fc43) into main (f479840) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #2035      +/-   ##
==========================================
- Coverage   94.39%   94.38%   -0.02%
==========================================
  Files         319      319
  Lines       59161    59153       -8
==========================================
- Hits        55846    55831      -15
- Misses       3315     3322       +7

Impacted Files
Coverage Δ

src/aggregation/mod.rs
91.87% <ø> (-2.13%)
:arrow_down:

src/aggregation/intermediate_agg_result.rs
94.55% <84.61%> (-0.29%)
:arrow_down:

src/aggregation/bucket/histogram/histogram.rs
99.45% <100.00%> (-0.01%)
:arrow_down:

src/aggregation/bucket/range.rs
97.37% <100.00%> (-0.01%)
:arrow_down:

src/aggregation/bucket/term_agg.rs
98.70% <100.00%> (-0.01%)
:arrow_down:

src/aggregation/metric/percentiles.rs
89.23% <100.00%> (-0.04%)
:arrow_down:

src/aggregation/metric/stats.rs
96.58% <100.00%> (-0.02%)
:arrow_down:

... and 2 files with indirect coverage changes


Ic/fix etcd init

High-level description
This commit ensures that etcd initial state file is persisted across cluster reboots.
Corresponding DC/OS tickets (required)

COPS-6183 2.1 beta - etcd cluster fails and cannot restart if you reboot a master node

Related tickets (optional)

D2IQ-ID JIRA title / short description.

@mesosphere-mergebot request-review @jkoelker @vespian

@mesosphere-mergebot sync

@mesosphere-mergebot backport 2.1


Changelog docs missing "get from github" example

Somewhere between version 0.3.0-prerelease.5 and 0.3.0-prerelease.6 oranda stopped showing the "body" of changelogs.
Before (up to .5):

Starting in .6 (and including release 0.3.1):

I haven't nailed down the specific commit, but with binstall that is the released version range.

Haha, j/k, this was an intentional design choice.
Adding this makes it all better:
  "components": {
    "changelog": {
      "read_changelog_file": false
    }
  }

That being said, it's not mentioned in the changelog docs, and it does mean that we need to manually disable changelogs in all children projects.
I'll keep this open to maybe track:

Adding docs for this
Maybe discuss the impact of enabling changelogs for ALL subprojects, which might not be released independently.

This is probably an area where mnemos is weird because:

we don't actually release our children crates (which might have their own changelogs?)
we do sort of "whole repo rolling release" things just for progress.

Also I see a lot of this while building:
↪ >o_o< INFO: Found 52 paths to watch, starting watch...
↪ >o_o< INFO: Workspace detected, gathering info...
↪ >o_o< INFO: Building 14 workspace member(s)...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
MnemosProjectOverview ↪ >o_o< INFO: Building components: changelog, mdbook
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
Fetching from proxy encountered an error:
 HTTP status client error (403 Forbidden) for url (https://octolotl.axodotdev.host/releases/tosc-rs/mnemos).
 Falling back to GitHub directly...
↪ >o_o< INFO: Building workspace index page...
✓ >o_o< SUCCESS: Your site builds are located in `public`.
✓ >o_o< SUCCESS: Your project is available at: http://<IP_ADDRESS>:7979

Also, the first thing I tried was to put "changelog": false in the workspace, then ONLY enabling the changelog w/ "pull from github" for our overview project, but I think that didn't work (no changelog generated for the overview project).

I was just wondering why the changelog wasn't showing up on our oranda site. Thanks for the hint!
I think it would be nice if oranda tried to read the changelog from GitHub (or similar) automatically if there is no CHANGELOG.md present. Otherwise, just some documentation on this would be great! Additionally, it might be nice if oranda emits a warning (maybe even an error) if read_changelog_file is set to true, but no file is found.


TS1192: Module '"[...]/node_modules/cem-plugin-better-lit-types/dist/index"' has no default export.

When using the plugin by:
import extractLitTypes from 'cem-plugin-better-lit-types'

Typescript reports a problem that the package itself has no default export:
TS1192: Module '"[...]/node_modules/cem-plugin-better-lit-types/dist/index"' has no default export.

This is technically true, as the index does not have a default export, but the plugin is supposed to supersede that. While on runtime, this does happen; it is not detected in the linting stage.

Thanks, mate! I haven't faced such an issue with the latest TS but seems like we have to change the way we export :)

@adaliszk just released 0.1.16 to npm. Will make a better version release flow next week.
Thank you for contributing!

Thank you for the quick fix!


Add toggle option for devtools

I think It would be useful when devtool is needed frequency. :)

Sure, but options needs a better name. Maybe showDevTools. Also need to fix the code style. See travis.

Fixed

And the option needs to be documented.

I added desc to readme as below. how about it?
## Usage
```js
var app = require('app');

require('electron-debug')({
	showDevTools: true
});

let win;

app.on('ready', function () {
	win = new BrowserWindow({
		width: 800,
		height: 600
	});
});

Options
showDevTools
If true, DevTools will be shown after the app has been started.

:+1:

Can you fix the merge conflict?

I merged but commit logs wasn't clear. it would be better that make new PR?


[2569] Show help text when provider has a single location

Context
When a provider has a single location - they are not able to edit their locations for the course. Currently, a change link is shown that doesn't work.
Changes proposed in this pull request

Don't show the change link on a provider with a single location
Show help text when there is one location
Create link to manage locations which opens in a new tab

Guidance to review
Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

Rebasing + fixing conflict then merging :tada:


Handle peer disconnect

When a remote peer is disconnected either through connection issues, like the network connection being cut, or by killing the peerd daemon, the node should attempt to reconnect with the remote peer. This only counts for connecting, or taker, connections. Makers, or listener have to remain up at all times.

Pull request opened in #426


Update k6 installation commands for dl.k6.io

Let's not merge this until we're ready to announce it (when https://github.com/k6io/k6/pull/1978 is merged).

Definitely. Thanks!

@simskij This is ready now, so you can approve/merge. Thanks!

Thanks for the help, @imiric! 🙇🏼


X-Envoy-Internal when using short hostname

Bug Description
curl -v https://myservice.com.au/actuator/health              <= x-envoy-internal is null: that's expected as the call goes out to the internet before coming back in via ingress gateway
curl -v https://myservice.internal.com.au/actuator/health    <= x-envoy-internal is true: that's the normal behavior
curl -v http://myservice.mynamespace/actuator/health         <= x-envoy-internal is null: this seems wrong
curl -v http://myservice/actuator/health                     <= x-envoy-internal is null: this seems wrong (from a pod from the same namespace as "myservice")

the first 2 curl calls behave as expected.
However, the 3rd and 4th calls are using the short form of the hostname, and we're getting x-envoy-internal as null.
That seems like a bug (unless it's a feature)
Context:
The context is to get this authorizationpolicy to work:
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: myservice
  namespace: mynamespace
spec:
  action: ALLOW
  rules:
  - to:
    - operation:
        paths:
        - /actuator/*
    when:
    - key: request.headers[X-Envoy-Internal]
      values:
      - "true"
  selector:
    matchLabels:
      app.kubernetes.io/instance: myservice.mynamespace
      app.kubernetes.io/name: myservice

=> because of this bug, this authorizationpolicy does not work (I've re-written it using a match on the source namespace, FYI)
Version
istio version: 1.10.4

kubectl version --short
Client Version: v1.22.2
Server Version: v1.21.2-eks-0389ca3

Additional Information
No response

cc @ramaraochavali this seems related to something you looked into perhaps

@jgournet I am not quite familiar with this, but probably set PILOT_SIDECAR_USE_REMOTE_ADDRESS at pilot would help? https://github.com/istio/istio/blob/3c3905e8e904d1913e0b12e841d6feceb41a19e7/pilot/pkg/features/pilot.go#L140

@bianpengyuan : Indeed, setting PILOT_SIDECAR_USE_REMOTE_ADDRESS to true seems to be doing the trick !
thanks for that
side question: would you have any idea of the side effects of changing that variable ?

The only diff that option make is that now outbound listener will have useRemoteAddress set. See all the implications at Envoy doc: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#x-forwarded-for


μ (mu) gets rendered as α (alpha)

In
https://tu-dresden.de/mn/physik/iktp/ressourcen/dateien/studium/praktikum/LM_Anleitung_komplett.pdf?lang=en
μ (mu) gets rendered as α (alpha).
This doesn't usually happen so I figure that this is a font issue, maybe even specific to my machine.
Configuration:

Web browser and its version: Firefox 71
Operating system and its version: Arch Linux, Kernel Linux 5.1.12
PDF.js version:

var pdfjsVersion = '2.4.43';
var pdfjsBuild = '16ae7c69';

Is a browser extension: no

Steps to reproduce the problem:

Just open the abovementioned pdf.

What is the expected behavior?

In evince, the standard gnome pdf reader.
What went wrong?

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

That's a non-embedded "Symbol" font; the file renders correctly in Firefox Nightly 73 on Windows 7.

I can also reproduce this using Arch Linux, so since it's a non-embedded font it's most likely OS/configuration specific.

Duplicate of #4244


WIP: Translations

Close #288 #286
Gitlab related MR: https://gitlab.skypicker.com/frontend/frontend/merge_requests/5812

LiveURL: https://smartfaq-add-translations.surge.sh

wut?


ssh -X to server and run StorageExplorer is giving password manager service error

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.22.1
Regression From
no
Architecture
x64
Storage Explorer Build Number
20220122.3
Platform
Linux
OS Version
Centos 7.3
Bug Description
Microsoft Azure Storage Explorer requires a password manager service to keep your data safe, but your system does not appear to have one installed. Please make sure you have the right packages installed before launching the application again.
Getting above error if we login from other machine to the machine through CLI where storsge explorer is running locally and try to launch this
Working fine if we directly login to the server with display manager localy and run this from the same machine.
Steps to Reproduce
Login to a machine with ssh where storsge explorer is installed from Citrix or vnc Display manager
launch storage manager on server where this is installed from local path
Storage Explorer is coming up with following pop up window and not starting
Microsoft Azure Storage Explorer requires a password manager service to keep your data safe, but your system does not appear to have one installed. Please make sure you have the right packages installed before launching the application again.
The Storage Explorer is working fine if we run vnc or citrix on the installed machine where Storage Explorer is installed and open this from the display manger on that machine.

Actual Experience
storsge explorer  is not working when we login through ssh and redirect display to other machine
Expected Experience
The Storage explorer should work over ssh and redirect the display to present display session
Additional Context
No response
Microsoft Reference Ticket : SR<PHONE_NUMBER>001953

@AnjanMukherje how are you seeing the error if you are just doing SSH without any sort of window forwarding? Storage Explorer is a GUI tool, so you do need to have the UI visible to be able to use it. I would assume there would be issues running it in scenarios that include not having the UI visible. Did you install via snap or .tar.gz?

@MRayermannMSFT Thanks for your reply, yes when we did ssh with window forwarding that's why the GUi is poping up with error with display. We have tried both snap and tar.gz mode both having same issue. This is running properly if we start display manager on that machine and access that with display manager else ssh to that machine from other Display manager is giving same error. display is not an issue as we are able to run other gui application with ssh on that machine.

@AnjanMukherje I was taking a look into this today, but I'm running into an issue getting to the failure point you are at. I'm trying to run Storage Explorer from .tar.gz and I'm getting:
Uncaught Exception:
Error: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/matthew/Downloads/storage-explorer/resources/app/node_modules/keytar/build/Release/keytar.node)

Did you see this at one point and if so how did you workaround it?

@MRayermannMSFT Please use any higher version of GCC or set the LD_LIBRARY_PATH accordingly. I had installed gcc 9.2.0 and set the LD_LIBRARY_PATH gcc-9.2.0/lib64

@MRayermannMSFT Please find the Microsoft Service Request SR<PHONE_NUMBER>001953

Please use any higher version of GCC or set the LD_LIBRARY_PATH accordingly. I had installed gcc 9.2.0 and set the LD_LIBRARY_PATH gcc-9.2.0/lib64

Can you share with me the exact commands you used to do that?
Also, to be clear, I am merely investigating the possibility of supporting this scenario right now. At this time it is neither supported nor planned to be supported in the near future. But getting the point of actually repro'ing the issue will help us evaluate if we could support this. Thanks.

Please use any higher version of GCC or set the LD_LIBRARY_PATH accordingly. I had installed gcc 9.2.0 and set the LD_LIBRARY_PATH gcc-9.2.0/lib64

Can you share with me the exact commands you used to do that?
Also, to be clear, I am merely investigating the possibility of supporting this scenario right now. At this time it is neither supported nor planned to be supported in the near future. But getting to the point of actually repro'ing the issue will help us evaluate if we could support this. Thanks.

@MRayermannMSFT exact command will depends on your shell type as following
Shell - csh
setenv LD_LIBRARY_PATH < your lib64 path of your higher version of GCC >
Shell bash / sh
export LD_LIBRARY_PATH=< your lib64 path of your higher version of GCC >


How to handle pip deps from a private source?

I am currently using poetry to pull python pkgs from a private index (see section of my pyproject.toml file below).
[[tool.poetry.source]]
name = "private-channel"
url = "utl-private-index"
priority = "explicit"

[tool.poetry.dev-dependencies]
pip_pkg = {version = ">=x.x.x", source ="private-channel"

I configure poetry with a private access token so it can have access to the private channel. How can I do something similar with unidep?

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Currently, unidep only supports setuptools and hatchling, and you can use their respective features to access packages from a private channel.
Poetry unfortunately, is not as flexible wrt plugins and therefore cannot be integrated easily. I started working on this in https://github.com/basnijholt/unidep/pull/78, however, ran into a couple of hard blockers.


Set encoding?

Is there a way I could set encoding like this - :encoding => 'windows-1251'
I am getting "invalid byte sequence in UTF-8" error

@NathanielGiron the encoding options is not exposed. It's a simple code change in case you want to give it a shot at a PR. You can also try to set the client_encoding session-level variable in your PostgreSQL connection.


libqxt 0.6.2 patch

Thanks for your contribution to Homebrew!  You rock!


Port requirements for Monitoring and other optional Rancher features

I couldn't find a note of the port 9796 needing to be exposed in the Rancher docs, or if any others are required.  There is conflicting info online and it looks like some ports can be modified (and may have been since thxcode notes in https://github.com/rancher/rancher/issues/17957 that 9100 is required but I see nothing expose there on my cluster).
It is important that we have this information readily available.
I've created PRs https://github.com/rancher/docs/pull/2489 and https://github.com/rancher/docs/pull/2490 to expose at least this port on the monitoring page, but we need to find out if others are required and probably expose the information in a better way.
I think it maybe it makes sense to add to https://rancher.com/docs/rancher/v2.x/en/cluster-provisioning/node-requirements/#networking-requirements/ and maintain it as our central reference page?  (I think that's the goal here?  Can't actually see most of the items on this page so opened #2492)

@aiyengar2 Do you know of any undocumented ports that need to be opened for monitoring? if not I think we can close this issue.

@Tejeev I'd need to test it out to make sure, but I'm pretty sure we don't need any open ports on (non-Windows, Windows is tbd) clusters anymore in Monitoring V2.
Monitoring V1 still has these port requirements since it uses the upstream Prometheus exporters, but Monitoring V2 uses rancher-pushprox, which takes care of this requirement by deploying a client onto each node to collect the metrics from the hostNetwork and expose them on the Pod rather than requiring the port to be externally accessible; this was implemented for kubeScheduler, kubeProxy, kubeControllerManager, and kubeEtcd and can easily be extended to node-exporter (although, to my knowledge, node-exporter already exposes metrics via Pod rather than via Host as well).
For Windows nodes, 9796 will still be required at the moment since there's no way for us to currently publish a port on the hostNetwork of the Windows node (as exposed by wmi_exporter) via a container. However, the story for Monitoring V2 Windows support is still being worked on (https://github.com/rancher/rancher/issues/28327), so it's possible this requirement will disappear too.

@catherineluse maybe we should keep this issue open until we test to make sure Monitoring is deployable on a cluster with locked down ports.
@deniseschannon  @SheilaghM @cbron @jiaqiluo could we prioritize testing this?

Ok, I'll leave it open.
Note: Bastian reorganized the port requirements (https://github.com/rancher/docs/pull/2637), so any pull requests should be made against the staging branch.

Monitoring v1 is still the most used and will be for a while going forward (until v2 can match the v1 feature set in the UI).  Can we be sure the v1 docs don't miss anything?

Monitoring v1 is still the most used and will be for a while going forward (until v2 can match the v1 feature set in the UI).  Can we be sure the v1 docs don't miss anything?

Piggybacking on to this issue for a support case I've just been looking at.  We also need to include 10254 when ingress-nginx is using hostNetwork, and 10250. Prometheus is trying to scrape nginx, and the cadvisor endpoint for the kubelets.

I've dug a little further on the ports.  The endpoints that v1 tries to scrape are controlled by headless services in the cattle-prometheus namespace.  So in addition to the ports on the workers we also need to open up the kubernetes components ports on the controlplane, and the etcd port on etcd nodes.

@aiyengar2 I've reviewed the monitoring v2 and we will still need 9796 (node-exporter) and 10250 (kubelet) on the workers.  Should I raise an RFE and work on the helm chart to set up a push proxy for those components?
9796 is required because the node-exporter runs on the host network.  I'm not sure if this is required for network stats gathering or not.  Interestingly the kubelet ServiceMonitor is in the kube-system namespace not cattle-monitoring-system like the rest of the components.

Yes, let's raise an RFE for that. Adding a pushprox sounds like the right solution.
re: kubelet ServiceMonitor being in the kube-system namespace, this is because the Service that we monitor also exists in that namespace. To support users who enable flags like ignoreNamespaceSelectors, the ServiceMonitor needs to exist in the same namespace as well.

Don't we create that service as part of the chart though?  Couldn't we put both in cattle-monitoring-system to keep all of the k8s components together?
I'll raise the RFE.

We don't create that service as part of the chart


JSHint not listed in npm dependencies breaks npm install

Installing dependencies with npm install fails on freshly cloned repo due to JSHint not being required locally. Adding JSHint to be installed locally "jshint": "2.9.1-rc1" in package.json or npm --save-dev jshint lets setup complete successfully.
$ git clone https://github.com/officert/mongotron.git; cd mongotron/
Cloning into 'mongotron'...
remote: Counting objects: 6056, done.
remote: Total 6056 (delta 0), reused 0 (delta 0), pack-reused 6056
Receiving objects: 100% (6056/6056), 5.23 MiB | 2.43 MiB/s, done.
Resolving deltas: 100% (3918/3918), done.
Checking connectivity... done.
radiance at satori in ~/_scrap/mongotron on master

$ npm i

><EMAIL_ADDRESS>install /home/radiance/_scrap/mongotron/node_modules/bufferutil
> node-gyp rebuild

make: Entering directory '/home/radiance/_scrap/mongotron/node_modules/bufferutil/build'
  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o
  SOLINK_MODULE(target) Release/obj.target/bufferutil.node
  COPY Release/bufferutil.node
make: Leaving directory '/home/radiance/_scrap/mongotron/node_modules/bufferutil/build'

><EMAIL_ADDRESS>install /home/radiance/_scrap/mongotron/node_modules/utf-8-validate
> node-gyp rebuild

make: Entering directory '/home/radiance/_scrap/mongotron/node_modules/utf-8-validate/build'
  CXX(target) Release/obj.target/validation/src/validation.o
  SOLINK_MODULE(target) Release/obj.target/validation.node
  COPY Release/validation.node
make: Leaving directory '/home/radiance/_scrap/mongotron/node_modules/utf-8-validate/build'

><EMAIL_ADDRESS>postinstall /home/radiance/_scrap/mongotron/node_modules/electron-prebuilt
> node install.js

><EMAIL_ADDRESS>postinstall /home/radiance/_scrap/mongotron
> gulp dev-sym-links

module.js:328
    throw err;
    ^

Error: Cannot find module 'jshint/src/cli'
    at Function.Module._resolveFilename (module.js:326:15)
    at Function.Module._load (module.js:277:25)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/radiance/_scrap/mongotron/node_modules/gulp-jshint/src/extract.js:1:79)
    at Module._compile (module.js:398:26)
    at Object.Module._extensions..js (module.js:405:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Module.require (module.js:354:17)
    at require (internal/module.js:12:17)

npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of jasmine-core@* but none was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
npm ERR! Linux 4.1.15-1-lts
npm ERR! argv "/usr/bin/node" "/usr/sbin/npm" "i"
npm ERR! node v5.3.0
npm ERR! npm  v3.5.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: `gulp dev-sym-links`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'gulp dev-sym-links'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the Mongotron package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp dev-sym-links
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs Mongotron
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls Mongotron
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/radiance/_scrap/mongotron/npm-debug.log

Packing & running the app further on Arch Linux worked without a hitch once this was taken care of.

Npm should install jshint because it's a peer-dependency of gulp-jshint:
https://github.com/spalger/gulp-jshint/blob/master/package.json
I'm using NPM version 2.14.7, maybe you have an outdated version of NPM that doesn't support peerDeps?
I need to look into this a bit more. Ideally we don't need to add it to our dependencies since we aren't using it directly, but instead using it through gulp-jshint.

Here's my npm version:
$ npm --version
3.5.2

This might be related to the API changes in npm 3 and this in particular. It'd make sense for gulp-jshint to download the dependency however. Bug on their end?

Alright so I upgraded my version of NPM to the latest 3.3.12 and I ran into the same issue. Looks like NPM no longer auto installs peer depedencies:
https://github.com/npm/npm/blob/master/CHANGELOG.md#peerdependencies
I just update Mongotron to the latest Node version, 5.3.0, and added a couple new dependencies for things that were peer dependencies before:
https://github.com/officert/mongotron/commit/58428f7670c6aca2a3aa403b269be53a90e801b6
Everything is up and working again on my system, let me know if you have any other issues running.

[19:37:03] Finished 'release-lin' after 1.4 min

Thanks for the fix - no issues on my end either now!


Redirect not working

Edit: I get the following error when serving locally: /Library/Ruby/Gems/2.0.0/gems/jekyll-2.1.1/lib/jekyll/cleaner.rb:59: stack level too deep (SystemStackError)
Removing the plugin from _plugins fixes this.
So I have added the plugin and redirect into my Jeykll repo
Custom domain: http://samdoidge.com
I use the master branch as from the github article:
For User Pages, use the master branch in your username.github.io repository. For Project Pages, use the gh-pages branch in your project's repository.
Outcome: 404 Error

I fixed it by changing the relevant portion in def generate_aliases to this:
index_path = alias_index_path.split('/')[0, sections + 1].join('/')
next if index_path.empty?

@site.static_files << Jekyll::PagelessRedirectFile.new(@site, @site.dest, index_path, '')


Create own forum

I think this option should be ;)
When you are on the main page of ChainBB You have subforums like "community", "crypto", etc. I would like to make my own subforums such as "Linux", "Windows", etc. with their own tags - that is to make their own forum.
The best option would eventually appear on ChainBB.
For example, you go to chainbb.com/forum/pingwineknet (or something) and you have a list of subforums that you have set up, etc.

This is one of the next things I'm working on

Completed


Added option that was missing in set command

I won't merge this, since this is pretty much the same as the audit-channel so I'll update it myself later today.


Clarify link to license

Clarify that Massachusetts Institute of Technology is not responsible for the terms of this repo
At the moment we are not accepting contributions to the repository.
h/t @saagarjha for suggesting this

Thanks @eliperkins and @saagarjha! Sorry for the auto-close. This is merged in now.


Add New Relic license in file headers

Some Go files do not contain the New Relic license. This issue is to add the license in all of them and configure the pipeline to check them all in every commit.
For the pipeline check we could use the https://github.com/google/addlicense tool

Validate with legal team which type of file must contain the license (.go, .sh, etc)
make validate: fail if any file does not contain the license
Add make target to easily add license

Moved to internal


fix: 9648 The Update query fails to update for all matching Document in mongo

Description

The Update query fails to update for all matching Document in mongo
It works fine for single and fails for multiple records.
The issue is related to the Mongo version change syntax of handling multi records update.
Implemented the updates to fix the issue

Fixes #9648
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Manually verified by verifying the data in DB during development
Unit Test cases was modified to take up the new change

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=06921b5

/ok-to-test sha=c8d378f


scripts: west build: propagate verbosity to cmake generator

When run as "west -v build", make sure that the underlying build tool is run in verbose mode as well.
This involves some hacks for CMake 3.13. We can make it a bit simpler when we move to 3.14 or later.

@nashif as requested. Note that --verbose is a common west option, so you have to say west -v build; you can't say west build -v. I tried to support the latter but ran into argparse limitations.


Example of including county data

As you can see from the code, I barely know Javascript but was able to create a working example of what I had in mind for issue #44. Ideally instead of "Oregon" appearing in the list of countries, an additional selector would appear when "US" is chosen that would contain each of the 50 states.
However, hopefully this simple-yet-hardcoded example shows what I had in mind for County-specific data.
Apologies for the auto-formatting which obscures the very few real changes.

If merging, watch out for the URL change in createURL() to support my demo site. That should not be merged into the main branch.


nodeSelector indentation should be fixed

Describe the bug
The nodeSelector indentation here needs to be fixed:
https://github.com/banzaicloud/kafka-operator/blob/master/charts/kafka-operator/templates/operator-deployment.yaml#L106
fix: please remove 1 tab, or use absolute indentation
Steps to reproduce the issue:
I was not able to use nodeSelector without manually fixing it
Expected behavior
I would like to use your chart without fixing it manually

Thanks for reporting it we are going to fix this ASAP

@fireking77 we just fixed this. The new version of the chart 0.2.9 should work as intended.


feat(cert-manager): additional options for targeting WebhookConfigurations and CRDs

This PR adds the additional configuration option of strictly defining which Mutating/Validating Webhooks and CustomResourceDefinitions should be retrieved and extended with the generated certificate.
This can be done by using the following struct when creating a KeptnWebhookCertificateReconciler:
type ObservedObjects struct {
	MutatingWebhooks          []string
	ValidatingWebhooks        []string
	CustomResourceDefinitions []string
        Deployments               []string
}

type CertificateReconcilerConfig struct {
	WatchResources *ObservedObjects // if this is set, the controller will use the exact resources specified here, instead of using the label selector
	MatchLabels    labels.Set
	Namespace      string
	Log            logr.Logger
	Client         client.Client
	Scheme         *runtime.Scheme
	CancelMgrFunc  context.CancelFunc
}

This is intended for use cases where the  KeptnWebhookCertificateReconciler will be used as a library in other operators. Using the newly introduced options, operators using this will not require get,list,update permissions for all WebhookConfigurations and CustomResourceDefinitions, but can rely on ClusterRoles giving them access to a strictly defined set of resources, specified by the resourceNames in the ClusterRoles

I guess you need to rebase to master to make the helm validation check to pass


Fix memory allocation problems in e_loader_attic.c

There are a double free and a use after free problem.
This fixes both.
Refer to the PRs for a description of what the problem is.
Fixes #15115 and #15116

I think the sanitizer failure is a different problem.

Commit message updated to match PR.

Merged to master, thanks for the comments.


Cannot read property '$setTouched' of undefined

The line:
$scope.fc.$setTouched();
returns setTouched undefined when an item type of 'multiCheckbox' is changed.
This seems to be because 'fc' on the scope is undefined. I believe SC is the formcontrol, but can't see where this is set or unset.

I re-wrote that control to add a few extra pieces I needed and noticed that fc is now an array and I had to reference one of the objects in the array.