HADOOP-17404. ABFS: Small write - Merge append and flush

When Hflush or Hsync APIs are called, a call is made to store backend to commit the data that was appended.
If the data size written by Hadoop app is small, i.e. data size :
(a) before any of HFlush/HSync call is made or
(b) between 2 HFlush/Hsync API calls
is less than write buffer size, 2 separate calls, one for append and another for flush is made,
Apps that do such small writes eventually end up with almost similar number of calls for flush and append.
This commit enables Flush to be piggybacked onto append call for such short write scenarios. This is guarded with config "fs.azure.write.enableappendwithflush" which is set to off by default as it needs a relevant change in backend to propagate.
Tests asserting number of requests made, request data sizes, file sizes post append+flush and file content checks for various combinations of append/flush/close sets with and without the small write optimization is added.
Existing tests in ITestAbfsNetworkStatistics asserting Http stats were rewritten for easy readability.
(Test results published in end of PR conversation tab.)

HNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 398, Failures: 0, Errors: 0, Skipped: 68
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 165
HNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 448, Failures: 0, Errors: 0, Skipped: 24
[INFO] Results:
[INFO]
[WARNING] Tests run: 254, Failures: 0, Errors: 0, Skipped: 48
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 420, Failures: 0, Errors: 0, Skipped: 233
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 48

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 42s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
16m 21s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 58s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 25s

the patch passed

-0 :warning:
checkstyle
0m 18s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 8 new + 7 unchanged - 0 fixed = 15 total (was 7)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

-1 :x:
findbugs
1m  0s
/new-findbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 24s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

77m  3s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Null pointer dereference of op in org.apache.hadoop.fs.azurebfs.services.AbfsClient.appendBlobAppend(String, long, byte[], int, int, String) on exception path  Dereferenced at AbfsClient.java:in org.apache.hadoop.fs.azurebfs.services.AbfsClient.appendBlobAppend(String, long, byte[], int, int, String) on exception path  Dereferenced at AbfsClient.java:[line 417]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 34223cfd7dc4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6a1d7d9ed25

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/1/testReport/

Max. process+thread count
689 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 43s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
16m 22s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 59s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 25s

the patch passed

-0 :warning:
checkstyle
0m 17s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 8 new + 7 unchanged - 0 fixed = 15 total (was 7)

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m  0s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

-1 :x:
findbugs
0m 59s
/new-findbugs-hadoop-tools_hadoop-azure.html
hadoop-tools/hadoop-azure generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 26s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

77m 12s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Redundant nullcheck of op which is known to be null in org.apache.hadoop.fs.azurebfs.services.AbfsClient.appendBlobAppend(String, long, byte[], int, int, String)  Redundant null check at AbfsClient.java:is known to be null in org.apache.hadoop.fs.azurebfs.services.AbfsClient.appendBlobAppend(String, long, byte[], int, int, String)  Redundant null check at AbfsClient.java:[line 412]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 2fd53bc5a366 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6ff2409b317

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/2/testReport/

Max. process+thread count
686 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Test results from East US2:
HNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 460, Failures: 0, Errors: 0, Skipped: 68
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 165
HNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 460, Failures: 0, Errors: 0, Skipped: 24
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 48
NonHNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 460, Failures: 0, Errors: 0, Skipped: 251
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 165
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 460, Failures: 0, Errors: 0, Skipped: 247
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 48

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 57s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
16m 17s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  0s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 58s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m  4s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 59s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

77m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 82d58d58917b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c2cecfc9b95

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/3/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 30s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 27s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
16m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 58s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 55s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 54s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 57s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

76m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux d06ce038c022 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c2cecfc9b95

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/4/testReport/

Max. process+thread count
540 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 45s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
16m 45s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  0s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m 58s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
0m 59s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

77m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 1d06664ec01b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9bd3c9bc506

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/5/testReport/

Max. process+thread count
724 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @DadanielZ. Have addressed the review comment. Kindly request your review.
Latest test results:
HNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 498, Failures: 0, Errors: 0, Skipped: 70
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 165
NonHNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 486, Failures: 0, Errors: 0, Skipped: 253
[INFO] Results:
[INFO]
[WARNING] Tests run: 254, Failures: 0, Errors: 0, Skipped: 165
HNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 485, Failures: 0, Errors: 0, Skipped: 24
[INFO] Results:
[INFO]
[WARNING] Tests run: 250, Failures: 0, Errors: 0, Skipped: 48
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 454, Failures: 0, Errors: 0, Skipped: 247
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 48
HNS-AppendBlob
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 482, Failures: 0, Errors: 0, Skipped: 70
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 189

Thanks @DadanielZ. Have addressed the review comment. Kindly request your review.
Latest test results:
HNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 498, Failures: 0, Errors: 0, Skipped: 70
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 165
NonHNS-OAuth
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 486, Failures: 0, Errors: 0, Skipped: 253
[INFO] Results:
[INFO]
[WARNING] Tests run: 254, Failures: 0, Errors: 0, Skipped: 165
HNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 485, Failures: 0, Errors: 0, Skipped: 24
[INFO] Results:
[INFO]
[WARNING] Tests run: 250, Failures: 0, Errors: 0, Skipped: 48
NonHNS-SharedKey
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 454, Failures: 0, Errors: 0, Skipped: 247
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 48
HNS-AppendBlob
[INFO] Results:
[INFO]
[INFO] Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
[INFO] Results:
[INFO]
[WARNING] Tests run: 482, Failures: 0, Errors: 0, Skipped: 70
[INFO] Results:
[INFO]
[WARNING] Tests run: 256, Failures: 0, Errors: 0, Skipped: 189

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 12s

trunk passed

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
18m 34s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 58s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s

trunk passed

-0 :warning:
patch
1m 16s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
1m 14s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

89m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 9b15906f971d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d21c1c65761

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/testReport/

Max. process+thread count
510 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 23s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 4 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 12s

trunk passed

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
18m 34s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 58s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s

trunk passed

-0 :warning:
patch
1m 16s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
1m 14s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 30s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 31s

The patch does not generate ASF License warnings.

89m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2509

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 9b15906f971d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d21c1c65761

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/testReport/

Max. process+thread count
510 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2509/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Any plans to merge to branch-3.3? This is complicating my own backporting work.
If you do want it in -3.3, create a PR against it with this and the predecessor  #2526 in as separate commits, retest & declare the results. I'll do the merge afterwards.

Any plans to merge to branch-3.3? This is complicating my own backporting work.
If you do want it in -3.3, create a PR against it with this and the predecessor  #2526 in as separate commits, retest & declare the results. I'll do the merge afterwards.


get string value from the slider

hello, i have a slider with stepsArray of strings, im trying to get value and heightValue, but it shows me NAN, is there a way to get it as string? thank you

String values are not supported. If the slider is showing NAN or undefined values, it means that it could not convert the input to usable values.


Quick comment on Chapter 10

In Concept01_timeseries_data.ipynb in Chapter 10, I believe you can simplify and speed up the following code:
def split_data(data, percent_train=0.80):
    num_rows = len(data)
    train_data, test_data = [], []
    for idx, row in enumerate(data):
        if idx < num_rows * percent_train:
            train_data.append(row)
        else:
            test_data.append(row)
    return train_data, test_data

as follows:
def split_data(data, percent_train=0.80):
    num_rows = len(data)*percent_train
    return data[:num_rows], data[num_rows:]

I didn't want to open an issue for this and it is related to Chapter 10. Can you please add an example that uses batch_sequences_with_states method?


Parallel executions

Most drivers don't need this, but some would benefit from it, like Babel. A possible use case/example: beemo babel --react --flow --parallel "--cjs" --parallel "--esm". This would run the babel command twice, with the args --react --flow --cjs and --react --flow --esm passed respectively.

How to handle multiple .babelrc files with different configuration?


[CELEBORN-872][MASTER]Extract the same allocation logic for both loadaware and roundrobin

What changes were proposed in this pull request?
As title
Why are the changes needed?
Reduce duplicate code segments, improve code readability and maintenance difficulty.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit Test

Also cherry-picked to branch-0.3(v0.3.2)


Fix indentation in example code

Wrong indentation mixed with if's without braces makes it hard to follow the code.

Docs Build status updates of commit 3bfcfdb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/cosmos-db/sql/how-to-write-stored-procedures-triggers-udfs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@seesharprun
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Issue with combining wrappers

When trying to use compress.zlib in conjunction with vfs (i.e. compress.zlib://vfs://root/test.nbt) I get "cannot represent a stream of type user-space as a File Descriptor" when trying to use fopen.
Much googling hasn't turned up much on this issue; is this something that can be supported, or a limitation?

Reopen, referenced the wrong issue id in the commit

Which PHP version are you using? Trying this with PHP 5.6.4 I get the error message "failed to open stream: operation failed", not the one you have. Also, it seems the vfsStreamWrapper never gets called, so I'd suspect a limitation in PHP.

It was 5.6.12 but admittedly on Windows. I'll test on Linux when I get a chance (though that'll be 5.5.9, Ubuntu 14.04) and get back to you.

5.5.9 on linux gives both the "cannot represent a stream of type user-space as a File Descriptor" and "failed to open stream: operation failed" warnings.

I took the time to investigate it further. I stumbled about the stream_cast method which until now only returns false, but could have a purpose now. I'm not sure if this feature should be added, as it can only work with a real file system interaction. But this should be discussed in PR #125, I'll close this issue for now.


Update JS dependencies, remove space after emoji completion

Update all JS dependencies
Enable stylint media-feature-name-value-no-unknown
Make use of new features in webpack and text-expander-element
Tested Swagger and Mermaid

To explain the text-expander-element change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for @ mentions.

Dependencies updated again, new octicons added, new stylelint rule added.

@silverwind please fix the merge conflicts. :tea:

I was unable to create a backport for 1.20. @silverwind, please send one manually. :tea:
go run ./contrib/backport 25266
...  // fix git conflicts if any
go run ./contrib/backport --continue


enhancement: more specificity in error message

When I ran "dnx ef migrations add initial" I got this error:
System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate(CreateTableOperation operation, IndentedStringBuilder builder)
   at CallSite.Target(Closure , CallSite , CSharpMigrationOperationGenerator , Object , IndentedStringBuilder )
   at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate(String builderName, IReadOnlyList`1 operations, IndentedStringBuilder builder)
   at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationsGenerator.GenerateMigration(String migrationNamespace, String migrationName, IReadOnlyList`1 upOperations, IReadOnlyList`1 downOperations)
   at Microsoft.Data.Entity.Migrations.Design.MigrationsScaffolder.ScaffoldMigration(String migrationName, String rootNamespace, String subNamespace)
   at Microsoft.Data.Entity.Design.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
   at Microsoft.Data.Entity.Commands.Program.Executor.<>c__DisplayClass6_0.<AddMigration>b__0()
   at Microsoft.Data.Entity.Commands.Program.Executor.Execute(Action action)
An item with the same key has already been added.

It would be great if the message could include either the "item" or the "key" or something to help point me to the right answer faster. Maybe the generator could do a check before the Add() and then return an error from there rather than just relying on the basic Dictionary itself?
I do understand what the message is caused by generally, but trying to pinpoint which mapping it is hung up on is where it takes some sleuthing. I imagine new EF users would be pretty frustrated by this one too.

@esargent do you have a model you can share so that we can reproduce the issue. Agreed that this is not a helpful error.

@rowanmiller this was with RC1-final. I've upgraded to RC2 and haven't been able to repo - however I did just add (https://github.com/aspnet/EntityFramework/issues/4251), which I found while trying to create the repo. It may indicate that error checking changed and while this issue doesn't happen in rc2 it lets in a different problem.
Have to admit that because of this and a few other challenges I've had I decided to just leave ApplicationUser alone and use claims to reference the user-type-specific properties for each user. And the different user types no longer derive from ApplicationUser. Maybe that's a better design anyway - I've been writing internal enterprise apps leveraging AD and roles for so long, I'm still trying to figure out best way to go about this scenario. Might be a good "best practices" document down the road to decide which way to go.
repo for RC1 in next post...

here is repo code for RC1
using Microsoft.AspNet.Identity.EntityFramework;
using Microsoft.Data.Entity;
namespace WebApplication5
{
public class ApplicationUser : IdentityUser
{
}

public class SpecialUser1 : ApplicationUser
{
    //same property in SpecialUser1 and SpecialUser2
    public string Sex { get; set; }
}

public class SpecialUser2 : ApplicationUser
{
    public string SomethingElse { get; set; }
    public string Sex { get; set; } //same property NAME in SpecialUser1 and SpecialUser2
    public string SomethingElse2 { get; set; }
}

public class ApplicationDbContext : IdentityDbContext<ApplicationUser>
{
    public DbSet<ApplicationUser> ApplicationUsers { get; set; }

    //two derived classes with same property NAME as each other, but different types
    public DbSet<SpecialUser1> Users1 { get; set; }
    public DbSet<SpecialUser2> Users2 { get; set; }

    protected override void OnModelCreating(ModelBuilder builder)
    {
        base.OnModelCreating(builder);
    }
}

}
C:\Users\esargent\Documents\Visual Studio 2015\Projects\WebApplication5\src\WebApplication5>dnvm use 1.0.0-rc1-final
Adding C:\Users\esargent.dnx\runtimes\dnx-clr-win-x<IP_ADDRESS>-rc1-final\bin to process PATH
C:\Users\esargent\Documents\Visual Studio 2015\Projects\WebApplication5\src\WebApplication5>dnx ef migrations add one
System.ArgumentException: An item with the same key has already been added.
at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary2.Insert(TKey key, TValue value, Boolean add)    at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate(CreateTableOperation operation, IndentedStringBuilder builder)    at CallSite.Target(Closure , CallSite , CSharpMigrationOperationGenerator , Object , IndentedStringBuilder )    at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationOperationGenerator.Generate(String builderName, IReadOnlyList1 operations, IndentedStringBuilder builder)
at Microsoft.Data.Entity.Migrations.Design.CSharpMigrationsGenerator.GenerateMigration(String migrationNamespace, String migrationName, IReadOnlyList1 upOperations, IReadOnlyList1 downOperations)
at Microsoft.Data.Entity.Migrations.Design.MigrationsScaffolder.ScaffoldMigration(String migrationName, String rootNamespace, String subNamespace)
at Microsoft.Data.Entity.Design.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
at Microsoft.Data.Entity.Commands.Program.Executor.<>c__DisplayClass6_0.b__0()
at Microsoft.Data.Entity.Commands.Program.Executor.Execute(Action action)
An item with the same key has already been added.

@esargent thanks for confirming that it is fixed. I'll close this one out now.


Mirror grammer fixes

I saw some grammar issues in the README, so I just fixed them. Nothing too crazy.

Incorporated some of these changes into the README. Thanks!


[Scenario] Moving projects to Docker

This scenario will explain to developers how to migrate their existing projects to Docker containers.

I think this is handled by https://docs.microsoft.com/en-us/dotnet/core/docker/building-net-docker-images. @BillWagner, agree?

I think all the information is in the doc you reference. However, I don't think the information is structured to make it clear to a reader that it's got the information they seek.  I'd recommend adding a new introduction that introduces the scenario, and uses the phrase "lift and shift" to explain that the reader will learn how to take an existing application, migrate to docker and run it in a container. Along the way, you'll learn important concepts about working with docker.
Thoughts @JRAlexander ?

I agree. I think we could create a new doc that specifically addresses that scenario, but looks very similar to the current one.


Enhancement: THE FLA (yes I am mario produ trolled!)

Please check for duplicates or similar issues before creating this issue.
What is your suggestion, and why should it be implemented?
I want all the flas for uh doing the uh zer0 !11111111111 trolled!!111111111
incuding everythign, literal everything !!!!11111111111
(sorry i like to joke :D )

that was my idea

ITLL HAPPEN ONE DAY PRODU!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

you are sus ziffy


OmniSharp chokes on project containing Protobuf element

While trying out the new ASP.NET Core gRPC features in Visual Studio Code I noticed that I'm getting errors in the OmniSharp Log in VS Code after adding the Protobuf element to my project file. Interestingly this only seems to fail for the client project and not for the server project. I've followed the documentation to ge the client going. But once I add the  element I get the following error in my output:
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

Which version of OmniSharp are you using?
Also, can you post the full output of the OmniSharp log? thanks!

@filipw Sure thing. I'm running omnisharp 1.32.18 according to the logs, as part of the VS Code C# extension version 1.19.0. Here are the logs:
Starting OmniSharp server at 2019-5-7 12:50:56
    Target: /workspaces/aspnetcore-grpc/aspnetcore-grpc.sln

OmniSharp server started.
    Path: /root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/run
    PID: 977

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on debian 0.0 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 15.0 - "/root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 15.0 - "/root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild/Current/Bin"
            MSBuildExtensionsPath = /root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild
            BypassFrameworkInstallChecks = true
            CscToolPath = /root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild/Current/Bin/Roslyn
            CscToolExe = csc.exe
            MSBuildToolsPath = /root/.vscode-remote/extensions/ms-vscode.csharp-1.19.0/.omnisharp/1.32.18/omnisharp/.msbuild/Current/Bin
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/workspaces/aspnetcore-grpc'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.WorkspaceInitializer
        Project system 'OmniSharp.DotNet.DotNetProjectSystem' is disabled in the configuration.
[info]: OmniSharp.MSBuild.ProjectSystem
        Detecting projects in '/workspaces/aspnetcore-grpc/aspnetcore-grpc.sln'.
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Service/AspNetCoreGRPC.Service.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/workspaces/aspnetcore-grpc'.
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Service/AspNetCoreGRPC.Service.csproj
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/workspaces/aspnetcore-grpc' on host 125.
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Service/AspNetCoreGRPC.Service.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project '/workspaces/aspnetcore-grpc/Service/AspNetCoreGRPC.Service.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Adding project '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Service
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[warn]: OmniSharp.MSBuild.PackageDependencyChecker
        AspNetCoreGRPC.Client: Did not find 'Microsoft.NETCore.Platforms' in lock file.
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Grpc.Core;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Greet;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using System.Threading.Tasks;
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Grpc.Core;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Greet;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using System.Threading.Tasks;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Running;
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Configs;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Jobs;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Toolchains.CsProj;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Configs;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Jobs;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using BenchmarkDotNet.Toolchains.CsProj;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: Add argument name 'toolchain'
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Microsoft.AspNetCore.Mvc;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using System.Threading.Tasks;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Microsoft.AspNetCore.Server.Kestrel.Core;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using System.Net.Http;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using System;
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: using Greet;
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[info]: OmniSharp.MSBuild.ProjectManager
        Successfully loaded project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj'.
/workspaces/aspnetcore-grpc/Client/AspNetCoreGRPC.Client.csproj
/root/.nuget/packages/grpc.tools/1.20.1/build/_protobuf/Google.Protobuf.Tools.targets(263,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

[info]: OmniSharp.MSBuild.ProjectManager
        Update project: AspNetCoreGRPC.Client

@filipw Do you need any additional info?

This is also happening with the OmniSharp on the latest C# Extension in Visual Studio Code on OSX.
/Users/mathewphillips/.nuget/packages/grpc.tools/1.22.0/build/_protobuf/Google.Protobuf.Tools.targets(264,5): Error: The "ProtoCompile" task failed unexpectedly.     System.MissingMethodException: Method not found: void      Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)       at      Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute ()      [0x00029] in <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0        at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask      (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost,      Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext,      Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket,      Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x00212] in      <4e0a1f1d78cf4c1ebd6f9a3dbcebf3bb>:0

This issue also happens to me, but it just happens when I install "serilog" package

gRPC MSBuild tooling developer here. What happens is, with a near certainty, is the build tasks DLL from the package links at runtime to the wrong version of Microsoft.Build.Utilities, specifically the one that comes with Mono/XBuild rather than that from the Microsoft's MSBuild package. XBuild's MSBuild emulation assemblies notoriously lack some methods, so we're unlikely runnable against them.
Do you think it's possible to change this behavior within OmniSharp?

This is really annoying :/
I have lost my intellisense in VS Code since adding some Mono to my project. This really hurts productivity for me. It there no temporary workaround?

@koliyo and others having this problem.
Add the following options to settings.json and restart OmniSharp.
{
    ...
    "omnisharp.useGlobalMono": "never",
    ...
}

Getting latest OmniSharp version information
Downloading package 'Latest OmniSharp Version Information' (1 KB).................... Done!
Installing OmniSharp Version = 1.34.5...
Platform: darwin, x86_64

Downloading package 'OmniSharp for OSX, Version = 1.34.5' (42489 KB).................... Done!
Installing package 'OmniSharp for OSX, Version = 1.34.5'

Finished

Getting latest OmniSharp version information
Downloading package 'Latest OmniSharp Version Information' (1 KB).................... Done!

The project now loads successfully...
Starting OmniSharp server at 24/10/2019, 1:16:04 pm
    Target: /Users/****/source/csharp-support

OmniSharp server started.
    Path: /Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/run
    PID: 2952

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on MacOS 10.14.6 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 1 MSBuild instance(s)
            1: StandAlone 16.3 - "/Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        MSBUILD_EXE_PATH environment variable set to '/Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/MSBuild.dll'
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: StandAlone 16.3 - "/Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
            MSBuildExtensionsPath = /Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/xbuild
            BypassFrameworkInstallChecks = true
            CscToolPath = /Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/Roslyn
            CscToolExe = csc.exe
            MSBuildToolsPath = /Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin
            TargetFrameworkRootPath = /Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/xbuild-frameworks

compared to before...
Starting OmniSharp server at 24/10/2019, 1:14:12 pm
    Target: /Users/****/source/csharp-support

OmniSharp server started with Mono 6.4.0.
    Path: /Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/OmniSharp.exe
    PID: 2867

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on MacOS 10.14.6 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 16.3 - "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/msbuild/Current/bin"
            2: StandAlone 16.3 - "/Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 16.3 - "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/msbuild/Current/bin"
            CscToolExe = csc.exe
            CscToolPath = /Users/****/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5/omnisharp/.msbuild/Current/Bin/Roslyn
[info]: OmniSharp.Cake.CakeProjectSystem
        Detecting Cake files in '/Users/****/source/csharp-support'.
[info]: OmniSharp.Cake.CakeProjectSystem
        Could not find any Cake files
[info]: OmniSharp.MSBuild.ProjectSystem
        No solution files found in '/Users/****/source/csharp-support'
[info]: OmniSharp.MSBuild.ProjectManager
        Queue project update for '/Users/****/source/csharp-support/csharp-support.csproj'
[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/Users/****/source/csharp-support'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0
[info]: OmniSharp.MSBuild.ProjectManager
        Loading project: /Users/****/source/csharp-support/csharp-support.csproj
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100
[info]: OmniSharp.WorkspaceInitializer
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.EditorConfigWorkspaceOptionsProvider, Order: 200
[info]: OmniSharp.WorkspaceInitializer
        Configuration finished.
[info]: OmniSharp.Stdio.Host
        Omnisharp server running using Stdio at location '/Users/****/source/csharp-support' on host 1597.
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <10b73e4bf233421cae439ef765e97ef0>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x002a9] in <10b73e4bf233421cae439ef765e97ef0>:0
[warn]: OmniSharp.MSBuild.ProjectManager
        Failed to load project file '/Users/****/source/csharp-support/csharp-support.csproj'.
/Users/****/source/csharp-support/csharp-support.csproj
/Users/****/.nuget/packages/grpc.tools/2.24.0/build/_protobuf/Google.Protobuf.Tools.targets(264,5): Error: The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <10b73e4bf233421cae439ef765e97ef0>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x002a9] in <10b73e4bf233421cae439ef765e97ef0>:0

[fail]: OmniSharp.MSBuild.ProjectManager
        Attempted to update project that is not loaded: /Users/****/source/csharp-support/csharp-support.csproj

The main difference is that the OmniSharp.MSBuild.Discovery.MSBuildLocator in the newer version of Mono embedded within OmniSharp seems to be linking XBuild correctly as @kkm000 alluded to.
I've also tested with just adding "omnisharp.path": "latest", (currently 1.34.6-beta.37) but VSCode still prefers the global Mono.  And, under that condition it will fails. So, at the moment, the only solution is to set "omnisharp.useGlobalMono": "never",.

For anyone still experiencing this issue, I've found a workaround that works for me on OmniSharp for OSX, Version = 1.34.5.  It would seem that the root cause of the issue was found, but the fix in #1595 does not help me.
So far, the only solution for me has been to remove Microsoft.Build.Tasks.v4.0 and Microsoft.Build.Utilities.v4.0 libraries from the Mono GAC in Omnisharp.
Following the steps below has fully restored Omnisharp functionality for me in VSCode gRPC/Protobuf projects:

Find the path which leads to your Omnisharp extension.  Example: ~/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5.
Open the lib/mono/gac/ folder within the Omnisharp directory.
Delete the Microsoft.Build.Tasks.v4.0 and Microsoft.Build.Utilities.v4.0 folders.

This is a brutal way to solve the problem, but it's allowed me to get back to work.
@radical, since you worked on #1595, I'm wondering if my solution might give you more insight on how we can bypass the old MSBuild libraries.

The workaround suggested by @nagytech has worked for me as well, working on Ubuntu and with Omnisharp 1.34.4

the fix from #1595 has not been shipped yet because it was applied to the embedded mono build which hasn't been changed yet.
it will ship only once #1640 is merged

Thanks for the update @filipw.
I thought I would be able to build from master and that would solve the issue, but that doesn't seem to be the case.  Is that correct?

Looks like #1640 has been merged and deployed on November 6 (1.21.7) but this problem persists for me.
Verified that I am using the right version of mono "OmniSharp server started with Mono 6.4.0." but receive the following in the log.
[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <10b73e4bf233421cae439ef765e97ef0>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x002a9] in <10b73e4bf233421cae439ef765e97ef0>:0

Yup same problem still here
OmniSharp server started with Mono 6.4.0.
    Path: /Users/nils/.vscode/extensions/ms-vscode.csharp-1.21.8/.omnisharp/1.34.9-beta.24/omnisharp/OmniSharp.exe
    PID: 9633

[info]: OmniSharp.Stdio.Host
        Starting OmniSharp on MacOS 10.14.6 (x64)
[info]: OmniSharp.Services.DotNetCliService
        DotNetPath set to dotnet
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Mono 16.3 - "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/msbuild/Current/bin"
            2: StandAlone 16.3 - "/Users/nils/.vscode/extensions/ms-vscode.csharp-1.21.8/.omnisharp/1.34.9-beta.24/omnisharp/.msbuild/Current/Bin"
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Mono 16.3 - "/Library/Frameworks/Mono.framework/Versions/6.4.0/lib/mono/msbuild/Current/bin"
            CscToolExe = csc.exe
            CscToolPath = /Users/nils/.vscode/extensions/ms-vscode.csharp-1.21.8/.omnisharp/1.34.9-beta.24/omnisharp/.msbuild/Current/Bin/Roslyn

[fail]: OmniSharp.MSBuild.ProjectLoader
        The "ProtoCompile" task failed unexpectedly.
System.MissingMethodException: Method not found: void Microsoft.Build.Utilities.ToolTask.set_UseCommandProcessor(bool)
  at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute () [0x00029] in <4f09eee3b78a486b82b9150b91f40192>:0
  at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask (Microsoft.Build.BackEnd.ITaskExecutionHost taskExecutionHost, Microsoft.Build.BackEnd.Logging.TaskLoggingContext taskLoggingContext, Microsoft.Build.BackEnd.TaskHost taskHost, Microsoft.Build.BackEnd.ItemBucket bucket, Microsoft.Build.BackEnd.TaskExecutionMode howToExecuteTask) [0x002a9] in <4f09eee3b78a486b82b9150b91f40192>:0

Following the steps below has fully restored Omnisharp functionality for me in VSCode gRPC/Protobuf projects:

Find the path which leads to your Omnisharp extension.  Example: ~/.vscode/extensions/ms-vscode.csharp-1.21.5/.omnisharp/1.34.5.
Open the lib/mono/gac/ folder within the Omnisharp directory.
Delete the Microsoft.Build.Tasks.v4.0 and Microsoft.Build.Utilities.v4.0 folders.
Add "omnisharp.useGlobalMono": "never", to your VSCode settings.json.
Restart Omnisharp.

This file structure is not present for me in the recent omnisharp releases
# nils @ elMaco in ~/.vscode/extensions/ms-vscode.csharp-1.21.8 [13:47:59]
$ find . | grep Microsoft.Build.Tasks.v4.0
./.omnisharp/1.34.8/omnisharp/.msbuild/Current/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.8/omnisharp/.msbuild/15.0/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.24/omnisharp/.msbuild/Current/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.24/omnisharp/.msbuild/15.0/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.2/omnisharp/.msbuild/Current/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.2/omnisharp/.msbuild/15.0/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.10/omnisharp/.msbuild/Current/Bin/Microsoft.Build.Tasks.v4.0.dll
./.omnisharp/1.34.9-beta.10/omnisharp/.msbuild/15.0/Bin/Microsoft.Build.Tasks.v4.0.dll

However, setting the
    "omnisharp.useGlobalMono": "never",

in settings.json seems to help!
I also deleted all previous omnisharp packages in ~/.vscode/extensions/ms-vscode.csharp-1.21.8/.omnisharp, not sure if this was part of the solution.

The fix was deployed and shipped however it only affects running on local (not global) Mono.
Therefore the setting "omnisharp.useGlobalMono": "never" is necessary to see the result. Alternatively, it also works if no Mono 6.4.0+ is found on the machine.

The fix was deployed and shipped however it only affects running on local (not global) Mono.
Therefore the setting "omnisharp.useGlobalMono": "never" is necessary to see the result. Alternatively, it also works if no Mono 6.4.0+ is found on the machine.

Unfortunately, this fix no longer helps. It produces different error:
Microsoft.Build.Exceptions.InvalidProjectFileException: The SDK 'Microsoft.NET.Sdk.Web' specified could not be found.


Failed to do setup

Describe the bug
Just installed the latest version of the app and ran it, got the following error.
symlink /Applications/OrbStack.app/Contents/MacOS/xbin/docker-buildx /Users/xxx/.docker/cli-plugins/docker-buildx: no such file or directory

To Reproduce
No response
Expected behavior
No response
Diagnostic report (required)
No response
Screenshots and additional context (optional)
No response

@anarchy89 Is this still an issue?

I had to fully delete docker and orbstack and reinstall both.


Add mention of mmap perf change

Docs Build status updates of commit cd6e6ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/release-notes/NuGet-5.8.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c170bcc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/release-notes/NuGet-5.8.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

We created PRs at the same time. I merged https://github.com/NuGet/docs.microsoft.com-nuget/pull/2212 already!

Going to close as duplicate is already live.


SilverStripe 4.0 Compatibility (in progress)

The start of a migration to SS4, including namespacing, relationship updates and class calls where applicable.

Thanks Jack. What min version of SS does this work with? Is this backwards compatible with older versions of SS?

Hi Shea, currently this is in progress, however, I see you have merged this with master (as per PR). I was asked to create a PR so other SS community members may contribute to ss4 compatibility. I would recommend perhaps creating a new branch of master for ss4 compatibility and revert master to the commit before the merge.


Remove warnings from test

Remove variable names to get rid of pesky warnings that flood compilation screen

Current dependencies on/for this PR:

main

PR #291   👈

This comment was auto-generated by Graphite.

Merge activity

Oct 25, 4:19 PM: @oveddan started a stack merge that includes this pull request via Graphite.


Illegal characters in the example code

There are quite a few em-spaces ( ) in the example code on this page, which are illegal characters in the context of an Azure Manifest file.  Specifically, copying and pasting the examples in this page into an app registration manifest prevents the manifest from being saved, and is a hugely frustrating and difficult to find bug.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f7ced07-0b71-715f-749b-180567591c72
Version Independent ID: 8c533d7b-a058-3f1a-c296-9c0305f85f13
Content: Understanding the Azure Active Directory app manifest
Content Source: articles/active-directory/develop/reference-app-manifest.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@jdthorpe which sample code are you referring to?

Here is one of them:

There was another, but I can't seem to find it now.

@jdthorpe  Sorry for the trouble.  I was only able to find one instance on this page (the one you pointed out).  I removed it, the change should go live later this afternoon.  Please let us know if you find other instances.  Thanks.  #please-close


"peerDependencies" option has no effect in "import/no-extraneous-dependencies" rule since 2.23.0

With version 2.23.0 eslint fails due to peerDependency imports in our code:
1:1  error  '{PACKAGE_NAME}' should be listed in the project's dependencies. Run 'npm i -S {PACKAGE_NAME}' to add it  import/no-extraneous-dependencies
Our package is scoped (@org-name/package-name), not sure if it makes any difference.
Version 2.22.1 works fine.
Our config looks like this:
'import/no-extraneous-dependencies': [
      'error',
      {
        devDependencies: [
          //
        ],
        peerDependencies: true,
        packageDir: './',
      },
    ],

cc @paztis / #1696, can you take a look at this?

I think #2097 will resolve it


Fixed Linking disable_popup_result for all Tools

Previously each tool's CMakeLists.txt was restating the linkage for the replay tool.

CI gfxreconstruct build queued with queue ID 3139.

CI gfxreconstruct build # 2907 running.

CI gfxreconstruct build queued with queue ID 3154.

CI gfxreconstruct build # 2908 running.

CI gfxreconstruct build # 2908 passed.

CI gfxreconstruct build queued with queue ID 492.

CI gfxreconstruct build # 2924 running.

CI gfxreconstruct build # 2924 passed.


fix nested column thread safety issue for 24.0.1

smaller footprint version of fix #13265 for 24.0.1, this just fixes the TypeStrategy to use positional reads

@clintropolis it looks like integration tests are still failing in the 24.0.1 branch. We might want to check if there is something non-deterministic or not.

it looks like integration tests are still failing in the 24.0.1 branch. We might want to check if there is something non-deterministic or not.

hmm, these actually look unrelated to my fix, but maybe worth looking into
[ERROR] org.apache.druid.sql.avatica.DruidAvaticaHandlerTest.testConcurrentQueries  Time elapsed: 12.981 s  <<< ERROR!
java.util.concurrent.ExecutionException: java.lang.RuntimeException: org.apache.calcite.avatica.AvaticaSqlException: Error -1 (00000) : Error while executing SQL "SELECT COUNT(*) + 1636 AS ci FROM foo": Remote driver error: QueryInterruptedException: Error while applying rule DruidQueryRule(AGGREGATE_PROJECT), args [rel#631993:LogicalProject.NONE.[](input=RelSubset#631992,ci=+($0, 1636)), rel#632012:DruidQueryRel.NONE.[](query={"queryType":"timeseries","dataSource":{"type":"table","name":"foo"},"intervals":{"type":"intervals","intervals":["-146136543-09-08T08:23:32.096Z/146140482-04-24T15:36:27.903Z"]},"granularity":{"type":"all"},"aggregations":[{"type":"count","name":"a0"}],"context":{"nativeQueryIds":"[3ef1e7e1-f2f6-4152-8384-229eaea39482]","sqlQueryId":"f2727102-ff6c-404c-8f9a-2ed84a406e46","sqlStringifyArrays":false}},signature={a0:LONG})] -> RuntimeException: Error while applying rule DruidQueryRule(AGGREGATE_PROJECT), args [rel#631993:LogicalProject.NONE.[](input=RelSubset#631992,ci=+($0, 1636)), rel#632012:DruidQueryRel.NONE.[](query={"queryType":"timeseries","dataSource":{"type":"table","name":"foo"},"intervals":{"type":"intervals","intervals":["-146136543-09-08T08:23:32.096Z/146140482-04-24T15:36:27.903Z"]},"granularity":{"type":"all"},"aggregations":[{"type":"count","name":"a0"}],"context":{"nativeQueryIds":"[3ef1e7e1-f2f6-4152-8384-229eaea39482]","sqlQueryId":"f2727102-ff6c-404c-8f9a-2ed84a406e46","sqlStringifyArrays":false}},signature={a0:LONG})] -> NullPointerException: Cannot invoke "java.util.Map.size()" because "m" is null

I think maybe https://github.com/apache/druid/pull/13049 is the fix

created #13281 to backport that fix


Database Testing

We have decided against using mocks to test the database as we weren't making much progress. We are instead going to attempt to insert and delete test data from the database before and after running tests. This code will be called before and after tests involving the database.

@jsalyers12 raised a good point that we should probably reorganize the backend tests to break them up a little better. Going to do that as part of this issue.