Requesting new experimental role terms and one interactor type for genetic interactions

The Alliance of Genome Resources Interactions working group would like to request several new terms for genetic interaction interactors.
We realize that there already exist the terms:
'suppressor gene'
'suppressed gene'
under the 'experimental role' branch. As it is more accurate to refer to the perturbation (genetic, chemical, environmental) as the 'suppressor' or 'suppressed' entity we are proposing to create the following terms as children of the 'experimental role' term:
'suppressor perturbation'
def: 'A perturbation that suppresses the phenotype of another perturbation.'
'suppressed perturbation'
def: 'A perturbation whose phenotype is suppressed by another perturbation.'
'enhancer perturbation'
def: 'A perturbation that enhances the phenotype of another perturbation.'
'enhanced perturbation'
def: 'A perturbation whose phenotype is enhanced by another perturbation.'
'epistatic perturbation'
def: 'A perturbation whose phenotype masks the phenotype of another perturbation.'
'hypostatic perturbation'
def: 'A perturbation whose phenotype is masked by the phenotype of another perturbation.'
and we propose an additional term as a child of 'interactor type':
'perturbation'
def: 'A modification of an organism and/or its environment that may be capable of inducing or modifying a phenotype in that organism. This may include genetic perturbations, such as a gene mutation or RNA interference, chemical perturbations, such as the introduction of a drug or chemical, or environmental perturbations, such as a change in ambient temperature or humidity.'
As 'perturbation' is such a generic term, we may want to instead label the term 'organism perturbation' or something to that effect (both in the term label and in the experimental role term definitions).
Feedback is welcome.

The concept of entering a perturbation as an interactor I think enters in direct conflict with the concept of interaction representation we have taken at PSI-MI so far. We aim to capture different types of interctions -be it genetic, physical or causal- among physical molecules or genes. Perturbations that either affect or are derived from these interactions are captured in different ways: as features of interactors/participants (see the 'mutation' branch under MI:0118, https://www.ebi.ac.uk/ols/ontologies/mi/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMI_0118), as agonist/antagonist annotations (MI:0625/MI:0626), using the biological role to depict an effector/target relationship type or extending this via causal statements or mechanisms (see the whole branch devoted to this here:https://www.ebi.ac.uk/ols/ontologies/mi/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FMI_2233&viewMode=All&siblings=false).
I believe having perturbation as an interactor, especially the way you have defined it, enters in direct conflict with most of the curation practice we have been following until now, so I would rather not do it. I am happy to have a conversation about how we can best accommodate for the use cases you have in mind, to explore how they can be rerpesented using current terms and practice, if possible.

@pporrasebi
OK, thanks for your feedback.
Ultimately, all genetic interactions are phenotype-based interactions between genetic perturbations of genes (I'm happy to discuss in detail and would be very interested in learning of examples that don't fit this criteria). I suppose we can stick to using "gene" as the interactor for now, but it isn't quite accurate. Our working proposal for genetic interactions is to submit the primary interactors as genes (with type "gene") and also submit the identifiers for individual genetic perturbations for each gene (for example using WormBase ?Variation/Allele class object identifiers like "WBVar00012345") in columns 26 and 27 of the MITAB file ("Annotations for interactor A/B" columns) in agreement with prior discussions with @sandraorchard. Including these identifiers will be critical for accurate capturing/reporting/interpretation of genetic interactions from WormBase and FlyBase and maybe others in the future.
The most accurate way to express the nature of interactors (genetic perturbations) in a genetic interaction is to say that a particular perturbation (as interactor) has the role of being the suppressor/suppressed, enhancer/enhanced, etc. We can kludge it for now and just refer to an interactor role of "suppressor interactor" and "suppressed interactor", for example, but actually those descriptors are most accurately applied to the genetic perturbations themselves and not, say, the genes (hence why I'm somewhat against referring to "suppressor gene" or "suppressed gene").
Also, as you will see in the upcoming proposal for changes to the genetic interaction branch of the ontology/CV, we are trying to develop it with other types of phenotype-based interactions in mind, like drug-drug interactions, chemical-genetic interactions, environmental-genetic interactions, etc. So the type and nature of interactors will need to expand beyond genes to other types of entities like chemicals/small molecules, environments (or environmental conditions), and so on, all of which would fit the definition of "perturbation" that could be applied universally to these types of interactions.
Maybe we can simply make replace the word "perturbation" with "interactor" for the time being?
'suppressor interactor'
def: 'A interactor that suppresses the phenotype of another interactor.'
'suppressed interactor'
def: 'A interactor whose phenotype is suppressed by another interactor.'
'enhancer interactor'
def: 'A interactor that enhances the phenotype of another interactor.'
'enhanced interactor'
def: 'A interactor whose phenotype is enhanced by another interactor.'
'epistatic interactor'
def: 'A interactor whose phenotype masks the phenotype of another interactor.'
'hypostatic interactor'
def: 'A interactor whose phenotype is masked by the phenotype of another interactor.'

Dear Chris,
I finally could put aside some time to think about these terms and I am
not sure the solution we are heading towards is the correct one. My
apologies for the delay, I hope this does not cause major disruption on
your side.
I have realized that the terms you are requesting do not really refer to
an interactor type, which in PSI-MI is defined as 'Molecular species
involved in the interaction.'. In genetic interactions, the interactor
type should probably always be 'gene'. The terms you are requesting
rather refer to the role of these interactors in the interaction
context, what we refer as 'biological role' (def: 'Physiological role of
an interactor in a cell or in vivo environment, which is reproduced in
the current experiment.').
I fact, I was wondering if these roles could be actually described with
the current terms in the CV. The roles always refer to an effector
interactor and an affected one, right? There are children of biological
role 'regulator' [MI:2274] and 'regulator target' [MI:2275] that could
possibly serve this role. These were created to capture causal
statements and theier definitions might need some tweaking. Or new
similar terms, more specific for the genetic interaction contaext, could
be created.
Regarding the specific type of effect, it could be described with the
rather verbose branch of the CV under 'genetic interaction' type. So
this information is given at the interaction level rather than with the
interactor. Have a look at the interaction type terms I propose for each
of your proposed terms at the end opf the message.
So what do you think? This would hel;p keeping consistency in the way we
capture interactor types and also align the representation of genetic
interactions both with the original practice and with current efforts
capturing causality statements.
Best regards,
Pablo.
For 'suppressor interactor' and 'suppressed interactor'
[MI:0796] suppression: An effect in which two genetic perturbations,
when combined, result in a phenotype that is less severe/penetrant than
the most severe phenotype of the original perturbations, in effect
making the organism more "wild type" in character with regards to the
phenotype in question. With respect to any single quantifiable
phenotype, this may be expressed as an inequality as:
a* < ab <= wt [E = a*]
OR
wt <= ab < a* [E = a*]
where 'a*' is the most severe observed phenotype value of the individual
perturbations, 'ab' is the observed phenotype value of the double
perturbation, 'E' is the expected phenotype value of the double
perturbation, and 'wt' is the wild type phenotype value.
For 'enhancer interactor' and 'enhanced interactor'
[MI:1271] enhancement: An effect in which the phenotype of one genetic
perturbation is enhanced by a second perturbation to a
severity/penetrance beyond (further from wild type) that expected by the
superimposition or addition of effects of the individual perturbations.
With respect to any single quantifiable phenotype, this may be expressed
as an inequality as:
ab < E < wt
OR
wt < E < ab
where 'ab' is the observed phenotype value of the double perturbation,
'E' is the expected phenotype value of the double perturbation, and 'wt'
is the wild type phenotype value.
For 'epistatic interactor' and 'hypostatic interactor'
[MI:0797] epistasis: An effect in which individual perturbations of two
different genes result in different mutant phenotypes, and the resulting
phenotype of their combination (the double mutant) is equal to that of
only one of the perturbations. With respect to any single quantifiable
phenotype, this may be expressed as an inequality as:
(a != wt AND b != wt AND a != b) AND (ab = a OR ab = b)
where 'a' and 'b' are the observed phenotype values of the individual
perturbations, 'ab' is the observed phenotype value of the double
perturbation, 'wt' is the wild type phenotype value and 'a != b'
indicates qualitatively or quantitatively different phenotypes.
On 30/01/2020 14:28, Chris Grove wrote:

@pporrasebi https://github.com/pporrasebi
We can go ahead with the definitions proposed above:
'suppressor interactor'
def: 'A interactor that suppresses the phenotype of another interactor.'
'suppressed interactor'
def: 'A interactor whose phenotype is suppressed by another interactor.'
'enhancer interactor'
def: 'A interactor that enhances the phenotype of another interactor.'
'enhanced interactor'
def: 'A interactor whose phenotype is enhanced by another interactor.'
'epistatic interactor'
def: 'A interactor whose phenotype masks the phenotype of another
interactor.'
'hypostatic interactor'
def: 'A interactor whose phenotype is masked by the phenotype of
another interactor.'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HUPO-PSI/psi-mi-CV/issues/422?email_source=notifications&email_token=ADZHALY5WNE5UJW6IEFDDCLRALPZFA5CNFSM4JHLE6Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKLFSQA#issuecomment-580278592,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADZHALY743AOFP7E6HDP6VDRALPZFANCNFSM4JHLE6YQ.

--
Pablo Porras Millán, Ph.D.
Molecular Interactions Team Coordinator
European Molecular Biology Laboratory
European Bioinformatics Institute (EMBL-EBI)
Wellcome Genome Campus
Hinxton
Cambridge CB10 1SD
United Kingdom
Tel:    +44 1223 494482
email<EMAIL_ADDRESS>URLs:   www.ebi.ac.uk/about/people/pablo-porras-millan
www.ebi.ac.uk/intact
www.ebi.ac.uk/complexportal

@pporrasebi
Thanks.

The proposal was not for the proposed terms to be children of "interactor type" but rather of "experimental role". The suggested terms are not directly reflective of the biological roles of each gene or gene product, but rather an indication of the experimental role each gene or genetic perturbation plays in the experiment, similar to tagging one protein as "bait" and the other as "prey". So, it would not be appropriate to use the terms 'regulator' [MI:2274] and 'regulator target' [MI:2275]. The intention going forward is to flag the interactor type in genetic interactions with:

psi-mi:"MI:0250"(gene)
That said, with genetic interactions we are not talking about molecular species, because we are not talking about molecular interactions. We only refer to genes as interactors in genetic interactions as a sort of convenient place holder. Again, genetic interactions are not a type of molecular interaction.

The intention for specifying the type of genetic interaction was to use the terms in the genetic interaction branch of the CV (well, in fact, to use the new proposal for the genetic interaction branch that I'm currently working on and will submit soon as a pull request). This alone does not help us indicate which role each interactor plays. We need the ability to label each interactor with their respective role using one of the suggested terms above. Existing terms are insufficient for this purpose.

Ah, my bad, got mixed up while following the thread. I will create the new terms then under experimental role.
One question regarding suppressor/suppressed. Does the current definition fit your use case? We might need to reconcile both to ensure backwards compatibility:
Current def on 'suppresor gene': 'Gene whose mutation suppress the phenotype associated to a suppressed mutation.'
Your def: 'An interactor that suppresses the phenotype of another interactor.'
Current def on 'suppressed gene': 'Gene whose mutation phenotype is suppressed by a given suppressor mutation.'
Your def: 'An interactor whose phenotype is suppressed by another interactor.'
These are not really the same. I am out of my depth when it comes to the nitty-gritty of genetic interactions, any suggestions as to how to reconcile them?
Cheers,
Pablo.

@pporrasebi
OK, sounds good, thanks!
As for the 'suppressor gene' and 'suppressed gene' terms and definitions, I would prefer referencing a 'perturbation' or more specifically a 'genetic perturbation' as opposed to 'gene', but aside from that the definitions of those terms are OK except that they are quite limited by the fact that they refer to 'mutation' instead of the much broader, and more inclusive, term 'genetic perturbation'. Also, I think it is worth noting that these definitions, correctly I think, refer to the mutations as doing the suppressing or being suppressed, as opposed to the genes themselves. That notion is in-line with my earlier suggestion to make a 'genetic perturbation' interactor type as it is the genetic perturbation that does the suppressing/enhancing/masking or is being suppressed/enhanced/masked.
For backwards compatibility, we can either keep the 'suppressed gene' and 'suppressor gene' terms as they are but keep them in parallel with the new suggested terms, or we make these older terms obsolete and add a 'term-replaced-by' annotation pointing to the newer 'suppressed interactor' and 'suppressor interactor' terms.

What about replacing the 'mutation' bit in the existing terms with 'genetic perturbation'? That would cover both use cases and should cause no backwards compatibility problems.

Of course, the term names would also change to the new version using 'interactor' rather than 'gene', keeping the gene ones as synonyms.

OK, after considering it more, I think I should be OK with the terms "suppressor gene" and "suppressed gene", as it will be familiar to researchers and, in some sense, isn't wrong it just uses a particular usage of the word "gene" that actually implies an allele rather than a gene in a more general sense. So, here's what I propose:
"suppressor gene" (MI:0581)
change definition from: "Gene whose mutation suppress the phenotype associated to a suppressed mutation."
to: "A gene whose genetic perturbation suppresses the phenotype resulting from a different genetic perturbation."
"suppressed gene" (MI:0582)
change definition from: "Gene whose mutation phenotype is suppressed by a given suppressor mutation."
to: "A gene whose genetic perturbation phenotype is suppressed by a different genetic perturbation."
While it is generally considered bad practice to change the definition of a term in a controlled vocabulary or ontology (as opposed to obsoleting the term and creating a new term), in these cases we are making the definitions apply more broadly, as opposed to more restrictively, so it's probably OK.
The other potential issue here, down the road, is that these definitions will restrict the use of the terms "suppressor gene" and "suppressed gene" to only those cases in which the suppressor gene suppresses a genetic perturbation (as opposed to any other perturbation, like chemical/drug/environmental perturbations) and the suppressed gene is suppressed by a genetic perturbation (as opposed to any other perturbation), respectively. I suppose we can cross that bridge when we come to it.
For the four remaining terms, then, we can propose the following:
"enhancer gene"
def: "A gene whose genetic perturbation enhances the phenotype resulting from a different genetic perturbation."
"enhanced gene"
def: "A gene whose genetic perturbation phenotype is enhanced by a different genetic perturbation."
"epistatic gene"
def: "A gene whose genetic perturbation masks the phenotype resulting from a different genetic perturbation."
"hypostatic gene"
def: "A gene whose genetic perturbation phenotype is masked by a different genetic perturbation."

Fine with the proposal and the way forward. I would just tweak the definitions to make them a bit clearer in ths way:
"enhancer gene"
def: "A gene whose genetic perturbation enhances the phenotype resulting from a genetic perturbation on a different gene."
And so on for the rest of the definitions, so it is clear that this are perturbations happening in different genes.
I will start creating/amending exisitng definitions and will close the issue once everything is pushed to the repo.

@pporrasebi
Yes, I had initially thought of proposing the same definition (exactly, actually), but the issue is that there are instances of interactions that have been curated (at BioGRID and some at WormBase) in which the same gene is both suppressor and suppressed (intragenic suppression), for example. That's why I intentionally left off the "different gene" from the definition

OK, will leave the proginal one you proposed then.
Pushing the commit in a few minutes, once I am done.


TCP queries larger than 4 KiB are truncated

Version affected: 2.13.0
Messages larger than 4 KiB (TCP_SEND_BUF_SIZE - 2) are not supported by dnsperf. Larger messages are truncated and the first part of the message is still sent to the TCP connection with message preambule saying it's size is TCP_SEND_BUF_SIZE - 2.
This truncation breaks the message and causes parsing errors on the remote end.
I can see two ways out:

do not send too large messages at all
support messages up to 64 KiB

Personally I would go for 64 KiB because it removes once nasty corner case, and I just have use-case for that for testing large UPDATE. This is implemented in https://github.com/DNS-OARC/dnsperf/pull/250.

Did you test #250 ?
I don't think the receive and send buffer for TCP has nothing to do with how large DNS messages are allowed.


Reduce gradle test output from +599 MB -> 300kb

Description
When running full test suites printing all the output to std out blows out the console window and overloads the github action logs.  All this data is still avaliable in the junit reports that can be downloaded from the GitHub actions or avaliable in
${project.dir}/build/reports/tests/...
Issues

Related https://github.com/opensearch-project/opensearch-migrations/pull/928

Testing
I consulted the most recent build [1] after downloading the job logs, the gradle check was 600mb, and this was truncated by GitHubs systems.
Doing the same check on [2] which was before the unified CC job, the gradle check was 277kb.

[1] https://github.com/opensearch-project/opensearch-migrations/actions/runs/10800784819/job/29959542405
[2] https://github.com/opensearch-project/opensearch-migrations/actions/runs/10745741358/job/29805359911

Check List

[ ] ~New functionality includes testing~

[X] All tests pass, including unit test, integration test and doctest

[ ] ~New functionality has been documented~
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait What do you think?

I like the change - but I'm wondering what others workflows are.  Can you go into more detail about how one would download the pieces from github actions?  Will the streams be shown for failed tests?
Personally, I'm using the build scan links & I don't think that those will be impacted.  I suspect that we'll still have some same performance hit (though IntelliJ probably won't blow a core to manage its console when I run a terminal w/in it, which would be nice!).

I'm wondering what others workflows are.

@gregschohn Here is is what an unaffected workflow looks like on my PC, everything save the gradle job is pretty small and can be displayed on the GHA UX without causing my browser to crash or the output to be truncated.

Can you go into more detail about how one would download the pieces from github actions?

There a bunch of links on PRs/commits, but navigate to the CI Summary view, link.

Scroll down the summaries and you can see 2 artifacts, one for python e2e the other for gradle.  The gradle ones contain the junit test logs which includes log output grouped by test class, same as whats under ${project.dir}/build/reports/tests/...


Multiplayer Join-Code Entry Page

Need to design and implement a page where players can enter a join code.

Integrated into https://github.com/microsoft/pxt-arcade/issues/5165


Update to Java 21

:tada: This PR is included in version 0.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Part sourcer: find a library

Looks like jsoup is a good bet.

https://github.com/yasserg/crawler4j
Open source java web crawler that looks very easy to use


Apps UI Edits

Description
UI edits for Apps work:
• Notices are now part of Backups and Linodes, as well as adding Paper to a few of the different 'states' of the components (loading, null imagery, etc.)
• Grid alignment updates
• Making checkout bar use css sticky instead of external library.
Type of Change

Non breaking change ('update', 'change')

If the any above types of change apply to this pull request, please ensure to include one of the listed keywords in the pull request title.
Note to Reviewers
This work is most noticeable under the 'My Images' tab, but 'Distributions' tab and 'Create NodeBalancer' flow should be reviewed as well since I impacted CheckoutBar.
Also, if there are other places where Paper component should be added/ notice messaging needs to be moved, please call it out and I will address either here or in a separate issue.

Good call @Jskobos ! I just pushed up a fix. At the time I didn't have an image so only saw the null image view.

@martinmckenna updated, thank you!


Question: All processed/generated locally

More to get confirmation as I don't see any mention of it in documentation.
Are all the JavaDoc snippets processed/generated locally? And don't go out to third party systems like GPT etc
Thanks

All java docs are generated using predefined templates: https://github.com/TSergey/intellij-javadocs/blob/master/src/main/resources/templates.xml
It's done locally, without any help of 3-d party systems.


ssti checks

Add something to check ssti vulns

Done https://github.com/six2dez/reconftw/commit/e67416db04785b0a9bd9ee8d714940bbc77e0ad9


Added CheckDigit.ts

Why:
This PR is Linked to #2950
What's being changed:
Added a file CheckDigit.ts

@Akhilbisht798
Sorry, the issue is assigned to someone else. Please look for other issues and make sure you type !assign to grab the issue!
Thank you!


swiftlint 0.4.0

Adds Swiftlint --strict flag
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

Quick question @viktorbenei ! 😄
Will the step be available when it is merged or ? 😄

Sure, it's already available ;)
If you can't see it on bitrise.io in the editor just reload it a few times, the browser might cache the steplib data/spec.
But if you run it via the CLI (also applies for the build VMs as those run the CLI) then the steplib spec/data is fetched directly from git, so it's available right after the PR is merged :)


Error loading the plugin cocoapods-rome-0.7.0.

pod install is generating this issue:
---------------------------------------------
Error loading the plugin `cocoapods-rome-0.7.0`.

Gem::ConflictError - Unable to activate cocoapods-rome-0.7.0, because fourflusher-2.0.1 conflicts with fourflusher (~> 1.0.0)
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:2288:in `raise_if_conflicts'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/site_ruby/2.3.0/rubygems/specification.rb:1408:in `activate'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command/plugin_manager.rb:93:in `safe_activate_and_require'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command/plugin_manager.rb:31:in `block in load_plugins'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command/plugin_manager.rb:30:in `map'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command/plugin_manager.rb:30:in `load_plugins'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:326:in `block in run'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:325:in `each'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.1/lib/claide/command.rb:325:in `run'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/cocoapods-1.1.1/lib/cocoapods/command.rb:50:in `run'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/cocoapods-1.1.1/bin/pod:55:in `<top (required)>'
/usr/local/opt/rbenv/versions/2.3.1/bin/pod:22:in `load'
/usr/local/opt/rbenv/versions/2.3.1/bin/pod:22:in `<main>'
---------------------------------------------

Any chance to see #53 get pulled soon?

@klaas it's just awaiting review


[WIP] [Feature] Issue page filter by author

close #9408

[ ] get GetIssueAuthors ready

[ ] use keyword link checked jet
[x] limitation (i tend to limit to 15)

[ ] UI

[x] Add Menue
[ ] Keyword search (look at add team)

[ ] Test(s)

ok it's completly broken :/ - need a redoo


cargo run -- up can not update the table field

Description
In poem_example，update the table field in entity posts, add two fields, and then add two fields in
migration/ m20220120_000001_create_post_table
 .col(ColumnDef::new(Posts::Password).string().not_null())
.col(ColumnDef::new(Posts::Username).string().not_null())

#[derive(Iden)]
enum Posts {
    Table,
    Id,
    Title,
    Text,
    Password,
    Username
}

then execute migration/main.rs,
and the execution result is

and find that the fields in the database posts table are not updated.
why

update the fields and migration show Applying 1 pending migrations ,but the result is No pending migrations

That's the expected behaviour according to the source code:
async fn up(db: &DbConn, mut steps: Option<u32>) -> Result<(), DbErr> {
    Self::install(db).await?;
    let manager = SchemaManager::new(db);

    if let Some(steps) = steps {
        info!("Applying {} pending migrations", steps);
    } else {
        info!("Applying all pending migrations");
    }

    let migrations = Self::get_pending_migrations(db).await?.into_iter();
    if migrations.len() == 0 {
        info!("No pending migrations");
    }
    // skipped
 }

The cli first checks the steps option and displays a message immediately. After that, it checks the database to know how many migrations are pending and then displays another message.
Therefore, in your attempt there is no pending migration. To add a new migration, you should generate a new migration as documented here. Alternatively, if you just want to edit the already migrated file, you can first roll it back before running it again. Hope this helps.

Hey @diaojunxian, welcome! Sorry for the delay. I'm pretty sure the migration m20220120_000001_create_post_table has already been applied. That's why you alter the migration script of it and execute cargo run -- up do nothing for you. Because the migration you just edit has been applied and it won't apply it again.
You have two options:

Rollback the migration then re-apply it: execute cargo run -- down then carg run -- up
Create a new migration with scripts to add those two columns to the table

Thanks!! @ctfdavis

This might be related

https://github.com/SeaQL/sea-orm/issues/1007

Hey @diaojunxian, as a temporary workaround: execute cargo run on your migration crate. It will apply all pending migration at once.

Thanks a lot for your answer. I have figured out what the current principle.
I describe my desired scenario.
when had created a data table, the service also inserted some data normally. At this time, when want to update the data table fields, for example, append two fields.
then, it is not feasible for me to add it to the original m20220120_000001_create_post_table. And need to create a new m20220120_000002_create_post_table, and then execute cargo run, which seems strange for code management.

It's not desire to alter the old (applied) migration. You should always create a new migration if you want to alter the schema.
However, if you insist to change the old (applied) migration. You can rollback the migration then re-apply it by first executing cargo run -- down then carg run -- up or simply carg run.


Where/how to keep constants

https://github.com/gammasim/gammasim-tools/blob/53bc1708b979c60b61fe8e075f278235b58d2108/simtools/model/model_parameters.py#L13-L30
I added these constants necessary for the camera plotting here. @RaulRPrado, is this the correct place in your opinion? I have these in a yaml file in my code actually, but I don't mind keeping them like this in gammasim.

By now, yes.
I also want to move these model parameters to a yaml file at some point, but didn't have time yet.

OK, thanks. I can create the yaml and read it if you want (and tell me where you wish to have them). In the meantime I close this issue then.

There are more stuff to do actually. I want to make a system for it, similarly to what io_handler does.
The parameter files should go to data/parameters/ and its path should be read from config.yml.

Sure, we can make a system for it, but it should have its own dedicated issue. BTW, the current config.yml works, but it produces errors like
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/configReports does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/datFiles does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/Verification/dataFromInstrumentTeams does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/configReports does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/datFiles does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/Verification/dataFromInstrumentTeams does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/configReports does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/datFiles does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/Verification/dataFromInstrumentTeams does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/configReports does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/ModelDescription/trunk/datFiles does not exist
WARNING::config(l128)::_searchDirectory::Directory /home/prado/Work/Projects/CTA_MC/svn/Simulations/SimulationModel/Verification/dataFromInstrumentTeams does not exist

which are not nice =)

Ok ok.
I think these messages should still exist but I changed it to debug, instead of warning.
It was fixed in the master by https://github.com/gammasim/gammasim-tools/commit/180a0f393c38f276be811600f085640c58441a84


Implement quick eval-soft and eval-hard

eval-soft can just echo parsed input for now. eval-hard can be eager reduction for simplicity.

ctx : [(String,Term)]

example usage:
lambda_mountain soft print.lm < print.txt

Working on main now.


[com.plumelabs.flow] Unable to log into an app

Hi there,
I'm unable to use a really specific app of my collection (Flow, package=com.plumelabs.flow).
The app launches correctly, but recquire immediatly to log in, and whereas there is absolutely no problem with this step on another GAPPS phone, it's been at least 3 times with 3 different roms I'm facing the same issue with microG: can't log in, having a loading circle looping infinitly.
Here is the corresponding logcat :
06-17 23:47:18.814 I/FirebasePerformance(19092): Session ID - 4aca52a6838f4ec981d9d07922d89453
06-17 23:47:18.815 D/Logger  (19092): (Application.kt:65) LoginActivity started
06-17 23:47:18.815 D/FirebasePerformance(19092): Creating a new Non Verbose Session: d60752291be14690aad0afb8ac72afb5
06-17 23:47:18.818 D/Logger  (19092): (Application.kt:61) LoginActivity resumed
06-17 23:47:18.821 W/ActivityManager(16239): Unable to start service Intent { act=com.google.android.gms.config.START pkg=com.google.android.gms } U=0: not found
06-17 23:47:18.821 W/ActivityManager(16239): Unbind failed: could not find connection for android.os.BinderProxy@7f37fd3
06-17 23:47:18.821 E/GmsClient(19092): unable to connect to service: com.google.android.gms.config.START on com.google.android.gms
06-17 23:47:18.824 D/GmsMeasureBrokerSvc(17687): onBind: Intent { act=com.google.android.gms.measurement.START pkg=com.google.android.gms }
06-17 23:47:18.826 D/GmsClearcutSvc(17687): onBind: Intent { act=com.google.android.gms.clearcut.service.START pkg=com.google.android.gms }
06-17 23:47:18.831 W/FirebaseRemoteConfig(19092): IPC failure: 17:API: Config.API is not available on this device.
06-17 23:47:18.835 D/SafeParcel(17687): Unknown field num 10 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.835 D/SafeParcel(17687): Unknown field num 11 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.835 D/SafeParcel(17687): Unknown field num 12 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.835 D/GmsClearcutSvc(17687): bound by: GetServiceRequest{serviceId=CLEARCUT_LOGGER, gmsVersion=12451000, packageName='com.plumelabs.flow', extras=Bundle[{}]}
06-17 23:47:18.839 D/GmsClearcutLogSvcImpl(17687): log: LogEventParcelable[1, PlayLoggerContext[1, package=com.plumelabs.flow, packageVersionCode=78, logSource=-1, uploadAccount=null, loggingId=-1, logAndroidId=false, logSourceName=FIREPERF, isAnonymous=true, qosTier=0], LogEventBytes: CKLDoru2LTKjAQpoCigxOjEwMzE1NTYzODIzMzc6YW5kcm9pZDo4ZDliZGY3NDZkZjMxMTM1EgtkbVRLWU1iU3ZXMBotChJjb20ucGx1bWVsYWJzLmZsb3cSDzEuMC4wLjIyNTA1MzI1NhoGMS4yLjAzKAMSNwoDX2JzINi02vC+8eICKK/2ghVKIgogZDYwNzUyMjkxYmUxNDY5MGFhZDBhZmI4YWM3MmFmYjV4wHCIAaKj9CE=, AddPhenotypeExperimentTokens: true]
06-17 23:47:18.843 I/LatinIME(16521): Starting input. Cursor position = 46,46
06-17 23:47:18.847 D/SafeParcel(17687): Unknown field num 10 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.847 D/SafeParcel(17687): Unknown field num 11 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.847 D/SafeParcel(17687): Unknown field num 12 in com.google.android.gms.common.internal.GetServiceRequest, skipping.
06-17 23:47:18.847 D/GmsMeasureBrokerSvc(17687): bound by: GetServiceRequest{serviceId=MEASUREMENT, gmsVersion=12451000, packageName='com.plumelabs.flow', extras=Bundle[{}]}
06-17 23:47:18.848 D/GmsMeasureSvcImpl(17687): onTransact [unknown]: 10, android.os.Parcel@4f6de2e, 16

Phone Model : OnePlus6

MicroG installation :

Using the NanoDroid installer (NanoDroid-21.0.20190601)
Has anyone an idea on how to troubleshoot this case ? That might be related to #404 #529 #497 and #310 but not so much information there since :

issue seems to have magically resolved with new release or
issue was related to a -dirty microG build or
user has got around not using the problematic app anymore

At this point, any help is welcome ;)

Not related to the actual issue, but: you're not on the latest unofficial beta build (which is <IP_ADDRESS>55-beta-80). See https://www.nanolx.org/fdroid/repo
Additionally the next version of NanoDroid will by default install the official microG build instead of the unofficial custom build (see https://gitlab.com/Nanolx/NanoDroid/commit/8e115c0dbc62281e336cc5c06c25e05733b21b22) and provide the mapbox instead of vtm build (see https://gitlab.com/Nanolx/NanoDroid/commit/1f57ba0567b313e78762354d64386d25fac3667e).
(another step to get rid of the unofficial build)

Still the same with version <IP_ADDRESS>55-beta-80 (sorry for not having tested before, had a F-Droid cache issue, and thus didn't see the update earlier) unfortunately.
I'm gonna wait for the next NanoDroid release.
If ever you have the time for this, I'm having 2 questions by the way:

Can we just flash a NanoDroid new version right over another, or should we always uninstall any previous one and clean install a new one? Asking this because of all the already GCM registered apps.
If not, is there a way to reset the GCM registering process without having to backup data, reinstall and restore data?

Thanks by advance for any answer.

a) Why do you expect an uninstallation to be necessary? Just flash the update.
b) Yes, there is, if your device is rooted, run the following command in a shell: nutl -r  (reset GCM connection for all apps) or nutl -r <appid> , e.g. nutl -r com.android.vending (reset GCM connection for specific app)

Ok about the updating process, thanks.
Oh yeah I'm sorry man I remember I saw it in the wiki but when I wanted to try it out previously (on another ROM), running su and then nutl -r , I had a "No command found" and couldn't figure out which package was necessary or what I did wrong.
It's now working as expected, don't know what is different from previous installation, but nevermind I got it now.
Thank you so much. Is this command still gonna work with official microG instead of your custom one ?

I don't think it's gonna bring more information, but I eventually tried with the <IP_ADDRESS>55 official microG GMS (using nanodroid_gmscore=1 in the .nanodroid-setup config file) just in case, but sill the same :

06-21 02:09:35.227 W/BiChannelGoogleApi(31968): [FirebaseAuth: ] getGoogleApiForMethod() returned Gms: com.google.firebase.auth.api.internal.zzal@e3d1fb3

There's no (more) technical difference between both builds thus the error log is the same and yes nanodroid-util (or the nutl shortcut) works with both.

Ok, thanks for those precisions.
Hoping it won't be too much pain, I really want to thank you @mar-v-in and @Nanolx for all the hard work done so far to bring everyone this so useful and great alternative.
Have a nice weekend :)

I am reading here because of https://github.com/microg/android_packages_apps_GmsCore/issues/809
I am wondering howto find the problem in the many lines of locgat.

I am reading here because of #809
I am wondering howto find the problem in the many lines of locgat.

If you strip out the logcat to the actual moment where the issue showed up (like few sec around it), it's suddenly easier to find the problem ;)
Also, it's easier if you have experience in debugging, and even more when you are the dev :D

With new version [<IP_ADDRESS>85-beta-1 (8b4852b-mapbox)], I got this when trying to log in, with still the loading circle looping forever :
07-04 15:17:10.658 W/BiChannelGoogleApi(21165): [FirebaseAuth: ] getGoogleApiForMethod() returned Gms: com.google.firebase.auth.api.internal.zzal@17578b1

Hello,
I am having the same issue on <IP_ADDRESS>85-mapbox on the N26 app, can't go pass login.
Getting this error:
[GmsClient: unable to connect to service: com.google.android.gms.config.START on com.google.android.gms]

@voxitme microG does not support Firebase Auth so far, which very likely is the issue here. I will let you know once first support is there.
@x37-potter The log you presented is most likely not the issue causing you the problem. Can you provide further logs?

Here you go, thank you so much for your help!
log-number26.txt

We need a dummy com.google.android.gms.config.START, I see it also in other issues.

@x37-potter I personally never had an issue with the N26 app, Magisk not even being hidden to it...
Is it correctly registered in GCM ? Are other apps registered ?
If not (if not saying "Current state: connected since x" and not showing any apps list in the GCM menu), try this : go to the phone dialer and type ##2432546## (or ##CHECKIN##). Go back to microG and check if current state is now saying connected (don't remember if a reboot is necessary, maybe do it just in case). If yes, just uninstall reinstall N26 and all your other apps using GCM. They will appear in a list there.
Maybe that's useless for you but can help some others.
All of this is in the Nanolx's Nanodroid wiki.

Thanks, I didn't know about that wiki. Nope, I didn't manage to register it - the code didn't work (it said connected but no apps underneath).
Anyway, at the moment I had to uninstall microg because my phone becomes very slow and most apps don't start... I don't know what I did wrong.

go to the phone dialer and type ##2432546## (or ##CHECKIN##).

misguiding. Right is: **#**#2432546#**#** (or **#**#CHECKIN#**#**)

long time no updates, is it under development or dropped?

Hey there,
I'm upping this post because I still have the issue after updating to v<IP_ADDRESS>414
Is there any information about this issue? I can provide a logcat if needed.

Hey there,
I'm upping this post because I'm still having this issue after updating to v<IP_ADDRESS>414
Is there any information about this issue? I can provide a logcat if needed.

I am also very curious about this specific issue as the app still does not let the user log in even with the latest version of microG. Should I provide a log about this behaviour?

This should be fixed in c3bfb63f27c116d21ba7b2b87629e36573d4a59e (otherwise please reply).


Add CQDNUM to deps

I'll fix those test failures.

I think it is perhaps just that QCDNUM.jl still needs to be loaded from main as I've been making changes there...

Can you trigger CI again now?

Could you make a new QCDNUM release?

I have a list of further changes I wanted to make first - is it urgent?

is it urgent

No, maybe best to make those changes first.

I'll get to it soon!


More detailed error message in RMW_CONNEXT_CHECK_TYPESUPPORT_IDENTIFIER

this is to be more consistent with https://github.com/ros2/rmw/blob/master/rmw/include/rmw/impl/cpp/macros.hpp#L74 (and to help debugging the broken tests)
before: http://ci.ros2.org/view/nightly/job/nightly_linux_release/119/testReport/(root)/test_pendulum_teleop__rmw_connext_cpp/test_executable/
after: http://ci.ros2.org/job/ci_linux/1591/testReport/(root)/test_pendulum_teleop__rmw_connext_cpp/test_executable/

LGTM

Lgtm too


feat: Support running querier

We added experimental support to our helm chart to run stateless querier. via values.experimental.querier.enabled=true
If you are using the helm chart that supports querier, you can run this local cluster using QUERIER=true flag.
To use it:

COPY example overrides files from overrides/querier.yaml to values-overrides.yaml to the root of the repo

cp overrides/querier.yaml values-override.yaml

RUN the script with QUERIER=true flag

QUERIER=true S3_OFFLOAD="true" HELM_BRANCH="kavirajk/helm-chart-support-experimental-querier" ./local-k8s.sh setup

I've started a cluster with the queier which was supposed to have a single node and it started 3 replicas for the querier, you will have to override the experimental.querier.replicas values in local-k8s.sh so that both match:
kubectl get pods -n weaviate
NAME                             READY   STATUS      RESTARTS   AGE
contextionary-54866b8588-44n5n   1/1     Running     0          13m
minio                            1/1     Running     0          14m
minio-mc                         0/1     Completed   0          9m2s
querier-768f9859-9sg8m           1/1     Running     0          13m
querier-768f9859-l256f           1/1     Running     0          13m
querier-768f9859-lf7jx           1/1     Running     0          13m
weaviate-0                       1/1     Running     0          13m


In SystemVerilog, macro definition parsing error

module fifo (
    input           clk_50,
`ifdef CLK_ON
    input           clk_2,
`endif
    input           reset_n,
    output [7:0]    data_out,
    output          empty
);

I've encountered a parsing failure with SystemVerilog, and I believe that even for macro definitions, our grammar should be able to parse the symbol into a 'conditional_compilation_directive'. However, I'm getting an error with the `ifdef section. Could you please help me resolve this issue? Thank you.

--- a/tree-sitter-verilog/grammar.js
+++ b/tree-sitter-verilog/grammar.js
@@ -489,7 +489,8 @@ const rules = {
'(',
commaSep(seq(
repeat($.attribute_instance),

 $.ansi_port_declaration)

 seq(optional($._directives), $.ansi_port_declaration)

 ),

),
')'
),
It appears that this was a small problem, and I have already addressed the processing of macro definitions by making the aforementioned modifications.

Hi @donniek ,
Thanks for reporting an issue. To me this looks a duplicate of #11.
Thanks a lot for taking the time to find a solution too. It is similar to the one I proposed at https://github.com/gmlarumbe/tree-sitter-systemverilog/issues/11#issuecomment-2538978371. Could you check if it works for you and open an PR with a new testcase?
To create a new testcase, create a file under test/files/core/directives (e.g. module_port_list.sv) and run:
$ ./update_tests.sh -t -p core/directives/module_port_list
This will create a new reference test file (module_port_list.txt) that you can add to the PR along with the module_port_list.sv file.

I'm going to give it a try following the process you outlined.
I'm truly grateful for your swift response. I must say, I'm thoroughly impressed by your work; the tree-sitter-systemverilog project you've developed is incredibly thorough and high-quality. It certainly warrants more recognition. It's great to see that it's now integrated into Emacs verilog-ts-mode and nvim systemverilog, which should certainly help it earn more stars.
Keep up the outstanding work!💪

Hi @donniek ,
Thanks for reporting an issue. To me this looks a duplicate of #11.
Thanks a lot for taking the time to find a solution too. It is similar to the one I proposed at #11 (comment). Could you check if it works for you and open an PR with a new testcase?
To create a new testcase, create a file under test/files/core/directives (e.g. module_port_list.sv) and run: $ ./update_tests.sh -t -p core/directives/module_port_list
This will create a new reference test file (module_port_list.txt) that you can add to the PR along with the module_port_list.sv file.

Fixed in #14


Error: Invalid patch string when linting file

init.py.zip

Environment data

VS Code version: 1.28.0-insiders
Extension version (available under the Extensions sidebar): 2018.9.0
OS and version: macOS 10.14
Python version (& distribution if applicable, e.g. Anaconda): 3.7.0 (pyenv)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: N/A

Actual behavior
When I try to save the attached file I get the following error:
##########Linting Output - flake8##########
Error: Invalid patch string: Skipped 1 files

Expected  behavior
No error and correct linting.
Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
##########Linting Output - flake8##########
Error: Invalid patch string: Skipped 1 files

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
[ms-python.python]Invalid patch string: Skipped 1 files
e.$onExtensionRuntimeError @ mainThreadExtensionService.ts:43
t._doInvokeHandler @ rpcProtocol.ts:442
t._invokeHandler @ rpcProtocol.ts:427
t._receiveRequest @ rpcProtocol.ts:344
t._receiveOneMessage @ rpcProtocol.ts:274
(anonymous) @ rpcProtocol.ts:149
e.fire @ event.ts:140
a @ ipc.net.ts:105
n._socketDataListener @ ipc.net.ts:134
emitOne @ events.js:116
emit @ events.js:211
addChunk @ _stream_readable.js:263
readableAddChunk @ _stream_readable.js:250
Readable.push @ _stream_readable.js:208
onread @ net.js:594
mainThreadExtensionService.ts:44

Error: Invalid patch string: Skipped 1 files
	at diff_match_patch.patch_fromText (/Users/albireo/.vscode-insiders/extensions/ms-python.python-2018.9.0/out/client/common/editor.js:240:19)
	at EditorUtils.getWorkspaceEditsFromPatch (/Users/albireo/.vscode-insiders/extensions/ms-python.python-2018.9.0/out/client/common/editor.js:327:40)
	at SortImportsEditingProvider.<anonymous> (/Users/albireo/.vscode-insiders/extensions/ms-python.python-2018.9.0/out/client/providers/importSortProvider.js:80:41)
	at Generator.next (<anonymous>)
	at fulfilled (/Users/albireo/.vscode-insiders/extensions/ms-python.python-2018.9.0/out/client/providers/importSortProvider.js:13:58)
	at <anonymous>

I can replicate this.

Case for me as well.

I got the same issue while sorting imports.
It seems to happen only for __init__.py files.
Renaming the file (e.g. to foo.py) fix the issue and make me able to sort the imports.


Strange hamburger menu behaviour

First – thanks for your magnificent work, minimal mistakes is the thing that makes me stay with jekyll :)
I've observed strange behavior of hamburger menu. Depending on some thing that I'm not aware of sometimes JS is executed properly and hamburger menu is hidden, and sometimes I can see in console TypeError: $(...).fitVids is not a function stopping JS exeucution/leaving hamburger menu visible.
jQuery.Deferred exception: $(...).fitVids is not a function @https://www.samouczekprogramisty.pl/assets/js/main.min.js:9:24516
f@https://www.samouczekprogramisty.pl/assets/js/main.min.js:7:9959
i/</d<@https://www.samouczekprogramisty.pl/assets/js/main.min.js:7:10263
 undefined main.min.js:7:11541

Below are two screenshots of the same page. On first one everything works as intended:

On second one JS execution fails, which also causes search being unusable:

Post used here is just an example. I can see similar behavior on other posts as well.
What is causing that strange behavior? What can I do to fix it?
Page is generated locally and pushed to github and hosted from github pages.
Jekyll: 4.0.1
minimal-mistakes-jekyll: 4.19.3
Source code available here: https://github.com/SamouczekProgramisty/samouczekprogramisty.github.io/tree/source
Website available here: https://www.samouczekprogramisty.pl/wzorzec-projektowy-dekorator/
Web browser: Firefox 76.0.1
OS: Ubuntu 18.04

Not sure.  But that would have been the first thing I'd suspect since if you're getting JavaScript errors in the console that could interfere with search and the menu toggle.
I clicked around your site and didn't see any issues. Is there a specific page that you reliably see the FitVids error for? I'm not seeing any console errors.
Since you customized the theme and the issue doesn't appear to be in the MM demo site it would appear to be something unique to your fork. Are you sure all the layouts and includes are current with the theme's files? And that you're not loading any additional scripts that might interfere with main.min.js?

Thanks, I'll need to look deeper into that – will update the ticket in case I find something.


Implement QueuesMonitor to observe queues' engagement type updates

What was solved?
This PR introduces QueuesMonitor that needed to update available engagement types instantly. This doesn't include tests which will be added in further PRs along with integration of QueuesMonitor to EntryWidget.
Release notes:

[ ] Feature
[X] Ignore
[ ] Release notes (Is it clear from the description here?)
[ ] Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

[ ] Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
[ ] Did you add logging beneficial for troubleshooting of customer issues?
[ ] Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

@igorkravchenko the plan was to merge this PR with QueuesMonitor introduction, then I will create PR with integration of QueuesMonitor and EngagementLauncher to EntryWidget so @rasmustautsglia could adjust its logic with actual business logic. After these PR merged I will add the unit tests/

After these PR merged I will add the unit tests

@ykyivskyi-gl  I think, in such case, it is worth creating a dedicated Jira ticket, that will specifically mention unit tests coverage.

@igorkravchenko Done https://glia.atlassian.net/browse/MOB-3669 . Updated the TODO with the task number. Thank you!

!squash


feat(obstacle_avoidance_planner): deal with infeasible drivable area

Description
When obstacles are extracted from the drivable area for static avoidance or dynamic avoidance by the motion planner, in some cases, the drivable area width is too narrow and it's infeasible to drive inside the drivable area as shown in the following figures.
In this case, without the PR, the trajectory optimization failed due to infeasible drivability.
To deal with this case, the obstacle avoidance planner expands the drivable area if it's infeasible to drive.
This feature of keeping the feasible drivable area width should be considered when the drivable area is created in the behavior_path_planner.
The reason I put this feature into not the behavior_path_planner but the obstacle_avoidance_planner is to add less implementation for this feature.
The obstacle_avoidance_planner already calculates the drivable area's width, so it's quite easy to add this feature there.
NOTE:
This feature does not adversely affect driving on narrow roads. (e.g. The drivable area will not be expanded to the outside the road.)
Without this PR
Failed to optimize the avoiding trajectory.
The output on the terminal is [osqp_interface]: [MPT] Optimization failed due to solved inaccurate

With this PR
Succeeded in optimizing the avoiding trajectory by modifying the drivable area internally in obstacle_avoidance_planner.

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe
I created a feature PR. For me, it's fine not to go deep into the code change for approval.


whats the diff between nocom and noc*m

noc*m sends CPacketTryUseItemOnBlock instead of the original nocoms CPacketPlayerDigging

Ah ok thanks

noc*m sends CPacketTryUseItemOnBlock instead of the original nocoms CPacketPlayerDigging

wait so noc*m is better then nocom

it just works on 0b0t. but its also slower


Adding html table results in table with no width

I'm adding Sablon.content with an html table.  The resulting table has columns with 0.1inch width.  I have attempted to add width on the table element (
) and also on the td/th elements.  I've used a variety of width values.  Most recently, I traced the code enough to see that it attempts to set the table/column width using dxa units, so my values were 1000 (columns) to 5000 (tables) hoping to see a table roughly 7 inches wide.  None of the values has changed the table rendered into the document.

@arvanasse can you provide more details? For example I have a table defined as such and it fits to the content contained.

        Table 1: Example With Formatting

            Head Cell 1
            Head Cell 2

            Data Cell 1
            Data Cell 2

            Data Cell 3
            Data Cell 4

See more HTML examples: test/fixtures/html/html_test_content.html

@stadelmanma What's been interesting is that the document formatting is fine when the document is opened in Word.  I'm working on a macbook pro without Word installed.  The Pages app typically opens Word docs without any issue.  I'm not sure what would be required to make Sablon-generated docs more portable.

Ah, so unfortunately MS Word doesn't completely follow the OOXML spec and they have alot of exceptions. I suspect this must be one of them since I have the same issue when I open the document using libreoffice at home. I suspect Pages must follow the OOXML spec to the letter (I'm pretty sure libreoffice does)
So the main way to debug this issue would be for you to generate a very simple 4 cell table (table XML is verbose so you don't want something big) that exhibits the problem shown. Unzip the DOCX file and copy out the relevant table's XML (contained in word/document.xml).
Then you will want to fix the table in Pages and do the same steps as above to see what differs between MS Word's table XML and the Page's XML.
Portability is nice when it's possible but formal support for non MS Word applications is not planned, I simply don't have the time (and I'm not 100% sure of the "need" for it either).


git deployment strategy freezes

Hello! I've tried to play a book, but when it gets to this task it seems like ansistrano freezes. I had to interrupt it.
I'd ssh into the server I've tried to deploy and saw the git_identity_file there (tried both public and private keys).
My ansible version is <IP_ADDRESS>
I would be glad to provide further info.

I've just read the docs of git module, and there accept_hostkey parameter has yes & no variants, but in your task used true. May that be a cause?

Well, I forgot that my private key required a passphrase... This SO answer helped me figure it out.
Closing, as not related to the ansistrano.

so how did you do ? created a new key without passphrase ? I just did that and my EC2 container is still in a waiting mode :( ! I really don't know what to do

@dupuchba yep. I've created a key without a passphrase and added it as a deployment key to GH repo. Be sure you are connecting to the right port.


How to generate OpenBLASConfig.cmake in Linux

With the lastest version of OpenBLAS source code.
I've tried in build openblas with cmake in Windows:
cd build/vs2017-x64
cmake ../.. -G "Visual Studio 15 2017 Win64"

This will generate 'OpenBLASConfig.cmake' in /path/to/install/share/cmake/OpenBLAS folder.
However, OpenBLASConfig.cmake file is not generated in Linux. Is there any trick that can generate it? Is there any plan that this file be generated on default in the future?
Btw, in Windows the OpenBLAS_LIBRARIES cmake variable is just empty, while OpenBLAS_LIBRARY is with correct value. This is not as what OpenBLASConfig.cmake's comment says:
#   OpenBLAS_LIBRARIES - OpenBLAS library to link against.
#   OpenBLAS_LIBRARY - same as LIBRARIES

The OpenBLASConfig.cmake does get generated on Linux, but only in the make install step. If your build does not install it, could you please upload a complete build log ?
I cannot really comment on the OpenBLAS_LIBRARY vs OpenBLAS_LIBRARIES topic, but as the
cmake config file is mainly using basic CMAKE commands it could be that it depends on CMAKE version and environment which of the two gets set ?

@martin-frbg  Thanks for reply.
I notice that in Linux I was using the lastest code of master branch instead of develop branch, sorry for the miss-understanding. Actually I just import this repo into a proxy website (https://gitee.com) for fast clone in P.R. China and that mirror on default gives master branch. Now I switched to develop branch and see OpenBLASConfig.cmake as you said.


[ci] add Xcelium DV test set 2 to private CI

This increases the number of Xcelium top-level DV tests run in private CI.
This partially addresses #14532.
Signed-off-by: Timothy Trippel<EMAIL_ADDRESS>

chip_sw_lc_walkthrough is currently failing in the nightly regressions, so you may have to exclude that for now.

chip_sw_lc_walkthrough is currently failing in the nightly regressions, so you may have to exclude that for now.

Done.


Reject master keys that are less than 16 bytes and add --generate-master-key CLI option

Pull Request
Related issue
Fix #3272
Fix #3287
What does this PR do?
User standpoint

Adds a --generate-master-key CLI flag to generate a fresh Master Key and exit.

(relevant fragment of the --help message)

When meilisearch is started in the development environment and no Master Key has been provided, then the binary prints a warning before starting.

When meilisearch is started in the development environment and the provided Master Key is shorter than 16 bytes, then the binary prints a warning before starting.

When meilisearch is started in the production environment, and no Master Key is provided, the error message is altered to generate a fresh Master Key.

When meilisearch is started in the production environment, and the provided Master Key is shorter than 16 bytes, then the binary exits with an error.

This implements the solution B described here: https://github.com/meilisearch/product/discussions/538#discussioncomment-4391346
Implementation standpoint

Add a new meilisearch-auth::generate_master_key function that uses a Cryptographic Random Number Generator (CRNG) to fill a vector of 32 bytes before encoding these bytes as base64

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Hey everyone!
I took some time to think about it, and I wonder if we are confident about adding --generate-master-key and if it's really necessary.

From what I see, there is only one use case where it appears; in all other cases, Meilisearch suggests a master-key. Wouldn't it be simpler to suggest a master-key in this case, too (for consistency & simplicity purposes)?

"When meilisearch is started in the development environment and the provided Master Key is shorter than 16 bytes, then the binary prints a warning before starting."

If yes, do we need a generate-master-key option?
2.1 This is an option that, when specified does not start Meilisearch (it would be the only one)
2.2 My opinion is that if it's suggested it is more than enough to help the user.
2.3 This is adding an option that would be immediately stabilized and documented.

(Sorry to be late 🙇♂) Note: This is something that can be removed during RC.
WDYT?


bower leaflet#0.7.7 invalid-meta The "main" field cannot contain font, image, audio, or video files

Hello,
Installing leaflet with bower I am getting this errors:
bower invalid-meta  The "main" field cannot contain font, image, audio, or video files
bower invalid-meta  The "main" field has to contain only 1 file per filetype; found multiple .png files: ["dist/images/layers-2x.png","dist/images/layers.png","dist/images/marker-icon-2x.png","dist/images/marker-icon.png","dist/images/marker-shadow.png"]

Maybe of changes to bower specs ( see: https://github.com/bower/spec/pull/43 )

Duplicate of https://github.com/Leaflet/Leaflet/pull/4481 ??

It seams so...
sorry i have missed


improve info for aggregated GeoResources

The BaseLayerInfo component should display the information from all GeoResources of an aggregated GeoResource

CSS adjustment has to be done yet.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.488%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
10083

Relevant Lines:
10085

💛  - Coveralls


Error: There was an error invoking Hub method 'c2.QuerySummaryState'

Hi Stanislav,
I'm trying your signalr-client-aio and it is working perfectly for the given methods:

SubscribeToExchangeDeltas
SubscribeToSummaryDeltas
queryExchangeState

Though when I'm trying to invoke two other requests, i.e.:
hub.server.invoke('querySummaryState', 'BTC-ETH')
hub.server.invoke('SubscribeToSummaryLiteDeltas', 'BTC-ETH')

i get the following error messages:

There was an error invoking Hub method 'c2.querySummaryState'
There was an error invoking Hub method 'c2.SubscribeToSummaryLiteDeltas'

A bit of googling around showed that this could sign something going wrong at Bittrex server side. Therefore: Does this occur to others as well?
Or does the client not feature these methods?
I'm running Python 3.7 in a Jupyter Notebook environment.

And I found a fix quickly after asking...
Just don't add the market identifiers:
hub.server.invoke('querySummaryState')
hub.server.invoke('SubscribeToSummaryLiteDeltas')

and it works perfectly


WebSocket error 400

I've got the following error when using web socket:

WebSocket connection to 'ws://site.com:9879' failed: Unexpected response code: 400

I run go access with the following parameters:
goaccess -f /var/log/nginx/access.log --log-format COMMON -o /var/www/stats/index.html --real-time-html --port=9879 --ws-url=site.com --origin=site.com

Great question. Actually the browser sends the origin header with the protocol included, so it should be exactly how it's accessed.
--origin=http://site.com

or
--origin=http://www.site.com

BTW, I just updated the man page option.

Unfortunately that doesn't work either :/
Request URL:ws://site.com:7890/
Host:site.com:7890
Origin:http://site.com
Pragma:no-cache
Sec-WebSocket-Extensions:permessage-deflate; client_max_window_bits
Sec-WebSocket-Key: XXXXXXXXXXXX==
Sec-WebSocket-Version:13
Upgrade:web socket

WebSocket connection to 'ws://site.com:7890/' failed: Error during WebSocket handshake: Unexpected >response code: 400

Have you tried running goaccess without --origin to narrow down the issue? Thanks.

Yeah I removed that because it picks up the right origin anyway, based on browser logs. However I still receive 400. It waits for about 10 seconds then returns 400..

Are you accessing the report through https? that could be the issue as well since the current version does not support wss. Just for testing purposes, you can test connecting via telnet to the ws server.
# telnet site.com 7890

I use plain HTTP. Connection works fine. But then as I type http headers it returns HTTP/1.1 400 Invalid Request. 👎

It would return 400 if no valid ws headers are sent. At this point is probably easier to run it through gdb  (if you are willing to).
$ curl tar.goaccess.io/goaccess-1.0.1.tar.gz | tar xvz
$ cd goaccess-1.0.1/
$ ./configure --enable-debug
$ make
$ gdb --args ./goaccess -f /var/log/nginx/access.log --log-format COMMON -o /var/www/stats/index.html --real-time-html --port=9879 --ws-url=site.com
(gdb) b ws_get_handshake <enter>
(gdb) r <enter>

Then try to open the generated report in your browser and use n to continue to the next line or s to step into a function call. A line within [this function] (https://github.com/allinurl/goaccess/blob/master/src/websocket.c#L1087) will give you the 400 status code.

I use Amazon EC2 so it could be it's the problem with AWS. I don't use load balancers though. I'll run it through debugger to see if I can get any more information on why it fails. Thank you!

Closing this as it appears to be a server config issue. Feel free to reopen it if needed. Thanks.

I'm running into the same issue
Debugging revealed the funny thing with parsing Host: header
(gdb) s
ws_set_header_fields (line=0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890", headers=0x7fdc34000a70) at src/websocket.c:1091
1091    {
4: method = 0x7fdc3c12add0 " \256\022<\334\177"
5: proto = 0x433b40 <xmalloc+24> "H\211E\370H\203}\370"
6: path = 0x7fdc3c12ae20 "P\256\022<\334\177"
7: list = (int *) 0x0
8: line = 0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890"
(gdb) n
1092      char *path = NULL, *method = NULL, *proto = NULL, *p, *value;
4: method = 0x7fdc3c12add0 " \256\022<\334\177"
5: proto = 0x433b40 <xmalloc+24> "H\211E\370H\203}\370"
6: path = 0x7fdc3c12ae20 "P\256\022<\334\177"
7: list = (int *) 0x0
8: line = 0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890"
(gdb)
1094      if (line[0] == '\n' || line[0] == '\r')
4: method = 0x0
5: proto = 0x0
6: path = 0x0
7: list = (int *) 0x0
8: line = 0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890"
(gdb)
1097      if ((strstr (line, "GET")) || (strstr (line, "get"))) {
4: method = 0x0
5: proto = 0x0
6: path = 0x0
7: list = (int *) 0x0
8: line = 0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890"
(gdb)
1098        if ((path = ws_parse_request (line, &method, &proto)) == NULL)
4: method = 0x0
5: proto = 0x0
6: path = 0x0
7: list = (int *) 0x0
8: line = 0x7fdc34002b40 "Host: cp2-apache.goaccess.beget:7890"
(gdb)
1099          return 1;

if we got get substring in Host: header - then parser thinks it contains request and tries to parse it once again
maybe we should check only GET substing in line to decide whether it is request or not

@mlosev, Thanks for reporting and debugging this. I've pushed a commit that should fix this. Please feel free to build from development and let me know if that solves the issue for you.

@allinurl  thanks for merging. I was testing this patch yesterday and it worked like a charm :wink:
Real-time html report is great, thank you for developing this!

real.html:1210 WebSocket connection to 'ws://myip:9870/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED

Exception... "Favicon at "http://myip/favicon.ico" failed to load: Not Found."  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 227"  data: no] FaviconLoader.jsm:227:22
onStopRequest resource:///modules/FaviconLoader.jsm:227

thanks

@narayan1599 your port is probably not open.


Inline without wires

Here's the patch to address https://github.com/rdaly525/coreir/issues/626
It does this by a fundamental change to the inlining module logics in the verilog backend. The scheme is now: emit instances that aren't inlined as before, skip instances that are inlined. The code for generating the inlined modules is now done when connections are added. Basically, when emitting an output connection, we search the inputs to the connections to see if they are driven by inlined modules. If so, inline the body of the module, otherwise, emit the wire name as normal.
Adds a new verilog serialization type VAssignStr, which is like VAssign, except instead of assigning a connection, it assigns a string to a target. This change allows us to abstract the notion of the assignment value, which could be a normal connection (wire name) or an inlined module body (verilog string).
This patch removes addConnection, in favor a function addConnections which handles the adding of connection logic with inlining.
Includes two test input .json files in tests/magma/inline which are generated by a simple magma script (also included in case we want to regenerate the .json files). The expected gold outputs are found in tests/magma/inline/gold (look here to see the result of inlining, the subtraction example is interesting because it shows some modules inlined and others not. The use of a module for Sub instead of a primitive is a side effect of mantle's sub interface having a carry out parameter, but that's a separate issue if we want to change that. In some ways, it made it a good test for this functionality).
The pseudo-code algorithm is included in a comment, as well as the referenced issue, but I'll include it below for completeness:
// queue = output ports of current definition
// while queue is not empty
//     output = queue.pop()
//     if output is driven by instance that can be inlined
//         recursively inline any inputs to instance if possible, otherwise use standard input wire
//         inline the instance and have it drive the output
//         add any non-inlined inputs of the instance to the queue
//     else
//        emit code normally for the output and instance
//        add the inputs of the instance to the queue

Agreed about the regex search and replace. You're right that the ideal solution here is to manipulate the AST representation (then we could use a visitor style pattern to search and replace AST nodes).

Ah I see, I misunderstood. Perfect then!

@leonardt a dev->master merge will ideally happen soon (today). Not sure if you want to merge now or wait for @rsetaluri

Up to you. There's quite a bit of code added here, so it could be good to get a second set of eyes on it. Also, I'm not sure if this is a critical feature to get in for the flow merge, so we could always merge this into master at a later time. The main thing is that the new functionality in this PR is guarded by the --inline flag, which I don't think many people are using at this time, so it shouldn't affect their code.
However, it does make some fundamental changes to the verilog generation logic, so if there were any regressions introduced that code, then that would affect users who aren't using --inline, so that is something to be cautious about.


Cursor position on screen for ruler?

Description of the new feature / enhancement
Cursor position can be used in the ruler (Win+Shift+M). It will display (X x Y) next to your cursor just like the rulers
Scenario when this would be used?
Can be used for macros to get cursor position.
Supporting information
No response

/dup #11800


How to deal with rubygems that "pull in" jquery-rails & jquery-ui-rails

This isn't an "issue" for react_on_rails per se (hey, this gem looks to the future!) but I wanted to see if anyone had some thoughts/mindshare on an integration problem.
Some rubygems, like Active Admin, depend on jquery-rails and jquery-ui-rails.  Thus, including them in a project can "force" jquery to be pulled in.  This of course is counter to the design philosophy of react_on_rails.
Is there a decent mental model for how to address this?  I thought of, in the webpack config, declaring externals for jquery and jquery-ui and NOT having them in the package.json.
The real issue this causes, of course, is that in some instances the jquery on a page (2.1.4) from webpack gets literally replaced by say, jquery 1.11.3, but all the widgets/things attached to $.fn then get blown away.
(to note, don't use those dang gem's in the answer -- I get it hah).

@rstudner Why would it matter if those gems like jquery and jquery-ui are pulled in? What matters is what you expose in terms of JS files on your layouts. So if Active Admin pulls the world in and take control of the layout, that should be fine. Just don't include your bundle.
Webpack also lets you bundle as you please, and you can easily specify jQuery as an external, etc.


Error when I try to install

Refusing to download the git repo
{"protocol":"http:","hostname":"ikt.pm2.io","repository":"http://ikt.pm2.io/ikt.git"} over HTTP without a commit hash
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Environment:
DigitalOcean, Alpine Linux (inside the docker container)

Have you tried using NPM rather then yarn? You can also just directly git clone the master branch and then cd to the directory and run 'pm2 install .'
Sent from my iPhone

On Jun 18, 2017, at 4:31 PM, Riderman de Sousa Barbosa<EMAIL_ADDRESS>wrote:
Refusing to download the git repo
{"protocol":"http:","hostname":"ikt.pm2.io","repository":"http://ikt.pm2.io/ikt.git"} over HTTP without a commit hash
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
Environment:
DigitalOcean, Alpine Linux (inside the docker container)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I install via docker using pm2-docker-alpine image
FROM keymetrics/pm2-docker-alpine
RUN pm2 install pm2-slack


Jump Links Component

Create a Jump Link component. The component should:

Have a drop-down where any star system can be selected.
Display the jump links from that star system. Jump links should consist of the destination system and the jump level.

:shipit:


Auto-open all new courses; remove Slack notification

Context
We no longer need to be notified of new courses because we can safely open them all automatically.
Now also removes the button to Open all courses, because we don't need it, and the button to trigger a sync, because we don't need that either, and there was a spec which tested both of them it was simpler to just delete.
Link to Trello card
https://trello.com/c/xiBI7KXR/4350-remove-new-course-notifications-from-support-channel

Removed some more as discussed @cwrw


Support for various cover image suffixes

The cover images for [stupdendous-sheep])https://bioimage.io/#/?type=model&tags=empanada&id=stupendous-sheep)
are not displayed (.tif cover images).
The preview using the thumbnails work. The thumbnails are saved as .png images).
Which of these file formats does the website support?
(Here is a list of the allowed cover image suffixes according to the current spec)

.gif
.jpeg
.jpg
.png
.svg
.tif
.tiff

offline @oeway stated that the website currently cannot handle .tiff-files

.tiff files are actually not allowed in the latest spec versions anymore...

we need to manually update older RDFs using tif cover images though...

we need to manually update older RDFs using tif cover images though...

Previously we have a conversion when generating the cover, so maybe we can just run that for all the older RDFs?

yes, but that thumbnail is also downscaled a bit.
I fixed it manually for the one model that made me discover this issue and it might have been the only one. I couldn't find another, but haven't searched through them all.
I think we can close this issue though and if we encounter another case just fix it manually.


[CT-3483] Support Semantic Layer timezone configs

Housekeeping

[X] I am a maintainer of dbt-core

Short description
The Semantic Layer currently uses timezone-agnostic types for all date/time operations, but forcing people to coerce to UTC and then back-convert on render is cumbersome at best and impossible at worst. We have real-world examples of people running into date boundary issues where they have customer data stored in the customer-local timezone, and they want to compute daily customer-specific metrics with the boundaries set for that customer's local day (rather than UTC or whatever).
For situations like that it's natural to store the date/time information in local time with timezone annotations intact, as this makes common query types more natural and also allows for things like audits against local time values.
Currently , the only work-around is to normalize the time stamp in the warehouse (via the underlying dbt model) ahead of time, or else to use the expr field to do it on the fly when the semantic model is constructed. This is somewhat limiting, as it does not allow for re-use of the same measure against different time zones.
To better support timezone information we need to expand the definition of TIME type Dimensions. Specifically a timezone attribute should be added to the Dimension type_params
dimensions:
  - name: date_time
    type: time
    type_params:
      time_granularity: day
      timezone: pst # New

Acceptance criteria
People can specify a timezone property on dimensions.
Impact to Other Teams

Semantic Layer - The semantic layer can't begin using this until we support it
Cloud artifacts - This change will change the v12 manifest that goes out with 1.8

Will backports be required?
Not sure if required, but the SL team would prefer a backport to 1.7
Context
This issue should not be considered ready to work on until the work is done in dbt-semantic-interfaces, because the schema we need to implement isn't finalized until that point. Currently there does exist an issue for this work in dbt-semantic-interfaces.

Should this be a location name instead of a timezone abbreviation? @Jstein77

List of timezones natively supported in Python: pytz.all_timezones_set


Wallet CLI need to re-scan for output transactions go from "Unconfirmed"->"Unspend"

Telegram report
I got many “Unconfirmed” output from a confirmed slate tx, which according to my test, I need do a re-scan otherwise they won’t become “Unspent”

I never need to re-scan with the old v2 wallet+node

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior.
Expected behavior
A clear and concise description of what you expected to happen.
Required data

Node/Wallet/Miner log as text or screenshot
Config toml file or command line
OS: [e.g. Windows]
Rust Version
Cargo Version

Additional context
Add any other context about the problem here.


Added Underline Title Text on UIButton method to UIButton extension

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 4.
[x] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[x] I have added a changelog entry describing my changes.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger

Hi @LucianoPAlmeida thank you for helping me with adding Test for last PR #365 . Can you please help me to add Test to this extension?

Hi, @SD10 Thank you for reviewing.

I think sometime user just want one line to add underline to title text by creating new attributedString and add attribution, with this mindset i created this extension.
Yeah, it's good to rename it to underlineTitleText().
I made a mistake. I merge last patch branch with master and created this branch with master so it contains another PR too. I am sorry for this, it was by mistake.
I will learn Unit Testing and add test to it.

I will commit all require changes tomorrow. Thanks :)

Hey @imjog and @SD10 :))
I agree with @SD10  first point, I think it's too specific and adds a little coupling on UIButton.
Another point is that it only works for .normal state.
Besides, it can be really easilly achieved with an extension that we already have on string
button.setAttributedTitle("string".underline, for: .normal)

I think this way above is a more decoupled API and more generic
And also very simple :))


Double tap is needed if this dropdown is wrapped for a ScroolView component

If the button is inside a scrollview or flatlist you have to add keyboardShouldPersistTaps="always" prop in the parent scrollview or flatlist


removes checksum function since it is included in bag validation

Not necessary to call separate checksum checking function, since bag validation includes it already!

All good.


d64412ae74 can't be used to build clang/llvm anymore

Bisecting, it looks like 6b4fb1a249a01891d68fcd9b6ceef1f2b3c788ba broke this. The failure is:
n2: error: parse error: expected '\n', got '.'
CMakeFiles/rules.ninja:119: rule CXX_COMPILER__obj.2eLLVMTableGenCom...

So it looks like between the mess that is llvm and #52 (which the breaking commit mentions it fixes) it's going to be a more complicated fix?

I just confirmed locally that backing out 6b4fb1a249a01891d68fcd9b6ceef1f2b3c788ba does let me build LLVM again, in case that's a useful datapoint.

Thanks for the report.  Are you using n2?  I haven't really touched it since my initial exploration, so I am happy if works for you but also surprised!

Yeah, it works for me very well, and the bazel-like output is very nice when I'm waiting on long builds of llvm. Thanks!

Cool!  I used it for months at my last job but I haven't had reason to run it recently.  Lemme know if you have any feature requests, I guess :P

Also man I just tried out LLVM, this is even on an M2:


windows v.0.1.2 error when trying to run ardublockly_run.bat

Downloaded most recent v. of ardublockly, but when trying to run the "pre-packaged" executable I repeatedly encounter an error.
Restarting and all basic fixes have been tried. After I close the error message, the program runs but all of the GUI is does not appear.
The core version will open in Chrome but the GUI is totally unresponsive. Have I forgotten to do something?....I thought this file after extraction was meant to be self-enclosed.
Any suggestions would be greatly appreciated, thanks!

It shows up as a JavaScript error. I tried re-extracting, and extracting the folder within the arduexec folder. As well as replacing the arduexec/server folder from the last build. Still no dice.

Even the last build v.1.1 isnt running. Please help.

If you can copy the error here I can then try to investigate?
I would also need the contents of the ardublockly.log file, so if you could upload it somewhere or copy it here it would be quite useful.

Hi carlos,
Below is the info you asked for. Hopefully this clarifies the issues some.
Thank you so so much!
ardublockly.txt

Could you confirm that the arduexec\server\start.exe file exists and that
you can execute it successfully? It should open a command line window with
some information and automatically open your default browser pointing to
the Ardublockly web interface. If it does open correctly, could you copy
and paste the contents of the console here as well?
Thanks,
Carlos
On 2 November 2016 at 13:19, Simsmzzms<EMAIL_ADDRESS>wrote:

Hi carlos,
Below is the info you asked for. Hopefully this clarifies the issues some.
Thank you so so much!
ardublockly.txt
https://github.com/carlosperate/ardublockly/files/566617/ardublockly.txt
[image: capture]
https://cloud.githubusercontent.com/assets/23213062/19930129/e75aacde-a0fe-11e6-8772-896bf8c1c646.PNG
[image: n]
https://cloud.githubusercontent.com/assets/23213062/19930131/e9160fdc-a0fe-11e6-8b46-05209cbb5047.PNG
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/carlosperate/ardublockly/issues/128#issuecomment-257861618,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD_sTuFb5gsWBiLXXvUxmwacO1GpK2tgks5q6I3_gaJpZM4KnJYf
.

@ C:\ardublockly\arduexec\server                  no start.exe file exists
Within that there is a folder called library which i've extracted. Is the start.exe file located in here?
Otherwise what are your suggestions? Thanks again.

what scripts should be contained? I can try and make my own

These are the contents from the zip file downloaded from the github releases link:

There should not be any need to rebuild the python server. Could you try to download the zip file and try again?

Hi Carlos, sorry for the delay, I've done what you said and have managed to locate/execute the start.exe within the arduexec\server folder. Below are the contents of the console. Once again thank you so much, I'm excited to start utilizing this implementation.

No need to further assist, everything is working wonderfully at this point. Its great!

Glad you git it working @Simsmzzms!


Add-NewLJOBsToServerProfile.ps1 return MethodException: Cannot find an overload for "new" and the argument count: "4".

Add-ExistingLJOBToServerProfile.ps1 return : MethodException: Cannot find an overload for "new" and the argument count: "4".
Version Information
$PSLibraryVersion

synergy.obs.hpecic.net              LibraryVersion Path
----------------------              -------------- ----
ApplianceVersion: <IP_ADDRESS>9867.00 5.20.2422.3962 /root/.local/share/powershell/Modules/HPOneView.520/5.20.2422.3962

Output from $PSVersionTable
Name                           Value
----                           -----
PSVersion                      7.0.2
PSEdition                      Core
GitCommitId                    7.0.2
OS                             Linux 4.18.0-147.8.1.el8_1.x86_64 HewlettPackard/oneview-powershell-samples#1 SMP Thu Apr 9 13:49:54 UTC 2020
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This is caused by the internal PowerShell class .stor not being named correctly.  And is now fixed.


Fix protobuf includes

Tested and working on M2 Mac with brew install protobuf.
Should fix #214

Tests are currently failing due to missing protobuf.

Looks like the Ubuntu build is failing because of strict checks on proto 3 syntax. I think the thing it's complaining about was fixed in later versions of the proto compiler, where optional is supported for proto 3 files.
Maybe it's because we're using an old image of Ubuntu (to get around the latest issue with incompatible clang and stdc++).

Thanks for this! I was able to build with these changes, combined with  @hongmindavidkim's comment: https://github.com/google-deepmind/mujoco_mpc/issues/214#issuecomment-1797847399
Here's the full diff I used:
diff --git a/mjpc/CMakeLists.txt b/mjpc/CMakeLists.txt
index e8e4dd3..f8d1206 100644
--- a/mjpc/CMakeLists.txt
+++ b/mjpc/CMakeLists.txt
@@ -24,8 +24,8 @@ target_link_libraries(
 )
 target_include_directories(threadpool PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/..)

-set(_PROTOBUF_LIBPROTOBUF libprotobuf)
-set(_PROTOBUF_PROTOC $<TARGET_FILE:protoc>)
+find_package(Protobuf REQUIRED)
+include_directories(${Protobuf_INCLUDE_DIRS})

 get_filename_component(agent_state_proto "./agent_state.proto" ABSOLUTE)
 get_filename_component(agent_state_proto_path "${agent_state_proto}" PATH)
@@ -36,11 +36,12 @@ add_custom_command(
   OUTPUT
   "${agent_state_proto_srcs}"
   "${agent_state_proto_hdrs}"
-  COMMAND ${_PROTOBUF_PROTOC}
+  COMMAND ${Protobuf_PROTOC_EXECUTABLE}
   ARGS
   --cpp_out "${CMAKE_CURRENT_BINARY_DIR}"
   -I "${agent_state_proto_path}"
   "${agent_state_proto}"
+  --experimental_allow_proto3_optional
   DEPENDS
   "${agent_state_proto}"
 )
@@ -52,7 +53,7 @@ add_library(agent_state_proto_lib STATIC

 target_link_libraries(
   agent_state_proto_lib
-  ${_PROTOBUF_LIBPROTOBUF}
+  ${Protobuf_LIBRARIES}
 )

 add_library(
@@ -169,7 +170,7 @@ target_link_libraries(
   lodepng
   mujoco::mujoco
   mujoco::platform_ui_adapter
-  ${_PROTOBUF_LIBPROTOBUF}
+  ${Protobuf_LIBRARIES}
   threadpool
   Threads::Threads
 )
@@ -192,7 +193,7 @@ target_link_libraries(
   agent_state_proto_lib
   libmjpc
   mujoco::mujoco
-  ${_PROTOBUF_LIBPROTOBUF}
+  ${Protobuf_LIBRARIES}
   threadpool
   Threads::Threads
 )
diff --git a/mjpc/agent.cc b/mjpc/agent.cc
index 7b6cc5b..898ea5f 100644
--- a/mjpc/agent.cc
+++ b/mjpc/agent.cc
@@ -250,12 +250,12 @@ agent_state::State Agent::GetAgentState(mjModel* model, mjData* data) {
     if (absl::StartsWith(numeric_name, "residual_select_")) {
       std::string_view name =
           absl::StripPrefix(numeric_name, "residual_select_");
-      (*task_parameters)[name].set_selection(mjpc::ResidualSelection(
+      (*task_parameters)[std::string(name)].set_selection(mjpc::ResidualSelection(
           agent_model, name, ActiveTask()->parameters[shift]));
       shift++;
     } else if (absl::StartsWith(numeric_name, "residual_")) {
       std::string_view name = absl::StripPrefix(numeric_name, "residual_");
-      (*task_parameters)[name].set_numeric(ActiveTask()->parameters[shift]);
+      (*task_parameters)[std::string(name)].set_numeric(ActiveTask()->parameters[shift]);
       shift++;
     }
   }

I'm still having problems when trying to build the gRPC together with the main mjpc binary (as seen in the failing tests). I'll try to look into fixing this early next week.

I was able to use this fix to get things working on Mac-M3 today.
Do we have any update for Ubuntu?

@hartikainen I think the issue is fixed, please reopen if closing is a mistake.


Refactor science data

Move plotting to mixins

Codecov Report

Merging #13 (5b7908a) into master (125d3c7) will decrease coverage by 3.05%.
The diff coverage is 44.92%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   59.80%   56.74%   -3.06%
==========================================
  Files           8        8
  Lines         505      615     +110
==========================================
+ Hits          302      349      +47
- Misses        203      266      +63

Impacted Files
Coverage Δ

stixpy/science.py
52.59% <38.14%> (+11.44%)
:arrow_up:

stixpy/timeseries/quicklook.py
67.95% <66.12%> (-1.47%)
:arrow_down:

stixpy/net/client.py
32.35% <0.00%> (-67.65%)
:arrow_down:

stixpy/net/attrs.py
57.14% <0.00%> (-28.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125d3c7...5b7908a. Read the comment docs.

Codecov Report

Merging #13 (44d9a8b) into master (125d3c7) will decrease coverage by 0.28%.
The diff coverage is 46.74%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   59.80%   59.51%   -0.29%
==========================================
  Files           8        8
  Lines         505      615     +110
==========================================
+ Hits          302      366      +64
- Misses        203      249      +46

Impacted Files
Coverage Δ

stixpy/net/client.py
32.35% <ø> (-67.65%)
:arrow_down:

stixpy/science.py
57.49% <40.70%> (+16.33%)
:arrow_up:

stixpy/timeseries/quicklook.py
68.50% <66.12%> (-0.92%)
:arrow_down:

stixpy/net/attrs.py
57.14% <0.00%> (-28.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125d3c7...44d9a8b. Read the comment docs.


OpenShift CodeReady Containers on Mac Sonoma 14.5

Hi Team
Please, I'm trying to run OpenShift CodeReady Containers locally on my Mac(Sonoma 14.5)
CRC version: 2.36.0+27c493
OpenShift version: 4.15.12
Podman version: 4.4.4
I receive the following errors after running crc start :
err : ssh: handshake failed: read tcp <IP_ADDRESS>:49921-><IP_ADDRESS>:2222: read: connection reset by peer
...
couldn't get current server API group list: Get "https://api.crc.testing:6443/api?timeout=32s": dial tcp
connect: connection refused
The connection to the server api.crc.testing:6443 was refused - did you specify the right host or port?
...
level=debug msg="SSH command results: err: Process exited with status 3, output: ○ ovs-configuration.service - Configures OVS with proper host networking configuration\n     Loaded: loaded (/etc/systemd/system/ovs-configuration.service; enabled; preset: disabled)\n     Active: inactive (dead)"
...

My complete ˜/.crc/crc.log file :
crc.log

@ericomtx Can you use the issue template and file this issue again because with this details we are not sure how to reproduce. Also log file which you shared only have temp error.