Limited docker exec concurreny

I'm using serverspec to test docker images (executing shell commands via exec ) and running each image in a parallel test. If i execute more then 6 parallel tests these tests are getting slower and slower.
Also docker stats isn't reliable anymore because all values are displayed as dashes instead of values.
Serverspec is using the docker-api gem.
I've tried to build a small quick&dirty testcase and gatherd as much information i was able to get:
https://github.com/mblaschke/docker-api-stresstest
docker info, docker version and server specs are included.
Maybe it's related to #13885 but the Docker daemon is still responding. But it's still limiting the execution requests. While testing there were no cashes or other problems just a limited concurrency to about 20 executions per second with a very low system load on the machine.

ping @mlaventure @crosbymichael @unclejack PTAL


chore(main): release 1.3.2

:robot: I have created a release beep boop
1.3.2 (2023-11-29)
Bug Fixes

Make default classification_level "Internal" str (#14) (fa02ee9)

Other

Add security md from template (#15) (4042db3)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/equinor/atmos-validation/releases/tag/v1.3.2 :sunflower:


RDS (Aurora) support

Hello again Max! Once again, congratulation for this amazing construct.
According to the Bedrock's UI and boto3 documentation, Amazon Bedrock now supports creating a knowledge base with Aurora as a vector database option. My team wants to try Aurora to deploy a knowledge base, so I'm wondering if you want to support Aurora in this construct.
I did actually fork this repo to start implementing the option in TypeScript to submit a PR here. Luckily, I saw that it's kinda simple (and smart): Just some interfaces and a Lambda that creates the Knowledge Bases (and Agents) via boto3.
However, I checked the changelog of boto3 and, as expected, the support for Aurora is pretty new.

And I think this is the current boto3 version of the layer:

So I was wondering if you are willing to accept a PR from me with the Aurora support and an upgrade of the boto3 layer to get this new change because I'd love to contribute, if you agree of course.

Hi @merojosa , I did see the updates but am a little strapped on time with day-to-day job so I didn't have time to make any updates. But I would be glad to accept your PR, as long as you promise you've tested it out 🙂

You got it @maxtybar. I'll make sure the new changes work and that they don't break anything.
Two questions before submitting the PR:

Do you have the command and the requirements.txt to generate the layer? I'm seeing other dependencies (awscli, opensearchpy, etc...) apart from the ones that are generated by boto3. I just want to keep everything exactly as it is, except for the boto3 upgrade.
I've never used projen, but I'm guessing the GitHub actions generate automatically the Go and Python packages based on the custom constructs in TypeScript. Is that correct, or should I update the Go types in bedrockagentscdk or something else to package the Go and Python constructs?

I do not have any other requirements. To be honest with you, I created this layer a while back for multiple projects, zipped it and then reused it in multiple places. I would assume if you unzip it and then substitute boto3 folder there that should do the deal.
I run yarn build in the root directory and it will build everything, including API documents and it will transcpile TypeScript to Python and Go as well. And then you just push it GitHub and after PR it should update packages in NPM, PyPi and Go repositories through GitHub actions.


Image is not showing

In:
https://dantecalderon.com/variables-en-css

Thanks, I'm solving my own problems. :smile_cat:


deps: move @carbon/react and @carbon/styles back to 1.27

Revert Carbon version back to 1.27 until https://github.com/carbon-design-system/carbon/issues/13725 is fixed.
Check that search box styles are correct.

@francinelucca can you take a quick look today so we can hopefully get this merged / deploy tomorrow 🙏


Higher order functions for comparison

A couple of higher order functions for comparators. Use cases
Compare primitive types
use Functional\comparator;

$list = [10, 20, 1, 0];

usort($list, comparator());

Compare objects
use Functional\object_comparator;

$list = [new stdClass(), new stdClass()];

usort($list, object_comparator());

Compare objects with a reducer
use Functional\object_comparator;
use Functional\invoker;

class V {
    private $o;

    public function __construct($o) {
        $this->o = $o;
    }

    public function getO() { return $this->o; }
}

$list = [new V(new stdClass()), new V(new stdClass())];

usort($list, object_comparator(invoker('getO')); // Will call getO() before comparing

Looks good to me modulo nomenclature:

comparator sounds way more generic than it actually is. strnatcasecmp is highly idiosyncratic, and it's nowhere hinted (source doesn't count) that comparator follows the same behaviour, or that reducer should comply to it.
object_comparator() would be better as object_hash_comparator().
object_comparator(invoker('get0')) would be better as compare_on(object_hash_comparator, invoke_method('get0') (where compare_on(op, f)(x, y) = op(f(x), f(y))). Which would also allow for cases where you don't want to compare the outcome by hash :3

what about comparator(callable $reducer, callable $compare = 'strnatcasecmp')?
Agreed
If you don't want to compare by hash, just do comparator(invoker('getScalar')). But I like how compare_on reads.

I'm not sure that strnatcasecmp a sane and natural default does make. 💂
Thanks :beer:
Fair enough. From the doc it seemed to me that I should be using invoker with object_comparator whenever the input is an object, when what actually matters is the output of the method :3


[Bug]: Sliding when adding a row to a Google Sheets sheet

Is there an existing issue for this?

[X] I have searched the existing issues

Description
A user reported that when adding new rows to their Goggle Sheets, the data shifts one column to the right.
I have tested to determine the cause of this problem and noticed that this situation occurs when there are previous empty columns. In the case of the user, column A of the sheet was empty causing that, when adding data in a new row, it would start from column C and not from column B (as it should be).
Steps To Reproduce

Create a test Google Sheets sheet and set it up as shown in the image below:

In an Appsmith app, set Google Sheets as the data source and create an Insert One query to add rows to the sheet.

Run the query and see that the row has been successfully added to the sheet.

Now modify the sheet by inserting a column to the left, i.e., column A should be left empty.

Run the same query above and notice that the row has been added to the sheet but shifted to the right.

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud

This is expected


Could not load file or assembly WebActivatorEx

Installing SquishIt version <IP_ADDRESS> via NuGet gives the following exception at runtime:
Could not load file or assembly WebActivatorEx, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7b26dc2a43f6a0d4 or one of its dependencies. The system cannot find the file specified.
The dependency WebActivator (≥ 1.4.0) as shown on (this page) isn't there in NuGet's UI and thus not added.

Ugh.  The original WebActivator package was de-listed.  I will need to test with v2 and make sure everything works, i'll try to get <IP_ADDRESS> out soon I guess.  Kind of frustrating that it won't allow installation once it is de-listed, wonder how many other projects that breaks.

If you install WebActivatorEx v2.0 does it work?

Sorry, didn't check that, reverted to previous SquishIt right away.

So there are no hard references to WebActivator anywhere (there will be in v1.0)
Guessing it is probably related to this file that gets transformed by nuget: https://github.com/jetheredge/SquishIt/blob/a00720b09fdd42920aa723944cb2ae1f58507c72/SquishIt.Less/Content/App_Start/SquishItLess.cs.pp
You reverted via git checkout (or similar) right?  I would expect the problem to occur regardless of version if you install the preprocessor package after the date WebActivator was delisted.
So if you install/update a preprocessor and experience this problem, I'm guessing the fix will be to install WebActivatorEx on its own.  I will update it in future packages once I am done cursing nuget for this.

I reverted by installing the previous SquishIt version on NuGet.
The reason this exception occurred is because of Umbraco (CMS). The Boot manager of Umbraco registers plug-ins and scans all assemblies in the AppDomain. During this scan any non-resolvable references throw an exception.

Huh, I wouldn't expect the previous version to work either.  You are using SquishIt.Less right?  It has always referenced WebActivator (not EX).
Anyway you can try this: https://www.nuget.org/packages/SquishIt.Less/<IP_ADDRESS>-beta1

No I'm talking about the regular SquishIt package. I'm sure it had a
dependency to WebActivator :-/
Op 5 jan. 2016 om 23:26 heeft Alex Ullrich<EMAIL_ADDRESS>het
volgende geschreven:
Huh, I wouldn't expect the previous version to work either. You are using
SquishIt.Less right? It has always referenced WebActivator (not EX).
Anyway you can try this:
https://www.nuget.org/packages/SquishIt.Less/<IP_ADDRESS>-beta1
—
Reply to this email directly or view it on GitHub
https://github.com/jetheredge/SquishIt/issues/327#issuecomment-169153871.

Nah, it shouldn't.  v1.0 will, but <IP_ADDRESS> doesn't have any dependency on WebActivator (hard or soft).
I'll try to look into this some more tomorrow but I don't see where that message would've come from unless you were using a preprocessor.

Sorry for the large screenshot and Dutch language ;-)

Opening the assembly in ILSpy:

This is weird, looks like a 1.0 assembly got pushed with the old package definition.  Thanks for pointing this out - I pulled <IP_ADDRESS> and am working on resolution now.

Just pushed <IP_ADDRESS>, it should solve the problem.  Thanks again for pointing this out!


Change base, gutter and columns settings and refresh layout

How can we change gridly settings after initialization?
For now I have created an override:
Gridly.prototype.refresh = function(params) {
    if (params.length === 1) {
        $.extend(this.settings, params[0]);
    } else if (params.length === 2) {
        this.settings[params[0]] = params[1];
    }
    var b = this.settings.base;
    this.$('> *').width(b).data('width', b).height(b).data('height', b);
    return this.layout();
};

Then my code looks like this
// base settings
var brickWidth = 250;
var gutter = 10;

// get initial gridly settings
var gridly = $.extend(true, {}, getGridlySettings(), {
    callbacks: {
        reordered: reorderImages
    }
});

// dynamically resize images
$('.gridly .brick').width(gridly.base).height(gridly.base);

// initialize gridly
$('.gridly').gridly(gridly);

// refresh gridly
function refreshGridly() {
    $('.gridly').gridly('refresh', getGridlySettings()); // <====== HERE
}

// get calculated gridly settings
function getGridlySettings() {
    var gridWidth = $('.gridly').width();
    var columns = Math.round(gridWidth / (brickWidth + gutter));
    var base = Math.round((gridWidth - (gutter * columns)) / columns);
    return {
        base: base,
        gutter: gutter,
        columns: columns
    };
}

$(window).resize(function(){
    // buffer execution by 50ms
    // this way we dont do multiple resizes
    // if user keeps resizing browser window
    clearTimeout(timeout);
    timeout = setTimeout(refreshGridly, 50);
});

I know this is old, but you solved an issue I was having. Thanks @HriBB !

The code above works fine although it makes all bricks the same size. I came up with a slightly different solution based on yours:
`//Gridly
var gBase = 60, gGutter = 20, timeout; //Gridly settings and refresh timeout
    //Reload gridly
    function refreshGridly() {
        var lastGridly = $('.gridly').clone();

        lastGridly.removeAttr('style');
        $('.gridly-container').empty().append(lastGridly);

        $('.gridly').gridly({
            base: gBase,
            gutter: gGutter,
            columns: Math.floor($(window).width() / (gBase + gGutter))
        });
    }

    $(window).resize(function(){
        clearTimeout(timeout);
        timeout = setTimeout(refreshGridly, 50);
    });`

This basicalle clones the current Gridly and restarts it keeping the brick "small" and "large" sizes.

The code above works fine although it makes all bricks the same size. I came up with a slightly different solution based on yours:
        //Gridly
        var gBase = 60, gGutter = 20, timeout; //Gridly settings and refresh timeout

        //Reload gridly
        function refreshGridly() {
            var lastGridly = $('.gridly').clone();

            lastGridly.removeAttr('style');
            $('.gridly-container').empty().append(lastGridly);

            $('.gridly').gridly({
                base: gBase,
                gutter: gGutter,
                columns: Math.floor($(window).width() / (gBase + gGutter))
            });
        }

        $(window).resize(function(){
            clearTimeout(timeout);
            timeout = setTimeout(refreshGridly, 50);
        });

This basicalle clones the current Gridly and restarts it keeping the brick "small" and "large" sizes.

elegant, but simple. thanks!


Empty table cells not resepecting cellContent

Here is a reproduction:
The document contains 1 empty list item and 1 empty table cell.
The empty list item is filled with a paragraph. ✅
The empty table cell is not filled with a paragraph ❌
https://codesandbox.io/s/prosemirror-table-cell-content-jxiev?file=/src/index.js

I think this is related:
If you parse:

It should result in:

Given:  content: "table_row+"


help for contributing

Hi,
I started to read the code so I can contribute,
I want to work on adding pagination for the project, but there is some part of the code I don't understand.
could you help me understand?
in FilterItems.ts, was is the difference between "getFiltered" and "getFilteredOut"?
and in Filterizr, why is there a "require" among the "import"? (require('imagesloaded')) how can this work in browser?

note : the bug label was automatically added because there is only a single template to choose to create issue, not because this is a bug.

@xileftenurb fixed the bug label, good catch with the templates, I'll add a couple more for different use cases.
In FilterItems.ts, getFiltered returns the items that should be visible in the screen with the currently active filter applied (e.g. if the user has activated a filter for a category named "fruit", then all items in the grid that belong to the "fruit" category will be returned from getFiltered). The getFilteredOut function, does the exact opposite. It returns every item that does NOT belong to the "fruit" category which should be hidden.
These methods are used by the render method in the Filterizr class (in Filterizr.ts) to handle rendering the grid (and they probably need better names seeing the confusion).

As to why there is a require among the import statement.. it has to do unfortunately with the imagesLoaded package not supporting es6 module imports/exports... why it works is that at the end of the day webpack takes care of transforming everything to UMD compatible modules (check the webpack config).

Why can't filterizr run in Select


🎨 Run biome after OpenAPI client generation

Since Hey API's openapi-ts CLI --format flag doesn't work (and is completely removed in newer versions), "manually" run biomi to correctly format the auto-generated code.
Note that at times the default formatting is completely broken (see schemas.ts as an example), and at times it's inconsistent (see  OpenAPI.ts as an example).

Cool! Thank you @tomerb :sunglasses:


Cannot compile dynamic shape MLP on vulkan/spir-v

mlp_reproducer_vulkan.mlir.txt
Local reproducer attached. Once the next PR goes in, this can be tested e2e by enabling the vulkan backend in the dynamic_mlp_test.py file.

At first glance, this seems to be because we are missing a lowering for ranked_broadcast_in_dim, which was on my list somewhere and I forgot about it.

Also, yay for local reproducers. So much easier to isolate!

Thanks Stella for the repro! I did a run with it and here is the immediate failing input IR:
// *** IR Dump Before mlir::iree_compiler::(anonymous namespace)::ConvertHLOToLinalgOnBuffersPass ***
func @predict_ex_dispatch_1() {
  %c0 = constant 0 : index
  %0 = hal.interface.load.constant offset = 1 : index
  %1 = shapex.make_ranked_shape %0 : (index) -> !shapex.ranked_shape<[?,256]>
  %2 = hal.interface.load.constant offset = 0 : index
  %3 = shapex.make_ranked_shape %2 : (index) -> !shapex.ranked_shape<[?,256]>
  %4 = hal.interface.load.tensor @legacy_io::@arg1, offset = %c0 : tensor<256xf32>
  %5 = hal.interface.load.tensor @legacy_io::@arg2, offset = %c0 : tensor<?x256xf32>
  %6 = shapex.tie_shape %5, %1 : tensor<?x256xf32>, !shapex.ranked_shape<[?,256]>
  %7 = "shapex.ranked_broadcast_in_dim"(%6, %3) {broadcast_dimensions = dense<[0, 1]> : tensor<2xi64>} : (tensor<?x256xf32>, !shapex.ranked_shape<[?,256]>) -> tensor<?x256xf32>
  %8 = shapex.tie_shape %7, %3 : tensor<?x256xf32>, !shapex.ranked_shape<[?,256]>
  %9 = "shapex.ranked_broadcast_in_dim"(%4, %3) {broadcast_dimensions = dense<1> : tensor<1xi64>} : (tensor<256xf32>, !shapex.ranked_shape<[?,256]>) -> tensor<?x256xf32>
  %10 = shapex.tie_shape %9, %3 : tensor<?x256xf32>, !shapex.ranked_shape<[?,256]>
  %11 = linalg.generic {args_in = 2 : i64, args_out = 1 : i64, indexing_maps = [affine_map<(d0, d1) -> (d0, d1)>, affine_map<(d0, d1) -> (d0, d1)>, affine_map<(d0, d1) -> (d0, d1)>], iterator_types = ["parallel", "parallel"]} %8, %10 {
  ^bb0(%arg0: f32, %arg1: f32):  // no predecessors
    %13 = addf %arg0, %arg1 : f32
    linalg.yield %13 : f32
  }: tensor<?x256xf32>, tensor<?x256xf32> -> tensor<?x256xf32>
  %12 = shapex.tie_shape %11, %3 : tensor<?x256xf32>, !shapex.ranked_shape<[?,256]>
  hal.interface.store.tensor %12, @legacy_io::@ret0, offset = %c0 : tensor<?x256xf32>
  return
}

@stellaraccident ping to see if this is a spirv/vulkan specific issue. If the ranked_broadcast_in_dim lowering somewhere could use that. (have a better understanding now of the shape dialect stuff, so I can take a stab at this.)

Obsolete?

I think this is working now. Can re-open if recurs (it should come up organically with other work at this point).


[W5.11][F09-2]Ang Wei Ming

Command to find person using tags
Parameters: KEYWORD [MORE_KEYWORDS]...
Example: findtag friends owesMoney

Good job! I have noticed you have made your tag case-sensitive, is there a particular reason why you did that? I was thinking wouldn't it be more convenient for finding persons if you made the tag case-insensitive?

Comments:

Great use of OOP and using the existing 'find' command to create 'findtag'
User guide updated, reflecting the changes
Set up test cases on input.txt and expected.txt

Possible Improvement:

Create a java test cases file for IntelliJ


Thread Creation adds to DiscordModel

Creating a Thread using the discord command should add the created thread to the DiscordModel.

Thread is first loaded to sql then loaded into discordmodel


Create tabular_parser

Add support for reading CSV data

The reader still needs to be added to base.py, I'll take care of doing it if this reader is acceptable

Debated adding excel reader, but first want to know if this CSV reader is acceptable


Issue Report: Inconsistent rod production for thermal series materials

Modpack version: 1.20.1 DELTA HOTFIX 4
Minecraft version: 1.20.1
Is on server: No
Modifications done: None
Description: Only 1 rod per ingot from Lathe for all thermal series materials. Only 1 rod per long rod from Cutter for all thermal series materials.
Details
See screenshot for an example:

This affects the following materials: soul infused, signalum, lumium, enderium, shellite, twinite, dragonsteel, melodium, and stellarium.
This is likely to be unintended behavior for 2 reasons:

Extrude the material into long rod with an Extruder (1 long rod per ingot) and then cutting the long rod using the Crafting Table recipe (2 rods per long rod) will produce 2 rods.
All other materials will produce 2 rods per ingot from lathe.

Know issue, will be patched in Epsilon, thank for you the post


getAppVersion never finds anything

There is an error in the mdfind command in the getAppVersion function.
The applist variable should be defined like this:
applist=$(mdfind "kMDItemFSName='$appName' kMDItemKind='Application'" -0 )
The double "&&" should be eliminated. At least on my system, it never finds any app.

fixed in e4e9aec0e2d39ee8cd148305dd4e52e7b913420f


some cli components can't be installed

REGISTRY_URL=https://jollyui.dev/r npx shadcn@latest add checkbox-group

Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.

Unexpected token '<', "<!DOCTYPE "... is not valid JSON

also happens with date-range-picker, datepicker, etc
also i see there are package manager copy options (yarn, bun, etc) which doesnt seem to be different (all copies npx)

Hi sorry for the issue!
Seems like I need to update the doc install links for some components, for example checkbox-group is just installed via checkbox.
Does appear to be another issue though with some components that are valid saying the registry is not valid json, e.g textfield.
As for the package manager copy options, these appear to be working for me. Is there a specific page or is it all of them for you?

The commands should be fixed now, and installing seems to okay for me. The copy commands all seem to work as well, but let me know if theres a specific one thats broken.
Reopen if anymore issues 😃


Clarify onMarkerClick arguments / best practice

I guess I really have two related requests

Clarify in the documentation what the argument passed to onMarkerClick is. I have looked at it in the console so I can find individual properties for it, but Im not sure if it is a custom class for this library, from the markercluster library, or from leaflet...?

How are people using this eventHandler? My use case is to display info for the location which was clicked, which means the knowledge of what has been clicked needs to be passed through, and this must be the case for most people using this function.

Currently I am passing through a custom locationId property to the marker 'options' object, which is then available as .options., but this feels unstable.
Is there an undocumented onClick property for the marker object that could be bound with the location's id?  Is there / could there be a user-data property that would be passed through? Could it be documented that custom marker.options properties will be passed through (thereby reassuring us that it is a stable api)

what the argument passed to onMarkerClick is
You should pass there function that will be invoked when user will click on marker
How are people using this eventHandler?
https://yuzhva.github.io/react-leaflet-markercluster/#event-listeners

invokeSpesificFunction() {
  console.log(marker, marker.getLatLng());
  // TODO:
}
render(
// ...
    <MarkerClusterGroup
      markers={markers}
      onMarkerClick={(marker) => invokeSpesificFunction(marker)}
    />
// ...
)

I dont think you read my questions at all...

was asking what argument is given to the onMarkerClick handler, not what I should pass as the onMarkerClick prop.  You show it in the above code as 'marker' but is it the leaflet marker instance?

I know how to use react, my question is how do you identify which of your business objects the marker object corresponds to?  You can compare the latlng, and that seems to be the way folks are doing it elsewhere, but that is not always going to be unique? Much preferable to be able to attach an id (which the code currently does, but using undocumented and therefore unstable features)


Fixed #25087 -- The proposal to allow the extend default permissions.

From discussion on https://groups.google.com/forum/#!topic/django-developers/Exaq5Nn4Ckg

I think we should try for an AppConfig attribute instead of a setting and also tests are missing.


Integrate user group management

We need to integrate the code provided in December 2017, the part related to having user groups.
The users belong to user groups, and the user groups have access to the different features of the tool (filtering URLs)
To be implemented after issue #5

To be implemented after issue #5

The user management is a feature not used so far. We will discuss the need of having user groups in the future


Android Preserve External Storage for Android 10+

See https://developer.android.com/training/data-storage/use-cases#opt-out-scoped-storage and https://developer.android.com/training/data-storage/use-cases#migrate-legacy-storage for more info.

By default, OpenFL and Lime save data in the folder returned by getFilesDir(). As far as I can tell from the documentation, this folder will remain accessible.
If you've stored data in other folders and you need these settings to make sure you can access that data, you can enable them from project.xml:
<config:android>
	<application android:requestLegacyExternalStorage="true" android:preserveLegacyExternalStorage="true" />
</config:android>

I might be missing something, but I don't see why these would need to be built in to Lime.

Oh, I didn't know sorry closing up this rn

No problem. This is still an undocumented feature for now, so you'd have to have been paying very close attention to the PRs to be aware of it.
We'll release proper documentation once Lime 8.2.0 comes out.


readasbinarystring not working with ie11

I had to change it to readasarraybuffer and then move to buffer to string. Is there a better way to do it?
   } else if(path instanceof Event) {
        // console.log("event");
        var files = path.target.files;
        var reader = new FileReader();
        var name = files[0].name;
        reader.onload = function(e) {

			var data = e.target.result;
            success(ArrayBufferToString(data));
        };
        reader.readAsArrayBuffer(files[0]);

    } else if(path instanceof Blob) {
    	success(path);
    }
}

};
function BinaryToString(binary) {
var error;
try {
    return decodeURIComponent(escape(binary));
} catch (_error) {
    error = _error;
    if (error instanceof URIError) {
        return binary;
    } else {
        throw error;
    }
}

}
function ArrayBufferToString(buffer) {
return BinaryToString(String.fromCharCode.apply(null, Array.prototype.slice.apply(new Uint8Array(buffer))));
}

Hey - thanks for reaching out...
I cant find readAsArrayBuffer in the code: https://github.com/agershun/alasql/search?utf8=✓&q=readAsArrayBuffer
Would love if you could give som inputs about where you suggest the changes?
Do you have some code that fails so we can put it into a test?

Hi @touletan
I have a feeling this question is related to another repo
If not please reopen this post and let me know where the issue is located


Setting ForegroundColor not working in macOS Terminal app

System Details

posh-git version/path: 1.1.0
PowerShell version: 7.2.2
Git version: 2.36.0
Operating system name and version: macOS 12.3.1

Issue Description
I've added the following snippet from the README to my PowerShell profile to set the default prompt color, but it doesn't seem to have any effect.
$GitPromptSettings.DefaultPromptPath.ForegroundColor = 0xFFA500

Interestingly, it does change the color to orange as expected when running in the VSCode integrated terminal:

Try setting to a standard console color, e.g.
$GitPromptSettings.DefaultPromptPath.ForegroundColor = 'Orange'`

Not all shells support all the ANSI color options.

Thanks. Still getting no effect with the line of code you provided. Interestingly, if I set the foreground color to 'LightGreen', I get a semi-transparent prompt...

Tried this on my macbook pro and the Apple terminal doesn't seem to work with the VT extended foreground colors.  On my Windows machine, in Windows Terminal, it works as expected:

Check out this Apple thread on lack of 24-bit color support.  In the mean time, try this:
$GitPromptSettings.DefaultPromptPath.ForegroundColor = "`e[38;5;172m"

To see all 256 colors available, try this:
1..255 | Foreach-Object { "`e[38;5;${_}m Color index ${_}`e[39m" }

This feels like an artifact of the terminal configuration more so than a posh-git issue, if changing to different colors at least produces a different result. Not sure how else to advise.

Seems like an "external" issue and could be closed.


PCM-1522 fixed updateOutgoingMedia() to allow  media request params

Codecov Report

Merging #459 (fc51e4b) into v6-beta (657dfed) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           v6-beta      #459   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           12        12
  Lines         1304      1306    +2
  Branches       278       280    +2
=========================================
+ Hits          1304      1306    +2

Impacted Files
Coverage Δ

src/client.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657dfed...fc51e4b. Read the comment docs.

Can you add a test for this please?


🛡 Improve Sass Task + Update NPM Modules

Sass task is broken and it breaks for simple errors. The new gulp-sass has better error handling. Moreover, the styles task is quite bulky and needs its dependencies to be updated as well.

[x] node-sass udpate
[x] Better Error handling for Sass
[x] Update related modules
[x] New configurable settings

Fixed via 94d9724ed96db38d84b0c7982ccaa07e8ec5f2f7


Implement CD workflow

This PR implements a simple CD workflow that would use our build-rust-action and release-action to automatically generate a release each time a tag is pushed.
Here is the end result:

Currently always runs on ubuntu-latest and builds for the next targets:

x86_64-unknown-linux-gnu
aarch64-unknown-linux-gnu
x86_64-apple-darwin
aarch64-apple-darwin
x86_64-pc-windows-gnu

Please note: In 1.82 version of Rust there is currently a regression, which causes zigbuild targeting macos to fail. That's why it's currently hardcoded to Rust version 1.81.

OpenAI suggests caching the .cargo directory to speed up the compilation: - name: Cache Cargo uses: actions/cache@v3 with: path: ~/.cargo key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}

Yes, caching is something I wanted to implement for number of things here, but since its not something critical (the timings are already pretty good), I wanted to first sync with Arto to see if there are some more important tasks for me to do.


Non accessible submodules

The following submodules are not accessible
https://github.com/potassco-asp-course/meta-encoding
https://github.com/potassco-asp-course/multi-shot-solving
https://github.com/potassco-asp-course/theory-solving
https://github.com/potassco-asp-course/heuristic-driven-solving

Where are https addresses used? I tried to avoid them, cf .gitmodules. Are you using ssh keyswhen usinggithub`?

Where are https addresses used? I tried to avoid them, cf .gitmodules.
They are used in .gitmodules.

Are you using ssh keys when using github?
I do.
Also, I wonder what is different with these 4 modules..?
SO I am a bit at a loss since I don't face this problem 😞
I cannot access those modules even in the browser.
If the url are correct, then I may not have access to them.
Are they public?

Jackpot! :1st_place_medal:  I'm so sorry, I forgot to make them public :disappointed:
I hope things work now that they are public.
BTW There are no https addresses for the modules in this organization. At least in the .gitmodules file I look at ... :confused: viz. https://github.com/potassco-asp-course/course/blob/main/.gitmodules

BTW, would you like to become a member of this organization..?

BTW, would you like to become a member of this organization..?

That would be great.
For a pull request, would you prefer that I create a new branch or that I make a fork. If the repository is public, it may make sense to use forks. That way, the working branches are private. What do you think?

Jackpot! 🥇 I'm so sorry, I forgot to make them public 😞
I hope things work now that they are public.
BTW There are no https addresses for the modules in this organization. At least in the .gitmodules file I look at ... 😕 viz. https://github.com/potassco-asp-course/course/blob/main/.gitmodules

When I enter I see 3 addresses with https:
https://github.com/krr-up/logos.git
https://github.com/krr-up/bibliography.git
https://github.com/krr-up/asp-macros.git

Yes, but these belong to another organization, viz krr-up, where they are public.
All "local" repos are just linked relatively.
So do these things work with you now..?

BTW, would you like to become a member of this organization..?

That would be great.

Will do at once

For a pull request, would you prefer that I create a new branch or that I make a fork. If the repository is public, it may make sense to use forks. That way, the working branches are private. What do you think?

I do not know ...


Provide an option to capture libvirt debug logs

Introduce a new option capture_libvirt_debug_logs in LibvirtPlatformSchema that tells LISA to capture libvirt debug logs during environment teardown.
Debug logs are enabled by using the log_outputs option in /etc/libvirt/libvirtd.conf. Here, we configure libvirt to write the debug logs to /var/log/libvirt/libvirtd.log.
We have been seeing multiple libvirt related errors in the pipeline and these logs can help in debugging those.
This is an opt-in feature since all users of libvirt platform might not be interested in debug level logs.

What was the problem with the current journalctl solution?

What was the problem with the current journalctl solution?

No problem. That is still the default.
For debug logs libvirt recommends using a file as destination since journald might throttle the amount of logs.
https://libvirt.org/kbase/debuglogs.html

@cwize1 @squirrelsc please do another round of review.


Work in Visual Studio

Will this work in Visual Studio as opposed to Visual Studio Code?  I sure would like it to.

This plugin will only work with visual studio code.
There should be similar plugins for visual studio as well.


chore: add licence header for some go files

Signed-off-by: shilinlee<EMAIL_ADDRESS>

What problem does this PR solve?

Issue Number: close #36
Problem Summary:
What is changed and how it works?
add licence header for some go files
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[x] No code

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features

Changelog category (leave one):

New Feature
Improvement
Bug Fix (user-visible misbehavior in official stable or prestable release)
Performance Improvement
Backward Incompatible Change
Build/Testing/Packaging Improvement
Documentation (changelog entry is not required)
Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
None

thx @shilinlee


CalcFields and CalcSums auto-complete/Intellisense stops working after the first two fields, i.e. broken on third onwards

Try typing this out. You'll see that the first two fields in each call offer autocomplete suggestions from the table, but the rest don't. Very irksome!
Please check if other functions are affected by this limitation too. Thanks :-)
codeunit 50100 Test
{
    trigger OnRun()
    var
        GLEntry: Record "G/L Entry";
        Customer: Record Customer;
    begin
        GLEntry.CalcSums(Amount, "VAT Amount", "Debit Amount", "Credit Amount");
        GLEntry.CalcSums("Debit Amount", "Credit Amount", Amount, "VAT Amount");

        Customer.CalcFields(Balance, "Balance (LCY)", "Balance Due", "Balance Due (LCY)");
        Customer.CalcFields("Balance Due", "Balance Due (LCY)", Balance, "Balance (LCY)");
    end;
}

Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 8.3.570094
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

@kalberes In what way is this not a bug? Is VS Code the problem, not the AL extension?

In every way it is a "bug" in the AL language server. The only change is that we may not mark issues as bugs.  Rather we would triage them, and if accepted we will fix them.  Nothing has changed but some terminology.

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 22.0.46839.0 and VS Code Extension Version 11.0.683951.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/

Thanks a mil!


fix: update syntax in readme for dataflow max workers

update to syntax, ref dataflow config for horizontal-autoscaling.

amended commit msg to meet conventional commit, this is ready for another pass. @vermas2012 fyi


Logic issues with GO:0034490 basic amino acid transmembrane import into vacuole -> GO:0051668 localization within membrane ?

Making a Noctua model (gomodel:5fce9b7300002015), and tried to make an annotation that a protein with the BP "basic amino acid transmembrane import into vacuole" occurs_in "fungal-type vacuole membrane".
Annotation Preview ended up showing an annotation to "localization within membrane". @vanaukenk looked into this a little and it seems like the logical definitions for GO:0034490 basic amino acid transmembrane import into vacuole may be a little off in order to let this turn into a localization term; the entity (L-arginine) is passed through the membrane but I would not say that it is localizing to the membrane.
if it helps, from my model:
basic amino acid transmembrane import into vacuole#5fce9b7300002034 | type | localization within membrane |
Asserted Triples

basic amino acid transmembrane import into vacuole#5fce9b7300002034 type basic amino acid transmembrane import into vacuole,
basic amino acid transmembrane import into vacuole#5fce9b7300002034 occurs_in fungal-type vacuole membrane#5fce9b7300002036,
fungal-type vacuole membrane#5fce9b7300002036 type fungal-type vacuole membrane

Rules

( ?x1 type localization ) ∧ ( ?x1 occurs_in ?x2 ) ∧ ( ?x2 type membrane ) → ( ?x1 type localization within membrane ),
( ?x1 type transport ) → ( ?x1 type establishment of localization ),
( ?x1 type fungal-type vacuole membrane ) → ( ?x1 type membrane ),
( ?x1 type amino acid transmembrane import into vacuole ) → ( ?x1 type transport ),
( ?x1 type establishment of localization ) → ( ?x1 type localization ),
( ?x1 type basic amino acid transmembrane import into vacuole ) → ( ?x1 type amino acid transmembrane import into vacuole )

Hi @suzialeksander
I dont think you can use occurs_in "fungal-type vacuole membrane".

did you try removing that ? I would suspect this is causing the 'location within membrane' assertion?

The logical definition of "basic amino acid transmembrane import into vacuole" is
'basic amino acid transport'
and ('has target start location' some cytosol)
and ('has target end location' some 'vacuolar lumen')
and (imports some 'amino acid')
and ('results in transport across' some membrane)
I wonder if, when there already is a CC in the logical definition of a BP, that doesn't cause weird results? In any event it seems to me the 'location within membrane'' is the result of your annotation occurs_in "fungal-type vacuole membrane" (this is also how I understand the explanation by the reasoner).
Thanks, Pascale

Hi @suzialeksander
I dont think you can use occurs_in "fungal-type vacuole membrane".

did you try removing that ? I would suspect this is causing the 'location within membrane' assertion?

The logical definition of "basic amino acid transmembrane import into vacuole" is
'basic amino acid transport'
and ('has target start location' some cytosol)
and ('has target end location' some 'vacuolar lumen')
and (imports some 'amino acid')
and ('results in transport across' some membrane)
I wonder if, when there already is a CC in the logical definition of a BP, that doesn't cause weird results? In any event it seems to me the 'location within membrane'' is the result of your annotation occurs_in "fungal-type vacuole membrane" (this is also how I understand the explanation by the reasoner).
Thanks, Pascale

can occurs_in "fungal-type vacuole membrane" be attached to the transporter instead ?(@suzialeksander I'm guessing that you are annotating a TM transporter here, because that part of the transport process does occur in the membrane)?

can occurs_in "fungal-type vacuole membrane" be attached to the transporter instead ?(@suzialeksander I'm guessing that you are annotating a TM transporter here, because that part of the transport process does occur in the membrane)?

@pgaudet (and actually @ValWood this answers your suggestion too) this was done in Form, so if this isn't an ontology issue maybe it's a Form problem? There doesn't seem to be an easy way to make this not be occurs_in unless I use CC Only Form at which point I lose the association with the F and P terms.
I don't know if @vanaukenk saw anything in particular when we were looking at this.

@pgaudet (and actually @ValWood this answers your suggestion too) this was done in Form, so if this isn't an ontology issue maybe it's a Form problem? There doesn't seem to be an easy way to make this not be occurs_in unless I use CC Only Form at which point I lose the association with the F and P terms.
I don't know if @vanaukenk saw anything in particular when we were looking at this.

I meant, the transport does not 'occur in' - it starts outside the membrane and ends outside the membrane. So, I think there is a logical inconsistency with our use of occurs_in "fungal-type vacuole membrane" for transport. Val might be right that the activity of the transporter should be OK to annotate with occurs_in "fungal-type vacuole membrane" . Have you tried that ?

I meant, the transport does not 'occur in' - it starts outside the membrane and ends outside the membrane. So, I think there is a logical inconsistency with our use of occurs_in "fungal-type vacuole membrane" for transport. Val might be right that the activity of the transporter should be OK to annotate with occurs_in "fungal-type vacuole membrane" . Have you tried that ?

I would  only use occurs_at when the MF. You can say where a specific activity occurs but  often the entire process is distributed and begins in another compartment or location.
Therefore you can't annotate a process with a precise location if the logical def specifies a broader start and end location. Logical violations will happen continually if occurs_at is allowed on process?

I would  only use occurs_at when the MF. You can say where a specific activity occurs but  often the entire process is distributed and begins in another compartment or location.
Therefore you can't annotate a process with a precise location if the logical def specifies a broader start and end location. Logical violations will happen continually if occurs_at is allowed on process?

That's probably right.

That's probably right.

Talking with @thomaspd
I will change the LD for 'localization within membrane'
from: localization
and ('occurs in' some membrane)
to: localization
and ('has target end location' some membrane)
Let's see if that helps.

We checked with @balhoff - this fixes the unexpected inference.


copy edits for post/29-js-ipfs-pubsub.md

Minor copy edits.
Consistent capitalization for pubsub (not PubSub)

cc @pgte


Collapse and expand grouped sections of data table

For example, if you had a Look like this:

You could define a measure to "expand" on to get something like this:

+1 Pelikan Travel


Fixing broken font checks

Hey,
I've fixed some more tests today. I just rebased these, since you just fixed the magiccode issue. It should all merge just fine. Please review each of these commits.
Refactored font version checks
I found your regex expressions to strip 'Version 1.007' -> '1.007' with comments to be faulty. It was hard to find due to the try and accept block. Instead of using regex.group(0), I've opted to use two different expressions with clearer syntax for each group.
Fixed Font names are consistent across platforms
The Windows names were not parsing correctly.
Is there any unused data at the end of the glyf table?
According to the MS Spec. The loca table is always 1 item higher than the glyf table.  https://www.microsoft.com/typography/otspec/loca.htm. I thought this was an error in FT but I was wrong, #663
pip requirements
I found the installation instructions on the README lacked dependencies. Imo, this is still not a perfect solution.
Cheers,
Marc

@felipesanches I think you might want to see this!

It all looks good. Thanks :-)


Can i use  RedisTokenStore to change the information of authentication

@planitian commented on Fri Nov 01 2019
After user login,Oauth2 store the authentication in redis. then i hava a demand that i want change the information of authentication that in redis. I can logout and login to change ,but  I think it is not  grace. so can i use  RedisTokenStore to change the information of authentication ?
I  find that RedisTokenStroe has public method that can read authentication,can store authentication,so it implies that I can read authtication first,and then change the authtication,finally store the authtication that i has changed.

Thank you very much. I have encountered a similar problem. I have dealt with it according to your thinking, and it has come into effect.

Yes. Those methods do what they say they do.


Progress bar for subdomain enumeration

Subdomain enumeration is so time consuming.
A progress bar can tell the user that things are moving.

Garud has progress bar in bash, maybe it deserves a look

@six2dez  :
Sorry Graus developers but the progress bar is fully static
check_xss() {
    echo -ne "${NORMAL}${BOLD}${YELLOW} ● Scanning is in progress:${NORMAL}${BOLD} Checking for xss in $domain [${GREEN}${BLINK}85%${NORMAL}] \r"

have you tried pv command?

Tried with shuffledns and other tools, but the results are not what I expected

can you share what command you tried?


⚠ Avatar API Endpoint has degraded performance

In 67eb66b, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 5096 ms

Resolved: Avatar API Endpoint performance has improved in 1571799 after 3 minutes.


[terra-button-group] Implemented border styles to buttons within the 'terra-button-group'.

Summary
Fixed- Implemented border styles for buttons within the 'terra-button-group'.
What was changed:
Implemented border styles for button focus.
Why it was changed:
Testing

This change was tested using:

[X] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-10077

Thank you for contributing to Terra.
@cerner/terra

Blue highlight still shows up on focus , I think we need to have only dashed outline for button on Focus.

No, Supreeth suggested to make changes for default and lowlight themes.


tests: lib: move the cmsis_dsp tests to new ztest API

Migrate the following  tests to the new ztest API:

tests/lib/cmsis_dsp/transform
tests/lib/cmsis_dsp/matrix
tests/lib/cmsis_dsp/filtering
tests/lib/cmsis_dsp/interpolation
tests/lib/cmsis_dsp/statistics
tests/lib/cmsis_dsp/support

Signed-off-by: Enjia Mai<EMAIL_ADDRESS>

Hi @stephanosio , I try to migrate these tests, could you please help to review this PR? Hope this could get a chance to be in 3.2, thank you!

Rebase it.


TestPiggyback test flakes

https://prow.istio.io/view/gs/istio-prow/logs/integ-pilot-cpp_istio_postsubmit/1766001749874708480
I don't think its a bug in the istioctl, but in the core xDS. If you look at the failure, the cluster does exist in the proxy but not others
relevant logs:
2024-03-08T07:30:01.836404Z     info    ads     Push debounce stable[290] 4 for config ServiceEntry/echo-2-81427/failover-eds-fake-locality.example.com and 2 more configs: 100.560991ms since last change, 124.959369ms since last push, full=true
2024-03-08T07:30:01.838793Z     info    delta   Timeout writing a-v1-756c876748-cc8pf.echo-2-81427-51
2024-03-08T07:30:01.839760Z     info    delta   CDS: PUSH for node:c-v1-7f97655fdb-l74fp.echo-2-81427 resources:18 removed:1 size:5.3kB cached:2/2
2024-03-08T07:30:02.547633Z     info    delta   ADS: "<IP_ADDRESS>:48580" a-v1-756c876748-cc8pf.echo-2-81427-51 terminated
2024-03-08T07:30:02.584707Z     info    delta   ADS: new delta connection for node:a-v1-756c876748-cc8pf.echo-2-81427-86
2024-03-08T07:30:02.589628Z     info    delta   CDS: PUSH request for node:a-v1-756c876748-cc8pf.echo-2-81427 resources:205 removed:1 size:200.7kB cached:188/188 filtered:0
2024-03-08T07:30:03.695294Z     info    ads     Push debounce stable[291] 4 for config ServiceEntry/echo-2-81427/failoverpriority-eds-fake-locality.example.com and 2 more configs: 100.839511ms since last change, 128.391648ms since last push, full=true
2024-03-08T07:30:03.697447Z     info    delta   CDS: PUSH for node:c-v1-7f97655fdb-l74fp.echo-2-81427 resources:18 removed:1 size:5.3kB cached:1/2
2024-03-08T07:30:03.699462Z     info    delta   CDS: PUSH for node:a-v1-756c876748-cc8pf.echo-2-81427 resources:18 removed:0 size:5.3kB cached:1/2

"a-v1" has extra cluster, "c-v1" does not

Played around with it a bit locally, cannot figure anything out. @ramaraochavali any ideas?

@howardjohn I think I have some clues and will try to fix the issue tomorrow. It's not related to istioctl but is related to an xDS inconsistent configuration.

After some investigation, I didn't find anything unusual in the cluster either, but found an inconsistency related to the listener, which is not related to the test failure mentioned above...

I found the issue, will work on a fix


ComponentDefinition type

Currently, there is no clean way to type check for a ComponentDefinition, e.g.:
{{validated-component someComponent=(component "some-component')}}

The (component) helper returns a CurlyComponentDefintion, which is a subclass of ComponentDefintion of the @glimmer/rutime package.
Ideally, I would like this API:
import Component from '@ember/component';
import { argument } from '@ember-decorators/argument';
import { type } from '@ember-decorators/argument/type';
import { ComponentDefinition } from '@ember-decorators/argument/types';

export default class ValidatedComponent extends Component {
  @argument
  @type(ComponentDefinition)
  someComponent;
}

However, I don't see an easy way to access the ComponentDefinition interface / class from the Ember world.

Definitely think this is something we should provide out of the box, also unsure of how we can do it (also, backwards compatibility. This may only be something we can guarantee in the Glimmer 2+ world if we can get ahold of that class)

Based on the validator refactor that I did in #90, I prototyped an implementation for this. While it doesn't do the "right thing" and actually receive the class from Glimmer to compare again, it does work! You can check out the commit above to see what I did; I'm going to hold off on making a pull request for it until #90 has been addressed.
One thing I also played with was going further and allowing you to validate more specific things about the component -- for example, what it is an instance of, or what arguments it expects! I think this is totally doable, I just need to come up with an API for describing those things that feels right.


Divide the types file

What do you think about dividing this into multiple files?
https://github.com/api3dao/airnode/blob/fd1fdf209ea22aba8b2bf980d4980011e850c955/packages/node/src/types.ts

I kinda like having everything in a single file, but yeah we can divide them up

I wanted to nudge you towards it in case you were already considering it. It's not really at the size that it's a problem. I'm closing this now, can be re-opened later.


Overview 页面在不停地请求静态资源

浏览器开发者工具截图：

刷新几次页面之后触发

I can confirm the issue. after refreshing the page it keep downloading the fonts endlessly.

没复现成功，有稳定的办法么

Can't reproduce this issue on my side, can we find a steady way to reproduce it?

even I can reproduce it on mobile immediately
open XD
open devtools
on XD open connections
open overview
refresh XD

是的，切换页面再刷新也可以复现。我这边现在直接在 Overview 页面刷新就出现这个情况了

https://github.com/MetaCubeX/metacubexd/assets/68163551/f052f2b0-1f7d-46ea-baae-004228868172

still can't reproduce this issue

Remote desktop session with @RikudouPatrickstar minutes before, after some digging, we can reproduce this issue on chromium based browser, such as Microsoft Edge and Google Chrome, but doesn't seem to have any issue whatsoever on firefox. Maybe it's an issue related to apexcharts rendering in svg, we still don't know yet. But after disabling the apexcharts fixes this issue.

用最新版的浏览器试了下最近的版本，没有这个问题了


background rendering dates

Hi there,
I have a display issue using background rendering.
The colour is overlapping on some dates and also starting at +- 30% of the cell
A mouse click on a specific date is also selecting two contiguous cells
Thank you for your help
 config: {
          header: {
            left: '',
            center: 'title',
            right: 'prev,next today'
          },
          height: 550,
          timeFormat: 'HH:mm',
          firstDay: 1,
          navLinks: false,
          editable: false,
          defaultView: 'month',
          overlap: false,
          viewRender: this.calViewRender
        },

"loop ..."
vLeave.push({
   start: datePush,
   color: 'red',
   rendering: 'background',
   allDay: true
  })

Sorry, it's my fault, css issue between the page and the calendar!
Fixed.


Customizing increments arrow input[type=number]

It would be nice to customize the arrows for the input[type=number].

We should not forget the arrows for the custom angles.

Hi!
Thank you for your interest!
With pleasure :)

Am i suppose to modify the javascript or just the css file?

It really depends of the style you want to implement.
Do you have a one in mind?
Some prefer to use exclusively CSS, others add JavaScript. It's up to you :)

I might have misunderstood the task but do I have to design the arrows myself ? If not can I use a image I found online ?

I created this issue because I don't like how the arrows are represented.
I'd like to see something more like that:

Or like that:
https://www.cssscript.com/demo/number-spinner-quantity-input/
But I don't think there is room in the Manual times adjustments section.
If you use an image found online you have the right to use it (with credit or not).
You can use the icons from Remix Icon: https://remixicon.com/

Hi let me know what you think, i end up not replacing with an image because it would have lost the clickity feeling of it so i end up just reformating it so there is no blank space #10

So it looks like that


Lift internal assumption is false

In lift.rs, in the implementation of the lift function, there is this line:
 debug_assert_ne!(slot as *const _, &root as *const _);

slot, &root presumably can't point to the same location because root owns a value whereas slot is a mutable reference to a value (of the same type), and both of them being the same would violate Rust's aliasing guarantees.
However, this is false in this example:
fn lift_counterexample() {
    GhostToken::new(|mut token| {
        let cell = GhostCell::new(Box::new(7));
        lift_with_mut(cell, &mut token, |cell_ref, token_ref| {
            GhostCell::from_mut(cell_ref.borrow_mut(token_ref))
        });
    })
}

Here, a &GhostCell<T> is safely aliasing a &mut GhostCell<T>. This happens by the chain of &GhostCell<T> -> &mut T -> &mut GhostCell<T>, which can be called in regular code without using the lift function.
To my understanding, this is safe because

GhostCell ensures these references cannot be used at the same time, by the use of the token.
GhostCell is/contains an UnsafeCell which causes some things to be allowable, both in terms of stacked borrows and in terms of rustc assuming less things.

Therefore, the code of lift is wrong to assume that this can never happen.

I believe that this is unsound, because then in the replace function, the function will read a moved (logically uninitialized) value from dst, since it has been moved in the src argument of the function.
I didn't manage to cause any concrete unsoundness or to cause miri to catch it.
Here's some speculation on what may actually happen in practice:
Note that It will then also "leak" the src argument into dst. (This is a "leak", since dst actually points to a logically-uninitialized value, which will therefore be ignored in the future).
I'm guessing that's because it will end up copying the logically uninitialized value in dst which will turn out to be the same as src, and then leak the src value, resulting in the net effect of just moving from src.
However, to my understanding that's definitely unsound, even if it's hard to observe.

You are definitely correct about the internal assumption, but I do not think there is a soundness issue.
As far as I know there is no notion of "logically" uninitialized value in Rust. The ptr::read or ptr::copy functions explicitly create multiple copies of a value, with a caveat that unless the value is Copy, then only one of the copies must be used (and dropped). This is exactly what happens here: the same value is copied in multiple places, but at the end, only one copy is returned and everything else is forgotten.
In fact, should there be "logically" uninitialized values, the entire lift would be unsound: slot is logically borrowing root, then root is moved (into slot) whilst borrowed, which should mean that slot is pointing into a "logically" uninitialized value.

I see multiple axes of improvement:

The internal assertions should be removed, they do not hold.
Tests should be created to exercise this usecase.
Comments, and in particular safety comments, should be refined. This is not about initialized values, but about valid for read/write pointers.

Thoughts?

To clarify, by "logically uninitialized" I mean it in the sense that a variable that has been moved out from, still exists as a variable, but behaves like it's uninitialized, since no one can use it. You can see this term in the rustonomicon
Specifically, in this case, root is moved in the replace call:
pub fn lift<F, R>(root: R, fun: F) -> R
where
    F: for<'a> FnOnce(&'a R) -> &'a mut R,
{
    let root = ManuallyDrop::new(root);
    let slot = fun(&root) as *mut R as *mut ManuallyDrop<R>;
    // Assume that they do point to the same point, and that we're in release mode
    debug_assert_ne!(slot as *const _, &root as *const _);

    unsafe {
        replace(slot, /* root is moved here */ root)
        // `slot` now points to a moved-from, (logically) uninitialized place.
    }
}

unsafe fn replace<T>(dest: *mut ManuallyDrop<T>, src: ManuallyDrop<T>) -> T {
    // Now `dest` points to the `lift` function's `root`, which is uninitialized, and different than this functions `src`.
    //  This reads from an uninitialized place
    let result = ptr::read(dest);
    ptr::copy(/* doesn't necessarilly point to the same position as `dest` */ &src as *const _, dest, 1);

    ManuallyDrop::into_inner(result)
}

I believe that rustc would be justified in marking root as uninitialized / llvm poison at the entrance to replace, which would then make subsequently reading from it UB.
However, miri doesn't report UB. Remember though, that miri isn't guaranteed to catch UB.
If the compiler decided to just leave the value of root as is even while it's considered uninitialized, then even though it's UB on an intermediate language level, it might perform as you expect.
Additionally, if you inline the call, you get rid of the problematic move as well:
pub fn lift<F, R>(root: R, fun: F) -> R
where
    F: for<'a> FnOnce(&'a R) -> &'a mut R,
{
    let root = ManuallyDrop::new(root);
    let slot = fun(&root) as *mut R as *mut ManuallyDrop<R>;
    // Assume that they do point to the same point, and that we're in release mode
    debug_assert_ne!(slot as *const _, &root as *const _);

    unsafe {
        let slot_ptr = slot as *const _;
        let result = ptr::read(slot_ptr);
        ptr::copy(/* This now points to the same place as `slot` */ &root as *const _, slot_ptr, 1);
        ManuallyDrop::into_inner(result)
    }
}

In the inlined version, you temporarily get two copies of the same value, which is then immediately forgotten. Since panicking cannot happen during that time, it seems okay.
In fact, I think inlining the call is probably a good way to solve this issue, and I propose to solve it this way.

Inlining is indeed a possibility, but it's a code-block that'd have to be repeated 3 times, which makes it unpalatable.
The reason that inlining works is that replace doesn't actually use the fact that src is moved into it, and instead immediately turns it into a pointer; as such, I'll instead switch things around and simply pass src by pointer into replace, thereby not moving in the various lift functions.

Fixed in v0.6.1.


NuttX and FreeBSD / BSD

Hello world :-)
My first steps with NuttX on FreeBSD. I will ask some questions here for support and make it working on FreeBSD / BSD Unix :-)
I have also asked that question on mailing list but I prefer to work here closer to the source code and better public reach.
My Target hardware is ESP32-C3 (using RISC-V CPU) ESP32-C3-MINI-1 / ESP32-C3-DevKitM-1 and/or ESP32-C3-WROOM-02 / ESP32-C3-DevKitC-02.
Problem 1: kconfig
% ./tools/configure.sh esp32c3-devkit:ble
Copy files /home/cd/cederom/work/CeDeROM/lab/embedded/nuttx/nuttx.git/nuttx/tools/../tools/sethost.sh:
line 129: kconfig-tweak: command not found

There is no such package kconfig on FreeBSD. But I was working with Zephyr KConfig somehow.
All I have is:
pkg search -x kconfig
kf5-kconfig-5.86.0 KF5 widgets for configuration dialogs
kf5-kconfigwidgets-5.86.0 KF5 widgets for configuration dialogs

Both are installed.
Any hints welcome :-)
Tomek

I have managed to build and flash esp32c3-devkit:ble on FreeBSD :-) It gets a boot loop problem but the build seem to have worked just the same as on Linux Debian, probably needs some more setup with bootloader :-)
I have tried ./tools/configure.sh -B sim:nsh but that needs porting genromfs to FreeBSD.
genromfs was easy peasy :-)
I am using upstream version 0.5.7 from https://github.com/chexum/genromfs
0xCFMX4% uname -a
FreeBSD 0xCFMX4 13.0-STABLE FreeBSD 13.0-STABLE #0 stable/13-n247642-39a1ff43ad7: Tue Oct 12 12:31:41 CEST 2021     root@0xCFMX4:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

0xCFMX4% ls -al nuttx
-rwxr-xr-x  1 XXX  XXX  1516992 Oct 18 01:41 nuttx

0xCFMX4% ./nuttx
login: admin
password:
User Logged-in!

NuttShell (NSH) NuttX-10.1.0
MOTD: username=admin password=Administrator
nsh> uname -a
NuttX 10.1.0 9cb35d79cc-dirty Oct 18 2021 01:40:26 sim sim
nsh> ls
/:
 bin/
 dev/
 etc/
 proc/
 tmp/
nsh>

:-)

@cederom look like all flaw are fixed, can we close this issue?

Sure! Thank you! I hope it lands into a release soon :-)


msbuild.exe is not recognized as the name of a cmdlet, function, script file, or operable program.

Environment
Windows build number: [run "ver" at a command prompt] Microsoft Windows [Version 10.0.17763.557]
Windows Terminal version (if applicable): v0.2.1715.0

Any other software?

Steps to reproduce
Running the installation commands from vs 2019 preview. I am doing it in PowerShell, although I also tried in CMD and got errors at the bcz step. Import-Module .\tools\OpenConsole.psm1 &
Set-MsBuildDevEnvironment both worked for me.
NOTE: Found what seemed like a similar issue at #930 but I am using the merged update. I think I may just need to give up trying to do it with 2019, but I'm still filing this as a bug hoping someone will explain to me why the version is causing this issue if I'm just running PowerShell commands.
Expected behavior
I'd expect the Invoke-OpenConsoleBuild command to complete successfully, it's giving me an error.
Actual behavior

Build is failing: msbuild.exe : The term 'msbuild.exe' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At C:\Users\pacoric\source\repos\terminal\tools\OpenConsole.psm1:251 char:5

msbuild.exe "$env:OpenConsoleRoot\OpenConsole.sln" @args

~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (msbuild.exe:String) [], CommandNotFoundException
FullyQualifiedErrorId : CommandNotFoundException

it sounds like msbuild isn't getting added to your path correctly, what's your path look like after running Set-MsBuildDevEnvironment?

I also ran into this issue. You need to run Set-MsBuildDevEnvironment with the Prerelease parameter set to $true for the script to find VS2019.

I am having the same issue, DEV's bump?


[CircleGraph] Use external source code instead of modified source code

media/CircleGraph/view-sidebar.js has following modifications.

Change formatting
Change == to ===
Change != to !==
However, these modifications are not related with real operation.
Thus this commit will replace media/CircleGraph/view-sidebar.js to media/CircleGraph/external/view-sidebar.js.

ONE-vscode-DCO-1.0-Signed-off-by: Seok NamKoong<EMAIL_ADDRESS>

@seanshpark
The reason why I created this PR is that our internal static analysis score collapsed :(
Main cause is modified external open source codes in media/CircleGraph, but fixing them all is quite hard.
Fortunately, media/CircleGraph/view-sidebar.js was nothing changed except trivial changes contrast to other modified files such as index.js, view.js.
That's why this PR only focus on media/CircleGraph/view-sidebar.js.
If there is something I missed, please let me know.


[WIP] Camera support

This is a pull request to centralize the camera integration effort.

Oh, that worked!

This is ready for being tested, to get an early preview of the full API:
import camera

camera.capture(True)
while True:
    bytes = camera.read()
    if bytes is None:
        break
    print(bytes)

I thought about a function that reads a JPEG image, and just sends all the bytes one by one, letting the receiver detect the end of the image by the presence of a packet shorter than the others: no wire protocol at all, just send equally sized packets until the end.
  |JFIF..23| |28151923| |28740150| |20971404| |20971404|
  |22592693| |29751002| |19937414| |13297191|
  |29891034| |01901604| |02981487| |01964010|
  |20171955| |02153664| |17082174| |93105601|

 First frame:    Other frames: as long as      Last frame:
 starts a new    there is more bytes in the    shorter as
 JPEG image      single JPEg image             a marker.


Update appendonly_compaction.c, add helpfull debug via Debug_appendon…

…ly_print_compaction
Recently have been debugging some unrelated issue, and i happened to notice that Debug_appendonly_print_compaction printing gone in CBDB (it was very helpfull in GPDB6) So, I propose to bring it back.

fix #ISSUE_Number

Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:

[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
[ ] Learn the coding contribution guide, including our code conventions, workflow and more.
[ ] List your communication in the GitHub Issues or Discussions (if has or needed).
[ ] Document changes.
[ ] Add tests for the change
[ ] Pass make installcheck
[ ] Pass make -C src/test installcheck-cbdb-parallel
[ ] Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Similar logging can be found in functions AOCSSegmentFileTruncateToEOF/AOCSCompact in CBDB
https://github.com/cloudberrydb/cloudberrydb/blob/main/src/backend/access/aocs/aocs_compaction.c#L388


fix(build): repair global usage

Coverage increased (+0.2%) to 77.241% when pulling 4c3e242b9c87a01e51e99e5f91c5bd600cda9b28 on fix/build/entry-point-and-module-exports into c5fc10893a718595cfbc302790a0f5c9b56e075f on master.


A11y_AzureDataStudioStayHealthy_Dashboard_Home - Toolbar_Screenreader : NVDA is not announcing non focusable content.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11y_AzureDataStudioStayHealthy;#A11ySev2;#Benchmark;#A11yTCS;#A11yMAS;#DesktopApp;#MAS1.3.1;#SQL Azure Data Studio;#FTP;#NVDA;#STP;#JAWS;#Win32;
Environment Details:
Application Name: Azure Data Studio
Version: 1.19.0-insider (system setup)
Commit: 8288360cc46910025453c14e5e02cda8d1ac33d0
Date: 2020-05-29T05:54:49.731Z
VS Code: 1.46.0
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
Additional Details:
MAS References: MAS1.3.1
Screenreader : NVDA 2019.3.1,JAWS
Repro Steps:

Launch Azure Data Studio Insiders application.
Connect to server.
Double click on connected server or right click on it & select manage option to open the Dashboard.
Navigate to Home under Dashboard & hit enter.
5.Navigate to "Learn more" button.
6.Start screenreader as NVDA and hit next arrow to read contents in the section below toolbar.

Actual:
NVDA is not reading the Version,Computer name,Edition,OS version information contained in the expanded section below toolbar which don't have any focus.
Similar issue also observed with JAWS.
Expected:
NVDA should read the Version,Computer name,Edition,OS version information contained in the expanded section below toolbar which don't have any focus.
User Impact:
Screen reader users will not get any information about the content.
Attachment link for Reference:
10647_A11y_AzureDataStudioStayHealthy_Dashboard_Home - Toolbar_Screenreader.zip

this is also by design, tab focus should move item to focusable items, if you want to navigate the page there are special screen reader keys for it. not sure about nvda, but on macOS voiceover you can press CAPS + Left/Right to browse the text elements.


Code and examples for proposed changes/additions to transport APIs

See Issu "Message interface for inter-transport use." #162
This PR is not intended to be pushed, it illustrates some ideas directly as working code and examples. As we agree on if/how the ideas  should be integrated, I'll submit PRs to merge them into the main transport package.
It is a little easier to read as godoc, for convenience I put it here https://alanconway.github.io/godoc/pkg/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/x/index.html
or you can use godoc to generate it locally

This is a little easier to read as godoc, for convenience I generated it here https://alanconway.github.io/godoc/pkg/github.com/cloudevents/sdk-go/pkg/cloudevents/transport/x/index.html
or you can use godoc to generate it locally

@n3wscott ping

Oh! I was traveling. Sorry I missed this.
Let me look.

What do you think about making a branch in this repo to start staging this stuff and then we can work together on it, or a branch in your repo.
I think I still need to be convinced of the removal of codecs as an abstraction of how to turn events into messages. But codecs could be internal details of the transport Message objects rather than how I have it as a detail of the transport.
Let's keep going on this idea. I think it could turn into a much easer adaptation for non-http transports.
Thanks for the detailed comments in the PR!

I have cut a 0.8.0 release to make room for these changes to come in.

What do you think about making a branch in this repo to start staging this stuff and then we can work together on it, or a branch in your repo.
I think I still need to be convinced of the removal of codecs as an abstraction of how to turn events into messages. But codecs could be internal details of the transport Message objects rather than how I have it as a detail of the transport.

My bad - I'm not proposing the removal of Codec, I just didn't bother to write an explict one in the example - fixing.

Let's keep going on this idea. I think it could turn into a much easer adaptation for non-http transports.

Yes - the biggest variable here is what we do about  #160. I think adding a RequestMessage interface might be a good compromise for the #160 use cases while removing responses from the main transport  API, but I would like to understand the requirement for response events better before I dive into that.

Thanks for the detailed comments in the PR!

I'll update with explicit Codec and RequestMessage { Response() }to see how that looks. I'm thinking that a response-capable transport (HTTP) would do if m, ok :=  m.(RequestMessage) { respond } whereas response-ignorant transports would blindly Finish() the message, in which case the requester can decide if that's an error, or if it will manufacture a fake response for the ultimate clien.t

Moving Message out of the transport also leads to interesting developments around sharing codec that are very common in strategy, like binary mode in AMQP, PubSub and HTTP all use the equivalent of headers to send the data, the Key value is different in each, but the strategy is the same...

Moving Message out of the transport also leads to interesting developments around sharing codec that are very common in strategy, like binary mode in AMQP, PubSub and HTTP all use the equivalent of headers to send the data, the Key value is different in each, but the strategy is the same...

Agreed, e.g. the if Structured() else Event() dance could be part of a generic library usable by all transports that allow structured tunneling.  Also the correct handling of different QoS options definitely should be captured generically, each transport just calls some relevant functions when it gets it's transport-specific ack indicator.
I'll probably do one or two more pushes in the current form to continue the discussion points so far, then try merging it into the main transport package and re-implementing some existing transports as you suggest.

LGTM
Let's start this plan.

:tada:


DS4 Practically Unusable

Not mad at all, this program has served me well for awhile now, but after the recent update things got silly. I haven't used DS4 in about 2 weeks and went to play a game today using my Dualshock 4 (not the new one) and so far here's the problems I've ran into.
-Not being able to open the profile editor, given an error screen and a prompt to either close the program or try to continue. By continuing I'm stuck in the profile select screen but with the profile name editor and save button loaded and not able to do anything else in the program.
-Right stick not working at all. After noticing that, I reinstalled DS4, used only the default profile, and the problem persisted and some. It was different for each game, but only a few buttons worked and were scrambled up a bit. (ex. 1: in Left 4 Dead 2 in the title screen, the controller doesn't do anything unless I hover over a selection, then only up/down D-pad and "A" button works then gets locked on game select menu if I navigate to it using the d-pad, and then only moves with mouse input. ex. 2: In Oblivion, Right Bumper was triggering the "y" button and most buttons didn't do anything). I used default profile after fresh install of DS4 and associated drivers for these tests, and for a control had a Logitech gamepad and the gamepad worked just fine on all games.
I had hide DS4 checked, reinstalled xbox drivers and all DS4 related stuff.
I'm on a Windows 10 PC with latest update.
I know my controller is fine because I took it to a friend who has a PS4 and it worked fine on that, and my bluetooth is fine considering I'm using my bluetooth keyboard to type this up (although I did try using the controller via usb connection and same results were had).
Screenshot of first listed error:

If you need more information from me, let me know because I would love to have this working again.

Where do you have your settings saved? Program folder or AppData? If it was in AppData you're possibly still using profiles from older versions of DS4Windows that might not be compatible with the newest version. Find the settings folder here C:\Users\USERNAME\AppData\Roaming\DS4Windows Delete it all and try again.

Had them in AppData and went ahead and tried what you suggested but nothing has changed.

It's similar to this issue #132  but with additional controller input problems. Not sure what's going on.


[WIP] Parameter coverage iPython notebook

Summary
This PR adds a parameter coverage checker hosted in an iPython notebook. This notebook produces a detailed report of which chemical groups a ForceField object is unable to parameterize. These chemistries are reported as

2D molecule images, with unparameterizable groups highlighted (generated by RDKit)
tagged SMILES
tuples of atom indices

These results are printed out in the iPython notebook itself, and the final cells provide functionality to write to file as well.
My hope is that the Open Force Field industry partners can use this tool on a small dataset which encapsulates the diversity of the compounds they might simulate, and report critical areas where our force fields lack coverage. Industry partners probably can not reveal whole molecules from internal data sets, so I have tried to design this notebook such that it is easy to take screenshots of relevant chemistry, without revealing the whole molecule.
This notebook is suitable for analysis of hundreds to thousands of molecules, but probably not much more than that. It takes about 1 core-second per molecule, though I do offer a parallelized checker as well. Significant speedups past 0.1 sec/molecule would require several additional days of engineering, affect internal OFF Toolkit code, and decrease code readability. Thus, while we probably want to make a "fast" version of this some day, it would not be in the form of an interactive notebook.
Checklist

[x] Closes #413
[x] Fix #417
[x] Fix #418
[x] Change MissingValenceParameterException to also contain relevant TopologyAtoms for exception handling
[x] Add parameter coverage example notebook

[x] Provide SMILES test set
[x] Provide mol2 test set
[x] Provide SDF test set
[x] Provide in-notebook description of missing parameters
[x] Output easily-readable, file-based summary of parameter coverage results

[x] Update docstrings/documentation, if applicable
[x] Update changelog

Status

[x] Ready for review
[ ] Ready for merge

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   49.25%   49.25%
=======================================
  Files          35       35
  Lines        9577     9577
=======================================
  Hits         4717     4717
  Misses       4860     4860

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe87bae...a40dca1. Read the comment docs.

Closed and reopened -- Trying to get travis to resume building this PR


Invalid option `--lsp'

I've compiled from the master branch and I couldn't use the --lsp option. Do I need to build a branch or will this be active in the alpha as well?
Steps to reproduce
$ nix build --extra-experimental-features 'nix-command flakes'
$ cd result/bin
$ pact --lsp

Expected Behavior
the lsp should start listening
Debug Information
$ pact --lsp
Invalid option `--lsp'

Thank you for the PR. I can't reproduce this issue .Are you sure, you execute the right binary, i.e. try running ./pact --lsp within the result/bin directory. It looks like you might use pact 4?

yep, my mistake!


ResourceZone

This PR Creates a Zone for a Server Profile Template requested from Oneview and populates the Links of Zone with available targets of the Server Profile Template.
Associated github issues are #260 and #237
Closes #260 #237

@karolcatunda marking you on this review.


Centralize logic for wrapping multine expressions

The multiline-expression-wrapping rule should be the central, and only rule, that wraps a multiline expression. Currently this logic is partly duplicated in binary-expression-wrapping and function-signature. Logic from function-signature with the different types of wrapping (always, multiline and default) has to be moved to multiline-expression-wrapping.

The function-signature property ktlint_function_signature_body_expression_wrapping also takes care of merging the body expression with the signature in case it fits on the same line as the signature when set to default, or when set to multiline and the body exists of a single line. When set to always the body expression is always wrapped. This functionality can/should not be generalized for all expressions.
The binary-expression-wrapping rule also has to wrap a single line expression in case it does not fit on a single line:
// $MAX_LINE_LENGTH_MARKER                         $EOL_CHAR
fun foo() =
    leftHandSideExpression && rightHandSideExpression

So there is hardly any logic that can be centralized.


Extract the data access logic as an independent abstract layer

Closed because we have introduced a new project turms-gateway.
https://github.com/turms-im/turms/commit/75e8b7ffb83346ef6a8cf54088012364879a09c5


decoding: fix panics by limiting max decode sizes in proofs, commitments and assets

Fixes https://github.com/lightninglabs/taproot-assets/issues/510.
Fixes https://github.com/lightninglabs/taproot-assets/issues/502.
Contains a commit (6174f9d5) that is already in the v0-3-0-staging branch, but was incomplete, so I added itests for it as well.
This PR fixes a number of proof and asset decoding related issues discovered through fuzz tests. Both FuzzFile and FuzzProof were run for an hour each after the changes and they didn't discover any additional panics.
To help any reviewer, here are all the magic numbers in one place:
	// MaxAssetNameLength is the maximum byte length of an asset's name.
	// This byte length is equivalent to character count for single-byte
	// UTF-8 characters.
	MaxAssetNameLength = 64

	// MaxAssetEncodeSize is the size we expect an asset to not exceed in
	// its encoded form. This is used to prevent OOMs when decoding assets.
	// The main contributing factor to this size are the previous witnesses
	// which we currently allow to number up to 65k witnesses.
	MaxAssetEncodeSize = blockchain.MaxBlockWeight

	// FileMaxNumProofs is the maximum number of proofs we expect/allow to
	// be encoded within a single proof file. Given that there can only be
	// one transfer per block, this value would be enough to transfer an
	// asset every 10 minutes for 8 years straight. This limitation might be
	// lifted at some point when proofs can be compressed into a single
	// zero-knowledge proof.
	FileMaxNumProofs = 420000

	// FileMaxProofSize is the maximum size of a single proof in a proof
	// file. The maximum size of a meta reveal is 1 MB, so this value would
	// cap the number of additional inputs within a proof to roughly 128 of
	// assets with such large meta data.
	FileMaxProofSize = 128 * MetaDataMaxLen

	// FileMaxSize is the maximum size of a single proof file. This is not
	// just FileMaxNumProofs * FileMaxProofSize as only the minting proof
	// can commit to a large chunk of meta data. The other proofs are much
	// smaller, assuming they don't all have additional inputs. But we must
	// cap this value somewhere to avoid OOM attacks.
	FileMaxSize = 500 * 1024 * 1024

	// MetaDataMaxLen is the maximum length of the meta data. We limit this
	// to 1MB for now. This should be of sufficient size to commit to any
	// JSON data or even medium resolution images. If there is need to
	// commit to even more data, it would make sense to instead commit to an
	// annotated hash of the data instead. The reason for the limit is that
	// the meta data will be part of the genesis proof, which is stored in
	// the universe and needs to be validated by all senders and receivers
	// of the asset.
	MetaDataMaxLen = 1024 * 1024

	// MaxNumTaprootProofs is the maximum number of Taproot proofs there can
	// be in a proof. This limit represents the maximum block size in vBytes
	// divided by the size of a single P2TR output and is therefore only a
	// theoretical limit that can never be reached in practice.
	MaxNumTaprootProofs = blockchain.MaxBlockBaseSize / input.P2TRSize

	// MaxTaprootProofSize is the maximum size of a single Taproot proof.
	// A Taproot proof can contain a commitment proof which at maximum can
	// contain two MS-SMT proofs that max out at around 10k bytes each (in
	// the worst case).
	MaxTaprootProofSize = tlv.MaxRecordSize

	// MerkleProofMaxNodes is the maximum number of nodes a merkle proof can
	// contain. This is log2(max_num_txs_in_block) + 1, where max number of
	// transactions in a block is assumed to be 17k (theoretical value).
	MerkleProofMaxNodes = 15

We use math.MaxUint16 for the number of previous witnesses and the number of TX witness elements (as well as the max length for each individual witness stack element).
Everything else uses the tlv.MaxRecordSize (65k) size as that should fit all of those elements.
cc @Crypt-iQ

Looking pretty good! I think some of the new limits are missing unit tests + this PR could also include similar mitigation for address decoding:
https://github.com/lightninglabs/taproot-assets/blob/bf4af96a55af655b02d1af89f9fabbbf15be8013/address/address.go#L369
I think just using DecodeP2P here is good enough?

Ah, good catch. Added!

Looking really good! Only nit is now a separate proof size limit for RPC input. I think instead of adding that in decode it could actually be somewhere like proof.IsProofFile() as a guard before proofFile.Decode().


Update composer.json

support Laravel 5.7

@mohammed-adil-moughal Does not work with version 5.0

UP ! @Crinsane when accepting this pull request ?

@bitw Then why don't do ^5.1 as a constraint? Laravel seems to respect semantic versioning in their illuminate packages now.


Relax Coveralls threshhold

We should improve test coverage someday.
In the meantime, Coveralls delivering red Xs to pull requests is demoralizing  and distracting without being helpful.
Therefore reconfigured Coveralls with cartoonishly low standards about test coverage. Should always pass. We still get the automatic calc, we can choose to engage with test coverage any time we want, but we stop with the annoyance in the meantime.
(Logged as GitHub issue for transparency.)

Ditto Code Climate, done.

done.
https://github.com/uPortal-Project/uportal-app-framework/issues/574#issuecomment-336184597

@apetro does that mean this ticket is completed and can be closed?

Think so, yes. Easily re-opened if anyone's still seeing unhelpful Coveralls / Code Climate PR status failures..


[SilverStripe 4] Fix object casting

The problem
The current "hack" of sorts to make sure that an object isn't force returned wont work. We know this because the ss4 branch unit tests fail.
https://github.com/silbinarywolf/silverstripe-components/blob/dev/src/SilbinaryWolf/Components/ComponentService.php#L58
The solution
Not sure on how to solve this yet. Ideally i'd put the solution in the SS3 codebase and rebase the ss4 branch.
Function signatures
SS3::ViewableData:
public function obj($fieldName, $arguments = null, $forceReturnedObject = true, $cache = false, $cacheName = null
SS4::ViewableData:
public function obj($fieldName, $arguments = [], $cache = false, $cacheName = null)

The current fix for this is to make the default object cast type allow RAW access to values.
https://github.com/silbinarywolf/silverstripe-components/blob/dev/src/SilbinaryWolf/Components/ComponentData.php
This might be a problem in SS4 where the assumption is that everything is escaped.

This has been solved.
Not sure the solution is good for SS3 but we're at least in a place to change our mind easily now.
Example template cache output
Here is an example of how this component template extension gets translated into the cached SilverStripe template files.
SilverStripe Template:
<:FormTextInput class="<% if $getAttribute("class") %>$getAttribute('class')<% end_if %> test" />

Output:
NOTE: We store each "part" passed in to a parameter seperately so that we can retain how the data should be cast when the value
is output as a string. This is necessary in SilverStripe 4 to ensure passing 'getAttributesHTML' (or any other HTMLText object) will work as expected.
<?php

$val .= '
';

$_props = array();
$_props['class'] = array();
if ($scope->locally()->hasValue('getAttribute', array('class'), true)) {
$_props['class'][] = $scope->locally()->obj('getAttribute', array('class'), true)->self();

}
$_props['class'][] = ' test';
$_props['class'] = Injector::inst()->createWithArgs('SilbinaryWolf\Components\DBComponentField', array('class', $_props['class']));
$val .= Injector::inst()->get('SilbinaryWolf\Components\ComponentService')->renderComponent('FormTextInput', $_props, $scope);
unset($_props);
$val .= '
';


Inline Documentation

Allow the use of comments to explain the code properly

I will take this up.

@salman-bhai
could you be more specific about the things you require in the documentation.

Just add single-line comments for now explaining what each function does for now!

I thought of submitting PR once the other bug issue is resolved, what do you tell @salman-bhai ?
I am done with the files in the lib directory.

Send it across. You can send another PR later.

@salman-bhai ,review PR #18 .


doxity build fails at "gatsby build --prefix-links"

Hi,
I successfully compiled and ran doxity init successfully.
Then I get an error when running doxity build :
# doxity build
Generating output for 1 contracts...
  done!
<EMAIL_ADDRESS>build /Users/davidvanisacker/Programming/.../ProjectName/scripts/doxity
> gatsby build --prefix-links
Error: Couldn't find preset "env" relative to directory "/Users/davidvanisacker/Programming/...
"
...

It seems like something related to gatsby but I was wondering if anyone could reproduce the error or know what to do about this ?
The CSS is generated successfully, but not the html.
OS : MacOSX Sierra
Solc : 0.4.14

I have the smae issue. Anyone can help with this?


System.Net.NetworkInformation and Utility

Merging S.N.NetworkInformation and Utility in SN2.

@mellinoe /cc: @pgavlin @stephentaub @davidsh @sidharthnabar
PTAL

Is this just refactoring to get things buildable, or has comment cleanup and reformatting also been done? No worries either way, just want to know what to look for.

@pgavlin

Is this just refactoring to get things buildable, or has comment cleanup and reformatting also been done? No worries either way, just want to know what to look for.

This is just to get things to build. Please ignore any comments/coding style, etc.
Current plan:

[ ] Address any feedback on the step-by-step commits
[ ] Merge snn into sn2. Can't rebase since @mellinoe is working in a topic branch from snn.
[ ] Prune resource strings.
[ ] Manually get things into a public PR branch off dotnet/master
[ ] Go through the normal PR process: CodeFormat, CodeSanitize, comments and extra formatting, ensure that SLNs are working, lock all json files.

@CIPop SGTM. I'll ignore what you've mentioned.

LGTM modulo a few small things.

This LGTM. Thanks for doing this, it will make it much easier for me to merge my changes back.
To briefly note, the only files I believe we will need to modify to include platform abstractions will be:

NetworkInterface.cs
NetworkChange.cs (Will probably need to split out the Windows-specific stuff that is in that file into another one).
IPGlobalProperties.cs
The project file

Thanks @pgavlin and @mellinoe for the review!
I'm going to shortly have another iteration that fixes various build breaks then move to the submission to dotnet/master.

Important: do not delete snn since it got branched.


Namenode's name directory is defined twice

Current implementation defines namenode's name directory twice in in hdp_hdfs-site.xml.erb , once using deprecated property dfs.name.dir and once using new property dfs.namenode.name.dir and both the parameters point to different directory location that causes confusion when debugging any issue related to hdfs. Also, since new property overrides deprecated property, keeping deprecated one is unnecessary. Below is the output from unix:
$ ls -l /disk/*/dfs/
/disk/0/dfs/:
total 0
drwx------ 2 hdfs hdfs  6 Jan  7 20:31 namedir
drwxr-xr-x 3 hdfs hdfs 20 Jan  8 21:27 nn

The deprecated property should be removed from the configuration file.

Fixed as part of PR "Multiple issues fixed #51"


Styling issues

The UI of the color picker could use a modern approach. How about a nice combo of material design and frosted glass design?

.hex-color-picker-wrapper {
position: absolute;
top: 0;
bottom: 0;
right: 0;
left: 0;
margin: 0 auto;
background-color: white;
background-color: rgba(255, 255, 255, 0.3) !important;
backdrop-filter: blur(2px);
z-index: 5;
width: 300px !important;
height: 300px;
box-shadow: 0 4px 10px 0 rgba(0,0,0,0.15), 0 4px 20px 0 rgba(0,0,0,0.1);
border-radius: 25px;
padding: 25px;
}

Looks great.  Let me think through the best way to integrate so we don't update the UI for any existing installations that aren't expecting a change.  Thanks so much for the contribution!

Okay, sounds good to me! I think your work is great and I'm using it on a
website myself. It's an awesome solution :)
On Mon, Dec 7, 2020 at 12:28 PM Boone Putney<EMAIL_ADDRESS>wrote:

Looks great. Let me think through the best way to integrate so we don't
update the UI for any existing installations that aren't expecting a
change. Thanks so much for the contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/boonep/jquery-hex-colorpicker/issues/3#issuecomment-740063980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL4BWCDG4U67XUV757GECFDSTUGEHANCNFSM4UOEVNNQ
.


LimitRange as part of Kubernetes core resources

Feature Suggestions
Going through the KubernetesFanOutHandler service, I noticed that the DEFAULT_OBJECTS array (which pretty much are all the v1 core resources) is missing an entry for limitranges which makes no possible for the actual fetching of these resources. I also noticed that even though you're exporting the KubernetesFanOutHandler class on the file level, you're not including this on the export from the index, making not possible for a user to use this class to actually use the builder pattern you're introducing with builder.setObjectsProvider
Possible Implementation
I believe you can address this including the limitranges on the DEFAULT_OBJECTS like:
export const DEFAULT_OBJECTS: ObjectToFetch[] = [
  {
    group: '',
    apiVersion: 'v1',
    plural: 'pods',
    objectType: 'pods',
  },
  {
    group: '',
    apiVersion: 'v1',
    plural: 'services',
    objectType: 'services',
  },
  {
    group: '',
    apiVersion: 'v1',
    plural: 'configmaps',
    objectType: 'configmaps',
  },
  {
    group: '',
    apiVersion: 'v1',
    plural: 'limitranges',
    objectType: 'limitranges'
  },
  {
    group: 'apps',
    apiVersion: 'v1',
    plural: 'deployments',
    objectType: 'deployments',
  },
  {
    group: 'apps',
    apiVersion: 'v1',
    plural: 'replicasets',
    objectType: 'replicasets',
  },
  {
    group: 'autoscaling',
    apiVersion: 'v1',
    plural: 'horizontalpodautoscalers',
    objectType: 'horizontalpodautoscalers',
  },
  {
    group: 'batch',
    apiVersion: 'v1',
    plural: 'jobs',
    objectType: 'jobs',
  },
  {
    group: 'batch',
    apiVersion: 'v1',
    plural: 'cronjobs',
    objectType: 'cronjobs',
  },
  {
    group: 'networking.k8s.io',
    apiVersion: 'v1',
    plural: 'ingresses',
    objectType: 'ingresses',
  },
  {
    group: 'apps',
    apiVersion: 'v1',
    plural: 'statefulsets',
    objectType: 'statefulsets',
  },

];

And you will need to modify the type KubernetesObjectTypes like:
export type KubernetesObjectTypes =
  | 'pods'
  | 'services'
  | 'configmaps'
  | 'limitranges'
  | 'deployments'
  | 'replicasets'
  | 'horizontalpodautoscalers'
  | 'jobs'
  | 'cronjobs'
  | 'ingresses'
  | 'customresources'
  | 'statefulsets';

If you do not feel comfortable adding a new resource to this (maybe for performance issues) you can also just export all the classes needed to implement the desired strategy on the builder pattern, some of these classes as far as I dig into this are:

KubernetesFanOutHandler
KubernetesClientProvider
KubernetesClinetBasedFetcher

And a final possible solution is just removing the validation on the app.config.yaml were using an empty group is not allowed anymore.

Context
I'm currently working with Kubernetes backstage trying to present the resource limits for a pod, and I'm taking into count the scenarios where a LimitRange is present on a namespace, that's why I started to dig about how can I actually fetch this resources.

@mclarke47 may know best but yeah it sounds to me like both adding this per default and making sure that the requisite types are exported, both make sense to contribute if you're up for it!

Hey! I just created this PR that I hope will address this issue. https://github.com/backstage/backstage/pull/11938

/close
(It looks like this was fixed in #11938)


Why can't search by number code if code upper than 236xxx?

Because every doujin search by nuc code hard if can't search code upper than 236xxx.

Fixed on 1.9.2