[WIP] Build our own redis

This is temporarily submoduling our current redis image until we decide what to use for sentinel support at which time we'll replace it with something more approproiate

@cnelson I've been testing this in k8s-dev with this docker image I haven't modified it, but I've forked it so I could test a few things. wdyt about using that docker image rather than the one we currently use for our starting point?

SGTM

@rogeruiz can I close this PR?  Do you have your own branch with updated redis changes on it?

Yeah, I think it makes sense to close this. We could also just keep this in for now. I ended up using a different version of Redis for HA so we have a whole set of Dockerfiles for that in redis-ha:customImages/redis32 (#55). Wdyt about upgrading all our Redis offerings to 3.x?

I think it's a good idea but one that is totally not in scope for the story that's already late :)


Backport Time Sync changes to WUTS

Summary of changes:

Use libwupsxx as an external submodule; code as been updated for the current libwupsxx, as some of the wups::config::item API changed.
Sources have a full copyright notice (year and author).
New option: synchronize when closing config (if changes were made). Closing the menu does not synchronize the clock unless this option is enabled (and any config was changed).
"Syncing Enabled" option was renamed to "Synchronize On Boot". Old config option will be migrated to the new one (sync -> sync_on_boot).
There's now an option to explicitly run the synchronization task inside the config menu.
Synchronization thread can now be safely canceled.
timezone_* classes and files were renamed to time_zone_*.
Plugin description, license and authors were removed from the Makefile. They're only used in main.cpp, there's no point in creating global macros for them.

I left the README unchanged, as you'll probably want to adjust names, phrasing, etc.

This all looks good to me! Thank you, as per usual!


Update modtcl.cpp add tcl function GetNetworkName

Add tcl function [GetNetworkName] return name of current network

Did you test this at all?

Did you test this at all?

Yes. I use it in production. No problem to report.
<MalaGaM> return $network <*modtcl> artis <MalaGaM> return $::network <*modtcl> artis <MalaGaM> return [GetServerName] <*modtcl> artis

The reason I'm asking is you're using GetNetworkName in one place, but GetServerName in another. How can Tcl_CreateCommand(interp, "GetNetworkName", ...) make GetServerName available?

The reason I'm asking is you're using GetNetworkName in one place, but GetServerName in another. How can Tcl_CreateCommand(interp, "GetNetworkName", ...) make GetServerName available?

fixed to https://github.com/znc/znc/pull/1658 sorry


rollup failed: 'Logger' is not exported by node_modules/angular2-logger/core.js

Following the install instructions & getting this with ionic 2:
[11:18:03]  ionic-app-scripts 0.0.48
[11:18:03]  build dev started ...
[11:18:03]  clean started ...
[11:18:03]  clean finished in 4 ms
[11:18:03]  copy started ...
[11:18:03]  transpile started ...
[11:18:07]  transpile finished in 3.75 s
[11:18:07]  rollup started ...
[11:18:07]  copy finished in 3.82 s
[11:18:13]  rollup failed: 'Logger' is not exported by node_modules/angular2-logger/core.js (imported by
            src/app/app.component.ts). For help fixing this error see
            https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module

Have you tried this? https://github.com/rollup/rollup-plugin-commonjs#custom-named-exports

Have you tried this? https://github.com/rollup/rollup-plugin-commonjs#custom-named-exports

Thx @langley-agm - will give it a shot shortly.

I also have this problem and tried the rollup commonjs workaround, but now encounter this error:
Error parsing /....../node_modules/angular2-logger/app/core/level.ts: Unexpected token (9:7) in /....../node_modules/angular2-logger/app/core/level.ts
For some reason rollup is trying to parse a Typescript file from the core.js require. I don't know what to do about this.

I must be doing something wrong, it's not working despite @olivermuc solution. Seems like it completely ignores 'nameExports'. Running 'rollup-plugin-commonjs' version '^8.0.0'. Anybody any clues?
'use strict';

import commonjs    from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve'
import uglify      from 'rollup-plugin-uglify'

import chalk from 'chalk';
const seen = new Set();
if (!process.stderr.isTTY) {
  chalk.enabled = false;
}
const warnSymbol = process.stderr.isTTY ? `Warning: ` : `Warning: `;
const stderr = console.error.bind(console);
const handleWarning = warning => {
  const str = warning.toString();
  if (seen.has(str)) {
    return;
  }
  seen.add(str);
  stderr(`${warnSymbol}${chalk.bold(warning.message)}`);
  if (warning.url) {
    stderr(chalk.cyan(warning.url));
  }
  if (warning.loc) {
    stderr(`${warning.loc.file} (${warning.loc.line}:${warning.loc.column})`);
  }
  if (warning.frame) {
    stderr(chalk.dim(warning.frame));
  }
  stderr('');
};

const warnFilter = /The 'this' keyword is equivalent to 'undefined'/;

export default {
  entry: './dist/out-tsc/src/main-aot.js',
  dest: 'aot/dist/build.min.js', // output a single application bundle

  sourceMap: true,
  sourceMapFile: 'aot/dist/build.min.js.map',

  treeshake: true,
  format: 'iife',

  onwarn: warning => {  // overwite the default warning function
    const str = warning.toString();
    if (warnFilter.test(str)) {
      return;
    }
    handleWarning(warning);
  },
  plugins: [
    nodeResolve({jsnext: true, module: true}),
    commonjs({
               include: [
                 'node_modules/rxjs/**',
               ],

               namedExports: {
                 'node_modules/angular2-logger/core.js': ['Logger', 'Options']
               }
             }),
    uglify()
  ]
}


Add breadcrumbs to our static pages

Context
We want a way for the user to get back to the home page from our static pages. So the breadcrumbs will contain the current page and a home page.
The home page link will go to the school/claims index page if normal the user is logged in.
For support users it will redirect to organisations index page. This is because we redirect from the root path to these pages if a user is signed in.
Changes proposed in this pull request
Pages controller, views, locals
Guidance to review
Go through the static pages and check the breadcrumbs
Screenshots

 The static pages should have breadcrumbs with a "Home" link to the "Start" page


formatter: print request header without query string

Signed-off-by: Tero Saarni<EMAIL_ADDRESS>Commit Message:
Adds formatter extension implementing a command operator that writes HTTP request header to access log without including the query string. Resolves #7583.
Additional Description:
Motivation for this change: Query string may contain sensitive information introducing potential vulnerability since access logs may unintentionally expose this information. If the problem cannot be fixed in the proxied application itself, the vulnerability can be mitigated by removing query string from the access logs.
This PR is similar to #7847 but implemented as extension and it is first in-tree formatter extension (xref #14512).
It implements command %REQ_WITHOUT_QUERY(X?Y):Z% which works in the same way as existing command operator %REQ(X?Y):Z%. The proposed implementation closely follows SubstitutionFormatParser and reuses SubstitutionFormatParser::parseCommandHeader() for parsing the command arguments.
In order to get check_format.py to pass, I needed to add entry to CODEOWNERS but since I don't know who should be added, I added @dio and myself as a placeholder for now.
Risk Level: Low
Testing: unit test
Docs Changes: TODO: Where to document formatters?
Release Notes: formatter: command operator to log request headers without query string.
Platform Specific Features: N/A

FWIW, we've achieved the equivalent of %REQ_WITHOUT_QUERY(X?Y):Z% by using the header-to-metadata filter, e.g.:

Thanks! I did not know about this filter.
In general, I have some doubts about about this PR. Adding a complete extension for the single purpose of removing ?querystring seems bit wrong.  Do people see it as problematic if we have a lot of small extensions that do really trivial things?
I've also done some experiments with more general purpose formatter, inspired by your example with Header-To-Metadata, which allows following
formatters:
  - name: envoy.formatter.regex_substitute
    typed_config:
      "@type": type.googleapis.com/envoy.extensions.formatter.regex_substitute.v3.RegexSubstituteConfig
      command_name: REQ_WITHOUT_QUERY
      regex_value_rewrite:
        pattern:
          google_re2: {}
          regex: "^(/[^?]*).*$"
        substitution: "\\1"

but would this then be duplication of functionality?

@tsaarni sorry I was out for a health issue. Sorry was not able to update this earlier. But generally, the PR is good. If you resolve the conflict I'll take a look at it as soon as I can. And it is nice to have that REQ_WITHOUT_QUERY shorthand.

@tsaarni sorry I was out for a health issue. Sorry was not able to update this earlier. But generally, the PR is good. If you resolve the conflict I'll take a look at it as soon as I can. And it is nice to have that REQ_WITHOUT_QUERY shorthand.

No problem with delays, glad to see you back!  I've now resolved the conflict.
I wonder if you have opinion about https://github.com/envoyproxy/envoy/pull/15711#issuecomment-819737323, that is: more general purpose formatter (regex manipulation) vs this one (dedicated for query string alone)?  I'm OK with anything at the end, but just wanted to hear your thoughts :-)

Check envoy-presubmit (check linux_x64 gcc) is failing for me due to too long argument list (full log here)
2021-04-24T19:45:27.1433253Z ERROR: /source/test/exe/BUILD:98:14: C++ compilation of rule '//test/exe:win32_scm_test' failed (Exit 1): gcc failed: error executing command
...
2021-04-24T19:45:27.2269979Z gcc: fatal error: cannot execute ‘/usr/lib/gcc/x86_64-linux-gnu/9/cc1plus’: execv: Argument list too long

and in another case in different target (full log here)
2021-04-22T18:21:55.0427418Z ERROR: /source/test/exe/BUILD:62:14: C++ compilation of rule '//test/exe:main_common_test' failed (Exit 1): gcc failed: error executing command
...
2021-04-22T18:21:55.1126016Z gcc: fatal error: cannot execute ‘/usr/lib/gcc/x86_64-linux-gnu/9/cc1plus’: execv: Argument list too long

I saw @rgs1 mentioning this in https://github.com/envoyproxy/envoy/pull/14855#issuecomment-822533255 but there it was config_fuzz_test_lib.  I don't understand why it is not always the same target that fails but it seems to hit more compilation targets as just a specific lib.

Could I kindly ask help in reviewing of this PR? I think @dio might be still unavailable, so I was hoping maybe others could be able to help and look at this also?

Hi @tsaarni -- I'm going to take over for @~dio.
Generally, this looks good. I have a couple minor comments, and I think you'll need to merge master for a conflict. Hopefully that'll fix the other CI errors. Once that's updated we'll need to pull in an API reviewer.

Thank you @zuercher!
I seem to have some problems with the CI since macos and windows jobs take more time than expected and get cancelled, therefore failing status.  I'm not sure if this is just a general problem since windows job finished after retrying, but macos still fails...

I think the macos failure is systemic. cc @envoyproxy/api-shepherds for the empty config proto

I guess @markdroth is our shepherd.

/lgtm api

@rgs1 do you want to give this a pass?

@rgs1 do you want to give this a pass?

Yeah I'll take another look today.

I realised I have one question left: what security_posture should be set for the extension? I've set "unknown" which results in following description in the docs "This extension has an unknown security posture and should only be used in deployments where both the downstream and upstream are trusted". Is this ok or should the security posture be evaluated somehow more in detail?

I think it's OK to make this one trusted for downstream and upstream.

Thanks @mattklein123. I've now added entry to release notes and changed the security posture.

Oops looks like it needs a main merge.
/wait

/retest

/retest

There has been quite many flakes but these tests now seem to be failing quite consistently and I don't seem to get clean CI run anymore

IpHttpVersions/HttpHealthCheckIntegrationTest.SingleEndpointImmediateHealthcheckFailHttp/IPv4_Http2Upstream (logs)
IpHttpVersions/HttpHealthCheckIntegrationTest.SingleEndpointImmediateHealthcheckFailHttp/IPv6_Http2Upstream (logs)

I saw some other PRs have had same failures, so I wonder if this is a flake as well, or could it have something to do with the changes in this PR?

Yeah, it's happening on master as well.


[ENH] Randomness handling in MiniRocketMultivariate

Is your feature request related to a problem? Please describe.
The current implementation is controlling the randomness using numpy.seed e.g. line 140. This is considered bad practice according to the numpy docs here:
https://numpy.org/doc/stable/reference/random/generated/numpy.random.seed.html?highlight=seed#numpy.random.seed
Describe the solution you'd like
The suggested approach for controlling the random generator is to create a new RandomState instance. Scikit-Learn has a nice function sklearn.utils.check_random_state that takes all the different inputs (int, None, RandomState) and returns the appropriate RandomState. The solution should replace np.random.seed(seed) with rng = check_random_state(self.random_state) and then any calls of the type np.random.choice(...), or np.random.randint(...) with rng.choice(...), rng.randint(...). Example code:
from sklearn.utils import check_random_state

...

rng = check_random_state(self.random_state)

# replace all calls from np.random to rng
rng.choice(...)
rng.randint(...)

I'll work on this .

I have a question ; I cannot replace the random.seed() with check_random_state(self.random_state) as the function is not inside the class so I tried to apply check_random_state on the seed and got the following error.

Okay so I went through the Numba docs according to them Numba doesn't allow you to create an individual randomstate instance .

Ah! sorry about that. Makes sense now why the code was written like that. Can you paste the link from the docs here?

Here's the link to the docs
https://numba.pydata.org/numba-doc/dev/reference/numpysupported.html#modules

OK - so if I understand this correctly "but with an independent internal state: seeding or drawing numbers from one generator won’t affect the other" we're ok with using the seed like that inside numba functions. Great job figuring this one out @Ris-Bali. Closing this!


videos of various demos

video (-> animated gif) of hand plugging/unplugging cable/connector

for where?

good question - the videos on the start page are nice. i see you've replaced the videos on the makecode client page.
what about the blog?

Can you reuse some of them?

From: Tom Ball @.>
Sent: Thursday, June 9, 2022 7:42:08 PM
To: microsoft/jacdac @.>
Cc: Peli de Halleux @.>; Assign @.>
Subject: Re: [microsoft/jacdac] videos of various demos (Issue #1059)
good question - the videos on the start page are nice. i see you've replaced the videos on the makecode client page.
what about the blog?
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fjacdac%2Fissues%2F1059%23issuecomment-1151861415&data=05|01|jhalleux%40microsoft.com|77b2f7bbf6834a7a40ff08da4a8ad0b3|72f988bf86f141af91ab2d7cd011db47|1|0|637904257310072989|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=BVNAQJQIyg8TRlUzo%2FIPnYLxDphrrPyvtycq0DDTIgY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKONEZ6FXAX346S5TLLVOKTQBANCNFSM5XZQ2U3Q&data=05|01|jhalleux%40microsoft.com|77b2f7bbf6834a7a40ff08da4a8ad0b3|72f988bf86f141af91ab2d7cd011db47|1|0|637904257310072989|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=1%2B5sFQFnrrzS9s8IRJeeO1Q2UbTqw9sXVZnTu8AUZJs%3D&reserved=0.
You are receiving this because you were assigned.Message ID: @.***>

yeah, I'll rewrite to incorporate them


Add other steamos Wallpapers

Other SteamOS Wallpapers

I could not add it since the steamos recovery image has the current wallpaper we are using and i fwe add it it will switch the wallpaper per boot


Readme updates

Codecov Report

Merging #272 (5a695c2) into master (6a15483) will increase coverage by 0.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   91.42%   92.38%   +0.95%
==========================================
  Files          17       17
  Lines         210      210
  Branches       24       24
==========================================
+ Hits          192      194       +2
+ Misses         18       16       -2

Flag
Coverage Δ

unittests
92.38% <ø> (+0.95%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/tests/mocks/address-utils-mock.sol
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a15483...5a695c2. Read the comment docs.


[Feature] fast recover

Before Requesting

[X] I found no existing issue matching my feature request

Describe the feature you'd like!
an innovative feature for betterdiscord that will ensure that the client is not cashed completely but recover immediately but with an error message
I don't know if it's really possible but I'll try
Anything else?
vencord crashes but doesn't crash at all

This is part of better crash recovery and prevention. duplicate of #1018


Better handle site CSS overriding PayButton styles

https://proofofwriting.com/148/

Not 100% perfect but pretty close.


chore: add two manifest related metrics

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
https://github.com/GreptimeTeam/greptimedb-enterprise/issues/39
What's changed and what's your intention?
The two metrics are: the time to update the manifest, labeled with "action"; and the time to do checkpoint. Screenshot of "/metrics" output:

Checklist

[ ]  I have written the necessary rustdoc comments.
[ ]  I have added the necessary unit tests and integration tests.
[x]  This PR does not require documentation updates.

@evenyag PTAL


Add more Remote Debug options to the web platform

This PR adds (great) quality of life improvements for the web platform for the Remote Debug options.

Before
After

Server Off

Server On

It may not seem important changes, but iterating on a web project with the old options were... irritating to say the least.
Before, you had to open up a window each time you did changes to the project. This is highly unpractical, since opened browser windows can have the developer tools opened. Opening a new window makes it awkward since it opens without that said window.
Now, you can re-export without even having to close the server. And let say that you have your browser window already opened up before you opened Godot. Now, you can launch the server without opening new windows.
Magical. Extraordinary!
This PR also cleans up EditorExportPlatformWeb, it could even serve as a template to make the EditorExportPlatform classes more readable. Instead of counting menu_options and incrementing the values for weird reasons, this uses a small state machine instead.
This PR makes it easier too to add new options to the menu, as actions were distinguished from the run() method.

Thanks @AThousandShips!

Thanks!


Add a helper method for optimization

Add a method that allows better performance. The future can be reused for each message and efficiently polled without unsafe code and unnecessary allocations.

What do you think about changing the recv implementation instead of adding a new method? The code would look like this:
impl<T> SignalReceiver<T> {
    /// Asynchronously receives the next message from the queue. Only the active
    /// receiver is allowed to receive messages. If there are no messages in the
    /// queue, the receiver will wait until a new message is sent.
    /// If this receiver is not active, the future will return `None`.
    pub fn recv(&self) -> impl Future<Output = Option<T>> {
        RecvFuture {
            inner: self.inner.clone(),
            receiver_id: self.id, // Pass the receiver's ID to the future
        }
    }
}

I agree, I was not sure that the API would be 100% compatible.
I would also like to make RecvFuture public and return the concrete type, so I can store it in a structure.

I am not sure if exposing internal structs to the user would be ideal, because its names were intended to be used internally. Would it be possible to make your code use impl Future type annotations to store futures?

Ok then, I will use Box<dyn ...>. I have adapted the commit, please review.

Thank you for your understanding. Perhapse you can use a generic type <T: Future> as well. I'll publish the new version as soon as possible.


[skip-ci][COMMUNITY] leandron to PMC

Dear community:
Please join us to welcome @leandron as a new PMC member. Leandro was one of the early contributors to the community. He contributed to the TVM command line driver.
He helps the community a lot by contributing to the CI and packaging efforts. Many of those efforts (time spent on overall coordination and infra) are not part of code contributions, nor do they necessary show up in normal code contribution statistics. But they are also very important for the TVM community (per our community guideline, "area of contribution can take all forms").
Importantly, leandro interacts constructively with the current community members in apache way.
Many interactions with Leandro with positive exchanges, with him being receptive to feedback and bringing constructive suggestions.

Commits History
Code Review
Community Forum Summary

Need to undo the pylint change. We can do [skip-ci] for a PR like this. (Add [skip-ci] to the beginning of the PR title and commit message)

I think we need to change the title before pushing commit? cc @driazati

[skip ci] seems only effective when opening the PR at the first time. Change the PR title or commit message after opening the PR might not work

I remember doing [skip ci] "after the fact". https://github.com/apache/tvm/pull/10067

maybe @tqchen can push another commit to be sure. It should finish after sanity check.

@masahi is right, both the commit message and the PR title at the time the build is run have to start with [skip ci]. We're working on a glob-based approach for auto-skipping CI for certain files (e.g. *.md) soon that should obviate the need for this though.


debian / ubuntu packaging

It seems that numpy-stl is used by Cura https://github.com/Ultimaker/Cura/  Cura is distributed as a debian package for ubuntu/debian.
It would be nice to have a debian package for numpy-stl tool that it could depend on or recommend.

Completely forgot to reply to this ticket, sorry about that.
While I think an Debian/Ubuntu package would be a great idea, I'm not entirely sure how to build one and too strapped for time to dive into that right now.
If someone has more expertise and is willing to create a pull request I'm all for that though.

Currently I started making packages for numpy-stl.
Is pytest-runner really essentially needed? https://github.com/WoLpH/numpy-stl/blob/master/setup.py#L64
It doesn't come with Ubuntu itself and thus I would need to package it, too.

Pytest runner is only required if you want to run tests from the setup.py file. If you use the py.test command manually the result is the same.
Additionally, the code is already tested through Travis anyhow so there is no real need to test.

Is it possible for you to make it optional? So I can pass an option and it will skip it?
This would be great! Thanks!

Sure, I've pushed a small update that should do the trick :)
Simply pass --no-pytest-runner to setup.py and it should do the trick.

I managed to pass --no-pytest-runner to be passed to the setup.py command, but the script says now that it is not recognized:
https://launchpadlibrarian.net/317672637/buildlog.txt.gz

Without overriding all used commands I don't think this will easily work. Perhaps we can switch to an environment variable instead?
Try this:
 PYTEST_RUNNER=false python2.7 setup.py clean

@thopiekar does the environment variable fix the issue?

Probably but it is not so trivial to set custom env variables in the packaging scripts. At least there they are not recognized.
Haven't had time to find a way to set it properly, sorry.

In that case, perhaps there is an existing environment variable we can use?
Or are there any other options?


maintainers: add jakelogemann user.

Motivation for this change
I'd like to assist maintaining packages/modules, since I'm tired of maintaining a local clone/fork!
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Is this something I should fix?


fix(python): pin mypy to the exact version

It's been a couple of times mypy breaks the pipeline by releasing new
versions that are more strict or start checking things it used to
silently ignored.
In order to avoid this happening in the future (and putting us back in
control), this pins the mypy version to the exact release (the last
we successfully built with, in this case), and moves everything we
install though pip install into requirements-dev.txt files so that
@dependabot can help us stay up-to-date going forward.
Fixes #2464

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: ace4752245a7b25cdd7b6c4ea38994cb232816ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
Commit ID: ace4752245a7b25cdd7b6c4ea38994cb232816ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


rename function names for package gtcp/gudp; add proxy example for gtcp.Server

Codecov Report
Base: 78.11% // Head: 78.13% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (bfc456c) compared to base (7d1a508).
Patch coverage: 76.81% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##           feature/v2.3.0    #2295      +/-   ##
==================================================
+ Coverage           78.11%   78.13%   +0.01%
==================================================
  Files                 583      580       -3
  Lines               48448    48108     -340
==================================================
- Hits                37844    37587     -257
+ Misses               8592     8527      -65
+ Partials             2012     1994      -18

Flag
Coverage Δ

go-1.15-386
?

go-1.15-amd64
?

go-1.16-386
78.13% <76.81%> (-0.01%)
:arrow_down:

go-1.16-amd64
?

go-1.17-386
?

go-1.17-amd64
?

go-1.18-386
?

go-1.18-amd64
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

net/ghttp/ghttp.go
100.00% <ø> (ø)

net/ghttp/ghttp_server_handler.go
64.14% <ø> (+0.11%)
:arrow_up:

util/gconv/gconv.go
93.84% <ø> (ø)

net/gtcp/gtcp_conn_pkg.go
86.08% <50.00%> (ø)

net/gtcp/gtcp_pool.go
72.22% <50.00%> (-3.34%)
:arrow_down:

net/gtcp/gtcp_pool_pkg.go
82.69% <50.00%> (ø)

net/gtcp/gtcp_conn.go
67.98% <71.42%> (ø)

net/gudp/gudp_conn.go
62.20% <77.77%> (ø)

net/ghttp/ghttp_response.go
37.64% <100.00%> (ø)

net/ghttp/ghttp_response_writer.go
100.00% <100.00%> (ø)

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


callonce seems to be called more than once through ignored scenarios

Hi there, not sure if this is an issue or not, but it's still worth asking I think.
I have test2.feature like this:
Feature: Test 2

Background:

@ignore @scenario1
Scenario: Scenario 1
    * print "Hello from Test 2 - Scenario 1"

And test.feature like this:
Feature: Test 1

    Background:
        * callonce read('test2.feature@scenario1')

    Scenario: Scenario 1
        * print 'Hello from Test 1 - Scenario 1'

    Scenario: Scenario 2
        * print 'Hello from Test 1 - Scenario 2'

When I execute test.feature, it looks good, test2.feature@scenario1 is only called once, which is as expected:

Now I change test.feature to be like this: An ignored scenario (scenario0) added, then call to that one from Scenario 1 and 2.
Feature: Test 1

    Background:
        * callonce read('test2.feature@scenario1')

    @ignore @scenario0
    Scenario: Scenario 0
        * print 'Hello from Test 1 - Scenario 0'

    Scenario: Scenario 1
        * call read('@scenario0')
        * print 'Hello from Test 1 - Scenario 1'

    Scenario: Scenario 2
        * call read('@scenario0')
        * print 'Hello from Test 1 - Scenario 2'

This time, test2.feature@scenario1 is called 3 times (1 for Background, and 2 for every time we call the ignored (scenario0). I expect that test2.feature@scenario1 should be always called once no matter what. Please kindly let me know if I am expecting it correctly? Thank you very much.

@phipgn this is a very complicated case (background, ignore, call by tag) and I insist that you follow this process to reopen: https://github.com/karatelabs/karate/wiki/How-to-Submit-an-Issue
I know this may sound like a lot of work, but we explain why we ask for this in the link.


example in lapin docs does not compile

after adding all of the dependencies, I get
src/main.rs1:35

use futures_executor::{LocalPool, ThreadPool};
No ThreadPool in the root

Did you enable the thread-pool feature of futures-executor like it is in our dev-dependencies?

No, as that was not spelled out in the documentation. Although i figured it out after filing this ticket. I have seen this implied context in documentation trip up a lot of developers in the rust ecosystem.

Well, given examples are supposed to be run within lapin's repository using e.g. cargo run --example=client, I don't think this issue is relevant. The use of futures-executor or any other executor is not really relevant to lapin, it's a detaill left to the user, it has nothing to do in lapin's documentation imo

I am referring to the example in your documentation, not in your repository. Don't you think its worthwhile to add a one liner that mentions the dependencies required to run the example? Especially if the dependency itself requires configuration? Even a simple "see examples/Crate.toml for configuration"?

I genuinely do not understand what you're saying.
If your neither speaking of an example in the examples folder nor the one in README.md, I have no idea which example you're complaining about

Sorry. I am referring to the example in the rendered docs here:
https://docs.rs/lapin/1.4.2/lapin/?search=
vs the README.md

I see what is going on. On github, I am looking at master instead of the 1.4.2 tag. that accounts for the difference.

I'll improve that for next release!


Where should I run train.py?

Should I enter model/bisenet/cityscapes.bisenet.R18 and run train.py or just in the top of root dir? I got error:
Traceback (most recent call last):
  File "train.py", line 13, in <module>
    from config import config
  File "/home/USER/Projects/TorchSeg-BiSeNet/model/bisenet/cityscapes.bisenet.R18/config.py", line 56, in <module>
    from utils.pyt_utils import model_urls
ModuleNotFoundError: No module named 'utils'
Traceback (most recent call last):
  File "train.py", line 13, in <module>
    from config import config
  File "/home/USER/Projects/TorchSeg-BiSeNet/model/bisenet/cityscapes.bisenet.R18/config.py", line 56, in <module>
    from utils.pyt_utils import model_urls
ModuleNotFoundError: No module named 'utils'
Traceback (most recent call last):
  File "train.py", line 13, in <module>
    from config import config
  File "/home/USER/Projects/TorchSeg-BiSeNet/model/bisenet/cityscapes.bisenet.R18/config.py", line 56, in <module>
    from utils.pyt_utils import model_urls
ModuleNotFoundError: No module named 'utils'
Traceback (most recent call last):
  File "train.py", line 13, in <module>
    from config import config
  File "/home/USER/Projects/TorchSeg-BiSeNet/model/bisenet/cityscapes.bisenet.R18/config.py", line 56, in <module>
    from utils.pyt_utils import model_urls
ModuleNotFoundError: No module named 'utils'

I found that furnace/utils, maybe wrong dir?

@hubutui : You should run train.py inside "model/bisenet/cityscapes.bisenet.R18" directory.

Ok, I fix it by adding
sys.path.append('/home/USER/Projects/TorchSeg-BiSeNet/furnace')

to train.py before import utils.


xy_35

description: Controlling color and opacity in xy plots
plot: https://www.ncl.ucar.edu/Applications/Images/xy_35_lg.png
script: https://www.ncl.ucar.edu/Applications/Scripts/xy_35.ncl

This issue was not linked to it's associated PR so it didn't close when PR #149 was merged.


Bombarder dependence link gives 404

Describe the bug
A clear and concise description of what the bug is.
Bombarder dependence link gives 404
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information

OS: [e.g. Ubuntu]
Installed Requirements Version [e.g. PySocks1.70]
Python Version [e.g. 3.8.x]

Additional context
Add any other context about the problem here.

@PXEiYyMH8F

fixed ?


Update terraform provider file locking

Currently, the file system lock (shared with the Provision, Destroy, and Describe functions) is held during the terraform apply goroutine while the resources are refreshed.
We do not need to hold it during this option, since the refresh does not need to be protected from the Provision (since it writes .tf.json.new files) and from the Describe (since that is a read-only operation).
This update reduces the number of group Describe timeouts since, currently, the Describe is blocked during the terraform refresh (which can take several seconds for larger swarms).

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "tf-file-locking" git@github.com:kaufers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354660032
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


keep in short :)

@EisenbergEffect this ones ok lets merge it with the next release cycle

@matjaz Would you mind signing our CLA please? https://docs.google.com/forms/d/1Npd68d32UDUKUYuCDDrW0VN5Lv8p-a6Ziaa2JFKp6Cg/viewform?c=0&w=1

oh i thought i already signed that months ago :)
anyway , done !
On Wed, Jun 24, 2015 at 8:10 AM, Rob Eisenberg<EMAIL_ADDRESS>wrote:

@matjaz https://github.com/matjaz Would you mind signing our CLA
please?
https://docs.google.com/forms/d/1Npd68d32UDUKUYuCDDrW0VN5Lv8p-a6Ziaa2JFKp6Cg/viewform?c=0&w=1
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/animator-css/pull/17#issuecomment-114689191.

@Aaike You did. This PR was from @matjaz though.

I already signed it. https://github.com/aurelia/dependency-injection/issues/15


__Userspace_os_Linux undefined after sources configured for MinGW cross-compiler

usrsctp library uses __Userspace_os_Linux macro to fence Windows-specific code.
However, this macro is not defined after I configured library for cross-compilation.

Sorry but there is no support for other plataforms than Linux. We cannot assume the extra cost for the beneffics it brings.


Only Inference is estimated

Hi @albanie , the flops you estimated is only for inference step, without Back Propagation. Am I right?
thanks

Hi @dujiangsu, yes that's correct.


Add Awesome mobile to Learn.

Fix https://github.com/sindresorhus/awesome/pull/308 comments.

Learn Mobile Development

The license isn't using the right name...

Improving, but I think the quality is still too low for inclusion. Not all the issues in the original comment are resolved. I think it could be a useful resource, but needs a lot more work. Especially on the quality of descriptions, what's included, etc.


[HOLD] Error message shown out of place in VBA flow

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/4916#
Tests / QA

Created workspace on freePlan beta
Selected Get Started in the Expensify Card tab of the Workspace
Entered test bank account credentials in 3 of this SO
Arrived at Validate Step to enter validation amounts, and make sure you don't see a verify your name and date of birth message

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Putting on hold for now until I can test this once the validate step works again

Putting on hold for now until I can test this once the validate step works again

I was able to test this locally using the credentials in 2 of this SO (not 3)

I think your are right about the problem being that we don't clear the error state properly.
When the error comes from the back end (no field highlighted, only growl), the fix doesn't seem to work:
https://user-images.githubusercontent.com/87341702/131585148-dc948619-0699-4d65-a6b6-d487015ed209.mov
When the error is from a validation in the front end (field highlighted + growl), there is doesn't stay because we clear it immediately on the input change here
https://user-images.githubusercontent.com/87341702/131585234-9387fc4e-c8b0-4881-8e3e-3d60350d06af.mov

Did you test on my branch? I was testing with the second credentials and had success (going to give it another test now)

Just kidding, I didn't trigger the API call, back to the drawing board

@aldo-expensify Thanks for the initial review - ready for another one (I tested it correctly this time)

Tested again, now it worked.
Just two comments:

I saw this error in the console, which I guess is related to displaying the error '':

This is related to the problem described here, a way to fix that is by doing this change in ValidationStep.js:
                            {errorMessage && (
                                <Text style={[styles.mb5, styles.textDanger]}>
                                    {errorMessage}
                                </Text>
                            )}

for
                            {Boolean(errorMessage) && (
                                <Text style={[styles.mb5, styles.textDanger]}>
                                    {errorMessage}
                                </Text>
                            )}

There is already a function in BankAccounts.js to clear the errors: hideBankAccountErrors

Good catch, I ended up using the !_.isEmpty conditional

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @aldo-expensify in version: 1.0.90-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I think I found a new issue here. After following the steps to enter a pending account I got a empty validation page 🤔

Ok ignore this 🔝 It happened because I already had an account with that user. Retested on a new account and it was a pass 🎉

🚀 Deployed to production by @roryabraham in version: 1.0.91-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Move Avalonia.Flexbox in this repository

Avalonia.Flexbox

What is reason to move it?
It's not a toolkit repository, nor a repository for this party controls. It's a repository for unstable (API-wise) controls, some of which might be merged into the core at some point.

cc @jp2masa

@maxkatz6 I can open a PR to move the code here, would it go to Avalonia.Labs.Controls or a new csproj?

Avalonia.Labs

A new project labelled Avalonia.Labs.Panels

Can this also be considered: https://github.com/Nickelony/AvaloniaSpacedGrid
RowSpacing and ColumnSpacing would be great if could be added directly to Grid at some point. Like Spacing on StackPanel

@emmauss @maxkatz6 Sorry for taking so long to respond.
I'm almost ready to create a PR to discuss this better, just have one more question. In my repo, there are two classes for flex layout: a panel and a non-virtualizing layout (for items repeater). I know items repeater has some very hard to fix bugs, which led to moving it to a separate package. Should I bring the items repeater part as well? If so, should it be in a separate project to avoid bringing the extra dependency?

It can be "Avalonia.Labs.Panels" project for ItemsControl panels, and "Avalonia.Labs.Layouts" for ItemsRepeater layouts.
But, honestly, I am not sure if adding ItemsRepeater layout is worth it, as it might not be supported for too long.


feat(commands): Adds autocompletion for all commands and subcommands

Can confirm it works on windows gitbash, but requires a slightly different setup:
For windows gitbash:
ng completion >> ~/.bash_profile
source ~/.bash_profile

This is because gitbash start with --login, and that uses .bash_profile instead.

lgtm

Thanks, let me add this to readme.


localization from the app to the back-end service

how can apps sense and communicate the locale to the back-end?
in websites that's done with cookies, however, i have been avoiding setting up cookies based on your advice to use single-access token.

actually, their time zone may also be necessary, in some cases, for smooth operation. not sure if this is available at all to the app. presumably it is?


:sparkles: Automatic dependency update checks

Please check if the PR fulfills these requirements

[x] Tests for the changes have been added (for bug fixes / features)
[x] PR title follows the guidelines defined in  https://github.com/ossf/scorecard/blob/main/CONTRIBUTING.md#pr-process

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
#179

What is the new behavior (if this is a feature change)?

Checks if the dependencies are automatically updated.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
None

Other information:
None

Going to start working on this.

re: @asraa I agree confidence should be lowered for other languages in the repo that are not defined in the dependabot config file. We could list files and their extension: if any of these files are not tracked by the dependabot config, they should reduce the score. It'd be great to weight the scoring based on how much code is tracked or not - maybe by looking at number of lines for each lanaguages.
There's the language API that I initially thought could help, but it unfortunately only works at the repo level, ie we cannot specify folders of interest.

@nathannaveen what's left for this PR to land?

re: @asraa I agree confidence should be lowered for other languages in the repo that are not defined in the dependabot config file. We could list files and their extension: if any of these files are not tracked by the dependabot config, they should reduce the score. It'd be great to weight the scoring based on how much code is tracked or not - maybe by looking at number of lines for each lanaguages.
There's the language API that I initially thought could help, but it unfortunately only works at the repo level, ie we cannot specify folders of interest.

I think for the initial release I am not going to target that

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's . AFAIK there aren't dependabot events by API.

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

Ok this is fine, but please add renovatebot file check in this as well. renovatebot is extremely common, and either one of the two is fine. in documentation, we should say this check only looks if it is enabled and not ensures that it is run and prs merge (maybe tbd for future ?) ?? @azeemshaikh38 @laurentsimon thoughts?

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's . AFAIK there aren't dependabot events by API.

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's . AFAIK there aren't dependabot events by API.

Please add a TODO in the code that we should also list commits even when we find the dependabot's config file (to ensure users actually update their dependencies).
re: quota: An alternative approach could be to run the cron jobs with some checks turned off. Within a few days we could run different checks so that, every week, we have all the checks. Do we actually need the cron job to run every single day? (It's ideal, but is it really necessary?)

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

I suppose that's the best we can do now. Note that "fail with low confidence" achieves little from a user's point of view. If I use scorecard and I get this result, it's almost like a noop: I have no idea how to interpret it. @asraa who tests scorecard for envoy, so she may comment.

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's . AFAIK there aren't dependabot events by API.

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

@nathannaveen what's left for this PR to land?

if failed, check for commits [we have to see how far we can go without burning quota, or instead see if we can get user dependabot events by api]. if that exists, pass with medium-high confidence, depending on last update?

☝ This will burn the API quota's . AFAIK there aren't dependabot events by API.

Please add a TODO in the code that we should also list commits even when we find the dependabot's config file (to ensure users actually update their dependencies).
re: quota: An alternative approach could be to run the cron jobs with some checks turned off. Within a few days we could run different checks so that, every week, we have all the checks. Do we actually need the cron job to run every single day? (It's ideal, but is it really necessary?)

☝  This is would be a separate issue

otherwise fail with low confidence (like 3?)

For now, we can stay with fail with low confidence.
Thoughts?

I suppose that's the best we can do now. Note that "fail with low confidence" achieves little from a user's point of view. If I use scorecard and I get this result, it's almost like a noop: I have no idea how to interpret it. @asraa who tests scorecard for envoy, so she may comment.


Make unit tests run faster

Description
WIP Description
Acceptance Criteria

[ ] wallet-unit-tests should take less than 15 minutes on CI

PR

Number
Base

develop

Moving out spending passwords generation seemed to help a little.
https://github.com/input-output-hk/cardano-sl/blob/develop/wallet-new/test/unit/Test/Spec/Fixture.hs#L41
2.2 s with 0% spending passwords
3.2 with 80% spending password, 20% without
3.0 - 3.6 with 100% spending passwords

Next step: only generate a few wallets & addresses and reuse them for all tests.

@Anviking
Think about making multiple PRs introducing your changes incrementally. No need to go for the final solution right away :)

anviking/38/faster-tests-2 🤔 I think this calls out: is there really anything we want to QuickCheck?
On develop the only things we're  generating randomly are:

Maybe V1.SpendingPassword (expensive to compute)
? V1.NewWallet (expensive to compute)
ProtocolMagic

Simplest solution would be setting withMaxSuccess to like 2.

Next step: withMaxSuccess 5 everywhere, and if it works, create a new separate issue for improving tests and removing QuickCheck where it's not needed.

To note: removing parallel didn't seem to do anything in particular.
parallel removed
parallel still there

Duplicated by #1


Add Canonicalized_Extension_Headers for signedURL builder

Cloud Storage SignedURLs allows for custom headers you can set to define metadata:

https://cloud.google.com/storage/docs/access-control/signed-urls#string-components

It doesn't look like you can add this in now during signURL construction:

StorageImpl.java

note BlobInfo has metadata defined in it already so maybe use that:

BlobInfo.java

the following shows how to manually construct the signed URL with canonical headers outside of this library
ServiceAccountCredentials creds = ServiceAccountCredentials.fromStream(new FileInputStream("YOUR_CERT.json"));

String BUCKET_NAME = "your_bucket";
String OBJECT_NAME = "a.txt";
String SERVICE_ACCOUNT_EMAIL =<EMAIL_ADDRESS>
String verb = "PUT";
long expiration = System.currentTimeMillis()/1000 + 60;
String Canonicalized_Extension_Headers = "x-goog-meta-icecreamflavor:vanilla";

byte[] sr = creds.sign( (verb + "\n\n\n" + expiration + "\n" + Canonicalized_Extension_Headers +
"\n" + "/" + BUCKET_NAME + "/" + OBJECT_NAME ).getBytes() );
String url_signature = new String(Base64.encodeBase64( sr ));
String signed_url = "https://storage.googleapis.com/" + BUCKET_NAME + "/" + OBJECT_NAME +
"?GoogleAccessId=" + SERVICE_ACCOUNT_EMAIL +
"&Expires=" + expiration +
"&Signature=" + URLEncoder.encode(url_signature, "UTF-8");

System.out.println(signed_url);

Just to note, you'll need to post the headers too but thats outside of this FR:
curl -v -H "x-goog-meta-icecreamflavor:vanilla" -X PUT "https://storage.googleapis.com/.....&Signature=Ol1zLbXd0W%2B3q....3D%3D" --upload-file a.txt

Kindly see pull request #2422


azcopy /bin/sh: azcopy: not found

Which version of the AzCopy was used?
10.15 ( latest)
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
Linux (alpine linux 3:17 )
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
# -----------------------------------------------------------------------------
# Add azcopy to the agent so can be used in projects.
FROM base AS bin-az-copy
# always update to the latest version , pinning version causing build failure

# ENV AZCOPY_VERSION 10.15.0
# https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/storage/common/storage-use-azcopy-v10.md
RUN wget -O tmp/azcopy_v10.tar.gz https://aka.ms/downloadazcopy-v10-linux && tar -xvzf /tmp/azcopy_v10.tar.gz -C /tmp
RUN mv /tmp/azcopy_linux_amd64_*/azcopy /usr/local/bin/azcopy \
    && chown -R root:root /usr/local/bin/azcopy
RUN chmod +x /usr/local/bin/azcopy
RUN rm -rf /tmp/azcopy_linux_amd64_*

FROM alpine:3.17 AS base
# -----------------------------------------------------------------------------
# Push helm packages to OCR images in Azure
ENV AZURE_CLI_VERSION 2.45.0

RUN apk add --upgrade \
    apk-tools \
    openssl

# Install base dependencies
RUN apk --no-cache add --update \
    curl \
    bash \
    build-base \
    zip \
    tar \
    rsync \
    postgresql-client

RUN apk add -U python3 sh \
    && apk add -U --no-cache -q --virtual=build gcc musl-dev python3-dev libffi-dev openssl-dev cargo make libc6-compat \
    && pip install --no-cache-dir azure-cli==${AZURE_CLI_VERSION} -q \
    && apk del --purge build

COPY --from=bin-az-copy   /usr/local/bin/azcopy   /usr/local/bin

Above command create a docker container successfully.,
while trying to run the azcopy command it throughs below error
What problem was encountered?
/bin/sh: azcopy: not found
How can we reproduce the problem in the simplest way?
copy paste above code and try to run it locally in docker-desktop
Have you found a mitigation/solution?
no not yet

replicated via below sample :
FROM alpine:3.17 as azcopy

RUN apk --no-cache add --update \
    git \
    curl \
    bash \
    sudo

# RUN curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash

RUN wget -O tmp/azcopy_v10.tar.gz https://aka.ms/downloadazcopy-v10-linux && tar -xvzf /tmp/azcopy_v10.tar.gz -C /tmp
RUN mv /tmp/azcopy_linux_amd64_*/azcopy /usr/local/bin/azcopy
RUN chmod +x /usr/local/bin/azcopy
RUN rm -rf /tmp/azcopy_linux_amd64_*

Please verify that the azcopy binary has been copied to appropriate location. This is not an issue with azcopy or the download links.

Have you tried yourself and got success ?
Kindly replicate and check !


Immune structure/folds/bubbles recognition

What would be the most straightforward method to identify tissue areas with unique cell organization patterns, such as dense immune aggregates or vascular areas, as well as artifacts such as bubbles or folds? Would the tissue boundary recognition with more iterations solve this or would it require an independent classification model per pixel using a CNN for example?
Thanks

I'm assuming this addresses the question and closing. Feel free to re-open.


Markdown preview: does not preview the file I picked?

When I have tabs disabled and I jump between 2 markdown files to preview, always the first one is previewed. Is this an issue with contexts?
Video:

Seems to be related to using the actions in the editor action bar top right.

The menu item uses the wrong resource. It gets that from the keybindings service...

Underlying issue was that the editor title action bar considers an action to be equal if the id didn't change. Now, the menu keeps the same action instances (since they are already scoped to 'this' menu) and updates them with the proper context instead of re-creating them.
Tho it is somewhat unexpected @bpasero that id means equality

No real reasoning behind it other than I did not want to recreate the toolbar when nothing changed. My weak attempt for not having react components...

:-) maybe the toolbar should diff what did and will render

Yeah, putting it on the toolbar would make more sense.


CSS style hints in style attributes

Old Subject: CSS style hints in


[Bug] docker fe启动无法访问端口

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.1.7-bin-x64
What's Wrong?
fe_1  | 2024-12-07T09:30:16+00:00 [Warn] [Entrypoint]: FE_SERVERS fe1:<IP_ADDRESS>:9010
fe_1  | 2024-12-07T09:30:16+00:00 [Warn] [Entrypoint]: FE_ID 1
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: FE_IP_ARRAY = [<IP_ADDRESS>]
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: FE_EDIT_LOG_PORT_ARRAY = [9010]
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: MASTER_FE = <IP_ADDRESS>:9010
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: CURRENT_FE = <IP_ADDRESS>:9010
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: PRIORITY_NETWORKS = <IP_ADDRESS>/24
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: Current FE is Master FE!  No need check fe status！
fe_1  | 2024-12-07T09:30:16+00:00 [Note] [Entrypoint]: the image is exsit!
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: the priority_networks values is <IP_ADDRESS>/24
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: the conf file path is /opt/apache-doris/fe/conf/fe.conf
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: start add_priority_networks
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: add priority_networks <IP_ADDRESS>/24 to /opt/apache-doris/fe/conf/fe.conf
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: Current FE is Master FE!  No need to register again！
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: Current FE is Master FE!  No need check fe status！
fe_1  | 2024-12-07T09:30:17+00:00 [Note] [Entrypoint]: Ready to start CURRENT_FE！
fe_1  | /opt/apache-doris/fe/bin/init_fe.sh: line 470: [: ==: unary operator expected
fe_1  | StdoutLogger 2024-12-07 09:30:19,530 using java version 8
fe_1  | StdoutLogger 2024-12-07 09:30:19,537 -Dfile.encoding=UTF-8 -Djavax.security.auth.useSubjectCredsOnly=false -Xss4m -Xmx8192m -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:MaxGCPauseMillis=200 -XX:+PrintGCDateStamps -XX:+PrintGCDetails -Xloggc:/opt/apache-doris/fe/log/fe.gc.log.20241207-093017 -Dlog4j2.formatMsgNoLookups=true
fe_1  | StdoutLogger 2024-12-07 09:30:19,844 start time: Sat Dec  7 09:30:19 UTC 2024
fe_1  | StdoutLogger 2024-12-07 09:31:41,094 =====
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |         RuntimeLogger %d{yyyy-MM-dd HH:mm:ss,SSS} %p (%t|%tid) [%C{1}.%M():%L] %m%n
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |         AuditLogger %d{yyyy-MM-dd HH:mm:ss,SSS} [%c{1}] %m%n
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |         RuntimeLogger %d{yyyy-MM-dd HH:mm:ss,SSS} %p (%t|%tid) [%C{1}.%M():%L] %m%n
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |         RuntimeLogger %d{yyyy-MM-dd HH:mm:ss,SSS} %p (%t|%tid) [%C{1}.%M():%L] %m%n
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |         AuditLogger %d{yyyy-MM-dd HH:mm:ss,SSS} [%c{1}] %m%n
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  |
fe_1  | =====
fe_1  | ==============================
fe_1  | RuntimeLogger 2024-12-07 09:31:44,863 INFO (main|1) [DorisFE.start():167] Doris FE starting...
fe_1  | RuntimeLogger 2024-12-07 09:31:45,074 INFO (main|1) [FrontendOptions.analyzePriorityCidrs():194] configured prior_cidrs value: <IP_ADDRESS>/24
fe_1  | RuntimeLogger 2024-12-07 09:31:45,149 INFO (main|1) [FrontendOptions.initAddrUseIp():101] local address: /<IP_ADDRESS>.
fe_1  | RuntimeLogger 2024-12-07 09:31:46,376 ERROR (main|1) [Util.report():128] SLF4J: Class path contains multiple SLF4J bindings.
fe_1  | RuntimeLogger 2024-12-07 09:31:46,392 ERROR (main|1) [Util.report():128] SLF4J: Found binding in [jar:file:/opt/apache-doris/fe/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
fe_1  | RuntimeLogger 2024-12-07 09:31:46,408 ERROR (main|1) [Util.report():128] SLF4J: Found binding in [jar:file:/opt/apache-doris/fe/lib/log4j-slf4j-impl-2.18.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
fe_1  | RuntimeLogger 2024-12-07 09:31:46,409 ERROR (main|1) [Util.report():128] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
fe_1  | RuntimeLogger 2024-12-07 09:31:46,746 ERROR (main|1) [Util.report():128] SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]
fe_1  | RuntimeLogger 2024-12-07 09:31:49,740 ERROR (main|1) [LogLog.warn():157] log4j:WARN No appenders could be found for logger (io.netty.util.internal.InternalThreadLocalMap).
fe_1  | RuntimeLogger 2024-12-07 09:31:49,741 ERROR (main|1) [LogLog.warn():157] log4j:WARN Please initialize the log4j system properly.
fe_1  | RuntimeLogger 2024-12-07 09:31:49,742 ERROR (main|1) [LogLog.warn():157] log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
fe_1  | RuntimeLogger 2024-12-07 09:31:50,218 INFO (main|1) [ConsistencyChecker.initWorkTime():105] consistency checker will work from 23:00 to 23:00
fe_1  | RuntimeLogger 2024-12-07 09:31:57,929 INFO (main|1) [PrivTable.addEntry():89] add priv entry: Node_priv,Admin_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:57,930 INFO (main|1) [PrivTable.addEntry():89] add priv entry: Admin_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,349 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: information_schema, priv: Select_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,350 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: mysql, priv: Select_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,351 INFO (main|1) [PrivTable.addEntry():89] add priv entry: origWorkloadGroup:normal, priv:Usage_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,352 INFO (main|1) [Auth.createUserInternal():503] finished to create user: 'root'@'%', is replay: true
fe_1  | RuntimeLogger 2024-12-07 09:31:58,353 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: information_schema, priv: Select_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,356 INFO (main|1) [PrivTable.addEntry():89] add priv entry: database privilege.ctl: internal, db: mysql, priv: Select_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,357 INFO (main|1) [PrivTable.addEntry():89] add priv entry: origWorkloadGroup:normal, priv:Usage_priv
fe_1  | RuntimeLogger 2024-12-07 09:31:58,357 INFO (main|1) [Auth.createUserInternal():503] finished to create user: 'admin'@'%', is replay: true
fe_1  | RuntimeLogger 2024-12-07 09:31:58,372 INFO (main|1) [AuthenticatorManager.():42] authenticate type: DEFAULT
fe_1  | RuntimeLogger 2024-12-07 09:31:59,770 INFO (main|1) [MTMVService.registerHook():69] registerHook: MTMVJobManager
fe_1  | RuntimeLogger 2024-12-07 09:31:59,770 INFO (main|1) [MTMVService.registerHook():69] registerHook: MTMVRelationManager
fe_1  | RuntimeLogger 2024-12-07 09:31:59,994 INFO (main|1) [Env.getSelfHostPort():1392] get self node: HostInfo{host='<IP_ADDRESS>', port=9010}
fe_1  | RuntimeLogger 2024-12-07 09:31:59,994 INFO (main|1) [Env.getHelperNodes():1446] get helper nodes: [HostInfo{host='<IP_ADDRESS>', port=9010}]
fe_1  | RuntimeLogger 2024-12-07 09:32:00,098 INFO (main|1) [Env.getClusterIdAndRole():1317] finished to get cluster id: 300926441, isElectable: true, role: FOLLOWER and node name: fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7
fe_1  | RuntimeLogger 2024-12-07 09:32:00,422 INFO (main|1) [Env.loadImage():1980] image does not exist: /opt/apache-doris/fe/doris-meta/image/image.0
fe_1  | RuntimeLogger 2024-12-07 09:32:16,985 WARN (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.notifyNewFETypeTransfer():2699] notify new FE type transfer: UNKNOWN
fe_1  | RuntimeLogger 2024-12-07 09:32:16,986 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [LogUtils.stdout():50] StdoutLogger 2024-12-07 09:32:16,986 notify new FE type transfer: UNKNOWN
fe_1  | RuntimeLogger 2024-12-07 09:32:17,073 INFO (stateListener|83) [Env$5.runOneCycle():2722] begin to transfer FE type from INIT to UNKNOWN
fe_1  | RuntimeLogger 2024-12-07 09:32:17,092 INFO (stateListener|83) [Env$5.runOneCycle():2809] finished to transfer FE type to UNKNOWN
fe_1  | RuntimeLogger 2024-12-07 09:32:17,172 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:1 reason:
fe_1  | RuntimeLogger 2024-12-07 09:32:27,270 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:101 reason:
fe_1  | RuntimeLogger 2024-12-07 09:32:37,370 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:201 reason:
fe_1  | RuntimeLogger 2024-12-07 09:32:47,453 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:301 reason:
fe_1  | RuntimeLogger 2024-12-07 09:32:57,520 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:401 reason:
fe_1  | RuntimeLogger 2024-12-07 09:33:07,577 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:501 reason:
fe_1  | RuntimeLogger 2024-12-07 09:33:17,628 INFO (UNKNOWN fe_e4d8af06_583d_47ab_b0f2_ae8abb6692a7(-1)|1) [Env.waitForReady():1102] wait catalog to be ready. feType:UNKNOWN isReady:false, counter:601 reason
What You Expected?
9010和9030端口都未监听，没有启动成功？
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

yes, you didn't start successfully.
wait catalog to be ready. feType:UNKNOWN isReady:false, counter:601 reason
how many FE nodes do you have?

@ixzc only one node


The intensity of ambient light should increase when it's foggy

Having fog in a scene means that there are much more particles that scatter light. Note that we must not use fogColor.a for this purpose because that's dependent on the distance from the camera.

However, if we increase it just because #if defined(FOG) then the scene will suddenly get brighter, which is obviously unacceptable. Perhaps we should give up doing this for now.


Add simplified Chinese and traditional Chinese languages

Awesome, thanks this PR @ZhiyueYi we'll do a review ASAP!

@ZhiyueYi do you know someone that could do a review?

@kefranabg Sorry, I'm not sure who could do a review...

@ZhiyueYi I resolved conflict and added you as a contributor, could you just translate the "share on twitter" label so I can merge?

@kefranabg Something strange happened. It shows random characters on Github markdown.

But my local vs code preview browser shows correctly

I doubt it's a bug from shields.io.
Can we leave the "share on twitter" label in English? Otherwise, we may need to find a workaround to avoid random characters.

Maybe there is a solution:

go to https://shields.io/category/social
fill the user field with a random string
paste your translation to the label input
use the copy badge URL

It should give the correct characters to get it work on Github.
I can do it if you want, I'll just need the translations 😄

@kefranabg wonderful! Thanks a lot for the help! It works 😆

Awesome ! Thanks for your help @ZhiyueYi 8


Revise the Annotation requirements

What's up?
As mentioned in #162, revise the annotation requirements subtitles under the User Requirements and come up with improvements.
To Do

[ ] Revise the Annotation related User Requirements.
[ ] Revise the Annotation related System Requirements.
[ ] Share your ideas with other team members in the next meeting on 16.10.22 @18.00.

Deadline
16.10.22 @18.00.
Additional Information
No response
Reviewers
No response

Annotation section in user requirement section seems to be sufficient except the

bookmarking feature : (<IP_ADDRESS>. Registered users shall be able to bookmark art items, online/offline exhibitions and comments.)


Integration with smooth scroll plugins

Hi, is there a recommended way to make hlslens work with smooth scroll plugins when calm_down is enabled?
Here's my attempt for integration with cinnamon.nvim:
local root = vim.fn.fnamemodify("./.repro", ":p")
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

local plugins = {
    {
        "kevinhwang91/nvim-hlslens",
        opts = {
            calm_down = true,
        }
    },
    {
        'declancm/cinnamon.nvim',
        opts = {}
    }
}

require("lazy").setup(plugins, {
    root = root .. "/plugins",
})

local kopts = {noremap = true, silent = true}

vim.api.nvim_set_keymap('n', 'n', [[<Cmd>lua Scroll("n", 1, 1); require('hlslens').start()<CR>]], kopts)
vim.api.nvim_set_keymap('n', 'N', [[<Cmd>lua Scroll("N", 1, 1); require('hlslens').start()<CR>]], kopts)
vim.api.nvim_set_keymap('n', '*', [[<Cmd>lua Scroll("*", 1, 1); require('hlslens').start()<CR>]], kopts)
vim.api.nvim_set_keymap('n', '#', [[<Cmd>lua Scroll("#", 1, 1); require('hlslens').start()<CR>]], kopts)
vim.api.nvim_set_keymap('n', 'g*', [[<Cmd>lua Scroll("g*", 1, 1); require('hlslens').start()<CR>]], kopts)
vim.api.nvim_set_keymap('n', 'g#', [[#<Cmd>lua Scroll("g#", 1, 1); require('hlslens').start()<CR>]], kopts)

This MWE works fine only when calm_down = false. When calm_down = true, hlslens markers are shown on every second press of "n".
Testing buffer: ia<Esc>20o<Esc>ggyG10P
https://github.com/kevinhwang91/nvim-hlslens/assets/16707112/0758f6b3-9023-4036-a711-d13d5e40e2bb
Thanks!

Can't reproduce it maybe I misunderstood the issue.
The lens disappears if the position is out of range after scrolling.

In "plain" hlslens with calm_down = false, pressing n (or N) doesn't hide the highlighting + markers even if I smooth scroll.
But with calm_down = true and the MWE config, every second lens is shown ([2/11], then [4/11], etc...). While smooth scrolling, cursor appears in out of range positions, so it makes sense that the lens disappears, however, I would expect the require('hlslens').start() call to display it again.
And I have no idea why it happens on every other press.

Try not scrolling with <C-{u, d, f, b}> but just by pressing n or N.

How does typing  n fire the smooth scrolling? Only get a position changed result without being out of range.

Actually,  it should do this on declancm/cinnamon.nvim side, Scroll should add a callback function if the animation ends.
hlslens compute the cursor position and clear lens within throttle that needs a fast refresh. Using debounce is a bad user experience.


[BUG] Messaging unclear for request flow

The messaging is not clear for CAVs and PINs on what to expect when submitting or accepting a request.

When a CAV accepts the request, they dont immediately get the contact information. The PIN has to accept the volunteers help first. The CAV should probably be informed of this once they accept the request. Do they get a notification? Do they get an email? How will they know the request for help has been approved and they have access to the contact information?

Do PINs get a notification once a CAV has offered their help?  Will they receive an email? Where do they go to see if the request has been accepted? Do they need to check back regularly in the app?

This needs to be communicated clearly to both CAVs and PIN.
PIN FLOW
Step 1 -
As a PIN on /requests/find, create a NEW REQUEST. Submit the request.
Step 2
As a PIN, notice that the user is not told where to go to view information about their ongoing request. They are not told that a CAV needs to accept this request, or that as a PIN they will also need to confirm that the PIN has accepted the offer for help before the request can officially begin.
expected behavior
When a PIN submits a request, they should be clearly informed of what the process is like. They need to know to WHEN to check back in the app see if their request for help has been accepted, and WHERE to go to get updates on their request. They need to know HOW to accept this request. In my humble opinion, I think a simple message explaining the process on this screen would be sufficient. (just above the request, after the user has filled out the request information, but BEFORE they submit their request. Maybe a checkbox to confirm they understand the process? Just an idea)

CAV FLOW
Step 1
As a CAV, on a different browser, find the request on the map and accept it by clicking "HELP (PIN's name)".
Step 2 -
Since the PIN has not accepted the offer for help from the CAV, the information on how to complete the request for help is not immediately available. The CAV should be aware of WHEN they need to check on information on help request, and understand that its not immediate. HOW it works (PIN needs to accept offer of help, it is possible it will be rejected, etc), WHERE they need to go to check if the offer is accepted or not. If it is accepted, whats next?
expected behavior
The flow is clearly understood by CAV so they know what to expect and when to check back, where to go. In my opinion, the details of the flow could be placed on THIS SCREEN, right before the CAV sends their initial offer to help:

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

+1, brought this up with @ashwinkjoseph who agreed we need a popup notification after creating a request/accepting a request or doing any major step in the workflow that takes you to the appropriate next screen.

UX to be upgraded on this one

PIN Flow
First time entering

Thank you for joining Reach4Help! As a person in need, you'll be able reach out for help in your area by creating requests. Currently, we can't guarantee that there are volunteers who can help in your area, in which case we'd suggest sharing it with potential volunteers and local volunteer organizations. Thank you for joining us in building this unified platform of help!

First time creating a request

Thank you for creating your first request! You can check the status of your request as it progresses each stage from the sidebar:

Open: Your request is out there but nobody's offered to help yet.
Accepted: A volunteer has offered to take up your request, awaiting your confirmation.

Finished: You and the volunteer have agreed that the request has been fulfilled.

You'll also be receiving notifications as your request passes each stage to remind you of these. If you have any questions or difficulty with this, don't hesitate to contact<EMAIL_ADDRESS>
General creating a request
Show a pop-up routing them to the request timeline page with the text:

Thank you for submitting a request! You'll be notified when a volunteer offers to accept it. To check its status, click/tap here or check "Open Requests" on the sidebar.

Accept volunteer help
Send a notification that routes them to the accept volunteer page:

A volunteer has offered to help! Click/tap here to accept them or check under 'Accepted Requests' on the sidebar.

If accepted:

You've accepted CAV_display_name's help on request_title! Click/tap here to check its status or check under "Ongoing Requests" on the sidebar.

If rejected:

You've rejected CAV_display_name's help on request_title. You'll be notified again when a volunteer offers to accept it. Click/tap here to check its status or check under "Open Requests" on the sidebar.

CAV Flow
First time entering

Thank you for joining Reach4Help! As a volunteer, you'll be able to help people in your area by responding to their help requests. Thank you for joining us in building this unified platform of help!

There's more stuff to add here, but you can work with this till I finish the others...

https://github.com/mcverter/reach4help/tree/bug/668-unclear-flow

FIRST PAGE PIN SEES WHEN THEY REGISTER
This is also the first time they see NewRequest screen


Spacing around port rules is too skinny

Steps:

Go to Services
Click on Create & select ClusterIP
Add Port Rules

Results:  The spacing around the fields for port rules is too skinny.  From Lauren in a previous design bug " Spacing around boxes in the port rules is too skinny" --- needs a dev to convert to grid not table.

Similar to https://github.com/rancher/dashboard/issues/1303
Fixed when converting port rules to grid.

Fixed


sequentialScale with same lower and upper bound produces incorrect value

If i have sequential scale with the same values for the domain and i call/apply it with the same input value as the domain values, i get an a color value that is not within the range of the color interpolater i specified.
e.g.
var ss=d3.scaleSequential(d3.interpolateBlues);
ss.domain([1000,1000]);
ss(1000); // "rgb(0, 0, 0)"

any other value produces the correct result.
Is this expected behavior ?

I think this should be considered a bug; the scale should probably return interpolate(0) for all inputs if the domain is collapsed. (Though if the domain contained NaN, I think interpolate(NaN) would be appropriate, which is what is happening here, erroneously.)


Plugin fails to load on iOS

When starting Obsidian the plugin fails to load, with a very rudimentary error message: Failed to load obsidian-qr-plugin.
The error can also be provoked by tapping "Enable" in the plugin config.

Thank you for reporting the issue.
I can reproduce the error. Unfortunately I have no possibility to get log files.
Do you have any clue what the problem could be?

This plugin might help: https://github.com/KjellConnelly/obsidian-dev-tools

I also have this issue on Android.
I was able to inspect Obsidian on my phone from my PC over ADB and got the following error in the console:
app.js:1

    Plugin failure: obsidian-qrcode-plugin ReferenceError: Buffer is not defined
    at Object.alloc (eval at <anonymous> (app.js:1), <anonymous>:199:3)
    at anonymous (eval at <anonymous> (app.js:1), <anonymous>:1025:24)
    at t.<anonymous> (app.js:1)
    at app.js:1
    at Object.next (app.js:1)
    at s (app.js:1)
(anonymous) @ app.js:1

Rudi is there any progress or this or is there any way for us to assist? I could use QR codes in Obsidian on iOS for sure.

I will give it a try in December when I have little more time to investigate the possible reasons.

That would be great.
My usecase: I have a public function often working outdoors and many times I can assist people by sending them to some website. Using a dynamically generated QR code on my iOS phone is much easier and faster then spelling out a long difficult URL to them.
Thx
From: "Rudi Häusler - @." @.>
Reply to: @." @.>
Date: Thursday, 1 December 2022 at 13:38
To: rudimuc/obsidian-qrcode @.>
Cc: Paul S @.>, Comment @.***>
Subject: Re: [rudimuc/obsidian-qrcode] Plugin fails to load on iOS (#2)
1597064: message 6 of 20)
I will give it a try in December when I have little more time to investigate the possible reasons.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

@AnalogCyan @davidolrik @851597064
I made some small changes and also updated the qrcode lib. I checked it out on iOS.... and it works :-)
So please update to 1.1.0 and will enjoy it.
Thank you all for your patience - took quite long time to get that fixed.
Best regards from Munich!

Very nice. Goodbye lots of QR code images files.


Demo link doesn't work

Please, refresh demo link of your project on Heroku. Thanks.

The app index page looks like this:

When you click something it looks like this:

Add new:

Listing details:


Compiling Project

Can someone teach me how to compile the project into a dll format? I'm a beginner to github. I have no idea what x68 and release means.

I installed virtual studio and cloned the repositories. However, after I selected Among Us as the process, it said it ran successfully, but when I pressed delete, the menu did not pop up.

Is there any way to compile the project and save it as a dll?

https://github.com/ExtraConcentratedJuice/ChristWareAmongUs/issues/25 This might help.

Make sure you go into the configuration manager for the solution and set the target to Release and x86,


rspec3 - doubles or partial doubles from rspec-mocks outside  ....

With:
stomp-1.4.9

ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]

$ rspec --version
RSpec 3.8
  - rspec-core 3.8.2
  - rspec-expectations 3.8.4
  - rspec-mocks 3.8.1
  - rspec-support 3.8.2

This results in:
$ rspec --fail-fast spec/client_spec.rb
RSpec version: 3.8.0
#<Thread:0x000055a54123d138@/home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:193 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	9: from /home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:194:in `block in start_listeners'
	8: from /home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:194:in `loop'
	7: from /home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:195:in `block (2 levels) in start_listeners'
	6: from /usr/share/gems/gems/rspec-mocks-3.8.1/lib/rspec/mocks/test_double.rb:102:in `method_missing'
	5: from /usr/share/gems/gems/rspec-mocks-3.8.1/lib/rspec/mocks/proxy.rb:202:in `raise_unexpected_message_error'
	4: from /usr/share/gems/gems/rspec-mocks-3.8.1/lib/rspec/mocks/error_generator.rb:50:in `raise_unexpected_message_error'
	3: from /usr/share/gems/gems/rspec-mocks-3.8.1/lib/rspec/mocks/error_generator.rb:311:in `__raise'
	2: from /usr/share/gems/gems/rspec-mocks-3.8.1/lib/rspec/mocks/error_generator.rb:327:in `notify'
	1: from /usr/share/gems/gems/rspec-support-3.8.2/lib/rspec/support.rb:106:in `notify_failure'
/usr/share/gems/gems/rspec-support-3.8.2/lib/rspec/support.rb:97:in `block in <module:Support>': #<Double "connection"> received unexpected message :receive with (no args) (RSpec::Mocks::MockExpectationError)
.#<Thread:0x000055a54150bd60@/home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:193 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	6: from /home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:194:in `block in start_listeners'
	5: from /home/straylen/pkgs/rubygem-stomp/stomp-1.4.9/lib/client/utils.rb:194:in `loop'

Looks like:
https://relishapp.com/rspec/rspec-mocks/v/3-6/docs/basics/scope#cannot-create-doubles-in-a-`before(:context)`-hook

I will try and look at this during the coming weekend.
However, if you have a fix I would appreciate a PR.

I confess rspec tests are not a strong skill.
I could use some help figuring this out.

I had a quick look the other day and got as far as working out it was not trivial.


Update getting-service-phone-numbers.md

Corrected typo in title, "Service" was spelled "Srvice" and removed internal comment from public facing push.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

These fixes were just submitted in another PR.  Closing this PR.


Adding more debugging to figure out AI crash

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 3 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.09%) to 97.687%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Battle.Logic/Characters/CharacterAI.cs
1
3
33.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
2206

Relevant Lines:
2253

💛  - Coveralls


Update jQuery to v2.1.4

Thanks!

 I'm working a bit on it for a personal project, I'll certainly make a few updates. :)

I'm also about to update it with some enhancements very soon :)


discriminator: Remove dependency on "full" feature

Problem
There are many recompilations when working on spl crates, starting with spl-discriminator-syn, probably due to crates that are recompiled with different feature sets.
Solution
I tried a few different things, including specifying all syn usage to use the features full and extra-traits, to line up with solana-sdk-macro. I also tried to remove the dependency on the full in one crate, which also didn't really have an effect.
This is the result of that second effort. Unfortunately, it means that generics, lifetimes, and where clauses are no longer supported. The ItemEnum and ItemStruct parsers are really nifty!

So where does this leave us then?

I'd prefer to not merge this to be honest, but you said you wanted to see it. We can keep it up, and maybe if we do the same thing with spl-program-error, we can avoid those recompilations.
But I think the better approach is to figure out the superset of features to enable on our crates everywhere.
Maybe I'll just close this

So where does this leave us then?

I'd prefer to not merge this to be honest, but you said you wanted to see it. We can keep it up, and maybe if we do the same thing with spl-program-error, we can avoid those recompilations.
But I think the better approach is to figure out the superset of features to enable on our crates everywhere.
Maybe I'll just close this

Happy to dive into this tonight so we can get it ironed out!

Happy to dive into this tonight so we can get it ironed out!

Honestly, there's no rush. I'll put up an issue about it and we can figure it out when we have time

Closing this since we have an issue at #4769


Large file

I did kind of a bad thing and checked in a 10MB png.  Do we want to take care of that now by rewriting history and putting the file elsewhere or are we o.k. with a few large files lying around since this repo is likely to end up with lots of analysis type files (not just code)?
Another option is to turn it into a git-lfs repo, but that would also require rewriting history to get rid of binary files.  Thoughts?

Keep for now.
As you allude to, turning this into a git-lfs repo doesn't solve this problem because step one would be re-writing history anyway.  It would only address future problems.  We can keep this in mind.  It would be my preference to wait a couple of more months for git-lfs to mature before requiring it to participate in Twinkles.

Sounds good. Closing.


Add node construction methods to Graph

This is a draft proposal to make explicit graph construction and reusing Constants easier.

Add an environment attribute to Graph. That way, graph transforms and optimizer can easily get ahold of it and use it to build constants.
Add Environment.apply to build an Apply node. That method could eventually implement common subexpression elimination.
Rename Environment.map to Environment.constant, because I find it clearer, and I don't think it's meant to return non-constants.
Add Graph.apply. g.apply(primops.add, node, 1) is the same as Apply([g.environment.constant(primops.add), node, g.environment.constant(1)], g), but a lot easier to write and read.
Add Graph.add_parameter, which creates a parameter for that graph and also adds it to the parameter list. The new parameter is returned.
Add Graph.constant as a shortcut to Graph.environment.constant, for convenience.

I also hide the implementation detail that we use id(obj) as the key in environments, which adds the flexibility of not doing that in the future. I'll note that there is some danger with that approach, because an object's id can be reused after the GC reclaims it. In the case of functions, where the constant contains a Graph and might not contain a pointer to the original function, it is possible (although unlikely) that we'd get a collision.
Another point to discuss is whether Environment should use a WeakValueDictionary. That would allow the GC to reclaim unused constants.

I'll note that there is some danger with that approach, because an object's id can be reused after the GC reclaims it. In the case of functions, where the constant contains a Graph and might not contain a pointer to the original function, it is possible (although unlikely) that we'd get a collision.

Turns out it's not that unlikely. It happened in a test in the type_inference branch when I tried to run them on my machine: two different functions were created with the same id, and one test failed because of it. @abergeron suggested using weakref.finalize to remove an object's id from the map when the GC collects it. I think it's either that or use the actual objects as keys.

I changed the PR to simply add a few methods to Graph. If that looks good, I'll change the rest of the code to use the new methods.

This has been here long enough, time to merge


make log value protected

I suggest to make the log field protected otherwise it could happen that other classes accidentally reuse the log field as in the following example:
import io.sphere.json._ //the package object json extends Logging

class Foo {
  log.info("message")//logs as io.sphere.json.package$ instead of Foo
}

Updated changelog.


Multiple-injection

Resolves #14

Already said that in #14 but I'm really not sure this is worth adding.
I like having a library that doesn't become a huge do-it-all lib. Keeping the API simple is important to me, and adding convenience methods to do something that the user can really easily do on its own if really needed does not seem to go in that direction, but rather adds methods in the API for which the user might wonder why it's here (in the sense "that feature is so simple to do it on my own, why is there a dedicated method to do this, if there is a dedicated method does it means that this is in fact not as obvious as I think it is?" etc)
In your examples, it seems to me that using a simple map allows to achieve the exact same effect that this feature does:
enum Services: String {
  case GMail, Yahoo, Outlook
  let allValues: [Services] = [GMail, Yahoo, Outlook]
}
container.register(tag: Services.GMail) { GmailService() as ThirdPartyEmailService }
container.register(tag: Services.Yahoo) { YahooService() as ThirdPartyEmailService }
container.register(tag: Services.Outlook) { OutlookService() as ThirdPartyEmailService }

let thirdPartyServices = try! Services.allValues.map { container.resolve(tag: $0) as ThirdPartyEmailService }

Sure, it can be done by user with ease. I'm ok with not including that feature.


Demographic data for selected languages

What?
Display Demographic data for selected languages
Why?
For local language conversion
How?
Looked for current language and response consist of details in current language add the language support.

Looks good to me


Add antiforgery support

https://learn.microsoft.com/zh-cn/aspnet/core/security/anti-request-forgery?view=aspnetcore-6.0

definitely don't wanna include it be default!
and create a separate PR for this if you want it reviewed.
and please add a integration test to #500 if you want that to be merged.
thanks!

definitely don't wanna include it by default! and create a separate PR for this if you want it reviewed. and please add a integration test to #500 if you want that to be merged. thanks!

By default, anti is turned off, so there is no performance penalty, but for security reasons such as uploading files, we have to enable it

data annotations PR has been merged but it does not have the antiforgery code. please submit a separate PR for this.

data annotations PR has been merged but it does not have the antiforgery code. please submit a separate PR for this.

okay

@vipwan could you please have a look at this documentation i wrote for antiforgery? let me know if i got some concepts wrong. thanks!


Format view Groupby Header styling

Hello,
My user wants to reduce the row height and group header text, as you can see on the screen its little big. I have been trying to use the Format Current View using json template, but unable to archive the goal.
Is there anyway this can be customized?

Thanks in advance.
Pras

It would be great if the format view allowed you to format the "Group By" row. We have people asking all the time if the "field name : " can be removed. If we have this functionality we could also create accordion like views that could be embedded on a site.

I also have users complaining about group heading size.

I figured I would post my basic theme. https://github.com/gobigfoot/sp-theme It is a very basic Application Customizer that allows you to add custom styles to SharePoint online. I have ours tenant deployed with a bunch of additional styles. Currently this only changes the group heading styles. (Theme Background and reduced the size to 16px)

@prasantabhowmik this issue list is intended for issues related to samples in this repository.
@gobigfoot's solution seems to be a feasible approach, but keep in mind that Microsoft can change the CSS classes at any time, and using an application customizer may affect other elements on the page. Use with caution.


Added a fallback option if no hash is given, but hash has changed.

Hi,
I needed a fallback if the user hits the back button and the hash changes to nothing.
So now it's simply possible to call stickyTabs like this:
$('.nav-tabs-sticky').stickyTabs({
    fallbackHash: '#home'
});

I also increased the version number and added a simple test.

Shouldn't your fallback hash be whatever tab is selected via "li.active > a"? That keeps it consistent with your CSS. Can you explain what situations you wouldn't want that behaviour? Thanks for your PR :)

Ok I'll try to explain step by step.

You open up the page with your tabs. URL is Like http://mypage.tld
You switch to tab-2. URL is now http://mypage.tld#tab-2
You switch to tab-3. URL is now http://mypage.tld#tab-3
You navigate back with your browser. URL should be http://mypage.tld#tab-2 again and tab-2 selected
Now if you navigate back - again - the URL should be http://mypage.tld and the default tab should be selected, but it isn't, because the current li.active > a is tab-2.

The reason for that is, tab-2 has the .active class and the default tab (e.g. tab-1) hasn't. So you have some options to decide which one is the default tab:

Remember the selected tab when the class is initialized. In that moment always the default tab should be selected and change afterwards by this plugin
Use the last one with active class (current behaviour)
My solution with an option, which is nice, but not as good as 1

When I did this PR I forgot that we could remember the initial selected tab just on initialization. Maybe I'll find the time to also add this feature.
I hope you understand the issue, what the current behaviour is and what the real behaviour should be.

Hi,
I updated the script. Now the default tab is remembered on initialization and used if no hash is given while you are going back in the history.

Can you see if this gist would work for you?
https://gist.github.com/aidanlister/1d36815809977b21e0f0

Fixed now

Hey Aidan,
good job. Had to use your little helper again and it works fine. Sorry that I missed to answer.


most model types now support flash attention 2 regardless of multipack support

wow! can't wait to try it!

Happy to have flash attention for phi3 👍🏼