Support the canonical format.

See https://tools.ietf.org/html/rfc7049#section-3.9.
This makes it possible to compare objects for bitwise equality (it also makes signatures/signature verification easier).

These are the requirements for canonical format.

[x] Integers must be as small as possible.
[x] The expression of lengths in major types 2 through 5 must be as
short as possible.  The rules for these lengths follow the above
rule for integers.
[ ] The keys in every map must be sorted lowest value to highest.
Sorting is performed on the bytes of the representation of the key
data items without paying attention to the 3/5 bit splitting for
major types.
[ ] Indefinite-length items must be made into definite-length items.

The way item sorting is currently implemented makes solving #79 a bit harder as it places serialized objects in temporarily allocated memory. That's in theory a non-issue when serializing BTreeMap data (which won't be there in embedded anyway -- it's only about avoiding ifdef hell there), but harder AFAICT for serialization of non-packed struct fields (as serde calls serialize_field, so we can't apply the field ordering at build time).
Is there currently (or would it make sense to have) an option to disable canonicalization in a serializer? (I figure it may have performance benefits on std as well, but can't tell whether that's actually an issue).

Two more notes in this context:

The online reference implementation does not produce canonical CBOR either, weakly indicating that we might not need to produce canonical CBOR unconditionally (but only when requested).
There are some pending errata items on the CBOR RFC that relate to canonicalization. There is an update to CBOR in the works that addresses those. (Which is not really breaking, given that the canonicalization rules are suggestions for what particular applications could specify as their canonical format, rather than prescribing what canonical CBOR is).

This is done. Convert the values you want to serialize in canonical format to values and then call serialize.


about backbone

why don't you use lite-hrnet as your backbone？ limited performence or lite-hrnet  isn't suitable in this paper

The lite-hrnet and our DEKR are concurrent work (CVPR2021). Our work was completed earlier, so we did not try to use the lite-hrnet.

so have you test the performance of combination of lite-hrnet and your dekr, or  whether it is suitable to dekr?

Hi, you can try it if you are interested in it. We believe that our approach can bring a large gain above the lite-hrnet regression baseline.


Add Initial Content

[ ] A contact button (email, other social)
[ ] An about me page
[ ] Experience (resume)
[ ] portfolio (links)

Nice work! Can you combine some of these pages together to simplify your navigation menu?


Cron tasks for storing snapshot

Either using system cron or Mojolicious::Plugin::Cron
Internal is preferred:

Wont need a special route thats bypasses auth
Could change time setting from yancy

needs to read current active games and loop though a minion route

Initial testing underway


Add validation for max fund balance value

Fix #223
@dice-cyfronet/atmo-dev-team, @mpawlik please take a look

:+1:


$componentController vs. $compile

This is more of a question than anything else, but in your component spec examples you provide a couple different ways of testing. One is the traditional directive testing done with $compile. The other is using $componentController.
The angular docs recommend using $componentController but $compile seems so much more powerful. You provide examples of both, but could you provide some insight as to why anyone would want to use $componentController over $compile? What do you use in your own testing?

Hi @benjyblack!
That's actually a good question and I guess I should update the guide. I actually wrote a blog post about how to test components last year.
I'm used to $compile testing both the compiled element and the controller, but if you don't need or want to test the compiled element you can just use $componentController. I think it also depends on your testing strategy, you could use $componentController for testing the logic of your components and E2E Testing for the compiled part and how they interact with each other.
Let me know if it helps!

Thanks for the answer @Puigcerber! After trying out some testing with $compile I think I've actually come to the conclusion that I would prefer to use $componentController. Testing the template is a lot of overhead and Jasmine/JQlite don't lend themselves particularly well to the job.
I like your suggestion of unit testing via $componentController and E2E testing the compiled components and their interaction with other parts of the app. Thanks for the clarification :)
BTW I also asked this question on StackOverflow. The answers there seem to be in line with yours.


Enable Presenter View?

How feasible would it be to allow the "Use Presenter View" option to be toggled in python-pptx?
Under the Slide Show tab, there's a checkbox to "Use Presenter View" which is only available when the PowerPoint is being used in an environment utilizing multiple displays.
I've searched for this option in the python-pptx documentation, as well as the currently open issues and pull requests, but I couldn't really find anything that indicates that this can be configured.
Perhaps this has been considered or discussed in the past with the decision not to allow for this particular configuration, so any references to such dialogue would be helpful.

The first question would be whether that option is transitory or persistent. Like if you set it, save, close, and reload, does it come back? or do you have to select it again.
If it's persistent and it is presentation-specific (not global to a particular computer), it almost certainly is saved in the PPTX file. If not, it's probably stored in application config somewhere or only remembered for the duration of a session.
If you can determine it is persistent, then the next step would be to look for where it is stored in the package (i.e. in which "part" (package file)). My bet would be in app.xml or maybe settings.xml.


add new hooks for instrumenting dataloaders

Pull request checklist

[x] Please read our contributor guide
[x] Consider creating a discussion on the discussion forum
first
[x] Make sure the PR doesn't introduce backward compatibility issues
[x] Make sure to have sufficient test cases

Pull Request type

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
add new hooks for instrumenting dataloaders

DgsDataLoaderScanningInterceptor: allows for wrapping a dataloader as it is initially being registered, including changing the type of the data loader
DgsSimpleDataloaderInstrumentation: an even easier way to add instrumentation like metrics, tracing, etc...

also note: it is likely that in the future this will be able to simplify the current micrometer metrics instrumentation that uses ByteBuddy.

I'm curious if you've tried to replace the bytebuddy stuff with this. At the very least it would be a good way to test the new API, see if it's possible or what you run into.
I generally like the approach with the two different interfaces that happen at different times in the lifecycle.

@kilink @srinivasankavitha @paulbakker PTAL
@paulbakker I haven't yet, as the tests for the data loader metrics are currently disabled. Re-enabling them looks to be moderately involved so I was going to do that and the new style of instrumentation together as a follow up.


Ask the user to choose the output path only after processing

Remove the output path as a initial input of the program. Process everything and output that into a temporary file. After finishing the process stage, ask the user where he wants to store the output and just move the temporary file to that path.

53b089b8a4c9dea6853fe9fe39050019c6700afe


Address non-happy paths

Sometimes the file_info messages don't have line and column.  Sometimes a sync will get a "file unchanged" message or an error message.  I wrote tests to cover these and fixed the Trio code.
I didn't fix or address the qt code.  In particular, I made a change to the commands.py file (added a SyncResponse type (which has a message field).  This might break something in the qt_server.
(This PR builds on my previous two.)

Let's wait until #3 stabilizes then. Also I don't think we should merge this without checking the Qt code. Hopefully commands.py should be very stable and that won't happen to often. Otherwise we may need to split this repo into three packages. I'll check the Qt code once #3 and #4 land.

I agree we should check Qt code before merging.  I just haven't got around to running it yet.


Create tests

Created tests for:

creating a blog post
creating super user non interactively
creating menu items
creating about page
creating landingpage

Next tests:

testing views


SonarQube release of version 9.4 officially out

Hello @DaveAldon,
Wanted to say thanks again for your help supporting version 9.3.
Couple of days ago, SonarQube released version 9.4 officially.
May I ask if it is possible for this project to bump SonarQube to version 9.4 please?
Also, cold you please teach me "what did you do last time" for the bump to version 9.3?
Basically, if there are steps explaining how to bump versions, I would like to give it a go for version 9.4, 9.5, etc..
Thank you!

Hi @patpatpat123, that's a great question. It's actually pretty easy to do once you know where to look.
Sonarqube updates a lot, and has a lot of builds underneath a major version. The arm64.Dockerfile needs the full build number to pull the image. So on line 89 of the arm64.Dockerfile I have a variable to hold the version. All I do is find that number and toss it in here:
ARG SONARQUBE_VERSION=<IP_ADDRESS>424

And to fully answer your question, how can you do this yourself, go to this sonarsource website that has the links to all possible binaries, and find the latest and plug that version into the above arg:
https://binaries.sonarsource.com/?prefix=Distribution/sonarqube/

I'll add this explanation to the readme as well.

Understood, thank you!


[Travis] Switch to Xcode 6.4

See https://twitter.com/travisci/status/616154472897773568.

:+1:

Thank you!


Create3 Lidar Not Working

Trying to follow this demo: https://github.com/iRobotEducation/create3_examples/tree/humble/create3_lidar
Setup
Roomba:
FastRTPS Middleware
H.1.0 Firmware
Raspberry Pi
Raspberry Pi 4
Ubuntu 22.04 Desktop
ROS2 Humble installed
.bashrc is setup for FastRTPS
Pi and Roomba communicate through Ethernet over USB
VM on my MacBook
Ubuntu 22.04 Desktop
ROS2 Humble installed
.bashrc is setup for FastRTPS
Lidar connected to Pi
https://user-images.githubusercontent.com/71447892/227058924-a07a73c1-a43b-4d3d-9344-819e47bef95c.MOV

I worked with Professor Briana Bouchard to get the 3 devices to communicate via the wireless network, so I don't believe the problem is there. The roomba, pi, and my VM are all connected to the same wifi network. They are all using FastRTPS too. Lastly, we did disable Multicasting by following the FastDDS instructions on https://iroboteducation.github.io/create3_docs/setup/xml-config/#fast-dds.
From my VM, I can see the Roomba's topics when I do ros2 topic list and I can access the Roomba's webserver from my VM's browser.
Running the nodes
On my pi:

ros2 launch create3_lidar sensors_launch.py which outputs this:

To fix the cannot bind to specified serial port I do sudo chmod 777 /dev/ttyUSB0 and re-run ros2 launch create3_lidar sensors_launch.py which outputs this:

This command also causes my lidar to stop spinning for a second and then start spinning again.

In another terminal window I run ros2 launch create3_lidar slam_toolbox_launch.py and get this:

I never see [async_slam_toolbox_node-1] Registering sensor: [Custom Described Lidar] as the repo README describes.

I open a third terminal window and run ros2 run teleop_twist_keyboard teleop_twist_keyboard. This allows me to successfully drive the roomba around!

On my VM:

I open a terminal and run rviz2 and open the right rviz file, and my rviz window shows this:

In my terminal window where I ran rviz2 I start seeing these messages:

I open a second terminal and run rqt_graph and get this:

Not sure where the issue is. My devices can all communicate with each other, but somewhere the Lidar's readings are not being captured or sent the way they should be.
Any help is appreciated.

A few things to check:

I don't see the create3's odometry node connected to the /tf topic, so I think that something in the create3 <-> host PC connection is not working correctly. Where did you run rqt_graph? If you run it on the same machine that is running slam_toolbox_launch.py, you should see one of the C3's nodes publishing transforms.
Make sure that your transform tree is connected: ros2 run tf2_tools view_frames.py The resulting .pdf should show you a tree that includes a path from laser_frame to the odom.
If the timestamps from the C3's publications are sufficiently out of step with the timestamps on the machine generating lidar output, then slam_toolbox will not be able to properly map the lidar samples, so it's worth doing a sanity check on that (e.g. from the pi do wget http://<IP_ADDRESS>/logs-raw and verify that it's doing NTP stuff and the log timestamps are in the right ballpark.

btw: if you add the user account that is running the lidar sensors to the dialout group, you should avoid that permission problem. I made some notes here https://github.com/iRobotEducation/create3_examples/issues/42 that describe how to set up udev rules that will ensure the lidar is always available at a fixed filesystem location

To address the 3 points from @carlsondc-ceva

I ran the original rqt_graph on my VM. Here is the rqt_graph on my pi:

When I run ros2 run tf2_tools view_frames.py I get a message saying "No executable found"
The logs show a latest timestamp of Mar 23 16:28:22 which I think is UTC time. My Pi and VM are on CST time Mar 23 11:28

I tried following https://iroboteducation.github.io/create3_docs/setup/compute-ntp/ exactly, but when I do sudo chronyc clients I only see
Hostname                      NTP   Drop Int IntL Last     Cmd   Drop Int  Last
===============================================================================

I added this to my /etc/chrony/chrony.conf:
server <IP_ADDRESS> presend 0 minpoll 0 maxpoll 0 iburst  prefer trust
# Enable serving time to ntp clients on <IP_ADDRESS> subnet.
allow <IP_ADDRESS>/24

When I run ros2 run tf2_tools view_frames.py I get a message saying "No executable found"

Run sudo apt install ros-humble-tf2-tools on the machine that is running the slam_toolbox node, then try it again. The first goal is to prove to ourselves that all of the necessary topics and transforms are visible to the slam_toolbox. If they are all there, then the next step is to check out timestamp integrity.
Can you clarify what nodes are running on what devices? I'm confused by why the rqt_graph output above shows e.g. the /scan topic coming into the /rviz node, but not the RPLidar node that is producing it.

I will do the sudo apt install ros-humble-tf2-tools and get back on that.
In the meantime, to answer your question regarding clarifying what nodes are running on what devices:

On the Pi I run ros2 launch create3_lidar sensors_launch.py, ros2 launch create3_lidar slam_toolbox_launch.py, and ros2 run teleop_twist_keyboard teleop_twist_keyboard
On my VM I run rviz2

I am following this guide exactly: https://github.com/iRobotEducation/create3_examples/tree/humble/create3_lidar
My SBC is my Raspberry Pi, and my secondary computer for rviz is my virtual machine on my Mac.

ok, cool. and on the pi, you are able to see all of the publications from the create3, right? e.g. if you do ros2 topic list you see the wheels, IMU, etc?

When I do a ros2 topic list I see this
/battery_state
/cmd_audio
/cmd_lightring
/cmd_vel
/dock_status
/hazard_detection
/imu
/interface_buttons
/ir_intensity
/ir_opcode
/kidnap_status
/mobility_monitor/transition_event
/mouse
/odom
/parameter_events
/robot_state/transition_event
/rosout
/slip_status
/static_transform/transition_event
/stop_status
/tf
/tf_static
/wheel_status
/wheel_ticks
/wheel_vels

I ran sudo apt install ros-humble-tf2-tools and the last line of the output was 0 upgraded, 0 newly installed, 0 to remove and 94 not upgraded, so maybe I already had that installed.
Running ros2 run tf2_tools view_frames.py`` still gives me No executable found```

So i tried running ros2 run tf2_tools view_frames instead of ros2 run tf2_tools view_frames.py and I got this an output:
[INFO] [1679698865.995797402] [view_frames]: Listening to tf data for 5.0 seconds...
[INFO] [1679698871.049957789] [view_frames]: Generating graph in frames.pdf file...
[INFO] [1679698871.060249007] [view_frames]: Result:tf2_msgs.srv.FrameGraph_Response(frame_yaml='[]')

And I have attached the pdf file too.
frames_2023-03-24_18.01.11.pdf

Hello. You should definitely be able to see some transforms, so that is likely the source of your problem. One note, I am running ROS2 galactic, not humble. I haven't tried on humble, though I don't think it should be too different.
This zip file working_example.zip
has a brief ros bag capture (example.bag) which you can compare against. The transform graph should look like something like this:

The output from running
for node in $(ros2 node list)
do
  ros2 node info $node
done

is in that .zip file as node_info.txt and should tell you how everything needs to be connected. I don't have a great setup to do a screenshot of rqt_graph output at the moment.
If that doesn't provide you with enough information, then you might want to get directly in touch with @alsora or whoever the designated point-of-contact is within iRobot for this sort of thing.

All of these diagnostics should be run while you've got the sensors_launch and slam_toolbox_launch scripts running, the goal here is to determine whether all of the various data sources are talking to each other. This means that the lidar node should be publishing laser scans to some topic, and the SLAM node should be subscribed to that topic. The Create3 should be publishing a bunch of different transforms to the /tf topic, and the relationship between those transforms should provide a way to translate laser scans to the 'odom' frame. The SLAM node then is responsible for figuring out the transform between the 'odom' frame and a 'map' frame that makes sense given the laser scans.
I'll break down the command above:

ros2 node list : outputs a list of all the ROS2 nodes that are discoverable from this machine.
for node in $(ros2 node list): iterate over the ROS2 nodes, storing the name in the variable node
ros2 node info $node: display the subscriptions, publications, services, etc associated with this node.

I don't know about rviz2, based on what you shared above with the empty transform graph I think it makes more sense to establish whether the nodes are all exchanging the information they need before worrying about the visualization.

Sounds good! I ran the sensors_lauch and slam_toolbox_launch on the Pi, and then ran:
for node in $(ros2 node list)
do
  ros2 node info $node
done

and I got this output:
my_node_info.txt
Which is a lot shorter than what you had

Even stranger, after I run the sensors_launch and slam_toolbox_launch on the pi, I did a ros2 node list and got:
/_internal/composite_hazard
/_internal/kinematics_engine
/_internal/mobility
/_internal/stasis
/mobility_monitor
/motion_control
/robot_state
/static_transform
/system_health
/ui_mgr

Shouldn't I see /rplidar_node and /slam_toolbox and others??

This is what my my file for FASTRTPS_DEFAULT_PROFILES_FILE looks like:
<?xml version="1.0" encoding="UTF-8" ?>
<profiles xmlns="http://www.eprosima.com/XMLSchemas/fastRTPS_Profiles">
   <participant profile_name="unicast_connection" is_default_profile="true">
       <rtps>
           <builtin>
               <metatrafficUnicastLocatorList>
                   <locator/>
               </metatrafficUnicastLocatorList>
               <initialPeersList>
                   <locator>
                       <udpv4>
                           <address>CREATE3_ROBOT_IP_ADDRESS</address>
                       </udpv4>
		   </locator>
		   <locator>
                       <udpv4>
                           <address>MY_VM_IP_ADDRESS</address>
                       </udpv4>
                   </locator>
               </initialPeersList>
           </builtin>
       </rtps>
   </participant>
</profiles>

Are you saying to get rid of the FASTRTPS_DEFAULT_PROFILES_FILE from the .bashrc?
My ROS_DOMAIN_ID is set to 0 (default) when I check the Roomba's web server. I tried setting the ROS_DOMAIN_ID on my pi to be 0 by adding export ROS_DOMAIN_ID=0 to the .bashrc, but that still doesn't show me more nodes than before.

yeah, try to omit the FASTRTPS_DEFAULT_PROFILES_FILE specification. Comment that line out in your .bashrc file, then log out/back in and try again.
I've got a pretty decent handle on ROS2 itself, but the RMW config is black magic to me.

Tried it, same result. ros2 node list gives this:
/_internal/composite_hazard
/_internal/kinematics_engine
/_internal/mobility
/_internal/stasis
/mobility_monitor
/motion_control
/robot_state
/static_transform
/system_health
/ui_mgr

My slam_toolbox_launch never outputs [async_slam_toolbox_node-1] Registering sensor: [Custom Described Lidar] like the demo says it should.

try a ros2 daemon stop and/or restart the pi, and then go for it again? I am running out of ideas here.

Ok I restarted my Pi and did ros2 daemon stop. I also had removed the FASTRTPS_DEFAULT_PROFILES_FILE from my .bashrc.
On the pi I ran sensors_launch and slam_toolbox_launch and then finally I did ros2 node list and I got:
/_internal/composite_hazard
/_internal/kinematics_engine
/_internal/mobility
/_internal/stasis
/mobility_monitor
/motion_control
/robot_state
/rplidar_node
/rviz
/slam_toolbox
/static_transform
/static_transform_publisher_jnq4FVKTr16ve5EV
/system_health
/transform_listener_impl_aaaaddb22b20
/transform_listener_impl_aaab0e606b80
/ui_mgr

I also did
for node in $(ros2 node list)
do
  ros2 node info $node
done

and I got:
my_node_info_2.txt
Here is the rqt_graph on my pi:

lastly, my slam_toolbox_launch kept saying:
[async_slam_toolbox_node-1] [INFO] [1680032751.658372302] [slam_toolbox]: Message Filter dropping message: frame 'laser_frame' at time<PHONE_NUMBER>.510 for reason 'discarding message because the queue is full'
[async_slam_toolbox_node-1] [INFO] [1680032751.821140257] [slam_toolbox]: Message Filter dropping message: frame 'laser_frame' at time<PHONE_NUMBER>.657 for reason 'discarding message because the queue is full'

over and over
Hope all this info helps narrow it down

What is the ros2 run tf2_tools view_frames.py output?
I am deeply suspicious of the fact that the rqt_graph output doesn't show any of the ROS nodes or topics. Specifically, there is no /robot_state node here that is publishing to the /tf topic.

The message that you're seeing is because there is a buffer that is holding onto laser scans and waiting to get enough information to map them from the laser_frame frame to the odom frame. This information comes from /robot_state, and based on the rqt_graph output, I doubt that it's getting it.
So I don't know what conditions allow you to see the nodes when you do ros2 node list on the pi but not have them show up when you run rqt_graph on the pi: solve that problem and you will probably have a working system

Here is the output to ros2 run tf2_tools view_frames
frames_2023-03-28_15.13.51.pdf
In my rqt_graph, should hide or select certain things?

I hit the reload graph button on rqt_graph and I got this:

Ok I will try ros2 run tf2_tools view_frames when I'm not running the slam_toolbox / sensor nodes.
In the meanwhile, if someone from iRobot can help me out, I would really appreciate that!

Any progress here? I'm fairly new with ROS2 and would love to pick up any tricks you've figured out.

No real progress. My tf tree does not look the way it is supposed to. If you have any ideas, I am all ears!

If you try to visualize that map in rviz, what do you see? If the SLAM node is outputting any sort of map, then that is a good sign! It won't do that unless it has laser scans and the transforms necessary to connect the odom frame to laser_frame frame.

Unfortunately, my rviz (running on my VM) gives me a message saying that the map does not exist:

I'm hoping people figured this out already, but if not, I ran into the same problem and the issue was indeed a mismatch of timestamps on the raspi. From a vanilla Ubuntu Raspi Server install, there aren't any NTP servers defined for synchronization, so the timestamps on the raspi were something like Mar 2023 for me, but the robot timestamps were present day.
Fix was to edit /etc/systemd/timesyncd.conf to have something like:
[Time]
NTP=ntp.ubuntu.com
FallbackNTP=0.us.pool.ntp.org 1.us.pool.ntp.org

Then reboot or systemctl restart systemd-timesyncd.service and check systemctl status systemd-timesyncd.service until it syncs after a few minutes.
Demo worked great on Galactic after that. There might be more legit ways to address this - I just opened iRobotEducation/create3_docs/pull/428 to include these steps in the setup documentation.

Good info. In my particular test environment, the wifi network for "untrusted devices" not fully controlled by our IT group has no internet access, so my approach for time synchronization is to have the raspberry pi act as the NTP server to the Create3 over the USB connection (and I manually set the clock on the pi when I turn it on). The directions here worked.

@ChrisBove This is interesting; I now see that you're right that this file is unconfigured, but my experience has been that my Raspberry Pi receives a time sync anyway. I wonder if the network infrastructure matters (that is, maybe my network sends time server info over DHCP and yours does not)? I am leaning towards making this step optional instead of required, or suggested in the case that the user is having trouble with time sync. Is it worth having the user try running timedatectl and only configure this file if necessary?

Ah, I forgot those directions when I brought the raspi up. I just tried that now and didn't work out for me as written - I needed to modify the robot's NTPD config file to get it to sync with the raspi. I'll add that to my PR for discussion there, and I'll adjust my PR to remind people to do the NTP configuration steps (since that at least syncs the time between the Create3 and compute board).
@shamlian I think you're right - I did notice in timedatectl logs that it was trying to connect to my router for NTP (and failing), so it's possible some routers do that while others don't. It would be best to make this an optional step - I'll make that change.


Update Block Registration to Happen Automatically for any blocks containing a block.json file

Description of the Change

This changes the block registration flow so that all blocks located within the directory that have a block.json file get automatically registered.
They also automatically get their  added if the directory where the  file is located also contains a  file

Closes #62
Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my change.
[ ] All new and existing tests passed.

Changelog Entry

Credits

Props @

@gthayer I have updated this PR based on how #85 includes all the files. In my testing, this still works and feels much lass hacky. Let me know what you think.

LGTM!


New version: Unity.Unity.2021 version 2021.3.41f1

Created by 🥟 Dumplings in workflow run #6825.

Log
Updated: 2021.3.40f1 → 2021.3.41f1
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


firejail: Fix opengl support for various apps

Description of changes
Fixes opengl support for various apps including Firefox, see https://github.com/NixOS/nixpkgs/issues/55191
Upstream fix https://github.com/netblue30/firejail/pull/5132 but would be cool to merge this too since it could take a while for a new upstream release.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@onny please rebase


Trigger signing via self-hostet git instance

This PR is ready to review.
@TomaszAIR be aware that I have not tested those changes cos I do not know if it is a good idea to trigger this pipeline.


Mortar recipes support "null" in CraftTweaker Zenscript

Describe your suggestion:

Now when we write a Roots Mortar recipe like this:

Mortar.addRecipe(*3,
[
       <mysticalworld:copper_ore>,&ltmysticalworld:copper_ore>,null,null,null
]
);

It is syntax correct, but will do nothing when you put 2 copper ore into Mortar and try to grind them.
My suggestion is to make Mortar recipe adding method support "null", so that we can put any number of materials into custom recipes as inputs.
Describe alternatives you've considered:
If this is difficult for devs to do so, maybe you can just disable "null" in Mortar recipe adding method.
For example,

Mortar.addRecipe(*3,
[
      &ltmysticalworld:copper_ore>,&ltmysticalworld:copper_ore>,null,null,null
]
);

will throw an CraftTweaker exception and write some information into crafttweaker.log.

Okay, so the issue isn't so much to do with nulls, but to do with the fact that the mortar was originally only designed to support spell recipes, which are specifically recipes of 5 ingredients. It was additionally modified to support recipes with 5 ingredients that just do general crafting rather than generating a specific type of spell dust.
This system was then extended to allow for processing-style recipes: you create a recipe with 1 ingredient, and it automatically creates recipes for 1, 2, 3, 4 and 5 ingredients, modifying the output accordingly (so if the original output was an itemstack with a count of 2, you would get 2, 4, 6, 8, 10 respectively).
Thus, it's only really designed to cope with 5 ingredients. Obviously I'm failing to clear out nulls, as there's already code in place to specifically say "hey, it has to be 1 or 5 ingredients".
I think what you're trying to do is ore duplication: 1 ore = 1.5 dust.
I'm not sure how to best go implementing this code-side. It's possible that I could specify a fractional/decimal float value for the output where one ore has a 50% chance of an extra, and 2 ore has a guaranteed chance of 3, and 3 ore has a guaranteed 4 ore and a chance of 5, and so-on.
I'll need to consider it further, but I'll definitely strip out nulls when checking for valid quantities of ingredients. I forgot that this was standard practice for padding in CraftTWeaker.

Oh, thanks for your reply!
I know it may be difficult to change the Mortar mechanic because doing so may leads to a re-construct of codes.
I just post this issue for a suggestion. You may choose the best way you think to deal with this issue.
Thanks again!

I think I'll add an additional mortar recipe type that takes a percentage chance for additional output and quantity of potential additional output and make that available via CraftTweaker; it should resolve the majority of issues, and it can also be used to automatically create recipes with 1-2-3-4 and 5 inputs.

Unfortunately, I'll most likely have to delay this until 3.2.


[No QA] Asking for company name and URL during invoice creation

Details

Updates the invoice creation flow to support adding company name and URL if it wasn't added before.
Fixed Issues

$ https://github.com/Expensify/App/issues/45174
$ https://github.com/Expensify/App/issues/45173
PROPOSAL: N/A
Tests

[x] Verify that no errors appear in the JS console

!Pre-step: Update hasInvoicingDetails check to always return false so you can always see the expected screen. Please, remember that API doesn't support adding company name and the website for now.

Press FAB -> Send Invoice
Go through the steps to reach the confirmation screen. Make sure you see the Next button instead of Send Invoice.
Tap on the Next. You should appear on the Company info page. Make sure it looks as expected.
Make sure the validation on the page works as expected.
Tap Send invoice -> the invoice should be successfully created.

Offline tests

Same as in the Tests section
QA Steps

[x] Verify that no errors appear in the JS console

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1721825016527359

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/52f7d703-e7af-414f-a562-4d1591daf1b8

Android: mWeb Chrome

https://github.com/user-attachments/assets/4d0bf04a-386c-4574-9a71-4c3e9c65e471

iOS: Native

https://github.com/user-attachments/assets/94adf916-0f4e-4c30-b9ad-df272d09bdeb

iOS: mWeb Safari

https://github.com/user-attachments/assets/34835217-9f25-4e07-9df4-1f4b45de2f08

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/db013039-f227-4f87-8f5e-3bfdfb29073d

MacOS: Desktop

https://github.com/user-attachments/assets/35e91340-cfcd-4ef4-b349-e81295da6646

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@getusha I've applied the requested updates, please take another look

@getusha kind bump 🙂

@getusha can you prioritize getting this done please?

@getusha can you prioritize getting this done please?

👍 will be on it in 2 hours.

@VickyStash seems like we don't allow urls without protocols, and the error message doesn't looks like misleading. should we have a new copy for this? wdyt @VickyStash?

@VickyStash seems like we don't allow urls without protocols, and the error message doesn't looks like misleading. should we have a new copy for this? wdyt @VickyStash?

I've reused the existing isValidWebsite check for the website validity and the existing error message.
@madmax330 Should I use another message/method to check it?

I think this message is fine since we already validate this type of field

BUG: Crash when sending invoice from chat 2nd time

Send invoice using the steps in the PR description
Press the + from the composer
Send Invoice > Enter Amount > Next > Next

Note: you may have to try again a couple of times
https://github.com/user-attachments/assets/cb2a0360-5bc9-4082-ad30-f2c86f1000dd

We need the company name and URL to create a Stripe Connect account, and so we will ask this one time, on the very first invoice being sent from a workspace

@VickyStash It always navigates me to enter both fields as new, despite filling it for previous invoices.
https://github.com/user-attachments/assets/944ed177-648b-4279-9bfe-e1f499b30330

@VickyStash It always navigates me to enter both fields as new, despite filling it for previous invoices.

It's cause you followed the pre-step described in the PR:

!Pre-step: Update hasInvoicingDetails check to always return false so you can always see the expected screen. Please, remember that API doesn't support adding company name and the website for now.

@getusha So it always shows you the screen for testing purposes cause you updated it so. When the API updated the check will works as expected.

BUG: Crash when sending invoice from chat 2nd time

Send invoice using the steps in the PR description
Press the + from the composer
Send Invoice > Enter Amount > Next > Next

Note: you may have to try again a couple of times
Screen.Recording.2024-08-06.at.2.25.10.in.the.afternoon.mov

@getusha It looks like this bug isn't related to this PR, see relevant issue https://github.com/Expensify/App/issues/46821

It's cause you followed the pre-step described in the PR:

We will be handling that as a follow up? is it awaiting backend changes?

We will be handling that as a follow up? is it awaiting backend changes?

Yes, I'll prepare a follow-up when API is ready

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.18-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Set the keep alive/reconnect configuration of grpc cilent according to client-go

The keep alive/reconnect configuration of grpc client of client-c differs a lot with client-go, this pr set the keep alive/reconnect configuration of grpc cilent according to client-go.

/merge

/run-all-tests


Fix side-view cursor title to use y,z coordinate instead of x,y

Set grid to none. When you hover the cursor on the side-view, the cursor title uses (x,y) coordinate. You can tell because the first coordinate is always 0, no matter where the cursor moves. Instead, the cursor title should use (y, z) or (z, y) coordinates

Note this will have to be changed back with #488.


[CLI]: wandb.init is altering my flags (Tensorflow)

Describe the bug

I have some tensorflow (no keras) code I have to use and it has a function (A) that is called before training starts, altering some of the flags. This works fine without wandb but when I try to pass the FLAGS object as the wandb init config the FLAGS are altered. It resets them to the state they were in before being altered by the function A. No idea why this might happen...

FLAGS = tf.app.flags.FLAGS
config_and_print_log(FLAGS) # A: alters flags
wandb.init(project='TF-DNet', config=FLAGS)

Additional Files
No response
Environment
WandB version: 0.10.33
OS: Linux-5.4.0-125-generic-x86_64-with-debian-bullseye-sid
Python version: 2.7.15
Versions of relevant libraries:
tensorflow-gpu            1.3.0
Additional Context
No response

Ok, this let's me train at least:
import copy
wandb.init(project='TF-DNet', config=copy.deepcopy(FLAGS))

Still, when I view the config in the webinterface, it is just the initial config, the changes are not there, although they are applied before init runs.

A better solution seems to be using
 wandb.init(project='TF-DNet', config=FLAGS.__dict__)

This results in the altered values showing up in the webinterface.
Still, this should not require debugging imo, so I'm leaving the issue open for now.

@wobbba
In the latest version of wandb we dropped support for python2 and we won't be back-porting changes.
Is there a specific reason you are using  wandb==0.10.33, python 2.7 and tensorflow 1? Is it possible for you to upgrade to the latest versions?

The reason I'm using the old versions is that I needed to reproduce the results of a paper using their code which uses these versions, before porting it to PyTorch, so I can show result equality afterwards.
It is odd that you can't reproduce it. The only difference I can think of is that the function altering the flags is imported from another file but I don't see what difference that could make.
In the end, the workaround did the job, I just don't understand what happened to cause this, so I figured maybe it pointed to a bug you'd want to address. But since you already said you'd stopped development for python2 versions, I will close the issue.
Thanks anyway!

@wobbba Thanks a lot for the additional context.
Very much appreciated the bug report!
On another note, if you still see the issue in a later version of wandb (with Python3) please feel free to re-open this issue 😊.
Good luck with your reproduction and porting 😄


Replaced Agent treatment for Env4InRow

Added treatment for Agent objects
Added support for switching turns
Changed main.py accordingly
Added __hash__ and __eq__ in Agent to allow using agents as keys to dictionaries
Refactored code - added more "pythonic" code style (using dictionaries instead of if-else cases)
Added a 'pass' action treatment in Env4InRow
Removed redundant for loops in main.py

Please review my code - I added some more "pythonic" code styling

Will resolve conflicts in a moment


Small fix in satype_overlap_audio

Prevent the sleep_increment from increasing over time

Sorry for the slight oversight, this is a minor fix that should allow playing really long audio without issues


Great job!

@rebel216 You have fulfilled  the requirements of the activity!

[Optional]
-It would be nice to work a little bit in the responsiveness of the project in case somebody try it from a mobil device or a small screen.

Yes I will do that . Thanks You 👍


version 0.12.0 not in npm

Hi,
Are you planning to publish 0.12.0 to npm? The 0.11.2 version gives me issues when it run
bower install

+1
Same here
Cant use selectize theme on multiple dropdown because the templates are missing in version 0.11.2
Please add it to npm


Redesign footer - it should include link to report bugs/issues

After the team has decided on a design for the footer, code it up. Design will be available in the team's Figma projects.

The Instagram-link is broken and should also be fixed in this issue


Lag spikes

Describe your bug here.
so when i play song the memory is 600 and is going to 700 and going to 600 and it makes lag spikes
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
i edited titlestate discord achievments creditsstate and mainmenustate

it might the song be overcharted like thearchy from strident crisis

Not really, I have the same issue with dadbattle. So it's not overcharting the problem. There's a issue here that explains some of their finds and I also think the problem already got adressed by one of the devs, and it has something to do with how the score calculation is handled in the newer versions, leading to absurd memory spikes. I think it will be fixed next update for sure.

apparently putting this in a script fixes the lag for some reason (for me, at least)
function onUpdate()
    setProperty('scoreTxt.alpha', 0);
end

HaxeFlixel unloads the sprite when it's alpha is set to 0.
This means, that when changing the alpha back to any number that isn't zero, will produce a little lag spike when loading back the sprite.

apparently putting this in a script fixes the lag for some reason (for me, at least)
function onUpdate()
    setProperty('scoreTxt.alpha', 0);
end

in what script i need to put this ?

#9322

That has literally nothing to do with this, did you even read the issue
That aside, scoreTxt updates were changed recently so I recommend checking the latest commits


Windows 10 builds don't install all Windows Updates

It seems that when running Windows 10 builds, only some updates are installed.
In a deployed box, after enabling UAC again, it seems that the "Windows Update" applet downloads more updates (and doesn't even start if UAC is disabled).
Could the installation of those updates somehow be fixed?

This doesn't seem to happen _exactly_ for me, are you still interested in someone looking into this, or has this gotten completely stale?

This issue has had no discussion or input for 5 months. I've tagged it as stale and as a result this issue will be closed in 1 month.
If you disagree and feel this decision is a mistake, please let me know and I'll remove the label.

Closing this issue due to being stale.


IndexError: too many indices for array

Thank you for your code.I have a problem.when I train my dataset,I meet this error:
UnknownError (see above for traceback): IndexError: too many indices for array
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/script_ops.py", line 206, in call
ret = func(*args)
File "../libs/detection_oprations/fcos_target.py", line 101, in get_fcos_target_batch
gt_target = fcos_target(gtboxes_batch[i, :, :], img_batch[i, :, :, :], fm_size_list)
File "../libs/detection_oprations/fcos_target.py", line 36, in fcos_target
center[:, :, 0] = 0
IndexError: too many indices for array
 [[node build_loss/fcos_target/PyFunc (defined at ../libs/networks/build_whole_network.py:210)  = PyFunc[Tin=[DT_FLOAT, DT_FLOAT, DT_INT32], Tout=[DT_FLOAT], token="pyfunc_10", _device="/job:localhost/replica:0/task:0/device:CPU:0"](Cast, get_batch/batch:1, build_loss/fcos_target/PyFunc/input_2)]]

The latest code has been updated, and the performance has been greatly improved.


Link to privacy notice in splash screen is untranslatable

The privacy notice added to the splash screen in #7040 is mostly translatable, but the link to the privacy policy has a hard-coded label “here” that can’t be translated. As a result:

By using this software, you agree to do so in accordance with the iD privacy policy, which can be found here.

would become this in Vietnamese:

Nếu bạn sử dụng phần mềm này, bạn đồng ý với chính sách về quyền riêng tư của iD có sẵn here.

The link text should be made translatable as well, but while we’re at it, I think it would read better if the words “iD privacy policy” were linked instead.
https://github.com/openstreetmap/iD/blob/ada4fb5814a51c3e49e451149a54e1469b6c971c/modules/ui/splash.js#L55-L58

sorry about that - just fixed it.


Dockerfile

This is interesting. I don't use bash in web services anymore berfore.
Could you provide the Dockerfile to help people have a quick your work.

I didn't expect anyone to actually run this, but sure. I've made a Dockerfile but am having some errors. I'll fix those before I push.

I'd say a year is a good response time?
It now runs in Docker with Apache.


Development: Fix creation of Docker images for pull requests opened from forks

Login to GHCR by using token & correct login name

Checklist
General

[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

PRs from outside collaborators cannot be build.
Description

As a first try, I repaired the username for GHCR in the actions.

See https://github.com/ls1intum/Artemis/runs/6879651880?check_suite_focus=true .. now it can build the docker image for outside collaborators.

I updated the title to be a bit more descriptive.

Thanks a lot 👍


Using an Owned Entity Type twice or more causes EF Core to not Find that Type in DbContext.Model

When using an Owned Entity in different EntityTypes EF Core doesn´t find the Owned Entitytype in the DbContext.Model.
Here is a sample project to reproduce the Issue.
Steps to reproduce
public class Name
{
    public string First { get; set; }
    public string Last { get; set; }
}
public class Author
{
    public int Id { get; set; }
    public Name Name { get; set; }
    public string Description { get; set; }
}
public class Customer
{
    public int Id { get; set; }
    public Name Name { get; set; }
    public int CustomerNumber { get; set; }
}

public class DbContextWithOneOwnedEntity : DbContext
{
    public DbSet<Author> Authors { get; set; }
    ...
}
public class DbContextWithTwoOrMoreOwnedEntities : DbContext
{
    public DbSet<Author> Authors { get; set; }
    public DbSet<Customer> Customers { get; set; }
    ...
}

var entityType = new DbContextWithOneOwnedEntity().Model.FindEntityType(typeof(Name)); // works
var entityType = new DbContextWithTwoOrMoreOwnedEntities().Model.FindEntityType(typeof(Name)); // entityType is null

Further technical details
EF Core version: 2.1.3
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10 18.03
IDE: Visual Studio 2017 15.8.4

@JakobFerdinand This is because once a CLR type is mapped to multiple different types in the model, then the model type can no longer be identified just by the CLR type. Therefore, each model type becomes a "weak entity type" which is defined by both it's CLR type and the defining navigation property from it's owner. These can be found using a different overload of FindEntityType:
var customerType = context.Model.FindEntityType(typeof(Customer));
var customerNameType = context.Model.FindEntityType(typeof(Name), nameof(Customer.Name), customerType);

var authorType = context.Model.FindEntityType(typeof(Author));
var authorNameType = context.Model.FindEntityType(typeof(Name), nameof(Author.Name), authorType);

Ok. Thank you for the quick answer! 👍

@JakobFerdinand If the CLR type is mapped to a single entity type in the model, then it can be found just by CLR type, as normal. It's only when the same CLR type is mapped to multiple entity types that they need to be treated differently.


Update to latest version of Functions NuGet, copy host.json to ouptut

@lindydonna,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


More blocks for the string methods

Can we have blocks for these:

.toUpperCase()
.toLowerCase()
.replace()
.replaceAll()
.endsWith()
.startswith()
.trim()

This is a candidate for extension.


Fix: ffuf now minifies progress text if terminal width less than value.

ffuf/config.go added new variable to track if progress should be minified.
ffuf/const.go added const to store value for minimum columns ffuf can handled before minifying.
ffuf/util.go added functions to detect terminal size and to return true if size less than const MINIMUMCOLS
output/stdout.go Progess function now changes what string should be printed based on Config.ProgessMinified
main.go states to check if size of terminal is small and then assign alues to the config for the jobs.

This fix is in regards to #166
This is a work in progress as I need some feedback.
At the moment a const value stores the minimum columns before the output should be changed, currently set to 35. Should this be a smaller valuer? And should the minified progress output be even smaller?

Thanks for the (WIP) PR! This is a really nice improvement!
Few comments:

If by any means possible, I think it'd be beneficial to check if we need to minimize progress bar dynamically (until it has to be minimized). This should be done in the function that updates the progress bar. The reasoning behind this is that there are many variables affecting the current size - wordlist size (in # of digits), current position in the wordlist, number of jobs (in recursion), number of errors and such.
The terminal width check should be cross platform (I don't think Windows has stty), or the feature should be disabled for unsupported OSes (Windows)
I think the MVP (minimum viable progressbar, pun intended) would be job progress as percentage, and number of queued jobs. This is up for discussion however.

I can make these changes. I imagine it should be if the string to be printed is at the length of the terminal only then print the minified version.
It would be nice to constantly call stty so if say a user is running ffuf in tmux and rescaled the pane ffuf would update to compensate. But I considered about performance hit on that. I will implement when a user first runs ffuf it calculates the width and if the progress string will break that width it then minifies output.
Regarding windows I'll ensure this feature is switched off for compatibility.
Thanks for your kind feedback for this MVP for MVP :^)

Here is an updated that covers your feedback.
progress is now dynamic switch back and forth between the minified version only if the verbose output does not fit the width of the terminal.
This feature is only enabled for non-windows machines. (tested on MacOS) If the host is a windows machine the width of the terminal is switched to 80 (the defacto).
The MVP Minimum Viable Progressbar now prints in the format of [100%]-[1/1] job progress as percentage and current job against total jobs. If this shorter version is still too long for a users terminal ffuf will then switch the Config.Quite flag to true which then turns off the printing of progress.
Line 175 of stdout.go
progressString = fmt.Sprintf("%s[%.f%%%%]-[%d/%d]", TERMINAL_CLEAR_LINE, ffuf.Percent(status.ReqCount, status.ReqTotal), status.QueuePos, status.QueueTotal)

I had to double escape the % I'm not sure if this is intended or a bug on my part. It would be good if you could test this.
Let me know if any further changes need to happen.

Let me know if there's any changes to be made @joohoi 👍🏻

I'm expecting to get this reviewed later today!

Oh, actually, meanwhile you could add yourself to CONTRIBUTORS.md and make a small addition to CHANGELOG.md

Hi @Sam-Lane , sorry that it took so long for me to do the initial review and hence losing the momentum here. I think this is a brilliant addition, and would like to know if you'd like to continue working on it or if you wish to hand it over for me or someone else to continue the work on?

Hei @joohoi
Sorry I dropped ball on this. I just moved from finn to UK and started a new job. I'll be happy to finish this up soon. Once I'm settled 👌🏻
Do you have a release date in mind for this fix?

This is an interesting addition. Any timeline when this will be merged? \o/

Hi @joohoi,
Please find an update I believe fits your spec better.

Thanks for updating the PR. It looks good to me and works really well.
There seems to be a few merge conflicts right now, but the PR is ready to merge when those have been resolved.


Request: Convenience methods for mean & sum

I would like to propose adding convenience methods for computing the mean and sums of numeric values in an Iterable:

mean()
meanBy()
sum()
sumBy()

While a similar proposal was rejected in #636 on the basis that same result could be accomplished via .reduce(), we already have similar convenience methods for .min(), .max(), and .count(), and the same argument could be made about those.
If there are no objections, I would be happy to propose an implementation in a PR.

Unfortunately I will still suggest that we do not do this.
Every method added has cost: more bytes for a compiled Immutable.js bundle means longer to download. More code means longer startup time in a browser or vm. And cognitive load is important to consider as well. Already one of Immutable.js's common complaints is that the API is relatively large and can take some effort to learn. Adding more methods makes this problem worse.
We only want to add methods when they add a unique capability that aligns to the goal of the library (programming with immutable data) and are non-trivial to implement (methods which take advantage of the inner workings of the data structures). Unfortunately mean and sum really do not meet these criteria. Honestly I believe it was a mistake on my part to have allowed min and max to be added as well, and could consider removing them in a future major release.
Immutable.js collections all implement the ES2015 Iterable protocol which was an intentional decision to make it easier to build general purpose versions of the types of methods you're suggesting. Then they could benefit from 1) not being bundled directly with Immutable.js and 2) work equally well with Immutable.js and native collections.


Create - Props : target ? target = "_blank" ? Please....

return _react.default.createElement("a", _extends({}, rest, {
href: url,
target : "_blank",
className: 'social-icon' + (className ? ' ' + className : ''),
style: _objectSpread({}, _styles.socialIcon, style),
"aria-label": label || networkKey
})

@leandrovitto more information please I do not understand your issue?

@couetilc if I understand correctly, @leandrovitto is referring to making target = "_blank" a default (please correct me if I'm wrong). Similar to #43.
Although passing the target as a prop does the trick: <SocialIcon url="" target="_blank" />

Thank you @ignasbol for jumping in. @leandrovitto I will not change the default for target, to keep the component as close to the default <a> behavior as possible. I recommend creating your own wrapper component in any projects and setting the default target prop there, an example:
// file: MySocialIcon.js
import { SocialIcon } from 'react-social-icons';
export default function MySocialIcon(props) {
  return <SocialIcon target="_blank" {...props} />;
}


fix: Support juju 3.x

Open juju 3.0~3.5 support
Change functional test from 3.1 to 3.3

Now the functional test is been blocked by https://github.com/canonical/prometheus-juju-exporter 3.3 release.
The functionality is waiting for 3.2/3.3/3.4 snap releasing.

The 3.2 support is blocked by https://github.com/canonical/prometheus-juju-exporter/pull/66


feat: replace template paths with contents

We replace the templateUrl fields with template fields and thus
switch from template paths to template contents in preparation for the
Webpack PR.
Changelog-Entry: Replace template paths with template contents.
Change-Type: patch

Picking up the changes from https://github.com/resin-io/etcher/pull/1943/files#diff-be8e7cbae4a85d432ac97a2164bcef95 might allow the CI tests to pass ;-)

@lurch thanks! Here it is with the sanity script changes.

I've added tests for other pages, unfortunately I can't find a nice way to test the modal(s), but I did add some tests related to the template in any case. Let me know what you think.

Tests pass here now, let me know what you think.


Backup Codes

How do they work? Is it use once and done? I installed this and then came back many months later not remembering my password but I did find a strange message I sent myself and used that code and logged in that night. But now I can't use that code again.

Of course I find it right after asking. Closing this though I would like to know if it prompts to change password after using a backup code. Because now I'm locked out again :(
"Backup Codes
Backup codes work like one-time passwords. They can always be used instead of the normal password (e.g. if you forgot it), but only once.
Attention: When you change your password, all backup codes will be deleted and you will have to create new ones."

You generated a total of 6 Backup-codes once they were generated. Each one is just single-use.
But at every place where you can use your password/backup-codes there should popup a message, when only 3 or less backup-codes are left.

Thank you. Unfortunately I only saved 1 of them I guess and texted it to myself. Anyway there can be a popup every time a backup code is used? I did not remember they were single use and since it was months later that I came back to the project I forgot that they were otherwise I would have changed my password right then.

Well at least the information was there, when you created the backup codes :/
But you're right. I'll try to edit it, so that it always shows the remaining backup codes.

I was able to restore an old copy of my users.json and get back in. Not sure of the security implications in the event that someone A. has your temp codes but they've been used and B. Has an old users.json they can use to get them back :)

Concerning the security implications: That's just the same as with any other software. Only you should know your password=backup-codes and on the other hand databases/json-data can always be backuped by the admin! So all the security is lying your hands by making sure no one else knows the password or backup-codes.
Concerning the users.json with only one backed-up backup-code: It could/should work, if you login with your backed up users.json and use your backup-code (just as you already did). At this moment this backup-code gets removed. Then as next step you just replace the "new" users.json (now without your used backup-code) with the same users.json you just used seconds before from your backup. As long as you use the same SECRET_KEY you will stay logged in and then you can use the same secret key again to now change your password.

I would not let me use that same secret key. I was getting incorrect
password. But I will try again starting from my backed up users.json.
Understood about the security which was why I was trying to say all these
events are unlikely to happen.
On Thu, Apr 20, 2023 at 2:05 AM Marco Kümmel @.***>
wrote:

Concerning the security implications: That's just the same as with any
other software. Only you should know your password=backup-codes and on the
other hand databases/json-data can always be backuped by the admin! So all
the security is lying your hands by making sure no one else knows the
password or backup-codes.
Concerning the users.json with only one backed-up backup-code: It
could/should work, if you login with your backed up users.json and use your
backup-code (just as you already did). At this moment this backup-code gets
removed. Then as next step you just replace the "new" users.json (now
without your used backup-code) with the same users.json you just used
seconds before from your backup. As long as you use the same SECRET_KEY
you will stay logged in and then you can use the same secret key again to
now change your password.
—
Reply to this email directly, view it on GitHub
https://github.com/PhiTux/DailyTxT/issues/29#issuecomment-1515762144,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANHZDJK6E3WPRPAF6NCFQ3XCDGZVANCNFSM6AAAAAAXCCHX6A
.
You are receiving this because you authored the thread.Message ID:
@.***>

No, I think you misunderstood me.
You have to copy the users.json twice! First (as you did) to be able to login with your one remaining backup-code. Then don't log out, just copy this same OLD users.json into its place again. And then use the same backup-code directly again to change the password.

Excellent. That worked. Thank you very much.

You're welcome :)


feat: Allow passing in the dialect and run_as option when creating alerts.

This PR solved two issues.

When the source query is not in presto dialect ie: mysql or postgres. We can pass the dialect as --source-dialect.
When we create alerts, normally it is running as the user who created it. This is not OK in a complex setup where we need to run the alerts under a specific servie principal or user which proper permissions for the data assets. This PR gives ability to do this by passing in --run-as argument with either user name like<EMAIL_ADDRESS>or service principal application id.

@tusharm Need re-approval :)


[BUG] - SwiftLint is destroying code

Apple add space to their code

But, in the strict mode of Swiftlint, we need to remove the space! Otherwise, it will warn

I guess you are talking about this error:
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

occurring in cases like this:

This means that you have a space or tab character on an other than that empty line. Just hit backspace until the cursor is completely on the start of the line, build and the error is gone.

I guess you are talking about this error:

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

occurring in cases like this:

This means that you have a space or tab character on an other than that empty line. Just hit backspace until the cursor is completely on the start of the line, build and the error is gone.

I’ll try it. Because Xcode automatically adds space. 🫠


[HOLD for payment 2023-10-02] [$500] Request money - Currency search does not work with head or trail space

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on FAB icon and select request money
Click on currency
Type any currency with head or trail space

Expected Result:
Should show currency suggestion if there is head or trail space
Actual Result:
Currency suggestion does not work with head or trail space
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/75d46416-1a0a-481c-b983-255ccbbe0dbf
https://github.com/Expensify/App/assets/115492554/849f524b-8aa3-44c6-9522-a3c32a514cc2
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692593642283219
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b5fade09bc8f8027
Upwork Job ID:<PHONE_NUMBER>556031488
Last Price Increase: 2023-09-14
Automatic offers:

gadhiyamanan | Contributor | 26720044
gadhiyamanan | Reporter | 26720045

Proposal
Please re-state the problem that we are trying to solve in this issue.
currency search does not work with head or trail space
What is the root cause of that problem?
we are not trimming currency value while searching
What changes do you think we should make in order to solve the problem?
trim the search value here
https://github.com/Expensify/App/blob/03cf0b14f82a41db004dfee27799e3cea1608ee5/src/pages/iou/IOUCurrencySelection.js#L91
What alternative solutions did you explore? (Optional)

I'm not sure if this a bug or by design. My thoughts are if there is not supposed to be a space before the currency code, if you enter a space and begin typing, the correct result would be to not show the subsequent list underneath. However, interested to see others' thoughts on this. Going to get additional eyes.

@chiragsalian Interested to hear your thoughts on this — TIA!

Chirag was OoO for Labor Day, so not overdue 👍

Bump @chiragsalian ^^^ thanks!

Not overdue as @chiragsalian will be reviewing 👍

missed this, looking now

Yeah this looks like a minor bug to me. I think it would be a slight user experience to trim unnecessary spaces while searching. Marking this as external.

@gadhiyamanan's proposal here looks good.
🎀 👀 🎀 C+ reviewed.

Seems super straightforward. Assigning @gadhiyamanan

@mananjadhav PR is ready for review

@mananjadhav bump for PR review

I tried tracing the offending PR, I can see it existed since a long time (I think since the component creation). It went through a couple of refactors, I can't see if the trim got removed anywhere.
I also don't think we need a regression test here, considering how seldom this piece of code changed. @chiragsalian wdyt?
@CortneyOfstad Can you please post the payout summary, this is also eligible for the timeline bonus. I'll be raising my request on New Dot.

yeah imo regression testing for this is not needed.

Sorry was OoO yesterday, but payment breakdown is below!

External issue reporter — @gadhiyamanan paid $50 and contract ended in Upwork
Contributor that fixed the issue — @gadhiyamanan paid $500 + 50% bonus = $750 and contract ended in Upwork
Contributor+ that helped on the issue and/or PR — @mananjadhav is paid in NewDot and is eligible for $750

Sorry @gadhiyamanan — just sent out a proposal for the additional $200. Please let me know as soon as you accept. Thank you!

@CortneyOfstad offer accepted, thanks

$750 approved for payment based on BZ summary.

Payments have been completed, so closing!


Fixes for 3.2.0 UI Integration Tests

Fixed the intermittent failures of the existing test suite

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as the PR is no longer relevant to this repo.


Refactor Part II: Split DuneClient Class

We split the DuneClient class up with an inheritance structure described vaguely as follows:
    Inheritance Hierarchy sketched as follows:

    DuneClient
        |
        |--- QueryAPI(BaseRouter)
        |       - Contains CRUD Operations on Queries
        |
        |--- ExtendedAPI
                | - Contains compositions of execution methods like `run_query` (formerly refresh)
                |
                |--- ExecutionAPI(BaseRouter)
                        - Contains query execution methods.

Note that this is based on #64 (which should be merged first).
Closes #69
cc @TheEdgeOfRage & @diegoximenes for additional review.

Note that we can circle back and clean this up even more later. This is mostly just an initial proposal for the final structure and servers as a starting point from which we can move things around as we see fit.

Thanks @RichardKeo for your careful review. I will create relevant issues and make suggested changes here accordingly first thing tomorrow!

In light of the backlog depending on this and all the comments addressed, I will merge this now. We can always double back and make additional changes upon request.


Authentication Required when attempting to pull from Docker Private Repository

Please provide us with the following information:

This issue is a: (mark with an x)

[ x ] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
Attempt to pull images from Docker Private Repository results in "UNAUTHORIZED" with "authentication required" error
Steps to reproduct
Enter the following command
az containerapp create --name myapp --resource-group myresource --image myprivaterepo/myapp:latest --environment myenv --registry-server docker.io --registry-username [username] --registry-password [password]
Expected behavior [What you expected to happen.]
The container to be deployed
Actual behavior [What actually happened.]
The following error occured
The following field(s) are either invalid or missing. Invalid value: "myprivaterepo/myapp:latest": GET https://index.docker.io/v2/privaterepo/myapp/manifests/latest: UNAUTHORIZED: authentication required; [map[Action:pull Class: Name:privaterepo/myapp Type:repository]]: template.containers.myapp.image.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Ex. Did this issue occur in the CLI or the Portal? Both CLI and Portal have the same error.

Where you able to fix it?

Have the same issue but using the Azure Container Registry as part of the tutorial (https://docs.microsoft.com/en-us/azure/container-apps/communicate-between-microservices?tabs=bash&pivots=acr-remote)
As well as this, the tutorial does not set the FRONTEND_NAME variable. Minor I know but will cause a bit of confusion for first timers (IMO)

For ACR you should be able to use managed identity for authentication, so it should just work without needing to pass a password.
For external registries, like dockerhub, you'll need to set a registry auth on the container app. It should be
az containerapp registry set -g {resourceGroup} -n {appName} --server {registryDomain} --username {userName} --password {password}

for dockerhub in particular the registry domain should be --server index.docker.io. You can still refer to dockerhub images with {repo}/{imageName} or docker.io/{repo}/{imageName} or index.docker.io/{repo}/{imageName}


#1207 added additional fields to FixedwingMetrics and  process_fixedwing_metrics

#1207 added additional fields to FixedwingMetrics and  process_fixedwing_metrics

Ah. I'll see about updating that too

I've updated the Proto definition: https://github.com/mavlink/MAVSDK-Proto/pull/176

I've re-done the prototype PR. And I updated the code for the SDK, to include that name change and the type change.

There was no follow-up here in a while, so I closed https://github.com/mavlink/MAVSDK-Proto/pull/182 and will close this PR as well. @haydockjp if you want to pick this back up, please re-open the PR and I'm happy to discuss it again.


Last try for today - Create BDArmorySorting.netkan

Instead of creating a new PR for each change, you can make commits to your existing branches. Based on your branch names I'm ~90% sure you're using GitHub's web site to do all your work so I'll give quick instructions on how to commit to existing PRs using the site.
Find the branch the PR is involved with (highlighted): http://puu.sh/jRuDE/72f2c22d3a.png
Go to your fork of the repository and select the appropriate branch: http://puu.sh/jRuBq/ccf3edf8cc.png
Edit the appropriate file: http://puu.sh/jRuH3/82905c530b.png
Commit your changes to the branch that the PR is pointing to: http://puu.sh/jRuJT/1256edfb7a.png

At any rate, this passes local and Jenkins. Merging with my thanks.

I suspected about this possibility, but could not find her. Thanks


cant get Trends ,

when trying to get trends as shown in documents , i got error
"An unhandled exception of type 'System.NullReferenceException' occurred in Tweetinvi.dll
Additional information: Object reference not set to an instance of an object."
code var trendingTopics = Trends.GetTrendsAt(42);

When I write 42 it means any correct value.
So if you try using var trendingTopics = Trends.GetTrendsAt(1); (1 being a valid geo id) you will get results.


Error render website created by vue in facebook app browser

Version
2.5.13
Reproduction link
https://vue.pizza/app/#/login?redirect=%2F
Steps to reproduce

Share the link https://vue.pizza/app/#/login?redirect=%2F to facebook
Use facebook app -> click to this link has shared. Please make sure you are use facebook app browser.

What is expected?
Page display
What is actually happening?
Page blank. Can not display correctly
Image: https://ibb.co/dSkCyK

I guess facebook browser can not render vuejs code.

Please provide a reproduction link with source code.

This is probably caused by facebook app browser's WebView not supporting some JavaScript features you're using. Make sure you have correctly set up babel to transpile JavaScript to support older browser/webviews

The issue is still not fixed. I am not able to view my Vue app on the Facebook in-app browser. It works flawlessly on Safari, Chrome,


Show status icon for tests rather than table with 1s and 0s

Show a status icon for test suites in the UI rather than a table with  Waiting | Running | Success | Fail | Err
You could use emojis to make it easy:
waiting :hourglass:
running: :runner:
success: ✅
failure: ❌
error: 🛑

Tests can have multiple test cases; perhaps an icon for each test case; so if there's four variants, show something like :hourglass::hourglass::runner::success: for 1 success, 1 running, 2 waiting


Update versions as to not have CI fail (while fixing "non-failing" CI)

I recently found that CI wasn't "failing as it should". I'm opening this PR as a draft to be able to identify the failing elements, then fix potentially them, then convert to "Ready for review".
Also closes #165.

This was merged sooner than I expected 😄 I'd left a comment for @lpil in the linked issue, but maybe it's not warranted any more.


updates schema to allow URI references

As discussed in #898 JSON API specification does not make any assertions
about URI structure. Also specification contains examples using "relative
URIs".
RFC 3986, which is referenced by JSON Schema specification, distinguish
between an uri and an uri reference like "relative" or "partial URIs":

1.2.3. Hierarchical Identifiers
[...]
NOTE: Previous specifications used the terms "partial URI" and "relative
URI" to denote a relative reference to a URI. As some readers misunderstood
those terms to mean that relative URIs are a subset of URIs rather than
a method of referencing URIs, this specification simply refers to them as
relative references.

Therefore relative URIs would fail validation if uri format (8.3.6 in JSON
Schema draft) is used. uri-reference format (8.3.7) allow both.

FWIW, linking to comment that the JSON SCHEMA is not authoritative https://github.com/json-api/json-api/pull/440#issuecomment-151013219

Thank you @jelhan!
@bf4 Yep, the spec itself (not the schema) should be considered authoritative.

@dgeb perhaps we should add a comment somewhere to that effect?


Deprecate SBI mapserv application

Summary
UGRC is moving applications from the mapserv server to the cloud. The SBI Locate app has been successfully migrated to sbilocate.ugrc.utah.gov and the mapserv application can now be deprecated. The DHS contact has been informed of the change to the new application DNS.

Application Name: SBI Locate
Application Url: mapserv.utah.gov/sbi

A short summary of the situation.
(See summary section above)
Action items

Assign a person who should complete the task by replacing name with their github @name.
Check [x] the box when the task is completed and add the date of completion.
~Strike~ out all items that do not apply.

[ ] ~Update relevant gis.utah.gov application pages (name, completed: 2021/00/00)~
[ ] Remove forklift pallet (@steveoh, completed: 2021/00/00)
[ ] Remove application-specific Databases (@steveoh, completed: 2021/00/00)
[x] AGRC Projects team drive - active maintenance agreement will remain in the folder (@nathankota , completed: 2021/06/21)

Is there a website?

[ ] ~Remove DNS entry (@nathankota, completed: 2021/00/00)~
[ ] ~Archive source code repository (@steveoh , completed: 2021/00/00)~

Choose one.

[ ] Remove from the web server (@steveoh, completed: 2021/00/00)
[ ] ~Replace app with a static page with information (name, completed: 2021/00/00)~
[ ] ~Redirect somewhere else (name, completed: 2021/00/00)~

Is there a map service?

[ ] ~Stop (name, completed: 2021/00/00)~
[ ] ~Delete (@steveoh, completed: 2021/00/00)~

Is there a forklift pallet?

[ ] ~Remove repo (@steveoh, completed: 2021/00/00)~
[ ] ~Remove stale data from forklift hashing and receiving (@steveoh, completed: 2021/00/00)~
[ ] ~Remove row from data/hashed/changedetection.gdb/TableHashes (@steveoh, completed: 2021/00/00)~

Are there service dependencies?

[ ] ~Validate that the web api does not query it (name, completed: 2021/00/00)~
[ ] ~Validate that AGRC or applications widgets do not reference it (name, completed: 2021/00/00)~

Notification

[ ] Twitter (@steveoh)

Group Task Assignments

Check [x] the box when you have assigned all the tasks relevant to your group.

[ ] ~Data Team (@gregbunce)~
[x] Dev Team (@steveoh)
[ ] ~Cadastre Team (@rkelson)~

I don't see a reason to delete a map service, or archive any source code since this is a migration. I also don't know of any DNS that needs to be removed. We were using a slash address from mapserv before. I will update the issue unless I am missing something.

/remind me in one week to destroy the website

/remind me to destroy the website in one week

/remind me to destroy the website in one week

/remind me to destroy the website on 6/28

There is no forklift or app specific database. I am also going to skip twitter.

Ok, this has been completed


Make debouncing "save preferences" optional

I implemented this awhile back, now I'd like the option to turn it off. Pretty simple, I'll have a PR soon.

How do you suggest to turn it off? config.debounce = 0?

Yep, exactly. I'll add to the readme

Fixed in #155


Plural configuration doesn't work

v1.7.0 ought to support plural lookups of singular terms (#18) but when I tried it both plurals: inflect and plurals: en yield this error:

AttributeError: 'GlossaryConfig' object has no attribute 'plurals'

Another configuration bug. Unfortunatly the configuration check is not covered by the tests causing this issues. This is now fixed with v1.7.1.
Thanks for your feedback!

I tested v1.7.1 and plural usages work otherwise, but they are not listed in the glossary. I submitted #24 about that.


[Dev] Support loading Emission from AppHub

Adds a new section when in the deploy schema (e.g. you will not see this in dev)

It has the same build chooser that Eigen has:

And can pull out the related PR from the build:

This makes the apphub upload also include the PR metadata as a description, so there should be more builds that look like:

I disabled the tests part of our Pods setup. Until we're writing native tests it adds more complications to the build process for everyone - and I was having some tricky issues with the React subspecs and AppHub.

Current build now shows relative time, I don't really know what day it is, so I shouldn't expect others to.

Going to look at this after our current release woes are over.

Yah, that's fine, less changing it 👍

poke

Updated and addressed all feedback

Ace 🙏🏽


WIP - Add acceptance tests to mco

This commit adds the infrastructure to support running acceptance tests
against mcollective.

CLA signed by all contributors.