Improve tests

Self remove feature
Target: <paper-chip>.

[ ] test that its disconnect callback is called when the element self removes itself
[x] test that the elements is not in the parentElement's DOM anymore when it removes itself

@leodido I wrote the following test to check that disconnectedCallback is called
test('disconnect callback of paper-chip has been called', (done) => {
    let chip = fixture('disc')
    const disconnectedCallback = sinon.spy(chip, 'disconnectedCallback');
    chip.$.removeBtn.click()
    expect(disconnectedCallback).to.have.been.called;
    done()
})

It fails with the message:
Error: expected disconnectedCallback to have been called at least once, but it was never called
  Context.test at paper-chip.html:105

What's wrong with my test?


Title flashing

Description
Added flashing title to notify user about unread conversations
Issue
[#148 ]
Screenshots

Checklist

[x] Everything passes when running mix test
[x] Ran mix format
[x] No frontend compilation warnings

@Aditya135 can you post a gif of what this update looks like?
also can you verify that when the number of unread messages changes, the html title also changes correctly?

@reichert621 I have updated the PR comment with the git, can you review it. You might have to zoom it a little bit 😅


Feature Request: Acme Titlebar theme

Would it be possible to change the look of the title bar to look like acme?

You can change the color of the decoration and titlebar around windows with a triplet of colors: a light one, a middle one and a dark one.  For example, for the active window, the triplet is activeTopShadowColor, activeBackground, activeBottomShadowColor, which defaults to a light, mid, and dark blue.
The same works for inactive and urgent containers.
The titlebar, however is colored the same as the decoration.

Would it be possible to change also the border width?

Would it be possible to change also the border width?

Set the shod.borderWidth X resource to the size you want in pixels.
More information on the manual.


direct airflow CLI throws sqlite3 error

I see in the docs we can do docker-compose -f docker-compose-CeleryExecutor.yml run --rm webserver airflow list_dags.  The drawback I see is this reinstalls requirements.txt.
When trying to run what seems like any airflow command with docker exec -i docker-airflow_webserver_1 like docker exec -i docker-airflow_webserver_1 list_dags, in the worker, scheduler, or webui with CeleryExecutor (or LocalExecutor in the webui container) it throws the error:
airflow@7a6881d6cd69:~$ airflow list_dags
[2020-02-23 17:59:56,130] {{cli_action_loggers.py:107}} WARNING - Failed to log action with (sqlite3.OperationalError) no such table: log
[SQL: INSERT INTO log (dttm, dag_id, task_id, event, execution_date, owner, extra) VALUES (?, ?, ?, ?, ?, ?, ?)]
[parameters: ('2020-02-23 17:59:56.122212', None, None, 'cli_list_dags', None, 'airflow', '{"host_name": "7a6881d6cd69", "full_command": "[\'/usr/local/bin/airflow\', \'list_dags\']"}')]
(Background on this error at: http://sqlalche.me/e/e3q8)
[2020-02-23 17:59:56,131] {{__init__.py:51}} INFO - Using executor SequentialExecutor
[2020-02-23 17:59:56,131] {{dagbag.py:403}} INFO - Filling up the DagBag from /usr/local/airflow/dags
[2020-02-23 17:59:56,200] {{dagbag.py:246}} ERROR - Failed to import: /usr/local/lib/python3.7/site-packages/airflow/example_dags/example_subdag_operator.py
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1246, in _execute_context
    cursor, statement, parameters, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 588, in do_execute
    cursor.execute(statement, parameters)
sqlite3.OperationalError: no such table: slot_pool

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/airflow/models/dagbag.py", line 243, in process_file
    m = imp.load_source(mod_name, filepath)
  File "/usr/local/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.7/site-packages/airflow/example_dags/example_subdag_operator.py", line 50, in <module>
    dag=dag,
  File "/usr/local/lib/python3.7/site-packages/airflow/utils/db.py", line 74, in wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/airflow/utils/decorators.py", line 98, in wrapper
    result = func(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/airflow/operators/subdag_operator.py", line 77, in __init__
    .filter(Pool.pool == self.pool)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 3287, in first
    ret = list(self[0:1])
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 3065, in __getitem__
    return list(res)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 3389, in __iter__
    return self._execute_and_instances(context)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 3414, in _execute_and_instances
    result = conn.execute(querycontext.statement, self._params)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 982, in execute
    return meth(self, multiparams, params)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/sql/elements.py", line 293, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1101, in _execute_clauseelement
    distilled_params,
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1250, in _execute_context
    e, statement, parameters, cursor, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1476, in _handle_dbapi_exception
    util.raise_from_cause(sqlalchemy_exception, exc_info)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 398, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/util/compat.py", line 152, in reraise
    raise value.with_traceback(tb)
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/base.py", line 1246, in _execute_context
    cursor, statement, parameters, context
  File "/usr/local/lib/python3.7/site-packages/sqlalchemy/engine/default.py", line 588, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: slot_pool
[SQL: SELECT slot_pool.id AS slot_pool_id, slot_pool.pool AS slot_pool_pool, slot_pool.slots AS slot_pool_slots, slot_pool.description AS slot_pool_description
FROM slot_pool
WHERE slot_pool.slots = ? AND slot_pool.pool = ?
 LIMIT ? OFFSET ?]
[parameters: (1, 'default_pool', 1, 0)]
(Background on this error at: http://sqlalche.me/e/e3q8)

-------------------------------------------------------------------
DAGS
-------------------------------------------------------------------
example_bash_operator
example_branch_dop_operator_v3
example_branch_operator
example_complex
example_external_task_marker_child
example_external_task_marker_parent
example_http_operator
example_passing_params_via_test_command
example_pig_operator
example_python_operator
example_short_circuit_operator
example_skip_dag
example_trigger_controller_dag
example_trigger_target_dag
example_xcom
latest_only
latest_only_with_trigger
test
test3
test_dag2
test_utils
tutorial

airflow@7a6881d6cd69:~$ cd dags/
airflow@7a6881d6cd69:~/dags$ ls
__pycache__  test2.py  test3.py  tuto.py

I'm also confused that it's printing out so many dags when I only have a few files in the dags folder.
I had entered the container as interactive bash, but the same thing happens with non-interactive.
It's also a similar error with docker-compose -f docker-compose-CeleryExecutor.yml exec webserver airflow delete_dag -y sparkify_etl.

I found we can do docker-compose -f docker-compose-CeleryExecutor.yml run --rm webserver airflow list_dags, but this runs a pip install with requirements.txt.  I'll close this issue and open another more targeted issue towards that.


Assoc list, fixes issue #7

This fixes issue #7.
 Working on this now...


Navigation timings and resource timings should have a causal relation

Description
In order to understand which specific resources with which specific timings were loaded as part of a page-load, there should be an identifier that can be used to find all the resource timings that are associated with a navigation timing.
Example:

navigation-timing: page-load-a (id: 123, name: /shopping-cart)

resource-timing-z (name: app.js, navigation: 123)
resource-timing-y (name: styles.css, navigation: 123)

navigation-timing: page-load-b (id: 456, name: /shopping-cart)

resource-timing-x (name: app.js, navigation: 456)
resource-timing-w (name: styles.css, navigation: 456)

Then we could look at each set of navigation timings and understand which page loads were involved and calculate if it's in line with expectations.
Proposed solution

calculate an identifier for each navigation timing
calculate an identifier for each resource timing
set navigation-timing event id on resource timings to make them discoverable

Context

They are sent as event which has respective information about the page etc. in it's metas.
So the correlation could be done in the backend instead of putting more load on the web-sdk.
Wdyt?

Implemented with: #434


Update CHANGELOG from 0.14.0 to 0.17.3

@CGNonofr along with updates to the CHANGELOG I did the following:

Updated CHANGELOG with entries for 0.14.0 to 0.17.3
Updated Current Maintainers list in CONTRIBUTING and introduced a "Past Maintainers" section
Make build work cross-platform with shx
Updated vscode settings
Added .editorconfig and added editorconfig plugin recommendation
Use monaco-languageclient again in examples

Sorry for the auto-selection of reviewers. This is one is not regarding any code changes.


Infino

**NOTE: This is an issue template for new partner pages we are building. Existing partners can use them to submit information needed as we build out enhanced pages. New partners, please continue to use the process outlined here for the time being: https://opensearch.org/new-partner.html
Organization name
Infino
Brief description of your business and what it does (50 words or less)
Infino offers a schemaless, serverless managed OpenSearch service optimized for Observability. Cheaper, faster, and with more observability features, it allows you to store logs, metrics, traces, code, tickets, etc. in a single index and query your data via several popular languages: Natural Language, Query DSL, PromQL, PPL, etc.
Name of your relevant product(s) or service for the OpenSearch audience
Infino OpenSearch
What OpenSearch technologies do you specialize in
Observability
Type of business
ISV
Home/main office location or address
Infino AI Inc.
19266 Coastal Hwy
Unit 4-250
Rehoboth Beach, DE 19971
How can people contact you (email and phone)
<EMAIL_ADDRESS>Regions you serve
North America, South America, Europe, Middle East, Africa, Asia Pacific, Australia
Industry specialization
Business services, consumer services, education, energy and utilities, financial services, healthcare, media and entertainment, public sector, non-profit, retail, software and technology.
Logo
assets/media/partners/infino.png
assets/media/partners/infino/infino_logo.png
Additional image
TBD
Links
TBD

Welcome to the list of partners!


Error trying to load babel plugin react-hot-loader/babel

I installed using --save and you have react-hot-loader specified as a dev-dep. Unless I explicitly install it I get:
ERROR in ./~/glamor/lib/index.js
Module build failed: ReferenceError: Unknown plugin "react-hot-loader/babel" specified in "/Users/tshugart/Sites/skatejs/skatejs.github.io/node_modules/glamor/package.json.env.development" at 0, att
empted to resolve relative to "/Users/tshugart/Sites/skatejs/skatejs.github.io/node_modules/glamor"

I could be wrong but it seems that since I'm in "development" it seems your babel env config gets loaded, but since dev deps aren't installed, it can't find the plugin specified in there.
Not sure the best way to fix this without compromising dev ergonomics on your end. You could specify react-hot-loader as a standard dependency so that it's picked up in dev mode for consumers. Thoughts?

good catch. I'll move the react-hot-loader dependency into my demo folder, that should help. gimme half an hour or so. Sorry for the trouble!

I just installed it as a dep; easy work around :)

looks like fixing this is going to take longer than I expected, unearthed a couple of other issues. cheers on the workaround, I'll fix this properly soon.

I've rewritten dependencies etc, and published a fresh build. If and when you have the time, do try out 2.2.1 (without react-hot-loader in your deps). Cheers!

 Thank you. I'll try this tomorrow and close it for now. If I experience issues, I'll reopen.

Does anyone have a resolution for this issue?
ReferenceError: Unknown plugin "react-hot-loader/babel"
I'm running it with webpack
Module build failed: ReferenceError: Unknown plugin "react-hot-loader/babel" specified in "/Users/example/.babelrc" at 0

Here is my .babelrc
{
  "presets": [
    "es2015",
    "stage-2"
  ],
  "plugins": [
    "react-hot-loader/babel"
  ]
}

I had the same problem after upgrading to version 1.3.1.
After going back to version "react-hot-loader": "^3.0.0-beta.6", the problem is gone with the ReferenceError: Unknown plugin "react-hot-loader/babel".

i had the same proble, the node_modules package don't have this file

have this issue right now
package.json
"react-hot-loader": "^1.3.1",

.babelrc

 plugins: [
     "react-hot-loader/babel",
 ]

Error
ReferenceError: Unknown plugin "react-hot-loader/babel" specified in "c:\\Projects\\Portal\\.babelrc" at 1,
attempted to resolve relative to "c:\\Projects\\Portal"
    at c:\Projects\Portal\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:180:17
    at Array.map (native)
    at Function.normalisePlugins (c:\Projects\Portal\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:158:20)
    at OptionManager.mergeOptions (c:\Projects\Portal\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:234:36)
    at OptionManager.init (c:\Projects\Portal\node_modules\babel-register\node_modules\babel-core\lib\transformation\file\options\option-manager.js:368:12)
    at compile (c:\Projects\Portal\node_modules\babel-register\lib\node.js:103:45)
    at loader (c:\Projects\Portal\node_modules\babel-register\lib\node.js:144:14)
    at Object.require.extensions.(anonymous function) [as .js] (c:\Projects\Portal\node_modules\babel-register\lib\node.js:154:7)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)

Install react-hot-loader with npm install react-hot-loader@next

thanks @gaastonsr ! its work


What time will the code be published?

Hi, Congratulations to your remarkable achievements! I'm looking forward to knowing details in your code. So I just want to know What time will the code be published？
Thank you!

The code based on PyTorch will be released in late December. It takes some time to reimplement it from internal architecture for open source.


Adding Installation Notes to WhatsApp.WhatsApp.Beta

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.
Resolves

#129816

Microsoft Reviewers: Open in CodeFlow

@msftbots


Beta 6:  Sapling drop rate too low?

So I had a try to farm myself some silverwood in my new world.
First three trees I felled dropped 0 saplings.
The fourth dropped one.  Fifth dropped 0.  Sixth dropped three.  Now I had four saplings.
I planted those four.  The next three trees dropped 0 again.  The last one dropped 2.
So far that's ten trees to get 6 saplings.  0.6 saplings per tree.  Now I had 2 saplings.
Planted those two.  Very shortly I had 0 saplings.
At this rate, silverwoods would go extinct.  Isn't this drop rate a bit low?

Fortune seems to have an effect, but I was only able to notice it with a cheated-in Fortune X tool. I wouldn't mind if it was made more effective so you had to probress a bit before being able to farm silverwoods. But just increasing the drop rate in general would be fine.

I got one sapling total from the next two trees I cut.  I think the average seems to be tending more towards 0.5 saplings per tree.  So far I'm at 7 saplings from 14 trees.
I haven't tested the effect of a Fortune axe yet.

I recently cut down a silverwood tree with my fortune II gauntlet and it dropped 3 saplings. Either I got lucky, or fortune plays a big role in getting the saplings.

That is about the expected drop rate. They are supposed to be super rare - it is even listed in their thaumonomicon entry.


Cannot open app on MacOS Catalina

[x ] I am on the latest Hyper.app version
[ x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Catalina
Hyper.app version: latest downloaded from website
Link of a Gist with the contents of your .hyper.js:

Issue
Upon downloading the latest Hyper app from the website, I cannot launch it.  OS complains with

The application "Hyper.app" can't be opened

I've got the same issue. What OS version are you running, specifically?

I found a previous issue that had the same problems as we've encountered. Try installing Hyper via Homebrew;
brew update
brew cask install hyper

This works on my end.

@henrikmmm1 That works.


SL-7099 - Added an Empty Cookie Container for HttpClient

I was able to directly include the changes to FileDownloader and verify that everything continues to work well and does not have any exceptions.


RemoveArrayAction does not update child controls ID

Ciao Wolfz :)
I'm handling an array of entities, and I have a remove button on each entity row, so for example, when I have 3 rows I can remove the middle one, and so on.
What's going on is that when I dispatch a RemoveArray action it's indeed updating the ID of the subsequents items, but not the id of their inner controls.
simple example is below:

3 items on array, with nested fields of Name & Surname
    ITEM0
     Name0
     Surname0
    ITEM1
     Name1
     Surname1
    ITEM2
     Name2
     Surname2

we now remove ITEM1 with a Remove_Array action from the library, ITEM2 gets correctly renamed to ITEM1, but the nested fields remains the same.
    ITEM0
     Name0
     Surname0
    ITEM1
     Name2
     Surname2

we now add a 3rd item, it's get ITEM2, and the nested fields? guess it..
    ITEM0
     Name0
     Surname0
    ITEM1
     Name2
     Surname2
    ITEM2
     Name2
     Surname2

This situation now leads to duplicated data, because when I modify Name on ITEM1 also modifies the one in ITEM2.
Regards,
Luca

Thanks for finding and reporting this bug. I'll work on a fix asap.

I have just released version 2.3.0 which fixes this issue.

Works, thanks man 👍


Mime and cache

This attempts to re-integrate #14 into the latest version of Static.

Wait. This is bad. I just saw (feat) Set content type automatically for based on file extension.
I'm currently using this mime detection to be able to serve static HTML / JS. Could it be kept as a temporary workaround and removed later?

Makes sense :+1: I'll use it locally and watch iron until that gets merged in. I just can't keep up :fearful: :smile:


Added pulltest.txt file

Before creating your PR, please make sure to add the appropriate GitHub label; i.e. run-smoke-tests. For more details see
tests/README.md.
(In case you don't have permissions to add labels, please ask a
Maintainer.)

/meow

/meow

/test

/test this


144184371: As an operator, I would like to not need consul to run the scheduler

@boyang9527, Thanks, I added a test case scheduler end-to-end test case in that class.

LGTM


sweep:write write unit test for all functions

write unit test for all functions.

Checklist

[X] safaribooks_test.py

Add unit tests for each function in the safaribooks.py file to ensure their correctness and functionality.

[X] safaribooks_test.py

Modify existing test cases to cover all possible scenarios and edge cases.

write unit test for all functions in safaribooks.py


Revert "Bearer is now case-sensitive."

Reverts shogo82148/goat#114

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.964%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7367

Relevant Lines:
9572

💛  - Coveralls

https://datatracker.ietf.org/doc/html/rfc9110#section-11.1
RFC 9110 11.1. Authentication Scheme:

HTTP provides a general framework for access control and authentication, via an extensible set of challenge-response authentication schemes, which can be used by a server to challenge a client request and by a client to provide authentication information. It uses a case-insensitive token to identify the authentication scheme:
auth-scheme    = token
Aside from the general framework, this document does not specify any authentication schemes. New and existing authentication schemes are specified independently and ought to be registered within the "Hypertext Transfer Protocol (HTTP) Authentication Scheme Registry". For example, the "basic" and "digest" authentication schemes are defined by [RFC7617] and [RFC7616], respectively.


Code completion not working

Hi! I am trying to use the tool but somehow the code completion is  not working. The chat functionality works just fine so I am quite sure I configured the connectors properly. Unfortunately, I couldn't find any logging. Hence I am not even sure whether the completion request is being sent.
It tried the following models: codegemma, codellama and starcoder. ( always the fim version)
The path is /api/generate
Though it is also not working in a host vs code, I normally work inside a dev container one. Hence, I updated the hostname to host.docker.internal
As I said, the chat functionality works just fine. I am wondering what could be the issue with the coding completion one?

Hello,
Please confirm all settings used for FIM completion providers.  Also, please enable the debugging information in the settings, scroll to the bottom and tick enable logging, then go to Help -> Toggle Developer Tools inside Visual Studio Code to look out for any errors.
Many thanks,

Hi! While debugging I could see that there is a request being sent if I use the chat functionality. However, nothing shows up in the console for the code completion ( even when I request it with  Option + \ ( mac user ) )
I also found a
"Problem creating default templates "/root/.twinny/templates""
Can it be that's the issue? No template-> no FIM?

Hey, that shouldn't be an issue for fim as they are built in.  Please provide all the provider configuration settings as previously requested.

Type: FIM
Fim template: codegemma
Provider: ollama
Protocol: http
Model name: codegemma:2b
Hostname: host.docker.internal
Port: 11434
Path: /api/generate
As I mentioned in the previous message, I don't get request in the console as you do ( based on your photo )

I would recommend trying codellama:7b-code to see if it works.

Just gave a try, still nothing:
Settings:

Console after a successful call to the chat api and several "Option + \ " in a python file:

I have the same problem as you andremald, i.e. chat is working fine but FIM does nothing
I have a strange error logged when I type in my cpp file. is this causing it or is it unrelated?

Same problem here. All settings correct. 13b or 7b, doesn't matter. Only chat seems to work. I see the robot icon loading when i start coding, but no autocomplete prompts ever how

Failing for me too. I can see the message being received by the provider, but no response and no error. I am using Aphrodite's openai api server. I have tried different providers, yet none give a resopnse.

My issue might partly related to there not being an actual supported OpenAi provider. I setup a litellm proxy to forward to my model and I am still not getting any completions.

+1

Hi.
I have the same issue: chat works, FIM doesn't, no matter what I do in the configurations.
I was looking at the developer tools. as suggested, and when I was writing in the VScode I saw this in the Developer console
ERR memory access out of bounds: RuntimeError: memory access out of bounds
at wasm://wasm/000bc226:wasm-function[254]:0x2b979
at Parser.parse (/home/juleivo/.vscode-server/extensions/rjmacarthy.twinny-3.11.39/out/index.js:2:218649)
at t.CompletionProvider.provideInlineCompletionItems (/home/juleivo/.vscode-server/extensions/rjmacarthy.twinny-3.11.39/out/index.js:2:123675)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async B.provideInlineCompletions (/home/juleivo/.vscode-server/bin/dc96b837cf6bb4af9cd736aa3af08cf8279f7685/out/vs/workbench/api/node/extensionHostProcess.js:155:108949)
twinny is being run in WSL Ubuntu 20.04 LTS

Same issue, OS is macOS, provider is ollama with starcoder:3b – ollama gets request and does computation, but whatever is computed does not show up in VSCode...

I found that setting Folding Range Provider in vscode settings to twinny would solve this issue for me, not sure if it will work for everyone.

@yuhanj2 Thx, that workaround works for me too!

Same issue here. Could it be bugging out due to other extensions?

Hello all, do we have any indication of what is broken?  I have been using the extension myself recently and it's working with latest version of code.  Many thanks.
❯ code -v
1.90.2
5437499feb04f7a586f677b155b039bc2b3669eb
x64

First of all, thank you for all your work @rjmacarthy 🙌🏽
I'm having the same issue, have a setup with ollama and just updated VSC to 1.90.2 and ollama 0.1.48
llama3 for chat ( working )
dolphincoder for FIM (I've tried with codellama, same issue)

Hello, I think starcoder 2 is not good for fim completion I tried it. Please try one of the recommended models in the docs. Many thanks.

Thanks for the heads up. Was working ok but now looking at the logs it seems trying to get a model I dont have locally anymore: "model": "deepseek-coder:1.3b-base-fp16", even when I changed provider to codellama.

Maybe try to restart ide.

I have. Its a bit confusing now: I installed the deepseek model as mentioned above, and then my FIM started working althogh still not requiring the model I have entered as provider (codellama) but deepseek again 🤔
Twinny Stream Debug
Streaming response from <IP_ADDRESS>:11434.
Request body:
"model": "deepseek-coder:1.3b-base-fp16",
"prompt": "<｜fim▁begin｜>/**/\n\n/* Language: Typescript React (typescriptreact) /\n/ File uri

Hello all, do we have any indication of what is broken? I have been using the extension myself recently and it's working with latest version of code. Many thanks.

To start with, thank you for you work!
I was getting the following error upon writing code:

I disabled-enabled the extension, and now it prints the request, but nothing happens:

Then, after a while, the following errors appear:

The chat works...

VSCode info:

I also have the issue of FIM not working. Running Ollama locally on M3 Mac.
VSCode Version: 1.91.0

This is the error in the console:
ERR Cannot read properties of undefined (reading 'apply'): TypeError: Cannot read properties of undefined (reading 'apply')
    at wasmImports.<computed>.stub.e.<computed> (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:177464)
    at null.<anonymous> (wasm://wasm/0003dbda:1:39736)
    at null.<anonymous> (wasm://wasm/0003dbda:1:35226)
    at postInstantiation (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:178474)
    at /Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:178735
    at t.getParser (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:114775)
    at t.CompletionProvider.provideInlineCompletionItems (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:123581)
    at J.provideInlineCompletions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:154:119139)

This is an error in the console:
ERR Cannot read properties of undefined (reading 'apply'): TypeError: Cannot read properties of undefined (reading 'apply')
    at wasmImports.<computed>.stub.e.<computed> (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:177464)
    at null.<anonymous> (wasm://wasm/0003dbda:1:39736)
    at null.<anonymous> (wasm://wasm/0003dbda:1:35226)
    at postInstantiation (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:178474)
    at /Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:178735
    at t.getParser (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:114775)
    at t.CompletionProvider.provideInlineCompletionItems (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:123581)
    at J.provideInlineCompletions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:154:119139)

Also:
ERR Parsing failed: Error: Parsing failed
    at Parser.parse (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:218987)
    at t.CompletionProvider.provideInlineCompletionItems (/Users/username/.vscode/extensions/rjmacarthy.twinny-3.11.43/out/index.js:2:123675)
    at J.provideInlineCompletions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:154:119139)

I am facing the same error with VS Code Ver 1.90.2.

I just released a new version which adds a try catch to the parsing of the document to attempt to fix this problem.  Please let me know if it helps, if not it would be helpful to know what file/language/extension is being used when this error appears.  Many thanks.

I couldn't get a manual suggestion to trigger, not by the command nor the keybind.
However, disabling auto suggestion made the manual trigger work just fine.
"twinny.autoSuggestEnabled": false in settings.

I installed latest version extension today. Configured an embedding, chat, and fim provider with proper models. Embedding was stuck and never ever ever completed (no requests caused Ollama to load model). No completion ever happened. It was with qwen2.5 coder. If I’m using the wrong one for FIM, then maybe the software should say that?! I see completion requests in debug console. None of the debugs had actually helpful information.

Hey @atljoseph,
Thank you for reaching out and sharing your experience with our extension. I'm sorry to hear you're facing issues, especially when you've taken the time to set everything up.
This project is a personal endeavour, and while I strive to ensure broad compatibility, each case's unique configuration can sometimes lead to unexpected behaviours...

I'm having the same issue of chat working fine, but FIM not working at all.
I have FIM configured to use codellama:7b-code, when code completion triggers I see the following error in the debugger:
cannot open file:///extension-output-rjmacarthy.twinny-%231-Twinny. Detail: Unable to read file '/extension-output-rjmacarthy.twinny-#1-Twinny' (Error: Unable to resolve nonexistent file '/extension-output-rjmacarthy.twinny-#1-Twinny'): CodeExpectedError: cannot open file:///extension-output-rjmacarthy.twinny-%231-Twinny. Detail: Unable to read file '/extension-output-rjmacarthy.twinny-#1-Twinny' (Error: Unable to resolve nonexistent file '/extension-output-rjmacarthy.twinny-#1-Twinny')
    at DOe.$tryOpenDocument (vscode-file://vscode-app/opt/visual-studio-code/resources/app/out/vs/workbench/workbench.desktop.main.js:619:8481)

I recall seeing something in the Twinny output in VSCode itself once but I can't seem to repeat that.

I also had error with ERR cannot open file:///extension-output-rjmacarthy.twinny-%232-Twinny..
Downgrading twinny to 3.17.19 seems to help

Thanks @joxxoxo and @Pspritechologist what os etc are you using?

@rjmacarthy
macbook, sequoia (15.0.1)
I've tried reinstalling the extension, removing ~/.twinny folder, reverting settings to defaults, using codellama:7b code+instruct models.
vscode info (latest):
Version: 1.94.2 (Universal)
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z (6 days ago)
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 24.0.0

PS thank you for the great extension btw

Hey @joxxoxo thanks for the response, it's interesting that 3.17.19 works, does 3.17.20 or 3.17.21 break it for you then?
Many thanks!

Yes, I've tried many versions yesterday and 3.17.19 was the latest working for me

I saw some changes in src/common/logger.ts in the next version and thought it can be the reason

FIM is working in 3.17.27 🙌
I don't see Twinny in Output options though 🤷

Thanks @joxxoxo and @Pspritechologist what os etc are you using?

I'm using Arch but some time later (after a restart or two) I opened VSCode and FIM was just working. No idea why.

for me what made code completion work was to use Fim Template: automatic


Add ability to pre-declare a stream

In discussions with PSI (SLS2) at NSLS-II today it became clear that we need the ability to pre-declare what the streams will be before we create the first event.  This will have at least three and a half major benefits

it makes the first measurement less special as we can ensure that the describe / read_configuration / describe_configuration happen when we think they wil
they will enable the bundler to live in a different process and still correctly accumulate all of the notifications it will need
it is now possible to get the descriptor is a custom plan without subscribing to the output stream
the RunBundler class is now pluggable by class level monkey patching or thin sub-classing (could be convinced to make it init time configurable...)

In local testing I added a "strict mode" flag to demand that streams are pre-declared and many tests still passed.

Open questions:

do we want this?
how to manage "strict mode" configuration (probably want 3 modes: YOLO, warn, strict)
how to thread the stream name through count and the scan_nd family of plans because they take an arbitrary user function than can use a different stream name that 'primary' ?
how configurable do we want to make the RunBundler class on the RE?

I think we do want it.
I think we should start with "YOLO" mode only and get some experience with this before we add either "warn" or "strict".
I think that we can defer doing anything helpful or clever with per_step. If anything but the default per_step is used, count and scan_nd can drop the declaration. Users who want both a  declaration and a custom per_step have to write a custom plan. As we get experience with this we can consider adding another parameter to deal with this.
I think class attribute is a fine place to start.

Also, what does "YOLO" mean?

It looks like changes to ophyd broke some of the tests?

I'm guessing https://github.com/bluesky/ophyd/pull/1036 might have something to do with it? @callumforrester do you recognise the error?

I'm interested in getting this merged. I can try to look at why tests were failing, but as the logs have disappeared it would be helpful to re-run the tests first.
I don't think I can tell GH to re-run the tests, but someone has the power to do that, right?

Power-cycled to re-run CI

Well it looks like turning it off and then back on has "fixed" the previously failing tests. Were the previously open questions ever answered satisfactorily?

Open questions:
* do we want this?

* how to manage "strict mode" configuration (probably want 3 modes: YOLO, warn, strict)

* how to thread the stream name through `count` and the `scan_nd` family of plans because they take an arbitrary user function than can use a different stream name that 'primary' ?

* how configurable do we want to make the RunBundler class on the RE?

I can at least answer the first question and say yes, I want this.
The rest of these were addressed by @danielballan
In order to manage count and scan_nd I think the existing code needs to be changed to avoid pre-declaring a stream if a non-default per_shot is passed in. There is already a check for if per_shot is None to assign the default. This could be when the stream pre-declaration is toggled.

Another important question is if strict checking option should be left in RunBundler, but False by default, or if it should be removed entirely for now. If it's False, there's really no way to ever turn it on, unless an option for strict checking were to be added to the RunEngine that could be passed to RunBundler instantiation during open_run
Maybe this is a plausible enough future addition that the code for strict checking ought to be left in?

Thank you @cjtitus for pushing on this!
One change I would like to make is to change the strict_pre_declare to an enum rather than a bool (with values "strict", "warn", and "permissive" and change the parameter to "stream_pre_declare_policy" or something like that), but it is not a disaster if it goes in as a bool (and we can promote later it is just annoying to do so).


Update README to match ReasonUrql module syntax.

Now that we have migrated all modules under the ReasonUrql module, we ought to update the docs to reflect this.

Fixed by #7.


Functionality to Hide 'Save Settings' button via Authorization

Is it possible to hide the 'Save Settings' button based from an Authorization Policy?
The use case is to only allow read-only of the entire Nova Settings page when a user's role is 'view-settings' only.

Is it possible to hide the 'Save Settings' button based from an Authorization Policy?
The use case is to only allow read-only of the entire Nova Settings page when a user's role is 'view-settings' only.

I think in this case is feature request

hi @kevariable - yes please! That would be really great. Thanks for this awesome Nova Settings piece. It really saved us a lot of time.

Added in 3.5.2, please follow https://nova.laravel.com/docs/3.0/resources/authorization.html#authorization

Added in 3.5.2, please follow https://nova.laravel.com/docs/3.0/resources/authorization.html#authorization

Thanks a lot! I'll give it a go

Hi @Tarpsvo I exposed the settings model and created a SettingsPolicy that has several methods there such as viewAny, view, create, update, delete, etc. similar to what's outlined here https://nova.laravel.com/docs/3.0/resources/authorization.html#authorization.
Authorization to show/hide the entire settings resource or show/hide on a per field basis works great jus tfine.
I noticed that all auth returned to false even if I force it to return true. Is there any configuration I may have been missing?

Can you elaborate and show me the policy you created? I'm not sure I understand what's not working.

I have the below Settings Model and SettingsPolicy. I implemented it based from how my other Policies are setup i.e. UserPolicy, PostsPolicy, etc.
Based from this setup, even after I assign the user a view-settings or update-settings permission, they're not able to see the Nova Settings Resource.
Apologies in advance if I've done it incorrectly. I've just set it up similar to the existing policies I have.
Settings Model
`<?php
namespace App\Models;
use Illuminate\Database\Eloquent\Model;
use OptimistDigital\NovaSettings\NovaSettings;
class Settings extends Model
{
protected $primaryKey = 'key';
public $incrementing = false;
public $timestamps = false;
public $fillable = ['key', 'value'];
public function __construct(array $attributes = [])
{
    parent::__construct($attributes);
    $this->setTable(NovaSettings::getSettingsTableName());
}

public function setValueAttribute($value)
{
    $this->attributes['value'] = is_array($value) ? json_encode($value) : $value;
}

public function getValueAttribute($value)
{
    $originalCasts = $this->casts;
    $this->casts =  NovaSettings::getCasts();

    if ($this->hasCast($this->key)) {
        $value = $this->castAttribute($this->key, $value);
    }

    $this->casts = $originalCasts;

    return $value;
}

public static function getValueForKey($key)
{
    $setting = static::where('key', $key)->get()->first();
    return isset($setting) ? $setting->value : null;
}

public function categories(): \Illuminate\Database\Eloquent\Relations\BelongsToMany
{
    return $this->belongsToMany(Category::class)
        ->withTimestamps();
}

}
`
Settings Policy
`<?php
namespace App\Policies;
use App\Models\Settings;
use App\Models\User;
use Illuminate\Auth\Access\HandlesAuthorization;
class SettingsPolicy
{
use HandlesAuthorization;
/**
 * Determine whether the user can view any models.
 *
 * @param  \App\Models\User  $user
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function viewAny(User $user)
{
    if ($user->hasPermissionTo('view-settings')) {
        return true;
    }
}

/**
 * Determine whether the user can view the model.
 *
 * @param  \App\Models\User  $user
 * @param  \App\Models\Settings  $settings
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function view(User $user, Settings $settings)
{
    if ($user->hasPermissionTo('view-settings')) {
        return true;
    }
}

/**
 * Determine whether the user can create models.
 *
 * @param  \App\Models\User  $user
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function create(User $user)
{
    if ($user->hasPermissionTo('update-settings')) {
        return true;
    }
}

/**
 * Determine whether the user can update the model.
 *
 * @param  \App\Models\User  $user
 * @param  \App\Models\Settings  $settings
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function update(User $user, Settings $settings)
{
    if ($user->hasPermissionTo('update-settings')) {
        return true;
    }
}

/**
 * Determine whether the user can delete the model.
 *
 * @param  \App\Models\User  $user
 * @param  \App\Models\Settings  $settings
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function delete(User $user, Settings $settings)
{
    //
}

/**
 * Determine whether the user can restore the model.
 *
 * @param  \App\Models\User  $user
 * @param  \App\Models\Settings  $settings
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function restore(User $user, Settings $settings)
{
    //
}

/**
 * Determine whether the user can permanently delete the model.
 *
 * @param  \App\Models\User  $user
 * @param  \App\Models\Settings  $settings
 * @return \Illuminate\Auth\Access\Response|bool
 */
public function forceDelete(User $user, Settings $settings)
{
    //
}

}
`

You didn't need to overwrite the Settings model. You could've just used the model from this package.
\OptimistDigital\NovaSettings\Models\Settings;

However, if you did overwrite the model - you should also define it in the config/nova-settings.php under the models.settings key.


Tracking transformations by plugin?

I'm currently in the process of writing a code deobfuscation tool, and Babel seems to do almost everything that I had in mind for my homegrown implementation. However, one thing doesn't quite become clear from the plugin handbook: is it possible to keep track of which transformations are applied by which plugin?
I intend to have a separate plugin for each deobfuscation step/strategy, because many obfuscators share some (but not all) techniques, and this kind of tracking would be essential to provide the user with a step-by-step visualization of how both the pre-built plugins and their custom plugins affect the AST.

I'm not sure what you mean by tracking which transforms are made by which plugin. But the design of the plugin system is to merge everything into a single visitor that gets run as a single transform. This was done to drastically improve performance

Right, so to give one example of a hypothetical deobfuscator:

Replace all identifiers that start with 0x_ with an auto-generated identifier name.
Replace all instances of !1 with false.
Remove all functions that aren't actually used anywhere in the code, because they're decoy functions.

These would be three separate steps, and three separate plugins (each of which can be optionally enabled). Even if visitors are optimized to a single traversal for all of them, I'd need some way to identify which AST nodes were affected by which step. Which instances of false originated from rule 2? Which identifiers were auto-generated? Which functions no longer exist?
The usecase here is that I'd have a custom visualization of the entire AST, and that the user should be able to 'step through' the different plugins/passes, and determine what changes were caused by which plugins. Think a debugger for AST transformations.

I have no idea how you'd build such a thing other than a custom script that ran babel over and over with each individual plugin and cloning the AST after each one to diff against.


False Answer in OamPatel/iti_trivia_qa_val

Hi!
I find that some the false answers in your  OamPatel/iti_trivia_qa_val dataset in actually true. (https://huggingface.co/datasets/OamPatel/iti_trivia_qa_val)
For example:
    {
        "question": "Wolf Mankowitz wrote the 1953 novel ‘A Kid For Two….’what’?",
        "question_id": "qb_2689",
        "question_source": "http://www.quizballs.com/",
        "entity_pages": {
            "doc_source": [],
            "filename": [],
            "title": [],
            "wiki_context": []
        },
        "search_results": {
            "description": [],
            "filename": [],
            "rank": [],
            "title": [],
            "url": [],
            "search_context": []
        },
        "answer": {
            "aliases": [
                "Farthing (coin)",
                "Farthing",
                "Farthing (disambiguation)",
                "Farthing coin",
                "Farthings"
            ],
            "normalized_aliases": [
                "farthings",
                "farthing",
                "farthing disambiguation",
                "farthing coin"
            ],
            "matched_wiki_entity_name": "",
            "normalized_matched_wiki_entity_name": "",
            "normalized_value": "farthings",
            "type": "WikipediaEntity",
            "value": "Farthings"
        },
        "false_answer": "A Kid for Two Farthings"
    },
    {
        "question": "Which ‘S’ is a group of geese in flight?",
        "question_id": "qb_6063",
        "question_source": "http://www.quizballs.com/",
        "entity_pages": {
            "doc_source": [],
            "filename": [],
            "title": [],
            "wiki_context": []
        },
        "search_results": {
            "description": [],
            "filename": [],
            "rank": [],
            "title": [],
            "url": [],
            "search_context": []
        },
        "answer": {
            "aliases": [
                "Skein",
                "Skein (disambiguation)",
                "Skeins"
            ],
            "normalized_aliases": [
                "skeins",
                "skein",
                "skein disambiguation"
            ],
            "matched_wiki_entity_name": "",
            "normalized_matched_wiki_entity_name": "",
            "normalized_value": "skein",
            "type": "WikipediaEntity",
            "value": "Skein"
        },
        "false_answer": "Skein"

I just find it by browsing randomly. I think there may be more. Although it may not hurt the result of the paper, it is better to inform  someone who using the dataset of the potential issue.

The truthful answers are from the original dataset, TriviaQA. Is it the case that you found some of their answers wrong?

No. The above truthful answers are all correct (checked by google), meantime, the constructed false_answer is same with correct answers.
I believe there are more cases like them in the dataset. And I guess it may be caused by gpt4 or chatgpt don't follow the generate false answers instruction very well when you are generating false answers.

Oh I see. I would made the same guess as you, and this indeed adds unnecessary noise to the observed metric.
FYI, there are better datasets coming out, which I would love to test ITI on instead, including but not limited to FACTOR.


Generate file header that complies with standard for generated code

See https://github.com/golang/go/issues/13560#issuecomment-288457920. We're not that far away, just need to put the top and bottom of the first paragraph on the same line.

Nevermind, this has already been done.

https://github.com/golang/protobuf/commit/47eb67eaf5cab63c58956d4d4ce86b03ad5eaa03 for reference


Fixed unit-tests

The global mock variables were being reused in may tests, due to which some tests were
failing to run individually, this commit reuses mock variables by creating a DeepCopy of global mock variables to prevent
modification of global mock variables.
There were multiple duplicate functions to create Fake Scheme for the tests,
this commit keeps only one createFakeScheme function for testing StorageCluster controller.
Above two changes are dependent on each other to make tests run individually and as a whole by make unit-test .
Signed off by: Priyanka Jiandani<EMAIL_ADDRESS>

/retest

/retest

/override ci/prow/ocs-operator-bundle-e2e-aws


Pam's H'Craft Quern.  Recipe not shown in JEI. Recipe gleaned from Internet does not work.

What is the problem you're trying to solve with this change? craft a quern.
What do you propose as a solution? Implementation of the recipe.

The Quern has been replaced with the Millstone from the Lord o the Rings mod since they have virtually identical functionality.

Thanks. I already have one of those I will give it a try.  Sorry to have
bothered you.
On Sat, 30 Oct 2021 at 12:20 am, Tungston @.***> wrote:

The Quern has been replaced with the Millstone from the Lord o the Rings
mod since they have virtually identical functionality.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tungstonminer/istari/issues/113#issuecomment-955097747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF2PDHJVLWW4TNWTGKT3JCDUJMT5NANCNFSM5G7ZB3WQ
.


the turn server maybe not works?

Hi,great muaz
i make a experiment of rtcmulticonnection in two client.one is on the network which is symmetric nat ,another is restricted port cone.and now i could not chat in video/audio.i think it is p2p traversal fail.but i check the code.i find as below
` var iceServers = [];
iceServers.push({
url: 'stun:stun.l.google.com:19302'
});
iceServers.push({
    url: 'stun:stun.anyfirewall.com:3478'
});

iceServers.push({
    url: 'turn:turn.bistri.com:80',
    credential: 'homeo',
    username: 'homeo'
});

iceServers.push({
    url: 'turn:turn.anyfirewall.com:443?transport=tcp',
    credential: 'webrtc',
    username: 'webrtc'
});

connection.iceServers = iceServers;

connection.rtcConfiguration = {
    iceServers: null,
    iceTransports: 'all', // none || relay || all - ref: http://goo.gl/40I39K
    peerIdentity: false
};

`
here the code have turn server and i can ping turn.anyfirewall.com successfully and could get turn.bistri.com webpage.i want to know why i could not chat successfully.is the turn server not working?or any errors?
any light would be appreciated.thanks

Did you check your WebRTC logs in chrome?

XirSys always works however free-account disconnects often. Merely anyfirewall  TURN server is expected to work. I'll setup a custom TURN server and remove all these 3rd party links (soon).

thanks,muaz,when you setup your own turn server,tell me and i could try it.thanks very much.

thanks muaz for all your effort
which turn server you would be implementing. can you share the installation steps

coturn is popular,you can google coturn+webrtc.you can get the steps in detail.

The TURN-server is running here:
connection.iceServers = [];

connection.iceServers.push({
    urls: 'turn:webrtcweb.com:3478',
    username: 'muazkh',
    credential: 'muazkh'
});

connection.iceServers.push({
    urls: 'turns:webrtcweb.com:5349',
    username: 'muazkh',
    credential: 'muazkh'
});

connection.candidates = {
    turn: true, // relay:true or turn:true
    stun: false
};

Currently it is listening ports 3478 and 5349 however I'm planning to run on ports 80/443 to make sure it can traverse maximum of the NATs.

oh,thanks.but your turn server maybe not work.
i change
        iceServers.push({
            url: 'turn:turn.bistri.com:80',
            credential: 'homeo',
            username: 'homeo'
        });

        iceServers.push({
            url: 'turn:turn.anyfirewall.com:443?transport=tcp',
            credential: 'webrtc',
            username: 'webrtc'
        });

to
				connection.iceServers.push({
				    url: 'turn:webrtcweb.com:3478',
				    username: 'muazkh',
				    credential: 'muazkh'
				});

				connection.iceServers.push({
				    url: 'turn:webrtcweb.com:5349',
				    username: 'muazkh',
				    credential: 'muazkh'
				});

i get these errors
TypeError: connection.iceServers is undefined
setDefaults()             RTCMultiConnection.js:5379
window.RTCMultiConnection()     RTCMultiConnection.js:1003
initRTCMultiConnection()

and then the application webpage stops and could not chat successfully.
i am sure i have no firewall to stop it.

Now CoTURN is listening both TCP/UDP ports (80/443).
// for v2.2.2 (skip xirsys servers)
connection.getExternalIceServers = false;

connection.iceServers = [];

connection.iceServers.push({
    url: 'stun:stun.l.google.com:19302'
});

connection.iceServers.push({
    urls: 'turn:webrtcweb.com:80',
    username: 'muazkh',
    credential: 'muazkh'
});

connection.iceServers.push({
    urls: 'turn:webrtcweb.com:443',
    username: 'muazkh',
    credential: 'muazkh'
});

Currently port 443 is listening fake certificate that's why we can't use turns:.

@muaz-khan But do FF and Chrome even use Turn if it's not encrypted over SSL? I'm just wondering about Chrome, because it forces SSL for camera access and also has the rule that on a encrypted sites all resources need to be called over SSL.

@muaz-khan
Where can I find instructions to implement my own Turn server?

You can try this (2013-old) post:

https://www.webrtc-experiment.com/docs/TURN-server-installation-guide.html

I'll update it for the CoTURN installation steps on Ubuntu/Debian, after fixing turn:webrtcweb.com:80 auto-disconnection bugs.

Dear all, muaz-khan,
I also installed CoTURN, and I'm experiencing auto-disconnection issues. I'm not able to see any related number of connection nor up time. Is this something known and fixed ? Can someone help me regarding this ?

@muaz-khan I have implemented turn and stun server as you have implemented in "Video Conference" But I am unable to  get Remote Stream if they are on another network. its work only when end user and me are on same wifi. Please guide .
Thanks in adance

Hi Muaz,
I used you turn server in my webrtc application. They didn't work. I am able to share screening within same wifi but not able to
share screen on different network. I created my own turn server also but still not able to share screen on different network. Please can you help me in this. session<PHONE_NUMBER>00000002: user <>: incoming packet message processed, error 401: Unauthorised. This error is logging in my turn server when i connect with my application. Can you help me regarding this. I used your turn server also in my code but they are also not working. Please help me into this


secrets from HashiCorp Vault

Added support for authentication with secrets from HashiCorp Vault by expanding the TriggerAuthentication resource with vault property which contains the authentication settings.
Vault property allows next options:

address - Vault address (format - <scheme>://<host>:<port>)
authentication - authentication method (currently supported: token and kubernetes)
role and mount
credetial - defines the Hashicorp Vault credentials depending on the authentication method
secrets - list that defines the mapping between the path of the secret and the key in Vault to the parameter

for example:
apiVersion: keda.k8s.io/v1alpha1
kind: TriggerAuthentication
metadata:
  name: keda-trigger-auth-vault
  namespace: devops
spec:
  vault:
    address: <VAULT-ADDRESS>
    authentication: kubernetes
    role: <ROLE>
    mount: kubernetes
    credetial:
      serviceAccount: /var/run/secrets/kubernetes.io/serviceaccount/token
    secrets:
      - parameter: connection
        key: CONNECTION_STRING
        path: <SECRET-PATH>

Fixes #
#673

PR to keda docs kedacore/keda-docs#199

@nisan270390 do you think you could add some tests to cover this scenario?

@zroubalik All the logic around HashiCorpVault Handler is in the initializing of the vault client, I don't see a way to write tests that will test this topic well


[$250] [Test] External label

This is a test of https://github.com/Expensify/Web-Expensify/pull/34925, please do not mind

All seems to work well


SDIT-423 Fix flyway version numbers

Codecov Report
Patch and project coverage have no change.

Comparison is base (0ffb69e) 77.53% compared to head (2dbae80) 77.53%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #240   +/-   ##
=========================================
  Coverage     77.53%   77.53%
  Complexity     1305     1305
=========================================
  Files           228      228
  Lines          5627     5627
  Branches        196      196
=========================================
  Hits           4363     4363
  Misses         1143     1143
  Partials        121      121

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Parse trailing xxx..../ in the server url configuration

Trailing / in the server url configuration file
The trailing / in the server url is causing a breaking change.
REFERENCE
https://github.com/saran-surya/email_auth/issues/89#issuecomment-1643211350

Hi @soueip ,
Can you please explain the last comment from your side ?


Remove id from TestSuite as its not specified in schema

As per https://windyroad.com.au/dl/Open Source/JUnit.xsd, I do not see id as an attribute for testsuite

please run bazel run //tools/format:format

@mielnikk

please run bazel run //tools/format:format

Rebased, it looks like there was an issue with installPlugins.sh that was resolved in another commit

Are you sure it's not specified? Because the schema contains this:
<xs:attribute name="id" type="xs:int" use="required">
  <xs:annotation>
    <xs:documentation xml:lang="en">Starts at '0' for the first testsuite and is incremented by 1 for each following testsuite</xs:documentation>
  </xs:annotation>
</xs:attribute>

I can see the id in generated JUnit4 test results as well.

Are you sure it's not specified? Because the schema contains this:
<xs:attribute name="id" type="xs:int" use="required">
  <xs:annotation>
    <xs:documentation xml:lang="en">Starts at '0' for the first testsuite and is incremented by 1 for each following testsuite</xs:documentation>
  </xs:annotation>
</xs:attribute>

I can see the id in generated JUnit4 test results as well.

Ah yep, you are right, missed it was an extension of the complexType and thought it was an attribute on testSuites.


Enable HTTPS with your own certificate via Powershell/ARM?

I want to configure HTTPS for my CDN with custom domain using certificate I've got from certificate authority. I've spent some time to figure out how to do it "automatically", but I cannot find the way to do it via ARM nor Powershell.
https://docs.microsoft.com/en-us/powershell/module/azurerm.cdn/?view=azurermps-6.13.0#cdn
https://docs.microsoft.com/en-us/cli/azure/cdn?view=azure-cli-latest
According to this docs you can enable HTTPS but it doesn't provide a way to use certificate stored in KeyVault (as showed in this tuturial https://docs.microsoft.com/en-us/azure/cdn/cdn-custom-ssl?tabs=option-2-enable-https-with-your-own-certificate).
This is very important to me to have possibility to do it via ARM/Powershell or any other automated way - clicking through Azure Portal does not comply with "Infrastracture as Code".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: beac0740-af6e-61ce-bcfa-e783ca181b7d
Version Independent ID: d97885ea-b051-5fde-bd14-ec977e34760e
Content: Tutorial - Configure HTTPS on an Azure CDN custom domain
Content Source: articles/cdn/cdn-custom-ssl.md
Service: cdn
GitHub Login: @mdgattuso
Microsoft Alias: magattus

@SubhashVasarapu-MSFT Hi I'm looking for an automated solution too, couldn't access the link by @materniak because of too many redirects.. mind you provide me with instructions or alternative guideline link?


Twitch video frame is overflowing on mobile devices

Twitch video frame is overflowing on mobile devices
Reproduced in Moto G5s Plus

Fixed in #31
Can you confirm if its good for you now? @yg

Yay :tada:
Fixed and the new UI is awesome @bdougie :clap:


netCore version changed to 2.0

netCore version changed to 2.0 and finished message added at the end of performance test

thanks, someone uses it so I'll try to create CI and release when merged.


Promisify api

Continuing conversation from: https://github.com/CommaSword/noise-generator/issues/6
Adjust Audio API and main module API to return promises.
Consider using comlin: https://github.com/GoogleChromeLabs/comlink

Comlink is really cool, but not for us atm: https://github.com/GoogleChromeLabs/comlink/issues/49

Done.


Add missing Thenable definition

This should resolve local build errors

Thanks for the PR - I noted that I accidentally excluded a source folder (typings) with .gitignore and that contains the thenable.d.ts and some other files. Sorry for the inconvenience, the next push will have the full code base.

thenable.d.ts is now added and it should build now. Please reopen the pull request, if that didn't fix the problem :)


cassandra: add a LIMIT to help Cassandra stop reading

This way, as soon as it has fetched all its elements it
will stop reading SSTables.

This change is

Look good to me


Issue #1007: clustered store invalidation

basic config for strong/eventual has been added, the real deal should be done in #1077
3-tier invalidation doesn't work yet as it requires a new release of the offheap store
tests are lacking but coming

Now that this PR is based on top of master having the clear operation, I believe it lacks the triggering of complete invalidation on clear.

test this please

Handling of clear will happen in another PR.


promise-must-complete false positive when passing resolve/reject out of scope

Take the following code snippet that lazy-loads an external script:
new Promise(resolve => {
    const script = document.createElement('script');
    script.onload = resolve;
    script.src = 'http://example.com/script.js';
    document.body.appendChild(script);
});

This would fail with
demo.ts[1, 1]: A Promise was found that appears to not have resolve or reject invoked on all code paths

I would suggest providing a less-strict version of promise-must-complete rule, or an option,  which bails out and allows the rule to pass when resolve and/or reject are made available outside the scope of the promise's closure.

Yes, so this was a conscious design decision. I like your recommendation of adding a parameter to make it a little less strict.

☠  It's time! ☠
Per #876, this repository is no longer accepting feature pull requests. TSLint is being deprecated and we recommend you switch to https://typescript-eslint.io.
Thanks for open sourcing with us, everyone!


Week 2 Update Meeting April 18 @ 2:40pm

Done-ish. Not sure if the meeting counts as week 2 or week 3. Either way, there shouldn't be an issue with missing anything due to my position in the project.


[5.3] Unable to use delayed mail sending via Mail facade

Laravel Version: 5.3.7
PHP Version: 7.0.8
Database Driver & Version: MySQL 5.7.13

Description:
When using the mail facade as described by the documentation, I encounter the following fatal throwable error:

Call to undefined method Illuminate\Mail\MailableMailer::later()

Sending and non-delayed queueing work as expected.
Am I missing something?
Steps To Reproduce:
Simply call the following from a controller
Mail::to($recipient)->later($sendDate, $mailable);

later method isn't defined in Illuminate\Mail\MailableMailer
https://laravel.com/api/5.3/Illuminate/Mail/MailableMailer.html
this method is defined in Illuminate\Mail\Mailer
https://laravel.com/api/5.3/Illuminate/Mail/Mailer.html

I understand that later() is defined in Illuminate\Mail\Mailer, but when calling Mail::to($recipient), an instance of Illuminate\Mail\MailableMailer is returned which clearly lacks said later() method.
This way of using it is exactly as shown in the documentation:
$when = Carbon\Carbon::now()->addMinutes(10);

Mail::to($request->user())
    ->cc($moreUsers)
    ->bcc($evenMoreUsers)
    ->later($when, new OrderShipped($order));

The docs seem to be out of date for this part, to send a queued mail you need to do the follwing:
$message = (new OrderShipped($order))->delay(60);

Mail::to($request->user())
    ->cc($moreUsers)
    ->bcc($evenMoreUsers)
    ->queue($message);

I think we should add it back though :)

@themsaid Thanks for clarifying. That would also explain why sendNow() isn't documented yet.
I agree with you that later() should be added back in. Given that the goal of this tool was simplicity and clarity, removing it seems like a bit of a step backwards.

Will check if Taylor is ok with bringing it back, since you can do this:
Mail::to($request->user())
    ->cc($moreUsers)
    ->bcc($evenMoreUsers)
    ->queue((new OrderShipped($order))->delay(60));

Which is not that bad as well.


Rework EmailProvider to avoid leaking Context

Static state in general is bad for Instant Run compatibility. We should tie all global state to the lifetime of the Application instance. But that's quite a bit of work with no immediate benefit. I think we should table this for now.


Import timeout code from http.rb (originally by Zach Anker)

Edited for simplicity, removing Ruby 2.0 support.
No tests yet. Will try to crib some from http.rb.

Coverage decreased (-30.9%) to 49.074% when pulling 3986d27411e88e1bd0c1cb1028c8858ebca950e7 on timeouts into ceb77e5d5b37c434122567a3758cc7b678e0170f on master.


webstorm

how resolve this problem?

what is it trying to do? look up .use?

This is a local settings issue, just check a colleagues webstorm setup which does not behave like this.

Yes，trying to look uo .use function

In order for WebStorm to get the right function definition for libraries like koa, just set the project's Javascript libraries (Languages & Frameworks > Javascript > Libraries). Press Download then find koa from the Typescript community stubs

It is an issue of WebStorm, rather than koa. Because javascript is a kind of dynamic types languages, WebStorm can not always find the right function definition.


Add files via upload

@CndGui I am sorry, the domain pucgo.edu.br is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


x64 bug in extension regex processing causes runaway memory use

VSCode Version: Code 1.16.1 (27492b6bf3acb0775d82d2f87b25a93490673c6d, 2017-09-14T16:38:23.027Z)
OS Version: Windows_NT x64 10.0.15063
Extensions:

Extension
Author (truncated)
Version

plsql
cas
0.0.3

jet
dio
0.0.1

xml
Dot
1.9.2

backspace-plusplus
jri
0.0.16

csharp
ms-
1.12.1

PowerShell
ms-
1.4.3

SQR
Cit
0.2.5

(1 theme extensions excluded)

Extension processing using x64 version of VS Code improperly handles single quote regex match of "('(?:\\'|.)*?')" with a string containing a pound sign character (e.g. 'string#'). Symptom is runaway memory use until the workstation becomes unresponsive.
Steps to Reproduce:

Install SQR 0.2.5 extension
Open a file containing a single line:   print 'Emp# '     (+1,1)

Reproduces without extensions: No

Please file bug against the corresponding SQR extension

The bug is not caused by the extension. The bug is caused by faulty regex processing in VS Code. The regex processing works perfectly well in the x86 version of VS Code.

@coe-jeubanks Where did you find this regex?

Ok, got it: https://github.com/CityOfEscondido/Visual-Studio-Code-SQR/blob/6754ec99c75ae70aaa88d454675f4365eb9401de/syntaxes/sqr.json#L68

This issue was moved to Microsoft/vscode-textmate#56


Implement new command line option to optionally skip module tags

This is very useful for couple of reasons:

In Haskell almost always module names and file names are the same, e.g. module A.B.C is in A/B/C.hs etc. This makes finding modules very easy and tags are usually not necessary.

There's a very old bug that still effects my workflow: https://github.com/ctrlpvim/ctrlp.vim/issues/92 Because of this I need to be very careful with tags with same names. In Haskell we often have modules that define types with same names, e.g. TypeRep.hs defines the type TypeRep etc. This patch helps with avoiding the linked bug in these cases.

Thanks for fixing the build, not sure how that made it in :/
I actually use module tags when I want to get to a module but don't want to type the complete path.
Would it be simpler to filter the output of processFile rather than not generate the tags in the first place?  I worry about accumulation of config flags being passed everywhere.  It would also then be really easy to generalize to a "include only these types" flag... though let's not do that unless you can think of a good reason.

How does it look now? Tried to make it easier to extend.

I'd just filter directly, but I'll just merge now rather than micromanage you to death :)


Created forget password feature

Successfully created the forget password issue, please merge the the pull request
Check the demo

solve this conflicting issue in login.css & raise PR again

Hey can you check the pr again ?   I have resolved the conflict
On Sun, 12 May 2024 at 16:21, Anurag Verma @.***> wrote:

image.png (view on web)
https://github.com/anuragverma108/SwapReads/assets/129655645/55f4ab41-176e-4ec6-ba35-ea28987fafa7
solve this conflicting issue in login.css & raise PR again
—
Reply to this email directly, view it on GitHub
https://github.com/anuragverma108/SwapReads/pull/182#issuecomment-2106205078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A6HOYD7VNRGPSEX2ECTR6NTZB5CUNAVCNFSM6AAAAABHSSR2MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGIYDKMBXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Application: SpiderDAO

Grant Application Checklist

[X] The application-template.md has been copied, renamed ( "project_name.md") and updated.
[X] A BTC address for the payment of the milestones is provided inside the application.
[X] The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
[X] The total funding amount of the project is below CHF 30k at the time of submission.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: PierreLaurent789:x: AnasSpider:x: SpiderDAO-1You have signed the CLA already but the status is still pending? Let us recheck it.

@SpiderDAO-1 Thanks for the application. I noticed that you listed Polkadot & Kusama as partners on your website. You are kindly asked to remove this, as no such partnership has been established. Your application will not be considered until then.

@mmagician Thanks for the feedback.  We did ask for permission to show these from Peter at parity which was agreed. To clear the air we are happy to remove them and apologies if we caused any upset here this was completely innocent.

@SpiderDAO-1 Thank you for taking swift action and I'm sorry for any misunderstanding caused regarding the wording. Let me clarify here: If you get a grant, you can say that you are a grant recipient, but Polkadot and Kusama are decentralized protocols so you can’t “partner” with them.

Thanks for your feedback @mmagician. Regarding your questions:
1.

Yes, we are going to offer open-source code through our GitHub for the Router and other modules.
Yes, we can guarantee that 1 router = 1 vote this will be controlled and checked via on-chain and off-chain workers.
2.
We are going to use Uboot environment variables to set our essential data and the router holder can not change this data. If the end-users run a factory reset of the router the Values of the router other than the MAC Address are removed completely. Then the user would have to initialize the router again.
3.
Our routers will be connected to a database which assigns the wallet registered when setting up to the router unique id (A combination of encrypted wallet seed + router mac address + router serial number) and every request will include generated unique file md5-check to confirm it's being done through the router.
4.
Milestones
Setup DAO framework on Kusama.
Successfully connect DAO entities (individual voters) to Spider routers. This will include one use case to show the connection is established correctly.
establish robust communication protocol between Routers and Onchain actions (e.g. pass on a vote form a verified wallet on a verified router as an on-chain vote).
Prepare a router firmware for all customers with the new module to establish the connection with the DAO entities.
Pass on a governance decision to move from Kusama towards substrate mainnet. Test vote. Real votes will be done through a bot on our discord server until the solution features are fully fledged.

Let us know if you got any other questions.

@AnasSpider Thanks for taking the time to comment. I am not sure whether my questions were not clear enough or there is another reason, but I feel like your responses did not (in the most part) answer my questions. Let me be clearer then:

Our routers will be connected to a database which assigns the wallet registered when setting up to the router unique id (A combination of encrypted wallet seed + router mac address + router serial number) and every request will include generated unique file SHA-512 checksum to confirm it's being done through the router.

As far as I can tell, there's still nothing preventing a user from registering a new wallet with a new router, right?
Q: What is the essential data? (You haven't really specified what it is)
Q: Are you using open source hardware, or else how do you support the claim that you have a secured ROM?

Setup DAO framework on Kusama.

How do you plan to do that? Are you going to use runtime modules, or smart contracts?

establish robust communication protocol

What is this protocol?
Please keep in mind that the more details you provide, the more likely we are to positively review your application.

@mmagician Thanks for your reply, Let me clarify more on your points, Please be assured that we here to help the open-source community as much as we can with our experience.
Going through your questions:
1. As far as I can tell, there's still nothing preventing a user from registering a new wallet with a new router, right?

Yes that's right and it can happen but that will come at a heavy cost for adding more routers and also have to wait for a period of time deemed reasonable to the DAO. Users must have active transactions on the wallet before being able to vote to make sure bots and whales won't get access with ease.

We will be keeping a log of every MAC Address and serial number for every router we add to our inventory, this we’ll be added to an on-chain ledger or on-chain database. This will help us to identify any clone or anyone trying to spoof/manipulate the hardware.

If the essential data mentioned below is not matched to the end-user and they try to spoof or manipulate access. There will be 3 warnings followed by a ban from taking a part in our governance model for a limited time(still to be decided). The ban time will be increased systematically based on the number of times this is identified until the customer is banned indefinitely if the infringement persistently continues.

We will also be in constant contact with the growing SpiderDAO community and the open-source community for beneficial ideas on how to make the governorate safer and more resilient to whales-resistance.

2. Are you using open-source hardware, or else how do you support the claim that you have a secured ROM?

Yes as we want to be involved much more in the open-source community, We are going to be using the Uboot environment with its open-source code to save the essential data which would be listed in the next question.
To go into more detail on that point, We will also be giving our community members the option to choose between Open Source wireless drivers and the closed source ones for them to choose so we can make sure we offer an OpenSource friendly solution.

3. What is the essential data? (You haven't really specified what it is)
The essential data is a combination of the following:

encrypted wallet seed using aes-256-cbc encryption standard with an auto-generated passphrase saved as part of the essential data.
PS: Please note the passphrase would only be local and will be independent to the requests sent by the router for the governorate operations.
Router Mac Address to avoid it being cloned.
Router serial number which cannot be cloned as it's a part of the chipset code.
SHA-512 checksum for a temp file that is created with all the data above which is updated every time the router is rebooted with the timestamp.

4. How do you plan to do that? Are you going to use runtime modules, or smart contracts?

We are planning to build using smart contracts at the beginning but as we scale up to more transactions, We are most likely to move toward a shared solution so we can cut the costs and take charge of how our blockchain will operate.

5. What is this protocol? - establish a robust communication protocol.

We are planning to write a substrate faucet to communicate with our discord server for our customers to send the token needed for the vote, Initiate voting, pass on the vote for the voting process that would be operated through our discord server.

@AnasSpider Thank you for a comprehensive response. Would you mind integrating the above comments directly into your application please?

@mmagician We have integrated the above comments into the application as requested this is visible on version 2.2. Thanks for the feedback.

Thanks, I'll share your application with my team.

Also, I think it only makes sense to evaluate your solution on the actual hardware. Therefore, in case the grant is approved, please be aware that you might need to send us the router to perform the evaluation on. The details of delivery can be finalised upon completion of your work.

@mmagician Thank you for the reply we are really looking forward to contributing to the Polkadot Ecosystem. We are happy to disburse routers for evaluation and we would happy to do that before completion of the milestones,  as we feel your feedback will be very valuable as we start completing our roadmap.

@Noc2 Thanks for your reply. Regarding your questions:
1- Could you please reduce the price a little bit more?

Sorted

2- Could you specify the technical implementation of the smart contracts? Are you planning to use ink!?

We will create smart contract modules that we will use for showing the voting process from our router.
We are leaning towards using ink yes.
We are currently looking to deploy that ourselves.

3- Could you integrate a medium article into the deliverables?

Sorted.

Let us know if you got any other questions.

@AnasSpider Thanks for the update. Could integrate ink! into the deliverables as well as specify the programming language/framework for the following deliverable: “Discord Communication”? And feel free to remove “on Kusama for this milestone”, since this is something we can not really enforce/ensure.

Thanks for your reply. All requested changes have been added.
Please let us know if you got any other questions.


New version with psr/http-message 2 support

PSR-7 v2 support was added in #289, but there is no version released.
Please cut a new release with the recent changes included.
Thank you.

I would be most grateful as well. Looking for workaround at the moment.

I guess the only work around that comes to mind is forking the repo and implementing the commit ourselves. It seems Slim is dying slowly, as opposed to Symfony and other frameworks.

Yes, that would be really great, I start to get errors with other libraries and switched to dev-master in composer now, but it would be great if you can add a release.

At this moment there is one PR pending for the 1.7.0 milestone: https://github.com/slimphp/Slim-Psr7/milestone/14.
I think if we want new release, we have to move https://github.com/slimphp/Slim-Psr7/pull/294 forward


apr-util port installs broken header which prevents static linking

The portfile for apr-util modifies apu.h and replaces defined(APU_DECLARE_EXPORT) or defined(APU_DECLARE_STATIC) with 1. This modification makes its way into the installed header. As a consequence linking with aprutil-1.lib results in unresolved externals because the exported data is not marked dllimport and the linker does not pick them up automatically as is the case for functions.

Hi @gix , thanks for reporting this issue!
I've fixed this issue, please update and rebuild apr-util.
Thanks.


Opt-in for analytics instead of opt-out

Current Implementation

Analytics is enabled until the user manually opts out in the settings. Every user leaves a data trace to analytics providers.
Suggested Enhancement

Switch from opt-out to explicit opt-in for analytics. Ask the user on the very first app start, if he wants to share data with analytics providers.
DB Streckenagent has a non skippable dialog on the first app start:

Changing analytics state is very convenient. A user can see it on the top-level settings page:

Expected Benefits

If a user doesn´t want to share analytics data, his data is never shared. The user is always in full control of his (analytics) data.
This seems to be more GDPR compliant (i am not a lawyer).

Dear @IndianaDschones,
Thank you for opening this issue! Actually we already are working on a new way to handle the analytics tracking in the app and we also plan to change the current Opt-Out option to an Opt-In.
Your example of the DB Streckenagent is really helpful for us as well.
So thanks again for your input and keep an eye on our following releases, in which this adjustment will be included.

@IndianaDschones, fyi, we changed the Opt-Out to Opt-In for Adobe Analytics in app release 3.12.0.


Using python module arlpy in golang simulation?

Congratulations for this interesting library. I am trying to understand, is it possible to use it to use a properly configured python module arlpy from golang application on linux:
https://arlpy.readthedocs.io/en/latest/uwapm.html
The application should call:
>>> import arlpy.uwapm as pm
>>> env = pm.create_env2d()
>>> tloss = pm.compute_transmission_loss(env, mode=pm.incoherent)
>>> pm.plot_transmission_loss(tloss, width=1000)

https://github.com/org-arl/arlpy

@Vytek I just tested, seems it worked, but something wrong in above code.
(py312) ➜  go-python git:(fix) ✗ python
Python 3.12.3 | packaged by Anaconda, Inc. | (main, May  6 2024, 14:46:42) [Clang 14.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import arlpy.uwapm as pm
>>> env = pm.create_env2d()
>>> tloss = pm.compute_transmission_loss(env, mode=pm.incoherent)
[WARN] Bellhop did not generate expected output file
>>> pm.plot_transmission_loss(tloss, width=1000)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/lijie/miniforge3/envs/py312/lib/python3.12/site-packages/arlpy/uwapm.py", line 523, in plot_transmission_loss
    xr = (min(tloss.columns), max(tloss.columns))
              ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'columns'

The go-python version:
package main

import gp "github.com/cpunion/go-python"

func main() {
	gp.Initialize()
	pm := gp.ImportModule("arlpy.uwapm")
	env := pm.Call("create_env2d")
	tloss := pm.Call("compute_transmission_loss", env, gp.KwArgs{"mode": pm.Attr("incoherent")})
	pm.Call("plot_transmission_loss", tloss, gp.KwArgs{"width": 1000})
}

Build and run:
(py312) ➜  go-python git:(fix) ✗ go build -o arlpy.out ./_demo/arlpy && ./arlpy.out
[WARN] Bellhop did not generate expected output file
Traceback (most recent call last):
  File "/Users/lijie/miniforge3/envs/py312/lib/python3.12/site-packages/arlpy/uwapm.py", line 523, in plot_transmission_loss
    xr = (min(tloss.columns), max(tloss.columns))
              ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'columns'

It has same outputs to your Python code.

@Vytek Could you please share me why do you need call this library in Go? I wish go-python more useful.

Of course and with pleasure. There is no doubt that the amount of scientific libraries in python is enormous. In this specific case arlpy is the simplest interface that the Ocean mathematical simulation platform that we are developing towards Bellhop Underwater Acoustics:
https://patel999jay.github.io/post/bellhop-acoustic-toolbox/ without having to rewrite the entire library in Go. In addition, the new version https://github.com/A-New-BellHope/bellhopcuda is also written in C++ and it is not at all easy to interface it in Go. Going through arlpy everything is much simpler and tested and I believe that this is true for many other scientific contexts.

Thank you for sharing, this is similar to what I had in mind. There are many libraries that don't have Go bindings, or only have old and incomplete versions, while Python has many better wrappers of these libraries.

Owner

Perfect, I will use this same system to interface with many other scientific libraries that have excellent management on python.
As for the anomaly that you reported to me, it is most likely due to the installation of the Bellhope binary that must be done separately before the relative wrapper in python. In any case, I am experimenting. Thank you very much for everything!


Allow concurrent activation execution, in some cases

When creating an action, it would be nice to be able to annotate it as -a concurrent <max concurrent  activations> to indicate that concurrent activation executions are allowed in the same container, up to some maximum. This would, for example, allow web actions to be more scalable, instead of limited to the number of concurrently running containers.  This would only be allowed for actions/users that are repeatedly invoked - parameters may be unique per activation, but the action+user would have to be the same for concurrent execution.
This would complicate:

log collection (log would include interleaved messages from multiple activations, which may be ok)
pause/unpause after activation completion (don't pause till there are no more activations running)

This would be a radical departure from the current model and comes with some significant baggage. I'll add to the list of complications:

what does guaranteeing a CPU share mean if multiple instances of an action are running concurrently in the same container?
similarly how do any of the limits now apply with respect to memory, io, network, diskspace?
how do you save the user from themselves when their code is racy, or uses the file system incorrectly, what does it mean for debugging, or performance isolation?

If someone were to try - it's certainly doable (the very first whisk prototypes did this) - I can't yet imagine how it would be deployed in a production environment. I can imagine how with some program analysis, it's possible to identify actions for which intra-container concurrency may be plausible. The annotation is the early escape clause to "release" for the platform from undefined, or unintended behavior.
The serveless promise is that the platform scales to handle any given load. Before going down this road to increase density, might it be more prudent to explore leaner isolation technologies instead?

@rabbah I'm not sure this baggage is different than what a developer would deal with if, instead of use a serverless approach, was to package there code into a node container, and run it that way? That is, when you run a container as a traditional web service, you have to gauge cpu/memory requirements in line with traffic and usage characteristics.  Instead of analysis to infer concurrent activation support, I would expect making this more explicit, like based on a different function name (main() vs mainConcurrent()) or annotation or ? would be better, but maybe there are cases where inferred behavior would also be useful.
I look at it as one additional knob for tuning resource utilization, where you can gain some benefits of serverless (scaling is done, but now based on reaching max allowed concurrency), and you also gain some benefits of increasing resource efficiency (in some cases functions may be just as happy serving 200 (or 2000+) concurrent activations as a single activation).  Tuning cpu shares for  concurrent requests support may be too coarse grained of an adjustment for many situations.
Another approach would be to avoid statically defining concurrency, and instead allow actions to define some backpressure function (in addition to "main()"), so that there can be some more custom logic applied to the concurrency limits. (e.g. backpressure based on concurrent downstream data usage, but not for function-managed internal cache hits)

My 2c on this: the implicit assumption here is that concurrency implemented through Node's EventLoop is vastly more efficient than concurrency by running containers in parallel. Where "vastly" is large enough to justify looking into the complexity stated above. I think in order to have a meaningful discussion on that we will need a set of shared performance/throughput test scripts (maintained within OW) and results.

FYI running perf tests in docker-compose env via ab load test against helloworld.js with #2060 using -a concurrent-max 1000 I get:
Percentage of the requests served within a certain time (ms)
  50%    567
  66%    630
  75%    678
  80%    707
  90%    790
  95%    881
  98%   1010
  99%   1124
 100%   1420 (longest request)

compare to without using the concurrent-max annotation:
Percentage of the requests served within a certain time (ms)
  50%   1653
  66%   1819
  75%   1931
  80%   2005
  90%   2330
  95%   2584
  98%   2932
  99%   4060
 100%   7674 (longest request)

I'll submit a separate PR to enable rerunning these tests easily in openwhisk-devtools

a suggestion: rerun on master but suppress pause/unpause entirely; from past results you can get 2x or more from that alone.

@tysonnorris thanks for sharing these numbers. Interesting! Made me wonder how these would change (or not) when the action is i/o-bound - e.g. the weather app from IBM's Bluemix tutorial (which IMHO is quite representative of typical OW actions):
`var request = require('request');
function main(params) {
var location = params.location || 'Vermont';
var url = 'https://query.yahooapis.com/v1/public/yql?q=select item.condition from weather.forecast where woeid in (select woeid from geo.places(1) where text="' + location + '")&format=json';
return new Promise(function(resolve, reject) {
request.get(url, function(error, response, body) {
if (error) {
reject(error);
}
else {
var condition = JSON.parse(body).query.results.channel.item.condition;
var text = condition.text;
var temperature = condition.temp;
var output = 'It is ' + temperature + ' degrees in ' + location + ' and ' + text;
resolve({msg: output});
}
});
});
}`

@rabbah, as you mention above this issue is about a rather fundamental design aspect. Do you think it makes sense to discuss this on the mailing list to get broader attention? It would be interesting to understand the history better (why early prototypes implemented this approach and why it was abandoned). Also, I think it would be a good discussion to look at use cases other than public cloud (i.e. private OW deployments). Reason I mention that: that might render moot some of the complexity arguments above.
Really don't know the outcome of such a discussion - but I think it's really worth having it and have it go "on record", because I believe this topic is likely to pop up again.

@rabbah thanks - yes tried that originally, and its better but still not good performance.
No-pause + without concurrent-max annotation:
Much better but still not great performance.
Percentage of the requests served within a certain time (ms)
  50%    584
  66%    654
  75%    712
  80%    749
  90%    843
  95%    929
  98%   1438
  99%   2785
 100%   6727 (longest request)

No-pause + with concurrent-max annotation:
Slightly worse than above, possibly due to log file parsing issues that come up with concurrent requests - I will take a look at that.
Percentage of the requests served within a certain time (ms)
  50%    625
  66%    700
  75%    759
  80%    800
  90%    919
  95%   1082
  98%   1579
  99%   1767
 100%   2301 (longest request)


Pledge Model

level enum (what are the sponsor pledge levels?)
pledge_type enum (:monetary, :inkind, :both)
amount_pledged integer
amount_paid integer
inkind_pledged integer
inkind_received integer
sponsor_id
belongs_to :sponsor

This should be possible to make now that sponsor model is created 👍


Excel template - editing multiselect boxes doesn't work

Opening an 'edit' form clears some existing data

There is no concept of 'editing' rows via a UserForm. Delete a row and re-add


Makes URL optional

@jessfraz let me know what else is needed for this please! :P thanks!
Fixes #88

SO we wouldnt want to modify the spec directly since it is generated from the api server. Can you modify the generator in openapitor to make URL's optional?

SO we wouldnt want to modify the spec directly since it is generated from the api server. Can you modify the generator in openapitor to make URL's optional?

Oh! this spec is just a generated spec? Where is openapitor, seems like a separate lib but I don't see it in the repos

its right here https://github.com/KittyCAD/kittycad.rs/tree/main/openapitor, this is the code generator it lives in this repo since its easier to update here

its right here https://github.com/KittyCAD/kittycad.rs/tree/main/openapitor, this is the code generator it lives in this repo since its easier to update here

Hmm, I'm not finding anything in the generator that actually generates spec.json? Everything seems to be about reading spec.json.
Or are you saying we should make every url always nullable?

SO we wouldnt want to modify the spec directly since it is generated from the api server. Can you modify the generator in openapitor to make URL's optional?

btw is the schema coming directly from the DB? The reason it's not a nullable url is because the DB has the image field for a user set to NOT NULL?

We don’t want to change the spec, I was saying let’s always assume in the generator that URLs are optional On Aug 29, 2022, at 3:19 PM, Garrett Skelton @.***> wrote:
SO we wouldnt want to modify the spec directly since it is generated from the api server. Can you modify the generator in openapitor to make URL's optional?
btw is the schema coming directly from the DB? The reason it's not a nullable url is because the DB has the image field for a user set to NOT NULL?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

We don’t want to change the spec, I was saying let’s always assume in the generator that URLs are optional

Where would that be? I haven't found the code that actually creates the structs, idk what I need to grep for

checkout types.rs in openapitor

checkout types.rs in openapitor

There wasn't one, but I eventually found the type building code!

You need to run EXPECTORATE=overwrite cargo test -p openapitor

You need to run EXPECTORATE=overwrite cargo test -p openapitor

oh I did the test stuff in a different PR #90, do I need to do that in this branch too?

It only matters in this branch ;) since you changed the generator On Aug 30, 2022, at 10:37 AM, Garrett Skelton @.***> wrote:
You need to run EXPECTORATE=overwrite cargo test -p openapitor
oh I did the test stuff in a different PR #90, do I need to do that in this branch too?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

It only matters in this branch ;) since you changed the generator

ah ok, generated a new r.gens file 👍


Add ability to disable default plugins

I couldn't find a way to disable the auth-token-cookie plugin. This PR provides the ability in the same manner like in the seneca main module.

Coverage decreased (-0.06%) to 79.922% when pulling c1b37fb8e966eedb8beaf6547bffff57bb59d2ee on indr:master into 3b00454268e1edb421c83dd4618f70251204db70 on senecajs:master.

This passes outside of 0.10 and 0.12 which are being dropped so I'm going to merge. Good work @indr


add high weight to login queue to prioritize login emails

Context
Card
As it is now, the login queue still don´t have top priority.
We need to add high weight or dedicate a worker exclusively to their jobs.
Changes proposed in this pull request
Add very hight weight to login queue
Guidance to review

 Prioritize processing of login emails in Sidekiq