feat(table): change paddings, new compactHorizontal prop

Изменение отступов у компонентов таблицы, добавление пропа для компактных горизонтальных отступов.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.78%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5801

Relevant Lines:
6525

💛  - Coveralls


Module parse failed: Unexpected token (107:38) for the graphql-language-service

Hi there,
Newbie here. This is the first time I run the react-app of the scaffold-eth using the yarn start command.
I'm facing the following error in Ubuntu Linux:
scaffold-eth/node_modules/graphql-language-service/esm/parser/onlineParser.js 107:38
Module parse failed: Unexpected token (107:38)
File was processed with these loaders:
 * ../../node_modules/react-scripts/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|
|     if (state.needsSeperator) {
>       expected = expected && expected?.separator;
|     }
|

May I know anyone facing the same error and any solution?
Please advise. Thank you.

Workaround to keep the ball rolling.
Replace the codes in node_modules/graphql-language-service with graphql-language-service.zip.

Not a lot of people use the subgraph feature of Scaffold-Eth. I am glad you found a quick workaround. Is this something you could submit a PR for?

The workaround is in the codes of the graphql-language-service package, PR is not applicable.

It is working fine with the latest code. Let me close the issue.


[FIX] fix errors on Codacy

Fix all errors present on Codacy

Analyse by Codacy stopped because get all checks controls of some framework PHP. And I need PHP natif only.
So, switch to Symfony Insight.
This issue will be closed.


Cosmetic map changes

same as sentimentMap

Since this is the same thing as sentimentMap, can you close the earlier PR. I'm heading out for today, but I'll look at it in the morning.


As an Assessor I want to see the number of notes and comments that have been made, so I don’t have to expand each of these sections to check if there have been any new ones added

[ADMIN APPLICATIONS] added admin and critical comments counter

Please assign trello card https://trello.com/c/hAXMlwdz/470-as-an-assessor-i-want-to-see-the-number-of-notes-and-comments-that-have-been-made-so-i-don-t-have-to-expand-each-of-these-sectio


Add more inputs for integration tests

In the coverage phase we use different Java vendors.
Therefore, we need to track the vendor if we want to use the build cache.

@melix Could you have another look?


CustomActor: rename "prefix" in panel to "typeName"

As I've just tried to write an extension based on this example, one of the gotchas that took a while to figure out was that the value for prefix set on line 122 in myPanel.js must match the value of typeName set on line 42 in myActor.js.
If these do not match, registering the actor fails:
Handler function DebuggerClient.requester request callback threw an exception: Error: Can't manage front without an actor ID

I suggest changing to work "prefix" to "typeName" to make it at least a bit clearer that these strings are related.

@janodvarko - thoughts?

(just god back from my vacation)
@hallvors: yes, this is nice improvement.
Honza


Error: access token failed to save to keychain

Hello!
Quick question, the first time I login it gets stuck at login screen printing this error:
Error: access token failed to save to keychain
traced it and here is the part of the code failing:
if !TokenManager.saveToken(accessToken, tokenIdentifier: accessTokenIdentifier, accessGroup: keychainAccessGroup) {
            print("Error: access token failed to save to keychain")
        }

however if I close the app and open again, works great.
Am I missing something?

Are you logging in by using the LoginManager or via the RideRequestViewController? Also, what version of iOS are you seeing this on? And is it in simulator or on device?
Saving the AccessToken should just work, so not sure what's going wrong

Hi jbrophy, thanks for the quick reply.
Just called requestBehavior.requestRide(rideParameters) similar to how it's called when the button class when it is tapped.
Real device, iOS 9.2.1

to be more specific
  func setObject(object: NSCoding, key: String) -> Bool {
       var keychainItemData = getKeychainItemData(key)

       let value = NSKeyedArchiver.archivedDataWithRootObject(object)
       keychainItemData[AttrAccessible] = kSecAttrAccessibleWhenUnlocked
       keychainItemData[ValueData] = value

       var result: OSStatus = SecItemAdd(keychainItemData, nil)

       if result == errSecDuplicateItem {
           result = SecItemUpdate(keychainItemData, [ValueData: value])
       }

       return result == errSecSuccess
   }

in the "KeychainWrapper" class is returning false :)

When you say requestBehavior is that a RideRequestViewRequestingBehavior? And you're using that on its own (not via the RideRequestButton?
Would you mind putting a breakpoint in setObject and letting me know what the actual error code is (the value of result at the end)

Yes exactly.
here you go
result = (OSStatus) -34018

this seems to not be a problem from your side:
http://stackoverflow.com/questions/29740952/osstatus-error-code-34018?rq=1

Ah okay, sorry I couldn't be of more help

Just in case someone else faces a similar issue. This is a bug (not related to the sdk) that only happens when running the app from xcode directly on the phone. That's why when I relaunched the app the 2nd time works fine.
Thanks for your help John.


The mv() function is placing files in a subdirectory

The mv() function is placing files in a subdirectory.
for example mv('_package.json', 'package.json'); is moving ./_package.json' to  ./package.json/_package.json rather than  ./package.json'
Heres a list of the files which were created for me
create index.js
create license
create readme.md
create test.js
create .editorconfig/editorconfig
create .gitattributes/gitattributes
create .gitignore/gitignore
create .travis.yml/travis.yml
create package.json/_package.json

I cannot reproduce. Just tried with latest yo and generator-nm:
   create package.json
   create index.js
   create license
   create readme.md
   create test.js
   create .editorconfig
   create .gitattributes
   create .gitignore
   create .travis.yml

Never experienced this bug.

I also used a fresh install of yo and generator-nm,  heres the full output
Tarrans-iMac:tarranjones tarran$ node -v
v5.12.0
Tarrans-iMac:tarranjones tarran$ npm -v
3.8.6
Tarrans-iMac:tarranjones tarran$ yo --version
1.8.5
Tarrans-iMac:tarranjones tarran$ npm list -g generator-nm
/Users/tarran/.nvm/versions/node/v5.12.0/lib
├──<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>
npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>Tarrans-iMac:tarranjones tarran$ mkdir generator-nm-test
Tarrans-iMac:tarranjones tarran$ cd  generator-nm-test
Tarrans-iMac:generator-nm-test tarran$ yo nm
? What do you want to name your module? generator-nm-test
? What is your module description? My lovely module
? What is your GitHub username? tarranjones
? What is the URL of your website? http://tarranjones.com
? Do you need a CLI? No
? Do you need code coverage? No
Initialized empty Git repository in /Users/tarran/github.com/tarranjones/generator-nm-test/.git/
   create index.js
   create license
   create readme.md
   create test.js
   create .editorconfig/editorconfig
   create .gitattributes/gitattributes
   create .gitignore/gitignore
   create .travis.yml/travis.yml
   create package.json/_package.json

I'm all done. Running npm install for you to install the required dependencies. If this fails, try running the command yourself.

npm WARN eisdir EISDIR: illegal operation on a directory, read
npm WARN generator-nm-test No description
npm WARN generator-nm-test No repository field.
npm WARN generator-nm-test No README data
npm WARN generator-nm-test No license field.

I started seeing something even crazier today. Seems related.
events.js:160
      throw er; // Unhandled 'error' event
      ^

TypeError: Path must be a string. Received [ '/Users/sholladay/Code/personal/gen-test/editorconfig',
  '/Users/sholladay/Code/personal/gen-test/editorconfig/**' ]
    at assertPath (path.js:7:11)
    at Object.dirname (path.js:1324:5)
    at Object.exports.getCommonPath (/Users/sholladay/Code/personal/generator-nm/node_modules/mem-fs-editor/lib/util.js:27:15)
    at Array.map (native)
    at Object.exports.getCommonPath (/Users/sholladay/Code/personal/generator-nm/node_modules/mem-fs-editor/lib/util.js:16:8)
    at EditionInterface.exports.copy (/Users/sholladay/Code/personal/generator-nm/node_modules/mem-fs-editor/lib/actions/copy.js:40:21)
    at EditionInterface.module.exports [as move] (/Users/sholladay/Code/personal/generator-nm/node_modules/mem-fs-editor/lib/actions/move.js:4:8)
    at mv (/Users/sholladay/Code/personal/generator-nm/app/index.js:98:13)
    at prompt.then.props (/Users/sholladay/Code/personal/generator-nm/app/index.js:110:4)

Node: 7.4.0
npm: 4.1.2
yo: 1.8.5
generator-nm: 3.2.0
yeoman-generator: 1.1.0
mem-fs-editor: 3.0.0
The timing is certainly suspicious with the release of yeoman-generator 1.1.0 which upgraded mem-fs-editor.
Anyone seeing related weirdness should post their npm ls yeoman-generator mem-fs-editor.

// @sboudrias

Got the same issue as @sholladay
❯ yo --version
1.8.5

❯ npm --version
4.1.2

❯ node --version
v7.4.0

@apertureless does pinning the version of yeoman-generator solve it for you? Change it from ^1.0.1 to 1.0.1 in package.json, followed by rm -rf node_modules && npm install.

I think I found the issue in mem-fs-editor and I published a fix. Let me know if the issue persists.
I was able to run generator-nm successfully after the fix, so give me more context if this still fails for you: Are you running on a new project? Over an existing project? Versions + OS? etc

@SBoudrias That fixed the crash for me, but now I am seeing the behavior that @tarranjones described. So I guess they were separate issues.
When the generator runs npm install, I see this:
npm WARN eisdir EISDIR: illegal operation on a directory, read
npm WARN foo No description
npm WARN foo No repository field.
npm WARN foo No README data
npm WARN foo No license field.

It happens because package.json actually gets generated as a directory, rather than a file. It contains the _package.json file. Same thing with the dotfiles. Notice the d directory bit in the permissions below.
Seth-Laptop:foo sholladay$ ls -lAh
total 40
drwxr-xr-x  3 sholladay  wheel   102B Jan 29 16:21 .editorconfig
drwxr-xr-x  9 sholladay  wheel   306B Jan 29 16:21 .git
drwxr-xr-x  3 sholladay  wheel   102B Jan 29 16:21 .gitattributes
drwxr-xr-x  3 sholladay  wheel   102B Jan 29 16:21 .gitignore
drwxr-xr-x  3 sholladay  wheel   102B Jan 29 16:21 .travis.yml
-rw-r--r--  1 sholladay  wheel   136B Jan 29 16:21 .yo-rc.json
-rw-r--r--  1 sholladay  wheel   231B Jan 29 16:21 index.js
-rw-r--r--  1 sholladay  wheel   1.1K Jan 29 16:21 license
drwxr-xr-x  2 sholladay  wheel    68B Jan 29 16:21 node_modules
drwxr-xr-x  3 sholladay  wheel   102B Jan 29 16:21 package.json
-rw-r--r--  1 sholladay  wheel   554B Jan 29 16:21 readme.md
-rw-r--r--  1 sholladay  wheel   219B Jan 29 16:21 test.js

A .yo-rc.json file appears in the destination directory and it is the only dotfile spared from becoming a directory.

Generation works.
But as @sholladay pointed out, package.json gets created as a folder
❯ ls package.json
_package.json

@sindresorhus, @SamVerschueren  I ran npm test on generator-nm
The test.beforeEach function generated the incorrect files for every test.
Initialized empty Git repository in /Users/tarran/github.com/tarranjones/generator-nm/temp/.git/
   create index.js
   create license
   create readme.md
   create test.js
   create .editorconfig/editorconfig
   create .gitattributes/gitattributes
   create .gitignore/gitignore
   create .travis.yml/travis.yml
   create package.json/_package.json

I'm all done. Just run npm install to install the required dependencies.

The only test which I expected to fail was test.serial('generates expected files', but that in fact passed.
Heres the output.
2 passed
5 failed

CLI option
Error: EISDIR: illegal operation on a directory, read
  node_modules/yeoman-assert/index.js:102:19
  Function.assert.fileContent (node_modules/yeoman-assert/index.js:98:9)
  Test.<anonymous> (test.js:52:9)

nyc option
Error: EISDIR: illegal operation on a directory, read
  node_modules/yeoman-assert/index.js:102:19
  Function.assert.fileContent (node_modules/yeoman-assert/index.js:98:9)
  Test.<anonymous> (test.js:70:9)

coveralls option
Error: EISDIR: illegal operation on a directory, read
  node_modules/yeoman-assert/index.js:102:19
  Function.assert.fileContent (node_modules/yeoman-assert/index.js:98:9)
  Test.<anonymous> (test.js:92:9)

prompts for description
Error: EISDIR: illegal operation on a directory, read
  node_modules/yeoman-assert/index.js:102:19
  Function.assert.fileContent (node_modules/yeoman-assert/index.js:98:9)
  Test.<anonymous> (test.js:120:9)

defaults to superb description
Error: EISDIR: illegal operation on a directory, read
  node_modules/yeoman-assert/index.js:102:19
  Function.assert.fileContent (node_modules/yeoman-assert/index.js:98:9)
  Test.<anonymous> (test.js:136:9)

Ive confirmed that generator-nm is sending the correct paths to this.fs.move and
mem-fs-editor's move,copy and commit methods all seem to be working fine.

I have the same problem, but I think it's related to yeoman generator this.fn.move, I created new yeoman generator and tried that function and It copies to subdirectories.

Release a new mem-fs-editor version that'll hopefully fix this issue. I've been having issue to properly reproduce this bug. I'm not 100% confident it is fixed, so let me know if it is still broken for you.

Woo! That did it for me @SBoudrias. 🎉
The fix is in<EMAIL_ADDRESS>It is a patch release, so a simple rm -rf node_modules && npm install inside of generator-nm should do the trick.
Seth-Laptop:generator-nm sholladay$ npm ls mem-fs-editor
<EMAIL_ADDRESS>/Users/sholladay/Code/personal/generator-nm
├─┬<EMAIL_ADDRESS>│ └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>

😃


gcc 13.0.1 with -O2 + -fno-strict-aliasing + aarch64 (arm64) build stucking.

I tried to run the tests with the simde v0.7.4-rc1 on Fedora rawhide (38)'s aarch64 (arm64) build environment. The gcc is 13.0.1 (RPM version: 13.0.1-0.2.fc38). Then the ninja -C build/gcc-O2 -v -j 8 is stucking on the build environment. As I was able to build and pass the tests with the gcc only with the -fno-strict-aliasing, I assume the -O2 flag triggered the stucking. I tried 2 times, and stucking the 2 times.
Here is the log.
+ bash -
=== 1.2. tests on gcc with O2 flag ===
+ BUILD_DIR=build/gcc-O2
+ CC='gcc -fno-strict-aliasing'
+ CXX='g++ -fno-strict-aliasing'
+ CFLAGS=-O2
+ CXXFLAGS=-O2
+ _setup
+ meson setup build/gcc-O2
The Meson build system
Version: 1.0.0
Source dir: /builddir/build/BUILD/simde-9609eb2cf687984277185813fdfe81b8b200377b
Build dir: /builddir/build/BUILD/simde-9609eb2cf687984277185813fdfe81b8b200377b/build/gcc-O2
Build type: native build
Project name: SIMDe
Project version: 0.7.4
C compiler for the host machine: gcc -fno-strict-aliasing (gcc 13.0.1 "gcc (GCC) 13.0.1 20230127 (Red Hat 13.0.1-0)")
C linker for the host machine: gcc -fno-strict-aliasing ld.bfd 2.39-9
C++ compiler for the host machine: g++ -fno-strict-aliasing (gcc 13.0.1 "g++ (GCC) 13.0.1 20230127 (Red Hat 13.0.1-0)")
C++ linker for the host machine: g++ -fno-strict-aliasing ld.bfd 2.39-9
Host machine cpu family: aarch64
Host machine cpu: aarch64
Library m found: YES
Compiler for C supports arguments -fopenmp-simd: YES
Compiler for C++ supports arguments -fopenmp-simd: YES
Compiler for C supports arguments -Wpsabi: YES
Compiler for C++ supports arguments -Wpsabi: YES
Library m found: YES
Build targets in project: 1534
NOTICE: Future-deprecated features used:
 * 0.64.0: {'copy arg in configure_file'}
Found ninja-1.11.1 at /usr/bin/ninja
+ _build
+ rm -f build.log
+ _time ninja -C build/gcc-O2 -v -j 8

@junaruga I've made a new pre-release. Can you retest using GCC 13? https://github.com/simd-everywhere/simde/releases/tag/v0.7.4-rc3

Sure. I plan to do it next week. Did you mean this issue should be fixed in GCC 13?

What do you think about adding the Fedora rawhide case to test a new GCC and Clang to this repository's CI?

Sure. I plan to do it next week. Did you mean this issue should be fixed in GCC 13?

I don't know of any GCC-13 specific fixes, no

What do you think about adding the Fedora rawhide case to test a new GCC and Clang to this repository's CI?

That would be welcome, yes!

All right.

That would be welcome, yes!

Okay. I will take a look to see if we can add the case.


Coverage Remapping Issue

Do you want to request a feature or report a bug?
Unsure Feature
What is the current behavior?

Coverage remapping that happens in  html lcov-report that gets generated is onto the actual file contents. Need to be able to remap it onto tranformed version of the actual file content.

This is my scenario

Relevant Preprocessor code
const babelOpts = Object.assign({}, babelConf, {
    plugins: (babelConf && babelConf.plugins) || [],
    presets: ((babelConf && babelConf.presets) || []).concat([jestPreset]),
    retainLines: true,
    sourceMaps: 'inline'
});

module.exports = {
    process(src, filename, config, transformOptions) {
        src = transformJustPhnx(src, true); //Conversion of abstraction syntax to React Code
        const finalOpts = Object.assign(
            {
                filename
            },
            babelOpts
        );
        if (transformOptions && transformOptions.instrument) {
            finalOpts.auxiliaryCommentBefore = ' istanbul ignore next ';
            // Copied from jest-runtime transform.js
            finalOpts.plugins = finalOpts.plugins.concat([
                [
                    babelIstanbulPlugin,
                    {
                        cwd: config.rootDir,
                        exclude: []
                    }
                ]
            ]);
        }

        const transformResult = babelTransform(src, finalOpts); //React code to final output with Sourcemaps.
        return transformResult ? transformResult.code : src;
    },
    canInstrument: true
};

Current output in lcov-report

Report that is achieved by superimposing it on the intermediate (Currently doing this when running SonarQube on the code)

What is the expected behavior?

Need to be able to remap it onto the intermediate output of my Jest Preprocessor transformations.

Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

Jest : 22.0.1
Ubuntu 17.10
Node 8.6.0
npm 5.6.0

After doing a little digging myself, found out where exactly to add this to get this to work.
This is where the source code gets read for the report.

I have tested adding my transformation of the source after that line. It works perfectly.

Now only question remains, is this a valid expectation to provide for sourcecode transformation? If so how do I go about adding a PR for this? Raising a thread on https://github.com/istanbuljs/istanbuljs too

I think being able to say "this is the source code I want instrumented" makes sense.
Are you saying that the fix to your problem must be in Istanbul? There's no change we can make?

I initially thought that the issue is with Jest, since I was seeing the same thing in error code frame.

The fix for the coverage report is in Istanbul, but the error code frame I need to investigate further.

If it gets added to Istanbul, then the transform for the source code will be an external config. That config for that needs to be allowed to be passed from jest.

We have #5121 for sourcemaps from transforms, I guess the Jest side can be folded into that?

My understanding of source maps are very basic. If you are saying the error code frame can be picked up from the source maps then yes, that's what I am asking for! 😄

We should. I'll close this as a dupe, but leave a note over there to test this use case whenever we get around to fixing it.
Thanks for the detailed issue and detective work!


refactor: generalize Bool.beq_eq_decide_eq

This PR generalizes Bool.beq_eq_decide_eq to also be applicable for types whose BEq α is different from the default instance implied by DecidableEq α. An example of such a type is Nat.

maintainer merge

bors r+ (this time I did apply the suggestion! :sweat_smile:)


Running the powershell module through an Azure AutomationAccount doesn't work

Using the Connect-Elements command through an Azure AutomationAccount gives me the following error-message:
The response content cannot be parsed because the Internet Explorer engine is not available, or Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again.          $Response = Invoke-WebRequest -Uri $RequestUri -Method 'POST' -Body $Body -ErrorAction Stop at Get-IdentityServiceToken<Process>, C:\Modules\User\Elements.Client\Api\ElementsCommon.ps1: line 50 at Connect-Elements<Process>, C:\Modules\User\Elements.Client\Public\ElementsConnectApi.ps1: line 23 at <ScriptBlock>, <No file>: line 117
Is it possible to have this reworked to use the '-UseBasicParsing' parameter of the native 'Invoke-WebRequest' command as suggested in the error-message?
Running this locally on my own computer works perfectly. However I need to be able to automate this through Azure

Hi @magnusjak,
Thanks for your feedback, we will publish a new version on 10/9/2023 to fix this issue of our Oct release. then you could import the latest version of this powershell module. If any questions, please feel free to let me know.
Regards,

Thanks for the quick reply, I will look forward to testing the new version :)

Hi @murray-zhao-avepoint,
I have just tested the new version through my Azure AutomationAccount and can verify that it works!
Thanks for the help 😃


DEV-431

Coverage increased (+0.2%) to 84.023% when pulling ad88b7a4d97ae9df062f5859b11687c7d237c7cc on DEV-431 into 6e883447a79a2bec488cb746a69493a66dbafc3d on master.


fix: tslint

OS
OS X 10.11.6 (El Capitan), but it is platform-independent

Versions.
From master after issue #1823 was committed

Repro steps.
If "no-shadowed-variable": true is added to tsconfig.json's rules.
Run npm run tslint

The log given by the failure.

addon/ng2/utilities/get-dependent-files.ts[50, 13]: Shadowed variable: 'node'
addon/ng2/utilities/get-dependent-files.ts[51, 11]: Shadowed variable: 'node'
packages/ast-tools/src/node.ts[24, 43]: Shadowed variable: 'node'
packages/ast-tools/src/route-utils.spec.ts[465, 13]: Shadowed variable: 'editedFile'
packages/ast-tools/src/route-utils.spec.ts[497, 13]: Shadowed variable: 'editedFile'

Mention any other details that might be useful.
IMHO, shadowed variables are an invitation for subtle bugs to come see us and remain invisible.

I vote for non-shadowed variable to be true rather than false.

This can be fixed by either disabling tslint, or by renaming
node         -> aNode
editedFile -> editedFile2 (occurence in line 465)
editedFile -> editedFile3 (occurence in line 497)

We talked about this internally when adding TS linting, and at the time decided that adding that rule wasn't really worth making the code less readable since we overall use a lot of function shorthand.


Add temp notes for Lesson 6

Just trying this out.

went in a different direction.
https://docs.google.com/document/d/1dOpJSSo2BqAdeQ_kci1L3oXluFrSa6bsMJ-LJeVfJX0/edit?usp=sharing


[Feedback] promote ONESDK_LOG="on"

Feedback
After superface execute when execute fails show in the CLI output hint to use ONESDK_LOG="on" for better debugging.
Or/And add this line to the created .env
ONESDK_LOG="off"  # Set to "on" to enable better output logging

So ONESDK_LOG is added to generated .env now I will probably try to look into superface execute fails. Or maybe we could add hint to each execute run. What do you think @julpat ?


JS_BASE_URL not working in docker

Describe the bug
The JS_BASE_URL is not working when configured in the environment of the docker container.
The webpage continues to try to load with the base URL of /
services:
  jellystat:
    image: cyfershepard/jellystat:latest
    container_name: jellystat
    restart: unless-stopped
    environment:
      <snip/>
      JS_BASE_URL: "/jellystat/"
      <snip/>

Environment Details (please complete the following information):

Docker
Jellystat Version: 1.1.0

To Reproduce
Deploy docker container with JS_BASE_URL set.
Open webpage.
Expected behavior
The page should be loading with the JS_BASE_URL prefix instead of /

I have the same issue I just can't get it to work via base url in docker


40s to receive a valid update from Performance Metrics

Hi,
I've been testing some funcionalities from EPOC+ using Emotiv Plugin for Unity 3D and the basic license.
In the sample scene provided by plugin, and as well in my test project, Cortex is taking 40s to receive a valid information about PM Metrics.
In my tests, "OnPMDataReceived" method in PMDataBuffer.cs file is called every 10s,  it's receiving valid values( by debugging), but when I request "DataStreamManager.Instance.GetPMData()" it returns -1. Only after 40s a valid data is received by this method.
Note:

this issue is happening in my project and in 'Cortex Unity Example'.
I've updated my EPOC+ firmware and Emotiv app today.

@HelenoSK , Cortex will return null value in the case detection is not active. The cause is your signal quality is not good.
we mentioned about it in the document
https://emotiv.gitbook.io/cortex-api/data-subscription/data-sample-object


What is the latest version it supports?

https://support.apple.com/en-us/HT211214
this is a link to apple website describing why 3.5.1 was released and what it fixes.  You will notice it only mentions fixing memory consumption impacted by an application to execute arbitrary code with kernel privileges.  They name Unc0ver specifically.
What this means is 13.5.1 was written solely to stop the unc0ver jailbreak.  If you have an older device, then you could possibly jailbreak using checkrain. They still don't offer windows support.  So I myself will not be exploring anything checkrain. You will have to find that information yourself.
good luck.

Ty

No problem.


Eta for PyTorch

What's the eta for release in PyTorch and/or FasterTransformer?
In PyTorch, what will the interface to use smoothquant look like? Will it be a wrapper around a linear layer or a custom linear layer?

Thank you for your attention! We have just released the real INT8 inference for PyTorch (https://github.com/mit-han-lab/smoothquant#smoothquant-int8-inference-for-pytorch). The FasterTransformer implementation will be released in around a week.
Since PyTorch does not support integer matrix multiplication on GPUs yet, we implement our customized INT8 Linear and BMM operators in torch-int with CUTLASS INT8 GEMM kernels. We replace the linear layers and bmm functions in the original Huggingface model with our INT8 operators to perform real INT8 inference (see opt.py).

A preview version of our FasterTransformer implementation has been released https://github.com/NVIDIA/FasterTransformer/blob/main/docs/gpt_guide.md#run-meta-opt.


task PublishPipelineArtifact ignoring .git

In a scenario, i need to copy complete workspace to other agent including .git file.
But task PublishPipelineArtifact ignoring .git file.

@abisekwins29 -- thank you for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please let us know which topic you’re referencing, or provide more context around the general task.

I am using below task, and while uploading it is somehow skipping .git
  - task: PublishPipelineArtifact@1
    displayName: Publish workspace
    inputs:
       path: '$(Build.SourcesDirectory)'
       artifact: workspace
    condition: always()

Thanks for your feedback. It looks like you're working through an issue with your scenario or implementation, rather than an issue with the documentation. Here are a couple of options you might consider:

Azure DevOps Support Bot
Azure DevOps on Stack Overflow


[migrations] Added migration file generated by django 2.0

This file not being present is breaking the Travis checks on django>=2.0. Probably generated on adding compatibility to django>=2.0

Coverage remained the same at 95.833% when pulling d6deadf0488d3f9b1f43c5e005a519ce1e2f242f on rohithasrk:missing-migration into 2f8f9493346cb4cf116cb787fcb89d8ce692336c on openwisp:master.

@nemesisdesign Can be merged maybe?

@rohithasrk ping

Replied inline @nemesisdesign


BUILD FAILED (macOS 11.5.1 using ruby-build 20211019)

rbenv install 3.0.2 or 3.0.0 fails on macOS 11.5.1 with below issues.
`Downloading openssl-1.1.1l.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/0b7a3e5e59c34827fe0c3a74b7ec8baef302b98fa80088d7f9153aa16fa76bd1
Installing openssl-1.1.1l...
BUILD FAILED (macOS 11.5.1 using ruby-build 20211019)
Inspect or clean up the working tree at /var/folders/5b/_n07b16j4t1104g4zn4j8rd40000gn/T/ruby-build.20211028162821.69642.evzpTP
Results logged to /var/folders/5b/_n07b16j4t1104g4zn4j8rd40000gn/T/ruby-build.20211028162821.69642.log
Last 10 log lines:
20 errors generated.
make[1]: *** [apps/opt.o] Error 1
make[1]: *** [apps/app_rand.o] Error 1
20 errors generated.
20 errors generated.
make[1]: *** [apps/s_cb.o] Error 1
make[1]: *** [apps/s_socket.o] Error 1
20 errors generated.
make[1]: *** [apps/apps.o] Error 1
make: *** [all] Error 2
`

FWIW, I also got this error while trying to install 2.6.7

getting the same error. What could be the issue? Any fix for this?

I don't want to assume anything...
but do you all utilize new macbooks with M1 chips?


Problem with the divider

Steps to reproduce
Does the flutter app affect the behavior of other apps?

I open the unity remote app (in the app the status bar and navigation bar are hidden)

2A) If I minimize the unity remote app and open the default flutter app from desktop, minimize and go back to unity, if I look at the divider it is hidden....
2B) If I minimize the unity remote app and open the default flutter app from the app list, minimize and go back to unity, if I look at the divider it doesn't hide!
I recorded a video, watch the behavior of the divider for unity app.
Is it a problem with unity app, flutter app or android os?
Expected results
unity app the divider should fade out
Actual results
unity app the divider doesn't fade
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]
https://github.com/flutter/flutter/assets/29661837/17001eee-c5da-4130-8a3b-4ef08ad78381

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on macOS 14.2.1 23C71 darwin-arm64, locale ru-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Once you provide a safe area to the scaffold

Once you provide a safe area to the scaffold

Once you provide a safe area to the scaffold

Divider problem with another app (which is open at the same time as the flutter app)
Does the flutter app affect the behavior of other apps?

Have you tried same thing with other apps instead of the flutter one?
If one app affects another, that would be an OS issue, IMO.
By the way, that line is not called divider, it is called Home Indicator.

Have you tried same thing with other apps instead of the flutter one?
If one app affects another, that would be an OS issue, IMO.
By the way, that line is not called divider, it is called Home Indicator.

I tested, other applications (not flutter) affect the currently open application.  If I open the application from the desktop everything is ok, if I open it from the list of applications the home indicator does not fade out. This is not a flutter problem

Cool. You can close the issue then.


Apply pkg-config patch

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This fixes the build failure in https://github.com/conda-forge/librsvg-feedstock/pull/69

Hmm, it seems like it might be better to fix whichever pkg-config file is adding the -lm on Windows, rather than patching it out in the g-i stage? Or is there some reason that's not feasible? I'd be curious to know what upstream has to say.
cf: https://gitlab.gnome.org/GNOME/gobject-introspection/-/merge_requests/265 (linked in the patch)

m.lib is already filtered out when the introspected library directly depends on it: https://github.com/GNOME/gobject-introspection/blob/10b1a869da09d260e54b6f28a0d2c0e3015deee4/giscanner/ccompiler.py#L223-L224 and https://github.com/GNOME/gobject-introspection/blob/10b1a869da09d260e54b6f28a0d2c0e3015deee4/giscanner/ccompiler.py#L247-L248

@tschoonj Ah, that's pretty compelling.

@pkgw I have to confess I don't understand the changes but if you are OK I'm also +1. Merge?

@ocefpaf Here's my attempt at a recap: it seems that on Windows, some projects publish pkg-config files that include a -lm dependency, but there's no such library on Windows. Now I'm kind of tempted to say that those pkg-config files should be fixed ... but gobject-introspection already has some hacks to filter out these deps when it does its introspection magic. It seems that librsvg is triggering a corner case where another filter needs to be added.


Add Github Action Badge

Let's show the world that I can use Github actions!

[![Actions Status](https://github.com/{owner}/{repo}/workflows/{workflow_name}/badge.svg)](https://github.com/{owner}/{repo}/actions)
Or like from Here

https://github.com/{github_id}/{repository}/workflows/{workflow_name}/badge.svg Says Stackoverflow

https://gist.github.com/lukas-h/2a5d00690736b4c3a7ba
A Licence Badge would also be nice while I'm on it


Should we move to Bootstrap v4?

Bootstrap 4 is out of alpha now...
I don't want rjsf to have to support too much. Ideally we could support either one or zero HTML/CSS frameworks "by default", and the other ones could be added by users in other packages or something. But I think the fact that Bootstrap v3 is now deprecated means the one we support "by default" shouldn't be that. On the other hand, moving unilaterally to a new Bootstrap might be a breaking change for our users. Or maybe it wouldn't be so bad, because it's just a version bump on a dependency in package.json. Thoughts?

I've spent the last two days creating Bootstrap 4 widgets by overriding BaseInput, CheckboxWidget, CheckboxesWidget, etc. via a CustomFieldTemplate. It seems to work well this way, and I've been able to make it fully compatible with BS4 syntax so far.
This has been a breeze to setup. My only concern is maintaining separate widgets for each framework, but I was thinking of making a plugin repo and maintaining the BS4 widgets there. Any thoughts?
This is essentially how I'm doing it:
import BaseInput from './widgets/BaseInput'
import CheckboxWidget from './widgets/CheckboxWidget'
import CheckboxesWidget from './widgets/CheckboxesWidget'

const widgets = {
	BaseInput,
	CheckboxWidget,
	CheckboxesWidget,
}

const FormWrapper = function(props) {
	const idPrefix = snakeCase(props.schema.title)

	const newProps = {
		...props,
		...{
			noHtml5Validate: true,
			showErrorList: false,
			transformErrors,
			FieldTemplate,
			widgets,
			idPrefix,
		},
	}

	return <Form {...newProps} />
}
FormWrapper.propTypes = {
	schema: PropTypes.object.isRequired,
}

I then export my FormWrapper and use that instead of Form from this package.
I've created custom ErrorList, Label, Help, FieldTemplate components, as well as one for each widget. Overriding the default widget association is easy with the widgets prop (kudos!).

This is the approach I'd like to see (refs #623, #555), but I'm not sure that what we currently have is sufficient to actually support this. Previous users who have requested this sort of feature have never explained exactly what's missing, but in particular, I think ArrayField might turn out to be tricky. If you could demonstrate that your bs4 library supported 100% of the functionality that rjsf wants to support, I would be quite excited about it! If not, please feel free to open issues/PRs to add whatever's needed.

Also refs #832.

Hey @glasserc,
I see what you mean about ArrayField. I could continue to override the fields like the widgets, but I'm concerned that too much logic is ending up in what should just be a theme.
I think a better solution would be to allow themes to add classes and markup to the existing fields/widgets, without duplicating logic into the theme.
We could use an extensive dictionary to provide markup and classes to the components:
const bootstrapTheme = {
  widgets: {
    BaseInput: {
      className: 'form-control'
    },
  }
}

A simple example for <input>:
// /src/components/widgets/BaseInput.js
function BaseInput(props) {
  // ...
  return (
    <input
      className={theme.widgets.BaseInput.className}  // I imagine this could be passed by FieldTemplate
  // ..
}

Classes aren't enough, and we need to be able to control surrounding markup, maybe a wrapper component:
const checkboxWrapper = props =>
{props.children}

const bootstrapTheme = {
  widgets: {
    CheckboxWidget: {
      wrapper: CheckboxWrapper,
      className: 'form-check-input'
    },
  }
}

// /src/components/widgets/CheckboxWidget.js
function CheckboxWidget(props) {
  // ...
    return (
      <Wrapper>
        <input
	  className={className} // FieldTemplate can help pass these down
          // ...
	/>
      </Wrapper>
    )
}

This approach would be framework-agnostic. What do you think?

I agree with @ugogo that this library should split from specific UI library. We do not wanna import bootstrap js/css to our app if we are building a material-ui app.

I think, yes :smile:
I'd love to use this piece of software in a running project, but I'm on BS4. Do you have any suggestions how it's possible to run the current version and improve it to work with BS4 until the BS4 supported version is public?
Does somebody know which components are still compatible in BS4?

I'm using a rewritten version of this great lib.
Basically I've just separated form, UI and fields from this lib. In an advanced mode it works like this:
(it's not public)
/**
 * Form container, newly required props: fields, templates and widgets
 */
import AdvancedForm from '@react-schema-form/form'; //
/**
 * All fields without templates
 * Templates are moved to `templates` in a themed package like @react-schema-form/bootstrap-4
 */
import fields from '@react-schema-form/fields';
/**
 * Templates and widgets with Bootstrap 4 UI
 */
import { templates, widgets } from '@react-schema-form/bootstrap-4';

...

/**
 * Templates are store in a registry. Registry doesn't load any default fields and widgets.
 */
<AdvancedForm fields={fields} templates={templates} widgets={widgets} {...otherProps} />

All UI elements are updated to Bootstrap 4.
And on top of that I've created some small packages with prewired components so you can use it like this:
import Form from '@react-schema-form/form-bootstrap-4';
...
/**
 * It has prewired fields, templates and widgets.
 */
<Form fields={{ MyField }} widgets={{ MyWidget }} schema={schema} uiSchema={uiSchema} {...} />

It works great and all tests passed. 👍 (btw I rewrote all your tests to Jest + react-testing-library -> great experience, better performance and no need for Enzyme and Sinon).

@MatejMazur great work, I am excited to try out your changes. Do you have the repo with your changes available on GitHub? I see a forked repo on your profile, is that it? You should be able to open a pull request from that.

@eberkund I'm working on it.

Ok, so here is a working repo: https://github.com/React-Schema-Form/react-schema-form (it's still in development - the progress is described at the top of the readme).
I moved into the new one because it's not react-jsonschema-form and the library structure is based on a npm scope  @react-schema-form (I removed 'json' because it was too long). Later I want to build Redux version so for better management I use github org https://github.com/React-Schema-Form for the whole library.

Looks good, I am having a little trouble getting webpack to resolve the scoped packages but I will look into it more later today hopefully.

@MatejMazur in regard to "some special space for extensions, website, etc" is the intention still to merge your changes back into the main library? I think forking it off into another library when this one already has many users would fragment resources.

You're probably right. I'll wait for a response of main contributors.

Since v3 has a (moderate) vulnerability, we should move to v4.

I'm surprised this project doesn't have bootstrap 4 support yet, it looks a little worrying for anyone looking for a healthy project to build upon.
Can the linked changes not just be put on a new major version branch where people can worry less about trivialities liked renamed variables and just see if it works? I don't see the concern over breaking changes, just give it a new major version.

I guess it's more a question of opening a PR indeed!
Would you be interested in looking at it @richmidwinter ?

@MatejMazur what's the state of the work you did to migrate to v4?

So what is the status of this? Is there a plan to merge in @MatejMazur or would it be better to use @abecks?

thanks for the effort @peterkelly  -  how hard is to update it to the latest react-jsonchema-form ? seems january was a very active month and your fork is behind.

Yes, having a ui framework agnostic solution would be great. There was some stalled progress at #1013). If someone has an implementation of just the withTheme function, that would be a great feature that would solve the bootstrap 4 problem and I'd be willing to add to the library.

BS4 upgrade would be wonderful. +1

https://github.com/mozilla-services/react-jsonschema-form/issues/899#issuecomment-451849732
Give this man a cookie 🍪

thanks for the effort @peterkelly - how hard is to update it to the latest react-jsonchema-form ? seems january was a very active month and your fork is behind.

I've just published an update; it's now on v1.3.0

same as @PhilipK2 : latest bootsrap has dropped glyphicon icon font. so the buttons for arrays are not being displayed properly.
https://getbootstrap.com/docs/4.3/migration/#components

managed to make it work by importing some extra css as per answer here: https://stackoverflow.com/questions/32612690/bootstrap-4-glyphicons-migration
Also realised that the bootstrap 4 changed classes from array-item-list to list-group and array-item to list-group-item. So same stuff really, any chance to update that?

Closing this, let's move the discussion to https://github.com/mozilla-services/react-jsonschema-form/issues/1222


Update minor version

Purpose

To-do

Content

[ ] I have read and checked the items on the review checklist.

bors r+


Slack channel is now configurable in organizations.json

Now you can pass the slackChannel in organizations.json..
If either slackChannel or slackToken is missing, no message will be send at all.
See README.md
Closes #41, #42

/rebase

@bartgolsteijn LGTM

@JeroenKnoops seems your commits are not signed.

@JeroenKnoops seems your commits are not signed.

Fixed this. I've switched to my old computer and did not yet configured krypt.on


for the appendix of paper

Hi, I can't find the appendix of your paper. Could you help me find it?

It starts on page 10 in the arxiv: https://arxiv.org/abs/1801.03924

Thank you very much!
------------------ 原始邮件 ------------------
发件人: "Richard<EMAIL_ADDRESS>发送时间: 2019年8月26日(星期一) 中午11:29
收件人<EMAIL_ADDRESS>抄送: "肖晓彤"810011624<EMAIL_ADDRESS>主题: Re: [richzhang/PerceptualSimilarity] for the appendix of paper (#32)
It starts on page 10 in the arxiv: https://arxiv.org/abs/1801.03924
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


dataset file and pre-training file

The dataset file and pre-training file could not be downloaded, perhaps the link name is incorrect. Can you give a link to download it

Same error as the above！

@xyanfei did you find a solution?


Add CONTRIBUTING documentation

I had to dig a bit to figure out how to get the environment running locally.
I think this is roughly what it needs:
npm install
npm test

Thanks @lencioni!


added centerline to track plot, json export and lyt export

Good effort on this pull request :heart:. However, there are a few points that need to be addressed:

JSON Export Compatibility: To ensure backwards compatibility, the cone keys should remain unchanged. You can add the new centerline points as two new keys, "centerline_x" and "centerline_y", at the top level of the JSON object.

LYT Export Relevance: The centerline concept is not applicable to the LYT export. LYT files are used by Live for Speed, which does not incorporate the concept of a centerline. Although theoretically possible to encode them as control waypoints, this falls outside the scope of our project.


MAX_CONN_PER_SNN assertion error

In a customized network, I saw that the SNN cannot run when we have more that 256 synapses totally in M groups. BTW, I am using "nocuda" version. I changed the assertion error in my computer to: `++numConnections_ <= MAX_CONN_PER_SNN +1000 ' to fix the error for now and continue running the SNN. Is there any way to change the value of this variable (MAX_CONN_PER_SNN) and also its type? Its type is short-int which is not enough to cover my large networks (syn>32765).

Just to clarify, an SNN with two groups of N>256 neurons connecting by pre-defined connections is fine. My case happens when we have about 50 groups of neurons (each 1 neuron) connecting to each other based on some specific criteria.


VSCode got set to default on its own.

Type: Bug
I don't know what happened, but after 2.5 years of using my Macbook with M1. All the configurations of my VSCode have been set to default on its own, without any input from my side, and also the entensions don't seem to be working at all. What is the fix?
VS Code version: Code - OSS Dev 1.78.0-dev (Commit unknown, Date unknown)
OS version: Darwin arm64 22.5.0
Modes:

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 2, 3

Memory (System)
8.00GB (0.22GB free)

Process Argv
--crash-reporter-id ed96adf9-11c4-47a9-922d-3d0dd57fc00d

Screen Reader
no

VM
0%

Extensions: none

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

same issue

issue got resolved on its own by reinstalling the IDE.

May I know how did you install VS Code because the version does not seem to be the one that we ship - Code - OSS Dev 1.78.0-dev

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Implement fromOption support

it would be nice to have methods for Option
def fromOption[T](opt: Option[T]) : F[Nothing, T]
def fromOptionWith[E](opt: Option[T])(exception: E) : F[E, T]

@kaishh

@ratoshniuk fromOption is included in current version (0.6.33) https://github.com/pshirshov/izumi-r2/blob/develop/fundamentals/fundamentals-bio/src/main/scala/com/github/pshirshov/izumi/functional/bio/BIOInvariant.scala#L57


Add a mechanism to choose zone color

This can be simple variables that can be set in the script itself

python version. Automatically chooses zone as well as all other data variables using  real time data.
https://github.com/anoop142/ieee-covid-poster-generator

Open a pr with the python script. People in windows without bash can use it

The district images have to be renamed for the Python script to work , it's not an  implementation of "makeposter.sh"  in python, it's more than that , it requires no input from users.(no need to set variables at all)

I didn't read the code entirely but how does it generate poster with new information everyday if there is no input?

script parses json data from https://github.com/c19k/website-data, and extract the required variables for the poster,and calls imagemagick to make the poster like makeposter.sh does  . Without any argument it will generate poster for the current date, optionally you can pass a specific date .

Everything is specified in the README though

That's cool! You might also wanna add the newer changes the designers have added to the poster to the script (color of district based on number of active cases, cases from returnees and by contact and so on)

if you are referring to the district colour based on zone, yes the script does that , well  my repo is updated with yours , idk if there is another repo for the poster design . The design is kinda flawed, we could just write the name of  of district only that have cases > 0 instead of just displaying "0" , and the  image quality is low .

Athalla, they have updated the poster since we started writing the script. Now there are 4 colors for the districts and all, including blue.


Add SampleCommand

New command sample allows users to have some sample data to experiment with.
Closes #98

looks fine


Fix Input and Output deadlock when buffer is full during startup

Output threads need calling after_start to run but
after_start is sometimes not called when Input#start is blocked.
This happens when in_tail with read_from_head true and
output with overflow_action block.
This fixes the problem by checking after_start immediately after start.
This may be related with #1485

@tagomoris Do you see any concern for this patch?

@repeatedly this change breaks many tests (makes tests unstable at least). read this commit comment: https://github.com/fluent/fluentd/commit/bd5841e930dfca8f73181d77d00ad8a2de98f6c6
IMO it's wrong to emit events in TailInput#start. It should be done in another threads executed from #start thread.

this change breaks many tests (makes tests unstable at least).

Which point? input or filter start assumes Output#after_start is not called?

IMO it's wrong to emit events in TailInput#start. It should be done in another threads executed from #start thread.

Yes but current plugin API, it is hard, right?
How to know other threads are running inside input plugin?

About the order of #start and #after_start, I made wrong comment. As you mentioned, there are no barrier to call #after_start immediately after calling #start per plugins.
But it depends the order of RootAgent#lifecycle(desc: true) why this patch solves #1485. So the comment in root_agent.rb should mention that desc: true means the order from Output, Filter, Output with event_emitter and Input.
About the threading, there are some options to do it - running long-running process in #start is bad practice anyway.

adding immediate: (default false) option to PluginHelper::Timer#timer_create to invoke callback immediately in timer thread (by creating TimerWatcher with 0 interval and repeat: false)
using thread_create to run refresh_watchers in TailInput#start

The first option is more general solution. ChildProcess#child_process_execute method also has immediate: optional argument besides interval: argument, so having same option in timer_create looks consistent solution. (in that case, child_process_execute(immediate: true) can be re-implemented on timer_create(immediate: true)).
The second option is to call thread_create and call refresh_watchers by TailInput itself. It may call #refresh_watchers in parallel from the thread created and timer threads without any control, so it requires mutex to prohibit it.

adding immediate: (default false) option to PluginHelper::Timer#timer_create to invoke callback immediately in timer thread (by creating TimerWatcher with 0 interval and repeat: false)

It seems good. I will implement this feature for in_tail like case in other patch.
in_tail specific fix is not good for plugin authors. So 2 approach is less merit.

Update comment of RootAgent#start

Ah, please open an issue to add the immediate option to #timer_create before closing this pull-request.


readme.md in bitbucket repo not showing in hub.docker

Hi,
I have linked up my bitbucket repo with my hub.docker repo (magnetmessaging/mmx-standalone-dist-docker) for autobuild. The autobuild works great; however, the readme (/readme.md) is not showing. I suppose it should be shown automatically in the "Information" tab. Would you please let me know why?
Thank you.
skwok

Hi,
The Github issues are for problems with docker itself, not hub. For hub
problems please email<EMAIL_ADDRESS>On Mon, Feb 16, 2015 at 2:29 PM, skwokmag<EMAIL_ADDRESS>wrote:

Hi,
I have linked up my bitbucket repo with my hub.docker repo
(magnetmessaging/mmx-standalone-dist-docker) for autobuild. The autobuild
works great; however, the readme is not showing. I suppose it should be
shown automatically in the "Information" tab.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/10840.

Thanks.


Enforce that there no extra properties in request JSON, and that non-null properties are [Required]

Closes #2314.
Make all request types inherit from BaseRequest which has an ExtensionData property, and ensure that it is empty in ParseRequest.

We should be sure to let this change bake a little longer than usual because it has the potential to expose a lot of small serialization bugs we missed.

Found an issue already in check-pr.

Found during testing that the CLI does send null for some no-longer supported properties, so I’ve updated the PR to allow extraneous properties to be set iff they are null.

Passed check-pr with full set of changes.


Updated nginx role

This PR depends on #27.  That pr should be merged before reviewing/merging this one.
This PR updates our nginx-single-host role to both take advantage of our cloudflare-certbot role and to improve our standard nginx config for the planetary-server single host pattern(e.g. what we use for planetary.name).  This role is expanded in a README included in this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Zach Mandeville seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Re-adding the to-bytes conversion function

For blob output, but you don't want to do this conversion for every blob (hence why not adding it in the to-clj function above). Some of those will be other datatypes kept in Cassandra as Blob types, so the user should be allowed to change them later.

Sorry it's taken so long for me to notice. Thank you!


Start new conversation button's tooltip not updating in DM narrow when direct messages are disabled.

When an organization disables direct messages, the "Start new conversation" button's tooltip no longer updates when a user navigates to the direct messages; instead it retains whatever tooltip was present on it from the previous view/narrow.

We want the tooltip to show "New direct message (x)" as expected.

[!NOTE]
A user can always DM themselves or a bot, even when direct messages are disabled in an org — the reason why we don't disable the "Start new conversation" button. (#28412)

CZO discussion
Steps to reproduces:
Considering direct messages are disabled for the org (Settings  > Organization permissions > Other permissions)

Go to a stream, #design for example and hover over the "Start new conversation" button — it shows "New topic (c)"
Go to direct message, hover of the "Start new conversation" button — it still shows "New topic (c)", whereas we expect it to show "New direct message (x)"

@sayamsamal I've opened a PR for this issue. Please review it when you get the chance.


Improve finalization on missing secret ref (#2910)

Adding more tests

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>
Try to fetch missing secret 5times

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>
Adding counter to the test reconciler obj

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>
adding the requeue err

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>
Remove else

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Roll Flutter Engine from 195009b91abd to fade29457465 (1 revision)

https://github.com/flutter/engine/compare/195009b91abd...fade29457465
2023-05-25<EMAIL_ADDRESS>[Impeller] Add generic path for mask blurring (flutter/engine#42308)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add support for Windows named pipes

Since Unix domain sockets are available in async-std, I think it is also in scope to add support for Windows named pipes.
There already exists a crate on top on mio (just like mio-uds) that we should be able to use: https://docs.rs/mio-named-pipes/0.1.6/x86_64-pc-windows-msvc/mio_named_pipes/

Is there an update on this? The tokio implementation of named pipes (based on mio-named-pipes) is dead simple (~100 LOC).

Having names pipes support would be quite nice; but I think to prevent too much churn happening here I'd like to see us make progress towards https://github.com/async-rs/async-std/issues/293 first.

Having names pipes support would be quite nice; but I think to prevent too much churn happening here I'd like to see us make progress towards https://github.com/async-rs/async-std/issues/293 first.

It's been 4 years since this was posted, and 3 years since #293 was marked completed.
Has there been any action on this? I've got something that needs named pipes that we're trying to support on both tokio and async-std.


Updates to Command Docs

Issue
#

:beetle: Bug Fix
No

:trophy: Feature
No

:pencil: Refactor
No

:open_book: Documentation
Yes

:warning: Break Change
No

Description

[ ] updated short and long descriptions for Commands, as well as formatting of flags (where appropriate)
[ ] made consistent use of the ... notation (i.e. [service...] and [option...]) to show acceptance of multiple arguments
[ ] made the long description for completion.go match the recently updated description used in the Autocompletion section of the Installation doc page

Notes

@dbpolito - FYI - I did not include an update for the Laravel preset doc page in this PR because I want to think a little more about the Presets. A straight copy/paste would create duplicate content (as determined by search engines), which we want to avoid. This is usually handled by adding a canonical tag in the <head> section, but I don't think we have that ability here. Is that true?

Well not at the moment, we can bring the idea of meta to introduce support like other CMS or maybe it's a indication we need to  move to a more robust tool like hugo or gitbook

Not sure changing to command is better... At exec we have service and command, which was the args a mentioned, which is forwarded to the container.
Now on run, we have a script under scripts key, so following the standard would be [script] [command], where command is optional and only relevant for single line scripts.

I misunderstood your comment, and made a hasty update. I’ll revert.

On Mar 8, 2021, at 4:07 PM, Daniel Polito<EMAIL_ADDRESS>wrote:

Not sure changing to command is better... At exec we have service and command, which was the args a mentioned, which is forwarded to the container.
Now on run, we have a script under scripts key, so following the standard would be [script] [command], where command is optional and only relevant for single line scripts.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


MSBuild does not locate targets for MonoGame

Environment data
dotnet --info output:
ambs@diabelli CourseCSharp $ dotnet --info
.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     linuxmint
 OS Version:  18.1
 OS Platform: Linux
 RID:         ubuntu.16.04-x64
 Base Path:   /usr/share/dotnet/sdk/1.0.1

VS Code version:
$ code --version
1.11.2
6eaebe3b9c70406d67c97779468c324a7a95db0e
C# Extension version: 1.8.1
Steps to reproduce
I open code with a standard C# hello world project, write 'Console.' and no completion  is shown.
Expected  behavior
Expected the list of available methods from the System.Console class
Actual behavior
none.

Hi! Could you provide your OmniSharp Log after opening this project? To display the log, select View->Output to display the Output pane and select "OmniSharp Log" from the drop-down in the top-right corner of the pane.

Additionally, if you are using a different shell other than bash, could you let us know which one?

Just give me a couple hours to end $job, and I will give more details. Thanks!

Yes, I am using Bash.
I was trying to use code in two different ways:

opening directly some .cs files that I have and compile manually
opening a .csproj file

I do that, in both situations, from the command line: code file.cs / code file.csproj
In both situations, the output pane, has a dropdown with only two options, Tasks and Extensions, and both show an empty page.
Also, and this might be relevant, when doing 'code file.csproj' code opens the XML file and displays it :-O
Thanks

Would you be willing to provide the project you're using?
Note that we don't provide completion for loose .cs files outside of project.

OK for the loose .cs file. I was not sure, and therefore just mentioned it so you could clarify.
Not sure if you need the .csfile only, or everything, so I just uploaded my workdir here: http://eremita.di.uminho.pt/~ambs/TugEngine.tar.gz (it is a monogame project that compiles perfectly well with 'xbuild').
Thank you

OK. I've updated the title based on what I see on my Mac. I opened your solution and a .cs file. Then, I selected View-Output to display the VS Code Output pane and picked "OmniSharp Log" from the upper-right corner of the Output pane. In here, I see an exception like this:
Microsoft.Build.Exceptions.InvalidProjectFileException: The imported project "/Users/dustincampbell/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/msbuild/MonoGame/v3.0/MonoGame.Content.Builder.targets" was not found. Also, tried to find "MonoGame/v3.0/MonoGame.Content.Builder.targets" in the fallback search path(s) for $(MSBuildExtensionsPath) - "/Library/Frameworks/Mono.framework/External/xbuild/" . These search paths are defined in "/Users/dustincampbell/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/OmniSharp.exe.config". Confirm that the path in the <Import> declaration is correct, and that the file exists on disk in one of the search paths.  /Users/dustincampbell/Downloads/TugEngine/TugEngine/TugEngine.csproj
  at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject (System.String errorSubCategoryResourceName, Microsoft.Build.Shared.IElementLocation elementLocation, System.String resourceName, System.Object[] args) [0x00067] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject (Microsoft.Build.Shared.IElementLocation elementLocation, System.String resourceName, System.Object[] args) [0x00001] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].ThrowForImportedProjectWithSearchPathsNotFound (Microsoft.Build.Evaluation.ProjectImportPathMatch searchPathMatch, Microsoft.Build.Construction.ProjectImportElement importElement) [0x000ae] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].ExpandAndLoadImports (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement) [0x0027f] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].EvaluateImportElement (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement) [0x00001] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].PerformDepthFirstPass (Microsoft.Build.Construction.ProjectRootElement currentProjectOrImport) [0x0036c] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].Evaluate () [0x00055] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].Evaluate (Microsoft.Build.Evaluation.IEvaluatorData`4[P,I,M,D] data, Microsoft.Build.Construction.ProjectRootElement root, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings, System.Int32 maxNodeCount, Microsoft.Build.Collections.PropertyDictionary`1[T] environmentProperties, Microsoft.Build.BackEnd.Logging.ILoggingService loggingService, Microsoft.Build.Evaluation.IItemFactory`2[S,T] itemFactory, Microsoft.Build.Evaluation.IToolsetProvider toolsetProvider, Microsoft.Build.Evaluation.ProjectRootElementCache projectRootElementCache, Microsoft.Build.Framework.BuildEventContext buildEventContext, Microsoft.Build.Execution.ProjectInstance projectInstanceIfAnyForDebuggerOnly) [0x0001a] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Project.Reevaluate (Microsoft.Build.BackEnd.Logging.ILoggingService loggingServiceForEvaluation, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings) [0x0003c] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary (Microsoft.Build.BackEnd.Logging.ILoggingService loggingServiceForEvaluation, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings) [0x00025] in <6a1392588f4a45bdbe07807130f9b3d0>:0

Do you see something similar?

Out of curiosity, did this work for you in the past? Or, are you new to VS Code?

Scratch my comment about the exception. Once I installed MonoGame 3.6 on OSX, I see the project load properly and have IntelliSense working.

It never worked. I am new using Code (just migrated from Mac - Xamarin to Linux).
So, probably something failed during the installation of the plugin?
Thanks!

FWIW, I'm trying Ubuntu 16.04 now.

Hehehe, I imagine it works, as nobody else has complained. But I can't manage to get anything of it.

We'll see. I'm also using the latest beta of C# for VS Code

Is there a way to install the beta from code, directly?

No. You can use the instructions from here: https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-Beta-Releases.

I had to apt-get install gtk-sharp3 and MonoGame. After doing that, I can build your project with xbuild. However, I get the same error that I listed above. Do you see the same?

I do not see any error at all :-(

After opening the TugEngine folder and a .cs folder, you don't have an OmniSharp Log in View->Output?

ok, now I have some feedback
Starting OmniSharp server at 4/18/2017, 6:05:13 PM
    Target: /home/ambs/MyReps/TugEngine/TugEngine

OmniSharp server started wth Mono
    Path: /home/ambs/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/run
    PID: 20674

OmniSharp: -s /home/ambs/MyReps/TugEngine/TugEngine --hostPID 20516 --stdio DotNet:enablePackageRestore=false --encoding utf-8 --loglevel information formattingOptions:useTabs=false formattingOptions:tabSize=4 formattingOptions:indentationSize=4
{"Event":"log","Body":{"LogLevel":"INFORMATION","Name":"OmniSharp.Startup","Message":"Omnisharp server running using Stdio at location '/home/ambs/MyReps/TugEngine/TugEngine' on host 20516."},"Seq":1,"Type":"event"}
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Initializing in /home/ambs/MyReps/TugEngine/TugEngine
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Auto package restore: False
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Update workspace context
[info]: OmniSharp.DotNet.DotNetProjectSystem
        Resolving projects references
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        MSBUILD_EXE_PATH environment variable set to /home/ambs/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/msbuild/MSBuild.dll
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        MSBuildExtensionsPath environment variable set to /home/ambs/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/msbuild
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        MSBuildSDKsPath environment variable set to /home/ambs/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/msbuild/Sdks
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        MSBuild will use local OmniSharp installation.
[info]: OmniSharp.MSBuild.MSBuildProjectSystem
        No solution files found in '/home/ambs/MyReps/TugEngine/TugEngine'
[warn]: OmniSharp.MSBuild.MSBuildProjectSystem
        Failed to process project file '/home/ambs/MyReps/TugEngine/TugEngine/TugEngine.csproj'.
/home/ambs/MyReps/TugEngine/TugEngine/TugEngine.csproj(1,1)
Microsoft.Build.Exceptions.InvalidProjectFileException: The imported project "/home/ambs/.vscode/extensions/ms-vscode.csharp-1.9.0-beta3/bin/omnisharp/msbuild/MonoGame/v3.0/MonoGame.Content.Builder.targets" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.  /home/ambs/MyReps/TugEngine/TugEngine/TugEngine.csproj
  at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject (System.String errorSubCategoryResourceName, Microsoft.Build.Shared.IElementLocation elementLocation, System.String resourceName, System.Object[] args) [0x00067] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Shared.ProjectErrorUtilities.VerifyThrowInvalidProject (System.Boolean condition, System.String errorSubCategoryResourceName, Microsoft.Build.Shared.IElementLocation elementLocation, System.String resourceName, System.Object arg0) [0x0000a] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject (Microsoft.Build.Shared.IElementLocation elementLocation, System.String resourceName, System.Object arg0) [0x00001] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].ExpandAndLoadImportsFromUnescapedImportExpression (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement, System.String unescapedExpression, System.Boolean throwOnFileNotExistsError, System.Collections.Generic.List`1[Microsoft.Build.Construction.ProjectRootElement]& imports) [0x0041e] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].ExpandAndLoadImportsFromUnescapedImportExpressionConditioned (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement, System.String unescapedExpression, System.Collections.Generic.List`1[Microsoft.Build.Construction.ProjectRootElement]& projects, System.Boolean throwOnFileNotExistsError) [0x0005b] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].ExpandAndLoadImports (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement) [0x00033] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].EvaluateImportElement (System.String directoryOfImportingFile, Microsoft.Build.Construction.ProjectImportElement importElement) [0x00001] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].PerformDepthFirstPass (Microsoft.Build.Construction.ProjectRootElement currentProjectOrImport) [0x0036c] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].Evaluate () [0x00055] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Evaluator`4[P,I,M,D].Evaluate (Microsoft.Build.Evaluation.IEvaluatorData`4[P,I,M,D] data, Microsoft.Build.Construction.ProjectRootElement root, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings, System.Int32 maxNodeCount, Microsoft.Build.Collections.PropertyDictionary`1[T] environmentProperties, Microsoft.Build.BackEnd.Logging.ILoggingService loggingService, Microsoft.Build.Evaluation.IItemFactory`2[S,T] itemFactory, Microsoft.Build.Evaluation.IToolsetProvider toolsetProvider, Microsoft.Build.Evaluation.ProjectRootElementCache projectRootElementCache, Microsoft.Build.Framework.BuildEventContext buildEventContext, Microsoft.Build.Execution.ProjectInstance projectInstanceIfAnyForDebuggerOnly) [0x0001a] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Project.Reevaluate (Microsoft.Build.BackEnd.Logging.ILoggingService loggingServiceForEvaluation, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings) [0x0003c] in <6a1392588f4a45bdbe07807130f9b3d0>:0
  at Microsoft.Build.Evaluation.Project.ReevaluateIfNecessary (Microsoft.Build.BackEnd.Logging.ILoggingService loggingServiceForEvaluation, Microsoft.Build.Evaluation.ProjectLoadSettings loadSettings) [0x00025] in <6a1392588f4a45bdbe07807130f9b3d0>:0

[info]: OmniSharp.Script.ScriptProjectSystem
        Detecting CSX files in '/home/ambs/MyReps/TugEngine/TugEngine'.
[info]: OmniSharp.Script.ScriptProjectSystem
        Could not find any CSX files
[info]: OmniSharp.Startup
        Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider
[info]: OmniSharp.Startup
        Configuration finished.

But still no completion :-)

Right. That exception above is the reason why. Essentially, it's not finding the MonoGame targets file that's installed. Once it fails to find that, it bails on processing the project further.

I think the problem so far was I was opening files and not folders (?).
So, vscode needs to find data about MonoGame but the installer did not place it in the correct place.

No, that's unlikely. MSBuild (and xbuild -- now deprecated) have... unconventional ways of locating files. It's more likely that we need to do something in OmniSharp to locate the targets properly.

ok, I can find that file here:
/usr/lib/mono/xbuild/MonoGame/v3.0/MonoGame.Content.Builder.targets
(msbuild or MSBuild -- command not found)

Yup. OK. Here's a workaround for you. It's not great, but'll get your project working. Add an "omnisharp.json" file to the directory that you're opening in VS Code with the following content:
{
    "msbuild": {
        "MSBuildExtensionsPath": "/usr/lib/mono/xbuild"
    }
}

Be sure to keep that file in the root folder that you open in VS Code and it should get things working for you.

Just great. Probably next versions can do that automatically
But for me this is fine :-) Thanks for your time!

Cool. We'll take a look at addressing this in OmniSharp soon. In the meantime, just adding that should fix it for any MonoGame project.

I would suggest keeping this around for reference while not fixed, but if you would like, be my guest closing it.

I've got a fix for this in PR here: https://github.com/OmniSharp/omnisharp-roslyn/pull/923. Once it's merged, it'll appear in C# for VS Code once we take a new version of OmniSharp.

I never realized this was a bug.... I've been constantly just recreating symlinks to folders that contain targets file... well my life is gonna get a whole lot easier :D


[Feature Request]:  Title name not showing for icons

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
The title text for few of the existing icons is not showing/or not named.

Use Case
This case can be used to identify the use or work-case of the icons for the user. It can make the working of the user for easy as the user can check the functionality before implementation.
Benefits
Showing title text when hovering over icons provides several benefits, including improved usability by helping users understand the icon's function, especially if its meaning is not immediately clear. It enhances accessibility by aiding users with visual impairments or cognitive difficulties through additional context. This feature also contributes to a better user experience by reducing the learning curve for new users, offering quick explanations without extra clicks. Consistent navigation is ensured, allowing users to quickly and accurately navigate the interface, which increases efficiency and satisfaction. Furthermore, it helps prevent errors by clarifying the purpose of the icons before any actions are taken.
Add ScreenShots
No response
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I want to work on this issue

Is this issue resolved?

yes
On Thu, Aug 8, 2024 at 10:39 PM Sarah Khan @.***> wrote:

Is this issue resolved?
—
Reply to this email directly, view it on GitHub
https://github.com/singodiyashubham87/Draw-it-out/issues/508#issuecomment-2276289719,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHNZX245WFOS6XRL74W4C5TZQOQ57AVCNFSM6AAAAABLYZJW2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGI4DSNZRHE
.
You are receiving this because you were assigned.Message ID:
@.***>


Kick the CI

Kicking the CI to check if things are working before doing some development. Used the handle little trick from Eric https://github.com/mne-tools/mne-realtime/pull/44#issuecomment-1497365006

Let me know if you want help

Thanks @larsoner. Florin is tackling the changes over in #507, so any suggestions or feedback for him there would be appreciated.


feat(jsx): created the missing jsx queries

fixes #222

but now you need to add jsx here again: https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/master/queries/javascript/textobjects.scm for JS, typescript and tsx

but now you need to add jsx here again: https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/master/queries/javascript/textobjects.scm for JS, typescript and tsx

Can you explain it a but further? As far as I know, tsx already references JSX

but now you need to add jsx here again: https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/master/queries/javascript/textobjects.scm for JS, typescript and tsx

Can you explain it a but further? As far as I know, tsx already references JSX

But JS not anymore https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/master/queries/javascript/textobjects.scm

@theHamsta do you mean that typescript should also extend JSX right. Typescript does not allow JSX in plain TS files, so it is not needed there

@theHamsta do you mean that typescript should also extend JSX right. Typescript does not allow JSX in plain TS files, so it is not needed there

that might be true, but javascript includes jsx

@theHamsta do you mean that typescript should also extend JSX right. Typescript does not allow JSX in plain TS files, so it is not needed there

that might be true, but javascript includes jsx

Yes, yes, and I will be adding it. I mistakenly wrote typescript twice, when the first one should have been Javascript, meaning that I will be adding it to Javascript but not to typescript. Sorry for the confusion

@danielo515 I added the suggestions. However, I am not sure about how the inherit mechanism works, so I don't know if what I did is correct

Thank you!


Make a clear distinction between ReqMgr2 and user create arguments

@ticoann I'm pretty sure you predicted this confusion... :-(
Besides this distinction, the only changes are:
*) RequestString is not a ReqMgr2 argument, but user has to provide it
*) RequestStatus is mandatory during assignment (maybe there was a reason I set it to optional...)
Once we merge it, we should point the master code to Antanas again.

the reason it was optional during assignment comes from the fact that we remove that key/value during the arguments handling/validation. Don't merge it yet, if it's simple, I'll just fix the validation code, otherwise I make it optional in the definition again.

2nd commit fixes that issue. Ive just need more time to make sure it won't break in a very specific case.

@ticoann I tested all test workflows and resubmission for all request types. This time it should be working fine.
Please review and merge, if possible, before your clone fix :-)

test this please

Thanks Alan, Patch looks good to me. I'm merging it before clone patch. 😄


Interactivity lost after setting a param on a named map in IE9

Having a named map and using Google Maps and Internet Explorer 9, if I set a new parameter for a named map the library loads new tiles reflecting the change but the interactivity is lost most of the times after the first infowindow is called.
Here some example code, details below
<!DOCTYPE html>

    <title>Named Map with Interactivity | CartoDB.js</title>
    <meta name="viewport" content="initial-scale=1.0, user-scalable=no" />
    <meta http-equiv="content-type" content="text/html; charset=UTF-8"/>
    <link rel="shortcut icon" href="http://cartodb.com/assets/favicon.ico" />

    <link rel="stylesheet" href="http://libs.cartocdn.com/cartodb.js/v3/3.15/themes/css/cartodb.css" />

To reproduce the error load the page, click on any green dot to call the event and the setParam and then click again any other feature (both countries and big dots). I'm pretty sure is related with GMaps because I haven't been able to reproduce it with Leaflet. Haven't tried with newer versions of IE, though and nothings shows up on the IE9 console :disappointed: .
cc. @danicarrion

I've tried to reproduce this issue on IE9 running on Windows 7, but the example seems to be working fine:

@danicarrion I'll reproduce this ASAP just in case we're lucky and this has been solved from the gmaps part

cool, I can give it a try tomorrow if needed too

Confirmed that it works, also with the original code the client passed. This was probably related with using an old version of the js library. Closing.


Error installing in cookiecutter django project

Describe the bug
I have a problem when installing and running the app
To Reproduce
Steps to reproduce the behavior:

Generate django cookiecutter app (blank one)
Follow the steps in the guide: Update urls.py, include app in installed apps
Run makemigrations appointment as the guide suggests (I did not include django Q)

Expected behavior
To create the migrations successfully
Logs
    path('appointment/', include('appointment.urls')),
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/django/urls/conf.py", line 38, in include
    urlconf_module = import_module(urlconf_module)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 995, in exec_module
  File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
  File "/usr/local/lib/python3.12/site-packages/appointment/urls.py", line 11, in <module>
    from appointment.views import (
  File "/usr/local/lib/python3.12/site-packages/appointment/views.py", line 24, in <module>
    from appointment.forms import AppointmentForm, AppointmentRequestForm, SlotForm, ClientDataForm
  File "/usr/local/lib/python3.12/site-packages/appointment/forms.py", line 42, in <module>
    class AppointmentForm(forms.ModelForm):
  File "/usr/local/lib/python3.12/site-packages/appointment/forms.py", line 43, in AppointmentForm
    phone = PhoneNumberField(widget=PhoneNumberPrefixWidget(initial='US'))
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: MultiWidget.__init__() got an unexpected keyword argument 'initial'

Additional context
I run this in docker compose, although I don't think that might be relevant
Can you fix the bug?

[ ] Yes, I can fix the bug and will open a pull request.
[ ] No, I can't fix the bug, but I can assist in testing and providing feedback.
[ x] No, I can't fix the bug, but I can provide more information to help you fix it.
[ ] No, I can't fix the bug, but I can open an issue to report it.

My bad, it seems I have a conflict with the requirements and I had django_phonenumber_field-8.0.0, which is not the version required by this repo. Apologies!!

Hi @eecarres, yes, this is a problem I'm currently working on. I need to address the issue with this package breaking changes.

Thanks for the answer and for your time. Amazing work!!
El jue, 4 jul 2024, 13:08, Adams Pierre David @.***>
escribió:

Hi @eecarres https://github.com/eecarres, yes, this is a problem I'm
currently working on. I need to address the issue with this package
breaking changes.
—
Reply to this email directly, view it on GitHub
https://github.com/adamspd/django-appointment/issues/215#issuecomment-2208706234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSFTSTISNLCACPJMNKIUYDZKUUKVAVCNFSM6AAAAABKLDGJEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYG4YDMMRTGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am running into the same issue.  Which version of django_phonenumber_field is required?

The one established in requirements: https://github.com/adamspd/django-appointment/blob/main/requirements.txt#L4


Feat: Generate typescript package types and tests

Resubmitting as a pr to the base repo.
Original PR: https://github.com/ChangJoo-Park/create-nuxt-app/pull/1
But it didn't make it into the initial typescript support here: https://github.com/nuxt/create-nuxt-app/pull/449
List of changes

Create nuxt.config.ts

Update nuxt.config.ts with changes from nuxt.config.js

Create a generate component template helper to switch between javascript and typescript

Another approach, if there are more typscript differences, could be a seperate file for js and typescript. but that seemed unnecessary right now

Update the following components to generate typescript components using the generateComponent template helper

buefy
FrameVuerk
Iview
Vuesax
Vuetify

Add typescript files to eslint and lint-staged configs

fix tests for typescript runtime

Add vue-shims.d.ts file

Issues from #448 - @davelsan

[Fix] File XXX is not a module (Vetur error)

vue-shims.d.ts included above

[Fix] Remove linting of unused vars

Add a fix by prefixing them with a _, which is the standard way to declare an unused var

[Fix] Do not use the base ESLint indent rule

No fix for this in this PR. I'm going to leave this for another issue

[Feat] Add TypeScript linting to package.json scripts

Included above

[Feat] Add TypeScript support to Jest test files

added @types/jest as suggested by @davelsan

[Feat] Port Nuxt config to TypeScript

Included above

@NickBolles Ping ;)

I'll try to look at this again today or tomorrow. Ping me again if you don't hear back by monday

Issues from #448

[Fix] File XXX is not a module (Vetur error)

vue-shims.d.ts already included in this PR

[Fix] Remove linting of unused vars

Add a fix by prefixing them with a _, which is the standard way to declare an unused var

[Fix] Do not use the base ESLint indent rule

No fix for this in this PR (yet). I don't quite understand the issue yet.

[Feat] Add TypeScript linting to package.json scripts

Already included in this PR

[Feat] Add TypeScript support to Jest test files

added

[Feat] Port Nuxt config to TypeScript

Already included in this PR

todo: look through the rest of the modules to see if we can install types for them

Thanks for the new additions. A couple of notes:
[Fix] File XXX is not a module (Vetur error)

vue-shims.d.ts already included in this PR

This should be enough. For the additional problem reported in vuejs/vetur#1187, there is a PR vuejs/vetur#1806 on the way.
[Fix] Do not use the base ESLint indent rule

No fix for this in this PR (yet). I don't quite understand the issue yet.

Originally reported in nuxt/eslint-config#76.
The issue is that, within *.vue components, indentation enforcement should be handled by eslint-plugin-vue through the vue/script-indent rule.
In the docs (see above link) it is recommended that the base indent rule is switched off within *.vue files, using an override.
{
  "rules": {
    "vue/script-indent": ["error", 2, { "baseIndent": 1 }]
  },
  "overrides": [
    {
      "files": ["*.vue"],
      "rules": {
        "indent": "off"
      }
    }
  ]
}

In *.ts files indentation should enforced by the @typescript-eslint/indent rule. In the docs it is recommended to switch off the base indent rule.
{
 "rules": {
   "indent": "off",
   "vue/script-indent": ["error", 2, { "baseIndent": 1 }]
 },
 "overrides": [
   {
     "files": ["*.ts"],
     "rules": {
       "@typescript-eslint/indent": ["error", 2]
     }
   }
 ]
}

This should be enough. For the additional problem reported in vuejs/vetur#1187, there is a PR vuejs/vetur#1806 on the way.

Nice! This should be good for now though.

[Fix] Do not use the base ESLint indent rule

No fix for this in this PR (yet). I don't quite understand the issue yet.

Your reasoning sounds good to me.
Could we do something like this though?
{
  "rules": {
    "vue/script-indent": ["error", 2, { "baseIndent": 1 }]
  },
  "overrides": [
    {
      "files": ["*.vue","*.ts"],
      "rules": {
        "indent": "off"
      }
    }
  ]
}

Would that result in the same functionality and also retain the "indent" rule for non ts or vue files?

Would that result in the same functionality and also retain the "indent" rule for non ts or vue files?

Yes, that would work, but then we are not using the @typescript-eslint/indent rule for *.ts files, and it feels weird to have a vue-eslint/indent base config with a *.vue override as well.
To avoid conflicts between rules, we could decide on a base config and turn on/off rules for specific files.
For a Nuxt-TypeScript project, I'd suggest the following:

Base: set vue/script-indent and turn off indent
Override: set @typescript-eslint/indent rule for *.ts files
(Optional) Override: set indent for *.js files

Because all three rules conflict with each other, I think this is a more parsimonious approach.
{
  // .eslintrc.json
  "rules": {
    "indent":"off",
    "vue/script-indent": [ "error", 2, {
      "baseIndent": 1
    }]
  },
  "overrides": [
    {
      "files": [ "*.ts" ],
      "rules": {
        "@typescript-eslint/indent": ["error", 2]
      }
    },
    {
      "files": [ "*.js" ],
      "rules": {
        "indent": [ "error", 2 ]
      }
    }
  ]
}

If you prefer to have indent on by default (I don't recommend this), then vue/script-indent and @typescript-eslint/indent should be in separate overrides, plus indent should be switched off in each.

This is just a side note. For reasons unknown to me yet, even in *.js files the indent rule causes the following error in vscode (e.g. when typing const)

ESLint: Cannot read property 'loc' of undefined

Maybe this is a problem that should be reported in the microsoft/vscode-eslint repo.

i'm not sure why there are so many commits. I had rebased onto master, not picking all of ChangJoo Parks commits. Diffs are only from my commits though.
@kevinmarrec could you review?

@NickBolles Might be related to this issue https://github.com/vuejs/eslint-plugin-vue/issues/370

@NickBolles Might be related to this issue https://github.com/vuejs/eslint-plugin-vue/issues/370

That's the eslint error. But it's not the same cause. The cause is that we are using ejs tags (<%_ _%> for example) in Vue files. That's unexpected in most cases.
Linting for anything with ejs syntax seems like a challenge.
That being said, I think disabling that rule for the repo would be the fix.

Hey, I wanted to drop by and say I appreciate very much the work you're doing in this PR. Sometimes the way I write is not the most sensible, so I'm just trying to make sure I convey the right message.
So, yeah, looking forwards to this being merged!

That being said, I think disabling that rule for the repo would be the fix.

(Trying to stay on topic)  I don't know the next thing about SAO or ejs, but my uneducated guess is that you're right. I say this after various messy and unsuccessful attempts to generate the <script/> tags without the linter yelling at me.

Thanks for the pr, could you please fix the lint errors ?

done!

@NickBolles Is this ready now?

@davelsan and @NickBolles You might find this useful https://github.com/overlookmotel/eslint-plugin-ejs-js

Is this important enough to patch the package? Seems like it might belong in a seperate pr?

Is this important enough to patch the package? Seems like it might belong in a seperate pr?

That's just a 3 line patch to make the ejs lib do the work.

@NickBolles Did you understand why we have error clear vue/comment-directive ?

@NickBolles ping

@mtltechtemp If you want to put a pull request together, either to follow up this one, or to merge into this branch I'd be fine with that. Although IMO a better fix would be to update eslint-plugin-ejs to register a pre-processor ID (https://eslint.org/docs/developer-guide/working-with-plugins#processors-in-plugins) and then allow users to configure it via the processor config, or overrides configs: https://eslint.org/docs/user-guide/configuring#specifying-processor
I hate doing one time patches of modules when with a little bit more work everyone can benefit.

@NickBolles Could you take into account my requested changes, then make your PR compatible with new monorepo (that's why you get lot of conflicts)

@NickBolles Can you fix conflicts & tests ? Thanks :)

@kevinmarrec updated. Could you take a look at this today? It's getting kinda difficult to keep this up to date with all of the other changes going on. :/

Greate feature and nice work @NickBolles

@NickBolles fo you mind resolving the conflicts one last time?

Is there any plan to continue working on this, or will it be changed after Nuxt 3 anyway?


docs up to date?

https://github.com/redhat-cop/group-sync-operator#overview states "Currently, this functionality is limited to LDAP only." - but it is possible to configure for instance AD credentials. What does the controller do if it does not create groups?

this relates to existing OpenShift functionality. Not the operator

But will the operator create the groups or not when running on ocp?

Yes it will. That is the goal of the operator. Doc updates to clarify as part of #53

Maybe the sentence "Currently, this functionality is limited to LDAP only." should be dropped from the readme then?

@davidkarlsen README has been updated to read "Currently, the functionality that is included in OpenShift to limited to synchronizing LDAP only"


Fix version conflicts caused by PR#933

I encountered a similar dependency hell issue when bump Newtonsoft.Json from 11.0.2 to 13.0.1. (PR#933).
Hope this fix can help you.
Best regards,
sucrose

Thanks for helping us out @sucrose0413. It looks like this PR failed on AppVeyor.


Update documentation to include CTA for getting a hosted account in the installation section

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1337
Originally created by @dmor on 2019-12-02 14:41:12

View 4 previous comments from the original issue on GitLab


refactor: move table rendering into own funcs

The logic for rendering tables with the checkpoint data was all present
in a single function showContainerCheckpoint(). This has now been
refactored to provide each table its own function that can be called to
render it. This increases code maintainability going forward as more and
more tables are added to the checkpointctl show command.

Codecov Report
Patch coverage: 90.14% and project coverage change: +0.25 :tada:

Comparison is base (d2600ca) 80.31% compared to head (e278052) 80.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   80.31%   80.56%   +0.25%
==========================================
  Files           3        3
  Lines         386      391       +5
==========================================
+ Hits          310      315       +5
  Misses         55       55
  Partials       21       21

Impacted Files
Coverage Δ

container.go
82.78% <89.23%> (+0.36%)
:arrow_up:

checkpointctl.go
84.21% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.