ARROW-11616: [Rust][DataFusion] Add collect_partitioned on DataFrame

The DataFrame API has a collect method which invokes the collect(plan: Arc<dyn ExecutionPlan>) -> Result<Vec<RecordBatch>> function which will collect records into a single vector of RecordBatches removing any partitioning via MergeExec.
This PR adds the DataFrame collect_partitioned method so that partitioning can be maintained. This allows easy passing into a new MemTable.
@andygrove

Codecov Report

Merging #9485 (5ed4321) into master (7660a22) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #9485      +/-   ##
==========================================
- Coverage   82.31%   82.30%   -0.01%
==========================================
  Files         234      234
  Lines       54482    54488       +6
==========================================
  Hits        44849    44849
- Misses       9633     9639       +6

Impacted Files
Coverage Δ

rust/datafusion/src/execution/dataframe_impl.rs
90.13% <0.00%> (-3.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7660a22...5ed4321. Read the comment docs.

Nice improvement. Thanks @seddonm1. At some point we may want collect to return an iterator over batches rather than a vec.

@andygrove  I think we already kind of have this -- namely SendableRecordBatchStream (the thing you get from calling execute directly is an "Iterator" (well, it is an async iterator). To get an actual Iterator from the async one, we would probably need to buffer the RecordBatches anyway so I think making that buffering clear to the end user by passing out a Vec is a reasonable API. That is my $0.02 anyways


Extended shipping method types

Please list the related package(s)
checkout-ui-extensions
If this related to specific APIs or components, please list them here
Related to: https://shopify.dev/api/checkout-extensions/checkout/extension-points/api#react-hooks
Is your feature request related to a problem? Please describe.
A native way to offer enhanced shipping methods that require the user to specify a delivery date or collection point
Describe the changes you are looking for
Further to the discussion here: https://github.com/Shopify/ui-extensions/issues/406
We currently have to customise the checkout.liquid and add write a lot of JS to offer the following types of shipping methods:

Named day (via a datepicker)
Collection point (via a map / list of points)

Both of these types of shipping methods have become fairly commonplace, and are essential if our merchants are to offer shipping options that rival Amazon, or brands on other ecomm platforms etc.
It's not enough to just offer a datepicker or map UI element though. The list of available dates or locations can vary depending on the cart contents. What we would love is to see some kind of tie-up between these front end elements and the Carrier Service functionality. The flow would work as follows:

Customer enters address (as now)
Carrier service is called (as now)
Carrier service returns list of methods (as now)
Some of these methods may return a list of dates or locations (as well as title & price)
User selects a method, and the appropriate UI appears to gather the extra data
Extra data is attached to the order as a metafield

Describe alternatives you’ve considered
Currently implemented via customisations to checkout.liquid with AJAX to enrich the UI
Additional context
Example datepicker implementation from www.mamasandpapas.com via customised checkout.liquid

+1

These features are definitely on our radar and we are exploring this now. We are exploring not only elements like DatePicker and map components, but also the end-end of how to ties these together. Thank you for this detailed summary of what you are looking for here!

@jarthorn - is it likely that as part of this we will be able to use a 3rd party service for delivery calculations? Our current implementation fires off a request to a shipping broker service to get a list of valid methods.

@jarthorn - is it likely that as part of this we will be able to use a 3rd party service for delivery calculations? Our current implementation fires off a request to a shipping broker service to get a list of valid methods.

Are you referring to using the Shopify carrier service API, or is this is bespoke integration with a 3rd party service? I expect for "ship to buyer" delivery we will continue to use the carrier service. We are considering different APIs for shipping to pickup points and pickup in store to offer more flexibility in those scenarios. If you have particular scenarios where existing APIs aren't flexible enough I'd love to hear details because we're working on this right now.

Thank you so much for these details! We've observed this pattern on many stores and it's understandable. Clearly you're being forced to resort to hacks here because of the lack of flexibility in the underlying system. What we are aiming for is that the "Delivery Method" chosen by the buyer accurately reflects which of the three fundamental choices available ("We'll ship it to you", "You come to pick it up", "We ship it to a place where you will pick it up"). Then, we want to enable additional levels of flexibility for each delivery method, through a combination of UI extensions and backend integrations with Shopify Functions or things like the carrier API, to enable all the various business needs that individual merchants have. In other words we are working on building a solution that can anwer "Yes" to all your three questions here.

Sounds perfect @jarthorn. We've got lots of experience with these sorts of retailers so happy help whenever.

+1
One of my shopify plus clients is also using a checkout.liquid solution which I developed for him, and which we will lose in August 2024. My implementation looks like this:
We first changed the "Ship to home" option on the first shipping step to say "Ship to home or Nearby Warehouse", to avoid confusions for the customer which @jarthorn mentions:

We then show various options of warehouses nearby which they can drive to, embedding a google maps instance to show the relative drive-times from their house. Each time a new option is selected, the map is redrawn, and explanatory text is changed:

This was all-done through CSS and javascript embeds on checkout.liquid, which added complexity to maintenance at each checkout.liquid upgrade. Nonetheless, we've managed this, because the feature drives significant revenue for my client. As I understand Checkout UI now, we have no option to reimplement this feature even in the most simplified and paired-down form. We can compromise on where these embeds are placed and what kind of content is allowed, but as I understand it now, there isn't any hook I can subscribe to on shipping method changes, to exchange any content anywhere on the checkout page. Just a simple shipping option change hook would allow us to do a basic implementation.
If shopify can inform us on whether or not the API's proposed on this thread, or API's like them, will be added to extensions UI, I would greatly appreciate it.

+1

Any progress on this in Checkout UI?
We are trying to recreate this functionality for this store: https://giftbasketstore.com/


Fix HTTP keepalive support

This commit broke HTTP keepalive support by introducing a
double-negation on the call to Netty's isKeepAlive.

damn - i see what i did there. this needs to be fixed for 3.1.2. as such, can you please retarget this PR for the tp31 branch?

Sure, will re-open with tp31 as the target.


widgets compatibility

for old widget inherit all newest modelsParameters by default. User can open existing project and enjoy alll the novelty without creating new widgets

can be extended to models, modelsHiddenParams if needed

Very useful evolution. Thanks Abir.
This is validated.


Adding input type event handlers

Hi, is there anyway to specify or pass in functions we want executed for basic javascritp event handlers?  For instance, I wanted to hook something up for the onFocus event handler on a text input field but was unable to do so.  From reading the code it appears as though only onChange is supported and onClick for button types.  Thanks for the help.

Hi @yellowandy,
currently no. I guess it could be handled the same way as onChange though.
What is the use case? What are you trying to do?


Add RAS directory into test document generation tools

[ ] To add RAS directory into test document generation tools

[ ] Update readme related to invoking (generate_test_document) - Readme was re-written and there old example was removed. Expected generate_test_document tool need to be invoked from the base openbmc-test-automation directory.

Thank you @SrideviRamesh for volunteering.  👍 Appreciate it.

@SrideviRamesh - Here was the Readme before new readme was re-written.
https://github.com/openbmc/openbmc-test-automation/commit/4470957efe04367e743579cb589b105a719a51e8#diff-04c6e90faac2675aa89e2176d2eec7d8

Sridevi is occupied with other item, Will make changes and include secureboot directory as well.


Tour direction continuity

Hi, I'm building a tour with each area crosslinked by hotspots. Currently the view reorients to yaw=0, pitch=0 on each scene load. I'd like to save the compass heading in order to restore that when the new scene loads. My intentions are to use the NorthOffset saved on the scene along with the Yaw in order to calculate a compass heading. From the reference section it looks like scenechange should fire before the new scene loads but it seems to be giving me the values from the new scene, rather than the one I'm coming from. Is that the way it should be operating? Can you tell me if there's another event I should listen to instead?

Nevermind, I see that I can add a clickHandlerFunc to each of my hotspots that can get the current scene's information before switching to a new one.

If I understand correctly what you're trying to do, you don't need to use the API at all. Setting the targetYaw parameter on each hot spot to sameAzimuth will load the new scene with the same compass heading as the current heading in the old scene.
The scenechange event fires when the loading process starts, after the new parameters are set. Changing when it fires to before the new parameters are set would just cause a race condition on the event listener, similar to what your saw with the clickHandlerFunc. I do have a few ideas on how to change things to provide the information you want, so let me know if the sameAzimuth setting doesn't do what you need.

Wow, the sameAzimuth setting is exactly what I wanted. I didn't know it existed even though I was all over the documentation, I must have skimmed over it. I've found a bug with it though. If the scene doesn't have a northOffset setting then it is giving me a view without loading the pictures. I get a solid color sky and a solid color land. Do you want me to open a separate issue for that? It works fine even if I set a northOffset of 0 on each scene.

I wasn't checking to see if northOffset was set before doing math with it, so the resulting yaw was NaN, hence the issue. I just fixed this in d9d216f2ae82a92b26a1e74d40b6a9db7ab39fbf.

Thanks!
Two questions: Which arrow on the compass is north; The white one or the black one?
Is the device orientation control relative or absolute? Absolute would be locked to the internal compass of the device, showing North when the device is pointing North. That seems to be the case but I'd like to confirm it. Relative would adjust the view in relation to the change with yaw rather than the absolute yaw of the device.

Black is north, and white is south, which is standard (well, red for north, but that becomes black when converting to monochrome).
The device orientation control is relative. See https://github.com/mpetroff/pannellum/issues/257#issuecomment-248727137 for more details.


bump aws-sdk-go

Bump aws-sdk-go to https://github.com/aws/aws-sdk-go/commit/727e1f596b6b59700b4d286af9ca41747066685d.
Dropped the local copy of jsonutil in favor of using the now public-ish version in the sdk.

:+1:


reapply 7309426 (configurable completion) which was removed in 9bef3b3

removed in #46 by accident?

Oh, woops. I think I reset too far while doing that.

Thanks, do you think we could get a version bump on hackage?

Pushed 0.1.14.

Thanks a lot!


Jacobian spectrum density plots (pcolormesh) have strange behaviour for missing stable solutions

In systems where no stable solutions are found, the missing values form gaps in the 1D solution plots, which is correct. However, one would expect a corresponding missing section in the 2D density plots of the Jacobian noise spectrum. This does not take place, as pcolormesh seems to fill the gaps with a continuous colored section, which is artificial and can be misleading. A solution would be to the spectrum in the noise spectrum with NaNs or Infs if no stable solutions have been found for the corresponding parameter value.

Closed by #44


Karpenter - Reconciliation not possible for custom named instances

Description
The Karpenter controller is not able to reconcile instances to be deleted if their name does not include Karpenter.
Looking at the code it seems that the IAM policy for the IRSAis expecting the name to always include karpenter (see link )

[x] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]:
Terraform version:
Terraform v1.6.1
on linux_amd64
Provider version(s):
Terraform v1.6.1
on linux_amd64

provider registry.terraform.io/gavinbunney/kubectl v1.14.0
provider registry.terraform.io/hashicorp/aws v5.0.1
provider registry.terraform.io/hashicorp/cloudinit v2.3.2
provider registry.terraform.io/hashicorp/helm v2.11.0
provider registry.terraform.io/hashicorp/http v3.4.0
provider registry.terraform.io/hashicorp/kubernetes v2.23.0
provider registry.terraform.io/hashicorp/time v0.9.1
provider registry.terraform.io/hashicorp/tls v4.0.4

Reproduction Code [Required]
module "eks-blueprints-addons" {
  source  = "aws-ia/eks-blueprints-addons/aws"
  version = "1.10.1"

  cluster_name      = local.cluster_name
  cluster_endpoint  = module.eks_cluster.cluster_endpoint
  cluster_version   = var.eks_cluster_version
  oidc_provider_arn = module.eks_cluster.oidc_provider_arn

  eks_addons = {
  karpenter_enable_spot_termination = false
  enable_karpenter = true
  karpenter_node = {
      iam_role_arn = module.eks_cluster.eks_managed_node_groups.eks-static-nodes.iam_role_arn
      create_iam_role = false
    }
  karpenter = {
    chart_version = "v${var.eks_karpenter_version}"
    values = [
      <<-EOT
        controller:
          image:
            tag: v${var.eks_karpenter_version}
        tolerations:
          - key: node-taints.example.com/scope
            value: infrastructure
            operator: Equal
        nodeSelector:
          node-labels.example.com/scope: "infrastrucutre"
      EOT
    ]
    wait = true
  }
  depends_on = [
    module.eks_cluster.eks_managed_node_groups
  ]
  tags = var.common_tags
}
resource "kubectl_manifest" "karpenter_provisioner" {
  yaml_body = <<-EOF
    apiVersion: karpenter.sh/v1beta1
    kind: NodePool
    metadata:
      name: default
    spec:
      template:
        metadata:
          labels:
            node-labels.example.com/scope: "application"
        spec:
          nodeClassRef:
            name: default
            apiVersion: karpenter.k8s.aws/v1beta1
            kind: EC2NodeClass
          taints:
          - key: node-taints.example.com/scope
            value: application
            effect: NoSchedule
          requirements:
          - key: "karpenter.k8s.aws/instance-category"
            operator: In
            values: ["t", "c"]
          - key: "karpenter.k8s.aws/instance-cpu"
            operator: In
            values: ["2", "4"]
          - key: "karpenter.k8s.aws/instance-memory"
            operator: Lt
            values: ["2048"]
          - key: "karpenter.k8s.aws/instance-generation"
            operator: Gt
            values: ["2"]
          - key: "topology.kubernetes.io/zone"
            operator: In
            values: ["eu-central-1a", "eu-central-1b"]
          - key: "kubernetes.io/arch"
            operator: In
            values: ["amd64"]
          - key: "karpenter.sh/capacity-type" # If not included, the webhook for the AWS cloud provider will default to on-demand
            operator: In
            values: ["on-demand"]
      disruption:
        expireAfter: Never
        consolidationPolicy: WhenEmpty
        consolidateAfter: 30s
      limits:
        cpu: "100"
        memory: 100Gi
    EOF

  depends_on = [
    module.eks-blueprints-addons
  ]
}

resource "kubectl_manifest" "karpenter_node_template" {
  yaml_body = <<-EOF
    apiVersion: karpenter.k8s.aws/v1beta1
    kind: EC2NodeClass
    metadata:
      name: default
    spec:
      amiFamily: AL2
      subnetSelectorTerms:
        - tags:
            karpenter.sh/discovery/node: ${var.k8s_private_sub_tags["karpenter.sh/discovery/node"]}
            karpenter.sh/discovery: ${var.k8s_private_sub_tags["karpenter.sh/discovery"]}
      securityGroupSelectorTerms:
        - tags:
            kubernetes.io/cluster/${local.cluster_name}: "owned"
      role: "${module.eks_cluster.eks_managed_node_groups.eks-static-nodes.iam_role_name}"
      tags:
        Name: eks-jit-nodes
      detailedMonitoring: false
    EOF

  depends_on = [
    module.eks-blueprints-addons
  ]
}

Steps to reproduce the behavior:

Apply the above
Trigger nodes creation
Scale back in deployment to trigger instance termination

Expected behaviour
Nodes should be terminated
Actual behaviour
Instance are not terminated and controller logs:
{"level":"ERROR","time":"2023-11-04T19:59:21.653Z","logger":"controller","message":"Reconciler error","commit":"1072d3b","controller":"node.termination","controllerGroup":"","controllerKind":"Node","Node":{"name":"ip-REDACTED.eu-central-1.compute.internal"},"namespace":"","name":"ip-REDACTED.eu-central-1.compute.internal","reconcileID":"5da575eb-5271-400c-8b89-ccde1c977275","error":"terminating cloudprovider instance, terminating instance, UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:sts::REDACTED:assumed-role/karpenter-20231104182048115600000018/1699126836611442743 is not authorized to perform: ec2:TerminateInstances on resource: arn:aws:ec2:eu-central-1:REDACTED:instance/i-REDACTED because no identity-based policy allows the ec2:TerminateInstances action.
Additional context
var.eks_karpenter_version is 0.32.1

you'll need to update to v1.11.0 which contains the necessary changes https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/pull/298

Thanks @bryantbiggs I'll test it again with new version, but checking the code of the tag 1.11.0 I don't quite get how it could help: https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/blob/v1.11.0/main.tf#L2841
Looks like it still is not customisable.
Note in the example above that in the EC2NodeClass I gave it the name eks-jit-nodes.
Ideally I would like to be able to set a terraform variable that can be passed consistently to the IAM policy and to the EC2NodeClass.
Thanks again

For now, I would not set the name tag on the nodes and the permissions will work as intended. We will be updating the permissions for Karpenter to re-align with the upstream project in https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/issues/286


Discussion: Resources you used to implement encryption

Dear PhiTux,
Apologies for opening this in the issues section, but I don't see a discussion section so am hopeful you'll be able to respond here if possible.
I'm very grateful to you and the team for this project! I'm reviewing the source code and am learning a whole bunch of stuff. I have a quick question - what resources did you use to implement the encryption for DailyTxT?
Was it mainly the main docs here - https://cryptography.io/en/latest/
Or did you use other learning resources?
Thank you so much again for taking the time to create such a helpful project :)
Sincerely,
Eric

Hi Eric,
thanks for the feedback :)
It's long ago that I implemented the encryption-part. But I guess, that it was 50% google and 50% the docs that you just posted 😅

Good to know! The app is very well structured. It's a terrific resource for those wanting to know about things! Bravo and thank you!


Add setNativeProps support for SafeAreaView

Summary
Fixes #24576 .
cc. @cpojer .
Changelog
[iOS] [Fixed] - Add setNativeProps support for SafeAreaView
Test Plan
Ci passes.

CC. @TheSavior .

@TheSavior Thanks!!! 💯

I'll merge it, and then Eli can monitor whether it works fine at FB later today :) #handoff


feat: improve type safety of Entity constructor inputs

Description
Enhances type safety in Entity constructors by generating strict TypeScript interfaces for constructor inputs. Required fields (marked with @Required) must be provided in the constructor, while optional fields remain optional. This prevents runtime errors by catching missing required fields at compile time.
Key changes:

Generates specific ConstructorInput interfaces for each Entity
Makes @Required fields mandatory in constructor types
Excludes Promise-wrapped relationship fields from constructor inputs
Properly handles array fields and relationships via ID fields

Fixes runtime errors that could occur when required fields are omitted during Entity instantiation.
Fixes #1088

Hey @rnons and @zfy0701
I'd really appreciate if you could take a moment to review this. It's quite simple and I'd like to get a newer version with this improvement published.

@spacedragon  will take a look, thanks for your contribution

LTGM,  one small trick to reduce some lines may be
type ConstructorInput = Partial<TheEntityClass> & {
    //  only required filed here
}

also to exclude those promise fields we could use omit
  Omit<TheEntityClass, "xxx Promise">

thanks for the review @spacedragon

The only concern to me users existing may need do some changes after this PR

would they not have to do those changes in any case for their processor to work properly?

thanks for the review @spacedragon

The only concern to me users existing may need do some changes after this PR

would they not have to do those changes in any case for their processor to work properly?

Some people may use codes like following
const entity = new Entity()
entity.requiedField = xxx

But I admit we should check if any required field is empty before it submit to database,  so please feel free to merge the PR.
Some user may need some modification to their exists code when they upgrade the SDK version but I think it worth to do it.

@spacedragon seems like one more workflow needs to pass before this PR can be merged in, can you trigger it?


Keep getting Exit Code: 127 error

I can only seem to get the error code 127 back when trying to run Puphpeteer.
[message] => The command "'/node/v16.14.2/bin/node' '/var/www/html/vendor/nesk/puphpeteer/src/get-puppeteer-version.js'" failed. Exit Code: 127(Command not found)
I'm passing the full path to node to executable_path when setting it up. I've been using /usr/local/.nvm/versions/node/v16.14.2/bin/node but I also tried copying node here /node/v16.14.2/bin. In either/both places node is owned by www-data (the user that php runs as) and has execute permissions (755).
Running '/node/v16.14.2/bin/node' '/var/www/html/vendor/nesk/puphpeteer/src/get-puppeteer-version.js' on the command line returns "5.5.0" so node is there and executable and the get-puppeteer-version script exists.
If anyone has any insight into why I'd be getting this error, that'd be great! Thanks!
Environment:

OS: Ubuntu 18.04.4
Node version: 16.14.2
PHP version 8.1

I am facing the same problem and the solution work for me is
echo 'export PATH=$PATH:/usr/local/nvm/versions/node/v18.8.0/bin/node' >> $HOME/.bashrc
source $HOME/.bashrc
I install node version using nvm on ubuntu


cleanup js api

This cleans up the api exposed when used as a module.
I also added support for handling circular references and scoped modules

once the readme is updated im totes :+1:

might actually consider making the options argument optional

It is https://github.com/chrisdickinson/clone-packages/pull/16/files#diff-6d186b954a58d5bb740f73d84fe39073R7

oh, derp, looked in the wrong spot


Fix TOML++ compilation with Clang-Cl toolchain

Compilation fails for Clang-Cl toolchain when it tries to test the package due to failure on implicit conversion to toml::table.
I simply replaced it with auto in the test snippet which seems to resolve this issue.
Log from error: (same happens for latest release version)
  => install toml++ master .. failed

C:\Users\andre\AppData\Local\Temp\.xmake\230715\_04EC0038C54040C282A93F45FB54B05B.cpp(18,29): error: conversion from 'toml::parse_result' to 'toml::table' is ambiguous
                toml::table tbl = toml::parse(some_toml);
                            ^     ~~~~~~~~~~~~~~~~~~~~~~
C:\Users\andre\AppData\Local\.xmake\packages\t\toml++\master\91dd63516d5447209d6768a849484ffd\include\toml++/impl/parse_result.h(203,18): note: candidate function
                /* implicit */ operator toml::table&() noexcept
                               ^
C:\Users\andre\AppData\Local\.xmake\packages\t\toml++\master\91dd63516d5447209d6768a849484ffd\include\toml++/impl/parse_result.h(210,18): note: candidate function
                /* implicit */ operator toml::table&&() noexcept
                               ^
1 error generated.

Did CI just gave up here? I dont understand why that single FreeBSD check failed looking at the logs 😕

Did CI just gave up here? I dont understand why that single FreeBSD check failed looking at the logs 😕

bsd ci is unstable, you can re-run it.


More optimizations for Shared Component Properties

This patch includes changes to leverage standard Sling object patterns to greatly improve performance of the SharedValueMapValueInjector and the SharedComponentPropertiesBindingsValuesProvider when rendering a complex page.

SharedComponentPropertiesBindingsValuesProvider uses an internal request attribute cache type for collecting Bindings computed different levels of shared properties according to their resource paths. This optimizes the BVP behavior by keeping the SCP results around for reuse across sling includes.
The SharedValueMapValueInjector will now attempt to retrieve results from the SlingBindings when the model adaptable is a request. This greatly optimizes requests for the simple case where a sling model used within an HTL script can access any SCP-provided properties from the SlingBindings, rather having to evaluate the adaptable request or resource again.
For more complicated scenarios where the injector is evaluating SCP for a resource adaptable, such as when it is referenced by another model using the @ChildResource annotation, and the bindings provided by BVP are not present or are not relevant for the child resource, the injector will adapt the resource to a SharedValueMapResourceAdapter, which implicitly leverages the SlingAdaptable adapters cache so that the SCP calculation for the injector is only evaluated once. This is similar to the traditional behavior of Resource.getValueMap() and originally Resource.adaptTo(ValueMap.class).

Code all looks good to me - I just need to find time to test.

Currently testing, hoping to get thru it today :)

Ok, I've tested this very thoroughly thru all the different code branches on AEM 6.5.  Unfortunately won't be able to get Cloud Service and 6.4 until early next week, but feeling pretty good about these optimizations being backward compatible and safe.

@davidjgonzalez I think we need to upgrade the codecov upload step in the github workflow. My fa2f2a2 commit above is unfortunately not going to affect the active workflow defined in the master branch until it is merged.

yeah - the github actions broke the ability to send to Codecov on PRs - was looking into it a while ago (think theres an open PR i made to test it out) .. iIRC we might have to add some override vars to get it to work? Or maybe Codecov has made updates on their side since then.

@davidjgonzalez any idea why the codecov/project test never comes back? Looks like it's preventing me from merging this for Mark.

Not sure, seems to be an edge case with PRs. We are trying out a new GH action in https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2706/files. Feel free to comment. For the time being I no longer made that status required.


Registry support

What does this do / why do we need it?
A go dep registry will host packaged versions of go "projects" in self-contained format.
Developers will be able to publish new project versions to the registry and resolve them back from the registry as project dependencies.
The primary use case for a registry is to support development isolation against an in-house repository that serves immutable project dependencies. These dependencies can be external dependencies or internal projects used in-house as 3rd party dependencies.
The registry will support authentication via user tokens.
This pull request adds the functionality of downloading dependencies from a registry.
Set the following environment variables to use registry:
DEPREGISTRYURL
DEPREGISTRYTOKEN

This PR is based on #1172 with review fixes.

Out of curiosity what were you using as a registry?

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


'zplug clean' Remove? (y/N) is duplicating the response and only removing every other plugin(if there are multiples)

zsh iTerm3 ('removed' are mine to show which ones are deleted):
› zplug clean
Remove? (y/N) '/usr/local/opt/zplug/repos/denysdovhan/spaceship-prompt' y
Remove? (y/N) '/usr/local/opt/zplug/repos/desyncr/auto-ls' y *removed*
Remove? (y/N) '/usr/local/opt/zplug/repos/momo-lab/zsh-abbrev-alias' y
Remove? (y/N) '/usr/local/opt/zplug/repos/zsh-users/zsh-autosuggestions' y *removed*
Remove? (y/N) '/usr/local/opt/zplug/repos/zsh-users/zsh-completions' y
Remove? (y/N) '/usr/local/opt/zplug/repos/zsh-users/zsh-syntax-highlighting' y *removed*

› zplug clean
Remove? (y/N) '/usr/local/opt/zplug/repos/denysdovhan/spaceship-prompt' y
Remove? (y/N) '/usr/local/opt/zplug/repos/momo-lab/zsh-abbrev-alias' y *removed*
Remove? (y/N) '/usr/local/opt/zplug/repos/zsh-users/zsh-completions' y

› zplug clean
Remove? (y/N) '/usr/local/opt/zplug/repos/denysdovhan/spaceship-prompt' y
Remove? (y/N) '/usr/local/opt/zplug/repos/zsh-users/zsh-completions' y *removed*

› zplug clean
Remove? (y/N) '/usr/local/opt/zplug/repos/denysdovhan/spaceship-prompt' y

› zplug clean
Remove? (y/N) '/usr/local/opt/zplug/repos/denysdovhan/spaceship-prompt'

To Reproduce
Steps to reproduce the behavior:

comment out a plugin for zplug and reload terminal
type 'zplug clean' to be promped for removal
type 'y'(or ANY letter)
Result:

the package isn't removed
the letter is repeated in the new prompt
if you type 'zplug clean' again, it'll ask to clean again.
if you have multiple(3+) directories, it'll only perform the function on the even plugins

Expected behavior
recognize first input without ignoring and then duplicating.
Env (please complete the following information):

zplug version: 2.4.2_
zsh --version: 5.5.1 (x86_64-apple-darwin17.5.0)
uname -a: Darwin BlackstarMBP 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64

Minimal zshrc (with less than 30 lines)
export ZPLUG_HOME=/usr/local/opt/zplug
source $ZPLUG_HOME/init.zsh

zplug "sorin-ionescu/prezto", \
use:"init.zsh", \
hook-build:"ln -s $ZPLUG_HOME/repos/sorin-ionescu/prezto ~/.zprezto"
zplug "modules/python", from:prezto
zplug "modules/utility", from:prezto
zplug "zsh-users/zsh-autosuggestions", defer:2
zplug "zsh-users/zsh-completions", defer:2
zplug "zsh-users/zsh-syntax-highlighting", defer:2
zplug denysdovhan/spaceship-prompt, use:spaceship.zsh, from:github, as:theme

# Install plugins if there are plugins that have not been installed
if ! zplug check --verbose; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

# Then, source plugins and add commands to $PATH
zplug load

I am also seeing this issue for a set of three plugins needing removal.


GTK popup from keybase login won't accept pastes?

When I run keybase login on linux, I get a GTK popup asking for my passphrase. I have a very, very long passphrase, and when I try to paste it into the window, the GTK window doesn't seem to accept the paste. I can type in the dialog, but it will not accept any paste. Is this by design, or is there potentially another problem?

It sounds like you're not running our GUI (if you installed from our site then run_keybase should start it), which would give you a separate popup that does allow pastes. Your system is probably falling back to some gpg pinentry app, and some of those disallow pastes, I suppose by design (once your password is on the clipboard then any other X app you were running could see it).

I did skip run_keybase, and instead ran keybase login directly (which started/forked the keybase daemon). OK, so run_keybase is required? Is there a way to use keybase without all the fluff? I don't want a daemon running, I only want keybase running when I invoke it (sorry, but I have minimal trust for keybase, and I don't want it running on startup or stuff like that).

You are right, I can paste when using run_keybase and the associated gui.


feat(coral): Topic details - Add Edit topic

About this change - What it does
Implements edit topic functionality:

Add editTopic domain handler
Add new behaviour in EntityDetailsHeader: hide Edit button when user is not allowed to edit (not owner of topic or there is currently a topic request open
Add TopicEditRequest component
Add route to render TopicEditRequest
Pass correct entityEditLink to EntityDetailsHeader

https://github.com/aiven/klaw/assets/20607294/2f7a00f8-4557-4a35-b979-fd971257e41b
Follow up
Working on this issue surfaced another issue, written up here: https://github.com/aiven/klaw/issues/1439
Resolves: #1435

If we use mutateAsync instead of mutate we should be fine!
https://github.com/aiven/klaw/assets/943800/1c67bed6-208c-41ad-abaf-619ed8525610

Ah and the handling of "user didn't change anything and hits submit" is still missing, right?

This is tested by the fact that editTopic is called with the environment value from mockGetAllEnvironmentsForTopicAndAcl returned value, isn't it? Isn't testing the outcome better than testing implementation detail?

Good argument. Yes, if we test strictly from a user perspective, it's not important to test this, only that the environment value is there and correctly handled. Also it's very implicit at the moment, so not inlining it would deffo help to make the test more readable.
I try to write my test cases with two questions in mind:

user-view -> what does the user see, how does their interaction affect states, is everything behaving as it should
dev-view -> does the component fullfill all promises it makes from a developer view, so in this case: it says it calls the api. Which I would confirm with an explicit test for that. That way, if the test for the "mockEditTopic is called with xyz" fails,  but the api call test does not fail, I already have one reason for the failing test excluded.

But since it's covered either way and the benefit of being more explicit is VERY small :D please read this just as reasoning for my comment :D and leave it as it is! 👯


"Add Maven Parent" recipe

What problem are you trying to solve?
I need to add a parent POM to my projects.
Describe the solution you'd like
I'd like a recipe for that as there already has one for changing the Maven parent.
Have you considered any alternatives or workarounds?
Using text recipe
Additional context

Are you interested in contributing this feature to OpenRewrite?
I can try :)

hi @rcsilva83 ! Thanks for the suggestion. For this one I'd assume the implementation would be rather similar to Change Maven Parent
https://github.com/openrewrite/rewrite/blob/28e7b125655fa507d68f80ed1dafa2dee38a38fa/rewrite-maven/src/main/java/org/openrewrite/maven/ChangeParentPom.java#L44
Perhaps we can start with a draft PR with some unit tests, and then I'll help guide you through what's needed beyond that.
Tests are also a great way to think through and codify how you'd want to handle certain cases, like:

should we match just any pom.xml file? Or only matching certain criteria?
How to handle an existing parent? Is that the same for multi module projects?

Hi @timtebeek
I'm trying to build the project on my machine but I'm having issues:
A problem occurred configuring project ':tools:language-parser-builder'.
> Cannot find a Java installation on your machine matching this tasks requirements: {languageVersion=17, vendor=any, implementation=vendor-specific} for WINDOWS on x86_64.
   > No locally installed toolchains match and toolchain download repositories have not been configured.

I'm running with JDK21 but it I run with JDK17 I have the same problem with languageVersion=21. I'm trying to configure org.gradle.java.installations.paths on gradle.properties but nothing changed...
Can you help me with this?

hi! That's curious; are you using any non standard paths for your installed JDKs? I know Gradle does some discovery that might fail to detect your JDK paths.
You might be able to work around this though by following these instructions to not load troublesome modules:
https://github.com/openrewrite/rewrite/blob/28e7b125655fa507d68f80ed1dafa2dee38a38fa/IDE.properties.tmp#L1-L7
We also have some more general IDE setup instructions on these pages.

https://docs.openrewrite.org/reference/building-openrewrite-from-source
https://docs.openrewrite.org/authoring-recipes/recipe-development-environment

Hope that helps!

Fixed in https://github.com/openrewrite/rewrite/pull/4289; thanks again!


Haskell: Add multi-select for default packages

Can grab the packages from here https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/haskell-modules/hackage-packages.nix
Just need to parse the nix expr, and grab the top level attrs.


Error transcribing file: DecodingOptions.init() got an unexpected keyword argument 'progress_callback'

Hi!
I have error:
Error transcribing file: DecodingOptions.init() got an unexpected keyword argument 'progress_callback'
when use --disable_faster_whisper=true with all models.
Without  --disable_faster_whisper=true it works.
Debian 12.2

I have not been able to reproduce the error with Windows 10. it seems like a bug with Debians, probably.

same problem with -disable_faster_whisper=true

You're right. Installing the official whisper will be problematic and I don't think this is good either..
All I did was adding a callback to trabscribe() to track the progress in the Gradio UI.
I was hoping that the official Whisper would provide a generator for this as I made a PR here, but it appears not to.
Perhaps just removing the progress tracking would be proper.


Position regression in v4.2.1

I've started experiencing menu position/transform bugs in v4.2.1 and later (tested in 4.2.2 as well):
https://github.com/user-attachments/assets/75ca7bca-9c34-4998-a5e4-d391a2c77136
The menu randomly appears out of the window bounds and may or may not re-position inside the window.
This doesn't happen in v4.2.0.

hey @elringus , this looks pretty unusual.
Can you please provide info about the props configuration, hopefully a reproducible sandbox example?
did you get this warning in the development environment?

Hi, Thanks for getting back!
Here is the wrapper I'm using over the @szhsin/react-menu (sorry for the unrelated code, I'll see if I can isolate it to a repro):
import { useState, useRef, ReactNode, MouseEvent, useLayoutEffect, useCallback } from "react";
import { c, BlurUnderlay } from "utilities";
import { Menu as SzhMenu, MenuButton as SzhMenuButton, MenuChangeEvent, MenuInstance } from "@szhsin/react-menu";
import { tip } from "components/tooltip";
import { MenuAlign } from "./types";
import<EMAIL_ADDRESS>import css from "styles/menu.module.css";

type Props = {
    label?: string;
    icon?: ReactNode;
    tooltip?: string;
    children?: ReactNode;
    buttonClass?: string;
    openButtonClass?: string;
    disabledButtonClass?: string;
    align?: MenuAlign;
    disabled?: boolean;
    handleOpen?: () => unknown;
    handleClose?: () => unknown;
};

export const Menu = ({
    align, buttonClass, children, disabled,
    disabledButtonClass, handleClose, handleOpen, icon, label, openButtonClass, tooltip
}: Props) => {

    const [open, setOpen] = useState<boolean>(false);
    const ref = useRef<MenuInstance>(null);
    const buttonRef = useRef<HTMLElement>(null);
    const alignType = align === MenuAlign.End ? "end" : "start";

    const handleMenuChange = useCallback((evt: MenuChangeEvent) => {
        if (disabled) return;
        setOpen(evt.open);
        if (evt.open) handleOpen?.();
        else handleClose?.();
    }, [disabled, handleClose, handleOpen]);

    const handleClick = useCallback((event: MouseEvent) => {
        if (!open) buttonRef.current?.blur();
        event.preventDefault();
        event.stopPropagation();
    }, [open]);

    const renderButton = useCallback(() => {
        const btnIcon = icon == null ? null : {icon};
        const btnLabel = label == null ? null : {label};
        const className = c(
            buttonClass,
            [open, openButtonClass],
            [disabled, css.disabledButton],
            [disabled, disabledButtonClass]);
        return (
            <SzhMenuButton {...tip(tooltip)} className={className}
                           onClick={handleClick} ref={buttonRef}>
                {btnIcon}{btnLabel}
            </SzhMenuButton>
        );
    }, [buttonClass, disabled, disabledButtonClass, handleClick,
        icon, label, open, openButtonClass, tooltip]);

    const renderChildren = useCallback(() => open && children &&
        <BlurUnderlay show={true}
                      className={css.itemsContainer}
                      children={children}/>, [children, open]);

    useLayoutEffect(() => {
        ref.current?.closeMenu();
        setOpen(false);
    }, [disabled]);

    return <SzhMenu instanceRef={ref}
                    children={renderChildren()}
                    menuButton={renderButton()}
                    onMenuChange={handleMenuChange}
                    className={disabled === true ? css.disabledMenu : undefined}
                    align={alignType}
                    gap={1}/>;
};

Thanks for providing the sample code.
I have to point out this is not the intended way to consume this menu library in general and the code promotes some anti-patterns we do not encourage.
The  <Menu/> manages an internal state to indicate whether it's open or not. The code tries to copy this internal state into another local state (open) by listening to the onMenuChange. At the time when the internal open state becomes true, the menu will compute position, but the locally-copied open state is not true yet. So there is nothing to be positioned as the children is conditionally rendered based on the local state open.
The code worked in v4.2.0 because we had a re-position logic in response to menu resizing which corrected it anyway. However, this was never an intention here as the menu has not been resized in this case. In v4.2.1 we refactor the logic to run re-position only when the internal open is true. Therefore the above code could miss both the position opportunities.
I would recommend using the ControlledMenu if your use case relies on the open state. However, as you have already gone so far the smallest refactor would be using the render prop which exposes the internal state from the menu.
    const renderChildren = useCallback((props) => props.state !== 'closed' && children &&
        <BlurUnderlay show={true}
                      className={css.itemsContainer}
                      children={children}/>, [children, open]);

- children={renderChildren()}
+ children={renderChildren}

Thank you very much for the details and the suggested fix! It worked perfectly.


chore: format intro json

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Why was this not formatted?
Closes #XXXXX

Formatting right now just creates conflicts for everyone who is adding or rearranging the curriculum. I don't think it's worth it.


Support multiple versions for the documentation

The documentation of kobs supports multiple versions now. This means
that a new version of the documentation is published on each commit to
the main branch and for every new tag. The user can then switch between
these version on the documentation site.
For this feature we are using "mike" and the versioning feature of
"Material for MkDocs", see:
https://squidfunk.github.io/mkdocs-material/setup/setting-up-versioning/
Before this commit is merged to the main branch we have to delete
everything from the gh-pages branch except the CNAME file. Because mike
would place the CNAME file in a sub directory we have to create / keep
it manually in the gh-pages branch.
Closes #259.

[x] I added a CHANGELOG entry for this change.
[ ] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #277 (23cf4b5) into main (7534d97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   42.68%   42.68%
=======================================
  Files          93       93
  Lines        7926     7926
=======================================
  Hits         3383     3383
  Misses       4506     4506
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7534d97...23cf4b5. Read the comment docs.

Codecov Report

Merging #277 (23cf4b5) into main (7534d97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   42.68%   42.68%
=======================================
  Files          93       93
  Lines        7926     7926
=======================================
  Hits         3383     3383
  Misses       4506     4506
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7534d97...23cf4b5. Read the comment docs.


Server side live preview is never turned off

Link to reproduction
payload website template
Environment Info
Payload: 3.0.0-beta.91
Node: v20.14.0
next: 15.0.0-canary.104

(Completely new payload website template, used "npx create-payload-app@beta my-project -t website"

Describe the Bug
Hi, I keep getting stuck on the fact that I think live preview seems wonky. If you once use live preview, you will always be served draft versions since next.js draft-mode has been enabled but never disabled.
Am I missing something here? This does seem very prone to having users that will panic because they will think they have published the draft changes.
Other than this, that next.js draft mode is supposed to be used to enable live preview is not at all mentioned in the documentation, it does not even mention that you need to turn on versions in payload.
Reproduction Steps

Login
Edit a page using live preview
Do NOT publish the changes
Logout
Go to the page (and see the draft version)

Adapters and Plugins
No response

So strictly speaking it's not up to Payload to manage next's draftMode in this case so it's a manual task to exit out of it.
As of https://github.com/payloadcms/payload/pull/7991 we now display "exit preview mode" in the admin toolbar when navigating around the site to help you exit draft mode


Flyway freezes when running a non-transactional migration in postgresql

Which version and edition of Flyway are you using?
Tested on 10.7.2 and various 9.x versions.
Works fine on 8.5.13
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
command-line
Which database are you using? (Type & version)
Postgresql 14 via docker
Which operating system are you using?
flyway is being run from Mac OS using Java 21
postgres is being run on Docker Desktop
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
flyway/flyway-10.7.2/flyway -validateOnMigrate=true -table=schema_version -user=postgres -password=xxxxx -url=jdbc:postgresql://localhost:54323/postgres\
 -locations=filesystem:src/main/resources/db/migration\
 migrate

I'm running a set of migrations on a blank db. It's freezing on one migration that has a config file to set it to not run in a transaction:
V21__participant_record_change_primary_key.sql =
CREATE UNIQUE INDEX CONCURRENTLY participant_record_pkey_temp ON participant_record (participant_reference, call_record_id);

ALTER TABLE public.participant_record DROP CONSTRAINT participant_record_pkey;

ALTER TABLE public.participant_record ADD CONSTRAINT participant_record_pkey PRIMARY KEY USING INDEX participant_record_pkey_temp;

V21__participant_record_change_primary_key.sql.conf =
executeInTransaction = false

What did you expect to see?
All migrations complete
What did you see instead?
Flyway OSS Edition 10.7.2 by Redgate

See release notes here: https://rd.gt/416ObMi
Database: jdbc:postgresql://localhost:54323/postgres (PostgreSQL 14.11)
Schema history table "public"."schema_version" does not exist yet
Successfully validated 39 migrations (execution time 00:00.031s)
Creating Schema History table "public"."schema_version" ...
Current version of schema "public": << Empty Schema >>
Migrating schema "public" to version "1 - schema"
Migrating schema "public" to version "2 - schema"
Migrating schema "public" to version "3 - schema"
Migrating schema "public" to version "4 - schema"
Migrating schema "public" to version "5 - schema"
Migrating schema "public" to version "6 - schema"
Migrating schema "public" to version "7 - schema"
Migrating schema "public" to version "8 - add session id index"
Migrating schema "public" to version "9 - peer report alter column types"
Migrating schema "public" to version "10 - add peer report created index"
Migrating schema "public" to version "11 - add session team index"
Migrating schema "public" to version "12 - add more performance indexes"
Migrating schema "public" to version "13 - create call record table"
Migrating schema "public" to version "14 - alter peer reports add call record id"
Migrating schema "public" to version "15 - create participant record"
Migrating schema "public" to version "16 - alter event add call record"
Migrating schema "public" to version "17 - rename org id col participant record"
Migrating schema "public" to version "18 - add call record id idx peer report"
Migrating schema "public" to version "19 - add participant id idx peer report"
Migrating schema "public" to version "20 - add call record transfer fields"
Migrating schema "public" to version "21 - participant record change primary key" [non-transactional]

It hangs there and doesn't complete.

You might need to set postgresql.transactional.lock to false

How do I set this in a migration-specific config file?
I've tried these variants:
executeInTransaction=false
flyway.postgresql.transactional.lock=false

executeInTransaction=false
postgresql.transactional.lock=false

executeInTransaction=false
transactionalLock=false

executeInTransaction=false
postgresqlTransactionalLock=false

In each case, I get an error like this:
Flyway OSS Edition 10.7.2 by Redgate

See release notes here: https://rd.gt/416ObMi
ERROR: Unknown configuration property: postgresqlTransactionalLock

If I add this as a global setting (e.g. via CLI args) it seems to work, but I'm not sure I want that.

Ok I see. Unfortunately script config files only support a subset of the parameters (listed on this page), and Postgres transactional lock isn't one of them.
Flyway applies the lock for the duration of the migration, i.e. it uses the same lock while executing multiple SQL files so I'm not sure how easy it would be to implement a different kind of lock for one specific file.

Looks like it was changed in 9.12 I think https://github.com/flyway/flyway/issues/3497


Intersect RBP list with lists of SARS-CoV-2 interacting proteins

Once we collect the following:

Lists of human proteins that interact with SARS-CoV-2 RNA or protein (issue #26)
Lists of human RNA-binding proteins (issue #27)

We can then intersect the two lists to find human RBPs that interact with SARS-CoV-2.

Ma'am, I want add into the project.
As I have competed upstream and downstream analysis of SARS-CoV-2 RNASEQ and got annotated peptides and proteins. Now I want to perform following steps to get interaction between SARS-CoV-2 proteins and Human proteins.

Orthology detection - Perform BLAST and reverse BLAST between virus proteins and human proteins to get orthologs ( Virus list may include SARS, MARS, H1N1 etc.)

Find functional conserved domains among ortholog hits of each SARS-CoV-2 protein and human proteins - perform hmm based search into database like pfam.

List common as well as different conserved domains between human and virus.

Structural analysis of conserved domains.


[Review] src/ops/doc-status.md

Files
Primary file to review: src/ops/doc-status.md
Impacted files: N/A
Explanation of need for review
This document establishes the life cycle and approval process for all in-scope documents, and needs to be approved itself in order to take effect. This is the first time the doc has gone up for approval.

Maybe I should learn how to use pull requests...

Yeah, I think pull requests are a better tool for this job. Will reopen as one of those later when I figure them out.


Capture logs generated by non-dockerized apps

As a Developer, I want to access the logs generated by dockerized and non-dockerized apps (e.g. nx serve challenge-registry) in a single place so that it's easier for me to explore logs.

Return to the backlog

Added to Sprint 23.03


Remove HAVE_NETINET_*_H headers

Replace automake-style HAVE_INCLUDE_H compile flags with #if __has_include preprocessor directives.
This PR does so for netinet/*.h  (which should always exist as UNIX standard internet headers, and thus all guards are removed).

[approve ci osx]

There is a check for HAVE_STRUCT_TCP_INFO on line 1296 in plugins/header_rewrite/conditions.cc that I think needs to be HAVE_STRUCT_LINUX_TCP_INFO

Right now that block of code currently does a (¬FreeBSD ∨ glibc) check for the Linux-style tcp_info, and then devolves to the FreeBSD-style tcp_info by default. I've made this more explicit in the latest commit to using the CMake HAVE_STRUCT_LINUX_TCP_INFO define for the first case and adding a new HAVE_STRUCT_FREEBSD_TCP_INFO in the second case.
In doing some research, there's also a macOS tcp_connection_info struct that behaves similarly but that is a future project to implement (and at any rate I am not aware of anyone using macOS in production, just for development).

There are a few checks that look like this:
#if defined(TCP_INFO) && defined(HAVE_STRUCT_TCP_INFO)

Is this redundant? The existence of one should imply the other, unless someone is doing crazy things (and then we should have a redefinition preprocessor warning). If we are willing to accept preprocessor protection, we could remove the HAVE_STRUCT_TCP_INFO CMake build env.
cc: @dragon512  @cmcfarlen


Crash when using comma separators inside enums

local Direction = enum
   "north",
   "south",
   "east",
   "west"
end

/usr/bin/lua5.3: /home/spoonie/.luarocks/share/lua/5.3/tl.lua:1707: attempt to index a nil value (local 'item')
stack traceback:
        /home/spoonie/.luarocks/share/lua/5.3/tl.lua:1707: in upvalue 'parse_newtype'
        /home/spoonie/.luarocks/share/lua/5.3/tl.lua:1783: in function </home/spoonie/.luarocks/share/lua/5.3/tl.lua:1761>
        (...tail calls...)
        /home/spoonie/.luarocks/share/lua/5.3/tl.lua:1845: in function </home/spoonie/.luarocks/share/lua/5.3/tl.lua:1832>
        (...tail calls...)
        /home/spoonie/.luarocks/share/lua/5.3/tl.lua:4992: in function 'tl.process'
        ...spoonie/.luarocks/lib/luarocks/rocks-5.3/tl/dev-1/bin/tl:141: in main chunk
        [C]: in ?

Fixed, thanks for the report! It now reports a proper syntax error
PS: criteria for not allowing , inside enums:

items in ()-lists are comma-separated
items in {}-lists are comma-or-semicolon-terminated
items in end-lists have no separators/terminators


”vault”(service name) and “IP address” should be added to the no_proxy variable(in docker-compose.yml file) for MPS, RPS and Vault containers

”vault”(service name) and “IP address” should be added to the no_proxy variable(in docker-compose.yml file) for MPS, RPS and Vault containers:
It is required when the setup is running in proxy environment.

@bwendlandt-intel Sounds like NO_PROXY env variables need to be set when using a proxy so that local calls aren't routed through the proxy.

@bwendlandt-intel is this issue resolved?

I believe this is outdated with v1.3.0 and the move to Kong/etc.  We have a proxy tutorial/topic in the docs backlog as To Do.  We can look at moving this up in priority.

Sounds good.  Once we have that update in, we can close this issue.


W2Grid: Added possibility to interact with the contextmenu on column header event.

Added possibility to interact with the contextmenu on column header event.
For some context:
I was using the contextmenu event in 1.5 to show a specific menu when right clicking on column header.
In the current state of 2.0 this was not possible anymore.
I tested it by adding a handler through the onColumnContextMenu property as well as with the on('columnContextMenu', ...) method. Works fine in both case.

Looks good. I would only suggest to add documentation for the new method and event.


Update: updateDCVars.tcl

This patch will fix the following issues:

Double runs or logging outputs if more than one Gateway in use
System variable is not created because another object with the same name already exists (now use ID_SYSTEM_VARIABLES)
Too many logging entries (now only create a entry if DC equal or greater 80 %)
Removes unused parts / Code cleaned up

This patch will add:

Checking if Wired-Gateway in use, then create a system variable named "Wired-Status" with the states "online/offline". This will allow as with the RF Gatways to respond via central program if the Network connection of the Wired-Gateway was disconnected

Danke Andreas für diese Anpassungen!


proposal: Go 2: ensure exhaustive struct filling

Proposal in brief
Add a keyword like "exhaustive" to compile-check that all fields in a struct instance creation are informed/filled.
Example and related issue
In the corresponding code:
type foo struct {
  a string
  b string
  c string
}

func main() {
  var f = foo{
    a: "hello",
    b: "world",
  }
  fmt.Printf("%v\n", f)
}

I think there is a danger here (which is not specific to Go, it also exists in C,C++, or many object-oriented langages): "c" has not been filled and will have its default empty string value. It may perfectly be intentional (filling fields is optional and it allows flexibility), but in some cases it may also not be: maybe this "c" field has been added afterwards and the developer may have forgot to correct all corresponding struct creations.
Proposed solutions with examples
1. The proposal is to create a keyword like "exhaustive" which would cause a compilation check that that all fields are filled in
that struct creation statement.
type foo struct {
  a string
  b string
  c string
}

func main() {
  var f = exhaustive foo{
    a: "hello",
    b: "world",
  }
  fmt.Printf("%v\n", f)
}

This code would generate a compilation error: "exhaustive keyword with missing field in struct foo: c"
Of course, this keyword would also be accepted on function calls like any normal statement:
fmt.Printf("%v\n", myFunction(exhaustive foo{a: "hello"}))

2. An even bolder idea: the "exhaustive" keyword on the struct type declaration would forbid any struct creation where a field declaration is missing.
type foo exhaustive struct {
  a string
  b string
  c string
}

func main() {
  var f = foo{
    a: "hello",
    b: "world",
  }
  fmt.Printf("%v\n", f)
}

This code would generate the same compilation error.
3. Another totally different approach: a keyword for "compulsory" fields.
type foo struct {
  a string compulsory
  b string
  c string
}

func main() {
  var f = foo{
    b: "hello",
  }
  fmt.Printf("%v\n", f)
}

Compilation error, not because of "c" which remains optional, but because of "a".
Go 2 language change template
Would you consider yourself a novice, intermediate, or experienced Go programmer?
Intermediate, I don't know.
What other languages do you have experience with?
Perl, C, C++, PHP, Bash, Mysql, and a bit of Java, Javascript, Python
Would this change make Go easier or harder to learn, and why?
Slightly harder but the feature is kinda simple, and optional to use which makes it a less imperative feature to know.
Has this idea, or one like it, been proposed before?
Not found in github issues.
Who does this proposal help, and why?
Developers wanting the most robust code possible.
What is the proposed change?
Please describe as precisely as possible the change to the language.
What would change in the language spec?
Please also describe the change informally, as in a class teaching Go.
(see above).
Is this change backward compatible?
Would break code where the keyword "exhaustive"/"compulsory" is used as a type/variable, but maybe it could be possible to accept it nevertheless and distingish a type/variable from the keyword, depending of the implementation.
What is the cost of this proposal? (Every language change has a cost).
Slightly higher language maintenance.
How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?
Several, depending on implementation.
What is the compile time cost?
Presumably low.
What is the run time cost?
Absolutely none. The binary program generated would be strictly the same provided that compilation passes.
Can you describe a possible implementation?
No. I just assume that it would impact the code that parses the struct statements.
Do you have a prototype? (This is not required.)
No.
Orthogonality: how does this change interact or overlap with existing features?
Interacts with the way struct and declaration works.
Is the goal of this change a performance improvement?
No.
Does this affect error handling?
No.
Is this about generics?
No.

Is this a widespread problem in general? I’m thinking something on the order of types nils or := shadowing variables in an outer scope.

This seems better suited to a static analysis tool than to a language change.  A new keyword seems like a very heavyweight mechanism for a feature like this.

To add to Ian's point, a static analysis tool could simply use struct field tags to see which fields are compulsory, so this is definitely doable without changing the Go language.

If this became a feature, adding a field to a struct would always be a breaking change, since if a single person used this keyword somewhere it would cause it to break. This definitely seems to be better suited to a separate static analysis tool than a language-level feature.

I actually use something like that in unit test. I have a small function that checks (using reflection) if all fields in a struct are set. And it allows me to specify fields for which it's okay to have the default value.
This is possible today and superior to this proposal, because the fields that must be set are defined in unit tests and not globally at the struct definition. Hence, different tests can test different fields.
I use it mostly to check if all protobuf fields are populated in an RPC to detect if the proto definition was changed without a corresponding code update.

Ok, since popular opinon is that it should not cause a language change, and could be in a separate static analysis tool instead, I did implement it here, using go/parser and go/ast:
https://github.com/phrounz/go-parano
As of today it is currently experimental, though.


git ignore .gem

Summary
Adding gitignore for .gem files so they do not accidentally get tracked when the template is used for new test kits

Make sure this gets put in the inferno new inferno-core command first, if it isn't already.  Not seeing an obvious PR on inferno-core for this, but didn't dig too deep.

Can we close this now @Shaumik-Ashraf @rpassas?  Seems like this was brought in the correct way via inferno new?

Closing because this was completed in PR #30


Reduce two steps while cloning project and subprojects

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question
We could reduce two steps inside build-from-github.
+ 2. git clone --recurse-submodules https://github.com/apache/skywalking.git
- 2. git clone https://github.com/apache/skywalking.git
- 5. git submodule init
- 6. git submodule update

So, what do you reckon?

They are same thing to me.

Same thing to me. But more convinient for fresh users.

Maybe both ways in the doc as alternative?

Not bad.

Submit a pull request if you like.

Okay.


shell-image should specify to run as root when it needs it.

Expected Behavior
A default nonroot version of shell-image can pass e2e testing without issues.
Actual Behavior
permission denied setting up PVCs.
@imjasonh brought up a great point about the script: semantics as well, which are probably being run as root due to the choice of default user today, but I have not confirmed.
Steps to Reproduce the Problem
Replace the -shell-image in config/controller.yaml with ghcr.io/distroless/busybox (which is nonroot by default).

FYI this is the shell-image equivalent to: https://github.com/tektoncd/pipeline/issues/4711

Ultimately the goal of this issue is to weaken this wording where root is required:

The shell image must be root in order to create directories and copy files to PVCs.

... to wording where the image must support running as root.

One of the places that must be fixed up is here:
https://github.com/tektoncd/pipeline/blob/80f9ac68e6dd291fe6cb2ad6cabb809084befe2f/pkg/apis/resource/v1alpha1/storage/artifact_pvc.go#L66-L80
Clearly (from the comment) this code dealing with PVCs is one of the key places where the root requirement had originally stemmed from.  I will see if/what else fails when these have an explicit runAsUser: 0 🤞


add docs for csi expansion going beta

Add docs for csi expansion going beta.
Xref https://github.com/kubernetes/enhancements/issues/556

/approve


bigint: Failed to load bindings

Bug Report: bigint: Failed to load bindings
Describe the bug
When running the application, the following error message is displayed:
stderr: bigint: Failed to load bindings, pure JS will be used (try npm run rebuild?).
How to reproduce
Steps to reproduce the behavior:
Install this package and run the provided example from README.
Expected behavior
The application should start without any errors or warnings. I would like to disable or suppress this.
Additional context
Operating System: Windows 11 and Linux
Node.js version: 18.x

Thanks for taking the time to report this @JaneX8!
This is the first time I see that message. I've never seen it on CI (I just checked) and it doesn't happen on my computer either.
Here's a screenshot from CI:

And this is what I get on my computer:
$ rm -rf node_modules/

$ node -v
v18.5.0

$ npm i

added 1193 packages, and audited 1194 packages in 12s

264 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

This appears to be the cause: https://github.com/no2chem/bigint-buffer/issues/31. If so, the solution appears to be to pre-install certain build tools depending on your OS.

No problem. It seems to work properly even with the error showing. I could install the build tools locally however I deploy my functions (obviously without all the dev and build tools) to a serverless platform. Meaning the logging there will continue to contain this error all the time.
Therefore I'd like to find a way to simply disable the thing that causes this or suppress this error.

Unfortunately, other than replacing bigint-buffer, I can't think of anything we can do from this library.
I implemented dnssec-js fairly recently and that was the best bigint/buffer library I could find, but I could've missed a better one or one may have been released since, so if that's the case please let me know and I may consider replacing bigint-buffer with it.
Otherwise, if you want to get rid of the warning I think the best course of action may be to propose a PR to fix https://github.com/no2chem/bigint-buffer/issues/31.


Fixes for Issue #57

In a nutshell, changed outputvalues and outputkeys to be arrays instead of simple_elements.
Updated the test CAT to show how to return the outputs.
If there's some clever way to merge two arrays into a hash, please let me know since that would be prettier code.
Tested the test CAT as well as nested CFT CAT and the "RedShift CFT" CAT in demo.

can you update the readme and changelog?

thanks @MitchellGerdisch btw, looks great

@rshade @MitchellGerdisch the readme prob doesn't need an update since the only change is simple_element -> array.  version up in the changelog to v1.1
also, can you add a long_description to the plugin file to read: "Version: 1.1".  we started adding that after this was published.

Versioning info added to changelog and plugin file.


Light theme ✨

I've tried to reuse CSS variables as much as possible to create the least amount of light theme specific styles as possible. I've also made it possible to create additional themes in the future if wanted. For example, creating a theme that just uses different colors would not be difficult at all.
This work would have been much simpler if CSS had color modifiers...

Also, too small issues I noticed.
The % of your portfolio holdings isn't visible in the dashboard.
Original:

Emphasised:

And the Debug button in the swap modal still has the dark button styles:

Hmm, feels a bit too bright.

Ok.
Good work on refactoring into CSS variables btw. Getting the light theme looking perfect isn't crucial right now. As long as it's implemented for launch and easily tweakable with the vars that's the main thing.
We can get some new visuals done based on this and finalise it at a later date when we're less pressed for time. 👌
One those points in my last comment are resolved I'm happy for this to be merged.

Oh also, two other minor things.
How do you feel about a custom dropdown for the theme selection? The default dropdown styles look good on the light theme but look a bit out of place on the dark theme:

And I think the style changes may have broke the login button in dark mode, I don't remember the "Login" text being dark before:

The % of your portfolio holdings isn't visible in the dashboard.

Fixed

And the Debug button in the swap modal still has the dark button styles:

Fixed

How do you feel about a custom dropdown for the theme selection? The default dropdown styles look good on the light theme but look a bit out of place on the dark theme:

I agree about the control itself, but I think it should be the native menu when opened. Let's preserve the little native feeling we have left when possible.

And I think the style changes may have broke the login button in dark mode, I don't remember the "Login" text being dark before:

That's an intentional change. Dark mode has so much white text on black background, I think this makes it look more interesting and make the main button stand out more.

Looks great.

I agree about the control itself, but I think it should be the native menu when opened. Let's preserve the little native feeling we have left when possible.

👌

Travis failing is unrelated to this PR. Seems to be some kind of race issue with Babel plugins.


Fix use of =~ operator

Amends PR #62, to fix a mistake in the use of =~ operator.

released: https://rubygems.org/gems/sensu-plugins-rabbitmq/versions/3.1.1


add pytorch-playground please

pytorch-playground: Base pretrained models and datasets in pytorch (MNIST, SVHN, CIFAR10, CIFAR100, STL10, AlexNet, VGG16, VGG19, ResNet, Inception, SqueezeNet)
You can put it in the Tutorials & Examples section.

Thanks!


cannot make nitcorn to listen on any interface/vhost

I cannot serve in the lan using only IP adresses :(

@jpcaissy Can you give us your insight about this one since you know the codebase?


Adds search and filters to the app library

closes issue #2

Do you like to  add "Widget" ?

Wow, this is awesome - thanks for all your work on this! I'll merge it in now and add the widget one :)


Update strings.xml

Hey, improve Russian text grammer

Hi! Check this Poker KinG-Texas Hold'em app, it is just awesome!
It is free and you get starter bonus in the beginning, I've played it a
while.Click on link below to visit application page in the Android market
and you'll receive up to free chips after installing it .
Don't forget to add me as friend, there's much more fun we playing
together!
Android : http://www.poker-king.me/android_market.php
iPhone : http://www.poker-king.me/ios.php
Miss you here ;)


on player kills player , fires multiple times

Video: https://www.youtube.com/watch?v=a_EDPEtbj0M
Running Code for Video:
on player kills player in 173pre:
- narrate kill!<context.entity>
- announce <context.damager>
- announce "globalkillMessage"
Screenshot: http://www.bilder-upload.eu/show.php?file=86cf8f-1504092287.png
Running Code for Screenshot:
on player kills player in 173pre:
- announce <context.entity.health>
- announce <context.final_damage>
- announce "globalkillMessage"

Use player death and some logic.
Kills event is an assumption-driven event, and it stops working when a plugin or script modifies the damage values.


fix: anyOf/oneOf missing properties for intersection/inheritance

This adds these scenarios as specific cases in KiotaBuilder.CreateModelDeclarations. Not sure if this is the best place to handle this but at least this fixes the issue where the properties & possible inheritance were completely missing while not breaking anything existing.
Fixes #5921

@microsoft-github-policy-service agree

Looks like there were some formatting issues which caused the build to fail, I have now fixed those.
For some reason the OpenApiSchemaExtensionsTests did not report any issues locally when running dotnet format --verify-no-changes but I assume it might be because of the collection expressions preferring newlines before brackets & braces because the examples I copied had worked previously.


crossingsRemoved gets confused by coincident points

Without detracting from your success with #81,  I discovered a case that still fails with that patch:
path.components.map { $0.curves } =
[[BezierKit.LineSegment(p0: (100.0, 585.0), p1: (100.0, 585.0)), BezierKit.LineSegment(p0: (100.0, 585.0), p1: (225.0, 585.0)), BezierKit.LineSegment(p0: (225.0, 585.0), p1: (100.0, 680.0)), BezierKit.LineSegment(p0: (100.0, 680.0), p1: (100.0, 585.0))], [BezierKit.LineSegment(p0: (260.0, 392.0), p1: (260.0, 585.0)), BezierKit.LineSegment(p0: (260.0, 585.0), p1: (160.0, 680.0)), BezierKit.LineSegment(p0: (160.0, 680.0), p1: (260.0, 392.0))]]
path.crossingsRemoved().components.map { $0.curves } =
[]

Looks like:

The bugaboo is that we have two points sitting atop each other at (100,585). There is no value of the discriminant that will cure this problem (so it deserves to be considered a distinct issue, I think).
In this case the “crossing” has zero area, so the “removal” (based on behavior of other crossing-removal algorithms I’ve used) should mean that the coincident points are collapsed into a single point.
For that matter, there doesn’t even need to be an actual geometric overlap for the operation to fail. A simpler example:
path.components.map { $0.curves } =
[[BezierKit.LineSegment(p0: (290.0, 467.0), p1: (290.0, 467.0)), BezierKit.LineSegment(p0: (290.0, 467.0), p1: (394.0, 467.0)), BezierKit.LineSegment(p0: (394.0, 467.0), p1: (290.0, 579.0)), BezierKit.LineSegment(p0: (290.0, 579.0), p1: (290.0, 467.0))]]
path.crossingsRemoved().components.map { $0.curves } =
[]

@mbutterick this is definitely a distinct issue, thanks for opening it.
I'm undecided whether the output of the second should be equal to the input, or have the duplicate point "collapsed". But it definitely shouldn't be doing what it's doing now ...

@mbutterick this is definitely a distinct issue, thanks for opening it.
I'm undecided whether the output of the second should be equal to the input, or have the duplicate point "collapsed". But it definitely shouldn't be doing what it's doing now ...

Sure, I can work around it. FWIW as a longtime consumer of Béziers I would vote for optimizing the contour by removing extraneous points that add no information to the curve (especially because crossingsRemoved is already changing the topology of the curves)
When composing operations on Béziers (like Boolean operations or affine transformations) it’s possible to inadvertently create situations with overlapping points. If the path optimization doesn’t happen automatically, these little errors can cause unintended consequences downstream (“hey, why are there 200 points piled up here?!”)
For instance, her’s another example that is benign but not optimal: these two rectangles share an edge. crossingsRemoved correctly merges them into one contiguous area, but leaves behind two collinear points on the long edges. If I were to pass this to other Bézier operations hoping it would behave as a rectangle — let’s suppose I rotate it and scale it and rotate it some more — I might be surprised when rounding errors move the middle points out of alignment, resulting in “dents” in my supposed rectangle.

Sure, I can work around it. FWIW as a longtime consumer of Béziers I would vote for optimizing the contour by removing extraneous points that add no information to the curve (especially because crossingsRemoved is already changing the topology of the curves)
When composing operations on Béziers (like Boolean operations or affine transformations) it’s possible to inadvertently create situations with overlapping points. If the path optimization doesn’t happen automatically, these little errors can cause unintended consequences downstream (“hey, why are there 200 points piled up here?!”)
For instance, her’s another example that is benign but not optimal: these two rectangles share an edge. crossingsRemoved correctly merges them into one contiguous area, but leaves behind two collinear points on the long edges. If I were to pass this to other Bézier operations hoping it would behave as a rectangle — let’s suppose I rotate it and scale it and rotate it some more — I might be surprised when rounding errors move the middle points out of alignment, resulting in “dents” in my supposed rectangle.

You've given me things to think about.
I'm glad that the case of collinear edges is actually working for you :). It took some special care to make sure that it would work at all!

You've given me things to think about.
I'm glad that the case of collinear edges is actually working for you :). It took some special care to make sure that it would work at all!


haxe: 3.4.6 -> 4.2.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

neko 2.2.0 -> 2.3.0 is required

https://github.com/HaxeFoundation/haxe#version-compatibility

@ofborg build google-drive-ocamlfuse

Please split up your updates into individual commits, i. e. the extlib update shouldn't be squashed together with the haxe update
The extlib breaks quite a few things, see #110374 for a discussion of the problems. Not sure if the situation has changed and we can update extlib without breaking stuff.

Please split up your updates into individual commits, i. e. the extlib update shouldn't be squashed together with the haxe update
The extlib breaks quite a few things, see #110374 for a discussion of the problems. Not sure if the situation has changed and we can update extlib without breaking stuff.

This was the last thing that was said in that issue so that's what I did.
https://github.com/NixOS/nixpkgs/pull/110374#issuecomment-777062907

Other packages are broken by extlib 1.7.8 we also need to care about. See the linked PR for a discussion of possible solutions. It seems we may need to keep to versions around after all if haxe 4.2.1 can't be made to work with a (patched) version of extlib 1.7.7.

Other packages are broken by extlib 1.7.8 we also need to care about. See the linked PR for a discussion of possible solutions. It seems we may need to keep to versions around after all if haxe 4.2.1 can't be made to work with a (patched) version of extlib 1.7.7.

Would you trigger those packages so I can see?

Would you trigger those packages so I can see?

In nixpkgs only google-drive-ocamlfuse, it seems.
My suggestion would be to add extlib 1.7.8 as a separate attribute for now and leave it as is until upstream sorts out their next release which should include a proper compatibility layer for the stuff that is currently broken (see https://github.com/ocaml/opam-repository/pull/17999).

It’s in PATH, so not necessary.

On 16. Mar 2021, at 18:20, zseri @.***> wrote:

@zseri commented on this pull request.
In pkgs/development/ocaml-modules/luv/default.nix:

@@ -0,0 +1,21 @@
+{ lib, buildDunePackage, fetchurl, ctypes }:

+buildDunePackage rec {

pname = "luv";
version = "0.5.6";
useDune2 = true;

src = fetchurl {
url = "https://github.com/aantron/luv/releases/download/${version}/luv-${version}.tar.gz";
sha256 = "119nv250fsadvrs94nwzk7qvlwr0kvcpkbwcmfkh13byg8nhkn1m";
};

shouldn't file be ${file}/bin/file instead?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@locallycompact I've dabbled around with your PR today and managed to redo it so there's no issue with extlib and we don't need to remove the old compilers just yet: #116953 Mind testing / reviewing?

@sternenseemann Not at all, thank you very much. I was about to. :)

Superseded by #116953.


Allow gestureRecognizerSwiped to be overridable

I think it would be useful to allow custom behaviour for user swipes on the elongation cells.

@Jauzee Any chance to get this merged?

Sorry for the delay. You changed access level of this method in subclass. It must be changed in supeclass SwipableTableViewController.
@v-ken can you please explain what is the purpose of overriding this method?

@Jauzee I think it's useful for users to decide the behaviour of the swipes. E.g. I use it to collapse the cells but not to present the detailed view controller.
Should I make the changes in SwipableTableViewController instead?

@v-ken I think it's be better to extend ElongationConfig and add cellSwipeAction like these actions.
Can't promise you that I'll do this soon, but you can try. It would be very helpful.


When exiting without opening; terminal is not clean

Hi, when I exit from fast-p using Ctrl+C or Esc, the terminal leaves debug/help message from the open command. I am using the x86_64 MacOS binary.
How to reproduce:

Run p
Exit using Ctrl+C

Can you confirm that adding the flag -r to the xargs command as in https://gist.github.com/bellecp/3988323c4cbfdfdce4eaf2121b4dfa67/revisions#diff-85cf9b51417c7cfb8766aa6b56f7edb9 does fix the issue?

Indeed it does!
Thanks!
--
https://raivivek.in
On Mon, Jul 30, 2018 at 10:41 PM, bellecp<EMAIL_ADDRESS>wrote:

Can you confirm that adding the flag -r to the xargs command as in
https://gist.github.com/bellecp/3988323c4cbfdfdce4eaf2121b4dfa
67/revisions#diff-85cf9b51417c7cfb8766aa6b56f7edb9 does fix the issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bellecp/fast-p/issues/6#issuecomment-409035581, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADEcuV5Yv-KpX6wNjqpB0x6vqLM7wEHLks5uL4u0gaJpZM4Vm5pU
.


Feat: Actions workflow to publish package to GH

What
Actions workflow to publish a new package to GH Packages every time a version is bumped.
Why
So packages in the internal registry and in GH Packages have the same versions

Coverage remained the same at 51.648% when pulling 022f667de706878234d6d941ab0fcda75ae635a7 on feature/actions-version-check into 65527d0b8c6cdba4dea77d7b9870ad83da423650 on master.


#236

Hey @Its-Aman-Yadav ,
Once again checked and fixed all the conflicts. Please check and merge.

It is a separate branch check now. @Its-Aman-Yadav

We can now merge it. @Its-Aman-Yadav

Why am I not shown in the contribution list? Please approve and accept the merge @Its-Aman-Yadav

I have merged your prev PR after fixing conflicts
Thank you, I am closing this PR


Makefile: make sure that make test-all really runs all tests

The current make test-all will only run tests under test/. This is no longer the only place we have tests so update the code to just run pytest to collect all tests.

Had to repush because our unittest gating has changed (which is totally my fault!)


[feat]

Is your feature request related to a problem? Please describe.
The description on how to set up docker container at (https://zwave-js.github.io/zwavejs2mqtt/#/getting-started/docker) allows anyone in the network to control Z-Wave WS Server.
Describe the solution you'd like
If the service connecting to Z-Wave WS Server is on the same host as the Z-Wave to MQTT container, then the docker command to run the Z-Wave to MQTT container can stipulate to only allow connections coming from the localhost.  This is a lot safer then allowing connections from anywhere on the network.  This is done by changing:
-p 3000:3000
to
-p <IP_ADDRESS>:3000:3000
Please consider adding that information to documentation at the URL above.
Describe alternatives you've considered
Another option would be using iptables on the host, but the option above is much simpler.
Additional context
NA.

Eh, there are lots of different ways to secure containers and we generally don't weigh into that. The UI isn't even password protected by default so I'm not sure what the WS really exposes beyond that. I'm also not sure that we can assume its coming from localhost, as many people address the container using their device IP from within the integration and what this is really doing is binding to <IP_ADDRESS> instead of <IP_ADDRESS>.
I'll meet you partway. I added a note to the bottom.

Sounds great.  Thanks.


connection refused

I'm running a Go2 Pro at firmware v1.0.22. I've obtained an accessToken via curl to the /login/email endpoint and have the go2-webrtc web app running. I provide the accessToken and the IP address for the robot in the interface.
However, any attempt to connect to the Go2 fails. I can ping the robot at its IP address, but I get a connection refused error when clicking Connect.
Added /home/awmartin/workspace/go2-webrtc/python to sys.path
Serving on port 8081
<IP_ADDRESS> - - [08/Dec/2024 17:35:42] "GET / HTTP/1.1" 304 -
ERROR:root:An error occurred: HTTPConnectionPool(host='<IP_ADDRESS>', port=9991): Max retries exceeded with url: /con_notify (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7d39f2c58da0>: Failed to establish a new connection: [Errno 111] Connection refused'))
----------------------------------------
Exception occurred during processing of request from ('<IP_ADDRESS>', 53750)
Traceback (most recent call last):
  File "/usr/lib/python3.12/socketserver.py", line 318, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python3.12/socketserver.py", line 349, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python3.12/socketserver.py", line 362, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.12/http/server.py", line 672, in __init__
    super().__init__(*args, **kwargs)
  File "/usr/lib/python3.12/socketserver.py", line 761, in __init__
    self.handle()
  File "/usr/lib/python3.12/http/server.py", line 436, in handle
    self.handle_one_request()
  File "/usr/lib/python3.12/http/server.py", line 424, in handle_one_request
    method()
  File "/home/awmartin/workspace/go2-webrtc/javascript/./server.py", line 75, in do_POST
    response_data = go2_webrtc.Go2Connection.get_peer_answer(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/awmartin/workspace/go2-webrtc/python/go2_webrtc/go2_connection.py", line 294, in get_peer_answer
    raise ValueError(
ValueError: Failed to receive initial public key response with new method.
----------------------------------------

Ubuntu 24.04. Python 3.12.3. Any insights would be helpful!

it supposed to first try to connect with the old method on port 8081. from the logs it seems it jumped directly to the new firmware method.
can you try this commit tree: https://github.com/tfoldi/go2-webrtc/tree/47f6d54  ?


grid Creator - Web design #309

Created and added the following files to address the issue grid Creator - Web design
modules/grids/grid_309_by_Vinay_Kumar_Reddy_V.html

HI @NtemKenyor , Can you please review this PR??

Heartfelt Thanks for Your Contribution to Our Open Source Project!
            Dear @VinayReddy-vr,

            I trust this message finds you in good health and high spirits. I am reaching out with a heart full of gratitude for your recent contribution to our open source project. Your dedication has not only elevated the functionality of our project but has also exemplified the collaborative spirit that lies at the core of thriving open source communities.

            A heartfelt congratulations are in order for your exceptional work! Your commitment and expertise have played a pivotal role in the success of our project, and we consider ourselves truly fortunate to count you among our community members.

            I must extend my sincere apologies for the delay in responding to your pull request. Your patience and understanding during this time are immensely appreciated. As our project continues to grow, we acknowledge the imperative need to enhance the quality and response time for contributions. To address this, we've kickstarted a call for maintainers and reviewers who can help us uphold the high standards of our project and ensure swift responses to pull requests.

            Your involvement and insights would be invaluable in this initiative. If you, or someone you know, is interested in taking on a more active role in the project, please don't hesitate to reach out. We firmly believe that with a robust team of maintainers and reviewers, we can elevate both the quality of the project and the speed of our responses.

            On an exciting note, I am thrilled to share that we have activated the sponsorship button for our project. This development allows supporters like yourself to contribute to the sustainability and growth of the project. Your ongoing support, whether through code contributions or sponsorship, is genuinely appreciated.

            Once again, congratulations on your outstanding contribution, and thank you for being an indispensable part of our open source community. We eagerly anticipate your continued collaboration and shared success.

            Best regards,

            Ntem Kenyor K.
            Lead
            Kwickerhub


Restore ability for tests to fail when component initialisation throws

What
Find a way to keep Puppeteer tests failing when they run initAll and an error happen on the page.
Why
We have set up Jest and Puppeteer to fail if an error happen on the page. However, recently, we've updated initAll to catch component's initialisation errors.
A lot of our tests rely on accessing review app pages, which call initAll... so won't throw errors and fail tests if one of the components fail to initialise.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when

[ ] Devise a way to keep tests failing when initAll is called and a component throws during initialisation

I think it's another symptom of our tests relying heavily on the review app. Wondering if the long term fix wouldn't be to move them all to renderAndInitialise. Short term, it's probably fine checking for stacktraces in the logs or something similar.

Just an update on this as we've hit a snag
Some tests will instantly start to throw errors 😣
For example, Skip link errors without an element ID matching the hash fragment
This is because our examples are single-component by design, but we could:

Add multi-component previews
Add dummy elements to pass the checks
Add and document known failures (updating tests accordingly)
Prefer initAll() unless testing a custom config or beforeInitialisation() change
Sneakily use different code vs. preview examples like we do for Page template guidance

Ideas 1) and 2) impact both the Review app and Design System previews so we should involve a designer
We discussed this at dev catch-up and will leave it on the agenda