Solve issue with manual select not working

We were having an issue that the manual select wasn't working when we were using streamlit option menu, even when we copied the example in the readme it wasn't working.
We entered the code of the package to understand how it was working and found that the issue was related with the the if statement that checked if the key was None. To have the manual select you need to have the key set otherwise you can't use it.
In this change I removed it, because there is already a check for the on_change which is essential for the manual select.
I also improved the readme to work better with the manual select. I think the change also answers the issue #46.
I haven't tested, but the error I was getting was similar to issue #27 and from the description I think it will solve it as well.

@Joao-Alves
The original code does work (and I'm using it in multiple streamlit apps I've built).
Can you please supply an environment yaml and full code that doesn't work for you? (streamlit version and other things you might have installed?, also what version of the option_menu are you using? )

Hello, the issue I have was similar to this one reported in the streamlit forum. From what they are saying is an issue with the streamlit chat input.
https://discuss.streamlit.io/t/st-chat-input-interaction-with-other-menu-option-component/50354
And they have a video showing the issue.
Here are the versions:

Streamlit - 1.28.2
streamlit-option-menu - 0.3.6

Here is a sample code where you will have the issue:
import streamlit as st
from streamlit_option_menu import option_menu

def main():
  st.markdown("Welcome")

  option_list = ["Q&A", "Summarization", "Compare & Contrast", "Output Parsers", "Admin Panel"]
  manual_select = None

  if st.session_state.get("main_menu", False):
      option_list_option = st.session_state["main_menu"]
      manual_select = option_list.index(option_list_option)

  # menu for document analyzer apps
  summary_type = option_menu(
      None,
      options=option_list,
      icons=[
          "chat-dots-fill",
          "file-earmark-text-fill",
          "zoom-in",
          "table",
          "person-fill-lock",
      ],
      menu_icon="cast",
      manual_select=manual_select,
      orientation="horizontal",
      key="main_menu",
  )
  summary_type

  if summary_type == "Q&A":
      st.markdown("Page 1")
  st.chat_input("Enter your message here")

if __name__ == "__main__":
  main()

https://drive.google.com/file/d/14g8wzRlWvRTzaDl4LTuGCG05O6-15GY1/view?pli=1 - Link for the video

Hello,
I was trying to do a deep dive to see why it wouldn't work on your machine, and I found a bug in my copy and pasted code here to the issue. You need to add a tab on the st.chat_input.
The bug occurs when the chat input widget from streamlit is removed from the rendered page. Using my fix the option-menu works well.
Here is the revised code:
import streamlit as st
from streamlit_option_menu import option_menu

def main():
    st.markdown("Welcome")

    option_list = [
        "Q&A",
        "Summarization",
        "Compare & Contrast",
        "Output Parsers",
        "Admin Panel",
    ]
    manual_select = None

    if st.session_state.get("main_menu", False):
        option_list_option = st.session_state["main_menu"]
        manual_select = option_list.index(option_list_option)

    # menu for document analyzer apps
    summary_type = option_menu(
        None,
        options=option_list,
        icons=[
            "chat-dots-fill",
            "file-earmark-text-fill",
            "zoom-in",
            "table",
            "person-fill-lock",
        ],
        menu_icon="cast",
        manual_select=manual_select,
        orientation="horizontal",
        key="main_menu",
    )
    summary_type

    if summary_type == "Q&A":
        st.markdown("Page 1")
        st.chat_input("Enter your message here")

if __name__ == "__main__":
    main()

To ensure I have a stable I am using Poetry and here is my pyproject.toml:
[tool.poetry]
name = "streamlit-option-menu-bug"
version = "0.1.0"
description = ""
authors = ["João<EMAIL_ADDRESS>readme = "README.md"
packages = [{include = "streamlit_option_menu_bug"}]

[tool.poetry.dependencies]
python = ">=3.10,<3.12"
streamlit = "1.28.2"
streamlit-option-menu = "0.3.6"

[build-system]
build-backend = "poetry.core.masonry.api"
requires = ["poetry-core"]

I am also using Edge and Chrome to test this out on Windows. I have also tested with streamlit 1.29.0 and the bug still occurs.

@fgdvir I trust you to make the appropriate decision on this issue. You can merge it as you deem fit (or let me know if you can't do so directly).

@Joao-Alves
Thanks!.
Indeed in the fixed example I got the same issue and your solution seems to fix it . I must say I'm not sure why it behaves this way but since I don't see an issue with this fix I can accept it.
Please fix/revert the README so I can merge your PR

@Joao-Alves
Thanks!.
Indeed in the fixed example I got the same issue and your solution seems to fix it . I must say I'm not sure why it behaves this way but since I don't see an issue with this fix I can accept it.
Please fix/revert the README so I can merge your PR

What is the issue you have with the readme?
I reviewed to make it more seamless to use option list and make it more evident the option we are selecting in session state.

@Joao-Alves  see above issue, I tagged you. the example doesn't work, it yields an error

I reviewed the issue and added a commit. I also think I improved the readme to be more explicit in this case and keep the use case that was there.
@fgdvir what do you think?
If you think the simpler readme is better I am happy to revert both commits.

Thank you for merging.
When do you think it will be available in Pypi the fixed version?

Hi @Joao-Alves @fgdvir, I tested the merged code briefly but the new example code doesn't appear to work. Specifically:

clicking on the fourth menu results in ValueError: False is not in list
The "Move to Next" button doesn't work either.

Additional minor problems:

The new example code is complex and hard to understand, without a clear purpose.
The code isn't properly formatted.

So will have to revert the PR for now.


This should set the transaction status to  in transaction

https://github.com/awslabs/aws-advanced-jdbc-wrapper/blob/0b04bc682742e93c07f43c572f9a53fbf77556f6/wrapper/src/main/java/software/amazon/jdbc/wrapper/ConnectionWrapper.java#L684

This should remain open until fixed

Hi @davecramer, there are a couple workflows where setting transaction status based on setAutoCommit is problematic.

Switching autocommit values within a transaction. For example, you can start a transaction while autocommit is false, then, while in the same transaction, you can call setAutoCommit(true). In this case, even though autocommit is true, you are still in a transaction
While autocommit is on, you can execute "START TRANSACTION". Again, even though autocommit is on, the transaction status should show we are in a transaction until commit is called.

The current implementation for tracking transaction status handles these two scenarios. Admittedly, they seem like strange workflows so whether they follow recommended practices or not is another question. Regardless, since the existing drivers seem to allow this behavior, I believe we should as well.

The spec says this: which suggests otherwise.
NOTE: If this method is called during a transaction and the auto-commit mode is changed, the transaction is committed. If setAutoCommit is called and the auto-commit mode is not changed, the call is a no-op.

Ah okay, thanks for pointing that out, I wasn't aware of that. I'll do some more investigation and get back to you

So it appears that mysql does indeed do some funky stuff but PostgreSQL doesn't https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
Mysql will actually commit the transaction in flight with another begin (most of the time)
The [BEGIN](https://dev.mysql.com/doc/refman/8.0/en/commit.html) statement differs from the use of the BEGIN keyword that starts a [BEGIN ... END](https://dev.mysql.com/doc/refman/8.0/en/begin-end.html) compound statement. The latter does not cause an implicit commit. See [Section 13.6.1, “BEGIN ... END Compound Statement”](https://dev.mysql.com/doc/refman/8.0/en/begin-end.html).

PostgreSQL will give you a warning saying there is already a transaction in process, but does not commit the transaction in flight.

Hi Dave, could you give me more context regarding your last comment? We were discussing whether setAutoCommit should set inTransaction, but your comment seems to be referring to implicit commits. Just want to make sure I'm understanding.
Also, I did a couple tests with the mysql and postgres community drivers switching autocommit while inside a transaction. Both drivers commit the transaction when switching autocommit from false to true inside the transaction, but neither committed the transaction when switching autocommit from true to false. Should they be, given the spec you mentioned?

My last comment is suggesting that it appears there are real differences to the way begin is handled inside a transaction.
As for committing when going from true to false. I don't think there is a transaction that needs to be committed at that point as the are in autocommit mode and every statement is committed.

Gotcha, yeah that's something to keep in mind, thanks!
For committing when going from true to false, what about the case where the user has autocommit on and executes "START TRANSACTION"? I've tested with the mysql and postgres driver and it appears both will let you start a transaction with autocommit on and switch autocommit to false inside the transaction, but neither will commit the transaction in this case

Well the spec also says you shouldn't do that :)
Note: When configuring a Connection, JDBC applications should use the appropriate Connection method such as setAutoCommit or setTransactionIsolation. Applications should not invoke SQL commands directly to change the connection's configuration when there is a JDBC method available. By default a Connection object is in auto-commit mode, which means that it automatically commits changes after executing each statement. If auto-commit mode has been disabled, the method commit must be called explicitly in order to commit changes; otherwise, database changes will not be saved.

Since the drivers are generally not inspecting SQL they have no way of knowing that you have started a transaction so they also have no way to know whether to commit the transaction. The drivers can only control what happens through the API

Okay thanks, just wanted to verify that executing "START TRANSACTION" is not considered valid according to the spec then? That quote you provided seems to clearly say that, for example, users should not execute "COMMIT" since there is a directly corresponding JDBC method: Connection#commit(). However its less clear to me whether that quote is implying "START TRANSACTION" is not considered valid, since there is not a directly corresponding startTransaction() method. I know setting autocommit false is the usual way of doing things though. Just trying to get clarity, thanks!

Right, is "START TRANSACTION" invalid according the JDBC API though? I still can't tell, I can't find anywhere in the spec that clarifies this specific scenario

it's not "invalid" there's just no specific support for using it.

Right, thanks for the clarification. With this in mind it sounds like the driver does not necessarily have to support tracking transactions for the scenario where the user starts a transaction with "START TRANSACTION" or "BEGIN". Perhaps it might be useful to some customers but it sounds like starting transactions in this way is uncommon and not recommended so we might consider simplifying transaction tracking. Does this sound accurate or did I misunderstand?

I think this is accurately summarizes the situation


Month name hiding

After scrolling to Next 2 month and scroll back to first month the name automatically hide.

Integration method.(cocoapods)

Full steps to reproduce. See attached video

Device modal and iOS version.  iPhone 15 Pro, iOS 17.5

Xcode version.  15.4

FSCalendar version. FSCalenda 2.8.3

Yes this happen in the demo project. https://github.com/WenchaoD/FSCalendar/tree/master/Example-Swift

https://github.com/WenchaoD/FSCalendar/assets/49437548/ab5cc31f-c387-4567-9580-0785c6352bc3

I have the same issue on iOS 17.5 and 18, FSCalendar version (2.8.4)
https://github.com/user-attachments/assets/6c8c538d-3eb5-43d8-ba87-51b8aa0f1a59

I also encountered this problem, at present do not know how to modify, xcode16.1, iPhone15

Same issue, solved by hardcoding with hidden default month name replaced by regular label.
Tested on iPhone 15 Pro, xcode16.1, however, couldn't reproduce the issue on the simulator


Url based

Everything functioning as expected
console logs from Looks.jsx and App.jsx
Lighthouse performance dropped from 53 to 41
Increase in SEO and Accessibility from 46 to 70 and 67 to 70, respectively.


Browser support

I'm starting to work on a node.js / javascript implementation using streams as the base abstraction (less elegant than goroutines, but I can see them working).
Other than the websocket support missing, as per #5, are there any specific issues you can see with the browser environment?
Have you considered browserchannel as another option for a fallback?

Discussed with @mcollina a simple protocol which can be used on the Go side and jschan side other than spdy.


Look for multiple identifiers with the same canonical name

We're doing something similar with NameRes in https://github.com/TranslatorSRI/NameResolution/issues/40, but Translator UI uses NodeNorm to choose the canonical name, so if there are cases where multiple identifiers have the same canonical name, there is no easy way for the UI to disambiguate this.
This is an important part of UI disambiguation between concepts.

This is done, although the question of how we can use that information to improve our cliques is still being figured out at https://github.com/TranslatorSRI/Babel/issues/338. I'll close this here and continue working on it there.


[Workspace] Make isResolutionRequired more robust

This cleans up the method and makes it work for some of the edge cases
that were being missed before.
rdar://problem/40507594 swift package resolve doesn't realizes local <-> version requirement changes

@swift-ci please smoke test


Note about BuildBundlerMinifier Nuget package required

fixes https://github.com/dotnet/AspNetCore.Docs/issues/19729

Thank you for fixing this, @damienbod!


The class should have more customization options

The class should let the user define all it's text.
I've created the PR #22 to help with this problem

Thanks for your contribution.


User option cases

To include user option cases.

Implementation for #https://github.com/bitcoin/bitcoin/pull/28408#discussion_r1335714341


Allow to evaluate an expression in printer

It would be great if I was possible to evaluate and print a custom expression using the data available in a printer position. So the following two scenarios are possible:

Evaluate an expression over several values in a given point of the code. Such as (+ a b).
Modify the expression returned by a given form. For example, (select-keys % [:a :b]).

Slack: https://clojurians.slack.com/archives/C03KZ3XT0CF/p1706144050247019

I think this is a nice thing to have.

Evaluate an expression over several values in a given point of the code. Such as (+ a b).
this is tricky to implement if possible at all.

Modify the expression returned by a given form. For example, (select-keys % [:a :b])
this one is imo the way to go

This is currently on master, checkout  https://flow-storm.github.io/flow-storm-debugger/user_guide.html#_printer_tool

This is currently on master, checkout https://flow-storm.github.io/flow-storm-debugger/user_guide.html#_printer_tool

This is awesome! Thank you for adding!


Fix issue with verification of ipv4/ipv6 address.

Description

Not possible to add secondary IPv4 or IPv6 address via UI. Having the following error:
TypeError: $.validator.methods[method] is undefined[Learn More] jquery.validate.js:777:6
check					http://<IP>:8080/client/lib/jquery.validate.js:777:6
element					http://<IP>:8080/client/lib/jquery.validate.js:492:10
onfocusout				http://<IP>:8080/client/lib/jquery.validate.js:300:5
delegate				http://<IP>:8080/client/lib/jquery.validate.js:423:6
dispatch				http://<IP>:8080/client/lib/jquery.js:5182:23
add/elemData.handler 	http://<IP>:8080/client/lib/jquery.js:4991:15
trigger 				http://<IP>:8080/client/lib/jquery.js:8249:11
simulate				http://<IP>:8080/client/lib/jquery.js:8318:7
handler					http://<IP>:8080/client/lib/jquery.js:8352:9

This was caused because of the ipv46address verification implemented in #2773; it was added on the jquery library (mea culpa). After upgrading the jQuery that verification was removed. I fixed by implementing it on the sharedFunctions.js. The same was applied by a customized ipv6 address verificiation that was implemented in the jQuery library.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
After the fix:

How Has This Been Tested?

ping @pbankonier @svenvogel @dhlaluku @wido


Bug Character can jump once under water fixed

Contains
Fixes #3267
How to test
Jump into the water and check that you're not able to jump, neither diving underwater nor swimming above the surface

Can one of the admins please verify this patch?

Hi @Maximetinu and thanks so much for the fix! Just to clarify though, are there are special conditions at all needed to reproduce it? I can't actually replicate #3267 reliably when I'm in water, only when I'm at the very top and get the little "help hop" meant to make you have an easier time to get out from water onto solid land. Which admittedly doesn't make sense when you're not up against a block you can jump on to.
I do recall occasional weird jumping-like behavior, I just can't reproduce it to really test this well before applying the fix. After the fix can you still easily get out of water on to dry land with the "help hop" or does that get disabled too?
By chance are you one of the GSOC student candidates and/or do you have a forum account/intro yet?
@GooeyHub: ok to test

Hooray Jenkins reported success with all tests good!

Hi @Cervator, glad to be of help!
I've been testing and yes, there are a special condition that I have not mentioned. To reproduce it, you must get in the water without jumping, because if you jump just before it starts the swimming/diving mode, then the number of jumps left is set to 0 and it's not possible to jump. But, if you hit the water without jumping, whether by falling or by walking forward, the variable "numbersOfJumpsLeft"is still 1 and you're able to make a jump.
About the "help hop", I am aware that it's not a bug and after the fix it isn't disabled, of course.
And yes, I'm one of the GSoC students interested in working with MovingBlocks. I still don't have a forum account, thus far I've been diving into the code and thinking about the projects, but soon you'll see me over there.


add dubbo-admin-zookeeper

What is the purpose of the change
add dubbo-admin-zookeeper
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #971 (f4ff5f3) into develop (105f12a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #971      +/-   ##
=============================================
- Coverage      21.33%   21.31%   -0.03%
+ Complexity       436      435       -1
=============================================
  Files            149      149
  Lines           4799     4799
  Branches         726      726
=============================================
- Hits            1024     1023       -1
  Misses          3690     3690
- Partials          85       86       +1

Flag
Coverage Δ

unit
21.31% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../mapping/AdminServiceInstancesChangedListener.java
92.30% <0.00%> (-7.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105f12a...f4ff5f3. Read the comment docs.


Setting Graphics x, y values not consistent with first render (pixi.js: ^4.3.0)

Running live here https://alex-wilmer.github.io/pixitest/
https://github.com/alex-wilmer/pixitest/blob/master/src/index.js
I've created 3 Text nodes and 3 Graphics (circles). I'm using the exact same dynamic scale (d3.scaleLinear) to zoom in, and reset on button clicks.
When I click the "zoom" button, the Text nodes behave as I would suspect, expanding to the right a bit, and hitting "reset" puts them back where they started.
The Graphics, on the other hand, jump much further as if it was on its own larger stage, interestingly enough, hitting "zoom" doesn't set them back to their original position, but what seems to be original on this odd larger scale.
let ticks = []

let drawCircles = ({ data, scaleX, scaleY }) => {
  for (let [k, v] of data) {
    let [x, y] = xy(k)

    v.graphic = circle({
      color: 0x123456,
      x: scaleX(x),
      y: scaleY(y),
      r: 4,
    })

    stage.addChild(v.graphic)

    let sx = scaleX(x)
    let txt = text(sx)
    txt.x = sx
    txt.y = 10
    stage.addChild(txt)
    ticks.push({ x, text: txt })
  }
}

let mutateCircles = ({ data, scaleX }) => {
  for (let [k, v] of data) {
    let [x, y] = xy(k)

    // use the exact same scaleX(x) value for graphic.x and text.x
    v.graphic.x = scaleX(x)
    ticks.find(q => q.x === x).text.x = scaleX(x)
  }
}

code that creates the renderer.
https://github.com/alex-wilmer/pixitest/blob/master/src/view.js
I've tried forcing webgl and canvas and get the same behaviour for both.
circle function, nothing fancy here:
https://github.com/alex-wilmer/pixitest/blob/master/src/circle.js
import { Graphics } from 'pixi.js'

export default ({
  color,
  x,
  y,
  r,
}) => {
  let s = new Graphics()

  s.beginFill(color)
  s.drawCircle(x, y, r)
  s.endFill()

  return s
}

Let me know if I can add anything else, or help out in any ways.
oh and if someone can tell me why it's so blurry, that would be great too, thanks.

Hi @alex-wilmer!

Let me know if I can add anything else, or help out in any ways.

Reproducing this in a pen as a minimum verifiable example against the latest dev build will help a lot in isolating this issue.

oh and if someone can tell me why it's so blurry, that would be great too, thanks.

Not seeing any blur - screenshot?

Ok I'll make a pen. Here is what my screen looks like. The "ticks" are Text and circles are Graphics and they are significantly more blurry then normal text to the left

Regarding the blurring - check your browser's current zoom.

Yep, current zoom is normal, sweeping through zoom levels same blurriness across. Checked chrome, canary, firefox nightly all the same

Checked a secondary computer as well, same bluryness as in the screenshot. They're both retina displays, could that be it?

Possibly if you're doing some sort of scaling and/or texture generation.  Clear on my machine where window.devicePixelRatio === 1;

Ok made my codepen http://codepen.io/alex-wilmer/pen/BpaaOb?editors=1010
exact same issue

Clicking reset for me does change stuff;
Init

Reset

Exactly. Why does it do that? I'm mutating the graphics to the exact same x value as when I drew them the first time.
PS I was able to solve the blurry issue via this comment https://github.com/pixijs/pixi.js/issues/621#issuecomment-41161587

The circles are being drawn with an offset x and you don't set graphics.x on init.

This sets graphics.x on init; http://codepen.io/staff0rd/pen/wgvBaw?editors=1010

omgosh offset you say.
Thank you so much!


linux/diagnostic: add check for versioned GCC linkage

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

This complements my other two GCC-on-Linux PRs (#13631, #13633), however
they are both reliant on bottles eventually being (re-)poured.
Let's try to speed that up by returning an error message from brew doctor
whenever a user has formulae installed that would benefit from a brew reinstall.

Review period will end on 2022-08-04 at 13:00:15 UTC.

As before, I still need to test this. But this is the proof-of-concept.

Is this for the scenario where the user doesn't use brew update?

I'll admit to not having thought too carefully about failure modes yet: my motivation is that it would be good to provide as many paths to brew reinstall as possible to minimise breakage.
Something like this (omitting the #core_tap? check) might help for your concern over source-built formulae from https://github.com/Homebrew/brew/pull/13633#issuecomment-1203951369, though.

Review period ended.

Benchmarked:
Before

Command
Mean [s]
Min [s]
Max [s]
Relative

brew doctor
5.248 ± 0.053
5.166
5.328
1.00

After

Command
Mean [s]
Min [s]
Max [s]
Relative

brew doctor
2.915 ± 0.033
2.862
2.957
1.00

This is on a system with about ~430 formulae installed, which is pretty extreme.
This means brew doctor is nearly twice as slow as before, which is pretty bad. OTOH, it didn't take long at all to run before, so it's not too bad in the end.

This means brew doctor is nearly twice as slow as before, which is pretty bad. OTOH, it didn't take long at all to run before, so it's not too bad in the end.

Yeh, I think that's too slow to run for everyone every time 😭.

Running some slightly more comprehensive benchmarks here: https://github.com/carlocab/workflow-test/actions/runs/2805207136/attempts/1#summary-7696068383
One of the runs is still going, but the ones that finished are a bit all over the place.
I'm ok to leave this be for now. We can reconsider it depending on the number of users who report issues that might be helped by this.

I'm ok to leave this be for now. We can reconsider it depending on the number of users who report issues that might be helped by this.

Shouldn't this be handled automatically by brew update? If so, can we check if the setting is set, make this a no-op if so and tell them to run brew update if anything fails? Similarly, we could make it fail the first time we find a single failure rather than getting all the failures from all formulae.

Let's ship this and revert if it's causing issues/too slow.


Add action to auto build debian package

This adds an action to automatically build a debian package and add it to the release tag page every time a new tag starting v* is created.  see here for an example
The action i used also parses the commits and adds them to the release to form a changelog.  personally i think this is useful but im sure there will be other actions that just attach the files if its not desired.
closes #1111

thanks @b4ldr, I'll play around a bit with it on a branch


Avoid memory leak in parameter creation

IBM-Swift/Swift-Kuery-PostgreSQL#8 Rewrite parameter passing to avoid memory leak

Codecov Report

Merging #9 into master will increase coverage by 0.88%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   73.17%   74.05%   +0.88%
==========================================
  Files           3        3
  Lines         205      212       +7
==========================================
+ Hits          150      157       +7
  Misses         55       55

Impacted Files
Coverage Δ

...es/SwiftKueryPostgreSQL/PostgreSQLConnection.swift
73.82% <100%> (+1.29%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea4182...b3e253b. Read the comment docs.


Playlist under Video

Hello i use Firefox 51 and Version 548 and Video is over Playlist
https://dl.dropboxusercontent.com/u/1390692/Bild.png
And some Sound Problems on Videos with Playlist sound is doubel wit 2 seconds delay

It's like only 3posts below.
https://github.com/YePpHa/YouTubeCenter/issues/2360


Can't resolve anything via DNS

Thanks for this awesome project!
Preliminary remark: During the last days I followed up on https://github.com/pires/kubernetes-vagrant-coreos-cluster/issues/74 and cloned your master branch just a few hours ago.
git clone git@github.com:pires/kubernetes-vagrant-coreos-cluster.git
cd kubernetes-vagrant-coreos-cluster
vagrant up
source ~/.bash_profile
kubectl get pods,services,rc

Looks like everything is alright.
Now I spin up a stock nginx and a corresponding service from
https://gist.github.com/reasn/bfbf9425606873b58021 like so:
kubectl create -f https://gist.githubusercontent.com/reasn/bfbf9425606873b58021/raw/6e86a84c26c700c2e47dd5903d5624a1695293cb/svc-nginx.yml
kubectl create -f https://gist.githubusercontent.com/reasn/bfbf9425606873b58021/raw/5906a19ba33eb28cfeb9db088971e4bf5e03907e/rx-nginx.yml
kubectl get pods,services,rc

If I now vagrant ssh node-01 and curl <IP_ADDRESS> (IP of the nginx pod) I get a response from nginx.
Same with the IP of the nginx service.
But if I curl svc-nginx.default.k8s.local curl can't resolve the host.
The same holds if I docker execinto the nginx container (in my case on node-02) and try to ping svc-nginx.default.k8s.local (Chose ping because the nginx stock container has neither curl nor dig).
I could not find out what I might have done wrong.
It seems to me that something with skydns is not working properly.

What's the error when you ping? Services are not pingable but you should have the address resolved. Try nslookup

Thanks for your response!
ping svc-nginx.default.k8s.localinside the nginx-container returns (after a while):
^C--- svc-nginx.default.k8s.local ping statistics ---
126 packets transmitted, 0 packets received, 100% packet loss

That means the resolve worked.
I have no idea why it did work now.
But if I vagrant reloadthings it stops to work (I might have done that before as well, sorry for that. I fixed the description).
If I - after having issued vagrant reload once - do the same ping inside the nginx container again I get ping: unknown host.
To make my checks more comprehensive I also spun up one of our ubuntu machines to be able to use curl and nslookup:
root@rpc-dev-node-5iu2n:/www# curl svc-nginx.default.k8s.local
curl: (6) Could not resolve host: svc-nginx.default.k8s.local

Can confirm, it's the reload, just updated the issue

@reasn thank you for debugging. I'm providing a fix today if work allows!

Wow. Awesome!


Using BERTopic for topic analysis

Description
In this PR we do topic analysis using BERTopic:

we evaluate different models on different datasets (slices of MSE and BH forums);
we then fix a random seed and check the results for specific models and interpret them;

Closes #3
Instructions for Reviewer
Setup
In order to test the code in this PR you need to:

clone this repo: git clone git@github.com:nestauk/asf_public_discourse_home_decarbonisation.git
checkout to the correct branch: git checkout 03_mse_bertopic
Run make install;
Run direnv allow;
Activate the conda enviroment: conda activate asf_public_discourse_web_scraping;
Download spacy model: python -m spacy download en_core_web_sm

Review
Hey @helloaidank, thank you for taking the time to review this PR.
Scripts to be reviewed:
There are a couple of scripts to be reviewed in this PR.

Getters - I had to make changes to the getters, so please check if you think they make sense (this is also a result for changing the way BH data is extracted and stored - in another PR):

asf_public_discourse_home_decarbonisation/getters/bh_getters.py
asf_public_discourse_home_decarbonisation/getters/mse_getters.py

Topic Analysis Pipeline (where the main files to be reviewed live)

asf_public_discourse_home_decarbonisation/pipeline/bert_topic_analysis/bert_params_config.py - config w/ parameters to test - I'm still not 100% happy about I organise the params to test (I don't like it that "text_column" and "filter" are in model_and_additional_params, but there are pros & cons about moving these to data_source_parms.
asf_public_discourse_home_decarbonisation/pipeline/bert_topic_analysis/evaluate_bertopic_results.py - script to evaluate BERTopic and compare results from different runs

Topic analysis utils:

I created a few utils in  asf_public_discourse_home_decarbonisation/utils/topic_analysis_utils.py

Topic Analysis - Analysis scripts:

Feel free to open the scripts in asf_public_discourse_home_decarbonisation/analysis/topic_analysis as notebooks how I ran the topic analysis on specific slices of the data after evaluating different results.

Code to run
Feel free to test asf_public_discourse_home_decarbonisation/pipeline/bert_topic_analysis/evaluate_bertopic_results.py, but perhaps it's best if you comment some of the parms in asf_public_discourse_home_decarbonisation/pipeline/bert_topic_analysis/bert_params_config.py so that you can test it quickly.
Checklist:

[x] I have refactored my code out from notebooks/
[x] I have checked the code runs
[ ] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[ ] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[ ] Appropriate information has been added to READMEs

[x] I have explained this PR above
[x] I have requested a code review

Hi Sofia,
Thanks for doing this work, it's really great to have a visualisation of the evaluation and to double check that nothing too weird is going on with such a stochastic method.
Regarding the analysis scripts, it would be really nice to have them save their outputs to a relevant directory just so I can sense check them for myself.
Let me know what you think!

Thanks @helloaidank. I'll leave the analysis scripts as they are for now, as they are still work in progress. I'll create a final script in a new PR where everything is optimised (i.e. you can use any keywords you want, instead of just HPs, etc) and save all figures to a nice location.

Sounds good! Happy for you to merge :).

hey again @helloaidank ,
In the meantime:

i've fixed that bug that only happened once in a while. Basically, when no topics were found we had 1 less output in our list, but the dataframe where the list was being stored expected the list to have a certain length and sometimes it didn't - hence why the code broke. So instead of dfs, I used dictionaries which are flexible in terms of length. That fixed it;
Also implemented your suggestions;
I removed the commented code about the outliers, I'll add it to a new PR.


2D Array

@Nivedita967 i have solved the problem using c++ #22

Please add some comments in your code :)

@Nivedita967 Okay  I will do it

@Mahindra-7 Also this does not belong to "Arrays - DS" folder. So change the name of folder from Arrays - DS -> 2D Array


Security Analyzer : Extra checks on host users

Moved here from https://github.com/DNNCommunity/DNN.SecurityAnalyzer/issues/15
Originally submitted by @Timo-Breumelhof and extra suggestion from @sleupold

Add a check for host with default credentials (probably out of scope now since there is no longer a default... New installations ask for a SuperUser user name and password)
Warning if there is a user account named host, the warning could suggest to use another username because host was previously very common for the SuperUser
Same as 2 but for the user name admin

Still a valid change?

IMO yes!

IMO yes!


Make FileResourceLoader extends PathResourceLoader and implement security checks

Since #97 was merged, FileResourceLoader is no more and could be replaced with PathResourceLoader + File#toPath(). Only one thing left in FileResourceLoader - index caching, which IMO shouldn't be a part of PathResourceLoader because NIO2 FS might be read-only.
I agree to the terms of the MIT license.

@dmlloyd I hope it's fine that security checks were implemented in the same PR where I replaced FileResourceLoader with PathResourceLoader, one was required for another :)

@dmlloyd thanks for merging!

No problem.  I added a cleanup commit afterwards that you might want to check out.
https://github.com/jboss-modules/jboss-modules/commit/e0c97173f38237ad02265146802155acd9a7e996

@dmlloyd ok, cool, now it's cleaner :)


Test: Fix CIDR/L4 flakes

Due the connectivity test to CloudFlare, time to time this test was not
reliable at all due internet connectivity issues. With this change if
the connection is failing more than one time will fail.
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>Fixes: #5745

This change is

test-me-please

Coverage decreased (-0.1%) to 44.048% when pulling f8160796f1df60252d43462348e16b5816aed2bc on eloycoto:RuntimeCIDRL4 into e2b43dd2e8cf2ede53e5c161bc5cea401c9a9cbe on cilium:master.

test-me-please

test-me-please

test-me-please

@eloycoto does this fix any of the issues in the CI Project? If so can you mark them as having been fixed by this PR?

@ianvernon is already in the commit message ;-)

@eloycoto thanks! I added it in the PR description as well.


Release 3.5.3

This should be the last PR before the release. I'll merge it tomorrow and publish the release if nobody has any comments.
cc @mseri @gasche @thierry-martinez @oandrieu

I don't know if this is the best place to raise this issue, but somehow I think the release for ppx_deriving 4.5 is broken, or rather, doesn't include what it claims.
I downloaded the tarball from https://github.com/ocaml-ppx/ppx_deriving/archive/v4.5.tar.gz and it doesn't have the ppxlib patches.

the 4.5 release follows the pre-ppxlib branch (as is this PR in this repository). Otherwise too many libraries would have to be fixed quite deeply for them to work with OCaml 4.11 if ppxlib were to be mandatory. The next (non-minor) release of ppx_deriving will come with ppxlib however (see master branch)

OK I thought the 4.11 support + ppxlib was done hand-in-hand. I don't know why I got confused here. Sorry for the noise.


Adding Vision Transformer to torchvision/models

🚀 The feature

Adding ViT architecture from this paper: "An Image is Worth 16x16 Words: Transformers for Image Recognition at Scale"
Adding DeiT architecture from this paper: "Training data-efficient image transformers & distillation through attention"

@fmassa @datumbox @mannatsingh @kazhang
Motivation, pitch
Vision Transformer models should exist in torchvision repo because they are good models :)
I'm currently working on this project.
Additional context
We can also consider adding some techniques from the following papers  ^^
For example, adding Conv stem for ViT, see details in "Early Convolutions Help Transformers See Better"
References:
https://github.com/google-research/vision_transformer
https://github.com/facebookresearch/deit
https://github.com/facebookresearch/ClassyVision/blob/main/classy_vision/models/vision_transformer.py
cc @datumbox

Note that DeiT has the same architecture as ViT - it's the same model, only the training setup is different!

Interesting! I was looking at the implementation here
https://github.com/facebookresearch/deit/blob/main/models.py#L20
and found that DeiT model actually inherits the ViT model class.
Does it make sense if I also do this in torchvision?

I believe that having ViT/DeiT in torchvision library would be really useful!
So is anyone else working with the implementation or should I go ahead and create a PR?

@take2rohit Thanks. @sallysyw is working on it at PR #4594.


1271-links-content

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix https://github.com/hlxsites/danaher-ls-aem/issues/1271
Test URLs:
Before: https://main--danaher-ls-aem--hlxsites.hlx.page/us/en/products/microplate-readers/multi-mode-readers
After: https://1271-links-content--danaher-ls-aem--hlxsites.hlx.page/us/en/products/microplate-readers/multi-mode-readers

CANCELLED AS NO LONGER NEEDED


Member variables should follow the mVariableName naming standard

... instead of using _variableName.
I'm sure a simple script could be written to change them all automatically.

I would not go with any of them, it is not necessary if you can write your code in readable English, which is gonna be let by a any IDE with decent syntax highlighting. Also the IDE, will tell you what's a member variable and what it is not.

so i really don't like the hungarian notation (i.e. prefixing with mVariableName). I strongly believe it makes code less readable.
my prefixing with _ has been pointed out as being weird more than once, so i hear ya :). it definitely makes it less readable than not having it at all, but here's my rationale:

i need to be able to immediately identify private variables and methods cause i want to lock down on m apis as much as possible. having the _ prefix is the least intrusive way of doing this imo.
a better solution would be to have the IDE style my public/private members differently (slap on a different color or italicized etc.), but that is currently not possible with IntelliJ's code styles. when that does happen, i will happily remove the _ prefixes.

closing this issue. feel free to re-open if you strongly feel otherwise.


Contenteditable fails

When there is a contenteditable element in the form, clicking on that element to focus it causes javascript errors. This is reproducible in Firefox 44 and Chrome 49.
The error raised is "TypeError: owner is undefined" or similar.
I have a feeling this is due to delegate() in init(), as contenteditable elements do not have a this.form attribute.
Here is an example (sorry I am not smart enough to automate the focus click, that has to be done manually):
https://jsfiddle.net/w3zrrzyk/

I confirm. The delegate method should be changed to work with contenteditable elements.

This was breaking WYSIWYG functionality on a project (same console errors, plus all toolbar buttons took two clicks to trigger).
This was my quick hack of src/core.js to get it working:
function delegate( event ) {
    //var validator = $.data( this.form, "validator" ),
    var validator = $.data( $(this).parents('form')[0], "validator" ),
        eventType = "on" + event.type.replace( /^validate/, "" ),
        settings = validator.settings;
    if ( settings[ eventType ] && !$( this ).is( settings.ignore ) ) {
        settings[ eventType ].call( validator, this, event );
    }
}

The fix doesn't sit right with me, but it seems to work for now (and I'm facing a tight deadline). Hopefully a more robust solution can be pushed through soon.
(In case it's relevant, we're using Trumbowyg as the editor)

Yup, this is an issue. It still occurs if you include contenteditable in 'ignore' and don't even want to validate it.

Could someone confirm that https://github.com/jzaefferer/jquery-validation/pull/1778 fixes this issue?

onfocusout still has problem with contenteditable
Uncaught TypeError: Cannot read property 'replace' of undefined
// source http://stackoverflow.com/a/12254194
function injectTrim(handler) {
 return function (element, event) {
   if (element.tagName === "TEXTAREA" || (element.tagName === "INPUT"
                                      && element.type !== "password")) {
     element.value = $.trim(element.value);
   }
   return handler.call(this, element, event);
 };
}
$("form").validate({
   onfocusout: injectTrim($.validator.defaults.onfocusout)
});


B 18312-multi-move-dashboard(MERGE-AFTER-B18310)

Agility ticket
Summary
This PR introduces the Multi Move dashboard. When the service member logs in they are routed to the multi move dashboard. Had to comment out playwright tests in  playwright/tests/my/mymove
and playwright/tests/my/milmove/ppms because they depend on the Home page.
Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Ensure that the multiMove feature flag is switched on
Log into MilMove as a service member
You should have been routed to the Multi Move Dashboard

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Screenshots

Warnings

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

  Generated by :no_entry_sign: dangerJS against c282694dc2aec289782132fbe7a233c57b8fff1f

Should we still be routed through the customer flow for new service member creation?
I am routed to the new member dashboard if I have an existing profile but still go through new customer profile creation for a brand new service member

If its a new user then they create their profile then get routed to their move dashboard. I think thats a correct flow.

Should we still be routed through the customer flow for new service member creation?
I am routed to the new member dashboard if I have an existing profile but still go through new customer profile creation for a brand new service member

If its a new user then they create their profile then get routed to their move dashboard. I think thats a correct flow.

Ok. After I created the profile and before I entered orders, I was at the MM dashboard. As long as that's intended, I am good with it. At some point we still need to let them enter their orders and shipments but I don't know at what point in the flow we want to route them to the dashboard

Should we still be routed through the customer flow for new service member creation?
I am routed to the new member dashboard if I have an existing profile but still go through new customer profile creation for a brand new service member

If its a new user then they create their profile then get routed to their move dashboard. I think thats a correct flow.

Ok. After I created the profile and before I entered orders, I was at the MM dashboard. As long as that's intended, I am good with it. At some point we still need to let them enter their orders and shipments but I don't know at what point in the flow we want to route them to the dashboard

@danieljordan-caci do you know the answer to this? Do they run through customer profile creation, then hit your new component, and then "Go to move" and continue entering their orders and stuff?

Should we still be routed through the customer flow for new service member creation?
I am routed to the new member dashboard if I have an existing profile but still go through new customer profile creation for a brand new service member

If its a new user then they create their profile then get routed to their move dashboard. I think thats a correct flow.

Ok. After I created the profile and before I entered orders, I was at the MM dashboard. As long as that's intended, I am good with it. At some point we still need to let them enter their orders and shipments but I don't know at what point in the flow we want to route them to the dashboard

@danieljordan-caci do you know the answer to this? Do they run through customer profile creation, then hit your new component, and then "Go to move" and continue entering their orders and stuff?

Nevermind, this does make sense to me after talking with Tevin. They get routed to the new dashboard and will enter orders and shipments for each move.


unable to change component width from  700 to otherwise.

tried your repo. awesome work . been trying to change width for component since my chart is bigger but cannot do it.

never mind found it


[SelectableText widget] Jumpy scrolling when doing long press gesture to select text

Initial Information
Suppose I have a full-height container with only SelectableText widget inside which will fill the height of container. Inside the widget is a long text (for example 6 paragraphs of Lorem Ipsum) so naturally the widget will be scrollable and some text will be obscured.
Sample code:
class Sample extends StatefulWidget {
  Sample ({Key key}) : super(key: key);

  @override
  _Sample State createState() => _Sample State();
}

class _Sample State extends State<Sample> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SafeArea(
        child: Container(
          child: SelectableText(
           ...long text here...
          ),
        ),
      ),
    );
  }
}

Steps to Reproduce
CASE 1

After page finishes building, select a word at the beginning of the text by long pressing it.
Cancel selection by tapping anywhere on the text.
Scroll down until the previously selected word gets obscured (In this case, to max scroll offset).
Select a word by again long pressing it.

CASE 2

After page finishes building, scroll down to max scroll offset.
Select a word by long pressing it.
Cancel selection by tapping anywhere on the text.
Scroll up until previously selected word is obscured (In this case, to min scroll offset).
Select a word by again long pressing it.

Expected results:
The word is highlighted.
Actual results:
CASE 1 and CASE 2
The word is highlighted, but;
Widget gets jumpy and scrolls in the direction of where the initially selected word is located on screen.
Additional Info
Issue only happens when I select a word by long-pressing it. This doesn't happen if I double tap on it.
Issue also happens on SelectableText.rich widget.

Logs

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel unknown, 2.5.0, on Microsoft Windows [Version 10.0.18363.1256], locale en-ID)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Android Studio (version 2020.3)
[√] VS Code (version 1.60.2)
[√] Connected device (2 available)

Any update on this? @chunhtai @HansMuller

I have the same problem. Did you find any solution or workaround? Any update on this? @danagbemava-nc  @chunhtai @HansMuller

@danagbemava-nc  dear the problem does not appear with you because you choose from the first line in the text after that if you select any text from the paragraph the problem does not appear so you can test it in the first run scroll down and select the text from the bottom of the problem it will appear so this is a problem that appears the first time in just run

@burhanaksendir  you can add this parameter (autofocus: true) in SelectableText will solve your problem, I tested that, and work fine ,

@burhanaksendir you can add this parameter (autofocus: true) in SelectableText will solve your problem, I tested that, and work fine , why add autofocus = true to make default selection text and then go to the bottom text and select specific part not jump to top

Thanks, but this does not fix the problem.

@burhanaksendir you can text that
import 'package:flutter/material.dart';
void main() {
runApp(MaterialApp(
home: Sample(),
));
}
class Sample extends StatefulWidget {
Sample({Key? key}) : super(key: key);
@override
_SampleState createState() => _SampleState();
}
class _SampleState extends State {
final loremIpsum = '''
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. A cras semper auctor neque vitae tempus. Eros donec ac odio tempor orci dapibus ultrices in. Faucibus vitae aliquet nec ullamcorper sit amet risus. Id ornare arcu odio ut sem nulla pharetra diam sit. Egestas congue quisque egestas diam in arcu cursus euismod. Leo vel orci porta non pulvinar neque. Sit amet consectetur adipiscing elit duis. Tristique senectus et netus et. Vestibulum mattis ullamcorper velit sed ullamcorper morbi tincidunt ornare massa. Neque vitae tempus quam pellentesque nec nam. Viverra nibh cras pulvinar mattis nunc sed. Lorem dolor sed viverra ipsum nunc aliquet. Justo nec ultrices dui sapien eget mi proin. Vitae elementum curabitur vitae nunc sed. Adipiscing vitae proin sagittis nisl. Egestas egestas fringilla phasellus faucibus scelerisque. Enim nunc faucibus a pellentesque sit amet porttitor. Rhoncus est pellentesque elit ullamcorper dignissim cras tincidunt lobortis.
Orci phasellus egestas tellus rutrum. Fringilla phasellus faucibus scelerisque eleifend donec pretium vulputate sapien. Mattis ullamcorper velit sed ullamcorper morbi tincidunt. Eu sem integer vitae justo eget magna fermentum iaculis. Faucibus nisl tincidunt eget nullam non nisi est sit amet. Pharetra magna ac placerat vestibulum. Est velit egestas dui id ornare. Nunc consequat interdum varius sit. Nunc sed id semper risus in hendrerit gravida. Eu facilisis sed odio morbi quis commodo. Varius quam quisque id diam vel. Velit aliquet sagittis id consectetur purus ut. Varius duis at consectetur lorem donec massa sapien faucibus et. Eget mauris pharetra et ultrices neque ornare aenean. Suspendisse sed nisi lacus sed viverra tellus in hac habitasse. Bibendum est ultricies integer quis auctor elit sed. Massa sed elementum tempus egestas sed sed. Quisque non tellus orci ac auctor augue mauris.
Id ornare arcu odio ut sem nulla pharetra. Aliquam ut porttitor leo a. Facilisis sed odio morbi quis commodo. Urna et pharetra pharetra massa massa ultricies. Cursus mattis molestie a iaculis at erat. Enim blandit volutpat maecenas volutpat blandit aliquam etiam erat. Nulla aliquet porttitor lacus luctus accumsan tortor posuere ac. Faucibus pulvinar elementum integer enim neque volutpat ac tincidunt. Urna duis convallis convallis tellus id interdum. Rhoncus urna neque viverra justo nec. Cras sed felis eget velit aliquet. Phasellus faucibus scelerisque eleifend donec pretium vulputate sapien nec. Cras tincidunt lobortis feugiat vivamus at augue. Integer feugiat scelerisque varius morbi enim nunc. Sed viverra tellus in hac.
Pellentesque sit amet porttitor eget dolor morbi. Phasellus vestibulum lorem sed risus ultricies. Posuere urna nec tincidunt praesent. Risus feugiat in ante metus dictum. Lacus sed turpis tincidunt id aliquet. Aenean et tortor at risus viverra adipiscing. Morbi non arcu risus quis varius quam quisque id diam. Est ante in nibh mauris cursus mattis molestie a iaculis. Dolor sit amet consectetur adipiscing. Blandit libero volutpat sed cras ornare arcu. Massa massa ultricies mi quis hendrerit dolor. Sagittis eu volutpat odio facilisis mauris sit amet. Posuere urna nec tincidunt praesent semper feugiat nibh sed. Nec ullamcorper sit amet risus nullam eget felis eget nunc. Amet luctus venenatis lectus magna fringilla urna porttitor. Amet consectetur adipiscing elit pellentesque habitant morbi tristique. Odio pellentesque diam volutpat commodo sed egestas. Sit amet purus gravida quis blandit turpis cursus in. Purus semper eget duis at tellus at urna. At in tellus integer feugiat scelerisque varius.
Risus sed vulputate odio ut. Arcu bibendum at varius vel pharetra vel. Arcu cursus euismod quis viverra nibh. Tempor orci dapibus ultrices in iaculis nunc sed augue. Aliquam ut porttitor leo a diam sollicitudin tempor.  Scelerisque felis imperdiet proin fermentum leo vel orci porta non. Et odio pellentesque diam volutpat commodo sed. Tortor vitae purus faucibus ornare suspendisse sed nisi. Id diam maecenas ultricies mi eget mauris pharetra et. Fusce ut placerat orci nulla pellentesque dignissim enim sit. Sed arcu non odio euismod. Tincidunt id aliquet risus feugiat in ante metus dictum. Ac ut consequat semper viverra. Lacus vestibulum sed arcu non. Ipsum dolor sit amet consectetur adipiscing elit ut aliquam.
''';
@override
Widget build(BuildContext context) {
return Scaffold(
body: SafeArea(
child: Container(
child: SelectableText(loremIpsum, autofocus: false),
),
),
);
}
}

@EslamAbotaleb  Thanks, I've tried. You can see the problem in the video.
Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-x64, locale tr-TR)
• Flutter version 2.8.1
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 77d935af4d (5 weeks ago), 2021-12-16 08:37:33 -0800
• Engine revision 890a5fca2e
• Dart version 2.15.1
https://user-images.githubusercontent.com/8548639/150676538-76d5fa2e-4eff-4097-b76f-22c8052206a4.mp4

@burhanaksendir You can change value autofocus from false into true and test again

@EslamAbotaleb I've tried. The result has not changed.
https://user-images.githubusercontent.com/8548639/150677100-f9f85e88-5b91-49c7-a453-20d17a31455c.mp4

@burhanaksendir
https://user-images.githubusercontent.com/50490125/150678494-4eb8fedc-8f1e-4ef2-ad1e-2637e2af3883.mp4

@burhanaksendir https://user-images.githubusercontent.com/50490125/150678494-4eb8fedc-8f1e-4ef2-ad1e-2637e2af3883.mp4

i have faced the same issue here, on a real android device with almost same code.
when you set autofocus=true, it solved the problem that you scrolled to bottom and long pressed then jump to middle. but when position in the top, long press would immediately jumping to middle.

@CPMoviePHil .
Hi,
Unfortunately I couldn't find a way to fix this problem. But the following answer may be a temporary solution:
https://stackoverflow.com/a/70659475

@burhanaksendir
yeah, it's a really bad solution, it can affect the whole project just by changing it.

Any update on this? @chunhtai @HansMuller
or give us some answer that what cause this issue here?

I looked through the git history and found that this problem started after deleting !selection.isValid from condition https://github.com/flutter/flutter/commit/e170ea521cd94da9fbeebf19bd708cbc6d8ee012#diff-49a445da2fd4112ade71a9423b3acffca8d7ffcf694849159f0adb0ed40ba0d5L4066
Same issue: https://github.com/flutter/flutter/issues/84480

Based on this answer https://stackoverflow.com/a/70659475 then the problem starts from here https://github.com/flutter/flutter/pull/75604

https://pub.dev/packages/extended_text seems to work as a replacement for text and selectabletext...

Any updates on this?
The issue seams to be in EditableText, which is used in SelectableText, to "ensure" that selected text is visible, also if the virtual keyboard of the smartphone appears, which is never the case on SelectableText, if it is not editable.
The issue is in the method _scheduleShowCaretOnScreen().

@rgevrek instead of avoiding showing caret on screen when the selection is not collapsed, _scheduleShowCaretOnScreen should probably scroll to reveal the entire selection.

@LongCatIsLooong I see the point, but if the selection is taller than the visible area, you need to display part of the selection based on the direction you are enhancing the selection. Maybe you can use the last touched selection edge as indicator, but in current implementation by enhancing selection, the viewport scrolls in right direction in the enhancing direction.
For a programmatic selection by SelectionController there is currently no scrolling initiated.
Are you intending to scroll automatically, also if a selection is triggered via SelectionController?
This behaviour I would see as a feature or a change, not as a fix, and is currently possible via setting the cursor first, followed by text selection, boths programmatically.

Is there an estimation for a fix?

Is there any chance for fix? I still have the problem. I just saw the contribution for a possible fix (#102270) but it seems to be revoked as I understood the timeline...?

Is there any chance for fix? I still have the problem. I just saw the contribution for a possible fix (#102270) but it seems to be revoked as I understood the timeline...?

The initial fix is revoked from master due to Google internal pipeline errors. @LongCatIsLooong is taking care and would fix.

+1

Still waiting for a fix ....

+1

I can't seem to reproduce this issue on master trying the instructions in the original post.
https://github.com/flutter/flutter/assets/948037/8f0dae09-6e4e-4e38-8edf-673385ec4e58


fix: cross-platform path handling

Add handling for path separator on Windows.
Note: I wasn't able to re-use lspconfig.util.path, since its join() function has been changed recently (backslashes don't work for autocmds).

Thank you!


Learn training content: 2 New Modules

(Issues in ADO were created first, then the GitHub tracking issue, so no reQuest/seQuestered labels here)
Write/code two new learn training modules which will be on learn-pr, handoff for review and approve.  I will create a separate issue for publishing since that requires a bit of overhead on the Learn training platform.
[NEW MODULE] Introduction to .NET web development with ASP.NET Core #296927
[NEW MODULE] Build your first ASP.NET Core app #296928

Associated WorkItem - 322623

Both Modules have received rounds of feedback from stakeholders and have received an approval.
I will track the publishing process in a new issue, however, since it requires a bit of overhead/time.


Alamofire Error: The operation couldn't be completed. Software caused connection abort - iPhone Device

Note: My API call is taking 10 Second to complete their process.

Simply API call using Alamofire
During API call minimize the application and Open application from App Switcher.
Application Stop API call and throw Error: "The operation couldn't be completed. Software caused connection abort"

I want to continue API call when a user minimizes application and lock screen.
Alamofire version: 4.8.0
Xcode version: 9.4.1
Swift version: 3.3
Platform(s) running Alamofire: iPhone 6
macOS version running Xcode: macOS 10.14.3
AlamofireTest.zip

To properly support background transfers on iOS, you either need to use a background session, which Alamofire doesn't really support, or use the UIApplication background task APIs, which are fairly easy, if manual, to use. We have more info in a recent issue.


Implementing julia scoping/capturing by implicit variables

Typechecking of the following code would proceed as following.
let d = ?
let e = ?

function g(f,a)
    # => (g :: {b @ sb1}(f :: {a,b}(a) -> F, a :: (A :@ (2 * (sa1+sa2))))) -> F
  let a = 2*(1+a)
    # => check (2*a): {(a :@ 2) :: A}
    # => new {(a :@ (2 * (sa1+sa2))), (b @ sb1)}
  in f{a,b}(a)
    # => (f :: {(a1,sa1) :: A, (b1,sb1) :: B}((a2,sa2) :: A) -> F)
end
function f(x) :: {(b,1) :: B}((x,3) :: Int) -> B
  b + 3*x
end
b = e
g(f,d)
  # => IFA(g :: {b @ sb1}(f :: {a,b}(a) -> F, a :: (A :@ (2 * (sa1+sa2))))) -> F
  #    , [({(b,1) :: B}((x,3) :: Int) -> B), D] -> G)

there is a problem if we want to check functions without knowing the scope they are applied in. consider this example:
function f(x)
   2*y
end
function f()
   x + y
end
function test()
   f()
end
y = 1
x = 1
test()

if we want to check test, we need to make sure none of its implicit or explicit parameters (hence, f), has any unresolved implicit parameters itself. that can be done by recursively resolving all implicit parameters of all parameters upon application of test(). but we cannot know whether the call of test() is 1- or 2-sensitive in y, as we do not yet know which method of f will be called, so actually resolving would be super cmplicated.
another drawback: we have to deactivate choices that use variables that are not in the scope without removing them from the choice list. an f(x,y) = z choice cannot be taken from the list of choices in case test calls an f with two parameters, but it must yield an error if it is chosen because it uses z which was never defined.

This approach is on hold in favor of #22.


Enable Travis CI

Hi,
I'm seeing .travis.yml in the repo, but it looks like tests don't actually run in CI.
Mind enabling repo in Travis?

Well, you could use brand-new integration, which allows you to restrict Travis access to this repo only if it helps.

@retr0h would this help?

Not something we are going to do.

Sad to hear that

@ssbarnea don't worry, we'll enable it around Oct 29 once it's under @Ansible

@webknjaz I hope you will use GitHub transfer for doing this as this keeps all existing tickets and makes a nice redirec from old location to new location.

@ssbarnea yes, I will be doing that, see https://groups.google.com/forum/#!topic/ansible-devel/U8_Lxg7wAHA

I am really happy to see these changes comming!
BTW, If one of you can have a look at https://github.com/metacloud/molecule/issues/1521 it would be great.

Setting as v2.20 milestone (next release)

Fixed by #1541


[Media Services] Change one of the banner to GitHub Release

We will be releasing Service SDK source code to Github this Sprint 13.4(exit at 5/22). We want to change the first banner linked to GitHub.

@mingfeiy Thank you for raising this issue.  We're closing old issues.  If you feel this issue should remain open, please comment to let us know that the issue should be reopened.


Add /debug/pprof handlers

Those handlers are necessary for profiling and debugging.
https://golang.org/pkg/net/http/pprof/
Let me know if you want this another way.

Hmmm. Is there a way to keep the pprof package from opening the endpoint unless a command line flag is set?

@mholt Yes, there is. There will be problem with Trace though :/ Because it appeared only in 1.5

Alright. And at this time I'm not deploying Caddy with Go 1.5. Will an end user ever use this feature? I think of profiling as something developers do or people who build it from source and can just add that import line themselves.

@mholt Yeah, it's just pretty convenient. We have this in docker. But it's an option to add this lines for development.

I think @mholt is right. I will just keep that code in git stash.


UTF-8 strings get encoded incorrectly

I'm building a universal store project for Windows 8.1 and Windows Phone 8.1.

SQLite for Windows Runtime (Windows 8.1) v. <IP_ADDRESS>
SQLite.Net.Async PCL  v. 2.5.1
SQLite.Net PCL - WinRT Platform v. 2.5.1

I insert data into tables both through ORM objects and through direct requests.
This works fine through ORM or via requests with @params in query, but writing a direct request breaks text encoding.
Is this an expected behaviour? Do I need to encode text somehow?
[Table("Tests")]
public class Test { public string a { get; set; } }

Connection = new SQLiteConnectionWithLock(
  new SQLitePlatformWinRT(),
  new SQLiteConnectionString(
	Path.Combine(ApplicationData.Current.LocalFolder.Path, "test123.db"),
	true
  )
);

Database = new SQLiteAsyncConnection(() => Connection);
await Database.ExecuteAsync("PRAGMA encoding='UTF-8'");

await Database.DropTableAsync<Test>();
await Database.CreateTableAsync<Test>();

// 1: works fine
await Database.InsertOrReplaceAsync(new Test() {
  a = "Through ORM: ЩЫИЯ"
});

// 2: breaks encoding
await Database.ExecuteAsync("INSERT OR REPLACE INTO Tests(a) VALUES ('Via direct request: ЩЫИЯ')");

// 3: works fine
await Database.ExecuteAsync(
  "INSERT OR REPLACE INTO Tests(a) VALUES (@param)",
  "Via direct request w/param: ЩЫИЯ"
);

List<Test> list = await Database.Table<Test>().ToListAsync();

Debug.WriteLine(list[0].a); // Through ORM: ЩЫИЯ
Debug.WriteLine(list[1].a); // Via direct request: ����
Debug.WriteLine(list[2].a); // Via direct request w/param: ЩЫИЯ

I'd think that this is expected behavior, since in case 2, you're explicitly passing a string (which is UTF16), and in other cases, you're letting the library take care of the encoding.
Unfortunately, strings are always represented as UTF16 internally. So there's no way to work around it, unless you're playing with bytes.

I think praeclarum did solve this already with this declaration of Prepare2.
[DllImport ("sqlite3", EntryPoint = "sqlite3_prepare_v2", CallingConvention = CallingConvention.Cdecl)]
public static extern Result Prepare2 (IntPtr db, byte[] queryBytes, int numBytes, out IntPtr stmt, IntPtr pzTail);

And then encode the strings.
public static IntPtr Prepare2 (IntPtr db, string query)
{
            IntPtr stmt;
            byte[] queryBytes = System.Text.UTF8Encoding.UTF8.GetBytes (query);
            var r = Prepare2 (db, queryBytes, queryBytes.Length, out stmt, IntPtr.Zero);
[...]
}

This seems to work just fine.

In Prepare2, why is there this differentiation between NETFX_CORE and non-NETFX_CORE? I think the NETFX_CORE version should always be used as strings are always UTF-16 encoded.
public static IntPtr Prepare2 (IntPtr db, string query)
{
    IntPtr stmt;
#if NETFX_CORE
    byte[] queryBytes = System.Text.UTF8Encoding.UTF8.GetBytes (query);
    var r = Prepare2 (db, queryBytes, queryBytes.Length, out stmt, IntPtr.Zero);
#else
    var r = Prepare2 (db, query, System.Text.UTF8Encoding.UTF8.GetByteCount (query), out stmt, IntPtr.Zero);
#endif
    if (r != Result.OK) {
        throw SQLiteException.New (r, GetErrmsg (db));
    }
    return stmt;
}


input box for filter is not available for input when view is zoomed out

See attached screenshot

It appears that the box is actually there but one needs to know where to click.  I am closing this issue because there is no "fix".


Fixing typo on contractsProperties

Fixing typo on contractsProperties and adding a use case sample

@jordillachmrf Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jordillachmrf Thank you for signing the Contributor License Agreement!


Fix incorrect duration value on android that comes from an audio stream

I didn't have this issue, when there was no audio playback in SkVideo. Now in some videos, the duration is totally incorrect (for example instead of 210'000 ms, it could be 78'123 ms, so no logic or dependency). That caused the issue of video interruption, that was caused, when the current playback time was larger than a "fake duration".
Fixed this locally and tested a lot, works fine.
Issue was (is) only on Android.

@wcandillon I was talking about this one ^^


Should reloader reload empty configuration files ？

Thanos, Prometheus and Golang version used:

thanos v0.5.0

Object Storage Provider:
What happened:
When I add the following test case(case 3) to pkg/reloader/reloader_test.go TestReloader_ConfigApply ，i found that reloader reload the empty cfgFile to cfgOutputFile, so the configuration of prometheus is overwritten by the empty file。
switch rel {
			case 1:
				// Initial apply seen (without doing nothing)

				// Output looks as expected?
				f, err := ioutil.ReadFile(output)
				testutil.Ok(t, err)

				testutil.Equals(t, `
config:
  a: 1
  b: 2
  c: 3
`, string(f))

				// Change config, expect reload in another iteration.
				testutil.Ok(t, ioutil.WriteFile(input, []byte(`
config:
  a: changed
  b: $(TEST_RELOADER_THANOS_ENV)
  c: $(TEST_RELOADER_THANOS_ENV2)
`), os.ModePerm))
			case 2:
				f, err := ioutil.ReadFile(output)
				testutil.Ok(t, err)

				testutil.Equals(t, `
config:
  a: changed
  b: 2
  c: 3
`, string(f))
				// Change config, expect reload in another iteration.
				testutil.Ok(t, ioutil.WriteFile(input, nil, os.ModePerm))
			case 3:
				f, err := ioutil.ReadFile(output)
				testutil.Ok(t, err)

				testutil.Equals(t, `
config:
  a: changed
  b: 2
  c: 3
`, string(f))

What you expected to happen:
In the case 3 above,i expect the final configuration file to remain the same of case 2,but i got ""，so I want to ask if it is reasonable to reload the empty configuration file ？
exp: "\nconfig:\n  a: changed\n  b: 2\n  c: 3\n"

got: ""

How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:

Anything else we need to know:
if r.cfgOutputFile != "" {
    b, err := ioutil.ReadFile(r.cfgFile)
    if err != nil {
         return errors.Wrap(err, "read file")
    }

   // Would skipping empty file execution logic be a good solution？
    if len(b) == 0 {
        return nil
    }
}

I think yes. This is because we want to delegate validation of the given configuration file to the Prometheus itself. This way Prometheus can tell properly signal it via metric and log line and fallback to the old configuration as expected. We are just allowing to watch and reload Prometheus file, nothing more


consider making .tick() reversable / accept negative iterations

This would be a fairly trivial change to:
https://github.com/d3/d3-force/blob/main/src/simulation.js#L39-L61
Reverse the arithmetic operations (+= => -=) and decays to excitements (via 1/x).
Would there be any chance you'd be willing to accept a PR for this change?

https://scicomp.stackexchange.com/questions/36394/time-reversibility-of-velocity-verlet-algorithm

I'm curious about this. Wouldn't it also work by changing the sign of alpha? Could be nice to prototype in a notebook.

As I mentioned, the signs of all arithmetic opreations need to be reversed (addition to subtraction) and the reciprocals of the weights taken and used instead (including alpha).

Can anyone say if a pull request for this functionality would be accepted?

It would certainly be considered! My question about prototyping is also a way to ask how this could be used in a concrete application.

I could imagine the tick being tied to a mouse wheel, up to go forward in time and down to go backward in time. This was our intended use case for a demo animation we are working on.


PRs from Director

I was looking through the PRs for Director.
I would not mind bringing those over to your fork.
Some are kinda old (but they may still be valid).
Wondering if I should work my way down from top (most recent first) and start doing copies of (valid) PRs here?
Really, this should not take long. A lot of these things are simple changes.
What kind of tests do we have setup for Tarantino? Is this documented?

The contributing.md file documents how to run the tests. I have also setup Travis CI.
I've taken a quick look through the existing PR's, but many not in good state.
https://github.com/flatiron/director/pull/300 - IE polyfills should not be added in libraries
https://github.com/flatiron/director/pull/330 - bower is deprecated, just use npm
https://github.com/flatiron/director/pull/267 - I've implemented Rollup instead of Gulp+Browserify
Good PR's:
https://github.com/flatiron/director/pull/334
https://github.com/flatiron/director/pull/331
https://github.com/flatiron/director/pull/307

Awesome, thanks for eyeballing! I'll do those 3 good ones you mentioned. I can do this tonight or over this week/weekend. :octocat:

[x] flatiron/director#334
[] flatiron/director#331
[] flatiron/director#307

Nice work :). I think that is it for now.
I'll look into moving this to a separate organisation soon (need to go back to work now). I'll add you as an admin then too. By making it an org we can assure that even if I would move on, it can live and florish 🌷 . We could consult with Flatiron afterwards to see if they are interested in linking to our repo in the README.

Nice work :). I think that is it for now.

Perfect! Thanks!

I'll look into moving this to a separate organisation soon (need to go back to work now). I'll add you as an admin then too. By making it an org we can assure that even if I would move on, it can live and florish 🌷 . We could consult with Flatiron afterwards to see if they are interested in linking to our repo in the README.

No pressure from me. Though, I do think if this did happen, it would help to get people interested. I've done a bit of looking lately, and the state of JS routers is pretty poor. Director/Tarantino is definitely on the top of the heap IMO.
I'm totally down to help out though, so let me know if I can help with anything to get the ball rolling. :)
Thanks again dude!


Couldn't download IntelliCode model.

Issue Type: Bug
I get the following error when attempting to download IntelliCode models:
Could not retrieve data from Experimentation service: Error: read ECONNRESET
Acquiring model 'intellisense-members' for python
Querying IntelliCode service for available models.
Couldn't reach service Error Message: tunneling socket could not be established, cause=Client network socket disconnected before secure TLS connection was established, (Error)
Could not reach the IntelliCode service. Checking the local model cache.
None of the cached models match.
Couldn't download IntelliCode model. Please check your network connectivity or firewall settings. Error Message: tunneling socket could not be established, cause=Client network socket disconnected before secure TLS connection was established, (Error)
No model available for Python, cannot continue.

My proxy settings are correct, everything else is working.
Extension version: 1.2.4
VS Code version: Code - Insiders 1.42.0-insider (9e8c4c247a779cdd1f4f53db963bc6124a28ac2f, 2020-01-30T05:29:34.196Z)
OS version: Windows_NT x64 10.0.17763
Remote OS version: Linux x64 4.15.0-74-generic

Hi!
This seems a lot like a proxy issue, or a firewall perhaps not letting you access our servers.
Could you try it on a different network and see if the problem persists?
Thanks for the feedback!

@osobeso as i have already stated above, my proxy settings are correct, as everything else is working. i can install the extension no problem, i can install other extensions that have non-extension dependencies (e.g. cpptools) no problem, they all work. this one doesn't - so it's something related to this particular extension's way of downloading its dependencies that's at fault here.
how do i debug this issue and see what commands it is generating?

Hi @anatolyburakov
I'm not sure if you also set your VSCode proxy settings to 'override'
If you haven't please do and try again.
You can find how to do that in this thread's comment #4
I'm asking because the error message seems to be the same.
That thread covers the same probem that you're facing.
There are also other ways to download the models, but it requires some extra steps of configuration so let's try first with the Proxy override. But we can follow up with that in case my previous provided solution doesn't work (or if you've already done it).
Again, thanks again for the feedback, and let's hope this get fixed 😄
Oscar.

@osobeso my proxy settings are already on "override".
the "connection issue" is not very descriptive, because nothing else has these "connection issues" (well, LiveShare extension also does, and i would bet that the root cause is exactly the same), and, as i said, the proxy settings are otherwise correct. That means that whatever way you're trying to download the dependencies, it doesn't take proxy settings into account.
I've tried wget-ing the IntelliCode model manually from the target machine, and it worked:
anatoly@xxxx:~/tmp$ wget "https://cdsmprodstg.blob.core.windows.net/models-prod-output/Output_88630A1B4C077752096ECAA576B92C7D3FA1_9BA695AD4C514C32A5D0AC9B02846CD7?sv=2018-03-28&sr=b&sig=EqKpziAF8sBVdPjLyp%2BKPVL%2F3BAstUiAE%2BmWzfSisJI%3D&se=2020-02-05T10%3A27%3A06Z&sp=r"
--2020-02-05 09:57:56--  https://cdsmprodstg.blob.core.windows.net/models-prod-output/Output_88630A1B4C077752096ECAA576B92C7D3FA1_9BA695AD4C514C32A5D0AC9B02846CD7?sv=2018-03-28&sr=b&sig=EqKpziAF8sBVdPjLyp%2BKPVL%2F3BAstUiAE%2BmWzfSisJI%3D&se=2020-02-05T10%3A27%3A06Z&sp=r
Resolving proxy-xxxx.com (proxy-xxxx.com)... <proxy IP>
Connecting to proxy-xxxx.com (proxy-xxxx.com)|<proxy IP>|:<proxy port>... connected.
Proxy request sent, awaiting response... 200 OK
Length: 2401248 (2.3M) [application/octet-stream]
Saving to: ‘Output_88630A1B4C077752096ECAA576B92C7D3FA1_9BA695AD4C514C32A5D0AC9B02846CD7?sv=2018-03-28&sr=b&sig=EqKpziAF8sBVdPjLyp+KPVL%2F3BAstUiAE+mWzfSisJI=&se=2020-02-05T10:27:06Z&sp=r’

Output_88630A1B4C077752096ECAA576B92C7D3FA1_9BA69 100%[=============================================================================================================>]   2.29M  2.48MB/s    in 0.9s

2020-02-05 09:57:58 (2.48 MB/s) - ‘Output_88630A1B4C077752096ECAA576B92C7D3FA1_9BA695AD4C514C32A5D0AC9B02846CD7?sv=2018-03-28&sr=b&sig=EqKpziAF8sBVdPjLyp+KPVL%2F3BAstUiAE+mWzfSisJI=&se=2020-02-05T10:27:06Z&sp=r’ saved [2401248/2401248]

As you can see, there are no "connectivity issues" there - the proxy works, and wgeting the model directly also works. The problem is with the extension.

Thanks for the information provided.
I'm going to do some more research about it, as you mention is probably the way we're calling the services.
I'd assume you are behind corporate proxy settings, this is going to make it a little harder for me to replicate the bug, but if you have any information you could provide to me that would help me create a similar environment it would be really helpful.
Thanks again!

@osobeso i am indeed behind a corporate proxy. I can't offer you anything more, besides the fact that i am running on Windows 10 and using Linux as a remote. both are behind corporate SOCKS5 proxy.
one thing of note here is that technically HTTP and HTTPS proxies are different (they connect to different ports). however, i've tried changing those to be the same, and it had no effect, so it's most likely not the proxy itself that's the problem, but the connection method being in use (maybe something in Node.js itself?).

Do you have the http.proxy or https.proxy VSCode settings configured?
I looked at a similar issue a year ago (https://github.com/MicrosoftDocs/intellicode/issues/93#issuecomment-490389843) where it seemed that VSCode was sending the wrong proxy settings to the remote. (https://github.com/microsoft/vscode-remote-release/issues/213)

@vivlimmsft yes, i do have both set, and env variables as well. they are all set to the same value, as proxy is the same on local and remote system. i also tried fiddling with proxy settings on host and guest, to no avail.
i've just tried explicitly setting a proxy on guest machine (clearing all settings in advance), and it didn't have any effect. however, even absent of proxy settings in VSCode, my env vars are set up properly as well - i have both http(s)?_proxy and HTTP(S)?_PROXY variables set up correctly (on both local and remote).

I had this issue when running on a Windows desktop. Our proxy setup is configured with the login session's kerberos ticket, but I was used to entering my proxy settings manually from linux. Even though my proxy credentials were correct, I saw this error. Clearing out the proxy setting in vscode, allowed it to use the host proxy, and it was able to download.

I had this issue when running on a Windows desktop. Our proxy setup is configured with the login session's kerberos ticket, but I was used to entering my proxy settings manually from linux. Even though my proxy credentials were correct, I saw this error. Clearing out the proxy setting in vscode, allowed it to use the host proxy, and it was able to download.

We don't have auth on our proxy.

Any movement expected on this?

I've also been having the same issue as @anatolyburakov. I'm also behind a corporate proxy/firewall and have all the http proxy variables set etc.
I'm also able to follow the instructions to download the blob here: comment above comment#4. However, creating the json to point the caching somewhere doesn't seem to work - I did change the modified and access times in the json for the files as appropriate too.
I'm absolutely happy to have a manual solution where I just download the blobs myself and point the plugin to them somehow - is there at least updated instructions for that?

IMO this is really an ecosystem-wide problem with Node.js, because it doesn't have a well-defined built-in proxy support. I keep seeing these proxy issues popping up in just about every software package that's ever been built with Node, and everyone seems to have a slightly different partially working proxy implementation. VSCode should really provide its own framework for abstracting away network connections, so that the extensions don't have to care about proxy settings, but apparently no such luck.

tagging @osobeso and @vivlimmsft to respond to @falcomomo 's question on latest instructions and close.

Microsoft should provide a cdn for every static packages related to vscode , in order to cope with network issue in different countries .
For example, github asserts is on s3 which almost of all be blocked in China .

it has been a year since this was reported, any updates?

it has been a year since this was reported, any updates?

Today I faced with the same problem. Yesterday, I opened outbound rules from Control Panel -> Network and Sharing Center -> Windows Firewall -> Advanced Setting -> Outbound Rules. Then I blocked an application's internet connection. ( not vscode or similar. It was an pdf app) and after that I had this problem. Today I solved it with opening Outbound Rules and deleting that rule that I blocked. And problem solved for me. I hope it works for you

I had this problem using the Ssh remote extension and here is how I solved it.
My local machine is a Windows machine. I have a local cntlm proxy executing with my configuration. Remote SSH works flawlessly, downloading extensions using this proxy.
My remote machine is a linux machine. In my .bashrc I set my http*_proxy variables to another proxy. In my terminal, these variables are correctly set, but I don't think that VSCode sees them.
Solution:: In the Remote settings  I configured:

Http: Proxy Support as override
Http: Proxy as my remote http proxy. If I set an https proxy url here, it failed.

Now I can see in the logs that the model is correctly downloaded.

can IntelliCode model support work without internet access ?  My VScode does run within corporate network and we don't have internet access.  And i hope IntelliCode model supports offline installation or works without internet access.

Pinned and leaving this open just in case anyone needs this workaround.

For me accidentally this was set so was unable to read and write either remove this from settings.json of VS Code or else add a read-writable path to store and cache models
    "vsintellicode.modelDownloadPath": "",

As of version v1.3.0, we no longer download models- they are included as part of the extension.


rewrite how to access information on Quartz cron expressions

Unfortunately the version of Quartz we use is so ancient that one must now dig somewhat to find documentation. Staged at http://www.openmicroscopy.org/site/support/omero5.2-staging/sysadmins/config.html.

Good to merge :+1:


I'm call it the Phantom Menace

tl;dr: Hammer sends a Tap event for each TouchEvent and MouseEvent it intercepts from the browser for every touch a user makes on the screen. Solution is to add PreventGhostClicks-like filtering to the domHandler() function that is only active if you are actually using a Touch-enabled device.
Related Issues: #727, #736
Details: So this all started when I was making changes to Angular Hammer to add an option that prevents ghost clicks. And after a really long afternoon of digging, I've finally got an actionable bug report.
For a long time, we have been having trouble handling Tap events when we clicked on a button.  At the top of the app we have a title/menu bar. On the right-hand side of the menu bar we have a button that, when clicked, adds a magnifying-glass-like widget on top of the map. The problem we were having was that when you click on this button, in certain circumstances, two of these magnifying glasses would appear on the screen. So we started looking into this problem.
Here's what the code for the button looked like when we first started exploring this issue. We have a Glyphicon search icon inside of an anchor, and that anchor has two Angular Attribute Directives that use the addMagnifier function to add a magnifier to the UI.

We started by looking at the events that were triggering the addMagnifier function. When we threw in some good-old-fashioned console.log() statements we found that the addMagnifier function was being triggered by both the Tap event and the Click event every time we tapped on the screen. This led me to implement the prevent ghost clicks functionality in Angular Hammer. So after this update our code looked like this.

Even after this fix, we were still getting two calls to the addMagnifier function. When we looked at it again we saw that instead of getting two events from different sources (one from Hammer and one from Angular), we were getting two Tap events from Hammer. And so we dug a bit deeper. We started with our own code, just to be absolutely sure it wasn't us (it wasn't), then moved on to Angular Hammer to make sure it wasn't just the prevent ghost clicks failing (it wasn't). Which led us to Hammer.
We wanted to track events as they made their way through the hammer pipeline. To do this, we added a unique ID to each TouchEvent that came through the Input.domHandler() function, since that's what catches all of the DOM events and pushes them towards various Hammer Recognizers, and we thought we would only be getting TouchEvents. We also added a console.log() to the beginning of the Manager.recognize() to capture the value of inputData, since that is what is actually passed to the registered handlers. Now, when we tapped on the screen we could see that we were only assigning a unique ID to a single TouchEvent, but the Manager was still logging two events from the recognize() function. Upon further inspection, we found that Hammer is capturing the TouchEvent and a MouseEvent (specifically a mouseup) from the browser, transforming them both into TouchInput events, and sending them both to recognizers.
Here's the code to insert into hammer.js to recreate our experiment.

// Insert at line 357 of hammer.js

var uniqueIdCounter = 0;

// Insert at line 375 of hammer.js

if (ev instanceof ) {
  ev.uniqueId = ++uniqueIdCounter;
  console.log('INFO: domHandler captured a TouchEvent', ev);
}

// Insert at line 2191 of hammer.js

console.log('INFO: Manager.recognize handling inputData', inputData);

And this is the issue that we would like to have solved. The solution is some sort of sneeze-guard that:

won't fire two events from a single tap by checking if the TouchEvent and MouseEvent were fired within some threshold (similar to PreventGhostClicks but temporally);
and is only active if Hammer is connected to a device that is Touch-enabled.

To the best of our ability, we have determined that the mouseup event that is eventually passed as the second Tap is firing after the TouchEvent.
For the time being I've implemented my own solution to this problem in a fork. You can view the changes in this commit, but basically I added a filter to only pass TouchEvents through domHandler(). The only reason I can implement this fix is because I can guarantee that our app will only ever be run on Touch-enabled devices (yay contract work!), but I think the solution needs to be more robust long-term. I'm going to keep working on this in my fork and see what I can come up with. Please contact me any time to coordinate efforts.

There's a chance that this is related to the Angular.js execution context/run loop. If it is then it's not your fault, but it might still be a Hammer.js problem to solve.
I'm going to experiment with some stuff in Angular Hammer tomorrow. I'll get post an update (with a fiddle or a pen or whatever tool the cool kids are using these days) once I do some testing.

I don't work on hammer itself, but I'm the author of ember-mobileTouch which uses hammer.  It's probably your run loop or some other eventing, we he a double tap issue / similar issues until we added the click buster.  I also had to take click out of ember's normal eventing, as ember itself was looking for and delegating a click.

That answer is why I think this fix may be best implemented in Hammer. It's not actually a Hammer problem, but it's just way easier if Hammer handles it. And PreventGhostClicks always felt like a short term fix anyway.

+1

@RyanMullins do you use ngTouch simultaneously ? i guess this can cause some headaches.

Closing in favor of #808


GT Item and Treasure Count Fixes

So the seed I rolled to test out the GT item counting literally only had keys, the map, and compass before the big key. This was kind of nagging me a bit, so I decided to check it out, and sure enough tracker was still going into the whole "You got another X item. Y treasures left." before which I think gets in the way of counting. This fixes that.
While doing that, I also found the spot that was causing the issue where Tracker wouldn't announce that there are no remaining items left when using the auto tracking, so I'm fixing that as well.

DigitalBasic ran into an issue caused by clicking the enable profile button when no profile was selected to enable, which caused a null to be added to the profile list. I addressed it in multiple ways to make sure it doesn't try to load null profiles and also fixed it to where it shouldn't add nulls in the first place.


Installation problem in ubuntu 20.04

when using composer require rinvex/laravel-categories
I get the following error
`Your requirements could not be resolved to an installable set of packages.
Problem 1
- felixkiss/uniquewith-validator 3.4.2 requires illuminate/support ^5.5|^6.0|^7.0|^8.0 -> found illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.
- rinvex/laravel-support[v6.1.0, ..., v6.1.1] require felixkiss/uniquewith-validator dev-l9-compatibility -> found felixkiss/uniquewith-validator[dev-master, 1.0.0, ..., 1.1.4, 2.0.0, ..., 2.0.8, 3.0.0, ..., 3.4.2] but it does not match the constraint.
- rinvex/laravel-categories v6.1.1 requires rinvex/laravel-support ^6.0.0 -> satisfiable by rinvex/laravel-support[v6.0.0, ..., v6.1.1].
- rinvex/laravel-support[v6.0.0, ..., v6.0.3] require felixkiss/uniquewith-validator ^3.4.2 -> satisfiable by felixkiss/uniquewith-validator[3.4.2].
- Root composer.json requires rinvex/laravel-categories ^6.1.1 -> satisfiable by rinvex/laravel-categories[v6.1.1].
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
I have the following lines in my composer.json file  "minimum-stability": "dev",
"prefer-stable": true`
I am using PHP 8.1.7 along with laravel 9

Note for Laravel v9
This package requires felixkiss/uniquewith-validator dependency, which is not yet compatible with Laravel v9! However as a temporary workaround, add Laravel Shift's fork to the repositories property of your project root composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/uniquewith-validator.git"
        }
    ]
}

https://github.com/rinvex/laravel-support#note-for-laravel-v9

Update: we dropped the felixkiss/uniquewith-validator dependency 🙂 https://github.com/rinvex/laravel-support/commit/2bf69b8dcbf6f18ecd97c2c7b43ae441d58765cd


TOP Omega Safe Spots callouts incorrect

Similarly to the party synergy callouts on p2, the p5 callout for omega safe spots is now incorrect.

This is a duplicate of #5412.


Dev

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.53%. Comparing base (f36a156) to head (988ec77).
 Consider uploading reports for the commit 46778c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   97.10%   97.53%   +0.42%
==========================================
  Files           1        1
  Lines          69       81      +12
==========================================
+ Hits           67       79      +12
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Wrong result value of ((0&0)-1)

Evaluation of ((0&0)-1) returns 0, but the result should be -1.

Apologies, it seems to be a conversion error in my code, can be closed.


[semantic-arc] Add a flag to SILBuilder called isParsing to allow for SILBuilder to ignore invariants while parsing.

[semantic-arc] Add a flag to SILBuilder called isParsing to allow for SILBuilder to ignore invariants while parsing.
I am going to add asserts to SILBuilder to ensure that the leaf level functions
that create qualified ownership and unqualified ownership instructions assert if
one attempts to create functions with the wrong ownership qualification.
This creates problems in the parser though since we apply the ownership
qualification heuristic to SILInstructions after we have created the instruction
via SILBuilder. I could change the ownership model evaluator to have special
methods for various instructions, but I think that would introduce more
decentralized code in the Parser which I want to avoid. Instead this commit just
introduces a small isParsing flag that is set by SILParser on its SILBuilder
that will cause these invariants to be ignored. Since the bool is used in the
actual asserts themselves they are at the call site where they have an effect,
making it very clear what is going on.
rdar://28851920

@swift-ci Please smoke test and merge


refactor code

Refactor code for

prompt training and evaluation
cross-task and cross-model transfer
activated neuron

Cannot support model.parallel