Download individual album art for each track when using --playlist-numbering

Requested Feature
Title says it all really. I love the --playlist-numbering feature, and I feel it would be even better if I also had the option to see the album art of each individual track when downloading playlists in this way, instead of the album art being that of the entire playlist.
Thank you very much devs and thank you for spotdl.
Possible implementation
No response

Hi, I would like to work on this issue, if you aren't working on it

Hi, I would like to work on this issue, if you aren't working on it

Hi, go ahead. Adding a new cli argument might be the best way to go

Resolved #2204


Fix a class name in test_erfinv

This PR fixes a typo.

Jenkins, test this please.

Jenkins CI test (for commit 9a5ac8a8e7fa9da36cff779583e2b4af10d1ca8b, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Non square images are cropped

Need all formats supported, and a zoom in and out feature using scroll wheel would be welcome too.

Thanks for reporting this, I'll take a look!

Just finishing testing, but it should support all kinds of deranged resolutions now.

It also supports zoom and pan

Hoping to get it tested and out in the next day or so.


Space larger than browser?

Is there a way to render a large format canvas/SVG suitable for later printing?
Canvas has an offscreen option, but there's no way to give it separate dimensions from the on-screen canvas.
For SVG, I tried <svg width="800" height="600" viewbox="0 0 8000 6000">, but the SVGSpace() constructor overrides both the viewport and the viewbox.

Hi @pikeas -- sorry about the late reply. We probably need a better solution for this in future (maybe using NodeCanvas), but for a quick hack, you can set the internal property _pixelScale to scale up the resolution after setup. For example:
Pts.quickStart(...); // or alternatively, space = new CanvasSpace(...).setup(...);
space._pixelScale = 5; // 5x larger

Try it here: https://ptsjs.org/demo/edit/?name=canvasspace.resize
Tip: You can right-click "Save Image..." on the canvas to verify the image resolution.
Hope this helps Thanks for reporting this.

v0.10.7 has implemented a pixelDensity option in setup().
If you need very large image, try this experiment node-canvas implementation here:
https://github.com/williamngan/node-pts-canvas
Closing this issue now. Please reopen if you encounter new issues. Thanks for taking the time to file this issue!


[REEF-638] Passing Mapper Specific configuration in IMRU

This addressed the issue by

introducing interface IPerMapperConfigs that allowes user to specify a list of configurations, one for each mapper.
implementing EmptyPerMapperConfigs that is default for IPerMapperConfigs in case user has no mapper specfic configs
making appropriate changes in IMRUDriver, IMRUClient, JobDefinition and JobDefinitionBuilder
JIRA:
REEF-638

This doesn't merge right now. Also, I left comments on the JIRA.

@markusweimer  I have done the rebase.

@markusweimer  I have done the required changes.

I'll do another pass.

@dkm2110 I've done a pass.

@markusweimer I have made the changes suggested by you.

@dkm2110 Thanks, I will test and merge.


Update .gitignore

Add .DS_Store to ignore file.

Not very sporting considering this is a fairly standard exception in almost all .gitignore files but hey ho.


fix @expensify.sms is copied along with phone number

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/38187
PROPOSAL: https://github.com/Expensify/App/issues/38187#issuecomment-1993276218
Tests

Go to staging.new.expensify.com
Go to any chat
Send a text with phone number mention
Right click on the message > Copy to clipboard
Paste the content in the composer
Verify that: @expensify.sms will not be copied along with phone number

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to staging.new.expensify.com
Go to any chat
Send a text with phone number mention
Right click on the message > Copy to clipboard
Paste the content in the composer
Verify that: @expensify.sms will not be copied along with phone number

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/4d9bcb6d-b39d-4a65-8891-e080fa1540b4

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/b0afa6ef-9721-4cd4-8a56-5d2daa97f925

iOS: Native

https://github.com/Expensify/App/assets/161821005/77cfa5f7-2e71-4239-aef4-2fe257b0aae6

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/97e94abd-9b40-4c4e-940b-4c791f3459d3

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/3bafa9b0-1a36-49db-8434-481088aaf443

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/630b2c46-6bd8-4128-8ff5-f1038d4d8229

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59907218/3a3844ae-70e7-44a2-a8dd-b4c853e2f1dc

Android: mWeb Chrome
https://github.com/Expensify/App/assets/59907218/8f89f104-891b-4537-b124-3fc4cd2b8198

iOS: Native
https://github.com/Expensify/App/assets/59907218/8456e488-e1d1-47cb-8b47-f7247e0e0efa

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59907218/a54150c5-2ebc-4541-b7f4-36444886b425

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/365324bb-209e-4bd4-b130-fb97050cd176

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/9870f15b-1ba8-47c3-853b-5a5130bf3228

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[ConstraintSystem] NFC: Extract PotentialBinding(s) and auxiliary types/logic into separate header and namespace

Add a new namespace - swift::constraints::inference
Place all of the types and logic related to type inference into aforementioned new namespace:

PotentialBinding(s) and auxiliary types
getPotentialBindingFromRelationalConstraint, checkTypeOfBinding etc.

This is a final step in preparation to storing bindings in constraint graph nodes to
avoid re-computation.

@swift-ci please clean test

@swift-ci please clean test

@swift-ci please test source compatibility

@swift-ci please test source compatibility

Build failed
Swift Test OS X Platform
Git Sha - 48afd65ec2a33ddbf4cc8c04a6ee842b99062e07

Build failed
Swift Test OS X Platform
Git Sha - 48afd65ec2a33ddbf4cc8c04a6ee842b99062e07

@swift-ci please test macOS platform

@swift-ci please test macOS platform


[BUG] git stash apply --help shows help text for stash not apply

Needs further investigation.
❯ dart bin/main.dart stash apply --help
Commands for managing a stack of stashed changes.

Usage: git stash <subcommand> [arguments]
-h, --help    Print this usage information.

Available subcommands:
  apply               Apply the stash at the given [stashRef] to the working directory.
  my-custom-command   Save your local modifications to a new stash.

Run "git help" to see global options.

Fixed with commit 79cef6c and will be included with v0.1.0-dev.4.


The "more information" link redirects to a broken page

The More information is available at< link in this article redirects to a broken link :
https://go.microsoft.com/fwlink/?linkid=2116430>
Can we please get this fixed to the correct link?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cfb90783-6580-dcf3-cb44-ff304ee66d74
Version Independent ID: cfb90783-6580-dcf3-cb44-ff304ee66d74
Content: ADMX_sam Policy CSP - Windows Client Management
Content Source: windows/client-management/mdm/policy-csp-admx-sam.md
Product: windows-client
Technology: itpro-manage
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

Tomorrow I will add new link

I commented some of this on the linked PR:
For more info, see Contributing to the CSP reference articles - it explains more.
The link in question exists in the non-editable description that comes from the ADMX. So if I accept your change, it will revert back in a week or so when the automation reruns.
@tomdan-MSFT you should Send feedback to Microsoft with the Feedback Hub app. Making sure to note that the string needs to change in the source ADMX, which is where that policy description comes from. That feedback should go to the engineering team who would need to file a bug to fix the string in the ADMX code.
I can also fix fwlink 2116430 so that it points to https://support.microsoft.com/windows/update-your-security-processor-tpm-firmware-94205cbc-a492-8d79-cc55-1ecd6b0a8022, so that will help as well.
(NOTE: Vinay is out right now, so I don't know if he had something else in mind...)

The fwlink is updated, and as I previously mentioned, feedback otherwise should go to the Feedback Hub for the engineering team. I'm closing this issue.


mobile: Fix the READMEs about running local Android test apps

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @abeyad

/retest


Add support for HF AML model

Describe your changes

Add support for HF AML model
Add bert HF AML model example

Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Format your code by running pre-commit run --all-files

(Optional) Issue link

Question: is HFConfig useful for HF onnx model? How many (and which) attributes in HFConfig can be used on HF onnx model?  (like model_name will be used to fetch tokenizer from HF model hub so model_name is needed)


Use forked gocheck

added support for per-check timeouts (upstream is non-responsive)
set 5m per-check timeout

ping @tiborvass @icecrime @tianon

ah saddness that upstream :(

I see there's also an open PR from @brahmaroutu https://github.com/go-check/check/pull/47 should we include that in our fork?

Oh Go ecosystem :cry:
For posterity's sake, can we enumerate some of the issues we've seen with upstream here?  (perhaps links to PRs that have gone stale?)  That'll be helpful to point anyone asking why we use a fork (or who traces it back to a commit and thus PR), and could also be an OK way to check whether we could consider switching back sometime later.

@tianon Yes, can definitely do that. Unfortunately I'll have to re-create the branch since I managed to push -f a change on it that really should have gone in another branch ( :cry: ). Luckily the changes required for this are rather small other than adding the tests.

Related PR upstream: https://github.com/go-check/check/pull/70 (and the one I mentioned above possibly)

@cpuguy83 oh, I just meant here -- it's pretty easy IMO to trace a commit back to a PR (by going to https://github.com/.../commit/... and clicking the #xxx link), so @thaJeztah's comment is good enough for me :+1:

Updated the PR to list the PRs.

LGTM :disappointed:

Not sure what's wrong here:
15:27:32 can't load package: package github.com/docker/docker: no buildable Go source files in /go/src/github.com/docker/docker

ping @cpuguy83 any idea what those failures are? TL;DR got a lot of WindowsTP4 builds timing out, so wondering if we should up the timeout for those, or if we can get this PR merged soon

I have literally no idea.
Note that experimental also failed just like janky, even though it is marked as successful.

ping @mlaventure perhaps we should up the timeout for WindowsTP4 while we figure out what's wrong here?

This one is a timeout issue.
It looks like the copy of the sources into the container didn't happen for some reason.
But I can see it happening in the log:
04:26:34 Step 50 : COPY . /go/src/github.com/docker/docker
04:26:38  ---> ba1e4201c70f

Yeah, it's super strange and it's only happening on this PR.
Tried rebuilding multiple times... rebasing and pushing, etc.

And win2lin and userns run successfully.

Seems I found the issue. Had to move the check.timeout flag from make.sh to make/integration.
Tests seem to be making it past where they did before.

LGTM

If this works well, I think we should ditch using the suite timeout at all (it doesn't make sense, because we're always adding new tests, it's more important that if a test stalls we fail it after a timeout -- it doesn't matter how long the whole suite takes as long as it doesn't freeze).

@cyphar Really I believe the -timeout option would be per-test, but since we're hijacking a single testing.T in the integration tests it ends up being for the whole suite.
Instead of removing it, we can still set the timeout option so it also applies to unit tests and such.

all :green_heart: again
In order to remove the somewhat duplicated CHECKTIMEOUT (and use TIMEOUT instead), we had to set a super long timeout for the integration tests.
This is because there is no way to disable go's built-in test timeout, which defaults to calling SIGQUIT after 10mins (when -timeout is not set)

LGTM

LGTM

:tada: thanks @cpuguy83


chore(removed logo)

hey i was not sure how to run this project as there are no scripts in package.json i have just updated code as i thought necessary for this can you look into tht and confirm?
closes isssue
https://github.com/OSCA-Kampala-Chapter/react-ui/issues/13#issue-1522226931

hey i was not sure how to run this project as there are no scripts in package.json i have just updated code as i thought necessary for this can you look into tht and confirm? closes isssue #13 (comment)

hey @Pavan-Nambi thank you for pointing out this...i think we should add proper guidelines on how to run the project and where to find anything, let me create an issue for that and we look into it.

@Pavan-Nambi
under the website directory is where we have the documentation that is built on top of docusaurus v2 which uses concepts of react.js so anyone that has done react can just work with it.
to run the  website which also is where are going to be writing documentation....

move into the website directory cd website
install packages using pnpm install
start the development server  pnpm run start which will open your browser at http:localhost:3000

pnpm is a package manger just like npm or yarn

@Pavan-Nambi
under the website directory is where we have the documentation that is built on top of docusaurus v2 which uses concepts of react.js so anyone that has done react can just work with it.
to run the website which also is where are going to be writing documentation....

move into the website directory cd website
install packages using pnpm install
start the development server  pnpm run start which will open your browser at http:localhost:3000

pnpm is a package manger just like npm or yarn

ya i got tht i can just to pnpm i and start but there are no scripts in package.json when i saw..? thats the reason i asked...

and are there any advantages to use pnpm over npm or yarn? i mostly see yarn everywhere npm sometimes
@HassanBahati  just curious on how it differs? and why u preffered it...

having pnpm installed wont mess up your yarn configurations. you can still use yarn in your other projects without any conflicts

having pnpm installed wont mess up your yarn configurations. you can still use yarn in your other projects without any conflicts

ohh got it thankyou!


Hello world

Hello master read me for my problem to investments banking trade I SHALL HAVE My ownerhip accounts us issuer card holder accounts has to be in my profile accounts and my direct share investment they should not put stop to my direct share investment accounts all of my banking investments how do I get out or support my business if not releasing my fund assets or my cash money accounts read me master SHALL I have what's maine

@Ray5254  Please avoid spamming this project.

@alya can we close this issue, to avoid it appearing in the filtered view where contributors look for a possible contribution? 🙏


Experimental feedback - Volume plugins

This is a placeholder issue to collect feedback on the volume plugins experimental feature shipped as part of Docker 1.7.0.

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

I went through docs and got to admit, plugin system looks pretty interesting; haven't tried it myself though. One note I could think of was that I find the API between plugin and engine to be too simple. E.g. I would like to see there ID of a container which is asking for volume creation/mounting. I also assume that configuration is completely up to plugin and there is no way to pass anything from engine to the plugin (e.g. arguments for mounting).
Also, are you guys planning to do other plugin types? E.g.

container plugin — call plugin whenever container is created, started, stopped, killed
build plugin — call plugin when build is started/stopped/failed
image plugin — call plugin when image is pulled/pushed/imported/exported

That would make plugins very powerful and I can image a lot of ongoing problems would got solved (e.g. secrets/mounts during build, layer/cache control).

Is someone working on anything rsync related regarding volume drivers? For the client side, I started working on https://github.com/synack/docker-rsync.

The suggested syntax (-v volumename:/data --volume-driver=flocker) looks to me like it would unnecessarily limit things to a single volume driver per container.  What if instead of --volume-driver, --volume was enhanced to accept a third initial parameter, the name of a volume driver?  Assume that no volume driver means "local", so this would still work:
-v /host/path:/container/path

But assuming, say, a "blockdev" volume driver, you could do this:
-v blockdev:/dev/sda1:/container/path

Or a "tmpfs" volume driver (Hi, Dan), like this:
-v tmpfs::/container/path

And you could combine these:
docker run -v /host/path:/container/path -v blockdev:/dev/sda1:/data -v tmpfs::/run ...

I agree, I don't like --volume-driver.
Even if we extend it to do something like -v /data --volume-driver blockdev:/data, it's still not nice.
I much prefer something like -v blockdev://<name>:/data:opt1,opt2,opt3... or potentially -v blockdev://<name>@/data:opt1,opt2,opt3
I don't think there is really a problem "overloading" this flag here since it's generally quite natural syntax with proto + path, and then opts like mount -o opt1,opt2,opt3

As I commented in my tmpfs volume patch, I dont line --volume-driver either
'''
Well I think that stinks, for several reasons,
It gives me no flexibility, I don't have any ability to have multiple volumes of different types.
It is not easy to understand. The -v syntax is well understood, and my change is intuitive, I belive, Similar individual mount commands
I don't believe the --volume-driver concept will tar up the contents of the underlying file system to be used in the new tmpfs, which is critical to using it for /run and I like the idea of using it for /var.

'''

I like the idea of passing the mount options on the volume command also. With tmpfs the big one is size.
Other potentials would be noexec.  I think nodev should be default for all of these file systems

@larsks Not sure you need to tmpfs::/mount/point.  tmpfs:/mount/point would be easier for users and not hard to implement.

@rhatdan I am proposing that the syntax is:
[<driver>:]<src>:<dest>

Where the interpretation of <src> is driver dependent, and a missing <driver> means local:.  With this model, tmpfs:/mount/point would need to be handled magically by the local driver, or there would need to be some sort of weird special casing for -v that would act different if the first component starts with a / or not.
I'm in favor of an explicit vs. implicit syntax.

@larsks Right now it's [<name>|<src>:]:<dest>, where  is used to name a volume, not a driver.

Hello all, and thanks for the feedbacks! Let me try to answer some of the questions here.
@TomasTomecek:

API was deliberately kept minimal in this first version. We'd rather first hear from the community what use cases they can't achieve with the current design, and "poke more holes" as necessary. On your specific example of passing the container ID, I'd like to hear an example where it's required (right now we provide a unique volume name which I believe is sufficient).
Driver-specific are indeed very likely to be needed at some point, they just weren't implemented so far.
We might have more plugin types in the future. One of the reasons we marked the feature as "experimental" is that we still don't really know what's going to be the community and user adoption. As we gain more feedback and use cases, we'll refine the UX and potentially expand the scope. API plugins is definitely something that we are thinking about (think Powerstrip), but our current API implementation might need a good rewrite before that.

@larsks @cpuguy83 @rhatdan:
You're right that the --volume-driver syntax is not ideal. There are several reasons behind it right now:

The goal is clearly to have a top-level docker volume command to manage volumes, which will open the possibility for per-volume drivers1 (e.g., docker volume create foo --driver=bar). This is by the way exactly the plan for network management too. We didn't want to put this as a requirement for this first release of the feature, which is why we went for the simplest. Brian I know you had work on this in the past, I think we're ready to do this for 1.8.0 if you interested.
Solomon was very clear that he doesn't want the driver name to appear as part of the volume specification. His reasoning for this is that we want to decouple volume definition from the operational aspect (e.g., "my container needs a volume X" versus "volume X should be managed by driver Y"). He'd ideally want it to be possible to label volumes and somehow leave it to a separate (ops defined) configuration to associates labels to drivers.

I hope this clears up some of the questions.

1 Truth is there already is a hackish way to do multiple volume drivers for a single containers using --volume-from, but that's far from convenient.

@cpuguy83 I am fine with -v tmpfs::/tmp
@icecrime I find the whole --volume-driver to be huge failure on the Ease of Use Scale.  One of the huge advantages of docker is its ease of use from the CLI, and I see this as a huge step backwards.
docker run --volume-from=tmpfs /tmp --volume-from=local /mnt fedora /usr/sbin/yuck
docker run -v tmpfs::/tmp -v /foo:/bar -v /mnt fedora /usr/bin/nice

@icecrime I totally get not wanting to do much more than -v /foo in the syntax... however...
In generally I think most people will use the same volume driver for everything, and then other ones for special cases (maybe mount something from keywhiz/vault, a tmpfs mount, etc).
So enable a user to change the default driver (at the daemon level) thus providing the desired minimal syntax for most cases, and then allowing people to have the finer control with on the -v for their special cases.

@rhatdan But if you consider this as a transition path toward
docker volume create <name> --driver=<driver>
docker run -v <name> <image>

How would you feel about that? One of the reasons the feature is experimental, is that we know this is not the final UX, so I'm glad we can discuss this now.

From a usability point of view not as easy as what we have.  I have no problem with that but I still prefer the shorthand.
Lots of different applications will be using tmpfs volumes, each vying for the same name tmpfs or worse each creating their own slightly different image name.
It breaks our atomic command since we currently expect their to be one command to start an application if I use tmpfs now I need two commands, if my volume creation tool fails what do I do?  Do I know if it failed because the content already existed versus other errors?  Do I need to start doing docker volume list to figure out if the volume already exists.

Bottom line I would want both.  Yours is good for seting up advanced volumes, but it is harder for the general use case.

@icecrime I was thinking of implementing secrets during build.

in playing with https://github.com/SvenDowideit/docker-volumes-nfs I think we need more meta-info.
because the plugin doesn't know anything about the daemon, or the container that is being requested, there's no way to make a unique mount point per container, to mount the volume to the actual docker graphdriver dir (either matching the non-root partition, or the correct docker daemon if there are more than one), and if the same thing is mounted into 2 containers, we're forced to add reference counting.
BUT.... it works :)

@SvenDowideit Plz don't mount to the graphdriver dir :)
unique mount point should be the id/name that the daemon sends.

What happen if we want to use different volume drivers on the same container? for example, a nfs volume and local volume. Would we use multiple --volume-drivers before the actual -v?
+1 to @larsks proposal

Hi. We just wrote a (crude) implementation of the docker volume plugin using Ceph RBD.
Quick feedback: when creating new volumes for Ceph, we need to pass in the desired volume size (among other things). Currently, we have to hard-code that or provide it as a configuration option but that will be applied to all volumes.
IOW, we might want to think about some way of passing driver-specific parameters (say, part of the docker run), on a per volume basis.

@cpuguy83 atm, the daemon isn't sending a unique id/name, which is part of the problem :)

Is snapshotting an intended feature?
I modified @SvenDowideit plugin to support generic block devices (eg. lvm), so an intended way of cloning volumes could be useful.

@loggstream What is the intention of snapshotting?
I don't think Docker should be a data management tool, rather it should be calling out to data mangement tools.
API endpoints should be focused around things happening with containers and the driver makes the decision on what to do.
For instance:

Fire up container on host A with volume named demo

docker calls out to the volume driver to create a new volume called demo
volume driver mounts new volume to host
host path is bind-mounted into the new container

A new container is fired up on a different host with a volume named demo

docker calls out to the volume driver to create a new volume called demo
volume driver knows that it already has a volume called demo
volume driver makes decision on what to do here (is it copying, is it providing a CoW snapshot, some intelligent cloning, etc)

@cpuguy83 a typical Openstack use-case is snapshotting a machine and its volumes for backup/scaleup.
In your 2nd scenario, I expect to pass some hints to trigger the cloning...
How would you implement with docker the following use case?

given a container with a volume attached;
clone the server volume (eg. CoW);
attach the cloned volume to another container.

Will this support containerized volume client?  If I wanted to keep the CEPH RBD client stack (or any other docker volume client) in a container and not on the host, will that be possible?

I prefer
docker volume create  --driver=
docker run -v
Seems more inline with the network UI.
Any thoughts on what is the best place to specify runtime mount options?
For example: NFS rsize,wsize options.

FWIW, I'd leave the management functionality out of the picture for now (ie snapshots).  Docker isn't/shouldn't be an Infrastructure management platform.  Just a plugin to make things easier to consume.

As @SvenDowideit points out, passing in the container_id as part of the mount/unmount request will help. If the same volume is mounted in more than one container,  then  it gets a little messy for the plugin to keep track of refcounts across  restarts and reboots.

The compromise is to add a unique volume id for each volume-name+container pair - see #14737

I agree to @cpuguy83 's comment that generally people will use same volume driver for a container.
@icecrime  How about an option where user can specify a config file to be used. Use case- say for example, user wants to use a specific size and layout for the volume. Each volume driver provider can have special formats of the config file. This config option could also be used for plugins other than volume plugin.

I'm a bit worried about the "one volume driver per container should be enough" assumption. Is it driven by how difficult is the implementation, or what's the rational?

I am agree with @aisrael. Volume driver API only accepts a volume name. We are currently unable to specify other volume characteristics like volume size, IOPS, volume layout, pool name, snapshot etc. How are we planning to add these storage requirements to volume driver API?

@mauri This is a temporary issue.
A top-level volume API/CLI should be part of Docker 1.9 that will make this a non-issue.
@Patiljn See above. The top-level API will allow setting volume-driver specific options when creating a volume as just a map of key/value pairs.
For instance: docker volume create --driver awesomevolumes --opt size=10G --opt iops=10000
The opts are passed directly down into the volume driver.

@cpuguy83 Are these opts per volume basis, right? e.g. If we want to create more than one volume with the same Volume driver, then we should be able to specify different opts to different volumes depending on our requirement.
One more thing is these opts should be specific to volume driver and not the generic one. Just wanted to clarify this.

@cpuguy83 so what about supporting snapshots like this?
--opt snapshot-from=other-volume-wwid

@ioggstream So far these opts just get passed directly to the volume driver and are not parsed by docker at all, so yeah that's totally possible, but must be implemented by the driver.

@ioggstream  yeah that's totally possible, but must be implemented by the driver.
Seems reasonable to me.

Is there any orchestration tool already supporting something like that?

@ioggstream Being that the api is not part of Docker yet? I'd say no.

@ioggstream volume API was just merged, so 1.9 will include it, and hopefully orchestration systems will follow suit.
Also, re-read my last comment and it probably seemed a bit rude... totally not intended to be! Sorry about that.

2015-08-26 22:59 GMT+02:00 Brian Goff<EMAIL_ADDRESS>
@ioggstream volume API was just merged, so 1.9 will include it, and hopefully orchestration systems will follow suit.

Looking ...

Also, re-read my last comment and it probably seemed a bit rude... totally not intended to be! Sorry about that.
Don't worry :)

Peace,
R.

I have the habit of using the --rm flag when I run docker containers just to keep my host clean.
If I use this flag with volume drivers a remove call is sent to the driver API. I don't like it.
I want to keep my host clean and my volumes reusable.
I am also happy to share with you my first Go program: docker-volume-rsync

Hi! I'm confused by volume plugin:
What 's the differences between volume plugin and -v /host/path/:/docker/path/?
I found that"Docker volume plugins enable Docker deployments to be integrated with external storage systems, such as Amazon EBS...".
If there is a path /home/amazon/,which is an EBS,then I just docker run -v /home/amazon/:/data/ -it ubuntu,so why I have to use volume plugins? Thanks :-)

2015-09-09 7:57 GMT+02:00 zhijian<EMAIL_ADDRESS>
If there is a path /home/amazon/

The plugin will:

eg. mount the EBS store for you;
on a remote docker server.

So you shouldn't care about how binding an EBS to your server.

So:
1 Using driverA plugin
2 mount driverA /home/driverAand then docker run -v /home/driverA/:/data/ -it ubuntu
They are the same,right?
But it'll be more convenient if we use plugin ? :-)

@cooljiansir The process of making a volume available to a Docker host in EC2 has a handful of steps.

What is the instance ID of the host
Attach the Volume to this instance
Find the Device
Format the device
Mount the device

.. and the reverse when the container stops.  So you can think of the steps that a Volume Driver accomplishes as a workflow that simplifies preparing external volumes to be used with Docker.
For example, see the following example where we are using Docker Machine to fire up a host with a volume driver configured.  We then can have a single command that enables the container to use the new volume.  The same command applied to another host would swing the volume to that host.
dicey1:machine clintonkitson$ docker $(docker-machine config testt26) run -ti --volume-driver=rexray -v testing:/testing busybox
/ # df
Filesystem           1K-blocks      Used Available Use% Mounted on
/dev/mapper/docker-202:1-16819084-3c8daea37802658c36e86cd6254e5e79f300cd830c14cc64a11030eb841d7130
                     103080888     62640  97758984   0% /
tmpfs                   507972         0    507972   0% /dev
shm                      65536         0     65536   0% /dev/shm
tmpfs                   507972         0    507972   0% /sys/fs/cgroup
/dev/scinia1           16382844     45080  15482520   0% /testing

@icecrime I think we can close this now that the volume plugins moved out of experimental with 1.9?

closing per my comment above


currently display name is not considered in scope expression

In creating dashboards from file, we skip scopes defined in file. For that purpose we may have to purposefully built the filter list, but that filter list does not considers variable names.  Hence we cannot perfectly create a dashboards from file.

Hi all, same problem. I have some dashboards using scope variable (display name) as token. When i use the create_dashboard_from_file method in Dashboard Filter i don't have any chance to pass the scope properly.


delete launch.json

Description

Related Issue(s)

Fixes #
How to test

Release Notes

Documentation

I wasn't aware that we still parsed and evaluated .theia/*
a. is this documented and/or should it be?
b. is it tech debt or not?


Integration with netbox?

Integrating both would make ipam, etc much easier

closing in favor of issue in tink


SQL / MariaDB error on table

Home Assistant release with the issue: 0.86.4 (latest at the moment of issue)
Last working Home Assistant release (if known): n/k
Operating environment (Hass.io/Docker/Windows/etc.): Debian / venv / Python 3.6.8
Component/platform: mariadb / recorder
Description of problem:
Error shows up unexpected (no issue with work of HA or no action done by users)
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
n/a
Traceback (if applicable):
Error executing query SELECT table_schema "homeassistant", Round(Sum(data_length + index_length) / 1024 / 1024, 0) "value" FROM information_schema.tables WHERE table_schema="homeassistant" GROUP BY table_schema LIMIT 1;: (MySQLdb._exceptions.OperationalError) (2006, 'MySQL server has gone away') [SQL: 'SELECT table_schema "homeassistant", Round(Sum(data_length + index_length) / 1024 / 1024, 0) "value" FROM information_schema.tables WHERE table_schema="homeassistant" GROUP BY table_schema LIMIT 1;'] (Background on this error at: http://sqlalche.me/e/e3q8)

Additional information:
Have it on a fresh system-install (was doing reinstallation) with latest Python 3.6.

Does this happen instantly on start, or after a length of time? Based on the error it looks like it's losing connection to the MariaDB server. Is the MariaDB server on the same host as HA or a different host?

sure it's the recorder?
Isn't it sensor.sql ?

Oops, you're right!
I totally forgot about that sensor. It's yaml:
- platform: sql
  db_url: !secret mysql_mariadb_hassdb
  queries:
    - name: MariaDB db size
      query: 'SELECT table_schema "homeassistant", Round(Sum(data_length + index_length) / 1024 / 1024, 0) "value" FROM information_schema.tables WHERE table_schema="homeassistant" GROUP BY table_schema;'
      column: 'value'
      unit_of_measurement: MB

@dgomes it is, I use it to store data in database

The error points towards the sensor not being able to connect to Mysql (wrong hostname, server down, ...)

It's on same machine, inside docker container. I'll try to investigate if it may be some limitation of docker, because I can't imagine connectivity problems on localhost :-)

It is 'mysql://username:password@<IP_ADDRESS>:3306/homeassistant?charset=utf8'

It is, I can see all history in recorder and it's value:

It might be somehow connected with other issues of components being unavailable after x time? With lots of entities (especially Xiaomi ones like I have 3 GWs) HA becomes sluggish in terms of connectivity and looses (working) gateways and maybe also sensors like this?

might :/

I hope it is, will be more than happy to help get it solved just need to know how to debug.
Like in #20383 - for xiaomi changing entity name helps for a while.. Entity registry? Async? Have no clue, just willing to help.

do you have custom_components ? can you switch them off ?

nothing strange in the logs ?

Not at all, except repetition of the error (once) from the issue here so far. It happens like 2-3 times a day tho (no super-extra usage of server as you can see):

I marked 23:40 (time of error) in yellow.

does it happen everyday at the same time ?

With database - I didn't notice that. With Xiaomi - usually it hangs aroung 17-18 everyday, but not only (as it may happen before or later too).

I moved my whole installation from venv to hass.io in docker (same architecture and machine, on same system). Also moved database to docker as an addon. Will test further.

Hi @andriej! Anything to report back yet? Make sure to update your Home Assistant to the lastest version (0.90). The library used by the sql sensor got some updates recently.

Well I'm on 0.90 and lately didn't see any database errors.
Could have been solved with other issues which may caused unstable HA.
I'll put new issue if situation will happen again.


Check if the query is already applied before show the notification.

This PR fixes #9260.
Because the applying notification listens the vis reload event to change its state (and eventually autoclose it), we check if the query is already applied. In this case, no new map request is made, so no need to show the notification.
cc @xavijam

🇪🇸, but I miss a test.

Merge!


feat: Add Makefile for common project tasks and pre-push checks

Introduced a Makefile to streamline common tasks in the Rust project.
Included targets for building, testing, formatting, linting, cleaning, and running the project.
Added a pre-push target that runs critical checks before pushing code to the repository:

Executes cargo test to ensure all tests pass.
Runs cargo +nightly fmt --all to format the code and avoid formatting issues.
Uses cargo clippy to lint the code and enforce code quality standards.

This Makefile enhances the development workflow by providing a single interface for essential tasks, ensuring code quality and consistency before code is pushed to the repository.

We already have GitHub Actions for this, so there's no need for a makefile.
See https://github.com/avhz/RustQuant/tree/main/.github/workflows


[DOCFIX] improve NFS docs (#7456)

Cherry-picks #7456  to the 1.8 branch

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20297/
Test PASSed.


Release updated curl-sys (7.85.0) to crates.io

Can recently updated #459 version be released to crates.io? Thanks.
It's marked as yanked (https://crates.io/crates/curl-sys/0.4.57+curl-7.85.0), but its simply unreleased?

It was yanked because it is not working on Windows 11. See https://github.com/curl/curl/issues/9451 for more information.

Sadly, there no yank reason on crates.io displayed.

See also #460 for context.

7.86 released with with fix, it seems.


modsecurity 3.0.4 - Apache-Error with rules

recusive error in Apache 2.4.41, PHP 7.4.16 fpm modsecurity 3.0.4-1bulid1, modsecurity CRS 3.2.0-1 and Ubuntu 20.04.2
don't see id code of rule and repeat this error everytime:
Apache-Error: [file "apache2_util.c"] [line 273] [level 3] [client XXX.XXX.XXX.XXX] ModSecurity: Rule 7fcb5152c980 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "89"] - Execution error - PCRE limits exceeded (-8): (null). [hostname "xxxx.xxxx.xx"] [uri "/xxxx/xxxx/xxxx.php"] [unique_id "YFocJk5fc7dTaCi90TeixQAAAA8"]
Message: Rule 7fcb5152c980 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "89"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb51507e40 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "240"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514f8948 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "266"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514f2c28 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "317"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514e51f8 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "342"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514df840 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "367"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514d6e68 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "392"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514d1a80 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "417"] - Execution error - PCRE limits exceeded (-8): (null).
Message: Rule 7fcb514c6950 [id "-"][file "/usr/share/modsecurity-crs/rules/RESPONSE-951-DATA-LEAKAGES-SQL.conf"][line "442"] - Execution error - PCRE limits exceeded (-8): (null).
modsecurity.conf
SecPcreMatchLimit 150000
SecPcreMatchLimitRecursion 150000

php.ini (fpm):
pcre.backtrack_limit = 1000000
pcre.recursion_limit = 100000

ulimit -a:
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
scheduling priority             (-e) 0
file size               (blocks, -f) unlimited
pending signals                 (-i) 63703
max locked memory       (kbytes, -l) 65536
max memory size         (kbytes, -m) unlimited
open files                      (-n) 1024
pipe size            (512 bytes, -p) 8
POSIX message queues     (bytes, -q) 819200
real-time priority              (-r) 0
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 63703
virtual memory          (kbytes, -v) unlimited
file locks                      (-x) unlimited

Hi @rudy500 ,
If you are using ModSecurity v3 with Apache HTTP Server, please be aware that that is not recommended.  For Apache HTTP Server, ModSecurity v2.9.3 is recommended.
As a general statement for ModSecurity, you have correctly identified useful configuration items to adjust.  Your values are not particularly high and you could try adjusting them much higher (I would try at least 500000 or 1000000 -- and perhaps much higher again) for the three that you currently have set lower than that.
Finally, some CRS rules can by their nature be very taxing on the regex engine -- especially for certain types of responses.  You may wish to spend some minutes identifying what sort of responses are triggering these errors, and then possibly exclude those rules from being executed in those cases.

Hi @martinhsv,
Review your comments and apply changes but we have this comments:

Review versión of modsecurity library for Apache
rys@moodleweb:/var/log/apache2$ sudo dpkg -l libapache2-mod-security2
||/ Name                     Version      Architecture Description
+++-========================-============-============-============================================
ii  libapache2-mod-security2 2.9.3-1      amd64        Tighten web applications security for Apache
Apply Changes on modsecurity.conf
modsecurity.conf
SecPcreMatchLimit 1000000
SecPcreMatchLimitRecursion 1000000
We apply the changes that you indicated, in the same way some errors of pcre appear ...

Will it be necessary to add these values again in the modsecurity.conf file?
Should we apply changes at the php-fpm level also matching these values?

@rudy500
The pcre limit values are set globally. Every other mod_ could be changing this value in run-time. It is common having php overwriting those values. If you happens to have the mod_php (or equivalent) loaded, double check the values you have for:  pcre.backtrack_limit, pcre.recursion_limit.
You can find further instructions here -
https://www.php.net/manual/en/pcre.configuration.php


Fix #784 Enable BasicAuth through Selenide proxy server

Proposed changes
Fix #784 issue. Enable BasicAuth through Selenide proxy server
Checklist

[x] Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

@asolntsev Done.


chore: use bindIsolatedHandle

bindIsolatedHandle is a method decorator that enforces the use of isolatedRealm. Any return is transformed to their natural equivalent in the mainRealm. this returns are also supported.

Let's land the rest and then I will review this one.

Would you mind rebasing and regenerating the docs for review?


Image scale is preserved on student page and it can mess things up

When a large image is uploaded it's scale is preserved, which means that it is too large to show

Fixed in 772553e7971bce594123fa6b22a1be739d874ea0
All images and videos now have
max-width: 100%;


Issues in the observe-metrics sample

Description:
Output of the observe-metrics sample is wrong
---Counter---
count: 0.0
count: 0.0

---Gauge---
gauge: 0.0
gauge: 0.0
gauge: 0.0
gauge: 0.0
current system time in milliseconds: 0.0

---Summary---
count : 0
max: 0.0
mean: 0.0
percentile values: {}

---Timer---
count: 0
max: 0.0 seconds
mean: 0.0 seconds
percentile values: {}

Affected Product Version:
Ballerina beta 4
OS, DB, other environment details and versions:
JDK - 1.8.0_171
Windows 10

What is the sample name?
Observe samples are removed, since we removed the observe package.


Does Nuxt UI Pro phone home?

Description
After buying UI Pro, will Nuxt keep a list of domains connected to my account?

Not sure to understand completely what you mean.
We check the project name (in package.json) associated to the license to prevent abuse.

The need to prevent abuse is understandable.
Is it possible to use something non-identifying, like a hash of the project name, to keep the user's privacy?

There is no account, the project name of your package.json will be matched with the license key you provided on build that's all.


SNI not used when connecting to https services

Do you want to request a feature or report a bug?
Bug
What did you do?
When using Traefik 2.1 on Kubernetes with an IngressRoute configured to send traffic to an HTTPS backend service, Traefik fails to connect due to the issues described in https://github.com/containous/traefik/issues/3906 related to certs not containing IP SANs.  Setting InsecureSkipVerify to true can work around this, but is not an ideal solution. Can Traefik be made to send and SNI request to the backend service using the hostname passed in form the ingress service?
Using a TCP ingress for this is also not ideal, as we are hoping to make use of the HTTP layer features of Traefik load balancing.
What did you expect to see?
Traefik to use the hostname requested on the inbound request to the IngressRoute as an SNI request to the backend service. Maybe this could be a feature based on whether "pass through host-header" is set in conjunction with a scheme of https?
What did you see instead?
Traefik used the IP, and failed to validate the SSL certificate for the backend service.
Output of traefik version: (What version of Traefik are you using?)
2.1.9
What is your environment & configuration (arguments, toml, provider, platform, ...)?
---
apiVersion: traefik.containo.us/v1alpha1
kind: IngressRoute
metadata:
  name: oidc-proxy
  namespace: auth-test
spec:
  routes:
  - kind: Rule
    match: "Host(`app.example.com`)"
    services:
    - kind: Service
      name: my-app
      namespace: default
      scheme: https
      port: 6443
  tls: {}

config.toml: |-
[entryPoints]
[entryPoints.web]
address = ":8000"
    [entryPoints.websecure]
        address = ":443"

    [entryPoints.traefik]
        address = ":8080"
[ping]

[accessLog]
  format = "json"

[metrics]
  [metrics.prometheus]

[api]
    dashboard = true

[providers.kubernetesCRD]

[providers]
    [providers.file]
        filename = "/etc/config/config.toml"
        watch = true

[tls]
    [tls.options]
        [tls.options.default]
            minVersion = "VersionTLS12"
        [tls.options.mintls13]
            minVersion = "VersionTLS13"

    [tls.stores]
        [tls.stores.default]
            [tls.stores.default.defaultCertificate]
                certFile = "/var/certs/default/tls.crt"
                keyFile  = "/var/certs/default/tls.key"
[serversTransport]
  insecureSkipVerify = true

Related to #4835

duplicate of  #4835


Add file "LICENSE" with the current version of the LPPL

I added the file LICENSE with the current version of the LaTeX Project Public License. The current version of http://www.latex-project.org/lppl.txt is used.
Thus, it is clearer to others which license is used in this project. Thus, also github can auto recognize the license as you can see https://github.com/kulla/beamercolortheme-owl (top right corner).
PS: Great color theme! I want to use it in some educational videos. :-)

Great idea, thanks for the contribution!


Make $sheet-border-radius tweak-able

Added a missing !default

Hmm, I assumed it would just work but doesn't seem like it.


Decouple FunctionsEnableMetadataSourceGen from FunctionsEnableWorkerIndexing to actually make it work properly when set

Issue describing the changes in this PR
resolves #2209
Unfortunately, I have no context of the project to be able to say this change of decoupling the properties is safe, but at least from the expectations I had from the description of the property and how the executor generation works, I would have expected to be able to disable the metadata source gen independently of the function indexing.
I did smoke test the package locally with the dev build, and it seems to work (see after GIF) and my function is still executing.
Pull request checklist

[ ] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[ ] My changes should not be added to the release notes for the next release

[ ] Otherwise: I've added my notes to release_notes.md

[ ] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[ ] I have added all required tests (Unit tests, E2E tests)

Additional information
This changes potentially requires a backport
Happy to add necessary release notes once I get some feedback from the team.
Before

After

@jviau you have been so kind to review my last contribution. Would you mind giving this one a go too?

Hi @danielmarbach, thanks for being a contributor! We will review and come back to this PR. I believe these two properties can be decoupled as they were introduced separately when we first implemented worker indexing (still using functions.metadata) then replaced the functions.metadata file creation and read with the source-generated metadata. However, performance benefits are only gained from the combination of these two features, so the "worker-indexing only" path is not preferred.
These two props were coupled together with the intention of using FunctionsEnableWorkerIndexing as a catch-all to light up the parts that are needed to use source-generation (worker-indexing, source-generated metadata, source-generated executor, auto-registration of the generated metadata provider, etc). Additionally, some of the other properties this PR touches need to be coupled to work properly.
You've brought up a great point, and we will review to see if we can improve on this to give users the ability to control these features with more granularity without breaking themselves.

@danielmarbach Are these changes still valid as of today? Is this good to be reviewed?

@kshyju I think so. I do not have the capacity nor the detailed knowledge to address the feedback of @fabiocav https://github.com/Azure/azure-functions-dotnet-worker/pull/2210#pullrequestreview-1846844982, unfortunately. So I leave it up to your team to decide how you want to proceed from here.


How to add Multiple emoji

Is't showing only one emoji ,but i want its look like which you are presented

lol...yes there is only one emoji lol


rav1e crashes on compiling paste for Arm64 Windows

Over at rav1e we are trying to get Arm64 Windows (aarch64-pc-windows-msvc) builds working, but right now it seems to crash on compiling paste. With https://github.com/dtolnay/paste/pull/11 I tried building paste for Arm64 Windows, which succeeds (but crashes on testing). Do you guys have any idea what's going wrong?
The error from https://github.com/xiph/rav1e/pull/1209 on AppVeyor.
   Compiling paste v0.1.5
error: linking with `link.exe` failed: exit code: 1112
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "/NXCOMPAT" "/LIBPATH:C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\aarch64-pc-windows-msvc\\lib" "C:\\projects\\rav1e\\target\\aarch64-pc-windows-msvc\\release\\deps\\rav1e-ea777a993130cf0c.rav1e.8w2jlir1-cgu.0.rcgu.o" "/OUT:C:\\projects\\rav1e\\target\\aarch64-pc-windows-msvc\\release\\deps\\rav1e-ea777a993130cf0c.exe" "/OPT:REF,ICF" "/DEBUG" "/NATVIS:C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\intrinsic.natvis" "/NATVIS:C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/LIBPATH:C:\\projects\\rav1e\\target\\aarch64-pc-windows-msvc\\release\\deps" "/LIBPATH:C:\\projects\\rav1e\\target\\release\\deps" "/LIBPATH:C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\aarch64-pc-windows-msvc\\lib" "C:\\Users\\appveyor\\.rustup\\toolchains\\nightly-x86_64-pc-windows-msvc\\lib\\rustlib\\aarch64-pc-windows-msvc\\lib\\libcompiler_builtins-cc0bf6ece960e8d2.rlib" "advapi32.lib" "ws2_32.lib" "userenv.lib" "msvcrt.lib"
  = note: advapi32.lib(ADVAPI32.dll) : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'ARM64'

error: aborting due to previous error
error: Could not compile `rav1e`.

This crate is an ordinary procedural macro crate; we don't do anything special that would fail in this way. I think this issue would be more appropriately reported as a rustc bug.
It would help if you could narrow down the smallest possible set of code that reproduces the bug.

@dtolnay Thanks for your reply!

It would help if you could narrow down the smallest possible set of code that reproduces the bug.
This would help a lot before filing a Rustc issue!


Use SharedExecutorService in more locations

Description
Replaces usage of one-off ExuecutorServices with SharedExecutorService, as most usages of ExecutorService should route through SharedExecutorService as it allows customers more control over the Azure SDK for Java threading story.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


add in high plains raceway to racetracks and add into simulation.py

simulation runs, but is v slow

simulation runs, but is v slow


[DOC-3126] Delegate SaaS release notes - 793xx

Delegate SaaS release notes - 793xx
For reviewers, previews are available:
NG
FG
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Link for Survey

follow with Dr. Cleo for survey links

Asked for links (March 5th)

done in #127


Always reset barrier

Coverage remained the same at 30.134% when pulling 67e925a028f966c59f2de89b55b7473eabc4b428 on qingweibinary:qingwei/reset_barrier into 516861e250dc0ce2a33743d277a50587e04bc7ae on binary-com:master.


Update the DG (User stories and Use cases)

Add the following to the DG, based on your project notes from the previous weeks. Some examples of these can be found in the AB3 Developer Guide.

Target user profile, value proposition, and user stories: Update the target user profile and value proposition to match the project direction you have selected. Give a list of the user stories (and update/delete existing ones, if applicable), including priorities. This can include user stories considered but will not be included in the final product.
Use cases: Give use cases (textual form) for a few representative user stories that need multiple steps to complete. e.g. Adding a tag to a person (assume the user needs to find the person first)
Non-functional requirements: Note: Many of the given project constraints can be considered NFRs. You can add more. e.g. performance requirements, usability requirements, scalability requirements, etc.
Glossary: Define terms that are worth recording.

The above DG sections should cover the full requirements of the product, some of which might not get implemented by the end of this semester. Furthermore, these sections will be graded at the final project evaluation, and any bugs in the content can cost you marks at that point.
Problems in User Stories. Examples:

Incorrect format
All three parts are not present
The three parts do not match with each other
Important user stories missing

Problems in Use Cases. Examples:

Important use cases missing (a use case is important if it involves a user interaction that is worthy of documenting e.g., it has multiple extensions -- this is not the same as the feature being important)
Formatting/notational errors
Incorrect step numbering
Unnecessary UI details mentioned
Missing/unnecessary steps
Missing extensions

Problems in NFRs. Examples:

Not really a Non-Functional Requirement
Not scoped clearly (i.e., hard to decide when it has been met)
Not reasonably achievable
Highly relevant NFRs missing

Problems in Glossary. Examples:

Unnecessary terms included
Important terms missing

Will complete this during v1.2
As of now, the workload distribution is quite uneven so we will readjust the workload planning, since we did not really plan out the workload for the actual coding of each enhancement/feature yet.


Add privacy policy page

/CC @jdorfman

Once James comes back from Black Hat I will work with him on this. The tricky thing here is there is www and cdn which need to be treated separately.
Back in January of 2016 a concerned user emailed MaxCDN support asking about BootstrapCDN's privacy policy. After a few back and forths, we came up with the following (that he then posted on his website):

Certain elements of the site (such as styles or scripts) may be served by BootstrapCDN, a service of MaxCDN. Each time you access a portion of the site that includes such elements, BootstrapCDN records certain information about your computer or device, including the IP address, geographical location (determined based on the IP address), and your browser's user agent information (which typically includes your operating system and browser type/version). We do not receive or have access to that information, but BootstrapCDN may retain it for security, troubleshooting, and/or service improvement purposes. If you have questions about how BootstrapCDN or MaxCDN uses this information, please contact them directly.

I tried to hire him to write our ToS and Privacy Policy but he respectfully declined. Then the acquisition (StackPath + MaxCDN) happened and this project got put on hold.

I'm thinking just linking to this: https://www.stackpath.com/privacy-statement/
Thoughts @XhmikosR @jmervine

I don't have a strong opinion, I'll leave that you to and James.

I don't have a preference either as long as it covers our use case (Google Analytics, Carbonads); no need to stuff that doesn't apply here.

Footer or Resources drop down?

I'd probably say footer, but not with it's current design. We'd need to move things around first. Maybe...

Maintained by...
Homies be...

SP logo | privacy policy

or something of the like.
That said, totally your call IMO.

@XhmikosR has the best design sense out of us. Whatever he thinks

If you send me the text I can put something together and ping you guys.

@XhmikosR my friend owns this service: https://www.iubenda.com/en/privacy-policy-generator/
I will get a free account.

@XhmikosR
options:
1:
Privacy Policy

2:
https://www.iubenda.com/privacy-policy/74504147

3:
Privacy Policy

API
http://www.iubenda.com/api/privacy-policy/74504147

https://www.iubenda.com/en/help/posts/78
Make sure to link back to iubenda since they hooked us up with a pro account.

@jmervine did I miss services?

I don't think we need to add AWS since Heroku is hosted on AWS right?

I wouldn’t mention any of this except maybe stack path, but I don’t know much about this side. 🤷🏻♂

I checked with my buddy who is in this space and he says it should all be in there. In fact, we should technically have a separate cookie policy but I rather just wait to be told than add one of those annoying banners to our site.

My main concern with this, is that I personally don't want to embed yet another third-party thing.
Can't we just get the text and we mention something like "Generated with foo(link)"?

@XhmikosR for sure that is why I gave you all the different options ;)


route() host overwritten by X-Forwarded-Host

Laravel Version: 5.8.33
PHP Version: 7.1.31

Description:
If the user sends a query with the manually set X-Forwarded-Host header, then the route() function will return an array with the key "host" with the changed address.
This may be a security problem - when I use route('my/page/url') in setAction() in any Form Builder (symfony form, laravel FormFactory etc.), then action attribute can be overridden by the attacker's domain.
Steps To Reproduce:

Get postman or other soft to modify headers.
Set header X-Forwarded-Host with domain, ex. www.google.com
Refresh page with form, when the page has setAction() method with route(), for example:

$form = FormFactory::createBuilder()
            ->setMethod('POST')
            ->setAction(route('homepage/signup'))

The action url is is overwritten. All data is correct except host.
Good to read
https://www.acunetix.com/blog/articles/automated-detection-of-host-header-attacks/

You can set trusted hosts to prevent header injection attacks:
Request::setTrustedHosts([
	'^(.+\.)?example\.com$',
	'^(.+\.)?example\.org$',
]);

Another way to mitigate this, if you serve your Laravel application with Nginx is to listen only to those valid domains and send an empty response for invalid ones:
Unknown hosts:
server {
    listen 80;
    server_name _;
    return 444;
}

All valid hosts:
server {
  listen 80;
  server_name .example.net .example.com;
  ...
}

Also if you define your routes within a domain group you can also be safe:
Route::domain('example.com')->group(function () {
 ...
});

Thanks!

You can set trusted hosts to prevent header injection attacks:
Request::setTrustedHosts([
	'^(.+\.)?example\.com$',
	'^(.+\.)?example\.org$',
]);

Excuse me @bonzai could you point where to put this? Thanks.

You also can filter each request in the AppServiceProvider boot method for the valid host.
    $appUrl = env('APP_URL');
    $appUrls = explode("//", $appUrl ?? '');

    $allowedHosts = [$appUrl, $appUrls[1]];
    $currentHost = request()->getHttpHost();

    if (!in_array($currentHost, $allowedHosts))
    {
        abort(404);
    }


Pretty print JSON

Added an option for json pretty printing, based on Issue #73 - json pretty print [feature request].

Can't this be merged?


php version not satisfied

getting
Problem 1
- This package requires php-64bit >=7.0 but your PHP version (7.0.30-0+deb9u1) does not satisfy that requirement.
Problem 2
- Installation request for exodus4d/pathfinder_esi dev-master#v1.2.5 -> satisfiable by exodus4d/pathfinder_esi[dev-master].
- exodus4d/pathfinder_esi dev-master requires php-64bit >=7.0 -> your PHP version (7.0.30-0+deb9u1) does not satisfy that requirement.
Im on debian 9 armhf 32 bit

Installation issues doesn´t belong to Github, register to Slack and try to find answer there.

why the hell would uncompiled php code require 64 bit tho

@razaqq Version requirements for e.g. PHP are set in composer.json.
They package versions in there might not always represent the real minimum version of a package.
This is because I can not provide tests for each version available. If your server setup matches all the requirements from composer.json you should be save because it was tested. If not and there is no option for upgrade, feel free to adjust composer.json with your installed versions and give it a try.
If you can´t see any problem with your package, please let me know and we could adjust the composer.json

alright giving it a try by editing the version in composer.json


refactor question about internal Option type

Can we abstract internal/client.Option&internal/server.Option as an interface?
Like type ServerOption interface  or type ClientOption interface, it's looks like easier to maintain.
The function signature of the Option.F is more like for server.WithSuite compatibility
Should we change this function signature to F func(o *Options)?
Code
// package "internal/server"
type Option struct {
	F func(o *Options, di *utils.Slice)
}
// package server
func WithSuite(suite Suite) Option {
	return Option{F: func(o *internal_server.Options, di *utils.Slice) {
		var nested struct {
			Suite   string
			Options utils.Slice
		}
		nested.Suite = fmt.Sprintf("%T(%+v)", suite, suite)

		for _, op := range suite.Options() {
			op.F(o, &nested.Options)
		}
		di.Push(nested)
	}}
}

Thanks @dongzeXD . This is common use in golang 'Option Pattern'. Why do you think a interface is better, could you give a demo? And this is irrelevant with WithSuite.


New-PSSession does not work with -ConnectionURI on 14.04/16.04

After calling $UserCredential = Get-Credential
then doing
$Session = New-PSSession -ConfigurationName Microsoft.Exchange -ConnectionUri "https://outlook.office365.com/powershell-liveid/" -Credential $UserCredential -Authentication "Basic" -AllowRedirection
results in
New-PSSession : [outlook.office365.com] Connecting to remote server
outlook.office365.com failed with the following error message :
MI_RESULT_FAILED For more information, see the about_Remote_Troubleshooting
Help topic.
At line:1 char:12

$Session = New-PSSession -ConfigurationName Microsoft.Exchange -Conne ...

       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OpenError: (System.Manageme....RemoteRunspace:Re
moteRunspace) [New-PSSession], PSRemotingTransportException
FullyQualifiedErrorId : 1,PSSessionOpenFailed

not sure what the expected result is, but that's not it.
Version info:
Name                           Value

PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.14
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Running strace on the binary, it appears to be a problem resolving the hostname.   Instead of doing a dns query for outlook.office365.com, it is doing a dns query for https:.default.domain.com (where default.domain.com is the domain on the dns searchlist).   yes literally that domain.
Similar result on 14.04 but did not run strace there

@paulcallen - Please comment on this issue with regard to #942. Is it a newly uncovered issue or a duplicate?

it was reported first as part of #942. There is an issue in powershell/psl-omi-provider#67 tracking progress.
Current status is that -ConfigurationName does the correct thing thing now, but the underlying stack does not like the redirects that this operation requires. I am currently working through that. Once that is complete we will be dropping new binaries to powershell to be included in the official build.


Create storybook story for PaginationV2 (now Pagination)

Looks like with the rename that there is no storybook story for PaginationV2, we should create one and add it in 👍

i'll do this after the rename for Pagination is merged into v10 release branch!

closed in https://github.com/IBM/carbon-components-react/pull/2129


Config giving error when Config loader is created while nothing is going wrong

When starting the engine Error parsing config file: config/BaseEngine.ini is printed which comes from creating the ConfigLoader in the application, nothing is going wrong so idk why its printing it.
Needs some investigation

The issue has been resolved! The problem we encountered occurred when the application wrote to the config, creating a new empty line that led to an error during parsing.


Add plugin (and plugin support) for background processing of non-JP2s

When dealing with a huge non-JP2 image, the server can become... sluggish, let's just say.  It would be very handy to be able to put all requests for a given resource into some kind of queue and generate a tiled, multi-resolution JP2 before serving up those requests.
The external images plugin sort of does this, but it is definitely not production-ready, it does its processing in a very weird hook (the id-to-iiif call), and it just shells out to the JP2 compression command (though this might be the easiest approach, it's certainly not ideal).

Thinking about this from the perspective of S3, @eikeon and I have talked about doing this on-demand where hitting a non-JP2 image would trigger a Lambda function to convert it, which seems really nice for this kind of bursty one-time activity.


Installation does not work.

Description
I followed the installation instructions on the install section (https://github.com/xpack-dev-tools/riscv-none-elf-gcc-xpack)
The code doesn't work.
Steps to Reproduce

xpm init: No packages found.

xpm install @xpack-dev-tools/riscv-none-elf-gcc@latest --verbose: Package "@xpack-dev-tools/riscv-none-elf-gcc@latest" not found.

Tryed refereshing. Doesn't work either.
Expected behaviour: Should install

Actual behaviour: Doesn't install package.
Versions

[RISC-V GCC version]
lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:    Ubuntu 22.04.3 LTS Release:        22.04 Codename:       jammy

Are you behind a firewall/proxy?

I installed WSL2 on windows https://learn.microsoft.com/en-us/windows/wsl/install
I don't know,if there is any firewall. But apt under ubuntu wsl works.
See also: https://github.com/hathach/tinyusb/discussions/2525#discussioncomment-8895299

Wrong tool. See https://xpack.github.io to install the correct xpm.

And where exactly is the installtion tutorial?

install worked. i propose to put a direct link on the front side on the project, so that install instructions are more easy to find.

put a direct link on the front side on the project

The existing one is not enough?

https://github.com/xpack-dev-tools/riscv-none-elf-gcc-xpack#prerequisites


Order - Specific

Should the docket numbers and court name be asked initially to get preliminary questions out of the way?

The order block has been updated to where Aubrie and Valerie felt the question was best fitted in terms of the readability for the user.


More style cleanups/changes

TODO:

~more type hinting~
~make suburb-selector a generator, so we can loop until time/count is done~
don't call update_processed_dates() every time?
~move print_progress_bar to utils~
~check for DB index, rather than trying+failing to create~

Looks good, happy to merge now or leave open if you were planning to add update_processed_dates() changes.

Happy to merge now. Will do more another day


Removing the only system nodepool from cluster via API does not show error

Rancher: v2.9-0d8af1460cfc73c3bf4bafecc38f399ea5c187a3-head
Dashboard: release-2.9 65f0232
Operator Version:  rancher-aks-operator:104.0.1+up1.9.0
Steps to reproduce:

Import a cluster with a single 'System' mode nodepool, and a user mode nodepool
Removing the 'System' mode nodepool via API

Result:
The update does not result in cluster to error out.
The UI shows error 'At least 1 system nodepool is required, but there is no error in the operator logs or cluster object.
For a provisioned cluster, the operator logs and cluster.Transitioning and cluster.TransitioningMessage both show appropriate error messages.

PR's:

[x] https://github.com/rancher/aks-operator/pull/694

Validation passed on build: v2.10-head, aks-operator:v1.10.0-rc.2
Removing the only system nodepool from provisioned/imported cluster via API throws error


Fix UnicodeEncodeError when ticket has an special char using python2 and user goes to the admin page.

See issue: https://github.com/django-helpdesk/django-helpdesk/issues/541

Codecov Report

Merging #542 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   63.46%   63.47%   +0.01%
==========================================
  Files          35       35
  Lines        3287     3288       +1
  Branches      499      500       +1
==========================================
+ Hits         2086     2087       +1
  Misses       1064     1064
  Partials      137      137

Impacted Files
Coverage Δ

helpdesk/models.py
78.92% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b00086...d264c46. Read the comment docs.


[WIP] Initial alternative plugin system

Alternative to https://github.com/fastlane/fastlane/pull/4619

I haven't yet looked into how we can actually load and use those gems then.
I was assuming it would be nice to have separate lock files, but thinking about it, that's not what lock files are built-for.
I'll iterate once again, and use only one lock file. We can still have separate Gemfiles, so that it's easy for us to provide a CLI to add and remove plugins.
All we have to do is add this to the ./Gemfile:
content = File.read(File.join(File.dirname(__FILE__), 'fastlane', 'FastlaneGemfile'))
eval(content, binding)

this way we still have separate Gemfiles, one in the fastlane directory, but only have one lock file.
This technique however doesn't allow us to update just the plugins without actually updating all the other things, right?

Excited for this! Are you able to give an overview how this will work so I have some context when reviewing :)

Closing this PR to split up the work 👍


Force unsigned behaviour for bitfield enums

Some compilers (notably MSVC) were using signed values for bitfield enums. This was causing problems where 2 bits were used to store 4 or less enum values, where they were being treated as negative numbers.
This PR explicitly requests these enums to be treated as unsigned values.
Problem can be reproduced here: https://godbolt.org/z/Kqqdsehc6
Notes

I had inadvertently caused this bug in #60858, by storing PauseMode in 2 bits.
Alternative approach is to add an extra bit to account for this compiler behaviour, but forcing unsigned is probably a better fix.
The TransformInterpolator::Method actually already has an extra bit so is not susceptible, but have changed this too as a "just in case".
We will have to watch for this bug in future when using bitfield enums.
Embree also uses bitfield enums, but either uses more bits than necessary, or adds an extra bit (presumably to prevent the problem).

Bit more explanation here, as there was no issue at the time, and godbolt now seems to be having problems running msvc compiler:
For an enum with e.g. 4 values, you would think that 2 bits should be enough to store this, e.g.:
Method method : 2;

This works on most compilers, as they default to an enum being unsigned int. However on msvc (at the time at least) it defaulted to enum being signed int.
This meant they interpretted the 2 bits as:
00 = 0
01 = 1
11 = -1
10 = -2

Which made all kind of things go pear shaped.
So the solution was either to add an extra bit (to prevent getting into the negative bit range), or better to specify the enum as unsigned in the declaration.


Proposal: Upgrade logspout

Logspout has undergone two major refactors in the time since we forked and enhanced it (mainly for the sake of discovering deis-logger host and port from etcd and to hijack the message format).
The master branch of logspout (which is trending toward a v3) is significantly more modular than what we've been using.  The possibility exists that we can bend logspout to our will by creating a module for it, rather than by forking it and hacking on it.
The major motivation for this would be the ability to reap the benefits of upstream bug fixes.
Do other maintainers want to weigh in?

If there's a way we can extend logspout without having to maintain the source (keeping the source code upstream), that would be a nice enhancement as well. Otherwise I'm all for a version bump!

:+1:

@bacongobbler @carmstrong
Trivial example of customizing logspout without forking:
https://github.com/gliderlabs/logspout/tree/master/custom
The major question will be whether the extension points logspout opens are sufficient hooks for us to do all the customizations we need.

I took a first swing at such a module here, but it's incomplete, and so far, it crashes my cluster every time I try it.  :astonished:

Have we reevaluated the need for us to maintain a fork of logspout? Could we ever switch back to using mainline?

While we're on the subject, I'd love to not change the message format when the message is sent to syslog-compatible (paperclip for instance). It should be changed for the sake of deis logs but I feel it should do so only after it has sent the raw log line to syslog.

@carmstrong the very idea here is that we could use mainline logspout and just maintain modules for whatever functionality we need to add... maybe.  Doing so may be easier said then done, but it's the hope.
@kalbasit re: message format... if one is running cephless/stateless and is therefore not running deis-logger, or has opted out of deis-logger for any other reason, I think we should make it easier to opt-into a syslog-compatible message format.  That being said, if deis-logger is the destination for the logs, then the responsibility of emitting syslog-compatible messages, IMO, belongs to deis-logger's drain.

See https://github.com/deis/logspout-v3-deis for a possible implementation of a Deis adapter that would allow us to use a newer upstream logspout without forking it.
Also see related upstream logspout issue: https://github.com/gliderlabs/logspout/issues/124

:+1: On using the logspout master and this plugin.

fwiw, I've been using logspout master + the proposed plugin all day while heavily testing other things and have kept one eye on both it and deis-logger.  No issues so far.
Most notably, I want to emphasize that upstream logspout master does not appear to suffer from the issue that was reported against our old logspout fork in #3633 and closed by #4291.  It seems to reliably attach to all containers even after many dozens of scaling events where i scaled up or down by 100 at a time.

@krancour I think it's probably worth PRing our switch to using the new logspout and plugin. I guess shipping v3 officially is a prerequisite for that?

Yes, although the plugin currently lacks unit and functional tests... so there's that.
re: an upstream v3 release, I'm working with @progrium on that.

although the plugin currently lacks unit and functional tests

Ah, that's right.

Closing.  See final comment in #4347


Weird formatting in case of linebreaks

Hi,
first of all thank you for providing the package.
I am currently writing a scientific paper in the IEEE template and naturally, some codelines are two long.
Unfortunately the rendering is not as I would expect from other editors etc, and the code looks quite strange as it tries to fill the lines.

#sourcecode()[```python
def reset_runner():
  try:
    # Connect to the local libvirt system
    if (conn:=libvirt.open("qemu:///system")) is None:
      print("Failed to open connection to the local libvirt system")
      return False

    # Find the domain by name
    if (dom := conn.lookupByName(domain_name)) is None:
      print(f"No domain found with name: {domain_name}")
      return False

    # Look up the snapshot by name
    if (snap := dom.snapshotLookupByName(snapshot_name, 0)) is None:
      print(f"No snapshot found with name: {snapshot_name}")
      return False
```]

Code of the screenshot using the charged ieee template.
Is there a way to stop this kind of "fitting"? Especially for python this would be necessary for readability.
Greetings
Felix

Not sure what the problem is here. This seems to be an issue with some other settings. Do you set any alignment for text or justified paragraphs? Can you post the full document or at least your "preamble" (any #page, #set and #show rules that might affect the outcome)?
I copied your example code into a test document and the result looks fine: https://typst.app/project/r4OW3WI6Fj8g2wZqrXQNLe

Hi,
thank you for the answer, I looked at your document and it looks just like I would like it.
I created on with the IEEE template and it definitely seems to be related to some template settings.
https://typst.app/project/rLgbAEGQRWinS8uyeb0Xgr
I tried fixing it with text, but so far not successfully :(
For any ideas how to fix, I would be very grateful. :)

Seems to be a problem with setting justified text. I will look into it.
You can fix it for now by adding
#show raw: set par(justify: false)

just after your #show: ieee call.

Oh, and you might want to add numbers-align: top+right to #sourceode to align the line numbers at the top for lines that are broken into multiple lines.

Thank you so much, this fixes it ❤


Add migration for event date columns on message table

What is the context of this PR?
Adds sent_at and read_at columns to the secure_message table in preparation for the code change that will populate these columns.
How to review

Run the migration SQL against the secure message database, if running the ras-rm-docker-dev setup you can use psql -h localhost -p 6432 -U postgres -d postgres -a -f migrations/001_create_event_dates_on_message.sql
Use the service and verify it works
Run the acceptance tests

@insacuri They are the defaults and are the same as the date_time column on events created by SQLAlchemy.


Add user-agent header to all network requests

We should add a User-Agent header to all model list and model download requests so we can get an idea of how many clients of which version are still around, and use that info to know whether we should still host old versions of models in case of an API update.

We should be always backwards compatible, even if it is prompting users to update their model on launch. A user starting a new program with the old models already downloaded should be prompted to update and to not crash.
A user downloading new models with old version of the app should be able to at least get a message such as "API unsupported, please upgrade."

Implemented in #47


Create an umbrella chart for the grafana stack (single grafana with auth)

Resources:

Grafana Helm repo
loki-stack umbrella chart - just an example

As there was already an issue hanging in the grafana/helm-charts repo, I have raised a PR there grafana/helm-charts#2666
It might also be good to create one without the microservices mode.

There is also an update now https://github.com/grafana/helm-charts/pull/3089