[BUG] Unnecessary instancemanager makes issues since v1.3.1

Describe the bug
After installing v1.3.1 a 7th instance-manager engine gets deployed. v1.3.0 and before only spin up 6 engines (I have 3 worker nodes in my cluster). Consequently, 2 replicas of the instance-manager permanently fail to start.
To Reproduce
Steps to reproduce the behavior:

Have a Kubernetes Cluster with 3 control planes and 3 worker nodes on v1.23.9
Have Rancher 2.6.6
Install Longhorn v1.3.1 through rancher

Expected behavior
It should only spin up 6 instances as in v1.3.0 and before
Log or Support bundle
Please let me know if certain logs help

Can you provide the support bundle?

longhorn-support-bundle_2d71ad25-a9d0-46e9-a06a-ee5e307fbffa_2022-08-23T08-35-38Z.zip

The two instance-managers, instance-manager-r-b675cbd9 and instance-manager-r-01a9f66f are stuck at starting state.
The events show
  reason: OutOfcpu
  message: 'Node didn''t have enough resource: cpu, requested: 480, used: 3601, capacity:
    4000'

Two questions still remain:
Why does it request such a high number of CPUs? Is there any need for 480 CPUs? And why does 1.3.1 spin up one more instance-manager than any other version before?

For the second question, because someof the volumes' replicas are still runnig the instance-managers. You can please refer to https://longhorn.io/kb/troubleshooting-some-old-instance-manager-pods-are-still-running-after-upgrade/

Thanks! After cleaning up the engines, it now works fine.
However, the high amount of requested CPUs seems strange to me (however, I am far for being an expert here :) )

@DrZoidberg09
The requested CPU 480 is because of the settings guaranteed-engine-manager-cpu and guaranteed-replica-manager-cpu. By default, the two values are 12 percent. If your are interested the settings, please refer to https://longhorn.io/docs/1.3.0/references/settings/#guaranteed-engine-manager-cpu.


Between m/44'/501'/0' and m/44'/501'/0'/0',  which one is recommended path for Ledger nano x?

I'm trying to connect phantom wallet with my ledger nano x.  There're two different derive paths
between m/44'/501'/0' and m/44'/501'/0'/0'.      May I know which is the recommended one?
I'm thinking like one of them maybe more compatible with different type of wallet such as Sollet, Phantom
which even I lose my hardware wallet, I still can recovery my fund by importing seed phase into hot wallet no matter Phantom or Sollet without the issue.

Trust Wallet uses the path m/44'/501'/0' ，


 ServerErrorHandler: Poco::Exception. Code: 1000, e.code() = 107, e.displayText() = Net Exception: Socket is not connected, Stack trace (when copying this message, always include the lines below)

 ServerErrorHandler: Poco::Exception. Code: 1000, e.code() = 107, e.displayText() = Net Exception: Socket is not connected, Stack trace (when copying this message, always include the lines below):

Poco::Net::SocketImpl::error(int, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&) @ 0x11d0c84e in /usr/bin/clickhouse
Poco::Net::SocketImpl::peerAddress() @ 0x11d0eac6 in /usr/bin/clickhouse
DB::ReadBufferFromPocoSocket::ReadBufferFromPocoSocket(Poco::Net::Socket&, unsigned long) @ 0xe8de1ad in /usr/bin/clickhouse
DB::TCPHandler::runImpl() @ 0xf64c6be in /usr/bin/clickhouse
DB::TCPHandler::run() @ 0xf65f879 in /usr/bin/clickhouse
Poco::Net::TCPServerConnection::start() @ 0x11d138af in /usr/bin/clickhouse
Poco::Net::TCPServerDispatcher::run() @ 0x11d152c1 in /usr/bin/clickhouse
Poco::PooledThread::run() @ 0x11e4b9e9 in /usr/bin/clickhouse
Poco::ThreadImpl::runnableEntry(void*) @ 0x11e4784a in /usr/bin/clickhouse
start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
(version <IP_ADDRESS> (official build))

What's wrong? Clickhouse server print this error infomation every second, Can any body help me?

did you deploy clickhouse sever inside kubernetes with clickhouse-operator?
could you share your kind: ClickhouseInstallation  manifest?

apiVersion: "clickhouse.altinity.com/v1"
kind: "ClickHouseInstallation"
metadata:
  name: "ch1"
spec:
  defaults:
    templates:
      podTemplate: default
  templates:
    podTemplates:
      - name: default
        spec:
          containers:
            - name: clickhouse-pod
              image: yandex/clickhouse-server:21.3
              volumeMounts:
                - name: data-storage-vc-template
                  mountPath: /var/lib/clickhouse
                - name: log-storage-vc-template
                  mountPath: /var/log/clickhouse-server
    volumeClaimTemplates:
      - name: data-storage-vc-template
        spec:
          accessModes:
            - ReadWriteOnce
          storageClassName: alicloud-nas-subpath
          resources:
            requests:
              storage: 400Gi
      - name: log-storage-vc-template
        spec:
          accessModes:
            - ReadWriteOnce
          storageClassName: alicloud-nas-subpath
          resources:
            requests:
              storage: 10Gi
  configuration:
    clusters:
      - name: "c1"
        layout:
          shardsCount: 1

@Slach

Yes, I did deploy clickhouse sever inside kubernetes with clickhouse-operator.

I also encountered this problem, did you find out the cause of this problem?

@czhfe @intfish123
it is kubernetes inside GCP or other cloud provider?
look like healthcheck probe from kubernetes external implementation for service type: LoadBalancer
they just try TCP connect and close connect unexpectly

@czhfe @intfish123
it is kubernetes inside GCP or other cloud provider?
look like healthcheck probe from kubernetes external implementation for service type: LoadBalancer
they just try TCP connect and close connect unexpectly

It is indeed a health status detection problem
I'm using Huawei Cloud, and Huawei Cloud's load balancer has health status detection on by default, so I don't have this problem if I turn off health status detection on my side.
Please tell me where I can see this is the problem.

We've faced we the same issue on GKE with the operator but we have no loader balancer service, only cluster IP service.

But our log is little bit defferent:
2021.10.05 12:42:35.258721 [ 251 ] {} <Error> ServerErrorHandler: Poco::Exception. Code: 1000, e.code() = 107, e.displayText() = Net Exception: Socket is not connected, Stack trace (when copying this message, always include the lines below):

0. Poco::Net::SocketImpl::error(int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) @ 0x13b6c5ee in /usr/bin/clickhouse
1. Poco::Net::SocketImpl::peerAddress() @ 0x13b6e836 in /usr/bin/clickhouse
2. DB::HTTPServerRequest::HTTPServerRequest(std::__1::shared_ptr<DB::Context const>, DB::HTTPServerResponse&, Poco::Net::HTTPServerSession&) @ 0x1100708b in /usr/bin/clickhouse
3. DB::HTTPServerConnection::run() @ 0x11005eee in /usr/bin/clickhouse
4. Poco::Net::TCPServerConnection::start() @ 0x13b738af in /usr/bin/clickhouse
5. Poco::Net::TCPServerDispatcher::run() @ 0x13b7533a in /usr/bin/clickhouse
6. Poco::PooledThread::run() @ 0x13ca81b9 in /usr/bin/clickhouse
7. Poco::ThreadImpl::runnableEntry(void*) @ 0x13ca444a in /usr/bin/clickhouse
8. start_thread @ 0x9609 in /lib/libpthread.so.0
9. __clone @ 0x122293 in /lib/libc.so.6
 (version <IP_ADDRESS> (official build))

does anybody know how to solve this issue?

@nsakovich @ossinkine
issue is not related to clickhouse-operator or clickhouse-server itself
issue related to internal Kubernetes machinery (maybe it service mech control plane health check, maybe it external load balancer health probes)
which create TCP connection to HTTP clickhouse port and abnormally close it
you could run apt-get update && apt-get install tcpdump && tcpdump -i any -w clickhouse.pcap port 8123
watch to /var/log/clickhouse-server/clickhouse-server.err.log found Code: 1000 error time
and look to clickhouse.pcap under wireshark and try to detect what's going on on TCP level and which ip responsible to SYN -> SYN ACK -> ACK -> FIN tcp packets sequence without HTTP request

is there any solution to this exception?

@sonalm https://github.com/Altinity/clickhouse-operator/issues/714#issuecomment-989951599


Unparsed external symbol

When compiling, we encountered an external symbol "WebPConfigInitial" that could not be resolved. This symbol is referenced in the function "wf_myrtille_start"

My compilation environment is visualstudio 2019,openssl-x64

If I remember well, the webp lib is 32 bits only, so wfreerdp have to be compiled in x86 (32 bits). While you are here, you could update it (https://developers.google.com/speed/webp/download).
Regarding webp, I found it interesting to lower the images size (thus the bandwidth), but at the expense of speed. Myrtille use png by default but it can be tweaked here: https://github.com/cedrozor/myrtille/blob/master/Myrtille.Web/js/config.js#L123 (see comments into display.js)
I used the nuget package openssl-vc141-static-x86_64 for openssl (1.1.0) (https://github.com/cedrozor/FreeRDP/blob/master/libfreerdp/packages.config)

In fact, I would like to know what your compilation environment is like, for example, openssl is x64 or win32,visual studio version is 2019 or 2017, or even 2015, I feel that the reason why I can't compile is more of this aspect

    hi：
        I've configured in visual2019 for all except wfreerdp - client for win - x64, only wfreerdp - client configuration is a win32, compiled, compiled by 28 in front of the product that only appeared in the wfreerdp - client here c3861 __readfsdword couldn't find the identifier of the error, I don't know what place is I didn't notice that, unfortunately, for compiling wfreerdp I always failed.The error is shown below:

此致
敬礼！
姓名：叶林
公司：北京欧智科技有限公司
手机：18610944486
<EMAIL_ADDRESS>From: cedrozor
Date: 2019-08-23 22:06
To: cedrozor/myrtille
CC: osswiseyelin; Author
Subject: Re: [cedrozor/myrtille] Unparsed external symbol (#172)
If I remember well, the webp lib is 32 bits only, so wfreerdp have to be compiled in x86 (32 bits). While you are here, you could update it (https://developers.google.com/speed/webp/download).
Regarding webp, I found it interesting to lower the images size (thus the bandwidth), but at the expense of speed. Myrtille use png by default but it can be tweaked here: https://github.com/cedrozor/myrtille/blob/master/Myrtille.Web/js/config.js#L123 (see comments into display.js)
I used the nuget package openssl-vc141-static-x86_64 for openssl (1.1.0) (https://github.com/cedrozor/FreeRDP/blob/master/libfreerdp/packages.config)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm using VS2017 and cmake 3.10; config for wfreerdp is win32 (x86) and config for myrtille is Any CPU.
What is the error message (can't see any in your post)?

I can see my post, but I can reply directly after the email reminder, which is more convenient. As for the compilation problem, I have solved it. The compilation environment compiled successfully in Windows 7-64 as you said. Thank you very much for your support.

        hi:The following picture is the file compiled by me with debug, but it can only be used for CMD, and cannot be put in myrtille's rdptool for web page interaction. I want to know, what else do I need to do after compilation?

此致
敬礼！
姓名：叶林
公司：北京欧智科技有限公司
手机：18610944486
<EMAIL_ADDRESS>From: cedrozor
Date: 2019-08-26 18:52
To: cedrozor/myrtille
CC: osswiseyelin; Author
Subject: Re: [cedrozor/myrtille] Unparsed external symbol (#172)
I'm using VS2017 and cmake 3.10; config for wfreerdp is win32 (x86) and config for myrtille is Any CPU.
What is the error message (can't see any in your post)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

To my knowledge, building wfreerdp in win64 have no real benefits besides going upper 4GB of RAM (which should never happen with a wfreerd process!). I didn't noticed any performance improvement; that's why I remained with a win32 build for myrtille (in addition to linking the Google's webp lib, which is x86), I don't have to package 2 executables and it works on both 32 and 64 bits OSes.
Did you built https://github.com/cedrozor/FreeRDP ? (not the main project, https://github.com/FreeRDP/FreeRDP)

Yes, I build is https://github.com/cedrozor/FreeRDP/releases (Myrtille 2.1.1), after I am trying to find, only under the compilation of the device can be used any wfreerdp, but packaged debug packet to another environment, seems to be missing some dependent, unable to run normally, can only be connected, the connection on screen will be stuck in the first frame, then this should be a gdi rely on such errors, then wfreerdp quit, How do you put all the dependencies into debug and still work on other devices without additional dependencies

    hi:The debug package below is the directory I compiled, and you can probably see which dependencies I missed

此致
敬礼！
姓名：叶林
公司：北京欧智科技有限公司
手机：18610944486
<EMAIL_ADDRESS>From: cedrozor
Date: 2019-08-27 22:51
To: cedrozor/myrtille
CC: osswiseyelin; State change
Subject: Re: [cedrozor/myrtille] Unparsed external symbol (#172)
To my knowledge, building wfreerdp in win64 have no real benefits besides going upper 4GB of RAM (which should never happen with a wfreerd process!). I didn't noticed any performance improvement; that's why I remained with a win32 build for myrtille (in addition to linking the Google's webp lib, which is x86), I don't have to package 2 executables and it works on both 32 and 64 bits OSes.
Did you built https://github.com/cedrozor/FreeRDP ? (not the main project, https://github.com/FreeRDP/FreeRDP)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Can you receive my Debug package?

Hi, you need to build the master branch from https://github.com/cedrozor/FreeRDP. The 2.1.1 release tag is related to myrtille 2.1.1. Sorry about that, I forgot/was a bit lazy to create tags after that. I will do for sure with the next releases!

Hello, yes, according to what you said, I compile successfully and combined with certain dependence can perfect run anywhere, however, after I put him in a myrtille replace original wfreerdp, found myrtille cannot use normally, it should be and I don't know the steps, make wfreerdp in command line mode and use the program call is different, is that so?

Did you tried to run wfreerdp.exe in command line from the myrtille bin folder? you may forgot to copy some dlls

Yes, I can run successfully. Thank you very much for your support during this period of time. I have successfully solved all the problems.


Unable to pin some thread tracks

Hi, I'm tracing a Chromium-derived app on Android and noticed I am sometimes unable to pin some thread tracks. This seems to happen when the track has a collapsed sub-track (?). I can click on the track to show the nested track, but the pin icon is only on the nested track and not on the outer one.
In the screenshot, I can pin the LongTaskTracker nested below the main thread, but there's no pin icon if I hover over the main thread.

Is this expected, or a bug?

This is a bug. We have an internal bug tracking the same issue actually.

Thanks for the lightning-fast response and fingers crossed for a fix, then :)

Actually I already fixed this in https://r.android.com/3391370
I guess we just need to cherry-pick this to stable.


Potential Workaround for AVPro Screen Flickering

Got suggestion in my Discord server, uses a RenderTeture as a buffer may potentially avoids screen flickering.
As observed, this issue was caused by AVPro, not VIzVid. It happens when AVPro's video frame output does not in sync on user's camera view (either with headset or monitor)-- in more particular, at the point where an object (screen mesh) was rendering but the next video frame data was not sent to graphics card yet, thus leaving it a short blank.

As we tested it in this world recently, this approach works.


Struggling to install on Ubuntu

Tried: curl https://github.com/wasienv/wasienv/raw/master/install.sh -L| sh
Result:

Successfully installed wasmer 0.8.0!
wasmer & wapm will be available the next time you open the terminal.
If you want to have the commands available now please execute:
source /home/samcov/.wasmer/wasmer.sh

Installing the required WASI SDKs
sh: 32: wasienv: not found

Then tried:
pip install wasienv --upgrade
wasienv install-sdk unstable
Result: wasienv: command not found
Any suggestions?

Hi @samcov,
This is probably due to the Python/pip binaries not being in the environment $PATH.
Are you using a virtual environment by any chance?

Yes, I'm in VMWare.

Thanks for the report!
We just updated the installation script to fix that issue!
https://github.com/wasienv/wasienv/commit/1984e395af875563d28e8e7879181d56d51f7fff
If you can try again and report if it worked, that would be awesome!
Closing the issue meanwhile

Tried it again, and PERFECTION! The output of the compilation and running it are shown below.
This is the easiest, most productive environment for generating WASM I've seen... Congratulations!
samcov@samcov-virtual-machine:~/Dev/Wasm$ ls
example.c
samcov@samcov-virtual-machine:~/Dev/Wasm$ wasicc example.c -o example
In file included from :1:
/home/samcov/.local/lib/python2.7/site-packages/wasienv/stubs/preamble.h:40:62: warning: declaration of 'struct sigaction' will not be visible outside of this function [-Wvisibility]
attribute((weak)) int sigaction(int signum, const struct sigaction *act,
^
1 warning generated.
samcov@samcov-virtual-machine:~/Dev/Wasm$ ls
example  example.c  example.wasm
samcov@samcov-virtual-machine:~/Dev/Wasm$ ./example Sam
Hello, Sam!

BTW, I also tweeted about this: https://twitter.com/Dewey2000/status/1195239005496823809


viewer: display sharp Retina icons in Safari

The blurry 1x iconset was getting displayed on WebKit browsers that do not
support dppx media queries, including current Safari versions.

/botio-linux preview

Parsing a context-free CSS grammar with regular expressions, with the redundant intention of removing vendor-prefixed CSS directives that Firefox already knows how to ignore is a meritless endeavour that my organisation won't commit resources towards. We'll maintain this patch out-of-tree, closing PR.


Twitter options does not work

It seems to me that Twitter options (conversation) does not work or I did not understand how to configure it. When I use
{% twitter https://twitter.com/Split82/status/766572568585404420 conversation=none %}
I still see the conversation. I have tried to clear the twitter cache but with no effect.

Hi,
After a bit of digging and trial and error it looks like hide_thread=true seems to work - I have no idea why, could be that the Twitter API actually used is subtly different to the documentation. I will update the link in this README to point one of the links below.
Documentation I found: https://dev.twitter.com/web/embedded-tweets https://dev.twitter.com/rest/reference/get/statuses/oembed

Perfect, it is working. Thanks!

👍


ssclj hsqldb DB may hang on checkpoint

This happens on the hsqldb service restart or manual checkpoint of on/off-line DB.
At the moment on prod machines we are using hsqldb 2.3.3.  I tried to checkpoint with 2.3.4, but it didn't help.  Highly likely the problem is in the data itself.

Solution: patience.
The checkpoint of ssclj eventually succeeds, but may take couple of hours.

Here is the size of the ssclj db/log before
-rw-r--r--  1 konstan  staff    35M May 24 14:09 sscljdb.log
-rw-r--r--  1 konstan  staff   185M May 24 14:11 sscljdb.script

and after the checkpoint
[root@bluebox SlipStreamDB]# ll -h sscljdb.script
-rw-r--r-- 1 slipstream slipstream 196M May 24 15:47 sscljdb.script
[root@bluebox SlipStreamDB]#

If hsqldb service star/stop command times out or fails on the checkpoint process here is the direct command to checkpoint the offline ssclj DB
java -jar /opt/hsqldb/lib/sqltool.jar --inlineRc=url=jdbc:hsqldb:file:/opt/slipstream/SlipStreamDB/sscljdb,user=sa,password= --sql "CHECKPOINT;" --autoCommit

I'm closing the ticket.


Migrate community gallery from private package to CLI extension

Is your feature request related to a problem? Please describe.

This is for Azure Compute community gallery private package. Current solution is to use private package Xing Zhou provided. However, it requires user to install python virtual env and it might cause confusion. To have better user experience, we plan to use CLI extension full support for community gallery and edge build link for 'az vm/vmss' deployment for community gallery vm deployment.
Describe the solution you'd like

It is above.
Describe alternatives you've considered

Additional context

https://github.com/Azure/azure-cli/issues/19882

Compute


Possible Blog Article : 2019 Recap

Author: Rinku
Write a blog article recapping our highlights for 2019
(This is a mandatory article, so it will move ahead without roadblocked by voting)

A PR #455 has been created for this issue.

This issue is being closed. Any discussion should be on  PR #455


Color of text not changeable

:clipboard: Description
There is no option that I could find at shields.io that allows to set the background color. This is important in cases where you might want the badge color to be a light one. The default white is not very visible in that case. Or say, someone wants to make the labelColor white!
If you believe that it is unreasonable to expect that, look at this:

You yourself judge which penguin looks better. Then look at the text to see if it is as readable as the text of the IDE you love :wink:
Don't you think the text would have been more readable only if the text was BLACK ?
Oh, why I chose that particular color? It was suggested by simpleicons.org for this logo
Which maniac would choose to do this? ME! :sweat_smile:

TL;DR
Add a new labelTextColor attribute (for the left part) and textColor (for the right part)

I believe you are correct.

:disappointed:

Will not commit to it right now, but I'll keep it in mind

Thanks very much! :smile:

No worries, though if it's okay with you I suggest we close this issue and leave the others open. :)

Of course! :innocent:

I don't know if its just me but this is like, pretty hard to read, at least on my monitor and bad eyes


channels: turn MessageStore into trait

Then supply:

InMemoryMessageStore: inprocess/current process persistence of messages
DBMessageStore: hooks into our DB implementation, also provides table migrations, through a generator

Notes:

In both cases we should strive for most of the logic to turn into a generic logic that appears in the framework, and then some "glue" that appears in code that is generated.
Once we use a MessageStore trait, we can now provide event handlers as well, by chat models. Because we set up the trait in app.rs this can seamlessly persist data to DB, and the user configures almost nothing to get a fully functioning chat.

SingleRoomChatModel - join leaves all channels, then joins a selected room, message appends a message
MultiRoomChatModel - join joins a new room, message selects which room to append to, leave leaves a room

see


Add project seems confusing

Describe the bug

Here it does not show that someone can create a new project by clearing the text and clicking on add button.

To Reproduce
Steps to reproduce the behavior:

Go to https://web.impler.io
Log in to the dashboard.

Expected behavior
It should explicitly indicate that there is a way to create a project.
Desktop (please complete the following information):

Browser: Chrome

We can rename Project to Workspace


RFE: start with with a search phrase.

I.e.
]fire search for this
Would start fire and execute the search with default settings.

The argument is taken; you can do
      ]fire .

to start the search in the current namespace.
I could investigate and when it's not a dot put it into the "Search" field, but I am not particularly keen on this.
If you imply that the syntax should also "press" the OK button: 80% of the problems reported to me were caused by the fact that people did not realize that they had changed some parameter and then forgot about it. When they do not even see it any more, it's probably getting worse.
Why exactly is this important to you? Maybe I am missing something here but you need to type what you want to search for in any case, so that does not make any difference, yes? And saving the time it takes to press  is not exactly a big time saver either.

It seemed like a convenient way to do a quick search.  I imagine It would work even if the gui was already up but hidden by bringing it to the front.
Maybe I should be asking if any of fire functionality will be exposed via an api?

I could make that happen for search; replace is not going to work this way I think - way too dangerous.
The GUI parameters could become options/flags and the argument could be searched for.  It could either be something like
]fire "Search for this" -nogui -case=1|0 ...

Or a completely different user command like
]firenogui "Search for this"  -case=1|0 ...

I would like to know what exactly you want to do with the result. That might be important!

I agree about replace now being a smart idea.
My use is a quick find a list of all hits.  Maybe a summary table of first 10 matches and a note that more exist.
Would using regex be an option?  I think less switches is better.

I dislike the idea of restricting the output; there are better ways to do this.
I think the list of names should be returned as a nested matrix with one column. That could then either be assigned to a variable or put on display with the editor.
Watch this video:
https://www.dropbox.com/s/nk2ktlrn8fpcs7r/QED.mp4?dl=0
Would you like to see ⎕ED as part of the syntax of the user command framework? I've suggested this to Dyalog many times over the last 5 or so years....
Although I think it should be possible to say
RegEx are no problem but you need to specify -regex for this.
The switches would all have defaults, so you specify only those you need to change.

Completely irrelevant but I don't think there is an uglier syntax than
]q←doSomething

It should have been q←]command really.
HTMLRenderer:

That makes it version dependent: at least 17.0. Not an option.

Why? If you want poper output you have to go via the GUI. It is all there. Only a list in the session makes kind of sense.


deleteScript can now be a callback

Not that anyone asked for it to my knowledge, but this is a handy option that I'm using on my server.
The signature of Image.deleteFile changed to take the jQuery element, instead of src. It now checks if your deleteScript option is a function, and if so passes the element to the callback allowing the end developer to get whatever info they need from the element and make their own AJAX call, if they desire.
The other delete options are ignored in this case, and it is up to the end developer to handle their AJAX options.

Use case: I'm using an API to handle my images that requires making a request like DELETE /api/v1/image/42, where 42 is the image's unique id. This is very difficult to do under the current structure. This modification allows you tons of freedom when deleting. If you want to use the old behavior, your code need not change.
I have never worked on a JS project, please be gentle.

@derrekbertrand thanks. Good idea. I left you just one comment regarding backwards compatibility. After that's done, we can merge this.

@orthes Where's the comment? I checked my branch's commit, and I don't see anything.

@derrekbertrand it's here in the pull request.

Can you make Images.prototype.deleteFile function backward compatible for people using the current implementation? For example leave the first attribute as it was before (string) and add $file as a second attribute. And pass both also to deleteScript function for consistency.

Definitely. I'll do that Monday, and I'll update the docs too.
On Jun 3, 2017 6:49 AM, "Pavel Linkesch"<EMAIL_ADDRESS>wrote:

@derrekbertrand https://github.com/derrekbertrand it's here in the pull
request.
Can you make Images.prototype.deleteFile function backward compatible for
people using the current implementation? For example leave the first
attribute as it was before (string) and add $file as a second attribute.
And pass both also to deleteScript function for consistency.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/orthes/medium-editor-insert-plugin/pull/428#issuecomment-305967435,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7GPIpZ5QlwJVGQ0iSb7Rv2pLZo1DqHks5sATo7gaJpZM4NudhB
.

@orthes I believe this will do it. I'll see if I can find some docs to update.


Replace html title with tokens.

Fixes #4439
@mikefantini I think on production/stage right now the setting is ['site:member-count'] and it will need to be changed to [site:'member-count-readable']

:+1:


Create a slack ?

Would it be interesting to have a bento-starter slack ?

An other possibility would be Gitter. It seems pretty great to talk with a dev community. What do you think about that ?
Slack is also great.

More people knows slack don't you think ? Discord is also an option

Well, let's try with Slack. We already know well this tool. ;)


Squashed version of #9515.

Fixes #9512
Closes #9515

@shoyer if I am merging someone's and it just needs squashing I do it on the command line
merge to master and push directly
I normally don't created another pr (but if this works for u then ok)

@jreback K, I'll do that next time. Thanks


fix: modify minimal preset's field elements per blob to mainnet for dev runs

As part of by parts integration of free the blobs PR

https://github.com/ChainSafe/lodestar/pull/5181

For devnets started using cli in minimal and for the merge interop/inline tests, the FIELD_ELEMENTS_PER_BLOB needs to be set to 4096 which is the mainnet value
because all kzg libraries and ELs process the blobs on this size and is a hardcoded value in them. We only need minimal value for spec tests which does not use the cli path or will not be providing DEV_RUN flag on test setup

:tada: This PR is included in v1.9.0 :tada:


docker: update rust image used to specific bullseye version

'rust:1' was recently updated and doesn't support openssl v3.
The simple-kbs runs without crashing using the 'rust:1.72.0-bullseye' tag.
Fixes: #61

Hi,
I'm still getting the same error "error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory" with 'rust:1.72.0-bullseye', any idea?


Add suport for "console" backend

Is your feature request related to a problem? Please describe.
Users might already be using a terminal library for other tasks, one that is not crossterm, so ideally we should be able to use that too instead of forcing the user to have multiple dependencies for the same thing.
Describe the solution you'd like
Add a new implementation for the Terminal trait, and select different types that implement it based on feature flags.
This issue is meant to track the support for the console backend
Additional context
Following requestty's footsteps :D

Added on main and updated on multiple commits, but it is closed :)
https://github.com/mikaelmello/inquire/commit/03408c10e0f1db2ac667dc98057d87a593a87557


REST Request IDs

#1001

@ricardopereira is this ready for review

@jamienewcomb not yet. I'm need run the test suite on my machine to see what's failing.

@ricardopereira Okay, are you looking to complete this over the next few days?

Deleting my above comment. I will link to this PR in Jira

Arrg, I forgot to squash the fixes 😩

@ricardopereira , correct me if I am wrong, request-id is different for different request right ( ofc if not retried to fallback host )

Hello @sacOO7. Yes, that's correct.


Migrate azure-maps-elevation to azure-json

Description
Migrate azure-maps-elevation to azure-json.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/check-enforcer override


How to use the library independently

I don't use akka in my project, or I can add akka dependency. But now I need to serialize Scala or Java classes, how should I use them?

I'd say use Kryo directly. This project is about integrating Kryo into Akka serialization.

OK, thank you for your advice.


fix typo in apollo-design.md

What's the purpose of this PR
fix typo in design page
Which issue(s) this PR fixes:
Fixes #
Brief changelog
fix typo in apollo-design.md
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

Summary by CodeRabbit

Documentation

Updated the sequence diagram to reflect communication from Portal to Admin Service instead of Config Service.
Corrected minor text related to metrics.

Thanks for your contirbution. Would you like to check the CLA? :)


test: updated filter tests

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: test/UpdateFilterTests

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
55.09 (-0.01)
37.06 (-0.01)
33.86 (0)
55.58 (-0.01)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.04 (-0.22)
40.42 (-0.83)
34.48 (0)
55.96 (-0.26)

/ok-to-test sha=5e727f1

/ok-to-test sha=13abaf6

/ok-to-test sha=13abaf6

/ok-to-test sha=163288d


Running CI with latest develop for "Rebasing put frame return error codes support start stop"

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6af9a7a) 16.38% compared to head (b6a5bad) 16.32%.
 Consider uploading reports for the commit 947b120 to get more accurate results

Files
Patch %
Lines

src/gstreamer/gstkvssink.cpp
0.00%
17 Missing :warning:

src/KinesisVideoStream.cpp
66.66%
1 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1119      +/-   ##
===========================================
- Coverage    16.38%   16.32%   -0.06%
===========================================
  Files           51       51
  Lines         6849     6854       +5
===========================================
- Hits          1122     1119       -3
- Misses        5727     5735       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[6.0] Fix LLDB Swift data formatters breaking Swift code debugging

Explanation: Because the data formatter for the compiler internals was registering itself as swift, it was hiding the default data formatters for swift code.
Scope: Internal data formatters
Original PR: #72576
Risk: None
Testing: N/A
Issue: rdar://125114526
Reviewer:  @adrian-prantl

@swift-ci please test


fix: xsky recode using endpoint as accesskey key

这个 PR 实现什么功能/修复什么问题:
修正：xsky代码重构是用了endpoint信息作为access信息，导致账号认证失败

是否需要 backport 到之前的 release 分支:

release/3.1
release/3.2

/cc @zexi  @yousong
/area region

Codecov Report

Merging #6740 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6740      +/-   ##
==========================================
+ Coverage    7.13%    7.15%   +0.01%
==========================================
  Files         648      648
  Lines      109488   109488
==========================================
+ Hits         7817     7830      +13
+ Misses     101072   101059      -13
  Partials      599      599

Flag
Coverage Δ

#aFlag
7.15% <ø> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/validators/validators_cert.go
39.77% <0.00%> (ø)

pkg/appsrv/response.go
69.11% <0.00%> (+2.94%)
:arrow_up:

pkg/cloudcommon/cronman/cronman.go
53.95% <0.00%> (+5.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d75932...de081a7. Read the comment docs.


Do NOT use this!

Do not use this plugin!
1. React is a dependency
This plugin has react as a dependency: it should not be. If you use this plugin, you'll end up with 2 different React packages in your bundle, increasing its size significantly.
2. You don't even need it!
Want ads? Copy .cache/default-html.js to your src folder, renaming it to html.js. Add your AdSense script tag to the head of that file. This replicates this plugin exactly.

@davwheat I have installed the plugin, and then seen your comment.
What is the right way to remove it including the react dependency?
These are the current dependencies in my package.json:
"dependencies": {     "@mdx-js/mdx": "^1.6.22",     "@mdx-js/react": "^1.6.22",     "babel-plugin-styled-components": "^1.12.0",     "disqus-react": "^1.0.8",     "gatsby": "^2.32.0",     "gatsby-image": "^2.11.0",     "gatsby-plugin-catch-links": "^2.10.0",     "gatsby-plugin-compile-es6-packages": "^2.1.0",     "gatsby-plugin-google-adsense": "^1.1.3",     "gatsby-plugin-google-analytics": "^2.7.0",     "gatsby-plugin-manifest": "^2.12.0",     "gatsby-plugin-mdx": "^1.10.0",     "gatsby-plugin-offline": "^3.10.0",     "gatsby-plugin-page-creator": "^2.10.0",     "gatsby-plugin-react-helmet": "^3.6.0",     "gatsby-plugin-sharp": "^2.14.0",     "gatsby-plugin-styled-components": "^3.10.0",     "gatsby-remark-autolink-headers": "^2.11.0",     "gatsby-remark-copy-linked-files": "^2.10.0",     "gatsby-remark-images": "^3.11.0",     "gatsby-remark-prismjs": "^3.13.0",     "gatsby-remark-responsive-iframe": "^2.11.0",     "gatsby-remark-smartypants": "^2.10.0",     "gatsby-source-filesystem": "^2.11.0",     "gatsby-transformer-remark": "^2.16.0",     "gatsby-transformer-sharp": "^2.12.0",     "prismjs": "^1.23.0",     "react": "^17.0.1",     "react-dom": "^17.0.1",     "react-helmet": "^6.1.0",     "styled-components": "^5.2.0",     "terser": "^4.6.11"   },   "devDependencies": {     "lighthousebot": "https://github.com/GoogleChromeLabs/lighthousebot",     "prettier": "^2.2.1",     "puppeteer": "^5.4.1",     "semantic-release": "^17.2.2",     "yaml": "^1.6.0"   },   "peerDependencies": {     "gatsby": "^2.20.0",     "react": "^17.0.0",     "react-dom": "^17.0.0"   } }

@luba-media You just need to remove this plugin. Running yarn or npm i will updated your deps and fix the double React.
To be extra sure, use the Gatsby Webpack Bundle Analyzed plugin and build your site locally -- you should be able to see all your deps there and check there's no duplicate React.
By the way, if you want to cut down that bundle size more, check our the Gatsby Preact plugin. Preact is a smaller version of React and Preact can be an almost drop-in replacement unless you're doing VERY complex things with React.

@IsAmrish moving react to the peer-dependancy should solve this problem.


A large language model like GLM does not seem to apply to the three examples given

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code

Error Message and Stack Trace (if applicable)
No response
Description

System Info

Please fill out the issue as instructed. I don't know what this ticket is about.


Add GitHub link and/or link to the project site (instead of the typedoc site), to the default theme?

Search Terms

Would it be possible to add a GitHub link and/or a link to the actual site (instead of the typedoc site), to the default theme?
Problem

I find for typedoc sites, I get to the typedoc site, and would like to return back to the original site, or just go to the GitHub page for the current project, and am unable to, e.g. barba.js.org/api (there is no button or link to the original site for barbajs, it's not a major problem, but it throws me off a bit, and I feel I'm not the only one who finds it off putting)
Suggested Solution

Add a GitHub button and/or a original site button to the navbar of the default typedoc theme.

Seems like a reasonable request, I think the links in the header should really be user configurable - there isn't an easy way to guess what they should be, some people might want to link to the Slack/Gitter/Discord/whatever for support for example

It would also be cool if we could add a link that could link to the projects original webpage, I think adding support for common link types should be good enough, e.g. discord, slack, github, etc..., if the users needs more than that they probs could configure the theme themselves (it would be awesome if the docs gave some example code to make getting started with this specific task easier)

This is a feature I am missing very much as well.
This can be implemented as an array in typedoc options, with items specifying links, text and maybe an icon asset (if the latter is complicated - I can live without it, no problem - just having the right links with plain title is 1000 times better than not having them at all. Rollup documentation is an example with plain text links).
The place where I expect to see the links is dedicated for some filters that has no use for me and I had to put some effort to hide with CSS.
I much prefer to see the links either in what's currently called tsd-page-toolbar or tsd-page-title.
I think current design of search and filter is unintuitive (search) and not very useful (filters). I'd think where to move and how to make them more useful instead.


Bump prettier from 2.8.8 to 3.0.3

The breaking change that affects us is that commas are now applied to the last argument of a multiline function call. Prettier is finally giving up support for Internet Explorer 11, which was the last browser that did not support this in its JS engine.
Closes #1365

ugh, how many changes :)
let me cleanup the review queue a little then before merging this one otherwise we might have to rebase everything.

I think we can merge this one, could you rebase it @sealer3 plz?
Also, I think you committed your local changes to config.json accidentally, can you remove it from the PR plz?

I rebased and also ran prettier-plugin-organize-imports so we can merge both substantial changes at the same time.


SCNMatrix4 init issue

Cannot invoke 'SCNMatrix4.Type.init' with an argument list of type '(matrix_float4x4)'
any fix ?

Are you using xcode beta 2 ? The swift apis have change slightly.

Xxode beta 1

Try upgrading and see if you still get the error.

Beta 2 fixes it, I had this same issue

yes upgrading solved the problem


Agent knows how to correctly proceed, but uses tool incorrectly anyways

System Info
platform: macOS-13.2.1-arm64-arm-64bit
Python 3.11.3
langchain                0.0.212
langchainplus-sdk        0.0.17
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[X] Agents / Agent Executors
[X] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I'm trying to get my Agent to correctly use my tools - from it's internal dialogue I can see it knows it's about to use a tool incorrectly but then it just goes ahead and does it resulting in an exception from my arg schema.
Here's the input and output with my agent:
💬: add a todo to by tortillas to my grocery shopping todo

Entering new  chain...
Action:

{
  "action": "save_sub_todo",
  "action_input": {
    "name": "Buy tortillas",
    "tags": ["grocery shopping"],
    "parent_id": "ID of the grocery shopping todo"
  }
}

Replace "ID of the grocery shopping todo" with the actual ID of the todo for grocery shopping. You can use get_all_todos() to find the ID if you don't know it.
Traceback (most recent call last):
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/term.py", line 32, in <module>
    Fire(run)
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/.venv/lib/python3.11/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/.venv/lib/python3.11/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
                                ^^^^^^^^^^^^^^^^^^^^
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/.venv/lib/python3.11/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/term.py", line 24, in run
    response = agent.run(user_input)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jacobbrooks/PythonProjects/jbbrsh/.venv/lib/python3.11/site-packages/langchain/chains/base.py", line 290, in run
    return self(args[0], callbacks=callbacks, tags=tags)[_output_key]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Here are the tools I'm passing to my agent:
class TodoInput(BaseModel):
    name: str = Field(description="Todo name")
    tags: List[str] = Field(description="Tags to categorize todos")

@tool(return_direct=False, args_schema=TodoInput)
def save_todo(name: str, tags: List[str]) -> str:
    """
    Saves a todo for the user
    The string returned contians the todos name and its ID. The ID can be used to add child todos.
    """
    notion_todo = NotionTodo.new(
        notion_client=_notion,
        database_id=DATABASE_ID,
        properties={
            "Tags": tags,
            "Name": name
        }
    )
    _notion.todos.append(notion_todo)
    return f"todo saved: {notion_todo}"

class SubTodoInput(TodoInput):
    parent_id: str = Field(
        description="ID for parent todo, only needed for sub-todos",
    )

    @root_validator
    def validate_query(cls, values: Dict[str, Any]) -> Dict:
        parent_id = values["parent_id"]
        if re.match(r"[\d\w]{8}-[\d\w]{4}-[\d\w]{4}-[\d\w]{4}-[\d\w]{12}", parent_id) is None:
            raise ValueError(f'Invalid parent ID "{values["parent_id"]}"')
        return values

@tool(return_direct=False, args_schema=SubTodoInput)
def save_sub_todo(name: str, tags: List[str], parent_id:str) -> str:
    """
    Saves a child todo with a parent todo for the user

    The string returned contians the todos name and its ID, The ID is formatted like so "f1ab8b74-6b67-46b1-81ec-519805c7a1cb"
    Do not make up IDs! use get_all_todos to find the best ID if a real one is unavailable.
    """
    notion_todo = NotionTodo.new(
        notion_client=_notion,
        database_id=DATABASE_ID,
        properties={
            "Tags": tags,
            "Name": name,
            "Parent todo": parent_id
        }
    )
    _notion.todos.append(notion_todo)
    return f"todo saved: {notion_todo}"

@tool
def get_all_todos():
    """
    Returns a list of all existing todos.
    Useful for finding an ID for an existing todo when you have to adda  child todo.
    """
    return '\n'.join([
        f"'{t.name}' {'Complete' if t.complete else 'Incomplete'} id={t.id} parent_id={t.parent_todo}"
        for t in _notion.todos
    ])

Here's how I'm creating my agent
_system_message = """
Your purpose is to store and track todos for your user

When using Tools with ID arguments don't make up IDs! Find the best ID from looking through all todos.
"""
llm = ChatOpenAI(temperature=0)
memory_key = "chat_history"
chat_history = MessagesPlaceholder(variable_name=memory_key)
memory = ConversationBufferMemory(memory_key=memory_key, return_messages=True)

agent = initialize_agent(
    llm=llm,
    tools = [HumanInputRun(), *tools],
    agent=AgentType.STRUCTURED_CHAT_ZERO_SHOT_REACT_DESCRIPTION,
    memory = memory,
    agent_kwargs={
        "system_message": _system_message,
        "memory_prompts": [chat_history],
        "input_variables": [
            "input", "agent_scratchpad", memory_key
        ]
    },
    **kwargs
)
return agent

Expected behavior
The bot init's internal dialogue knows that it's about to use an invalid ID, and it knows how to go about getting the real ID

Replace "ID of the grocery shopping todo" with the actual ID of the todo for grocery shopping. You can use get_all_todos() to find the ID if you don't know it.
But it just goes ahead and uses the tool resulting in an exception.

The Agent should acknowledge this insight, use the tool it knows it should use to get the proper ID, and then reformat the initial tool attempt with the legitimate ID.

+1

Geeze this post is from last year. and issue still remains?


Name fixing

Why:
Noticed some name inconsistencies in some folders and tried to fix manually some of them, might fix more if I find time or I may write a script to do so by file extension
What's being changed:
Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Done @harshraj8843 !

The changes u mentioned gonna improve org so go ahead with that 🎉. Also which repos will be archived 🤔 do will still approve prs or it is automated?

So after the 5 contributions, how is one can contribute?

there will be no requirement to update README(s) and folder(s). Github action will take care of it.

Thats great I also wanted to know how to create these github actions 👀

good first issues will be tweeted to Twitter to help other contributors find new good first issues

Yeah twitter bot is great for good first issues it will increase interaction in community 👍 Eddie also have one https://github.com/EddieHubCommunity/good-first-issue-finder
We can follow eddiehub for more such ideas.


add retries for http requests

/hold

/lgtm
Out of curiosity, did you face this problem a lot?

/lgtm
Out of curiosity, did you face this problem a lot?

Not sure what problem are you referring to, however we face a reasonable amount of 503 from AI Rest API. I believe connections are not drained properly, and during cluster upgrades and possibly deploys 503 are relatively frequent.
Also we get a few connection timeouts from elasticsearch service (not sure why, AFAIU we handle gracefully shutdown of this process, maybe some tiny glitch with AWS service, as errors are very few compared with operations performed).
Also we've improved error handling on conditions that should never happen, although they did happen for example because of index maintenance. I think in those cases it adds resilience to the code, although the error is not frequent at all.
Hope I answered your curiosity, if not just let me know :)


Autocomplete dropdown for images in markdown

Thanks for the Markdown editor support in Visual Studio Code.
Feature suggestion:
An autocomplete drop-down for image paths while working with Markdown(md) files can be a helpful feature.

The syntax for adding images in Markdown:
![image description](image path)

If there was a autocomplete suggestion drop-down for the image path in the above command, working with large Markdown documentation files with lots of images will become way more easier to add new images and eliminate broken links when the attachments are moved from source

Hello, @mjbvz , I would like to contribute here. I think we can have a new settings key "markdown.ImagesPath" - which defines the path of images for a folder. If this is the right approach to go with where can I start on this ? If this is not the right approach can you suggest me a right one and where I can start digging through so that I can make things clear.

This is already done (see the changelog) if you won't mind adding one more extension. 😏

@yzhang-gh  What I've see is that this still does not work without relaunching VSCode i.e when new images are added to a folder, they do not appear on the auto-complete suggestions until VSCode is relaunched.
Thanks!

Seems to work well on my laptop. Maybe you have a special file structure? You can file an issue here, better with some reproducing steps.

Okay thanks will try that!


Add ioredis v5 support

The ioredis v5 was released a few days ago 🎉

Thank you! This client seems to be compatible. I’ve added units tests for it. Were you having problems using it with keyv-anyredis?

I'm facing the following typing issue:
error TS2345: Argument of type 'Cluster' is not assignable to parameter of type 'CompatibleRedisClient'.
  Type 'Cluster' is not assignable to type 'CompatiblePromiseRedisClient'.
    Types of property 'set' are incompatible.
      Type '{ (key: RedisKey, value: string | number | Buffer, callback?: Callback<"OK"> | undefined): Promise<"OK">; (key: RedisKey, value: string | ... 1 more ... | Buffer, get: "GET", callback?: Callback<...> | undefined): Promise<...>; (key: RedisKey, value: string | ... 1 more ... | Buffer, nx: "NX", callback?: Callback<.....' is not assignable to type '(key: string, value: string, expiryMode?: string | undefined, time?: number | undefined) => PromiseLike<unknown>'.
        Types of parameters 'callback' and 'expiryMode' are incompatible.
          Type 'string | undefined' is not assignable to type 'Callback<"OK"> | undefined'.
            Type 'string' is not assignable to type 'Callback<"OK">'.

I’ve tightened up the TypeScript typings and this should work as of version 3.1.0. Sorry about that!


THR316 - Is this supported

I installed the plugin and have one device THR316  - it is thermostat switch.
Can i use it as summation selecting
"thDevices": [
{
"label": "Pool",
"deviceId": "10017703e6",
"deviceModel": "th",
"showAs": "default"
}
],

Hi @rionshin
Yes this device should be supported and you can use the existing Sonoff TH10/16 as the device model in the config.
In the next version of the plugin I will update this label to include the Sonoff THR316 and THR320.
Thanks!

Hi,
Closing this just as been a little overwhelmed with issues recently.
If this is still an issue or a feature you would like implemented then please do re-open this ticket!
Thanks for your understanding!


New icon set, improved icon colors

The goal here is mainly to use a good enough icon set for now that generally has everything we need instead of spending time creating shitty icons myself. So, you'll notice some icons you'll like more than the old ones, and some you'll like less. Overall, it's an improvement, though.
They will initially look bad to you because you're used to the old ones... Give it a little time.
Another improvement is making the icons in the header the same color as in the tab bar. Equalizes their importance a bit.

Demo.

Also, I just picked the icons I thought were appropriate, let me know if any of them need to change.

icomoon(1).zip
Unzip this and open demo.html if you want to browse all the available icons in this set


unable to start grafana on 16.04

t=2018-01-16T11:06:02+0000 lvl=eror msg="Failed to write pidfile" logger=server error="open /grafana-server.pid: permission denied"

fixed it by adding the pid file according to this

@m1schka and @john-delivuk I've merged a PR that should handle this.
please let me know if the problem persists.
thank you!


#minor upgrade babel config with polyfills

It allows to use the built-in polyfills when webpack target is web, otherwise no need of them.
It allows to use all the plugins already included in @babel/preset-env if needed.
Removals of installed modules not needed.
The main goal of this PR is to run the server side faster, with less transpiled code, because the Node.js 14 version doesn't need to be transpiled at all, it can run ES2016 or ES 2017 easy without any plugins added.


Code highlights broken when [[ included

Describe the bug
When in a code block, using the characters [[ produces incorrect output.
To Reproduce
Steps to reproduce the behavior:

Put the following code block on a page.

if [[ "$@" == "test" ]]; then
    echo "this is a test!";
fi

Render the site.
See the following output

if span> &; then
    echo "this is a test!";
fi

Expected behavior
The code block should render as follows:
if [[ "$@" == "test" ]]; then
    echo "this is a test!";
fi

Screenshots
No screenshot, but the behaviour can be seen on this page
Desktop (please complete the following information):
I've replicated this issue when rendering the website on macOS, Linux (ubuntu) and Windows 10.

Device: Desktop
OS: MacOS / Linux / Windows
Browser: All (N/A)

Additional context
Nothing relevant.

Possibly related to #288

This issue should be fixed in Quartz 4. I'll be closing it for now but please reopen this issue if this persists in the new version.


Add support for interface localization

It would be great to be able to interact with Sinopia in other languages.  I imagine most early-adopters are able to work with it in English, but many other potential users would be de-facto barred from using this useful environment without local-language support in the interface.
A minimal level of L10N would be making all the interface strings translatable by one of the existing frameworks.
Deeper support would be to also adapt UI layout to right-to-left languages, but I understand that is a much larger undertaking, probably out of scope for the current budgeted iteration.

what work is required to "make all the interface strings translatable by one of the existing frameworks"? @justinlittman @jermnelson has your team done this before, perhaps with DLME?

Will require investigation. We've never done this with a React app.

making this a research task for Work Cycle 4: assess what would be required to support interface localization

thanks this is helpful. changing title of ticket and putting it in backlog for consideration for future Work Cycle


added dark mode for analog clock

🛠 Fixes #976
Closes #976

👨💻 Changes proposed
I have added a toggle checkbox that allows us to switch between light and darkmodes. For this I have used basic java script to change the colors based on the status of the checkbox.

✅ Check List (Check all the applicable boxes)

[x] You have linked this PR to the correct issue.
[x] My code doesn't break any part of the project (Zero Octave-Javascript-Projects).
[x] This PR does not contain plagiarized content.
[x] My Addition/Changes works properly and matches the overall repo pattern.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
As the color of the numbers on the clock is fixed, we couldn't change them. However grey suits both the themes. Here is the preview of light and dark mode UI/UX designs of Analog clock.

📷 Screenshots

Yeah sorry. I deleted it accidentally. Currently I have made some changes to address issue #928 . Can I commit both the changes together here? Or shall a open a new PR?

Yeah sorry. I deleted it accidentally. Currently I have made some changes to address issue #928 . Can I commit both the changes together here? Or shall a open a new PR?

It is always recommended to work on different issues using separate branches in order to maintain a clean history.
Additionally, since the issue in question has not been assigned to you, you can proceed with working on it if the assigned person does not submit a pull request (PR) in a timely manner.
Just commit the changes for this pull request here and refrain from addressing any other issues in this pull request.

Thank you @aysal04 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

It was an amazing experience contributing for the first time to an open source. Thanks to my mentor for such an amazing guidance

It was really an amazing experience contributing for the first time to an open source. Thanks to you for being so supportive.

Appreciate your contribution :)

It was really an amazing experience contributing for the first time to an open source. Thanks to you for being so supportive


Make SecurityService.postProcessRequest call async

Stop doing a blocking wait when calling
SecurityService.postProcessRequest for GET/HEAD/DELETE. This allows for
remote calls to be made in implementations of this method.

Codecov Report

Merging #1058 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1058      +/-   ##
============================================
- Coverage     68.56%   68.49%   -0.07%
+ Complexity     4805     4801       -4
============================================
  Files           382      382
  Lines         30408    30382      -26
  Branches       3867     3860       -7
============================================
- Hits          20848    20811      -37
- Misses         8526     8529       +3
- Partials       1034     1042       +8

Impacted Files
Coverage Δ
Complexity Δ

...ava/com.github.ambry.frontend/FrontendMetrics.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...github.ambry.frontend/AmbryBlobStorageService.java
94.9% <100%> (+2.19%)
44 <1> (+1)
:arrow_up:

...java/com.github.ambry.store/CompactionManager.java
86.75% <0%> (-2.65%)
19% <0%> (ø)

...github.ambry.rest/AsyncRequestResponseHandler.java
88.59% <0%> (-2.29%)
23% <0%> (ø)

.../java/com.github.ambry.router/DeleteOperation.java
92.19% <0%> (-1.42%)
47% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
70.84% <0%> (-0.65%)
102% <0%> (ø)

.../main/java/com.github.ambry.router/PutManager.java
87.17% <0%> (-0.65%)
26% <0%> (ø)

...src/main/java/com.github.ambry.commons/BlobId.java
86.97% <0%> (-0.43%)
59% <0%> (-1%)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...va/com.github.ambry.replication/ReplicaThread.java
72.61% <0%> (-0.41%)
59% <0%> (-1%)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca33b4...62c4c85. Read the comment docs.


fix OpenStack_2_NodeDriver.detach_volume

Since https://github.com/apache/libcloud/pull/1242 the OpenStack_2_NodeDriver uses a volume object returned via volumev2_connection. This object will not contain serverId but server_id. This PR makes the detach_volume method compatible with v2 volumes.
Fixes:
return connection.detach_volume(volume)
File "/usr/local/venv/project/src/apache-libcloud/libcloud/compute/drivers/openstack.py", line 328, in detach_volume
(attachment['serverId'], attachment['id']),
KeyError: 'serverId'

Codecov Report

Merging #1267 into trunk will decrease coverage by <.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##            trunk    #1267      +/-   ##
==========================================
- Coverage   85.76%   85.76%   -0.01%
==========================================
  Files         356      356
  Lines       72730    72742      +12
  Branches     6579     6581       +2
==========================================
+ Hits        62380    62390      +10
- Misses       7729     7731       +2
  Partials     2621     2621

Impacted Files
Coverage Δ

libcloud/compute/drivers/openstack.py
85.24% <0%> (ø)
:arrow_up:

libcloud/test/compute/test_openstack.py
94.89% <66.66%> (-0.21%)
:arrow_down:

libcloud/test/compute/test_upcloud.py
91.39% <0%> (+1.32%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3ebe5...79cdd3a. Read the comment docs.

@micafer could you take a look at this one?

failing tests because of https://github.com/apache/libcloud/pull/1271


CASMMON-359: Not getting UAN node metrics on grafana smartmon dashboard.

Summary and Scope
Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?
Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

Resolves: https://jira-pro.it.hpe.com:8443/browse/CASMMON-359

Testing
List the environments in which these changes were tested.
Tested on:
Starlord
Test description:

Reverted the code at csm side


Update videospringboard screen

Adds favorites to tv episodes, tv shows also add resume time

We already got all of this right?

I am pretty sure you can close that one. Its already there yeah.


Adds the doxygen html to the readthedocs space

This adds a link to the doxygen documentation from the readthedocs/sphinx homepage. It also autobuilds the doxygen in readthedocs. The new documentation is available for preview here. It resolves https://github.com/LLNL/serac/issues/7

LGTM

Yep! I have ideas about using breathe/exhale to make it prettier, but this is at least a start.

LGTM

LGTM


Notes after a test run

Hi Marc,
first of all - great job done!!! The app is a miracle! We tested with six singers over two full-day rehearsals and they loved it! Had also two iPads connected and a laptop with Ableton Live, sending commands to the SD9. Nice thing is that we have OTH OSC commands punched in the ABL session and they worked along the iPad command-set, as we have both loaded in the console. So the console seems to accept multiple command-sets at a time.
The admin section is pretty intuitive, although a few minor touches would be nice:

a hint to add a DiGiCo iPad external device to the console, not OTH OSC ... that took me like 30mins to realize :-D
be a little more specific about receive and send ports, eg. "console's send"; these binary things always give me a headache
add channel numbers to the channel section

We've also had a few issues, my notes from the rehearsal:
Error connecting new web client
console log:

New Connection
/home/admin/oscwebmixer2/OSCWebMixer2/index.js:133
order: config.channels[i].order,
^
TypeError: Cannot read properties of undefined (reading 'order')
at buildConfig (/home/admin/oscwebmixer2/OSCWebMixer2/index.js:133:32)
at WebSocketServer. (/home/admin/oscwebmixer2/OSCWebMixer2/index.js:192:15)
at WebSocketServer.emit (node:events:517:28)
at WebSocketServer.completeUpgrade (/home/admin/oscwebmixer2/OSCWebMixer2/node_modules/ws/lib/websocket-server.js:431:5)
at WebSocketServer.handleUpgrade (/home/admin/oscwebmixer2/OSCWebMixer2/node_modules/ws/lib/websocket-server.js:339:10)
at Server.upgrade (/home/admin/oscwebmixer2/OSCWebMixer2/node_modules/ws/lib/websocket-server.js:114:16)
at Server.emit (node:events:517:28)
at onParserExecuteCommon (node:_http_server:931:14)
at onParserExecute (node:_http_server:825:3)
Node.js v18.19.0

Note:

Config of the digico session has changed during runtime - channels added.
Order of channels in the admin section was changed before adding new channels to console.

Webapp gets disconnected, but does not notify the user

Probably only when app saved as a desktop app, it seemed to work correctly in a common browser - Safari, Chrome
Tested on iPhone and Android

And finally a handful of "nice-to-have" feature suggestions:

logarithmic scale on app faders, now they seem to be linear
name of current snapshot in client app header

I have added that as a plugin, but changes to mixer.js obviously needed to be done too
After receiving “/Snapshots/Current_Snapshot” save snapshot number to a global var and send “/Snapshots/names/?” to receive the whole list; pick the correct number, get args[3] (snap name) and send an arbitrary msg to the clients to update the .innerHTML

(Low priority) add an aux output level meter to the client app

Thanks a lot for all the great work, we will definitely send a contribution!
Regards, Lukas

Hi Lukas. Great. I'm glad you managed to get it to work!
I used the system over the weekend as well and noticed the faders were linear as well. I actually released an update for this yesterday, so if you get the latest version this should be much better.
I would like to see an aux output level meter in the client app but I'm not sure if DiGiCo expose this data over OSC. Have you seen any metering in the DiGiCo iOS app?
Thanks for the other feedback. I will work on these when I can.

Yes, the console sends it - "/Meters/...". I actually had to block these from the console to be able to read something useful.
The iPad app also request session filename every 5 seconds or so. A bit annoying.. :)

Oh, that is interesting. I didn't notice the /Meters but it could have something to do with my setup. The SD9 I'm using doesn't have Stealth Core 2 so that might be the difference. Do you have stealth core 2?
The session filename is annoying. Seems strange that it has to ask so often. I could probably cache the value so that we don't have to broadcast it to everything that is connected.
I haven't been able to replicate the issue with the webapp ui not updating when its disconnected. Do you have any more details about this issue?
Where in the interface were you displaying the snapshot to the user? I'm thinking the best spot would be at the top just under the toolbar but I haven't tried it yet.

Yes, it's core 2.
The issue only happened in the "desktop app". I guess it uses some simplified browser core and it does not handle ws correctly. No problem in a "normal" browser window.
I added a  directly to the body so it showed at the bottom by default. Was lazy to fiddle with CSS more... But I agree - best spot would be below the AUX selection.

Thanks.
How are you creating the desktop app? Are you on windows or mac?
I discovered today that the metering shows up if you are on the mix tab of the iPad. I should be able to get the metering working.
I released a small update today with some fixes for your other items.

Hey @luprchal, I just released a new version of webmixer that displays the current snapshot. Please have a play with it and let me know what you think.

I'm closing this issue as I believe its all sorted


Unable to find version v0.4.1

Hy @mpdude,
I am trying to use v0.4.1 but it is unable to find by github actions then I tried for the previous version v0.4.0 but it is not working also because --set-env: is being deprecated by github.

That's strange – https://github.com/webfactory/ssh-agent/tags, the v0.4.1 version is clearly there.
Can you share your action configuration and the output of the action run?

Feel free to reopen if the issue persists.


Redesign layout with bootstrap

This would come in handy for designing page to support multiple screen dimensions and multiple link columns, as requested in #8.

Closing this issue, as commit 70410c has eliminated the need for bootstrap. Decided to go with custom responsive design instead. Turns out that it was simple for this scenario and taught me a lot about general css conflicts.


Can't start when no windows are active

I tried adding cortile to autostart list in xfce but it seems cortile can't start when no windows are active.
cortile.log:
Error on initialization GetProperty: No such property '_NET_ACTIVE_WINDOW' on window 765.

I made a potential fix, please try to follow the dev install instructions and install cortile via remote source from the develop branch. Let me know if this version solves your problem.
If not, you may temporarily delay autostart. e.g. via,
bash -c "sleep 10 && /home/USER/.go/bin/cortile -vvv"

we can than investigate the issue further.

I made a potential fix, please try to follow the dev install instructions and install cortile via remote source from the develop branch. Let me know if this version solves your problem.
If not, you may temporarily delay autostart. e.g. via,
bash -c "sleep 10 && /home/USER/.go/bin/cortile -vvv"

we can than investigate the issue further.

Thank you, develop branch solved the problem!

Updated: Well it seems it doesn't work sometimes

Can you confirm that the sleep command,
bash -c "sleep 10 && /home/USER/.go/bin/cortile -vvv"

solves the issue on startup, regardless if windows are active or not in the first 10 seconds?
Please also provide additional infos about the Desktop Environment/Window Manager you are using.

Updated: Well it seems it doesn't work sometimes

Can you confirm that the sleep command,
bash -c "sleep 10 && /home/USER/.go/bin/cortile -vvv"

solves the issue on startup, regardless if windows are active or not in the first 10 seconds?
Please also provide additional infos about the Desktop Environment/Window Manager you are using.

To make cortile start normally, I have to open any window before cortile start, if no window is active, cortile will fail to start. Using the sleep command only works if before 10 seconds a certain window is opened.
i use XFCE desktop environment and Metacity as window manager.

I understand, but unfortunately I can't reproduce the problem properly on my system.
Are you using a desktop manager (e.g. xfdesktop) or are panels (e.g. xfce4-panel) configured, or is the desktop initially completely empty (no background image etc.) before other windows are opened?
Please also run the latest develop branch using cortile -v, as I have changed some logging levels and let me know what the result is.

I understand, but unfortunately I can't reproduce the problem properly on my system.
Are you using a desktop manager (e.g. xfdesktop) or are panels (e.g. xfce4-panel) configured, or is the desktop initially completely empty (no background image etc.) before other windows are opened?

Yes, my xfdesktop and xfce4-panel always start up immediately.

Please also run the latest develop branch using cortile -v, as I have changed some logging levels and let me know what the result is.

Thank you, looks like this commit fixed the problem, i was able to start cortile without the sleep command and open the window manually. 👉👈

There might be some new issues related to system startup caused by this commit (346a89b). If you are still using cortile, it would be helpful if you could confirm that version v2.3.0 is working as expected.


[Server side] memory leak: invalid disposed IdsEntry in OutOfProcessRenderBatch

With server side Blazor, the out of process render returns invalid id values for disposing component and event handler.

This was fixed thanks to @uazo's PR recently.


Render committee name on author page

Description
Added a query to render committee someone is a part of on frontend.
Checklist

[x] Code compiles correctly
[x] Created tests which fail without the change (if possible)
[x] All tests passing
[x] Extended the README / documentation, if necessary

@monkeyjonjon I created an API (Application Programming Interface, not network related) for working with the Sanity library we use. You can see the change I made to your query in 8240064f04e6e589076a735d101da9ae109cc1c8.
"APIs simplify and accelerate application and software development by allowing developers to integrate data, services and capabilities from other applications, instead of developing them from scratch. APIs also give application owners a simple, secure way to make their application data and functions available to departments within their organization" From IBM.
Its a fancy way, in this case, to say I made functions that help us work with the Sanity library code.


Increase the usage of augmented assignment statements

Proposed refactoring or deprecation

:eyes: Some source code analysis tools can help to find opportunities for improving software components.
:thought_balloon: I propose to increase the usage of augmented assignment statements accordingly.
Would you like to integrate anything from a transformation result which can be generated by a command like the following?
(:point_right: Please check also for questionable change suggestions because of an evolving search pattern.)
lokal$ perl -p -i.orig -0777 -e 's/^(?<indentation>\s+)(?<target>\S+)\s*=\s*\k<target>[ \t]*(?<operator>[+\-%&|^@]|\*\*?|\/\/?|<<|>>)/$+{indentation}$+{target} $+{operator}=/gm' $(find ~/Projekte/pytorch-lightning/lokal -name '*.py')

Motivation

Pitch

Additional context

@elfring Hi, thank you for your suggestion. Would you mind sharing the motivation for this change other than PEP203 which you've shared in other issues?

https://github.com/pypa/pip/issues/10624
https://github.com/nedbat/coveragepy/issues/1279

I believe it won't work properly at some places if we use augmented assignments as they are in-place operations.

What is in-place operation?
In-place Operations in PyTorch - What are they and why avoid them

diff of this proposal
diff --git a/pytorch_lightning/callbacks/progress/rich_progress.py b/pytorch_lightning/callbacks/progress/rich_progress.py
index b07b48792..c58172e73 100644
--- a/pytorch_lightning/callbacks/progress/rich_progress.py
+++ b/pytorch_lightning/callbacks/progress/rich_progress.py
@@ -328,7 +328,7 @@ class RichProgressBar(ProgressBarBase):
         if total_train_batches != float("inf"):
             # val can be checked multiple times per epoch
             val_checks_per_epoch = total_train_batches // trainer.val_check_batch
-            total_val_batches = total_val_batches * val_checks_per_epoch
+            total_val_batches *= val_checks_per_epoch

         total_batches = total_train_batches + total_val_batches

diff --git a/pytorch_lightning/callbacks/progress/tqdm_progress.py b/pytorch_lightning/callbacks/progress/tqdm_progress.py
index 672d9d893..cbafd44d7 100644
--- a/pytorch_lightning/callbacks/progress/tqdm_progress.py
+++ b/pytorch_lightning/callbacks/progress/tqdm_progress.py
@@ -226,7 +226,7 @@ class TQDMProgressBar(ProgressBarBase):
         if total_train_batches != float("inf") and total_val_batches != float("inf"):
             # val can be checked multiple times per epoch
             val_checks_per_epoch = total_train_batches // trainer.val_check_batch
-            total_val_batches = total_val_batches * val_checks_per_epoch
+            total_val_batches *= val_checks_per_epoch
         total_batches = total_train_batches + total_val_batches
         reset(self.main_progress_bar, total=total_batches, current=self.train_batch_idx)
         self.main_progress_bar.set_description(f"Epoch {trainer.current_epoch}")
diff --git a/pytorch_lightning/loops/optimization/optimizer_loop.py b/pytorch_lightning/loops/optimization/optimizer_loop.py
index 7050ac75d..03dc2a148 100644
--- a/pytorch_lightning/loops/optimization/optimizer_loop.py
+++ b/pytorch_lightning/loops/optimization/optimizer_loop.py
@@ -87,7 +87,7 @@ class ClosureResult(OutputResult):
         if closure_loss is not None:
             # accumulate the loss. If ``accumulate_grad_batches == 1``, no effect
             # note: avoid in-place operation `x /= y` here on purpose
-            closure_loss = closure_loss / normalize
+            closure_loss /= normalize

         return cls(closure_loss, extra=extra)

diff --git a/pytorch_lightning/plugins/training_type/tpu_spawn.py b/pytorch_lightning/plugins/training_type/tpu_spawn.py
index 7aa4a6772..c6d885327 100644
--- a/pytorch_lightning/plugins/training_type/tpu_spawn.py
+++ b/pytorch_lightning/plugins/training_type/tpu_spawn.py
@@ -250,7 +250,7 @@ class TPUSpawnPlugin(DDPSpawnPlugin):
         output = xm.mesh_reduce("reduce", output, sum)

         if isinstance(reduce_op, str) and reduce_op.lower() in ("avg", "mean"):
-            output = output / self.world_size
+            output /= self.world_size

         return output

diff --git a/pytorch_lightning/trainer/supporters.py b/pytorch_lightning/trainer/supporters.py
index 6e2e51e82..0a18bf47a 100644
--- a/pytorch_lightning/trainer/supporters.py
+++ b/pytorch_lightning/trainer/supporters.py
@@ -86,7 +86,7 @@ class TensorRunningAccum:
         self.current_idx += 1

         # reset index when hit limit of tensor
-        self.current_idx = self.current_idx % self.window_length
+        self.current_idx %= self.window_length
         if self.current_idx == 0:
             self.rotated = True

diff --git a/pytorch_lightning/utilities/distributed.py b/pytorch_lightning/utilities/distributed.py
index 174051892..581a0cdc2 100644
--- a/pytorch_lightning/utilities/distributed.py
+++ b/pytorch_lightning/utilities/distributed.py
@@ -172,7 +172,7 @@ def sync_ddp(
     torch.distributed.all_reduce(result, op=op, group=group, async_op=False)

     if divide_by_world_size:
-        result = result / torch.distributed.get_world_size(group)
+        result /= torch.distributed.get_world_size(group)

     return result

diff --git a/pytorch_lightning/utilities/model_summary.py b/pytorch_lightning/utilities/model_summary.py
index 9c2690202..3789d6d62 100644
--- a/pytorch_lightning/utilities/model_summary.py
+++ b/pytorch_lightning/utilities/model_summary.py
@@ -415,7 +415,7 @@ def get_human_readable_count(number: int) -> str:
     num_groups = int(np.ceil(num_digits / 3))
     num_groups = min(num_groups, len(labels))  # don't abbreviate beyond trillions
     shift = -3 * (num_groups - 1)
-    number = number * (10 ** shift)
+    number *= (10 ** shift)
     index = num_groups - 1
     if index < 1 or number >= 100:
         return f"{int(number):,d} {labels[index]}"

Would you mind sharing the motivation for this change other than PEP203 which you've shared in other issues?

I find that the rationale of the Python enhancement proposal 203 (from 2000-07-13) can indicate also motivation for another bit of collateral evolution. :thinking:

I believe it won't work properly at some places …

Which of the concrete change suggestions (from which 34 source code transformations might look reasonable) would you find inappropriate (at the moment)?

How will the chances evolve for related improvements?
Would you eventually like to adjust the distinction where in-place modifications should be excluded?

I find that the rationale of the Python enhancement proposal 203 (from 2000-07-13) can indicate also motivation for another bit of collateral evolution. :thinking:

The link you've provided is exactly the same as the one I mentioned in the previous reply (PEP203). Could you possibly fill up the "Motivation" section of this issue description above instead of just pasting the link?

Which of the concrete change suggestions (from which 34 source code transformations might look reasonable) would you find inappropriate (at the moment)?

For example, this one:
https://github.com/PyTorchLightning/pytorch-lightning/blob/7a9a08c5d3ca4699fb439f691c40e1320b37507a/pytorch_lightning/loops/optimization/optimizer_loop.py#L90

How will the chances evolve for related improvements?

I'm not sure what you're asking.

Would you eventually like to adjust the distinction where in-place modifications should be excluded?

I'm not sure if I understand your question. We could probably replace some of the occurrences, but I see it as almost preference...

Could you possibly fill up the "Motivation" section of this issue description above instead of just pasting the link?

Do you find the explanation by the Python enhancement proposal 203 (from 2000-07-13) insufficient? :thinking:

For example, this one:

Why do you find the following source code transformation inappropriate (at the moment)? :thinking:
-            closure_loss = closure_loss / normalize
+            closure_loss /= normalize

I'm not sure what you're asking.

:thought_balloon: Would another code review eventually be performed based on data processing results from the shown Perl command example?

Dear @elfring,
I think closure_loss /= normalize would break with the latest PyTorch as it performs an in-place operation.
@ninginthecloud

:thought_balloon: Are in-place modifications generally supported by all involved Python software libraries?
Can run time characteristics eventually be influenced in desirable directions? :thinking:


added links to gifs

Issue Number
fixes ISSUE #51
Describe the changes you've made
Added links to the gifs of Code of Conduct and License.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

@Umesh-01, what have you done.
Nothing has changed.

@QAZIMAAZARSHAD what happened??

Yaa my bad.
May be it was due to GitHub, sometimes Github takes time to show changes.


Flutter web intermittently only renders the very first frame of the app in profile/release builds

I came across this in DevTools when embedded inside VS Code (https://github.com/Dart-Code/Dart-Code/issues/2852). Sometimes it would just render a tiny blue square where the app should be:

After much trial and error, I've managed to reproduce this in a simple Flutter app outside of VS Code:

This turns out to be only the first frame rendering, and then nothing more. The small square is the first frame of the CircularProgressIndicator rendered by the app. There are no errors or warnings listed in the Chrome developer tools/console.
It's pretty intermittent, but here's my steps:

flutter create foo
replace lib/main.dart with this simple app which renders a CircularProgressIndicator and then changes to a Text widget after 500ms.
build the app with flutter build web --profile
run the app through a web server, for ex with cd build/web && python3 -m http.server
open the app in your browser

If you're lucky, it will just happen first time. Otherwise, you can press refresh repeatedly until it happens.
It seems to occur more frequently when I do one or more of the following:

Open Chrome developer tools, go to Application and click "Clear site data"
Copy the URL, navigate to another website, then paste the URL back into the address bar and press

It seems like a race I wonder if it might be related to the service worker (only because it seems more common after clearing the data - though it could just be something else cached that alters timing).
I littered the Flutter code with some prints to see if anything different was happening, and noticed that when this does happen, the call to scheduleBuildFor() triggered by the setState() call skips over the call to onBuildScheduled, though I don't understand this code enough to know if that's relevant (or always the case):

Flutter version is master / Framework • revision 13896b3bd1 (14 hours ago)
OS is macOS Catalina (10.15.7 19H2)
Chrome is 86.0.4240.111 (Official Build) (x86_64) / Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}

I tried removing the service worker JS from index.html, unregistered the service and then reproducing - and it did. So this seems unrelated to the service worker.

I published the build output here:
https://blog.dantup.com/flutter-repro-69313/#/
And with some refreshing, it occurs there too (it did take 20-30 refreshes though):

I was able to reproduce after 15-20 refreshes
Deployed
https://optimistic-mclean-e229a1.netlify.app/#/

code sample
import 'dart:async';

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

void main() async {
  runApp(const MyApp());
}

final _theme = ThemeData.dark().copyWith(
  accentColor: Colors.green,
  backgroundColor: Colors.blue,
  scaffoldBackgroundColor: Colors.red,
);

@immutable
class MyApp extends StatefulWidget {
  const MyApp();

  @override
  State<MyApp> createState() => MyAppState();
}

class MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return Builder(
      builder: (context) {
        return MaterialApp(
          title: 'Dart DevTools',
          theme: _theme,
          onGenerateRoute: (settings) => MaterialPageRoute(
              settings: settings, builder: (_) => MyInitializer()),
        );
      },
    );
  }
}

class MyInitializer extends StatefulWidget {
  @override
  _MyInitializerState createState() => _MyInitializerState();
}

class _MyInitializerState extends State<MyInitializer> {
  bool _isLoaded = false;

  @override
  Widget build(BuildContext context) => _isLoaded
      ? const Text('LOADED SCREEN')
      : const Scaffold(body: Center(child: CircularProgressIndicator()));

  @override
  void initState() {
    super.initState();

    Future.delayed(const Duration(milliseconds: 500)).then(
      (_) {
        _isLoaded = true;
        setState(() {});
      },
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.24.0-4.0.pre.165, on Microsoft Windows [Version 10.0.19041.572], locale en-US)
    • Flutter version 1.24.0-4.0.pre.165 at C:\Code\flutter_master
    • Framework revision e444b1e3fa (6 hours ago), 2020-10-30 00:41:52 -0400
    • Engine revision 99cc50dfff
    • Dart version 2.11.0 (build 2.11.0-266.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Code\sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = C:\Code\sdk
    • Java binary at: C:\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30611.23
    • Windows 10 SDK version 10.0.18362.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.50.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[✓] Connected device (4 available)
    • Windows (desktop) • windows    • windows-x64    • Microsoft Windows [Version 10.0.19041.572]
    • Web Server (web)  • web-server • web-javascript • Flutter Tools
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 86.0.4240.111
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 86.0.622.51

• No issues found!

cc @yjbanov @mariamhas

@devoncarew , any stack trace in console?

@ferhatb there are no errors in the dev console when this happens (I built this page with a lot of print statements, but it repros without):

My sample is here: https://blog.dantup.com/flutter-repro-69313/#/ - you may need to refresh it 10-20 times for it to occur.

Yep, I see it happening after a few refreshes.

This is reproducible in a non-canvaskit build, so I'm removing the cavaskit label. Comparing the output from the print statements that @DanTup added, the framework does indeed sometimes decide to go through a different codepath. For example, when the bug happens the output contains:
...
main.dart.js:7628 because _scheduledFlushDirtyElements_MediaQueryFromWindowsState
...
main.dart.js:7628 inside flutter setState of _MediaQueryFromWindowsState
main.dart.js:7628 calling element.markNeedsBuild for _MediaQueryFromWindowsState
...

These lines are not printed when the app loads normally. A good place to start debugging this is to figure out what conditions cause it to ping _MediaQueryFromWindowsState.
Leaving it as P3, as this is a pretty severe bug. We should be able to write an integration test for this too, just reload the app 100 times and take the screenshot of the first frame, compare with the golden.

Not much more detail, but in the original issue I had this comment about a difference the difference in code paths:

I added some prints throughout Flutter, and found that whenever this happens, it's when this code in scheduleBuildFor skips over calling onBuildScheduled. I don't completely understand how this code works to know whether that's important though.

After some additional print debugging my current conclusion is that the issue is a race between the warm-up frame and the first real scheduled frame. The warm-up frame is implemented via a pair of timers, one for handleBeginFrame, and one for handleAnimationFrame. Currently, dart2js/DDC do not make the same guarantees as the VM, allowing the Window.scheduleFrame() to fire between the timers.
Here's a draft for a workaround: https://github.com/flutter/flutter/pull/72088/files. However, I don't like it due to the following reasons:

It relies on zones, which are complex and error-prone. Zones can be easily bypassed via Zone.root or Zone.parent.
It does not the solve the underlying issue with the discrepancy between the VM and dart2js, which means the Flutter users will have to deal with this quirk in their code.

I'm also bumping the priority of this issue to P2, because being able to launch an app only sometimes is not an option.

https://github.com/flutter/flutter/pull/72115 -- an alternative fix, one that doesn't use zones. It's still unclear to me though why the animation halts without a real engine frame (i.e. not the warm-up frame), but at least the fix guarantees that if the app requested an engine frame, it will get one, in addition to the warm-up frame. Previously you'd either get a warm-up frame + engine frame (common case), or just the warm-up frame and no engine frame (uncommon case). I can see how this randomness can lead to flakiness, which the PR should fix.

To document what we found in the unhappy case:

The warm-up frame's handleBeginFrame runs
transient callbacks for that frame execute
another frame is scheduled
transient callbacks for that frame are scheduled
the newly scheduled frame wants to run between the warm-up's frame handleBeginFrame and handleDrawFrame
It is cancelled (without setting _hasScheduledFrame back to false), its transient callbacks therefore never run
the warm-up frames handleDrawFrame executes

At this point, the app is stuck and we do not produce another frame, ever, because:

when somebody tries to schedule a frame with scheduleFrame we ignore that request because we think another frame is already scheduled (_hasScheduledFrame is still true, but that frame was cancelled and will never be produced).
even if we were to reset _hasScheduledFrame, we still may not produce another frame if it is triggered by the transient callbacks scheduled for the cancelled frame (since those callbacks never run).

@yjbanov Is that a good summary of what we chatted about yesterday?

In a chat with @goderbauer we decided to go with the https://github.com/flutter/flutter/pull/72115.

@yjbanov Is that a good summary of what we chatted about yesterday?

:+1:

Fixed by https://github.com/flutter/flutter/pull/72115


Support multiple secure_headers versions

This PR tries to fix https://github.com/rollbar/rollbar-gem/issues/712 and make the gem work with different secure_headers versions.
https://github.com/twitter/secure_headers doesn't define a VERSION constant and makes tricky to detect which interface to use. Depending on few checks we return a class that will take care of the interface to use.
I've tested manually the implementation using secure_headers versions from 2.x to 6.x passing by different versions 3.x (which is the major version with more minor versions). Things seem to work fine and now looks a bit easier extending the behavior if secure_headers changes the interface...
Some mocks are used in the tests to simulate the different secure_headers versions. Tests have been refactored a bit so we have few shared examples that can be used from secure_headers > 3.x.
It seems trying to be compatible with secure_headers 2.x is not easy cause the way they define the nonce so that version will be still unsupported.

Looks great. Thanks @jondeandres


Archive HTML reports for flaky tests without leftover

Previously the flaky tests without leftovers were not archived.

@bot-gradle test this

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Slot Prop Types

Is there any guidance on properly coding slot properties for type inference?
Getting error Property 'default' does not exist on type '{}'.ts(2339) on a very simple slot. Error is on this line
<Authorized v-slot="{ userName }">
{{ userName }}
</Authorized>

Authorized.vue is this
<template>
  <template v-if="isAuthorized">
    <slot :userName="userName"></slot>
  </template>
</template>

<script setup lang="ts">
import { computed } from 'vue'
import authStore from '~/store/authStore'

const userName = computed(() => authStore.userName)
const isAuthorized = computed(() => authStore.isAuthenticated)
</script>

userName is typed as a string in authStore.  It is converted to a ComputedRef<string>
I don't know how to remove the error message.

it's seem a bug and I have note it: https://github.com/johnsoncodehk/volar/projects/4#card-55169086
wait a minute I'm checking.

fixed in 0.21.11.

Confirmed; thanks so much!


Add other unit tests

There are plans to add the Factory, Decorator, Filter, Component Router and Animation unit tests do?

Hi @Shyam-Chen! I don't have plans right now as this was more about common patterns that I've encountered while testing AngularJS apps.
You can test factories the same way you test services. Filters are really easy to test, for a given input you test for the expected output. I have to say I never used the decorator method neither animations. And the component router only with Angular 2.
Cheers, Pablo.


[GH-#209] Serialize data with msgpack for binary representations

closes #209

can you review?
@nedelcho-delchev-tues
@cheezus1
@gspasov


090615.remote.btsw1 Is Not Work

I added the BLE Wireless Switch 090615.remote.btsw1 in the Xiaomi Gateway 3.
And try click the button , the BLE status is changed, but there is no action.
Could you please help to check and fix it?
https://home.miot-spec.com/spec/090615.remote.btsw1
Thank you.

https://github.com/AlexxIT/XiaomiGateway3?tab=readme-ov-file#handle-button-actions