Ensure that the target pod of a migration is prepared by virt-handler only once

What this PR does / why we need it:
On of the reasons for migration to fail is that
the test fails due to GRPC timout error while
starting VM.
This PR fixes it by ignoring warings and still
veryfying running VM.
Release note:

Don't try to prepare the migration target again if the migration is already running. This could happen sometimes on the source pod.

This change is

/cc @slintes

@slintes I have set ignore warnings as we have discussed. Lets see if it helps as I think it will.

"As we have discussed"... well, I also wrote that dealing with the problem by ignoring the warning might hide real issues. See discussion on https://github.com/kubevirt/kubevirt/pull/2528

I am aware of that. I am trying elimination approach. By eliminating one element, I hope other will show up. Hopefully this will work.
Lets mark this PR WIP to make it clear it is ongoing effort.

/cc @vladikr

@vladikr this is the WIP PR for the experiments as we have talked about.

/test all

/retest

/test all

@vladikr I have consolidated the PR, lets see how ci reacts.
Thank you for the advices!!

/test all

@petrkotas can you address the comments from @vladikr and update the PR?

Hi @rmohr and @vladikr updated the PR. Thanks for the ping, I had other tasks to solve, and missed this one.

/lgtm
/approve
@petrkotas thanks for updating. Let's see if we can reduce the flakes on migrations with this.

Formatting is not right. Can you run make?

Ah okay, done. Sorry for that.

/lgtm
/approve

/retest

/retest
Sent from my iPhone
On 21 Sep 2019, at 07:21, kubevirt-bot <notifications<EMAIL_ADDRESS>wrote:
@petrkotashttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpetrkotas&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663535241&sdata=VDHt1lJFvokG9fLzNhCR2o6sYxXDjUvjMkkSi7trny8%3D&reserved=0: The following tests failed, say /retest to rerun them all:
Test name       Commit  Details Rerun command
pull-kubevirt-e2e-k8s-1.11.0    be6d760https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubevirt%2Fkubevirt%2Fcommit%2Fbe6d760f11e9adc8deeae23e504228a2a06c6071&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663545250&sdata=CbcZ4tmj6sH68RLhccn9OGk67rN%2BY3R6dZV9M4HFLeM%3D&reserved=0    linkhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprow.apps.ovirt.org%2Fview%2Fgcs%2Fkubevirt-prow%2Fpr-logs%2Fpull%2Fkubevirt_kubevirt%2F2582%2Fpull-kubevirt-e2e-k8s-1.11.0%2F1164879456049827840&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663545250&sdata=nTW81avOT011kcTtxLiQPyOLbC0b2mqTH8nrK39MDfQ%3D&reserved=0    /test pull-kubevirt-e2e-k8s-1.11.0
pull-kubevirt-e2e-k8s-1.14.6    5a3ba78https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubevirt%2Fkubevirt%2Fcommit%2F5a3ba784e8cebf24ebe049a709bf9cacd28a5b34&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663555255&sdata=f7dyBZp9aMhqMGt2aoxxRMDZe746G0uCS3fBMrlQzq8%3D&reserved=0      linkhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprow.apps.ovirt.org%2Fview%2Fgcs%2Fkubevirt-prow%2Fpr-logs%2Fpull%2Fkubevirt_kubevirt%2F2582%2Fpull-kubevirt-e2e-k8s-1.14.6%2F1175199959872442369&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663555255&sdata=0AIGqxIutSqi2bucSNjhUmELEw%2F2y3INoZ8ztC6WLT8%3D&reserved=0  /test pull-kubevirt-e2e-k8s-1.14.6
pull-kubevirt-e2e-os-3.11.0-crio        5a3ba78https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubevirt%2Fkubevirt%2Fcommit%2F5a3ba784e8cebf24ebe049a709bf9cacd28a5b34&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663565265&sdata=K1a36YPA8u3HKS36co0RH1RI9y7N9HJmdyZf5KZOi1s%3D&reserved=0      linkhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprow.apps.ovirt.org%2Fview%2Fgcs%2Fkubevirt-prow%2Fpr-logs%2Fpull%2Fkubevirt_kubevirt%2F2582%2Fpull-kubevirt-e2e-os-3.11.0-crio%2F1175199959885025281&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663565265&sdata=mRNO5Ik8d5vkMB3wpp5dPdpW%2FHwPKD0uW%2FBU6yDnAH0%3D&reserved=0    /test pull-kubevirt-e2e-os-3.11.0-crio
Instructions for interacting with me using PR comments are available herehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.k8s.io%2Fcommunity%2Fcontributors%2Fguide%2Fpull-requests.md&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663575269&sdata=Ug5BEdOpYHVQvrrcoFRODlJNBN%2FDNGhpZBDBHXICdDI%3D&reserved=0. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infrahttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes%2Ftest-infra%2Fissues%2Fnew%3Ftitle%3DProw%2520issue%3A&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663575269&sdata=Quq2RftgRtkX%2BJPYyidlc16tydJtfM9tUaH%2FPgNZwbo%3D&reserved=0 repository. I understand the commands that are listed herehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgo.k8s.io%2Fbot-commands&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663585279&sdata=j%2BalObZ%2F1fkHrC%2B3vL4G%2Fwm1KwAB7lCtAyiV02%2BjfaA%3D&reserved=0.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubevirt%2Fkubevirt%2Fpull%2F2582%3Femail_source%3Dnotifications%26email_token%3DACCI4CKFJVR6F35SPCMELQ3QKWVMDA5CNFSM4IKLOAC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IKYGA%23issuecomment-533769240&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663585279&sdata=MJO90AkCNhdFv9KKe6di6LL1vGMVWT9lGg0P2uCr6NU%3D&reserved=0, or mute the threadhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCI4CMMNPTPEL54BETRSTLQKWVMDANCNFSM4IKLOACQ&data=02|01||8f886964b6ac46416e1908d73e5380c6|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637046400663595288&sdata=saIXQK4NzBRyhJFENcZ0qwVMiijjPSPhxKp%2FxCbAlz0%3D&reserved=0.

/cherrypick release-0.20


Feat/s3 public access block

what do you think about:

./src/common.ts?
behavior on delete. regardless of what what was configured before it will be set to all false.... does that make sense?

i have tested multiple scenarios (with and without pre-existing resource) using the resource itself based on the example and everything is working as expected:

create
update (single or multiple properties)
delete

we are able to start managing the resource even if they are already there (just like we discussed)


Create examples

Possibly via Jupyter notebooks, examples other than the test cases would be useful.

examples shall contain

[ ] single point

[ ] periodic
[ ] non-periodic

[ ] geometry optimisation

[ ] only coordinates
[ ] only cell vectors
[ ] fully flexible
[ ] constant volume and external pressure

[ ] molecular dynamics

[ ] heating and cooling
[ ] NVE
[ ] NVT
[ ] NpT
[ ] other
[ ] rdf/vdos calculation
[ ] showcase of integration with ase (eg. diffusion constants), dynasor (https://dynasor.materialsmodeling.org/) or pymatgen (https://pymatgen.org/)

[ ] eos example

[ ] phonons example

[ ] descriptors

[ ] train and fine tune potential.

[ ] plot loss, plot various convergence graphs

where cli exists one shall give an example of it.

jupyter notebooks shall be saved both in repo and in google colab (we need to see best ways)


feat: introduce concept of "storage class" wtih separate dataset for "blob" storage data

I'm open to terms other than "storage class" as well.  I also think we might want to use something other than "blob" as it can be easy to confuse the concepts of "blob encoding" (e.g. low page overhead, file-like API) and "blob storage class" (fewer rows per file).  In fact, the thresholds can even be different with the blob encoding threshold being 8-16MB but the blob storage class threshold being closer to 128KB

Codecov Report
Attention: Patch coverage is 56.65399% with 228 lines in your changes missing coverage. Please review.

Project coverage is 77.43%. Comparing base (4812ac0) to head (df10405).
Report is 5 commits behind head on main.

Files with missing lines
Patch %
Lines

rust/lance/src/io/commit.rs
32.00%
65 Missing and 3 partials :warning:

rust/lance/src/dataset/transaction.rs
39.70%
36 Missing and 5 partials :warning:

rust/lance/src/dataset.rs
48.43%
32 Missing and 1 partial :warning:

rust/lance/src/dataset/blob.rs
25.00%
25 Missing and 2 partials :warning:

rust/lance/src/dataset/schema_evolution.rs
50.00%
16 Missing :warning:

rust/lance-core/src/datatypes/field.rs
64.10%
12 Missing and 2 partials :warning:

rust/lance/src/dataset/write.rs
85.07%
2 Missing and 8 partials :warning:

rust/lance/src/dataset/scanner.rs
47.05%
8 Missing and 1 partial :warning:

rust/lance/src/dataset/write/update.rs
75.00%
4 Missing :warning:

rust/lance/src/io/exec/utils.rs
0.00%
3 Missing :warning:

... and 3 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
- Coverage   77.57%   77.43%   -0.15%
==========================================
  Files         240      240
  Lines       78636    79123     +487
  Branches    78636    79123     +487
==========================================
+ Hits        61005    61271     +266
- Misses      14496    14698     +202
- Partials     3135     3154      +19

Flag
Coverage Δ

unittests
77.43% <56.65%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


0.22.1 wheel lacks typing stubs

The tarball for version 0.22.1 on PyPI includes the typing stub information now:
$ curl -LO https://files.pythonhosted.org/packages/81/4b/d3eb25831590d6d7d38c2f2e3561d3ba41d490dc89cd91d9e65e7c812508/thefuzz-0.22.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
$ tar tzvf thefuzz-0.22.1.tar.gz
drwxr-xr-x  0 johndebs staff       0 19 Jan 19:17 thefuzz-0.22.1/
-rw-r--r--  0 johndebs staff   20810 21 Sep 18:25 thefuzz-0.22.1/CHANGES.rst
-rw-r--r--  0 johndebs staff    1064 30 Oct 15:13 thefuzz-0.22.1/LICENSE.txt
-rw-r--r--  0 johndebs staff      52 21 Sep 18:25 thefuzz-0.22.1/MANIFEST.in
-rw-r--r--  0 johndebs staff    3859 19 Jan 19:17 thefuzz-0.22.1/PKG-INFO
-rw-r--r--  0 johndebs staff    3086 19 Jan 19:16 thefuzz-0.22.1/README.rst
-rw-r--r--  0 johndebs staff     186 30 Oct 15:13 thefuzz-0.22.1/requirements.txt
-rw-r--r--  0 johndebs staff      38 19 Jan 19:17 thefuzz-0.22.1/setup.cfg
-rw-r--r--  0 johndebs staff    1239 30 Oct 19:39 thefuzz-0.22.1/setup.py
-rw-r--r--  0 johndebs staff   18483 21 Sep 18:25 thefuzz-0.22.1/test_thefuzz.py
drwxr-xr-x  0 johndebs staff       0 19 Jan 19:17 thefuzz-0.22.1/thefuzz/
-rw-r--r--  0 johndebs staff      23 30 Oct 19:39 thefuzz-0.22.1/thefuzz/__init__.py
-rw-r--r--  0 johndebs staff    5058 21 Sep 18:25 thefuzz-0.22.1/thefuzz/fuzz.py
-rw-r--r--  0 johndebs staff     830 21 Sep 18:25 thefuzz-0.22.1/thefuzz/fuzz.pyi
-rw-r--r--  0 johndebs staff   11752 21 Sep 18:25 thefuzz-0.22.1/thefuzz/process.py
-rw-r--r--  0 johndebs staff     705 21 Sep 18:25 thefuzz-0.22.1/thefuzz/process.pyi
-rw-r--r--  0 johndebs staff       1 21 Sep 18:25 thefuzz-0.22.1/thefuzz/py.typed
-rw-r--r--  0 johndebs staff     509 21 Sep 18:25 thefuzz-0.22.1/thefuzz/utils.py
-rw-r--r--  0 johndebs staff      98 21 Sep 18:25 thefuzz-0.22.1/thefuzz/utils.pyi
drwxr-xr-x  0 johndebs staff       0 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/
-rw-r--r--  0 johndebs staff    3859 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/PKG-INFO
-rw-r--r--  0 johndebs staff     412 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/SOURCES.txt
-rw-r--r--  0 johndebs staff       1 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/dependency_links.txt
-rw-r--r--  0 johndebs staff      35 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/requires.txt
-rw-r--r--  0 johndebs staff       8 19 Jan 19:17 thefuzz-0.22.1/thefuzz.egg-info/top_level.txt
-rw-r--r--  0 johndebs staff       1 16 Jan 14:17 thefuzz-0.22.1/thefuzz.egg-info/zip-safe

However, the wheel on PyPI does not include these:
$ curl -LO https://files.pythonhosted.org/packages/82/4f/1695e70ceb3604f19eda9908e289c687ea81c4fecef4d90a9d1d0f2f7ae9/thefuzz-0.22.1-py3-none-any.whl
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8245  100  8245    0     0  90604      0 --:--:-- --:--:-- --:--:-- 97000
$ unzip -l thefuzz-0.22.1-py3-none-any.whl
Archive:  thefuzz-0.22.1-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
       23  10-30-2023 19:39   thefuzz/__init__.py
     5058  09-21-2023 17:25   thefuzz/fuzz.py
    11752  09-21-2023 17:25   thefuzz/process.py
      509  09-21-2023 17:25   thefuzz/utils.py
     1064  01-19-2024 19:17   thefuzz-0.22.1.dist-info/LICENSE.txt
     3899  01-19-2024 19:17   thefuzz-0.22.1.dist-info/METADATA
       92  01-19-2024 19:17   thefuzz-0.22.1.dist-info/WHEEL
        8  01-19-2024 19:17   thefuzz-0.22.1.dist-info/top_level.txt
        1  01-16-2024 14:17   thefuzz-0.22.1.dist-info/zip-safe
      775  01-19-2024 19:17   thefuzz-0.22.1.dist-info/RECORD
---------                     -------
    23181                     10 files

Can this please be fixed?
For now, the work-around is to force PIP to install from the tarball; the following command assumes that the dependencies are already installed correctly, it only re-installs thefuzz from the tarball to build a cached wheel with typing stubs:
pip install --force-reinstall --no-binary thefuzz --no-deps 'thefuzz==0.22.1'

To verify the stubs are now installed you can use:
python -c 'from importlib.resources import files;print(*(f.name for f in files("thefuzz").iterdir() if f.suffix in (".pyi", ".typed")), sep="\n")'

This should print out:
fuzz.pyi
process.pyi
py.typed
utils.pyi

(moved here from #67 for visibility)

for some reason, the pip install --force-reinstall --no-binary thefuzz --no-deps 'thefuzz==0.22.1 doesn't work for me =\

I have locally verified the cause. Setuptools is pinned to "68.2.2", which doesn't include type information in the wheel by default. Pinning it to the latest version "70.0.0" fixes the issue. A fix as soon as possible would be appreciated, as this is causing annoyances in a CI pipeline I manage.


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.10.2
Electron Version: 0.37.8
System: Mac OS X 10.11.6
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31)
at emitMany (events.js:121:13)
at EventEmitter.emit (events.js:195:7)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25)
at emitTwo (events.js:100:13)
at EventEmitter.emit (events.js:185:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:178

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:44:28)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:309:31)
    at emitMany (events.js:121:13)
    at EventEmitter.emit (events.js:195:7)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:141:25)
    at emitTwo (events.js:100:13)
    at EventEmitter.emit (events.js:185:7)
    at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:178:13)
    at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:112:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:636:29)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:670:36)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:182:35)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61

Commands

Config
{
  "core": {
    "disabledPackages": [
      "open-in-browser"
    ],
    "themes": [
      "atom-light-ui",
      "solarized-light-syntax"
    ]
  },
  "editor": {
    "autoIndent": false,
    "fontSize": 18,
    "invisibles": {}
  }
}

Installed Packages
# User
atom-elixir, v0.1.4 (active)
build-xcodebuild, v0.2.0 (active)
fold-functions, v0.4.3 (active)
goto-definition, v1.1.18 (active)
ionic-framework-snippets, v1.2.1 (inactive)
language-elixir, v0.12.3 (active)
language-javascript-jsx, v0.3.7 (active)
language-swift, v0.4.0 (active)
multi-cursor, v2.1.3 (inactive)
open-in-browser, v0.4.7 (inactive)
pdf-view, v0.50.0 (active)
pigments, v0.31.2 (active)
pretty-json, v1.0.3 (active)
react, v0.16.0 (active)
react-native-snippets, v0.3.0 (active)
react-redux-atom-snippets, v0.1.1 (active)
readonly, v0.2.0 (inactive)
solarized-one-dark-syntax, v1.1.0 (inactive)
xcode-theme, v1.4.0 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (active)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.5.0 (inactive)
one-light-ui, v1.5.0 (inactive)
one-dark-syntax, v1.3.0 (inactive)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (active)
about, v1.5.3 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
find-and-replace, v0.201.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.2 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v0.53.1 (active)
notifications, v0.65.0 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.100.2 (active)
timecop, v0.33.2 (active)
tree-view, v0.208.2 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

This is a duplicate of #11692 - feel free to subscribe there for updates.


Added DEM support

🎉 New feature

Closes https://github.com/ignitionrobotics/ign-gazebo/issues/235
Requires:

~~https://github.com/ignitionrobotics/ign-common/pull/267~~
https://github.com/ignitionrobotics/ign-physics/pull/315
https://github.com/ignition-tooling/release-tools/issues/574
https://github.com/ignitionrobotics/ign-common/pull/292
https://github.com/ignitionrobotics/ign-rendering/pull/560

Summary
Added Digital Elevation Model (DEM) heightmap support to physics (uses DART) and rendering (with ogre1; ogre2 requires fixing https://github.com/ignitionrobotics/ign-rendering/issues/508).
Test it
ign gazebo dem_volcano.sdf
ign gazebo dem_monterey_bay.sdf

dem_volcano.sdf
dem_monterey_bay.sdf

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[x] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

No new failures on Linux and macOS.
I expect Windows to fail due to

https://github.com/ignitionrobotics/ign-physics/issues/334

Merging!


nimbleList fixes

This PR has fixes for CRAN check notes and warnings involving the use of <<- and .self in nimbleList().

also removes the call to:
assign("makeNewNimListSEXPRESSIONFromC", makeNewNimListFromC, envir = globalenv())   in cppDefs_RCfunction.R, instead assigning the  makeNewNimListSEXPRESSIONFromC() function to the nimbleInternalFunctions environment, where it can be called from C++.

@export tags were added to  is.nl, eigenNimbleList, and svdNimbleList

slight change to roxygen help for nimEigen and nimSvd

Hmm, there are failures in testing. The first one I see is pretty basic, in test-declare (see below). Not sure the best way to proceed as the errors I'm first noticing don't seem like they would related to nimbleLists.
Here's the error in the 'numeric 2' test of test-declare:

expected <- numeric(10)
Rfun <- nimbleFunction(run = function() {

ans <- numeric(10)

returnType(double(1))

return(ans)

})

Cfun <- compileNimble(Rfun)
compiling... this may take a minute. Use 'showCompilerOutput = TRUE' to see C++ compiler details.
compilation finished.
test_that('numeric 1', expect_equal(Rfun(), expected))
test_that('numeric 2', expect_equal(Cfun(), expected))
Error: Test failed: 'numeric 2'

Cfun() not equal to expected.
Types not compatible: character vs double

Cfun
function ()
{
if (is.null(CnativeSymbolInfo_)) {
warning("Trying to call compiled nimbleFunction that does not exist (may have been cleared).")
return(NULL)
}
ans <- .Call("CALL_rcFun_6")
ans <- CnativeSymbolInfo_[[1]]
ans
}
<environment: 0x39435b8>
debug(Cfun)
Cfun()
debugging in: Cfun()
debug: {
if (is.null(CnativeSymbolInfo_)) {
warning("Trying to call compiled nimbleFunction that does not exist (may have been cleared).")
return(NULL)
}
ans <- .Call("CALL_rcFun_6")
ans <- CnativeSymbolInfo_[[1]]
ans
}
Browse[2]>
debug: if (is.null(CnativeSymbolInfo_)) {
warning("Trying to call compiled nimbleFunction that does not exist (may have been cleared).")
return(NULL)
}
Browse[2]>
debug: ans <- .Call("CALL_rcFun_6")
Browse[2]>
debug: ans <- CnativeSymbolInfo_[[1]]
Browse[2]> ans
[[1]]
[1] 0 0 0 0 0 0 0 0 0 0

Browse[2]>
debug: ans
Browse[2]> ans
[1] "CALL_rcFun_6"
Browse[2]> CnativeSymbolInfo_
$name
[1] "CALL_rcFun_6"
$address
<pointer: 0x7f4b6d108760>
attr(,"class")
[1] "NativeSymbol"
$package
NULL
attr(,"class")
[1] "NativeSymbolInfo"
Browse[2]>

The commit I just pushed should hopefully fix the above errors.  They arose because previously there was a line of code in the RwrapperFunCode that created the function that would create new nimbleLists if necessary.  This line of code is no longer in the RwrapperFunCode , but I had forgotten to update the indexing of the RwrapperFunCode after its removal , so a separate line of code was being overwritten.


Added a light/dark toggle

Fix for Add light/dark toggle #10
Haven't checked all the styles... it was just the toggle mechanism, design needs to improve. :)

Could you use the solid makePersistent to save this to localstorage?

Also, is there an icon we can use for each state from: https://solid-icons.vercel.app/

I think I got it... o.O


Third party CSS build.prod

Hello,
I added some third party css injection in my project.config.ts like this :
// Add NPM third-party libraries to be injected/bundled.
this.NPM_DEPENDENCIES = [
...this.NPM_DEPENDENCIES,
// {src: 'jquery/dist/jquery.min.js', inject: 'libs'},
/* { src: 'lodash/lodash.js', inject: 'libs'},*/
{ src: 'primeng/resources/primeng.css', inject: true },
{ src: 'primeng/resources/themes/omega/theme.css', inject: true },
{ src: 'font-awesome/css/font-awesome.min.css', inject: true },
{ src<EMAIL_ADDRESS>inject: true }
];
all of css are copied when do build.dev, but not with build.prod.
Any idea ?

I can't reproduce the issue. Maybe wrong paths? All the CSS files gets concatenated into main.css which is located in dist/prod/css.
For support requests you can use gitter or take a look at project's the wiki page in order to get more complete idea on how the it works.


Error creating project: could not ensure the target project location exists and is accessible

Steps to Reproduce

...
...
...

Logs

Hey guys sorry if i am doing this wrong but i am new to programming and have not yet learnt how to use github but i am running into the issue with android studio "could not ensure the target project location exists and is accessible". So the issue is more with android studio than flutter. I know there are other similar questions to it but non of the solutions have worked for me and they somehow just get abruptly closed just because there's some

other question that looks similar to it but i do not know what to do anymore i am stuck guys please help

Hi @Vuyisile619 the problem is that the directory C:\AndroidStudioProjects either doesn't exist, or you lack permissions to edit it. I would recommend creating a folder under Documents instead.
At any rate, these sorts of questions are not really suitable for github issues, which should be reserved for bugs or features requests.
For help on topics like these in the future, you might check out one of the channels at flutter.dev/community

I have facing the same problem but I couldn't find the solution can u elaborate what to do to slove this issue..

I have facing the same problem but I couldn't find the solution can u elaborate what to do to slove this issue..


Fix reporting of punished alts

The punishment methods do not impose any order on the affected alts that are returned from them. In particular, the first element is not always the original target user, which the alt list reporting wrongly assumes to always be the case. This can lead to the target user being reported as an alt of itself while an actual alt is missing.
Another possibility would be refactoring the punishents to return {targetUser, alts}, that way the separation would be somewhat enforced and documented.

I'd probably support returning targetUser first? Does targetUser always exist?

Yes, that's what I'm saying.

Just comment that in the function description.

and/or implementation

Hm okay, so like this? Filtering out and then re-adding the current user in a different position seems kind of ugly, but I'm not sure where or how else that could be done.

(bump since I'm not sure if this is on the radar)

Yes, like this, sorry, I've been busy lately and have a backlog.


Does not support Chinese pdf?

Chinese pdf upload question reported error, do not support Chinese pdf?

I cannot upload Chinese either. Whenever I try to upload, there is an error message.

Sorry, it would not be possible to provide support in Chinese language as I do not understand mandrian right now, therefore not able to code specific support to reduce token request size. More than a programming problem, it seems like a language specific demand to change the code which I am not able to do right now.


starting the bot

i searched entire google for help but to no evil
the tsconfig.json is set except java link (need help in that too)
i am using windows pc (10 home)
how can i start the bot with node.js

$ yarn start
yarn run v1.17.3                                                                                $ node dist/src/Aelia.js                                                                                internal/modules/cjs/loader.js:775                                                                                throw err;                                                                                ^                                                                                Error: Cannot find module 'C:\Users\ASUS\Desktop\bot project\Aelia\dist\src\Aelia.js'                                       at Function.Module._resolveFilename (internal/modules/cjs/loader.js:772:15)
    at Function.Module._load (internal/modules/cjs/loader.js:677:27)
    at Function.Module.runMain (internal/modules/cjs/loader.js:999:10)
    at internal/main/run_main_module.js:17:11 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

First of all, I would like people to not run replicas of my bot, you can invite Skyra (which contains Aelia's music module) here: https://skyra.pw/invite
But if your purpose is purely educational or you want to contribute to the project, you'll need Docker installed in your system in order to run Lavalink (I guess you can try WSL, but I have never done that myself).
Afterwards you have to build Aelia running yarn build, this compiles the TypeScript code to runnable JavaScript code, and you may run yarn start to run the bot.

i am learning to make my own bot with features as urs + gaming apis notification system + patch notes of games+ anime notification ,etc so i am looking as many bots i can

In that case I you can join the official server, Aelia is up and running there, so you can check and try out her commands. 👍🏼
Admittedly, setting up Aelia's full environment isn't as easy as I would hope, but I hope this helps.


char* to string cast only for strings with length <=8

Casting char* types to string types is possible, does not throw a compiler error, but leads to wrong results for strings with length >= 8.
For example, the bug occurs here:
f<int> main() {
   printf("%s\n", "Hello World!".substring(0, 9));
}

This code prints:
ðìl

Works as intended


Lemmatizer or stemmer for use with mark.js

Is there a recommended lemmatizer or stemmer library that can be used in conjunction with mark.js, such that marking "waived," for example, will also mark "waive," "waiver," etc.?  Obviously the "complementary" setting can sometimes have the desired effect, but that's not a true substitute.  Thanks.

Hi @amtopel,
Thanks for your question.
Actually I didn't have a situation where I needed a stemmer library. Therefore there's nothing that I could suggest.
But, you can use any stemmer that can transform a string into an array of strings, e.g. "waived" to ["waive", "waiver"] as mark.js supports arrays too.
Sorry for not being much of a help ;-)


Git tag latest release 1.3.8 & publish apk in github releases

latest release on google-play is: 1.3.8 https://play.google.com/store/apps/details?id=com.coingrig
while latest tag https://github.com/coingrig/coingrig-wallet/tags and release is 1.3.7 https://github.com/coingrig/coingrig-wallet/releases
tag the latest 1.3.8 release, and publish universal apk file of the release in github releases as asset as well.

Thank you, we are tring to keep the code updated as soon as possible.
We will not be publishing at this moment the APK in github, but we are going to start publishing the APK on our official website soon.


Missing Errors in response from get_torrents()

Description
Errors or Errorstring is not returned when running get_torrents(). Would it be possible to include these in the future?
https://github.com/transmission/transmission/blob/master/extras/rpc-spec.txt#L207
Environment

language version: python 3.9.5
app/lib/repo version: v3.3.0

How to reproduce
NA
Expectations
Expecing to find error fields in response when running get_torrents.
Actual result

I have trouble reproducing it, are you sure your torrent is in error？

FIELDS = ["id", "name", "addedDate", "status",
          "eta", "peersConnected", "percentDone", "sizeWhenDone", "leftUntilDone",
          "rateDownload", "rateUpload", "uploadRatio", "error", "errorString"]

torrent_id = '********************' # removed

torrents = client.get_torrents(torrent_id, arguments=FIELDS)

for torrent in torrents:
    print(torrent.error)  # 3
    print(torrent.errorString)  # No data found! Ensure your drives are connected or use "Set Location". To re-download, remove the torrent and re-add it.

Yes I got it working now thanks. I was confused because VSC wasn't showing the variables when debugging. Rather it showed the variables under a parent called "_dirty_fields".
Sorry for wasting your time and thank you :)


No content packages found for project when using type=content-package

When using dependencies of type content-package instead of type zip the convert mojo fails with
[ERROR] Failed to execute goal com.adobe.aem:aemanalyser-maven-plugin:0.0.16:convert (default-convert) on project aem-analyser-example: No content packages found for project. -> [Help 1]

Example project at https://github.com/kwin/aem-analyser-example/tree/type-content-package

The condition in https://github.com/adobe/aemanalyser-maven-plugin/blob/5e966e61445a92cfc1f97b66c9626bc43fb91d7c/aemanalyser-maven-plugin/src/main/java/com/adobe/aem/analyser/mojos/ConvertToFeatureModelMojo.java#L73 needs to be extended.

The condition in https://github.com/adobe/aemanalyser-maven-plugin/blob/5e966e61445a92cfc1f97b66c9626bc43fb91d7c/aemanalyser-maven-plugin/src/main/java/com/adobe/aem/analyser/mojos/ConvertToFeatureModelMojo.java#L73 needs to be extended.


Handle start/end positions equal to the root's text content length

Re-implement the toRange function to better handle cases where:

The start or end positions include the end of the root element's text
The start or end positions are outside the range [0, root.textContent.length]
The root node is empty or consists of just an empty text node

This fixes an issue encountered in Hypothesis' PDF annotation where
creating an annotation would fail if the selection included the last
character of a PDF page's text layer (original bug report).
This implementation also makes it more obvious which of the two possible
range configurations is used when the start or end offset occurs at
a text node boundary. In that case, the range could use either the end
of one text node or the start of the next as the boundary point. The
boundary point is always placed at the end of the earlier node in that case.

These tests are great, thank you.
I just pushed a branch that passes all your tests, preserving more of the original structure: https://github.com/tilgovi/dom-anchor-text-position/compare/fix-overruns-and-empty-root?expand=1
It highlights some issues with the ergonomics of seek() that we could, perhaps, resolve.
I don't know if I'm just experiencing a personal attachment or if there are real benefits to maintain the composition of building this on top of seek(). I'm tempted, maybe, because it provides a place to resolve #6 / tilgovi/dom-seek#1.
Any objection to merging your test changes with my implementation changes, or do you think I'm being sentimental by keeping seek()?

Any objection to merging your test changes with my implementation changes, or do you think I'm being sentimental by keeping seek()?

If the updated dom-seek based implementation passes the tests, that at least solves our problem. So if you could merge either of the two approaches, that would be great. One technical issue I noticed in the code is that it assigns to iter.referenceNode, which is a read-only property. That's a no-op in non-strict code and an error in strict-code. I'm not certain why it doesn't error in this context - either the code is not being executed in strict mode, or PhantomJS is incorrectly not throwing, or the referenceNode property refers to something from the polyfill?
The reason I opted for a different approach originally is that I found it difficult to reason about the correctness when extending the existing implementation. What the code is ultimately trying to do seems fairly simple: Iterate over a sequence of text nodes and determine the node and character offsets, if any, which correspond to two offsets within the concatenated text of all the nodes. However with the previous implementation I found myself needing to read the NodeIterator DOM specs to grok how pointerBeforeReference works when iterating forwards and backwards, reading the dom-seek implementation to clarify how it works and what happens in various error scenarios (what if there are no text nodes? What if the text length is less than the where value? What are the invariants about the state of the iterator afterwards? etc.). So ultimately I reworked it to hopefully make it more "obviously correct" for a future reader.

One technical issue I noticed in the code is that it assigns to iter.referenceNode, which is a read-only property.

That was a mistake of refactoring. I had a separate variable, like you have, startContainer, that was getting assigned. It's not needed and I've fixed that.

The reason I opted for a different approach originally is that I found it difficult to reason about the correctness when extending the existing implementation.

That's exactly right. The ergonomics are bad and I'm not sure whether they can be salvaged or not. It might be doable, though! Maybe a) throwing if there is no text at all, and b) always leaving the pointer before the reference node, c) fixing the documentation to be clear about overruns.

Just to see what that would look like:
export function toRange(root, selector = {}) {
  if (root === undefined) {
    throw new Error('missing required parameter "root"')
  }

  let document = root.ownerDocument
  let range = document.createRange()
  let iter = createNodeIterator(root, SHOW_TEXT)

  let start = selector.start || 0
  let end = selector.end || start
  let count = seek(iter, start)
  let remainder = start - count

  range.setStart(iter.referenceNode, remainder)

  let length = (end - start) + remainder
  count = seek(iter, length)
  remainder = length - count

  range.setEnd(iter.referenceNode, remainder)

  return range
}

I find that really attractive.

Alternatively:
export function toRange(root, selector = {}) {
  if (root === undefined) {
    throw new Error('missing required parameter "root"')
  }

  const document = root.ownerDocument
  const range = document.createRange()
  const iter = createNodeIterator(root, SHOW_TEXT)

  const start = selector.start || 0
  const end = selector.end || start

  const startOffset = start - seek(iter, start);
  const startContainer = iter.referenceNode;

  const remainder = end - start + startOffset;

  const endOffset = remainder - seek(iter, remainder);
  const endContainer = iter.referenceNode;

  range.setStart(startContainer, startOffset)
  range.setEnd(endContainer, endOffset)

  return range
}

I had a go at using the code in the previous comment as a basis. Using the tests in this branch I encountered a few issues:

If the start position refers to a node boundary (see "toRange returns a range selecting a whole text node" test), then the first call to seek leaves the iterator pointing at the previous node to the one containing the content and so the returned range selects the wrong content. The code in the master branch knows about this detail of dom-seek's implementation and handles it explicitly
If the end position refers to the end of the root's content , then the endOffset ends up being incorrect and the returned range is empty (see "toRange returns a range selecting the last text of the root element" test)
The cases where the start and end offsets are out of range is not implemented in this sketch explicitly. Those tests currently fail with a generic DOM exception due to an invalid character offset being passed to setStart and setEnd. Adding checks for this is complicated by the fact that seek may leave iter.referenceNode pointing an either an element or a text node depending on whether the root has text nodes and whether the passed whence value is 0 or not

I'm sure it is possible to resolve these issues, but it does seem to me simpler to avoid the dom-seek abstraction for this particular use case.
I pushed a couple more commits to add the missing argument to createTextNode and also add a test for when the end offset is less than the start offset.

Very sorry if I caused any confusion. My code snippets were aspirational, with the idea that I would fix dom-seek to provide those guarantees.
I would like to unblock you, so I will take a look at what you've done and probably merge something later today. Thanks for all the work on this.
I am somewhat attached to the seek abstraction, generally, because I do observe that iterating over text nodes and counting characters is something we do in a lot of places in Hypothesis / Annotator / dom-anchor-*.

My code snippets were aspirational, with the idea that I would fix dom-seek to provide those guarantees.

Ah, right. I had misunderstood.

I would like to unblock you, so I will take a look at what you've done and probably merge something later today. Thanks for all the work on this.

Thanks in advance :)

@robertknight it took me longer to get back to the list last week than I thought. Over the weekend, I did have time to experiment a bit.
I've kept all of your commits and added one of my own, implementing toRange() as described in my comment, above. That branch is at #8. It is currently pointing at a branch on dom-seek that includes proposed changes in tilgovi/dom-seek#6 along with the built sources for testing.
Would this be okay for you?

@tilgovi Any thoughts on merging this?

@longhotsummer thanks for the nudge. Working on it this week.

I've updated #8, which currently points at an unreleased version of dom-seek. I put a bunch of work into the master branch of dom-seek and I'm looking for feedback around releasing that as dom-seek v5.
The approach keeps the code here simple and puts more of the logic in dom-seek. I decided that if dom-seek is to be useful it should throw on the error cases and make it easier to work with the iterator. Therefore, it has a few new things going for it:

Throws RangeError for empty text and exhausted traversals
Does not care what the value of the pointerBeforeReferenceNode attribute is at the start
Always leaves pointerBeforeReferenceNode to true at the end

With these changes, there's no need for error handling here and it's always the case that you can just use the remainder of the seek when calling Range.prototype.setStart() or Range.prototype.setEnd().
Any feedback is greatly appreciated.

Thanks @tilgovi. I don't have a strong opinion on the internal implementation, although from an aesthetics standpoint the code in #8 is very clean and understandable (although #7 isn't too bad either).
From a library user standpoint, a release that works correctly is the most important thing to me.
Currently I have cut-and-pasted the code from the hypothesis branch (effectively this PR) because it solves a number of edge cases that were hurting my users and it's simple enough that I have a good understanding of how it works. Being able to rely on a working library is preferable to me than cut-and-paste :)
If #8 requires further iteration, perhaps an option is to release this version (that doesn't rely on a new dom-seek) and then iterate on #8 until it's ready, then release that.

I've just published dom-seek v5.0.0 and updated #8 to use it. That branch keeps all the tests added here but modifies them to expect the new errors thrown by this new dom-seek.
@robertknight thank you so much for your patience with this. I hope you don't feel I've trampled on your work by trying to keep dom-seek alive. I think there's value in having that traversal code exist apart from this. I've checked that the hypothesis/client tests run successfully when I update it for the work in #8. If there's anything I can do to further help with testing there, please reach out.
@longhotsummer thanks for your feedback. I'm going to close this and merge #8 to master. I'll work tomorrow on getting a release out.

Hi @tilgovi - Thanks for taking the time to get this resolved. As long as the tests are passing and I can understand the changes I'm not too attached to the implementation.

I published v5.0.0 just now! :tada:
Note that this version removes the dependency on dom-node-iterator, but still depends on a modern implementation.
If you're supporting recent evergreen browsers, you should be fine without it. If you're supporting IE11 or Edge < 17 you'll want it.
I also released v5.0.0 of dom-node-iterator. It fixes a bug I found during testing and makes all the NodeIterator attributes readonly, per the spec. To automatically polyfill the global document, import dom-node-iterator/auto. More over at that repo.
Please report any bugs when testing and I'll resolve them as quickly as a I can.

If we'd rather not have to pollute the global scope, I could reinstate the hard dependency on dom-node-iterator. I can't decide if it's more appropriate for this library to assume a spec-compliant world or to guard against it without polluting it. Feedback welcome.

Perhaps assume a standards-compliant world, but let the caller pass in a callable to use if they don’t want to use the browser’s implementation.
So the best case just works with no additional dependency, and the case which needs a workaround is still possible and graceful.

I'll leave this alone for now and will look out for any reports of issues using dom-node-iterator/auto. The work I put into the latest dom-node-iterator takes care to try to be a little bit more defensive, ensuring that wrappers it installs for IE11 and Edge < 17 still pass isinstance NodeIterator checks and that all the attributes are readonly. So, hopefully this is safe enough for now and I'll look out for reports of issues.


Update cocktail-cloud.svg

Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you added your SVG to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and Cocktail Cloud has issues with logo: cocktail-cloud.svg, SVG file embeds a png. Please use a pure svg file
No cached entry, and Sosivio (member) has issues with twitter: https://twitter.com/SosivioLtd, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Rancher Federal (member): https://twitter.com/rancherfederal
No cached entry, and Valve Software (member) has issues with twitter: https://twitter.com/valveoficial, 404 - {"errors":[{"code":34,"message":"Sorry, that page does not exist."}]}
Empty twitter for Banzai Cloud (KCSP): https://twitter.com/banzaicloud
Empty twitter for WasmEdge Runtime: https://twitter.com/realwasmedge
Empty twitter for StackStorm: https://twitter.com/Stack_Storm
Item Cocktail Cloud has no image_data

Closing, asking member for different


ordered list with flex in firefox

This code: http://codepen.io/anon/pen/jPGzPK
Chrome/IE: list numbers are 1 and 2 (correct?)
Firefox: all 0

Hi,
An issue was already opened for this problem: Bug 1171419 - ordered list order count broken for flex container.

Having the tracking bug listed here is good, so if others find this issue they can follow it. I'm going to close this though because there's not a clear workaround other than to just not use a <ol> as a flex container, and I think that will be pretty obvious to most people encountering this problem.


Feature: display stacked context

Once more groups are added, it would be useful to be able to see class+function+internal structure context simultaneously as is possible with context.vim. This could be done by stacking the lines vertically, with outermost context at the top.

#27

Pretty sure this is implemented so closing. Comment if this is incorrect.


V5 Offcanvas : data-bs-keyboard="false" not working!!

I'm using .offcanvas.show to shows content the problem that I got when I try to disable Closes the off-canvas when escape key is pressed by adding this data-bs-keyboard="false" but as I see is not working?
Live Example:
https://codepen.io/themes4all/pen/OJWYqGr
Try to click outside the off-canvas box to see the issue!

Hey @devhoussam
The scripts you try to replicate the issue are these of beta-3. There have been some fixes till then
Try with some updated scripts. (I tried too, and seems working)
https://deploy-preview-33782--twbs-bootstrap.netlify.app/docs/5.0/dist/css/bootstrap.min.css
https://deploy-preview-33782--twbs-bootstrap.netlify.app/docs/5.0/dist/js/bootstrap.bundle.min.js

Hey @devhoussam
The scripts you try to replicate the issue are these of beta-3. There have been some fixes till then
Try with some updated scripts. (I tried too, and seems working)
https://deploy-preview-33782--twbs-bootstrap.netlify.app/docs/5.0/dist/css/bootstrap.min.css
https://deploy-preview-33782--twbs-bootstrap.netlify.app/docs/5.0/dist/js/bootstrap.bundle.min.js

this is work better I update the preview link with this update : https://codepen.io/themes4all/pen/OJWYqGr

So now works or not? Can we close the issue?

it's work better you can close this issue


Interwork with injectable

Hello,
I found this package a few days ago and it looks really promising.
I have a question about using it with injectable. It is a code generator for get_it. I see get_it is mentioned in the documentation also.
I would like to use injectable's annotations with the classes of flutter_data. In the quick start it mentions you can use get_it. I guess that would be something like this:
Future<void> main() async {
  final baseDir = await getApplicationDocumentsDirectory();
  final manager = await FlutterData.init(baseDir);
  getIt.registerLazySingleton<Repository<User>>(
    manager.locator<Repository<User>>(),
  );

  WidgetsFlutterBinding.ensureInitialized();
  runApp(AppWidget());
}

Do you think there is a way to annotate Repository with @lazySingleton for example? Or if injectable is a dependency flutter_data would use get_it + injectable as default/additional service locator? Unfortunately I don't know much about how build_runner works and if this would be even possible.
If there is a way could you please tell me? If it is currently not possible, can this somehow be implemented? I would also be interested in contributing.
Thank you!

Thank you for your kind words!  I'm not sure yet how this would work with injectable, as we need to place an annotation on generated code. Will try to have a look later.

Did you try https://github.com/Milad-Akarie/injectable#auto-registering-experimental ?
That should fix this issue.

I tried auto registering now. Unfortunately it did not detect classes from generated files for me. I tried declaring an additional class: class AuthRepository = $UserRepository with AuthAdapter;, this can be registered, however this depends on LocalAdapter, which then also needs to be registered.
So I am manually registering flutter_data's classes before running the app:
Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();

  // Init Flutter Data
  final baseDir = await getApplicationDocumentsDirectory();
  final manager = await FlutterData.init(baseDir);

  // Register Flutter Data's classes for get_it
  getIt.registerLazySingleton<Repository<User>>(
    () => manager.locator<Repository<User>>(),
  );

  // Run injectable's generated function for registering annotated classes
  configureInjection(Environment.dev);

  runApp(AppWidget());
}

Of course when running build_runner I get the warning: [RegisterBloc] depends on [Repository] which is not injectable!
I am not sure on which side this could be improved, flutter_data or injectable.

Let me try adding a runs_before to our FD's build. After that, Injectable should be picking up the whole code. If that doesn't work I think it should be improved on their side.

That alone won't fix this if I understand it, please correct me if I am wrong somewhere. Flutter Data generates two classes for a Repository:
class _$UserRepository extends Repository<User> {}
class $UserRepository extends _$UserRepository with StandardJSONAdapter<User> {}

Even if injectable would pick up on these repositories it could not create them because of their dependency to DataManager (and LocalAdapter for now), which is created at runtime with FlutterData.init().
Passing the get_it instance to FlutterData.init() would create a dependency on the package, right? I though of some solutions.

Add a register function as an optional parameter, which if set would also call it with the repository objects.
Going a little further and making an abstract class Injector() with register() and locator() functions a parameter for FlutterData.init and using the package's own version as default value. This way an injector/locator could be passed from outside.

Right now I am using it this way when using with a Bloc:
// auth_repository.dart
abstract class AuthRepository {
  // Contains register, login etc.
}

// user.dart
@JsonSerializable()
@DataRepository([StandardJSONAdapter, AuthAdapter])
class User extends DataSupport<User> {...}

mixin AuthAdapter on Repository<User> implements AuthRepository {...}

// register_bloc.dart
class RegisterBloc extends Bloc<RegisterEvent, RegisterState> {
  final AuthRepository _authRepository;

  RegisterBloc(this._authRepository);
}

This way testing the Bloc is easily done by passing in a Mock which implements AuthRepository. But I think the only way to use this is to manually register the Repository as AuthRepository or $UserRepository as telling which type to search for could be hard for generated code between flutter_data and injectable.
There is one other thing I was thinking about, I am not sure if I should open a separate issue for it, so I will ask it here for now: Is there a reason to use Repository<User> instead of $UserRepository? The reason I am asking is because $UserRepository class contains mixin informations, so when I want to use an extension function I have to cast it to the mixin or $UserRepository first. If using $UserRepository that is not needed as it contains all the adapters annotated to it. Also is the $ prefix used because it is a generated class?

Thank you for the detailed comment!  I'm busy with the upcoming 0.4.0 release but I'll have a look after that.

I'm going to make it such that if GetIt.instance is present, Flutter Data will register singletons for each repository. Including Repository<User> and UserRepository


network issue

globed tries to create udp connection. nothing happens but a timeout error.

14:55:12 ERROR [Network (in) Thread] [Globed]: Failed to connect to the server. No response was received after 5 seconds.

proxy connection isn't used to create server connection.
network setup:

this bug still persists in v1.1.0

what


Add CLI parameters for SSL cert and key

Clear and concise description of the problem
We can enable / disable https with a CLI paramter -https.  It would be very helpful to be able to also specify the cert and key.
I know these can be specified in the config, but the parameter would allow for different cert locations based on OS.
Suggested solution
Add parameters such as these (similar to webpack's dev server)
--ssl-cert certificate.pem
--ssl-key certificate.key,

Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Turns out this is already available, but one has to dig into the syntax a bit to make it work.
--https.cert=certificate.pem
--https.key=certificate.key

Works as expected.  Just need to be sure to leave out the --https by itself.
Closing issue.


Fix invalid CSS rules in JS modules

The progress bar, sortable list and tag field output invalid
text-shadow and box-shadow properties.

Thanks @dcruz for catching those.


Update README.d and graphs.

Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

/test pull-cri-containerd-node-e2e

@mikebrow Changed to end-of-life.

The test failure is caused by kubernetes/kubernetes#61443.
I'll retrigger the test.
/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-node-e2e


ARM Template incremental mode behavior

Hi,
What this the expected behavior of deploying an ARM Template in incremental mode with SFM.
My test was the following:
1- Deployed an App with 2 Services
2- Deployed the same template with 1 Service in incremental mode (default)
The result is that the removed service from the template was removed from the deployment. Is this what is expected ? (I know that the Service is not an ARM resource

That setting relates to resources under the same resource group.  Incremental would do PUT on any resources in your template and ignore all others.  Complete(or whatever the other option is called) will do PUT on resources in template and DELETE on all other resources in resource group.

In my example, i had 2 services within my SFM app. Deploying an ARM template with only Service 1 has resulted on the deletion of Service 2. Is this what you are expecting ?

I like this behaviour as it aligns with what full SF does.

In this case I think it is because a service is a component of the application resource, you deploy an application not a service.
On the other hand, applications, network and gateway are independent resources.
This is my understanding, I might be wrong!

This is also my understanding. SFM application actually maps to a usual SF app, as I can see when deploying to local cluster and browsing in SFX.

@guibirow your understanding is correct.  The application is the ARM tracked resource so the entire definition of the application is replaced during deployments.

Let us discuss why this behavior is important for me:
We are building a new Application on Top of SFM with a target release version next summer.
The Application follows a Micro-services architecture, and hence contains tens of services.
Each service (or a group of Services) are handled by a Team which is represented by a CICD pipeline.
My question comes here : How can let these teams release only their respective services without being able to touch other services ?
If at the end of the CD steps, there is an ARM template that deploys the new container images versions, any deviation from the last ARM template (used y everyone) version will cause the whole app to break.
So i see two options:

The CD have to be handled by a transversal team that controls the deployment templates life-cycles
Using an SFM App by team with a shared Network ??

Any idea guys ?

I'd personally go for shared network approach and leave the teams with their own application. I think there is a bit of misunderstanding in terminology. An app is supposed to be a self-contained set of microservices, owned by one entity. If a team needs to achieve it's goal by splitting their application (what is often called a microservice in business terms) they are free to do so - other teams shouldn't have an influence in their decisions. Sharing application description resources is a bad idea in long term -now you're locking people into specific tech they might not want to use in future or not ready to yet. Or they might want to use different incompatible versions of SFM in future.
Also I wouldn't have a dedicated DevOps team with SFM, it just never works.  Two-pizza teams are much more effective IMHO.

I agree with @aloneguid, separate applications is the way to go. I've been using SF for a while, I've used single application with multiple services and multiple applications with minimal service dependency, the former is much more flexible and reliable.
Applications should be named service group or something that does not mislead the users in thinking that an application should contain all the services.

It's nice to see your thoughts guys, this is the best path to take i think. i wonder what @mattrowmsft can add to this. Have you planned how to use CICD pipelines with SFM?

I agree with sentiment of an application per team.  Application is meant to be a deployment unit and I have always found a team owning the deployment end to end leads to the most productive teams.
I think the friction here is that we haven't enabled multiple applications on a network properly yet, which is forcing multiple teams to "co-own" the application.  We are working hard on fixing this limitation.

When do you think this will be possible, for Apps to share the same network, and to see each other using appnsme.servicename? Q1,Q2?

The next refresh is focused on MSI + diagnostics (although it is different people working on features).  I would guess 3-5 months from now.

Nice. What do you mean be MSI please ?

Managed Service Identity. https://azure.microsoft.com/en-us/blog/keep-credentials-out-of-code-introducing-azure-ad-managed-service-identity/

I thought @mattrowmsft won't use the old naming for this service, which is now Managed Identity for Azure Resources :wink:

I didn't even know about this rename (probably those working on feature did).  I think I have finally gotten SF Mesh to stick in my head as opposed to our original seabreeze codename :-).

"How can let these teams release only their respective services without being able to touch other services?"
I've been exploring this at work and I was under the impression that we could use Linked Arm Templates.
https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-linked-templates
Essentially each code repository for a service would have its own subset of the SF Mesh template allowing teams to control a particular service.
I haven't tried this out but I was expecting this to be the case.

@heymega Using linked templates can quickly become very messy, in addition to that, this will not solve our problem.
An SFM app contains services. A SFM ARM  te.ate for example deploys an App. The App is an ARM resource.
The problem comes when two teams owns different services within the same app.
Team1 owns Service 1
Team2 owns Service 2
Let's say Service 1 uses a container image1 tag 10.
Let's say Service 2 uses a container image2 tag 10.
When Team1 makes a new deployment, they need first to update their template with anything made by Team2, otherwise they may overwrite what Team2 has updated. For example, if Team2 service is now using image2 tag 11, Team1 may overwrite this configuration whenver they make a new deployment using their template.
This was a short example to show the governance challenge.

They wouldn't overwrite it if they're using a linked arm templates though, surely.
Let's say there is a single arm template for the application with two child templates which are linked. Team 1 and team 2 own their own child template.
Team 1 can't change team 2's sub template and vice versa.
Both teams deploy the application template but it'll use each team's specific sub template.
I'd imagine the links point to the Master branch in each team's git repository for the live template.

The linked template is a template tjat deploys what? An SFM app or an SFM Service ?

The linked template deploys a SFM service.
There is a master template that deploys the application and the linked child services.
As long as you ensure the deployment mode is idempotent (which is default I believe) then this would work.
Now I haven't tried this out in practise yet but I've used linked templates before and we are looking to do this with SF Mesh.
This is how I envisaged it working so I hope it works!
We are still waiting for the SFM to reach GA (which I believe is Jan/Feb time) and this is one of the things on our checklist. Once we've got round to trying it out I can let you know and send you the POC files.

@heymega in that case'

who will manage the parent template?
what if a tem decided to add a new service? They need to ask to update the parent template

Using Linked Templates may be z workaround, but it does fit well in a single responsibility model when teams are independent and can work solely in DevOps/CICD mode


Added Helm install section and a few ISM updates

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is definitely going to need a rebase due to all the file name changes after we merge https://github.com/opendistro/for-elasticsearch-docs/pull/153 into master.


Hide rotation arrows in HUD for tokens with Lock Rotation

On tables with mixed token styles (like top-down monsters and portrait-style PCs) it's useful to select Lock Rotation in the token configuration for the tokens that shouldn't rotate. With direction arrows enabled in Drag Ruler, this creates a UX problem where players with locked-rotation tokens see the arrows but they do nothing, frustrating discovery UX, and raising the usability barrier of Foundry a little bit higher.
Drag Ruler should hide the arrow buttons on the token's HUD for locked-rotation tokens, even if “Direction arrows in Token HUD” is set On. This will make the appearance of the token HUD arrows sensitive to context by removing UI elements that are non-functional for that token.

Drag Ruler doesn't add any direction arrows to foundry. Maybe they are coming from a different module?

I'm sorry! You're right, this should be for TouchVTT. I had both repos open to investigate compatibility and just… forgot which one I was thinking of when I submitted this. Thanks for the quick catch. I'll submit this where it belongs!


Switch to a more modern TypeScript target

Enhancement description
Currently target in tsconfig is set to "es5", as a result TypeScript outputs ES5 which includes generators for any async code.  Also, ES5 at this point is only required for IE11 support and ancient ancient versions of node.js. For example node 8 already supports es2017: https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-8.
Also by making this change the bundle size of the module should go down for users that bundle this module into the browser
The problem it solves
Better debugging + lower bundle size
Additional information
It probably wouldn't be a bad idea to also leave import/export statements in the code by setting "module" setting to ES2020. ES2020 is required to allow for dynamic imports, but once that is done 2 dists will have to be build one for browser & 1 for node consumers

That makes a lot of sense, @marcodejongh. Would you be willing to create the PR with the proposed changes? :)


Add MessageReactionsRemove

Closes #874
Add Delete All Reactions for Emoji
Deletes all the reactions for a given emoji on a message.
https://discord.com/developers/docs/resources/channel#delete-all-reactions-for-emoji

Thank you for your contribution to the library! 🤠


NIFI-5689 ReplaceText does not handle end of line correctly on buffer…

… boundary
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[-] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[-] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[-] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@patricker

we cannot edit/alter NLKBufferedReader as-is.  It needs to be completely redone as per https://issues.apache.org/jira/browse/NIFI-5711

Closing until re-write


Blazor native deps (w/callback coverage)

Fixes #23661
Internal Review Topic
This guidance requires further work:

Dan ... plz check the draft title, UID, physical file name (i.e., URL), description, and location in the ToC relative to the other topics.
The WasmBuildNative property wasn't in the blog post. I guessed where/how to describe it.
If an example makes sense for the callback guidance, place it in an issue comment here for inclusion.
I can't get the SkiaSharp example to work following this guidance with the RC2 SDK, so I'm :ear: for how that section is incorrect or if it's missing something. My error is shown on the original PR ... BUT, Steve told me offline that there have been improvements since RC2 and that the RTM SDK worked for him following the guidance here. My problem might be a point-in-time thing for RC2.

Thanks @guardrex.
@SteveSandersonMS can you please review this? Thanks!


Unhelpful error message when RuboCop is not installed

I am using rbenv and I had RuboCop installed in different version of Ruby but not the version I happened to be using. When trying to commit, I got this output:
Analyzing with RuboCop......................................[RuboCop] FAILED
Hook raised unexpected error
Unexpected output: unable to determine line number or type of error/warning for message ''
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/pre_commit/base.rb:31:in `block in extract_messages'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/pre_commit/base.rb:28:in `map'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/pre_commit/base.rb:28:in `extract_messages'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/pre_commit/rubo_cop.rb:19:in `run'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/base.rb:45:in `block in run_and_transform'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/utils.rb:259:in `with_environment'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook/base.rb:45:in `run_and_transform'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook_runner.rb:152:in `run_hook'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook_runner.rb:88:in `block in consume'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook_runner.rb:85:in `loop'
/Users/joe_lencioni/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/overcommit-0.32.0.rc1/lib/overcommit/hook_runner.rb:85:in `consume'

Running rubocop alone gave me this output:
rbenv: rubocop: command not found

The `rubocop' command exists in these Ruby versions:
  2.0.0-p481
  2.3.0

After installing rubocop, it seemed to work better (I got a different error but this one was more actionable).

This situation is difficult to address. The core problem is that rbenv installs a shim for rubocop the first time you install. However, this shim exists in your path even if you switch to a version of Ruby that does not have that gem installed yet. Thus you'll get the error you so saying "The `rubocop' command exists in these Ruby versions:". Since this doesn't match the message format the hook is expecting, it fails.
The intention of showing a stack trace in this case is because we wanted hook authors to get feedback on whether or not their hook message regex was correct. However, I think it would be reasonable for us to swallow the stack trace and instead display all of STDOUT/STDERR in this case. That way in your situation you would have seen (as an example):
Analyzing with RuboCop......................................[RuboCop] FAILED
Hook raised unexpected error
Unexpected output: unable to determine line number or type of error/warning for message:
rbenv: rubocop: command not found

The `rubocop' command exists in these Ruby versions:
  2.0.0-p481
  2.3.0

Agreed, that would be much better!


Dataset bagls

I fixed the problem of img and msk not matching. But still another problem exists.
ValueError: Height and Width of image, mask or masks should be equal. You can disable shapes check by setting a parameter is_check_shapes=False of Compose class (do it only if you are sure about your data consistency).
I fixed it by add 'is_check_shapes=False' in .Resize. I don't know if it has any effect on img and msk properties.

In this case, you had better resize the image and the mask to both sizes and make sure that the new size keeps the ratio of the image and mask. I think that the resize transformation has been applied to image but not mask yet.

For that reason I gonna close this pull request as usual


Unable to transfer call to external endpoint

Hi,
I can't seem to get my connected call to transfer to an external number;
Here's my code:
transferCall(extPhone = '+61417486885') {
    console.log('+ transfer call to: ', extPhone);
    const contacts = window.myCPP.agent.getContacts()
    if (Array.isArray(contacts)) {
      console.log('+ contact id', this.contactUiState.contactId);
      console.log('+ contacts', contacts);

      contacts.forEach(contact => {
        if (contact.contactId === this.contactUiState.contactId) {
          console.log('+ contact', contact);
          contact.addConnection(extPhone, {
            success: () => {
              console.log('+ added external connection');
              window.myCPP.contact.getAgentConnection().destroy({
                success: () => {
                  console.log('+ ended agent connection on successful transfer')
                },
                failure: () => { console.error('! failed to end the call') }
              })
            },
            failure: () => { console.error('! failed to add connection (transfer)') }
          })
          return;
        }
      })
    }
  }

The error I get is:
[2019-08-08T08:43:43.065Z] [ERROR]: 'createAdditionalConnection' API request failed: [object Object]

Am I approaching this the wrong way?

@camstuart  contact.addConnection expects Endpoint object, not string value.
contact.addConnection(window.connect.Endpoint.byPhoneNumber(extPhone), {   success: () => {},   failure: () => {}, });
https://github.com/aws/amazon-connect-streams/blob/master/Documentation.md#endpointbyphonenumber-static-function

Thanks, @prosunshining for that information, that works perfectly.
And thanks as well for such a fast response.


Hi,what IDE should I use to compile this project?

What IDE should I use to compile this project? Thanks!

No need for a ide. you can simple use maven.
Best regards,
Marcel

If you're looking for a recommendation, IntelliJ community edition is an excellent choice.

thanks,my friends😄


Support Hugo Page Bundles

Is your feature request related to a problem? Please describe.
My content is organized in page bundles:
/content/posts/my-cool-article/index.md
/content/posts/my-other-cool-article/index.md

I would like that NetlifyCMS can handle content organized this way.
Describe the solution you'd like
In config.yml, I should be able to do something like this:
collections:
  - name: "posts"
    label: "Posts"
    folder: "content/posts"
    slug: "{{slug}}/index.md"

Describe alternatives you've considered
Additional context

Duplicate of https://github.com/netlify/netlify-cms/issues/513

Also related: bundling image assets is #1472

This is not solved for me.
Hugo page bundle (branch) has structure like this:
/parent/_index.md
/parent/sub1.md
/parent/sub2/_index.md
/parent/sub2/inside.md
Each file produces url based on folder and filename. But most important is, that these pages have hierarchy usable in code. So I can output list of all child pages that belong to parent page.
I tried using beta feature slug and path with combination of url frontmatter, but it doesn't work.

@zabatonni  can you show your config file.

I have no working config file to show:
`collections:

name: pages_en
label: Pages EN
folder: content/en
create: true
path: '{{PARENT_DIR???}}/{{PARENT_DIR2???}}/{{slug}}'`

@barthc please take a look at https://gohugo.io/content-management/page-bundles/
there are 2 types of bundles and netlifycms only supports {{slug}}/index.md or {{slug}}/_index.md
I think only solution is to show folders and be able to manage (create/rename/delete) files and folders. Forestry does this using regex pattern when defining sidebar "collections" like this: */

@barthc But there are hundreds of folders made dynamically by client (it was WP before, after migrating to Hugo all parent and child connections are done using folders), no way one could maintain it in config.

Another workaround is to pull the folder name from the entry. Maybe a dropdown, and then do something like
path: '{{fields.folder1}}/{{fields.folder2}}/{{slug}}'

@erezrokah  does the path config support the fields. placeholder?

ok, and if i want to move pages, or rename folders? Folder would be created only on post creation, but if there is a typo and post title is changed, how this change will reflect folder structure?

Hi @zabatonni, that workflow should be covered in https://github.com/netlify/netlify-cms/issues/3227

I have no working config file to show:
collections:
- name: pages_en
  label: Pages EN
  folder: content/en
  create: true
  path: '{{PARENT_DIR???}}/{{PARENT_DIR2???}}/{{slug}}'

I too have same issue, Have you found out any solution using path and slug?


Please invite me to the GitHub Community Organization

Name
Abhishek Rajput
Discord Username (if applicable)
No response

__


UCR crashes on create profile if ViGEm not installed

Reported by CommStatic in Discord
Happens with UCR 0.8.0 and IOWrapper 0.11.0 / 0.11.1 based builds

Was caused by the Devices property of the ProviderReport being null instead of an empty list


Fix Popper Issue mmozuras/pronto-poper#5

ruby_patches method sometimes returns an empty Array.
Calling #first on it will return nil that can cause errors.
So, using the bare @patches instance variable.
Fixes mmozuras/pronto-poper#5

@abinoam 👍 thanks for a fix! 🙇

👍 Thanks for merging and for developing Pronto!


Random voxel filtering.

This leads to slightly slower performance but better quality.
Also replaces the VoxelFilter class by free standing functions.
Signed-off-by: Wolfgang Hess<EMAIL_ADDRESS>

When you say "slightly", did you do some tests? can you express in CPU usage?

@bochen87 Yes, of course. Main point here is better quality. Exact performance numbers depend on the sensors used and the environment. For the 3D backpack example voxel filtering takes a few milliseconds and performance regression is a fraction of that.

Ok, cool!

Thanks for the review. Some numbers from the 3D demo:
CPU time changes from 1037 s to 1068 s (+3%)
712 loop closures are found instead of 681 (+5%)
translational residuals are 4.5 cm mean instead of 4.9 cm mean (-8%)
rotational residuals are 7.6 mrad means instead of 7.8 mrad (-3%)

thanks for also posting some numbers, very insightful! :+1:


Refactor integration test test cases

Waiting for #290 to be merged.
Currently, test cases are specified as
class TestTrainCase:
    model: str = "graphtcn"
    loss_weights: str = "default"
    ec_params: dict[str, Any] | None = None

and then later there's a long if, elif change turning these strings into the actual classes.
Better would be to directly do
test_case = TestTrainCase(
	model=GraphTCN(
          node_indim,
          edge_indim,
          h_dim=2,
          hidden_dim=2,
          L_ec=2,
          L_hc=2,
      )
)

etc.

Hey, can I work on this issue? This might help me understand the basic flow of this project.


Nero-Promises Song

A great english edm song for the project

Hey @vaibhavmishra4g,
You also have to update the index.html file.
For Example:

              05:34

Make changes like them with proper indentation.


Index Update Strategies

The documentation for update strategies is somewhat confusing. Here is my update_index method.
update_index('users#user') { self if self.user_profile? }
But that does NOT update the index when I save a user. If I specify 'urgent: true' in there it does, but then I get a depreciation warning. So, I checked the documentation, where you have examples like this:
Chewy.strategy(:atomic) do
  City.popular.map(&:do_some_update_action!)
end

That makes sense for a specific action, but what about a default? In looking at your elasticsearch / chewy blog post on toptal.com, I found this little bit about update strategies:
around_action { |&block| Chewy.atomic(&block) }
But that doesn't work either.
When I try Chewy.strategy(:urgent) in the console I get an undefined method error for 'strategy'. I ran Chewy.methods and found urgent_update and then added this to my application.rb.
Chewy.urgent_update = true
And that finally is what did the trick.
Am I missing something here?

Yeah, the current README is for current master, there was a lot of changes and I recommend to use it, it will be released really soon.

I'm confused. So, the current README is not the most current information? How did the README get updated before the actual code? You said you recommend that I "use it." What is "it" in that situation? And what will be released really soon? A new README?

Current README is the most current information. Usually README updates in accordance with implemented features. If you want the latest released version README you could just use corresponding git tag (https://github.com/toptal/chewy/tree/v0.6.2)
But I recommend to use master branch. Just set it up in your Gemfile and enjoy the latest features of Chewy. Also I was talking about new version of gem which would be released soon. And all the features form master branch would be included in this release.
Was it more clear?

Thank you, thank you, thank you. That clears things up a BUNCH. It all makes sense now. I don't think it would hurt to add a little something to the README about what we are talking about here.
Because, in my experience, this is how things unfolded. I added chewy to my gemfile as such:
gem 'chewy'
I didn't specify a version, I just wanted the latest from rubygems. When I went looking for information about the gem and how it works, I came upon the github repo and the corresponding README. Nowhere in there does it say anything about what version that it relates to or where the documentation for the current rubygems.org version can be found.
Maybe you could add a little note at the top of the README that says
"This is the master branch of this gem, and the corresponding README. If you'd like the documentation for the most recent version on rubygems.org, use the following link:"
http://www.rubydoc.info/gems/chewy/0.6.2
Just a thought. Maybe I'm just a newbie and all of this is obvious, but that would have been very helpful and could have saved me some time. I'm only hoping to help out other future developers that might run into the same problem.
Thanks again for your time. I hope I wasn't too annoying. :)

It is quite a usual case for ruby gems on github btw. And welcome if you have more questions.


Gitify is eating my api rate limit

Hi!
I have been using gitify for some time and been quite happy with it so far. But now, it is eating my github rate limit. To the point where it prevents me from logging into other services.
Is there a way to prevent that from happening?
Thank you

Just updated to version 2, maybe that will solve the issue

@callicles this was an issues in an earlier version of Gitify, but should be solved in v2. :)

perfect, thx!


security-check fails

nsp check
(+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io api.nodesecurity.io:443
(running nsp check here on it's own just to show the error)

nsp was acquired by npm, so it's now built into npm. You no longer need to manually run nsp. Check out this PR for updates on how to run the latest versions.

What part of my background is off?
I worked at the Jet Propulsion Laboratory for 25 years. I have held a
military security clearance for most of my life. I WAS happily subscribed
for months.
I will forward this mess to Cory.
On Wed, Dec 12, 2018, 2:11 PM gregor<EMAIL_ADDRESS>wrote:

nsp check
(+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io
api.nodesecurity.io:443
(running nsp check here on it's own just to show the error)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/javascript-development-environment/issues/24,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACfSKq3C-O82x45xWwxW1Dh_fRtWligUks5u4VTIgaJpZM4ZQRLR
.

I've already added a blue note to the relevant clips in the course. That note was added months ago. Did you guys just overlook it?
@Chris-43 - What is your issue?

I see what happened - yes you are right there is a blue note in the package management section but one is missing in the Automation - Demo: Create Security Check and Share Scripts. [only checking cos I love you ;) ]

@gbm - Ah! Great catch! I just submitted a patch to add a callout on that clip, and the following clip as well since it shows calling the security-check clip. Thanks! 💯