c++ quadrupedal walking benchmark

In GitLab by @cmastalli on Oct 4, 2019, 18:09

In GitLab by @cmastalli on Oct 4, 2019, 18:09
assigned to @proyan

In GitLab by @cmastalli on Oct 4, 2019, 18:10
If you finish this task before Monday, could you push the code?

In GitLab by @proyan on Oct 4, 2019, 22:09
mentioned in merge request !240

In GitLab by @cmastalli on Oct 5, 2019, 09:14
assigned to @cmastalli and unassigned @proyan

In GitLab by @cmastalli on Oct 13, 2019, 19:15
mentioned in merge request !246

In GitLab by @cmastalli on Oct 13, 2019, 19:15
changed title from c++ quadrupedal {-gait-} benchmark to c++ quadrupedal {+walking+} benchmark

In GitLab by @cmastalli on Oct 13, 2019, 19:15
changed the description

In GitLab by @cmastalli on Oct 13, 2019, 19:17
Fixed in !246

In GitLab by @cmastalli on Oct 13, 2019, 19:18
closed


[Feature Req] Enable support for releasing a set of libraries that span multiple SDK/areas

This is part of the patch/BOM releases Epic, and the full description of the larger problem is in there (see linked Epic).
Our various templates use the ServiceDirectory parameter. This starts in the individual SDK/area/CI.yml files and threads its way through everything from sparse-checkout, building and testing, verification and releasing. The various template files, the way are now, will not work with a set of libraries from multiple SDK/areas. We are going to end creating special templates to handle this specific case but, whenever possible, we should taking chunks of common code from the existing templates and making smaller templates from those to reduce duplicate code that would allow a ServiceDirectory regardless if it's a parameter or something we have to compute.
One thing of note, after things have been built the pipeline's published Artifacts will contain a Packages/PackageInfo directory that has .json files, which can be used later in the process, to pull the service directory for a given artifact. An example, in the ResourceManager pipeline one of the artifacts built is azure-resourcemanager-appplatform. Packages/PackageInfo/azure-resourcemanager-appplatform.json contains the following:
{
"Name": "azure-resourcemanager-appplatform",
"Version": "2.15.0-beta.1",
"DevVersion": "2.15.0-alpha.20220425.3",
"DirectoryPath": "sdk/resourcemanager/azure-resourcemanager-appplatform",
"ServiceDirectory": "resourcemanager",
"ReadMePath": "sdk/resourcemanager/azure-resourcemanager-appplatform/README.md",
"ChangeLogPath": "sdk/resourcemanager/azure-resourcemanager-appplatform/CHANGELOG.md",
"Group": "com.azure.resourcemanager",
"SdkType": "mgmt",
"IsNewSdk": true,
"ArtifactName": "azure-resourcemanager-appplatform",
"ReleaseStatus": "Unreleased"
}

I'm closing this. This was completed as part of this PR


Implement drawOver capability

Implements a drawOver function within the Display class that will accept partial ch/fg/bg values and draw only the provided values "over" any existing draw information.
The use case for this is being able to draw a game state in a way similar to this for efficiency:
tiles.forEach(tile => display.draw(tile.x, tile.y, tile.ch, tile.fg, tile.bg));
entities.forEach(entity => display.drawOver(tile.x, tile.y, tile.ch, tile.fg, null));

So as a result you can draw an entity (like the player) on the map while preserving the map background and without having to do a lookup of what the background color is. Similarly if you are doing cloud or particle effects you can draw those over the map and entities without having to reach out to other data structures to look at what else should be in that same tile.

@ondras I am not sure what the PR process here is regarding the build files. I have run make for this pull request which is why there are so many changes to the docs. I can submit the same PR without running make to keep the changes limited to just the adjusted files if that's preferable.

Hi @Slogo,
thanks for the PR! I think this feature makes sense so I'm gonna merge it. There is no explicit PR policy, but I would run make myself, so I suppose this is perfectly okay.


Weird glyph rendering issue with CaskaydiaCove NerdFont

Windows Terminal version
1.18.231114001
Windows build number
10.0.19045.3570
Other Software
No response
Steps to reproduce
Glyphs do a wavy thing when I type three lower case 'w' letters in a row with CascadiaCode-NF-Mono.
Steps:

Set font to CascadiaCode-NF-Mono
Type www

Expected Behavior
Here's a comparison of what it looks like in VS Code integrated terminal, Windows Terminal and stock terminal:

Actual Behavior
As above.

Windows Terminal enables ligatures by default and the "www" one is a ligature. You can see it here - it's the first one in the top-left: https://github.com/microsoft/cascadia-code#font-features
If you open your settings.json (Ctrl+Shift+,) you can edit your font features to disable that:
"font": {
    "face": "Cascadia Cove, etc.", // <-- you'll have to search this block
    "features": {
        "liga": 0                  // <-- this disables ligatures entirely
    }
}

Thanks, I found some more documentation regarding this:
Font features settings in different apps:
https://github.com/tonsky/FiraCode/wiki/How-to-enable-stylistic-sets
Settings in Windows Terminal more specifically
https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-appearance#font
List of features that should be possible to set
https://learn.microsoft.com/en-us/typography/opentype/spec/featurelist
Interestingly though, the key you suggested ("liga") didn't have any effect. The settings for particular features seem not to react to any of the following:
"ss01"
"ss02"
"ss03"
"ss04"
"ss05"
"ss06"
"zero"
"onum"
"liga"

They are all disabled when "calt" is set to 0 though.
So, for anyone who somehow lands here from google, here's a snippet that worked for me:
{
  "font": {
      "face": "CaskaydiaCove Nerd Font Mono"
      "features": {
          "calt": 0
      }
}


Collection name with hyphens in it errors out on CosmosDB emulator

I haven't tested this out in the cloud db yet, so I don't know if it's just a problem with the emulator.
I have a collection called social-data and I get a DocumentClientException with syntax error at the exact spot where the hyphen is.
Here's the query I'm running.
 SELECT * FROM social-data a WHERE a.Type == "Juna.Zone.NewsFeed.Infrastructure.DAO.FeedItemDO" ORDER BY a.DatePublished DESC
The sytax error goes away for the hyphen, but it's occurring further down the line with the query which I am still investigating.

@bchong95 please look into this.

The root symbol in the FROM clause has to be a valid identifier (starts w/ an underscore or alpha char and followed by an underscore or alphanumeric char).
On the other hand, it really does not have to match the collection name since the collection is inferred from the connection context (you could only establish a connection to a single collection). So basically, you could pick any name here.
BTW, '==' is also not valid, replace it by '='.

@sboshra I understand that collection can be inferred from the context itself. However, if we are writing a generic repository layer where queries are distributed across multiple collections, sometimes we have to write plain SQL like queries.
Correct me if I'm wrong, but it's a best practice to make sure that queries across all formats work the same way (including emulator UI or administration UI).
Thanks for point out the ==. Sometimes, I bang my head against the wall for the silliest of reasons.


Compressible Navier-Stokes on TreeMesh3D

This implements the three dimensional compressible Navier-Stokes equations on Cartesian meshes for TreeMesh{3}. It was quite straightforward to extend the 2D methods for gradients and get things up an running in 3D. Below is a laundry list of what needs done before merging.

[x] Write tests for new elixirs, probably requires a new test/test_parabolic_3d.jl set
[x] Create a MMS convergence test that exercises the boundary conditions
[x] Get things up and running on DGMulti{3} as well
[ ] Viscous shock tube test? Save for 1D Navier-Stokes, it would be a good student project
[ ] Compute kinetic energy dissipation rate (as an analysis quantity)
[x] Compute enstrophy (as an analysis quantity)

The points above address a few of the list items from #1147 .

Two questions to @jlchan @ranocha @sloede:

The co-rotating Euler test failed due to some exception. Have y'all had this happen before?
The new parabolic tests all pass in 57m; should I modify them to be shorter to not extend the automatic testing?

1. The co-rotating Euler test failed due to some exception. Have y'all had this happen before?

I haven't seen that before. I opened #1242 to test main.

2. The new parabolic tests all pass in 57m; should I modify them to be shorter to not extend the automatic testing?

No, we have some CI jobs running longer than that, so it's fine.

I haven't seen that before. I opened #1242 to test main.

The test fails there as well with the same error.

@sloede Any ideas?

I have been trying to work out the best way to create an enstrophy callback for the 3D compressible Navier-Stokes. I have written the necessary routines that live in src/equations/compressible_navier_stokes_3d.jl with my thought process being that it can reuse the gradients already computed and stored in cache_parabolic. This, though, proves a bit unwieldy because the analyse and integrate routines are designed to only dispatch on the advective cache (within semidiscretization) so the callbacks do not have access to the cache_parabolic that I want access to. Do y'all have any good suggestions on how to give the integrate (or integrate_by_indices)  routines access to the gradients information?

This sounds similar to the issue we had with initial conditions and parameters that depend on the equation type.
I had experimented with a "combined" equation type for dispatch, but I think this would basically necessitate rewriting a bunch of the callback codes.

What if we introduced a separate set of callbacks that dispatch on the viscous cache and viscous equations?

You could try to intersect the call chain at
https://github.com/trixi-framework/Trixi.jl/blob/4afc4b73046025f6d033a497f6d4844fdae4f7cd/src/callbacks_step/analysis.jl#L462
There, the semidiscretization is passed as an argument - which should hopefully be the hyperbolic-parabolic semidiscretization in this case.

Alternatively...is reusing computed gradients worth it?

I was hoping to reuse the gradients because then the callback would not be solver specific. If we re-compute the gradients on the fly, which I am open to doing, then the callback would (maybe) need two version; one for DGSEM and another for DGMulti

I can try to add the corresponding DGMulti enstrophy callback this weekend.

@andrewwinters5000 added a draft enstrophy analysis routine. It's a bit complicated right now because I'm interpolating to quadrature points every time. If we want to avoid this cost, we could approximate the enstrophy integral using polynomial interpolation instead.
Do you have a test where you use this callback?

Do you have a test where you use this callback?

The enstrophy is in the list of extra_analysis_integrals in the elixir_navierstokes_taylor_green_vortex.jl. But I do not have a specific test that isolates just the enstrophy computation if that is what you are asking.

What are your plans for

Compute kinetic energy dissipation rate (as an analysis quantity)

?

What are your plans for

Compute kinetic energy dissipation rate (as an analysis quantity)

?

I couldn't think of a "clean" way to write such a callback. Potentially we can save an "old" value for the kinetic energy and then use the current value to compute the difference. The question I ran into was what value of delta_t is appropriate; especially with the adaptive time stepping. It might be easiest to just write a "helper" routine that opens the analysis file and uses the delta t and kinetic energy data available there to approximate the dissipation rate. Is this what you did for the Lattice-Boltzmann in the past @sloede ?

Sorry for the delay in reviewing - I've added the enstrophy callback to the DGMulti elixir too now.

The failing tests should be resolved by https://github.com/trixi-framework/Trixi.jl/pull/1268.

@andrewwinters5000 mind if I mark this ready for review?

@andrewwinters5000 mind if I mark this ready for review?

Sure that works for me. I am not sure why the coverage drops.

I think it's a spurious drop. The coverage report is showing drops in areas that we didn't touch.


gauge_card may use an attribute of the entity, instead of its state

I needed this to show current temperatures of heating controls.
Example:
- type: custom:gauge-card
  title: Living Room
  entity: climate.living_room
  attribute: current_temperature

I will review this soon

Also would be nice to get a version bump to 0.1.0 and a description in changelog

I wanted to leave that honor to you but here you go ;)


Add InitializeInternal concept to Singleton

Overview
This is introducing an abstract initialization step in singleton to help auto sort out dependencies between singletons. Say you have three singletons where singleton A depends on singleton B and uses it for something in it's initialization step. Singleton B, similarly depends on singleton C. If initialization is done in Awake, since unity doesn't guarantee an order in which Awake is called, this could lead to singleton A being initialized first, and throwing errors, similarly with singleton B and C. If you instead follow the practice of initializing in this function, initialization is done on demand, allowing Awake to be called in any order and initialization to be auto sorted, as long as there are no cycles in your dependency graph. It also allows for lazy initialization of singletons.

Can you add an example of how this is actually used IRL (for instance the hypothetical you cite in the commit description)? Right now, all Singleton derived classes just have the same empty implementation of:
protected override void InitializeInternal()
{

}

The example is in this pr: https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1506

Do we need to go though each Singleton and update its InitializeInternal implementations?

Where is the example in your PR?  I couldn't find it with all the other changes

Each one can remain empty.  Preferably, initialization happens there, but it doesn't need to.

There are definitely some places we initialize things in Awake or Start and have run into initialization order issues where this would be very helpful. The InputManager's event data creation is one that comes to mind.

@StephenHodgson @NeerajW I have addressed all the issues, can we move forward, this is dragging on quite long...

Not really sure this PR is needed if we just update the Script Execution Order of the scripts as @Railboy pointed out.

Meta file changes are a much less discoverable and robust way of doing this.

Thanks all!

This change may become redundant with the move away from Singletons #1654 , but we should ensure this use case is handled in what comes next.
Personally (after doing a full review), Singletons have been grossly overused and in may cases, just because it's in the scene and needs to be referenced.  Some should just be static, others should become "Managers" in the way forward.


Clean up StartXR script

This PR improves the start_xr script by:

Exposing target XR frame rate
Removing obsolete auto_initialize
Using modern signal.emit() syntax
Setting physics rate on WebXR
Enabling WebXR hand-tracking if enabled in project settings
Enabled WebXR passthrough support

Note: This is in preparation for improving the passthrough blend-mode support as a future PR.

Looks good!


Fuzzy completion for bash with custom Commands

Category

[ ] fzf binary
[ ] fzf-tmux script
[X] Key bindings
[X] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[ ] Linux
[X] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[X] bash
[ ] zsh
[ ] fish

I can very easily run
$vim ** [tab]
and fzf fuzzy search works as expected.
I would like to however set this up with my default editor (sublime)
currently doing:
$sublime ** [tab]
does nothing

Bash requires you to set up completion function for each command. And the list of commands that we apply fuzzy completion is currently hard-coded :confused:
But you can manually set up completion for extra commands. Add the following after source ~/.fzf.bash line in your .bashrc:
complete -o bashdefault -o default -F _fzf_path_completion sublime

Thanks so much @junegunn for the excellent and timely response


Example for using semantic sensors

Author @abhiskk:
Detailed example on how to extract information from semantic sensor

I believe this is done?

Yes, done with https://github.com/facebookresearch/habitat-api/pull/106.


The size prop is not working on the IconButton. However the edge prop is using the correct size. (I used size="small")

https://github.com/mui/material-ui/blob/ffab89c7323212fe7ab5e1578c9d7d6afc6f8282/packages/mui-material/src/IconButton/IconButton.js#L23

size prop on IconButton only changes the surrounding padding. To actually increase the size of the underlying icon, you can pass fontSize="large"/"small" etc.
Feel free to re-open if this isn't what you meant.


Docs: update readme

Signed-off-by: Hu Keping<EMAIL_ADDRESS>

Thank you for your contribution @HuKeping!


Stimulus doesn't remove listeners automatically after disconnecting

Hello,
I don't know if this is the expected behavior but any of my listeners are being removed automatically when the controller is disconnected. I have to do it myself.
This is the code of my current controller.
export default class extends Controller {
  connect() {
    ...
    $(document).on('nested:fieldAdded', function(event) {
      console.log('hello there');
      ...
    });
  }
}

This controller is my main controller, so it's used in a lot of my pages, when I go to 2 or more pages with this controller each listener is stack. Making that if I trigger the nested:fieldAdded event, the log is print twice. I don't know if this is not normal or if it's expected that I clean my listeners myself. Thank you.

Stimulus will automatically create event listeners for the actions you define data-action and tear them down for you.
Here you are manually connecting a jQuery listener.
It is your responsibility to teardown this event in the disconnect function.
Stimulus has no knowledge about it.

That's correct. Actions are the conventional way to handle events, and Stimulus automatically adds and removes listeners for them.


Armored Core Oldgen Basic Map and Text editing support

This adds support for 3 games mainly, and one as a placeholder.
All of them only for PS3, but Xbox 360 may work to some degree depending on what is done, there are no other platforms for these games outside of PS3 and Xbox 360.
AC4 - Armored Core 4, only a placeholder for now.
ACFA - Armored Core: For Answer, the game after AC4 in the same generation, support is for loose loaded only right now.
ACV - Armored Core V, the first 5thgen game, uses edge FLVER2 models on PS3.
ACVD - Armored Core Verdict Day, follows ACV in 5thgen.
FLVER CHANGES:
For 5thgen support FLVER2 needed edge index decompression at the very least to even read the models, which I researched and implemented entirely in C#. The bitstream reading for it can be improved as I use strings to read the bits for now.  I also implemented edge decompression for FlverResource's fast loading FLVER stuff.
Another change to FLVER2 is shared facesets, some 5thgen models share facesets and use them more than once it seems? Needs more investigation but removing an error check allows them to read. I also removed the old SekiroUnkStruct class as it seems SkeletonSet is what it was and is used now instead.
The FLVER0 implementation in Smithbox was outdated and missing write, so I got the FLVER0 implementation from DSMS and moved the newer Flver stuff discovered for Smithbox into it.
I also added some more vertex types that were missing for FLVER.
FLVER2 edge is not completely supported, but edge index decompression is. The gist of it is, they use edge for face indices, and another kind of edge for vertex positions, but they also always include uncompressed positions for some reason. Edge positions are their own buffer and have a header, I can decompress one kind, but another kind has something I don't know anything about and fails reading. They also need info from edge data in facesets for stuff like vertex count (EdgeGeomSpuConfigInfo). For now edge vertex positions are skipped, as uncompressed positions always exist in 5thgen AC anyways.
TEXTURE CHANGES:
Textures are found by a FLVER's texture paths in FlverResource, but these paths are completely unreliable in AC games, some paths are only names, and some names are for generic objects like "billboard" which says nothing about where it comes from. In an effort to bypass the virtual pathing problems, I instead make the virtual paths purely names. This also seemed to find some more textures for a DeS tutorial map.
I am unsure if this would affect textures when loading multiple maps. For some reason the texture resources don't get automatically unloaded with this change when unloading maps. This change can simply be reverted by uncommenting the older code for texture virtual paths, and making loaded TPFs include the virtual path base in the resource system again.
MSB ADDITIONS:
I added MSBFA for ACFA, MSBV for ACV, and MSBVD for ACVD. These are the MSB classes for those games. In them some array like structures are expandable to an extent like point reference names, but no implementation currently exists in the property editor to expand arrays to my knowledge. I made them use lists in these places in these MSB for future expansion of lists.
I also added extremely barebones MapStudioTree generation support. DES, AC4, ACFA, ACV, and ACVD all use the exact same implementation of MapStudioTree. It is a bounding volume hierarchy, probably considered to be an AABB tree. Each box holds part indexes, and can have a single index, multiple indexes, or no indexes (branching). They have left and right children for each node and use local offsets to find children. Figuring out how to generate efficient ones is difficult at the moment, so I am only making one big box and adding a bit of size, without the added size some models get culled.
I added an interface for MSB using trees, IMsbTreeParam, if there is a better way of going about this please let me know.
For ACV and ACVD there are two  MapStudioTrees, one for collision, and one for model culling. ACFA is similar but some old test MSBs have 4 empty trees. AC4 is probably the same as ACFA for this.
Without this support, removing parts may cause indices to go out of range and crash the game, for DeS this is probably not much of an issue as I imagine not much map editing goes on there, but with extreme edits or massive removals this can be an issue. Regenerating the entire tree is ideal but may cause slight performance downgrades for ACV and ACVD who are extremely performance sensitive in game so I need to figure out a proper algorithm later.  I have not added the MapStudioTree support to DeS, but its exactly the same as all of the other games, and recalculating the trees can be ignored for now.
PARAM ASSET ADDITIONS:
I added paramdefs for ACFA, ACV, and ACVD.  5thgen paramdefs have english internal names, while ACFA didn't support internal names yet.  I got the best translations I could from 5thgen and from what I had to do with google translate, into internal names for ACFA. ACV and ACVD have a lot of param info that is easily backported to ACFA, including tons of TDFs ACFA did not provide. These defs are all DSMS legal to my knowledge (as it loads them itself), though I cannot immediately test the param editor in Smithbox without some leniency changes regarding params I will look into later for Smithbox.
MAP ASSET ADDITIONS:
I added friendly map names for most ACVD maps, but that's it for now regarding that.
EDITOR CHANGES:
I had to add list support to several property editor actions to support list editing for MSB but it works so far.
I had to also add null checking to the property editor as some things in these MSB are not always present and need deep research to figure out why, so null is used when they don't exist, and the editor crashed when this was the case.
For text editing I noticed input was not being saved, I fixed this by seeing how DSMS saved theirs, but I see you may have already made your own commit for it recently. I also added .bak and .prev backup functionality to the text editor instead of saving text changes with no backups.
The duplicate to map combobox was not working from the edit menu and would cause an assertion failure in imgui's native code, causing a hard crash. I changed it to load like DSMS, a single line change at an imgui if statement.
PATHING ADDITIONS:
I noticed the equal to enemies from these AC games might be characters for models. Instead of chr, the older AC games use ene. I implemented ene as its own thing in several places but it might fit just fine in character loading as long as ene is used for a path there.
I added support for ACFA, ACV, and ACVD loose loaded files for model, texture, map, and fmg loading. ACFA is normally packed and you have to really go out of your way to loose load the game so I want to fix that later. ACFA does not use BHD5. It instead uses a collection of BND3s for the release build of the game that pack up important resources based on when loading them in groups would be ideal.
ACV and ACVD use BHD5, but without encryption so repacking is possible, but they also support loose load out of the box and there is a loose loader I made for that purpose, so no reason not to loose load them. Something like ME2 is far from being supported for these games as well right now unfortunately.
DEBUGGING CHANGES:
For easier debugging I added some !DEBUG checks against try catch statements, ideally if this is to be used, some kind of variable other than DEBUG should be used for checking. It was useful for variable values, as try catches would completely erase all of that with an exception stack frame, something I don't fully understand myself. These #if statements surround the try and then the catch parts separately.
ISSUES:
As mentioned before, textures are not unloading automatically when unloading maps because of the virtual path change for some reason. The virtual path being only a name may cause issues when loading multiple maps but I'm not sure.
Ene models for all the games I've implemented do not transform correctly, I have no idea why. The meshes look fine, but it looks almost like all of the bones where moved into the root bone or something. All of these models use normal W for bone transformations, but making it use DSMS's normalW transform makes all models except skyboxes invisible for these games. IndexNoWeight transforms change some things slightly but still mess up almost completely.
A lot of skybox models (domes) for ACFA have flipped faces for some reason, a FLVER0 triangulation issue of some sort probably. You usually see an arrow like face looking from the top that was flipped, but sometimes its a strip of triangles down a seam (m070).
ACV and ACVD textures do not load correctly, most of the time they don't show anything at all, but sometimes a tiny bit of texturing can be seen. A tunnel map in ACFA also has its textures only showing tiny splotches making most of the map look invisible, but most maps load almost full textures without issue. Some ACFA buildings also have windows that become holes in the model visibly for texturing, not sure why.  ACFA textures become extremely shiny for some reason in a lot of places.
ACFA pathing on the release build of the game is packed up into BNDs, but looks like ACV or ACVD when loose loaded with a lot of effort. Better BND support needs to be looked into for loading its MSBs and its massive model archives.
For example, ACFA stores every mission in its own event BND, and the event BND holds the MSB. The map models and textures are in their own individual BNDs, but those BNDs are all thrown inside of one massive map.bnd file. The obj and ene resources are packed similarly in ene.bnd and obj.bnd respectively.
Param support is not yet added in Smithbox for these games. for the following reasons.
These AC games use a lot of params, some params must be localized due to them including text directly in the param, such as design and designer names for AC designs in AcAssemblyDrawing, or mission descriptions in MissionInfo. There is also a param for every individual mission, which are generically named with the map/mission ID like m010.bin. This name is reused in two places for 5thgen so a dictionary of names is not enough for loading all params. In my fork of DSMS I included part of the path secretly for the dictionary and display only the name to users.
Most params use the .bin extension, with like only two using .param. The game also mixes non-param files in with the params with the same extensions, but the game provides a way to find them. The game uses paramlist XMLs which are ResourceLists. I implemented these for my fork of DSMS and they work rather well, but not in Smithbox yet. However, localized params are not included there. Though they are easy enough to pick out at this point.
Some ACFA params' last row has what is seemingly extra padding at the end, like 8 to 12 bytes of null data. This usually occurs on a few single row params, but occurred on one that wasn't a single row. In my DSMS fork I had to make it a bit more lenient, but was still able to make this isolated for only ACFA.
Sorry if I left anything out, or if this is a bit long. Let me know if you have any questions, I can recall why I did something if pointed at it.

Also the most recent commits for the model editor could be entirely discarded, I was looking into adding placeholders for these games, but as they probably aren't going to be supported for a while, it might be cleaner to ignore those changes.


allow mappers config overriding

Description
When workspaces include multiple GraphQL projects, and graphs share the same core model. In this case, I would like to write the core model mappers only once in the root config and additional mappers per plugin, but that is not currently allowed.
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I skipped it because there are no existing tests for config. Please tell me if it requires
Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@charlypoly I expect that the JSONSchema for editor support is also need to be changed. Is it automatically generated? Or is it managed elsewhere?

Hi @cometkim,
What do you mean by "JSONSchema for editor support"?

I meant this https://www.graphql-code-generator.com/config.schema.json

I meant this https://www.graphql-code-generator.com/config.schema.json

This file is automatically generated

@cometkim, I've fixed your PR to support the following configuration:
schema: "schema.graphql"
documents: src/*.ts
mergeMappers: true
config:
    mappers:
      ID: IDType
generates:
  resolvers-types-1.ts:
    plugins:
      - typescript
      - typescript-resolvers
    config:
      mappers:
        String: StringType
  resolvers-types-2.ts:
    plugins:
      - typescript
      - typescript-resolvers
    config:
      mappers:
        String: StringType

Example setup is available here: https://github.com/charlypoly/codegen-repros/tree/master/merged-config
You can see that I added a mergeMappers flag (default: false) since introducing this change will be breaking for most configurations.
Let me know what you think 👀

@cometkim, actually, this new options is not necessary since you can achieve same result using YAML references:
codegen.yml
schema: "schema.graphql"
documents: src/*.ts

shared_mappers: &shared_mappers
  ID: IDType

generates:
  resolvers-types-1.ts:
    plugins:
      - typescript
      - typescript-resolvers
    config:
      mappers:
        <<: *shared_mappers
        String: StringType
  resolvers-types-2.ts:
    plugins:
      - typescript
      - typescript-resolvers
    config:
      mappers:
        <<: *shared_mappers
        String: StringType

I'm closing this PR and will update the typescript-resolvers documentation with the above example

https://github.com/dotansimha/graphql-code-generator/pull/8177


feat(extension-chrome): add network and whitelist sites implementation

This PR takes full implemented freature of wallet whitelist and network select. Includes these features:

Search and remove whitelist sites
toggle network of blockchain
add new network of blockchain

Screenshots

@homura Can you help confirm these unresolved conversation?


Show a message when user is not authorized yet

Fix #164, show a message when user is not authorized instead of json decoding error.

Thanks @qyzdo !


🔍 Add email distribution list registration form

This adds the email distribution list to our main README.md

Super! Let's merge!

Super! Let's merge!

Got it, just digging a bit into these weird failures in the windows machines


no default region is exported

aws-okta-processor authenticate --environment --user XXX --organization XXX -R us-east-1 --no-okta-cache --no-aws-cache
but only AWS key is exported to environment variable, not the AWS_DEFAULT_REGION
What is the use of -R?

If for some reason AWS STS API is having issues for a specific region you can force communication to occur on another region. I have personally never had to set region since STS has always worked with the region it defaults to. Also be aware IAM Roles are not regionally scoped.


Pods stuck in "pending" and kubectl get nodes said: "no resources found"

Rancher Versions:
v1.3.1
Docker Version:
1.12.5
OS and where are the hosts located? (cloud, bare metal, etc):
SUSE Linux Enterprise Server 12 SP2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single Node Rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Kubernetes 1.5.1
Steps to Reproduce:
Set up rancher v1.3.1 with proxy env's -> Set up New Environment Kubernetes 1.51. After the complete infrastructure stack is active create any stack from the catalog e.g. K8s Example Guestbook.
Results:
The pods will never start and 'kubectl get nodes' says "no resources found" but the confusing part is, that the whole infrastructure stack stays green (active).

I have rancher/enterprise and Docker v1.12.5 and see exactly the same issue.

Any update?

What do you have for your nodes host name(s)?

Up! Any news ?

if this is reproducible on the latest version of rancher/k8s (1.5.9+) please let us know.


[BUG] SSL protocol error on some builds of Chrome

Description of the bug
On some versions of Google Chrome, the eddiehub.org site fails to
load with an SSL protocol error.
Not working: Version 94.0.4606.61 (Official Build) (x86_64)
Working: Version 94.0.4606.71 (Official Build) (x86_64)
Project stack or language (e.g. front-end)
Chrome
Working Environment (e.g. operating system, browser, device)
Google Chrome on MacOS Big Sur 11.6
Please add screenshots (if applicable)

Add any other context about the problem here
Problem resolved by upgrading Chrome.

That's weird.

Thanks @vielmetti for raising. I am going to close this for now if no one else can verify the same issue.
Feel free to comment if it is still an issue and we can re-open it

Thanks @eddiejaoude - confirmed to all be working as of
Version 102.0.5005.61 (Official Build) (arm64)

thanks for confirming 👍


Only show max of the day in charts

Hi, since you liked the idea, I cleaned up the code a bit and made a PR.
Thank you for this nice extension and have a good day!

Thx again! See also #57.


PyPi Publish and GitHub Release Tag in CI/CD

Rebuilding the tag-based deploy cycle from Gitlab, likely with some adaptations.

@edgarrmondragon has picked this up as part of 2.2.0 release.

Closed by:

https://github.com/meltano/meltano/pull/6338
https://github.com/meltano/meltano/pull/6145
https://github.com/meltano/meltano/pull/6346
https://github.com/meltano/meltano/pull/6348


Battleground.GetEnemyReachMod() throws an error when character carries a shield

Most likely WeaponM.Reach is not set correctly. Or maybe not. Load character Rhydderch Dijstra" and call battleground dialog to get the error.

Shield was missing in DB (whale shield)


When WSL is slow to respond, and a WSL profile is default, we throw a weird error message

Environment
Windows build number: Microsoft Windows [Version 10.0.19628.1]

Windows Terminal version (if applicable): Windows Terminal Version: 1.0.1401.0

Any other software?

Steps to reproduce
After booting completes. Open terminal. And error pops up. Close the terminal and reopen, then the terminal open the shell in /mnt/c/Users/being$ directory.
After again closing the terminal and reopen it starts working normally.
Expected behavior
Load all the settings listed in C:\Users\being\AppData\Local\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState\settings.json file correctly
And open in just 1 time.
Actual behavior

After first opening the terminal this error pops up.

Encountered errors while loading user settings

After second opening the terminal. It starts in /mnt/c/Users/being$ irrespective of starting directory mentioned in the setting.json

After 3 time opening the terminal it works correctly.

Actual json file.

 // This file was initially generated by Windows Terminal 0.11.1333.0
 // It should still be usable in newer versions, but newer versions might have additional
 // settings, help text, or changes that you will not see unless you clear this file
 // and let us generate a new one for you.

 // To view the default settings, hold "alt" while clicking on the "Settings" button.
 // For documentation on these settings, see: https://aka.ms/terminal-documentation
 {
    "$schema": "https://aka.ms/terminal-profiles-schema",

    "defaultProfile": "{2c4de342-38b7-51cf-b940-2309a097f518}",

    // You can add more global application settings here.
    // To learn more about global settings, visit https://aka.ms/terminal-global-settings

    // If enabled, selections are automatically copied to your clipboard.
    "copyOnSelect": false,

    // If enabled, formatted data is also copied to your clipboard
    "copyFormatting": false,

    // A profile specifies a command to execute paired with information about how it should look and feel.
    // Each one of them will appear in the 'New Tab' dropdown,
    //   and can be invoked from the commandline with `wt.exe -p xxx`
    // To learn more about profiles, visit https://aka.ms/terminal-profile-settings
    "profiles":
    {
        "defaults":
        {
            // Put settings here that you want to apply to all profiles.
        },
        "list":
        [
            {
                "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl",
                "startingDirectory": "\\\\wsl$\\Ubuntu\\home\\dark",
                "icon" : "C:\\Users\\being\\ubuntu.png"
            },
            {
                // Make changes here to the powershell.exe profile.
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": false
            },
            {
                // Make changes here to the cmd.exe profile.
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt",
                "commandline": "cmd.exe",
                "hidden": false
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },

    // Add custom color schemes to this array.
    // To learn more about color schemes, visit https://aka.ms/terminal-color-schemes
    "schemes": [],

    // Add custom keybindings to this array.
    // To unbind a key combination from your defaults.json, set the command to "unbound".
    // To learn more about keybindings, visit https://aka.ms/terminal-keybindings
    "keybindings":
    [
        // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json.
        // These two lines additionally bind them to Ctrl+C and Ctrl+V.
        // To learn more about selection, visit https://aka.ms/terminal-selection
        { "command": {"action": "copy", "singleLine": false }, "keys": "ctrl+c" },
        { "command": "paste", "keys": "ctrl+v" },

        // Press Ctrl+Shift+F to open the search box
        { "command": "find", "keys": "ctrl+shift+f" },

        // Press Alt+Shift+D to open a new pane.
        // - "split": "auto" makes this pane open in the direction that provides the most surface area.
        // - "splitMode": "duplicate" makes the new pane use the focused pane's profile.
        // To learn more about panes, visit https://aka.ms/terminal-panes
        { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
    ] }

I have same problem

I believe this is a side effect of WSL not responding to our request for information fast enough. When that happens, we think there is no WSL distribution available.

I tried with WSL2.
Still getting this error.

Update
Now everytime the Terminal neglect starting directory mentioned and start at /mnt/c/Users/being$~

An error message saying something like 'WSL service did not respond in time, not able to use WSL.  Please check whether WSL is running and restart the terminal' would go a long way to making this less confusing to the user.  I spent 10 minutes this morning trying to work out what had become wrong in my terminal settings file as a result of a reboot, before discovering that the problem just went away if I restarted Terminal.
A dialog with 'give up' and 'retry' options would be better, so if I think WSL is probably just slow, I can retry, if I've done something like uninstall WSL I can go and edit my settings.  Ideally, some monitoring of the WSL service status and system load would let the terminal diagnose whether this is a slow response, the WSL service is crashed, or WSL is not enabled at all and do the right thing, but given that I've been using the terminal as my daily driver for over a year and seen this problem once, the engineering time required to do all of that would be better spent on something else.

An error message saying something like 'WSL service did not respond in time, not able to use WSL.  Please check whether WSL is running and restart the terminal' would go a long way to making this less confusing to the user.  I spent 10 minutes this morning trying to work out what had become wrong in my terminal settings file as a result of a reboot, before discovering that the problem just went away if I restarted Terminal.
A dialog with 'give up' and 'retry' options would be better, so if I think WSL is probably just slow, I can retry, if I've done something like uninstall WSL I can go and edit my settings.  Ideally, some monitoring of the WSL service status and system load would let the terminal diagnose whether this is a slow response, the WSL service is crashed, or WSL is not enabled at all and do the right thing, but given that I've been using the terminal as my daily driver for over a year and seen this problem once, the engineering time required to do all of that would be better spent on something else.

Reproduces Microsoft Windows [Version 10.0.19042.804] and WSL2 5.4.72-microsoft-standard-WSL2

Compile a large program in Visual Studio 2019. Naturally VS uses all cores to compile
Run Windows Terminal

Result
The error message in the OP and no ability to launch a WSL2 distribution from Windows terminal. No distributions are listed in the WT pulldown in the menu bar.
Expected
No error message. WSL2 opens at its designated distribution prompt
Workaround
Don't use Windows Terminal.
Instead, run the specific WSL2 distribution from Start menu which uses some other console binary for the command line.

I think Terminal should propose to wait longer in this case and clearly explain what is going on.
This situation is frequent on laptops with HDD where it can take arbitrary time for WSL to respond (especially if some libraries need to be loaded from paged out memory)

Okay, I prototyped a warning in dev/migrie/b/6160-dynamic-default-warning.
It looks like this now:

With #10967, I don't think this will be hit with any frequency. And with some of the work in #9997, we will also need to revisit this approach. We'll actually be keeping around profile blobs for profiles that the user had in their settings file but didn't successfully layer onto an existing profile. With those hanging around, then it'll actually be easier to fix.


modify adapter to laavel-9.x^ compactible

I updated the adapter  to suit Laravel 9.x^ as referenced in the documentation https://laravel.com/docs/9.x/upgrade#flysystem-3
Please review and merge

@Joemires
v2 is already compatible with Laravel 9 & 10 buts its set as alpha-release.


Update Gitfox images and meta info in GUI list

Updated Gitfox meta information and corresponding image assets

Thanks, looks like this matches the current data from www.gitfox.app.


Added the kafka source 1.14

Added the kafka source 1.14 manifests.
Added the RBAC missing for the kafka source 1.14.

/lgtm


Query timezone of calendar for events?

I know this may not be an actual bug rep but really wanted to ask if there was a way to query the calendars current timezone because we use a UTC server with this package and people want to schedule events in their calendars default tz?

Hey, thanks for your question.
Unfortunately, there is no implementation of the calendar and calendarList processing (talking about #62).
As a workaround, you can use GoogleCalendar.service field:
gc = GoogleCalendar(...)
calendar_json = gc.service.calendars().get(calendarId='primary').execute()
tz = calendar_json['timeZone']

This will give you The time zone of the calendar. (Formatted as an IANA Time Zone Database name, e.g. "Europe/Zurich".)
See more here and here.
In future, you can use GitHub Discussions or Discord server.
Will close the issue. If you have any more questions, please, feel free to reach out!


Simulator builds fail due to use of stable release channel

I'm getting failing simulator builds of the crankstart examples.
The device builds (eg --device) are fine.
I'm new to both playdate & rust so bare with me.  I've followed the full setup in the README including the nightly toolchain and thumbv7em-none-eabihf target. I'm on macOS 13.6.6.
Here's the full error:
crank build --release --example hello_world
   Compiling num-traits v0.2.18
   Compiling cstr_core v0.1.2
   Compiling rand v0.8.5
   Compiling rand_pcg v0.3.1
   Compiling randomize v3.0.1
   Compiling syn v1.0.109
   Compiling hashbrown v0.14.3
error[E0554]: `#![feature]` may not be used on the stable release channel
  --> /Users/garethknowles/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cstr_core-0.1.2/src/lib.rs:12:40
   |
12 | #![cfg_attr(feature = "alloc", feature(alloc))]
   |                                        ^^^^^

For more information about this error, try `rustc --explain E0554`.
error: could not compile `cstr_core` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Error: cargo failed with error ExitStatus(unix_wait_status(25856))

Adding +nightly flag to the simulator builds - matching what seems to be done for device builds looks to fix the issue for me locally. I don't really know what I'm doing here but I've go the examples running now 👍
pd-rs/crank/pull/58


prevent bp_mem_transducer from overwriting current request

In bp_mem, the transducer may accept a new request when it is already processing a request. This causes the initial request to be overwritten, and bp_mem to send back an incorrect response to the first request.

I am still investigating this. It only manifested in the bp_cce testbench in the ME, I think because it was able to issue multiple memory requests fast enough that bp_mem was already occupied when the second one arrived.
Perhaps a better solution here is to insert a fifo in bp_mem for inbound memory commands, since bp_mem is a simulation component?

mem_cmd_ready_o depends on ready_i, so mem_cmd_v_i should not be high (r->v)

(As in whatever module is connecting has a handshake bug)

Hmm, okay. I missed that when I looked at the code lol. I'll add a comment to bp_mem (unless I missed that, too) and check my TB.

The memory is definitely not representative of actual dram because the latency model only processes 1 request at a time, as you noted. Really, there should be a fifo, an array of n latency models and a rr arbiter.


Extraterm-qt Window toggle doesn't work

When hitting Toggle Show/Hide window it either:

hides the window and doesn't show it again upon hitting toggle again
hides the window briefly and  brings it back without having to hit toggle again
doesn't hide the window at all

So far I've been unable to reproduce a predictable behaviour.
Looks like this (quality reduced to reduce size):

Arch linux
Kernel: Linux 6.11.5-arch1-1.1-g14
GNOME Version: 47
Windowing system: Wayland
Installed from AUR as extraterm-bin:
$ pacman -Q extraterm-bin
extraterm-bin 0.78.0-1
$

Edit:
Tried with 0.79 as well, same issue.

I suspect this is Wayland related.


linuxPackages.nvidia_x11_production: 525.85.05 -> 525.89.02

Description of changes

Release highlights since 525.85.05:

Fixed a bug that could cause banding or flickering of color gradients on DisplayPort monitors.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Currently running into space issues running nixpkgs-review, but confirmed linuxPackages_latest.nvidia_x11_production(_open)? build without errors.
Also looks like ofborg is not having a good day

@ofborg eval


Wrong StatusBar appearance with View controller-based status bar appearance

When the App has View controller-based status bar appearance set to YES in Info.plist the statusbar handling of SKPhotoBrowser is broken (black on black).
This can be circumvented by using a subclass which implements preferredStatusBarStyle.
For convenience, if anybody else runs into this problem:
import UIKit
import SKPhotoBrowser

open class ExtendedSKPhotoBrowser: SKPhotoBrowser {

    open override var preferredStatusBarStyle: UIStatusBarStyle {
        return .lightContent // white statusbar, .default is black
    }

}

Just instantiate ExtendedSKPhotoBrowser instead of SKPhotoBrowser.

Closing and keeping it as a reference for further documentation here.

I know it's an old issue, but just commenting to try to improve lib behavior.
The same behavior still continues here. I think the proposed solution should be default to display the status bar since the default background color is dark.


fix(instrumentation-aws-sdk): temporarily disable failing sqs test

Which problem is this PR solving?
See #1477. This test constantly failing reduces the visibility of failing tests in other packages. Skipping this test for now until #1477 is resolved. I'll add a comment in #1477 to remove the skip().

Looks like actually all 3 tests in custom service behavior failing.

Hmm, looks like now the tests are failing with Error: Cannot find module '@smithy/hash-stream-node' - I wonder if this is as similar issue to the one we're seeing in #1828

Hmm, looks like now the tests are failing with Error: Cannot find module '@smithy/hash-stream-node' - I wonder if this is a similar issue to the one we're seeing in #1828

Explained here: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1828#issuecomment-1834276719
tl;dr<EMAIL_ADDRESS>was just a bad release.  #1828 will resolve it, because I've reduced the aws-sdk/client-s3 versions tested in the .tav.yml file, and explicitly skipped that broken version.

https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1847 is an alternative change that reduces the number of tests skipped.


Drop deprecated toPromise and use lastValueFrom operator

Rxjs refactoring to drop the deprecated toPromise method in favor of the lastValueFrom operator.

Also, maybe this kind of thing helps with the replacement


Added missing header to the RNSVGImage.m file to fix a build error wh…

Added missing header to the RNSVGImage.m file to fix a build error when when importing as a cocoapod. While building we received the following error:
error Failed to build iOS project. We ran "xcodebuild" command but it exited with error code 65. To debug build logs further, consider building your app with Xcode.app, by opening <redacted>.xcworkspace

** BUILD FAILED **

The following build commands failed:
	CompileC /Users/rbarclay/Development/<redacted>/packages/app/ios/build/<redacted>/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RNSVG.build/Objects-normal/x86_64/RNSVGImage.o /Users/rbarclay/Development/<redacted>/packages/app/node_modules/react-native-svg/ios/Elements/RNSVGImage.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

by including the above header, it resolved the problem.
our cocoapod file is configured as such:
# Fix for cocapods and the new build system to not have to clean after each build when making changes to pods
install! 'cocoapods', :disable_input_output_paths => true

# Specifies the minimum deployment target for iOS.
platform :ios, '10.0'

# Supresses warning from pod modules. Many of these we cannot fix, so why fill our warnings in xcode with them. We can
# enable warnings on a specific module if needed. Compilation errors will be shown.
inhibit_all_warnings!

target '<redacted>' do

  pod 'React', :path => '../node_modules/react-native', :modular_headers => true, :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTText',
    'RCTNetwork',
    'RCTWebSocket', # Needed for debugging
    'RCTAnimation', # Needed for FlatList and animations running on native UI thread
    'RCTLinkingIOS',
    'RCTImage',
    'RCTPushNotification',
    'RCTSettings',
    'RCTVibration',
    'RCTLinkingIOS'
  ]
  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  pod 'RNSVG', :path => '../node_modules/react-native-svg'

  # The following line needs to be here, and new pods when linked with the 'react-native link [module name]` command
  # added below the line automagically

  # Add new pods below this line

end

Thanks!

@robertbarclay Could you take a look at https://github.com/react-native-community/react-native-svg/issues/1025

@robertbarclay Is this really needed? Are you sure the issue wasn't caused by anything else? It seems this breaks building with normal linking and I'll probably have to revert this unless some better workaround is found very soon.


Add AriaLib to the AT interactive test page

If the application under test does not declare AriaLib as its widget lib (because it does not use widgets, or uses only HtmlLib for instance), then the Classic Test Runner test page failed to load

Integrated in master in ec5b9e0ced7992cbad6fb12cac7a439d56ba386f.

@jakub-g Thank you for your pull request.
As you can see in WidgetLibsSettingsCfgBeans, the aria widget library is already defined by default.
So, I suppose that, if you feel the need to set it again in the Classic Test Runner test page, it means it was overridden specifically by configuration in a script defined through the extraScripts parameter.
However, due to the way environment properties are merged, doing this will remove all other widget libraries previously defined in the environment.
I think it is better to follow your idea of changing all our classic test runner templates to include explicitly the $wlibs : { 'aria' : 'aria.widgets.AriaLib' } parameter. I let you open the pull request on Aria Templates if you want this approach to be implemented.

Yes I was thinking about changing the test runner TPLs but this was a quicker thing to do. I will have a look at the TPLs


EITDATA file is corrupted

Please verify EITDATA.json file. It is corrupted and does not contain all data.

Did you find a work around?

Yes, I used the matlab files.

Hey! Thanks for the reminder of this, and the interest in the data. MATLAB writing JSON has a character limit so the JSON was truncated. This has been fixed in resfix #7


Datasets with very big max lat/lon

2 datasets in the inventory (v20210301) have very large latitude and longitude values of<PHONE_NUMBER>047466219876688855040.00.
These are:
/badc/cmip6/data/CMIP6/ScenarioMIP/CAS/FGOALS-g3/ssp534-over/r1i1p1f1/SImon/siconc/gn/v20200706
/badc/cmip6/data/CMIP6/CMIP/SNU/SAM0-UNICON/historical/r1i1p1f1/SImon/siconc/gn/v20190323
They are both on irregular grids (i, j) but i and j both have sensible max values:
320 and 384 respectively for /badc/cmip6/data/CMIP6/CMIP/SNU/SAM0-UNICON/historical/r1i1p1f1/SImon/siconc/gn/v20190323
360 and 218 respectively for /badc/cmip6/data/CMIP6/ScenarioMIP/CAS/FGOALS-g3/ssp534-over/r1i1p1f1/SImon/siconc/gn/v20200706
should these be included in the inventory?

tagging @agstephens @RuthPetrie

Looks like the FillValue has been changed from 1e+30 to 1e+20 but the data still contains the 1e+30 FillValue

These have been removed from the inventory for now


check CUDA_HOME; warn if version mismatch (or unset).

Checklist before submitting

[ x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Moved from https://github.com/open-ce/open-ce/pull/319 due to project reorganization; for
https://github.com/open-ce/open-ce/issues/88
Checks if $CUDA_HOME set; sets to default /usr/local/cuda if not set.
Checks whether requested cudadev build version matches local version in CUDA_HOME.
Issues WARNING if not.
(Note: does not abort build (non-fatal) because: CI may build without $CUDA_HOME set such
that we set to default path, which isn't present on build system; we don't want this to prevent
the build from proceeding.)
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

Codecov Report

Merging #3 (9d3a318) into main (37c8720) will decrease coverage by 0.24%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   95.56%   95.32%   -0.24%
==========================================
  Files          20       20
  Lines        1689     1710      +21
==========================================
+ Hits         1614     1630      +16
- Misses         75       80       +5

Flag
Coverage Δ

unittests
95.32% <76.19%> (-0.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
91.58% <73.68%> (-1.86%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c8720...9d3a318. Read the comment docs.

This was moved from a PR in open-ce/open-ce (noted above previously).  But unfortunately I've not given it attention since then.  It had been reviewed already, and there had been two remaining comments left to be addressed:
From Nishidha:
I think this call should be .... added into build_tree's constructor too so that it can be called once when build env command is triggered.
And from Deepali:
I think we can also add a test for the newly added functionality.

Codecov Report

Merging #3 (322b0f6) into main (144c789) will decrease coverage by 0.27%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.59%   96.32%   -0.27%
==========================================
  Files          23       23
  Lines        1936     1957      +21
==========================================
+ Hits         1870     1885      +15
- Misses         66       72       +6

Flag
Coverage Δ

unittests
96.32% <76.19%> (-0.27%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.28% <73.68%> (-1.50%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144c789...322b0f6. Read the comment docs.

Codecov Report

Merging #3 (322b0f6) into main (144c789) will decrease coverage by 0.27%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.59%   96.32%   -0.27%
==========================================
  Files          23       23
  Lines        1936     1957      +21
==========================================
+ Hits         1870     1885      +15
- Misses         66       72       +6

Flag
Coverage Δ

unittests
96.32% <76.19%> (-0.27%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.28% <73.68%> (-1.50%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144c789...322b0f6. Read the comment docs.

Codecov Report

Merging #3 (322b0f6) into main (144c789) will decrease coverage by 0.27%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.59%   96.32%   -0.27%
==========================================
  Files          23       23
  Lines        1936     1957      +21
==========================================
+ Hits         1870     1885      +15
- Misses         66       72       +6

Flag
Coverage Δ

unittests
96.32% <76.19%> (-0.27%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.28% <73.68%> (-1.50%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144c789...322b0f6. Read the comment docs.

Codecov Report

Merging #3 (3e3dd49) into main (9911a95) will decrease coverage by 0.21%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.60%   96.40%   -0.21%
==========================================
  Files          23       23
  Lines        2032     2053      +21
==========================================
+ Hits         1963     1979      +16
- Misses         69       74       +5

Flag
Coverage Δ

unittests
96.40% <76.19%> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.70% <73.68%> (-1.52%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9911a95...3e3dd49. Read the comment docs.

Codecov Report

Merging #3 (7edbf0e) into main (2836c38) will decrease coverage by 0.21%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.60%   96.40%   -0.21%
==========================================
  Files          23       23
  Lines        2032     2053      +21
==========================================
+ Hits         1963     1979      +16
- Misses         69       74       +5

Flag
Coverage Δ

unittests
96.40% <76.19%> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.70% <73.68%> (-1.52%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2836c38...7edbf0e. Read the comment docs.

Codecov Report

Merging #3 (7edbf0e) into main (2836c38) will decrease coverage by 0.21%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   96.60%   96.40%   -0.21%
==========================================
  Files          23       23
  Lines        2032     2053      +21
==========================================
+ Hits         1963     1979      +16
- Misses         69       74       +5

Flag
Coverage Δ

unittests
96.40% <76.19%> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/utils.py
93.70% <73.68%> (-1.52%)
:arrow_down:

open_ce/build_feedstock.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2836c38...7edbf0e. Read the comment docs.

Oh....and....I never did finish this old PR!  Is it still desired?  Anyone still want it?
I won't delete it, just in case anyone wants to grab it and make a new PR of their own with this code as a starting point. But I will personally step back from it.

@npanpaliya @cdeepali - what should we do with this PR?

I think we can close it as it is not must to have. We can anytime use the changes of this PR in case such requirement comes.

Thanks, closing


Bug: Doesn't work on fresh Nuxt app

Hello, I just created a brand new nuxt app and setup this package but no manifest.json is detected. Specifically I am using "nuxt": "^3.5.2" and "@vite-pwa/nuxt": "^0.1.0". I have setup vite-pwa before with sveltekit so I am somewhat familiar with the process, but I can't figure out why this wont work with nuxt?
Below is my config file:
import { defineNuxtConfig } from "nuxt/config";

export default defineNuxtConfig({
  modules: ["@vite-pwa/nuxt"],
  pwa: {
    // devOptions: { enabled: true },
    manifest: {
      name: "T",
      short_name: "T",
      description: "T",
    },
  },
});

Found my issue, needed to include <VitePwaManifest /> in app.vue. I think we should add this step to the docs. Full example below:
<template>
  <div>
    <VitePwaManifest />
    <NuxtWelcome />
  </div>
</template>

https://vite-pwa-org.netlify.app/frameworks/nuxt.html#registering-web-manifest

I think this section could be made for obvious as i also completely missed this

If it's solved, then @nicodes please close this issue.

export default defineNuxtConfig({
runtimeConfig: {
public: envData,
},
router: {
mode: "history",
},
buildModules: [
"@nuxtjs/composition-api/module",
["@pinia/nuxt", { disableVuex: false }],
"@nuxtjs/tailwindcss",
],
modules: [
"@vite-pwa/nuxt",
"@element-plus/nuxt",
"@pinia/nuxt",
"@pinia-plugin-persistedstate/nuxt",
],
pwa: {
registerType: "autoUpdate",
manifest: {
name: "D",
short_name: "D",
theme_color: "#ffffff",
icons: [
{
src: "pwa-192x192.png",
sizes: "192x192",
type: "image/png",
},
{
src: "pwa-512x512.png",
sizes: "512x512",
type: "image/png",
},
{
src: "pwa-512x512.png",
sizes: "512x512",
type: "image/png",
purpose: "any maskable",
},
],
},
workbox: {
globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
},
client: {
installPrompt: true,
periodicSyncForUpdates: 20,
},
devOptions: {
enabled: true,
suppressWarnings: true,
navigateFallbackAllowlist: [/^/$/],
type: "module",
},
},
plugins: [
// { src<EMAIL_ADDRESS>mode: 'client' }
// '~/plugins/dict',
// '~/router.js'
// { src: '~/plugins/router.plugin.ts', mode: 'client' },
],
pinia: {
autoImports: [
// automatically imports defineStore
"defineStore", // import { defineStore } from 'pinia'
["defineStore", "definePiniaStore"], // import { defineStore as definePiniaStore } from 'pinia'
],
},
build: {
transpile: ["/^element-plus/", "vue-i18n"],
extractCSS: { allChunks: true },
}
Production environments do not see pwa downloads，How to configure？


Invalid Parameter Fix for Asymmetrik/node-fhir-server-mongo #28

String, reference, uri, and token all use the same case for parseValue and validateType, as they are all strings.

Looks good, thanks

Looks like when I merged in Jon's changes he may have already added a case for reference which caused an error with our linter, I'll push a fix.


Unable to add layer

Been trying to test this but it keeps failing with the following error when I try and attach the layer
not authorized to perform: lambda:GetLayerVersion on resource: arn:aws:lambda:eu-west-3:297975325230:layer:opentelemetry-lambda-extension:8
I am using an administrator account with "full access" but it still fails.
Also tried it via the UI and get the same message "You are not authorized to perform: lambda:GetLayerVersion."
Looks like we are not able to query the version of the layer

Can second seeing this behavior.

Hey @geoffhigginbottom, can you try again from one of the 4 regions the layer has been published to and see if it works?
https://github.com/open-telemetry/opentelemetry-lambda/blob/bb143b170e756b922bc0d6788bce6f491c823a00/Makefile#L2

Thanks @jordanpurinton but you can only attach a layer from the same region, and I am running in Europe - is there a way to get this published into EU Region please
I get error message "This value must be a valid layer version ARN and in the same region as your function."

This is also something we require. I get the same not authorized error. My lambda is in eu-west-1. Seems the error message is misleading as this is a region conflict rather than permissions.

Also get the same error when using this lambda layer arn:
arn:aws:lambda:us-east-2:297975325230:layer:opentelemetry-lambda-extension:8

Hi @geoffhigginbotto , Can you please confirm if you are still facing this error. I would like to provide more information/contriute to address this issue.


Fixup labels usage

Code should not be assuming labels.Labels is a slice, because at some point that could change.

Shouldn't these changes be done in the upstream Prometheus and then get vendored here? 🤔

These are changes to code that doesn't exist upstream, e.g. to do with sharding.

Aha! I didn't realize from a quick look. LGTM :)

CI is timing out queries again - #407 should fix.

Rebased and added a few more fixes for code added since January.


Github action build-push-linux fails after merging PR

Github action build-push-linux fails. The details as the below:
Run .github/workflows/chartmuseum.sh nightly
  .github/workflows/chartmuseum.sh nightly
  shell: /usr/bin/bash -e {0}
  env:
    CARGO_TERM_COLOR: always
    RUSTC_WRAPPER: /home/runner/.cargo/bin/sccache
    CARGO_INCREMENTAL: 0
    CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE: /home/runner/work/pyrsia/pyrsia/gha-creds-29e732e548437f23.json
    GOOGLE_APPLICATION_CREDENTIALS: /home/runner/work/pyrsia/pyrsia/gha-creds-29e732e548437f23.json
    GOOGLE_GHA_CREDS_PATH: /home/runner/work/pyrsia/pyrsia/gha-creds-29e732e548437f23.json
    CLOUDSDK_CORE_PROJECT: pyrsia-sandbox
    CLOUDSDK_PROJECT: pyrsia-sandbox
    GCLOUD_PROJECT: pyrsia-sandbox
    GCP_PROJECT: pyrsia-sandbox
    GOOGLE_CLOUD_PROJECT: pyrsia-sandbox
    CLOUDSDK_METRICS_ENVIRONMENT: github-actions-setup-gcloud
AccessDeniedException: 403<EMAIL_ADDRESS>does not have storage.objects.list access to the Google Cloud Storage bucket.
Error: Process completed with exit code 1.

Related logs: https://github.com/pyrsia/pyrsia/runs/8147023845?check_suite_focus=true
https://github.com/pyrsia/pyrsia/runs/8158778519?check_suite_focus=true#step:16:19

@fishseabowl  - I added permissions to the storage bucket for<EMAIL_ADDRESS> I will watch the actions for the next merge to see if the error is resolved.


Get rid of member_overload

@tcw165 , what do you think about this approach?

Looks like way with #include brokes doxygen. Way with macros also is really non-readable. Probably best way is to move declarations back to the base class...


461814 is double in the list above

461814 .NET Framework 4.7.2 installed on Windows 10 Fall Creators Update and earlier OS versions
461814 .NET Framework 4.7.2 installed on Windows 10 October 2018 Update

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2115da38-e95e-46fc-1e2d-da88ef92c6cf
Version Independent ID: a3790e8a-0654-851b-c991-ab7382025406
Content: How to: Determine which .NET Framework versions are installed
Content Source: docs/framework/migration-guide/how-to-determine-which-versions-are-installed.md
Product: dotnet-framework
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Thank you for letting us know. We'll take care of this shortly.

Thanks for pointing this out, @iwangoll. The information is actually correct. It made a great deal of sense when we first published it, but now, with the passage of a few months, I was no less convinced than you that it is erroneous. I'll open a pull request shortly that tries to make the release key values for .NET Framework 4.7.2 clearer.

This was addressed in #9557,


android version

Hi, could you provide an android version of this, with an example of injection of custom java code? thanks

It's available here:
https://github.com/oleavr/android-inject-custom


🐱 ADD - Secrets to operator and tidy up docs 🐱

What is this PR About?
🐱 ADD - Secrets to operator and tidy up docs 🐱
How do we test this?
Follow the readme?
cc: @redhat-cop/day-in-the-life

/approve
/lgtm


Not sure where to ask - Any oppertunity for CC grabbing from chrome/other browsers

Not sure if its even possible any more, but this grabber is one of the best free ones ive found

Thanks for the compliment!
CC grabbing from browsers was a feature long ago but it was basically useless, since browsers do not store CVV.


NEI buttons overlap with FTBUtilities

NEI: 1.10.2-<IP_ADDRESS>
FTBUtilities: 1.10.2-<IP_ADDRESS>

then disable one in the configs there is not really much that can be done with this


Notes on getting to work with PHP 7 / 8

So some of the lib versions required by this package is not compatible with php 7 or 8
the current requirements are
    "inacho/php-credit-card-validator": "^1.0",
    "sabre/xml": "^1.5",
    "guzzlehttp/guzzle": "^6.3"

sabre needs 3.0
guzzle im not sure, but my cms already had 7.4.5
inacho has not been updated so you have to manually edit the files, or try a fork
so:
composer require "guzzlehttp/guzzle:7.4.5 as 6.3"
composer require "sabre/xml:3.0 as 1.5"
composer require "mitchdav/st-george-ipg"
then i manually update inacho lib like so:
https://github.com/inacho/php-credit-card-validator/pull/28/files

to use a fork i think you could try https://github.com/jeebon/php-credit-card-validator/tree/master
with something like this:
"repositories": [
{
"type": "vcs",
"url": "https://github.com/jeebon/php-credit-card-validator.git"
}
],
"require": {
"inacho/php-credit-card-validator": "dev-master"
}

Hi Hayden,
I haven't worked with St. George IPG in many years now, so I am closing off this and any other issues, and archiving this repository now as it is not supported.
Please maintain your own fork if you are still using the project.
Thanks.
Mitch


Update the Get an access token with Graph permissions.

Please update the Get an access token with Graph permissions link to following link.
https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/tab-sso-graph-api?tabs=dotnet#acquire-access-token-for-ms-graph

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 52cb5b2e-e1e9-1993-04a0-6925d1453f20
Version Independent ID: 52cb5b2e-e1e9-1993-04a0-6925d1453f20
Content: Register your tab app with Azure AD - Teams
Content Source: msteams-platform/tabs/how-to/authentication/tab-sso-register-aad.md
Service: msteams
GitHub Login: @surbhigupta
Microsoft Alias: surbhigupta

@surbhigupta12 - Could you please help here to update the Get an access token with Graph permissions link to following link.
https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/authentication/tab-sso-graph-api?tabs=dotnet#acquire-access-token-for-ms-graph.


"Max All" IDs causes pow to be set to 0

this is due to the maxAllID function manually setting the power level and passing an array into pow(), causing it to return 0

oof


chore: bump go version to 1.21

Description

How has this been tested?

Checklist

[ ] changelog was updated with notable changes
[ ] documentation was updated

/e2e

End to end tests: :hourglass_flowing_sand: STARTING

/e2e

End to end tests: :hourglass_flowing_sand: STARTING


karmor: 1.2.1 -> 1.2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/kubearmor/kubearmor-client/releases.
meta.description for karmor is: A client tool to help manage KubeArmor
meta.homepage for karmor is: https://kubearmor.io
meta.changelog for karmor is: https://github.com/kubearmor/kubearmor-client/releases/v1.2.2
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.2.2 with grep in /nix/store/6rg4qq4ivyqavmpdfgfss6a6zl1wvvm2-karmor-1.2.2
found 1.2.2 in filename of file in /nix/store/6rg4qq4ivyqavmpdfgfss6a6zl1wvvm2-karmor-1.2.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

karmor

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6rg4qq4ivyqavmpdfgfss6a6zl1wvvm2-karmor-1.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A karmor https://github.com/r-ryantm/nixpkgs/archive/df5fd51cee66018a09f17c638f4db2c3946304c1.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/df5fd51cee66018a09f17c638f4db2c3946304c1#karmor

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6rg4qq4ivyqavmpdfgfss6a6zl1wvvm2-karmor-1.2.2
ls -la /nix/store/6rg4qq4ivyqavmpdfgfss6a6zl1wvvm2-karmor-1.2.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

karmor

Maintainer pings
cc @urandom2 @kashw2 for testing.

@NixOS/nixpkgs-merge-bot merge


Consider conforming to Sequence

Sequence would let one iterate over the heap like an array.
Consider doing this. To allow multiple iterations one could implement a copy() method.

PR #2 adds this feature. A copy() method was not necessary as the makeIterator() and HeapIterator already use a copy of the Heap.


ROX-22924: Make operator-e2e failure tickets more granular

Description
Incorporates the following changes to make kuttl report per-step failures, and junit2jira to be able to ingest them and create more finer-grained tickets:

https://github.com/stackrox/junit2jira/pull/23
https://github.com/kudobuilder/kuttl/pull/509

Checklist

[ ] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~
[x] ~Evaluated and added CHANGELOG entry if required~
[x] ~Determined and documented upgrade steps~
[x] ~Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

Testing Performed
Here I tell how I validated my change

[x] Ran operator e2e tests manually to provoke a JUnit report with a failure, and then ran junit2jira in dry-run mode on the output and verified that the printed messages looked as expected.
[x] https://github.com/stackrox/stackrox/pull/10371 created https://issues.redhat.com/browse/RS-642 and https://issues.redhat.com/browse/RS-643 and updated the latter as expected

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

/retest

/retest


Update contact details in the Contribute section of the Data Portal.

The email address should be changed from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>in the Contribute section of the Data Portal:

in Contributing Data (2 instances, bottom of page): https://data.humancellatlas.org/contribute#data-submission-process
in Contributing Data - Data Suitability (one instance, bottom of page): https://data.humancellatlas.org/contribute/contributing-data-suitability#organism
in Contributing Data - Data Submission Process (one instance, bottom of page): https://data.humancellatlas.org/contribute/contributing-expect-prepare#data-submission-process

Hi @zperova  the changes above have been made and are on prod.
Can you take a look and close if this looks ok?
Thanks!
Dave

Thanks @NoopDog ! closing as finished.


Provide axon-bom

With all the different fine-granular framework packages, it's a good idea to have a BOM (maven pom listing all the parts in the correct version), so we can just import the BOM once and leave out the specific version definitions for the sub-packages.
Idea: axon-bom on axonFramework repo  top level

Just noticed this is a duplicate of #1200, hence I'll close this one.


[Build/PackageLoading] SR-13084: Improve user awareness for issues around missing resources

Follow up from https://github.com/apple/swift-package-manager/pull/2810 (GitHub wasn't letting me update the base branch the PR was targeting)
This addresses SR-13084.
In looking to use the new resources capability of SPM I faced some confusion when my setup wasn't working - it turned out to be that my paths were relative to the Package.swift rather than to the target. There was no warning/error and so wasn't the easiest to debug -- this MR aims to resolve this in two parts:

Currently the Bundle.module accessor is only created if at least one valid resource is generated in the bundle. A change in this MR means that the accessor is always created but is marked unavailable (with a user friendly message) if there are no valid resources.

A warning is raised as part of the package description diagnostics which lists the exact resources which were seen as missing. A warning has been chosen to act as a non-breaking change (though an error may be more appropriate)

The messages may need more finessing to make more sense - open to suggestions.
First attempt at trying to contribute to SPM so hopefully this isn't horrendous!
Thank you 🙌

Just wanted to let you know that I haven't yet had a chance to take a look, but plan to do so this week.

Hmm, it looks like the AbsolutePath.contains() is completely wrong:```
/// Returns true if the path contains the given path.
///
/// This method is strictly syntactic and does not access the file system
/// in any way.
public func contains(_ other: AbsolutePath) -> Bool {
return self.components.starts(with: other.components)
}

If `/a/b` contains `/a/b/c/d` then `other` starts with `self`, not the other way around.  Hard to imagine there wouldn't be a unit test for that, but I'll take a look.  That would certainly affect any other clients as well.

Actually, I suppose this comes down to what "contains" means.  The implementation says that "contains" means "starts with", meaning that the passed-in path should be the ancestor of the receiver.  If we think of "contains" in a file system hierarchy manner, it would be the opposite:  "/Users" contains "/Users/me", for examine, if the "Users" directory contains a "me" directory.  This would probably be better if it used a term that was less ambiguous, e.g. isDescendant(of:).

Probably the thing to do in this case is to use AbsolutePath.contains() with the current semantics, which is not to check whether one path logically contains another but rather to see it as a "starts-with" operation, and swap the two method arguments.

Aye that's really interesting - thanks for the explanation on that Anders! I made a bit of an assumption there on what the contains method was doing.
I've run the tests on with the recent changes and all are passing with the exception of testWASITarget which is giving me the following error:
caught error: "Error Domain=NSCocoaErrorDomain Code=642 "You can’t save the file “DerivedSources” because the volume is read only." UserInfo={NSFilePath=/path/to/build/debug/PkgPackageTests.build/DerivedSources, NSUnderlyingError=0x100c16af0 {Error Domain=NSPOSIXErrorDomain Code=30 "Read-only file system"}}"

I don't believe this is related but please let me know if I've made a mistake there!
I really appreciate the help 😄  Thanks

Thanks, @Sherlouk!  Yes, I think that error is unrelated, but will check to be sure.  The method name is confusing and we should certainly do something about it at some point, but adjusting to established semantics is right in this case.  I'll open a bug report on it.

@swift-ci please smoke test

The new failures are different but look no more relevant than the previous ones... looking.

Looks similar to some of the test failures that were fixed by another PR.  Trying again.

@swift-ci please smoke test

I've reproduce the test failures locally, and I think I see what's going on.  Some of the unit tests check that if there are two independent targets in a package, for example, and only one of them is built, then the other one doesn't actually build anything.  This is checked by seeing if there are intermediate build directories.  With this PR, there is a generated resource accessor for each of those targets that just emits an error.  Arguably that should only be created if the target is going to be actually built — I'd rather not change the unit tests to be OK with having intermediates created for targets that aren't built.  I'm not familiar with the code here so will have to check to see where to put that generation logic so that it only happens for targets that are going to be built.

Interesting that I've not been able to get this test locally - which scheme and test exactly are you running? Would love to experiment some more if nothing but to learn!
Thanks for taking a look!

Hi @Sherlouk.  After applying the diffs in this PR to my local checkout, I just opened SwiftPM in Xcode 12 and built the "SwiftPM-Package" scheme using Comnand-U (Product > Test).  But you should be able to see the same thing using swift test.
I haven't yet had a chance to take a look at where to suggest moving the code to so that it only runs for the targets that need it, but I think that will be the solution.

Apologies @Sherlouk, this one got a bit lost amid the activity on the other PRs.  I will take another look at this today and see if I can advise on an adjustment that will make this work while only running the code when needed.  This would be a very valuable change!

Apologies @Sherlouk, this one got a bit lost amid the activity on the other PRs.  I will take another look at this today and see if I can advise on an adjustment that will make this work while only running the code when needed.  This would be a very valuable change!

I've looked into this some more, and based on the current structure of the build plan, I'm wondering if we're going to have to live with having the .build directories for each of the targets get created after all.  There is value in having the tests check that only the right targets got built, so we'd either have to generate the source files somewhere else, or modify the tests so that they only check for the absence of built artifacts and not generated source.
Ideally we'd want to generate the source when it's needed, but that would require some restructuring of BuildPlan so that the source is generated as part of a command, and that is beyond the scope of this PR, I think.  I'll take a closer look at how to modify the tests.

I've looked into this some more, and based on the current structure of the build plan, I'm wondering if we're going to have to live with having the .build directories for each of the targets get created after all.  There is value in having the tests check that only the right targets got built, so we'd either have to generate the source files somewhere else, or modify the tests so that they only check for the absence of built artifacts and not generated source.
Ideally we'd want to generate the source when it's needed, but that would require some restructuring of BuildPlan so that the source is generated as part of a command, and that is beyond the scope of this PR, I think.  I'll take a closer look at how to modify the tests.

Thanks for the PR @Sherlouk and sorry for the delay on this. Would you mind resolving the conflicts, then we can re-run CI and get this merged.

Have done a rebase and the changes look sensible, but struggling to build and test locally due to Xcode failing to resolve dependencies on the project.

Dependencies could not be resolved because root depends on 'swift-argument-parser' 0.4.3..<0.5.0 and root depends on 'swift-argument-parser' 0.3.1..<0.4.0.

Investigating.

You might just need to "Update to Latest Package Versions"

Updating packages was successful.
However, when running tests it highlights that new diagnostics have been added under Pull3294 which mostly resolves the need for these changes.
Closing, no longer required. Thanks for your help!


RainAlarm App by mdiener shows distorted gmap after screen rotate

Hi
This is a Problem i believe being present since a long time ago. Normally I habe my screen locked to portrait for most apps. Today I enabled auto rotate in Android and hold it so it goes to landscape. So I just noticed the probably old Problem.
Then it looks like this: https://postimg.org/image/ez9lxqvzr/
Link to App: https://play.google.com/store/apps/details?id=de.mdiener.rain.usa
System : cm13 nightly 20160529, LG G4-H815 mobile, MicroG 0.2.3-1 GmsCore, Xposed FakeGApps

vtm, the library we use to render the map unfortunately was discontinued. It still has quiet some number of annoying bugs, especially when the map view is recreated (which happens on rotation), the map contains a lot of elements or when multiple map views are visible at the same time. I am not very deep into OpenGL 3d programming and can't do a lot on that.
The designated successor is tangram or its wrapper mapzen-android-sdk, however it still lacks a lot of features, most importantly proper markup (markers/lines/etc) support. Until that, I think it's the best to just keep what we have. Rendering problems are very unfortunate, but often it's possible to "fix" them by restarting the app.

The mapzen android SDK claims support for polylines and markers on https://github.com/mapzen/android (docs added on Apr 21 2016)

@lambdaupb yes, but no support of coloring, input listeners etc. It's currently only drawing a line on the map.


How to perform parallel testing in Protractor on Mobile devices

How to perform parallel testing in Protractor on Mobile devices -
Hi Team,
Currently I am using appium to execute my protractor tests in android device. I am not sure how to execute multiple instances in mobile devices. Can someone help me on that

Hi there!
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Also see http://www.protractortest.org/#/mobile-setup


ui gird : auto-resize breaks with ui-selection

ui-grid-auto-resize breaks when ui-grid-selection directive is added
plunker

OK, I don't see what's broken about it.  Could you provide a bit more detail about what you expect it to do and what it's doing?

when you re-size of the container the grid some times moves up and down for a split mill-second before coming back in  place .This does not happens if you dont use  ui-grid-selection

This is probably happening because the row header is increasing the the width beyond the available canvas when it resizes to a smaller size, and that's causing the grid to wrap.

I think this is a flavour of #3031, and somewhat of #3125, #2997, #1957


how to build for ios?

Can you be a bit more specific about what you would like to build on IOS?

Please feel free to re-open with more info.


autoSizeColumns only works with ColDef.field, not with ColDef

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid/blob/master/CONTRIBUTING.md#question

Current behavior
Calling gridOptions.columnApi.autoSizeColumns(allColumns); only works when allColumns is an array of ColDef.field values, meaning strings which are the field values of their respective column definitions.
However, at least the TypeScript typedefinition tells that one can also use an array of ColDef's. However, this does not seem to work as the columns are not being resized anymore. There is also no JavaScript runtime error being thrown.
Expected behavior
Column resizing should also work with an array of ColDef being input as the argument to the gridOptions.columnApi.autoSizeColumns() method.
Minimal reproduction of the problem with instructions
I used the following code (as illustrated by the ag-Grid examples) to resize the columns:
      onGridReady: () => {
        const allColumnIds = [];
        this.gridOptions.columnDefs.forEach((columnDef) => {
            allColumnIds.push(<ColDef>columnDef);
        });
        this.gridOptions.columnApi.autoSizeColumns(allColumnIds);
      },

This will not resize the columns.
What is the motivation / use case for changing the behavior?
Being able to automatically resize the columns even when they do not have a field attribute value, such as with computed properties via the valueGetter property.
Please tell us about your environment:
Windows 7 x64, Node 7.8.0, npm 4.5.0, Angular 4.0.1

ag-Grid version: 9.0.0

Browser:
Chrome 57.0.2987.133 (64-bit)

Language: [all | TypeScript X.X | ES6/7 | ES5]
TypeScript 2.2.2

Hi
Thanks for reporting this - I've raised issue AG-395 our side to track this. We'll update this thread with updates as soon as we can.
thanks

the method should take an array of col id's. these are strings.
see the docs on id's
https://www.ag-grid.com/javascript-grid-column-definitions/
do not pass in col defs.

the method should take an array of col id's. these are strings.

I know that. Please carefully read the initial post:

However, at least the TypeScript typedefinition tells that one can also use an array of ColDef's. However, this does not seem to work as the columns are not being resized anymore.

yes, the colDef is in there. that's historic. we will be removing that soon because of this issue. however the solution for your application is to use the id's.
the codDef's used to work, as the column contained a reference to the original colDef, however since we implemented defaultColDef (it's a grid option), the colDef is now merge of both the default and the actual, thus it's a new colDef that the column contains. so comparing by colDef reference doesnt' work anymore.
sorry for the confusion.

internally we have renamed our jira
AG-395 drop colDef from the colKey

Thank you!