Port to .NET Core

I ran dotnet-apiport against the project and it seems like it's pretty compatible 😄
https://1drv.ms/x/s!ArqMTZb-afYkgQh9voOZzGCd7NKh
https://docs.microsoft.com/en-us/dotnet/core/porting/
Porting to .NET Core would make Sharpmake cross-platform just like CMake is and possibly increase performance too.
The first step would be to convert project files to the new format.
If I wanted to submit a PR, I should work on dev branch is that right?
EDIT: I already ported the project to the newer csproj format which greatly simplifies things  but then I've noticed it's using itself now to generate project (https://github.com/ubisoftinc/Sharpmake/commit/74c8af9e2057657bc0600a257d726e89f36958cd )
which complicates things a bit... so either:

revert this commit and use new csproj format
write generator for new csproj format (does it make sense anyway?)

then another cool thing would be to make use of dotnet tool to install sharpmake easily without building it yourself.

I opened a pull request that makes it so we can at least generate .NET Core projects (#63). Next I'm going to see if I can use that change to bootstrap Sharpmake into .NET Core and build natively in WSL.

Does it even make sense to use a project generator for C# projects?
People are using only one format anyway on Mac and Linux too (https://stackoverflow.com/a/6604782/2828480). In my opinion, it makes sense only for C++ projects as there are multiple formats.
Because of that I would remove C# support completely and focus on C/C++ projects only.

I think the biggest limitation in porting Sharpmake to .NET Core is Microsoft.VisualStudio.Setup.Configuration.Interop package for locating visual studio instances - it's .NET Framework only. The best workaround would be to port this package to .NET Core or use registry to find VS instances - CMake does it similarly.

Yeah, that's going to be a challenge. I'm thinking I should be able to move that code into a separate dll that only gets built/imported on windows.
And it absolutely makes sense to generate c# projects. It's not so much about an individual file's format, it's more about enabling a lot of flexibility and freedom in overall project structure. Moving code around, generating multiple projects, complex inter-dependencies are very complex problems that sharpmake helps to trivialize.
The example about the VisualStudio setup dependency is a great example. Sharpmake scripts would allow me to add a platform specific IDE interop layer that only gets added to the solution for that platform.

New csproj format can be used for both frameworks. You can still move code around as it implicitly compiles all the .cs files in a directory.
I think it's more convenient than sharpmake for c# projects - it just works cross-platform and no additional generation step is needed. And it looks like .NET framework will become obsolete soon or already is (https://github.com/dotnet/core/blob/master/roadmap.md). That being said, MSBuild is more than enough for c#/f#.
You can still multi-target but ideally .NET Core should be used even when targeting Windows.
<PropertyGroup>
  <TargetFrameworks>netcoreapp2.2;net462</TargetFrameworks>
</PropertyGroup>

Also, take a look at https://blog.magnusmontin.net/2018/11/05/platform-conditional-compilation-in-net-core/ for a nice solution to do platform conditional compilation

I now have Sharpmake fully ported to .net core, including boostrapping and running on linux. I'm getting a friend to test it out on Mac soon. Going to wait for main devs to respond and get some feedback before doing a full PR for this. I also still have to test debug solution generation.
https://github.com/kudaba/Sharpmake
One thing that I noticed is a bit odd about working in .net core is that development builds are actually .dll files and not .exe files. To get proper functioning .exe to distribute you have to 'publish' which is quite a bit slower build.

This is pretty neat! I'll try to test it out :)

regarding dll files and not exe files: https://github.com/dotnet/cli/issues/6237#issuecomment-511001872

Is this still on the roadmap?

Hello! Yes, it'll happen eventually, but because of the split between reference and runtime assemblies that was introduced with net core it has proven difficult to get it to work reliably.


ModuleNotFoundError: No module named resources.protection

tried to run the executable on a test computer (not vm my old computer) and this message showed up, how do you fix this error?

tried to run the executable on a test computer (not vm my old computer) and this message showed up, how do you fix this error?

Did you try to remove Anti-VM protection? If so, retrieve it back and rebuild with debug mode turned on.

tried to run the executable on a test computer (not vm my old computer) and this message showed up, how do you fix this error?

Did you try to remove Anti-VM protection? If so, retrieve it back and rebuild with debug mode turned on.

Ill try, thank you for replying!

tried to run the executable on a test computer (not vm my old computer) and this message showed up, how do you fix this error?

Did you try to remove Anti-VM protection? If so, retrieve it back and rebuild with debug mode turned on.

Once ran the executable, it logged "Logging in the static token" or whatever but the bot is unresponsive, how do I fix it?

Is it a great time to also mention that my ipad is using a VPN to be at america but the computer im using is still in china with no vpn

Hey, just use the ModdedPysilon version, it covers every bug and it make sure your discord account never get banned.
Leave me a star if you like my project ;)


{{ file.id }} not including token in email

The {{ file.id }} variable is not working.  I have added the variable to the email message text, but it is not including anything.
My template:

			{{ email.from }} wants to share file(s).

			Message:

			{{ email.body }}

			Your document token:

			{{ file.id }}

			Your files can be downloaded by clicking on the link below:

I have the same problem. The template just does not change
I've tried changing my template as follows but it has no effect. I am using docker.

Hi,

			{{ email.from }} wants to share file(s).

		{% if message %}

			{{ message }}

			Token is: {{ file.id }}

		{% endif %}

			{% for file in files %}

{{ file.name }} ({{ file.size }})

			{% endfor %}

			You can download each file individually by clicking on the file name.
			It is also possible to download a collection of all files.

Powered by youtransfer.io


@types/next-nprogress is required

Hi~ 👋
Thank you for your wonderful library.
I'd like to use it in _app.tsx, but it throws an error says @types/next-nprogress is required or add *.d.ts containing declare module next-nprogress. I tried to yarn add @types/next-nprogress -D, but failed not found.
any solution?

Hi! I don't use typescript and I'm pretty sure there is no community made for definitions for this module. So I'm afraid you are on your own defining them.
If you get it working you could publish them to help other people in the future 🙏

For posterity, I recently added definitions for this project to the DefinitelyTyped repo, so installing them should work fine now. http://npmjs.com/@types/next-nprogress


bump netty to 4.1.45.Final

Type of change

Enhancement / new feature

Description
Bump Netty to 4.1.45.
Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=isolated

:x: Test Summary :x:
TEST_PROFILE: isolated
TEST_CASE:
TOTAL: 98
PASS: 90
FAIL: 2
SKIP: 6
BUILD_NUMBER: 217
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testSendThroughConnector1 in io.enmasse.systemtest.isolated.bridging.ConnectorsTest
testSendThroughConnector2 in io.enmasse.systemtest.isolated.bridging.ConnectorsTest


Is it possible to add support for reading/writing Atari 8 bit disks?

Is it possible to add support for reading/writing Atari 8 bit disks?
i.e. ones from the the Atari 400/800 written with 810/1050 drives?

Yes ATR image support is planned. Is that the main format you want supported?

I also would like to archive my Atari stuff. For Verifikation converting to ATR would be great. For copy protected disks ATX would be afaik better.

Great! Yes, I want to archive some of my old personal Atari disks, so ATRs is all I would need. Thanks

Hello,
Is there any news about support for the Atari ATR format for Atari 8 bit computers?
I would also be very interested in implementing it.
By the way, I think the Greaseweasel adapter is great. I already use it on the Amiga... and yes, I know that you can also create Atari disks with the sio2pc and a 1050 floppy, but the support in Greaseweasel would still be great.
greetings, Alex


XmlDoc snippet is not automatically generated by typing triple forward slashes anymore

Steps to reproduce

Make sure the extension is enabled and fully loaded
Open a .cs file with a member, a method or a class that lacks documentation
Type /// over it

Expected  behavior
An XmlDoc snippet should be generated, including the summary tag and also param and exception tag for methods if any.
Actual behavior
Nothing is generated, only the /// I typed.
Additional context
This feature used to work in earlier versions but I don's exactly know which update broke it.
Environment data
dotnet --info output:
.NET SDK:
 Version:           8.0.101
 Commit:            6eceda187b
 Workload version:  8.0.100-manifests.8a1da915

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22621
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.101\

.NET workloads installed:
 Workload version: 8.0.100-manifests.8a1da915
 [maui-windows]
   Installation Source: VS 17.8.34408.163
   Manifest Version:    8.0.3/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maui\8.0.3\WorkloadManifest.json
   Install Type:              Msi

Host:
  Version:      8.0.1
  Architecture: x64
  Commit:       bf5e279d92

.NET SDKs installed:
  8.0.101 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.26 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 7.0.15 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.1 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

VS Code version:
Version: 1.85.1
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:49:37.021Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

C# Extension version
v2.15.30

Possibly related to #7184 ??

I forgot to reply to this issue so I may be wrong since it was a long time ago, but I think this was a problem because I was using Omnisharp (Setting dotnet.server.useOmnisharp was enabled) at the time.
If you're using omnisharp, you need another extension (k--kato.docomment) enabled to put the docs for you.
If you're not using omnisharp, having that extension will generate double xml-doc comments when you type /// so if you're not using omnisharp, you gotta disable it and let the C# extension handle xml-doc comments for you.


Make it easier to inspect source-code of a LambdifiedFunction

The lambdified function that is contained in LambdifiedFunction is 'hidden' by a dunder:
https://github.com/ComPWA/tensorwaves/blob/942f4b5b04f7e2c1d58b0ef09ba152e136e4db48/src/tensorwaves/model.py#L278
This makes it almost impossible to get the lambdified function or inspect the source code of that lambdified function. Note that simply making this attribute public does not entirely solve the problem: the lambdified function can be constructed by optimized_lambdified, meaning that it is still not possible to inspect the lambdified function even if you have access to this attribute.
See also #322

I would suggest to make this (and the others) simply normal private attributes. Name mangling is usually just needed if there is a potential for naming conflicts, which I think is not given here?
Or, out of curiosity, why was this even been put to leading dunder?

I would ask the other way around: what's wrong with using a dunder by default? I think its quite similar to c++ private and protected. There you have the same ideal, to use private unless you really need protected or public. So my logic would be the same here, unless you need access to the variable make it a dunder.
So far I don't have any argument why using dunders by default is a bad thing.

I would ask the other way around: what's wrong with using a dunder by default? I think its quite similar to c++ private and protected.

Besides the Python convention, from a software design perspective: why private and not protected? If I would like to inherit from the class, should I not be able to access exactly these attributes? Like should not every LambdifiedFunction(in the OOP "is-a" sense) have this lambdified function accessible?
AFAIU, a single leading underscore is considered "private/protected", while a dunder is "just" to avoid collisions. So if you wanna do some real heavy magic or if the attribute is likely to collide with another attribute, that's a good use-case for dunder.

There you have the same ideal, to use private unless you really need protected or public.

Python goes here more the path of "we're all adults here". There is no need to be over-protective with things, but rather about "communicating an intention". If anyone touches a private (_) attribute, the convention is clear: that is not guaranteed to be stable and may break anytime. We all know that. Making something __ just makes sure that the attribute is not accessed by accident. Because all attributes can be accessed anyways. So using a dunder here conveis I think the wrong message:
From another developers perspective, I would find it rather confusing that an "obvious" attribute such as the lambdified function is "so protected". Is there a lot of magic going on that will break everything if touched? Same for the parameters: this is just the usual private attribute, saying: "please use the public accessor", so why is that mangled?
I would say: single underscore means private, implementation detail. May changes. Don't rely on it. Dunder means, don't touch because you cannot understand this attribute, like really (or it is likely to collide). Looking at codebases, this seems also like it's handled in general. But I agree that it leaves a bit of unease sometimes as to the missing strictness of what is what.
We had in the Python for HEP group at some point a long discussion about how to convey the message to a user that he is allowed to overwrite an "internal" method, which somewhat also came from this missing distinction of private/protected. The solution was that a) either state that an "unstable" method (leading underscore) is actually stable or use (a "yet" quite unknown "convention") _method_(...).

Well I know that in all "non adult" programming languages, protected should only be used if absolutely needed, or if the designer knows what he is doing. The problem being that a protected variable is accessible by the whole inheritance tree, which is a nightmare for making sure some variable only changes through some specific way. So it just leads to more bad code. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-protected
I know python is never truly safe and this mechanism was created to avoid name collisions, but I still would try to make it as hard as possible for a developer to screw something up. Basically this tells us that the current design might have a flaw and it should be reconsidered.
Now regarding this specific issue, I don't really understand what the use case of inspecting the lambdified function is. Looks more like for debugging purposes. @redeboer can you elaborate why this is needed, or what you ultimately want to do?

Just some thoughts while reading through: so far, inheritance in TensorWaves was only used for defining (abstract) interfaces. This is done on purpose: no code sharing through inheritance, even if that seems convenient. In that sense, the dunder was never to avoid name conflicts (there are no shared attributes), but to hide implementation, discourage further inheritance, and signal that the derived classes only fulfil the contract that their interface base class prescribes.

Now regarding this specific issue, I don't really understand what the use case of inspecting the lambdified function is. Looks more like for debugging purposes. @redeboer can you elaborate why this is needed, or what you ultimately want to do?

Yes, you are correct that it is mostly for debugging. I just wanted to call inspect.getsource on the lambdified function inside. You then face two problems: (1) that the __lambdified_model is hard to access (leading to the discussion above ;)) and (2) that the __lambdified_model can be a function that calls (inaccessible) inline functions. But indeed, the general issue here is that it would be nice to have some mechanism that allows you to inspect the source code of the lambdified function (whether it's one function, or a function that calls other lambdified functions).

Sure, absolutely agree! And while I like the Python philosophy, it requires a lot of awareness and assumes that everyone understands the "rules", not sure that this requirement is always satisfied in scientific code... :P

...as hard as possible for a developer to screw something up.

I think this is where the Python philosophy (and the "adult" thing) differs from others: there is no need to make it hard. It is already clear that underscore should not be used: the difference between a "do not enter" sign and a locked door.
I agree on debugging as the most prominent use-case (I also had this with the model, I remember, and accessing/hacking around internals was difficult). To add, it's also very useful for testing: tests can be even more specific and test the internals properly.

But if one is interested in the lambdified expression it can be generated by model.lambdify(backend=backend) right?

That's right, but in that case, there is the second problem: it returns a callable with inline functions. May be fixed through #322.


Crash after the logo using MRKT2.8 + Unity 2021LTS

Hello,
I am writing this in hope that somebody as an idea on what might be going on in our project.
We had a working 2019LTS project that was updated to 2021LTS with the latest mrtk2 version.
At the moment, we are able to run the app inside unity with the simulation input but in Hololens 2 it crashes right after showing the logo. Let's call this app, our "main" app.
For troubleshooting purposes, we also have a very simple app with exactly the same configurations that just writes some text in the screen. Let's call this app, our "simple" app.
The "simple" app runs just fine in Hololens 2.
The "main" app doesn't. We reached the point where we made sure that the "main" app startup scene is not running any code, and it still crashes.
The Error output we get is the following:
[MROpenXR][Info   ][17:33:05.257221][tid:798] XrViewConfigurationSettings_OnXrSessionCreated SupportedViewConfigType=XR_VIEW_CONFIGURATION_TYPE_PRIMARY_STEREO SupportedReprojectionModesCount=0 [MROpenXR][Info   ][17:33:05.257994][tid:798] XrViewConfigurationSettings_OnXrSessionCreated SupportedViewConfigType=XR_VIEW_CONFIGURATION_TYPE_SECONDARY_MONO_FIRST_PERSON_OBSERVER_MSFT SupportedReprojectionModesCount=0 [MROpenXR][Info   ][17:33:05.258357][tid:798] OnSessionCreated GraphicsAPI=XR_TYPE_GRAPHICS_BINDING_D3D11_KHR sessionCreationResult=XR_SUCCESS AppName= AppVersion= AppMode= openXRRuntimeName= openXRRuntimeVersion= APIVersion= PartA_PrivTags=33554432 [MROpenXR][Info   ][17:33:05.323155][tid:798] OpenXRContext_OnEvent_XrEventDataSessionStateChanged EventType=XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED session=2 sessionState=XR_SESSION_STATE_IDLE [MROpenXR][Info   ][17:33:05.324678][tid:798] OpenXRContext_OnEvent_XrEventDataSessionStateChanged EventType=XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED session=2 sessionState=XR_SESSION_STATE_READY [MROpenXR][Info   ][17:33:05.325254][tid:798] ViewConfigurationSettings_PrimaryStereoEnabled [MROpenXR][Info   ][17:33:05.325547][tid:798] ViewConfigurationSettings_OnSessionBegan_SecondaryBeginInfo EnabledSecondaryViewConfigurationCount=1 [MROpenXR][Info   ][17:33:05.325935][tid:798] ViewConfigurationSettings_OnSessionBegan_EnabledSecondaryViewConfiguration EnabledSecondaryViewConfiguration=XR_VIEW_CONFIGURATION_TYPE_SECONDARY_MONO_FIRST_PERSON_OBSERVER_MSFT [MROpenXR][Info   ][17:33:05.326374][tid:798] LocatableCameraProvider_Registered [MROpenXR][Info   ][17:33:05.350446][tid:798] SetSceneOriginSpace nativeToken=2 oldSpace=0 newSpace=3 [MROpenXR][Info   ][17:33:05.350937][tid:798] SetSceneOriginSpace nativeToken=1 oldSpace=0 newSpace=3 [MROpenXR][Info   ][17:33:05.351238][tid:798] SetSceneOriginSpace nativeToken=4 oldSpace=0 newSpace=3 [MROpenXR][Verbose][17:33:05.351693][tid:798] MicrosoftOpenXRPlugin_OnSubsystemsStarting NativeLibToken=HandTracking [MROpenXR][Info   ][17:33:05.352033][tid:798] InputProvider_LifecycleStart [MROpenXR][Verbose][17:33:05.352981][tid:798] MicrosoftOpenXRPlugin_OnSubsystemsStarting NativeLibToken=HoloLens [MROpenXR][Verbose][17:33:05.353643][tid:798] MicrosoftOpenXRPlugin_OnSubsystemsStarting NativeLibToken=Controller [MROpenXR][Info   ][17:33:06.671657][tid:798] OpenXRContext_OnEvent_XrEventDataSessionStateChanged EventType=XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED session=2 sessionState=XR_SESSION_STATE_SYNCHRONIZED [MROpenXR][Info   ][17:33:06.672446][tid:798] OpenXRContext_OnEvent_XrEventDataSessionStateChanged EventType=XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED session=2 sessionState=XR_SESSION_STATE_VISIBLE [MROpenXR][Info   ][17:33:06.672846][tid:798] OpenXRContext_OnEvent_XrEventDataSessionStateChanged EventType=XR_TYPE_EVENT_DATA_SESSION_STATE_CHANGED session=2 sessionState=XR_SESSION_STATE_FOCUSED onecore\base\windows.storage\src\win32proxy.cpp(339)\windows.storage.onecore.dll!00007FF8D790B080: (caller: 00007FF900445BD8) LogHr(2) tid(798) 80070005 Access is denied.     CallContext:[\FindFirstFileExProxyActivity]  Exception thrown at 0x00007FF8BC578D14 (GameAssembly.dll) in ASSIST.exe: 0xC0000005: Access violation reading location 0x00000000000000F4.
This seems to be somewhat related with "[MROpenXR]" but we're not sure what else we could check/troubleshoot to understand the source of this issue.

Hmm, nothing looks out of the ordinary in those logs as far as MROpenXR is concerned. Is FindFirstFileExProxyActivity something in your app? A quick search of MRTK, OpenXR, etc didn't surface anything for me.

@keveleigh We have no idea what "FindFirstFileExProxyActivity" might be, It's not ours, but it might be from some external dependency. We are trying to dig deeper into this.

We narrowed it down to external packages causing the issue (like we were suspecting).
We still don't know which package exactly was causing this but the app booted after removing the following at the same time:

com.unity.xr.management
com.unity.entities
com.microsoft.spatialaudio.spatializer.unity
com.unity.burst
com.unity.editorcoroutines
com.unity.ext.nunit
com.unity.mathematics
com.unity.render-pipelines.core
com.unity.render-pipelines.universal
com.unity.shadergraph
com.unity.xr.management

Since this issue is not happening anymore I think we can close it. Hopefully it'll be helpful to someone in the future.
Thank you

We eventually found out it was the "com.unity.entities" package that caused this.

Oh wow, I'm able to repro this as well. Have you filed a Unity bug and (if so) could post the bug number here? Thanks!

Hello.
I'm sorry, since we don't really needed the "com.unity.entities", we decided not to spend further time reporting the bug and creating a separate project where this could be reproduced, etc, etc.
We probably should as soon as we have the time, just in case.

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Prevent deploying to prod if any diff is found wrt openapi.json

travis finished, not sure why it is showing "in process":
https://travis-ci.org/github/RedHatInsights/policies-ui-frontend/jobs/696536439


ol.source.Source setProjection method

Hello,
Is it possible to set/modify propety "projection"_ of "ol.source.Source"?
No method is allowed like "setProjection".
Is there a reason?
Thank you

duplicated on Stackoverflow:
https://stackoverflow.com/questions/47529818/openlayers-set-modify-property-projection


Inconsistent Base URI Behavior in Load RDF

Describe the bug
When N3 RDF like
<> <http://id.loc.gov/ontologies/bibframe/mainTitle> "The Labyrinth Index"@en .
<> <http://sinopia.io/vocabulary/hasResourceTemplate> "resourceTemplate:bf2:WorkTitle" .
<> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Title> .

is pasted into the N3 RDF text area in the Load RDF tab, if the Base URI field is left blank the Editor tab loads correctly into the Editor Tab:

Trying to load the same RDF but this time using a relative uri of <> in the Base URI field, fails to load with a TypeError: this.match(...).toArray(...)[0] is undefined error.
The following RDF fails to load with or without a Base URI value being set:
<http://example.com/1> <http://id.loc.gov/ontologies/bibframe/mainTitle> "The Labyrinth Index"@en .
<http://example.com/1> <http://sinopia.io/vocabulary/hasResourceTemplate> "resourceTemplate:bf2:WorkTitle" .
<http://example.com/1> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Title> .

What environment are you in? Running locally with USE_FIXTURES=true
What OS and browser are you using? Mac/Firefox
If you're cataloging, what Resource Template were you using (name or ID) resourceTemplate:bf2:WorkTitle

For me, testing locally, if:
<> <http://id.loc.gov/ontologies/bibframe/mainTitle> "The Labyrinth Index"@en .
<> <http://sinopia.io/vocabulary/hasResourceTemplate> "resourceTemplate:bf2:WorkTitle" .
<> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Title> .

is loaded with a blank base URI (i.e., nothing entered in the field), then the resource loads.
If:
<http://example.com/1> <http://id.loc.gov/ontologies/bibframe/mainTitle> "The Labyrinth Index"@en .
<http://example.com/1> <http://sinopia.io/vocabulary/hasResourceTemplate> "resourceTemplate:bf2:WorkTitle" .
<http://example.com/1> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://id.loc.gov/ontologies/bibframe/Title> .

is loaded with http://example.com/1 as base URI, then the resource loads.
So I can't replicate the problem.
Now, there are definitely usability / error handling issues with this page (e.g., making it clear when to enter a base URI and what is a base URI) but perhaps that should be a separate ticket.

Closing for now


Runtime cgo crash when building with -race flag and running FindAllSubmatchIndex

First of all thanks for the amazing work you did here, this is a great improvement in performance 💪
The issue that I found is the following:
It looks like there is some kind of issue with using cgo while using data race detector of go.
The output that I got is the following:
fatal error: checkptr: pointer arithmetic result points to invalid allocation

goroutine 242 [running]:
runtime.throw({0x205ba86?, 0x1e06a80?})
	/usr/local/go/src/runtime/panic.go:1047 +0x40 fp=0xc000f5f770 sp=0xc000f5f740 pc=0x44e470
runtime.checkptrArithmetic(0xc000f5f848?, {0x0, 0x0, 0x0?})
	/usr/local/go/src/runtime/checkptr.go:69 +0xac fp=0xc000f5f7a0 sp=0xc000f5f770 pc=0x41b11c
github.com/wasilibs/go-re2/internal.matchFrom(...)
	/root/go/pkg/mod/github.com/wasilibs/go-re2@v1.4.0/internal/re2_tinygowasm.go:73
github.com/wasilibs/go-re2/internal.(*Regexp).findAllSubmatch(0xc00072bd10, {0x556f70?, 0x10001f8f8?}, 0xffffffffffffffff, 0xc000f5f970)
	/root/go/pkg/mod/github.com/wasilibs/go-re2@v1.4.0/internal/re2.go:485 +0x124 fp=0xc000f5f8d0 sp=0xc000f5f7a0 pc=0x15828e4
github.com/wasilibs/go-re2/internal.(*Regexp).FindAllSubmatchIndex(0xc00072bd10, {0xc0009e5400, 0x4e8, 0x500}, 0xc0009a8990?)
	/root/go/pkg/mod/github.com/wasilibs/go-re2@v1.4.0/internal/re2.go:415 +0x10c fp=0xc000f5f9d0 sp=0xc000f5f8d0 pc=0x1581a8c

then every other process on this pod started crashing as well...
this only happen when I run go build using both -tags re2_cgo and -race
Expected behaviour is the same as with out the race build flag, meaning running properly without crashing.
Please let me know if any other information is needed to investigate this issue, I will also do some investigating when I have the time, but wanted to let you know.
Thanks!

Thanks a lot for the report @himelbrand! This repo should have been running tests with -race all along and unfortunately missed it. I have created a PR to fix the issues with race detector, while enabling it in CI. Some of them did look like potential crashes in real-world so really good to have this in.

@anuraaga thanks a lot for the quick reply!
when will a new tag be released? so I could use the fixed version in my project?

@himelbrand I'd like to release one soon but currently am having trouble with the race detector on the Windows build
https://github.com/wasilibs/go-re2/blob/main/.github/workflows/ci.yaml#L71
I need some more time (and remembering to spend it when at a Windows machine...) to see if this is only a flake or indicative of an issue of some sort. Sorry for the delay

Hi @anuraaga,
I'm experiencing the same issue.
Do you have an update with an estimation for a fix?
Thanks!

Sorry for the huge delay - I still haven't been able to get machine time to investigate the windows issue but I think it's fine to release as it should still be better even if there may be a remaining issue on that OS. Thanks for the patience.

Thank you! appreciate it!


Run Rustfmt and Clippy via main CI workflow

@RazrFalcon I noticed this only while fixing the Clippy lints, but it seems like there is a discrepancy in the alignment computation for flush and flush_async and including flush_async in the flush_range test does indeed fail. Hence I aligned the alignment computations for both functions in the last commit which might be something to consider independently of the Rustfmt and Clippy changes.

Thanks. That's a lot of nice changes. Especially the alignment fix.


Constructor keyword not suggested

Bug Report

From https://github.com/microsoft/vscode/issues/120881
🔎 Search Terms

suggest
Intellisense

🕗 Version & Regression Information
4.3.0-dev.20210412
💻 Code

// @ts-check

class Foo {
    abc;
    constructor(name) { }
}

Trigger suggest right after constructor
🙁 Actual behavior
A suggestion for the constructor keyword is returned.
🙂 Expected behavior
No such suggestion is included

Where is auto-complete being triggered here?

Ah, I see from the original issue. So certain class member keywords are not suggested once they're finished.

The fact that you get keyword completions on
class/*0*/ C {
    yadda;
    async/*1*/ constructor/*2*/() {

    }
}

implies you should get keyword completions for
class/*0*/ C {
    yadda;
    constructor/*1*/() {

    }
}

as well

It looks like that the Actual behavior and Expected behavior should be swapped?

Hi! Since no one is working on this, I'll give it a shot.


Luca QR:  Replace undefined parameters from Check In  with useful Defaults

In LucaApp location QR codes fields like Location are not filled in and replaced with "" .
See: https://github.com/corona-warn-app/cwa-documentation/issues/741.
While this does not make a difference in warning functionality it looks ugly and has high public visibility.
The idea  is to fill these fields with sensible defaults , like:
@LucaCode@
@The QR code does not provide  text  information , but warnings will work@
or similar. This would stop people from thinking it is an error.
Problem image see below.

Internal Tracking ID: EXPOSUREAPP-10669

the luca returned string is undefined : see https://pbs.twimg.com/media/FD5XsWrXMAEYtiV?format=png

Correct, but it will be blamed on CWA, so the idea is to somehow replace the undefined with placeholders, that say "Sry, Luca has not provided"

Would be nice if implemented quickly!

One could think if the GUID could be displayed instead some of the undefineds, like
Location ID: S897-SHJKD-9879-DAKJ
That would people show that CWA received something that can be worked with...

I think a text would be  more user friendly. Indeed though, the users need to know their scan was successful and CWA will warn if needed.
Example "Luca App QR Code wurde erfolgreich verarbeitet"  or neutral "Fremd App QR Code wurde erfolgreich verarbeitet"
Currently it looks like an error, which will lower trust and acceptance.

Internal Tracking ID: EXPOSUREAPP-10669
@DanAmt thanks for your input! I would appreciate a text change as well.


Rename --vk-layers command line argument to --gpu-validation

The new name is independent of the graphics API in use. This prepares Godot for implementations of graphics APIs other than Vulkan.
See https://github.com/godotengine/godot-proposals/issues/4261#issuecomment-1127974614.
Note: Not cherry-pickable to 3.x as graphics API validation isn't available there.

Thanks!


thrust::mt19937 : Is this doable in the future?

I am a newbie in CUDA and Thrust, however, I have to say, thrust is so amazing.
I am working on a CUDA accelerated Monte Carlo problem that require at least 10^13 random numbers. MT19937 seems to be a good random number generator but it is not included in Thrust. Is there any plan that Thrust could include this in the next release?
My problem is basically as following:
in Thrust example monte carlo .cu files, (it calculates pi with a transfrom_reduce for aggregation, and the random number is generated on GPU "device" function,). I am currently using cuRand but it does not have the MT random number generator on the  "device" side.
Thanks!

Mersenne Twister is probably not a good fit for parallel applications because its state is relatively large. The PRNGs Thrust currently supports have relatively small state. Moreover, generating the nth state typically requires either O(n) or O(nlgn) sequential steps.
Moving forward, I think a better strategy for PRNG support will be by targeting PRNGs which are specifically designed with parallelism in mind.

@jaredhoberock should we file this as an RFE for improved device-side PRNGs?

It's not really a question of what makes sense on device or host, the issue is that none of the standard random number generators are a good fit for parallelism.
The problem is that when multiple threads use the same PRNG initialized from different seeds, the output may be correlated. A better approach is to have all the different threads use the same random number sequence, but "leap frog" each other when taking samples from the sequence. Such an arrangement does not produce correlation.
A good PRNG in this arrangement would have small state (because one will be instantiated in each of a massive number of threads) and O(1) access to the nth state in the sequence (because each thread needs to "jump" to state n to avoid colliding with the states consumed by other threads). The D.E. Shaw Research stuff I linked to in my last comment is designed in this way.


Array#+ signature is too restrictive

Input
→ View on sorbet.run
ints = T.let([], T::Array[Integer])
floats = T.let([], T::Array[Float])
numbers = ints + floats # unexpected error here

Observed output
Expected T::Enumerable[Integer] but found T::Array[Float] for argument arg0 https://srb.help/7002

Expected behavior
No errors
Potential solution
It seems like the problem is here:
https://github.com/sorbet/sorbet/blob/dd140356ee753b26a6a7273397bf8e3e1d93fb2e/rbi/core/array.rbi#L444-L456
T::Enumerator[Elem] it's too restrictive, as the addition should allow for any types.

This one specifically is intentional. We think that it's more frequently a cause of bugs than it is intentional on the hand of the programmer. If the behavior is desirable, the recommendation  is to explicitly widen the receiver type first, like
ints = T.let([], T::Array[T.any(Integer, Float)])
floats = T.let([], T::Array[Float])
numbers = ints + floats


Support private git repos that require a custom CA cert

What problem are you facing?
The ansible provider does not currently allow retrieval of Ansible content from git repos that require a custom CA certificate. This is a blocker for enterprise environments that define their own custom CA.
How could Crossplane help solve your problem?
Enhance provider configuration to allow specification of a custom ca-bundle.crt. Then use that ca-bundle.crt when downloading remote ansible content.

Do you think the workaround described here: for the aws provider might work for this provider as well? If so, is there an environment variable like AWS_CA_BUNDLE that would work to tell ansible where to find its ca-bundle.crt?

Hi @ron1 ,
We support mount and exposing the CA certificate to the controller pod through ProviderConfig :
apiVersion: ansible.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: config
spec:
  vars:
    # Specify the path where the Ansible roles are located
    SSL_CERT_FILE: ./ca.pem
  credentials:
    - filename: ca.pem
      source: Secret
      secretRef:
        namespace: crossplane-system
        name: secret-that-holds-ca-crt
        key: ca

--------------
> Do you think the workaround described [here](https://github.com/crossplane/crossplane/issues/2535#issuecomment-907634643) for the aws provider might work for this provider as well? If so, is there an environment variable like AWS_CA_BUNDLE that would work to tell ansible where to find its ca-bundle.crt when fetching urls?

Yes, I believe that you can CA certificate to the ansible controller certificate bundle using `Cluster Policy` from `kyverno`

Yes. Environment variables `SSL_CERT_FILE` and `SSL_CERT_DIR` can be used to specify additional trusted CA certificate or certificates ( [origin](https://github.com/ansible/ansible/issues/28570#issuecomment-324517881) ) . Please  note that we are running  `ansible-galaxy` binary  behind the scene to fetch ansible content, so we support ansible default environnement variable.

Hi @fahedouch,
Thanks for your response.
Is there a current work-around that can be used with the latest provider-ansible image to allow ansible-galaxy to pull from private git repos, say viagit+ssh URLs? Are there environment variables (and volume mounts?) that can be dynamically added to the Pod that might help implement such a work-around?

Hi @fahedouch,
Thanks for your response.
So, should we be able to set environment variables SSL_CERT_FILE and SSL_CERT_DIR via a mutating webhook in the latest provider-ansible image to allow ansible-galaxy to pull content from private git repos?

Yes.

Tried to do this via ProviderConfig but it's now expecting a key/value format.  THis:
apiVersion: ansible.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: provider-ansible
spec:
  vars:
    - key: SSL_CERT_FILE
      value: ./ca.pem
  credentials:
    - filename: sshkey
      source: Secret
      secretRef:
        key: sshkey
        name: ssh-key
        namespace: default
    - filename: ca.pem
      source: Secret
      secretRef:
        key: myca
        name: myca
        namespace: default

The ca.pem gets created in provider, but I'm not seeing the SSL_CERT_FILE env variable as being set when shelling into the container.  Also - how about user/pass for ansible-galaxy if pulling collections from a repo requiring auth as well?

@ride808 I think you can set both env vars and args using controllerConfig. You may need to follow guidance here to mount the ca.crt at the path specified in the above env var. Let me know if you get it working.

Tried to do this via ProviderConfig but it's now expecting a key/value format. THis:
apiVersion: ansible.crossplane.io/v1alpha1
kind: ProviderConfig
metadata:
  name: provider-ansible
spec:
  vars:
    - key: SSL_CERT_FILE
      value: ./ca.pem
  credentials:
    - filename: sshkey
      source: Secret
      secretRef:
        key: sshkey
        name: ssh-key
        namespace: default
    - filename: ca.pem
      source: Secret
      secretRef:
        key: myca
        name: myca
        namespace: default

The ca.pem gets created in provider, but I'm not seeing the SSL_CERT_FILE env variable as being set when shelling into the container.
@ron1 were you successfully at getting galaxy around the cert error?
Maybe it's a more general question as to what is the most common ways to set environment variables in the provider pod.

this should be work now, after merging this. You cannot see env var inside the pod shell as it is directly passed to ansible-galaxy cmd triggered by the AnsibleRun CR.
We avoid setting providerConfig behavior vars as env vars in the controller pod to avoid multi providerConfig behavior vars overriding

I will close this. feel free to open it if necessary.


Design: Allow (permanent?) binding of hardware tokens to OIDC accounts

In https://github.com/sigstore/cosign/issues/108, we're discussing support for yubikey and other PIV devices in our signing clients.
One feature of these devices is that they can produce a hardware-bound attestation certificate with a unique serial number from the manufacturer. It might be interesting to allow Fulcio's root CA to issue a longer-term device certificate that can bind these devices to the oidc account through some kind of registration process.
The actual signing keys on the devices can be reset/rotated more frequency, but it might be nice to somehow "lock" the device itself to the user with a multi-year, discoverable certificate on the tlog.

@dlorenc, is this something you want to explore still?
I don't think we need to pursue this anymore since we encourage the use of ephemeral keys by default.

We can drop this one.


BUILD_EXTENSIONS=False make install  error！！！

System Info
none
Information

[ ] Docker
[ ] The CLI directly

Tasks

[ ] An officially supported command
[ ] My own modifications

Reproduction
none
Expected behavior
"-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-debug" "-nodefaultlibs"
= note: /usr/bin/ld: /home/spfx/tgi/text-generation-inference-3.0.0/target/release/deps/libopenssl-aafd127b1af2d7b3.rlib(openssl-aafd127b1af2d7b3.openssl.50414e331a930e91-cgu.00.rcgu.o): in function openssl::ssl::SslRef::peer_certificate':           openssl.50414e331a930e91-cgu.00:(.text._ZN7openssl3ssl6SslRef16peer_certificate17hb6d9c5bb0094007eE+0x3): undefined reference to SSL_get_peer_certificate'
collect2: error: ld returned 1 exit status
= note: some extern functions couldn't be found; some native libraries may need to be installed or have their path specified
= note: use the -l flag to specify native libraries to link
= note: use the cargo:rustc-link-lib directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#rustc-link-lib)
error: could not compile text-generation-router-v3 (bin "text-generation-router") due to 1 previous error
error: failed to compile text-generation-router-v3 v3.0.0 (/home/spfx/tgi/text-generation-inference-3.0.0/backends/v3), intermediate artifacts can be found at /home/spfx/tgi/text-generation-inference-3.0.0/target.
To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.
make: *** [Makefile:8: install-router] Error 101

We encounter this error too! looking forward to an official reply.


Stale bot is using label "wontfix" even though a different label is configured

Example of the bot applying and removing the "wontfix" label:
https://github.com/MinecraftForge/MinecraftForge/pull/4673#issuecomment-364836718
stale.yml config file:
https://github.com/MinecraftForge/MinecraftForge/blob/1.12.x/.github/stale.yml
I expect it to be using the "Stale" label, it has been until just recently.

Sorry about that. Fix deploying now.

Thanks!


engine.io Uncaught Exception vulnerability

Context
Moderate issue in the monitor-plan-api

Dependabot issue resolved


Add support for enums in storage {}

As a user I would really like to store an enum inside storage {}.
Currently I must use another variable type, u64, with some number to perform the same state checks etc.
This isn't the worst thing in the world however when it comes to an enum that uses the common Address and ContractId that becomes a different story as now I must use additional variables or add additional code to figure out which type I am using.

I have a branch with the fix. I'll put up a PR today.


Deprecate participant_label and exclude_participant_label args

Once we finish implementing the filtering apis #241, the participant_label and exclude_participant_label arguments on generate_inputs() become rather redundant. There would, at that point, be three separate ways to filter out subjects: BidsDatasets.filter(), the magic --filter-<component> args, and the generate_inputs() arguments. I think we can probably afford to simplify and deprecate.

If this would also deprecate the --participant_label cli arg, then that would be a deviation from bids-app standards, and it is a quite commonly used option in my experience. We could drop the exclude_participant_label perhaps.

Ah, no definitely not talking about the cli. I was thinking more the arguments on the generate_inputs function

The CLI arg uses this so we should keep it for now, at least until BidsDataset.filter exists.

As implemented in #349, these arguments actually do have distinct features: they apply filtering after paths are found via pybids, meaning you can end up with empty components as opposed to missing components. --participant-label also filters before running path parsing, meaning it's faster than running a filter after generate_inputs


[Atom-1.28.0-beta1][OSX] Mocha tests fail in headless mode, but not in headed mode

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
I'm using https://github.com/BinaryMuse/atom-mocha-test-runner to run package specs, and I started noticing something weird recently.
The latest Atom beta (1.28.0-beta1) fails to run specs that require package activation on OSX.
The package is activated via await atom.packages.activatePackage(path.join(__dirname, '..')) (since atom-mocha-test-runner doesn't automatically load/activate the package in question). This works on Atom 1.27, and on Windows/Linux on 1.28.0-beta1, but for some reason not on OSX 1.28.0-beta1.
I've went out of my way to get access to an OSX machine, and apparently, specs run fine, more or less, from Atom via window:run-package-specs, but fail completely via atom-beta --test
Overall it appears as if the package fails to activate completely when specs are run with atom --test
Additional Information
Some build examples: https://travis-ci.org/atom-community/markdown-preview-plus/builds/384340951

I was able to track this down to the dependency on fsevents, which silently fails to load in Package.getIncompatibleNativeModules, and further investigation yields the following trace:
Method bytesRead called on incompatible receiver #<TTY>
TypeError: Method bytesRead called on incompatible receiver #<TTY>
    at Function.getOwnPropertyDescriptor (<anonymous>)
    at names.map (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/rpc-server.js:35:29)
    at Array.map (<anonymous>)
    at getObjectMembers (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/rpc-server.js:34:16)
    at getObjectPrototype (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/rpc-server.js:52:14)
    at valueToMeta (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/rpc-server.js:95:18)
    at EventEmitter.<anonymous> (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/rpc-server.js:387:25)
    at emitThree (events.js:136:13)
    at EventEmitter.emit (events.js:217:7)
    at WebContents.<anonymous> (/private/var/folders/jv/t7bl0bt111n7m1nct94bxdw80000gn/T/AppTranslocation/7212D351-985E-4707-BF34-DB60627600B2/d/Atom Beta.app/Contents/Resources/electron.asar/browser/api/web-contents.js:295:13)
    at emitTwo (events.js:126:13)
    at WebContents.emit (events.js:214:7)

Here's a test package: https://github.com/lierdakil/atom-mocha-osx-test
Here's a typical build for this package: https://travis-ci.org/lierdakil/atom-mocha-osx-test/builds/384376894

Hey @jasonrudolph ... this may be related to Electron v2.0? Can you take a quick look to give a 👍/:-1: on that?

Possibly related: https://github.com/nodejs/node/issues/17636

@lierdakil: Thanks for the detailed issue with nice, clear reproduction steps. ✨

@maxbrunsfeld @daviwil: This issue leads me to believe that something differs in the way modules are loaded when running in headless mode versus headed mode, but I'm not yet sure what that difference is. Can you think of anything that might be causing the different behavior noted below, or can you think of a good place for me to look to try to track down the difference?
Headless
When running the tests from the command line, the activation and deactivation tests fail and log the following output:
$ atom --test spec

Package.isCompatible() =  false
Package.getIncompatibleNativeModules() =  [ { path: '/private/tmp/atom-mocha-osx-test/node_modules/fsevents',
    name: 'fsevents',
    version: '1.2.4',
    error: 'Method bytesRead called on incompatible receiver #<TTY>\nTypeError: Method bytesRead called on incompatible receiver #<TTY>\n    at Function.getOwnPropertyDescriptor (<anonymous>)\n    at names.map (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:35:29) ... <snip>' } ]

1 passing (159ms)
2 failing

Headed
When running the tests within Atom, they all succeed and log the following output:
Package.isCompatible() =  true
activation.test.js? [sm]:14 Package.getIncompatibleNativeModules() =  []

Hey @jasonrudolph ... this may be related to Electron v2.0? Can you take a quick look to give a 👍/👎 on that?

@lee-dohm: Probably 👍.
As far as I can tell, this issue does appear to be new in Atom 1.28, which means there's a good chance it's due to the Electron 2.0 upgrade.
With Atom 1.27, if an incompatible native module is present in the package's node_modules directory, the tests fail in both headless and headed modes (whereas the headed tests pass in Atom 1.28). For example, I copied an incompatible version of keytar into the node_modules directory of the test package, and observed the results shown below.
Headless
When running the tests from the command line, the activation and deactivation tests fail and log the following output:
$ atom --test spec

Package.isCompatible() =  false
Package.getIncompatibleNativeModules() =  [ { path: '/private/tmp/atom-mocha-osx-test/node_modules/keytar',
    name: 'keytar',
    version: '4.2.1',
    error: 'The module \'/private/tmp/atom-mocha-osx-test/node_modules/keytar/build/Release/keytar.node\'\nwas compiled against a different Node.js version using\nNODE_MODULE_VERSION 57. This version of Node.js requires\nNODE_MODULE_VERSION 54. Please try re-compiling or re-installing\nthe module (for instance, using `npm rebuild` or`npm install`).' } ]
!!

  1 passing (211ms)
  2 failing

$ atom --version
Atom    : 1.27.2
Electron: 1.7.15
Chrome  : 58.0.3029.110
Node    : 7.9.0

Headed
When running the tests within Atom, they fail in the same way that they failed in headless mode:

The latest Atom beta (1.28.0-beta1) fails to run specs that require package activation on OSX.

@lierdakil: Based on your findings in https://github.com/atom/atom/issues/17409#issuecomment-392332143 and my follow-up findings in https://github.com/atom/atom/issues/17409#issuecomment-393610837 and https://github.com/atom/atom/issues/17409#issuecomment-393627854, I think the root problem is different than what is described in the original issue body. I've described my current understanding below. Does that description seem accurate to you?
Steps to Reproduce

Identify the version of Electron used by your version of Atom (e.g., Atom 1.28.0-beta2 uses Electron 2.0.1).
Create a package that has a native dependency that is incompatible with that version of Electron (e.g., fsevents 1.2.4 appears to be incompatible with Electron 2.0.1)
Add a test that activates the package and asserts that activation succeeded. [example]
Run apm install to install the package's dependencies.
Launch Atom and open a project containing the package.
Run the Window: Run Package Specs command.

Expected behavior: The specs should fail, because the package specifies a dependency on an incompatible native module.
Actual behavior: The specs pass.

fsevents 1.2.4 appears to be incompatible with Electron 2.0.1

This is not accurate. fsevents happily loads in headed mode when required directly:

But the same thing fails right away in headless mode:
https://travis-ci.org/lierdakil/atom-mocha-osx-test/builds/386513047
Find the code at https://github.com/lierdakil/atom-mocha-osx-test/pull/3

The more I look into it, the more it seems that the root issue is not as much upgrade to Electron 2.0, as is upgrade to Node 8.9.3. https://github.com/nodejs/node/issues/17636 seems very much relevant.
What I don't understand is where the apparent difference between headed and headless comes from. Perhaps this line from Electron is just never executed in headed mode?

@lierdakil: Thanks for the additional info. :bow:

The more I look into it, the more it seems that the root issue is not as much upgrade to Electron 2.0, as is upgrade to Node 8.9.3. https://github.com/nodejs/node/issues/17636 seems very much relevant.

That sounds right to me. I see that https://github.com/nodejs/node/issues/17636 is fixed in https://github.com/nodejs/node/pull/17665, and that fix is currently in Node  10.0.0 and subsequent 10.x.y releases (https://github.com/nodejs/node/commit/efffcc262c77a58ad3c75787497df46863d1b7a6).
The fix has been backported to Node 8.11.2 in https://github.com/nodejs/node/pull/20478.
I'll check in with the Electron folks to see if there's a way to get an Electron 2.0.x release that uses Node 8.11.2, or if there's a different approach that could resolve this issue. I'll follow up here with my findings.

Cross-referencing https://github.com/electron/electron/issues/13061, as it appears to be related.

I'll check in with the Electron folks to see if there's a way to get an Electron 2.0.x release that uses Node 8.11.2, or if there's a different approach that could resolve this issue. I'll follow up here with my findings.

I chatted with @ckerr, and he opened https://github.com/electron/node/pull/38 to backport the fix from nodejs/node@efffcc2 into the version of Node used in Electron 2. 😅
Once there's a build of Electron that includes that fix, I'll upgrade Atom to use that build of Electron, and verify that it resolves this issue. 🤞

This is fixed by #17549, and that change will be included in the Atom 1.28 release.


Update QUICHE from 5406ceca9 to faf6f0e8f

https://github.com/google/quiche/compare/5406ceca9..faf6f0e8f
$ git log 5406ceca9..faf6f0e8f --date=short --no-merges --format="%ad %al %s"
2022-01-11 vasilvv Use a C++17 feature in QUICHE.
2022-01-11 bnc Remove HTTP2_FALLTHROUGH.
2022-01-11 haoyuewang Make GfeQboneServerSession buffer STREAM_FRAME (with pending stream) and drop MESSAGE_FRAME before LOAS authentication completes.
2022-01-11 quiche-dev Let OgHttp2Session invoke the visitor OnMetadataEndForStream() callback for empty metadata payloads.
2022-01-11 haoyuewang Set idle timeout correctly between TLS handshake completion & LOAS authentication completion for QBONE with IETF-QUIC.
2022-01-11 quiche-dev Updates header validation behavior when encountering a too-long header field.
2022-01-11 wub Fix a few Readability/Naming clang-tidy warnings under //third_party/quic.
2022-01-10 quiche-dev Remove TestFrameSequence::MetadataBlockForPayload().
2022-01-10 quiche-dev Fixes test case OgHttp2AdapterServerTest.ServerReceivesTooLargeHeader in oghttp2_adapter_test.cc.
2022-01-10 vasilvv Add a way to make WebTransportFingerprintProofVerifier reject RSA keys.


Newbe Questions about Lambda

I followed the instructions and copied my applicationId into the options.js file but I get an error
"{
"errorMessage": "Invalid applicationId"
}"
I checked it many times to make sure it has the right AppID.  Anything I should be looking for to figure out why this errors on my AppID?

This is the full error log:
START RequestId: a9197f11-3b9e-11e5-a1fb-318f91195300
2015-08-05T18:20:33.418Z	a9197f11-3b9e-11e5-a1fb-318f91195300	session applicationId: YOUR_ECHO_AWS_APP_ID_HERE
2015-08-05T18:20:33.418Z	a9197f11-3b9e-11e5-a1fb-318f91195300	The applicationIds don't match : YOUR_ECHO_AWS_APP_ID_HERE and amzn1.echo-sdk-ams.app.[I redacted this for security]
2015-08-05T18:20:33.419Z	a9197f11-3b9e-11e5-a1fb-318f91195300	Unexpected exception Invalid applicationId
2015-08-05T18:20:33.419Z	a9197f11-3b9e-11e5-a1fb-318f91195300	{"errorMessage":"Invalid applicationId"}
END RequestId: a9197f11-3b9e-11e5-a1fb-318f91195300
REPORT RequestId: a9197f11-3b9e-11e5-a1fb-318f91195300	Duration: 19.82 ms	Billed Duration: 100 ms 	Memory Size: 128 MB	Max Memory Used: 9 MB


avoid using np.stack which is introduced in NumPy 1.10

Fixes #4081
Refs #4003

For record, this issue was introduced in #3494 (no need to backport)


Do not suggest open namespaces in case of misspelled names

This was a part of https://github.com/Microsoft/visualfsharp/pull/2102, it fixes https://github.com/Microsoft/visualfsharp/issues/2108

@dotnet-bot test this please


Save the chart as an image

Hey!
Is there any way to save the chart as an image?
Thank you,
Vered

Yes, just use the underlying SKiaSharp.
Using chart as your normal defined chart:
var bmp = new SKBitmap(500, 500);
bmp.Erase(SKColor.Empty);
var canvas = new SKCanvas(bmp);
chart.DrawContent(canvas, 500, 500);
canvas.Save();

var yourStream = File.Create("XXX"); // or any other IO stream

using (var image = SKImage.FromPixels(bmp.PeekPixels()))
{
    using (var data = image.Encode(SKEncodedImageFormat.Png, 100))
    {
        data.SaveTo(file);
    }
}


Add ReadTheDocs config

Summary of the changes / Why this is an improvement
This change adds a first integration of the builds into ReadTheDocs. From there we can take it to the next level and integrate it into Crate.io's documentation framework.
A demo build is on https://crate-operator.readthedocs.io/en/mh-rtd-config/
Checklist

[ ] CLA is signed

sorry, just to clarify. I missed that the current package has to be installed. the best way to do that is to add "." to the requirements file. see here: https://github.com/crate/crate-docs-theme/blob/master/docs/requirements.txt
(changing the python version is fine)

Thanks @mechanomi I've update the RTD config and also had to make sure that the API docs are build accordingly.


fix: restart goture after db reset

What kind of change does this PR introduce?
Bug fix https://github.com/supabase/cli/issues/1056
What is the new behavior?
as title
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 19 (89.47%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 60.964%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/db/reset/reset.go
16
18
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
4362

Relevant Lines:
7155

💛  - Coveralls


Language Server - have Token extend Range

@heeheehee-kolmafia just checking -- are you busy with something else? Waiting for me for something? In the process of reviewing this? Taking a break from this after what happened during the last few days?
Just making sure it's not another deadlock like last time

I'll get around to this when I have time. Haven't looked yet.

(@heeheehee-kolmafia Am I meant to re-request review once I answered all three questions, even though I didn't make any change, or..?)

(no, I've just been busy.)


Personal goals

PR includes

[x] Feature

Related issues

Resolve #1757
QA Instructions, Screenshots, Recordings

https://github.com/taskany-inc/issues/assets/9020793/93cb15a2-2b7b-4a12-9a8c-cb654aa994c3

https://github.com/taskany-inc/issues/assets/9020793/ac834c74-c5ab-4386-9c48-f85c3160fa7c


Mysql Error from using Apostrophe in name.

Describe the bug
Mysql error caused from using apostrophe in name.
To Reproduce
Add a name including an apostrophe to an inventory item name
example:  Grampy's Soil
Expected behavior
For you to be able to use an apostrophe
Screenshots

More details
An string or a sql statement with an apostrophe becomes a unclosed string because of the presence of that single 'quote'
Software:
HortusFox v3.2
PHP Version: 8.3.0
MySQL Version: 9.0.0

Works flawlessly with MariaDB. Trying to reproduce with MySQL.

@tumeden I see now what's happening. The problem is that when you tried to add the item to your inventory using the group identified via the token 300, it appears that the group item does not exist. That's why you get that message. The message Invalid group token: 300 indicates that there is no such group with the given token. It might be that someone deleted the group before you tried to add an inventory item while your page was not refreshed, so the group was still in list.

Resolved via 56abc5f3da0a302c2c4ff67dc9c5f1c6941b1b58


Script footprint.sh failing

The script scripts/footprint.sh no longer works, and is failing with the error:
arm-none-eabi-gcc (4.8.2-14ubuntu1+6) 4.8.2
CFLAGS=-Os -march=armv7-m -mthumb

default (include/mbedtls/config.h):
entropy_poll.c:45:2: error: #error "Platform entropy sources only work on Unix and Windows, see MBEDTLS_NO_PLATFORM_ENTROPY in config.h"
 #error "Platform entropy sources only work on Unix and Windows, see MBEDTLS_NO_PLATFORM_ENTROPY in config.h"
  ^
make[1]: *** [entropy_poll.o] Error 1
make: *** [lib] Error 2

ARM Internal Ref: IOTSSL-693


Respect --extend-per-file-ignores on the CLI

Summary
This field was being dropped from the CLI.
Closes https://github.com/astral-sh/ruff/issues/8328.

Thank you for the fix, I'm about to use this in Hatch!


Request for Example: Directly Reading and Parsing Filenames from $MFT File without Copying

@t9t
Thank you for sharing the code of this library. As a newbie to MFT, could you write an example? I would greatly appreciate it if you could read the $MFT file directly without copying it, and then parse out the file name of each file.

Hi @hkhk368, thanks for taking the time to make this request.
Unfortunately, I cannot give a good example. When I wrote this library, I wanted to create an open-source commandline alternative to WizFile, to quickly find a file by reading the MFT. However, while I figured out parsing (of which this library is the result), I was never able to figure out how to get the file tree from the MFT. I encountered some strange things, like multiple records for the same file, or entries for files which were already deleted (and no indication of that in the record). So there is something missing to bridge the gap between reading MFT records, and actually interpreting the records to a file tree.
So for now, my suggestion is to look up other MFT and NTFS documentation on the web to understand how to interpret the MFT data for your use case.
I'll leave the issue open, because I do think it would be useful to add a few good examples at some point.


Mobile Safari issue

iOS 8.1.2

Tap on the input. Datepicker will open.
Tap outside the datepicker. Datepicker will not close.

http://jsfiddle.net/z4fmvuzb/

Should be fixed now
https://github.com/nazar-pc/PickMeUp/releases/tag/2.6.5


Can't extract unity3d

Hi, ata4.
I am very thanks for your disunity program. I am trying to extract game object from package file, but it fails.
Maybe the version is unmatched.
The current version for target package is 4.7.0f.
How can I extract these?

Download Disunity v0.5 and type the following command in your CLI:
java -jar disunity.jar bundle unpack
Please note that Disunity v0.5 doesn't support the deserialization of objects and the release versions of Unity don't support UnityFS asset bundles. Please close!


Numeric fixes

Fixes: https://github.com/Azure/autorest.csharp/issues/301
Properly handles numeric formats for short, int, long, float, double, and decimal. Enables a couple more tests to pass in body-complex.

This might be a good time to start adding tests that verify model structure. In this case we can verify that property types are what we expect.

/azp run


Fix invalid links in access-control.md

In page "Authentication, Authorisation, Access Control",
section "Authorisation: How Permissions Work",
the links in the table were not properly formatted.
I fixed the link formatting.

Thanks!


Update the doc for OpenCensus Python

@mrbullwinkle - this is the proposed change for OpenCensus Python June release. Please help to review, thanks!

@lzchen for awareness

If you want I can take your changes and quick generate a PR against the private repo for you tomorrow if that saves time?

Sure, that would be very helpful! I can also help if you need.

The changes requested in the pull request appear to now be reflected in the current version of the article. We'll close this PR.


doc update reflecting folder name change

We've 2 examples in folder example.

takeoff_land
fly_mission
TODO: Need to update the links to them once the corresponding PR is merged.

@shakthi-prashanth-m next time just add a commit like this to the original PR. There is no need to create an additional pull request per commit.


Is there a better readme? Are we able to change options?

The datepicker looks great. But! I don't know how to use it! The current readme has little information. The Live Demo just show functionality, but it does not tell me how to do that. which is useless. Things I want to change are: 1. css style. 2. closeOnSelect. 3. disable dates something like these. Is that possible??

Hi, you can change the css files, if you do this you need to build the changes with grunt.
Im can't see what you mean by closeOnSelect.
Disabling dates is not possible, you can only do a min and max date rule, but it will only add validation to ng-model.

Hi, thanks for replying. The options readme I mentioned is like this datepicker(https://github.com/alongubkin/angular-datepicker). And they have a very informative options instruction: (http://amsul.ca/pickadate.js/date/). The only problem is that datepicker is no longer maintained. So my question is: Do you have something like the options instruction?

This date picker don't have have that type of configuration, the only "options" are the attributes described on the readme. You need to have basic knowledge of angular to use this directive. But you are right and the readme can be inproved, helping to understand how the distribution code can be used.

Thank you. Another thing is that it is hard to hook up datepicker with a button. I used a ng-if='showPicker' and  it is easy to close datepicker by setting auto-close='true', but no idea how to reopen it by clicking the button. What's more. min-date and max-date are just for validation, while I was expecting to disable dates before min-date

Don't use auto-close with a button, it will remove the date picker from scope, check this: http://plnkr.co/edit/b5BJLxTWtBrzSKcwCMsJ?p=preview.
You need to have a button that will open the picker and another to close it.

I've checking the source code and i can see that auto-close does 2 things.

Add's a class to the date picker "hidden" this will hide the picker
It emit's an event to the scope "hidePicker"

Try this: http://plnkr.co/edit/bDuKpjXpvuXh5x3jDaLE?p=preview


Auto-select artifact when processing or analyzing

Since you can only process one artifact at a time, when you click the "Process" button, the artifact should be automatically selected the first time since there is only one artifact present.
Tagging with 'CMI-workshops' now when feedback received there.

fixed in https://github.com/biocore/qiita/pull/2352


FR630 button layout is different

Figure out the button layout and adjust the icons.

It is a touch screen also.

Fixed in 4a68eef. Closing.


🐛 FromSeed() does not set value from seeded object property

Describe the Bug
FromSeed() does not set value from seeded object property
I'm using AutoFixture 5.0.0-preview0011
Scenario
public class FromSeedTests
{
    private class Foo { public string StrVal { get; set; } }

    [Fact]
    public void TestFromSeed()
    {
        // Arrange
        var fixture = new Fixture();
        var fooSeed = new Foo() {StrVal = "FromSeed",};

        fixture.Customize<Foo>(c => c.FromSeed(seed => new Foo() {StrVal = seed.StrVal}));

        // Act
        var fooFromSeed = fixture.Create<Foo>(fooSeed);

        // Assert
        Assert.Equal("FromSeed", fooFromSeed.StrVal);
    }
}

produces this assertion error
Xunit.Sdk.EqualException
Assert.Equal() Failure: Strings differ
           ↓ (pos 0)
Expected: "FromSeed"
Actual:   "StrVal117cc748-74ef-4dd2-827d-0acfcac60f6"···
           ↑ (pos 0)
   at XunitTestProject_01.FromSeedTests.TestFromSeed() ...

Expected Behavior
I've expected the value from seeded value to be copied to created object but it wasn't
Maybe I have wrong assumptions about how fromSeed() works but if that is the case ,it is because I couldn't find good documentation with examples how to correctly use it and why my example fails. (same applies to fromFactory())
I've tried links like:

https://autofixture.github.io/docs/quick-start/
https://github.com/AutoFixture/AutoFixture/wiki
.. all Mark's Seeman blog posts with AutoFixture tag

Can you please add documentation about how to use fromSeed/FromFactory (and also probably how not to use it ?)

Hi @grzegorz-wolszczak,
The behavior you are observing is not a bug. FromSeed works similar to the FromFactory method in the builder API.
It will provide a way to create an object instance from a seed but will not prevent default behavior.
I your case since the Foo.StrVal has a public setter the value in that property will be overridden by the initialization of auto-properties. To avoid it you could either use 'OmitAutoProperties()or explicitly omit that specific member.Without(x => x.StrVal)`.
Here's a working example:
[Fact]
public void TestFromSeed()
{
    // Arrange
    var fixture = new Fixture();
    var fooSeed = new Foo() { StrVal = "FromSeed", };

    fixture.Customize<Foo>(c => c
        .FromSeed(seed => new Foo() { StrVal = seed.StrVal })
        .Without(x => x.StrVal));

    // Act
    var fooFromSeed = fixture.Create<Foo>(fooSeed);

    // Assert
    Assert.Equal("FromSeed", fooFromSeed.StrVal);
}

Regarding the documentation. I know there isn't much to go on.
At the moment the project priorities lie in other areas. If you wish to help you could raise a PR in the documentation project.

closing the issue.
if in doubt about other features, please open a question in the discussions.

I have been often puzzled by the from seed method because its behavior feels unnatural or, at the very least, conflicting with the intent declared by the name.
In my opinion, an object constructed from a seed should be equivalent to the seed unless explicitly customized otherwise.
I'd consider changing the method so that OmitAutoProperties is automatically included
It will then be responsibility of the user to specify With(property) to force the generation of a new value for the specific property.

@Kralizek I can only assume, but I think the intention was to allow creation of related values. Using the original object as a prototype.
For example objects with the same foreign key, people with the same last name, etc.
To create a new object you'd create a specimen builder that would handle a seeded request for a specific type.
Then in that handler you'd specify how the value is created and return it. No other alterations would be made to that object, since the resulting object was created.
It's the fact that @grzegorz-wolszczak used the builder API that forced the other properties to be filled in.
For example:
[Fact]
public void TestFromSeed()
{
    // Arrange
    var fixture = new Fixture();
    fixture.Customizations.Add(new SeededFooBuilder());
    var fooSeed = new Foo { StrVal = "FromSeed" };

    // Act
    var fooFromSeed = fixture.Create<Foo>(fooSeed);

    // Assert
    Assert.Equal(fooSeed.StrVal, fooFromSeed.StrVal);
    Assert.Null(fooFromSeed.OtherStrVal);
}

public class Foo
{
    public string StrVal { get; set; }
    public string OtherStrVal { get; set; }
}

public class SeededFooBuilder : ISpecimenBuilder
{
    public object Create(object request, ISpecimenContext context)
    {
        if (request is not SeededRequest seededRequest)
        {
            return new NoSpecimen();
        }

        if (seededRequest.Seed is not Foo foo)
        {
            return new NoSpecimen();
        }

        return new Foo { StrVal = foo.StrVal };
    }
}


Added a gitignore to remove unwanted files

Clean up for you :)

Split into 2 PRs depending on how many changes you wanted @avijit1258


updating OpenShift install docs to include leader election env vars

Issue #, if available:

Relates: aws-controllers-k8s/code-generator#455

Description of changes:
Adding these env's to the configmap so when leader election code is merged, installs on OpenShift can still function properly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly This can go after the code-gen is merged.

@a-hilaly @RedbackThomson Can this be merged now that leader elect is merged.


Simplify GDVIRTUAL_CALL calls

The premise of this PR is that
bool success = false;
if (GDVIRTUAL_CALL(_handles_type, p_type, success)) {
	return success;
}

return false;

is the same as
bool success = false;
GDVIRTUAL_CALL(_handles_type, p_type, success);
return success;

I went over all if (GDVIRTUAL_CALL) conditions and simplified them like this.

I wonder if this has an incredibly miniscule performance benefit because of one less redundant call, too, of if it really just is a stylistical choice...

I asked about this in the chat and this is a leftover from before GDExtension where virtual functions worked like that. When new virtuals were introduced, the old calls were mass-renamed and then newly added ones just followed the style. So it seems like some legacy thing.

Thanks!

збирає гроші. Допомога ЗСУ
Зробити переказ ви можете за посиланням: https://hi.alfabank.ua/3kvbwJWex5e5wn438
Надіслано з iPhone

27 жовт. 2022 р. о 10:19 Juan Linietsky @.***> пише:

@reduz approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.


Undifine mysqli_init() line 103

Hello,
I am from Indonesia and I have one question regarding Codeigniter mysqli_driver
I have uploaded my apps into web server but there was an error that saying :
Call to undefined function mysqli_init()...in sys/database/drivers/mysqli/mysqli_driver.php on line 103..
I dont know how to fixit. FYI: my host running PHP 5.4.30, Apache 2.2.27, MySQL version 5.5.37-cll.
If i use my offline server (using php 5.5.11), there is no such issue come up.
If there are allready closed issues on this, please guide me to it.
Thanks in advance.
Regards,

Hey narfbg;
mysqli_init() is in system\database\drivers\mysqli\mysqli_driver.php on line 125
and this is supposed to initialize mysqli.... amhaving sam problem n failed to solve

If mysqli_init() is not defined, you need to install/load the MySQL Improved (mysqli) extension. Check with your host or read the relevant section of the PHP manual: http://php.net/manual/en/book.mysqli.php This is not an issue with CodeIgniter.

@Qnatz you must be very studios to fail resolving this issue lol


Add Missing Descriptions

Brief explanation of the change
Added missing descriptions
For now it's a draft until i finish doing missing ones and maybe change the ones i really don't like.

This is it, it has every missing description

Or should i add descriptions for Evidence ?

Site won't use them, but it might be ok for documentation purposes.

**BIF File** any file with the .bif extension. is just as good as having no description, haha.
Just skip evidence for now.

That's what i though, haha

A few evidence files I did give descriptions that say things like "this can be a sign of XYZ engine" but yeah let's skip evidence for now.
You have an "is is" typo in one of these, but they all look pretty good to me.

I merged this, the rest can be iterated in a future pr.


[SPARK-30125][SQL] Remove PostgreSQL dialect

What changes were proposed in this pull request?
Reprocess all PostgreSQL dialect related PRs, listing in order:

#25158: PostgreSQL integral division support [revert]
#25170: UT changes for the integral division support [revert]
#25458: Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. [revert]
#25697: Combine below 2 feature tags into "spark.sql.dialect" [revert]
#26112: Date substraction support [keep the ANSI-compliant part]
#26444: Rename config "spark.sql.ansi.enabled" to "spark.sql.dialect.spark.ansi.enabled" [revert]
#26463: Cast to boolean support for PostgreSQL dialect [revert]
#26584: Make the behavior of Postgre dialect independent of ansi mode config [keep the ANSI-compliant part]

Why are the changes needed?
As the discussion in http://apache-spark-developers-list.1001551.n3.nabble.com/DISCUSS-PostgreSQL-dialect-td28417.html, we need to remove PostgreSQL dialect form code base for several reasons:

The current approach makes the codebase complicated and hard to maintain.
Fully migrating PostgreSQL workloads to Spark SQL is not our focus for now.

Does this PR introduce any user-facing change?
Yes, the config spark.sql.dialect will be removed.
How was this patch tested?
Existing UT.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19706/
Test PASSed.

Test build #114883 has started for PR 26763 at commit f7ad82e.

Test build #114883 has finished for PR 26763 at commit f7ad82e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114883/
Test PASSed.

cc @gatorsmile

Thanks Dongjoon, also cc @cloud-fan

Note that, we want to revert pgsql dialect, but not all pgsql compatibility features. A simple policy: if a behavior is not protected by conf.usePostgreSQLDialect, it should not be reverted.

Test build #115038 has started for PR 26763 at commit cc14274.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19859/
Test PASSed.

@cloud-fan Thanks for the guidance, it takes me some time to reprocess all the related commits.
The last change keeps the date subtraction and ANSI-compliant support. I also changed the PR description correspondingly.

Test build #115041 has started for PR 26763 at commit 6d978c6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19861/
Test PASSed.

Test build #115041 has finished for PR 26763 at commit 6d978c6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115041/
Test FAILed.

Test build #115038 has finished for PR 26763 at commit cc14274.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115038/
Test PASSed.

Test build #115101 has started for PR 26763 at commit 17a3c77.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19915/
Test PASSed.

Test build #115101 has finished for PR 26763 at commit 17a3c77.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115101/
Test PASSed.

thanks, merging to master!

Thanks Wenchen!

Thank you, @xuanyuanking and @cloud-fan .
Also, cc to the original authors, too. Although we removed these, we are thankful for your original contributions. Sorry again.

@wangyum
@younggyuchun
@gengliangwang
@MaxGekk
@Ngone51


Set scheduledTime and startTime with currentTime for all system tasks

Pull Request type

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
[ ] WHOSUSING.md
[ ] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.
Changes in this PR
Set scheduledTime and startTime with currentTime for all system tasks
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered

nit: Title and description of this PR to be modified to maybe "fix scheduleTime of task"?


Please improve 'vcpkg search'

Currently vcpkg search pattern gives all kinds of hits unrelated to library name(s) as the
vcpkg search --help indicates:
The argument should be a substring to search for, or no argument to display all libraries.
I read this as a substring should match the library name only.
Now with e.g. vcpkg search ares (and combined with grep to give colours), I get these hits:

How useful is it to match ares against Nearest and squares?
I would request a more powerfull and precise fnmatch-style instead. Like:  vcpkg search  lib[a-c]*.
Returning something like:
libaaplus           2.12-1         libaaplus is an astronomical computations library by naughter software
...
libcroco            0.6.13#2       A standalone css2 parsing and manipulation library
libcuckoo           0.3            A high-performance, concurrent hash table

This seems like two features in one request:

Adding regex search to vcpkg search
Adding an option to only search names.

These are both reasonable features, however it's unlikely to be done by us since it's lower-prio. If you're interested, we'd accept patches to add these :)

.... however it's unlikely to be done by us since it's lower-prio.

Sorry about the late reply, but what!! "lower-prio" according to who/what?
Okay  lets just stay with the traditional sloppy cmd-line handling Microsoft uses.

@gvanem it's lower-prio for us to implement compared to registries and versioning; we don't have unlimited time, and while this would be a nice-to-have, it's not blocking anyone. We are very willing to help anybody interested in implementing this, of course, since this is an open source project.


Cleanup and harmonize contract setup protocol error handling

When working on https://github.com/itchysats/itchysats/pull/1515 we noticed that contract setup protocol does not handle all error pathes within the protocol actor, but some errors are passed out of the actor back to the connection.
This means we might not add a Failed event, we might not even stop the contract setup actor, but just keep it running forever (which is basically a memory leak).
Cleanup:

contract setup handlers should not be fallible, but error should be handled within the actor.
once contract setup handler was cleaned up: evaluate if address_map::send_fallible is still used and necessary.

This project is unmaintained


Why LoadGen use C++

I'm curious why using C++ within Loadgen not other language. What's the advantage of using C++ instead of python and C?

The LoadGen needs to be very low overhead in order to measure the maximum throughput of large systems and to avoid overburdening the CPU in small systems. Python's overheads are too high. Choosing between C and C++, there are more programmers comfortable writing well-modularized code in C++ than C.


Error: You have both a tsconfig.json and a jsconfig.json.

Error: You have both a tsconfig.json and a jsconfig.json. If you are using TypeScript please remove your jsconfig.json file.

But I'm not using Typescript 🤨
I need a tsconfig.json, because I need eslint-plugin-deprecation, which requires @typescript-eslint/parser, which requires Typescript, which requires a tsconfig.json.
When I rename tsconfig.json to tsconfig.eslint.json and point eslint to that, craco conveniently creates a tsconfig.json! 🤯
It does so because it detected one little teeny-weeny .ts file, which again is needed for a valid tsconfig.json. The file doesn't even contain any code whatsoever, just a comment to explain to developers encountering it, what it's for.
The build will succeed (well, not really, as it builds some empty project, but at least without errors), but only this time. Next time it'll see that newly-created tsconfig.json, which will produce the same error again. This is madness! Craco literally conveniences itself to a crash 😅
So how can I:

Prevent it from creating a tsconfig.json for a Javascript project
Tell it not to crash on the existence of a tsconfig.json and a jsconfig.json, but instead use jsconfig.json and ignore the other
Work around this issue until a proper fix has been released

Are you sure this is coming from CRACO and not CRA itself? I remember setting up CRA in a project with both tsconfig.json and jsconfig.json and CRA threw out an error until I removed one of those files.

Does it matter? I'm using craco, not cra, and to me craco is throwing this error. Whether the error originates in an upstream package, I trust that the craco authors know how to deal with better than I do.

Close this issue all you want, but I don't think this issue is fixed. I'm no longer on the project that this was about, so I personally don't care if it get fixed. But it probably should be.
At any rate, I really don't think ingoring/postponing an issue merits closing it...

Stale bot closed this issue for inactivity. Because I'm starting to maintain this project and because I'm personally not a fan of stale bot (at least for now when I can manually close issues as I see necessary), I'll remove it. I'll look into the issue at some point soon.

Does it matter? I'm using craco, not cra, and to me craco is throwing this error. Whether the error originates in an upstream package, I trust that the craco authors know how to deal with better than I do.

@thany if you're using craco, you're probably using cra (hence the 'cra' in 'craco'). In fact, there's no point in using craco if you're not using create-react-app.
The error that you encountered is not thrown by craco but rather by react-scripts. If you could, please share the steps you took so I can try to reproduce the issue (for example, you could create a demo repo with the setup you have).


⚠ Jenkins Plugins Artifactory has degraded performance

In 80486ac, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1248 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 8ba479f after 1 hour, 29 minutes.


How to encode our scientific understanding?

Describe this function:
Particle function(Wave) {...}

We're modelling wavefunction collapse, where the result of a measurement is the collapse of the wave into a single particle.


Broken Table of Contents in Keen - SendGrid Integration Tutorial

https://sendgrid.com/docs/Integrate/Tutorials/analytics_with_keen_io.html
it looks like a single paranthesis is missing.
a big launch is happening tomorrow so if anyone knows how to fix, plz help!

@wetzler thanks for the catch! I can push this fix to production before your big launch tomorrow

omg thank you. I found another one (less urgent but still would be nice to have). will log separately.

@wetzler you're welcome! We'll address the other one soon (or someone in our open source community!)
Closing this issue because the links are working correctly now!


RequiredIf attribute prevents DisplayName from working

I just noticed that when I have the [RequiredIf] attribute on my view model properties, the display name value isn't being used for labels.  Eg:
View model:
public class RegistrationViewModel
{
    [RequiredIf("IsAdmin == false", ErrorMessage = "Date of Birth is required")]
    [Display(Name = "Date of Birth")]
    public DateTime? DateOfBirth { get; set; }
}

View:
@Html.LabelFor(m => m.DateOfBirth)

Instead of "Date of Birth" being displayed, it's displaying "DateOfBirth".  The way only to get it to use the display name now is to include it in the Razor code like this:
@Html.LabelFor(m => m.DateOfBirth, "Date of Birth")

I would prefer to keep it in the view model.
When I comment out the [RequiredIf] attribute, it uses the display name correctly.
Unfortunately, I can't test in the ExpressiveAnnotations samples because they're in an newer version of .NET.

It's surprising and looks like a problem related to LabelFor helper, not EA. Does the LableFor helper you're using cannot extract display name when such a field has multiple annotations attached to it? It would be quite unexpected. What ASP.NET MVC version are you using (EA has been tested on MVC4 and 5)? Is this LabelFor your custom extension or framework one?

I actually just noticed implementing the client-side validation (which I did this morning) broke all [RequiredIf] functionality, including the display name.
I referenced ExpressiveAnnotations.dll and ExpressiveAnnotations.MvcUnobtrusive.dll in my web app.
I added DataAnnotationsModelValidatorProvider.RegisterAdapter(typeof(RequiredIfAttribute), typeof(RequiredIfValidator)); to my Global.asax Application_Start().
And I included expressive.annotations.validate.js in a bundle after jquery.validate.js and jquery.validate.unobtrusive.js.
What did I do wrong?

Actually commenting all of that out and simply including the ExpressiveAnnotation DLLs in the web app project break [RequiredIf] for me.
I'm using .NET 4.5.

What ASP.NET MVC version?
I assume that the versions of dependencies on which EA relays are correct, i.e.

Newtonsoft.Json (≥ 4.5.11)
jQuery (≥ 1.8.2)
jQuery.Validation (≥ 1.10.0)
Microsoft.jQuery.Unobtrusive.Validation (≥ 3.1.1)

Here is what I have:
System.Web.Mvc.dll: <IP_ADDRESS>
Newtonsoft.Json.dll: 7.0.0
jquery-2.1.4.js
jquery.validate.js: 1.14.0
jquery.validate.unobtrusive.js: Inexplicably doesn't give the version
jquery.unobtrusive-ajax.js: Inexplicably doesn't give the version

Are you able to provide me explicit and tiny project (zip archive) where this single error is reproducible?

I'll see if I can create a new tiny project to reproduce sometime soon.

Due to the fact I'm unable to reproduce this issue, I'm closing it. If you find spare time to get back with required details in the future, reopen it please.


Missing defaults print schema

Description
Added a reproduction of a potential bug in the printSubgraphSchema from @apollo/subgraph. It seems the printing method doesn't include default values, where the printSchema from graphql does that. Please check this commit https://github.com/moonflare/pothos/commit/459b853389142cb85347a2cfc129c309ae166bfa to see the difference between the output of the two printing methods.

Also, not sure if this was intetional, but this PR is for the main branch of your fork, you'll need to open a new PR into the Pothos repo to get this merged.


API has no transactions endpoint or full block endpoint

The API endpoints don't include a transaction endpoint and also doesn't have an endpoint for the full block data (getblock rpc call)

Sorry, overlooked #61


Add merge-sorted, merge-sorted-by

Related: #147
Adds misc/merge-sorted and misc/merge-sorted-by to merge two arrays which are known to be in sorted order.
This is more convenient, and also faster than either:

concatenating the arrays, and applying sort to the result
splicing the second array into misc/insert-sorted

A side note: the parameter order for merge-sorted-by is consistent with insert-sorted-by. However, both are inconsistent with the core function sorted-by (or every -by function for that matter, the first parameter is always f).
It's probably better for parameter order to be consistent within a module, but perhaps both should be updated.


Code crushes when no DocComment provided

Line 90  https://github.com/meena-erian/implicit-sdk/blob/master/src/python/lib/implicit_sdk/implicit_endpoint.py#L90
AttributeError
'NoneType' object has no attribute 'split'
When there is no block comment at all provided for the method

resolved in version 0.1.10


Fix for #777 - Adds percent as an optional variable for the tooltip template

This lets you access the percentage of the segment as part of the tooltips via <%=percent%>
eg:
<%if (label){%><%=label%>: <%}%><%=percent%>%
Example output: 45%

Note that on further inspection of the Travis build failure, it seems the issue was  'valid' errored after 1.05 min connect ETIMEDOUT on NodeJS 0.10; but passing with flying colours on NodeJS 0.11.
The error on 0.10 seems to be more likely a transient Travis error, or that the environment for 0.10 is correctly configured.
Just though I'd defend my PR, haha.
Cheers,

@schme16 Do you think it makes sense to add this to polar area charts as well?
I think this can be merged. Any thoughts @tannerlinsley @jakesyl @fulldecent @nnnick @fntneves @derekperkins

@etimberg I think to add this to polar area would be nice, too.
@schme16 @etimberg I think toFixed(0) is quite strange, once we can easily notice the sum greater than 100%. Would be nice get 100% when we sum all partial areas, and leave the toFixed() argument as an  option with 2 as default, too. Thoughts ?

Sure, I only submitted a patch to add it to doughnut/our charts because that's what I was using ChartJS for at the time, but any of the percentage based charts should have access I think; keeps the expected experience the same not to mention the api a little more consistent.
Cheers

@fntneves @etimberg I think thats a fair change, you're right about it going above 100% occasionally. A toFixed(2) would be much more precise. Should we be passing it back as a float though or just leave it as a string (which is what toFixed does)?

+1 to merge.

@schme16 It's nice. Thanks ! Did you touch dist file ? If yes, what's the purpose ?

@fntneves Ahh, yeah sorry I pushed the dist files to my patch by mistake instead of my master; they can safely be discarded! (sorry about that, haha)

@schme16 That's right !
+1 to merge.

+1

We've recently announced a feature complete status for v1.x and will only be accepting bug fixes for v1.x. Be sure to take a look at v2.0-dev and it's new features that are either finished or currently under development.  If you see your feature is still not implemented, feel free to submit another PR to the v2.0-dev (or later) branch for your feature.


Specify it's a jQuery plugin at the top of your readme

and in Github's description input. Thanks

@englishextra why not open a PR?

@mattcdowning Because this particular matter is up to the author to decide. Perhaps they wont like it. I'm sure you know what I mean.