Reconsider 'overflow : hidden'

Currently all the widgets (.p-Widget) have overflow set to hidden. As a result any kind of overlay elements of children will be clipped.
We are facing this issue with integrating the monaco editor (e.g. hover, content assist, context menu, etc.). I see how you solved it for the code mirror completion widget, but unfortunately moving out such elements is not always possible.
I also can imagine that this could be a problem with other widget contents. Any ideas how this situation could be improved / solved?

Actually I think https://github.com/Microsoft/monaco-editor/issues/181 would be a preferred solution.


[ci] Set save location for JSON report files for CSCS

Adapt the production and maintenance execution modes

Currently all reports end up in Jenkins' user home.

Hello @vkarak, Thank you for submitting the Pull Request!

In the file config/cscs.py:

Line 1012:80: E501 line too long (109 > 79 characters)
Line 1014:37: W604 backticks are deprecated, use 'repr()'
Line 1028:80: E501 line too long (107 > 79 characters)

Do see the ReFrame Coding Style Guide

Codecov Report

Merging #1471 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   91.69%   91.69%
=======================================
  Files          82       82
  Lines       12852    12852
=======================================
  Hits        11784    11784
  Misses       1068     1068

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcff43...f177d0d. Read the comment docs.


Update to latest aws-sdk

→ Fixes issue with not being able to set Cloudfront DistributionConfig.Origins.Items[x].OriginPath. Previous aws-sdk would throw an "unexpected argument" error on OriginPath

Thank you :dancer:


make the preact as same as react in shouldComponentUpdate return value

Hey, l found there is some difference between React and Preact about shouldComponentUpdate.
if you return a value like '',0,false,NaN,undefined in React , they all skip render. but only false skip render in Preact.

Coverage remained the same at 100.0% when pulling 0cd851318db665a9790f91c4f34b4f9f88a3676b on huangming1994:master into 4bc9af44321e5e4c9fccf373d7e189fda8b7a635 on developit:master.

It's intended. See #898.

@yaodingyd Either i'm reading this wrong but i think the comment by @developit in #898 might come of as confusing. The intention seems to be to follow React in the heuristics of shouldComponentUpdate, which is appropriately matched by what @huangming1994 has presented.

@yaodingyd ok, l didn't see the issue. :D

Do we know what values React supports for this?  If anyone has time to set up a jsfiddle test, that would be useful.  If we're going to change Preact's behavior here, it only makes sense to bring it more in-line with React's.

Coverage remained the same at 100.0% when pulling 64cf30bba679ec27816b412d6c2955d1c8983c24 on huangming1994:master into 6f3e77f633f00982539536b186b10902c1b909df on developit:master.

As suggested here a jsfiddle.
Looks like react treats everything truthy as true and everything falsy as false.
Also react logs a warning Warning: TestComponent.shouldComponentUpdate(): Returned undefined instead of a boolean value. Make sure to return true or false. for undefined but not for other non boolean values 😕

What if we changed the check to this?  It'd get us 0, '', false equalling false:
&& component.shouldComponentUpdate(props, state, context) == false) {

This is fixed in Preact X :tada:


Use a requirements.txt file

We need a requirements.txt. The current file imports everything. I am not sure what is the purpose of this.
Would you mind if I replaced it with the following, @stefanpauliuk ?
In my case ODYM seems to work with the following (i.e. pip freeze output):
appnope==0.1.0
bleach==2.1.2
cycler==0.10.0
decorator==4.2.1
entrypoints==0.2.3
html5lib==1.0.1
ipykernel==4.8.2
ipython==6.2.1
ipython-genutils==0.2.0
ipywidgets==7.1.2
jedi==0.11.1
Jinja2==2.10
jsonschema==2.6.0
jupyter==1.0.0
jupyter-client==5.2.2
jupyter-console==5.2.0
jupyter-core==4.4.0
MarkupSafe==1.0
matplotlib==2.1.2
mistune==0.8.3
nbconvert==5.3.1
nbformat==4.4.0
notebook==5.4.0
numpy==1.14.1
pandas==0.22.0
pandocfilters==1.4.2
parso==0.1.1
pexpect==4.4.0
pickleshare==0.7.4
prompt-toolkit==1.0.15
ptyprocess==0.5.2
Pygments==2.2.0
pyparsing==2.2.0
python-dateutil==2.6.1
pytz==2018.3
pyzmq==17.0.0
qtconsole==4.3.1
scipy==1.0.0
Send2Trash==1.5.0
simplegeneric==0.8.1
six==1.11.0
terminado==0.8.1
testpath==0.3.1
tornado==4.5.3
tqdm==4.19.6
traitlets==4.3.2
wcwidth==0.1.7
webencodings==0.5.1
widgetsnbextension==3.1.4
xlrd==1.1.0
xlwt==1.3.0

This includes Jupyter. Without that it would be much less dependencies.

looks good! Is there a way to distinguish between the requirements for ODYM only and those for the Jupyther notebooks?

Well I guess the question is if we build upon Jupyter notebooks or not.
On my computer I have (at least) one environment per project. So, personally, I would be happy if Jupyter would get installed with it.
As discussed today, I will read up on this, but once we use something like pip, we probably don't really need this file anymore.

The alternative is that users are responsible for installing Jupyther, e.g., via the Anaconda distribution.
Main model scripts will likely be pure Python with lots and lots of heavy code but for tutorials Jupyther seems suitable.

I will come back to this after having a look at the tutorials this week

Hi,
Just a short interception from my side (since I get these issues in my inbox).
Based on my experience with pymrio and country_converter you should aim to get a package as soon as possible. It is not necessary that you upload that to pypi straight away, you can still just clone the repo and than do an
pip install FOLDER_OF_SOURCE
You can also do a
pip install -e FOLDER_OF_SOURCE
in which case your install will reflect the changes in the code you are doing.
This will solve your requirement issue and also the need for specifying where the source code is in the settings file. Otherwise, you are reinventing the wheel in a way the user would not expect... Once you are happy with the software, it is just one command to publish it on pypi and any user can install it with the same command without cloning from github.
You can check here for a minimal setup file to make a package:
https://github.com/konstantinstadler/country_converter
As I am not really involved in this software, I will unsusbscribe from these issues - however, you can still mention me with @konstantinstadler and I will have a look

@konstantinstadler Thanks for dropping in. This is very helpful. Stefan and I had this very discussion yesterday.
I like your suggestion and will read up on how to create packages. Are the packages managed in setup.py?

Yes.
It takes a little time to get your head around the concepts, but than you are surprised how easy it is.
This helped me to get started
https://tom-christie.github.io/articles/pypi/
Further background info you can find here

https://packaging.python.org/
https://the-hitchhikers-guide-to-packaging.readthedocs.io/en/latest/

Perhaps the easiest way to try these things would be to clone the country converter as a running example and play with it. You can alway get rid of installed packages by
pip uninstall package_name


Addition of SmoothMix Training in the Randomized Smoothing Module

Description

Added support for SmoothMix training on Randomized Smoothing classifiers.
Added a train_method argument in the fit method via kwargs with support for SmoothMix training.
Added additional params in the RandomizedSmoothingMixin and PyTorchRandomizedSmoothing modules with the parameters needed to train the classifier properly.
Implemented a fit_pytorch method that performs the SmoothMix training via PyTorch

Paper Link: https://arxiv.org/pdf/2111.09277.pdf
Code Repository based on paper: https://github.com/jh-jeong/smoothmix
Fixes # (issue)
Type of change
Please check all relevant options.

[X] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[ ] Test A
[ ] Test B

Test Configuration:

OS: Ubuntu 22.04 LTS
Python version: 3.7
ART version or commit number: 1.10.0
TensorFlow / Keras / PyTorch / MXNet version: PyTorch 1.11.0+cu113

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Hi @asarj Thank you very much for this draft pull request. I'll take look soon to follow your work. Please let us know if you have questions, etc.!

Codecov Report

Merging #1668 (bcb3988) into dev_1.11.0 (8f8039b) will decrease coverage by 15.60%.
The diff coverage is 93.12%.

@@               Coverage Diff               @@
##           dev_1.11.0    #1668       +/-   ##
===============================================
- Coverage       88.10%   72.49%   -15.61%
===============================================
  Files             259      261        +2
  Lines           21349    21500      +151
  Branches         3789     3810       +21
===============================================
- Hits            18809    15586     -3223
- Misses           1597     5116     +3519
+ Partials          943      798      -145

Impacted Files
Coverage Δ

...andomized_smoothing/smoothmix/smooth_pgd_attack.py
91.11% <91.11%> (ø)

.../randomized_smoothing/smoothmix/train_smoothmix.py
92.59% <92.59%> (ø)

...tors/certification/randomized_smoothing/pytorch.py
95.65% <94.73%> (-0.58%)
:arrow_down:

...ation/randomized_smoothing/randomized_smoothing.py
97.75% <100.00%> (+0.31%)
:arrow_up:

art/estimators/object_detection/utils.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/evasion/shapeshifter.py
5.89% <0.00%> (-93.30%)
:arrow_down:

art/attacks/evasion/carlini.py
7.59% <0.00%> (-87.07%)
:arrow_down:

art/attacks/evasion/pe_malware_attack.py
14.74% <0.00%> (-84.34%)
:arrow_down:

...s/extraction/functionally_equivalent_extraction.py
14.19% <0.00%> (-78.40%)
:arrow_down:

art/attacks/evasion/decision_tree_attack.py
23.28% <0.00%> (-76.72%)
:arrow_down:

... and 62 more

Thanks @beat-buesser! Tagging @keykholt and @rahmati so that they follow along with updates as well

Hi @asarj It looks like some commits unrelated to this PR got signed by the recent force push. Could you please use git cherry-pick to move your commits onto a clean local version of dev_1.11.0 and push it to your remote branch smoothmix?

Thanks for the heads up @beat-buesser, I've never used git cherry-pick before, but I think I addressed mistakenly signed commits by switching to the dev_1.11.0 branch, cherry-picking my commits specifically, and pushing that back to the smoothmix branch. Can you please take a look and let me know if this has been resolved?

Also @beat-buesser, do I need to address anything from the lgtm-com bot's recent comment on fixing one alert?

Hi @asarj Can you check the commits again, it looks like there are some unrelated commits left from May 8.
Can we implement SmoothMixPGD in art.attacks.evasion inheriting from  art.atttacks.attack.EvasionAttack?
Can we move the training procedure in to the fit method of the randomised smoothing estimator?
Should we create a separate estimator for SmoothMix? I think SmoothMix is adding a large umber of arguments to the randomised smoothing estimator which might make it more challenging to recognise which arguments are required for randomised smoothing.

@beat-buesser I can create a separate estimator for smoothmix and model this based on the randomized smoothing estimator and look into implementing SmoothMixPGD inheriting from art.atttacks.attack.EvasionAttack but this will take some time

Closing this because the changes have undergone a refactor based on recent feedback and are in a new PR found here: https://github.com/Trusted-AI/adversarial-robustness-toolbox/pull/1705#issuecomment-1131165716.


Build failing on Travis Docker image

Hello!
I know there are known issues with linux but I did not see this specific error when searching. We get this occasionally over on our Travis: https://travis-ci.org/roots/roots/jobs/48079124
><EMAIL_ADDRESS>install /home/travis/build/roots/roots/node_modules/gulp-sass/node_modules/node-sass
> node scripts/install.js
Binary downloaded and installed at /home/travis/build/roots/roots/node_modules/gulp-sass/node_modules/node-sass/vendor/linux-x64/binding.node
><EMAIL_ADDRESS>postinstall /home/travis/build/roots/roots/node_modules/gulp-sass/node_modules/node-sass
> node scripts/build.js
npm ERR! cb() never called!
npm ERR! not ok code 0

Full log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/48079124/log.txt

It does not seems to be a problem with node-sass, but npm cache issue. See http://stackoverflow.com/a/15483897/863980.
Apparently, the recent builds are not exhibiting the issue: https://travis-ci.org/roots/roots/builds.

Ah okay. It was a super infrequent issue anyway. Just wanted to make sure you guys had as much info as possible to debug your linux issues. Thank you!


Update latest version of PowerShell 6.2 to 6.2.3

https://github.com/PowerShell/PowerShell/releases/tag/v6.2.3

Closing as a dupe of #88


Add structured output for istioctl x precheck

Use Messages type to support structured output for istioctl x precheck in a way similar to istioctl analyze.
More details in #26199. Code logic has been noticeably changed and should require careful review.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@niwatorrri: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-notes_istio

release-test_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test release-test_istio

lint_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test lint_istio

integ-distroless-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-operator-controller-tests_istio

integ-pilot-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-pilot-k8s-tests_istio

integ-ipv6-k8s-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test integ-ipv6-k8s-tests_istio

unit-tests_istio
605339ebe7f1a3294d922c73f0229f6e22efc1fa
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[staging] pythonPackages.pyyaml: 5.3.1 -> 5.4.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ceph

@GrahamcOfBorg build ceph

@ofborg build ceph

@ofborg build ceph

@GrahamcOfBorg build awscli

@GrahamcOfBorg build awscli

seems ceph is broken for other reasons

seems ceph is broken for other reasons

This fixes CVE-2020-14343: https://github.com/yaml/pyyaml/blob/5.4.1/CHANGES

This fixes CVE-2020-14343: https://github.com/yaml/pyyaml/blob/5.4.1/CHANGES

@ofborg test awscli

@ofborg test awscli

I successfully ran the awscli test on my machine and built some other random packages.
However, I noticed that ddt fails: https://github.com/datadriventests/ddt/issues/95.

I successfully ran the awscli test on my machine and built some other random packages.
However, I noticed that ddt fails: https://github.com/datadriventests/ddt/issues/95.

I suggest we merge and fix stuff later if we notice major breakage on Hydra.

I suggest we merge and fix stuff later if we notice major breakage on Hydra.

20.09: https://github.com/NixOS/nixpkgs/pull/110525


Custom grid -- angular-ui-grid with angular-schema-form -- not working

Data Grid is on of the very common scenarios for any Web Page. I am trying to create a grid using angular-schema-form. This is how my schema looks and the form. Its not working. Can you please suggest where could i be wrong?
{
"schema": {
"type": "object",
"title": "Grid Schema",
"properties": {
"grid1": {
"type": "array",
"description": "An Grid.",
"items": [
"gridOptions", { "type": "object" }
]
}
}
},
"form": [
{
"key": "grid1",
"type": "simple-grid"
}
],
"model": {
"grid1": [
{
"name": "Exert",
"age": 55
},
{
"name": "Tiancum",
"age": 43
},
{
"name": "Jacob",
"age": 27
},
{
"name": "Nephi",
"age": 29
},
{
"name": "Enos",
"age": 34
}
]
}
}

"type": "simple-grid"
This isn't supported in ASF currently, you'd need to implement that as an addon.

Hi Simon,
Thanks for you reply.
I forgot to mention. I have created a custom template and registered in the bootstrap-decorator.
$templateCache.put("src/simple-grid.html", "
 {{form.title}}

");
I am not sure what else I need to do to make it working.

Hi All,
Can you please help with this? I also tried the below JSON Schema and did not work:
{
"schema": {
"type": "object",
"title": "Grid Test",
"properties": {
"Offerings": {
"type": "array",
"title": "Offerings Info",
"items": {
"type": "object",
"properties": {
"name": {
"title": "Name",
"type": "string"
},
"email": {
"title": "Email",
"type": "string",
"pattern": "^\S+@\S+$",
"description": "Email will be used for evil."
}
}
}
}
}
},
"form": [
{
"key": "Offerings",
"type": "array",
"items": [
"Offerings[].name",
"Offerings[].email"
]
}
]
}

Have you tried using bootstrap grid css styles, I think they are supported aren't they? Then just put that inside an array.

I tried a month ago but did not work.. Did it work for you?

@anupamarachuri I made an add-on for work that makes a basic data table, but unfortunately not of a high enough level of quality that I would release it into the wild

@Anthropic I'm trying to implement a very basic data table in a module I made. Could you share your code?


Could go.mod and go.sum be committed?

It seems that "go.mod" and "go.sum" are not committed.
When building operator with operator-sdk build  each time, the two files are generated and updated.
In my opinion, they should be committed as they're important for version selection.

I made a mistake. Forgot to unset GO111MODULE.


Run Keyword If changed to If causes test failures

Discovered with version 3.3.1.
Enabling 'Format on Save' in Visual Studio Code can produce an unintended side effect, which is that not only the formatting is changed but the keyword too, as below. Note that the Run Keyword If command has been changed to If, which was causing failures in test runs.
Unformatted (correct):
SSH Delete Folders If Exists
	[Arguments]     ${LOCAL_ADMINISTRATOR_PASSWORD}     ${PATH}

	${out}	${err}	${rc}=	Execute Command		cd ${PATH}/agent		return_stdout=True  return_stderr=True  return_rc=True
	Run Keyword If			${rc}==${0}			SSH Delete Folder		${LOCAL_ADMINISTRATOR_PASSWORD}		${PATH}/agent

	${out}	${err}	${rc}=	Execute Command		cd ${PATH}/MMS			return_stdout=True  return_stderr=True  return_rc=True
	Run Keyword If			${rc}==${0}			SSH Delete Folder		${LOCAL_ADMINISTRATOR_PASSWORD}		${PATH}/MMS

Formatted:
SSH Delete Folders If Exists

    [Arguments]    ${LOCAL_ADMINISTRATOR_PASSWORD}    ${PATH}

    ${out}    ${err}    ${rc}=    Execute Command
    ...    cd ${PATH}/agent
    ...    return_stdout=True
    ...    return_stderr=True
    ...    return_rc=True
    IF    ${rc}==${0}
        SSH Delete Folder    ${LOCAL_ADMINISTRATOR_PASSWORD}    ${PATH}/agent
    END

    ${out}    ${err}    ${rc}=    Execute Command
    ...    cd ${PATH}/MMS
    ...    return_stdout=True
    ...    return_stderr=True
    ...    return_rc=True
    IF    ${rc}==${0}
        SSH Delete Folder    ${LOCAL_ADMINISTRATOR_PASSWORD}    ${PATH}/MMS
    END

Hi, what kind of error did you get? Replacing Run Keyword If to If is done by Replace Keyword If transformer and it can be disabled. But IF syntax should work if you're using Robot Framework 4+.
And the reason why it is being replacing is that Run Keyword If is getting deprecated in favour for IF. There are other cases like this in robotidy, for example [Return] is replaced withRETURN in Robot Framework 5.0.+

Hi @bhirsz unfortunately we no longer have log files covering the test failures for the If keyword replacement, so I can't investigate the difference in behaviour. We weren't aware that this was an intended feature so obviously this led to the problem. Thanks for your explanation.


Ensure dist info is provided so pip recognizes installation

This addresses the concerns brought up in #84.
Official source install instructions for pyside instruct to use python setup.py install with a number of options.
Since we are installing to a particular location, we use cmake/make to install instead, which makes sense, but does not handle adding the dist-info folder which is what pip looks for to see that a package is installed.
This PR adds that by using the more targeted python setup.py dist-info.
To do so on py3.8/3.9, I had to disable the python version check in setup.py (which looks at classifiers, does not use python-requires), hence the additional patch file.
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Had to add an explicit gxx build dep for some reason that I do not fully understand.... (The setup.py dist_info calls failed without it, indicating gxx could not be run) If that is a problem, I can look into it more (perhaps an env var could be set or something).

@jschueller Do you have any opinions on this packaging change to allow pyside2 to integrate better on installed systems?

@jschueller thoughts?

@ksunden @jan-janssen would one of you be willing to become additional maintainers of this feedstock?

@ksunden @jan-janssen would one of you be willing to become additional maintainers of this feedstock?

Sure, I am happy to - I opened a corresponding pull request https://github.com/conda-forge/pyside2-feedstock/pull/95


Fix missing queue name enque! job in web portal.

@queue_name_with_prefix hasn't initialized properly.
[2] pry(#<Sidekiq::Cron::Job>)> self
=> #<Sidekiq::Cron::Job:0x007f9bd948f1a8
 @active_job=false,
 @active_job_queue_name_delimiter="",
 @active_job_queue_name_prefix="",
 @args=[{"type"=>"comments"}],
 @cron="* * * * *",
 @description="",
 @errors=[],
 @fetch_missing_args=false,
 @klass="Worker::FetchLoader",
 @last_enqueue_time=2016-09-22 19:14:21 +0800,
 @message="{\"retry\":true,\"queue\":\"comments\",\"class\":\"Worker::FetchLoader\",\"args\":[{\"type\":\"comments\"}]}",
 @name="comments_loader",
 @queue="comments",
 @status="enabled">

[3] pry(#<Sidekiq::Cron::Job>)> self.queue_name_with_prefix
=> "comments"
[4] pry(#<Sidekiq::Cron::Job>)> @queue_name_with_prefix
=> nil

Coverage increased (+0.3%) to 93.598% when pulling decf23c560bccbd75a86346dc4a571ec1b5ffe45 on farainc:master into f8c68a8c40edc80de683755071cd8dd68a24cb9e on ondrejbartas:master.

Coverage increased (+0.3%) to 93.598% when pulling decf23c560bccbd75a86346dc4a571ec1b5ffe45 on farainc:master into f8c68a8c40edc80de683755071cd8dd68a24cb9e on ondrejbartas:master.

Coverage increased (+0.3%) to 93.598% when pulling afff21945b3b4575084e026fc7fbb01a2f691453 on farainc:master into f8c68a8c40edc80de683755071cd8dd68a24cb9e on ondrejbartas:master.

Coverage increased (+0.3%) to 93.598% when pulling afff21945b3b4575084e026fc7fbb01a2f691453 on farainc:master into f8c68a8c40edc80de683755071cd8dd68a24cb9e on ondrejbartas:master.

@Junyulive what version of sidekiq cron do you use?

@ondrejbartas I just got the updates from the newest version (you did fixed the missing queue name bug). But I fixed an additional issue with the active job queue name (	Active job const set queue name without prefix).

+1

sorry for delay.. Thank you for your PR


App load testing and profiling

This PR contains some modifications to enable load-testing and profiling of the app.
The goal is to find out whether the app currently already shows severe bottlenecks for data IO, network, memory, and/or CPU usage.
Experiments
On my local machine I ran two different experiments using the flask/mysql Docker services. For the results I don't put absolute numbers since they'll be different/non-comparable when running the experiments with the app deployed to GAE or similar.

Load-testing using k6
Profiling the app

Load-testing

The scenario is a running server running the webapp, and several clients sending as many requests as possible. We want to find out about the throughput (requests / sec), and the latency (i.e. request waiting time for client == processing time for server)
I extended our Docker services to use the WSGI server gunicorn to resemble a production-level setup. For gunicorn, it's most important to tune its number of worker processes acc. the available CPU resources
I ran the load-testing.js script by k6 for several combinations of virtual users, requests (single beneficiary vs. page of 100 beneficiaries) and gunicorn settings. The duration of the load-test is 15s.
Result:

scaling workers in sensible manner improves both latency and throughput by a factor of 4
below some threshold (~nr of workers) increasing the number of users does not have an impact on app performance
latency for the beneficiaries query (50 DB rows read and returned) already noticeable: data IO plays a role

Follow-up:

various smart and performant worker classes (gevent, meinheld) can be used in combination with gunicorn
Flask as a framework already has some overhead when processing requests. More minimalistic frameworks like falcon show better performance but have a smaller community

Profiling

I wanted to find out more about the internal workings in the app during a request. I could hook in the built-in ProfilerMiddleware for Flask, and visualize the resulting profile files using tuna and snakeviz (showing the hierarchy of Python calls and their expense)
Findings:

for decoding the user JWT, we retrieve the public key of the boxtribute domain from Auth0. Like others we should consider hard-coding the public key in our codebase or providing it via an env variable at least
after having cut the public-key-retrieval overhead about 1/3 of the processing time is due to opening a MySQL connection at the start of processing the request. peewee provides support for connection pooling but it has to be evaluated how efficient this is in combination with Flask
the remaining processing time is mostly spent processing the actual database query
peewee caches rows returned by select queries. For large queries it is recommended to work-around this behavior
a query like bene = Beneficiary.get_by_id(id), followed by bene.base.id causes a full select of the Base model. Better be explicit and do Beneficiary.select(Beneficiary, Base.id).join(Base).where(Beneficiary.id == id).get(). This can avoid overhead, e.g. due to formatting datetime in peewee.

Conclusion
The requests used in the experiments are still fairly simply, and don't put the app under concerning pressure. Profiling revealed some overhead that we can easily reduce. I'm not sure how much benefit further optimizations (e.g. using an async framework) would bring (but they would take some effort for sure). On that topic, I found articles that question the performance of (and benchmarks issued by) async frameworks.
Follow-up questions:

How many (simultaneous) users do we currently have in dropapp?
What are the resources (CPU, memory) of the stack we deploy to?

 Research on async support for back-end

 Production-level optimizations for new app

I added follow-up trello cards (see above) and optimized some peewee queries for FK IDs. I think this is completed for now.
Mind to approve @vahidbazzaz @aerinsol or do you have more remarks?


How to read the code from image

I may have missed it in the readme or wiki, but how can we read / scan a qrcode image to read the code back ?
Thank you.

This library cannot read qrcodes. To read them have a look at reader libraries like ZXing.Net.


When Kafka is down, MT reporting healthy health check

Is this a bug report?
yes
Can you also reproduce the problem with the latest version?
yes
Environment

Operating system: Windows 10
Visual Studio version: Rider
Dotnet version: 5.0

Steps to Reproduce

Setup MT with Kafka rider
Add HealthChecks
Run app, check for /health/ready
Kill RMQ, check unhealthy status
Up RMQ and kill Kafka, check healthy status

Expected Behavior
When Kafka is down MT reporting unhealthy
Actual Behavior
When Kafka is down MT reporting healthy

I'm guessing topic consumers, and likely event hub consumers as well, aren't reporting to the health checks. Since they aren't receive endpoints.

I think we need to change a way how we start endpoints for riders, we should probably move to common approach when we have ReceiveTransport which is instantly monitoring endpoints and restart them. The possible issue could be with kafka which is suppressing all connectivity errors.

I also have seen the same behavior with MT not reporting a Kafka issue, But in my scenario, I only have producers configured.
services.AddMassTransit(cfg =>
{
    cfg.UsingInMemory();
    cfg.AddRider(riderCfg =>
    {
        riderCfg.AddProducer<MyMessageClass>("TopicName");
        riderCfg.UsingKafka((ctx, kfCfg) =>
        {
            kfCfg.UseHealthCheck(ctx);
            // setup host etc...
        });
}

@Excommunicated it is expected because you do not have topics, and kafka works as endpoint.

should be fixed by: https://github.com/MassTransit/MassTransit/pull/2182


SEPG Automated Release - v3.0.0

SEPG Details
Release Build Link: http://sou-jenkins2.swinfra.net:8080/job/Auto-Release/329/
Build Token: github.com/CAFapi/buildenv-dotnet-mono-image/main/3bb035e249919bf3d60da7125090a8d375f1bbf3
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/buildenv-dotnet-mono:3.0.0 (Static Tag)
cafapi/buildenv-dotnet-mono:3.0 (Dynamic Tag)
cafapi/buildenv-dotnet-mono:3 (Dynamic Tag)
cafapi/buildenv-dotnet-mono:latest (Dynamic Tag)

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


Added Logistic Regression

Added minimal logistic regression...

Great. Thanks for the contribution

Things to add in the future - Regularization, advanced optimization, and mini-batch stochastic gradient descent


feat(anvil): pretty print withdrawalsRoot

Closes #5142.
withdrawalsRoot was missing from the pretty print formatting.

did this fix the issue? I just pulled the latest version of foundry but I dont see withdrawalsRoot when I call:
cast rpc eth_getBlockByNumber $BLOCK_NUMBER false --rpc-url http://localhost:8545

It did—it's just not always set as the local chain won't have a withdrawals root set.


Problems with @:enum abstract

Using token-tree branch against this code:
package sx.properties;

/**
 * Indicates orientation.
 *
 */
@:enum abstract Orientation (String)
{

    var Vertical   = 'vertical';
    var Horizontal = 'horizontal';

}//abstract Orientation

leads to various exceptions:
	Error: LINE - 1: Checker - Check LeftCurly failed: bad token Kwd(KwdEnum) != Const(CIdent(_))
Stacktrace:
Called from TokenStream.hx line 33
Called from TokenTreeBuilder.hx line 95
Called from TokenTreeBuilder.hx line 39
Called from TokenTreeBuilder.hx line 23
Called from Checker.hx line 43
Called from checks/block/LeftCurlyCheck.hx line 62
Called from checks/Check.hx line 22
Called from Checker.hx line 155
	Error: LINE - 1: Checker - Check LeftCurly failed: bad token Kwd(KwdEnum) != Const(CIdent(_))
Stacktrace:
Called from TokenStream.hx line 33
Called from TokenTreeBuilder.hx line 95
Called from TokenTreeBuilder.hx line 39
Called from TokenTreeBuilder.hx line 23
Called from Checker.hx line 43
Called from checks/block/LeftCurlyCheck.hx line 62
Called from checks/Check.hx line 22
Called from Checker.hx line 155
	Error: LINE - 11: MemberName - Invalid member signature: Vertical (name should be ~/^__[a-z][a-zA-Z0-9]*$/)
	Error: LINE - 12: MemberName - Invalid member signature: Horizontal (name should be ~/^__[a-z][a-zA-Z0-9]*$/)
	Error: LINE - 1: Checker - Check NeedBraces failed: bad token Kwd(KwdEnum) != Const(CIdent(_))
Stacktrace:
Called from TokenStream.hx line 33
Called from TokenTreeBuilder.hx line 95
Called from TokenTreeBuilder.hx line 39
Called from TokenTreeBuilder.hx line 23
Called from Checker.hx line 43
Called from checks/block/NeedBracesCheck.hx line 50
Called from checks/Check.hx line 22
Called from Checker.hx line 155

Related rules:
{
            "type"  : "LeftCurly",
            "props" : {
                "severity" : "WARNING",
                "option"   : "eol",
                "tokens"   : [
                    "TYPEDEF_DEF",
                    "FOR",
                    "IF",
                    "WHILE",
                    "SWITCH",
                    "TRY",
                    "CATCH"
                ]
            }
        },
        {
            "type"  : "LeftCurly",
            "props" : {
                "severity" : "WARNING",
                "option"   : "nl",
                "tokens"   : [
                    "CLASS_DEF",
                    "ENUM_DEF",
                    "ABSTRACT_DEF",
                    "INTERFACE_DEF"
                ]
            }
        },
{
            "type"  : "MemberName",
            "props" : {
                "severity" : "ERROR",
                "format"   : "^[a-z][a-zA-Z0-9]*$",
                "tokens"   : [
                    "PUBLIC",
                    "TYPEDEF"
                ]
            }
        },
        {
            "type"  : "MemberName",
            "props" : {
                "severity" : "ERROR",
                "format"   : "^__[a-z][a-zA-Z0-9]*$",
                "tokens"   : [
                    "PRIVATE"
                ]
            }
        },
{
            "type"  : "NeedBraces",
            "props" : {
                "severity"                 : "WARNING",
                "allowSingleLineStatement" : true,
                "tokens"                   : ["IF", "FOR", "ELSE_IF", "WHILE", "TRY", "CATCH"]
            }
        },

Also all fields of such abstract declared like var SomeField = 'someValue' should be treated as enum fields, but now they are treated as private members. Please, notice that such abstracts can have other 'normal' fields as well. For example:
@:enum abstract MyAbstract(Int) from Int to Int
{
    static public inline var NORMAL_CONST = 'hello, world';

    var EnumConstructor1 = 1;
    var EnumConstructor2 = 2;
    var EnumConstructor2 = 3;

    static public function doSomething () : Void trace(NORMAL_CONST);
}

the stack trace was already fixed in a previous commit
I also added support for differentiating between class/interface and abstract members:
If you include CLASS along with PUBLIC or PRIVATE it will apply to classes and interfaces only.
if you use ABSTRACT and PUBLIC rules will only apply to public abstract fields.


Modify bookshelf setup and extend the README

When using the bookshelf, it would only read the config of postgresql, so I added an additional db key to the bookshelf config, which selects the client to be used (defaulted to sqlite, as it requires the least setup).
I also added MySql and SQLite clients to the package.json, since all the others are there as well.
I extended the README with some information that might not be so obvious without digging into the code or being familiar with some of the modules (using bookshelf, running migrations, installing dependencies, removing unused dependencies, accessing the application).

Looks good.


Add Login with Cognito and Microsoft buttons on UI

Canarybank UI app should have buttons to login via Cognito and Microsoft

how to accept the story?
url: https://canarybank.hexademo.org/
login with cognito and azure and you should be successfully authenticated with the credentials in each(cognito and azure). please make sure to logout after each attempt.


Task: Create dataframe of species locations in Arabian Sea and/or Bay of Bengal

https://seamap.env.duke.edu/
Here are some sea turtle species data available:

Looks like more data is available on the east coast of Africa.

The example data in /data/raw_bio should be fairly easy to load in. This format is similar to a Darwin Core occurrences.csv file.
"oid","longitude","latitude","providers","species","datasets","date_min","date_max","num_records","num_animals","num_species","y1_value","y2_value","y3_value","csquare","geom_wkt"
49450059,-179.5,-16.7,"The State of the World's Sea Turtles Team","Chelonia mydas","545","2006-01-01","2006-01-01",1,,1,,,,"5117:469:374","POLYGON((-179.4 -16.7,-179.4 -16.8,-179.5 -16.8,-179.5 -16.7,-179.4 -16.7))"
49450058,-179.3,-16.3,"The State of the World's Sea Turtles Team","Chelonia mydas","545","2006-01-01","2006-01-01",1,55,1,,,,"5117:469:132","POLYGON((-179.2 -16.3,-179.2 -16.4,-179.3 -16.4,-179.3 -16.3,-179.2 -16.3))"
40059319,-178.4,-30.2,"Graham Edgar, Institute for Marine and Antarctic Studies (IMAS), University of Tasmania (UTAS)","Chelonia mydas","103152531","2012-12-30","2012-12-30",1,1,1,,,,"5317:208:124","POLYGON((-178.4 -30.2,-178.4 -30.3,-178.5 -30.3,-178.5 -30.2,-178.4 -30.2))"
40060818,-178.0,-29.3,"Kevin Mackay, NIWA","Chelonia mydas","103152536","1905-05-23","1992-05-01",2,,1,,,,"5217:497:229","POLYGON((-177.9 -29.2,-177.9 -29.3,-178 -29.3,-178 -29.2,-177.9 -29.2))"

I created a file that gets the lat/long of the green turtles in the Arabian Sea and Bay of Bengal from the green_turtles.csv file, and I think it is in the right format to use with dismo. I'm not sure yet how to make distinction of if the turtle was on sea vs land, and currently looking for more datasets to add.

I initiated an export from OBIS for the following query:

I should be able to upload the 8554-line .csv shortly.

I initiated an export from OBIS for this query:

I should be able to upload the 8554-line .csv shortly.

How did you do this? (I did download from the link you posted, But I really want to know how you did this. I'm just so new to using OBIS...)


Extend UiSchema to allow objects not to be rendered.

This can be useful to not show all agents.

I'm not sure UiSchema should be adapted to this? If you want to customize on the object level (instead of class level), there are many other options that might come in handy, visibility is only one of them. For example, you might give each object a special color, or some text explaining it state, etc. I think these kind of things are interesting, but probably overextend the original intend of the UiSchema, which is (IMO) a quick and easy way to provided some kind of visualization. In case you want a more extensive visualization, I think creating your own Renderer implementation is the way to go. Although I agree that the Renderer system probably can be improved to more easily facilitate these kind of things.


High CPU consumption when internet connection is lost

Matthieu,
When the internet connection is lost, in client/socket/index.js , connectSocket() starts looping on  retry(), which results in a nasty CPU overhead.
To prevent it, I modified connectSocket() prototype, by adding a "retry tempo" parameter, so that updated code in index.js looks like that:

defining: const RETRY_TEMPO = 15*1000;
connectSocket(retry); becomes: connectSocket(retry, retryTempo);

retry(); becomes: setTimeout(function(){ retry(); }, retryTempo);

const socket = await connectSocket(retry); becomes: const socket = await connectSocket(retry, RETRY_TEMPO);

What do you think? I tested it and it works quite well.
I set the tempo to 15sec, even if it could be set at interface level by adding a new parameter to function connect().
Regards, Pedro.

Maybe it would be better to do it with an increasing timeout depending on the number of retries with a maximum value to avoid a too large timeout :
const retryTimeout = Math.min(retries * 1000, 30 *1000);

With this solution, we can reconnect instantly if the disconnection was just a temporary network failure instead of waiting for 15 seconds.

Feel free to submit a PR, if you have time to implement it !

In V1.1.4 the retryCount is never reseted :
The line retryCount = 0; // Reset retry count on successful in the socket.connect() connection has no effect, since the retryCount value will be taken from the last bind retry function :
// Retry on disconnect
  retry = connect.bind(
    this,
    payload,
    RequestType,
    preBuffer,
    NotificationSchema,
    keys,
    persistentIds,
    retryCount + 1
  );

I tried to find a "nice" solution based on current code (I would have submitted a PR), but I ended up with the solution I proposed in my first commit, here after:
[FIX] High CPU consumption when internet connection is lost #2, where it was based on defining "let retryCount = 0;" outside "async function connect()" scope..
🤔

I'm going to submit a PR..


JAMES-1678 Don't throw unsupported exception when collapseThreads is …

…false
rebased from : https://github.com/linagora/james-project/pull/118

already merged


Added del-cli and cross-env for package scripts to work on Windows

closes #39

Thanks. 👍

Note that I'm looking for active maintainers for the boilerplate. It likely does a little too much but some of the ideas are solid.

Thank you! I still don't feel confident enough to be able to maintain such a project and I don't create components so often as to use it much, but if I do get to the point of actually knowing what I am doing, I will gladly help!
BTW, I followed your webpack and react tutorials and I did promised (via Disquss) to buy you coffee if I was able to change jobs thanks to them... which I did, and I'd like to pay my debt now. How could I buy you a coffee / donate to any of your projects, if any?

BTW, I followed your webpack and react tutorials and I did promised (via Disquss) to buy you coffee if I was able to change jobs thanks to them... which I did, and I'd like to pay my debt now. How could I buy you a coffee / donate to any of your projects, if any?

I'm happy with the PR, thanks! Maybe you can buy a book from me unless you did already. 👍

I'll probably do that then! can you point me to the right link?

Here's the bundle. Note that the webpack book comes with some extra bits (poster, cheatsheet, QA with Tobias).
You can also find the webpack book on Kindle (about $10).

Done! Bought the React only but paid more than the minimum because I wanted you to have that coffee :D


Fix Day components validation check

Day components were triggering validation errors even when no validation was required. This was because of an inconsistent return value from the validateCustom method. This patch fixes this by returning the correct state object.

I see you've already done this in commit eee7455f70419c75ee63364e3c6affdf5e1e133d so I will close this PR

Thanks. I didn't see this before I fixed it otherwise I would have pulled this in!


sdr-<IP_ADDRESS> test suite failure

While packaging sdr in NixOS, we've encountered a somewhat mysterious test suite failure in our CI: http://hydra.cryp.to/build/795272/log/raw. Do you happen to have an idea why that test suite reports a failure?

Its difficult to know for sure without the test log. I use the test suite to test signal processing code written in C that uses SIMD instructions including AVX2. My guess would be that as AVX2 is relatively new, the instruction set is not supported on your CI server.
I plan to implement checks for AVX, SSE, etc in the near future, which should eliminate this problem.

I have implemented the checks. Did this resolve the problem?

I've enabled the test suite again in https://github.com/peti/nixpkgs/commit/d7004bb6c89e84c2f5d0e65e5a4cf517c5a6c8bf. I'll let you know what comes out of it ASAP. Right now, we cannot build sdr, unfortunately, because GLUtil won't cope with recent versions of hpp.


[QUESTION] Log level when using as NestJS app logger

I'd like to use this as a NestJS app logger as described here: https://github.com/iamolegga/nestjs-pino#usage-as-nestjs-app-logger
How can I specify the log levels and other configuration?

You can specify log levels via configuration of LoggerModule: https://github.com/iamolegga/nestjs-pino#asynchronous-configuration please see https://github.com/iamolegga/nestjs-pino#configuration-params for more details

You can specify log levels via configuration of LoggerModule: https://github.com/iamolegga/nestjs-pino#asynchronous-configuration please see https://github.com/iamolegga/nestjs-pino#configuration-params for more details

Is it level or useLevel?
From https://github.com/iamolegga/nestjs-pino#asynchronous-configuration
         pinoHttp: { level: config.level },

From https://github.com/pinojs/pino-http#pinohttpopts-stream
...
useLevel: the logger level pino-http is using to log out the response. default: info
...

@dlecan this two different options

useLevel: the logger level pino-http is using to log out the response. default: info

level sets level for logger, so only logs with level >= options.level will be emitted. I recommend read the docs of pino first

Also worth noting, the NestJS repl uses its own logger, so the pino logging config does not seem to be used (and hence any logger that might have been specified in that config.)


fix: gracefully handle process kill

Fixes #406

Why was stop service not working properly?
SIGKILL is sent by std::process::Child::kill(&self) and the FastAPI server is hosted in a child process, hence killing the parent just causes a reparent to current process, and doesn't kill the child process spawned by Python. While killing the prem-app cleans them up.
This is cause, the process groups aren't initialized for std::process::Command for grouped signal dispatch.
Possible Solutions
There are two solutions,

Use process groups for each command (CommandGroup?), to broadcast SIGKILL command to the entire process tree for the quiting command.
Use SIGTERM instead for then the process will be responsible to handle the resource cleanup, this also ensures no broken resources will be left behind that could be removed by the process.

We picked solution 2.

Fixes #437

Ensure on quit operation we gracefully stop all services
This should already be handled because the terminal session will start it in a process group that ensure all the process will be killed if they haven't been detached but currently it doesn't guarantee deterministic behaviour.
Possible Solutions
There are two solutions,

Before application quit call stop_all_services.
Before binary exit or panic of any kind try to call stop_all_services.

We picked solution 1 + 2 (just to ensure we always call stop_all_services).
Cons
Because we handle panics and exits with custom code that code itself "can" "theoritically" panic and cause a panic during a panic, which means a direct abort leading to no stack trace being reported.
This should currently not happen as the code called in such contexts is panic-free, and hence should be safe behaviour but letting people know just in case we ever introduce a panic to the code, it should be easier to debug.

When service Mistral Orca is running, calling restart causes error Service with mistral-7b-openorca already exist.
It seems that running_services is not cleared properly.


Multi-user support?

Can libstreaming support multiple users?
When a new client connect the server,the previous one is closed.
How to implement multi-user connection like RSTP streaming in VLC ?

I have the same question, too.Can anyone help us?

Seems this one not answered yet.
I also wonder how to do the multi user support.
Looks someone has the answer here.
http://stackoverflow.com/questions/27058706/multiple-libstreaming-streams-only-recognized-as-session-of-first-rtsp-client
But looks it;s not a simple modification. In the current api each time a request come it tries to initialize the camera also. Which thorws camera in use error.
Any one has a solution?

This is a really old question...
I solved it by sending packets to a broadcast IP. Besides, you need a server to dispatch SDP(session description) info. The clients open SDP files with VLC, it works.
The solution is ugly, though.

Thank you very much for the answer. Seems you managed to solve it somehow.
Though, the question is old but no proper solution yet. If you could share your work that would be a great help for me and the community. You will save lot of time of myself and other programmers who look for the same answer.
Thank again LangleyChang

If my solution could help,

Firstly, set your IP address as "<IP_ADDRESS>" of

session.getSessionDescription()
This is my Old code

Here's my old code for it, but honestly, the code is really ugly and I guess you may get confused...
You must be aware that broadcast packets challenges the router and it could cause a crash in the network.
Anyway, if my solution really helps, it is as following :

Firstly, set your IP address to "<IP_ADDRESS>" or some other broadcast IPs.

Then build up a session as usual.After that, you can get SDP as a string by calling session.getSessionDescription().
The above two steps correspond to the normal way to build up a sessoin.

As far as I know, this SDP string can identify a session. You just save it into a .sdp file and then open it with VLC.This player is amazing because it parses the file and connect the RTSP server (libstreaming) automatically. So, the problem is to send the .sdp file to clients, and I build up another socket server for it.

In conclusion, the server builds up a session and start to send broadcast packets.Then you build up another server to dispatch SDP strings obtained from session object.
The clients connect to the latter server firstly to fetch the SDP string and save it as a .sdp file.Then, open the .sdp file with VLC. All done~
Forgive me but I'm not a native English speaker.And anywhere unclear, feel free to reply.

Thanks Zhehua Chang, your solution works!
Bit slow but works. :) The only issue is the writing to the broadcast ip.
*As another approach, I have tried to write the buffer into two sockets.
Managed to get the frames in two clients. But has so problems. *
*Here I did the modifications in the AbstractPacketizer class
and H264Packetizer class. Created two **RtpSocket and buffer instances. *
*Anyone tried this before? *
2016-01-28 15:41 GMT+05:30 Zhehua Chang<EMAIL_ADDRESS>
Here's my old code https://github.com/Oo-Dev/OoDroid2 for it, but
honestly, the code is really ugly and I guess you may get confused...
You must be aware that broadcast packets challenges the router and it
could cause a crash in the network.
Anyway, if my solution really helps, it is as following :

Firstly, set your IP address to "<IP_ADDRESS>" or some other broadcast IPs.

Then build up a session as usual.After that, you can get SDP as a
string by calling session.getSessionDescription().
The above two steps correspond to the normal way to build up a sessoin
https://github.com/Oo-Dev/OoDroid2/blob/master/app/src/main/java/org/oo/oodroid2/OoDroidActivity.java#L100
.

As far as I know, this SDP string can identify a session. You just
save it into a .sdp file and then open it with VLC.This player is
amazing because it parses the file and connect the RTSP server
(libstreaming) automatically. So, the problem is to send the .sdp file
to clients, and I build up another socket server for it.

In conclusion, the server builds up a session and start to send broadcast
packets.Then you build up another server to dispatch SDP strings obtained
from session object.
The clients connect to the latter server firstly to fetch the SDP string
and save it as a .sdp file.Then, open the .sdp file with VLC. All done~
Forgive me but I'm not a native English speaker.And anywhere unclear, feel
free to reply.
—
Reply to this email directly or view it on GitHub
https://github.com/fyhertz/libstreaming/issues/93#issuecomment-176102877
.

@zhehuaz @ft816806 @deshan @brunosiqueira @serpro
I don't have any server. I would like to make my own device as server and let multiple clients see streams in VLC player.
Any suggestions, how to I achieve that?

@zhehuaz
您可以用中文详细描述下您上面的做法吗？我没大看明白，大致感觉你说的是多播（组播）。

Here's my old code for it, but honestly, the code is really ugly and I guess you may get confused...
You must be aware that broadcast packets challenges the router and it could cause a crash in the network.
Anyway, if my solution really helps, it is as following :

Firstly, set your IP address to "<IP_ADDRESS>" or some other broadcast IPs.
Then build up a session as usual.After that, you can get SDP as a string by calling session.getSessionDescription().
The above two steps correspond to the normal way to build up a sessoin.
As far as I know, this SDP string can identify a session. You just save it into a .sdp file and then open it with VLC.This player is amazing because it parses the file and connect the RTSP server (libstreaming) automatically. So, the problem is to send the .sdp file to clients, and I build up another socket server for it.

In conclusion, the server builds up a session and start to send broadcast packets.Then you build up another server to dispatch SDP strings obtained from session object.
The clients connect to the latter server firstly to fetch the SDP string and save it as a .sdp file.Then, open the .sdp file with VLC. All done~
Forgive me but I'm not a native English speaker.And anywhere unclear or better approaches, feel free to reply.


⚠ Secret Website 3 has degraded performance

In fe04457, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2603 ms

Resolved: Secret Website 3 performance has improved in 13a2f65.


With argument autocompletion, context is not passed properly

I used the current master revision:
$ pip3 install git+https://github.com/pallets/click.git@55682f6f5348f5220a557f89c3a796321a52aebf

and an executable file testclick:
#!/usr/bin/env python3
import click

def _complete(ctx, args, incomplete):
    return ctx.obj['completions']

@click.group()
@click.pass_context
def entrypoint(ctx):
    pass

@entrypoint.command()
@click.argument('arg', type=click.STRING, autocompletion=_complete)
@click.pass_context
def subcommand(ctx, arg):
    print('arg={}'.format(arg))

entrypoint(obj={'completions': ['abc', 'def', 'ghi', ]})

and enabled bash completion with
eval "$(_TESTCLICK_COMPLETE=source ./testclick)"

Now I am getting an error when trying to use autocompletion:
    $ ./testclick subcommand <TAB>Traceback (most recent call last):
  File "./testclick", line 23, in <module>
    entrypoint(obj={'completions': ['abc', 'def', 'ghi', ]})
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/core.py", line 731, in __call__
    return self.main(*args, **kwargs)
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/core.py", line 701, in main
    _bashcomplete(self, prog_name, complete_var)
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/core.py", line 46, in _bashcomplete
    if bashcomplete(cmd, prog_name, complete_var, complete_instr):
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/_bashcomplete.py", line 216, in bashcomplete
    return do_complete(cli, prog_name)
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/_bashcomplete.py", line 205, in do_complete
    for item in get_choices(cli, prog_name, args, incomplete):
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/_bashcomplete.py", line 186, in get_choices
    ctx, all_args, incomplete, param))
  File "/home/user/testclick/venv/lib/python3.6/site-packages/click/_bashcomplete.py", line 124, in get_user_autocompletions
    incomplete=incomplete)
  File "./testclick", line 7, in _complete
    return ctx.obj['completions']
TypeError: 'NoneType' object is not subscriptable

Expected behavior was to get a list of completions abc def ghi.
I am using Python 3.6.4

Im currently not able to test my idea, so please excuse me if for just thinking out loud. :wink:
Instead of passing the settings dict to entrypoint you could try passing it to the context_settings kwarg of the .group or .command function.
Refer to the documentation for details:
http://click.pocoo.org/5/commands/#context-defaults

Alright, in that case I have another idea:
Are you sure that the kwarg obj to entrypoint should get passed to the context?
After having a glimps at the implementation of pass_context I would suspect, that obj={...} just get passed to the wrapped function and is not used any further. The context is passed as the first argument to the decorated function without any interaction with the other arguments it would seem.
The source code I am refering to is in decorators.py.

I don't understand what LuckyJosh is getting at.
The custom context with obj attached is normally created in BaseCommand.main(). The problem is that in autocomplete mode, _bashcomplete() gets called before execution of context-creation code, and creates its own context instead.
It looks to me like we want BaseCommand.main() to create its context in all circumstances, and pass it to _bashcomplete().
Related: #930

To be clear, this issue limits the functionality of #755. Until it is fixed, autocompletion callbacks have no clean way to access shared network resources.

anyone found a workaround on this ?
for now i'm doing things like this to at least init state based on env variables before calling out:
def get_entities(ctx, args, incomplete):
    if not hasattr(ctx, 'server'):
        ctx.server = os.environ.get('HASS_SERVER', const.DEFAULT_SERVER)

    if not hasattr(ctx, 'token'):
        ctx.token = os.environ.get('HASS_TOKEN')

    if not hasattr(ctx, "timeout"):
        ctx.timeout = os.environ.get('HASS_TIMEOUT', const.DEFAULT_TIMEOUT)

    try:
        x = req(ctx, "get", "states")
    except HTTPError:
        x = None

    entities = []

    if x is not None:
        for entity in x:
            entities.append((entity["entity_id"], ''))

        return [c for c in entities if incomplete in c[0]]
    else:
        return entities

this lets the autocompletion work but its unforunate I have to relist the defaults and env parameters here. would be so much nicer if there was a way click could pass the right context or i at least could call something to generate the proper config/context.
thx!

Is there any update on this issue?

I'm facing this issue too.
For now, my workaround is to factor out the ctx.obj creation code and call it from both cli() and the corresponding autocomplete methods.
# cli() function
@click.group
@click.pass_context
def cli(ctx):
    ctx.obj = create_context_object()

# example autocomplete function
def get_completion(ctx, args, incomplete):
    if ctx.obj is None:
        ctx.obj = create_context_object()


Add labels/annotations to container status

Found this one while testing kubectl logs with #162
Signed-off-by: Mrunal Patel<EMAIL_ADDRESS>

LGTM

LGTM


Fix empty api page

Issue #25
Fixes the api page on readthedocs being empty.

This PR also improves the docstring of a few pages.


feat: validate local and external references

validate external references

external url is invalid

external url leads to invalid json-schema file

relative external url but invalid $id

validate internal references

TODO:

validate anchor fragments
look for optimizations

solves #7

Sorry, but that's not what is meant by "external reference". It means external to the schema document, not external to the workspace. I wasn't thinking about fetching schemas over HTTP and at this point and I don't want to go there. There are complications involved in doing that right that we don't want to deal with right now. For this task, you should only be considering schemas defined in the workspace or pre-registered in @hyperjump/json-schema like the meta-schemas.
my-project/schemas/address.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/address",

  ...
}

my-project/schemas/customer.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/customer",

  "type": "object",
  "properties": {
    ...,
    "address": { "$ref": "/schemas/address" } <-- External reference to a schema in the workspace
  }
}

Sorry, but that's not what is meant by "external reference". It means external to the schema document, not external to the workspace. I wasn't thinking about fetching schemas over HTTP and at this point and I don't want to go there. There are complications involved in doing that right that we don't want to deal with right now. For this task, you should only be considering schemas defined in the workspace or pre-registered in @hyperjump/json-schema like the meta-schemas.
my-project/schemas/address.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/address",

  ...
}

my-project/schemas/customer.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/customer",

  "type": "object",
  "properties": {
    ...,
    "address": { "$ref": "/schemas/address" } <-- External reference to a schema in the workspace
  }
}

Ahh! Got it!
will make the necessary changes. I was also a little skeptical when fetching schemas over http, should've asked beforehand my bad 😅

Sorry, but that's not what is meant by "external reference". It means external to the schema document, not external to the workspace. I wasn't thinking about fetching schemas over HTTP and at this point and I don't want to go there. There are complications involved in doing that right that we don't want to deal with right now. For this task, you should only be considering schemas defined in the workspace or pre-registered in @hyperjump/json-schema like the meta-schemas.
my-project/schemas/address.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/address",

  ...
}

my-project/schemas/customer.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/customer",

  "type": "object",
  "properties": {
    ...,
    "address": { "$ref": "/schemas/address" } <-- External reference to a schema in the workspace
  }
}

What exactly is workspace, is it just a folder containing many schema.json files ? If we open a folder in an IDE and the folder has many schema.json files and with them it has another folder which also has schema,json files then how will the workspaces be defined here?

What exactly is workspace

"Workspace" is an LSP concept. Open a directory in vscode and look at the file tree for that directory. That's your workspace. Everything that's visible to the IDE/editor is your workspace.

What exactly is workspace

"Workspace" is an LSP concept. Open a directory in vscode and look at the file tree for that directory. That's your workspace. Everything that's visible to the IDE/editor is your workspace.

ok! Just a little confused.
let's consider this example.
my-project/schemas/b.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/c",

  ...
}

my-project/schemas/c.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/b",

  ...
}

my-project/schemas/a.schema.json
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/a",
  "type": "object",
  "properties": {
    ...,
    "address": { "$ref": "/schemas/b" }
  }
  ...
}

is the ref in my-project/schemas/a.schema.json pointing to the file at /schemas/b.schema.json or /schemas/c.schema.json since c.schema.json has the id of /schemas/b

If you haven't read Structuring a Complex Schema on the website, definitely do that. It should help with the basic concepts.
There are two schema identification concepts. One is the retrieval URI and the other is self-identification.
Because these are files that exist on the file system, they have a file: URI that identifies them by their location on the file system. LSP uses this URI to identify files in the workspace. An example would be file:///path/to/my-project/schemas/a.schema.json.
However, JSON Schema also defines a way for schemas to declare their own identifier in addition to the natural identifier they get based on their file system location. This is done this using the $id keyword (id in draft-04). When a schema self-identifies, it effectively has two identifiers: the one it declares and it's file system location. LSP understands the natural identifier, but the self assigned identifier, so you need to implement that somehow.
So, going to your example,
LSP-ID: file:///path/to/my-project/another-folder/b.schema.json
Self-ID: https://example.com/schemas/c
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://example.com/schemas/c",
...
}
LSP-ID: file:///path/to/my-project/another-folder/c.schema.json
Self-ID: https://example.com/schemas/b
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://example.com/schemas/b",
...
}
LSP-ID: file:///path/to/my-project/schemas/a.schema.json
Self-ID: https://example.com/schemas/a
{
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "https://example.com/schemas/a",
"type": "object",
"properties": {
...,
"address": { "$ref": "/schemas/b" }
}
...
}
The question is, what does the reference at /properties/address resolve to. $id doesn't just assign an identifier to the schema, it also sets the base URI. So, the URI-reference /schemas/b is resolved against the https://example.com/schemas/a to get https://example.com/schemas/b. There is only one schema identified by that exact URI and that's the one located at /path/to/my-project/another-folder/c.schema.json.
Now consider if the schema at /path/to/my-project/schemas/a.schema.json didn't self-identify (didn't have a $id). How would that change how the reference resolves? Let's also change the reference to ../another-folder/b.schema.json to make the result interesting. Since there's no $id, the base URI is file:///path/to/my-project/schemas/a/schema.json and it resolves to file://path/to/my-project/another-folder/b.schema.json. This resolves the schema that self-identifies as https://example.com/schemas/c.

If you haven't read Structuring a Complex Schema on the website, definitely do that. It should help with the basic concepts.
There are two schema identification concepts. One is the retrieval URI and the other is self-identification.
Because these are files that exist on the file system, they have a file: URI that identifies them by their location on the file system. LSP uses this URI to identify files in the workspace. An example would be file:///path/to/my-project/schemas/a.schema.json.
However, JSON Schema also defines a way for schemas to declare their own identifier in addition to the natural identifier they get based on their file system location. This is done this using the $id keyword (id in draft-04). When a schema self-identifies, it effectively has two identifiers: the one it declares and it's file system location. LSP understands the natural identifier, but the self assigned identifier, so you need to implement that somehow.
So, going to your example,
LSP-ID: file:///path/to/my-project/another-folder/b.schema.json Self-ID: https://example.com/schemas/c
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/c",

  ...
}

LSP-ID: file:///path/to/my-project/another-folder/c.schema.json Self-ID: https://example.com/schemas/b
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/b",

  ...
}

LSP-ID: file:///path/to/my-project/schemas/a.schema.json Self-ID: https://example.com/schemas/a
{
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "$id": "https://example.com/schemas/a",
  "type": "object",
  "properties": {
    ...,
    "address": { "$ref": "/schemas/b" }
  }
  ...
}

The question is, what does the reference at /properties/address resolve to. $id doesn't just assign an identifier to the schema, it also sets the base URI. So, the URI-reference /schemas/b is resolved against the https://example.com/schemas/a to get https://example.com/schemas/b. There is only one schema identified by that exact URI and that's the one located at /path/to/my-project/another-folder/c.schema.json.
Now consider if the schema at /path/to/my-project/schemas/a.schema.json didn't self-identify (didn't have a $id). How would that change how the reference resolves? Let's also change the reference to ../another-folder/b.schema.json to make the result interesting. Since there's no $id, the base URI is file:///path/to/my-project/schemas/a/schema.json and it resolves to file://path/to/my-project/another-folder/b.schema.json. This resolves the schema that self-identifies as https://example.com/schemas/c.

got it! I almost wrote another huge example, but I read the comment once again and now I completely get it!
Thank you so much, I will finish this ASAP!

I think I'm done with all the tasks and my PR is ready for review!!

https://github.com/hyperjump-io/json-schema-language-tools/assets/61962871/76f57e5b-a54d-43d4-952c-4c9d51c501c8
https://github.com/hyperjump-io/json-schema-language-tools/assets/61962871/2193cbcf-c4da-4f36-a658-605862b80dfb
Here are the demo videos! @jdesrosiers

Please rebase and resolve conflicts. Also, make sure you run tests locally to make sure they pass before pushing. Don't rely on automation.

Please rebase and resolve conflicts. Also, make sure you run tests locally to make sure they pass before pushing. Don't rely on automation.

The failed checks don't seem to be related the changes I made. Could you please take a look?

It's definitely related to your changes. The tests pass on "main".

Thanks for pointing that out @jdesrosiers
I made the necessary changes, tests should pass now.

Got it. Yes I forgot about those cases.
That's exactly what I was thinking a couple hours ago when I stumbled upon #17 , I also feel the same. I will definitely decouple the logic.

I will get on that asap!

Hey @jdesrosiers , I have refactored my solution more.
I have removed the identifiers store but I have kept the inactiveDocumentStore , since that caches the documents which are not  open in the editor and saves a lot of io operations. and the instances are removed from the inactiveDocumentStore once those are open in the editor.

I have made some changes, please take a look @jdesrosiers !

Seems like there are a lot of changes made for schema resources :sweat_smile:
I'll update my PR or maybe open a new one at this point :sweat_smile:

Yes, sorry. There was a big change introducing a more powerful and performant AST for working with schemas that replaced JsoncInstance. The change is preparing for supporting more advanced features like linting.

Closing in favor of #44


Improvement in  the Contact section

Describe the feature
We can add some border effects and also a hover effect to make the contact form look better ,
Kindly Assign me this Issue under GSSOC, I would like to work on it.
Add ScreenShots
Before:

After:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Describe the feature
We can add some border effects and also a hover effect to make the contact form look better , Kindly Assign me this Issue under GSSOC, I would like to work on it.
Add ScreenShots
Before:

After:
Record

[x]  I agree to follow this project's Code of Conduct
[x]  I'm a GSSOC'24 contributor
[x]  I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


ESLint doesn't work

from .vimrc:
set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 1
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0

let g:syntastic_python_python_exec = '/path/to/python3'

let g:syntastic_python_checkers = ['pep8']
let g:syntastic_javascript_checkers = ['eslint']

It checks Python with PEP8, but doesn't check JavaScript. When I type :SyntasticInfo javascript if prints
Syntastic version: 3.6.0-92 (Vim 704, Linux)
Info for filetype: javascript
Global mode: active
Filetype javascript is active
Available checkers: -
Currently enabled checkers: -

it doesn't see eslint
however, eslint works well from the terminal (I've installed it with npm install -g eslint)
P. S. OS Debian Jessie
P. P. S. Excuse me if my English isn't very well

Please open a JavaScript file, set g:syntastic_debug to 33, run :SyntasticInfo, run :mes, and post the output.

@lcd047 I don't now how why, but when I set syntastic_debug to 33 it started to work well
thank you :)

Hi, I have the same issue : Here is what is in the :mes after doing
g:syntastic_debug to 33,
Syntastic version: 3.6.0-93 (Vim 704, Linux)
Info for filetype: javascript
Global mode: active
Filetype javascript is active
The current file will be checked automatically
Available checkers: eslint jscs
Currently enabled checkers: -

The eslint checker is available but not enabled.
However, in my .vimrc, I have let g:syntastic_js_checkers = ['eslint']
and if I do :echo g:syntastic_js_checkers, I get back ['eslint']

If I force to use eslint by running : :SyntasticCheck eslint , I get back the right errors, strangely. So it seems it's only the "enabling" that doesn't work.

I've removed jshint and jscs from my system, and now I get :
syntastic: 14.964734: getcwd() = '/home/edi9999/projects/test'
syntastic: 14.965139: CacheErrors: Checker javascript/jshint is not available
syntastic: 14.965331: CacheErrors: Checker javascript/jslint is not available
syntastic: 14.965516: CacheErrors: no checkers available for javascript

It seems that syntastic has cached the linters I would like to use, is they some way to clean that cache ?

@netei Please see #1440.

Great, works !


.ve footer & .background's color

May I add .ve footer for the juncture's logo, license etc. to all pages? I have tried but nothing.
Same question for the background to all pages.

Solved


Test Message are blocked by scroll bar

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.67.2 (user setup)
Commit: c3511e6c69bb39013c4a4b7b9566ec1ca73fc4d5
Date: 2022-05-17T18:15:52.058Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22000
Steps to Reproduce:

When the test messages in the peek are longer than the widget width, it will be blocked by the scroll bar (See the first line in the below video)

https://user-images.githubusercontent.com/6193897/172131221-1b0e697f-176a-44ec-8cd0-c47c9d93cec0.mp4

@connor4312 I just see this horizontal scrollbar that doesn't do anythin

Now I only see the text wrap, is there a way for the scrollbar to show up, or is that the fix?

I don't think the horizontal scrollbar should ever show up, unless you make a single long word for example

Oh right. Both work great


Update mongodb-shard.conf.erb

fix the bind_ip usage in mongdb-shard.conf.erb, it is defined as array in manifests but config file wants it as a string ( comma separated list of ip adresses )

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Good catch. There are tests for server:
https://github.com/voxpupuli/puppet-mongodb/blob/6f48eddb3606ac5b3b377ebda575dd480ed2f8a0/spec/classes/server_spec.rb#L119-L142
However, these don't exist for mongos. Could you add these so we don't risk this in the future?


Tabs Native base 3

How do I place the tabs at the bottom with native base 3.0.3 and put icon with tab

@yaderlacayo tabs are still under development and not recommended in production application.
Currently, recommended approach is to use a different package or create your own using Layout components (HStack, Box).
I am closing this issue, will notify here once we release Tabs officially :)


DxcNumberInput calls onChange function with '' when "." character is entered

Describe the bug
Not sure if it's a bug or I'm doing something wrong with the component.
When you type:

"1," ->  the component transform this value into "1". It can make sense because as you din't type the fractional part it will return the integer one.
"1." -> the component transforms this value into "". It can make sense but I would expect the same behaviour as "1,".

It's not a big thing but as I'm creating my own validations, the user will receive an error like "value is required" even if he enters a value like "1.".
To Reproduce

Include a DxcNumberInput in your code, like:

() => {
  const [value, setValue] = useState("");
  const onChange = ({ value }) => {
    setValue(value);
  };
  const onBlur = ({ value }) => {
    setValue(value);
  };

  return (
    <DxcInset space="2rem">
      <DxcNumberInput
        label="Enter your age"
        value={value}
        onChange={onChange}
        onBlur={onBlur}
        optional={false}
        clearable={true}
      />
    </DxcInset>
  );
}

Set a breakpoint in onChange function to check the received value.
Enter "1." and check the received value.

Expected behaviour
I would expect:

Component will transform "1." value to "1", similar to the current behaviour when typing "1,".

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Using halstack-react version 9.1.0.
"@dxc-technology/halstack-react": "^9.1.0"
Add labels
Add any applicable label like the concerned components or the target version of the Design System where the bug has been found.

Hi @fredofm!
First of all, sorry for the late response. This is a fair request, I'm currently working on it.
I've reproduced the error. It looks like it is a bug from the HTML <input type=" number" />, which understands the comma as a decimal number when there are no decimals at all (1,, 12,, 4483,, ...) but doesn't apply the same logic on the dotted ones.
Is this a very important fix for you guys? If so, we can work on a patch to address it.
Code example
const App = () => (
        <input
          type="number"
          onChange={(event) => {
            console.log(event.target.value);
          }}
        />
);

Hello again @fredofm!
No problem, I will create an issue for that feature and we will add it to our roadmap as soon as possible. I will keep you updated!
Thanks for all the feedback 🚀


update mailman to version 3.2.2

I would normally not merge a major version bump from Mailman 2.x to 3.x to a stable release branch, but I am pretty sure that nobody has been using this package. It was never in a usable shape without major glue code and/or a NixOS module. I'd like to remedy those issue now and I'd rather start that effort based on a current version of Mailman.

You might want to have a look at a very hacky version of a mailman 3 module:
https://github.com/mayflower/nixexprs/blob/master/modules/mailman3.nix

You might want to have a look at a very hacky version of a mailman 3 module:
https://github.com/mayflower/nixexprs/blob/master/modules/mailman3.nix

Very cool, thank you for the pointer!

I'm not sure I really understand why for release-19.03, especially when 19.09 isn't that far off (branch-off in 11 days).

I'm not sure I really understand why for release-19.03, especially when 19.09 isn't that far off (branch-off in 11 days).

Yeah, that is a good point. I had not considered that 19.09 is not that far away, really. I guess I can simply develop that code on master now and run my mail server on the 19.09 test branch once it's created.

Superseded by https://github.com/NixOS/nixpkgs/pull/67708.


Grey-out/highlight unused variables

An IntelliJ Idea feature which would be incredibily handy in VS code

This would be a nice addition, tracking in #16


[mmloader] Add new port

This PR adds a new port: http://tishion.github.io/mmLoader/

Hi @myd7349 thanks for this PR.
I noticed that this port failed on x64-windows-static triplet from CI test result:
-- Performing post-build validation
Expected Debug,Static crt linkage, but the following libs had invalid crt linkage:

    C:/vsts/_work/3/s/packages/mmloader_x64-windows-static/debug/lib/mmLoader-static-x64-v142-d.lib: Debug,Dynamic

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Expected Release,Static crt linkage, but the following libs had invalid crt linkage:

    C:/vsts/_work/3/s/packages/mmloader_x64-windows-static/lib/mmLoader-static-x64-v142.lib: Release,Dynamic

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Found 2 error(s). Please correct the portfile:
    C:\vsts\_work\3\s\ports\mmloader\portfile.cmake

Could you try to fix it?

/azp run

/azp run

Hi @myd7349
Could you please resolve the conflicts?

Hi! @NancyLi1013 Sorry for the long delay. The conflict has been resolved.

Thanks for your update.
Could you address the review suggestions?

/azp run

@myd7349
All seem to be good now except for the patch.
Since there are many changes in this patch.
Could you please submit these changes to upstream?

Hi! @NancyLi1013 Thanks for your help and sorry for the long delay, I have created an issue in the upstream: https://github.com/tishion/mmLoader/issues/18.

Hi everyone, i just know that you are working on adding the mmLoader to vckpg. Thanks for the work, I understand what you are doing, and I am joining to finish this work gracefully with you.
I will apply the patch to the original repo and make commit for this PR soon (within 24 hours).
Thanks

@myd7349 beg your pardon, I submitted a new PR to adding the mmloader as a new port here: #11381 .
I just reconstructed the project with CMake build so that the port file can be very clean and tidy.
Hope this is good to everyone.
Thanks

Hi! @tishion Thanks for your quick reply and kindly help.
Close PR in favor of #11381 .


Spanner gapic migration error augmentation with interceptor

Add SpannerInterceptorProvider
Move LoggingInterceptor outside GrpcSpannerRpc and make it a separate class
Use SpannerInterceptorProvider to do logging and error augmentation in GapicSpannerRpc

@pongad gax isn't released yet so this PR does not compile now. Can you take a look and see if the overall idea works? I'll release gax afterwards.

PTAL @garrettjonesgoogle @snehashah16


added a phase coverage vetter

A start on a simple coverage vetter. It still needs to be added to the vetters.py and tests moved to the correct place.
EDIT: Fix #22

Tip: Instead of "do not merge" label, which still allows accidental merging, it is safer to turn this into a draft PR, which disables the merge button completely. When you are ready, you can convert it to a "normal" PR with one click. This does not affect the CI. I'll turn it into a draft PR for you now.

I'll try to remember that (assuming I can find the button). I'm not sure how I see how to change it back to a normal PR,  so when the time comes I'll need you to show me that one click button.

It is the "Ready for Review" button.

We will save creating the vetting class for another pull request.


Pressing o in the cell configuration panel collapses the panel

It seems that VS Code has a keybinding for closing cells when pressing the o key:

This is not an ideal user experience when editing cell configurations.

It turns out that this behavior originates from the Jupyter Keymap extension and the only way to suppress this is by overwriting the keybindings. I raised an issue asking whether they could very the kernel before executing the command to allow us to remove these overwrites.

I'm getting a warning that the noop command does not exist, @christian-bromann?

@sourishkrout I don't see that warning on my end, can you please check again? this seems GTG

Confirmed 👍


Throwing error that 'window is not defined' while rendering in server.

You should add a check for window in order to make it compatible for server side rendering.
Please add typeof window !== 'undefined' in file lib/components/SweetAlert.js in line no. 23

fixed in published version 2.1.0


Yubikey support?

Any thoughts on integrating https://github.com/Yubico/yubikit-ios to support Yubikeys similar to what Brave did at https://github.com/brave/brave-ios/pull/1158?

Looks interesting, thanks for the heads up.  Think I'll buy myself a YubiKey to play around with. :)

Hey @jplock! We're gonna sit tight on this one for now, since full WebAuthn support is on the WebKit roadmap for this year:

Parity goals include WebAuthn for all WKWebViews

Thanks for the suggestion. I'd love to have YubiKey support too, so here's hoping that WWDC brings us some good news. 🙂


fix: reload page after burning

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[x] Bugfix
[ ] Feature
[ ] Refactoring

What's new?

[x] PR closes #3466
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 50 usd


Do not end \item with \.

Issue's in the title, really. Do not do this.

Unless this is really a Pandoc issue, at which point I am simultaneously ashamed and enraged. :smile:

Can you post an example document and point out the problem?

Huh, it doesn't seem to do this anymore. Did you recently update pandoc? (And given that you use pandoc internally to do the conversion, I don't see it as your issue anyway.)

That's odd. Please let me know if you see this happen again, I can try fixing this at the editor level.

If I ever see it again, I'll take whatever kind of snapshot information I can find and give you the heads-up :)


Provide nicer implementation of publishLocal / skip for 2.0.x series

As noted by https://github.com/sbt/sbt/pull/7165#discussion_r1123429285, there is a nicer implementation possible for the solution in that PR however it wasn't possible to cleanly implement due to an already existing deprecated function (see https://github.com/sbt/sbt/blob/51da437f22506cfedf73abfbf5a33e969f64f548/main/src/main/scala/sbt/Defaults.scala#L3582-L3587).
Since its possible to remove that deprecated function in the 2.0.x series, once the https://github.com/sbt/sbt/pull/7165 is merged into the 2.0.x branch a nicer implementation can be made

I will assign this to myself, just ping me when that PR gets merged into 2.0.x

just ping me when that PR gets merged into 2.0.x

@eed3si9n that's not how it works in this repo is it?

develop branch is intended to be sbt 2.x so all we need to do is git merge. (I'm doing that for 2.x to make it easier to maintain 3 branches)

I have https://github.com/sbt/sbt/pull/6746 as pull request open, which I think needs to be reviewed by @adpi2 and others?