Telework: 3+ day Supervisor notification email URL to approve is not linked

Background:
When a supervisor receives a email to approve a 3+ day telework request the URL to approve is not linked

Steps to Reproduce:

make a telework request for 3+ days
review supervisor email
In the After obtaining proof of ADM (or delegate) approval section, check first bullet

Open the request at this link: https://digital-journeys.apps.silver.devops.gov.bc.ca/task/eaaca67f-a5b9-11ee-98f5-0a580a618238
Actual Behavior:
URL is displayed, but it is not linked
Expected Behaviour:
URL should be linked to help supervisor find and get to the form needing approval
Environment:
PROD
TEST

@Stella-Archer I turned the link into words and made it into a hyperlink so the manager can just click it for occasional, <3 days and >=3 days . Can you test this and let me know if you want me to change the text and the links work.

Sweet this is looking great - goes right to the review and process tab :)
for occasional or 3 days it perfect -
Unfortunately the 2 days email is wrong - you do NOT need ADM approval/upload for that

this is what the 2 day request should look like replacing the URL with 'review the submission' linked would be super nice it looks way cleaner, scans easier

Updated the less than 3 day request. Weirdly the original one I was working with had the adm requirement, but I removed it :).

Less than 3 days, has been updated! Thank you, Andrew :)

Perfect - ready to deploy

It's LIVE and it rocks!


Custom-markers does not support zoom-to-include-markers

With common markers you can use zoom-to-include-markers to fit the bounds of the map. Actually, this does not work with custom-markers. As a workaround I have to set the center and bounds programmatically.

+1

@cogidoo Do you have an example of your solution? I've got problems with the process order, my function, triggert on the event "mapInitialized" after filtering the markers on the map looks like
    function fitMap() {
        var bounds = new google.maps.LatLngBounds();
        angular.forEach(vm.map.markers, function(marker) {
            if (marker.getVisible()) {
                bounds.extend(marker.getPosition());
            }
        });
        vm.map.setCenter(bounds.getCenter());
        vm.map.fitBounds(bounds);
    }

@solidevolution I create the custom-markers with ng-repeat over a list. So when I change that list, I also call setCenter and fitBounds - like you do. But I iterate over my list-items and take the position from there.
Do you really work with custom-markers? Because custom-markers a stored at vm.map.customMarkers.

@cogidoo I use markers, no custom-markers but with ng-repeat.
How do you listen for ng-repeat changes on markers?

@solidevolution You may wanna take a look at this: http://plnkr.co/edit/7b8ngAD85BjBniAFNEWU?p=preview
At the end of the function switchList I would do something like this:
var bounds = new google.maps.LatLngBounds();
_.forEach($scope.devices, function(d) {
    var latlng = new google.maps.LatLng(d.attributes.lat, d.attributes.lng);
    bounds.extend(latlng);
});

$scope.map.setCenter(bounds.getCenter());
$scope.map.fitBounds(bounds);

+1

ng-map does not officially support MarkerClusterer, but only support official Google Maps APIs. MarkerClusterer is community driven feature. So, it's out of scope.
However, there is not much to lose trying this, but less priority.
We will mark it as enhancement and tackle it later

added this feature with release 1.14.3.


Can't anymore test ARM and uARM toolchain

After the merge #1691 it's not anymore possible to use the command singletest.py with both uARM and ARM toolchain. The ARM part fail build when uARM is also used. If ARM is used alone, no problem.
The problem come from arm.py. The ARM_STD and ARM_MICRO class share a reference self.flags to DEFAULT_FLAGS and when ARM_MICRO object is created, it add, amongst others, --library_type=microlib in the DEFAULT_FLAG and then in the self.flags of ARM_STD object.
A fix could be to copy the DEFAULT_FLAGS line 57.
self.flags = copy.deepcopy(self.DEFAULT_FLAGS)

Another problem is that the uARM toolchain is always in timeout. Can you verify this point ?
exemple with nucleo_l031k6 :
report_issue_l031k6.zip

Hi @svastm, I'm having trouble reproducing your issue on the K64F. Are you using the latest master? If so and you're still seeing the same issue, could please post the following info?

The platform you're testing
The commands you're using
The errors you're seeing
The version of armcc you're using

I have the issue with, at least, NUCLEO_L031K6. and the updated master (HEAD: 9cef243de23875778f461bbe9a8c1bc47e65212b) when I use the following command:
python ..\mbed\workspace_tools\singletest.py --auto -f NUCLEO_L031K6,NUCLEO_L053R8,NUCLEO_L073RZ,DISCO_L053C8 --parallel --tc uARM,ARM,IAR,GCC_ARM --global-loops=1 --clean -j 4 -c copy -V -v --report-html=.\reports\report__2016-05-04_<IP_ADDRESS>__L0__common__ALL.html -C

with armcc version <IP_ADDRESS>.
During an ARM_STD compilation, I have the following line where the options --library_type=microlib and -D__MICROLIB should not be present.
Compile: main.cpp
[DEBUG] Command: C:\Keil\ARM\ARMCC\bin\armcc -c --gnu -Otime --split_sections --pcs=interwork --brief_diagnostics --restrict --multibyte_chars --cpu=Cortex-M0 -O3 --cpu=Cortex-M0 -O3 --cpu=Cortex-M0 -O3 --cpu=Cortex-M0 -O3 --md --no_depend_system_headers -IC:\Keil\ARM\ARMCC\include --c99 -D__ASSERT_MSG --library_type=microlib -D__MICROLIB --library_type=microlib -D__MICROLIB --cpp --no_rtti -D__ASSERT_MSG --library_type=microlib -D__MICROLIB --library_type=microlib -D__MICROLIB -D__CORTEX_M0 -DTEST_SUITE_UUID="67e26a5a-17ca-40cf-8ca4-988dac97eda9" -DTARGET_FF_ARDUINO -DTEST_SUITE_TARGET_NAME="NUCLEO_L031K6" -DTARGET_CORTEX_M -DTARGET_LIKE_MBED -DARM_MATH_CM0 -DTOOLCHAIN_ARM_STD -DMBED_BUILD_TIMESTAMP=1462360969.32 -DTARGET_STM32L0 -DTARGET_STM -D__MBED__=1 -DTARGET_M0 -DTARGET_STM32L031K6 -DTEST_SUITE_TEST_ID="MBED_37" -DTARGET_NUCLEO_L031K6 -DTOOLCHAIN_ARM -DTARGET_LIKE_CORTEX_M0 -IC:\Users\xxx\github\mbed\libraries\tests\mbed\serial_nc_rx -IC:\Users\xxx\github\mbed\libraries\tests\mbed\serial_nc_rx -IC:\Users\xxx\github\mbed\build\mbed -IC:\Users\xxx\github\mbed\build\mbed\TARGET_NUCLEO_L031K6 -IC:\Users\xxx\github\mbed\build\mbed\TARGET_NUCLEO_L031K6\TARGET_STM -IC:\Users\xxx\github\mbed\build\mbed\TARGET_NUCLEO_L031K6\TARGET_STM\TARGET_STM32L0 -IC:\Users\xxx\github\mbed\build\mbed\TARGET_NUCLEO_L031K6\TARGET_STM\TARGET_STM32L0\TARGET_NUCLEO_L031K6 -IC:\Users\xxx\github\mbed\build\mbed\TARGET_NUCLEO_L031K6\TOOLCHAIN_ARM_STD -IC:\Users\xxx\github\mbed\libraries\tests\mbed\env -o C:\Users\vansons\github\mbed\build\test\NUCLEO_L031K6\ARM\MBED_37\.\main.o C:\Users\xxx\github\mbed\libraries\tests\mbed\serial_nc_rx\main.cpp --depend C:\Users\xxx\github\mbed\build\test\NUCLEO_L031K6\ARM\MBED_37\.\main.d

Then the link fail :
Link: serial_nc_rx
Error: L6218E: Undefined symbol __initial_sp (referred from entry2.o).
Error: L6218E: Undefined symbol __heap_base (referred from malloc.o).
Error: L6218E: Undefined symbol __heap_limit (referred from malloc.o).
Finished: 0 information, 0 warning and 3 error messages.

@svastm Thanks for reporting, I'll have a look at those microlib flags

Should be fixed. I was able to run uARM test, and also both ARM and uARM. Please verify, and reopen with more info if this problem persists.
Thanks for the description with the solution for this bug, appreciated :+1:


setView map property

The docs say that the map component has a property called 'setView' that is the callback function for setView, trigged on the map's 'moveend' event; however, it doesn't seem to work for me.

I modified the basic example to demonstrate this, by adding the following around line 185:
  const handleSetView = () => {
    console.log('moveend');
  };

  const handleClick = () => {
    console.log('clicked');
  };

  // place the map on the page.
  ReactDOM.render(
    <Provider store={store}>
      <RendererSwitch setView={handleSetView} onClick={handleClick}>
        <SdkScaleLine />
        <SdkMousePosition
          style={{
            position: 'absolute',
            top: 20,
            right: 12,
            zIndex: 1,
            width: '5em'
          }}
        />
        <SdkZoomControl />
        <SdkZoomSlider />
      </RendererSwitch>
    </Provider>,
    document.getElementById('map')
  );

Demonstration: https://github.com/cartolab-gis/sdk/blob/set-view-bug/examples/basic/app.js
The onClick callback works as expected, but there is no console message when I change the view of the map.

yeah the docs are wrong here, we need to suppress those props from the documentation, as they are populated by redux
what is it you want to achieve?

You should be able to subscribe a listener to the store instead and look for the MAP_SET_VIEW type actions instead and do something there, see also: https://egghead.io/lessons/javascript-redux-wrapping-dispatch-to-log-actions

Okay, thanks.  I'm trying to subscribe to that event so I can wait and apply a bbox query to a REST endpoint that sends too much data otherwise.  Good advice on subscribing to the store.  Thanks!

Closing this one @brambow let me know if you can't get it to work by reopening if needed


Try out the kick-starting section

If you are on macOS or Linux, you can try out the kick-starting section and report if that succeeds or not.

NODE=targets/node-v9.2.0 ABI=59 make `(uname -s)`
g++ -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -std=c++17 -I uWebSockets/uSockets/src -I uWebSockets/src src/addon.cpp -stdlib=libc++ -mmacosx-version-min=10.7 -undefined dynamic_lookup -I $NODE/include/node -o dist/uws_darwin_$ABI.node
clang: warning: argument unused during compilation: '-undefined dynamic_lookup' [-Wunused-command-line-argument]
src/addon.cpp:173:47: error: 'isolate' cannot be captured because it does not
      have automatic storage duration
    uWS::Loop::defaultLoop()->setPostHandler([isolate](uWS::Loop *) {
                                              ^
src/addon.cpp:5:10: note: 'isolate' declared here
Isolate *isolate;
         ^
1 error generated.
make[1]: *** [Darwin] Error 1
make: *** [default] Error 2

Thanks try again now

Cool, builds now
$ node -v
v9.2.0
$ node examples/HelloWorld.js
/Users/len/playground/uWebSockets.js/dist/uws.js:8
		throw new Error('This version of µWS is not compatible with your Node.js build.');
		^

Error: This version of µWS is not compatible with your Node.js build.
    at module.exports (/Users/len/playground/uWebSockets.js/dist/uws.js:8:9)
    at Object.<anonymous> (/Users/len/playground/uWebSockets.js/dist/uws.js:10:3)
    at Module._compile (module.js:641:30)
    at Object.Module._extensions..js (module.js:652:10)
    at Module.load (module.js:560:32)
    at tryModuleLoad (module.js:503:12)
    at Function.Module._load (module.js:495:3)
    at Module.require (module.js:585:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/len/playground/uWebSockets.js/examples/HelloWorld.js:2:23)

The same on node 10, mac OS

g++ -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -std=c++17 -I uWebSockets/uSockets/src -I uWebSockets/src src/addon.cpp -I $NODE/include/node
g++ -flto -O3 *.o -std=c++17 -shared -static-libstdc++ -static-libgcc -s -o dist/uws_linux_$ABI.node
make[1]: Leaving directory `/www/repos/uWebSockets.js'
NODE=targets/node-v10.0.0 ABI=64 make `(uname -s)`
make[1]: Entering directory `/www/repos/uWebSockets.js'
gcc -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -I uWebSockets/uSockets/src uWebSockets/uSockets/src/*.c uWebSockets/uSockets/src/eventing/*.c
g++ -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -std=c++17 -I uWebSockets/uSockets/src -I uWebSockets/src src/addon.cpp -I $NODE/include/node
g++ -flto -O3 *.o -std=c++17 -shared -static-libstdc++ -static-libgcc -s -o dist/uws_linux_$ABI.node
make[1]: Leaving directory `/www/repos/uWebSockets.js'
NODE=targets/node-v11.1.0 ABI=67 make `(uname -s)`
make[1]: Entering directory `/www/repos/uWebSockets.js'
gcc -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -I uWebSockets/uSockets/src uWebSockets/uSockets/src/*.c uWebSockets/uSockets/src/eventing/*.c
g++ -DLIBUS_USE_LIBUV -flto -O3 -c -fPIC -std=c++17 -I uWebSockets/uSockets/src -I uWebSockets/src src/addon.cpp -I $NODE/include/node
g++ -flto -O3 *.o -std=c++17 -shared -static-libstdc++ -static-libgcc -s -o dist/uws_linux_$ABI.node
make[1]: Leaving directory `/www/repos/uWebSockets.js'
for f in dist/*.node; do chmod +x $f; done

node examples/HelloWorld.js
Listening to port 3000
Timers will not work until us_loop_integrate is done

Running 30s test @ http://<IP_ADDRESS>:3000/hello
  20 threads and 10000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    49.00ms   78.12ms   1.88s    98.87%
    Req/Sec     9.21k     3.09k   27.88k    74.81%
  5497186 requests in 30.09s, 550.47MB read
  Socket errors: connect 0, read 1797, write 0, timeout 56
Requests/sec: 182679.97
Transfer/sec:     18.29MB

Mac os full error (i have printed e from catch method)
Error: dlopen(/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws_darwin_64.node, 1): no suitable image found.  Did find:
	/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws_darwin_64.node: unknown file type, first eight bytes: 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00
	/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws_darwin_64.node: unknown file type, first eight bytes: 0xDE 0xC0 0x17 0x0B 0x00 0x00 0x00 0x00
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:718:18)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at module.exports (/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws.js:5:15)
    at Object.<anonymous> (/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws.js:13:3)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws.js:11
		throw new Error('This version of µWS is not compatible with your Node.js build.');
		^

Error: This version of µWS is not compatible with your Node.js build.
    at module.exports (/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws.js:11:9)
    at Object.<anonymous> (/Users/dmitrii/Desktop/github/uWebSockets.js/dist/uws.js:13:3)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/Users/dmitrii/Desktop/github/uWebSockets.js/examples/HelloWorld.js:2:23)

Yeah that's the same error I have heard about before. Something is wrong with the macOS build.

Ah, lol.. I haven't even updated the Makefile since.. ever

Yep. Am on node 11.1.0 on OSX High Sierra. Getting same error as @goriunov. Will try it also on Linux (Alpine under Docker) as it's quite a popular deployment option, and report any issues (if any) with that env.

Alright, should be close to working now. This code only works with Node.js 10 and 11

$ node -v
v11.1.0
$ node examples/HelloWorld.js
Segmentation fault: 11

$ node -v
v10.10.0
$ node examples/HelloWorld.js
Segmentation fault: 11

:ok_hand:

If you change the HelloWorld.js to only this:
var uWS = require('../dist/uws.js');
console.log(uWS);
Does it print { App: [Function], nextTick: [Function] }?
Does uWS.App(); work?

@alexhultman it does not go farther then
const uWS = require(`./uws_${process.platform}_${process.versions.modules}.node`);

I have tied running
module.exports = (() => {
	try {
		console.log("1");
		const uWS = require(`./uws_${process.platform}_${process.versions.modules}.node`);
		console.log("2");

		/* We are not compatible with Node.js domain */
		// console.log(uWS);
		process.nextTick = (f, ...args) => uWS.nextTick(f.apply(...args));
		return uWS;
	} catch (e) {
		console.log("3", e);

		throw new Error('This version of µWS is not compatible with your Node.js build.\n\n' + e.toString());
	}
})();

and output is
Dmitriis-MacBook-Pro:uWebSockets.js dmitrii$ node examples/HelloWorld.js
1
Segmentation fault: 11

Yeah I need to check this out. Too bad Apple computers are priced in a way that it makes no logical sense to ever buy them. At least the Swedish prices are simply unreal - 125% or 150% that of US prices.
 You can have much more joy with four stolen cars I tell you...

 I have tracked seg fault to (not sure if i aright though):
localApp->SetAlignedPointerInInternalField(0, new uWS::App());

It runs on Linux and macOS now

Working alright :)

Works on mac for me too 💯

@tleasure those numbers seem very reasonable. On Linux I get multiple times better IO compared to Node.js,
But on macOS it seems like the difference is not all that great - can macOS people try and compare the IO of hello world with nodejs?
Maybe it's just Linux being a lot more efficient than macOS as a system (wouldn't surprise me at all)?

I've heard 90k req/sec vs. 52k on macOS yet on Linux you can see more like 120k vs. 20k. Let's see if this ratio difference is same for all

If you normalize spent CPU-time the numbers are a lot better. Basically it seems wrk does not stress the server fully on macOS for some reason, I only get up to 62% CPU time. You can also extra check this by running:
time node examples/HelloWorld.js and compare real-time with user space + system time and normalize by that.


CI: Add coala-ci checks

gitmate is behaving weird recently, we need a run of coala itself as a fallback.

@Makman2  Is this done with the current PR(https://github.com/coala/corobo/pull/437) ?

No this issue is about adding a call to coala in our CI, so we don't rely only on gitmate (as it recently failed to flag issues in code recently).

@Makman2  Adding docker run coala/base coala --ci to .travis.yml would work?

Maybe :)

@Makman2 , I believe that travis and semaphore are both already running coala checks.
https://github.com/coala/corobo/pull/454#issuecomment-348787642
.travis.yml and .ci/semaphore.tests.sh omit GitCommitBear with sed -i.bak '/bears = GitCommitBear/d' .coafile , and that is due to a bug in coala-bears.

Oh do you have the issue link maybe? In that case let's quickly resolve that issue and close this one ;)

@Makman2 https://github.com/coala/coala-bears/issues/1037

Bug is bogus.


enable preview from sanity

@tompahans
I have prepared a feature for enableing preview mode from sanity.
To better understand the code you can read the following resources. Then you can merge the PR.
The complete tutorial that is the source
https://www.sanity.io/guides/nextjs-live-preview
Api-routes in Next.js
https://nextjs.org/docs/api-routes/introduction
Built in preview mode in Next.js
https://nextjs.org/docs/advanced-features/preview-mode
Next.JS automatic-static-optimization
https://nextjs.org/docs/advanced-features/automatic-static-optimization


fix: fix class cast exception seen on MySQL plugin when built on local setup

Description

Currently, when Appsmith API server is built on local setup on console or on IntelliJ and we try to create connection to a MySQL db via MySQL plugin then a ClassCastException is thrown as described here.
This PR attempts to resolve the issue by excluding the conflicting packages from MySQL r2dbc driver package as described in the link above.

Fixes #11385
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manuall on console and IntelliJ

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=dbb4eb7

/ok-to-test sha=99e806d

/ok-to-test sha=4e938d6

I have found that the earlier change was
<exclusion>
             <groupId>io.netty</groupId>
             <artifactId>*</artifactId>
</exclusion>

and the later change is
<dependency>
            <groupId>io.netty</groupId>
            <artifactId>netty-all</artifactId>
            <scope>provided</scope>
</dependency>

@sumitsum Can you please state the reason behind this change?

Skipped the test plan approved label since it is a POM file change.

@subrata71 the core issue that was ocurring was a conflict between the netty-all package provided by the r2dbc package and the one that was provided by the API server. The first change removed the netty-all package that was being imported as part of the r2dbc package - this resolved the conflict. However, for some reason the GitHub CI was failing because if required the netty-all pagckage for mysql tests during the test run time - not sure why - this failure is not seen on my local set. Hence I added the netty-all package with the provided scope - which means that the mysql plugin would fetch the netty-all package from the overall dependency tree when required.


Fix wikipedia

Problem
Wikipedia demo has been broken
Solution
Clean up the Wikipedia demo, get some rules working across both Twitter and Wikipedia
Result
Second demo is running in case Twitter one breaks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.089%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/sqrl/src/function/DataFunctions.ts
1
2
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
15801

Relevant Lines:
24117

💛  - Coveralls


Preparation Metadata: Proteomics

[x]  Identify metadata components that need captured at PNNL (what isn't captured by DMS) (August)
[ ]  Identify metadata components captured by DMS that are required when data is received from other institutions
[x]  Generate metadata template (September)
[ ]  Check & confirm missing components once template and example are complete (@SamuelPurvine , @pdpiehowski ) (October)

Moving to the October sprint per Slack message from Montana

Moving to the November sprint per Slack message from Montana

Adding backlog label and removing from sprints per slack message from @mslarae13
FYI @SamuelPurvine


fix nongraph joins. common query builder. Support for waterline unit tests + more operators and functions.

Now passes 119 out of 180 waterline-adapter-tests (v0.11.2).
I'm raising this PR initially for comment (not expecting you to simply merge this - as I think you would need to test against your own use cases).
I'd like to add gulp driven mocha unit-testing so we can develop our own unit-tests (on top of the waterline-adapter-tests - as arangodb has features beyond basic waterline functionality, e.g. graphs).
Please let me know your thoughts...

Hey @gbevan, I have not maintained this project for a little while now.
What's your saying makes a lot of sense. I don't mind merging a WIP as long as stuff get resolved before the next release and that the todo stuff is clear.
Also, before I go ahead and merge, I think we should get rid of commented out code.

sure.  We can use this PR as a discussion going fwd, for now.
I'll cleanup the comments too.
I'll start putting gulp and mocha test framework in place - perhaps you could have a think about what tests you would like to see around the graph support - as i've really not used that part yet (though I do plan to...)

Here's a summary of the waterline adapter compliance test:
`
✓ should create a new record
✓ should return a generated PK
✓ should return generated timestamps
✓ should return a model instance
✓ should normalize undefined values to null
✓ should return rows in the correct order when creating multiple rows (131ms)
✓ should have saved the proper values (with auto-increment values)
✓ should create a set of users
✓ should insert 2 records verififed by find
✓ should return model instances
✓ should destroy a record
✓ should return an empty array when searched for
✓ should destroy a record
✓ should return an empty array when searched for
✓ should destroy all the records
✓ should return an empty array when searched for
✓ should not destroy any records
✓ should return 10 records
✓ should return 1 record when searching for a specific record (integer test) with find
✓ should return a model instance
✓ should work with no criteria passed in
✓ should return a single record
✓ should return a model instance
✓ should return null if a record is not found
✓ should work with just an id passed in
✓ should create a new record
✓ should return a single record
✓ should only have a single record in the database
✓ should return a model instance
✓ should take search criteria as values
✓ should accept array of objects
✓ should return error if search criteria length does not match values
✓ should create new user(s) for the one that doesn't exist
✓ should find a user that does exist
✓ should only have a single record for keys that exist
✓ should fail when only one arg is specified
✓ should return model instances
✓ should store proper array value
✓ should store proper boolean value
✓ should store proper date value
✓ should store proper float value
✓ should store proper integer
✓ should store proper object value
✓ should store proper string value
✓ should update model attributes
✓ should return model instances
✓ should work with just an ID passed in
✓ should work with an empty object
✓ should work with null values
✓ should update model attributes without supplying required fields
✓ should allow the record to be found
✓ endsWith should actually enforce endswith
✓ should escape stars
✓ should accurately count records
✓ should work with dynamic finders
✓ should return all the users with the given name
✓ should return the user with the given name
✓ should average by key and only return that key with the average value
✓ should average by multiple keys and return averages per key
✓ should return the user with the correct name
✓ should return the user with the correct name
✓ should have [attribute]contains() method
✓ should return the user with the correct name
✓ should return the user with the correct name
✓ should have [attribute]EndsWith() method
✓ should return records with greaterThan key
✓ should return records with symbolic usage > usage
✓ should return records with greaterThan key when searching dates
✓ should return records with symbolic usage > usage when searching dates
✓ should return records with greaterThan key when searching strings
✓ should return records with symbolic usage > usage when searching strings
✓ should return records with greaterThanOrEqual key
✓ should return records with symbolic usage >= usage
✓ should return records with greaterThanOrEqual key when searching dates
✓ should return records with symbolic usage >= usage when searching dates
✓ should return records with greaterThanOrEqual key when searching strings
✓ should return records with symbolic usage >= usage when searching strings
✓ should error if not given any calculations to do
✓ should return correct user
✓ should return a model instance
✓ should return an empty array
✓ should return an empty array
✓ should return records with lessThan key
✓ should return records with symbolic usage < usage
✓ should return records with lessThan key when searching dates
✓ should return records with symbolic usage < usage when searching dates
✓ should return records with lessThanOrEqual key
✓ should return records with symbolic usage <= usage
✓ should return records with lessThanOrEqual key when searching dates
✓ should return records with symbolic usage <= usage when searching dates
✓ should return the user with the given name
✓ should support wrapping both sides with a % sign
✓ should return the correct amount of records
✓ dynamic finder usage should return the correct amount of records
✓ as an option should return correct amount of records
✓ should get the maximum of the key
✓ should max multiple keys
✓ should max and average
✓ should get the minimum of the key
✓ should min multiple keys
✓ should min and average
✓ should return records with string usage
✓ should return records with symbolic usage ! usage
✓ should return records using not comparisons on strings
✓ should return a model instance
✓ should return a record with a single field first_name
✓ should return multiples records with a single field first_name
✓ should return a record with a single field first_name (findOne)
✓ should return a record with multiple fields
✓ in absence of SELECT modifier should return a record with all fields
✓ should sort records using binary notation for asc
✓ should sort records using binary notation desc
✓ should sort records using string notation for asc
✓ should sort records using string notation for desc
✓ should sort when sort is an option
✓ should sort records using multiple sort criteria, with first name desc
✓ should sort records using multiple sort criteria, with first name asc
✓ should return the user with the correct name
✓ should return the user with the correct name
✓ should have [attribute]StartsWith() method
✓ should sum by key and only return that key with the sum value
✓ should sum by multiple keys and return sums of all keys
✓ should sum and average in the same query

Semantic Interface .find() should parse multi-level criteria:
Queryable Interface case sensitivity .findOne() should work in a case insensitve fashion by default:
Queryable Interface case sensitivity .findOne() should work with findOneBy*():
Queryable Interface case sensitivity .find() should work in a case insensitve fashion by default:
Queryable Interface case sensitivity .find() should work with findBy*():
Queryable Interface case sensitivity special classified queries contains should work in a case insensitive fashion by default:
Queryable Interface case sensitivity special classified queries startsWith should work in a case insensitive fashion by default:
Queryable Interface case sensitivity special classified queries endsWith should work in a case insensitive fashion by default:
Queryable Interface case sensitivity special classified queries like should work in a case insensitive fashion by default:
Queryable Interface case sensitivity special characters contains should work with stars in the name:
Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings:
Queryable Interface GroupBy Query Modifier should group by keys and sum values:
Queryable Interface GroupBy Query Modifier should group by multiple keys and sum values:
Queryable Interface GroupBy Query Modifier should group by keys and both sum and average values:
Queryable Interface GroupBy Query Modifier should allow match query with groupBy:
Queryable Interface NOT IN Query Modifier with a record should return correct user:
Queryable Interface NOT IN Query Modifier without a record should return an empty array:
Queryable Interface OR Query Modifier with a record should return the correct users:
Queryable Interface OR Query Modifier with a record should return a model instances:
Queryable Interface OR Query Modifier with a record should work with multi-level criteria options inside the OR criteria:
Queryable Interface OR Query Modifier with a record should work correctly when OR is used with AND:
Queryable Interface OR Query Modifier with a record should work correctly when OR is used with multiple contains modifiers:
Queryable Interface OR Query Modifier without a record should return an empty array:
Queryable Interface SKIP Query Modifier should return the correct amount of records:
Queryable Interface SKIP Query Modifier dynamic finder usage should return the correct amount of records:
Queryable Interface SKIP Query Modifier as an option should return correct amount of records:
`
What are your thoughts on the issue of case insensitive finds?  Waterline expects them to be case insensitive.  Doesn't seem right to me - also there have been reported concerns with index performance on other adapters due to this default.  I've left it as case sensitive, but with the option of using the caseSensitive: false option (see unit tests).

What are your thoughts on the issue of case insensitive finds?

If there is performance issues with case insensitive tests then I think having it default to false is a good idea.

waterline adapter test (v0.11) compliance issues now down to 15:
      ✓ should create a new record
      ✓ should return a generated PK
      ✓ should return generated timestamps
      ✓ should return a model instance
      ✓ should normalize undefined values to null
      ✓ should return rows in the correct order when creating multiple rows (134ms)
        ✓ should have saved the proper values (with auto-increment values)
      ✓ should create a set of users
      ✓ should insert 2 records verififed by find
      ✓ should return model instances
        ✓ should destroy a record
        ✓ should return an empty array when searched for
        ✓ should destroy a record
        ✓ should return an empty array when searched for
        ✓ should destroy all the records
        ✓ should return an empty array when searched for
        ✓ should not destroy any records
      ✓ should return 10 records
      ✓ should return 1 record when searching for a specific record (integer test) with find
      ✓ should parse multi-level criteria
      ✓ should return a model instance
      ✓ should work with no criteria passed in
      ✓ should return a single record
      ✓ should return a model instance
      ✓ should return null if a record is not found
      ✓ should work with just an id passed in
      ✓ should create a new record
      ✓ should return a single record
      ✓ should only have a single record in the database
      ✓ should return a model instance
      ✓ should take search criteria as values
      ✓ should accept array of objects
      ✓ should return error if search criteria length does not match values
      ✓ should create new user(s) for the one that doesn't exist
      ✓ should find a user that does exist
      ✓ should only have a single record for keys that exist
      ✓ should fail when only one arg is specified
      ✓ should return model instances
        ✓ should store proper array value
        ✓ should store proper boolean value
        ✓ should store proper date value
        ✓ should store proper float value
        ✓ should store proper integer
        ✓ should store proper object value
        ✓ should store proper string value
        ✓ should update model attributes
        ✓ should return model instances
        ✓ should work with just an ID passed in
        ✓ should work with an empty object
        ✓ should work with null values
        ✓ should update model attributes without supplying required fields
        ✓ should allow the record to be found
        ✓ should work in a case insensitve fashion by default
        ✓ should work with findOneBy*()
        ✓ should work in a case insensitve fashion by default
        ✓ should work with findBy*()
        ✓ contains should work in a case insensitive fashion by default
        ✓ startsWith should work in a case insensitive fashion by default
        ✓ endsWith should work in a case insensitive fashion by default
        ✓ like should work in a case insensitive fashion by default
        ✓ endsWith should actually enforce endswith
        ✓ should escape stars
        ✓ contains should work with stars in the name
      ✓ should accurately count records
      ✓ should work with dynamic finders
      ✓ should return all the users with the given name
      ✓ should return the user with the given name
      ✓ should average by key and only return that key with the average value
      ✓ should average by multiple keys and return averages per key
          ✓ should return the user with the correct name
          ✓ should return the user with the correct name
          ✓ should have [attribute]contains() method
          ✓ should return the user with the correct name
          ✓ should return the user with the correct name
          ✓ should have [attribute]EndsWith() method
          ✓ should return records with greaterThan key
          ✓ should return records with symbolic usage > usage
          ✓ should return records with greaterThan key when searching dates
          ✓ should return records with symbolic usage > usage when searching dates
          ✓ should return records with greaterThan key when searching strings
          ✓ should return records with symbolic usage > usage when searching strings
          ✓ should return records with greaterThanOrEqual key
          ✓ should return records with symbolic usage >= usage
          ✓ should return records with greaterThanOrEqual key when searching dates
          ✓ should return records with symbolic usage >= usage when searching dates
          ✓ should return records with greaterThanOrEqual key when searching strings
          ✓ should return records with symbolic usage >= usage when searching strings
      ✓ should error if not given any calculations to do
          ✓ should return an empty array
        ✓ should return an empty array
          ✓ should return records with lessThan key
          ✓ should return records with symbolic usage < usage
          ✓ should return records with lessThan key when searching dates
          ✓ should return records with symbolic usage < usage when searching dates
          ✓ should return records with lessThanOrEqual key
          ✓ should return records with symbolic usage <= usage
          ✓ should return records with lessThanOrEqual key when searching dates
          ✓ should return records with symbolic usage <= usage when searching dates
        ✓ should return the user with the given name
        ✓ should support wrapping both sides with a % sign
      ✓ should return the correct amount of records
      ✓ dynamic finder usage should return the correct amount of records
      ✓ as an option should return correct amount of records
      ✓ should get the maximum of the key
      ✓ should max multiple keys
      ✓ should max and average
      ✓ should get the minimum of the key
      ✓ should min multiple keys
      ✓ should min and average
        ✓ should return records with string usage
        ✓ should return records with symbolic usage ! usage
        ✓ should return records using not comparisons on strings
        ✓ should return a model instance
      ✓ should return a record with a single field first_name
      ✓ should return multiples records with a single field first_name
      ✓ should return a record with a single field first_name (findOne)
      ✓ should return a record with multiple fields
      ✓ in absence of SELECT modifier should return a record with all fields
      ✓ should return the correct amount of records
      ✓ dynamic finder usage should return the correct amount of records
      ✓ as an option should return correct amount of records
      ✓ should sort records using binary notation for asc
      ✓ should sort records using binary notation desc
      ✓ should sort records using string notation for asc
      ✓ should sort records using string notation for desc
      ✓ should sort when sort is an option
      ✓ should sort records using multiple sort criteria, with first name desc
      ✓ should sort records using multiple sort criteria, with first name asc
          ✓ should return the user with the correct name
          ✓ should return the user with the correct name
          ✓ should have [attribute]StartsWith() method
      ✓ should sum by key and only return that key with the sum value
      ✓ should sum by multiple keys and return sums of all keys
      ✓ should sum and average in the same query
  1) Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings:
  2) Queryable Interface GroupBy Query Modifier should group by keys and sum values:
  3) Queryable Interface GroupBy Query Modifier should group by multiple keys and sum values:
  4) Queryable Interface GroupBy Query Modifier should group by keys and both sum and average values:
  5) Queryable Interface GroupBy Query Modifier should allow match query with groupBy:
  6) Queryable Interface IN Query Modifier with a record should return correct user:
  7) Queryable Interface IN Query Modifier with a record should return a model instance:
  8) Queryable Interface NOT IN Query Modifier with a record should return correct user:
  9) Queryable Interface NOT IN Query Modifier without a record should return an empty array:
  10) Queryable Interface OR Query Modifier with a record should return the correct users:
  11) Queryable Interface OR Query Modifier with a record should return a model instances:
  12) Queryable Interface OR Query Modifier with a record should work with multi-level criteria options inside the OR criteria:
  13) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with AND:
  14) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with multiple contains modifiers:
  15) Queryable Interface OR Query Modifier without a record should return an empty array:

with some additional unit tests focusing on specific bugs:
    connection
      ✓ should establish a connection
    methods
      ✓ should create a new document in pets
      ✓ should find previously created pet by id
      ✓ should create a new document in users
      ✓ should find previously created user by id
      ✓ should find user by name
      ✓ should find user by name (case insensitive)
      ✓ should find user by name (case sensitive)
      ✓ should find user by name (case insensitive by default)
      ✓ should fail to find user by name (case sensitive)
      ✓ should update the user name by id
      ✓ should update the user name by name search
      ✓ should update the user name by name search (case insensitive)
      ✓ should support complex objects on update
      ✓ should select a top-level field using select
      ✓ should find by nested where clause
      ✓ should find by nested where clause with contains filter
      ✓ should find by nested where clause with contains filter (case insensitive)
      ✓ should find using 2 fields (AND)
      ✓ should find using 2 fields (AND) w/complex second field
      ✓ should find using 2 contains fields (AND)
      ✓ should find using 2 contains fields (AND) w/complex second field
      ✓ should populate pet
      ✓ should populate pet and find by pet name
      ✓ should not return documents with undefined field with <=
      ✓ should not return documents with undefined field with <
    drop collection(s)
      ✓ should drop the users_1 collection (50ms)
      ✓ should drop the pets_1 collection (82ms)

only 11 left:
  1) Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings:
  2) Queryable Interface GroupBy Query Modifier should group by keys and sum values:
  3) Queryable Interface GroupBy Query Modifier should group by multiple keys and sum values:
  4) Queryable Interface GroupBy Query Modifier should group by keys and both sum and average values:
  5) Queryable Interface GroupBy Query Modifier should allow match query with groupBy:
  6) Queryable Interface OR Query Modifier with a record should return the correct users:
  7) Queryable Interface OR Query Modifier with a record should return a model instances:
  8) Queryable Interface OR Query Modifier with a record should work with multi-level criteria options inside the OR criteria:
  9) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with AND:
  10) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with multiple contains modifiers:
  11) Queryable Interface OR Query Modifier without a record should return an empty array:

Looking good!

Re: 1) Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings
this fails due to the waterline adapter test assuming a date format as returned by toString(), whereas arangodb returns date strings in ISO format (as per toISOString().  I've added a new unit test to our suite for the ISO string format.  I think we can ignore the above waterline test failure.  Here is the output of the new test:
      greaterThanOrEqual (>=)
        dates
          ✓ should return records with greaterThanOrEqual key when searching dates
          ✓ should return records with symbolic usage >= usage when searching dates
          ✓ should return records with symbolic usage >= usage when searching dates as ISO strings

groupBy support added.  waterline test failures reduced to 7:
  1) Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings:
  2) Queryable Interface OR Query Modifier with a record should return the correct users:
  3) Queryable Interface OR Query Modifier with a record should return a model instances:
  4) Queryable Interface OR Query Modifier with a record should work with multi-level criteria options inside the OR criteria:
  5) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with AND:
  6) Queryable Interface OR Query Modifier with a record should work correctly when OR is used with multiple contains modifiers:
  7) Queryable Interface OR Query Modifier without a record should return an empty array:

waterline adapter tests now only complains about the date string format issue i mentioned previously:
1) Queryable Interface Modifiers greaterThanOrEqual (>=) dates should return records with symbolic usage >= usage when searching dates as strings

I added my own test for ISO formatted dates returned from Arangodb.
All thats left to do is to add some unit tests around graphs support...

Any update? I will gladly merge it when you think it's ready!

Hi @gabriel-letarte, I need to spend a little time putting some graph related tests together.  Hopefully i'll get it done this weekend.

@gabriel-letarte question: Should the models map field id to columnName '_key' or '_id'?
Reason I ask is if I create a graph where the model states via 'id' for the edge, and id is mapped to columnName '_key' - it doesnt work: "ArangoError: invalid edge attribute".  However, if I map the id field to '_id' to all works fine.
Seems we have to have fields mapping to '_id' for createEdge() to work.

@gbevan Your call, mapping the id to field _id seems like a reasonable decision.

The current join() via a named graph is not working
I'm looking at reworking the way named graphs are defined and used.  Currently we allow for a single named (predefined outside of thislibrary) graph in the config.  I would prefer to allow named graphs to be part of the schema - like this:
const Waterline = require('waterline');

const UsersProfilesGraph = Waterline.Collection.extend({
  identity: 'users_profiles_graph',
  schema: true,
  connection: 'arangodb',
  graph: true,

  edgeDefinitions: [
    {
      collection: 'users_profiles',
      from: ['users_1'],
      to: ['profiles_1']
    }
  ]

});

module.exports = UsersProfilesGraph;

and allow as many named graphs as needed.  I think this will make a lot more sense.
Also, not sure join should use edges/graphs at all - and instead provide access to graph functions - like we do for neighbours.
I'd like to also have a think about how we can extend access to graph functionality from waterline.
Any thoughts you may have would be welcome.

Summary of additional tests on top of the std waterline (v0.11) tests:
$ gulp test
[19:39:17] Using gulpfile ~/Documents/Brackets/sails-arangodb/gulpfile.js
[19:39:17] Starting 'mocha'...

  adapter
    connection
      ✓ should establish a connection
    methods
      ✓ should create a new document in pets (38ms)
      ✓ should find previously created pet by id (40ms)
      ✓ should create a new document in users (38ms)
      ✓ should find previously created user by id
      ✓ should find user by name
      ✓ should find user by name (case insensitive)
      ✓ should find user by name (case sensitive)
      ✓ should find user by name (case insensitive by default)
      ✓ should fail to find user by name (case sensitive)
      ✓ should update the user name by id
      ✓ should update the user name by name search
      ✓ should update the user name by name search (case insensitive)
      ✓ should support complex objects on update
      ✓ should select a top-level field using select
      ✓ should find by nested where clause
      ✓ should find by nested where clause with contains filter
      ✓ should find by nested where clause with contains filter (case insensitive)
      ✓ should find using 2 fields (AND)
      ✓ should find using 2 fields (AND) w/complex second field
      ✓ should find using 2 contains fields (AND)
      ✓ should find using 2 contains fields (AND) w/complex second field
      ✓ join should populate pet
      ✓ join should populate pet and find by pet name
      ✓ should not return documents with undefined field with <=
      ✓ should not return documents with undefined field with <
      delete
        ✓ should delete entry by name
        ✓ should delete entry in array
        ✓ should delete entry not in (with v0.11 !) array
        ✓ should delete entry not in (with v0.12 nin) array
      greaterThanOrEqual (>=)
        dates
          ✓ should return records with greaterThanOrEqual key when searching dates
          ✓ should return records with symbolic usage >= usage when searching dates
          ✓ should return records with symbolic usage >= usage when searching dates as ISO strings
      update
        ✓ should merge on update by default
        ✓ should replace on update
    Graphs
      createEdge as anonymous graph
        ✓ should create an edge
      neighbors
        ✓ should return the neighbor (profile) of the user (anonymous graph)
      join (populate) with edge collection profileOf
        ✓ should populate (join) profile and for the user (via graph)
      deleteEdge
        ✓ should delete an edge
      createEdge on named graph
        ✓ should create an edge on the named graph
      neighbors
        ✓ should return the neighbor (profile) of the user (edge coll from named graph)
      neighbors
        ✓ should return the neighbor (profile) of the user (named graph)
    drop collection(s)
      ✓ should drop the users_1 collection (69ms)
      ✓ should drop the pets_1 collection
      ✓ should drop the profiles_1 collection (50ms)
      ✓ should drop the profiles_1_id__users_1_profile (?) junctionTable collection (50ms)

  46 passing (2s)

mocha ended...

Please review the tests/models/*.js schemas.  The tests/adapter.test.js has examples of both anonymous and named graphs.  I think there is need for much more work here. But, these can be future pull requests...

@gbevan It's really been a while since I played with Sails + ArangoDB. I think you're currently the expert for this repo.

I've updated the version in package.json to 0.3.0.  This is ready to merge and publish.

Do you want me to merge, squash & merge or do you want to reorganize history before I merge?

Squash&merge is fine

hi, @gabriel-letarte are you planning to publish this to npm?  It's still reporting 0.2.3 there.

@gabriel-letarte I dont have the ability to publish this project under your npm account.  I could bring a fork under the umbrella of my partoutx project - where I am using this package - and publish from there.  Let me know what approach we should follow.

@gbevan Give me your email, I will add you to the list of collaborators :)

@gabriel-letarte I have actually already started releasing under a fork of this as https://www.npmjs.com/package/@partoutx/sails-arangodb.  I have attributed back to your original project in the readme.

👍


Trigger configuration doesn't work as expected

While following instructions specified in https://github.com/meteatamel/knative-tutorial/blob/master/docs/helloworldeventing.md, trigger gets created but ready state is false.
kubectl get trigger
NAME                    READY   REASON                               BROKER    SUBSCRIBER_URI   AGE
trigger-event-display   False   Unable to get the Subscriber's URI   default                    5s
Describe command on trigger returns following message:
failed to get ref &ObjectReference{Kind:Service,Namespace:default,Name:event-display,UID:,APIVersion:serving.knative.dev/v1,ResourceVersion:,FieldPath:,}: services.serving.knative.dev "event-display" not found

config issue.. working as expected


Usage with jest unstable

I tried to used this plugin together with Jest.
I thought I could setup the user permissions using strapi admin, export the settings using this plugin and load those settings during the test runs with jest. So I do not have to manually setup the permissions during each test run.
This first worked for me, but I then noticed errors:
Sometimes, the settings do not get imported.
Example:
When running npm test 5 times, it will likely work 4 times but 1 time it will fail, without anything changed in between.
In my example I have some routes wich should only be accessible for authorized users. Most of the time the requests work but sometimes I get forbidden errors.
https://user-images.githubusercontent.com/6911678/134194098-9aa14a68-f913-49bb-ad5a-a9922b94b470.mov
I suspect that the import runs asynchronously in the background and sometimes the import is not completed before the tests run. But I am not sure about that.
Is there a reference implementation for use with Jest?
I setup Jest as Described in the strapi docs:
https://strapi.io/documentation/developer-docs/latest/guides/unit-testing.html#testing-basic-endpoint-controller
this is my config-sync config:
module.exports = ({ env }) => ({
  'config-sync': {
    destination: "extensions/config-sync/files/",
    minify: false,
    importOnBootstrap: true,
    include: [
      "core-store",
      "role-permissions"
    ],
    exclude: [
      "core-store.plugin_users-permissions_grant"
    ]
  },
});

This is the test that's running in my example video:
  it('should create ticket', async () => {
    await request(strapi.server) // app server is an instance of Class: http.Server
      .post('/tickets')
      .set('accept', 'application/json')
      .set('Content-Type', 'application/json')
      .set('Authorization', 'Bearer ' + jwt)
      .send({
        ...ticketData
      })
      .expect('Content-Type', /json/)
      .expect(200)
      .then(data => {
        expect(data.body).toBeDefined();
        expect(data.body.title).toBe(ticketData.title);
      })
  });

Hi @derweili!
What an interesting usecase for this plugin. Haven't used the plugin like this myself yet, but it seems like it fits your purpose great!
The importOnBootstrap setting will simply run the importAllConfig service, just as it would when importing from the admin panel. This service is asynchronous, but is used with await so should be OK.
Though I did find that inside this service the plugin will rerun importSingleConfig for each config, though this is also a asynchronous method which is not used with await. Maby this fixes the issue?
Are you in the position to test this with your setup as described above? If so I could create a PR for you to test.

@boazpoolman yes I can test it again. What do I have to do?
Install a newer version of this plugin?

@boazpoolman I just testet the PR, unfortunately I still get the error.
I also sometimes (very rarely) get an error when initiating the Strapi instance. But because this only happend two times, I wasn't able to verify if this is related to this plugin.
Don't you have to return this await importSingleConfig function?
https://github.com/boazpoolman/strapi-plugin-config-sync/pull/23/files#diff-e487fde79a6fb1723e2b7bcb2fd3e62ba4148f537b0d9cd725ecacd2bc6f57a0R160
Although this also does not solve the error, I tried this already.

Strapi v4 has been released, and this plugin was migrated along with it.
In the migrated plugin this should likely be fixed as a lot of improvements have been made for the importOnBootstrap setting.
Alternatively you could use the CLI to import the config before you run your test command:
# Using yarn
yarn cs import -y && [test-command]

# Using npm
npm run cs import -y && [test-command]

Released in v1.0.0-alpha.1 of strapi-plugin-config-sync.


COR Policies added to HttpStream

The following changes add the ability to have CORS enabled on httplistener. So far, CORS Policy declined message goes away for HTML5 video player by viewing under Chrome. May need more work.

Great stuff, thanks for the patch. Let me know how it goes for you!


Does the background model can reconstruct the sun or the clouds ?

When I used my own data to reconstruct the model with the code, I noticed that the background model failed to reconstruct the sun or clouds.

Yes, currently the bg model can only reconstruct low frequency part in the background (eg sky). And GS would still try to reconstruct other parts.

Got it！Thank you！


Update grant selection feature in submission workflow

In Grant step of the workflow, populate the drop down with logged-in user's grants (on which he/she is the pi) - sort by award number.

This will likely be rolled into a future update to Autocomplete (#279), as the updated pass-indexer should include the ability for the search service itself to do the filtering.

I don't see this restriction happening. I'm still seeing all the grants - where I should only see 5.
On rev. dd4d6985
In fact, can we please make the drop down to be populated with user grant. so he/she can select from the drop down instead of having to search? that would will probably remove the need to use auto complete?

whoops! sorry if I mislabeled this ticket. My intent was that this ticket needs verification in the unmerged PR (https://github.com/OA-PASS/pass-ember/pull/292) - so code is not yet in develop. Same label situation in #279

this is done in a different ticket


IPTT landing page: Stretched out form fields

Issue
Too much space:

[x] Between the two radio toggle options
[x] Between “Most recent” and its corresponding numeric field

@KennyMonster a few more details to bring it to parity with Prod:

Can you add about 50% more space in between the two radio options -- i.e. between the word "all" and the radio button to its right?

Can you make the "Show all" and "Most recent" labels clickable the way they are on Prod? As opposed to having to click inside the tiny radio button.

If I type something into the Most recent number box, then toggle to Show All, and then back to Most recent, it should not "remember" the previous entry. (It doesn't do this on Prod, does do it on QA.)

Everything looks good!


refactor(theme): align text styles used in app with Figma design specifications

Pouria , please check some errors on ci and fix them. then send review request again.

@PouriaMoradi021

everything is done!
@esmaeil-ahmadipour

everything is done!
@esmaeil-ahmadipour

The PR is Draft. Please change it to "Ready for review"

@phoenixit99  , @PouriaMoradi021
Please note that the final commit must be made after the latest changes and right before the merge. This commit should include the changelog updates and the app version upgrade. We need to either have a discussion to align on this or follow the established format used in the changelog file so far. The commit message should also follow a consistent pattern.
update: update `CHANGELOG.md` & `pubspec.yaml` files

please use onSurfacePallet in text styles . according some part of material spec in this link.

Surface – Default color for backgrounds
On surface – Text and icons against any surface color

Examining Figma, we conclude that there is no consistent color for texts in light and dark mode, and there is a noticeable irregularity. Due to the need to temporarily fix this issue, follow the solution below :
Light Text Color : #242424
Dark  Text Color #FFFFFF
Please add this color for color palettes (surface and non-surface) - if they are not available -

@PouriaMoradi021

Document the Text Style Names
Ensure you document the name of each text style above it. This will make it easier to locate and reference them.

@PouriaMoradi021


Q: how to load "main.css" from the static page?

What is the best practise to load the css bundle (with a hashed filename) in the statically generated pages?
The <Html> component currently does not load any CSS at all, is that expected? Should we be using html-webpack-plugin for this and generate a skeleton template?

See how Layout.js imports its stylesheet:
import React, { PropTypes } from 'react';
import './Layout.scss';

This causes that file to get inlined as a <style> element in the rendered content.
Does this answer your question? Or did I misunderstand?

Does this answer your question? Or did I misunderstand?

Well, not really. I would like all my css to be 1. bundled&minified; 2. included with a <link> on all pages. The ExtractTextPlugin takes care of extracting all styles and creates a bundled css. It's not clear (to me) what the best way is to include that in all static pages rendered.

bump

I believe PR #41 addresses this but I think that code could be cleaned up a bit.

There are different routes to optimize the initial page load time. The approach that is currently used in RSB tries to minimize the number of external resources needed to be loaded initially (when user opens the page for the first time). For that reason, all the CSS for each chunk is bundled into JavaScript (.js) file(s). So instead of:
<link rel="stylesheet" href="/dist/main.5a4bf4f88305456d34fd.css">
<script src="/dist/main.5a4bf4f88305456d34fd.js"></script>

You can have just:
<script src="/dist/main.5a4bf4f88305456d34fd.js"></script>

As far as I understand, ExtractTextPlugin doesn't work well with chunks and causes unnecessary excess HTTP requests.
If you have a suggestion how to optimize the initial page load time that is oriented towards minimizing application bundle(s) (chunks) and redundant HTTP requests, please don't hesitate to share your ideas here or on Gitter. Thanks! I will close this issue for now.


⚠ Bofrost.es has degraded performance

In 9b29dd0, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1520 ms

Resolved: Bofrost.es performance has improved in 4117ef6 after 6 minutes.


fix for hybrid networks

Tried the tool on my network which had both an IPv4 and IPv6 address. It didn't work because the IPv6 address was selected instead of the IPv4 one. This fixes that. :)

Thankyou @ccbrown, I really appreciate the time you took to make a fix


LSOpenURLsWithRole() strikes back

I am unable to open Atom from the command line on Mac OS X 10.10 (Beta 4)—I don't remember when it broke or what caused it, but re-downloading/re-installing the command line tools didn't fix it. I believe this is different from #1103 because I'm on Atom 0.119.0.
I investigated which line of /usr/local/bin/atom was causing the error and discovered that
open -a /Applications/Atom.app

works fine, but
open -a /Applications/Atom.app -n

causes the error.
Full error message:
LSOpenURLsWithRole() failed for the application /Applications/Atom.app with error -10810.

For me it crashes every time. I have tried: inside tmux, outside tmux and from dock. It crashes every time. Crash report it always same, and it can be seen on my own issue report https://github.com/atom/atom/issues/6135.

Atom stopped working for me completely:
$ atom
LSOpenURLsWithRole() failed for the application /Users/feedy/Applications/Atom.app with error -10810.
$ reattach-to-user-namespace atom -v

$ reattach-to-user-namespace atom
LSOpenURLsWithRole() failed for the application /Users/feedy/Applications/Atom.app with error -10810.
$ /opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/MacOS/Atom
dyld: Library not loaded: @rpath/Atom Framework.framework/Atom Framework
  Referenced from: /opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/MacOS/./Atom
  Reason: no suitable image found.  Did find:
	/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/MacOS/../Frameworks/Atom Framework.framework/Atom Framework: code signature invalid for '/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/MacOS/../Frameworks/Atom Framework.framework/Atom Framework'

Trace/BPT trap: 5

This started with a restart to upgrade to the latest version. I only saw a white window, which I force-quit after several minutes. Now, atom crashes every time I try to start it.

I don't have tmux installed, but it is happening for me.

This is happening for me when using Black Screen on OS X:
https://github.com/black-screen/black-screen/issues/58

For me this issue was due to my unzip tool not preserving the symlinks in Atom.app/Contents/Frameworks/Electron\ Framework.framework

@jamesward How would I go about fixing this?

@jdsimcoe Electron could not use symlinks.

FYI, I think this can happen is the executable name changes (Gatekeeper gets confused)... e.g. Foo.app/Contents/MacOS/Electron to Foo.app/Contents/MacOS/Foo

The electron-packager changed recently which changes the executable name from Electron to app name: https://github.com/electron-userland/electron-packager/commit/aaeee768cfbcc7932a1413161afe2a3df28490eb

FWIW, I had this issue when trying to use a terminal (terminal-plus extension) within Atom to open a file within my current Atom session. The fix mentioned above in the original issue filing, while not ideal, did indeed fix it for me. I am not using reattach-to-user-namespace.
To be explicit about what I changed, I did the following:

vim /usr/local/bin/atom
Changed line 88 (for me) to match the following (just removed the -n option):
open -a "$ATOM_PATH/$ATOM_APP_NAME" --args --executed-from="$(pwd)" --pid=$$ --path-environment="$PATH" "$@"
Reloaded my shell
atom /path/to/some/file was working again.

@opes doing this fixed the error, but doesn't actually make the files open when running atom <path>.

The only that works for us so far in OS X 10.12.2 is to add the following to your ~/.bash_profile or relevant shell script:
alias atom="open -a /Applications/Atom.app/Contents/MacOS/Atom"

That's basically what I do

It doesn't seem to help for me.
Changing the executable as @opes says fixes the error but doesn't open the file.
Creating the alias doesn't stop the error for me.
This is when using git via terminal-plus

@fndaily nice

I got this when running atom within platformio-ide-terminal (terminal-plus).
I was able to bypass the error using a wrapper shell script:
#!/usr/bin/env -i bash
exec atom $@

env - i resets the environment... so terminal-plus should probably be sanitising Atom / Electron environment variables when creating a terminal window.

For those having this problem in iTerm.app after upgrading that app, see
https://gitlab.com/gnachman/iterm2/issues/4694
which points to
https://gitlab.com/gnachman/iterm2/wikis/brokenafterupdate

I am suddenly having this problem from within iTerm2 and when I exec atom from the LaunchPad.  Tried some of these work around to no luck.  Any update on this?

I'm having this issue too. I am not using tmux, just regular OS X terminal.
Last time, a week ago, I completely reinstalled Atom and all of my plugins.

FWIW, I fixed the problem by reinstalling Atom. I didn't lose any of my settings, packages, etc.

I have been reinstalling, but it's becoming increasingly more common that I have to do this.

https://github.com/Radarr/Radarr/issues/1353#issuecomment-293187409
chmod +x fixed this for me.


User edit as form submit

First of all, let me thank you for this great project. It's really filling a gap on the 'market'.
I wanted to ask if you possibly plan to change the way how user edits work today. I know that the tool is meant for admins, but even admins are usually used to changing all user details at once and then submitting with Save or Submit button. Hitting Set at each property is little more demanding and also somewhat inconsistent with changing checkboxes where Set is missing.
Would it make sense to you to change the UI this way in the future?

It's a nice idea, but I don't see having the time to make such a change anytime soon.


Support to read tags and values and also set them.

It would be nice if we have functionality to read struct tags and also get and set values for respective field.
Thanks.

@adpande I'm not sure how would you see it, could you please draft a pseudocode to describe what you have in mind?

Hi @bkrukowski ,
Here is the actual code I used to read config from a NATS KV bucket based on the struct tags and set and return the value.
https://gist.github.com/adpande/99881aef7de899c46916a47e0968825b
Have a look at it. If we make it easy to read struct tags and set values accordingly, it would be  a nice feature for this library to add.
Regards,
Abhishek

@adpande hmmm... I believe the most flexible approach would be to manipulate values by callbacks, because tags may have a bit more sophisticated logic, e.g.:
Field int `json:"myName,omitempty"`

in the above example the JSON tag equals myName,omitempty. I drafted how I would see it here https://github.com/gontainer/reflectpro/pull/8 (see the ExampleSetByCallback func). Feel free to comment on that PR.
	var person struct {
		Name string `custom:"name"`
		Age  int    `custom:"age"`
	}

	config := map[string]any{
		"name": "Jane",
		"age":  25,
	}

	_ = setter.SetByCallback(
		&person,
		func(field reflect.StructField) (_ interface{}, ok bool) {
			// check whether the given tag exists
			tag, ok := field.Tag.Lookup("custom")
			if !ok {
				return nil, false
			}

			// check whether we have the desired value in the config
			if val, ok := config[tag]; ok {
				return val, ok
			}

			return nil, false
		},
	)


Remove availability zones since AWS ignores them anyway

This only worked when availability zones were matching all available zones in the region. If provided less or none, there was always a diff and terraform wanted to recreate the cluster.
References

https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/8
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/38

This exact issue is affecting DocumentDB. It totally ignores the availability zones passed into a aws_docdb_cluster and uses all the ones in the region. When I re-run Terraform, it wants to destroy & recreate the cluster with the two availability zones I'm passing in (which don't matter anyways).


update doc with driver option FQDN

@wangcai0124 : Thanks for your contribution! The author, @mani-ramaswamy, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @mani-ramaswamy, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @mani-ramaswamy, has been notified to review your proposed change.

@wangcai0124 : Thanks for your contribution! The author, @mani-ramaswamy, has been notified to review your proposed change.

#sign-off


Odo source e2e test dotnet component push fails on Openshift 4.0 cluster

[kind/bug]

What versions of software are you using?

Output of odo version:

$ odo version
odo v0.0.20 (3e634631)

Server: <URL>:6443
Kubernetes: v1.12.4+0f8e04e

How did you run odo exactly?
$ git clone https://github.com/redhat-developer/odo && cd odo
$ make bin
$ ./odo project create odo-source
$ ./odo create dotnet dotnet-app --local tests/e2e/examples/source/dotnet/
$ ./odo push
OR

$ make test-source-e2e
Actual behavior
Fails
Expected behavior
Should pass
Any logs, error output, etc?
$ ./odo create dotnet dotnet-app --local tests/e2e/examples/source/dotnet/
 ✓  Checking component
 ✓  Checking component version
 ✓  Initializing 'dotnet-app' component
 ✓  Creating component dotnet-app
 ✓  Component 'dotnet-app' was created and port 8080/TCP was opened
 ✓  Component 'dotnet-app' is now set as active component
To push source code to the component run 'odo push'
This may take a few moments to be ready
Amits-MacBook-Pro:odo amit$ ./odo push
Pushing changes to component: dotnet-app
 ✓  Waiting for component to start
 ✓  Copying files to component
 ◐  Building component ✗  Unable to build files
+ set -eo pipefail
+ '[' '!' -z /opt/app-root/src ']'
+ '[' /tmp '!=' /opt/app-root/src ']'
+ '[' /opt/app-root/src '!=' /opt/app-root/src ']'
+ '[' -f /tmp/src/.s2i/bin/assemble ']'
+ '[' -n /usr/libexec/s2i ']'
+ rm -rf /opt/app-root/src/.git
+ /usr/libexec/s2i/assemble
---> Installing application source...
Using SDK: 2.2.104
---> Restoring application dependencies...
  Restoring packages for /opt/app-root/src/asp-net-hello-world.csproj...
  Installing System.Threading.Overlapped 4.3.0.
  Installing System.Net.WebSockets 4.3.0.
  Installing System.Security.Principal 4.3.0.
  Installing System.Security.Claims 4.3.0.
  [...]
  Installing System.Globalization 4.3.0.
  Installing System.Net.Primitives 4.3.0.
  Generating MSBuild file /opt/app-root/src/obj/asp-net-hello-world.csproj.nuget.g.props.
  Generating MSBuild file /opt/app-root/src/obj/asp-net-hello-world.csproj.nuget.g.targets.
  Restore completed in 8.25 sec for /opt/app-root/src/asp-net-hello-world.csproj.
---> Publishing application...
Microsoft (R) Build Engine version <IP_ADDRESS>311 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

/opt/rh/rh-dotnet22/root/usr/lib64/dotnet/sdk/2.2.104/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(208,5):
error NETSDK1005: Assets file '/opt/app-root/src/obj/project.assets.json'
doesn't have a target for '.NETCoreApp,Version=v2.2'.
Ensure that restore has run and that you have included 'netcoreapp2.2'
in the TargetFrameworks for your project. [/opt/app-root/src/asp-net-hello-world.csproj]

 ✗  Building component
 ✗  command terminated with exit code 1

#1431

On 4.0 cluster
$ odo catalog list componentsNAME        PROJECT       TAGS
dotnet      openshift     1.0,1.1,2.1,2.2,latest
httpd       openshift     2.4,latest
java        openshift     8,latest
nginx       openshift     1.10,1.12,1.8,latest
nodejs      openshift     10,6,8,8-RHOAR,latest
perl        openshift     5.24,5.26,latest
php         openshift     7.0,7.1,7.2,latest
python      openshift     2.7,3.5,3.6,latest
ruby        openshift     2.3,2.4,2.5,latest
wildfly     openshift     10.0,10.1,11.0,12.0,13.0,14.0,15.0,16.0,8.1,9.0,latest

On 3.11.0 cluster
$ odo catalog list components
NAME           PROJECT            TAGS
dotnet         openshift          2.0,latest
httpd          openshift          2.4,latest
nginx          openshift          1.10,1.12,1.8,latest
nodejs         openshift          10,6,8,8-RHOAR,latest
perl           openshift          5.24,5.26,latest
php            openshift          7.0,7.1,latest
python         openshift          2.7,3.5,3.6,latest
ruby           openshift          2.3,2.4,2.5,latest
wildfly        openshift          10.0,10.1,11.0,12.0,13.0,8.1,9.0,latest
nodejs (*)     odo-1552548705     10,11,6,8,8-RHOAR,latest

As per the error resolution reported in the odo push, by replacing <TargetFramework>netcoreapp2.0</TargetFramework> with <TargetFramework>netcoreapp2.2</TargetFramework> works on 4.0 cluster, but the same target framework tag for netcoreapp2.2 doesnot work on 3.11 cluster.

https://github.com/redhat-developer/odo/blob/master/tests/e2e/examples/source/dotnet/asp-net-hello-world.csproj#L4

However dotnet 2.0 is available in the image stream but the Tags is marked as hidden
$ oc describe is -n openshift dotnet
[...]
2.0
  tagged from registry.centos.org/dotnet/dotnet-20-centos7:latest
    prefer registry pullthrough when referencing this tag

  RETIRED: Build and run .NET Core 2.0 applications on CentOS 7. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/master/2.0/build/README.md.
  Tags: hidden, builder, .net, dotnet, dotnetcore, rh-dotnet20
  Supports: dotnet:2.0, dotnet
  Example Repo: https://github.com/redhat-developer/s2i-dotnetcore-ex.git

  * registry.centos.org/dotnet/dotnet-20-centos7@sha256:0f8ba35b50a98c7980af6aa8b023f347e9b1d7f9195df7b99ddeb9afaa018a32
      3 minutes ago
    registry.redhat.io/dotnet/dotnet-20-rhel7@sha256:35cd9b0c2f596f0ffcb417946c97a3056005cda815d51705a49684f68c5b6521
      15 hours ago
[...]

We should probably figure out what to do long term, but maybe for now we can skip dotnet against 4.0 cluster and get source tests on OpenShift CI but push for its removal from other CI's  last.
What you can do to achieve this

setup an env OPENSHIFT_VERSION
If this env is set and its value is 4.0, then skip dotnet tests

We should probably figure out what to do long term, but maybe for now we can skip dotnet against 4.0 cluster and get source tests on OpenShift CI but push for its removal from other CI's last.
What you can do to achieve this
* setup an env OPENSHIFT_VERSION

* If this env is set and its value is 4.0, then skip dotnet tests

* Edit tests in openshift/release to set `export OPENSHIFT_VERSION=4.0`

As a workaround even after removing the hidden tag from dotnet image stream - https://raw.githubusercontent.com/openshift/library/master/arch/x86_64/community/dotnet/imagestreams/dotnet-centos7.json and applying the same does not work. Also use of latest tag in the source test file could not help.
I am ok with suggestion. @kadel WDYT ?

^ Or lets not complicate the test. IMO this can be done just by changing netcoreapp2.0 to netcoreapp2.2 in [1]. I am proposing this because anyway 4.0 is going to be the default CI test environment and 3.11 will be used in some cases (mostly locally).
So for our test we can create a known issue for source test on 3.11 cluster with a workaround. Later days we can fix it if needed. @mohammedzee1000 @kadel WDY ?
[1] https://github.com/redhat-developer/odo/blob/master/tests/e2e/examples/source/dotnet/asp-net-hello-world.csproj#L4

#1469

^ Or lets not complicate the test. IMO this can be done just by changing netcoreapp2.0 to netcoreapp2.2 in [1]. I am proposing this because anyway 4.0 is going to be the default CI test environment and 3.11 will be used in some cases (mostly locally).

3.11 will be with us for a long time

However dotnet 2.0 is available in the image stream but the Tags is marked as hidden

hidden shouldn't matter. It just hides it from odo catalog list components but you still can create component using it.

If this was solved in  https://github.com/redhat-developer/odo/pull/1469, it should be closed.

Fixed via #1469


Update PointsDisplay.tsx

Percentage should be multiplied by 100

Hey @lamgary, thanks for the catch! I ended up needing to do a quick fix on that code so I grabbed your fix in #257.
We'd love to take contributions from you in the future - please remember to run yarn fix before uploading a PR so that lint won't block you!

Awesome, thanks a lot Benjamin, and thanks for the work on the site - it’s
really helpful
On Tue, Sep 15, 2020 at 00:10 Benjamin Shaya<EMAIL_ADDRESS>wrote:

Hey @lamgary https://github.com/lamgary, thanks for the catch! I ended
up needing to do a quick fix on that code so I grabbed your fix in #257
https://github.com/microcovid/microcovid/pull/257.
We'd love to take contributions from you in the future - please remember
to run yarn fix before uploading a PR so that lint won't block you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microcovid/microcovid/pull/254#issuecomment-692515049,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZAZYY3EKAPCDZEX7GAABTSF4HQDANCNFSM4RMR5NVQ
.


Remember last selected template

Issue:
Plugin UI doesn't remember selected Template, Vault Or manually entered destination path - resets as soon as closed.
Request:
Plugin UI should remember and stay on the last selected Template, Vault and manually entered path. Until I reselect a template manually or optionally until I hit a "reset button".
Description:
I constantly save different websites in a row to a specific topic. For that I select my specified Template which already selects targeted Vault and pre-defines the destination path to that vault. From there i specify the sub-path further in the plugin UI. These adjustments resets after I hit "add to obsidian" button, close the plugin (clicking away by accident) or change tabs in browser. It resets itself to top most ordered Template.
The whole procedure basically works fine - but i need to reselect and readjust parameters every time, find and copy the destination path from explorer... which makes this very very time consuming.
Please make it remember my latest settings. thx

OS: Win10
Browser Firefox 132.0.2
Web Clipper version: 0.9.7
Obsidian version: 1.7.6

What your describing is similar to the behavior that existed in a prior version but it was removed because people found it too confusing. Instead I would recommend creating multiple templates, and change the order of them in the Web Clipper settings.
You can also consider using triggers:
https://help.obsidian.md/web-clipper/templates#Automatically+trigger+a+template

I understand this plugin popup UI as an temporary change of parameters. If I want to reset them I'd reselect a template - what users would do anyway if the have multiple templates/vaults. Optionally if I want to keep these changes you could add an "save to new template" button.
Honestly I cant think of an situation where keeping the changes in the popup window temporarily would be considered confusing.
What is the use case conflict that depends on the template list order?
In my workflow I clip different news sites in a folder structure for comparison of information and content.
for example: TOPIC/SUBTOPIC1/SUBTOPIC2/DATE_SUBTOPIC3
I do this several times in a row for different websites until the topic changes which completely changes the folder structure.
so I have to re-enter this path on every website - after i selected the template containing the correct vault and predefined path up to SUBTOPIC1.
current workaround is copy pasting the path from an opened editor window since clipboard is being permanently overwritten in the clipping process.
Suggestion:
Maybe its possible if change in the popup UI a temporary hidden template is created in the background. which will be put on top list until a different template is reselected, then it gets deleted.

Have you tried triggering a template based on URL - https://help.obsidian.md/web-clipper/templates#Automatically+trigger+a+template

Have you tried triggering a template based on URL - https://help.obsidian.md/web-clipper/templates#Automatically+trigger+a+template

Folder structure depends on Topic, not on URL. Same website, multiple Topics. Most of them with individuals dates.
So I need to change it individually. Thankfully there is already a Field in the pop UI that let me do this on the fly. So I very much appreciate that.

I see both preferences having value, based on case(s) I'm trying to clip.
Maybe a "sticky button" (checkbox) to the current active template could be possible to add? E.g. behaviour would be not changing template, until the "sticky button" (checkbox) is removed?

I see both preferences having value, based on case(s) I'm trying to clip.
Like mentioned, a toggle-button (e.g. checkbox in the pop-up window), to have the current template "sticky" could be a possible solution; e.g. behaviour would be not changing the "active template", until the toggle/checkbox is removed.

I dont see where current behavior would have its benefits. Please explain where it would make sense to automatically jump back to topmost template?
Because, I still could reselect that manually - and then it "sticks" with my latest selection until I select another one.
A "sticky button" doesnt help me much. I still need to reenter the destination path on every website (or if I accidentally close the plugin window).
The changes inthe fields "Path" in the plugin window would need to be also temporarily saved - as long as I reselect another template.

To make clear what i mean I took some time to create some mockups on how i would see that UI and its usability.

The Plugin Window should show a template selection on top.
Below that parameters which are changeable, including lines for vault and path.
If a change is made a temporarily template is created in the background , a tag "changed" is added behind the name of the currently selected template.
Bonus feature:
Now a save button appears where i can save the changed template to a NEW template.
Or reset it by a button or simply reselecting another template.
Personally I prefer mockup#3. It makes a visually clear hierarchy change between template fields and the following ones. The additional naming on the left shouldn't leave room for "confusing" the user on what is what.
I hope my suggestion makes sense - Thanks for your time.


[backport release 21.05]: newlib: Add parameter for "nano" variant

Motivation for this change
Backport of https://github.com/NixOS/nixpkgs/pull/140055
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140507 at 92162ff8 run on x86_64-linux 1

2 packages failed to build:

betaflight
inav

6 packages built successfully:

armTrustedFirmwareTools
axoloti
fusee-launcher
gnuk
newlib
newlib-nano

2 suggestions:

warning: license-missing
Package is missing a license.
Near pkgs/development/misc/newlib/default.nix:25:3:
   |
25 |   configureFlags = [
   |   ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/misc/newlib/default.nix:25:3:
   |
25 |   configureFlags = [
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


User defined caps

If VAAPI_FITS_CAPS environment variable is defined, then
try to load caps from this path.  If no caps found, then
fallback to library caps path.

cc: @Bin-QA


Consider providing a DAGUnroller backend to return a QobjExperiment instead of a plain dictionary

What is the expected enhancement?
Avoid using QobjExperiment#from_dict method. This method was intended to ease the transition to Qobj and will be removed (#652).

This is on blocked until #1129. Therefore, on hold.

We have decided that obj will only be made using the qobj objects in circuits_2_qobj and not part of the unroller. This will be done with issue #1145.


Added enum for connection errors

Thank you! I'm grateful you've contributed to this as you have. It's much appreciated.


Update typography section on site and typography classes in CSS

[ ] bug
[ ] feature request
[x] enhancement

Expected behavior
Typography in components should match classes in typography section of Clarity website.
Description of typography classes should list components that use such class correctly.
Actual behavior
Right now most of the components doesn't use built-in typography classes, and description of each class in docs, where use cases for each class is listed, is incorrect.
Components very often use 1pt bigger or smaller text, than listed in typography docs, and almost always they use different line height, sometimes - different letter spacing.
So, documentation on typography right now is confusing.
I'd say you need a complete revision of it.

There are a couple of issues here. Typography is really about guidelines for content, and should not be conflated with the typography used inside of components.

I agree we should clean up the typography page to not reference components and focus instead of how this is typography for static content. We can do this now.
We should also spend some time when we have a design lead doing the work to consolidate and simplify our use of typography for consistency. This is a long term issue that reflects work that is likely to go into Clarity after 1.0.
I don't know that we want to actually use the typography styles in our own components, as it really depends on each component what we'll do. Again this depends on item 2.

I do not agree with the notion that type classes are for content and that should not be conflated with type specifications for components. By using classes in components theming is streamlined. While this may require a few more classes to address both component and copy needs, the benefit justifies the effort.
The existing classes already refer to their use in components in the 'style name' column of the documentation. What is needed is a survey and consolidation of classes based on product and component needs. This will be a substantial effort - in the meantime an initial pass of type system incremental improvement is in flight.
This issue superseded by: https://github.com/clr-team/planning/issues/90


WIP: Add perf-analyzer-no-security integ tests to staging-build-tar workflow

Issue
https://github.com/opendistro-for-elasticsearch/opendistro-infra/issues/236
https://github.com/opendistro-for-elasticsearch/opendistro-build/issues/339
Description of changes
Add perf-analyzer-no-security integ tests to staging-build-tar workflow.
Test Results
Manually tested the workflow. The integ tests start, but fail right now because the tests need to enable a feature in the test cluster.
https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/217498888
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

If this PR is not in ready state for review, e.g. has many TODOs. Please add "WIP" in the title, and do not assign us for review until everything is ready. Thanks.

should we enable the PA feature firstly? I see the " PA not enabled" error in the log

I tried that; the tests still fail. See https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/219069273/workflow
Sid's change should address this: https://github.com/opendistro-for-elasticsearch/performance-analyzer/pull/176/

should we enable the PA feature firstly? I see the " PA not enabled" error in the log

I tried that; the tests still fail. See https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/219069273/workflow
Sid's change should address this: opendistro-for-elasticsearch/performance-analyzer#176

Ping him and ask when he can get that PR merged, and create a tag for 1.10.0 then test again.

should we enable the PA feature firstly? I see the " PA not enabled" error in the log

I tried that; the tests still fail. See https://github.com/opendistro-for-elasticsearch/opendistro-build/actions/runs/219069273/workflow
Sid's change should address this: opendistro-for-elasticsearch/performance-analyzer#176

Ping him and ask when he can get that PR merged, and create a tag for 1.10.0 then test again.

Way ahead of you :)
[August 24, 2020, 9:20 AM] Skinner, Cameron: Hey Sid, what's the ETA for getting that change merged?
[August 24, 2020, 9:24 AM] Narayan, Sid: Let me ping people, I'll try to get it merged by EOD, hopefully sooner

Talking to Sid about this in a meeting, and the outcomes are:

We have to have RCA jars build fresh because:

gradle integTest framework requires a full code compilation to run test
RCA jar is a dependency for PA jar
Since RCA and PA sits in two different repo instead of one, during the integTest compileJAVA step, test will fail if it could not find a RCA jar presents in the same repo parent folder as PA (/tmp/pa, /tmp/rca structure required here)
The solution is to build RCA jars on the fly, push it to mavenlocal, so the PA integTest can find it as a dependency through mavenlocal, thus use it for full compilation during integTest compileJAVA step

However, the integTest is only doing API calls through 9200 port, does not necessarily need the code in RCA jar to actually run the integTest
This would be taken care of by PA team later
They will also try to upgrade their gradle to the latest version in order to take JDK 14/15 later

Close this as the integTest model changed in OpenSearch.


Fix network still has endpoint bug

This fixes #366

Decouple endpoint count and allocated address count
Change the way we send address pool ID in docker IPAM plugin
Return gateway address if lib network gateway label is present
Add a system test case for network add/delete without gateway
Cleanup some unused code

I'm going to merge this to get a release out


Wrong setting for Java permission

Windows Components / Internet Explorer / Internet Control Panel / Security Page / Locked-Down Trusted Sites Zone | Java permissions |
You have the setting:
Enabled: Enable
It should be Enabled | and one of the Java security settings:  High, medium,low, custom, Disable

@officedocsbot assign @e0i

@My-userid
Somehow your issue has been opened without being associated to a documentation topic.
Could you clarify which documentation you're referring to? A link would be helpful.
Thanks.

Link is:
https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-security-configuration-framework/level-5-enterprise-security

@My-userid
Thank you.
The issue has been noted and the document will be revised in the light of your feedback.

@e0i The link provided seems broken.

I couldn't access the url, either.
There is https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-security-configuration-framework/level-5-enterprise-administrator-security -- note "administrator" in the url.
But...that page does not include settings.

@My-userid : it would be most helpful if you could provide a working link to the page you refer to. Or better still, if you post the same statement as you wrote in your opening comment, but in the Feedback section of the correct page, it would be very useful with regards to getting the changes you requested applied to the correct page.

@My-userid
We are closing this issue as there hasn't been a response from your side regarding the specific article where the issue stems from.
Feel free to re-open this issue by clarifying the problematic document and we'd be glad to come up with content updates.
Thank you for providing feedback.

@officedocsbot close


WebAssembly post draft.

WebAssembly post draft. Full text, missing potential example (there's one taken from the docs, should we add another one with a simple C++ hello world?), missing icon. RFC.

Added introduction (explains a few key concepts) and conclusion. Turned into "7 things" rather than 8.


Will there be windows and linux support?

As stated in the title: Will there be windows and linux support?

Linux and windows are not my focus, although if anyone wants to contribute, you are welcome to comment below. If that happens eventually, I will also need to convert this plugin to a federated plugin.

Unfortunately I am no C++ developer. For a project I need the windows and linux support, so I would really appreciate someone contributing on this topic


Windows平台能否添加右键菜单

如果可以在文件上右击 > 使用Localsend发送
比起拖拽来更加方便, 沉浸感更强

A good idea, but if this feature is implemented on Windows, should it also be implemented on Linux & macOS? Should it be implemented on mobile devices for long-press as well?

如果能在右键菜单添加发送到localsend 或者文件以Localsend形式打开，可以触发发送操作，那就非常完美了。


Add  to the list of merchants

What's the name of your business?
Venom X Security Ltd.
What's the URL of the website?
https://www.venomxsecurity.com
Write a brief description of your business/service (max 50 characters)
Penetration testing, vulnerability assessment and OSINT
Enter the URL where a Monero mention can be found
https://www.venomxsecurity.com/crypto-currency/
How do you accept Monero? (choose only one option)

[ ] Monero integrations (github.com/monero-integrations)
[ ] Globee
[x] Native wallet
[ ] Other payment gateaway (Coinpayments, Morphtoken, etc. Please specify)

How would you categorize your business? (choose only one option)

[ ] Exchange
[ ] Block Explorer
[ ] Payment Gateway
[ ] Web Hosting
[ ] Tool
[x] Service
[ ] Goods
[ ] Entertainment

Comment
We look forward to helping extend the Monero platform and reach.

OK.

#1651


When SCL Namespace isn't the default

Background:
When a SCL XML File is used that doesn't use the SCL Namespace as the default namespace the OpenSCD editor isn't working correctly, because it expects it to be the default. The file is loaded and parts of the XML can be edited, but some parts won't.

We have decided to - within the ongoing refactor - create our own query function that will allow setting any namespace as the default namespace in the future. My guess is that mid-Dec it will be available for you to use.

@dlabordus This one can be closed right?

Agree

I kind of disagree, because the XML is valid if it's not the default namespace, but it seems the electric world expect it to be the default.


handling http semantic convention breaking changes in v1.23.0

Description:

It is a cherry-pick from opentelemetry upstream https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31120
awsxrayexporter is able to handle both old and new versions of http span attributes, support translate new http attributes to xray segment fields by following http server span and client span spec.
Link to tracking Issue:
https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30935
Testing:
Documentation:
https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

Can you change the PR to merge to the aws-cwa-dev branch? This is the branch we use for cloudwatch agent


fix(InteractionData): populate second param of getLocalPosition

Supercedes #2208

Here it is against dev

:+1:


Feature/us#14 send recommendations

Funcionalidades Adicionadas:

Criar Recomendação do aluno;
Editar recomendação do aluno;

Coverage decreased (-0.1%) to 96.774% when pulling 62ae3bd00c0e67f50ad340f032e8b69c1e12c463 on feature/US#14-sendRecommendations into 11c99e449af91a31e3b806e17e2c27de8d2b52dd on master.