[v4] A configuration object could not be found

the error:
withPrismicPreview.tsx:109 Error: A configuration object could not be found for repository "karrot". Check that the repository is configured in your app's usePrismicPreviewResolver.
    at eval (usePrismicPreviewBootstrap.ts:150)
    at eval (Either.js:70)
    at eval (function.js:180)
    at pipe (function.js:277)
    at eval (usePrismicPreviewBootstrap.ts:145)
    at eval (Chain.js:5)
    at eval (EitherT.js:24)
    at eval (ReaderT.js:12)
    at eval (Task.js:110)
eval @ withPrismicPreview.tsx:109

gatsby-config.js
    {
      resolve: 'gatsby-source-prismic',
      options: {
        repositoryName: 'karrot',
        accessToken: process.env.PRISMIC_ACCESS_TOKEN,
        schemas: {
          'mbti-test-result': {},
          mbti_intro: {},
          mbti_test_question: {},
          ads_intro: {},
          global_contents: {},
          faq: require('@karrotmarket/prismic-config/schema/faq.json'),
          site_navigation: require('@karrotmarket/prismic-config/schema/site_navigation.json'),
          terms_and_conditions: require('@karrotmarket/prismic-config/schema/terms_and_conditions.json'),
          member_profile: require('@karrotmarket/prismic-config/schema/member_profile.json'),
          team_contents: require('@karrotmarket/prismic-config/schema/team_contents.json'),
        },
      },
    },
    {
      resolve: 'gatsby-plugin-prismic-previews',
      options: {
        repositoryName: 'karrot',
        accessToken: process.env.PRISMIC_ACCESS_TOKEN,
        toolbar: 'new',
      },
    },

wrapRootElement (both gatsby-browser.jsx and gatsby-ssr.jsx)
import * as React from 'react';
import type { GatsbyBrowser, GatsbySSR } from 'gatsby';
import { PrismicPreviewProvider } from 'gatsby-plugin-prismic-previews';

export const wrapRootElement: (GatsbyBrowser | GatsbySSR)['wrapRootElement'] = ({
  element,
}) => {
  return (
    <PrismicPreviewProvider>
      {element}
    </PrismicPreviewProvider>
  );
};

the preview resolver page
export const linkResolver: LinkResolver = doc => {
  switch (doc.type) {
    case 'site_navigation': {
      return '/';
    }
    case 'faq': {
      return '/faq/';
    }
    case 'team_contents': {
      return '/';
    }
  }
  return '/';
}

export default withPrismicPreviewResolver(PreviewResolverPage, [
  {
    repositoryName: 'karrot',
    linkResolver,
  },
]);

the preview page is working as expected, redirect user to target page, provide the merged data into page.

@cometkim Are you saying the preview works normally, but an error is printed to the log? Can you confirm which version of the plugin you are using (the latest is 4.0.0-beta.11 as of this comment)?
Thanks!

I'm seeing the same following error:

This appears to be happening on all previews whether they are published or drafts. The preview page only says loading, then displays the error.
This is what I'm seeing in the console:

I'm using:

Node v14.15.4
Gatsby v3.6.1
<EMAIL_ADDRESS><EMAIL_ADDRESS>

I'm also seeing the same error...

FYI, I'm working on this issue but I'm having a hard time reproducing it. If you have any ideas or notice anything strange, please share!
I'll post updates here as I learn more.

@angeloashmore I will send invite you my working repo

@angeloashmore I just sent invitation to https://github.com/daangn/websites
And I'm currently working with gatsby-source-prismic beta on https://github.com/daangn/websites/tree/main/team.daangn.com
I can generate a prismic preview link when you needed. at me or DM me on twitter anytime you want.

Thank you @cometkim! I will take a look and reach out via Twitter if I get stuck.

I can also add you to my repo if you need to compare, just give me a shout.

@cometkim I was able to get previews working in your repo. Thanks for sharing it!
TL;DR: @greatwitenorth @jodiedoubleday @cometkim
Can you check that all pages using withPrismicPreview, withPrismicUnpublishedPreview, and withPrismicPreviewResolver have the repository configurations setup correctly?
The problem
The preview resolver page was working fine. The Link Resolver was returning / for most documents rather than the correct URL. This is okay, it just means you'll land on the home page rather than the document's page. The homepage, however, did not have withPrismicPreview setup correctly.
Before (not working):
export default withPrismicPreview(IndexPage, [])

After (working):
export default withPrismicPreview(IndexPage, [
  {
    repositoryName: 'karrot',
    linkResolver
  },
])

I updated the error message to be a little more descriptive. Basically, all pages that should be previewable should have withPrismicPreview around the default export. This involves adding the repository config as well. If the higher order component doesn't find a configuration for the repository, it will display the following error.

One way to simplify this is to make dedicated prismicPreviews.ts and prismicUnpublishedPreviews.ts files and setup your configuration objects there. Then you can import them into each page/template.
This repository contains an example of how I would recommend setting up previews: https://github.com/angeloashmore/gatsby-source-prismic/tree/beta/starters/gatsby-starter-prismic-typescript
Examples:

prismicPreviews.ts: https://github.com/angeloashmore/gatsby-source-prismic/blob/beta/starters/gatsby-starter-prismic-typescript/src/prismicPreviews.ts
prismicUnpublishedPreviews.ts: https://github.com/angeloashmore/gatsby-source-prismic/blob/beta/starters/gatsby-starter-prismic-typescript/src/prismicUnpublishedPreviews.ts
Template: https://github.com/angeloashmore/gatsby-source-prismic/blob/beta/starters/gatsby-starter-prismic-typescript/src/pages/{PrismicPage.url}.tsx

I've got mine working by changing...
export default withPrismicPreview(PageTemplate, [
  {
    repositoryName: process.env.GATSBY_PRISMIC_MAIN_REPOSITORY_NAME,
    linkResolver,
  },
])

to
export default withPrismicPreview(PageTemplate, [
  {
    repositoryName: 'juniper-studio',
    linkResolver,
  },
])

@greatwitenorth Thanks, I had a look at the code. Published previews worked fine for me, but I did need to add _previewable to the GraphQL queries. Without it, preview content won't be merged.
In 404.js, however, there was small typo that was causing the red error modal to appear. Note the repositoryName casing:
  export default withPrismicUnpublishedPreview(NotFoundPage, [
    {
-     repositoryname: "weareroadmap-clone",
+     repositoryName: "weareroadmap-clone",
      linkResolver,
      componentResolver: componentResolverFromMap({
        page: Page,
        insight: Insight,
        case_study: CaseStudy,
      }),
    },
  ])

@jodiedoubleday Glad you got it working! In general, I would recommend sticking to the process.env.GATSBY_PRISMIC_REPOSITORY_NAME pattern as it keeps your configuration more portable. You'll need to make sure it is setup properly in a .env file as well as wherever you are building your site (Netlify for example).
That being said, providing your repository name as a string works as well!

@angeloashmore I'm also having trouble getting these previews to work, followed some instructions in the tutorial and got some help from you earlier with my package.json-versions. Mind taking a look att what I am missing?
https://github.com/FagerKod/prismiclab

Hey @FagerKod, are you getting the same "A configuration object could not be found" error in the red modal?
Everything looks okay in your repository. The only unnecessary part I see is the Prismic toolbar in Layout.js. You can remove this as gatsby-plugin-prismic-previews will add it for you. This shouldn't be causing the problem, however.
https://github.com/FagerKod/prismiclab/blob/d9d0c835fda2999463c762b520d52952e63aa6c1/src/components/layout.js#L13-L17

@angeloashmore removed the script from Layout, thanks.
Still does not work, adding screen shot.

Got my stuff working, had to import linkResolver in a correct way e.g
import linkResolver ...
instead of import {linkResolver} ...
Thanks for input @angeloashmore !

Ah, glad you got it working! I'm learning that exact problem is actually quite common with the Link Resolver function. Maybe there's a better way we can teach how it set up the export/import.

I tried again with the latest version of the plugin and got the same error.
https://github.com/daangn/websites/pull/121

Hey @cometkim, it looks like your app doesn’t include PrismicPreviewProvider in gatsby-browser.ts.
Instructions: https://github.com/angeloashmore/gatsby-source-prismic/tree/beta/packages/gatsby-plugin-prismic-previews#gatsby-browser-and-ssr-files
Can you confirm this is in the app tree and let me know if the issue persists?

@angeloashmore it is included in a theme I use
https://github.com/daangn/websites/pull/121/files#diff-9502760eb59a5f354737ca6093b53d94e5ea3083d1356b40099ee5b8acf5ea6a

Got it, that makes sense. Can you try adding the provider directly in the site-specific gatsby-browser.ts file to see if it makes a difference? Trying to narrow down where the issue is happening. Thanks 👍

Oh, sorry @angeloashmore  It was my bad. I just forgot to build my theme on my local 😅
The previewing works fine in the latest version of the plugin. But it seems there's a SSR issue

The preview HoC doesn't seems to guarantee isomorphic results, the hydration is not work properly and layouts that rely on media queries look broken.

Maybe I can close this and open another issue

Hey @cometkim, no problem! Glad it was an easy fix. Yes, I'll close this issue but if anyone else runs into configuration issues, feel free to post here and I can help.

@angeloashmore I've found a small documentation discrepency that led to me getting this error for a while.
Partially my fault for copy/pasting without reading fully, but something many others can/will run into too.
Here, the API key is GATSBY_PRISMIC_*REPO*_NAME
https://prismic.io/docs/technologies/install-the-plugin-gatsby
And here it's both GATSBY_PRISMIC_*REPO*_NAME and GATSBY_PRISMIC_*REPOSITORY*_NAME depending on which part of the page you're looking at.
https://prismic.io/docs/technologies/previews-gatsby

@danspratling Good catch! That error will be fixed shortly.

Adding this context for someone else running into a similar issue in the future:
For me I narrowed down the issue as coming from the gatsby-browser.js file, and that replacing the process.env.<repo-name> variable with a string fixed it.  My PrismicProvider looked something like this:
export const wrapRootElement = ({ element }) => (
  <PrismicProvider
    internalLinkComponent={({ href, ...props }) => (
      <Link to={href} {...props} />
    )}
  >
    <PrismicPreviewProvider
      repositoryConfigs={[
        {
          repositoryName: process.env.PRISMIC_REPO_NAME,
          linkResolver,
          componentResolver: componentResolverFromMap({
            front_page: FrontPage,
          }),
        },
      ]}
    >
      {element}
    </PrismicPreviewProvider>
  </PrismicProvider>
)

Can you spot the issue?  Depending on what framework you are using, environment variables are not allowed to be accessed by the client browser, unless they are prefixed with a particular string.  So for me, changing the environment variable to GATSBY_PRISMIC_REPO_NAME solved the issue.


basic form 插槽如何动态添加表单项

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[ ] Read the docs.
[ ] Make sure the code is up to date. (Some bugs have been fixed in the latest code)
[ ] This is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Describe the bug
A clear and concise description of what the bug is..
Reproduction
Please describe the steps of the problem in detail to ensure that we can restore the correct problem
System Info

Operating System:
Node version:
Package manager (npm/yarn/pnpm) and version:

这不就随便发挥呀，插槽跟组件没区别


Community health index

Motivation
Add standard github documents and templates.
Each file is pushed as separate commit and it can be reviewed or rejected.
This change will help to tick all the boxes in the community profile.

It's worth having this +more than 20 github stars to raise project profile.
Suggestions
Additionally developers can add CODEOWNERS for assigning reviewers for specific parts of the code.

@maleck13 It looks like you got some outdated version when reviewing. RainCatcher was already removed.


 After deleting them, you'll be redirected to his profile and create 2 notifications:

for you as if you deleted his notifications
for him to let him know that his notifications have been deleted


Custom colour treshold only works with whole numbers (V.3.1.4)

Custom colour treshold only works with whole numbers
Here is an example with temperatures:
Code:
[...]
sort: state
colors:
steps:
- value: 18
color: lightblue
- value: 19
color: blue
- value: 20
color: yellow
- value: 22
color: green
- value: 23
color: red
- value: 24
color: darkviolet
tap_action:
action: more-info
collapse: 10
entities:

entity: sensor.klimasensor_kuche_temperature
entity: sensor.klimasensor_gaste_wc_temperature
entity: sensor.hwr_h_t_sensor_temperature
[...]

Output with Decimal numbers:

Output with Integers:

Thanks for reporting - fixed in v3.1.5


Can kafka-manager-<IP_ADDRESS> fully support kafka_2.11-0.10.2-kafka-2.2.0

I am using cloudera-kafka, the jar name is kafka_2.11-0.10.2-kafka-2.2.0.jar , can kafka-manager-<IP_ADDRESS> fully support ?
I cant find kafka-0.10.2 in kafka-manager add cluster page.
thinks first !

If you don’t see 0.10.2, then it doesn’t support in this release. What is the reason use old <IP_ADDRESS> if new version <IP_ADDRESS> available? Use the latest release and be happy :)


WIP: Remove use of deprecated (in 9.2) Exceptions API

@dr-itz setCause...I missed this when I was looking at this before.


[SPARK-28040][SPARK-28070][R] Write type object s3

Re-filing stale https://github.com/apache/spark/pull/24888

What changes were proposed in this pull request?

Migrate write* internals to use an S3 generic
Why are the changes needed?

Robustness -- old version was missing some cases like glue that would be treated properly as character by S3 dispatch
Does this PR introduce any user-facing change?

How was this patch tested?

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26616/
Test PASSed.

@HyukjinKwon oh! actually the issue is not transient.

The repository 'https://cloud.r-project.org/bin/linux/ubuntu bionic-cran35/ Release

that file doesn't exist anymore because the 35 folder is no longer the "head" of R -- it's migrated to 40:
https://cloud.r-project.org/bin/linux/ubuntu/bionic-cran40/

Test build #121942 has started for PR 28379 at commit 8e26641.

Thanks for pointing it out. I just opened a PR :-)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26618/
Test PASSed.

Test build #121944 has started for PR 28379 at commit 27f15ab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26620/
Test PASSed.

Test build #121942 has finished for PR 28379 at commit 8e26641.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121942/
Test FAILed.

Test build #121948 has started for PR 28379 at commit 38aa3e9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26624/
Test PASSed.

Test build #121954 has started for PR 28379 at commit 9a1ac4f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26629/
Test PASSed.

Test build #121944 has finished for PR 28379 at commit 27f15ab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121944/
Test FAILed.

cc also @felixcheung and @shivaram

Test build #121948 has finished for PR 28379 at commit 38aa3e9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #121954 has finished for PR 28379 at commit 9a1ac4f.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121954/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121948/
Test FAILed.

Test build #121992 has started for PR 28379 at commit f1aac7f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26667/
Test PASSed.

Test build #121992 has finished for PR 28379 at commit f1aac7f.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121992/
Test FAILed.

Test build #121994 has started for PR 28379 at commit 09d397b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26669/
Test PASSed.

Test build #121994 has finished for PR 28379 at commit 09d397b.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121994/
Test FAILed.

Test build #122009 has started for PR 28379 at commit 849bc25.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26682/
Test PASSed.

Test build #122009 has finished for PR 28379 at commit 849bc25.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122009/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26687/
Test PASSed.

Test build #122014 has started for PR 28379 at commit 648ad44.

Test build #122014 has finished for PR 28379 at commit 648ad44.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122014/
Test FAILed.

Test build #122048 has started for PR 28379 at commit 2e3fa24.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26723/
Test PASSed.

Test build #122048 has finished for PR 28379 at commit 2e3fa24.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122048/
Test FAILed.

Latest commit was vetted for regression by comparing output of a bunch of common / edge case objects; those tests are here, might make sense to include them as unit tests:
https://gist.github.com/MichaelChirico/58327b30aa865fd8bb234b7b98fa6df9

Test build #122050 has started for PR 28379 at commit 950da2c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26725/
Test PASSed.

Test build #122054 has started for PR 28379 at commit 8af440d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26729/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26730/
Test PASSed.

Test build #122050 has finished for PR 28379 at commit 950da2c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122050/
Test FAILed.

Test build #122055 has started for PR 28379 at commit ba4a65e.

Test build #122055 has finished for PR 28379 at commit ba4a65e.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122055/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26738/
Test PASSed.

Test build #122064 has started for PR 28379 at commit 780cef7.

Test build #122054 has finished for PR 28379 at commit 8af440d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122054/
Test FAILed.

Test build #122064 has finished for PR 28379 at commit 780cef7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122064/
Test FAILed.

Test build #122082 has started for PR 28379 at commit b57c79a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26757/
Test PASSed.

Test build #122084 has started for PR 28379 at commit 899cec5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26759/
Test PASSed.

Test build #122082 has finished for PR 28379 at commit b57c79a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122082/
Test FAILed.

Test build #122084 has finished for PR 28379 at commit 899cec5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122084/
Test FAILed.

alright i'm stuck. what could cause this?

R worker produced errors:
no applicable method for 'writeObject' applied to an object of class "c('integer', 'numeric')"
Calls:

Test build #122107 has started for PR 28379 at commit 8b8ab75.

what could cause this?

I believe it was the use in worker.R of SparkR:::writeObject; since there were no S3 methods registered in NAMESPACE we get that error

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26781/
Test PASSed.

Test build #122107 has finished for PR 28379 at commit 8b8ab75.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122107/
Test FAILed.

Test build #122110 has started for PR 28379 at commit 94fe31f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26784/
Test PASSed.

Test build #122110 has finished for PR 28379 at commit 94fe31f.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122110/
Test FAILed.

Test build #122111 has started for PR 28379 at commit 7fccb3a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26785/
Test PASSed.

Test build #122111 has finished for PR 28379 at commit 7fccb3a.

This patch fails R style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122111/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26786/
Test PASSed.

@HyukjinKwon 7fccb3ab4b9658aa57a1ebab3aedc0c1633d5bc8 failed linting on Jenkins, but not on GH Actions. The error:
inst/worker/worker.R:81:62: style: Opening curly braces should never go on their own line and should always be followed by a new line.
    arrow = SparkR:::writeArrowSerialize(output, outputCon), { # brace here for linter...
                                                             ^
lintr checks failed.
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-r ; received return code 1

Two things:

Is the lintr version on Jenkins up to date? I see there was something added to lintr in Sep '19 about this, so if the Jenkins version is <= 1.0.3, that could be the source
Is it necessary to have both Jenkins and GitHub running the linting check?

Test build #122112 has started for PR 28379 at commit f4757da.

Test build #122112 has finished for PR 28379 at commit f4757da.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122112/
Test FAILed.

Test build #122115 has started for PR 28379 at commit 3e3f68a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26789/
Test PASSed.

Test build #122115 has finished for PR 28379 at commit 3e3f68a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122115/
Test FAILed.

Test build #122121 has started for PR 28379 at commit 232be9c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26795/
Test PASSed.

Test build #122121 has finished for PR 28379 at commit 232be9c.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/122121/
Test FAILed.

Alright, completely and totally stuck now.
Could go for an extra pair of eyes / advice on how to further debug @HyukjinKwon .
Have done extensive regression testing, see https://gist.github.com/MichaelChirico/58327b30aa865fd8bb234b7b98fa6df9
Two types of test (1) test a bunch of common objects to be sure writeObject is producing the same bits on master and this branch (2) ran pkg/run-tests.sh where I added some code to writeObject to save() the input of all instances of writeObject encountered during the tests, then do the old-v-new comparison on all of those.
Both are successful, so as near as I can tell, the new and old writeObject are always producing the same output.
But still we're failing (it seems a timeout error??)
I'm also not able to reproduce the same errors as Jenkins or Appveyor (which have different errors) locally, so it's hard to know how to proceed.
I'm also not able to run pkg/run-tests.sh on master locally either, FWIW (Spark itself builds under ./build/mvn -DskipTests clean package), further complicating the dev process...

For the Jenkins lintr, I see now it's 2.0.0 installed from GitHub; this can probably be handled by CRAN now right? 2.0.1 is on CRAN

New & old writeObject differ for this input:
x = c(1:2, NA)

# old
rc = rawConnection(raw(), 'rb')
writeObject(rc, x)
rawConnectionValue(rc)
#<PHONE_NUMBER>030000000100000002
close(rc)

# new
rc = rawConnection(raw(), 'rb')
writeObject(x, rc)
rawConnectionValue(rc)
#<PHONE_NUMBER>03000000010000000280000000
close(rc)

However, the old code throws a warning in this case, so I doubt that such input was observed previously.

I didn’t review but I recall something similar this to support glue like 2 or 3 years ago? This serde is very sensitive - we probably need (to add) a lot more tests on this (existing tests are not very comprehensive)

Thanks @felixcheung indeed that was me filing that issue about glue 😅
This PR is intended to be a much more general solution to that issue -- a glue object would be passed to writeObject.character under this PR.
There are already a bunch of tests you could basically drop in from the gist above.
My suspicion at the moment is that the usage in worker.R is the issue, but I'm having trouble debugging that. Any suggestion for debugging the executor process?

Test build #126420 has started for PR 28379 at commit ed5f19b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31034/
Test PASSed.

Test build #126420 has finished for PR 28379 at commit ed5f19b.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126420/
Test FAILed.

why not just coerce inputs to class character?
SparkR:::sql.default <- function (sqlQuery) {
    sparkSession <- getSparkSession()
    sdf <- callJMethod(sparkSession, "sql", as.character(sqlQuery))
    dataFrame(sdf)
}


"dependencies were not found:" - from node v.18

Package Name: core-reset-pipeline
Package Version: 1.16.1
Operating system: mac
[ x] nodejs

version: 18

Describe the bug
updating from node 16 to 18 introduces an inability for electron to compile. We see the following error:
><EMAIL_ADDRESS>electron:serve
> vue-cli-service electron:serve

 INFO  Starting development server...

 DONE  Compiled successfully in 2856ms                                                                                4:03:23 p.m.

  App running at:
  - Local:   http://localhost:8080/
  - Network: http://<IP_ADDRESS>:8080/

  Note that the development build is not optimized.
  To create a production build, run npm run build.

⠹  Bundling main process...

 ERROR  Failed to compile with 11 errors                                                                                4:03:27 p.m.

These dependencies were not found:

* node:http in<EMAIL_ADDRESS>* node:https in<EMAIL_ADDRESS>* node:os in<EMAIL_ADDRESS><EMAIL_ADDRESS>* node:process in<EMAIL_ADDRESS><EMAIL_ADDRESS>* node:stream in<EMAIL_ADDRESS><EMAIL_ADDRESS>* node:util in<EMAIL_ADDRESS><EMAIL_ADDRESS>* node:zlib in<EMAIL_ADDRESS>
To install them, you can run: npm install --save node:http node:https node:os node:process node:stream node:util node:zlib

as noted in the error, trying to install the modules with or without the node: prefix does not resolve the issue.
To Reproduce
Steps to reproduce the behavior:
update a working vue app (eg: https://github.com/trek-eric/vue_app_18) from node v16 to v18 (LTS) that includes an azure dependency using core-rest-pipeline. The newly prefixed imports using "node:" will break after node 16
nvm use 16
vue create app
cd app
vue add electron-builder
npm install --save applicationinsights
add to background.js
let appInsights = require('applicationinsights');
console.log(appInsights)

npm run electron:serve (works!)
nvm use 18
npm update --save
npm run electron:serve
Expected behavior
i expected the application to build per normal in v.16
Screenshots

I'm a bit confused about this report. Are you saying that node: imports are working in node16 but not in 18? From what I can see it should work in both: https://nodejs.org/docs/latest/api/esm.html#node-imports
Are you using 1.16.1 of @azure/core-rest-pipeline in both? Can you reproduce this by depending only on @azure/core-rest-pipeline instead of transitively through applicationinsights?
If not, perhaps file an issue in the app insights GitHub and they'll have a better idea of how to help: https://github.com/microsoft/ApplicationInsights-node.js


Merge master branch to prTesting1_201903070904 branch

OPS Build status updates of commit 6f822bf:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: OPS Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

OPS Build status updates of commit 6f822bf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon1.md
:bulb:Suggestion

Details

split/updateTestCon1.md

[Suggestion] Missing attribute: author. Add a valid GitHub ID.
[Suggestion] Missing attribute: ms.author. Add a valid Microsoft alias.
[Suggestion] Missing attribute: either ms.prod or ms.service is required. Use ms.prod for on-premise products, or ms.service for cloud services.
[Suggestion] Missing attribute: ms.topic. Add a valid value to indicate the article type.
[Suggestion] Missing attribute: ms.date. A freshness date is required for this content set. Add a date in format MM/DD/YYYY.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


FancyZones loses custom zones after update

Microsoft PowerToys version
0.53.3
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce

Create custom zone(s) in lower app version
Update application
Check custom zone(s)

✔ Expected Behavior
After updating FancyZones retains custom layouts.
❌ Actual Behavior
After updating versions, FancyZones no longer retains custom layouts.  Other settings in the app seem to be retained during my testing.
Other Software
No response

@SeraphimaZ Duplicate of #14782?

I also saw this. I believe I updated from 0.53.1 to 0.53.3. If it helps, here's the bug report zip file.
PowerToysReport_2022-01-14-08-14-09.zip

@jasonanders @SvendK can you please specify what "loses" means?
As I can see in the logs from the bug report, there are custom layouts saved and no new layout was created. So were they just reset to the default one and you still have them in the editor?

I have a similar behaviour, albeit a little more limited.
I have connected a second monitor to my notebook via USB. On this one I use two custom zones.

Start computer -> User defined "Home-Office" zone work as expected

Away -> Computer goes into sleep mode

Wake up computer -> Default Zone "Büro" is used even if "Home-Office" is shown as selected

Call another layout, then the wanted one again, don't work.
It helps to deactivate FancyZones once in the PowerToys and then activate them again.
But then only that one user defined zone is visible in the editor:

Restarting the hole PowerToys brings back all user defined zones.

Thank you all for the explanation.
@JHCD can you please attach a bug report to let me see logs? Probably more info can help.
I checked @SvendK bug report and didn't see any error in FZ and in the FZ Editor as well. Moreover, nothing seems to be lost according to logs. For some reason they just weren't shown in the editor.

/bugreport

@SeraphimaZ
I had to wait for the error to appear again, attached the bug report.

Probably more info can help.
What do you want to know? I think I described the problem, what am I missing? I am of course happy to answer any questions.

PowerToysReport_2022-01-20-19-55-28.zip

Happened to me as well. All my custom zones are now missing/deleted.
The "custom-zone-sets" key in zones-settings.json in %LocalAppData%\Microsoft\PowerToys\FancyZones is empty.

What do you want to know? I think I described the problem, what am I missing? I am of course happy to answer any questions.

Thank you for the bug report, I found the problem. The fix is ready!

Oh my god, sorry for missing your replies.
I have been ill and actually forgot a little about this. I don't remember if my custom layouts got deleted or the default layouts was just selected instead. The latter has definitely been a problem a couple times. It happens mostly when I change from my home office (laptop-screen + one HDMI ultrawide monitor), using the laptop alone and work office (laptop screen, 4K and 3K vertical via USB-C dock) - and I haven't been much at the office lately.
But great that you have found a bug and working on it. Thank you for your work. Unsure if this is a voluntary job or paid my Microsoft, but nonetheless, thank you for PowerToys!

The was fixed in in 0.55. Head over to https://aka.ms/installpowertoys to try it out

@SeraphimaZ Thank you for the quick solution!

Not sure if I need to open a new issue, but just updated to 0.56.2 and now my zones are missing again.
I didn't reboot after the update. Still running as administrator. No changes other than the update.
Moving a window with Tab has the three vertical zones on each monitor each with a margin, which I don' use.
When I open the Layout editor, I see that my first monitor (laptop internal) actually retained it's set custom monitor, but my two external monitors is reset to default Priority Grid layout. My custom layouts are still there, just not selected for my two external monitors.
Maybe the bugfix closing this issue was only fixing the first monitor and they forgot about multi monitor setups?
I hope you'll look into this again :-)
Bugreport
PowerToysReport_2022-03-08-10-45-12.zip

When I open the Layout editor, I see that my first monitor (laptop internal) actually retained it's set custom layout, but my two external monitors is reset to default Priority Grid layout. My custom layouts are still there, just not selected for my two external monitors.

It's a known problem for laptops with external monitors. For some reason, name of the monitor is different, so FancyZones thinks that it's a new one and sets the default layout there.
Main issue for this problem: https://github.com/microsoft/PowerToys/issues/16370

I did actually update the firmware of my USB-C Lenovo dock just about there, could be the cause. No changes to audio or other stuff and Windows also remembered screen resolution and locations of the displays after the firmware update, though. Let's leave it at that and see if it returns.

@SeraphimaZ
Hi,
Unfortunately, the same problem occurs again (see: https://github.com/microsoft/PowerToys/issues/15529#issuecomment-1012934806) in version 0.56.2. After the notebook wakes up, the configuration on the connected monitor is no longer correct.
I've attached the bug report.
PowerToysReport_2022-03-11-12-26-57.zip

Lost all of my custom FancyZone layouts after updating to v0.59.0. I am very pleased with PowerToys in general and FancyZones in particular, so don't want to sound ungrateful. But this issue is very annoying and similar complaints go back at least to 2020. Will this problem ever be resolved adequately? I'm not an expert, but how hard can it be to hold on to a bunch of configuration settings?

Duping to most recent mention of this problem. /dup https://github.com/microsoft/PowerToys/issues/32978


Update icons

New icons for the application. @hzarea thanks!

Could you also insert in the PR the original (photoshop?) vector files?

I've created a new PR with an editable file (.svg)!


Project is excluded from Hacktoberfest 2021?

Even though my PR had the appropriate tag, it has flagged up as being excluded?

@HaylzRandom yes now it's a practice project


Production usage?

Are still missing many bits and data types that would prevent this package from being used in production?  Would you recommend against using the latest?
Thanks
Samuel

Hey, so as with any beta software, using it in production has its risks, so we it's your call on whether the benefits justify the risk. That being said, we feel pretty good about the stability of existing functionality. As we're based on a database that is heavily used in production, we expect the functionality that is implemented to be robust and stable enough for production usage.
The reason why we're designating the project as beta is because there's a fair amount of features supported by other Realm SDKs that we want to support. It also gives us a little bit more flexibility when it comes to breaking changes. We don't expect any major breaking changes before we go GA, but we may change some things based on user feedback.

Thanks for the reply.  Definetely going to have a look at implementing the package.  Not sure if I'm going live with it yet or not.  Thanks again!


add maplibre-gl-js 3.x.x to peerDependencies

I only did some simple manual testing, so far it seems to work with 3.3.1
fixes #50

@lseelenbinder thanks for merging! Are there any plans to publish a new release soon? :)

Maybe you can create a pull request for the release @goapunk ? Here seems to be some documentation https://github.com/maplibre/maplibre-gl-leaflet/blob/main/CONTRIBUTING.md

@wipfli will have a look

Just deployed those changes @goapunk. Thanks for the PRs!


Improve TextDataset

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #55   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     11
  Lines         438    435    -3
=====================================
- Hits          438    435    -3

Impacted Files
Coverage Δ

lineflow/text.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e10e8e...9ce10d4. Read the comment docs.


Move to HTTPS to stop mixed content error

https://developer.mozilla.org/docs/Security/MixedContent
Firefox now blocks XHR requests to HTTP sites from HTTPS origins. We do this with the is.gd API call, though their API works on HTTPS too (demo)

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Thanks!


Create 1.0-Beta release

Checklist:

[x] Version number will be 1.0.0b0
[x] Replace "Unreleased" to "1.0.0b0" in changelog
[x] Write installation instructions on how to install prereleases:
- pip install --pre imod=1.0.0b0
- conda install imod=1.0.0b0
- pixi install imod=1.0.0b0
[x] Tag git version as "1.0.0b0"
[ ] Ensure material is uploaded to PyPI as beta release
[ ] Ensure beta release ends up in imod-feedstock

Relevant docs about version specifiers:

https://packaging.python.org/en/latest/specifications/version-specifiers/#pre-releases
https://packaging.python.org/en/latest/discussions/versioning

It's installable via PyPI


Added Jenkins version to service package version

Added the Jenkins version to the service package version since there are many different Jenkins versions available with different characteristics (JDK support, plugin compatibility etc) and it would be useful to know which Jenkins version to install when selecting a Jenkins package in DC/OS. With current master, there is no obvious way to know the Jenkins version beforehand.
This also aligns with other packages that uses the same denotation.

@ssk2 can you pls review this PR? Has been sitting here for almost a month :(

Oops, apologies @tommysdk. I can't merge this into the current package because we're about to significantly refactor this package (next week) but I will make sure this change happens.

@ssk2 ok. Would appreciate a notification when the change has been introduced!

@tommysdk, we are now doing this: https://github.com/mesosphere/universe/blob/version-3.x/repo/packages/J/jenkins/11/package.json#L4

@ssk2 nice, thanks!


avoid hard crash in CTiglPatchShell

Minor fix to prevent a hard crash in CTiglPatchShell. Fixes #700

Doesn't this simply change the exception type? Why is this safer than before?

There was no exception handling in that function before.

No, but with the change you are catching an arbitrary exception and create a new one CTiglError. You you are converting the exception from opencascade into a tigl exception. The question is, why the opencascade exception has not been caught before.

The question is, why the opencascade exception has not been caught before.

My guess is opencascade doesn't properly handle this exception?

Codecov Report

Merging #701 into master will decrease coverage by 0.00%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   68.52%   68.52%   -0.01%
==========================================
  Files         424      424
  Lines       23179    23181       +2
==========================================
  Hits        15884    15884
- Misses       7295     7297       +2

Impacted Files
Coverage Δ

src/geometry/CTiglPatchShell.cpp
89.18% <84.61%> (-2.48%)
:arrow_down:

Very good!


User preference: Redirect to ticket detail page on service request save #12

Hi.
Also in this request fix of 'post '/userprofile' #36' issue.

Good day,
Thank you for the pull request.
I will review and merge the changes shortly.
BTW, I've added you to the Contributors list in the ReadMe. 🥇
-Nitin


010 Library of Congress Control Number

Map the OXX spreadsheet

https://docs.google.com/spreadsheets/d/1O_tBQqCMUpDz4SS_u5SWX0fP9Ww9Szn8iN5L2lquvyE/edit#gid=9363292
Hello Everyone,
Please see the first pass of 010 - Library of Congress Control Number (NR). Is it possible that someone might review my work?
Thank you.
Best,
Alice


InlineForm adds two non-targetable divs to DOM layout

Description
Not sure if this is a "bug", but it's breaking behaviour for me. InlineForm appears to be rendering two classless divs when added to a page since updating to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Steps to reproduce
Add an inline form. See the divs.
Expected result
Inline form shouldn't require any DOM elements?
Actual result
Inline form is adding DOM elements, and they can't be classed or managed, so they mess up my design.
Environment
Tinacms Package Versions

N/A

Tools

Tool
Version

browser
safari@latest

os
macos

node
LTS

npm
LTS

Are you upgrading from 0.33 or an earlier version?

@dwalkr went from 0.30.0 => 0.34.0 => 0.35.0

I checked out v0.30.0 and ran demo-next in the monorepo, and still have the two wrapping divs. I can see how that's could be a problem, but doesn't seem to be a regression from previous behavior.
If you think it's a regression, I think we'll need more info and, ideally, a reproduction of the problem.

@dwalkr irregardless of it being a regression or not, it is a problem, because the divs have no reliable way of targeting with CSS.
Ideally they wouldn't be there at all. But if that's a big challenge, then making them easier to target to fix styling would be ideal.

I completely agree, but there is a difference between "my existing Tina setup suddenly broke after an update" and "Tina is hard to work with because X" in terms of how we prioritize an issue like this.

Inline form shouldn't require any DOM elements?

You can see from PR #1726 (and issue #1725) why those divs are required.
They're used for capturing events that will deselect any selected inline form field.
Perhaps though there is another way to do this though, which doesn't require extra divs.
Note that the <Dismissible> component (which renders the other div) lives in another repo: https://github.com/tinacms/react-dismissible/blob/5bf1d004505a4ede9c8fab72b5b5057b94346821/src/Dismissible.tsx#L57-L75

So, right now we have two extra divs covering the exact same space (i.e. one is just inside the other, & neither have padding or margin)...
The first div is only used for capturing clicks inside the space
The second div is only used for capturing clicks outside the space.
I think we could remove both divs and instead use useEffect to attach a single click handler to the document body.
The only complication with this is that clicks outside the space are handled slightly differently than clicks inside the space..
Clicks outside the space are ignored if settingsModalIsOpen (see current InlineForm implementation below).
But I think it makes sense to also apply this logic to "inside clicks" also anyway.
Current InlineForm implementation: https://github.com/zenflow/tinacms/blob/3e8aab4f324454752e2a88d99e9bdf869c26447f/packages/react-tinacms-inline/src/inline-form.tsx#L44-L90

What is the status of this issue?
Cause the divs are still being created and there is no way to interact with them other then to add a styled-container to style them :slightly_frowning_face:.


Convert Storage class table (now Copy options) to PF, add claims and namespaces columns, other UX fixes

Fixes #587
Fixes #804
Fixes #773
This PR renames the StorageClassForm and StorageClassTable to CopyOptionsForm and CopyOptionsTable, to match Vince's mockups. It adds Claim and Namespace columns, updates text to match the mockups, and converts the table to PF using the same sorting/filtering/pagination abstractions I wrote in https://github.com/konveyor/mig-ui/pull/776 and https://github.com/konveyor/mig-ui/pull/803.
In the process of rewriting the form and table components, I gave them the same treatment as the last 2 wizard steps (moved non-presentational logic out of the table component, removed redundant state, flattened unnecessary useEffect logic into render logic). While doing this I saw that the condition for setting recommended storage class settings would always be false (#804), so I fixed it in 6782c71 .
Since the copy options and storage class columns have values that don't come directly from the PV object (they perform lookups), I needed to enhance the useFilterState and useSortState hooks so they can take functions rather than string keys for determining the value to match/sort by. useFilterState now takes the filterCategories as an argument, and a filter category can optionally have a getItemValue function in it (if omitted, the category key will be used as before). The useSortState hook takes a getSortValues function instead of a sortKeys array.
I also changed the filter logic so rows will not match a filter if they have a null/undefined value for the selected field (so that "Target storage class: None" doesn't match every filter) and so that search filters are case insensitive.
This PR does not include the Verify copy column, that will be in a separate PR to address https://github.com/konveyor/mig-ui/issues/788.
Before

After

So what do you think about dropping the Migration type column (it's always Copy).

+1, it's entirely redundant

Ideally, we skip the step entirely, but since we're tight on time, if it's easier to display an empty state for the table we should do that. I can provide text.

Also +1, I'd really like to explore the ability to conditionally skip wizard steps and see how expensive that will be to do with the current state of the code. For 1.2, let's go with an empty state (for some reason I feel like this had been implemented at one point?)

Thanks @eriknelson @vconzola. Just pushed updates to address those comments.
Table with migration type column removed:

Empty state (no results match the filters; I also added this one to the last 2 wizard steps):

Empty state (no PVs selected for copy):


screenshot not working

Also, I tried the screenshot feature and it grabs black screenshot and it inhibits the usual screengrab tools, which doesnt allow me to use the classic crtl +V in Photoshop either. So the software doesnt work and having it installed I can`t take any screenshot in any other way.
Any solution?

You can change the ScreenShot hotkey at Configure | Hokeys, then other programs will not be inhibited.
There's an option for ScreenShot Save Location. You can set it to Clipboard.
Regarding the black screenshots, which version of Windows do you have? Also, which of the following screenshots work:

Full Screen
Specific Screen
Window
Region

Hi,
thanks. now the photoshop option works again and when I hit screenshot
desktop (alt+2 the new shortcut) it grabs what I have on the desktop (the
whole thing on both screens).
The only othe option is screenshot  and it goes black every time, but I
don`t have all those other options in the save menu: I only have disk,
imgur and clipboard.
On Mon, May 14, 2018 at 10:20 PM, Mathew Sachin<EMAIL_ADDRESS>wrote:

You can change the ScreenShot hotkey at Configure | Hokeys, then other
programs will not be inhibited.
There's an option for ScreenShot Save Location. You can set it to
Clipboard.
Regarding the black screenshots, which version of Windows do you have?
Also, which of the following screenshots work:

Full Screen
Specific Screen
Window
Region

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MathewSachin/Captura/issues/199#issuecomment-388949283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AldY6hzd4zz_qfWub7oksuv_N4TBzw_Xks5tyecAgaJpZM4T-X3B
.

Hello,
for the log file, I clic on the copy to clipboard button, but when I go
into the system32 folder looking for the clip.exe file to run it, it
appears and disapperas immediately so, I`m not sure how to visualize what
is in the log file and send it to you. any solutions for that?
On Mon, May 14, 2018 at 10:34 PM, angy pop<EMAIL_ADDRESS>wrote:

Hi,
thanks. now the photoshop option works again and when I hit screenshot
desktop (alt+2 the new shortcut) it grabs what I have on the desktop (the
whole thing on both screens).
The only othe option is screenshot  and it goes black every time, but I
don`t have all those other options in the save menu: I only have disk,
imgur and clipboard.
On Mon, May 14, 2018 at 10:20 PM, Mathew Sachin<EMAIL_ADDRESS>wrote:

You can change the ScreenShot hotkey at Configure | Hokeys, then other
programs will not be inhibited.
There's an option for ScreenShot Save Location. You can set it to
Clipboard.
Regarding the black screenshots, which version of Windows do you have?
Also, which of the following screenshots work:

Full Screen
Specific Screen
Window
Region

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MathewSachin/Captura/issues/199#issuecomment-388949283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AldY6hzd4zz_qfWub7oksuv_N4TBzw_Xks5tyecAgaJpZM4T-X3B
.

I was not specifying Screenshot options.
The options: Screen, Region, etc. are video sources, first dropdown from top-left.

oh I see,
I gave it a try and:
screen > works OK
region > works OK
windows > it only grabs my toolbar is that normal?
Desktop duplication > goes black
On Tue, May 15, 2018 at 4:32 AM, Mathew Sachin<EMAIL_ADDRESS>wrote:

I was not specifying Screenshot options.
The options: Screen, Region, etc. are video sources, first dropdown from
top-left.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MathewSachin/Captura/issues/199#issuecomment-389023529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AldY6sZcH0JtNuWxA7nGRnpHP8xQH6NCks5tyj5PgaJpZM4T-X3B
.

Window can be customized from the second dropdown.
Regarding Desktop Duplication, which version of Windows do you have and also do you have graphic cards, single or multiple?

ok, got it.
I`m using windows 10 with a single graphic card: MSI GeForce GTX 1080 SEA
HAWK X
On Tue, May 15, 2018 at 11:57 AM, Mathew Sachin<EMAIL_ADDRESS>wrote:

Window can be customized from the second dropdown.
Regarding Desktop Duplication, which version of Windows do you have and
also do you have graphic cards, single or multiple?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MathewSachin/Captura/issues/199#issuecomment-389111878,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AldY6kaEROArlfeJK-EWm2zQaMRukJHwks5tyqZ_gaJpZM4T-X3B
.

Please try both running Captura with and without GPU and try if Desktop Duplication works in any case.

Desktop Duplication now captures ScreenShot in the same way as Screen, so this issue should not occur in future releases. While there is a known issue regarding capturing with Desktop Duplication failing on devices with hybrid graphics when Captura is run on the dedicated graphic card.


Add Mapper #11 (Color Dreams) support

Here we add support for some... I guess you could call them "games"... :man_shrugging:

@jntrnr looks like some header files in SerentyOS Setup have changed ..


Improve diagnostic when automatic resolution is disabled

Show the exact path where we looked for a resolved file
Special case if there wasn't a file to begin with

rdar://81172549

@swift-ci please smoke test

There are probably some tests that need updating, I didn't run the suite locally 😬

@swift-ci please smoke test

@swift-ci please smoke test

11:22:27 error: signalled(6): /Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/usr/libexec/swift/pm/swiftpm-xctest-helper /Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/swiftpm/.build/x86_64-apple-macosx/debug/SwiftPMPackageTests.xctest /var/folders/_8/79jmzf2142z2xydc_01btlx00000gn/T/TemporaryFile.tAiaIg output:
11:22:27     dyld: Library not loaded: @rpath/XCTest.framework/Versions/A/XCTest
11:22:27       Referenced from: /Users/buildnode/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx/branch-main/usr/libexec/swift/pm/swiftpm-xctest-helper
11:22:27       Reason: image not found

@swift-ci please smoke test

Self-hosted macOS is failing due to unrelated reasons, so this can be merged.


Minor improvements

Changes the Help window to use hyperlink instead of copy URL.
Add keyboard shortcuts for Links
Fixes the scrollbar color
Limits the maximum width of a label in a tag, truncates the text otherwise.

Codecov Report
Base: 71.89% // Head: 71.38% // Decreases project coverage by -0.50% :warning:

Coverage data is based on head (035bd55) compared to base (17e597c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #124      +/-   ##
============================================
- Coverage     71.89%   71.38%   -0.51%
  Complexity      684      684
============================================
  Files           100      100
  Lines          2124     2139      +15
  Branches        277      277
============================================
  Hits           1527     1527
- Misses          514      529      +15
  Partials         83       83

Impacted Files
Coverage Δ

src/main/java/seedu/address/ui/EventCard.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/HelpWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/ProfileCard.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Recording of iterative message sends is wrong/counterintuitive

Steps to reproduce:
m := Morph new.
3 timesRepeat: [m addMorph: Morph new].

MessageSendRecorder new
	watchPackageNamed: #Morphic;
	setMessageSend: [m submorphsDo: [:n | n show]];
	record;
	browse.

Output:

The representation is counterintuitive. When using #recordAllObjects, the argument n is not recorded either.
Rather, I would expect to see three children of the Morph>>submorphsDo: node, one for each invocation of the [] in UndefinedObject>>DoIt block.

Unfortunately, the number of nested nodes does not even correspond with the number of iterations but the number of calls from the iterator block ...

Interesting. Well, it is not possible to catch neither block evaluation nor its return. That []-record is created manually. You discovered the drawback of that.
See:
https://github.com/hpi-swa/MessageSendRecorder/blob/master/packages/MessageSendRecorder.package/MessageSendRecorder.class/instance/recordSendId.method.receiver.arguments.context..st
Would be nice to also simulate the block return somehow.

Hm, in theory, this should be solved by checking #outerCode of the right CompiledBlock, shouldn't it? And does MSR support the V3.X bytecode set all?

I don't think that I use SistaV1-specific calls. should work with V3PlusClosures, too.

But this refers to SistaV1 explicitly:
https://github.com/hpi-swa/MessageSendRecorder/blob/befc38911ab66cc810aaa03539ae7b6d8374c0b3/packages/MessageSendRecorder.package/MessageSendRecorder.class/instance/recordSendId.method.receiver.arguments.context..st#L10
In V3PlusClosures, we don't have CompiledBlocks, so aContext method will always equal closure homeMethod, correctly?

Correct. So, where is the issue? :-) Just the comment refers to SistaV1, not the code.

FWIW, here is another erroneous record that assumes recursion instead of method calls:

Recorded watching the packages #(Metacello Gofer) with #recordAllObjects.


Give the user the ability to choose if podman service should be enabled+restarted

Hi, first of all I want to thank you for this role! It's very useful :)
Your role enables and starts the podman.service systemd unit at the end, but in my setup I'm using Podman only as an unprivileged user and I don't want the Podman socket running in the background as root.
A possible solution to this problem is to implement a enable_and_start_podman_service variable in the Ansible role to let the user choose. I'm going to make a pull request for you. Let me know what you think :wink:

Nice for suggestion but I had additional concern:

My podman related packaging and Ansible Roles are not fully tested with unprivileged user, yet
Sometime unprivileged user mode couldn't working as expected, see https://github.com/alvistack/ansible-role-podman/issues/9
As a fail-safe and fallback, I mainly use privileged mode with sudo for my daily operation, see https://github.com/alvistack/docker-ubuntu/blob/master/molecule/ubuntu-22.04-docker/molecule.yml#L17-L23
This Ansible Role share AS MUCH AS possible homogeneous coding style and logic with else my ~120 Ansible Roles; this systemd service enable + start logic is designed with KISS, ensure functioning in most cases if possible (i.e. without additional configuration, both functioning for privileged or unprivileged mode)

Usually it looks like sexy for an additional configuration parameter; BTW, unless around 20~50% use case need this ability for switching, else I will not add a new parameters that I am not going to use daily, for myself and both my paid clients.

Ok no problem, I understand. Thanks for your time and for the detailed explanation :)


How can I read input and output node from frozen inference model (.pb)?

@bendangnuksung
Thanks for your great repository. it helps me lot.
Would you suggest me please How can I read input and output node/tensor from frozen inference graph (.pb)?
Thanks again

Hi @ibrahimLearning
How is it different from Issues #9? Judging from your comment on #9 you seem to have successfully able to use the frozen model.

Hi @ibrahimLearning
How is it different from Issues #9? Judging from your comment on #9 you seem to have successfully able to use the frozen model.

@bendangnuksung
Thanks for your reply
Yes I used the frozen model using forward.py, what you provided. It was used for detection. In the internal code, the following segment mentions output nodes:
       self.outputs = {             'detection': 'mrcnn_detection_4/Reshape_1',             'class': 'mrcnn_class_4/Reshape_1',             'box': 'mrcnn_bbox_4/Reshape',             'mask': 'mrcnn_mask_4/Reshape_1'}
But my problem is to display or read the node input and output from .pb file.
Is there any clue please?
Thanks


Sample - Allow for running HSQLDB in Server Mode

For introspection purposes, it would be useful to have an option to run HSQLDB in "server" mode. That way, user can more easily inspect the data, e.g. using DBeaver.

Resolved by commit 1997d5c0f50c8d18f521f7a7b71be74644f940e4


MM-47280 : Migrate "/ad_ldap/" e2e tests to TypeScript

Summary

Converting following spec files under /integration/ad_ldap to Typescript

saml_ldap_sync_id_attrib_spec.js
saml_ldap_sync_remove_spec.js
saml_ldap_sync_spec.js

Ticket Link

Fixes mattermost/mattermost-server#21302
Related Pull Requests

No
Screenshots

No UI changes.
Release Note

NONE

Hello @joremysh,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/255672

@joremysh Sorry for late response I notice that createLDAPUser function is returning empty object. Am I missing something ? I checked adding cy.log
cy.createLDAPUser({prefix: 'ldap', user: {}}).then((user) => {
      cy.log(" createLDAPUser " + JSON.stringify(user))
      samlLdapUser = user;
        });

I cannot run the test on local machine and also cannot check the e2e test result.
It seems the API requires an Enterprise Edition.
Body: {   "id": "api.license.upgrade_needed.app_error",   "message": "Feature requires an upgrade to Enterprise Edition.",   "detailed_error": "",   "request_id": "zd6ufifm7prcmypgxn3dpj15za",   "status_code": 403 }
will need your help and some more instructions

Thanks @joremysh
Yeah let's sync on Monday.
Sorry for inconvenience

@furqanmlk is there any way that I can run the test locally?

@furqanmlk is there any way that I can run the test locally?

Hi @joremysh You can run all e2e tests except Enterprise ones.
let me test your changes and let you know the issue if there is any.

@sbishel
Can someone from your team take a look ?
We are having issue on /api/v4/saml/certificate/idp request.
I followed all the steps mentioned in test case ( including running openldap, keycloak and copying keycloak.crt)

That would be @mkraft now...

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@joremysh
These tests are passing on Master

But failing at your PR.

I think issue is due to this change
https://github.com/mattermost/mattermost-webapp/pull/11419/files#diff-ce0b399d70dcb741c288feaaa0205ed89e5c01f5300bfa9030140c74a5d3920bR30

If you want we can have zoom session to quickly resolve this issue

/update-branch

Error trying to update the PR.
Please do it manually.

@joremysh let us know if you need help in getting this pr to finish line

@joremysh let us know if you need help in getting this pr to finish line

I will try to fix your comments soon and tell you when I finish
may need your help to test with it again

@joremysh let us know if you need help in getting this pr to finish line

I've fixed all the comments. could you take a look again?

@M-ZubairAhmed could you help check again with the pull request?

/update-branch

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@joremysh
I am getting the following error; I think it is something configurations missing. Let me have a look

/update-branch

@joremysh I am getting the following error; I think it is something configurations missing. Let me have a look

@furqanmlk how's it going?

@joremysh I am getting the following error; I think it is something configurations missing. Let me have a look

@furqanmlk how's it going?

Sorry, @joremysh, for being late.
Very busy in release testing as we are running short on our QA resources.

Hey there!, Thank you for your PR.
Webapp is now part of mattermost monorepo now at https://github.com/mattermost/mattermost-server/tree/master/webapp Would you be interested in opening the PR over there?

The web app now lives in the webapp/channels over in https://github.com/mattermost/mattermost-server. We decided to move it to be a monorepo to make both development and our CI pipelines easier, but it's unfortunately disruptive right now. We've updated our setup docs and added some steps for migrating to working with the monorepo.
Copying the changes over there hopefully shouldn't be too hard. There's a few changes to file paths (such as the code living in a dedicated src subdirectory), but most things should look the same as they do now.
Let us know if you could use any help with this. Hopefully the process is smooth.

@furqanmlk should I move the pull request after your checking with the issue?

@joremysh
I would appreciate if you could move now, as we have made few improvements there. I will test both changes there.
Thanks for your patience


Add basic navigation support for help pages

Summary of the new feature / enhancement
Please consider adding page navigation support for:

ShowCommandHelp, which currently supports keyboard actions:

Up - next line
Down - previous line
Q - exit

help, which currently supports keyboard actions:

Space - next page
Enter - next line
Q/Ctrl+C - exit

It surprises me that the page up and page down buttons are not supported. We can't scroll back up on help, and also there is no button to jump to next page on ShowCommandHelp.
I would suggest:

Synchronizing the keys actions for both variants of manual pages.
Adding support for "Page Up"/"Page Down"/"Home"/"End" keys.

Just as an FYI,  help is a function which wraps Get-Help   (in most cases Thing will run Get-Thing  if there is no actual thing command  - try date and get-command date)  and sends help's output through a pager - on windows this defaults to more.com but it can be over-ridden with an environment variable $env:Pager so you can set it to (e.g.) less.exe and get different keys and functionality.
Because of the issues running an external pager in the middle of processing command line input AIUI PSReadLine  - which has its own repo - implements it's own pager.
Changing the behaviour of more.com after so long as it is is unlikely (but the Windows team updated tree.com for Windows 11 so anything is possible) making PSReadline more like other pagers would be a query for that repo, but is more likely to get traction.

Thanks for the information!

I played with your example and now I'm curious as to how date works 🤔
Like what you said, help it is a wrapping function, such that (gcm help).Definition would print its definition; gal help would return an error as expected because it is not an alias.
Yet date is different: gal date shows that it is not an alias; gcm date shows that it is not a function, script, nor program. So what is date?

(in retrospect, the gal date check is redundant, as gcm would resolve it too)

Thanks for the information!
I played with your example and now I'm curious as to how date works 🤔
Like what you said, help it is a wrapping function, such that (gcm help).Definition would print its definition; gal help would return an error as expected because it is not an alias.
Yet date is different: gal date shows that it is not an alias; gcm date shows that it is not a function, script, nor program. So what is date?

Powershell just has a a backstop before reporting "not found" which is to try Get-whatever
function get-thing {"A Thing"}
Thing

Works
Help is unusual in not being a hidden alias for get-help  but being  way to do  get-help  | more  with various conditions - which allow people to do get-help | less  or any other alternative pager.

date (on Windows) isn't a command, but PowerShell has a lesser known feature where if you type a command, like date and it doesn't exist, PowerShell will try it with get- in front.  So date, on Windows, will actually execute get-date.  You can try the same with service which will run get-service.

There are currently no plans to continue to enhance the builtin pager as there are much better pages out there.

As an aside: that Get-Command (gcm) and Get-Help / help aren't aware of the default-verb logic (date falling back to Get-Date) is a long-standing bug:

#3987

FWIW, I agree that:

the pagers used in the two scenarios should exhibit the same behavior.

I had previously suggested improvements to the ShowCommandHelp pager in https://github.com/PowerShell/PSReadLine/issues/3561 (note that the source code is maintained in the PSReadLine repo), without considering the asymmetry with the help function.

that there should be a unified mechanism to allow specifying a custom pager.

Only the help function supports this, via the $env:PAGER environment variable.


fix(template): fix let directive initial view

Description
The let directive currently calls this.templateManager.displayView('rxNext'); in the ngOnInit method when no rxSuspense template was found. This is not only an issue as this is against the idea of "lazy rendering".
If your value you bound to the LetDirective does not emit any value until the LetDirective renders it's initial view, you will end up in runtime errors since all your ViewBindings are now bound to an undefined object.
Also, in my opinion the LetDirective should really not render ANYTHING until the first "defined" ( !== undefined ) value appears.  Of course only if you haven't provided a rxSuspense template.
Steps to reproduce

revert changes in let.directive.ts
yarn nx s tour-of-heroes
navigate to a detail-view from the dashboard
you will get an core.js:4196 ERROR TypeError: Cannot read property 'name' of undefined error

Very nice!


BCP Validation implementation

This issue is related around specification section "6.1.12 Language" https://github.com/oasis-tcs/csaf/blob/master/csaf_2.0/prose/csaf-v2-editor-draft.md#6112-language
The current state of implementation uses the bcp47 library to parse a BCP string and then checks in bcpLanguageTagChecker.js  that the subtags can be found with expected Type: entries in the subtag registry. This is what we understood so far.
@tschmidtb51 mentioned the following examples:

Examples for vlaid tags aa-DE, sjo-Sora-AN , sry-Visp-, tig-x-Y, eo-arkaika, de-1996, i-DeFaULt
Examples for invalid tags: ez, abx-i-mingo, ads-aeb

The implementation accepts all valid tags, but it also accepts abx-i-mingo and ads-aeb.
As far as I understood:

abx-i-mingo is a valid BCP tag, but illegal to a grandfathered tag; For Secvisogram it's okay to report is as valid according to BCP, as the regex already marks it as invalid. Right?
The issue with ads-aeb is more difficult to grasp for us and I'm not sure why it should be invalid within the scope of our original check requirements (see below).

Case  ads-aeb
This is listed in the registry as language, but also as extension:
Type: extlang
Subtag: aeb
Description: Tunisian Arabic
Added: 2009-07-29
Preferred-Value: aeb
Prefix: ar
Macrolanguage: ar

Given that ads is the language,  the position of aeb seems perfectly reasonable to me as extension. Also aeb is a valid extlang subtag.
I only see a violation of Prefix: ar vs. the actual language being aeb.
Besides checking, that

every parsed subtag can be found in the subtag registry list under a Type which allows the given position in the language string

should we also additionally check for this requirement?
CC @domachine

Well, the CSD01 only stated:

For each element of type /$defs/language_t it must be tested that the language code is valid and exists.

When it comes to programmatic handling the details of languages, calendars, and time zones across interfaces I rather suggest following Postel's Law, also known as the robustness principle, which states:

Be conservative in what you do, be liberal in what you accept from others.
(Postel wrote this in an early version of the TCP specification in 1980 thus the name stuck somehow)

* The issue with `ads-aeb` is more difficult to grasp for us and I'm not sure why it should be invalid within the scope of our original check requirements (see below).

As far as I understand BCP 47 Section 2.2.2 an extlang subtag can not exist in any other language as given by prefix. The prefix value of aeb is ar. Therefore, it can as an extlang only exist as ar-aeb. Does that make sense?

@domachine: I found another one :see_no_evil:: az-baku1926 should be valid. However, according to Secvisogram #218 it is not.  The problem is that the Prefix should be an array where only one of them has to match as the registry lists:
%%
Type: variant
Subtag: baku1926
Description: Unified Turkic Latin Alphabet (Historical)
Added: 2007-04-18
Prefix: az
Prefix: ba
Prefix: crh
Prefix: kk
Prefix: krc
Prefix: ky
Prefix: sah
Prefix: tk
Prefix: tt
Prefix: uz

As uz-baku1926 works, I guess we take only the last one during parsing...


[Editor][Bug] Error is thrown for default imported package as unused

Create a bal file with a function to print hello world
Create another bal file with main method that invokes the above function. Here the lang.system is not used.

There following error is thrown in the backend when trying to run
"main.bal:2: unused import package "ballerina.lang.system"
"
It's wrong to throw exceptions as this for the default imported package as it was not a user action

This is the correct behavior. Import should be mentioned in the same file where the package is used.


$eval not working as expected

It appears that the $eval doesn't work as expected.
Input
{
  "inputs" : [
	  {
		  "a" : 1,
		  "b" : "{\"c\":11}"
	  },
	  {
		  "a" : 2,
		  "b": "{\"c\":22}"
	  }
  ]
}

and the corresponding jsonata
$map(inputs,function($v){{
  "a": $v.a,
  "b": $v.b,
  "c": $eval($v.b).c
}})

should produce something like this
[
  {
    "a": 1,
    "b": "{\"c\":11}",
    "c": 11
  },
  {
    "a": 2,
    "b": "{\"c\":22}",
    "c": 22
  }
]

instead I am getting,
[
  {
    "a": 1,
    "b": "{\"c\":11}"
  },
  {
    "a": 2,
    "b": "{\"c\":22}"
  }
]

as you can see, "c" is silently failing

hey @yesoreyeram good observation - the $eval placed in this fork of go-jsonata is different from js jsonata
the method is
func RunEval(initialContext reflect.Value, expression ...interface{}) (interface{}, error) {

for it to work you need to pass in initial context. In this case, initial context is irrelevant so you can just pass ""
i.e
$map(inputs,function($v){{
  "a": $v.a,
  "b": $v.b,
  "c": $eval("", $v.b).c
}})


Create options for human-readable output formats

Added a -summary and -longsummary options to zlint.
The -summary option produces output that looks like:
+-------+--------------+
| LEVEL | # OCCURANCES |
+-------+--------------+
| info  |            0 |
| warn  |            1 |
| error |            7 |
| fatal |            0 |
+-------+--------------+

and the -longsummary produces output that looks like:
+-------+--------------+------------------------------------------+
| LEVEL | # OCCURANCES |                 DETAILS                  |
+-------+--------------+------------------------------------------+
| info  |            0 |  -                                       |
| warn  |            1 | w_ext_san_critical_with_subject_dn       |
| error |            7 | e_cert_policy_iv_requires_country        |
|       |              | e_ca_key_cert_sign_not_set               |
|       |              | e_ca_organization_name_missing           |
|       |              | e_ca_crl_sign_not_set                    |
|       |              | e_ca_country_name_missing                |
|       |              | e_sub_ca_crl_distribution_points_missing |
|       |              | e_sub_cert_not_is_ca                     |
| fatal |            0 |  -                                       |
+-------+--------------+------------------------------------------+

The only significant changes to zlint was to export statusLabelToLintStatus from result.go and to pull in tablewriter.
Thanks for considering these changes.

Wow, this is awesome. Seriously. Thanks for contributing that. I have been wanting something like this for a while but haven't had any time to work on it.

I've committed additional changes to this PR, so tagging @cpu or @dadrian to take a final pass and merge.

I'm not entirely convinced that removing the tablewriter dependency is worth it, but the new output looks like:
cat testdata/indivValAllBad.pem | ./zlint -summary
| LEVEL | # OCCURRENCES |
+-------+---------------+
|  info |             0 |
|  warn |             1 |
| error |             7 |
| fatal |             0 |

and
cat testdata/indivValAllBad.pem | ./zlint -longsummary
| LEVEL | # OCCURRENCES |                  DETAILS                  |
+-------+---------------+-------------------------------------------+
|  info |             0 |                                        -  |
|  warn |             1 |        w_ext_san_critical_with_subject_dn |
| error |             7 |                      e_sub_cert_not_is_ca |
|       |               |                e_ca_key_cert_sign_not_set |
|       |               |  e_sub_ca_crl_distribution_points_missing |
|       |               |                     e_ca_crl_sign_not_set |
|       |               |                 e_ca_country_name_missing |
|       |               |         e_cert_policy_iv_requires_country |
|       |               |            e_ca_organization_name_missing |
| fatal |             0 |                                        -  |

Tests and some consideration of moving the filtering elsewhere will come later.
Thanks for all the feedback!

@cpu thanks for the feedback, I'll clean it up and write some tests, hopefully I'll get to it all within the next week or so

:wave: @acaird just wanted to check in on this branch. Do you feel like you'll have a chance to address the last bits of feedback in the next few weeks? If you think you might not have the time I definitely understand and would be happy to adopt this PR to get it across the line. Let me know what you would prefer!

:wave: @cpu.  I haven't given up yet!  If I can't get something worthwhile by Tuesday I'll put it up for adoption.  Sorry for the delays... :/

If I can't get something worthwhile by Tuesday I'll put it up for adoption. Sorry for the delays... :/

Please don't apologize, take your time :-) I just want to make sure my feedback isn't the only thing keeping this from landed in tree. Thanks for the update!

Writing tests in main is not ideal; I can keep working on it or I can split the functions and their requirements into a file that isn't main and test that.  Thoughts?

I can split the functions and their requirements into a file that isn't main and test that. Thoughts?

@acaird Splitting would be my pref. but it's lightly held. If you find it easier to keep working through main that's OK with me. I don't want to hold you up :-)

@zakird Thanks for merging, was just typing out a squash commit message.

oh 🤦  sorry about that!

No worries :-) Happy it's all merged up :tada:

Thanks for merging it.  I'm glad it's useful.  I'm sorry about the tests, they are still forthcoming.


Tagedit View repeats characters on its own

Hello Vishesh - looking for a open-source notepad (as starting point for Java with Android) I found your "Sealnote". Following issue though: When adding tags, on some devices the Textview starts typing its own characters, i.e. repeating characters. Example typing "abcde":
Typing <-> on screen
a => a (ok)
b => ab (ok)
c => ababc (ab wrongly repeated)
d => ababcd (ok)
e => ababcdabcde (abcd wrongly repeated)
I think something with TagTextWatcher->beforeTextChanged. The "mShouldMove" is set to true although not needed (at least for the first tag), and setting it to false allows proper (sequential) entering of tags. Strangely, only happening on some devices (Galaxy Tab S, but not on virtual devices). Maybe for consideration with the next version.
Otherwise, very nice program (especially the UI!). Thank you for making it available here!

@ysmad Thanks for reporting and looking into code. I'm a bit busy this week, so will look at it in next 10 days.


[fact] Convert Parser to Kotlin

#155

Codecov Report

Merging #156 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     81.63%   81.65%   +0.02%
+ Complexity      455      454       -1
============================================
  Files            44       44
  Lines          1742     1733       -9
  Branches        275      275
============================================
- Hits           1422     1415       -7
+ Misses          200      196       -4
- Partials        120      122       +2

Impacted Files
Coverage Δ
Complexity Δ

src/main/kotlin/se/kth/spork/spoon/Parser.kt
78.12% <78.12%> (ø)
12.00 <12.00> (?)

src/main/java/se/kth/spork/cli/Cli.java
60.78% <100.00%> (ø)
6.00 <1.00> (ø)

...rc/main/java/se/kth/spork/spoon/Spoon3dmMerge.java
98.55% <100.00%> (ø)
20.00 <0.00> (ø)

...h/spork/spoon/pcsinterpreter/SpoonTreeBuilder.java
88.05% <100.00%> (ø)
42.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaca7c3...2a7bd37. Read the comment docs.


Support for Authorization in Asp.net core

Is your feature request related to a problem? Please describe.
No way apply an specific authentication policy to a graphql field.
Describe the solution you'd like
Use of the AuthenticateAttribute that is built in in asp.net core in a type or in a field.

#22


Adding a volume without a volume template

Issue: A new volume cannot be created without having a volume template created first.
Below is the code containing the resource:
resource "oneview_volume" "volume" {
  properties {
    name              = "VolToAdd"
     /* uncomment the below two lines to provide the size and storage pool uri or it will be taken from the volume template*/
    storage_pool      = data.oneview_storage_pool.st_pool.uri
    size              =<PHONE_NUMBER>
    provisioning_type = "Thin"
    is_deduplicated   = false

  }
  #volume_template_uri = data.oneview_storage_volume_template.test.uri
  #template_name        = "TerraformStorageTemplate"
  #template_uri         = data.oneview_storage_volume_template.test.uri
  is_permanent= true
  #templateUri = data.oneview_storage_volume_template.test.uri
  name                 = "VolToAdd"
  description          = "Description here"
  initial_scope_uris   = [data.oneview_scope.scope_obj.uri]
  provisioned_capacity = "268435456"
}

We are trying to create a new volume, but have not created any volume templates. We have tried to comment out the template_name and template_uri attributes, but get the following error:
╷
│ Error: Error in response: One or more required fields are missing.
│  Response Status: 400 Bad Request
│  Response Details: Missing value for property 'templateUri'.
│
│   with module.Add_Volume.oneview_volume.volume,
│   on 04-Add-Volume-Terraform\main.tf line 25, in resource "oneview_volume" "volume":
│   25: resource "oneview_volume" "volume" {
│
╵

Expected output: A volume is added without having used a template.
Is it possible to do this in the current revision of the provider?

Hi @josyfj ,
We will look into this and get back to you.
Thanks

The fix is now part of master. We are closing it here.

Hello Nabhajit,
I'm still seeing an error when attempting to run this. I've made sure to update the provider to version 7. Below is the resource exactly as I have it configured as well as the output I get:
The resource had to be modified from the example. I removed the "description" parameter and moved the "name" parameter from inside the properties subset into the main resource parameters.
resource "oneview_volume" "volume" {
  properties {

    #description = "Test Volume with no template"
    storage_pool      = data.oneview_storage_pool.st_pool.uri
    size              =<PHONE_NUMBER>
    provisioning_type = "Thin"
    is_deduplicated   = false
  }
  name              = "testvol3"
  initial_scope_uris   = [data.oneview_scope.scope_obj.uri]
  provisioned_capacity = "1221225472"
}

2022-06-20T10:35:55.876+0200 [DEBUG] created provider logger: level=debug
2022-06-20T10:35:55.878+0200 [INFO]  provider: configuring client automatic mTLS
2022-06-20T10:35:55.897+0200 [DEBUG] provider: starting plugin: path=.terraform/providers/registry.terraform.io/hewlettpackard/oneview/7.0.0-13/windows_amd64/terraform-provider-oneview_v7.0.0-13.exe args=[.terraform/providers/registry.terraform.io/hewlettpackard/oneview/7.0.0-13/windows_amd64/terraform-provider-oneview_v7.0.0-13.exe]
2022-06-20T10:35:55.917+0200 [DEBUG] provider: plugin started: path=.terraform/providers/registry.terraform.io/hewlettpackard/oneview/7.0.0-13/windows_amd64/terraform-provider-oneview_v7.0.0-13.exe pid=70760
2022-06-20T10:35:55.917+0200 [DEBUG] provider: waiting for RPC address: path=.terraform/providers/registry.terraform.io/hewlettpackard/oneview/7.0.0-13/windows_amd64/terraform-provider-oneview_v7.0.0-13.exe
2022-06-20T10:35:55.975+0200 [INFO]  provider.terraform-provider-oneview_v7.0.0-13.exe: configuring
server automatic mTLS: timestamp=2022-06-20T10:35:55.971+0200
2022-06-20T10:35:56.031+0200 [DEBUG] provider: using plugin: version=5
2022-06-20T10:35:56.031+0200 [DEBUG] provider.terraform-provider-oneview_v7.0.0-13.exe: plugin address: address=<IP_ADDRESS>:10000 network=tcp timestamp=2022-06-20T10:35:56.030+0200
2022-06-20T10:35:56.158+0200 [WARN]  ValidateProviderConfig from "provider[\"registry.terraform.io/hewlettpackard/oneview\"]" changed the config value, but that value is unused
2022-06-20T10:35:57.553+0200 [INFO]  provider.terraform-provider-oneview_v7.0.0-13.exe: 2022/06/20 10:35:57 [WARN] Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2022-06-20T10:35:57.553+0200
2022-06-20T10:35:57.554+0200 [INFO]  provider.terraform-provider-oneview_v7.0.0-13.exe: 2022/06/20 10:35:57 [WARN] Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2022-06-20T10:35:57.553+0200
module.Add_Volume_Terraform.oneview_volume.volume: Creating...
2022-06-20T10:35:57.560+0200 [INFO]  Starting apply for module.Add_Volume_Terraform.oneview_volume.volume
2022-06-20T10:35:57.563+0200 [DEBUG] module.Add_Volume_Terraform.oneview_volume.volume: applying the planned Create change
2022-06-20T10:35:57.569+0200 [INFO]  provider.terraform-provider-oneview_v7.0.0-13.exe: 2022/06/20 10:35:57 [DEBUG] setting computed for "device_specific_attributes" from ComputedKeys: timestamp=2022-06-20T10:35:57.569+0200
2022-06-20T10:35:58.241+0200 [DEBUG] provider.terraform-provider-oneview_v7.0.0-13.exe: Error submitting new storage volume request: Error in response: One or more required fields are missing.
2022-06-20T10:35:58.242+0200 [DEBUG] provider.terraform-provider-oneview_v7.0.0-13.exe:  Response Status: 400 Bad Request
2022-06-20T10:35:58.243+0200 [DEBUG] provider.terraform-provider-oneview_v7.0.0-13.exe:  Response Details: Missing value for property 'templateUri'.
2022-06-20T10:35:58.280+0200 [ERROR] vertex "module.Add_Volume_Terraform.oneview_volume.volume" error: Error in response: One or more required fields are missing.
 Response Status: 400 Bad Request
 Response Details: Missing value for property 'templateUri'.
╷
│ Error: Error in response: One or more required fields are missing.
│  Response Status: 400 Bad Request
│  Response Details: Missing value for property 'templateUri'.
│
│   with module.Add_Volume_Terraform.oneview_volume.volume,
me":
│   30: resource "oneview_volume" "volume" {
│
╵```

Is there something I'm missing in my resource or configuration that could be causing this?

Thank you

Hi Josyf,
Have you  pull the latest changes and build the provider locally ?

Hi Nabhajit,
I've synced the latest changes and ran the provider locally by using a terraform mirror C:\<directory> command followed by a terraform init -plugin-dir C:\<directory>. If I run terraform providers I get the following response:
.
├── provider[registry.terraform.io/hewlettpackard/oneview] 7.0.0-13
├── provider[registry.terraform.io/hashicorp/null] 3.0.0
└── module.Add_Volume_Terraform
    └── provider[registry.terraform.io/hewlettpackard/oneview] 7.0.0-13

Providers required by state:

    provider[registry.terraform.io/hewlettpackard/oneview]```

It appears that Terraform is using the latest provider version, unless there is something I'm missing?

Thank you again

Hi @josyfj ,
We did not hear from you if the fix is working. Closing it here. Please reopen if it is not working