MIT charge 400 - Bad Request using tokenized test card

Hi,
Can you please check what is wrong with my call from your logs.
I am using the code that has worked before, now testing again and now getting 400 error.
I been trying to use different test cards none worked so far.
I get token successfully but mit charge always fails.
Here is one of the failing call.
Can't figure out what is wrong here.
Not using redirectUrls and I was adviced by your support to use empty redirect urls since its mandatory and like I said it was working earlier. This is not document that they can be left empty if not used. Best would be of course if they were non mandatory and could be left out in case they are not used.
POST to https://services.paytrail.com/payments/token/mit/charge
headers
{"Accept":"application/json","checkout-timestamp":"2023-01-19T13:08:24+00:00","checkout-account":375917,"checkout-algorithm":"sha256","checkout-method":"POST","checkout-nonce":"8974bdb3-8251-49f3-abdb-021be8fdbfcf","X-CheckoutFiClient-Api-Version":"0.1","Content-Type":"application/json;charset=UTF-8","signature":"666dad0a82eaca39a8bc0cd2dd6dfeb1de0b03a218bfca4c37bc0d131e6ae11f"}
body
{"stamp":"555857","reference":"10005558576","currency":"EUR","language":"FI","amount":10600,"customer":{"firstName":"pekka","lastName":"testaaja2","email":"pkilpo+2@gmail.com"},"redirectUrls":{"success":"","cancel":""},"items":[{"description":"TARJOUSKESTO 12 KK","deliveryDate":"2023-01-19","productCode":"1210","units":1,"unitPrice":10600,"vatPercentage":10}],"token":"8edcbd8f-0aa6-4b1c-a407-46c0809e5f60"}
RESPONSE
400 - Bad Request
Thanks in advance

Hi,
This request is successful when calculated signature is ead765f7fc7e3cf26e58cb5a90ed32bc3a6c608715be72a883cf3554d903bcc6
Did you check that checkout headers are passed in alphabetical order https://docs.paytrail.com/#/?id=authentication


add

https://github.com/PixelGuys/Cubyz

Welcome PR to add thisOn Jul 7, 2024, at 09:16, jujubeja @.***> wrote:
https://github.com/PixelGuys/Cubyz
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


Add Skywalk Mescal 6 Glider Model

About
This adds Skywalk Mescal 6 glider to the extras/wings package and the simulation script to draw polar curves. Data was obtained from: https://skywalk.info/project/mescal/
By the way, very cool project! And thanks for a thorough documentation, paper and open-sourcing the codebase! :parachute:
Note

Certain parameters are quite hard to guess / empirical. And most were copied from Nivuk hook 3 :cry:
Only XS size has been added, and details on other parameters in the model need to be tuned

Comparison of flattened model with line chart of datasheet

Seems like the cell sizes are really big in the middle & smaller on the outside, so the discrepancy in cell division lines arises. In the actual simulated model, however, do we consider the differences in cell opening lengths in spanwise direction?
The projected map differs slightly, especially how the outermost chord diminishes much smoothly in actual glider, compared to the simulated one. Is this also a common trait with Nivuk glider? Or does this indicate that I didn't set the model correctly?

Questions
How would we accurately measure the following?:

kappa_C: For Mescal 6, the lineplan shows that C-risers are not connected just spanwise, but also cordwise. In this case, which value should be chosen for the C risers's attach point along the chord?
s_delta_start/stop0/1: These are really tricky, are the videos the only way to measure this?
kappa_z: I added the 'middle line length excluding length of risers' from the technical data, is it accurate to assume that the tip of the riser is matching the Riser-Midpoint?
kappa_x: We can't really tell what this value should be (chordwise offset from leading edge to pilot's position hung under the glider. How did you initially come up with the number 0.45 * Chord_root?
kappa_b: I initially thought this should be the brake-line range (specified also in Technical data), but after reading the paper it seems like this range can't be directly translated into the kappa_b (actual movement of TE) that we desire. But, is there some way to calculate this?
SimpleFoil/aerodynamics_config: We use v_ref_mag of 10, and alpha_ref of 5. I didn't read in detail, but how would changing these values affect the final aerodynamic calculation of the glider? Are these values from some reference?

Improved chart visualization example
NOTE: I need to remove comments on 'breakpoint' stuff :laughing: (I commented it out, as it was annoying for iterating the plotting code)

Hi Junwoo, sorry for the delays. I answered your private messages, hope that helps; I'll try to address these questions too when I get time. Good luck with your license and studies!


Creating a volume and attaching it to an instance fails

Creating a volume before attaching it as a ebsBlockDevices fails with the following exception: aws:ec2/instance:Instance resource 'aaaa' has a problem: "ebs_block_device.0.volume_id": this field cannot be set
The volume resource definition:
const volume = new aws.ebs.Volume("aaaa-state", {
  availabilityZone: config.availabilityZone,
  encrypted: true,
  size: 15,
  tags: {
    ...config.tags,
    snapshotable: "true"
  }
});

The instance definition:
const instance = new aws.ec2.Instance(
  `aaaa`,
  {
    ami: "ami-02ea8f348fa28c108",
    instanceType: "t2.micro",
    subnetId: config.subnetId,
    vpcSecurityGroupIds: [...securityGroups.map(group => group.id)],
    associatePublicIpAddress: false,
    keyName: `aaaa`,
    iamInstanceProfile: profile,
    userData,
    ebsBlockDevices: [
      {
        volumeId: volume.id,
        deviceName: "/dev/xvdh"
      }
    ],
    tags: config.tags
  },
  {
    dependsOn: [...securityGroups, volume]
  }
);

Any help is highly appreciated 🙂

Okay, found an alternative approach. I created the instance without ebsBlockDevices and attached the volume via:
new aws.ec2.VolumeAttachment(
  "aaaa-instance-state-mount",
  {
    volumeId: volume.id,
    instanceId: instance.id,
    deviceName: "/dev/xvdh"
  },
  {
    dependsOn: [instance, volume]
  }
);

Still, two questions are unanswered 🙂

Why is it not possible to define tags within the ebsBlockDevices definition (what I wanted to do originally)?
Why is it not possible to set the volumeId in ebsBlockDevices?


EmbeddedFileProvider code example not compiling with .Net core 2.1

With .Net core 2.1 the code in FormFactory.AspNetCore.Example/Startup.cs line 36 and 60 does not compile.
The EmbeddedFileProvider has to be created like this:
new EmbeddedFileProvider(typeof(FormFactory.FF).Assembly, nameof(FormFactory));

Maybe the example should be updated or the lines should be commented ("// For .Net core use bla")?

Cheers - I don't have a lot of time to work on FF, but I'd be very happy to
merge a PR updating it all to a newer version of .NET Core
On Thu, 7 Mar 2019 at 09:10, Benno Straub<EMAIL_ADDRESS>wrote:

With .Net core 2.1 the code in FormFactory.AspNetCore.Example/Startup.cs
line 36 and 60 does not compile.
The EmbeddedFileProvider has to be created like this:
new EmbeddedFileProvider(typeof(FormFactory.FF).Assembly, nameof(FormFactory));
Maybe the example should be updated or the lines should be commented ("//
For .Net core use bla")?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mcintyre321/FormFactory/issues/78, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQ0-gG9Dmotl8u0vjUo-bgBDPze2MZNks5vUNeBgaJpZM4bisTm
.


Add stubs to workflow

When we get a chance we should consider going back to add stubs to process's in our workflow.
          Just a note that we should probably add these to scpca-nf as we go. Sometime when we have a chance to make sure everything has one...

Originally posted by @jashapiro in https://github.com/AlexsLemonade/CART_Monje/pull/131#discussion_r1157230370

Closed by #326


[AutoPR apimanagement/resource-manager] Add apimanagement/resource-manager/readme.typescript.md

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4127

(message created by the CI based on PR content)


Adding resilient list deserializer

Fixes #9
Not sure if there was something new in KxS 1.6 that made this possible, or if I just ended up trying something different.. but it seems to work 🎉

Nice!

what do you feel about the name?

resilientListSerializer  what I came up with when trying this out again
listSerializerIgnoringInvalidItems  seen in the issue

I'm kind of in favor of no 2.

Yeah, any of those names is fine. Personally I'd go with LenientJsonArraySerializer. I'll leave it up to you :)

Thanks, that's a great suggestion :) I'll go with that


TSInstall templ doesn't work until adding plugin (the old way), and even after TS installs templ successfully, it doesn't seem to work

Running :TSInstall templ gives me the following:
Installation not possible: ...vim/lazy/nvim-treesitter/lua/nvim-treesitter/install.lua:86: Parser not available for language "templ"
See https://github.com/nvim-treesitter/nvim-treesitter/#adding-parsers on how to add a new parser!

I went through the old readme, before it was officially available on tree-sitter, and it said to install it as a package and set up treesitter that way. This is the config I made, as per the old docs. I'm using LazyVim.
require("lazy").setup({
-- other plugins, including tree-sitter
{ "vrischmann/tree-sitter-templ", config = function() require("tree-sitter-templ").setup({}) end }                  -- https://github.com/vrischmann/tree-sitter-templ/commit/2a8326a0ee921c5ed24b3e627283390b7bf1d64f

Then, later:
require("nvim-treesitter.configs").setup({ auto_install = true, highlight = { enabled = true, additional_vim_regex_highlighting = true }, })

require("luasnip")

local treesitter_parser_config = require "nvim-treesitter.parsers".get_parser_configs()
treesitter_parser_config.templ = {
  install_info = {
    url = "https://github.com/vrischmann/tree-sitter-templ.git",
    files = {"src/parser.c", "src/scanner.c"},
    branch = "master",
  },
}

vim.treesitter.language.register('templ', 'templ')

Even then, I don't get highlighting and everything else.
:checkhealth gives me this
Parser/Features         H L F I J
...other modules
  - templ               ✓ . . . ✓

but :TSModuleInfo gives me this:
>> default          context_commentstring  highlight  illuminate  incremental_selection  indent
...other modules
templ               ✗                      ✗          ✗           ✗                      ✗

I'm at a bit of a loss. Is there something I'm missing? I'm not sure if this program incorporates templ's builtin lsp, but even so I just wanted to get syntax highlighting to work

I have a similar issue - I had to update treesitter to the most recent version, and eventually :TSInstall templ found the package and installed. My :checkhealth shows the same as yours, but I get no syntax highlighting. I also can't get the lsp to work at all.

Whoops, just found my issue. I had to add the templ.vim package. Then, the templ filetype still wasn't recognized, so I had to add
vim.filetype.add({
  pattern = {
    ["*.templ"] = "templ",
  },
})

somewhere in my config. Everything works as expected now.

Hi.
@nathan-hello I would guess that something is wrong with your nvim-treesitter installation because templ is definitely available by default since a couple of weeks ago. Did you update nvim-treesitter ?
@knudtty You shouldn't need templ.vim, I don't have it installed. But you do need to add the filetype yes.

@vrischmann Thanks for the quick reply. I updated all of my plugins, and templ was installing properly. It still wasn't working, but I noticed :InspectTree was giving me a good tree-sitter looking tree, so it's obviously parsing. Running :TSBufEnable highlight was the solution, as per this part of the tree-sitter readme. So, this is what I put in my init.lua
vim.filetype.add({ extension = { templ = "templ" } })
vim.api.nvim_create_autocmd("BufEnter", {
    pattern = "*.templ",
    callback = function() vim.cmd("TSBufEnable highlight") end
})

Syntax highlighting is working, without the older, vimscript plugin (though I did try it and it did work) and without the tree-sitter plugin that you made before it got added officially.
I still have a few questions about the templ lsp, but I know that's not your side of the house. Thanks for making the parser and for helping me.


Meet with Robin

Needs to be week of June 13th in order to work with Robin's schedule

Matt and I met with Robin today. She is quite excited about our progress. A few takeaways listed below:
(1) Provided login credentials to 'Reclaim Hosting' site which they host their current website through. They seem to provide quite a few hosting options for sites and databases. We see MySQL and PHP as out of the box options, but it appears there may be advanced methods that could allow us to host our MongoDB, but need to research further. Robin gave us permission to reach out to their support team on OneSharedStory's behalf to ask questions.
(2) Robin loves the interface of both the transcribe tool and search tool. Believes that the search tool is sufficient in allowing families to identify connections between datasources. She really appreciated the way we've displayed the 'Events' column to be told as a story versus simply listing the raw data.
(3) She would like to provide a url to the digital version of documents. She will not have a url for all documents, but would be interested in adding these links as hyperlinks in the search table.
(4) While Robin thinks it would be great to have a way to view additional information in the search tab about a record, she is most concerned with the ability to export all features into a shareable JSON format.


Add support for max_completion_tokens in OpenAI chat options request

Adds support for max_completion_tokens in OpenAI chat options request - An upper bound for the number of tokens that can be generated for a completion, including visible output tokens and reasoning tokens.
Fixes https://github.com/spring-projects/spring-ai/issues/1411

Thank you for the contribution @dafriz . Much appreciated

Rebased and merge at f56ce20cade7523396a2ce8728c856b0c0a159c0


Wallet creation password entry should offer secure text entry

.. with an optional toggle switch to show password for the curious.

Ok, fixed


Pirasmas

About the PR

[x] Tinsel (white, red, blue)
[ ] Mapping tinsel
[x] Christmas lights (colours obviously)
[ ] Mapping christmas lights
[ ] Christmas Trees on all maps
[ ] Christmas carpets
[X] Gibstick self-antag license stuff
[x] Music
[X] Lobby screens
[ ] Mobs have bows or whatever christmas stuff on them
[ ] Nukies christmas theme (grinches???)
[ ] "Antag where their goal is to give out white elephant gifts to people, like giving an emag to command that has no charges"
[ ] "change the sound that plays for the announcements of crates NT sends randomly to someone doing a santa impression going "ho ho ho merry christmas!" or something"
[ ] Christmas logo
[X] Enable the already existing christmas stuff (christmas nuke) during the entire event

Media

I'll add media when I get close to done / done
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

TODO: Add CL

Summary by CodeRabbit
Release Notes

New Features

Introduced new cargo products, including "CrewMonitoring" and various crate entities related to crew monitoring.
Added several new flora entities, including Christmas-themed decorations and trees with item-giving capabilities.

Improvements

Enhanced the visual representation of game maps with new nodes and updated entity attributes.
Adjusted holiday definitions to extend the Christmas celebration throughout December.

Bug Fixes

Removed outdated entities and streamlined the structure for improved performance and management.

Refactor

Consolidated various borg chassis parts into generic components for better organization.

I'm un marking this as draft so checks as run, DO NOT MERGE THIS, I will do it when it's done.

oh no! it failed to load cog guys!


Refactor some dependency handling to fix various API dependency issues

This PR tries to tackle several of the "harder" issues involving API dependencies. Basically the stuff that required deeper refactoring rather than a hack-on fix.
There were several cases where the dependency list was incorrect. Usually this erred on the side of too many dependencies rather than too little, so hasn't seen widespread bug reports beyond a few comments here and there.
Notably:

The dependency list had parts that varied depending on the machine that generated the API JSON rather than the consumer.
Stable-only or HEAD-only dependencies were not correctly considered.
uses_from_macos "example", since: ... did not work correctly.

This changes in this PR are:

Removed TapDependency (this makes the rest of the PR a bit simpler), folding it into Dependency
Refactored uses_from_macos handling. Instead of being a conditional depends_on, it now consistently adds a UsesFromMacOSDependency on all platforms with the checks now taking place in installed?. This provides a more consistent behaviour on all platforms, and has a bonus of reducing the bloat of the variations part of the JSON.
Introduced an internal auto tag, which is now applied to all dependencies not explicitly added via a depends_on. This fixes an issue where some of the "if needed" deps leaked from the machine that generated the API JSON. For example, if a formula uses xz and the machine that generated the API JSON did not have xz, it will now no longer appear on the API dependency list and instead be determined by the API consumer.
Changed the API hash and Formulary to support all these changes. Some fields in the hash were deprecated as a result as some changes were unavoidably backwards incompatible given the basic array of strings we had before simply does not have the flexibility to store the additional information added in this PR like a hash/dictionary does. (Requirements already used a hash so the existing field worked there.)

This is draft because rspec tests need adjusting and basic commands are probably very broken as is. But the general implementation as a whole should be done, with just bug/typo fixes needed.

Will have a look at this PR later, but since we're looking at refactoring dependency handling:
Some of the "auto" dependencies (e.g. xz when the source tarball is a .tar.xz, or curl when the url has using: :homebrew_curl) get added to the build environment by superenv, which leads to opportunistic linkage (see icecast.rb and vorbis-tools.rb for hacks we've used to try to avoid this). It would be nice if we could get rid of this (if this PR doesn't handle that already).

Thanks for reminding me. I knew there was another reason for tagging those dependencies but I forgot what that was.
I will indeed make that change.

It would be nice if we could get rid of this (if this PR doesn't handle that already).

Agreed 👍🏻

I will indeed make that change.

🎉

Some of the "auto" dependencies (e.g. xz when the source tarball is a .tar.xz, or curl when the url has using: :homebrew_curl) get added to the build environment by superenv, which leads to opportunistic linkage (see icecast.rb and vorbis-tools.rb for hacks we've used to try to avoid this). It would be nice if we could get rid of this (if this PR doesn't handle that already).

fd411c26511e9721c587bde7201b2cb8c35996c2 will probably handle this (untested).


General: Mobile Wallet Adapter Dev Integration

Description
This update adds to the initial mobile wallet updates from the solana foundation members
How has this been tested?
Types of changes

[ ] Technical Debt (non-breaking change which removes unused code/assets)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] The related ClickUp task has been linked to this PR
[ ] The person creating the pull request is listed in "Assignees"
[ ] Change requires updated documentation

moved commits to feature branch closed in PR #581


Running Python as guest results in incorrect file path

When connecting to myself in liveshare and running a python program, it does not run from the correct directory. When I run the file as the liveshare leader, the following command is executed: & "C:/Users/my_name/Anaconda3/python.exe" "c:/Users/my_name/source/repos/test.py"  and the correct output is given. However, when running from liveshare connected to myself, the following command is executed: & "C:/Users/my_name/Anaconda3/python.exe" /test.py. Since there is no file at /test.py, I am given a generic python error that there is no file there. 'can't open file '/test.py': [Errno 2] No such file or directory'. However, when I manually type in the command generated by the host, the file is run properly.
Product and Version: VSC 1.45
OS Version: Windows 10
Live Share Extension Version: 1.0.2236
Target Platform or Language: Python
Steps to Reproduce / Scenario:

Create a new folder and python file inside. Open the folder and liveshare it
Attempt to run it from the shared machine with the run button

Thanks for your help, I'm a student trying to attend a virtual hackathon.
log.zip

Hi Stanley,
Thanks for reporting this issue. Do you have launch configuration in .vscode/launch.json? If you do, can you please share the launch configuration you have there from your host machine?
When you launch from your guest machine, what launch configuration do you use?

My launch.json file is as follows on both the host and guest:
{
"version": "0.2.0",
"configurations": [
{
"name": "Python: Current File",
"type": "python",
"request": "launch",
"program": "${workspaceFolder}/test.py",
"console": "integratedTerminal",
"cwd": "${workspaceFolder}"
}
]
}
I just realized the command run by the Guest is run in the Guest's local terminal, not in the shared terminal, resulting in an error. When the command & "C:/Users/my_name/Anaconda3/python.exe" /test.py is run from the shared terminal, the expected output is given. Thanks.


Role/group setup is not working and the description is confusing

Have followed all the steps from the example and authentication part (sign in) works for me. However, authorization part (role/group) access is not working - I don't get role setup in AD inside Spring Boot App - my authenticated user has 'ROLE_USER' authorization.
The documentation around role/group is bit misleading since the group name in AD is 'users' however the value in Spring Boot App is 'Users'. It's not clear is it the convention, is it case sensitive or not.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cf5423d-6c4c-26a8-89bb-7686794716d0
Version Independent ID: 998d0369-045c-d32c-d07e-ff7d4352e878
Content: How to use the Spring Boot Starter for Azure Active Directory
Content Source: java/spring-framework/configure-spring-boot-starter-java-app-with-azure-active-directory.md
Service: active-directory
GitHub Login: @bmitchell287
Microsoft Alias: brendm

@vvoinov thanks for the feedback! We'll investigate and update the topic to clear things up.
@seanli1988 can you comment here? Thanks!


Small request for list_active_ds9()

Hello! I'm relatively new to using pyraf and imexam (and Github, to tell the truth), so please excuse me if this has been asked before or I'm going about any of this incorrectly. I have checked the previous issues and did not see it.
I noticed that list_active_ds9() prints the current DS9 session to the terminal. I wanted to be able to collect the XPA_METHOD via my script instead of manually finding it in my DS9 window, so I dug into my libraries and changed this code:
if find_xpans():
    try:
        ...
        if ..(stuff)
        else:
            print(sessions.decode())

To this:
if find_xpans():
    try:
        ...
        if ..(stuff)
        else:
            return sessions.decode()

This allows me to collect the string that list_active_ds9() spits out and parse it to grab the XPA_METHOD. This works for my purposes, though I realize it may cause issues if users have multiple DS9 windows open. Would you consider adding perhaps a toggle-able option to either return the values or print the values, depending on user needs? If you like the idea, I can contribute the code change if that is allowed on this repository.
Thanks for this very helpful module!

Is this what #60 was trying to address?

Yes, thanks! I'll close this.

Let's keep this open until the PR is merged.

Hi @emcangi , indeed you are the second person to ask for this, I'm going to make some suggestions on the original PR and copy you there.

fixed in 2f42089ba689e85c6ef02b8ce92a75e7344ae198


Also pass shape to single preprocessers not just stacked ones

Otherwise the constructor of Preprocessor complains that the kwarg 'shape' is not set.

Thanks!


ARI handling of label types in text form

The CACE library needs to handle typed label values in text form according to Section 4.2.1 of the ARI draft.
Tests must include positive verification of encoding and decoding specific values. This includes alternatives for ARI types LABEL.

According to section 4.2.1 of the ARI spec, labels may consist of either text identifiers or digits:
lit-label = id-text / id-num

However, numeric labels are currently not allowed by the implementation:
ari:/LABEL/0
ari:/LABEL/1

Note that zero-padded numbers are not allowed in this context. For example the parser should reject ari:/LABEL/01.


JSON Wrapper results in Pyright Error

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using the JSON type-wrapper, it's required that the type actually be that which lives within side the wrapper. Is there any reason to not just allow any string to be passed in? We could instead enforce the type-checker accept an string regardless of what the contained type is, which would mitigate this issue.
Example Code
Let's take this example from the documentation:

from typing import Any, List
from pydantic import BaseModel, Json, ValidationError

class AnyJsonModel(BaseModel):
    json_obj: Json[Any]

class ConstrainedJsonModel(BaseModel):
    json_obj: Json[List[int]]

print(AnyJsonModel(json_obj='{"b": 1}'))

# Argument of type "Literal['[1, 2, 3]']" cannot be assigned to parameter "json_obj" of type "Json[List[int]]" in function "__init__"
  "Literal['[1, 2, 3]']" is incompatible with "Json[List[int]]"
print(ConstrainedJsonModel(json_obj="[1, 2, 3]"))

Python, Pydantic & OS Version
conda run python -c "import pydantic.version; print(pydantic.version.version_info())"
             pydantic version: 2.6.1
        pydantic-core version: 2.16.2
          pydantic-core build: profile=release pgo=true
                 install path: /Users/maxmuoto/mambaforge/envs/sm/lib/python3.11/site-packages/pydantic
               python version: 3.11.7 | packaged by conda-forge | (main, Dec 23 2023, 14:38:07) [Clang 16.0.6 ]
                     platform: macOS-14.4-arm64-arm-64bit
             related packages: pyright-1.1.357 typing_extensions-4.7.1 pydantic-extra-types-2.5.0

@max-muoto  is this bug is confirm by maintainer ? if yes can I work on this issue or are you going to solve this issue ?

After thinking about this more, not sure it's possible to solve this within the constraints of the current Python typing system. Perhaps when dataclass converters, this could be reworked into something that's compatible with Pyright, which will have support for dataclass transform: https://peps.python.org/pep-0712/


Use more appropriate methods to compile KtFiles

Update detekt core to ensure KtFiles are created using standard methods in the compiler. This means paths and filenames are correctly stored in each KtFile so this fixes #5747 and fixes #6155.

What's the reason why this is in draft?

Test failures - CI not passing for formatting module which requires further changes to make autocorrect work again.

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

:warning:
This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

  Generated by :no_entry_sign: dangerJS against 50a7a3d13d6acd42f26b2d3c4cad14c486ba5dc8

I couldn't think of a decent solution to support auto correct while using this approach. We might want to consider whether autocorrect should be supported at all by detekt, especially if we start pushing the compiler plugin since that can't reasonably support it.
Closing and replacing with https://github.com/detekt/detekt/pull/6310


quick filter on namespace

When I enter cluster view I almost always want to filter on namespace - having to open the filter popup for this purpose is "cumbersome" (i'm lazy) - could we have a quick-filter on namespace somewhere? (perhaps similar to what we had initially?)

not sure this is needed anymore since it is possible to filter on namespace from within the source editor

superceded by #905


Explicitly discard result of std::remove

Fixes Android arm-64-v8a build with NDK r14.

Rebased against master, and rewrote the patch to erase the removed elements.

Please take another look.

Rebased and pushed into master as 188cd3780d76


Use non-strict mode by default

torch.export has strict mode and non-strict mode.
For difference, please read Non-Strict Export.
This PR switches to non-strict mode by default. Improving tracing success rate (no Dynamo graph break).

im not convinced.
i should be easy to convince since at the moment i'm fighting with tracer issue after tracer issue.
however, if the answer is "turn off safety so it doesn't throw errors" i'm not sure i want to use the tracer at all.


Fix typo in ES service monitor name

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

Tested on GCP kubeadm and verified that the old ES ServiceMonitor will be deleted.


Privacy policy must disclose the use of Google Analytics

As stated in the FAQ page, Atom uses Google Analytics to provide useful feedback to the development team. I see from issue #4966 that work has started on providing a way for users to give informed consent, which is great.
Google Analytics' Terms and Conditions under section 7 "Privacy" read: "You must post a Privacy Policy and that Privacy Policy must provide notice of Your use of cookies that are used to collect data. You must disclose the use of Google Analytics, and how it collects and processes data."
This is currently missing from your privacy policy and must be added to be compliant with Google's T&Cs, whether a method to opt-in (or out) is later added.
It's acceptable to use Google Analytics, you just have to disclose that you use it in a Privacy Policy.

@tombrossman Can you please move this over to the atom/metrics repo?  Thanks.
(Also, the README in the metrics repo both discloses the use of GA and what data Atom collects.  There's also a notice present on the initial Welcome screen to Atom.)


[Unified Recorder] Only run tests after the proxy tool is active

As we depend on concurrently and run the docker run .. and mocha .. commands in parallel, there might be a case where tests start running and docker run .. is still setting up the test proxy. Make sure the tests only run when the test proxy is active.

Being handled at https://github.com/Azure/azure-sdk-for-js/pull/18322


During Verifiable Credential Issue request - VCCrypto.KeychainStoreError code 3 itemNotFound

I tried this on both MacOS latest updated and Windows 11 via Parallels (latest updates)
I followed instructions per documentation and keep running into this error during iPhone (latest updates) Authenticator "Add a credential" step
2022-05-10 19:58:01.094 INFO VerifiableCredential 0 TID=1 137 (viewWillAppear()) DIDCardListViewed properties: ["Count": "0", "CorrelationVector": "FnK369BYQ6m+DTGa/M9Cbg.0"]
2022-05-10 19:58:01.096 ERRO VerifiableCredential 0 TID=1 259 (refreshNotifications(forcedRefresh:)) Error: Optional(VerifiableCredentialWallet.NotificationUseCaseError.notificationsRefreshedRecently) Message: Unable to refresh notifications Properties: ["ThrowableMessage": "The operation couldn’t be completed. (VerifiableCredentialWallet.NotificationUseCaseError error 1.)", "CorrelationVector": "FnK369BYQ6m+DTGa/M9Cbg.0", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/ViewModel/CardTableViewModel.swift", "Throwable": "Optional(VerifiableCredentialWallet.NotificationUseCaseError.notificationsRefreshedRecently)", "Message": "Unable to refresh notifications", "Tag": "refreshNotifications(forcedRefresh:)", "Line": "259"]
2022-05-10 19:58:03.832 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Function": "fire()", "Line": "55", "Message": "Correlation Vector for VCNetworking.FetchPresentationRequestOperation: FnK369BYQ6m+DTGa/M9Cbg.1", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "CorrelationVector": "FnK369BYQ6m+DTGa/M9Cbg.1"]
2022-05-10 19:58:03.846 INFO VerifiableCredential 0 TID=1 137 (viewWillAppear()) DIDCardListViewed properties: ["Count": "0", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.0"]
2022-05-10 19:58:03.846 ERRO VerifiableCredential 0 TID=1 259 (refreshNotifications(forcedRefresh:)) Error: Optional(VerifiableCredentialWallet.NotificationUseCaseError.notificationsRefreshedRecently) Message: Unable to refresh notifications Properties: ["Message": "Unable to refresh notifications", "Tag": "refreshNotifications(forcedRefresh:)", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.0", "Throwable": "Optional(VerifiableCredentialWallet.NotificationUseCaseError.notificationsRefreshedRecently)", "ThrowableMessage": "The operation couldn’t be completed. (VerifiableCredentialWallet.NotificationUseCaseError error 1.)", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/ViewModel/CardTableViewModel.swift", "Line": "259"]
2022-05-10 19:58:05.498 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["code": "200", "isSuccessful": "true", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.0", "eventName": "FetchPresentationRequestOperation", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.0", "CV_response": ""]
2022-05-10 19:58:05.513 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.1", "Line": "55", "Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: vw5h8XsRTvKsuvImy4Rupg.1", "Function": "fire()", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 19:58:05.852 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["code": "200", "isSuccessful": "true", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.1", "eventName": "FetchDIDDocumentOperation", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.1", "CV_response": ""]
2022-05-10 19:58:05.881 INFO VerifiableCredential 0 TID=1 55 (fire()) ["File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.2", "Function": "fire()", "Line": "55", "Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: vw5h8XsRTvKsuvImy4Rupg.2"]
2022-05-10 19:58:05.987 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["code": "200", "isSuccessful": "true", "CV_response": "", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.2", "eventName": "FetchDIDDocumentOperation", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.2"]
2022-05-10 19:58:05.992 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Message": "Correlation Vector for VCNetworking.FetchWellKnownConfigDocumentOperation: vw5h8XsRTvKsuvImy4Rupg.3", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.3", "Function": "fire()", "Line": "55"]
2022-05-10 19:58:06.738 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["eventName": "FetchWellKnownConfigDocumentOperation", "code": "200", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.3", "isSuccessful": "true", "CV_response": "", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.3"]
2022-05-10 19:58:06.766 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDPerformanceMetrics properties: ["eventName": "Presentation getRequest", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.3"]
2022-05-10 19:58:06.791 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.4", "Function": "fire()", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Message": "Correlation Vector for VCNetworking.FetchContractOperation: vw5h8XsRTvKsuvImy4Rupg.4", "Line": "55"]
2022-05-10 19:58:07.601 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["isSuccessful": "true", "eventName": "FetchContractOperation", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.4", "CV_response": "", "code": "200", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.4"]
2022-05-10 19:58:07.611 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Line": "55", "Function": "fire()", "Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: vw5h8XsRTvKsuvImy4Rupg.5", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.5", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 19:58:07.671 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["code": "200", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.5", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.5", "eventName": "FetchDIDDocumentOperation", "CV_response": "", "isSuccessful": "true"]
2022-05-10 19:58:07.675 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Line": "55", "Message": "Correlation Vector for VCNetworking.FetchWellKnownConfigDocumentOperation: vw5h8XsRTvKsuvImy4Rupg.6", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "Function": "fire()", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 19:58:07.680 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["isSuccessful": "true", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "eventName": "FetchWellKnownConfigDocumentOperation", "CV_response": "", "code": "200", "CV_request": "vw5h8XsRTvKsuvImy4Rupg.6"]
2022-05-10 19:58:07.702 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDPerformanceMetrics properties: ["CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "eventName": "Issuance getRequest"]
2022-05-10 19:58:08.247 INFO VerifiableCredential 0 TID=1 145 (stopTrackCurrentMeasuredEvent()) DIDIssuanceRequest properties: ["Source": "QRScanner", "CountOfVCRequested": "0", "FirstTimeOnBoarding": "false", "LinkedDomainsStatus": "linkedDomainUnverified", "CountOfIdTokenRequested": "1", "CountOfSelfIssuedRequested": "0", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6"]
2022-05-10 19:58:08.248 VERB VerifiableCredential 0 TID=1 247 (navigateUsing(navigationBlock:)) navigateUsing: view had appeared previously CorrelationVector: vw5h8XsRTvKsuvImy4Rupg.6
2022-05-10 19:58:11.857 INFO VerifiableCredential 0 TID=1 72 (performAction()) DIDLinkedDomainsFailureContinueTapped properties: ["CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6"]
2022-05-10 19:58:18.106 INFO VerifiableCredential 0 TID=1 198 (onNextTapped()) DIDIssuanceAllowed properties: ["CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "RetryNumber": "0"]
2022-05-10 19:58:18.130 INFO VerifiableCredential 0 TID=1 123 (formatIssuanceResponse(response:isPairwise:)) ["Function": "formatIssuanceResponse(response:isPairwise:)", "Message": "Signing Issuance Response with Identifier", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCServices/VCServices/IssuanceService.swift", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "Line": "123"]
2022-05-10 19:58:18.135 ERRO VerifiableCredential 0 TID=1 492 (sendIssuanceResponse(for:withIssuancePin:completionHandler:)) Error: Optional(VCCrypto.KeychainStoreError.itemNotFound) Message: Failed to send issuance response container. Properties: ["File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/UseCase/RequirementUseCase.swift", "Throwable": "Optional(VCCrypto.KeychainStoreError.itemNotFound)", "Tag": "sendIssuanceResponse(for:withIssuancePin:completionHandler:)", "Line": "492", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.6", "ThrowableMessage": "The operation couldn’t be completed. (VCCrypto.KeychainStoreError error 2.)", "Message": "Failed to send issuance response container."]
2022-05-10 19:58:18.142 INFO VerifiableCredential 0 TID=1 55 (fire()) ["File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Message": "Correlation Vector for VCNetworking.PostIssuanceCompletionResponseOperation: vw5h8XsRTvKsuvImy4Rupg.7", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.7", "Line": "55", "Function": "fire()"]
2022-05-10 19:58:18.144 INFO VerifiableCredential 0 TID=1 145 (stopTrackCurrentMeasuredEvent()) DIDIssuanceResponse properties: ["HasFailed": "true", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.7", "CountOfVCOwned": "0", "CountOfSelfIssuedPresented": "0", "CountOfVCPresented": "0", "CountOfIdTokenPresented": "0"]
2022-05-10 19:58:18.153 VERB VerifiableCredential 0 TID=1 92 (configure()) Showing error page with itemNotFound details:Error: VCCrypto.KeychainStoreError code: 2 CorrelationVector: vw5h8XsRTvKsuvImy4Rupg.7
2022-05-10 19:58:18.281 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CV_request": "vw5h8XsRTvKsuvImy4Rupg.7", "code": "400", "isSuccessful": "false", "eventName": "PostIssuanceCompletionResponseOperation", "CV_response": "", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.7"]
2022-05-10 19:58:18.282 ERRO VerifiableCredential 0 TID=1 44 (logNetworkingError(error:)) Error: nil Message: Networking Error: badRequest(withBody: "{"requestId":"82258e12c36c1e15b3aada355c09d19f","date":"Tue, 10 May 2022 19:58:18 GMT","mscv":"vw5h8XsRTvKsuvImy4Rupg.7.1","error":{"code":"IssuanceFlowFailed","message":"issuance_service_error"}}") Properties: ["Line": "44", "Tag": "logNetworkingError(error:)", "Message": "Networking Error: badRequest(withBody: "{\"requestId\":\"82258e12c36c1e15b3aada355c09d19f\",\"date\":\"Tue, 10 May 2022 19:58:18 GMT\",\"mscv\":\"vw5h8XsRTvKsuvImy4Rupg.7.1\",\"error\":{\"code\":\"IssuanceFlowFailed\",\"message\":\"issuance_service_error\"}}")", "ThrowableMessage": "", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.7", "Throwable": "nil", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/failureHandlers/SimpleFailureHandler.swift"]
2022-05-10 19:58:18.284 INFO VerifiableCredential 0 TID=1 570 (handleIssuanceCompletionResponse(presentationRequest:wasSuccessful:errorDetails:)) ["Message": "Failed Issuance Completion network call.", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/UseCase/RequirementUseCase.swift", "Line": "570", "CorrelationVector": "vw5h8XsRTvKsuvImy4Rupg.7", "Function": "handleIssuanceCompletionResponse(presentationRequest:wasSuccessful:errorDetails:)"]

updated iPhone Authenticator and received different error at this step... KeychainStoreError code 3 itemNoteFound
2022-05-10 20:22:52.923 ERRO VerifiableCredential 0 TID=1 99 (handleVCSDKErrorCase(:)) Error: Optional(VCCrypto.KeychainStoreError.itemNotFound) Message: Failed to migrate keys. Properties: ["Message": "Failed to migrate keys.", "Tag": "handleVCSDKErrorCase(:)", "Throwable": "Optional(VCCrypto.KeychainStoreError.itemNotFound)", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/Storage/PersistentContainer.swift", "Line": "99", "CorrelationVector": "", "ThrowableMessage": "The operation couldn’t be completed. (VCCrypto.KeychainStoreError error 3.)"]
2022-05-10 20:22:52.924 INFO VerifiableCredential 0 TID=1 101 (handleVCSDKErrorCase(_:)) DIDSDKInitializationFailure properties: ["CorrelationVector": ""]
2022-05-10 20:22:56.187 INFO VerifiableCredential 0 TID=1 137 (viewWillAppear()) DIDCardListViewed properties: ["Count": "0", "CorrelationVector": "wYBqHv9hRMu12v2GbYlPPA.0"]
2022-05-10 20:22:58.495 INFO VerifiableCredential 0 TID=1 137 (viewWillAppear()) DIDCardListViewed properties: ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.0", "Count": "0"]
2022-05-10 20:22:58.538 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Message": "Correlation Vector for VCNetworking.FetchPresentationRequestOperation: 8iF7LPIDQnOzdvpnEjZppg.1", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.1", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Line": "55", "Function": "fire()"]
2022-05-10 20:23:00.426 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.1", "eventName": "FetchPresentationRequestOperation", "CV_response": "", "isSuccessful": "true", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.1", "code": "200"]
2022-05-10 20:23:00.440 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.2", "Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: 8iF7LPIDQnOzdvpnEjZppg.2", "Line": "55", "Function": "fire()", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 20:23:00.785 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CV_response": "", "isSuccessful": "true", "code": "200", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.2", "eventName": "FetchDIDDocumentOperation", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.2"]
2022-05-10 20:23:00.813 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.3", "Function": "fire()", "Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: 8iF7LPIDQnOzdvpnEjZppg.3", "Line": "55", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 20:23:00.908 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CV_response": "", "code": "200", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.3", "isSuccessful": "true", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.3", "eventName": "FetchDIDDocumentOperation"]
2022-05-10 20:23:00.912 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.4", "Function": "fire()", "Message": "Correlation Vector for VCNetworking.FetchWellKnownConfigDocumentOperation: 8iF7LPIDQnOzdvpnEjZppg.4", "Line": "55", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift"]
2022-05-10 20:23:01.360 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CV_response": "", "isSuccessful": "true", "eventName": "FetchWellKnownConfigDocumentOperation", "code": "200", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.4", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.4"]
2022-05-10 20:23:01.389 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDPerformanceMetrics properties: ["eventName": "Presentation getRequest", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.4"]
2022-05-10 20:23:01.405 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Message": "Correlation Vector for VCNetworking.FetchContractOperation: 8iF7LPIDQnOzdvpnEjZppg.5", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.5", "Function": "fire()", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Line": "55"]
2022-05-10 20:23:01.800 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["CV_response": "", "isSuccessful": "true", "eventName": "FetchContractOperation", "code": "200", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.5", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.5"]
2022-05-10 20:23:01.809 INFO VerifiableCredential 0 TID=1 55 (fire()) ["Message": "Correlation Vector for VCNetworking.FetchDIDDocumentOperation: 8iF7LPIDQnOzdvpnEjZppg.6", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Function": "fire()", "Line": "55", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.6"]
2022-05-10 20:23:01.888 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["eventName": "FetchDIDDocumentOperation", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.6", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.6", "code": "200", "CV_response": "", "isSuccessful": "true"]
2022-05-10 20:23:01.892 INFO VerifiableCredential 0 TID=1 55 (fire()) ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "Function": "fire()", "Line": "55", "Message": "Correlation Vector for VCNetworking.FetchWellKnownConfigDocumentOperation: 8iF7LPIDQnOzdvpnEjZppg.7"]
2022-05-10 20:23:01.897 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["eventName": "FetchWellKnownConfigDocumentOperation", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "code": "200", "isSuccessful": "true", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.7", "CV_response": ""]
2022-05-10 20:23:01.918 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDPerformanceMetrics properties: ["CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "eventName": "Issuance getRequest"]
2022-05-10 20:23:02.635 INFO VerifiableCredential 0 TID=1 145 (stopTrackCurrentMeasuredEvent()) DIDIssuanceRequest properties: ["CountOfAccessTokenPresented": "0", "CountOfSelfIssuedRequested": "0", "Source": "QRScanner", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "FirstTimeOnBoarding": "false", "CountOfIdTokenRequested": "1", "CountOfVCRequested": "0", "LinkedDomainsStatus": "linkedDomainVerified"]
2022-05-10 20:23:02.636 VERB VerifiableCredential 0 TID=1 247 (navigateUsing(navigationBlock:)) navigateUsing: view had appeared previously CorrelationVector: 8iF7LPIDQnOzdvpnEjZppg.7
2022-05-10 20:23:11.990 INFO VerifiableCredential 0 TID=1 202 (onNextTapped()) DIDIssuanceAllowed properties: ["RetryNumber": "0", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7"]
2022-05-10 20:23:12.010 INFO VerifiableCredential 0 TID=1 123 (formatIssuanceResponse(response:isPairwise:)) ["Function": "formatIssuanceResponse(response:isPairwise:)", "Message": "Signing Issuance Response with Identifier", "Line": "123", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCServices/VCServices/IssuanceService.swift"]
2022-05-10 20:23:12.015 ERRO VerifiableCredential 0 TID=1 492 (sendIssuanceResponse(for:withIssuancePin:completionHandler:)) Error: Optional(VCCrypto.KeychainStoreError.itemNotFound) Message: Failed to send issuance response container. Properties: ["ThrowableMessage": "The operation couldn’t be completed. (VCCrypto.KeychainStoreError error 3.)", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/UseCase/RequirementUseCase.swift", "Line": "492", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.7", "Tag": "sendIssuanceResponse(for:withIssuancePin:completionHandler:)", "Message": "Failed to send issuance response container.", "Throwable": "Optional(VCCrypto.KeychainStoreError.itemNotFound)"]
2022-05-10 20:23:12.023 INFO VerifiableCredential 0 TID=1 55 (fire()) ["File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/operations/NetworkOperation.swift", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.8", "Function": "fire()", "Line": "55", "Message": "Correlation Vector for VCNetworking.PostIssuanceCompletionResponseOperation: 8iF7LPIDQnOzdvpnEjZppg.8"]
2022-05-10 20:23:12.026 INFO VerifiableCredential 0 TID=1 145 (stopTrackCurrentMeasuredEvent()) DIDIssuanceResponse properties: ["CountOfIdTokenPresented": "0", "CountOfVCPresented": "0", "HasFailed": "true", "CountOfSelfIssuedPresented": "0", "CountOfAccessTokenPresented": "0", "CountOfVCOwned": "0", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.8"]
2022-05-10 20:23:12.041 VERB VerifiableCredential 0 TID=1 92 (configure()) Showing error page with itemNotFound details:Error: VCCrypto.KeychainStoreError code: 3 CorrelationVector: 8iF7LPIDQnOzdvpnEjZppg.8
2022-05-10 20:23:12.167 INFO VerifiableCredential 0 TID=1 40 (event(name:properties:measurements:)) DIDNetworkMetrics properties: ["isSuccessful": "false", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.8", "CV_request": "8iF7LPIDQnOzdvpnEjZppg.8", "CV_response": "", "code": "400", "eventName": "PostIssuanceCompletionResponseOperation"]
2022-05-10 20:23:12.168 ERRO VerifiableCredential 0 TID=1 44 (logNetworkingError(error:)) Error: nil Message: Networking Error: badRequest(withBody: "{"requestId":"11fed35a3ee69fc7c592505a4fb4678a","date":"Tue, 10 May 2022 20:23:12 GMT","mscv":"8iF7LPIDQnOzdvpnEjZppg.8.1","error":{"code":"IssuanceFlowFailed","message":"issuance_service_error"}}") Properties: ["ThrowableMessage": "", "Tag": "logNetworkingError(error:)", "Message": "Networking Error: badRequest(withBody: "{\"requestId\":\"11fed35a3ee69fc7c592505a4fb4678a\",\"date\":\"Tue, 10 May 2022 20:23:12 GMT\",\"mscv\":\"8iF7LPIDQnOzdvpnEjZppg.8.1\",\"error\":{\"code\":\"IssuanceFlowFailed\",\"message\":\"issuance_service_error\"}}")", "Line": "44", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.8", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/Submodules/VerifiableCredential-SDK-iOS/VCNetworking/VCNetworking/failureHandlers/SimpleFailureHandler.swift", "Throwable": "nil"]
2022-05-10 20:23:12.170 INFO VerifiableCredential 0 TID=1 570 (handleIssuanceCompletionResponse(presentationRequest:wasSuccessful:errorDetails:)) ["Function": "handleIssuanceCompletionResponse(presentationRequest:wasSuccessful:errorDetails:)", "Message": "Failed Issuance Completion network call.", "File": "/Users/runner/work/1/s/PhoneFactor/VerifiableCredentialWallet/VerifiableCredentialWallet/UseCase/RequirementUseCase.swift", "Line": "570", "CorrelationVector": "8iF7LPIDQnOzdvpnEjZppg.8"]

Uninstalled and reinstalled Authenticator fixed this


Release v1.0 supporting rails 5.2 - 7, and testing on rails main

Release checklist:

[x] Update gem version in version.rb and README.md.

[x] Update CHANGELOG.md.

[x] Wait for the Travis build to come back green.

[x] Tag the release and push it to rubygems:
rake release

[ ] Copy the release notes from the changelog to GitHub Releases.

Draft at: https://github.com/thredded/db_text_search/releases/edit/untagged-eaefc4f69ba4dd583ab0
not sure about binaries

@glebm could you have a look at the release notes, and let me know if we need binaries and if so what

however we haven't yet removed it from the gemspec, because it might still work

Let's raise the minimum Rails requirement so that people on older Rails versions do not accidentally upgrade to a potentially incompatible release
No need to publish any binaries


MeteringPoint playback and newest object state creation

We are unsure if the playback mechanism should be used. It depends on the solution we choose.


url lose efficacy

i try to build from tag 1.5.1，but the url in alpine/Dockerfile is lose efficacy。
the url is "https://bintray.com/kong/kong-alpine-tar/download_file?file_path=kong-$KONG_VERSION.amd64.apk.tar.gz"

Hi @ancienter. We no longer maintain Kong 1.5. I would recommend you to switch to a newer version (latest is 2.5, check it out! :). Our new download location is download.konghq.com.


Option to increase sample rate of freehand drawings

Maybe it's even possible to adjust the sample rate dynamically based on the speed of pointer. Drawing.FREEHAND_SAMPLE_RATE controls the sample rate of the freehand tool:
  /**
   * The rate at which points are sampled (in milliseconds) during a freehand drawing workflow
   * @type {number}
   */
  static FREEHAND_SAMPLE_RATE = 75;

This was originally a feature request for Advanced Drawing Tools (dev7355608/advanced-drawing-tools#2). But it is definitely be a better fit for Precise Drawing Tools.

foundry default sample rate is 75
testing on my own computer shows that the real sample rate is approximately every 15 milliseconds
I'll try having the module set it close to 75 when the pointer is very slow and to 10 when the pointer is very fast

Added in v1.2.0, please give it a try!
screenshot


Add install deps script

this script installs dependencies for maintenance operator in dev env.
in addition minor modification to manager deployment for better security.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 65.644%

Totals

Change from base Build<PHONE_NUMBER>3:
0.1%

Covered Lines:
1091

Relevant Lines:
1662

💛  - Coveralls


pkg/bootstrap: fix a race between machinectl image-status and umount

There has been an issue of umount /var/lib/machines failing with -EBUSY. It happens only when a command machinectl image-status runs once at least. So we need to make a retry loop to attempt to umount, up to 3 seconds, to make it work correctly.

Recently I haven't seen this issue.
Closing. Will revisit this issue in the future when it happens again.


[🐞] Server functions cant run functions that are defined outside of the top level

Which component is affected?
Qwik City (routing)
Describe the bug
I want to define func inside of test and run it in a server function, but doing this causes a Dynamic require error
const test = async () => {
  let func = $(()=>"Working!")
  let serverFunc = server$(async () => {
    return func()
  })
  return serverFunc()
}

console.log(await test())

Expected outcome: log Working!
Outcome: Uncaught (in promise) Error: Dynamic require of "/src/test_func_7dytemg6cq8.js" is not supported
Notes:

If you move func out of the test function and into the top level, it works
If you dont serialize func you get an error saying You might need to convert it to a QRL using $(fn):. However if you run it in the top level without serializing it you dont get this error
If you log func in the server it actually is defined. It's a [AsyncFunction: invokeQRL]. Still wont run though
Trying to clone the function doesnt fix the issue. Returns the same error as before

Steps to reproduce
Run this:
git clone https://github.com/M-M-M-M-M-M-M-M-M-M/Qwik-JS-Server-Func-Bug && cd ./Qwik-JS-Server-Func-Bug && npm i && npm start
System Info
System:
    OS: Linux 5.17 Fedora Linux 36 (Workstation Edition)
    CPU: (4) x64 Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz
    Memory: 3.17 GB / 15.49 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.3.1 - ~/.nvm/versions/node/v20.3.1/bin/node
    Yarn: 1.22.17 - /usr/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v20.3.1/bin/npm
  npmPackages:
    @builder.io/qwik: ^1.2.6 => 1.2.6
    @builder.io/qwik-city: ^1.2.6 => 1.2.6
    undici: 5.22.1 => 5.22.1
    vite: 4.4.0 => 4.4.0

Additional Information
There isnt a Reproduction link because for some reason server$ breaks stackblitz. If you want to try to get it working, here's a link, but whatever's causing stackblitz to not work isnt related to my issue

Can you please explain the use case or problem you're trying to solve?

With my app all the requests sent to the server are signed with a crypto graphic key. Because of this all my functions have this boilerplate.
const user = {
  publicKey: "xxxxxx",
  privateKey: "xxxxxxx"
}

// boilerplate starts here
type Data = {"username": string}
const changeUsername = async (data: Data) => {
  let signedData = await sign(data, user)
  let serverFunc = server$(async function (signedData: string, publicKey: string) {
    let data: Data = await verify(signedData, publicKey)
    // [...]
    return response
  })
  return await serverFunc(signedData, user.publicKey)
}

I made a function that does all of this automatically, but it doesnt work because of this bug.

@hamatoyogi I found a workaround. I can store the function in an object and then pass that object into my function, that way it still counts as being defined as being on the top level.
I'm not opening myself up to code injections with this, am I?

@hamatoyogi I found a workaround. I can store the function in an object and then pass that object into my function, that way it still counts as being defined as being on the top level.
I'm not opening myself up to code injections with this, am I?

hard to say without seeing the code... But generally:
The server$ function in Qwik is designed to always execute on the server. It's a form of RPC (Remote Procedure Call) mechanism between the client and server. When you use server$, it wraps a function and returns an async proxy to the function. On the server, the proxy function directly calls the wrapped function, and a HTTP endpoint is automatically created by the server$() function.
As for security, it's important to note that server$ functions can read HTTP cookies, headers, or environment variables, which could potentially expose sensitive information if not handled properly. However, Qwik does not inherently make your application less secure. The security of your application largely depends on how you handle and protect sensitive data within your server$ functions.
For example, if you're accessing a database within a server$ function, you should ensure that you're properly authenticating and authorizing those requests. You should also avoid exposing sensitive information in HTTP responses.
In terms of storing the server$ function on an object, as long as the object itself is secure and not exposed to any potential threats, it should not pose a security risk. However, it's always important to follow best practices for security in your specific context.
For more information, you can refer to the Qwik documentation on server$. If you have specific security concerns, it may be best to consult with a security expert or conduct a security audit of your application.


HDFS-16783. Remove the redundant lock in deepCopyReplica and getFinalizedBlocks

Description of PR
When patching the fine-grained locking of datanode, found there is a redundant lock in deepCopyReplica and getFinalizedBlocks, maybe we can remove it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 14s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 24s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
23m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 56s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
22m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
239m  5s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

348m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4942

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 94ffd4d04031 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e012308dff14a110672f93f2ba97d4372ad42eb9

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/1/testReport/

Max. process+thread count
3873 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 10s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 34s

trunk passed

+1 :green_heart:
shadedclient
25m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
25m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
352m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

466m 35s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4942

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 04b55acfebd9 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e895ab5182913a7ab352b85782b605d64bf9a99b

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/2/testReport/

Max. process+thread count
1958 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4942/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao @MingXiangLi Sir, can you help me reivew this PR?
volumeMap.replicas already acquired the BP read lock, so here we can remove the redundant lock.

Committed to trunk. Thanks @ZanderXu for your contribution and thanks @MingXiangLi for your reviews.
Failed unit test seems not related to this change.


feat: account bound functionality

The Badge form needs to reflect the state of account bound.

Is this really not in the current version?


Thread/Task sleep prevents sending?

Hello,
consider this small program:
using System.Threading;
using ElectronCgi.DotNet;
using Microsoft.Extensions.Logging;

namespace ConsoleApp
{
    class Program
    {
        static void Main(string[] args)
        {
			var connection = new ConnectionBuilder()
				.WithLogging(minimumLogLevel: LogLevel.Trace)
				.Build();

			connection.Send("1", 1);
			connection.Send("2", 2);
			Thread.Sleep(5000);
			connection.Send("3", 3);

			connection.Listen();
		}
	}
}

What I would expect is, that the first two messages are sent immediately upon start of the program and then the third message is being sent after a 5 second delay.
But what happens is that no message is sent until those 5 seconds passed and then all are sent at once. Am I doing something wrong here?

Hi @lookapanda
You are doing nothing wrong. The thing is, nothing really happens until you call connection.Listen().
If you were to do that inside a request handler it would work as you'd expect:
            connection.OnAsync("requestType", async () => {
                connection.Send("1", 1);
                connection.Send("2", 2);
                await Task.Delay(5000);
                connection.Send("3", 3);
            });

(It's probably not a good idea to use Thread.Sleep given that the code relies on Tasks, see: https://stackoverflow.com/questions/20082221/when-to-use-task-delay-when-to-use-thread-sleep)
Alternatively you can do this as well:
            var connection = new ConnectionBuilder().Build();

            Task.Run(async () => {
                connection.Send("1", 1);
                connection.Send("2", 2);
                await Task.Delay(5000);
                connection.Send("3", 3);
            });

            connection.Listen();

The reason for this is that the connection really isn't ready until you call .Listen (maybe this is poorly named). It's in that method that the stdin and stdout streams start to be used to send and receive information between Node and .NET

Thank you! In my usecase (not the one I posted above), I now realized that Task.Wait() is similar to await Something() and thus it never reached connection.Listen() :)


File search only works on first thread message

When uploading a file to the assistants vector storage, you can access the file in newly created threads (thread id).
This is discussed here: https://community.openai.com/t/thread-unable-to-access-newer-assistant-files/689247/2
~With Sam (as well as assistants) we want to reuse threads because they represent the slack conversation with an assistant.~

The actual problem: If the first message in a thread was about something else than files, all future messages in the same thread won't be using file_search anymore.
Compare: https://community.openai.com/t/only-searches-files-if-first-message-uses-file-search/730992

We can't do much here but wait for OpenAI to work on a bugfix.

I hopefully created a ticket with their chat bot

I tried to add the assistants vector storage to the thread upon creation like here: https://platform.openai.com/docs/assistants/tools/file-search/attaching-vector-stores
This brought better results. However, we allow users to upload files. They are then added to the assistants own vector storage and hence leaking files across threads with the same assistant.

...I followed up in the chat. I hope there will be a response.

By Open-AI service agent

Thank you for providing additional details about the issue you're encountering with the Assistants API, specifically regarding file search functionality within threads. Based on the information you've shared, it seems like the core of the issue is related to how file search is triggered within a thread after initial interactions that do not involve file search. Given the setup you've described, here are a few suggestions and clarifications that might help: Explicitly Invoking File Search: While it's understood that you cannot predict whether a user's request will require file search, ensuring that the file search tool is enabled for every thread, as you've tried, is a good approach. According to the Assistants API documentation, once the file_search tool is enabled, the model decides when to retrieve content based on user messages. However, the behavior you're experiencing suggests there might be limitations or specific conditions under which the file search is triggered. Thread-Specific Vector Stores: To address the issue of file leakage across threads when users upload files, consider utilizing thread-specific vector stores. When a user uploads a file, you can create a new vector store for that thread or add the file to an existing thread-specific vector store. This way, files uploaded by users will only be accessible within the context of their respective threads. The documentation on File Search provides guidance on creating vector stores and attaching them to threads. Reviewing File Search Tool Configuration: Ensure that the file search tool's configuration within your assistant and threads is set up to support your use case. As per the documentation, the file search tool uses specific settings by default, such as chunk size and embedding model. Reviewing these settings might provide insights into how file search is being triggered. Investigating Message Structure: The structure of the messages sent by users and how they're processed by your assistant could influence whether file search is triggered. Reviewing the structure of successful versus unsuccessful file search attempts might reveal patterns or requirements for triggering file search. Given the complexity of the issue and the potential need for a more tailored solution, I recommend reaching out to OpenAI support with the details you've provided here, including the assistant and vector store IDs, the model you're using, and specific examples of the issue. While I understand this might not provide an immediate solution, sharing these details with the support team could facilitate a more in-depth investigation into why file search isn't being triggered as expected in certain scenarios. Lastly, I want to assure you that your query is being read and taken seriously. We aim to provide the best support possible, and your feedback is invaluable in improving our services.

I'll need to again dig deeper on the vectore storage topic.
Perhaps we can create one vector storage per thread that inherits all files from the assistants vector storage.


feat(@angular/cli): add support for custom npmrc path

According to the npm config docs, a user can specify the path to their
npmrc file using the environment variable NPM_CONFIG_USERCONFIG.
I ran into this issue on my system because I have my npmrc file in a custom location. I noticed it when running ng update @angular/cli because there were 404 errors on a few internal packages, which indicated that my npmrc was not
being honored.
I'm not sure if this fix is sufficient, but wanted to at least start a conversation about the issue.

@AdamVig, can you kindly rebase?

@vikerman this can be merged as it’s has some pending checks due to the recent CI changes.


Begin upgrading to v4.0.0-rc1

Pull Request Test Coverage Report for Build #253

122 of 223 (54.71%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-19.3%) to 80.039%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/com/uber/h3core/H3Core.java
106
107
99.07%

src/main/java/com/uber/h3core/exceptions/H3Exception.java
13
21
61.9%

src/main/java/com/uber/h3core/H3CoreV3.java
0
92
0.0%

Totals

Change from base Build #252:
-19.3%

Covered Lines:
409

Relevant Lines:
511

💛  - Coveralls

@dfellis @nrabinowitz @ajfriend I believe this is now ready for review.


Bluetooth: host: Add hardware error event handling

Add handling of the HCI_Hardware_Error event to log the hardware code.
This event was unmasked in set_event_mask.
Adding this mostly to improve documentation, since it shows up as "unhandled event 0x10" now, and the 0x10 event code did not have a definition.
We could consider if we should do anything at this point.

Very useful for split builds


warning: ‘Z’ directive writing 1 byte into a region of size between 0 and 9 [-Wformat-overflow=

Describe the bug
github.com/ava-labs/go-ethereum/accounts/usbwallet/trezor
github.com/ava-labs/go-ethereum/p2p
github.com/ava-labs/go-ethereum/vendor/gopkg.in/olebedev/go-duktape.v3
duk_logging.c: In function ‘duk__logger_prototype_log_shared’:
duk_logging.c:184:64: warning: ‘Z’ directive writing 1 byte into a region of size between 0 and 9 [-Wformat-overflow=]
sprintf((char *) date_buf, "%04d-%02d-%02dT%02d:%02d:%02d.%03dZ",
^
In file included from /usr/include/stdio.h:862,
from duk_logging.c:5:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:33:10: note: ‘__builtin___sprintf_chk’ output between 25 and 85 bytes into a destination of size 32
return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
To Reproduce
Steps to reproduce the behavior.
Expected behavior
no error
Operating System
WSL - Ubuntu 18.04
By submitting this issue I agree to the Terms and Conditions of the Developer Accelerator Program.

The upstream bug report for this is here https://github.com/svaarala/duktape/issues/2137

I think the bug is actually in the Go bindings for duktape: https://github.com/olebedev/go-duktape.v3, specifically fixed by https://github.com/olebedev/go-duktape/pull/67, and https://github.com/ethereum/go-ethereum/pull/20777. Awaiting approval or feedback on https://github.com/ava-labs/go-ethereum/pull/1 to incorporate the fix into Avalab's vendored version

ava-labs/go-ethereum#1 was merged, there are still warning relating to the duktape repo, but the overflow warning has been fixed.

For the record, the remaining warning I see is
# github.com/ava-labs/go-ethereum/vendor/gopkg.in/olebedev/go-duktape.v3
In file included from _cgo_export.c:4:
debugger.go:22:13: warning: ‘_duk_debugger_attach’ defined but not used [-Wunused-function]


Revit: Transforms of Linked Revit Model element is ignored

Description
ToSpeckle conversion ignores any transforms applied to Linked Revit Model element in the root project.
This issue appears separate/unrelated to any base point conversion issues, since Revit appears to align linked documents by internal origin point.
Expected
In this screenshot there are 4 projects.

"R" is geometry in the root project.
"1" is geometry in a linked model, which has translation.
"2" is geometry in a linked model, which has no transform.
"3" is geometry in a linked model, which has translation and rotation.

Link to Revit model: https://drive.google.com/drive/folders/1h4RXFtvGqRSj2yik0KoTpbfmFEOBALTe
Actual
When sent to speckle, it looks like this

https://speckle.xyz/streams/b6c2ae069c/commits/f279a5b206?c=[3.52621,-4.00989,22.73682,3.52621,-4.00986,-2,0,1]
We can see that 1 and 3 appear in the wrong place, due to their transforms being ignored.
Steps to reproduce

Add a linked model (Manage →Manage Project → Manage Links)
From within the root project, move/rotate the linked element.
Send to Speckle.
Observe, any movement operations will have no effect. The models will have their origin point aligned.

We decided to close this issue as it seems quite an edge case and we should not encourage applying transformations to linked models ;)


update ergo-lib to v0.23;

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 12 (8.33%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.987%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/src/contracts/update.rs
0
1
0.0%

core/src/contracts/refresh.rs
0
10
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2040

Relevant Lines:
3345

💛  - Coveralls


Use the raven installation manager if available.

Pull Request Description
What issue does this change request address?
Closes #2090
What are the significant changes in functionality due to this change request?
Uses the INSTALLATION_MANAGER from .ravenrc if it exists.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

checklist is good.


You can set another team's bot as active

I think fixing this should go along with the refactor of authentication

Fixed with #54


Please invite me to the GitHub Community Organization

Name
CodingSpecies
Discord Username (if applicable)
No response
Additional Context
Thank you.

@CodingSpecies you are welcome to ChryzHub🎉


Paperclip/pencil file duplicates

Why are there so many files? why not just one of each? (see PR 360) The files for pencil and paperclip should be reused when possible. If we need different file formats or something, please let me know.

@Sheeri @o-fish-wildaid
I saw that in project files there are no unused icons of pencil and paperclip.
All assets are vector files. Vector files change their sizes dynamically, depending on screen size.

OK, great. Thanks for investigating.


Analyzer: Make await voidExpression an error

This is the analyzer specific issue for implementing the error described in dart-lang/language#932, which has the details.

https://dart-review.googlesource.com/c/sdk/+/144681


Support template-haskell and tests on GHC < 8.8

We can effortlessly support GHC 8.0+ instead of GHC 8.8+ for both building and testing, so let's do that.
GHC's before 8.8 (base-4.13) don't export MonadFail to Prelude.
Relax the bounds on template-haskell to support GHC 8.0+
Tighten the bounds on containers and ansi-terminal to exclude unsupported versions.
Drop bounds specification in the test suite for dependencies shared with the library; the library already constrains these dependencies and it reduces maintenance burden.
This was tested with all major GHC versions between 8.0 and 9.0 inclusive, with cabal v2-test {,--prefer-oldest}. I also checked the examples on GHC 8.0.
To test with --prefer-oldest, you'll need this in cabal.project.local since older versions of these packages do not build with GHC 8:
constraints:
  aeson >= <IP_ADDRESS>,
  contravariant >= 1.5.2

We intend to add CI, but right now I'm focussing on getting this into Stackage. This is a preparation for that, just cleaning up some loose ends.

Closes #54


Pulls out CT mode into open source.

CT mode sets the near and far plane really close to each other. This allows to look at a slice of the point cloud directly in front of the observer and has been useful for internal debugging at Lyft.
This open sources the implementation, but does not mention the mode in README.md, since it seems very specific.

All done. PTAL.

@wally-the-cartographer merge

Merge requested by authorized user feuerste. Merge queue now has a length of 1.


[Issue Template] Add bug report template

Related Issue (#55)
Add bug report issue template for improved bug reporting in the project.

No need for this PR, all three files are included in the latest PR.


Support for OrderBy StartAt EndAt

There is probably a better way  to write it but this one is effective and easy to understand.

Maybe it worth including that the OrderBy requires quotes, Ex:
...OrderBy(""user_id"").StartAt("123456").EndAt("123456")

Maybe it worth including that the OrderBy requires quotes

Looking at the firebase docs it looks like we don't need the escaped quotes when using OrderBy
curl 'https://dinosaur-facts.firebaseio.com/dinosaurs.json?orderBy="weight"&limitToLast=2&print=pretty' -v
*   Trying <IP_ADDRESS>...
* Connected to dinosaur-facts.firebaseio.com (<IP_ADDRESS>) port 443 (#0)
* TLS 1.2 connection using TLS_DHE_RSA_WITH_AES_128_GCM_SHA256
* Server certificate: *.firebaseio.com
* Server certificate: RapidSSL SHA256 CA - G3
* Server certificate: GeoTrust Global CA
> GET /dinosaurs.json?orderBy="weight"&limitToLast=2&print=pretty HTTP/1.1
> Host: dinosaur-facts.firebaseio.com
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Content-Length: 346
< Content-Type: application/json; charset=utf-8
< Cache-Control: no-cache
< Strict-Transport-Security: max-age=31556926; includeSubDomains; preload
<
{
  "bruhathkayosaurus" : {
    "appeared" : -70000000,
    "height" : 25,
    "length" : 44,
    "order" : "saurischia",
    "vanished" : -70000000,
    "weight" : 135000
  },
  "triceratops" : {
    "appeared" : -68000000,
    "height" : 3,
    "length" : 8,
    "order" : "ornithischia",
    "vanished" : -66000000,
    "weight" : 11000
  }
}

There is probably a better way to write it but this one is effective and easy to understand.

I think that this is a great first step and get's the functionality out the door. Even if we decide to restructure this the API would end up staying the same. Could you please add a few tests similar to the shallow test?

I changed to use the param const as it was done for Shadow, and added some tests

LGTM. Thanks for your contribution @crystalin


Update change Log, migration trigger changes should be v2.0.1

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   90.97%   90.97%
=======================================
  Files          59       59
  Lines        2882     2882
  Branches      572      572
=======================================
  Hits         2622     2622
  Misses        246      246
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba118ed...e04bab8. Read the comment docs.


Delete jliang-mlflow-transformers-flavor.json

request deletion.

Hey, your code is still publicly available here: https://files.pythonhosted.org/packages/b3/42/c2b1d061fde9a4ac549a7207ebd3bc9fbbfaf575f25b1acb2a60f6b0809d/jliang-mlflow-transformers-flavor-<IP_ADDRESS>.dev1.tar.gz
Many services mirror, scan and retain pypi packages. Removing the metadata here is not a solution to that, and it would still exist in the git history.


Please document the known issue around ERROR [HY000] [Microsoft][QuickBooks]

The QuickBooks connector fails frequently at regular intervals (every 1-2 days) with the error message "ERROR [HY000] [Microsoft][QuickBooks] . API Connection Failed. Bad Request. HTTP Response code: 400". This error goes away after manually generating a refresh token from QuickBooks and using the new token.
I originally thought that this was an issue on QuickBooks side where the refresh token expires before it's due (as per QuickBooks API documentation, refresh token only expires after 100 days), but this does not appear to be the issue because other applications (non-Azure) that use the same refresh token seem to be connecting successfully.
Please mention this as a limitation. Also please suggest any workarounds while dealing with QuickBooks connector (other than manually updating the refresh token).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998a28b0-5278-73e2-7e27-b01997807797
Version Independent ID: c7a902d0-b098-0e3d-ef13-3f5f3082382d
Content: Copy data from QuickBooks Online using Azure Data Factory (Preview) - Azure Data Factory
Content Source: articles/data-factory/connector-quickbooks.md
Service: data-factory
GitHub Login: @jianleishen
Microsoft Alias: jianleishen

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Thank you for your feedback. This has been assigned to the content owner and will be updated as appropriate.

This isn't a doc change that I'm willing to make. 1-2 days isn't how the OAuth refresh interval should work.
Wonder if your token is getting throttled by Quickbooks or something performance related, maybe when there are too many requests happening in a day or so, so it blocks it.
Sounds like something broken, and needs to be diagnosed. Please work with support if you still have it in the broken state. I can't write in the doc that this is the expected behavior.
Thanks, Jason
#please-close

This is not caused by any throttling on the account. Refer to Quickbooks documentation around refresh tokens - https://developer.intuit.com/app/developer/qbo/docs/develop/authentication-and-authorization/faq
Even though the refresh token is valid for 100 days, it looks like Quickbooks updates the refresh token every 24 hrs. This is an additional measure implemented by Intuit on top of the standard OAuth process.
Looks like the Quickbooks connector in ADF is unable to handle the scenario of refresh token update every 24 hours. I can confirm that the refresh token (and the app in Intuit) is not being changed by any other processes.
Specifically refer to the following paragraph in Intuit documentation FAQ link above:
"We update the value of the refresh_token value every 24 hours hours, or the next time you refresh the access tokens after 24 hours. This is an additional security measure by Intuit to reduce risk of compromise."

I am experiencing the same problem - It seems like the connector fetches a new access token and gets a new refresh token alongside it from the API, but there is no way for me to get that new refresh token. Even if I try to refresh it manually upfront, I sometimes (if less than 24h passed) get the old (but still valid) refresh token back and when my copy activities run right after that (>=24h passed, new token returned, old token expired) it just fails again.
@jayendhar-cf Did you find a way to get around this? I would imagine going custom with python and direct API access will solve it, but this would be so much simpler.

@jense789 - I ended up building a workaround (a separate ADF pipeline which runs every 1 hr. or so) that does something like this. I stored the QBO refresh token in Key vault, and wrote a pipeline to check if there is a new refresh token available, and adjust the key vault entry. The QBO connection in the actual ADF pipeline will refer to the key vault for the QBO refresh token.

The QBO connection I am using in ADF pipeline looks something like below:

@jayendhar-cf  Wow, thanks for the detailed description!
That looks very similar to what I currently have! But I'm just running this only once immediately before my daily load and not hourly, so this might be the missing puzzle piece.
I'm also saving the new refresh token to the key vault regardless of it being the same.