[ENH] Add size parameter for ieeg channels and compute it during contact location

Related to https://github.com/mne-tools/mne-python/issues/10090.
In working with my own data, we have contacts that are different sizes and using a strict distance-based metric of labeling as implemented in mne.get_montage_volume_labels sometimes returns unhelpful labels at relatively low distances (e.g. 3 mm crossing the dura and being labeled as cortex in the cerebellum or having labels in the brainstem from subcortical structures). The function to compute which voxels are within a threshold of the maximum is already implemented in mne.get_montage_volume_labels and actually the input to that function is very cumbersome. Breaking it down into two steps of making an image in voxels and then warping that image I think would be easier to understand from a user perspective. Since there has been a release since this function was added the deprecation will be a bit complicated though. Also an option is not to deprecate and just call the montage-to-image function from warp_montage_volume but I think it would be good to split that up for the long-term maintainability but just my opinion.
As mentioned in the referenced issue, this could be used smartly with binary dilation to get a different estimate of the anatomical labels of a contact.

Also an option is not to deprecate and just call the montage-to-image function from warp_montage_volume but I think it would be good to split that up for the long-term maintainability but just my opinion.

I would say let's start with the split-up-but-don't-deprecate plan. Maybe get_montage_volume_labels can be saved someday if people find a good reliable algorithm that works 90%+ of the time. And if not, it can at least serve as a quick pass version.

Where I was going with this is that BIDS has electrode contact size as a parameter but I think it might be better instead of exposing the image to make a function to calculate it. Here is where it is described in the spec: https://bids-specification.readthedocs.io/en/stable/04-modality-specific-files/04-intracranial-electroencephalography.html. I think ideally, you would know the size but it would be better to have an estimate than nothing at all. This might be an mne-bids issue but I think this is really tricky because there isn't anywhere in the Raw object to store the size as far as I know.

Maybe get_montage_volume_labels can be saved someday if people find a good reliable algorithm that works 90%+ of the time. And if not, it can at least serve as a quick pass version.

I was thinking about this and there are biomechanical models of brain tissue deformation with a needle insertion into a brain 10.1371/journal.pone.0242704 but this is quite advanced and doesn't seem like the biggest deal for sEEG. The ground truth is that the electrode contact displaces the tissue so I think it wouldn't make sense for larger contacts to have more labels based on volume in the CT, surface area is what is important. I guess unless you have model of the voxel displacement, the best approach available is to just pick voxels within a certain distance of the center. This could be adjusted based on the size of the contact by the user by picking specific channels to compute labels for at a time. This does make assigning the channels sizes, preferably in the Raw object something that would be helpful for ieeg users.

I think this is incorporated into #10216 and has to do with actually modeling what's going on with electrical activity in the vicinity of the contact and not just treating it as a point.


Feature request: symmetric matrix constructors

Some common and useful symmetric matrices it would be nice to construct in one step:

Toeplitz
Hermitian
Circulant

https://en.wikipedia.org/wiki/Symmetric_matrix

Using the function I mentioned in #145, here's a sketch of a symmetric matrix constructor:
fn upper_diag_inds(nrows: usize, ncols: usize) -> Vec<[usize; 2]> {
  (0..nrows)
    .enumerate()
    .flat_map(|(iter_ind, row_ind)| {
      (iter_ind..ncols).map(move |col_ind| {
        [row_ind, col_ind]
      })
    }).collect()
}

// Computes the inverse of the triangular number function. Returns Result,
// because not every number is triangular.
fn triangular_inverse(tri_num: usize) -> Result<usize, Error> {
  let test_num = (((tri_num * 8 + 1) as Float).sqrt() - 1) / 2;
  if test_num == test_num.floor() {
    Ok(test_num)
  } else {
    Err("Input {} was not triangular.", &tri_num);
  }
}

// Assumes that the values are passed in row-major order, with all values below
// the diagonal omitted.
fn symmetric_matrix<T>(values: Vec<T>) -> Matrix<T>
  where T: NumCast + Float + Any {

  // Panics here if the number of values for the upper diagonal is not a
  // triangular number.
  let dim: usize = triangular_inverse(values.len()).unwrap();

  let mat: Matrix<T> = Matrix::zeros(dim, dim);

  for (val_ind, upper_diag_ind) in upper_diag_inds(dim, dim).enumerate() {
    mat[upper_diag_ind] = values[val_ind];

    // Add elements to transpose
    if upper_diag_ind[0] != upper_diag_ind[1] {
      mat[upper_diag_ind[upper_diag_ind[1],
                         upper_diag_ind[0]]] = values[val_ind];
    }
  }
}

Sorry for my slow response on this!
I agree with you that adding simple constructors for these matrices could be a good thing. I'll give my thoughts on this issue and #145 together here.
Firstly I think that because these are fairly niche things they are probably better kept a little apart from the current Matrix API. Additionally we have had some discussion about Symmetric/Triangular matrix storage in the past and these types seem like they may be better tackled as part of that work. See @Andlon 's work on the Permutation matrix for an idea of what I'm talking about.
As for the upper/lower_diag_inds my feeling is that these do not serve a common use case and it's a little difficult to understand exactly when they are useful. For example why not just do:
for i in 0..rows {
    for j in i..cols {

    }
}

As always I'm happy to hear thoughts from the other side. Let me know if I am missing anything!

I'll think more deeply about the other matrix items. I think you're right that there is potential if matrices that are known to have special properties are given "special" status within the library, certainly if they are known to be Symmetric.
The reason why it's useful to have a Vec or Iterator expression of the symmetric indices as opposed to just a couple of nested for loops is I think a standard characteristic of Rust: every iterative operation has an expressive functional equivalent. I don't think there is a one-liner that performs the task of creating an Iterator or Range like (0..rows).zip(cur_row..cols), and even if there was, it's more helpful for it to have a name.
On the other hand, if there was a SymmetricMatrix trait or struct, such an Iterator would follow naturally. What do you think?

I think in general it's nice to provide some functionality for working with commonly occurring matrices with special structure. However, I think we should maybe think about this from a usage perspective. What applications actually require this functionality?
Let's take the symmetric matrix construction example. The proposed function takes a vector of values corresponding to the upper triangular part of the matrix. In most applications that I can think of, it's significantly harder to build a vector of such values than to work with a full matrix, and such a function would just copy the values into a full matrix anyway, so it would be both more intuitive and more efficient to just build a full matrix in the first place, using a double for loop or whatever is appropriate for your application.
A useful alternative, as @AtheMathmo mentioned, would be to have a custom struct for SymmetricMatrix which actually stores only the symmetric part of the matrix. This would save roughly half the memory costs of storing a full matrix. However, the development costs would be very high: we would have to provide specialized operator overloads (multiplication, add, subtract etc.) between all types of such special matrices for it to be useful. In some cases this might be worth it (in the case of PermutationMatrix, significant memory and performance benefits were attained in some cases), but the bar is quite high.
Now, the Toeplitz matrix is interesting, however. Like the PermutationMatrix, its special structure makes it possible to solve an invertible Toeplitz matrix in only O(n2) operations, and it can be stored in only O(n) memory. Moreover, we wouldn't really need to implement binary operators (I think? Does one often multiply by a Toeplitz matrix? I think not. And in any case it can be converted to Matrix for those purpose, although it is not optimal), so it wouldn't have to be very invasive to implement.
Finally, I just want to say that while I think custom storage for e.g. triangular, symmetric and other types of matrices is too much work to be worth it, a more enticing approach is the concept of special matrix "wrappers" through which one could access special APIs for special matrices. We've discussed this before in various different issues. As an example, one could imagine this (purely imaginary, not sure if it would work out this way):
let x = matrix![ 1.0, 0.0, 0.0;
                 2.0, 1.0, 0.0;
                 1.0, 2.0, 3.0];

// Wrapper verifies that the matrix satisfies the lower triangular constraint
let lower_triangular = LowerTriangular::from_matrix(x).expect("Matrix is lower triangular");
// Wrapper makes no verification
let lower_triangular = LowerTriangular::from_matrix_unchecked(x);
// Wrapper verifies using an element-wise tolerance rather than exactly zero
let lower_triangular = LowerTriangular::from_matrix_with_tol(x, 1e-12)
                                      .expect("Matrix is lower triangular to given precision");

// Once obtained, one can efficiently solve the triangular system
let y = lower_triangular.solve(Vector::zeros(3))
                                    .expect("Triangular system is invertible.")

// Or compute the determinant
let det = lower_triangular.det();

A major benefit of such an approach, is that it allows us to check that the constraint is satisfied exactly once, and then solve many such systems without risk of the constraint breaking between different calls to solve.


Can we add functionality to Hiro Wallet's Bitcoin transaction constructor that exposes OP_RETURN fields?

Currently, in order to pass data to a Bitcoin transaction's OP_RETURN field, front-end devs have to construct a PSBT and use the PSBT API. Can this method be extended to include fields for OP_RETURN (for instance, for including the Hiro Wallet authenticated Stacks address so that it exists on-Bitcoin-chain)?
cc: @kenrogers

We've been discussing this as a team and erring towards keeping the sendTransfer method you've referenced simple (with the idea that PSBTs are best for more advanced use cases, since by nature they provide a ton of extensibility). However, there's certainly a trade-off here to requiring users to construct PSBTs as you've indicated.
Would it be sufficiently helpful if we provided guidance on how to construct PSBTs, especially ones with OP_RETURN data?

I'm not in this conversation, but to me - Yes it would defintily have been useful to see a full end to end example of psbts: I've been asking for this elsewhere and was asked to instead provide example of how I would do it without hiro at all.
Im kinda there now anyway via trail and error.... however still riding into some gochyas arround legacy addresses which I am asking about in your discord.

@markmhx that would be great and I think would sufficiently solve the problem.

Speaking with some external parties, this is a common and quite useful use-case. As it's often used as a memo, of sorts, it seems reasonable sendTransfer would include this ability.


Fix validation for input field definition directives

Probably the result of a copy-paste mistake.
I noticed this error while trying to validate a schema in Lighthouse that contained directives that are supposed to work on input fields, like:
directive @rules on ARGUMENT_DEFINITION | INPUT_FIELD_DEFINITION

input Foo {
  bar: ID @rules
}

They were wrongfully rejected with:
    GraphQL\Error\InvariantViolation  : Directive @rules not allowed at FIELD_DEFINITION location.
 GraphQL request (1:1)
 1: """
    ^
 2: Validate an argument using [Laravel validation](https://laravel.com/docs/validation).
 Directive @rules not allowed at FIELD_DEFINITION location.

Coverage remained the same at 86.287% when pulling 1b26abf0d14fd1ce6dfce861c367efe1e1aac8ff on spawnia:fix-input-field-directives-validation into 5042bedc57059d486e9c7da7b3ddcac3a5cbcd15 on webonyx:master.


Override unf_ext gme for Azure resource

This change loads in unf_ext with the solaris fix. This is a temporary bind until:
knu/ruby-unf_ext#39
Can be merged/released accordingly.
Credit to @scotthain
Signed-off-by: Jared Quick<EMAIL_ADDRESS>

We are going to do this at a different level.


WIP: Add chartvalues e2e test

@rossf7 If you wanna take over here, while I am on holidays its cool with me. Otherwise I can also pick it up afterwards. I added a more generic tb-resource-chart that should be easily extendable to secrets and user-configmap. Passing values with the configmap is working fine.
There is still this issue https://github.com/giantswarm/giantswarm/issues/3896, but having a 10min wait for release status seems it to fix for now. (e2e-harness pr still needs to be merged aswell)
I didn't quite get the added secret support to work, and left it out for now. There are some troubles parsing the json string (maybe just need bas64 encoding in the chart, or also some adjustment in chart-operator itself, cc @MarcelMue ):
{rpc error: code = Unknown desc = release tb-configmap failed: Secret in version \"v1\" cannot be handled as a Secret: v1.Secret: ObjectMeta: v1.ObjectMeta: TypeMeta: Kind: Data: decode base64: illegal base64 data at input byte 0, error found in #10 byte of ...|secret\\\"}\"},\"kind\":\"|..., bigger context ...|\":{\"secret.json\":\"{\\\"secret\\\":\\\"default-secret\\\"}\"},\"kind\":\"Secret\",\"metadata\":{\"name\":\"values-secre|...}]


horizontal line is not spread on whole width

hi,
@mikejacobson
when there are only few tabs, and the scroll buttons are hidden, the horizontal line (just below the tab headers) is not being spread to the whole width, but instead it is being terminated at the last tab.

Hi Shemesh,
v0.0.19 should fix this issue.
It also contains a possible fix for your issue #11. It worked when I ran it locally but it wasn't working quite right in the fork of your plunk that I made:
http://plnkr.co/edit/575H1Br10RhX5fNQ5mnB
With the new scrolling-tabs.js, you just need to add watch-tabs="true" to the scrolling-tabs-wrapper element and it will refresh things when tabs are added or removed via ng-if.
So when you click the "don't panic" button, the error isn't thrown anymore and the additional tabs display. But the problem--in the plunk, anyway--is that selecting a tab doesn't always work. It seems like it only registers that you selected a tab every other time. Strange, especially since it works fine running locally. So I'm still looking into it, but you can give it a try and see if it works for you.
Mike


How can i run electrumx for 2 coins at one machine ?

How can i run electrumx for 2 coins at one machine ?

Simplest approach is to use docker and expose different electrumx container representing each coin in different ports.


Fixed - Set ng-model value for AngularJS v1.5.3

For AngularJS v1.5.3, ng-model value was empty any time.
$scope[modelValue] // undefined
ngModel.$modelValue //  Object { startDate="2016-04-27",  endDate="2016-04-30"}

I haven't had time until now to review this pull request but it looks like there are really only 4 lines that get changed yet there are 118 insertions and 202 deletions in files that don't even affect code. I'm closing this pull request because of that but will be fixing this error manually using your code.


[Request] log file location

Would be good to have a flag to output all logging to a file.

File logging is not going to be implemented because modern systems should use the system's logging services, such as journalctl/systemd, etc.
Please configure your logging externally. You will also improve the system stability because with a correct system setup you will also profit from automatic restarts on a crash, startup on boot, and log rotation based on your needs.


Remove the CPLEX requirement

Summary
The CPLEX installation requirement is causing a lot of issues on different platforms, see #951, #926 and @nonhermitian. Since CPLEX has no support for Python 3.5 and 3.8, which we support in Qiskit, CPLEX is optional for the functionality of Aqua.
This PR removes CPLEX from the requirements.

I agree. You need to remove this line too.
https://github.com/Qiskit/qiskit-aqua/blob/7056f9bdd9ece32c41e162faecdcd24cf483da6f/setup.py#L44

The removal in the setup.py turns out to break the code the in Examples section of the CPLEX optimizer:
File "../qiskit/optimization/algorithms/cplex_optimizer.py", line ?, in default
Failed example:
    optimizer = CplexOptimizer()
Exception raised:
    Traceback (most recent call last):
      File "/opt/python/3.7.1/lib/python3.7/doctest.py", line 1329, in __run
        compileflags, 1), test.globs)
      File "<doctest default[3]>", line 1, in <module>
        optimizer = CplexOptimizer()
      File "/home/travis/build/Qiskit/qiskit-aqua/qiskit/optimization/algorithms/cplex_optimizer.py", line 60, in __init__
        raise NameError('CPLEX is not installed.')
    NameError: CPLEX is not installed.

@manoelmarques @woodsp-ibm Do you know if it is possible to install CPLEX just for the docs build?

Yes, a specific install can be added for the build, since its only needed in optimization we localized this to those tests @manoelmarques .
Also we might want to add cplex to the extra_requires section of setup.py rather than delete it entirely.

I saw the extra_requires but wasn't sure if it goes there, I'll add it 👍

It does not have to but when present you can do 'pip install qiskit-aqua [name]' by whatever 'name' the set packages listed in the extra require is given and they will be installed too.

Docplex has some CPLEX runtime dependencies, as e.g. for reading .lp files since that's a CPLEX specific type afaik. The optimization module, at least at this stage, is not a independent, fully-flegded optimization package since we also want to have a smooth transition with common software from the optimization community.
I agree it's not great though to have this dependency in the tutorials. @t-imamichi or @stefan-woerner do you think we can replace the lp file from the tutorial with a format the Docplex can read without using CPLEX?

Having a smooth transition or an interface to it is fine, but requiring a package that can't be used without installing of large proprietary packages isn't. From what I can tell (which isn't much since I can't actually find the docplex source hosted anywhere and I'm digging through the extracted package and docs) it only does anything if you have either CPLEX optimization studio installed, ilog cp installed, or have an ibm cloud account and a subscription to the optimization service. It doesn't cause a failure on import but does it actually do anything without installing an IBM product or using the service? It doesn't feel like something that should be required for installing aqua and should only be opt-in when a user chooses to use that interface. I agree the tutorial shouldn't be written using this interface and needs to be refactored to be more generally usable.
But that being said all the issues with cplex you outline in the PR summary look like they're true with docplex too it only lists support for py 2.7, 3.6, and 3.7 on pypi. Although it doesn't look like it's causing an install time or import time failure like cplex.

Docplex has been used in Aqua for some time. It should be fine - we test it on 3.8 for what we use, though as you note the package does not explicitly list it. cplex is the new package that was introduced.

I think this method should note the cplex requirement in its docstring https://github.com/Qiskit/qiskit-aqua/blob/7056f9bdd9ece32c41e162faecdcd24cf483da6f/qiskit/optimization/problems/quadratic_program.py#L818

QuadraticProgram.write_to_lp_file has no dependency on cplex. docplex.mp.lp_printer.py can print out a LP file without cplex.
But, QuadraticProgram.read_from_lp_file needs cplex. docplex.mp.model_reader.ModelReader says as follows.
Note:
        This class requires CPLEX to be installed and present in ``PYTHONPATH``. The following file formats are
        accepted: LP, SAV, MPS.

I added a note to read_from_lp_file that CPLEX is required for that method, thanks for the info @t-imamichi.

It might be good to send a warning message when read_from_lp_file is invoked but cplex is not installed. We also need to skip unit some tests that includes read_from_lp_file if Travis has problems with Python 3.8.

The current version 7056f9bd passes all unit tests of optimization thanks to @Cryoris 's change to skip tests related cplex.

Though Docplex seems to be working with Python 3.5, some code in the optimization module was not compatible (e.g. inline type-hints are not supported). I fixed that and the tests now all run in Python 3.5 as well, thanks for bringing this up @mtreinish!

@t-imamichi Sorry, my bad. I meant to link the read method not a method that created LP since I saw they had not dependence. Thanks for catching that!


[HOLD] [N7 Account Settings] Create Home Address page

Tracking issue: https://github.com/Expensify/Expensify/issues/182122
Detailed section of doc: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.yq9k2fsi0uy6
Note: This cannot be completely implemented until the command UpdateHomeAddress has been created - see https://github.com/Expensify/Expensify/issues/231916

On hold for WhatsApp Quality

Changing to Monthly while on hold

Unassigning since k2 is not liking that i have so many issues assigned to me on hold, will get back to this once N7 Account Settings if off hold

Picking this back up!

App PR is still in review

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.67-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/14290

If no regressions arise, payment will be issued on 2023-02-15. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

Closing in favor of doing payment in https://github.com/Expensify/App/issues/11578


ActiveUsers list will keep expanding because empty entries are not dropped or sliced

The 10.GetAllActiveUsers list is a list that keeps expanding, instead of removing it changes an address into 0x000...  (so empty)
it seems. So the list will get longer.
line 132: delete activeUsers[i];

Yes, It's because of solidity language. When you romve an element from your array, It will be cleaned but the place remains empty.
However in related functions I check that if user was zero address the function skip that.
https://github.com/nexlabs22/Nex-Dex-Contracts/blob/794b34e5f509a489d5152f64f10c1383f7f39b1e/contracts/Exchange.sol#L856

And are you not worried that in time, this will blow up this user list? (and with it increase the gas costs?)

When function see that it's zero address, skips it, and we don't pay gas for that.

Oke thats very nice!


Eddy County, NM

Contact:
http://www.co.eddy.nm.us/assessor.html

Closing as stale - Feel free to open a new issue if someone is actively going after these.


State-dependent methods / internal events.

Sometimes a user wants to create behaviour that varies based on state. But if the method has side-effects one needs to set aside a variable to store the result as events in umple currently don't have return types.
class Portal {
  statusWord = "";
  description = {"Current status: "+getStatusWord();}
  before getStatusWord {describe();}

  sm {
    closed {
      describe / {setStatusWord("closed");} -> closed;
      open -> open;
    }
    open {
      describe / {setStatusWord("open");} -> open;
      shut -> closed;
    }
  }
}

The above is wordy and the user must explicitly code the self transition that might clutter up the diagram, might be error prone, and is awkward. It would be better to be able to define a method in a state thus:
class Portal {
  description = {"Current status: "+getStatusWord();}

  sm {
    closed {
      String getStatusWord() {return ("closed");}
      open -> open;
    }
    open {
      String getStatusWord() {return ("open");}
      shut -> closed;
    }
  }
}

Any Umple method syntax should work.
The generated code would generate a single method getStatusWord with a case statement that would execute the right block of code depending on the state (with priority given to substate versions overriding higher level state versions. If no method version is defined in a state then a default of doing nothing and returning an empty string, null, zero, false or nothing, depending on the method;s return type.
The above would serve to implement UML's internal event capability.
In a queued or pooled state machine, should such a method be in the queue or be a direct call? I tend to think the former.
The above could be done by
a) Allowing any event method to return a value initiaally (with consistency enforcement, and default enforcement)
b) Adding the ability to tag any self transition as internal e.g. ~>
c) Allowing an ordinary method signature to implicitly define an internal transition.

See also #663

The following items are to do (from #1385). I will also point out some other items in a subsequent comment.
TODO as mentioned in PR

Test that different modifiers don't result in strange behaviour (currently, will take the first encountered modifier)
Test more complicated state nesting
Test multiple top-level state machines
There is a weird extra space added for the second state-dependent method in the test file which needs to be removed

In addition to the above, the code injection in the following results in
Warning on line 34 : Method 'pstatus' cannot be found. Injection was ignored.. More information (1012)

If I comment out the definitions of pstatus in the states, the warning goes away. Injections need to be made to work in stateful methods!
class X {
  public static void main(String [] args) {
    X testX = new X();
    testX.go();
    testX.pstatus();
    testX.stop();
    testX.pstatus();
    testX.go();
    testX.pstatus();
    testX.stop();
    testX.pstatus();
    testX.stop();
  }

  sm {
    init {
      void pstatus() {
        System.out.println("init");
      }
      go -> going;
    }
    going {
      void pstatus() {
        System.out.println("going");
      }
      stop -> init;
    }
  }

  void pstatus() {
      System.out.println("not in a state");
  }

  after pstatus {
     System.out.println("...");
  }
}


Honk proofs are structs(?)

This seems much better--you can read what's in the proof and you can explicitly see how thing serialize because there's a function that shows the serialization.
Luke: Also, this would allow for more explicit testing of invalid proofs in the recursive verification setting. E.g. this would make it easy to supply an incorrect multilinear evaluation or an bad wire commitment. See the honk recursive verifier tests for an example.

Can you assign this issue @codygunton and also please ellaborate on the issue a little

Hi @itsajay1029, sorry for the delay, I must have missed a notification.
To elaborate: here
https://github.com/AztecProtocol/barretenberg/blob/75926410954b3d7e5f6c8398ad7d59fd4d98d9fd/cpp/src/barretenberg/honk/proof_system/prover.hpp#L48
and here
https://github.com/AztecProtocol/barretenberg/blob/75926410954b3d7e5f6c8398ad7d59fd4d98d9fd/cpp/src/barretenberg/honk/proof_system/ultra_prover.hpp#L43
we see that the Honk provers output a plonk::proof (this is already weird, since Plonk and Honk are different proving systems). Elsewhere you will see that plonk::proof is simply an alias for a std::vector<uint8_t>. My idea is that, for Honk, we, should have more informative structures. Namely, each "flavor" (e.g., Ultra and Standard, but there are others, and more to come) should have a custom struct defined as a container for the proof. Each should have an explicit serialization method (say, serialize) that creates a std::vector or std::array of uint8_ts. This will make it very easy to see the exact structure of a proof, which currently has to be read by looking at the appropriate construct_proof function for calls to transcript.send_to_verifier. I like the explicitness of this struct solution, the fact that it localizes the proof information making it very easy to answer "what's in the proof", and believe that it will also help with debugging serialization issues (which I expect to be a major pain point farther down the line).
Does that make sense? Are you saying you'd like to have a crack at this?

Btw @ludamad if our proofs were structs, would we want this serialization method, or do we have some magic with msgpack that would let us deserialize to structs? I feel like the potential to catch bugs here is huge.

Also folding "proofs" when implemented

To be closed by https://github.com/AztecProtocol/aztec-packages/pull/2668

Also folding "proofs" when implemented

What do you mean by this? That we need to structure these proofs, or that it would help with implementing the folding scheme?


FluentValidation in WebApi trying to validate every property type in request objects

I'm trying to use FluentValidation to validate my webApi post requests but I'm having some issues when I try to create the validator instances using SimpleInjector.
The problem is that the FluentValidation api tries to find validators for every property of the request object, including the base types (string, int...). I only want the fluentValidation api to reach for existent validators.
My DI registration:
public static void Register(HttpConfiguration config)
        {
            Container container = new Container();
            container.Options.DefaultScopedLifestyle = new WebApiRequestLifestyle();
            RegisterServices(container);
            container.RegisterWebApiControllers(GlobalConfiguration.Configuration);
            container.Verify();
            config.DependencyResolver = new SimpleInjectorWebApiDependencyResolver(container);

            FluentValidationModelValidatorProvider.Configure(config, provider =>
            {
                provider.ValidatorFactory = new SimpleInjectorValidatorFactory(container); ;
            });
        }

My custom validator factory (as you can see, I made a workaround for this issue by returning an generic validator when there is no necessity to validate anything):
public class SimpleInjectorValidatorFactory : ValidatorFactoryBase, ISimpleInjectorValidatorFactory
    {
        private readonly Container _container;

        public SimpleInjectorValidatorFactory(Container container)
        {
            _container = container;
        }

        public override IValidator CreateInstance(Type validatorType)
        {
            try
            {
                return _container.GetInstance(validatorType) as IValidator;
            }
            catch (Exception)
            {
                return new ObjectValidator();
            }
        }

        private class ObjectValidator : AbstractValidator<object>
        {
            public ObjectValidator()
            {

            }
        }
    }

My model class and its validator:
public class InstrumentIdentification
    {
        public string IdInstrument { get; set; }
    }

    public class InstrumentIdentificationValidator : AbstractValidator<InstrumentIdentification>
    {
        public InstrumentIdentificationValidator(IInstrumentWebService instrumentWebService)
        {
            RuleFor(x => x.IdInstrument)
                .Must(instrumentWebService.IsValidInstrument);
        }
    }

Is there any other option to stop the chain validation for every object property?

Hi, WebApi will always call into the validator factory for every type it encounters - that's the normal and expected behaviour. It's the job of the validator factory to determine whether a validator should be returned or not. The usual thing to do here is to check inside the CreateInstance method if the validator type is registered with the container. If it is, call into the container to retrieve it. If it's not, then you should be returning null.

Great. Makes sense. I'll modify the factory to return null if there is no validator. Tks!


Add BSD tagging support to b3sum

Title pretty much says it all. Could this feature be added to b3sum, please?
Visual example:
$ b3sum --tag -- foo.bin
BLAKE3 (foo.bin) = 6dfbfe0d4e63479d25ea18acb6897e0aa3a2a9dc4b4bc3cf38198c26f9f94c8f

Seems reasonable enough. Would you be willing to submit a PR? If I understand correctly, the main change would be replacing this print statement with two different ways to print: https://github.com/BLAKE3-team/BLAKE3/blob/7692ba52e215fdec43b2b13159692fa20409f06c/b3sum/src/main.rs#L316

Thanks for the quick reply. I'm not familiar with programming languages outside of shell scripts and basic Python scripts, so I won't be of much help there, sorry.
Looking over digest.c in GNU coreutils' md5sum, it seems like the code around line 725 might be helpful to use for reference.

Seems reasonable enough. Would you be willing to submit a PR? If I understand correctly, the main change would be replacing this print statement with two different ways to print:
https://github.com/BLAKE3-team/BLAKE3/blob/7692ba52e215fdec43b2b13159692fa20409f06c/b3sum/src/main.rs#L316

There is more to it:
diff --git a/b3sum/src/main.rs b/b3sum/src/main.rs
index 0b692a2..3df4333 100644
--- a/b3sum/src/main.rs
+++ b/b3sum/src/main.rs
@@ -22,4 +22,5 @@ const NUM_THREADS_ARG: &str = "num-threads";
 const RAW_ARG: &str = "raw";
 const CHECK_ARG: &str = "check";
+const TAG_ARG: &str = "tag";
 const QUIET_ARG: &str = "quiet";

@@ -115,4 +116,9 @@ impl Args {
                     ),
             )
+            .arg(
+                Arg::new(TAG_ARG)
+                    .long(TAG_ARG)
+                    .help("Create a BSD-style checksum."),
+            )
             // wild::args_os() is equivalent to std::env::args_os() on Unix,
             // but on Windows it adds support for globbing.
@@ -158,4 +164,8 @@ impl Args {
     }

+    fn tag(&self) -> bool {
+        self.inner.is_present(TAG_ARG)
+    }
+
     fn raw(&self) -> bool {
         self.inner.is_present(RAW_ARG)
@@ -314,5 +324,9 @@ fn write_hex_output(mut output: blake3::OutputReader, args: &Args) -> Result<()>
         let hex_str = hex::encode(&block[..]);
         let take_bytes = cmp::min(len, block.len() as u64);
-        print!("{}", &hex_str[..2 * take_bytes as usize]);
+        if args.tag() {
+            print!("BLAKE3 () = {}", &hex_str[..2 * take_bytes as usize]);
+        } else {
+            print!("{}", &hex_str[..2 * take_bytes as usize]);
+        }
         len -= take_bytes;
     }
@@ -515,6 +529,8 @@ fn hash_one_input(path: &Path, args: &Args) -> Result<()> {
         print!("\\");
     }
-    write_hex_output(output, args)?;
-    println!("  {}", filepath_string);
+    write_hex_output(output, filepath, args)?;
+    if !args.tag() {
+        println!("  {}", filepath_string);
+    }
     Ok(())
 }

This is not finished because I am not sure how you would like to pass the filepath_string around. I leave it up to you.
In case of stdin, it should be:
BLAKE3 (-) = ...

otherwise:
BLAKE3 (filename) = ...

Example:
$ echo "foobar" | b2sum --tag
BLAKE2b (-) = 9e2bf63e933e610efee4a8d6cd4a9387e80860edee97e27db3b37a828d226ab1eb92a9cdd8ca9ca67a753edaf8bd89a0558496f67a30af6f766943839acf0110

$ b2sum --tag foobar
BLAKE2b (foobar) = 786a02f742015903c6c6fd852552d272912f4740e15847618a86e217f71f5419d25e1031afee585313896444934eb04b903a685b1448b755d56f701afe9be2ce

Seems reasonable enough. Would you be willing to submit a PR? If I understand correctly, the main change would be replacing this print statement with two different ways to print:
https://github.com/BLAKE3-team/BLAKE3/blob/7692ba52e215fdec43b2b13159692fa20409f06c/b3sum/src/main.rs#L316

There is more to it. How about this?
diff --git a/b3sum/src/main.rs b/b3sum/src/main.rs
index 0b692a2..23dc098 100644
--- a/b3sum/src/main.rs
+++ b/b3sum/src/main.rs
@@ -22,4 +22,5 @@ const NUM_THREADS_ARG: &str = "num-threads";
 const RAW_ARG: &str = "raw";
 const CHECK_ARG: &str = "check";
+const TAG_ARG: &str = "tag";
 const QUIET_ARG: &str = "quiet";

@@ -115,4 +116,9 @@ impl Args {
                     ),
             )
+            .arg(
+                Arg::new(TAG_ARG)
+                    .long(TAG_ARG)
+                    .help("Create a BSD-style checksum."),
+            )
             // wild::args_os() is equivalent to std::env::args_os() on Unix,
             // but on Windows it adds support for globbing.
@@ -158,4 +164,8 @@ impl Args {
     }

+    fn tag(&self) -> bool {
+        self.inner.is_present(TAG_ARG)
+    }
+
     fn raw(&self) -> bool {
         self.inner.is_present(RAW_ARG)
@@ -315,4 +325,7 @@ fn write_hex_output(mut output: blake3::OutputReader, args: &Args) -> Result<()>
         let take_bytes = cmp::min(len, block.len() as u64);
         print!("{}", &hex_str[..2 * take_bytes as usize]);
+        if args.tag() {
+            print!("\n");
+        }
         len -= take_bytes;
     }
@@ -515,6 +528,11 @@ fn hash_one_input(path: &Path, args: &Args) -> Result<()> {
         print!("\\");
     }
-    write_hex_output(output, args)?;
-    println!("  {}", filepath_string);
+    if args.tag() {
+        print!("BLAKE3 ({}) = ", filepath_string);
+        write_hex_output(output, args)?;
+    } else {
+        write_hex_output(output, args)?;
+        println!("  {}", filepath_string);
+    }
     Ok(())
 }

Example:
$ echo "foobar" | ./target/debug/b3sum
534659321d2eea6b13aea4f4c94c3b4f624622295da31506722b47a8eb9d726c  -
$ echo "foobar" | ./target/debug/b3sum --tag
BLAKE3 (-) = 534659321d2eea6b13aea4f4c94c3b4f624622295da31506722b47a8eb9d726c
$ ./target/debug/b3sum ~/foobar
af1349b9f5f9a1a6a0404dea36dcc9499bcb25c9adc112b7cc9a93cae41f3262  /home/user/foobar
$ ./target/debug/b3sum --tag ~/foobar
BLAKE3 (/home/user/foobar) = af1349b9f5f9a1a6a0404dea36dcc9499bcb25c9adc112b7cc9a93cae41f3262

$ echo "foobar" | b2sum
9e2bf63e933e610efee4a8d6cd4a9387e80860edee97e27db3b37a828d226ab1eb92a9cdd8ca9ca67a753edaf8bd89a0558496f67a30af6f766943839acf0110  -
$ echo "foobar" | b2sum --tag
BLAKE2b (-) = 9e2bf63e933e610efee4a8d6cd4a9387e80860edee97e27db3b37a828d226ab1eb92a9cdd8ca9ca67a753edaf8bd89a0558496f67a30af6f766943839acf0110
$ b2sum ~/foobar
786a02f742015903c6c6fd852552d272912f4740e15847618a86e217f71f5419d25e1031afee585313896444934eb04b903a685b1448b755d56f701afe9be2ce  /home/user/foobar
$ b2sum --tag ~/foobar
BLAKE2b (/home/user/foobar) = 786a02f742015903c6c6fd852552d272912f4740e15847618a86e217f71f5419d25e1031afee585313896444934eb04b903a685b1448b755d56f701afe9be2ce

@odiferousmint Looks good, thanks for the help!

I came here to request the same feature, anything blocking this?


add amazon sqs support

Looks good to me!!! Thanks for the contrib

I think the tests fail on this because it won't give it access to the secrets for SQS access.


fix: name of tile manifest on the top of the page

Before:

After:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.202%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/games/TileManifest.jsx
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>1:
0.0%

Covered Lines:
445

Relevant Lines:
15829

💛  - Coveralls

Sorry, we worked on top of each other. I fixed this in https://github.com/18xx-maker/18xx-maker/pull/627/commits/909223dd70e379948a4cb48471d77a41fa4e5240 which is in a PR I just pushed.


docs(orderBy): Start with a simpler example.

Per the question raised at this Stack Overflow question:
http://stackoverflow.com/questions/24048590/angularjs-ng-repeat-orderby-date-not-working
The first example on this page is too complex to convey the simplest possible case for using this function.

cla:yes.

This is a good idea. However, I think it would be better if the new example 1 and example 2 had an introductory sentence, explaining which features of order By are used in the example. Could you add this?

Sounds good. Thanks.
I have updated the commit (with a rebase / squash) to add a couple of sentences describing each example.

Thanks, landed! I had to make a few adjustments - the new example didn't actually work: if you don't use a scope property for your predicate, you need to make it a string literal: '-age'

You're very welcome. I'm glad you caught my mistake, too.
The updated example will be very helpful for programmers who just recently speed Angular. Thanks for merging it.


Added Scoop as installation method

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[ ] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[ ] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Added scoop as installation method for windows users.

Is it guaranteed to always download latest version from releases?

Yeah! they have a server running to check for updates, usually should should update within 24hrs.

Updated to latest version the same day it was released. https://github.com/ScoopInstaller/Main/commit/42ce17d

See https://github.com/yt-dlp/yt-dlp/issues/1313#issuecomment-945153465


Upload instructions do not include upload instructions

While all of the information is useful, http://depth.openseamap.org/#instructions does not mention registering, or which link is used for track upload.

this issue belongs to history


aniwatch.toURL change

Source information
aniwatch 14.39 (english)
Source language
english
Steps to reproduce
Select aniwatch from the Browse tab.
Expected behavior
A list of animations is displayed based on the source.
Actual behavior
The message "No result found" will be displayed
Aniyomi version
preview r7913
Android version
Android14
Other details
The URL for aniwatch appears to have changed to https://aniwatchtv.to/.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

Duplicate of #2690


Allow AMMCreate if issuer has clawback enabled when featureAMMClawbac…

for task:
https://ripplelabs.atlassian.net/browse/DEFI-186

High Level Overview of Change

Context of Change

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Performance (increase or change in throughput and/or latency)
[x] Tests (you added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation update
[ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
[ ] Release

API Impact

[ ] Public API: New feature (new methods and/or new fields)
[ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
[ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
[ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

closing this PR because we will send another PR when the full feature is ready


Operator precedence

Order
Operator
Description
Associativity

1
()
Function application
Left-to-right

| `[]` | Subscript |
| `.` | Member / path traversal |

2 | + - | Unary plus and minus | Right-to-left
| !     | Bitwise NOT |
| *     | Dereference |
| &     | Address-of |
3 | * / % | Multiplication, division, and remainder | Left-to-right
4 | + - | Addition and subtraction |
5 | < <= | Less than; and, less than or equal to |
| > >= | Greater than; and, greater than or equal to |
6 | as | Cast |
7 | == != | Equal to; and, not equal to |
8 | & | Bitwise AND |
9 | ^ | Bitwise XOR |
10 | | | Bitwise OR |
11 | not | Logical NOT |
12 | and | Logical AND |
13 | or | Logical OR |
14 | if / else | Ternary conditional expression | Right-to-left
15 | = | Assignment

[ ] Write parse tests to prove the above

We should move &, ^, and | to just under * and /. It doesn't make any sense for x & y == z to parse like x & (y == z) in practical usage.


InvalidArgumentError while training on GPU

Hi
After 1000 steps, when evaluation starts, I get the following error when training on GPU. I did the exact same training with the same data (200.000 training sentences) and parameters (example_config_nmt_small) on CPU without this error. Could anyone point me in the right direction as to what I did wrong exactly?

File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/decoder.py", line 287, in dynamic_decode
swap_memory=swap_memory)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2605, in while_loop
result = context.BuildLoop(cond, body, loop_vars, shape_invariants)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2438, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2388, in BuildLoop
body_result = body(*packed_vars_for_body)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/decoder.py", line 240, in body
decoder_finished) = decoder.step(time, inputs, state)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/decoders/attention_decoder.py", line 187, in step
time=time, outputs=outputs, state=cell_state, sample_ids=sample_ids)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/helper.py", line 134, in next_inputs
time=time, outputs=outputs, state=state, sample_ids=sample_ids)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/decoders/attention_decoder.py", line 155, in att_next_inputs
name=name)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/helper.py", line 204, in next_inputs
lambda: nest.map_structure(read_from_ta, self._input_tas))
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1745, in cond
_, res_f = context_f.BuildCondBranch(fn2)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 1639, in BuildCondBranch
r = fn()
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/helper.py", line 204, in
lambda: nest.map_structure(read_from_ta, self._input_tas))
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/util/nest.py", line 302, in map_structure
structure[0], [func(*x) for x in entries])
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/util/nest.py", line 302, in
structure[0], [func(*x) for x in entries])
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/seq2seq/seq2seq/contrib/seq2seq/helper.py", line 201, in read_from_ta
return inp.read(next_time)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/tensor_array_ops.py", line 250, in read
name=name)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/ops/gen_data_flow_ops.py", line 2421, in _tensor_array_read_v3
name=name)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/framework/op_def_library.py", line 763, in apply_op
op_def=op_def)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/framework/ops.py", line 2327, in create_op
original_op=self._default_original_op, op_def=op_def)
File "/home/pricie/milan/VirtualEnvironment/GPU/seq2seq/lib/python3.5/site-packages/tensorflow/python/framework/ops.py", line 1226, in init
self._traceback = _extract_stack()

InvalidArgumentError (see above for traceback): Tried to read from index 49 but array size is: 49
[[Node: model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3 = TensorArrayReadV3[_class=["loc:@model/att_seq2seq/decode/TrainingHelper/TensorArray"], dtype=DT_FLOAT, _device="/job:localhost/replica:0/task:0/cpu:0"](model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_1/_437, model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/Switch_2)]]
[[Node: model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3/_423 = _Recvclient_terminated=false, recv_device="/job:localhost/replica:0/task:0/gpu:0", send_device="/job:localhost/replica:0/task:0/cpu:0", send_device_incarnation=1, tensor_name="edge_1011_model/att_seq2seq/decode/attention_decoder_1/decoder/while/CustomHelperNextInputs/TrainingHelperNextInputs/cond/TensorArrayReadV3", tensor_type=DT_FLOAT, _device="/job:localhost/replica:0/task:0/gpu:0"]]

Thanks in advance.

see #103


AttributeError: exit

Dear developer,
I have the following problem when running your code irrev_mech. The detailed error info is listed below.
Traceback (most recent call last):
File "/Users/yuanjie/anaconda/bin/irrev_mech", line 11, in
load_entry_point('irrev-mech==2.1.0', 'console_scripts', 'irrev_mech')()
File "/Users/yuanjie/anaconda/lib/python2.7/site-packages/irrev_mech-2.1.0-py2.7.egg/irrev_mech/main.py", line 50, in main
convert_mech_irrev(args.chem, args.thermo, args.range, args.output, args.numprocs)
File "/Users/yuanjie/anaconda/lib/python2.7/site-packages/irrev_mech-2.1.0-py2.7.egg/irrev_mech/irrev_mech.py", line 458, in convert_mech_irrev
with Pool(processes=n_procs) as pool:
AttributeError: exit
Could you pls help me look into this?
Also, I installed Cantera in my laptop, is that the reason these two are incompatible?
Thanks
jyj

hello @yuj056, I just tried running this again on my machine (which is using Python 3.6) and it completed with no problems. Are you limited to using Python 2.7, or could you upgrade to 3.5 or 3.6?
Also, this program does not interact with Cantera, so there shouldn't be any conflict.

Hi Kyle,
Yes, after I update python it works.
Thanks,
Yuanjie
Sent from my iPhone

On Nov 18, 2017, at 8:10 PM, Kyle Niemeyer<EMAIL_ADDRESS>wrote:
hello @yuj056, I just tried running this again on my machine (which is using Python 3.6) and it completed with no problems. Are you limited to using Python 2.7, or could you upgrade to 3.5 or 3.6?
Also, this program does not interact with Cantera, so there shouldn't be any conflict.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

OK great. I will remove the claim of Python 2.x compatibility for the code, as that seems to be the cause.


Fixed links

Fixed link to Orb version badge and Orb registry page.

Hey thanks @peteraritchie! Appreciate the help


tests(celery): improve celery tests infra

CATEGORY
Choose one

[ ] Bug Fix
[ ] Enhancement (new features, refinement)
[X] Refactor
[X] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
This change proposes to deprecate the current method to launch celery workers on tests. The aim is to push running tests using docker-compose defined infra on the root of the repo.
A couple of changes were made to reach a fully functional yet simple test environment:

docker-compose will launch specific workers for tests.
Tests celery workers and dev celery workers don't share the same Redis DB. Test celery workers will use DB 2 and 3 for queue and results respectively.
Test celery workers use test DB on postgres

This is a step to run faster, more reliable, and closer to github actions env, tests.
Examples to run tests:

Run all tests with full init (resets test db, upgrades and loads examples):
./scripts/tests/run.sh tests

Run just a single test with full init:
./scripts/tests/run.sh tests.celery_tests:CeleryTestCase.test_run_async_query_cta_config

Run just a single test (with an already inited DB):
./scripts/tests/run.sh tests.celery_tests:CeleryTestCase.test_run_async_query_cta_config --no-init

Using tox:

./scripts/tests/run.sh . --reset-db
tox -e py36-postgres

Docker compose infra diagram:

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@willbarrett

I'm good with this. It would be nice to have the celery process for testing not running constantly, but I don't see a simple way to accomplish that and it's not a huge deal anyway.
LGTM!

Codecov Report

Merging #9775 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9775      +/-   ##
==========================================
+ Coverage   70.87%   70.96%   +0.09%
==========================================
  Files         588      184     -404
  Lines       30493    17881   -12612
  Branches     3154        0    -3154
==========================================
- Hits        21613    12690    -8923
+ Misses       8767     5191    -3576
+ Partials      113        0     -113

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
70.96% <ø> (-0.11%)
:arrow_down:

Impacted Files
Coverage Δ

superset/db_engine_specs/mysql.py
78.26% <0.00%> (-13.05%)
:arrow_down:

superset/db_engine_specs/sqlite.py
63.33% <0.00%> (-10.01%)
:arrow_down:

superset/result_set.py
96.63% <0.00%> (-1.69%)
:arrow_down:

superset/models/core.py
85.25% <0.00%> (-0.89%)
:arrow_down:

superset/sql_lab.py
77.63% <0.00%> (-0.44%)
:arrow_down:

superset/db_engine_specs/base.py
87.67% <0.00%> (-0.29%)
:arrow_down:

superset/views/core.py
74.90% <0.00%> (-0.23%)
:arrow_down:

...rset-frontend/src/components/ListView/ListView.tsx

.../explore/components/controls/CollectionControl.jsx

...ontend/src/dashboard/components/dnd/DragHandle.jsx

... and 401 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02f2d1...aea2376. Read the comment docs.


Fibonacci Formula Program

Implement the Fibonacci formula program in Java in O(1) time complexity!

Please assign this issue to me under Hacktoberfest!

Go ahead @aniket-24  follow me for more such repo to contribute :)

Hi, I want to contribute in Hacktoberfest 2021. Please assign me this task and also add label as Hacktoberfest-accepted.

Hi, I would like to contribute to this issue. Please assign it to me under Hacktoberfest!

Hello!
I've registered in Hacktoberfest 2021 and this is my first time to contribute in opensource and I would like to contribute on this topic. I've earned 4 stars in java from Hackerrank and I'm pretty confident that I am able to do it.

Please assign this issue to me. I would like to contribute in python, java & c++.


Bad notification posted from package com.example.background: Couldn't create icon

Hi. after pressing the "Go" button, the app crashed:
12-18 20:40:32.410 27724-27724/com.example.background E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.background, PID: 27724
android.app.RemoteServiceException: Bad notification posted from package com.example.background: Couldn't create icon: StatusBarIcon(icon=Icon(typ=RESOURCE pkg=com.example.background id=0x7f060060) visible user=0 )
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1519)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:5530)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:734)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:624)

It would be helpful to get some more info to help us understand the issue better:

Which codelab are you following? (Java, Kotlin)
Which step of the codelab does this happen on?

It would be helpful to get some more info to help us understand the issue better:

Which codelab are you following? (Java, Kotlin)
Which step of the codelab does this happen on?

Closing issue due to inactivity


Warning on using this component

/opt/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_datetime_picker-1.5.1/lib/flutter_datetime_picker.dart:311:32: Warning: Operand of null-aware operation '??' has type 'Color' which excludes null.
 - 'Color' is from 'dart:ui'.
                  color: theme.backgroundColor ?? Colors.white,

Same problem

yes, it shows a warning I am running on flutter web.
../../development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_datetime_picker-1.5.1/lib/flutter_datetime_picker.dart:311:32: Warning: Operand of null-aware operation '??' has type 'Color' which excludes null.

'Color' is from 'dart:ui'.
color: theme.backgroundColor ?? Colors.white,
^

The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
exit code: 128
pub get failed (server unavailable) -- attempting retry 5 in 16 seconds...

I checked the repo and it seems they fixed that but did not deploy a new version. You can import the package by git url and last commit hash like below. It will be fixed.
flutter_datetime_picker:
    git:
      url: git://github.com/Realank/flutter_datetime_picker.git
      ref: eb66486c47d50bf550950c196486121ffcea8885

The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
exit code: 128
pub get failed (server unavailable) -- attempting retry 5 in 16 seconds...

We have a fork up and running that's compatible with flutter 3.10
https://github.com/Bdaya-Dev/flutter_datetime_picker
https://pub.dev/packages/flutter_datetime_picker_bdaya


Ink Smart Contract Wizard

Project Abstract

Ink Contracts Wizard is an UI based smart contract generation tool. It will scaffold Smart Contracts based on the options selected by the user. User can also download the contracts if required.

Grant level

[x] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

Thanks a lot for your review and marking it approved.

Hey @Noc2. I recently came across this: https://openbrush.io/.
They already have a smart contract generator, just as same as OpenZepplin Wizard.
Should I terminate this grant since a tool like this already exists?

In general, we are interested in supporting multiple solutions. But if you prefer to work on something else instead, we can also terminate it. Whatever you prefer.

Hey @Noc2. I want to pivot a bit here instead of selecting options and generating smart contracts in the WebApp. I want to do the same in the CLI. I would raise PR for the same.
Here are the ideas I wish to work on: https://docs.google.com/document/d/10zN5rIYJObSDTwnirfUxIgAyxLxDpIPnkOgd59Y9oNs/edit?usp=sharing
How should I go about it? I am a bit confused here. If you can look at the doc, it would be great.

Feel free to create a PR to amend this contract/file.


Install @playwright/test notification showing on activation, despite being installed

I'm seeing this whenever I open my workspace:

My project is structures like this which is maybe the reason:
outer-project
  package.json
  node_modules
  sub-project (git module) <-- this is the opened folder
    package.json
    node_modules <-- this is where @playwright/test is installed

So the first problem is that I'm getting the notification at all. It also occurs to me that you shouldn't be showing a notification on activation or startup but when the extension actually needs to use the extension, otherwise it would just be annoying and add to many notifications popping up when syncing settings, opening vscode.dev, etc.

Extension is activated when it finds playwright.config.ts in your workspace. I assume you have one, so it activates. It will then go ahead and try running require.resolve("@playwright/test") from that config folder. It does that in order to populate the Test tree and render the editor decorators. Until it parses the config, any file potentially has test decorations, so parsing the config lazily does not save much.
Does running node -e "require.resolve('@playwright/test')" in your config folder succeed?

Notes from our call:

Notification on startup is a bad experience when opening a folder without node_modules installed for example

Only show the notification if node_modules is not installed seems like a good compromise

Bad experience for older versions apparently is the root cause of https://github.com/microsoft/playwright-vscode/issues/114

I was on<EMAIL_ADDRESS>

Have 2 playwright.config files, tests are duplicated in out (js) and src (ts) because of that
src/out folder was missing from config names

I cannot expand any of the items (related to compiled mode)

.test.d.ts files were showing up in tests

Notification on startup is a bad experience when opening a folder without node_modules installed for example

I'll remove those from the activation. It'll silently not work until user presses the 'Reload tests' button

Bad experience for older versions

Following up with a fix

Have 2 playwright.config files, tests are duplicated in out (js) and src (ts) because of that

That's by design, you can have several configs and they all will be loaded, compiling config would be unusual.

src/out folder was missing from config names

I did not want to print the whole path to config here, could be long. So I was disambiguating them using immediate parent. In your case parents have the same name. I'd still say unusual / low pri.

I cannot expand any of the items (related to compiled mode)

Compiled mode is not yet supported in the extension. We'll prioritize it based on the usage / reports.

Does not look actionable at this point, let's split into explicit requests for remaining issues.


Non-damaging actions import with damage checkbox ticked

When a creature's actions are imported, actions that do no damage import with the damage checkbox ticked, doing 0+Str damage. Example: Thug's Multiattack, Lich's Cantrip Legendary Action. Lich's Frightening Gaze.

Fixed via 3.3.3


[FEAT]: Provide the ability to publish Issuer metadata as a well-known spec

What is the feature request for?
Registry Core
What problem/inconvenience (if any) will this feature solve?
The framework should have the ability to publish the metadata as a wellknown spec file. This should be configurable and service multiple publishing formats. Currently we have REST based endpoints (DID-resolvers) to share the Issuer metadata.
Describe the feature clearly.
Add a new feature that does ....

https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html


The game prevents further submissions once the time limit expires, ensuring fairness and adherence to the game rules.

commit: 0ce79ac


add or clarify license

Can you add more explicit indication of the license under which firestation is released? I found "ISC" in package.json, but I am not certain to what it refers. Is it https://opensource.org/licenses/ISC?
Some possibilities:

add a file in the root of the sourcetree named LICENSE (or COPYING) that has a full copy of the license;
add a description in the README along with a link to a full copy of the license (not necessarily in the repo);
add copyright and license declarations in particular source code files.

This same issue applies to https://github.com/chrisvxd/firestation-demo

@slivingston damn forgot I missed the license. Will add shortly. Thanks for noticing.

Thanks for your work on firestation!

@slivingston no worries. You got it up and running?

Closed in 2348f0d


Add examples using async/await syntax

Thanks for creating this library! I used it to write a command-line version of the namescript user script and found it quite pleasant to work with :)
One thing that I think could be helpful: examples on how to use the library with async/await syntax instead of chaining .then calls. Since Bluebird promises (or any other Promises/A+ promises) are fully compatible with ES6 promises, this works out quite well, and I found it to be a very pleasant style of programming:
async function main() {
    const bot = new MWBot({
        apiUrl: 'https://www.wikidata.org/w/api.php'
    });
    await bot.loginGetEditToken({
        username: …
        password: …
    });
    …
    for (const itemId of …) {
        await bot.request(…);
    }
}
main().catch(console.error);

Do you think it would be worth adding such examples? I could try to adapt some of the existing examples if you’re okay with it.

Hello Lukas,
I'm glad this library works for you!
You are right. Since Node.js has proper async/await support, there's really no reason not to use the new syntax for it in almost all use cases.
I'll add your example to the documentation, thanks!

https://github.com/Fannon/mwbot/commit/32dca91abec447f23d5596943e68c498a279d3e6#diff-04c6e90faac2675aa89e2176d2eec7d8

Cool, thank you!


Run StyleCop only on modified code

I am working on applying StyleCop to an existing project. This project is however quite large and contains lots of different styles. I don't want to enforce StyleCop over night as the project will drown in warnings/errors from StyleCop. Is there a way to configure StyleCop in such a way that it will only report new code violations (e.g. only touched code based on a git diff)?

This is not directly supported by StyleCop Analyzers, but Visual Studio 2017 includes a tool to help you:

Bulk-suppression / Baselining – To suppress all active issues, you can select all issues in the Error List, right-click, and navigate to "Suppress" or you can right-click on your project in the Solution Explorer and navigate to Analyze → Run Code Analysis and Suppress Active Issues.

/cc @kuhlenh


Set cifmw_networking_definition for ci-bootstap staging

Set cifmw_networking_definition for ci-bootstap staging
Use the new ìs_trunk_parent and trunk_parent hints for ci-bootstrap
to understand how to attach networks.
Ref:
https://github.com/openstack-k8s-operators/ci-framework/pull/1218
https://github.com/openstack-k8s-operators/ci-bootstrap/pull/33
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/approve

/lgtm


Problem if 2 nodes have the same out pin name

On line 490 in the header file this should be changed to
std::vector<PinUID> m_nodeRecursionBlacklist;

Also if there are nodes with the same out pin name this will not work.
Maybe do something like using the parent uid and the out uid:
template<class T>
    const T &OutPin<T>::val()
    {
          PinUID po_uid = m_parent->getUID() + m_uid;   // po -> parent + out pin uid
          if (std::find((*m_inf)->get_recursion_blacklist().begin(), (*m_inf)->get_recursion_blacklist().end(), po_uid) == (*m_inf)->get_recursion_blacklist().end())
        {
            (*m_inf)->get_recursion_blacklist().emplace_back(po_uid);
            m_val = m_behaviour();
        }
        return m_val;
    }

Thanks, @Fattorino, works great now 👍


refactor: faster trust data

By removing the heath check before each acquisition of a trust data file, the run time of connaisseur speeds up dramatically.

Codecov Report

Merging #210 (1ebcb37) into develop (29f6666) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #210      +/-   ##
===========================================
- Coverage    96.65%   96.64%   -0.01%
===========================================
  Files           22       22
  Lines         1077     1074       -3
===========================================
- Hits          1041     1038       -3
  Misses          36       36

Impacted Files
Coverage Δ

connaisseur/validators/notaryv1/notary.py
98.30% <ø> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f6666...1ebcb37. Read the comment docs.


API Program to solve Mathematical Problems

Solve your Mathematical Problems in an instant with Mathjs API.

Contributed API-based Program in Python to Opensource for Hacktoberfest Submission.


Colors design tokens

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Vitamin Core theme (Light mode)
Summary 💡
Improve our color naming convention.
Rework our foundation to get ready for design token.
Examples 🌈
Material Design 2
Material Design 3
Atlassian Design
Motivation 🔦
No response
New 🆕

[x] Validated in a grooming session

Backlog 📋

[ ] Has a good summary
[ ] Has example link(s)

Design in progress 🏗

[ ] Analysis (functional & technical)
[ ] Design refinement
[ ] Dev qualification (properties, breakpoints, tokens etc.)
[ ] Documentation refinement (inside the Figma branch)

Design review 👀

[ ] Figma branch merged
[ ] Documentation review _(and move the documentation into Vitamin Documentation Figma file)

Ready to dev 👍

[ ] Issues are created in all repositories affected (vitamin-<web,android,ios,compose>)

Dev in progress 💻

[ ] All issues are resolved (to replace with issues links)

This topic has been launched in beta test.
However, its status in the board no longer reflects the current reality, so it has been moved to our "New" column.
We will keep you informed of the different advances.
Thank you.


Quotes example does not compile

I freshly installed Arduino 1.8.19 both from the flatpack repositories as directly from the Arduino website on Fedora 36 as on macOS Ventura. I added the additional board URL as explained in the documentation and choose the ESP32 Dev Module. This works fine.
When adding the Paperdink library the Arduino IDE asks if it should install all dependencies, which I accepted. During the library install I get an error. The output is from macOS but it's the same on Fedora.
no protocol:
java.lang.RuntimeException: java.net.MalformedURLException: no protocol:
at
cc.arduino.contributions.libraries.ui.LibraryManagerUI.lambda$onInstallPressed$4(LibraryManagerUI.java:250)
    at java.lang.Thread.run(Thread.java:748)
Caused by: java.net.MalformedURLException: no protocol:
    at java.net.URL.<init>(URL.java:611)
    at java.net.URL.<init>(URL.java:508)
    at java.net.URL.<init>(URL.java:457)
    at
cc.arduino.contributions.DownloadableContributionsDownloader.download(DownloadableContributionsDownloader.java:60)
    at
cc.arduino.contributions.DownloadableContributionsDownloader.download(DownloadableContributionsDownloader.java:56)
    at
cc.arduino.contributions.libraries.LibraryInstaller.performInstall(LibraryInstaller.java:148)
    at
cc.arduino.contributions.libraries.LibraryInstaller.install(LibraryInstaller.java:118)
    at
cc.arduino.contributions.libraries.ui.LibraryManagerUI.lambda$onInstallPressed$4(LibraryManagerUI.java:240)
    ... 1 more

Arduino: 1.8.19 (Mac OS X), Board: "ESP32 Dev Module, Disabled, Default 4MB with spiffs (1.2MB APP/1.5MB SPIFFS), 240MHz (WiFi/BT), QIO, 80MHz, 4MB (32Mb), 921600, None"

I am not sure if this is an indication something went wrong or just some debugging output. I restart the Arduino software to be sure and open the "Quotes" example because this seems like the simplest example and I just want to test if everything works. When I compile the sketch I get:
Multiple libraries were found for "WiFi.h"
Used: /Users/xxx/Library/Arduino15/packages/esp32/hardware/esp32/1.0.6/libraries/WiFi
Not used: /private/var/folders/wj/7dr02y8s1vx92scj6y7tknww0000gn/T/AppTranslocation/F313BE5E-D617-4A1B-9C46-1E8E29FCD9A9/d/Arduino.app/Contents/Java/libraries/WiFi
In file included from /Users/xxx/Documents/Arduino/libraries/Paperdink/src/ui/crypto/crypto.h:5:0,
   from /Users/xxx/Documents/Arduino/libraries/Paperdink/src/Paperdink.h:17,
    from /var/folders/wj/7dr02y8s1vx92scj6y7tknww0000gn/T/arduino_modified_sketch_72738/Quotes.ino:27:/Users/xxx/Documents/Arduino/libraries/Paperdink/src/ui/crypto/../../paperdink_common.h:5:25: fatal error: ArduinoJson.h: No such file or directorycompilation terminated.
exit status 1
Error compiling for board ESP32 Dev Module.

Note that it fails on the crypto.h header while I am trying to compile the "Quotes" example. I am not sure why the Paperdink.h header needs to include unrelated examples?
Maybe related, not sure, but in Arduino 2.0.3 I can find the Paperdink library but the install button does nothing. No output, nothing, even if I install the libraries dependencies manually first.
Any idea what I am doing wrong? Thank you!

I can help with your Arduino 2.0.3 issue. I just ran into that too and fixed it. See: #11

I've just tried it in the 2.x IDE and the quotes example works. Albeit with the fixed library as described in #11 and the associated pull request.

Thank you @haarts. I manually installed the Paperdink Arduino library with your fix in pull request #11 and it does indeed compile and I can write it to the Paperdink device. Success! Let's hope the pull request gets merged soon.

Pull request #11 has been merged and a new version of the Paperdink library, version 0.0.5, has been released.
I tested the Quotes example with the new version of the library on both Arduino 1.8.19 and 2.0.3 and the example compiles correctly on both versions. The "no protocol" and "multiple libraries" errors have both been resolved with the fix from #11.
This issue has been resolved.


from_raw on Script class

I think there is an error on the from_raw function on the Script class.
I discovered that the redeem script from a P2SH transaction was not given the right codes.
If I disable the CODE_OPS [OP_PUSHDATA1, OP_PUSHDATA2 and OP_PUSHDATA4] and increase the index by one on the 4c, 4d, and 4e cases on the from_raw function it works.
if not, it pushes a OP_PUSHDATAx on tne commands and doesn´t read the right amount of bytes to read.

Hi @clon19 !  I will look at it when I have some available time. In the meantime if you are willing make a pull request to fix it.

I just tried a couple of P2SH and they worked fine.
Could you give me the P2SH that caused the problem? If I can replicate it I can fix it.

try with tx 7e2aa1a680763d2bbae7fb3976c2a0995366a272c4707a3c2ea589ea843a05f1
this works for me
def from_raw(scriptraw, has_segwit=False):
"""
Imports a Script commands list from raw hexadecimal data
Attributes
----------
txinputraw : string (hex)
The hexadecimal raw string representing the Script commands
has_segwit : boolean
Is the Tx Input segwit or not
"""
#print("sr",scriptraw)
scriptraw = to_bytes(scriptraw)
commands = []
index = 0
while index < len(scriptraw):
byte = scriptraw[index]
if bytes([byte]) in CODE_OPS:
commands.append(CODE_OPS[bytes([byte])])
index = index + 1
#handle the 3 special bytes 0x4c,0x4d,0x4e if the transaction is not segwit type
elif has_segwit == False and bytes([byte]) == b'\x4c':
#print(scriptraw[index + 1])
bytes_to_read = int.from_bytes(scriptraw[index + 1:index + 2], "little")
index = index + 2
commands.append(scriptraw[index: index + bytes_to_read].hex())
index = index + bytes_to_read
elif has_segwit == False and bytes([byte]) == b'\x4d':
bytes_to_read = int.from_bytes(scriptraw[index + 1:index + 3], "little")
index = index + 3
commands.append(scriptraw[index: index + bytes_to_read].hex())
index = index + bytes_to_read
elif has_segwit == False and bytes([byte]) == b'\x4e':
bytes_to_read = int.from_bytes(scriptraw[index + 1:index + 5], "little")
index = index + 5
commands.append(scriptraw[index: index + bytes_to_read].hex())
index = index + bytes_to_read
else:
data_size, size = vi_to_int(scriptraw[index:index + 9])
commands.append(scriptraw[index + size:index + size + data_size].hex())
index = index + data_size + size
    return Script(script=commands)

I am not sure what is the problem.
In the tx you've sent  (https://www.blockchain.com/btc/tx/7e2aa1a680763d2bbae7fb3976c2a0995366a272c4707a3c2ea589ea843a05f1)
both pkscripts and the sigscript work fine with .from_raw

Closing.


Add Dark Mode Feature

Describe the Feature you want to end
Is your feature request related to a problem? Please describe.
There is no Dark mode option for this website
Describe the solution you'd like
The dark Mode feature will attract more peeps.
I will add a toggle button which will act as a theme changer from dark mode to light mode

@pranjay-poddar Please assign this issue to me so that I can contribute in GSSOC 23.

Hey @pranjay-poddar ,I would like to add Dark Mode feature.
I'm a contributor to GSSOC'23 please assign this issue to me as a part of GSSOC'23


Facebook's Website Title changes when a replacement occurs

When I visited facebook this morning, I noticed the website title had been changed to the code below. My dead name is in the title, but it shouldn't be replaced this many times and it shouldn't have styling applied to it. On commit 0ce90d0

Here's what the element view in plain text looks like, so you can see just how many times it does this (968 times)
262.txt

Another very minor issue is that the space between first and last name is removed as well as the (username) to the right of the last name


docs(mesh): adding licensing instructions

Adding licensing docs to Kong Mesh.

@lena-larionova yes, ideally the full instructions should be here, but I didn't have time to copy-paste them.

In that case - I can take care of that.


create setter by field path

i don't understand how to set a filed if i have 2 resources of the same type, eg:
i have 2 deployments, and i want to create 2 setters for each one of them, it's not clear to me how to create a setter that is bound to a specific resource, from what i understand, we can only set types?
Any help is much appreciated! Thank you!

Setters can be unique for filed and fieldValue combination. Can you walk through an example and expected behavior so that I could help.
scope creating setter references to a specified field
kpt cfg create-setter DIR/ replicas 3 --field "replicas"

@papagalu not to steal your thread here but I think we share the problem.
@phanimarupaka is this a use case supported of using kpt and kustomize.
.
├── README.md
├── base
│   ├── deployment.yaml
│   └── kustomization.yaml
├── prod
│   ├── kustomization.yaml
│   └── patch.yaml
├── dev
│   ├── kustomization.yaml
│   ├── patch.yaml
│   └── patch_init.yaml
└── qa
    ├── kustomization.yaml
    └── patch.yaml

I want to provide setters or substitutions on the kustomization.yaml or even the patch.yaml for a given environment. Say a developer wants to change their image version or maybe we run different memory limits across the environments. Being able to use kpt setter's is appealing. However, since the kpt pattern is matched by multiple files it updates them all disregarding the directory.
TL;DR: Is it possible to scope the setter to a specific resource + field?

https://github.com/kubernetes-sigs/kustomize/blob/master/cmd/config/docs/commands/set.md looks to provide what I am looking for.

This will be implemented as part of search and replace command which is being tracked here. https://github.com/GoogleContainerTools/kpt/issues/961
Marking this as a duplicate.


Class 'Facts' should have method 'put' instead or in addition to 'add'

The class "Facts" is a facade for the underlying Map methods of  get, remove and toString. While the 'add' method, usually associated with a List, invokes the 'put' method of the Map interface.
This feature request is to add a 'put' method or rename the existing 'add' method as 3.x is still under development.
The change has the impact on the Groovy Map usage so all of the following syntaxes can be used:
facts.put('thickness', 10)
facts['color'] = 'Blue'
facts.weight = 500
facts.'shape' = 'Circle'
facts << [price:150]

You are right, put is better since Facts is backed by a map.
I've added a put method in the latest v3.0.0-SNAPSHOT.
The add method has been deprecated and will be removed in the final release to avoid any confusion.

Great! Will modify the Groovy Tutorial tomorrow.


New Hugo theme

I've made a new theme for the website. What do you think?
Please tell me if there's something you want to change.
Screenshots
Home Page

Configuration Page

Light Version
There's also a light version which is chosen by the user's system prefrences

404 Page

Responsive Header

I will need some time to review all the changes but design-wise I love it! Might make sense to put in some more work into the contents before pushing this. Maybe we could even set up a seperate milestone.

@N1x0 I agree about adding some more content. The website really doesn't have much content currently.

@dalyIsaac

It is considered best practice to use rem over px. rem is essentially 16px but if you change the root's font size all the elements using rem will also change their size.
Changing the code bg color is difficult because it is hard coded into the element but I will try to change it.
The horizontal layout is suppose to mimic the tiling aspect of Workspacer. Under about 1000px of viewport width it goes back to vertical.
I will try to have the header at a fixed size.

It is considered best practice to use rem over px. rem is essentially 16px but if you change the root's font size all the elements using rem will also change their size.

👍

I changed the pre color to a lighter color than the bg. I had to use !important but it works.

Thanks, looks much better now.

The horizontal layout is suppose to mimic the tiling aspect of Workspacer. Under about 1000px of viewport width it goes back to vertical.

Makes sense. There's a couple of issues with small window sizes:

I changed the header height to 5rem.

Thanks!

We've had some stoppage in PR-processing due to a 2-review requirement. This has now been reduced to 1, so consider this merged. Sorry about the delay!


Add SD 1.4 as an option

Could we get the version as an option? It doesn't have to be a UI item, can just be a variable for us to change. Currently it's not too hard to do, but the string is hardcoded to too many places.

I'll add it soon

It'd be really nice.

Actually, what's the difference between 1.4 and 1.5 dreambooth? Is it just the model downloaded from hugging face being different?
Has there been any other change to the actual training process? (apart from changes to the learning rate and text encoder)

No, if you change the model from Huggingface everything else works fine.

No, if you change the model from Huggingface everything else works fine.

Good to know. Thanks


Swagger UI fails with Can't read from server. It may not have the appropriate access-control-origin settings.

I have an API that I implemented that exposes a swagger json.  When I attempt to hit that API with the swagger UI located at petstore.com.  It gives the subject error.  When I use my rest API tool to invoke the api I get back the following:
Request headers
Accept: application/json
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36
Accept-Encoding: gzip, deflate, sdch
Accept-Language: en-US,en;q=0.8

Response headers
X-Powered-By: Express
Content-Type: application/json; charset=utf-8
Content-Length: 4964
ETag: W/"CCtaLYI7tt5BH1+4ka3O6w=="
Date: Tue, 24 Feb 2015 22:37:14 GMT
Connection: keep-alive

{
  "swagger": "2.0",
  "info": {
    "title": "Subscription Service",
    "description": "Manages subscriptions between producers and consumers.",
    "contact": {
      "name": "Disney Web Services",
      "url": "https://confluence.disney.com/display/FND/Disney+Web+Services",
      "email"<EMAIL_ADDRESS>    },
    "schemes": [
      "http",
      "https"
    ],
    "paths": {}
  },
  "paths": {
    "/entities": {
      "get": {
        "operationId": "createEntity",
        "summary": "Create new ENTITY",
        "description": "Creates a new entity, registers the secured entity for the entity, and assigns ownership to the caller session.",
        "parameters": [
          {
            "in": "header",
            "name": "Authorization",
            "required": true,
            "type": "string",
            "description": "Must be of the form 'SESSION {token}' where {token} is the session token returned from session service."
          }
        ],
        "responses": {
          "200": {
            "description": "Successful operation",
            "schema": {
              "$ref": "#/definitions/EntityList"
            }
          },
          "401": {
            "description": "Either the authorization header is missing/badly formed, the token is not valid, or the token is expired, or session service is down.  See response body for more details."
          },
          "403": {
            "description": "A permission check failed, input was invalid, or an integrity constraint would be violated if the operation were completed.  See response body for more details."
          },
          "500": {
            "description": "An unexpected error occured or a service dependency is down.  See response body for more details."
          }
        }
      }
    }
  },
  "definitions": {
    "Entity": {
      "id": "Entity",
      "type": "object",
      "properties": {
        "_id": {
          "type": "string",
          "description": "Unique system identifier for the entity."
        },
        "name": {
          "type": "string",
          "description": "A name that IS unique that may not be so friendly.",
          "required": true
        },
        "type": {
          "type": "string",
          "enum": [
            "GUEST",
            "CAST_MEMBER",
            "APPLICATION",
            "SERVICE",
            "DEVICE"
          ],
          "required": true
        },
        "featuresProvided": {
          "type": "array",
          "items": {
            "type": "object",
            "properties": {
              "uniqueName": {
                "type": "string",
                "description": {
                  "type": "string",
                  "description": "Describes what the feature is or does."
                },
                "onboardingLink": {
                  "type": "string",
                  "description": "The link for onboarding onto this feature.",
                  "format": "url"
                },
                "subscriptionMetadataSchema": {
                  "type": "object",
                  "description": "The json schema of the subscription metadata for the feature."
                }
              }
            }
          }
        }
      }
    },
    "EntityList": {
      "id": "EntityList",
      "type": "array",
      "items": {
        "id": "Entity",
        "type": "object",
        "properties": {
          "_id": {
            "type": "string",
            "description": "Unique system identifier for the entity."
          },
          "name": {
            "type": "string",
            "description": "A name that IS unique that may not be so friendly.",
            "required": true
          },
          "type": {
            "type": "string",
            "enum": [
              "GUEST",
              "CAST_MEMBER",
              "APPLICATION",
              "SERVICE",
              "DEVICE"
            ],
            "required": true
          },
          "featuresProvided": {
            "type": "array",
            "items": {
              "type": "object",
              "properties": {
                "uniqueName": {
                  "type": "string",
                  "description": {
                    "type": "string",
                    "description": "Describes what the feature is or does."
                  },
                  "onboardingLink": {
                    "type": "string",
                    "description": "The link for onboarding onto this feature.",
                    "format": "url"
                  },
                  "subscriptionMetadataSchema": {
                    "type": "object",
                    "description": "The json schema of the subscription metadata for the feature."
                  }
                }
              }
            }
          }
        }
      }
    },
    "SecuredEntityForEntitySchema": {
      "id": "SecuredEntityForEntity",
      "type": "object",
      "properties": {
        "domain": {
          "type": "string",
          "description": "Ace domain name"
        },
        "containerId": {
          "type": "string",
          "description": "Ace container for Entities in domain.",
          "default": "Entities"
        },
        "instanceId": {
          "type": "string",
          "description": "Name of the ENTITY"
        },
        "type": {
          "type": "string",
          "description": "Secured entity type",
          "default": "ENTITY"
        },
        "listingData": {
          "type": "object",
          "properties": {
            "name": {
              "type": "string",
              "description": "Name of the ENTITY, (matches instanceId)"
            },
            "description": {
              "type": "string",
              "description": "A creator specified description for the entity"
            },
            "contactEmail": {
              "type": "string",
              "format": "email",
              "description": "Email to contact regarding this entity"
            },
            "type": {
              "type": "string",
              "description": "Entity type",
              "enum": [
                "GUEST",
                "CAST_MEMBER",
                "APPLICATION",
                "SERVICE",
                "DEVICE"
              ]
            },
            "featureNames": {
              "type": "array",
              "description": "Names of features this entity provides.",
              "items": {
                "type": "string"
              }
            }
          }
        }
      }
    },
    "SecuredEntityForEntityList": {
      "id": "SecuredEntityForEntityList",
      "type": "array",
      "items": {
        "id": "SecuredEntityForEntity",
        "type": "object",
        "properties": {
          "domain": {
            "type": "string",
            "description": "Ace domain name"
          },
          "containerId": {
            "type": "string",
            "description": "Ace container for Entities in domain.",
            "default": "Entities"
          },
          "instanceId": {
            "type": "string",
            "description": "Name of the ENTITY"
          },
          "type": {
            "type": "string",
            "description": "Secured entity type",
            "default": "ENTITY"
          },
          "listingData": {
            "type": "object",
            "properties": {
              "name": {
                "type": "string",
                "description": "Name of the ENTITY, (matches instanceId)"
              },
              "description": {
                "type": "string",
                "description": "A creator specified description for the entity"
              },
              "contactEmail": {
                "type": "string",
                "format": "email",
                "description": "Email to contact regarding this entity"
              },
              "type": {
                "type": "string",
                "description": "Entity type",
                "enum": [
                  "GUEST",
                  "CAST_MEMBER",
                  "APPLICATION",
                  "SERVICE",
                  "DEVICE"
                ]
              },
              "featureNames": {
                "type": "array",
                "description": "Names of features this entity provides.",
                "items": {
                  "type": "string"
                }
              }
            }
          }
        }
      }
    }
  }
}

so the whole swagger spec is in the response payload?  I'm not sure I understand the issue.

The issue was apparently one of not having the response to the request provide all of the needed CORS headers.


Fix a super-old weird bug in sq_get_distance_computer_avx512()

Seems like a typo that exists from the VERY FIRST commit ad7c219e0bc74645e502d75470e0dbd1f0493882

This is a typo error since we start supporting avx512 (https://github.com/milvus-io/milvus/pull/1195)
Thanks a lot to dig it out

/lgtm
/approve

issue: # https://github.com/zilliztech/knowhere/issues/713

issue: #713

/kind bug


Windows Versions

Where will i be able to find the compiled windows version?

https://github.com/ahodesuka/ahoviewer/releases


[Bug] Js editor: WhenJS is associated with the widget or function we should display an error

Steps to reproduce:

Add a Js Function1
Bind the function1  into a widget or another Js itself
Navigate to Entity explorer and delete the function1
and observe

Observation :
The function1 get deleted with an info/error message
Expectation:
User must be displayed with an info message stating the function is associated with another widget

As per discussion with @ApekshaBhosale closing the issue


Can't load mods alongside Seamless Co-op

I currently have Elden Ring setup to use er-patcher for ultrawide and to launch the Seamless Co-op exe, I also have this fork of ModEngine2 and Elden Mod Loader properly installed and working, there's only 1 other mod, Ultrawide UI Fixes inside the mod folder.
The issue is that to launch Seamless Co-op with er-patcher I need to edit modengine.toml and put ersc.dll inside the brackets of external_dlls, but doing so makes mods in the mod folder stop working.
Even if I launch the game normally, without Seamless Co-op, but keeping ersc.dll inside modengine.toml, the UI Fix mod I have in there also doesn't load, it only starts working when I remove ersc.dll from modengine.toml, but then Seamless Co-op doesn't launch at all.
Also, it needs to be exactly external_dlls = [ ersc.dll ], if I put ersc.dll between quotes, like external_dlls = [ "ersc.dll" ], it will not launch SeamlessCoop. I don't know why, but I thought I'd mention that too.

Thanks to your question I got it to launch from the seamlesscoop exe file,  'external_dlls = ["SeamlessCoop\ersc.dll"]' with the launch config 'WINEDLLOVERRIDES="dinput8.dll=n,b" %command%' works for me, I will try now to add another mod on top of the coop, apparently is important to use backward slash for the folder name, it didn't worked with forward slash

@Lunatik00 I'm glad it helped you launch the mod. Have you tested with other mods to confirm if this issue also happens to you?