Using an Organization vs a User account

It seems like you created a GitHub user to hold this repository (and possibly related ones in the future).
From https://docs.github.com/en/get-started/learning-about-github/types-of-github-accounts:

Tip: Personal accounts are intended for humans, but you can create accounts to automate activity on GitHub. This type of account is called a machine user. For example, you can create a machine user account to automate continuous integration (CI) workflows.

GitHub has a feature designed to group repositories together without being attached to a single user: an Organization. GitHub recommends as best practice to instead have a GitHub user for your person, and then group related community repositories under an organization that you manage.
From https://docs.github.com/en/organizations/collaborating-with-groups-in-organizations/about-organizations:

Your team can collaborate on GitHub by using an organization account. Each person that uses GitHub signs into a user account. Multiple user accounts can collaborate on shared projects by joining the same organization account, which owns the repositories. A subset of these user accounts can be given the role of organization owner, which allows those people to granularly manage access to the organization's resources using sophisticated security and administrative features.

It is possible to convert an existing GitHub user into an organization here: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-github-user-account/managing-user-account-settings/converting-a-user-into-an-organization
I recommend doing this with @openglonmetal and then creating or using existing personal accounts for individuals contributing to the project.

Ok sounds good

Done, if you want to be added to the list of contributors just give me a heads up.


Attribution

It would be nice to have a NOTICE file in the repo and in releases that is easy to find and that gives proper thanks to work that was used to build the template. At least we should thank the teams behind:

Fira Code
HanziWriter

The NOTICE file should be automatically generated.
For Anki we mainly used their documentation and their code is not used directly, but still they deserve our utmost gratitude.

It would also be cool to have a button in the template itself that shows the NOTICE file, so that you can see it even if you only download a pre-packaged apkg

We have the NOTICE file and also in release builds.
What's missing is some way to expose this right within the anki package.


python310Packages.life360: 5.4.1 -> 5.5.0

Diff: https://github.com/pnbruckner/life360/compare/refs/tags/v5.4.1...v5.5.0
Changelog: https://github.com/pnbruckner/life360/releases/tag/v5.5.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 209346 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.life360
python310Packages.life360
python39Packages.life360


Fields can have periods in their names when back quoted .

We blow up when there are . in field names because internally split on . to seperate fields.  We might want to convert all field references to arrays.  @mtoy-googly-moogly lets discuss when you are a back.

Interesting ... yup
Yeah every place we accept a string to name a field it should be a FieldReference type and it should be an array because the parser will have parsed it out properly and that needs to be preserved. That's going to be a few places though FieldFragment and FieldRef off the top of my head. Shouldn't be that hard, typescript will save us.


Virus Total IP Enrichment Playbook - 403 Forbidden Error

The Playbook Status is "Failed" and getting stuck in “For each” – “Condition” – “True” – “Output” – “Status Code: 403”
Sample Message Body:
{
"StatusCode": "Forbidden",
"ReasonPhrase": "Forbidden",
"Content": "{"error":{"code":"AuthorizationFailed","message":"The client 'XXXXXX' with object id 'XXXXXX’ does not have authorization to perform action 'Microsoft.SecurityInsights/incidents/comments/write' over scope '/subscriptions/XXXXX/resourceGroups/brev-sandbox-sentinel/providers/Microsoft.OperationalInsights/workspaces/brev-sandbox-loganalytics/providers/Microsoft.SecurityInsights/incidents/XXXXX/comments/XXXX' or the scope is invalid. If access was recently granted, please refresh your credentials."}}",
"Headers": {
"Pragma": [
"no-cache"
],
"x-ms-failure-cause": [
"gateway"
],
"x-ms-request-id": [
"XXXX"
],
"x-ms-correlation-request-id": [
"XXXX"
],
"x-ms-routing-request-id": [
"XXXX
],
"Strict-Transport-Security": [
"max-age=31536000; includeSubDomains"
],
"X-Content-Type-Options": [
"nosniff"
],
"Connection": [
"close"
],
"Cache-Control": [
"no-cache"
],
"Date": [
"Thu, 31 Mar 2022 21:49:20 GMT"
],
"Content-Length": [
"655"
],
"Content-Type": [
"application/json; charset=utf-8"
],
"Expires": [
"-1"
]
},
"debugInfo": "clientRequestId: XXXXX"
}
Configured a Custom Role with the specific write permissions and assigned at the Sentinel Resource Group level (Scoped to this Logic App only) but still having issues.
The Connector we are using under “Condition – True – Add comment to incident (V3)” is a service principal account. Considering the least privileged principle how can we fix the error and where should the custom role to be assigned? Thanks

Hi @Gary-S-ingh , did you try to assign Microsoft Sentinel Responder role? Responder role can write a comment in Sentinel. We would suggest using system assigned Managed Identity so that only that specific playbook has a permission.

Hello, @BenjiSec Good day. Considering the least privilege principle I created a custom role with the specific permission “Microsoft.SecurityInsights/incidents/comments – Write: Create Incident Comments” scoped at RG level and then assigned to the service account used in the Logic App Connector and that fixed the issue yesterday.
Is it best practice to use system assigned role i.e.Microsoft Sentinel Responder role instead of the custom role I’ve created? I can try assigning the default Responder Role to that Service Account and see if that works
Many thanks

Hi @Gary-S-ingh , did you try to assign Microsoft Sentinel Responder role? Responder role can write a comment in Sentinel. We would suggest using system assigned Managed Identity so that only that specific playbook has a permission.

Hi Gary, did you have to assign the role to the Resource Group where the App lives?


[question] its possible to adjust the color of 	show_current_context = true ?

as you can see

the current context indent line color is green. can i change this color?
or its just based on the theme?

that would be
:hi IndentBlanklineContextChar

it can be defined by a theme if set, however, you can also simply override it using
vim.cmd[[highlight IndentBlanklineIndent1 guifg=#COLOR]]

P.S: You can have it more accurately highlight the correct context by setting context_patterns option in your configuration

Thanks @amazingefren
That is all correct.
Just one small addition, you should add gui=nocombine to the highlight group, or the character inherits things like italic if the surrounding code is a comment etc.
vim.cmd[[highlight IndentBlanklineIndent1 guifg=#COLOR gui=nocombine]]

@lukas-reineke updated previous comment with correct highlight group! accidentally used the example with the wrong highlight group

if you used: highlight IndentBlanklineIndent1 guifg=#COLOR gui=nocombine
there is a typo (incorrect highlight group)
if you used guifg=#COLOR you hadn't actually assigned a color to it
try:
vim.cmd[[highlight IndentBlanklineContextChar guifg=#ff0000 gui=nocombine]]

in which #ff0000 is HEX for red

works now. thanks.
also, please take a look at that demo.

also.

here that function is inside a class. the plugin highlighted correctly. but when moving around in that function to the location of if and inside if, the highlight doesnt work, its not applied

look where my cursor is. inside that if, the indent line just near the if should be highlithed.
now i came to conclusion that this plugin only takes into consideration the defs and classes for current context highlighting.

@alexzanderr
that is because you have to define context_patterns, it should be a array of strings
for example:
require('indent_blankline').setup {
  -- ... your config
  context_patterns = {
    "def",
    "class",
    "return",
    "function",
    "method",
    "^if",
    "^while",
    "jsx_element",
    "^for",
    -- ... and you can add more
  }
}

now it works.

but wait a second.
do you notice that there is long line between pass and x = 3, is it normal?
i guess only the indent line under the second for is respecting format, but the above one is not right.
is there a way to delete that extra line? or to specify a level of indentation? or to ignore that extra space between lines?

btw. please update readme with these
  context_patterns = {
    "def",
    "class",
    "return",
    "function",
    "method",
    "^if",
    "^while",
    "jsx_element",
    "^for",
    -- ... and you can add more
  }

and if there is more configuration ... please update readme.

@alexzanderr
as for the extra indentline appearing, I don't believe that is this plugins fault.
The plugin is working as intended and creating a indentline where (treesitter?) is saying there should be an indent there.
You can test this, if you go to your line with pass and hit o, it will create a new line indented over when it shouldn't, as for a fix i'm not exactly sure.
for the context_patterns configuration, it is not defined by the plugin solely, it should be defined by treesitter so all available configuration options should be with its parser
example: javascript

@alexzanderr
Python -------------
https://user-images.githubusercontent.com/48777455/134237295-0cb97acb-56ba-4582-bdec-dcb08a04d9c2.mp4
Typescript ---------
https://user-images.githubusercontent.com/48777455/134237313-58ce1476-2674-4c0c-b735-115f85a247f2.mp4
Check out how hitting o (create a new line) automatically is automatically indenting over when it shouldn't? be
When this plugin is notified that there is a indentation, it will place it (as it should be doing).
Compare that to the typescript example above in which the line only appears before I define x (when let x= before 10 is added) but then proceeds to properly indent after declaration to the correct indent level

i see yours its working fine with the above lines

@alexzanderr
Python -------------
python_demo.mp4
Typescript ---------
typescript_demo.mp4
Check out how hitting o (create a new line) automatically is automatically indenting over when it shouldn't? be
When this plugin is notified that there is a indentation, it will place it (as it should be doing).
Compare that to the typescript example above in which the line only appears before I define x (when let x= before 10 is added) but then proceeds to properly indent after declaration to the correct indent level

i dont know what to say to this...
so its tree-sitter's fault?

@alexzanderr I think what you want is show_trailing_blankline_indent = false. That option defaults to true and will do what it says, add an additional indent guide to blank lines.

@alexzanderr
I don't know exactly what the fault is, what I do know is that when you see the extra indent line, that is because something ( i was assuming treesitter ) was essentially telling this plugin that there will be an indentation level there.
https://user-images.githubusercontent.com/48777455/134240284-1ae2a0ed-04b0-4f1a-92d5-cb37d512eef5.mp4

@alexzanderr @amazingefren
Tested this myself now and it is exactly what I said above. It's an option of this plugin.
let g:indent_blankline_show_trailing_blankline_indent = v:true:

let g:indent_blankline_show_trailing_blankline_indent = v:false:

@Daxtorim
the video above is with show_trailing_blankline_indent = false
without changing my configuration at all if I copy your example code it looks exactly the same, the issue is partly unrelated

the lines he is seeing are not trailing lines, they are showing the indentation level

show_trailing_blankline_indent = false

wow. now its so perfect

thank you so much man.

@alexzanderr @amazingefren
Tested this myself now and it is exactly what I said above. It's an option of this plugin.
let g:indent_blankline_show_trailing_blankline_indent = v:true:

let g:indent_blankline_show_trailing_blankline_indent = v:false:

@amazingefren @Daxtorim i really like that you copied my stupid template code format with:
def some_function():
   "asdasd"

i really laughed!!

@alexzanderr
wait am I tripping balls or did my indentation level mask your trailing lines, can do me a favor and upload a screen shot of the new config with this code? \/

haha, omg you make me laugh.
here is the photo:

this is how it should look like (it already looks like this, its perfect)

@lukas-reineke do you have discord?

holy shit it was, I don't know what was causing mine to parse an extra indentation level (making it look exactly like yours)  while yours were actually trailing lines (which I had already disabled)
it had completely misinterpreted it as indentation lines rather than trailing lines so my bad

however I am currently transitioning to dvorak

why ?
you didnt answer my question: do you have discord? we can talk there.

didn't realize you mean to tag me
I don't use discord frequently but you can add me efrentheroker#1273
Also, close this thread if your issue has been resolved

done. thanks

Thanks for the help @amazingefren  and @Daxtorim :heart:
To clear up some confusion, I call the last indent of a blank line the trailing indent.
And you can turn this one on or off, because people have different preferences here.
This is unrelated to treesitter, works the same if you don't have treesitter enabled.
Should look just like https://github.com/lukas-reineke/indent-blankline.nvim/issues/223#issuecomment-924351878
But as you can see in that screenshot as well, treesitter sometimes gets the indentation wrong and adds more than there should be.
I myself have treesitter turned off for this. The other implementation does not make these mistakes, it always looks good (but is not always semantically correct)

do you have discord?

No, just twitter and reddit. If you want to chat either is fine.

lets chat then


Yabai + Arc spaces switching

When I switch from space with Arc browser to the first space (Desktop 1), I can see in MacOS native status-bar that focus did change to the window that is on the first space, but then immediately focus changes back to Arc while space is opened. Command that I'm using to switch between spaces is next:
yabai -m space --focus 1 || yabai -m space --focus recent; sketchybar --trigger window_focus
The issue persists regardless if I'm using skhd or execute command directly from terminal.
Here is a little screen recording of the issue:
https://github.com/koekeishiya/yabai/assets/40265576/14219452-1efb-44cf-b5b4-8df74b2f2ffd
I have to mention that this issue does persist only when switching from any space with Arc in focus to first space. The application that is launched in first space does not matter, focus does not switch to neither kitty nor telegram nor spotify. No errors were printed when trying to switch spaces from terminal as well as no errors in yabai log file. yabai version is yabai-v7.1.0.

Also happens to me when but I'm using Microsoft Edge.
MS Edge is in Space 1 and if I switch to an empty Space (3), it goes back to Space 1. But if I switch back again, the problem doesn't occur

So I know this was 3 weeks ago, but this issue might be because of Arc and not yabai. I say this because I haven't even installed yabai yet and the focus will sometimes switch to the main Arc window when a little Arc is opened (e.g. from a link in an email), or the focus will stay on the main Arc window and I have to manually swipe to another space in order to see the little Arc window.
I will say though I mainly have Arc fullscreen, so it could still be yabai, but I'm not sure.

So I know this was 3 weeks ago, but this issue might be because of Arc and not yabai.

Well this is exactly what I said in the issue. But I have to admit, I've recently switched to amethyst, so spaces switching there are handled via macos native hotkeys, and this issue no longer persists. So it must be yabai problems and not Arc, at least in my case.

I also have the same problem and I don't even use Arc, so it's definitely something in Yabai or some MacOS config that's conflicting with Yabai 🤔


flutter: Authentication failed -ERROR: Invalid token.. Try again later.

 flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.5.2, on macOS 11.6 20G165 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.2)
[✓] VS Code (version 1.61.1)
[✓] Connected device (3 available)

• No issues found!

Issue when trying to send verification code for my flutter project.

 error
2021-10-20 17:46:35.957381+0800 Runner[9662:2013008] flutter: Authentication failed -ERROR: Invalid token.. Try again later.
2021-10-20 17:46:54.804721+0800 Runner[9662:2013414] [] __nwlog_err_simulate_crash simulate crash already simulated "nw_hash_table_apply called with null table"
2021-10-20 17:46:54.805218+0800 Runner[9662:2013414] [] nw_hash_table_apply called with null table, dumping backtrace:
        [arm64] libnetcore-2736.12.1
    0   libnetwork.dylib                    0x00000001842299c0 __nw_create_backtrace_string + 120
    1   libnetwork.dylib                    0x00000001839a387c nw_hash_table_apply + 2808
    2   libnetwork.dylib                    0x0000000183f2b1e4 D810C689-1339-3FC6-96E8-196B9901E4DC + 6300132
    3   libnetwork.dylib                    0x0000000183f28cc0 D810C689-1339-3FC6-96E8-196B9901E4DC + 6290624
    4   CFNetwork                           0x00000001836d4ff4 _CFURLStorageSessionCopyIdentifier + 20652
    5   libnetwork.dylib                    0x0000000183ac8da4 D810C689-1339-3FC6-96E8-196B9901E4DC + 1703332
    6   libdispatch.dylib                   0x00000001059b8a20 _dispatch_call_block_and_release + 32
    7   libdispatch.dylib                   0x00000001059ba700 _dispatch_client_callout + 20
    8   libdispatch.dylib                   0x00000001059c4e34 _dispatch_workloop_invoke + 2960
    9   libdispatch.dylib                   0x00000001059cffa0 _dispatch_workloop_worker_thread + 916
    10  libsystem_pthread.dylib             0x00000001f28251b0 _pthread_wqthread + 288
    11  libsystem_pthread.dylib             0x00000001f2824f50 start_wqthread + 8

Hi @yendiscart, thanks for filing the issue.
Please provide a complete minimal reproducible code sample and your pubspec.yaml.
Thank you

pubspec.yaml.
name: app #changing it will force you to change appname in import statement inside every .dart file.
description: Chats & Calling app
version: 1.0.32+33
environment:
sdk: ">=2.12.0 <3.0.0"
dependencies:
google_mobile_ads: ^0.13.5
font_awesome_flutter: ^9.1.0
sms_autofill: ^2.1.2
receive_sharing_intent: ^1.4.5
firebase_crashlytics: ^2.2.1
async: ^2.8.1
emoji_picker_flutter: ^1.0.7
flutter_video_info: ^1.2.0
group_button: ^3.1.0
flutter_colorpicker: ^0.6.0
story_view: ^0.13.1
devicelocale: ^0.4.2
cloud_functions: ^3.0.3
http_auth: ^1.0.1
cloud_firestore: ^2.5.2
flutter_cached_pdfview: ^0.4.0-nullsafety
fluttertoast: ^8.0.8
firebase_messaging: ^10.0.7
dio: ^4.0.0
cached_network_image: ^3.1.0
firebase_storage: ^10.0.3
device_info: ^2.0.2
file_picker: ^4.0.2
flutter_image_compress: ^1.1.0
path_provider: ^2.0.3
path: ^1.8.0
flutter_sound: ^8.3.12
percent_indicator: ^3.0.1
string_validator: ^0.3.0
ntp: ^2.0.0
random_string: ^2.3.1
flutter_native_timezone: ^2.0.0
intl: ^0.17.0
connectivity: ^3.0.6
data_connection_checker_tv: ^0.3.5-nullsafety
http: ^0.13.3
provider: ^6.0.0
firebase_auth: ^3.1.1
html: ^0.15.0
image_picker: ^0.8.4+2
universal_platform: ^1.0.0+1
flutter_linkify: ^5.0.2
dotted_border: ^2.0.0+1
url_launcher: ^6.0.10
diacritic: ^0.1.3
image_cropper: ^1.4.1
contacts_service: ^0.6.1
share: ^2.0.4
scoped_model: ^2.0.0-nullsafety.0
local_auth: ^1.1.7
crypto: ^3.0.1
encrypt: ^5.0.1
localstorage: ^4.0.0+1
photo_view: ^0.12.0
mime: ^1.0.0
launch_review: ^3.0.1
overlay_support: ^1.2.1
jiffy: ^4.1.0
geolocator: ^7.6.0
video_player: ^2.2.0
video_thumbnail: ^0.4.3
chewie: ^1.2.2
media_info: ^0.8.0
firebase_core: ^1.6.0
shared_preferences: ^2.0.7
permission_handler: ^8.1.6
agora_rtc_engine: ^4.0.6
translator: ^0.1.7
audioplayers: ^0.20.1
flutter_local_notifications: ^8.2.0
flutter_secure_storage: ^4.2.1
package_info: ^2.0.2
flutter_link_previewer: ^2.5.2
giphy_get: ^2.0.3
wakelock: ^0.5.6
flutter:
sdk: flutter
flutter_localizations:
sdk: flutter
The following adds the Cupertino Icons font to your application.
Use with the CupertinoIcons class for iOS style icons.
cupertino_icons: ^1.0.3
collection: ^1.15.0-nullsafety.4
dependency_overrides:
provider: ^6.0.0 # for chewie 1.2.2
dev_dependencies:
flutter_test:
sdk: flutter
mockito: ^5.0.15
flutter_driver:
sdk: flutter
test: ^1.16.8
flutter_launcher_icons: ^0.9.2
flutter_icons:
android: "ic_launcher"
ios: true
image_path: "assets/appicon/appicon.jpg"
flutter:
uses-material-design: true
To add assets to your application, add an assets section, like this:
assets:
- assets/images/mapview.jpg
- assets/images/background.png
- assets/images/applogo.png
- assets/images/splash.jpeg
- assets/images/img_not_available.jpeg
- assets/sounds/popsound.mp3
- assets/sounds/callingtone.mp3
- assets/sounds/ringtone.mp3
- assets/sounds/whistle.mp3
- assets/flags/
- lib/Services/localization/json_languages/


Allow customized parameter boundaries for utils.fit_circuit_parameters

Currently, the fit_circuit_parameters function in AutoEIS doesn't allow for customized parameter boundaries. Would be helpful to allow user-defined boundaries for different kinds of circuit elements.

Duplicate #119


[main] Upgrade to latest dependencies

release -dprotaso
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing-redis 4cb7a31...96c568e:
  > 96c568e fix verify codegen (# 366)
  > d0a5fe5 upgrade to latest dependencies (# 365)
  > 64cb1f1 upgrade to latest dependencies (# 364)
bumping knative.dev/eventing-kafka 1a86afb...394f005:
  > 394f005 upgrade to latest dependencies (# 1236)
  > 38f3576 upgrade to latest dependencies (# 1235)
bumping knative.dev/eventing cc06bab...a9151b5:
  > a9151b5 upgrade to latest dependencies (# 6495)
  > 291e961 upgrade to latest dependencies (# 6493)

/lgtm
/approve


Removed Dartcraft Configuration

Dartcraft's last update was for Minecraft 1.6; it has not updated since, and it makes no sense for its oregen configuration to be in a Minecraft 1.7.10 mod.  So, let's just drop the configuration.

Note: All the biome set stuff has been removed; I have several classes of biome with their temperature and rainfall values ready to go, but that will happen once we can use unions, intersections, and differences with biome sets.


Ensure data returned from Intl Enumeration is consistent with data supported by Intl objects

(I remember discussing this before, but I can't find an issue for it)
We should make sure that the lists returned from Intl Enumeration is required by the spec to be the same as the lists of what Intl objects support.  For example, Intl.DateTimeFormat should support the calendar systems returned by Intl.supportedValuesOf("calendar"), no more, no less.

We just have to make sure we don't require to have data which isn't present. For example Intl.NumberFormat accepts any currency and if the currency isn't known, it simply defaults to outputting the currency code:
js> print(new Intl.NumberFormat("en", {style: "currency", currency: "ZZZ"}).format(1))
ZZZ 1.00

whereas Intl.DisplayNames is required to detect and handle unknown currencies. (This example only works with JSC and SM, because V8 doesn't yet support the fallback option for the "currency" type.)
js> print(new Intl.DisplayNames("en", {type: "currency", fallback: "none"}).of("ZZZ"))
undefined

And some currencies are even only supported for certain locales:
js> print(new Intl.DisplayNames("en", {type: "currency", fallback: "none"}).of("UYW"))
Uruguayan Nominal Wage Index Unit
js> print(new Intl.DisplayNames("de", {type: "currency", fallback: "none"}).of("UYW"))
undefined

any suggestion of how to phrase that in the spec text?

Maybe using a host hook as the source of truth for viable values for both enumeration and also other relevant APIs, and requiring the host hook always return the same values across calls?

Any suggestion of how to add such mandate into the spec text?

A normative note that says so, like https://tc39.es/ecma262/#sec-hostimportmoduledynamically has ("it must always do so for subsequent calls.").


JPEG image not handled.

The above image can't be added to a document despite being an apparently valid jpeg.
from docx import Document

doc = Document(None)
with open('error.jpg', 'rb') as f:
    doc.add_picture(f)

This raises docx.image.exceptions.UnrecognizedImageError.  Apparently it doesn't match any existing header format listed in SIGNATURES.

This was tested on python-docx 1.1.2

Just to understand: Which device did you use to take this photo? Did you edited/converted it with some software or sent compressed via some IM chat?
The image is a plain JPG but it's missing all the Exif information inside of it.


ISPN-8227 OptimisticTxPartitionAndMergeDuringPrepareTest.testPrimaryOwnerIsolatedPartition fails randomly

https://issues.jboss.org/browse/ISPN-8227

Its counterpart (duringCommit) failed at least once in CI: http://ci.infinispan.org/job/Infinispan/job/PR-5408/10/testReport/junit/org.infinispan.partitionhandling/OptimisticTxPartitionAndMergeDuringCommitTest/testOriginatorIsolatedPartitionWithDiscard_DIST_SYNC_/
Can the fix be applied to both ?

@tristantarrant Should be, IMO... I'll try to reproduce it locally.

Hmm, the original test failed every now and then on my machine, but I can't get the failure from CI.

aren't you hitting https://issues.jboss.org/browse/ISPN-8232? it is going to require some work...

@pruivo That might be the cause for the other failure; here I've identified a race in data structures access and I am fixing that one.

@danberindei Added those toString()s.

Localized the exceptions.

Merged, thanks


Difference from original code

HI
very nice implemented cyclegan
I have a few questions...

What does "Resize Convolution" mean?
I wonder what is different from the original code of the author.

Thank you for your questions.

About Resize Convolution you can refer to link https://distill.pub/2016/deconv-checkerboard/. It is used to remove checkerboard artifacts which commonly occur in images generated by deconvolution.
In fact, the main goal is to study and re-implement in Tensotlayer ( framework difference).  And then add some tricks to improve the quality of output images. (1. Each group in datasets has just more than 1000 images, by enlarging dataset using data augmentation maybe we can obtain better results; 2.  The original paper mentioned the BatchNorm in the architecture of networks and when I refer to implementation in GitHub, most implementation updates to the InstanceNorm, and actually InstanceNorm may perform better in style transfer to some extent; 3. Some checkerboard artifacts in output images can be removed by replacing deconv with resize-conv in decoder part.  )

If you look at main.py, you used model_upsampling.py. Is this resize_conv you say?
If so, will it be the same as the original cyclegan if I use model_deconv.py?

resize cov = upsampling + conv

@zsdonghao  hello，tensorlayer‘s author. resize conv is just as unet's done?

@Zxr1314 check this https://distill.pub/2016/deconv-checkerboard/

@zsdonghao thank u very much，a detailed explanation for deconv

@zsdonghao effect of resize-conv is really useful for GAN，thanks again！


image_test: catch metadata script runner failure

Stop the test if we detect an error from the google_metadata_script_runner

/ok-to-test


Move the chum repository to the "user" section which allows it to be disabled on os upgrade

Ive tested the following scenarios:
Old package upgrade with new
New package upgraded
Package removed
all appear to be ok... thats the reason for the posttrans script ... with the AR in post and the RR in postun, you actually end up with no repo on upgrade because the postun for the removed package runs after the post of the installing package

@piggz, looks good! I'll merge it and let us test it in "production" through :chum:testing


In the case of iOS rolling, the text appears in the text

Steps to reproduce
I used the EasyRefresh plug -in to refresh.
The component is covered with CustomScrollView.
Discovery in Russian environment or English environment.
The text show afterimage in IOS
Expected results
Under normal circumstances, it should be normal
Actual results
The text show afterimage in IOS
Code sample
Code sample
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: BrnAppBar(
          automaticallyImplyLeading: false,
          brightness: Brightness.light,
          title: Text('message'),
          titleAlignment: Alignment.center,
        ),
        body: EasyRefresh(
          clipBehavior: Clip.none,
          controller: controller.refreshController,
          onRefresh: () async {
            await Future.delayed(const Duration(seconds: 2));
            controller.refreshController.finishRefresh();
            controller.refreshController.resetFooter();
          },
          onLoad: () async {
            await Future.delayed(const Duration(seconds: 2));
            controller.refreshController.finishLoad(IndicatorResult.noMore);
          },
          child: CustomScrollView(
            slivers: [
              const HeaderLocator.sliver(),
              SliverList(
                delegate: SliverChildListDelegate([
                 Center(
                    child: SizedBox(
                      height: Get.height / 3 * 2,
                      child: Column(
                        mainAxisAlignment: MainAxisAlignment.center,
                        children: [
                          Image.asset(
                            'images/no_message_bg.png',
                            width: 148,
                            height: 78,
                          ),
                          SizedBox(height: 16),
                          Text(
                            'Нет уведомления об устройстве',
                            style: TextStyle(
                              color: Color.fromRGBO(150, 154, 157, 1),
                              fontSize: 14,
                            ),
                          )
                        ],
                      ),
                    ),
                  ),
                ]),
              ),
              const FooterLocator.sliver(),
            ],
          ),
        ),
    );
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

https://github.com/flutter/flutter/assets/43984550/6d6f55d2-9a65-4a52-a099-2061898e93f0
Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.12, on macOS 12.7.1 21G920 darwin-x64, locale zh-Hans-CN)
Checking Android licenses is taking an unexpectedly long time...[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

I see an issue #108590 but the problem still exists

Thanks for filing this @DaYang816.
I see you are on an older version of Flutter, can you upgrade to the latest versions of flutter to see if this issue still persists?
Also, EasyRefresh is a third-part package, can you try with a CircularProgressIndicator or similar widget to see if this issue still occurs with them?

I have a project using SDK 3.13.9. After transplanting the above code, I found that it can be displayed normally.
But the upgraded version will bring code iteration, it takes a lot of time, please tell me to repair the lowest version number of this bug?

Thanks for your response.
Not sure I understand what you mean by this

please tell me to repair the lowest version number of this bug?

But per triage policy, since it is working on the newer versions of Flutter, I'll be closing this as fixed, if you disagree, please write in the comments and I'll reopen this.
Thank you!


[main] Update community files

Cron -knative-prow-robot
Produced by: knative-sandbox/knobots/actions/update-community
Details:

/retest

this will need to be regenerated


Add option to exclude optional fields

I encountered a scenario in my project where email needs to be an optional field, because some users do not have an email.
This causes a problem because django-shibboleth-remoteuser passes None as the value for 'email' to User.objects.get_or_create.  If an email key is not provided at all, Django defaults to the empty string for the value of email.
The workaround I came up with was an (awkwardly long) attribute in the settings to pop keys that are None, instead of passing the None to the ORM.  Note, any required fields that are missing will still throw an error.
SHIBBOLETH_ATTRIBUTE_EXCLUDE_ABSENT_OPTIONAL_FIELD = True
The default is False, which maintains existing functionality.

Yes, @bcail that simplified solution works for my use case.  However, I'm hesitant to assume my preference is the norm.
The intent of the new config option was to maintain the existing functionality for existing users.  If you think my desired state (i.e. your example above) should be the only available solution, or if you prefer the default setting be reversed, I'm happy to make those changes.

@bcail I updated to include your suggestion.  Let me know if you have any additional thoughts or concerns.

@m3brown thanks. Merging.


Add Brick Breaker game

Fix #390 , Add Brick Breaker Game.

there is a conflict resolve it

@iamrahulmahato , This branch has no conflicts with the base branch.

@iamrahulmahato , This branch has no conflicts with the base branch.


Account creation when the network is slow

Problem
If the network is slow, the account creation might get stuck saying username is taken after the user clicks the create account button, which is caused by an timeout error from rpc. However, at this point the account might have been already created on the network, which means that the user cannot create the same account again if they retry.
Expected Behavior
There should be some way to inform the user about the timeout error and then allow them to do some manual refresh of the page (or some better way) so that they can proceed with the same account id.
Steps to reproduce

Try to create an account on https://wallet.tatooine.nearprotocol.com
Observe that it says Username taken after the create account button is clicked. However, from near-shell near state <account_id> shows that the account exists.

Still occurring.  Can't login for stakewars staking because of the username taken already bug.  I'm wondering exactly where there recovery phrase is provided also.


Support raw SQL files

In my standard use case, I have no need for rollback and no need for peewee's abstractions, really, but I would like to keep that as an option. To reduce boilerplate ever so slightly, I would like to load raw .sql files from directory, as an alternative to python scripts.
Would you be willing to merge something like this if I created a PR:
class SqlRouter(Router):

    filemask = re.compile(r"[\d]{3}_[^\.]+\.(py|sql)$")

    @property
    def todo(self):
        """Scan migrations in file system."""
        if not os.path.exists(self.migrate_dir):
            self.logger.warn('Migration directory: %s does not exists.', self.migrate_dir)
            os.makedirs(self.migrate_dir)
        return sorted(
            f.rpartition('.')[0] for f in os.listdir(self.migrate_dir) if self.filemask.match(f))

    def read(self, name):
        """Read migration from SQL or python file."""
        sql_file = os.path.join(self.migrate_dir, name + '.sql')
        if os.path.isfile(sql_file):
            data = ''
            with open(sql_file) as f:
                for line in f.readlines():
                    if line and not line.startswith('--'):
                        data += line
            return lambda mg, db, *args, **kwargs: db.execute_sql(data), VOID
        return super().read(name)

Note that the only thing needing change in todo() is from ''.join(f[:-3]) to f.rpartition('.')[0] to support different length of file suffix. That could be improved in Router already.

Let see the PR.

After think about it a bit more, I am afraid this would not be such a good idea or in the scope of the project. The library seems to imbue some magic for the peewee models, and mixing and matching SQL migrations together with python migrations would probably introduce issues as not every change is available to the next migration.


Add in reference implementation of Software Supply Chain Security

Based on the best practices site, is there a section where we can add in reference implementation of the architecture of what the best practices would look like in software supply chain security. We have been working on an OpenSSF project known as FRSCA that would be great to demo to the community and add as an implementation that people can explore. FRSCA utilizes Tekton and follows the CNCF Secure Software Factory Ref Arch.

Happy to consider a proposal for a white paper to include in the community section.


Updated Makefile with deploy target

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind api-change
/kind bug
/kind cleanup
kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR adds a new target to the makefile named deploy.
Which issue(s) this PR fixes:

Fixes #4
Special notes for your reviewer:
Release note:
action-required: review

/ok-to-test


[glib]Fix linux build.

If feature selinux is not selected, remove define HAVE_SELINUX.

@vicroms ready to merge now.


Test building Openshift apps using the new images

@helio-frota you are already doing this to some extent with your work on the save-images script. I think it would be useful to have several different example applications bundled with the repo.

in progress...
https://github.com/bucharest-gold/s2i-nodejs#using-openshift-origin-client-tools
https://github.com/bucharest-gold/origin-s2i-nodejs/issues/39

@helio-frota I think we should be all set with this. If you want to outline what you have done to test these here, we can close it.

After the fix: https://github.com/bucharest-gold/origin-s2i-nodejs/pull/40
The apps works fine:
https://github.com/bucharest-gold/s2i-nodejs#using-oc-client-with-oc-cluster-up


Correction for raw affiliation Université de Lyon - Lumière Lyon2 França#R##N#Pesquisa: UMR 5191 ICAR

Correction needed for raw affiliation Université de Lyon - Lumière Lyon2 França#R##N#Pesquisa: UMR 5191 ICAR
raw_affiliation_name: Université de Lyon - Lumière Lyon2 França#R##N#Pesquisa: UMR 5191 ICAR
new_rors: 01rk35k63;03rth4p18;04mn0nr69
previous_rors: 029brtt94;03rth4p18
works_examples: W2619554878;W2593790860
contact: 7d81dd6ff36f8249d355931d5cfc1833:30a02b64990a43c9018daa3c65d7 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Added adapter_only option to LoRA

Context
What is the purpose of this PR? Is it to

[x] add a new feature
[ ] fix a bug
[ ] update tests and/or documentation
[ ] other (please add here)

Please link to any issues this PR addresses.
close #1212
Changelog
In #1210, the "adapter_only" (boolean) option was added to the save_checkpoint method of each Checkpointer class. When this option is set to True, only the adapter weights are saved instead of the entire model weights.
This PR applies that change to LoRA fine-tuning.
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)

[x] run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
[ ] add unit tests for any new functionality
[x] update docstrings for any new or updated methods or classes
[x] run unit tests via pytest tests
[ ] run recipe tests via pytest tests -m integration_test
[ ] manually run any new or modified recipes with sufficient proof of correctness

[ ] include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

To the reviewer,
Please let me know if there are any missing parts in my implementation or if there are any parts that should be removed. It's perfectly fine if the maintainer edits it directly.

Codecov Report
Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (7eb89e2) to head (aeedd92).
Report is 2 commits behind head on main.

Files
Patch %
Lines

recipes/lora_dpo_distributed.py
0.00%
5 Missing :warning:

recipes/lora_dpo_single_device.py
0.00%
5 Missing :warning:

recipes/lora_finetune_distributed.py
0.00%
5 Missing :warning:

recipes/lora_finetune_single_device.py
0.00%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
+ Coverage   67.81%   70.19%   +2.37%
==========================================
  Files         219      220       +1
  Lines        9908     9957      +49
==========================================
+ Hits         6719     6989     +270
+ Misses       3189     2968     -221

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thank you to all reviewers. I have made the following revisions:

The name of the option adapter_only was changed to save_adapter_weights_only. While adapter_only is understandable within the save_checkpoint method, it becomes ambiguous when used independently.
To avoid complications, the option is retained as a method option for save_checkpoint rather than being included in the Checkpointer constructor.
Adjusted the code to maintain consistency by removing the special case where all weights were saved only for the last epoch.
Added log output to inform the user that only adapter weights are being saved.

Due to a too long error occurring when running pre-commit run --all-files, the logs are spread over 4 lines.

Feel free to review the changes and provide further feedback!

@ebsmothers
Thank you for your review! I have made the corrections based on your feedback.

Maybe I'm being dense but is this log correct? I don't see where we actually check that save_adapter_weights_only=True prior to logging this

You’re absolutely right, this could indeed confuse the user. I’ve now modified the code to log the message based on the value of the option.
            if not is_intermediate_epoch:
                log.ingo("Saving final epoch checkpoint.")
                if self._save_adapter_weights_only:
                    log.info(
                        "Please note that you have set save_adapter_weights_only=True, so only adapter weights will be saved."
                        "You need to merge the adapter weights into your base model for further use. "
                        f"See {type(self._checkpointer).__name__}"
                    )
                else:
                    log.info(
                        "The full model checkpoint, including all weights and configurations, has been saved successfully."
                        "You can now use this checkpoint for further training or inference."
                    )

We already log the full config, no need to just directly re-log an individual config field unless there is something more non-trivial happening

I’ve removed the log output for that section. I agree that it’s best not to deviate too much from the overall logging pattern for the other options.

I moved the log output to checkpointer.
https://github.com/pytorch/torchtune/pull/1220/commits/e8e8757783ce2a784680734306c9c4676a2f47fc

LGTM. Thanks so much for your contribution, and your patience in addressing our comments : )

@SalmanMohammadi
PyTorch is my favorite ML package, and I'm happy to have contributed to it. Thanks so much!


Changed category fields in /courses endpoint

Problem: Some category fields have an object with fields as an example, some have just string with id. Check courseService and update those examples with real values from API
Now: category fields changed to actual API response

Please, check the references in cource-schema.yaml file. You are assigning a reference to a string field and, also they are not from components, you added them as definition.

As I know, we return just id as a string, that's why it assigned as a string. And added ref to show which object we receive via this id. Regarding to problem with components/definitions, it's already done in my other PR. It defined as definitions

Please, check the references in cource-schema.yaml file. You are assigning a reference to a string field and, also they are not from components, you added them as definition.

As I know, we return just id as a string, that's why it assigned as a string. And added ref to show which object we receive via this id. Regarding to problem with components/definitions, it's already done in my other PR. It defined as definitions

If you want to show, to which object this id is linked, you can use the description tag with some text, like id of category object with courceCategoryPost schema. But using ref without $ gives a wrong idea to the user, that it can be a reference to the object with a wrong example. You need to use only those reserved words, which are supported by Swagger docs, and ref is not one of them.


Tooltip for upgrade button gets stuck

Since #211
Reproduce:

Build a tower
Upgrade it
Move mouse away from upgrade button

Expected result: tooltip goes away
Actual result: tooltip doesn't go away

Fixed


Python: Textobject Motions Stop Working after Undo

Describe the bug
Whenever I undo an edit the textobject motions stop working until I restart nvim; it looks like TreeSitter may not be re-parsing the edited text?
https://github.com/user-attachments/assets/da32a918-be69-4375-be60-b527d372cdbf
To Reproduce

Open a Python file, edit a textobject, undo, then try editing a textobject again.

This is my config for treesitter-textobjects using lazy (mostly copied from the README):
return {
    "nvim-treesitter/nvim-treesitter-textobjects",
    dependencies = {
      "nvim-treesitter/nvim-treesitter",
    },
    config = function()
      local ts_textobjects = require("nvim-treesitter.configs")
      ts_textobjects.setup({
        textobjects = {
          select = {
            enable = true,
            lookahead = true,
            keymaps = {
              ["af"] = { query =<EMAIL_ADDRESS>desc = "outer function" },
              ["if"] = { query =<EMAIL_ADDRESS>desc = "inner function" },

              ["ac"] = { query =<EMAIL_ADDRESS>desc = "outer class" },
              ["ic"] = { query =<EMAIL_ADDRESS>desc = "inner class" },

              ["ao"] = { query =<EMAIL_ADDRESS>desc = "outer loop" },
              ["io"] = { query =<EMAIL_ADDRESS>desc = "inner loop" },

              ["ak"] = { query =<EMAIL_ADDRESS>desc = "outer block" },
              ["ik"] = { query =<EMAIL_ADDRESS>desc = "inner block" },

              ["al"] = { query =<EMAIL_ADDRESS>desc = "outer call" },
              ["il"] = { query =<EMAIL_ADDRESS>desc = "inner call" },

              ["ar"] = { query =<EMAIL_ADDRESS>desc = "outer parameter" },
              ["ir"] = { query =<EMAIL_ADDRESS>desc = "inner parameter" },

              ["ad"] = { query =<EMAIL_ADDRESS>desc = "outer conditional" },
              ["id"] = { query =<EMAIL_ADDRESS>desc = "inner conditional" },

              ["aa"] = { query =<EMAIL_ADDRESS>desc = "outer assignment" },
              ["ia"] = { query =<EMAIL_ADDRESS>desc = "inner assignment" },
            },
          },
          move = {
            enable = true,
            set_jumpts = true,
            goto_next_start = {
              ["]f"] = { query =<EMAIL_ADDRESS>desc = "outer function" },
              ["]c"] = { query =<EMAIL_ADDRESS>desc = "outer class" },
              ["]o"] = { query =<EMAIL_ADDRESS>desc = "outer loop" },
              ["]k"] = { query =<EMAIL_ADDRESS>desc = "outer block" },
              ["]l"] = { query =<EMAIL_ADDRESS>desc = "outer call" },
              ["]r"] = { query =<EMAIL_ADDRESS>desc = "outer parameter" },
              ["]d"] = { query =<EMAIL_ADDRESS>desc = "outer conditional" },
              ["]a"] = { query =<EMAIL_ADDRESS>desc = "outer assignment" }
            },
            goto_next_end = {
              ["]F"] = { query =<EMAIL_ADDRESS>desc = "outer function" },
              ["]C"] = { query =<EMAIL_ADDRESS>desc = "outer class" },
              ["]O"] = { query =<EMAIL_ADDRESS>desc = "outer loop" },
              ["]K"] = { query =<EMAIL_ADDRESS>desc = "outer block" },
              ["]L"] = { query =<EMAIL_ADDRESS>desc = "outer call" },
              ["]R"] = { query =<EMAIL_ADDRESS>desc = "outer parameter" },
              ["]D"] = { query =<EMAIL_ADDRESS>desc = "outer conditional" },
              ["]A"] = { query =<EMAIL_ADDRESS>desc = "outer assignment" }
            },
            goto_previous_start = {
              ["[f"] = { query =<EMAIL_ADDRESS>desc = "outer function" },
              ["[c"] = { query =<EMAIL_ADDRESS>desc = "outer class" },
              ["[o"] = { query =<EMAIL_ADDRESS>desc = "outer loop" },
              ["[k"] = { query =<EMAIL_ADDRESS>desc = "outer block" },
              ["[l"] = { query =<EMAIL_ADDRESS>desc = "outer call" },
              ["[r"] = { query =<EMAIL_ADDRESS>desc = "outer parameter" },
              ["[d"] = { query =<EMAIL_ADDRESS>desc = "outer conditional" },
              ["[a"] = { query =<EMAIL_ADDRESS>desc = "outer assignment" }
            },
            goto_previous_end = {
              ["[F"] = { query =<EMAIL_ADDRESS>desc = "outer function" },
              ["[C"] = { query =<EMAIL_ADDRESS>desc = "outer class" },
              ["[O"] = { query =<EMAIL_ADDRESS>desc = "outer loop" },
              ["[K"] = { query =<EMAIL_ADDRESS>desc = "outer block" },
              ["[L"] = { query =<EMAIL_ADDRESS>desc = "outer call" },
              ["[R"] = { query =<EMAIL_ADDRESS>desc = "outer parameter" },
              ["[D"] = { query =<EMAIL_ADDRESS>desc = "outer conditional" },
              ["[A"] = { query =<EMAIL_ADDRESS>desc = "outer assignment" }
            },
          },
        },
      })

      local ts_repeat_move = require("nvim-treesitter.textobjects.repeatable_move")
      -- Repeat movement with ; and ,
      -- ensure ; goes forward and , goes backward regardless of the last direction
      -- vim.keymap.set({ "n", "x", "o" }, ";", ts_repeat_move.repeat_last_move_next)
      -- vim.keymap.set({ "n", "x", "o" }, ",", ts_repeat_move.repeat_last_move_previous)

      -- vim way: ; goes to the direction you were moving.
      vim.keymap.set({ "n", "x", "o" }, ";", ts_repeat_move.repeat_last_move)
      vim.keymap.set({ "n", "x", "o" }, ",", ts_repeat_move.repeat_last_move_opposite)

      -- Optionally, make builtin f, F, t, T also repeatable with ; and ,
      vim.keymap.set({ "n", "x", "o" }, "f", ts_repeat_move.builtin_f_expr, { expr = true })
      vim.keymap.set({ "n", "x", "o" }, "F", ts_repeat_move.builtin_F_expr, { expr = true })
      vim.keymap.set({ "n", "x", "o" }, "t", ts_repeat_move.builtin_t_expr, { expr = true })
      vim.keymap.set({ "n", "x", "o" }, "T", ts_repeat_move.builtin_T_expr, { expr = true })
    end,
  }

Expected behavior
The textobject motions should work after the undo.
Output of :checkhealth nvim-treesitter
==============================================================================
nvim-treesitter: require("nvim-treesitter.health").check()

Installation ~
- WARNING `tree-sitter` executable not found (parser generator, only needed for :TSInstallFromGrammar, not required for :TSInstall)
- OK `node` found v22.9.0 (only needed for :TSInstallFromGrammar)
- OK `git` executable found.
- OK `cc` executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
  Version: cc (GCC) 14.2.1 20240910
- OK Neovim was compiled with tree-sitter runtime ABI version 14 (required >=13). Parsers must be compatible with runtime ABI.

OS Info:
{
  machine = "x86_64",
  release = "6.10.10-arch1-1",
  sysname = "Linux",
  version = "#1 SMP PREEMPT_DYNAMIC Thu, 12 Sep 2024 17:21:02 +0000"
} ~

Parser/Features         H L F I J
  - bash                ✓ ✓ ✓ . ✓
  - c                   ✓ ✓ ✓ ✓ ✓
  - diff                ✓ . ✓ . ✓
  - lua                 ✓ ✓ ✓ ✓ ✓
  - make                ✓ . ✓ . ✓
  - markdown            ✓ . ✓ ✓ ✓
  - markdown_inline     ✓ . . . ✓
  - python              ✓ ✓ ✓ ✓ ✓
  - query               ✓ ✓ ✓ ✓ ✓
  - regex               ✓ . . . .
  - rust                ✓ ✓ ✓ ✓ ✓
  - vim                 ✓ ✓ ✓ . ✓
  - vimdoc              ✓ . . . ✓

  Legend: H[ighlight], L[ocals], F[olds], I[ndents], In[j]ections
         +) multiple parsers found, only one will be used
         x) errors found in the query, try to run :TSUpdate {lang} ~

Output of nvim --version
NVIM v0.10.1
Build type: RelWithDebInfo
LuaJIT 2.1.1725453128
Run "nvim -V1 -v" for more info

Additional context
This seems to only happen with Python; everything works as expected when editing my nvim configuration, for example.

Was just working on some rust code and the same issue occurred; this seems more and more like an issue with either my config or this plugin and less like an issue with Python specifically.

This issue seems to have been fixed as of November 3rd; thanks to the devs for all the hard work they put into this!


Announcements & Breaking Changes

Please subscribe to this issue to be notified of any breaking changes or major features.

Version 0.0.3 has been released!

Breaking: window.options.winhighlight is deprecated
Feat: Add highlight support
Feat: Support hiding Incline on the only window in a tabpage
Feat: Support hiding Incline on the focused window
Feat: Allow tables of highlight args as winhighlight values
Feat: Add preset render functions
Feat: Add functions to globally enable/disable/toggle Incline
Feat: Add config.window.options
Feat: Add configuration transforms

Full Changelog: https://github.com/b0o/incline.nvim/compare/v0.0.2...v0.0.3
Check out the docs for more info — :help incline


Cleanup Kubernetes UI

As of 1.3, Rancher can show the native Kubernetes dashboard but it is not easy to find. In the next release we should do the following:

Remove Kubernetes namespaces tab
Remove Stacks, Deployments, Services, Replication Controllers, Replica Sets, and Pods from the Kubernetes tab
Add a new menu item called "Dashboard" into the Kubernetes tab, so the Kubernetes tab contains three items: Dashboard, kubectl, and Infrastructure Stacks.
Deploy heapster so graphs show up in Kubernetes UI.
The Catalog tab should go away since we support Helm/Tiller through CLI now. So in an Kubernetes environment, we'll only see four major tabs: Environments, Kubernetes, Infrastructure, and API.

@sheng-liang  omg, the "execute shell" and "logs" menus will be removed?

we will not be able to see pods from Rancher menu and inspect them with 'execute shell' ? :(
I really like current menus, all pods/deployments/services pages are useful to quickly navigate from "service" for example into "which pods it points to", and quickly see its logs or ssh (in K8s dashboard things are different, and not everything is as good as in Rancher UI).
Please consider leaving current UIs optional to those who like it?
K8s dashboard is good, but not in all aspects. When both options available, it'll be a win win for all :)  (especially those who already got used to current Rancher UI with K8s environment)

The Rancher infrastructure view will not be removed. Only the pod/replica set view will be removed as it is done better in native Kubernetes UI.

Pod stats need cadvisor I think

@weikinhuang context?

Ah, gotcha, I tried running heapster/grafana/influxdb but couldn't get container (pod) stats working, I was only able to get node stats working. (Using Rancher 1.3.0/CoreOS/Kube 1.5.1)

@wlan0 I just tried deploying your heapster add-on, same issue. I was only able to see node stats and not pod stats. The section that lists namespaces only show default and kube-system, and no pods within those namespaces are available.

Version - master 1/11
All menu items are removed.  If you have other issues, please add separate bug.


Can't create netCDF resource using iRODS user zone file

I tried to create the netCDF resource on www site using the file from iRODS user zone and got the following error. Different files are tried and have the same error. @hyi would you please help to have look at this issue? Thanks

@gantian127 I discovered this issue while writing and testing federated user zone unit tests and have fixed this issue along with several other issues related to federated user zone in that branch. This PR https://github.com/hydroshare/hydroshare/pull/1623 will fix this bug along with several other bugs. It'd be great if you, @pkdash and @zhiyuli can code review that PR whenever you have a chance so that it can be merged sooner rather than later since it includes several bug fixes discovered by the new unit tests I wrote. With that PR merged, the user zone-related functionalities will be unit tested to make sure they work as expected.

@hyi Thanks for your information. I will look at the code of branch #1623.

@gantian127 The fix to this issue has been deployed to beta as part of the addition of federation unit tests. Can you verify on beta and close this issue if it works now?

@hyi I tested on Beta and it works now. I will close this issue. Thanks


Skipping e2e tests failed

This PR aims to skip a bunch to odsp and tinylicious test failing in the pipeline. There is an issue opened for these tests: https://github.com/microsoft/FluidFramework/issues/9534

I think disabling these altogether will decrease the coverage for regular changes considerably and possibly lead us with worse outcomes when the issues are fixed. Especially when we don't have a clear path around fixing the root issue causing this. We could be injecting bugs and then we'll have to dig through the changes to pinpoint them when we fix the issue.
Also, please add the github issue in the comment in the code.
Can we try to disable them only for the specific drivers for which they fail?

I'll go over them again. But there are few tests failing for both tinylicious and odsp

I think disabling these altogether will decrease the coverage for regular changes considerably and possibly lead us with worse outcomes when the issues are fixed. Especially when we don't have a clear path around fixing the root issue causing this. We could be injecting bugs and then we'll have to dig through the changes to pinpoint them when we fix the issue.
Also, please add the github issue in the comment in the code.
Can we try to disable them only for the specific drivers for which they fail?

I'll go over them again. But there are few tests failing for both tinylicious and odsp

we should be targeted with our skipping. and only skip for the failing driver type. all these tests on local when they run in the buddy build so we shouldn't remove coverage there

@sdeshpande3 you can follow my example here https://github.com/markfields/FluidFramework/commit/4f4bd042359bbdc23d646462603ead0e21a1e10b

Also, please add the github issue in the comment in the code.

Agree with this.  Usually I'm not a fan, but this is test code and we aim to get these cleaned up ASAP, and it will make a nice way to ensure we finish that work (searching for that issue number would come up empty)

looks like you accidentally added to large file named q that should be removed


php_value should be placed in php-fpm and not httpd config

Describe the bug
There are some php_value parameters set in the file /etc/httpd/conf.d/zabbix.conf
Apache 2.4.37 (centos 8) doesn't accept that and this should therefore be placed in the php-fpm pool instead.
This is the output from systemctl, when trying to start httpd:
Feb 24 12:47:02 psg1-zabbix-001.local systemd[1]: Starting The Apache HTTP Server...
Feb 24 12:47:02 psg1-zabbix-001.local httpd[8975]: AH00526: Syntax error on line 41 of /etc/httpd/conf.d/zabbix.conf:
Feb 24 12:47:02 psg1-zabbix-001.local httpd[8975]: Invalid command 'php_value', perhaps misspelled or defined by a module not included in the server configuration
Feb 24 12:47:02 psg1-zabbix-001.local systemd[1]: httpd.service: Main process exited, code=exited, status=1/FAILURE
Feb 24 12:47:02 psg1-zabbix-001.local systemd[1]: httpd.service: Failed with result 'exit-code'.
Feb 24 12:47:02 psg1-zabbix-001.local systemd[1]: Failed to start The Apache HTTP Server.

Installation method/version

Github / latest
Ansible Galaxy / 1.5.0

Ansible Version
ansible 2.9.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.6.8 (default, Nov 21 2019, 19:31:34) [GCC 8.3.1 20190507 (Red Hat 8.3.1-4)]

Targetted hosts
Concerns the following OS(es):

CentOS 8

Expected behavior
We should place the php_value things in php-fpm pool instead.. Example here:
php_value[max_execution_time] = 300
php_value[memory_limit] = 128M
php_value[post_max_size] = 16M
php_value[upload_max_filesize] = 2M
php_value[max_input_time] = 300
php_value[max_input_vars] = 10000
php_value[date.timezone] = Europe/Stockholm

Additional context

Created PR https://github.com/dj-wasabi/ansible-zabbix-web/pull/79 to address this issue.


Trying to overwrite file owned by another mod

Please note that this repository's issues section will be closed in the near future.
Please open metadata-related issues (issues relating to incorrect information about mods, missing versions, or incorrect installations) in the NetKAN repository (https://github.com/KSP-CKAN/NetKAN/issues) or if you want to suggest something or report a bug relating to CKAN as a whole, open the issue in the CKAN repository (https://github.com/KSP-CKAN/CKAN/issues).
File           : GameData/scatterer/sunflare/Ghost1.png
Installing Mod : AstronikiSunflareforScatterer 1.0
Owning Mod     : Scatterer
CKAN Version   : v1.16.1-0-g2e91715 (beta)

Uninstalling and re-installing  scatterer will clear this issue.


IP not required

On rave pay documentation the IP address is not required so it shouldn't be required to charge a card with the SDK to.

Hello @Uncensored-Developer,
Thanks for the feedback.
We have deployed a fix to address the issue you raised. In the new update, only the params listed as required in the documentation are made compulsory in the SDK.
Please feel free to check out the update and let us know what you think about it.
We are excited to hear from you soon.
Kind regards,
Cornelius.

Hello @Uncensored-Developer,
Thanks for the feedback.
We have deployed a fix to address the issue you raised. In the new update, only the params listed as required in the documentation are made compulsory in the SDK.
Please feel free to check out the update and let us know what you think about it.
We are excited to hear from you soon.
Kind regards,
Cornelius.


Gulp not importing dependencies

What were you expecting to happen?
Vue components to be transpiled correctly by gulp. I'm not sure if this the fault of gulp, or browserify, or babelify. It's definitely related to gulp somehow.
What actually happened?
What's occurring is I'm able to run
gulp vue-js

And the build completes successfully. On page refresh, there is a console error that reads:
SyntaxError: Unexpected end of input

This is due to a line in a new component (a line that is duplicated in many others):
const Axios = require('axios');

I've also tried:
import Axios from 'axios';

Neither work correctly. What appears to be happening is when it comes to bringing in the Axios sources, gulp fails to locate the files and decides to just write what it's put together at that point and die silently. The reason for this is a typical vue-js file, once transpiled, is ~11K LOC. The files that are being generated from this new component are ~1200 LOC.
I've worked with the npm support team already to rule out npm or node being the issue. I've also reached out to Vue support who confirmed it's not an issue with the framework itself. That leaves gulp, browserify, babelify, and Axios as being the next groups from which to seek assistance.
As for reaching out to gulp support, I've tried the IRC channel, StackOverflow, and Gitter -- none were effective in garnishing any responses. So now I'm here. I apologize for opening an issue, but I can't afford to wait any longer, I've already lost three days of productivity to this problem.
I tried upgrading to gulp 4, and it broke my app, so I reverted. I've upgraded npm and node, and all my dependencies with no apparent positive or negative side effects. There are a lot of other steps I've completed as well, but I figure these are the big ones you should be aware of.
The below configuration works fine for 30+ other components, and has been working fine for a while. It's the creation of new components that are the problem, and what sparked my upgrade spree.
Any assistance will be greatly appreciated. Thank you.
Please post a sample of your gulpfile (preferably reduced to just the bit that's not working)
var gulp        = require('gulp');
var browserify  = require('browserify');
var vueify      = require('vueify');
var transform   = require('vinyl-transform');
var source      = require('vinyl-source-stream');
var sass        = require('gulp-sass');
var sourcemaps  = require('gulp-sourcemaps');
var fs          = require("fs")
var babelify    = require('babelify');
var glob        = require('glob');
var rename      = require('gulp-rename');
var rev         = require('gulp-rev');

gulp.task('vue-js', function() {
  //determine all files to be compiled
  glob('./js/vue-mini-apps/**/*app.js', function(err, files) {
    if (err) {
      gutil.log(gutil.colors.red('Glob error:'),err);
    }
    //browerify each file
    var tasks = files.map(function(entry) {
      return browserify(entry, {debug:true})
          .transform(babelify, {presets: ['es2015'], plugins: ["transform-runtime"]})
          .bundle()
          .pipe(source(entry))
          //determine file name from file path
          .pipe(rename(entry.split('/')[3].split('.')[0] + (entry.split('/')[4] != 'app.js' ? '.' + entry.split('/')[4].replace('app.js', '') : '.') + 'bundle.js'))
          .pipe(gulp.dest('./js/vue-mini-apps/dist'));
          gulp.src('./js/vue-mini-apps/dist/' + entry.split('/')[3].split('.')[0] + '.bundle.js')
            .pipe(rev())
            .pipe(gulp.dest('./js/vue-mini-apps/dist'));
    });
  });
});

What version of gulp are you using?
$ gulp -v
[16:36:17] CLI version 2.0.1
[16:36:17] Local version 3.9.1

What versions of npm and node are you using?
$ npm -v
6.1.0

$ node -v
v10.6.0

This is not a support forum. Please direct support questions to StackOverflow.


Provide information regarding multiple re-exports

The problem I'm facing is that parse only reports the last re-export of cjs modules completely loosing the information about pre-existing ones.
For example by parsing the following code:
if (true) {
  module.exports = require("./a.cjs");
} else {
  module.exports = require("./b.cjs");
}

only the last re-export assignment is recognized and reported to the caller (reexports = ['./b.cjs' ]).
It would be very useful if all the re-exports in the code could be recognized and reported to the caller
For example as: reexports = ['./a.cjs', './b.cjs']
The above anyways could be considered ambiguous since the same result could be obtained by parsing
module.exports = {...require('./a.cjs'), ...require('./b,cjs')};

so maybe reexports could/should actually be an array or array of strings?
Meaning that parsing
if (true) {
  module.exports = {...require('./a.cjs'), ...require('./b,cjs')};
} else {
  module.exports = {...require('./c.cjs'), ...require('./d,cjs')};
}

could yield reexports = [['./a.cjs', './b.cjs' ], ['./c.cjs', './d.cjs' ]]
Minimal Reproduction
For convenience I've created a reproduction here: https://github.com/dario-piotrowicz/cjs-module-lexer-reexports-repro
Additional information
Bug?
As I mentioned, I am not sure if this could be considered a bug since the reexport resetting seems to be intentional.
Solving this might generate different problems
If this issue were to be addressed, I would imagine that the following code:
module.exports = require('./a.cjs');
module.exports = require('./b.cjs');

would also produce two re-exports... although only one is actually valid... so this is definitely something to keep in mind 😕
The lexer is content-unaware so I don't think much could be done to avoid the above arguably incorrect result, even if nesting was kept into account (which might be a stretch in the lexer) that would still not always generate perfect results, for example when parsing code like this:
if(true){
   module.exports = require('./a.cjs');
}

module.exports = require('./b.cjs');

(maybe instead of expanding reexports there could be a new field in the parse result? as extra-reexports or something like that that could host all the reexports excluding the last one? so keeping the same exact functionality the lexer has now whilst also providing callers with the extra bit of information?)
More context
To give a bit more context, I am simply trying to parse cjs code and gather informations about all the exports and re-exports that the code contains, unfortunately as mentioned in the issue the lexer currently doesn't return all possible re-exports but only the last one encountered, this is problematic in my use case as I would want to know all possible re-exports as well (and that information gets, as far as I can tell, completely lost).

This could make sense.


Update overview.md

Added a note about not using the CDN for production scenarios
When creating a new PR, please do the following and delete this template text:

Reference the issue number if there is one:
Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.

Suggest reviewers if you know who should review the PR, using the GitHub Reviewers UI.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Hey Rick
I don't see this change live yet - when does that happen?
Thanks
Chris
On Tue, Aug 8, 2017 at 3:07 PM, Rick Anderson<EMAIL_ADDRESS>wrote:

Merged #3914 https://github.com/aspnet/Docs/pull/3914.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Docs/pull/3914#event-1198102713, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABRep10bbENASfWtIkR7JOn_v_4UJbCwks5sWNw6gaJpZM4OxGO6
.


Enhance docs about setting Spring profile at bootstrap via ENV Variable

i have updated the paragraph as discussed, but also i have modified the resource yaml file to be general I've used a POD, any suggestions !

Thanks for this!
Actually the README.adoc is generateds from the contents inside docs. Would you like to make the changes there (and revert the the README change) please?

Alright,


Extract getMetrics() and getConfig()-related functionality into a module.

The idea behind extracting getMetrics() and getConfig()-related functionality into a module is that, currently, the implementation of getting metrics for a service is duplicated between edgex-go and device-sdk-go.
As recommended by @anonymouse64, it would make our code-base more efficient if we extract these common tasks into another module, which lives independently of device-sdk-go and edgex-go.

@akramtexas - still a Fuji release item?  Label Geneva?

@jpwhitemn thanks for catching that 👍

@michaelestrin can please I take this up?

@shashank-priyadarshi thanks for offering, but I just checked the code, and we have completed this issue in the main branch
the logic of config and metrics have both been moved to go-mod-bootstrap
https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/bootstrap/container/configuration.go
https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/bootstrap/container/metrics.go
closing this issue as resolved


<EMAIL_ADDRESS>referenced in [...] didn't resolve at build time, it will remain unchanged to be resolved at runtime

Försöker konsumera @fkui/vue och @fkui/design men får varningar vid bygge (vanilla Vite från npm create vue). Nu nyttjar jag ingen komponent som behöver dessa filer så jag klarar mig men antar att det blir 404 ifall jag gör det.
<EMAIL_ADDRESS>referenced in<EMAIL_ADDRESS>didn't resolve at build time, it will remain unchanged to be resolved at runtime

<EMAIL_ADDRESS>referenced in<EMAIL_ADDRESS>didn't resolve at build time, it will remain unchanged to be resolved at runtime

<EMAIL_ADDRESS>referenced in<EMAIL_ADDRESS>didn't resolve at build time, it will remain unchanged to be resolved at runtime

<EMAIL_ADDRESS>referenced in<EMAIL_ADDRESS>didn't resolve at build time, it will remain unchanged to be resolved at runtime

<EMAIL_ADDRESS>referenced in<EMAIL_ADDRESS>didn't resolve at build time, it will remain unchanged to be resolved at runtime

Som en workaround kan jag lägga in följande i min vite.config.ts men det är ju trist och drygt, står heller inte dokumenterat att man isf behöver göra det.
+       resolve: {
+               alias: {
+                       '~@fkui/design': "@fkui/design",
+               }
+        },

SFKUI-6938


Refactor IO code to abstract out "OUTPUT"

allow one to specify a different output directory

The purpose of the PR is to begin abstracting out the hard-coded paths for reading/writing pickle files. Now that we can get the same answers on all platforms, we need to move to a style of computation like this:
reference inputs + code -> outputs
compare outputs to reference outputs -> if difference is less than TOL, tests PASS

Right now, the reference inputs, reference outputs, and code outputs are all mixed together. By separating these inputs and outputs, we can then do more invasive changes to the code and ensure that the answer remains the same.

I think this is in reasonable shape. I would prefer a resolution on https://github.com/OpenSourcePolicyCenter/dynamic/issues/115 before merging.

This now makes use of the file comparison features and will run the full SS+TPI by running py.test. (this takes about 40 minutes, so for Travis CI, we skip that test).

Merging this doesn't impact running the run_simulation.py script, but it does provide the option to put all output in a different directory. Just FYI
cc @rickecon @jdebacker @evan-magnusson @isaacswift @MattHJensen


Add Usage and Installation sections to README.md

Fix #99.

A PR should be also send to extension-catalog to update README.md after this one is merged.


Isn't there a good documentation for understanding how python/node.js drivers work

It's is mentioned in the readme of the Apache age official GitHub link.
Python Driver:
Github ReadMe link
Node Driver:
Github ReadMe link

Just as @waleedahmed0001 said, it is mentioned in the README of the official Github link, if you have more questions I think you should ask those working on AGE drivers here on discord.

Though we do not have a detailed documentation about python or node js driver but on the official age github repository in the built-in section there is a read me file for each driver which contains enough information to get you started.


Poor interaction with threads (python 2.7)

the interaction between this library, graphql-core, and promise appears to allow execution to hop threads especially (only?) when using a middleware and nested resolvers. this is inconsistent with flasks threading model and the ability to access the request/g thread locals
with the attached (very contrived) example, when submitting the query with concurrent requests the requests frequently fail because the key created in get_context doesn't exist on the threadlocal flask.g object in the resolvers. This happens when a thread accesses the promise.async_instance which isn't thread local, and resolves a promise that was created on a different thread.
query.txt
from flask import Flask
from flask_graphql import GraphQLView

app = Flask(__name__)

import graphene
import threading
import time
from flask import g

def get_user(info):
    return g.get(info.context['key'])

class User(graphene.ObjectType):
    id = graphene.ID()
    name = graphene.String()
    friend = graphene.Field(lambda: User)
    age = graphene.Int()
    apple = graphene.String()

    @classmethod
    def resolve_friend(cls, root, info):
        time.sleep(.1)
        x = get_user(info)
        return User(id=id(root), name=':'.join([x.name, threading.current_thread().name]))

    @classmethod
    def resolve_age(cls, root, info):
        time.sleep(.1)
	return 5

    @classmethod
    def resolve_apple(cls, root, info):
        time.sleep(.1)
        return "Apple"

class Query(graphene.ObjectType):
    me = graphene.Field(User)

    def resolve_me(self, info):
        time.sleep(.1)
        return get_user(info)

schema = graphene.Schema(query=Query)

ahh = {}
def dummy_middleware(next, root, info, **args):
    return_value = next(root, info, **args)
    return return_value

import random
random.seed()

class TestQLView(GraphQLView):
    def get_context(self, request):
	# set a random key in g to be used by resolvers
        key = str(random.randint(0,50))
	name = threading.current_thread().name
        user = User(id=key, name=name)
        setattr(g, key, user)
	return {
	    'key': key
        }

app.add_url_rule('/graphql', view_func=TestQLView.as_view('graphql', schema=schema, graphiql=True, middleware=[dummy_middleware]))

Yes. With concurrent requests I would frequently see errors in the logs. This only occurs when threading is on and requests are concurrent, so a single screenshot of a result won't reflect a proper step for reproduction.
I also ended up tracking this down and working around it. It turns out the promise library isn't thread safe. I mentioned it in an issue for the promise library and described my workarounds.
here's the issue: https://github.com/syrusakbary/promise/issues/57

Any news on how to access context in resolvers with the ThreadExecutor ?
I keep getting "Working outside of request context" when accessing "info.context" in resolver when I use the ThreadExecutor


fix: prevent yank events registration issues in multi-window setup

When opening a vault with multiple windows, non-active windows could miss the timing to register yank events.
Added a mechanism to manage windows that have registered yank events to ensure proper event handling across all windows.
Windows that fail to register yank events will not sync with the clipboard, even when set clipboard=unnamed is configured.

Thanks!


Dev versioning?

This changes the version of the crate to 0.3.0 and the binary's to 1.0.0… I've added a -dev suffix. Trying to reflect what gets build off main or other branches, but mostly not at 'tags' for actual releases… so to avoid ever having e.g. a 1.0.0 before and it released, and proposing to increment right after release re-adding the suffix. Not attached to -dev tho… just anything that differentiates it from an actual release.
@guicassolato any point of view? It'd be great to have this across all components, wdyt?

would it make sense to use a something like -rc0 (release candidate 0 )

I'm cool with -rc0 but if we do release candidates, it becomes weird: You are at -rc0 (i.e. work in progress towards whatever version it suffixes, e.g. 1.0) then you release -rc1, dev branch goes back to -rc0 so that you have -rc0 < -rc1 < -rc0… which is weird (and not how versioning order things… i.e. lexical order, hence -alpha < -beta
But with that rational in mind -dev < -rc anyways… 🤔

@maleck13 I also realize I may have badly conveyed my intent here: -SNAPSHOT people use in Maven

Also, for completeness here, I tried changing the build.rs to use  git tag --points-at HEAD and figure out some magic about what version it actually builds… but somehow I couldn't get it to work reliably and also thought it wouldn't address it holistically… at the limitador level, if we'd push the output to a file and use that for versioning throughout;… but what about other components? So decided to open the floor for discussion with this change first.

I follow now. So we would have v0.3.0-dev. This would be a build of all the components injecting the version in to the binary and also building and publishing a new image to quay. Then when we felt we were close to a release we would switch to -rc0 etc?
Ideally then this new dev version would also be tested in an environment with a set of very stable (really really stable even if that means we only have 1 or 2 initially) tests that should never fail and are red flag that something happened. I think we should look to trigger these builds automatically on a nightly basis (as a goal).
Once we go through doing it once manually, we can then look to automate it via GH actions or some other mechanism (as long as its not from someones machine).

Then when we felt we were close to a release we would switch to -rc0 etc?

Yes, we can do releases with RCs or whatever however we see fit (including a -nightly-<date> or something that's automated… if we feel we want to distribute that), I just would like some marker that means "that's a thing that's built off this branch (could be main if e.g. v1.0.0 is where that happens) but that's NOT the release…

So installing the operator at v0.3.0-dev would install the latest -dev releases?

As wrt to dependencies across components… well, that's a bit a mess with -dev (or whichever suffix we go for), as it is per definition "unstable", which would mean that you could perfectly use n-dev of one component that would end up being incompatible with n-dev of one if its dependencies. This could happen for multiple reasons:

There is no atomic publishing of these components
There is no atomic installation of these neither (e.g. you run n-dev of an operator than only "later" pulls in an image of e.g. limitador… that could be weeks later and as such it'd pull the last n-dev published then…)


RustQuant::autodiff: add support for nalgebra matrices/vectors.

Opps, just realised there is an issue for it and you assigned to yourself.
This is my blocker of https://github.com/avhz/RustQuant/issues/63 and I'm trying to fix it as well.
nalgebra requires its matrix element to be 'static, so it's not easy to create a matrix full of our Variable structure as it contains a reference to Graph. Currently I'm refactoring Variable structure to use Rc<Graph> instead, but it leads me to other troublesome problems.
You can see my progress in https://github.com/WenqingZong/RustQuant/tree/wenqing/neural-networks Currently the code doesn't compile due to an error which I'm not sure how to fix, was meant to ask for your help but found you are working on it as well.
The Problem:
In Variable.rs, after changing graph: &Graph to graph: Rc<Graph>, the graph.rs/var() method failed to compile as creating a Variable would take the ownership of a Graph instance.

If I recall correctly, using Rc means that the user needs to do things like:
// Original
let z = x + y;

// Using `Rc`
let z = x.clone() + y.clone();

Which I think is not user friendly. Is this the problem you had ?

Hmmm, ok, forget about the Rc solution then. But again the current Variable structure cannot be used to populate an nalgebra matrix as it has lifetime 'v and... it's really blocking neural net implementation.

I could try ndarray and see if it is the same problem?

superb

It would work I think if I could impl num::One and num::Zero traits for the Variable type but I don't see how this could be done.

Would a global, static graph variable solve that?


added history {id} command

Fixes

Fixes #126
Types of changes

[ ] Bug/Hot fix (non-breaking change which fixes an bug)
[x] New feature (non-breaking change which adds a functionality/feature)
[ ] Refactoring Old Code ( non-breaking change replacing already existing code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

In this PR, I have added the history {id} command.
For ex: If we have a history as follows

then on running the 'history 2' command, it will run 'github' command

Preview Link

https://terminal-portfolio-2i3evsjzw-vaibhav31.vercel.app/
Checklist:

[x] I have read the CONTRIBUTING guidelines in repository.
[x] My pull request has a descriptive title and is attached to an existing issue.
[x] I haven't repeated the code and it follows established code style of repository.
[x] My branch is up-to-date with upstream branch.

remove this highlighted portion as it is already mentioned inside the history block

@TechSpiritSS I have resolved the merge conflict and removed the highlighted portion as you mentioned, please review it now.

Great 🚀


Fix flaky web console end-to-end test

Description
web-console/e2e-tests/tutorial-batch.spec.ts would occasionally timeout between the transition from the data loader "configure schema" and "partition" steps due to missing waits when toggling the rollup setting.
Also, fix shellcheck warnings for web-console/script/druid.

This PR has:

[x] been self-reviewed.
[x] been tested by running 50 times in Travis CI: https://travis-ci.org/github/ccaominh/druid/builds/673698848

Looks great. Thank you. 👍


Exporting a timer with seconds isn't collecting in the right units

Ran into an interesting issue when attempting to track request duration via:
let start = Date()
let oneSecond = -start.timeIntervalSince(start.addingTimeInterval(1.0))

It resulted in much larger values than I expected, to show some sample test output comparing the unexpected values:
error: -[SwiftPrometheusTests.PrometheusMetricsTests testSummaryDouble] : XCTAssertEqual failed: ("# TYPE summary_seconds summary
summary_seconds{quantile="0.01"}<PHONE_NUMBER>.0
summary_seconds{quantile="0.05"}<PHONE_NUMBER>.0
summary_seconds{quantile="0.5"}<PHONE_NUMBER>.0
summary_seconds{quantile="0.9"}<PHONE_NUMBER>0000.0
summary_seconds{quantile="0.95"}<PHONE_NUMBER>0000.0
summary_seconds{quantile="0.99"}<PHONE_NUMBER>0000.0
summary_seconds{quantile="0.999"}<PHONE_NUMBER>0000.0
summary_seconds_count 5
summary_seconds_sum<PHONE_NUMBER>0000
summary_seconds{quantile="0.01", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.05", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.5", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.9", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.95", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.99", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds{quantile="0.999", myValue="labels"}<PHONE_NUMBER>00.0
summary_seconds_count{myValue="labels"} 1
summary_seconds_sum{myValue="labels"}<PHONE_NUMBER>00")

is not equal to

("# TYPE summary_seconds summary
summary_seconds{quantile="0.01"} 1.0
summary_seconds{quantile="0.05"} 1.0
summary_seconds{quantile="0.5"} 4.0
summary_seconds{quantile="0.9"} 10000.0
summary_seconds{quantile="0.95"} 10000.0
summary_seconds{quantile="0.99"} 10000.0
summary_seconds{quantile="0.999"} 10000.0
summary_seconds_count 5
summary_seconds_sum 10130
summary_seconds{quantile="0.01", myValue="labels"} 123.0
summary_seconds{quantile="0.05", myValue="labels"} 123.0
summary_seconds{quantile="0.5", myValue="labels"} 123.0
summary_seconds{quantile="0.9", myValue="labels"} 123.0
summary_seconds{quantile="0.95", myValue="labels"} 123.0
summary_seconds{quantile="0.99", myValue="labels"} 123.0
summary_seconds{quantile="0.999", myValue="labels"} 123.0
summary_seconds_count{myValue="labels"} 1
summary_seconds_sum{myValue="labels"} 123")

The underlying swift-metrics saves everything as Int64 and assumes nanoseconds, as all other methods convert then call to that method. From the Prometheus docs on naming:

Metrics must use base units (e.g. seconds, bytes) and leave converting them to something more readable to graphing tools. No matter what units you end up using, the units in the metric name must match the units in use.

This follows an assumption that Prometheus client libraries use seconds as well.
I believe we should strive to create an idiomatic client, which I think means exporting the metrics in the desired unit. Given the assumption that units are encoded in the metric name, I think that's potentially a good path to investigate further.

Basing just off seconds and assuming that'll be enough is probably offbase too— if someone's using http_requests_duration (or any other name to represent time) then we won't catch it. Maybe we just need to make explicit that we always export in nanoseconds?

The PromCounter doesn't export. nanoseconds, it exports whatever value you put in. With swift-metrics, that's nano seconds. If you were to use Prometheus directly and put in 1 second, (.inc(1)) you would get back 1. Not quite sure what a nice way to fix this would be.

Filed https://github.com/apple/swift-metrics/issues/39 to see what upstream folks think too 🎉


fix: allow 'autocompletion' function to return any kind of iterable

This is related to #1856 (0103c9570650daa59560baf42ad0a27e57b3157f) and addresses the same issue as in python/typeshed#5265.
Specifically the type annotation introduced there forces the autocompletion function to have List[str] as return type even though the implementation never required that. It only needs Iterable[str]. This causes some functional autocompletion functions to get rejected by mypy even though there's (ostensibly) no reason for that.
I'm not sure whether an issue needs to be created for this as this problem isn't present in any released code (yet).
Checklist:

[x] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

no relevant docs:

[x] Add or update relevant docs, in the docs folder and in code.
[x] Add .. versionchanged:: entries in any relevant code docs.

Please fix the annotation to match the code.

After reviewing, going to close this in favor of a new PR, since basically everything would change.


connectivitycheckcontroller: fix incorrect event reason on update

Event indicating endpoint updated should have a reason of EndpointCheckUpdated.

/lgtm

/test e2e-aws-operator


Dataset Download

Hi @jponttuset
I am unable to download the raw voice recordings in the dataset. There is no such path, as mentioned in the documentation.
https://storage.googleapis.com/localized-narratives
While accessing the above URL, I am getting the following error:
<Error>
NoSuchKey
<Message>The specified key does not exist.</Message>
No such object: localized-narratives/voice-recordings/
</Error>

Hi @shivangibithel,
If you check the documentation of the file format here, you'll see that you need to access the recordings by their direct URL, which is specified in the field voice_recording of the Localized Narrative.
For example, for coco_val/coco_val_137576_93.ogg, the URL is
https://storage.googleapis.com/localized-narratives/voice-recordings/coco_val/coco_val_137576_93.ogg, which works properly.

Hi @shivangibithel
Thanks for your patience while I was debugging this issue.
I just realized that for Flickr30k, the image IDs are 0-padded to 16 characters, so in the case above it'd be:
https://storage.googleapis.com/localized-narratives/voice-recordings/flickr30k_val/flickr30k_val_0000000219843859_180.ogg
I'll fix the JSONL files ASAP, but in the meantime you can hack it as above.

Hi @shivangibithel,
The JSONL files on the website have been updated to point to the correct recording filename (it was wrong for Flickr30k and ADE20k). The rest of the file should be exactly the same.
Feel free to reopen this bug in case you still find some problems, and thank you very much for reporting the issue!

Thank you for the quick response.


Refine impl of TabletColumn to reduce memory usage

Close issue #607
With this optimization, the memory usage of 73000 tablets, each of which contains 1500 columns
of type VARCHAR, dropped from 23.5GB to 11GB.

After optimization, column name uses most of the memory (std::string 32byte), wonder if we can share the column name for all the tablet's of the same table, using gutil::scoped_refptr (8byte), or using std::shared_ptr(16byte)

This object will be shared by multiple threads. If shared_ptr is used, it will hurt performance when there are many concurrent access.

It will only affect performance when Tablet gets created, not for scan (read-only)

After optimization, column name uses most of the memory (std::string 32byte), wonder if we can share the column name for all the tablet's of the same table, using gutil::scoped_refptr (8byte), or using std::shared_ptr(16byte)

Sounds appealing, but I'm curious whether we can have all Tablets with the same schema share a single TabletSchema object, and if so, maybe we can benefit even more.

After optimization, column name uses most of the memory (std::string 32byte), wonder if we can share the column name for all the tablet's of the same table, using gutil::scoped_refptr (8byte), or using std::shared_ptr(16byte)

Since the column names are all zero-terminated strings and rarely updated, maybe we can just replace the std::string with const char* to save the column name.

By using a single char* to represent the column, instead of std::string, the memory usage dropped to 7.6GB


server-1704 | Terraform format

:gear: Issue
Terraform pipeline was failing due to fmt
SERVER-1713
SERVER-1704
:white_check_mark: Fix

Formatted the terraform code
Added an example with latest code base in GCP ReadMe file
Removed unnecessary input variable project from GCP code base

:question: Tests

[ ] Passed reality check

@atulsingh0 we could probably remove the project var here too: https://github.com/CircleCI-Public/server-terraform/blob/main/nomad-gcp/examples/basic/main.tf#L1-L4

thanks variable is actually used in google-provider - https://github.com/CircleCI-Public/server-terraform/blob/main/nomad-gcp/examples/basic/main.tf#L73


Page pageup/pagedown do a better job in the compose box

If you're composing a really long message (like a couple screenfuls of text), and then try to navigate within the compose box using pageup/pagedown, it doesn't really work.  The cursor moves, but the scroll position in the window doesn't, which is annoying.  We should improve this.

@timabott Can you send a small video of what you are facing? I tried typing a really long message and then scrolled, the scrolling is smooth for me?

@minervapanda don't have time to take a video, but if you type a really long messsage (multiple screens) and then hit the pageup key, it move the cursor, but doesn't move the scroll position within the text box to show the new cursor position.

I can see this issue in Chrome, but not in Firefox Quantum
@minervapanda do you want to claim this issue, or can I look into it?

I can also reproduce the issue on Google Chrome. Could someone point where to look at?
I found, however, something in navigate.js where these events are defined:
exports.page_up = function () {
    if (message_viewport.at_top() && !current_msg_list.empty()) {
        current_msg_list.select_id(current_msg_list.first().id, {then_scroll: false});
    } else {
        exports.page_up_the_right_amount();
    }
};

exports.page_down = function () {
    if (message_viewport.at_bottom() && !current_msg_list.empty()) {
        current_msg_list.select_id(current_msg_list.last().id, {then_scroll: false});
        unread_ops.mark_current_list_as_read();
    } else {
        exports.page_down_the_right_amount();
    }
};

@zulipbot claim

I think we may not have custom code for this, and might need to add some.  @synicalsyntax @lonerz might be able to help here.

This is an interesting problem here that doesn't have a clear solution.
Something that I can think of is that in hotkey.js, we can check if Pg+Up and Pg+Down are pressed when the compose textbox is focused and scroll the textbox manually--not sure how to do the scrolling manually though.

@zulipbot claim