Allow empty draft messages

Details

Previously, draft messages could not be empty as this value was used to indicate that a draft does not exist, leading to undesired behavior.
This PR allows drafts to be empty.
Fixed Issues

$ https://github.com/Expensify/App/issues/25488
PROPOSAL: https://github.com/Expensify/App/issues/25488#issuecomment-1684067167
Tests

Open any report
Post a message
Press the Edit button in the newly added message
Empty the draft message input
Navigate to a different report
Return to the first report
Verify that the draft message input is empty

[X] Verify that no errors appear in the JS console

Offline tests

Open any report
Post a message
Press the Edit button in the newly added message
Empty the draft message input
Navigate to a different report
Return to the first report
Verify that the draft message input is empty

QA Steps

Open any report
Post a message
Press the Edit button in the newly added message
Empty the draft message input
Navigate to a different report
Return to the first report
Verify that the draft message input is empty

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/137707942/ecc8b879-6f99-4fea-b83c-c27cb7cc1ca9

Android: mWeb Chrome

https://github.com/Expensify/App/assets/137707942/7eb85505-86a3-4a16-a7b8-ede3d767cfd9

iOS: Native

https://github.com/Expensify/App/assets/137707942/d0463aef-a448-497d-a51c-8c2d17dd5d96

iOS: mWeb Safari

https://github.com/Expensify/App/assets/137707942/8f3798f0-4a41-41a1-9104-99b4259e3c6d

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/137707942/88fa26a5-3ec4-49cf-bef4-cd4db8ab758b

MacOS: Desktop

https://github.com/Expensify/App/assets/137707942/e91f7d62-d25b-4584-963c-0ea5c8d4202f

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.21-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


vertcoin core does not work. Progress 0.00% Progress increase per hour 0.01% its been running all night.

This issue tracker is only for technical issues related to bitcoin-core.
General bitcoin questions and/or support requests and are best directed to the Bitcoin StackExchange.
For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/.
Describe the issue
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
Screenshots.
If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.
What version of bitcoin-core are you using?
List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.
Machine specs:

OS:
CPU:
RAM:
Disk size:
Disk Type (HD/SDD):

Any extra information that might be useful in the debugging process.
This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

When you go to Help > Debug window > Peers, do you see any peers listed there?

No response by poster for a month. Assuming resolved.


pkg/api/norman/customization/cluster: fix dropped error

This fixes a dropped error in pkg/api/norman/customization/cluster.

Looks good. Thanks for the contribution!


Acoustic event detector

Hi guys,
This is our universal acoustic event detector. Correct operation still depends on the ADC driver though.
Currently, all source files are copied-and-pasted from another debugging repos (https://bitbucket.org/longle1/gcwa) and laid out flat to build with the default Makefile. I could use some help with the Makefile to reorganize the code and avoid copy-and-paste everytime there's an update in the original repo. :)
Thanks,
Long

This is cool! I guess the goal is to eventually either ship events out over the radio or use this as a library for a larger application that uses the events as a signal to start doing other processing?

Hi Amit,
Thank you so much for your time and patience with my first pull request! I really appreciated your guidance.
Yes, my current goal is to ship events out of the Signpost for more processing. In my experience on the Android platform, the right way to do this is to write detected events down to a local storage queue, and depends on a "Network/Communication Manager" to clear the queue/ship events off the board depending on the network state/energy availability. Thoughts?
The event detector you see is indeed a subroutine/library in a larger processing chain. ;)


frontend testing.md translated

Thanks for the translation! Please fix the formatting in development/frontend/testing.md.


Enter submits form in Firefox

I'm using a multiselect instance of Choices, within a <form>. When I select a choice by pressing Enter, Firefox will automatically try and submit the form.
An example in a Codepen: https://codepen.io/drweissbrot/full/QJGqGj/
The console mentions ReferenceError: event is not defined in https://github.com/jshjohnson/Choices/blob/master/src/scripts/choices.js#L1258.
Everything is working properly when clicking to select a choice.
This appears to only be a problem in Firefox, everything is working fine in Chrome. I'm using Choices 4.1.1 beta, the problem also persists in 4.1.0.

I am seeing the same thing.  As a temporary work around I'm using this jQuery to disable all form submit with Enter
    $(document).on("keypress", ":input:not(textarea)", function(event) {
      return event.keyCode != 13;
    });

Thanks! Had to make some changes since I don't use jQuery, but it seems to work.
Obviously not a permanent solution though :/

Yeah this is a bug - will investigate 👍

This has been resolved in version 4.1.2. Thanks 👍


Update latest jdk8 version to 152 release

I just realised, @srsp doesn't (publicly) seem to quite have a lot of activity on GitHub, apart from the time where he forked this from William Yeh (back in June). I'm worried it might be abandoned again. I'm going to give it a week - if there's no movement on this PR, I'll fork this again (and I suppose set a weekly cron build in Travis).
@srsp 👋


Ensure reference and moving layers are different

Using the default ComboBox widget, initially, the selected reference and moving
layers are the same layer (the first layer in the layer list). This means that
if the user is not very careful, they will be aligning that layer to itself,
which is confusing behaviour in affinder. It's also poor default behaviour.
With this PR, a callback is created in selecting a layer in either ComboBox
ensures that the other ComboBox contains a different layer.
With great thanks to @tlambert03 for excellent docs at:
https://pyapp-kit.github.io/magicgui/events/#connecting-to-events
particularly for including the magic_factory tab. 😃

Codecov Report

Merging #69 (d1cbc06) into main (132dd2b) will increase coverage by 2.73%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   82.97%   85.71%   +2.73%
==========================================
  Files           4        4
  Lines         141      168      +27
==========================================
+ Hits          117      144      +27
  Misses         24       24

Impacted Files
Coverage Δ

src/affinder/_tests/test_affinder.py
100.00% <100.00%> (ø)

src/affinder/affinder.py
91.83% <100.00%> (+1.59%)
:arrow_up:


#[changeset_for] codegen issue

Trying to use #[changeset_for] for the struct:
#[changeset_for(users)]
pub struct UserChanges {
    id: i32,
    first_name: Option<String>,
    last_name: Option<String>,
    email: Option<String>,
}

Produces the error:
src/main.rs:33:24: 33:24 error: the trait `diesel::query_source::Queriable<(diesel::types::Integer, diesel::types::VarChar, diesel::types::VarChar, diesel::types::VarChar)>` is not implemented for the type `UserChanges` [E0277]
src/main.rs:33 #[changeset_for(users)]
                                      ^
src/main.rs:33:1: 33:24 note: in this expansion of try! (defined in <std macros>)
src/main.rs:33:24: 33:24 help: run `rustc --explain E0277` to see a detailed explanation
error: aborting due to previous error

However, adding #[derive(Queriable)] to the struct annotation raises the error:
src/main.rs:34:24: 34:24 error: the trait `diesel::types::FromSqlRow<(diesel::types::Integer, diesel::types::VarChar, diesel::types::VarChar, diesel::types::VarChar)>` is not implemented for the type `(i32, core::option::Option<collections::string::String>, core::option::Option<collections::string::String>, core::option::Option<collections::string::String>)` [E0277]
src/main.rs:34 #[changeset_for(users)]
                                      ^
src/main.rs:34:1: 34:24 note: in this expansion of try! (defined in <std macros>)
src/main.rs:34:24: 34:24 help: run `rustc --explain E0277` to see a detailed explanation
error: aborting due to previous error

Halp

You'll need to use two different structs for that use case. (Which makes sense if you think about it, you don't want to have to deal with options for reads, when you know the field is always present)

(I might eventually be able to support reading a non-nullable field into an option, but at the moment coherence prevents it)

I'm totally fine to (and prefer to) use separate structs for changesets and queriable, but the first error comes from just using #[changeset_for(users)] on the UserChanges struct

Oh, whoops!

^----- That commit probably also makes save_changes way more useful for your use case as well

Definitely, that's awesome!


PostgreSQL Server logs - Small changes

@andresnava : Thanks for your contribution to the Azure documentation! The author, @SaloniSonpal, has been notified to review your proposed change.

#sign-off


Im preparing a mega update ! If you love potatoes, read this !

Eh guy ! I will make an update(lol). When the bot found a certain cell with a certain name, the bot suicide in this cell !
I'm creating the best free bots ever :) (after botme.ga lol)

@camilleeeyres Easy todo but noone thought about it...  Nice idea congrats...   Ad  an option in config.js for cell name to suicide into.

Useful only if you dont have bots running on your ip..   Otherwise you couldnt play..   But just doit as its very useful for me and others if you for ex.  Have a vps   :)

Traduire
Non, les TOUS les robots ( y compris des autres ) seraient attires vers nous, et seulement les developpeurs know le nom "magique"
No, ALL robots (including others) would be attracted to us, and only the developers know the "magic" name.
You do a lot of stuff, it's a way for the users to "pay" we.

lol I made BotMega

@MasonBurdette Its down   I also had X10Hosting but its shit...  They deleted all my files without any warning and support refused to get them back  (fortunately I had an old copy of the code) Not Agar related...   So just leave them and get a free vps on aws free tier..   You can also get 100$+ credit on GitHub student pack for vps...

nah I have an ovh node, I'll just host it on that.

I have an OVH vps too... Now the bot will follow all cell named "𝓦𝔦𝔷𝔞𝔯𝔡" !

𝓦𝔦𝔷𝔞𝔯𝔡

Nice


Adjust Storage dropdown titles for new layout of providers.storage.

They were all 'undefined' before.

Thanks @douglaselee! We found this one in testing as well. I am making the change to formiojs on this one.

Thanks for fixing @travist!


Add URL Shortening Microservice

Fixes #1003
PR is still a WIP.
Introduction
Adds an in-house micro-service to shorten long urls from the playground. The URL shortener is YOURLs. Currently, this is deployed to a custom AWS instance for testing purposes.
The playground share button now looks like this:

GIF of how it works with the meta-circular evaluator programme:

You may notice that the domain of the shortener is currently http://ec2-18-140-69-106.ap-southeast-1.compute.amazonaws.com (this is my own AWS server). This should be swapped out for a custom domain from NUS!
How it works
Nothing fancy. The YOURLs php service is deployed on a custom AWS instance. The frontend makes a API call to the service to retrieve a short url. The urls are stored in MariaDB MySQL database.
There is also an admin dashboard available to show the urls in the database.

Changelog
Small frontend changes namely:

playground component and container updated
sharebutton component updated
new saga added

Remaining TODOs:

[ ] improve error handling
[ ] update authentication
[ ] basic tests
[ ] discuss on deployment of actual AWS instance with domain

Pull Request Test Coverage Report for Build 4879

10 of 36 (27.78%)  changed or added relevant lines in 7 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 37.056%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/reducers/playground.ts
1
2
50.0%

src/containers/PlaygroundContainer.ts
0
2
0.0%

src/components/workspace/controlBar/shareButton.tsx
1
6
16.67%

src/sagas/playground.ts
3
21
14.29%

Files with Coverage Reduction
New Missed Lines
%

src/components/workspace/controlBar/shareButton.tsx
1
25.0%

Totals

Change from base Build 4873:
-0.08%

Covered Lines:
2905

Relevant Lines:
7009

💛  - Coveralls

Requesting preliminary UI / feature review from @martin-henz and @blackening

Looks good. There is a complication though. We have been playing with the idea of multiple deployments of the Source Academy, for different purposes. Currently we have:

https://sourceacademy.nus.edu.sg/ for CS1101S, and
https://source-academy.github.io/playground for the general public, including readers of SICP.

With this feature, we would establish a de-facto default playground: the URL used by the share feature.
If we want to be a bit more fancy, we could let each deployment generate its own URLs. So if you share a program in
https://source-academy.github.io/, the URL would go to
https://source-academy.github.io/...
and if you share a program in
https://sourceacademy.nus.edu.sg/ , the URL would go to
https://sourceacademy.nus.edu.sg/...
I think for this, it would be acceptable, if the short names are globally distinct so that we can still use a single URL shortening service.

Yup we discussed on this and reached a consensus!
This share service will behave similar to tinyurl/bit.ly. So regardless of where you call it from (staging/prod), it will give the same domain. We are looking to make it share.sourceacademy.nus.edu.sg/<alias>

Yes, we have a consensus on this: same short urls, and the actual long links take the user back to deployment where the link was generated.

A small issue that I raised: The color of the popup in case the link exists already should be green and not orange.

@martin-henz yup this has been fixed already, try it out at https://source-gpu.herokuapp.com/playground


Get current time in millisecond (Android)

currentTime() method in Android returns result in second.
Is there any way to get current time in milliseconds(immediately) ?

I'm not positive on how to do it with react-native-youtube because this repo didn't build for me. I had to use react-native-youtube-sdk.
For that repo, I went to "C:<project_dir>\node_modules\react-native-youtube-sdk\example\lib
and in the file 'YouTubePlayer.js' I edited line 48
from...
".then(currentTime => resolve(Math.round(currentTime)))"
to...
".then(currentTime => resolve(currentTime))"
I hope this helps.

@bmike712 why not multiply by 1000?


Dependencies cannot be resolved, so the UserScript cannot be installed.

This happens because rawgit has gone down; the relevant GitHack URLs for the two dependencies that were linked from rawgit are

https://raw.githack.com/eligrey/FileSaver.js/master/dist/FileSaver.min.js
https://raw.githack.com/Frug/js-bbcode-parser/master/bbcode-parser.js

Okay, the issue should be resolved now. To be honest, I'm surprised that people are still using this script and it isn't a (completely) broken mess

Unless someone has an archived version of this gist, the script is broken: https://gist.githubusercontent.com/tilmanpotthof/8549286/raw/f1c0e68547e2f03af1ae84720ec524ad4e54e40c/intercept-function.js
It looks as if @tilmanpotthof is no longer on GitHub Gists.


feat: lossless sampling

That appears to be a good perf win, especially in the 10000 rows case. :+1:

This broke into 2 smaller PRs so closing for now.


Updated CSS naming

This PR updates the CSS names to match typical naming conventions.

I'm learning the tools, and I think I can do a squashed merge once the syntax changes are backed out, so you can do that in this same PR if you like.

Yep, you're right. Totally didn't notice that. Just committed again so you can squash and merge.

I just tested this change and it appears to work fine.
LGTM, I'll merge it momentarily.


Decimal tweaks

[x] Rename Decimal.from_string to Decimal.from_text.
[x] Add a dec function to top level namespace
[x] Integers are automatically converted to decimals when used in decimal operations
[ ] Arithmetic Decimal operations between a decimal and a float should throw an error
Equality
[x] Should promote the float to a decimal and attach a warning (saying best to use decimals
[x] Comparison Perform the comparison between the decimal and the float; Attach same warning as equality.

#10517 does not implement errors for mixed float/decimal arithmetic. There are a few options, none of them acceptable yet:

Keeping from conversions between Float and Decimal means that Floats are promoted to Decimal transparently for all arithmetic operations, making it impossible to throw an error in these cases (without undesirable special cases engine hacks).
Removing from conversions means that equality between Floats and Decimals cannot be accomplished (without undesirable special cases engine hacks), since equality is implemented as a builtin and only uses EqualsSimpleNode and from comparisons.
Promoting warnings to errors in arithmetic operations would surely make them much slower.

Closing, as I've moved the error task to #10631


Drawing is wrong when selecting a text block

Modify Colors\Default.js as below:

SET "SelectionForeground":"clNone"
Remove BOLD from Method style
Run Demo project
Select a block like attachment

Hmm, I don't get this...

But I see another problem with the green color. Maybe related...

In Monokai.json, line 135
        "Name":"Method",
        "Foreground":"$00EFD966",
        "Background":"$00222827",
        "Style":"Italic" -> remove this line

Actually methods are in italic...

I mean: if you want to reproduce my issue, you should remove this line: ""Style":"Italic"

Fixed.


Improved startup performance

Removed calls to compinit in bundler.plugin.zsh and extract.plugin.zsh, resulting in much improved startup times - from an average of about 3 seconds to an average of about 0.2 seconds on my FreeBSD 9-STABLE system.
I have tested both plugins, and they seem to work correctly.

Sorry. Got it wrong again.  That would keep your commits separated when you open pull requests.
BTW, sorry for the noise on the issue.

@lucapette Thanks - I had more or less arrived at that conclusion myself, but it's good to have in confirmed by someone less clueless than myself! Apologies for the inept blunderings.


fix(IssueCredentialService): check if requested framework credential already exists

Description

In the service layer, a new validation has been added that checks if a framework credential already exists with the same credential subject type for the requested holder. If the credential is present, a DuplicateCredentialProblem is thrown, else a new credential is issued.

Resolves #258
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@borisrizov-zf we don't have any specific document that mentions the need for a unique FrameworkCredential.
However, as per the current flow in Catnena-X, we are issued a framework VC once we sign contract with the customer (customer requests FrameworkCredential using the portal UI, that the portal admin accepts. Once the request is accepted, we issue the requested VC).
In the portal it is not possible to request same type of VC multiple times (same as membership and dismentaler VC). So owing to the current scenario, all CX type of VC must be issued once.
We can think on re-issuing of the VC if the VC has expired or has been revoked.

@neha-smartsense please rebase and i can merge.

@neha-smartsense Please rebase using the develop branch. That one has been updated and is the active development branch.

Hi @borisrizov-zf, I have rebased using develop branch and also updated the base branch of this commit to the same.

This is no longer valid to align with issuer component changes, I think we can close this PR

@nitin-vavdiya Ok, thank you for the update. I'll close for now.


Nk is 5 2

Three more! Note that I added a missing word to the first_line of four-i.

Okie doke, Markdown files now ignored.

Thanks again.


[Naver TV] HTTP Error 400: Bad Request

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Singapore
Provide a description that is worded well enough to be understood
Unsure of what is actually causing the error. Naver TV used to work fine.
I don't have Naver TV account to attempt cookies. Requires Korean SSID
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp https://tv.naver.com/v/28934837 --verbose --ignore-config
[debug] Command-line config: ['https://tv.naver.com/v/28934837', '--verbose', '--ignore-config']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-nightly-builds [0b6b7742c] (pip)
[debug] Python 3.12.6 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 3.0.15 3 Sep 2024)
[debug] exe versions: ffmpeg N-117825-g970d57988d-20241118 (setts), ffprobe N-117825-g970d57988d-20241118, phantomjs 2.1.1
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.45.3, urllib3-2.2.3, websockets-14.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Plugin directories: ['C:\\Users\\User\\AppData\\Roaming\\yt-dlp\\plugins\\yt-dlp-ChromeCookieUnlock\\yt_dlp_plugins']
[debug] Loaded 1837 extractors
[Naver] Extracting URL: https://tv.naver.com/v/28934837
[Naver] 28934837: Downloading JSON metadata
[Naver] 28934837: Downloading JSON metadata
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec, channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 28934837: Downloading 1 format(s): HLS_2160P
[debug] Invoking hlsnative downloader on "http://b01-kr-cdn.vod.naver.net/navertv/a/read/v2/VOD_ALPHA/navertv_2022_08_31_1327/hls/2f24b263-292b-11ed-a41b-48df37269fd0.m3u8?_lsu_sa_=6b954cf8c18761465fdb55c064157abe1e1036d837043fc132d754c957293795b02a3a2060c50700c09838b27e3a6bb1a6406e1b7635e0bae906f1d7ed5df25735417894260ce0fabb3fdf9ff85426d93fac7925a049296ffcbfe1b0b9e6422244c4d1dfd2c9c7f98afbd7f7914312c2d90d0adeebf1166804f5a1b8161bae3a15234374601fd74355703e0e452fcc32"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 193
[download] Destination: 레이싱모델 송주아 직캠 원신 유라 기본 코스튬 코스프레 서울팝콘 Cosis 코스이즈 부스 [28934837].mp4
[debug] File locking is not supported. Proceeding without locking
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (1/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (2/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (3/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (4/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (5/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (6/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (7/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (8/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (9/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 1 (10/10)...
[download] fragment not found; Skipping fragment 1 ...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (1/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (2/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (3/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (4/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (5/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (6/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (7/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (8/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (9/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 2 (10/10)...
[download] fragment not found; Skipping fragment 2 ...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 3 (1/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 3 (2/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 3 (3/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 3 (4/10)...
[download] Got error: HTTP Error 400: Bad Request. Retrying fragment 3 (5/10)...
...

as a workaround, try passing -S proto:https


Investigate capturing in a separate process and exposing the frame buffer with Python 3.8's shared memory capabilities

Probably better to escape the GIL at the library level rather than placing the burden on the user.
This wasn't initially considered because the performance loss of IPC with serialization/deserialization steps would have been too important.
With Python 3.8's shared memory capabilities, it might be possible to copy the frame to the main thread with very little overhead and therefore be able to process it without the overhead having to run on the same CPU core.

Wow 3.8 has great capabilities!

mmap might also be a good candidate. In my test it is even slightly faster than shared_memory, and with much more supported versions.

Hey @nbrochu , thanks for your great library and haven't seen you for a while! I utilized some of d3dshot when creating my own deep learning pipeline (prototyping in python) and came across this issue. I have utilized shared_memory in python3 to re-write the capture in a separate process while maintaining all the functionalities using a shared ring buffer. The performance improvement is significant compared to the old thread+deque. If you are still maintaining this library I would be happy to do some clean-up and make a PR. I am also investigating the windows.graphic.capture api. If you are not actively maintaining anymore I can take ownership/do some maintainance for the repo. d3dshot is a well-considered and solid library with no substitutes available right now. (huge props 2 u)


Towards Unified Editing

Meta issue to track all the issues for unified fluid editing.
Multiple features to create the next generation of unified editing:

[x] All ACE editing, #48
[x] cursors moves fluidly between cells, done.
[x] change modes using keyboard, done: #50
[x] Split/Merge/Delete: currently only delete supported, #52
[ ] Allow line numbers to continue? Might not be important or easy
[x] Layout and formatting.

This seems pretty much done.


Can StringTie --merge be used to create a slightly improved reference annotation?

Hi
The official dog gtf annotation on Ensembl V100 is missing some important genes. Interestingly, Ensembl also holds two other dog annotations, based on 2 different breeds.
I would like to 'improve' the official dog gtf by merging it with the other two gtfs. I have tried using StringTie to do this, based on the following command line
stringtie --merge -p 10 -v -o stringtie_merged_withref.gtf -G Canis_lupus_familiaris.CanFam3.1.100.chr_sorted.gtf input_gtf_list.txt
So I have the reference Ensembl annotation as an argument for -G followed by a list of the other gtf files to add.
The problem with this is that it'll discard all gene entries and only leave entries of type transcript or exon.
Any help/suggestions on how to do this properly appreciated

Don't use stringtie --merge for this purpose, that feature was designed for merging multiple stringtie outputs, not generic annotation data. It can lead to losing some isoforms from the annotation by "assembling" overlapping/compatible isoforms together and in most cases you do not want that kind of data loss.
gffread (http://dx.doi.org/10.12688/f1000research.23297.1) would be a better choice for merging multiple annotations by reducing redundancy across multiple datasets, in a more conservative and controlled way. Take a look at the "Clustering" options of gffread (-M/-K/-Q) to control the merge process.
However gffread won't solve the problem of losing gene entries, those are still going to be lost in the process of merging data from multiple annotation files. The gene entries cannot be preserved practically if you merge two or more transcripts (from different annotation files) that have a different gene ID. gffread can however generate locus features during clustering, which also shows all the genes and transcripts that were merged/gathered in the same locus. One can easily transform those locus features into gene features. (gffread would group under the same locus all the transcripts linked by exon overlaps, which is how gene features are generally defined). We can discuss more about this in the gffread github (https://github.com/gpertea/gffread) issues section there, perhaps.

Thanks so much for the speedy reply -  will gladly test gffread and let you know how it goes for this on its github repo if needed!

Hi, did anyone test using gffread to improve annotation? How is the result?
thanks,
Cui

@gpertea  Hi I am trying to use gffread to  improved axolotl reference annotation. But when I read a paper(https://www.ncbi.nlm.nih.gov/pmc/articles/PMC7222033/) said,"While GffRead can convert, sort, filter, transform, or cluster genomic features, GffCompare can be used to compare and merge different gene annotations." I am kind of confused which one I should use improved axolotl reference annotation? Looking forward to your reply. Thank you in advance.


Integrity error on submodel add

When using SubAmdin with a related model with unique constraints IntegrityError is not correctly catched and reported, causing an internal-server-error.
This does not happen when using default admin.
Configuration
models.py
from django.db import models

class ModelA(models.Model):
    foo = models.CharField(max_length=16)

class ModelB(models.Model):
    parent = models.ForeignKey(ModelA, on_delete=models.CASCADE)
    foo = models.CharField(max_length=16)
    bar = models.CharField(max_length=16)

    class Meta:
        unique_together = (('parent', 'foo'),)

admin.py
from django.contrib import admin
from subadmin import SubAdmin, RootSubAdmin
from .models import ModelA, ModelB

class ModelBSub(SubAdmin):
    model = ModelB

@admin.register(ModelB)
class ModelBAdmin(admin.ModelAdmin):
    pass

@admin.register(ModelA)
class ModelAAdmin(RootSubAdmin):
    subadmins = [ModelBSub]

Step to reproduce

create an instance of ModelA
add to that an instance of ModelB
add an other instance of ModelB with the same value of foo using sub-admin

an IntegrityError should be thrown with a 500 response

add an other instance of ModelB with same value of foo using normal admin

no error is thrown, duplicare-constraint error is shown on UI

This is caused by the way relations are added to sub-admin:
https://github.com/inueni/django-subadmin/blob/e4a15b3f1c3ffe2d4e9020e2e7ac2a6518cd2dbc/subadmin/__init__.py#L201-L205
Foreign key is added in save_model method, which is called after validation, thus causing IntegrityError if any unique_together which involves foreign is defined.
This could be solved by overriging get_form (or some form-related method) and force relation here.

Thanks for reporting this issue. I see you opened a pull request, so let's continue this discussion there.

Thank you @sevdog for reporting this issue and also providing a fix.
For anyone coming across this issue, since this slightly changes how subadmin handles saving related PK field to instance, there are some side-effect in rare circumstances, see Caveats in README for details.


chore(e2e): run tests against Firefox 86 on macOS Catalina

AngularJS is in LTS mode
We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes

What is the current behavior? (You can also link to an open issue here)

e2e is only run against Firefox 76 which is 14 months old on a 2 yo OS (macOS Mojave)

What is the new behavior (if this is a feature change)?

e2e is run against Firefox 86 on macOS Catalina

Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[x] Fix/Feature: Docs have been added/updated
[x] Fix/Feature: Tests have been added; existing tests pass

Other information:
This is expected to break due to https://github.com/angular/angular.js/issues/17117.

This verifies #17117 as there are many Failed: Error while running testForAngular: Timed out after 30000 ms in the e2e tests.
It doesn't look like we can test against and verify compatibility with Firefox 86-89.


view_channel permission alias is not supported

Hello,
Should I write chan.set_permissions(role, view_channel=True, connect=True), which works perfectly when executing, mypy is not happy at all : error: No overload variant of "set_permissions" of "GuildChannel" matches argument types "Role", "bool", "bool".
If I replace view_channel by its alias read_messages, mypy works fine.
While the workaround is perfectly acceptable, it would be nice if discord.py-stubs supported the alias.
Here is a link to the discord.py documentation for reference: https://discordpy.readthedocs.io/en/latest/api.html#discord.Permissions.view_channel

Thanks for the report. I've updated the Permissions and GuildChannel.set_permissions() typing and will make a new release later today.

Version <IP_ADDRESS> (which includes this fix) has been released on pypi


sql highligher is confused by comment ON CONSTRAINT "email is

Issue Type: Bug
VS Code version: Code 1.35.1 (c7d83e57cd18f18026a8162d042843bda1bcf21f, 2019-06-12T14:30:02.622Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2208)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.82GB (5.05GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

love
bsc
0.3.6

vscode-autohotkey
sle
0.2.2

lua
sum
0.9.12

Steps to Reproduce:

Make an sql file.
Insert this text: COMMENT ON CONSTRAINT "email is unique" ON public.users  IS 'snip';
See that the first " character is ignored, and that the ending of the file is styled as if it's a comment.

I first noticed this in a way larger sql file, and this is as small as I could get the string where the issue still occurs and is visible.

Does this issue occur when all extensions are disabled?: Yes
Restarting code also does not fix this.
Image of the issue: https://i.imgur.com/dGRragH.png
When you remove is from the part of the string that should highlighted as string it get's even weirder. And the formatter seems to ignore two quote characters.
https://i.imgur.com/JmwowhK.png

Moved to owning repo.


max line limit

Greetings,
the DocumentView has a limited amount of lines when ext:documentView_textFormat="formatted" is selected. Can't increase the maxLine.

ext:documentView_cacheConfig="no_cache" parameter fixed the issue.


Any plan to release next version v1.4?

36 commits to master since v1.3 release.
benchmark result: https://github.com/the-benchmarker/web-frameworks

@julienschmidt is there anything the community at large can do to help w/ releases?

@jehiah v1.3 version has poor performance.

@appleboy sorry i wasn't meaning to co-opt your issue; If you intended this issue to document a specific performance issue i didn't read it that way.

@jehiah I know that. I already update my previous comment.

What else is hanging up the 1.4 release?

Pay attention，when v1.4.0 or new version will be released？


Plugin not working - Edamagit

As suggested in the release notes, I've found a plugin that does not seem to work (or I might be doing something wrong).
Link to plugin repo https://github.com/kahole/edamagit

Any update on this? None of the extensions features seems to be working.

Any update on this? None of the extensions features seems to be working.


draw.io: use standard UML elements

It seems there is hard dependency on the plugin for the VScode draw.io (3rd party) plugin.
My goal was to use the draw.io desktop version, however, I found out I had to use specific styling of the elements, especially for text events in the container elements. There is a dependency like gradientColor, strokeColor etc.
Is such a dependency really necessary? It seems the desktop version draw.io can not be extended with the plugin, right?
Any chance to support standard UML elements directly provided by draw.io (perhaps More Shapes -> Software ->UML 2.5)?
Thanks.

Right now, you can use draw.io without any special shapes as long as the node labels match what StateSmith is expecting. This is similar to how the yEd diagrams are drawn. You can actually download the below svg and rename it back to Tutorial1Sm.drawio.svg to allow draw.io to edit it. It works with StateSmith.

You can also copy the StateSmith shapes from this online template if you want.
More info here if you haven't seen it yet: https://github.com/StateSmith/StateSmith/wiki/Getting-started-using-draw.io-with-StateSmith
UML 2.5 shapes
I wasn't aware of these! Thanks for pointing them out. Is there a good shape for composite states? Something like ON_GROUP in the image below?

Would you be able to share a sample diagram that you would like to use and then we can figure out a way of parsing it with StateSmith?

We need to keep at least some of those styling restrictions so that we can parse the diagram reliably.
In the draw.io xml file, text nodes and shape nodes can be basically the same thing. StateSmith needs some way of knowing that the text belongs to the parent and isn't a nested state.
The below styles ensure that the text node doesn't look like a state node:
fillColor=none;
gradientColor=none;
strokeColor=none;

We could relax the validation though. Instead of making sure that all the above are all set to none, we could also accept if there was no style for them.
We could potentially relax the below restrictions as well.

resizable=0;
movable=0;
deletable=0;
rotatable=0;

The main thing I wanted to prevent was diagrams with the behavior code in strange places:

I think initially, we could add a flag in DrawIoSettings.cs like
public bool relaxTextEventHandlerValidation = false; // opt-in for now

Thoughts?

I totally understand you need to be able to distinguish among the elements.
I have no further thoughts. I was just wondering if it was possible at all to eliminate the need for the plugin by using the already provided UML 2.5 elements.

I like the idea of it. I'm thinking we could start with the basics:

[ ] recognize regular circle shape as initial state without needing the label $initial_state
[ ] recognize rhombus/diamond shape as choice state without needing the label $choice
[ ] recognize circle with "H" label as shallow history state
[ ] implement relaxTextEventHandlerValidation as discussed above

Any interest in helping me?

Unfortunately, I don't have any spare time to help with coding nowadays. Sorry :(
I investigated the UML 2.5 elements in drawio though... some hints...
shape=ellipse: either "junction" or "initial" ... distinguish programatically (junction must always have an incoming transition, initial shall not have an incoming transition)
ellipse with value=H: shallow history
*ellipse with value=H **: deep history
rhombus: always a choice point
shape=mxgraph.sysml.actFinal: final transition
shape=mxgraph.sysml.simpleState: only suported state state (can be turned into composite state by enabling Container property)
regions: ?

This page has some good info we could look into supporting: https://www.diagrams.net/blog/uml-state-diagrams


cannot find the reqired file C:\Users\ssh\Documents\Visual Studio 2017\Projects\simple-music-player-dev\src\SimpleMusicPlayer.Tests\bin\Debug\SimpleMusicPlayer.Tests.dll file

it gives this error when i want to make a setup of it with Advanced installer 12.8 :
cannot find the reqired file C:\Users\ssh\Documents\Visual Studio 2017\Projects\simple-music-player-dev\src\SimpleMusicPlayer.Tests\bin\Debug\SimpleMusicPlayer.Tests.dll file

@great-ssh I really don't know how this installer works and how do you compiled SimpleMP...


look at sia bbolt modifications

Sia modified the vendored bbolt like in commit ec535f7c2a0b5bad406779309c2eb5232f068204

OK, so there are 2 things. First of all, I seem to have vendored a pretty old version, from 2016, not sure why golang/dep vendors that version by default. So we'll have to sync with master first, as Sia is up to date with latest master.
The commit you mentioned seems to be the only commit in which they've modified the vendored version (on a sidenote, they only vendor dependencies when they modify them, so we might want to check the other dependencies as well, I'm not a big fan of modifying the vendor dir though, as such changes can be easily overwritten, I would prefer a vendored fork instead).
In that commit they claim to have simply added a MmapError to indicate the mmap'ing of some data failed, however, they are also doing some extra mmap'ing back to the minimum required size prior to that. We'll have to investigate why they did this second part of the change, even though the comment also explains a bit.
The MmapError they use in the consensus to indicate the system is out of memory. So for now we don't really need it. We could resolve this issue together with #85.

I'm not a big fan of modifying the vendor dir though, as such changes can be easily overwritten, I would prefer a vendored fork instead).

same way I feel about it

In 1.0.1, we'll fork bbolt, and apply the changes there. We could try get it upmerged if it makes sense. For now we should leave it as it is. See #218 for more info.


Update README translation of Portuguese Brazil

I did some corrections on words and adjusts phrases for better understanding while reading.

@PabloNunes when you have a chance, could you review this translations PR? Thank you!

@satirioneto.  Before merging, you need to agree with the CLA first. Look at the checks on the repository.

@saragibby the PR submitter needs to approve the CLA.
Retagging @satirioneto to approve the CLA before merging.

@microsoft-github-policy-service agree


Google Form API ( getValidtors of an item)

Hi,
Is there a way to get the current validations I assigned on a item?
Example:
let form = FormApp.openById('1234567890abcdefghijklmnopqrstuvwxyz');
let item = form.addTextItem();
.......
.......
let validations = item.getValidations();

Currently there is no way to getValidations: https://developers.google.com/apps-script/reference/forms/text-item
File Apps Script bugs on the bug tracker instead of this sample repo:
https://developers.google.com/apps-script/support#bugs
This bug also states this issue. You can press the star it to +1 it:
https://issuetracker.google.com/issues/72151985


What is the best rate for downloading followers/followees?

I was hoping we could discuss rate limits for downloading followers and followees from profiles. In my experience, I am able to download most structures without ever getting blocked simply be relying on the default RateController. But when downloading followers, while I don't get 429 errors, I frequently experience other problems like having to chance password, confirm in the app using their face-check, two factor auth with phone number etc.
If others are experiencing this too, I was wondering if it might be useful to think about having a separate rate control mechanism for these types of harvests. This could also include setting the _graphql_page_length to something other than 50. Has anyone found a rate at which they could avoid these issues and keep a continuous download stream going on the followers of many profiles? My best result so far has been in simply sleeping for two hours between every 5000 downloaded followers, and then again for two hours each time a profile completes.
Of course, since it doesn't actually seem to be the rate limits and 429 errors that are causing the problem, but rather that Instagram seems to think my accounts are being hacked or that I am using some service to get more followers or something, are there other things one can do to avoid this, such somehow using the Instagram service more organically from that account? Or is it simply a matter of reducing the amount requests made? Thanks for the help.

Your account will be banned more and more frequently. At some point you will have to activate it via video call.


add vehicle data

Codecov Report

Merging #37 into master will decrease coverage by 1.23%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage     100%   98.76%   -1.24%
==========================================
  Files          29       30       +1
  Lines         632      650      +18
==========================================
+ Hits          632      642      +10
- Misses          0        8       +8

Impacted Files
Coverage Δ

vehicle.go
55.55% <55.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f3f88...4f1ba39. Read the comment docs.

Holy cow! Nice Job!
First time someone was able to just jump in and add something with full examples and benchmarks with 100% coverage.
Would love to know why you needed vehicles but its so nice and perfect that ill add it just cause.

Thanks, glad to contribute.
I use your package in a continuous feed (data generator stream) for a fleet system, so having this data makes sense for my use case.
I really appreciate this package, you've done a great job!

I bumped the repo version to v3.15.0 in case you use version control

I just notice on your vehicle list the model array is all in upper case. for consistency sake can you update that to be title case?

Alright #38


Kubernetes SD: Add endpoints role to API servers job to actually discover some API servers

Previous PR forgot to add endpoints role... Sorry about that!
Ref #2175 - ping @Priyanka098.

I'll give it a run in a bit, busy right now, but should get to it soon.

@brancz Had a chance to try this out?

Completely forgot, thanks for reminding me. Trying now.

Config works. LGTM 👍
One nitpick, but we can address this in another PR and/or discuss first. The node scrapes fail due to cert problems, we've seen this for a while, but I feel that ignoring invalid certs in a default config seems like we're not being a role model, plus there are two ways to solve it: ignore cert issues or relabel kubelet scrape targets to 10255 instead of the discovered 10250. Which one is better?
Either way you have my 👍 so we at least have a working/starting config that we can improve along the way.

Yea, having this fix in is better than not.
We really have to figure out what's the issue with cert validation against the API server. The read-only port is subject to removal and not really an option.


Allow option-selects to send their 'closed state' with their form data

This pull request is aimed at solving an issue found when using option-selects without AJAX.
The problem

the option-select is in a form which posts to its parent page without the use of JavaScript (ie a search results page with option-selects used for filtering)
every time the form is submitted the option-selects do not remember whether they were closed or open when a new version of the page is returned

Why it's only come up now
Option-selects are used on www.gov.uk in pages where, if the JavaScript sent runs, all form submissions use AJAX meaning the option-select HTML is not reloaded so this is not a problem.
How this pull request attempts to solve it
These changes allow option-selects that do not use JavaScript for form submissions to preserve their 'closed state' by sending it in the form data.
A closed_state_name parameter can be added to the component data which is used by the option-select JavaScript to create a hidden <input> tag with that name. This is used to send the 'closed state' of the option-select in the form data.

Any help getting this to an acceptable state much appreciated @fofr, @dsingleton, @quis, @gemmaleigh.

I'm not sure I like that this just wouldn't work if you don't specify that closed state name parameter. Maybe it should be a mandatory or generated value?

I might be mis-understanding but wouldn't it work without that parameter?
I did think of just adding the hidden <input> if you set closed_state_name to the partial data but that seemed a bit odd. Control over the closed state is added by JS so it seemed to make sense to have the communication of that state also added by JS.
Also, the reason I made it optional was because the main use of option-selects at the moment won't use it (because they use AJAX).

If control over the closed state is added by JS then is this code really needed?
What does closed actually mean? Do you have an example link?

By not working I mean the functionality you added only works if that data key gets set.

This could sit outside of this component in a slightly different form (in the project JS of whatever applications use option-selects without AJAX).
My intention in adding it here was to grow the potential uses of this component by allowing a non-AJAX approach to be supported where the code that renders the option-selects can know if the user expects them closed or open.
If the value this adds to all users is worth it I think there's an argument for including it in the existing JS. That's part of the point of this pull request actually, to see if the maintainers feel it's worth adding here.

Maybe I'm mis-reading things but I'm not sure I see what problems could occur from not setting the parameter in the partial data. My intention in having it as optional was to allow users who don't need this functionality to ignore it.

I made a test-page in a copy of the components guide that might be useful:
https://github.com/tombye/option-select-test
The page is at the '/option-select-test' route.
(It assumes you're running a local version of static and running the apps in a VM.)

@tombye Any progress on this, or can I close it?

@fofr judging by this thread it doesn't look like there's a need for this functionality on GOVUK apps so I'm happy for you to close it.
Worth saying if this functionality is of interest to anyone in future, it exists on the Digital Marketplace version (viewable here: http://alphagov.github.io/digitalmarketplace-frontend-toolkit/forms/option-select.html).


refactor client code to eliminate “account” concept and terminology–artifact of FastPay

@patrickkuo / @lxfind - this seems to be resolved. Can we close it out?


fixed broken hyperlink to daviwil.com

Under the website management header in Emacs.org, the link to your personal site currently points to https://github.com/daviwil/dotfiles/blob/master/daviwil.com

Awesome, thanks a lot!


Added a flag that excludes Elementary's models.

This is a requirement.

Don't you think it should be true by default?

I think that most users would want to be able to look at our own lineage when trying to figure out which tables contain information they might be looking for and for understanding how we generally work.


Allow runtime update of cache directory

I need to separate cached requests per user role in our application. I want to achieve this by using separate cache directory for each role: /cache/role1/..., /cache/role2/... Unfortunately there is currently no easy way to update cache directory on cache instance during runtime.
Thus I propose the directory() getter got a setter as well which would flush and close current cache and created new DiskLruCache in specified location.
Feel free to comment on this and if by any chance you find this makes sense I might find time to implement this and send pull request.

You can accomplish what you want with lightweight copies of the OkHttp client.
val client2 = client1.newBuilder().cache(newCache).build()
But you should consider asking this type of question on stack overflow to build the community knowledge base.  We won't add this to the public API.


Adhesion gel is weird when portal exist in certain areas of the world

Video, Because bug is weird its requires a video I cant upload to Github
How? What? Why? No Idea
Only happens when that specific is structure is built and the portals are around the same area (I think)

Seems fixed in 2.1.7
although 1 time I jumped multiple times and it didnt unstick me when I was upside down, but I cant replicate it

Ok, its still weird but not as weird

This has been fixed in dev versions, as adhesion gel was rewritten.
To download a version of the latest build, use this link: https://nightly.link/Fusion-Flux/Portal-Cubed/workflows/build/1.19.2/Artifact.zip


go: stop setting GOPATH

This hook is removed in a1e13f6140a568b73c1c36bb9ef79d7876ccaae3 on staging.
cc @Mic92 @zimbatm

I'll bump it to 1.13.11 as well while we're here.

The hook is removed only in staging because it causes lots of rebuilds (which is what staging is for). It will make its way into master eventually.

When staging merges to master go_1_13 will break as it was readded after the hook was deleted.

I missed that this was for 1.13, oops.
I thought this would have a large amount rebuilds, but I remembered we migrated away from 1.13 (so nothing should be depending on a previously-removed package...). You're right; thanks for correcting me!


Navigation Node Spawning

Navigation Nodes spawn on top of props. The props get iterated over but when the current prop is not in the same location of the node then it marks as false and pushes it back.

Can close this now, it was fixed in https://github.com/Zannark/CollegeProject_SurvivalGame/commit/9f28263366f3a1456e53fd46c07de5651d3d2e36


cannot zoom in/out when using polygon as AOI

Describe the bug
I was trying to create an AOI using the polygon tool in the "planet recipe" and the zoom in/out didn't work, I also tested it on a different environment using the "optical mosaic" and it didn't work either.
To Reproduce
Steps to reproduce the behavior:

open the planet recipe, or any, the problem is spread across all recipes.
select Polygon as AOI tool.
zoom in/out
will fail

Fixed in f4c8366172271bb8545134635bda6ec9ca3babf6.


[WIP] Modify azure-pipelines continuous integration to use Anaconda Python

Over in #525 we are encountering a tricky theano compilation error which can likely be resolved by using Anaconda Python instead of relying on the Ubuntu 16.04 system Python.
This PR attempts to make that change.

This solution appears to resolve the issue encountered in #525.  I'm closing this PR as I ended up merging this branch into #525.


LocalAI Integration

Tracking the individual LocalAI APIs Integration:

[x] (great) Text generation with GPTs
[x] (good) Function calling by GPTs 🆕
[x] (good) Model Gallery to list and install models
[ ] (half done) Image generation with stable diffusion
[ ] (P2) Vision API for image chats
[ ] (P3) Text to Audio
[ ] Audio to Text
[ ] Embeddings generation
[ ] Constrained grammars (JSON output)
[ ] Voice cloning 🆕

See also #451, #477

If I could voice a priority ask, image generation followed by constrained grammar and finally embeddings would be preferred order!

BTW, since localai has all-in-one docker images, it already should support openai-compatable Speech-to-text, image generation with stable diffusion, etc, so, maybe, openai provider code could be reused.
Strong vote for this issue and localai support.


Fix switch-to-configuration-ng on WSL

Description of changes
Fixes #319529

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg test switchTestNg

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4148

@dasj could I get a review from you on this one? I apologize as I realize you're not directly tied to the maintenance of this, but there isn't really any once else I can think of to pull in and review this one.


[EPIC] Streamline/simplify our docker compose

The docker compose for the dashboard and related services is a bit clunky and has some things that aren't needed - like the custom network, and the import of the secondary compose file.
Could also look at moving all environment variables from .env files directly into the docker compose for easier evaluation by prospective deployers. They can be easily moved back out to .env files for production deployments.

[ ] #43
[ ] #44
[ ] #45
[ ] #46
[ ] #47
[ ] #48
[ ] #49

Kerri asks where/how this can all get documented, in README, etc.

Done (complete)


Namespaced bitflag constants?

Would there be any objection to putting all generated consts in a module named after the type? This way, they could behave more like how enums do with variants globbing. It would also prevent documentation clutter in rustdoc, where all the constants are currently listed indiscriminately in the parent module.
Should we allow non-caps in constants so that they're stylistically closer to enums?
The syntax seems to work: http://is.gd/hGgTe7

Thanks for the report! These are actually more appropriate as associated constants, which have no recently landed in the nightly compiler, and this library can switch to using them in the future as soon as they're stable!


Big Pointer/Reference Proposal

These are some changes to simplify syntax and semantics.
Types
@int - raw pointer to int
^int - ARC pointer to int
&int - reference to int

By default, these types are immutable. Mutable variations:
@mut int - mutable raw pointer to int
^mut int - mutable ARC pointer to int
&mut int - mutable reference to int

References, and any type containing references, cannot be returned from functions.
References, and and type containing references, cannot be assigned to a variable declared in an enclosing scope.

Address-of
Raw pointers and referecnes can be created by using the same symbol used in the type as the address-of operator. There is no address-of operator for ARC pointers.
thing := 10;

@thing // raw pointer to thing
&thing // reference to thing

@mut thing // mutable raw pointer to thing
&mut thing // mutalbe reference to thing

Note that you cannot take a raw pointer to a stack variable. You can bypass this restruction like so: raw_ptr := @int(uintptr(&thing));
Dereferencing
There is one deference operator to rule them all: *.
thing := 10;

*(@thing) // same as thing
*(&thing) // same as thing

Casting
Raw pointers and references can be casted to uintptr and back.
To get a raw pointer from an ARC pointer, use the library function
mem::arc_get_raw_pointer<T>(ptr: ^T) -> @T.
To get an ARC pointer from a raw pointer, use the library function
mem::arc_from_raw_pointer<T>(ptr: @T, refs int) -> ^T.
Raw pointers and ARC pointers can be implicitly casted to references. This is useful for functions which should be able to take all three types.
func do(a: &int) {
    *a = 5;
}

func main() -> int {
    // pass an ARC pointer to do()
    // it's essentially the same for raw pointers
    arc_ptr: ^int = mem:alloc<int>();
    do(arc_ptr);

    // pass a stack var reference to do()
    i: int = 5;
    do(&i);

    return 0;
}

Also, all 3 mutable type variations can be implicitly casted to their immutable variations.

Hopefully, with this setup, the compiler will be able optimise out many ref count checks. Also, it could even replace some ARC pointers with raw pointers when it is proven to be safe.

LGTM, perhaps in the casting from_raw_ptr and to_raw_ptr, we could put this inside arc.ark so in effect you do arc::from_raw_ptr or something like that. Not particularly sure on the @ symbol for raw pointers, any particular reason why you chose this over something like an asterisks *?

It's to make it consistent with the other two, where the type symbol is the same as the address-of operator. Keeping * separate from all three keeps it clean.

@MovingtoMars Ah yeah the dereferencing stuff, hm yeah I guess I like most of this though if we could pick a symbol for raw pointers could it be like ', so x: 'int = .... I'm not too bothered, but if the opportunity is there...

Ideally, you shouldn't be using raw pointer too often, so it shouldn't matter.

This seems a bit overcomplicated, couldn't all references be reference counted, rather than having a totally distinct type for that?

@SamTebbs33 The idea is it's a systems language, you don't want to reference count everything because:

it's not always necessary
it introduces overhead (not good for a systems lang)

Though I do agree that introducing 3 new types is a little overcomplicated for my liking.

@MovingtoMars Yah but the @ symbol seems a little arbitrary, and if we're going for arbitrary I'd rather it be foo: 'T = ... :wink:

I'll start out with saying that in general, I think this is a really complicated approach, and ideally I'd want just raw pointers and then do (A)RC completely in the stdlib, mainly via the implementation of RAII-like system using interfaces (e.g a Drop interface containing a method that would be invoked once the value leaves scope).
Now with that out of the way, my comments on this approach:

First of all I'd way prefer if @n was the ARC pointer vs ^n as this would be more of an indications that "this is not just a pointer".
The restriction on taking a raw pointer to an element on the stack is silly and unnecessary imo. There is no need to make the programmer jump through hoops like that.
Using * as a generic dereference operator seems okay.
Finally I'd like to ask about how you plan the stdlib dependence for ARC pointers:

If I wanted to use a custom allocator, I'd obviously have mem::arc_from_raw_pointer to create an ARC pointer, but how would you go about handling the deallocation once that happens?

@kiljacken I mostly agree, I would prefer arc in the stdlib rather than introducing loads of weird pointer syntax.

Ok. It'll probably be a lot less complicated by putting it in the stdlib.


Improve consensus unit tests

Consensus is built on the Tokio executor for futures, but currently uses futures::executor all over the place. This was discovered by trying to improve the test timeout behavior and realizing that the futures were not executing in a Tokio runtime.
This PR does the following:

Changes tests using futures::executor::block_on to use tokio::runtime::Runtime::block_on instead.
Uses async blocks instead of async move blocks, as the Runtime must be dropped from outside a future as it calls block_on in the drop logic. The async move was moving the Runtime inside the block, which was then dropped inside the block, causing a panic for invoking runtime functions inside a runtime (similar to a double borrow).
Removes the crash handler, which force exited the process on panic, which is not the behavior the test harness is designed for.
Replaces the timeout panic with tokio::time::timeout for more graceful timeout handling.

This PR does not remove all instances of futures::executor, but that should be done eventually.

cc @davidiw @rexhoffman @bmwill @aching

@bors-libra r=zekun000

:pushpin: Commit 07e2711 has been approved by zekun000

:hourglass: Testing commit 07e2711af19a5bed2f46857175fa4e706fb8b2c6 with merge ff651033361c6d842ac7e29df0598a6ab807bcd6...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: zekun000
Pushing ff651033361c6d842ac7e29df0598a6ab807bcd6 to master...


fix SectionList scrollToLocation and prevent regressions

Summary
Recently there were quite a few changes to this functionality, and they caused breakages
#21577
#24034
#24734
#24735
Currently,  whichever viewOffset I pass, it will be overridden (either by 0 or something computed in the if body). This fixes the issue and also adds tests to make sure there is no regression.
Changelog

[Javascript] [Fixed] - VirtualizedSectionList scrollToLocation viewOffset param ignored
Test Plan
tests pass

@cpojer rebased; CI failures don't seem to be related


Avoid the need to hardcode table names

We currently hardcode the "three standard" table names in various places in the code.
These table names could be set as constants in a relevant place.
One important question:

[ ] Are the table names going to be the same no matter what the underlying database engine is?

Yes to your question. I see no reason why it shouldn't be

Yes to your question. I see no reason why it shouldn't be

thanks!


Adds the 'removeMapper' method for 'MapperRegistry', and a forwarding…

Adds the 'removeMapper' method for MapperRegistry, and also a forwarding method in Configuration, for those situations like 'dynamic loaded class annotated with @Mapper' use.

Hello? Anyone responsible?

Hello @Jucyfer ,
I'm not sure what you mean by "'dynamic loaded class annotated with @Mapper' use", but this would not do anything useful.
And please avoid modifying unrelated lines when sending a PR.


Released egui 0.26

Thanks for this excellent crate, I would be very appreciated if you update it to egui 0.26

I guess this will be simple version bump, I will check it and update crate tomorrow (cargo lacks sensible implementation of sth like egui= ">=0.21, <0.27", so each egui major update requires issuing breaking release and dropping support for previous versions of egui, I do not find that elegant, so I was considering options to support multiple versions of egui and that's one of the reasons of delay here).

Thanks for your response. Also, it is possible to have a library version the same as egui. Иut this is not an unambiguous question.

egui_struct 0.4 with egui 0.26 has been published


stacked_localisation null-safety migration?

Looks like stacked_localisation has not updated for null safety (for flutter v2.0+) at https://pub.dev/packages/stacked_localisation.
Any plan updating this and maybe release as preview instead of stable?
PS: discontinued flag is bad for search in pub.dev.

I think it's marked as discontinued because it is not supposed to show up while they are working on it. See #126

Since the last update on pub.dev is 8/20/20, I don’t think anyone is working on it?
Null-safety should be a priority now since Flutter v2.2+ requires it.

@calvintam236 it's marked as discontinued and has been since the second day it was released. I realised I had an incomplete implementation and abandoned the package for that reason.
We don't have the resources to dedicate to this project since we have no more projects that require localisation.


Cannot update carbon.properties file with new configuration model

Description:
The system properties defined in the deployment.toml file is not loaded into the server on the first start.
Steps to reproduce:
1.Add following configuration to deployment.toml file
[system.parameter]
'org.wso2.CipherTransformation'="AES"
2. Start the server.
3. Restart the server. Now the new value in the deployment.toml will be picked.
Affected Product Version:
APIM 3.1.0

Optional Fields
Related Issues:
https://github.com/wso2/product-is/issues/7991

Fixed with https://github.com/wso2/carbon-kernel/pull/2754


Remove x86 target from iOS frameworks

As the latest Xcode versions do not include simulators for devices prior to iPhone 5s, 32-bit simulator targets are no longer required. Thus we should keep x64 but can drop x86. This should make our compiled framework roughly a quarter smaller.

Removed from 4.2.0-rc.1


Create pre-commit hooks

Create pre-commit hooks that checks for the quality of the code submitted, identifies any potential sensitive info disclosures and corrects / removes any error if found.

Issue resolved


Awesome Project,  I want to integrate SVG into my Blazor Canvas

Please checkout my project   https://apprenticefoundry.github.io/    maybe we can collaberate

Hey @SteveStrong, thanks for your interest in the project. 😁
You can contact me at i (at) kristoffer-strube.dk then we can arrange a call to discuss.


nixos/test-driver: add Machine.record_audio

Motivation for this change
Allows you to record audio from a VM and verify that sound actually played.
Depends on #153866
TODO:

[ ] Write some docs
[ ] Get ALSA driver to work for QEMU? It's so choppy on my machine it's actually interfering with the proper functioning of the machine (cage threw a warning that "my machine is too slow" 😅)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg test pulseaudio.user pulseaudio.system firefox mpd

Gonna draft this until #154168 is merged, so that'll probably take some time. If anyone wants this in earlier, let me know.


Adding venv support for python libraries

I found that the PyLap libraries failed to run with the latest version of numpy (V2). I solved the problem by installing older versions of numpy, scipy, and matplotlib using venv in the PyLap folder. This setup worked on my computer and hopefully it'll work for others.

Tested it on a fresh install and it didn't work. Will get it in a working condition before resubmitting.

It does in fact work on a fresh install -- the problem was my test procedure, not the code. Please test it yourself as well before merging.


Formatting SD card does not cause free space to be recalculated

Seen on: 9.3.0-09eef33 rx:74 va:191
If the SD card is full, and you reformat the SD card, the SD card still shows as being full.
Rebooting causes free space to be recalculated, but this should not be required.
AFAIK a similar issue also applies if you delete recordings via the playback menu

Repro'd on this build: https://github.com/hd-zero/hdzero-goggle/actions/runs/9382157957
Test method:

FILL your SD card - on a windows system, for an SD card F:, in powershell:

cd F:
$space = $(get-WmiObject win32_logicaldisk | where-object -Property DeviceID -EQ "F:" | select -ExpandProperty FreeSpace) ; fsutil file createNew emptyFile $space

Put card in goggles - status bar shows "SD Card Full"
Storage menu > Format
Status bar still shows "SD Card Full"

Can you please try the artifact of this build?
I don't have my goggles at hand and therefore can't try it myself at the moment.

I just tried, but I cannot get the bloody SD card full :(
When I use the command I posted above, I get Error:  There is not enough space on the disk.
Even if I format it and it's completely empty :(


Specify config file path on the command line

Should have a parameter like --config pointing to a config file outside the default path. This will be handy with Docker deploys.

Done in commit d7d64b2ef52aebb45dcd63adc942360894f3bda6


Horizontal collision detection with dropdownAutoWidth: true

Prerequisites

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate
[x] The issue still exists against the latest master branch of Select2
[x] This is not a usage question (Those should be directed to the community)
[x] I have attempted to find the simplest possible steos to reproduce the issue
[ ] I have included a failing test as a pull request (Optional)

Steps to reproduce the issue

Make select2 appear near right edge of the screen (float: right on wrapper will do it)
Put some moderate-length nonwrapping string inside an option (i.e. SomeOptionText)
Init select2 with dropdownAutoWidth: true and width: 90 (width is just for example)
Open select2 and see how dropdown is overflowing body horizontally: http://output.jsbin.com/vulajaxaja

Expected behavior and actual behavior
When I follow those steps, I see that opened select2 dropdown is overflowing body horizontally
I was expecting that there will be some sort of collision detection in case there is not enough space and dropdown will flip its direction to the opposite side
Environment
Browsers

[x] Google Chrome
[x] Mozilla Firefox
[x] Internet Explorer

Operating System

[x] Windows
[x] Mac OS X
[ ] Linux
[ ] Mobile

Libraries

jQuery version: 1.12.4
Select2 version: 4.0.3

Isolating the problem

[ ] This bug happens on the examples page
[x] The bug happens consistently across all tested browsers
[x] This bug happens when using Select2 without other pluigns
[x] I can reproduce this bug in a jsbin

Same problem here. I opened a question in Stackoverflow about this.
https://stackoverflow.com/questions/45339207/wrong-position-when-using-select2-dropdownautowidth

Hi, is there any plan to fix this ?

Hi, is there any chance this to be fixed soon?


'RoundedRectangleBorder' can't be assigned to type ShapeBorder

This used to work but now there's an error when developing for iOS. No error for Android
Here is my flutter doctor:
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.5 19F101, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
[✓] Android Studio (version 3.5)
[✓] VS Code (version 1.47.3)
[✓] Connected device (1 available)

Hi @kaarens93
Seems to work fine for me on iOS on the latest stable

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      // theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(8.0),
          child: Material(
            elevation: 5,
            color: Colors.blue,
            shape: RoundedRectangleBorder(
                borderRadius: BorderRadius.all(Radius.circular(25))),
            child: Padding(
              padding: const EdgeInsets.all(8.0),
              child: Image.network(
                'https://i.imgur.com/QCNbOAo.png',
                fit: BoxFit.cover,
              ),
            ),
          ),
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.6 19G2021, locale en-GB)
    • Flutter version 1.20.4 at /Users/tahatesser/Code/flutter_stable
    • Framework revision fba99f6cf9 (34 hours ago), 2020-09-14 15:32:52 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 49.0.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (1 available)
    • iPhone 11 (mobile) • 73130414-6DF8-4E37-B9AF-F81FA0F9068B • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-7
      (simulator)

• No issues found!

Can you please provideflutter run --verbose logs, and a minimal complete reproducible code sample
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Fix jsc regression.Fixes #22274

My silly mistake when tinkering with the jsc lib. Also you have this patch first https://github.com/facebook/react-native/pull/22295.
@Kudo plz review.

@Kudo Thanks for report and review this.

@facebook-github-bot shipit


boringtun: 0.3.0 -> 0.4.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cloudflare/boringtun/releases.
meta.description for boringtun is: "Userspace WireGuard® implementation in Rust"
meta.homepage for boringtun is: "https://github.com/cloudflare/boringtun"
meta.changelog for boringtun is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0/bin/boringtun had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.4.0 with grep in /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0
found 0.4.0 in filename of file in /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
boringtun

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A boringtun https://github.com/r-ryantm/nixpkgs/archive/0b590e3c3caef4f97fc8eeba9918fe2fbdd2bca5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0
ls -la /nix/store/qipyl7wgj82mszradslakv83r96pygsi-boringtun-0.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

boringtun

Maintainer pings
cc @xrelkd @marsam for testing.

addressed by https://github.com/NixOS/nixpkgs/pull/163736


Random percentage of tests

Is there a way to run a random % of tests through exam? Like for example, randomly selected 25% of the tests.

Not currently. What is the use case you're trying to satisfy?

At the moment, we are limited on the number of CI agents for our tests, so we intend to run a 'light' version of our test suite where appropriate

I would recommend investing in figuring out why your test suite can't be handled by your CI or simply run all your tests on one machine instead of using multiple CI agents.
Running only random portions of your test suite will allow regressions to slip in undetected and will likely cause more difficultly and frustration in maintaining your code over the long run. Therefore, unless another use case is presented, I don't think this is a feature we'll support "out-of-the-box" with ember-exam.


request barrier  (testcafe part of the hammerhead #498 issue)

@AlexanderMoskovkin @helen-dikareva
For more details see DevExpress/testcafe-hammerhead#498

\r-

Waiting for https://github.com/DevExpress/testcafe-hammerhead/issues/602

@miherlosev Seems like there was a problem with rebase. I suggest you to rebase locally and open new pull request.

Yes. I will do it after merge https://github.com/DevExpress/testcafe-hammerhead/pull/607

I opened the another pull request - https://github.com/DevExpress/testcafe/pull/570


adds docs for Freighters signAuthEntry API

Adds docs for Freighters signAuthEntry API, points to a few examples.

Preview is available here:http://soroban-docs-pr592.previews.kube001.services.stellar-ops.com/

Preview is available here:http://soroban-docs-pr592.previews.kube001.services.stellar-ops.com/

I know you didn't ask for my review, but I did notice just a couple small things. Great addition!

Thanks! Updated in d9ad0af086a1210da59e31f763f27a6ce2458864

Preview is available here:http://soroban-docs-pr592.previews.kube001.services.stellar-ops.com/

Nice! The change looks good to me. Do you want to wait for a review from @piyalbasu? Or, I can approve and merge now. Whichever you'd prefer.

Nice! The change looks good to me. Do you want to wait for a review from @piyalbasu? Or, I can approve and merge now. Whichever you'd prefer.

yeah if you don't mind, we can wait for Piyal to make sure I covered everything he has in mind.