Generic AST impl

This PR is intended for discussion with a supporting example
Intent
The purpose of this PR is to provide the basis for making the AST generic. This is particularly useful for cases where a different parser, and different intermediate representation - read AST nodes - may be more appropriate (e.g. static parsing vs incremental parsing)
Included is the trait set for python 3.10 grammar (admittedly with an extra bound of Located for some traits), making heavy use of bounding associated types to ensure a correct interface. Additionally an implementation of these traits is included for the rustpython_parser. Integration of this has been shown in the helper function: ruff::ast::helpers::compose_code_path.
This shows incremental adoption is possible, with a final goal of the check_ast method being exposed and able to take a type implementing ruff::ast::nodes::Ast
Discussion
A few questions that would be useful to discuss:

Is this appropriate to keep inside ruff or should it be a seperate crate?
Is there sufficient motivation to get this change in (ie potential pitfalls of introducing this vs use cases)?
Would this introduce performance concerns?
Are the current associated type bounds sufficient, or should all associated types be bound with inner associated types where possible (e.g. type Alias: Alias<'a> vs type Alias: Alias<'a, Ident = Self::Ident>

Wow this is really interesting (and very impressive). To repeat my understanding: you've developed a RustPython-agnostic AST interface based on traits, and then implemented that interface for the existing RustPython AST. This would allow us to write code that consumes the AST in a way that's agnostic to the underlying AST implementation. For example, we could implement the same traits atop tree-sitter, and plug the resulting AST into the same code downstream without changes. Is that correct?

Is this appropriate to keep inside ruff or should it be a seperate crate?

Happy to keep this inside ruff.

Is there sufficient motivation to get this change in (ie potential pitfalls of introducing this vs use cases)?

I think what this needs is a second implementation of the trait interface, or a concrete proposal for what that second interface would be. That would give us sufficient motivation since it'd anchor us in concrete use-cases. What would this interface unlock?

Would this introduce performance concerns?

Only way to know is try! But if it's just function calls and not allocations... maybe it's fine? We'd have to do some benchmarking.

To repeat my understanding: you've developed a RustPython-agnostic AST interface based on traits, and then implemented that interface for the existing RustPython AST. This would allow us to write code that consumes the AST in a way that's agnostic to the underlying AST implementation. For example, we could implement the same traits atop tree-sitter, and plug the resulting AST into the same code downstream without changes. Is that correct?

That's exactly it.

I think what this needs is a second implementation of the trait interface, or a concrete proposal for what that second interface would be. That would give us sufficient motivation since it'd anchor us in concrete use-cases. What would this interface unlock?

Over at ruffd, there's nothing currently public but I've been messing around with creating an incremental parser. Implementing these traits could be that second implementation.
Another candidate is LibCST. I'm unsure of how much use it's receiving in the codebase but if its parser is being utilised, this would be an opportunity to only require a single pass rather than multiple for a cst vs ast.

Only way to know is try! But if it's just function calls and not allocations... maybe it's fine? We'd have to do some benchmarking.

I suspect the diff for the full implementation will be truly gargantuan, hence the incremental approach. Setting up a benchmark for a subset of rules would probably be the best first step. Are there any recommendations on what that subset should look like / if such a benchmark already exists?
Also, as a side note many of the function calls can be completely inlined so it should be exactly equivalent in those cases. Where there's potential overhead added, admittedly very small, is the use of ruff::ast::nodes enums both in the transform into these types and unwrapping them for the underlying value. Given these enums are sized as a pointer + discriminator, my expectation is the performance impact would be within margin of error.

Sweet! The other thing I can do to push this forward is spend some time myself trying to port parts of Ruff to this new generic interface, which will help me build intuition and opinions on the questions above.

There's been a bit of radio silence here but it's been for a good reason. There are essentially 2 unsolved problems remaining. one is the representation of underlying values (e.g. strings) and the second is integrating stricter lifetime requirements within ruff.
Generic, lifetime-bound, associated types
The most recent changes have introduced a generic way of specifying return types, as there are cases, particularly when using the FFI, where it is not appropriate to return a ref as the underlying data cannot be borrowed. The reason for compilation failure is that ruff currently assumes everything in the AST to be recursively borrowable, with the same lifetime.
This assumption is excellent for performance, but cannot be relied upon when data needs to be owned when querying the FFI. Having said that, it is also true that data produced from using the FFI has its implicit lifetime for data owned underneath itself, it is therefore not possible (even with allocations) to return nodes underneath intermediary nodes as those intermediary nodes were borrowed to create these new nodes and have lifetime restrictions corresponding to that borrow.
This technically would be possible to get around with implementing an IntoAst trait with corresponding Ast nodes (ie &self becomes self), but this has currently not been explored.
Underlying literal reprs
Various implementations have different ways of representing the underlying string literals. A particularly nasty case is that of tree-sitter where location is the only information about the literal for various string literal cst nodes. As such a type must be created to store both the Node and the string to which it refers to. Unfortunately this now presents a potential problem for the implementation. Thusfar ruff has assumed that the string literal is readily available as &str. Although String is always available potentially using a character iterator is a better approach. My main concern is the devex side of things as working with rust string primitives is far easier than playing around with character iterators, even if functionally they're behaving very similar for almost every op (that doesn't care about bytes).. There's potentially a nicer set of bounds that could be guaranteed forall parsers and enables equivalent functionality but I'm hestitant to just implement Iterator traits unless there's a use case.

Closing for now to keep the PR list up-to-date.


Problem in creating Blockchain network on Fabric with three organizations

I was able to successfully execute tools like configtxgen and cryptogen with relevant files modified for three organizations.
But when I am trying to start the network using command CHANNEL_NAME=$CHANNEL_NAME TIMEOUT=10000 docker-compose -f docker-compose-cli.yaml up -d
It's throwing an error
$ CHANNEL_NAME=$CHANNEL_NAME TIMEOUT=10000 docker-compose -f docker-compose-cli.yaml up -d
WARNING: The COMPOSE_PROJECT_NAME variable is not set. Defaulting to a blank string.
Pulling peer0.org3.example.com (hyperledger/fabric-peer:latest)...
ERROR: manifest for hyperledger/fabric-peer:latest not found
I even searched on net and found the following remedy https://stackoverflow.com/questions/43830372/error-manifest-for-hyperledger-fabric-ordererlatest-not-found
But even this is not working.
Pls help...Thanks in advance.

ah, not sure anyone here can help.  You should make an issue on the Hyperledger Fabric Jira


Updating README.md

Coverage remained the same at 100.0% when pulling 7cde1d1d7588ebaab8a8edb99c0d4e970cab494b on info into abb5e781cf8f1e21c8614e5081c1ebf5e21e8edc on master.


Expand container-entrypoint args as separate words

Closes #79.

@bparees @mfojtik ptal

@praiskup PTAL

Wrong - we need /bin/bash probably.  Sorry (because we need to take
some $BASH_* variables into account.  This probably deserves small comment.

Wrong - we need /bin/bash probably, because we need to take
some $BASH_* variables into account.

Yep, the scl enable hack

@praiskup we need "/bin/sh -i" (which will pickup ENV var, but on the other hand produce ugly warning about not having a tty if you run this in non-interactive fashion...) (which is the reason why we should fix 'scl command to provide a way to enable collections globally for docker images ;-)

Yeah - that is something I disagree with (but have to be tolerant ;)).  IMO, SCLs should be
set by openshift -- image consumer.  Image itself should be neutral to allow to build on top
of it without headaches.

s/should be set/should be neabled/

@praiskup that is a good goal, but openshift consumers wants to have environment similar to what docker language stack provides. Any fluctuation from that setup is a barrier for them to switch to RH images and we don't like annoyed users :-)

@mfojtik can we get this merged?


Truncate support for field-level filtering

re: https://tranquildata.atlassian.net/browse/HC-24
Support for truncating structs down to a subset of fields

Yes, sorry that I forgot to annotate this PR. The changes to the tranquil_<resourcetype>.go files are generated code for the Truncate method. The only one of any significance is the one in tranquil_explanationofbenefit.go. I'll add a comment to that file.


Request: Option to send snapshots to alternative pool

Hi,
Firstly, thank you for creating this script, its been really useful.
I have decided to create a second pool to fully backup a filesystem on my main pool and was wondering if you could add an option (-b?) to backup the snapshot to an alternative pool. e.g. zfSnap -a 5d -r zpool -b bpool
This would first check if the current filesystem in the loop (e.g. xyz) exists in the bpool. If it doesn't then it will just zfs send zpool/xyz | zfs recv bpool/xyz. If it does exist then the script will get the n (just created) snapshot and the n-1 snapshot and send an incremental backup  zfs send -i zpool/xyz@n zpool/xyz@n-1 | zfs recv bpool/xyz
Is this achievable?
Thanks,
Comm

@comm Thanks fir the suggestion. :-) I do have plans to implement this, but it won't be for the 2.0 release. Probably 2.1. I'm closing this issue, as I'll track any changes in issue #48.
---Alex


ASP.NET CORE: What is the Configuration.GetConnectionString("BloggingDatabase") namespace?

options.UseSqlServer(Configuration.GetConnectionString("BloggingDatabase")));
Does not recognize "Configuration". What is the namespace to use? Not clear

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de9db02d-7310-1141-6aeb-539c02326a36
Version Independent ID: 90062036-aa01-3f73-dac9-b4a092245721
Content: Connection Strings - EF Core
Content Source: entity-framework/core/miscellaneous/connection-strings.md
Product: entity-framework
GitHub Login: @rowanmiller
Microsoft Alias: divega

The Configuration  property is defined in the Startup class and it is initialized thru dependency injection. Here is the sample for a project created with  dotnet new mvc -au Individual
public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

It would be useful more examples of connection strings with other providers :)

services.AddDbContext<Context>(opt => opt.UseMySQL(Configuration.GetConnectionString(connectionStringName)));

If you use MySQL then you need the MySql.Data.EntityFrameworkCore NuGet package


⚠ Bofrost.at has degraded performance

In 53bb918, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1857 ms

Resolved: Bofrost.at performance has improved in d7cf78c.


fix: adjust setDefault

What type of PR is this?
feature
What this PR does / why we need it:
Adjust route PATCH /diagram/:id/default
Minor refactors
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., usage docs, etc.:

:tada: This PR is included in version 1.5.0-rc.10 :tada:
The release is available on:

npm package (@rc dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Mount component inside mounted component?

Goals:  Mount DashboardAccount inside DashboardLayout, and mount DashboardEdit inside DashboardAccount
What I've tried
FlowRouter.route('/dashboard/account/edit', {
  name: 'dashboard.account.edit',
    action () {
      mount(DashboardLayout, {
         content: () => (<DashboardAccount />)
      });
      mount(DashboardAccount, {
        content: () => (<DashboardEdit />)
      });
    }
  });

ps. using the mantra spec.

Got something working with
FlowRouter.route('/dashboard/account/edit', {
  name: 'dashboard.account.edit',
    action () {
      mount(DashboardLayout, {
         content: () => (<DashboardAccount content={ () => (<DashboardEdit/>) }   />)
      });
    }
  });

Is this the recommended way of approaching this? or what is the correct way to approach this?

@fallenpeace Yeah. This seems like the way it's working now.
We may need to work on something simple.
May be, it's some more docs.

Hi @fallenpeace - I've have components in props working this way:

authenticatedRoutes.route('/account/profile', {
  name: 'account.profile',
  action() {
    mount(MainLayout, {
      yield: <Account yield={<ProfileSettings/>} />
    });
  }
});

Hope this helps!


Visual Studio 2019 support

Describe the solution you'd like
I would like to build my UWP application on a Visual Studio 2019 agent. Configuring the build so that the agent could be selected based on the Visual Studio version would be the ultimate goal as most likely upgrading all agents to Visual Studio 2019 would brake some other user builds.
Describe alternatives you've considered
I could try Azure Pipelines as Visual Studio 2019 seems to be supported there. Or I could change my app so that it builds on Visual Studio 2017 (which App Center agents currently seem to use).

Thanks for this feature request @miktap! We've been starting to look into this. Out of curiosity, is it important for you to be able to select between VS 2019 and VS 2017 for builds or would just having support for VS 2019 be enough?

Support for VS 2019 is enough for me. Thanks!

What's the status of this? This is a problem on Windows (VS2019) and also Mac. Our Android builds are failing because the build chain on Mac is not updated.
We started using F# 4.7 features as soon as VS2019 was released, and this was not a problem on Azure DevOps as that was updated straight away, but builds are still failing on App Center.

+1 Same here.  I'm on the bleeding edge with Xamarin Forms UWP/Android, so having 2019 build agent support would take a lot of the "build-and-pray" out of my development cycle.  I have had to wrestle with issues where my local builds would not build on AppCenter.

As an update here, we're looking to switch from VS 2017 agents to VS 2019 agents by mid-February.

+1 Thank you! Same here. Also, thanks for the update @nrajpurkar!
We're trying to build a UWP app in App Center. For development, our machines are using Visual Studio Pro for mac and Visual Studio 2019 for Windows. We don't get any errors when building from our machines but we get an error Fody is only supported on MSBuild 16 and above. Current version: 15.  We use Fody on our code and will try downgrading it to a previous version in order to make the app build on App Center but only for now.

+1 on this. @nilofer, is mid-February for this still on track? The reason I ask is because I had opened a ticket about a failing UWP build on 1/10 and I was told by intercom support engineer to open an issue because there was no plan to support VS2019 in the pipeline. This is the exact response I received.

App Center currently only supports building UWP apps with Visual Studio 2017. As you have discovered, the version of .NET Core you are targeting is not supported by this version of Visual Studio. At this time, that means you can't use App Center for building this app.
Please consider opening a feature request so we can determine how many people are looking for this to work. We track feature requests here:
I had a look for similar requests, but did not find any that cover your request exactly.
I'll close this issue now since requests for new features are handled through the GitHub repository.

Hello, any update on this? we are looking forward to use AppCenter for our deployments of visual studio 2019 apps

@hiraldesai @kmatthijssen, apologies for that response from support. This is still on our roadmap and our team will pick this up in the coming week. We may slip into the following week, but aiming to get this done soon.

Any latest update for add VS 2019 support in AppCenter? When will be the next release fix?  We are encountering UWP compiler errors ONLY on AppCenter build because it is using VS2017. Our build works fine on VS2019.
This is the Error. This happened after we added EntityFrameworkCore.SQLite nugget.
Error CS7069: Reference to type 'IAsyncDisposable' claims it is defined in 'netstandard', but it could not be found

VS 2019 support was added on approximately March 5th: https://github.com/MicrosoftDocs/appcenter-docs/commit/48fe3b6282e3484c32eae24a025f60a45e634fba


fix(node): apply @rollup/plugin-commonjs on rollup

Description

Test Plan

#523  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on  Graphite

Merge activity

Mar 10, 8:41 AM EDT: @Brooooooklyn merged this pull request with Graphite.


Upload CLI help to include CATEGORY text

BUG: Presently only one of the supermarket doc pages references Category tag.
Updates needed:
CLI needs to include help text for optional parameter: CATEGORY.
`knife supermarket share COOKBOOK  (options)
Reference: https://docs.chef.io/plugin_knife_supermarket.html
ps: CLI may need other updates to cover functionality I am not aware of.

Hi @vinyar!
I want to make sure I understand your issue.  Is it that when you run:
$ knife supermarket share --help

You would like to see information on including the CATEGORY parameter?

@vinyar Does the comment about category in the supermarket shared command code shed any further light? Given the conclusion there—the recommendation to not use a category—possibly the fix is to remove or add a deprecation to the reference to CATEGORY command line option in the docs.
I agree that documentation and/or the help text should be adjusted one way or the other for consistency.

History: categories were a thing with the pre-supermarket cookbook site.  Instead of fixing the doc bug, either stop requiring it on the side of supermarket or pass something to supermarket so it can be deprecated.

I'm all for killing deprecated functionality. Just because a knob exist doesn't mean it should be turned


Error trying to install via pip on Windows (10) using anaconda 2.7

I love the idea of this package and thank you to for creating it.
but....
i'm having a bear of a time getting it installed. Anaconda sometimes doesn't play nice, but even conda recipies for 64bit windows fail.
Attached are text files of the pip failed installs using Microsoft Visual C++ 9.0 (reccommended for Python 2.7) and MinGW (latest GCC as near as I can tell)
not to rub salt in the wound but it seems like there are a lot of issues in regards to installation, if feather is supposed to be a fast, convenient way to share dataframes it seems like the install needs to be a bit general and painless to encourage adoption.
Thanks for any help the (much) more informed user base can provide. looking forward to ruffling some feathers...
feather_install_log_VisualCpp.txt
feather_install_log_MinGW.txt

Ouch!
Per https://github.com/conda-forge/feather-format-feedstock/issues/1, I believe regrettably that Feather, Windows, and Python 2.7 may not be a viable combo (@msarahan, can you provide some more color on this?) unless a kind soul backports the C++ code to C++03 (we're using C++11).
Python 3.5 should work for you, but you'll need to use the git master version until I post a new PyPI release with recent Windows fixes (https://github.com/wesm/feather/commit/e27a58e3fbab9b32aec4a1ed4b5779cd8779dbeb).

This article sums up the reasons why well: http://siomsystems.com/mixing-visual-studio-versions/ - you can't have C++11 without a newer compiler, and you can't have a newer compiler, because you'd be mixing runtimes.
Your only options are to use a non-standard python2.7  interpreter - either MSYS2 (and use GCC for compiling feather), or create a whole new Python2.7 stack that isn't compatible with many other Python 2.7 packages out there.

right on. thanks for the quick replies. you guys rock. python on windows often does not...
I love pandas and I love the anaconda stack but it looks like feather won't be joining the party in my current dev environment. Maybe the 2.7 --> 3 gap has gotten wide enough that I should make the leap. I think this is the first time I'd be opting for 3 because it actually supports a package I want to use...
Maybe when windows rolls out the subsystem for linux we can all be one happy family again.
keep up the awesome work!


Testing a mutation

I have a mutation like so.
const [addItemResult, addItem] = useMutation(addItemMutation)

//....

const addItemToCart = async () => {
 const {error} = await addItem(variables)
}

So I trigger this mutation when the user submit the form. So pretty basic here.
Next I tried  to test the mutation by mocking the the executeMutation function. In the documentation it suggest to do something like this executeMutation: jest.fn().
However this was causing an error: TypeError: Cannot read property 'length' of undefined triggered by the function Object.toPromise from wonka
Dependencies
{
"urql": "^1.9.6"
"wonka":  "^4.0.9",
"jest": "^25.3.0",
"@testing-library/react": "^10.0.2",
}

Steps to reproduce
Reproduce the example of the documentation. I used react-testing-library instead of enzyme
const mockClient = {
 executeMutation: jest.fn()
}

it('triggers a mutation', () => {
  const { getByText,  getByTestId } = render(
    <Provider value={mockClient}>
      <MyComponent />
    </Provider>
  );
  const variables = {
    name: 'Carla',
  };
  fireEvent.change(getByTestId('input'), { target: { value: variables.name } })
  fireEvent.click(getByTestId(button'))
  expect(mockClient.executeMutation).toBeCalledTimes(1);
  expect(client.executeMutation.mock.calls[0][0]['variables']).toMatchObject(variables)
});

Solution
I came over this problem by doing this: executeMutation: jest.fn(() => empty) So my mock function returns an empty stream which is completed immediately. So I don't know if the best solution and if the documentation needs to be updated or not.

Hiya 👋
Thanks for raising this!
It does mention this further down on the documentation page, but I agree that it’s very unclear: https://formidable.com/open-source/urql/docs/advanced/testing/#response-success
Optimally all the code samples on this page should be explained better, and fromValue should be explicitly highlighted, and a section on subscriptions and mutations should be added, despite the testing strategy there not being different.
This is a new page in our docs, so I did expect it to be a little rough around the edges 😅

Thanks @kitten. I'll propose a PR for the changes. I'm not fluent in English so you'll might need to change a thing or two 😄 .


[Core] Support results_per_page in the by_page iterator

Currently the ItemPaged.by_page() function only takes a continuation_token.
We should also allow specifying the page size.
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/core/azure-core/azure/core/paging.py#L98
Not all services will support setting a page size (just as not all services support a continuation token). So in order to prevent breaking any existing implementations that don't support the extra kwarg, this could be done simply by adding **kwargs to the by_page function:
def by_page(self, continuation_token=None, **kwargs):
    # type: (Optional[str]) -> Iterator[Iterator[ReturnType]]
    """Get an iterator of pages of objects, instead of an iterator of objects.
    :param str continuation_token:
        An opaque continuation token. This value can be retrieved from the
        continuation_token field of a previous generator object. If specified,
        this generator will begin returning results from this point.
    :keyword int results_per_page: The maximum number of items to return in
        a single page.
    :returns: An iterator of pages (themselves iterator of objects)
    """
    self._kwargs.update(kwargs)
    return self._page_iterator_class(
        continuation_token=continuation_token, *self._args, **self._kwargs
    )

@annatisch to me it's the role of the list call to do that:
result = client.list(top=5)
for page in result.by_page():
   for elt in page:
       do_something(elt)
```

Thoughts? @annatisch @johanste

hey @annatisch @johanste @lmazuel , reinvigorating this thread. Text Analyticss is running into a similar issue as MA. To me, top of 5 would mean "just return the top 5 results". However, some service teams (i.e. MA) are takign top to mean paging size. I believe this discrepancy is the reason for this issue being open, and I beleive both @johanste and @annatisch recommended it be on by_page. I also believe there were talks to have the param on by_page be something like page_size

hey @annatisch @johanste @lmazuel , reinvigorating this thread. Text Analyticss is running into a similar issue as MA. To me, top of 5 would mean "just return the top 5 results". However, some service teams (i.e. MA) are takign top to mean paging size. I believe this discrepancy is the reason for this issue being open, and I beleive both @johanste and @annatisch recommended it be on by_page. I also believe there were talks to have the param on by_page be something like page_size

@johanste @iscai-msft in v6.0.0 of autorest we stopped generating with the maxpagesize keyword argument. IIRC we were relying on it's ability to be passed into the by_page, but it doesn't look like this got implemented yet. Should we prioritize this?

Unless we have customer feedback, I wouldn't prioritize this too high. Given that the maxpagesize parameter generally is aspirational (i.e. the service only guarantees that it returns at most maxpagesize items, not that it will actually return maxpagesize items), it ends up not being used too frequently.

Got it, sounds good. I don't think I've heard any customer feedback on this, just came across it and thought I'd check.


Documentation for writing extensions

At least for formatters, it is straightforward. Implement the OutputFormatterInterface, let users know how to register it and you are good to go.
For Commands, this is not so simple, because you might want to depend on Analysers, token resolvers, and other internal features, that are not yet pinned down to a stable API.

I would like to put this on hold for now and create docs one by one for each interface, because at the very least I want to make some slight modifications, e.g. Qossmic\Deptrac\Collector\CollectorInterface::getType() can be removed and instead we put this info as attribute on the tag. This way it is much easier to resolve conflicts when two or more collectors use the same type. Similarly for Qossmic\Deptrac\OutputFormatter\OutputFormatterInterface::getName().
Updating the docs each time, when we likely change the extension points frequently before making them public seems like unnecessary overhead.


Help: D&D 5e elevation

Is there a way to get the 5e system to check the elevation? It says in the table that elevation is not checked, and I don't seem to be able to get the elevation difference to be recognized.

Have you setted the active effect change ATCV.conditionElevation = true like describe in the documentation ?
Enable the debug module settings and show to me the logs for confirm the check.

So I think the issue is that I just don't understand where/how I am supposed to make that change.

Like in this video

but instead you use :
ATCV.conditionElevation = true
if you use Dfred Convienient Effect you can directly edit the effect on dfred panel.

So it should be like this:
Attribute Key					| Change Mode	| Effect Value
ATCV.conditionElevation	| Custom				| true
?

As a side question, why is 5e not set to automatically check for elevation differences in the calculations?

_So it should be like this:
Attribute Key | Change Mode | Effect Value
ATCV.conditionElevation | Custom | true
?_
yes it should work
As a side question, why is 5e not set to automatically check for elevation differences in the calculations?
bad community feedback, the elevation check is useful only for people a little more skilled and in combination with other modules, so is a statistic decision , the majority of people are just happy wihtout a elevation check on the middle.
The module is already integrated with "Levels" so you don't need to set the value to true if you use that module.

Hmm.. I do have levels installed and it is not working. I will do some further troubleshooting and get back to you.

@ravingdragoon i added a module settings for enable by default the elevation check if you can found helpful.


final modifier not applied

The snippet below demonstrates that the "final" field
modifier is not applied.
bsh % class FClass { public static final int fnum = 100; };
bsh % bsh % javap( FClass );
Class class FClass extends class java.lang.Object
public bsh.This FClass._bshThisFClass
public static bsh.This FClass._bshStaticFClass
public static int FClass.fnum
bsh % FClass.fnum = 200;
bsh % print( FClass.fnum );
200
Reported by: eric_lindahl
Original Ticket: "beanshell/bugs/265":https://sourceforge.net/p/beanshell/bugs/265

Works as expected in BeanShell 3.0.0-SNAPSHOT.841
bsh % class FClass { public static final int fnum = 100; };
--> $0 = class FClass :Class
bsh % bsh %  javap( FClass );
Class class FClass extends class java.lang.Object
public bsh.This FClass._bshThisFClass :Field
public static final bsh.This FClass._bshStaticFClass :Field
public static final java.lang.String FClass.UUID :Field
public static int FClass.fnum :Field
--> void
bsh % FClass.fnum = 200;
// Error: Evaluation Error: Cannot re-assign final variable fnum. : at Line: 5 : in file: <unknown file> : FClass .fnum = 200


Generated .pb.go files are stale [phab:T218]

Created by benjyw at 2017-02-21 20:17:36:
a08c1f5e4db563cf242b0393f9f54c4c3a824d96 modified kythe/proto/serving.proto and kythe/proto/xref.proto but not the corresponding generated files in kythe/proto/serving_proto/ and kythe/proto/xref_proto/.
As a result, third-party code that uses Kythe go code is now broken against master.

benjyw wrote at 2017-02-21 20:18:37:
I'd be happy to post a code review that fixes this, but I'm not sure what the canonical way to generate these is.

fromberger wrote at 2017-02-21 23:14:25:
The solution is to run ./kythe/proto/generate_go_protobufs.py
I guess we should probably add a presubmit check for that.

fromberger wrote at 2017-02-21 23:14:37:
cf. #1752

revision #1752


[Bug]: Unable to add devices after software update

What happened?
I am unable to connect my Eufy security devices after software update. Things were working fine before the update. It keeps getting stuck at “Homebridge running at port 51876”.
The devices fail to be added. Please advise. Thanks.
Device Type
Contact Sensor (Supported)
Plugin Version
v2.0.x (Supported)
HomeBridge Version
v1.4.x (Supported)
NodeJS Version
v16 (Supported)
Operating System
Raspbian 10+ (Supported)
Relevant log output
06/07/2022, 10:10:13 AMEufy Security Bridge starting
06/07/2022, 10:10:51 AMEufy Security BridgeLoaded plugin 'homebridge-eufy-security'
06/07/2022, 10:10:51 AMEufy Security BridgeLoading 1 platforms...
06/07/2022, 10:10:52 AMEufy Security BridgeBridge is running on port 51876.
06/07/2022, 10:11:02 AMEufy Security BridgeConfiguration change
06/07/2022, 10:11:02 AMeufysecuritybridge stopping
06/07/2022, 10:11:08 AMEufy Security Bridge starting
06/07/2022, 10:11:21 AMEufy Security BridgeLoaded plugin 'homebridge-eufy-security'
06/07/2022, 10:11:21 AMEufy Security BridgeLoading 1 platforms...
06/07/2022, 10:11:22 AMEufy Security BridgeBridge is running on port 51876.

Closed, since this most likely a duplicate and stale


ICSE 2021 Camera Ready Preparation

I've pulled origin/master, origin/research, origin/develop, and origin/shaifuls-changes into origin/icse2021 in preparation for final ICSE validation.
To finalize the paper we need to (in the origin/icse2021 branch):

[ ] Add the FinerGit / IntelliJ / git log data files (@shaifulcse).

[ ] Ensure FinerGit fails to compute the changes we observed if failing for with the initial submission (@shaifulcse).

[ ] Improve the conceptual flow of the matching code. (@rtholmes on a separate branch to not block other work)

[ ] Confirm the implementation passes the oracle to the same degree described in the paper. (@rtholmes)

[ ] Confirm the constants match the description in the paper. (@rtholmes)

At that point we should be done (for ICSE 2021).

380ccf5f4126c22a12bcb0b32539df66d169c1b2 & fd0f92697a57bfc4c9157b80f75aadb18a235f04 fix the memory leak issue (#37) and the test running issue (#39).

380ccf5f4126c22a12bcb0b32539df66d169c1b2 & fd0f92697a57bfc4c9157b80f75aadb18a235f04 fix the memory leak issue (#37) and the test running issue (#39).

Great work in those two commits @rtholmes !! I think putting the code into the test suite in fd0f926 is not the "final solution" but if it works this way that's fine for now!

Great work in those two commits @rtholmes !! I think putting the code into the test suite in fd0f926 is not the "final solution" but if it works this way that's fine for now!

Great work in those two commits @rtholmes !! I think putting the code into the test suite in fd0f926 is not the "final solution" but if it works this way that's fine for now!

Don't worry, I redid this again in 730b508 which I hope addresses your concerns! The test part is only ~4 lines of code now.

reid_icse2021 merged into icse2021 and deleted. master is now up-to-date with icse2021.


confirm that checkout action defaults to GITHUB_REF

placeholder for https://github.com/actions/checkout/issues/8

confirmed in the above.


Timezone handling fixes

Assortment of fixes and cleanups related to timezone handling in Camera and admin.

thanks for the patch. release notes and docs will be needed too.

I'll look into adding some release notes. But can you clarify about the
docs? This is a bugfix/refactor PR and I would generally assume that these
don't require docs. Secondly, do we even have docs? The best I could find
online is a page in Celery docs.
2016-08-04 09:05 "Asif Saifuddin Auvi"<EMAIL_ADDRESS>rašė:

thanks for the patch. release notes and docs will be needed too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/celery/django-celery/pull/456#issuecomment-237460901,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE-s-N8PggxW_PNOFeWF_ihK0MtPlJKoks5qcYFCgaJpZM4Jb-Ii
.

you are right, only release notes would be fine for now.

I have added a changelog entry.

looks good to me. thanks


Align serialization of empty members

Align with https://github.com/LIonWeb-org/organization/issues/59 : option B = having properties, children, references as required members, but empty values are not allowed (so don't emit empty sub members, but still accept them).

fixed by commit d95b769


Undefined property on Fluent class

Larastan Version: 10.22.0
--level used: 8
Pull request with failing test:

Description
Hello!
I'm getting an undefined property error on a Fluent class, I saw a PR (#924) was rejected, however, as Fluent is by definition a universal object crate this really needs to be fixed by the package (either by adding it to the universalObjectCratesClasses or developing an extension)---shouldn't expect everyone to have to add the class to their own config just to use it.
Thanks!

Hi,
I do not want to ignore stuff on behalf of users. We did that in the past, and it was annoying in some scenarios. Also, PRs are welcome if you want to develop an extension for it. But I don't think we need to keep an issue open for it.

@canvural, what do you envision the extension would look like?


cacti-integrate.php - use-dsstats logic is reversed

In  random-bits/cacti-integrate.php  the logic for generating the target should be reversed:
current code reads:
if ($use_dsstats) {
....
} else {
$tgt = "8*dsstats:$local_data_id" . $ds_names;
....
}
when $use_dsstats is true is should use the contents of the second clause, not the first.

Thanks for the report! This is resolved in the current dev version, via commit ec10d756c54939e2444f529fb3c481e27493bca1

Hi Howie,
Awesome tool!  The deeper I dive into it the more I love it!.  I might be missing something, but I don't see where the referenced commit touches that file or anything to do with dsstats for that matter.
Cheers,
Chris

Sorry! I think I must have pasted the wrong commit... it's here: 4938a007d35a07c2bae3ed8d9843ce50ff218aac

Sorry - pasted, the wrong commit. I meant here: 4938a007d35a07c2bae3ed8d9843ce50ff218aac
The change is slightly different (I switched $use_dsstats with !$use_dsstats), but the logic is the same.
Glad you like it!


LinkedList Deletion Operation

Deletion Operations in LinkedList

Deletion of first node in linkedlist
Deletion of last node in linkedlist
Deletion of intermediate node in linkedlist

Event :
Gssoc'21
Can you assign the above task to be written in CPP and Java?

Please assign this issue to me .I will write the code in C++.

Ma'am
I would like to work on this issue . I have read the guidelines for making a contribution and will abide by them .
I am actively contributing to GeeksforGeeks & I am proficient in C++ . Please assign this issue to me .
I have been selected for GSSOC'21, and I am really interested in Data Structures & Algorithms , so I would like to contribute in this amazing repository.
Regards
Amartya Yadav

Can I work on this issue, under gssoc'21?

Hi,
Please assign this task to me. I am a GSSoC'21 participant. I can solve the problem using c++.

Hello sir/mam,
I have gone through your problem statement.
And as a participant of GSSOC21 and I am also good at Data Structures and Algorithm I have also have pull request in this existing project and I love this project.
This same question I have done in Leetcode as well and I know the main Algorithm behind this.
Looking forward to your reply.!!!:)

I would like to work on this issue, under gssoc'21.
I have implemented the same thing as a part of my college assignment, so I am very well aware with the logic and code.

Please Assign me this issue I can code it in python. I am a gssoc'21 participant.

Hello sir/mam,
I have gone through your problem statement.
And as a participant of GSSOC21 and I am also good at Data Structures and Algorithm I have also have pull request in this existing project and I love this project.
This same question I have done in Leetcode as well and I know the main Algorithm behind this.
Looking forward to your reply.!!!:)

I am GSSOC'21 participant , I want to work on the in C++ code.
I have good understanding about C and C++ language..so I request , to please assign me the work.
The code will be properly indented with proper comments and description.
I will provide the code in all the deletion cases with best time complexity.

duplicate issue.


Update curation-guidelines.md

Propose a more step-wise process for curation guidelines that also sets out minimum curation standards for a component.  Still work to be done around source location and facets.

Thanks @bduranc I've added the below to clarify the difference between source and package components.
The Difference between "Source components" and "Package components"
The process below differes for components depending on whether they are "source" or "package" components. A "source" package is the component in the preferred form of editing or building, like a Git repository.  A "package" component is a component in its functional form that is intended to be used without further editing or building, like would be installed by a package manager.


Add opt-out option

Hey, what if I want to spin up a project, but don't need a form library?
For whatever reason. I thought, maybe an opt-out here would be a good idea.
What do you think?

You shouldn't be forced to add a form library! It's just checked by default for convenience.
Maybe that's not convenient, I'll have to check usage numbers at some point. The defaults should roughly cover the 80% use case.


Increase time before timeout when waiting for the instance to run

The problem that has valued the opening of this PR seems to have solved itself, so it is impossible to find the cause


fn_call_style has no "Compressed" variant

Check this out. Before:
let a = i8x32::new(
             0, 1, -1, 2,
             -2, 3, -3, 4,
             -4, 5, -5, std::i8::MAX,
             std::i8::MIN + 1, 100, -100, -32,
             0, 1, -1, 2,
             -2, 3, -3, 4,
             -4, 5, -5, std::i8::MAX,
             std::i8::MIN + 1, 100, -100, -32);

After
let a = i8x32::new(
            0,
            1,
            -1,
            2,
            -2,
           3,
            -3,
            4,
             -4,
             5,
             -5,
             std::i8::MAX,
             std::i8::MIN + 1,
             100,
            -100,
            -32,
             0,
            1,
             -1,
             2,
             -2,
             3,
             -3,
             4,
             -4,
             5,
             -5,
             std::i8::MAX,
             std::i8::MIN + 1,
             100,
             -100,
             -32,
         );

Should probably just skip calls like this.

@nrc is this fixed, or should I just not have this method? we are using rustfmt in stdsimd, and... if you have an u8x32 then the new` constructor really does take 32 arguments... such is life :D

You should use a skip attribute on a call like this.I think it is unlikely that rustfmt ever will (or even could) format a call like this nicely.

This is what I ended up doing. This issue was filled because I thought that adding a Compressed variant to fn_call_style would fix this everywhere for us. Turning such a feature on would probably eliminate 90% of the skips in the stdsimd code base.

The trouble is that for most function calls, compressed is a pretty bad formatting style and we have no way of forcing an option on for some calls. We'd need to be 'smart' about when to apply different styles and people generally don't like these kind of 'heuristic' changes.

I personally like to maximize use of vertical space so compressing function arguments is not that bad.
I agree that it doesn't look very nice, but nice-looking code is not what I expect from an automatic formatting tool, the only thing I expect is that the resulting code doesn't need to be horrible. I am willing to live with overall worse looking code if that saves me having to write a lot of skip annotations (because for me the most important thing is to not have to worry about formatting at all).
The stdsimd crate is not a typical crate, so such an option shouldn't be the default, and probably it is not worth it to implement it, but I would personally find it handy for this particular crate.


new(zfs-localpv): Functional/Validation test for custom-topology support for zfs-LocalPV

Signed-off-by: Aman Gupta<EMAIL_ADDRESS>
What this PR does / why we need it:

This PR adds functional test for custom-topology support for zfs-localpv.
Ref: https://github.com/openebs/zfs-localpv/blob/master/docs/faq.md#6-how-to-add-custom-topology-key

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #354

Ansible logs:
custom-toplogy ansible logs.txt

lets not use i/w to denote the binding mode. Lets use immediate/wfc respectively

pipeline script: https://github.com/mayadata-io/e2e-nativek8s/pull/26


Source map inlining support for @swc-node/register

The compiler in @swc-node/core supports the option "inline" for the sourcemap option, but @swc-node/register doesn't provide a configuration option for it.
When debugging node code using Chrome Dev Tools, it would be nice to be able to inline the source map in order to debug using the original source maps. Would it be possible to pass through the option to the underlying transformer somehow?

Wow, that was quick! 😁 Thanks!


Always space provided to user game stats, even when disabled

I'd rather disable user game stats because it doesn't look very nice. But when I do, I get an empty space where the user game stats would normally be. Only happens with games that provide stats. Nothing major, just a bit annoying due to the empty space.

Compared to for example

Which is visually more pleasing.
Using Magpie, but not the provided integration because it doesn't allow for the customisation I want.

Is the issue fixed on Playnite 9 beta?

Unfortunately I am unable to test this directly given that the theme does not have a version compatible with playnite 9. Using the Harmony theme however, the space allocated to user stats disappears when disabling user stats.
So I assume that either the issue is fixed or, if the issue persists with Magpie should it get a Playnite 9 update, the issue is not on your end. I'll close with this comment.


Compile Problem

I tried to compile the library and got an error that c++11 was not enabled. I tried using g++ 4.7, 4.8 and 4.9 on Ubuntu 14.04.
This is the beginning of the output of make using g++ 4.8:
In file included from /usr/include/c++/4.8/chrono:35:0,
                 from /home/demian/Documents/FastPFor/headers/common.h:31,
                 from /home/demian/Documents/FastPFor/headers/bitpacking.h:9,
                 from /home/demian/Documents/FastPFor/src/bitpacking.cpp:1:
/usr/include/c++/4.8/bits/c++0x_warning.h:32:2: error: #error This file requires compiler and library support for the ISO C++ 2011 standard. This support is currently experimental, and must be enabled with the -std=c++11 or -std=gnu++11 compiler options.
 #error This file requires compiler and library support for the \
  ^
In file included from /home/demian/Documents/FastPFor/src/bitpacking.cpp:1:0:
/home/demian/Documents/FastPFor/headers/bitpacking.h:11:26: error: ‘uint32_t’ does not name a type
 void __fastunpack0(const uint32_t *  __restrict__ in, uint32_t *  __restrict__  out);
                          ^
/home/demian/Documents/FastPFor/headers/bitpacking.h:11:51: error: ISO C++ forbids declaration of ‘in’ with no type [-fpermissive]
 void __fastunpack0(const uint32_t *  __restrict__ in, uint32_t *  __restrict__  out);
                                                   ^
/home/demian/Documents/FastPFor/headers/bitpacking.h:11:55: error: ‘uint32_t’ has not been declared
 void __fastunpack0(const uint32_t *  __restrict__ in, uint32_t *  __restrict__  out);
                                                       ^
/home/demian/Documents/FastPFor/headers/bitpacking.h:12:26: error: ‘uint32_t’ does not name a type
 void __fastunpack1(const uint32_t *  __restrict__ in, uint32_t *  __restrict__  out);

This is the output of cmake:
-- No build type selected, default to Release
-- The CXX compiler identification is GNU 4.8.2
-- The C compiler identification is GNU 4.8.2
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- TEST TEST
-- Performing Test SUPPORT_SSE42
-- Performing Test SUPPORT_SSE42 - Success
-- Performing Test SUPPORT_AVX
-- Performing Test SUPPORT_AVX - Success
-- Performing Test SUPPORT_AVX2
-- Performing Test SUPPORT_AVX2 - Success
-- CMAKE_SIZEOF_VOID_P (should be 8): 8
-- Good. You appear to have a 64-bit system.
-- CMAKE_CXX_COMPILER_ID: GNU
-- CMAKE_C_COMPILER: 4.8
-- CXX_COMPILER_VERSION: 4.8
-- SSE 4.2 support detected
-- Snappy was found. Building additional targets codecssnappy and inmemorybenchmarksnappy.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/demian/Documents/FastPFor/build

I would really appreciate if you could have a look at this and help me compile your library

That is an odd error. Let me investigate. I will get back to you.
The error is clear enough, but the makefile should have added the required flag.

I also had the same problem when just calling cmake. But adding CMAKE_BUILD_TYPE like this
cmake .. -DCMAKE_BUILD_TYPE=Release
solved the problem.

Thats odd because in the output of the makefile it says that it defaults to release but it solved this error for me. Thanks!
I didn't notice this works because I got another error on SSE 4.1 when I did it but I solved this with an additional compiler flag.

@simongog  @Hespian
I think I fixed the problem. My take on the issue is that we used to set, temporarily the build type for the duration of the cmake script, but we actually want to write the build type to cache if it is not specified.
Could be that the cmake people simply do not like the idea of a default build type...
Thanks for your feedback.

Thanks Daniel @lemire; I have just tested it again. The fix works for me.


Owin/Nancy Sample

Hi Guys,
Look this may exist already in which case just point the finger to the applicable sample.
I'm going to be hosting an APP that uses Nancy and some other middleware. I want to do my identification and authorization in the main 'parent' application and set the relevant owin security stuff so that Nancy (and whatever other middle ware) have access to it.
https://github.com/jchannon/Owin.StatelessAuth/blob/master/src/Owin.StatelessAuthExample/Startup.cs
This guy I believe has a package that does what i'm after but I suspect there is a way to do this with the existing IdentityServer / IdentityModel libs.
So far i've just been doing:
 //Token Verification
   app.UseIdentityServerJwt(new JwtTokenValidationOptions {
     Authority = IdSvr.BaseAddress
  });

But I'm sure there is some more plumbing required and I'm struggling to find specifically what that is.
Thanks in advance

@galenp @leastprivilege is this information still relevant? I'm trying to get my Nancy API up and running with IS.. installed the Nancy.MSOwinSecurity package, but i can't find a reference to app.IdentityServerJwt or SecurityConfig.Register or app.UseJsonWebToken. It seems all these methods/techniques have been deprecated.
By the looks of the current methods and the samples i've read, i should be using app.UseIdentityServerBearerTokenAuthentication in a similar way to here
Can either of you advise and/or point me to the latest sample of how i should be setting up IdentityServer3 in Nancy?

Just looking for you now @RPM1984 ...

Thanks @galenp ! :smile: :clap:

These are the packages I'm using.
  <package id="Nancy" version="1.2.0" targetFramework="net45" />
  <package id="Nancy.Hosting.Owin" version="0.16.0" targetFramework="net45" />
  <package id="Nancy.MSOwinSecurity" version="1.0.1" targetFramework="net45" />
  <package id="Nancy.Owin" version="1.2.0" targetFramework="net45" />
  <package id="System.IdentityModel.Tokens.Jwt" version="4.0.0" targetFramework="net45" />
  <package id="Thinktecture.IdentityModel.Client" version="4.0.1" targetFramework="net45" />
  <package id="Thinktecture.IdentityModel.Owin" version="1.0.0-beta1" targetFramework="net45" />
  <package id="Thinktecture.IdentityModel.Owin.ResourceAuthorization" version="1.0.1" targetFramework="net45" />
  <package id="Thinktecture.IdentityServer3.AccessTokenValidation" version="1.1.0" targetFramework="net45" />

  public static class SecurityConfig
    {
        public static void Register(IAppBuilder app)
        {
            JwtSecurityTokenHandler.InboundClaimTypeMap = new Dictionary<string, string>();

            //Token Check
            //app.UseOAuthBearerAuthentication(new OAuthBearerAuthenticationOptions {
            //    Provider = new EnhancedAuthenticationProvider(),
            //    AuthenticationMode = AuthenticationMode.Active
            //});

            app.UseIdentityServerBearerTokenAuthentication(new IdentityServerBearerTokenAuthenticationOptions
            {
                AuthenticationMode = AuthenticationMode.Active,
                Authority = IdSvr.BaseAddress
            });

        }
    }

Registered in startup  Configuration
  SecurityConfig.Register(app);

I've got this extension method
 public static class NancyModuleExtensions
  {
    public static bool HasAuthNancyUser(this INancyModule module)
    {
      return module.Context.CurrentUser != null && UserIdentityExtensions.IsAuthenticated(module.Context.CurrentUser);
    }

    public static void RequireKatanaAuthOtherwiseNancyAuth(this INancyModule module)
    {
      ModuleExtensions.AddBeforeHookOrExecute(module, (Func<NancyContext, Response>) (ctx =>
      {
        IAuthenticationManager authenticationManager = NancyContextExtensions.GetAuthenticationManager(ctx, false);
        if (authenticationManager == null || authenticationManager.User == null || !authenticationManager.User.Identity.IsAuthenticated)
        {
          if (NancyModuleExtensions.HasAuthNancyUser(module))
            return (Response) null;
          return (Response) HttpStatusCode.Unauthorized;
        }
        ctx.CurrentUser = (IUserIdentity) new NancyPropertyCompassUserIdentity(authenticationManager.User);
        return (Response) null;
      }), "Requires MS Owin authentication");
    }
  }

Which allows me to just add this in the constructor of each Nancy module
  this.RequireKatanaAuthOtherwiseNancyAuth();

And in each Nancy method you can do
 var user = Context.CurrentUser;

So from my recollection (and its been a while):
App is configured to validate incoming tokens with IdentityServer.
Requests to modules that have RequireKatanaAuthOtherwiseNancyAuth have a hook that validates that we have a identity in context.

Awesome, i'll give this a try... thanks so much @galenp !

Any thoughts or good samples for Nancy + IdentityServer4 all on NetCore? The part I feel I'm missing right now is a compatible rough equivalent to Nancy.MSOwinSecurity that works with NetCore.

Just to tie off my question: http://stackoverflow.com/questions/43006280/nancy-and-identityserver4-on-net-core.


Chain should be some metadata for rending and filtering on the web console

What would you like to be added:
As the issue title, some metadata fields we can have such as

name
labels

https://github.com/pipe-cd/pipe/blob/master/pkg/config/application.go#L580
Why is this needed:

/assign @khanhtc1202


Chakra version isn't showing on dropdown

Subject
Homepage
Description
The latest and previous Chakra version isn’t showing up on dropdown (top right screen).

I would like to work on that one next. Already did some research and found stuff i can start from.


Add network_id to ServerInfo respones

This value was added to rippled v1.11.0. Unclear if this is planned for reporting-mode (likely will occur for Clio), but in any event should probably be optional for backward compatibility...?

See https://github.com/XRPLF/rippled/pull/4370 for the commit to rippled.


test: removes log.Fatal and log.Panic

Description of your changes: Logging altered to remove log.Fatal and log.Panic
Which issue is resolved by this Pull Request:
Resolves #389
Checklist:

[x] Documentation has been updated, if necessary.
[x] Pending release notes updated with breaking and/or notable changes, if necessary.
[x] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[x] Code generation (make generate) has been run to update object specifications, if necessary.
[x] CRD manifests generation (make manifests) has been run to update CRD manifests yaml file specifications, if necessary.
[x] Update dependencies (make vendor) has been run to update Gopkg.lock file, if necessary
[x] RBAC permissions in clusterrole.yaml have been updated to include new types, if necessary
[x] All related commits have been squashed to improve readability.
[x] Comments have been added or updated based on the standards set in CONTRIBUTING.md

Thanks for this effort @hasheddan!


feat(Modal): Create a Modal using shorthand props

can pass modal header, content, and actions via shorthand props (#1390)

can pass actions props a triggerClose option that will allow buttons to control open/closing modal

Codecov Report

Merging #1508 into master will decrease coverage by 0.25%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   99.74%   99.49%   -0.26%
==========================================
  Files         141      141
  Lines        2384     2381       -3
==========================================
- Hits         2378     2369       -9
- Misses          6       12       +6

Impacted Files
Coverage Δ

src/modules/Modal/ModalActions.js
100% <100%> (ø)
:arrow_up:

src/modules/Modal/Modal.js
91.3% <33.33%> (-8.7%)
:arrow_down:

src/modules/Dropdown/Dropdown.js
100% <0%> (ø)
:arrow_up:

src/modules/Checkbox/Checkbox.js
100% <0%> (ø)
:arrow_up:

src/collections/Form/FormField.js
100% <0%> (ø)
:arrow_up:

src/elements/Button/Button.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4319f0b...2f1ff84. Read the comment docs.

I've made the changes.

I've made the changes, and I added an example.

Changes are made - I've enjoyed learning whats going on under the hood a bit more.

I added some tests to Modal.
I had to add _.isPlanObject(action) to prevent implementsShorthandProp from failing for actions:
{_.isNil(children) && ModalActions.create(_.forEach(actions, (action) => {
  if (_.isPlainObject(action) && action.triggerClose) action.onClick this.handleTriggerClose(action.onClick)
}))}

Is there anything I should change/fix here?

Thanks, folks! As a heads up, I'll be out on travel for a week starting today. Expect silence from me during this time, however, I will try to catch some mobile updates as I am able.

@levithomason I've resolved merge conflicts, will be glad to receive your review there 👍

Changes look great, merging!

Released in<EMAIL_ADDRESS>


Startup very slowly, about 10 senconds

Steps to reproduce
Double click the pwsh.exe, need wait about 10 seconds to show the prompt.
If I append the -NonInteractive parameter, it shows the prompt immediately.
When I input $psver and press TAB key, it will block everything for about 10 seconds also. others such as Get-date, [System.Environment]::CurrentDirectory ... works fine.
Environment data

PS C:\Users\chenyj> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0-rc.1
PSEdition                      Core
GitCommitId                    7.0.0-rc.1
OS                             Microsoft Windows 6.1.7601 Service Pack 1
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

What do you see with -NoProfile parameter?

With -NoProfile parameter works like without parameter.

NonInteractive disable PSReadline module importing. If you run with NonInteractive and import PSReadline how long has this been going on?

Just like without parameter

Can you try with disconnected network interface?

The machine has no internet access.

My request was to detach network cable at all.
I think it is dup https://github.com/PowerShell/PowerShell/issues/10983.

I still have this behavior with 7.1.0, whould I create an issue?

@Silex Please open new issue with repro steps - we need to reproduce the issue to investigate.


[ODS-5059] Implement code changes to redirect Write auth checks to use the new tuple table only

Please ignore failed MetaED Integration build and not related with this code change

@gmcelhanon   I had test method around for authorizationPathModifier for positive case and negative case


Changed ui of home page and page of every topic #18

solved issue #18
before
https://github.com/user-attachments/assets/fce5988b-b7d3-4901-8bdc-4fc168f70fdf
after
https://github.com/user-attachments/assets/425cdf52-879c-4f44-becd-b1a29ef0bda5

@neerajrathore , I have opened a PR please review it and suggest any changes if needed

@bhaavvya Found a solution for markdown displaying as HTML. look commit
As you created new UI and you would be having best exposure, can you these changes in other files as well?


Package manager integration

Hello there.
I like this project a lot and recently tried to install it on a new project and realised there was no way to install it with Unity Package Manager (UPM).
So i was wondering if you would be open to a discussion and/or pull request about integrating this asset with the new package manager?
I've been playing around with it on a local fork and managed to get it working (see screenshot below). But that would mean changing the folder structure of the project (no code change though), because currently UPM includes all files in a repository (it's on the roadmap).
I've created a really quick and dirty fork here to show what the folders structure might look like.
I think we could make it a lot cleaner but here is a quick list of things i came across to get to this result:

UPM includes all folders/files in the project. This is problematic because we don't want the ProjectSettings and Packages folders to be included.
UPM will ignore folders with a ~ suffix. So i've moved the Editor and Examples folder to the root and rename Aseprite2Unity to Aseprite2Unity~ as a quick way to exclude it.
UPM has a way to link/import sample code. So we can point to the MegaDad example  (see package.json). I've taken the liberty to rename it to Samples~ since it's the convention the unity packages use, but that's totally optional.

To use it, you would just have to add this line to your manifest.json for unity to install it.
"aseprite2unity": "git@github.com:Seanba/Aseprite2Unity.git",
// or git@github.com:cbellino/Aseprite2Unity.git for the proof of concept

Okay reading back on what i wrote, that's a bigger comment than i thought it would be (sorry about that). So i would totally understand if you don't have the time or don't want to go this way, no worries :)
Cheers.
What it looks like in the editor:

Hi there, @cbellino. I like the idea of using the UPM. Ideally that's how everyone would get my tools.
Is there a way register the package with Unity so that people don't have to modify their manifest?

That's great to hear :) I think moving forward it will be the default way to import tools into Unity.

Is there a way register the package with Unity so that people don't have to modify their manifest?
I was wondering about that too ! I'll look into it. For now, the Package Manager UI have an add by URL button that people can use and put the git repository URL instead of editing the manifest (still not ideal i know).

After some research, i don't think Unity offers to register packages to their repository (yet ?).
One alternative they offer is to create your own registry but that still forces users to edit the manifest file.

Hi again, @cbellino.

For now, the Package Manager UI have an add by URL button ...

Hmmm ... I can't find any button on the Package Manager for adding a package by URL. Are you on a Unity beta? (I'm currently on Unity 2019.2).

Ah, sorry about that. I was indeed on the 2020 alpha ! Didn't realise this button was not in 2019.
If you need me, i'd be happy to help where i can :)


unregisterForLocationUpdates?

i registerForLocationUpdates multiple times (from time to time). Is it necessary to have an unregisterForLocationUpdates?

Your most recent registerForLocationUpdates should overwrite all the past callbacks. You should only get a location update from one callback at a time. I didn't write in support for multiple listeners so thats the way it should act.
Although I haven't tested it out so there may be different behavior. Let me know if thats not what you observe

@pmwisdom got it. i wrap the background positioning logic in an Observable and just have no idea how to do the cleanups. currently I just put backgroundLocationServices.stop() in the cleanup callback and it seems to behave correctly.


NetworkTransformBase onlySyncOnChange=false does not send actual position/rotation/scale values every sendInterval

Describe the bug
Just to give a bit of context, in my project network transforms / child network transforms are rarely updated. Since the CmdClientToServerSync and RpcServerToClientSync are specified as channel=unreliable it's possible that dropped packet will cause those transforms to not be properly synchronize till next change that's over sensitivity.
To get that sorted I wanted to send data every 0.5 second regardless of any changes. I assumed this will be what onlySyncOnChange does.
The tooltip does suggest it's not entirely the case with 'When true, changes are not sent unless greater than sensitivity values below.'
Although it's quite confusing.
Code would also suggest that intention was bit different, with
Mirror.NetworkTransformBase.UpdateServer:352
#if onlySyncOnChange_BANDWIDTH_SAVING
                cachedSnapshotComparison = CompareSnapshots(snapshot);
                if (cachedSnapshotComparison && hasSentUnchangedPosition && onlySyncOnChange) { return; }
#endif

That'd suggest with no changes to snapshot and onlySyncOnChange=true it'd return early, with false it's allowed to proceed but then bit further
#if onlySyncOnChange_BANDWIDTH_SAVING
                RpcServerToClientSync(
                    // only sync what the user wants to sync
                    syncPosition && positionChanged ? snapshot.position : default(Vector3?),
                    syncRotation && rotationChanged ? snapshot.rotation : default(Quaternion?),
                    syncScale && scaleChanged ? snapshot.scale : default(Vector3?)
                );
#else

it'll always send null for position / rotation / scale as there's no consideration for onlySyncOnChange.
[IMPORTANT] How can we reproduce the issue, step by step:
Please tell us how to reproduce your issue, STEP BY STEP, with one of our built in examples.

Run any server and 2 clients with any NetworkTransform or ChildNetworkTransform, with onlySyncOnChange = false
Move transform on client
Artificially introduce packet drop so that value never reaches server or drop packet that will go from server to other client
Do not further move transform

Expected behavior
I'd expect values to be synchronized every sendInterval if onlySyncOnChange is false. Or there'd be a different switch to specify that changes should be always synchronized regardless of changes
Desktop (please complete the following information):

OS: Windows
Build target: Windows
Unity version: 2020.3
Mirror branch: master (commit a9f9becf7a460b9fc83da32447b0fa1298560a06)

Additional context
If the intention for onlySyncOnChange=false is to send data every send interval then following can fix the issue.
RpcServerToClientSync(
    // only sync what the user wants to sync
    syncPosition && (positionChanged || !onlySyncOnChange) ? snapshot.position : default(Vector3?),
    syncRotation && (rotationChanged || !onlySyncOnChange) ? snapshot.rotation : default(Quaternion?),
    syncScale && (scaleChanged || !onlySyncOnChange) ? snapshot.scale : default(Vector3?)
);

@JesusLuvsYooh @MrGadget1024 that's what I meant :)
you can turn off the option.
it was meant as a hack to save bandwidth until we get delta compression done, which will take some time.

@ninjakickja  ^

User has totally misunderstood the use of onlySyncOnChange.
"To get that sorted I wanted to send data every 0.5 second regardless of any changes. I assumed this will be what onlySyncOnChange does."
onlySyncOnChange does the opposite, it only sends values if something has changed (larger than sensitivity).
User also misread the code:
"it'll always send null for position / rotation / scale as there's no consideration for onlySyncOnChange."
lines numbers 352 and 445:
if (cachedSnapshotComparison && hasSentUnchangedPosition && onlySyncOnChange) { return; }
This is before any sending, so nothing is sent when onlySyncOnChange is TRUE. It does NOT send NULL like user suggested.
User's reproduction assumes that onlySyncOnChange will somehow FORCE sync EVEN when packets are dropped. That is totally not the intended usage, and also DOES NOT HAPPEN for the ORIGINAL NT2K, since NT operates only on Unreliable.
With this, if I have misunderstood the intention of the user, please let me know, otherwise I'd consider this closed.
vis2k,
onlySyncOnChange might be a hack, but until you have delta compression which may take some (unknown) time, users will continue to ask for it.

Thanks @ninjakickja, I don't want to push any buttons here. I've been merely pointing out that by setting that flag to false I'd assume data will be send every sentInterval. Not that the behaviour itself is wrong.
I don't expect it to somehow magicaly detect packet drop over unreliable channel as that's not how unreliable channel works of  course. What I was expecting will happen in that packet-drop situation was second update to be sent at specified syncInterval - which would sort my issue.
I'm also afraid you're wrong in saying the code won't sent update with null values. That's exactly what happened during debugging. Execution does not exit early in here:
if (cachedSnapshotComparison && hasSentUnchangedPosition && onlySyncOnChange) { return; }
as onlySyncOnChange = false
and then goes further to:
syncPosition && positionChanged ? snapshot.position : default(Vector3?),
in that case positionChaned is false as client does not see any change from previous update (but server did never got the update so they are out of sync now) - code will evaluate to default(Vector3?) which will be null and that's what's then received at the server.
Btw I usually go by Chris, not User :) thanks for your work on Mirror - it's a great tool.

Thanks, you're right and that's what I've tried and found but that call is made to the server with data (position/rotatio/scale) = null as for the end running the code there's no difference from previous snapshot.
Say:
1st call:  - CmdClientToServerSync(Vector3(1,1,1), , )
Vector3(pos) - resolves correctly as syncPosition[true] && positionChanged[true] ? **snapshot.position** : default(Vector3?)
Package is dropped on the way to the server, server thinks transform is still at 0,0,0 position
2nd (and subsequent) call(s) after sendInterval
 - CmdClientToServerSync(null, null, null)
Call is made but data resolves to null as syncPosition[true] && positionChanged[**false**] ? snapshot.position : **default(Vector3?)**
This is as positionChanged  is being resolved by comparing with previous snapshot, and that correctly resolves to false - transform did not move on client [but server still have incorrect data].
With that till there's a change to transform the data will actually not be sent to the server. That's the bit that was confusing.
I suppose in most cases that won't matter as transform on client is likely to change quite often and data will be sent when that happens. I think it's my use case where transform is moved very infrequently that's making this one visible.
Happy to leave it as that, it seems it's as designed and will be changed soon with introduction of delta compression.
Thanks for help

Closing per user OP comments


Build Optimizations

Author Name: Javi Fontan (Javi Fontan)
Original Redmine Issue: 3022, https://dev.opennebula.org/issues/3022
Original Date: 2014-07-07

SConstruct files do not add @-O@ parameter to optimice code:
1. Compile flags
main_env.Append(CPPFLAGS=[
    "-g",
    "-Wall"
])

The flag can be added on build time setting @CFLAGS@ environment variable:
export CFLAGS=-O3

The idea of following changes in packaging is not just set the higher build-time optimizations, but more to

build packages with standard parameters proposed on each platform and
enable the features which make the binaries more "secure".

Current state
Right now, we depend
a) mainly on defaults of GCC on each target
b) just very simple CFLAGS, CXXFLAGS we set right before the build
https://github.com/OpenNebula/packages/blob/0a53c1e0d1401ff6a36fd2d61f36651278266bdd/sources/build_opennebula.sh#L14-L18
c) general defaults we set in SConstruct (-g, -Wall, --std=c++11)
https://github.com/OpenNebula/one/blob/7b03f719d69c171319d89e7378331d074eb585e5/SConstruct#L116-L124
Today, it's pretty standard to enable security features like PIE or stack protector (see https://developers.redhat.com/blog/2018/03/21/compiler-and-linker-flags-gcc/). On some platforms, these things are already enabled in defaults of the GCC, on some it's necessary to enable them.

Proposed state
The following PRs don't set any particular compiler / linker options, but allows to pass the options proposed by the distribution packages build tools. Moreover, they also request using hardening options everywhere (although some platforms use them by default).
As a result, the produced binaries have ALL features on ALL targets listed on the table above.
Note: related to -O3 optimization requested originally, no platform builds packages with -O3, but just -O2. So, I'm not enforcing higher optimization levels.
PRs to merge into master:

one: https://github.com/OpenNebula/one/pull/3707
packages: https://github.com/OpenNebula/packages/pull/103
development: https://github.com/OpenNebula/development/pull/719
docs: https://github.com/OpenNebula/docs/pull/761

Example of single gcc invocation on CentOS 7

before

g++ -o src/host/HostPool.o -c -DGITVERSION='"not known"' -fPIC -Wno-error=format-security -g -Wall -std=c++11 -DSQLITE_DB -DMYSQL_DB -DSYSTEMD -Iinclude -Isrc/parsers -I/builddir/build/BUILD/xmlrpc-c/install/include -I/usr/include/mysql -I/builddir/build/BUILD/xmlrpc-c/install/include -I/usr/include/libxml2 src/host/HostPool.cc

after

g++ -o src/host/HostPool.o -c -DGITVERSION='"not known"' -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -g -Wall -std=c++11 -DSQLITE_DB -DMYSQL_DB -DSYSTEMD -Iinclude -Isrc/parsers -I/builddir/build/BUILD/xmlrpc-c/install/include -I/usr/include/mysql -I/builddir/build/BUILD/xmlrpc-c/install/include -I/usr/include/libxml2 src/host/HostPool.cc

(parameters are specified twice as they are set both in CXXFLAGS and CPPFLAGS)

Nice!!!!!!! :smiley:


fix: bump rasterio and correctly reproject ukcp18 2.2km

What this PR is:
From: https://github.com/developmentseed/os-climate-hazard/pull/17

Bumps rasterio to >=1.4b1 so we can use src_geoloc_array in reprojecting
Implements a fix to 2.2km UKCP18 data with the above parameter to correctly reproject rotate poles data
Updates UKCP18 Notebook with better examples

@joemoorhouse No rush on this but incase it's gone under your radar 🫶 thanks!


[WIP] Create Table Contract

Create Table Contract which enables a wallet to create the table by setting the initial start bet value. The wallet which initializes the contract will be the first player on the table.
Another player will be able to join the table and transfer the money to the pot.

The on-chain throwing error, required to identify if it is due to enum.

Implement Pausable to the smart contract https://github.com/Supercolony-net/openbrush-contracts

https://github.com/paritytech/ink/pull/1217
having issue as the 3.1.0 version might have changed the way storage

issue resolved by hardcoded the ink version to 3.0.1
https://substrate.stackexchange.com/questions/2721/cargo-contract-3-0-1
there are a few issues with the latest ink 3.1.0 -> migrate to it later


Fixed move_to patch

Missed a line when uploading.

reverted the original pull request for now, think there might be issues if the relativePath isn't enabled in certain circumstances. Additionally I think this behavior may be better off being optional


test(expand): add test coverage to expand

Description:
This PR adds test coverage to expand operator, cases where scheduler is specified.
Related issue (if exists):

Coverage increased (+0.06%) to 97.187% when pulling 641f501ebe0507f8a4daeb9bbdac73dd3b3f4222 on kwonoj:test-expand into e91d113e49acc9b0e12e2524040fa84cf3fa2c78 on ReactiveX:master.

PR's updated per suggestion.

Coverage increased (+0.06%) to 97.187% when pulling daee81e080ccba6fc5601ebadd903d39f42fc1a3 on kwonoj:test-expand into e91d113e49acc9b0e12e2524040fa84cf3fa2c78 on ReactiveX:master.

LGTM

Coverage increased (+0.06%) to 97.187% when pulling 6e0155f48d4183a1969bedd3105d03638f402149 on kwonoj:test-expand into 2a40fb637dba1a62765cd5342ec902c320224af3 on ReactiveX:master.

Coverage increased (+0.06%) to 97.187% when pulling 6e0155f48d4183a1969bedd3105d03638f402149 on kwonoj:test-expand into 2a40fb637dba1a62765cd5342ec902c320224af3 on ReactiveX:master.

LGTM too, needs rebase.

Coverage increased (+0.06%) to 97.187% when pulling 57959e995b92acb0ce547059888e07783c866c62 on kwonoj:test-expand into bf64ad5a5196ed6a6344a9b7fb059f3e6804c8ec on ReactiveX:master.


Add International Womens Day to DE-MV

@ihmels Can you add the appropriate unit tests for your change? Also, if you have any documentation or reference for this change, that would be great.

I have added a test.
The source is https://www.ndr.de/nachrichten/mecklenburg-vorpommern/Frauentag-in-MV-Landtag-beschliesst-neuen-Feiertag,frauentag370.html. However, there is another source on Wikipedia that is already referenced via Germany::getSources().
Where is the best place to put the source?

@ihmels Good point regarding the source. You could override the getSources method while adding the additional link.

@ stelgenhof I've added the source and fixed the namespace in the test. Can you run the workflow again for these changes?

@stelgenhof Can you approve the workflow again?

@ihmels Can you check you once more?

The error was.

ERROR: InvalidReturnStatement - src/Yasumi/Yasumi.php:245:16 - The inferred type 'array<string, array<array-key, string>|null|string>' does not match the declared return type 'array<string, string>' for Yasumi\Yasumi::getProviders (see https://psalm.dev/128)
       return $providers

This error was not related to my changes, but I fixed it. Can you run tests again?

@ihmels I've made some fixes on the develop branch that would make your PR error free. Can you rebase your branch? Thanks.


Fix delete endpoint

This PR is based on #269, the diff will make more sense once that is merged, but I thought I'd create this anyway so I don't forget ;)

This branch now has conflicts FYI

Updated!


Soften sharp path vectors

I've been using this library instead of potrace as it's faster and modern but I've found potrace tends to soften/round its paths (correct term?) so they aren't quite so sharp, whereas I'm unable to do this on imagetracerjs.
Is it possible for you to put in an option please, or have I missed an existing option somewhere?
imagetracerjs and potrace comparison respectively (nb. ignore the palette differences, it is the same image but rotated slightly).

Hi,
I recommend using the curvy option preset or setting options.ltres = 0.01; . See also: https://github.com/jankovicsandras/imagetracerjs/blob/master/options.md

Thanks I've used the ltres option and it's looking very similar now. Amazing software, thanks for making it :)


Updated navbar active link

I updated the navbar active link class

Hey @Joshua-Nweze , have you created your own branch and pushing the code there or raising the PR directly to the main branch.

Hey @Joshua-Nweze , have you created your own branch and pushing the code there or raising the PR directly to the main branch.

He's created a PR from his to the main branch.

Why it's showing that it has 2 neutral checks? @sayands @AneeshBose

Why it's showing that it has 2 neutral checks? @sayands @AneeshBose

Probably a netlify thing.


chat is not auto updating.

when I am in a conversation, then the customer support messages not updating . need to go back and forward then the chat will update.

Hey there, I don't use the Zendesk chat so my knowledge about it is limited. But doing a quick search it seems that real time updates are not supported by default (see). So perhaps this has to be handled using push notifications (which unfortunately are not supported yet) or in another way inside the app.
I'll leave this open in case somebody has an insight on how to solve it. Happy to help with the solution.


Feature request: Specify custom console

I'm trying to use apollo-link-logger in React Native and it turns out group and groupEnd are not supported by the default global console in React Native. We would like to use our own custom console implementation but there's no way to do that without polluting the globals.

It would be very useful for apollo-link-logger to support custom console objects. Thanks!

Are you getting any errors? AFAIK both are supported.

React-native has a "Debug JS Remotely" mode where Chrome is used as JS runtime, which supports console.group/groupEnd. But when debugging mode is off, it uses JavaScriptCore, which doesn't support console.group.
See: JavaScript Environment · React Native
For example,
console.group('test');

will result in:

I also added the screenshot to the original comment.

I can confirm this is a problem in version 1.0.4. When debugging mode is turned off, using this link results in a network error that can be traced back to this console.groupCollapsed call.

Thanks. I’ll take a look this Saturday.
--
Best Regards,
Adrian Perez
https://adrianperez.codes
On December 5, 2017 at 8:21:58 PM, Adam Savitzky<EMAIL_ADDRESS>wrote:

I can confirm this is a problem in version 1.0.4. When debugging mode is
turned off, using this link results in a network error that can be traced
back to this console.groupCollapsed
https://github.com/blackxored/apollo-link-logger/blob/c77b2c72f8d5eb13208c278fe6dae4fab3aca882/src/index.js#L13
call.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/blackxored/apollo-link-logger/issues/1#issuecomment-349412230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIIvOiNfJ5E8FKJa28-R3yPl1kIQ9pjks5s9ZfWgaJpZM4Q0dVy
.

@blackxored Take a look at #3. Should fix the problem.


Improve review feature documentation

Summary:
Currently our review tool is not well documented. It is not clear what happens when user click to buttons. This lack of information may prevent users from using this tool, since they don't know what they effect. Some infoboxes can be added to inform users about.

@neslihanturan  can I work on this ?

@neslihanturan Can I work on this?

Excuse my question but:
Are you looking for the application to see small banners of what each button does or a small section where you can see screenshots of the actions to be performed by the app?

Hi. Is this issue closed/worked on, or should i work on it?

do you mean adding the type of info buttons that are in this image to these two options at the bottom?
If I would throw a solution out there, maybe we should just modify what the boxes that are already there say?To make it even more clear? But, i'm not sure if it would NOT be repetitive if we add info boxes next to both of those options at the bottom?

@neslihanturan Can I work on this issue?

Hi, I'd like to contribute. Could I get a few pointers on how to get started?

Hi, I would like to work on this issue if nobody is assigned.

I had revised the tool tip review button to have three different options that have alert boxes that go into a little more detail for this issue

Hi everyone seemed to interested, sorry for the latency of the response. Based on the mockups shared, I decided to explain what is in my mind about this task in more details:

A rounded info button next to Peer Review title should exists
When clicked to that button a group of explanation of each function of this feature should be visible. This explanation should be a detailled explanatin, ie. "when you say "no out of scope", you are adding a nomination for deletion template to this image."
Every question should have their own info buttons at their near
When they are clicked a detailed (what is happening on commons side when both of these options are clicked) explanation should appear.

Hi everyone seemed to interested, sorry for the latency of the response. Based on the mockups shared, I decided to explain what is in my mind about this task in more details:

A rounded info button next to Peer Review title should exists
When clicked to that button a group of explanation of each function of this feature should be visible. This explanation should be a detailled explanatin, ie. "when you say "no out of scope", you are adding a nomination for deletion template to this image."
Every question should have their own info buttons at their near
When they are clicked a detailed (what is happening on commons side when both of these options are clicked) explanation should appear.

Thanks for the detailed explanation.

@neslihanturan is this issue still open? can it be assigned to me?

@neslihanturan any updates on this issue? or is someone working on it

No one is working on it and the issue is still open :) A good start point would be answering how you plan to solve each bullets that I listed at https://github.com/commons-app/apps-android-commons/issues/3361#issuecomment-725372809 . @Dannyhh , are you interested?

Hi @neslihanturan Please assign me this issue as I'm a new bees here and love to contribute over documentation

Hi @neslihanturan Please assign me this issue as I'm a new bees here and love to contribute over documentation

Hello! @neslihanturan this issue was last assigned on 23rd of March and I noticed that it has been over 2 months since. If there haven't been any developments, can I please contribute to this. I am new to open source and I'd like to start with this documentation.

@nicolas-raoul  I would like to work on this issue and implement the feature told here, just verify it once,
if this is actually needed, assign me this issue

@Rishavgupta12345 Thanks please follow https://github.com/commons-app/apps-android-commons/issues/3361#issuecomment-725372809

@nicolas-raoul you can close this issue now

Please remove me from your mailing list
On Sat, Mar 26, 2022, 1:23 PM Nicolas Raoul @.***>
wrote:

Closed #3361
https://github.com/commons-app/apps-android-commons/issues/3361.
—
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3361#event-6311295358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM62UDN32PWCDVU6FCV7ZQ3VB2667ANCNFSM4KOTBMEA
.
You are receiving this because you commented.Message ID:
@.***
.com>

@AdityaArunSharma , you have to unsubscribe from the GitHub email notifications yourself, we can't do it for you.


fix custom ldap file and schema

Hi I'm using this image and trying to use customize ldfi file when initial, but this feature seem doesn't work
After I check startup.sh I find this issue
in line 44 should use ${CONTAINER_SERVICE_DIR},
because when using --copy-service the ${CONTAINER_SERVICE_DIR} will be /container/run/service
and the custom boostrap ldif execution in line 366 is using ${CONTAINER_SERVICE_DIR}/slapd/assets/config/bootstrap/ldif/custom

Thanks :)


Windows-2022 image does not seem to have .NET 6 SDK installed

Description
According to the list of installed software (in https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#net-core-sdk), .NET SDK 6.0.200 is expected to be present.
In the recent upgrade to windows-22, this breaks build pipelines because SDK 6 isn't installed.
According to the discussion in #4856, it should be installed as part of VS 2022.
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Image: windows-latest
Agent: Azure Pipelines 6
Failed build:
https://dev.azure.com/jet-opensource/opensource/_build/results?buildId=9452&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=0f0b056b-e9f7-5ce7-8817-a8ca2fd77699
Expected behavior
Build should not fail with SDK not found error.
Actual behavior
Build fails saying SDK 6.0 could not be found.
     A compatible installed .NET SDK for global.json version [6.0.200] from [D:\a\1\s\global.json] was not found.
        3.1.416 [C:\Program Files\dotnet\sdk]
      Install the [6.0.200] .NET SDK or update [D:\a\1\s\global.json] with an installed .NET SDK:
        5.0.104 [C:\Program Files\dotnet\sdk]
        5.0.211 [C:\Program Files\dotnet\sdk]
        5.0.303 [C:\Program Files\dotnet\sdk]
        5.0.405 [C:\Program Files\dotnet\sdk]

Repro steps
Run a build targeting .NET SDK 6 on the windows-latest image.

On Azure, windows-latest still points to windows-2019. See the log output of the top-level Windows job:

##[warning]windows-latest pipelines will use windows-2022 soon.

And the comment at https://github.com/actions/virtual-environments/issues/4856#issuecomment-1050662080:

GitHub migration completed! Azure DevOps one is delayed and will be completed by the end of March or even the beginning of April.

So for now you need to specify windows-2022.

Thank you.


export html linux (.deb) version do not show bg images

The preview below displays perfectly, but when exported to HTML, the background image is missing (even in local exports). The same .md file exports correctly on the Windows version.
Additional Information:
VSCode Version: code_1.95.1-1730355339_amd64.deb
Linux Distribution: KDE Neon 6.2 (fully updated)
Image Path: Verified as correct
test.md
test.html.txt

The exported HTML preserves the Markdown specify image path images/knapsack.jpeg. Web browser will resolve the image path from the location of file when browsing HTML, so you should export HTML to the correct location.
.
├── images/
│   └── knapsack.jpeg
├── test.md
└── test.html

If the image location is already confirmed as correct, check your browser's restrictions for HTML location. For example, if your KDE is working on Ubuntu, installed browsers may be a snap app. Because of security, some browsers restrict reading resources from local (file:///).
https://askubuntu.com/questions/1435757/firefox-cant-open-files

Thank you for your attention, @yhatt.
This isn’t an issue with an incorrect image path or browser permissions. I’ve tested in different browsers with the same result, and even uploaded the export to GitHub Pages, where the image still doesn’t display.
However, when I export using the Windows version, everything works as expected—both locally and on GitHub Pages.
Thanks again for your help!

If the browser is unable to display images, there should be some kind of error output on the browser. Open the browser’s developer tools, go to the Network tab, and check why the image resources are failing to load.
If possible, sharing a minimal reproducible example on GitHub Pages could help in identifying the cause of the issue.

The underlying issue may not yet be resolved, but since there have been no extra reports of this problem, we close this issue. We will consider that there is no issue with Marp itself.
If the issue still persists, please feel free to re-open the issue with the requested additional information.


Removed API Key and Secret

Not sure if you are intentionally giving these out or not :eyes:

You should also reset the git repo to remove it from previous commits, and also request a new API key :+1: stay safe out there

https://help.github.com/articles/remove-sensitive-data/

I created a special account on flickr for the project, but knowing me I will forget and something will go wrong!
Thanks for the help!


rebuild split object key with its paths

When hosted on Vercel and if the query parameters contain an encoded slash (eg. when files are in a folder) they will be split into an array of strings. This leads to elements in a folder not getting deleted because the objectKey is just the name of the first folder. This patch is aiming to solve that by rebuilding the objectKey including its paths.
I tried to explain it well, but please feel free to update naming and description of the PR.

[x] It must successfully build, test, and lint your branch
[ ] It must pass the dangerjs script
[x] It must be up-to-date with master
[ ] It must be approved by at least 1 tinacms core member
[x] It must have conventional-commits that clearly explain what has been changed

Hey @khnn,
Thanks for this contribution! We'll be looking into it shortly. 🦙

Hey @khnn,
Thanks for this contribution! We'll be looking into it shortly. 🦙

If you need any information or context let me know.


Config-wide locale

✓ Checklist:

[ ] This PR has been added to CHANGELOG.md (at the top of the list);
[ ] Tests for the changes have been added (for bug fixes / features);
[ ] Docs have been added / updated (for bug fixes / features).

Codecov Report

Merging #36 (d3a6485) into main (897873f) will increase coverage by 0.06%.
The diff coverage is 55.38%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   54.21%   54.27%   +0.06%
==========================================
  Files          37       37
  Lines        1437     1487      +50
==========================================
+ Hits          779      807      +28
- Misses        658      680      +22

Impacted Files
Coverage Δ

datanymizer_engine/src/lib.rs
100.00% <ø> (ø)

datanymizer_engine/src/settings/mod.rs
0.00% <0.00%> (ø)

datanymizer_engine/src/transformer/mod.rs
25.71% <0.00%> (-3.32%)
:arrow_down:

datanymizer_engine/src/transformers/pipeline.rs
0.00% <0.00%> (ø)

datanymizer_engine/src/transformers/template.rs
75.47% <0.00%> (-7.87%)
:arrow_down:

datanymizer_engine/src/transformers/mod.rs
86.36% <83.33%> (-13.64%)
:arrow_down:

datanymizer_engine/src/transformers/fk/mod.rs
95.13% <87.50%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897873f...e24587b. Read the comment docs.


Dialog Improvements

Since Dialog doesn't work with few modern browsers which lack of polyfill support, i believe there'll be a need for workaround for modal dialog instead of approaching custom elements. And addition of transition/animation scripting may require for following MDesign guidelines.

The polyfill is used since the <dialog> element is a W3C standard that provides exactly what is needed for them in an accessible manner with a clearly defined API. This reduces the amount of code we need to maintain and will help show other browsers that the dialog element is needed natively so they will implement it.
On the note of a custom dialog element, that would actually go in the opposite direction to using the dialog element polyfill. It would then require a polyfill of more intricate components and detailed setup which has less browser support than the dialog polyfill if a developer needs to support more engines. So, you'd include more and have more overhead while developing your application with fewer browsers able to use it.
Transitions and Animations are a little out-of-scope for the default dialog setup. The specification does not define how they should be animated in and in order to provide the most pleasing user experience their animation should fit with what the user interaction is that causes the appearance. Doing that internally is fairly intensive and would add a bit of weight to the codebase.

Hey @SayChunKim
We appreciate your input here, and will be revisiting this in #4486. In the meantime, as it says in our issue template we will not be making any major changes to our existing v1 components.
To @Garbee's point: the hope is that <dialog> eventually gets adopted by all browsers, and then we can remove the polyfill altogether. For that to work, dialogs would have to be robust enough to allow for the UX that Material Design mandates. We're still planning on using the dialog element for v2, but we're probably also going to wind up providing a more js-heavy fallback if people decide they cannot support it / don't want to use a polyfill.


Added interpolated reference frames, updated constrained low pass filter

and smaller misc changes.

+5147, -2219

That's a lot of changes, would it be possible to get a slightly more detailed changelog?