[Bug] Unable to recognize vocab.json, merges.txt tokenizer format

🐛 Bug
according to #31 , mlc-llm should already support vocab.json, merges.txt tokenizer formats.
But when I try to inference CausalLM/72B-preview-llamafied-qwen-llamafy I run into the error that can't find the tokenizer
>>> from mlc_chat import ChatModule
>>> cm = ChatModule(model="/home/alphaarea/models/CausalLM-7B-DPO-alpha-q0f16", model_lib_path="/home/alphaarea/models/CausalLM-7B-DPO-alpha-q0f16/CausalLM-7B-DPO-alpha-q0f16-cuda.so")
[2024-01-03 14:04:58] INFO model_metadata.py:55: Total memory usage: 9917.13 MB (Parameters: 5462.51 MB. KVCache: 1024.00 MB. Temporary buffer: 3430.62 MB)
[2024-01-03 14:04:58] INFO model_metadata.py:64: To reduce memory usage, tweak `prefill_chunk_size`, `context_window_size` and `sliding_window_size`
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/alphaarea/.conda/envs/mlc-llm-20240103/lib/python3.11/site-packages/mlc_chat/chat_module.py", line 774, in __init__
    self._reload(self.model_lib_path, self.model_path, user_chat_config_json_str)
  File "/home/alphaarea/.conda/envs/mlc-llm-20240103/lib/python3.11/site-packages/mlc_chat/chat_module.py", line 988, in _reload
    self._reload_func(lib, model_path, app_config_json)
  File "tvm/_ffi/_cython/./packed_func.pxi", line 332, in tvm._ffi._cy3.core.PackedFuncBase.__call__
  File "tvm/_ffi/_cython/./packed_func.pxi", line 263, in tvm._ffi._cy3.core.FuncCall
  File "tvm/_ffi/_cython/./packed_func.pxi", line 252, in tvm._ffi._cy3.core.FuncCall3
  File "tvm/_ffi/_cython/./base.pxi", line 182, in tvm._ffi._cy3.core.CHECK_CALL
  File "/home/alphaarea/.conda/envs/mlc-llm-20240103/lib/python3.11/site-packages/tvm/_ffi/base.py", line 481, in raise_last_ffi_error
    raise py_err
  File "/workspace/mlc-llm/cpp/llm_chat.cc", line 1532, in mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#1}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const
  File "/workspace/mlc-llm/cpp/llm_chat.cc", line 553, in mlc::llm::LLMChat::Reload(tvm::runtime::TVMArgValue, tvm::runtime::String, tvm::runtime::String)
  File "/workspace/mlc-llm/cpp/tokenizers.cc", line 63, in mlc::llm::TokenizerFromPath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
tvm._ffi.base.TVMError: Traceback (most recent call last):
  3: mlc::llm::LLMChatModule::GetFunction(tvm::runtime::String const&, tvm::runtime::ObjectPtr<tvm::runtime::Object> const&)::{lambda(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)#1}::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const
        at /workspace/mlc-llm/cpp/llm_chat.cc:1532
  2: mlc::llm::LLMChat::Reload(tvm::runtime::TVMArgValue, tvm::runtime::String, tvm::runtime::String)
        at /workspace/mlc-llm/cpp/llm_chat.cc:553
  1: mlc::llm::TokenizerFromPath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
        at /workspace/mlc-llm/cpp/tokenizers.cc:63
  0: _ZN3tvm7runtime6deta
  File "/workspace/mlc-llm/cpp/tokenizers.cc", line 63
TVMError: Cannot find any tokenizer under: /home/alphaarea/models/CausalLM-7B-DPO-alpha-q0f16

Here is the mlc-chat-config.json generated by mlc_chat gen_config, which looks like it already recognizes the tokenizer file. But it doesn't work in practice
{
  ...
  "tokenizer_files": [
    "vocab.json",
    "merges.txt",
    "tokenizer_config.json"
  ],
  "version": "0.1.0"
}

To Reproduce

Several of CausalLM's models use the same tokenizer format, which can be reproduced by downloading the smallest model CausalLM/7B-DPO-alpha

convert, gen_config and compile

MODEL_PATH='/home/alphaarea/models/CausalLM-7B-DPO-alpha'
MLC_QUANT='q0f16'
MLC_DEV='cuda'
MLC_SHARDS=4
MODEL_ARCH='llama'
MODEL_TEMP='gpt2'
MODEL_NAME=${MODEL_PATH##*/}
MODEL_OUTPUT=$MODEL_PATH'-'$MLC_QUANT
MODEL_LIB=$MODEL_NAME'-'$MLC_QUANT'-'$MLC_DEV'.so'

mlc_chat convert_weight --quantization $MLC_QUANT --model-type $MODEL_ARCH --output $MODEL_OUTPUT $MODEL_PATH
mlc_chat gen_config --quantization $MLC_QUANT --model-type $MODEL_ARCH --conv-template $MODEL_TEMP --tensor-parallel-shards $MLC_SHARDS --output $MODEL_OUTPUT $MODEL_PATH
mlc_chat compile --device $MLC_DEV --output $MODEL_OUTPUT/$MODEL_LIB $MODEL_OUTPUT/mlc-chat-config.json

run  in python

from mlc_chat import ChatModule
cm = ChatModule(model="/yourpath/CausalLM-7B-DPO-alpha-q0f16", model_lib_path="/yourpath/CausalLM-7B-DPO-alpha-q0f16/CausalLM-7B-DPO-alpha-q0f16-cuda.so")

Expected behavior
TVMError: Cannot find any tokenizer under: /yourpath/CausalLM-7B-DPO-alpha-q0f16
Environment

Platform: CUDA
Operating system: Ubuntu 22.04.3 LTS
Device: Tesla P100
How you installed MLC-LLM: python3 -m pip install --pre -U -f https://mlc.ai/wheels mlc-chat-nightly-cu121 mlc-ai-nightly-cu121
How you installed TVM-Unity: pip
Python version: 3.11
GPU driver version: 545.23.08
CUDA/cuDNN version: 12.1

Currently we support the following tokenizers:

SentencePiece
HuggingFace
RWKV world
Byte-level BPE

See the tokenizer finding logics here for more details: https://github.com/mlc-ai/mlc-llm/blob/main/cpp/tokenizers.cc. The tokenizer-related files exist (vocab.json, merges.txt and tokenizer_config.json) don't match any of the patterns in our tokenizer detection, and that's why an error is reported.
Not super familiar with the tokenizer part - could you share which tokenizer it is? Please feel free to contribute if you are interested!

I've figured it out, the models I've been able to run without problems in the past have the tokenizer_class LlamaTokenizer or  LlamaTokenizerFast in tokenizer_config.json. But the CausalLM-72B is GPT2Tokenizer. And I had a similar problem when I trying Nous-Capybara-34B, whose tokenizer_class is YiTokenizer.
Does HuggingFace tokenizers support mean only LlamaTokenizer and LlamaTokenizerFast in currently?
In the future, will the common tokenizer supported by transformers.AutoTokenizer be more easily supported by mlc-llm?

I do think fundamentally we support full HuggingFace tokenizers because we compile its full source in rust: https://github.com/mlc-ai/tokenizers-cpp with some wrapping logic:

Rust wrapper: https://github.com/mlc-ai/tokenizers-cpp/blob/main/rust/src/lib.rs#L106-L130
Expose Rust wrapper in C++: https://github.com/mlc-ai/tokenizers-cpp/blob/main/src/huggingface_tokenizer.cc#L84

It would be awesome if you'd love to contribute adding the related wrappers to tokenizers-cpp!

Ah I just noticed that GPT2Tokenizer is actually byte-level BPE tokenizer, which is supported already. We only need to figure out what the missing file add_tokens.json is used for

I saw a blog explaining this file. Let me know if it's helpful! https://blog.rfox.eu/en/Programming/How_to_run_your_own_LLM_GPT.html

I'll see if there's a way of generating an added_tokens.json during gen_config, just like how we currently convert tokenizer.model to tokenizer.json there.
https://github.com/mlc-ai/mlc-llm/blob/main/python/mlc_chat/interface/gen_config.py#L132-L153
Meanwhile we might have to do it manually.

@CharlieFRuan I tried to add an added_tokens.json with an empty json string "{}", but got another error from our tokenizer wrapper complaining about merges.txt:
thread '<unnamed>' panicked at 'Invalid merges.txt file.', src/lib.rs:63:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5

This line in our tokenizer wrapper tries to split each line in merges.txt into two pieces, separate by " ", which fails at the last line which only contains:
å

Note that the merges.txt file is different from GPT2's official one.

OK I know how to make this work now! @alphaarea There are two things you will want to patch up:

Add an added_tokens.json which contains an empty json object: "{}"
Replace the truncated merge.txt with QWen's official one.

OK I know how to make this work now! @alphaarea There are two things you will want to patch up:

Add an added_tokens.json which contains an empty json object: "{}"
Replace the truncated merge.txt with QWen's official one.

Very thanks, I successfully run CausalLM/7B-DPO-alpha follow your way. English and Chinese both run good.
And I compare the mergers.txt from CausalLM/7B-DPO-alpha and vonjack/Qwen-LLaMAfied-HFTok-7B-Chat. The front half of them is exactly the same. But the CausalLM/7B-DPO-alpha's mergers.txt is short, and looks like having a incomplete ending. The last line only has one character å. I deleted the line and try to run it, can't believe it work well. Seems no different with when use mergers.txt from vonjack/Qwen-LLaMAfied-HFTok-7B-Chat.
Is this due to an error in the file provided by CausalLM itself?

When I use the same way on CausalLM/72B-preview-llamafied-qwen-llamafy, it didn't have the same effect. It output broken characters, looks like the tokenizer is still having error.
So I ran the test all over again, I noticed a warning appeared when starting the convert_weight
[2024-01-06 11:57:23] WARNING utils.py:25: Unused extern parameters: model.layers.0.self_attn.k_proj.bias, model.layers.0.self_attn.o_proj.bias, model.layers.0.self_attn.q_proj.bias, model.layers.0.self_attn.v_proj.bias, model.layers.1.self_attn.k_proj.bias...

(Incomplete, the warning is very long)
Is this the reason why the model outputs broken characters? Other than that I haven't encountered any other warning messages

CausalLM is not a popular model, I'm not sure if there's something wrong with the model itself.
If manager determines that these errors are caused by the CauseLM's non-standard llama model itself, please close the issues.


[fixed] Eliminate unnecessary renders when modal is closed

Fixes #[issue number].
Changes proposed:

Early return if the modal is closed and will remain closed. This prevents us from doing additional DOM check and running renderPortal again unnecessarily. This was my original intention with https://github.com/reactjs/react-modal/pull/328, but is greatly simplified with v2 code.

I wasn't exactly sure if we wanted another test as all current tests are passing and this one (https://github.com/reactjs/react-modal/blob/master/specs/Modal.spec.js#L233) covers the scenario of multiple modals rendering.
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.

Coverage remained the same at 71.429% when pulling 430aa83e2626248a11f50527c7d991ab5503c588 on ajfuller:fix/unnecessary-renders into 6c780aed87679cc534e47027480c904ccc768f48 on reactjs:master.

Coverage remained the same at 71.429% when pulling 430aa83e2626248a11f50527c7d991ab5503c588 on ajfuller:fix/unnecessary-renders into 6c780aed87679cc534e47027480c904ccc768f48 on reactjs:master.

Released v2.0.6.


Proposal: parse <style> contents using PostCSS

Description
Hi,
as suggested in sveltejs/eslint-plugin-svelte#402, I'd like to add support for rules around styles to eslint-plugin-svelte. However, since I am going to be implementing style parsing to do that, I thought maybe it would be better to provide it as part of svelte-eslint-parser?
I am not sure if there's any way of making this compatible with ESTree, but I'm not sure that is actually necessary or even a good idea. I just think that having an AST for styles may make it easier to create eslint-plugin-svelte rules that work with styles.

I think it difficult to convert a <style> AST to an ESLint compatible AST.
Supporting different CSS preprocessors (e.g. SCSS, Sass, Less, Stylus) is difficult.
I don't think we need an ESLint compatible AST to implement the rule in sveltejs/eslint-plugin-svelte#402.
It just uses CSS preprocessors to convert it to CSS and uses postcss and postcss-selector-parser to extract the class name.

Hi,
yes, I agree it would be difficult to convert the PostCSS AST into an ESLint AST - so let's not do that.
I totally could do all of this in sveltejs/eslint-plugin-svelte#402, however, I have the feeling this won't be the last rule that needs to inspect the <style> block at least in some part - ESLint is not Stylelint and it shouldn't be, but there are things in Svelte that connect the template with the script and the styles.
So what I am proposing is to essentially move the parsing part into svelte-eslint-parser - yes, the result would be a PostCSS AST kind of "hanging" from an ESLint AST node, which is not the best, but I think it is better than duplicating the parsing in every rule that needs to read/manipulate <style>. And you mentioned preprocessors - yes, they are one more reason to do it this way actually - let's solve different style "languages" once in the parser as well - the rules are going to need to support them either way...

So what I am proposing is to essentially move the parsing part into svelte-eslint-parser

Hmm. If it doesn't produce an ESLint-compatible AST, I think that producing such an AST with this parser will only confuse plugin authors.
Also, at the moment, there are very few eslint-plugins that use the AST generated by this parser, and I think eslint-plugin-svelte is the only plugin that wants to use the result of <style> parsing. So I don't think parsing <style> in plugins is currently a problem.
I think it should at least generate an ESLint-compatible AST. However, ESLint may expand AST compatibility in the future.
https://github.com/eslint/rfcs/tree/main/designs/2022-languages

Hmm. If it doesn't produce an ESLint-compatible AST, I think that producing such an AST with this parser will only confuse plugin authors.

Yeah, I get that, that's not good... Do you think naming the property something like postcssAST would help?

Also, at the moment, there are very few eslint-plugins that use the AST generated by this parser, and I think eslint-plugin-svelte is the only plugin that wants to use the result of <style> parsing. So I don't think parsing <style> in plugins is currently a problem.

I agree that it's currently not a problem, I'd like to prevent it from becoming one :D I think in general, styles are an integral part of svelte code and rules aimed at svelte will want to look at them, sooner or later (I already have another rule proposal in mind that'd need this :D). I think it would be better to have one common way of dealing with them, rather then each plugin/rule designing their own... If you disagree with this basic assumption behind my wanting to include this as part of the AST, then I think we won't agree - and of course, you have the final word as the maintainer, I just hope to persuade you with my arguments :)

Looking at the ESLint AST, is that really that complicated? Looking at the docs, do I understand it correctly that this would boil down to the range and loc properties? - the docs mention ESTree compatibility, but, well, there isn't an ESTree for styles...
Thanks for the link, seems very interesting, but also far away :D

Oh, sorry, looking at the ESTree docs, it would mean type in addition to range and loc. But I still think I can do that...

Actually, I already managed to convert the PostCSS AST to be ESLint AST as well :D

Closed by #340


Add CONFIG_CFQ_GROUP_IOSCHED check

- What I did
- How I did it
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)
blkio.weight depends on this config.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

LGTM

LGTM


Ingest from Pulsar: Update to Pulsar 3.3

Update Pulsar Ingest
Pulsar 3.3 with lots of fixes and improvements was released:
https://github.com/apache/pulsar/releases/tag/v3.3.0
active and security support of current Pulsar version used (3.2.2) ends 05 Aug 2024
see https://pulsar.apache.org/contribute/release-policy/
update should be much smoother than major version update done in
https://github.com/apache/pinot/issues/12713

dependabot already has done its job:
All checks have passed
22 successful checks

only one manual approving review required to close this.
https://github.com/apache/pinot/pull/13322


Scam Account Submission

Duplicate Submissions

[X] Yes, I checked that the account name is not currently in the list
[X] I read the wiki explaining each different categories and examples before submitting

(Required) Spam Comment Direct Link
https://www.youtube.com/watch?v=NX4BEkNKxUc&lc=UgwZGN0mIetsG04LLa14AaABAg.9obm_5tuaCQ9oboKcUz80k
(Optional) Screenshot of comments referencing the scam account

(Required) List of the scam account names
Anna.user723 / F#СК МЕ. ТАР 0N MY Р1С

I don't know how to categorize these types of scammers as they have been popping out recently using a new method. But they changed the username and spam these types of comments to grab viewers' attention to click on their profile. So let me know if this is the right one to put in!

Never mind, this seems like it's not a new method, but rather YouTube chose to display their "@" username rather than the actual/old username. The spammerpurge still recognizes the actual/old username as I ran it multiple times today on different videos.

I don't know how to categorize these types of scammers as they have been popping out recently using a new method. But they changed the username and spam these types of comments to grab viewers' attention to click on their profile. So let me know if this is the right one to put in!

Not sure about adding this one myself either. Whilst I can't argue they are prob bots and spamming, not sure we have a category for this sort of thing yet.
I'll leave this open for ThioJoe's opinion of it.

Gotcha, I'll leave this open for now.

Since we don't seem to be getting an answer from @ThioJoe
While they are a bot we don't currently have a category to add it to sorry.


Remove Empty CSS

Having this only slows down the initial request to Laravel Nova. laravel/nova-issues#3474

Thank you very much for the information and your contribution @crynobone ! 🥳


[UI] Enhance Registry page in Settings

Current Behavior
The underlying code for this UI component is… less than stellar, but really, really needs to be a commonly referenced index for Meshery admins / users.
Meshery admins need to be able to confirm which models and components are registered, what host serves those components, what their version is, disable/enable models and so forth.
Slack conversations - messages
Expected Behavior
Understand which designs use with components. What models are the most popular by use…. and on and on.
Screenshots/Logs
https://layer5io.slack.com/files/U05RS2F9GAC/F06BXHHS4CD/screencast_from_2023-12-31_15-13-54.webm
Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v
Meshery Client Version: stable-v

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

// @sudhanshutech

Let me know @Yashsharma1911 with any task here

#9595 needs to be re-open

Toggle button in settings/registry
https://github.com/meshery/meshery/assets/128807866/da48454e-68c0-45e2-9fd4-4a42fa7a81bd
Expand toggle button not working properly

Thankyou @vaibhavpnimkar let's meet tomorrow to discuss more if you are free

sure @Yashsharma1911  let me know in which time duration you are free?

Are you available today at 10 PM maybe, ping me on slack after that

okay !!!

@AjaxAueleke there are a number of issues with this UI. There might be a few items you could pick off and fix here.

@vaibhavpnimkar I have updated the issue

hey @Yashsharma1911 i am struglling with local dev env of meshery i would like to unassign this issues for right now whenever it will work i will start working

hey @Yashsharma1911 i am struglling with local dev env of meshery i would like to unassign this issues for right now whenever it will work i will start working

Ohh no worries @vaibhavpnimkar, have you posted that issues on discuss.layer5.io? till someone answer there or you figure out, can you help few PRs gettings reviewed and merged in meshery.io website?

Closing this issue as new issue is created to track registry enhancements


Error installing OpenFold

I'm following the installation instructions (installing all this in a custom conda environment on a shared computing resource)
Everything has gone well up until the OpenFold installation step.
Bug description
After I run the command:
(esm_gpu)$ pip install 'openfold @ git+https://github.com/aqlaboratory/openfold.git@4b41059694619831a7db195b7e0988fc4ff3a307'
I get the error:

Collecting openfold@ git+https://github.com/aqlaboratory/openfold.git@4b41059694619831a7db195b7e0988fc4ff3a307
  Cloning https://github.com/aqlaboratory/openfold.git (to revision 4b41059694619831a7db195b7e0988fc4ff3a307) to /tmp/pip-install-ijszxkv5/openfold_9c0f532345174527be994f0e05bd4f36
  Running command git clone --quiet https://github.com/aqlaboratory/openfold.git /tmp/pip-install-ijszxkv5/openfold_9c0f532345174527be994f0e05bd4f36
  Running command git rev-parse -q --verify 'sha^4b41059694619831a7db195b7e0988fc4ff3a307'
  Running command git fetch -q https://github.com/aqlaboratory/openfold.git 4b41059694619831a7db195b7e0988fc4ff3a307
  Running command git checkout -q 4b41059694619831a7db195b7e0988fc4ff3a307
  Resolved https://github.com/aqlaboratory/openfold.git to commit 4b41059694619831a7db195b7e0988fc4ff3a307
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [8 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-ijszxkv5/openfold_9c0f532345174527be994f0e05bd4f36/setup.py", line 56, in <module>
          _, bare_metal_major, _ = get_cuda_bare_metal_version(CUDA_HOME)
        File "/tmp/pip-install-ijszxkv5/openfold_9c0f532345174527be994f0e05bd4f36/setup.py", line 40, in get_cuda_bare_metal_version
          raw_output = subprocess.check_output([cuda_dir + "/bin/nvcc", "-V"], universal_newlines=True)
      TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

Not sure what to do here? Anybody have any suggestions of how to fix?
Thank you
EDIT: Looks like it has to do with my CUDA installation (or lack of one!)
Loading in CUDA fixed the error.

Since I also run into this exact issue myself today, I wanted to leave a solution for posterity. If you're using conda/mamba, then you need to install cudatoolkit-dev from the conda-forge channel, because the standard cudatoolkit (listed in the yml file in the repo) is runtime-only and doesn't come with nvcc which is needed here.

Hi @DaRinker I am currently trying to install OpenFold in my virtualVM and stumbled upon exactly the same error as you. I wanted to know what did you exactly mean by loading CUDA? I have already installed nvcc and the cudatoolkit-dev @lm-jkominek mentioned but it has not worked UnU].


User position on leaderboard

Describe the bug
Users not in the top 5 on the rp leaderboard will not show when the command is called. Users searched for will not show on the leaderboard either.
To Reproduce
Steps to reproduce the behavior:

Use command "b!p lb @<user not in top 5>"
Leaderboard of top 5 users will show

Expected behavior
Top 5 users and then rank about user searched for, the user and then the user ranked one below.
What platform are you using discord on?
Desktop application.

This feature was never re-added when profiles were changed to save into json files. Mostly because I forgot.


Request for working GhostText with Overpass-Turbo website (firefox/emacs)

GhostText 24.8.10, firefox 130.0.1, emacs 29.4, atomic-chrome 20230304.112.
Hello.
It would be really nice if GhostText could work with Overpass-Turbo, that is the web site for testing and using the overpass query language for openstreetmap database objects.
In the site source i see they are using "textarea" fields, but obviously it does not work.
Thank you very much!

The editor should be supported, it's CodeMirror, but it fails :(


credhub and vault security rules conflict

it looks like when running bucc with bbl that the priority on the network security rules are conflicting
* azurerm_network_security_rule.vault: 1 error(s) occurred:

* azurerm_network_security_rule.vault: Error Creating/Updating Network Security Rule "bucc-azure-vault" (NSG "bucc-azure-bosh" / Resource Group "bucc-azure-bosh"): network.SecurityRulesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="SecurityRuleConflict" Message="Security rule bucc-azure-credhub conflicts with rule bucc-azure-vault. Rules cannot have the same Priority and Direction." Details=[]

simply changing the priority fixes the issue, however it may be worth updating it or adding it in  docs

thanks for the notifying us about this issue.
and we would always be willingly to accept a PR for this issue.
so that your name will be forever known in our release notes :)

thanks @ramonskie, I created a PR https://github.com/starkandwayne/bucc/pull/184

your PR has been accepted.
thanks allot for you support


Reverse indexing order for audio and images

Description

Going through the logs for failed ingestions, the logs stop at this point:
https://github.com/WordPress/openverse-api/blob/270b086095ba125fa26e04bf27dff3ab6994e025/ingestion_server/ingestion_server/ingest.py#L338
It's natural to assume something funky has to be happening at that stage. By reversing the order to ingest audio first, we can skip the cleanup step and proceeding, thus hopefully revealing more about the nature of this flakiness.
Testing Instructions

Nothing to test here really. It's just the same steps in a different order.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

To me it seems that the only thing we can do for flakiness like this is add more logging, shake things up and wait for failures.


Hide the separate votes count

What does this PR do?
To avoid display sensitive data such as votes count to every candidate before voters vote.
Fixed #31
Type of change
Remove and modify existing codebase.
Screenshots

You solved that issue really fast. Thankyou for your contribution @rajmanna-dev . I will merge it immediately.


[Question]: Why the model doesnt detect the mathematics equations

Describe your problem
When parsing my file the mathematics equations doesn't get detected !

Equations are treated as images now.


refactor(katana-primitives): move class related types to a separate module

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

dev/katana

PR #1559

PR #1560   👈

PR #1561

PR #1562

This stack of pull requests is managed by Graphite.

Merge activity

Feb 29, 1:56 AM EST: @kariy started a stack merge that includes this pull request via Graphite.


您好，我目前也在自己开发redis cluster的proxy

您好，我目前也在自己开发redis cluster的proxy，获取redis slots信息 维护在proxy里面
关于redis协议这块，我想从官网扒出来， 感觉有点麻烦，不知道您那边协议库，可以扒出来用到我自己的proxy上面吗？

no problem

好扒出来吗？， 看依赖的东西不少~  比较麻烦~  想看看hiredis看看从那里拔出来~

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @bijeebuss, @andyzhshg, @jimmyMaci, @kskkido, @restaurantt, @Kuanlin, @andyscho


TATB - 01 :#BUG : Make login and registration page responsive till tablet view

 - for making login and registration form responsive change html and scss file of the both component.
 - remove the global font-family scss from all component and give it to the style.scss

This PR is approved and merged


Sapo updated its output format

Description
Sapo updated its output format and the current version of webSapo does not support commits newer than f81aad9.
Possible solution
Sapo commits newer than 5899cb0 can print the results in JSON format. We may use this feature to ease the integration.

Closed in 3dce2b28f9628ae396a351655f89a959654aa07f


login username on navbar

Hello,
After cloned and run this app, I found a bug: after login using username john and logout, re-login using different username jane will provide username john on navbar. It supposed to be username jane on navbar, isn't it? CMIIW

@ffachrial
The prior user is being cached. See authService.js...
return $http.get('/api/me', { cache: true });
changing to false works for me, see:
https://github.com/scotch-io/mean-machine-code/issues/13

@WebAppNut ,
Thank you for your info, so is not a bug. i will close this issue.


Warnings with parameters in yaml-blocks.

Example:
.. code-block:: yaml

    test: %my_parameter%

Results in:
WARNING: Could not parse literal_block as "yaml". highlighting skipped.

IIRC, you have to surround the value with double quote " because it contains %

You don't have to. At least in symfony 2.8 there is no error if you omit the double quotes.
And what if the parameter is an integer? Will this have implications if I use double quotes?

See Example 5.10. Invalid use of Reserved Indicators in http://yaml.org/spec/1.2/spec.html

Indeed, and starting with Symfony 3.1 this is also deprecated (see symfony/symfony#17809) and will be removed in Symfony 4.0.

Ok, thanks for the info!


Fix update-wiki.sh

Referenced from https://github.com/gfx/example-updating-wiki-with-gha/blob/main/.github/workflows/update-wiki.yml

Have been trying to debug it, but it didn't work
https://github.com/buildship-dev/nft-contracts/actions/runs/3360814177/jobs/5570510426
I went up to use different script in the end

Damn, turns out my docgen tool overwrites full folder and that caused it to overwrite the .git, essentially removing the repository


Bug with target search

I've been noticing some bugs in the current targeting method.
Bug 1
If you have 2 contacts with the same name, only 1 will be listed.
I don't know why yet.
Bug 2
False-positive groups, sometimes people appear in the group listing.
This is because the selector that takes the name of the groups also takes the status of the people and when that status contains the searched name it is also included in the groups!
How to solve Bug 1 and 2?
Maybe we could enter in every target filtered and get the target title. This could solve both bugs.

Hey, can I work on this issue?

Hey, can I work on this issue?

@Bhanu-mbvg sure, will be counted for GSSoC only after March 1st

I recommend to solve 1 bug in 1 PR.

@rpotter12 the solution will fix both.

@Bhanu-mbvg  Assigned to you, you have 4 days.

@Bhanu-mbvg deadlined extended +4d

@Bhanu-mbvg how is it going?

Now we already have a function to enter in target and get the data, but we don't verify if is the same name.


Misc Changes :

Adding enums for various steam fields
App data will always be loaded from the correct directory regardless of the shell's current working dir
Cleaning up unused Manifest fields
Refactoring DepotHandler and adding tests.  Flattening out DepotInfo class.
Flattening out CommonInfo section into AppInfo, so that there is no need for a separate class
Filtering out apps that aren't supported on the current operating system

SteamPrefill-1.1.1-osx-x64.zip
SteamPrefill-1.1.1-win-x64.zip
SteamPrefill-1.1.1-linux-x64.zip

SteamPrefill-1.1.1-linux-x64.zip
SteamPrefill-1.1.1-win-x64.zip

SteamPrefill-1.1.1-osx-x64.zip
SteamPrefill-1.1.1-win-x64.zip
SteamPrefill-1.1.1-linux-x64.zip

SteamPrefill-1.1.1-osx-x64.zip
SteamPrefill-1.1.1-win-x64.zip
SteamPrefill-1.1.1-linux-x64.zip


doc: gsg: add libpython3.8-dev

Not all distributions install python3.8 libraries as a part of the
python3 package. Specifying the python3.8 library solves this problem.
addresses #34397

@nashif we should make sure this is in the new docker image so GDB works for the user w/python.


I cannot reach the ori accuracy by training the ResNeXt-50 on the ImageNet.

I use the 'PyTorch ImageNet Training' example and the 'models' of TorchVision 0.4.2 to train ResNeXt-50 twice but got 23.52% and 23.57% (Top-1) on ImageNet Val set, which do not reach the ori Err. (22.2%). Besides, I find that the hyper parameters setting of 'PyTorch ImageNet Training' example is same to the original paper. Can you give me some advices for training to reach the ori Err. ?
The val acc alongside training is shown below:

logs

Top-1
16.894
32.488
36.116
40.272
45.394
46.328
50.126
50.336
52.242
54.414
53.096
54.438
55.662
54.972
55.902
57.204
54.932
57.068
55.586
56.9
58.018
56.67
58.564
57.272
58.224
57.736
57.816
58.292
57.618
56.664
70.7
71.502
72.04
72.452
72.69
72.754
73.03
72.996
72.504
72.812
72.318
72.294
72.584
72.318
72.42
72.528
72.238
72.14
71.76
71.91
72.282
72.508
72.156
71.424
72.3
72.48
72.42
72.61
72.61
72.178
75.62
75.86
76.16
76.184
76.26
76.252
76.376
76.3
76.404
76.48
76.326
76.368
76.304
76.386
76.462
76.36
76.452
76.396
76.258
76.308
76.334
76.228
76.252
76.304
76.15
76.298
76.362
76.15
76.17
76.058

EDIT: (vfdev-5) I updated the message and put the training logs into summary/details block.

@PoonKinWang it is difficult to say for me where is the issue. Please, check reference script here for the classification task:
https://github.com/pytorch/vision/tree/master/references/classification
Maybe, using them you can obtain desired accuracy.

@PoonKinWang it is difficult to say for me where is the issue. Please, check reference script here for the classification task:
https://github.com/pytorch/vision/tree/master/references/classification
Maybe, using them you can obtain desired accuracy.

Thanks for your reply.
The setting of 'PyTorch ImageNet Training' example is same to what you mentioned, and both of them were the official code of TorchVision. Thus, I think the code you mentioned cannot work as well. Could you offer any training logs of ResNeXt-50?

Could you offer any training logs of ResNeXt-50?

Unfortunately, I do not have these logs, maybe, @fmassa still has them.

Could you offer any training logs of ResNeXt-50?

Unfortunately, I do not have these logs, maybe, @fmassa still has them.
@PoonKinWang By the way, do you train the model on the same infrastructure setup 8x V100 GPUs ?
and what are the software versions you use ?
pip list | grep torch

I trained on two 2080ti.

@PoonKinWang if your total batch size is not 256 (=8 * 32) as for 8 GPUs, then you have to rescale the learning rate like
total_batch_size = ...
lr = 0.1 * (total_batch_size / 256.0)

(as ref: https://arxiv.org/abs/1706.02677)

I trained on two 2080ti.

@PoonKinWang if your total batch size is not 256 (=8 * 32) as for 8 GPUs, then most probably you have to rescale the learning rate like
total_batch_size = ...
lr = 0.1 * (total_batch_size / 256.0)

(as ref: https://arxiv.org/abs/1706.02677)

On that two training, I used total batch size of 256 on two GPUs.

@PoonKinWang do you mean DistributedDataParallel (not DataParalle) right ? (https://pytorch.org/tutorials/intermediate/ddp_tutorial.html#comparison-between-dataparallel-and-distributeddataparallel)

I mean DataParalle.

@PoonKinWang do you mean DistributedDataParallel (not DataParallel) right ? (https://pytorch.org/tutorials/intermediate/ddp_tutorial.html#comparison-between-dataparallel-and-distributeddataparallel)

I use the train.py as you mentioned to train again but still fail to reach the Acc. as the ori paper provide (22.2%). I get 22.52%, 22.67% and 22.81% as three independent training results.

@PoonKinWang it is difficult to say for me where is the issue. Please, check reference script here for the classification task:
https://github.com/pytorch/vision/tree/master/references/classification
Maybe, using them you can obtain desired accuracy.

I use the train.py as you mentioned to train again but still fail to reach the Acc. as the ori paper provide (22.2%). I get 22.52%, 22.67% and 22.81% as three independent training results.

@vfdev-5 I use the train.py as you mentioned to train again but still fail to reach the Acc. as the ori paper provide (22.2%). I get 22.52%, 22.67% and 22.81% as three independent training results.

Hi,
Here is the training log for ResNeXt50 32x4d for the model that we uploaded for torchvision https://gist.github.com/fmassa/aa7f0b0890317cddceeec6fa29fd221a
It reaches best accuracies of
Acc@1 77.618 Acc@5 93.698

in epoch 97.
We used the training scripts present in references, without sync-batchnorm, on 8 GPUs each with batch size of 32, trained for 100 epochs (as described in https://github.com/pytorch/vision/tree/master/references/classification#resnext-50-32x4d).
This means that in your setup the batch size per GPU should be 128, which will have different statistics for batch norm and could explain the difference in results.
I believe I've answered your question and as such I'm closing this issue, but let us know if you have further questions

I use Distributed-BatchNorm-PyTorch to simulate multi-GPUs and achieve the accuracy provided by original paper.
Thanks for your reply.


Make it easier to create FutureStreams from Collections, Streams

make sure suitable
react methods in SimpleReact, LazyReact and EagerReact
of methods in LazyFutureStream, EagerFutureStream, SimpleReactStream

react should indicate an async action (i.e from the async evaluation of a Supplier)
of should indicate a synchronous action (i.e. copied from an iterator / iterable / collection or Stream).

completed on HEAD


Add the help message, if manifest file is not accesible to wskdeploy and undeploy

Thanks @houshengbo - it would be good practice to add go unit tests for these improvements as they’re developed.

Created separate low priority issue for the same, #947


"ModuleNotFoundError: No module named 'mentat.terminal'" when installing from github

Running metat after python -m pip install git+https://github.com/AbanteAI/mentat.git leads to
Traceback (most recent call last):
  File "/opt/homebrew/bin/mentat", line 5, in <module>
    from mentat.terminal.client import run_cli
ModuleNotFoundError: No module named 'mentat.terminal'

The pip package is working fine (but I can't make it work with the 128k context window, which, I suspect, is not in that version yet)
System Version: macOS 14.1 (23B74), Python 3.11.5

Thanks for reporting. I see the same issue. I'll look into it. In the mean time you can also install with:
git clone https://github.com/AbanteAI/mentat.git
cd mentat

# install with pip in editable mode:
pip install -e .

Cheers, that got me on the right way!


how understand which id use...

For now i'm using 0 for ID working perfectly as root.
How i can understand exactly which id corrisponding to my personalized admin account?
thanks from italy!

If you have the user name, you can use the id command to determine the user and group IDs.  See https://github.com/jlesage/docker-mkvtoolnix#usergroup-ids

Closing this issue.  Please reopen if needed.


Carthage

Hi,
It's will be great to add Carthage support
Take a look at these articles:

Ruthlessly Simple Dependency Management with Carthage
Carthage Tutorial: Getting Started
Making Carthage-compatible Frameworks with Swift
[Creating Cross-Platform Swift Frameworks for iOS, watchOS, and tvOS via Carthage and CocoaPods] (http://basememara.com/creating-cross-platform-swift-frameworks-ios-watchos-tvos-via-carthage-cocoapods/)

@TofPlay, sure thing. feathers-ios isn't close to being done yet but once it is, I'll be sure to add Carthage support.


✨ Support Svelte Inspector

Describe the problem
Would be cool for SvelteLab to support the Svelte Inspector
Describe the solution you would like
Clicking an element in the preview with Svelte Inspector opens the corresponding
file in the Editor.
Describe alternatives you have considered
No response
Additional context
idk how hard that is to pull off but would be cool 😎

Oh man that would be awesome but i think it should be pratically impossible (if i'm not mistaken it uses some vite api to specifically launch vscode)...i'll check tho

we could let people opt into a sveltelab vite plugin that does integrations?
we could make it fail gracefully when used outside sveltelab 🤔

That's what I was thinking of, that or intercepting the links of the actual inspector.
Only problem is that they would need to add it by hand because dynamically modify the svelteconfig/vite plugin is something that I'm yet to understand how to do


fix: enable text-categorical vars comparsion

Fix the comparison validation that raised did not allow comparison between text and categorical vars.

Codecov Report
Patch coverage: 78.99% and no project coverage change.

Comparison is base (d8c3104) 89.70% compared to head (324036d) 89.70%.
Report is 9 commits behind head on develop.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1417   +/-   ##
========================================
  Coverage    89.70%   89.70%
========================================
  Files          194      194
  Lines         6254     6254
========================================
  Hits          5610     5610
  Misses         644      644

Flag
Coverage Δ

py3.8-ubuntu-22.04-pandas
89.70% <78.99%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

setup.py
0.00% <ø> (ø)

src/ydata_profiling/model/pandas/__init__.py
100.00% <ø> (ø)

src/ydata_profiling/report/structure/report.py
92.10% <0.00%> (ø)

tests/unit/test_describe.py
94.54% <ø> (ø)

tests/unit/test_output.py
100.00% <ø> (ø)

src/ydata_profiling/profile_report.py
81.42% <50.00%> (ø)

src/ydata_profiling/visualisation/plot.py
78.92% <59.37%> (ø)

..._profiling/model/pandas/timeseries_index_pandas.py
76.19% <76.19%> (ø)

src/ydata_profiling/model/timeseries_index.py
83.33% <83.33%> (ø)

src/ydata_profiling/report/structure/overview.py
93.33% <91.30%> (ø)

... and 5 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Import a js module for its side effects only

Is there a way to import / define / annotate a node module for its side effects only?
For example: Vaadin Elements
(source: https://vaadin.com/tutorials/using-web-components)

Install the components

import '@vaadin/vaadin-button';

In JS this will load the module and some side effects will be applied to the HTML page (custom styles, dom-module nodes, ...).
In Kotlin Js, importing a module which is not explicitly used has no effect.
@JsModule("@vaadin/vaadin-button")
@JsNonModule
external val vbutton: HTMLElement? = definedExternally

fun main() {
    //console.log(vbutton?.toString())
    val mainDiv = document.getElementById("main")
    mainDiv?.append {
        vaadin_button {
            attributes["id"] = "hello"
            +"Hello"
        }
    }
}

Everything works fine when I uncomment the console.log line but I was wondering if there was a better way.
An example project can be found here:
https://github.com/dvekeman/vaadin-elements-kotlin/tree/sideeffects
(sideeffects branch)

I think for that to happen, you should use require instead of just defining an external module
    require("@vaadin/vaadin-button")

Thanks for the feedback. That seems to work!
external fun require(module:String):dynamic

fun main() {
    require("@vaadin/vaadin-button")
    require("@vaadin/vaadin-text-field")
...
}


isort thrash with ruff on imports

isort version 5.12.0, ruff version 0.0.261
Relevant fragments from pyproject.toml:
[tool.isort]
profile = "black"
known_first_party = ["redacted", "redacted",]
lines_after_imports = 2

[tool.ruff]
select = ["I", "ICN", "YTT"]
target-version = "py310"

[tool.ruff.isort]
known-first-party = ["redacted", "redacted",]
lines-after-imports = 2

isort and ruff seem to aggregate these imports differently. This may be an isort issue (as I think ruff's way is correct), but raising it here as it's a behavior difference:
After running isort:
from tenacity import before_sleep_log
from tenacity import retry as retry_decorator
from tenacity import stop_after_attempt, wait_fixed

After running ruff --fix:
from tenacity import before_sleep_log, stop_after_attempt, wait_fixed
from tenacity import retry as retry_decorator

tenacity is https://github.com/jd/tenacity

Ah yeah, this is one of the two "known deviations" that we have with isort -- there's some discussion on it here: https://github.com/charliermarsh/ruff/issues/1381. (And I'll just link to the "known deviations" in the FAQ for completeness.) I also prefer our behavior, and there aren't currently plans to change it, though I know it's annoying that it causes larger-than-expected diffs during migration.

Ah, got it, thanks. I was hoping to have both isort and ruff running for a bit just to ensure that everything was good between them, but I guess I'll just switch over.
I actually saw the FAQ entry before filing this, but it wasn't obvious to me (w/o clicking through to the actual issues) that "a few known, minor differences in how Ruff and isort break ties between similar imports, and in how Ruff and isort treat inline comments in some cases" was talking about this issue - I didn't think these were similar imports that would be tied and it's definitely not inline comments.

Yeah that's a good point. I don't think I really internalized the scope of this deviation when I wrote that. Will fix.


Fadeout fixes

Fixes #321
Fixes #202

Ohh yeah this looks so much better. Turns out designers know what they're doing.


Systematize generating names for category tracker

This implements category name calculation by tracking 'labels', which represent fragments of category names, and calculating the resulting combination of them. This fixes many discrepancies between the category tracker and MossRanking.
In its current state, we log a warning when the text differs between the new and old methods. This is a bit noisy when a run is both "No Gold" and "Pacifist" because the order has been fixed.
Known differences that aren’t corrections:

For Cosmic Ocean%, we now display No Jetpack and hide No TP
When dying in CO, we now say Cosmic Ocean% instead of Death%

Other notes:

Mossranking says  "No Gold Sunken City%" and "No Teleporter No Gold Sunken City". For the latter, RunLabel includes a '%'
RunLabel supports True Crown Cosmic Ocean%, but RunState treats TC as a Score run
RunLabel supports Millionaire, but RunState doesn’t 👀
In general, we produce more detailed labels than MossRanking tracks. However, there are a some places we hide detail:

No TP, Abzu, and Duat are hidden in CO
For non-CO, we hide No Jetpack
We only display Jungle/Temple for Low% categories (incl. chain)

I'm not wild about 'Label' as the enum name, but I haven't thought of anything that's more accurate and still short

Fixed "Score" vs "Score No CO".
After rebase, tests pass.

At this point, I've done a bunch of testing with Overlunky and haven't found any unresolved bugs. I intend to exercise this more and tear out the old text generation.
Feedback and suggestions are still very welcome.


Export font objects (text) the same way as curves

Treat FONT objects (called Text in the UI) the same way as curves so they can be exported directly (they contain a TextCurve which is a subclass of Curve)
The current workaround is to Convert to Curve from Mesh/Text before exporting.

This looks OK to me, @McNopper could this be included in glTF-Blender-IO?

Looks good, thanks!


Fix Output panel colors on theme changing

Changes:

Fix incorrect icon colors:

Add a log rebuilding to also fix a text color:

Thanks!


[mp] remove 'throbbing' as potential adjective for new blocks

This one is self explanatory.

🤦♂


problem occur when your php version is too old

you need to change [] to array()
memcached_library protected $errors = array();
config file  [] => array()
life is short ,why I have to use php5.1.6 .Orz

php 5.1.6 end of life was 9 year ago. sorry but if you're stuck with that then use an older version of this.


Disable TCP Offloading on macOS

Pull Request Description
As proposed here, I'm disabling offloading on macOS. It's already disabled on Linux and Windows runners.
Important Notes
This should hopefully increase the stability of localhost-based tests.
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
[x] All documentation and configuration conforms to the markdown and YAML style guides.
[x] All code has been tested where possible.

It's doing actual external networking. The TCP offloading seems to be impacting communication over localhost, rather than external networking.

It's doing actual external networking. The TCP offloading seems to be impacting communication over localhost, rather than external networking.

Hm, in that case it may indeed be unnecessary. I thought it also affected the external connections (as we sometimes seen curl fail, but maybe that was purely to real networking load). I do not remember seeing this job fail for networking reasons (although it is not run too often either), so maybe it is unnecessary indeed.
Let's skip it for now and if there are any networking errors in the release workflow, we can revisit that.

Sounds good! It's a tool in our arsenal if we need it. ^^


(Windows) Enable ANSI colors if the user is using ConEmu (and has the ANSI colors enabled)

refs #1193
Reposting from a named branch according to CONTRIBUTING.MD

Hi @petetnt, can you squash your commits please ?

Sure @mickaelandrieu , it's done now!

thank you for this contribution :)


Name test

solves #149

Could you create a separate PR for this, instead of continuing off from a branch, as I don't see a need to continue from your branch https://github.com/saiutkarsh33/tp/tree/assertion-error?
Doing so, you will not need to rebase your changes once #256 is merged.

Closed because of #258


Issues with GitHub Actions deployment

Hi Everyone!
Not sure if this is the right place to ask as I'm a newbie. Basically I cloned the template, just did minor text changes on the main page and it runs perfectly locally but does not deploy properly with the provided gh action.
Followed the steps here: https://gohugo.io/hosting-and-deployment/hosting-on-github/
The action runs successfully but the deployed page does not look as it should.
Link to the project: https://github.com/high-five-app/website/actions/runs/6991485038
Do you have any suggestions as to what I could be doing wrong?
Thank you very much!

Hey @valentinneher, Thanks for choosing Hugoplate. You just need to set this https://high-five-app.github.io/website/ as your baseURL in the hugo.toml file. and you are good to go. have a nice day.

Thank you so much! @tfsomrat
I think it might be helpful for other users to elaborate a bit more on that or provide a little example in the README.md.
Have a great day! 🔥


Replace with KWOK implementation

[x] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description
After testing, we've confirmed that SimKube works fine with KWOK and so we're ripping out all of the virtual-kubelet-based implementations.  This only left skctl as the last remaining bit of Go code in the repo, and so for build tooling simplicity, this has been replaced with a Rust implementation.
TODO: docs need updating
Testing done

manual testing
make test

Additional info
Resolves #70, #71

Updating Kubernetes DAG...
Please wait until the job has finished.


Fix the cIGZSystemService definitions

OnTick and OnIdle take a single integer parameter, which appears to be
some kind of incrementing counter.
The cIGZSystemService  header was also missing the GetServiceTickPriority method, which
was causing it to crash when calling AddToTick.
Fixed the OnTick and OnIdle method signatures in various headers.

@0xC0000054 thanks for the PRs! I think the parameter is supposed to be the total number of tick and idle frames that have elapsed since the game started. At least that's what I've been able to deduce from reverse-engineering in https://github.com/nsgomez/scion
Declaration I used there: https://github.com/nsgomez/scion/blob/main/src/framework/include/cIGZSystemService.h
Usage: https://github.com/nsgomez/scion/blob/f0608f01e058b2e97e7d94225f02047d84573a8d/src/framework/src/cGZFramework.cpp#L461

That makes sense. How is scion supposed to be used for reverse engineering?
I see that it uses a version of STLPORT, are scion's collection types (std::list, etc.) binary compatible with SC4?
As I mentioned in #8, the EASTL vector type is binary compatible with SC4 but its list type is not.

Scion is a bottom-up reverse engineering of the GZ/RZ game framework, including source code. gzcom-dll is more top-down, starting with SimCity 4's game-specific bits and working down, and mostly focuses on declaring interfaces instead of reversing the source wholesale. You could smush them together by replacing gzcom-dll's GZCOM declarations with the ones from Scion.
And yeah, SimCity 4 (on Windows) uses STLPORT instead of EASTL or the compiler-provided STL. If you inspect SimCity 4.exe in a PE viewer, there's a program section referencing it:

So you should have better luck using that instead.


Can't build

Hello,
I'd like to test this out and see how it can push some of my drives while copying some data but it wont build. It looksl ike  utils::CSearcher::CSearcher is missing. Can you help?
Thanks!

Yeap, thanks for reporting this. Now everything should be fine.


Entity Damage Animation is not correctly implemented

Currently, the EntityAnimationPacket is sent out with the TAKE_DAMAGE Animation. This Animation does not exist anymore in 1.20.
The ID of TAKE_DAMAGE (1) is now simply unused (don't remove the please, since it will break the animations after, since all IDs are still the same and minestom is using enum ordinals here. Minecraft internally just uses int constants)
Instead, the HitAnimationPacket should be sent out. I would create a PR for this, but you are required to supply the yaw from which the damage came from, and I would rather let a more experienced minestom developer properly implement this.

I ran into this when doing the 1.20 update but wasn't super happy with the solution I came up with so decided to leave it for people to send from their own combat handling for the moment (though didn't remove the old stuff).
Perhaps I'll take another crack at it.


Update Docker Registry for 1.9

Made some preliminary updates for the 1.9 update of this package, but I don't yet have an environment with a bootstrap node, and have run into issues uploading to the registry so far using the insecure mode. WIP.

Closing in favor of #186


Deleting gardes autodimsiss doesn't update gradelist

deleting subjects/gardes crashes app qw

fixed in 3.3.5


public instance is down

the public instance is down with project is not ready, try to restart it error

Shuttle is problematic - there is a lot of downtime. I cannot restart the project or login via API key.
I removed the public instance statement from README. You can check out my blog post if you want to create your own instance.

it would be nice if we was able test it before installation (public instance)
or at least some screenshots/video in readme


variant_lantern compat

Includes Gold (Normal, Soul & Redstone) and Iron (Redstone variant) base lanterns.
Includes all variants from 'Tech Reborn' pack
Havent tested with every lantern yet.
also build seems to be failing atm due to a 403 error on the modcompile of secret-rooms-fabric when trying to build, not related to this PR.
I made another branch and removed the mixin, and secret-rooms stuff to test the build, all seems to be good.
please dont accept this PR yet, as it is WIP and my mod is not released.

tested with all lanterns in my mod, no issues

Sorry about this, but I have changed the placement system used. I forgot about the update I've had on the back burner. With these changes, the on_wall blockstate has been removed. This change also means that hanging now has to be false. Luckily, you should be able to do what I did and just find and replace within each file.
After these changes, I'm happy to merge.

so
"hanging=true,on_wall=true,facing=north": {
to
"hanging=false,facing=north": {
?

That is correct.

added.

I'm going to release this update tomorrow.


update shipment report and pdf generator

Coverage increased (+0.2%) to 68.228% when pulling d73947eb497fa2707cbb25578bd3494baa3ba634 on leslieaula:dev into f45fb47de4cc3ec499f2f6db845873528a5540f9 on danliris:dev.


Version 2 wishlist

Want some feature in v2? Comment here.

[x] Make "reject on drop" true by default
[x] Add support for an options object, but keep the simple argument passing style for the 4 basic arguments (minTime, maxConcurrent, highWater, strategy)
[x] Rename all the changeX methods to setX
[x] Make the Promise library an option instead of a Prototype setting. Consider maybe making it an option when requiring the library, i.e. var Bottleneck = require('bottleneck')(myPromiseLibrary);.
[x] Modern JavaScript (ES2015) rewrite, compiled to ES5 using Babel.
[x] Support a timeout (with an error if the time is exceeded) for any job, both callbacks and promises. I don't want this in version 1 because it breaks the backwards compatibility.

More to come..

I like these but am unsure on the last one. It seems a bit out of the ordinary compared to other libraries, and would mean if you wanted the default promise library you would still have to
var Bottleneck = require("bottleneck")();

which is a bit strange.
I think it makes sense to have it as an option in the new options object like anything else.

@omencat That's a great idea and I'll try to add it to the new release for you, no need to wait until version 2 for that.

Suggestion: port from CoffeeScript to ES2015 (perhaps with async?)

Yes, possibly with Babel for backwards compatibility. Almost all the good features of CoffeeScript have been ported to ES2015.

This Issue will be reopened when work on Version 2 begins.

@tjenkinson @timdp
I think you guys will appreciate the new v2, currently in Beta https://github.com/SGrondin/bottleneck/tree/version-2
Lemme know what you think!


Can't use zerotier nic in VM template

Issue migrated from https://api.github.com/repos/zero-os/0-templates/issues/116, opened by @zaibon
Traceback (most recent call last):
  File "/opt/code/github/zero-os/0-robot/zerorobot/task/task.py", line 79, in execute
    self._result = self._func()
  File "/opt/code/github/zero-os/0-templates/templates/vm/vm.py", line 39, in _monitor
    if self._vm_sal.is_running():
  File "/opt/code/github/zero-os/0-templates/templates/vm/vm.py", line 26, in _vm_sal
    return self._node_sal.primitives.from_dict('vm', data)
  File "/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/primitives.py", line 151, in from_dict
    vm.from_dict(data)
  File "/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/VM.py", line 447, in from_dict
    nicobj = self.nics.add(nic['name'], nic['type'], nic.get('id'), nic.get('hwaddr'))
  File "/opt/code/github/jumpscale/lib9/JumpScale9Lib/clients/zero_os/sal/VM.py", line 237, in add
    raise RuntimeError('Zerotier can not be added when the VM is running')
RuntimeError: Zerotier can not be added when the VM is running

commented by @grimpy
Zerotier can only be added when a VM is stopped because we configure it insde the os with the configs option of zero-os which is only applied (and can only working) before the vm is started itself.

verified :
js branch : development
zos-node : development


CI for no differences in .ok file

Description
As a simple sanity check, there could be a CI test that any modified .ok files do not have differences in them. This will ensure that they don't get missed on review.
Suggested Solution
A simple script which greps for "Differences found at line" should suffice.
Additional Context
No response

@vvbandeira could this be a GH action?

@vvbandeira could this be a GH action?

I think Jenkins should be fine. It would be a simple grep "Differences found at line" **/*.ok or for f in **/*.ok; do ... plus some minor parsing/substitutions just to print the names of the tests in a nice format.


fix: add qaHook propType to components

This is the blanketing attempt for all the action based elements inside of backpack-ui. This will allow for easier locators in our test automation strategy.
Read more here:
https://kentcdodds.com/blog/making-your-ui-tests-resilient-to-change
The only elements that we are interested in are mainly select, options, buttons, a, and textarea. This allows the FE developers to change/update classname/ids without concern of breaking our E2E tests.
---- UPDATE ----
After discussing with @vacas5 about this locator strategy another attempt has been made to make all custom data hooks conditional for developers to either enable or disable at will.
This will break automation that has existed for now but like muscle will make us stronger later. Furthermore, we did not want to pigeon hole users of this library into having these without first enabling them themselves. Tagging in @bwanamaker for him to be made aware of this pivot.
If additional unit testing is needed to validate all components I am willing to bolster the code coverage as well. Some quality of life changes were made to components as I was validating the qaHook enabled components. Nothing too considerable I'd say.

ps, I missed the part where some of these have already been added to other components.

I think I found a few things that need tidying up. Thank you for doing this, I know it was a lot of work to refactor all of these, but I think it better serves this package.
Also, we'll need a conventional commit message on this when we merge it in. Looks like you cleaned up a couple of bugs here also so we should be sure to document (if you already did that's great).
I think you should maybe consider this to be a "fix". It's a more open source friendly implementation of an easier commit. It does technically introduce breaking changes, though.

@vacas5 I may need a brief tutorial on how to make sure the messages are proper regarding the changes I made and where exactly to put them. At your leisure. Thanks for your help with this!

I think we can squash and merge this with no problems


i added a brazilian portuguese because i loved this plugin idea <3

Thank you very much, the changes look good (from what google translate says lol). Have a good day. Merged.


can not use this mod when using optifine

latest.log
mod list:

Just ran into this also, using CreateGoggles v0.5.5.c and Optifine 1.19.2 I2 (the same as @Beafty). See attached logs:
creategoggles_optifine_crash.log

Just ran into this also, using CreateGoggles v0.5.5.c and Optifine 1.19.2 I2 (same as @Beafty) on Forge 43.2.3.  Use rubidium and oculus

https://media.discordapp.net/attachments/560583846509281280/1035541105997000704/57BAE7EC-E093-4CF2-A83F-AA50237A7D91.gif


How can I search for locations around a specific coordinates?

Is there a way to search for a specific locations like Gas Stations in the area I specify?

Yes there is a way, we called a place api provided by Google.
This is out of scope question though.


onMinimumReached and onMaximumReached events are always fired

<UIStepper               displayValue={true}               initialValue={item.qty}               minimumValue={1}               maximumValue={10}               value={item.qty}               onMinimumReached={console.warn(' min reached')}               onMaximumReached={console.warn(' max reached')}               onIncrement={() => this.increment(item.id)}               onDecrement={() => this.decrement(item.id)}             />
The onMinimumReached and onMaximumReached events are always triggered upon render even when the value is 3.
By the way, my UIStepper is inside a FlatList (loop).
Am I lacking a setting?

Thanks for reporting the issue @misheki
Have you got a repository or a reproducible demo that I could use to fix the issue?

Hi @hannigand, sorry for the late response.
I don't have a demo on this yet because I realized that it does not bother my requirements as of now.  However, I am facing a different issue with the VALUE setting.  Even though I hardcoded it with the number 3, it still increments and decrements when I click on the plus and minus buttons.  Should I close this and open a new issue?
Thanks!

Hi @misheki - that's the expected behaviour.
When you set the value, it's only read-only and you can modify it by pressing the increment/decrement buttons.

Hey @misheki , instead of this ;
onMinimumReached={console.warn(' min reached')}
Please try this :
onMinimumReached={() => console.warn(' min reached')}
Passing a function instead of an instruction will prevent the behavior you're describing. Cf. https://reactjs.org/docs/faq-functions.html#why-is-my-function-being-called-every-time-the-component-renders
Cheers


Extension missing - Live Share

Issue Type: Bug
I would like to install the Live Share extension for collaborative work with my colleagues. But the extension does not appear in the extensions overview.
Executing the "ext install MS-vsliveshare.vsliveshare" command as suggested on the homepage does not work. Most probably because the extension isn't listed.
Could there be some kind of filter active? Im on ArchLinux with i3 as window manager.
VS Code version: Code - OSS 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-16T15:21:33.370Z)
OS version: Linux x64 5.12.6-arch1-1

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz (8 x 2100)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 1

Memory (System)
15.45GB (7.29GB free)

Process Argv
--no-sandbox --unity-launch --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
i3

XDG_CURRENT_DESKTOP
i3

XDG_SESSION_DESKTOP
i3

XDG_SESSION_TYPE
x11

Extensions (14)

Extension
Author (truncated)
Version

path-intellisense
chr
2.3.0

vscode-eslint
dba
2.1.8

gitlens
eam
11.4.1

prettier-vscode
esb
6.4.0

vscode-go-test-adapter
eth
0.1.5

go
gol
0.25.0

terraform
has
2.10.2

vscode-test-explorer
hbe
2.20.1

file-downloader
min
1.0.11

mindaro
min
1.0.120200919

vscode-aks-tools
ms-
0.0.7

vscode-kubernetes-tools
ms-
1.3.2

azure-account
ms-
0.8.9

vscode-yaml
red
0.19.2

Duplicate of https://github.com/microsoft/vscode/issues/107997#issuecomment-703245178


Make forms_dict more consistent, better prefix

Coverage decreased (-0.31%) to 17.85% when pulling e54689cb2e29f309120dbebf9b067dd88c3565e6 on enh/consistent-forms-dict-better-prefix into f15175762fe66afb85f8ccf10c7090fcafa6d3f7 on master.


Error during build

I get the following error when I try and build the solution.
Error	MSB4030	"25/10/2017 10:20:57" is an invalid value for the "TimeStamp" parameter of the "GetBuildIndexFromTime" task. The "TimeStamp" parameter is of type "System.DateTime".	MultiPlatformBuild	C:\VS2017\Projects\Llvm.NET-master\BuildOutput\packages\CSemVer.Build.Tasks.1.0.0-alpha.2--ci-REL.194F4984\build\CSemVer.Build.Tasks.targets	117
Any thoughts ?
Andy

Hmm, looks like a bug in the CSemVer build task not accounting for localization of the date/time. If you temporarily set your date/time region settings to US does it work? I have an update planned on that build task I've been planning so I can hit this one as well. I'll need to look into how I can force that on the AppVeyor builds. We already switch the language to catch any assumptions on framework specific language strings.

I actually just replaced the macro in the targets file directly thus:
TimeStamp="10/25/2017 10:20:30"
This got me past the error I noted though I do get a bunch of compile warnings and errors that I am going to have to look through.
Andy

FYI you can also get the CI builds from the AppVeyor Nuget feed at: https://ci.appveyor.com/nuget/Ubiquity.Llvm.NET

This should be fixed now, the build tasks were updated to force a well known locale independent representation of the time stamp.


Change to Visual Studio Installer

The "Snapshot Debugger" is now under "Azure development" instead of "ASP.NET" and web development"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5f13f80-a3b0-9602-db14-48130d47ef7c
Version Independent ID: 96ee1b24-bc43-5e46-f645-f4ccfe9f1ba1
Content: Debug live ASP.NET Azure apps - Visual Studio
Content Source: docs/debugger/debug-live-azure-applications.md
Product: visual-studio-dev15
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@andysterland Andy, might this refer to the App Insights Snapshot Debugger? Or is our Snapshot Debugger under the Azure workload now?

Checking on this.

Updating doc


How add [hash] for .js .css and other files in build?

I want add [name][hash].[ext] for .js .css and other files in build
For example in webpack i have file-loader and i have
options: {
              name: '[name]__[hash]__.[ext]',
              publicPath: '...',
              outputPath: '...',
            },

How do same in next.config.js? Or nextjs do hashing files when build?

Tech
Version

next
5.1.0

node
10.0.0

it working but look like as shi~
const nextConfiguration = {
  webpack: (config, { dev, buildId }) => {
    if (!dev) {
      const nextExtractTextPlugin = config.plugins.find(
        element => element.__proto__.constructor.name === 'ExtractTextPlugin'
      );
      nextExtractTextPlugin.filename = `static/style.${buildId}.css`;
      config.plugins.push(nextDefinePlugin(buildId), nextCleanWebpackPlugin);
      return config;
    }
    config.plugins.push(nextDefinePlugin);
    return config;
  }
};

Doesn't seem like a Next.js issue. Maybe you're using one of the next-plugins, in that case file it there. Also, when creating issues, please follow the issue template.

@timneutkens what about extractCSSPlugin in context webpack: (config, context) => {
how i can manipulate it

@timneutkens nextjs do hashing files when build?

@timneutkens do u answer me?

@Popugune The issue tracker is for filing bugs in Next.js, not to ask for support. You can try asking your question on Spectrum.
It looks like you're on the right track with your nextConfiguration above.


Adjusted Guid in build.yaml

While initially taking the pushbullet Plugin as a Template, i forgot to change the GUID in the build.yaml which lead to confusion in the Plugin catalog. This should fix this.

:rocket:


example hosts.ini for project

Added a global group and comments. The global group for our purposes allows us to use the /projects/inventory/group_vars/ansible_scaleio variables

Review 👍

+1


Propagate miette error info through FFI

Description of changes
FFI returns rich JSON structures for errors, rather than a simple string.
This diverges from the plan proposed in #757 in two ways:

This PR actually specifies the miette JSON structure produced, rather than just using serde_json::Value in our interface types.  This makes it easier to integrate with the FFI (and write tests), and makes us responsible for updates if the miette JSON structure ever changes, but as an upside the code will complain louder and earlier if the miette JSON structure does change.
ValidationWarning and ValidationError have the same structure, so this PR proposes just having a single struct ValidationError.  Errors and warnings can still be distinguished from each other in two ways: (1) via miette's severity field; and (2) because ValidationAnswer::Success keeps them in separate lists validation_errors and validation_warnings.

Somewhat orthogonally, this PR also includes a pass through all of the cedar repo removing occurrences to the outdated terminology "instantiation" in favor of "linking".  This can be separated into a different PR if that's preferable.
Issue #, if available
Part of #757
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR (choose one, and delete the other options):

[x] Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

[x] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

for review:

the REVIEW comment in cedar-wasm/src/validator.rs
The code currently has two possible panics in cedar-policy/src/ffi/utils.rs.  Do we want to: (1) justify these with PANIC_SAFETY; (2) bite the bullet and make this a TryFrom instead of From, with some error type indicating it's a purely internal error; or (3) re-architect to not use miette's JSON at all and just write our own serialization from miette::Report to a very similar JSON structure, that we can (a) control better and (b) know won't panic

When I last looked at the miette JSON format, it didn't seem like it was particularly well-documented (and thus maybe not widely used), so I'd lean towards a custom JSON format. We would presumably have a function that converts miette's format to ours, so that would be an indicator when something breaks.

Yes, it doesn't seem to be well-documented, and in fact I just looked at some outputs experimentally when crafting the structure in this PR.

Pushed another rev of this PR, now uses our own custom error JSON format and doesn't touch miette's JSON handler at all.  Gives us maximum control over the JSON shape.  Allows us to have message include all the sources (which seems to be the pre-existing behavior).

Updated this PR given #814.  Made the cedar-wasm changes a bunch simpler.

Updated this PR to account for the changes made in #824.  This PR does propose breaking changes to some of the choices made in #824:

Errors can have multiple source locations, at least in the fullness of time.  (Cedar doesn't use this much currently, but miette supports it, and it seems like a good future-proofing measure to support it in the FFI now.)  This PR proposes to rename #824's sourceLocation to sourceLocations and make it a JSON array.
Because there are many fields (up to 7) associated with each error now, this PR proposes to rename the main error message from error to message.
This PR also introduces one more level of nesting for errors compared to #824 (which added sourceLocation as a peer of error): validation errors are now { policyId: ..., error: { message: ..., sourceLocations: [...], ...}.  This could be flattened, but I thought it was valuable to have a consistent structure for errors which could be mirrored on the TS side, and the contents of error in this struct (DetailedError in the Rust in this PR) are used in many other places now, and there is not always a policyId associated with all of these errors (this struct is used for other kinds of errors as well, not just errors on policies).  I'm open to removing the nesting if yall think the flatter structure is more important than a consistent DetailedError type.
type: "error" renamed to type: "failure".  I think this is more clear, since the "success" case can still contain policy evaluation errors.  The top-level Failure is only for failures to parse or call the authorizer entirely.

Chiming in with some of the work I've been doing on our GitHub Actions integration - the error structure proposed here ({ policyId: ..., error: { message: ..., sourceLocations: [...], ...}) would be very easy to work with and I am in favor of it.

Split the "instantiate" -> "link" changes into #826

Now that #826 has been merged, I've rebased this PR on main and it is ready for re-review


Problems playing a LIVE DASH with multiperiod

https://shaka-player-demo.appspot.com/demo/#asset=https://moln.edgeware.tv/__cl/cg:ibc/__c/ibc2018/__op/default/__f/Manifest.mpd;lang=en-GB;build=uncompiled
What browser and OS are you using?:
Chrome 70 on macOS Mojave
What did you expect to happen?
Playing the LIVE stream without problems
What actually happened?
Starts, but stopped after a short while
Console shows this

Some feedback on why this is happing would be appreciated.
Thanks in advance.

I tried out that link, but I was getting CORS errors. If you control this asset, could you set up an 'Access-Control-Allow-Origin' header?

Hi @theodab the stream is protected by IP. If you can provide me with your external IP address I can get it unblocked.

Ok, I sent it to the email address you have listed in your GitHub profile.

Hi, @theodab your subnet should be unblocked now.

Looking at your manifests, the SegmentTemplate tags don't include a startNumber attribute. Consequently, Shaka Player doesn't know how to merge the old manifest and the new manifest together.

Hi, @theodab Thank you for looking at this. I´ll take your feedback back to my streaming team.

@theodab I think there is some confusion here about the type of manifest.
SegmentTimeline can be used with $Time$ or $Number$.
In this case, $Time$ is used and startNumber is not relevant at all.
In the case of $Number$, the MPD needs a startNumber attribute in the SegmentTemplate.
The difference can be seen on DASH-IF dash-live-source-simulator, where I just added the $Number$ version on the dev version.
$Time$: https://livesim.dashif.org/livesim/segtimeline_1/testpic_2s/Manifest.mpd
$Number$: https://livesim.dashif.org/livesim-dev/segtimelinenr_1/testpic_2s/Manifest.mpd
Adding number is one way to solve this issue, but Shaka-player should also work with this URL for $Time$.
In fact, we have been running this content,
https://moln.edgeware.tv/__cl/cg:ibc/__c/ibc2018/__op/default/__f/Manifest.mp
with Shaka-player during the full IBC show in September, and I have a compiled version that still works fine.
However, it does not work well with with the 2.3-master version, 2.4-master or 2.5.0-beta.
It is an assert in segment_index.js on line 169 (v2.5.0-beta) that fires
goog.asserts.assert(r2.endTime > r1.endTime &&
i == this.references_.length - 1 &&
j == references.length - 1,
'This should be an update of the last segment in a period');
The URL is IP-address blocked, but I'd be happy to open it up if you want to investigate this further. I can also provide a link to the compiled shaka-player that works.

All of the sudden things are working in 2.5.0-beta in Chrome 70 an in Safari 12.0.1 on my Mac running High Sierra. The content now plays nicely for 10 minutes which is about 20 period boundaries. I have not touched the source, nor the Shaka-player code.
So it seems that something is unstable, but I don't know what. I saw a similar behavior a couple of days ago as our canned demo with this source worked on one Mac, but not another, although having the same Chrome and OS versions.
Maybe the mapping between adaptationSets or Representations between the periods can be flawed somehow?

I can look into adding support for numbering segments by time, if number isn't provided.
Though things suddenly working is a little suspicious. I'm not sure why it would? Unless we have suddenly started fitting the segments, but we shouldn't do that for dynamic manifests.

When I notice the errors, the Period@start has changed.  We don't support this case and it is now against the DASH IOP guidelines.  We also support missing startNumber when using $Time$.

OK. I'll look into if the Period@start changes. It should not!  It may be because we create the Period with a SCTE-35 ad marker as early as possible in order to get minimal delay. This means that we create it when we know at what time we close the old period, but we do not yet have a segment in the new Period, which is thus empty. This is something that is not yet allowed in DASH but considered a bug by the editor.

The Manifest.mpd is a bad source with one period which is changing Period@start.
The proper URL ends with manifest.mpd (lower m):
https://moln.edgeware.tv/__cl/cg:ibc/__c/ibc2018/__op/default/__f/manifest.mpd
The latter produces periods like
     <Period start="PT1541685905S" id="p_0_385421476" duration="PT40S">
     <Period start="PT1541685945S" id="p_0_385421486">

while the Manifest.mpd has only the latest period start and with non-changing id="p_0_0" which is obviously wrong:
     <Period start="PT1541685945S" id="p_0_0">

The manifest.mpd URL plays nicely in Chrome 70 with Shaka-player v2.5.0-beta.

@TobbeEdgeware Glad to hear! Does this mean we can close the issue, or is there something else we can help with?

@ismena If no one else has something to add, you can close the issue. Thank you all for the investigation into this issue.

@ismena I think you can close this. Thanks for your engagement.


Add support for bcachefs

Since Linux 6.7, the bcachefs filesystem has been mainlined and currently, Booster does not support reading bcachefs block devices.
Since bcachefs supports authenticated encryption, a stretch goal would be to support device decryption of the root filesystem.

Multiple devices support is especially important.


Don't name the class the same as the namespace.

It messes things up. You can't do
using Toml;
at the moment. See this article for reference:
http://blogs.msdn.com/b/ericlippert/archive/2010/03/09/do-not-name-a-class-the-same-as-its-namespace-part-one.aspx
Obviously this will be a big breaking change, but maybe it's best to get it over with (and bump up the major version no.)?

That's actually a really good point. I'll try to get to it this weekend. Thanks for the tip!


use 422 status code for validation errors on user

nit that I came across in other branch.  we should use 422 status code for form validation errors

🧑🔬


Refactor/clean the xml

Explore the usage of multi dog joints
Clarify the relationship between dof sequence and inverse kinematics:

Either make it flexible to using any sequence
Or write script to change the order

Remove actuators and cameras and initialise them in init()
Check that simulation parameters are fully relevant
Check that body, joint, inertial and geom parameters make sense

According to the docs, all those dummy bodies (like *Coxa_roll/yaw) where multiple DOFs are required can be just removed

When a joint is defined inside a body, its function is not to connect the parent and child but rather to create motion degrees of freedom between them. If no joints are defined within a given body, that body is welded to its parent. A body in MJCF can contain multiple joints, thus there is no need to introduce dummy bodies for creating composite joints. Instead simply define all the primitive joints that form the desired composite joint within the same body. For example, two sliders and one hinge can be used to model a body moving in a plane.

https://mujoco.readthedocs.io/en/stable/modeling.html#kinematic-tree

In theory, cameras and actuators can be moved to separate XML files and then included, but for the actuators it would require to have joints names fixed.

include (*)
This element does not strictly belong to MJCF. Instead it is a meta-element, used to assemble multiple XML files in a single document object model (DOM) before parsing. The included file must be a valid XML file with a unique top-level element. This top-level element is removed by the parser, and the elements below it are inserted at the location of the include element. At least one element must be inserted as a result of this procedure. The include element can be used where ever an XML element is expected in the MJCF file. Nested includes are allowed, however a given XML file can be included at most once in the entire model. After all the included XML files have been assembled into a single DOM, it must correspond to a valid MJCF model. Other than that, it is up to the user to decide how to use includes and how to modularize large files if desired.

https://mujoco.readthedocs.io/en/stable/XMLreference.html#include

MuJoCo has a powerful mechanism for specifying default values to almost anything On one hand it makes XML file much less cluttered, but on the other hand it can be difficult to keep track of this tree of default classes in a large file, having everything defined explicitly in-place has its own benefits as well.
https://mujoco.readthedocs.io/en/stable/modeling.html#default-settings
For example, dm_control quadruped example made me totally confused when I looked at it for the first time :)
https://github.com/google-deepmind/dm_control/blob/main/dm_control/suite/quadruped.xml
Also it might be just a waste of time if you are ever going to import an updated model or something like this.


Call experimental endpoint of gemini (#4150)

TEMPORARY fix for https://github.com/openshiftio/openshift.io/issues/4150.

Ike Plugins (test-keeper)
Thank you @abs51295 for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?


fix(opentelemetry-core): modify regex to allow future versions

Which problem is this PR solving?

Fixes #979

Short description of the changes

Modifies the VALID_TRACE_PARENT_REGEX to allow for future versions excluding FF

I signed it

"I signed it"

I signed it

@srjames90 there is no need to fix the cla/linuxfoundation error. EasyCLA is our new CLA tool and the old one is deprecated.

@srjames90 there is no need to fix the cla/linuxfoundation error. EasyCLA is our new CLA tool and the old one is deprecated.

Oh, lol thanks


In Dark Mode in Search section white Box-shadow creates eye strain

Description
Issue
In Dark mode in the search section while hovering over the user component white box-shadow creates eye strain and the user name is not visible.
Solution
We can simply fix this by adding this color:black !important in .p-chip:hover pseudo class .
Screenshots
This is the issue:

And this is the after adding the above line of code :

Additional information
No response

Hi @eddiejaoude, can you please assign this issue to me? Thanks

sure @MAX-786  👍

We already seem to have issue created for the above mentioned problem and also the PR has been raised for the same
https://github.com/EddieHubCommunity/LinkFree/issues/1999
https://github.com/EddieHubCommunity/LinkFree/pull/2014
cc @eddiejaoude

oh thank you @skarthikeyan96 , sorry I missed this, let me look now


API-only deployment option

Feature name
API-only deployment option
Is your feature request related to a problem? Please describe.
N/A
Describe the feature you'd like to see implemented
An option to deploy a lower-cost, API-only variant of Perspective. That is, no UI, no search, just the graph API so I can query things in my account without the overhead of the UI. Useful for developers who don't need/want the full feature-set (and its associated cost).
Describe the value this feature will add to AWS Perspective

Customers can deploy an API-only variant of Perspective in accounts where they have low usage - the cost/benefit would be better in those cases
Developers who don't need/want the UI can deploy without it
It will provide additional marketing for the fact that Perspective has a nice API :)

Describe alternatives you've considered
N/A
Additional context
N/A

This has been prioritized for the next release of the solution.


feature: Add Event Type 3

Verify member address on multi-sig are authors of a mirror articles
Define flow for that

Use the the DAO ens form the mirror article link and check whether the connected address is part of that DAO or not


[Release] Verify 7.0.0 RC7 [WIP]

@github-actions crossbow submit --group verify-rc-source --param release=7.0.0 --param rc=7

Closing in favor of https://github.com/apache/arrow/pull/12262


add target and field's selector to HassService model

Looks good. Thanks @Zorgino

Coverage decreased (-4.6%) to 72.478% when pulling 1ccd7c8d284336e97a5cbf368a171765a735d919 on Zorgino:service_selectors into 60ea677cf6b09903dce6c34c4ee7add80d7272dd on net-daemon:dev.


Add conceptual overview for JSON v2 page

User is asking for conceptual overview for parsing JSON v2. We could add overview to this page or link to another doc.
Page: https://docs.influxdata.com/telegraf/v1.22/data_formats/input/json_v2/
Feedback: How do I parse something like? {"Pool":{"Sequence":18437,"Temp":78.80,"Humidity":17.00,"HeatIndex":77.18,"WiFiSignal":-19,"Lux":0.00,"InFlow":82.91,"OutFlow":82.72,"Pressure":-0.61,"Memory":25355}}
What is an object?  What is a Key? What is a Field? What are the relationships between them?  What items will graph?

Related to #3949


Fixed Arbitrary Code Execution by pickle.load

📊 Metadata *
Fix for Arbitrary Code Execution
Bounty URL:https://www.huntr.dev/bounties/1-pip-apache-flink
⚙ Description *
💻 Technical Description *
Describe in-depth, the technical implementation of the proposed security fix. Imagine you are describing it to a NASA engineer.
🐛 Proof of Concept (POC) *
🔥 Proof of Fix (PoF) *
👍 User Acceptance Testing (UAT)
The library has been successfully tested

👋 Hello, @tillrohrmann - @B3EF has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@tillrohrmann & @B3EF - thank you for your efforts in securing the world’s open source code! 🎉

👋 Hello, @tillrohrmann - @B3EF has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@tillrohrmann & @B3EF - thank you for your efforts in securing the world’s open source code! 🎉

Thanks for creating this fix @B3EF. I am not entirely sure whether this is really an exploit because Flink is designed to execute arbitrary code in parallel fashion. Hence, it is a bit the responsibility of the user to make sure that his code does the right things. For example, using the Java API you can also call System.exit().
Moreover, we need to be able to execute code from arbitrary Python libraries whose module names we don't know upfront.
I am also pulling in @dianfu who works on Flink's Python API for a second opinion.
Feel free to disagree.

Thanks a lot for the fix @B3EF and thanks @tillrohrmann for the ping. I agree with @tillrohrmann and also tend to think this is by design and should not be a problem.
Flink allows users to execute arbitrary code. Users could define user-defined functions in Java/Scala/Python languages in Flink, see [1] and [2] for more details. There are no limitations on what users could do in the user-defined functions and this is the same case for all kinds of user-defined functions in Flink (I think this is also the behavior shared by most projects, such as Spark, Beam, etc).


HBASE-22198 Fix flakey TestAsyncTableGetMultiThreaded

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1
mvninstall
289
master passed

+1
compile
55
master passed

+1
checkstyle
72
master passed

+1
shadedjars
268
branch has no errors when building our shaded downstream artifacts.

-1
findbugs
166
hbase-server in master has 11 extant Findbugs warnings.

+1
javadoc
34
master passed

_ Patch Compile Tests _

+1
mvninstall
250
the patch passed

+1
compile
54
the patch passed

+1
javac
54
the patch passed

+1
checkstyle
67
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
518
Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.

+1
findbugs
169
the patch passed

+1
javadoc
33
the patch passed

_ Other Tests _

+1
unit
8496
hbase-server in the patch passed.

+1
asflicense
25
The patch does not generate ASF License warnings.

10877

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/135

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 11c595129294 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 494a8efe5f

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/testReport/

Max. process+thread count
5292 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-135/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

The findbugs warnings are not introduced by this patch.


Move coin view to the base feature.

And possibly move consensus to base since even light wallet now ill have consensus, just a light version

I am not sure this is correct to do this, lets discuss before starting on this.


Add files suitable for usage as chat avatar.

Connect to #192

Add and attribute a cartoon robot svg.
Render a version of the robot in 1:1 aspect ratio.

Hey, I had 15 minutes waiting for a support shift to end before I could get tea, so I made SyncBot's avatar more Resin coloured.

@sonyagreen in case the last message didn't hit your "I should do something" pattern matching; this is an suggestion as to a SyncBot avatar; do you approve?

@sqweelygig If you re-add Sonya as a reviewer, it should wind up pinging her properly.


gnoigo.Execute() usage

Hi,
Thanks for this great project. It simplifies our work a lot.
The code is pretty clear but I have an issue when trying to call gnoigo.Execute().
I followed your example in the README and I got an error.
my code is:
conn, err := grpc.DialContext(ctx, serverAddress, opts)
if err != nil {
	log.Fatalf("failed to dial server: %v", err)
}
defer conn.Close()

clients := gnoigo.NewClients(conn)
rebootStatusOp := spb.NewRebootStatusOperation()
response, err := gnoigo.Execute(ctx, clients, rebootStatusOp) --------> Error is here
fmt.Println(response, err)

the error is:
type *"github.com/openconfig/gnoigo/system".RebootStatusOperation of rebootStatusOp does not match gnoigo.Operation[T] (cannot infer T)
how can I overcome this issue?
Thanks in advance,
Asaf.

What version of Go are you using?

go version go1.20.13 linux/amd64

Ah, it requires 1.21 for the improved generics inference. I see the go.mod file is behind. I'll fix that.