Create a table where the users can select previously created groups

Description
App developer would like to produce a table that lists groups created by the users earlier in the form process. The users should be able to select each row in the table in relation to a new question.
Could be solved with a checkboxlist.

Needs a way for the user to add new elements to the list

Screenshots

Considerations

Should the user be able to create new groups when in this state?

Acceptance criteria

Describe criteria here (i.e. What is allowed/not allowed (negative tesing), validations, error messages and warnings etc.)

Specification tasks

[ ] Development tasks are defined
[ ] Test design / decide test need

Development tasks

Add tasks here

Definition of done
Verify that this issue meets DoD (Only for project members) before closing.

[ ] Documentation is updated (if relevant)

[ ] Technical documentation (docs.altinn.studio)
[ ] User documentation (altinn.github.io/docs)

[ ] QA
[ ] Manual test is complete (if relevant)
[ ] Automated test is implemented (if relevant)
[ ] All tasks in this userstory are closed (i.e. remaining tasks are moved to other user stories or marked obsolete)

Relevant info for those wanting this functionality:

You can reference another (repeating) group in a Panel, in case the user might need to add a row to the group when they are working somewhere else in the app. This is related and reminded me about this need, but that functionality is not made to reach the same goal as this.
You should be able to use existing repeating groups as options inside a dropdown/checkbox/radio list. This lets you implement this functionality, albeit with a different user interface.
When #578 is implemented, you could perhaps use that component along with the above trick to use repeating groups as options to get almost the same UI, but without the option to add/edit data.

Apart from the options above, this issue describes a separate need in #107, so it should still be implemented at some point (unless the mentioned choices cover all current and future needs).

I was reminded about this issue, and so I'll comment again with later developments. There might be a way to use expressions (in the future) to create the data structure needed for the List component to do this. See relevant issues:

#1180
#925


Gracefully handle bad proofs of possession

At the moment we assert that proofs of possession are correct:
    assert bls_verify(
        pubkey=deposit_input.pubkey,
        message_hash=signed_root(deposit_input, "proof_of_possession"),

This assert is bad for a few reasons:

The "logic to ensure that deposits from 1.0 chain are processed in order" may prevent "skipping" deposits.
User funds go in a black hole.

My suggestion would be to process the deposit (no assert) and make validator status go directly to "withdrawn".

We already handled (1) in master. Looks like a cleanup messed up the functionality.
See process_deposit in master. We do the following to keep processing moving forward even if the validation failed.
if not proof_is_valid:
    return

As for (2), I'm more amenable to black holes than you are :)
Is there any security risk in moving the user funds to withdrawable if they failed their PoP?

We already handled (1) in master.

👍

Is there any security risk in moving the user funds to withdrawable if they failed their PoP?

I don't see any security risk. One benefit is that it would unlock the possibility to (intentionally) make deposits without having to be a validator, e.g. by leaving the PoP all zeros.

closing via #687


When using styled-jsx on a page this error is thrown: "Cannot read property 'start' of undefined"

[x] I have searched the issues of this repository and believe that this is not a duplicate.

I've been using styled-jsx in some components and it worked well. Now I tried using it directly in a page like this:
product.js
import React from 'react';
import Page from './page';
import HeadInclude from './headinc';

class ProductPage extends Page {
  render() {
    return (

        <HeadInclude />

bleh

    );
  }
}

export default ProductPage;

page.js
import { Component } from 'react';
import Local from '../src/local';

class Page extends Component {
  static getInitialProps() {
    return {
      local: Local.de_DE,
    };
  }
}

export default Page;

If I open localhost:3000/product I suddenly get this error:
Error in /pages/product.js?entry
Module build failed: TypeError: /pages/product.js?entry: Cannot read property 'start' of undefined
    at processCss (/node_modules/next/node_modules/styled-jsx/dist/_utils.js:447:49)
    at PluginPass.exit (/node_modules/next/node_modules/styled-jsx/dist/babel.js:232:51)
    at newFn (/node_modules/babel-traverse/lib/visitors.js:276:21)
    at NodePath._call (/node_modules/babel-traverse/lib/path/context.js:76:18)
    at NodePath.call (/node_modules/babel-traverse/lib/path/context.js:48:17)
    at NodePath.visit (/node_modules/babel-traverse/lib/path/context.js:117:8)
    at TraversalContext.visitQueue (/node_modules/babel-traverse/lib/context.js:150:16)
    at TraversalContext.visitMultiple (/node_modules/babel-traverse/lib/context.js:103:17)
    at TraversalContext.visit (/node_modules/babel-traverse/lib/context.js:190:19)
    at Function.traverse.node (/node_modules/babel-traverse/lib/index.js:114:17)

What's wrong? Everything else was working perfectly fine until I added

Now it works :D

Actually, I've been getting those errors as well. For example, this will trigger an error:
export default () => {
  return (

  );
};

@Leland-Kwong I tried Radium now instead of styled-jsx. Works quite well so far.

@Leland-Kwong In your case the problem is that nested styles are currently not supported by styled-jsx, see: https://github.com/zeit/styled-jsx/issues/365 :-(


dockerTools: populate the nix database of the container nix store

Currently, the contents closure is copied to the layer but there is no
nix database initialization. If pkgs.nix is added in the contents,
nix-store doesn't work because there is no nix database.
From the contents of the layer, this commit generates and loads the
database in the nix store of the container. This only works if there
is no parent layer that already have a nix store (to support several
nix layers, we would have to merge nix databases of parent layers).
We also add an example to play with the nix store inside the
container. Note it seems more is a missing dependency of the nix
package!
Motivation for this change
Be able to use nix in a container
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @lo1tuma @NeQuissimus @globin

This should be optional or outside of dockerTools. We don't use Nix inside of containers and do not want to increase our image sizes with a Nix DB.

I use nix inside the container because my container is a hydra slave. It could also be useful to be able to use nix inside the container for debugging purpose.
But I agree this increases the container size and this could be optional (or maybe, we could enable it by default and let the user disable it easily).

@puffnfresh I added the option populateNixDb to dockerTools.buildImage and set it to false by default.

@nlewo can you write this as a function which creates a new layer instead of modifying mkPureLayer?

I'd definitely prefer making this opt-in

@puffnfresh I think it's not trivial to add a layer, and I'm not sure it's a good idea to have a layer with a nix database without the store associated to that database.
Since the current patch doesn't change the actual behavior, but allow us to use nix inside the container, could we discuss your proposition in another PR?
Note also, we currently publish on the docker hub a docker image (nixos/nix) built with a dockerfile based on alpine. With this patch, we are going to generate this image with our tools :)

ping

@nlewo isn't this enough?
with import <nixpkgs> { };

let
  nixRegistration = contents: runCommand "nix-registration" {
    buildInputs = [ nixUnstable perl ];
    # For obtaining the closure of `contents'.
    exportReferencesGraph =
      let contentsList = if builtins.isList contents then contents else [ contents ];
      in map (x: [("closure-" + baseNameOf x) x]) contentsList;
    }
    ''
      printRegistration=1 perl ${pkgs.pathsFromGraph} closure-* > $out
    '';
  populateNixStore = args@{ contents, ... }:
    dockerTools.buildImage (args // {
      runAsRoot = dockerTools.shellScript "nix-db.sh" ''
        echo "Generating the nix database..."
        echo "Warning: only the database of the deepest Nix layer is loaded."
        echo "         If you want to use nix commands in the container, it would"
        echo "         be better to only have one layer that contains a nix store."
        # This requires Nix 1.12 or higher
        export NIX_REMOTE=local?root=$PWD
        ${nixUnstable}/bin/nix-store --load-db < ${nixRegistration contents}
      '';
    });
in
populateNixStore {
  name = "populated-example";
  contents = [ nix hello bash coreutils sqlite ];
}

Can we rewrite this PR to just add the above function to dockerTools?

@puffnfresh yeah, really nice improvement. Thanks.
I then submitted a new patch with your implementation. I use extraCommand instead of runAsRoot to avoid the need of qemu. I hope that I don't miss something regarding runAsRoot.

@globin could you have a look?

Maybe @grahamc you could have look?

LGTM!

Could we move forward on this PR ? :)

Thanks

@bjornfor I try to improve this in https://github.com/NixOS/nixpkgs/pull/29765


This is dealing with the 'Customizing the Login Screen'

I'm having some rather strange issues with this functionality.
I followed the Wiki instructions to a tee and also referred to the gist by jsbUSMC, same subject.
I have made only the changes to the AccountLogin.cshtml file.
I've installed the vegas script to "~Scripts/vegas..."
I've copied the image files I am going to use to "~Content/site/images...", they are a mix of .jpg and .png files. Currently I am not including the .png files in the routine.
After having built and then transforming the templates, the functionality seems to work partially. My login screen opens up with a gray background - sometimes. Other times I'll get a 404 for the AccountLogin.cshtml that it or a dependency can't be found.
When the login screen actually opens with only a gray background, the console tells me that one of the .jpg files can't be found. It appears to be a random file not found because the image file not found is different each time.
I have double checked, triple checked that the file names are correct, they are in the correct location, and are included in the project. This is a really bizarre thing happening.  I'll include my code below
    ViewData["Title"] = "Login";
    ViewData["PageId"] = "Login";
    Layout = MVC.Views.Shared._LayoutNoNavigation;
}

@section Head
{
    <link rel="stylesheet" href="~/Scripts/vegas/vegas.min.css"/>

}

@if (SiteInitialization.SkippedMigrations)
{

    <button type="button" class="close" data-dismiss="alert" aria-hidden="true">×</button>

 Warning!

    MyApp skipped running migrations to avoid modifying an arbitrary database.
    If you'd like to run migrations on this database, remove the safety check
    in SiteInitialization.RunMigrations method.

}

@if (ViewData["Activated"] != null)
{

    <button type="button" class="close" data-dismiss="alert" aria-hidden="true">×</button>

@LocalText.Get("Dialogs.InformationTitle")

    @Texts.Forms.Membership.SignUp.ActivationCompleteMessage

}

``

typo on my part, issue has been resolved.

Latest template has vegas integrated. You may also check that one.

Thanks, I've, as a rule, been upgrading the SERENE template and solutions I'm working on as the updates are posted.


Fixed SSL/TLS error

I just found for a temporary solution for SSL/TLS error. Maybe we can change it later if we create a parameter for it.

This was it will create  a problem of certain xmpp server, I had tested so i am going to give a more flexible way to user's end possible it will be out in next couple of days where you will be able to enable and disable SSL/TLS connection as well as re-connection attempts while making your user authenticated.

Oh that could be better! Thanks for quick response. I'm waiting for your update.


fix(local-setup): simplify local squidex setup

Ticket: https://trello.com/c/WH7OSCwI/1190-integration-tests-local-setup

sounds nice. I suppose the only barrier to local dev that will then remain is data import / Auth0 linking?


Doesn't build on OS X 10.11+

I get the following output when I follow the directions in the README file...

What should I do to fix this problem?  Thanks!

I think the issue is with NVCC not supporting clang version 8.0.  You probably need to revert clang to a lower version until NVIDIA updates NVCC.  See the NVCC installation guide for OS X: http://docs.nvidia.com/cuda/cuda-getting-started-guide-for-mac-os-x

it seems you have the beta xcode 8 installed... One solution might be to switch back via:
$ sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer

and then try.


Security dep update

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   87.66%   87.66%
=======================================
  Files          78       78
  Lines        2796     2796
  Branches      605      605
=======================================
  Hits         2451     2451
  Misses        342      342
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a07b28...3d2233e. Read the comment docs.


improve handling pickle warning

@ChristinaEimer
implement try/catch around pickle load, catch warning, print meaningful message (inform user what is going on in a simple and understandable way), proceed in code

it is not clear to me how you know that the warning can only refer to a library version mismatch:
https://github.com/friendsofstrandseq/ashleys-qc/blob/83c6b304ff5c1ccbedb3713de7f7151bddc3b84c/src/ashleyslib/prediction.py#L30
is that documented somewhere?
Also, please make it explicit here that ASHLEYS proceeds despite the version mismatch:
https://github.com/friendsofstrandseq/ashleys-qc/blob/83c6b304ff5c1ccbedb3713de7f7151bddc3b84c/src/ashleyslib/prediction.py#L39


Feature: Approval of edits

Describe the feature you'd like
I would like a feature for the approval of edits by the owner of a page
Describe the benefits this feature would bring to BookStack users
A viewer could purpose changes to a page or chapter e.g. spelling or even adding a new section an collaborate on a book with the author / owner

Thanks for the request @MaximilianKindshofer. I'm going to close this off since I see a lot of logical overlap with #473.


PageHeader: Add visual ordering and PageLayout story example

Add order CSS attribute
Just added visual ordering for the children using order css attribute. I am not too sure if they do any good though. As this attribute only changes visual ordering and this order is not reflected on the DOM. PageHeader children have to be written in the correct order to provide the same ordering both for visually and in the DOM. Slots might be an option but there are quite a few children so I don't know if this would be practical. I am open to suggestions 🙌🏼
Add an example story with PageLayout

Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

I don't understand the reason behind the order changes. Could you explain?

@mperrotti My intention behind the ordering is to make sure the children are always rendered/displayed in the intended order even though they are "mistakenly" written in a different order. For example the TitleArea children should always follow the order of LeadingAction, LeadingVisual, Title, TrailingAction, TrailingVisual and Actions. Same goes for main children as well i.e ContextArea, TitleArea, DescriptionArea, NavigationArea I am not sure if this is absolutely necessary but I saw this pattern on PageLayout and wanted to give it a go. However, as I mentioned on the description, I am some concerns. Just copy-pasted what I wrote in the description as well.

Just added visual ordering for the children using order css attribute. I am not too sure if they do any good though. As this attribute only changes visual ordering and this order is not reflected on the DOM. PageHeader children have to be written in the correct order to provide the same ordering both for visually and in the DOM. Slots might be an option but there are quite a few children so I don't know if this would be practical. I am open to suggestions 🙌🏼

Thanks @broccolinisoup - I understand now.
I think this is a nice way to enforce layout/placement without relying on slots. I can't think of a cleaner way to do it.

Thanks @broccolinisoup - I understand now.
I think this is a nice way to enforce layout/placement without relying on slots. I can't think of a cleaner way to do it.

Thanks @mperrotti!

It looks like these changes break the spacing between the action buttons

This seems to be an issue on the Hidden-component-refactor that I branched off this PR. I updated the styling of the story on the Hidden-component-refactor branch and rebased again , so it should be good  ✨


_check_parent_dir_exists() does not create a directory when create=True

Describe the bug

Running _check_parent_dir_exists() does not create a directory when create=True AND the requested path is a new parent folder with a child subfolder. This is because os.mkdir() does not create new folders recursively. Here is an example:
>>> import os
>>> os.mkdir("outputs/gtfs") # works OK, so delete folder and try with grandchild
>>> os.mkdir("outputs/gtfs/validation")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
FileNotFoundError: [Errno 2] No such file or directory: 'outputs/gtfs/validation'

StackOverflow suggests using os.makedirs() :
>>> os.makedirs("outputs/gtfs/validation") # grandchild created as expected.

This could be dropped in directly to replace os.mkdir link to code line:
def _check_parent_dir_exists(pth, param_nm, create=False):
	_is_path_like(pth, param_nm)
	parent = os.path.dirname(pth)
	if not os.path.exists(parent):
		if create:
			os.makedirs(parent)
			print(f"Creating parent directory: {parent}")
	else:
		raise FileNotFoundError(
			f"Parent directory {parent} not found on disk."
		)

	return None

Or the exist_ok argument could be used to handle the whole 'does the folder already exist' if/else statement internally.
This aspect should also be covered by a unit test (in test_defense.py) to prevent reocurrence.
Environment

OS: macOS
Python version: 3.9.13
Java version: 11
Python module versions (if different from requirements.txt):

Steps to reproduce

New folder is generated regardless of how many new sub-directories need to be created.

Describe the bug
When running src/transport_performance/osm/osm_utils.py, if using a path in the out_pth argument containing backslashes in the string, this is not recognised as a path and instead creates a file with that character or whatever escape character happens in the filename. Using double slash to prevent escape character just creates a file with the slash in the name.
This behaviour is caused by function _check_parent_dir_exists().
Environment

OS: macOS
Python version: 3.9.13
Java version: 11
Python module versions (if different from requirements.txt):

Steps to reproduce
>>> filter_osm(out_pth=Path('hello\asdf.pbf'))
"hello sdf.pbf"
>>> filter_osm(out_pth=Path('hello\\asdf.pbf'))
"hello\asdf.pbf"


VulcanJS 1.8 - Example Forum - feed.xml  tag url issue ?

Hi,
I just publish the new version of my website based on a migration from VulcanJS 1.5 to VulcanJS 1.8 (example forum package).
I notice that the feed.xml,< link > tag, don't use absolute url but relative url, example
< link >
/posts/eRCBqHcGJs3SFnq6H/dmcc-and-china-partnership-to-create-dubai-marketplace-for
< /link >
instead of
< link >
https://mywebsiteurl/posts/eRCBqHcGJs3SFnq6H/dmcc-and-china-partnership-to-create-dubai-marketplace-for
< /link >
Do I missed some new setting ? If no, how can I fix this issue ?
Thank You
Adalidda

Hi,
I found that the code to update is in lib/server/rss.js
I update the code to fix this bug and now everything is working fine.
Thank You
Adalidda


config: v2 Address resolution using named resolver

Add Address::ResolverFactory and Address::Resolver interfaces for instantiating Address::Instances from strings in protos. The interface is completely synchronous, so all translation must be done inline without any network access, meaning this can't be used to resolve hostnames via DNS. Doing so would require making more things asynchronous; this can be done, but let's not do it until it's necessary.
This is progress towards #1477

TSAN was stuck, kicked it.


Editjoin disk

Pull request for the code from Bhargav and Ankit

Coverage increased (+0.4%) to 76.525% when pulling adec91cdd1ea76997383b05c256a56e76879ea71 on Bhargav145:editjoin_disk into 624212b748ff34fe9b2bf3045f6a0c81cf3d8ab3 on anhaidgroup:master.

Coverage increased (+0.4%) to 76.525% when pulling adec91cdd1ea76997383b05c256a56e76879ea71 on Bhargav145:editjoin_disk into 624212b748ff34fe9b2bf3045f6a0c81cf3d8ab3 on anhaidgroup:master.

Coverage increased (+0.4%) to 76.525% when pulling adec91cdd1ea76997383b05c256a56e76879ea71 on Bhargav145:editjoin_disk into 624212b748ff34fe9b2bf3045f6a0c81cf3d8ab3 on anhaidgroup:master.

Coverage increased (+0.4%) to 76.525% when pulling adec91cdd1ea76997383b05c256a56e76879ea71 on Bhargav145:editjoin_disk into 624212b748ff34fe9b2bf3045f6a0c81cf3d8ab3 on anhaidgroup:master.

Coverage increased (+0.4%) to 76.525% when pulling adec91cdd1ea76997383b05c256a56e76879ea71 on Bhargav145:editjoin_disk into 624212b748ff34fe9b2bf3045f6a0c81cf3d8ab3 on anhaidgroup:master.


Configurable custom emojis

As some may know, all bots have the privilege of using emojis from any server they're in, like they had Nitro.
I want to add an emoji entry to config.yml where you can add entries for certain emojis.
emoji:
    - levelup: 🌟
    - death: ☠
    - deathplayer: 💀
    - druid: ❄
    - sorcerer: 🔥
    - paladin: 🏹
    - knight: 🛡
    - checkmark: "<:greencheck:448645325918437376>"
    - cross: "<:redcheck:448645341659791360>"

In this case, checkmarks and crosses use a custom emoji, :greencheck: and :redcheck: respectively.
It's recommended to add NabBot to a server just for the custom emojis, to avoid changing the shortcuts, as they would break the reference.

f974030 added the option to use custom emojis for /serverinfo

Implemented in dev branch
For instructions on how to use, check:
http://galarzaa90.gitlab.io/NabBot/customizing/config/#emojis


AbstractCloudConfig imports classes from Spring data Redis, MongoDB and RabbitMQ

Hi,
In project "spring-cloud-spring-service-connector", the object AbstractCloudConfig imports classes from "spring-data-redis", "spring-data-mongodb" and "spring-data-rabbitmq". Therefore it is impossible to extend it to create a DataSource, without adding useless dependencies.
Thanks, regards,
Gauthier

Can someone point me how to use spring cloud for a very simple standalone Java Web application !? I would be happy to test it on CF. Thanks

@codecandy2015 There are several examples of Java Web applications using Spring Cloud a few comments up in this thread, and the README file in this repo have documentation. Are you looking for something different than what these samples and docs already provide?

Hi Scott,
I am trying to write micro services which are based on Jersey. One of the tasks is to read from a MySql table. At the moment I have it running on Tomcat which is working fine using the context.xml.
I want to use Cloud foundry for this and came here to Spring cloud. It would be a good way to use Spring cloud rather than parsing thru the JSON String for environmental variaables.
I am trying to use it like this in the createEMF method,
public class ServletUtility implements Closeable extends AbstractCloudConfig {
private EntityManagerFactory emf;

public ServletUtility (String pUnit) {
   super();
   this.emf = createEMF(new InitialContext(), pUnit);
}

public EntityManagerFactory createEMF (InitialContext ctx, String persistanceUnit) {
       DataSource ds = connectionFactory().dataSource();
       Map <String, Object> properties = HashMap <String, Objects>();
       properties.put("javax.persistance.nonJtaDataSource", ds);
       properties.put("eclipseLink.target-database", TargetDatabase.MySQL);
       return Persistance.createEntityManagerFactory(persistanceUnit, properties);
     }
}

Get a null pointer error. You have any suggestions Scott ?!

@codecandy2015 Since this question is not related to the original issue, this conversation should be moved to a separate issue.
The AbstractCloudConfig class is designed to be used in a Spring application in a @Configuration class. If your app isn't using Spring, or you aren't using Java-based Spring configuration, then AbstractCloudConfig isn't going to do what you want it to do.
Take a look at the documentation on using Spring Cloud Connectors Core for examples of how to use the Connectors API directly to get a DataSource object.

Thanks Scott, I followed the page, got it working ;)! Cheers

Having exactly the same issue in three projects.

Fixed in https://github.com/spring-cloud/spring-cloud-connectors/commit/625040ca1a0699726966997ac0dac40c59fac434.
The reason that this problem was hard to nail down was that (per my testing anyway) the NoClassDefFoundException would only be triggered when the @Configuration class that extends AbstractCloudConfig was nested within a Spring Boot main class (or possibly nested in any @Configuration or @Component class). The exception would not get thrown if the @Configuration class was a top-level class. There may be other edge cases, but that explains why the problem didn't happen in all the (older, mostly non-Boot) projects listed in the comment above, but happened in many newer (I presume Boot) projects.
Moving the ServiceConnectionFactory class (which is where the DataSource, MongoDB, Redis, RabbitMQ dependencies come from) from an inner class of AbstractCloudConfig to a top-level class, and making AbstractCloudConfig depend on an interface instead of this concrete class, change the way Spring inspects these classes for configuration, and prevents the invocation of the Java refection API that was triggering the NoClassDefFoundException.


[Feat]: Auto Commenting feature for PR Raised

This feature aims to address the problem of delayed and inconsistent communication following the raising of PRs. By automatically commenting on PRs as soon as they are raised, it ensures that contributors receive immediate feedback and acknowledgment for their efforts. This fosters a positive and supportive environment for collaboration, encouraging continued participation and engagement from contributors.

@Swarnendu0123 please assign me this issue under gssoc

Merging it with #57


[Bug] Introspect not working with flatten and serde_with

Example
// ser.rs

use serde::{Serialize, Deserialize};

serde_with::with_prefix!(my "my_)");

#[derive(Debug, Serialize, Deserialize)]
pub struct B {
    pub b: String,
    #[serde(rename="z")]
    pub b2: usize
}

#[derive(Debug, Serialize, Deserialize)]
pub struct A {
    pub a: usize,
    #[serde(flatten, with="my")]
    pub bx: B
}

#[derive(Debug, Serialize, Deserialize)]
pub struct A0 {
    pub a: usize,
    pub bx: B
}

#[derive(Debug, Serialize, Deserialize)]
pub struct A1 {
    #[serde(with="my")]
    pub a: usize
}

#[derive(Debug, Serialize, Deserialize)]
pub struct A2 {
    #[serde(flatten)]
    pub bx: B
}

#[derive(Debug, Serialize, Deserialize)]
pub struct A3 {
    #[serde(with="my")]
    pub bx: B
}

// main.rs

use serde_aux::prelude::*;
mod ser;

fn main() {

    println!("A = \t{:?}", serde_introspect::<ser::A>());
    println!("A0 = \t{:?}", serde_introspect::<ser::A0>());
    println!("A1 = \t{:?}", serde_introspect::<ser::A1>());
    println!("A2 = \t{:?}", serde_introspect::<ser::A2>());
    println!("A3 = \t{:?}", serde_introspect::<ser::A3>());
}

# Output

A =     {
  "a": 2,
  "my_)b": "AA",
  "my_)z": 22
}
A0 =    {
  "a": 2,
  "bx": {
    "b": "AA",
    "z": 22
  }
}
A2 =    {
  "b": "AA",
  "z": 22
}
A3 =    {
  "bx": {
    "my_)b": "AA",
    "my_)z": 22
}

A =     []          # Wrong
A0 =    ["a", "bx"] # This is ok
A1 =    ["a"]       # Actually panics, my bad
A2 =    []          # Wrong
A3 =    ["bx"]      # Wrong

Hi! Thank you for filing your issue! I am not aware of how it should work together (not usually use serde_with), can you please provide the examples with the expected results?

Sure. Here you go. I've edited my bug report to include jsons

So it MAY work with serde_with prefixing, but it certainly fails with the flattened structs

I have just noticed you use the serde_introspect crate, which is not a part of serde_aux. Also, I couldn't see any use of serde_aux here except for the use statements, which do not do anything independently. Perhaps you meant to file an issue in the serde_introspect crate instead?

Que? There is no such a crate... Also https://github.com/iddm/serde-aux/blob/master/src/serde_introspection.rs#L35

Que? There is no such a crate... Also https://github.com/iddm/serde-aux/blob/master/src/serde_introspection.rs#L35

I couldn't see any use of serde_aux here except for the use statements, which do not do anything independently

I literally took it from this repo. See docs

Oh, I apologise! It wasn't me who added it, and I had completely forgotten about its existence.
The serde attribute often messes up with everything else. It has been long known and not many things can be fixed, unfortunately. From what I can tell right now, it seems that the problem is introduced by using the serde's flatten attribute. Additionally, the serde_with might be breaking things another way. It is going to require research, which I unfortunately have no time for. @lucatrv would you like to take a look at what might cause a problem here?


How to install/use Torch2 implementation (SM_90)

Hi! How can one install and use the torch2 implementation?
I installed it via Docker and the installation tutorial and got this:
/usr/lib/python3/dist-packages/transformers/generation/utils.py:1219: UserWarning: You have modified the pretrained model configuration to control generation. This is a deprecated strategy to control generation and will be removed soon, in a future version. Please use a generation configuration file (see https://huggingface.co/docs/transformers/main_classes/text_generation)
  warnings.warn(
Traceback (most recent call last):
  File "<string>", line 21, in _fwd_kernel
KeyError: ('2-.-0-.-0-d82511111ad128294e9d31a6ac684238-394352f6a8351feaac334fbb8cc63fa4-46c7c5d46afed8316facd72e7e581bec-d42e1fe9b96880bf34a5514915acc6aa-39e3c68a052760cc345a9147b0d68f7d-5c5e32ff210f3b7f56c98ca29917c25e-06f0df2d61979d629033f4a22eff5198-4ac47e74762ba6a774cceea0e1e75ae6-13b7ffc189bd9fba7696034bbcfee151', (torch.bfloat16, torch.bfloat16, torch.bfloat16, torch.bfloat16, torch.bfloat16, torch.float32, torch.float32, 'fp32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32', 'i32'), ('vector', True, 128, False, False, True, 128, 128), (True, True, True, True, True, True, True, (False,), (True, False), (True, False), (True, False), (True, False), (True, False), (True, False), (True, False), (True, False), (True, False), (True, False), (False, False), (True, False), (True, False), (True, False), (True, False), (True, False), (False, False), (False, False), (True, False), (True, False), (True, False), (True, False)))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/app/mpt7b.py", line 34, in <module>
    output_ids = model.generate(input_ids, max_length=100)
  File "/usr/lib/python3/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/transformers/generation/utils.py", line 1437, in generate
    return self.greedy_search(
  File "/usr/lib/python3/dist-packages/transformers/generation/utils.py", line 2248, in greedy_search
    outputs = self(
  File "/usr/lib/python3/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/modeling_mpt.py", line 237, in forward
    outputs = self.transformer(input_ids=input_ids, past_key_values=past_key_values, attention_mask=attention_mask, prefix_mask=prefix_mask, sequence_id=sequence_id, return_dict=return_dict, output_attentions=output_attentions, output_hidden_states=output_hidden_states, use_cache=use_cache)
  File "/usr/lib/python3/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/modeling_mpt.py", line 183, in forward
    (x, past_key_value) = block(x, past_key_value=past_key_value, attn_bias=attn_bias, attention_mask=attention_mask, is_causal=self.is_causal)
  File "/usr/lib/python3/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/blocks.py", line 36, in forward
    (b, _, past_key_value) = self.attn(a, past_key_value=past_key_value, attn_bias=attn_bias, attention_mask=attention_mask, is_causal=is_causal)
  File "/usr/lib/python3/dist-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/attention.py", line 180, in forward
    (context, attn_weights) = self.attn_fn(query, key, value, self.n_heads, softmax_scale=self.softmax_scale, attn_bias=attn_bias, key_padding_mask=key_padding_mask, is_causal=is_causal, dropout_p=self.attn_dropout_p, training=self.training, needs_weights=needs_weights)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/attention.py", line 120, in triton_flash_attn_fn
    attn_output = flash_attn_func(query, key, value, attn_bias, reset_is_causal, softmax_scale)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/flash_attn_triton.py", line 469, in forward
    (o, lse, ctx.softmax_scale) = _flash_attn_forward(q, k, v, bias=bias, causal=causal, softmax_scale=softmax_scale)
  File "/root/.cache/huggingface/modules/transformers_modules/mosaicml/mpt-7b/4ff95c4aec5c04ba509ddf517c56720541a7a487/flash_attn_triton.py", line 363, in _flash_attn_forward
    _fwd_kernel[grid](q, k, v, bias, o, lse, tmp, softmax_scale, q.stride(0), q.stride(2), q.stride(1), k.stride(0), k.stride(2), k.stride(1), v.stride(0), v.stride(2), v.stride(1), *bias_strides, o.stride(0), o.stride(2), o.stride(1), nheads, seqlen_q, seqlen_k, seqlen_q_rounded, d, seqlen_q // 32, seqlen_k // 32, bias_type, causal, BLOCK_HEADDIM, BLOCK_M=BLOCK, BLOCK_N=BLOCK, num_warps=num_warps, num_stages=1)
  File "/usr/lib/python3/dist-packages/triton_pre_mlir/runtime/jit.py", line 106, in launcher
    return self.run(*args, grid=grid, **kwargs)
  File "/usr/lib/python3/dist-packages/triton_pre_mlir/runtime/autotuner.py", line 200, in run
    return self.fn.run(*args, **kwargs)
  File "<string>", line 41, in _fwd_kernel
  File "/usr/lib/python3/dist-packages/triton_pre_mlir/compiler.py", line 1256, in compile
    asm, shared, kernel_name = _compile(fn, signature, device, constants, configs[0], num_warps, num_stages,
  File "/usr/lib/python3/dist-packages/triton_pre_mlir/compiler.py", line 901, in _compile
    name, asm, shared_mem = _triton.code_gen.compile_ttir(backend, module, device, num_warps, num_stages, extern_libs, cc)
RuntimeError: Internal Triton PTX codegen error:
ptxas fatal   : Value 'sm_90' is not defined for option 'gpu-name'

You are in a world of "not formally supported"... Be careful.
I actually started workin on this problem this morning.
The workaround for the specific issue you're citing is to install triton_pre_mlir like this:
pip install triton-pre-mlir@git+https://github.com/vchiley/triton.git@triton_pre_mlir_sm90#subdirectory=python

see here for details.
for sm90s you might also need to set
model:
  loss_fn: torch_crossentropy

in your config
Note:
I've only tested this one GPU and the testing has been minimal
Let us know if you hit other issues.

Is this version pushed to the llm-foundry docker repository yet?

what do you mean by llm-foundry docker repository?
If you follow the llm-foundry install instructions, doing
pip install triton-pre-mlir@git+https://github.com/vchiley/triton.git@triton_pre_mlir_sm90#subdirectory=python

right after installs the version that enables it to run on SM90 GPUs (H100s)
Note: this is experimental / not formally supported...

This in-progress PR may help you: https://github.com/mosaicml/llm-foundry/pull/260

We've merged the updt triton-pre-mlir
Let us know if you experience any other issues

Hello @vchiley , sorry to ping you like this. I have also received the same Value 'sm_90' is not defined for option 'gpu-name' as OP. I followed your instruction to install the _sm90 branch and checked the PRs. However, I still got the same issue.
pip install triton-pre-mlir@git+https://github.com/vchiley/triton.git@triton_pre_mlir_sm90#subdirectory=python

I'm running with my own custom code that tries to integrate MPT. attn_imp torch works. It's just triton I couldn't get working unfortunately. I was wondering if I have done something incorrectly?


duke-lucene is not deployed on Maven Central

Duke 1.2 is available on Maven Central. That's great, however, if I try to use Lucene, Maven tells me "Failure to find no.priv.garshol.duke:duke-lucene:jar:1.2". Indeed, I don't see it on Maven Central and it should be added.

@marco-brandizi the multi-model structure has been introduced in version 1.3 (not yet released) See here https://github.com/larsga/Duke/pull/191 . Duke 1.2 is a uber jar with all the dependencies included (even lucene).

Oh, I see, I'll try 1.2, thanks.


Sign with derive Wrong Data error

When calling the sign command with the "derive" option, I always get an 6A80 WRONG_DATA error. Data sent is : the hash to sign (32 bytes) | 4x32-bit integers
I guess this error is thrown by the L1261 in KeycardApplet.java. Still, I can't see what's wrong with the data I send. For example EXPORT KEY is always working fine, even with "derive" option and a path provided.
Here are some logs about the issue I'm facing :
Public Key reading (export)
Use Derive
80 c2 01 01 + 4x4 bytes for path (= m/44'/0'/0'/0)
--> sending (SCP)
80c20101108000002c800000008000000000000000
<-- received (SCP) :  9000
a1438041049caa9dc12313a0101ca0dfc35d3e87039d070e09e9da4bf2119e40d1a249194a558be3ec5a0e34eeaaef1dfd708d1bb68da1906b450343a69fbb4d750cdaeae0
Sign
Use Current
80 c0 00 00 + 32 bytes hash
--> sending (SCP)
80c000002096ee85875b737ea6dce2f892516c40af0d296112ad64b6ff1eb0ce7034c2938b
<-- received (SCP) : 9000
a08189804104f50167e9f253bbbd7613ac637111d5abda618329108fb142d5c79c82fa286f0066ad9438a37e9224fdd57f68322fbd18f1ce37cf4c51ccc5ed6f6c617dab8f3e304402206ca8cc0881a57c93a71914063bea5c152cfd29766ef6e508bb53864945ceea1f02206353f923168366d6f343aff31c8a479339764ef8f90dd18413fe70a499ccfe00
Sign
Use Derive
80 c0 01 00 + 32 bytes hash + 4x4 bytes for path (= m/44'/0'/0'/0)
--> sending (SCP)
80c001003096ee85875b737ea6dce2f892516c40af0d296112ad64b6ff1eb0ce7034c2938b8000002c800000008000000000000000
<-- received (SCP) :  6a80
Can you test on your side? What is the data format for SIGN when P1=1 ?

can you check that you are using applet version 2.2? Keycard now ships with applet version 2.1 which did not have this functionality. But you can reinstall it using the keycard-cli tools to use the new features.

Great, I'll try. My card is indeed using for now the applet v2.1.
I didn't see the update about this point was done recently : https://github.com/status-im/status-keycard/commit/5bc5e23272938c077b3ceadf8367a831f42a9dc8
The cards was ordered 3 weeks after the release of the 2.2, sadly shipped with the 2.1 version.
At least, the doc is very well updated, congrats ;)

I updated my cards applet to v2.2 and I can confirm the sign with derive option is now working.


Show "node" subfields for unset schema params

This PR addresses the fact that our change to storing all value-specific data underneath the "node" dict makes the subfields not appear for unset parameters in a manifest. I fixed this by adding a 'default', 'default' entry that is always empty and is used to initialize the node dict whenever it gets populated, mimicking the pattern that gets used for schema parameter keypaths themselves.
I was originally planning to have 'global', 'global' be always filled in by default, but I realized this mucks with some of the logic as it loses the distinction between required and optional pernode parameters (required ones should not have a 'global', 'global' entry).

Github is currently reporting service degradation for Actions, will re-run once it's restored: https://www.githubstatus.com/

@gadfort I ended up implementing what we discussed offline where the defvalue field gets replaced by the value field under default, default. This change actually felt pretty natural during implementation - it simplifies the code in a few places.
Although this is not what we discussed, I decided not to provide a mechanism to override the default value (but I did add a mechanism to retrieve it). Even though this technically regresses on functionality, I still think it feels a little iffy to do it in the first place, and it might be okay to not allow it unless we come up with a compelling reason to make it possible.

Please update docs and resolve merge conflicts


Pass in HBRequestContext as the second argument

I'm aware, I wanted to do this one step at a time. To simplify the changesets to review.

Merge when you are ready. When you merge can you make sure you use Squash and merge to keep the commits clean

I don't have the permissions to do that @adam-fowler

I don't have the permissions to do that @adam-fowler

try now


Request: Transport options

We are using redux-logger and it provides many useful pieces of functionality. However we would like to also send these logs to a server for processing and analysis.
We have managed to do this through setting redux-logger to log to js-logging, and setting that to transport to our server and output to the console.
However, this has broken the console indenting, breaks the colourisation1, and generally makes a mess of things. It would be much nicer if we could just set redux-logger to log to an external service, or if you could suggest an external library it did integrate with nicely that could do this.
Similarly to #245, it would also be nice if we could use this library elsewhere in our code.
1For some reason the first piece of the log "action %cACTION %c @ timestamp" doesn't end up with any other arguments to actually set these colours or the font-weight, so we are having to check for this special case and insert them.

I see your point, thanks for feedback.
Can you please tell how you'll use it? What is your backend for logging? Do you use something like logstash?

Currently we are using Splunk, but I would also be interested in a Logstash solution.

@JBoudMS, we plan to add logging interception feature that would allow you to execute custom logic (and get access to next state, previous state, action) right before outputting the log message. You can read more about it in #292.


Error occured when uploading a proguard mapping file

I followed the guide to setup Acrarium on my local tomcat server, and it truly worked well. But when I tried to upload a proguard mapping file, I was prompted this error: "Unexpected Server Error".
I have no server-side background knowledge, so can't figure out this is something I need to do on my local test environment or an issue.

Which version were you using?

Stale - closing


Fix YAML parsing Norway as False

If the user writes no in the country list, they mean Norway, not the opposite of "yes".
Unfortunately, YAML interprets this as False, causing exceptions later when the code expects a string.
This only happens if no is unquoted, but none of the example countries have quotes, and there's no mention of YAML in the default config, so it's likely users will discover this behavior the hard way.
This PR's fix replaces any False value in the COUNTRY_LIST with the string 'no'.

BTW, if you like this PR, I'd appreciate it if you added the label hacktoberfest-accepted to it. That way, it can count toward my Hacktoberfest total. (If not, no worries.) Thanks for making this!

Thank you for the fix. I have added it until PyYAML implements the YAML 1.2 standard, which will solve this problem.
In this version (1.2), 'no' is no longer converted to 'False'


breakdown when find no face

Hi, I wrote a program to automatically enroll and verify
But when the API could not find face in the given image, it broke down
Is there any way to make it continue even if the program has some exception?

Traceback (most recent call last):
File "run_ROC_test.py", line 75, in
args.start_threshold, args.end_threshold, args.threshold_step)
File "run_ROC_test.py", line 51, in main
kairos_face.enroll_face(subject_index, 'ROC', file=image_path)
File "/usr/local/lib/python2.7/dist-packages/kairos_face/enroll.py", line 26, in enroll_face
raise exceptions.ServiceRequestError(response.status_code, json_response, payload)
kairos_face.exceptions.ServiceRequestError: {u'Errors': [{u'Message': u'no faces found in the image', u'ErrCode': 5002}]}

I solve this by commenting the raise exceptions.ServiceRequestError in the file, and reinstall with pip

Hi, and sorry for taking this long to answer.
This exception is simply passing the response obtained from the Kairos service itself. One thing that you can do is to catch the ServiceRequestError exception and handle it according to the ErrCode passed in the exception contents, instead of changing the library itself.
Since not having a face in the image is not exactly an unexpected situation, it may be worth handling this scenario in the library itself and make it return something less intrusive, but I'll need some more time to think about it.

@ffmmjj thank you for your reply, I will try to handle the exception outside the library.


Please update documentation

Hi,
I really like the package. However, I have a really hard time using the package. Whenever I need something specific, I get stuck and spend hours trying to figure out what is this.
For example:
getAccount()
ram_quota: 69053,
total_resources: {
  cpu_weight: "0.7588 EOS",
  net_weight: "0.6216 EOS",
  owner: "xxxx",
  ram_bytes: 69053,
}

What is the difference between ram _ quota and ram _ bytes?

ram_bytes is the one used in the system contract under the account.   That is the main one users will be looking at.  ram_quota is used in get_account_limits which I suspect is a block producers limit on all the accounts..
https://github.com/EOSIO/eos/search?q=get_account_limits&unscoped_q=get_account_limits
Your going to have to look at the code on some of this if you don't find docs.


Template download still have old grid

What should happen?
When downloading template from https://get.foundation/templates.html, the template should have xy grid classes (grid-x , cell etc)
Specifically i downloaded ecommerce from https://get.foundation/downloads/templates-sites/ecommerce.html
What happens instead?
The downloaded file uses row and column classes. I am just a beginner and am guessing that that is the previous grid.
Possible Solution
Obviously the demo and download should use the same classes, the current classes.
It may be an idea to use the exact same file, so this does not happen. Or make the link to the source of the demo.
Your Environment

Foundation version(s) used:
Browser(s) name and version(s):
Device, Operating System and version:
Link to your project:

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one.
[x] The issue title and template are correctly filled.

Hi @rubydesign,
Thanks for letting us know.
The templates are at https://github.com/foundation/foundation-marketing/tree/master/src/downloads/templates-sites
Do you want to provide a PR to update them?

Hi @DanielRuf
that is encouraging. Since just fixing them would not be my solution i shall give that a miss though.
I would help on getting it right though. I mean the demo, ie https://get.foundation/templates-previews-sites-f6-xy-grid/ecommerce.html works. So linking to that somhow i could look into.

In general only the html classes and markup would have to be updated in general.
Probably we may have to update just a few links and folder names.
https://github.com/foundation/foundation-marketing/tree/develop/src/pages/templates-previews-sites-f6-xy-grid
What would you recommend?

I would make a little script, cut the yaml out of that file you linked, put your standard header on it , close the body/html tag at the end and serve it up.
That way you don't have to update the same files in 2 places

There is an easier way. We use our flat file generator panini which uses layouts and partials.
https://github.com/foundation/panini/blob/develop/readme.md
See https://github.com/foundation/foundation-marketing/blob/master/gulpfile.js#L67 and https://github.com/foundation/foundation-marketing/blob/master/src/pages/50x.html#L2
https://get.foundation/sites/docs/panini.html

Ok, you seem to be much more than half way there.
But the phrasing .. am i still being encouraged?
Do you want me to give it a shot, or is it 2 minutes for you?

As maintainer I am currently working on a few other projects like verdaccio and not doing much for Foundation today (one project per day) or in the next few days.
So it would be very cool if you want to and can provide a PR. It can be also a WIP PR and if there are any questions feel free to ask and we try to answer them as best as possible and guide you.

ok, i am installing now and will let you know.

Ok, sorry. I'm bailing
foundation -marketing does not install on my system (foundation-sites did)
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
There were wild cpp error codes. I got past where it needs python2, but npm installation errors are above my knowledge. As i said, i have never developed a js app.
Sorry, but you wlil have to spend the 5 minutes :-(

Do you use Windows or another OS @rubydesign?

Ok, if this is too much effort I'll plan it for next year (January or so).

Do you use Windows or another OS @rubydesign?
Ok, if this is too much effort I'll plan it for next year (January or so).
Thanks for taking the time to report this and trying to help us with the PR.
We really appreciate this.

I'm on Linux, fedora 31. Thats new too.
Thanks, and thanks for the very promising looking grid system and sass framework.
I've used bootstrap for years, all sites do tend to look very same.
I like the fully semantic aproach, so thanks


Flash of blank space in data scroller use case

(I'm the maintainer of CodeMirror, a code editor that supports large documents by only drawing the range around the current viewport.)
So the spec says

An Intersection Observer processing step should take place during the "Update the rendering" steps, after step 9, run the fullscreen rendering steps, and before step 10, run the animation frame callbacks, in the in the HTML Processing Model.

which means that drawing happens first, and observers are notified afterwards. I understand the reasons for this. However, that does mean that in the 'data scroller' scenario, there doesn't appear to be a way to prevent users from seeing the content flash into view as they scroll quickly (yank scrollbar or throw-scroll). This may not sound like a big deal, but in CodeMirror, users repeatedly and insistently complained about this until we fixed it (with a bunch of scary tricks some of which are starting to fall apart now that browsers delay scroll events more).
If you run the little demo below, which sets up a scrolling element with two colored elements inside of it, and colors the bottom red one blue as soon as the observer tells us it has become visible, you can easily see a flash of red when you scroll quickly.
Has a way to avoid this been discussed? Is it considered too problematic for performance, or is this whole use case not really in scope for this proposal?
<!doctype html><meta charset=utf8>

Set a larger rootMargin and you will be notified a little in advance before your visible range is actually on screen. That parameter was added specifically for the "infinite scroller" use case. Will that work with your requirements?

Throw scrolling can move in increments of 1000s of pixels. Keeping that wide a margin around the viewport is too expensive in my case.

IntersectionObserver is not really intended to drive per-frame layout.  As mpb@ pointed out, you can use root margin to give yourself some extra runway to respond to scroll events, but the fundamental problem remains.

There's no solution in any modern browser that will guarantee no flashes of blank space because scrolling happens on a different thread from JS. There are some scenarios under which browsers will scroll on the JS thread, but they are becoming increasingly rare as browsers further optimized their pages.
Our conclusion from that was that the only solution for infinite scrollers is to have some amount of runway. Definitely open to other ideas.
The fastest thing you could do today is have a scroll listener that does a double requestAnimationFrame and calls takeRecords. In that world you'd always miss exactly one frame.
I guess you can force a layout in your scroll listener and avoid missing a frame, but you'd still have the runway problem with threaded scrolling. How does codemirror handle threaded scrolling today?

There are some scenarios under which browsers will scroll on the JS thread, but they are becoming increasingly rare as browsers further optimized their pages.

So I guess the idea of providing client code with some hook to force scrolling of a given container to happen on the JS thread so that it can intercept it is considered undesirable because 'people will abuse it'. I can kind of understand that position, but it is unfortunate that it breaks this use case, forcing people to completely hijack scrolling—which leads to an even worse user experience.

but you'd still have the runway problem with threaded scrolling. How does codemirror handle threaded scrolling today?

It doesn't, that's why I'm looking for a better solution, which brought me here.
Feel free to close this if you decide that guaranteed JS-free scrolling is more important than data scrolling libs.

I don't think there's a universally correct answer for this, but I will say that based on experience, users are more bothered by scrolling-induced jank (i.e. dropped frames) than by painting stale content.
IntersectionObserver is intended more as an after-the-fact reporting mechanism, and one if its design goals is to avoid impacting rendering performance.  As you point out, there are other mechanisms you can use to intercept scroll events and avoid painting stale content, albeit with the side effect that you may drop frames.  Which approach you choose is really up to you.

@szager-chromium wrote:

As you point out, there are other mechanisms you can use to intercept scroll events and avoid painting stale content,

I was claiming out that there aren't such mechanisms, that I'm aware of. scroll events fire after drawing as well, and are often delayed for a long time on modern browsers. If you know a reliable technique for doing this, please point it out to me.


Adjusting Syntax Highlighting Requires Multiple Restarts VS2015

Steps to reproduce:

From Tools>Options>AsmDude>Syntax Highlighting make a change to one of the colors.
Click on OK to confirm the changes.
Restart VS2015 to effect the change.
Open an ASM project and note that the updated syntax highlighting has not taken effect.

Typical workaround involves disabling the plugin, restarting VS2015, enabling the plugin, and finally restarting VS2015, version 14.0.25421.03 Update 3.
Other than that I'm absolutely loving this plug-in. Thank you for taking the time to develop it!

Sorry, I see this is a duplicate of the open bug already.

Hi Profess,
Yes, I'm still trying to fix this annoying update bug. I've wasted way to much time that could have been spend on useful things such as code completion templates. In a few minutes I'll update the other thread with a possible solution.


Augeas lens from rodjek/puppet-haproxy?

Is it at all feasible to think about migrating from the current way of generating haproxy.cfg (using concat and lots of hashes and arrays) to using rodjek's Augeas lens from https://github.com/rodjek/puppet-haproxy?
The advantages would be the ones listed in https://github.com/rodjek/puppet-haproxy/blob/master/README.md.
Would this allow to keep the current interface where one can just supply arrays and hashes of options via default_options, global_options and options? Doesn't seem like it to me.
But what would be the best interface exposed by the haproxy class and the haproxy::listen and haproxy::balancermember types for making full use of the Augeas lens?

Hello! We are doing some house keeping and noticed that this issue has been open for a long time.
We're going to close it but please do raise another issue if the issue still persists. 😄


Save results of A/B test runs in a JSON file for future processing

This is a proof of concept for writing the results of an A/B run to a JSON file.
I also modified the ab.dart source file to be a main() program that can read the files back in and print out reports or do other processing. Thus far, the only things it can do is to write out the same reports that were originally printed during the test, but more processing could be added in the future, such as combining runs, generating some code for graphs, etc.
My naming conventions probably violate a number of dart/json style and naming guidelines, but suggestions are welcome!
The PR is marked WIP, because I know it will have to be revised quite a bit before it goes back, but I do specifically want some input at this point so ignore the "do not review" part of the label...

Some other naming considerations that I was looking for feedback on:

default name of output file (currently ABresults#.json) (I also clarified the # in the options description)
key names in JSON output (I didn't see any style guidelines on this and I just noticed that benchmarkScoreKeys uses camelCase)
Name of method ABTest.finalize() (finalize, in retrospect, is also the name of a memory management mechanism in Java...)

It would also be nice to save the frame times themselves so we can do more than just compare the summaries, but also graph the frame times against each other. That may be for a future PR...

This is pretty much in its final form - wondering if we want to adjust the defaults for which kind of output appears in the terminal when an A/B test is run and which is the default output for the summarize tool.
(Also, more naming feedback would be nice.)


[feature] pin action by release tag

A few internal Action need to be called with they fully fully-qualified name<EMAIL_ADDRESS>We need to ensure they use the same tag as the release tag for consistency. The pre-release should use:

dispatch event so that we can run it manually before creating a release tag
during release, as a final verification. Ideally this one should not fail otherwise we will need to further bump the version, otherwise

We also need to update the documentation in RELEASE.md

Adding https://github.com/slsa-framework/slsa-github-generator/issues/880#issuecomment-1288220141 here too.

@laurentsimon We still pin almost all of the actions called from the reusable workflows. For example:
https://github.com/slsa-framework/slsa-github-generator/blob/ce2408f54c685a307925330e1d9ceda98c853fd8/.github/workflows/generator_generic_slsa3.yml#L71
Do we want to do a builder checkout for these others besides secure-download-artifact too? or is the idea to pin all of these at a release per #1084?

Good catch. It was a mistake from me and I forgot to update all the refs. I've sent https://github.com/slsa-framework/slsa-github-generator/pull/1126 to fix it. PTAL

@mchmarny Which references are you referring to. We actually recommend referencing our reusable workflows by tag rather than digest. There is some info on that here: https://github.com/slsa-framework/slsa-github-generator#referencing-slsa-builders-and-generators

Will take a look, but building provenance of an image based on its tag undermines the integrity of that provenance as the image tag is not guaranteed to be constant and that reference is not cryptographically verifiable in any meaningful way.

In example under that link. Pinning by tag causes CodeQL errors being reported on the repo.

I'm not sure I follow. AFAIK CodeQL doesn't report errors on GitHub actions. Can you point me to where the errors are showing up?

It maybe scorecard, codeql, or even serif report from trivy, all push alert into the security panel in the repo. All of mine are resolved right now and I'm on mobile, but will try to reproduce tomorrow. Should be as simple as referencing it by canonical version and pushing new PR in a repo that's using the SLSA reusable workflow. Example here github.con/mchmarny/s3cme

Yes, scorecard does produce scanning results for pinned dependencies. Unfortunately we're at the mercy of how GitHub Actions works in this regard. If we pin our reusable workflow my hash, we can't easily verify that the hash used corresponds to a particular release or branch of the slsa-github-generator repository.


Invalid hook calls when calling a normal query with typescript + generated core used as a package

I'm using Yarn workspaces with a core package having the generated code and a mobile package that uses it.
When trying to make a call from an imported query I get an invalid hook call. Using any other hook in that component (i.e. useState) works fine.
My package.json of my mobile package imports:
"@workspace-library/core": "1.0.0",
I have an index.js file at core/src that has:
export * from "./generated/graphql";
export { apollo, useAuth, withAuth };

And I import the queries like this:
import {
  useArticlesQuery
} from "@workspace-library/core";

const SidebarArticles: FunctionComponent<{ props: any }> = (props: any) => {
  const [test, setTest] = useState("false");
  const data = useArticlesQuery({
    fetchPolicy: "no-cache",
    notifyOnNetworkStatusChange: true,
  });

   return (
    <View>
      <Text>Heyhey</Text>
    </View>
  );
};

I can see the useArticlesQuery in my generated/graphql.jsx, just in case:
export function useArticlesQuery(baseOptions) {     return ApolloReactHooks.useQuery(ArticlesDocument, baseOptions); }
Environment:

OS: Ubuntu
"@graphql-codegen/cli": "^1.13.1",
"@graphql-codegen/typescript": "^1.13.1",
"@graphql-codegen/typescript-operations": "^1.13.1",
"@graphql-codegen/typescript-react-apollo": "^1.13.1",
Yarn workspaces

Additional context
Error in question:
Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
* /home/dogchef/Development/workspace-library/packages/core/node_modules/react/cjs/react.development.js:1589:4 in resolveDispatcher
* /home/dogchef/Development/workspace-library/packages/core/node_modules/react/cjs/react.development.js:1597:29 in useContext
* http://<IP_ADDRESS>:19001/node_modules/expo/AppEntry.bundle?platform=android&dev=true&minify=false&hot=false:181621:41 in useBaseQuery
* /home/dogchef/Development/workspace-library/packages/core/node_modules/@apollo/react-hooks/lib/react-hooks.cjs.js:550:18 in useQuery
* http://<IP_ADDRESS>:19001/node_modules/expo/AppEntry.bundle?platform=android&dev=true&minify=false&hot=false:197883:37 in useArticlesQuery
* components/SidebarArticles.tsx:10:2 in SidebarArticles

I'm not sure it's related directly to codegen. Maybe it's something related to your setup.
Can you please share a reproduction in codesandbox/repo?

Closing. @DogChef feel free to comment here if it's still relevant.

I'm also facing this issue with a shared package which holds GraphQL types, here's a repository for reproducing it: https://github.com/Je12emy/monorepo-error
Here's a SO thread for more context

I just tried moving condegen into each react project, this seems to have fixed some errors, but still causes issues in my React Native app, it works fine with regular hooks such as useEffect


[Move] Update to c79b1f4d

Include new APIs to access ModuleCache and SyncModuleCache size, supporting #6039.

This will be superseded by #6072.


Use require_relative instead of unshift

Based on @markrickert 's comments - I noticed that this seems to perform faster (though I am not sure thats what the problem that mark was seeing...
time ./live_gem
./live_gem  8.24s user 1.00s system 99% cpu 9.323 total
time ./tweaked_gem
./tweaked_gem  0.68s user 0.40s system 92% cpu 1.164 total

both of the above scripts are simply calling potion -v 10 times in a row, the tweaked version has what is changed here in this PR and repeatedly is much faster every time I time them.

@markrickert so the only way I can think of to test this is to modify your local gem cache of the bin/potion file - then you can see if it speeds up at all - I think there might be other stuff going on here, but this definitely speeds up when I test it, but I dont see the delay that you see, so wondering if this accomplishes the same changes for you.
also in your local master copy of redpotion, time ./bin/redpotion -v is that also super delayed?

:clap:

@markrickert did this speed it up for you?  I wasnt able to locate anything else (and RMQ uses the unshift...so I really have been at a loss as to what is going on here - sorry :frowning: )

The speedup was negligible, but it DID speed it up a tad. I can see how unshifting would take a long time simply because I have a massive amount of gems installed :)


Disabling ContextInitializer in Android if needed. Add an option to initialize by passing Android Context instance

          @mirzemehdi what do you think about making ContextInitializer public? I think some app have to use manual startup initialization logic (my app included). Maybe having an option to do so would be good?

Originally posted by @linhvnguyen9 in https://github.com/mirzemehdi/KMPNotifier/issues/53#issuecomment-2266379524

This is implemented in 1.3.0 version.
By default using androidx-startup Context instance is obtained automatically in android. But if you disabled androidx-startup, you can pass android Context instance using initialize method as below:

class MyApplication : Application() {
   override fun onCreate() {
       super.onCreate()
       NotifierManager.initialize(
           context = this
           configuration = NotificationPlatformConfiguration.Android(
               notificationIconResId = R.drawable.ic_launcher_foreground,
               showPushNotification = true,
           )
       )
   }
}


images in drafts are deleted when navigating to a link in preview

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
If inserting an image when drafting a post, the image is deleted if you move to preview mode and then click a link to another page.
Screenshots
No response
Steps To Reproduce

click "post", then choose discussion post.
Go to text box "write mode and insert a photo
enter the url to an external page in the body of the draft text.
Switch to "preview", then click the link to the external page
The code for the inserted image has been deleted when you return to the "write" menu.

Expected behavior
I expected the image to remain in the draft while checking external links before posting.
Logs
No response
Device information
OS Ubuntu Linux
Browser Firefox
Additional context
No response

I see the problem:
https://github.com/user-attachments/assets/bacf9000-3f3b-4bf2-9077-fbbf67f0416d
It's unrelated to preview. It happens because we don't save the draft after upload, only when something was typed.
Fix would be to trigger the event that triggers saving the draft.

No big deal. Thanks for letting me know.
Sent from Proton Mail Android
-------- Original Message --------
On 10/28/24 12:32 PM, ekzyis  wrote:

I see the problem:
https://github.com/user-attachments/assets/bacf9000-3f3b-4bf2-9077-fbbf67f0416d
It's unrelated to preview. It happens because we don't save the draft after upload, only when something was typed.
Fix would be to trigger the event that triggers saving the draft.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[Bug] escaped criminals embed always present

Describe the bug
The escaped criminals message should be empty if there are no escaped criminals, but currently the embed is always there

superseded by #928


UnreceivedPackets grpc query handler only works for unordered channels

Summary of Bug
UnreceivedPackets builds the response only by looking for a corresponding packet receipt for every sequence number included in the query (see here). This only works for unordered channels, as ordered channels use nextSequenceRecv rather than packet receipts. Therefore, on ordered channels, the query response will include all sequence numbers that were present in the query, as no receipt will be found for any of them.
Version
v3.0.0
Steps to Reproduce
I used the interchain accounts demo repo to confirm the problem, as interchain accounts use ordered channels. After installation,
In terminal 1,
$ make init
$ make start-rly

In terminal 2,
export DEMOWALLET_1=$(icad keys show demowallet1 -a --keyring-backend test --home ./data/test-1) && echo $DEMOWALLET_1;
export DEMOWALLET_2=$(icad keys show demowallet2 -a --keyring-backend test --home ./data/test-2) && echo $DEMOWALLET_2;

# This will have hermes relay the channel handshake in terminal 1
icad tx intertx register --from $DEMOWALLET_1 --connection-id connection-0 --chain-id test-1 --home ./data/test-1 --node tcp://localhost:16657 --keyring-backend test -y

# Once the channel is opened on both chains...
export ICA_ADDR=$(icad query intertx interchainaccounts connection-0 $DEMOWALLET_1 --home ./data/test-1 --node tcp://localhost:16657 -o json | jq -r '.interchain_account_address') && echo $ICA_ADDR

At this point, hit ^C in terminal 1 to stop hermes from relaying packets. We will create a sendPacket on test-1, recv it on test-2, and then query unreceived packets on test-2 to confirm that the chain claims that our packet has not been received, even though it has.
In terminal 2, send the packet.
icad tx intertx submit \
'{
    "@type":"/cosmos.bank.v1beta1.MsgSend",
    "from_address":"cosmos15ccshhmp0gsx29qpqq6g4zmltnnvgmyu9ueuadh9y2nc5zj0szls5gtddz",
    "to_address":"cosmos10h9stc5v6ntgeygf5xf945njqq5h32r53uquvw",
    "amount": [
        {
            "denom": "stake",
            "amount": "1000"
        }
    ]
}' --connection-id connection-0 --from $DEMOWALLET_1 --chain-id test-1 --home ./data/test-1 --node tcp://localhost:16657 --keyring-backend test -y

In terminal 1,
# Confirm that we see 1 unreceived packet
hermes -c network/hermes/config.toml query packet unreceived-packets test-2 icahost channel-0

# Recv the packet on test-2 (make sure you run this before the packet times out)
hermes -c network/hermes/config.toml tx raw packet-recv test-2 test-1 icacontroller-cosmos1m9l358xunhhwds0568za49mzhvuxx9uxre5tud channel-0

# Confirm that we *still* see 1 unreceived packet
hermes -c network/hermes/config.toml query packet unreceived-packets test-2 icahost channel-0

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Thanks for opening this issue, @plafer! This is a very good catch!

Some pseudocode to discuss a possible way to fix this issue.
After this line replace this block with something like this:
channel, found := q.GetChannel(ctx, req.PortId, req.ChannelId)
if !found {
	return nil, status.Error(
		codes.NotFound,
		sdkerrors.Wrapf(types.ErrChannelNotFound, "port-id: %s, channel-id %s", req.PortId, req.ChannelId).Error(),
	)
}

unreceivedSequences := []uint64{}

switch channel.Ordering {
case types.UNORDERED:
	for i, seq := range req.PacketCommitmentSequences {
		if seq == 0 {
			return nil, status.Errorf(codes.InvalidArgument, "packet sequence %d cannot be 0", i)
		}

		// if packet receipt exists on the receiving chain, then packet has already been received
		if _, found := q.GetPacketReceipt(ctx, req.PortId, req.ChannelId, seq); !found {
			unreceivedSequences = append(unreceivedSequences, seq)
		}
	}
case types.ORDERED:
	// check if the packet is being received in order
	nextSequenceRecv, found = q.GetNextSequenceRecv(ctx, req.PortId, req.ChannelId)
	if !found {
		return nil, status.Errorf(...)
	}

	for _, seq := range req.PacketCommitmentSequences {
		if seq == 0 {
			return nil, status.Errorf(codes.InvalidArgument, "packet sequence %d cannot be 0", i)
		}

		if seq >= nextSequenceRecv {
			unreceivedSequences = append(unreceivedSequences, seq)
		}
	}
default:
	return nil, status.Errorf(...)
}

Hi @plafer, what behaviour would be desirable?
The functionality of UnreceivedPackets could be different for ordereded channels. For example, a list of sequence might be provided: 2, 7, 9, 10. If the latest received packet is 5, should we returned 6, 7, 8, 9, 10 - or 7, 9, 10. I'm wondering if we should create a separate gRPC entirely?
Would love to hear your input. In what context are you using this function and how could we best adjust the functionality to fit your needs?

I don't believe a separate gRPC endpoint is necessary. From the perspective of relayers (which I assume are the primary users of this endpoint), using a different gRPC endpoint depending on the channel ordering adds complexity, which I don't believe it justified. I assume that on ordered channels, queries similar to 2, 7, 9, 10 are rare, as there's no point in sending a bunch of packets all at once since most will be dropped unless the user is "lucky" that the packets got relayed in the proper order. In other words, my assumption is that most queries on ordered channels have a single sequence number, or maybe a few packets (e.g. 2, 3, 4).

For example, a list of sequence might be provided: 2, 7, 9, 10. If the latest received packet is 5, should we returned 6, 7, 8, 9, 10 - or 7, 9, 10.

Hence, I believe 7, 9, 10 should be returned to preserve the semantics of the unordered channel case (i.e. as implemented @crodriguezvega's pseudocode).


fix pl.py to handle more corner cases

add clock parsing for zynq ultrascale devices

fix parsing when PL clock enable is not set explicitly

skip parsing the {DEFAULT} configurations

Should fix following issues:
https://github.com/Xilinx/PYNQ-Dev/issues/97
https://github.com/Xilinx/PYNQ/issues/490

I'm concerned that this won't fix all future instances of #490 because the value can be {DEFAULT} but also {USER}. I think you should ignore all VALUE_SRC directives instead but I have no idea if that is sensible or not.


Exit or error early

Fix https://github.com/freckle/stack-action/issues/57 - attempt 2

Should we add a case to the CI suite that exposes the issue, so we can see that this PR doesn't re-introduce it?
I'm thinking we have an example Job with a test or compilation failure, then a dependent Job that asserts the Job that ran that has failed.

I think it's enough to have a step with a build failure.

Set continue-on-error for the stack-action step (link).

In the next step, check that the previous step failed (link).
if: steps.stack-action-step.outcome != 'failure'
run: exit 1

Seems to work.


New Integration CloudFront

Description
Added support for CloudFront
Also added to support for add metadata.
Fixes #
How Has This Been Tested?
Locally
Checklist:

[ ] I have updated the versions in the SemanticVersion in template.yaml
[X] I have updated the CHANGELOG.md
[ ] I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
[ ] This change does not affect any particular component (e.g. it's CI or docs change)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: juan-coralogix:x: RafalSumislawskiYou have signed the CLA already but the status is still pending? Let us recheck it.


fix(jobCard): bookmark icon is overlaping job title

bookmark icon is overlapping job title

@hscgavin it already has withBookmark css class, but it was used only when bookmark is clicked (isSaved) .. but initially (unsaved/unchecked yet) will be overlapping


(PlatformException(ERROR, java.lang.Long cannot be cast to java.lang.Integer, , null)) #82

ConnectycubeFlutterCallKit.showCallNotification
when I launch this i get this error
E/flutter (25671): [ERROR:flutter/lib/ui/ui_dart_state.cc(186)] Unhandled Exception: PlatformException(ERROR, java.lang.Long cannot be cast to java.lang.Integer, , null)
E/flutter (25671): #0 StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:581
E/flutter (25671): #1 MethodChannel._invokeMethod
package:flutter/…/services/platform_channel.dart:158
E/flutter (25671):
i am trying to run this code with fake data after firebase background message invoked
I don't understand how to to do that - the code i am using is this

ConnectycubeFlutterCallKit.showCallNotification(
      sessionId: "23113123",
      callType: 0,
      callerId:<PHONE_NUMBER>124,
      callerName: "Test Me",
      opponentsIds: {2, 3, 4});

Sorry to bother - this error occur if the callerid is very large - tried smaller id and it fixed the problem


Get number of samples from train.rec file

Hi,
Is there any build in method to get the number of samples in train.rec file?

rec files doesn't have an index. So it's not possible without looping throught the entire file

In this case, the number of samples could be got from corresponding *.lst file


Enhances csv output mode and Exclude nested properties, Closes #4150

This PR enhances csv output mode and Exclude nested properties.
Closes #4150

Great work! We'll try to review it ASAP!

Merged manually, thanks you! 👏


TextEntity zIndex always 0

Can't change set ZIndex of TextEntity in VisEditor. It is always 0.

What version of visEditor are you using? on 0.2.6 snapshot i have no problem modifying it.. (although if it seem's to dont change much in the scene)

This was fixed in https://github.com/kotcrab/VisEditor/commit/94eb1b64b6955e0dd4b7dedc887330d5297544db, please try 0.2.6 snapshot build..
@omomthings it changes z order, to notice change you need 2 entities on same layer and they must be overlapping

Hi, thanks for answer, can anybody explain what I see in this directory 0.2.6 snapshot build? Is this all VisEditor 2.6.0 and I just must download last file?

Yes those are the different snapshots, day by day.. I use the version of 8/11 and its enough stable. Just download it and thats all. :-)

Exactly as @omomthings said, those are built after every commit, you just need the latest one. Sorry for not explaining it.

All clear, thanks.


Update spring-context, spring-core to 5.3.9

Updates

org.springframework:spring-context
org.springframework:spring-core

from 5.3.8 to 5.3.9.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.springframework" } ]

labels: library-update, semver-patch

Superseded by #1033.


[Planning] ADC speed when It is on the lane bend a lot.

Is your feature request related to a problem? Please describe.
ADC has too low speed when it turns.
Describe the solution you'd like
Decrease kappa weight in planning_config.pb.txt when it has low speed.
make a variable and make it changable along the ADC velocity.
the variable will be 1.0 at high speed of ADC and it will be between 0.5~1.0 when ADC has low speed.
multiple the variable and kappa weight.
and then, kappa weight will be low a little bit when ADC has low speed.
Describe alternatives you've considered
Additional context

You can change kappa weight in speed optimizer. what's more, you can also increase speed limit when turning (max_centric_acceleration_limit in planning_config.pb.txt)


The Cydia icon does not exist after jailbreak, but you can open cydia via U0.

Describe the bug
The Cydia icon does not exist after jailbreak, but you can open cydia via U0.
Device (please complete the following information):

iOS Version: 12.4
iOS Device: ipad air 2
unc0ver Version: 3.5.2

Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[x] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[x] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

I'm having the same problem.

iOS Version: 12.4
iOS Device: ipad air 2
unc0ver Version: 3.5.2

did you both try "refresh icon cache" in unc0ver settings?

Yes, still the same.

Same for me - also on an iPad Air 2, 12.4.
Completely fresh install - not an upgrade - no restore performed.
Also icons for things installed via Cydia (opened from U0) don't show up either.
Tried both rebooting and 'refresh icon cache'

My friend gave me some links for sources that I can use, when O added them to my sources the upgrade icon appears so I clicked on it and the cydia instantly closed and I couldn’t open it again, every time I tried to open it it shuts down before the screen appears so I tried to delete cydia and redo jailbreak but unfortunately the app doesn’t exist but I think that the app in just hidden then because when I tried to install app there was an space between apps, anyway I tried to fix this but I accidentally destroy everything because I tried to uninstall all apps I used to jailbreak the iPhone and delete all profiles from general setting and reinstall it but the jailbreak didn’t work, so last thing I did is reset all setting and reinstall all jailbreak apps and jailbreak the iPhone but still didn’t work and always the iPhone restart after reaching 8/31
Is there any solution for this or I have to do software for my iPhone !

I redid the jailbreak and selected to add OpenSSH.
Not sure if this is what changed anything, but the icons then appeared after a reboot/rejailbreak

It didn’t work with me

I redid the jailbreak and selected to add OpenSSH.
Not sure if this is what changed anything, but the icons then appeared after a reboot/rejailbreak

I'm having the same problem.

iOS Version: 12.4
iOS Device: ipad air 2
unc0ver Version: 3.5.6

I reinstalled unc0ver v3.5.5  and it works.


[HOLD] add a banner to globus deposits on item show page

Why was this change made? 🤔
Fixes #2915 - add a banner to the top of the item show/detail page for globus deposits in a draft state directing users to the help page and showing them the folder name we created on globus.
This is in the same spot that the banner shows for users who still need to complete their globus account setup (i.e. that banner goes away when they complete their setup and is replaced by this one).
Account setup complete (new banner)

Account setup needed (existing banner)

HOLD for language updates by Amy
How was this change tested? 🤨
Localhost

@amyehodge  this adds the banner for draft globus deposits that shows when users have completed their account setup ... i just made up some language for now and linked to the help page ... we can tweak as needed

@peetucket I'd like to tweak this a bit to read:
"Upload your files to the Globus folder "auser/work9/version1" and then click the Edit button on this page to complete your deposit. Refer to our help page[linked] if you have questions, or contact us at the Help link above."

Do we want to say "click the Deposit button..." instead of "click the Edit button..." ?

If this message is on the work view/show page, the button actually says "Edit or Deposit" at this point. Perhaps it would be best to say that for clarity, even if it is longer.


Support Basic Auth credentials in Web3signer URL

Description
currently using Web3signer with TLS + http basic auth. This work fine with Lighthouse and Prysm when using an URL format of https://user:pass@web3signer_url but in TEKU it seems that the HTTP lib used does not support passing the basic auth credentials.
2023-12-07 09:10:36.137 ERROR - External signer is currently not reachable at<EMAIL_ADDRESS>
When logged into the pod I can query it fine.
Is there any way to support this easily in TEKU ? Or am I missing something ? Right now I'm passing this as en ENV var, I could try via config or args but not sure it would change anything.
Steps to Reproduce (Bug)
Set the env vars TEKU_VALIDATORS_EXTERNAL_SIGNER_URL.
Expected behavior: [What you expect to happen]
Connection is successful
Actual behavior:
Unable to connect
Frequency:
Constant
Versions (Add all that apply)

Software version: 23.08
Java version: jdk17
OS Name & Version: Ubuntu 22.04 but running in Kubernetes via Docker image
Docker Version: No docker but containerd
Cloud VM, type, size: Bare metal

Hi, thanks for raising an issue. I looked at the code and it looks like we don't support basic auth. We will look into adding that functionality.

Could you point to where it is in the code ?
On Thu, Dec 7, 2023, 13:05 Stefan Bratanov @.***> wrote:

Hi, thanks for raising an issue. I looked at the code and it looks like we
don't support basic auth. We will look into adding that functionality.
—
Reply to this email directly, view it on GitHub
https://github.com/Consensys/teku/issues/7796#issuecomment-1845224215,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJXRKNVCT65WCCSXZYARNTYIGWHFAVCNFSM6AAAAABAKY6JKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGIZDIMRRGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Could you point to where it is in the code ?

Yeah, it's here -> https://github.com/Consensys/teku/blob/master/validator/client/src/main/java/tech/pegasys/teku/validator/client/loader/HttpClientExternalSignerFactory.java


Visibility checkboxes in Page/Settings use the wrong markup

I think these are supposed to use checkboxSet or similar?

No, they are just basic checkboxes. I think this is correct (just tested, it seems ok).
It is responsive... the buttons drop onto one column on narrow screens.


Multiple instances affect eachother in a breaking way

I have two Plotly instances, which plot data after a button press (e.g. click button one, data for the first instance is plotted).

plot 1 is a scatter plot
plot 2 is a group violin plot

If I click the button for plot one, everything works fine. If I then click the button for plot two, however, the group violin mode of layout is updated in the internalLayout data of of plot one! Note, that each of these instances have separate data and layouts!
e.g.
<VuePlolty v-bind="propsOne" />
<VuePlolty v-bind="propsTwo" />

So how to get around this?

Have you ever found a solution to this?
I am facing a kind of similar issue. I used a same component containing a vue plotly multipl times and it all breaks on plot width.


Bar Chart - Width adjustment issue with 2 XAxisLabels

Bug type
Component
Component name
Bar Chart
What happened?
I have pretty less number of items in x-axis, when I tried to run, the labels are too far.  When I tried to adjust the width to 50%
Currently it leads to overall SVG resize of whole chart
,
Expected behavior
Expected output is to adjust the space in-between. if there is not scope to adjust the width than this needs to resize the chart overall.
Reproduction link
https://try.mudblazor.com/snippet/cYGmubbinlAMTFCw
Reproduction steps

Run the Link provided https://try.mudblazor.com/snippet/cYGmubbinlAMTFCw
You will see the chart becomes small in size even though there is huge space in between the x-axis which is empty

Relevant log output
No response
Version (bug)
6.0.4
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This answers my question #3751. Thanks


Cwlparser

This is a pull request that adds structural import for a CWL workflow to Apache Taverna.
The current code parses the cwl file to extract inputs, outputs and steps of a workflow, and then converts them to a Taverna workflow containing ports, processors and data links.
In the tests, we try to compare expected objects (like InputWorkflowPort) with the newly created workflow from the cwl file. We do this by using the default equality of Taverna components (Implemented inside AbstractNamed class) but this way we try to compare the name and the parent of two objects.
Currently, we set the parent of the expected object to be the same as the parent of the created object, but this will modify the parent as well to point to the same object in the end and thus we'll have two equal objects all the time.
What we can do is set objects' parents to null before comparing and in that way we will compare the names and not the parents.
Is there another approach or is the current one correct?

Thank you so much for the comments.


FALCON-2028 HDFS extension: Validate and append/remove the scheme://authority for the paths

+1

+1


examples: Add Envoy admin listener

Add an example CiliumEnvoyConfig CRD for gaining access to Envoy admin on localhost port 9901. Without this Envoy admin  listener is only reachable via a unix domain socket within the Cilium agent pod.

Not covered in CI. Merging.


first generated psf is not centered

The very first generated psf is not centered and it's and the airy disk in not visible.
It's centered instead from the second execution.
It'd be nice to align this

Can't reproduce the error. What version of the plugin are you using and what's your napari version? Thanks

napari 0.4.14
napari-psf-simulator 0.1.4

Ok, it looks like that the viewer.dims class has been modified recently. I'm having a similar problem using viewer.dims.point(), which gives inconsistent results with different napari versions. I'll search for the recommended usage. Please write here if you have any ideas.

Hi @micropolimi, I added this line to reset the view. The issue is solved for napari-psf-simulator >=0.1.5
Due to a previous issue in napari,  the new change raises an error if napari <0.4.13 is installed.
Considering that you many users are updating napari regularly, this point can be considered a minor issue. I am closing the issue


Preserve ItemSpec after GetTargetFrameworks call

A much more targeted change for the same issue #2650 solves. Thanks @cdmihai
Preserve the ItemSpec value after we get target frameworks from project
references.
Closes #2649

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

@dotnet-bot test Ubuntu16.04 Build for CoreCLR please


Bridges in a Graph

Closes #89

C++ program for printing the bridges in a graph using DFS.
Checklist
<Put an x between square brackets wherever appropriate without any spaces like [x]>

[x] I've followed the Contributing guidelines provided in the repository.
[x] I've made the changes which were demanded in the linked issue.
[x] My code gave a clean output on debugging. (NO warnings/errors)

Again you have committed an extra binary file. 😅

@ankiiitraj I would request you to add a git ignore for files without an extension if it's possible. What do you think?

creating an issue for the same @Vishal19111999


Add ability to specify drive and drive format to mender-qemu.

This will be important to do testing, since testing will use a
revertible qcow2 image.

We decided not to use a revertible qcow2 image after all, since not doing so is closer to how it will be on hardware. It's here if we need it later.


Missing constants for relative axes

I added some of the missing event codes from input-event-codes.h.  Their
omission causes the library to panic with some input devices.

This is a symptom of a deeper issue: the library should not be panicing on unrecognized codes, because future kernel updates will likely continue to add new ones, causing applications using this library as it stands to break.


Filter line items with 0 units when creating statements

Since session interval line items have 0 unit counts when the session unit cost is 0: We work out the unit count as total_session_length_cost / session_unit_cost, but use 0 if the total session length cost (and thus also the unit cost) is zero. These items are more confusing than they are useful.

Ready for review.

:+1:


Not refreshing

The plugin allows me to update the temperature directly under accessories inside homebridge or with the HomeKit thermostat but after a while it stops displaying the correct cooling temperature.  Even after changing it, it goes back to an older value.

When the temperature reverts have you checked the infinitude dashboard to see what it displays as the current cooling temperature? You may need to narrow down if this issue is occurring between HomeKit and Infinitude or Infinitude and the thermostat.

Closed due to inactivity


add pdbpp

"This module is an extension of the pdb module of the standard library. It is meant to be fully compatible with its predecessor, yet it introduces a number of new features to make your debugging experience as nice as possible."
The "sticky" feature is quite useful for example
https://pypi.org/project/pdbpp/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hmm maybe this is good but I've never tried it and strictly speaking it's not a dev dependency. The other dev dependencies are needed for the tests to run, or are for pre-commit stuff

alright, I'll close it then. It's still worth a look :)