renew confd.io (pending deletion)

@kelseyhightower, you might want to renew it (?)
$ whois confd.io

Domain : confd.io
Status : pendingDelete
Expiry : 2015-10-26
Delete : 2016-01-25 00:30
Domain reserved

whois via nic.io:
The domain is unavailable for use
Domain Status:	pendingDelete / Final Phase
Expiry :	2015-10-26

Reserved by Back-Order :	No

Unless it is renewed it will be deleted in a batch run started at 2016-01-25 00:30 (UTC)
Purchase a Back-Order ... (What is a back-order?)

Friendly bump :)

@josegonzalez @anapsix Both issues regarding the domain have been fixed. The domain name registration was renewed just in time so it was not delete. I'm now delegating DNS to Google Compute Engine so everything should be working now. Thanks for the ping and friendly reminders.


Add console as a consumed service

Could also add opening the Atom IDE Console automatically to this if desired but this will at least get more detailed error messages into the editor.
Closes #68

Thanks!


update: bump plugin rc versions

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b170a1b6a653acd87cf4dd9f9bdfc10815f52ecb

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add mhchem KaTeX extension to math.html

Hello!
I would like to suggest adding the simple addition of the mhchem extension in the $\text{KaTeX}$ implementtion. Personally, I find the extension useful for writing units quickly (through the \pu{example unit} command) and chemical formulae (like $\ce{2H2 + O2 -> 2H2O}$) in my notes and so I thought it could be useful for others to have the functionality as well.

Sure thanks! I would merge it in the next release.


🚢Ship map link removal

Docs Build status updates of commit 6794865:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/index.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Hermes ignores IBC events emitted by BeginBlock/EndBlock

Crate

relayer::event
Summary of Bug

get_all_events doesn't return IBC events that are raised in BeginBlock or EndBlock, only transactions.  This prevents ChannelOpenInit from within EndBlock, which is what Agoric needs for dynamic (smart-contract driven) IBC.
Version

v0.10.0
Steps to Reproduce

Modify your chain to do the following in EndBlock:

	ctx.EventManager().EmitEvents(sdk.Events{
		sdk.NewEvent(
			sdk.EventTypeMessage,
			sdk.NewAttribute(sdk.AttributeKeyModule, channeltypes.AttributeValueCategory),
		),
	})

Run hermes listen mychain
Note that the message.module = 'ibc_channel' event is not detected by Hermes

Acceptance Criteria

hermes listen mychain reports events emitted in EndBlock.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

This seems either a regression of https://github.com/informalsystems/ibc-rs/pull/1409 (or we need to extend that work to cover additional types of packets beyond SendPacket).

https://github.com/agoric-labs/cosmos-sdk/tree/mfig-endblock-ibc-event has a hack to raise message.module = 'ibc_channel' in EndBlock.
To reproduce this problem, you can do:
git clone https://github.com/agoric-labs/cosmos-sdk -b mfig-endblock-ibc-event
cd cosmos-sdk
make build
./build/simd --help

Simd is then a Cosmos SDK chain that will produce those events on every block.

Just to double check, does hermes config file include:
[mode.channels]
enabled = true

Just to double check, does hermes config file include:

Yes, I was able to reproduce both with and without the config you mentioned.

Hi @michaelfig, can you please confirm if this issue is fixed by #1801?

can you please confirm if this issue is fixed by #1801?

Hi @hu55a1n1 ,
After further testing, I find that in the code as of #1801, Hermes doesn't detect newly-created EndBlock events, only ones that happened before Hermes started. So, I have to restart Hermes to get it to process the newly-sent events.
Is there any chance it's related to this issue, or should I file a separate one?

Oh, probably my mistake!  I had been testing #1840, and didn't look too closely at it.  Turns out #1801 was not included in it.
I'm now testing them both together.

I'm now testing them both together.

And I've verified that this current issue is fixed and should remain closed, but I see a potentially-related problem in #1844.


How to add a vue file into GridItem?

Now, I have a demand, my GridItem content is a vue file, not a number i.
How should I build my data  testLayout?
How should I modify my template?

Check this sample, its using a component as content for the GridItem: https://github.com/jbaysolutions/vue-grid-layout-sample-v1


add debugger class and connect to debugger websocket

JerryScript-DCO-1.0-Signed-off-by: Geoff Gustafson<EMAIL_ADDRESS>

Got past the promise stuff and got it simply connected, but I'll continue working on this patch

@grgustaf jfyi, I posted a couple more comments on this one.


Solution Selection Logic doesn't support tolerance

SSL does include a tolerance which should simplify the logic and how many solutions are needed, but it doesn't use the tolerance for detecting conflicts and, more importantly, it isn't known how to support the tolerance when merging two rules which technically have a conflict but its outside the threshold.

not applicable to v2.0.0


Wireguard isn't running in Container: systemctl: command not found

Describe the bug
Hey, I used the wireguard docker-compose.yaml from the README to start a pivpn container. The container started and I could connect to it's shell and add clients with pivpn add. But when I tried to connect with the android Wireguard app I didn't get internet access.
So I tried to debug with pivpn -d and it stated that wirequard isn't running at all:
=============================================
::::            Self check               ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
/opt/pivpn/self_check.sh: line 289: systemctl: command not found
:: [ERR] WireGuard is not running, try to start now? [Y/n] y
/opt/pivpn/self_check.sh: line 298: systemctl: command not found
Done
/opt/pivpn/self_check.sh: line 303: systemctl: command not found
:: [ERR] WireGuard is not enabled, try to enable now? [Y/n] y
/opt/pivpn/self_check.sh: line 313: systemctl: command not found
Done
:: [ERR] WireGuard is not listening, try to restart now? [Y/n] y
/opt/pivpn/self_check.sh: line 334: systemctl: command not found
Done
[INFO] Run pivpn -d again to see if we detect issues
=============================================

Did I miss something or is this a bug?

Hey, sorry I think that could be a problem on my side because the vserver I'm using doesn't support wireguard. So maybe thats the reason for this error message.


Wipe wallet in advanced settings

https://www.figma.com/file/vYQD6uZtkPgtmgJ3zfauq0/Zashi-UI?type=design&node-id=3524-32583&mode=design&t=L69gPR22NMvtqLNn-0

Language updated in Figma. Let me know if we need anything else.


Implement safe deletion strategy

Description
Changes proposed in this pull request:

propose new safe strategy version
update documentaion

Related issue(s)

https://github.com/kyma-project/keda-manager/issues/89

/retest

/test pull-keda-module-build

/test all

/test all

/test all


[BUG]  Training an agent on RoboHive env using torchRL

Describe the bug
I wasn't sure whether to open this issue on torchRL, agenthive, or the robohive repo. Apologies if its in the wrong place.
I'm trying to train a PPO agent on the Franka Kitchen environments, and the agent is not able to converge on most of the tasks. I have tried feeding in the full state of the environment as input (body_pos,body_quat, site_pos, site_quat, qpos, qvel, ee_pose). That failed to converge, and led to the model predicting some invalid actions and causing the robot arm to point straight up in the air, and the following warning:
Simulation couldn't be stepped as intended. Issuing a reset
WARNING:absl:Nan, Inf or huge value in CTRL at ACTUATOR 0. The simulation is unstable. Time = 0.0000.

When I used the site_errs as input, it converged on a few tasks, but still failed on most.
Is there a canonical way to train an agent using torchRL on a RoboHive env?
To Reproduce
Attached training script for reference. (slightly modified from the ppo tutorial )
train_ppo_robohive_upload.txt
Expected behavior
Training converges
System info
Describe the characteristic of your environment:

Describe how the library was installed - pip
Python version - v3.8
Versions of any other relevant libraries - robohive v0.6

import torchrl, numpy, sys
print(torchrl.__version__, numpy.__version__, sys.version, sys.platform)

0.3.0 1.24.4 3.8.18 (default, Nov 29 2023, 16:26:57)
[GCC 13.2.1 20230801] linux

Checklist

[X] I have checked that there is no similar issue in the repo (required)
[X] I have read the documentation (required)
[X] I have provided a minimal working example to reproduce the bug (required)

This is the right place!
Can you share a little more about your setup, how you build the env (are you using transforms?) the PPO loss and how you're using PPO and GAE + storing data?
Thanks!
cc @vikashplus

You can also take pass at some of our pre-trained agents to compare results

Can you share a little more about your setup, how you build the env (are you using transforms?) the PPO loss and how you're using PPO and GAE + storing data?

Creating the env:
def create_env(env_name, device, from_pixels=False, pixels_only=True):
    base_env = RoboHiveEnv(
        env_name,
        device=device,
        from_pixels=from_pixels,
        pixels_only=pixels_only,
    )
    env = TransformedEnv(
        base_env,
        Compose(
            FlattenObservation(
                first_dim=-2,
                last_dim=-1,
                in_keys=[
                    ("state", "body_pos"),
                    ("state", "body_quat"),
                    ("state", "site_pos"),
                    ("state", "site_quat"),
                ],
            ),
            CatTensors(
                in_keys=[
                    ("state", "body_pos"),
                    ("state", "body_quat"),
                    ("state", "site_pos"),
                    ("state", "site_quat"),
                    ("state", "qpos"),
                    ("state", "qvel"),
                    "ee_pose",
                ],
                out_key="observation",
            ),
            # normalize observations
            ObservationNorm(in_keys=["observation"]),
            DoubleToFloat(),
            StepCounter(),
        ),
    )
    return env

PPO Loss, GAE and storing data are all identical to the tutorial, I have not made any changes. The full training script is attached in the previous comment, that should help in reproducing the result.

You can also take pass at some of our pre-trained agents to compare results

I did check out the agenthive release, but I had trouble getting it working. It appears to be mjrl, not torchrl, and since it depends on the old mujoco bindings, setup was painful. I'll take another crack at it, but I would very much appreciate getting this set up with torchrl!

This seems to be a case of the right input not being passed. I tried training again with just ee_pose and obj_goal as the inputs to the policy. This performed marginally better, with more tasks converging. Many others failed to converge and only one "broke" the simulation.
I also checked a bit more on why the simulation breaks and the robot arm points into the air. During training, sometimes,  the loss_objective term of the PPO loss goes to NaN and after the loss update, the entire network goes to NaN, which then breaks the simulation. Not sure why this is happening, will try some more experiments and report the results.

@sriramsk1999 - any more updates on this. Here are a few things to check

Check that observations from following match with the env that you register. Be careful of the seeding ee.unwrapped.seed(<seed>) between the two envs.

In [1]: import robohive
In [2]: import gymnasium as gym
In [3]: gym.make('FK1_MicroOpenFixed-v4')
In [4]: ee = gym.make('FK1_MicroOpenFixed-v4')
In [5]: obs = ee.unwrapped.get_obs()
In [6]: reset_obs = ee.unwrapped.reset()

Check that the exploration of the initial policy is sensible. (small movements around the mean position)
Check that the policy after 1st PPO iteration is doing sensible things (small movements around the mean position)

cc @vmoens

The reset_obs values match. Before seeding, the gym and torchrl observations do not match. After seeding both the envs, these match as well.
For the policy itself - Last time when I tried training with MicroOpenRandom-v4, the loss went to nan and broke the simulation. This time, the loss did not go to nan but the network didn't converge :sweat_smile:
I also tried with MicroOpenFixed-v4. Here its better than MicroOpenRandom-v4, but still doesn't fully converge, even though its a fixed environment.

I think I am not passing the right inputs to the model. @vmoens what keys of the tensordict should I use to get the vector in ee.unwrapped.get_obs()?


Add support for local file

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add support for localfile when storageUri like file://,

We're not actively supporting this Alpha branch. Do you mind detailing why you need this?

We're not actively supporting this Alpha branch. Do you mind detailing why you need this?

The change can apply to master branch! It can be used for supporting localfile like "file://path".

We're not actively supporting this Alpha branch. Do you mind detailing why you need this?

The change can apply to master branch! It can be used for supporting localfile like "file://path".

@aurorazl what's the use case for local file path? KFserving already supports pvc

Yes it's not work in my test, and I once submitted a PR (#622) to remove it. I think there should not be use case for this and the only thing I can think about is for local testing.

closing staled PR


Lambda load error: importlib_metadata.PackageNotFoundError: importlib_metadata

Unable to get Lambda loading with the configuration below:
versions
Framework Core: 1.59.3
Plugin: 3.2.5
SDK: 2.2.1
Components Core: 1.1.2
Components CLI: 1.4.0

requirements.txt
boto3==1.9.42
Flask==1.1.1
flask-cors==3.0.8
flask-marshmallow==0.10.1
flask-restplus==0.13.0
marshmallow==3.2.1
python-json-logger==0.1.11
requests==2.22.0
webargs==5.5.1

# bert and TF
tensorflow==1.13.1
bert-tensorflow==1.0.1
beautifulsoup4==4.8.1

serverless.yml snippet
plugins:
  - serverless-python-requirements
  - serverless-wsgi

custom:
  wsgi:
    app: app.app
    packRequirements: false
  pythonRequirements:
    dockerImage: lambci/lambda:build-python3.6
    # dockerizePip: true
    zip: true
    slim: false
    noDeploy:
      - boto3
      - botocore
      - docutils
      - jmespath
      - pip
      - python-dateutil
      - s3transfer
      - setuptools
      - six
      - tensorboard

ERROR on Lambda Load
    from .model import Model
  File "/tmp/sls-py-req/flask_restplus/model.py", line 15, in <module>
    from jsonschema import Draft4Validator
  File "/tmp/sls-py-req/jsonschema/__init__.py", line 33, in <module>
    import importlib_metadata as metadata
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 554, in <module>
    __version__ = version(__name__)
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 516, in version
    return distribution(distribution_name).version
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 489, in distribution
    return Distribution.from_name(distribution_name)
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 194, in from_name
    raise PackageNotFoundError(name)
importlib_metadata.PackageNotFoundError: importlib_metadata
START RequestId: 263c5ed9-a9ac-4d2a-a61d-84a52a023d75 Version: $LATEST
module initialization error: Unable to import app.app

END RequestId: 263c5ed9-a9ac-4d2a-a61d-84a52a023d75
REPORT RequestId: 263c5ed9-a9ac-4d2a-a61d-84a52a023d75	Duration: 108.10 ms	Billed Duration: 200 ms	Memory Size: 1024 MB	Max Memory Used: 483 MB	Init Duration: 4198.33 ms
module initialization error
Unable to import app.app
Traceback (most recent call last):
  File "/tmp/sls-py-req/jsonschema/__init__.py", line 31, in <module>
    from importlib import metadata
ImportError: cannot import name 'metadata'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/var/task/wsgi_handler.py", line 44, in import_app
    wsgi_module = importlib.import_module(wsgi_fqn_parts[-1])
  File "/var/lang/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/var/task/app.py", line 6, in <module>
    from industry_classifier.app import create_app
  File "/var/task/industry_classifier/app.py", line 6, in <module>
    from industry_classifier import api
  File "/var/task/industry_classifier/api/__init__.py", line 1, in <module>
    from . import views
  File "/var/task/industry_classifier/api/views.py", line 2, in <module>
    from flask_restplus import Api
  File "/tmp/sls-py-req/flask_restplus/__init__.py", line 4, in <module>
    from . import fields, reqparse, apidoc, inputs, cors
  File "/tmp/sls-py-req/flask_restplus/reqparse.py", line 19, in <module>
    from .model import Model
  File "/tmp/sls-py-req/flask_restplus/model.py", line 15, in <module>
    from jsonschema import Draft4Validator
  File "/tmp/sls-py-req/jsonschema/__init__.py", line 33, in <module>
    import importlib_metadata as metadata
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 554, in <module>
    __version__ = version(__name__)
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 516, in version
    return distribution(distribution_name).version
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 489, in distribution
    return Distribution.from_name(distribution_name)
  File "/tmp/sls-py-req/importlib_metadata/__init__.py", line 194, in from_name
    raise PackageNotFoundError(name)
importlib_metadata.PackageNotFoundError: importlib_metadata

i am running into same error .
Any update!

The issue here (I think) is that slim: true is removing .dist-info files that are needed for your ML packages.
Here's a workaround, modify the pythonRequirements section of your serverless.yml to include both slimPatternsAppendDefaults and slimPatterns (the important part here is to exclude the removal of **/*.dist-info*):
pythonRequirements:
  slim: true
  slimPatternsAppendDefaults: false
  slimPatterns:
    - '**/*.py[c|o]'
    - '**/__pycache__*'

Also note that if you were using previously cached pip files (which is on by default), you may also want to disable cache before deploying:
pythonRequirements:
  useDownloadCache: false
  useStaticCache: false
  slim: true
  slimPatternsAppendDefaults: false
  slimPatterns:
    - '**/*.py[c|o]'
    - '**/__pycache__*'

I just bumped into the same error after adding a dependency and then having to figure out that one of the transitive dependencies is relying on dist-info files.
I would also vote for removing the *.dist-info pattern from the default exclusion list, since the size of them is pretty negligible, while at the same time omitting these files can break a lot of applications.

I just ran into this problem as well; however, in my case, I'm using the poetry support from this plugin.
Poetry adds the package metadata when you install a package or build a wheel. This plugin only exports the package dependencies, which neglects the package metadata and causes the same error as OP.
Is that different enough from this to warrant a new issue?

The issue here (I think) is that slim: true is removing .dist-info directories that is needed by importlib_metadata to function properly.
Here's a workaround: modify the pythonRequirements section of your serverless.yml to include both slimPatternsAppendDefaults and slimPatterns (the important part here is to exclude the removal of **/*.dist-info*):
pythonRequirements:
  slim: true
  slimPatternsAppendDefaults: false
  slimPatterns:
    - '**/*.py[c|o]'
    - '**/__pycache__*'

Also note that if you were using previously cached pip files (which is on by default), you may also want to disable cache before deploying:
pythonRequirements:
  useDownloadCache: false
  useStaticCache: false
  slim: true
  slimPatternsAppendDefaults: false
  slimPatterns:
    - '**/*.py[c|o]'
    - '**/__pycache__*'

Ultimately the .dist-info you aren't deleting should contribute only minimally to the deployed .zip size; in fact, also adding '**/docs/*' and '**/tests/*' to slimPatterns should save you even more MBs. Though be warned that removing those two directories may have other side effects (for example boto3 has a docs directory as part of their code base).

Thanks a lot for this, it fixed my issue! One thing though -- if I set the caches back to true after disabling them, I hit the issue again. Were you ever able to get it to work with the caches or did you have to keep them disabled? Thanks!


[UNDERTOW-1890] - fix NetworkUtils exceptions

Issue: https://issues.redhat.com/browse/UNDERTOW-1890

@baranowb  I want to run WF tests with this before merging, I'll merge it soon

Thanks @baranowb !


Fix: Update ESLint to handle class static member

Having static member in a class is only supported in ES7+ (I think). Bump the version in ESlint will clear the error in database.js.

Parsing error is gone for me (Visual Studio Code), but I still cannot see other errors and warnings in database.js (for example when I change let to var

Big oops, I basically set an invalid env and made ESLint crash. Should be fixed now, but I has to pull in babel-eslint.

@chakflying: Could you also fix remaining files? If you are using VS Code, here is how to auto-fix files during file save: https://github.com/louislam/uptime-kuma/pull/113#issue-696595568

database.js fixed. Rebased on master.

BTW is semicolon turned off on purpose? Currently we have it all over the place, random lines have or have no semicolon. IMO consistency on this would be better. I also find lines with semi more readable.

Lol, just saw another eslint error.
The reason why I disable eslint in the first place is, I don't want to spend time to solve these eslint error...

@louislam
Ooops, didn't know vue also has its own parser. Fix by replacing parser and parserOptions:
    parser: "vue-eslint-parser",
    parserOptions: {
        parser: "@babel/eslint-parser",
        sourceType: "module",
        requireConfigFile: false,
    },

It really isn't ESLint's problem, the pain comes from rarely having to set this up myself :( The blessed cli generating starter projects has spoiled us...

vue-eslint-parser

@louislam
Ooops, didn't know vue also has its own parser. Fix by replacing parser and parserOptions:
    parser: "vue-eslint-parser",
    parserOptions: {
        parser: "@babel/eslint-parser",
        sourceType: "module",
        requireConfigFile: false,
    },

It really isn't ESLint's problem, the pain comes from rarely having to set this up myself :( The blessed cli generating starter projects has spoiled us...

Thank you for your investigation. You are right, I skipped eslint when I was creating this project via vite.js cli. 😂
However, since I put the server part in the same project, hopefully it won't be a problem for backend code.


Improve our migration story

This PR does a number of things related to migrations:

Rename the migration script (based on the scheme discussed today; see the changes to the CONTRIBUTING file for more detail)
Remove the procrastinate_version table, and add a migration script for that
Remove the notion of schema version entirely (which is to be handled by the migration tool)
Update the CONTRIBUTING file as appropriate

I have tested a migration from 0.5.0 to the current version, and it's worked as expected. Here are the exact steps I've followed for my test:
$ dropb procrastinate
$ git checkout 0.5.0
$ createdb procrastinate
$ procrastinate migrate  # to apply the Procrastinate 0.5.0 schema to the database
$  # create the Pum table and set the baseline
$ pum baseline -p procrastinate -t public.pum -d procrastinate/sql/migrations/ -b 0.5.0
$ git checkout ele_deltas  # this PR's branch with three deltas
$ # now do the migration!
$ pum upgrade -p procrastinate -t public.pum -d procrastinate/sql/migrations/
Upgrade...     Applying delta 0.5.0 001_drop_started_at_column... OK
     Applying delta 0.5.0 002_drop_started_at_column... OK
     Applying delta 0.5.0 003_drop_procrastinate_version_table... OK

The next step is to finish the "use pum for migrations" how-to, which I started in the ele_pum branch. But I'd like to add it with a separate PR.
Successful PR Checklist:

[x] Tests
[x] Documentation (optionally: run spell checking)
[x] Had a good time contributing? (if not, feel free to give some feedback)

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #167   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          21     21
  Lines         848    827   -21
  Branches       87     84    -3
=====================================
- Hits          848    827   -21

Impacted Files
Coverage Δ

procrastinate/healthchecks.py
100% <ø> (ø)
:arrow_up:

procrastinate/cli.py
100% <ø> (ø)
:arrow_up:

procrastinate/schema.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816bfd5...b218884. Read the comment docs.


[Suggestion] replace route group with the method name

so instead of having
Route.group('version1', function () {
  Route.get('/users', function * (request, response) {
  })
}).prefix('/api/v1')

it would be
Route.prefix('/api/v1', function () {
  Route.get('/users', function * (request, response) {
  })
})

writing the route like this makes it much easier for maintainability and improve code readability/quality specially when the nested group option gets added.

It is not only about prefixing the routes since you can also attach a middleware to a group of routes.

in that case maybe we can then use it like
Route.group([
  {prefix:'/api/v1'},
  {middleware: 'auth'}
], function () {
  Route.get('/users', function * (request, response) {
  })
})

This is even weird than the current syntax we have right now.

its using the same syntax laravel is following, which is an array of options instead of using the chained methods, am totaly new to js world so forgive me

Laravel have it's own ways of doing things. Also I don't find any reason of changing the syntax and introducing a new breaking change.

okay then, thanx for ur help 👍


Payment status other than "paid" refreshes the Mollie page

Hi,
I just stumbled upon your plugin... Thanks for your work. It's great to see that we're getting very close to getting the complete Mollie experience within the Mall plugin.
Do you know how we can deal with the issue of the Mollie page refreshing whenever the payment has any other status than "Paid"?
As you can see here, we were working on a similar integration, and it seems that the missing link would be a webhook. Would you have a clue how we could implement that?
Otherwise payment methods like banktransfer would not work in the plugin.
Thanks in advance for looking into it.

Hi Maarten,
I've created a separate branch and spent some time converting the plugin to use Mollie's own API client for PHP instead of omnipay so we can utilize webhooks, feel free to test it for your purposes.
When a Mollie payment is created in the process() method, it passes a webhook URL for which I have created a route. When Mollie sends a POST request to this route, it calls a method that can change status of the order depending on status of the Mollie payment.
There are still some issues  I will have to look into:

Mollie expects the amount to be formatted like "10.00", but the Mall plugin's $this->order->total_in_currency variable will output a rounded numer like "10" which Mollie will reject.

When you have enabled multiple payment methods in your Mollie account and you do not specify a payment method when creating a payment in the process() method, Mollie will not send a webhook when a payment is failed or canceled, it will just return you to the Mollie start screen where you can select another payment method. If you abandon the payment page, Mollie will send a webhook when the payment expires. The expiry time depends on the last payment method you attempted. The result of this is that Mollie will never send a webhook to your shop if you have enabled multiple payment methods within Mollie, only 'paid' and 'expired' will be used.

What to do when the user returns to the website after paying  (or not paying): I have enabled a callback in the
process() method. This callback requires you to implement a complete() method in your class which is called when the user returns to the website. I've made a complete() method that simply redirects you to the orders page regardless of the outcome of the payment. I am not sure if there is a better way to handle this.

Changing the sratus of the Mall order / payment: The method that gets called when the webhook is used will either return PaymentResult->fail() or PaymentResult->success() depending on the status of the Mollie payment. I have experimented with using Mall's built in OrderState model, but this model only contains order states for canceled, complete and new, so I am not sure how to handle expired payments.

Hi Guus,
Thank you so much for your work!! I've been doing some testing and came up with the following:
Regarding your first remark: could we do something like this? We do have to be mindful of other thousand and decimal separators one might set up in the currency configuration of the Mall Plugin:
number_format((float)$this->order->total_in_currency,2)
As far as your second comment is concerned: if the admin has multiple payment methods defined in their Mollie account, could we set up a separate payment gateway in the Mall plugin for each of those? We might define a payment gateway for each payment method in the Mollie account, and we could supply fields for the apikey, besides a dropdown with a list of all available payment methods? Would this be practical, you think? Or can we get it up and running in the current setup?
Regarding your third comment: could you have a look at the payment method "invoice" that is by default included in the Mall plugin? When we choose that payment method, the user is redirected to /checkout/done with a message: your order is completed. There's a button below that links to the overview of the orders. There the order is marked "payment pending". Would that be of any use for our usecase?
Regarding your fourth comment, I think we might ask the advice of Tobias here. I'll try to reach him regarding expired payments...
I hope these comments might be helpful. Let me know if there's anything else I could do.

Hi Maarten,
I have made some more progress:

The plugin now has the ability to specify a Mollie payment method when creating a payment. When creating a payment method in the "Mall: Payments" section of the settings, make sure that the "Code" field matches a Mollie payment method. When checking out an order, the plugin will check if the selected payment method is active in the Mollie account using the API. if the payment method is not active or otherwise invalid, the user will be redirected to the Mollie Checkout page that shows all possible payment methods.

Fixed formatting for the amount > value field using number_format() I believe this is safe because the $this->order->total_in_currency variable is always a float.

Thank you so much for your work. I'll be testing it out ASAP and let you know my findings!


ERROR 'NoneType' object has no attribute 'nodes'. WARNING can't convert np.ndarray of type numpy.str_.

Hi,
I'm using Graphein on Google Colab, I have a list of PDB ids pdb_ids and I'm using ProteinGraphDataset(...) to create a dataset.
!pip install graphein[extras] torch-geometric

from graphein.ml import ProteinGraphDataset
import graphein.protein as gp

dataset = ProteinGraphDataset(
    root = "./dataset",
    pdb_codes=pdb_ids,
    graphein_config=gp.ProteinGraphConfig()
)

Output
/usr/lib/python3.10/multiprocessing/popen_fork.py:66: RuntimeWarning: os.fork() was called. os.fork() is incompatible with multithreaded code, and JAX is multithreaded, so this will likely lead to a deadlock.
  self.pid = os.fork()
100%
 1/1 [00:00<00:00,  3.29it/s]
/usr/lib/python3.10/multiprocessing/popen_fork.py:66: RuntimeWarning: os.fork() was called. os.fork() is incompatible with multithreaded code, and JAX is multithreaded, so this will likely lead to a deadlock.
  self.pid = os.fork()
[08/17/24 21:19:38] WARNING  PDB 8xip not found.                                                       [utils.py](file:///usr/local/lib/python3.10/dist-packages/graphein/protein/utils.py):[220](file:///usr/local/lib/python3.10/dist-packages/graphein/protein/utils.py#220)
                    INFO     8xip downloaded to antigen-nanobody-structures/raw                        [utils.py](file:///usr/local/lib/python3.10/dist-packages/graphein/protein/utils.py):[227](file:///usr/local/lib/python3.10/dist-packages/graphein/protein/utils.py#227)
Processing...
  0%|          | 0/1 [00:00<?, ?it/s]
100%
 100/100 [01:54<00:00,  1.61it/s]
[08/17/24 21:21:35] WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.
                    WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.
                    WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.

*** same error a lot of times ***

                    WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.
                    WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.
                    WARNING  can't convert np.ndarray of type numpy.str_. The only supported      [conversion.py](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py):[334](file:///usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py#334)
                             types are: float64, float32, float16, complex64, complex128, int64,
                             int32, int16, int8, uint64, uint32, uint16, uint8, and bool.
  0%|          | 0/1 [01:59<?, ?it/s]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[<ipython-input-10-e55dd419c727>](https://localhost:8080/#) in <cell line: 2>()
      1 # Create dataset of surfaces for proteins.
----> 2 dataset = ProteinGraphDataset(
      3     root = "./dataset",
      4     pdb_codes=pdb_ids,
      5     graphein_config=gp.ProteinGraphConfig()

7 frames
[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in __init__(self, root, paths, pdb_codes, uniprot_ids, graph_labels, node_labels, chain_selections, graphein_config, graph_format_convertor, graph_transformation_funcs, pdb_transform, transform, pre_transform, pre_filter, num_cores, af_version)
    472         self.graph_transformation_funcs = graph_transformation_funcs
    473         self.af_version = af_version
--> 474         super().__init__(
    475             root,
    476             transform=transform,

[/usr/local/lib/python3.10/dist-packages/torch_geometric/data/dataset.py](https://localhost:8080/#) in __init__(self, root, transform, pre_transform, pre_filter, log, force_reload)
    113
    114         if self.has_process:
--> 115             self._process()
    116
    117     def indices(self) -> Sequence:

[/usr/local/lib/python3.10/dist-packages/torch_geometric/data/dataset.py](https://localhost:8080/#) in _process(self)
    258
    259         fs.makedirs(self.processed_dir, exist_ok=True)
--> 260         self.process()
    261
    262         path = osp.join(self.processed_dir, 'pre_transform.pt')

[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in process(self)
    620
    621             # Convert to PyTorch Geometric Data
--> 622             graphs = [self.graph_format_convertor(g) for g in graphs]
    623
    624             # Assign labels

[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in <listcomp>(.0)
    620
    621             # Convert to PyTorch Geometric Data
--> 622             graphs = [self.graph_format_convertor(g) for g in graphs]
    623
    624             # Assign labels

[/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py](https://localhost:8080/#) in __call__(self, G)
    467     def __call__(self, G: nx.Graph):
    468         nx_g = eval("self.convert_" + self.src_format + "_to_nx(G)")
--> 469         dst_g = eval("self.convert_nx_to_" + self.dst_format + "(nx_g)")
    470         return dst_g
    471

[/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py](https://localhost:8080/#) in <module>

/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py in convert_nx_to_pyg(self, G)
    272
    273         # Initialise dict used to construct Data object & Assign node ids as a feature
--> 274         data = {"node_id": list(G.nodes())}
    275         G = nx.convert_node_labels_to_integers(G)
    276

AttributeError: 'NoneType' object has no attribute 'nodes'

Hi @PabloExperimental
From looking at your logs it seems pdb 8xip is failing. As you can see on this entry page this structure is not available in PDB format. I'd suggest either using a different format or converting from another format with appropriate sanitisation.

I validate the existence of pdb files with this code:
valid_pdb_ids = []

BASE_URL = "https://files.rcsb.org/download/"

for id in pdb_ids:

  try:
    pdb_name_id = id.upper()+".pdb"
    composed_url = BASE_URL + pdb_name_id
    response = requests.get(composed_url)

    if response.status_code == 200:
      valid_pdb_ids.append(id)
    else:
      continue

  except Exception:
    continue

Then I tested for a few entries because for the whole list will take over 3 hours:
edge_fns = [
    add_aromatic_interactions,
    add_hydrophobic_interactions,
    add_aromatic_sulphur_interactions,
    add_cation_pi_interactions,
    add_disulfide_interactions,
    add_hydrogen_bond_interactions,
    add_ionic_interactions,
    add_peptide_bonds
    ]

config = ProteinGraphConfig(edge_construction_functions=edge_fns, graph_metadata_functions=[rsa], dssp_config=DSSPConfig())

dataset = ProteinGraphDataset(
    root = "./dataset",
    pdb_codes=valid_pdb_ids[0:5],
    graphein_config=config
)

Output
Processing...
  0%|          | 0/1 [00:00<?, ?it/s]
100%
 5/5 [00:15<00:00, 15.50s/it]
  0%|          | 0/1 [00:18<?, ?it/s]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[<ipython-input-23-d662d3b9515d>](https://localhost:8080/#) in <cell line: 2>()
      1 # Create dataset of surfaces for proteins.
----> 2 dataset = ProteinGraphDataset(
      3     root = "./dataset",
      4     pdb_codes=valid_pdb_ids[0:5],
      5     graphein_config=config

7 frames
[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in __init__(self, root, paths, pdb_codes, uniprot_ids, graph_labels, node_labels, chain_selections, graphein_config, graph_format_convertor, graph_transformation_funcs, pdb_transform, transform, pre_transform, pre_filter, num_cores, af_version)
    472         self.graph_transformation_funcs = graph_transformation_funcs
    473         self.af_version = af_version
--> 474         super().__init__(
    475             root,
    476             transform=transform,

[/usr/local/lib/python3.10/dist-packages/torch_geometric/data/dataset.py](https://localhost:8080/#) in __init__(self, root, transform, pre_transform, pre_filter, log, force_reload)
    113
    114         if self.has_process:
--> 115             self._process()
    116
    117     def indices(self) -> Sequence:

[/usr/local/lib/python3.10/dist-packages/torch_geometric/data/dataset.py](https://localhost:8080/#) in _process(self)
    258
    259         fs.makedirs(self.processed_dir, exist_ok=True)
--> 260         self.process()
    261
    262         path = osp.join(self.processed_dir, 'pre_transform.pt')

[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in process(self)
    620
    621             # Convert to PyTorch Geometric Data
--> 622             graphs = [self.graph_format_convertor(g) for g in graphs]
    623
    624             # Assign labels

[/usr/local/lib/python3.10/dist-packages/graphein/ml/datasets/torch_geometric_dataset.py](https://localhost:8080/#) in <listcomp>(.0)
    620
    621             # Convert to PyTorch Geometric Data
--> 622             graphs = [self.graph_format_convertor(g) for g in graphs]
    623
    624             # Assign labels

[/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py](https://localhost:8080/#) in __call__(self, G)
    467     def __call__(self, G: nx.Graph):
    468         nx_g = eval("self.convert_" + self.src_format + "_to_nx(G)")
--> 469         dst_g = eval("self.convert_nx_to_" + self.dst_format + "(nx_g)")
    470         return dst_g
    471

[/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py](https://localhost:8080/#) in <module>

/usr/local/lib/python3.10/dist-packages/graphein/ml/conversion.py in convert_nx_to_pyg(self, G)
    272
    273         # Initialise dict used to construct Data object & Assign node ids as a feature
--> 274         data = {"node_id": list(G.nodes())}
    275         G = nx.convert_node_labels_to_integers(G)
    276

AttributeError: 'NoneType' object has no attribute 'nodes'


CLI App Example Fails With 'no field named pointer' Error

Description
I encountered an issue while running the sample code from the project.
const std = @import("std");
const cli = @import("zig-cli");

// Define a configuration structure with default values.
var config = struct {
    host: []const u8 = "localhost",
    port: u16 = undefined,
}{};

pub fn main() !void {
    var r = try cli.AppRunner.init(std.heap.page_allocator);

    // Create an App with a command named "short" that takes host and port options.
    const app = cli.App{
        .command = cli.Command{
            .name = "short",
            .options = &.{
                // Define an Option for the "host" command-line argument.
                .{
                    .long_name = "host",
                    .help = "host to listen on",
                    .value_ref = r.mkRef(&config.host),
                },

                // Define an Option for the "port" command-line argument.
                .{
                    .long_name = "port",
                    .help = "port to bind to",
                    .required = true,
                    .value_ref = r.mkRef(&config.port),
                },
            },
            .target = cli.CommandTarget{
                .action = cli.CommandAction{ .exec = run_server },
            },
        },
    };
    return r.run(&app);
}

// Action function to execute when the "short" command is invoked.
fn run_server() !void {
    // Log a debug message indicating the server is listening on the specified host and port.
    std.log.debug("server is listening on {s}:{d}", .{ config.host, config.port });
}

Error Output
run
└─ run test-project
   └─ zig build-exe test-project Debug native 4 errors
/home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/value_ref.zig:60:18: error: no field named 'pointer' in union 'builtin.Type'
    const t = ti.pointer.child;
                 ^~~~~~~
/home/soheil/.zvm/0.13.0/lib/std/builtin.zig:256:18: note: union declared here
pub const Type = union(enum) {
                 ^~~~~
referenced by:
    allocRef__anon_3610: /home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/value_ref.zig:54:22
    mkRef__anon_3100: /home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/app_runner.zig:32:34
    remaining reference traces hidden; use '-freference-trace' to see all reference traces
/home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/value_ref.zig:60:18: error: no field named 'pointer' in union 'builtin.Type'
    const t = ti.pointer.child;
                 ^~~~~~~
/home/soheil/.zvm/0.13.0/lib/std/builtin.zig:256:18: note: union declared here
pub const Type = union(enum) {
                 ^~~~~
/home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/value_ref.zig:60:18: error: no field named 'pointer' in union 'builtin.Type'
    const t = ti.pointer.child;
                 ^~~~~~~
/home/soheil/.zvm/0.13.0/lib/std/builtin.zig:256:18: note: union declared here
pub const Type = union(enum) {
                 ^~~~~
/home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/value_ref.zig:60:18: error: no field named 'pointer' in union 'builtin.Type'
    const t = ti.pointer.child;
                 ^~~~~~~
/home/soheil/.zvm/0.13.0/lib/std/builtin.zig:256:18: note: union declared here
pub const Type = union(enum) {
                 ^~~~~
error: the following command failed with 4 compilation errors:
/home/soheil/.zvm/0.13.0/zig build-exe -ODebug --dep zig-cli -Mroot=/tmp/test-project/src/main.zig -Mzig-cli=/home/soheil/.cache/zig/p/1220cc1cf7dff2a1c0df453620a2469ee1384e728526a35c38a27d45b4def8a124f4/src/main.zig --cache-dir /tmp/test-project/.zig-cache --global-cache-dir /home/soheil/.cache/zig --name test-project --listen=-
Build Summary: 2/7 steps succeeded; 1 failed (disable with --summary none)
run transitive failure
└─ run test-project transitive failure
   ├─ zig build-exe test-project Debug native 4 errors
   └─ install transitive failure
      └─ install test-project transitive failure
         └─ zig build-exe test-project Debug native (reused)
error: the following build command failed with exit code 1:
/tmp/test-project/.zig-cache/o/8d1d9412d7ef4aeaa0d6a0e46a5629e0/build /home/soheil/.zvm/0.13.0/zig /tmp/test-project /tmp/test-project/.zig-cache /home/soheil/.cache/zig --seed 0x72fba74a -Z9ad9f965c0dc7e68 run

Environment

Zig version: 0.13.0
Operating System: Ubuntu

Since most folks use the zig-master, I try to keep the main branch compatible with zig-master.


home-assistant: 2021.4.2 -> 2021.4.3

Motivation for this change
https://github.com/home-assistant/core/releases/tag/2021.4.3
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

    Outdated dependencies
┏━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━┓
┃ Package ┃ Current ┃ Wanted ┃
┡━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━┩
│ numpy   │ 1.20.1  │ 1.20.2 │
└─────────┴─────────┴────────┘

(which is already in staging)

@GrahamcOfBorg eval

Result of nixpkgs-review pr 119004 run on x86_64-linux 1

5 packages built:

home-assistant
python38Packages.devolo-home-control-api
python38Packages.python-smarttub
python39Packages.devolo-home-control-api
python39Packages.python-smarttub


Prompt Cards not showing on prompthub

The prompt cards, which are .md files with the same name as their corresponding .yaml files are not showing on the prompt hub. I'm not sure where the issue lies @silvanocerza

Fixed with #28 and deepset-ai/prompthub-ui#19.


Release/0.3.1

Codecov Report

Merging #35 (1d608df) into main (59dc38e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #35   +/-   ##
=========================================
  Coverage     70.60%   70.60%
  Complexity      312      312
=========================================
  Files            63       63
  Lines          1177     1177
  Branches         66       66
=========================================
  Hits            831      831
  Misses          305      305
  Partials         41       41

Impacted Files
Coverage Δ

...tarterkit/wes/constant/WesServiceInfoDefaults.java
75.00% <ø> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Errors with --nvdDatafeed parameter

With earlier versions upto 8.4.3, storing the nvd data mirror, created using https://github.com/stevespringett/nist-data-mirror/, in a git repository and using that repo with --cveUrlBase and --cveUrlModified was working.
But now, storing the data, generated through vulnz tool, in github and using that URL as an input to --nvdDatafeed flag is not working.
Getting this error -
[ERROR] Unable to download the NVD API cache.properties
org.owasp.dependencycheck.data.update.exception.UpdateException: Unable to download the NVD API cache.properties
at org.owasp.dependencycheck.data.update.NvdApiDataSource.getRemoteCacheProperties(NvdApiDataSource.java:558)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDatafeed(NvdApiDataSource.java:130)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.update(NvdApiDataSource.java:108)
at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:906)
at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:878)
at org.owasp.dependencycheck.App.runUpdateOnly(App.java:427)
at org.owasp.dependencycheck.App.run(App.java:172)
at org.owasp.dependencycheck.App.main(App.java:89)
Caused by: org.owasp.dependencycheck.utils.ResourceNotFoundException: Requested resource does not exist - received a 404
at org.owasp.dependencycheck.utils.HttpResourceConnection.obtainConnection(HttpResourceConnection.java:233)
at org.owasp.dependencycheck.utils.HttpResourceConnection.fetch(HttpResourceConnection.java:163)
at org.owasp.dependencycheck.utils.Downloader.fetchContent(Downloader.java:183)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.getRemoteCacheProperties(NvdApiDataSource.java:551)
... 7 common frames omitted
[INFO] Updating CISA Known Exploited Vulnerability list: https://www.cisa.gov/sites/default/files/feeds/known_exploited_vulnerabilities.json
[INFO] Begin database defrag
[INFO] End database defrag (240 ms)
[ERROR] Unable to download the NVD API cache.properties
No documentation exists for the usage of the --nvdDatafeed flag. What could be the reason for this error and its solution?

got the same error on 9.0.4, on 9.0.3 it works

got the same error on 9.0.4, on 9.0.3 it works

@ibulic00 Could you please tell me where you have hosted the data that you downloaded from the Vulnz CLI tool?

Depending on how you are hosting the cache - the cache.properties may not be served by the HTTP server. If you are using vulnz 5.1.0 or newer to create the cache PR #6282 should resolve the issue. I'll release the updated version soon.

Also - you may need to quote the URL per https://github.com/jeremylong/DependencyCheck/issues/6251#issuecomment-1850380838.


Use variables to make it easier to update the download website if it ever changes.

I will use variables to store the URLs for downloading Bitcoin Core and its checksums. This way, if the URLs change in the future, we can easily modify the script without breaking it.
Originally posted by @BenWestgate in https://github.com/BenWestgate/Bails/issues/73#issuecomment-1657283478

this will let me create an array of urls and try each one sequentially with the wget part in a function. That would be cleaner than the current double wget command.

Covered by #94


No software limits on voltage, current or frequency (Trac #3)

The software should enforce limits on voltage and current (and maybe frequency) to prevent damage to the electronics. In the future, it may make sense warn users about potential damage to their device, though this would require more information about the modes of failure.
Migrated from http://microfluidics.utoronto.ca/ticket/3
{
    "status": "closed",
    "changetime": "2014-11-06T21:45:19",
    "description": "The software should enforce limits on voltage and current (and maybe frequency) to prevent damage to the electronics. In the future, it may make sense warn users about potential damage to their device, though this would require more information about the modes of failure.",
    "reporter": "ryan",
    "cc": "",
    "resolution": "duplicate",
    "_ts": "1415310319042497",
    "component": "microdrop",
    "summary": "No software limits on voltage, current or frequency",
    "priority": "major",
    "keywords": "",
    "version": "0.1",
    "time": "2011-09-18T05:12:44",
    "milestone": "Microdrop 1.1",
    "owner": "ryan",
    "type": "defect"
}

Trac update at 20111008T03:10:24: ryan changed summary from "No software limits on voltage, current or frequency." to "No software limits on voltage, current or frequency"

Trac update at 20140312T20:02:01: ryan changed milestone from "1.0" to "1.1"

Trac update at 20140417T19:40:13: ryan changed component from "core" to "microdrop"

Trac update at 20141106T21:45:19:

ryan commented:

This is a duplicate of #163

ryan changed resolution from "" to "duplicate"
ryan changed status from "new" to "closed"


Steam 968 UI changes

Makes a few changes requested by Michelle:

Times and time zones are included with date times that include that information.
Dose to Volume tables now include the "volume Label" in the title of each column.
Modalities and Techniques have been split off into their own table. One modality can have several techniques, which will be separated by new lines.
Tables have been reordered per Michelle's suggestions.

@dmendelowitz Good catch! I added the optional chining operator throughout the getModalities function in commit 0eba9c1.

@dmendelowitz  That issue was kind of two-pronged, and commit 5774367 should address both issues.

If metadata was included, the MultiEntryDataTable component would still look for the "Volume Label" field to populate the title. This would result in "undefined" being printed to the metadata headers which was inappropriate. I edited the component to not assume that it would always be used in the Dose to volume context.
If no metadata was included at all, the app would error out because the Metadata component was actually still being rendered, just with no data (this is because empty arrays in javascript are still truthy values, so I fixed that by making the check in the TreatmentVolumeTable a bit more explicit). That bug can actually be seen in our currently deployed site, but it's especially nasty here because the  MultiEntryDataTable component was trying to access a property on those undefined metadata objects.

Confusing javascript truthyness strikes again... This all looks good now!


Add faster copy/erase to overwrite-only mode

This add a new option to overwrite-only mode that enables copy/erase of
only the amount of sectors that are required to store the source image.
This is enabled by default when overwrite-only mode is used.
MCUB-70
Signed-off-by: Fabio Utzig<EMAIL_ADDRESS>

@d3zd3z @mbolivar This seems good enough that I left it enabled by default for Mynewt/Zephyr/Simulator.
There's one possible "issue" remaining, which is when erasing slot 1 after the copy is done, both the first sector (header) and last (trailer) are erased. This is done because if the trailer is left un-erased, the image_ok/magic will still be there if a new image without padding/trailer is written (as is the case with mynewt), triggering a new update. It's possible that a reset between both erases would trigger this unwanted behaviour but it seems quite hard to fix for something that will hardly ever happen.

Do we need this to be an option, or should we just make this the default behavior?  We always do this with swapping.

I was not sure so I left as an option, imagining someone might some day want to actually erase all sectors (for security reasons IMO!).

I'm +1 to leave it an option.


Bump Quarkus to 3.12.3

Bumping Quarkus to 3.12.3

CI pass so we will see in few next daily if something is wrong


How to count until 150.000?

If I code data-to="150.000", the output is 150: how can i fix this?
 I fixed it with data-decimals="3"!
Good job everybody!


Command Line Interface ussage

Currently, the app can only be launched with a python ... call at the terminal.
As the project is defined as an installable package, a decent CLI should be defined.

Issue fixed at https://github.com/Jtachan/Conways_GameOfLife/pull/3


[BUG] @microsoft/applicationinsights-web fails to initialize with latest version

Description/Screenshot
Starting this morning, our application insights instance began failing to initialize:

TypeError: Cannot set property 'snippetVer' of undefined
at _updateSnippetProperties (Initialization.js?e727:236)
at Initialization.loadAppInsights (Initialization.js?e727:263)
at new OnlineTelemetryClient (OnlineTelemetryClient.ts?ed0c:20)
at Object.eval (Telemetry.ts?e430:72)
at Generator.next ()
at eval (Telemetry.ts?e430:5)
at new Promise ()
at __awaiter (Telemetry.ts?e430:5)
at Object.initializeTelemetry (Telemetry.ts?e430:62)
at eval (Extension.ts?7991:33)
at Generator.next ()
at eval (Extension.ts?7991:5)
at new Promise ()
at __awaiter (Extension.ts?7991:5)
at activate (Extension.ts?7991:31)
at Function._callActivateOptional (extHostExtensionService.ts:418)
at Function._callActivate (extHostExtensionService.ts:407)
at extHostExtensionService.ts:362

Steps to Reproduce
Initialize a new instance of Application Insights with a non-null snippet. Our snippet:
this.appInsights = new ApplicationInsights({
			config: {
				instrumentationKey,
				endpointUrl: 'https://vortex.data.microsoft.com/collect/v1',
				emitLineDelimitedJson: true,
				isCookieUseDisabled: true,
			},
		});

OS/Browser:
Windows - Chrome and Edge

SDK Version [e.g. 22]:
Using version 2.5.6 of the @microsoft/applicationinsights-web NPM package
NOTE: this works in version 2.5.3 (and I presume lower)

@MSNev I've got the same issue while working on gatsby site. I actually thought it was an issue with my environment first. I will add details of the error(s) I got here in case someone else gets this.
Error symptoms
When you use ApplicationInsights in site without using NPM Setup, you may have got errors like this.

ReferenceError: XMLHttpRequest is not defined
ReferenceError: XDomainRequest is not defined
TypeError: Cannot set property 'snippetVer' of undefined

For me, I got each error in order mentioned above after trying to fixing each, for example, to fix ReferenceError: XMLHttpRequest is not defined, I tried,
npm install xhr2 --save

if (!("XMLHttpRequest" in global)) {
    global.XMLHttpRequest = require('xhr2');
}

After this, I got ReferenceError: XDomainRequest is not defined, which I didn't found anyway to import/polyfil, I tried this,
if (!("XMLHttpRequest" in global)) {
    global.XMLHttpRequest = require('xhr2');
    global.XDomainRequest = undefined;
}

After above change, I got TypeError: Cannot set property 'snippetVer' of undefined, which I didn't know how to fix, and then came across this post.
Solution
ApplicationInsights version I've been using was, 2.5.6, which seems to be causing the issue. I downgraded it to 2.5.3 by taking clue from @MSNev which solved the issue.
Please note that you still have to use this block if you are getting first two errors.
npm install xhr2 --save

if (!("XMLHttpRequest" in global)) {
    global.XMLHttpRequest = require('xhr2');
    global.XDomainRequest = undefined;
}

Hope this helps someone.

The reference errors are interesting, does your gatsby environment not provide any XHR support (which is why you are dragging in a polyfil?).
I'll see if I can address the failures as we want to ensure we work in environments without crashing like this -- do you happen to have the stack trace at all to confirm the location were this is occurring... I have an idea where but I don't want to apply any fix the wrong location(s)

I've also opened a new bug to address the Reference is not defined issues
https://github.com/microsoft/ApplicationInsights-JS/issues/1334

@MSNev I'm very new to Gatsby, I'm not very sure if I have done something wrong when I setup my environment. I will add details about how I setup my environment in the ticket you mentioned above for you to reproduce it.

Fully Deployed to CDN and NPM as version 2.5.7


style: pre-commit

This is a basic pre-commit setup.
I've also added a section in contributing.

docs: pre-commit instructions

I can add ignore patterns if there are any files that need changes. Once ready, this PR should be rebased and merged (the "style" commits can be added to a .git-blame-ignore-revs eventually if we want)
@JPivarski, thoughts? Other committers?
I'd like to slowly introduce the checks from https://scikit-hep.org/developer/style , and also add style checking to CI in the future. But I think small steps are best, so just adding two things in this PR.

Could we exclude the studies and maybe also docs-* directories from these checks? The studies are completely free-form for figuring out the logic of a problem before committing it to mainline code. After having solved the logic, they're left for historical interest and maybe for figuring out a related problem. (I've used old studies in new studies from time to time.) The code in this directory is not necessarily even expected to work, which is why you found a syntax error.
Perhaps we could remove code from this directory, saying that it's all in history, but in practice, it can be hard to find the last commit that has something you're looking for. GitHub's search doesn't search all of the history, for instance. When I need to find an old study, I don't want it to be super-hard! (I won't necessarily know what it was named.)
Formatting the studies with Black is not only unnecessary, given what they are and what they're for, but it would add noise to this one PR, for instance, since this scratch-work is far from being properly formatted.

Could we exclude the studies and maybe also docs-* directories from these checks? The studies are completely free-form for figuring out the logic of a problem before committing it to mainline code. After having solved the logic, they're left for historical interest and maybe for figuring out a related problem. (I've used old studies in new studies from time to time.) The code in this directory is not necessarily even expected to work, which is why you found a syntax error.
Perhaps we could remove code from this directory, saying that it's all in history, but in practice, it can be hard to find the last commit that has something you're looking for. GitHub's search doesn't search all of the history, for instance. When I need to find an old study, I don't want it to be super-hard! (I won't necessarily know what it was named.)
Formatting the studies with Black is not only unnecessary, given what they are and what they're for, but it would add noise to this one PR, for instance, since this scratch-work is far from being properly formatted.

You know, it's also putting newlines at the ends of SVG files. Those are made by Inkscape, and if edited by Inkscape, it will remove the newline again (ah, but the pre-commit would put it back...).
Inkscape is otherwise pretty good about minimizing diffs, in that it has an internally consistent style and maintains SVG element ids.

You know, it's also putting newlines at the ends of SVG files. Those are made by Inkscape, and if edited by Inkscape, it will remove the newline again (ah, but the pre-commit would put it back...).
Inkscape is otherwise pretty good about minimizing diffs, in that it has an internally consistent style and maintains SVG element ids.

Sure, I can exclude svgs and those two directories.

Sure, I can exclude svgs and those two directories.

The test seem to be trailing whitespace in markdown, configuration files, and black in places where I hadn't thought of running it, like the dependent tests. I'm happy with the changes and with having them become automated.
Just not in the studies directory, and probably not for SVG files.

The test seem to be trailing whitespace in markdown, configuration files, and black in places where I hadn't thought of running it, like the dependent tests. I'm happy with the changes and with having them become automated.
Just not in the studies directory, and probably not for SVG files.

Reran with a global exclusion for ^docs.* and ^studies.* (regex), and removed the svg file type from the end-of-file fixer.

Reran with a global exclusion for ^docs.* and ^studies.* (regex), and removed the svg file type from the end-of-file fixer.

Now that I'm looking at this on a computer and not a phone, I found one more: "tests/samples/test-two-arrays.json" was badly formatted on purpose, to test the JSON-reader's insensitivity to such issues. I see that *.svg have been excluded; *.json should be excluded as well, or else (or also) anything in the "tests/samples" directory, since these are all raw data and may have formatting issues on purpose.

Now that I'm looking at this on a computer and not a phone, I found one more: "tests/samples/test-two-arrays.json" was badly formatted on purpose, to test the JSON-reader's insensitivity to such issues. I see that *.svg have been excluded; *.json should be excluded as well, or else (or also) anything in the "tests/samples" directory, since these are all raw data and may have formatting issues on purpose.

As soon as this PR is merged, I'd like all contributors to try running pre-commit. It should be as simple as brew install pre-commit / pipx install pre-commit / pip install pre-commit (whatever you like to use for your main applications), and then just try pre-commit run -a. (or pre-commit run --all-files; I like descriptive names, but since I type this hundreds of times per day, short is better ;) )
We can set it up via CI, but ideally everyone will be able to run locally as well.

As soon as this PR is merged, I'd like all contributors to try running pre-commit. It should be as simple as brew install pre-commit / pipx install pre-commit / pip install pre-commit (whatever you like to use for your main applications), and then just try pre-commit run -a. (or pre-commit run --all-files; I like descriptive names, but since I type this hundreds of times per day, short is better ;) )
We can set it up via CI, but ideally everyone will be able to run locally as well.

I've installed pre-commit and will try
pre-commit run -a

on my next PR (when it's still small and doesn't have many changes).

I've installed pre-commit and will try
pre-commit run -a

on my next PR (when it's still small and doesn't have many changes).

I scanned them again and I'm 100% happy with the changes. If you're not editing it locally, you can merge it or let me know that I can merge it.

I scanned them again and I'm 100% happy with the changes. If you're not editing it locally, you can merge it or let me know that I can merge it.

:tada: Nope, not editing locally.

:tada: Nope, not editing locally.


Add support for a service account credential file at the GCLOUD_CREDENTIAL_PATH

I noticed that the SDK would fail to detect the Application Default Credentials when I set the GCLOUD_CREDENTIAL_PATH environment variable the path of a service account key file. Since the same is working perfectly fine in the C# SDK, I assumed that this is a bug.
Please let me know if I should do anything different here or if this is the expected behavior, since I'm not familiar with the internals of the Node SDK at all!

Hi @flagbug !
To my understanding the service account key file path should be set using GOOGLE_APPLICATION_CREDENTIALS environment variable. See https://firebase.devsite.corp.google.com/docs/admin/setup#initialize-sdk
Is that what you were looking for?

@lahirumaramba Looks like this is a link to an internal Google tool which I can access unfortunately. If I'm understanding you correctly, you're saying that GCLOUD_CREDENTIAL_PATH is supposed to be used internally by the Google Cloud SDK and as a developer, I should always prefer to set the GOOGLE_APPLICATION_CREDENTIALS path, correct?

@lahirumaramba Looks like this is a link to an internal Google tool which I can access unfortunately. If I'm understanding you correctly, you're saying that GCLOUD_CREDENTIAL_PATH is supposed to be used internally by the Google Cloud SDK and as a developer, I should always prefer to set the GOOGLE_APPLICATION_CREDENTIALS path, correct?

Apologies for the incorrect link! Just updated the original comment with https://firebase.google.com/docs/admin/setup#initialize-sdk
You’re right. You can use the GOOGLE_APPLICATION_CREDENTIALS environment variable to point to a service account file to use application default credentials at initialization. I might have misunderstood your requirements though so give it a try and let us know if this works for your project. Thanks!


Add the usage instructions that are in README to top-level crate documentation

Those are useful and hard to find if you don’t read READMEs.

Thanks, yes, this makes sense.
Ideally we would unify this by maybe just including the readme.md as the top-level documentation for the crate, instead of keeping two copies of all docs.


Cannot login to Cloudflare via terminal

Describe the bug
npx wrangler login
⛅ wrangler 2.4.2
Attempting to login via OAuth...
Opening a link in your default browser: https:........
✘ [ERROR] Timed out waiting for authorization code, please try again.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/NagurasChatApp/api
Steps to reproduce
see above
Expected behavior
Login to Cloudflare
Get a token
Enable all wrangler functions to work
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
eric@NUC:~/projects/chat-project/api$ npx wrangler login
▲ [WARNING] Using "CF_API_KEY" environment variable. This is deprecated. Please use "CLOUDFLARE_API_KEY", instead.
⛅ wrangler 2.2.1 (update available 2.4.2)
Attempting to login via OAuth...
Opening a link in your default browser: https://dash.cloudflare.com/oauth..........................
Successfully logged in.
Platform
Version = 1.67.0
Hash = 3f0da22fd4d64ee969b596d789da2142b5d54de9
WebContainer = 79ba5d6ed4650f43d3d2f1721ce6e5bef04fff66

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 107
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 109864392,
  "usedJSHeapSize": 106762540,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
No response

:wave: Thanks for the report. I can't access the repo you're linking, could you re-create it or make some reproduction public?

I think the login currently doesn't work from the terminal because it depends on a redirect to localhost which doesn't work as there is no server running on localhost. We need to discuss how we can allow logging in to Cloudflare via the terminal.

:wave: We're closing this due to inactivity. Please, feel free to open a new one if you're still encountering any errors.


Simple Video

First of all thanks for the awesome module.  I need some help with autoplaying,muting, looping  the video and hiding the controls.
Here is what i'm trying to do
http://plnkr.co/edit/I2LZ5skKB96Pphl2d3fF?p=preview

I have updated the demo, now it works in desktop  chrome and firefox, In IE9 its not working.
Ipad  autoplaying is not working

Autoplay won't work on iPad since it's required a user action (click over the video or a button that triggers play). Also, with a bug that is going to be solved very soon, I hope in the next release for the next weekend.
IE9 support is tricky, since I don't have any way to test on IE9 currently, so any help is welcome.

Closing this since there are no feedback.


Html formatted data, is rendered as raw data.

When Json data is html encoded it is rendered as raw data.
eg. if Name if formated as Mohit
then instead of rendering as Link it is rendered as it is

I would recommend creating a custom component to display the data as desired. Please see Customization documentation for more information on this.
I'm going to close this one for now but please feel free to open a new issue if any problems are encountered. 👍


Hard to discern point features in Rapid Assist

I have Rapid Assist enabled and chose the address dataset in Alexandria, VA. The selected point feature is highlighted with a yellow dashed circle which is not very distinct next to the yellow address point. Could we:

Choose a different colour to highlight the currently selected feature?
Could we enlarge the selected point to make it easier to see which one is selected OR auto-zoom to the selected point. With auto-zoom the user could zoom out again if desired, but would automatically be taken to a more suitable zoom level after choosing the address.

See image below. It is quite hard to tell which address is selected.

1. Choose a different colour to highlight the currently selected feature?

yeah this is #813 , sort of..
I agree, I'd like to improve the styling of the selection halos.
When we converted from the old svg/d3 renderer, we also lost out on having that pulsing animation - it's something I'd like to reimplement to make things easier to see.

2. Could we enlarge the selected point to make it easier to see which one is selected OR auto-zoom to the selected point. With auto-zoom the user could zoom out again if desired, but would automatically be taken to a more suitable zoom level after choosing the address.

For this, you can also try the Z key to zoom in on whatever is selected - then pressing Z again will zoom back out to where you were before.

Yes this definitely closely related to #813.
The pulsating animation would help big time. I wonder if you could also draw attention to the highlighted feature by lowering the opacity of all other features in the assist layer. If that's not graphically intensive, it'd be a nice visual cue in addition to any colour changes.
Thanks for the Z hotkey tip. I don't think I have used it in Rapid before.


Toggle Cooldowns

dumping NeP.DSL.Get("toggle")(nil, "coodowns") will always return false.
Hotkeys not working too.

/dump NeP.DSL.Get("toggle")(nil, "cooldowns")

Cooldown dont seem to work for me with the newest version, the value dumps to true

nvm fixed it - the NerdPack-DarkN-CR is using the old "modifiers"


Added configuration option reportTestsIndividually.

Changes the test run report to show each it as a test in the passing and failing test count.
I have submitted a CLA

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

This was implemented in #370 as --verbose.


AMM Core Functionality

High Level Overview of Change
Adds AMM core functionality Instance Create, Deposit, Withdraw, Governance, and Auctioning.
Context of Change
Adds AMM Root Account, trustline for each IOU AMM token, trustline to track Liquidity Provider Tokens (LPT),
and directory entry to track all AMM's with different weights. Note that only equal weights are supported
in the first release. A new RPC method amm_info is added to fetch the pool and LPT balances.
Type of Change

[ x] New feature (non-breaking change which adds functionality)

Test Plan
AMM unit test is added to test AMM Create, Deposit, Withdraw, Swap.
Future Tasks
Add Number library to facilitate AMM equations coding and Payment Engine Integration.

I've reviewed the integration with Number and it looks good to me.

I've reviewed the integration with Number and it looks good to me.

Thanks for reviewing!

Closed, new PR is based on amm-core-functionality branch.


Refactor backoff

This new backoff strategy is more efficient than the previous one, which waited four seconds after just two retries. By using this updated approach, we can optimize retry behavior and reduce unnecessary delays. I think we can apply this strategy in other places to increase efficiency in waiting time. In syncpackage we use continuous polling in functions pollLatest and pollPending and waiting for constant time intervals instead we can use this backoff strategy to increase efficiency.


android: move liveliness log to main

Description: the liveliness CI tests for android are flaky because the response view holder doesn't log with high fidelity without UI interaction. This PR changes the logs to be printed in the main activity.
Risk Level: low
Testing: CI
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

thanks for fixing!


Use SignalR -pre Versions

I have SignalR running on a .Net Core Server, which does only support the v2.2.0-pre version.
Is there some way to get SwiftR working with -pre versions?

I haven't checked in a little while, but all the times I have tried to use .NET Core SignalR with SwiftR, using v2.2.0 in SwiftR still worked. Have you tried this?

As much as I know there is no 2.2.0 version for .NET Core but theres a 2.2.0-pre. Do you have any Reference on this? Or do you mean to use SwiftR with 2.2.0-pre?

I mean use v2.2.0 everywhere in SwiftR and just connect to the .NET Core SignalR server. That has worked for me in the past.

I already tried it like this, but I assumed that I had the error because of the version. So know I get a well known error: Error during negotiation request. I already set the connection.useWKWebView = false. Do you know any other possible mistakes?

I think @fhaussener refers to the new SignalR 1.0.0-alpha (https://dotnet.myget.org/feed/aspnetcore-ci-dev/package/nuget/Microsoft.AspNetCore.SignalR). As far as I can see by analyzing the server communication, the handshake changed and e.g. a Websocket is established directly by a 101 Switching Protocol. (See https://github.com/aspnet/SignalR/blob/dev/specs/TransportProtocols.md) There is no negotiation phase anymore, therefore this client won't be compatible with the new SignalR without some additional work.
Are there any plans to do this? The new JS client is out and could be integrated in this client as well. I would like to begin the work if someone could provide information where to start.

Did you update new version for working with SignalR 1.0.0-preview2-final in .NET core?


gitlab ci hang up

Hello
I am experiencing hang up in gitlab CI when using PUT method during unit test. It will work fine if I run the test in my local machine, but when it is already in gitlab CI, it seems the wiremock server doesn't respond. The curl perform is waiting forever.

Unless you provide us with a way to reproduce it on our machines (or some telemetry data explaining what's going on), I don't think we'll be able to troubleshoot the issue.

Unless you provide us with a way to reproduce it on our machines (or some telemetry data explaining what's going on), I don't think we'll be able to troubleshoot the issue.

https://github.com/LukeMathWalker/wiremock-rs/pull/118
Please use this Sample code and commit it into gitlab with CI enabled with tests setup in yml file.

GET and POST is working well, only PUT method that server doesn't respond

This is way beyond what I'm willing to do for resolving a bug report (for free) on this OSS project, I'm sorry.
The issue could be in GitLab, in the curl crate or in wiremock and it could easily take me hours to pin it down since I'm not familiar with the first two.


added custom metrics for read scenario

implemented logic to report custom k6 metrics based on response stats for instant and range queries

Can you please also add the metrics (+ the push metrics) to the README?

Can you please also add the metrics (+ the push metrics) to the README?

@chaudum  done

TotalLinesProcessed fro

It depends on customer needs... bytesProcessedPerSecond and linesProcessedPerSecond show us the speed of the Loki. TotalBytesProcessed and TotalLinesProcessed show the only amount of data that is processed during the query.
If you think that these two fields are useful, we can add them.
What do you think?

If you think that these two fields are useful, we can add them.

Yes, I think both metrics are useful.

thanks @chaudum


Invoker failling with error

After fixing #266 we started to have the following error on the invoker:
Picked up JAVA_TOOL_OPTIONS: -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap
[2018-07-31T12:56:30.381Z] [INFO] Slf4jLogger started
[2018-07-31T12:56:30.999Z] [INFO] [#tid_sid_unknown] [Config] environment set value for whisk.api.host.name
[2018-07-31T12:56:31.003Z] [INFO] [#tid_sid_unknown] [Config] environment set value for whisk.api.host.proto
[2018-07-31T12:56:31.005Z] [INFO] [#tid_sid_unknown] [Config] environment set value for whisk.api.host.port
[2018-07-31T12:56:31.006Z] [INFO] [#tid_sid_unknown] [Config] environment set value for zookeeper.hosts
[2018-07-31T12:56:31.006Z] [INFO] [#tid_sid_unknown] [Config] environment set value for runtimes.manifest
[2018-07-31T12:56:31.007Z] [INFO] [#tid_sid_unknown] [Config] environment set value for kafka.hosts
[2018-07-31T12:56:31.008Z] [INFO] [#tid_sid_unknown] [Config] environment set value for port
[2018-07-31T12:56:31.176Z] [INFO] [#tid_sid_unknown] [Invoker] Command line arguments parsed to yield CmdLineArgs(None,None,None)
[2018-07-31T12:56:31.179Z] [ERROR] [#tid_sid_invoker] [Invoker] Either --id or --uniqueName must be configured with correct values

It seems a parameter is missing somewhere, can anyone help?
Thanks.

Argh, sorry forgot to update.
We basically need to replay this commit: https://github.com/apache/incubator-openwhisk/commit/b197332e041968e98f6cec996e4a136116a90569 to the kubernetes repo. Want to open a PR on that? :)

Hi,
Thanks. Will try it now and make a PR.
Thanks.

Hi @markusthoemmes.
We tried but now we get the following error:
[ERROR] [#tid_sid_invoker] [Invoker] Error processing command line arguments List(--id, 554q8, --uniqueName, 554q8)

We changed the line on invoker.yaml to:
        command: [ "/bin/bash", "-c", "COMPONENT_NAME=$(hostname | cut -d'-' -f2) && tail -f /init.sh --id $COMPONENT_NAME --uniqueName $COMPONENT_NAME"]

This makes sense according to your commit correct?
Thanks.

Ok just checked your code and saw you have the following:
          parse(tail, c.copy(id = Some(id.toInt)))

We were not passing an int as the id.

@cduque89 Note how today the invoker is not passed an id at all. The only thing you need to do is pass INVOKER_NAME as the --uniqueName, since that's the only effective change of the PR.
The ID will be determined at runtime by registering to zookeeper with that uniqueName.

Ok perfect.
Will open a PR in the next couple of minutes.
Thanks for the help.


Add FastBuild UnityInputIsolateListFile support

I have had to update the unity test for FASTBuild to reflect the hash change.
I have also added a functional test to represent the functionality of isolating files from a unity build.

Merged, thanks!


[ENH] Clarify age search bounds

Is there an existing issue for this?

[X] I have searched the existing issues

New feature
No response
Unclear documentation
Are the bounds inclusive?

Thanks for the suggestion. We might address this together with some other docs issues in the future.


Make clearing the bookmark more robust

Addresses https://github.com/jotaen/klog/issues/66, where the removal of the previous bookmark failed but klog just swallowed the error. The error handling now explicitly checks for the expected error and fails in case something else goes wrong.

Doesn’t fix the issue unfortunately, but it’s a good chance in itself.


Include minify_css and minify_js in the public API

I haven’t finished adding them to the API for all of the different languages yet. Here’s what I have so far:

[x] Rust
[x] CLI
[ ] Node.js
[x] Python
[ ] Ruby

Fixes #66.

I took a look at creating bindings for Node.js and Ruby, but that code is too far over my head. To put things in perspective, I only started learning Rust less than a month ago, but I understand Rust much better than I understand JavaScript or Ruby.
That’s not to say that I’ll never finish this PR, just that I’m going to focus on something else for a while.

Hey, thanks for creating the PR and raising the issue. I think this is an interesting idea, but currently I'm against it for a few reasons:

The internal usage of the JS and CSS minifiers is an implementation detail, and exposing them would limit or complicate changing their usage/behaviour when beneficial or necessary. For example, esbuild has been replaced with minify-js, a JS minifier I wrote from scratch fully in Rust, which has different configuration, usages, semantics, rules, and output types.
The JS and CSS minification libraries are publically available and minify-html does not have much additional code when using them, so it's possible to easily import and use them alongside minify-html and we would not be providing much additional value.
We would probably need to also clone the API across all library variants and languages, and JS and CSS minification will most likely have far more complicated function signatures and usage patterns than minify-html. Consider all the deep configuration options, error handling, and threading, that must be exposed, tested, and described. It's already quite difficult to merely implement the current simple minify-html APIs in other languages, so this would be adding a lot more effort and complexity.
We'd most likely have to reimplement most if not all of the functionality of the libraries, and also track them regularly and provide frequent updates (including breaking version changes) even if nothing has changed with regards to the main functionality (HTML minification). From my experience with esbuild-lib, this is neither fun nor easy.

I'm going to close this PR and corresponding issue for now for housekeeping.


return 2 for emoji width in the 0x2300-0x1f000 range if ambw=double

On current implementation, emoji characters in range 0x2300-0x1f000 is not listed which return 2 from utf_char2cells(). I know this is compatible issue.
https://github.com/vim/vim/issues/665
https://github.com/vim/vim/commit/3848e00
https://github.com/vim/vim/commit/6a08454
Now, I'm thinking that user who got the compatible issue should set ambiwidth=single. So I suggest to return 2 for the emoji characters in the range 0x2300-0x1f000, if ambiwidth=double.
If you don't like this, I can make patch to add new option or detect locale string is CJK.

Yaruhiro wrote:

On current implementation, emoji characters in range 0x2300-0x1f000 is
not listed which return 2 from utf_char2cells(). I know this is
compatible issue.
https://github.com/vim/vim/issues/665
https://github.com/vim/vim/commit/3848e00
https://github.com/vim/vim/commit/6a08454
Now, I'm thinking that user who got the compatible issue should set
ambiwidth=single. So I suggest to return 2 for the emoji characters in
the range 0x2300-0x1f000, if ambiwidth=double.
If you don't like this, I can make patch to add new option or detect
locale string is CJK.

I get very confused about the 'emoji' option.  The docs say:
When on all Unicode emoji characters are considered to be full width.

But then it only applies to the characters in emoji_width, not
emoji_all.  Why doesn't it use emoji_all?
Then utf_ambiguous_width() returns true for all emoji characters, but
when 'amibwidth' is "double" this isn't taken into account.
So what should be the proper behavior?  Are there any characters in
emoji_all that are always single width?  The utf_ambiguous_width() needs
to be ajusted.
--
A fool learns from his mistakes, a wise man from someone else's.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I get very confused about the 'emoji' option.  The docs say:
When on all Unicode emoji characters are considered to be full width.
But then it only applies to the characters in emoji_width, not
emoji_all.  Why doesn't it use emoji_all?
Then utf_ambiguous_width() returns true for all emoji characters, but
when 'amibwidth' is "double" this isn't taken into account.

Please remember this thread on mailing list.
https://groups.google.com/forum/#!searchin/vim_dev/Arrow$20characters$20shouldn$27t$20be$20wide|sort:relevance/vim_dev/fu0ZZIx5gjk/2-MOLugwGgAJ
https://github.com/vim/vim/commit/6a08454

So what should be the proper behavior?  Are there any characters in emoji_all that are always single width?  The utf_ambiguous_width() needs to be ajusted.

Some of terminal still not be fixed to show emoji as square box. On such terminal, ↖ is drawn as narrow width. There are two types of terminal. One of them draw ↖ as narrow, Other one draw ↖ as wide. So we should provide way to switch them.
I thought for the way to fix this issue. And I guess the user who expect narrow width for ↖ should set ambiwidth=single.

However, I can not make sure that there are no side effects from my suggestion. So, if you do not like this change, I can prepare another option.

Yasuhiro wrote:

I get very confused about the 'emoji' option.  The docs say:
When on all Unicode emoji characters are considered to be full width.

But then it only applies to the characters in emoji_width, not
emoji_all.  Why doesn't it use emoji_all?
Then utf_ambiguous_width() returns true for all emoji characters, but
when 'amibwidth' is "double" this isn't taken into account.

Please remember this thread on mailing list.
https://groups.google.com/forum/#!searchin/vim_dev/Arrow$20characters$20shouldn$27t$20be$20wide|sort:relevance/vim_dev/fu0ZZIx5gjk/2-MOLugwGgAJ

That discussion was open ended.  And the help for the 'emoji' option is
wrong, it only applies to the characters in "emoji_width".
And the comment for it says "Emoji characters that don't have ambiguous
or double width".  Even though they are double width in the emoji
table...

https://github.com/vim/vim/commit/6a08454

So what should be the proper behavior?  Are there any characters in emoji_all that are always single width?  The utf_ambiguous_width() needs to be ajusted.

Some of terminal still not be fixed to show emoji as square box. On
such terminal, ↖ is drawn as narrow width. There are two types of
terminal. One of them draw ↖ as narrow, Other one draw ↖ as wide. So
we should provide way to switch them.
I thought for the way to fix this issue. And I guess the user who
expect narrow width for ↖ should set ambiwidth=single.

No, 'ambiwidth' has no relattion to emoji characters.  It's for another
group of characters.
Is it right to say that all emoji characters should be double width, but
in some fonts a subset is single width?
--
To be rich is not the end, but only a change of worries.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Is it right to say that all emoji characters should be double width, but
in some fonts a subset is single width?

Sorry, my idea is bad. you are right. So it can't define with single option emoji. How about following ideas to correct this issue.
new function to define widths
let cells = {
\ "2139",
\ "2194-2199",
\ ...
\}
call setwcwidth(cells)

load cell-width list file
:loadwcwidthfile /path/to/wcwidth.txt

Should be list as same as above func.
override wcwidth by dll/so
int
my_wcwidth(int c) {
  return /* my custom width */
}

or
int
my_wcwidth(const char fontname, int c) {
  return /* my custom width */
}

Is this PR going to be worked on or shall we close it?

I want still working on this.

Ref: https://github.com/vim/vim/commit/08aac3c6192f0103cb87e280270a32b50e653be1


Update howto-best-practices.md

Added guidance for configuration as code

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

cc @jimmyca15 @AlexandraKemperMS for review

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@zhenlan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

It looks like this PR is ready to merge--approved and updated based on feedback. Merging! Thanks, all.


[FEATURE] InputDateTime opens calendar with min/max month (if current month less/more)

🚀 Feature request
Describe the solution you'd like
If current month is less/more than min/max month in InputDateTime => make the first opening of calendar with min/max month.
BUT all subsequent click on calendar opens it with last opened month (as it was before).

We will also need to think about null as the max / min value. Now null breaks the component. Perhaps the default value should be set


updated tower (2.3.4-305-ab500cf4)

Thank you for the contribution. It was merged directly as 85123f83801a154fb452d070a50904cbcb57125d to keep commit history cleaner. Your contribution is still credited to you.