perform initial sync in parallel

run in parallel
log in sync function, we don't do any error handling besides logging anyway

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[X] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test release-test_istio

gencheck_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test analyze-tests_istio

unit-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test unit-tests_istio

lint_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test lint_istio

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test release-test_istio

gencheck_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Also concerned about starting 10k goroutines or something

I can do a rate-limit here.

I have some concerns about this. The current code is written with the assumption events are processed in serial. I don't know that it will break if we violate this assumption, but we need to be careful.

Maybe an integration test where we deploy echos before istio could sniff out issues.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-telemetry-k8s-tests_istio

integ-operator-controller-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-ipv6-k8s-tests_istio

release-test_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test release-test_istio

integ-distroless-k8s-tests_istio
7fdf8e56d446c41a16cfe59d2879de3a45bb1fa3
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
430103bb2a2588a076bb119cf18d90511575bf70
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

As @howardjohn said, we need to control the goroutines

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
430103bb2a2588a076bb119cf18d90511575bf70
link
/test unit-tests_istio

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
430103bb2a2588a076bb119cf18d90511575bf70
link
/test unit-tests_istio

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

lint_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test lint_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

gencheck_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

analyze-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test analyze-tests_istio

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

unit-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test unit-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-pilot-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test gencheck_istio

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

gencheck_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-security-k8s-tests_istio

release-test_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test release-test_istio

integ-distroless-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
0347a4f9e528e7cb231bc09aded09621ea668a12
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test gencheck_istio

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It may be useful for services and endpoints as we get the benefit parallelism in conversion functions. For node and pod may not be that beneficial as there is not much logic before it is put it in cache - infact for pods since podcache creates a lock it may not benefit at all.
Should we get some numbers and see how much it improves?

Unless the way I set up this benchmark is flawed, I don't think theres much to gain.
With 100 services, 200 endpoints/200 pods (did not set things up for nodes).

~/g/s/i/i/p/p/s/k/controller ❯❯❯ benchstat sync parallel
name                            old time/op  new time/op   delta
Controller_SyncAll/pod-12       17.2µs ± 2%  102.0µs ± 6%  +493.38%  (p=0.000 n=17+19)
Controller_SyncAll/endpoint-12   274µs ± 2%    165µs ± 7%   -39.80%  (p=0.000 n=18+20)
Controller_SyncAll/node-12      25.2ns ± 0%  136.0ns ± 1%  +439.33%  (p=0.000 n=18+17)
Controller_SyncAll/service-12   57.7µs ± 1%   84.5µs ±10%   +46.36%  (p=0.000 n=19+20)

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test gencheck_istio

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

lint_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

lint_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test lint_istio

gencheck_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
be8e1a505978f606ab16a85904333337bf6a13fe
link
/test unit-tests_istio

lint_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test lint_istio

gencheck_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test lint_istio

gencheck_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
ef09e90245790185d0f05967e87522153449ff63
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Error CREATE2 Deployer not present on Arthera Mainnet (chainId: 10242)

It's explained at Foundry CREATE2 tutorial which points to common deployer used by Foundry


"PV energy today" and "PV energy total" register missmatch

Hi Csongor,
at first i want to thank you very much, for your work here and also on Youtube. I'm one of your subscriber and have to say, i have learned a ton from what you do and explain... in an age of >55 ;-) Thank you man!
So now, i want to inform you there is a register mismatch and failure in the code For MIC-TL-X.
I do not get total- or today-energy values in mosquitto or influx. I've checked the register with the Growatt Inverter Modbus RTU Protocol V.1.2 and it says on the very first page:

Instruction: Register range for various types of inverter
TL-X (MIN Type): 03 register range:       0-124, 3000-3124; 04 register range: 3000-3124, 3125-3249
...
Storage (MIX Type): 03 register range:  0-124, 1000-1124; 04 register range: 0-124, 1000-1124
...

So, there is no input register type range (04)  0 - 124 in the MIC TL-X devices, only 3000-3124 also not even the (04) 3125-3249 range like the manual says.
your code: growattinterface.cpp:

modbusdata.energytoday = ((growattInterface.getResponseBuffer(53) << 16) | growattInterface.getResponseBuffer(54)) * 0.1;
modbusdata.energytotal = ((growattInterface.getResponseBuffer(55) << 16) | growattInterface.getResponseBuffer(56)) * 0.1;
modbusdata.totalworktime = ((growattInterface.getResponseBuffer(57) << 16) | growattInterface.getResponseBuffer(58)) * 0.5;
modbusdata.pv1energytoday = ((growattInterface.getResponseBuffer(59) << 16) | growattInterface.getResponseBuffer(60)) * 0.1;
modbusdata.pv1energytotal = ((growattInterface.getResponseBuffer(61) << 16) | growattInterface.getResponseBuffer(62)) * 0.1;

The Growatt RTU Protocol Description for MIC-TL-X input (04) registers says:
3053 | Epv_total H | PV energy total
3054 | Epv_total L  | PV energy total
3055 | Epv1_today H  | PV1 energy today
3056 | Epv1_today L  | PV1 energy today
3057 | Epv1_total H  | PV1 energy total
3058 | Epv1_total L   | PV1 energy total
Please, could you maybe check and correct this?
Greetings from Karlsruhe/Germany
Tom

Hi Tom,
I also have a MIC-TL-X and the code works just fine there. There is a naming convention in modbus that the input registers are always number from 3000 and the holding registers from 4000 (or the other way around, I can never remember). This is done so when you look at the number you can immediately tell if it is a holding or input register. But in all the modbus software I used and also in the arduino library, you provide the address from the base 3000 or 4000. So what is addres 3000 in the documentation, in the program that is zero.
As I said this code is reading my small MIC 750 and it is fine.

What you write makes perfect sense, but various totay and total values are still mixed up. Take a look above.
What irritates me now is that I can read out the total and today data via the 3049 with my own nodered flow (attachment) over an waveshare modbus-wlan converter. But not with this esp-script and your Grafana dashboard. All other data are coming in.

I have checked the mqtt-mousquitto log file. {"fields":{"deratingmode":0,"energytoday":0,"energytotal":0.9,"faultbitcode":0,"faultcode":0,"gridfrequency":49.99,"gridvoltage":227.2,"ipf":20000,"opfullpowe r":0,"outputpower":21.5,"pv1current":0.3,"pv1energytoday":0,"pv1energytotal":0.9,"pv1power":22.1,"pv1voltage":58,"pv2current":0,"pv2energytoday":0,"pv2energyt otal":0,"pv2power":0,"pv2voltage":0,"realoppercent":0,"solarpower":22.1,"status":1,"tempboost":0,"tempinverter":26.5,"tempipm":26.5,"totalworktime":165833.5," warningbitcode":0},"name":"mqtt_consumer","tags":{"host":"raspberrypi","topic":"growatt600/data"},"timestamp":1700298901}
Any ideas?

Hi Csongor,
i have checked it now multiple times. I am very sorry, also because i know that you have much more knowledge of the matter than i do. I have to say your code is not using the correct registers for the TL-X Series, because you've used the wrong register list documentation.

There is a naming convention in modbus that the input registers are always number from 3000 and the holding registers from 4000

I noticed this for some manufactures (i believe the Eastron SDM630/230) with 3000x (for holding) and 4000x (for input), but now after my review i know it has nothing to do with this. These in the docmantation described 3000-registers are the right, real and only ones that worked correctly. You can't use register 0001 from a other device alternatively to the 3001 and so on. It is different address with different values in it, even when you get some values out of it and even many of them seems to be the right ones.
The documenatation (site no: 48) says it very clear: The input register for TL-X begins at 3000-3124, (3125...  right after the heading information:

Use for TL-X and TL-XH
and this means do not start at site no: 33 with input register no: 0. of an different device.  In many cases the register are kind identical, but a few are different and others do not even exists. If you use 0001 it will bemapped to 3001 or vice versa.

I say it again: there are no input-register 0-124 for MIC-TL-X described in the documentation.
One example (then i'm done here):
In growattInterface.cpp @line 82:

modbusdata.pv1energytoday = ((growattInterface.getResponseBuffer(59) << 16) | growattInterface.getResponseBuffer(60)) * 0.1;

Here you want to get value of "energy PV1 of actual day", like it is described in input-register list no. 59, right? But instead it reads (with, or without the internal mapping function) the register 3059 | Epv2_today. There is no PV2 in a MIC-TL-X. And that is the reason why i am getting no value.  I've found a few other mismatched addresses in your code. No question, it is a total mess what they have done in this documantation.

OK, I see the problem. The issue is that it will be very difficult to make code changes without having the actual device and testing how it works. Also I am not really sure what is the best way of making the code work for the "old" devices and the MIC-TL-X as well. Maybe this new mapping is something they will roll out for all new models in the future?

i have you send an email


I can't find my video's bottom controller like stop....

my code as follows:
  const video = site + movie.videoKey
    const pic = site + movie.coverKey

    if (!this.player) {
      setTimeout(() => {
        this.player = new DPlayer({
          container: document.getElementsByClassName('videoModal')[0],
          screenshot: true,
          autoplay: true,
          video: {
            url: video,
            pic: pic,
            thumbnails: pic
          }
        })
      }, 500)
    } else {
      if (this.player.video.currentSrc !== video) {
        this.player.switchVideo({
          url: video,
          autoplay: true,
          pic: pic,
          type: 'auto'
        })
      }
      this.player.play()
    }

but i can't find the video's bottom's tab

@fireairforce Could you please give us a demo?
Codepen or JSbin or JSFiddle please

I solved this question by adjusting my css....


[Improvement] We should use buffer method instead heapBuffer

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
Spark code use buffer instead heapBuffer.

How should we improve?
We should use buffer method instead heapBuffer
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

cc @maobaolong

I think it should be ByteBuf header = ctx.alloc().directBuffer(headerLength);


Bad Authentication data. Unauthorized on remote side. Status: 404.With empty response

Hi,
I'm using ConnectyCube.users.signup(userProfile)
const userProfile = {
    login: "test.user",
    password: "12345678",
    email<EMAIL_ADDRESS>    full_name: "Test User",
  };

and the account is created successfully.
I'm trying to login with the account created but i'm receiving error code 422 "Bad Authentication data. Unauthorized on remote side. Status: 404.With empty response".
const userCredentials = { login: "test.user", password: "12345678" };
ConnectyCube.login(userCredentials)
.then((user) => {
     console.log("success")
 })
.catch((error) => {
    console.log("failed")
 });

can anyone help me solving this issue ?
Thank you guys.

@abdallahasswad did you enable custom identity provider?
https://developers.connectycube.com/guides/custom-identity-provider
seems yes
If you are using it then you do not need to sign up the users
Just use a login, and the credentials will be validated against your external user base

@DaveLomber
i've checked my ConnectyCube account and custom identity provider is enabled.
i've enabling it before just to test something but actually i never use it.
My problem was solved after disabling it.
Thank you.


Does it support exporting dynamic batches?

Hello author, I have reviewed your project and found that the input batch dimension is fixed. How can I support dynamic batch?

sorry


devcontainer: Install clang sanitizer runtimes

Clang sanitizers require "compiler-rt" runtime libraries (https://compiler-rt.llvm.org/).
Fedora packages those separately as compiler-rt.

add compiler-rt
split the lines to make the list installed stuff easier to read

Release kicked off in https://github.com/python/cpython-devcontainers/actions/runs/11389125670 .


generated documentation for Option type and reverting a minor change in script

Current coverage is 51.62%

Merging #227 into master will not affect coverage as of fa7c2c1

@@            master    #227   diff @@
======================================
  Files           40      40
  Stmts         3911    3911
  Branches       362     362
  Methods
======================================
  Hit           2019    2019
  Partial        119     119
  Missed        1773    1773

Review entire Coverage Diff as of fa7c2c1

Powered by Codecov. Updated on successful CI builds.

LGTM


Client always set restake to true unless --no-restake flag is provided

Bug Description
Client always assumes that restake is true unless user specifically doesn't provide --no-restake flag in every command.
Steps to Reproduce
Set the stake with flag --no-restake so that rewards are not restaked.
Send another command to increase the stake but don't provide a flag for restaking.
Expected Result
Stake should be increased and rewards should not be restaked.
Actual Result
Stake was increased but rewards are restaked.
Versions

Software Version: concordium-client_4.0.0-delegation-test-1

Addressed in 4.0.1.


Won't build with Ollama

Describe the bug
Svelte (@latest) frontend importing ollama runs just fine in dev but when I try to build I get the following errors:
error during build:
RollupError: [vite-plugin-sveltekit-compile] node_modules/ollama/dist/index.js (11:13): "promises" is not exported by "__vite-browser-external", imported by "node_modules/ollama/dist/index.js".
Then further down I get (fulll output is below):
import { createHash } from 'crypto';
at getRollupError (file:///vercel/path0/node_modules/rollup/dist/es/shared/parseAst.js:376:41)
at error (file:///vercel/path0/node_modules/rollup/dist/es/shared/parseAst.js:372:42)
at Module.error (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:13654:16)
at Module.traceVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:14102:29)
at ModuleScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:11805:39)
at ChildScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ClassBodyScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ChildScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ChildScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at FunctionScope.findVariable (file:///vercel/path0/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
Error: Command "npm run build" exited with 1
I had a quick look at the @node_modules/ollama/dist/index.javascript" file and didn't see any warnings etc.
Anyone know how to get round this?
I flagged this as "blocking all usage of svelte" but actually it's only blocking deployment.
Cheers
Full build output:
vite v5.1.6 building SSR bundle for production...
✓ 92 modules transformed.
vite v5.1.6 building for production...
[plugin:vite:resolve] [plugin vite:resolve] Module "fs" has been externalized for browser compatibility, imported by "/Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "path" has been externalized for browser compatibility, imported by "/Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "crypto" has been externalized for browser compatibility, imported by "/Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
[plugin:vite:resolve] [plugin vite:resolve] Module "os" has been externalized for browser compatibility, imported by "/Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.
✓ 86 modules transformed.
x Build failed in 356ms
x Build failed in 996ms
error during build:
RollupError: [vite-plugin-sveltekit-compile] node_modules/ollama/dist/index.js (11:13): "promises" is not exported by "__vite-browser-external", imported by "node_modules/ollama/dist/index.js".
file: /Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js:11:13
9: };
10: import * as utils from './utils.js';
11: import fs, { promises, createReadStream } from 'fs';
^
12: import { join, resolve, dirname } from 'path';
13: import { createHash } from 'crypto';
file: /Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/ollama/dist/index.js:11:13
9: };
10: import * as utils from './utils.js';
11: import fs, { promises, createReadStream } from 'fs';
^
12: import { join, resolve, dirname } from 'path';
13: import { createHash } from 'crypto';
at getRollupError (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/parseAst.js:376:41)
at error (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/parseAst.js:372:42)
at Module.error (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:13654:16)
at Module.traceVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:14102:29)
at ModuleScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:11805:39)
at ChildScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ClassBodyScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ChildScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at ChildScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
at FunctionScope.findVariable (file:///Users/mdh/Desktop/SvelteKit-AI-FE/node_modules/rollup/dist/es/shared/node-entry.js:6019:38)
Reproduction
I'm off out in 5, will stick something up on GH later tonight or tomorrow morning...
Logs
No response
System Info
System:
    OS: macOS 14.3.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 16.25 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - /usr/local/bin/node
    npm: 10.2.4 - /usr/local/bin/npm
  Browsers:
    Chrome: 122.0.6261.129
    Chrome Canary: 122.0.6255.0
    Safari: 17.3.1
  npmPackages:
    svelte: ^4.2.7 => 4.2.12

Severity
blocking all usage of svelte

@Mark2M reminder that we need a proper reproduction in the form of a git repo to investigate and fix the issue. Otherwise it'll be closed.

Here you go...  https://github.com/Mark2M/sk-ollama-test
It'll work in dev, if you're running Ollama with tinillama you can even click the button and get a response, it just won't build.
Also note that I tried Ollama with remix and that produced the same error.
Cheers

Seems like you should be using the ollama/browser endpoint https://github.com/ollama/ollama-js#browser-usage

That sorted it, thanks very much.
Just had to change my imports from "ollama"to "ollama/browser".

Works as expected, thanks again


Redirect from within middleware

I want to redirect from within my own middleware by dispatching 'goto', but it doesn't seem to work. I see within your code you do some hacky stuff to get around this in your preload middleware, but I don't have access to that in my middleware. Maybe you could apply the user supplied middleware 'before' applying reduxRouter store enhancer, but keep applying your preload middleware after it?

I want to redirect from within my own middleware by dispatching 'goto'

How exactly

but it doesn't seem to work

How exactly

I wrote some middleware like this, that I pass in the redux_middleware parameter to react-isomorphis render:
import _ from 'lodash';

import { logout } from '../modules/authentication.js';
import { goto } from 'react-isomorphic-render/redux';

export default function logoutMiddleware() {
  return ({ dispatch, getState }) => next => action => {
    // Check for api errors related to authorization
    if (_.endsWith(action.type, '_FAIL')) {
      if (_.includes([419, 403, 401], action.error.status)) {
        console.log('TIME TO GO HOME', goto('/'));
        setTimeout(() => {
          dispatch(logout());
        }, 1000);
        dispatch(goto('/'));
      }
    }
    return next(action);
  };
}

When I watch the dispatched action, I only ever see the API_HISTORY action, but not ROUTER_CHANGED action. So the page doesn't actually change.

Which API_HISTORY action exactly do you see.

If there's no ROUTER_DID_CHANGE then it could be that API_HISTORY action never gets to historyMiddleware.
If you feel like editing raw javascript then you could add some console.logs to node_modules/redux-router/lib/historyMiddleware to get a peek inside the whole pipeline.

I see within your code you do some hacky stuff to get around this in your preload middleware

I don't know about anything hacky there

I see this one coming from the middleware:
{
  type:"@@reduxReactRouter/historyAPI",
  method:"push",
  args:
    0:"/"
}

When I dispatch goto from a component click for example, I see this action:
{
  type:"@@reduxReactRouter/routerDidChange",
  routes: ...
  params: ...
  location: ...
  components: ...
}

By the "hacky stuff" I was referring to your comment in line 206 of preloading middleware.js:
Because preloading_middleware is applied to the store
before reduxReactRouter store enhancer adds its own middleware,
then it means that standard dispatch of preloading_middleware
won't send actions to that reduxReactRouter middleware,
therefore using this dispatch_event function to hack around that.

This action
{
  type:"@@reduxReactRouter/historyAPI",
  method:"push",
  args:
    0:"/"
}

Means that a redirect is requested. When this action gets to historyMIddleware of redux-router then it does history.push.
Then a history listener (in redux-router) calls routerDidChange() which dispatches a ROUTER_DID_CHANGE action, which, upon arrival to the last middleware, renders the new route.

By the "hacky stuff" I was referring to your comment in line 206 of preloading middleware.js

Oh, yes, Redux'es createStore gets called with the middleware_chain, and then another createStore gets called, and those are like independent layers with no peeking into each other. I guess, sort of. Maybe that's how Redux works.
Well, that could be a point.
I guess, that might be it: HISTORY_API action not being dispatched to historyMiddleware because it's in a different Redux layer.
So, what about that ROUTER_DID_CHANGE?
Post the full content of this action. Does it correspond to the HISTORY_API action? If it does, then this is not the "layers" thing.

Yes that makes sense, but I think the dispatch being passed to the middleware is not connected to the redux-router history listener since the middleware is applied before the history listener is attached. I think that's what you are saying in that comment I pasted above.

Yes that makes sense, but I think the dispatch being passed to the middleware is not connected to the redux-router history listener since the middleware is applied before the history listener is attached. I think that's what you are saying in that comment I pasted above.

Yes, that can be checked by inspecting that ROUTER_DID_CHANGE action.

The ROUTER_DID_CHANGE event is not getting fired at all from the middleware. I was just posting it for reference - when things are working correctly, I see the ROUTER_DID_CHANGE action.
I think you are right about the redux layers thing, but I think 'inner' layers can access stuff from 'outer' layers. So if you run applyMiddleware(myMiddleware)(reduxReactRouter()(create_store)), then myMiddleware dispatch will hit the reduxRouter history listener. But if you run reduxReactRouter()(applyMiddleware(myMiddleware)(create_store)), then myMiddleware dispatched actions don't hit the listener.
However I don't think you can flip this for your preloadMiddleware, because that one is depending on the history event already being transformed by reduxRouter. But you could flip it for user supplied middleware. So end up with something like this:
applyMiddleware(preloadMiddleware, reduxReactRouter()(applyMiddleware(userMiddleware)(create_store)))

Yeah, I guess, that could be a viable idea...
Not so keen on all that "store enhancers" thing.

I'll do some reading and also some experiments and post back

Sounds good, great picture.

Ok, your proposed approach seems to be working.
Try the latest version.
redux_middleware now always takes an empty array, because that middleware is applied on a different level than preloading middleware.
I tested it in my sample project and goto worked for me.

This is working great, thanks

Hi Again,
There was an unintended side effect of this change, I will describe here.
Now when I dispatch actions from within a preload function (run by the preloading middleware during a route change), the dispatched actions do not hit my middleware provided in redux_middleware. I can fix this by changing line 232 of preloading middleware.js to use dispatch_event instead of dispatch, like this:
(current, dispatched events in preloader don't hit user middleware)
const preload = preloader(server, components, getState, dispatch, location, params)
(new, dispatched events in preloader do hit user middleware)
const preload = preloader(server, components, getState, dispatch_event, location, params)
I can't think of any reason not to make this change - but maybe you can.
Let me know what you think, thanks!

Oh, yeah, so tricky...
I've made the change you pointed out and I agree on this being a suitable solution.
Guess it will work now. Try the latest version.

Hey Again,
So sorry to keep bothering you on this... but another slight issue with middleware composition.
When the asynchronous middleware is dispatching actions related to api calls (like GET_SOMETHING, GET_SOMETHING_SUCCESS, GET_SOMETHING_FAIL), those calls are not hitting the user defined middleware. I think this could be solved by either:

Passing in a dispatch_event argument to asynchronous middleware, the same way you do for preloading_middleware, and use that function for dispatching actions.
Apply the asynchronous middleware in the same place you are applying the user middleware. It doesn't depend on the reduxRouter stuff being loaded so that should be ok.

Let me know what you think...

Oh, another gotcha.
I think variant #1 is the most consistent one considering the workarounds
already implemented.
I'll release the fix when i get home
On Friday, July 29, 2016, adailey14<EMAIL_ADDRESS>wrote:

Hey Again,
So sorry to keep bothering you on this... but another slight issue with
middleware composition.
When the asynchronous middleware is dispatching actions related to api
calls (like GET_SOMETHING, GET_SOMETHING_SUCCESS, GET_SOMETHING_FAIL),
those calls are not hitting the user defined middleware. I think this could
be solved by either:

Passing in a dispatch_event argument to asynchronous middleware,
the same way you do for preloading_middleware, and use that function for
dispatching actions.
Apply the asynchronous middleware in the same place you are
applying the user middleware. It doesn't depend on the reduxRouter stuff
being loaded so that should be ok.

Let me know what you think...
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/halt-hammerzeit/react-isomorphic-render/issues/7#issuecomment-236197762,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdH78WaZ_VLBlR1ZbvUlf1GwLxxncR2ks5qahAsgaJpZM4JWmrz
.

Oh, actually, turns out there is no .dispatch() in asynchronous middleware at all.
Everything is dispatched by calling next(...) which obviously just moves those events further the middleware chain, not though all the chain again.
I guess I'll substitute those next(...) calls with dispatch_event.
Try the new version, seems to be working.

Thanks, this is working.
One more thing I found, that is tricky:
That logoutMiddleware I pasted in above in this thread ends up not working well within the server side render. The dispatch(goto('/')) call is throwing an error and expecting that error to bubble up to the top of the render function (see line 152 of redux/store.js in this project).
But in my case I am calling dispatch(goto('/')) within the failure event of asynchronous middleware (see line 108 of asynchronous middleware.js). Since that call is already within a promise body, when it throws the redirect error, then I guess nothing happens (the promise neither resolves nor rejects). So the redirect doesn't happen and any code waiting on that promise never runs.
I'm not sure how to fix this, maybe instead of throwing an error, the redirect handlers could be hooked up directly to some redirection logic in render.

I have just tried creating a middleware with redirection on a certain _FAIL event and it worked for me.

	redux_middleware(middleware)
	{
		return [({ dispatch, getState }) => next => action => {
			// Check for api errors related to authorization
		console.log('########### action', action)
			// if (action.events && action.events[0] === 'retrieving users') {
			if (action.type === 'deleting user failed') {
				console.log('~~~ deleting user failed ~~~')
				return dispatch(redirect('/logs'))
			}
			return next(action)
		}]
	},

Why aren't you returning after dispatching a redirect in your code?

Oh, that was client-side by the way.
Didn't test it on the server.
I'll try if it works for me on the server side.
On Sunday, July 31, 2016, adailey14<EMAIL_ADDRESS>wrote:

Thanks, this is working.
One more thing I found, that is tricky:
That logoutMiddleware I pasted in above in this thread ends up not working
well within the server side render. The dispatch(goto('/')) call is
throwing an error and expecting that error to bubble up to the top of the
render function (see line 152 of redux/store.js in this project).
But in my case I am calling dispatch(goto('/')) within the failure event
of asynchronous middleware (see line 108 of asynchronous middleware.js).
Since that call is already within a promise body, when it throws the
redirect error, then I guess nothing happens (the promise neither resolves
nor rejects). So the redirect doesn't happen and any code waiting on that
promise never runs.
I'm not sure how to fix this, maybe instead of throwing an error, the
redirect handlers could be hooked up directly to some redirection logic in
render.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/halt-hammerzeit/react-isomorphic-render/issues/7#issuecomment-236434429,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdH729b0nIgQeYav6EEAraLzd__G_5sks5qbLeXgaJpZM4JWmrz
.

@adailey14 Phew, okay, I managed to reproduce that.
Indeed, client-side worked as expected but server side didn't.
The cause was the Promise chain in asynchronous_middleware: it just didn't rethrow an error for some reason.
I rewrote that promise chain a little differently and now it works.
Try the latest version.

By the way, there's also on_error handler which you could possibly use alternatively to catching _FAILs in a middleware:
// Is called when an error happens on the server side
  // (can redirect to special "500 Error" pages).
  // If this error handler is defined then it must handle
  // all errors it gets (or just re`throw` them).
  on_error: (error, { url, redirect }) => redirect(`/error?url=${encode(url)}&error=${error.code}`)

I meant this one:
  // (optional)
  // Handles errors occurring inside `@preload()`.
  // For example, if `@preload()` throws a `new Error("Unauthorized")`,
  // then a redirect to "/unauthorized" page can be made here.
  // If this error handler is defined then it must handle
  // all errors it gets (or just re`throw` them).
  on_preload_error: (error, { url, redirect }) => redirect(`/error?url=${encode(url)}&error=${error.code}`)

Thanks I will try it out. Yes I am using the on_preload_error, but I also want to catch any api errors I have after a page is loaded (for example if an authentication token expires while the page is open for a long time, and the user clicks a button that calls the api).
I know this was a tricky one, I was doing all of my testing on it on the client side and everything was fine, then got caught by the different redirect behavior on the server. Glad you were able to reproduce it.


IOS - Picture is not displayed after using camera to update avatar - reported by @chauchausoup

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login
Navigate to Settings > Profile
Click on avatar to change profile pic
Select upload from Camera
Take a photo

Expected Result:
Picture should display after taking
Actual Result:
Camera popup is not appearing full screen
Workaround:
unknown
Platform:

Where is this issue occurring?

iOS

Version Number: 1.2.4-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/191661779-3f08c974-4b7c-46c6-9860-026e46228538.MP4
Expensify/Expensify Issue URL:
Issue reported by: @chauchausoup
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662272938247309
View all open jobs on GitHub

@JmillsExpensify actually the proper Bug description as per Slack thread is :
Whenever I try to take image for profile pic section via camera, I get a non full screen pop up  of camera interface rather than a full screen camera interface which I see in other standard apps.

Gotcha, so this is more of a product/design preference. I wouldn't call this a bug. I personally think this is fine and not a priority, so I'm included to close this issue. Further, we're going to redo this entire flow soon. Curious if you agree on closing @shawnborton @michelle-thompson?

Yeah, I agree with that. @Gonals @roryabraham, aren't we going to rip out this camera component and use a new one when we get to the Scan Receipts project as well?

Yeah, I think we can close this one personally. I agree that once we build our own camera system, we'd just reuse that here.

Awesome, thanks! Closing.

aren't we going to rip out this camera component and use a new one when we get to the Scan Receipts project as well?

Not confirmed, but I think there's a good chance we might use https://mrousavy.com/react-native-vision-camera/


Backend pytorch logging mistake when config.amp_autocast is True.

We should make logging for config.amp_dtype when config.amp_autocast is True since self.amp_dtype is not set yet.

nice catch! I'll merge it rn.


Remaining Samples Csv file not available

Hello, I am trying to study Bayesian Optimization based on the code you have provided, however, the "'remaining_samples.csv'" file is not available in the directory. Is it possible to upload it? Thank you

First, please run "sample_program_05_02_sample_selection.py". Then, "remaining_samples.csv" will be output.


Add gitsigns essential keymaps

An alternative attempt at including only the essential keymaps compared to the full list in: https://github.com/nvim-lua/kickstart.nvim/pull/740
Changes compared to the full list:

reduced the list of keymaps as suggested by @lewis6991 (the author of gitsigns):
https://github.com/nvim-lua/kickstart.nvim/pull/740#pullrequestreview-1948295290
simplified navigation keymap code - verified that it works also in diff mode, the only difference is a slight change in behaviour as gitsigns navigation does wrap-around while original diff mode does not. Also confirmed with @lewis6991 that it should work.
Added a note pointing to gitsigns README for the full list of keymaps

Compared to the original PR this one has about half the lines of code, hopefully this will make it more likely to be included.

LGTM but I'll defer to @tjdevries as I haven't had a problem with this stuff from jump, but can appreciate the desire to keep things small and understandable.

Hi!
Just wanted to mention what I did and ask if this might be a good option for you:
https://github.com/feoh/kickstart.nvim/commit/52722b7524b152fb77772ad968a54fc56a51ff50
If I install gitsigns like a regular old plugin, I get it in all its full fat goodness. Keymaps, configs. The whole enchilada.
Why not just do that? What am I missing? That way @tjdevries can get his super minimal starting point for new folks, and we can enjoy our luxurious git manipulating goodness in our forks? :)
Sorry if I'm missing something obvious, and in NO way do I mean to cut down the value of all your amazing contributions and work on this project.
You really have been an outstanding contributor, and I for one sincerely appreciate it!
Should you ever come to Boston, MA, USA. Please do look me up! I'd love to buy you a beverage or dinner or whatever :)

@feoh your suggestion works. But I think it's not clean that a plugin has the spec split into two files. Please open a PR with your solution so there are more options for TJ to pick from. It's not a question what works for me, I have the full enchilada no worries, the question is what is the best for the average or new Neovim user. I think a new Neovim user isn't necessarily a fresh developer, he can be an experienced developer looking for a new editor. A perfect example: DHH moving to Neovim: https://twitter.com/dhh/status/1764340531877105824
Anyway let's wait for @tjdevries feedback and we'll see.
And thanks for the kind words, I have no travel plans to US at the moment, but I'll keep it in mind :)

Just coming back to this in my usual PR check:
I don't know that generating a PR of my change is appropriate because my change has the gitsigns plugin installed in lua/custom/plugins which I think we'd prefer to reserve for end users to fill themselves :)

Gitsigns has just updated and next_hunk() and prev_hunk() has been deprecated. This is the commit with the new suggested way to do keymaps: https://github.com/lewis6991/gitsigns.nvim/commit/59bdc1851c7aba8a86ded87fe075ef6de499045c

Closed in favor of #858. Thanks for the hard work on this!


Create e2e for Task "Integrating Services into the Mesh"

Bookinfo injection, etc. Main work. Always done :)


Fix bug in _get_subset() when using require_all_on

This PR fixes the half-baked #207. See https://github.com/NCAR/intake-esm/issues/202#issuecomment-597325056 and https://github.com/NCAR/intake-esm/issues/202#issuecomment-597335795

@jbusecke, once you give a green light to this I will go ahead and merge it.

Looks great. Go for it!


Fragment

Added fragment struct
Basic implementation

LGTM, we could generalize
struct Fragment<T, MAX_DATA_LEN> {
  ...
  data: [T; MAX_DATA_LEN]
}


WRO-3893: Fixed React 18 Suspense sample content is not loading inside all-samples app

Enact-DCO-1.0-Signed-off-by: Stanca Pop<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Refactored React 18 Suspense sample content to load inside all-samples app. Replaced Panels with TabLayout. Removed unused classNames from React18 sampler file App.js.
Resolution
Additional Considerations
Links
WRO-3893
Comments

Travis build fails with the following error:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for steady-bienenstitch-c35b14 processing.

Name
Link

🔨 Latest commit
e7568258aca940ccccf53c2601c51e094d3e3cb1

🔍 Latest deploy log
https://app.netlify.com/sites/steady-bienenstitch-c35b14/deploys/63ef8b8ffe92030008e4c87a


Pass null arg to connect in container template

Original PR here: https://github.com/mxstbr/react-boilerplate/pull/891
Issue to resolve here: https://github.com/mxstbr/react-boilerplate/issues/971

Coverage remained the same at 98.942% when pulling 961fccc1a477f8cc090f9d4a7c5a66e8cf3999ce on tbash:null_connect_arg into 3cfb4b55292f3e1117530f2f9ac6bad67dcced21 on mxstbr:dev.

@tbash Thanks!


[impact4soil] which filters are applied when harvesting dataverse/zenodo by impact4soil

Emily will ask the developers which filters are used

Hello Paul,
The filter is this one: "soil AND organic AND carbon".


Should returning false rather than throwing an exception be better behaviour?

The code looks very good, but I think it is more useful if 'IsDefinedFast(string states)' returns false rather than throwing an exception. This means that if the string is not defined in the enum collection and we get back 'false' and can act on that in the if statement.
Here is my example:
// currently throws an exception (would be better if it returned false)
if (UserTypeTestEnumExtensions.IsDefinedFast("Gien"))
{
    System.Console.WriteLine("'Gien' is defined");
}
else
{
    System.Console.WriteLine("Not defined is 'Gien'");
}

Here is the pseudo code for what I am suggesting:

public static bool IsDefinedFast(string states)
{
    return states switch
    {
        nameof(UnitTests.UserTypeTest.Men) => true,
        nameof(UnitTests.UserTypeTest.Women) => true,
        nameof(UnitTests.UserTypeTest.None) => true,
        _ => false
    };
}

This is only for this specific scenario that I suggest returning false.
What do you think?

Hello, thank you for your participation.
I am very busy at the moment and cannot apply these changes. I will be happy if you can do it.

Thanks, that is really good. Will this be released as a package? v1.0.12 seems to be from may 31st.
Thanks again, this will be very useful.

Thanks, that is really good. Will this be released as a package? v1.0.12 seems to be from may 31st.
Thanks again, this will be very useful.

Yes, the version is finalized in 1.0.13. There should be no problem

I have tried 1.0.13 out. It works perfectly. Thanks again for making this change.


api changes

Hello,
In previous versions this worked<EMAIL_ADDRESS>and now only this works "@iconify/svelte"
What changed and how can i keep using the old style import?
Thanks

Try installing @iconify/svelte@next

no luck, i tried 3.1.6 and 4.0.0-beta.2 and i get the same error. Now i'm back on the original version in my project which is 2.2.1
    Error: Cannot import<EMAIL_ADDRESS>no matched export path was found in "pkg_name/package.json".

so yeah, i have no idea what happened like a week ago when this error first appeared ..

Should be fixed in 4.0.0-beta.3

is 4.0.0-beta.3 missing index.js? i'm having trouble importing from https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>

It no longer exists because it is not needed. Svelte uses .svelte file, that .js file was compiled for very old version of Svelte.
Correct usage is to import @iconify/svelte, which is pointing to dist/Icon.svelte.

Completely forgot about Svelte component. New version has been published as beta for almost half a year now.
Just published it as stable version 4.0.0. No changes since version 4.0.0-beta.3.
Importing from /dist/ won't work, newer versions of Svelte supports only .svelte files when importing components, not pre-compiled .js files. And by "newer" I mean versions released in last few years.
Imports that work: @iconify/svelte, @iconify/svelte/dist/Icon.svelte, @iconify/svelte/dist/OfflineIcon.svelte.
Importing from @iconify/svelte points to @iconify/svelte/dist/Icon.svelte.

@cyberalien not sure what changed between v3 and v4... but i cant install v4 under pnpm:
 ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In : "@iconify/types@workspace:^" is in the dependencies but no package named "@iconify/types" is present in the workspace
This error happened while installing the dependencies of<EMAIL_ADDRESS>
tried with pnpm v8 and v9 (8.14.3, 8.15.5, 8.15.7, 9.0.0, 9.0.6)
You might want to check for issues as the package also shows 0 downloads within npm

Sorry about that. Looks like I've published using npm instead of pnpm by accident. Re-published as 4.0.1


New Action: An assistant can search google

@Duncid what would you want here? the assistant to get access to a google result page or the assistant to process result. The former is fast the latter will be much slower.
Both possible.
We can obviously create such action as a top-level action but it can also be done by creating a dust app and enabling using dust apps as action.
In any case this will require a design for switching aciton setup between data sources and web search in the assistant builder?

Currently superseded by #1840 so that we can explore with Dust apps what is the right way to do internet retrieval.
We can reopen an issue to create a first-citizen internet search action once we have it working on converge using a Dust app


Left pane gets removed on clicking Escape Key

Describe the bug
The Left Pane gets removed on clicking ESC and not able to get back until the page refreshes.
To Reproduce
Steps to reproduce the behavior:

Click anywhere on the left pane
Click on 'ESC' key

Screenshots
If applicable, add screenshots to help explain your problem.
https://github.com/CarnegieLearningWeb/UpGrade/assets/49234788/0f1a793a-9349-4dc8-9986-34cdee443ad8

QA: Passed


Fix typo on use_cases page

and one o them is the so-called "sampling priority" -> and one of them is the so-called "sampling priority"

Gracias!


Missing video in docs "What are ARM templates?"

Azure documentation issue guidance
Thanks for opening an issue in the Azure technical documentation repository.
Source: https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/overview
Repo: https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-resource-manager/templates/overview.md
Issue:
The first video in this document 404's:

To learn about how you can get started with ARM templates, see the following video.
[!VIDEO https://learn.microsoft.com/Shows/Azure-Enablement/How-and-why-to-learn-about-ARM-templates/player]

title: Templates overview
description: Describes the benefits using Azure Resource Manager templates (ARM templates) for deployment of resources.
ms.topic: overview
ms.custom: devx-track-arm-template
ms.date: 07/05/2024

@uniQuk
Thanks for your feedback! We will investigate and update as appropriate.


Exception on import (enum type creation)

With capnp-{v0.5.0,v0.5.1,master}, and pycapnp-{v0.5.1,v0.5.0,develop} I get an error during import capnp.
Specifically:
>>> import capnp
terminate called after throwing an instance of 'kj::ExceptionImpl'
  what():  /usr/include/capnp/schema.h:840: failed: expected primitive != schema::Type::STRUCT && primitive != schema::Type::ENUM && primitive != schema::Type::INTERFACE && primitive != schema::Type::LIST
 ...
Aborted

Removing initializing types.Enum in capnp.pyx seems to solve the issue. Specifically, constructing a bare Type of schema::Type::ENUM doesn't seem to be supported by capnproto; rather it wants a concrete Enum. This hasn't been supported since  https://github.com/sandstorm-io/capnproto/commit/87ea5bdb04a02bfb0b09c40be55eb6524030333c#diff-93583ef7e9c5c392dc4f12098e0a8859R724 . I'm actually sorta confused as to how it ever worked.... maybe pycapnp has never been tested with a debug build of capnproto?
A trivial patch (https://gist.github.com/davidcarne/67da9b89e64067a21354) at least allows the import.
With that patch, addressbook.py works, but calculator_client.py doesn't seem to. That's probably another issue....

Hmm that's interesting since it's tested against C++ Cap'n Proto v0.5.2 and master and both seem to be working fine. What version of C++ Cap'n Proto do you have installed? What's your OS/architecture?
Separately, can you try yes | pip uninstall pycapnp; pip install --install-option '--force-bundled-libcapnp' pycapnp to see if it fixes your problem?

Oh sorry, I see now that you tried multiple version of libcapnp. Still, try the pip install with the force-bundle-libcapnp to see if it fixes it.

OS=linux/gentoo , Architecture=amd64
Using pip install --install-option '--force-bundled-libcapnp' pycapnp works, but the issue may worth a deeper look: I think the use of -O2 -NDEBUG in buildutils/build.py is masking a potential bug.
Just removing the -O2 -NDEBUG flags from the environ CXXFLAGS (in buildutils/build.py) causes the same behaviour mentioned above. If forcibly disabling the capnproto assertions is intentionally required for pycapnp rather than just as a speed optimization, please let me know and I'll close this issue (and then just force -NDEBUG in my ebuild).
In detail, the assertion/exception that triggers for me for hand-builds is KJ_IREQUIRE. KJ_IREQUIRE is only defined as something other than a noop when KJ_DEBUG is defined. bundled/capnproto-c++/src/kj/common.h define KJ_DEBUG (and therefore KJ_IREQUIRE) only for builds where no optimization level is specified, and where NDEBUG is not specified.

Ah ok, sorry, I didn't quite understand at first that it was due to you running a DEBUG build. It's been a while since I've tested pycapnp with a DEBUG build, but it's certainly intended to be working :)
I'll start on getting it working, and I'll add it to travisci so this doesn't diverge again.

Also, for what its worth, I think the way -O2 -NDEBUG is set in buildutils/build.py causes a difference in the CXXFLAGS for how pycapnp is built depending on whether a system capnproto is present

without system capnproto: both capnproto + pycapnp are built with -O2 -NDEBUG ${CXXFLAGS}
with system capnproto: pycapnp is built with system CXXFLAGS

Good catch, I'll fix that as well.

Ok this is fixed, and now being tested by travis, so hopefully I won't miss these sorts of issues again.
I'm not sure what the issue you're seeing with the calculator example is. Can you try running pip install pytest and py.test test from the pycapnp source directory?


Ignore email-like words

I'd like an option to be able to ignore email-like words, i.e. words that have a '@' somewhere in the text.
E.g<EMAIL_ADDRESS>"nick@", "@nick" should all be ignored
Rationale: emails are often not dictionary words, and in many contexts '@' marks a reference to a person's username.
It might be necessary to separate the email from the prefix/suffix '@', in order to support use cases like checking annotations in Java @Annotation.
Related to https://github.com/kamykn/spelunker.vim/issues/34

Hi, @nitnelave.
I've added a new option to the plugin to ignore words in email format.
" Disable email-like words checking. (default: 0)
let g:spelunker_disable_email_checking = 1

Could you please update the plugin and then try the new option!

Thanks, I'll give it a try!

So, it seems that the email style "bla@bla" is correctly ignored, but I still see "@bla" and "bla@" marked as misspelled.

I've never seen a situation where the @ is treated as a prefix or suffix pattern as an email. I didn't include them in this option because they are often used to represent account names on the websites.
I could add the option to exclude it as an account name, but it would exclude Java annotations as well. Spelunker.vim doesn't parse the text so it can't determine if it is an annotation or not.

Yes, the point is that most account names are not spelled correctly according to the plugin :)
As for the Java annotations, I'd add a note in the documentation with an autocmd showing how to disable the option locally for java.

@nitnelave
I've added a new option to the plugin to disable checking account name.
" Disable account name checking. (default: 0)
let g:spelunker_disable_account_name_checking = 1

Could you check the new option?

Thanks for the quick update! I'll check that tomorrow, I have to run.

Works like a charm! Thanks a lot for the quick responses, I really appreciate it :)


Problem with Table to Xlog converter, no event log: "loading port contents...", trace omitted

I have data which I attached. sample.csv
It contains event data. It looks like this:
case_id;activity;timestamp
1;53100;2017-04-07 00:00:00
1;53106;2017-04-07 00:00:00
1;90020;2017-06-14 00:00:00
1;53117;2017-06-14 00:00:00
1;60305;2017-07-11 00:00:00
1;58600;2017-07-12 00:00:00
1;58600;2017-07-12 00:00:00
1;68500;2017-07-12 00:00:00
2;53100;2017-06-23 00:00:00
2;58600;2017-06-23 00:00:00
...

It is sorted properly, so the missing time is not a problem for me.
The case activity are numbers here, however with KNIME I read it in and treat it as string, otherwise I would get an error.
There are no trace level attributes, so no additional column with for example costs that vary for each state nor is there an additional column for costs which are the same for an event. So just these three columns.

I have a KNIME workflow which I also attached (I had to zip it, otherwise I could not have attached it).
sample.zip

Basic idea is to:

use the csv reader to read in the data. I specify the csv reader to read in the activity as string.
I use the string to date&time converter to convert the timestamp column to a date&time value type.
Then I use the modify time zone node to get the format into the appropriate Zoned Date time format.
use the Table to Xlog converter to create an event log

And indeed, it looks fine so far, when I check the output of the third node, the modify time zone:

However, when I now try to configure and execute the last node, the Table to Xlog converter it does not work. I right click the Table to Xlog converter and click on configure. Then for "Case Id column" I choose case_id. For "Eventclass Column" I choose activity. For "Life Cycle Column" I choose not available. For  "Time Stamp Column" I choose timestamp. On the "Choose Attributes Set" tab I include everything, for trace attributes and event attributes:

When I execute the node I get the warning:

   Unmatch trace attribute values error is detected on the trace, therefore trace is omitted

And when I right click the node I get the messsage "display port content..." and nothing further happens.
I also tried to remove the trace attributes on the choose attribute set tab:

But it does not work, as I get the message:

Make sure the attribute set choice panel includes all the choices in the panel!

and I cannot execute the node.
So where is my mistake? Why is the event log not displayed properly?
I was able to create a xes file for this csv file in Python using PM4PY. When I import this xes directly with the xes reader I can see the event log and further use for example the Alpha Miner. So it seems to be a problem with the Table to Xlog converter or its configuration which I did not do correctly.

Dear HaraBeron,
You need to include the caseID in the list of trace attributes and both the eventID and timestamp in the list of event attributes. This means in your case: "case_id" in the list of trace attributes; "activity" and "timestamp" in the list of event attributes.
I hope this solves the issue!
Best regards,
Humam

Thanks a lot for the answer!
Yes, it solved the issue.


enable local cluster test in gh action

I believe this will run in series with existing rust tests, and thus will slow down CI times. Is is possible to just make a test target for this test so that it runs in the existing test step via cargo nextest run?

I believe this will run in series with existing rust tests, and thus will slow down CI times. Is is possible to just make a test target for this test so that it runs in the existing test step via cargo nextest run?

good question, I don't know yet. maybe we need to build a bridge by ourselves. cc rust guru @bmwill / @huitseeker


Opening of a alva file can be reverted with undo

Describe the bug
When Alva is opened with clicking on a Alva project file this can be reverted with cmd+z.
To Reproduce
Steps to reproduce the behavior:

Make sure that Alva is closed
Open a Alva project
Click Edit -> Undo or cmd+z
Now the window should be white

Expected behavior
The history should not include the opening of project files
Screenshots

Device (please complete the following information):

macOS 10.13.4
Current master (commit hash: 9c35fe53983)

fixed with #536


[BUG][DOC] API reference on sktime.utils module is wrong, outdated, confusing

@fkiraly update after discussion below (Apr 22):
The API reference page on the sktime.utils module is incorrect:
https://www.sktime.org/en/stable/api_reference/utils.html
Most of the functions aren't even there anymore.
This needs to be updated, preferably urgently.
What should be in the utilities section:

sktime.datatypes functionality convert, convert_to, check_is, check_raise for "data processing"
plotting, that's still in the utils module
check_estimator for manual testing
maybe some of the synthetic data generators, _make_series, _make_panel, _make_hierarchical (in utils) and get_examples (in datatypes)

Sources for this page are in docs/source/api_reference/utils

Describe the bug
I'm looking to work with sktime, but I can't seem to import any of the functions provided in the utils module.
To Reproduce
I created a brand new venv with sktime version 0.11.2.

python3 venv
pip install sktime

There were no issues the popped up during installation.
Environment
Linux pop-os 5.13.0-7620-generic Ubuntu  x86_64 x86_64 x86_64 GNU/Linux
When I go to import sktime.utils.from_nested_to_2d_array, I receive the following error:
AttributeError: module 'sktime.utils' has no attribute 'from_nested_to_2d_array'.
When I look at what attributes the module has, I get the following:

I'm looking to test an implementation of ROCKET using the sktime library, but I have been unsuccessful due to these module errors. Am I doing something incorrect?

@mccrinbc-ss, that function is not in the utils module since ages.
Also, dir(sktime.utils) should break unless you are in the wrong directory.
To me this sounds like a messed up installation?
I would suggest one of two things:

please post reproducible, self-contained code for your bug, e.g., when does rocket try to import this?
you can join one of the collab sessions tomorrow and we can have a look at your notebook or code

Re from_nested_to_2d_array, if you want that functionality use instead:
from sktime.datatypes import convert_to
convert_to(object, to="numpyflat")

Oh for real! I was trying to follow what is stated in the API reference for where functions are stored but I guess things have changed and the API reference is not up to date? Where can I find the most up-to-date API reference documentation? I see the following:

I was only attempting to import the function directly, so I never had and direct issues with ROCKET itself. Sorry for the confusion here.
The import statement you provided above works fine, so I assume that I have a working installation of sktime. These all seem to be very beginner mistakes :-) Thanks for the support!

Oh dear!! This is all wrong.
How is this still on the stable API page?
I verified and this page is outdated since probably half a year.
https://www.sktime.org/en/stable/api_reference/utils.html
I will change this issue into a docbug.

Where can I find the most up-to-date API reference documentation?

Apologies, it does not exist for this piece of functionality - the auto-generated API has not been updated with the move to the datatypes module that happend a while ago.
Until this is fixed (hopefully soon), you can use the docstrings. The content on this page should be as said above:

sktime.datatypes functionality convert, convert_to, check_is, check_raise for "data processing"
plotting, that's still in the utils module
check_estimator for manual testing
maybe some of the synthetic data generators, _make_series, _make_panel, _make_hierarchical (in utils) and get_examples (in datatypes)

For a tutorial on the functionality mentioned, you can consult this:
https://github.com/alan-turing-institute/sktime/blob/main/examples/AA_datatypes_and_datasets.ipynb

@aiwalter, perchance, is your upgrade of the automated doc generation here
https://github.com/alan-turing-institute/sktime/pull/2498
also going to fix this?

@mccrinbc-ss, I think I fixed this now: https://github.com/alan-turing-institute/sktime/pull/2703

Fantastic! Thanks for resolving this.


Fluentd prometheus metrics listens on 9533 instead 24231

Bugs should be filed for issues encountered whilst operating logging-operator.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors. #logging-operator
Please provide as much detail as possible.

Describe the bug:
It is expected that fluetd prometheus listener would listen on a default port of 24231 however, having deployed helm chart 4.4.1 fluentd listens on 9533 for metrics

this is with following fluentd image: ghcr.io/kube-logging/fluentd:v1.15-ruby3
Expected behaviour:
Expected to see fluentd listening on default 24231
Steps to reproduce the bug:
enable serviceMonitor on Logging
  fluentd:
    metrics:
      serviceMonitor: true

Additional context:
Add any other context about the problem here.
Environment details:

logging-operator version: 4.4.1 (helm chart)
Install method : fluxcd

/kind bug

Hi @marcin-je,
I have tried reproducing the issue with the following yaml file:
apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: quickstart
spec:
  controlNamespace: logging
  fluentd:
    disablePvc: true
    metrics:
      serviceMonitor: true

I've installed it using helm as well:
helm install --namespace logging --create-namespace logging-operator oci://ghcr.io/kube-logging/helm-charts/logging-operator --version=4.4.1

And executing kubectl get pod -n logging quickstart-fluentd-0 -o jsonpath='{.spec.containers[0].ports}' | jq yields:
[
  {
    "containerPort": 24240,
    "name": "fluent-input",
    "protocol": "TCP"
  },
  {
    "containerPort": 24231,
    "name": "monitor",
    "protocol": "TCP"
  }
]

Could you please try using the Helm chart without fluxcd? The helm chart is available here.
I am not that familiar with fluxcd, but it seems they might override the default port.

I also tried to reproduce, but same on my side. The configuration also contains the right port:
kubernetes view-secret -n logging quickstart-fluentd input.conf

# Enable RPC endpoint (this allows to trigger config reload without restart)
<system>
  rpc_endpoint <IP_ADDRESS>:24444
  log_level info
  workers 1
  root_dir /buffers
</system>

# Prometheus monitoring

<source>
    @type prometheus
    port 24231
</source>
<source>
    @type prometheus_monitor
</source>
<source>
    @type prometheus_output_monitor
</source>

Do you perhaps have more than one logging resources and looking at the wrong one?


tentative fixes for memory leaks (#86)

This PR contains a tentative solution for memory leak reported in #86. I quickly tested it in Instruments and it seems to work fine, but I didn't have time to test it with very complex cases.
Here's a summary of the changes:

MMDrawer files are ARC based, so I added the -fobjc-arc compiler flags for those.
Removed the custom close() method from the drawer view, since it should be handled by the proxy.
Added windowWillClose and windowDidClose methods for proper notification to the child window proxies.

working great.
can you please bump the version, build the module with a zip in the dist and add a changelog?
Thanks :+1:

No problem. Done

:+1:

sweet

Hi,
What is the command to clear the memory for the left drawer/center window. If i am using Alloy.
I am trying to figure this out, but I'm stuck.
Thanks,
Victor

Hi,
I figure this out.
Thanks,
Victor

@victsant What did you figure out?


command parsing needs to be case-insensitive

at the moment we only accept UPPER CASE commands, but specs state that MAIL == mail == MaiL, etc. There are easy str methods to solve this.

fixed by bdf776a23d8034c0897966c0298d7a1d65c58912


🧑💻(backend) add helpers to development lti form

Purpose
When we test the same resource both on instructor and student views, we
have to copy paste data on two different tabs.
Now, we display last 5 videos, documents, and meetings, and when we
click them, the form is filled with matching data.
Also, random resource_link_id, user_id, lis_result_sourcedid, and
lis_person_contact_email_primary are generated.
Lastly, the third form now opens a new tab, allowing us to easily
inspect the frontend app with react developer tools.
https://user-images.githubusercontent.com/720491/157286572-4ae07145-e456-449d-a183-0614e7449968.mp4

Once the tests fix I think it should be ok. Nice improvement +1

Thanks!
The tests are ok now, remaining fails are the usual ones :/


update

Codecov Report

Merging #25 into master will increase coverage by 1.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   68.21%   69.53%   +1.32%
==========================================
  Files          19       19
  Lines         151      151
  Branches       15       15
==========================================
+ Hits          103      105       +2
+ Misses         46       44       -2
  Partials        2        2

Impacted Files
Coverage Δ

angular/src/app/navpages/page1/page1.component.ts
100.00% <0.00%> (+50.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3774770...a0107f6. Read the comment docs.


Simplify Transform Implementation Where Possible

Summary
The Transform component is by far the most used component in Duality. Handling as many of them as possible while keeping performance impacts low is a priority. However, Transform currently carries some potentially costly logic that is rarely used, like calculating and updating velocity values. Investigate whether they can be removed, benchmark the results and compare them to previous benchmarks.
Analysis

Check if velocity calculations can be removed. Might actually work without too many drawbacks.
Check if change event delivery can be removed. Maybe not though - this could actually be quite useful, and RigidBody relies on this.
Investigate potential optimizations for non-moving Transform components, which are probably 90% of them.

Progress

Investigated velocity calculation removal and found that this isn't possible without drawbacks.

A very important distinction in transform changes is whether an object was moved or teleported there. This makes a difference for attached sounds and sound listeners, but there are probably other cases as well.
This distinction is completely lost when taking away velocity from Transform. So for now, it will need to stay.

Found no optimizations for non-moving transforms so far, except introducing an explicit IsStatic flag / property, which requires and extended design and is sort of a different issue.

Closing this issue for now as there's nothing much left to do within its scope. Open a new one when there's a more concrete design on static transforms, or other transform optimizations.