QueryExecuted event not dispatched

Laravel-mongodb Version: 5.1.0
PHP Version: 8.2.x
Database Driver & Version:

Description:
Steps to reproduce

Listen to QueryExecuted
Log the executed query

Expected behaviour
MongoDB driver should dispatch the QueryExecuted event when there's query executions
Actual behaviour
No query executed event dispatched
I'm using open-telemetry laravel auto instrumentation, and I noticed that the mongodb query not logged after I upgrade the driver version from 4.x to 5.1

In version 5 this event will be dispatched only if enableQueryLog is enabled for the connection.
Another problem occurs if you have 2 connections using the mongodb driver and EnableQueryLog is enabled for two of them. There will be 2 QueryExecuted events for one query
For example:
DB::connection('tenant')->enableQueryLog();
DB::connection('central')->enableQueryLog();

Site ::query()->count(); // dispatched 2 QueryExecuted

Is this expected ? I think the behavior is different when we're using another type of databases like MySQL or PostgreSQL in laravel

Sorry for the delay on this. There are two issues described in this ticket:
Issue number one is that no queries are logged. As explained earlier, this needs to be specifically enabled using DB::enableQueryLog or $connection->enableQueryLog(). This was done to fix a performance regression noted in #3166. Note that we don't recommend enabling this in production, both for performance reasons and to avoid logging potentially sensitive data.
Issue number two is that queries are duplicated when using multiple connections. This can occur when using two Laravel database connections that share the underlying connection to the MongoDB deployment. The details of this connection persistence are explained in the driver documentation, but in short, the following code only creates a single connection to the deployment:
$config = [...];
$conn1 = new Connection($config);
$conn2 = new Connection($config);

Since the query log is populated from APM callbacks initiated by the underlying connection, this connection reuse has a negative impact here. However, we don't want to completely disable is, as this connection persistence improves performance in typical PHP environments: while a PHP request is short-lived, the PHP process is kept alive for longer, and thus reusing connections can make requests faster.
I haave created #3197 to fix this and expect this to be released in a 5.1 patch release in the near future, but until then this particular issue can be worked around manually: make sure that the configuration passed to both connections is not identical. This can be accomplished by adding a unique driver option to each config:
[
    'connections' => [
        'tenant' => [
            'name' => 'mongodb',
            'driver' => 'mongodb',
            'dsn' => env('MONGODB_URI', 'mongodb://<IP_ADDRESS>/'),
            'database' => env('MONGODB_DATABASE', 'unittest'),
            'options' => [
                // driver_options is passed to the driver and used to determine connection reuse
                'driver_options' => ['connectionName' => 'tenant'],
            ],
        ],
        'central' => [
            'name' => 'mongodb',
            'driver' => 'mongodb',
            'dsn' => env('MONGODB_URI', 'mongodb://<IP_ADDRESS>/'),
            'database' => env('MONGODB_DATABASE', 'unittest'),
            'options' => [
                // driver_options is passed to the driver and used to determine connection reuse
                'driver_options' => ['connectionName' => 'central'],
            ],
        ],
    ],
];

The configuration above replicates what the PR will do out of the box in future. Since the two connections now have different driver options (containing a value that remains constant across multiple requests), two different connections to the MongoDB deployment are established, and the query log is properly separated. At the same time, this continues to leverage connection persistence and reuse across multiple requests.


Fix linix typo

I think that's not a typo. It's a deliberate mixture of the words linux and unix.

You give too much credit ;) I wasn't sure if I should say linux or unix there. Would one be more appropriate than the other? I never was 100% on what the proper name was for all the diversity of OSes in this family

How about "if you are on some linux/unix OS"? :smile:

That seems good :) This suggests that "linux" would cover all the tested cases I know of. I have no idea if our binaries work on FreeBSD. So I'm down to go with the current PR just to fix the initial typo.


Activity recognition stuck on "100% still" on Android O

Always on this state.
Not sure if it's because of the sample, or a bug on Android O.
Reported here too:
https://issuetracker.google.com/issues/65659441

I'll bring this to the attention of engineering. Looks like a bug to me.

As I wrote there, even on pre-Android-O, the results don't seem good.
On OnePlus 2 with Android 6.0.1, it had about 50% score for me driving, even though I was just walking...


Scheduled Report Policy - Monday Bug Fix

Description
Fixes an error in the date calculation for the daily/current metrics.
Issues Resolved
#176
#175
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger

1 Warning
⚠	Should this include readme changes
Generated by 🚫 Danger

Readme changes not required as functionality is unchanged.

Example of applied policy: https://governance.rightscale.com/org/78/projects/30206/applied-policies/5c59e3f089319400907c42b5


Modernized host name resolution to avoid memory leak.

The issue
The function grpc_gethostname returns a gpr_malloc'd char* and transfers ownership to the caller. I picked up a case where the caller does not free the returned string, nor stores it - a memory leak, albeit minor.
The remedy and motivation
There is a unique pointer class called grpc_core::UniquePtr<T> which uses the correct deallocator for gpr_malloc'd memory. This lets us transfer ownership and freeing (no pun intended :laughing: ) the caller from the responsibility of managing the memory.
Looking forward to feedback!

@veblush

We're trying to move away from UniquePtr<char>.  Instead, please change this function to return std::string.

Agree with avoiding UniquePtr - suggest absl::optionalstd::string however to indicate failure (or better StatusOr)
Would love to see this lifted into namespace grpc_core and renamed GetHostName while you're here!

Yeah, agreed, moving this to a C++-style API would be nice.  If you do that, please move the code from the gpr directory to the gprpp directory.  Thanks!

I can certainly do that. Look forward to an updated patch soon!

The API now uses absl::StatusOr. The code was not inside the gpr directory, so I did not move it to gprpp. A truly portable GetHostName implementation will take substantially more effort because of differences in gethostname across operating systems (and even libc implementations!).
With that being said, the error returned on an unsuccessful call to gethostname might be valuable to capture and report to the caller, possibly using perror to get a human readable cause of failure.

This has been waiting for an update for a while, so I'm going to close it.  Please let me know if you'd like to update it further, in which case we can reopen it.


Revisit how CPF works

Describe the issue
CPF Team and any new member of the team needs a guiding principle document to get an understanding of how we work and for the product/service we are building for Ministry teams.
Additional context

we aim for a presentation style format stored in Teams
https://digital.gov.bc.ca/resources/digital-principles
This might be used for a communication piece for dealing with our customers

Definition of done

Draft of the proposed explainer of how we work (Eg: We are working in the open so we assume anyone can get a hold of our material, we are also pathfinding and we have a fairly technical audience)
Meeting to discuss and define the 'how' of how we work

We need a list of docs that need to be updated as we publish this deck.

done


ManyToMany relationship fail when rendered as XLSX

Hi,
Unless I missed something obvious, when I tried to export using XLSX, I get an error due to ManyToMany fields.
Specifically, line 332 of renderers.py:
https://github.com/wharton/drf-renderer-xlsx/blob/82af43b879aad2a37b0d1115f5f830bf5c822314/drf_renderer_xlsx/renderers.py#L330-L332
The problem seems to be that if it's a list of non string objects, it throws an error.
And by default for ManyToMany fields, django sends back a list of int (the ids)
It would probably make sense to flatten the list by calling str() on each element of the list?
Something like this:
list_sep.join(map(str,v))

@rptmat57 can you provide some example code to reproduce the error?

here is a small sample project.
after creating a superuser and logging in to /admin, if you create a publication, then an article with that publication selected, when you go to /api and try to export articles in Excel it will fail
xlsx_renderer_project.zip


Attaching Volume to running container should fail

It's not possible to attach a volume to a running container.  Volumes can only be attach to containers at creation time, i.e., there's no hotplugging of volumes to containers.  ciao-cli should therefore return an error.  Instead it attempts to attach the volume to a container.  It returns success but the volume is not attached.  It remains stuck in the attaching state for ever and cannot be deleted.   Zombie volume.
$ ciao-cli volume add -name zombie -size 1
Created new volume: 6817ab36-6b82-4088-8bd4-31be35c40ffb
$ ciao-cli instance add --workload ca957444-fa46-11e5-94f9-38607786d9ec
Created new instance: 7181b76b-5c60-40b6-8272-73b4197067aa
$ ciao-cli volume attach --instance 7181b76b-5c60-40b6-8272-73b4197067aa --volume 6817ab36-6b82-4088-8bd4-31be35c40ffb
Attached volume: 6817ab36-6b82-4088-8bd4-31be35c40ffb
$ sleep 60
$ ciao-cli volume show --volume 6817ab36-6b82-4088-8bd4-31be35c40ffb
	Name             [zombie]
	Size             [1 GB]
	UUID             [6817ab36-6b82-4088-8bd4-31be35c40ffb]
	Status           [attaching]
	Description      []
$ ciao-cli volume delete --volume 6817ab36-6b82-4088-8bd4-31be35c40ffb
F1125 14:27:50.350790   31705 main.go:403] ciao-cli FATAL: Expected HTTP response code [202 204] when accessing [DELETE https://singlevm:8776/v2/f452bbc7-5076-44d5-922c-3b9d2ce1503f/volumes/6817ab36-6b82-4088-8bd4-31be35c40ffb], but got 403 instead
Forbidden

This issue can also be reproduced by the unsubmitted TestAttachToRunningContainer BAT test.

I have a patch for this but have not been able to fully test because of #875

@markdryan I reviewed the code in controller - it looks like this error path should cause the volume state to be reset to available. I also looked at the launcher code and it looks correct. @tpepper does the scheduler need to forward these errors explicitly? I don't see anything in the scheduler code to indicate that it does anything for these errors.


fatal: unsafe repository ('/path/to/repo' is owned by someone else)

Running make docker to build new binaries produces this error message:
fatal: unsafe repository ('/path/to/repo' is owned by someone else)
To add an exception for this directory, call:

        git config --global --add safe.directory /path/to/repo

A brief Google search leads me to these resources:

https://github.com/actions/checkout/issues/760
https://github.blog/2022-04-12-git-security-vulnerability-announced/

One of the workarounds given:

run the container as a user that has access to the mounted directory

The upside is that it runs the build container without root privileges, which is a win in itself.

Additional resources used:

https://github.com/openshift/release/issues/9748
https://medium.com/redbubble/running-a-docker-container-as-a-non-root-user-7d2e00f8ee15


take_until equivalent combinator

What's synom's equivalent combinator for take_until, if any? If none, how can it be achieved? I want a way to grab everything in a token stream until I reach a comma.

Here is what I have so far:-
impl Synom for ToComma {
    fn parse(mut rest: Cursor) -> PResult<Self> {
        let mut tokens = Vec::new();
        while let Some((tree, cursor)) = rest.token_tree() {
            rest = cursor;
            if let TokenTree::Punct(p) = tree.clone() {
                if p.as_char() == ',' {
                    break;
                }
            }
            tokens.push(tree);
        }
        let stream = TokenStream::from_iter(tokens);
        Ok((ToComma(stream), rest))
    }

    fn description() -> Option<&'static str> {
        Some("token stream to comma")
    }
}

However, for any input that has more tokens after a comma, this gives "failed to parse token stream to comma: failed to parse all tokens". Where am I going wrong?
Permalink to the playground
Direct link to the gist

If I return an empty cursor, instead of the rest tokens, the test passes. That is,
Ok((ToComma(stream), Cursor::empty()))

instead of
Ok((ToComma(stream), rest))

Am I not supposed to return a cursor to the remaining tokens so they can be used by subsequent parsers?

Here is the final version (in case someone is interested):-
impl Synom for ToComma {
    fn parse(mut rest: Cursor) -> PResult<Self> {
        let mut tokens = Vec::new();
        while let Some((tree, cursor)) = rest.token_tree() {
            if let TokenTree::Punct(p) = tree.clone() {
                if p.as_char() == ',' {
                    if !tokens.is_empty() {
                        break;
                    }
                }
            }
            rest = cursor;
            tokens.push(tree);
        }
        let stream = TokenStream::from_iter(tokens);
        Ok((ToComma(stream), rest))
    }

    fn description() -> Option<&'static str> {
        Some("token stream to comma")
    }
}


GL_INVALID_OPERATION spam for glFrambufferTexture2D and GL_COLOR_ATTACHMENT4-7 on Raspberry PI

Bevy version
0.11.0
[Optional] Relevant system information
Raspberry PI 4B running Arch Linux Arm with Wayland and KDE Plasma.
AdapterInfo { name: "V3D 4.2", vendor: 5348, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Gl }
What you did
Going through the Bevy Book tutorial, this issue occurs as soon as you add DefaultPlugins.
What went wrong
The console spams
2023-08-01T21:16:25.771843Z ERROR wgpu_hal::gles::egl: GLES: [API/Error] ID 1 : GL_INVALID_OPERATION in glFramebufferTexture2D(invalid color attachment GL_COLOR_ATTACHMENT4)
2023-08-01T21:16:25.771912Z ERROR wgpu_hal::gles::egl: GLES: [API/Error] ID 1 : GL_INVALID_OPERATION in glFramebufferTexture2D(invalid color attachment GL_COLOR_ATTACHMENT5)
2023-08-01T21:16:25.772298Z ERROR wgpu_hal::gles::egl: GLES: [API/Error] ID 1 : GL_INVALID_OPERATION in glFramebufferTexture2D(invalid color attachment GL_COLOR_ATTACHMENT6)
2023-08-01T21:16:25.772448Z ERROR wgpu_hal::gles::egl: GLES: [API/Error] ID 1 : GL_INVALID_OPERATION in glFramebufferTexture2D(invalid color attachment GL_COLOR_ATTACHMENT7)

for every frame
Additional information
2023-08-01T21:16:24.990633Z  INFO bevy_winit::system: Creating new window "Bevy App" (0v0)
2023-08-01T21:16:25.007955Z ERROR sctk_adwaita::config: XDG Settings Portal did not return response in time: timeout: 100ms, key: color-scheme
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
ALSA lib pcm_asym.c:105:(_snd_pcm_asym_open) capture slave is not defined
2023-08-01T21:16:25.332586Z  WARN bevy_audio::audio_output: No audio device found.
2023-08-01T21:16:25.589474Z  INFO bevy_render::renderer: AdapterInfo { name: "V3D 4.2", vendor: 5348, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Gl }
2023-08-01T21:16:25.675852Z  WARN bevy_pbr::ssao: ScreenSpaceAmbientOcclusionPlugin not loaded. GPU lacks support: TextureFormat::R16Float does not support TextureUsages::STORAGE_BINDING.

Upstream wpgu issue for this: https://github.com/gfx-rs/wgpu/issues/3543
Though I'm surprised it's defaulting to GL. I thought the rpi4 supported vulkan? Does vkcube run? (might have to install it from your distro's repo if vulkan-tools aren't already installed.)

Actually installing vulcan-broadcom helps. 8)
I'll just close this and hide under a blanket for a while then.


Redrawing spectrogram may fail

(Using Chromium 59)
I tried loading a large file (a 56 minute one of those FrauBovary thingies) and zooming in and out of it. I discovered that the spectrogram sometimes fails to render, leaving the respective signal canvas empty except for the text "rendering ...". In these cases, the following error appears on the console:
Uncaught TypeError: Cannot read property 'windowSizeInSecs' of null
I can recover from this error by simply zooming in or out - the spectrogram is then redrawn without a problem. I have not been able to find further hints about when this does or does not happen.

just tried this for about 10 mins and couldn't reproduce it. Might have been fixed by accident...


Drop application prefix

Fixes

https://issues.redhat.com/browse/HACBS-1442
Description

Remove application prefix in gitops service APIs.
ApplicationSnapshot -> Snapshot
ApplicationSnapshotEnvironmentBinding -> SnapshotEnvironmentBinding
ApplicationPromotionRun -> PromotionRun (not used in UI)

Type of change

[x] Bugfix

Screenshots

cc: @christianvogt

/lgtm
/approve

/retest


Clarify BIG-IP objects created for ConfigMaps

@f5yacobucci
What issues does this address?
Fixes #
WIP #314
...
What's this change do?
This PR contains doc updates to clarify what BIG-IP objects the kctlr can manage according to resource type.
Summary of changes:
Update CC landing page; remove outdated diagram
change product landing page titles
Simplify doc titles
update project makefile/make.bat
update project README
light edit on flannel big-ip concept doc
remove glossary and term refs
remove index entries
manage metadata for marathon docs; remove docs-testing sidebars; update titles
update openshift metadata tags; remove index entries
update product metadata and type tags
update marathon docs toctree
update tags and k8s docs toctree
Add create vs-per-service doc
clarify ingress and BIG-IP objects
remove text from kctlr index page and put it in iApps draft for holding
Where should the reviewer start?
View the staged documentation:
k8s index
F5 Resource
Manage BIG-IP objects
Create VIPs for Services
Any background context?

@f5yacobucci -- updates pushed.
New staged docs available for review (new URL).
I'll rebase and squash once review is complete.


Fix  Error retrieving SCMFileSystem

ignoreCommitterStrategy gets error "Error retrieving SCMFileSystem " on github orgization jobs because currRevision is not instanceof AbstractGitSCMSource.SCMRevisionImpl.
Check the type and convert to SCMRevisionImpl would fix it.

@b-b3rn4rd Could you please review this change? Thanks.

hi @mervynzhang , thanks for providing the fix, sorry for the delay I'm on holidays atm

@b-b3rn4rd could you make a new release? I am trying to use this plugin with gitea and I get the same "Error retrieving SCMFileSystem".


Simulation fails if there is no wait or delay at the first line

It looks like if there is no  waitor delay at the first part of the test the simulation fails.
steps:
- - wait-serial: 'LED on'
  - expect-pin:
      part-id: led1
      pin: A # Anode pin
      value: 1

Erro message:

Tested on this example

Thanks for reporting!


Pass Virus Scan

Pass Virus Scan and upload to here

Virus scan is complete.
See the results here:
https://sharepoint.amr.ith.intel.com/sites/HPD/Shared Documents/Forms/AllItems.aspx?RootFolder=%2Fsites%2FHPD%2FShared Documents%2FLustre EE Releases%2FLustre EE 4.0.1&InitialTabId=Ribbon.Document&VisibilityContext=WSSTabPersistence


Reorganize the scripts for GIE launching

What do these changes do?

replace distribution, deploy and instance-manager's  scripts and config with bin/giectl and conf
update the launch gie command with giectl

Related issue number
Fixes #518

pr is ready, any comment?


Removed extra (capitalized) margin property.

Removal of an extra (capitalized) margin property in _alignment.scss.

The extra capitalized Margin is intentional, for an edge case in Outlook that only obeys capitalized Margin. This should be closed. (Also there is an insane number of commits here for some reason.)

@markadrake the capital Margin address the Outlook issue described by @jsit. You can read more about it here: https://www.emailonacid.com/blog/article/email-development/outlook.com-does-support-margins
Thanks for chiming in @jsit!


block_writer: add p{50,95,99,max} latency stats

Latency is measured over the reporting interval (1s).
_elapsed___errors__ops/sec(inst)___ops/sec(cum)__p50(ms)__p95(ms)__p99(ms)_pMax(ms)
      1s        0         5689.5         5689.4      2.5      4.7      5.8     10.5
      2s        0         4903.8         5297.8      2.9      6.0      7.6     16.8
      3s        0         5297.6         5297.7      2.6      6.0      8.4     16.8
      4s        0         4776.6         5167.5      2.9      7.1     10.0     13.6
      5s        0         4759.7         5086.1      2.9      7.3     11.0     14.2
      6s        0         4945.3         5062.7      2.8      6.6     10.5     14.2
      7s        0         4768.4         5020.8      2.8      7.1     14.2     22.0
      8s        0         4914.9         5007.5      2.8      6.8     12.1     18.9
      9s        0         4258.1         4924.2      2.9      8.9     14.7     19.9
     10s        0         4598.5         4891.7      2.9      6.3     14.2     23.1

This change is

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

block_writer/main.go, line 254 at r1 (raw file):

	}()

	for i := 0; true; {

can't this be for i := 0; ; {?

Comments from Reviewable

Review status: all files reviewed at latest revision, 2 unresolved discussions.

block_writer/main.go, line 254 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
can't this be for i := 0; ; {?

Done.

Comments from Reviewable


Login dovecot only the active mailbox

Some commands, such as doveadm -A need to get a list of users. With SQL userdb this is done with iterate_query setting.

Need to decide in what form it is better to refactor the classes quota and quota2 map/user_query.
Also can be implemented using dict (dovecot-dict-SQL.Conf.EXT):
driver = mysql
connect = host={{ DBHOST }} dbname={{ DBNAME }} user={{ DBUSER }} password={{ DBPASS }}
default_pass_scheme = SHA512-CRYPT
table = quota
select_field = current
where_field = path
username_field = username
#table = quota2
#select_field = bytes/messages
#where_field = bytes/messages
#username_field = username

Using map, quota2 (quota size):
connect = host={{ DBHOST }} dbname={{ DBNAME }} user={{ DBUSER }} password={{ DBPASS }}
map {
  # pattern = priv/quota/storage
  table = quota2
  username_field = username
  value_field = bytes
}
map {
  # pattern = priv/quota/messages
  table = quota2
  username_field = username
  value_field = messages
}

I implemented this with SQL dictionnary and using dovecot pattern mapping.

Need fix.
Error: User<EMAIL_ADDRESS>doesn't have home dir set, disabling duplicate database
Error: net_connect_unix(/var/run/dovecot/dict) failed: Permission denied (euid=1024(vmail) egi
d=1024(vmail) missing +r perm: /var/run/dovecot/dict, dir owned by 106:112 mode=0755)
Error: Internal quota calculation error

I let you review the changes,

Merged into dev.


type narrowing for agents and policies using generics

implement type narrowing all the way down to the lowest agent and policy level, through the use of generics
right now policies are typed as only a very high-level NoPolicy | BasePolicy which isn't useful at all

here's an example of where the type narrowing is not correct

This type is incorrect, which means I can't auto-complete any of the random_hold_policy functions or discover the arguments.
and another for config:

these should be random hold policy & random hold policy config, which would have correct autocomplete.
I have a TODO in base.py:
# TODO: We add this as a helper property so that subclasses can access the config without
# overwriting the __init__ function. The downside is that users of this member variable
# can't be type checked. There's probably a way to do this with generics instead of Any.

This hints that the solution is to use Generics, which I still think is correct. We need to revamp IHyperdrive to also use generics for this all to work.
The meta issue is that the python type system is fine with you narrowing the type to a base class, which removes all the metadata and content. So while it's not returning any type errors, it is not the behavior we want.

Move to medium priority bc the policy attribute is intended to be private & not accessed by the user.


Fixed singleselect multi choice widget

Changed single-select multiple choice widget.
New behavior:
-Selected text is empty when widget is first displayed. Submitting answer from this view results in null submission
-On dropdown user can select from all of the options specified in formbuilder
In response to http://manage.dimagi.com/default.asp?229724

also think we'd want this in the SpinnerMultiWidget
would be good to get sign off from @dimagi/product

looks great!
On Fri, Jun 17, 2016 at 3:31 PM, Saumya Jain<EMAIL_ADDRESS>wrote:

[image: screenshot_20160617-151357]
https://cloud.githubusercontent.com/assets/9773036/16162306/8cfc4bb4-34a0-11e6-88c7-062d7943936d.png
[image: screenshot_20160617-151402]
https://cloud.githubusercontent.com/assets/9773036/16162309/8d0c81fa-34a0-11e6-9921-a638412eeaf9.png
[image: screenshot_20160617-151851]
https://cloud.githubusercontent.com/assets/9773036/16162308/8d0caaae-34a0-11e6-946f-be3d4a54ed90.png
[image: screenshot_20160617-152710]
https://cloud.githubusercontent.com/assets/9773036/16162307/8d0b0ab4-34a0-11e6-8269-95f5a543a89a.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dimagi/commcare-odk/pull/1322#issuecomment-226861145,
or mute the thread
https://github.com/notifications/unsubscribe/AAazfHyrIJM5pR_T4DzNsqOLlStvIrlHks5qMvYPgaJpZM4I3uY7
.


HoloViews dotplot and umap elements

HoloViz-ifying the scanpy clustering tutorial and making:
WIP POC:

HoloViews anndata Interface
HoloViews DotPlot Element
HoloViews/Panel Dim Reduction (PCA, UMAP) App

How should the new anndata Interface and DotPlot Element become installable?

UMAP cell-type classification labels

TODO: add marker labels on UMAP

Scatter

Variance ratio

PCA

UMAP

UMAP Leiden graph-clustering

UMAP QC metrics

UMAP cell-type classification labels

[ ] TODO: add marker labels on UMAP

Yea, honestly, I don't know what's going on with the coloring. I'm not sure this particular plot is improved with rasterization.. it is suboptimal to have to play with spreading.

If that coloring difference isn't deliberate, it seems like a bug that should be addressed.  I'd be happy to have hvplot respect the size argument (translating it to a spread value) so that people wouldn't have to play around with spreading.

Highly variable genes

If that coloring difference isn't deliberate, it seems like a bug that should be addressed.

fixed the coloring issue.. it wasn't using the first two colors of the cmap for the two categories so I just limit the cmap to the first two colors and that resolves it.

fixed the coloring issue.. it wasn't using the first two colors of the cmap for the two categories so I just limit the cmap to the first two colors and that resolves it.

That sounds like a workaround, with a bug that still needs fixing.  What it sounds like is that it is treating the list of colors as a colormap (which is sampled at equal intervals due to its continuous nature) rather than as a color key or color cycle (which are taken in order due to their discrete nature). Definitely should not be confusing those usages! So unless I'm confused, you shouldn't be using cmap, you should be using a color key or color cycle.


BABA Whomst update

Added /whomst command, returning a user's real name.
Fixed capitalization of clientId and guildId.
Changed adminid to adminId to be consistent with clientId and guildId.

Requested wrong merge.


Passwords with spaces unable to authenticate

Messaging the bot with the login command  -- uses whitespace to separate arguments.
Since the last argument is always the password, would it be possible to concatenate all remaining args into the password?  People with spaces in their passwords are left out in the cold.

thanks to @sarlalian a fix for this has been merged into master now.
You can now put the "password with spaces" between quotes


Need SRA run accession on RNA-Seq

We have this on assembly.  It would be good to have it on this service as we provide for Assembly, and I could see that our users would make use of it.

SRA accession is already supported in RNA-seq service now. Closing the ticket.


Remove ancient debug logging

It's mortifying that we've been logging to consoles unnecessarily for years.

Can one of the admins verify this patch?

Some of this is more recent, but I agree we can at this point probably remove this logging as it serves its purpose (although it’s unclear whether there is a significant performance penalty if the dev tools aren’t open).
This is ok to test.
Sent from my iPhone

On Sep 5, 2019, at 19:04, App Inventor Worker Bee<EMAIL_ADDRESS>wrote:
Can one of the admins verify this patch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Some of this is more recent

Good to know. It hadn't occurred to me to do a git blame.
FWIW, what called my attention to it was when I did my own logging for debugging and had to dig through irrelevant messages.

@jisqyv Is there any reason we shouldn't remove this logging?

@ewpatton No reason, it can go...


.scrollTo and .scrollIntoView don't do nothing

When calling this two functions, nothing happens. I want to scroll the editor by javascript, and I call
  codeMirror.scrollTo({'x': 300});

and nothing happens.

Read the docs and make sure you are actually passing it the parameters it expects.

yes just saw it, really sorry for the scrollTo


Allow specifying the name of the installed Typst executable

this action adds typst to the path; for testing packages with multiple Typst versions it would be desirable that different versions could be installed under different executable names, to that in the end for example typst and typst-0.10 end up on the Path.
I can imagine a few different ways this could work:

add a parameter like executable-name that you could set to typst-0.10. If specified, the executable is renamed
add a parameter like use-version-suffix that you could set to true. If true, either

rename the executable
add a symlink that uses typst-version for the suffix
add symlinks for all prefixes of the actual resolved version number, e.g. 0, 0.10 and 0.10.0

always add these symlinks; they don't hurt, even if the executable is used through the name typst. As each invocation of setup-typst prepends an entry to the path, the last one will determine the version found under the name typst

Wouldn't mind a main build too

you mean in addition to "latest" and version tags? and with suffix that would be typst-main?

For reference (I don't know if this setup-typst currently works like this) the way this is done with other setup-node and setup-python actions is to execute the tests on each version either in parallel across multiple jobs or sequentially by re-applying setup-node again and again after each test.
Example using multiple jobs:
jobs:
  test-it:
    strategy:
      matrix:
        node-version: ["18", "20", "22"]
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          node-version: ${{ matrix.node-version }}
      - run: npm ci
      - run: npm test

Example using multiple applications of setup-node
jobs:
  test-it:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          node-version: "18"
      - run: npm ci
      - run: npm test
      - uses: actions/setup-node@v4
        with:
          node-version: "20"
      - run: npm test
      - uses: actions/setup-node@v4
        with:
          node-version: "22"
      - run: npm test

ah, I completely forgot configuration matrices; I'll try it this way.

Using a matrix is IMO sufficient and superior, so I'll close this. As an example, I'm adding this in the package template here: https://github.com/typst-community/typst-package-template/pull/9


npm ERR! 404 Not Found: react-native-sqlcipher-storage@latest

For Discussion

I am trying to install a plugin :
npm install --save react-native-sqlcipher-storage
reference from : https://github.com/axsy-dev/react-native-sqlcipher-storage
but it is throwing a 404 error
npm ERR! 404 Not Found: react-native-sqlcipher-storage@latest

It is because that lib is no longer present in npm repo.
You can still add => dependencies { ... "react-native-sqlcipher-storage": "axsy-dev/react-native-sqlcipher-storage", ... } in package.json and then do npm install or yarn. This will install that package for you


MINIFICPP-604: Convert C++ namespace operators to Java packing operators

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

changes look good.  verified build and tests.  saw the appropriate format change in generated output.
will merge


Object validator

[x] Related GitHub issue(s) linked in PR description
[x] Destination branch merged, built and tested with your changes
[x] Code formatted and follows best practices and patterns
[x] Code builds cleanly (no additional warnings or errors)
[ ] Manually tested
[x] Automated tests are passing
[x] No decreases in automated test coverage
[ ] Documentation updated (readme, docs, comments, etc.)
[ ] Localization: No hard-coded error messages in code files (minimally in string constants)

https://github.com/AndcultureCode/AndcultureCode.DotnetReact.Boilerplate/issues/26
This PR is to move the Object-Validator functionality from the Boilerplate project into this core project.

@AaronW This was automatically closed out due to the default branch changing from master to main. Feel free to reopen another PR whenever you're ready 👍


[#2910] fix(filesystem-hadoop3): Make getWorkingDirectory method synchronized

What changes were proposed in this pull request?
Make getWorkingDirectory method synchronized.
Why are the changes needed?
Fix: #2910

cc @justinmclean @jerryshao


Smart card reader causes libusb crash

Insert and unplug the smart card reader on windows platform causes libusb crash.
releated issues #285
static char *parse_device_interface_path(const char *interface_path)
{
	char *device_id, *guid_start;
	unsigned int i, len;

	len = safe_strlen(interface_path);
	if (len < 4) {
		return NULL;
	}

	// Microsoft indiscriminatly uses '\\?\', '\\.\', '##?#" or "##.#" for root prefixes.
	if (((interface_path[0] == '\\') && (interface_path[1] == '\\') && (interface_path[3] == '\\')) ||
		((interface_path[0] == '#') && (interface_path[1] == '#') && (interface_path[3] == '#'))) {
		interface_path += 4;
		len -= 4;
	}

	guid_start = strchr(interface_path, '{');
	if (guid_start != NULL) {
		len = (guid_start - interface_path) - 1; // One more for separator
	}

	if (len <= 0) {
		usbi_err(NULL, "program assertion failed: invalid device interface path");
		return NULL;
	}

	device_id = calloc(len + 1, 1); // One additional for NULL term.
	if (device_id == NULL) {
		return NULL;
	}
	strncat(device_id, interface_path, len);

	// Now convert to uppercase and replace '#' with '\'
	for (i = 0; i < len; i++) {
		device_id[i] = (char)toupper((int)device_id[i]);
		if (device_id[i] == '#')
			device_id[i] = '\\';
	}

	return device_id;
}

The unsigned int len cause the len
Value cannot be negative
and then Cause the code if(len<=0) not to be executed
when len should be -1;
device_id[i] emit Array out of bounds exception
Just need to modify unsigned int len to int len

Having the same Issue. Thank you @xdimh now can I patch it in my project.
Dont you @xdimh want to create a PR so that the node-usb Team can apply it faster?

IIUC we gave up on using a patched libusb (#453), so v1.9+ currently has no real hotplug support on windows and falls back to periodic polling from JS.
That will hopefully change with #488.

Although the current polling mechanism on Windows is sub-standard, I'd still be keen to know if the switch to more recent upstream libusb has fixed this crash (any usb release since November 2021 / usb@1.9.0).

the crash is from a patch that we used to apply to libusb in order to get hotplug support for windows. the code is no longer there since we switched to upstream libusb

Excellent,  closing.  Please re open this if required.


Ensure doc groups are sorted before merging them

We had been implicily assuming that clients send us sorted groups, but unsurprisingly that's not always the case. The additional sorting here should be redundant, but the consequences of merging unsorted groups are severe -- we can end up with uniqueness violations on the primary key in the database -- and so we add an additional sort here.
COUCHDB-2735

+1

Fixing a typo in the commit message and merging, thanks for the review.


Edit: 9X Jalwa

Channel ID (required)
9XJalwa.in
Channel Name
No response
Alternative Names
No response
Network
No response
Owners
No response
Country
No response
Subdivision
No response
City
No response
Broadcast Area
No response
Languages
No response
Categories
No response
NSFW
None
Launched
No response
Closed
No response
Replaced By
No response
Website
No response
Logo
No response
Notes
No response

New channel


Adblock plus bypass your script

When I try to add the following two filters to Adblock plus:
@@||sitexw.fr^$script
@@||sitexw.fr^$elemhide
Then will bypass your script As you can see in attached image.
Could you please fix this as soon as possible..

It is a real question?
For your Github account has been created together with the issue.

Yes, I have create an account to getting your help to solve this issue only,

Hello,
So, there is no solution for this issue??

Excuse me,
please explain what did you mean that my account caused this issue.

I will donate to you, if you helped me to solve this issue

I'll answer the question, but the subject remains strange.
FuckAdBlock is designed to detect an ad blocker in action and not to detect if an advertisement blocking extension is present.
That is to say that if advertisement blocking extension (eg AdBlock) is on the browser, but that there is an exception to the site, FuckAdBlock can not detect it because the ad blocker does not block ads..

The Adblock block the ads, and FuckAdBlock can not detect it..
Did you tried to ad the following two codes to you Adblock plus filter and test your script again:
@@||sitexw.fr^$script
@@||sitexw.fr^$elemhide
You will understand me

The Adblock block the ads, and FuckAdBlock can not detect it..
Did you tried to ad the following two codes to you Adblock plus filter and test your script again:
@@||sitexw.fr^$script
@@||sitexw.fr^$elemhide
You will understand me

The Adblock block the ads, and FuckAdBlock can not detect it..
Did you tried to ad the following two codes to you Adblock plus filter and test your script again:
@@||sitexw.fr^$script
@@||sitexw.fr^$elemhide
You will understand me

The Adblock block the ads, and FuckAdBlock can not detect it..
Did you tried to ad the following two codes to you Adblock plus filter and test your script again:
@@||sitexw.fr^$script
@@||sitexw.fr^$elemhide
You will understand me

Ok, I understand better.
I'm sorry, I did not pay attention to "$elemhide".
I am currently working on the V4 FuckAdBlock (#34) and this problem will be resolved.
Thank you.


npm install "broken"

When using the command:
npm install @grvcoelho/babelfish --save

I'm given the following error:
npm ERR! 404  '@grvcoelho/babelfish' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)

Has this project been pushed to npm registry? Perhaps a simple npm publish can solve this?
Awesome project, btw.

@grvcoelho Any idea of this? Is the project still maintained?

Hey, just fixed :)
Sorry for the delay :+1:


FIX: Handle account-level metrics listing

Query params sent to the arsenal auth method currently only handle bucket-level metrics. Since the listing binary supports account-level metrics, we also need to be able to send the correct path for account-level listings. This also prepares the route for remaining metric levels: to be introduced in https://github.com/scality/S3/pull/536

@ironman-machine try

Hello @bennettbuchanan
Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "DEFAULT_BRANCH": "rel/6.4", "SCALITY_S3_BRANCH": "fix/handle_account_level_listing"}
Please follow http://ci.ironmann.io/gh/scality/Integration/11203 for CI status.

E2E passed


[Android] Refactor microblink implementation

As a developer
I need to Refactor the microblink implementation
to keep the SDK updated always able to use new microblink features without big changes
What it is now
the microblink is implemented using the old documentation.
What it should be
the SDK should use the new and recommended way to implement microlbink.
Acceptance criteria
SDK continues working fine using the new implementation way

already implemented


Fix/service details gap between stepper button

This PR fixes the service details container positioning within the step.

This PR is not relevant anymore since #366 addresses share data page layout issues, including service details gap.


[Bug] Timestamp based day transformed partitions fails on read

Changes were made in https://github.com/apache/incubator-iceberg/pull/424 to have Timestamp day() to return Date type instead of Integer ordinal. This is causing partition interpretation to fail during append/read. Here's an example ..

scala> import org.apache.iceberg.types.Types.NestedField._
import org.apache.iceberg.types.Types.NestedField._

scala> import org.apache.iceberg.types._
import org.apache.iceberg.types._

scala> import org.apache.iceberg._
import org.apache.iceberg._

scala> val timestampSchema = new Schema(optional(1, "timestamp", Types.TimestampType.withoutZone()))
timestampSchema: org.apache.iceberg.Schema =
table {
  1: timestamp: optional timestamp
}

scala> val partitionByDate = PartitionSpec.builderFor(timestampSchema).day("timestamp", "date").build
partitionByDate: org.apache.iceberg.PartitionSpec =
[
  date: day(1)
]

scala> DataFiles.builder(partitionByDate).withPath("/path/to/data-1.parquet").withPartitionPath("date=2019-09-01").build()
java.lang.UnsupportedOperationException: Unsupported type for fromPartitionString: date
  at org.apache.iceberg.types.Conversions.fromPartitionString(Conversions.java:70)
  at org.apache.iceberg.DataFiles.fillFromPath(DataFiles.java:83)
  at org.apache.iceberg.DataFiles.access$200(DataFiles.java:36)
  at org.apache.iceberg.DataFiles$Builder.withPartitionPath(DataFiles.java:292)
  ... 55 elided

org.apache.iceberg.types.Conversions class doesn't support Date type handling. The impact this has is when one has PartitionSpec containing day() transformed field, doing operations like append to such a Table requires re-interpreting this field. This could potentially affect other flows as well.

cc @rdblue

Gist to reproduce : https://gist.github.com/prodeezy/459422d1b7d388a0d225292a62817b19

@prodeezy will resolving #428 fix this?

@aokolnychyi  yes seems like it. I put up a PR with a potential fix, maybe you can review it? I'm handling it in Conversions by returning an epochday ordinal which is in a Integer.  https://github.com/apache/incubator-iceberg/pull/506

Doesn't PR #506 fix #428? That's basically what it does.
I'm fine adding that commit if it unblocks you, but this type of bug is going to keep happening to you if you continue to use this pattern where you write files and then use paths to build partition data when appending to a table. The withPartitionPath method is only intended for use with Hive partitions, and even then it is a best effort. Iceberg doesn't guarantee that partition strings even can be parsed to produce the original value because that has been an error prone anti-pattern in Hive.
This is going to cause further problems with strings that require escaping, hourly partitions, etc. I suggest moving off of this pattern and keeping the partition tuples as data instead of recovering partition tuple values like this.

There's some internal code that builds DataFile objects and augments the commit process. We need to re-think that code a bit. Until we work around that we need this issue fixed.

Sounds good to me, I just want to make sure you don't hit this again in a few weeks for a similar use case, like hourly partitions. We should be able to get the fix in today.


ITEX should be able to see feedbacks from excursions

What kind of an issue is this?

Bug report

What is the expected behaviour?
Members of the ITEX group shoudl be able to see the feedbacks from their events.
What is the current behaviour?
Members of the ITEX group can not see feedbacks from excursions, because it is hard-coded that only 'eksKom' can do that.
Other information
The offending lines of code can be found here

Resolved by #2131


fix(gateway): Use sudo to write files

Found a couple small issues with the systemd gateway when copy-pasting onto my rpi not as a root user.

Tested to work


argument sets / tuples?

Is it possible to have "sets" of arguments?
My CLI.

Usage:
  my-cli (--x=... --y=... --z=...) ...

so that I can run my-cli --x=... -y=... -z=... -x=... =y=... -z=... -x=... and so forth. Basically, I need to accept a list of tuples/structs?

How about this?
http://try.docopt.org/?doc=usage%3A
++my-cli+(--x%3D<x>+--y%3D<y>+--z%3D<z>)...&argv=--x%3D1+--y%3D1+--z%3D1+--x%3D2+--y%3D2+--z%3D3


[MBL-1778] Create GraphQL fragment for Project-specific analytics

📲 What
This PR creates an abstraction around Project-related properties for analytics. This will let us use either a Project object from V1 API or a fragment from a GraphQL query.
🤔 Why
We want to move away from requiring a full ProjectFragment for analytics purposes, as a full Project requires a ton of fields that analytics does not. This will help keep the wire size small for GraphQL queries.
🛠 How

I created a protocol ProjectAnalyticsProperties which represents the fields for a project needed for analytics. This was based on usages in the projectProperties function in KSRAnalytics, so it should be the minimal set of fields needed.
I updated KSRAnalytics to replace Project with any ProjectAnalyticsProperties where project analytics were needed.
I added a conformance for ProjectAnalyticsProperties to Project, so existing usages would continue to work.
I created a new GraphQL fragment, ProjectAnalyticsFragment, which fetches the required properties from GraphQL for a given Project.
I added a conformance for ProjectAnalyticsProperties to GraphAPI.ProjectAnalyticsFragment.

This will get used in the follow-up PR for #2167.
✅ Acceptance criteria
Tests should pass.

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger


Trigger a "sending" notification while a photo is being sent

I am sending photos using sendPhoto(), but while they are being sent, the user does not receive this notification:

Any way to trigger it?

Hello,
yes , the method you are looking for is sendChatAction. from the Reference :

sendChatAction(chat_id, action)
Tell the user that something is happening on the bot's side. The status is set for 5 seconds or less (when a message arrives from your bot, Telegram clients clear its typing status).
See: https://core.telegram.org/bots/api#sendchataction

this method can display all types of sending X messages, for sending photo specifically you can use the following code:
# Uploading a file may take a while. Let user know you are doing something.
bot.sendChatAction(chat_id, 'upload_photo')

Thank you very much my dear.


update single site dmrg

I finally got around to checking out the dmrg code. Very cool and lots of potential!
Is there a reason the rightmost site is skipped during the single site dmrg sweep?
commit:
-fixed: rightmost site skipped
-slight change to verbose

Hi Ryan, thanks for the PR!  In fact the code does correctly update all sites. However, there is an error in the print message. I fixed this myself already, I think it's easier that way.
Any issues and future PRs are highly welcome though!


Section 1 (Technical): Create questions for assessment

Based on https://github.com/sara-sabr/ITStrategy/issues/1102, create questions for the survey

Questions
Answers
Weighting (Ex: Answer A on this question is worth x points, while answering b on this question is worth y points, etc...)

https://014gc.sharepoint.com/:w:/s/DevOpsAssessment/EQetov3hTqRBlIIh1RL1CYgB4ZYUWjhdBTGfvJWtAmgviQ?e=2Kp7gV


Problem when running goaccess with cron

I have the following script updateStats.sh that works great when I run it manually but fails when run on Ubuntu via cron with 0 * * * * /var/www/html/updateStats.sh
cat updateStats.sh:
goaccess /var/log/nginx/access.log -o /var/www/html/nginxDaily.html --log-format=COMBINED --anonymize-ip
zcat -f /var/log/nginx/access.log* | goaccess -o /var/www/html/nginxDailyAll.html --log-format=COMBINED --anonymize-ip

cat cron.log provides:
 [PARSING /var/log/nginx/access.log] {4907} @ {0/s}
Cleaning up resources...

GoAccess - version 1.5.5 - Feb  5 2022 18:37:15
Config file: /etc/goaccess/goaccess.conf

Fatal error has occurred
Error occurred at: src/goaccess.c - initializer - 1457
No input data was provided nor there's data to restore.

The first line runs fine. The second line fails.
Any ideas what I'm doing wrong?

Great question. When piping data to goaccess via the cron or pretty much anytime you pipe data in, you will need to add a dash. e.g.,
zcat -f /var/log/nginx/access.log* | goaccess - -o /var/www/html/nginxDailyAll.html --log-format=COMBINED --anonymize-ip

Let me know if that helps.

@allinurl that seemed to work! Thanks so much!

Glad that worked :)

Hi - just run into it and was almost before opening an issue for it. Glad to found the solution among the closed ones. (Can confirm it, too). The behavior though seems strange, if the single ssh command works but not while executed during cron....hm for better understanding can someone explain what is happening here?
Anyway THX for the solution :-)

@StefanSchubert cron doesn't give a TTY so isatty(3) fails when no filename is passed and thus it won't output a report. A single dash (-), with no option, usually means "read from standard input". This is a very common convention used by many programs. Hope that helps clarify this.

@allinurl Did it! Thanks for the explanation - I learned something new by it!

great explanation. It solves my issues. :-)


Can't Login

when I ran bash setup. sh I typed the password randomly and ended the termux app in halfway and now I can't login I back

there is a problem in user name and login


[Removal]: Please check

Hotspot Name
Ambitious Bone Fish
Hotspot b58 Address
11oW3U9LHvqcKWUVDyb1n5UnyKUBBZeSHumoqDDD3BGzot5GQnB
Discord Handle
No response
Hotspot Manufacturer
PantherX
Removal Reason
Please read it again, the hotspot is placed in the rental house, the monthly electricity bill, the network, whether it is affected by the surrounding non-compliant equipment, or the use of VPN, all have their real locations, please move me to the rejection list.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Dynamic import with destructuring false positive on unused export

I've created a simple reproduction at https://github.com/shawnmcknight/knip-dynamic-import-destructuring.
Dynamic imports of the signature import("./components.ts").then(({ Apple }) => Apple); are reported as unused exports while dynamic imports of the signature import("./components.ts").then((mod) => mod.Orange); are not reported as unused exports.
As illustrated in the reproduction, I have a components.ts file that is:
export const Apple = () => "Apple";
export const Orange = () => "Orange";

and an index.ts file that is:
import("./components.ts").then(({ Apple }) => Apple);
import("./components.ts").then((mod) => mod.Orange);

When running knip the output is:
Unused exports (1)
Apple  unknown  components.ts:1:14

Please let me know if there is anything else I can provide to assist!

Thanks @shawnmcknight, great report + repro 🙏

:rocket: This issue has been resolved in v5.22.1. See Release 5.22.1 for release notes.
Using Knip in a commercial project? Please consider becoming a sponsor.


⚠ Bofrost.es has degraded performance

In a6468ae, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1445 ms

Resolved: Bofrost.es performance has improved in 756fa7d after 8 minutes.


Add first pass compare versions dialog

User Story
As a translator, I want to be able to collaborate with others on my Scripture projects so that we can work together effectively.
Description
Develop a rough-cut first draft of Compare Versions functionality in Platform.Bible.

[ ] Create simple compare versions dialog

[ ] Find npm text comparison component
[ ] Compare usfm literally - no need to integrate editor

Compare Versions

Compare Versions with version selector dropdown

Can we discuss this? I'd really like to avoid forcing users to become developers to do version control.

Please involve somebody from ux in this discussion. Will be interesting to hear opinions and ideas.

Time-box this at a medium. We should re-evaluate this if it takes too long.

https://github.com/paranext/paratext-bible-internal-extensions/pull/75 has screenshots thanks @jolierabideau

Verified that with the below steps

Open Scripture Editor with zzz6 project
Set the BCV to Gen 1:1
Click Project > Compare versions for this project on zzz6 webview
Confirm Compare versions dialog opens with 2 drop downs
Verified that Select Revision one is displayed with the list of revisions with Timestamp,User Info and Book
Verify that Select Revision two is displayed with the list of revisions with Timestamp. UserInfo and Book
The diff displays the highlighted text with 'Red' and -  for deletion and 'Green' / + for adding text.
The dropdown selections are persisted even as the dialog was moved around.
The dropdown selections are persisted even as the application is reopened.

There are few things PT10 is different from PT95
Note :

In PT95 the Left side pane and Right side pane are independent, they can scroll or place cursor with keys independently.They both are in sync once the cursor is placed.
In PT95 the compare version dialog opens up with default Current on left side and Base version on the right side.In PT10 user have to select and it is not displayed as default.
In PT10 both panes scroll together.
In PT10 We can also not place a cursor in either of the panes
In PT10 there is no option to compare different projects or resources with the current project like in PT95


Fix CLI doc

The current doc gives the impression that process.argv is parsed automatically, but you have to add a dispatch() call.
I simply added this call and an example of how to run the program.

Cool, thanks! I cherry picked 46e0b2db684f5778874d979058a67ce8fc77abee


Windows & QOL

Fix windows binary download and unzipping.
Improve README.md and fix typo using harper, lol.
Add more officially supported languages by zed to the extension.

I mean considering they don't have support for many languages yet. Maybe it'll still be useful to add, no need to update because harper might add them in the future?

@nuIIpointerexception PR has been made: https://github.com/zed-industries/extensions/pull/1699


useEslintRc ERROR!!

I can confirm this. It's pretty bad and the error points to minified js, so it's pretty much impossible to debug.


Remapping keys

I have a few questions about remapping keys.  Note that I am primarily using this in conjunction with chunkwm.  I've asked some of these in the ##kwm channel in freenode; however, I have no idea if that's the appropriate place so I'm now coming here.

1. Using the following in my .khdrc, but it doesn't seem to work (as in, doesn't seem to trigger anything when I press ctl-t)
ctl - t : khd -p "cmd - t"

Ideally this would just remap ctl-t to cmd-t

2. Is it possible to remap to bindings that already exist in khd?  For instance, I'd like to have this binding -
cmd - w  : chunkc tiling::monitor -f 3

But then also have
ctl - w : khd -p "cmd - w"

I'm not sure if this would even work in theory (due to some sort of key binding loop), but that doesn't seem to do anything either; in fact, none of the khd -p commands seem to work.

3. I am currently using Karabiner-Elements to remap fn to ctl and ctl to fn; is it possible to do this with khd?  Since Karabiner-Elements can pull it off, it also seems like this may prove that key binding loops are avoidable (as I mentioned in point 2), I'm just not sure how to pull it off.

Key remapping is not a supported feature of khd: https://github.com/koekeishiya/khd/issues/50

What is the difference between key remapping and khd -p ?

khd -p triggers key strokes. It's more an auto-type than key-remaping.
From the linked issue:

Using khd -p to perform 'fake key-remapping' can be done to some extent, but this was never the intention of the feature

As chrishoage said, we do not do keymapping, but we can emit keystrokes.
Your particular case should both work, but you likely need khd void_unlisted_bind off.
# when 'default' mode is NOT active, any key-combination that
# does not correspond to a valid bind will be suppressed.
# this is enabled by default, and must be explicitly set to 'off'.
khd void_unlisted_bind off

To expand on the previous answer. Even if you could to case 2 in khd, I would not recommend doing so, because it will incur noticable delay. khd -p in general is not amazingly fast, due to macOS API constraints.

Karabiner-Elements is certainly the best way to pull this off.  Thanks!


why  face with glasses when aged?

I edit real faces, all the aged faces with glasses, it is strange. Should the face attributes be disentangled? Anyone encounter this question? Any solutions?

It is hard to disentangle different face attributes. Sometimes, such entanglement is caused by the training data distribution. For example, if all old people in the training set are wearing eyeglasses, that will also be the case when you perform editing with the GAN model.

I understand, thanks

It is hard to disentangle different face attributes. Sometimes, such entanglement is caused by the training data distribution. For example, if all old people in the training set are wearing eyeglasses, that will also be the case when you perform editing with the GAN model.

I understand , thanks


Contribute 'Open Commit at GitHub' to SCM Graph item

This is related to #229349

/assign @lszomoru
Please consider for October.

@lszomoru now that 1.94 has shipped please consider taking this.

@lszomoru any feedback on this yet?


Handling of attributes containing js expressions

In many cases vue uses js expressions, e.g. arrays of objects (dicts), to set options.
Currently we handle such situations mostly by defining a model field that takes a Julia expression which is then converted to the correct js expression during rendering. Sometimes, we also set js expressions explicitly, e.g. options = R"['hello', 'world']".
I propose to modify Stipple attribute handling such that the latter example could be written as options = ["hello", "world"]. That kind of handling would also allow easier definitions of objects or array of objects:
julia> btntoggle(:network, options = [opts(label = x, value = lowercase(x)) for x in ("Google", "Facebook")])
"<q-btn-toggle v-model=\"network\" :options=\"[{'value':'google','label':'Google'},{'value':'facebook','label':'Facebook'}]\"></q-btn-toggle>"

Mmm I don't know about this. I see how it can be useful as you avoid having to define extra variables, but I don't think it's much simpler than doing
@out option_list = [opts(label = x, value = lowercase(x)) for x in ("Google", "Facebook")]
btntoggle(:network, options = :option_list)

Moreover, this wouldn't prevent the instantiation of the list, so I think there wouldn't be much computation time savings (not sure about memory).
Also, as of now, anything you pass to a parameter has to be a symbol or a Javascript expression. Same goes for macros like @on. If we extend them to accepting list comprehensions, couldn't this lead to some confusion?

Moreover, this wouldn't prevent the instantiation of the list, so I think there wouldn't be much computation time savings (not sure about memory).

That's not true. The list is only instantiated at the client side and it will not consume memory per model, because the list definition will reside in Stipple.js. It's only defined once UI.
btntoggle(:network, options = [opts(label = x, value = lowercase(x)) for x in ("Google", "Facebook")])

Also, as of now, anything you pass to a parameter has to be a symbol or a Javascript expression. Same goes for macros like @on. If we extend them to accepting list comprehensions, couldn't this lead to some confusion?

Currently, parameter values can be either

AbstractString, Real: The value is directly passed to the parameter as a constant at the client side
Symbol: The string value of the symbol is evaluated as a js expression and is updated if one of the included variables changes

So I think if we add

<julia expression, e.g. Dict, Vector, GenericTrace>: The values are jsonified and evaluated as js expressions

that's only very intuitive, think e.g. of select(:field, options = [1, 2, 3]), plot(:plot, layout = PlotlyBase.Layout(title = "test title"))

Same goes for macros like @on

The content of the @on or @click macro is executable code. We don't have any representation for that in Julia, so I don't see how you would want to change the macro to handle julia expressions.
I know there is a package with a macro that translates julia code to js code, but that's a different story. Although, I would find it quite nice for js_methods() to write julia code and have it executed as javascript on the client side. Let's think about that. I need to dig, which package that was.

I was also thinking of @recur. I've seen people attempt to put Julia expressions in there and ask why it doesn't work. With this change one would expect something like @recur([fruit in fruit_list])to work

Good point! Andfine for me and easy to implement.

Well the second way would probably be better as you get, the iterated variable. What I wrote would be akin to doing for _ in fruit_list. Still, I wrote it as a list comprehension because otherwise it'd have to be an Exp, right?
Here's an example of what I meant from one of our users

Well, as @recur is a macro, anything inside is an expression first of all. So we could do what we want with it.
Javascript enumeration works just the other way around, the index follows second. So, indeed we'd need that translator package.

There is JSExpr.jl which does a lotvof what we'd want. Only Dict translation is not done and there is  o zip function, but we could add that as method

Here's an example of what I meant from one of our users

Have a look at https://vuejs.org/guide/essentials/list.html#v-for
You find that you can easily access the index by destructuring
@recur("for (letter, i) in letters")

where i will run from 0 to length(letters) -1 and will be the correct js index so that letter == letters[i] for each element.
zip
If you have another vaiable that you want to loop, instead of
for (var1, var2) in zip(vars1, vars2)

you can do
for (var1, i) in vars1

and write vars2[i] instead of var2 in the referencing expression.

But we could implement Julia expressions as well. Question would be how exactly. We could either use expression evaluation or explicit interpolation

expression evaluation

julia> dict = Dict(:a => "b", :c => 4);

julia> list(@recur((v, k, i) in mydict), "{{ v }}")
"<q-list v-for=\"(v, k, i) in {'a':'b','c':4}\">{{ v }}</q-list>"

julia> list(@recur((v, k, i) in :mydict), "{{ v }}")
"<q-list v-for=\"(v, k, i) in mydict>{{ v }}</q-list>"

2: interpolation
list(@recur((v, k, i) in $mydict), "{{ v }}")
"<q-list v-for=\"(v, k, i) in {'a':'b','c':4}\">{{ v }}</q-list>"

list(@recur((v, k, i) in mydict), "{{ v }}")
"<q-list v-for=\"(v, k, i) in mydict>{{ v }}</q-list>"

Re-reading my proposals, I would vote for the first solution.

@PGimenez @essenciary
If version 1) also meets your taste, I think we're set to merge this PR.
My idea is the following:

merge #234
merge #232

Prepare another PR to support julia expressions in @for (alias for '@recur`)
Are there other macros that would need to support Julia expressions?JSExpr is quite a heavy dependency and I'm not sure how much that would help, after I tried some examples. Please share your opinion.

Yes, looks good to me!
I would not add JSExpr - users could add it themselves maybe.

Solved by #232


Cq 4348876

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

lets have TCs for the all the components related to behaviour of short and long description.

short description visible on hovering if always show is not selected.
short description always visible if always show is selected.
In case short description is marked as always show, then it gets hidden when question mark icon is clicked.
long description toggling on clicking question mark icon.


Update repository-structure.md

Added necessary information in Repo Per Environment documentation section
Resolve #417

Thank you @kingdonb


Pinned Tab is being replaced by new query

Description
Expected behaviour:
Pinning a tab, then running another query would open result for new query in a seperate tab.
Current behaviour:
It no longer does this, after pinning the tab the new query replaces the previously pinned tab.
DBeaver Version
Community Version <IP_ADDRESS>408041450
Operating System
macOS Sonoma 14.5
Database and driver
Mysql 8.2.0 Driver
Steps to reproduce
Run first query:
select 'hi there' data from dual;
Pin the result windows
Run second query:
select 'hi again' data from dual;
Pinned tab is replaced, no new tab is opened.
Additional context
Was able to replicate this against database on local machine and remote via socks tunnel

The same for the Operating System - Windows 11

Dear all guys,
The same situation here. It’s very annoying and is hapenninig from this version: Version <IP_ADDRESS>408041450

Rolled back to 24.1.3 due to this bug

Thank you for bug report.

We fixed this bug.
You can try Early Access version with fix (https://dbeaver.io/files/ea/) or wait for the next release


[SR-10203] Subscripts setter on key-path calls getter of the destination property

Previous ID
SR-10203

Radar
rdar://problem/49345381

Original Reporter
@DevAndArtist

Type
Bug

Environment
Apple Swift version 5.0 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.2.0

Additional Detail from JIRA

Votes
3

Component/s
Compiler

Labels
Bug

Assignee
None

Priority
Medium

md5: 13afefaa36d850c75676dbe3a222ba64

Issue Description:
This example unexpectedly crashes:
struct DelayedMutable<Value> {
  private var _value: Value? = nil

  var isInitialized: Bool {
    return _value != nil
  }

  var value: Value {
    get {
      guard let value = _value else {
        fatalError("property accessed before being initialized")
      }
      return value
    }
    set {
      _value = newValue
    }
  }

  /// "Reset" the delegate so it can be initialized again.
  mutating func reset() {
    _value = nil
  }
}

private var _value = DelayedMutable<Int>()

var value: Int {
  get { return _value[keyPath: \.value] }
  set { _value[keyPath: \.value] = newValue }
}

value = 42

Discussion on the forums: https://forums.swift.org/t/keypaths-subscript-setter-accesses-the-properties-getter/22212

Running into this bug as well.

Same, this bug is unfortunately preventing me from implementing a useful API that uses key paths. Would love to see a fix for it!

A slightly simpler example:
struct Foo {
  private var isInitialized: Bool = false

  var value: Int {
    get {
      guard isInitialized else {
        fatalError("property accessed before being initialized")
      }
      return 1
    }
    set {}
  }
}

do {
  var x = Foo()
  x[keyPath: \.value] = 0
}

This issue still happens and is also affecting an API that we were trying to build. Specifically, the getter runs an expensive operation to get the value so we want to avoid doing that unnecessarily.
struct Foo {
  var value: Int {
    get { fatalError("Should not call get") }
    set {}
  }
}

var foo = Foo()
foo[keyPath: \.value] = 0

Confusingly, this is exactly how SwiftUI environment works too. It uses key paths to set the value. I wonder if they're doing something different behind the scenes or are also having this issue as a small performance hit

Having the same problem!
@gabriellanata SwiftUI probably does not run into this problem because environment variables always have a value (the default value, if it has not been overwritten). So, they don't have to use fatalError in the getter.

I'm running into this issue as well... has anyone found a workaround?


Revert "Ops Optimization"

Reverts openvinotoolkit/openvino_tokenizers#219
Check the possibly breaking change

Jenkins is green w/o this change, so I merged the revert. If any build procedure update is required in Jenkins to return the change back and you need help with that - please, reach CI team separately.


fail to instantiate component after dump-autoload

Running
composer dump-autoload -a

gives problems initiating the PositionFieldtypeAsset.. when i try to acces the CP /craft/settings/fields/new
running
composer install

fixes the issue..
Not sure if there is something you can do about this.
Screenshot error: https://ibb.co/rM5mKxc
Pastebin of error: https://pastebin.com/?cf_chl_jschl_tk=3471c03aa50d5fe665b67cf1e3d3b5b41397bd99-1576233104-0-AR3_4GzEkeCdZlac2uH5rvTpU0hgCSXYGKP_qdOlD5HxS_gqohFjyIkmIc-Jw6_Zhoavrt9IN_OvshlGuMd1WwgtqZBMEIqBvIETEtaYVa6Rf02mBQbeBfd_NFJ13xpYcj9J4-lTY0QVNCxo6iiVh_Aprm81iRPuTigjRS9aQ6Yyj_KqBKsITG1gmujsJwIPqSeg215yygSZIoUpnhpv7E6tikJ-jK6M--mnu3g5LmZGu8lL2ZZMSlDx7iMHYLa-3x30d5dEEWasBBL-rJXLWnA

Had same issue today:
Failed to instantiate component or class "rias\positionfieldtype\assetbundles\positionfieldtype\PositionFieldtypeAsset".
↵
Caused by: ReflectionException
Class rias\positionfieldtype\assetbundles\positionfieldtype\PositionFieldtypeAsset does not exist

We have this issue all the time lately.
Doing composer update fixes it.

is this still an issue for you guys?

Closing due to age and lack of info.


Update libreoffice to 5.3.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Terminated because of No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. => download took too long.

Checking locally.

Thanks so much @vitorgalvao!


Reporting changes, but nothing has change

I'm using the command
./vendor/sourcerer-mike/phpsemver/bin/phpsemver compare --type git HEAD ./src/MainBundle
and having the result:
+-------+---------------------------------------------------------------------+
| Level | Message                                                             |
+-------+---------------------------------------------------------------------+
| major | AppCache removed                                                    |
| major | AppKernel removed                                                   |
| major | DBV removed                                                         |
| major | DBV_Adapter_DBLib removed                                           |
| major | DBV_Adapter_MySQL removed                                           |
| major | DBV_Adapter_PDO removed                                             |
| major | DBV_Adapter_PostgreSQL removed                                      |
| major | DBV_Adapter_SQLite removed                                          |
| major | DBV_Exception removed                                               |
| major | __() removed                                                        |
| major | DBV_Adapter_Interface removed                                       |
| patch | MainBundle\Entity\UserRepository::loadUserByUsername() body changed |
| patch | MainBundle\Service\Redacao::search() body changed                   |
| patch | MainBundle\Utils\Debug::finishCount() body changed                  |
+-------+---------------------------------------------------------------------+
But, none that report have a real change.
I try "git diff", "git log" and anything else, but nothing.

Sorry for taking so long to respond. Thank you for letting me know about this problem!
Is it within a public repository and can you name the URL to it?
Which version oh phpsemver did you use?
Thanks in advance!
Cheers,
Mike


Tests improvements and refactoring

@relu what's the status of this PR?

There might still be something valuable in here, I wasn't able to finish what I proposed to do in the first place though. I'll have another look over it.

This was superseded by #412 which included your S3 server mock, thanks a lot @relu :bow:


Remove streaming v1 datasets.

Should we also remove files under composer/datasets/streaming folder ?

Do we want to keep the example notebooks with streaming v2?

Was thinking of readding with fancy V3 afterward


Error occurs when running "python setup.py test"

🐛 Bug
So I followed the instruction in readme and successfully built habitat-sim and habitat-lab, and I ran python examples/example.py and python examples/benchmark.py with expected results.
But when I run python setup.py test, some error occurs like:
test/test_baseline_agents.py .........                                                                                [  5%]
test/test_baseline_trainers.py FFFFFFFFFFFFFFFFFFFF....FFFException ignored in: <function VectorEnv.__del__ at 0x7fdf1cc84b90>
Traceback (most recent call last):
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 529, in __del__
    self.close()
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 413, in close
    write_fn((CLOSE_COMMAND, None))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 206, in send
    self._send_bytes(_ForkingPickler.dumps(obj))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 404, in _send_bytes
    self._send(header + buf)
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor
Exception ignored in: <function VectorEnv.__del__ at 0x7fdf1cc84b90>
Traceback (most recent call last):
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 529, in __del__
    self.close()
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 413, in close
    write_fn((CLOSE_COMMAND, None))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 206, in send
    self._send_bytes(_ForkingPickler.dumps(obj))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 404, in _send_bytes
    self._send(header + buf)
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor
Exception ignored in: <function VectorEnv.__del__ at 0x7fdf1cc84b90>
Traceback (most recent call last):
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 529, in __del__
    self.close()
  File "/remote-home/my/habitat-lab/habitat/core/vector_env.py", line 413, in close
    write_fn((CLOSE_COMMAND, None))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 206, in send
    self._send_bytes(_ForkingPickler.dumps(obj))
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 404, in _send_bytes
    self._send(header + buf)
  File "/root/anaconda3/envs/vln/lib/python3.7/multiprocessing/connection.py", line 368, in _send
    n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor

How could I fix this?

The subprocesses are having trouble communicating, it's likely the simulator subprocesses are dying (segfaulting) or such. Ensure that everything is properly installed and all test asset files are available and in the proper location.
@erikwijmans might have a better idea of what is going on.

@PatZhuang  can you try older commit before https://github.com/facebookresearch/habitat-lab/commit/7537389aaf5bbd3c3a8524c492c4d520311b9c9d: git checkout b7a93bc493f7fb89e5bf30b40be204ff7b5570d7  and run python setup.py test there. Thank you!

Otherwise try clean conda environment and install again.

@PatZhuang can you try older commit before 7537389: git checkout b7a93bc493f7fb89e5bf30b40be204ff7b5570d7  and run python setup.py test there. Thank you!

Actually I switched to branch v0.1.6 and this problem no longer occurred. The test process finished with 11 tasks failed and 25 tasks skipped( I didn't download the full matterport3D dataset). But I don't see any explanation to why those tasks had failed, except for some "skipped" notice in the last lines of the output which are caused for I did not download the full matterport3D dataset.

Is that still test/test_baseline_trainers.py FFFFFFFFFFFFFFFFFFFF....FFFE failing?
Maybe, you can provide additional System Info to address the issue:
Please copy and paste the output from the
environment collection script
(or fill out the checklist below manually).
You can run the script with:
# For security purposes, please check the contents of collect_env.py before running it.
python habitat_sim/utils/collect_env.py

OS (e.g., Linux):
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version:
GPU models and configuration:
CUDA version:
PIP/conda dependencies packages versions
Any other relevant information:

Is that still test/test_baseline_trainers.py FFFFFFFFFFFFFFFFFFFF....FFFE failing?
Maybe, you can provide additional System Info to address the issue:
Please copy and paste the output from the
environment collection script
(or fill out the checklist below manually).
You can run the script with:
# For security purposes, please check the contents of collect_env.py before running it.
python habitat_sim/utils/collect_env.py

OS (e.g., Linux):
How you installed PyTorch (conda, pip, source):
Build command you used (if compiling from source):
Python version:
GPU models and configuration:
CUDA version:
PIP/conda dependencies packages versions
Any other relevant information:

Closing the issue because it has not had recent activity.


Uncertainty of the VSCode plugin

Not sure how to formulate this, so let's just state the facts:

https://documentation.mjml.io/#tooling links to https://github.com/mjmlio/vscode-mjml and https://marketplace.visualstudio.com/items?itemName=mjmlio.vscode-mjml
THIS repo in the about section links to https://marketplace.visualstudio.com/items?itemName=attilabuti.vscode-mjml
in the README.md of this repo the links also go to attilabuti.vscode-mjml

I understand, that there seems to be some kind of legacy-takeover by @mjmlio for the plugin, but even searching in VSCode for mjml ends me up with the following:

People might (and have, I did) ignore this version based on installs.
It would be nice, if this repo, IF it is the one official source for the plugin could somehow remove any ambiguity to the "old" plugin, maybe somehow add a paragraph about how it came about to be (forked the original plugin, etc) and the old plugin somehow could be removed or deprecated (VSCode offers a system where the old plugin can set some parameters in package.json and users get nudged to upgrade.
If of course the old maintainer just disappeared this won't be possible. In that case this repo at least should loose all "official" looking links to the old repo with a legacy note instead of even in the about-section linking to the old repo.
I am sure there can be done a little bit more to make this distinctively "the" repo for the MJML VSCode plugin... I actually forked the old repo myself because I thought there is no more current version and recent updates were missing. Let's make this one the main-one?

We have no control over this sadly, we should replace old url from this fork at least to make it clear that's the current maintained version we have

Hello, part of the issue is the link in the "About" section of this (mjmlio/vscode-mjml) repo that still links to the forked-from extension (attilabuti.vscode-mjml). It should link to mjmlio.vscode-mjml AFAIK.

Just open a PR about this we'll merge it quickly

It is not modifiable via a PR, a maintainer need to go on the Github web interface and change it by clicking on the cogwheel. Example on another repo :

It seems that it cannot be edited for official fork :/

Weird, I can on a fork such as this one. Maybe there is a configuration issue in the MJML's Github organisation rights ?


conversationsReplies does not support all parameters

ConversationsRepliesRequest does not support all parameters. Such as inclusive, latest and oldest.
Problem in RequestFormBuilder class in method toForm(ConversationsRepliesRequest)

Good catch. Thank you for pointing it out. I will work on the fix. If you're interested in contributing to this library, your PRs are always welcome.


Fix removing event listener inside listener

It's a common situation to remove an event listener inside its definition. Like this:
viewer.on('load', function foo() {
	//code
	viewer.off('load', foo);
});

In this case off function removes the item from externalEventListeners array, while looping through this array may be not finished in fireEvent function. A reverse iteration fixes it.
Since we'd like to fire listeners in the order they were added, we need to use externalEventListeners[type].length - i index.

Thanks!


Emitter duration alterable?

First of all, thanks for the pleasant library!
A question about the duration of emitter: is it alterable during runtime? If I init the emitter with duration: 10, it kind of works when I change it to 1. But if the emitter is init with duration: 1, it's ignored when I set the number to 10. Is it a bug or is the emitter's duration just not alterable during runtime?
Thanks!

By the sounds of it, it might be a bug. I'm really tied up at the moment so haven't had the time available to dedicate to this project - I'll try to have a quick look asap (hopefully over the next few days) to see if it's a bug or not. If not, then it's a feature I'd like to add, as it seems like it should be a thing.
You're welcome to delve in yourself and see if you can pick it apart if you'd like, though.
Will get back to you soon!


Investigate pooling of HashAlgorithm instances in KeyVault CryptographyClients.

Internally the CryptographyClient creates HashAlgorithm instances to compute hashes.  We should investigate if these could be reused to reduce allocations.

According to https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.hashalgorithm.canreusetransform?view=netstandard-2.0#property-value this property always returns true, though it is virtual. No algorithm we support based on their Windows implementation currently overrides that; however, this is not thread-safe. As such, we should create new instances with each use.


Update version to 1.0.69-0 on staging

Update version to 1.0.69-0

🚀 Cherry-picked to staging in version: 1.0.69-0🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.73-3🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Move Tabs to LEFT does not work properly

Version: 1.0.131-nightly.0
Platform: win32 10.0.19042
Plugins: clickable-links
Moving Tabs to Left or right creates a small height panel that is not very friendly and can display only one tab at a time. It involves lots of scrolling to go to the right tab if you have multiple tabs open. The height of panels created while switching tab to left/right needs to be addressed.

Could you post a screenshot? All tabs are supposed to be visible at the same time:

Attaching screenshots for reference...
[Tab Location: TOP]

[Tab Location: LEFT]

Only one tab is visible when tabs are aligned to left side. A small slider is visible though. I was able to access other tabs using this slider.

Fixed in nightly.


I cannot figure out how to declare what should happen when no routes are matched.

I am getting "Fatal error: Uncaught exception 'League\Route\Http\Exception\NotFoundException' with message 'Not Found'"
Should I wrap $route->dispatch() in a try catch or is there some special 404 route or catch-all I can set up?
Or can I define some kind of super greedy regular expression addPatternMatcher alias and set that as the very last route so if no router before that was matched, it will be run?
I'm trying to make a view that says "Page not Found" that uses the same layout as the rest of the project.

There are two ways to do this, one is as you mentioned, wrapping dispatch in a try catch, or by creating a custom strategy that handles not found in a different way.
I'll mirror what I said on another issue that this isn't a framework so we make no assumptions around how not found should be handled.
Take a look here http://route.thephpleague.com/custom-strategies/ for custom strategies, as well as the default strategies in the repository for guidance.


build: Included githubactions in the dependabot config

This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.
Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot
GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool

Thanks for your contribution, but we use Renovatebot to update github actions.


Test confirmation

/confirm

/unconfirm

/confirm

@usernamehw @cleidigh FYI: I've added an /unconfirm command for you to flag issues that you have looked into, but could not reproduce yourself. (Thanks for the suggestion @usernamehw!)

The main idea of my comment was to get help in reproducing the issue (the one that's already has steps). Something like:

tagging a random vscode team member to try to repro
Putting somewhere alongside existing
help-wanted - welcomes PR,
unconfirmed - welcomes info if the issue could be reproduced at all and repro steps

Current label and its description is probably going to discourage people to file bugs.

@usernamehw Makes sense. What about /confirmationPending and confirmation-pending? That seems to capture what you propose.

What about /confirmationPending and confirmation-pending?

👍

/confirmationPending


Fix/unintended session at end

resolves #

Description

Moved the interactive-session initialisation logic into the scope of cursor() use rather than handle scope

Checklist

[ ] I have signed the CLA
[X] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@menuetb pls review and merge


creator tools icon bug

Requesting a new config when a user logs in/out because we show the dashboard icon based on the config.
Thank you @justinswart for all your help!

 Creator tools instrumentation

 Android creator dashboard icon doesn't always show on load


Switch to using Boxroot for root handling

@g2p here is the WIP work on boxroots integration, I don't think the code will change much more, but I still have to finish the docs.

pub fn make_some(cr: &mut OCamlRuntime, value: String) -> Option<String> {
    ocaml_frame!(cr, (root), {
        let str = to_ocaml!(cr, value, root); // `OCamlRef<String>`
        let result = ocaml::make_some(cr, str);
        result.to_rust()
    })
}

should now be written as:
pub fn make_some(cr: &mut OCamlRuntime, value: String) -> Option<String> {
    let str = value.to_ocaml_rooted(cr); // BoxRoot<String>
    let result = ocaml::make_some(cr, &str); // dereferenced into `OCamlRef<String>`
    result.to_rust(cr)
}

To note:

ocaml_frame! macro is gone
to_ocaml! macro is gone
New to_ocaml_rooted method in the ToOCaml trait, which is the same as to_ocaml but returns a rooted value (a BoxRoot<T> instead of an OCaml<'gc, T>.

This BoxRoot<T> is an owned root, it can be passed around (not bound to the stack lifetime like local roots). Once dropped will delete the root on the OCaml side so that the pointed-to value can be collected. An OCaml<'gc, T> value can be recovered with cr.get(boxroot), and boxroots also deref into OCamlRef<T> references that are what OCaml functions expect as inputs.

cc @zshipko

Cool! I will create a new ocaml-rs branch later today to start integrating these changes

Still unsure about the name to_ocaml_rooted, too long and ugly, considering to_boxroot.