Audio input device issue when device is removed

Describe the bug
If the selected audio input device is removed a new device must be selected before the audio input works again. Adding the audio input device again does not resolve the issue.
This is a bigger problem in firefox because if you have 2 input devices and remove 1 you can't get the remaining input device to work without refreshing the page. When you have at least 3 input devices, you'll have 2 left after removing one so you're able to select an input device.
I think this occurs for output devices as well, but I only tested inputs.
To Reproduce
Steps to reproduce the behavior:

Start the app with at least 2 audio inputs available on your device (ex: laptop with an internal microphone and external microphone)
Open the audio and video settings modal
Select the removable audio input device (if not already selected)
Remove the audio device
Notice the dropdown either becomes empty, or changes the selected value, but no input is captured

Expected behavior
Another input device should be selected automatically and capture input
Screenshots
Chrome Demo - In this video I show what happens when unplugging my mic when it is selected
https://user-images.githubusercontent.com/100885/111847680-b030ba00-88df-11eb-8ddf-6361bfbbfb0b.mp4
Environment (please complete the following information):

OS: OSX 10.15.7
Browser: Chrome 89.0.4389.90, Firefox 86.0
App Version: 0.2.3 (a6fc6c9826bdb39fe9cb5be423bdb17a44286180)
SDK Version: 2.12.0
Node.js version: 12.20.1

Additional context
I tried adding logic to AudioInputList to detect when the audio input device list changed and calling localAudioTrack?.restart with either a new device id if the existing one is missing or the same device id if the device id is the same but the group id changed. That did work, but I doubt this is the correct place for this logic since it would only change/restart the input device when the audio and video settings modal is open.
Let me know if there's anything else I can provide.

Thanks for the detailed bug report @coreymaher!!
I can confirm that this issue is present in the app. I have created a bug ticket and added it to our backlog.
I'll ask around the team here to see what the best approach might be, but I think we will need to listen to the devicechange event on the navigator.mediaDevices property, as it is fired whenever a device is removed from the system. When this event is fired, we can check to see if the audio track that was published to the room was supplied by the removed device (by checking to see if the device is still returned by navigator.mediaDevices.enumerateDevices()). If it was removed, we can call audioTrack.restart() without a deviceId to capture the system's default audio device and publish it to the room. I think this logic could go somewhere in the VideoProvider component.

Thanks for the info @timmydoza! Is there a public backlog or roadmap for this repo (and/or twilio-video in general)? I'd be curious to see which improvements and bug fixes are coming soon and which ones I should attempt to work-around on my own.
Thanks for the great project and all your team's hard work!

Thanks @coreymaher!
Twilio video doesn't have a public roadmap, but the bugs found in our github issues will have fixes coming at some point. Generally, if a bug isn't going to be fixed, or a feature request isn't going to be implemented, we will close the issue.

Hi @timmydoza thanks for your responses here. I'd like to +1/bump on this one for prioritization if possible. With WFH, headphones are ever more common. Totally understand if you guys are swamped but would be helpful to understand if a fix could be expected on a scale of days, weeks, or months, so that I can prioritize on my side as well. Thanks again!

Thanks for the additional info @jszem!
I was able to consistently reproduce this issue with wired headphones (with mic), so I understand that this issue has the potential to have a significant impact on users. We will bump the priority of the bugfix. It's added to our next sprint, so I expect that the fix should be merged within the next week or two.

Hi @coreymaher and @jszem! This fix has been merged into master 🙂 . Please let us know if you run into any more issues. Have a great weekend!

Thanks @olipyskoty! I can't wait for the next release, it looks like a bunch of good features and fixes are going to be part of it!

@olipyskoty I had a chance to test out this fix and it works great in Chrome! Unfortunately, it doesn't appear to work in Firefox.
When I unplug my external mic a few errors are printed to the console and it doesn't end up capturing output from the other device.
Here are the errors I'm seeing:
2021-04-21T13:59:25.750Z error [LocalAudioTrack #1: {b8aef587-7138-0e4f-958a-13af62165c48}] Failed to re-acquire the MediaStreamTrack:
Object { error: MediaStreamError, constraints: {…} }
index.js:1
    e index.js:1
    overrideMethod react_devtools_backend.js:2557
    log log.js:179
    error log.js:269
    _restart localmediatrack.js:208
    (Async: promise callback)
    _restart localmediatrack.js:207
    restart localmediatrack.js:289
    restart localaudiotrack.js:141
    handleDeviceChange useRestartAudioTrackOnDeviceChange.ts:19
    (Async: EventListener.handleEvent)
    useRestartAudioTrackOnDeviceChange useRestartAudioTrackOnDeviceChange.ts:23
    React 6
    unstable_runWithPriority scheduler.development.js:697
    React 4
    unstable_runWithPriority scheduler.development.js:697
    React 5
    getAudioAndVideoTracks useLocalTracks.ts:93
    getAudioAndVideoTracks useLocalTracks.ts:93
    PreJoinScreens PreJoinScreens.tsx:37
    React 6
    unstable_runWithPriority scheduler.development.js:697
    React 4
    unstable_runWithPriority scheduler.development.js:697
    React 6

and
Uncaught (in promise)
MediaStreamError { name: "OverconstrainedError", message: "Constraints could be not satisfied.", constraint: "deviceId", stack: "" }

Let me know if you need any more info or would like me to open up a separate bug report for this issue.
Thanks again for all the help!

Hi @coreymaher thanks so much for bringing this to our attention. I can reproduce the issue in Firefox exactly as you described.  I've added a new bug ticket to our backlog, and we'll let you know as soon as the fix is merged. Have a good weekend!

Thanks for taking a look @olipyskoty! Have a good weekend as well!

Hi @coreymaher, thanks again for bringing the Firefox bug to our attention. The fix has been merged into the master branch 🎉. Please reach out if you have any questions or run into any more issues!

Thanks so much @olipyskoty!


Convert parcel ports into a plugin system

We should allow for third party people to supply there own parcel port implementation at runtime. The easiest would be to load parcel ports from separate shared libraries and accessing them using a virtual function interface.

This has been done with merging #1361.


Add size-limit

Will fail the CI if the library grows too big.
Run npm run size -- --why to run Webpack Bundle Analyzer.

Worth adding some kind of a size badge to the Readme — this library is 10 times smaller then most alternatives.
P. S. Depends on #38 to fix tests.

Neat! I hadn't heard of size-limit before.
Adding a badge on size is a good idea, too. I haven't thought about it very actively, but I have put a lot of effort into minimizing dependencies.
Some local changes do push this size a tad over 4 KB, so I'm thinking of upping the limit to 5 KB, and am hoping that works for you, too?
Thanks for contributing! And sorry for the delay getting back to you


Custom 3D mesh generation example does not work

Bevy version
0.11.3
[Optional] Relevant system information
If you cannot get Bevy to build or run on your machine, please include:
Rust version: 1.71.0
OS: Ubuntu Linux 22.04
Hardware:

CPU: AMD Ryzen 5 5600

  AdapterInfo { name: "NVIDIA GeForce GTX 1070", vendor: 4318, device: 7041, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "525.125.06", backend: Vulkan }

What you did
Create a new project with cargo new Add bevy as a dependency.
Copy the code in https://github.com/bevyengine/bevy/blob/latest/examples/3d/generate_custom_mesh.rs into main.rs
Do cargo run
What went wrong
Screen appears grey, no mesh is visible. Inspecting the renderer with renderdoc seems to show no dedicated draw call is being issued for geometry.
Additional information

This examples requires assets/textures/array_texture.png, have you added it to your project folder? Also, there is any warning or error in the console output?
I tested it here, on my Windows 11 machine, and it worked fine, I did a clean cargo new project.

Oh I see, the engine does throw a warning, rather than an error explaining the issue which is why I missed it. Thank you.


Reports >> Income Statement is brokeb

ArgumentNullException: Value cannot be null. (Parameter 'source')
System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
System.Linq.Enumerable.Where(IEnumerable source, Func<TSource, bool> predicate)
AspNetCoreGeneratedDocument.Views_Financials_IncomeStatement.ExecuteAsync() in IncomeStatement.cshtml
+
var netIncome = Model.Where(a => a.IsExpense == false).Sum(a => a.Amount) - Model.Where(a => a.IsExpense == true).Sum(a => a.Amount);

Previous owner have deleted the entire code for Income Statement. They have commented that "this generates an error a.ContraAccounts' is invalid inside an 'Include' operation".
I got the same error.
TODO:
[] - Create new method to get income statement from DB.


AfterContentInit should mention that it gets called before structural directives are being initialized

The documentation for AfterContentInit states:

Implement this interface to get notified when your directive's content has been fully initialized.

Note the word "fully". I think it's misleading. I spent multiple hours trying to find out why the stuff I was trying didn't work. Structural templates like *ngFor don't get resolved before the code reaches AfterContentInit, which means using @ContentChildren(ChildComponent) works for
<ChildComponent><ChildComponent></ChildComponent></ChildComponent>

but it fails for
<ChildComponent><ChildComponent *ngFor="..."></ChildComponent></ChildComponent>

I think this behaviour is not always intuitive (especially for people new to Angular) and should be clarified.

Sorry that it took soooooo long to answer. Not sure how I missed it, I check all the issues once a month.
API issues belong to the angular/angular repo because that text you quote is extracted from there.
If you see that it is still an issue, please open an issue there.


Setting link length to be uniform

Would be nice to adjust the links in a  network to be the same length.

This isn't geometrically possible. Consider a network like this:
A - B - E
 \ / \ /
  C - D

There's no way in two dimensions to connect A to E with a link that's the same distance as all the other links. The same holds true for only slightly more complex examples in three dimensions. It may be possible under our implementation of Nearest Neighbor, but I'm not certain and would need to think about the edge cases a bit. Even if it turns out to be, I think that the added complexity isn't going to be worth the effort for just NN networks.

Thanks @AABoyles. The primary use case we're envisioning is mimicking BioNumerics.
This may not be geometrically possible in all cases, but we just got off of a call where we saw a live example of a 2D network with fixed lengths. That being said, I did say:
"This is a feature constraint that we may need to relax due to technical reasons, so I want to set expectations."

One way we might be able to accomplish this is by increasing d3-force's Link Strength. That way, the physics engine would work harder to make the link lengths agree. We could add the slider to do that with minimal effort.

Thanks, Tony. I will look into it.

I tried a slider of link strength but not sure it will meet the expectation. Google around, I found this link, basically stating no built-in way to enforce a fixed length.

Thanks @mchiuw. That had to be the case (again, because this constraint can't be enforced globally for certain network structures), my suggestion was just a way to get closer to the mark. I'm excited to see your implementation!


Added DAST to tweek

close #235
WIP

@michaelkruglos do you mean if we need to have 2 different installation of Glue?

@Yshayy there is already an issue for that - see #644


Correction to "enter d6 past".

Even with tune of ages, still need to be able to cross the water channel
in the cave.

Wouldn't adding feather be enough?

Ah, true. Updated. This method of entry is far from obvious though, so, your call if you want it in normal logic.

Definitely not obvious, but not far from timewarp guard skip either, which is also normal logic.
I might have to go back through normal logic at some point though; there are things like Moonlit Grotto bridge shenanigans that probably don't belong there.


Prevent webpack from running twice at a time

What kind of change does this PR introduce?
improve DX by explicit error messages

Did you add tests for your changes?
yes

If relevant, link to documentation update:
N/A

Summary
If webpack somehow starts in a synchronous manner like:
compiler.run();
compiler.run();
// or
compiler.run()
compiler.watch()
// or
const compiler = webpack({}, () => {})
compiler.run()

it will produce wierd and syntactically wrong code.
This PR add some flag to check if compiler in running state and prevent any starts until it done.

Does this PR introduce a breaking change?
no

Other information
Related to #6667

I'll see for multi

@ooflorent ready, but I'm not sure for watch. It's not so easy to understand all these callback's, especially if they shadowing each other.

Thanks


Macbook上碰到https的错误

➜  ProxyPool git:(master) pip3 install -r requirements.txt
pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
Collecting aiohttp>=1.3.3 (from -r requirements.txt (line 1))
  Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/aiohttp/
  Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/aiohttp/
  Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/aiohttp/
  Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/aiohttp/
  Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/aiohttp/
  Could not fetch URL https://pypi.org/simple/aiohttp/: There was a problem confirming the ssl certificate: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /simple/aiohttp/ (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.")) - skipping
  Could not find a version that satisfies the requirement aiohttp>=1.3.3 (from -r requirements.txt (line 1)) (from versions: )
No matching distribution found for aiohttp>=1.3.3 (from -r requirements.txt (line 1))
pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
Could not fetch URL https://pypi.org/simple/pip/: There was a problem confirming the ssl certificate: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /simple/pip/ (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.")) - skipping
➜  ProxyPool git:(master)

New version is released, please try it.


Deprecated DevContainer

This devcontainer is deprecated, plaese replace it.
https://github.com/ludeeus/container#deprecated

@tmack8001 I have local changes that replace the use of this container on my box already. I can do a PR for this shortly if you haven't already started on it.

In trying to upgrade my HA I have borked my HA devcontainer. Keep getting errors on onboarding about InvalidUser though the storage is empty and never had a user.
Need to figure that out.
No haven't started work on this at all just using the prior container, maybe that is the problem?


support pem in both base64 and plain text

certs in HTTP server spec were in plain text before but were updated to base64 encoding in #391 , this PR auto-detect the encoding, and the certs could be in either plain text or base64.

Codecov Report

Merging #425 (965cac0) into main (554efe7) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   80.43%   80.18%   -0.26%
==========================================
  Files          70       70
  Lines        8093     8093
==========================================
- Hits         6510     6489      -21
- Misses       1223     1244      +21
  Partials      360      360

Impacted Files
Coverage Δ

pkg/object/mqttproxy/session.go
74.23% <0.00%> (-7.98%)
:arrow_down:

pkg/cluster/cluster.go
49.65% <0.00%> (-1.03%)
:arrow_down:

pkg/object/mqttproxy/client.go
77.67% <0.00%> (-0.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 758c860...965cac0. Read the comment docs.


chore: take down diff&canary release workflow temporarily

Summary

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

!canary


Restructure the tests

It does not make sense to create the __test contains the storybook config. So thinking another name such as stories and move the test file to another directory or single file

@nvhoc can u help to rename testsfolder to vr-test?

now it becomes
my-react-component
  |-- stories/
      |-- vr-test/
          |-- index.spec.ts
      |-- story-1.story.tsx
      |-- story-2.story.tsx
      |-- story-3.story.tsx
  |-- index.tsx
  |-- style.less


Crash loop after upgrading server from v1.19.7+k3s1 to v1.20.4+k3s1

Environmental Info:
K3s Version: v1.20.4+k3s1
Node(s) CPU architecture, OS, and Version:
Linux pi8s-1 5.4.0-1030-raspi #33-Ubuntu SMP PREEMPT Wed Feb 24 11:20:11 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
Cluster Configuration:
1 master, 3 workers
Describe the bug:
After starting the upgrade plan, the master node fails to become stable. It goes into a loop where it's Ready for a few seconds and then k3s crashes out.
Steps To Reproduce:
Run in the following plan:
apiVersion: upgrade.cattle.io/v1
kind: Plan
metadata:
  name: server-plan
  namespace: system-upgrade
spec:
  concurrency: 1
  cordon: true
  nodeSelector:
    matchExpressions:
    - key: node-role.kubernetes.io/master
      operator: In
      values:
      - "true"
  serviceAccountName: system-upgrade
  upgrade:
    image: rancher/k3s-upgrade:v1.20.4-k3s1-arm64
  version: v1.20.4+k3s
---
# Agent plan
apiVersion: upgrade.cattle.io/v1
kind: Plan
metadata:
  name: agent-plan
  namespace: system-upgrade
spec:
  concurrency: 1
  cordon: true
  nodeSelector:
    matchExpressions:
    - key: node-role.kubernetes.io/master
      operator: DoesNotExist
  prepare:
    args:
    - prepare
    - server-plan
    image: rancher/k3s-upgrade:v1.20.4-k3s1-arm64
  serviceAccountName: system-upgrade
  upgrade:
    image: rancher/k3s-upgrade
  version: v1.20.4+k3s

Expected behavior:
The cluster upgrades successfully
Actual behavior:
The master node goes into a crash loop
Additional context / logs:
There's a huge golang stack trace in the journal log but this appears to be the root cause:
Mar 24 17:10:56 pi8s-1 k3s[7358]: F0324 17:10:56.260671    7358 controllermanager.go:168] error building controller context: failed to wait for apiserver being healthy: timed out waiting for the condition: failed to get apiserver /healthz status: an error on the server ("[+]ping ok\n[+]log ok\n[+]etcd ok\n[+]poststarthook/start-kube-apiserver-admission-initializer ok\n[+]poststarthook/generic-apiserver-start-informers ok\n[+]poststarthook/priority-and-fairness-config-consumer ok\n[+]poststarthook/priority-and-fairness-filter ok\n[+]poststarthook/start-apiextensions-informers ok\n[+]poststarthook/start-apiextensions-controllers ok\n[+]poststarthook/crd-informer-synced ok\n[+]poststarthook/bootstrap-controller ok\n[-]poststarthook/rbac/bootstrap-roles failed: reason withheld\n[+]poststarthook/scheduling/bootstrap-system-priority-classes ok\n[+]poststarthook/priority-and-fairness-config-producer ok\n[+]poststarthook/start-cluster-authentication-info-controller ok\n[+]poststarthook/aggregator-reload-proxy-client-cert ok\n[+]poststarthook/start-kube-aggregator-informers ok\n[-]poststarthook/apiservice-registration-controller failed: reason withheld\n[+]poststarthook/apiservice-status-available-controller ok\n[+]poststarthook/kube-apiserver-autoregistration ok\n[+]autoregister-completion ok\n[+]poststarthook/apiservice-openapi-controller ok\nhealthz check failed") has prevented the request from succeeding
Mar 24 17:10:56 pi8s-1 k3s[7358]: goroutine 19145 [running]:
Mar 24 17:10:56 pi8s-1 k3s[7358]: github.com/rancher/k3s/vendor/k8s.io/klog/v2.stacks(0x40001a0001, 0x4018310600, 0x56d, 0x5b4)
Mar 24 17:10:56 pi8s-1 k3s[7358]:         /go/src/github.com/rancher/k3s/vendor/k8s.io/klog/v2/klog.go:1026 +0xac
Mar 24 17:10:56 pi8s-1 k3s[7358]: github.com/rancher/k3s/vendor/k8s.io/klog/v2.(*loggingT).output(0x675bac0, 0x4000000003, 0x0, 0x0, 0x401830e230, 0x63d5e24, 0x14, 0xa8, 0x0)
Mar 24 17:10:56 pi8s-1 k3s[7358]:         /go/src/github.com/rancher/k3s/vendor/k8s.io/klog/v2/klog.go:975 +0x168
Mar 24 17:10:56 pi8s-1 k3s[7358]: github.com/rancher/k3s/vendor/k8s.io/klog/v2.(*loggingT).printf(0x675bac0, 0x4000000003, 0x0, 0x0, 0x0, 0x0, 0x3d573c8, 0x25, 0x40182ff4f0, 0x1, ...)
Mar 24 17:10:56 pi8s-1 k3s[7358]:         /go/src/github.com/rancher/k3s/vendor/k8s.io/klog/v2/klog.go:750 +0x12c
Mar 24 17:10:56 pi8s-1 k3s[7358]: github.com/rancher/k3s/vendor/k8s.io/klog/v2.Fatalf(...)

Looks like this might be the same as #2425

Yes, definitely the same. I haven't had a chance to dig into the upstream code to figure out why the rbac stuff fails on slow systems.

OK, closing since it's a duplicate


Bad Name Index<PHONE_NUMBER>/176

Just installed ark server for the first time and getting this error. Don't know what it means , could anyone help.

May you provide more details and context please?

It is ok now. had to re-install four times before i got there but it is working now.
Thank you for your response.

Sounds like Steam was being a bit silly.


Placeholder attribute on control instead of @placeholder argument on element does not render placeholder

While using @placeholder on a Form.element of type power-select works, it is deprecated. The alternative of using the placeholder attribute on the Form.element.control doesn't work (for me) however.
This renders the palceholder correctly but gives a deprecation warning:
<Form.element
    @controlType="power-select"
    @property="property"
    @onChange={{this.setProperty}}
    @options={{this.propertyChoices}}
    @label="some label"
    @placeholder="placeholder"
    as |Element|
    >
    <Element.control
      as |option|
    >
      {{option}}
    </Element.control>
  </Form.element>

This doesn't render the placeholder:
<Form.element
    @controlType="power-select"
    @property="property"
    @onChange={{this.setProperty}}
    @options={{this.propertyChoices}}
    @label="some label"
    as |Element|
    >
    <Element.control
      placeholder="placeholder"
      as |option|
    >
      {{option}}
    </Element.control>
  </Form.element>

Is this an issue or am I making a mistake?

If using @controlType="power-select" through ember-bootstrap-power-select the yielded <Element.control> is a <PowerSelect> component. That one accept a @placeholder argument. It forwards HTML attributes to the underlying <BasicDropdown>. That's not what you want.
TL;DR: Your code should look like this:
  <Form.element
    @controlType="power-select"
    as |Element|
  >
    <Element.control
      @placeholder="placeholder"
      as |option|
    >
      {{option}}
    </Element.control>
  </Form.element>

Ah, I see. That works. Thanks a lot!

It looks like
addon/components/bs-form/element/control/power-select.hbs
was recently changed to remove the line
@placeholder={{@placeholder}}
which means that the placeholder option is not passed to the placeholder component, so the placeholder does not appear.
Restoring that line will fix the problem.

It was removed in #113. @simonihmig Can you explain why? Or was it just an accident?

any news on that?

any news on that?

I'm also wondering the same, seems now we are "forced" to use a placeholderComponent? It would be good to get an official position on this.

I'm also wondering the same, seems now we are "forced" to use a placeholderComponent? It would be good to get an official position on this.

I assume it was a mistake. I would accept a merge request adding @placeholder argument back to <BsForm::Element::Control::PowerSelect> and <BsForm::Element::Control::PowerSelectMultiple>. It should only add test coverage. The merge request should include test coverage.
I think most of the code can be pulled in again from #113. But tests need to be updated to not rely on <BsForm::Element> passing @placeholder to the control. Instead the argument should be set on yielded control directly. See https://github.com/kaliber5/ember-bootstrap-power-select/issues/99#issuecomment-670380846.
Sorry that it took so long for an official statement.

I assume it was a mistake. I would accept a merge request adding @placeholder argument back to <BsForm::Element::Control::PowerSelect> and <BsForm::Element::Control::PowerSelectMultiple>. It should only add test coverage. The merge request should include test coverage.
I think most of the code can be pulled in again from #113. But tests need to be updated to not rely on <BsForm::Element> passing @placeholder to the control. Instead the argument should be set on yielded control directly. See https://github.com/kaliber5/ember-bootstrap-power-select/issues/99#issuecomment-670380846.
Sorry that it took so long for an official statement.

Sorry for the late feedback, this slipped through unfortunately.

It was removed in #113. @simonihmig Can you explain why? Or was it just an accident?

Looking back, I guess my thought was that as the other built-in control components also don't accept a @placeholder argument  anymore (they do accept a placeholder attribute though of course), this needed to be applied also to power-selects. But I guess this was wrong, when power-selects do still expect users to use a @placeholder argument. I think the same applies to @disabled also being removed as part of #113.
So yes, reverting these parts of #113 seems right. Stupid me, sorry! 😔
I someone is able to contribute a PR, bringing back the arguments and the removed test cases, that would be awesome! Otherwise I hope I can do that next weekend...


How to stop the session?

For example, I want have 2 sessions in one node api, one after one. But when i use the second Google login/pass, there is an old user "ingame" yet. How can I stop old User playind and start new User playing session?

Initialise two clients.
let user1 = new pogobuf.Client();
let user2 = new pogobuf.Client();

Then use the auth objects to fetch tokens and give them to each client individually.

You could technically also call client.setAuthInfo() and client.init() again (that will properly reset stuff since a few commits ago).
But simply creating a new client instance is easier.

No, I need just to kill current user session. How can I do that? I have already use "delete client;", but in didn't help

I fix my problem, thank you.


Invalid constraints errors when using dynamic height for the cell's top label

[x] I have read the README, documentation, and FAQ.
[x] Contributing guidelines confirmation: YES
[x] I have searched existing issues and this is not a duplicate.

General information

JSQMessagesViewController version: 7.3.4
iOS version: 10.2
Devices/Simulators: iPhone 6 64GB
Reproducible in the demo project? (Yes/No): No
Any related issues: Haven't found anything related

What happened?
Xcode prints the following errors when I scroll through the long chat history:

[LayoutConstraints] Unable to simultaneously satisfy constraints.
Probably at least one of the constraints in the following list is one you don't want.
Try this:
(1) look at each constraint and try to figure out which you don't expect;
(2) find the code that added the unwanted constraint or constraints and fix it.
(Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<NSAutoresizingMaskLayoutConstraint:0x174481b80 h=--& v=--& UIView:0x100974490.height == 38   (active)>",
"<NSLayoutConstraint:0x1744804b0 JSQMessagesLabel:0x10099e690.height == 20   (active)>",
"<NSLayoutConstraint:0x174480960 JSQMessagesLabel:0x10099e940.height == 20   (active)>",
"<NSLayoutConstraint:0x174481ea0 JSQMessagesLabel:0x1009a1aa0.height == 0   (active)>",
"<NSLayoutConstraint:0x174481fe0 V:|-(0)-[JSQMessagesLabel:0x10099e690]   (active, names: '|':UIView:0x100974490 )>",
"<NSLayoutConstraint:0x1744820d0 V:[JSQMessagesLabel:0x10099e690]-(0)-[JSQMessagesLabel:0x10099e940]   (active)>",
"<NSLayoutConstraint:0x174482170 V:[JSQMessagesLabel:0x10099e940]-(0)-[UIView:0x100982a50]   (active)>",
"<NSLayoutConstraint:0x174482300 V:[JSQMessagesLabel:0x1009a1aa0]-(0)-|   (active, names: '|':UIView:0x100974490 )>",
"<NSLayoutConstraint:0x174482350 V:[UIView:0x100982a50]-(0)-[JSQMessagesLabel:0x1009a1aa0]   (active)>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x174480960 JSQMessagesLabel:0x10099e940.height == 20   (active)>
Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

I think this problem is related to the cell's topLabel and corresponding delegate methods. So if I either do not implement them or return nil / 0.0f values the log is clean. Another option to get rid of these errors is to return constant height value from the heightForCellTopLabelAtIndexPath method.
Here's my code:
- (NSAttributedString *)collectionView:(JSQMessagesCollectionView *)collectionView attributedTextForCellTopLabelAtIndexPath:(NSIndexPath *)indexPath
{
    if (path.item % 3 == 0) {
        MYPChatMessage *message = [self.messages objectAtIndex:path.item];
        return [[JSQMessagesTimestampFormatter sharedFormatter] attributedTimestampForDate:message.date];
    }

    return nil;
}

- (CGFloat)collectionView:(JSQMessagesCollectionView *)collectionView
                layout:(JSQMessagesCollectionViewFlowLayout *)collectionViewLayout heightForCellTopLabelAtIndexPath:(NSIndexPath *)indexPath
{
    if (path.item % 3 == 0) {
        return kJSQMessagesCollectionViewCellLabelHeightDefault;
    }

    return 0;
}

Note that this bug is also present when the using dynamic height for the message bubble's top label. With a fixed (zero height, nil string) cell top label but a variable message bubble top label I get an identical error in the console log.

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


[GLUTEN-6016][CH] Add uts for decimal convert to int overflow case

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #6016)
Notice: must be merged before: https://github.com/Kyligence/ClickHouse/pull/494

Let's see it failed at first :)

Run Gluten Clickhouse CI


relations should be a required field

entity.relations and event.relations is a required field according to https://github.com/InTaVia/api-client/blob/main/src/models.ts#L98 and https://github.com/InTaVia/api-client/blob/main/src/models.ts#L109

but its not in the swagger of the API right? and at least for the entities I would keep it that way. Why would an entity need relations to events (could be that we dont even know the date of birth). We could change it for the events though, given that those events need at least one related entity.

we did agree on an api contract, can we please stick to that?

ok, I can change the API for now, but in the long run we should think about changing that to optional as I am pretty sure we will exclude a lot of entities eg from BiographyNET via making relations required (although obviously entities that dont have relations are also not very interesting)

:) sure, got that completely wrong thought of list.len() > 0 vs None
I will change that


Add link to docs in major README

close #176
Signed-off-by: David Liu<EMAIL_ADDRESS>

@litong01 changed accordingly.


New Release

Are there plans to tag a new release with the fix to support 5.7+? I switched my composer to "dev-master" for now, but it feels dirty. Thanks!

New release would indeed be nice! Including the recent PR #19.

0.3 is 7+


BUG: fix session_distance for flipped ranges

Coverage decreased (-0.5%) to 86.617% when pulling 4279f6b69e9f5936e8012b5f7deb72280c4a60cd on signed-distance into 94237421d6ae0a5038c172a6b0200f0bd6be29d9 on master.

Coverage decreased (-0.5%) to 86.617% when pulling 4279f6b69e9f5936e8012b5f7deb72280c4a60cd on signed-distance into 94237421d6ae0a5038c172a6b0200f0bd6be29d9 on master.

LGTM


[rlwe]: Merge fails with ring.Type = ring.ConjugateInvariant

Method tries to operate an automorphism by GalEl^-1 but this is not defined and required in this ring.

#379


How to fire django_chatterbot from an existing .Net Web application.

Hello All,
This is not an issue. Just a question.
I have build a chatbot using django using chatterbot. I want it to integrate in an existing .Net web application. I want to call this application from an existing .Net application. Please guide me if anyone has any information regarding this.

Hi @vedantnarayan,
I have never tried this, but one possibility might be Iron Python (http://ironpython.net/). I've never tried it but it might be worth experimenting with.


New Services menu needs to be updated in WordPress/eNews pages

The old header and menu is still there:
http://enews.patricbrc.org/category/patric-in-the-news/

Looks to be fixed


chore: Updated Dependencies

Pull Request Test Coverage Report for Build 2d5518bbeb96e64a8d2d5ffa3df3e65dc5eb59f7-PR-11

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.235%

Totals

Change from base Build 76e00ce7c30a54c15a427f3cd0481d3fc98aa605:
0.0%

Covered Lines:
355

Relevant Lines:
528

💛  - Coveralls


Improve keyboard accessibility

For example Today shortcut or clearing the value should be doable with keyboard.

Closely related to #195

This issue was fixed by #247


Color theme per window or project

Issue Type: Feature Request
When I work on two projects at once, I happen to confuse which VS Code window I am reading from or writing to. For this it would be super helpful if one VS Code instance would be a color and the other one to be a different color. I tried to set the color theme in one window but then as soon as I focused in the other window it picked up the same theme.
Would be great to have color themes per folder/project.
If this makes sense for more people.
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

You should be able to do this by adding the desired theme to .vscode/settings.json in your projects. For instance, adding
{
    "workbench.colorTheme": "Default Dark+"
}

Let us know if that works for you.
/needsMoreInfo

@connor4312 Thank you very much for the info! I didn't know I can do it like this. There are many things I don't know about what VS Code can do.


Optionally render in transclusions and other areas

I'm loving using this, but it looks like it doesn't render in transcluded link embeds. Could this be added?
More generally, it would be nice to optionally render matched text in frontmatter YAML, backticked-text, quotes (lines starting with > ), transclusions, and maybe other areas too. I'd love to have a way to specify where to render or not render per highlight entry.

+1 for rendering in embeds

+1 for rendering in embeds

I've also noticed that this doesn't work yet in callouts.

This will require #26 to be implemented first. Once it works in preview mode, it will automatically work in embeds and callouts. I have not started work on preview mode support but it's on the roadmap.

+1
This plugin is really good, I hope you can also see it in the embed


Create separate page for each Relaton processor, and write out how to cite (with examples of document identifiers)

Create separate page for each Relaton processor, and write out how to cite (with examples of document identifiers)

@andrew2net can you please help with this? We can add a separate documentation page within each gem if needed.

https://github.com/relaton/relaton.github.io/issues/35

@ronaldtse do we really need to create separate pages? There are almost empty gems' pages already. https://www.relaton.org/software/relaton-iso/

@andrew2net yes. We need to.


Update curl examples to use 'localhost'

Proposed changes
Update curl examples to use localhost instead of <IP_ADDRESS>
Fixes #3612
@aaronlehmann PTAL

looks good to me


What does Curious API do for this mod ?

Hello good day,
awesome mod really cool!
just wondering why this mod need the curious api...
like do we need it or can this mod run without it?
Reason i ask is cause I use forge but with connector and I use trinkets instead of forge because of specific mod that only uses trinkets.
So I'm wondering what we need curious for, for your mod what does it do and do I need it ect.
sorry I'm a noob at this

Hi Curios is required to lock the trinkets that are added through the curios api like artifacts

I don't need this mod (artifacts ) though, right ?
We can just use your mod correct ?
When using artifacts could we just use the fabric version with Trinkets API ?

Yes, it does work without the Curios API.


accept classNames and styles props to the components exposed by the library

applied to the top level element of each component

we should also allow the user to fully opt-out of any library styles with a prop

I think it will be hard for the user to meaningfully apply styles without the library classes. We can simply advice the user to not import the stylesheets if they don't whish to use the default styles, and then they can easily define their own styles for the available class names on the components.

I will actually not allow this. Better to keep the API to a minimum until we know there is a need.


app闪退

我使用你的代码加载进android studio中，run后apk直接闪退，请问可能是什么原因呢？

你需要看log 看为啥闪退------------------ Original ------------------
From<EMAIL_ADDRESS>Date: Wed, Mar 25, 2020 07:59 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS>Subject: [chentyjpm/MobileNetSSD_Demo_AndroidNCNN] app闪退 (#8)
我使用你的代码加载进android studio中，run后apk直接闪退，请问可能是什么原因呢？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

出现这个错误:Timed out waiting for process to appear on device

多发一些完整的呢？

我也是闪退，Android10测试，出现错误为

两种情况

你需要在 ndk 链接openmp 好像是 -fopenmp

https://github.com/chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN/issues/1
same with the  ""libomp.so" not found " issue
I have the same problem too.
same problem when build https://github.com/chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN
I download the NDK 17 version from https://developer.android.google.cn/ndk/downloads/older_releases
and then set the Android Sutdio project NDK folder to 17 folder, and the problem solved.

我是什么报错都没有就闪退了，只有两行看起来没啥用处地输出：
Connected to the target VM, address: 'localhost:8601', transport: 'socket'
Disconnected from the target VM, address: 'localhost:8601', transport: 'socket'
我是下载完直接build install的，请问在此之前还需要动什么地方吗

chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN#1
same with the ""libomp.so" not found " issue
I have the same problem too.
same problem when build https://github.com/chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN
I download the NDK 17 version from https://developer.android.google.cn/ndk/downloads/older_releases
and then set the Android Sutdio project NDK folder to 17 folder, and the problem solved.

thanks for your answer,it`s useful
感谢你的答案 非常有帮助 #

chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN#1
same with the ""libomp.so" not found " issue
I have the same problem too.
same problem when build https://github.com/chentyjpm/InsightFaceRecognition_Demo_AndroidNCNN
I download the NDK 17 version from https://developer.android.google.cn/ndk/downloads/older_releases
and then set the Android Sutdio project NDK folder to 17 folder, and the problem solved.

thanks for your answer,it`s useful
感谢你的答案 非常有帮助 #


Healthcheck not supported for grpc and grpcs upstreams

Discussed in https://github.com/Kong/kong/discussions/13335
Converting this back to an issue as it really is a bug. Internal ticket: KAG-4871

Originally posted by kanbo July  4, 2024
Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 3.2.2
Current Behavior
error.log
2024/07/04 11:50:05 [error] 28965#0: *598 [lua] handler.lua:665: declarative reconfigure failed after 38 ms on worker #1: /usr/local/share/lua/5.1/resty/healthcheck.lua:1490: checks.active.type can only be 'http', 'https' or 'tcp', got 'grpc', context: ngx.timer

kong declarative_config :
services:
- name: grpc_test
  host: grpc_test
  connect_timeout: 10000
  protocol: grpc
  routes:
  - strip_path: true
    path_handling: v0
    preserve_host: true
    name: grpc_test
    hosts:
    - <IP_ADDRESS>
    methods:
    - GET
    - POST
    paths:
    - /

upstreams:
- name: grpc_test
  algorithm: round-robin
  hash_on: none
  healthchecks:
    active:
      https_verify_certificate: false
      type: grpc
      http_path: /
      timeout: 3
      concurrency: 10
      healthy:
        successes: 3
        interval: 10
      unhealthy:
        tcp_failures: 3
        timeouts: 3
        http_failures: 3
        interval: 10

Expected Behavior
No response
Steps To Reproduce
No response
Anything else?
No response

@kanbo Actually, ChatGPT suggested a workaround to me, do you want to give it a try?
To configure gRPC health checks on an upstream in Kong Gateway 3.2.2, you should use tcp as the health check type, since direct grpc support isn't available for health checks. Here’s how you can adjust your configuration:
services:
- name: grpc_test
  host: grpc_test
  connect_timeout: 10000
  protocol: grpc
  routes:
  - strip_path: true
    path_handling: v0
    preserve_host: true
    name: grpc_test
    hosts:
    - <IP_ADDRESS>
    methods:
    - GET
    - POST
    paths:
    - /

upstreams:
- name: grpc_test
  algorithm: round-robin
  hash_on: none
  healthchecks:
    active:
      https_verify_certificate: false
      type: tcp
      timeout: 3
      concurrency: 10
      healthy:
        successes: 3
        interval: 10
      unhealthy:
        tcp_failures: 3
        timeouts: 3
        http_failures: 3
        interval: 10

This configuration uses tcp for active health checks. While it doesn't check gRPC-specific functionality, it will still ensure that the upstream is reachable and accepting connections, which can be sufficient for many scenarios.

@kanbo Actually, ChatGPT suggested a workaround to me, do you want to give it a try?
To configure gRPC health checks on an upstream in Kong Gateway 3.2.2, you should use tcp as the health check type, since direct grpc support isn't available for health checks. Here’s how you can adjust your configuration:
services:
- name: grpc_test
  host: grpc_test
  connect_timeout: 10000
  protocol: grpc
  routes:
  - strip_path: true
    path_handling: v0
    preserve_host: true
    name: grpc_test
    hosts:
    - <IP_ADDRESS>
    methods:
    - GET
    - POST
    paths:
    - /

upstreams:
- name: grpc_test
  algorithm: round-robin
  hash_on: none
  healthchecks:
    active:
      https_verify_certificate: false
      type: tcp
      timeout: 3
      concurrency: 10
      healthy:
        successes: 3
        interval: 10
      unhealthy:
        tcp_failures: 3
        timeouts: 3
        http_failures: 3
        interval: 10

This configuration uses tcp for active health checks. While it doesn't check gRPC-specific functionality, it will still ensure that the upstream is reachable and accepting connections, which can be sufficient for many scenarios.

I have tried but was unsuccessful. When I shut down the upstream service, Kong thought it was still in a healthy state

I'll take a look at this problem associated to balancer system.

I reproduce it and disable timerng to get a full backtrace of lua error
(kong-dev) xc kong $ cat x.yml
_format_version: '3.0'
_transform: false
services:
- name: grpc_test
  host: grpc_test
  connect_timeout: 10000
  protocol: grpc
  routes:
  - strip_path: true
    path_handling: v0
    preserve_host: true
    name: grpc_test
    hosts:
    - <IP_ADDRESS>
    methods:
    - GET
    - POST
    paths:
    - /

upstreams:
- name: grpc_test
  algorithm: round-robin
  hash_on: none
  healthchecks:
    active:
      https_verify_certificate: false
      type: grpc
      http_path: /
      timeout: 3
      concurrency: 10
      healthy:
        successes: 3
        interval: 10
      unhealthy:
        tcp_failures: 3
        timeouts: 3
        http_failures: 3
        interval: 10

$ kong config db_import x.yml

$ cat error.log

2024/08/01 11:20:02 [error] 93101#0: *648 lua entry thread aborted: runtime error: ...l-bin/build/kong-dev/share/lua/5.1/resty/
healthcheck.lua:1493: checks.active.type can only be 'http', 'https' or 'tcp', got 'grpc'
stack traceback:
coroutine 0:
        [C]: in function 'assert'
        ...l-bin/build/kong-dev/share/lua/5.1/resty/healthcheck.lua:1493: in function 'check_valid_type'
        ...l-bin/build/kong-dev/share/lua/5.1/resty/healthcheck.lua:1575: in function 'new'
        ./kong/runloop/balancer/healthcheckers.lua:274: in function 'create_healthchecker'
        ./kong/runloop/balancer/balancers.lua:161: in function 'create_balancer_exclusive'
        ./kong/runloop/balancer/balancers.lua:201: in function 'create_balancer'
        ./kong/runloop/balancer/init.lua:259: in function 'init'
        ./kong/runloop/handler.lua:927: in function <./kong/runloop/handler.lua:926>, context: ngx.timer


"Search in Files" doesn't search across all files

Issue Type: Bug
Opened a folder and search a term, it only shows partial results. After I opened the file which doesn't show in result, and search the same term again, this file is now shown in search result page.
VS Code version: Code 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1620 v3 @ 3.50GHz (8 x 3492)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.91GB (8.00GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (26)

Extension
Author (truncated)
Version

azuretoolsforvscode
bra
2.0.2

jsonnet
hep
0.1.0

azure-functions-tools
joh
0.3.3

vscode-azureappservice
ms-
0.12.0

vscode-azurefunctions
ms-
0.13.1

vscode-azurestorage
ms-
0.6.0

vscode-azureterraform
ms-
0.2.2

vscode-cosmosdb
ms-
0.10.0

vscode-kubernetes-tools
ms-
0.1.16

mssql
ms-
1.4.0

python
ms-
2019.1.0

vscode-ai
ms-
0.4.2

azure-account
ms-
0.8.0

azurecli
ms-
0.4.2

PowerShell
ms-
1.11.0

vscode-azureextensionpack
ms-
0.0.9

team
ms-
1.144.1

azurerm-vscode-tools
msa
0.4.2

azure-hdinsight
msh
1.1.1

vscode-docker
Pet
0.5.2

vscode-yaml
red
0.2.1

usql-vscode-ext
usq
0.2.14

application-insights
Vis
0.4.2

azure-iot-edge
vsc
1.9.0

azure-iot-toolkit
vsc
2.2.0

t4-support
zbe
0.4.2

Just happened to me.

Please see this page on troubleshooting search issues, and let me know if you still have issues: https://github.com/Microsoft/vscode/wiki/Search-Issues

Thanks Rob. It is due to the expected file is part of gitignore. I feel it is better to disable using gitignore as default setting. Users will only think the button in the lower right corner is related to Exclude settings since it is next to "Exclude" textbox. This UI design is not user friendly. As long as "using ignore" is more visible, user will know give it a try.

I know it confuses some people but I've found that more expect it to be the default than not.


Reuse TCP transport to prevent connection leak

Signed-off-by: H.Muraoka<EMAIL_ADDRESS>Description
The conntrack table on which a grafana opeartor v3.2.0 is running is filled with too many(~35k) entries as shown below.

I think this is caused by the dashboard operator, which creates an http client but leaves it unclosed every time it runs a reconciliation loop.
The golang official document indicates that:

The Client's Transport typically has internal state (cached TCP connections), so Clients should be reused instead of created as needed. Clients are safe for concurrent use by multiple goroutines.

This PR fixes the connection leak by reusing the TCP connection and fixes the client timeout assignment logic, which is probably a bug, as well.
Relevant issues/tickets

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] This change requires a documentation update
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added a test case that will be used to verify my changes
[ ] Verified independently on a cluster by reviewer

Verification steps

Go to the node on which a grafana-operator is running, and execute the following:
$ sudo conntrack -L | wc -l

HI @tapih , Are you still experiencing this issue even with the fix #298 ? @pb82 I don't think these would be conflicting though, we could benefit from having both logic for closing idle connections and reusing existing ones?

I am experiencing the same issue with #289 because I am using v3.6.0 in which the fix is not applied.
#289 fixes this problem, but there is the overhead of TCP handshakes because a reconciler closes a connection every time a reconciliation loop is done and opens it again in the next loop.
Reusing a connection ensures that more than one connection cannot exist at the same time with no overhead, so it's better to take this approach, IMO.

/lgtm


Missing py.typed file in package

Hi,
I've encountered an issue with the pydantic-avro package when using mypy for static type checking. The package is missing a py.typed file, which causes mypy to raise the following error:
error: Skipping analyzing "pydantic_avro.base": module is installed, but missing library stubs or py.typed marker  [import-untyped]
note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

To reproduce:

Install the pydantic-avro package.
Run mypy on a file that imports pydantic_avro.base.

Suggested solution:
Please include a py.typed file in the package to indicate that it supports type checking.
Reference:
https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Thank you!

Added in 0.7.1. Thanks for raising the issue!


Use Monolog directly instead of IExceptionLogger

IExceptionLogger and ExceptionLogger just provide a few conveniences for mapping exceptions to log levels and sets the min error log levels.  This could probably just be done via either a built-in handler in Monlog, or via a custom one.  Regardless, it's probably simpler to do away with Aphiria's logger altogether.

After a bit more research, the issue with not just using LoggerInterface directly is that it's not obvious what log level method to call from the ExceptionHandler middleware - you need some sort of mapper class to figure that out.  So, I either have to pass that mapper class around everywhere (break in encapsulation), or I have to abstract away the way I'm currently doing in ExceptionLogger.  So, it's probably easiest to continue with the current path unless we can think of a better way to introduce log level mapping logic without breaking encapsulation.


Attach (recommended) or Link to PDF file
任何pdf文件
Web browser and its version
chrome
Operating system and its version
win10
PDF.js version
2.6.347
Is the bug present in the latest PDF.js version?
Yes
Is a browser extension
No
Steps to reproduce the problem
在使用TextLayerBuilder的render时候，显示的是eventbus事件总线没有这两个方法导致页面报错，试了很多个版本
What is the expected behavior?
引入
import {
TextLayerBuilder,
} from 'pdfjs-dist/web/pdf_viewer';
import * as pdfjsLib from 'pdfjs-dist/build/pdf'; //pdfjs
pdfjsLib.GlobalWorkerOptions.workerSrc = /js/pdf.worker.js;
执行方法：
}
this.pdfurl = data.data.ulr;
this.fileName = data.data.filename;
document.title = data.data.filename;
console.log(data.data);
const loadingTask = getDocument(data.data.ulr);
const pdf = await loadingTask.promise;
const viewer = this.$refs.pdfViewer;
viewer.innerHTML = ''; // 清空现有内容
		// 渲染所有页面
		for (let i = 1; i <= pdf.numPages; i++) {
			const page = await pdf.getPage(i);
			const viewport = page.getViewport({ scale: 1 });

			const canvas = document.createElement('canvas');
			const context = canvas.getContext('2d');
			canvas.height = viewport.height;
			this.allHeight = viewport.height * pdf.numPages;
			canvas.width = viewport.width;

			// // 渲染 PDF 页面到 Canvas
			await page.render({
				canvasContext: context,
				viewport: viewport,
			});

			// 创建文本层
			const textLayerDiv = document.createElement('div');
			textLayerDiv.className = 'textLayer';
			viewer.appendChild(textLayerDiv);
			viewer.appendChild(canvas);
			//提取文本并创建文本层
			const textContent = await page.getTextContent();
			const textLayer = new TextLayerBuilder({
				textLayerDiv: textLayerDiv,
				pageIndex: i - 1,
				viewport: viewport,
			});
			textLayer.setTextContent(textContent);
			textLayer.render();
		}

What went wrong?

Link to a viewer
No response
Additional context
No response

Please use English in this bug tracker, otherwise no help can/will be provided.

PDF.js version
2.6.347

That version is no longer supported, since it's over four years old, please find the latest releases at https://mozilla.github.io/pdf.js/getting_started/#download
Please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


Is it safe to store passwords with String?

https://github.com/spring-cloud/spring-cloud-config/blob/72ec91814ee1b1dbd6d914899205144122cedbca/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/encryption/EncryptionController.java#L133
Is it safe to store passwords with String? There seems to be no way to proactively clean up strings of passwords stored in memory.

TextEncryptor.decrypt() returns a string. Not sure there's anything I can do there.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Get circleci running in bcgov environment in prep for transfer to HL

Reassigning to @WadeBarnes in hopes he can fit this in this week.
If you can't, please at least comment out the CircleCI badges on the readme so that those don't show up, and reassign to me.
Thanks!

Wired up CircleCI and CodeCov with some help from @nrempel.  CircleCI as been configured to build PRs from forks.  Badges and links are working.
The master branch has been protected.  Merges require a review, build to succeed, and DCO sign-off.
Just need a new logo.

circleci is up and running now 👍🏼


Color Widget's HSV mode doesn't update the hue properly when saturation is 0.

Godot version
4.0.2
System information
Ubuntu 22.04.1 LTS
Issue description

Notice how the hue is on the blue color, but the saturation is insists on remaining red.
If I change the saturation a little bit, the correct value will apply. But if I adjust the value or the alpha, the blue hue will be punched out and become red again.
Steps to reproduce
Go to a ColorPicker in the editor (say, the modulate property of Node2D), open the color picker, and copy the above configuration in the HSV tab.
Minimal reproduction project
N/A

Slider colors are taken directly from the picker's color, not from other sliders. Hue is undefined if saturation is 0.

However, the hue seems to reset back to red when saturation is put to 0... I personally wouldn't want the hue value to change.

I wanna see if I could tackle this one cuz it looks kinda funky.

Upon further investigation, a way to reproduce this issue better is to:

Click a random location on the slider (say saturation) that is not on the endpoints of the slider. Let go of the mouse.
Click and drag the slider to 0.
The bug will appear like so.

It seems there might be some weirder business going on too. When dragging from a non endpoint value to an endpoint, the _set_pick_color  function is called twice.
Below: I placed print statements in _value_changed and _set_pick_color

Here is what happens when I set the saturation slider to 1:

Here is what happens when I set saturation to 0:

As one can see... _set_pick_color is called twice...

I can also reproduce the "calling _set_pick_color twice" behavior sometimes by double clicking the slider...


Fix the release task

Motivation:
release task did not handle an SSH remote URL whose path starts with a
colon (:) correctly, e.g. github.com:line/armeria.git
Modifications:

Match host and path correctly for both forms:

scheme://host/path
user@host:path

Result:

We can release.

Thanks, reviewers!


[Suggestion] Add password validation(digit, characters and length check)

Hello,
I am interested in your repo and suggest one feature to check password length and type.
To make a password more secure, It need to apply validation even simple logic.
I looked at your code and auth.js code has several validations.
I will put this default validation and pull request soon.
// Middleware to check for Password length and type
const checkPassword = (req, res, next) => {
    // regex to validate password
    const regex = /[A-Za-z0-9]/;
    const pwd = req.body.userPassword;
    const defaultLength = 7;

    if(regex.test(pwd) && regex.test(pwd) && pwd.length > defaultLength){
        next();
    }
    else{
        res.status(400).json({ message: 'Invalid Password : Please uses Digit,Characters' });
    }

};

Thanks

Merged

Merged


rix: install rocksdb from repo

Slack raised issue and failed barebone build: https://app.circleci.com/jobs/github/omisego/elixir-omg/20131
Overview
Install rocksdb via git
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

separate step in bin/setup

Testing
barebuild

I recomend to suspend this - after running bin/setup I found my integration test fails localy...
Not sure if this is because setup I will investigate and update here

Coverage remained the same at ?% when pulling aa463c75a54611da9317780cc047239b19419b2a on fix_rocksdb_install into aabead0347053f174c46b7e4c423e730e243e3fe on master.

@pnowosie so the unit tests and integration tests now pass on debian 9. I don't think there's anything wrong with the installation script now

@pnowosie so the unit tests and integration tests now pass on debian 9. I don't think there's anything wrong with the installation script now

Script is meant to be run on fresh envs it's not meant to be run on dev box we a lot of package are already installed, probably in diff versions.

Indeed @pnowosie. But that is something I'm unable to test.


Incompatible type conversion requested to type 'int64' for variable of type 'int32_ref'

A data type conversion error occurred when I ran the sample program with the command python examples/openai_gym.py CartPole-v0 -a examples/configs/dqn.json -n examples/configs/mlp2_network.json -e 2000 -m 200:
/home/davidhopper/code/gym/gym/__init__.py:22: UserWarning: DEPRECATION WARNING: to improve load times, gym no longer automatically loads gym.spaces. Please run "import gym.spaces" to load gym.spaces on your own. This warning will turn into an error in a future version of gym.
  warnings.warn('DEPRECATION WARNING: to improve load times, gym no longer automatically loads gym.spaces. Please run "import gym.spaces" to load gym.spaces on your own. This warning will turn into an error in a future version of gym.')
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
Backend TkAgg is interactive backend. Turning interactive mode on.
Traceback (most recent call last):
  File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/__main__.py", line 211, in <module>
    singlesession=args.single_session)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/__main__.py", line 205, in main
    debug_main(addr, name, kind, *extra, **kwargs)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_local.py", line 30, in debug_main
    run_file(address, name, *extra, **kwargs)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_local.py", line 64, in run_file
    run(argv, addr, **kwargs)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_local.py", line 125, in _run
    _pydevd.main()
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_vendored/pydevd/pydevd.py", line 1699, in main
    debugger.connect(host, port)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_vendored/pydevd/pydevd.py", line 1061, in run
    return self._exec(is_module, entry_point_fn, module_name, file, globals, locals)
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_vendored/pydevd/pydevd.py", line 1068, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/home/davidhopper/.vscode/extensions/ms-python.python-2018.7.1/pythonFiles/experimental/ptvsd/ptvsd/_vendored/pydevd/_pydev_imps/_pydev_execfile.py", line 25, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/davidhopper/code/tensorforce/examples/openai_gym.py", line 172, in <module>
    main()
  File "/home/davidhopper/code/tensorforce/examples/openai_gym.py", line 104, in main
    network=network,
  File "/home/davidhopper/code/tensorforce/tensorforce/agents/agent.py", line 283, in from_spec
    kwargs=kwargs
  File "/home/davidhopper/code/tensorforce/tensorforce/util.py", line 192, in get_object
    return obj(*args, **kwargs)
  File "/home/davidhopper/code/tensorforce/tensorforce/agents/dqn_agent.py", line 131, in __init__
    entropy_regularization=entropy_regularization
  File "/home/davidhopper/code/tensorforce/tensorforce/agents/learning_agent.py", line 141, in __init__
    batching_capacity=batching_capacity
  File "/home/davidhopper/code/tensorforce/tensorforce/agents/agent.py", line 80, in __init__
    self.model = self.initialize_model()
  File "/home/davidhopper/code/tensorforce/tensorforce/agents/dqn_agent.py", line 158, in initialize_model
    huber_loss=self.huber_loss
  File "/home/davidhopper/code/tensorforce/tensorforce/models/q_model.py", line 98, in __init__
    requires_deterministic=True
  File "/home/davidhopper/code/tensorforce/tensorforce/models/distribution_model.py", line 90, in __init__
    discount=discount
  File "/home/davidhopper/code/tensorforce/tensorforce/models/memory_model.py", line 114, in __init__
    reward_preprocessing=reward_preprocessing
  File "/home/davidhopper/code/tensorforce/tensorforce/models/model.py", line 217, in __init__
    self.setup()
  File "/home/davidhopper/code/tensorforce/tensorforce/models/model.py", line 290, in setup
    independent=independent
  File "/home/davidhopper/code/tensorforce/tensorforce/models/memory_model.py", line 605, in create_operations
    independent=independent
  File "/home/davidhopper/code/tensorforce/tensorforce/models/model.py", line 1195, in create_operations
    self.create_observe_operations(reward=reward, terminal=terminal)
  File "/home/davidhopper/code/tensorforce/tensorforce/models/model.py", line 1129, in create_observe_operations
    reward=reward
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 427, in __call__
    return self._call_func(args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 370, in _call_func
    result = self._func(*args, **kwargs)
  File "/home/davidhopper/code/tensorforce/tensorforce/models/memory_model.py", line 566, in tf_observe_timestep
    return tf.cond(pred=optimize, true_fn=true_fn, false_fn=tf.no_op)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/util/deprecation.py", line 432, in new_func
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/control_flow_ops.py", line 2040, in cond
    orig_res_t, res_t = context_t.BuildCondBranch(true_fn)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/control_flow_ops.py", line 1890, in BuildCondBranch
    original_result = fn()
  File "/home/davidhopper/code/tensorforce/tensorforce/models/memory_model.py", line 562, in true_fn
    optimize = self.fn_optimization(**batch)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 427, in __call__
    return self._call_func(args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 370, in _call_func
    result = self._func(*args, **kwargs)
  File "/home/davidhopper/code/tensorforce/tensorforce/models/q_model.py", line 256, in tf_optimization
    target_optimization = self.target_optimizer.minimize(**arguments)
  File "/home/davidhopper/code/tensorforce/tensorforce/core/optimizers/optimizer.py", line 139, in minimize
    deltas = self.step(time=time, variables=variables, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 427, in __call__
    return self._call_func(args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 370, in _call_func
    result = self._func(*args, **kwargs)
  File "/home/davidhopper/code/tensorforce/tensorforce/core/optimizers/synchronization.py", line 92, in tf_step
    do_sync = (time - last_sync >= self.sync_frequency)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/variables.py", line 826, in _run_op
    return getattr(ops.Tensor, operator)(a._AsTensor(), *args)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/math_ops.py", line 850, in binary_op_wrapper
    y = ops.convert_to_tensor(y, dtype=x.dtype.base_dtype, name="y")
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1011, in convert_to_tensor
    as_ref=False)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1107, in internal_convert_to_tensor
    ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/variables.py", line 798, in _TensorConversionFunction
    "of type '%s'" % (dtype.name, v.dtype.name))
ValueError: Incompatible type conversion requested to type 'int64' for variable of type 'int32_ref'

originally defined at:
  File "/home/davidhopper/code/tensorforce/tensorforce/models/model.py", line 245, in setup
    self.setup_components_and_tf_funcs()
  File "/home/davidhopper/code/tensorforce/tensorforce/models/q_model.py", line 128, in setup_components_and_tf_funcs
    self.target_optimizer = Optimizer.from_spec(spec=self.target_optimizer_spec)
  File "/home/davidhopper/code/tensorforce/tensorforce/core/optimizers/optimizer.py", line 160, in from_spec
    kwargs=kwargs
  File "/home/davidhopper/code/tensorforce/tensorforce/util.py", line 192, in get_object
    return obj(*args, **kwargs)
  File "/home/davidhopper/code/tensorforce/tensorforce/core/optimizers/synchronization.py", line 48, in __init__
    super(Synchronization, self).__init__(scope=scope, summary_labels=summary_labels)
  File "/home/davidhopper/code/tensorforce/tensorforce/core/optimizers/optimizer.py", line 52, in __init__
    custom_getter=custom_getter
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/template.py", line 153, in make_template
    **kwargs)

Is there a solution? Thanks a lot.

#470
It should work now.

@daggertye
I downloaded the latest code. it's OK now. Thank you.


[Feature] 请问可否考虑增加一个通过LangChain调用的Demo

Is your feature request related to a problem? Please describe.
No response
Solutions
为便于开展基于本地数据/文件索引的chatglm应用，可否考虑增加一个通过LangChain调用ChatGLM模型的Demo
Additional context
No response

我根据这个 尝试了一下，
报错
Traceback (most recent call last):   File "/data/wuhaixu/mygpt/ChatGLM-6B/tests/test_langchain.py", line 7, in <module>     llm_chain = LLMChain(prompt=prompt, llm=HuggingFaceHub(repo_id="THUDM/chatglm-6b", model_kwargs={"temperature":0, "max_length":64}))   File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__ pydantic.error_wrappers.ValidationError: 1 validation error for HuggingFaceHub __root__   Task not specified in the repository. Please add it to the model card using pipeline_tag (https://huggingface.co/docs#how-is-a-models-type-of-inference-api-and-widget-determined) (type=value_error)
问了一下chatgpt, 他说
`It sounds like you may be encountering an issue with a machine learning model repository where a task is not specified for a particular model. To solve this problem, you can add a pipeline_tag to the model card that specifies the task or use case for which the model was designed.
A pipeline_tag is a metadata field that provides information about the intended use case for a particular model. For example, if the model was trained for sentiment analysis, you could add a pipeline_tag for "sentiment analysis." This will make it easier for users to understand the model's purpose and suitability for their own use cases.
To add a pipeline_tag, you will need to access the model card for the repository and look for the metadata fields. Depending on the repository platform, this could be called something like "tags" or "metadata." Add the appropriate pipeline_tag to indicate the task for which the model was designed.
If you do not have permission to edit the model card or if the repository does not support pipeline_tags, you can contact the repository owner or submit an issue to request that the task be added to the model card.`
所以，可能要请repository owner，把task加到model card上。

@NLPpupil 目前已经通过创建CustomLLM类成功实现了，后面准备发个repo

@NLPpupil 目前已经通过创建CustomLLM类成功实现了，后面准备发个repo

帅呀，求教怎么弄的？在线等，挺急的。

@NLPpupil 可以参考一下 https://langchain.readthedocs.io/en/latest/modules/llms/examples/custom_llm.html 和 https://gist.github.com/DamascusGit/40bf1e9fd63974a95d071e3508e3f7c3

谢谢大佬，我好像会了

https://langchain.readthedocs.io/en/latest/modules/llms/examples/custom_llm.html

等一手大佬的repo

@zhongtao93 已经改用langchain直接实现啦，晚上回去我上传一下，也实现了利用fastapi搞了个api版本的，晚上我先上传直接实现的版本。

@zhongtao93 来咯 https://github.com/imClumsyPanda/langchain-ChatGLM

大佬牛掰在 2023年3月31日，20:24，imClumsyPanda @.***> 写道：
@zhongtao93 来咯 https://github.com/imClumsyPanda/langchain-ChatGLM
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Reef detail page

Also, in the future, when you submit a PR, can you please add a little summary of what is implemented in the PR? If you add pages, include screenshots of the pages.


Updates MFTF configuration with notes about some common issues

Updates mftf.md with several notes regarding getting it running in a default magento2 environment type.

Hopefully my formatting here is acceptable - I wasn't sure where the information should go - if anyone has a better suggestion, just holler at me and I'll adjust.

@davidalger Gotcha - I'll update this PR with the suggested changes this week

Closing in favor of #349


Support for X-GitHub-Event header

The event body only contains the action, but not the event type.
Without extracting from that header, the GitHubEvent extractor is less useful. E.g. when the action is “closed”, what was closed? A pull request? A project?

Typed access to the headers would probably be useful. Here's something that might suffice: https://github.com/tokio-rs/axum/discussions/1437
Would be happy to merge contributions if you do end up writing something to help.

Octocrab has this, should be easy to make an extractor: https://docs.rs/octocrab/latest/octocrab/#github-webhook-application-support


HI-WA164DBI support

Hi, I have an appartment complex with Haier MVR and I would like to control it with hass.io but it doesn't have wifi. I see wifi module for MVR HI-WA164DBI that should enable WIFI access via some app called Haier-AC. Will it support hon? or am i SOL?
Thanks

Hi, I have looked at the module and I doubt that this is compatible with hOn and so this integration will not work. Haier has many different interfaces that are not compatible with each other...


redhat iptables not saving?

This might not be an issue, but my customer told me that on reboot of the system we stood up for them via chef, their ip tables rules are not persistent.
excuse my ignorance, but can someone explain to me what this is doing and why redhat/centos are not in the list of platforms?
case node[:platform]
when "ubuntu", "debian"
  iptables_save_file = "/etc/iptables/general"

  template "/etc/network/if-pre-up.d/iptables_load" do
    source "iptables_load.erb"
    mode 0755
    variables :iptables_save_file => iptables_save_file
  end
end

BTW: I read through the cookbook and see that the rebuild-iptables.erb is supposed to write the ip table rules to "/etc/sysconfig/iptables", I was more so curious as to why the above is needed.
template "/usr/sbin/rebuild-iptables" do
  source "rebuild-iptables.erb"
  mode 0755
  variables(
    :hashbang => ::File.exist?('/usr/bin/ruby') ? '/usr/bin/ruby' : '/opt/chef/embedded/bin/ruby'
  )
end

Yes, it confuses me as well.

I also had this problem with Amazon Linux (aka Enterprise Linux), where rules where not showing in "iptables -L" after a reboot.
This turned out to be because the "iptables" service was not being enabled with chkconfig. Simply enabling the service with chkconfig resulted in the rules being present after a reboot.
$ chkconfig iptables on
$ chkconfig --list iptables
iptables        0:off 1:off 2:on  3:on  4:on  5:on  6:off
$ sudo reboot

However, above is too manual, presume the cookbook should enable the service like below?
service 'iptables'
  action [:enable, :start]
end

We're now enabling the services on RHEL based systems.  This shouldn't be an issue anymore.


Set ConditionalPathExists in correct area so docker-gc-enabled works.

High Level Description
When enable_docker_gc is set to false, the file docker_gc_enabled does not exist, which is supposed to stop the unit file from starting. The ConditionPathExists was in the wrong place, however, and needs to be in the Unit section instead of Service.
Tested manually on my cluster. How does 3dt mark Condition failed systemd units as in the UI? On my cluster, docker-gc still shows as healthy even though it can't be executing. Could be very confusing if people are expecting docker-gc to be disabled, but still see it show up in the DC/OS UI.
Related Issues
https://jira.mesosphere.com/browse/DCOS_OSS-999
Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

I've just been burned by this in an environment with a very slow upstream internet connection. :-(

@mesosphere-mergebot Ready For Review

@mesosphere-mergebot label Ready For Review

@branden  - PTAL.

@mesosphere-mergebot label ship it

@mesosphere-mergebot bump-ee


Add NestJS Guard, Decorator icons

Changes made:

Decorator icon - nest-decorator.svg
Middleware icon - nest-middleware.svg

to use:
  "symbols.files.associations": {
    "*.decorator.ts": "nest-decorator",
    "*.middleware.ts": "nest-middleware"
  }

It would be nice If you could add the other nestjs-files variants

@FabianMontoya Will do, i was planning to do it already.

@FabianMontoya Will do, i was planning to do it already.

Thank u for the work!


build stuff

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@10f1b76). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main      #5   +/-   ##
======================================
  Coverage        ?   2.58%
======================================
  Files           ?       2
  Lines           ?     155
  Branches        ?       0
======================================
  Hits            ?       4
  Misses          ?     151
  Partials        ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


support deep nested class

Then this can generate nested class's description for swagger json.

@domaindrivendev hi, would you consider to support this for these who using deep (more then two) nested class?

Looks like the same underlying issue was ultimately fixed by #1690.

Looks like the same underlying issue was ultimately fixed by #1690.


Get commands registered by package

Summary
The Atom API has several methods and properties to retrieve package commands, but there is no reliable way to get all commands registered by a package.
Motivation
The motivation is entirely personal. I'm building things to improve the Atom eco-system, from packages to Node modules tailored for use in Atom. I've repeatedly run into the situation where I would want to retrieve package commands for various purposes, e.g. to subscribe to events emitted by these commands.
Describe alternatives you've considered
Using the current Atom API, it's possible to retrieve activation commands e.g. using atom.packages.getLoadedPackage(packageName). Personally, I cannot think of a situation where a user would not want his commands to be activation commands, but it's possible to have non-activating commands.
It's also possible to retrieve all registered commands using atom.commands.registeredCommands, that's all commands by all installed package. However, a package can register any command name, they are not bound to the name of the package – even if that is suggested*. That means, the list of registered commands cannot reliably be filtered to get commands that belong to a single package.
* Personally, I've "misused" this myself, since I prefer acronyms to be capitalized when appearing in the command palette (e.g. HTML vs Html). But that's a different story.

I can see how this would be useful, but how would Atom know which commands are registered by which packages? Right now commands can be registered anywhere. They don't even have to be registered by a package. They can be registered in the init file or even in the developer tools console.
How would you suggest Atom figures out which commands are part of which packages?

How would you suggest Atom figures out which commands are part of which packages?

To answer that, I will have to take a closer look at atom.commands.add() and the event handler for registered commands.


Errors when building following the guide on the readme on ubuntu 14.4

root@ip-172-37-0-51:~# go get github.com/kahing/goofys
# github.com/Sirupsen/logrus
work/src/github.com/Sirupsen/logrus/logger.go:32: undefined: sync.Pool
# github.com/jacobsa/fuse/internal/buffer
work/src/github.com/jacobsa/fuse/internal/buffer/runtime_other.s:25 6a: No such file or directory: textflag.h
# github.com/aws/aws-sdk-go/private/protocol/rest
work/src/github.com/aws/aws-sdk-go/private/protocol/rest/build.go:71: r.HTTPRequest.URL.RawPath undefined (type *url.URL has no field or method RawPath)
work/src/github.com/aws/aws-sdk-go/private/protocol/rest/build.go:187: u.RawPath undefined (type *url.URL has no field or method RawPath)
work/src/github.com/aws/aws-sdk-go/private/protocol/rest/build.go:188: u.RawPath undefined (type *url.URL has no field or method RawPath)
work/src/github.com/aws/aws-sdk-go/private/protocol/rest/build.go:227: u.RawPath undefined (type *url.URL has no field or method RawPath)
work/src/github.com/aws/aws-sdk-go/private/protocol/rest/build.go:231: u.RawPath undefined (type *url.URL has no field or method RawPath)
# github.com/aws/aws-sdk-go/aws/ec2metadata
work/src/github.com/aws/aws-sdk-go/aws/ec2metadata/service.go:57: unknown http.Client field 'Timeout' in struct literal
work/src/github.com/aws/aws-sdk-go/aws/ec2metadata/service.go:87: c.Timeout undefined (type *http.Client has no field or method Timeout)

I ran into this one yesterday as well, I believe its due to your version of go. The default one in Apt-Get seems to be a little out of date, see https://github.com/golang/go/wiki/Ubuntu. If you install go from source the latest version (1.7.4) worked for me.

Glad to know that everyday there are people compiling goofys :-)
@adam-malowiecki is right, goofys requires at least Go vendoring support which first appeared in 1.5. I would happily take a PR that makes the error more explicit.


Improve/snapshots logging

Update logic for adding snapshot_id to array of snapshots if not already present - append to the end, preserving the test order.
When running with named snapshots, log the snapshot name during runs:

Running tests for [snapshot name]

Looks good to me.


Editors can steal focus later when opening slowly

Repro:

Open a notebook in the right editor
Click the left editor quickly, when the right one is done loading (which could take seconds), it will steal focus

No longer reproduceable in latest Insiders. We have changes for editor focus which fixed this problem I think.

I exprimented by adding a 3 second timeout for setInput and once it finishes, the editor service will always try to focus the editor, even if users have already move focus to another editor/pane. It would be the same for webview editor I think.

Editors are being focused after setInput here:
https://github.com/microsoft/vscode/blob/5bcb560aedb31dac84642fb2a4525fc7e652972c/src/vs/workbench/browser/parts/editor/editorPanes.ts#L243-L249
I wonder how to best fix this, we would almost of have to capture the state of editors before setInput and then after to compare if any other editor meanwhile opened?

Maybe the pragmatic fix here is to simply check document.activeElement before and after setting input to the editor and only setting focus when the active element is still the same. Because I think there are other situations where you do not want the editor to steal focus, e.g. when you open search viewlet and start to type.
We still would not be able to catch the case where you open an editor to the side and continue typing in the active editor of the group you started from because the active element would always be the textarea of that editor. If we wanted to solve for that issue, we would have to start adding more and more machinery to detect user activity...

This bug has been fixed in the latest release of VS Code Insiders!
@Tyriar, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 79c4f9b75db3b4f50468fc022cacf8ba6d640aff of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


ARROW-12170: [Rust][DataFusion] Introduce repartition optimization

This introduces a optimization pass to introduce repartition whenever the number of partitions of the plan drops below the configured amount of concurrency to optimize the amount of achievable concurrency.
This PR separates the optimizations into a PhysicalOptimizer, so this can be extended and built upon later.
The performance benefit is clear when loading data into memory with a single partition, to test the use case whenever we would have single files or in memory data has high enough throughput, but the single partition causes too little parallelism.
This has a similar performance benefit of pre-partitioning the data and loading it in memory in those queries.
cargo run --release --bin tpch --features "snmalloc" -- benchmark --iterations 30 --path [path --format parquet --query 1 --batch-size 8192 --concurrency 16 -m -n 1

Master
Query 1 avg time: 411.57 ms
Query 3 avg time: 147.32 ms
Query 5 avg time: 237.62 ms
Query 6 avg time: 46.00 ms
Query 12 avg time: 124.02 ms

PR
Query 1 avg time: 76.37 ms
Query 3 avg time: 67.51 ms
Query 5 avg time: 134.14 ms
Query 6 avg time: 9.58 ms
Query 12 avg time: 20.60 ms

All in all, looking good, we observe speed ups up to 6x for this test!

I like where this is heading @Dandandan :rocket:

@Dandandan great that someone is working through these optimisations!

@alamb @andygrove
PR is ready enough for review by now. I added some benchmark results to demonstrate the impact of this change on under-partitioned data (or nested queries, but the TPC-H queries are not great examples of that).
Probably don't have a lot of time to spent during easter.

There are two issues still I think originating with RepartitionExec (but I can not find the source of the bug) now that we add RepartitionExec in many situations.

RepartitionExec + EmptyExec causes empty results -> I disabled adding RepartitionExec for EmptyExec nodes
RepartitionExec + custom TopKExec extension causes emtpy results -> don't know what to do about this

Thanks @Dandandan  -- I'll try and take a closer look at this tomorrow. Given we use custom execution nodes (ala TopKExec in IOx I would prefer to figure out what is going on there first).

Thanks @alamb much appreciated 😃

@Dandandan  -- sorry I ran out of time today -- I will try and find time tomorrow. Sorry about that

No worries @alamb

Codecov Report

Merging #9865 (fb2183b) into master (2b87dfc) will increase coverage by 0.02%.
The diff coverage is 89.34%.

@@            Coverage Diff             @@
##           master    #9865      +/-   ##
==========================================
+ Coverage   82.68%   82.70%   +0.02%
==========================================
  Files         256      259       +3
  Lines       60105    60155      +50
==========================================
+ Hits        49698    49753      +55
+ Misses      10407    10402       -5

Impacted Files
Coverage Δ

rust/datafusion/src/physical_plan/mod.rs
88.00% <ø> (ø)

rust/datafusion/src/physical_plan/parquet.rs
87.57% <ø> (+0.29%)
:arrow_up:

rust/datafusion/src/execution/context.rs
91.65% <57.14%> (-0.53%)
:arrow_down:

...st/datafusion/src/physical_optimizer/merge_exec.rs
77.77% <77.77%> (ø)

...afusion/src/physical_optimizer/coalesce_batches.rs
88.23% <88.23%> (ø)

rust/datafusion/src/physical_plan/planner.rs
79.54% <94.44%> (-0.24%)
:arrow_down:

...t/datafusion/src/physical_optimizer/repartition.rs
95.08% <95.08%> (ø)

rust/datafusion/src/datasource/parquet.rs
94.40% <100.00%> (-0.04%)
:arrow_down:

rust/datafusion/src/physical_plan/merge.rs
68.65% <0.00%> (-8.96%)
:arrow_down:

...t/datafusion/src/physical_plan/coalesce_batches.rs
84.07% <0.00%> (-0.89%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b87dfc...fb2183b. Read the comment docs.

I spent some time looking at this.
It seems as if at least one problem is that the TopKExec user defined plan should declare that it takes only a single input partition from its child:
#[async_trait]
impl ExecutionPlan for TopKExec {
...
    fn required_child_distribution(&self) -> Distribution {
        Distribution::SinglePartition
    }
...

However, that is still not enough to get the tests to pass. My debugging of cargo test -p datafusion --test user_defined_plan suggests that the actual TopK stream never runs; I'll keep putzing with it

Thanks @alamb that gives some more pointers to continue with. I am also interested what the even

Somehow this is what the plan looks like - already before optimization(?)
TopKExec

It seems something in the Repartition optimizer, when disabling it it succeeds now.

Somehow this is what the plan looks like - already before optimization(?) it seems it doesn't have children somehow

I think this is due to the Debug implementation not printing out children recursively:
https://github.com/apache/arrow/blob/9262a5d83b6037d0c39668310b1875e32f1b7e83/rust/datafusion/tests/user_defined_plan.rs#L336

Somehow this is what the plan looks like - already before optimization(?) it seems it doesn't have children somehow

I think this is due to the Debug implementation not printing out children recursively:
https://github.com/apache/arrow/blob/9262a5d83b6037d0c39668310b1875e32f1b7e83/rust/datafusion/tests/user_defined_plan.rs#L336

Yeah, I realized that later. Don't know how it is handled in others though, seems formatters implementations only need to include themselves, not their children?

Somehow this is what the plan looks like - already before optimization(?) it seems it doesn't have children somehow

I think this is due to the Debug implementation not printing out children recursively:
https://github.com/apache/arrow/blob/9262a5d83b6037d0c39668310b1875e32f1b7e83/rust/datafusion/tests/user_defined_plan.rs#L336

Yeah, I realized that later. Don't know how it is handled in others though, seems formatters implementations only need to include themselves, not their children?

Ah it is only defined like that on the logical plan...

This is the optimized plan, which looks ok, there is a RepartitionExec wrapping the CsvExec (which is ok) and a MergeExec just before TopKExec:
TopKExec { input: MergeExec { input: ProjectionExec { expr: [(Column { name: "customer_id" }, "customer_id"), (Column { name: "revenue" }, "revenue")], schema: Schema { fields: [Field { name: "customer_id", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, Field { name: "revenue", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }], metadata: {} }, input: CoalesceBatchesExec { input: RepartitionExec { input: CsvExec { path: "tests/customer.csv", filenames: ["tests/customer.csv"], schema: Schema { fields: [Field { name: "customer_id", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, Field { name: "revenue", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }], metadata: {} }, has_header: false, delimiter: Some(44), file_extension: ".csv", projection: Some([0, 1]), projected_schema: Schema { fields: [Field { name: "customer_id", data_type: Utf8, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }, Field { name: "revenue", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: None }], metadata: {} }, batch_size: 8192, limit: None }, partitioning: RoundRobinBatch(16), channels: Mutex { data: {} } }, target_batch_size: 4096 } } }, k: 3 }

Something is happening with polling here and marking the stream as done. When I remove that part, the TopKExec will get results in a later moment. So the fold/aggregate is not getting all batches somehow?


Mantis hangs on large input

Hi,
I'm trying to run Mantis on quite a big experiment ~3000 samples. I've build CQFs with Squeakr-exact, k-mer=28 and total Squeakr output takes ~8 TB. I use cutoff=2 for each sample. It's larger than example in manuscript, but I think it still should work, right? I changed constant MAX_NUM_SAMPLES to account for bigger number of samples.
Currently mantis build process for this input has been running for 10 days and hanged with the following message:

Kmers merged: 10000000 Num eq classes: 1934823 Total time: 233712
Home slot: 2602766 Insertion slot: 30477349 Difference: 27874583 Fraction done: 0.000152

Do you think any other constants or anything else should be changed to account for bigger input size?
Thank you, Pavel

Hi @effect,
Based on the logs it seems the build process didn't even complete the sampling phase (which is until first ~67M k-mers). But given that the process didn't crash (segfaulted) and is just super slow one thing jumps out at me.
The current Mantis code doesn't have a way to estimate the total number of k-mers in the final output (i.e., the total number of slots needed in the final CQF which can store all k-mer hashes and corresponding color-class IDs). If you make the CQF size smaller than the expected output size, the build process (i.e., insertions in the final CQF) will become super slow before crashing eventually.
Currently, the final CQF size is hardcoded to 16B slots (2^34). (https://github.com/splatlab/mantis/blob/master/include/cqf.h#L35).
You can increase that to 35 or 36 and see if the process goes past the sampling phase.
Note: We already have a fix to dynamically estimate the size of the output CQF and resize the CQF. We will release the fix soon.
Thanks,
Prashant

Thanks Prashant, it actually crashed and I got Segmentation Fault for my case. I also got Segmentation Fault for NUM_Q_BITS = 36 and 37. Finally for 38 case I got not enough memory exception. My guess is I need to increase cutoff and filter out more k-mers and correspondingly decrease data structure size.


Jupyter Notebook as interactive app

Deploys Jupyter as an interactive app sourced from https://github.com/stackhpc/OOD-containerised-jupyter, which itself uses modified images built by a workflow in https://github.com/stackhpc/jupyter-docker-stacks/tree/ood-mounted-config
Can be connected to by launching the interactive app and waiting for the 'Connect to Jupyter' button to appear. Note that the button may appear while the Jupyter image is still building, so you might initially get a 'cannot connect to slurmd-X' message in the browser
Currently Jupyter has all auth disabled, still requires OOD auth to access but could be a potential issue for multiple users

@wtripp180901 lets leave the jupyter repo as outside this repo, but let's change it into a fork of the upstream repo please.

Changed the Jupyter repo to https://github.com/stackhpc/bc_containerised_jupyter
Should I delete the old one?


Update show commands to return 3 if resource not found

The Media Services REST API get calls will return null rather than throw an APIException if a resources is not found. Update our show commands to return 3 to conform to CLI standard.
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@Juliehzl please take a look.

@giakas, this should be the last changes before removing the preview tag.

@Juliehzl I've addressed you review feedback.

@Juliehzl, we would like to have this PR merged as soon as possible. Can you please advise us on any remaining issues?
Thanks

Hi @BrianBlum, please resolve all conflicts and answer my last comment left.


[HxSidebar] Toggler is not visible when using ResponsiveBreakpoint.None

When I use HxSidebar with ResponsiveBreakpoint set to SidebarResponsiveBreakpoint.None the sidebar toggler disappears.

Moved the d-none to CSS isolation so it can be overloaded by the responsive utility class.