Issue 26 by budden

This one is for issue #26 (implement COUNT). So far not all test suites are updated, otherwise it seem to work. Please review when you have time, meanwhile I'll update missing tests in a day or two.

That's a great contribution @budden , another one to check. Thanks a lot.

Now I seem to have touched all test suites.

Hey @budden I'm testing your change and the way how we present the information is really good but there is a problem that I mentioned in #26.
For now, gitql has a default limit result and if I type select count(*) from commits it shows the default limit (10 rows).
My worried here ist that I didn't find a solution beyond a full table scan respecting the way how gitql works (accessing directly git objects).
How do you see that issue?

Hi @cloudson , I've read the discussion in the issue and decided to start with simples yet useful thing.
Haha, kubernetes has 74+k commits :) SO says there is command line to get count "faster", like git rev-list --all --count, see https://stackoverflow.com/questions/677436/how-do-i-get-the-git-commit-count .
If we go this way there are more questions to explore then. For instance, what to do with select count(*) from commits where .... Counting all commits is just one of use cases, not necessary the most important one. Sorry I have no good PC at hand to check all those things, will do that tomorrow my timezone.
What goes to limit, I don't think it is a bad thing, because count(*) ... limit N would show the right number if N is good enough. This behavior can be changed so that count ignores limit, but current one is regular. That's up to you, I can change it. OTOH I would change default limit to something more useful, like 1000.

My wrong. In Postgresql and MySQL, limit must not affect the count, because limit applies to the result set, which is always of length 1. The only possible exception is limit 0. So I'll change this one tomorrow.

No rush man, we can discuss more before you implement it.

It takes 3-4 seconds on my hardware to obtain 'count(*) from commits limit 100000' for kubernetes.  Do we really need some optimization here?

 'select count(*) from commits limit 100500 now runs 4 seconds against git rev-list --count HEAD, which runs for 0,8 seconds. More interesting, if we run git rev-list --all --count, then results are different, where --all --count returns more commits. I don't know what does it mean, but in worst case it means that commits virtual table does not cover all actual commits.

wow 😍 , for me it's quite good. Can you check it with some more complex where query using date interval and email as criteria?

Ok, will do after making limit to not affect count.

Fixed count vs limit. The results of measuring follow. I'm running debian stretch amd64 on a virtual box, which runs on a ASUS ROG G771JW laptop with an SSD drive.
/y/kubernetes$ time git rev-list --count HEAD
74763
real	0m2,981s

$ time git ql --type json "select count(*) from commits"
[{"count":"74763"}]
real	0m5,551s

$ time git ql --type json "select count(*) from commits where author_email like '%.com' order by date asc limit 3"
[{"count":"71952"}]
real	0m6,463s

$ time git ql "select count(*) from commits where author_email like '%.com' and date >= '2017-01-01' and date <= '2017-12-31'"
+-------+
| count |
+-------+
| 17617 |
+-------+
real	0m7,880s

I tested locally and it seems amazing. I just found a little problem that I would like to discuss to you.
git ql --type json "select count(*) from commits where author_email like '%.com' order by date asc limit 3"

Should return 3 instead of 71952. I mean, when we set a limit, count should not be greater than it, isn't?
What do you think about it?

Hi! I'm hesitating it should. As I mentioned before, postgresql and mysql apply limit after count, so "limit" sees exactly one record.
For instance,
https://dba.stackexchange.com/questions/117284/count-gives-more-than-1-with-limit-1
https://stackoverflow.com/questions/17020842/mysql-count-with-limit
So if we're following "the principle of least surprise", gitql should do the same.

You are totally right @budden . I'm merging it and appreciate all your work. Thanks a lot.


OAuth client credential not supported

Description
I am following along this docs page: https://docs.shopware.com/en/shopware-platform-dev-en/api/admin-authentication?category=shopware-platform-dev-en/api
I execute:
curl https://foobar.test/api/oauth/token -X POST -H 'Content-Type: application:json' --data '{"client_id":"SWABCDEFGHIJKLMNOPQRSTUVWX","client_secret":"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX","grant_type":"client_credentials"}' | jq
My installation is answering:
{
  "errors": [
    {
      "code": "2",
      "status": "400",
      "title": "The authorization grant type is not supported by the authorization server.",
      "detail": "Check that all required parameters have been provided"
    }
  ]
}

Possible Solution
Remove documentation about it as it says it is not supported.

Nvm wrong content-type


Typehead with button at the end

can we implement some thing like above image.

I implemented something like this by adding a link in the footer to create a new one. In my case, selecting this option closes the typeahead and shows more fields (I'm doing it for addresses).
Does that help?

kind of. do mean like this.
$('.typeahead').typeahead({
footer: "Hello"
});

I think the api changed since I had my implementation (and I angularized it). But I did something like:
var dataset = {
    displayKey: "displayKey",
    source: function() {...},
    templates: {
        footer: 'Click here to add a new one.'
    }
};
element.typeahead({}, dataset);

Something like that.


Add init hook flag to shellenv command

Summary
Add init hook flag to shellenv command. This prints out the env variables and the init hooks to stdout, and should replicate the behavior of a devbox shell within the context of the current shell.
How was it tested?
devbox shellenv --init-hook

And changing the shell by
eval "$(devbox shellenv --init-hook)"

Couple questions/suggestions:

Should devbox shell --print-env then print the init hook as well? or, remove that call altogether
We could instead print . .devbox/gen/scripts/.hooks.sh instead of copying the entire hook here

Couple questions/suggestions:

Should devbox shell --print-env then print the init hook as well? or, remove that call altogether

I think it should? I'm not sure. I know it is being used in direnv

We could instead print . .devbox/gen/scripts/.hooks.sh instead of copying the entire hook here

Will there be a race condition of .devbox/gen/scripts/.hooks.sh not being generated in time?


apt: 2.9.3 -> 2.9.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/apt/versions.
meta.description for apt is: Command-line package management tools used on Debian-based systems
meta.homepage for apt is: https://salsa.debian.org/apt-team/apt
meta.changelog for apt is: https://salsa.debian.org/apt-team/apt/-/raw/2.9.4/debian/changelog
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.4 with grep in /nix/store/mwink114cx2r6hhjqjbjw6dsb6bm80zz-apt-2.9.4
found 2.9.4 in filename of file in /nix/store/mwink114cx2r6hhjqjbjw6dsb6bm80zz-apt-2.9.4

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath

apt
python311Packages.python-apt
python312Packages.python-apt
snapcraft

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mwink114cx2r6hhjqjbjw6dsb6bm80zz-apt-2.9.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A apt https://github.com/r-ryantm/nixpkgs/archive/c25484219c81b4cd76a9ca336f4a77bfa857f32c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c25484219c81b4cd76a9ca336f4a77bfa857f32c#apt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mwink114cx2r6hhjqjbjw6dsb6bm80zz-apt-2.9.4
ls -la /nix/store/mwink114cx2r6hhjqjbjw6dsb6bm80zz-apt-2.9.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

10 packages built:

apt
apt.dev
apt.doc
apt.man
python311Packages.python-apt
python311Packages.python-apt.dist
python312Packages.python-apt
python312Packages.python-apt.dist
snapcraft
snapcraft.dist

Maintainer pings
cc @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge


github actions: fix installation after move to ubuntu 24.04

The default github action image moved from ubuntu 22.04 to 24.04, and its list of installed packages is not the same. Make sure we have libcairo-dev for pycairo, a dependency of matplotlib used by hwgraph.

This should help with the build issues seen in #68 .


Investigate why historical precipitation values differ substantially between main branch and iem_taspr_2km branch

For example, if you look at the historical precipitation values from the main branch:
http://earthmaps.io/iem/point/64.80/-147.70
You'll see this:
"1910-2009": {
  "DJF": {
    "CRU-TS31": {
      "CRU_historical": {
        "pr": 47,
        ...
      }
    }
  },
  ...
}

Compare this with the historical precipitation data from the iem_taspr_2km branch for the same lat/lon point (using the new taspr endpoint):
http://localhost:5000/taspr/point/64.80/-147.70
{
  "1950_2009": {
    "DJF": {
      "CRU-TS40": {
        "CRU_historical": {
          "pr": {
            "hi_std": 28,
            "lo_std": 5,
            "max": 63,
            "mean": 16,
            "min": 0
          }
        }
      }
    },
    ...
  },
  ...
}

The mean precipitation value from the main branch is 47mm. The mean precipitation value from the iem_taspr_2km branch is 16mm. Is this because of the different time range (1910-2009 vs. 1950-2009) or difference in the underlying dataset (CRU TS 3.1 vs CRU TS 4.0)? Or is there a bug in the calculation?

Awesome catch Craig! This was a failure on my part to sum the months of a season before averaging for the precip. Nothing wrong with the API here, but processing code in iem-taspr-2km branch of rasdaman-ingest repo has been fixed and the live coverage in the production Rasdaman server has been updated.


feat(ui): ability to collapse all unused freight

Fixes #2386

Seeing some issues with this:

When I collapse unused, the box that represents the unused Freight says "Old Freight," which is somewhat misleading, since hiding old Freight is a separate feature.

When I hide Old Freight, it's not hiding all the old Freight, but just one. The count that it shows in the box that represents the old Freight is off -- reflecting the number that is should have hidden.

N.B.: Don't be fooled by version numbers in this video. I manually created Freight containing references to older images. The chronological order in the Freight timeline is correct.
https://github.com/user-attachments/assets/3663d104-894c-4c4a-a503-a42cd1d135c0

@krancour Thanks for finding the bug with the old freight collapsing improperly. Just pushed a fix.
WRT the "old freight" label, I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen. My thinking is that no matter whether all unused freight are hidden or not, that last set is always "old". I can certainly see how this could be confusing though, so I'm happy to change it. WDYT?
Here's an example of all freight collapsed with the old freight label for the last group:

I chose to label the oldest set of collapsed freight as "old" no matter which collapse mode is chosen

That makes sense!


Identify and remove assets that are not being used in the app

Identify all assets that are not being used in Hexa
Archive the assets that are not being used
Remove the unused assets from App

@AliMeer  do we have a list of assets that were removed?

In case no issues related to icons/images are found in regression then close this issue


Check return value for GetModuleFileName in ConfigParser::ParseConfig

If GetModuleFileName failed and we ignore the return value, then _wsplitpath_s will read uninitialized stack buffer modulename.

@xiaoyinl,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@xiaoyinl,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dilijev Could you review this patch? Thanks!

@LouisLaf @boingoing

Hi @boingoing, any update on the review? Thanks!

@xiaoyinl: @boingoing is on vacation, but I've added @suwc who is currently doing work in the area of modules. Maybe he can give a review.

@xiaoyinl: thanks! If you have a small test case, could you add it to the regression tests? Also, I saw there are a few other places where GetModuleFileName is called and [out] modulename is used without checking return value. Let us know if you would be so kind to help fix them too :-) (It will be totally fine if you shall decide to leave them to us)

Thank you @dilijev and @suwc! I'd like to fix all other places and add test cases. I will do them today or tomorrow.

@xiaoyinl Any update here?

@dilijev I am very sorry for the delay! I will do it tomorrow for sure this time.

@xiaoyinl No worries -- just wanted to check in. Take your time. :)

Sorry I messed up the changes. I rebased it before pushing. I will close this and open a new one PR. Sorry for the long delay again!

@xiaoyinl, maybe you don't need to create a new PR. You might be able to just rebase and push -f to xiaoyinl:modulefilename.

@suwc Thank you! I did it. But now this PR can't be reopened. "The modulefilename branch was force-pushed or recreated". I should have forced push earlier. Anyway, now it seems I have to recreate a PR.


Add release demo for v1.26

Can we also fill in the readme file for this repo to list an index of hosted demo apps? I expect most if not all of these demos are still live and a clean list of links to access them would be nice in the readme file.
Ping to @snehankekre for tracking.


Ignore fullscreen windows

Minor compatibility fix for Fullscreen Avoider extension: removes a small delay making the Top bar transparent when it gets moved to secondary display.

Thanks!


[WIP] Add health check strategy

Motivation

https://github.com/line/armeria/issues/1953
When HealthCheckEndpointGroup has a lot of candidates, it's not efficient.

Modification

Divide `how to select health check candidate' as HealthCheckStrategy.
Make all check strategy as default.
Make partial check strategy.
Test code and javadoc are not yet. (Interface would be changed by review)

Result

NOT YET

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sunghoon Park seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Devel

Coverage decreased (-0.2%) to 60.811% when pulling 2e3f98afcdb79af5d027a192cecffc1f36c4b403 on devel into ebca817d1d194ff0137facc4686da75e468022f3 on master.


Tin ingot (mekanism) recipe switched to uranium cane from tin cane

For some reason the tin ingot recipe randomly switched to uranium cane but used to be tin cane a week ago (when i last played) and i didn't do anything with the mod files in between the time i last played and now (when i posted the issue) and the bug isn't world specific and i also redownloaded the file and it didn't fix the bug. Attached some screenshots of the bug.

Fix in 2.4.1 or 2.4.2(minecraft 1.18)


top level awaits seem to be not supported.

What problem does this feature solve?
[Farm] Error loading dynamic module "virtual:FARMFE_DYNAMIC_IMPORT:C:\Users\pinke\p\as-examples\n-body\n-body\build\as_nbody.mjs" ReferenceError: await is not defined
Hi again! Huge thank you for the work! I've attached a pretty simple assemblyscript output (.mjs + .wasm + .d.ts) that seems to be impossible to straightforward tune to wrap itself to anything but top-level awaits. Honestly, vite does not do anything with them too and has pretty the same error.
Is there a way to workaround this ?
build.zip
What does the proposed API look like?
top-level awaits are supported by all modern browsers, and cracking this support by a bundler looks weird.

Top level await is not supported for now. It will be supported soon.

Top level await will be supported in<EMAIL_ADDRESS>


Set max length 256 on names and add indexes

Fixes https://github.com/aspnet/Identity/issues/370
@divega does this look ok to you?

I verified that the table definitions look like this:
CREATE TABLE [dbo].[AspNetUsers] (
[Id]                   INT                IDENTITY (1, 1) NOT NULL,
[AccessFailedCount]    INT                NOT NULL,
[ConcurrencyStamp]     NVARCHAR (MAX)     NULL,
[Email]                NVARCHAR (256)     NULL,
[EmailConfirmed]       BIT                NOT NULL,
[LockoutEnabled]       BIT                NOT NULL,
[LockoutEnd]           DATETIMEOFFSET (7) NULL,
[NormalizedEmail]      NVARCHAR (256)     NULL,
[NormalizedUserName]   NVARCHAR (256)     NULL,
[PasswordHash]         NVARCHAR (MAX)     NULL,
[PhoneNumber]          NVARCHAR (MAX)     NULL,
[PhoneNumberConfirmed] BIT                NOT NULL,
[SecurityStamp]        NVARCHAR (MAX)     NULL,
[TwoFactorEnabled]     BIT                NOT NULL,
[UserName]             NVARCHAR (256)     NULL,
CONSTRAINT [PK_IntUser] PRIMARY KEY CLUSTERED ([Id] ASC)
);
GO
CREATE NONCLUSTERED INDEX [IX_IntUser_NormalizedUserName_NormalizedEmail]
ON [dbo].[AspNetUsers]([NormalizedUserName] ASC, [NormalizedEmail] ASC);
CREATE TABLE [dbo].[AspNetRoles] (
[Id]               INT            IDENTITY (1, 1) NOT NULL,
[ConcurrencyStamp] NVARCHAR (MAX) NULL,
[Name]             NVARCHAR (256) NULL,
[NormalizedName]   NVARCHAR (256) NULL,
CONSTRAINT [PK_IntRole] PRIMARY KEY CLUSTERED ([Id] ASC)
);
GO
CREATE NONCLUSTERED INDEX [IX_IntRole_NormalizedName]
ON [dbo].[AspNetRoles]([NormalizedName] ASC);

Updated to use u => u.NormalizedUserName syntax, also added verification of default schema for columns and indexes

:shipit:

d8b3cf238e3a106ebb3e08b1eb9f5661f997cdc0


Azure Cognitive Search - TOC fix, landing page corrections

Docs Build status updates of commit f8c6dc1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0a0e092:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c0c4530:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 81b12d0:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit fe72110:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit e456f27:
:warning: Validation status: warnings

File
Status
Preview URL
Details

:warning:Warning

Details

api/overview/azure/search.md
:white_check_mark:Succeeded
View

docs-ref-toc/top_level_toc.yml
:white_check_mark:Succeeded

[Warning-DuplicateUids] Uid(azure.net.sdk.landingPage.services.EventHub.Client) has already been defined in api/overview/azure/EventHubs/V4.yml.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off  @scbedd @maggiepint
Please merge for the Tuesday July 21 publish.  This PR restores a landing page for the older V10 client, adds client version disambiguation in the TOC, and adds specifics about version differences. Only my files were touched in this PR. The validation warning in this PR is unrelated to my changes.


Doesn't seem to work with React Native?

App crashes on launch. I've even added React Native to the TrustKitDemo project following these steps:
https://facebook.github.io/react-native/docs/integration-with-existing-apps
It crashes on  [TrustKit initSharedInstanceWithConfiguration:_trustKitConfig];

Any ideas? Has anyone got TrustKit working with RN?

Hello,
on our side, we have not tried to use TrustKit in a React app. The location of the crash is surprising but I don't know much about React either.

I am having the same issue. any solution for this yet?

Please take a closer look at the logs, at least in my case it says:

Terminating app due to uncaught exception 'TrustKit configuration invalid', reason: 'TrustKit was initialized with less than 2 pins...

And it crashes exactly as @apski describes above. Adding another public key hash fixed the issue.


fix(interactive): Fix bugs When Counting on Multiple Columns

What do these changes do?
as titled.

Related issue number

Fixes #3410

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (10ecb95) 40.90% compared to head (5bf01aa) 40.90%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3442   +/-   ##
=======================================
  Coverage   40.90%   40.90%
=======================================
  Files         109      109
  Lines       11343    11343
=======================================
  Hits         4640     4640
  Misses       6703     6703

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ecb95...5bf01aa. Read the comment docs.


Remove double space in error message IDX10214

To be consistent with error message IDX10205.
Related to issue #426 and PR #429. This PR is on the 5.x branch.

Hi @bgever, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


GSM Module Feasibility Verification

Verify the feasibility of adding a GSM module to the Raspberry Pi.

@qmascarenhas how does this look?
https://www.jeffgeerling.com/blog/2022/using-4g-lte-wireless-modems-on-raspberry-pi

@ATATC This doc is precisely what we’re looking for b/c there’s lots of little nuances that we’ll run in to and it would help to have a single resource to reference instead of scouring the web. I’d probably go for the hat option unless we have enough real estate.

https://github.com/Civlo85/gsmHat seems to serve the purpose.

https://www.waveshare.com/SIM7600A-H-4G-HAT.htm
It's designed for North American scenarios and it states that it "comes with development resources and manual (examples for Raspberry Pi/Jetson Nano/Arduino/STM32)"

Most tutorials I found used modules from Waveshare although it's a Chinese company based in Shenzhen. I did not find any known issues regarding the hats in the limited number of references on Google. There is a detailed doc written by the manufacturer: https://www.waveshare.com/wiki/SIM7600A-H_4G_HAT.

There is a problem though, I am not sure whether it works as a system-level adapter like WiFi.

Under current circumstances I don't think it's worth taking extra time to dig into. We can leave it in VeC 3.0.


Is it possible to make use of the Kong Session plugin?

Hi guys!
I've had a hard time to make the OIDC plugin work with my Kong setup (on AWS EKS)
Thanks to https://github.com/nokia/kong-oidc/issues/123, setting the session secrect for both Kong and the OIDC plugin finally did the trick. (I also raised the large_client_header_buffers to "8 24k")
Although everything is working fine now I am a little bit concerned if the cookie header size might be an issue in the future.
So my question is, would it be possible to use the Kong Session plugin (https://docs.konghq.com/hub/kong-inc/session/) with the database as a session storage instead of cookies?
I've activated the session plugin globally but the OIDC plugin still uses its own session cookies.
Thanks,
Stephan

That's because this oidc plugin works with lua-resty-openidc lib, it also uses lua-resty-session directly. You can add manually the sessionConfig parameters in the schema.lua and update the authenticate method:
local res, err = require("resty.openidc").authenticate(oidcConfig, nil, nil, sessionConfig)

One more thing, the kong-session plugin is based on lua-resty-session too, so you will have the same functionality, but u will need to implement. I think the kong plugin is exclusively meant for work with the enterprise plugins.


Use symbol key maps instead of string keys

Will make a lot of logic simpler and clearer.

It's safer to use string keys for the data and metadata blobs, to prevent exhausting the symbol namespace.


Develop a component template

Assessment of requirements for a component to be complete

[x] What sections do we include in component documentation? Minimum, plus optional.
[x] What are the content blocks (requirements) for each section?
[x] Review Jillian's audit
[ ] Review Button, Link, and Notification components
[ ] Audit of other design systems as needed
[ ] Build out a component template that's ready to use for the next assessment phase

Rolling this work into #1070


Client Allocation Request for: Yak Cho Myung Ga

Client Allocation Questions
Core Information

Name: Yak Cho Myung Ga
Website / Social Media: https://www.약초명가.com/ Slack @pangpang
Region: Asia excl. Greater China
DataCap Requested: 1TiB
Addresses to be Notarized: f1jk7gbw5mjqwlwkl3oz2yx6ms3rlyza2mgwk4dxa
Notary Requested: rayshitou

@cloudC20 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hi @cloudC20, gald to see you here.
May I ask whether you are applying Datacap in the name of an individual or a company, and could you please give me a brief introduction.

Thank you for the reply,
Yak Cho Myung Ga is applying Datacap as a company. We plan to use this datacap in Asia. We plan to use the datacap to store for our files/data of our products.

Great!
Can you give me a brief introduction about your company？And to be prudent, I also need to check the business license of your company. Could you please send it to my email address (dlleig@gmail.com)?

Hello, I've sent the business license to your email. thank you!

got it. thanks!
Could you please show me your company searching consequence in the local business license searching website?
And have you/your company ever used cloud? If yes,  Which platform do you use? What's your usage volume and frequency?Could you please show me your cloud usage evidence?

We have only used our own server, and have not used cloud services. I have attached the screenshot and the website to check the business license thru email

okey. It's not decisive.
Could you please show me your company searching consequence in the local business license searching website?
And about the data you want to store, please answer:
1.What kind of data do you want to store and how much?
2.Could you please send me some demos of your data?
3.Do you agree to use the DataCap to only store data that abides by local regulations and in compliance with the recipient miner's terms of service?

Sorry, I just saw your email about your business license searching website. I have checked it and there is no problem.

Okey.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzaceclk6a3kejdaz2vowsc63h35xqioroplejfvnqrj5mqktwkfv7owc

Address

f1jk7gbw5mjqwlwkl3oz2yx6ms3rlyza2mgwk4dxa

Datacap Allocated

1TiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzaceclk6a3kejdaz2vowsc63h35xqioroplejfvnqrj5mqktwkfv7owc


Tilemap rendering sets initial state better

#1666 - previous alpha state could bleed through.
Now the initial alpha and composite modes are set explicitly.

Does not fix problems fully

But that does fix it..


Run Docker as non-root

https://public-site-radix-platform-qa.radix.equinor.com/docs/topic-docker/#running-as-non-root

You can ask Reza how this is done


[gardening] Replace likely word processor artefacts with ASCII equivalents (— → --, … → ...)

@swift-ci please smoke test

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 3918d9d25115527af0d82de9e658c9f29bf9c5b1
Test requested by - @practicalswift

Heh. I missed this at the time, but I guess I'm probably the only one who uses ... vs … to make a semantic distinction. (The former is a token; the latter is omitted code.)


Make one of our FAB bots participate on beta.metaculus.com

@ncarazon is this something you could do? If not, can you suggest another engineer?

@hickman-santini I think @hlibowski or @lsabor would have more context here

Elis did this! The bot is working now, thanks @lsabor for helping Tom.


Error: routine at frontends/vmc.rs:118 vm_start(vm_name,user_id_hash,matches.opt_present("enable-gpu")) failed: bad VM status: VM_STATUS_FAILURE: failed to mount stateful: Input/output error

After upgrading to Chromebook v73, I'm getting this error starting up Linux apps. When attempting to restart termina, I get the following responses:
`vm_start(vm_name,user_id_hash,matches.opt_present("enable-gpu"))` failed: bad VM status: `VM_STATUS_FAILURE`: failed to mount stateful: Input/output error

I've found the following thread on reddit. The hard reset hasn't worked, so I'm looking at uninstalling & reinstalling Linux.
I wanted to try using bakery, but I need to reinstall Linux first.

I fixed this by uninstalling and reinstalling Linux.  That was the best solution for the time being. In the future (version 74 Chrome OS) backups should be more available.


Configurable Origins and small configuration fixes

This makes it configurable to specify multiple origins as allowed (default only local origin is allowed). Wildcard origin will not be supported as it is a security vulnerability.
It adds a compatibility check in configuration for windows paths.
Upgrades servlet config to add httponly and secure which will secure session cookies if used.

Thanks for the fix! Tested and Looks good to me.

@djoelz Thanks for adding the origin names a configuration option. Much appreciated.

Thanks @djoelz. I'm merging it.


Property does not exist on never with empty interface and type guard

TypeScript Version:  2.1.1
Code
export interface Record {
    kind: string;
    name: string;
}

export interface UsefulType extends Record {}

export function isUseful(c: Record): c is UsefulType {
    return c.kind === "one";
}

export function doThing(record: Record) {
    if (isUseful(record)) {
        return null;
    }

    console.log(record.name);
    return record;
}

Expected behavior:
No errors.
Actual behavior:
record is converted to never after the if.
This seems to be because of the empty interface declaration. While I know it's not really that useful to declare an empty interface, it's useful for us to implicitly document this particular library and it really shouldn't cause an error.
If you add a member of any kind to the interface, the error clears up.
Playground Link

Types in TypeScript are structural. The narrowing with the user-defined type guard will remove anything that looks like UsefulType, which happens to be the same as Record since it does not add any new properties. Removing type Record, you are left with never.

👍

`function isBook(text: Book | Magazine): text is Book {
return (text).author !== undefined;
}
let readingMaterial: Book | Magazine = util.GetAllBooks()[0];
if (isBook(readingMaterial)) {
console.log(The book's author is ${readingMaterial.author});
}
else {
console.log(The magazine's publisher is ${readingMaterial.publisher});
}`

TS2339	Property 'publisher' does not exist on type 'never'.

in my case though, I have a type that I'm left with after removing one type. Ideally this should make typescript narrow it down to Magazin in the else block. However that isn't happening.


Treesitter error: attempt to  index local 'node' (a nil value)

Describe the bug
Error executing vim.schedule lua callback: ...z8ox/usr/share/nvim/runtime/lua/vim/treesitter/query.lua:185: attempt to
index local 'node' (a nil value)
stack traceback:
        ...z8ox/usr/share/nvim/runtime/lua/vim/treesitter/query.lua:185: in function 'get_node_text'
        ...erial.nvim/lua/aerial/backends/treesitter/extensions.lua:156: in function 'postprocess'
        ...gged/aerial.nvim/lua/aerial/backends/treesitter/init.lua:103: in function 'fetch_symbols'
        ...re/nvim/plugged/aerial.nvim/lua/aerial/backends/util.lua:45: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

System information

OS: Ubuntu 20.04
Neovim version: 0.7 latest stable release
AerialInfo:

Aerial Info
-----------
Filetype: cpp
Configured backends:
  treesitter (supported) (attached)
  lsp (supported)
  markdown (not supported) [Filetype is not markdown]
Show symbols: Class, Constructor, Enum, Function, Interface, Module, Method, Struct

Aerial config:

require("aerial").setup({
  on_attach = function(bufnr)
    -- Toggle the aerial window with <leader>a
    vim.api.nvim_buf_set_keymap(bufnr, 'n', '<leader>aa', '<cmd>AerialToggle<CR>', {})
    -- Jump forwards/backwards with '{' and '}'
    vim.api.nvim_buf_set_keymap(bufnr, 'n', '{', '<cmd>AerialPrev<CR>', {})
    vim.api.nvim_buf_set_keymap(bufnr, 'n', '}', '<cmd>AerialNext<CR>', {})
    -- Jump up the tree with '[[' or ']]'
    vim.api.nvim_buf_set_keymap(bufnr, 'n', '[[', '<cmd>AerialPrevUp<CR>', {})
    vim.api.nvim_buf_set_keymap(bufnr, 'n', ']]', '<cmd>AerialNextUp<CR>', {})
  end
})

To Reproduce
Steps to reproduce the behavior:

Create a header file with the code below
Try and edit anything and save the file
The error above will occur

If possible, provide a minimal file that will trigger the issue:
bool operator < (int, int) {

}

Additional context
The error happens even after a plug update, i.e. in the latest aerial version.

Thanks for the report, should be fixed! This time I added a guard so that hopefully in the future if something like this comes up it will just produce sub-optimal symbol names instead of erroring.


Information: Support for other models is possible

Hey Martin,
thanks for your awesome component.
Just today I saw your project and took some time to get it working for my Creality K1C by changing around some sensor names with values that I could capture from my device.
The configuration is quite different from your device.
The device by default does not use a password for the websocket and the default port is now 9999.
I was able to get a load of information over to Home Assistant.
I am not a good coder, at least not in python and I don't quite understand the Home Assistant syntax, so I can't really contribute working code as I just copy pasted your sensor names and changed them to what I saw in the websocket output from my device.
The device also has a camera builtin that can be accessed via http://IPADDRESS:8080/?action=stream
If you would like to make this component compatible with the K1C (and therefore maybe also the K1 and K1 Max) I have included the whole set of data that is transmitted from the printer so you can use them. I have not tested sending commands yet, as I don't want to risk my ongoing print to fail :)
Again: NOT ASKING you to add this for me; just providing information for the case that you want to push this component forward with other models.
I am happy to provide other data if you give me a hint on how to capture / provide.
Best wishes from germany
The first long batch is what you get for the initial response to opening the connection.
The next rows are every update, I assume the printer just sends every changed bit since the last transmission.
I have redacted some parts with the word REDACTED.
{ "TotalLayer": 72,
"accelToDecelLimits": 2500,
"accelerationLimits": 5000,
"aiDetection": 0,
"aiFirstFloor": 0,
"aiPausePrint": 0,
"aiSw": 0,
"autoLevelResult": "",
"autohome": "X:1 Y:1 Z:1",
"auxiliaryFanPct": 0,
"bedTemp0": "69.250000",
"bedTemp1": "0.000000",
"bedTemp2": "0.000000",
"bedTempAutoPid": 0,
"boxTemp": 35,
"caseFanPct": 100,
"connect": 1,
"cornerVelocityLimits": 5,
"curFeedratePct": 100,
"curFlowratePct": 100,
"curPosition": "X:78.26 Y:152.20 Z:1.15",
"dProgress": 0,
"deviceState": 1,
"enableSelfTest": 0,
"err": { "errcode": 0,
"key": 0 },
"fan": 1,
"fanAuxiliary": 0,
"fanCase": 1,
"hostname": "K1C-REDACTED",
"layer": 6,
"lightSw": 1,
"materialDetect": 0,
"materialStatus": 0,
"maxBedTemp": 115,
"maxNozzleTemp": 320,
"model": "K1C",
"modelFanPct": 100,
"modelVersion": "printer hw ver:;printer sw ver:;DWIN hw ver:REDACTED;DWIN sw ver:<IP_ADDRESS>;",
"nozzleMoveSnapshot": 0,
"nozzleTemp": "229.410000",
"nozzleTempAutoPid": 0,
"powerLoss": 0,
"pressureAdvance": "0.055000",
"printFileName": "REDACTED.gcode",
"printId": "",
"printJobTime": 1811,
"printLeftTime": 8430,
"printProgress": 4,
"printStartTime":<PHONE_NUMBER>,
"realTimeFlow": "8.730000",
"realTimeSpeed": "112.780000",
"repoPlrStatus": 0,
"smoothTime": "0.040000",
"state": 1,
"targetBedTemp0": 70,
"targetBedTemp1": 0,
"targetBedTemp2": 0,
"targetNozzleTemp": 230,
"tfCard": 1,
"upgradeStatus": 0,
"usedMaterialLength": 5397,
"velocityLimits": 600,
"video": 1,
"video1": 0,
"videoElapse": 1,
"videoElapseFrame": 15,
"videoElapseInterval": 1,
"withSelfTest": 100 }

{ "nozzleTemp": "229.600000", "printJobTime": 1812, "realTimeFlow": "6.380000", "curPosition": "X:86.59 Y:144.47 Z:1.18" }
{ "nozzleTemp": "229.830000", "bedTemp0": "69.240000", "usedMaterialLength": 5398, "curPosition": "X:104.71 Y:126.71 Z:1.26" }
{ "nozzleTemp": "230.090000", "bedTemp0": "69.230000", "printLeftTime": 8429, "usedMaterialLength": 5400, "curPosition": "X:86.03 Y:145.62 Z:1.18" }
{ "nozzleTemp": "230.340000", "bedTemp0": "69.240000", "usedMaterialLength": 5401, "curPosition": "X:81.20 Y:151.04 Z:1.16" }
{ "nozzleTemp": "230.560000", "bedTemp0": "69.250000", "printJobTime": 1813, "usedMaterialLength": 5402, "curPosition": "X:102.22 Y:130.02 Z:1.25" }
{ "curPosition": "X:90.47 Y:142.37 Z:1.19" }
{ "nozzleTemp": "230.720000", "bedTemp0": "69.270000", "printLeftTime": 8428, "usedMaterialLength": 5403, "curPosition": "X:79.12 Y:154.30 Z:1.14" }
{ "nozzleTemp": "230.830000", "usedMaterialLength": 5404, "curPosition": "X:99.10 Y:134.33 Z:1.23" }
{ "nozzleTemp": "230.870000", "bedTemp0": "69.280000", "printJobTime": 1814, "realTimeFlow": "8.570000", "curPosition": "X:93.56 Y:140.47 Z:1.20" }
{ "nozzleTemp": "230.860000", "bedTemp0": "69.300000", "usedMaterialLength": 5405, "curPosition": "X:78.50 Y:156.12 Z:1.14" }
{ "nozzleTemp": "230.790000", "bedTemp0": "69.320000", "printLeftTime": 8427, "usedMaterialLength": 5406, "curPosition": "X:98.46 Y:136.15 Z:1.22" }
{ "bedTemp0": "69.340000", "usedMaterialLength": 5407, "curPosition": "X:94.19 Y:141.02 Z:1.20" }
{ "nozzleTemp": "230.640000", "bedTemp0": "69.360000", "printJobTime": 1815, "curPosition": "X:80.20 Y:155.61 Z:1.14" }
{ "nozzleTemp": "230.450000", "usedMaterialLength": 5408, "curPosition": "X:100.15 Y:135.65 Z:1.22" }
{ "nozzleTemp": "230.200000", "bedTemp0": "69.390000", "printLeftTime": 8426, "usedMaterialLength": 5409, "curPosition": "X:92.50 Y:143.90 Z:1.19" }
{ "nozzleTemp": "229.950000", "bedTemp0": "69.420000", "usedMaterialLength": 5410, "curPosition": "X:84.23 Y:152.76 Z:1.15" }

I have chosen to display this values, as they are enough information to me :)

I also got K1C, did some digging and would be happy to help :)
Their filament printers (or at least K1 family) actually use forked Klipper (https://github.com/CrealityOfficial/K1_Series_Klipper) with custom Web UI that doubles as API server for Creality Print app. That server is a single binary in ROM (/usr/bin/web-server) and appears not to be any open-source clone.
While I was able to install more common API server - Moonraker and integrate it with Home Assistant properly getting various sensors (except camera - but it's simple MJPEG stream), many features (like current GCODE information) are not available there if you keep using stock firmware functions (e.g. their slicer to upload models or start print from touchscreen).
That said, even if it may be harder to cover both types of printers in this integration, it'd still be worth getting support for stock API. And I think that whatever API they have on Halot should be close enough not to split projects.

Hi @petto,
how have you been able to get this working with your K1C?
Would you be able to share your files?
Thanks

Hey @Yannik25
download the latest release from the repo and replace two files with the files from this .zip
Please note: This is a very very very dirty hack, not meant for any release as I have removed / changed some files without really thinking about compatibility / code quality.
(It is enough for me to display a status in Home Assistant however)
Copy the folder to your Home Assistant installation and restart the system.
Then use the wizard to add the printer, fill in user and password with default values if you are asked to provide them.
Please remember to add the printer with port 9999 in the wizard.
custom_files_for_K1C.zip

Hi @petto
I installed your hack and it seems to be working for my Ender 3 V3 KE as well

CR10 SE. I had to post-hide a couple of incompatible entities. But basically it works too :)

It worked on my K1 Max!
Thanks!

Hi @petto
I installed your hack and it seems to be working for my Ender 3 V3 KE as well

Hello, I have an Ender 3 v2, but I can’t get it connected. Which box do you have connected to your Ender 3 printer? Mine just won’t show up in Home Assistant, even after trying this hack.

My card K1 Max

Hey @Yannik25 download the latest release from the repo and replace two files with the files from this .zip Please note: This is a very very very dirty hack, not meant for any release as I have removed / changed some files without really thinking about compatibility / code quality. (It is enough for me to display a status in Home Assistant however)
Copy the folder to your Home Assistant installation and restart the system. Then use the wizard to add the printer, fill in user and password with default values if you are asked to provide them. Please remember to add the printer with port 9999 in the wizard.
custom_files_for_K1C.zip

I got my Ender 3 V3 Plus into HA using this method. Still calls it a K1C of course. Not pretty but better than nothing! Thanks!

If you change the name in the "sensor.py" file you will get the right name

Hi @petto
I installed your hack and it seems to be working for my Ender 3 V3 KE as well

Hello, I have an Ender 3 v2, but I can’t get it connected. Which box do you have connected to your Ender 3 printer? Mine just won’t show up in Home Assistant, even after trying this hack.

use 9999 for port and just a space for password


Fix tests

> jest
 FAIL  src/schematics/ng-add/index.spec.ts (5.174s)
  ng-add
    × should run ng-add (45ms)
    × should add single-spa dependency (1ms)
    × should add main-single-spa.ts (1ms)
    × should use correct prefix for root (1ms)
    × should not add router dependencies
    × should add router dependencies (1ms)
    × should modify angular.json (1ms)
    × should add build:single-spa npm script

  ● ng-add › should run ng-add

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should add single-spa dependency

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should add main-single-spa.ts

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should use correct prefix for root

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should not add router dependencies

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should add router dependencies

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should modify angular.json

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

  ● ng-add › should add build:single-spa npm script

    Cannot find module 'C:\dev\single-spa-angular\lib\schematics\ng-add' from 'export-ref.js'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:202:17)
      at new ExportStringRef (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/export-ref.ts:19:28)
      at NodeModulesTestEngineHost._resolveReferenceString (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/node-module-engine-host.ts:121:17)
      at NodeModulesTestEngineHost.createSchematicDescription (node_modules/@angular-devkit/schematics/tools/packages/angular_devkit/schematics/tools/file-system-engine-host-base.ts:235:30)
      at SchematicEngine.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:293:34)
      at CollectionImpl.createSchematic (node_modules/@angular-devkit/schematics/src/engine/packages/angular_devkit/schematics/src/engine/engine.ts:90:25)
      at SchematicTestRunner.runSchematic (node_modules/@angular-devkit/schematics/testing/packages/angular_devkit/schematics/testing/schematic-test-runner.ts:93:40)

Test Suites: 1 failed, 1 total
Tests:       8 failed, 8 total
Snapshots:   0 total
Time:        5.318s, estimated 6s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

I confirmed this locally. I'd gladly review a PR for this. Also it would probably be good to add a Travis CI build for PRs that run the tests.

This occurs when you don't build before running the tests. Do the following and the tests work:
npm run build
npm test


Issue when using with the black (formatting) module

ERROR: Failed on file: .\.venv\Lib\site-packages\black\linegen.py
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\V\AppData\Local\Programs\Python\Python311\Lib\site-packages\pipreqs\pipreqs.py", line 131, in get_all_imports
    raise exc
  File "C:\Users\V\AppData\Local\Programs\Python\Python311\Lib\site-packages\pipreqs\pipreqs.py", line 117, in get_all_imports
    tree = ast.parse(contents)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\V\AppData\Local\Programs\Python\Python311\Lib\ast.py", line 50, in parse
    return compile(source, filename, mode, flags,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<unknown>", line 412
    Ã˜: Set[str] = set()
     ^
SyntaxError: invalid character '˜' (U+02DC)

This seems to be occurring due to this line in this file - https://github.com/psf/black/blob/a552f7096a9f6e016c9bb1df1e0a77a17caeec1c/src/black/linegen.py#L471 due to the weird variable name.
Because Black is such a popular library, and the variable name seems to be valid, any workarounds for using pipreqs to generate a requirements.txt file?

Seems like pipreqs doesn't use the correct encoding (utf-8 by default) for opening Python files. The error message posted above has mojibake, suggesting the file was opened in something like Latin-1 instead of UTF-8.


app that you are trying to run is not supported on this version of Windows

Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.

C:\Users\Ivan Skiridomov>bash
-- Beta feature --
This will install Ubuntu on Windows, distributed by Canonical
and licensed under its terms available here:
https://aka.ms/uowterms

The app that you are trying to run is not supported on this version of Windows.

OS Name	Microsoft Windows 10 Enterprise N 2016 LTSB
Version	10.0.14393 Build 14393
Developer Mode is On

Feature was installed:

The beta was accidentally included in the LTSB release.  It was subsequently disabled because it cannot be updated or even bugfixed without updating the kernel-mode drivers lxcore.sys and lxss.sys, both of which are strictly bound to specific versions of the Windows kernel (for example, work on networking to support some WSL features was transported into the kernel-mode "Winsock Kernel" core piece of the NT kernel, where it will also be used to provide more socket functionality to the Win32 usermode Winsock API as well).
The drivers lxcore.sys and lxss.sys (being beta components) are being maintained directly along the "Fast ring" of the Insider branch of Windows 10.  The "slow ring" provides snapshots of the "fast ring", and the Current Branch will be replaced roughly this April by another fork of the Insider branch.  Until the Windows Subsystem for Linux loses its "beta" tag, it will only be available (updates, bugfixes, etc) in the Current Branch as a snapshot of its state at the date of the fork, without even bugfixes being backported to the current branch from the Insider Branch.
Given that even the Current Branch is not currently receiving bugfixes, upgrades, or likely even security fixes, it would be impossible to handle bugfixes in LTSB (releases scheduled 2-3 years apart!) of a feature that is highly incomplete and has already hit several bugchecks (many bugchecks are also potential security vulnerabilities, and it is dangerous to use buggy drivers in kernel-mode).
So a decision was taken by Microsoft to remove this feature from LTSB until it is out of beta, at which point it will at least have bugs and security vulnerabilities fixed and backported.  On the other hand, this also means that LTSB will not be receiving this functionality in stable form until at least 2018 if not 2019.
If you want to use WSL, it is highly recommended to run Insider builds or at the very least the Current Branch, which receives updates roughly every nine months.

Marking as duplicate of #1281.

Very nice explanation and again a terrible choice of MS, so I think I installed Win 10 enterprise for nothing. Please look how FreeBSD handles Linux using a subsystem and a kernel mode module that can be updated.
Why do you allow installing the linux subsystem at all when you cannot run bash on newer W10 builds?


Update version of moment.js

Addresses: https://github.com/NuGet/Engineering/issues/4343

Branch name containing a _ created CI issues. Closing and re-PRing with https://github.com/NuGet/NuGetGallery/pull/9093.


What kind of Event (actions) are avalaible?

As example holiday events have the onClick event (seems the only one that is possible to intercept).
But if I want an event to be executed on removing one or changing some details there are some events that I can use? As I need as example that those user actions execute custom code to integrate somewhere else.
I was wondering something that I can use with addEventListener or a global function in the CalendarJS library.
As I can see now everything executed in the calendar is just exportable as CSV/etc but I cannot intercept those user actions, in the documentation/code I don't find anything.

  You will see a list of custom events that can be assigned and triggered when the user performs a specific action, like adding an event, removing an event, etc.
If there is something that needs to trigger that is not on that list, let me know.  I will add it to the to-do list.
Thanks

Thanks for raising this issue. I have the same need. Can anyone give a snippet of codes how to handle onClick when clicking on an event? Thank you very much.

Hi there,
You can see all the events supported here:
https://calendar-js.com/documentation/custom-triggers.html
To assign an event, use the following example:
var calendarInstance = new calendarJs( "myCalendar", {
  events: {
    onEventsAdded: YourJSFunction
  }
} );

You can also set the custom events by calling setOptions().


AWS-Region issue when trying to work with EC2-Instance Profiles via KIAM

Describe the bug
Using a Kubernetes Installation on AWS-EC2-VMs. To communicate to AWS (Assume-Roles) we use KIAM (https://github.com/uswitch/kiam)
When trying to remove the Access_Keys and Access_Secrets and make use of EC2-Instance Profiles, Falcosidekick fails when it tries to connect to AWS.
Error Message in the Logs:
2022/06/01 10:30:33 [ERROR] : AWS - MissingRegion: could not find region configuration
How to reproduce it
When removing the following Entries from secret of Falcosidekick:

AWS_ACCESSKEYID:
AWS_SECRETACCESSKEY:
AWS_REGION:

it will show the following error: 2022/06/01 10:30:33 [ERROR] : AWS - MissingRegion: could not find region configuration
When putting the AWS_REGION with the the correct Region (ex. "eu-central-1") then it will show the following error:
2022/06/01 10:50:45 [ERROR] : AWS - Error while getting AWS Token
After a hint from @Issif I tried to define Environment variable: AWS_STS_REGIONAL_ENDPOINTS = true
the following error message is shown:
2022/06/01 11:00:30 [ERROR] : AWS - Error while creating AWS Session
Expected behaviour
Login via Instance-Role Profile should work and should be able to communicate with the AWS-API.
Environment

Falco version:
falco version: 0.31.1
falcosidekick version: 2.25.0
System info:

{
  "machine": "x86_64",
  "nodename": "xxxxxxxxx"
  "release": "5.10.107-flatcar",
  "sysname": "Linux",
  "version": "#1 SMP Tue Mar 22 19:39:53 -00 2022"
}

Thank you for this report, I'll do some tests on my own with as much use-cases as possible.

I've tested it as we also want to use KIAM. We do get one step further, but then this error occurs:
2022/06/17 07:39:29 [ERROR] : AWS - Error while getting AWS Token: WebIdentityErr: failed to retrieve credentials
caused by: InvalidIdentityToken: No OpenIDConnect provider found in your account for https://oidc.eks.eu-central-1.amazonaws.com/id/<SOME_ID>
	status code: 400, request id: f2142f50-1967-4f60-b2b9-.........

As you may expect, we do not use OIDC and do not have OIDC configured. Is it absolutely necessary to have an OIDC provider for FalcoSidekick?
Cheers,
Eelko

Found the problem on my side - I had set the config.aws.rolearn which then triggered the OIDC path in the code. When left empty there is no error message and KIAM is used as intended!

If it's OK for you, do you think we can close this issue then? Thanks

/close

@Issif: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


[CI] Align git author with commiter

Submission Checklist

[ ] Run unit tests: ./runTests.py src/test/unit
[ ] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary
Define git author and committer information as environment variables, removed git config and --author usage, see https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables.
Intended Effect
Fix an issue where a merge is done in CI will be committed by the default git committer, see https://github.com/stan-dev/stan/pull/3153
How to Verify
Break format in this PR and ensure commits come from Stan Jenkins.
Side Effects
None
Documentation
None
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Toptal
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

@WardBrian I think this PR will solve that issue, the only "problem" is that I'm not entirely sure how to trigger that specific merge to happen to confirm it works ... In theory, the env variables will ensure the correct committer and author are set.

I’m also not sure how to cause it - maybe there needs to be a change to develop first which needs to be merged?
I’m happy to just take a best-effort improvement even if we’re not 100% positive it fixed the issue. It wouldn’t make it worse, for sure

Oki sounds great, as soon as I have some free time I'll re-open this one since I messed up a lot here. I did go over other repos and stan, math, cmdstan will also require this PR. I'll tag you when ready, thanks for the help!


Update driver in order to be compatible with BigchainDB2.0

fixes #157
This PR also fixes #147 and fixes #149

Codecov Report

Merging #159 into master will decrease coverage by 2.16%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage    82.7%   80.54%   -2.17%
==========================================
  Files          11       11
  Lines         266      257       -9
==========================================
- Hits          220      207      -13
- Misses         46       50       +4

Impacted Files
Coverage Δ

src/transaction.js
91.25% <100%> (ø)
:arrow_up:

src/connection.js
92.3% <33.33%> (-1.98%)
:arrow_down:

src/request.js
78.57% <0%> (-14.29%)
:arrow_down:

src/baseRequest.js
72.41% <0%> (-6.9%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1b25b1...55dbaf8. Read the comment docs.


Add documentation for the OmegaConf grammar

Some "design choices" I made, happy to discuss them here:

Not dumping the whole set of parser rules as is done in Hydra's documentation: this is because it would be pretty much unreadable with the current documentation formatting (in particular due to the limited width). Instead, I chose to focus on a few relevant excerpts, and link to the file if someone wants to see the whole thing
Making a few simplifications (not mentioning all details), in order to (hopefully) keep it digestible

I'm requesting reviews for diverse people to get feedback both from those familiar vs unfamiliar with it.
For ease of reviewing I suggest you build it locally:
cd docs && make html && open build/html/index.html

I believe that the CI should pass if changes from PR #800 are incorporated into this branch.

I believe that the CI should pass if changes from PR #800 are incorporated into this branch.

Thanks, I'll rebase before merging to get it green.


Deprecating https://gitlab.com/CentOS/cloud/issue-tracker

Needs a rebase now, but otherwise looks sane


Release 0.8.1

/test-all

/test-whole-conformance

"Whole conformance" test has passed, merging this now. Will run EKS and GKE tests right after.


[FLOC-3890] Add views for master and releases branches.

OK w/ code. Can you link to a demo?

http://<IP_ADDRESS>:8080/job/ClusterHQ-flocker/
using the same credentials as the main instance.

Great, thanks.


Add task for clearing pinata pinned files since we only get 100

completed as part of https://github.com/COSC880/nasanft-contracts/issues/28


Add script to update readme --help example

It is too easy to forget to update the help snippet in the readme when making changes.
Can we automate this, maybe in the release process?

I'm closing this off as the commands are fairly stable so we can handle it manually.


Chore/sample local fragment and fragment glob

sample test to show how local fragments are ignored in case of fragment glob

This PR did his job)


Game Suggestion

could you possibly add OneShot: World Machine Edition?
thanks!

I have added the game(s) you requested in the most recent release: https://github.com/hobby-grade/Nintendo-Switch-Discord-Status/releases/tag/v1.1.5
Thank you for checking out the project, reach out if you have any more suggestions!


[Question]: Failed to resolve 'es01'

Describe your problem
I tried using the  Launch Service from Source,but have some problem.
Failed to resolve 'es01' ([Errno -3] Temporary failure in name resolution))
curl http://localhost:1200/ is ok

遇到同样的问题，请问你怎么解决的？

Use ip address to replace 'es01'.


no_na() always returns FALSE

The following code
use extendr_api::prelude::*;

fn main() {
    test! {
        let vals1 = Integers::from_values([Rint(1)]);
        dbg!(vals1.no_na());

        let vals2 = Integers::from_values([Rint::na()]);
        dbg!(vals2.no_na());

        let vals3 = Integers::from_values([Rint(1), Rint(2)]);
        dbg!(vals3.no_na());

        let vals4 = Integers::from_values([Rint(1), Rint::na()]);
        dbg!(vals4.no_na());
    }
}

outputs
[src/main.rs:6] vals1.no_na() = FALSE
[src/main.rs:9] vals2.no_na() = FALSE
[src/main.rs:12] vals3.no_na() = FALSE
[src/main.rs:15] vals4.no_na() = FALSE

whereas I would expect the first and third line to be TRUE. The same happens for Doubles and I imagine also other wrappers.
I'm using R 4.2.0 and extendr-api at master (4de57caf577371a9105f2a1669111a00e406f68f).

Confirmed, strange.
testthat::expect_true(
    rextendr::rust_eval("
            let x = Integers::from_values([extendr_api::scalar::Rint(23)]);
            x.no_na()
        ",
        extendr_deps = list(`extendr-api` = list(git = "https://github.com/extendr/extendr"))
    )
)
#> ℹ build directory: 'C:/Users/[redacted]/AppData/Local/Temp/RtmpQ9GxIo/file2a182c8731be'
#> ✔ Writing 'C:/Users/[redacted]/AppData/Local/Temp/RtmpQ9GxIo/file2a182c8731be/target/extendr_wrappers.R'
#> Error: rextendr::rust_eval(...) is not TRUE
#>
#> `actual`:   FALSE
#> `expected`: TRUE

testthat::expect_false(
    rextendr::rust_eval("
            let x = Integers::from_values([extendr_api::scalar::Rint::na()]);
            x.no_na()
        ",
        extendr_deps = list(`extendr-api` = list(git = "https://github.com/extendr/extendr"))
    )
)
#> ℹ build directory: 'C:/Users/[redacted]/AppData/Local/Temp/RtmpQ9GxIo/file2a182c8731be'
#> ✔ Writing 'C:/Users/[redacted]/AppData/Local/Temp/RtmpQ9GxIo/file2a182c8731be/target/extendr_wrappers.R'

Created on 2022-05-17 by the reprex package (v2.0.1)

Integer no_na calls INTEGER_NO_NA.
Much would depend on if this is an ALTREP vector.
With #401 this will mostly use the
default R behaviour, but we should also make the ALTREP no_na have
a sensible default (even if it is RBool::na())
I would suggest a PR to implement a default in altrep.rs for each of the types.

@andy-thomason , I found this the hard way just now. Very strange behaviour TBH.
cpp11::cpp_function("int test_fn(SEXP x) {return INTEGER_NO_NA(x);}")
testthat::expect_equal(
    test_fn(1L:2L),
    1
)
testthat::expect_equal(
    test_fn(c(1L, 2L)),
    1
)
#> Error: test_fn(c(1L, 2L)) not equal to 1.
#> 1/1 mismatches
#> [1] 0 - 1 == -1

Created on 2022-05-17 by the reprex package (v2.0.1)

Ok, now it seems I begin to understand. So if *_NO_NA(...) returns TRUE, we are sure there are no NAs (like in ALTREP 1:5). However, if it is a regular vector (e.g., c(1, 5)), it performs no real checks and returns FALSE, but there might still be no NAs.
If that is indeed the case, than I am not a fan of .no_na() name, as it is misleading. It should be something like no_na_or_unknown() or any similar variation. And perhaps return not a bool or Rbool, but rather an enum with NoNA and Unknown  variants. That way if we test an altrep guaranteed to have no NAs, we get a NoNA response. Otherwise, we get Unknown.
Not exactly a thin wrapper, but at least it won't confuse people that much.

an enum with NoNA and Unknown variants.

This sounds good to me, if there's no significant performance penalty (since, iiuc, these shortcuts are all about performance).
Regarding the name, I'm not sure I agree with no_na_or_unknown(). It might be confusing in turn to those who are familiar with the *_NO_NA() functions on C++.

It might be confusing

Unfortunately *_NO_NA() itself if misleading. So we have two options: (i) use no_na() and propagate this confusion, triggering issues like the issue-starter person had (and I also expected no_na() to reliably check for the absence of NA, with some perf optimizations), or (ii) use different name which better communicates the function behavior, yet potentially confusing hardcore R/C++ devs. I prefer the latter, but won't object to the former.
Perhaps the return type in the form of enum would better communicate the intended outcome of the function call, so I hope it will be adopted in any case.

Thanks for looking into this. Stepping back a little bit, I wonder how valuable it really is to duplicate the confusing C API here. If you ask "does this vector contain any NAs"? and the response is "maybe" then I find it hard to see how you could ever be satisfied with that response. In that scenario isn't the only thing you would ever do just to iterate over the vector anyway?
What if no_na() works by first trying *_NO_NA and in the indeterminate case iterate over the vector to provide a real answer (as a bool rather than Rbool). Then it becomes a way to efficiently find if there are no NAs without accidentally allocating due to iterating over an ALTREP or converting types. That seems like a more useful API and I don't see what would be lost by not exposing direct equivalents of *_NO_NA if that API were available instead.

Ah, I see. There are 2 distinct uses for *_NO_NA in the R codebase:

Decide whether a specialised algorithm can be used for performance gain (example alongside *_IS_SORTED). In this case the indeterminate answer is fine because falling back on the slow variant is ok.
Efficiently find out if a vector contains NAs (example). In this case you would always have to follow up with iteration in the indeterminate case. Note this example is the implementation of base::anyNA which sounds pretty much like the negation of the function I was describing above, and what I'd imagined no_na did from the name :)

Maybe the first case is useful (there's also is_altrep though, which seems to overlap), I don't know. If no_na stays though it would probably be enough just to explain in its documentation that it's only really useful for specialisation, and perhaps point to an alternative like .iter().all(|e| e.is_na()) for the second and more common use case.

We could call it something like no_na_optimization() or optim_no_na() (if you'd rather a prefix) to make it clear it's only there as a performance thing? Then we could also add a real not_na() method which calls .iter().all(|e| e.is_na()) as mentioned above. The two methods should have a nice docstring explaining this difference as well.

What if we keep .no_na(&self) and make it return an enum (casting result to which should be close to no-op and not affect performance that much), and add another has_no_na(&self) -> bool, which will do something like self.no_na() == NoNAResult.NoNA || self.iter()./*<whatever>*/.all(|e| e.is_na()), which will first check using optimized method, and if it is unknown, resort to iterating over collection.  Obviously, naming can be adjusted.

Well I think the original method needs to be available for Rust programmers to be able to use that optimization. If you have a different code path when there are no NAs, and you don't want to waste time checking for them, you still want the original no_na() method.


chore(lightbox-video-player): remove redundant method

Description
Removes a method from <dds-lightbox-video-player>, given no longer inherits HybridRenderMixin and such method is no longer used.
Also fixes a wrong class name.
Changelog
Changed

Fixes a wrong class name in <dds-lightbox-video-player>.

Removed

A method from <dds-lightbox-video-player>

@asudoh something odd happening here, can you take a look?

Good catch @jeffchew - Fixed.

@asudoh Looks like you need to update the snapshots.

Great catch thanks @kennylam - Updated.


Add more commands

More commands need to be added and more websites also need to be added to make Jarvis more useful!
Even if one command is added, we will go ahead with the merge and it will count towards your Hacktoberfest!
Adding commands is easy as you just have to copy-paste the structure of the commands.
Happy Coding!

Hi, can I contribute to this?

Hi, can I contribute to this?

Hi @agotag, check out Contributing.md

Hi @agotag, check out Contributing.md

Hello, I am new to Open Source, can I contribute to this?

@agotag welcome to the world of open source! You can contribute to this repository. You can check out how to do that here
Happy Hacking!

is this still open for hacktoberfest 2022?

is this still open for hacktoberfest 2022?

Yes, it is open for Hacktoberfest 2022!

Still need help?

hello I am a beginner.
Can I contribute to this
want to add email function

@Tyagiquamar, sure! However, i think there's already an email function in there

Yeah it have, which opens temp-mail website/ another one outlook
I was asking for a default email like gmail from chrome broswer.
And I want to add music/song command

Hello, I created a PR to add two commands!

@virejdasani Hello, I created a pull request to add two commands, can you please review my code? Thank you!

@virejdasani after reading the CONTRIBUTIONS.md I'm going to go ahead and implement a new connect four game into the existing feature suite, will have a PR up tomorrow.

@virejdasani put up a PR adding Connect Four into the code along with unit testing

Hi, this seems like a fun project that I'd like to contribute to! I will work on creating a new feature

I added a new feature for language translation and created a PR. Please take a look

Added a new weather command to fetch and display current weather information for a specific city. Created a PR https://github.com/virejdasani/Alexis/pull/38. Could you please take a look?

Are PR's still being accepted?

https://github.com/virejdasani/Alexis/pull/41

#41

I have #42 ready for review as well

Hi, is this project still being maintained? If so can I contribute to it?


fix: unspecified begin or end params in the datetime will default to now()

NB: There is an edge case where this will blow up with a panic (if begin > end) with the error:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: OutOfRangeError(())', core/src/schema/content/string.rs:276:50
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This is a known issue and should be handled separately as it is a non-trivial change to fix this.
Furthermore, behaviour here will deviate from our number::range generator (that is, high is exclusive and should be strictly bigger than low). However in date_time this makes less sense as there are different increments for different formats (i.e. nanosecond, second, year etc.).
If we are to address this it should happen in another PR.

@christoshadjiaslanis I cannot reproduce the issue you are mentioning on master.
Taking the bank_db example and setting created_at with:
{
    "type": "string",
    "date_time": {
        "format": "%Y-%m-%dT%H:%M:%S%z",
        "begin": "2022-01-01T00:00:00+0000",
        "end": "2021-01-01T00:00:00+0000"
    }
}

I get the error
Error: Unable to open the namespace

Caused by:
    0: at file examples/bank/bank_db/users.json
    1: Failed to parse collection
    2: BadRequest: begin is after end: begin=2022-01-01T00:00:00+0000, end=2021-01-01T00:00:00+0000 at line 76 column 1


Is batch normalization still used in training mode when sampling examples (testing) ?

I see you don't specify the running mode in batch_norm. Is there any reasons? Does this have a big influence in the quality of image generated?

Thanks for pointing out this. Actually I used the default setting of BatchNorm for all my experiments. No further trials indicate if a different running model does bring any influence. Anyway it is an interesting topic that deserves a trial.

Thanks for your reply.
I have tried to split train and test phase, and the images sampled in training mode looks good, but when changed to testing mode (set is_training=False of batch normalization), all the images generated looks very bad， they are just noisy points.


fix(nextjs): Nonce not being populated in Clerk provider and browser script

Description

Fixes a bug where the nonce was not being applied to the Clerk browser script causing CSP errors and failing to load Clerk.
Added an else statement to the ClerkProvider otherwise the nonce was resolving to an empty string. Potentially could be moved to line 32 of of ClerkProvider, but it may cause issues in older versions of Next.
Checklist

[x] npm test runs as expected.
[x] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[x] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Breaks static rendering - won't work.


Serialize a Promise or Observerable for slow resolvers

I'm experimenting with GraphQL wrapping with Amazon's Mechanical Turk (AMT), which is a human driven knowledge service.

Look at this ↑ HCrowd.prompt let us ask five real human where is the best place in NewYork. This is gonna be a slow API behind resolver.
So I'm wondering is there any way to serialize a Promise that resolves to a data, to client side?
Idea:
As https://github.com/apollostack/graphql-server/issues/34 said, GraphQL can update some field asyncly:
Query:
{
  feed {
    stories {
      author { name }
      message
      likeCount @live
    }
  }
}

Initial payload (like normal):
{
  "feed": {
    "stories": [
      {
        "author": { "name": "Lee Byron" },
        "message": "GraphQL est grand!",
        "likeCount": 5
      },
      {
        "author": { "name": "Dan Schafer" },
        "message": "Anyone for lunch?",
        "likeCount": 5
      },
      {
        "author": { "name": "Christopher Chedeau" },
        "message": "React Native est l'avenir",
        "likeCount": 50
      }
    ]
  }
}

Sample update delta:
{
  "path": [ "feed", "stories", 0, "likeCount" ],
  "data": 6
}

And maybe we can serialize a Promise by placing a placeholder before data comes in, which looks likes a json-LD annotation:
{
  "feed": {
    "stories": [
      { "@type" : "$Promise<Object>" }
    ]
  }
}

Thus letting apollo-client wrap that field into a Promise.
I know apollo-client is based on observable, so this will be a bit complicated. But if you think this is interesting, let's discuss more. And I'm glad to try a PR.

hi @linonetwo are you familiar with @live / @stream directives?
sounds to me that this is what you are looking for (They are not available yet)

When will these directives become available?
I've heard about them for quite a time.

@linonetwo this sounds very much like a corner case. I think for the moment your best bet would be a graphql subscription or maybe polling. Definitely not something I would implement with a single GraphQL request. I'd look at this more as a mutation (eg submitting a job to MT) and then checking the status of that job.
I'm going to close this since it's not really an issue with graphql-server, but feel free to continue the discussion, I think it's a very interesting application! 🙂


Fix typo in comment.

It's probably your standard Copy&Paste error.

 You should sign our Contributor License Agreement in order to get your pull request merged.Eimantas Vaičiūnas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account ([for further information, click here] (https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user)).


Unable to view documents properly

Describe the bug
The moment you first open the application it shows a thumbnail of the documents, but after that moment all documents are not seen properly.
To Reproduce
Steps to reproduce the behaviour:

Open the application
Wait for a very short time
Have seen error

Expected behaviour
Upon opening this application, one can browse the files normally
Screenshot and screen recording
https://github.com/deckerst/aves/assets/109811457/8d937aa2-75f6-485d-95b5-ab6569c39deb

System information and logs:
Package: deckers.thibault.aves.libre
Installer: com.android.packageinstaller
Aves version: 1.9.7-libre, build 10802
Flutter: stable 3.13.7
Android version: 12, API 31
Android build: SKQ1.211006.001 test-keys
Device: Xiaomi M2012K11AC
Geocoder: ready
Mobile services: not available
System locales: zh_CN
Storage volumes: /storage/emulated/0/
Storage grants:
Error reporting: false
aves-logs-20231205_210233.txt
Additional information
None

Does it sound like your situation?
https://github.com/deckerst/aves/wiki/FAQ#why-does-aves-show-thumbnails-with-a-broken-image-symbol
In particular, are the files actually on storage or just obsolete items left in the Media Store by misbehaving apps?

Does it sound like your situation? https://github.com/deckerst/aves/wiki/FAQ#why-does-aves-show-thumbnails-with-a-broken-image-symbol
In particular, are the files actually on storage or just obsolete items left in the Media Store by misbehaving apps?

After clearing all the data and restarting the application, it can be used normally, but I still do not know why I could not view the files properly at the beginning.