Multi-Version CRs support

Context
All ACK controllers start out with an Alpha API version (v1alpha1) that evolves from release to release, most likely due to updates in aws/aws-sdk-go OpenAPI Schemas or because of changes in the generator.yaml (ignored fields, renamed fields, field made secrets etc...)
Eventually most of these APIs will need to move to a more stable API ( v1beta1, v1beta2... v1...) and restricted from making breaking changes to it.
However to simplify ACK users experience when dealing with controllers/CRDs upgrades we need to keep support for multiple API versions (if not all of them) and gradually deprecate old versions when needed (see kubernetes deprecation policy)
Implementation details:
Changes to ack/code-generator

[x] ack-generate should be able to generate API definitions for different ApiVersions (currently supported with --api-version flag)
[x] ack-generate apis should save a copy of generator.yaml within the ApiVersions directory (apis/v*/)
[x] ack-generate should save the parameters used to generate a specific ApiVersion (aws-sdk-go, ack--generate versions, ENV Vars, etc ...) see #809
[x] controller flags should allow to enable webhook server and set it's host and port
[x] runtime should contain a package to systematize webhook registration and listing
[x] ack-generate controller should generate code that registers conversion webhooks on controller startup (probably done in main.go) https://github.com/aws-controllers-k8s/code-generator/pull/111
[x] ack-generate should start using gogit to load/checkout aws-sdk-go specific versions https://github.com/aws-controllers-k8s/code-generator/pull/108
[ ] ack-generate controller should generate conversion functions by loading all aws-sdk-go version schemas and their related generator.yaml and computing the CRD "type diffs"
[ ] Change the scripts/build-controller.sh to call controller-gen with specific arguments when dealing with multiple versions
[ ] Change the scripts/release-controller.sh to include the new CRD Schemas and optionally create a CA (Certificate Authority) service

Documentation:

[ ] Document how code generation works for multiple version works (conversion functions, webhooks, Auth/CA service)
[ ] Document how does a controller support two or more API versions (data flow description + diagram)
[ ] Document the required steps from K8s cluster administrators to setup multi-version ACK controllers

/cc @aws-controllers-k8s/code-generator-maintainer @aws-controllers-k8s/runtime-maintainer @aws-controllers-k8s/community-maintainers

we need to keep support for multiple API versions

Would you mind clarifying what the Kubernetes definition of "support for" means in this context? Is it simply that we are able to convert to/from them, or are there stronger definitions about their usage?

ack-generate should start using gogit to load/checkout aws-sdk-go specific versions

Is this related to versioning, or just an aside?

create a CA (Certificate Authority) service

What purpose does a CA serve for CRDs?
Is there also some way we can ensure we do not modify a previous version of a released CRD? That is, if we've released v1alpha2 we must somehow lock v1alpha1 to a given version.

Would you mind clarifying what the Kubernetes definition of "support for" means in this context? Is it simply that we are able to convert to/from them, or are there stronger definitions about their usage?

Yes, simply that we will be able to convert to/from them, by always regenerating conversion functions whenever there is a CR version bump (latest version is always the "Hub" version)

Is this related to versioning, or just an aside?

Not directly related to versioning. It's gonna simplify the way we load AWS API Specifications from aws-sdk-go

What purpose does a CA serve for CRDs?

The CA will issue certificates to ensure secure communication between the kube-apiserver and a given ACK controller. The webhook server will be running within the service controller (https://github.com/kubernetes-sigs/controller-runtime/blob/master/alias.go#L103-L104)

Is there also some way we can ensure we do not modify a previous version of a released CRD?

We can do that by saving an output file containing the files checksum whenever we regenerate an API version. However conversion functions will always change whenever we update/create a new API version - so maybe we can just exclude the conversion functions when computing the checksum ?

/remove-lifecycle stale

@A-Hilaly If I understand correctly, the apiVersion is specified per-group, right? Not per-CRD? In Crossplane, we go for per-CRD to comply with Kubernetes and also CRDs in the same group usually don't have the same maturity level. Do you see that case arising in ACK as well or do you consider the whole group as a unit that will be versioned together?

/remove-lifecycle stale


Improve docs on SOCIAL_AUTH_NEW_USER_REDIRECT_URL

The behavior change documented in https://github.com/omab/python-social-auth/issues/276 may not be what users expect, especially those migrating from django social auth. This PR better documents the new user redirect behavior.

Thanks!


Fail to open train.prototxt

It worked well for solver.prototxt, but the sublime broke down when I tried to open a train.protxt or val.prototxt, any idea about it?
I was on ubuntu 16.04, sublime text 3.

Could you share your train.prototxt and val.prototxt?

My sublime text3 on macOS consumes a lot CPU usage after installed this package, and I found that ST will freeze for a while when opening prototxt files, especially large ones.
I guess maybe there are performance issues with the package running on ST3?

@wujiyoung Could you share your prototxt?
@edingroot I don't have large size prototxt, If you have one, could you share yours?

Here is my prototxt file.
https://raw.githubusercontent.com/shelhamer/fcn.berkeleyvision.org/master/voc-fcn32s/train.prototxt

@wujiyoung wow, my laptop has same issue. Thank you for reporting. I will fix it asap.

@zironycho Thank you, and I am expecting good news from you.

@zironycho I was editing prototxt like this: https://github.com/torrvision/crfasrnn/blob/master/python-scripts/TVG_CRFRNN_COCO_VOC.prototxt
Thank you, looking forward to use this great plugin!

@edingroot thank you for using it.

@wujiyoung @edingroot
Thank you for issue reporting.
The new version(1.1.0) is updated  in sublime package control.


Fix multiple api calls on route change

References

Fixes #2482

Description
The issue was caused by the fact that the guard made a new request to the api every time something subscribed to the result of its canActivateChild method. That happened more then once per route change
The solution was to use the cached /api response, and invalidate that cache on every NavigationStart event. That way, the first subscriber triggers the re-request, and all the others use the cached version.
Instructions for Reviewers
Open the network tab in the browser's dev tools, and check that there's one a single /api request every time you change the route
Also verify that if the backend becomes unavailable, that you're redirected to the 500 error page the next time you change the route
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes ESLint validation using yarn lint
[x] My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[x] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
[x] If my PR fixes an issue ticket, I've linked them together.

Thanks @artlowel! I tested the patch by opening the network tab of my browser dev tools and clearing it before navigating to another route. Before applying I would see two requests to /api. After applying I only see one request to /api.
Also, as suggested, I stopped Tomcat and then the next time I tried to navigate to a new route I received the HTTP 500 error page.
So on functionality this looks good to me. I will let someone else who is better with Angular review the code.

@alanorth I can reproduce your issue only when the backend is down. It makes sense that you can't log in when the backend is down. After it is back up, logging in works again for me.
I did however discover an bug where the login dropdown goes blank if you enter the wrong account details. But I can reproduce that on both https://demo.dspace.org/ and on https://sandbox.dspace.org/, so it's not related to this PR. I created an issue for it: https://github.com/DSpace/dspace-angular/issues/2515

@artlowel I just tried again, and my backend is definitely up because I can browse everywhere in the repository, but my login dropdown is white. Shift refresh, nothing. See quick demo:
https://github.com/DSpace/dspace-angular/assets/191754/2da6a327-d063-422a-a4f8-bb09c89d36af
Another thing I noticed is that some browse pages actually make THREE calls to /api! Check "Browse by Issue Date" for example. With this patch they only make one. So that's a win.

@artlowel if I revert the patch the white login dropdown issue goes away. Also note, in my video above, that I have not attempted login at all, so I'm not sure that bug is related to a failed login.

@alanorth then that must mean that https://github.com/DSpace/dspace-angular/issues/2515 also happens for other errors, besides a failed login.
Can you check your console when the blank dropdown issue happens. Is undefined doesn't contain the link authn still the error shown? The reason I ask is because that error tends to mean that /api can't be retrieved (as authn is a link on /api) and in your video we see that it can be retrieved

@artlowel yes, it is reliable. Right after applying the patch, Angular rebuilds, the page refreshed, and I get errors in the console. Three messages about missing links (one for authn, two for properties):

@alanorth I'm able to reproduce your issue now. It happens only in dev mode. I'll take a look

Just to quickly note that I get the same errors. Running in development mode with sandbox as API.
I don't know if it's an issue but the CanActivateChild interface used in server-check.guard.ts  is deprecated in favour of "functional injectable guards". Is this a concern? (I have no idea)
I put in some console.traces() and seems to me that a lot of services and functionality want to know how server/api is doing.

@J4bbi

I don't know if it's an issue but the CanActivateChild interface used in server-check.guard.ts is deprecated in favour of "functional injectable guards". Is this a concern? (I have no idea)

It looks like CanActivate itself is also deprecated, which means that eventually we'll need to update all our guards. I think this is something that is best done all at once, e.g. in the context of the next angular upgrade

Hey @artlowel. I tested again with the updated patch and I am able to log in. I also confirm that the calls to /api are still reduced to one as expected. I think I'm +1, but can wait for @J4bbi to comment as well.

Merging this as it has been tested by myself and @J4bbi, with our review feedback addressed.
I think if we want to add a comment about the six hours you can add that later and we can merge it without testing all that.

@J4bbi

@artlowel , great. I just wonder, because that number seems somewhat arbitrary, if it's possible to leave a comment to explain why it's 6 hours and not something else, or if there is something dependent on it being at least a specific value?

It doesn't have to be any specific value no. The original idea was that it should basically never expire because all the /api endpoint was used for was to retrieve the links to all other endpoints, and those only change if major new features are added to dspace. So 6 hours was chosen as just "a long time".
With the introduction of the ServerCheckGuard, that this PR makes some tweaks to, that endpoint is used to check that the server is still running as well. So in practice those 6 hours will never be reached, because the timer will restart every time you switch routes. The reason I still rolled back the change though, is because I don't want to introduce issues where the validity expires while you're on a page and not doing anything. In theory, if everything else is properly designed to use dataservices and work with the cache that shouldn't be a problem, it would just cause /api to be re-requested automatically when that time is up. But I'd rather not risk introducing new edge cases that haven't been tested for

@artlowel the automatic port to main failed. Would you be able to port it manually and make a PR? Assuming all tests pass we can merge it ASAP. Thanks!


add tests for finalize entry button when editing, creating new, and going back from staging view

Tested extensively for time units


Add load_from_uri for dataset

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6c1a4dc) to head (f7d024c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           54        55    +1
  Lines         1114      1130   +16
  Branches        84        85    +1
=========================================
+ Hits          1114      1130   +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix forced unlocking

Force unlocking was not working after the bsp refactoring. This PR fixes force unlocking in state B. Force unlocking in state C is not supported.

Thanks for addressing this issue. We also noticed this on Tarragon, but thought this was an issue in our BSP implementation.
Nevertheless i like to leave some comment regarding the implementation. From our understanding this command is the last resort for the EV driver who isn't able to get his cable back. So "force" should be considered as almost "unconditional", which from our understanding means always unlock the plug lock no matter what the CP state says. Since we cannot trust the mechanics of the plug lock and its sensors. The only exception should be that the EVSE contactor is closed.
In case this change is to big for this regression, i can open a new issue here.

It is just a one line change to support state C as well. Agreed that probably it is better to only forbid a force_unlock if the relais are closed as state C is beyond our control on the EVSE side.

Now force_unlock remains active until it is "normally" unlocked because state A/E/F is reached. Unlocking happens whenever relais are open and it is either force_unlocked or normally unlocked. It needs some testing still.

I will try to discuss this within our team so we can test this soon.

Tested on one HW now


Make updating the state independent of the tx generator

If we slow down the tx generator, or we disable it, Faucet will no longer
update its state, and will eventually run out of UTXOs.

Tested live, works.


Use security compiler flags for ResinOS

To harden ResinOS we should use the yocto security compiler flags (https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/conf/distro/include/security_flags.inc).
FD: https://www.flowdock.com/app/rulemotion/r-security/threads/ZXIGjUS1p-jgJ7bSXcUSIb-CaIc

See #845


In app.module place the app.component import last

In order to make it easier to cut and paste component imports in the router module, Instead of:
import { AppRoutingModule } from './app-routing.module';
import { AppComponent } from './app.component';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { StepperComponent } from './stepper/stepper.component';

Do
import { AppRoutingModule } from './app-routing.module';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { StepperComponent } from './stepper/stepper.component';
import { AppComponent } from './app.component';

I think that makes sense. I'd even move the non-local imports all the way to the top.
Would you like to implement this change?

@filipesilva Hello, What are trying to solve here? In the original issue only app.component is mentioned. Are we trying to move all non-local imports to top?

@krishnaanaril yes, that is the idea. The way we add these imports is by reading the source file AST and inserting new imports in the appropriate place. So the algorithm we use to do that would need to handle local/non-local better.
I'm still not sure in what situations this occurs so it's also important to isolate the problematic insertions.

Is anyone working on this?

I have not encountered this being an issue with other developers. Am I reading this right that this to to make copy/paste easier?

Hi - Sorry for the late reply - Just saw the other comments now.
After having done a few more project I've started to always just delete the routing module and place the routes directly into the app module.
This is easier because the app module has to have all the components for declaration anyways, so it's just easier to define the routes there too.
I wonder if creating a separate routing module should be an option on the new command, so that users that want that get that, otherwise the routing will just be generated right into the app.module?

--------answer
yes you can do it by using the command as -ng new  --routing
->it will create a new project with a separate routing module
I hope that this was your problem, if not then sorry i am just new to github community

--------answer
yes you can do it by using the command as -ng new --routing
->it will create a new project with a separate routing module
I hope that this was your problem, if not then sorry i am just new to github community

it is ng new  --routing
i don't now how it got removed from my comment

--------answer
yes you can do it by using the command as -ng new --routing
->it will create a new project with a separate routing module
I hope that this was your problem, if not then sorry i am just new to github community
it is ng new project_name --routing
i dont now how it got removed from my comment

As a new contributor, it seems to be a good point to start with.
I gave it a try and the first thing was to figure out which schematic is responsible for the app.module file generation. I found out that it's the application scematic, and generates the app.module based on this template.
If my findings are correct, then it seems that this issue has already been resolved.

As a new contributor, it seems to be a good point to start with.
I gave it a try and the first thing was to figure out which schematic is responsible for the app.module file generation. I found out that it's the application scematic, and generates the app.module based on this template.
If my findings are correct, then it seems that this issue has already been resolved.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.

Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.


dark mode

add dark mode
use this: #22212C,#454158,#9580FF,#22212C,#454158,#FFFFFF,#8AFF80,#FF5555

?

The web assets for HF are all white background black text; it is bad for the environment and the eyes for many people. I suggest using the above colour scheme (Dracula) to implement night-mode

we do have a dark mode, have you tried it? (you might need to create an account to toggle it)

if by default it honours your system setting (when logged out), would that fit your use case?

That would be awesome!

Dark and system themes are now available everywhere. Enjoy


Refine pipeline load

Idea:

when checkpoint to load is set in pipeline or passed as --load param "distribute it" to all models in the pipeline (as model's self.config.add_default_param({"load" : xxx })
That would enable conditional initialization e.g. of WordEmbeddings - why to load vectors as they are going to be "overwritten" in the following load()

Current "fix" - when pipeline name to load is passed as --load, both workers are not trying to load models using "self.pipeline.load_models()" (else clause)
        # Try to load the model.
        if pipeline_name != "":
            if path.isfile(pipeline_name):
                # Load parameters from checkpoint.
                self.pipeline.load(pipeline_name)
            else:
                raise Exception("Couldn't load the checkpoint {} indicated in the {}: file does not exist".format(pipeline_name, msg))
            # If we succeeded, we do not want to load the models from the file anymore!
        else:
            # Try to load the models parameters - one by one, if set so in the configuration file.
            self.pipeline.load_models()


Normalized l2-dissimilarity

Hi I'm trying to reproduce your experiment but while I was trying to evaluate FGSM attacks under white box settings, I found that the normalized l2-dissimilarity for a FGSM at eps=0.1 is only about 0.007. As in your code, the upper bound for an white-box attack is determined by some pre-generated adversarial examples. I'm wondering how you guys finish the experiments as in Fig. 7 in your paper?

Hi Scott,
Thanks for having an interest in our work.
Our approach is an ensemble model that was built upon many weak defenses (WD), it first collects predictions from all WDs then finds the final label for given input using some strategy. In the context of whitebox threat model, the attacker knows everything regarding the model (Section IV.C) and wants to generate adversarial examples (AE) that fool as many WDs as possible, one possible approach is by introducing adversarial perturbations based on various WDs into one AE.
To do so, we use a greedy approach to add perturbations based on multiple WDs into one AE (Algorithm 1). This algorithm has two constraints N (the number of WDs based on which we generate the adversarial perturbations, for a whitebox threat model of a Majority-Voting ensemble, $N=#_of_WDs \times 0.9$.) and max_dissimilarity (the maximum l2-dissimilarity of each generated AE, in our study, we ).

Hi Meng,
Thanks for reply. As indicated in your code (/src/evaluation/eval_whitebox.py, line 291), it seems that the max_dissimilarity is set as the normalized l2 norm between benign samples and adversarial examples generated by FGSM attack at eps=0.1. According to my experiement, the normalized frobenius norm of them should be as small as 0.01. Just wonder do i need to adjust the max_perturb argument in line 291 as 0.1~1.0 during experiments?
Thanks

For each set of AE, it is a value passed via parameter max_dissimilarity.

Oh understood. Thanks!


Document thread-safety of library

After reading through the docs, it is unclear to me whether I should expect this code to work:
from google.cloud import storage
import thread

client = storage.Client()
for blob in bucket.list_blobs():
  thread.start_new_thread( blob.download_to_filename, '/tmp/' + blob.name)

google-cloud-storage has been based on requests since #3674, released with google-cloud-storage 1.3.0 just about a year ago.
I'm leaving this open as a docs bug so that we add a note to that effect.

Sorry, you last me. Does being based on requests imply that google-cloud-storage is thread-safe, and the code example above should work fine?

Yes to both questions.

@BrandonY Here is the text I am planning to add to the client page:
.. note::

   Becuase the :class:`~google.cloud.storage.client.Client` uses the
   third-party :mod:`requests` library by default, it should be safe to
   share instances across threads.  In multiprocessing scenarious, best
   practice is to create client instances *after*
   :class:`multiprocessing.Pool` or :class:`multiprocessing.Process` invokes
   :func:`os.fork`.

Does that address your need?

@BrandonY Please follow up via #5763, if needed.


Update asset-guidelines.rst

Thanks @john-combs for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Really sorry for the delay in this, guys! :) CLA resubmitted.

Thanks John, all good to merge now.


Icons don't warn about Win10 not supported

Which version of the app?
WinUI 3 Gallery
Description
On the Iconography page it's too easy to go pick an icon glyph and add it to your app, not realizing it won't work on Windows 10. For instance the following will render a square placeholder on Windows 10:
<FontIcon Glyph="" />

However this will render fine:
<FontIcon Glyph="" />

With so many users still on Win10, it needs to be made easier to avoid making such mistakes, since it can get caught too late in the dev process if the developers are using Win11 machines.
Screenshots
No indication that this isn't supported on Windows 10:

This one right next to it though is supported on Windows 10:

Windows version
Windows 10 22H2 (19045)
Additional context
No response

Thats a good point, would you expect there just to be a "Windows 10" disclaimer or also depending on the Windows build when it was available?

It's called out in the Expander.
But I agree, it doesn't jump out.
Maybe we could add an InfoBar at the top calling this out and warning folks that some icons might not render at all and testing is required?

That message isn’t helpful. Many of the icons do work on Win10 but not all

Interesting. I wasn't aware some icons wouldn't be available in the MDL2 font. I wonder how many of them are missing. In my opinion, I think the code area (for the specific icon)would be the most appropriate place.

If they are on this page they are supported: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font
If they are on this page, Windows 11 is required: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

If they are on this page they are supported: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font
If they are on this page, Windows 11 is required: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

Technically, it's not about the OS, but a matter if the Fluent font is installed. Important difference.

As you said: Technically. In practice though it'll catch developers out.

Yes, there is a clear correlation between the two. But when the Fluent font is installed on Windows 10 (which is super easy) a message calling out the OS would be invalid. Just trying to keep it accurate.

But when the Fluent font is installed on Windows 10 (which is super easy)

Define "super easy". You shouldn't be expecting your users to be doing this. If anything you should include it in your app, but it's still worth pointing out that there's something you need to do and be aware of if you want to use those symbols on Windows 10.

If I may suggest:

[!IMPORTANT]
This icon is not available in the MDL2 font, the default icon font on Windows 10, and thus may not be rendered.

Define "super easy"

It's literally as simple as installing the font. The OS will pick it up automatically 🙂 But indeed, this is not so common.

No you don’t just do that. You need to build an app installer that does this. That’s not “super easy”. Again apps shouldn’t require people to do this themselves just to use the app. And that still doesn’t change the fact that someone needs to know they need to ensure this font is available. If it’s not installed all you get is a place holder icon and a poor app experience

Wait. My comments were based on old ideas. Back when Project Reunion wasn't renamed yet, there was a font (file) that basically acted as MDL2v2. I once installed it and, because of the same internal name, Windows 10 picked it up as the System Icon font. But that's long ago and will not work nowadays. Apologies. 🙇🏻♂

Like, what even is this?

@HO-COOH to answer your question: Windows 10 default icon font is MDL2. This font has some less icons than the newer Fluent Icons font, which is default for Windows 11. So, as I said earlier, the app says these icons are available in the Fluent font, so technically there's no blame. It would be a courtesy to add a note, for developers building apps that can be run on Windows 10.

Definitely, this should have a warning.


Fix a typo in README.md

Changed 'comand' to 'command'

Thanks! Spotted it in a couple of other places too:
https://github.com/simonw/shot-scraper/blob/fb64010771ff0753fc387923ac09b34e842c4760/setup.py#L17
https://github.com/simonw/shot-scraper/blob/fb64010771ff0753fc387923ac09b34e842c4760/README.md?plain=1#L8


Capture build scans on ge.apache.org to benefit from deep build insights

This PR adds a new auto-plugin that configures publishing of a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
All projects in the Pekko ecosystem will benefit from build insights once this PR is accepted and a new version of sbt-pekko-build plugin is applied.
The build scans of the Apache Pekko projects are published to the Develocity instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Develocity instance has all features and extensions enabled and is freely available for use by the Apache Pekko projects and all other Apache projects.
On this Develocity instance, Apache Pekko will have access not only to all of the published build scans but other aggregate data features such as:

Dashboards to view all historical build scans, along with performance trends over time
Build failure analytics for enhanced investigation and diagnosis of build failures
Test failure analytics to better understand trends and causes around slow, failing, and flaky tests

If interested in exploring a fully populated Develocity instance, please explore the builds already connected to ge.apache.org, the Spring project’s instance, or any number of other OSS projects for which we sponsor instances of Develocity.
Please let me know if there are any questions about the value of Develocity or the changes in this pull request and I’d be happy to address them.

Thanks @c00ler - I can apply when this is ready. I have just one minor not with the README change.
In the next few weeks, I intend to bring this repo into the apache/pekko project.

Thanks @c00ler - I can apply when this is ready. I have just one minor not with the README change.
In the next few weeks, I intend to bring this repo into the apache/pekko project.

@c00ler do you have an Apache iCLA?
https://www.apache.org/licenses/contributor-agreements.html
Or would your employer have a cCLA?

Thanks @c00ler - I can apply when this is ready. I have just one minor not with the README change.
In the next few weeks, I intend to bring this repo into the apache/pekko project.

@c00ler do you have an Apache iCLA?
https://www.apache.org/licenses/contributor-agreements.html
Or would your employer have a cCLA?

Let me clarify this question and I will get back to you.

I'm not enthusiastic about using this tool. I'm unlikely to merge this.

I'm not enthusiastic about using this tool.

So I think you have an incorrect impression of where the tool is being used, as its currently used in numerous ASF projects (its not just Pekko where its being put into, see https://gradle.com/blog/apache-software-foundation-standardizes-on-gradle-develocity-to-improve-developer-productivity-experience/). This is not dissimilar to tools like confluence or github, which are closed source and have partnerships with ASF where they host instances for us.
Also do note that this tool was actually used to diagnose sbt build times and make improvements in the pekko build, see https://github.com/apache/pekko/pull/1125.
I would advice that we be more cordial in accepting this, if there are problems we can always disable/report it but thats very different to just outright saying no without trying it.

I'm unlikely to merge this.

Then it would be submitted to one of the Pekko modules proper, bringing us to the second point which is that this repo should be moved into ASF org asap because this kind of gatekeeping for something that is a critical part of Pekko builds is not following the spirit/ethos of ASF, or to put it differently, we are bypassing community consensus.
I understand the context as to why this was put under a personal org due to the difficulties of incubator, but this is now behind us.

It will be more productive to guinea pig this in one of the Apache Pekko projects directly and when it works well there, we can move the code to this sbt plugin or its planned Apache Pekko equivalent. There is a discussion already open on Pekko dev mailing list about moving this repo. This repo will probably only be moved after the sbt-apache-sonatype plugin that it depends on is moved and released.

I logged https://issues.apache.org/jira/browse/INFRA-25735

It will be more productive to guinea pig this in one of the Apache Pekko projects directly and when it works well there, we can move the code to this sbt plugin or its planned Apache Pekko equivalent. There is a discussion already open on Pekko dev mailing list about moving this repo. This repo will probably only be moved after the sbt-apache-sonatype plugin that it depends on is moved and released.

This is reasonable, @c00ler do you mind doing relevant changes in pekko core and we can keep this PR open?

It will be more productive to guinea pig this in one of the Apache Pekko projects directly and when it works well there, we can move the code to this sbt plugin or its planned Apache Pekko equivalent. There is a discussion already open on Pekko dev mailing list about moving this repo. This repo will probably only be moved after the sbt-apache-sonatype plugin that it depends on is moved and released.

This is reasonable, @c00ler do you mind doing relevant changes in pekko core and we can keep this PR open?

@mdedetrich Of course, no problem. Lets' start by integrating only with pekko core. I will prepare the PR.


Implement reading of carbon parameters in 5.0 image driver

Carbon parameters from the veg_lib file are not currently read in.

closed via #391.


Use clearer input syntax for hexagonal lattice pitch

What is the change?

Add an option for a user to specify a hexagonal pitch directly:

latticePitch: {hex: 1.5}

~2. Additionally, a bug in the grids.hexagonal.HexGrid.pitch property was corrected. Previously, it was incorrect for "corners up" grids (low by a factor of sqrt(3)/2).~
Why is the change being made?

Previously, a user had to specify the triangular pitch using the x attribute of latticePitch, which is confusing because the pitch is not necessarily equal to the x distance between two neighbors in a hex grid.

latticePitch: {x: 1.5}

~2. The grids.hexagonal.HexGrid.pitch property was defined in a manner that was only correct for "flats up" hexagonal grids. It was wrong for a "corners up" grid.~
https://github.com/terrapower/armi/blob/main/armi/reactor/grids/hexagonal.py#L152-L161

~Fix 1284~ (fix for this issue pulled into a different PR, #1649)
Partially related to #252

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[ ] The release notes have been updated if necessary.
[ ] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

I'm just thinking aloud here, but what something "flat-to-flat" be better for hex grids?
Isn't the goal to call out that we are going to be explicitly picking one over the other?

I'm just thinking aloud here, but what something "flat-to-flat" be better for hex grids?
Isn't the goal to call out that we are going to be explicitly picking one over the other?

I'm not sure I understand what you are proposing. Do you mean specifying the pitch/flat-to-flat distance as flat-to-flat in the blueprints instead of latticePitch? I think latticePitch is still a fine descriptor of that parameter for a hexagonal lattice. And this allows us to not break any backwards compatibility with existing blueprints files, which would be an enormous pain.

The bug fix was pulled out of this PR and into #1649
The remaining part of this PR is an optional/nice-to-have feature. It's just allowing users to define the hex pitch in blueprints in a slightly different way than before. No rush to push this through now, really.

The unit tests broke after my PR merged. Sorry!

The unit tests broke after my PR merged. Sorry!

No worries! I just have to pull out what was moved over to #1649 and I think it will work.

@mgjarrett Forgive me, I have totally lost where this PR was at. When you think it is ready for review, take it out of Draft mode.

I think the PR is ready. For context, I was trying to address the issue that Drew and Mitch were discussing 3 years ago over on this issue #252:

I had unintentionally added some files that were sitting around in my git directory to this PR. These files have been removed, so this PR is now ready.


feat: Pass user_id if available to popular tables endpoint

Signed-off-by: Josh Howard<EMAIL_ADDRESS>
Summary of Changes
Minor frontend service changes to be compatible with this PR. The idea is to pass the current authenticated user id to the metadata service to optionally customize the popular tables response.
Tests
Minor test updates to mock the popular tables endpoint w/ the authenticated user.
CheckList
Make sure you have checked all steps below to ensure a timely review.

[-] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[-] PR includes a summary of changes, including screenshots of any UI changes.
[-] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[-] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[-] PR passes all tests documented in the developer guide

Closed to address comments in this PR.


The 'meta' specified in the @Composite is not passed on to the sub constraints.

The meta value specified at the controller on a Composite constraint
    @Composite(value = "isDevAndOwner", meta = "skip")
    public Result updateResource(String installationId) { /* ... */ }

is not available to the dynamic constraint (DynamicResourceHandler) which is sub constraint of the composite constraint:
// ...
    @Inject
    public CompositeConstraints(final CompositeCache compositeCache, final ConstraintBuilders builders) {
        final Constraint isDevAndOwner = new ConstraintTree(
                Operator.AND,
                builders.restrict(builders.anyOf(builders.allOf(ROLE_DEVELOPER))).build(),
                builders.dynamic("isResourceOwner").build()
        );
// ...

public class IsResourceOwner implements DynamicResourceHandler {

    @Override
    public CompletionStage<Boolean> isAllowed(String name, Optional<String> meta, DeadboltHandler deadboltHandler, Http.Context context) {
            return CompletableFuture.supplyAsync(() -> meta.isPresent()); // always false!
    }

// ...
}

Do let me know what other details you require or if I am doing something wrong.

This is a bug.  I'll fix it and release 2.5.4 asap.

Thanks @schaloner for the quick response. Could you please let me know when I can expect 2.5.4 release? Just want to know if it would be in a couple of days or longer so that I can plan on using an alternative to Composite constraints or hold on to it while the bug is fixed. Thanks again.

It should be released within the next 12 hours.

Awesome! :raised_hands: Thanks again! :smile:

This is released as 2.5.4.
There's also a new property on Composite that instructs on preferred metadata.
If set to true, the metadata defined in the Composite annotation is given priority over metadata defined directly on the constraint.  So, if you have a constraint tree that contains three Dynamic constraints that may have a metadata value defined (let's say Some("a"), None and Some("c")) but want these metadata to be replaced with the metadata defined in @Composite(value = "isDevAndOwner", meta = "skip") when evaluating, change the annotation to @Composite(value = "isDevAndOwner", meta = "skip", preferGlobalMeta = true).
If you only want this global value to be used if there isn't metadata in the individual , set it to false.  For the case described above, the first constraint would use Some("a"), the second would get Some("skip") from the Composite annotation and the third would get Some("c").
By default, this value is false, giving priority to per-constraint metadata.

Thanks @schaloner. I downloading 2.5.4 now. Will test and update you in sometime.

This is working for me. I'll close it. Thanks.


roi window basic

add roi window
sample code is added to main window to describe the usages of the roi window

When the viewDataFrame button is clicked, it will pop up new window.
In the window, you can find three buttons.
RESET: reset any rotation or translation changes
ZOOM/PAN: allow users to zoom in/out and pan the image. for zooming, use mouse scroll and for panning using left button of mouse with dragging
ROI: allow users to draw a roi. use left mouse button to draw and right mouse button will delete the roi
Additionally, four spin boxes are used to show numbers related to the ROI drawn.
The first two are for x and y coordinate of the ROI and the others are for width and height of the ROI.
Any changes in the spin boxes or direct drawing will update each other.
To get the changes from the MainWindow, one can connect roi_changed signal into a slot.
Currently, the signal is connected _get_roi_slot function in the MainWindow and print out ROI for future usages.

@bsmind  Thanks a lot for the message. Let me take over from here. Stay tuned.


Properly validate IVs

As how  low priority as it sounds due to how inviable hidden power fighting is, due to the Mechanics of obtaining legends in game from X/Y/ORAS hidden power fighting should not be legal on some pokemon, thus effectivily making it an illegal combo.
Xerneas, Yveltal, Zygarde, Diancie, Darkrai + phantom force Jirachi + moonblast, Celebi +hold back (from the events) must have at least 3 31ivs when obtained in game and they are always produced with at least these number of IVS. The best hidden fighting combo 31/31/30/30/30/30 is unobtainable on these pokemon through normal gameplay and therefore should be considered illegal on the simulator.

So correct me if I'm wrong, but a mon with fewer than 3 perfect IVs must be either gen-5-or-earlier or not be in the Undiscovered egg group? Does that adequately describe the conditions for this?

As I said in ae9363ae906ac1215d597bd805a2728423b4acd0, Undiscovered egg group Pokemon caught in the wild in gen 6 must have at least 3 perfect IVs.
So, yes, your conditions are correct. But I'd add the word "caught" to it: must be caught either gen-5-or-earlier.

I just checked a Happiny and a few Unown caught in Mirage Spots, and they have one or zero perfect IVs. ORAS seems to have done away with the non-legendary portion of the Undiscovered egg group having 3 guaranteed perfect IVs, presumably because the DexNav exists.

Oh...

That's GF for you, never consistent.

Okay, so we need to start explicitly flagging legendaries now?


Don't validate dose_sequence if not administered

A vaccine that isn't administered doesn't have a batch, which means it doesn't have a vaccine. Without the vaccine, maximum_dose_sequence defaults to 1. If the dose_sequence is > 1, this breaks the validation.
We can also remove the vaccine& || 1 default with this change.

I’m wondering if it makes sense to store a dose sequence on not administered vaccinations, but this fix sounds good for now.

We had the same thought, but dose sequence is currently a non-nullable field in the DB and removing that restriction would be a bigger incision.


feat(style): disable id-length rule

Hey 👋
This pull request resolves issue #17

I run npm i on my machine with a node 16.LTS version and it changed the lock file.


Add UI enum property for message verbosity level when rendering with appleseed.cli

Do we still want to implement this?

Possibly, but it's very low priority.

#313


"Run the Application" - "dotnet ef database update" fails

The command "dotnet ef database update" fails with the messages show below.  I can skip the step and run the app, but when I try to open localhost:5000 I get the error "Microsoft.Data.Sqlite.SqliteException (0x80004005): SQLite Error 1: 'no such table: Todo'."
I'm running dotnet version 3.1.101.  The dotnet help shows no commands ef, database, or update.
===================================
dotnet ef database update
Could not execute because the specified command or file was not found.
Possible reasons for this include:

You misspelled a built-in dotnet command.
You intended to execute a .NET Core program, but dotnet-ef does not exist.
You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 00961883-36eb-f736-b906-73d4c35e69b0
Version Independent ID: 3a2fd493-9682-eedf-fad1-571b9391cd46
Content: Tutorial: ASP.NET Core with SQL Database - Azure App Service
Content Source: articles/app-service/app-service-web-tutorial-dotnetcore-sqldb.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@KenBrady Thanks for the feedback! We are currently investigating and will update you shortly.

@KenBrady Thanks for asking question! You may try solution and refer to similar thread might be helpful: My contribution to this document when the command is executed: dotnet ef database update

Thanks for the reply.  I was able to get this working with the following commands:
dotnet tool install -g dotnet-ef --version 3.1.1
dotnet-ef database update

Note that the first command must provide the version because the latest dotnet-ef version is 3.2, and there is no dotnet version 3.2.
The dash in "dotnet-ef" is absent from the tutorial webpage.

I would suggest the following updates to the tutorial web page:

Include step 1 in the instructions.
Supply the missing dash of step 2.

Thanks again -
Ken Brady

@KenBrady Thanks for the feedback! I have created PR for this and it will be visible soon.


Support CI for Windows and MacOS

Description
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe.
Issues Resolved

Related https://github.com/opensearch-project/security-dashboards-plugin/issues/845
Related https://github.com/opensearch-project/security-dashboards-plugin/issues/1156

Note: follow up pull request will convert the integration test job to be multi-platform
Check List

[X] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1164 (c71fe93) into main (7c8ede6) will decrease coverage by 1.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
- Coverage   73.90%   72.07%   -1.84%
==========================================
  Files          86       88       +2
  Lines        1901     1959      +58
  Branches      251      258       +7
==========================================
+ Hits         1405     1412       +7
- Misses        439      490      +51
  Partials       57       57

Impacted Files
Coverage Δ

...s/configuration/panels/role-view/tenants-panel.tsx

...panels/auth-view/authentication-sequence-panel.tsx

...ublic/apps/configuration/utils/auth-view-utils.tsx

...hboards-plugin/public/apps/account/account-app.tsx

...ublic/apps/configuration/utils/combo-box-utils.tsx

...-dashboards-plugin/public/apps/login/login-app.tsx

...n/public/apps/configuration/utils/request-utils.ts

.../public/apps/configuration/utils/display-utils.tsx

...n/panels/internal-user-edit/backend-role-panel.tsx

...-plugin/public/apps/account/account-nav-button.tsx

... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied Looks like we have to modify the required checks similar to what @cliu123 did for this PR: https://github.com/opensearch-project/security/pull/2161#issuecomment-1294205866

FYI The backport to 2.x https://github.com/opensearch-project/security-dashboards-plugin/pull/1167


F-Droid

Please consider submitting your app to F-Droid. :)

Sorry, but this is not an Android app.

Oh, sorry. Looked like one here: https://www.reddit.com/r/amateurradio/comments/qvcx64/glad_to_see_that_my_open_source_cofdmtv_stuff/
This repo was linked and also Play Store. :)


Fix player sorting based on jersey number

https://github.com/Tristandemuijnck/ultitv-api-svelte/commit/8b02e8ce3867568acc46924128522369c02982cc
Added sorting options for several endpoints


Custom Field - Give Reminder date with Note option on different Objects

Problem-
When user works on any object like Company, Contact , Project Custom Field Page
they usually call Client and try to take data from Clients.
Some times clients says please call after 5 days etc
So User get confuse that what need attention and what's already done
Solution-

Provide Option to give reminder Date with Note on each Page
Adding Column for Reminder on main list. to sort accordingly
Default sort order will be Reminder Date
This is not related to any other module
Log for no of attempts is not required as i have discussed with @vinpahilwani
Just next reminder, with note required
Filter required for Objects with empty custom field count > 0

Technical details

Adding Column for Reminder Date. not sure about default value
Need to add 2 new columns
Planning to add temp value, not keeping data for Past values for Comment and reminder date.
Sorting will be okay for reminder date
after Object gets all custom field, reminder date and comment get removed automatically
Adding Filter for Custom Field Values => All, Empty, Filled (@vinpahilwani please provide english)
Default filter will be empty count > 0

Initiated by @vinpahilwani
verified by @mitulpanch

We keep only one value for Note, so no previous note will be present on system
We just update same field with new note and new reminder date
and delete after All custom field completes

done

Next reminder date picker not working


lxd file push gives unhelpful error when specifying a target directory without trailing slash

Required information

Distribution: Ubuntu
Distribution version: Xenial
The output of "lxc info" or if that fails:
% lxc info
apicompat: 0
auth: trusted
environment:
addresses: []
architectures:

x86_64
i686

driver: lxc
driverversion: 2.0.0.rc1
kernel: Linux
kernelarchitecture: x86_64
kernelversion: 4.4.0-6-generic
server: lxd
serverpid: 27171
serverversion: 2.0.0.rc2
storage: zfs
storageversion: "5"
config:
core.trust_password: true
storage.zfs_pool_name: lxd_zfs

Issue description
lxc file push <file> <container>/<dir> returns obtuse error message and does not push the file.
This occurs when the target path in the container is an existing directory and does not have a trailing slash.  I suspect it's attempting to write to the  as a file which fails.
% lxc file push tgt_1.0.63-1ubuntu1_amd64.deb x1/tmp error: Error calling 'lxd forkputfile /tmp/lxd_forkputfile_515851167 27315 tmp<PHONE_NUMBER>00 436': err='exit status 255'
If you add the trailing slash, it works fine
% lxc file push tgt_1.0.63-1ubuntu1_amd64.deb x1/tmp/
Steps to reproduce

lxc launch xenial x1
echo "hello" > hello.txt
lxc file push hello.txt x1/tmp

Yeah, it should tell you "File already exists" or something along those lines.


Fix stuck PipelineRun caused by optional workspace

Changes

When a Pipeline accepts an optional workspace and gives it to a PipelineTask
the PipelineRun reconciler stalls if the workspace isn't provided. This happens
because the reconciler didn't know that a missing workspace binding is a valid
state for an optional workspace.
This commit fixes the problem by ensuring that the PipelineRun reconciler doesn't
fail to create a task if an optional workspace is not provided.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes
Fixed bug where PipelineRun that didn't provide an optional workspace to the Pipeline would stall until timing out.

Unit Test failure:
=== RUN   TestEmit
    logger.go:130: 2021-01-20T19:05:52.600Z	DEBUG	cloudevent/cloud_event_controller.go:143	Sending cloudevent of type "dev.tekton.event.pipelinerun.started.v1"
    event_test.go:243: received no events for with sink but (?s)dev.tekton.event.pipelinerun.started.v1.*test1 expected
--- FAIL: TestEmit (0.09s)
FAIL
FAIL	github.com/tektoncd/pipeline/pkg/reconciler/events	2.101s

This doesn't reproduce for me locally.
/test tekton-pipeline-unit-tests

Unit Test failure:
=== RUN   TestEmit
    logger.go:130: 2021-01-20T19:05:52.600Z	DEBUG	cloudevent/cloud_event_controller.go:143	Sending cloudevent of type "dev.tekton.event.pipelinerun.started.v1"
    event_test.go:243: received no events for with sink but (?s)dev.tekton.event.pipelinerun.started.v1.*test1 expected
--- FAIL: TestEmit (0.09s)
FAIL
FAIL	github.com/tektoncd/pipeline/pkg/reconciler/events	2.101s

This doesn't reproduce for me locally.
/test tekton-pipeline-unit-tests

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests

@sbwsg @praveen4g0 This fixes #3703 right ?

@sbwsg @praveen4g0 This fixes #3703 right ?

@vdemeester that's right - I've updated the PR description to include a Fixes comment.

@vdemeester that's right - I've updated the PR description to include a Fixes comment.

thanks @sbwsg
/approve

thanks @sbwsg
/approve

/retest

/retest

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-integration-tests


error message:  dangerously_allow_code

Thanks for your work.
I followed the steps to test this tool, and encountered this error:
TypeError: The dash_ag_grid.AgGridcomponent (version 2.0.0a1) with the ID "portfolio-grid" received an unexpected keyword argument:dangerously_allow_code``
Thanks for any potential help provided!

Hi @AtomicNess123
This is due to a change we are making in the next release.  I just updated the demo app so it will  work with version 2.0.0a1.  Would you like to give it another try?

So basically, I git-clone it and try, correct?

The easy way to pip install dash-ag-grid==2.0.0a1 then copy that demo app file and run it.
Plus make sure you have at least the following:
dash>=2.0.0
pandas>=1.2.3
dash-bootstrap-components>=1.0.0
yfinance
If you are interested in contributing and would like to run the latest (unreleased) version, you can fork the repo and follow the instructions on how to build the component locally.

Thanks, how would installing using git clone be?

i basically wanted to run the python script and be able to edit it for my own purposes. Is that possible with this app?

Yes, you can do that - no need to clone the entire repo or build the component locally.  As I mentioned in my first reply, please just:
pip install dash-ag-grid==2.0.0a1

Copy this one file ( run it first to make sure it works) then change it however you like:
https://github.com/plotly/dash-ag-grid/blob/dev/docs/demo_stock_portfolio.py


Improve GitHub deployment

I tried out Franklin today (https://github.com/JuliaPackaging/binarybuilder.org). I didn't end up using much of Franklin's feature set, but what I did use worked flawlessly, which is no small thing for a new package, so congratulations :).
I do have some thoughts on improving the deployment workflow (I've tested this out on the above repo and it seems to work well):

Use a deploy key rather than a personal access token

Personal access tokens are account scoped rather than repository scoped. This may not be a problem for personal sites, but for organizations I can't put my personal access tokens in the secrets since it would give everybody in the org access to all my repos. Luckily the github action used for deployment already supports deploy keys, so it's just a matter of updating the docs.

Generate the __site as part of the deploy

It looks like at the moment Franklin expects the user to generate the __site locally. This is not a great workflow, since it'll prevent merged pull requests from being automatically deployed unless the PR includes the regeneration. I see there's #362 for this already, but everything I'm doing in https://github.com/JuliaPackaging/binarybuilder.org could probably be bundled into a standalone action provided by this repo that can then just be installed. I'm sure our resident github actions expert @DilumAluthge would be happy to help out.

Ok this was super helpful, thanks so much, I was wondering about external dependencies for the pre-rendering but GitHub actions makes that super easy to manage.
I'll do a bit more testing with the DEPLOY_KEY thing and assuming everything works seamlessly will add that soon.

Now done in #390 which will be rolled out in the docs soon


Wrong NPM-package

Hi, I just noticed, that the npm package has the wrong name. The project is called vue-voice-recording, but the README says to install vue-voice-recorder ...

Use npm install vue-voice-recording --save for instead, it works


Rework x509 certificate generation in our testing setup

I decided to rework the current x509 setup we have in our tests. The main reason is that we need SAN certificates for Go 1.15 (Fedora 33, RHEL 8.4).
To achieve this, I created 3 helper scripts that handle X.509 certificates with SAN:
tools/x509/generate-certificate
tools/x509/generate-csr
tools/x509/sign-csr

I think it's pretty obvious what they do, feel free to inspect them, I tried to document them.
The scripts are now used everywhere where we need X.509 certificates. This also means one potentially controversial thing: We're no longer shipping pre-generated certificates in the test subpackage but instead, we're generating them on fly.
I have several reasons to do this:

The pre-generated certificates are not documented. If someone wants to inspect them, he must know the right openssl incantation. This way, you are able to see what's inside the certificates in plain text.

The pre-generated certificates are going to expire at one point and someone will be surprised.

Shipping private keys in RPMs is iffy. I know, it's just for testing but still...

Auth tests are generating their own certificates. To achieve consistency, we have two options:
a) Ship also all certificates for auth tests. That's extra 8 ones or something like that.
b) Generate all certificates on fly. This commit does that.

I force-pushed a fix to api.sh failure. I put a comment in tools/provision.sh explaining why this was needed.
tl;dr: our Schutzbot setup currently violates the "run every test case on a pristine machine" principle.

I am however not a fan of the openssl wrapper scripts. They have similar-but-not-equal API, which might confuse people that already know openssl. Also, it means most certificates have the same options (as for example noted in a comment below).

Honestly, I think most people (including me) don't know openssl well. And that's exactly why I tried to hide it. If we have a wrapper reviewed by someone who does, then everybody on the team can use it to easily generate safe certificates. Restricting users to be able to use just a subset of openssl options sounds like a good way to prevent people from getting burned by delicate internals of the openssl hydra.

I think I'd prefer using openssl directly, passing a config file that is specific to the test we generate certificates for. That would be easier to review than to read code to find out which options (mostly SANs) were passed.

In auth-tests, we generate a lot of similar certificates. Honestly, I don't like the idea of shipping multiple very similar config files for openssl. Possibly, we can have an openssl configuration generator script, that sounds like a nice middleground between "have a wrapper for openssl" and "have a lot of similar configs in the repo".

Honestly, I think most people (including me) don't know openssl well. And that's exactly why I tried to hide it. If we have a wrapper reviewed by someone who does, then everybody on the team can use it to easily generate safe certificates. Restricting users to be able to use just a subset of openssl options sounds like a good way to prevent people from getting burned by delicate internals of the openssl hydra.

Very fair point. Except one thing: I wouldn't say these certificates are "safe" — they are ok for testing, but go against common practice of giving the least permissions possible.

In auth-tests, we generate a lot of similar certificates. Honestly, I don't like the idea of shipping multiple very similar config files for openssl. Possibly, we can have an openssl configuration generator script, that sounds like a nice middleground between "have a wrapper for openssl" and "have a lot of similar configs in the repo".

Ah, I didn't know auth-tests generated that many certificates. I like the idea of a config generator.

Superseeded by #1057


Music Player

Description 📜
Please include a summary of the change and which issue is fixed.
Fixes #1341

Type of change 📝
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] Add a new project
[] Modified or enhanced the existing projects
[] Improve the readme of any project

Domain of Contribution 📊
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[] Project using only HTML & CSS
[x] Project using HTML, CSS & JS
[] Project using ReactJs

Checklist ✅
Please delete options that are not relevant. In order to tick the check box just put x inside them for example [x] like this

[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸

Plag content found
https://codepen.io/sahilpro/pen/dypdrRB?editors=1100

Remove labels @Mrjoy832


Can  'predict_hallucination_mt.py' be used to predict hallucination for summarizaion tasks?

@violet-zct Hi, I'm sorry to touble u again. As mentioned in REAMDE.ME, we can use 'predict_hallucination_mt.py' directly to predict hallucination.  There is a XLMRModel for predicting MT hallucination in that script.
xlmr = XLMRModel.from_pretrained(
   model_path,
   checkpoint_file='checkpoint.pt',
   data_name_or_path=datapath
)

Can we use it directly to predict hallucination for summarizaion tasks? Or,  Should we write another script to use roberta model for predicting hallucination in summarization?

No worries. So XLM-Roberta is a cross-lingually pre-trained model that handles different languages, for English summarization tasks, please use the Roberta model.

Appreciate sincerely for your reply!


Proxy Http Reason Phrase to Avoid Unconscious Incompatibilities.

Some backend services (e.g., Azure Relay) are customizing HTTP reason phrases. This should be considered as misuse of the HTTP protocol but that info may need to be kept at the proxying time to keep the integrity of the origin messages.
An example response:
401 MissingToken: Relay security token is required. TrackingId:988e8147-c5ed-473c-a679-fb2c0d400ee4_G11, SystemTracker:hdirelay-uswe-d4c1893d-0.servicebus.windows.net:a21a0c87558b411bb098f8a8c7cad92a, Timestamp:2023-03-07T03:52:29

@twitchax twitchax

Hey, sorry, I was out of town, and missed this.  Will take a look.


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for quiet-chimera-c1d66f processing.

Name
Link

🔨 Latest commit
be2613ac6ffa3ab82cab546d0bf3265f4e41c9c3

🔍 Latest deploy log
https://app.netlify.com/sites/quiet-chimera-c1d66f/deploys/64e2036153ef6f000870120c


show current wallpaper

It would be nice to have a button to display current wallpaper on the list.

Android doesn't support accessing wallpapers by user apps.

I checked and found out that it's possible to get the wallpaper but only with MANAGE_EXTERNAL_STORAGE permission. I'm not sure anyone will ever grant the app this permission but I think I can make some plans to add folder support and other things that may utilize this permission better and simultaneously support this as well.

I have added this in v1.52, check it and let me know.


OCL: [objdetect]Remove unnecessary barrier in runHaarClassifier().

Signed-off-by: Yan Wang<EMAIL_ADDRESS>

@ilya-lavrenov @vpisarev Could you please review this PR? Thanks.

@ilya-lavrenov @vpisarev Could you please review this PR? Thanks.

:+1:


Breadcrumbs incorrectly render when displayMissing is false.

Here is an example of a route, where the final two items are  named, but the first ones are not:

Here it is when displayMissing is false:

This PR fixes the issue by removing routes with no name before they are added to the list of routes to render. (ignore the seperator change)

Thanks! It's now merged and available with version 1.4 :)


Is this still maintained? Or EOL?

I am seeing no update since 2019, and it looks like there was a plan for updates and an RC but that is from 2020?
Seein issues like this here
Is this a dead project or just one not in need of too many updates?

@jonxssc  To be save I upgraded to react-native-swiper-flatlist, needed to refactor some, and is not 1:1 but worked for my use. It seems to still be maintained

Thanks, i will also try it with this one :)

Hi guys,
I'm trying to carry out the work on a separate library, is welcome anyone who wants to participate :)
https://github.com/rideonagency/ro-react-native-swiper
Thanks!

DEAD PROJECT


Experimental WebAssembly support

Changes to introduce experimental WebAssembly support into CoreRT. This is enough to print "hello world".
This change adds a new WebAssembly backend to ILCompiler. This backend uses the LLVMSharp library to emit LLVM bitcode. That bitcode can then be compiled by Emscripten into WebAssembly or Asm.js. The new ILToWebAssemblyImporter is based off of the existing importers. In these changes, the supported opcodes include:

Arithmetic
Load and store locals, arguments, and fields
Non-virtual calls
Branching

Other working features include:

Generating data sections
P/Invokes to linked C++ code (that don't require marshaling)

Also includes initial WebAssembly test infrastructure. There is one test that generates bitcode for "hello world". If the machine running the test has Emscripten installed, it will also be linked to WebAssembly.
Big thanks to @davidwrighton, @MichalStrehovsky and @shrah, who worked with me on the WebAssembly experiment.
When merging these changes, please do not squash.

When merging these changes, please do not squash.

We should at least manually rebase out half of the garbage checkins such as "WIP" and "BuildsAgain". This is pretty ugly to have in the source history. (I don't mind not getting credit for any of my changes, so I wouldn't be opposed to squashing.)

I would be useful to add a file under https://github.com/dotnet/corert/tree/master/Documentation: how to compile simple program (outside of the test harness), current state, etc.

@jkotas , I was planning to put together docs and file issues after this is merged. Does that sound reasonable?

ok

If folks sign off on the changes, I'll make an attempt at history cleanup before merging (but I'd like to be sure I don't have to change the code before I do that).

I've attempted a bit of history cleanup, though it's not ideal (I ran into a couple of rebase issues when I tried to do a final pass). Once CI passes, I'll merge.


Unable to return data object from response/promise

I'm not sure if this would improve error handling but can I return just the data object on success? The following code will not work but hopefully the idea makes sense.
$scope.loadTags= function (query) {
 $http.get('types.json').success(
  function (data, status, headers, config) {
    console.log(config);
    console.log(data);
    console.log(status);
    console.log(headers);
    return data;
    //currently have to return $http.get('types.json') in order for code to work but this is not ideal.
   }).error(
   function (data, status, headers, config) {
    //Handle Errors
   }).then(
   function (data, status, headers, config) {
    //Handle cleanup
   });
};

Sorry for not replying sooner.
ngTagsInput will work with any array that your success callback may return, but you need to make your loadTags() function return a promise:
$scope.loadTags= function(query) {
  return $http.get('types.json').success(function(data) {
    return data;
  });
};

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Error-handling pattern in core-data REST Handlers missing returns

Fixes: https://github.com/edgexfoundry/edgex-go/issues/1907
Signed-off-by: Michael Estrin<EMAIL_ADDRESS>

Rebased

recheck

Codecov Report

Merging #1908 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   44.01%   43.94%   -0.07%
==========================================
  Files         184      184
  Lines       11504    11521      +17
==========================================
  Hits         5063     5063
- Misses       6154     6171      +17
  Partials      287      287

Impacted Files
Coverage Δ

internal/core/data/router.go
11.61% <0%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0aa8f0...32f773d. Read the comment docs.


Implement saving and restoring of column widths with stateSave

Thank you again, that was on my TODO list for a while. I will test and merge soon.


[improve][client] Revert "[fix][client] Messages with inconsistent consumer epochs are not filtered when using batch receive and trigger timeout

Motivation
https://github.com/apache/pulsar/pull/17318 has made internalRedeliverUnacknowledgedMessages executed by internalPinnedExecutor which may cause a deadlock described in https://github.com/apache/pulsar/pull/18462.
So revert this patch and decide to close https://github.com/apache/pulsar/pull/18462.
Modification

Revert this patch.
Push out a fix without using internalPinnedExecutor

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #18475 (3a9dcdc) into master (fdf86d3) will decrease coverage by 9.23%.
The diff coverage is 4.58%.

@@             Coverage Diff              @@
##             master   #18475      +/-   ##
============================================
- Coverage     45.67%   36.44%   -9.24%
+ Complexity    10075     1938    -8137
============================================
  Files           693      208     -485
  Lines         67940    14434   -53506
  Branches       7273     1589    -5684
============================================
- Hits          31030     5260   -25770
+ Misses        33333     8600   -24733
+ Partials       3577      574    -3003

Flag
Coverage Δ

unittests
36.44% <4.58%> (-9.24%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...r/client/impl/UnAckedMessageRedeliveryTracker.java
0.00% <0.00%> (ø)

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
14.80% <1.47%> (-0.30%)
:arrow_down:

...he/pulsar/client/impl/MultiTopicsConsumerImpl.java
22.26% <2.94%> (-0.70%)
:arrow_down:

...va/org/apache/pulsar/client/impl/ConsumerBase.java
21.95% <33.33%> (ø)

...a/org/apache/pulsar/client/impl/MessageIdImpl.java
80.55% <33.33%> (+18.05%)
:arrow_up:

...apache/pulsar/client/impl/ConsumerBuilderImpl.java
27.80% <50.00%> (+0.29%)
:arrow_up:

...he/pulsar/client/impl/PartitionedProducerImpl.java
30.34% <0.00%> (-5.13%)
:arrow_down:

...va/org/apache/pulsar/client/impl/ProducerImpl.java
15.84% <0.00%> (-1.17%)
:arrow_down:

.../org/apache/pulsar/client/impl/ConnectionPool.java
37.43% <0.00%> (-1.03%)
:arrow_down:

.../pulsar/client/impl/ProducerStatsRecorderImpl.java
84.04% <0.00%> (-0.62%)
:arrow_down:

... and 492 more


Setup Your Mac (1.5.0-rc1): Code to Rename Computer

Andrew Clark
:happymac:  4 hours ago
One addition is to the scutil commands, in general the host names should also be set to the computerName.
I added
scutil --set HostName "${computerName}"
scutil --set LocalHostName "${computerName}"

colorenz
3 hours ago
Moin, why can we  not use the following to set Name?
@drtaru
 /usr/local/bin/jamf setComputerName -name

Resolved in v1.5.0.


make CRA work cross-platform

Make PUBLIC_URL environment variable work on all the platforms

@lamiazar @wujekbizon can you either try to run the updated app from this branch or follow the instructions in the README.md? I don't have a Windows machine with me.

@chicoxyzzy I will test now

@chicoxyzzy I'm still getting the same error, I tested that on your branch cross_platform_cra

@lamiazar can you try these two ways to run the app and test if any of these work?

set PUBLIC_URL=./ && ssc build
set PUBLIC=./ && npm run build && ssc run

I tried everything and still got an error

The build failed when I run this (I'm getting the same error) --> set PUBLIC_URL=./ && ssc build
I'm getting this output for set PUBLIC=./ && npm run build && ssc run

C:\Users\lamia\socket-examples\advanced\create-react-app>set PUBLIC=./ && npm run build && ssc run

><EMAIL_ADDRESS>build
> react-scripts build

Creating an optimized production build...
Compiled successfully.

File sizes after gzip:

  46.62 kB  build\static\js\main.1c40095e.js
  1.79 kB   build\static\js\787.62ea5e01.chunk.js
  541 B     build\static\css\main.073c9b0a.css

The project was built assuming it is hosted at ./ /.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.

Find out more about deployment here:

  https://cra.link/deployment

• executable not found: C:\Users\lamia\socket-examples\advanced\create-react-app\dist\win\create-react-app-example-dev-v1.0.0\create-react-app-example-dev.exe 5ms

Please pull latest changes and try ssc build -r again

it works for me

it even works for both first commit and last commit

are you running it from PowerShell?

are you running it from PowerShell?
no, from command prompt
I'll try with PowerShell now

I'm sorry, but it still doesn't work for me, even when using PowerShell.

@wujekbizon did you try updating ssc version? @chicoxyzzy has build the app from the latest master.

did you try updating ssc version? @chicoxyzzy has build the app from the latest master.

yes , I'm on the latest one. Is it working for you?

yes , I'm on the latest one. Is it working for you?
I'm updating ssc now, I have an old version

@mribbons can you try ssc build -r for this branch and advanced/create-react-app example too?

@mribbons can you try ssc build -r for this branch and advanced/create-react-app example too?


scripts: update Roasbeef's key ID in verify-install.sh

This was overlooked in #1229.
We're updating to the parent key ID
A5B61896952D9FDA83BC054CDC42612E89237182.
$ cat scripts/keys/roasbeef.asc| gpg --with-colons --import-options show-only --import

pub:-:255:22:DC42612E89237182:1729552568:::-:::scESCA:::::ed25519:::0:
fpr:::::::::A5B61896952D9FDA83BC054CDC42612E89237182:
uid:-::::1729552794::8D805FB762825ECBDA00EB0AF5FEDF76DE288546::Olaoluwa Osuntokun <laolu32@gmail.com>::::::::::0:
sub:-:255:18:19E88A946BEF6D65:1729552568:1761088568:::::e:::::cv25519::
fpr:::::::::70206BBE2C0A81EC381A212C19E88A946BEF6D65:
sub:-:255:22:966072F65DF1D016:1729552672:1761088672:::::a:::::ed25519::
fpr:::::::::98E3632DC026406855001E22966072F65DF1D016:
sub:-:255:22:90525F7DEEE0AD86:1729552758:1761088758:::::s:::::ed25519::
fpr:::::::::296212681AADF05656A2CDEE90525F7DEEE0AD86:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
18 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.008%) to 40.708%

Files with Coverage Reduction
New Missed Lines
%

tappsbt/create.go
2
53.22%

tapgarden/planter.go
2
74.12%

tapdb/addrs.go
2
75.09%

tapchannel/aux_leaf_signer.go
3
43.43%

tapgarden/caretaker.go
4
68.87%

commitment/tap.go
5
83.64%

Totals

Change from base Build<PHONE_NUMBER>0:
0.008%

Covered Lines:
25819

Relevant Lines:
63425

💛  - Coveralls


Using the system's own Chinese input method can not input Chinese

You can't input Chinese using the Chinese input method that comes with WIndows 10.

Same issue. In fact, I can't change any input settings in Windows Terminal. So I can't type any non-English characters.

Version: 0.4.2382.0

/dup #2213


Use loaders.gl core with csv and arrow data modules for loading data

see: https://loaders.gl/docs/developer-guide/using-worker-loaders

will try frictionless js libs listed in #15 instead.


Value for $RIGHT_PROMPT placement error

I have the setting $RIGHT_PROMPT='meow' (to keep it as simple as possible).
After a clear, the meow shows up on the bottom right.
After hitting enter, the meow shows up at the end of the line above the current prompt (the line I just left).

It is a problem with prompt-toolkit rendering. It was fine until few version updates.


Document update: GRAPHICS_CURVES.adaptive default value to true

Description of change
Update file: pixi.js/packages/graphics/src/const.ts
It's seems like default value is true
// @property {boolean} adaptive=false - flag indicating if the resolution should be adaptive
export const GRAPHICS_CURVES: IGraphicsCurvesSettings = {
    adaptive: true,
    //...
}

Pre-Merge Checklist

[ ] Tests and/or benchmarks are included
[x] Documentation is changed or added
[ ] Lint process passed (npm run lint)
[ ] Tests passed (npm run test)

Good one! Thank you


Update Blog Post “2020-05-recruiting-first-—-being-social-while-distancing”

Automatically generated by Netlify CMS

Deploy preview for dds-mil ready!
Built with commit fe29ea04a46c468b37e7409f888681e9852b6bdb
https://deploy-preview-268--dds-mil.netlify.app


Server console should only auto-scroll at the bottom

Product

[x] Panel
[ ] Daemon
[ ] Dockerfile(s) [Please list if so: __ ]

Type

[ ] Bug or Issue
[ ] Feature Request
[x] Enhancement
[ ] Other

The server console when managing a server should only automatically scroll to the bottom when new messages arrive if the console is scrolled all the way down (or very close to beeing so).
This would eliminate the need for the pause button and make it much easier to read the log.
We could try to set terminal.scrollOnEcho to false when the terminal isn't scrolled down if possible.

This is a limitation of the software being used to control it, so not much I can do about it as far as I can tell.


Stream scroll 10010

Part of PR #10010
Currently on zoom out from stream topics, scrollbar didn't scroll back
to opened stream. Because call to scroll-to-stream func isn't called
after all streams view is displayed. So wrong stream element is
passed to func.
Fix this by calling scroll-to-stream func after all-stream-list view
is displayed.
Before:

After:

@synicalsyntax I wasn't able to open PR on your PR #10010, so please review it here and merge into yours.

@YJDave and @synicalsyntax Thanks for working on this!
Most of the commits look good to me, but the commit entitled "overlays: Normalize different overlays' styling." perhaps could use a bit more explanation in the commit message.
I'm about to test this out.
@timabbott Two of the commits here are pretty trivial to merge:

stream list: Scroll to opened stream on zoom out from stream-more-topics.
scroll_util: Account for element padding in height calculations.

In testing this, I found strange behavior that's not due to this PR--we can scroll past the bottom of streams on Stream Settings.  Haven't dug deep into it yet.

The left sidebar stuff seems to work perfectly for me, and those are both tiny commits.
I also tested the stream settings.  There's definitely some different scrolling behavior, and I prefer the new way here, although it's hard to see the speedup since stream settings is just sluggish in general.  Those commits are a bit more invasive, but I hope we can merge them soon.  There are other efforts underway to improve Stream Settings, so we don't want to build up too much PR debt.

I merged 3 commits; I'm having a harder time understanding the big overlays refactor, so left that open.

I am closing this PR, since starting commits are merged and unmerged commits are covered in #10010 with rebase.


transition duration not working on material present

Hi;
Transition duration not working when presenting view controller with material style. On dismiss it seems like its working.
When presenting vc without material style it works as intended.

Yes, i forgot to set animation's duration. you can check it now.

thnx for the quick response, it is alright now.


user provided bins

For example, I already computed the bins through my own method, can I give that to the view?

Can the user provide bins in an array? If they want to compute non-linear bins, let them! DO whatever you want


Create an lambda example for reading images directly from S3

Chip n Scale originally sends tile (x, y, z) from their tile endpoint to the TFServing for model inference.
We have a project now requires to read images directly from a client's S3 bucket.
We need to write a lambda example that can allow Chip n Scale to read images from an S3 bucket.

Closed via #18


Changed cached_result to be compatible with new QCPortal

Fixes #38

Codecov Report

Merging #40 (975d722) into main (98f9a50) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files


5.0.0rc2

The maintainers of this repository would appreciate it if you could provide more information.

I'm sure they would


feat: data-side & data-align for floating content

This PR introduces small yet mighty improvements to the "floating" content and arrows, which apply data-side and data-align attributes to the various "floating" elements containing the true positioning of the element after the floating UI computation.
data-side can be one of - 'top' | 'left' | 'bottom' | 'right'
data-align can be one of - 'start' | 'end' | 'center'
The arrow component just receives the data-side attribute, so you can easily adjust the style of the arrow depending on the side it's actually rendered on.

Thanks! This closes https://github.com/melt-ui/melt-ui/issues/519


insert date header into file

# 2023-11-09 at the top of the file, which improves things when rendering in the terminal,

https://github.com/notnmeyer/daylog-cli/pull/11


[BUG]: Studio not working - Drizzle Local Storage Error - Permission Denied for 'rules' Table

What version of drizzle-orm are you using?
0.33.0
What version of drizzle-kit are you using?
0.24.1
Describe the Bug
i don't have the 'rules' in my project !
read the report bug zip file
Expected behavior
the studio work at : https://local.drizzle.studio/
Environment & setup
Linux redhat using pg with docker locally
chrome
bug-report.zip

@mieaw Hey! What user are you using to connect?


CWELL-15237: Overlay theming

Summary
Added theming variables and wdio tests for Overlay component.
Fixes #1184
Deployment URL
https://terra-core-deployed-pr-1222.herokuapp.com/
Thanks for contributing to Terra.
@cerner/terra

@paku-sruti We are in the process of removing nightwatch tests from our repository and replacing them with webdriver.io tests. Would you mind adding webdriver.io tests for the remaining test routes so we can remove the nightwatch for this component?

@emilyrohrbough  Adding the other tests is out of the scope of this story. I have spoken to my team lead @dm123455  I'll be adding the tests as a part of a different story.

@neilpfeiffer Do you want to look over this before we merge it done. It is mainly tech-only, but you may want to check out the theming variables before we merge it.

Checking against all the themes to make sure we have

Let remove all opacities - originally a hold-over from Terra-legacy, and none of the theme designs uses opacity to create transparency for both background and content (which can already be achieved through background-color and color if needed).
https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L12
https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L25
https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L35

2) Update these values:
background: var(--terra-overlay-dark-background-color, #1c1f21 rgba(28, 31, 33, 0.8) );
https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L23
background: var(--terra-overlay-light-background-color, #f4f4f4 rgba(245, 245, 245, 0.7) );
https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L33

3) Add a child element .content class inside of .light so can be correctly colored white in consumer:
    .content {
      color: var(--terra-overlay-light-content-color, #1c1f21);
    }

https://github.com/cerner/terra-core/blob/e294371600e853b78f21007aa4b63570707157b5/packages/terra-overlay/src/Overlay.scss#L36

@neilpfeiffer I updated the code with the suggested changes. It is ready for review.

Tested: PR #1222
Resolves: Issue #1184

Reviewed:

No change to implementation for terra-overlay and loading overlay.
corrects minor color variations to better match previous Terra-Legacy styling.
provides correct variables needed for theming capability.

Verified @neilpfeiffer, Ready for Release.

Pass

UX Review

@bjankord  I updated the screenshots, all tests are passing now. The branch is ready to merge.


fix minor typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Good catch! Thanks!


Typo in doc @\Zend\Expressive\Helper\BodyParams\StrategyInterface::parse

see https://github.com/zendframework/zend-expressive-helpers/blob/master/src/BodyParams/StrategyInterface.php#L26
It returns a request, so i think the doc should go like

Parse the body content and return a new request.

instead of

Parse the body content and return a new response.

Thanks for reporting this. It's been corrected in 2.0.2.


improve throw If Unchecked

#2160
fixed error:
/DynFields.java:60: error: [ThrowIfUncheckedKnownChecked] throwIfUnchecked(knownCheckedException) is a no-op.
Throwables.throwIfUnchecked(e);
DynFields.java:69: error: [ThrowIfUncheckedKnownChecked] throwIfUnchecked(knownCheckedException) is a no-op.
Throwables.throwIfUnchecked(e);

@justinmclean please take a look

We use Spotless (https://github.com/diffplug/spotless) to keep our code formatting consistent as part of our Gradle build. It's best practice to build the code before checking in. You'll need to run "./gradlew : catalogues: catalogue-hive:spotlessApply" to fix the formatting. I've not looked at the issue in detail, but given the simple change, you may have incorrect line endings. We use Unix/macOS LF, not Windows CFLF.

@lambaaryan011 tell me if you need some help with this.

ok, sure
On Mon, Feb 12, 2024 at 10:49 AM Justin Mclean @.***>
wrote:

@lambaaryan011 https://github.com/lambaaryan011 tell me if you need
some help with this.
—
Reply to this email directly, view it on GitHub
https://github.com/datastrato/gravitino/pull/2170#issuecomment-1938078664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEUVDPYQC775VEDSDYMIHJ3YTGQ73AVCNFSM6AAAAABDCW6U3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZYGA3TQNRWGQ
.
 If so please give me permission to push to your branch.

Yes, please!   sorry for late  because my college exam is going on
On Tue, Feb 13, 2024 at 11:40 AM Justin Mclean @.***>
wrote:

@lambaaryan011 https://github.com/lambaaryan011 Do you still need a
hand with this? If so please give me permission to push to your branch.
—
Reply to this email directly, view it on GitHub
https://github.com/datastrato/gravitino/pull/2170#issuecomment-1940483884,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEUVDP5BRX7BM6BZKQMC3I3YTL7UZAVCNFSM6AAAAABDCW6U3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGQ4DGOBYGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I don't have permission to push to your repository, so here is the patch.
patch.txt

@lambaaryan011 Do you have time to apply the patch I gave you?

Yeah, I can do that.
On Mon, Feb 19, 2024 at 10:03 AM Justin Mclean @.***>
wrote:

@lambaaryan011 https://github.com/lambaaryan011 Do you have time to
apply the patch I gave you?
—
Reply to this email directly, view it on GitHub
https://github.com/datastrato/gravitino/pull/2170#issuecomment-1951677737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BEUVDP2ZIBLW6NZAUAOEY43YULI3FAVCNFSM6AAAAABDCW6U3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGY3TONZTG4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Close this PR as it has no update for a long time. Please re-open if needed.


numeric - invalid regexp group only on firefox

Describe the bug
Only on Firefox, the numeric alias (latest beta version 191):

is producing a lot of errors on change: invalid regexp group
deleting (one digit or entire selected value) doesn't reflect to the mask but the value is actually changed (blur & focus on the field updates it correctly)

On Safari or Chrome it seems to be working fine
PS: how to retrieve the actual value (unmasked) if suffix / prefix configured ?
To Reproduce
Steps to reproduce the behavior:

Go to this CodePen
Open firefox console (the errors do not show up on CodePen app console
Update input field value
See error in console
Try to delete (partial or entire selection). The value (mask) doesn't change (but the value actually does)

@razvanioan,
Ok, named groups are not supported in firefox.

@razvanioan ,
I already made the fix in the numeric extensions.  But I didn't push a new bundle in the dist folder, as I was still working on another fix.  The next push will include the fix into the bundled files.


Mezzanine release v2 script updates and metadata

Changes made over the past few months, used to generate mezzanine release v2, including:

Annotations now added to green start frame and red end frame, starting from frame 1 (not frame 0).
Stream duration is now exactly 60 seconds (instead of 60 seconds + 2 frames previously).
Black background added behind QR codes to help with detection.
Bit pattern added to the top left of the video (with frame number, total frames, frame rate, horizontal resolution and vertical resolution).
Mezzanine audio sample rate now always 48kHz.
A/V sync metadata is saved to JSON files named as follows: <mezzanine_filename>_avsync.json
Metadata for each mezzanine stream, including video properties and license, now saved to JSON files named as follows: <mezzanine_filename>.json
Mezzanine stream metadata for mezzanine release v2.
Grouped assets and updated JSON configuration files (rjf) for generating mezzanine content into separate folders.

As part of the clean-up, I propose to remove the unused legacy scripts as well.
Together with the mezzanine release v2, this resolves issues #40, #38, #36, #29, #28, #18 and #20.

I've regenerated the test content with the mezzanine v2.


Thank you

Screenshot

This pattern is related to #77 (Exit surveys)

@gavinwye Part of #77 or #46 rather than on its own.

closed because of what @stevenaproctor says above


Replace http.Flusher with http.ResponseController for SSE in Go SDK

Using ResponseController instead of Flusher is more appropriate since Go 1.20:
https://tip.golang.org/doc/go1.20#http_responsecontroller
https://www.alexedwards.net/blog/how-to-use-the-http-responsecontroller-type
It changes the ServerSentEventGenerator struct as seen below, replacing the flusher with a ResponseController.

I have re-added it to the panic when we flush the headers.


Adding one or more Admin Sets changes Default AS to being closed by default

Descriptive summary
targeting Hyrax v1.0.0
Rationale

If as the administrative user I add a second administrative set (calling it here the ‘mediation administrative set’) and connect it to this one-step mediation workflow, and assign participants to the new mediation administrative set, and assign roles to workflows, users with either the deposit or approve mediation role are no longer able to deposit to the default administrative set, unless as the administrative user, I add them as participants (depositors) to the default administrative set.

Note: I'm not seeing this in master so this may be another bit of work that is backportable.
Expected behavior
Actual behavior
Steps to reproduce the behavior
Related work

I believe this will be irrelevant once #887 is merged.

Fixed by https://github.com/projecthydra-labs/hyrax/pull/887


Fix mod-shib package name for current debian

This is a great idea and I'll try to update it very soon

@porkotron  Hi, this has been merged and there's a new container image, version 5.1, on Github and Docker Hub.
I'd made this change locally awhile ago and completely forgotten to publish it - sorry about that, and thanks for the PR!

Thanks!


rarian: remove

Description of changes
It is still being maintained somewhat but basically nothing uses it and even Debian dropped it:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914523
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Yeah I was quite surprise when this appears in my repology search. I am okay with this.


Internet Explorer Support

ng2-smart-table doesn't work in Internet Explorer 11.
It doesn't get displayed.
Please help me fix this problem.
Thanks in advance

Even the https://akveo.github.io/ng2-smart-table/#/ page doesn't load in IE 11.

I've solved the issue by adding these dependencies (package.json)
dependencies:
"array.from": "^1.0.3",
"babel-polyfill": "^6.23.0",
"babel-runtime": "^6.23.0",
devDependencies:
"babel-plugin-transform-runtime": "^6.23.0",

Appears to be still missing some polyfills, getting:
Unable to get property 'apply' of undefined or null reference

on the demo page

dependencies:
"array.from": "^1.0.3",
"babel-polyfill": "^6.23.0",
"babel-runtime": "^6.23.0",
devDependencies:
"babel-plugin-transform-runtime": "^6.23.0",
Still issue remains same.


[release-1.7] Change sample cross-network port to 15443

Manual cherrypick required.
#26389 failed to apply on top of branch "release-1.7":

#26422