Implement Zod Validation for Deleting Multiple Articles from an Article Series

Title: Implement Zod Validation for Deleting Multiple Articles from an Article Series
Description:
This GitHub issue is dedicated to enhancing the validation process for deleting multiple articles from an article series within the /user/article_series/:id/articles route. The task involves implementing Zod validation to ensure the validity of the id parameter and the array of articles IDs. This improvement provides a structured validation approach to maintain data integrity and code quality.
Tasks:

Implement Zod Validation for id Parameter:

[ ] Implement Zod validation for the id parameter in the /user/article_series/:id/articles route.
[ ] Define the validation logic using Zod to require the id parameter and ensure it cannot be 0.

Array Validation for articles:

[ ] Implement Zod validation for the articles array to ensure it contains valid article IDs.
[ ] Verify that the articles array contains only numbers.

Acceptance Criteria:

The /user/article_series/:id/articles route successfully implements Zod validation for the id parameter.
The id validation ensures it is required and cannot be 0.
Zod validation is implemented for the articles array.
The articles validation ensures it contains only valid article IDs represented as numbers.

Additional Information:

Implementing Zod validation improves data integrity and code quality.
The structured validation approach contributes to better data handling and error prevention.
This enhancement helps maintain a robust and reliable codebase.

Hi, this looks similar to the validator we created today. May I please work on this issue as well?

Assigned to you

Hi, I need an input for this. As we are getting the body in this format, articles: number[], we cannot use an array of our existing idValidator as it expects an object with id.
Can we repeat the number validation inside arrayValidator such as
export const idArrayValidator = z.array(
    z
        .number({
            required_error: 'id is required',
            invalid_type_error: 'id must be a number',
        })
        .refine((value) => value !== 0, {
            message: 'id must not be equal to 0',
        }),
);

or can use something like this if(req.body.articles is array) req.body.articles.forEach(article => idValidator))

@sparsh-18 I think we can use idArrayValidator

z
.number({
required_error: 'id is required',
invalid_type_error: 'id must be a number',
})
.refine((value) => value !== 0, {
message: 'id must not be equal to 0',
})

Also reuse the id validator already created

z
.number({
required_error: 'id is required',
invalid_type_error: 'id must be a number',
})
.refine((value) => value !== 0, {
message: 'id must not be equal to 0',
})

Also reuse the id validator already created

actually this is where the problem is coming, the idValidator expects an object with field id, but we have to validate an array of ids.

@sparsh-18 Then create total new one that validate array of ids .

HI @prasenjeet-symon please refer the PR


How to enable MCU mode?

Hi,
I ran the demo and it seems is SFU mode. How can I enable MCU mode? I want to create a video meeting with about 100 participants.
Thank.

Did you manage to find out?


Fix no msgs in queue bug after replug

I would receive "No message of type '{frame_type}' in frame queue. error whenever I unplug and replug a camera in while having the stream open. This is the fix

@seanavery bump on this review


tutorial should define OPENWHISK_HOME first before using it in a command

from https://dist.apache.org/repos/dist/dev/incubator/openwhisk/apache-openwhisk-0.9.0-incubating-rc1/doc/INSTALL.md
to avoid conflicting values for the env var, the instructions should first tell you to define OPENWHISK_HOME before running this command.
and maybe we should avoid that anyway - you're already assuming in the build steps that you're in the incubator-openwhisk directory, users will need to cd ansible... so why not reset the path and avoid introducing this var.
## Run OpenWhisk

The easiest way to try out OpenWhisk is to use OpenWhisk CLI. Please find the configuration [here](https://github.com/apache/incubator-openwhisk/blob/master/docs/cli.md).
For example, you can configure you CLI with the following command, if you have deployed OpenWhisk locally:

$ wsk property set --apihost <IP_ADDRESS> --auth $(cat ${OPENWHISK_HOME}/ansible/files/auth.guest)

The environment variable $OPENWHISK_HOME points to the directory incubator-openwhisk.

Will update the doc for this issue together with #213


Generate QR code

Create a QR code for the shortened link in case the user wants it.

Update Frontend component
Update Backend to receive and send back new params

https://github.com/Nishant9771/QR-Code-Generator
Check here for that.


Misordered ports

Some ports are showing the times and capacities for other routes. Double check they're retrieving the correct ones and reorder as needed.

Closing due to PR #25


Upgrade calcite in druid

Motivation
We are currently stuck on an older version of calcite. This is because of old guava dependencies coming from Hadoop 2. Till we get rid of hadoop 2, we cannot upgrade calcite.
The upgrade will be very helpful because

There are bug fixes in recent version of Calcite. We have seen some queries fail in calcite layer. We tried these queries with a test patch that has newer calcite. We didn't see the failures with newer calcite version.
Extending calcite is easier in later version. We had to copy a bunch of boilerplate code to add custom syntax. This boilerplate code can be removed.
Calcite provides hints that druid developers want to use. However these are not available in the current version we use.
We want to be able to upgrade a calcite dependency quickly in case a security vuln is discovered.
There is significant drift already between the version we use and the latest calcite version. Between these versions, some API has been deprecated and then removed. The more we delay, the higher the drift is and more work in upgrading.

Proposed Solutions
The major blocker for the upgrade is old guava dependencies.
Removing Hadoop 2 entirely
We can remove Hadoop 2 entirely and thus rid ourselves of its transitive dependencies. We have a Hadoop 3 distribution profile and will be shipping a Hadoop 3 compatible druid distribution bundle with 25.0. There is some discussion about it here https://lists.apache.org/thread/1j5w9dmt1gp8hx31tvrmyomcko4mlp03
However, there are concerns in the community about Hadoop 3 not being a viable alternative. We have now classic batch ingestion and also SQL-based batch ingestion. We have also added MM-less ingestion on Kubernetes. With this, users now have the ability to use a common/shared infra to run druid ingestion jobs. However, MM-less ingestion is still experimental.
Calcite shading
The other option is to shade the calcite jars. Calcite dev team is not going to do this. Instead, we can shade the jars ourselves. There is a prototype here and it works. I ran into a problem with tests however it was fixed in calcite 1.30.0
Next steps
To proceed with the upgrade, we can go with the shading approach. There is a prototype that already works. We need to figure out where we want to host these shaded jars. Once done, we also need to test the SQL thoroughly to avoid regressions.

Do you know if Hadoop 2 + Guava 19 has been tested? Guava 19 is Calcite's minimum version these days, so we could update to that as a compromise version if it works for Hadoop 2.
I raised a PR here so it can at least run through CI: https://github.com/apache/druid/pull/13544. Although I'm not sure to what degree that exercises Hadoop 2 compatibility, or if we need to run it on a real cluster too.

A note about shading: it looks like Apache Beam does this too. Here’s their build file for Calcite: https://github.com/apache/beam/blob/52753a9c854786ad0732af4b8577d1cdcfc66047/vendor/calcite-1_28_0/build.gradle. It relocates Guava (com.google.common) and some other packages.
They do their own releases as well. Here's the latest one: https://mvnrepository.com/artifact/org.apache.beam/beam-vendor-calcite-1_28_0/0.2

Another question for anyone who has tried this: what went wrong when using the latest Calcite with Guava 16.0.1? From the thread at https://lists.apache.org/thread/oy84c1607hyjhkbop8svtrzlzgj5632q, it seems like this may actually work OK, even though Calcite claims to have a minimum version of 19.

Relevant action in this sub-thread: https://lists.apache.org/thread/oy84c1607hyjhkbop8svtrzlzgj5632q. Calcite targets a minimum Guava version of 16.0.1 as of https://issues.apache.org/jira/browse/CALCITE-5428. I'm working on integrating this into Druid. So far, I ran into these three things along the way:
https://issues.apache.org/jira/browse/CALCITE-5477
https://issues.apache.org/jira/browse/CALCITE-5478
https://issues.apache.org/jira/browse/CALCITE-5479
Other than those things, there are also a lot of changes in Calcite that require adjustments on the Druid side.

@gianm - there is already a draft PR that you could work off - https://github.com/apache/druid/pull/12258

Thanks @abhishekagarwal87. I did indeed start from your PR as a base.


release 2.0.0

next dev version: 2.1.0-SNAPSHOT
Thanks!

2.0.0 has been released. Also Maven Central staging repository is released, synching to maven central release takes a while.


Update to raven 3.1.1

Hi, just to let you know that the currently version of rave is 3.1.1 and contains some bug fixes.

thanks!


can’t download album

can’t download album

Hello! Why? What error you got which branch are you using? Contact me via @masterolic at telegram masterolic.t.me

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Track had been successfully downloaded
The reason for 500 raised from telegram that you had filled the variable LOG_CHANNEL where the bot does not have rights to send message make sure the value is empty or not is admin in that chat

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Track had been successfully downloaded
The reason for 500 raised from telegram that you had filled the variable LOG_GROUP where the bot does not have rights to send message make sure the value is empty or not is admin in that chat

The LOG_GRAOUP value is always empty，the single track can be downloaded successfully，but the album can not，it just downloaded one track from the album and then stopped。

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Track had been successfully downloaded
The reason for 500 raised from telegram that you had filled the variable LOG_GROUP where the bot does not have rights to send message make sure the value is empty or not is admin in that chat

The LOG_GRAOUP value is always empty，the single track can be downloaded successfully，but the album can not，it just downloaded one track from the album and then stopped。

Yes you are right bro :(
Just right now noticed forgotten to skip log method for None value thanks for bringing to  us
Don't hesitate to report again  any issues :(❣

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Track had been successfully downloaded
The reason for 500 raised from telegram that you had filled the variable LOG_GROUP where the bot does not have rights to send message make sure the value is empty or not is admin in that chat

The LOG_GRAOUP value is always empty，the single track can be downloaded successfully，but the album can not，it just downloaded one track from the album and then stopped。

Yes you are right bro :(
Just right now noticed forgotten to skip log method for None value thanks for bringing to us
Don't hesitate to report again any issues :(❣

Thanks for fixing,it's now perfect!

Hello! Why? What error you got which branch are you using? Contact me via @Masterolic at telegram https://masterolic.t.me

Two Branches are the same，It just downloads one song of the album and shows “telegram says 500 error,so please try again later”，even if I ldownloads a single track，the error still exists

Track had been successfully downloaded
The reason for 500 raised from telegram that you had filled the variable LOG_GROUP where the bot does not have rights to send message make sure the value is empty or not is admin in that chat

The LOG_GRAOUP value is always empty，the single track can be downloaded successfully，but the album can not，it just downloaded one track from the album and then stopped。

Yes you are right bro :(
Just right now noticed forgotten to skip log method for None value thanks for bringing to us
Don't hesitate to report again any issues :(❣

Thanks for fixing,it's now perfect!

Welcome


Merge 1.0.x branch to master branch for the identity-extension-utils repo

The active branch of the identity-extension-utils https://github.com/wso2-extensions/identity-extension-utils repo is the 1.0.x and the master branch have not been updated for last 3 year ago.
We need to validate why the master branch is not active, and possibility to merge 1.0.x branch to master branch

The dependency updater is failing due to this repo verion bump as the master branch have higher version than 1.0.x. branch, and trying to bump the versions from master, but the active branch is 1.0.x


Rotation issue in with Proper scroll example

The cells are not rotated properly when i am using your configuration for Proper scroll
  [circularLayout setStartAngle:M_PI endAngle:0];
 circularLayout.mirrorX = NO;
 circularLayout.mirrorY = YES;
can u guide me in this

What do you mean by not rotated properly. Can you attach some screen shot as a reference and explain what is expected and actual outcome?

the way you shared screenshot of example for Proper scroll the other cells are not rotated properly when i use above configuration
basically circularLayout.rotateItems = YES; is not working properly see the angle of 3 and 5

Got it. I fixed it. Can you take the latest pull and check.

Thanks bro, for a quick response really appreciate your work
Can u help i am trying to show only three cells a time the way you did when
first time you load collectionview,
But when i scroll the collection and when it halts it can show 4 cells,
I want only 3 cells at a time even when user scroll . Thnks in advance
On Tue, Feb 28, 2017 at 6:13 PM, Dodda Srinivasan<EMAIL_ADDRESS>wrote:

Got it. I fixed it. Can you take the latest pull and check.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DoddaSrinivasan/DSCircularCollectionView/issues/1#issuecomment-283029325,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHIlzKpIfrP0Fh186lYIFonXedzXaZWmks5rhBZygaJpZM4MOMqP
.


Logger updates

Edits console logger such that various properties can be output in an error or warning message. The properties are determined by an item "outputProperties" defined by the project. Ex:
Program.cs(14,13): error CS0103: The name 'Consol' does not exist in the current context [C:\Users\t-laprin\source\repos\tester_app\tester_app\tester_app.csproj SchemaVersion:2.0 TargetFramework:netcoreapp3.0 ]
I don't have write permission to Link an issue to this, but this would be the issue it should link to: https://github.com/microsoft/msbuild/issues/3015

Wouldn't it be better if the engine computed this string, rather than a specific logger? If loggers are responsible for computing it, then everybody who writes a logger has to duplicate this logic. If the engine computes it, then it's in a single place.
ProjectStartedEventArgs can hold the computed string for the project instance it represents. The LoggingService can hold the string cache to avoid recomputations and LogProjectStarted would compute it.

ProjectStartedEventArgs can hold the computed string for the project instance it represents. The LoggingService can hold the string cache to avoid recomputations and LogProjectStarted would compute it.

This is a nice design, I think.

Taking it even further, it could even be a property of ProjectInstance and / or Project. This would help all the tools out there to provide this info in their UIs. ProjectStartedEventArgs would enable loggers to display it, ProjectInstance/Project would enable msbuild API users to display it (Visual Studio, QuickBuild, dotnet CLI?, etc).

Maybe, but right now I think I prefer leaving it at the logging level (in the event).

Talked this over with @laurenprinn and others. I like pushing it to the LoggingService, but that doesn't solve the whole problem, because it's only easy to do that for the ProjectStarted event. When logging, though, we'll really want this for errors/warnings/messages, too. So the logger would still have to preserve/restore it.
We could add it to a deep base class like BuildEventContext or LazyFormattedBuildEventArgs, but that would potentially spend a fair amount of memory for minimal benefit when using other loggers (like the VS logger).
So let's go with this implementation for now and we can potentially improve it further in the future.


Add iterator support to cosmwasm-storage

Builds on #249
This enables a fully-functional cosmwasm-storage.
Done:

[x] Update with new returns from #246
[x] Add range to (Readonly)PrefixedStorage
[x] Test prefix range, including edge cases
[x] Add typed range to (Readonly)TypedStorage
[x] Add typed range to (Readonly)Bucket

Logic is implemented, I am waiting on #246 to rebase and finish

Made some requested simplifications. Yes, no need for paranoid-programing, we have tested the code this relies on.
Please merge if you approve it.


ENS setup for IPNS (PoC)

Tasks

[ ] Implementation of contract interaction in FE

References

Product doc

POC flow:
Use wagmi  usePrepareContractWrite hook to interact with ENS Set Contenthash method.
Ref:

Use content-hash package to encode ipns hash to Set Contenthash function input


Any plan to upgrade AsyncAPI plugin for  IntelliiJ IDEA 2020.3?

Now AsyncAPI plugin just for IntelliJ IDEA 2020.2, and most developers have upgraded their IDEA to 2020.3, To be compatible with IntelliiJ IDEA 2020.3 is some important, thanks.

@linux-china hi.
Did you check it with 2020.3 and faced with issues?

Now AsyncAPI plugin just for IntelliJ IDEA 2020.2, and most developers have upgraded their IDEA to 2020.3, To be compatible with IntelliiJ IDEA 2020.3 is some important, thanks.

Looks like it's compatible till 2020.4

@Pakisan, it's  2020.2.3 — 2020.2.4,  not 2020.2 — 2020.4  from https://plugins.jetbrains.com/plugin/15673-asyncapi/versions/eap

@linux-china yes. You are right. I thought about 2020.2.3 release not about new 2020.3 which allows only Java 11

Can you check it - https://github.com/asyncapi/java-asyncapi/releases/tag/idea-EAP-1?
For me looks ok. Checked on 2020.3.1

@Pakisan  it works well now. I have installed it from local disk, and I think you can upload it to the plugin central.

@linux-china new version was uploaded to plugins central. Will be available in a few business days because of review. Currently available via https://plugins.jetbrains.com/plugin/15673-asyncapi/versions/eap/107189

@linux-china new version was uploaded to plugins central. Will be available in a few business days because of review. Currently available via https://plugins.jetbrains.com/plugin/15673-asyncapi/versions/eap/107189

@Pakisan  thanks :)

@Pakisan  thanks :)


Implement new replacedBy dart fix for current and prior deprecations

The dart fix has a new feature, replacedBy. This allows us to make transformations across classes.
The feature resolved https://github.com/dart-lang/sdk/issues/45393, which has some example use cases.
We should implement this for current deprecations, and check to see if any past deprecations that have already been removed can be supplied a fix.
⭐  It has not been confirmed that we can provide fixes for these, but they should each be investigated. Some may still be too complex to reliably migrate, or may not provide a better experience to the developer if it can only partially be fixed.
Might be able to fix, will check them off as they are investigated:

Old API
New API

✅
DayPicker
CalendarDatePicker

✅
MonthPicker
CalendarDatePicker

✅
FlatButton
TextButton

✅
OutlineButton
OutlinedButton

✅
RaisedButton
ElevatedButton

Scaffold.[snackbars]
ScaffoldMessenger.[snackbars]

BlacklistingTextInputFormatter
FilteringTextInputFormatter

WhitelistingTextInputFormatter
FilteringTextInputFormatter

CupertinoNavigationBar.actionsForegroundColor
CupertinoTheme.primaryColor

CupertinoSliverNavigationBar.actionsForegroundColor
CupertinoTheme.primaryColor

ButtonTheme.bar
ButtonBarTheme

These are just the ones I thought of or saw might be possible from the ones we have announced. If anyone can think of others, let us know and we'll add them to the list!

Related dart fix feature requests:

#47945
#47944
#47943
#47941

The button and Month/Date picker migrations were not possible with replacedBy, they were still too complex to create a transformation of code that would actually be helpful to the user.
I feel the SnackBar one is similar, since many folks save a reference, use a key, or chain off of .of(context) to use that API. I don't think dart fix can reliably catch these, but it is still worth checking.
The remaining ones to explore are listed above. I am not currently working on this, so I am going to un-assign myself.
@TahaTesser has been exploring fixes, do not feel obligated to work on this. Just an FYI in case you are interested as part of your fix library. :)


Idle manager with separated logic

Changes

logic of idle manager was separated to separate file

the logic and python module pynput is imported only when needed

renamed file idle_manager.py to idle_module.py

Timer turns off fine, but no pop up shows. I smell something fishy in here ;)

I smell something fishy in here ;)

Me either. Issue was that it didn't expect multiple callbacks at the same time which may happen only if message time is really small. Fixed...


I am making a Google Logo

Hi. The issue for the Google logo has already been created. If you wish to work on any other art, please feel free to open new issues.


do the phedex recovery block by block

With too many block/files in the recovery attempt, the call to the PhEDEx data service can time out (as it did for a recent example where we had 2500 blocks with a total of 38k files). Split it to run block by block. Recovery should be rare, we don't care about doing it fast.

@ticoann please review. Not sure how to test this. I hot-patched the production Tier0 where we had this problem, but not with this exact same patch (patched in place, then re-wrote the same patch again from memory for the pull request).

Hi Dirk, Patch looks good to me. I made a comment for a minor thing which I am not sure it is necessary.
For the test, we can add some unittest for existing files in PhEDEx but I think if we test normal case in the agent test, it should be OK. I will first test that. Thanks,

I guess this is a bit on the back burner now with all the other problems...

@hufnagel, Dirk do you want me to merge this one? I will create a new tag tomorrow.

Not urgent, as the production Tier0 is hot-patched and this is not really relevant for the replay instances. Merge at your convenience...


Wrong code generated for "Subscribe" method calls in obscure case

Originally opened at CodePlex by tomasp
For more information see this StackOverflow question.
I'd say that this is a bug which happens specifically with the Subscribe method of IObservable. Since F# treats events automatically as  IObservable values, it has some special handling for them and it adds Subscribe method. If there is a Subscribe extension declared elsewhere, it clashes and things break.
The easiest repro I could find is to create a C# project with:
public static class Extensions {
  public static void Subscribe(this IObservable<int> c1, Action<int> f) {
    f(1);
    f(2);
  }
}

And then do exactly what you did:
let partial() =
  printfn "called"
  fun n -> ()

let a = new Event<int>()
let o = a.Publish.Subscribe(partial())
111

This prints "called" twice, while it should really be called just once.

comments
NikonTheThird wrote Aug 7, 2014 at 11:49 AM [x]
Hello, here is some code that displays the issue with the Action<'a> delegate:
open System
open System.Threading

let callThrice (action : Action<_>) =
    for i = 0 to 2 do
        action.Invoke ()
        Thread.Sleep 500

let makeHandler () =
    let count = ref 0
    fun () -> printfn "Count: %d" !count
              incr count

let try1 () =
    printfn "try1"
    let handler = makeHandler ()
    callThrice (Action<_> handler)

let try2 () =
    printfn "try2"
    callThrice (Action<_> (makeHandler ()))

try1 ()
try2 ()
printfn "Done"
Console.ReadKey true |> ignore

try2 prints only zeros.

Simplified repro all in F#. The delegate creation implied by "partial()" needs to be amortized.
module Extend =
    [<System.Runtime.CompilerServices.ExtensionAttribute>]
    type Extensions() =
       [<System.Runtime.CompilerServices.ExtensionAttribute>]
       static member Subscribe(this : System.IObservable<int>, f: System.Action<int>)  =

          f.Invoke(1);
          f.Invoke(2);

open Extend

let partial() =
  printfn "called"
  fun n -> ()

let a = Event<int>().Publish
let o = a.Subscribe(partial())

I am going to close this as "Wont Fix".  This is an exceptionally corner-case bug and it is really quite hard to fix.


feat(client) plug-in message tracing  feature

What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

some exception caused by the ons-trace-core latest version hasn't been released, so merge it first and wait for the ons-trace-core plugin release.


CAPSTONE SETTINGS

https://github.com/Gopxfs/capstone-2/projects/1
Our team has two members: @Gopxfs & @jevazquezb.

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Unexpected restart when installing Calibre

Brief description of your issue
After updating Calibre the computer restarted
Steps to reproduce
winget upgrade calibre

computer suddenly restarts without any warning
from event viewer:
The process msiexec.exe has initiated the restart of computer  on behalf of user NT AUTHORITY\SYSTEM for the following reason: No title for this reason could be found
 Reason Code: 0x80030002
 Shutdown Type: restart
 Comment: The Windows Installer initiated a system restart to complete or continue the configuration of 'calibre 64bit'.

Expected behavior
At least some kind of warning would be nice
Actual behavior
Not to have a sudden restart out of the blue
Environment
[winget --info]
Windows Package Manager v1.0.11694
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22000.168
Package: Microsoft.DesktopAppInstaller v1.15.11694.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
--------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget

Take a look at #229 and #994 I think one or both of those apply here. It's also possible the installer is actually doing the reboot, and we may not be able to prevent it.


VTK models are not shown in the docs

This was detected also in PyMAPDL long ago. We should probably coordinate on this.
https://github.com/pyansys/pymapdl-examples/issues/80

Duplicate of #80


BHBC-900: Initial project view components

Overview
Links to jira tickets
https://quartech.atlassian.net/browse/BHBC-900
This PR contains the following changes

Moved ProjectPage.tsx to projects/view folder
Updated ProjectPage.tsx to align with initial designs
Added placeholder components for the details, surveys, attachments content
Added util for creating formatted date strings
Added tests

This PR contains the following types of changes

[x] New feature (change which adds functionality)
[ ] Enhancement (improvements to existing functionality)
[ ] Bug fix (change which fixes an issue)
[ ] Misc cleanup / Refactoring / Documentation
[ ] Version change

Checklist
A list of items that are good to consider when making any changes.
Note: this list is not exhaustive, and not all items are always applicable.
General

[x] I have performed a self-review of my own code

Code

[ ] New files/classes/functions have appropriately descriptive names and comment blocks to describe their use/behaviour
[ ] I have avoided duplicating code when possible, moving re-usable pieces into functions
[ ] I have avoided hard-coding values where possible and moved any re-usable constants to a constants file
[ ] My code is as flat as possible (avoids deeply nested if/else blocks, promise chains, etc)
[ ] My code changes account for null/undefined values and handle errors appropriately
[ ] My code uses types/interfaces to help describe values/parameters/etc, help ensure type safety, and improve readability

Style

[ ] My code follows the established style conventions
[ ] My code uses native material-ui components/icons/conventions when possible

Documentation

[ ] I have commented my code sufficiently, such that an unfamiliar developer could understand my code
[ ] I have added/updated README's and related documentation, as needed

Tests

[ ] I have added/updated unit tests for any code I've added/updated
[ ] I have added/updated the Postman requests/tests to account for any API endpoints I've added/updated

Linting/Formatting

[ ] I have run the linter and fixed any issues, as needed
See the lint commands in package.json
[ ] I have run the formatter and fixed any issues, as needed
See the format commands in package.json

SonarCloud

[ ] I have addressed all SonarCloud Bugs, Vulnerabilities, Security Hotspots, and Code Smells

How Has This Been Tested?
Locally + unit tests.
Screenshots

Also, resolved the code smells ... mostly TODO's, but the file upload was high in cognitive complexity.  I resolved it as 'won't fix' since we're going to be making significant changes to that code in the near future.


Workspace - Newly created workspace does not appear in workspace list on second device

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to staging.new.expensify.com with the same account on two devices
On the first device, create a new workspace
On the second device, go to Settings > Workspace

Expected Result:
The newly created workspace will appear on the second device
Actual Result:
The chat room for the newly created workspace appear on LHN on the second device, but not on the workspace list
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.55-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/a8137d42-dbb3-4dcc-847f-9516b91fe35c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This issue is the regression of this PR.
When we create a workspace, we optimistically set isPolicyExpenseChatEnabled: true but the pusher events doesn't include this value.
This is the root cause
We can revert the PR but I think this should be fixed in the backend

@Nikhil-Vats
Did you pull the latest changes? It's still reproducible for me on main

Assigning over to @youssef-lr since he already has a PR up for this.

This has been deployed.


Koin crash: kotlin.native.internal.IrLinkageError: Can not get instance of singleton 'Companion': No class found for symbol 'kotlin.uuid/Uuid.Companion|null[0]'

KMPNotifier and Kotlin version:
kmpnotifier version: 1.3.0, kotlin version: 2.0.0
Everything works fine on kmpnotifier version: 1.2.1
Describe the bug
I got exactly this crash on ios: https://github.com/InsertKoinIO/koin/issues/1985
Android works fine with the same code.
kotlin.native.internal.IrLinkageError: Can not get instance of singleton 'Companion': No class found for symbol 'kotlin.uuid/Uuid.Companion|null[0]'
Function doesn't have or inherit @Throws annotation and thus exception isn't propagated from Kotlin to Objective-C/Swift as NSError.
It is considered unexpected and unhandled instead. Program will be terminated.
Uncaught Kotlin exception:     at 0   ios staging.debug.dylib             0x10caede63        kfun:kotlin.Throwable#<init>(kotlin.String?){} + 119
    at 1   ios staging.debug.dylib             0x10cae714b        kfun:kotlin.Error#<init>(kotlin.String?){} + 115
    at 2   ios staging.debug.dylib             0x10cb2408b        kfun:kotlin.native.internal.IrLinkageError#<init>(kotlin.String?){} + 115
    at 3   ios staging.debug.dylib             0x10cb24143        kfun:kotlin.native.internal#ThrowIrLinkageError(kotlin.String?){}kotlin.Nothing + 163
    at 4   ios staging.debug.dylib             0x10cee1d13        kfun:org.koin.mp#generateId__at__org.koin.mp.KoinPlatformTools(){}kotlin.String + 63

I've seen that v.1.3.0 uses koin 4.0 so I guess that's it https://mvnrepository.com/artifact/io.github.mirzemehdi/kmpnotifier/1.3.0
I'm using older koin 3.5.6 in the app itself.
In which platform bug occurs?
ios only
To Reproduce
Open app with koin + kmpnotifier version: 1.3.0
Expected behavior
No crash

@szczepanski-k Using koin version 4.0.0, and kotlin version 2.0.20 should fix this issue. There should be a binary incompatibility between 3.5.6 and 4.0.0 koin versions

Ok we can close the issue for now. I'll downgrade kmpnotifier for now and try to upgrade versions later on. I'll post a comment if it worked or not


Allows running demo on device by embedding binaries

You would still need to set a Team in order to run on device, but this commit fixes the "image not found" issue. See https://stackoverflow.com/questions/24333981/ios-app-with-framework-crashed-on-device-dyld-library-not-loaded-xcode-6-beta

Looks great. Thanks a lot for your work :+1:


Callback E-Wallets

Setting untuk callback sukses melalui e-wallet tidak masuk

Hello @husna3305, apologies for the trouble and the late response. We're keeping issues on GitHub reserved for active bugs and feature requests for our PHP SDK, so we encourage you to have a look at our Docs (https://docs.xendit.co/) or ask for help through our help page https://www.xendit.co/en/contact/. Cheers and sorry we couldn't be of help~


Add a terms of service page to the frontend

Description

We presently have terms of service defined for our API here: https://docs.openverse.org/terms_of_service.html
We recently received an external request for information about the terms of service for our frontend. While the question came in the context of scraping our data from the frontend, it would be useful for us to establish a document similar to the one for our API which specify the terms of use we're expecting there as well. Many of the same conditions could apply in the cases where it makes sense to.
Additional context

Might be related to #2171

It may be easiest for us to make the existing ToS more generic and then link to it from the About page rather than setting up a separate page for it (and having to manage two documents, plus translations).

then link to it from the About page

Might be good to check this, but ToS might not be binding if a link to it isn't prominent on every page it could pertain to... I read some stuff recently about this with respect to licencing. Definitely should check with lawyers if we can, just to be sure, but would like to avoid a case where someone has plausible deniability because they didn't check for the ToS in a specific sub-page of the site.

Ah, that's a very good point. I'll poke around and see if I can get an answer for this!

It seems like from a few sources^1, linking the ToS in our footer or some other location where it's visible on each page is the best bet.

We might also show a frontend banner that we've added the ToS and link to it (like we do for analytics and incomplete translations), but that makes a total of 3 banners for a new user which is potentially bad UX and might need @fcoveram to chime in.

I don't think a new banner is necessary. So long as we have a ToS, if we find someone scraping we have something to point to saying why we blocked them. Even if they didn't see it, that doesn't mean the ToS isn't in effect, right? Most users will not care about the ToS, so putting in front of everyone feels very heavy.

I think it's important to communicate changes to the ToS to existing users. IANAL but I would likely be against a service changing the terms of service that I originally agreed to without letting me know they had changed.
We also write in our ToS that we will make reasonable efforts to communicate changes to the existing users.

If we change the ToS to affect API users, we should send an email to the registered users. It isn't possible to send an email to frontend users (just clarifying in case others aren't aware we don't have information on frontend users). I know this isn't necessarily a "good" example (not sure if we want to follow this company, but there are others I could find), but AirBnb recently sent me an email as a user telling me they updated their terms of service (I got that email on 29 Jan my time). However, there's nothing on their website to indicate that change, other than the policy documents themselves indicating the last time they were changed.

we will make reasonable efforts to communicate changes to the existing users

I think the email would suffice for that if the change affects API users, but that it is not reasonable to expect us to try to alert every single user of the Openverse.org website, where we have no way of identifying existing vs new users, especially considering the volume of banners we already have and the significant interruption an interstitial modal would be (particularly to new users, who truly wouldn't be affected by it at all).
Just my perspective though. If we're worried about sticking to our obligation to make reasonable effort, we should consult legal folks.

We have the opportunity to rearrange the pages shown in the header to make it more simple and congregate related content into single pages. For instance, content related to the project's purpose and how it is approached can be displayed in one page, whereas the two terms of services discussed here and "Privacy" can live in different ones.
Here is a quick draft I shared internally with some folks.

And the new page structure goes like this:

About

History (new)
Licenses = Brief description and link to CC licenses (external)
Sources = Sources table and link to suggest new ones
Search help = Syntax guide
Get involved = Link to Handbook and User feedback

Get involved ↗ (external)
API ↗ (external)
Terms of Service

API
Frontend

Privacy

As you can see, the main idea is to make the brand more visible and introduce the project in a friendly way where users dive into details as they scroll. The page is easy to share as it explains everything people need to know what Openverse is about.
I'd like to polish it more and work on a better visual for the cover. Since all current content is text-heavy, we could include visuals or play with styles in specific sections to ease the reading. In the meantime, if we need to display a new ToS before agreeing on a design, then adding a new link in the current header is fine. We can prioritize the design implementation once we have it.
Question: Regarding changes in the ToS, does it make sense to consider a changelog in the page itself and have access to previous versions?

That sounds and looks great Francisco! One note on the ToS - it's currently on our documentation site: https://docs.openverse.org/terms_of_service.html. In the example you posted, we have separate sections for API & Frontend. Would it be sufficient just to have an external link for it similar to Get involved?

Question: Regarding changes in the ToS, does it make sense to consider a changelog in the page itself and have access to previous versions?

We can update the ToS page in our documentation to include a changelog potentially, that might be the easiest way of surfacing that information.

Oh, I see. I understood something different. I don't see sections for API & Frontend in the doc page, unless it's written in the content I quickly skimmed.

That's right, currently the ToS is intended to cover both services (based on the changes made in #3586).
And that update works great! Terms seems perfect.

@fcoveram I've created a PR for the small change necessary to add it into the existing navbar in #3727. Do you think it would be best to convert this ticket to a navbar redesign, or make a separate issue for some of the proposals you've made?

A separate issue. I will create a design ticket once I have a proposal to discuss, that's why I added the design: needed label.

Regarding changes in the ToS, does it make sense to consider a changelog in the page itself and have access to previous versions?

This is not the best UX or the most user-friendly but the simplest approach to this would be to point to the GitHub history of the file containing the ToS. That would capture every possible information for even the smallest change.

That idea works @dhruvkb and gives us room to improve it later if we think it's necessary.


0.2.0 linux is not yet released on conda

As listed here https://anaconda.org/soumith/torchvision/files.
Seems that only osx-0.2.0 is released but not linux-64 one.
Can you please release it so I can install it using conda?
thanks

conda install torchvision -c pytorch
We switch from soumith channel to pytorch channel.


Rviz extremely slow when showing grid maps

Hi, I don't know if I am missing a depency or something, but the grid map displays slows down Rviz to 1fps, even when the map is small. Octomaps on the other hand are ploted in 30fps like always.
Using the simple demo as example. I can see the octomap generated from the grid map in 30fps, but enabling the grid map message immediatly brings the fps to 1. Rostopic hz on the grid map message gives me ~20hz. Also, the 'surface normals' and 'elevation cells' topics are not published. My guess is I am missing something, but the dependencies looks right (rosdep says it's ok), make does not give any errors or warning. I tried on a clean Ubuntu 14.04 with ROS Indigo to be sure and the same thing happened.
Were there changes to grid map rviz plugin? Am I missing a package? Or is this how it was supposed to be?

When you're building the package, make sure you use -DCMAKE_BUILD_TYPE=Release. Mine was updating at around 0.25 hz before I remembered to set the cmake flag.

YES! THANK YOU VERY MUCH! That was it! From <1 to 30 fps
Closing the issue


Add command to dump template variables

See http://discuss.gohugo.io/t/the-never-ending-confusion-over-variables/804/10

Not sure on what level this should be performed, site, page?
Reflection should be able to read out the exported fields and funcs in a template context

I thought that we could write a for loop in the template to iterate through all the values in . and dump the values as needed. I added two functions in PR #1026 to help:

"inspect" is similar to printf "%#v".
"typeOf" returns the type of a variable or value.

Future thoughts - given how fast Hugo is, would it be possible to have a template hiding on the back end that did a pretty print of the current environment and passed that through CSS to float a window that displayed the results in a navigable hierarchy?

Yes - that's a good idea ... but since the current context is perg page/node, it should be some kind of DebugWrapper around each html file.


Assorted linting fixes.

Remove unused code.
Use copy instead of a loop where appropriate.
Don't pass nil contexts ever.
Remove unneeded nil check for slice.

/lgtm
/approve


python310Packages.effect: fix build

Description of changes
Fix build (https://hydra.nixos.org/build/207467949)

add changelog to meta
disable on older Python releases
add pythonImportsCheck

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 216022 run on x86_64-linux 1

2 packages built:

python310Packages.effect
python311Packages.effect


Add Operations in inventory explorer presentation

Add Operation model
Present operations in explorer associated with resources

@pilhuhn Any further change needed form this PR?

@pilhuhn Already corrected in next Work. Will be hard if I correct back in this one


Add list of predefined colormaps to docs

A list of the colormaps defined by Color.jl (or a link to the Color.jl docs) should be included in the Colormaps doc page.

slangangular@979c30a79e79bf505d8874b11e1a09a3df6385b3

@slangangular Mind if I create a PR for the various documentation-related commits you've made over the past month?

I'm sorry, I thought I had done that. Here it is: #217


Schemas from src/resources/org/jpeek/xsd must be referenced in generated XMLs

Subj. First discussed in #133.
We need to make references to the schemas explicit in generated XML documents. This will bring transparency in semantics of the generated XML files and will make their support easier.

The job #135 assigned to @llorllale/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

@yegor256 can I take the liberty to define namespaces for these schemas? I was thinking of using this for metric.xsd: http://www.jpeek.org/2018/schema/metric

My notes:

Importing Schemas with No Namespaces

@llorllale let's use the schema without a namespace, it will be easier for everything

@0crat status

@0crat status (here)

@llorllale This is what I know about this job, as in §32:

The job #135 is in scope for 19days
The role is DEV
The job is assigned to @llorllale/z for 4days
There is a monetary reward attached
@llorllale/z will get 50% of their hourly rate for this job
The job doesn't have any impediments
The budget is 30 minutes/points
These users are banned and won't be assigned:

@skapral/z: This user reported the ticket

Job footprint (restricted area)

@llorllale/z this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat waiting

@0crat waiting (here)

@llorllale The impediment for #135 was registered successfully by @llorllale/z

@yegor256 can we close this?

Reference to metric.xsd in metric.xml was added in PR #196)
Puzzle #227 left to refactor the above towards a simpler solution
Puzzles #224, #225, and #226 left for adding references to the rest of the XSDs

@llorllale thanks

@ypshenychka/z please review this job, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat quality good

QA review completed: +8 points just awarded to @ypshenychka/z

Order was finished, quality was "good": +35 points just awarded to @llorllale/z

@skapral 3 puzzles #224, #226, #227 are still not solved; solved: #225.

@skapral 2 puzzles #224, #227 are still not solved; solved: #225, #226.

@skapral 2 puzzles #224, #327 are still not solved; solved: #225, #226, #227.

@skapral the puzzle #327 is still not solved; solved: #224, #225, #226, #227.


Implementation 'inherit_members' for creating project

Hello,
Can you implement inherit_members option for creating project ?
Regards,
Julien B.

clarification: I see "inherit_members" option in Redmine web UI plus it is also documented here: http://www.redmine.org/projects/redmine/wiki/Rest_Projects
let's see if anyone is willing to submit a patch for this.


Housekeeping updates for .NET 8 GA

Contributes to #34171

Internal previews
Toggle expand/collapse

📄 File
🔗 Preview link

api/index.md
.NET API browser

docs/architecture/grpc-for-wcf-developers/application-performance-management.md
Application Performance Management - gRPC for WCF Developers

docs/architecture/maui/unit-testing.md
Unit testing

docs/architecture/microservices/multi-container-microservice-net-applications/background-tasks-with-ihostedservice.md
Implement background tasks in microservices with IHostedService and the BackgroundService class

docs/architecture/porting-existing-aspnet-apps/deployment-scenarios.md
docs/architecture/porting-existing-aspnet-apps/deployment-scenarios

docs/core/compatibility/8.0.md
Breaking changes in .NET 8

docs/core/compatibility/aspnet-core/8.0/trimmode-full.md
TrimMode defaults to full for Web SDK projects

docs/core/compatibility/containers/8.0/multi-platform-tags.md
"Breaking change: Multi-platform container tags are Linux-only"

docs/core/compatibility/interop/8.0/safehandle-constructor.md
SafeHandle types must have public constructor

docs/core/compatibility/sdk/8.0/arch-option.md
docs/core/compatibility/sdk/8.0/arch-option

docs/core/compatibility/sdk/8.0/console-encoding.md
CLI console output uses UTF-8

docs/core/compatibility/sdk/8.0/version-requirements.md
"Breaking change: Version requirements for .NET 8 SDK"

docs/core/compatibility/winforms.md
Breaking changes in Windows Forms for .NET Core 3.0 and 3.1

docs/core/deploying/native-aot/index.md
Native AOT deployment

docs/core/deploying/trimming/prepare-libraries-for-trimming.md
docs/core/deploying/trimming/prepare-libraries-for-trimming

docs/core/extensions/timer-service.md
Implement the IHostedService interface

docs/core/extensions/windows-service.md
Create Windows Service using BackgroundService

docs/core/extensions/workers.md
Worker services in .NET

docs/core/install/macos-notarization-issues.md
docs/core/install/macos-notarization-issues

docs/core/porting/index.md
Overview of porting from .NET Framework to .NET

docs/core/tools/dotnet-new-details.md
dotnet new details

docs/core/tools/nuget-signed-package-verification.md
NuGet signed-package verification

docs/core/tutorials/cli-templates-create-template-package.md
Tutorial: Create a template package

docs/core/tutorials/debugging-with-visual-studio-code.md
docs/core/tutorials/debugging-with-visual-studio-code

docs/core/whats-new/dotnet-8.md
What's new in .NET 8

docs/csharp/whats-new/csharp-12.md
What's new in C# 12 - C# Guide

docs/standard/frameworks.md
Target frameworks in SDK-style projects

docs/standard/native-interop/qualify-net-types-for-interoperation.md
Qualify .NET types for COM interoperation

docs/standard/net-standard.md
docs/standard/net-standard

docs/standard/serialization/system-text-json/customize-properties.md
How to customize property names and values with System.Text.Json

Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

Thanks for reviewing @BillWagner!


Add information on image size limits and how to make them smaller

Feedback is welcome. Anything I should add (or remove)?

Well-written explanation and tips for for Rahti's end-users.


CI for Node

Following tests are failing: Contains the compiled JavaScript, Initializes with two players, Starts the game with a random player, Sets the current player to be whoever it is not


Enable use of wasm-pack with panic_immediate_abort

I'm trying to enable panic_immediate_abort in order to get smaller wasm size (see https://github.com/rust-lang/rust/issues/54981).  The workflow is to create a Xargo.toml file:
[dependencies]
std = {default-features=false, features=["panic_immediate_abort"]}

However, I can't figure out how to invoke xargo when using wasm-pack build.  I can run xargo build --target wasm32-unknown-unknown --release, which I assume puts the output in the target directory without compiling it to the pkg directory, but then wasm-pack build just overwrites the target directory again with the non-xargo build.

I think being able to use xargo instead of cargo has more general uses as well and has to be supported. For example, using wasm32 simd extensions is currently unstable and requires recompiling libcore in order to enable them so in order to take advantage of these in WebAssembly, one has to recompile libcore, typically done by xargo.

Note that it's no longer needed to use xargo, since build-std is now a part of Rust itself (nightly only):
wasm-pack build --release -- -Z build-std=std,panic_abort

This works for enabling simd as well. You simply create a .cargo/config file in your project which contains this:
[build]
rustflags = ["-C", "target-feature=+simd128"]


[HOTFIX] Removed required attribute from checkout manager fields when activated

Closes #316

Hotfix merged without review...

🤔

Well, I hope it's ok. I'll test it tomorrow.


Projects don't load.

When I try to open this solution in VS2017 15.5.7 the Presentation and Services projects don't load. I get the error missing Microsoft.Net.Sdk.Web if I try to reload them. It's definitely there. The other projects show numerous errors when trying to build them - missing core libraries. I definitely have the latest Core installed. Any ideas? Thanks

Found the solution - I had to remove the content of the global.json file and reload the projects, which updated all the targets and fixed everything.

This is the best solution?


Add multi line text

@ajpmaclean : : Please review.

@ajpmaclean : Indentation fixed. No extra .txt files. Please review.

Thanks


Test 2 of new bookplates since 8/28/2023

Test the "new" bookplates added since 8/28/2023:

[x] Clear out the digital_bookplates table following instructions in the README.
[x] Deploy latest libsys-airflow code to dev
[x] Unpause the fetch_digital_bookplates and digital_bookplate_instances DAGs
[x] Trigger the fetch_digital_bookplates DAG (when it completes it will trigger the digital_bookplate_instances DAG)
[ ] Write up any bug tickets

fetch_digital_bookplates took 41 minutes to run. It successfully triggered dag runs for digital_bookplate_instances. It doesn't look like the paymentDate query for invoices is correct, though. For the dag runs created by the previous dag, the paymentDate should be 2023-08-28 but the logs for the invoices_paid_within_date_range task show
[2024-10-15, 20:38:49 UTC] {invoices.py:123} INFO - Querying paid invoices with paymentDate >= 2024-10-02 09:00:00+00:00
[2024-10-15, 20:38:49 UTC] {_client.py:1038} INFO - HTTP Request: GET https://okapi-test.stanford.edu/invoice-storage/invoices?query=%28%28paymentDate%3E%3D2024-10-15%2020%3A29%3A30.890209%2B00%3A00%29%20and%20status%3D%3D%22Paid%22%29&limit=500&offset=0 "HTTP/1.1 400 Bad Request"

Bug ticket: https://github.com/sul-dlss/libsys-airflow/issues/1281

Bug ticket: https://github.com/sul-dlss/libsys-airflow/issues/1282


⚠ ClamAV has degraded performance

In b987655, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in 2be41f0.


More WebDataset docs

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq what's there is fine, wds examples are simple, appear correct.
Two comments that can be addressed in follow up additions

Why no example using datasets to stream the wds shards? It does work, but as discussed needs the http streaming fix to be similar to webdataset + curl, and needs distributed improvements
The webdataset example covers the in-order most basic case, and simple shard + sample shuffling cases. Distributed training, epoch based training, shard resampling with replacement use cases could also be documented at some point, though they get quite a bit more complex to cover the nuances as you can see in timm or open_clip code...

Thanks !

Why no example using datasets to stream the wds shards? It does work, but as discussed needs the http streaming fix to be similar to webdataset + curl, and needs distributed improvements

it will be in the datasets docs :)

The webdataset example covers the in-order most basic case, and simple shard + sample shuffling cases. Distributed training, epoch based training, shard resampling with replacement use cases could also be documented at some point, though they get quite a bit more complex to cover the nuances as you can see in timm or open_clip code...

Definitely ! That's the next step ^^ Btw if you have some good references on this that would be helpful

Merging for now, but lmk if you have more comments


Double dotted line on abbreviations

On https://markdown-it.github.io/, abbreviations have a double dotted line on Chromium. This seems to be due to type.less and bootstrap.css doing:
abbr[title] {
    border-bottom: 1px dotted;
}

Whereas my user agent stylesheet is doing:
abbr[title], acronym[title] {
    text-decoration: underline dotted;
}

Those are different ways of putting a dotted line under the text and they appear in different positions. Actually, the position my browser uses by default looks better to me since it is closer to the text.

Ah alright, I thought it may be related to something shipping with markdown-it.


Improve bootstrapping of a collated handle.

One may want to use the Profile recipe to select an avatar, but that recipe takes as input a set of friend's avatars. Initially one has no friends, the handle doesn't exist, and the recipe won't surface.
#friends_avatar was statically build previously, but we recently changed it to build dynamically from collated friend data, which was fine as long as you already had friends.
@sjmiles to clarify as needed.

In #841, I added code to app-shell.js to create a place-holder handle for (what is now) #BOXED_avatar so that recipes needing that handle will always resolve.
Sometimes there ends up being two handles with that ID, but the second one ends up being harmless.
This solution is specific to this piece of data and doesn't scale (at all). A possible solution is a handle-connection that resolves to a null-view (or just null) in the absence of a proper match.


Roll engine 065fe5b21092..8840b7546c75 (6 commits)

https://github.com/flutter/engine/compare/065fe5b21092...8840b7546c75
git log 065fe5b2109291c84e24ce16763e6761d8cd3077..8840b7546c757a66a5aedfd5a7f92e30dc32fd63 --no-merges --oneline
8840b7546 Roll src/third_party/skia 0c6daf034b11..76346ac952c4 (30 commits) (flutter/engine#9000)
c181972a4 New Plugin API PR3: Introduces Service, BroadcastReceiver, and ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
682a6a8d0 Roll src/third_party/dart 0e8656e045..b2a3d1c31b (2 commits)
74b1f3270 Roll src/third_party/skia c6568afa0b63..0c6daf034b11 (1 commits) (flutter/engine#8995)
2e6ed7cdc Roll Buildroot (flutter/engine#8996)
865cb1c98 Roll src/third_party/dart 5ffff98440..0e8656e045 (1 commits)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5538004391690240 , https://cirrus-ci.com/task/4975054438268928 , https://cirrus-ci.com/task/6100954345111552

Commit queue failed; closing this roll.


Last updated date

Many of the services and audit scopes have been updated, but the article still reflects May 2019. If it's appropriate, I'd recommend refreshing the date.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e27d0b1-56f9-2eb7-8fee-0c47cfbafeac
Version Independent ID: 12556227-6adc-52c1-ac60-f341ae247e51
Content: Azure Services in FedRAMP and DoD SRG Audit Scope
Content Source: articles/azure-government/compliance/azure-services-in-fedramp-auditscope.md
Service: azure-government
GitHub Login: @Jain-Garima
Microsoft Alias: gjain

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

Hello, the May 2019 is the ms.date when this page was created. There is another date above the services table which shows when the services were updated(Last Updated: April 2020)

That makes sense, but it's not what's being shown on the public article.

https://docs.microsoft.com/en-us/azure/azure-government/compliance/azure-services-in-fedramp-auditscope

Please see the date highlighted below. The date under article topic is when it was created.
<EMAIL_ADDRESS>From: Brian Levenson<EMAIL_ADDRESS>Sent: Thursday, May 14, 2020 2:02 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Garima Jain (AZURE<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Last updated date (#54607)
That makes sense, but it's not what's being shown on the public article.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F40701897%2F81985702-74f09b00-95eb-11ea-8bd9-e0603caac9af.png&data=02|01|gjain%40microsoft.com|2c2cf8f054a14bcd1bcd08d7f84a1382|72f988bf86f141af91ab2d7cd011db47|1|0|637250869351092348&sdata=yQ8ot93H3p3PgtBTOW%2FWX1bISfWzzsF7yZxIMCj7aqQ%3D&reserved=0
https://docs.microsoft.com/en-us/azure/azure-government/compliance/azure-services-in-fedramp-auditscopehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fazure-government%2Fcompliance%2Fazure-services-in-fedramp-auditscope&data=02|01|gjain%40microsoft.com|2c2cf8f054a14bcd1bcd08d7f84a1382|72f988bf86f141af91ab2d7cd011db47|1|0|637250869351092348&sdata=PPt15VaU7D4mUrMe64HQfUbSOws%2F0XaILBkmCasPNCQ%3D&reserved=0
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F54607%23issuecomment-628884847&data=02|01|gjain%40microsoft.com|2c2cf8f054a14bcd1bcd08d7f84a1382|72f988bf86f141af91ab2d7cd011db47|1|0|637250869351102344&sdata=v%2BLOA2IfMbsznLLXFMjDYIPGuyjyA3uIhg0aaiza8pw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMLOUONMOYAVT4W6WMCPPNTRRRL5LANCNFSM4M6J4SSA&data=02|01|gjain%40microsoft.com|2c2cf8f054a14bcd1bcd08d7f84a1382|72f988bf86f141af91ab2d7cd011db47|1|0|637250869351112337&sdata=C%2BMiXliH4NXUwMd0yfEk01GOsVaalLVrSJUWINcN5H4%3D&reserved=0.

oh, yep! interestingly, the Docs in my team's repo use that field differently. either way, my mistake. thanks for the quick responses!


Understandable error messages when using spread operator with expect.any(Object)

🚀 Feature Proposal
Understandable error messages when using object destructuring with expect.any(Object).
Motivation
Let's consider following functions
const createEvent = (event, payload) => ({
  eventType: event,
  ...payload,
})

const getEvents = () => ([
	createEvent('evt1', { some: 'payload' }),
	createEvent('evt2', { some: 'payload' }),
])

Let's say you want to test that getEvents gives you appropriate actions and you already tested createEvent so you use it in your next test suites and write something like this
test('this test fails :(', () => {
	const expectedEvents = [
		createEvent('evt1', expect.any(Object)),
		createEvent('evt2', expect.any(Object)),
	]

	expect(getEvents()).toEqual(expectedEvents);
});

You will get a close to cryptic error TypeError: val.toAsymmetricMatcher is not a function with no clue what you need to fix.
Maybe there's a way to detect this kind of mistakes and provide a more user-friendly error message?

Sorry for a newbie question, but I'm running into this exact cryptic error message and can't quite understand from this thread what the mistake on my end is and how to fix it -- could someone clarify?

Same. I get this baffling message after upgrading to Jest 27: TypeError: Cannot destructure property 'AsymmetricMatcher' of '_prettyFormat.default.plugins' as it is undefined.

Fixed by #12626


kubernetes nodes "NotReady"

Hello all,
I have a problem with a kubernetes deployment on a bare-metal server. The deployment is on a ubuntu 16.06 server, using btrfs for lxd storage(same situation with zfs as well), using juju-2.0, kubernetes was deployed via "juju-2.3 bootstrap lxd lxd-test" and juju-2.3 deploy canonical-kubernetes.
The issue I have is that after the deployment, the workers and master are in a "waiting" status.  from "kubect get-nodes" it shows that they are all in "NotReady" status.
I have tried creating the whole env. several times, but to no effect. After some debugging the nodes, i get the message that there is not enough disk space or there are no available nodes-at the same time, which I think might be the same issue as https://github.com/kubernetes/kubernetes/issues/28481. Also tried to deploy the kubernetes env via conjure-up, but i still get the same issue. I believe it might be something to do with the LXD configuration, though it should be correct, as I have set up the storage and the bridge adapter during the "lxd init" Attaching the required information from the CDK Field Agent.
I would really appreciate some assistance with this as I have gone through pretty much all the described issues out there that resemble the current one.
results-2018-08-22-16-31-52.tar.gz

using btrfs for lxd storage(same situation with zfs as well)

using btrfs for lxd storage(same situation with zfs as well)

This is a known issue with CDK on LXD - kubelet does not work on LXD when using either the zfs or btrfs storage backends. You have to use the dir storage backend instead.

Thank you ever so much :), no matter how much I looked around I did not come across this.

I weil rebuild the environment and let you know of the results.

Hi @Cynerva ,
I am still experiencing the same issue it seems on a fresh environment with "dir" as the storage backend, also additional details on the env that might not be relevant, i have mounted a RAID1 device in /var/lib/lxd for storage.
Nodes:
NAME            STATUS     ROLES     AGE       VERSION   INTERNAL-IP    EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION      CONTAINER-RUNTIME juju-b88e67-7   NotReady   <none>    5m        v1.11.2   <IP_ADDRESS>   <none>        Ubuntu 16.04.5 LTS   4.4.0-131-generic   docker://17.3.2 juju-b88e67-8   NotReady   <none>    1m        v1.11.2   <IP_ADDRESS>   <none>        Ubuntu 16.04.5 LTS   4.4.0-131-generic   docker://17.3.2
Pods:
NAME                                               READY     STATUS    RESTARTS   AGE       IP        NODE            NOMINATED NODE default-http-backend-n5nlj                         0/1       Pending   0          5m        <none>    <none>          <none> nginx-ingress-kubernetes-worker-controller-mt4qh   0/1       Pending   0          55s       <none>    juju-b88e67-8   <none> nginx-ingress-kubernetes-worker-controller-pr8zl   0/1       Pending   0          5m        <none>    juju-b88e67-7   <none>
Attaching the the CDK output from the current env.
results-2018-08-23-15-30-16.tar.gz

@kiroalbatrosa Ahh sorry. I think you need to apply the LXD profile here prior to deploying: https://github.com/juju-solutions/bundle-canonical-kubernetes/wiki/Deploying-on-LXD#the-profile

@Cynerva , thank you for the info, I will try it and let you know of the results, just to make sure as far as I understastand, you are saying that I need to amend the profile after bootstraping before the juju deploy?

@kiroalbatrosa your steps are correct:
juju bootstrap
juju add-model my-k8s-model
sed "s/##MODEL##/my-k8s-model/" </path/to/lxd-profile.yaml"> | \
    lxc profile edit juju-my-k8s-model
juju deploy canonical-kubernetes

That's probably the best method... However, just today, I forgot to edit my lxc profile prior to deployment and decided to try doing it afterwards (basically swapping the last 2 steps above).  After running lxc profile edit, i restarted my containers:
juju run --all 'sudo reboot'

And it worked!!  So, you can definitely modify the profile before deployment, but you might also have success with lxc profile edit and restarting containers post-deployment.

Thank you all for your assistance, it is much appreciated

after using dir storage on lxd worked for me.

For those who face similar problem (nodes are NotReady), so kubelet isn't starting correctly.
I've spent several hours finding out that the kubelet isn't starting because of another reason.
Host server has to have this kernel parameter set:
vm.overcommit_memory=1

Relates to:
#https://github.com/kubernetes/kubernetes/issues/66241
More importantly, if you need to find the reason, try searching directly in kubelet's log:
juju ssh kubernetes-worker/0 "sudo snap logs kubelet -n 20000" | grep -A10 ": F"

My current setup:
1.) LXD cluster (lxd 4.9, juju 2.8.7) on VMWare, Ubuntu 20.04.1
2.) vagrant's "bento/ubuntu-20.04" image (on VirtualBox 6.1.16) + snap lxd 4.0.4 + snap juju 2.8.7 + charmed-kubernetes-559

@rstribrn it looks like you're hitting a known issue on LXD: https://bugs.launchpad.net/charm-kubernetes-worker/+bug/1903566
A workaround is provided in the issue:
juju config kubernetes-worker kubelet-extra-config='{protectKernelDefaults: false}'

I recommend taking further discussion into the launchpad bug. We don't track github issues anymore.

@rstribrn it looks like you're hitting a known issue on LXD: https://bugs.launchpad.net/charm-kubernetes-worker/+bug/1903566
A workaround is provided in the issue:
juju config kubernetes-worker kubelet-extra-config='{protectKernelDefaults: false}'

I recommend taking further discussion into the launchpad bug. We don't track github issues anymore.


[Linux/Mac/Windows]: Query about Visualization Graph for playing music

How to make visualization graph for current songs, I am guessing to get a stream of values for each bar?. I am trying to make winamp for multi-dekstop. Hope to get this resolved.

Thanks,
Shashank

I think this is hard to achieve with this library as the bytes are handled on the platform itself. Basically audioplayers only hands down the url to the native player. So the library never sees what is processed, only getting specific events (completed, errors, etc.) from the platform.

Oh, so should I make my own code for native processing? or can i fork this repo?


io/fs cannot find package

What version of Go are you using (go version)?

$ go version
go version go1.8 linux/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/noiro/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build250038941=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
"io/fs" is imported in the vendor dir (vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go). Go is trying to fetch the module "io/fs" but it ends with an error saying
vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in:
/go/src/github.com/noironetworks/aci-containers/vendor/io/fs

What did you expect to see?
Running go mod vendor should have resolved this issue which it didnt and I am also using latest go version.
What did you see instead?
vendor/k8s.io/client-go/plugin/pkg/client/auth/exec/metrics.go:21:2: cannot find package "." in:
/go/src/github.com/noironetworks/aci-containers/vendor/io/fs

go1.8 is no longer supported
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions


Development: Holidays app - homepage

Develop the homepage for the holidays app in React.
To do

[ ] Set up homepage

Done when:

[ ] Merged into gcds-examples/fable-test-app

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."


Fix logging

Try and fixup how are logging is organized a works
This is now the logs from a load and unload of two separate programs with RUST_LOG=bpfd=info.
---------------->>>>>>>>> STARTUP
[astoycos@nfvsdn-02-oot bpfd]$ sudo RUST_LOG=bpfd=info ./target/debug/bpfd
[INFO  bpfd] Log using env_logger
[INFO  bpfd] Has CAP_BPF: true
[INFO  bpfd] Has CAP_SYS_ADMIN: true
[WARN  bpfd] Unable to read config file, using defaults
[INFO  bpfd::certs] CA Certificate file /etc/bpfd/certs/ca/ca.pem does not exist. Creating CA Certificate.
[INFO  bpfd::certs] bpfd Certificate Key /etc/bpfd/certs/bpfd/bpfd.key does not exist. Creating bpfd Certificate.
[INFO  bpfd::certs] bpfd-client Certificate Key /etc/bpfd/certs/bpfd-client/bpfd-client.key does not exist. Creating bpfd-client Certificate.
[INFO  bpfd::oci_utils::cosign] Starting Cosign Verifier, downloading data from Sigstore TUF repository
[INFO  bpfd::serve] Listening on [::1]:50051
---------------->>>>>>>>> LOAD 1
[WARN  bpfd::oci_utils::cosign] The bytecode image: quay.io/bpfd-bytecode/xdp_pass:latest is unsigned
[INFO  bpfd::command] Loading program bytecode from container image: quay.io/bpfd-bytecode/xdp_pass:latest
[INFO  bpfd::bpf] Adding xdp program: pass
[INFO  bpfd::bpf] Removing program with id: 30845
---------------->>>>>>>>> LOAD 2
[WARN  bpfd::oci_utils::cosign] The bytecode image: quay.io/bpfd-bytecode/uprobe:latest is unsigned
[INFO  bpfd::command] Loading program bytecode from container image: quay.io/bpfd-bytecode/uprobe:latest
[INFO  bpfd::bpf] Adding probe program: my_uprobe
[INFO  bpfd::bpf] Removing program with id: 30846

All other commands intentionally don't log when at the info level.
Additionally fix-up how we get and store the raw program bytes during the load process

@Billy99 I'm happy to add more here but I think this is a pretty good stopgap for our release....LMK what you think
The k8s logging is now always defaulted to info for both the agent and bpfd

Resolves: #663


Add view getter on RCTRootView / RCTFabricSurfaceHostingProxyRootView

Summary:
Hi 👋
During the react-native-bootsplash implementation of the new architecture, I noticed a few thing regarding RCTRootView / RCTFabricSurfaceHostingProxyRootView compat.
Currently RCTRootView inherits from UIView, but RCTFabricSurfaceHostingProxyRootView does not, which this works:
- (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
                          moduleName:(NSString *)moduleName
                           initProps:(NSDictionary *)initProps {
  RCTRootView *rootView = (RCTRootView *)
      [super createRootViewWithBridge:bridge moduleName:moduleName initProps:initProps];

  UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"LaunchScreen" bundle:nil];
  UIView *loadingView = [[storyboard instantiateInitialViewController] view];

  loadingView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
  loadingView.frame = rootView.bounds;
  loadingView.center = (CGPoint){CGRectGetMidX(rootView.bounds), CGRectGetMidY(rootView.bounds)};
  loadingView.hidden = NO;

  [rootView addSubview:loadingView];

  return rootView;
}

But this doesn't:
- (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
                          moduleName:(NSString *)moduleName
                           initProps:(NSDictionary *)initProps {
  RCTFabricSurfaceHostingProxyRootView *rootView = (RCTFabricSurfaceHostingProxyRootView *)
      [super createRootViewWithBridge:bridge moduleName:moduleName initProps:initProps];

  UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"LaunchScreen" bundle:nil];
  UIView *loadingView = [[storyboard instantiateInitialViewController] view];

  loadingView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
  loadingView.frame = rootView.bounds;
  loadingView.center = (CGPoint){CGRectGetMidX(rootView.bounds), CGRectGetMidY(rootView.bounds)};
  loadingView.hidden = NO;

  [rootView addSubview:loadingView];

  return rootView;
}

Because RCTFabricSurfaceHostingProxyRootView is an imperfect proxy as it doesn't give access to the underlaying UIView *. As a solution, I added a prop on both: UIView *view
PS: I'm well aware that setLoadingView also exists in both files, but it's currently not usable as the current isActivityIndicatorViewVisible / isSurfaceViewVisible / _activityIndicatorViewFactory logic in RCTSurfaceHostingView.mm doesn't work: a situation where isActivityIndicatorViewVisible == true && isSurfaceViewVisible == false && _activityIndicatorViewFactory != nil never happen:

Changelog:

[iOS] [Added] - Expose a view property on RCTRootView and RCTFabricSurfaceHostingProxyRootView for splash screen libraries usage
Test Plan:
Add this block of code in AppDelegate.mm:
#import <React/RCTRootView.h>

#if __has_include(<React/RCTFabricSurfaceHostingProxyRootView.h>)
#import <React/RCTFabricSurfaceHostingProxyRootView.h>
#endif

// …

- (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
                          moduleName:(NSString *)moduleName
                           initProps:(NSDictionary *)initProps {
#ifdef RCT_NEW_ARCH_ENABLED
  RCTFabricSurfaceHostingProxyRootView *rootView = (RCTFabricSurfaceHostingProxyRootView *)
#else
  RCTRootView *rootView = (RCTRootView *)
#endif
      [super createRootViewWithBridge:bridge moduleName:moduleName initProps:initProps];

  // accessing the "real" root view on both arch
  UIView *view = rootView.view;

  UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"LaunchScreen" bundle:nil];
  UIView *loadingView = [[storyboard instantiateInitialViewController] view];

  loadingView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
  loadingView.frame = view.bounds;
  loadingView.center = (CGPoint){CGRectGetMidX(view.bounds), CGRectGetMidY(view.bounds)};
  loadingView.hidden = NO;

  [view addSubview:loadingView];

  return rootView;
}

It should persist the splash screen on both old and new architecture.

I understand. It has also been approved internally. So, let's go with this approach! 😉

@cipolleschi Perfect! I will update the pull request this evening 🙂


Add support for arrays of pointer types

Progress towards dotnet/corefx#17480.
On the compiler side:

Unblock generation of arrays of pointer EETypes. We were already doing
the right thing w.r.t. the interface lists (these do not implement the
generic interface: int*[] does not implement IEnumerable<int*>).
Nothing else was missing.

On the classlib side:

I groveled through the places where we would box/unbox array element
types, or assume that if the element type is not a value type, it's a
reference type. Hopefully, I didn't miss anything.
I pre-emptively fixed dotnet/coreclr#10646 in my implementation of
Array.Copy.

On the runtime side:

I verified this doesn't affect casting (i.e. we don't allow casting
uint*[] to int*[]), so no changes should be needed.

@davidwrighton PTAL.
The code paths that reach the type loader still have a PlatformNotSupportedException for this case. I tried to coerce the type loader into taking void*[] as the template for these and move on with life, but it seems like it needs more work.


Month Navigation triggers next Step if flow [calendar, time]

Bug
When you click on one of the monthly navigation buttons (back & forth arrows) and the flow is set to ['calendar','time'] it opens up the time selector.
Steps to reproduce the behavior:
<VueDatePicker v-model="date" :flow="['calendar','time']"/>
Open the calendar and change the month (back or forth) before selecting a date. It will show the time selector, instead of switching the month.
Expected behavior
When switching to another month (via back and forth buttons) it should not trigger the next step in the flow and change to the month accordingly. After that it should open up the time selector, when selecting a date.
https://github.com/Vuepic/vue-datepicker/assets/58180062/4b3ec314-ef42-441c-9e99-2f1e621e4a4f

My fault. Problem does not occur in the playground, so there is a Problem on my end. Sorry for the inconvenience.


Error with rustc 1.77+

Reported by @barretodavid,
error: failed to run custom build command for `scarb-build-metadata v2.5.3 (https://github.com/software-mansion/scarb#5189ae09)`

Caused by:
  process didn't exit successfully: `/Users/david/apps/starknet/starklings/target/release/build/scarb-build-metadata-80d95f6ce8b10254/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-changed=../../.git/index
  cargo:rustc-env=SCARB_COMMIT_HASH=5189ae09e2be80e5ed70c0f927b0bcd297454b5d
  cargo:rustc-env=SCARB_COMMIT_SHORT_HASH=5189ae09e
  cargo:rustc-env=SCARB_COMMIT_DATE=2024-02-08
  cargo:rerun-if-changed=../../Cargo.lock

  --- stderr
  thread 'main' panicked at /Users/david/.cargo/git/checkouts/scarb-831c32bf23da0a7c/5189ae0/utils/scarb-build-metadata/build.rs:54:5:
  Expected metadata resolve root to be `scarb`.
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Waiting on update on Scarb to fix for newer rustc.

I'm getting the same error to run cargo run -r --bin starklings

Yeah, that's the one.
Please use rust 1.76 until this issue is fixed.

Same error here, thanks for creating this issue.

This is fixed in scarb and will be released in the next scarb release.

If you have rustup, you can switch to v<IP_ADDRESS> by running the following commands:

rustup toolchain install 1.76.0
run rustup default 1.76.0  - this sets your toolchain (cargo and rustc) to v1.76.0
check the respective versions of your toolchain by running:
rustc --version and cargo --version

Make sure you see 1.76 for both rustc and cargo on your terminal. Then you can proceed to run:
cargo run -r --bin starklings watch

Thanks for the instructions @sprtd :D

This is fixed in scarb and will be released in the next scarb release.

I am having the same issue for rustc 1.79.0 (129f3b996 2024-06-10)

This is fixed in scarb and will be released in the next scarb release.

I think this is not fixed in latest version:
scarb 2.6.5 (d49f54394 2024-06-11)
cairo: 2.6.4 (https://crates.io/crates/cairo-lang-compiler/2.6.4)
sierra: 1.5.0

Hi @shramee,
As this bug has been ongoing since March and has not yet been fixed in the latest Scarb release, I propose we add it as a Known Issue to the documentation. Placing a small warning near the installation steps could be very helpful for new users. We can use the solution provided by @sprtd, as it is simple and effective.
Documenting known issues can prevent users from encountering avoidable problems, allowing them to focus on learning Cairo without unnecessary hurdles. Please let me know what you think.
Thank you!

Before the next scarb release as @shramee mentioned, if you have rustup, you can switch to v<IP_ADDRESS> by running the following commands:

rustup toolchain install 1.76.0
run rustup default 1.76.0  - this sets your toolchain (cargo and rustc) to v1.76.0
check the respective versions of your toolchain by running:
rustc --version and cargo --version

Make sure you see 1.76 for both rustc and cargo on your terminal. Then you can proceed to run: cargo run -r --bin starklings watch
Thanks for this man

This is now fixed guys.


Extend Furnishings

Furnishings need to be Walkable/Non-Walkable.
Furnishings should be lockable.
Move the concept of locked doors from blocks to furnishings.

Should also list what item represents them in the inventory.

Complete as of #30.


Add a background job that clears old unused tokens

Add a background job to TokenServiceImpl that removes from DB old, unused tokens. The job should be run every X times 50 where X is tokens time to live.
Put job logic into the separate, private method and provide appropriate tests.

Won't do!


Bounds on std::error::Error implementation for ParseError<P> too restrictive

Commit 1e500c6efa1dab4b3e5fc883900a401228053d89 changed the bounds on the implementation of std::error::Error for ParseError<P>. It now requires, among others, P::Position: Positioner which I think is unnecessarily restrictive and in fact not the case for existing instances of P, e.g. char and u8.

Thanks for noticing the typo.
Fixed in 7f86f3b3d7079590b6eb258a7bf8a66c4d845b19

And I will publish 0.5.1 once travis finishes testing.


Investigate issue with application of  rights_statement_default in Rikolti mapper (from metadata_mapper/mappers/constants.py)

We have a default rights statement specified in metadata_mapper/mappers/constants.py (rights_statement_default) , intended to be supplied as a "statement of last resort" if there is nothing in the source metadata -- and if we neglected to intentionally add a boilerplate statement into records at the time of harvesting.
In running Rikolti mapper validation tests, we've noticed that this statement of last resort doesn't seem to be getting invoked and applied, for cases where there's nothing in the source metadata. Two example collections, below:
https://registry.cdlib.org/admin/library_collection/collection/29
https://registry.cdlib.org/admin/library_collection/collection/26713
For the time being, we've intentionally added the statement within the "Rights statement" field in Registry, so it is explicitly there -- and should be applied per the /required-values-from-collection-registry?field=title&mode=fill, enrichment chain.  That can be backed out, when re-investigating this issue.

I removed the "rights statement" from Registry for collections 29 and 26713. I didn't run 26713 yet though because it's so huge.

From collection 29, this record doesn't have a Nuxeo-supplied copyright info:

-stage: https://calisphere-stage.cdlib.org/item/ark:/81235/d85n69/
Nuxeo: https://nuxeo.cdlib.org/nuxeo/nxdoc/default/7dc2fe1b-207b-485f-8d8e-632f172a0367/view_documents

The Nuxeo record is indeed missing rights details.

Timeline:

January 30th: In Registry, Barbara removed the Registry-supplied rights description (on January 30th, according to the Registry history).
April 24th: According to the Publication Sequence spreadsheet -- collection 29 was most recently harvested on April 24th.

Based on this timeline, my sense is that the template rights_statement_default appears to be working!


fix(ui): handle failing voting power

Summary
Handle case when fetching voting power is failing.
Closes: #87
On error, the voting power indicator should look like:

The error message inside voting power modal looks like:

On retry button click, it should enter loading state:

How to test
Example of proposal with invalid voting power: https://testnet.snapshotx.xyz/#/s-tn:wan-test.eth/proposal/0x56b857b02d573b0ba747333b57cb3dd11df57cc0d1bcc41c3c990466b477c5e8

Go to a proposal with a failing voting power / space's proposals page
The voting power indicator should have a special styling
Opening the voting power modal should display a message, a retry button, and the list of strategies (without vp)
Clicking on the RETRY button should trigger a voting power fetching

To-Do
On voting power error:

[x] Voting power indicator should have an error style
[x] Show warning message inside modal
[x] Add retry button inside modal to re-trigger voting power fetching
[ ] List all available strategies, with a red (!) icon instead of voting power
[x] Improve UI

The red color looks too similar to the Reject button, I think we should keep the original color and use a warning red icon
We shouldn't show the modal empty when retry is going on we can show a loading instead.

The red color looks too similar to the Reject button, I think we should keep the original color and use a warning red icon
We shouldn't show the modal empty when retry is going on we can show a loading instead.

Yes, UI not ready yet, focusing on logic

This has double border

I believe icon should be exclamation for error, information-circle for info

For the modal you could use the flash message style like this:

Still trying to find out best way to fetch the strategies list

Screenshots and code updated as per latest comments


Various Messages Plugin Support

Sometimes you don't want to drop coords in a public chat, do you think you could add in the config menu a text bar that allows us to place a prefixed command to either message it to someone specific or a specific group chat in game?
Or a hotkey to copy it to your clipboard?
Or even a way to change or add multiple hotkeys with different prefixes?

 I don't even use this mod anymore, I made a script with JS Macros which is much better.

The mod is meant for multiplayer with your friends. If you want to remember the coords just press f3 and take a screenshot. I was just making a hilarious spongebob reference

Actually, the reason I suggested it was because if you're getting attacked by another player you might not want to broadcast your coords to whole world. Messaging a player or sending it in another chat group on the server would be a better option.