Catch up with latest elemental-cli

Signed-off-by: David Cassany<EMAIL_ADDRESS>

Fails due to rancher/elemental-cli#380


rsync: permission denied

Hi! I'm running Win 8.1 with cygwin. When I call in my nodejs project folder the fly command with the appropriate argument, i get this error: "localhost > Permission denied, please try again." When I call the rsync itself, it requires a password then copies the given files to the remote server without problems. I tried the passwordless authentication too, copied the ssh public key and the rsync it works well again, the files copied to the remote host, but with the fly command I became the same permission denied message. It not requires any password or anything.
I created a linux guest in vbox, and copied my nodejs project folder on this virtual machine, so all is the same except the os. When I called here the fly command it runs perfectly.
How could I fix this issue? Many thanks for every help (aaaand, sorry for my english, when I wrote something wrong)
Here is the output from the cygwin:
localhost Copy files to remote hosts
localhost $ git ls-files
localhost > app.js
localhost > package.json
localhost ● ok
localhost $ rsync --files-from dce8928af5455d73f1b507a3251c8400 -az --rsh="ssh -p22" ./ kergeodeta@xxx.xxx.xxx.xxx:/home/kergeodeta/test-proj-1469781651157
localhost > Permission denied, please try again.
localhost > Permission denied, please try again.
localhost > Permission denied (publickey,password).
localhost > rsync: connection unexpectedly closed (0 bytes received so far) [sender]
localhost > rsync error: error in rsync protocol data stream (code 12) at io.c(226) [sender=3.1.1]
localhost ● failed (12)
● Command exited abnormally on localhost

It was not the flightplan, it was the cygwin. With the start of cygwin the ssh-agent not started. I have to edited the .bash-profile file (http://killtheradio.net/how-tos/ssh-agent-on-cygwin/) and then restart the cygwin. After this I have to added my RSA key and it began to work :-)

Glad you managed to make it work 🍻

I have exactly the same problem, but can't get it working. Could you please explain in detail how you fixed that problem under windows?
Thanks


just a simple question related to limitation

why should it limited to max 4 tab while I try to change the source code and test it of 5 tab and still look fine.

@lastday4you have you managed to work it out?

This library implement the same widget, without the limitation.
https://pub.dev/packages/circular_bottom_navigation


Adds dynamic component support (aka "hierarchical components") with entry points to ACS, adds SB3 PPO agent and ports Acme R2D2 agent

Fixes #127, Fixes #146, Fixes #147

This PR breaks the registry functionality!
Makes it easier to compose agents via local components
Adds acme_r2d2 and sb3_agent to example_agents directory
Acme R2D2 agent ported to new dynamic component graph system
Acme R2D2 successfully runs w/ the following commands:

evaluate entry-point: agentos run agent --entry-point learn --param-file parameters.yaml
learn: agentos run agent --entry-point learn --param-file parameters.yaml
OR use some command line args for evaluate: agentos run agent --entry-point learn --param-file parameters.yaml -Pnum_episodes=100

Simple port of SB3 PPO, which you can run with:

evaluate agent: agentos run agent
learn: agentos run agent --entry-point learn

Replaced the use of shared_data by Acme R2D2 components with direct access to other components
Evolve param system for new component system. Support params at command line w/ -P flag and also a param file w/ --param-file flag (command line flags override args specified in the file)
Moves the metrics tracking and checkpointing functionality from runtime.py into agento.Agent since not all components will handle that functionality the same way, so it makes more sense for it to be associated with the optional/example agent component we are providing in agentos.Agent.

Now the runtime is responsible for managing and loading parameters, allowing the user to call entry-points, initing agent projects, installing components, and interacting with the registry, while all tracking and artifact logging is handled inside of components (probably by using libraries)

Renames the default entry point from "run" to "evaluate" (to semantically separate the concept of agentos "run"ing an entry point vs the purpose of the entry point being to evaluate the performance of an agent.
Makes reset() an entry_point in core.Agent, though this isn't tested yet
TODO: add a way for AgentOS cli to show the params supported by an entry-point by inspecting the component function signatures.
NOTE: parameters from the CLI via -P flag are all sent to component entry point function) as strings, so the component entry point has to cast them to other values if necessary.
TO DISCUSS: Should we rename the agentos "run" command to be "exec", and run_component to be exec_component (suggested by Beth)?

Github is showing you added a submodule at example_agents/acme_r2d2/.aos/acme_r2d2_policy. I'm guessing this may have been unintentional. If so, let's kill it.

Yep, was unintentional. Removed it.

I propose that we remove the .aos/ folders from the example agents because they contain a bunch of binary files and other clutter. We should make the runtime recreate the expected directory structure if it does not exist (I believe we already have a function for that).

Done. I also moved the tracking functionality out of runtime into an agentos.tracking.Tracker class.

I needed to pip install attrdict before I could run the R2D2 agent. Maybe that should be added to requirements. Same story with the SB3 agent and pip install stable_baselines3.

Done.

We can probably remove my personal .bash_rc and .bash_profile that migrated over from acme_test repo and the Dockerfile entries that copy them into the Docker image.

Done.
Build currently isn't green (looks like you need to run python scripts/format_code.py). Maybe we should just skip any tests we're trying to run until we dig out?
Done.

Ok @nickjalbert I think I've addressed all of your current specific points of feedback!

LGTM!


adding 2 defaults for grub 2

Hi,
A small change to avoid the following message on my Debian 8:
Warning: Found multiple default providers for kernel_parameter: grub2, grub; using grub2
I also made a change for the issue #13
Tested on CentOS 7 and Debian 8

Lgtm, I'll merge


Add instruction to declare the variable

I've extended the fix to the regexp highlighter, tweaked the log message and merged. Thanks for the patch!


NIFI-8260 Implement an Upload File capability in the NiFi UI for flow definitions.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_This feature allows the user to upload a previously exported JSON flow definition into the NiFi UI and it will create a new Process Group, bypassing NiFi Registry.
NIFI-8260 - [WIP] Created Upload File capability for front end and server side logic.
Created a new API endpoint to upload a JSON flow definition and transform it to a Versioned Flow Snapshot.
Fixed the client side file form to reset after submit.
Fixed the canvas to instantly update and show the process group after submitting the file.
Changed the Add Processor Group dialog UI based on design notes.
Changed the Upload File link to an icon and moved to the name input field.
Changed the 'Registry Import' link to say 'Import from Registry' and moved to the bottom of the dialog.
Display the filename when a file is selected.
Added a cancel file button to the Process Group dialog._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

The PR is ready for initial review. The overall functionality works. I have one more UI enhancement that I'm working on now - it's for disabling the "Add Process Group" dialog "Add" button until the dialog is ready for submission.
cc: @pvillard31 @mcgilman

When I read this PR title I was thinking this was a very different thing.  Reading the JIRA I think it is more specific to being able to upload a 'flow definition' which will create that flow on the NiFi it is uploaded to.  Can we please clarify the description?
The term 'flow file' is a specific thing in NiFi and it means 'data in the flow' as represented by a set of attributes and content.

@joewitt Yes! Changed the term to flow definition.

Built the PR and gave it a try. When trying to import a flow (json file) that I just exported from somewhere else on the canvas by right clicking on a process group / download flow definition, I always got the below stack trace:
2021-02-25 23:42:36,617 ERROR [NiFi Web Server-234] o.a.nifi.web.api.config.ThrowableMapper An unexpected error has occurred: java.lang.NullPointerException. Returning Internal Server Error response.
java.lang.NullPointerException: null
        at org.apache.nifi.web.api.ProcessGroupResource.lambda$uploadProcessGroup$106(ProcessGroupResource.java:4373)
        at org.apache.nifi.web.api.ApplicationResource.withWriteLock(ApplicationResource.java:719)
        at org.apache.nifi.web.api.ProcessGroupResource.uploadProcessGroup(ProcessGroupResource.java:4328)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:76)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:148)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:191)
        at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:200)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:103)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:493)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:415)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:104)
        at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:277)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:272)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:268)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:316)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:298)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:268)
        at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:289)
        at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:256)
        at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:703)
        at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:416)
        at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:370)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:389)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:342)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:229)
        at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1452)
        at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:791)
        at org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1626)
        at org.apache.nifi.web.filter.RequestLogger.doFilter(RequestLogger.java:66)
        at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
        at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
...

@pvillard31 Good catch - I just pushed a commit that should fix this. If uploading a flow that was downloaded from the canvas, the flow does not contain snapshot metadata. I was trying to access the metadata, but it's not necessary. Thanks.

@exceptionfactory Thanks for reviewing! I've addressed your feedback and committed the changes.

My last commit includes the disabled buttons, which completes this PR and is ready for merge once it's approved. Thanks.
@pvillard31

@exceptionfactory Thanks for reviewing! I've addressed your feedback and committed the changes.

Thanks for making the changes @mtien-apache.  I will take another look following the updates. I noticed that StandardProcessGroup, NiFiServiceFacade, and StandardNiFiServiceFacade still show up with reordered imports, can you remove those changes?

Note sure if this has been addressed but I noticed that: if selecting a flow on the canvas ans clicking on the "Group" icon (to make a process group from the selection), then the icon to upload a JSON file appears when it should just ask for the new process group to create from the selection.

I don't think this is expected. And if I do select a JSON file at this step (instead of just giving a name for my selection to be added in a process group), the process group for my JSON file will be added instead of putting my selection into a process group.
So... I guess it's just about removing the option to upload the file when we click on the "Group" button. It should only be available when drag-and-dropping a process group on the canvas. Thoughts?

@pvillard31 Agreed the upload file button should be removed when a user clicks on the "Group" button. Will make the change.

Just pushed a commit -

Hide the Upload File button when grouping components @pvillard31
Refactored uploadProcessGroup and exception handling @exceptionfactory
Refactored nf-ng-group-component.js @sardell

Thanks

@sardell Thanks for reviewing!

@markap14 I made revisions from your feedback. Thanks for looking at this in detail!

Merged (and took care of reverting import ordering changes)


Convert single regression test in iocore/eventsystem/SocketManager.cc to Catch.

[approve ci autest]

[approve ci autest]


Refactor

Pull Request Test Coverage Report for Build 656081423

63 of 95 (66.32%)  changed or added relevant lines in 7 files are covered.
8 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.7%) to 70.455%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

conn.go
42
48
87.5%

testutils/fasthttp_server.go
6
32
18.75%

Files with Coverage Reduction
New Missed Lines
%

testutils/fasthttp_server.go
8
19.4%

Totals

Change from base Build 643464492:
0.7%

Covered Lines:
186

Relevant Lines:
264

💛  - Coveralls


Failure in window operation

TypeError: cannot read property 'D:\x5cZUI\x5cTool/tcp-echo.js' of undefined
at [anon] (d:\zui\zui\duktape\duk_hobject_props.c:2336) internal

I need more details to understand what's going on here.


Requirements are not updated

We should add and review ALL correct libraries we use in this project. It should be possible for students to simply write:
python -m pip install -r requirements.txt
for installing all libraries necessary for all lectures

The requirements in master branch are updated. This issue is related only for non-master branches.


Starting Windows container from Selenoid

I have successfully build a container with running windows inside from your guide. Thanks a lot for the detailed instructions!
It works also as described when running the container like this:
$ docker run -it --rm --privileged -p 4444:4444 -p 5900:5900 windows/ie:11
I am able to run tests successfully against the container.
Now I want to start the container from Selenoid on the host system. Selenoid is able to start the image successfully but the service inside is not starting. For me it looks like --privileged flag is missing in browser.json configuration. Is there a way to achieve this?
docker-compose:
version: '3'
services:
  selenoid:
    image: "aerokube/selenoid:latest-release"
    network_mode: bridge
    volumes:
      - "$PWD/selenoid/config:/etc/selenoid/"
      - "$PWD/selenoid/opt:/opt/selenoid/video"
      - "$PWD/selenoid/opt:/opt/selenoid/logs"
      - "/var/run/docker.sock:/var/run/docker.sock"
    environment:
      - OVERRIDE_VIDEO_OUTPUT_DIR="$PWD/opt"
    command: ["-limit", "4","-conf", "/etc/selenoid/browsers.json", "-video-output-dir", "/opt/selenoid/video", "-log-output-dir", "/opt/selenoid/logs"]
    ports:
      - "4445:4444"

browser.json:
{
    "internet explorer": {
        "default": "11",
        "versions": {
            "11": {
                    "image": "windows/ie:11",
                   "port": "4444",
                   "path": "/",
                   "tmpfs": {
                       /tmp": "size=128m"
                   }
            }
        }
    }
}

@telesma Selenoid appends --privileged automatically. Could you copy some Windows container logs started by Selenoid here?

May be you have to add network: bridge to you compose file?
ср, 31 июл. 2019 г., 12:25 Ivan Krutov<EMAIL_ADDRESS>
@telesma https://github.com/telesma Selenoid appends --privileged
automatically. Could you copy some Windows container logs started by
Selenoid here?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23N45ROZDALDAZVDOB3QCFLAZA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3GU6PA#issuecomment-516771644,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23PUMSZZ5WQC7P4UILTQCFLAZANCNFSM4IIEO5RA
.

This is the output in the command line from the host with Selenoid. I am currently a little helpless how to get the logs from the Windows container..
osboxes@osboxes:~/Desktop/selenoid-windows$ docker-compose up Creating selenoid-windows_selenoid_1 ... done Attaching to selenoid-windows_selenoid_1 selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Loading configuration files...] selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Loaded configuration from /etc/selenoid/browsers.json] selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Video Dir: /opt/selenoid/video] selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Your Docker API version is 1.40] selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Timezone: UTC] selenoid_1  | 2019/07/31 09:51:46 [-] [INIT] [Listening on :4444] selenoid_1  | 2019/07/31 09:52:10 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>] selenoid_1  | 2019/07/31 09:52:10 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>] selenoid_1  | 2019/07/31 09:52:10 [0] [LOCATING_SERVICE] [internet explorer] [] selenoid_1  | 2019/07/31 09:52:10 [-] [DEFAULT_VERSION] [Using default version: 11] selenoid_1  | 2019/07/31 09:52:10 [0] [USING_DOCKER] [internet explorer] [11] selenoid_1  | 2019/07/31 09:52:10 [0] [CREATING_CONTAINER] [windows/ie:11] selenoid_1  | 2019/07/31 09:52:10 [0] [STARTING_CONTAINER] [windows/ie:11] [a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d] selenoid_1  | 2019/07/31 09:52:11 [0] [CONTAINER_STARTED] [windows/ie:11] [a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d] [0.81s] selenoid_1  | 2019/07/31 09:52:41 [0] [REMOVING_CONTAINER] [a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d] selenoid_1  | 2019/07/31 09:52:41 [0] [CONTAINER_REMOVED] [a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d] selenoid_1  | 2019/07/31 09:52:41 [0] [SERVICE_STARTUP_FAILED] [wait: http://<IP_ADDRESS>:4444/ does not respond in 30s] selenoid_1  | 2019/07/31 09:52:41 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>] selenoid_1  | 2019/07/31 09:52:41 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>] selenoid_1  | 2019/07/31 09:52:41 [1] [LOCATING_SERVICE] [internet explorer] [] selenoid_1  | 2019/07/31 09:52:41 [-] [DEFAULT_VERSION] [Using default version: 11] selenoid_1  | 2019/07/31 09:52:41 [1] [USING_DOCKER] [internet explorer] [11] selenoid_1  | 2019/07/31 09:52:41 [1] [CREATING_CONTAINER] [windows/ie:11] selenoid_1  | 2019/07/31 09:52:41 [1] [STARTING_CONTAINER] [windows/ie:11] [7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb] selenoid_1  | 2019/07/31 09:52:42 [1] [CONTAINER_STARTED] [windows/ie:11] [7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb] [0.82s] selenoid_1  | 2019/07/31 09:53:12 [1] [REMOVING_CONTAINER] [7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb] selenoid_1  | 2019/07/31 09:53:13 [1] [CONTAINER_REMOVED] [7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb] selenoid_1  | 2019/07/31 09:53:13 [1] [SERVICE_STARTUP_FAILED] [wait: http://<IP_ADDRESS>:4444/ does not respond in 30s]

Error that service "does not respond in 30s" means that there is no network
connectivity between selenoid container and browser container, it often
occurs using docker compose because it creates custom network and selenoid
creates containers in default network. Possible fix is setup network to
brige, or pass -container-network option to selenoid with name of docker
compose network.
ср, 31 июл. 2019 г. в 13:49, Frank Rossi<EMAIL_ADDRESS>
This is the output in the command line from the host with Selenoid. I am
currently a little helpless how to get the logs from the Windows container..
osboxes@osboxes:~/Desktop/selenoid-windows$ docker-compose up Creating
selenoid-windows_selenoid_1 ... done Attaching to
selenoid-windows_selenoid_1 selenoid_1 | 2019/07/31 09:51:46 [-] [INIT]
[Loading configuration files...] selenoid_1 | 2019/07/31 09:51:46 [-]
[INIT] [Loaded configuration from /etc/selenoid/browsers.json] selenoid_1 |
2019/07/31 09:51:46 [-] [INIT] [Video Dir: /opt/selenoid/video] selenoid_1
| 2019/07/31 09:51:46 [-] [INIT] [Your Docker API version is 1.40]
selenoid_1 | 2019/07/31 09:51:46 [-] [INIT] [Timezone: UTC] selenoid_1 |
2019/07/31 09:51:46 [-] [INIT] [Listening on :4444] selenoid_1 | 2019/07/31
09:52:10 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>] selenoid_1 | 2019/07/31
09:52:10 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>] selenoid_1 |
2019/07/31 09:52:10 [0] [LOCATING_SERVICE] [internet explorer] []
selenoid_1 | 2019/07/31 09:52:10 [-] [DEFAULT_VERSION] [Using default
version: 11] selenoid_1 | 2019/07/31 09:52:10 [0] [USING_DOCKER] [internet
explorer] [11] selenoid_1 | 2019/07/31 09:52:10 [0] [CREATING_CONTAINER]
[windows/ie:11] selenoid_1 | 2019/07/31 09:52:10 [0] [STARTING_CONTAINER]
[windows/ie:11]
[a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d]
selenoid_1 | 2019/07/31 09:52:11 [0] [CONTAINER_STARTED] [windows/ie:11]
[a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d] [0.81s]
selenoid_1 | 2019/07/31 09:52:41 [0] [REMOVING_CONTAINER]
[a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d]
selenoid_1 | 2019/07/31 09:52:41 [0] [CONTAINER_REMOVED]
[a7d652962bd9267c74ddec5a7d7a3df34990de0ee0b30b4a19aaa2f92967195d]
selenoid_1 | 2019/07/31 09:52:41 [0] [SERVICE_STARTUP_FAILED] [wait:
http://<IP_ADDRESS>:4444/ does not respond in 30s] selenoid_1 | 2019/07/31
09:52:41 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>] selenoid_1 | 2019/07/31
09:52:41 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>] selenoid_1 |
2019/07/31 09:52:41 [1] [LOCATING_SERVICE] [internet explorer] []
selenoid_1 | 2019/07/31 09:52:41 [-] [DEFAULT_VERSION] [Using default
version: 11] selenoid_1 | 2019/07/31 09:52:41 [1] [USING_DOCKER] [internet
explorer] [11] selenoid_1 | 2019/07/31 09:52:41 [1] [CREATING_CONTAINER]
[windows/ie:11] selenoid_1 | 2019/07/31 09:52:41 [1] [STARTING_CONTAINER]
[windows/ie:11]
[7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb]
selenoid_1 | 2019/07/31 09:52:42 [1] [CONTAINER_STARTED] [windows/ie:11]
[7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb] [0.82s]
selenoid_1 | 2019/07/31 09:53:12 [1] [REMOVING_CONTAINER]
[7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb]
selenoid_1 | 2019/07/31 09:53:13 [1] [CONTAINER_REMOVED]
[7ab5b479a671229463bc7fa859925694d17388be1878a617993b63df5f704ccb]
selenoid_1 | 2019/07/31 09:53:13 [1] [SERVICE_STARTUP_FAILED] [wait:
http://<IP_ADDRESS>:4444/ does not respond in 30s]
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23PWEAWGNKHLVLKKXT3QCFU3RA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3G3SDY#issuecomment-516798735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23P7DDSF3P43P6DNBHTQCFU3RANCNFSM4IIEO5RA
.

@telesma take a look at examples of using -container-network flag with Selenoid here: https://aerokube.com/selenoid/latest/#_selenoid_with_docker_compose

@vania-pooh @aandryashin  I have increased all timeout arguments for Selenoid host and on Windows in the meantime and the "[SERVICE_STARTUP_FAILED] does not respond in 30s" error goes away. Indeed the Service gets started but I get another error "[SERVICE_FAILED] 404 Not found"
I will digg further in your suggestion with the network options.

@telesma SERVICE_FAILED means you may have incorrect path parameter in browsers.json. I think it should be path: "/" or just try to remove it.

Most probably you have to correct path in browsers.json and set it to "/".
Please check it.
ср, 31 июл. 2019 г., 15:51 Frank Rossi<EMAIL_ADDRESS>
@vania-pooh https://github.com/vania-pooh @aandryashin
https://github.com/aandryashin I have increased all timeout arguments
for Selenoid host and on Windows in the meantime and the
"[SERVICE_STARTUP_FAILED] does not respond in 30s" error goes away. Indeed
the Service gets started but I get another error "[SERVICE_FAILED] 404 Not
found"
I will digg further in your suggestion with the network options.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23LV5JKJYJA7HGU3T5TQCGDFPA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3HENJQ#issuecomment-516834982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23OLNYW3N2MCIWUPUVTQCGDFPANCNFSM4IIEO5RA
.

I have a running windows/ie:11 docker container with Selenoid inside and the following browser.json and I am able to test successful against the docker container.
browser.json (windows/ie:11):
{     "internet explorer": {         "default": "11",         "versions": {             "11": {                 "image": [ "C:\\Windows\\System32\\headless-selenium-for-win-v1-4\\headless_ie_selenium.exe"]             }         }     } }

However when I want to test against a windows/edge:18 docker container with a running Selenid inside I do get the following error:
Error: Requested environment is not available
C:\selenoid-windows\selenoid_windows_386.exe -conf C:\selenoid-windows\edge18\config\browsers.json -disable-docker -limit 4 -service-startup-timeout 240s -session-attempt-timeout 240s -session-delete-timeout 240s -timeout 240s > C:\selenoid-windows\edge18\opt\selenoid.log 2>&1

browser.json (windows/edge:18)
{
    "MicrosoftEdge": {
        "default": "18.17763",
        "versions": {
            "18.1776": {
                "image": [ "MicrosoftWebDriver.exe", "--host=<IP_ADDRESS>", "--port=4445"]
            }
        }
    }
}

Do you have a hint for me. Seems like Edge 18 Driver is behaving differently.

Please try to change version number to 18 (without fraction part)...
сб, 3 авг. 2019 г., 17:08 Frank Rossi<EMAIL_ADDRESS>
However when I want to test against a windows/edge:18 docker container
with a running Selenid inside I do get the following error:
Error: Requested environment is not available
C:\selenoid-windows\selenoid_windows_386.exe -conf C:\selenoid-windows\edge18\config\browsers.json -disable-docker -limit 4 -service-startup-timeout 240s -session-attempt-timeout 240s -session-delete-timeout 240s -timeout 240s > C:\selenoid-windows\edge18\opt\selenoid.log 2>&1
browser.json (windows/edge:18)
{
"MicrosoftEdge": {
"default": "18.17763",
"versions": {
"18.1776": {
"image": [ "MicrosoftWebDriver.exe", "--host=<IP_ADDRESS>", "--port=4445"]
}
}
}
}
Do you have a hint for me. Seems like Edge 18 Driver is behaving
differently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23IAQM747LTR5C3F6Z3QCWGMHA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PPC3Y#issuecomment-517927279,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23PKW4RDGYQG4JY2FRDQCWGMHANCNFSM4IIEO5RA
.

@aandryashin Looks much better when removing the fraction from the version number. But the process times out.
2019/08/03 14:34:24 [-] [INIT] [Loading configuration files...]
2019/08/03 14:34:24 [-] [INIT] [Loaded configuration from C:\selenoid-windows\edge18\config\browsers.json]
2019/08/03 14:34:24 [-] [INIT] [Timezone: Local]
2019/08/03 14:34:24 [-] [INIT] [Listening on :4444]
2019/08/03 14:34:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [0] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:34:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:34:28 [0] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:34:28 [0] [ALLOCATING_PORT]
2019/08/03 14:34:28 [0] [ALLOCATED_PORT] [50193]
2019/08/03 14:34:28 [0] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50193]]
2019/08/03 14:38:28 [0] [TERMINATING_PROCESS] [7396]
2019/08/03 14:38:28 [0] [TERMINATED_PROCESS] [7396] [0.03s]
2019/08/03 14:38:28 [0] [SERVICE_STARTUP_FAILED] [http://<IP_ADDRESS>:50193 does not respond in 4m0s]
2019/08/03 14:38:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [1] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:38:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:38:28 [1] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:38:28 [1] [ALLOCATING_PORT]
2019/08/03 14:38:28 [1] [ALLOCATED_PORT] [50667]
2019/08/03 14:38:28 [1] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50667]]

Hm, try to modify command and set --host=<IP_ADDRESS>
сб, 3 авг. 2019 г., 17:43 Frank Rossi<EMAIL_ADDRESS>
@aandryashin https://github.com/aandryashin Looks much better when
removing the fraction from the version number. But the process times out.
2019/08/03 14:34:24 [-] [INIT] [Loading configuration files...]
2019/08/03 14:34:24 [-] [INIT] [Loaded configuration from C:\selenoid-windows\edge18\config\browsers.json]
2019/08/03 14:34:24 [-] [INIT] [Timezone: Local]
2019/08/03 14:34:24 [-] [INIT] [Listening on :4444]
2019/08/03 14:34:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [0] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:34:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:34:28 [0] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:34:28 [0] [ALLOCATING_PORT]
2019/08/03 14:34:28 [0] [ALLOCATED_PORT] [50193]
2019/08/03 14:34:28 [0] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50193]]
2019/08/03 14:38:28 [0] [TERMINATING_PROCESS] [7396]
2019/08/03 14:38:28 [0] [TERMINATED_PROCESS] [7396] [0.03s]
2019/08/03 14:38:28 [0] [SERVICE_STARTUP_FAILED] [http://<IP_ADDRESS>:50193 does not respond in 4m0s]
2019/08/03 14:38:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [1] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:38:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:38:28 [1] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:38:28 [1] [ALLOCATING_PORT]
2019/08/03 14:38:28 [1] [ALLOCATED_PORT] [50667]
2019/08/03 14:38:28 [1] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50667]]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23IKDMLUEC527CTGRC3QCWKPXA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PPUNQ#issuecomment-517929526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23NFUWI62GWO5TSCVCLQCWKPXANCNFSM4IIEO5RA
.

Got it working with the following configuration.
browser.json (windows/edge:18):
{
    "MicrosoftEdge": {
        "default": "18",
        "versions": {
            "18": {
                "image": [ "MicrosoftWebDriver.exe", "--host=<IP_ADDRESS>", "--verbose" ]
            }
        }
    }
}

Thank you so much for your help!!!

Or to --host=<IP_ADDRESS>
сб, 3 авг. 2019 г., 17:46 Alexander Andryashin<EMAIL_ADDRESS>
Hm, try to modify command and set --host=<IP_ADDRESS>
сб, 3 авг. 2019 г., 17:43 Frank Rossi<EMAIL_ADDRESS>
@aandryashin https://github.com/aandryashin Looks much better when
removing the fraction from the version number. But the process times out.
2019/08/03 14:34:24 [-] [INIT] [Loading configuration files...]
2019/08/03 14:34:24 [-] [INIT] [Loaded configuration from C:\selenoid-windows\edge18\config\browsers.json]
2019/08/03 14:34:24 [-] [INIT] [Timezone: Local]
2019/08/03 14:34:24 [-] [INIT] [Listening on :4444]
2019/08/03 14:34:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:34:28 [0] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:34:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:34:28 [0] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:34:28 [0] [ALLOCATING_PORT]
2019/08/03 14:34:28 [0] [ALLOCATED_PORT] [50193]
2019/08/03 14:34:28 [0] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50193]]
2019/08/03 14:38:28 [0] [TERMINATING_PROCESS] [7396]
2019/08/03 14:38:28 [0] [TERMINATED_PROCESS] [7396] [0.03s]
2019/08/03 14:38:28 [0] [SERVICE_STARTUP_FAILED] [http://<IP_ADDRESS>:50193 does not respond in 4m0s]
2019/08/03 14:38:28 [-] [NEW_REQUEST] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [-] [NEW_REQUEST_ACCEPTED] [unknown] [<IP_ADDRESS>]
2019/08/03 14:38:28 [1] [LOCATING_SERVICE] [MicrosoftEdge] []
2019/08/03 14:38:28 [-] [DEFAULT_VERSION] [Using default version: 18]
2019/08/03 14:38:28 [1] [USING_DRIVER] [MicrosoftEdge] [18]
2019/08/03 14:38:28 [1] [ALLOCATING_PORT]
2019/08/03 14:38:28 [1] [ALLOCATED_PORT] [50667]
2019/08/03 14:38:28 [1] [STARTING_PROCESS] [[MicrosoftWebDriver.exe --host=<IP_ADDRESS> --verbose --port=50667]]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23IKDMLUEC527CTGRC3QCWKPXA5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PPUNQ#issuecomment-517929526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23NFUWI62GWO5TSCVCLQCWKPXANCNFSM4IIEO5RA
.

Great!
сб, 3 авг. 2019 г., 17:47 Frank Rossi<EMAIL_ADDRESS>
Got it working with the following configuration.
browser.json (windows/edge:18):
{
"MicrosoftEdge": {
"default": "18",
"versions": {
"18": {
"image": [ "MicrosoftWebDriver.exe", "--host=<IP_ADDRESS>", "--verbose" ]
}
}
}
}
Thank you so much for your help!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aerokube/windows-images/issues/8?email_source=notifications&email_token=AAKY23OGNE6FWVXDQAKEAETQCWK77A5CNFSM4IIEO5RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PPW5Y#issuecomment-517929847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKY23LUGGKROZEH3FFJSRDQCWK77ANCNFSM4IIEO5RA
.


[Bug] Investigate OAuth issue faced by eLabNext

An ELN that has an integration with DMP Tool is experiencing auth issues.  They are unable to log in to their accounts through their desktop application that uses the DMP Tool, but can log in with the same account on the website..

Note they sent some videos of the situation that I cannot attach, but are available in email to myself and Brian.

multiple issues here.

The WAF is blocking some of the traffic to these OAuth routes, so need to modify the WAF rules to allow access
Doorkeeper and Devise gems have been upgraded at some point in the past and broken the functionality
Doorkeeper views seem to be unable to access the compiled CSS files
Need to tie the current system's authentication into the OAuth2 authorization flow


[WIP] Handle infinite recursive types

Still struggling to get the right semantics of when to bail out in the unifier. Currently I am getting either bad error messages or errors in typechecking. Making a PR to show WIP though.

I've merged the function branch - you might want to rebase.

This should be a bit better. The first refactoring commit may confuse things a bit but look at the added test cases to see the types of cases that should now be handled instead of causing a stack overflow by continuing to expand aliases.
In most languages this handled by not allowing recursive aliases but I am hoping that the way gluon handles it may work out to be convenient in the end. The short version is just that it expands an alias only when it is not ambiguous to do so and "aliases" are otherwise treated as opaque types. I will try to add some more through explanation on this (and overloading) to the tutorial sometime next week though.

@brendanzab Unless you have some more questions or reservations I think this can be merged?


Getting errors from phpCAS?

Hello:
I've wrapped phpCAS in a Zend_Auth_Adapter_Interface() interface.
Is there a way to get errors from phpCAS so that I can pass descriptions up into Zend_Framework?
Thanks!
Greg

Hi Greg, this is indeed a feature we are lacking right now. We do not have any good integration point for error handling with applications using phpcas. I'm happy to integrate such a commit :-)

Hi, Joachim:
Let me take a look and see what I can do.
Greg


Add Getting Started tutorial to the docs

@hajimehoshi if this is something you are interested in me adding, I would be happy to write a section of the docs that explains how to get started with Ebiten that goes over creating a simple game. Would that be helpful?
Thank you for making and maintaining Ebiten! 🎉

Thank you!


resource/pingone_application_flow_policy_assignment: Removal of policy in DV leads to "FlowId/PolicyId not found" error when the policy is invoked by client app

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.
PingOne Terraform provider Version

Terraform Version

Affected Resource(s)

pingone_application_flow_policy_assignment

Terraform Configuration Files
# Copy-paste your PingOne related Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

# Remember to replace any account/customer sensitive information in the configuration before submitting the issue

TBC

Debug Output

N/a
Panic Output

N/a
Expected Behavior

Replacement of a davinci_application.xyz.policy set object will generate a new policy ID (davinci_application.xyz.policy.policy_id) that should be updated in the pingone_application_flow_policy_assignment resource.  There exists a time when the davinci_application.xyz.policy object is removed from the platform but still assigned on the pingone_application_flow_policy_assignment resource.
When the pingone_application_flow_policy_assignment resource is updated with the new DV policy ID, this should be made successfully and have no negative impact to front end experience.
Actual Behavior

When the davinci_application.xyz.policy object is removed but still assigned to the application with the pingone_application_flow_policy_assignment resource, an inconsistency arises in the application.  The pingone_application_flow_policy_assignment resource can be updated successfully, but the inconsistency remains.
Recommended interim workaround is to replace the tainted pingone_application_flow_policy_assignment resource: Terraform doc link and apply the replace_triggered_by lifecycle argument on the pingone_application_flow_policy_assignment, triggered by the policy_id on the davinci_application resource.
Steps to Reproduce

TBC

Important Factoids

References

https://github.com/pingidentity/terraform-provider-davinci/issues/214
https://registry.terraform.io/providers/pingidentity/davinci/latest/docs/resources/application#policy

This issue has been resolved within the platform APIs, and does not need a provider code change


[Bug]: Share plus dialog is not being closed.

Platform
iPad 15.6.1
Plugin
share_plus
Version
4.1.0
Flutter SDK
2.10.1
Steps to reproduce
Hi, The share plus dialog is not being closed in case one. Suppose I opened the share plus dialog and sent a push notification on my mobile, after clicking on the notification share plus dialog should dismiss. it is not being closed.
Code Sample
No response
Logs
there is no such exceptions related share plus.

Flutter Doctor
[✓] Flutter (Channel stable, 2.10.1, on macOS 12.5.1 21G83 darwin-arm, locale en-IN)
    • Flutter version 2.10.1 at /Users/mayank/Downloads/DownloadedSoftware/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db747aa133 (7 months ago), 2022-02-09 13:57:35 -0600
    • Engine revision ab46186b24
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mayank/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Users/mayank/Downloads/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Users/mayank/Downloads/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] IntelliJ IDEA Community Edition (version 2021.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.67.0)
    • VS Code at /Users/mayank/Downloads/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • iPad (mobile) • 00008020-001859923AE1002E • ios            • iOS 15.6.1 19G82
    • Chrome (web)  • chrome                    • web-javascript • Google Chrome 105.0.5195.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

The plugin does not control the share dialog, only opens it.
I am not sure if there may be a way to dismiss the dialog from Flutter side, but that's not supported at the moment.
Changing this to feature request.

Okay, thanks

Any updates on this? @miquelbeltran

So the notification is from the app that is already opened? I would not expect the pushed ViewController to pop, as the underlying flutter application could handle the click and change its appearance. As for manually closing the share dialogue, we could attempt to instruct the controller to dismiss, using dismissViewControllerAnimated:completion: on UIViewController. I am not sure if this would work though.

I had to close programmatically the share intent on iOS for a project. I successfully implemented a Share.close() method that works great on iOS. My work is here. Not opening any PR because it supports only iOS for the moment. I might take some time to check what we can do on Android.

@Pierre-Monier I think we can do an exception in this case. Feel free to open the PR and we can take a look. Also, the same logic should work on the macOS implementation, no?

Yes it should work on macOS too, but I haven't tried it. I will make a PR then

Sadly, it doesn't work on macOS

I have made some research on Android, sadly it is not possible. We need either root access or an Accessibility service with the related permission to accomplish that. Those solutions are clearly hacky, and I think it should not be merged in this repository.
Related SO post


Properly import goog.History and goog.history.EventType

This closes issue #81

Thanks @Wegi :+1:


⚠ Samsung has degraded performance

In ac972a8, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2703 ms

Resolved: Samsung performance has improved in ae0c52e.


Adding cla-munger.

Adding the CLA munger to work with the linux foundation's CLA bot.

This change is

Is there a reason why we can't add this functionality to the cncf checker bot?

@lavalamp The goal here is to standardize interactions with the bot, which is why we want to add this functionality into the mungegithub bot. The CNCF bot does not notify the user(s) from whom action is required, for example. There is some discussion here in the comments: https://docs.google.com/document/d/1LIwyn5PDSYu8kh-7hH8688lt1cvwATkZmhec13nhp1c/edit#

cc @bgrant0607 @emsearcy

Reviewed 4 of 5 files at r1.
Review status: 4 of 5 files reviewed at latest revision, 3 unresolved discussions.

mungegithub/github/github.go, line 783 [r1] (raw file):

}

// AddLabelIfAbsent adds a single `label` to the issue, if it isn't present already.

I already said that, but I'm not a huge fan here

mungegithub/mungers/cla.go, line 125 [r1] (raw file):

	}
	obj.RemoveLabelIfPresent(cncfClaYesLabel)
	obj.AddLabelIfAbsent(cncfClaNoLabel)

It can't be absent because of the check above

mungegithub/mungers/cla_test.go, line 151 [r1] (raw file):

func setUpMockFunctions(mux *http.ServeMux, t *testing.T, issue *github.Issue) {
	path := fmt.Sprintf("/repos/o/r/issue/%d/labels", *issue.Number)

I think these should leave in mungegithub/github/testing (even if it's becoming more messy everytime ... :-/)

Comments from Reviewable

Reviewed 1 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable

mungegithub/mungers/cla_test.go, line 151 [r1] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> I think these should leave in `mungegithub/github/testing` (even if it's becoming more messy everytime ... :-/)

Some of these cannot live within the testing because they depend on the issues and PRs which are created in the test itself. These two could move, but I'd like to fix the testing portion the right way. I've opened an issue https://github.com/kubernetes/contrib/issues/1654 to refactor it.

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.

mungegithub/mungers/cla.go, line 125 [r1] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> It can't be absent because of the check above

Done.

mungegithub/github/github.go, line 783 [r1] (raw file):
Previously, apelisse (Antoine Pelisse) wrote…
> I already said that, but I'm not a huge fan here

Done.

Comments from Reviewable

Reviewed 3 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

/lgtm

Comments from Reviewable


KAFKA-14533: Do not interrupt state-updater thread during shutdown

Fix the StateUpdater shutdown procedure: a) in shutdown, we first set the running flag, then notify the condition; 2) in the thread's waitIfAllChangelogsCompletelyRead block, we collapse the if condition together with the while condition so that we always check all four conditions once the thread is notified inside the while loop. As a result, shutdown procedure would not involve any thread interruptions anymore.
Print fine-grained streams exception when list-offset fails, this is a byproduct of the debugging procedure but I think it's worth keeping since it has better operational visibilities.
Some nit logging improvements (including moving logger from the inner thread into the outer class to also add some more logging).
Re-enable state-updater in SmokeTestDriverIntegrationTest

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Re-starting new checks as SmokeTestDriverIntegrationTest did not fail again.

SmokeTestDriverIntegrationTest did not fail in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/2, triggering again.

SmokeTestDriverIntegrationTest did not fail in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13318/11, triggering again.
If that run still did not fail SmokeTestDriverIntegrationTest, I think we could be confident here. cc @lucasbru

We had a failure of Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true. I'm pretty sure that one was not flaky before. Any chance this PR breaks it?

@lucasbru did you happen to have triggered a system test for this branch as well?

I triggered one now: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5554/console

ping @cadonna for a final look, this PR needs to go first before the next one.

I triggered one now: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5555/console

@lucasbru the failure seems not related to the code but sock timeouts itself. Have you seen similar scenarios before when working with system tests? Are they okay to ignore or not?

Yeah, these seem to be unrelated. I restarted the job:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5562/consoleText
We have two failures:
test_id:
kafkatest.tests.streams.streams_broker_bounce_test.StreamsBrokerBounceTest.test_many_brokers_bounce.failure_mode=clean_bounce.num_failures=2.metadata_quorum=ZK
kafkatest.tests.streams.streams_upgrade_test.StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces.from_version=2.6.2.to_version=3.5.0-SNAPSHOT

It seems to me that they are unrelated.

@cadonna Thanks for your comments. I've addressed your comments except the nit name.
LMK what do you think as a better name for the class TaskAndAction and I can change the class name, and other field names accordingly.


Preview button not visible at all

Hello,
I am trying to add the preview button, but I don't see it content manager edit page :
I rebuilt with yarn build and yarn develop several times, event tried with npm

My dependencies in package.json

  "dependencies": {
    "@commitlint/cli": "^18.4.2",
    "@commitlint/config-conventional": "^18.4.2",
    "@strapi/plugin-i18n": "4.15.4",
    "@strapi/plugin-users-permissions": "4.15.4",
    "@strapi/strapi": "4.15.0",
    "better-sqlite3": "^9.1.1",
    "strapi-plugin-preview-button": "2.2.1"
  },

my config/plugin.ts
'use strict';

module.exports = {
  'preview-button': {
    config: {
      contentTypes: [
        {
          uid: 'api::dressing.dressing',
          draft: {
            url: 'http://localhost:3000/api/preview',
            query: {
              category: 'dressing',
              locale: '{locale}',
              slug: '{slug}',
              secret: process.env.STRAPI_PREVIEW_SECRET
            },
            openTarget: '_blank',
          },
          published: {
            url: 'http://localhost:3000/dressing/{slug}',
          },
        },
        {
          uid: 'api::cream.cream',
          draft: {
            url: 'http://localhost:3000/api/preview',
            query: {
              category: 'cream',
              slug: '{slug}',
              secret: process.env.STRAPI_PREVIEW_SECRET
            },
            openTarget: '_blank',
          },
          published: {
            url: 'http://localhost:3000/cream/{slug}',
          },
        },
        {
          uid: 'api::compress.compress',
          draft: {
            url: 'http://localhost:3000/api/preview',
            query: {
              category: 'compression',
              slug: '{slug}',
              secret: process.env.STRAPI_PREVIEW_SECRET
            },
            openTarget: '_blank',
          },
          published: {
            url: 'http://localhost:3000/compression/{slug}',
          },
        },
        {
          uid: 'api::cleanser.cleanser',
          draft: {
            url: 'http://localhost:3000/api/preview',
            query: {
              category: 'cleanser',
              slug: '{slug}',
              secret: process.env.STRAPI_PREVIEW_SECRET
            },
            openTarget: '_blank',
          },
          published: {
            url: 'http://localhost:3000/cleanser/{slug}',
          },
        },
      ],
    },
  },
};

the url of my preview should be for example
http://localhost:3000/api/preview?secret=secret&category=dressing&slug=slug

Hi @L-Weisz The only thing I noticed out of place in your config was "@strapi/strapi": "4.15.0", in your package.json. Have you tried changing that to 4.15.4 like the other Strapi dependencies?

Hello @mattmilburn I tried to roll back to 4.14.5, I reinstalled the plugin with  yarn add strapi-plugin-preview-button@latest and solved all dependency warnings but it still doesnt work.
My package is now :
{   "name": "healico-strapi",   "private": true,   "version": "0.1.0",   "description": "A Strapi application",   "scripts": {     "develop": "strapi develop",     "start": "strapi start",     "build": "strapi build",     "strapi": "strapi",     "prepare": "husky install"   },   "devDependencies": {     "husky": "^8.0.3"   },   "dependencies": {     "@babel/core": "^7.0.0-0",     "@babel/runtime": "^7.11.0",     "@codemirror/autocomplete": "^6.0.0",     "@codemirror/language": "^6.0.0",     "@codemirror/lint": "^6.0.0",     "@codemirror/search": "^6.0.0",     "@codemirror/state": "^6.0.0",     "@codemirror/theme-one-dark": "^6.0.0",     "@codemirror/view": "^6.0.0",     "@commitlint/cli": "^18.4.2",     "@commitlint/config-conventional": "^18.4.2",     "@lezer/common": "^1.0.0",     "@strapi/design-system": "1.13.0",     "@strapi/helper-plugin": "^4.13.1",     "@strapi/icons": "1.13.0",     "@strapi/plugin-i18n": "4.14.5",     "@strapi/plugin-users-permissions": "4.14.5",     "@strapi/strapi": "4.14.5",     "@strapi/utils": "^4.13.1",     "better-sqlite3": "^9.1.1",     "codemirror": "^6.0.0",     "lodash": "4.17.21",     "prop-types": "15.8.1",     "qs": "6.11.0",     "react": "^18.0.0",     "react-dom": "^18.0.0",     "react-intl": "6.4.1",     "react-is": "^16.8.0",     "react-router-dom": "^5.2.0",     "strapi-plugin-populate-deep": "^3.0.1",     "strapi-plugin-preview-button": "^2.2.1",     "styled-components": "5.3.3",     "typescript": "^4"   },   "author": {     "name": "A Strapi developer"   },   "strapi": {     "uuid": "4a3dd523-a60c-4e3e-a3d4-42f39d1bac80"   },   "engines": {     "node": ">=18.0.0 <=20.x.x",     "npm": ">=6.0.0"   },   "license": "MIT",   "commitlint": {     "extends": [       "@commitlint/config-conventional"     ],     "rules": {       "body-max-line-length": [         0,         "always",         "Infinity"       ],       "scope-case": [         0,         "always",         "lower-case"       ]     }   } }

Hello @mattmilburn do you have an example of package.json and plugin.ts in typescript  that does work so I can adjust my configuration ? This is the only plugin I want to use so I can modify the version if necessary


Added scroll progress bar

Hey @khushi-joshi-05 and @sunny0625 ,
issue closes #1271
I have added scroll progress bar to the all pages in the website.
Screenshot/Video

Please take a look and review it.

@Tejashri-Taral solve conflicts

@khushi-joshi-05 , done

@khushi-joshi-05 @sunny0625


Update ReadMe to reflect quality levels of client libraries

We will soon have client libraries at different quality levels. Let's make sure we reflect this information in our top-level ReadMe file the moment we cut the new release.
The update for PHP's ReadMe has already be done (as a Pull Request for now) and can be used as the canonical example to follow. The list below highlights the main changes to follow for this repo.
General

[ ] P1: change from Google Cloud Libraries for .NET to Google Cloud .NET Client (for consistency)

Listing Beta client libraries

[ ] Remove the text "The Google Cloud Libraries for .NET support the following Google Cloud Platform services: "

[ ] Create a section to show the Beta client libraries (see image right below for text & layout)

[ ] Make the term Beta link to the Versioning section of the ReadMe (see image right below)

[ ] Add the term (Beta) next to each API name (see image right below for text and visual):

Listing Alpha client libraries

[ ] Create a section to show the Alpha client libraries (see image right below for text and layout)

[ ] Make the term Alpha link to the Versioning section of the ReadMe (see image right below)

[ ] Add the term (Alpha) next to each API name (see image right below for text and visual):

Versioning section

[ ] If the Versioning section doesn't exist, add one.

[ ] Add the following content in the Versioning section:

After discussion with Omar:

We'll leave the name as it is. We have multiple libraries and no single "big" package, so it makes sense for it to be plural
We'll have three pre-release version types: "late beta", "beta" and "alpha", where our "late beta" is like the "beta" above, and "beta" is "we're confident it works, but we expect API churn" vs "alpha" being "pretty experimental - stuff may not work". In future releases we may try to align with the simple alpha/beta, but for the moment these three different levels are useful
As we'll now have redundancy between the readme and the docs, we'll have a tool to generate both sections (this may come later)


Request: Add an example to progressively fill out an amp-form

Similar to http://info.kaplanuniversity.edu/?adpos=1t1&creative=110159095106&device=c&matchtype=e&network=g&source=SF22032&ve=61599&utm_source=Google&utm_medium=CPC&utm_campaign=kuo_lg_mer_RLSA_BR_KW_Kaplan_EXT&utm_term=97625482-VQ2-g-VQ6-110159095106-VQ16-c&adid=3036760956
Details listed in: https://github.com/ampproject/amp-by-example/issues/372#issuecomment-275256317
Some features of the widget could be:
a) Show an animated indicator showing the progress of the form
b) Should allow custom validation on each screen
c) Only reveal the "submit" button in the last screen of the form
This could turn out to be very similar to https://github.com/ampproject/amp-by-example/issues/371 but wanted to capture separately because of additional requirements.

Is this similar to https://ampbyexample.com/dynamic_amp/multi_page_flow/preview/?


Is it possible to connect to a Websocket server?

I have a gameserver (websocket, written in nodejs) that is around.. 20k lines of code :(. I was curious if Godot supports connecting to an HTTP server to make the Websocket handshake?
I found this, but not sure.

@Dillybob92 ~ BTW, it might be better to ask such questions on our QA site.
But still, since you asked, Godot supports connecting to HTTP servers via the HTTPClient and HTTPRequest classes. Also, if in any way they don't support websocket technology, you might open an issue for it, or just switch to a plain old TCP stream connection, which is supported as well :smile: .

@bojidar-bg Awww, thanks. Good idea. I'll check out the classes and docs.

In case anyone is interested, I found this library:
https://github.com/marcosbitetti/Godot-Websocket
And the tutorial: https://www.youtube.com/watch?v=rMnUVm-4fEw
I didn't make it but plan to give it try these days.


Remove old ABI lists

Only keep the ABI lists that we actually use now.

This PR is now subsumed by #6410.


FIX: HB3 Doorbell Known Face detection not coming trough

@martijnpoppen Does this still work? Are you using T8214 doorbell by any chance? I wanted to make the face detection to work for this type of doorbell as well cause I do see the information being there. Just not mapped.

Yes this works but is not merged yet. So for my integration its working

@GijsvanDulmen you can always check my up-to-date branch were i updated this already: https://github.com/martijnpoppen/eufy-security-client/tree/homey-integration

@martijnpoppen Thanks. Got it working in eufy-security-ws. It fixes my HB3 missing face detection!


How to get selected inputs from smart select?

$('.smart-select select')[0].selectedOptions

Use forum for questions


[ruby] Bug in regex character class syntax highliting

regex_sub character-class begin match contains mistakenly closing square brackets.
Patch for vscode/extensions/ruby/syntaxes/Ruby.plist attached.
Ruby.plist.diff.txt

Please create a pull request
https://github.com/Microsoft/vscode/pulls

CC @aeschli


Preflight OPTIONS requests fail with 408 - Request timeout

Bug report

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
When using supabase functions serve to serve all functions simultaneously, the pre-flight 'OPTIONS' request initiated by a browser agent fails.
The server returns Status Code 408 - Request timeout with a message body of {"msg":"Request could not be processed by the server because it timed out or an error was thrown."}
The bug is triggered by the fact that the OPTIONS body is empty
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Use code snippet at https://supabase.com/docs/guides/functions/cors#recommended-setup to setup CORS headers in the serve function
Send OPTIONS request to edge function

Expected behavior
The server should return 200 with the CORS headers set appropriately.
Screenshots

System information

OS: macOS
Browser (if applies) : chrome. Also tested outside browser (Postman)
Version of supabase-js: 2.20.0
Version of Node.js: not relevant

Additional context

If serving the function individually via supabase functions serve <function-name>, the bug does not happen. It only happens when serving all functions simultaneously via supabase functions serve

If calling the function with the POST method directly, the bug does not happen.

Inserting console.log() statements everywhere in the edge function code shows that the script reaches the point where it has to send the response to the OPTIONS request, then crashes silently.

If you put some dummy data into the body of the OPTIONS request, the bug does not happen:

Unfortunately a browser-generated pre-flight request always has an empty body
To me it looks like when I call return new Response('ok', { headers: corsHeaders }) inside the edge function, this triggers the bug because probably the server-side is still waiting for the client to send its body and it does not want to reply with the Response before it can close the incoming connection - but I may be mistaken on my interpretation.
In conclusion, it looks like there may be some code inside edge-runtime that tries to enforce a non-empty body on an OPTIONS request ?

Additional info :

broken somewhere between supabase-cli 1.47.5 and 1.50.4
not solved as of supabase-cli 1.50.8

Linking to supabase-cli as it might be a better place to report

I'm getting this as well. I've also noticed the following behavior. If I send:
OPTIONS http://localhost:54321/functions/v1/function-name

with no headers, the response fails. If I include a body in the options request:
OPTIONS http://localhost:54321/functions/v1/function-name

{
  "name": "test"
}

The response succeeds.

I'm also seeing this. Posted about it on Discord

@soedirgo : Not sure whether this is relevant to edge-runtime, but I think DELETE requests also have an empty body.
Anyways many thanks for the fix 🚀

Additional info :

broken somewhere between supabase-cli 1.47.5 and 1.50.4
not solved as of supabase-cli 1.50.8

Linking to supabase-cli as it might be a better place to report

supabase-cli 1.48.1 is still working. So it must be between 1.48.1 and 1.50.4

cc @laktek I'm not able to reproduce this bug in the latest main. Can we close?

@andreespirela Can you try other HTTP verbs like DELETE and confirm everything works without a request body?

@laktek Getting this instead
{
    "msg": "Error: channel closed"
}

Investigating.

We are weirdly handling when a request has a body
    async fetch(req) {
        const { method, url, headers, body, bodyUsed } = req;

        const headersArray = Array.from(headers.entries());
        const hasBody = false;

        const userWorkerReq = {
            method,
            url,
            headers: headersArray,
            hasBody,
        };

        const { requestRid, requestBodyRid } = await ops.op_user_worker_fetch_build(userWorkerReq);

        // stream the request body
        if (hasBody) {
            let writableStream = writableStreamForRid(requestBodyRid);
            body.pipeTo(writableStream);
        }

        const res = await core.opAsync("op_user_worker_fetch_send", this.key, requestRid);
        const bodyStream = readableStreamForRid(res.bodyRid);
        return new Response(bodyStream, {
            headers: res.headers,
            status: res.status,
            statusText: res.statusText
        });
    }

hasBody
cc @laktek

I'm confused how this could be fixed as I thought that #56 was supposed to fix this and it hasn't been merged. In either case, could we pls get an update when its released?

We are weirdly handling when a request has a body

Agree - See https://github.com/supabase/edge-runtime/pull/69#issuecomment-1525346087

I feel like i'm missing something obvious here but I cannot work out how to get my local supabase to use the latest version.
I've updated supabase CLI via homebrew but it's still pulling down edge runtime v1.2.12 from docker, i've manually deleted all the images and allowed supabase to re pull them but it's still pulling the old version.

@DeanWard We haven't updated Supabase CLI to use the latest Edge Runtime yet. Expect a new release today.

Supabase CLI 1.52.3+ should include the Edge Runtime with the fix. cc: @DeanWard @vejja

@laktek Lakshan - i updated my cli this morning and i only have 1.52.2. when will 1.52.3 be release? thank

Wonderful - fixed !
Thanks guys

@CareTiger 1.52.3 should already be available. Can you try upgrading again?

still doesnt work. serving the request with /home/deno/functions/hello-world Error: channel closed     at async Function.create (ext:sb_user_workers/user_workers.js:75:21)     at async Server.<anonymous> (file:///home/deno/main/index.ts:94:24)     at async Server.#respond (https://deno.land/std@0.182.0/http/server.ts:220:24)

@laktek  supabase --version
1.52.3

@CareTiger Can you share the request you are making? Also, the code for the hello-world function?

I have filed a ticket. my project reference is zkcmpwzbigjgwiesauro. here is the code ```
// @ts-ignore: module not found
import { serve } from "server";
// @ts-ignore: module not found
import { corsHeaders } from "cors";
// console.log("Hello from Functions!");
serve(async (req: Request) => {
if (req.method === "OPTIONS") {
return new Response("ok", { headers: corsHeaders });
}
const { pathname: path, searchParams: query } = new URL(req.url);
console.log(path);
console.log(req.url);
// get the payload from the request
const payload = await req.json();
console.log(payload.user_id);

return new Response(JSON.stringify(`Hello ${payload.user_id}!`), {
    headers: {
        ...corsHeaders,
    },
});

});```

@laktek others are facing the same issue - https://discord.com/channels/839993398554656828/1097177678412533903/1103052379877818419

An update: Looks like @CareTiger's issue was caused due to a bug in CLI handling import maps. Will do a fix for it soon (check the above Discord thread for more details)


User grid: scroll middle of screen iOS

Can't repro

Repro:

Go to poll screen
Scroll a little
Return to main conference screen


First release, package hosting decisions

Prepare for relase
Decide on pypi/conda/github

Released.
Pypi & Conda


Release 1.0.0

This is a very stable library with very small surface area, so I think we're basically going to be fine aggressively moving towards a psychologically "safe" number. It's been tested extensively in Cats Effect, so I don't think we should have any concerns about instability in the implementation.
Cats Effect will want a 1.0.0 release before we're comfortable doing 3.3.0, which will probably happen within about 1-2 months, so I would like it if we could live within that kind of time frame.
IMO we should release an 0.2.0 once @armanbilge runs out of ideas of things to change. ;-) Then let that bake for as long as we feel like, then do a 1.0.0. Process-wise, it'd be great to get @sjrd's blessing on this before we cut 1.0.0.

Now I feel like a dry well but I think we're pretty 👍 on 0.2.0 with the JSDOM fix. I already played with some optimizations in https://github.com/typelevel/cats-effect/pull/2231 but those came up dry as well.
Between now and 1.0 it would be awesome to beef up the testing #18 to prove definitely this works anywhere we might care about, but I think we'd be shocked if this uncovers any issues. It's worth nothing this code has not only been tested in CE, but it's a fairly faithful port of JS code with 12 million weekly downloads.

Process-wise, it'd be great to get @sjrd's blessing on this before we cut 1.0.0.

It looks fine from my side 👍

I'm going to release 0.2.0 on top of current main. We can let that bake for some period of time before pushing out 1.0.0. Note that Cats Effect 3.3.0 will be coming some time within the next six weeks or so (low confidence estimate), and it will want a full release, so that probably puts a cap on the baking time.

Cross posting from https://github.com/scala-js/scala-js/pull/4556: Should we block Scala.js 1.7.1 on this?

@djspiewak ping? The Scala.js 1.7.1 release is currently waiting on your input regarding this.

Word in Typelevel is that Daniel is extremely busy at the moment. IMO macrotask is plenty baked for v1.0.0, we haven't made any meaningful changes since 0.2.0: https://github.com/scala-js/scala-js-macrotask-executor/compare/v0.2.0...main
So I suggest you tag macrotask v1.0.0 yourself and CI will release, or if you wish add me to the repo and I can cut the release (I'm also a maintainer for Cats Effect). Otherwise, better not block Scala.js 1.7.1 on this.

I would prefer not to short-circuit Daniel. So I think we'll release Scala.js 1.7.1 as is. The warning can come later anyway.

Really terribly sorry for being so out of the loop! I can confirm I've been completely swamped beyond normal swamping. Dipping my head above water very quickly for two thoughts…

Let's cut v1.0.0. I think we're good on it and given the level of testing both directly and indirectly, I think we can have a high confidence at least in the API and more likely also in the functionality.
I think it's fine if 1.7.1 goes without the warning, though it'd be nice to sneak it in. There will be a 1.7.2, presumably!

A lot of my urgent fires are starting to die down so I can probably take care of point 1 today.

Done! https://github.com/scala-js/scala-js-macrotask-executor/releases/tag/v1.0.0


[Feature Request] Block registration based on email domain

I would love to be able to block registration to my gitea instance based on the email they use to register, whether or not Gitea is set to send verification emails

Yay :D


no linux/serial.h

unavail in std libs, unable to compile.

Hi!
On which Linux distribution are you trying to compile the program?

Hi Alerighi,
It's in a Alpine container ( HomeAssistant OS )

Alpine Linux doesn't use Glibc but rather uses muslibc. I think that is the issue, since that particular headers are only available on Glibc. I should probably adjust the #ifdef condition to be more specific.
Meanwhile you can just edit the source code and remove the code between the #ifdef __linux__. That particolar system call is not necessary for the software to work.

I've added a check that ensures that include file is not present. Since this is associated with an optional feature we can just ignore it if not present.


Add TcpSocket, a basic TCP socket builder

@Thomasdezeeuw I'm posting this now for early feedback. The work is not done.
This provides TcpSocket, a basic API for building a TCP socket. The
goal is not to provide comprehensive coverage of all system options, but
to provide an API for the most common cases.
This is added now as a replacement for the removal of
TcpStream::connect_std. The connect_std function from v0.6 was used
until now as the strategy to set socket option before obtaining a mio
TcpStream.
Providing some strategy for customizing a TcpStream is required for
Hyper to be able to upgrade.
The TcpSocket API for Tokio is provided
here. There has been
some discussion in Discord related to how to handle configuring a TCP
socket.
I know there is some discussion about using socket2 for advanced
socket configuration. I don't believe TcpSocket and socket2 are
mutually exclusive. TcpSocket provides the ability to configure a
socket while maintaining mio invariants (non-blocking).

@Thomasdezeeuw This is ready to go!


Blog post on MUI

and how we're using it to implement the principles of the USWDS as required by 21st Century IDEA

@abudz19 Would you be interested in working with @jlouis-onrr on this blog post to sum up the work you've done for us?


[Gui] accept args from the general section in bitcoin.conf

An user willing to use his own bitcoind hit this today:

it seems to me his bitcoin.conf should miss [main] section, but why we do not use args if they are in the general section?

why we do not use args if they are in the general section?

The bitcoin.conf file for managed bitcoind is auto-generated with an expected format. As we don't expect any user modifications, it can only parse the file correctly if it has this expected format. We should perhaps add something in the bitcoin.conf file to warn users that manual modifications may cause errors and be overwritten.

i guess this issue happend to an user that try to used its own bitcoind in place of the managed one:

Hmm yeah, it might be they had selected the managed bitcoind option and then made some changes to the config file while importing the pruned node. We could in principle be flexible in the format the bitcoin.conf file takes, but it's simpler to assume a fixed format and I think if the user knows how to edit the file, then they might be better choosing the self-managed node option.

i guess the proper handling of this is document/example of bitcoin.conf


Update to latest NetCDF and HDF5

Build NetCDF 4.6.1 and HDF5 1.10.2 on dunkel and merlot, then copy dunkel build to xtra and new-bock.  Not only for the static libraries for Ferret and PyFerret, but also for the NetCDF executables.

HDF5 and NetCDF updated on dunkel and merlot; also NCO updated to 4.7.5.  NetCDF and NCO executables (static linked libraries) copied to xtra and new-bock.


fix: ensure search params are not left off of load_cache

Closes #10122.
The load_cache has no context of any search parameters that exist on the current path. So when data-sveltekit-preload-data is enabled for links, search parameters were being left off in the navigate function. More specifically, when setting the current variable which is used to inform the from property in BeforeNavigate.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[x] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

I will go bug @tcc-sejohnson for a review!

Hmmm, I'm not sure if this is quite right... if I'm understanding correctly, preloading /foo?bar=baz and then clicking a link for /foo would still navigate to /foo?bar=baz. Maybe I'm wrong -- I'm reading code on mobile. I'll dig in further when I get home.

@tcc-sejohnson this was actually a bit confusing at first for me too!
I'll try my best at a better description:
We're not preloading links that have a search param but without (/foo); when we navigate to /foo, what's saved in the load_cache is /foo. When we have logic inside a beforeNavigate to persist a search param using to and from, the search param ends up getting lost after the first navigation because the value for to gets set via the current variable -- and current this gets set using the load_cache (which in this example currently holds /foo not something like /foo?bar=baz).
Please do let me know if you see a better way to tackle this! For a better understanding of the bug, it'll help to start from the repo in the issue linked or the added test.

Thanks for tackling this!
I think the fix is applied at a point that is too late. If the the search param is appended, a load function dealing with it should see that search param, too - which is not the case with this fix. So I think instead the load_cache should be ignored completely if a mismatch is detected. The root problem is that the id which determines this is computed in get_navigation_intent which is before calling beforeNavigate which could change the search params and therefore the id.
In general I'm wondering if we actually want to fix this. what would happen if someone changes the pathname in beforeNavigate? Then we're at a completely different page. Should we handle that? Should we instead document that these parameters should be treated as readonly and tell people to instead do something like this?
beforeNavigate(({ from, to, cancel }) => {
	const previous_param_value = from?.url.searchParams.get(preserved_param);
	if (typeof previous_param_value === 'string') {
		const url = new URL(to.url);
		url.searchParams.set(preserved_param, 'asd');
		cancel();
		goto(url);
	}
});

Then again, beforeNavigate has no info about any of the additional goto parameters (like noScroll), and it would also need additional checks to handle goto/invalidate etc correctly. So I could also be persuaded to say "search params are a special case which we handle". I'm not sure what the correct approach here is yet.

@dummdidumm really appreciate you taking a look!
Based on what you've shared, I'm also wondering whether this is something we want to explicitly fix -- and whether there's an appropriate "fix" for this based on how/the order of navigation and preloading are currently handled.
I can take some more time this week/next to dig a little deeper on the flow of navigation and see if there may be a better approach!

preview: https://svelte-dev-git-preview-kit-10179-svelte.vercel.app/
this is an automated message

Closing this since I can't reproduce this original issue after upgrading to the latest version of SvelteKit.


[feature suggestion] Colored icons

Hi,
Thanks for the very cool plugin, I really like the simple spirit.
I don't know how difficult it is to implement colored icons, but it would be nice to see an option like this.
Feel free to close this issue if it is against the idea of this plugin.

I know nvim-web-devicons has color support for icons, but I don't know what it would take to show them in the tabline (currently the plugin just slaps a highlight group over the whole tab and calls it a day). I'll take a look at how other tabline plugins implement colored icons when I have a chance this weekend and get back to you re: feasibility.

This was a little trickier than expected, but with some tweaking, barbar.nvim's implementation (which creates a new highlight group using the icon color as the foreground and the original background color) did the trick. I just pushed a new commit with the feature, so let me know if it does what you wanted.

The colored icons work perfectly, one last thing, would it be possible that only the active buffers/tabs have colored icons and the inactive ones do not, otherwise it works exactly as desired, Thanks!

Nice idea – I just added a couple of additional options for icon_colors. Setting it to current should get you what you want.

Works very well, thanks for the quick implementation :+1:


Caching Objection.js SQL queries in server route

Hi,
I'm trying to cache queries where data seldomly changes (also because the DB is dead slow and the response times to the server are shocking).
Relating to https://github.com/Vincit/objection.js/issues/980#issuecomment-400828235
Can you show an example of how you're using catbox to do this?

Yeah, sure.  So the way this works is that you configure caching on your service to provide what is essentially a server method configuration (which contains a catbox policy configuration) for the various methods on your service.
Say you have a service that looks like this, with a method involving a slow query:
'use strict';

const { Service } = require('schmervice');

module.exports = class UserService extends Service {

    async count() {

        const { User } = this.models();

        // Suppose this query below is slow, i.e. if you have millions of users
        return await User.query().resultSize();
    }
};

You could implement caching by simply adding a caching config to the service:
'use strict';

const { Service } = require('schmervice');

module.exports = class UserService extends Service {

    async count() {

        const { User } = this.models();

        // Suppose this query below is slow, i.e. if you have millions of users
        return await User.query().resultSize();
    }

    static get caching() {

        return {
            count: { // <-- the key is the method name
                expiresIn: 1000 * 60 * 15, // Results are good for 15minutes
                generateTimeout: 1000 * 60 // Bail on generation if it's taking over a minute
            }
        };
    }
};

And that's really all there is to it!  You can go very in-depth fine-tuning a caching configuration to have all sorts of different behaviors, particularly when combining the above with a stale timeout. Keep in mind if your method has non-simple arguments that you need to determine a cache key from the args manually by also configuring generateKey in the caching config.  More docs: https://hapipal.com/docs/schmervice#servicecachingoptions.  An example in the hapipal.com codebase: https://github.com/hapipal/hapipal.com/blob/master/lib/services/github.js.

NICE! Thanks for your help.

I had an issue with request params (object) being passed to the function.
Fixed it by changing the cache key:
static get caching() {
    return {
      test: {
        cache: {
          expiresIn: 15 * 1000 * 60,
          generateTimeout: 1000 * 60
        },
        generateKey: params => {
          return JSON.stringify(params);
        }
      }
    };
  }

Can you access the request from withing a service method? Or do I need to pass it as a param?

You can't access it in the service unless you pass it as a method argument.  I usually prefer to write my services to be HTTP-agnostic, so they only very rarely see an actual request object.

Related question. How can I found out if the cache is old?
I've built a proxy API that calls a third party endpoint and I'd like to see if my servive cache is too old. If it is, then call the third party API again.


Adds support for configure option --enable-yaml-headers

=> Gives build-time control for exporting yaml-cpp headers from
trafficserver. By default, headers won't be exported.
=> Enhances support added in following commit:
a71a815dacea967b3e02a1f103b7ae199d993913 (Export headers for internal
YAML-CPP library)
=> Allows client-code to keep using their own yaml-cpp headers without
any interference from yam-cpp headers in trafficserver

[approve ci]

[approve ci ubuntu]

I'm confused about why we would need this.  I think all the include statements would be of the form:
#include <yaml-cpp/blahblah.h>

Is there a distinct library which is also called yaml-cpp?  If the plugin dynamically links with a different version of lib than the core does, or some other lib where there are name collisions, I don't think not exporting the headers will help with that.

Re: https://the-asf.slack.com/archives/CHQ1FJ9EG/p1584142660322600 could you solve this by changing the order of the -I options in your compiles?

Re: https://the-asf.slack.com/archives/CHQ1FJ9EG/p1584142660322600 could you solve this by changing the order of the -I options in your compiles?

More on that front has been discussed here:
https://the-asf.slack.com/archives/CHQ1FJ9EG/p1584222243334200
To summarize:
Agreed that changing the order of -I statements could solve the issue in theory. But changing the order of -I statements to ensure a specific order at build time adds unnecessary burden on build infra (atleast in case of Linkedin) - it has deal with one more complexity to deal with a situation which is a result of a recent change - https://github.com/apache/trafficserver/commit/a71a815dacea967b3e02a1f103b7ae199d993913
The simplest approach would be to solve the problem at its root like this PR is doing. I can imagine that other people who want to use their own yaml library (not the one which comes with trafficserver) could run into similar issues. Having the support being added as part of this PR should make life simpler for every user who wants to do that.

Cherry-picked to v9.0.x branch.

Ship it.


Adds go modules for v4 branch

This patch adds Go Modules support, with the library being versioned as v4 ( github.com/gobuffalo/pop/v4 ).

I notice that this would also require updating import paths within the library. I'd like an indicator first though if this is something that would be merged.

I believe this is being done by core maintainers and will thus close this issue.

It is, but will be v5 since it's such a big change requiring everyone to use go modules


docs(module): update module.type naming change

Resolves https://github.com/webpack/webpack.js.org/issues/3195
Changed in https://github.com/webpack/webpack/pull/9415.

All webpack 5 milestone issues must be targeting next branch and be branched off next

Thanks!


Linux: undefined symbol problem when loading hdCycles.so

Hi,
I am trying to run hdCycles under Ubuntu20.04 with USD20.08 and the current version of cycles (master branch).
Everything compiles without any problems but when I try to activate hdCycles in usdview I get the following error:
'Failed to load plugin 'hdCycles': /home/sherholz/USD20.08-local/plugin/usd/hdCycles.so: undefined symbol:  _ZN3ccl9BVHParams15best_bvh_layoutENS_15KernelBVHLayoutEi in '/home/sherholz/USD20.08-local/plugin/usd/hdCycles.so''
As described in the documentation I compiled cycles with the:
-DCMAKE_POSITION_INDEPENDENT_CODE=ON

option turned on.
Plotting the linking command for hdCycles it looks like the corresponding cycles libraries are linked correctly:

[ 72%] Linking CXX shared library hdCycles.so
cd /home/sherholz/Develop/hdcycles/build/plugin/hdCycles && /usr/bin/cmake -E cmake_link_script CMakeFiles/hdCycles.dir/link.txt --verbose=1
/usr/bin/c++ -fPIC  -std=c++11 -Wall -Wno-deprecated -Wno-deprecated-declarations -Wno-unused-local-typedefs  -O3 -DNDEBUG  -shared -Wl,-soname,hdCycles.so -o hdCycles.so CMakeFiles/hdCycles.dir/Mikktspace/mikktspace.c.o CMakeFiles/hdCycles.dir/basisCurves.cpp.o CMakeFiles/hdCycles.dir/camera.cpp.o CMakeFiles/hdCycles.dir/instancer.cpp.o CMakeFiles/hdCycles.dir/light.cpp.o CMakeFiles/hdCycles.dir/material.cpp.o CMakeFiles/hdCycles.dir/mesh.cpp.o CMakeFiles/hdCycles.dir/points.cpp.o CMakeFiles/hdCycles.dir/renderDelegate.cpp.o CMakeFiles/hdCycles.dir/rendererPlugin.cpp.o CMakeFiles/hdCycles.dir/renderPass.cpp.o CMakeFiles/hdCycles.dir/renderParam.cpp.o CMakeFiles/hdCycles.dir/config.cpp.o CMakeFiles/hdCycles.dir/renderBuffer.cpp.o CMakeFiles/hdCycles.dir/utils.cpp.o  -Wl,-rpath,/home/sherholz/USD20.08-local/lib::::::::::::::::::...
...
...
/home/sherholz/Develop/cycles/build/lib/libcycles_bvh.a /home/sherholz/Develop/cycles/build/lib/libcycles_device.a /home/sherholz/Develop/cycles/build/lib/libcycles_graph.a /home/sherholz/Develop/cycles/build/lib/libcycles_kernel.a /home/sherholz/Develop/cycles/build/lib/libcycles_render.a /home/sherholz/Develop/cycles/build/lib/libcycles_subd.a /home/sherholz/Develop/cycles/build/lib/libcycles_util.a /home/sherholz/Develop/cycles/build/lib/libextern_clew.a /home/sherholz/Develop/cycles/build/lib/libextern_cuew.a /home/sherholz/Develop/cycles/build/lib/libextern_numaapi.a
...
...

Any ideas or am I missing something essential?

Hi,
I solved the problem by rearranging the order in which the cycles libraries are linked in.
The cycles_bvh library was linked first but the functions provided by it are used by a later library (i.e., cycles_render).
I filed a pull request with a patch for that problem (#5)


security/detect-object-injection false alarm on type safe key

What version of eslint-plugin-security are you using?
1.7.1
ESLint Environment
Node version:
npm version:
Local ESLint version:
Global ESLint version:
Operating System:
What parser are you using?
@typescript-eslint/parser
What did you do?

Configuration
    "extends": [
      "standard-with-typescript",
      ...
      "prettier",
      "plugin:security/recommended"
    ],

What did you expect to happen?
Bypass security/detect-object-injection when type safe.
const kfoo = Symbol('foo')
const kbar = 'bar'
const o: Partial<Record<typeof kfoo | typeof kbar, 42>> = {}

o[kfoo] = 42
o[kbar] = 42

What actually happened?
const kfoo = Symbol('foo')
const kbar = 'bar'
const o: Partial<Record<typeof kfoo | typeof kbar, 42>> = {}

// eslint-disable-next-line security/detect-object-injection
o[kfoo] = 42
// eslint-disable-next-line security/detect-object-injection
o[kbar] = 42

Participation

[ ] I am willing to submit a pull request for this issue.

Additional comments
Related https://github.com/typescript-eslint/typescript-eslint/issues/7194

Bypass security/detect-object-injection when type safe.

What does this mean?

Again, I'm not quite sure what you're asking.
ESLint doesn't interpret code, it just looks for simple patterns. If you're implying that something in the first code block means the code in the second block shouldn't warn, that's not something this rule can do. It's not going to interpret TypeScript (which is expensive) to figure out if a later pattern would work.

@nzakas
Quote reply from https://github.com/typescript-eslint/typescript-eslint/issues/7194

Unlike ESLint core - 3rd party plugins aren't restricted to just supporting JS and can support TS and consume types.
For this reason we do not create extension rules for 3rd party rules - we are not looking to compete with other plugins in the community.

It would be nice to let security/detect-object-injection have better typescript support within eslint-community/eslint-plugin-security.

It's not going to interpret TypeScript (which is expensive) to figure out if a later pattern would work.

Compare to human time, machine time is not so expensive.
Given

typescript obj[variable_key]

Would be nice to have option

ignore security/detect-object-injection when variable_key is subset of keyof typeof obj

As I mentioned, that type of check is expensive and not worth implementing. However, because this is an open source project, you can always copy the rule and make your own that does exactly what you want.