Bug: Any non-plaintext content pasted into chat from Pidgin appears as [object Object]

I have an OpenFire chat server with a Candy interface.  When pasting links (or any other non-plaintext content) into the Pidgin window, they appear as [object Object] in the Candy chat window.  Links pasted into Candy function normally.
In the screenshots below, the message at 4:28:08 was pasted into the Candy chat window, and is formatted correctly.  The message at 4:28:18 was pasted into the Pidgin chat windows, and appears in Candy as [object Object].  The preceding text is also removed.

This error exists in Firefox, Chrome, IE, and Edge.
Server setup:
OpenFire Server 3.10.3
CentOS 7.1.1503
Candy 2.1.0
Pidgin 2.10.11
Apache HTTPD 2.4.6-31.el7.centos.1.x86_64

Would you please provide debug logs from your browser console so that I can see what message Candy actually received?

Let me know if you need any more logs.  Thanks.
[Strophe][DEBUG]: request id 13.1 state changed to 2
candy.min.js (line 1)
[Strophe][DEBUG]: request id 13.1 state changed to 3
candy.min.js (line 1)
[Strophe][DEBUG]: request id 13.1 state changed to 4
candy.min.js (line 1)
[Strophe][DEBUG]: removing request
candy.min.js (line 1)
[Strophe][DEBUG]: _throttledRequestHandler called with 0 requests
candy.min.js (line 1)
[Strophe][DEBUG]: request id 13 should now be removed
candy.min.js (line 1)
[Strophe][DEBUG]: request id 13.1 got 200
candy.min.js (line 1)
[Strophe][INFO]: _dataRecv called
candy.min.js (line 1)
RECV: https://github.comhttps://github.com
candy.min.js (line 1)
[Jabber] Message
candy.min.js (line 1)
[Jabber:Room] Message
candy.min.js (line 1)
[Strophe][INFO]: no requests during idle cycle, sending blank request
candy.min.js (line 1)
[Strophe][DEBUG]: request id 14.0 posting
candy.min.js (line 1)
[Strophe][DEBUG]: request id 14.0 state changed to 1

After 2 hours searching. I found it under line 4676.
Cahnge:
from: if (xhtmlMessage !== undefined && xhtmlMessage.length > 0) {
to: if (xhtmlMessage !== undefined && xhtmlMessage.length > 1) {
it looks like openfire is set the xHTML-Message with an "blank" instet of empty.
I put a log line in the if, so i could see this:
Log entry in code: Candy.Core.log("[show] renderXhtmlMessage: " + JSON.stringify(xhtmlMessage));
Result with length > 0:
[show] renderXhtmlMessage: {"0":{},"length":1}
sorry for my bad English, i'm a german potato ;)

Same here:

Candy 2.1
Chromium 47
Prosody 0.9.8

RECV: <message xmlns='jabber:client' type='groupchat'<EMAIL_ADDRESS><EMAIL_ADDRESS>id='purple18e1021'>testing webclient https://jabber.me.net/
testing webclient https://jabber.me.net/
</message>

Oh, I see... When setting enableXHTML to true, then this is not an issue anymore =) One should properly read the docs before complaining

Tested setting enableXHTML to true, but the bug persists.

I think with enableXHTML: false we should see  content as usual, not [object Object]?

The "enableXHTML: true" statement belongs in the view: section. Took me a bit to figure that out.

But adding "enableXHTML: true" in the view-options results in the following error:
function Candy.Core.Event</a.Jabber.Presence()  - error -  Error: Syntax error, unrecognized expression: testuser joined the room.
Stack-Trace:
at.error@https://example.com/candy/candy/jquery.min.js:4:15710
mt@https://example.com/candy/candy/jquery.min.js:4:21596
kt@https://example.com/candy/candy/jquery.min.js:4:24325
at@https://example.com/candy/candy/jquery.min.js:4:10694
.find@https://example.com/candy/candy/jquery.min.js:5:21209
x.prototype.init@https://example.com/candy/candy/jquery.min.js:4:1142
x@https://example.com/candy/candy/jquery.min.js:4:225
Candy.Util</a.parseAndCropXhtml@https://example.com/candy/candy/candy.min.js:1:6679
Candy.View.Pane</a.Chat.onInfoMessage@https://example.com/candy/candy/candy.min.js:2:10728
Candy.View.Pane</a.Chat.infoMessage@https://example.com/candy/candy/candy.min.js:2:10553
Candy.View.Pane</a.Roster.showJoinAnimation@https://example.com/candy/candy/candy.min.js:3:3619
Candy.View.Pane</a.Roster.update@https://example.com/candy/candy/candy.min.js:3:672
Candy.View.Observer</a.Presence.update@https://example.com/candy/candy/candy.min.js:2:5246
x.event.dispatch@https://example.com/candy/candy/jquery.min.js:5:14077
x.event.add/v.handle@https://example.com/candy/candy/jquery.min.js:5:10849
x.event.trigger@https://example.com/candy/candy/jquery.min.js:5:13253
.triggerHandler@https://example.com/candy/candy/jquery.min.js:5:20849
Candy.Core.Event</a.Jabber.Room.Presence@https://example.com/candy/candy/candy.min.js:1:31021
Candy.Core.Event</a.Jabber.Presence@https://example.com/candy/candy/candy.min.js:1:26291
f.Handler.prototype.run@https://example.com/candy/candy/libs.min.js:1:15817
f.Connection.prototype._dataRecv/<@https://example.com/candy/candy/libs.min.js:1:22445
f.forEachChild@https://example.com/candy/candy/libs.min.js:1:8462
f.Connection.prototype._dataRecv@https://example.com/candy/candy/libs.min.js:1:22278
Strophe.Bosh.prototype._onRequestStateChange@https://example.com/candy/candy/libs.min.js:2:6782
 Syntax error, unrecognized expression: testuser joined the room.


testing for fiat CI

We don't have fiat CI https://github.com/fedimint/fedimint/actions/runs/7735421361/job/21091050141?pr=4197#step:6:1620


Y-axis log scale to respect "min" and "forceNiceScale" options

Summary
Have logarithmic y-axes respect the given min option, and only use 'nice' values when the forceNiceScale option is true.
Currently, when using a logarithmic y-axis, the min option isn't really used (except checking if it's 0) and the forceNiceScale option doesn't do anything.
I'd like it if the scale always used the given min/max values if given and if forceNiceScale=false. When forceNiceScale=true, the generated scale would simply use the multiples of the base above and below the data's highest and lowest y values.
API Changes
The API would be the same, though it might make sense for forceNiceScale to default to true if the axis is set to logarithmic, as this would be closest to current behavior? Though I'm not sure if the forceNiceScale default value can depend on another option's value?
Intended Use Case
I had some data that was logarithmic but was roughly between 300-2000. I could only get the axis to go between 1 and 2000 which left most of the graph empty and made it hard to see what my data was doing. With my changes it's much easier.

I've tried to follow these guidelines and have forked, committed my proposal in a new branch and created a pull request #3126 . Though this is my first time contributing to a public repo, and doing a PR (and doing node.js stuff!) so apologies if I've scuffed something.

Looks like this issue can be closed?

Yeah, I agree. There's still a couple of tests that fail from that PR (related to multiple y-axes) due to another issue but I've explained those in the PR and they can be tracked there or separately. If I get time I'd like to end up using multiple y-axes so may bump into it again and have another look but for the moment, no time!


Error in test library 'KeywordLibraryName' : Creating keyword 'keywordname' failed: Keyword with same name defined multiple times. When calling a component keyword through a page object keyword

Hello All,
I am facing a very strange issue with my robot framework tests.
I have created some user libraries and added some keywords.
my tests were working fine.
Once without making changes to my code (at least I am not aware I did), i am facing the following error for all my keywords of all my libraries.
Error in test library 'ReservationPage': Creating keyword 'Add Message To Hotel' failed: Keyword with same name defined multiple times.
Any help would be appreciated

Somehow you must have the same keywords defined twice...
Though this is not an issue and should not be raised in GitHub.
You should ask the question in the user mailing list).
And try to give more information about the failure (maybe try to give some informations how to reproduce your issue with a small config/dataset)

This is most likely caused by a fix for #2097 in RF 2.9.1. Do you have a static library (i.e. Python or Java code that directly implements library methods, the most common case) or a hybrid or dynamic library (i.e. library that uses get_keyword_names to tell which keywords it contains)?
Notice that the fix for #2097 has already caused issues as it broke compatibility with the AutoItLibrary (#2147). That problem was fixed with a small change to how dynamic and hybrid libraries are handled, but the fix hasn't yet been released.

Thanks Pek, yes I do have user defined python libraries and I am using the page object library. After some debugging I found out that this error is caused by a page object library calling a component library keyword. So this is a kind of embedded argument keyword. I guess I have to wait for the 3.0 version for a fix. Do you know when will be the release date for 3.0?

This error is not related to keywords with embedded arguments. Because what they match depends on the actual embedded arguments used, conflicts with them are only detected at runtime.
The PageObjects library you use is a dynamic library that returns keywords it contains from get_keyword_arguments. It seems the list it returns contains duplicates and Robot, since 2.9.1, doesn't like that. Hopefully they are exact duplicates (e.g. my_name and my_name), because in the forthcoming 2.9.2 that is OK (this was the fix for AutoItLibrary in #2097). If they are not exact duplicates but are normalized to same keyword name (e.g. my_name' and myName`), they won't work in the future either.
It would be great if you could clone the latest Robot sources, install it, and test does the problem go away or not. If it goes away, then #2097 has fixed it too. If not, we can still try to investigate this further to make sure we understand the root cause.

Any new information about this @ZiedWD? We've just released RF 2.9.2 which contains the fix for #2147. Could you test do you still get errors with it?

I have upgraded my robot framework version to 2.9.2 and I confirm that the issue is resolved,  am not getting the error anymore.

Great! The root cause apparently was the same as in #2147.


Refactor test data

It seems like the test data including whole period of results for each indicator is ready to be used. If it is correct, I'm planning to write unit tests using xlsx files in each indicator directory. Is it available now?

https://github.com/DaveSkender/Stock.Indicators/pull/553

Can I know the reason why you are not using them?

Can I know the reason why you are not using them?

I tend to clean up the Excel files for formatting so they tend to not have a stable layout that might break the test data importer.  Since I tend to do TDD, it's not unusual for me to come back and revise the reconcile calculations throughout the development process.
I do actually review the full results and compare them.  In the spreadsheets, you'll see manual calcs (blue table) and indicator output (yellow); so essentially I am already doing a full compare.
It makes the whole test much slower overall to import results.  CSV import is much faster than Excel and JSON; however, CSV is still a lot slower than sampling.  Sampling is still a statistically acceptable approach.
I'm lazy and it's a low ROI effort.  There are several alternate test scenarios for each indicator and it could be a lot of work to switch them over, with only a little added benefit.  It would have been much easier to start with that approach.

Your words make sense. I thought using spreadsheet having whole period of results can make writing unittest faster, without losing its original goal.
Anyway, I'll put off switching it.


Update Shoukou

About the PR
Added a secdrobe, cell rechargers, and a maxPlayers value in the prototype.
Changelog

:cl:

add: Added max player count of 65 for Shoukou to be selected in lobby.

Test failed for seemingly no reason. Not really sure what it means by "entity 5"

This is the same error that's come up before. The release build succeeded, so it's probably fine.


Wrong number parsing

I got wrong number parsing result when import from excel.
My result

SSF format

My handle code
`handleFile(e) {
var files = e.target.files, f = files[0];
var reader = new FileReader();
var rABS = true
var _this = this;
reader.onload = function(e) {
var data = e.target.result;
if(!rABS) data = new Uint8Array(data);
var workbook = XLSX.read(data, {type: rABS ? 'binary' : 'array'});
		  /* DO SOMETHING WITH workbook HERE */
		  _this.to_json_first_sheet(workbook)
		  console.log(workbook)
		};
		if(rABS) reader.readAsBinaryString(f); else reader.readAsArrayBuffer(f);
	}

to_json_first_sheet: function(workbook){
var result = {};
var _this = this;
var sheetName = workbook.SheetNames[0];
var roa = _this.X.utils.sheet_to_json(workbook.Sheets[sheetName],{});
console.log(roa)
if(roa.length) result = roa;
return result;
}
`
My excel file  ( github doesn't accept xls file so I updated it into google driver)
https://drive.google.com/file/d/1l1TLlycLpYjrhWzpO5fUipp-UCO49rzU/view

Thanks for sharing!  This is a BIFF4 file using codepage 932 with FORMAT records that specify 0 index.  Need to dig further, but if the index is always zero then replicating the BIFF2/3 logic for BIFF4 would solve the problem:
--- a/bits/76_xls.js
+++ b/bits/76_xls.js
@@ -486,7 +486,12 @@ function parse_workbook(blob, options/*:ParseOpts*/)/*:Workbook*/ {
                                        sst = val;
                                } break;
                                case 'Format': { /* val = [id, fmt] */
-                                       SSF.load(val[1], val[0]);
+                                       if(opts.biff == 4) {
+                                               BIFF2FmtTable[BIFF2Fmt++] = val[1];
+                                               for(var b2idx = 0; b2idx < BIFF2Fmt + 163; ++b2idx) if(SSF._table[b2idx] == val[1]) break;
+                                               if(b2idx >= 163) SSF.load(val[1], BIFF2Fmt + 163);
+                                       }
+                                       else SSF.load(val[1], val[0]);
                                } break;
                                case 'BIFF2FORMAT': {
                                        BIFF2FmtTable[BIFF2Fmt++] = val;

mm. well thank you so much for helping me but I still confuse

This is a BIFF4 file using codepage 932 with FORMAT records that specify 0 index

first how could I get this information above, workbook file or work sheet properties ?
second I still don't know how to implement to read data.

@SheetJSDev
Could you explain this. Thank you

This is a BIFF4 file using codepage 932 with FORMAT records that specify 0 index
first how could I get this information above, workbook file or work sheet properties ?
second I still don't know how to implement to read data.

@ToujouAya we are releasing 0.11.11 right now with the fix.  Give it some time to show up on NPM and CDNs.  Your code should work as-is.

@SheetJSDev
Oh thank you so much. I appreciate


[DOCS] : Link License and Contributing.md to ReadMe

Description
Is your feature request related to a problem? Please describe.

Improving the docs by adding the LICENSE and contributing.md links to the ReadMe file.

Describe the solution you'd like

I would like to add the links of LICENSE and Contributing.md at the bottom of the readme file so as to make the readme more structured.

Anything else?
No response

I would like to work on this @aayushchugh

@shashankbhatgs go ahead


[IAM Policy] adds elasticfilesystem:TagResource permission

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
Extends the IAM Policy to add the following permission to match to what is in main Helm chart:
https://github.com/kubernetes-sigs/aws-efs-csi-driver/commit/cd41c38c9902505e14337d4967f929027ce6c417
For some reason efs-csi-driver fails to create EFS AP on some of my clusters, while it still works on others. Can't really understand the difference but adding the above to IAM Policy fixes it, so since that shouldn't cause any harm I propose to add this to the official tf provider which you maintain.
What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING.md doc.
[ ] I have added necessary documentation (if appropriate).
[ ] Any dependent changes have been merged and published in downstream modules.

When will this be merged? I think it's a critical fix, otherwise, we won't be able to bind the PVC successfully.

When will this be merged?


[send to memo] it show "Check that API MEMO URL is correct", but in fact it's effected

Extension
https://www.raycast.com/ahonn/send-to-flomo
Description

Steps To Reproduce
No response
Current Behaviour
No response
Expected Behaviour
No response

@ahonn / @fankaidev does anyone of you have the possibility to check this? I don't have an API key

@stuchilde
I can't reproduce it here, please try if you can reproduce it again and provide more details (screen recording, etc.).
From the code implementation, it looks like there may be a problem with flomo's API response.


Ability to update extension packs through VSIXs

Currently installing a VSIX is always considered as fresh install and in case of an extension pack we install completely. It would be nice if one can update extension packs through VSIX and install only newly added extensions to extension pack.

//CC @jakebailey
Python insiders uses the installExtension command to install prerelease versions of the extension. They are now looking for an install command that has the same behaviour as the VS Code's builtin update already has:

Any extension in the pack that has been uninstalled is not reinstalled on update.
Any extension in the pack that is new is now installed.

Added an install option installOnlyNewlyAddedFromExtensionPackVSIX to the existing install command. Enabling it will install only newly added extensions in the extension pack. This flag is considered only while installing VSIX.
Eg:
vscode.commands.executeCommand('workbench.extensions.installExtension', vscode.Uri.file('/users/sandy081/downloads/ms-python.python-2021.5.842923320.vsix'), { installOnlyNewlyAddedFromExtensionPackVSIX: true })


File -> New Window does not open new window

VSCode Version:

Version: 1.34.0-insider (system setup)
Commit: 7f0f3e4bbb3f1b81d85d51af0cfc2f7f13b629c2
Date: 2019-04-17T07:54:45.003Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

OS Version:

OS Name	Microsoft Windows Server 2019 Datacenter
Version	10.0.17763 Build 17763
Other OS Description 	Not Available
OS Manufacturer	Microsoft Corporation
System Name	tech
System Manufacturer	Microsoft Corporation
System Model	Virtual Machine
System Type	x64-based PC
System SKU	Unsupported
Processor	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz, 2295 Mhz, 2 Core(s), 2 Logical Processor(s)
BIOS Version/Date	American Megatrends Inc. 090007, 02/06/2017
SMBIOS Version	2.3
BIOS Mode	Legacy
BaseBoard Manufacturer	Microsoft Corporation
BaseBoard Product	Virtual Machine
BaseBoard Version	7.0
Platform Role	Desktop
Secure Boot State	Unsupported
PCR7 Configuration	Binding Not Possible
Windows Directory	C:\windows
System Directory	C:\windows\system32
Boot Device	\Device\HarddiskVolume1
Locale	United States
Hardware Abstraction Layer	Version = "10.0.17763.404"
User Name	Not Available
Time Zone	GMT Daylight Time
Installed Physical Memory (RAM)	7.00 GB
Total Physical Memory	7.00 GB
Available Physical Memory	2.59 GB
Total Virtual Memory	8.12 GB
Available Virtual Memory	3.59 GB
Page File Space	1.13 GB
Page File	D:\pagefile.sys
Kernel DMA Protection	Off
Virtualization-based security	Not enabled
Device Encryption Support	Reasons for failed automatic device encryption: Feature is not available, TPM is not usable, PCR7 binding is not supported, Hardware Security Test Interface failed and device is not InstantGo, Un-allowed DMA capable bus/device(s) detected, WinRE is not configured, TPM is not usable
A hypervisor has been detected. Features required for Hyper-V will not be displayed.

Steps to Reproduce:

File -> New Window
Does not open a new window. Instead the existing window is just reset.

Fixed in:
Version: 1.34.0-insider (system setup)
Commit: 6d5feae57959287fb116467f4eb6c7079571b466
Date: 2019-04-17T09:25:49.535Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763


Prevent secrets from being exposed

The Hetzner API token should not be exposed in case of any errors, as you can see at #8.

Ah wow, learning a lot today! :) Perfect.


Allow fuzzy searching

For #999

Grabbed a small levenshtein function, and overrode the search filter to use that. Only tested basic searching, I'm sure there are things that used to be found that aren't now. let me know, easy enough to fix.

Merge conflict is due to https://github.com/perl6/doc/commit/b7f0e9de59291320b60bcdf87b0203acd6edd91a

force pushed a rebase without a conflict.

Thanks.


improve url parsing, client error logging, include version in user-agent

improve url parsing with parse_host func and log problems faster
improve ambiguous client errors messages in the authorize func. Tell the user if they were redirected, and add specific messages for 403s and 502s.
add the version of the batch-scoring script in the user-agent header

Coverage decreased (-1.0%) to 83.622% when pulling 15fa8ba1bd2954c28db7daf0a552e572259fbf5c on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.622% when pulling a0c3949a94a0cc7e30ddd4bddbf4965d1b1b9334 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.622% when pulling b023c9d18ffb2389e834aac5aff367748bc3e85e on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.622% when pulling b023c9d18ffb2389e834aac5aff367748bc3e85e on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

@datarobot/predictions

Coverage decreased (-1.0%) to 83.638% when pulling 3a9a08e423358ea7748310db8135aa89c5e13490 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.638% when pulling 3a9a08e423358ea7748310db8135aa89c5e13490 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.638% when pulling 3a9a08e423358ea7748310db8135aa89c5e13490 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

We need to reflect in docs of changes that now /api addin by default.

Coverage decreased (-1.0%) to 83.638% when pulling 3430c7d01454f1783a39ae287cc751067f6e3003 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

Coverage decreased (-1.0%) to 83.638% when pulling 93adc138fd16619ba236d182a6326b347a111104 on matt/186bugfix into b91d50d9a19e25ff99cda125be95a7518abc9b73 on master.

LGTM, let's merge it on green.


Some build fixes (changed sq API, and a missing file on iOS)

I ran into the sq changes by installing sq on my new laptop; this was the first release build I've done on it.

Thanks! Revision pushed.

Thanks! Looks good; merging.


Add support for setting audio attributes in ExoPlayer

<Video
audioUsage={'alarm'} //Sets audio attribute usage to "USAGE_ALARM" (default is USAGE_MEDIA)
audioFlags={'audibility_enforced'} //Sets audio attribute flag to "FLAG_AUDIBILITY_ENFORCED" (default is none)
audioContentType={'speech'} //Sets audio attribute content type to "CONTENT_TYPE_SPEECH" (default is CONTENT_TYPE_UNKNOWN)
/>
Provide an example of how to test the change
Set the "audioUsage" to "alarm", mute the main "music" audio stream on Android, and watch as you're able to hear the audio from the video via a different stream.
Describe the changes
This PR allows you to set the various audio attributes on an ExoPlayer instance via the  element.  Currently, this library lacks the ability to do so.

@cobarx Please let me know if these changes make sense.  Thanks!

Yes it makes sense. Ideally, we need a common API that will work on iOS & Android, so I'm hesitant to merge something that's very specific to the way Android handles things and then have a completely different API down the road for iOS.
I did a writeup covering what I found out how iOS & Android handle audio configuration here:
https://github.com/react-native-community/react-native-video/issues/1103
I still think that API makes sense. However, we can add the configurable options for the type of the content to supplement it. I also curious if we need to handle audio focus.
We also need to think about if there are multiple media items playing at the same time. Expo does an extremely good job of this, they evaluate all the items with audio and give the item that needs the most permissions priority.
Would you be open to spending a bit of time hashing out a cross platform API before we start looking the PR. Also, do you have time to tackle this for iOS as well. I'd like to get this all in place at once if possible. This is probably the most requested feature, so it's very important we get this right the first time.

@cobarx I'll be happy to help hash out a different API that would be more cross platform, but unfortunately I don't have the gear to do the iOS work.  Will gladly do the Android changes if that helps though

Also, we've forked the repo since we needed the changes in this PR on Android only (on iOS the defaults work as we would want them) and it's working great out of the box so if anyone else needs until it's merged, I definitely recommend.


mAP of 0.39 on DOTA validation set

Using the provided trained-weights R2CNN and config files, I am getting 0.39 mAP on validation set of DOTA. it's right?   @yangJirui @yangxue0827

This code has 60+ mAP. @heping0228


Modifications to GuildBanAdd, closes #29 #33

Fixes #29
Fixes #33

Hey, thanks for all the help!  I really do appreciate it.  With the Delete Comments addition I'd actually like to add that to the existing GuildBanCreate function instead of making a new function for it.  I'd like to have this match how the ChannelMessages func works.  Just add a check if days is over 0 then include it similar to that func.  If you want to make those changes I'll import them in for sure.  Otherwise I can just import this and modify it slightly :)  Again, though.  I really appreciate the help!

I have made the changes you suggested, I also cleaned up ChannelMessage a little because there was a more idiomatic way to achieve it.

Oh, great :) That does look much better! Thank you very much for the help.


Make all the devmapper log messages consistent with a common prefix.

Closes #16667
Uses the common prefix "devmapper:" for all the fmt and logrus error/debug/info messages.
Signed-off-by: Chris Dituri<EMAIL_ADDRESS>

thanks @cdituri!
/cc @rhvgoyal

I'm very glad to see that there seems to be such good logging coverage. I wonder if there is anything provided by logrus to structure the log entries a little bit more.

@rhvgoyal - I stripped the string "[deviceset]", fixup'd, and force pushed.
@thaJeztah - much obliged, thank you too!

@rhvgoyal - split into two commits to better differentiate the changes to the graph-driver -vs- the package.
@MHBauer - logrus is k-v structured. We could have a prefix key and use a contextual logger,
withFields(), to set the prefix once. This would not 100% match the current behavior as <ourPrefix> would no longer be part of the msg key-value.
Given #11623, #11621, #11619, and #11618, it looks like logging needs to be refactored across the board and contextual logrus usage should be part of that larger effort ... thoughts?

@cdituri Thanks. LGTM.

LGTM - Windows doesn't use the devicemapper driver (and can't) so no need to deal with waiting on Windows CI

Congratulations on your first PR merged, @cdituri! Thanks so much for contributing! :tada:

@thaJeztah @rhvgoyal @MHBauer @estesp - thanks for driving the process and review, super agile!


Added extra message when there is no data on select

when there is no selected data, it should print out saying 'no data'

https://github.com/nanoPayinc/NANOPAY/issues/1013


Fix alpine class binding for inactive tab items

Description
There is a bug, which prevents inactive tab items from getting the correct CSS classes.
Visual changes
This is primarily visible in dark mode. In light mode only the hover state is missing.
Before:

After:

Functional changes

[x] Code style has been fixed by running the composer cs command.
[x] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

Unfortunately Prettier undoes this change when you run cs. Can you try using {{-- format-ignore-start --}} and {{-- format-ignore-end --}} around these lines, and then running cs to check it still works please?

I am very sorry. Didn't realize, composer cs affects blade files too.
Your suggestion works fine 👍

Thank you!


Add SMTPS notify

Description

Checklist

[x] I have reviewed the contributing guidelines.
[ ] I have included unit tests for my changes or additions.
[x] I have successfully run make test-docker with my changes.
[x] I have manually tested all relevant modes of the change in this PR.
[x] I have updated the documentation.
[x] I have updated the changelog.

Questions or Comments

Thanks for your contribution. I don't think this is needed any longer. Did you see the new feature that was added a few weeks ago? It allows any of the built-in alerters to be used for notifications. That then allows the ability to send emails over SMTPS/TLS/etc.

This patch is not for rule notification. This is for sending notification of ElastAlert2 itself.

The change I mentioned earlier is not for rule notification. It's for system error notifications. Please see the latest CHANGELOG.md.

Please check function send_notification_email in elastalert.py. It does not support SMTPS.


GitHub service hooks

I'm new to Docker. So I want to try automatic builds. When I activated GitHub service hooks, I got the following message: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
So how would a webhook look like for GitHub? Probably the section "GitHub service hooks" should be updated?
File: docker-hub/github.md

This also seems to apply to the docker-hub/builds.md documentation which refers to:

Within GitHub, a Docker integration appears in your repositories Settings > Webhooks & services page

Following the steps to create an automated build and it no longer creates a service setup. Instead it creates a web hook correctly, however the builds documentation lags.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


nixos: wire up new memtest efi binary into bootloaders

Issue description
Memtest finally supports EFI, so we should wire that up instead of the proprietary memtest86+ in our EFI bootloaders like GRUB and systemd-boot.
Should we leave the option to use the proprietary one?
cc @cdepillabout @K900 @LunNova

Memtest and memtest86+ are different pieces of software, with different functionality, right?  Why would we remove the proprietary one?  I imagine that some users would want to use one or the other (or both at the same time).

They're pretty similar, but yeah, I think we should definitely keep both options. I've had setups where one of the two found issues not found by the other.

Ah, sorry. Got the two mixed up.
Still, the proprietary one is used and we should at least offer the free one instead.

I just ran into this, after dropping some pcmemtest patches, not realizing there was this package selection going on in the modules.
Seems like this requires a bit of consideration

do both accept similar types of  parameters?
is it possible to just hang a package option off the end?

I probably can't work on this but would test any improvements here.

Tried to substitute the EFI variant on grub with memtest86plus.
diff --git a/nixos/modules/system/boot/loader/grub/memtest.nix b/nixos/modules/system/boot/loader/grub/memtest.nix
index ccb6e8cc3ca..7e1d47ea1fb 100644
--- a/nixos/modules/system/boot/loader/grub/memtest.nix
+++ b/nixos/modules/system/boot/loader/grub/memtest.nix
@@ -73,12 +73,12 @@ in
       ];

       boot.loader.grub.extraFiles = {
-        "memtest86.efi" = "${pkgs.memtest86-efi}/BOOTX64.efi";
+        "memtest.efi" = "${pkgs.memtest86plus}/memtest.efi";
       };

       boot.loader.grub.extraEntries = ''
-        menuentry "Memtest86" {
-          chainloader /memtest86.efi
+        menuentry "Memtest86+" {
+          linux /<EMAIL_ADDRESS>         }
       '';
     })

This results in a boot entry like this:
menuentry "Memtest86+" {
  linux /($drive1)/gaia/boot/memtest.efi
}

The file is correctly copied to /boot/memtest.efi, but GRUB can't find it.
I use GRUB_CRYPTDISK and I don't have a dedicated boot partition. The @bootRoot@ variable seems to point to my EFI Partition at /boot/efi, which means @bootRoot@ is the wrong partition for my setup. Also since GRUB unlocks my root partition the original /memtest86.efi also wouldn't work, because it would need to look at /boot/memtest86.efi instead.
I don't think we correctly identify the location of /boot  within GRUB in all cases.
I can edit the path and replace  drive1 with drive2, which makes the boot entry work.

Related, I think -- my memtest boot menu entry fails to find memtest.efi in my @boot subvolume. If I enter grub and edit the path to @boot/memtest.efi it works.

With similar changes to the systemd-boot module, systemd-boot is not detecting memtest86+'s efi file; so my guess would be the EFI file is not built properly.

The efi file is working on my system but I haven't been launching it with systemd-boot, I use refind.
Not sure if there could be a difference there?

Confirm its still not working with grub. But im still figuring out how to integrate the modules mentioned by Lun. and Mwe.

Not sure if this is the correct issue (happy to open a new one), on aarch64-linux (Raspberry Pi) enabling memtest with
boot.loader.systemd-boot.memtest86.enable = true;
nixpkgs.config.allowUnfree = true;

results in a 0 byte sized file on my /boot partition. I verified it's not an issue of disc size.
# ls -la /boot/EFI/nixos/.extra-files/efi/memtest86/
total 8
drwxr-xr-x 2 root root 4096 Apr  9 00:14 .
drwxr-xr-x 3 root root 4096 Apr  9 00:14 ..
-rwxr-xr-x 1 root root    0 Apr  9 00:14 BOOTX64.efi

That's a separate issue. Memtest doesn't even support aarch64 (https://github.com/memtest86plus/memtest86plus/issues/147), so we shouldn't be allowing that option on non-x86 to begin with.


When removing input UI instances with remove_ui, the associated input value stays the same as the last input.

Hi, I have noticed that removing the input UI element doesn't lead to any updates in the associated input value. It is still set and equals the last input value.
I am not sure whether it is intended to be this way or not, but maybe worth mentioning in the documentation?
And together with this, is there any way to check whether the corresponding UI element was removed or not? Apart from the workaround of setting the tracking reactive.Value.

Hi Oksana,
Can you provide a bit more context, or maybe an example of what the app does.
One option is to use the shiny.ui.update.* functions, the same observer which changes the UI rendering can update the UI elements. I'm not sure that's exactly the issue here, but it's a handy pattern.

@OksanaBash That is the expected behavior -- removing an input from the web page does not cause the input value to be unset on the server side.
One thing you could do is add a reactive.Value() in the server function which represents whether or not the input has been added, and set the value in the same place where you call insert_ui() and remove_ui(). In the example below, n_exists() represents whether or not the slider n is on the page.
from shiny import App, reactive, render, ui

app_ui = ui.page_fluid(
    {"id": "main-content"},
    ui.input_action_button("btn", "Trigger insert/remove ui"),
    ui.output_text_verbatim("txt", placeholder=True),
    ui.output_ui("dyn_ui"),
)

def server(input, output, session):
    n_exists = reactive.Value(False)

    @output
    @render.text
    def txt():
        if n_exists():
            return f"The value of input.n() is: {input.n()}"
        else:
            return f"input.n does not exist"

    @reactive.Effect
    def _():
        btn = input.btn()
        if btn % 2 == 1:
            n_exists.set(True)
            slider = ui.input_slider(
                "n", "This slider is inserted with ui.insert_ui()", 0, 100, 20
            )
            ui.insert_ui(
                ui.div({"id": "inserted-slider"}, slider),
                selector="#main-content",
                where="beforeEnd",
            )
        elif btn > 0:
            n_exists.set(False)
            ui.remove_ui("#inserted-slider")

app = App(app_ui, server)

Live example here
Note that you could do something similar if you are using @render.ui instead of insert.ui.


[Bug]: Bars-navigation component accessibility issues

Prerequisites

[X] I have searched the backlog for duplicate or closed feature requests

Your test device
iPhone 14 Plus
OS Version
17.1.1
App version
v0.16.0
Describe the issue
This list is about "Bars-navigation" component and variant only. Other common issues are described in dedicated issues.

Title on variants screen is "Large Title" or "Title", not relevant.
Recommandation: Use an explicit title like "Large title demo" or "Title example"

"Standard and "Large" buttons are not linked with the setting label "Size".
Recommandation: Group label and buttons

Expected Behavior
Page 100% accessible

@pya35 Could you please share here some screenshots of the views you are referring? I didn't find the location of theses issues in the app.

#744 not delivered yet

fixed


Develop

What is the purpose of the change
Add api doc
Brief changelog
Add api-refrence-DefaultMQPushConsumer.md doc for RocketMQ
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+3.0%) to 47.752% when pulling 661e9133258914b6b503a99578b7429fa8b97059 on lr77323:develop into 8f37ff27db02177a1e336c8d5ee1a089a4a23939 on apache:master.

@lr77323 cloud you change the target branch of this PR to the develop branch?


The initialize form looks odd in small screen

Steps to reproduce
Access a fresh Walrus setup using a small screen or minimize the browser window.
Result

Environment

Walrus version: main or v0.3.0

Environment

Walrus version: main 2314b9d4571c3b6b341dee7ed630a5ffc5793dfe
UI version: dev-0835269

Test Result:

Check the small screen.

But unable to view full settings box when resizing the browser window as follows:

Environment

Walrus version: main b51994e3fdba0aaeaba9439f6c609c105e5cbb92
UI version: dev-6ab9dbf

Test Result: pass


FireFox table doesn't work

So the table in FIreFox browser is a trap. There is no way to get out of it. Pressing "Option + Tab" works for Chrome and Safari.

If you use the proper VoiceOver commands to navigate the page (control + option + arrow keys) then the user can navigate in and out without a problem. Not sure about windows though.


5700/5700 XT

compatibility on navi cards?

Hi @Atelis
Thanks for reaching out.
As ROCm + Navi brought lot of critical issues in different areas/layers in the stack, hence things got delayed.
AMD is panning to enable official ROCm support on some set of Navi cards(but not all), most likely, with ROCm 5.0.
Please stay tuned for the updates.
Thank you.

@ROCmSupport can you tell us which Navi cards are going to be supported?

Hi @esistgut
I can not comment right now until official announcement is driven from AMD/ROCm.
Thank you.


Running 'kube-aws destroy' in the wrong folder could destroy the wrong cluster

Nope, I haven't done that 😄 . But I worry about doing it a lot...
Feature request 1: kube-aws destroy should display the clusterName and prompt for the user to type the name of the cluster to confirm the deletion. People who need to script a destroy can 'echo "cluster-name" | kube-aws destroy".
I don't think a similar check is necessarily needed for kube-aws node-pool destroy as it at least requires you specify --node-pool-name. Though a similar prompt for the cluster or node pool name could protect against command history re-runs.
Feature request 2: kube-aws destroy should check for errors. Right now it always acts as if it succeeded, even if it actually failed, because e.g. the cluster has node-pools, the cluster doesn't exist/was deleted already, the wrong AWS account is active, etc.

Sounds good overall 👍
Nit but for the former, I'd rather like to add -f flag to skip the confirmation for automation purpose.

Related: AWS recently added a 'termination protection' option for CloudFormation stacks. If you enable that, is should prevent a mistaken 'kube-aws destroy'. It doesn't block stack updates/rollbacks, even if those updates delete stuff, but it does stop an inadvertent, all-out destroy, just because you were in the wrong folder.
https://aws.amazon.com/about-aws/whats-new/2017/09/aws-cloudformation-provides-stack-termination-protection/

Opened #1152. Probably it would be the fix for this issue :)

Yes, allowing new cluster to start with stack protection is great. Though it is easy enough to enable manually after cluster start.

Yes, allowing new cluster to start with stack protection is great. Though it is easy enough to enable manually after cluster start.

yes, but that's a manual step which can be undocumented, forgotten, or otherwise lost in the process, which undercuts the value of kube-aws as a management tool for kubernetes on aws

Thx for the feedback.
I agree!
I've marked it 'good first issue' to welcome a contribution from anyone.

+1 for this feature as i recently had to implement it via aws-cli instead, which as mentioned here is easy enough step to do but one that gets forgotten etc.


AutoML: use separate CV split for ensembling

#1732 updates our stacked ensembling pipeline to use the same data splitter that is used in AutoML. However, @rpeck noted that we may not want to do this. We continued with #1732 because we believed that it was still an improvement on our current approach (scikit-learn default).
This issue tracks long-term updates we may want to make to our data splitter for stacking in AutoML.

Update: while continuing to update #1732, we ran into a conundrum with the interaction between stacking and AutoML that made us revisit whether it really was a good idea to use the same data split for the stacking ensemble as we use in AutoML. We decided no, and that as Raymond had pointed out, we probably want to use a separate CV for our ensemble. (@dsherry  also mentioned a good nugget of info that using ensembling allows the model to put less excessive importance on the more complex models, so CV probably helps with that--please correct me if I've paraphrased incorrectly 😂 ).
Rather than continuing that work then, we should use this issue to discuss updating AutoML for stacking: Specifically, we should create a separate split for CV for the stacked ensembling. This would be similar to what we currently have in place for binary-threshold tuning.

Plan: if stacking is enabled, we'll create a separate split which can be passed to stacked ensembling for CV
It could be neat to look into supporting using the out-of-sample predictions (validation split from original CV) as the data passed to stacking. However I suggest we start with the simpler approach of just creating a separate split if stacking is enabled.
RE our discussion, some supporting evidence for why we should withhold a separate split which stacked ensembling can use to perform CV:

"By using the cross-validated [predictions,] stacking avoids giving unfairly high weight to models with higher complexity." AKA overfitting
"The most common approach to preparing the training dataset for the meta-model is via k-fold cross-validation of the base models, where the out-of-fold predictions are used as the basis for the training dataset for the meta-model. The training data for the meta-model may also include the inputs to the base models, e.g. input elements of the training data. This can provide an additional context to the meta-model as to how to best combine the predictions from the meta-model. Once the training dataset is prepared for the meta-model, the meta-model can be trained in isolation on this dataset, and the base-models can be trained on the entire original training dataset." -- blog post
"It is important that the meta-learner is trained on a separate dataset to the examples used to train the level 0 models to avoid overfitting." -- another blog post
Original paper abstract which discusses how stacked ensembling can be viewed as a generalization of cross-validation
I also found this to be a good read.

@rpeck FYI, after some spinning we are following your suggestion 😆

Plan: if stacking is enabled, we'll create a separate split which can be passed to stacked ensembling for CV
It could be neat to look into supporting using the out-of-sample predictions (validation split from original CV) as the data passed to stacking. However I suggest we start with the simpler approach of just creating a separate split if stacking is enabled.
RE our discussion, some supporting evidence for why we should withhold a separate split which stacked ensembling can use to perform CV:

"By using the cross-validated [predictions,] stacking avoids giving unfairly high weight to models with higher complexity." AKA overfitting
"The most common approach to preparing the training dataset for the meta-model is via k-fold cross-validation of the base models, where the out-of-fold predictions are used as the basis for the training dataset for the meta-model. The training data for the meta-model may also include the inputs to the base models, e.g. input elements of the training data. This can provide an additional context to the meta-model as to how to best combine the predictions from the meta-model. Once the training dataset is prepared for the meta-model, the meta-model can be trained in isolation on this dataset, and the base-models can be trained on the entire original training dataset." -- blog post
"It is important that the meta-learner is trained on a separate dataset to the examples used to train the level 0 models to avoid overfitting." -- another blog post
Original paper abstract which discusses how stacked ensembling can be viewed as a generalization of cross-validation
I also found this to be a good read.

@rpeck FYI, after some spinning we are following your suggestion 😆

@dsherry @rpeck @angela97lin I started looking at this issue, but it seems like sklearn's StackedClassifier and StackedRegressor classes do use internal cross validation during the training of the model in order to prevent overfitting. This seems to be the same problem that we are trying to solve with this issue, so it seems like it should be resolved. I don't think we'll need to do a separate CV fold for training/validating the Stacked Ensembling methods, but what do you all think?

After discussion with @dsherry, here's the idea we want to proceed with

Plan discussed with @bchen1116 : this issue tracks:

create separate split for training the metalearning for ensemble pipelines

Separate performance enhancement: better support for small data. Don't create separate split for ensemling. Use out-of-sample pipeline preds from normal CV (from across all the CV folds) to train the ensembler.


Update readme

Closes #45

[X] installation methods
[X] links to related technologies
[X] link to Contributing (though call for collaboration is probably enough for now)
[X] licen[c/s]e & citation
[X] badges

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3733648). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 7b6ab2f differs from pull request most recent head 56f4792. Consider uploading reports for the commit 56f4792 to get more accurate results

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage          ?   81.38%
=========================================
  Files             ?        9
  Lines             ?      231
  Branches          ?        0
=========================================
  Hits              ?      188
  Misses            ?       43
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3733648...56f4792. Read the comment docs.

Nice work 👍


New version detected 3.0.5 please update the bot!??

2024-10-07 11:31:35 | WARNING  | 27 - New version detected 3.0.5 please update the bot!.
I've updated newest version.

Update again


USB Keyboard and USB Serial at the same time

Hello guys, I'm writing a project for pi pico and I'd like to have the board to function as both Serial device for debug output and a keyboard.
I was able to achieve that in Arduino simply by calling
  Keyboard.begin(KeyboardLayout_en_US);
  Serial.begin(115200);
  etc.

However, when I'm trying to replicate the same in Rust it doesn't work simultaneously.
While I can successfully make the board work as Keyboard or Serial, I can't combine the two - in this case lsusb doesn't show any USB devices.
Do you know what's causing this limitation or how it can be overcome?

Hey codekrolik2,
I may be able to help you if you link to an example repo showing the code you are trying to use.
Here is some of my older code, that predates this library, showing how you can use a serial device and hid at the same time: https://github.com/dlkj/macropad-rust/blob/main/cross/app/src/usb.rs
The key bit is to pass both the hid and serial devices to the poll function:
      if self
            .usb_device
            .poll(&mut [&mut self.serial_port, &mut self.keyboard])
        {
            let mut buf = [0u8; 64];
            match self.serial_port.read(&mut buf) {
                Err(_e) => {}
                Ok(_count) => {}
            }

            let mut buf = [0u8; 64];
            match self.keyboard.pull_raw_output(&mut buf) {
                Err(_e) => {}
                Ok(_count) => {}
            }
        }

I'm doing the following in my test:

Let me study your code and try to adopt, thank you very much for the pointer!

You don't need two instances of UsbDeviceBuilder.
Thank you very much!


Drone skips first waypoint of every mission

Describe the bug
During live flight testing, we observed that the drone would always skip the first waypoint and head directly to the second waypoint when receiving a new mission.
Reproduction steps

Be testing MPS on a live drone
Use POST /queue to give the drone a new mission
Observe that the first waypoint is skipped and the drone heads directly to the second one

Expected behaviour
The drone should not skip the first waypoint of a mission.
Additional context
No response

This can be reproduced in SITL.
It's inconsistent - sending missions with only 'regular' waypoints works just fine, and 'mixed' missions afterwards seem to work as well

Possibly addressed in commit d44cb0


feat: support package object in objectChange

sample tx result:
"objectChanges": [
				{
					"type": "published",
					"packageId": "0x0000000000000000000000000000000000000000000000000000000000000001",
					"version": "1",
					"digest": "FKegovSq3RzY1E3LT2WNpLS4nXCtCwCN6D1YGxQRS8w4",
					"modules": [
						"address",
						"ascii",
						"bcs",
						"bit_vector",
						"debug",
						"fixed_point32",
						"hash",
						"option",
						"string",
						"type_name",
						"vector"
					]
				},

previous object change struct is missing packageId and modules fileds

Okay, already merged pull request. Thanks for contributing.


removed wierd extra title block

Then

Now

Much better. :sparkles:

I'm loving the before and after pictures :)

@brianwarehime It's important to provide evidence. Even if I'm likely the one who introduced it.


PageHeader: Adjustments to the storybook and docs examples (sign-off review)

Describe your changes here.
Closes # (type the issue number after # if applicable; otherwise remove this line)
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@lesliecdubs it is active, sorry was holding it until the sign-off is completed but that will take a while. I added to my to-do list to clean up and open for review for next week.


Update Gazebo.rst

The topic pub command on line 141 does not work as written.
Updated the line to call the proper message and pass the correct arguments in YAML format.
old: ros2 topic pub /model/vehicle_blue/cmd_vel geometry_msgs/Twist "linear: { x: 0.1 }"
new: ros2 topic pub /model/vehicle_blue/cmd_vel geometry_msgs/msg/Twist "{linear: {x: 0.1, y: 0.0, z: 0.0}, angular: {x: 0.0, y: 0.0, z: 0.0}}"

The topic pub command on line 141 does not work as written.

Can you provide more information on what platform you are using, and how it is failing?  The command as written works fine for me on Rolling on Ubuntu 22.04.

Sorry for lack of details.
humble on ubuntu 22.04.
Passed message type is invalid.

humble on ubuntu 22.04.
Passed message type is invalid.

Thanks for the details.  I'm trying it here locally on Humble on Ubuntu 22.04, and it is still working fine for me.  Can you tell me what version of ros-humble-ros2topic and ros-humble-geometry-msgs you have installed?

I will check tonight when I get back to my office.
Hoping I didn't get to excited trying to make the world a touch better.

I must have been mistyping something checking now both the old and new lines work I am closing this pull request.


Support Arbitrarily Large ETW/nettrace Heap Snapshots

Set isVeryLargeGraph=true for the in-memory graph representation.  NOTE: This graph doesn't get written to disk.
Remove the 10M node limit.

cc: @Maoni0, @cshung

awesome, thanks @brianrob!!


TypeScript - Load ESM

Is there already a solution for the issue mentioned in issue #8 ?
Because I'm currently working on a TypeScript project and would love to use milliparsec.
When I use JavaScript I don't have any problems with the package.
It's a shame because this is the only body parser I'd love to use and doesn't work with TypeScript.
This is the error I got in the terminal:
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/dist/index.js
require() of ES modules is not supported.
require() of /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/dist/index.js from /Users/franciscomendes/Desktop/tinny/src/app.ts is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/package.json.

    at new NodeError (node:internal/errors:329:5)
    at Module._extensions..js (node:internal/modules/cjs/loader:1109:13)
    at require.extensions..jsx.require.extensions..js (/private/var/folders/np/ycmnjy5d4y11shfjzgr981qm0000gn/T/ts-node-dev-hook-8114142920895264.js:114:20)
    at Object.nodeDevHook [as .js] (/Users/franciscomendes/Desktop/tinny/node_modules/ts-node-dev/lib/hook.js:63:13)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Module.require (node:internal/modules/cjs/loader:996:19)
    at require (node:internal/modules/cjs/helpers:92:18)
    at Object.<anonymous> (/Users/franciscomendes/Desktop/tinny/src/app.ts:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1092:14)
[ERROR] 22:42:18 Error: Must use import to load ES Module: /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/dist/index.js
require() of ES modules is not supported.
require() of /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/dist/index.js from /Users/franciscomendes/Desktop/tinny/src/app.ts is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /Users/franciscomendes/Desktop/tinny/node_modules/milliparsec/package.json.

Hello.
I assume you're working with ts + commonjs build? The quick & dirty solution would be installing<EMAIL_ADDRESS>as that was the last version to be having a cjs build. Other than that, you should migrate your app to ESM😅

@FranciscoMendes10866 hi,
the solution is to set target and module to ESNext in tsconfig and use something that can run ts+esm (or u can run tsc && node ./dist/index.js)
for example u can use -r ts-node/esm or esmo


Use Dat storage module

Changes defaults to use the dat-storage module.

Codecov Report

Merging #137 into master will increase coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   91.75%   91.79%   +0.04%
==========================================
  Files           6        6
  Lines         194      195       +1
==========================================
+ Hits          178      179       +1
  Misses         16       16

Impacted Files
Coverage Δ

index.js
100% <100%> (+2.85%)
:arrow_up:

lib/storage.js
81.81% <66.66%> (-8.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea66b6a...91abb6e. Read the comment docs.


Popup problems with Colibris skin

With the Colibris skin, the popup looks like this:

Problems with this:

The × in the title doesn't do anything, the real close button is on the right. It should be removed.
The "on" slider for "starts editing the pad" isn't visible. It is apparently still there in the DOM somewhere; the mouse cursor changes when you hover over where it should be.
Neither slider seems to be toggle-able. Clicking on them doesn't do anything.
This is less important but center-justifying the options below the email address box seems like less than ideal presentation. Better to have all that left-justified if possible.

Actually this is completely changed since about last week..  Pop up no longer includes HTML, user must visit settings to subsribe.

Update Etherpad and the plugin :)

I just upgraded Etherpad last night to 1.8.6, and I tried to upgrade the plugin too (although my admin interface says I only have 0.1.15 vs. 0.1.17 in Git). Can you please let me know what versions of each I need to be running?

Try clear browser cache.  Also set minify to false and maxage to 0 if this is a dev instance


3D image classification problem

Dear author, I am very interested in your code，Could you please provide the code or information to change 3D in image classification？

Have you found a solution to make it compatible with 3D images? Or did you use other visualisation methods instead? @xiaobaitubaibaibai


ext_authz: Emit dynamic metadata on OK and Denied responses

Commit Message: This patch fixes the bug when the ext_authz filter fails to emit dynamic metadata when receiving Denied response from the (gRPC) authorization service.
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: Added
Platform-Specific Features: N/A
Fixes #15031
Signed-off-by: Dhi Aurrahman<EMAIL_ADDRESS>

Thanks, @snowp! Hopefully, this one goes through :).


Adding KEY as a reserved word for QueryDSL 3.x

MS SQL Server rejects queries for columns named key without being escaped. MS SQL Reserved Keywords
This PR is an alternative to PR 2183. Instead of adding "KEY" to SQLTemplates.SQL_RESERVED_WORDS, construct an ImmutableSet in SQLServerTemplates consisting of the union of SQLTemplates.SQL_RESERVED_WORDS and MS SQL specific keywords.

@Shredder121 What are your thoughts on getting this into the 3.x release?

Shouldn't be too hard.
I suppose this will be the time I'll look in the correctness of my release profile.

We haven't supported querydsl 3 for a while now. I'm going to close this PR since it's probably irrelevant at this point, but if I'm wrong, comment and we'll try to release this fix.


bulk_update_fuzzy_#{field} Error when value is chinese

Hi, it seems there is a bug to build fuzzy index when a column is chinese, you can look the image I uploaded

@mezis   ^_^


301 on RSS feed

Hi there,
I'm serving my blog using Caddy, and the URL for rss feed is https://example.com/feed. But before I switched to HTTPS, many subscribers were using http://example.com/feed.
Using nginx I just return 301 to the https URL and everything works, but using caddy, the 301 redirection has it's content of Moved Permanently., and many RSS readers (feedly, inoreader) went confused. They thought the content of the feed were .
Is it possible to just return a empty-body 301 response?
Cheers,

Heh, I forgot that the Go standard library does that. It's for clients that don't follow redirects so users can still go where they ought.
The comment explains why:
// RFC2616 recommends that a short note "SHOULD" be included in the
// response because older user agents may not understand 301/307.
// Shouldn't send the response for POST or HEAD; that leaves GET.

So it satisfies a "SHOULD" in the RFC, but it's for older clients.
Still, I don't think clients should be reading the body for a 301 response code. Really surprised even a modern one like feedly is doing it wrong...

According to http://webmasters.stackexchange.com/questions/63217/301-redirecting-a-blogs-rss-feed-url , it seems like Feedly has this issue for a while

Hi, I rechecked Nginx's 301 response, the body is also non-empty. Maybe my issue is not related to go's body content.
I'll recheck this problem later.
Thanks.


API hooks description text fixes

There were a few typos, including inappropriate commas, which I fixed in this PR.

Thanks for this very nice PR @edlucas  💯💯💯


fix: storage details missing capacity fields since 3.1

这个 PR 实现什么功能/修复什么问题:
修正：因为json fieldname写错了，storage详情缺少capacity信息
是否需要 backport 到之前的 release 分支:

release/3.1

/cc @ioito @zexi
/area region

Codecov Report

Merging #5517 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5517      +/-   ##
==========================================
+ Coverage    6.87%    6.88%   +<.01%
==========================================
  Files         610      610
  Lines      103165   103152      -13
==========================================
  Hits         7097     7097
+ Misses      95495    95482      -13
  Partials      573      573

Flag
Coverage Δ

#aFlag
6.88% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.32% <0%> (-0.01%)
:arrow_down:

pkg/compute/models/storages.go
1.08% <0%> (ø)
:arrow_up:

pkg/monitor/notifydrivers/feishu/client.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce6ad8...e1ad22e. Read the comment docs.


Bootstrapped the project using gulp-angular generator

I did all sorts of damage, but I thought it would be helpful to bootstrap the project using yeoman to resolve #31. The gulp-angular generator seemed like a good choice to get us to a point where we have the structure/dependencies needed to be productive. I didn't complete the migration of the existing code base, but I can work on that if we think this is a good attempt at bootstrapping the project.
I updated the readme to point to the generator used. I also updated the instructions for building/serving the app. Let me know what you think!

I believe @joekarl didn't use yeoman in order to have a more barebones application. Yeoman generators are built for the general case and usually leave a bunch of unnecessary files.

I'm up for stripping stuff out. I thought it would just be easier to use it as a starting point and to remove any utilities that we're not planning on using.

Closing this out based on the discussion in #31. I'll create new issues for the tools I was trying to pull in, and then we can decide within those whether or not they add enough value to include in this project.


Python debug scripting interface

still kind of a draft, but I want a CI result: A debug scripting interface for the RISC-V models from Python 3.9.

closing this for now, needs new thinking


v1.0.0 - Webpack: Module not found: Error: Cannot resolve module 'react-simple-dropdown'

I even tried to remove node_modules/ and reinstall all packages, still the same. When I switch back to v0.1.1 it works again.

Can you provide any more error information? What method were you using to include the module?

import Dropdown from 'react-simple-dropdown';

It works with v0.1.1

Are you installing through npm?

Yes

1.0.1 should work. There was a configuration error stemming from my switch to compiled JS which should be resolved now.
https://github.com/Fauntleroy/react-simple-dropdown/commit/f91217c9b6cff31f954bb964b5d326797ac0d103


feat: check if coin already in cache

Summary
Checks if any of the inputs is already cached before sending/submitting the tx.

IIRC the plus here is that we prevent the user from hitting the network with a tx that's bound to fail, which is great.
I have two concerns, correct me if I'm wrong:
* We might get inconsistent results because of the time based eviction. E.g. user stalls submitting the second transaction long enough for the cache to drop the entry.

* We don't evict when txs are dropped by the node which means we might prevent the user from executing a valid transaction at some point.

If the cache drops the entry because of time based eviction then we revert to the old behavior. We send the the tx and the node will complain.
This can also happen with the current implementation; however, only if the tx is squeezed out.

Had meeting with @segfault-magnet and @MujkicA where we went through the uses cases and we came to the above conclusions.


Changes to MultiBatch portion of scRNA Pre-Processing tutorial

Generated a new batch of simulated data (rewrite of old method).
Now includes two examples of crosscontamination as a learning exercise.

merci!


Tooling rehaul: introduce ARM64 release; use git tags instead of production branch for releases

Description of the change
Tooling rehaul.
Multi-arch uploads to S3 (downloads.spacelift.io)
This pull request makes it so that we'll upload platform-specific binaries to S3 and multi-platform Docker images as well.
How it used to look like:

https://downloads.spacelift.io/spacelift-vcs-agent
https://downloads.spacelift.io/spacelift-vcs-agent_SHA256SUMS
https://downloads.spacelift.io/spacelift-vcs-agent_SHA256SUMS.sig

☝  Let's call this legacy.
New format:

https://downloads.spacelift.io/spacelift-vcs-agent-x86_64
https://downloads.spacelift.io/spacelift-vcs-agent-x86_64_SHA256SUMS
https://downloads.spacelift.io/spacelift-vcs-agent-x86_64_SHA256SUMS.sig
https://downloads.spacelift.io/spacelift-vcs-agent-aarch64
https://downloads.spacelift.io/spacelift-vcs-agent-aarch64_SHA256SUMS
https://downloads.spacelift.io/spacelift-vcs-agent-aarch64_SHA256SUMS.sig

This naming convention entirely matches the launcher binaries.
❗ We will still upload the legacy files, but we shouldn't use those links anywhere. I'll update the documentation at docs.spacelift.io once this PR is merged.
New release process
A new use-case arose in Spacelift where we'd like to download VCS Agent binaries for Darwin for end-to-end testing purposes. CC @jakubdal
In order to facilitate that, let's improve our release process: instead of merging to the production branch, releases should happen when a new tag is pushed. This follows our other public repositories' pattern such as spacectl or terraform-provider-spacelift.
From now on, Goreleaser will publish a GitHub release whenever a tag is pushed and it'll attach all the built binaries as well.
How does that help us? We will publish all 3 operating systems (Linux/Darwin/Windows) to the GitHub Releases which can be used by endtoend tests - those tests can detect the current OS and architecture and download the agent accordingly.
Type of change

[ ] Bug fix (non-breaking change that fixes an issue);
[x] New feature (non-breaking change that adds functionality);
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected);
[ ] Other (miscellaneous, GitHub workflow changes, changes to the PR template);

Checklists
Development

[x] Lint rules pass locally;
[x] All tests related to the changed code pass in development;

Code review

[ ] This pull request has a descriptive title and sufficient context for a reviewer. There may be a screenshot or screencast attached;
[ ] This pull request is no longer a draft;

Deployment

[x] Selected merge strategy is squash merge;
[ ] Changes have been reviewed by at least one other engineer;

@jakubdal ahh there was a typo, fixed it, do you mind reapproving? 🙏


Require serializers and paginators

I like the idea of splitting these repositories out, I think we should wait until v2.0 to exclude them to lower the barrier to 1.0.

I like this, especially with it being more of a 2.0 goal. But we should figure out whats up with the test suite.

@Nyholm Can you be specific about your concerns? The idea is to require these until v2 to ease the transition to the separated repositories.


T9 (V0.3) Feedback

I think you are okay functionality wise for v0.3. Please try to improve the UI design in the final product. You have GCal integration, etc.. So I think UI is going to change substantially.

There are other teams like you who have their design similar to address book level 4 and  hence do not have changes to the design. This is okay. But we suggest you to consider the foll.

Compare with other alternative designs possible.

Add more descriptions e.g. show at least one interaction (i.e. sequence diagrams) within each component. But this doesn't mean to add more verbose text about trivial and unstable things.

Use object diagrams to show the object structure at runtime

Use activity diagrams and OO domain models where applicable (covered in yesterday's lecture)

Explain how they implemented things such as undo/redo (since they weren't given features in AddressBook Level 4)

Thanks!


fix(module:cascader): fix component not rendered label correctly with leaf option (#336)

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #336
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

clicking the leaf node will remove any children columns.

Coverage decreased (-0.02%) to 40.756% when pulling 1ae1dc38fb3c75792899b84b2518c5c2b5218eec on fbchen:master into ae7c757649a3d4472e1f73c8f0e07a6d09de61f2 on NG-ZORRO:master.

Coverage decreased (-0.009%) to 40.765% when pulling 1f0d74f233cf4f40275699134303399ff4bfa30e on fbchen:master into ae7c757649a3d4472e1f73c8f0e07a6d09de61f2 on NG-ZORRO:master.

Coverage remained the same at 40.791% when pulling 5dafd0c13b3d78b176d078a60d1dd4a837b96b3a on fbchen:master into 525edb805cc2cd39e7d861fad2e5354d54a5344c on NG-ZORRO:master.

Coverage remained the same at 40.791% when pulling 987ed42402c1c506274eab99d4eb1f9af47e19a9 on fbchen:master into 525edb805cc2cd39e7d861fad2e5354d54a5344c on NG-ZORRO:master.

Coverage decreased (-0.009%) to 40.782% when pulling 8c8c5d578414cb46bf824b5304d27f7137ae2f0c on fbchen:master into 525edb805cc2cd39e7d861fad2e5354d54a5344c on NG-ZORRO:master.

Coverage decreased (-0.009%) to 40.782% when pulling cdddc8abd5b0140738ad475bc709d4241fc9284c on fbchen:master into 525edb805cc2cd39e7d861fad2e5354d54a5344c on NG-ZORRO:master.


[SB] refactor iter for typing bug

API change check
API changes are not detected in this pull request.


Emojis don't save after applying settings

What happened?
When I put emojis in my status, they are put but if I close and restart my IDE all the emojis go but the custom texts stay.
Expected behaviour
Configs are supposed to keep emojis
What version of the plugin are you using?
1.2
What IDE and version are you using?
WebStorm 2024.1.2

Can confirm this happens. Seems to be an issue with how IntelliJ api encodes settings, because if you put an emoji directly into the settings file, it works. This is not handled by me. I'll ask on the JetBrains Platform Slack.

So if i write my emoji in file it's work ? PS : where is the config file x)

Yes, it should work. In Windows the config file is located at %APPDATA%\JetBrains\YOUR IDE\options\discordrp.xml.

Thanks

Related JetBrains YouTrack issue: https://youtrack.jetbrains.com/issue/IJPL-38379/Paths-with-emoji-dont-get-saved-after-closing


Automatic GUI test pass in travis

It is working good.
We need to set this automatically in cmake. But first we need a general way to exit from an application from the parallel GUI testing function. Now I use fm.close(), and I need to pass a pointer to the main form to that function to do that. A general API::exit() will be much better but don't works. Why? With API::exit() nana can add a default GUI test to any program when compiled with that option, with is ideal for travis.
Also, some demos compiled but don't pass the run test - the list is at the end of .travis.yml. We need to fix that. It maybe a problem with the Xvfb, an X server to emulate display? See hier how to use in travis.

The function exit_all exit from all threads... OK? not sure, but it works...

Hi, qPCR4vir. Is it necessary to include the auto GUI testing in release package?

Hi,
good question.
In the future, surely yes.
For beginners it is not a problem because it is off by default.
For mid-level programmers it is a big plus: you simple fork nana and nana-demo, add your own experimental app to your nana-demo (and in cmake and .travis.yml, just like all the other demos) and you will get testing in Linux for free (in the future in windows too, and possible in OSX with clang too). To me it is a very good and easy way to test that my app is really "crossplatform" and not only in theory (I can't install all of this locally just to test my app).
But I agree that right now it is immature - it need more work. I propose you to forgot hotfix-1.3 and create hotfix-1.3.1 in the commit before your last merge. It have not gui testing, and could be the next release, or after merging your develop could be release 1.4
The GUI testing can be in a new feature branch Automatic_GUI_testing. I have all of this in my nana fork take a look.

see :
https://travis-ci.org/qPCR4vir/nana/branches

API::exit() only closes windows which are created by the calling thread.
I found that a new form pointer parameter for exec(), is the form like a main form? Will all windows get closed when the main form is closed? IMO, the idea of main form is not good.
I think the best way to do test is to add a test.cpp and define a specific function for testing rather than modify exec().

Your are right. The main form pointer was a workaround and is now eliminated.
And yes, the workaround was needed because API::exit() don't close all forms.
Maybe you can think of a function that can be called to really exit the whole program correctly?
The problem is that if you use the function std::exit() the program don't really exit normally - nana complain and throw, and even shows a msgbox that will block travis. The msgbox is very good for normal interactive use  but not for travis. (it is very bad to see that the OS visualice that the program crash and you need to inform about that by sending an email to Microsoft! It is much better a more or less nice msgbox from nana). It can be fixed if we find and fix why std::exit don't std::exit() normally.
That is why I introduced a version API::exit_all(). It works, closing more forms and is good for many examples, but it is also a workaround that I invented and I think it it's not very good (but is better than the main form pointer).
The whole point is that I want a method to test any program without modification, just by recompiling with a different option. For example, I want to be sure that the examples are keep always actualized. Many users and some critics try to compile old examples and then have problems.  The source text of the examples are included automatically in the documentation with many links to the classes and functions. And I don't want to explain to an absolute beginner what some artifacts for testing are. I don't want to modify the HelloWorld program to include testing, but I want to be always sure that HelloWorld compile and run without problems.
Yes, now is not very good. If you see a way to do all of that, than I agree that it is best not to change exec. I will keep thinking about, but for now that was the way I finded.
Yes - to isolate all testing functions in test.cpp is a good idea. Testing if for "advanced use" and need to be optional and separate, not a mess. But I don't know how to change one switch (a #define) and trigger a new compilation that include the test for a program that don't include it originally.

Can we replace wvl.cpp with a new defined test.cpp in travis? The test.cpp is a copy of wvl.cpp, but it has a different definition of exec(). We can move the test-related functions into test.cpp to eliminate the marco NANA_AUTOMATIC_GUI_TESTING and NANA_ADD_DEF_AUTOMATIC_GUI_TESTING. And the wvl.cpp will not be compiled in travis.
A possible definition of exec() in test.cpp is also very simple.
`
void exec()
{
using namespace nana;
timer tmr; //<nana/gui/timer.hpp>

unsigned seconds = 10; //exit exec() after 10 seconds
tmr.elapse([seconds]() mutable
{
	if (0 == seconds--)
		API::exit(); //same thread of exec().
});

tmr.start();
detail::bedrock::instance().pump_event(nullptr, false);

}
`
The test.cpp will not present in release distribution, I think a new complete testing feature is another issue. What do you think about this way?
I will merge the PR first.

Sounds good, I will try.
Thank

It seemed that I found another issue, automatically testing demos without modifying demos' source code means the behavior of Nana is changed. Maybe the automatic testing is only used for internal use.


tools/ipc: use closesocket() instead of close() on Windows

Fixes the following compile warning on the MinGW CI:
../../ngl-tools/ngl-ipc.c:354:9: warning: implicit declaration of function 'close'
This was forgotten in 139b5ec4d8072831061f2b689bc7650deb419029.

lgtm


Disable babel ESNext transpilation in dev

This was mostly because the regenerator runtime was making my debugging horrible and couldn't fix this, so realized we don't actually need babel on anything but react while in dev as modern browsers have all the functionality and we use a new enough version of node

I'm not sure how I feel about having a split like this between what's on Prod and Dev. Seems like something that could introduce the possibility (however small) of a bug on Prod that would not show up on Dev. All it takes is one bug in the Babel that's being run on Prod(again unlikely but possible) and it becomes possible to push something that has bugs on Prod that didn't exist in Dev.

Yeah I thought of that as well, what consoled me though is that CI runs on production build, and I therefore think either the build or the E2E tests should catch any errors since it would basically be "syntax errors" so they shouldn't fail silently. Also, it seems exactly that has actually been caught right now as E2E tests are failing
I just really want to use async await though, and I don't think it's feasible making the debugging experience as bad as it was before (you literally couldn't see what was going on in async functions, like, not at all)

Additionally, it looks like async and await were only introduced in 2016 for chrome(Chrome 55). Especially on Linux machines where Chrome doesn't always auto-update it's pretty feasible that a developer wouldn't have that version e.g. I'm pretty sure my behemoth ML rig doesn't have Chrome 55.

Oh yeah I'd definitely put in a point in the docs about the fact that if you run into any syntax errors in your browser you should update to the latest version of Chrome.
I won't merge it in before I can make E2E tests pass anyway, obviously, but yeah I'll think a bit more about it. If you can think of any better ideas (or if you feel strongly that we should just ditch async/await) feel free to share. Your concerns are valid though, I would also prefer not to even leave the option open of a failure like the one you say, and not rely that much on the tests even if the E2E tests really should catch any of this

Would it feasible to make an additional build option that is without ESnext? I'd be far less iffy on this if it wasn't the default behavior, but instead something you opt into when debugging async & await code.

Also, I think that 1. as you say the chance that babel has a bug should be pretty small, especially if we aren't changing babel version, and yes we should test when we upgrade babel versions with babel running, but that's also where probably the CI E2E tests would catch the errors we wouldn't anyway (as humans, or maybe just me, don't have the patience to test everything super thoroughly haha). And if we assume babel works as it should, then it should only make things more compatible and less possible to error, so if they work in dev they should also work in production.
There should definitely be a point in documentation about browser versions no doubt, but I don't think it's a big hassle asking developers to upgrade their browser to the newest version, we ask them to install MariaDB that is a much bigger pain often. I actually in some ways also like not using babel transpilation on anything but React for dev, because it kind of keeps us in touch with reality as well. If neither the newest browsers or our current version of Node haven't implemented the features we use yet, probably there isn't a big enough consensus in the community on whether it's a good feature yet (cough argument against me writing a polyfill for Array.prototype.flatten cough haha).
I'm starting to convince myself this is okay, how do you feel? I truly do value your opinion so haven't completely made a decision yet

As I said in the original review, I'm fine to put this in with documentation of the chrome version needed since that would be something really frustrating for a new developer to debug if it's undocumented.
Would you put that in the Wiki or the README??
If it's the README then add it with this PR. If it is the wiki, then this PR is fine for me - though I personally would like it a bit more if something like --without-esnext was something you opted into.

I love that idea @Helw150 !
Also, I've actually been thinking, for example with changing the wiki for the Ghost changes which I currently can't do because it's global and not in the same source control, it's super stupid. I think I'll migrate the wiki to a docs folder, which should be just as easy to read on Github and we can still link to, and we can make a README in the folder itself that has an "index" of links to all the docs pages, then I can also organize them in folders etc. Would be so much cleaner and then you can change documentation in your PRs

I'm throwing an approval on this under the assumption you'll add the browser requirements somewhere into the docs. The opt-in or not is your call.

Sounds good :), this is slightly in the backlog, I'm planning on getting it merged in when I've also updated the docs with latest setup instructions now Ghost are gone

The meat of this is achieved in #408 as also now node is properly not compiled with regenerator runtime. Browsers still will, but we can handle that hurdle when we reach it, when I encountered the issue it was with VS Code on serverside code, but that should no longer be a problem


Batch not Edge Partitioning

This PR contributes to provide a higher abstraction level with less focus on graph terminology: renames edge partitioning functionality to batch partitioning.

Thanks for the review @bernlu !


Group by category changes

This brings in changes to enable us to group events by category's by passing a group_by prop on events and passing in a new categoryGrouping array to specify an ordered list of category's or a boolean

True: to generate the category list from the values in the group_by prop
False: To place all events in a single misc category (default)

It also adds a scoped slot for passing in a custom category header, adds tree-shaking for our use of lodash and utilises an iso caret icon for the default category headers to show the collapse state
and any logic/styling changes to go with the above, it also adds the semantic ui css for use when testing the repo locally
A seperate PR for tests for the new groupByData logic will follow this in the near future.

These changes can be tested on the forward planning gantt on supercroud dashboards on this branch feature/CC-1176-Gantt-chart-category-changes

There seems to be an vertical offset issue as the rows aren't matching up, I guess is down to how the box model is calculating the height. The new ToggleHeader.vue has a fixed height of 35px and a border of 1px which gives it a total height of 37px, 2px larger than the spacer rectangle on the other side of the graph.
It's subtle enough for a small number of rows but could compound to a major offset with a real dataset

Thanks for the review, i have made the follow changes:

Misc header is not shown if category groupings is set to false
Show misc at the bottom when dynamically categorised (Im not sure we stated that misc would be weighed at the bottom when dynamically grouping the categories, although when passing our array of categories misc would have been at the last index (as this was mentioned).. but its logical/consistent so i have set it so it will show at the bottom in both cases)
Fix vertical offset, i had fixed one instance of this but it reoccured when i moved the border style responsibility to the gantt (Good spot)

Ok, I will review again over the weekend. Thanks

Sorry for the ambiguity.
As in if we pass in :categoryGroupings="false", we could have treated this as a single category grouping. Then we wouldn't have to maintain two almost identical sets of template markup and node building logic.
The logic I built out (specifically line 447) already does this by effectively putting everything into the misc category if the categoryGroupings prop is false.

@BrockReece @kingy04 Just to add absolutely no value but to clarify, this was the logic that we all agreed on collectively before respective holidays wasn't it? I'd like to understand where the communication breakdown has arisen from to avoid this kind of issue again.

@kingy04 No, my point was that we weren't doing that in this PR, you were using different node building and template logic based on the categoryGroupings prop. Cleaning up the code is something we should be doing anyway.
Yes, we did discuss this and yes it is what was implemented in the logic that I built before I went away, but that is where this idea was left behind it seems.
As for all the new issues found that breaks existing functionality, this is a nod to the comment I made about building more tech debt into our projects and this is what I understood was being worked on since I left for my holiday?

@kingy04 I think there is an issue with reactivity, the nodes aren't rebuilding if there is a change in the data, this is probably causing the 'postpone' issue you mentioned above, but it is also causing 'children' blocks not to update when you drag and drop the parent block.

Just fixed some :key based errors to get rid of some noise in the console logs

I have added a watcher to update the event positions, do you think that is ok or is there a better way to deal with it?, we want to avoid re building the data to often right?
Ok ill have a look at the link logic

I think that will only catch a very narrow set of data updates. This only considers the offset of the event that is currently selected in the ui, right?
I don't see an issue with re running the groupByData when the underlying data changes, the most expensive part will probably be updating the DOM and because of Vue's Virtual DOM, this will only re render the branches with actual changes.
If we are concerned with performance, we could abstract the node building logic out of the groupByData method and into it's own buildEvent method. We could then put a watcher on all the event data, compare the diff of the change and only run the rebuild for the specific events. But I don't think this will give us much of a return on the investment.

I think a good rule of thumb is that data integrity should always be our primary concern and performance improvements should only be considered after that.

This has passed product QA, so I'm happy
On Mon, 18 Jun 2018, 11:24 Brock Reece<EMAIL_ADDRESS>wrote:

@kingy04 https://github.com/kingy04 @paul-watkins-croud
https://github.com/paul-watkins-croud
Can we confirm that we are confident and happy for this to be merged in to
master and I will approve and bump the major version number.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CroudTech/croud-vue-gantt/pull/13#issuecomment-398010031,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAysdR8chrm7ZRnFXX7-ZN2cyCuCxx2mks5t93_BgaJpZM4T50dI
.

@BrockReece, Im happy for this to be merged to master. Thanks

This has been released in v2.0.0


Shorten system compatibility recommendation texts

Tweak wording returned in system_compatibility() dictionary:

"Recommended ..." --> "Recommend ..."

Partially addresses tenstorrent/tt-smi#47 by avoiding a line wrap of Ubuntu 20.04+ recommendation in tt-smi UI.

Not an endorsement of that recommendation, see #10.

Demonstration:

vs.


GTA Vendor

Above mention process is too good to tax configuration. I have need to mark vendor as GTA for reverse changes calculation. Can anybody help me to find the GTA check box in vendor master or mapped through other process.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1741b5c4-5580-d1a6-8d93-540ec7a0df0b
Version Independent ID: 3259d413-9a05-229e-f7aa-cf37fd05f293
Content: India GST - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/financials/localizations/apac-ind-gst.md
Service: dynamics-ax-applications
GitHub Login: @ShylaThompson
Microsoft Alias: ralin

The GTA - Commercial vendor option is located on the Vendors page in the Tax information tab.

Dear Shyla,
Thanks for your reply.
Unfortunately I am not getting this option. I have tried many way, even I
have compare all parameters with default company INMF.
After upload the GST configuration, service tax tax option not enabling in
GL parameter. Where as in INMF company service tax option is there in GL
parameter.
Can you suggest any other option?
On Mon, Jun 18, 2018 at 7:18 PM Shyla Thompson<EMAIL_ADDRESS>wrote:

Closed #193
https://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/193
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/dynamics-365-unified-operations-public/issues/193#event-1686225352,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Amew1Z3xZb9URz3sX0fPEDyqs3H7aU09ks5t96-vgaJpZM4UrL3V
.

--
With regards,
Uttam Mustafi
+91 98748 91806  [Kolkata]


Generate .gitignore using gitignore.io

.gitignore can be generated by gitignore.io using Javascript

Hi @coderpoker. this has been already addressed in #23 and solved in #24.
The .gitignore file in the root level is redundant and should be removed. You can check the .gitignore files inside the node_api and node_app folders.


Fix 1010 split u2f build

Closing PR as it was primarily raised to ensure tests pass prior to opening a PR to upstream.


Character cropping in the middle of URLs breaks links

If a note has 100 characters and then a 50 character URL, right now the URL is cropped in the middle. That's bad, because it's click-able but clicking on it does not open the correct link.
A user can open the trailing URL to the original note to find a proper URL, so this is not a disaster, but neither is it elegant.
A naive solution is to, when cropping the note at 120-ish characters, see if that would break a URL in half and, if so, remove the entire URL.  However, that would be bad if the post's readability were largely dependent on the URL being there.
What to do about this?

Since Twitter does URL shortening, we don't need to worry about long or malformed URLs.

I think there is no good fix for this issue. It's too painful to try to guess where a URL ends, especially since people sometimes post weird ones. Since the Tweet will have a link to the original Note, users can at worst use two clicks instead of one.
If you think of some reasonable and cool way of handling this otherwise, by all means open the issue again.


Font-size reset on click bold, italic or underline

Jodit Version:  3.2.6
Code
There is no code yet.
Expected behavior:
No font-size reset on click bold, italic or underline
Actual behavior:
Whether inline editor or normal: The font size is always reset if you click bold, italic or underline.
Example: Set the font size to 30 and then click bold.
Is there perhaps a workaround or is this a bug?

Fixed in 3.2.7