sniff_delimiter returns wrong delimiter when csv contains a lot of JSON

I haven't put together an example that reproduces this yet, as the real-world example csv contains JSON cells with around 26000 characters each of privileged information and I haven't made a test file of comparable size yet.
The expected delimiter is ",", but sniff_delimiter returns ":". If I pass the entire byte stream to csv.Sniffer() it gets the delimiter right, so I guess 1024 * 4 bytes isn't enough to disambiguate the "," from the ":" as possible delimiters with all that JSON in the mix. I'm sure we don't want to pass the entire byte stream every time, and increasing the number of bytes we pass seems like an endless game of whack-a-mole as file sizes get larger.
For our use-case, where the delimiter is known beforehand, it might be enough to just have parse accept an expected_delimiter argument that gets passed down to the ParseVisitor and down to parse_csv, calling sniff_delimiter as needed if expected_delimiter isn't specified. This wouldn't solve the problem for users that don't have prior knowledge of the delimiter, though.

Reproducing example:
import io

import pandas as pd

from fables.parse import sniff_delimiter

json_ = '{"web-app": {"servlet": [{"servlet-name": "cofaxCDS", "servlet-class": "org.cofax.cds.CDSServlet", "init-param": {"configGlossary:installationAt": "Philadelphia, PA", "configGlossary:adminEmail"<EMAIL_ADDRESS>"configGlossary:poweredBy": "Cofax", "configGlossary:poweredByIcon": "/images/cofax.gif", "configGlossary:staticPath": "/content/static", "templateProcessorClass": "org.cofax.WysiwygTemplate", "templateLoaderClass": "org.cofax.FilesTemplateLoader", "templatePath": "templates", "templateOverridePath": "", "defaultListTemplate": "listTemplate.htm", "defaultFileTemplate": "articleTemplate.htm", "useJSP": false, "jspListTemplate": "listTemplate.jsp", "jspFileTemplate": "articleTemplate.jsp", "cachePackageTagsTrack": 200, "cachePackageTagsStore": 200, "cachePackageTagsRefresh": 60, "cacheTemplatesTrack": 100, "cacheTemplatesStore": 50, "cacheTemplatesRefresh": 15, "cachePagesTrack": 200, "cachePagesStore": 100, "cachePagesRefresh": 10, "cachePagesDirtyRead": 10, "searchEngineListTemplate": "forSearchEnginesList.htm", "searchEngineFileTemplate": "forSearchEngines.htm", "searchEngineRobotsDb": "WEB-INF/robots.db", "useDataStore": true, "dataStoreClass": "org.cofax.SqlDataStore", "redirectionClass": "org.cofax.SqlRedirection", "dataStoreName": "cofax", "dataStoreDriver": "com.microsoft.jdbc.sqlserver.SQLServerDriver", "dataStoreUrl": "jdbc:microsoft:sqlserver://LOCALHOST:1433;DatabaseName=goon", "dataStoreUser": "sa", "dataStorePassword": "dataStoreTestQuery", "dataStoreTestQuery": "SET NOCOUNT ON;select test=\'test\';", "dataStoreLogFile": "/usr/local/tomcat/logs/datastore.log", "dataStoreInitConns": 10, "dataStoreMaxConns": 100, "dataStoreConnUsageLimit": 100, "dataStoreLogLevel": "debug", "maxUrlLength": 500}}, {"servlet-name": "cofaxEmail", "servlet-class": "org.cofax.cds.EmailServlet", "init-param": {"mailHost": "mail1", "mailHostOverride": "mail2"}}, {"servlet-name": "cofaxAdmin", "servlet-class": "org.cofax.cds.AdminServlet"}, {"servlet-name": "fileServlet", "servlet-class": "org.cofax.cds.FileServlet"}, {"servlet-name": "cofaxTools", "servlet-class": "org.cofax.cms.CofaxToolsServlet", "init-param": {"templatePath": "toolstemplates/", "log": 1, "logLocation": "/usr/local/tomcat/logs/CofaxTools.log", "logMaxSize": "", "dataLog": 1, "dataLogLocation": "/usr/local/tomcat/logs/dataLog.log", "dataLogMaxSize": "", "removePageCache": "/content/admin/remove?cache=pages&id=", "removeTemplateCache": "/content/admin/remove?cache=templates&id=", "fileTransferFolder": "/usr/local/tomcat/webapps/content/fileTransferFolder", "lookInContext": 1, "adminGroupID": 4, "betaServer": true}}], "servlet-mapping": {"cofaxCDS": "/", "cofaxEmail": "/cofaxutil/aemail/*", "cofaxAdmin": "/admin/*", "fileServlet": "/static/*", "cofaxTools": "/tools/*"}, "taglib": {"taglib-uri": "cofax.tld", "taglib-location": "/WEB-INF/tlds/cofax.tld"}}}'

df = pd.DataFrame(dict(a=['one'], b=['two'], c=[json_]))
stream = io.BytesIO(df.to_csv(index=False).encode('utf-8'))
sniff_delimiter(stream)  # returns ":"

Thanks for the detailed report! This is a fascinating edge case!
expected_delimiter feels like a good, practical way to solve this. Agreed, that it cuts through the Fables abstraction layer a bit with the user having to have an expectation for the file.
I wonder if it would be possible, as an alternative to reading in 1024 * 4 bytes, to have sniff_delimiter calculate the number of bytes in e.g. the first 5 or so non-blank lines (or perhaps lines containing at least one ,) (maybe doing something with seen \n's), and then use that many bytes. Maybe 1024 * 4 isn't "wide" enough to pull in complete lines in this case, and that's why the underlying csv.Sniffer chooses the wrong delimiter?
Another hack could be to have a line restricting fables.parse.ACCEPTED_DELIMITERS = {",", "\t"} (not sure if this actually work). This could be made into less of a hack if we allowed the user to explicitly set options something like the way pandas has pd.options.... This would be useful too for other Fables variables that could be seen as options including FRACTION_OF_BLANK_HEADERS_ALLOWED, MAX_FILE_SIZE, and OS_PATTERNS_TO_SKIP.

Both those approaches make sense to me. I tried a quick test of the first approach, but found that it still returned the wrong delimiter. Sample code below.
import csv

from fables.parse import ACCEPTED_DELIMITERS

# skipping first few lines of example in earlier comment
df = pd.DataFrame(dict(a=list('abc'), b=list('123'), c=[json_]*3))
stream = io.BytesIO(df.to_csv(index=False).encode('utf-8'))
i = 0
sample = b""
for row in stream:
    if i >= 3:
        break
    sample += row
    i += 1
stream.seek(0)
sniffer = csv.Sniffer()
dialect = sniffer.sniff(sample.decode(encoding="utf-8"), delimiters="".join(ACCEPTED_DELIMITERS))
dialect.delimiter  # returns ":"

This is feeling more like a limitation of csv.Sniffer in general.
I did try the other approach, of monkey patching the ACCEPTED_DELIMITERS, but that didn't work. I really like the idea of making the options configurable like pandas, though I'm not sure I have the bandwidth to implement that robustly. Looking at the pandas implementation, they abstracted validation and callbacks really nicely, ideally we'd have a similar scheme for validating the values and providing feedback if the user uses an invalid value.

Thanks for giving these approaches a try!
I stumbled across this library: https://github.com/alan-turing-institute/CleverCSV and just tried pip install clevercsv and replacing csv with clevercsv with your code listing and it returned ,!
I forgot about this, but I think we actually considered using clevercsv near the beginning of Fables development, but the built-in csv.Sniffer was working well enough at the time ...
I'd be curious to see if it works with your real world example.

Just gave that a try, it did work on my real-world example! This seems like the best path forward. No interface changes, nothing new to implement. I'll work on a PR making that update. Thanks for the suggestion!!


Switch CI_release.yml to 2024.2.pre0

Test release pipeline: https://github.com/ansys/pydpf-core/actions/runs/7900013659

Trying to skip a problematic doctest line for Ubuntu on 3.9 with 2024.2.pre0: https://github.com/ansys/pydpf-core/actions/runs/7904444681/job/21577966159


Support tracking external observations (Landmarks) as constraints

Users expressed interest to add constraints to visual features, GPS tracks, or bluetooth beacons as constraint for the SLAM. This is the tracking issue for discussion and implementation of this feature.

Here is an example of a mobile base with an AR tag on the gripper, as I had mentioned on today's google hangout:

In this case the landmark may move relative to both the sensor and world. Both sensors and grippers could be on the robot, the gripper, or the wall. Furthermore, with an AR tag on the base in addition to the gripper poses based on individual joint angles could be estimated and incorporated to refine the estimate.
I understand this case may be out of scope but even if it cannot be incorporated, it could still useful to consider that landmarks such as AR tags may move in known manner relative to both the world and the robot. Perhaps the API design might then be set up such that it can be more easily extended for this sort of data later on.

@SirVer mentioned that the currently proposed API in #246 is not sufficient in some use cases during the open house meeting. Could you explain what is missing?


How to remove line graph pop up

On line graphs i cant git rid of this pop up when i click on the chart, how can i opt out of this??

pretty sure its lineTouchData but i cant set this to null

lineTouchData: LineTouchData(enabled: false),


"Read-While-Write" EEPROM emulation for ATSAMD21 micros?

This HAL for ATSAMD51 has support for the NVM and the Smart EEPROM feature. Similar to the SAMD51, the SAMD21 has some flash reserved for EEPROM-like functionality, which can be written while the main program memory is read (called "Read-While-Write EEPROM Emulation" in the datasheet). It's only present on devices with <256KB of flash, and only on some variants (B, C, D, and L)

Hi @NightEule5 , and apologies for the slow response!  There are certainly functionalities which we don't yet have implemented in the HAL, for chips that we support.  I believe you're correct that we don't have an implementation of SAMD21 EEPROM emulation, might you be interested in adding one?


feature: add curator config and functionality

related to #70
curator_pure has following uploads:

other account with role "curator_pure":

other account without role "curator_pure":

TODOs

add CLI command on how to add the roles.
add small documentation about pure-records having its own Permissionpolicy. and using the generator from config modules.


Remove lakeFS client stub

The proper typing information was upstreamed and included in v0.105.0.
Since that is the minimum we require now, we can safely delete the stub file again and rely on the package typing info.
Also switch out API member calls on the lakeFS client.
The non-suffixed members, e.g. client.objects or client.branches, were deprecated in v0.105.0, so we switch out to the suffixed members instead.
These were always the same anyways (matching object IDs), so there is no change in behavior.

cc @AdrianoKF


Explorer: Locate Current Buffer (minor bugfix + additional tests)

Add command palette option "Explorer: Locate Current Buffer" that will
expand directories down to the current buffer, then select the
corresponding file/directory.

As I'm entirely new to the Oni codebase I thought I would submit this before I tackle writing tests, in the hopes someone can take a look and let me know if my approach is reasonable.

@Akin909 Thanks for the quick feedback!
I've changed the SUCCESS action logic so that it doesn't trigger unnecessarily.  It seems odd that dispatching such a simple action (which isn't part of the epic) would slow things down.  When I tried I could maybe feel some slight lag, but not particularly noticeable.  Perhaps my machine is just able to absorb the extra effort.
I do find the Explorer pane is a bit buggy when scrolling down beyond the last visible file. The pane seems to scroll jump up and down.  That bug is present in the current stable release, which I'm using for development, so I'm not too concerned that my changes broke it.  I'll try to remember to check if there's an existing bug report and if not I'll make one.
Activating the Explorer if it's closed is a nice idea, I'll add that asap.

Re. the flicker in the explorer that isn't because of your changes its a known bug i've opened #2182 in order to fix that

@Akin909 - well spotted on the duplicated nodePath function, thanks for that.
Now the Explorer will open if it was closed when locating a file.

@feltech just tried it again works really well and now opens the explorer, thanks for adding that 👍. re. testing I don't think you need too many here my recommendation would be just testing the reducer and epic, the other tests are here in terms of examples of how those work

Still more tests to write.  That weird redux-mock-store bug was an odd one.

@feltech thanks for adding so all those tests 🎉

@feltech is this complete?

Nearly, working on the final test now (though it's late here so might take another day).

OK, assuming checks/review pass, we're good to go.
I had a problem running the entire integration test suite locally - it stops on Configuration.TypeScriptEditor.CompletionTest.ts, where the autocomplete never shows.
I don't think anything I did affects that, so I'm hoping it's just my local machine is misconfigured (I suspect the vim-session plugin is causing problems).

Hmm, this OSX integration test failure is interesting.  The buffer's path (oni.editors.activeEditor.activeBuffer.filePath) begins with /var/.  Whereas the workspace root (oni.workspace.activeWorkspace) is /private/var.  If I remember the OSX file system correctly, /var symlinks to /private/var (maybe the other way around).  So a naive check for the buffer's path being a descendent of the root fails.

These integration tests are annoyingly unstable.  In this most recent case a test passed on OSX, then ran again and failed, failing the job.  Plus the Linux test didn't even get past installing packages.
I think it would be worth removing the need to run the test twice if it succeeds, and only run multiple times on failure.
I also think it would be nice to remove the --bail parameter, so that all tests run even if they fail, to get a better idea of what needs fixing.

@feltech

These integration tests are annoyingly unstable. In this most recent case a test passed on OSX, then ran again and failed, failing the job. Plus the Linux test didn't even get past installing packages.

Unfortunately they are still quite flaky I think because of all of the various dependencies and having to open an editor cross platform it results in a lot of false negatives. I agree it would be nice to have them all run I think the idea though was to save time rather than having a full long test suite run this way we find out if theres an error as soon as possible would be interested in @bryphe opinion
Re. this PR ill re-run the tests a couple of times to see if the error resolves thanks for bearing with it will be great to have this in

Yeah it works locally for me, but I'm on Linux.  It consistently fails on OSX.  I'll try to get some time with an OSX box tomorrow to check it out.

I use a mac so can have a look at the test later as well when I get a chance

I tried at lunch today on OSX (10.12 on a Mac Pro).  I still couldn't get PrettierPluginTest to fail (though AutoCompletionTest-Reason consistently failed with a timeout). I tried the test in isolation, running test:integration, even running the exact scripts that the travis build runs.
I didn't have much time to play, so perhaps I didn't set it up properly or something.  I'll keep hacking at it..

@feltech since the changes involving the CI test are being quite flaky, how about separating this branch at commit 96ddb79 and submitting that which was the last passing build and opening a separate PR for the work on the CI test I think the other tests are enough to meet the diff and coverage requirements and cover the functionality well and if you would still like to finish work on the CI test you can submit that separately so you arent blocked by this

That's a good plan.  My one concern is that the OSX integration test for this feature did highlight a genuine issue to do with symlinks, so it would be good to include the fix for that.  I suppose that could be part of a separate PR to improve the feature (along with the fixes to the CI tests).

I've now split at the last successful build as #2456.  However, I had to merge in master so the tests are going to run again...
I still hold out some hope of fixing all this up. So it would be good to keep this PR around so I can abuse Travis a bit longer.

No freaking way.  Finally Travis stops complaining!  There's a bunch of debug logs to remove and other tidying.  Hopefully the build still passes after that.

OK then, pending review I think this is good to go.

@feltech 🎉 glad you managed to get the CI tests working 👍 looks good to me.
Re. the CI test changes tbh I havent spent a great deal of time looking at how its all setup what do the changes you've made do? also might be worth if (hes available getting @bryphe or) @CrossR to review

From a quick look, it looks like the main changes are swapping to using a temporary workspace in some tests, since currently they run in the full Oni repo. That should help a few of the tests, but we may want to revert it if in the future we do some performance tests since the Oni repo is nice to test against as its a decent size.
The other changes seem to be removing the "before" and "after" parts of the CI tests, and collapsing it down into the test itself. It doesn't look to change the tests themselves, but if it helps reliability then sounds good! Only part I wasn't quite sure on was the catching and then doing nothing with the error in the final try-finally of runInProcTest.
As for the runInBand and no-cache, from a quick Google they looked like jest flags not mocha flags, but I could be wrong.

Ah good point.  A summary of the changes:

A few integration tests now use a temporary workspace, rather than relying on whatever default workspace Oni opens.
The PrettierPluginTest now checks for the presence of the statusbar icon in a waitFor.  Looking at the flux actions in the log output there were a lot of STATUSBAR_SHOW (or some such) around the same time as the assertion, so I concluded it was a race condition.
I removed the beforeEach and afterEach in the main runInProcTest, and instead put their logic inside the (single) it, with an appropriate try/catch clause.  This means if the setup/teardown fails, the configured retries will still take place.  I.e. if there is an error in a before/afterEach then the test does not retry, which was annoying.
During teardown of Oni, I noticed that it would sometimes hang trying to get the windowCount, which only appears to be used for logging, so I made that time out non-fatally.
In package.json I added a couple of switches to the test:integration call.... OK just read your comment @CrossR - I may well have been mistaken there and those switches are pointless.

@CrossR

Only part I wasn't quite sure on was the catching and then doing nothing with the error in the final try-finally of runInProcTest.
My thinking was that if Oni had failed to start or was in some other bad state, then presumably we could get an exception trying to stop it, which we don't really care about.

I suppose the downside is that if Oni fails to shut down, then that specific test won't fail (should it?).
However, I suspect in that case subsequent tests will fail, because there would be two instances of Oni running, which is bad news for these integration tests.

@CrossR Re. swapping to use a temporary workspace in some tests:
I did this originally in the integration test for this feature, so that I wasn't relying on a specific workspace and some arbitrary file existing in it.
Then I found that subsequent tests will run in that same temporary workspace, and at least one of those tests does rely on an arbitrary file in the Oni repo.  I judged that to be bad practice, so went with refactoring that test to also use a temporary workspace.
I do get your point about monitoring performance.  Though integration tests that break because of a side-effect of a previous integration test are a pain to debug.
I'm happy to change the test I wrote to rely on running in the Oni repo as it's workspace, if that's the standard.

I'm happy to change the test I wrote to rely on running in the Oni repo as it's workspace, if that's the standard.

Nah, its fine! Your new implementation is great, its better to setup a proper workspace rather than depend on a file which could maybe move etc. It was more just a mental note that if in the future we swap to checking performance, we'd want to update it so we are running in a bigger repo for more realistic performance.

Just wanted to check this PR can be merged, since its got WIP in the title still! Otherwise looks good.
I assume the split-off PR can be closed?

Hey, yep it's ready to go.  I'll close the other PR.


Cannot deploy on AWS with v1.0.0 release candidate

I used the latest release to deploy on EC2. It fails as follows (just showing the relevant parts of the CLI output):
[...]
Creating minion configuration
Creating autoscaling group
 0 minions started; waiting
 0 minions started; waiting
 0 minions started; waiting
 0 minions started; waiting
 1 minions started; waiting
 1 minions started; waiting
 2 minions started; ready
Waiting 3 minutes for cluster to settle
..................Re-running salt highstate
Waiting for cluster initialization.

  This will continually check to see if the API for kubernetes is reachable.
  This might loop forever if there was some uncaught error during start
  up.

Kubernetes cluster created.
Wrote config for aws_kubernetes to /Users/florian/.kube/config
Sanity checking cluster...
Attempt 1 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 2 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 3 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 4 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 5 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 6 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 7 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 8 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 9 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 10 to check Docker on node @ <IP_ADDRESS> ...not working yet
Attempt 11 to check Docker on node @ <IP_ADDRESS> ...not working yet

Your cluster is unlikely to work correctly.
Please run ./cluster/kube-down.sh and re-create the
cluster. (sorry!)

Here are the environment variables I use:
export KUBERNETES_PROVIDER=aws
export KUBE_AWS_ZONE=eu-central-1a
export NUM_MINIONS=2
export MINION_SIZE=m3.medium
export AWS_S3_REGION=eu-central-1
export INSTANCE_PREFIX=k8s

The minion has the following content in the salt log:
root@ip-172-20-0-53:~# cat /var/log/salt/minion
2015-07-15 10:00:26,226 [salt.state       ][ERROR   ] An exception occurred in this state: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1533, in call
    **cdata['kwargs'])
  File "/usr/lib/python2.7/dist-packages/salt/states/sysctl.py", line 56, in present
    configured = __salt__['sysctl.show'](config_file=True)
  File "/usr/lib/python2.7/dist-packages/salt/modules/linux_sysctl.py", line 86, in show
    for line in salt.utils.fopen(config_file_path):
  File "/usr/lib/python2.7/dist-packages/salt/utils/__init__.py", line 1065, in fopen
    fhandle = open(*args, **kwargs)
IOError: [Errno 2] No such file or directory: '/etc/sysctl.d/99-salt.conf'

2015-07-15 10:00:34,989 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'runlevel /run/utmp' failed with return code: 1
2015-07-15 10:00:34,989 [salt.loaded.int.module.cmdmod][ERROR   ] output: Too many arguments.
2015-07-15 10:00:35,117 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'service docker status' failed with return code: 3
2015-07-15 10:00:35,117 [salt.loaded.int.module.cmdmod][ERROR   ] output: * docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Wed 2015-07-15 10:00:35 UTC; 18ms ago
     Docs: http://docs.docker.com
  Process: 19728 ExecStart=/usr/bin/docker -d -H fd:// $DOCKER_OPTS (code=exited, status=1/FAILURE)
 Main PID: 19728 (code=exited, status=1/FAILURE)
2015-07-15 10:00:42,288 [salt.state       ][ERROR   ] The named service kubelet is not available
2015-07-15 10:00:44,836 [salt.state       ][ERROR   ] The named service kube-proxy is not available

I have been seeing this in older version too (v0.21.2).

@justinsb

@brendandburns

FWIW — I'm seeing a similar issue in our testing as well.

I will try to reproduce

I was able to get it working now following: https://github.com/GoogleCloudPlatform/kubernetes/blob/v1.0.0/docs/getting-started-guides/aws.md

I suspect the problem is the S3 bucket being in a non-default region, I haven't tested this as much.  But I will try to figure it out.

@justinsb you think if I switch out the S3 location to default (i.e., unset the env var that I use), it should work.
I can try that as well but tbh I see no correlation between the salt error and the S3 location. But I'm no expert here, just a user :)

Hmmm .. it came up for me, even with the S3 bucket being in a different region.
Do you still have a non-working cluster?  Can you try running systemctl status docker on <IP_ADDRESS> so we can see the status of docker?
The error messages from kubelet are mostly known:

No such file or directory: '/etc/sysctl.d/99-salt.conf' is fixed in #10401, but I think mostly harmless.
The messages about kubelet & kube-proxy are just salt saying the service isn't installed before installing it

The docker message I'm not so sure about, which is why I'd like to see the output from systemctl status docker!

@frosenberg so that was my theory, but I am no longer convinced, as it worked for me.  And the salt files come from S3, so if that was the problem I suspect we would fail much earlier.  It looks more like something went wrong with docker startup.  Output from systemctl status docker would be the next step, I believe.

@preillyme if you followed the procedure, I guess you installed v0.21.1, right?

Just followed the aws docs and installed v0.21.1. Same issue here. Trying version 1.0.0 now.
Docker fails to come up. Here is the upstart log /var/log/upstart/docker.log:
root@ip-172-20-0-193:~# cat /var/log/upstart/docker.log
Waiting for /var/run/docker.sock
INFO[0000] +job serveapi(unix:///var/run/docker.sock)
INFO[0000] Listening for HTTP on unix (/var/run/docker.sock)
INFO[0000] +job init_networkdriver()
no such network interface
INFO[0000] -job init_networkdriver() = ERR (1)
FATA[0000] Shutting down daemon due to errors: no such network interface

The same entry keeps repeated in the log.
The /var/log/salt/minion log shows this:
root@ip-172-20-0-193:~# cat /var/log/salt/minion
2015-07-15 20:39:07,796 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'service kubelet status' failed with return code: 3
2015-07-15 20:39:07,797 [salt.loaded.int.module.cmdmod][ERROR   ] output:  * kubelet is not running
2015-07-15 20:39:10,021 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'service kube-proxy status' failed with return code: 3
2015-07-15 20:39:10,022 [salt.loaded.int.module.cmdmod][ERROR   ] output:  * kube-proxy is not running
2015-07-15 20:39:14,996 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'crontab -l | grep "* * * * * /etc/monit/monit_watcher.sh 2>&1 | logger"' failed with return code: 1
2015-07-15 20:39:14,997 [salt.loaded.int.module.cmdmod][ERROR   ] output: no crontab for root
2015-07-15 20:39:21,636 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'service docker start' failed with return code: 1
2015-07-15 20:39:21,636 [salt.loaded.int.module.cmdmod][ERROR   ] output: start: Job failed to start
2015-07-15 20:39:21,641 [salt.state       ][ERROR   ] Service docker is already disabled, and is dead
2015-07-15 20:39:23,469 [salt.loaded.int.module.cmdmod][ERROR   ] Command 'service kubelet status' failed with return code: 1
2015-07-15 20:39:23,469 [salt.loaded.int.module.cmdmod][ERROR   ] output:  * kubelet is not running

Just ran a test with v1.0.0 (distro 'vivid'). It fails as well with docker not coming up.
root@ip-172-20-0-71:~# systemctl status docker
● docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
   Active: activating (auto-restart) (Result: exit-code) since Wed 2015-07-15 21:25:04 UTC; 760ms ago
     Docs: http://docs.docker.com
  Process: 29131 ExecStart=/usr/bin/docker -d -H fd:// $DOCKER_OPTS (code=exited, status=1/FAILURE)
 Main PID: 29131 (code=exited, status=1/FAILURE)
   CGroup: /system.slice/docker.service

Jul 15 21:25:04 ip-172-20-0-71 systemd[1]: docker.service: main process exited, code=exited, status=1/FAILURE
Jul 15 21:25:04 ip-172-20-0-71 systemd[1]: Unit docker.service entered failed state.
Jul 15 21:25:04 ip-172-20-0-71 systemd[1]: docker.service failed.

Any clue? Cloud the ubuntu image in region in eu-central-1 be busted? I give it another try in the us-east region.

Ran the whole process in us-east-1 again. Same issue. Some more log information from syslog:
Jul 15 21:51:45 ubuntu systemd[1]: docker.service holdoff time over, scheduling restart.
Jul 15 21:51:45 ubuntu systemd[1]: Stopping Docker Socket for the API.
Jul 15 21:51:45 ubuntu systemd[1]: Starting Docker Socket for the API.
Jul 15 21:51:45 ubuntu kubelet[29715]: I0715 21:51:45.107995   29715 manager.go:163] Version: {KernelVersion:3.19.0-20-generic ContainerOsVersion:Ubuntu 15.04 DockerVersion:Unknown CadvisorVersion:0.15.1}
Jul 15 21:51:45 ubuntu kubelet[29715]: I0715 21:51:45.108511   29715 aws.go:483] Zone not specified in configuration file; querying AWS metadata service
Jul 15 21:51:45 ubuntu systemd[1]: Listening on Docker Socket for the API.
Jul 15 21:51:45 ubuntu systemd[1]: Started Docker Application Container Engine.
Jul 15 21:51:45 ubuntu systemd[1]: Starting Docker Application Container Engine...
Jul 15 21:51:45 ubuntu docker[29723]: time="2015-07-15T21:51:45Z" level=info msg="+job serveapi(fd://)"
Jul 15 21:51:45 ubuntu docker[29723]: time="2015-07-15T21:51:45Z" level=info msg="Listening for HTTP on fd ()"
Jul 15 21:51:45 ubuntu docker[29723]: time="2015-07-15T21:51:45Z" level=info msg="+job init_networkdriver()"
Jul 15 21:51:45 ubuntu docker[29723]: no such network interface
Jul 15 21:51:45 ubuntu docker[29723]: time="2015-07-15T21:51:45Z" level=info msg="-job init_networkdriver() = ERR (1)"
Jul 15 21:51:45 ubuntu docker[29723]: time="2015-07-15T21:51:45Z" level=fatal msg="Shutting down daemon due to errors: no such network interface"
Jul 15 21:51:45 ubuntu systemd[1]: docker.service: main process exited, code=exited, status=1/FAILURE
Jul 15 21:51:45 ubuntu systemd[1]: Unit docker.service entered failed state.
Jul 15 21:51:45 ubuntu systemd[1]: docker.service failed.
Jul 15 21:51:45 ubuntu kubelet[29715]: F0715 21:51:45.316816   29715 plugins.go:90] Couldn't init cloud provider "aws": error listing AWS instances: UnauthorizedOperation: You are not authorized to perform this operation.
Jul 15 21:51:45 ubuntu kubelet[29715]: status code: 403, request id: []
Jul 15 21:51:45 ubuntu systemd[1]: kubelet.service: main process exited, code=exited, status=255/n/a
Jul 15 21:51:45 ubuntu systemd[1]: Unit kubelet.service entered failed state.
Jul 15 21:51:45 ubuntu systemd[1]: kubelet.service failed.
Jul 15 21:51:45 ubuntu systemd[1]: kubelet.service holdoff time over, scheduling restart.
Jul 15 21:51:45 ubuntu systemd[1]: Started Kubernetes Kubelet Server.
Jul 15 21:51:45 ubuntu systemd[1]: Starting Kubernetes Kubelet Server...
Jul 15 21:51:45 ubuntu kubelet[29785]: I0715 21:51:45.634455   29785 server.go:271] Using root directory: /mnt/ephemeral/kubernetes/kubelet
Jul 15 21:51:45 ubuntu kubelet[29785]: I0715 21:51:45.635003   29785 manager.go:127] cAdvisor running in container: "/"
Jul 15 21:51:45 ubuntu kubelet[29785]: I0715 21:51:45.635774   29785 fs.go:93] Filesystem partitions: map[/dev/disk/by-uuid/ce99c711-e060-49c5-9633-9d4a92a96e43:{mountpoint:/ major:202 minor:1} /dev/mapper/vg--ephemeral-docker:{mountpoint:/mnt/ephemeral/docker major:252 minor:4} /dev/mapper/vg--ephemeral-kubernetes:{mountpoint:/mnt/ephemeral/kubernetes major:252 minor:5}]
Jul 15 21:51:45 ubuntu kubelet[29785]: I0715 21:51:45.638781   29785 manager.go:156] Machine: {NumCores:1 CpuFrequency:2494048 MemoryCapacity:3946217472 MachineID:2cbbdda5667a405fae66c42307efe2c4 SystemUUID:EC23ACBC-6F77-C4C1-6E06-6EDEBBC22DB4 BootID:df91a047-1eb0-4644-88d8-f8ed06c50b89 Filesystems:[{Device:/dev/disk/by-uuid/ce99c711-e060-49c5-9633-9d4a92a96e43 Capacity:8309932032} {Device:/dev/mapper/vg--ephemeral-docker Capacity:4135649280} {Device:/dev/mapper/vg--ephemeral-kubernetes Capacity:198902784}] DiskMap:map[252:5:{Name:dm-5 Major:252 Minor:5 Size:209715200 Scheduler:none} 202:0:{Name:xvda Major:202 Minor:0 Size:8589934592 Scheduler:deadline} 202:32:{Name:xvdc Major:202 Minor:32 Size:4289200128 Scheduler:deadline} 252:0:{Name:dm-0 Major:252 Minor:0 Size:4194304 Scheduler:none} 252:1:{Name:dm-1 Major:252 Minor:1 Size:4068474880 Scheduler:none} 252:2:{Name:dm-2 Major:252 Minor:2 Size:4068474880 Scheduler:none} 252:3:{Name:dm-3 Major:252 Minor:3 Size:4068474880 Scheduler:none} 252:4:{Name:dm-4 Major:252 Minor:4 Size:4269801472 Scheduler:none}] NetworkDevices:[{Name:eth0 MacAddress:0a:ae:39:14:d3:23 Speed:0 Mtu:9001}] Topology:[{Id:0 Memory:3946217472 Cores:[{Id:0 Threads:[0] Caches:[{Size:32768 Type:Data Level:1} {Size:32768 Type:Instruction Level:1} {Size:262144 Type:Unified Level:2}]}] Caches:[{Size:26214400 Type:Unified Level:3}]}]}

I think it boils down to the no such network interface error when starting up docker.

Looks like it is working now. I suspect it was the IAM role for the minion (b/c that is the only thing I clean up between the last kube-up run and this one). I had one laying around from a some older version that was different. I was not aware the the kube-up.sh does not update an "outdated" IAM role.

Ah; thank you for noticing that.  There is indeed an issue where we don't verify the IAM role configuration.  My thinking here is that users may have deliberately granted more rights to their masters/minions.  Perhaps that is much rarer than the much-more-common case of us changing the IAM configuration.
kubelet restarts docker after it configures cbr0, so it sounds like that is why Docker was not starting when the IAM credentials were broken.
This is obviously not a great state-of-the-world; I will think about what we can do to make it better!

I'm closing this since this issue is resolved for me. Found another issue with DNS but I file a separate one.

Thanks @frosenberg ; I opened #11373 because this has persuaded me that we should verify the IAM policy (because this was so unexpected).  I don't know if there is another issue that will come out of this around the fact that docker failed to start, but I think that may be "correct" (although surprising); we can't start docker till kubelet configures the network bridge.


Release 0.2.0

I think I will defer the automated machinery for now and just do this one manually.
The todo list

[x] Update version refs to be "0.2.0"
[x] Add a change log
[x] Git tag (using the release mechanism on github)
[x] Upload artifacts to pypi
[ ] Release Party?

Could you also add the link to the doc in the github short description of the reposirory?

Released! (That party is optional)

I'll celebrate it!


Ci tests cleanup

I changed some input sample sheets according to the new tests on nf-core/metapep (https://github.com/nf-core/metapep/pull/93)

It's a bit confusing, there is a input.bins.csv and input.bins_only.csv now. I guess in the past bins was not tested in the main test profile and called input.bins.csv, but since bins are also tested in the main test profile, this is probably not necessary anymore, right? So one could just delete one

These files are not used in any test:

https://github.com/nf-core/test-datasets/blob/metapep/testdata/fullsize_CAMISIM_SPAdes.G0_T2.top300000.fasta.gz
https://github.com/nf-core/test-datasets/blob/metapep/testdata/fullsize_CAMISIM_SPAdes.G0_T2_depths.top300000.tsv

Should I delete them? We still have T0 and T1!

These files are not used in any test:

https://github.com/nf-core/test-datasets/blob/metapep/testdata/fullsize_CAMISIM_SPAdes.G0_T2.top300000.fasta.gz
https://github.com/nf-core/test-datasets/blob/metapep/testdata/fullsize_CAMISIM_SPAdes.G0_T2_depths.top300000.tsv

Should I delete them? We still have T0 and T1!

Yes, do it :)

Since the samplesheet for the full-size test ist called samplesheet.fullsize_assembly.csv, would it maybe make sense to call all those files samplesheet.XX.csv instead of input*?

Why exactly is input.mouse_assembly.csv needed?

Not sure, could one maybe improve the naming scheme in test-datasets/testdata?

I tried cleaning up the files again, and renamed all input. ... to samplesheet. ...! Maybe you can shortly look at it again @skrakau?


Leaflet popup overlaying polygon blocks mouseover event

example code: https://plnkr.co/edit/baMA0hrGq5XgG8Tb
I have a polygon that gets highlighted on mouseover. inside the polygon there is an icon and a popup bind to it.
The problem is: when I hover over the popup, the polygon's mouseout is triggered, thus its not highlighted although the cursor is still inside the polygon, I don't want that to happen
I tried:

using the popup offset method (documented: https://leafletjs.com/reference.html#divoverlay)
using a specific css styling to the popup to prevent that

Is there a way to achieve that without using a plugin?

Any reason why you created https://stackoverflow.com/questions/70970960/leaflet-popup-overlaying-polygon-blocks-mouseover-event and then deleted it?

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.
If you are really sure that this is a bug in leaflet, or a feature request, please change the wording to make it look like a bug report.


[ocaml5-issue] Assertion failure when allocating memory in Buffer test on macos

On trunk (but fetching the exact commit failed) with an failed allocation in Buffer tests:
random seed: 125017365
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s STM Buffer test sequential
[ ]    0    0    0    0 / 1000     0.0s STM Buffer test sequential (generating)
[✓] 1000    0    0 1000 / 1000     0.6s STM Buffer test sequential

Fatal error: allocation failure during minor GC

We had seen a lot of issues with compilations of dependencies being killed on macos CI runners: may that be another symptom of too many memory constraints on that platform? :thinking:

I'm wondering whether this is the known Buffer unsafety which is still open: https://github.com/ocaml/ocaml/issues/11279
There's a good looking candidate fix in https://github.com/ocaml/ocaml/pull/11742

Seen also on Windows: https://github.com/shym/multicoretests/actions/runs/3522675835/jobs/5905925671#step:8:830
And with it, goes my hypothesis about memory limits on macos runners.

Potentially this can still be due to the known Buffer unsafety, if, e.g., a size field gets corrupted before resizing :thinking:
Could be interesting to give ocaml/ocaml#11742 a spin with the Buffer test and see if the issue remains...

Also triggered on Windows 5.0.0~beta1:
https://github.com/jmid/multicoretests/actions/runs/3522482423/jobs/5905515367
random seed: 9296128
generated error fail pass / total     time test name

[ ]    0    0    0    0 / 1000     0.0s STM Buffer test sequential
[ ]    0    0    0    0 / 1000     0.0s STM Buffer test sequential (generating)
[✓] 1000    0    0 1000 / 1000     0.5s STM Buffer test sequential

File "src/buffer/dune", line 16, characters 0-111:
16 | (rule
17 |  (alias runtest)
18 |  (package multicoretests)
19 |  (deps stm_tests.exe)
20 |  (action (run ./%{deps} --verbose)))

(cd _build/default/src/buffer && ./stm_tests.exe --verbose)
Command exited with code -1073741819.
[ ]    0    0    0    0 / 1000     0.0s STM Buffer test parallel

As ocaml#11742 is part of β2, let’s see what happens now!

Not spotted since the release of 5.0.0~beta2 with the Buffer fix, so closing.


Features: Force dtype conversion if FeatureMetadata differs from actual dtype

Issue #, if available:
Description of changes:

Previously, if user manually set different raw types in FeatureMetadata from what the real dtypes are in Pandas, the Pandas dtype would be used. Now, the FeatureMetadata type is used and the dtypes are converted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1212-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1212/1/index.html

Job PR-1212-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1212/2/index.html


Use the latest RPMRepo snapshot for RHEL-9.0 image tests

This is needed to satisfy RPM dependencies of GCP guest tools, which
will be installed on the gce image type.
Signed-off-by: Tomas Hozza<EMAIL_ADDRESS>This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Looks good but I would prefer to land https://github.com/osbuild/osbuild-composer/pull/2196 firstly, sorry. :/

Looks good but I would prefer to land #2196 firstly, sorry. :/

Actually #2196 is updating image tests ti the same RPMRepo snapshot, so this PR may not be needed at all. So much wasted computing power on so many architectures 😵  😆

Reopened, because #2196 will take some time until it is mergeable.


M1 mac with Docker WatchfilesRustInternalError: Error creating watcher: Function not implemented (os error 38)

Description
When starting django with the watcher (after installing from pypi from the wheel)
PostgreSQL is available
INFO:     Will watch for changes in these directories: ['/app']
INFO:     Uvicorn running on http://<IP_ADDRESS>:8000 (Press CTRL+C to quit)
INFO:     Started reloader process [18] using WatchFiles
Traceback (most recent call last):
  File "/usr/local/bin/uvicorn", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
=== Starting migration
Operations to perform:
  Apply all migrations: account, address, admin, auth, contenttypes, customers, orders_tenant, permissions, sessions, socialaccount, users
Running migrations:
  No migrations to apply.
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.9/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/uvicorn/main.py", line 407, in main
    run(
  File "/usr/local/lib/python3.9/site-packages/uvicorn/main.py", line 570, in run
    ChangeReload(config, target=server.run, sockets=[sock]).run()
  File "/usr/local/lib/python3.9/site-packages/uvicorn/supervisors/basereload.py", line 45, in run
    for changes in self:
  File "/usr/local/lib/python3.9/site-packages/uvicorn/supervisors/basereload.py", line 64, in __next__
    return self.should_restart()
  File "/usr/local/lib/python3.9/site-packages/uvicorn/supervisors/watchfilesreload.py", line 85, in should_restart
    changes = next(self.watcher)
  File "/usr/local/lib/python3.9/site-packages/watchfiles/main.py", line 103, in watch
    watcher = RustNotify([str(p) for p in paths], debug, force_polling, poll_delay_ms)
_rust_notify.WatchfilesRustInternalError: Error creating watcher: Function not implemented (os error 38)

Example Code
No response
Example Code Output
No response
Operating System
Mac M1 12.3.1 (21E258)
Environment
Docker
Watchfiles Version
0.15.0
Python Version
3.9
Rust & Cargo Version
cargo: not found; rustc: not found

Which docker image?

Maybe worth checking if the correct wheel was installed.
I've run watchfiles inside docket on my M1 Mac and it worked fine.

I can reproduce this without Django or Uvicorn. The error occurs on an Apple Silicon M1 Mac, but not on an Intel Mac, and occurs even if specifying the platform.
watch.py
from watchfiles import watch

for changes in watch('/hello.py'):
    print(changes)

hello.py
print('hello world')

Dockerfile
FROM python:3.10
RUN pip install watchfiles==0.15.0
COPY hello.py watch.py /
CMD watchfiles watch /hello.py

docker build . --platform linux/amd64 -t watchfiles-example
docker run -p 8080:80  --platform linux/amd64 -v "$(pwd)/hello.py":"/hello.py" watchfiles-example

[20:55:51] watchfiles 👀  path="/hello.py" target="watch" (command) filter=DefaultFilter...
Traceback (most recent call last):
  File "/usr/local/bin/watchfiles", line 8, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.10/site-packages/watchfiles/cli.py", line 150, in cli
    run_process(
  File "/usr/local/lib/python3.10/site-packages/watchfiles/run.py", line 130, in run_process
    for changes in watch(
  File "/usr/local/lib/python3.10/site-packages/watchfiles/main.py", line 103, in watch
    watcher = RustNotify([str(p) for p in paths], debug, force_polling, poll_delay_ms)
_rust_notify.WatchfilesRustInternalError: Error creating watcher: Function not implemented (os error 38)

Consider reporting to Docker upstream (docker/roadmap#7).

+1 on this

Okay, I can reproduce this.
First the good news:

I don't get this error (and watchfiles seems to correctly detect changes) if I remove --platform linux/amd64
Same if I use force_polling=True
As per the traceback, watchfiles is catching this error, so we should be able to catch the error and gracefully fall back to polling

It might also be worth honouring an env variable to enable polling for those who are using watchfiles via a third party library and therefore aren't able to use the kwarg directly.
In terms of the underlying error and how to handle it, I'm not really sure where to go.
@messense do you have any ideas?

From the logs, pip is installing watchfiles-0.15.0-cp37-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.whl.
I tried packing pip to allow me to install other wheels directly and tried installing  watchfiles-0.15.0-cp37-abi3-manylinux_2_17_armv7l.manylinux2014_armv7l.whl and watchfiles-0.15.0-cp37-abi3-manylinux_2_17_aarch64.manylinux2014_aarch64.whl  on the off-chance that worked, but it gave me a wrong ELF class: ELFCLASS32 error.
I also tried install 0.14.1 in case it was an issue with abi3, but it doesn't seem to be.

I cannot reproduce this with lima on M1 Pro Mac.
root@49fb5ab8d2ea:/# watchfiles watch /hello.py
[02:19:00] watchfiles 👀  path="/hello.py" target="watch" (command) filter=DefaultFilter...

Usage:
 watch [options] command

Options:
  -b, --beep             beep if command has a non-zero exit
  -c, --color            interpret ANSI color and style sequences
  -d, --differences[=<permanent>]
                         highlight changes between updates
  -e, --errexit          exit if command has a non-zero exit
  -g, --chgexit          exit when output from command changes
  -n, --interval <secs>  seconds to wait between updates
  -p, --precise          attempt run command in precise intervals
  -t, --no-title         turn off header
  -w, --no-wrap          turn off line wrapping
  -x, --exec             pass command to exec instead of "sh -c"

 -h, --help     display this help and exit
 -v, --version  output version information and exit

For more details see watch(1).
^C[02:19:03] KeyboardInterrupt caught, stopping watch
[02:19:03] process already dead, exit code: 1

I think I'll ask on notify and see if they have any ideas.

Partial fix / work around building now in #170.
Reported upstream, see https://github.com/notify-rs/notify/issues/423.

FYI, https://docs.docker.com/desktop/mac/apple-silicon/#known-issues

However, attempts to run Intel-based containers on Apple silicon machines under emulation can crash as qemu sometimes fails to run the container. In addition, filesystem change notification APIs (inotify) do not work under qemu emulation.

Okay, this is fixed in #172.
Please could those experiencing this problem @daniel-butler @br3ndonland @gravy-jones-locker try this and confirm it fixes the problem for you.
To install from wheel from the PR:

Download pypi_files from the CI run
Extract the zip
pip install pypi_files/watchfiles-0.0.0-cp37-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.whl

It is working for me when I use the updated wheel! Thank you for fixing!

Great, trunk you for confirming. I'll make a new release tomorrow.

v0.16.0 has just be released.

Nice! It works with 0.16.0 from PyPI, too.

missed the notifications for these. but the immediate issue is definitely fixed. thanks!


Linked full screen announcements

in CourseDashboardViewController

@aleffert pl review. Just a one line change to link both the screens

:+1:


credentialSchema is not shared with the verifier

When the presented BBS+ credential includes the credentialSchema property, It is not added to the presentation exchange record as expected.
Reproduction steps:

Add credentialSchema property to the credential with value:

"credentialSchema": {
    "id": "https://example.com/schema",
    "type": "JsonSchemaValidator2020",
}

Run demo agents:

./run_demo faber --did-exchange --cred-type json-ld --wallet-type askar
./run_demo alice --wallet-type askar

Issue credential and send proof request
Fetch v2 presentation exchange record on the verifier(Faber) agent
Observe that the presentation exchange record does not include the credentialSchema property but includes all others inside the ˙by_format.pres.dif.verifiableCredential˙ array.

@TimoGlastra I have discovered an issue with pyld normalize which is used to generate document_statements here:
https://github.com/hyperledger/aries-cloudagent-python/blob/fa749d249a38ab2e5df96d4992ea2ced542290a5/aries_cloudagent/vc/ld_proofs/suites/bbs_bls_signature_proof_2020.py#L97
For this credential (link), the document_statements generated by pyld is missing this:
<https://example.com/schema> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <https://json-ld.org/playground/JsonSchemaValidator2020> .

Due to this, the derived credential's credentialSchema is as following:
"credentialSchema": "https://example.com/schema"

Against expected
"credentialSchema": {
    "id": "https://example.com/schema",
    "type": "JsonSchemaValidator2020"
}

Hmm, haven't tested with credential schemas when writing this. @shaangill025 could you add test that reproduces this error?  That will make it easy for me to debug

@TimoGlastra This test reproduces the issue:
https://github.com/hyperledger/aries-cloudagent-python/blob/1f59a056bbf7a489fcefb25510a16832fc165ee5/aries_cloudagent/vc/ld_proofs/suites/tests/test_bbs_bls_signature_2020.py#L89

@TimoGlastra @shaangill025 Thank you for taking a look. Are there any updates regarding the issue?


no longer support bing translator

Hi, soimort
Kudos for this great app! But it no longer supports the bing translator. Can you please fix such problem?

Please update to the latest version (<IP_ADDRESS>).


Dependency version cleanup w/ Dependency Management

Addresses issue https://github.com/google/guice/issues/991

Thanks for this, however it's been quite a while since this was sent, and I think we're OK with things as they are now.


Add regenesis

TODO:

[x] Add the new OVM_L1CrossDomainMessenger
[x] Add the script to speed up the pending transactions

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@d940b26). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #237   +/-   ##
==========================================
  Coverage           ?   86.05%
==========================================
  Files              ?       49
  Lines              ?     1936
  Branches           ?      307
==========================================
  Hits               ?     1666
  Misses             ?      270
  Partials           ?        0

Flag
Coverage Δ

contracts
86.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d940b26...198cb28. Read the comment docs.


feat(sheets-ui): support canvas float dom

close #xxx

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

https://github.com/dream-num/univer/pull/2343#issuecomment-2137208048


use babel-node for server scripts

Makes eslint happy.
Also wrapped some stuff in an IIFE so that the errant return statement didn't cause eslint to barf.

Quote from babel docs regarding babel-node:

Not meant for production use
You should not be using babel-node in production. It is unnecessarily heavy, with high memory usage due to the cache being stored in memory. You will also always experience a startup performance penalty as the entire app needs to be compiled on the fly.

It's too confusing to use babel-node in dev and node in production, revert?

ahhhh... sorry, my bad.


Add V4+ features: DATE_TYPE and SMALLINT_AND_TINYINT_TYPES

This would be nice-to-have (though not essential) for the Spark connector.  The connector code necessarily checks the protocol version in several places when generating queries and thinking about schema.  These checks currently look like regular integer-primitive comparisons, which isn't ideal for readability.  Descriptively-named features are more readable, when available.
Following @adutra's  helpful preliminary comment, I split these features along OSS *C issue lines:

https://jira.apache.org/jira/browse/CASSANDRA-7523 - date type support
https://jira.apache.org/jira/browse/CASSANDRA-8951 - combined smallint & tinyint type support

This passed the coveo formatter enforcement and local testing (mvn -pl core test -Dtest=DefaultProtocolVersionRegistryTest).

Squashed and rebased on new 4.5.x branch: since this has very little impact, we're targeting our upcoming 4.5.1 patch release.


Upvote/Downvote responses in Sprig AI

Have the user be able to upvote/downvote Sprig AI answers, so we can collect and improve using that data. This is to combat hallucinations and other failure points we've been experiencing with the bot.

for doing this - we should have endpoints (/upvote and /downvote) that receive the AI conversation, the game code, and the specific response being upvoted/downvoted. @grymmy how do you propose we impl. this


License Header?

I noticed the license header says
/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
...
 */

I am not sure, if projects outside the apache.org namespace are allowed to use that?
Please clarify, we had somewhat similar situations when two forks or partial forks of Apache DeviceMap took place before or after it was archived by ASF, and in both cases, the license was still Apache 2, but the file headers needed to change.

Yes, I think you are right. I updated to:
/*
 * Licensed under the Apache License, Version 2.0 (the "License").
 * See the NOTICE file distributed with this work for additional
 * information regarding copyright ownership. You may not use this
 * file except in compliance with the License.
 * You may obtain a copy of the License at
...
 */

Does it sound better?


add missing bits to Header.Flags

Fixes #8

Thank you for this!  :)


Criteria (PASS/FAIL) for each inspection item in Prowler v2, v3

New feature motivation
Is there any data that summarizes the difference in inspection criteria between Prowler v3 and v2?
The more detailed it is, the better.
Where can I see the comparison data for each item?
Solution Proposed
the difference in inspection criteria between Prowler v3 and v2
Describe alternatives you've considered
The more detailed it is, the better.
Additional context
No response

Hi @kimdoyoung0430, unfortunately we don't have that comparison. Prowler v3 was a complete refactor in Python 3 to have a better, faster and reliable version.
Apart from that, if you have specific questions about changes you notice please ask us.
Also, refer to the public documentation at https://docs.prowler.cloud
Thanks for using Prowler 🚀

Hi @jfagoagas, I have further questions.
Let's assume that there is a check ID which is checkXXX for v2 and checkYYY for v3 and they are matched each other. Is it guaranteed that inspection criteria on v2 script and v3 python file are identical?
Since we already have made custom remediation guides based on Prowler v2, we want to know that the same guides could be used if we use Prowler v3 as long as a check ID is same on both versions.

Hi @Jaeyoon32 @kimdoyoung0430 was I able to solve the questions you had about the differences between Prowler v2 and v3?

Hi, @jfagoagas
I checked with Prowler docs document. However, when performing v2 and v3, it is necessary to verify the inspection results.

Thank you for your reply.


Create 0000-01-02-OdogwuSaina.md

I have created a branch, created a file and made a commit, and opened a pull request

Completed


Interpretation of memory derefencing with segment registers on x86-64

The best way is to illustrate it with a sample. Say this assembly code (using Windows 10, x64):

That first line MOV        RAX,qword ptr GS:[0x60] is getting a pointer to the _PEB structure (or, process environment block on Windows.)
Originally the source window translated it into this, which is unreadable:

So to correct it, I tried to do "Retype variable" for longlong in_GS_OFFSET; to change it to _PEB *:

But this made the following incorrect conversion of the source line:

If you look at the definition of the _PEB struct:

we have hProcessHeap at the offset 0x30.
Is this a bug?

local_GS_OFFSET should be a TIB* then adding the 0x60 offset will be the PEB* you are after.

Oh, I see. I got confused by that original weird type cast it did. So if I re-type that original longlong in_GS_OFFSET from longlong to _TEB64* it now works fine. Thank you,


AMBARI-24833. Extend cloud log rolling options

What changes were proposed in this pull request?
Extend rolling options:

add size format
add default rolling strategy

How was this patch tested?
Waiting for UTs

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/48/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/50/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/51/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-LogSearch-Github-PR-Builder/52/
Test PASSed.


RoomList bugs

[ ] If same person is visible and invisible, the name isn't shown in participants list
[ ] Missing space after icon in name list tooltips

I think the first bug is non-deterministic and depends on which presence joined first.


Feat/eps controller/integration

Intention
A description of the changes contained in the PR.
Implementation
What decisions were made to implemenent the above
Tests
What test cases are included
Discussion
A place to ask questions of reviewers, clarify any uncertenties

closing, will re-implement when EPS slice is returned to


[image_picker] Pick Image Method Alllows User To Pick Multi Images

Hello,
I use these lines to pick an image from gallery:
final ImagePicker _picker = ImagePicker();
final XFile? image = await _picker.pickImage(source: ImageSource.gallery);
But in some iOS devices it works like "pickMultiImage". This means, it and allow users to select more than 1 image from gallery, and it causes a crash on return.
How can i fix this?

Hello @oorfalimak. Thank you for filing this issue. Can you please provide the following information?

A complete and minimal, reproducible example. Ideally, a single main.dart file that can be run directly.
Plugin and OS version information
The output of flutter doctor -v
The output of flutter run -v

Please provide the information in the form of text. See how to make collapsible sections with Markdown here.

Thanks for the reply.
The code is:

  XFile? image;
  final ImagePicker _picker = ImagePicker();
  image = await _picker.pickImage(
        source: ImageSource.camera,
        imageQuality: 90,
        maxHeight: 1024,
        maxWidth: 1024,
      );

Flutter doctor output:

[✓] Flutter (Channel stable, 3.3.10, on macOS 13.0.1 22A400 darwin-x64, locale en-TR)
    • Flutter version 3.3.10 on channel stable at /Users/ozanorfa/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (2 weeks ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0-rc5)
• Android SDK at /Users/ozanorfa/Library/Android/sdk
• Platform android-33, build-tools 31.0.0-rc5
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14C18
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
[✓] IntelliJ IDEA Community Edition (version 2022.2)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.74.2)
• VS Code at /Users/ozanorfa/Desktop/Visual Studio Code.app/Contents
• Flutter extension version 3.56.0
[✓] Connected device (3 available)
• SM A235F (mobile) • R68TB01G4HT • android-arm64  • Android 13 (API 33)
• macOS (desktop)   • macos       • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
• Chrome (web)      • chrome      • web-javascript • Google Chrome 108.0.5359.124
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

The run code outout:

Launching lib/main.dart on SM A235F in debug mode...
lib/main.dart:1
✓  Built build/app/outputs/flutter-apk/app-prod-debug.apk.
D/FlutterLocationService(14368): Creating service.
D/FlutterLocationService(14368): Binding to location service.
I/app(14368): Compiler allocated 6075KB to compile void android.view.ViewRootImpl.performTraversals()
Connecting to VM Service at ws://<IP_ADDRESS>:62256/94y0CEFLkxQ=/ws

Best regards.

Please provide a complete code sample that can be run directly, including main()


Title: Fix Bugs, Enhance Compatibility, and Improve Defaults in Pull Request

This pull request addresses the following changes:

Fixed a bug where the interface would throw an error when the input request parameter was in the format of List.
Changed the default HOST from localhost to <IP_ADDRESS> to allow external access.
Modified the default value of NORMALIZE_EMBEDDINGS to True.
Fixed an issue where the HuggingFaceBgeEmbeddings couldn't be called when loading a local model.
When no model name is provided, it now defaults to the model defined in DEFAULT_MODEL_NAME.
Added attributes to the returned class to maintain consistency with the OpenAI format.
Added the dependency "uvicorn" for service startup.
Improved Python version compatibility (tested with Python 3.8 to Python 3.10) by switching methods between **request.model_dump and **request.dict based on the differences in pydantic versions.

Please review and merge this pull request at your earliest convenience. Thank you!

Thanks for sending the PR. I will take the time to review and test it out. Please don't force push changes to main branch.

Thanks for sending the PR. I will take the time to review and test it out. Please don't force push changes to main branch.

Thanks for review .
Sorry about force push ,  I submitted the wrong code ,so used force push to overwrite my own wrong code.

I will merge the changes except the commit of fix List Post Error


Make car speed parser bad surfaces consistent with surface encoded value

In OSMSurfaceParser we map sett and unhewn_cobblestone to COBBLESTONE, earth to DIRT, pebblestone to GRAVEL (!) and grass_paver to GRASS.
I think we need to extend the badSurfaceMap in CarAverageSpeedParser accordingly to make this consistent.

There is another inconsistency: In OSMSurfaceParser we ignore everything that is written after a colon in the surface value:
https://github.com/graphhopper/graphhopper/blob/881a04c761a141860a72aaf4fe9c56081062e8bd/core/src/main/java/com/graphhopper/routing/ev/Surface.java#L68-L71
But in CarAverageSpeedParser we don't. For example cobblestone:flattened will be treated like cobblestone by OSMSurfaceParser, but CarAverageSpeedParser only considers cobblestone a bad surface, and not cobblestone:flattened (because we only add cobblestone to the badSurfaceMap).


get button by id

Fix Cypress tests by getting button by id

Catherine has demo'd and this is approved from a test perspective


fix fix bad case in s3 tvf load test

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Concerned with major version (breaking) releases in rapid succession

Is your feature request related to a problem? Please describe.
Good morning. :) Just a friendly note from an engineer to other engineers:

Major version 3 was released 10 days ago.
Major version 4 was released 7 days ago.
Major version 5 was released 16 hours ago.
Major version 6 was also released 16 hours ago.

From the Semantic Versioning specification:

If even the tiniest backwards incompatible changes to the public API require a major version bump, won’t I end up at version 42.0.0 very rapidly?
This is a question of responsible development and foresight. Incompatible changes should not be introduced lightly to software that has a lot of dependent code. The cost that must be incurred to upgrade can be significant. Having to bump major versions to release incompatible changes means you’ll think through the impact of your changes, and evaluate the cost/benefit ratio involved.

Describe the solution you'd like
Bundle-up breaking changes into a single release so that upgrading users only get broken once instead of several times. It might be helpful to release pre-release RCs first so that people can test changes and provide feedback before cutting an official release.
Ideally:

There would be more rigor in the automated testing to catch things like the basic authentication flip-flops.
Deeper functionality would be tested. (For example: not just generating Access Tokens, but also testing that the access token can do what it's intended to do.)
Multiple versions would be tested (perhaps by spinning-up multiple clusters with Terraform and base system images via whatever CI system you use). [I suggested this in a different ticket.]

If the ideal state can't be reached in the relative near-term, then at least planned breaking changes should be bundled together into a single release so that customers are only broken once in a general timeframe rather than several times in quick succession.
Is it a resources issue? As an enterprise customer, is there anything that I can do to apply pressure to the company at a higher level to ensure that adequate testing systems/infrastructure are available for this project?
Describe alternatives you've considered
None.
Additional context
Again, thank you for your work on this software.

Hey there @skyzyx - We were very congnizent of releasing breaking changes and how fast we were going and I'll give some guidance on what we're trying

We intentionally created numerous major releases so that users could pick-and-choose versions, in case they weren't ready. For example, removing all the legacy repos is something that some teams might not be ready for and some have no problem. Teams that aren't ready can stay on that version as long as is needed.
We made the major version changes fully understanding that we might need to monkey patch in features from a different release.

The release cycle is was very intentional because we had so many backlogged breaking changes and we knew we might be asked to create x.y.z y releases on any given major version.
We (me personally) value your input and opinion. I mean, our more rigorous documentation and semver release is specifically because of your suggestions.
As for your quote from semver: I wouldn't worry about 42.0.0 release. We have no new major version releases in our pipeline. So, you can expect 6.x.x to be the major version for the long future.
If there is a specific test or automation you think we should implement, we'll consider it (for example, you requested that we list the Artifactory version we tested against (and even here, usage of the word Artifactory instead of RT is your suggestion), and a ticket has been cut and will be worked on soon)
There really isn't anyone you can lean on that you haven't already. Myself and @alexhung are your best resources for changes in any of our providers, and any changes you need in Artifactory your only recourse is a support ticket. We have absolutely no extra juice
sidenote: We are working to get a newsletter setup so we can proactively announce changes before release and give our users a chance to speak up.
Thanks again for your input, and if you wanna show your love, get your friends to give this repo (and our other ones) stars

@chb0github

Thanks for the explanation. While unusual, the explanation at least makes sense. I appreciate it.


Lens metrics not showing after k8s migration

Describe the bug
Problem: Lens metrics not showing after k8s migration
Context:
I have recently migrated master node from on-prem to EC2 by using old master's etcd snapshot following below tutorial on RKE2.

Restoring a Snapshot to New Nodes

Seems like the overall cluster information is migrated & restored properly, however Lens Metrics are not showing!
I have tried followings

Disabling & Enabling prometheus Extensions - Lens Metrics - PROMETHEUS
Installing kube-prometheus-stack manually via helm chart

Please let me know how I can debug & fix this issue!
Thanks in advance!
To Reproduce
Steps to reproduce the behavior:
Migrate K8s master node using etcd snapshot & see metrics on Lens UI
Expected behavior
Metrics should appear
Screenshots

Environment (please complete the following information):

Lens Version:
Lens: 5.4.6-latest.20220428.1

OS: [e.g. OSX]
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.4 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Installation method (e.g. snap or AppImage in Linux):
Lens desktop

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Your logs go here...

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: *******
    server: https://<IP_ADDRESS>:6443
  name: default
contexts:
- context:
    cluster: default
    user: default
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: default
  user:
    client-certificate-data: *******
    client-key-data: *******

Additional context
Add any other context about the problem here.

Might be related: In a v1.23.6+k3s1 cluster I cannot install Lens metrics. It just says "Lens Metrics settings requires established connection to the cluster." despite being connected to the cluster.

Were you using the lens metrics before the migration or were you using the helm prometheus stack?

Applying https://github.com/lensapp/lens/blob/master/troubleshooting/custom-prometheus.md solved issue!

Were you using the lens metrics before the migration or were you using the helm prometheus stack?

Sorry, @Nokel81, I didn't get notified of your reply. I wasn't using Prometheus. I was using Lens metrics prior. Also, I tried with a fresh cluster and it didn't work. Originally k3s, then k0s.


mean_probe_position incorrect

Right now you are calculating the position of the cluster as:
mean ( masks * probe.positions )
But it should be:
sum ( masks * probe.positions ) / sum(masks)
[that's just the formula for center of mass]
Here's a specific line that computes it for each spike individually; you can probably use it directly if masks is the same size? I'm not sure.
masks = view.model.masks[...]
x = np.sum(masks*view.model.probe.positions[:,1],axis=1)/np.sum(masks,axis=1)

do you feel like trying to do a pull request and become an actual phy contributor? :) Max or I can show you how do to it

Ok! Will do it with max today.
On Jun 29, 2015 11:00 AM, "Cyrille Rossant"<EMAIL_ADDRESS>wrote:

do you feel like trying to do a pull request and become an actual phy
contributor? :) Max or I can show you how do to it
—
Reply to this email directly or view it on GitHub
https://github.com/kwikteam/phy/issues/440#issuecomment-116590013.


Update readme

Same changes made in https://github.com/hmrc/uknw-auth-checker-api/pull/62#pullrequestreview-2271661743


Check for clobber issues within a single catalog

There is code that checks for multiple windows_env instances with
clobber enabled on the same variable. This check makes use of the
instance variable @mergemode, which gets the entire contents of the
previously instantiated resource.
This was causing issues in the case where Puppet restarts mid-way
through its run to account for agent-specified environment conflicts.
When Puppet does this, it does not clear, or re-instantiate, its
types. This caused all instance variables to stick around for the next
run.
The check was looking at the instance variable that it already made;
which was technically coming from a different catalog (a different,
albeit stunted, Puppet run).
This commit fixes the issue by adding some logic that checks to see that
we are only validating for duplicate clobber within the same catalog.
Ideally, this fix shouldn't be needed because Puppet should
re-instantiate its types when it restarts a Puppet run.

this pull request replaces #17


feat(notes): add marked options

Issue:
Hi all,
I don't think there where any way to enable code syntax highlight when using withMarkdownNotes using it like that:
storiesOf('Notes', module).add( 'Markdown Highlight', withMarkdownNotes(`
~~~javascript
const test = () => 'this is highlighted';
let foo = 'bar';
~~~`)(() => {
      return {
        component: MyComponent,
        props: { }
      }
    })
  )

So we currently have something like this:

I haven't found any PR or Issue addressing this issue except maybe this closed one: https://github.com/storybooks/storybook/issues/951
What I did
I came up with the following solution that  solves this issue while allowing backward-compatibility.
 - export const withMarkdownNotes = (text) => {
 + export const withMarkdownNotes = (text, options) => {
     const channel = addons.getChannel();
     return getStory => context => {
 +     marked.setOptions({ ...marked.defaults, options });
       // send the notes to the channel before the story is rendered
       channel.emit('storybook/notes/add_notes', marked(text));
       return getStory(context);
     };
   };

changing above code snippet to this: (I'm using Prism but that's only a personnal preference)
storiesOf('Notes', module).add( 'Markdown Highlight', withMarkdownNotes(`
~~~javascript
const test = () => 'this is highlighted';
let foo = 'bar';
~~~`,
     { highlight: (code, lang) => Prism.highlight(code, Prism.languages[lang], lang) }
)(() => {
      return {
        component: MyComponent,
        props: { }
      }
    })
  )

You should now be able (with a bit of css, i.e. a prism theme) to obtain this:

If you think this need some testing I'll gladly add them or if there is anything that I missed feel free to tell me.

@aymeric-duchein how do you pass the prism theme (css) to the notes panel?

@aymeric-duchein here is  what i tried
details using 4.0.0-alpha.16 of notes with angular
{
    notes: {
      markdown: buttonMarkdown,
      markdownOptions: {
        highlight: function (code, lang) {
          return Prism.highlight(code, Prism.languages[lang], lang);
        }
      }
    }
  }

but i dont see Prism tokenizing my input.
currently using a work around as follows
added the following css ref in manager-head.hml
<link rel="stylesheet" href="assets/prismjs/themes/prism.css">

 //helper.js
import marked from "marked";
import Prism from "prismjs";

const mdToHTML = (md) => {
  marked.setOptions({
    ...marked.defaults,
    highlight: function (code, lang) {
      return Prism.highlight(code, Prism.languages[lang], lang);
    }
  });
  const HTML = marked(md);
  return HTML;
};

export default mdToHTML;

//some where inside index.stories.ts

import mdToHTML from "./helper/mdToHTML";
import * as buttonMarkdown from "./button.md";

//.....
 notes: {
      text: mdToHTML(buttonMarkdown)
}

the above one works but i lose  code formatting

It seems that the code changed a lot since the last time I used storybook. From what I can gather maybe @tmeasday could help you on this one.

@anoopsinghbayes that code looks like it should work:
https://github.com/storybooks/storybook/blob/93745d706710e9e45b8cb8ddec4c6e773e181a41/addons/notes/src/index.js#L19
I'm not sure exactly why it not work -- perhaps we should add an example to the official storybook that uses the option?

Although, shouldn't it be {...marked.defaults, ...options} or even just marked(markdown, options)?
I haven't tested this directly, I just converted the old code. @anoopsinghbayes if you wanted to send a PR with an example it would be awesome. I bet you'd be able to fix the issue too, the code isn't too complicated! Let me know I can help.

@tmeasday ,I was struggling to get the storybook application setup(proxy and other yarn related issues)
now that it is fixed ,i can send a PR,
i am trying to add a test for this but i dont know how to run the test for addons\notes :-(

Oh! Sure, the best way is to just run the storybook and take a look. You can do (from the top-level of the project):
yarn
yarn bootstrap --core
cd examples/official-storybook
yarn storybook

and then browse to the official storybook (I think it's http://localhost:9011), and look at the addon/notes stories within it. The files for those stories are here: https://github.com/storybooks/storybook/blob/master/examples/official-storybook/stories/addon-notes.stories.js

@anoopsinghbayes, Are you going to create a PR for that?
@tmeasday to my mind it would be awesome to have code highlighting out-of-the-box in addon-notes, what do you think about it?

I think it'd be great!


Windows Terminal breaks remapped key by windows powertoys

Windows Terminal version
1.11.2921.0
Windows build number
22000.318
Other Software
Powertoys v0.49.1
Steps to reproduce
I have remapped capslock to esc and vice versa.
By simply opening Windows terminal the remapped keys stopped working and start showing their actual behavior.
Expected Behavior
Remapped keys should work.
CapsLock as esc and vice versa
Actual Behavior
Remapped mapped doesn't work, instead their actual behavior is shown.

Installing and changing the font to MesloLGM Nerd Font, corrected the issue.
Using any other font didn't work, so for now the issue is solved, so I'm closing it.

I don't know what's happening, but sometimes the remapped keys start working, and other time don't.

That's weird. I don't think the Terminal should be messing with that at all.
When you say:

By simply opening Windows terminal the remapped keys stopped working and start showing their actual behavior.

Do you mean the key stops being remapped for the Terminal, or for all applications?
@crutkas any ideas what's going on here?

Do you mean the key stops being remapped for the Terminal, or for all applications?

I meant, as long as the focus is on the terminal window, it doesn't work, when I change the focus to something else or open another program, it starts working

When I said, sometimes remapped keys starts >working and sometimes don't.

I also meant inside WT, as everywhere else remapping totally works fine.

is terminal run as admin and Powertoys isn't?

is terminal run as admin and Powertoys isn't?

You're right, found the exact reason, it only happens when WT is running as an admin but PowerToys isn't.
Running PowerToys always in an admin mode solved the problem.
So, closing the issue. Thanks a lot @crutkas.

While we can detect this, it is hard.  FancyZones is able to since you interact with the window.  Keyboard manager is a bit harder to catch this.


Split magnet set object

First crack at the class hierarchy disussed a couple weeks back - not sure the best way to handle things that you might want to be part of the init method for both classes? I just left those variables (like logger) in the init for each class. This felt a bit like defining things in two places.

tests are passing locally :(


Add Char.toInt with tests

Adds Char.toInt which seems like it should be there based on what's in the other classes. I discovered there's no easy way to map a Char such as '1' to the Int 1. You'd think '1' |> toString |> String.toInt would do it but toString '1' returns "'1'"!
I can't find an easy way to convert a Char to a String at all. I thought about adding a method for that, but I wouldn't know what to call it, since toString is taken.

About getting from Char to Int: Isn't that what Char.toCode is for? (Or at the very least, you could implement your Char.toInt in Elm by using the existing Char.toCode without doing any native stuff as you do in your pull request.)
About getting from a Char to a String: It seems you have overlooked the existence of String.fromChar.

I'm closing this issue.
@bradurani, if you want to propose addition of Char.toInt, please:

Do so via a pull request to https://github.com/zeckalpha/char-extra. This is the current standard practice of suggesting completely new stuff (rather than fixing existing stuff) for core: collecting it into *-extra libraries first.
Try doing it without using native stuff. The existing Char.toCode should enable you to implement Char.toInt in pure Elm.

Concerning "Char.toString", see my previous comment.

Makes since. I'm getting the hang of all this. Thanks for explaining @jvoigtlaender


Login(username, password) returns no error but IsLoggedIn() returns false

I'm having this issue since yesterday. After calling err := scrapper.Login(username, password), I see err is nil. But then when I check scrapper.IsLoggedIn() it returns false.
I have tried to call scraper.ClearCookies() just before the login attempt, just in case it was a problem with older cookies. But that doesn't solve it, nor running the program from scratch.

I think it was an issue with https://api.twitter.com/1.1/account/verify_credentials.json on Twitter's side. It fixed itself after some hours. I'll close this ticket for now and reopen it if it happens again.

The problem is back. This is the response the library gets from https://api.twitter.com/1.1/account/verify_credentials.json, in case it helps:
response status 403 Forbidden: {"errors":[{"message":"Your credentials do not allow access to this resource","code":37}]}

@ealmuina
I experience similar issue. with api.twitter.com it returns 404 error. with x.com it returns the same error as yours

As I mitigation, for now I'm running fine by just skipping the call to scrapper.IsLoggedIn() and simply checking if scrapper.Login(username, password) doesn't return any error.

the problem is back. This is the response the library gets from https://api.twitter.com/1.1/account/verify_credentials.json, in case it helps:

My response:
Login failed: response status 404 Not Found: {"errors":[{"message":"Sorry, that page does not exist","code":34}]}

I found why it failed.
We need x-client-transaction-id as well in each API request. it's different in each request. any idea how to generate it?

I've been playing around using shell scripts to make it easier for me to quickly understand what is and isn't needed. This seems to still work for me today:
https://github.com/cmj/twitter-tools/blob/4a2743351ad83ec7de817ad2ac36575cd19fda88/twitter-cookie.sh#L32-L33
Just a user-generated 94 character string works in this example. I'm not entirely sure this is the solution, but worth a try.

The bearerToken needs to be changed. Something like this should work...
https://gist.github.com/cmj/8ada29ebbf202b971e7336df9dc1e81d

that worked! changing the bearer token to:
AAAAAAAAAAAAAAAAAAAAAG5LOQEAAAAAbEKsIYYIhrfOQqm4H8u7xcahRkU%3Dz98HKmzbeXdKqBfUDmElcqYl0cmmKY9KdS2UoNIz3Phapgsowi

Allows sending requests without x-client-transaction-id

There seems to be a rate-limit issue with that bearer token. The one in the patch I shared is limited at 75.
We need to use this token which has an x-rate-limit-limit: 2000
"AAAAAAAAAAAAAAAAAAAAAFQODgEAAAAAVHTp76lzh3rFzcHbmHVvQxYYpTw%3DckAlMINMjmCwxUcaXbAN4XqJVdgMJaHqNOFgPMK0zN1qLqLQCF"
Sorry for not checking this first.


Adding a new workbook on Log4j hunting

Change(s):
Azure-Sentinel/Workbooks/Log4jPostCompromiseHunting - A new workbook added with the following tabs
FindTrace - A lookup to curated IOCs across all sentinel tables.
SecurityNestedRecommendation - This section uses the Azure Defender Security Nested Recommendations data to find
machines vulnerable to log4j CVE-2021-44228. Log4j is an open-source Apache logging library that is used in many Java-
based applications. Security Nested Recommendations data is sent to Microsoft Sentinel using the continuous export
feature of Azure Defender
AzureDiagnostics - Azure Diagnostics
MultipleDataSources - Across multiple data sources
Syslog - From Syslog Sources
Azure-Sentinel/Workbooks/WorkbooksMetadata.json - To add workbook metadata.
Azure-Sentinel/Workbooks/Images/Logos - To add workbook logo.
Azure-Sentinel/Workbooks/Images/Preview - To add preview images.

@samikroy : I think you missed to add workbook.json here, can you please add it... Thanks!!

@v-rucdu & @v-rucdu - Thank you for highlighting this.
Have added the files as requested.
Please let me know for further changes.

@samikroy : I think you missed to add workbook.json here, can you please add it... Thanks!!

@v-rucdu & @v-jayakal - Thank you for highlighting this. Have added the files as requested. Please let me know for further changes.

@samikroy : You have added the workbook.json under Images folder, can you please delete and add it under Workbooks folder... and in solutions WorkbookMetadata.json is not required... please delete it... thanks!!!

@samikroy : I think you missed to add workbook.json here, can you please add it... Thanks!!

@v-rucdu & @v-jayakal - Thank you for highlighting this. Have added the files as requested. Please let me know for further changes.

@samikroy : You have added the workbook.json under Workbooks-->Images folder, can you please delete and add it under Workbooks folder... and in solutions WorkbookMetadata.json is not required... please delete it... thanks!!!

Done.

Thank you @v-rucdu for the approval & merge.


The executable does not have the hardened runtime enabled

Hi,
I am trying to bundle osquery-extension and osquery, and in the notarization process I am getting the following error  from Apple.
Error is related to extension extracted from Release binary.
The executable does not have the hardened runtime enabled

Could you advice how to fix this problem ?

Notarization is not required for enterprise deployment methods (such as munki).


SPF record for email marketing

May I know whether it's necessary to create SPF record for email marketing now?
If no, why we still have this section?

If yes, why this doc is deleted.
https://github.com/MicrosoftDocs/dynamics-365-customer-engagement/blob/fa212737c3fc76584e98d724788a7c2e61461382/ce/marketing/create-spf-record.md

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71706c5b-48b9-a172-d3e9-84c6d2479b90
Version Independent ID: 7e2a27d9-d8d6-6375-7ae7-6c7465e83d39
Content: Maximise email deliverability (Dynamics 365 Marketing)
Content Source: ce/marketing/get-ready-email-marketing.md
Service: dynamics-365-marketing
GitHub Login: @alfergus
Microsoft Alias: alfergus

Thanks for your comment, @iChrisJ. This issue has been assigned to the doc author for review.

Thanks for the question! If the Envelope From address feature is enabled and confirmed, all emails will be signed with SPF on the sender domain. There is no need to add any additional DNS records to the existing SPF record.
I'll update this doc to remove outdated info.

@iChrisJ You can learn about the Envelope From setup here: https://docs.microsoft.com/en-us/dynamics365/marketing/mkt-settings-authenticate-domains#envelope-from-domain


TinyCLIP HuggingFace integration

Hi team,
I am integrating and comparing the brilliant set of TinyCLIP (ViT-based) architectures with the vanilla CLIP model in a number of language-enabled action recognition frameworks. Some of these AR models rely on HF model configurations, are there plans to release the TinyCLIP family to HF? Thanks!

Hi @FransHk , thanks for your attention to our work!
Were you referring to integrating TinyCLIP into Hugging Face, like this example?
https://huggingface.co/openai/clip-vit-large-patch14

Hi, thanks for your reply. You are right. I am looking to export a TinyCLIP model in the HuggingFace 'ClipConfig' format so that I can load it into an existing codebase that expects this format.
For example, the code I am integrating TinyCLIP in loads vanilla CLIP like so:
from transformers import CLIPModel, CLIPConfig
configuration = CLIPConfig().from_pretrained(pretrained_model)
clip_model = CLIPModel.from_pretrained(pretrained_model, config=configuration)

The model that integrates CLIP for AR tasks is completely built around the HF-formatted CLIP, that's why I'm asking instead of re-implementing it for the open clip framework. Does this answer your question?

I see. Thanks @FransHk !
I am trying to integrate TinyCLIP into HF.
I rarely use transformers, and I have encountered issues with CLIPConfig, so it will take some time to integrate TinyCLIP :)

Thank you @wkcn, looking forward to the results!

Hi @FransHk, I have integrated some TinyCLIP-ViT models into HF.
https://huggingface.co/collections/wkcn/tinyclip-model-zoo-6581aa105311fe07be88cb0d

@wkcn Could you guide me how to convert "open_clip TinyCLIP.pt" model to "HF TinyCLIP" ?
I found order of transformer layers are changed and some parameters are missing.

Hi @becxer , I used the script (https://github.com/huggingface/transformers/blob/main/src/transformers/models/clip/convert_clip_original_pytorch_to_hf.py) to convert the model.
The number of layers in config.json should be changed like https://huggingface.co/wkcn/TinyCLIP-ViT-8M-16-Text-3M-YFCC15M/blob/main/config.json#L138.

Hi @becxer , I used the script (https://github.com/huggingface/transformers/blob/main/src/transformers/models/clip/convert_clip_original_pytorch_to_hf.py) to convert the model.
The number of layers in config.json should be changed like https://huggingface.co/wkcn/TinyCLIP-ViT-8M-16-Text-3M-YFCC15M/blob/main/config.json#L138.

Appreciates for the quick response!
So did you mean that the following PT model can be converted into the following HF model using the mentions script without additional training?
PT : https://github.com/wkcn/TinyCLIP-model-zoo/releases/download/checkpoints/TinyCLIP-ViT-40M-32-Text-19M-LAION400M.pt
HF : https://huggingface.co/wkcn/TinyCLIP-ViT-40M-32-Text-19M-LAION400M

@becxer Yes. The conversion does not need additional training.


add UI support for {required,forbidden}UnlessAnyOf, and simplify constraint messages

LGTM, thanks @ahgittin 👍
One question though, do we have support on the server for {required,forbidden}UnlessAnyOf? I didn't see those before? Could you point me to this code?

https://github.com/apache/brooklyn-server/pull/1008

Ah cool, thanks @ahgittin. Merging now


Refactor code in Draw component

Create a separation in the Draw component where users can

Create a canvas component that has no color picker / brush properties

This would be amazing!

Just laying out the details:

@benjeau/react-native-draw would only contain the renderer/canvas
@benjeau/react-native-draw-extras would contain everything else (bottom section - color picker, brush properties, undo, delete)

Both of these dependencies will be in this repo - although I am unsure how to push to two separate npm packages with react-native-bob. I'm not sure when I'll do this, but I really want this do this since I already have the Skia renderer done and want to merge it with this code so bad, but I can't as of now


Improve camera overlays settings for telemax.wbt

I would maybe reduce the default size of the telemax camera overlays, because when running Webots on a 15.6'' screen the 3D and the robot itself are not visible.

Similar issue with the robotis op3 guided tour world: the camera overlays is over the robot head.

The robotis op3 worlds has to be improved as well if possible.


I would like to display initial data to OHLCTooltip

Thanks for your great Component .
OHLCTooltip initial data : "Date: n/a O: n/a H: n/a L: n/a C: n/a V: n/a"
I would like to display the last value as the initial value of OHLCTooltip.

Any help? I want the same feature to display default data instead of n/a.


Crash report on flutter run

First time using flutter run on brand new app after installing on Ubuntu 18.04.  See attached log.
flutter_01.log

Hey @steowens , please try installing the Android SDK. flutter doctor also crashed

@steowens what sort of device were you attempting to run with?

It was an HP laptop.

I have kind of given up using this software so I probably won't be watching this thread.  Perhaps I will pick it up sometime in the future.

OK. If you're able to file a more complete bug report in the future please do


As a User I want to be able to access the website

Frontend

[x] Deploy website: gh-pages?

Backend

[ ] Deploy backend
[ ] Deploy DB

Deployed! https://meta-dog.github.io/meta-dog/ 🚀


test: repeated volume rebuilds should succeed

Added two rebuild tests which are ignored as they're meant to aid in testing io-engine rebuilds.
Example running with custom io-engine:
export IO_ENGINE_BIN=/home/tiago/git/mayastor/io-engine/target/debug/io-engine
cargo test -p io-engine-tests repeated_volume_double_rebuilds -- --ignored
Signed-off-by: Tiago Castro<EMAIL_ADDRESS>

bors merge


[fix warning] Warning: Failed prop type: Invalid prop bsSize of value md

Codecov Report

Merging #6293 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6293   +/-   ##
=======================================
  Coverage   77.01%   77.01%
=======================================
  Files          64       64
  Lines        9508     9508
=======================================
  Hits         7323     7323
  Misses       2185     2185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e8df4...1ae303f. Read the comment docs.

Does it fallback to sm or `lg?

It's just medium if you don't specify it. This just removed the warning.

👍


update tor browser alpha

Fixes #451 for me as well.

Thank you !!!!!
On Wed, Dec 12, 2018 at 02:28 Christian Koep<EMAIL_ADDRESS>wrote:

Merged #452 https://github.com/jessfraz/dockerfiles/pull/452 into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jessfraz/dockerfiles/pull/452#event-2020722505, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYNbICljGx6jrxstZwEaQBCNFAf3v48ks5u4LAQgaJpZM4ZO3nm
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3


(PUP-7117) New acceptance test: utf-8 characters in file resource

This PR adds a new accecptance test to verify correct behavior of
file resources when they include utf-8 characters.

CLA signed by all contributors.