v0.4.0: with LLD support

See commit messages for details about why this is a breaking change.
I personally think no longer requiring GNU LD / arm-none-eabi-binutils to build a Rust program is worth the breaking change.
So far this seems to work fine but I'll continue to test this locally.
This depends on rust-lang/rust#49728

Dropping stack overflow protection is kind of unfortunate but given that it required the custom linking step maybe it's good that it's gone. I think that a proper solution can be much more easily developed for lld than binutils, especially given that rustc ships a fork of lld now.

I just tested this with my microbit crate. Works fine with both arm-none-eabi-binutils and lld. Flash image size is identical, disk size with debugging symbols went down a bit and surprisingly lld produces slightly larger files on disk than GNU ld but that's nothing to worry about.

@whitequark

I think that a proper solution can be much more easily developed for lld than binutils, especially given that rustc ships a fork of lld now.

I think it's very unlikely that the Rust team will add features to rust fork of lld. They try to keep as few patches (that are not backports) as possible on top of upstream LLVM / LLD. I do agree that a LLD (linker script?) solution would be the ideal solution here.

As we are making a new version release I'm also removing the panic_fmt lang item and the abort-on-panic feature. rust-lang/rust#47074 has been fixed and #[panic_implementation] is around the corner so it seems a good time to remove them. Without them the user is expected to specify the panic behavior; they can do so using #[panic_implementation] or by depending on a panic crate.

I think it's very unlikely that the Rust team will add features to rust fork of lld. They try to keep as few patches (that are not backports) as possible on top of upstream LLVM / LLD. I do agree that a LLD (linker script?) solution would be the ideal solution here.

I mean that the features can be added upstream and then pulled to the rust fork of lld to avoid waiting for an LLVM release cycle, of course.

Alright, let's land this to get more real world testing.


[BUG] Too many aliases for a single line in hosts file (Windows)

General information

OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes
Running CRC on: Laptop

CRC version
CodeReady Containers version: 1.31.2+19538dab
OpenShift version: 4.8.4 (not embedded in executable)

CRC status
DEBU CodeReady Containers version: 1.31.2+19538dab
DEBU OpenShift version: 4.8.4 (not embedded in executable)
DEBU Running 'crc status'
DEBU Checking file: C:\Users\user\.crc\machines\crc\.crc-exist
DEBU Checking file: C:\Users\user\.crc\machines\crc\.crc-exist
DEBU Running '( Hyper-V\Get-VM crc ).state'
DEBU Running SSH command: df -B1 --output=size,used,target /sysroot | tail -1
DEBU Using ssh private keys: [C:\Users\user\.crc\machines\crc\id_ecdsa C:\Users\user\.crc\cache\crc_hyperv_4.8.4\id_ecdsa_crc]
DEBU SSH command results: err: <nil>, output:<PHONE_NUMBER>6<PHONE_NUMBER>8 /sysroot
CRC VM:          Running
OpenShift:       Running (v4.8.4)
Disk Usage:      14.66GB of 32.74GB (Inside the CRC VM)
Cache Usage:     14.38GB
Cache Directory: C:\Users\user\.crc\cache

CRC config
- consent-telemetry                     : no
- memory                                : 20480

Host Operating System
OS Name:                   Microsoft Windows 10 Enterprise
OS Version:                10.0.19042 N/A Build 19042
OS Manufacturer:           Microsoft Corporation
OS Configuration:          Member Workstation
OS Build Type:             Multiprocessor Free

Steps to reproduce

crc start
type c:\windows\system32\drivers\etc\hosts

Expected
At most 9 aliases per ip per line. Preferably one line per alias
<IP_ADDRESS> myhost
<IP_ADDRESS> prometheus-istio-system.apps-crc.testing
<IP_ADDRESS> istio-ingressgateway-istio-system.apps-crc.testing
<IP_ADDRESS> grafana-istio-system.apps-crc.testing
<IP_ADDRESS> jaeger-istio-system.apps-crc.testing
<IP_ADDRESS> kiali-istio-system.apps-crc.testing
<IP_ADDRESS> api.crc.testing canary-openshift-ingress-canary.apps-crc.testing
<IP_ADDRESS> console-openshift-console.apps-crc.testing
<IP_ADDRESS> default-route-openshift-image-registry.apps-crc.testing
<IP_ADDRESS> downloads-openshift-console.apps-crc.testing
<IP_ADDRESS> oauth-openshift.apps-crc.testing

I'm not sure if it's Windows or some 3rd party component (vpn, 3rd party firewall) that adds limit of 9 entries per line, but current single line approach isn't just working. Limit of 9 came from experimenting behavior (User has had similar experience here: https://superuser.com/questions/932112/is-there-a-maximum-number-of-hostname-aliases-per-line-in-a-windows-hosts-file )
Actual
All aliases are on single line:
<IP_ADDRESS> myhost prometheus-istio-system.apps-crc.testing istio-ingressgateway-istio-system.apps-crc.testing grafana-istio-system.apps-crc.testing jaeger-istio-system.apps-crc.testing kiali-istio-system.apps-crc.testing api.crc.testing canary-openshift-ingress-canary.apps-crc.testing console-openshift-console.apps-crc.testing default-route-openshift-image-registry.apps-crc.testing downloads-openshift-console.apps-crc.testing oauth-openshift.apps-crc.testing

Logs
Cannot update kubeconfig: Head "https://oauth-openshift.apps-crc.testing": dial tcp: lookup oauth-openshift.apps-crc.testing: no such host

The hostsfile module we are using has code for this https://github.com/goodhosts/hostsfile/commit/57158c4acf4812de4e18728a918eac8fcfe6f628
crc's admin-helper seems to be using a recent enough version of this module, and crc seems to be using an up-to-date admin-helper release, so I'm not sure yet where the missing bit is.

Windows has a maximum of 9 entries per line, and to add more a new line is required as alias.
I am not aware of the known limitation of having a maximum of 9 lines for the same host/alias.
Might have a try with this later, but I know there is a tool called "Host File Optimizer" that might help with this.

# Test section
<IP_ADDRESS> one two three four five six seven eight nine ten
<IP_ADDRESS> eleven
<IP_ADDRESS> tweleve
<IP_ADDRESS> thirteen
<IP_ADDRESS> fourteen
<IP_ADDRESS> fifteen
<IP_ADDRESS> sixteen
<IP_ADDRESS> seventeen
<IP_ADDRESS> eighteen
<IP_ADDRESS> nineteen
<IP_ADDRESS> twenty
# End of test section

C:\Users\gbraad>ping one

Pinging one [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 1, Received = 1, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
Control-C
^C
C:\Users\gbraad>ping nine

Pinging one [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 1, Received = 1, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
Control-C
^C
C:\Users\gbraad>ping ten

Pinging ten.gbraad.net [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time=71ms TTL=51

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 1, Received = 1, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 71ms, Maximum = 71ms, Average = 71ms
Control-C
^C
C:\Users\gbraad>ping eleven

Pinging eleven [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 3, Received = 3, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
Control-C
^C
C:\Users\gbraad>ping nineteen

Pinging nineteen [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 2, Received = 2, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
Control-C
^C
C:\Users\gbraad>ping twenty

Pinging twenty [<IP_ADDRESS>] with 32 bytes of data:
Reply from <IP_ADDRESS>: bytes=32 time<1ms TTL=128

Ping statistics for <IP_ADDRESS>:
    Packets: Sent = 1, Received = 1, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
Control-C
^C

So it seems the limitation is only for the entries on a line, and not the amount of lines.
If this is failing on your end, it might be something else?
Have you installed a firewall or other endpoint protection?

We do have Symantec Endpoint Protection and Cisco VPN installed. Like I mentioned the limit might be because of some 3rd party product. There's no way of telling which product is causing the problem - I do not have required access to isolate it. And even if I did, convincing Symantec or Cisco to fix their product... you all know how this discussion would end.
If I manually split the long entry from multiple lines, everything seems to work properly. This should be easy enough to change at crc side? I can't see any negative side effects in this change (unless some other 3rd party product mishandles having multiple lines :-))

We might be able to propose a fix for the library we use, but might go with an intermediate postprocess to put them on individual lines.
Will see if this can be fixed soonish

https://github.com/goodhosts/hostsfile/issues/18

The hostsfile module we are using has code for this goodhosts/hostsfile@57158c4
crc's admin-helper seems to be using a recent enough version of this module, and crc seems to be using an up-to-date admin-helper release, so I'm not sure yet where the missing bit is.

I think this code is for cleaning/removing side not taking account to add an host entry.
$ cat /etc/hosts
<IP_ADDRESS> localhost localhost.localdomain localhost4 localhost4.localdomain4
::1 localhost localhost.localdomain localhost6 localhost6.localdomain6
<IP_ADDRESS> libvirt.default
<IP_ADDRESS> api.crc.testing canary-openshift-ingress-canary.apps-crc.testing console-openshift-console.apps-crc.testing default-route-openshift-image-registry.apps-crc.testing downloads-openshift-console.apps-crc.testing oauth-openshift.apps-crc.testing
<IP_ADDRESS> oauth-openshift.apps-crc.testing
<IP_ADDRESS> downloads-openshift-console.apps-crc.testing oauth-openshift.apps-crc.testing

$ ~/.crc/bin/crc-admin-helper-linux remove oauth-openshift.apps-crc.testing

$ cat /etc/hosts
<IP_ADDRESS> localhost localhost.localdomain localhost4 localhost4.localdomain4
::1 localhost localhost.localdomain localhost6 localhost6.localdomain6
<IP_ADDRESS> libvirt.default
<IP_ADDRESS> api.crc.testing canary-openshift-ingress-canary.apps-crc.testing console-openshift-console.apps-crc.testing default-route-openshift-image-registry.apps-crc.testing downloads-openshift-console.apps-crc.testing
<IP_ADDRESS> downloads-openshift-console.apps-crc.testing

Maybe we should drop this hostsfile library and do our own text processing. We could also add delimiters around the entries we added.

Does a later version of this library work? The author claims this exists?
But yeah, delimiting is also not existing now

I think this code is for cleaning/removing side not taking account to add an host entry.

ah looks like it. This seems like something which was missed when they added the line splitting.

Just to say, I really dislike the fact that library rewrites whole hosts file. If you've added custom comments (documentation), it all gets removed.
And now that I tested following:

added a new entry with completely different host (<IP_ADDRESS> foo) with a comment while crc was running
stopped crc
started crc

I observed that entry and comment got removed.
<IP_ADDRESS> prometheus-istio-system.apps-crc.testing
<IP_ADDRESS> istio-ingressgateway-istio-system.apps-crc.testing
<IP_ADDRESS> grafana-istio-system.apps-crc.testing
<IP_ADDRESS> jaeger-istio-system.apps-crc.testing
<IP_ADDRESS> kiali-istio-system.apps-crc.testing
<IP_ADDRESS> api.crc.testing canary-openshift-ingress-canary.apps-crc.testing
<IP_ADDRESS> console-openshift-console.apps-crc.testing
<IP_ADDRESS> default-route-openshift-image-registry.apps-crc.testing
<IP_ADDRESS> downloads-openshift-console.apps-crc.testing
<IP_ADDRESS> oauth-openshift.apps-crc.testing
<IP_ADDRESS> bookinfo-bookinfo-gateway-525eca1d5089dbdc-istio-system.apps-crc.testing
# another thing
<IP_ADDRESS> another

Got translated to:
<IP_ADDRESS> prometheus-istio-system.apps-crc.testing istio-ingressgateway-istio-system.apps-crc.testing grafana-istio-system.apps-crc.testing jaeger-istio-system.apps-crc.testing kiali-istio-system.apps-crc.testing bookinfo-bookinfo-gateway-525eca1d5089dbdc-istio-system.apps-crc.testing api.crc.testing canary-openshift-ingress-canary.apps-crc.testing console-openshift-console.apps-crc.testing default-route-openshift-image-registry.apps-crc.testing downloads-openshift-console.apps-crc.testing oauth-openshift.apps-crc.testing

This will cause major issues for everyone that uses hosts file for anything other than crc discovery.
I'd personally just read the whole file in memory, do a simple regex for removing specific content (block, or lines) and then append new content to end of file. Structure of hosts file is so simple that you really don't need fancy wrapper library for editing it.

if https://github.com/goodhosts/hostsfile/pull/20 is merged upstream then we can try to update our admin-helper to use this functionality to make sure each line doesn't have multiple host.

https://github.com/code-ready/admin-helper/pull/23 should fix it, tried it on windows.

This is fixed and available on latest version of crc.

exactly, well said. it's really bad idea and very intrusive default behavior. is there some change regarding that? i have pretty long and not interested in mods. provide settings what is needed and let change on user will be far user user friendly way...thx


Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce:]

...
...

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Mac OS X 10.12.4
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
at emitMany (events.js:127:13)
at EventEmitter.emit (events.js:201:7)
at WebContents. (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
at emitTwo (events.js:106:13)
at WebContents.emit (events.js:191:7)
At /Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/Applications/Atom.app/Contents/Resources/electron.asar/browser/objects-registry.js:41:28)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/rpc-server.js:306:31)
    at emitMany (events.js:127:13)
    at EventEmitter.emit (events.js:201:7)
    at WebContents.<anonymous> (/Applications/Atom.app/Contents/Resources/electron.asar/browser/api/web-contents.js:222:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:191:7)
    at metaToValue (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:217:13)
    at undefined.remoteMemberFunction (/Applications/Atom.app/Contents/Resources/electron.asar/renderer/api/remote.js:113:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:663:1)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:697:1)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:184:1)
    at /Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:1

Commands
     -3:09.5.0 editor:move-to-end-of-screen-line (input.hidden-input)
     -3:08.2.0 core:paste (input.hidden-input)
     -3:06.9.0 core:save (input.hidden-input)
     -2:31.8.0 fuzzy-finder:toggle-file-finder (input.hidden-input)
     -2:29.9.0 editor:move-to-first-character-of-line (input.hidden-input)
     -2:28.6.0 core:confirm (input.hidden-input)
     -1:35.1.0 find-and-replace:show (input.hidden-input)
  4x -1:23.9.0 core:move-left (input.hidden-input)
     -1:22.4.0 editor:select-to-end-of-line (input.hidden-input)
  2x -1:22.1.0 core:select-left (input.hidden-input)
     -1:20.1.0 emmet:toggle-comment (input.hidden-input)
     -1:20.1.0 editor:toggle-line-comments (input.hidden-input)
     -1:18.9.0 core:undo (input.hidden-input)
     -1:17.9.0 core:backspace (input.hidden-input)
     -1:16.7.0 core:save (input.hidden-input)
     -0:08.3.0 core:undo (input.hidden-input)

Non-Core Packages
atom-beautify 0.29.24
atom-typescript 11.0.3
busy-signal 1.4.1
compare-files 0.8.0
emmet 2.4.3
firewatch-syntax 1.1.1
git-history 3.3.0
git-plus undefined
intentions 1.1.2
language-babel 2.61.0
linter 2.1.4
linter-eslint 8.1.7
linter-less 2.6.0
linter-ui-default 1.4.0
minimap 4.28.2
open-git-modified-files 0.2.4
ramda-syntax 1.0.3
react-es6-snippets 0.3.0
seti-ui 1.8.0

Thanks for taking the time to contribute!
We noticed that this is a duplicate of #11692. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


azure-mgmt-rdbms docs missing

The preview release of the MySQL and PostgresQL services within the rdbms has the package listed on pypi for the rdbms, but the link is broken (https://azure-sdk-for-python.readthedocs.io/en/latest/sample_azure-mgmt-rdbms.html)

Hi @jmalobicky
Yes you're right, the package is released from the private repo, I will fix that asap.
Thanks for the report.

Hi @jmalobicky
Now the doc from source code is on RTD:
http://azure-sdk-for-python.readthedocs.io/en/latest/ref/azure.mgmt.rdbms.mysql.html
http://azure-sdk-for-python.readthedocs.io/en/latest/ref/azure.mgmt.rdbms.postgresql.html
We are working on the samples.
Thank you,

Thanks @lmazuel i noticed they were updated earlier in the day yesterday. Samples will be helpful :)

Need samples to implement.

@jmalobicky @kvnaveen7 There is some samples now here:
https://docs.microsoft.com/python/api/overview/azure/postgresql
https://docs.microsoft.com/python/api/overview/azure/mysql
Could you take a look, tell me if it's useful, and if not what kind of precise sample could help? Thanks!

Thanks @lmazuel, I ended up going through the models and operations and building my own. I am good at the moment and my deployment is operational.

Thanks @jmalobicky !
I'm closing this, since I think the intial question is covered. Please open a new issue if you need specific scenarios as samples.


Update url to point to requirements meaning

This may not be the most ideal link but at least it describes what the check is doing. Alternatively, you can a section back to the other page.
closes https://github.com/hacs/integration/issues/2297

Closing as docs has been updated, thanks :+1:


Option to set default date on open

Currently in all examples the picker opens to the current date.  I want to open it to another date/year without setting a value.
Any undocumented option for this?

Hey @TheSisb, there's no hidden option for this but it sounds like a good request.  This could be an initialDate prop that, if specified, will set the calendar's view to this date on first load.

We do this by hooking into onFocus, eg.:
const SomeComponent = React.createClass({
  getInitialState() {
    return { selected: null };
  },
  handleDateFocus() {
    if (this.state.selected === null) {
      this.replaceState({ selected: doAnyKindOfMagicDefaultLookupHere() });
    }
  },
  handleChange(newDate) {
    this.replaceState({ selected: newDate });
  },
  render() {
    return (
      <DatePicker
          onFocus={this.handleFocus}
          onChange={this.handleChange}
          selected={this.state.selected} />
    );
  }
});

Which works well for us since we do some computation at focus time to determine which date should be default. However, for simpler cases this is probably annoying to have to set up.

You can do this by creating a new date and pass it to moment. If you store it in your component state then you can do this:
const defaultDate = moment(new Date('YYYY', 'MM', 'DD'));
this.setState({ startDate: defaultDate });

...

<DatePicker selected={(this.state) ? this.state.startDate : null} />

Hope it helps someone.

@PetarIvancevic's answer looks probably like the way to go here. Do we want to document this somewhere?

@PetarIvancevic's solution sets the selected date, but @TheSisb was looking for a way without doing that.  @uniphil's code gets the right functionality but in an "unsupported" way.

Hi @TheSisb, just opened a PR for this if you want to take a look https://github.com/Hacker0x01/react-datepicker/pull/486

Fixed in #486


[Feature] When will floating charts be supported

Initial checklist

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Problem
now version dont support render img
Solution
support render img

We will start this work in this quarter.

We will start this work in this quarter.

Hello, could you tell me the progress of this project?

The floating charts feature is provided by VCharts through the univer-vchart-plugin.


Exit Script URL

There seems to be an issue with the URL produced when using the Exit script. It seems to be adding /logout? to external links that previous versions didn't (I tried 4_0_29)
4.0.47:

http://localhost:8080/sinom/logout?targetUrl=https%3A%2F%2Fwww.canada.ca%2Fen%2Femployment-social-development%2Fservices%2Fsin%2Fapply.html (from inspection)
4.0.29

https://www.canada.ca/en/employment-social-development/services/sin/apply.html (from inspection)
When an exitUrl property is specified, any external URL opened in a new tab appears to log the user out.

Hello, the URL that is specified for the exitURL parameter is added to external links. This is so that users can be redirected to a another page before continuing on to the desired page.
For example, in URL that you provided, it looks like you specified "logout" for exitURL parameter.
This is an optional feature. If you don't want that, then remove the exitURL parameter from your code.

Hello, the URL that is specified for the exitURL parameter is added to external links. This is so that users can be redirected to a another page before continuing on to the desired page.
For example, in URL that you provided, it looks like you specified "logout" for exitURL parameter.
This is an optional feature. If you don't want that, then remove the exitURL parameter from your code.

We still do need the exitURL parameter. We also need to be able to open external links in new tabs without "logging the user out". Once one link is opened, any other links they open on that page will open the page they would receive if they had logged out.

We also need to be able to open external links in new tabs without "logging the user out".

Use the exitDomains parameter to have hostnames part of the exception list. Exit script will not be applied for hostnames part of this list. See our sample page for more info: https://cdts.service.canada.ca/app/cls/WET/gcweb/v4_0_47/cdts/samples/exitscript-en.html

We do need the exit script to be hit so the logout happens but the links/domain we want excluded are canada.ca. It's an odd scenario but I don't know that the exitDomains parameter will work here.

Basically, you would like specific links of your choosing to be exempted from the exit script completely, correct?
If that is the case, I'm thinking of having an attribute that you can add to your link (for example: cdts-exiturl-disabled = "true") and so CDTS would recognize that attribute and exempt that link from the exit script.
Will that work for you?

Basically, you would like specific links of your choosing to be exempted from the exit script completely, correct?
If that is the case, I'm thinking of having an attribute that you can add to your link (for example: cdts-exiturl-disabled = "true") and so CDTS would recognize that attribute and exempt that link from the exit script.
Will that work for you?

That's exactly it, there are certain links within the canada.ca domain that we need to miss the exit script when the link is opened in a new tab. With an attribute that exempts the link, would the script still be hit if opened in the same tab?

With that attribute, the exitscript would not hit regardless of if you open in the same tab or new window.
Because opening in new tab depends on if you have attribute target="_blank" set to your link. Exitscript doesn't check for that.
That works for you?

Sorry for the late reply but I think this will work yes

It depends on when our release is scheduled for. Right now, we just did a release and the deployment has not been completed yet (scheduled for next week).
This means that the fix for this issue will go in our next release which we haven't even begun preparations for. It is very hard to say right now but it will take a couple months at the minimum (might be more).


Registrate v0.2.0

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/54811
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 390752c62a0171848bbed9520339ac49d242d335
git push origin v0.2.0


benchmark tooling + profiling

Some sample cases and benchmark tooling will make identifying performance improvements easier.

WIP benchmark suite for the interested.  I'll update once it's ready for usage.
https://github.com/scott113341/csjs-benchmarks


Adds missing ConfigurationParser file in META-INF/services.

The ConfigurationParser file points to CloudStoreConfigurationParser72, which is used to parse XML config in namespace urn:infinispan:config:store:cloud:7.2, including the cloud-store element. This is necessary to set up a cloud-store cache config via XML and have the correct parser be recognized by Infinispan.

Integrated, thanks!

Excellent, thanks for merging in those changes!
Do you mind if I ask about the release plan/policy for this project? I see in the POM file that the current version is 7.1.1.Final, but the latest version I can find in Maven central is 6.0.0.Alpha (http://mvnrepository.com/artifact/org.infinispan/infinispan-cachestore-cloud). I'd like to use this module in a production setting, and it would be much easier to do so if I could pull it directly from maven. Thanks!


Add option to reverse the light ring sense

Guidelines

[x] I have reviewed the guidelines for contributing to this repository.

Is your feature request related to a problem? Please describe.
Sometimes the led ring is reversed in the factory and as I tunr the knob le light count go in the other direction.
Describe the solution you'd like
Just a simple checkbox on the desktop application will be ideal

Sad to see this is still not implemented. I also have an 'inverted' LED ring.
Alltough happy with Maxmix for over 2 years now, still the LEDs animate in the wrong direction.
(see my comments in youtube video K7CqB7U6xoU )
So would be nice to see this fixed, if not, not a biggy, still love Maxmix :)


NIFI-8644: Introduced a notion of ParameterProviderDefinition. Refact…

…ored stateless to use this when creating a dataflow so that Parameter Provider implementations can be externalized into NARs. Also updated ExtensionDiscoveringManager such that callers are able to provide a new type of class to be discovered (e.g., ParameterProvider) so that the extensions will be automatically discovered.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for the thorough review @gresockj! I addressed the concerns and a few other minor tweaks that i found when updating the code. I also added a couple of system tests to verify that the behavior is as expected.

Agreed @gresockj the command line override should take precedence. Followed by environment variables, and then anything provided by a ParameterProvider. Updated the PR to use this precedence. Thanks again!


Problem when creating a Waterfall Plot

After creating a XGBClassifier, and training this classifier with .fit(xtrain, ytrain), I want to use SHAP to create the waterfall plot.
import shap
import pandas
from sklearn.model_selection import train_test_split

X, Y = data.drop(target, axis=1), data[target]
xtrain, xtest, ytrain, ytest = train_test_split(X, Y, test_size=0.2, random_state=50)

shap.initjs()

explainer = shap.Explainer(xgbc)
shap_values = explainer.shap_values(xtest)

shap.waterfall_plot(shap_values[0], xtest.iloc[0])

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Input In [28], in <cell line: 1>()
----> 1 shap.waterfall_plot(shap_values[0], xtest.iloc[0])

File ~/Anaconda3/lib/python3.9/site-packages/shap/plots/_waterfall.py:45,
in waterfall(shap_values, max_display, show)
     42 if show is False:
     43     plt.ioff()
---> 45 base_values = shap_values.base_values
     46 features = shap_values.display_data if shap_values.display_data is not None else shap_values.data
     47 feature_names = shap_values.feature_names

AttributeError: 'numpy.ndarray' object has no attribute 'base_values'

The problem appears because shap_values is just a NumPy array without any attributes like:

.values
.data
.base_values

What I'm doing wrong, or how should I solve this problem?
I'm on the latest version, 0.41.0.

Sorry, my fault, I was doing wrong the shap_values line wrong:
explainer = shap.Explainer(xgbc)
shap_values = explainer(xtest)

Is the correct one :)


Windows key shortcut guide in Chinese

Microsoft PowerToys version
0.68.1
Utility with translation issue
Shortcut Guide
🌐 Language affected
Chinese
❌ Actual phrase(s)
Some of them are in English, while others are in Chinese.
✔ Expected phrase(s)
Will it possible to make them all in Chinese? I cant take the screenshot when I activate the guide window.
ℹ Why is the current translation wrong
The translation is right, but not complete.

this is too vague to be actionable.  Can you provide more information?
/needinfo


Foundation

What should happen?
...
What happens instead?
...
Possible Solution

...
Test Case and/or Steps to Reproduce (for bugs)

Test Case:

How to reproduce:
1.
2.
3.
Context

...
Your Environment

Foundation version(s) used:
Browser(s) name and version(s):
Device, Operating System and version:
Link to your project:

Checklist

[ ] I have read and follow the CONTRIBUTING.md document.
[ ] There are no other issues similar to this one.
[ ] The issue title and template are correctly filled.

Hi, I've been online with Bluehost because my homepage graphics disappeared after I updated my WordPress site. I was told it was a Foundation Press Master issue and I need to contact the company who created it. So, here I am. Hoping someone can tell me if there is a bug (obviously not a tech person) and hopefully that it's being rectified. Any advice would be appreciated. Thanks.

Hi @KendallHunter,
FoundationPress support is available at https://github.com/olefredrik/FoundationPress. But this project is archived.
We are not the creators of this theme.

But this sounds like a different issue which is not directly caused by us - as Foundation Sites is only frontend code (css, js, html).
A link to the affected website would be vedy helpful.

This is the site that's been affected. https://culturedock.com/
Bluehost said it's not an issue they can help with because the theme is
created by a third party. They also said there have not been other
complaints so that leaves me curious.
On Tue, Nov 26, 2019 at 12:37 AM Daniel Ruf<EMAIL_ADDRESS>wrote:

But this sounds like a different issue which is not directly caused by us

as Foundation Sites is only frontend code (css, js, html).

A link to the affected website would be vedy helpful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/foundation/foundation-sites/issues/11920?email_source=notifications&email_token=AN37LOIVD3H5WCOAXS7FNM3QVSYZRA5CNFSM4JRPRVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEY4UI#issuecomment-558468689,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN37LOKVKBJEOFTC6VFKBSDQVSYZRANCNFSM4JRPRVFQ
.

--
*Kendall *
kendallhunter.ca
culturedock.com
(647) 293-1449

This is not directly related to the frontend framework.
Bluehost should check the errorlog, it should contain some error why it stops there. I do not have any access to your server so I can not directly help with that.

Ok thank-you
On Tue, Nov 26, 2019 at 12:49 AM Daniel Ruf<EMAIL_ADDRESS>wrote:

[image: Screenshot_20191126-064705]
https://user-images.githubusercontent.com/827205/69602640-99928f80-1018-11ea-9100-bfb7028ed2d0.jpg
This is not directly related to the frontend framework.
Bluehost should check the errorlog, it should contain some error why it
stops there. I do not have any access to your server so I can not directly
help with that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/foundation/foundation-sites/issues/11920?email_source=notifications&email_token=AN37LOPD4KBEDMVLQOYB6TDQVS2IFA5CNFSM4JRPRVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEZSYQ#issuecomment-558471522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN37LONZNBMONU2G7DG5ST3QVS2IFANCNFSM4JRPRVFQ
.

--
*Kendall *
kendallhunter.ca
culturedock.com
(647) 293-1449