Max open file limit issue with Elastic Search and Docker

What happened:
I'm running into ulimit / max open file limit issues when trying to run Elastic Search on Docker using this AMI. This is the same as issue #278. Issue #278 is marked as "closed", but as the last comment on the issue states, this is still a problem.
How to reproduce it (as minimally and precisely as possible):
I launched the newest version of the image that I could find: amazon-eks-gpu-node-1.14-v20191213 (ami-0730212bffaa1732a) and found the contents of /etc/sysconfig/docker to be this:
# The max number of open files for the daemon itself, and all
# running containers.  The default value of 1048576 mirrors the value
# used by the systemd service unit.
DAEMON_MAXFILES=1048576

# Additional startup options for the Docker daemon, for example:
# OPTIONS="--ip-forward=true --iptables=true"
# By default we limit the number of open files per container
OPTIONS="--bridge=none --default-ulimit nofile=2048:8192 --log-driver=json-file --log-opt max-size=10m --log-opt max-file=10 --live-restore=true --max-concurrent-downloads=10"

# How many seconds the sysvinit script waits for the pidfile to appear
# when starting the daemon.
DAEMON_PIDFILE_TIMEOUT=10

For my purposes, I've written a command into my CloudFormation UserData to replace nofile=2048:8192 with nofile=65536:65536. It looks something like this:
mv /etc/sysconfig/docker /etc/sysconfig/docker.bak
sed 's/nofile=2048:8192/nofile=65536:65536/g' /etc/sysconfig/docker.bak > /etc/sysconfig/docker
systemctl restart docker

Environment:

AWS Region: US East 1
Instance Type(s): any
AMI Version: amazon-eks-gpu-node-1.14-v20191213 (ami-0730212bffaa1732a)

@hopper-signifyd Thanks for the detailed issue, and sorry for the late answer. It has been some busy times lately.
The issue here seems to be between the default docker settings and Elastic Search wanting to have a lot higher limit. The defaults are like that for a reason, but I agree that we could make it easier to enable higher limits for running Elastic Search. I wonder if improved documentation around the --docker-config-json flag in bootstrap.sh would be enough, or if adding a section about customizing for Elastic Search?
Another option would be to add a custom flag in bootstrap.sh, something like --configure-docker-nofile-limit <limit>, similar to the --enable-docker-bridge flag, that would let you set that limit explicitly.

Hi @mogren,
Thanks for looking into this. If this can be fixed via --docker-config-json, then I think that would be sufficient. An example in the docs would be helpful. I think adding things like --configure-docker-nofile-limit if the parameter could be configured via a more general approach would lead to people asking why there's a specific option for one config parameter, but not for others.

@mogren  I believe this may be a regression as I understand the intention to be a ulimit of 65535 not 8192. Please see https://github.com/awslabs/amazon-eks-ami/issues/278 and
https://github.com/awslabs/amazon-eks-ami/issues/233  for context where it was determined that changing the ulimit to 8192 was accidental and was fixed in subsequent releases.

@ajcann
I think there's two separate issues.
The first, I can confirm --default-ulimit nofile=2048:8192 is still in accelerator AMI, I will make a change to 65535, this should be shipped with CUDA 10.2 and latest nvidia driver pretty soon.
The second, that's the only ulimit setting we give in the docker configs. I think @mogren 's point is more like how can we better support these cases. We have some other products needs memlock etc.

@ajcann
I think there's two separate issues.
The first, I can confirm --default-ulimit nofile=2048:8192 is still in accelerator AMI, I will make a change to 65535, this should be shipped with CUDA 10.2 and latest nvidia driver pretty soon.
The second, that's the only ulimit setting we give in the docker configs. I think @mogren 's point is more like how can we better support these cases. We have some other products needs memlock etc.

@Jeffwan ah yes I see that you are correct. Thank you for addressing the docker options!

My understanding is this has been addressed, please let us know if this remains an issue on the latest AMI's.


Additional information requested for SAF-T tax code mapping

Could you please provide additional information regarding the saf-t tax code mapping as the documentation currently doesn't instruct how to handle scenarios in which multiple codes would be applicable. As an example, let's say a single tax code in Dynamics 365 was defined for full rate sales and purchases. A different SAF-T code would be applied depending on the direction. How would one correctly map SAF-T codes in this situation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d8904993-84a8-8983-dcc5-4499b6e1e9d5
Version Independent ID: f40dc67d-74a2-dab3-182c-fbbd6f0e46e0
Content: Standard Audit File for Tax (SAF-T) for Norway - Finance | Dynamics 365
Content Source: articles/finance/localizations/emea-nor-satndard-audit-file-for-tax.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @liza-golub
Microsoft Alias: elgolu

@liza-golub, please review.

Hello,
Thank you for your feedback. Scenario described in the comment: “Scenarios, in which multiple codes would be applicable. As an example, let's say a single tax code in Dynamics 365 was defined for full rate sales and purchases. A different SAF-T code would be applied depending on the direction.” is out of scope of current implementation of Norwegian SAF-T report. Currently this is not in our roadmap; however, we are tracking ideas registered on ideas portal and if we get more feedback and votes, we may consider it in the future. We suggest registering this information in relation to the Norwegian SAF-T report. Alternatively, such requirement could be implemented via customization of “SAF-T Financial data model mapping” model mapping and “SAF-T Format (NO)” format configurations of the report to accommodate specific need of a company.
Sincerely,
Elizaveta Golub,
PM, Microsoft

Hello @liza-golub . Understand not in roadmap for my specific example scenario, but there are simpler ones as well and I would still request additional instruction for the SAF-T setup for tax codes. The article basically only says "set up the external codes for tax groups" but how?

Is the standard code checkbox required to be set in order for the SAF-T report to work?
What if multiple tax codes use the same SAF-T code? The external codes form blocks duplicates, so is it ok to create another external code header record and have that as standard code too?

Hello,
Current implementation of External codes for Sales tax codes is limited to possibility to setup one “external” code value for one Sales tax code. As you correctly noted: “The external codes form blocks duplicates”. This behavior was inherited from the solution introduced for Norwegian SAF-T report in 2016th for AX 2012 R3, to not brake users experience in case some companies are migrating from 2012 R3 to Dynamics 365 Finance. Here you can find some description of this feature in AX 2012 R3: https://docs.microsoft.com/en-us/dynamicsax-2012//sales-tax-codes-form?redirectedfrom=MSDN
In general, “External codes” is not Norway specific or SAF-T specific feature – it is part of core tax module master data setup which is used in reporting. Different reports can use differently this functionality depending on in-market practices and particular report requirements.
Specifically, for Norwegian SAF-T the algorithm is the following: system takes the value (ExtCodeValue) for the first found External code from the list of specified for a Sales tax code.
FIRSTORNULL(FILTER(ExtCodeValueTable<EMAIL_ADDRESS>ExtCodeValueTable.ExtCodeRelationRecId=@.RecId)))
Where @ = TaxCodes
Hope this information helps.


feat : Add relationships for session model

Changes:

Added resolvers for adding relationship(session-type, track, microlocation) in session model
Moved IO related methods to IOUtils class

@iamareebjamal @arp95 Please review

@Shailesh351 We only need to have relationship which is directly accessible in 1 JSON, because we won't make 3 API calls just to resolve Session type

So assume that while parsing you only have access to session.json

@iamareebjamal but for relationships of session with microlocation, track and speaker we need to make different api calls right. how can we determine the realtionship through one json?

@iamareebjamal Main problem is that in current server response they only providing relationship links. So for parsing we have to fetch response from server.
If they provide INCLUDED section also then we can parse whole json without making API calls.
Please suggest other way

Currently, you can manually add included section, as it will be definitely returned by the API

@arp95 The basic info about each relationship will be included in the JSON. Like at least the ID of sessions, or tracks or microlocations

When it will be saved in db, it'll load the whole object because they'll be linked by IDs. When we load from network, we won't be waiting for all calls to complete to then send each to different parsers. This will be a complex task as session track and speakers have circular dependency

@iamareebjamal Made changes. Please review


How to make SourceMaps work for 1p Packages with WebPack ?

We have a bunch of 1p JS packages which are used across web and mobile (React Native App). One thing we have noticed is the source map only works for the base package and not for the 1p packages as those are node dependencies added at compile time.
The 1p node modules are not captured as part of the source maps how do we enable for our packages alone? I tried using https://www.npmjs.com/package/source-map-loader but it dosent work and gives error at compile time .
Setup

ERROR in (webpack)-dev-server/client?http://localhost:8080
Module build failed (from ./node_modules/source-map-loader/dist/cjs.js):
TypeError: this.getOptions is not a function
    at Object.loader

WebPack Config
devtool: 'source-map',
  module: {
    rules: [
      {
        test: /\.js$/,
        enforce: "pre",
        use: ["source-map-loader"],
      },
      {
        test : /\.scss$/,
        use: {
          loader: 'sass-loader',
          options: {
            includePaths: ["./node_modules"]
          }
        }
      },
      {
        test: /\.js$/,
        use: {
          loader: 'babel-loader'
        }
      },
      {
        test: /\.mjs$/,
        include: /node_modules/,
        type: 'javascript/auto'
      }
    ]
  },

What are 1p packages?
The error sounds like you are using an outdated webpack version, but I can't say because:
It looks like you just deleted/ignored our lovely crafted issue template. It was there for good reasons. Please help us solving your issue by answering the questions asked in this template. I'm closing this. Please open a new issue with filled issue template. Also make sure your issue is not a question. Questions should be posted on Stack Overflow.


Make tiles still visible at small screen resolutions

Shrinking keyboard is the only way, I think
iphone SE

before
after

Together with other PR, I think this closes #43

Definitely an improvement.

There is overlap with IPhone XR in landscape, but I'm ok with that.


Create interface for indexible tables in IndexedTableAccess

Currently, only ResolvedTables are allowed to have indexes. There exists an interface, sql.IndexAddressable, which any node or table can implement in order to be a candidate for index-based optimization. But in practice, implementing that interface won't actually do anything because the IndexedTableAccess struct explicitly requires a ResolvedTable.
This PR replaces the ResolvedTable field in IndexedTableAccess with a new interface tentatively called TableNode, although a more specific name would probably be better.
In order for a node to be used for index-based optimization, it must implement this interface, and the table returned by the UnderlyingTable method must implement sql.IndexAddressable

Prior to this PR, it was not possible for system table functions to have indexes. (You could make the table function implement sql.IndexAddressable, but it wouldn’t actually do anything.)
It’s now possible to write a system table function that can be optimized. The workflow looks like this:

Create a sql.Partition implementation that encodes all information necessary for the table function logic to only generate rows that match the filter. For example, include a field in the partition object for each field being filtered on.

Partitions were a feature inherited from GMS, designed to facilitate parallelism: a table is divided into multiple partitions that can each be iterated over separately. Dolt doesn’t support parallelism, but we still use partitions because indexes are implemented via partitions: every node that is indexable converts index lookups into an PartitionIterator.

Implement a Partitions method, which returns a partition iterator that will contain every row in the table exactly once. This method is called in situations where the caller wants to get every row in the table.

Implement a PartitionRows method, which takes a partition and returns a RowIter. Most likely, either this or the existing RowIter function will end up calling the other one.

Implement GetIndexes, which provides the list of indexes that the table supports.

These don’t need to be full implementations of the sql.Index interface. Most index functionality won’t actually be used. In the case of table functions, it’s not even possible for a query to inspect these indexes. There doesn't need to be an underlying table.

Implement LookupPartitions, which takes in IndexLookup and generates a PartitionIter.

The process of implementing these methods is cumbersome, but straightforward, so long as you’re only exposing a single index on a single column. Optimizing on multiple columns becomes more complicated.
In addition, there may be optimizations that can’t be expressed as an Index. For instance, imagine a hypothetical system table function that has N columns and any combination of these columns can be filtered on efficiently. In order to make sure that every combination of filters can be done efficiently in the current framework, the node would need to provide N! different indexes.
A better solution would be to allow system tables (and system table functions) to be aware of filters when generating their rows. Conceptually, this could be done by having system tables implement an interface which consumes a filter expression and produces a new system table node. In cases where no optimization can be performed, the interface returns the original system table unchanged. Then we add an optimization that runs after we push filters down the tree, that pattern matches for filters whose child nodes implement this interface.
If we decide to optimize more system table functions in the future, we should strongly consider this better solution, since it will result in cleaner, more readable, more maintainable code that’s faster to write.


Request callback function arguments are not in correct order

The callback functions in request module have arguments error, response, body, in that order. But DefaultTransporter passes the arguments in the order error, body, response, in lines 70 and 106
I suppose that's because the API is designed to return meaningful stuff in body of the HTTP response. And that's fine.
The problem arises when someone writes a callback that uses the response argument, and due to the difference is design, naively ends up using body.

Addressed in #182 when we switched from Request to the promise based Axios


Use of $NIX_BUILD_TOP considered harmful

Describe the bug
Nix expressions that rely on $NIX_BUILD_TOP may break under nix-shell (or when using nativeBuildInputs = [ keepBuildTree ]), so let's try to avoid it.
Steps To Reproduce
Steps to reproduce the behavior:

Find a package that uses $NIX_BUILD_TOP, e.g. spotifyd via cargo setup hook: nix-shell -A spotifyd
Run genericBuild inside the shell.
Watch it fail trying to work with files inside $NIX_BUILD_TOP (when the files actually are in $PWD).

Expected behavior
Builds work both with nix-build and nix-shell (not fail in the latter case).
Additional context
A workaround for the nix-shell breakage could be exporting $NIX_BUILD_TOP before invoking any build code. (nix develop has code for that?) But it wouldn't fix the keepBuildTree case.
Notify maintainers

TODO list

[x] cargo setup hook: https://github.com/NixOS/nixpkgs/issues/138554
[ ] buildBazelPackage
[ ] Most other packages referring to $NIX_BUILD_TOP. (Some are harmless, need to check them.)

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/use-of-nix-build-top-considered-harmful/21443/1

CC bazel and cargo setup hook people: @abbradar @danieldk.
Do you agree with the issue? Who else need to be aware of this issue before we start removing $NIX_BUILD_TOP from nixpkgs?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/temporary-writable-directory-for-builds/34907/1

Another fix here: https://github.com/NixOS/nixpkgs/pull/266723

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-look-at-the-build-directory-after-successful-build/14007/3


RUM-6035 Add the integration tests related with RumMonitor#addViewLoadingTime API

…dingTime API
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (mconstantin/rum-6033/add-viewloadingtime-logs@e70c3ea). Learn more about missing BASE report.

Additional details and impacted files
@@                               Coverage Diff                                @@
##             mconstantin/rum-6033/add-viewloadingtime-logs    #2268   +/-   ##
================================================================================
  Coverage                                                 ?   70.14%
================================================================================
  Files                                                    ?      727
  Lines                                                    ?    27170
  Branches                                                 ?     4577
================================================================================
  Hits                                                     ?    19056
  Misses                                                   ?     6836
  Partials                                                 ?     1278


Enable or disable caching allocator from Lua

The CUDA caching allocator is now enabled by default but is know to consume more memory (#707). It can be controlled with the THC_CACHING_ALLOCATOR environment variable but some applications may want to enforce a value to mitigate their memory usage without user interaction.
Here I propose a simple approach to disable or re-enable the CUDA caching allocator from Lua code.

this doesn't really seem worth the complexity; maybe I'm missing the use case, but it seems semi-far fetched that someone is going to use a caching allocator, realize they are using too much memory, and turn off the caching allocator at run time, over just not using the caching allocator to begin with.
And it's not clear this would even solve the above problem; for example, if you use the caching allocator and haven't freed some allocations when you switch, you'd have to empty the cache again after you free, otherwise you only mark the cached blocks as unallocated and don't actually return them to the system.

The primary use case is to disable the caching allocator from the client application, typically during its initialization. I agree the current implementation is somewhat naive and certainly does not properly handle the switch at runtime (i.e. after some allocations have already occur).
However, I believe applications should be able to enforce a value as the caching allocator can require as much as 2GB more memory. Currently, I have to repeat to users to use this environment flag to fix their out of memory issues.
Let me know if there is a better way to implement this feature. Or if you don't want to support such feature, that's fine too and you can close this PR.

what about just having an accessor/acccessors and using that in the client to warn/error about the specific client not being used with caching?

That's sound good to me. I will re-open a PR with this approach.
Thanks!


Parameter file type consumes, confusing language

In the Parameter Object definition of the type property, the following is stated:

If type is "file", the consumes MUST be either "multipart/form-data" or "application/x-www-form-urlencoded"

Interpreting this strictly would mean that consumes MAY NOT contain both "multipart/form-data" and "application/x-www-form-urlencoded" but MUST contain no more or less than one of those two choices. This restriction seems odd to me.
Could anybody please clarify if the above interpretation is correct.

It can be either one or both.

So basically "A and/or B" rather than "either A or B" (http://dictionary.cambridge.org/dictionary/english/either-or)
This language construct appears to be used in a few other places in the documentation as well, I believe some of those may similarly be incorrect.

Please do. I'll review the changes and add comments if needed.

Just added a pull request #514. Only two found. Other uses of "either/or" seem appropriate as is.

Thanks for that.


Fix: The interface is broken when modifying  review under mobile devices

Fix: #30123
Before

After

After research, the following CSS only affects the modification of reviews and doesn't impact other places, so it was directly deleted
@media (max-width: 767.98px) {   .comment-code-cloud .comments .comment {     display: flex;   } }


Review translation and rotation box interactive

Getting this ready for release, @JackMorganNZ could you please comment on this issue with any changes you want made. I'm unsure about the relative paths used for linking to files across different folders, can you test that it works on our system and if not, let me know what to change :) (Last folder restructure in commit https://github.com/uccser/cs-field-guide/commit/4827ff4ac7f0ae888828a8fc6daa5c75f5d86bcd)

Here are some ideas for the interface from using both interactives:

[ ] Entering 90 into the rotation interactive should turn the box 90 degrees (1:1 ratio). I currently like the ratio of numbers for the translation interactive, but we may want to make numbers on a similar scale (can chat about this in detail soon).
[ ] Possibly try moving box on input change rather than pushing enter.
[ ] Clicking submit without selecting anything causes an TypeError.
[ ] Upon clicking submit (with correct sequence), this error is hit script.js:452 Uncaught TypeError: scene.removeObject is not a function.
[ ] This message is logged to console, check if it can be removed (or is due to issue) THREE.WebGLRenderer 74.
[ ] Possibly add restart button after successful ending.
[ ] Generally enlarge the interface:

[ ] Change instruction font to not monospace for readability.
[ ] Increase button and input internal padding.
[ ] Possible put each input on a new line.

[ ] Begin incorrect shaking as soon as submit button is clicked.
[ ] Limit input boxes to 3 digits.

Interactive is looking amazing, will be the best one so far!

I tested out moving the box on input rather than by pushing enter when I was making it, it made the interactive very confusing to use (particularly when dropping a place holder, e.g. 500 -> 50 and vice versa as it led to very sudden movement).

THREE.WebGLRenderer 74 is a feature of threejs for devs to see what version the page is using, and has been discussed in the threejs repo, where the general consensus was to leave it there. The typical user will not notice it, and a curious dev might appreciate it :)

For "Limit input boxes to 3 digits" I set a (-360, 360) range. For the rotation interactive it takes mod 360 of the given input, and for the translation interactive -360/360 act as the lower/upper bound so any number outside of this range automatically gets changed to -360/360.

Tidied up a couple more things  https://github.com/uccser/cs-field-guide/commit/e15584f907b0c827dbcc3fbc6af173132b760dcd


Add tests for auto-generated private accessors.

I am half way through reviewing this PR. However, I don't understand why the test for RT #125227 is removed. Could you shine a light on that?
That being said, this removed test seems to be wrong. $o ~~ /':2'/ will probably match World.nqp:2498 just as well.

These tests are written in support of PR rakudo/rakudo#674. That PR adds support for auto-generating private accessors, it also attaches defined semantics to 'is rw'/'is readonly' for private attributes. In that regard the test was removed as it specifically tests that 'is rw' will generate a warning -- something it should no longer do.

This issue mentions an issue that has been closed as Rejected, and also has a good amount of conflicts. Closing it.

What? This is a PR for https://github.com/rakudo/rakudo/pull/674 which is open. So this should be open as well.

Worth a problem-solving issue, I'd say.

Since https://github.com/rakudo/rakudo/pull/674 is closed, closing this one too. It's also conflicting, so it does not help anyone keeping it open.


Set-up Matomo analytics

Purpose
Offer analytics on page's visits to the communication/marketing team.
Proposal

[X] Setup Matomo per the React integration guide.
[X] Add the official Iframe to allow user Opt Out tracking analytics.
[X] Update Data and cookies page's content.
[X] Minor changes in Legal pages UI.

i'm currently changing the default styles with DSFR so don't worry about styling things of external links I'll fix it :)


feat:Adding Sound effect

As the title suggests, this issue is regarding the adding sound effects to the game when a player wins the game or it is a draw also try to improve the design of the game to give it a refreshing look . So get your Html, CSS and Java Script skills to work by improving the design of the overall application and also adding the sound effect to it.

I can add sound effect to the game for both the states(Winning and draw) while give the game  a change in look.
Please assign this issue under Hacktoberfest 2023.
Thank You.

hey @malivinayak I have created a PR for this #5 please review it, and attach Hacktoberfest-accepted label to this PR.

Please assign this issue to me

hey @malivinayak I have committed  requested changes again to the PR for this #19 please review it once.

@Kedarnath-Rothe

Please assign this issue to me

This feature is introduced by @shivam-sharma-03 and @shivam-sharma-03 already working on it.
Don't just put same message in every issue. find your own and start working on it if you want.
Thank You.

Hey @malivinayak completed the requested tasks, please review and also, please add Hactoberfest-Accepted label to the PR.


Documentation: Can we get an example of CSS in the UI ?

Hi! Thanks for your work on this. I'm trying to figure out how to add custom CSS. I see your json examples but that hasn't helped me set CSS in the settings. I've tried just 'strong' 'text-decoration: line-through;' 'background: black' and variations but none seem to work. Just an example wold help me identify what CSS goes in there (like.. do I add root:? I don't think so—do I add the cssclass?).
Thanks!

Write styles in the CSS editor just like you would if you were writing a css snippet. You still need to call out the class names you want to style and such.
.inline-property-name {
color: var(--text-faint);
font-size: 0.8em;
}


[BugFix] Fix partial partition query rewrite for external table

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #19011
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 10 / 14 (71.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalHudiScanOperator.java
0
1
00.00%
[103]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalIcebergScanOperator.java
0
1
00.00%
[88]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFileScanOperator.java
0
1
00.00%
[97]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalDeltaLakeScanOperator.java
0
1
00.00%
[82]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/ScanOperatorPredicates.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalHiveScanOperator.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 10 / 14 (71.43%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalHudiScanOperator.java
0
1
00.00%
[103]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalIcebergScanOperator.java
0
1
00.00%
[88]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalFileScanOperator.java
0
1
00.00%
[97]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalDeltaLakeScanOperator.java
0
1
00.00%
[82]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/ScanOperatorPredicates.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/logical/LogicalHiveScanOperator.java
1
1
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Fix connect/reconnect race in sniff mode of logical replication

Summary of the changes / Why this improves CrateDB
Rewrite sniff remote cluster connection
Fuses all of:

RemoteClusterClient
RemoteClusterConnection
SniffConnectionStrategy
RemoteConnectionManager

into a single SniffRemoteClient that works more similar to the PgClient.
This should fix some concurrency issues with the previous implementation
which led to flakyness in cases where multiple components try to
establish a connection at the same time.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please
Unrelated test failure:
test_graceful_stop_concurrent_queries (test_decommission.TestGracefulStopDuringQueryExecution) ... FAIL
======================================================================
FAIL: test_graceful_stop_concurrent_queries (test_decommission.TestGracefulStopDuringQueryExecution)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/CrateDB/crate_on_pr/blackbox/test_decommission.py", line 351, in test_graceful_stop_concurrent_queries
    self.assertEqual(errors, [])
AssertionError: Lists differ: [ProgrammingError('ShardNotFoundException[no such shard]')] != []

First list contains 1 additional elements.
First extra element 0:
ProgrammingError('ShardNotFoundException[no such shard]')

- [ProgrammingError('ShardNotFoundException[no such shard]')]
+ []```


[BUG] Can't enable kube-explorer ui plugin when creating a cluster

Describe the bug
When creating a cluster, can't enable kube-explorer as ui plugin. Only can enable it from the cluster list page.
To reproduce
Steps to reproduce the behavior:

Go to the Clusters list page and create a new cluster.
Config cluster parameters and enable Explorer as ui plugin in Add-on Options Tab
After deploying K3s successfully, the kube-explorer is not enabled as selected.
Enable kube-explorer plugin from the Cluster list page is working as expected.

Expected behavior
The kube-explorer plugin can be enabled after deploying the K3s cluster successfully.
Screenshots

Environments (please complete the following information):

OS: Darwin Bigsur
AutoK3s Version v0.9.1

Additional context
This bug occurs after adding the support of the Add-ons plugin in Add-on Options Tab.

tested by UI version v0.9.2-rc2. close as complete


Supervised Order with OBSERVER permissions shows too many buttons on MyDSpace.

Describe the bug
Discovered during final testing of #2019
The issue is on the "MyDSpace -> Supervised Items" when "OBSERVER" permissions are assigned.  Obviously, if you are just an OBSERVER, you should only be able to view the Item.  But, the buttons displayed imply you can do more.
Here's want an OBSERVER sees on MyDSpace:

(I'd expect that the "Delete" and "Edit" Buttons should not appear. They should only have the "View" option")
That said, I've confirmed that clicking "Delete" doesn't work.  If the OBSERVER clicks "Edit", they are able to load the submission form... but they are unable to save any changes to the form.
To Reproduce
Steps to reproduce the behavior:

Login as an Admin & create a Supervision Order (from Administrative Workflow), assigning a Group with OBSERVER permissions
Logout & Login as a member of that group
Go to "MyDSpace -> Supervised Items".  Verify you see the Supervised Item, but also see an "Edit" and "Delete" button.

Expected behavior
Edit & Delete button should not appear on MyDSpace page for the OBSERVER role.  An OBSERVER can only view the supervised item.
Related work
Related to #2019

@atarix83 : This is the final (minor) issue that I located in #2019.  If there's a very quick fix, let me know & we could still try to get it into 7.5.  If it needs work / more analysis, then we'll wait till 7.6 to resolve this.


add app.listenPromise

Proposing this new method
https://github.com/nodejs/node/issues/21482
or maybe we could have a breaking change for express 5, where .listen return a Promise if no callback is given?
I think it's be great, since doing:
const server = app.listen(process.env.PORT || 3000);
console.log(server.address().port)

is unsafe (it can throw since .listen is async, and .address not necessarily available just after)
but I guess you'll want to preserve the API chaining style for .listen
maybe a app.ready() returning a Promise rather?

Hey @caub!  I think the idea of app.listen returning a promise if no callback was specified is the best idea here.  I would be interested in hearing other contributors opinions, but I imagine if you put together a PR with just1 that it would setup the conversation point.
1: I mean remove all the other changes you have in this PR, and just use native promises.

@wesleytodd the problem is when people use the return value of app.listen, with no callback. Making it return a Promise would break this

This is bringing back memories now.  I think this issue has already undergone some discussion but I cant remember where.  I searched PR's and issues but couldn't find it.
You are absolutely right that returning a promise breaks the existing behavior, but I was thinking it could be one of the breaking changes in 5.0.  The change would be to resolve with the server or reject with an error.  I am not sure I like the change, but that is what I was thinking the discussion would be about.

I've done something similar back in an internal framework for a previous company, and ended up reverting the change.
The problem is that listen currently fills two functions:

it creates an http.Server
it calls listen on that server

That is why the listen function currently both return a value (the Server) and takes a callback.
I think that the "best" or "most correct" or whatever way to do it would have that as two methods. First you create a server, then you call listen on that. But then the question is whether we should return a plain http.Server (which then will not support a promisified .listen) or whether to return our own representation of an http.Server.
That would also then make it "harder" or "more complicated" to just start listening on a port, since it would require two calls.
Maybe a createServer, or just server, method could be provided in addition to a revamped listen that returns a Promise<void>.
app.server().listen(3000, () => console.log('Listening'))
app.listen(3000).then(() => console.log('Listening'))

const server = app.server()

server.listen(0, () => {
  console.log(`Listening on ${server.address().port}`)
})

We could even make .listen return a Promise of server.address(), I think that would be quite neat!
app.listen(0).then(({ address, port }) => {
  console.log(`http://${address}:${port}`)
})

and also default the port to 0 (or maybe even Number(process.env.PORT || '0'), but maybe too much magic?)
app.listen().then(({ address, port }) => {
  console.log(`http://${address}:${port}`)
})

I'm going to close this since it's been 2 months and there hasn't been any update to the pr, responses to the two above collaborator comments, and the changes don't even have passing tests after all this time.
If there is desire this pr can always be reopened or a new one created.

I tried to make it, (see my last push), so that it works like before when passing a callback, or return a Promise else
I get thus only error though: and couldn't find how to solve it
 1) res .sendFile(path, fn) should invoke the callback when client aborts:
     TypeError: app.address is not a function
      at Test.serverAddress (node_modules/supertest/lib/test.js:55:18)
      at new Test (node_modules/supertest/lib/test.js:36:12)
      at Object.obj.(anonymous function) [as get] (node_modules/supertest/index.js:25:14)
      at Context.<anonymous> (test/res.sendFile.js:277:34)

I would like for us to have a discussion about the points I brought up before landing this ☺

Should a new issue be opened to discuss? I read through the above and wasn't super obvious what the discussion points were, and perhaps a more meta issue may help, especially since there are no promise anything in express today so adding this one promise thing just seems off at the surface.
The reopen button is disabled on the pr apparently so i can't reopen if i wanted to, sorry.

@LinusU I rather think express should stay this simple wrapper of node's http.Server
I'd just like to add app.close that would call server.close in addition of this promisified listen (that might come in nodejs as well some day)

press should stay this simple wrapper of node's http.Server

I'm not sure what this mean. Express does not wrap http server at all. That's why there is no app.close etc. An express app can be multiple servers / ports. This is how you can make an express app be both http and https at the same time, for example.
The overall issue is that our .listen is just the Node.js .listen. if node.js makes it return a promise than it will here too, and I think that is better for the ecosystem anyway, as I'm sure if having .listen return a promise is useful, then it is useful being in core and not confined to express only.

@dougwilson ok, makes sense
here's the nodejs issue I opened at that time: https://github.com/nodejs/node/issues/21482, will try to expand discussion there so

Basically, I just don't want us to stop returning the http.Server instance, even if there is a callback provided, this is valid code that I've seen in the wild:
const server = app.listen(0, () => {
  console.log(`Listening on ${server.address().port}`)
})

which would break by that.
I'm not sure that promisifying listen is the right approach since it's not actually callback that is passed in, it's an event listener. In http.Server#listen, the function passed won't receive an error if the server fails to listen, and it will be called multiple times if the server emits the listening event more than once.

Right, it is not a callback function. Node.js core has several places where this happens: they take a function as the last arg and just attach that as an event listener and that's it. It is confusing to users because it looks and generally acts like a callback but yet is not one. Usually only callbacks are promisified.


Question about “04_Support_Vector_Machines\04_Working_with_Kernels”

Hi, in 04_svm_kernels.py shows below, I have some questions to need your help, please.

In Line 54, the variable "model_output" seems not to be used in the whole py file, is there missed some codes?
Not very understand on how to calculate the loss function when use the my_kernel. From the code I guess the calculation is  that: my_kernel *(b^T *b) * (y * y^T) ,and then reduce_sum of it.
And the loss equals "reduce_sum(b)- the above result"
So I don't understand why use this formula to get the loss function calculation result. Could you give me some help to understanding the process, please?
"
# Compute SVM Model
54 model_output = tf.matmul(b, my_kernel)
55 first_term = tf.reduce_sum(b)
56 b_vec_cross = tf.matmul(tf.transpose(b), b)
57 y_target_cross = tf.matmul(y_target, tf.transpose(y_target))
58 second_term = tf.reduce_sum(tf.multiply(my_kernel, tf.multiply(b_vec_cross, y_target_cross)))
59 loss = tf.negative(tf.subtract(first_term, second_term))
"

Hi @yingwei13mei ,  thanks for the notice.  You bring up a few points to address.

Yes, the 'model_output' is errant code that has been removed in the most recent pull request.
As for what exactly is going on in the SVM code, you might look into the following resources about SVMs:

http://cs229.stanford.edu/notes/cs229-notes3.pdf
http://www.robots.ox.ac.uk/~az/lectures/ml/lect3.pdf

I created a non-detailed jupyter notebook walkthrough of the code here:
https://github.com/nfmcclure/tensorflow_cookbook/blob/master/04_Support_Vector_Machines/04_Working_with_Kernels/04_svm_kernels.ipynb

Also, if you want to know what is going on in the RBF non-linear kernel calculations, I also created an jupyter walkthrough here:
https://github.com/nfmcclure/tensorflow_cookbook/blob/master/04_Support_Vector_Machines/05_Implementing_Nonlinear_SVMs/05_nonlinear_svm.ipynb
Good luck!


MIDI Implementation and more

make the fasttracker 2 complete and please also implement MIDI output. preferably with a few more functions, such as MIDI CC.
separate tracks audio input (with MIDI out) and output with multi-channel sound cards
live rendering

... I can think of more... I would even pay more for your work!
I think it's great that the FT2 has not been forgotten and is being rebuilt for new technology.
but at the moment I'm working with the old fasttracker 2 because it has MIDI out.

... I think it's great that the FT2 has not been forgotten and is being rebuilt for new technology.
but at the moment I'm working with the old fasttracker 2 because it has MIDI out.

I share your sentiments regarding full MIDI I'm implementation.  But beyond that some of the features might not be welcomed by the developers because of the fact that they are outside of the original functionality and scope of a true original DOS FT2 clone.  But the code is open for forking and there is nothing stopping another development team from taking on the task.   It's not going to be cheap in the ways of man hours though.  Some of those features would require major rewriting of core functionality.
I do agree that it would be wonderful to have parity when it comes to MIDI features though, but it might not ever happen here.    I'm also still using the good old DOS executable for my music projects that require MIDI outputs.

What do you mean by "make the fasttracker 2 complete"? It's a clone of original FT2, and I think it's (kinda) complete as it is. It doesn't try to be a modern full-fledged DAW. That is outside of the project's scope, and there are other alternatives out there for that.
Anyway, MIDI out is not that easy to implement in a realiable and timing-stable way when dealing with high (ish) audio buffer sizes. FT2 on DOS could get away with a smaller audio buffer size because it runs in a realtime OS, but I have heard some people say that MIDI out had some smaller timing precision problems even then. I also do not have a way of testing MIDI out because of no MIDI gear, so yeah, it's not going to happen. Sorry...


Upstream/serializable properties fix

Mentioned in the last comment of #27, the callbacks from ISerializationCallbackReceiver was calling Operation.Serialize() every frame (in editor and playmode) whenever you clicked on a gameobject with SpeckleProperties. I kept the same structure started with #29 but with a couple of added classes that observe the collection and k+v.

@JR-Morgan also, should I push this commit to a different branch? Seems like main is the one you're working with.

Your right, it seems like ObservableDictionary isn't avaiable to .NET Standard 2.0.
It might be possible to add it as a DLL.
The performance improvement might be quite neglegable however, so may not be worth.
I'll do some local testing of this PR over the weekend, and merge to editor2, from there I will merge it into main when it's ready.

Hi @haitheredavid,
Thank you for your patience, I've been caught up on the Unreal side for a while now, so I apologise for being sluggish to propertly review this.
You're right, OnBeforeSerialize is being called every frame while inspected 😱.
I've taken a dive into your changes, and I'm not sure I like how many times the dictionary has to be copied.
Here for example, sd.Data requires a new dictionary to be created each time.
https://github.com/specklesystems/speckle-unity/blob/c3de6a49a8ae6728508df8e70fb34b6ab1b3c78a/Assets/Speckle Connector/ConverterUnity.Geometry.cs#L447-L457
I see you've sort of solved this with the index operator.
https://github.com/specklesystems/speckle-unity/blob/5b07a84709d9922ac861a9e3cab016b12cec0efb/Assets/Speckle Connector/SpeckleProperties.cs#L22-L26
But something like sp.Data.Add(foo, bar) would still not work as expected.
I've done some more digging into ObservableConcurrentDictionary and I've taken a pass at an implementation using it.
I'm interested in getting your thoughts, does this solve everything we want?
I'm thinking that avoiding SpeckleProperties.Data from having to recreate a dictionary offers maximum flexibility, which this gives, while allowing us to perform serialisation smartly.

hi hello @JR-Morgan ! Sorry for taking a bit to get back to you, been away on the honeymoon 🏖, but I'm back in action 🚀.
I like the solution you have developed with #50, it's much cleaner 🧹 than what I had put together. It seems like this solution does what we want it to do. I also want to note that I haven't utilized  properties to much within unity so I might not have a well rounded perspective on how I would want them to work in untiy, but it seems like it works and gets the job done 😸.
The one thing that might be a helpful quality of life thing would be integrating a simple KVP look up for the object data. Similar to what threw together in this pr.
 public object this[string key]
 {
   get => _data[key];
   set => _data[key] = value;
 }

Hi David!,
I hope you enjoyed your honeymoon! Congrats. 😁
I think I'll go ahead and merge #50 now.
We can consider adding some quality of life methods later I think, that's not a bad suggestion.
I'll try and take a look at your #53 #54 PRs soon, but I have some other higher priorities,
Thank you for your contributions, and your patience!

@JR-Morgan thanks! As I mentioned in my last post, this feature is not something I typically rely on within unity at the moment. I would rather see support for (#56 )Kits and Converters as not having access to this in the unity package is major blocker (at least for me!).


Remove lazy loading of alert text animation to fix articles bug

Alert text wouldn't show on articles. Lazy load logic was biased to the DN highlight page.


Problem with uploadFile on openVMS server

**FTP OS:
**FTP Server: OpenVMS
**Computer OS: windows 10
<if the remotePath is "/"+File name, this file is upload but the name is prefixed with an "_"
if the remotePath is ""+ file name or anything + file name  the method returns syntax error (see logs)>
Logs :
# Connect()
Status:   Connecting to ***:21
Response: 220 ******* FTP Server (Version 5.3) Ready.
Command:  USER ***
Response: 331 Username ******requires a Password
Command:  PASS ***
Response: 230 User logged in.
Command:  FEAT
Response: 502 FEAT is unimplemented.
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 200 VMS OpenVMS V7.3 on node ********.
Status:   Detected FTP server: OpenVMS
Status:   Auto-detected VMS listing parser

# UploadFile("E:\Release\exportFTP\73000023.RES", "\73000023.RES", Overwrite, False, None)

# FileExists("\73000023.RES")

# GetNameListing("/")
Command:  TYPE I
Response: 200 TYPE set to IMAGE.

# OpenPassiveDataStream(AutoPassive, "NLST /", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||63414|)
Status:   Connecting to ***:63414
Command:  NLST /
Response: 150 Opening data connection for / (<IP_ADDRESS>,65047)
Status:   Disposing FtpSocketStream...

# CloseDataStream()
Response: 226 NLST Directory transfer complete
Status:   Disposing FtpSocketStream...

# OpenWrite("\73000023.RES", ASCII)
Command:  TYPE A
Response: 200 TYPE set to ASCII.

# OpenPassiveDataStream(AutoPassive, "STOR /73000023.RES", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||63415|)
Status:   Connecting to ***:63415
Command:  STOR /73000023.RES
Response: 150 Opening data connection for FTP_DEFAULT:[WAGN_IN]_73000023.RES; (<IP_ADDRESS>,65048)
Status:   Disposing FtpSocketStream...
Response: 226 Transfer complete.

# Dispose()
Status:   Disposing FtpClient object...
Command:  QUIT
Response: 221 Goodbye.
Status:   Disposing FtpSocketStream...
Status:   Disposing FtpSocketStream...

# Connect()
Status:   Connecting to ***:21
Response: 220 ******* FTP Server (Version 5.3) Ready.
Command:  USER ***
Response: 331 Username ***** requires a Password
Command:  PASS ***
Response: 230 User logged in.
Command:  FEAT
Response: 502 FEAT is unimplemented.
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 200 VMS OpenVMS V7.3 on node *******.
Status:   Detected FTP server: OpenVMS
Status:   Auto-detected VMS listing parser

# UploadFile("E:\Release\exportFTP\73000025.RES", "73000025.RES", Overwrite, False, None)

# FileExists("73000025.RES")

# GetWorkingDirectory()
Command:  PWD
Response: 257 "FTP_DEFAULT:[WAGN_IN]" is current directory.

# GetNameListing("FTP_DEFAULT:[WAGN_IN]")

# GetWorkingDirectory()
Command:  PWD
Response: 257 "FTP_DEFAULT:[WAGN_IN]" is current directory.
Command:  TYPE I
Response: 200 TYPE set to IMAGE.

# OpenPassiveDataStream(AutoPassive, "NLST FTP_DEFAULT:[WAGN_IN]/FTP_DEFAULT:[WAGN_IN]", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||63435|)
Status:   Connecting to ***:63435
Command:  NLST FTP_DEFAULT:[WAGN_IN]/FTP_DEFAULT:[WAGN_IN]
Response: 550 file specification syntax error
Status:   Disposing FtpSocketStream...

# CloseDataStream()

# Dispose()
Status:   Disposing FtpClient object...
Command:  QUIT
Response: 221 Goodbye.
Status:   Disposing FtpSocketStream...
Command:  STOR /73000023.RES
Response: 150 Opening data connection for FTP_DEFAULT:[WAGN_IN]_73000023.RES; (<IP_ADDRESS>,65048)
Status:   Disposing FtpSocketStream...
Response: 226 Transfer complete.

# Dispose()
Status:   Disposing FtpClient object...
Command:  QUIT
Response: 221 Goodbye.
Status:   Disposing FtpSocketStream...

# Connect()
Status:   Connecting to ***:21
Response: 220 ******* FTP Server (Version 5.3) Ready.
Command:  USER ***
Response: 331 Username ***** requires a Password
Command:  PASS ***
Response: 230 User logged in.
Command:  FEAT
Response: 502 FEAT is unimplemented.
Status:   Text encoding: System.Text.ASCIIEncoding
Command:  SYST
Response: 200 VMS OpenVMS V7.3 on node ********.
Status:   Detected FTP server: OpenVMS
Status:   Auto-detected VMS listing parser

# UploadFile("E:\Release\exportFTP\73000026.RES", "./73000026.RES", Overwrite, False, None)

# FileExists("./73000026.RES")

# GetWorkingDirectory()
Command:  PWD
Response: 257 "FTP_DEFAULT:[WAGN_IN]" is current directory.

# GetNameListing("FTP_DEFAULT:[WAGN_IN]")

# GetWorkingDirectory()
Command:  PWD
Response: 257 "FTP_DEFAULT:[WAGN_IN]" is current directory.
Command:  TYPE I
Response: 200 TYPE set to IMAGE.

# OpenPassiveDataStream(AutoPassive, "NLST FTP_DEFAULT:[WAGN_IN]/FTP_DEFAULT:[WAGN_IN]", 0)
Command:  EPSV
Response: 229 Entering Extended Passive Mode (|||56097|)
Status:   Connecting to ***:56097
Command:  NLST FTP_DEFAULT:[WAGN_IN]/FTP_DEFAULT:[WAGN_IN]
Response: 550 file specification syntax error
Status:   Disposing FtpSocketStream...

# CloseDataStream()

# Dispose()
Status:   Disposing FtpClient object...
Command:  QUIT
Response: 221 Goodbye.>

3rd time I'm fixing this. Used a proper Regex implementation now. Hope it solves this.
Released in https://www.nuget.org/packages/FluentFTP/25.0.6

Hello,
Big thanks for the fix. It’s working now.
De : Robinicks<EMAIL_ADDRESS>Envoyé : jeudi 11 juillet 2019 13:52
À : robinrodricks/FluentFTP
Cc : JACQUES Benoit; Author
Objet : Re: [robinrodricks/FluentFTP] Problem with uploadFile on openVMS server (#424)
3rd time I'm fixing this. Used a proper Regex implementation now. Hope it solves this.
Released in https://www.nuget.org/packages/FluentFTP/25.0.6https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nuget.org%2Fpackages%2FFluentFTP%2F25.0.6&data=02|01|benoit.jacques%40preciamolen.fr|f39d148003824a06d23908d705f633f5|9281c83e132c4ab8be8034517d7a5b70|0|0|636984427314208457&sdata=Y%2Bi0rFuux0e29ErL%2FKCeiE1AtRphWoKLtIaLl1Ou%2BvU%3D&reserved=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobinrodricks%2FFluentFTP%2Fissues%2F424%3Femail_source%3Dnotifications%26email_token%3DAMRBX2AUFP4XYGXNTO4R6G3P64NGPA5CNFSM4H6ZV752YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZWOQNY%23issuecomment-510453815&data=02|01|benoit.jacques%40preciamolen.fr|f39d148003824a06d23908d705f633f5|9281c83e132c4ab8be8034517d7a5b70|0|0|636984427314208457&sdata=xirC46GkcBndtOszBaRXdKmjxJ4FU9T8d%2Fq1GqbTUMc%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMRBX2F7U4OJSSLM2M6DXKLP64NGPANCNFSM4H6ZV75Q&data=02|01|benoit.jacques%40preciamolen.fr|f39d148003824a06d23908d705f633f5|9281c83e132c4ab8be8034517d7a5b70|0|0|636984427314218465&sdata=W7wD045EOYqWaK95uQdBUTWhXho4MKcqwZwnLzqsQAY%3D&reserved=0.

Released in 26.0.0.
https://www.nuget.org/packages/FluentFTP/26.0.0


TOOL: Make top menu bar texts bigger

User Story
As a user in DJ, I want the top-menu bar text size to be consistently the same size as all other text in the platform
Tasks

[ ] Make top menu bar text bigger

Acceptance Criteria
When the top menu bar buttons are more clear to users.

@HasanSifat
Menu font size change to Websites' default value. It is slightly bigger than the previous one. Changes are available on both DEV and TEST. (Hard refresh is required to see the change)

@bhumin-fw after discussion with the program team, We want the font size to go up another 2-3 levels.

@HasanSifat for sure, Increased font size to 3 levels. Changes Deployed to DEV and TEST.

@bhumin-fw  I see the changes in dev but not test, the text is still small in test

Dev in comparison -

Test env has large menu font  (Forms, Draft Forms...) than the current Prod env.  The larger text size looks great compared to the prior prod, smaller text size.
Test env large menu size all good   - Confirmed.


Missing ground on L8/L9

In the input filter, the ground connection is missing between the L8 and L9.
Found this by review of the schematic, for use in the fork https://github.com/uhi22/foccci
Want to mention just in case someone uses the project as base for further development.

Update: The "missing" ground connection was most likely by intend. Because when grounded, the L8 and L9 will short the DC bias (1.6V) to ground, and this blocks the input amplifier of the QCA from working. So the conclusion is: use the original design with the NOT grounded L8 and L9, or as second option, ground the L8 and L9, and add additional series capacitors directly at the RX pins of the QCA.

Closing.


Add a conditional compilation flag to verify token choices

Verification of token choice is currently causing assertion failures where the list of expected token choices in the syntax tree doesn't match those the parser generates.
I’d still like to get the verification code into main so I can conditionally enable it locally while working on the issues, so add it behind a conditional compilation flag.

@swift-ci Please smoke test

@swift-ci Please test

@swift-ci Please test


⚠ Bofrost.at has degraded performance

In bcdd9e3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1852 ms

Resolved: Bofrost.at performance has improved in 952ac84 after 9 minutes.


add typing with mypy

Implementation notes:

Didn't import types individually, used import typing as _t to shorten things.
Common types are aliased in a if TYPE_CHECKING: block and referenced as string names.
Only a few types (really just str_bytes) were common between modules, didn't bother with a common _typing module.
All generics that aren't in the common block are strings to avoid runtime cost. This won't be necessary once we drop 3.6.
The return_timestamp parameter of TimestampSigner.unsign changes the return type. To distinguish these, @overload is used, but because the method takes some other optional parameters, many overloads are needed to cover every combination. I added the overloads that matter, as mypy does use that to figure out a type elsewhere, but ignored the finding about incompatible overlap.
Flake8 has a special case so @typing.overload doesn't trigger a redefinition error, but it has to be literally typing.overload, _t.overload isn't recognized. So had to ignore that Flake8 finding.
Mypy doesn't allow assignment of modules or classes for Protocol, so Serializer.serializer has the Any type for now. See https://github.com/python/mypy/issues/5018.

Findings and future work:

TimedSerializer.loads and loads_unsafe have incompatible signatures with Serializer.loads because extra parameters were added before the salt parameter. This violates the Liskov substitution principle, and should probably be migrated with *args and a deprecation warning at some point. I added a TODO in the code.

Between removing Python 2 compat helpers and adding typing, I'm more convinced that accepting bytes and str interchangeably everywhere is not good. Python 3 emphasizes understanding the boundary between the two.
Because pretty much every single point in the ItsDangerous API accepts either, want_bytes is called over and over again, even where it's redundant because an earlier function already called it. I already moved wants_bytes around to get a few spots that were missed. This isn't a huge deal in ItsDangerous, but it's probably hurting performance in Werkzeug where it happens much more often.
It's still probably useful to accept both as the data passed to Serializer.loads, Signer.sign, and Singer.unsign, since you might be signing either bytes or text, and received data to be loaded might be bytes or text (ASGI vs WSGI, for example). Everything else should probably be bytes only since that's how they're used.

Todo for draft:

Add typing to tests.
Stricter Mypy configuration.
Cache .mypy_cache in CI.

cc @pgjones

Oh, looks like that comment wasn't needed???

Moving the docs discussion out of review. It seems that Sphinx autodoc relies on typing.get_type_hints(), which fails since the aliases are guarded in a TYPE_CHECKING block. That was me just experimenting with forward references before we drop 3.6, but I don't have to do that, I'll change it to use runtime annotations.

The parameter annotations look really messy:

I think we should have the aliases (e.g. for Union[bytes, str] and the like) but they should be given more intelligible names (such as "StrOrBytes" or something similar) rather than "_t_str_bytes" which is harder to understand.
My guess is that the use of a secret key shows up in multiple places (I confess I have limited understanding of this library) so perhaps creating an alias to be used universally would be useful?

The _t_ prefix is there for the same reason I used import typing as _t, to use a short name and keep everything related to types organized under it. The name is only referenced internally, it's not for public consumption.

Didn't import types individually, used import typing as _t to shorten things.

I'd argue that the types are public because they show up to people using them in development. Keeping a distinction sounds good though.

The typing information is public in that it's now available when a project uses a type checker, but the exact aliases we used aren't. If there was some alias that we expected users to use in their own code, then we would make it a public name. For example, the argument to Flask.make_response would be a publicly importable alias.

Sphinx 3.0 added autodoc_typehints = 'description' which looks much nicer than 'signature'. Still messy for long types, but better organization.

Just in case, does https://github.com/agronholm/sphinx-autodoc-typehints help with anything here?

I saw it but didn't try it. `autodoc_typehints = 'description' seems to do the same thing and is built-in now.

Since we were asking about it, I tried replacing the Union[str, bytes] with AnyStr, but it failed. The problem is that a TypeVar is collapsed to a single type that all other uses of it in the same context must match, and that's too strict for what ItsDangerous does. Unfortunately, when you do have something that uses AnyStr, Mypy doesn't recognize it as valid to pass to Union[str, bytes]. No clue what to do about that. Hey look, I ran across Teymour's question about it :sweat_smile: https://stackoverflow.com/questions/62673777/how-to-pass-a-value-of-type-unionbytes-str-to-function-taking-anystr
I'm trying to add types to the tests, but it's fairly frustrating as I do a lot of little weird things in the tests. For example, even if you annotate serializer: Serializer, Mypy thinks it doesn't have a signer` attribute, even though that's annotated and works elsewhere. I have been thinking of writing a more flat test layout that doesn't rely on class fixtures and patching so much, maybe this is an indication that's a good idea. I'll try a bit more on the tests then just add ignores for now.

I think it's a bug in mypy. There's a few of them in mypy which have been around for a really long time (the inability to make typed NamedTuple's generic is another one).
Hopefully they'll fix them 🤞🏼 – fixing them seems a bit beyond me at the monent 😄.

I ignored the jws module since it's deprecated, and configured tests to check untyped functions without requiring types.

Here's an example of the docs: https://itsdangerous.palletsprojects.com/en/master/serializer/#itsdangerous.serializer.Serializer


instead of circles, there are boxes

I installed all the necessary dependencies and such, and yet this happens:

arch linux btw

Same happened to me, but it was a problem with the shader not compiling properly because my machine is very old so it uses and old version of opengl too. So it couldn't compile the shaders. So i downgrade the shaders to use version 1.20 like
// circle.fs
#version 120

// Input vertex attributes (from vertex shader)
varying vec2 fragTexCoord;
varying vec4 fragColor;

// Output fragment color
vec4 finalColor;

void main()
{
    float r = 0.07;
    vec2 p = fragTexCoord - vec2(0.5);
    if (length(p) <= 0.5) {
        float s = length(p) - r;
        if (s <= 0.0) {
            finalColor = fragColor * 1.5;
        } else {
            float t = 1.0 - s / (0.5 - r);
            finalColor = mix(vec4(fragColor.xyz, 0.0), fragColor * 1.5, t*t*t*t*t);
        }
    } else {
        finalColor = vec4(0.0);
    }
    gl_FragColor = finalColor;
}

// smear.fs
#version 120

// Input vertex attributes (from vertex shader)
varying vec2 fragTexCoord;
varying vec4 fragColor;

// Output fragment color
vec4 finalColor;

void main()
{
    float r = 0.3;
    vec2 p = fragTexCoord - vec2(0.5);
    if (length(p) <= 0.5) {
        float s = length(p) - r;
        if (s <= 0.0) {
            finalColor = fragColor * 1.5;
        } else {
            float t = 1.0 - s / (0.5 - r);
            finalColor = mix(vec4(fragColor.xyz, 0.0), fragColor * 1.5, t*t*t);
        }
    } else {
        finalColor = vec4(0.0);
    }
    gl_FragColor = finalColor;
}

after that it worked. So maybe it's your problem too :)

Btw, raylib examples use several versions of shader simultaneously and pick the right version at the runtime. Maybe we should do the same...

Yaaaa it shouldn't be that hard to do, so it makes sense...

I installed all the necessary dependencies and such, and yet this happens:

arch linux btw

Now is fixed

This also seems to happen if you run musializer from the build/ directory instead of the root directory, because the shaders are loaded from a path relative to the root (and you get a file not found if you don't run it this way or manually move the shaders).

In the end, the problem (for me at least) was user error. I feel quite silly. I was running from the build directory :P

@artistic-hacktivist thanks for letting me know anyway! It may count as a usability issue, that I took a note of.


Smoke test for Docfx v3

Docs Build status updates of commit 23967d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/SmokeTest.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Vijay, Siva | Sample list of SNOMED procedure orders

Curated list of Procedure orders

This looks good to me.


Reduce log level for production to :info

:debug is too high for a production environment – We don't want SQL
queries being logged in the production environment as they could contain
sensitive information.

Rebasing...


Reopen button exist when user can’t

The Issue reopening button exists even though the user can’t reopen. When the user touches the button, it shows a cryptic error about API fails.(Well, the apps are targeted to devs so it might not be that cryptic?)
Sent with GitHawk

Hi, what’s the exact error message you’re seeing, and in what issue or pull request?
Sent with GitHawk

@BasThomas Any Issue that the user opened(and closed) in a repo that the user doesn’t have write access to.
The error message is something like:
The operation couldn’t be completed. (GitHubAPI.ResponseError error 0)

The meaning of cryptic in my comment was that the error message doesn’t mention anything about not having write access. It would be better if it had a better error message or if it didn’t show the blue button (FAB?) if the user doesn’t have write access.
A screenshot of this: (if the picture expires, please ping me :-))
Screenshot
(BTW, the error popup really doesn’t go together with the UI. What about displaying error messages at the top like FB Messenger?)
Sent with GitHawk

Thanks for the info. We should definitely check this logic again.

(BTW, the error popup really doesn’t go together with the UI. What about displaying error messages at the top like FB Messenger?)

I think we had this before the iPhone X and moved to a toast to prevent some edge cases with notch-equipped devices.


Import modules, hiding symbols

closes #17.
Works quite well in manual tests.
However, I am unsure about the command line arguments.
Currently, only either import list or hiding can be used. E.g. if a -s and -e flag is given, -s will win and only an import-list will be used. Using both doesn't make sense though, so maybe this never happens?
Also, we probably should reuse the SymbolImport for hiding and import lists, since actually, they can do the same, in my opinion. Therefore, I am proposing adding two separate Datatypes newtype ImportList = ImportList SymbolImport and newtype HidingList = HidingList SymbolImport instead of adding an additional constructor that some functions care about and some dont.

[x] Cleanup code.
[x] Write tests.

Thanks!
I think I would prefer just a ˋ—hidingˋ, ˋ-Hˋ bool argument, then the ˋ-sˋ can be reused.
It should be only allowed to use one of ˋ—allˋ, ˋ—withˋ or ˋ—hidingˋ at once.
I don‘t see the need for additional data types beyond ˋSymbolImportˋ. If a function
only cares about one data constructor, then it should just get as argument the data
of the data constructor instead of a ˋSymbolImportˋ.

Now almost everything can be reused! I renamed some functions a bit to improve naming.
However, I dont understand how to write the tests correctly for this. A few pointers?

On Wed, May 29, 2019 at 06:59:33AM -0700, fendor wrote:

However, I dont understand how to write the tests correctly for this. A few pointers?

You can extend the symbolTests in tests/Main.hs e.g.:
test "SymbolTest33" $ HI.defaultArgs { HI.moduleName = "Control.Foo", HI.hiding = True, HI.symbolName = "foo" }

Now you need a new input file for the test in tests/inputFiles/SymbolTest33.hs e.g.:
module Test where

And a reference file for the test in tests/goldenFiles/SymbolTest33.hs e.g.:
module Test where
import Control.Foo hiding (foo)

From: Daniel Trstenjak<EMAIL_ADDRESS>To: dan-t/hsimport<EMAIL_ADDRESS>Thinking about it, I would prefer to have the hiding argument in
the SymbolImport' instead of the ModuleImport`:
data Symbol
   = Only Name
   | AllOf Name
   | SomeOf Name [Name]

data SymbolImport
   = Import Symbol
   | Hiding Symbol

I think this also simplifies the code in ImportChange.hs, by
not having to pull the hide out of the ModuleImport and
removes the need for an additional function parameter.
----- End forwarded message -----

And then renaming SymbolImport to SymbolChange makes it a bit more clear.

I added some tests to verify the behaviour.


ng-file-upload wont upload with header

everytime I add header to ng-file-upload, image upload 100% but wont upload to server
file.upload = Upload.upload({
	url: 'http://localhost/server/upload.php',
        headers: {
			   'Accept':  "*/*",
	                   'Content-Type': '*/*',
		           'X-Access-Token': 'eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9._B_0ymCSWvdY',
			   'X-Key'<EMAIL_ADDRESS>
		     },
	data: {username: $scope.username, file: file},

});

You should not set the content-type it must stay multipart/form-data. Remove that line.


docker-compose.yml in demo is not working for 3.0.6

The reason is that genie-demo-apache does not have a public 3.0.6 tag in the docker hub.
Changing the composer to use 3.0.5 composes fine.

Thanks @ronhash10. We were aware of this as the release build for 3.0.6 was done too early and it failed at the docker container build stage before it was caught (and the binaries were already released so we couldn't redo it). We'll be pushing 3.0.7 once we get a few more bug fixes in that should resolve this.

3.0.7 is being released now and build should work to fix the demo.


Update manifest and add test that manifest matches function signature

Closes #11

@fstur The script for updating the manifest was working, I just forgot to git pull the main branch 🙈
Now we have tests included to check that the manifest matches function docstrings & all arguments are present. If those tests fail, just rerun the new_args_schema.py script in src/fractal_faim_hcs/dev => updates the manifest


2.0 Performance Regression in creation of Pipelines

What happened?:
In the automated go test: TestAutoscalingStandby/ChainOf10, we had to bump up the wait period to get 10 pipelines created and in Standby mode from 30 seconds to 120 seconds
What you expected to happen?:
How to reproduce it (as minimally and precisely as possible)?:
Execute TestAutoscalingStandby/ChainOf10
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):
Pachyderm CLI and pachd server version (use pachctl version):
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):
OS (e.g. from /etc/os-release):
Others:

FYI @nitinjainsj . I don't think this is of very high priority since the use case is just setting up a bunch of Pipelines at once. What do you think?


V1 Entity Data Panel

Adds entity data panel in pipelines folder. Core ideas

Data panel that has zero or more embedding columns
Data panel has index panel for functions like iget and icontains for the unique entity id
Supports appending, from_datapanel, and other data panel methods
Supports embedding based functions (e.g., cosine nearest neighbors) that returns the metadata.

Codecov Report

Merging #48 (85fed5b) into dev (fce9cac) will increase coverage by 1.58%.
The diff coverage is 82.85%.

@@            Coverage Diff             @@
##              dev      #48      +/-   ##
==========================================
+ Coverage   62.71%   64.30%   +1.58%
==========================================
  Files          45       46       +1
  Lines        2336     2465     +129
  Branches      410      439      +29
==========================================
+ Hits         1465     1585     +120
+ Misses        767      766       -1
- Partials      104      114      +10

Flag
Coverage Δ

unittests
64.30% <82.85%> (+1.58%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mosaic/columns/numpy_column.py
81.65% <0.00%> (+0.74%)
:arrow_up:

mosaic/columns/tensor_column.py
81.05% <50.00%> (+0.84%)
:arrow_up:

mosaic/datapanel.py
76.00% <66.66%> (+0.38%)
:arrow_up:

mosaic/columns/embedding_column.py
71.69% <69.23%> (+14.12%)
:arrow_up:

mosaic/pipelines/entity.py
87.96% <87.96%> (ø)

mosaic/columns/list_column.py
88.57% <0.00%> (+5.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce9cac...85fed5b. Read the comment docs.

Looks great! Small change to improve clarity: renaming Entity -> EntityDataPanel.
This PR is good to merge after that, but we should discuss how to support this use case better in the base DataPanel class and how this relates to other embedding use cases (reading your code makes me think this can be applied to a lot more beyond entities).
Eventually, it would be nice if we could transition this class to a more functional API (e.g. mosaic.embedding) that relies on the standard DataPanel + move the more generic methods you've added into the DataPanel class. I'm particularly curious if you think there are reasons why this may not be a good idea (just to understand this better myself).
Another request: if we can get a small Colab for this that shows this off, it might help us understand more quickly which of your ideas can be moved up into the base class as well + share this more widely.


Issue 73: Added info on setting up frontend to README.md

For issue 73, added information on how to set up the frontend to README.md.

@ash-tamraz thanks for the PR! I'll take a look tomorrow.

@ash-tamraz looks great! Go ahead and merge :)


MERN_MongoDB: 5.1 Mongoose Introduction and Installation

Description
All about Mongoose

What is mongoose and its need.
Explain how to install mongoose.

Project Directory
Branch MERN>MERN/Topic/Backend/MongoDB/
Name the file as 5.1_Mongoose_Introduction_and_Installation.md
Domain
MERN
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign


InputNumber样式优化

InputNumber样式优化

Coverage remained the same at 50.943% when pulling 176b240398c87f8a45c8b02a0dbd92e84fffd939 on sw811:master into a75800689fcb089326a22cf09bc97f79c2bd6a29 on ecomfe:master.


Session changes on other devices replaces state on local device

If I am logged in on device A and device B.

Device B logs out
Device A gets the logout event and replaces whole state with the ended session from Device B

(It of course also triggers on more cases, like when you are on logged in on Device A and a device B logs in)
https://github.com/react-appwrite/react-appwrite/blob/8f6b7284bc3152d98b9b2320792d88fba79542ec/src/account/useAccount.ts#L45
Edit: Just realized also that you probaby expect a UserObject in that set, but session changes payload is a SessionObject. So it's the wrong kind of data

It also breaks useTeams since it is dependent on useAccount

Ah, yeah I see what you mean. Good catch. I'm looking into this.


Graphback as Codegen plugin

Motivation
In graphql cli now we have generate and codegen plugins for graphql-config
Generate works with graphback data, Codegen does typesafe code generation.
This is very confusing. Ideally, we should be able to have one generator as part of the codegen.
Graphback itself has different requirements than codegen.
Each generator can produce multiple files and affect schema.
With architecture of the codegen plugin it is very challenging to fit graphback into plugin.
We are now in process of rewriting our generators to support transformations #639
This will allow us to simplify entire processing. Our input will be always model schema.
Challenge 1
Schema specified in graphql config needs to be generated by graphback first. This brings the chicken or egg problem.
To resolve that I think it will be just easier to have model schema as plugin config and read it inside. Create Codegen plugin that will create schema in some specified location from model file. We can output schema into schema filter specified in config (as long it is filesystem location).
Challenge 2
Plugins always return strings that is piped to file.
This means that we are restricted to this simple use case where each plugin we have can do multiple files and even append etc. Presets do not fit to that model.
Idea
Create plugin as wrapper that will accept model as config value and build it itself and always return schema DSL as string. The plugin however under the hood will create multiple files like resolvers etc . We could have separate plugin for database migrations in this case as they will be working with the entire schema.

Our plugins can be now adapted to codegen (All work in graphback is now done).
We will follow up with the work on graphql-cli to finalize it.
We also using GraphQL-Config in the core and also made it simple to build CLI commands from graphback core thus simplifying entire graphql-cli integration


refactor: remove DTOs from management-api

What this PR changes/adds
Remove all the DTOs from the management api (except one that's deprecated and it will exists until /v2/assets endpoint does.
Why it does that
cleanup
Further notes

this PR is based on #3306, do not merge before

Linked Issue(s)
Closes #3267
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Codecov Report
Patch coverage: 71.17% and project coverage change: -0.28 :warning:

Comparison is base (112ade7) 71.63% compared to head (d9c463d) 71.35%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3309      +/-   ##
==========================================
- Coverage   71.63%   71.35%   -0.28%
==========================================
  Files         831      806      -25
  Lines       16681    16403     -278
  Branches      953      951       -2
==========================================
- Hits        11949    11705     -244
+ Misses       4336     4303      -33
+ Partials      396      395       -1

Impacted Files
Coverage Δ

.../eclipse/edc/validator/jsonobject/JsonWalkers.java
76.92% <0.00%> (-7.70%)
:arrow_down:

.../java/org/eclipse/edc/api/model/ApiCoreSchema.java
0.00% <0.00%> (ø)

...eclipse/edc/api/validation/CriterionValidator.java
88.23% <0.00%> (ø)

...lipse/edc/api/validation/DataAddressValidator.java
75.00% <0.00%> (ø)

.../management/configuration/ManagementApiSchema.java
0.00% <0.00%> (ø)

...sform/JsonObjectToAssetEntryNewDtoTransformer.java
77.77% <ø> (ø)

...dc/connector/api/management/asset/v3/AssetApi.java
0.00% <0.00%> (ø)

...c/connector/api/management/catalog/CatalogApi.java
0.00% <0.00%> (ø)

...ment/contractdefinition/ContractDefinitionApi.java
0.00% <0.00%> (ø)

...nt/contractnegotiation/ContractNegotiationApi.java
0.00% <0.00%> (ø)

... and 26 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


chore: release 0.18.1

:robot: I have created a release *beep* *boop*
0.18.1 (2021-06-05)
Bug Fixes

fix an issue of highlighting in code blocks (3378b9c), closes #92

This PR was generated with Release Please. See documentation.

Coverage remained the same at 78.231% when pulling 4d512b092bbadecd27e376c6732a3c09b13d5d13 on release-v0.18.1 into f11bb76f9bface7bc500a15d55f88000ae65d89f on master.

:robot: Release is at https://github.com/easyops-cn/docusaurus-search-local/releases/tag/v0.18.1 :sunflower:


Please add KDD 2019 paper, data, code

Hi!
Thank you for this awesome repository!
Could you please add the following paper, code, and data link to the repository:
Paper: Predicting Dynamic Embedding Trajectory in Temporal Interaction Networks
Authors: Srijan Kumar, Xikun Zhang, Jure Leskovec
Venue: ACM SIGKDD 2019 (Proceedings of the 25th ACM SIGKDD international conference on Knowledge discovery and data mining)
Project page: http://snap.stanford.edu/jodie/
Code: https://github.com/srijankr/jodie/
All datasets: http://snap.stanford.edu/jodie/
Many thanks,
Srijan

Hi there, Is this a node level embedding paper?

Yes!

This repository covers graph level problems (e.g. DiffPool, Graph2Vec
etc.). However, there are another repos (one of them with way more stars)
maintained by some lovely people that work at the node level:
https://github.com/chihming/awesome-network-embedding
https://github.com/naganandy/graph-based-deep-learning-literature
On Tue, 16 Jul 2019 at 02:58, srijankr<EMAIL_ADDRESS>wrote:

Yes!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/benedekrozemberczki/awesome-graph-classification/issues/5?email_source=notifications&email_token=AEETMFYEWGVF4WEADHMSD5DP7UTM7A5CNFSM4IDTKJGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7OUGY#issuecomment-511633947,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEETMF2P2AWUQENPLWR6M7DP7UTM7ANCNFSM4IDTKJGA
.


Fix drawer scrolling to top when opened

Fixes #546
100% height causes the page content to jump back to the top, regardless of scroll position. We've used this updated code on Brooklyn and it works well.

This is consistent with what we do in Marketing Assets as well: https://github.com/Shopify/marketing_assets/blob/af347646becb2675ca10a9e46d37148a1c179d07/app/assets/stylesheets/marketing_assets/modules/_drawer.scss#L173-L174
👍

👍

thanks!


Git page setting

This would provide a link to the git page in vc the current page to encourage awareness or contribution. This should be a global site level setting

up to theme developers to implement but https://www.youtube.com/watch?v=58heffz5qWQ shows it now in haxor-slevin (build running)


EnvelopeEvent is not showing any data

EnvelopeEvent is not showing any data, only working on version TikTokLive==4.3.8 for what I can tell.
Not giving an error message that I can capture either.
Tried on Windows 10, python 3.7 and 3.11

Pretty sure last working version was Version: 4.5.2 so maybe something after that broke it :)

Pretty sure last working version was Version: 4.5.2 so maybe something after that broke it :)

Would have been updated due to a TikTok proto change. Will look into fixing in newest version.

Gonna close this for now.
Falls under https://github.com/isaackogan/TikTokLive/issues/157 & will be fixed.


http://soap.sforce.com/ is not available

After adding and updating a bunch of npm dependencies to get the server working, when I visit localhost:8085 (as suggested by the server instead of localhost:8080) the page renders with a spinner that never stops spinning.
Inspecting the console, there are all 10 errors which trace back to failures to load resources from soap.sforce.com, which does not seem reachable.
Typical errors look like:

logger.service.ts:49 Error: No operation available for request {http://soap.sforce.com/schemas/package/AngularAppController}executeQuery, please check the WSDL for the service.(…)LoggerService.error @ logger.service.ts:49
2016-11-25 21:05:19.087 logger.service.ts:49 Error: No operation available for request {http://soap.sforce.com/schemas/package/AngularAppController}executeQuery, please check the WSDL for the service.(…)LoggerService.error @ logger.service.ts:49

(I don't know if this is a personal problem or a temporary problem.)
Please, let me know if you need further information.

I resolved this by doing a gulp deploy, because the AngularAppController DNE in salesforce yet.


README.md: update with link to bill of materials

update to README

@DavidPHirsch modify your commit message with the prefix docs:
So as to pass the commit compliance check


Binding applications requires to compare the external export prefix

In the DM...
if( ! app.getTemplate().getName().equals( applicationTemplateName ))
			throw new UnauthorizedActionException( "Application " + applicationName + " is not... " );

... is wrong.
applicationTemplateName should in fact be the external export prefix.

Invalid location, this bug is about the platform.


IAP scanner will fail if the network property of instanceGroup is empty

2018-08-20 20:05:53,579 INFO [forseti-security] google.cloud.forseti.scanner.scanners.iap_scanner(_find_violations): Finding IAP violations with <google.cloud.forseti.scanner.audit.iap
_rules_engine.IapRulesEngine object at 0x7f125c1a8550>...
2018-08-20 20:05:54,110 ERROR [forseti-security] google.cloud.forseti.scanner.scanners.iap_scanner(instance_group_network_port): NetworkPort can not be constructed. Unable to find the
appropriate port from backend service or instance group.
2018-08-20 20:05:54,463 ERROR [forseti-security] google.cloud.forseti.scanner.scanners.iap_scanner(instance_group_network_port): NetworkPort can not be constructed. Unable to find the
appropriate port from backend service or instance group.
2018-08-20 20:05:54,463 ERROR [forseti-security] google.cloud.forseti.scanner.scanners.iap_scanner(instance_group_network_port): NetworkPort can not be constructed. Unable to find the
appropriate port from backend service or instance group.
2018-08-20 20:05:54,463 ERROR [forseti-security] google.cloud.forseti.scanner.scanners.iap_scanner(instance_group_network_port): NetworkPort can not be constructed. Unable to find the
appropriate port from backend service or instance group.
2018-08-20 20:05:54,689 ERROR [forseti-security] google.cloud.forseti.scanner.scanner(run): Error running scanner: IapScanner
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanner.py", line 112, in run
scanner.run()
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 634, in run
all_violations, _ = self._find_violations(iap_data)
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 619, in _find_violations
for (iap_resources, project_resource_counts) in iap_data:
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 602, in _retrieve
run_data.make_iap_resource(backend, parent.full_name))
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 321, in make_iap_resource
if self.is_alternate_service(backend_service, backend_service2):
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 361, in is_alternate_service
backend_service2, instance_group2)
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 140, in instance_group_network_port
project_id=instance_group.project_id),
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.1.0-py2.7.egg/google/cloud/forseti/common/gcp_type/network.py", line 64, in from_url
if '://' not in url:
TypeError: argument of type 'NoneType' is not iterable

Updated stacktrace when running iap scanner
google.cloud.forseti.scanner.scanner(run): Error running scanner: IapScanner Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanner.py", line 113, in run scanner.run() File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 635, in run all_violations, _ = self._find_violations(iap_data) File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 620, in _find_violations for (iap_resources, project_resource_counts) in iap_data: File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 603, in _retrieve run_data.make_iap_resource(backend, parent.full_name)) File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 291, in make_iap_resource backend.get('group')) File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 152, in find_instance_group_by_url target_key = instance_group_type.Key.from_url(instance_group_url) File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/common/gcp_type/instance_group.py", line 195, in from_url url) File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.8.0-py2.7.egg/google/cloud/forseti/common/gcp_type/key.py", line 104, in _from_url path_components = urlparse.urlparse(url)[2].split('/')[3:] File "/usr/lib/python2.7/urlparse.py", line 143, in urlparse tuple = urlsplit(url, scheme, allow_fragments) File "/usr/lib/python2.7/urlparse.py", line 182, in urlsplit i = url.find(':') AttributeError: 'NoneType' object has no attribute 'find'

seems to be present in  2.13.0
2019-04-03 10:46:10,952 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Looking for IAP violations: IapResource(project_full_name=u'organization/899064685583/folder/457815117631/folder/150093548869/folder/736583365201/folder/371694806870/project/manawa-euw4-dtp/', backend_service=backendservice<id=333020148442725244,parent=None>, alternate_services=set([]), direct_access_sources=set([u'<IP_ADDRESS>/0']), iap_enabled=False)
2019-04-03 10:46:10,953 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Ancestors of resource: [project<id=manawa-euw4-dtp,parent=None>, folder<id=371694806870,parent=None>, folder<id=736583365201,parent=None>, folder<id=150093548869,parent=None>, folder<id=457815117631,parent=None>, organization<id=899064685583,parent=None>]
2019-04-03 10:46:10,953 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for project<id=manawa-euw4-dtp,parent=None>: []
2019-04-03 10:46:10,953 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for folder<id=371694806870,parent=None>: []
2019-04-03 10:46:10,953 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for folder<id=736583365201,parent=None>: []
2019-04-03 10:46:10,953 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for folder<id=150093548869,parent=None>: []
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for folder<id=457815117631,parent=None>: []
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Resource rules for organization<id=899064685583,parent=None>: [IapResourceRules<resource=organization<id=,parent=None>, rules=set([IapRule<rule_name=Forbid any IAP bypasses (when IAP is enabled), rule_index=0, allowed_alternate_services=[], allowed_direct_access_sources=[], allowed_iap_enabled=^.$>]), applies_to=self_and_children, inherit_from_parents=True>]
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Does IapResourceRules<resource=organization<id=,parent=None>, rules=set([IapRule<rule_name=Forbid any IAP bypasses (when IAP is enabled), rule_index=0, allowed_alternate_services=[], allowed_direct_access_sources=[], allowed_iap_enabled=^.$>]), applies_to=self_and_children, inherit_from_parents=True> apply to resource? True
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Has enabled violation? '^.*$' / False
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Enabled violation: False
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Has alternate service violation? False / [] / set([])
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Alternate services violations: []
2019-04-03 10:46:10,954 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Has sources violation? False / [] / set([u'<IP_ADDRESS>/0'])
2019-04-03 10:46:10,955 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_mismatches): Sources violations: []
2019-04-03 10:46:10,955 DEBUG [forseti-security][2.13.0] google.cloud.forseti.scanner.audit.iap_rules_engine(find_violations): Returning violations: []
2019-04-03 10:46:11,065 ERROR [forseti-security][2.13.0] google.cloud.forseti.scanner.scanner(run): Error running scanner: IapScanner
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanner.py", line 117, in run
scanner.run()
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 642, in run
all_violations, _ = self._find_violations(iap_data)
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 627, in _find_violations
for (iap_resources, project_resource_counts) in iap_data:
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 610, in _retrieve
run_data.make_iap_resource(backend, parent.full_name))
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 300, in make_iap_resource
backend_service, instance_group)
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/scanner/scanners/iap_scanner.py", line 141, in instance_group_network_port
project_id=instance_group.project_id),
File "/usr/local/lib/python2.7/dist-packages/forseti_security-2.13.0-py2.7.egg/google/cloud/forseti/common/gcp_type/network.py", line 64, in from_url
if '://' not in url:
TypeError: argument of type 'NoneType' is not iterable