Is max timestep limit useful?

Hi, I am new to metaworld. I find that you set a max_path_length in metaworld/envs/mujoco/mujoco_env.py. I find that you mentioned this in #39, where you said it is because Mujoco environments have a max_path_length of 150.
But I find that in other mujoco envs (like openai gym), there is no such timestep limit. So I just delete line 101 and 102 in metaworld/envs/mujoco/mujoco_env.py to unrestrict the limit. Then I just run an env from your benchmark envs for 1000 timesteps and I don't encounter any problem. So I just wonder if this timestep limit is useful.

Reposting my response from #157
My short answer is "yes," and you can read below for why it exists.
@HeegerGao thanks for bringing up this feedback!
The max_path_length limit is intended to ensure that results generated with metaworld are reproducible across research papers. The performance of two algorithms can be drastically different using two different max_path_length numbers, given the same number of environment samples. This is especially true in the case of meta-learning, which typically uses trajectories during the adaptation step. It also functions to give users a reasonable idea of how long an environment takes to solve.
I'll take this issue as feedback for future revisions of the benchmark. It may be artificially-constraining to limit the max_path_length, when we can already measure the total environment steps taken during training regardless of max_path_length (and in the case of meta-RL, the total environment steps prior to adaptation).
If you plan on writing a research paper, please note: regardless of your perspective on design decisions, it's never valid to report results in a research paper as "metaworld" using a modified version of the benchmark code. If a limitation is particularly-cumbersome and you need to change it, we ask that you present the results from both the modified and unmodified version of the benchmark in all figures/tables/plots, and make clear in the main text the exact modifications you made.


Remove .DS_Store file from repo

There was a .DS_Store file in the repo, despite the .gitignore stating there shouldn't be. Small thing, but I wanted to help you out.
Thanks for your work with this hook!

Thanks @aethant!


performance/caching/middleware.md "Response caching middleware"

@GuardRex  meeting notes
go at it.

@JunTaoLuo Just adding myself here so I'll get an E-mail from GH when the outline is ready.

There's a subscribe button you'll find pretty useful :)
On Wed, Nov 30, 2016, 20:45 Luke Latham<EMAIL_ADDRESS>wrote:

@JunTaoLuo https://github.com/JunTaoLuo Just adding myself here so I'll
get an E-mail from GH when the outline is ready.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/Docs/issues/2198#issuecomment-264033305, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABeg9LiW7HHSOMtAT39bYGAukAfSJgGEks5rDgqAgaJpZM4K0yIR
.

I'm subscribed to this repo's issues, but I don't get E-mail from GH on a specific issue unless I post to it. I just want to make sure I get an E-mail on this one so I can jump right on it when the outline is ready. [The Rex is lick'in his chops to get into this! :smile: ]

Topics to include:

Sample

Use something similar to the sample in the ResponseCaching repo: https://github.com/aspnet/ResponseCaching/blob/dev/samples/ResponseCachingSample/Startup.cs
Note that this sample does not illustrate how to use the ResponseCachingFeature to configure VaryByQueryKeys

Extensions needed to use the middleware

AddResponseCaching(), UseResponseCaching()

Options

UseCaseSensitivePaths
MaximumBodySize

ResponseCachingFeature

VaryByQueryKeys

functions as an HTTP cache

relevant headers:
Authorization (we do not cache if it exists)
Cache-Control

max-age, max-stale, min-fresh, must-revalidate, no-cache, no-store, only-if-cached, private, public, s-maxage, proxy-revalidate

Pragma

no-cache

Set-Cookie
Vary
Expires
If-None-Match
If-Modified-Since
The middleware also sets the following when appropriate:
Date
Age
Content-Length

@GuardRex Thanks for helping out, let me know if you have any questions.

@GuardRex  meeting notes

@JunTaoLuo Thanks John. I'll be wrapping the Pub IIS doc with Tom's feedback by tomorrow afternoon. I want to take a quick look at the use of "command line" language (Docs/2248) and get back to to Tom on that Wednesday afternoon, then I'll get right on this.

@JunTaoLuo Bit of a side-question, but I'm confused on seeing ...
context.Response.Headers[HeaderNames.Vary] = new string[] { "Accept-Encoding" };

I would have expected to see it in a compression sample, where the Response Compression Middleware changes the encoding but doesn't set the header automatically AFAICT from my testing.
In a purely caching sample, where there only ever is one encoding (text/plain in the sample, for example), do you want that there? ... I mean the Response Caching Middleware never changes the encoding all by itself, does it?

@GuardRex The Vary in the sample was there to illustrate how to vary the cached response by another header. In the example, the Accept-Encoding header was used but we could have used any other header. The Microsoft.Extensions.Caching.Memory dependency is unnecessary as you have mentioned and seems to be something that was not cleaned up.

@JunTaoLuo I'm researching whether or not it is relevant to mention disabling IIS output caching in web.config for an app that prefers to use the middleware where IIS has been configured at the server level to cache objects.
I ran a test with the HttpCacheModule ...

a non-ANCM site to confirm IIS output caching was working normally (it worked :+1:)
a non-middlware ANCM-Kestrel site serving the same test image with the same Cache-Control header

I couldn't get the IIS module to cache the test image from the ANCM-Kestrel site. so it looks like the module isn't effective with reverse-proxy setups. Is that correct? If it should work, I'll go back and check my test setup again.


Add more built-in features for "Insert image" menu button, for @tiptap/extension-image

Right now, there's a general-purpose "insert image" button via MenuButtonAddImage. You provide your own onClick (where you could use your own interface to type in a URL, or you could trigger a file upload), like in the simple example in the internal demo.
As originally mentioned/requested in https://github.com/sjdemartini/mui-tiptap/issues/52, we might also want to add support for more functionality/UI built into mui-tiptap, with:

[ ] An interface for a user to provide a URL
[ ] A user to upload an image from their filesystem

See example screenshots here https://github.com/sjdemartini/mui-tiptap/issues/52#issuecomment-1637220903

👋🏻  Do you have a simple example of triggering a file upload when clicking the Insert image menu button?

Hi @devth, I don't have one off hand, though I plan to add one soon. I think an approach like this https://medium.com/web-dev-survey-from-kyoto/how-to-customize-the-file-upload-button-in-react-b3866a5973d8 (https://codesandbox.io/embed/how-to-customize-file-upload-buttons-in-react-wthkrz?codemirror=1) is similar to what I had in mind, except swapping the <button> for the MenuButtonAddImage, and using logic similar to the mui-tiptap URL example to insert the image into the editor after you upload it (using a URL returned from the server for the uploaded image). There's more to do to handle multi-file uploads/insertions with the Tiptap API, which I plan to also demo, but maybe that's enough to get you started in the meantime. I'll keep you posted when I add something.

@sjdemartini awesome, thanks so much! I’ll play around and see what I can come up with.

@devth I've released a new version 1.8.0 which includes a new component MenuButtonImageUpload that encapsulates the image upload functionality intended/discussed above. You just need to supply your own onUploadFiles prop in order to take/upload the image files the user provided, and return URLs at which the images can be served/viewed. The component will handle the hidden file input, button behavior, and insertion of the images into the editor content.
I've also updated the demo to show how to use drag-and-drop and pasting of image files (notes on this are in the README here).
Hope that's useful!

@sjdemartini this looks awesome! thanks.

hi i am new to programing as a whole and am trying to use the mui titap pludin in my react MUI project, i copied the all-in-one component from the gitgub repo, and am trying to add controls but i get such errors "React Router caught the following error during render TypeError: editor.can(...).toggleSuperscript is not a function", toggleSuperscript is the control i want to add for example, and this goes for all other controls i add,

as you can see from the screenshot all the commented controls give the error in the console and my application breaks. please how can i go about this.

@rextambua This comment doesn't seem to be related to the original issue here—please create new issues rather than changing the topic if you have a problem. In this case though, it appears your issue is that you haven't installed and added the necessary extensions (notably Superscript here). See past issues about this here https://github.com/sjdemartini/mui-tiptap/issues/174#issuecomment-1783299136 (or similarly here https://github.com/sjdemartini/mui-tiptap/issues/187) and this section of the README https://github.com/sjdemartini/mui-tiptap?tab=readme-ov-file#choosing-your-editor-extensions.

sorry and thanks, i will read this material and if need arises i will create a new issue

@devth getHTML() does not return the full Tiptap-rendered markup (such as the react-renderer elements, etc.). getHTML is for returning a serialized version of the the editor content—it will always use the renderHTML method of an extension and not custom Node views (React or otherwise) or interactive elements. When its output is parsed again by Tiptap later, it should ideally produce/render the same visual result as before. But on its own, the HTML may not appear the same.
I'm not sure where you are referring to in saying that the CodeSandbox demo has getHTML containing a wrapper. I have just tested and confirmed (via the "Save" button example there) that it only returns the ordinary img markup and no more:

In general, you should use Tiptap to render and display Tiptap content, like with RichTextReadOnly as you note, rather than trying to inject the HTML directly into the page.

Thanks for the explanation!
What I meant in the CodeSandbox demo was that when the html is rendered via RichTextReadOnly it contains the wrapper when I inspect it in devtools:

I'll look into using RichTextReadOnly in my app. 👍🏻

One thing I'm trying to figure out is how I can replace anchor tags coming from tiptap getHTML with Next.js Links. Currently I do that with html-react-parser's replace function:
const parseHtmlWithNextLink = (html: string) => {
  return htmlParse(html, {
    replace: (domNode) => {
      if (domNode instanceof Element && domNode.attribs) {
        if (domNode.name === "a") {
          const props = attributesToProps(domNode.attribs);
          return (
            <Link legacyBehavior href={domNode.attribs.href} {...props}>
              {domToReact(domNode.children as DOMNode[])}
            </Link>
          );
        }
      }
    },
  });
};

🤔

An alternate solution I tried is to keep using html-react-parser, and add my own wrapping logic so that image alignment works:
const parseHtmlWithNextLink = (html: string) => {
  return htmlParse(html, {
    replace: (domNode) => {
      if (domNode instanceof Element && domNode.attribs) {
        // surround images with a div that respects alignment
        const props = attributesToProps(domNode.attribs);
        if (domNode.name === "img") {
          const style = props.style;
          const divStyle = {
            width: "100%",
            textAlign: style?.textAlign as CSSProperties["textAlign"],
          };
          return (

          );
        }
        // turn anchor tags into Next.js Link elements for client-side routing
        if (domNode.name === "a") {
          return (
            <Link legacyBehavior href={domNode.attribs.href} {...props}>
              {domToReact(domNode.children as DOMNode[])}
            </Link>
          );
        }
      }
    },
  });
};

Not sure this is a good idea, but it "works".

Oops Ive now included a MUI diag box for insert Images. However upon inserting a Transparent PNG the background showa white. Any think I may be missing ?

@sjdemartini would be great if you could help let me know if there is something missing WRT adding transparent images

@pymenow There is not a specific built-in way to add an image from a URL in mui-tiptap, but you can do it yourself with your own mui-tiptap MenuButton, MUI Dialog, etc. as you seem to be suggesting.
In terms of transparent images, mui-tiptap currently has behavior similar to Chrome, which is to add a light grey background to all (transparent) images, as this tends to be useful since most images are created on a light background and will help make them readable even in dark mode. (Though of course some images, likely a minority of them, will have the opposite problem.) See the notes here for more of the behavior details and rationale
https://github.com/sjdemartini/mui-tiptap/blob/9e4bbb5ab66294ce654ba2e7c141d21fe1e72325/src/styles.ts#L489-L516
You can override the styles by targeting img:not(.ProseMirror-separator) inside of the mui-tiptap RichTextEditor/ProseMirror context and adding CSS to change to backgroundColor: "transparent" or similar.


Alerts

Some alerts that might be useful to add:

We see a single crit error. "Alert Critical Error"
We see a single error: "Alert Error"
We see 5 or more warnings (in an hour window): alert that something is misbehaving
Peer count drops below 20
NAT is closed
Attestation missed (this is for the future, we could parse the logs which would tell us when attestations are missed. These will show as errors. )
Block produced - Again would have to parse the logs for a block production log. The log would look like: "Valid block from HTTP API" in the beacon node
If we go out of sync a warning alert saying either the EC or BN is out of sync

We might want to parse some of the error message in the alerts if we can. Like if there is a crit, somehow display the log message corresponding to the crit when they click on the alert.
If there are multiple of the same error, I don't think we stack them. We just have a single one. Once the user acknowledges them or removes them, we add them back if there are more.

[ ] Crticical alerts
[ ] error alerts
[ ] 5 or more warnings
[ ] peer count alerts
[ ] nat alert
[ ] beacon sync alert
[ ] ec sync alert
[ ] alerts dissmisable


ADD EVENTS GPS103 PROTOCOL

Hello @tananaev , I would like to add some events for the gps103 protocol, but I'm not sure what the default should be for the names of these, I'm attaching the manual that sends me directly, so you can see section 3.1 and there to take account for example When a command is sent and the response arrives, think of something like ALARM_MOVEMENT_ENABLE for example. But I'm not sure. I await your comments to start adding them.
COBAN GPRS PROTOCOL_20141212.pdf

Traccar already supports alarms for GPS103 protocol.

Yes, but not support responses from GPRS commands. Please ser 3.1 section.
El dic. 13, 2016 17:31, "Anton Tananaev"<EMAIL_ADDRESS>escribió:

Traccar already supports alarms for GPS103 protocol.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/2683#issuecomment-266868069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_Rdn3VGFwR-Jim6jLTa-7t0mxSMZwWks5rHw6ugaJpZM4LMLcK
.

So, you asking for commands, not for events. Is that correct?

Yes, responses for commands. For example. I send a speed config to GPS, And
it respond that its Ok.
El dic. 13, 2016 18:10, "Anton Tananaev"<EMAIL_ADDRESS>escribió:

So, you asking for commands, not for events. Is that correct?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/2683#issuecomment-266877960,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_RdrM0yDj9g0IRBCqUkMN8bd1so5oUks5rHxfCgaJpZM4LMLcK
.

That's not what I said. What you pointed out in the document is referring to commands, not "responses for commands". Please explain properly what you are looking for.

The boxes on the left are the commands from the server to the gps but the
boxes on the right are the responses from gps to the server
El dic. 13, 2016 18:17, "Anton Tananaev"<EMAIL_ADDRESS>escribió:

That's not what I said. What you pointed out in the document is referring
to commands, not "responses for commands". Please explain properly what you
are looking for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tananaev/traccar/issues/2683#issuecomment-266879709,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH_RdjJcW06kW4cfuI9xMIi35Rbfr2nSks5rHxlmgaJpZM4LMLcK
.

OK, it looks like command responses. Those should be decoded as KEY_RESULT in the position. Traccar will automatically generate command response for those. Note that it's not possible to specify any additional information with this event.


Chore/component tests

Add unit tests for components

Meant to merge into chore/updates, not main


foo_scrobble does get auth token but still puts tracks to unauthenticated queue

Version info:
Foobar v 1.6.5
foo_scrobble <IP_ADDRESS>78
I was able to successfully authenticate with lastfm, but the plugin does not publish the tracks to lastfm. I have looked at the console and I see
foo_scrobble: Requesting auth token
foo_scrobble: Received auth token: ********
foo_scrobble: Queuing scrobble (Unauthenticated)
Complete log here (I am playing tracks from Spotify but the same happens for local tracks):
Components loaded in: 0:01.493572
Configuration read in: 0:00.100282
foobar2000 v1.6.5 [portable]
Filter Panel - Genre: initialised in 0.000 s
Filter Panel - Artist: initialised in 0.000 s
Filter Panel - Album: initialised in 0.000 s
Playlist view initialised in: 0.003 s
User Interface initialized in: 0:00.183676
FFmpeg version: 4.3.1
Startup time : 0:01.843075
foo_scrobble: Requesting auth token
foo_scrobble: Received auth token: ********************************
Opening track for playback: "spotify:track:5LLfL25W8ELqVXOLBhkJOP"
foo_spotify (log): 13:00:01.054 I [ap:1752] Connecting to AP ap.gslb.spotify.com:4070
foo_spotify (log): 13:00:01.095 I [ap:1226] Connected to AP: <IP_ADDRESS>:4070
foo_spotify (log): 13:00:01.254 I [offline-mgr:2084] Storage has been cleaned
foo_spotify (log): 13:00:02.267 I [offline-mgr:2032] 0 files are locked. 0 images are locked
foo_spotify (log): 13:00:02.269 I [offline-mgr:2058] 0 files unlocked. 0 images unlocked
Automatic resampling: using Resampler (dBpoweramp/SSRC), Resampler (PPHS)
Device: Speakers / Headphones (Realtek Audio)
Mix format: 48000 Hz / 32-bit float / 2 channels (0x3)
Sending stream: 48000 Hz / 32-bit float / 2 channels (0x3)
foo_spotify (log): 13:00:03.333 E [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/network/proxy_resolver_win32.cpp:215] WinHttpGetProxyForUrl failed
Opening track for playback: "spotify:track:1vOu4N1r3asJO9xfBMKWNd"
foo_spotify (log): 13:02:00.537 I [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/social/social_presence.cpp:135] Presence: A track was played
Opening track for playback: "spotify:track:6c7uYlmHJtZPnenPjqG7Ir"
foo_spotify (log): 13:02:20.865 I [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/social/social_presence.cpp:135] Presence: A track was played
foo_spotify (log): 13:02:30.526 I [offline-mgr:2058] 0 files unlocked. 0 images unlocked
Opening track for playback: "spotify:track:2mDpaQWRfsXtymj7JhVOEE"
foo_spotify (log): 13:04:51.986 I [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/social/social_presence.cpp:135] Presence: A track was played
foo_spotify (log): 13:04:52.473 I [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/protocol/file_streamer_simple.cpp:769] Request for file 58364c9fc1f94663d50798a8530e7bd785473c1d complete (code: 0)
foo_spotify (log): 13:04:52.690 I [c:/Users/spotify-buildagent/BuildAgent/work/1e0ce8a77adfb2dc/client/core/protocol/file_streamer_simple.cpp:769] Request for file 58364c9fc1f94663d50798a8530e7bd785473c1d complete (code: 0)
foo_scrobble: Queuing scrobble (Unauthenticated)

After authenticating on last.fm, you have to click on the button again (at this point it should show "Complete authorization"). Then click Apply in the bottom right corner. The log should show:
foo_scrobble: Requesting auth token
foo_scrobble: Received auth token: ********************************
foo_scrobble: Requesting session key
foo_scrobble: New session key: ********************************

I should've had a closer look at what the button tooltip said :facepalm:
Thank you @gix, my issue is gone!


Unable to restore .csproj in .NET Core Hosted Build

Environment

Server - VSTS build with ASP.NET Core template
log:   https://docascode.visualstudio.com/docfx/_build/index?buildId=1&_a=summary
Agent - Hosted

Issue Description
Error when restore in .NET Core env: Invalid input 'd:\a\1\s\test-projects\CSharpAndVBasic\csharp-console\csharp-console.csproj'. The file type was not recognized.
Looks like similar to https://github.com/Microsoft/vsts-tasks/issues/3311, however that issue is closed long time ago. And according to the log, we are using .NET Core 2.1.8, that version should already support dotnet restore .csproj. Would you mind taking a look at what's wrong here?
And according to #3311, the workaround is to change to use Hosted VS2017, however I want a pure dotnet core 2.0 environment with NO VS installed. Is there any alternations?
Error logs
2017-12-01T08:56:49.8086927Z ##[section]Starting: Restore
2017-12-01T08:56:49.8096916Z ==============================================================================
2017-12-01T08:56:49.8096916Z Task         : .NET Core
2017-12-01T08:56:49.8096916Z Description  : Build, test, package, or publish a dotnet application, or run a custom dotnet command. For package commands, supports NuGet.org and authenticated feeds like Package Management and MyGet.
2017-12-01T08:56:49.8096916Z Version      : 2.1.8
2017-12-01T08:56:49.8096916Z Author       : Microsoft Corporation
2017-12-01T08:56:49.8096916Z Help         : More Information
2017-12-01T08:56:49.8096916Z ==============================================================================
2017-12-01T08:56:50.70235
...........Expanding 100% 12831 ms
2017-12-01T08:57:42.5993726Z error: Invalid input 'd:\a\1\s\test-projects\CSharpAndVBasic\csharp-console\csharp-console.csproj'. The file type was not recognized.
2017-12-01T08:57:43.2812893Z ##[error]Error: C:\Program Files\dotnet\dotnet.exe failed with return code: 1
2017-12-01T08:57:43.2812893Z ##[error]Packages failed to restore
2017-12-01T08:57:43.2852880Z ##[section]Finishing: Restore

To clarify, 2.1.8 would be the version of the task which is independent of the version of the .Net core sdk installed on the agent machine.
If you want to use Hosted Windows based pools – then only Hosted VS2017 contains the appropriate .Net core SDK.  Hosted Linux preview pool also has the required .Net core tooling.
You can also use the new tool installer task - “.Net Core Tool Installer” which can be used to install any version of .net core just in time. So you can use it before restore and other commands.

If you’re using the Hosted queue you’re on the older windows 2012 with VS 2012/2013/2015 on it, the Hosted VS 2017 pool only has VS 2017. The Hosted Linux pool is probably the closest thing to pure dotnet core in our set of images right now.

Closing issue.  If suggestions above do not work.  Please reopen.


Use Immutable.js for storing data.

Just a heads up, you can use seamless-immutable to not break backwards compatibility.

Awesome, thanks for the @isair. I'll take a look.


Response example should be json object

In the OpenAPI spec, it looks like response examples should be matching the media type.
https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#mediaTypeObject
Response examples in FastEndpoints appear to get formatted as JSON strings instead of as a JSON object. I'm also seeing complaints in 3rd party tools that validate swagger (e.g. Stoplight) complaining the example is not formatted as an object.
e.g.

vs

can you try the latest beta. I think this was fixed recently. report back if it's still there.

Let me check...

Yes, I confirm its coming over as an object in latest beta. Closing this out as a result. Thanks!


Add functionality to test raised exceptions

I think it would be nice to test for raised exceptions.
This is already possible like this:
<!-- name: test_raises
```python
import pytest
with pytest.raises(ZeroDivisionError):
```
-->
```python
    1 / 0
```

But this leaves an ugly indentation in the rendered docs. I think another argument in the comment would be nice, which would allow this.
Maybe one could specify a fixture that is then prepended to the test case. Then one could use the pytest.xfail for this.

may be:
<!-- name: test_raises; raises: (ZeroDivisionError, ValueError) -->
```python
1 / 0
```

I just don't understand how this is better than a hidden code block, you can of course make the indent parameter so that it moves the code 4 spaces to the right, for example, so that the code is not so scary, but it seems to me that it is better to write a comment to the user that an exception is being handled in this place

may be:
<!-- name: test_raises; raises: (ZeroDivisionError, ValueError) -->
```python
1 / 0
```

I like this syntax.
But it might be worthwhile to make it more general for other use cases. I would suggest something along the lines of:
<!-- name: test_raises; mark: xfail(raises=IndexError) -->
```python
1 / 0
```

I just don't understand how this is better than a hidden code block, you can of course make the indent parameter so that it moves the code 4 spaces to the right, for example, so that the code is not so scary, but it seems to me that it is better to write a comment to the user that an exception is being handled in this place

I'm not sure I understood you correctly. Could you maybe rephrase your last point?
I don't think that the hidden code block is worse, I just think the sudden identation will throw users off.
I could not hide the with pytest.raises, but I don't want to randomly mention pytest in the middle of the documentation whenever I want to show user's that an exception will be thrown.


Session check fails with "Unable to post message"

Describe the bug
Get this error

Unable to post message to . Recipient has origin .

To Reproduce
Not quite sure how this is best reproduced. I'm assuming having the issuer and application on different urls?
btw one thing to note they are both on a azurewebsites.net (which is a separate problem imo).
Expected behavior
Should not be seeing any errors
Desktop (please complete the following information):

OS: Mac (Catalina)
Browser: Safari
Version [e.g. 22] > 12

Additional context
postMessage
	checkSession (vendor-es2015.e67ebd09ba0437696bf6.js:1:2049269)
	(anonymous function) (main-es2015.3b98823407c2f41b53b6.js:1:493328)

There seems to be a similar issue on another project https://github.com/IdentityModel/oidc-client-js/issues/350.
It seems to be a timing issue where the iframe isn't loaded yet when we send the first postMessage.
Their solution is to just listen to the iframe's onload before starting the session checks https://github.com/pawepaw/oidc-client-js/commit/69dd35040220fa4fbcb0a3073e1ffae77d0f601a.
So would be something like this
  protected initSessionCheck(): void {
    if (!this.canPerformSessionCheck()) {
      return;
    }

    const existingIframe = this.document.getElementById(
      this.sessionCheckIFrameName
    );
    if (existingIframe) {
      this.document.body.removeChild(existingIframe);
    }

    const iframe = this.document.createElement('iframe');
    iframe.id = this.sessionCheckIFrameName;

    const url = this.sessionCheckIFrameUrl;
    iframe.setAttribute('src', url);
    iframe.style.display = 'none';

    const waitForIFrame = new Promise((resolve) => {
            iframe.onload = () => {
                resolve();
            }
             this.document.body.appendChild(iframe);
             this.setupSessionCheckEventListener();
        });

    waitForIFrame.then(() => {
      this.startSessionCheckTimer();
    });
  }

Sounds like an annoying issue!
Will have to say though that:

Not quite sure how this is best reproduced. I'm assuming having the issuer and application on different urls?

without a way to reliably reproduce this, the community cannot really help out, right? Might also be an issue specific to your setup, if we don't have an isolated way to reproduce it?


Allow running the program as cargo-script file.rs

Must run as cargo script file.rs currently. Is there a reason cargo-script file.rs could not work?

> touch script
> cargo-script script

Does that try to execute a file called script, or did I type cargo script and forget to provide a filename?  (As an aside, I'm actually not even sure if clap can reconcile this case.)  This is actually why I added the run-cargo-script trampoline, for shebang lines.
Is there any particularly compelling reason why you'd want to use cargo-script instead of cargo script?

Not really. if run-cargo-script exists, I can use that.
Reached for cargo-script first and I don't know why. But as it is right now, cargo script x does not complete on filenames, so that's not really viable either.

I'm using some kind of bash script for cargo completion since it knows how to complete cargo subcommands. Like cargo scr for example.

Well, I don't know anything about how completion works.  Maybe the script is blocking completion of stuff it doesn't recognise?

We can close this.


Feature request: Keylogger with active window.

This tool is magnificent, but I miss a simple Keylogger feature.

To the target u propose?

Windows Script Host doesn't have straight access to the Windows API, so unfortunately we don't have the ability to hook keystrokes. Best bet is to upload a keylogger executable and read any text files it produces.

what about using a javascript keylogger like this one
https://github.com/PlayLikeLars/simple-keylogger/blob/master/keylogger.js

That keylogger specifically adds keyUp listeners for form inputs. We don't have form inputs.
I assume that a generic JS keylogger would require the window to be focused to receive key events.

That keylogger specifically adds keyUp listeners for form inputs. We don't have form inputs.
I assume that a generic JS keylogger would require the window to be focused to receive key events, and we purposefully do anything we possibly can to blur the windows.

my bad :(

I betcha we could whip up some C# and DotNet2JS this. It will work as long as DotNet2JS doesn't get sniped. I'll do some testing when I can.


Version 3.0.0 will not close on Windows 10

Hi,
when i try to shutdown the client on Windows 10 Build 1909 the process is not closed, it even consumes more and more RAM. I have now waited about an hour after click on File -> Exit. So i have to kill it. After this when i start it next time it will always check the blockchain for all blocks, so after every shutdown and restart, maybe windows updates, i have to wait about 3 days before it is online again...

Please upgrade to latst v3.10.0. https://www.reddit.com/r/reddCoin/comments/h88u4j/reddcoin_rdd_core_release_v3100_reddcoin_core/


removed magic constant

Description
Replaced script with hardhat task in hardhat config
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Deployment

[ ] Should publish npm package
[ ] Should publish Docker image

it's just an opinion, how about adding tasks to read public count variables? if you think it's unnecessary, that's okay. I thought it could be called after calling add or remove functions to check if the count has changed.

it's just an opinion, how about adding tasks to read public count variables? if you think it's unnecessary, that's okay. I thought it could be called after calling add or remove functions to check if the count has changed.

I think it's good to have, but then it should be consistent among all other tasks. Let's create another issue for that. I'll merge this PR for now


Refactor integration test script for CSLC-S1

To move the integration tests for CSLC-S1 to the new paradigm, the following refactoring tasks need to be completed on the test_int_cslc_s1.sh script:

[x] Remove the download of the comparison script from S3 on lines 61-65
[x] Refactor the comparison logic on lines 151-199 into a separate shell script, named compare_cslc_s1_products.sh
[x] Refactor the comparison logic on lines 151-233, excluding lines 166-199, into a separate shell script named compare_cslc_s1_static_products.sh
[x] Update the opera_pge_cslc_s1_delivery_6.1_final_runconfig.yaml runconfig to execute the new compare_cslc_s1_products.sh script within the QAExecutable section of the PGE config
[x] Update the opera_pge_cslc_s1_static_delivery_6.1_final_runconfig.yaml runconfig to execute the new compare_cslc_s1_static_products.sh script within the QAExecutable section of the PGE config

The changes made in https://github.com/nasa/opera-sds-pge/pull/406 can be referenced for examples of the required changes.

Closed by #427


Add support for staking-deposit-cli

Add support for staking-deposit-cli

Here is the recipe for the static binaries:
{ stdenv, fetchurl, autoPatchelfHook, lib, zlib, ... }:
stdenv.mkDerivation {
  pname = "staking-deposit-cli";
  version = "2.5.0";

  src = fetchurl {
    url = "https://github.com/ethereum/staking-deposit-cli/releases/download/v2.5.0/staking_deposit-cli-d7b5304-linux-amd64.tar.gz";
    hash = "sha256-P1GFnXitR6PiWEcPWlyvA9Ge0dQwfVFzJbe7j2/N5u8=";
  };

  nativeBuildInputs = [ autoPatchelfHook ];

  buildInputs = [ zlib ];

  installPhase = ''
    runHook preInstall

    mkdir -p $out/bin
    mv ./deposit $out/bin/deposit

    runHook postInstall
  '';

  meta = {
    description = "Secure key generation for deposits";
    mainProgram = "deposit";
  };
}


Add Release Status badge

https://github.com/bromso/school-frontend/blob/master/README.md

https://github.com/bromso/school-frontend/blob/master/README.md


Texture Not Updating for Large Number of Sprites in Particle Container

Hello,
I am working with Pixi.js and have a problem with updating textures. I have a Particle Container with ~1000 sprites in it. I want to go through the container and change all of their textures to something new. I am currently doing it by the following:
function changeTextures() {
    for(var i = 0; i < container.length; i++) {
        var sprite = container.children[i];
        container.removeChild(sprite);
        sprite.texture = PIXI.Texture.fromFrame("new_texture");
        container.addChild(sprite);
    }
    renderer.render(container);
}

This updates most of the sprites, but not all of them. ~100 sprites do not update their textures. However, if I run the function consecutively, more and more sprites will update. Is there a better way to update all sprites in a Containers texture?

Does using container.length let you loop properly? You are reading out of an array that you are changing as you loop through it though - if you don't use addChild() here, does it work better?

If I do not do addChild(), it does not update at all

You'll be messing around with a private variable a little, but try setting container._bufferToUpdate = 0; after your for loop. In theory that's what should be happening behind the scenes in addChild().

Try a reverse loop instead, I think modifying the array in the loop is your problem:
function changeTextures() {
    for(var i = container.children.length - 1; i >= 0; --i) {
        var sprite = container.children[i];
        container.removeChild(sprite);
        sprite.texture = PIXI.Texture.fromFrame("new_texture");
        container.addChild(sprite);
    }
    renderer.render(container);
}

I had uvs set to false when creating the Particle Container. Setting it to true would enable me not to have to add/remove the sprite to get it to update?
Also I figured out the problem. I was looping incorrectly. Since addChild puts it at the end of the array, looping incrementally was missing objects. By instead always looking at the first child in the array, I was able to update them all correctly. Thanks for your help!

Closing this since it seems answered.


Webpack: Promise is not a constructor

Great library, I am really getting into the pouchdb ecosystem!
I received a error message stating that "Promise is not a constructor." After investigating the issue, I noticed that pouch-quick-search depends on an outdated version of pouchdb-promise, which created a version conflict in my webpack bundle.
Someone proposed just modifying pouch-utils to require('pouchdb-promise').default but that would break when running in nodejs.
I was able to workaround the issue by augmenting the webpack configuration of my angular app, by adding a resolve alias to always pull in the newer version of pouchdb-promise, and using the index.js rather than index.es.js
const path = require('path');
const webpackDefault = require('@ionic/app-scripts/config/webpack.config');
const webpackMerge = require('webpack-merge');

const customConfig = {
  dev: {
    resolve: {
      alias: {
        'pouchdb-promise$': "pouchdb-promise/lib/index.js"
      }
    }
  },
  prod: {
    resolve: {
      alias: {
        'pouchdb-promise$': "pouchdb-promise/lib/index.js"
      }
    }
  }
};

module.exports = webpackMerge(webpackDefault, customConfig);

Is there an easy way to update this library to distribute a ES6 module version for webpack to use, and a ES5 (CommonJS?) version for nodejs to use? I noticed other pouchdb libraries are using the "main" and "module" package.json properties to achieve this. I'd be happy to open a pull request after getting some direction.

Thanks so much for posting the results f your investigation on this. I'm sure I'm not the only one you've saved loads of debugging time for.
Here's a slightly sorter config without the webpack-merge dependency if using Ionic. I've left in another alias too `@environment' which is part of a solution to set environment variables.
const path = require('path');
const webpackConfig = require('@ionic/app-scripts/config/webpack.config.js');

module.exports = function () {
  webpackConfig[process.env.IONIC_ENV].resolve.alias = {
    "@environment": path.resolve(__dirname + '/../../src/config/config.' + process.env.IONIC_ENV + '.ts'),
    'pouchdb-promise$': "pouchdb-promise/lib/index.js"
  };
  return webpackConfig;
};

Thanks so much for posting the results f your investigation on this. I'm sure I'm not the only one you've saved loads of debugging time for.
Here's a slightly sorter config without the webpack-merge dependency if using Ionic. I've left in another alias too @environment which is part of a solution to set environment variables.
const path = require('path');
const webpackConfig = require('@ionic/app-scripts/config/webpack.config.js');

module.exports = function () {
  webpackConfig[process.env.IONIC_ENV].resolve.alias = {
    "@environment": path.resolve(__dirname + '/../../src/config/config.' + process.env.IONIC_ENV + '.ts'),
    'pouchdb-promise$': "pouchdb-promise/lib/index.js"
  };
  return webpackConfig;
};

Hi, I have problems. I am new to this and I have the same error, where I paste this code that they have put. Help me please

@davidspalaciof You need to add a file somewhere in your project that contains the code above.   Then reference that file in your package.json as follows:
  "config": {     "ionic_webpack": "./config/webpack.config.js"   },
In the example above I have a folder named "config" at the root of my project that contains a file named webpack.config.js.

@silverbackdan Your solution works very nicely - thank you.  @cah-ricksuggs thanks to you for the original solution.

Hi, I get the same issue using pouchdb-replication-stream.
But I could't find how to resolve alias in create-react-app without ejecting.
So I've just imported plugin from dist like:
var replicationStream = require('pouchdb-replication-stream/dist/pouchdb.replication-stream.min.js');
Hope this helps someone.
Is there any better way of doing it?

Hi, I get the same issue using pouchdb-replication-stream.
But I could't find how to resolve alias in create-react-app without ejecting.
So I've just imported plugin from dist like:
var replicationStream = require('pouchdb-replication-stream/dist/pouchdb.replication-stream.min.js');
Hope this helps someone.
Is there any better way of doing it?

Is there an explanation for why this works?


Binded model is not available inside on-select's handler

This is my view:
<ui-select ng-model="selectedExporter.selected" ng-disabled="fetchingExporters || working" on-select="onExporterSelected()">
    <ui-select-match placeholder="">{{$select.selected.name}}</ui-select-match>
    <ui-select-choices repeat="exporter in exporters | filterBy: ['name', 'code']: $select.search">

    </ui-select-choices>
</ui-select>

This is my code:
$scope.selectedExporter = {};
$scope.exporters = [];

$scope.onExporterSelected = function () {
    console.log($scope.selectedExporter);  // Prints "{}"
};

As you can see, the model is not available inside that handler...
I'm using the last version (0.8.3)
Although I'm using angular 1.2.26 (and last is 1.3.4)

Closing as legacy issue and resolved.


Monochromatic ducks

I was wondering if it would be possible to make monochromatic ducks with a key instead of explicitly making them colourless. I know xcolor has an option to globally change the entire colourscheme to monochromatic, but I was thinking more along the lines of a local change.
Probably one for the TikZ experts. 😉

@cereda Thanks for your idea! It is certainly useful to create monochrome ducks, however I feel this should be handled with tikz weapons and not by the duck package itself.
I propose to use

\usepackage{tikzducks}

\begin{document}
\begin{tikzpicture}
\selectcolormodel{gray}
\duck
\end{tikzpicture}
\end{document}

Of course I could make some key and use \selectcolormodel{gray} internally, but somehow I think this would open an never ending stream of things which should really be handled by tikz and not by the ducks. The same train of thoughts made me leave scaling etc. to be done by the tikz site.
What's your opinion about letting tikz handle this?

Great idea! I was unaware of \selectcolormodel{gray} and thought it would require some sort of advanced trickery! I suggest leaving the monochromatic option to the TikZ environment and not to the package itself. If possible, add a quick mention to this in the documentation, so TikZ newbies like myself will be able to get monochromatic ducks whenever possible. 😉
Quack!

added monochrome customisation to documentation: https://github.com/samcarter8/tikzducks/commit/4b0b12b1716989f5b7ad9b4981c3460cb542b30c


iPhone models and iOS versions update

Removed iOS 8 versions
added iOS11 versions
Removed iPhone models 5,x and added 6,x , 7,x , 8,x, 9,x , 10,x

we are emulating iphone 5c & 5 only
and iOS 8 is now removed in latest !


Revert "Update newly encrypted clouds.yaml in Managerless Credentials."

Reverts opentelekomcloud-scs/testbed#20

recheck


Add update pin page

Currently pins can't be updated after creation. They should be editable.

[x] Add edit pin page.

Updating a pin is implemented in a modal, instead of creating a new page.


Improve tests

Update API
Added tests for List, Create, Delete project APIs.
Give names to various API tests.

Codecov Report
Base: 80.82% // Head: 82.86% // Increases project coverage by +2.04% :tada:

Coverage data is based on head (9ff9c7f) compared to base (d972b02).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   80.82%   82.86%   +2.04%
==========================================
  Files          30       30
  Lines        2889     2889
==========================================
+ Hits         2335     2394      +59
+ Misses        439      367      -72
- Partials      115      128      +13

Impacted Files
Coverage Δ

driver/grpc.go
85.91% <0.00%> (+4.05%)
:arrow_up:

driver/driver.go
87.10% <0.00%> (+4.29%)
:arrow_up:

driver/http.go
75.94% <0.00%> (+4.49%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Discuss upgrading junit version

Please discuss about upgrading junit version 4 to 5, and if need please commit codes.
After upgrade, make sure all the origin tests run.

I think, it is better to upgrade to junit5.
First it is better to asynchrous test, and some new functions.
But, i never try it, maybe some issues there. I need help

I think using junit5 is good option.
I will try to change version.
Also I want to discuss about two more another issues about test code.

I want to suggest adding @DisplayName above each test method to recognize easily what test is about.
There is another library called "AssertJ" which is recommended to use with junit5 because of its fluency of writing test assertions. Especially in collections, exceptions, objects..
Introduction to AssertJ
Do you think it is worth applying AssertJ library in our project?

I also want to hear anyone's good other opinions about test code.
thanks.

I think using junit5 is good option.
I will try to change version.
Also I want to discuss about two more another issues about test code.

I want to suggest adding @DisplayName above each test method to recognize easily what test is about.
There is another library called "AssertJ" which is recommended to use with junit5 because of its fluency of writing test assertions. Especially in collections, exceptions, objects..
Introduction to AssertJ
Do you think it is worth applying AssertJ library in our project?

I also want to hear anyone's good other opinions about test code.
thanks.

Sorry.. I missed your comment. And i have some question for it.

@DisplayName shows the name of the test or description of the test? What is the different from change the method name or class name?
I agree with your idea that use AssertJ! That's greate!


feat: swcr serverside

Need some fields from SQL/PBI team for this.
Closes: #376

[x] KPI
[ ] Garden
[ ] Grid

beep boop This Draft seems old @Gustav-Eikaas


Multi-server support

Otherwise known as Suicult taking over every Hololive server
This will only be implemented if enough support and would be V3, during this time, V2 will only receive patches and other necessary updates.
Once approved, all progress will be tracked in a project, as this would be a massive undertaking.
Planned features: (This list will grow with other servers requesting functions)

Log/moderation sync
Cross server user check
Auto pre-emps, with example an auto updating embed with reported users

Now tracked on Jira


Error from 'map_msgs'

Hello, I'm installing about your instruction at the HOST PC, but there's error and it's really hard to manage it.
So can you give me any comments?
Thanks.
--------Error---------
<== Finished processing package [194 of 238]: 'map_msgs'
==> Processing catkin package: 'nvidia_gmsl_driver_ros'
==> Building with env: '/home/glad/ros_catkin_ws/devel_isolated/map_msgs/env.sh'
==> cmake /home/glad/ros_catkin_ws/src/nvidia_gmsl_driver_ros -DCATKIN_DEVEL_PREFIX=/home/glad/ros_catkin_ws/devel_isolated/nvidia_gmsl_driver_ros -DCMAKE_INSTALL_PREFIX=/home/glad/ros_catkin_ws/install_isolated -G Unix Makefiles in '/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros'
CMake Warning at cmake/SamplesSetBuildType.cmake:17 (message):
CMAKE_BUILD_TYPE must be one of (Debug|Release).  Using Release as default.
Call Stack (most recent call first):
cmake/MainConfiguration.cmake:10 (include)
CMakeLists.txt:18 (include)
CMake Error at /usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:223 (file):
file failed to open for writing (Permission denied):
/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/3.17.3/CompilerIdCUDA/CMakeCUDACompilerId.cu
Call Stack (most recent call first):
/usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:234 (CMAKE_DETERMINE_COMPILER_ID_WRITE)
/usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:32 (CMAKE_DETERMINE_COMPILER_ID_BUILD)
/usr/share/cmake-3.17/Modules/CMakeDetermineCUDACompiler.cmake:72 (CMAKE_DETERMINE_COMPILER_ID)
cmake/MainConfiguration.cmake:42 (enable_language)
CMakeLists.txt:18 (include)
CMake Error at /usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:223 (file):
file failed to open for writing (Permission denied):
/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/3.17.3/CompilerIdCUDA/CMakeCUDACompilerId.cu
Call Stack (most recent call first):
/usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:234 (CMAKE_DETERMINE_COMPILER_ID_WRITE)
/usr/share/cmake-3.17/Modules/CMakeDetermineCompilerId.cmake:32 (CMAKE_DETERMINE_COMPILER_ID_BUILD)
/usr/share/cmake-3.17/Modules/CMakeDetermineCUDACompiler.cmake:72 (CMAKE_DETERMINE_COMPILER_ID)
cmake/MainConfiguration.cmake:42 (enable_language)
CMakeLists.txt:18 (include)
-- The CUDA compiler identification is unknown
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc
-- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - broken
CMake Error at /usr/share/cmake-3.17/Modules/CMakeTestCUDACompiler.cmake:46 (message):
The CUDA compiler
"/usr/local/cuda/bin/nvcc"

is not able to compile a simple test program.
It fails with the following output:
Change Dir: /home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeTmp
Run Build Command(s):/usr/bin/make cmTC_da6cc/fast && /usr/bin/make  -f CMakeFiles/cmTC_da6cc.dir/build.make CMakeFiles/cmTC_da6cc.dir/build
make[1]: Entering directory '/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeTmp'
Building CUDA object CMakeFiles/cmTC_da6cc.dir/main.cu.o
/usr/local/cuda/bin/nvcc  -ccbin=/home/glad/nvidia/nvidia_sdk/DRIVE_OS_5.2.0_SDK_Linux_OS_DRIVE_AGX_XAVIER/DRIVEOS/toolchains/gcc-linaro-7.3.1-2018.05-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-g++  -I/home/glad/nvidia/nvidia_sdk/DRIVE_OS_5.2.0_SDK_Linux_OS_DRIVE_AGX_XAVIER/DRIVEOS/drive-t186ref-linux/targetfs/../include -I/targets/aarch64-linux/include   -x cu -c /home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeTmp/main.cu -o CMakeFiles/cmTC_da6cc.dir/main.cu.o
cc1plus: fatal error: cuda_runtime.h: No such file or directory
compilation terminated.
CMakeFiles/cmTC_da6cc.dir/build.make:85: recipe for target 'CMakeFiles/cmTC_da6cc.dir/main.cu.o' failed
make[1]: *** [CMakeFiles/cmTC_da6cc.dir/main.cu.o] Error 1
make[1]: Leaving directory '/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeTmp'
Makefile:141: recipe for target 'cmTC_da6cc/fast' failed
make: *** [cmTC_da6cc/fast] Error 2

CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
cmake/MainConfiguration.cmake:42 (enable_language)
CMakeLists.txt:18 (include)
-- Configuring incomplete, errors occurred!
See also "/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeOutput.log".
See also "/home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros/CMakeFiles/CMakeError.log".
<== Failed to process package 'nvidia_gmsl_driver_ros':
Command '['/home/glad/ros_catkin_ws/devel_isolated/map_msgs/env.sh', 'cmake', '/home/glad/ros_catkin_ws/src/nvidia_gmsl_driver_ros', '-DCATKIN_DEVEL_PREFIX=/home/glad/ros_catkin_ws/devel_isolated/nvidia_gmsl_driver_ros', '-DCMAKE_INSTALL_PREFIX=/home/glad/ros_catkin_ws/install_isolated', '-G', 'Unix Makefiles']' returned non-zero exit status 1
Reproduce this error by running:
==> cd /home/glad/ros_catkin_ws/build_isolated/nvidia_gmsl_driver_ros && /home/glad/ros_catkin_ws/devel_isolated/map_msgs/env.sh cmake /home/glad/ros_catkin_ws/src/nvidia_gmsl_driver_ros -DCATKIN_DEVEL_PREFIX=/home/glad/ros_catkin_ws/devel_isolated/nvidia_gmsl_driver_ros -DCMAKE_INSTALL_PREFIX=/home/glad/ros_catkin_ws/install_isolated -G 'Unix Makefiles'
Command failed, exiting.

There are multiple errors, I would suggest to tackle them one-by-one:

file failed to open for writing (Permission denied) - this is unusual for building something in your home directory. Any chance you used sudo during cloning the repo or for build? I would suggest redoing cloning and building from scratch and avoid sudo.
fatal error: cuda_runtime.h: No such file or directory - this hints for CUDA not being installed. While installation instructions really don't mention CUDA, it might be a oversight from our side. Can you follow CUDA installation instructions and get back to us if it fixed your error?


Texas Supreme Court

Last opinion is from Dec. 23, 2014. Something changed on their site, because there are January 2015 opinions available.

I've done a lot of work on Texas lately. I think this is probably fine.


[FR] add bool template parameter to *_constrains in

Summary:
In the Stan compiler stuff can be written like
      local_scalar_t__ sd_1 = in__.scalar();
      current_statement__ = 5;
      if (jacobian__) {
        current_statement__ = 5;
        sd_1 = stan::math::lb_constrain(sd_1, 0, lp__);
      } else {
        current_statement__ = 5;
        sd_1 = stan::math::lb_constrain(sd_1, 0);
      }

But jacobian__ is known at compile time so we can have a reader.*_lb_constrain<>(...) that takes in a bool template parameter so the above can just become
      local_scalar_t__ sd_1 = in__.scalar_lb_constrain<jacobian__>(0, lp__);

for matrices things like that will matter a good bit
Current Version:
v2.26.0

@rok-cesnovar I wrote this up over here. But if you writing the rep_array<>() thing should these also have the same return type as the first tempalte parameter thing so you can reuse that scheme in the compiler? Haven't written tests for this yet so pretty easy for me to flip it around and do that

Yes, that would be great! I am working on adding rep matrix atm , for both matrix_cl and varmat.


Multi-ETCD node deployment, networking issue

All machines are using <IP_ADDRESS> as an IP, causing issues.
See gist: https://gist.github.com/stephenrlouie/763c08eee8a02d5920ac0902d66557f4

Is it Vagrant+VirtualBox?
On Vagrant+VirtualBox first (and default) interface is NAT-only interface, and local network (connected to other VMS) is second network interface.
I fixed bunch of issues related to this in kubernetes/contrib.

Yea its Vagrant+VirtualBox.
Right now the first interface is an internal network for provisioning and PXE booting.

@stephenrlouie it's my understanding that etcd ha is not working or supported in contrib. @adamschaub is working on adding and testing etcd ha. @adamschaub any updates on etcd ha that you can provide?

@rutsky Addressed this with kubernetes/contrib#724. Tested it on CentOS7, static two node etcd cluster:
[vagrant@kube-node-1 ~]$ etcdctl set /test-message "Hello"
[vagrant@kube-master ~]$ etcdctl get /test-message ... Hello

@adamschaub can you verify etcd clustering works for coreos too?

@danehans Correct, tested it today on vagrant.

@stephenrlouie, need to reopen for our gemini/vagrant work. kubernetes/contrib/#724 was published by rutsky to fix this issue. Need to be able to configure etcd interface in our vagrant dev environment.

@danehans Can we reopen this?

I'm seeing that the hostname shows up as localhost for all the ectd nodes

@adamschaub called out this line

Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_INITIAL_CLUSTER=localhost=http://<IP_ADDRESS>:2380,localhost=http://<IP_ADDRESS>:2380

Changes I made so far to try and reflect the above discussion:

#group_vars
flannel_opts: "--iface=enp0s3"
etcd_interface: "enp0s3"

Output for Debugging

#ansible output
TASK: [etcd | CoreOS | Start etcd2] *******************************************
<<IP_ADDRESS>> ESTABLISH CONNECTION FOR USER: core
<<IP_ADDRESS>> REMOTE_MODULE service name=etcd2 state=started
<<IP_ADDRESS>> ESTABLISH CONNECTION FOR USER: core
<<IP_ADDRESS>> REMOTE_MODULE service name=etcd2 state=started
<<IP_ADDRESS>> EXEC ssh -C -tt -v -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/home/vagrant/.ansible/cp/ansible-ssh-%h-%p-%r" -o IdentityFile="/home/vagrant/.ssh/ansible.rsa" -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o User=core -o ConnectTimeout=10 <IP_ADDRESS> /bin/sh -c 'mkdir -p $HOME/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052 && chmod a+rx $HOME/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052 && echo $HOME/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052'
<<IP_ADDRESS>> EXEC ssh -C -tt -v -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/home/vagrant/.ansible/cp/ansible-ssh-%h-%p-%r" -o IdentityFile="/home/vagrant/.ssh/ansible.rsa" -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o User=core -o ConnectTimeout=10 <IP_ADDRESS> /bin/sh -c 'mkdir -p $HOME/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015 && chmod a+rx $HOME/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015 && echo $HOME/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015'
<<IP_ADDRESS>> PUT /tmp/tmpWzAm0J TO /home/core/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015/service
<<IP_ADDRESS>> PUT /tmp/tmpwLheIh TO /home/core/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052/service
<<IP_ADDRESS>> EXEC ssh -C -tt -v -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/home/vagrant/.ansible/cp/ansible-ssh-%h-%p-%r" -o IdentityFile="/home/vagrant/.ssh/ansible.rsa" -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o User=core -o ConnectTimeout=10 <IP_ADDRESS> /bin/sh -c 'sudo -k && sudo -H -S -p "[sudo via ansible, key=iykneusyohliqbuoqzwlmhawvkrxemqy] password: " -u root /bin/sh -c '"'"'echo BECOME-SUCCESS-iykneusyohliqbuoqzwlmhawvkrxemqy; LANG=C LC_CTYPE=C PATH=/opt/bin:$PATH python /home/core/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015/service; rm -rf /home/core/.ansible/tmp/ansible-tmp-1460145382.33-90003943367015/ >/dev/null 2>&1'"'"''
<<IP_ADDRESS>> EXEC ssh -C -tt -v -o ControlMaster=auto -o ControlPersist=60s -o ControlPath="/home/vagrant/.ansible/cp/ansible-ssh-%h-%p-%r" -o IdentityFile="/home/vagrant/.ssh/ansible.rsa" -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o User=core -o ConnectTimeout=10 <IP_ADDRESS> /bin/sh -c 'sudo -k && sudo -H -S -p "[sudo via ansible, key=hykukdmpoglyfmvboqjmglogwvlhmufw] password: " -u root /bin/sh -c '"'"'echo BECOME-SUCCESS-hykukdmpoglyfmvboqjmglogwvlhmufw; LANG=C LC_CTYPE=C PATH=/opt/bin:$PATH python /home/core/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052/service; rm -rf /home/core/.ansible/tmp/ansible-tmp-1460145382.34-178882944752052/ >/dev/null 2>&1'"'"''
failed: [<IP_ADDRESS>] => {"failed": true}
msg: Job for etcd2.service failed because the control process exited with error code. See "systemctl status etcd2.service" and "journalctl -xe" for details.

failed: [<IP_ADDRESS>] => {"failed": true}
msg: Job for etcd2.service failed because the control process exited with error code. See "systemctl status etcd2.service" and "journalctl -xe" for details.

FATAL: all hosts have already failed -- aborting

journalctl -xe on <IP_ADDRESS>
Apr 08 20:09:16 localhost systemd[1]: Started OpenSSH per-connection server daemon (<IP_ADDRESS>:55995).
-- Subject: Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:55995.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:55995.service has finished starting up.
--
-- The start-up result is done.
Apr 08 20:09:16 localhost sshd[1084]: WARNING: /etc/ssh/moduli does not exist, using fixed modulus
Apr 08 20:09:16 localhost sshd[1084]: Accepted publickey for core from <IP_ADDRESS> port 55995 ssh2: RSA SHA256:Q02N13yuRPzOYU6trVEevwvh0iqJ+Ht8+BKGj6Krp3o
Apr 08 20:09:19 localhost systemd[1]: etcd2.service: Service hold-off time over, scheduling restart.
Apr 08 20:09:19 localhost systemd[1]: Stopped etcd2.
-- Subject: Unit etcd2.service has finished shutting down
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has finished shutting down.
Apr 08 20:09:19 localhost systemd[1]: Starting etcd2...
-- Subject: Unit etcd2.service has begun start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has begun starting up.
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=http://<IP_ADDRESS>:2379
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_DATA_DIR=/var/lib/etcd
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_INITIAL_ADVERTISE_PEER_URLS=http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_INITIAL_CLUSTER=localhost=http://<IP_ADDRESS>:2380,localhost=http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable
ETCD_INITIAL_CLUSTER_STATE=new
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_INITIAL_CLUSTER_TOKEN=etcd-k8-cluster
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost etcd2[1093]: recognized and used environment variable ETCD_NAME=localhost
Apr 08 20:09:19 localhost etcd2[1093]: etcd Version: 2.2.3
Apr 08 20:09:19 localhost etcd2[1093]: Git SHA: 05b564a
Apr 08 20:09:19 localhost etcd2[1093]: Go Version: go1.4.3
Apr 08 20:09:19 localhost etcd2[1093]: Go OS/Arch: linux/amd64
Apr 08 20:09:19 localhost etcd2[1093]: setting maximum number of CPUs to 1, total number of available CPUs is 1
Apr 08 20:09:19 localhost etcd2[1093]: listening for peers on http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost etcd2[1093]: listening for client requests on http://<IP_ADDRESS>:2379
Apr 08 20:09:19 localhost etcd2[1093]: stopping listening for client requests on http://<IP_ADDRESS>:2379
Apr 08 20:09:19 localhost etcd2[1093]: stopping listening for peers on http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost etcd2[1093]: --initial-cluster must include localhost=http://<IP_ADDRESS>:2380 given --initial-advertise-peer-urls=http://<IP_ADDRESS>:2380
Apr 08 20:09:19 localhost systemd[1]: etcd2.service: Main process exited, code=exited, status=1/FAILURE
Apr 08 20:09:19 localhost systemd[1]: Failed to start etcd2.
-- Subject: Unit etcd2.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has failed.
--
-- The result is failed.
Apr 08 20:09:19 localhost systemd[1]: etcd2.service: Unit entered failed state.
Apr 08 20:09:19 localhost systemd[1]: etcd2.service: Failed with result 'exit-code'.

journalctl -xe on <IP_ADDRESS>
Apr 08 20:12:34 localhost systemd[1]: etcd2.service: Service hold-off time over, scheduling restart.
Apr 08 20:12:34 localhost systemd[1]: Stopped etcd2.
-- Subject: Unit etcd2.service has finished shutting down
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has finished shutting down.
Apr 08 20:12:34 localhost systemd[1]: Starting etcd2...
-- Subject: Unit etcd2.service has begun start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has begun starting up.
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_ADVERTISE_CLIENT_URLS=http://<IP_ADDRESS>:2379
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_DATA_DIR=/var/lib/etcd
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_INITIAL_ADVERTISE_PEER_URLS=http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_INITIAL_CLUSTER=localhost=http://<IP_ADDRESS>:2380,localhost=http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_INITIAL_CLUSTER_STATE=new
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_INITIAL_CLUSTER_TOKEN=etcd-k8-cluster
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_LISTEN_CLIENT_URLS=http://<IP_ADDRESS>:2379
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_LISTEN_PEER_URLS=http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost etcd2[1224]: recognized and used environment variable ETCD_NAME=localhost
Apr 08 20:12:34 localhost etcd2[1224]: etcd Version: 2.2.3
Apr 08 20:12:34 localhost etcd2[1224]: Git SHA: 05b564a
Apr 08 20:12:34 localhost etcd2[1224]: Go Version: go1.4.3
Apr 08 20:12:34 localhost etcd2[1224]: Go OS/Arch: linux/amd64
Apr 08 20:12:34 localhost etcd2[1224]: setting maximum number of CPUs to 1, total number of available CPUs is 1
Apr 08 20:12:34 localhost etcd2[1224]: listening for peers on http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost etcd2[1224]: listening for client requests on http://<IP_ADDRESS>:2379
Apr 08 20:12:34 localhost etcd2[1224]: stopping listening for client requests on http://<IP_ADDRESS>:2379
Apr 08 20:12:34 localhost etcd2[1224]: stopping listening for peers on http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost etcd2[1224]: --initial-cluster must include localhost=http://<IP_ADDRESS>:2380 given --initial-advertise-peer-urls=http://<IP_ADDRESS>:2380
Apr 08 20:12:34 localhost systemd[1]: etcd2.service: Main process exited, code=exited, status=1/FAILURE
Apr 08 20:12:34 localhost systemd[1]: Failed to start etcd2.
-- Subject: Unit etcd2.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit etcd2.service has failed.
--
-- The result is failed.
Apr 08 20:12:34 localhost systemd[1]: etcd2.service: Unit entered failed state.
Apr 08 20:12:34 localhost systemd[1]: etcd2.service: Failed with result 'exit-code'.
Apr 08 20:12:37 localhost systemd[1]: Started OpenSSH per-connection server daemon (<IP_ADDRESS>:58499).
-- Subject: Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:58499.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:58499.service has finished starting up.
--
-- The start-up result is done.
Apr 08 20:12:37 localhost sshd[1231]: WARNING: /etc/ssh/moduli does not exist, using fixed modulus
Apr 08 20:12:37 localhost sshd[1231]: Accepted publickey for core from <IP_ADDRESS> port 58499 ssh2: RSA SHA256:Q02N13yuRPzOYU6trVEevwvh0iqJ+Ht8+BKGj6Krp3o

Done

Looking into some flanneld issues now (attached just incase you guys are more familiar than me)

Failed on 'Resource'
File or Directory not found

Setting different hostnames resolved my last comment.

systemctl status flanneld.service
flanneld.service: Failed to load environment files: No such file or directory
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Failed to run 'start' task: No such file or directory
Apr 12 13:39:44 core-02 systemd[1]: Failed to start flannel is an etcd backed overlay network for containers.
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Unit entered failed state.
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Failed with result 'resources'.

journalctl -xe
-- The start-up result is done.
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Failed to load environment files: No such file or directory
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Failed to run 'start' task: No such file or directory
Apr 12 13:39:44 core-02 systemd[1]: Failed to start flannel is an etcd backed overlay network for containers.
-- Subject: Unit flanneld.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit flanneld.service has failed.
--
-- The result is failed.
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Unit entered failed state.
Apr 12 13:39:44 core-02 systemd[1]: flanneld.service: Failed with result 'resources'.
Apr 12 13:40:11 core-02 locksmithd[1128]: etcd2.service is active
Apr 12 13:40:44 core-02 sshd[2588]: Received disconnect from <IP_ADDRESS>: 11: disconnected by user
Apr 12 13:40:44 core-02 sshd[2588]: Disconnected from <IP_ADDRESS>
Apr 12 13:44:03 core-02 systemd[1]: Started OpenSSH per-connection server daemon (<IP_ADDRESS>:52625).
-- Subject: Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:52625.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit sshd@2-<IP_ADDRESS>:22-<IP_ADDRESS>:52625.service has finished starting up.
--
-- The start-up result is done.
Apr 12 13:44:03 core-02 sshd[3417]: Accepted publickey for core from <IP_ADDRESS> port 52625 ssh2: RSA SHA256:a9sxElPdr96B9XklwnTme+TRd5hWFluvbotbNg9ZMgg
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:prefs.cc(51)] certificate-report-to-send-update not present in /var/lib/update_engine/prefs
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:prefs.cc(51)] certificate-report-to-send-download not present in /var/lib/update_engine/prefs
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:prefs.cc(51)] aleph-version not present in /var/lib/update_engine/prefs
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:omaha_request_params.cc(60)] Current group set to stable
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:update_attempter.cc(475)] Already updated boot flags. Skipping.
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:update_attempter.cc(658)] Scheduling an action processor start.
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:action_processor.cc(36)] ActionProcessor::StartProcessing: OmahaRequestAction
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:prefs.cc(51)] previous-version not present in /var/lib/update_engine/prefs
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:omaha_request_action.cc(257)] Posting an Omaha request to https://public.update.core-os.net/v1/update/
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:omaha_request_action.cc(258)] Request: <?xml version="1.0" encoding="UTF-8"?>
Apr 12 13:44:47 core-02 update_engine[612]: <request protocol="3.0" version="CoreOSUpdateEngine-<IP_ADDRESS>" updaterversion="CoreOSUpdateEngine-<IP_ADDRESS>" installsource="scheduler" ismachine="1">
Apr 12 13:44:47 core-02 update_engine[612]: <os version="Chateau" platform="CoreOS" sp="899.15.0_x86_64"></os>
Apr 12 13:44:47 core-02 update_engine[612]: <app appid="{e96281a6-d1af-4bde-9a0a-97b76e56dc57}" version="899.15.0" track="stable" bootid="{dcbd18d1-2f42-4d51-98ac-b11ed830c2e8}" oem="vagrant" oemversion="0.0.3" alephversion="899.1
Apr 12 13:44:47 core-02 update_engine[612]: <ping active="1"></ping>
Apr 12 13:44:47 core-02 update_engine[612]: <updatecheck></updatecheck>
Apr 12 13:44:47 core-02 update_engine[612]: <event eventtype="3" eventresult="2" previousversion="<IP_ADDRESS>"></event>
Apr 12 13:44:47 core-02 update_engine[612]: </app>
Apr 12 13:44:47 core-02 update_engine[612]: </request>
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:libcurl_http_fetcher.cc(48)] Starting/Resuming transfer
Apr 12 13:44:47 core-02 locksmithd[1128]: LastCheckedTime=0 Progress=0 CurrentOperation="UPDATE_STATUS_CHECKING_FOR_UPDATE" NewVersion=<IP_ADDRESS> NewSize=0
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:libcurl_http_fetcher.cc(164)] Setting up curl options for HTTPS
Apr 12 13:44:47 core-02 update_engine[612]: [0412/134447:INFO:libcurl_http_fetcher.cc(427)] Setting up timeout source: 1 seconds.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:prefs.cc(51)] update-server-cert-0-3 not present in /var/lib/update_engine/prefs
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:prefs.cc(51)] update-server-cert-0-2 not present in /var/lib/update_engine/prefs
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:prefs.cc(51)] update-server-cert-0-1 not present in /var/lib/update_engine/prefs
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:prefs.cc(51)] update-server-cert-0-0 not present in /var/lib/update_engine/prefs
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:libcurl_http_fetcher.cc(240)] HTTP response code: 200
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:libcurl_http_fetcher.cc(297)] Transfer completed (200), 267 bytes downloaded
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:omaha_request_action.cc(574)] Omaha request response: <?xml version="1.0" encoding="UTF-8"?>
Apr 12 13:44:48 core-02 update_engine[612]: <response protocol="3.0" server="update.core-os.net">
Apr 12 13:44:48 core-02 update_engine[612]: <daystart elapsed_seconds="0"></daystart>
Apr 12 13:44:48 core-02 update_engine[612]: <app appid="e96281a6-d1af-4bde-9a0a-97b76e56dc57" status="ok">
Apr 12 13:44:48 core-02 update_engine[612]: <updatecheck status="noupdate"></updatecheck>
Apr 12 13:44:48 core-02 update_engine[612]: </app>
Apr 12 13:44:48 core-02 update_engine[612]: </response>
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:omaha_request_action.cc(394)] No update.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:action_processor.cc(82)] ActionProcessor::ActionComplete: finished OmahaRequestAction, starting OmahaResponseHandlerAction
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:omaha_response_handler_action.cc(36)] There are no updates. Aborting.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:action_processor.cc(68)] ActionProcessor::ActionComplete: OmahaResponseHandlerAction action failed. Aborting processing.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:action_processor.cc(73)] ActionProcessor::ActionComplete: finished last action of type OmahaResponseHandlerAction
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:update_attempter.cc(283)] Processing Done.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:update_attempter.cc(319)] No update.
Apr 12 13:44:48 core-02 update_engine[612]: [0412/134448:INFO:update_check_scheduler.cc(82)] Next update check in 40m2s
Apr 12 13:44:48 core-02 locksmithd[1128]: LastCheckedTime=0 Progress=0 CurrentOperation="UPDATE_STATUS_IDLE" NewVersion=<IP_ADDRESS> NewSize=0
Apr 12 13:52:24 core-02 systemd[1]: Starting Cleanup of Temporary Directories...
-- Subject: Unit systemd-tmpfiles-clean.service has begun start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit systemd-tmpfiles-clean.service has begun starting up.
Apr 12 13:52:24 core-02 systemd-tmpfiles[3434]: [/usr/lib64/tmpfiles.d/home.conf:10] Duplicate line for path "/home", ignoring.
Apr 12 13:52:24 core-02 systemd-tmpfiles[3434]: [/usr/lib64/tmpfiles.d/home.conf:11] Duplicate line for path "/srv", ignoring.
Apr 12 13:52:24 core-02 systemd[1]: Started Cleanup of Temporary Directories.
-- Subject: Unit systemd-tmpfiles-clean.service has finished start-up
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit systemd-tmpfiles-clean.service has finished starting up.
--
-- The start-up result is done.
Apr 12 13:54:46 core-02 polkitd[2813]: Registered Authentication Agent for unix-process:3437:104503 (system bus name :1.37 [/usr/bin/pkttyagent --notify-fd 5 --fallback], object path /org/freedesktop/PolicyKit1/AuthenticationAgent
Apr 12 13:54:46 core-02 polkitd[2813]: Unregistered Authentication Agent for unix-process:3437:104503 (system bus name :1.37, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale en_US.UTF-8) (disconnected from bus)
Apr 12 13:54:50 core-02 sudo[3442]:     core : TTY=pts/0 ; PWD=/home/core ; USER=root ; COMMAND=/bin/systemctl start flanneld.service -l
Apr 12 13:54:50 core-02 polkitd[2813]: Registered Authentication Agent for unix-process:3442:104822 (system bus name :1.39 [/usr/bin/pkttyagent --notify-fd 5 --fallback], object path /org/freedesktop/PolicyKit1/AuthenticationAgent
Apr 12 13:54:50 core-02 systemd[1]: flanneld.service: Failed to load environment files: No such file or directory
Apr 12 13:54:50 core-02 systemd[1]: flanneld.service: Failed to run 'start' task: No such file or directory
Apr 12 13:54:50 core-02 systemd[1]: Failed to start flannel is an etcd backed overlay network for containers.
-- Subject: Unit flanneld.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit flanneld.service has failed.
--
-- The result is failed.
Apr 12 13:54:50 core-02 systemd[1]: flanneld.service: Failed with result 'resources'.
Apr 12 13:54:50 core-02 polkitd[2813]: Unregistered Authentication Agent for unix-process:3442:104822 (system bus name :1.39, object path /org/freedesktop/PolicyKit1/AuthenticationAgent, locale en_US.UTF-8) (disconnected from bus)

@rutsky @danehans @adamschaub
This error was resolved by assigning the node as both an etcd and a node.
I think contrib is broken on assigning a machine, just to etcd.
[master]
A
[etcd]
A
B
[node]
C
D

B does not get flanneld files, it gets skipped in ansible, and fails when we try to start flanneld, it won't work because it does not get any of the set up for flanneld.
I'm in the process of validating and will open an issue on contrib if this is correct

confirmed on /contrib/ansible/vagrant. Filed the issue: https://github.com/kubernetes/contrib/issues/763


Add violations for Guava NavigableMap/Set methods

Since Java 8 there are java.util.Collections alternatives for

unmodifiableNavigableMap
synchronizedNavigableMap
unmodifiableNavigableSet
synchronizedNavigableSet

Thank you for your contribution @snago!


Add Dark Engine

SteamDB app page links to a few games using this
https://steamdb.info/app/211600/
https://steamdb.info/app/211740/
Brief explanation of the change
Add the Dark Engine, used in the Thief series by Looking Glass Studios.

Two apps.

good news, that's what i marked

there's also another game that is supposed to use this engine, but idk if 3 games is enough

Actually, the Dark engine and Shock engine are supposed to be separate things, but they are very similar.

@Lifeismana Wait, so did you want me to ADD "res/intrface.crf", or to REPLACE "DROMED.ZIP" with it? Because you said to do one thing in "Engine.DarkEngine.txt", and the other in "rules.ini".

Replace the rule and replace the old strings with the string i gave and then run the generate strings script

After running changed rules in this pull request (this bot only tests rules.ini changes):
Changed technologies: Engine.DarkEngine
These apps now match: (3)<PHONE_NUMBER>40 238210
Please confirm that all these changed apps are correct.

not used by enough apps


feat(docs): rename docs/reference/sql-rest to docs/reference/sql-openapi

fixes #315

@simonplend could you take a look?

Any news about this?

We are currently in London for a few conferences ;).

@marcelom97 I'll be looking at this today.

I've opened a PR for the OSS site to reflect these renaming changes in https://github.com/platformatic/oss/pull/42.
Related new issue that I'll be picking up: https://github.com/platformatic/platformatic/issues/355


Update resources.json

My contribuition is  to Add a new podcast api

Hi, and thank you for the contribution.
The /db folder is auto-generated, and changes must be made in the /resources folder.
Could you please amend this PR?
Our CONTRIBUTING guide has instructions that might help you.
Thanks!


Use riakcs swap for postgres too

Would this work, @benrudolph @snopoke ? (I have not tested this!)

Yes.

my preference for this would be to just selectively add swap to the machines we need. don't think it's great to rely on swap. that said not super convinced it matters that much

+1 to only have this on machines we want. I haven't looked closely but this might only get applied to hosts with the swap_size var set (which gets set in inventory).

closing this out because https://github.com/dimagi/commcarehq-ansible/pull/706 likely supersedes it


Bugfix/audio

Audio fixes for both VR and non-VR modes.
Voice audio has been fixed to automatically skip to next voice in VR.
Preview here: https://pr-340.lba2remake.net

Yay! 👍


Fix unnecessary marshalling of data

Fixes https://github.com/numaproj-labs/numaplane/pull/163#discussion_r1532533747
Modifications

Remove unnecessary marshalling and Unmarshalling of while generating manifest.

Verification

Tested the changes in local kind cluster for raw, kustomize and helm

can you review this one @xdevxy ?


fix_win11_aot_compile_NoSuchFileException,because of File.separator

What is the purpose of the change
fix win11 graalvm17 dubbo aot compile throws java.nio.file.NoSuchFileException
Brief changelog
Because in Windows OS ,   file separator is  "\" .
However in jvm/graalvm ,  .class file  URL is always  splited by  "/"
So the   following code does not work in Windows
org.apache.dubbo.aot.generate.JarScanner#toClassName(String path)
path.substring(0, path.length() - 6).replace(File.separator, ".")

I change to
path.contains(File.separator) ? path.substring(0, path.length() - 6).replace(File.separator, ".") : path.substring(0, path.length() - 6).replace("/", ".");

Checklist
[y] dubbo_issue: win11 graalvm17 dubbo aot compile throws java.nio.file.NoSuchFileException

Codecov Report

Merging #12769 (db25121) into 3.3 (80d496c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #12769      +/-   ##
============================================
- Coverage     68.11%   68.08%   -0.03%
  Complexity        6        6
============================================
  Files          1703     1703
  Lines         70133    70133
  Branches      10175    10175
============================================
- Hits          47768    47752      -16
- Misses        17719    17733      +14
- Partials       4646     4648       +2

see 26 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Stack overflow

I have a relatively small Python program that I tried running pylyzer on. In (and outside) my virtual enviroment I execute pylyzer /path/to/project/main_of_project.py and I get:
cannot open '/path/to/project/source/utils/dependency1.py': [Errno 2] No such file or directory (os error 2)
cannot open '/path/to/project/source/utils/dependency2.py': [Errno 2] No such file or directory (os error 2)
cannot open '/path/to/project/source/dependency3.py': [Errno 2] No such file or directory (os error 2)
cannot open '/path/to/project/source/dependency4.py': [Errno 2] No such file or directory (os error 2)
cannot open '/path/to/project/source/dependency5.py': [Errno 2] No such file or directory (os error 2)

thread 'main' has overflowed its stack
fatal runtime error: stack overflow
Aborted (core dumped)

All dependency files are of course available.

Python: 3.11
OS: Kubuntu 23.04 x86_64
Kernel: 6.2.0-20-generic
Pylyzer: 0.0.27

Please update pylyzer to the latest version. If that does not solve the problem, please report the smallest code that reproduces the problem.

Fixed, thanks!
(tested with v0.0.29)


Support setting the BIOS implementation (seabios|ovmf)

This allows booting UEFI VMs.
This requires: https://github.com/Telmate/proxmox-api-go/pull/69.

This is merged,Telmate/proxmox-api-go#69 but you'll need to update the module references.


Delete button on loadouts doesn’t work

Tapping the delete button in the  loadout sheet or page does nothing. My assumption is that this is due to the confirmation dialogue we pop up here.

Ah thanks! I patched this but an having a heck of a time with the review process. #3
I'll give it another try with them

Duplicate of DestinyItemManager/iOS#3

FYI looks like apple finally pushed the update! Should be fixed now.


Enable RSSI on Pixracer

@pkocmoud @kd0aij It would be great if you could cross-test this. This will enable RSSI sampling. I need to find the right min/max scaling still.

Does this assume that RSSI is a PWM signal?

It assumes its either really analog or a PWM signal, yes. The massive lowpass filter is to make them look both analog.

Just measured the RSSI PWM frequency on a D4R-II: 110KHz
What's the ADC sampling frequency?


Journal title did not get populate on the form when user tries to "Finish" a submission

Steps:

logs on as nih-user
go to Submissions screen
Click Finish Submission on the submission with status "Manuscript Expected"
Enters the submisison workflow, observe that the DOI and TItle field has been prepopulated but the journal title field has not.

When I ran pass-ember, the test submission that can be "Finished" did not have a Journal attached to its Publication, so the workflow was unable to populate the journal field. The journal field is populated correctly when editing a draft submission.


[from qiskit] Max Likelihood Amplitude Estimator applies post processing twice to the confidence interval

What should we add?

Information

Qiskit Terra version: 0.17.1
Python version: 3.8.3
Operating system: macOS 11.2.3

What is the current behavior?
The confidence_interval of the Max Likelihood Amplitude Estimator is already rescaled. The confidence_interval_processed is rescaled twice. This does not happen for example with the Iterative Amplitude Estimator
Steps to reproduce the problem
Run a Max Likelihood Amplitude Estimator with a post processing function
What is the expected behavior?
Have the confidence_interval not rescaled, and the confidence_interval_processed only rescaled once
Suggested solutions
I haven't seen where the bug is

Opened by @Francesco-Benfenati
Original issue & discussion: https://github.com/Qiskit/qiskit/issues/6243


feat: disallow changing existing mentee/mentor

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/tracks/tracks.controller.ts  2

See the complete overview on Codacy


System.NullReferenceException: FileTarget.GetCompressedLogsInternal

Case: Get Compressed Logs in AppCenter Crashes.GetErrorAttachments delegate.
Bug:  _logFolder is null when GetCompressedLogsInternal is called before EnsureInitialized is called in FileTargetBase.WriteAsyncCore.
Tested solution proposal: Add EnsureInitialized in FileTargetBase.GetCompressedLogs.
   public async Task<MemoryStream> GetCompressedLogs()
    {
        using (await _lock.LockAsync().ConfigureAwait(false))
        {
            CloseAllOpenStreamsInternal();
            await EnsureInitialized().ConfigureAwait(false);
            return await GetCompressedLogsInternal().ConfigureAwait(false);
        }
    }

Hi there, and thanks for your proposal :)
Is it just a hypothesis or did you verify that it actually fixes the issue?

Yes, verified! Running it now in my MAUI app. :) (In an local version of this library)

will merge this in a heartbeat :)
There is also this: https://github.com/roubachof/MetroLog/issues/7 if you want to be able to have custom prompt

PR created! (Added #7 with sample layout in sample project and had to fix namespace) :)


if you plan to incorporate functionality for multi-label tasks into Bluecast?

Hi @yangfa-zhang !
So far I did not have any particular plans. Could you elaborate what exactly you would need?

Would be a non-CV (aka single model) instance be sufficient?
Do you have a small example dataset at hand for testing purposes?

Hi @thomasmeissnercrm !
I noticed that in class_problem there are only options for binary, multi-class, and regression. For instance, if we have a dataset where we want to predict both the type of fruit (multi-class) and its weight (regression), the current options in Bluecast might not suffice. Can we include models in Bluecast that can predict multiple variables?

From what you describe it sounds like you would like to get the class scores of all classs in a multiclass problem. When using BlueCast class, you get the class scores of all classes.
With BlueCastCV  you can specify return_sub_models_preds=True to receive class scores of all classs.
You can see this in the following overview notebook as part of a multiclass kaggle competition.
Is that what you are looking for?

thanks！ @ThomasMeissnerDS


ECMA 6 Support / Parsing Override

This would be more of a feature request, or "does this exist already" type issue.
I am working on a project that makes use of ECMA via the --harmony command line option. However, the parser in Visual Studio does not see the usage of ECMA things as valid. Such as fat arrows and similar.
http://i.imgur.com/wxsDPD5.png
Along with that multiple usage lands up causing VS to nearly stop parsing a file that makes use of ECMA 6 features heavily causing a 'Too many errors' report saying the file is probably not a Javascript file.
Just wondering if there are plans to override the parser to allow ECMA 6 features, or if this feature already exists.
I'm using Visual Studio 2013 Update 4.

ES6 Usage in the Editor
Some ES6 usage will cause IntelliSense to fail in a broader sense - this includes things that involve new syntax. For example arrow functions will give syntax errors, but new methods on array just won’t show up in IntelliSense and won’t be analyzed. New scoping rules would probably just give wonky IntelliSense. So really only things that involve new syntax would show up as being broken (display errors and otherwise hurt IntelliSense).
Until we implement those features, you can work around any IntelliSense issues by ignoring directories for analysis
Taken from wiki :
https://github.com/Microsoft/nodejstools/wiki/io.js-and-ES6-support

Ah totally overlooked the wiki on here, sorry about that. Answers this question / feature request then.
Thanks for the link.

Can the wiki be updated to discuss debugging limitations with iojs as well?  Also would be great to talk about transpilation with babeljs using require("babel/register");
Visual Studio has the opportunity to provide an amazing node debugging experience with modern javascript, especially since nobody else is even close to doing it well.


ESP32 C3 support please. WiFi is working but not BLE

I am using ESP32 C3 from ai-thinker and ESP32-C3-DevKitM-1 .

@jamesjian007 ESP32C3-AT support BLE is an internal ongoing work.
The first ESP32C3-AT firmware, without BLE, is planned to be released in the next month.
It is planned to release the second version of ESP32C3-ATt firmware in the next two months for BLE.

BLE in ESP32C3-AT will use new  AT BLE commands, different from ESP32-AT, for ESP32C3 will use NimBLE.

@jamesjian007 ESP32-C3 AT released: https://github.com/espressif/esp-at/releases/tag/v<IP_ADDRESS>_esp32c3
this is the first ESP32C3-AT version, without BLE, please know.

Any latest news about the second version of ESP32C3-AT? Waiting for BLE support.

@leungngok Sorry for possible inconvenience. Here are latest updates from internal.

we are in testing ESP32-C3 BLE internally now
ESP32-C3 firmware with BLE will be available in latest month (without full-test internal)
ESP32-C3 firmware with BLE is planned to be released around the end of october
ESP32-C3 AT BLE commands should be same as ESP32

please know.

@jamesjian007 ESP32C3-AT support BLE is an internal ongoing work.
The first ESP32C3-AT firmware, without BLE, is planned to be released in the next month.
It is planned to release the second version of ESP32C3-AT firmware in the next two months for BLE.

BLE in ESP32C3-AT will use new  AT BLE commands, different from ESP32-AT, for ESP32C3 will use NimBLE.

@jamesjian007 ESP32-C3 AT released: https://github.com/espressif/esp-at/releases/tag/v<IP_ADDRESS>_esp32c3
this is the first ESP32C3-AT version, without BLE, please know.

My target hardware  is ESP32-C3-DevKitM-1 v1.0  and the revision is 2: ESP32C3_REV_MIN_2 on menuconfig.
ESP-IDF version: ESP-IDF v4.3-beta3-195-g6be10fab0
UART AT console:
ready
AT+GMR
(No reply to AT commands)

@mtuxpe sorry, ESP32-C3 ECO2 (the revision is 2) chip is not supported, for it is not the massive product chip.
please use ESP32-C3 ECO3 (the revision is 3) chip instead.

Is the ESP32-C3 firmware with BLE now?

@donghang6 yes, ESP32-C3 AT supports BLE now, you can Download the Latest Temporary Version of AT Firmware from GitHub or Compile ESP-AT Project.
btw, we are in first round testing for ESP32-C3 release internally.

May I know if there is any update? If the issue still exists, please let us know.

Congrats. BLE is working
AT+GMR
AT version:<IP_ADDRESS>(s-4c6eb5e - ESP32C3 - May 20 2022 03:12:30)
SDK version:v4.3.2-553-g588436db47
compile time(40ae56a):May 27 2022 11:29:02
Bin version:2.4.0(MINI-1)
Tested on ESP32-C3-DevKitC-02 and ESP32-C3S_Kit


transfer to moneta-org?

@asppsa It would be great if we could transfer the gem to a moneta-org since the travis builds are hogging my pipeline ;) What do you think?

Yes, this sounds great.  Do you want me to create the org?  I see that moneta is taken already, so perhaps something like moneta-rb?

Docs are here: https://help.github.com/en/articles/transferring-a-repository

Yes, you can create that with us as admins and I will transfer the repo. moneta-rb sounds good!


[Hidden files] - Add support for moving or permanently deleting a hidden folder

For #2303
Fixes an issue for which you currently cannot move or permanently delete a hidden folder
Fixes an issue for which no icons are shown in recycle bin

@gave92 When you insert a hidden folder into another folder, it becomes not hidden.


Update libsodium to 1.0.18

Alignment patch is no longer needed with this update.

Pull Request Test Coverage Report for Build 982

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.648%

Totals

Change from base Build 980:
0.0%

Covered Lines:
2900

Relevant Lines:
3064

💛  - Coveralls

What is the reason for it not being needed though?

I'm not sure but it doesn't really matter. We have committed bindings into the repo so they always will be correct once generated correctly. Because of this we support only one version of libsodium (but anyway alignments won't break even for different versions). Also we have manually written test for alignments so it's even not possible to generate incorrect bindings without being noticed: https://github.com/sodiumoxide/sodiumoxide/blob/69a69fb091c59cb853230cee5a1e4d58780ca5a8/libsodium-sys/tests/crypto/crypto_generichash_blake2b.rs#L8

That’s true. I’ll approve the pull request. However I would be even happier if we could add a test to check the alignment so we don’t get any regressions next time we regenerate the bindings.

But we have it, see the link from my previous comment :)

Sorry. I’m on mobile and a bit sleep deprived. :)
On Fri, 7 Jun 2019 at 09:12, Evgeny Kurnevsky<EMAIL_ADDRESS>wrote:

But we have it, see the link from my previous comment :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/sodiumoxide/sodiumoxide/pull/342?email_source=notifications&email_token=AAJ5KBKNOAV6TG74DM5WSGDPZIC6RA5CNFSM4HUATIW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXFBIMA#issuecomment-499782704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ5KBKEKRDHU5MNTTEDIB3PZIC6RANCNFSM4HUATIWQ
.

It seems it was bindgen: https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md#0480
Fixed comments.

Then we should add an updated min dependency for bindgen
On Fri, 7 Jun 2019 at 09:18, Evgeny Kurnevsky<EMAIL_ADDRESS>wrote:

It seems it was bindgen:
https://github.com/rust-lang/rust-bindgen/blob/master/CHANGELOG.md#0480
Fixed comments.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/sodiumoxide/sodiumoxide/pull/342?email_source=notifications&email_token=AAJ5KBM6ZQBBHA7WJRNI3MLPZIDVLA5CNFSM4HUATIW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXFBTSY#issuecomment-499784139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ5KBIL2ZXVIC5RF42OXPDPZIDVLANCNFSM4HUATIWQ
.

We don't depend on bindgen anymore and don't specify it's version anywhere - it's used only when bindings are generated.

it's used only when bindings are generated.

Add a comment with min bindgen version to .sh file

bors r+