Add reverse binomial with tests.

See https://math.stackexchange.com/a/103385/205 for details

As a first observation this seems to be a direct translation of the python code snippet in the stack exchange link.

As a first observation this seems to be a direct translation of the python code snippet in the stack exchange link.

@hernanmd as I mentioned above, the code appears to be python translated, almost literally to Smalltalk. Is this the case?
I think findNK could be made more intention revealing. Could the code be refactored a little as I can't seem to follow it too easily (I'm having an off day!).

@hernanmd as I mentioned above, the code appears to be python translated, almost literally to Smalltalk. Is this the case?
I think findNK could be made more intention revealing. Could the code be refactored a little as I can't seem to follow it too easily (I'm having an off day!).

@hernanmd as I mentioned above, the code appears to be python translated, almost literally, to Smalltalk. Is this the case?
I think findNK could be made more intention revealing. Could the code be refactored a little as I can't seem to follow it too easily (I'm having an off day!).

Yes, it is a translation from Python code that's why I included the link :)
I don't see how it could be refactored because Integer can easily explode.

@hernanmd as I mentioned above, the code appears to be python translated, almost literally, to Smalltalk. Is this the case?
I think findNK could be made more intention revealing. Could the code be refactored a little as I can't seem to follow it too easily (I'm having an off day!).

Yes, it is a translation from Python code that's why I included the link :)
I don't see how it could be refactored because Integer can easily explode.

Chasing up on this PR, @hernanmd . Let us know when you've addressed review comments and then we can merge

Chasing up on this PR, @hernanmd . Let us know when you've addressed review comments and then we can merge

Move to 1.0.4 milestone

Can we merge? @hemalvarambhia

@SergeStinckwich I think the code quality may be improved. Plus, there has been no addressing of comments or any other activity.
I would close it rather than merge. That way, it can reopened when the author has energy and capacity.
What do other reviewers think?

@SergeStinckwich I think the code quality may be improved. Plus, there has been no addressing of comments or any other activity.

Can you detail which aspect of the code could be improved?
IMHO it seems too much revision for a single method addition, I would love to know why or simply discard this addition definitely.

The main concern of @hemalvarambhia is about names. Could you use better names for findNK and firstOver: ?

I propose to replace findNK by findAllNKGivenBinomialCoeffor inverseBinomialCoefficient.
You can remove firstOver:and replace directly in the code: nmin := k firstOver: (k factorial * self).by nmin :=  (k factorial * self) nthRoot: k..

I propose to replace findNK by findAllNKGivenBinomialCoeffor inverseBinomialCoefficient.
You can remove firstOver: (and tests) and replace directly in the code: nmin := k firstOver: (k factorial * self).by nmin :=  (k factorial * self) nthRoot: k.

inverseBinomialCoeffient feels more concise IMHO. Could you use Kent Beck's 'Refactor to composed method' to improve the maintainability. This is the only concern that I have.

@hernanmd This is only my opinion and it is important that others weigh in. If more disagree with my view, ignore the following:
my concern is the structure of findNK. It feels very nested, with while and nested ifTrue messages so I sense there is a risk to maintainability and understandability, a key trade off for me. The method is also long. One option to improve things might be to appeal to 'refactor to composed method' (cf Kent Beck's 'Smalltalk Best Practice Pattern')

Thank you Hernan.


add new tutorials

Closes: https://github.com/onflow/flow/issues/958
Description
Added the new tutorials from https://github.com/onflow/cadence/pull/1727/files so they show up in the docs site.

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

I've merged the cadence PR now, so this is ready to merge @10thfloor

Just seeing this now


Incorrect formatting within lambdas for multiplication sign

Expected Behavior
Code (shown as an example, only to show an error):
val variable1=2
val variable2=3
val variable3=false
val variable4=variable3.takeIf{variable3}.run{variable1*variable2}

after formatting:
val variable1 = 2
val variable2 = 3
val variable3 = false
val variable4 = variable3.takeIf { variable3 }.run { variable1 * variable2 }

Observed Behavior
val variable1 = 2
val variable2 = 3
val variable3 = false
val variable4 = variable3.takeIf { variable3 }.run { variable1*variable2 }

Did a bit of debugging and it looks like this only occurs for multiplication specifically because it's getting caught up in the line designed to ignore spacing for things like fn(*array):
!(node.elementType == MUL && node.isPartOf(KtValueArgument::class)) && // fn(*array)

Will take a look at a solution to more specifically differentiate between fn(*array) and thing.run { thing1*thing2 } cases


(Regression) Non Fungible tokens transfers not showing correctly on Jakartanet, and when manually adding they show in Fungible token section

Issue #629 is back and the same problem we had on Ithaca last time is now happening on Jakarta
This was the fix hopefully it can get integrated quickly.
Perhaps ghostnet support can be added at the same time to avoid this in the future.

Ghostnet support added


Adding a segment does not resize feature map

Version and Platform (required):

Binary Ninja Version: 3.5.{dev}
OS: macOS
OS Version: 12.5
CPU Architecture: M1

Bug Description:
When I use the segments editor and add a segment to the file, the feature map does not update to show the added segment, even if "file-backed only mode" is disabled.
Steps To Reproduce:

Open a file
Observe feature map
Open memory maps panel
Add a segment at the start of the binary (addr 0 length 0x100000 data addr 0 data length 0)
Observe feature map does not update
Right-click feature map and enable File-Backed only mode
Right-click feature map and disable File-Backed only mode
Observe feature map has updated

Expected Behavior:
I expected feature map to update automatically
Additional Information:
Via Andrew :)

The Feature Map will now update for segment and/or memory map changes.
Fixed in 4.2.5758.


MiqAeObject fixes

Remove duplicate code
Fix Whitespace
Convert ifs to case

@gmcculloug @mkanoor Please review

Looks good to me.

👍


Added the onBoarding user filter and written its respective test

Added the OnBoarding Users Filter-
-We can now filter the users whose state is Onboarding
-Written the tests which verifies this behaviour
Issue - #1144

Add the screenshots in the main comment section please

Add the screenshots in the main comment section please

Screenshots for what exactly ? Response after hitting api to see whether we are getting onboarding users or not ? Correct me if I am wrong @sahsisunny

Add the screenshots in the main comment section please

Hello @naivecoder786...you done great work
Can you please attach test coverage in description because in realdevsquad this is rule :)

Thanks @shubhamsigdar1 for the info ! I am attaching it the main description. I think we should add in the PR rules where beginners could see this at the beginning only.

@naivecoder786 you closed this pr...okkk I will do it then


The desktop app will default open link in browser

wait please, I will add a remove-browser-open attribute

ok

Looks great :) Thank you!


adult dataset encounters mu=nan sample in antecedent length=1

Hi Archon,
When running the sample code on adult dataset, the calculation for mu is nan for one sample (indexed 185 of the 239 length1 antecedents).
The observation is that the satis_mask for this sample is all False, the selected satis_ans is an empty list [] .
This is the breakpoint check for variable mu in the following stack
__get_answer__, dataset.py:885
__init__, dataset.py:792
create_pretrain_dataset, dataset.py:650
, pretrain_consequent_estimator.py:130

Reproducable on two different machines (one on Mac, one on Centos).
Previous commands
python3 base.py --dataset adult --base dnn --gpu 1
python3 extract_base_embedding.py --dataset adult --base dnn --gpu 1
python3 build_atom_pool.py --dataset adult --base dnn
python3 sample_antecedents.py --dataset adult --base dnn --gpu 1
python3 pretrain_consequent_estimator.py --dataset adult --base dnn --gpu 1

the nan of mu is in pretrain_consequent_estimator.py, the program will crash in selor.py as it encounters nan.
(no gpu is used, I set the value of gpu as gpu = torch.device('cpu'))

Hi, @haojx07
I added a new commit to solve the issue.
Please check if it works with your environment.

Hi @archon159 ,
It looks good so far, the NaNs disappear.

Great.


RFC: Rust 2018 Roadmap

This RFC sets the Rust 2018 Roadmap, in accordance with RFC 1728. This year's goals are:

Ship an epoch release: Rust 2018.
Build resources for intermediate Rustaceans.
Connect and empower Rust’s global community.
Grow Rust’s teams and new leaders within them.

In pursuing these goals, we will focus particularly on four target domains for Rust:

Web services.
WebAssembly.
CLI apps.
Embedded devices.

A hearty thank you to the 100-some people who wrote blog posts to help drive this process!
Rendered

@aturon @Lokathor I think your side-discussion on game development and other applications domains which didn't make the Rust2018 cut was interesting, and is likely to be raised again in the future. Is there any hope that it could be added to the Drawbacks/Alternatives section of the RFC document in some form so that it does not get forgotten?

This RFC looks good overall, in the current form and with the general direction it is doing. I like the idea of internationalization and growing the community along this axis. Also I really like that embedded devices and WebAssembly are two of the target choices.
For me, the saddest part of this RFC is probably that stabilisation of const generics is being deprioritized beyond a "maybe this will get stable during 2018". I understand though that one can't have a focus on everything...
I've already summarized my ideas on Rust in my post about it. So I won't spend much on reiterating my ideas in this thread or starting a comparison between what's in the RFC and my own suggestions.
Mostly I'm quite positive about this roadmap. It seems very reasonable overall and well explained.
Also: I've really liked the idea of calling for blog posts! Please do this next year as well :).

While I use nightly for personal projects, at work I use stable because I think it'll make my life simpler in the long run. That said, there are a lot of places where I'd love to use features like impl Trait and non-lexical lifetimes. By comitting to stabilizing them this year, I'm more comfortable switching to nightly at work, so we can develop with them now but still stay on stable in the long run.

Connect and empower Rust's global community. We will pursue internationalization as a first-class concern

Will this entail the stabilization of the non_ascii_idents feature (tracking issue)? Its current status seems to be that we want someone to research and write an RFC defending the adequacy of the current implementation (or proposing whatever changes may be necessary). (I might be able to do this?)

I think the focus on finishing stuff from last year makes good sense.  I agree the web is an awfully big target of course, but it sounds completely reasonable to work out generators and improve tokio to do asynchronous servers better and improve web assembly output.

Oh hey, thanks for the name drop!
The section on documentation for the 2018 epoch kinda feels like we're focusing exclusively on Rust By Example and the book, but we have also been spending some effort on the Reference as well. We've started bringing in some Docs Team Peers (that list is already out of date >_>) to field contributions and lead polishing efforts for specific documents. Right now we have a couple on the Reference and a couple on RBE, and they've already helped immensely. We're using this as a springboard to bring more people into the docs world.

@QuietMisdreavus Wanna make a PR-to-the-PR to flesh that section out a bit?

@aturon I can give it a shot. I don't have wording for it thought out yet, but i can try getting something sketched up and opening it up for the rest of the team to complete.

@HadrienG2 Great idea -- I've pushed a commit which adds such a discussion.
All: it would appear that we have very broad consensus on the overall roadmap, and the teams are already starting to focus on plans for execution. As such, I'm going to go ahead and get the formal review process started:
@rfcbot fcp merge

Explaining the changes to the RFC proposal in https://github.com/rust-lang/rfcs/pull/2314/commits/c52be1a5b2bd0ee9cd185935214ab88805a12645 - focusing on testing
In addition to the four domains, we will also focus on providing a great experience for writing tests in Rust - this is a cross cutting concern for all domains and all rustaceans. We will also focus on testing so that we may gain confidence in the quality and reliability of our offerings the 4 domains. To that end, we will at least land an eRFC for custom testing frameworks (such as #2318) and create a working group that will focus on the consolidation and integration of testing libraries (such as hamcrest, spectral, proptest, quickcheck). Please note however that we won't focus on testing as much as any of the 4 domains.

@aturon I'm not sure whether you forgot about the idea of having a team for crates which are abandoned. @vitiral and @KodrAus did not make any comment on that either. So let me ask how to continue on this topic? Outside of the roadmap for 2018 and if yes, where/how?

@matthiasbeyer A great place would be to talk on this internals thread about Libs Team activities.

This sort of goes along with "embedded devices", but one area where I think Rust has huge potential but the ergonomics are still not super great still is general "embedding", i.e. producing Rust static libraries for linking into other programs. This is useful for having a single codebase that can, say, be shared between iOS and Android, or Windows and OS X, i.e. portability and low/zero overhead are key.
The concerns are quite similar to "embedded devices" in many ways (I say this as someone with a SiFive and a Hail sitting on my desk): they're generally no_std and need to be linked with other toolchains. Generally most of the Rust-on-embedded-devices development I've done has been this way: I produce a Rust static library which contains the actual program, use a tiny/trivial C shim to invoke it, and compile and link the C code with the Rust static library using a platform-specific toolchain.
Presently libraries with these sorts of requirements tend to be developed in C and C++. Cryptography is certainly an area that comes to mind for me where people are or were reluctantly writing code in C. Several cryptographers I have spoken to are excited about implementing new systems in Rust, because cryptography is an obvious area that benefits from as much safety as you can provide. There are of course tons of other areas which are interesting as well: things like machine learning, graphics, search algorithms. I think we should really be encouraging Rust developers, especially ones writing libraries that are presently #![no_std]-friendly, to be adding C ABIs to them so as to expose them to a wider audience of programmers, and perhaps this should be a bit easier than it is today.
I guess what I'm saying is don't lose the forest for the trees when it comes to "embedding". Also I'd be interested in participating in an "embedded devices"/"embedding" WG 😉 I intend to do quite a lot of embedded Rust development this year, both professionally and as a hobby.

This RFC makes it look like compiler improvements (be it code size or speed) are secondary again this year, could we put more emphasis on them? They are not even in the main bullet points of the RFC summary.

@nox Do you mean improvements to compilation speed, etc or to the actual size of the source in the rust-lang/rust repo?
I don't think that the former is true given that incr comp is going to be in stable this week (:tada:). And the latter seems to fall under tech debt, which is a goal this year.

Assuming that @nox means size of generated binaries like making Clone very tiny, I think this is already implied by the focus on both wasm and embedded use cases inside the roadmap. It doesn't hurt to make it explicit, but both with wasm and in the embedded space you don't really want 200 mb for normal use cases.

It doesn't hurt to make it explicit, but both with wasm and in the embedded space you don't really want 200 mb for normal use cases.

For the record, rewriting some Clone methods by hand just merging similar arms and whatnot in Gecko allowed me to shave hundreds of kilobytes off the final binary in total, so this should definitely be stated more explicitly, given it is already an issue even outside wasm and embedded.

For context: Gecko mostly cares about code size when shipping to android (download size). This Clone impl rewriting was replacing #[derive(Clone)] on some enums with several hundred variants.

given that incr comp is going to be in stable this week (🎉)

That’s awesome, but not the end of the road:

https://github.com/rust-lang/rust/issues/45208
https://github.com/rust-lang/rust/issues/47660

Recompiling Servo with a perfect cache (after only touching a source file’s timestamp) can still take minutes. Or as Niko wrote:

It’s worth emphasizing also that we are not done when it comes to improving compiler performance. The incremental infrastructure is working and en route to a stable compiler near you, but we need to shoot for instantaneous build times after a small change (e.g., adding a println! to a function).

(Emphasis not mine.)
Maybe this could have more than a one-line mention in the roadmap?

Also worth mentioning that incremental compilation is not the end of the road either, full builds are still very slow and there's not much that's been done in that sphere. codegen-units isn't very reliable (setting it to 1 speeds up Firefox release builds) and parallelism isn't the full solution.

Are there plans to officially push harder on efforts like rust-lang/rust#46564 ?

Thanks @nox and @SimonSapin, I absolutely agree that compiler performance remains a significant problem and should get more emphasis here. I will talk to the relevant compiler folks and figure out what more we should say.

I'm a bit disappointed that, aside from by accident (with things like SIMD) stuff like numeric, simulation, or high performance computing is missing. Rust is theoretically ideal in a lot of ways for simulations (be they games, theoretical physics, etc) and pretty good for number crunching because of a lot of the theoretical optimizations it can do because of its aliasing guarantees. However, it has a number of hindrances in working with array-based numeric types for (largely) type system reasons, as well as library immaturity.
I'm not in any way expecting anything to be changed at this point of the RFC, I just figure if those of us who use it for that never speak up it will never be a focus item in any year. I know a growing number people who use Rust with largely private code for these things who aren't really the sorts of people who are going to come knocking asking for it.

@LinearZoetrope thanks for writing in! FWIW, the Core Team also sees this area as having great potential for Rust. But at the same time, our focus for this year is on shipping what can reasonably be shipped within 2018, and given that const generics are vital in this space, but at the same time are blocked on various other work, it's simply not viable to promise even a stable foundation in 2018. Meanwhile, the four domains highlighted in the roadmap are ones where we feel like Rust can shine this year.
That said, I think a numerics WG in 2019 would be awesome, and we'd probably have enough of the foundational pieces in place by then for that to make sense.

@mark-i-m

Are there plans to officially push harder on efforts like rust-lang/rust#46564 ?

I missed this before, but yes! There's an ongoing internals thread about this. More generally, the plan is to set up a dedicated compiler performance working group, led by @michaelwoerister.

I see this RFC has entered FCP but still doesn't mention compiler improvements in the first bullet list. Am I missing something?

(Probably the wrong issue to comment on this but I can't find the issue or PR for what to put in the next epoch:)
Could we make guard a keyword in the next epoch, to revive the let...else RFC with a syntax similar to the one in Swift for that feature?

@nox there's an IRLO thread for reserving keywords. https://internals.rust-lang.org/t/keywords-to-reserve-for-rust2018-epoch/6720

The RFC has now been updated with more emphasis and significantly more text around compiler performance. @michaelwoerister will be heading up a working group on this topic.

This RFC has been merged!
There is not a tracking issue for the roadmap; we are still iterating on our approach to tracking, but see the github project page for one possibility. More on the tracking front soon!

Perhaps Rust lang should propose to work with the Khronos Group (Vulkan) to do a Rust front end?

@DrizztVD You may want to get it touch with the gfx-rs project: https://github.com/gfx-rs/gfx. Whether that matches what you have in mind or not, this probably doesn’t need to be within the Rust project.

@SimonSapin I was following on generally from @Lokathor above. The point is to make Rust for game dev more prominent since I see Khronos promoting C and Cpp which is like using a steam train when you could use an electric truck. The question is why can't Rust be the flag bearer?

They only want to focus on issues that can be delivered by the end of this year. How we will tackle multi-year issues in the future is left to be seen, but I suppose the idea is that hopefully someone will randomly get things to the point where they're less than one year to complete, and then they can get the official focus.

@Lokathor That's thinking about things the wrong way around. The idea is to create a sales pitch that can convince some industry folks to add their own resources to Rust. I've sent emails to companies randomly pitching ideas to them. The success rate is just higher if you find the right contact.

I don't entirely disagree with you, but those are the goals that they've committed to.
Nothing much is actually stopping you from getting 1st class support for rust into the official vulkan distribution, you just have to do it yourself is all :P
Note that we already have the vulkano lib, and I expect that it will get support for the new vulkan release very soon.

Understood. But, my point is centred on the premise that marketing efforts are a direct benefit to a product. Hence, why should the Github community defer such aspects? Any company will budget well for marketing, thus, it may be useful and 'profitable' to have a focus on building industry relations directly. Such an effort can only occur successfully through the community as an entity, not by any one member.

@DrizztVD In general, this RFC describes what we - from the perspective of beginning of 2018 - can commit to with the resources that we have and the demands that we get.
It's an action plan, not a wish or idea list. As you may see, we consciously decided to not commit to a polished story for games this year. Note that this doesn't say we won't support.
The reasons are manifold, but one of the core things is: we just don't have people driving that effort and team bandwidth to make it happen. The project you describe would be a complete pivot, if we would take that on as a project. We would have to move people away from things that are currently in flight and need to be finished. Also, the RFC factors in a lot of community feedback from more roughly 100 posts and this factors into the focus.
It's tough to decide which things to cut for this year and what not. But having a lot of interesting things unfinished is - on a large scale - worse then having half of them done. The Roadmap for 2018 is about finishing things that we can. Some of that might not be obvious: WASM for example may seem like a Mozilla pet project, but there's actually HUGE demand from production users and it isn't very far from delivering a good story.
However, and that's crucial: we won't stand in anyones way and support with the resources that we have. There are, for example, people driving the adoption of Rust within the Free Desktop project, which does get engineering support.
But that means that we need a player to commit to a certain subject. If you have contacts to Khronos and they are thinking about adoption, we can totally talk things through, connect interested people and find a roadmap. But there has to more then just an idea to make it on the Roadmap.


Add cloud init datasources script

Added a script that will run before cloud-init to determine which datasources should be used based on connectivity to the predetermined addresses used for Ec2, CloudStack, and OpenStack metadata.
This will prevent us from timing out while looking for a connection to those datasources and delaying access to the appliance through ssh.
Also moved our cloud.cfg changes to the cloud.cfg.d directory to prevent our edits from being clobbered when the cloud-init package is updated on the appliance.
Requires https://github.com/ManageIQ/manageiq-appliance-build/pull/56

I tested this on RHEV 3.4 by changing the root password using the RHEV UI.
In order for RHEV to expose the drive with the data to the guest machine the OS for the machine needs to be set to a RHEL version.
The template for our appliance was initially set to "Other OS" and RHEV wouldn't expose the disk until it was set to "Red Hat Enterprise Linux 7.x x64"

@carbonin Should you remove the logging modifications? Or are those still needed?

@Fryguy No, I didn't get around to testing that.  I can do that today though if we want it for this PR.

It can be in a followup


Failure to run after install

setup.py requirements are too greedy and pull in version that are incompatible with current code:
AttributeError: module 'flask.json' has no attribute 'JSONEncoder'

ImportError: cannot import name 'url_quote' from 'werkzeug.urls'

ImportError: cannot import name 'escape' from 'jinja2'

ImportError: cannot import name 'json' from 'itsdangerous'

AttributeError: module 'sqlalchemy' has no attribute '__all__'. Did you mean: '__file__'?

SQLalchemy error is likely another manifestation of #6 (i.e. incompatible with SQLalchemy version 2.x).

Opened PR https://github.com/cs91chris/flask_autocrud/pull/9


Feat/ Venue: SAC releaxed conflict computation

NeurIPS asked to use only current SAC submissions when transfering conflicts to ACs
Run as follows:

venue_matching = openreview.venue.matching.Matching(venue, openreview_client.get_group(venue.get_area_chairs_id()))
venue_matching.sac_profile_info = openreview.tools.get_sac_profile_info
venue_matching.setup(compute_affinity_scores=True, compute_conflicts='NeurIPS')

NeurIPS decided to use current submissions and also any relations and history with no end date (I think we should also include anything with an end date in the future). Now this would be run as follows:
venue_matching = openreview.venue.matching.Matching(venue, openreview_client.get_group(venue.get_area_chairs_id()))
venue_matching.sac_profile_info = openreview.tools.get_current_submissions_profile_info
venue_matching.sac_n_years = 0   ## if we use n_years = 1, the cutoff year would be 2022, not 2023
venue_matching.setup(compute_affinity_scores=Yes, compute_conflicts='NeurIPS')


on-click="resetPartial(...)" not working

both latest/edge:
http://jsfiddle.net/xc2o8y08/42/
calling resetPartial in the code instead of the button works. Likewise, removing databound items from the partials also make it work in the button.
I guess I see a lot of things because I used ractive rather heavily in a production application.

Did a bit of research, it's the mustache {{ in the on-click method expression that's failing at _parse_time.

I think I can solve this and issues with nested quotes in directives if/once #2386 lands. Instead of grabbing everything in the attribute and parsing it again based on the attribute type and what the content looks like, it can do proper parsing of the attribute/directive values. It could technically be done now, but I don't think it would be pretty because of the legacy syntax for proxy events, decorators, and transitions.

This is now fixed in edge and available in 0.9.0-build-1.


fix markdown typography

Markdown-rendered proposals often suffer from a "ransom note effect," making them hard to read. To improve readability and professionalism, could we work in CSS / typography of markdown or use something like github-markdown-css?

Hi,
Thanks for the suggestion. We'll look into enhancing the CSS/typography for our markdown-rendered proposals to improve readability and avoid the "ransom note effect." Using something like github-markdown-css could be a good solution.
Appreciate your input!
Best,
Polkassembly Team

typography seems to be way better now


Connection keeps dropping

Hello, do you know why connection keeps dropping?
I'm running latest ibeam docker and using live account with 2FA /IBKey app/.
I had to complete authentication over and over again.
Attached a screenshot.

For me it keeps dropping every few days. And I have to log into the website and log out and restart the gateway docker image. It's so super annoying. I just still can't believe that IB let's this happen and there seems to be no solution.

Feel you pain , I have to do the same thing daily

Hey @muu1994 thanks for submitting your issue 👍
Unfortunately, this seems to be a reoccurring issue with IBKR - their authentication is not predictable and not stable. IBeam does its best to maintain the Gateway authenticated, so whenever it notices a lack of authentication it will attempt to reauthenticate.
Some users reported that logging into TWS or IBKR website caused the authentication on the Gateway to drop.
I'd suggest for you to report that to IBKR support, as to let them know how much of a burning issue this is for their algo trading community.


test(stablecoin): Mint/Burn simulation tests

[ ] Add mint and burn simulation for accounts
[ ] Remove the use of fund accounts in create new pool msg simulation (use mint/burn logic for new pool assets)

Outdated / no longer relevant


#issue3 database star created

Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
Write a summary of your change. Explain why you have made it.
Related to
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes #1
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

Mark suggests we add a foreign key to link it to the users table

I  have modified it but its creating issues with the post method. You might need to look and work around the post method i did. Thank you


Update runtime-options.js

Allow the upper limit of clones to be freely modified and increase the translation of monitoring blocks.

It already was though? If you put a join block in it you could access that.

不过已经是这样了？如果你在其中放置一个连接块，你可以访问它。

how to use?but i think it would be more convenient for me to do this

you can do this already

the translate() fix is definitely something to merge though

the text-inputs-that-are-also-dropdowns inputs would be a better way to add the clone limit input

you can do this already

the translate() fix is definitely something to merge though

thanks


ANC Subs Visit - Add Activity - Treatment Review [2h]

Issue
Building upon the existing subsequent encounter activities for ANC @ Health Centers, we will be adding a Treatment Review Activity to REPLACE the current medication activity
The Treatment Review activity should appear 6thin the tray, after Family Planning.
Individual Icon:

Tray View:

The activity will have sub-activities based on a patient's previous diagnosis. Potential subactivities could be:

Prenatal Medication ( #248)
HIV Medication (#249)
Hypertension (#250)
Malaria (#251)
Anemia (#252)
Syphilis (#253)
** There could be more added at a later date**

Design Files:
You can access the icon SVG here.
To Do:

Build out architecture for the Treatment Review Activity.

Updated main issue with related issues and more information about sub-activities.

https://nutrition-ihangane.pantheonsite.io/
QA Review
Checked and approved:

Treatment review displays as 6th icon, after Family planning.


Dashboard usability study

Describe the blog post your would like to write
Keylime Interactive conducted a usability study with dashboard users in Q1/2 of 2023. We would like to share insights of findings in a blog and also initiate GitHub issues to motivate ongoing dashboards improvements. This blog helps share findings.
What is the title of the blog post?
OpenSearch Dashboards: A Snapshot of the Current Usability and Inclusivity Index
Who are the authors?
Aparna Sundar snd Ashwin PC
What is the proposed posting date?
August 11th

Is there an updated target send date for this one, @apasun?

@vagimeli -can you update the publication date to "9/6/2023" https://opensearch.org/blog/dashboards-usability-snapshot/


Include small pt-br translation

Include small pt-br translation to complement https://github.com/gogits/gogs/issues/1620 and https://github.com/gogits/gogs/commit/362d64df0483700ac435c4b05709265378887a4e

Hmm.... thanks your PR!
But as documented, you should:

PR to develop(https://github.com/gogits/gogs/blob/master/CONTRIBUTING.md#pull-request)
and do it on https://crowdin.com/project/gogs/pt-BR (https://github.com/gogits/gogs#overview)

Hi @Unknwon
Sorry for my noob, I translated using Crowdin, after I will help to translate another strings

@joubertredrat no worries!


Add data to images exif

What is your suggestion for the program?
I would like data information to be stored in the images exif data. This is much better than putting information in the filename.
What version of the product are you using? On what operating system?
v3.3.0 windows server 2008

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 Jun 2013 at 9:02

See issue #258


Dancer2 code

Time to actually start building backend as per the agreed REST API routes.

This is cool... I'm going through the documentation . Dancer2 is really cool and fun.

Hello @manwar 👋
I have already set up the basic Dancer2 project (basic setup of all identified routes in #125). I would like to have more information on this issue.
Should we commit the Dancer2 code to this repository, for review ?

Hi @manwar.
Should I push the Dancer2 code to this repo or in the new repo ?

I would like to get assigned this issue please @manwar


chore: bdd-nh-1591275846 to 0.0.1

chore: Promote bdd-nh-1591275846 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Self Signed Certs

I am trying to use a self signed cert and my script is unable to verify:
SSL: CERTIFICATE_VERIFY_FAILED
Any suggestions will be appreciated !

I found the arg for cafile but I am getting: no certificate or crl found. I tried base64 and DER .cer files. Will try pem next

I am also running into this issue. Would welcome a solution.


EACCES Error on every command

How did you install the Amplify CLI?
sudo npm install -g @aws-amplify/cli --unsafe-perm=true
If applicable, what version of Node.js are you using?
20.1.0
Amplify CLI Version
12.0.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Not that I know of
Describe the bug
Any command that starts with Amplify results in an error.
For example: amplify configure results in:
EACCES: permission denied
I also could not install amplify without sudo, as I would get this error:
Error: Amplify CLI failed to install. Check your internet connection and try again
Expected behavior
I would like to run amplify configure and set up my environment
Reproduction steps
amplify configure
Project Identifier
No response
Log output

# Put your logs below this line
zsh: no such file or directory: issue-date

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @aoh-escape, 👋 thank you for reaching out. This appears to be similar to https://github.com/aws-amplify/amplify-cli/issues/11615.
If you are experiencing EACCESS issues installing global packages, please refer to the npm documentation.
Alternatively you can assume ownership over the folders created in your home directory but owned by root (chown -R ~/.amplify)


130341271 coveralls test coverage integration

Description
Test coverage report is transferred from TravisCI to coveralls.IO, also added a badge to the READ.me file display the coverage status of the app.
Status
Completed
Pivotal tracker story
Integrate Coveralls code coverage service - #130341271

Changes Unknown when pulling 4dd695e5ba890700ce1f102e413b91f57b333af2 on chore/coverall-integration-130341271 into ** on develop**.


Chunk info for infinite maps?

Looking at the code, I'm not seeing chunk information for infinite maps (x, y, width, height) being stored within the layer structure. Is there any reason for this?
It's not a big deal as it can always be calculated but would've been nice to read it directly from the loaded structure

No reason other than this is more or less an unsupported project.  I haven't really touched anything related to Tiled or even C# in over a decade.  (I've nudged people towards other projects, but unfortunately they never seem to stay around very long.)
If you do want to add support for this, then I'd be happy to include it.


No istall package

Please publish an install package, and/or docs on how to install the pieces.

You'll find installation instructions, documentation, and installation packages on the official project website.
https://hotcakes.org

Installation instructions can be found here:
https://hotcakescommerce.zendesk.com/hc/en-us/articles/115002941503-Installing-Hotcakes-Commerce


⚠ Samsung has degraded performance

In 8074e7d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2653 ms

Resolved: Samsung performance has improved in 4b6afd1.


feat: Add support for permissions boundary on enhanced monitoring role

Description
The variable I've created previously in https://github.com/terraform-aws-modules/terraform-aws-rds/pull/482 was not exposed in the main module, just in the sub db_instance module. This PR fixes that.
Motivation and Context
Able to define permissions_boundary for enhanced monitoring role.
Breaking Changes
No
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

This PR is included in version 5.6.0 :tada:


Surface selection on subtractive brushes no longer pickes the backfaces, but instead the invisible front faces.

Surface selection on subtractive brushes no longer pickes the backfaces, but instead the invisible front faces.
Steps to reproduce:

Create an additive cube.
Create a subtractive cube overlapping part of the additive cube.
Change to "Surfaces" mode and try to click one of the inner faces of the cube.

Video example:
https://thumbs.gfycat.com/AgonizingPersonalAnchovy-mobile.mp4

Thanks, fixed in 1.562!
I'll close this ticket when it's available from the asset store

Considering that it doesn't appear like the asset store version is going to be updated anymore, I'm going to go ahead and close this.


Подключение к сети

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9e748ed-63fe-0d00-6b60-c1a778797afa
Version Independent ID: 3cd66c90-ed09-7c28-7dbb-0a11769f8033
Content: Network connectivity in the Microsoft 365 Admin Center (preview) - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/office-365-network-mac-perf-overview.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@matuhinal Please add the description in English. Thanks

@matuhinal We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if you see an improvement is required in the specific area of this documentation. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@matuhinal We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if you see an improvement is required in the specific area of this documentation. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


bug: Reading balance_of ERC20 Cairo 1 contract

Bug Report
Madara version:
41e8ca4dc3b5622191fc95fad48870e1927c3275
Current behavior:
Calling balance_of in deployed erc20 contract in test-cairo-1.ts throws an error:
 LibraryError: 40: Contract error
      at RpcProvider.errorHandler (node_modules/starknet/src/provider/rpc.ts:96:13)
      at RpcProvider.fetchEndpoint (node_modules/starknet/src/provider/rpc.ts:107:12)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async RpcProvider.callContract (node_modules/starknet/src/provider/rpc.ts:416:20)
      at async Context.<anonymous> (tests/test-starknet-rpc/test-cairo-1.ts:163:27)

Expected behavior:
Should be able to call view functions from deployed contract.
Steps to reproduce:
I'm adding this line in test "should declare and deploy erc20 contract then transfer some tokens", after deploying the contract and calling transfer
const balanceOf = await providerRPC.callContract({contractAddress: deployRes.contract_address[0], entrypoint: "balance_of", calldata: [CAIRO_1_ACCOUNT_CONTRACT]});

Can we test this again to see if it is still broken

Can i work on this ?

This should be solved already @KaushikKC. @lana-shanghai can you confirm?

@KaushikKC you can try to reproduce if you want, and tell us if it has been fixed

I think it has been solved. Reopen if I'm wrong


The audio output from VQ-GAN Decode has noise

Self Checks

[X] I have thoroughly reviewed the project documentation (installation, training, inference) but couldn't find any relevant information that meets my needs. English 中文 日本語 Portuguese (Brazil)
[X] I have searched for existing issues search for existing issues, including closed ones.
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell us your story.
I  use the CLI  -  python tools/vqgan/inference.py -i "./person/test/wav/test.wav" --checkpoint-path "checkpoints/fish-speech-1.5/firefly-gan-vq-fsq-8x1024-21hz-generator.pth"
it's create two file , fake.npy and fake.wav , In theory, fake.wav  and  test.wav  should not differ much,  but in reality, they are far apart，fake.wav has strong noise ，I don't know if I need to retrain the VQ-GAN
2. What is your suggested solution?
i don't know how to fix it
3. Additional context or comments
No response
4. Can you help us with this feature?

[ ] I am interested in contributing to this feature.

I have read the description in the issue，vector-quantize-pytorch == 1.14.24 ，The problem has been solved When I used this version, tks


Fix secret to release from org level cred.

Description
Fix secret to release from org level cred.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: endgame
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Thanks for the approval here but we cannot release CLI RC until we have another fix to be done tomorrow morning.


Enable the snapshot functionality of the Amazon EBS CSI driver

Is your request related to a problem? Please describe.
To enable the external-snapshot feature, officially supported by EBS CSI driver is necessary that the following resources are deployed before the EBS CSI driver addon:

CustomResourceDefinition (CRD) for volumesnapshotclasses, volumesnapshots, and volume snapshot contents;
RBAC (ClusterRole, ClusterRoleBinding, and so on);
controller deployment;

Describe the solution you'd like.
It would be great to enable a feature flag to install the above dependencies before the EBS CSI driver deployment.
Describe alternatives you've considered.
Alternatively, it may be enough to run some custom Kubernetes manifests before the addons deployment.

this module is not intended to go inside the cluster (i.e. - use the Kubernetes provider), and instead this functionality should be provided by the EKS addon.
instead, you can raise an issue on https://github.com/aws-ia/terraform-aws-eks-blueprints-addons to see if it can be supported there


Add support for wasm_bindgen

Implement Into<JsValue> to anyhow::Error on an optional feature, allow it to be use in functions exported to js.
Fix #115

so how did you solve this problem without anyhow eventually? Convert to string manually?


Create better element ID generator

Bug Report
Replace the use of _.uniqueId with a better implementation, as these are re-generated at every render, and is confusing.
Steps
Replace the lodash function in dialogBehavior.ts and Accordion.tsx with a better implementation, that will generate a unique ID but only once.

If you need to do something one time in class components: do this in constructor(): _.uniqueId() works as expected for me.
For function components, we can use existing hook: https://github.com/reach/reach-ui/blob/master/packages/auto-id/src/index.js


Issuing credits to Kaliya

Issue 5000 credits to @Identitywoman.

 Follow up
On Monday, 18-Mar-24 03:22:36 UTC by Gov4Git dev
Issued 5000 credits to member @identitywoman.


Can I just set the windows.navigator.webdriver to undefined?

I use evaluateOnNewDocument funcition to set windows.navigator.webdriver to undefined.
But in some situations, the document has an A tag with target="_blank" attr which means when the
page in code
      browser.on('targetcreated',async (target)=>{
            let page = await target.page();
            page.evaluateOnNewDocument($fn) // set the windows.navigator.webdriver to undefined
      })

cant run the $fn in  evaluateOnNewDocument function .
What I just want is to set the all the tabs variable windows.navigator.webdriver to undefined.
Is there anyway to make this ? like recompile the puppeteer or the whole chromium?

Yes I can


Port ftphdfs as s-c-t module

As a developer, I'd like to move ftphdfs module from XD to s-c-t-m repo, so I can use it as task to build batch pipelines.
Acceptance:

ftphdfs as task module (Spring Boot App) is available in spring-cloud-task-modules repo
maven coordinates include ftphdfs with respective group/artifact/version

This issue was moved to spring-cloud/spring-cloud-task-app-starters#11


Bad URL for Synology config file

https://github.com/Notifiarr/notifiarr/blob/4ae29fa5f7988f9a57e62fcc1f68b7cc34c5860e/userscripts/install-synology.sh#L153

See if this sorts that out:
https://notifiarr.wiki/en/Client/Installation#synology

Having the same issue it seems.  I had to copy the file from "https://github.com/Notifiarr/notifiarr/blob/main/examples/notifiarr.conf.example" and update the permissions to get it to work.  Even then, I am not sure I got all the settings correct as I believe the other file was customized for Synology, while the generic one is not.

Regardless you're going to want to customize the configuration for yourself.
This is the file: https://github.com/Notifiarr/Notifiarr.github.io/blob/gh-pages/configs/notifiarr-synology.conf
The only thing custom are the log file locations.
log_file = "/var/log/notifiarr/app.log"
http_log = "/var/log/notifiarr/http.log"

It's also an old file and incomplete, so we really shouldn't rely on it. This issue will remain open until we fix the script.


[4.1] Remove Laravel 5.8 Support

This should make it easier for us to maintain, and maybe it'll allow Scrutinizer to actually install ocramius/package-versions 1.7.0 🤞
Also, if we drop support for Laravel 5.8, we also drop support for PHP 7.1 which has reached EOL in January 2019, more than 1 year ago, so it's about time we stopped supporting it.
See:

Laravel Version Support
PHP Version Support

A new inspection was created.

A new inspection was created.

A new inspection was created.

A new inspection was created.

Done. In the process I've also:

fixed 2 places where we were still using array helpers despite having removed laravel/helpers
fixed Scrutinizer CI requiring wrong version of ocramius/package-versions
fixed Travis CI not sending code coverage status to Scrutinizer CI (hopefully 🤞 )

The result is that we FINALLY have ScrutinizerCI working for the 4.1 branch, once this is merged, so that we can see the difference in code quality between master and 4.1.

PS. Scrutinizer's code rating increased from 9.1 to 9.5 , between master and 4.1 🎉 🎈 🎊


Add vm structure

details:
Add vm structure

I think we should talk about the structure tomorrow at the meeting.


Partial CHaP release

The problem that you wish to solve
Could we get a release of the cardano-wallet cli on CHaP?
Description
As above,
Implementation suggestions
No response

May I inquire about the purpose? The main reason for releasing the cardano-wallet executable in CHaP would be to be able to depend upon it from other .cabal packages — do you have a particular cabal package in mind where you want to do this?

To include in horizon so it can be installed on a system without use of IFD using the same build plan and dependency footprint as all the other cli tools. https://gitlab.horizon-haskell.net/package-sets/horizon-cardano/-/blob/master/horizon.dhall

Some tools, let's say Atlas PAB use cardano-wallet as a Haskell library, and they are forced to copy its gory cabal.project file which sucks. Their dependants have to do the same. Does is sound like a good argument to you @HeinrichApfelmus?

Do we need release to CHaP, which will be somewhat complicated because CHaP is controlled by another organisation, or would a release to https://hackage.haskell.org be good?

@euonymos Also, I would be interested in understanding which part of the cardano-wallet API you are using. A quick search in the PAB repository only showed cardano-wallet-primitives but I may have overlooked other uses.

@abailly It would be unsatisfying to release to hackage in my opinion because the dependencies would not resolve without CHaP. Maybe cardano-foundation deserves its own release index?

@abailly Thank you for your interest in this issue. I would like to chime in regarding some of your remarks.

@euonymos Also, I would be interested in understanding which part of the cardano-wallet API you are using. A quick search in the PAB repository only showed cardano-wallet-primitives but I may have overlooked other uses.

@euonymos remark was wrt Atlas, an Haskell based transaction building tool. Inside Atlas, we use cardano-coin-selection package from cardano-wallet. Due to this dependency we have to import cabal.project details of cardano-wallet inside Atlas, here. Likewise, any project using Atlas in their stack have to do the same which is a huge bloat atm.

Do we need release to CHaP, which will be somewhat complicated because CHaP is controlled by another organisation, or would a release to https://hackage.haskell.org/ be good?

Isn't cardano-wallet itself dependent upon chap? I mean, how could then this package be uploaded onto Hackage as it would not build in the standard Hackage environment since Hackage has no access to chap? I could be missing something here.

@locallycompact @sourabhxyz I agree depending on CHaP from Hackage is a major problem, I will raise an issue in the relevant repository to understand how we can streamline the release process there from here.

So there's a script for adding packages to CHaP that we could use: https://github.com/IntersectMBO/cardano-haskell-packages?tab=readme-ov-file#-from-github

I did a quick analysis of c-w dependency graph using cabal-plan and here is the local dependency graph:

Restricting to the cardano-coin-selection package, this yields:

@sourabhxyz Would that help if we published only the latter set? This seems a low-hanging fruit we can solve relatively easily.
@locallycompact Did you have request from people using horizon to be able to pull c-w executable from CHaP?

It was originally a request from myself to myself but I suspect having atlas in horizon would also find use.

@abailly

@sourabhxyz Would that help if we published only the latter set? This seems a low-hanging fruit we can solve relatively easily.

Yes indeed, that's a great idea!

Yes indeed, that's a great idea!

Would the latest version (2024.11.18) be good or do you need an earlier version in order to take advantage of this?

Would the latest version (2024.11.18) be good or do you need an earlier version in order to take advantage of this?

I'll need some time to evaluate it, but likely we can manage with latest version.

Thank you a lot @abailly, I will try to find time to wire in chap's libs.


Export Image data of QR-Code

Hi, I'd like to download a QR code to the device of the user. For this, I need the image data. Now my question:
How to get a PNG image out of an QrImageView()?

+1
I also need to download the generated image

you can find an example of how to get the image bytes in test/painter_test.dart

An export to svg would be cool as well


making the encrypt.so on linux

Hey, i cannot make an encrypt.so on my linux machine...
When i cd into 'lib' folder and call make, i get :
No rule to make target 'encrypt.o', needed by 'libencrypt.so'.  Stop.
Am I doing something wrong?

encrypt.c is required to build libencrypt.so. Please read the README for more details.


epic: sticky proccess of nitro

Problem
Nitro cannot exit when quitting jan with latest release

temporarily cannot be reproduce


D_80126CD4->gRaceStartShowHudStep and name get_object_render_stack_pos

gRaceStartShowHudStep counts up from 0->5 on race start, used to coordinate when certain hud actions & audio clips play:
0->1 when camera shutter opens from center of screen
1->2 when hud slides into screen with "whoosh" sound
2->3 on the "Get Ready!" voice play
3->4 on the "Go" voice and text
4->5 on the "Go" sliding off screen

All LGTM. Maybe add your documentation for gRaceStartShowHudStep in the comments above it's declaration? Would be easier to find in the future.


autodiscover_tasks can not work when django app layers more than 2

for example, a django project like this:
/proj
/proj/apps/app1/app11
/proj/apps/app1/app12
/proj/apps/app1/app11/tasks.py
/proj/proj/setting.py
/proj/proj/celery.py
/proj/proj/init.py
autodiscover_tasks can not find the /proj/apps/app1/app11/tasks.py ， how to resolve this problem? thanks!

Have app1.tasks import app11.tasks!

i use CELERY_IMPORTS, and it works , i want to find a way not to use it ,  tks


useRepo tests

In useRepo.test.tsx, there's a floating assertion that confirms that a repo can be instantiated with no network:
https://github.com/automerge/automerge-repo/blob/d73e71588c3835a172fdf4d19e56a1f946c041ed/packages/automerge-repo-react-hooks/src/useRepo.test.tsx#L8-L14
This PR moves that into a proper test in Repo.test.ts:
https://github.com/automerge/automerge-repo/blob/4e426f7b564cbca4e8fbb43b36910edad0f73f65/packages/automerge-repo/test/Repo.test.ts#L34-L41

Current dependencies on/for this PR:

main

PR #243

PR #244

PR #242   👈

PR #248

This stack of pull requests is managed by Graphite.

Merged already, thanks! (I guess I didn't push the rebase.)


Mttl 2046 - Implement Automated Eligibility checks

Link to JIRA ticket
https://hackney.atlassian.net/browse/MTTL-2046
Describe this PR
What changes have we introduced

Make calls to Tenure and Person tables & Income API to carry out checks according to business logic

Checklist

[x] Added tests to cover all new production code
[x] Checked all code for possible refactoring
[x] Code pipeline builds correctly

Follow up actions after merging PR
This will be implemented into the API & tested E2E in another PR (https://hackney.atlassian.net/browse/MTTL-2047)

There should also be some TDD for the updated E2E tests (we should no longer be ignoring them)
@humulla I made this PR to implement the checks & tests for them, haven't actually called them anywhere as that's a separate ticket, so E2E tests will be then :)


Update NCBI FCS Adaptor

Description of feature

This will have to wait till the next release, see https://github.com/ncbi/fcs/issues/90

Related to #114


update test case for s390x

Update test case test/IRGen/c_functions.swift for s390x for v4.0
Please also  merge to v 4.0 branch.
Thanks

@swift-ci Please smoke test

@samding01 Can you create the PR for the swift-4.0-branch?

@slavapestov A PR for swift-4.0-branch is created, see https://github.com/apple/swift/pull/12269


Split IOCTL links onto separate lines.

Links to the IOCTL documentation were all showing on one line and looked like a single large macro instead of three individual macros.

Hi @cburg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks @cburg looks much better now!  https://msdn.microsoft.com/en-us/windows/hardware/drivers/storage/supporting-mount-manager-requests-in-a-storage-class-driver


Creation of tc.Image should be simpler

Right now, there are a few "hidden" parameters in the creation of tc.image. We should change that and expose them like this
tc.Image(buffer=image.pixel_data[..., :3].tobytes(),
                width=image.width, height=image.height, channels=3, format = "raw")

We can borrow elements of the API design from PIL. Alternatively, we can also have simple constructors from PIL

A common use-case is to convert a numpy array to a Turi Create image, so perhaps we should make this particularly simple (similar to PIL's Image.fromarray for instance).

How would someone create a tc.Image from a numpy array currently?

@tiborr - He is one way to do it. There is likely a better way (i.e a way which doesn't write to disk).
from PIL import Image
import numpy as np
import turicreate as tc

# This array could be whatever you want, doesn't have to be all zeros
my_numpy_array = np.zeros((224, 224, 3))
image = Image.fromarray(my_numpy_array.astype(np.int8), 'RGB')
image.save('/tmp/zeros.jpg')
tc_image = tc.Image('/tmp/zeros.jpg')

Unrelated to the numpy array to image path, we should also consider allowing astype on SArray to convert from str (containing URLs to images) to Image type. Lots of data starts with lists of URLs and there's currently no efficient way to convert all of them to tc.Image.

So i have to first save numpy arrays as jpgs if i want to load these numpy array images in turicreate?

Hi @Muggle-Du ,
Here is a "hidden" API to go from a NumPy array to a Turi Create Image:
RAW_FORMAT = 2
tc.Image(_image_data=numpy_array.tobytes(), _width=numpy_array.shape[1], _height=numpy_array.shape[0], _channels=numpy_array.shape[2], _format_enum=RAW_FORMAT, _image_data_size=numpy_array.size)

Note that since this is not documented in the API docs, things could change with this API and code that uses it may at some point stop working with a point release.
We are working to scope out when and how to make this API public in the meanwhile.
Hope this helps!


bug: Ionic Push Google API Key error

Type: bug
Platform: android 5.0 webview
I trying push my Google API key and error appear
$ ionic push --google-api-key XXXXXXXXXXXX
An error occurred [TypeError: undefined is not a function]

My ionic info
$ ionic info

Your system information:

Cordova CLI: 5.3.3
Ionic Version: 1.1.0
Ionic CLI Version: 1.7.6
Ionic App Lib Version: 0.6.2
ios-deploy version: 1.8.2
ios-sim version: 5.0.2
OS: Mac OS X El Capitan
Node Version: v0.12.7
Xcode version: Xcode 7.0.1 Build version 7A1001

My npm and node
$ npm -g list --depth=0
/Users/pedrobrasileiro/.nvm/versions/node/v0.12.7/lib
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>```

Greetings @pedrobrasileiro!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Closing as this is an Ionic Platform issue. Mind posting here so the platform team can help? https://github.com/driftyco/ionic-platform-web-client cc @ericb


Indexing with all false lead to ValueError

Add the following test in test_constaints.py, it will produce ValueError: zero-size array to reduction operation.
def test_constraint_slice(self):
#self.A = Variable(2, 2, name='A')
condition = np.matrix('1 1; 1 1')
constraint = [self.A[condition == 0] == 0]

The error message is not the best here, but this seems like it should produce an error. You think this should work?

The condition might be dynamic (calculated), so it cannot be pre known whether it’s all false or not. I think no matter whether it’s all false or not, it should always work the same way.

On 25 Mar 2017, at 5:43 AM, Steven Diamond<EMAIL_ADDRESS>wrote:
The error message is not the best here, but this seems like it should produce an error. You think this should work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/cvxgrp/cvxpy/issues/344#issuecomment-289150415, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGXgkp0Ruvz3qdEs9ZTBIeqiCMYTs0cks5rpDkXgaJpZM4Mnxo2.

@goriri , can you try to articulate the general behavior of indexing by all-False? Perhaps: cvxpy Expressions of size zero are automatically cast to the scalar 0?


No way of persist new collections

Hi there,
I'm getting in troubles persisting collections. The first time I initialize de db it works correctly, but if I try to add new collections on subsequents initializations, it never get saved to files.
Any idea on this? The collections are marked with autoupdate.
Thanks in advance

Hi, could you describe your setup a bit ore detailed? Maybe show some code snippets? I just checked the latest version against one of my applications using persistence. It worked. Which persistence system are you using? Disk persisting? It would really help to have more details and code ;)

Sure, first time:
`let loki = {}
let adapter = new lfsa()
loki.db = new lokijs('socks.db', {
adapter : adapter,
autoload: true,
autoloadCallback : loki.databaseInitialize,
autosave: true,
persistenceMethod: 'adapter',
autosaveInterval: 4000
})
loki.databaseInitialize = function() {
let users = loki.db.getCollection('users')

if (users === null) {
  loki.db.addCollection('users', { indices: ['user'], unique: ['user'], autoupdate: true })
}

}`
Then I add a new collection, it won't be saved ever.
`let loki = {}
let adapter = new lfsa()
loki.db = new lokijs('socks.db', {
adapter : adapter,
autoload: true,
autoloadCallback : loki.databaseInitialize,
autosave: true,
persistenceMethod: 'adapter',
autosaveInterval: 4000
})
loki.databaseInitialize = function() {
let users = loki.db.getCollection('users')
let roles = loki.db.getCollection('roles')

if (users === null) {
  loki.db.addCollection('users', { indices: ['user'], unique: ['user'], autoupdate: true })
}

if (roles === null) {
  loki.db.addCollection('roles', { indices: ['name'], unique: ['name'], autoupdate: true })
  roles = loki.db.getCollection('roles')
  roles.insert({ name: 'admin', description: 'Highest permission on the system', removable: false })
}

}`

I don't really find it in the documentation but I believe if you are using persistenceMethod: 'adapter' and adapter: adapter then you are responsible to provide the logic of saving your file in that given adapter. https://github.com/techfort/LokiJS/wiki/LokiJS-persistence-and-adapters. What happens if you use it without those two lines?

Sorry, didn't provided that part of code, but was this:
const lfsa = require('lokijs/src/loki-fs-structured-adapter.js') let adapter = new lfsa()


Portfolio Plans: Hard to Find Epic to Add to Plan

We find it difficult to find the Epic to add to the Portfolio Plan because the list is too long.  It includes Epics in all states from every team within a project.  We have close to 1500 Epics in our project and the list does not seem to be sorted in any way! We would like to see a textbox allowing us to search by ID.  This will save us a lot of time.

@judychou thanks for the feedback! This is something we're looking at implementing in the future.

Any estimates on when?
Judy Chou
Senior Quality Assurance Engineer, Enterprise Technology
Direct<PHONE_NUMBER>
Other<PHONE_NUMBER>
Email<EMAIL_ADDRESS><EMAIL_ADDRESS>Global Headquarters, Seattle
1015 Third Avenue, 2nd Floor
Seattle, WA 98104
From: Steven Hutchings<EMAIL_ADDRESS>Sent: Wednesday, August 14, 2019 8:51 AM
To: microsoft/featuretimeline<EMAIL_ADDRESS>Cc: Judy Chou<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/featuretimeline] Portfolio Plans: Hard to Find Epic to Add to Plan (#182)
@judychouhttps://github.com/judychou thanks for the feedback! This is something we're looking at implementing in the future.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/featuretimeline/issues/182?email_source=notifications&email_token=ADMHAM4JKIWPJFXM76PA5OLQEQSUXA5CNFSM4ILWF6GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4JHUWI#issuecomment-521304665, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADMHAM3XG3RAHDS2QK3G5G3QEQSUXANCNFSM4ILWF6GA.

It's being worked on now and will be part of the next release. Probably in the next couple weeks.

Hi @judychou
Thanks for reporting the issue.
We've added a filter that works on the work item title / id.
There is now also a context menu option in the work item to add work items directly from your Backlogs / Boards.


Update ASTC version

Description

Update the astcenc library version to the most recent release.

Detect SIMD support and build the corresponding atscenc variant
Fixes a number of potential memory leaks caused by the non-thread-safe code in the previous version of astcenc

Update the mipmap generation code to allocate the required memory for all mips at once instead of mip by mip (less fragmentation, and should be faster)

Performance
Ran the command_buffer_usage sample 5 times against this branch and against the current main branch, recording the Time spent loading images log line for each run.  The target machine is a Ryzen Threadripper 1950X with 32 logical processor and for which the AVX2 ISA was detected and used.

branch
average load time
standard deviation

main
5.6638216
0.07

astc
3.3971104
0.06

This represents a 40% increase in ASTC image decompression performance.
Note that the only caveat for this is that the modules being used to detect the SIMD instruction set were only found under the license embedded in the added CMake files, which is a slight variant of the BSD-3 license.  Hopefully this shouldn't be a problem.
General Checklist:
Please ensure the following points are checked:

[X] My code follows the coding style
[X] I have reviewed file licenses
[X] I have commented any added functions (in line with Doxygen)
[X] I have commented any code that could be hard to understand
[X] My changes do not add any new compiler warnings

Strictly speaking there may be new or different compiler warnings inside the ASTC build, but that seems out of scope.

[ ] My changes do not add any new validation layer errors or warnings
[X] I have used existing framework/helper functions where possible
[ ] My changes do not add any regressions
[ ] I have tested every sample to ensure everything runs correctly
[X] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

[X] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[X] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Is this PR also suffering from the CRLF issue? Whole files appear different.

Note that the only caveat for this is that the modules being used to detect the SIMD instruction set were only found under the license embedded in the added CMake files, which is a slight variant of the BSD-3 license. Hopefully this shouldn't be a problem.

We probably need to check this internally. @marty-johnson59: Maybe something to put on next calls agenda? Or forward to Legal at Khronos. It's a different license, so we need to make sure that we can use it and that we don't block any current user from using our samples by that new license.

Tough tbh. I'd rather prefer moving all the assets that use astc to basisu instead. This is a nice stopgap, but probably becomes obsolete once we update the assets.

@marty-johnson59 is a licence check needed on this?

ATSC is under Apache 2 license, so we're OK with that.  Merging with 3..

Looks like this broke builds on recent Apple devices (e.g. M1), see https://github.com/KhronosGroup/Vulkan-Samples/issues/965

@kanavin is it critical that this be automatic, or would it be sufficient if you could force the ISA from the command line, like for instance cmake -Bbuild -DASTCENC_ISA_NONE=ON?
If the latter is sufficient, then I have a PR up that should allow you to build: #978

@kanavin is it critical that this be automatic, or would it be sufficient if you could force the ISA from the command line, like for instance cmake -Bbuild -DASTC_ARCH=NONE?
If the latter is sufficient, then I have a PR up that should allow you to build: #978

Something like this should work, yes. I've tested a local patch that does something similar, and was going to open a pull request:
https://github.com/kanavin/Vulkan-Samples/commit/41090ff333b2b4d888a15e3fba000229fc8740c3
While you're at it, SSE41 should become sse4.1 (with a dot), when lowercased, as that's how astc defines the target.

Ugh, you're right... 🤦

However, I'm not super-concerned with fixing this in the same PR since support for SSE 4.1 but NOT AVX2 is a relatively narrow window of processors.


Error in executing a query about 'Traverse' statement by JDBC

Version of orientdb-jdbc : 2.0.4 & 2.1.16
when I execute the code below:
ResultSet rs = statement.executeQuery("traverse OUT('someR') from (select from tableA where xxid = 'xxxxx') WHILE $depth <= 1");
Two documents are expected to be returned to me. However, the returned result set contains 2 rows, one of which is an object of ODocument, and the other is an object of ORecordId which just contains '@rid'. What's more, it will cause a ClassCastException when using rs.next() to move the cursor forward the second row because com.orientechnologies.orient.core.id.ORecordId cannot be cast to com.orientechnologies.orient.core.record.impl.ODocument.

The query is not correct: you should use EXPAND:
ResultSet rs = statement.executeQuery("traverse expand( OUT('someR') ) from (select from tableA where xxid = 'xxxxx') WHILE $depth <= 1");


CB-9051 [AuthZ] Improve error pop up message for non entitled users

The error message for authz was confusing for users.
This pull request introduce a new format for this error message and unify the messages at different locations.
CB version: 2.31.0-b83
Env: mow-dev
New authz role enabled.
Steps:
Perform any non entitled user operation.
Current Behavior:
Now the error message in below format
Error:
You have no right to perform any of these actions:  on crn
Instead of above error pattern with crns and role information, it needs to call out the correct error such as "user1 not entitled to do a delete operation, need to be a owner"
The original error message is not very user friendly, we should somehow reformulate it so the customer can know better which resource it belongs too.
This especially is very confusing for e.g. credentials.
Requirements:
use the CRN to determine the type of resource we want to do an action on
(since environments:....:credentials:uuid) can be confusing.
check how expensive would it be to look up the name of the resource and return it with the error message or as an alternative guide the user on how can he describe the resource manually
You have insufficient rights to perform the following action "environments/describeCredential" on a Credential Type resource with
Resource identifier: .

This solution can extract resource type from CRN but still not showing the name of the resource in the message, as I see this is part of the ticket. Is this intentional?

I think it's too expensive


Sorting form questions issue

I noticed that sorting form questions on the front-end is not persistent.
A MembershipApi request is made to /questions/sort/[---]/up or /questions/sort/[---]/down respectively, but it fails.
After taking a quick look at the code it looks like there's no code handling this kind of request.

@jzongker Can you please check this out? The relevant code appears to run but sorting doesn't work. I suspect it has something to do with the sort field initialization query you ran on the database (did you ran it on the Production database?)


backgroundColor for form elements

ability to set backgroundColor on form widgets such as TextInput
ability to set backgroundColor of Inputs in the global theme

In theme today we can define a variety of styles for Input widget (applicable to the entire App) - see screenshot. BackgroundColor is missing so please add that.

closing this as @hamxa152 is done


Enable additional linters and fix reported issues

Codecov Report

Merging #339 (98ccc70) into master (75000ae) will increase coverage by 0.08%.
The diff coverage is 43.58%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
+ Coverage   69.54%   69.62%   +0.08%
==========================================
  Files          67       67
  Lines        5618     5617       -1
==========================================
+ Hits         3907     3911       +4
+ Misses       1303     1299       -4
+ Partials      408      407       -1

Impacted Files
Coverage Δ

net/dtlslistener.go
70.00% <ø> (ø)

tcp/server.go
81.28% <ø> (ø)

tcp/session.go
70.85% <0.00%> (ø)

udp/client.go
84.74% <ø> (ø)

udp/discover.go
54.54% <ø> (ø)

tcp/clientconn.go
68.19% <20.00%> (-0.12%)
:arrow_down:

net/blockwise/blockwise.go
67.58% <37.20%> (ø)

message/getETag.go
61.53% <50.00%> (ø)

udp/client/clientconn.go
71.29% <61.11%> (+0.47%)
:arrow_up:

net/connUDP.go
62.34% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75000ae...98ccc70. Read the comment docs.


Modify ExceptionThreadingUtility to stop adding stack trace as root

See #195

Add caller thread stack trace to HystrixRuntimeException
Override all printStackTrace methods in HystrixRuntimeException to print out the caller thread stack trace

Any idea as to when 1.4.0 will officially be released? Much thanks,,.

This functionality is not going into 1.4.x.  See #451

@MMalani We're looking at the order of a month or so.  At the moment, I've got 1.4.0-RC6 targeted as a bugfix release, 1.4.0-RC7 as an additive feature release, and then will begin production testing at Netflix.  Hopefully, that will go quickly, but if it doesn't, you can expect more issues/pull requests as that gets ironed out.


button 'Select Part' do not work

Installed the plugin today. Linux Mint. KiCad night with daily updates. The "Select part" button does not manifest itself in any way, nor does it open anything

Do you see any kind of output in the Textbox in the main window that indicates an error?

The field is empty.

Ok, thanks for the feedback. I will have to test this out on my Arch linux machine, hopefully I can reproduce it there!

I just tested this on an Arch linux machine and for me it seem that everything works as expected. The only scenario I can think of is that you didn't select any parts before clicking the select part button. At the moment the selection dialog is sapwned anyway which is not ideal, I guess I should prevent the dialog from opening if no part is selected and maybe show a warning 🤔 .

@maxvid Have you tested if it still not works for you?


getting the below error after npm start

C:\Users\git project\express-mongoose-es6-rest-api\config\config.js:30
throw new Error(Config validation error: ${error.message});
^
Error: Config validation error: child "JWT_SECRET" fails because ["JWT_SECRET" is required]

take a look at your .env.example and create a copy of that file as ".env". Then, create a db in your mongo as "express-mongoose-es6-rest-api-development" and restart the server.


avoid restriction to global PackageRepositoryManager

Problem: Lots of code in packages_.py uses a global PackageRepositoryManager instance, and this restricts all resource caching to a single pool.
It should instead be possible to create your own repo manager, and resolve contexts with this manager. This would mean that all resources (eg packages, variants etc) are cached into a separate pool, that does not affect the global pool.
One example of where this functionality is required is in pre-install/release package testing. The way this works is that a variant payload is installed, but before its associated package.py is updated (and hence the variant becomes visible), a separate variant is created and installed to a temporary package.py. This variant has its root attribute patched to point to the real payload. This allows us to run tests on this variant without it being visible in the real package repo. If the tests fail, the real variant payload is deleted, and nobody is affected. If the tests succeed, the release goes ahead as normal, and the real package.py is updated.
Currently, the above approach works, however the global repo manager's resource pool is polluted with the temporary testing variant.

Closed in favor of https://github.com/nerdvegas/rez/issues/1043


Add Annoy as VectorStore

Adds Annoy (https://github.com/spotify/annoy) as vector Store.
RESOLVES hwchase17/langchain#2842
discord ref:  https://discord.com/channels/1038097195422978059/1051632794427723827/1096089994168377354

Thanks for the comments - I store the "index config" now explicitly as part of the pickle via ConfigParser. Unfortunately one cannot get the used metric from the index itself (the dimensionality is possible though) - so I just added it explicitly. Still better like so imho.


Add SS5 as supported version

FYI #183 is needed for SS5 support too not just updating the composer file :) there's some deprecated api's that need to be replaced.

I'm aware :) I simply "started" the PR. There's more than only the API change to it :)

@GuySartorelli any chance someone from the Symbiote team can have a look at this and #183

Handled in #190


[SPARK-35859][PYTHON] Cleanup type hints in pandas-on-Spark

What changes were proposed in this pull request?
Cleaning up the type hints in pandas-on-Spark.

Use a single file _typing.py for type variables or aliases
Rename IndexOpsLike to SeriesOrIndex.
Rename T_Frame and T_IndexOps to FrameLike and IndexOpsLike respectively
Introduce DataFrameOrSeries for Union[DataFrame, Series]

Why are the changes needed?
This is a cleanup for the mypy check stuff series.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

cc @HyukjinKwon @itholic @xinrong-databricks

Thanks! merging to master.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44888/


Missing database in menu

Description
My added database is disappearing from the databases list, though it persists on the server(if i make requests i got proper responses).
DBeaver Version
Community Edition <IP_ADDRESS>309250303
Operating System
macOS Ventura 13.0
Database and driver

Databse PostgreSQL 15.2
Driver PostgreSQL JDBC Driver [42.5.2]

Steps to reproduce

Created database named db1, for example
Now i have default postgres and db1 databases
Then i was using db1 for 1 day and closed the app
Next day I launch DBeaver, connect to the server(local) and db1 is gone
If i check the server with pgadmin - it is shown

Additional context
No extensions

Hello @andriibezkorovainyi
Please check that this setting is enabled in your connection settings:

Hi, @LonwoLonwo. This helped, thank you very much  🤗, but i must say, the behaviour like that isnt enough obvious, regarding to the fact, that these settings are only changable while establishing connection rather then edit existing one. So, maybe, this option should be applied by default on my opinion. But im nove with the rest of the software features :)


Speed up process configuration

closes #18
The introduced fix also requires me to update the profiling recipe to include the step argument in process_configuration() in each processing step.

The introduced fix also requires me to update the profiling recipe to include the step argument in process_configuration() in each processing step.

Which is now fixed in broadinstitute/pooled-cell-painting-profiling-recipe#68


ext: mcux: Add import script and import latest version

Adds a new python script to automate importing the MCUXpresso SDK into Zephyr and uses the script to import the latest version. Parts of the SDK are re-licensed with a BSD-3-Clause-Clear license, which is a new license to Zephyr.
Updates README to follow template and reflect new licensing.
Fixes #5833
@mike-scott @vakulgarg The new uart driver supports hw flow control

Codecov Report

Merging #6633 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6633   +/-   ##
=======================================
  Coverage   53.51%   53.51%
=======================================
  Files         437      437
  Lines       41426    41426
  Branches     7935     7935
=======================================
  Hits        22169    22169
  Misses      16040    16040
  Partials     3217     3217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242c583...03d3702. Read the comment docs.

Thank you @MaureenHelm !   When I'm back in the office tomorrow, I'll rebase my LTE modem branch and test this update

@MaureenHelm: are you also setting up a PR for drivers/serial/uart_mcux.c to set enableRxRTS / enableTxCTS based on Kconfig options?

Hi @MaureenHelm, there are couple of nxp hal fixes in gPTP PR #6570.
The patches are called:

ext: hal: nxp: mcux: Fix ethernet timestamping driver
ext: hal: nxp: mcux: Enable enhanced buffer desc mode if needed
ext: hal: nxp: mcux: Fix PTP event packet type check

How could we get those fixes merged in upstream nxp hal?

Hi @MaureenHelm, there are couple of nxp hal fixes in gPTP PR #6570.
The patches are called:
ext: hal: nxp: mcux: Fix ethernet timestamping driver
ext: hal: nxp: mcux: Enable enhanced buffer desc mode if needed
ext: hal: nxp: mcux: Fix PTP event packet type check
How could we get those fixes merged in upstream nxp hal?

Thanks @jukkar, I'll file an internal ticket. Only the first and third commits need to go upstream, the second modifies a file unique to Zephyr.

@MaureenHelm I tested this PR along with my current modem driver and everything seemed to work just fine.  As a part of that testing, I rebased a patch to add the Kconfig settings for HW Flow Control support here: https://github.com/mike-scott/zephyr/commit/a296fcc089a42653360e04438b1d03f3295b749a    Let me know if you want me to put that up as a PR linked to this one.  Or feel free to add it here if you want.

@MaureenHelm any thoughts on my comments?  I asked, because I can see us wanting to merge the re-org change and related commits while we wait on any discussion about the updated import.  (Not sure how the re-org will impact PR #6367

In general all looks good, but maybe the import script should not be in the root of scripts/, but rather keep it somewhere in scripts/support?

IMO this should be in ext/hal/nxp/mcux/scripts, all in one place and when we move HALs out of the tree at some point, the script will be part of the deal.

Rebased to latest master
Moved script to ext/hal/nxp/mcux/scripts
Added example usage to commit message

Is this still stuck in license review hell?

Is this still stuck in license review hell?

Yes. The governing board is still discussing it.

Rebased to latest master

Do we want to pull the script out into its own PR, and close this for now?

Do we want to pull the script out into its own PR, and close this for now?

Sure


new Error().stack reporting wrong line number

Describe the bug
I am trying to create a simple logger that reports the line numbers where the log function was called by parsing new Error().stack. But the resulting line numbers are off--in my case, between 2 and 7 lines. I do not know if this is a sveltekit issue, a vite issue, or a non-issue.
Reproduction
With a freshly created app:
npm create svelte@latest lineno
cd lineno
npm install

If I create I $src/hooks.server.js with just a simple function:
export const handle = async ({ event, resolve }) => {
  console.log(new Error("My error").stack)
  return await resolve(event);
}

The stack trace reports line 4 instead of line 2;
Error: My error
    at Object.handle (/erikor/Documents/Business/lineno/src/hooks.server.js:4:15)

This continues to be true despite trying to enable sourcemaps in svelte.config.js:
const config = {
    compilerOptions: {
        enableSourcemap: true,
      },
    preprocess: sveltePreprocess({
        sourceMap: true,
    }),
    kit: {
        adapter: adapter()
    }
};

And vite.config.js:
const config = {
    plugins: [sveltekit()],
    build: {
        sourcemap: 'inline'
    },
};

And this is the case in both dev and prod.
If my code contains an actual error, then the reported line numbers are correct.
export const handle = async ({ event, resolve }) => {
  foo(bar);
  return await resolve(event);
}

foo is not defined
ReferenceError: foo is not defined
    at Object.handle (//Users/erikor/Documents/Business/lineno/src/hooks.server:2:3)

Logs
See above. There are no other logs I am aware of.

System Info
System:
    OS: macOS 12.6
    CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
    Memory: 1.94 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.12.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 108.0.5359.124
    Firefox: 108.0.1
    Safari: 16.0
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0 => 1.0.0
    @sveltejs/adapter-node: ^1.0.0 => 1.0.0
    @sveltejs/kit: ^1.0.0 => 1.0.1
    svelte: ^3.54.0 => 3.55.0
    vite: ^4.0.0 => 4.0.3

Severity
annoyance
Additional Information
No response

I do not know if this is a sveltekit issue, a vite issue, or a non-issue.

Because this is happening in a .js file without any .svelte file involved, it's almost certainly a Vite issue and not caused by SvelteKit or vite-plugin-svelte.

Vite 4.0.4 has a sourcemap fix. I see you're on 4.0.3. You could try upgrading and see if it helps.
https://github.com/vitejs/vite/blob/v4.0.4/packages/vite/CHANGELOG.md#404-2023-01-03

Upgrade to vite 4.0.4. Did not resolve issue. I will post over in vite. Thank you!


Unreachable code in core DataDomain to_dict method

The following check can never be None.
https://github.com/NOAA-OWP/DMOD/blob/664d7571bbe578df272fbf916c25557ad558fe77/python/lib/core/dmod/core/meta_data.py#L699
It can never be None because of the following in DataFormat's initializer.
https://github.com/NOAA-OWP/DMOD/blob/664d7571bbe578df272fbf916c25557ad558fe77/python/lib/core/dmod/core/meta_data.py#L144-L150
I think the check in DataDomain's to_dict method should instead be:
  if not self.data_format.data_fields:

@robertbartel, can you confirm this?

Hmm, I believe you are correct.  Pretty sure this was a missed component when the design of DataFormat changed, probably around the time StandardDatasetIndex was introduced.
Going a little further, it looks like the _custom_data_fields attribute itself probably needs to go.  It's present in a lot of places but doesn't ever actually get a value set by __init__ (except when that's called by deserialization, which should make getting to this a catch-22).

Thanks for having a look.

Going a little further, it looks like the _custom_data_fields attribute itself probably needs to go. It's present in a lot of places but doesn't ever actually get a value set by __init__ (except when that's called by deserialization, which should make getting to this a catch-22).

Right, so it looks like the only methods that will use _custom_data_fields are __eq__ and __hash__. I presume it's safe to remove _custom_data_fields from ContinuousRestriction? If that is the case, I can address this in #228.

I presume it's safe to remove _custom_data_fields from ContinuousRestriction?

Essentially yes, but from DataDomain.

If that is the case, I can address this in #228.

I hesitate slightly because of both scope creep and the potential for #228 to take a while to actually be finished and incorporated.  For now, sure, go ahead with that.  If #228 remains unresolved for more than another week, we should probably come back and separate this.

Essentially yes, but from DataDomain.

Right, duh, I don't know why I wrote ContinuousRestriction.

I hesitate slightly because of both scope creep and the potential for #228 to take a while to actually be finished and incorporated. For now, sure, go ahead with that. If #228 remains unresolved for more than another week, we should probably come back and separate this.

👍


CA-442-When-Conf-App-ended-and-user-logged-in-bring-the-user-to-TABula-main-screen1

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

[ ] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details
JIRA link(s):

AHOYAPPS-0000

Description
A description of what this PR does.
Burndown
Before review

[ ] Updated CHANGELOG.md if necessary
[ ] Added unit tests if necessary
[ ] Updated affected documentation
[ ] Verified locally with npm test
[ ] Manually sanity tested running locally
[ ] Included screenshot as PR comment (if needed)
[ ] Ready for review

Before merge

[ ] Got one or more +1s
[ ] Re-tested if necessary

Why it is to merge-code branch and not to integration (develop) branch?
Tal

merge-code branch is the develop, for now, we can change it, but we need to ask Chana before, because its depend in cicd pipeline

Why it is to merge-code branch and not to integration (develop) branch?
Tal

merge-code branch is the develop, for now, we can change it, but we need to ask Chana before, because its depend in cicd pipeline


ETH transfer

/Users/apple/Documents/starknet.js-workshop/node_modules/starknet/dist/provider/sequencer.js:394
error = new Error(message);
^
Error: REJECTED: TRANSACTION_FAILED
Error at pc=0:91:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:739)
Unknown location (pc=0:682)
Unknown location (pc=0:358)
Unknown location (pc=0:400)
Unknown location (pc=0:423)
Error in the called contract (0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7):
Error at pc=0:104:
Got an exception while executing a hint.
Cairo traceback (most recent call last):
Unknown location (pc=0:1678)
Unknown location (pc=0:1664)
Error in the called contract (0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7):
Error at pc=0:1344:
An ASSERT_EQ instruction failed: 10:3 != 10:2.
at SequencerProvider. (/Users/apple/Documents/starknet.js-workshop/node_modules/starknet/dist/provider/sequencer.js:394:37)
at step (/Users/apple/Documents/starknet.js-workshop/node_modules/starknet/dist/provider/sequencer.js:33:23)
at Object.next (/Users/apple/Documents/starknet.js-workshop/node_modules/starknet/dist/provider/sequencer.js:14:53)
at fulfilled (/Users/apple/Documents/starknet.js-workshop/node_modules/starknet/dist/provider/sequencer.js:5:58)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
response: [Object: null prototype] {
tx_status: 'REJECTED',
tx_failure_reason: [Object: null prototype] {
code: 'TRANSACTION_FAILED',
error_message: 'Error at pc=0:91:\n' +
'Got an exception while executing a hint.\n' +
'Cairo traceback (most recent call last):\n' +
'Unknown location (pc=0:739)\n' +
'Unknown location (pc=0:682)\n' +
'Unknown location (pc=0:358)\n' +
'Unknown location (pc=0:400)\n' +
'Unknown location (pc=0:423)\n' +
'\n' +
'Error in the called contract (0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7):\n' +
'Error at pc=0:104:\n' +
'Got an exception while executing a hint.\n' +
'Cairo traceback (most recent call last):\n' +
'Unknown location (pc=0:1678)\n' +
'Unknown location (pc=0:1664)\n' +
'\n' +
'Error in the called contract (0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7):\n' +
'Error at pc=0:1344:\n' +
'An ASSERT_EQ instruction failed: 10:3 != 10:2.'
}
}
}

Same error here when transfer.

Are there any updates on this issue, is it resolved with the latest releases?
If not can you give a sample of code to reproduce this locally, is it reproducible only on testnet or also on devnet?

@tabaktoni For ASSERT_EQ error, this is reproducible in Goerli, and the cause is missing trailing 0 in calldata:
const contract = new starknet.Contract(ethAbi, ethContractAddress, provider);
const call = contract.populate('transfer', [recipientAddress, amount]);

// vvv Uncommenting this line will fix the issue vvv
// call.calldata?.push(starknet.number.toBN("0x00"));

const calldata = starknet.transaction.fromCallsToExecuteCalldata([call]);
const txid = starknet.hash.calculateTransactionHash(
    senderAddress,
    version,
    calldata,
    maxFee,
    goerliChainId,
    starknet.number.toBN(await provider.getNonceForAddress(senderAddress)),
);
const signature = starknet.ec.sign(keyPair, txid);
await provider.invokeFunction({ contractAddress: senderAddress, calldata, signature }, { nonce, maxFee, version });

@kcy1019 Because type of amount is Uint256 which requires two felt so you need to include Uint256 struct definition in abi:
        const ethAbi = [
            { "name": "transfer", "type": "function", "inputs": [{ "name": "recipient", "type": "felt" }, { "name": "amount", "type": "Uint256" }], "outputs": [{ "name": "success", "type": "felt" }] },
            {
                "members": [
                    {
                        "name": "low",
                        "offset": 0,
                        "type": "felt"
                    },
                    {
                        "name": "high",
                        "offset": 1,
                        "type": "felt"
                    }
                ],
                "name": "Uint256",
                "size": 2,
                "type": "struct"
            }
        ];

And then include both low and high values:
const call = contract.populate('transfer', [other.address, ["1000", "0"]]);
// or
const call = contract.populate('transfer', [other.address, {
     low: uint256.bnToUint256(1000).low,
     high: uint256.bnToUint256(0).high,
}]);

@NIC619 Thank you for the detailed explanation and the fix!


schema: Document that ranges should be half-open

Test plan
n/a, codegen checked by CI

While we're defining things. Can Ranges be empty? As in Range(p1, p2) where p1 == p2?

Yes, ranges can be empty.