Failing onehop test

{
    "message": {
        "query_graph": {
            "nodes": {
                "a": {
                    "category": "biolink:ActivityAndBehavior",
                    "id": "umlscui:C0562508"
                },
                "b": {
                    "category": "biolink:ActivityAndBehavior"
                }
            },
            "edges": {
                "ab": {
                    "subject": "a",
                    "object": "b",
                    "predicate": "biolink:correlated_with"
                }
            }
        },
        "knowledge_graph": {
            "nodes": {},
            "edges": {}
        },
        "results": []
    }
}

This is returning no results, but based on this element in the onehop tests:
{
            "subject_category": "biolink:ActivityAndBehavior",
            "object_category": "biolink:ActivityAndBehavior",
            "predicate": "biolink:correlated_with",
            "subject": "umlscui:C0562508",
            "object": "umlscui:C2348993"
        },

I would expect to get back umlscui:C2348993

I ran this query:

Here are the results:
{
"terms and conditions": "The Translator Integrated Clinical and Environmental Exposures Service (ICEES) is providing you with Data that have been de-identified in accordance with 45 C.F.R. §§ 164.514(a) and (b) and that UNC Health Care System (UNCHCS) is permitted to provide under 45 C.F.R. § 164.502(d)(2). Recipient agrees to notify UNCHCS via NC TraCS in the event that Recipient receives any identifiable data in error and to take such measures to return the identifiable data and/or destroy it at the direction of UNCHCS.\n\nRestrictions on Recipient’s Use of Data. Recipient further agrees to use the data exclusively for the purposes and functionalities provided by the ICEES: cohort discovery; feature-rich cohort discovery; hypothesis-driven queries; and exploratory queries. Recipient agrees to use appropriate safeguards to protect the Data from misuse and unauthorized access or disclosure. Recipient will report to UNCHCS any unauthorized access, use, or disclosure of the Data not provided for by the Service of which Recipient becomes aware. Recipient will not attempt to identify the individuals whose information is contained in any Data transferred pursuant to this Service Agreement or attempt to contact those individuals. Recipient agrees not to sell the Data to any third party for any purpose. Recipient agrees not to disclose or publish the Data in any manner that would identify the Data as originating from UNCHCS. Finally, Recipient agrees to reasonably limit the number of queries to the Service per IP address within a given time interval, in order to prevent rapid ‘attacks’ on the Service.\n\nWe kindly request that users of this service provide proper attribution for any products (e.g., manuscripts, podium presentations, software) derived from the use of ICEES. Attribution should include acknowledgement of the funder, the National Center for Advancing Translational Sciences, Biomedical Data Translator Program (awards OT3TR002020 and OT2TR002514) and Center for Translational Science Award Program (UL1TR002489). Please also acknowledge the Renaissance Computing Institute, UNC Health Care System, UNC Hospitals, and any affiliated team members who contributed to the work.\n",
"message": {
"query_graph": {
"nodes": {
"n00": {
"category": "biolink:ActivityAndBehavior",
"id": "umlscui:C0562508"
},
"n01": {
"category": "biolink:ActivityAndBehavior"
}
},
"edges": {
"e00": {
"subject": "n00",
"object": "n01",
"predicate": "biolink:correlated_with"
}
}
},
"knowledge_graph": {
"nodes": {
"umlscui:C0562508": {
"category": [
"biolink:A",
"biolink:C",
"biolink:T",
"biolink:I",
"biolink:V",
"biolink:I",
"biolink:T",
"biolink:Y",
"biolink:",
"biolink:A",
"biolink:N",
"biolink:D",
"biolink:",
"biolink:B",
"biolink:E",
"biolink:H",
"biolink:A",
"biolink:V",
"biolink:I",
"biolink:O",
"biolink:R"
]
}
},
"edges": {}
},
"results": []
},
"reasoner_id": "ICEES",
"tool_version": "4.0.0",
"datetime": "2021-04-04/13/21 14:32:04",
"n_results": 0,
"message_code": "OK",
"code_description": ""
}
Response headers


Add precommits

Codecov Report

Merging #651 (9ab38e6) into master (2863c4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #651   +/-   ##
=======================================
  Coverage   97.49%   97.49%
=======================================
  Files          23       23
  Lines        2713     2713
=======================================
  Hits         2645     2645
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2863c4d...9ab38e6. Read the comment docs.


Attribute Case Mismatch

I'm surprised this hasn't been realized before, but the attrs object passed to link by Angular contains only lower case keys.  In other words, Angular maps them all to lower case when processing them.  However, React is case sensitive.  So if the React component has a property name that includes upper case (like nearly every event handler), then you can't provide a value to it because you'll never find the name of that property in attrs.
This addresses that quite simply by determining both the React name, propName, and the corresponding Angular attribute name attrName and using the appropriate key in propNames and attrs respectively.

Thanks for you pull request.
Perhaps I'm misunderstanding the issue, but isn't because you need to use a - in angular. If you look at this test you can see that it adds a attr called change-name which matches the prop changeName ?

@kasperp You are completely correct.  I tried it out and it seems to work for me.  I think you can ignore the pull request.  The proper solution is to use hyphens in the Angular attribute name.  Thanks!


added upload abort/cancel support

#195 This should add support to abort upload if already started.

does this actually works?

Sure! I'm using this in my current project and this works OK.

When this can be merged ?

thanks @marekszczepansky!

You're welcome :)

Yay ! thank you both 👍


It's not possible to use global tokens values for locally scoped tokens

Is your feature request related to a problem? Please describe.
It's not possible to use global tokens values for locally scoped tokens, so for example I can't do this:
const ToolbarButton = styled('a', {
  $$defaultIconColor: '$red100',
  color: '$$defaultIconColor',
  fill: '$$defaultIconColor',
});

, because $$defaultIconColor becomes ---defaultIconColor instead of --colors-red-100.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I want the $$defaultIconColor become --colors-red-100 in such case.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi, @patryknawolski!
How would $$defaultIconColor know to pull from colors? You’ll either need to define that relationship in themeMap, or assign it a scale-specific value of $colors$red100.
In either case, that should cause --defaultIconColor to reference --colors-red100.


I love this package!

I'm using it extensively in the dev environment now and I'm super enthousiastic about it.
The existence of this package is one of the reasons I'm using webpack for my frontend now, which has a lot of advantages I found out ;)
But one thing, would it be possible to update the PyPy version? :)
Thanks!

And another question: Would it be possible to include util functions within the Django settings? (for example for tinymce)

Actually, I also wrote a webpack_manifest context processor that might come to handy to some other people as well:
def webpack_manifest(request):
    # not used in the API!
    # creates inline manifest based on file

    webpack_config = load_config('DEFAULT')
    manifest_path  = os.path.join(settings.FRONTEND_DIR, 'assets', webpack_config['BUNDLE_DIR_NAME'], 'chunk-manifest.json')

    try:
        with open(manifest_path) as f:
            manifest_content = f.read()
    except IOError:
        raise IOError(
            'Error reading {0}. Did you create a manifest?'.format(
                manifest_path))

    inline_webpack_manifest = mark_safe('<script> \
                            //<![CDATA[\
                            window.webpackManifest = '+manifest_content+'\
                            //]]>\
                        </script>')

    return {'inline_webpack_manifest':inline_webpack_manifest}

Cheers!

@gabn88 I've released a new version with latest changes from master. Thanks!


Warning: PHP Startup : Unable to load dynamic library /../pinpoint.so: undefined symbol: ....

Expected Behavior

start pinpoint_c_agent

Current Behavior

error when run './Build.sh' in '/pinpoint_c_agent/pinpoint_php'

Failure Information (for bugs)
PHP Warning:  PHP Startup: Unable to load dynamic library '/pinpoint-c-agent/pinpoint_php/modules/pinpoint.so' - /pinpoint-c-agent/pinpoint_php/modules/pinpoint.so: undefined symbol: _ZN8Pinpoint5Agent13UdpDataSender16MAX_REFRESH_MSECE in Unknown on line 0
Steps to Reproduce
Please provide detailed steps for reproducing the issue.

step 1 Checking phpize path
find / -name phpize
/usr/bin/phpize
export PATH=/usr/bin/phpize:$PATH)
echo $PATH
/usr/bin/phpize:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin

step 2 Specifying BOOST and THRIFT path
find / -name boost
/usr/include/boost
find / -name thrift
/usr/local/include/thrift

export WITH_BOOST_PATH='/usr/include'
export WITH_THRIFT_PATH='/usr/local/include'
3.step 3 Run ./Build.sh --enable-debug --always-make && make install
cd /pinpoint-c-agent/pinpoint_php
./Build.sh --enable-debug --always-make && make install
result:
Build complete.
Don't forget to run 'make test'.
Installing shared extensions:     /usr/lib64/php/modules/
Build complete.
Don't forget to run 'make test'.
libgcc_s.so.1 must be installed for pthread_cancel to work
libgcc_s.so.1 must be installed for pthread_cancel to work
PHP Warning:  PHP Startup: Unable to load dynamic library '/pinpoint-c-agent/pinpoint_php/modules/pinpoint.so' - /pinpoint-c-agent/pinpoint_php/modules/pinpoint.so: undefined symbol: _ZN8Pinpoint5Agent13UdpDataSender16MAX_REFRESH_MSECE in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/pinpoint-c-agent/pinpoint_php/modules/pinpoint.so' - /pinpoint-c-agent/pinpoint_php/modules/pinpoint.so: undefined symbol: _ZN8Pinpoint5Agent13UdpDataSender16MAX_REFRESH_MSECE in Unknown on line 0
PHP         : /usr/bin/php
Warning: PHP Startup: Unable to load dynamic library '/pinpoint-c-agent/pinpoint_php/modules/pinpoint.so' - /pinpoint-c-agent/pinpoint_php/modules/pinpoint.so: undefined symbol: _ZN8Pinpoint5Agent13UdpDataSender16MAX_REFRESH_MSECE in Unknown on line 0
PHP_SAPI    : cli
PHP_VERSION : 5.4.16
ZEND_VERSION: 2.4.0
PHP_OS      : Linux - Linux PHP 3.10.0-862.el7.x86_64 #1 SMP Fri Apr 20 16:44:24 UTC 2018 x86_64
INI actual  : /pinpoint-c-agent/pinpoint_php/tmp-php.ini
More .INIs  :
CWD         : /pinpoint-c-agent/pinpoint_php
Extra dirs  :
VALGRIND    : Not used
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Operating System: CentOS7.7.1908

PHP Version: 5.4.16

php.ini:
[pinpoint]
extension=/usr/lib64/php/modules/pinpoint.so
pinpoint_agent.trace_exception=true
pinpoint_agent.config_full_name=/pinpoint-c-agent/quickstart/config/pinpoint_agent.conf:1

php-fpm or apache:
php-fpm: unmodified
apache: 2.4.6

pinpoint_agent.conf:
entID=php_pinpoint
ApplicationName=PHPApplication

collector ip address
CollectorSpanIp=<IP_ADDRESS>
CollectorSpanPort=9996
CollectorStatIp=<IP_ADDRESS>
CollectorStatPort=9995
CollectorTcpIp=<IP_ADDRESS>
CollectorTcpPort=9994
TraceLimit = -1
SkipTraceTime = -1
DEBUG|INFO|WARN|ERROR
PPLogLevel = DEBUG
LogFileRootPath = /data/log
AgentType -> NGINX | APACHE |PHP |TEST
AgentType="PHP"
plugin
PhpInternalFunctionsPlugin
PluginExclude = ExcludePlugin
PluginInclude = PhpRequestPlugin;QuickStartPlugin  ; PhpInternalFunctionsPlugin ;ExcludePlugin ;PDOPlugin;CurlPlugin;
[PHP]
PluginEntryFile=plugins_create.php
PluginRootDir=/pinpoint-c-agent/quickstart/php/web/plugins
*boost 1.71.0
*thrift 0.11.0
*pinpoint_c_agent 0.1.0
How can I fix this error?

I recommended you update to v0.2.0(easy to deployment and faster)
....
libgcc_s.so.1 must be installed for pthread_cancel to work
...

You did not make it right.

I already installed libgcc_s.so.1
find / -name libgcc_s.so.1
/usr/lib64/libgcc_s.so.1
/lib/libgcc_s.so.1
Do I have to change paths?


hub: support user info changes

Hub ignores all changes to user info, except the first one. We should support info updates properly.
Related to #43

Done


Slurper is not detecting copying file

slurper is start copying the file as soon as it detect the file in local file system. its not waiting till full copy.
I am setting below property in the configuration file
VERIFY = true
Please let me know if  i'm missing anything.
Note : I am using winscp tool for uploading files into slurper in directory

There can be a race condition if a file is being written-to when the
slurper picks it up.  The general recommendation is to either perform an
atomic move into the directory of a file, or if you're writing to a file,
make it "hidden" (prefix with a period "."), and once the file's been
written then rename it.
On Mon, Sep 14, 2015 at 9:42 AM, nagarajasn<EMAIL_ADDRESS>wrote:

slurper is start copying the file as soon as it detect the file in local
file system. its not waiting till full copy.
I am setting below property in the configuration file
VERIFY = true
Please let me know if i'm missing anything.
Note : I am using winscp tool for uploading files into slurper in directory
—
Reply to this email directly or view it on GitHub
https://github.com/alexholmes/hdfs-file-slurper/issues/13.


Update core-foundation-sys to 0.8

Why? Is this for updating core-foundation-sys in gecko?

Yes

Otherwise we end up with multiple copies

Can you paste the bug number here?

https://bugzilla.mozilla.org/show_bug.cgi?id=1654699


Indexing is required every time an observer is opened

After installing the plugin, indexing is required every time the observer is opened, resulting in slow startup

Obsidian is reindexing or make.md is reindexing every startup?

Obsidian is reindexing or make.md is reindexing every startup?
After the makemd plug-in is enabled, the obsidian startup is very slow and the following information is displayed


Type-level symbols in Japanese are not rendered properly.

The issue is in GHC
[nix-shell:/tmp]$ ghc T.hs
[1 of 1] Compiling T                ( T.hs, T.o )

T.hs:3:6: error:
    Illegal type: ‘"\26085\26412\35486"’
      Perhaps you intended to use DataKinds
  |
3 | t :: "日本語"
  |      ^^^^^

[nix-shell:/tmp]$ cat T.hs
module T where

t :: "日本語"
t = undefined

Sadly Trac seems to be down at the moment so I can't make a ticket.

Thanks @Fuuzetsu for reporting! It may be worth to take a look here: https://github.com/ghc/ghc/blob/master/compiler/iface/IfaceType.hs#L1013
I have a hunch that the show is the culprit here...

yeah, looking… at the very we're doing
FastString -> String (decodeUtf8) -> show (show instance) -> show (pprIfaceTyLit) which seems weird; I'll try to look into it today if I manage to wrestle with GHC

[nix-shell:~/programming/ghc]$ inplace/bin/ghc-stage2 /tmp/T.hs
[1 of 1] Compiling T                ( /tmp/T.hs, /tmp/T.o )

/tmp/T.hs:3:6: error:
    Illegal type: ‘日本語’ Perhaps you intended to use DataKinds
  |
3 | t :: "日本語"
  |      ^^^^^

[nix-shell:~/programming/ghc]$ git diff
diff --git a/compiler/utils/FastString.hs b/compiler/utils/FastString.hs
index 8653485e0c..7a53895b01 100644
--- a/compiler/utils/FastString.hs
+++ b/compiler/utils/FastString.hs
@@ -208,7 +208,7 @@ instance Monoid FastString where
     mconcat = concatFS

 instance Show FastString where
-   show fs = show (unpackFS fs)
+   show fs = unpackFS fs

 instance Data FastString where
   -- don't traverse?

Sadly GHC Trac and everything else are down.

I think we should be careful here: Chaning show for FastString might have other knock-on consequences. Just using the right combinator at the right places seems like a cleaner solution.

If it passes validate then it should be good enough. There should be no critical functionality relying on a Show instance of it. I plan to propose it as-is.

                                                                                ('GHC.Generics.MetaSel
                                                                                ('GHC.Base.Just
-                                                                                "d12d")
+                                                                                d12d)

Seems it may break some deriving mechanisms and few other things &c.
-     No instance for (HasField "foo" T Int)
+     No instance for (HasField foo T Int)

Lame ;/


MNT: Re-rendered with conda-smithy 2.3.2

Add python3.6

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

closing in favor of https://github.com/conda-forge/staged-recipes/pull/3614


face-alignment changed code

in the version find_best_frame = True
there will be a problem to read the actual code from face alignment.
So if you change the demo.py in line
107 to
fa = face_alignment.FaceAlignment(face_alignment.LandmarksType.TWO_D, flip_input=True, #the 2 is getting to TWO
everything will go on fine.

few weeks before I had same issue and It went well as what you said. Thank you! :)
but now it does not work. I think it has been changed.


Gradio Web demo

easy to use web demo on gradio hub

@AK391 thanks for contributing! Very cool that you can easily setup a web demo like this.
Could you please make a few small changes:

Move the gradio relevant files (demo.py, *.mp4 files) into a gradio folder
I think formatting in the README might be better if the gradio link / section is removed and you can add a [Gradio Demo] to the top of the README like [Paper][Website][Colab][Gradio Demo]

@wilson1yan thanks made the suggested changes

@AK391 great, thanks!


BlueSSLService cannot be cross-compiled

BlueSSLService uses #if os(...) in the Package.swift file which prevents it from being cross-compiled because that makes the assumption that the Package.swift is executed on the same OS as the resulting binaries will be which isn't true for cross-compilation.
I know this is to make it compatible with macOS without installing Open/LibreSSL using homebrew on macOS and I don't know if there's a full solution to get it to properly work with SwiftPM. There might be a way using conditional imports in the .swift files rather than in the Package.swift but I'm not 100% sure.
The other option is that we do something hacky and we change the
#if os(Linux)

to something like
#if CROSS_COMPILATION_TARGET_LINUX || os(Linux)

and in the cross compilation toolchain builder script we'd just add
-DCROSS_COMPILATION_TARGET_LINUX

to the extra-swiftc-flags list.

I prepared a PR for that: https://github.com/apple/swift-package-manager/pull/2114


JS9 could not preload image

JS9 doesn't display some FITS files and throws this issue:

JS9 ERROR: could not preload image(s):  https://fits.ztf.snad.space/products/sci/2018/0621/355000/ztf_20180621355000_000685_zr_c05_o_q4_sciimg.fits

Example light curve: https://ztf.snad.space/dr8/view/685205400141854 (the brightest point in the flare)

I cannot reproduce it, I hope it was a temporal issue. Please free to reopen if you find more examples


Triangle Count

Added triangle count algorithm with correctness tests. Also added the source file to generate graphsdocs using Literate, function documented are bellman-ford and triangle-count.

Codecov Report
Patch coverage has no change and project coverage change: -0.41 :warning:

Comparison is base (ac731f6) 78.64% compared to head (3a2f62d) 78.24%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   78.64%   78.24%   -0.41%
==========================================
  Files          49       49
  Lines        4590     4730     +140
==========================================
+ Hits         3610     3701      +91
- Misses        980     1029      +49

see 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Corrected function parsePOST

This bugfix branch solves issue #29.

@jaimeperez could you please have a look at this?
If everything's ok, could you please merge this PR and close the corresponding issue?


Problem compiling with VS 2022

Compiling with VS 2022 does not work:
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0006	Metadata file 'C:\Users\user\Source\Repos\ImprosecPasswordAuditor\DSInternals.Replication\bin\Debug\DSInternals.Replication.dll' could not be found	ipsvc	C:\Users\user\Source\Repos\ImprosecPasswordAuditor\ipsvc\CSC	1	Active
Error	CS0006	Metadata file 'C:\Users\user\Source\Repos\ImprosecPasswordAuditor\Debug\DSInternals.Replication.Interop.dll' could not be found	DSInternals.Replication	C:\Users\user\Source\Repos\ImprosecPasswordAuditor\DSInternals.Replication\CSC	1	Active
Error	CS0006	Metadata file 'C:\Users\user\Source\Repos\ImprosecPasswordAuditor\Debug\DSInternals.Replication.Interop.dll' could not be found	ipsvc	C:\Users\user\Source\Repos\ImprosecPasswordAuditor\ipsvc\CSC	1	Active
Warning		The referenced component 'NDceRpc.Microsoft' could not be found.	DSInternals.Replication

Hi martclau,
Please refer to issue #2. Basically, you need to set a valid Windows SDK version for that specific project and rebuild it on its own, I put screenshots in the other issue :)

Hi martclau,
Please refer to issue #2. Basically, you need to set a valid Windows SDK version for that specific project and rebuild it on its own, I put screenshots in the other issue :)

Ok, thanks for the link, the latest version works with your recommendations.


Image URL undefined

📌 Describe Issue

readme: [![stackticon](undefined)](https://github.com/msdio/stackticon)
link only: undefined
img:

Image URL not found.
In firebase, I confirmed that the image is created well.
🐠 Checklists

[  x ] Are image links created properly?
[  x ] Does the same problem occur when selecting a different stack? -> [![stackticon](undefined)](https://github.com/msdio/stackticon)

🚴 Possible(or Suggest) solutions
I'm not sure because I haven't checked the code related to the issue yet,
There seems to be a problem in the process of receiving the image link.
🍳 Environments

Device:
OS:
Browser:
Version:

📷 Screenshots

I checked test codes on utils, but it seems there is no problem with it.
Maybe it is not passing props properly to result page, I will take look on it.


updated dependencies

@SylvainEstevez I cant merge this. Could you kindly do that.
Also, I dont think I can publish this to the registry right ? I never published anything to NPM before but I suspect I need to have some permissions to do so ...

@asiFarran I invited you to be admin on both the GH and NPM orgs, check you inbox

Got it and accepted invites. I still dont seem to have write access to this repo though - cannot merge it

I made you owner, try again @asiFarran ?


Update Go gRPC dependency

grpc.Dial() is (soon to be) deprecated in current gRPC versions. Use grpc.NewClient() instead.

If no URI scheme is specified, dns is used by default. The documentation does specify that the argument should be a URI and gives an example using the dns:/// prefix. We could omit the schema but I don’t think there is any harm in specifying the complete URI as intended.


win10 svrx没反映

Describe the bug
win10 cmd窗口运行svrx后没反映~，cmd也不能ctrl c中断，而且关闭还没响应了。
Desktop (please complete the following information):

OS: win10 1809

Additional context

Hi @minhail, is your Node.js version v12? We suspect it might be somehow related to the Node.js of version v12. Can you downgrade to v10 and have another try?
Hi, 请问下你的 Node.js 版本是 v12 吗？我们怀疑可能是和 node 版本有关，可以尝试切换到 v10 试试吗？

我的node是v10.16.3版本的~

me too , it does't work in  win10。。。。。。。 fix it plz

me too , it does't work in win10。。。。。。。 fix it plz

@zhuzhensuo will fix  in v1.05 , release before tomorrow

Please update @svrx/cli to 1.0.2 and then try:
svrx install
svrx


Removed depreciated

deta run is depreciated hence removed from docs

it's used by us sometimes, so we would like to keep a reference for now

it's used by us sometimes, so we would like to keep a reference for now

🫣👍🏻


Colocation groups config

Right now we specify the components that should run together in a colocation group. For all the others we run them in their own groups. However, given that the group is the unit of deployment, we'll have to add configuration knobs that make sense per colocation group.
This PR provides some options to set per colocation group knobs in the config.

We never reached a conclusion on what is the right way to specify collocation groups. The way we let users specify collocation groups as of now seems fine.


Close files in disk cache if they are not used any more

We need to close files if we do not have pages of them in both disk read and write cache and if amount of open files reached limit of open files.  It seems like the most fast approach is usage of com.orientechnologies.orient.core.index.hashindex.local.cache.OReadWriteDiskCache#filePages state.
If limit of open files is reached we find files with zero amount of pages in cache or if such ones do not exist, files with smallest amount of pages are closed. If limit of open files is reached amount of closed files is calculated using following approach:

All files which do not have associated pages in cache are closed, without exception.
If limit of files which should be closed is not reached, files with smallest amount of pages are closed till limit is reached.

I will introduce first checked exception inside of OrientDB , OFileClosedException. It is needed because files now are closed automatically it they are not used for a long time.

ETA for this issue is 3 days, so it will be fixed at 6-th of Mat (holidays are taken in account).

I do suggest to move it to 2.2 version. Too much of changes for rc version.
Also this fix is not urgent at all.

:+1: Let's discuss in the private group chat what's missing for 2.1-rc2

too much of effort better to manage open storages through lru list and close least recently used one.


Fix window exception in WWLLN

Description:
When configuring wwlln via configuration.yaml, we allow users to input any time_period schema for the window parameter (for maximum flexibility). In each case, this returns a timedelta; unfortunately, timedeltas can't be JSON-serialized, so they can't be saved in config entries as-is. This would cause an unhandled exception.
Related issue (if applicable): https://github.com/home-assistant/home-assistant/issues/25099
Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for configuration.yaml (if applicable):
wwlln:
  window: 300

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

@MartinHjelmare RE: this:

I would recommend adding a test where we set up the component and let that import a config entry. But it's not strictly necessary for this PR.

...doesn't test_step_import do that?

No we just test that step in the config flow. The component hasn't been set up.

@MartinHjelmare Ah, I see. I'll add another test in a new PR. 👍


restore accidentally deleted "swapAt"

Accidentally deleted in 7d332592590f83573ff6d7729391557e69cdb021.

Thanks. LGTM :)

Auto-merge toggled on


[Bug] Tasks plugin not cover all function when Lazy plugin loader enable

In normally, with Tasks plugin and Kanban plugin.
When tick checkbox or move card to completed list in kanban board. Tasks will add completed date (if enable) to a checkbox/card.
When Lazy plugin loader plugin enable, that feature is missing even I set Tasks and Kanban plugin as instant load.
This didn't occer in previous version. Maybe version that when enable plugin loader debugging, it will show all plugins that enable plus lazy plugin. (In this version it only shows lazy plugin not instant load plugin)

Thanks @l2eused - I can replicate the issue. To resolve it I have reverted the change suggested by Obsidian team here.
If you upgrade to 1.0.13 and set Kanban and Tasks to Instant, it will now work correctly.
(For future reference, I can confirm the loading the plugins with any other method causes the completed date to not function. The order of loading the plugins doesn't matter either.)

You'll need to restart a couple of times for the new settings to take effect before you can see the final result of the update.

This is what I get, which is what I would expect:

Just make sure you restart a couple of times to lock in the individual plugin startup settings after the 1.0.13 update.

You are right, I can see there is something strange about the combination of those two plugins. The kanban plug-in does indeed appear to the load instantly, even if you haven't sent to be a delay. I will keep diagnosing this.

Should be fixed now in 1.0.15. It was a missing setting being undefined and causing all plugins to instantly start.


ProcessPoolExecutor hangs

The example below hangs when using s3fs with ProcessPoolExecutor but not when using ThreadPoolExecutor. Both work with local file system.
"""
example.py
""""

import argparse
import concurrent.futures
from concurrent.futures import Executor
from os import PathLike
from typing import List, Type, Iterator, Union, Iterable

import fsspec

EXEC_MAP = {
    "thread": concurrent.futures.ThreadPoolExecutor,
    "process": concurrent.futures.ProcessPoolExecutor,
}

def find_files(path: Union[str, PathLike]) -> Iterator[str]:
    """
    Find files contained in path.
    """
    path_str = str(path)
    # Create a filesystem object using fsspec
    fs = fsspec.open(path_str).fs

    # Get the protocol (e.g., "s3", "file", etc.)
    protocol = fs.protocol if isinstance(fs.protocol, str) else fs.protocol[0]

    # Check if the path is a directory
    if fs.isdir(path_str):
        # If it's a directory, iterate over the files in the directory
        for file in fs.find(path_str):
            if not fs.isdir(file):  # Ensure it's a file, not a subdirectory
                yield f"{protocol}://{file}"
    else:
        # If it's a file, yield the file with protocol
        yield f"{protocol}://{path_str}"

def find_all_files(paths: Iterable[Union[str, PathLike]]) -> Iterator[str]:
    """Find all files contained in paths."""
    for path in paths:
        yield from find_files(path)

def get_content_length(uri):
    with fsspec.open(uri) as fp:
        return len(fp.read())

def process_many(exec_type: Type[Executor], filez: List[str]):
    with exec_type() as executor:
        futures = list()
        for file in list(find_all_files(filez)):
            print(file)
            futures.append(executor.submit(get_content_length, file))

        print("futures submitted. waiting for results")
        for ftr in concurrent.futures.as_completed(futures):
            print(ftr.result())

def main():
    parser = argparse.ArgumentParser()
    parser.add_argument("filez", help="file paths", type=str, nargs="+")
    parser.add_argument(
        "--exec-type",
        type=str,
        choices=EXEC_MAP.keys(),
        required=True,
    )
    args = parser.parse_args()

    process_many(EXEC_MAP.get(args.exec_type), args.filez)

if __name__ == "__main__":
    main()

Works
python example.py path/to/dir --exec-type process
python example.py path/to/dir --exec-type thread
python example.py s3://path/to/dir --exec-type thread

Hangs
python example.py s3://path/to/dir --exec-type process

Version info
fsspec==2024.6.1
s3fs==2024.6.1

Python 3.10.14

async ioloops and threads are not fork-safe. You may be able to get things running by using spawn or spawnserver start methods for your processes. fsspec tries to detect that it finds itself in a forked process, but this cannot be guaranteed.
Other possible workarounds:

don't create a filesystem in the main process at all
don't cache instances (skip_instance_cache=True); this is less likely to help.

Thanks @martindurant. As long as we use ThreadPoolExecutor we are able to query the file system object in the main thread and don't need to worry about deadlocks?

I don't expect any problems with threads, but note that s3fs is async and runs its ioloop in a dedicated thread, so you probably don't get any parallelism on the IO by doing this. You might still get parallelism on whatever you then do with what you fetched.

Multiprocessing documentation that I evidently missed.


"Page not found" : Skuba-validate-pr-author status link

It seems skuba-validate-pr-author CI job status link is broken when try to see why it failed.

Can you give a specific one? There's been issues with the Jenkins sever itself lately which might of caused this. Usually it fixes itself.

@tdaines42 works now


Scanner

Codecov Report

Merging #2 (b850500) into main (39d16d8) will increase coverage by 81.60%.
The diff coverage is 89.24%.

@@            Coverage Diff             @@
##            main       #2       +/-   ##
==========================================
+ Coverage   1.88%   83.49%   +81.60%
==========================================
  Files          3        3
  Lines         53      418      +365
  Branches       6       41       +35
==========================================
+ Hits           1      349      +348
+ Misses        52       48        -4
- Partials       0       21       +21

Impacted Files
Coverage Δ

src/main.rs
2.85% <9.09%> (-0.09%)
:arrow_down:

src/lox.rs
12.50% <10.00%> (+12.50%)
:arrow_up:

src/scanner.rs
94.27% <94.01%> (+94.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d16d8...b850500. Read the comment docs.


Fix TODO in update_checker

See https://github.com/jspargo/dependabot-core/blob/add-cocoapods/cocoapods/lib/dependabot/cocoapods/update_checker.rb#L15
I don't 100% follow what this in reference to... I guess if we can't work it out, then we can delete the TODO as a last resort

Keep open please, stalebot


Missing Projects

Few projects missing
Not able to track down the "Drawing app", "Scientific Calculator", "Password Generator", "Mario", "URL Shortner"  etc app projects cards in the index file
As per mine project is considered, it had been merged properly ( Twice with the enhancement ) .. Files seem to be there in the public & assets folder. Cards are missing
Expected behavior
Projects cards have to be there. I am not able to see any mentioned projects card.
Kindly, take a look!
Event
Part of GSSOC

@TidbitsJS Please make the PR for the same !! Except that scientific calculator

Done with PR.
If you want & no one is assigned for the scientific calculator project, then I am happy to work on that.
Let me know @Vishal-raj-1

@TidbitsJS Please make the PR for the same !! Except that scientific calculator


Disabling entities uses a soon to be disabled method

When I use the GUI to disable a sensor generated by this integration I get this warning:
2021-12-04 22:12:37 WARNING (MainThread) [homeassistant.helpers.frame] Detected integration that uses str for entity registry disabled_by. This is deprecated and will stop working in Home Assistant 2022.3, it should be updated to use RegistryEntryDisabler instead. Please report issue for config using this method at homeassistant/components/config/entity_registry.py, line 127: entry = registry.async_update_entity(msg["entity_id"], **changes)

Apologies. This is a core issue. Not an issue with your integration.


Bug in pruning

The code only prunes with cutoff_top_n if the probability cutoff_prob is set with a value less than 1.0
https://github.com/parlance/ctcdecode/blob/0e3aef7b35200a14658fb762bebded93ee1288f9/ctcdecode/src/decoder_utils.cpp#L20

Also, I am not sure why we have this https://github.com/parlance/ctcdecode/blob/0e3aef7b35200a14658fb762bebded93ee1288f9/ctcdecode/src/decoder_utils.cpp#L29


Fix search & sorting

First of all, this fixes https://github.com/HangarMC/Hangar/issues/569
The error message in that issue was due to the sorting by the last updated date. To fix that, I put that funny calculation in the SELECT: ((EXTRACT(EPOCH FROM COALESCE(hp.last_updated, hp.created_at)) -<PHONE_NUMBER>) / 604800) *1 AS last_updated_double,"
And then ordered by last_updated_double. And now it works.
At the same time, this PR fixes the search functionality. It now searches if the project name contains the search query (case-insensitive). This is very basic and doesn't do the full-text search which you wanted to do, but at least we have something which works now.
The problem with full-text search currently is, that cockroachdb doesn't support it. See: https://go.crdb.dev/issue-v/7821/v21.2
Until they add support, we could extend on the basic name-search functionality and search the project description as well. Currently, the search query is a simple hp.name ILIKE '%queryhere%'.

ideally we have something that considers project name, project description and the key words and ranks that somehow

obviously not good yet about better than nothing


how to load model from the local directory?

I want to load the model from local directory, instead of downloading it to my C drive.

Here , you can refer for how to run it locally , https://rewa-insights.com/t/text-to-voice/217/3?u=rewa-evija

Here , you can refer for how to run it locally , https://rewa-insights.com/t/text-to-voice/217/3?u=rewa-evija

I can already run it locally. how can I load the models from the directory of audiocraft?


[10.1] ISPN-11172 Remap container uid/gid to fix permissions with mounted vo…

https://issues.redhat.com/browse/ISPN-11172
Backport of https://github.com/infinispan/infinispan/pull/7863

I missed this PR and I cherry picked the commit :)

But you have forgot to push it


Feature Request: Plural handling

Would it be possible to add features like in https://www.i18next.com/translation-function/plurals?

very handy feature! Would love to have this


Weird unaligned write in embedded Rust

I have written a Flash struct that implements the Read, Write and Read traits for the Raspberry Pico's flash memory. I am trying to format the volume using fatfs::format_volume with the following options:
let options = fatfs::FormatVolumeOptions::new()
    .bytes_per_sector(4096)
    .bytes_per_cluster(4096);

and after a while, my write function returns an error that "The cursor is not aligned to SECTOR_SIZE" (that error type is mine). Furthermore, it seems like this specific error occurs after the library zeroes a bunch of memory at the beginning of the flash, when it tries to write the buffer [255, 255] to the address 4097, just 1 byte off from the start of the 2nd sector.
Additional info

I am not doing any kind of buffering, everything is flushed immediately
I am using C bindings to the RP2040 ROM functions described in section <IP_ADDRESS>.3, page 136 of the RP2040 datasheet
I have enabled the alloc feature, but that doesn't seem to change the program's behaviour
Another issue I have found is that the size of the buffer data to write isn't a multiple of SECTOR_SIZE. Is this intended behavior?

Code
use alloc::format;
use core::{cmp, slice};

// custom error types
use crate::error;
use error::{Error, ErrorKind, FlashErrorKind};

use fatfs::{self, SeekFrom};
// ROM functions
use rp_pico::hal::rom_data::{
    connect_internal_flash, flash_enter_cmd_xip, flash_exit_xip, flash_flush_cache,
    flash_range_erase, flash_range_program,
};

// SECTOR_SIZE is already a multiple of PAGE_SIZE (256), so we use that instead
pub const SECTOR_SIZE: usize = 4096;
pub const SECTOR_ERASE: u8 = 0x20;
pub const XIP_BASE: usize = 0x1000_0000;

pub struct Flash<'a> {
    pub slice: &'a [u8],
    pub offset: usize,
}

impl<'a> Flash<'a> {
    /// Returns `None` if offset isn't aligned to a sector
    pub fn new(offset: usize, len: usize) -> Option<Self> {
        let slice = unsafe { slice::from_raw_parts((XIP_BASE + offset) as *const u8, len) };
        let flash = Flash { slice, offset: 0 };

        if flash.is_aligned()
            && slice.len() % SECTOR_SIZE == 0
            && slice.as_ptr() as usize >= XIP_BASE
        {
            Some(flash)
        } else {
            None
        }
    }

    pub fn len(&self) -> usize {
        self.slice.len()
    }

    fn is_aligned(&self) -> bool {
        // Below we are not using that pointer to read/write anything, so this is actually safe
        unsafe { self.slice.as_ptr().add(self.offset) }.align_offset(SECTOR_SIZE) == 0
    }

    fn offset_from_xip_base(&self) -> usize {
        self.slice.as_ptr() as usize - XIP_BASE
    }
}

/// Copy the contents of `src` to `dest` and return how many bytes were read
///
/// Note: unlike the `copy_from_slice` function, this doesn't panic;
/// instead, this will cap at the when an end-of-slice is reached for either `src` or `dst`
fn slice_copy<T>(src: &[T], dest: &mut [T]) -> usize
where
    T: Copy,
{
    let src_len = src.len();
    let dest_len = dest.len();
    let size_cap = cmp::min(src_len, dest_len);

    // Perform copy operation
    dest[..size_cap].copy_from_slice(&src[..size_cap]);

    return size_cap;
}

#[derive(Debug)]
pub struct IoError(Error);

impl From<Error> for IoError {
    fn from(value: Error) -> Self {
        Self(value)
    }
}

impl fatfs::IoBase for Flash<'_> {
    type Error = IoError;
}

impl fatfs::IoError for IoError {
    fn is_interrupted(&self) -> bool {
        self.0.kind() == ErrorKind::Interrupted
    }

    fn new_unexpected_eof_error() -> Self {
        Self(Error::new(
            ErrorKind::UnexpectedEof,
            "Encountered unexpected EOF while doing FS operations",
        ))
    }

    fn new_write_zero_error() -> Self {
        Self(Error::new(
            ErrorKind::WriteZero,
            "A FS operation could not be completed because a call to .write() returned Ok(0)",
        ))
    }
}

impl fatfs::Read for Flash<'_> {
    // `io::Result` always returns `Ok`, so you can safely unwrap this
    fn read(&mut self, buf: &mut [u8]) -> Result<usize, Self::Error> {
        defmt::debug!("Read {} bytes from offset {}", buf.len(), self.offset);
        if self.offset >= self.slice.len() {
            unreachable!()
        } else {
            let bytes_read = slice_copy(&self.slice[self.offset..], buf);
            self.offset += bytes_read;
            Ok(bytes_read)
        }
    }
}

impl fatfs::Seek for Flash<'_> {
    fn seek(&mut self, pos: fatfs::SeekFrom) -> Result<u64, Self::Error> {
        defmt::debug!(
            "current pos: {}, seekfrom: {:?}",
            self.offset,
            defmt::Debug2Format(&pos)
        );
        match pos {
            SeekFrom::Start(offset) => {
                let offset: usize = offset.try_into().map_err(|_err| {
                    Error::new(
                        ErrorKind::TryFromIntError,
                        "New offset must fit into a usize",
                    )
                })?;

                if offset < self.slice.len() {
                    self.offset = offset;
                } else {
                    return Err(Error::new(
                        ErrorKind::FlashRelated(FlashErrorKind::MovedPast),
                        "Moved past end of managed flash",
                    )
                    .into());
                }
            }
            SeekFrom::Current(offset) => {
                let offset: i64 =
                    offset
                        .checked_add_unsigned(self.offset as u64)
                        .ok_or(Error::new(
                            ErrorKind::CheckedOverflow,
                            "Numeric overflow between addition of i64 and usize",
                        ))?;

                match u64::try_from(offset) {
                    Ok(offset) => self.offset = self.seek(SeekFrom::Start(offset))? as usize,
                    Err(_err) => {
                        return Err(Error::new(
                            ErrorKind::FlashRelated(FlashErrorKind::MovedBefore),
                            "Moved before start of managed flash",
                        )
                        .into())
                    }
                };
            }
            SeekFrom::End(offset) => {
                let offset: i64 =
                    offset
                        .checked_add_unsigned(self.slice.len() as u64)
                        .ok_or(Error::new(
                            ErrorKind::CheckedOverflow,
                            "Numeric overflow between addition of i64 and usize",
                        ))?
                        - 1;

                match u64::try_from(offset) {
                    Ok(offset) => self.offset = self.seek(SeekFrom::Start(offset))? as usize,
                    Err(_err) => {
                        return Err(Error::new(
                            ErrorKind::FlashRelated(FlashErrorKind::MovedBefore),
                            "Moved before start of managed flash",
                        )
                        .into())
                    }
                };
            }
        }

        defmt::debug!("new pos: {}", self.offset);

        Ok(self.offset as u64)
    }
}

impl fatfs::Write for Flash<'_> {
    // Please note that if writing the entire buffer would exceed the limits
    // of the managed flash space, everything UP TO that point will be written
    #[inline(never)]
    #[link_section = ".data.ram_func"]
    fn write(&mut self, buf: &[u8]) -> Result<usize, Self::Error> {
        defmt::debug!("{}: {:?}", self.offset, buf);
        if !self.is_aligned() {
            Err(Error::new(
                ErrorKind::FlashRelated(FlashErrorKind::Unaligned),
                "The cursor is not aligned to SECTOR_SIZE",
            )
            .into())
        }
        // the issue with the buf len not being a multiple of SECTOR_SIZE
        /*else if buf.len() % SECTOR_SIZE != 0 {
            Err(Error::new(
                ErrorKind::FlashRelated(FlashErrorKind::InvalidBufferSize),
                format!(
                    "The length of the input buffer ({}) isn't a multiple of SECTOR SIZE ({})",
                    buf.len(),
                    SECTOR_SIZE
                ),
            )
            .into())
        } */
        else {
            // Prevent flash memory overflow by taking a slice of the input buffer
            let init_buf_slice = &buf[..cmp::min(self.slice.len() - self.offset, buf.len())];

            // the issue with the buf len not being a multiple of SECTOR_SIZE
            // Zero out remaining bytes so that our buffer is divisible by SECTOR_SIZE
            let bytes_needed =
                init_buf_slice.len().next_multiple_of(SECTOR_SIZE) - init_buf_slice.len();
            let mut filler_vec: heapless::Vec<u8, SECTOR_SIZE> = heapless::Vec::new();
            filler_vec.resize(bytes_needed, 0).unwrap();

            let buf_vec = [init_buf_slice, filler_vec.as_slice()].concat();
            let buf_slice = buf_vec.as_slice();

            // Variation of what is described in https://github.com/rp-rs/rp-hal/issues/257
            unsafe {
                cortex_m::interrupt::free(|_cs| {
                    connect_internal_flash();
                    flash_exit_xip();

                    // Erase the data in that region
                    flash_range_erase(
                        self.offset_from_xip_base() as u32,
                        buf_slice.len(),
                        SECTOR_SIZE as u32,
                        0xD8,
                    );

                    // Reprogram the data in that region
                    flash_range_program(
                        self.offset_from_xip_base() as u32,
                        buf_slice.as_ptr(),
                        buf_slice.len(),
                    );

                    flash_flush_cache();
                    flash_enter_cmd_xip();
                });
            }

            self.offset += buf_slice.len();
            Ok(buf.len())
        }
    }

    // Anything written to the flash is flushed immediately
    fn flush(&mut self) -> Result<(), Self::Error> {
        Ok(())
    }
}

This is intended behavior. Implementation assumes IO has some kind of buffering and allows reading/writing arbitrary number of bytes at unaligned addresses.
In your case it probably makes sense to add a buffer that has size of exactly one sector to your Flash struct and use it in Read and Write trait implementations. You can take https://github.com/rafalh/rust-fscommon/blob/master/src/buf_stream.rs as example although it doesn't seem to care about address alignment.

This is intended behavior.

In that case, shouldn't this behavior be documented somewhere in the docs, especially considering that this is the only FATFS library in crates.io?


Error on S-interpolator usage for assert, assume and printf

This is to be backported to 3.5.x as a warning instead of an error
Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[ ] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

updated feature/API

API Impact

Current assert, assume and printf APIs allow the Scala s-interpolator for formatting messages. This often leads to user errors where the Scala object is printed instead of the Chisel object, which leads to the messages being generally unhelpful.
After this update, using s-interpolators will throw an error about deprecation.
Backend Code Generation Impact

N/A
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Using Scala s-interpolators now throws an error recommending a shift to the cf interpolator.
Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you do one of the following when ready to merge:

[ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
[ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

I think this requires some fixes to the printable docs? Or can we say something there to show people the warning/error they will get if they try to printf(s"...")?

This is not marked with Milestone 3.5.x because we do not want it to be backported and automerged, instead after merging we will do a manual backport and change the behavior to be just a warning.


addition to displayAnim for a 'style' segment, where you can just input CSS for that bit of text to use.

fun fun

he


Fix select in *ngFor

It fixes https://github.com/mseemann/angular2-mdl-ext/issues/881

Coverage increased (+0.005%) to 97.556% when pulling ea8b919c9ff6d919b4ece89debd4807f24fa6a2c on fix-select-in-ngfor into d3647a550904bc80613ec71144f1a0b5e0f16b90 on master.

published as @angular-mdl/select:0.11.2


signatures: accept unicode emoji

signatures--accept-unicode-emoji

Turns out this was a change needed in the config file. Though we should probably change the example one too.

Do you want to open that pull?

Opened.


Facebook and twitter window open twice in android

I have used shareViaTwitter and shareViaFacebook for sharing but when i click on button facebook and twitter window open twice in android.
My Code is below :
window.plugins.socialsharing.shareViaTwitter('title', null /* img */, null, function(msg) {console.log('ok: ' + msg)}, function(msg) {console.log('error: ' + msg)});
Thanks

Experiencing a very similar issue with our project, was there a resolution or work around found?

@patt0 please share your code with me at eddyverbruggen at gmail and I'll take a look.

Have this issue to. When click on Share button window opens twice.
Button:

      <button class="button" style="border:none;" ng-click="sharePost(post.url)">
        <i class="icon ion-android-share-alt"></i>
      </button>

Controller:
 $scope.sharePost = function( link ){     window.plugins.socialsharing.share('Check this post here: ', null, null, link);   }


[Enhancement]feat: Add custom parameters when broker load starts

Fixes #28797
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[x] 2.5
[ ] 2.4
[x] 2.3

@taoshengyijiua 大佬，我是您同程旅行的同事方李骥，目前账号关联不上您是谁，还请您看到之后，企业微信上联系我，谢谢


[VPU] Missing firmware – when cross compiling to 32 bit (x86)

I have been chasing this problem for days but I'm completely lost, any pointers will be highly  appreciated - Please
We use buildroot to build a software package for our embedded platform, that run on a 32 bit Intel board.
We have earlier successfully cross-compiled ncsdk for the myriad 1 stick, but now we need to use the Myriad 2 and thus to compile the dldt.
I’m using the recipe https://github.com/opencv/dldt/tree/2019/inference-engine#build-on-linux-systems
But cmake fail with the message
CMake Error at src/vpu/CMakeLists.txt:14 (message):
 [VPU] Missing firmware
even if the files are present in the correct locations,
they are visible, with -rwx------ permissions
We use

cmake 12.1
gcc 6.3.0

here is the buildroot .mk file that drives the build:
`
MOVIDIUS2API_VERSION = 2019
MOVIDIUS2API_SITE_MDETHOD=git
MOVIDIUS2API_SITE =  git://github.com/opencv/dldt.git
MOVIDIUS2API_GIT_SUBMODULES=YES
MOVIDIUS2API_LICENSE = Apache-2.0
MOVIDIUS2API_LICENSE_FILES = LICENSE
MOVIDIUS2API_INSTALL_TARGET = YES
MOVIDIUS2API_INSTALL_STAGING = YES
MOVIDIUS2API_SUBDIR=inference-engine
MOVIDIUS2API_CONF_OPTS =  -DENABLE_GNA=OFF -DENABLE_PROFILING_ITT=OFF -DENABLE_SAMPLES=OFF -DENABLE_SAMPLES_CORE=OFF -DENABLE_CPPLINT=OFF -DCMAKE_COLOR_MAKEFILE=ON -DENABLE_SSE42=OFF -DTHREADING=SEQ
MOVIDIUS2API_DPENDENCIES += libusb pugixml
$(eval $(cmake-package))
`
I'm going crazy -- I tried all kind of debug, but find_file fails every time.
and complete build output:
output  from clean build.txt

SOLVED !!
It turns out that buildroot construct and use a toolchainfile.cmake aka  CMAKE_TOOLCHAIN_FILE
that isuue a set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
I now patch the find_file command with CMAKE_FIND_ROOT_PATH_BOTH, and voilà !
it find the firmware files


Remove '?' (optional properties) in tsgeneration to match apollo-codegen

I think the apollo client-side codegen off queries is correct, in that the typescript optional (?) annotation on keys should not be used for generated schema code.
Most GQL resolver frameworks require keys to be defined and set to null, not undefined (as the ? allows).
This is now the only thing preventing typescript types from exactly matching between my backend and front-end codegen, which would enable some code-sharing even as they use different code generators.

@gaberudy thank you for creating this PR!
Few steps before we can continue with it:

Have you seen this discussion? https://github.com/dotansimha/graphql-code-generator/issues/155
Can you please check the tests and CI?

@dotansimha I would take a crack at fixing the tests if you think you would accept this PR.
It looks like #155 was about making the type of the properties be nullable (adding  | null), which is great and needed, but I'm arguing the better default would be to make the properties not optional (allowed to be undefined, assigned to undefined).
It may be a change some people like myself appreciate, others don't care, and some don't like. But it would match the spec of GQL better (IMHO) and the use case I am running into.

@gaberudy I think the best solution is to use the generator-specific config to decide if to use ? or not, and by default we should keep the current state.
how to set it: https://github.com/dotansimha/graphql-code-generator/tree/master/packages/graphql-codegen-cli#generator-specific-config
how to use it in the template: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/templates/typescript/src/template.handlebars#L2-L4

@gaberudy I implemented it in this PR: https://github.com/dotansimha/graphql-code-generator/pull/293
Thank you for your help and this PR! It's a great idea!!


Add rule of thumb disk space requirements

I'll add a more detailed version, the expected build times, to the detailed wiki guide version in a bit.

Source (in case that's useful): https://forums.freenas.org/index.php?threads/how-to-build-freenas-9-10.43374/page-3#post-340632


Jaccard loss

Another useful loss function for semantic segmentation tasks. It was available in keras-contrib, losses/jaccard.py

@qlzh727 It would be great to have this loss function from core keras. But as it's mostly cv-related loss function, isn't it fitter to have it from keras_cv; if cv-related stuff moves to keras_cv from keras in the future?  Also, if we have Dice loss from keras_cv and Jaccard loss from keras, it might be a confusing UX, IM0.

I will check with API owner for this question, and see where we want to place this loss. Will update later this week.

Just for the record: https://github.com/keras-team/keras-contrib/pull/533


[aarch64] update the Primtive cache logic for ACL fixed format kernels

oneDNN3.3 enables ACL fixed format kernel support on aarch64 which don't need the workaround for the weights handling during the caching. This PR is to update the logic to remove weights hash checking for the primitive caching.

Hi @yanbing-j, this is another PR required for PyTorch 2.2. same as https://github.com/intel/ideep/pull/257, resubmitting on the correct branch. Could you please merge this before the ideep branch is updated in PyTorch. Thank you!

Hi @snadampal , thanks for the commit. If #257 is a replicated one, please close that PR.

Hi @jgong5, could you please help review this PR?

Hi @yanbing-j , the PR is approved, can you please merge it before  the ideep submodule is updated for PyTorch2.2. Thank you!


Chore/improve GitHub workflows

Hi,
Here are small improvement for your the github workflow you may want.
The idea is to:

Run the workflows only for the branch master (and pull requests against that branch)
Run the workflows for all new pushed tags. (will run for the tagged commit, even if you push more commits alltogether)
Run only the check tasks for changes made in implementation/scipamato

You can see there results here:

workflow status and log: https://github.com/jcornaz/scipamato/actions
sonar report: https://sonarcloud.io/dashboard?id=jcornaz_scipamato

@jcornaz sounds very useful. Many thanks!


Work around old-style constructors in PGO training case

class.php of the pgo01org training case still uses PHP 4 style
constructors, which trigger deprecation notices and as such may
negatively affect the optimization.  Until this will be fixed upstream,
we're employing the workaround to modify the file during the PGO
initialization step.

Merged, thanks! Btw. no need to mention pr in the code, instead you could put closes #53 into the commit msg (see github docs).
Thanks.

Ups, closes #51 i mean, the issue ticket.
Thanks.


Watching does not seem to work on MacOS Sierra and Go1.7RC6

Not directly related to #2338, as there is no panic.
Watching for changes in /Users/georg/projects/foo/{content,static,themes}

Now when I change something in foo/themes/own/layouts/partials/nav.html, nothing happens.
I tested it with fsnotify directly and it worked, at least non-recursively.
Is the described change even  supposed to trigger rebuild?

Ok, the issue was related to the go version. Installing hugo from source on go1.7RC6 solved the problem.


Document how NOTICE.txt are assembled for every artifact

Is your feature request related to a problem? Please describe.
We are legally required (per Apache license) to (re)publish certain third-party licenses and we do so in NOTICE.txt for OpenSearch and OpenSearch dashboards. We need documentation on how each repo generates such a file, then how these are concatenated during the packaging process so we can ensure compliance, and answer questions such as whether that includes transitive dependencies.
Describe the solution you'd like
Markdown documentation of how NOTICE(s) are generated linked together with a top-level in this repository explaining how the assembled artifact gets its NOTICE. Some of it may need to live in OpenSearch, OpenSearch Dashboards, and plugin repos.
Additional context
I recently couldn't answer the question of how we generate these files.

https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/src/main/groovy/org/opensearch/gradle/NoticeTask.groovy  - this is the logic that is used in gradle project to build the notice file.

All OpenSearch projects need to product NOTICE.txt this should be done in a uniform way and it should be generated correctly and placed into the distribution

[Triage] @dblock @CEHENKLE Is this something that you guys can take over since NoticeTask.groovy is a part of the opensearch repo?
Thanks!


MQTT-over-WebSockets needs to explain how to set up the WS connection

Just like the document explains how to set up a raw MQTT connection when not using one of the Azure SDKs, it also needs to explain how to set up the MQTT-over-WebSockets connection when not using the SDKs. Specifically these two pieces of information are missing:

The path of the URL of the request must be /$iothub/websocket.

The request must contain the sec-websocket-protocol header with value mqtt

Thus an example handshake request would look like:
GET /$iothub/websocket HTTP/1.1
Host: foo.azure-devices.net
<other standard handshake headers>
sec-websocket-protocol: mqtt

Not doing both of these things will cause the server to reject the connection with HTTP 400.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bcf2a86a-1de0-2786-db87-58279ceffb22
Version Independent ID: 7e43624f-a87d-1c4d-94e6-e38c1d42686f
Content: Understand Azure IoT Hub MQTT support
Content Source: articles/iot-hub/iot-hub-mqtt-support.md
Service: iot-hub
GitHub Login: @rezasherafat
Microsoft Alias: rezas

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@arsing, sure, I'll add this in future revisions of this doc. In the meantime, if you have working samples to share feel free to send me here or via email (rezas).

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

In case someone stumbles on this - you need to use /$iothub/websocket?iothub-no-client-cert=true - otherwise the connection gets dropped.


True for later Feature updates?

Is this information true for later Feature Updates? Such as 1709, 1803, etc...?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c91ae55-29b0-a5e1-b715-a72ac4270050
Version Independent ID: a102db60-b94c-573a-6ba9-9970d9ac5b44
Content: Change the TPM owner password (Windows 10)
Content Source: windows/security/information-protection/tpm/change-the-tpm-owner-password.md
Product: w10
GitHub Login: @andreabichsel
Microsoft Alias: v-anbic

No, just for the versions mentioned. Thank you!


Remove gce-scalability from blockers list

cc @eparis @lavalamp

Why? Are we turning this job down?

@lavalamp - I'm also not 100% convinced. But the rationale behind this is that we have kubemark500 that is blocking.

If we're confident in kubemark 500, then maybe we should also make
scalability a once-per-day thing, since it's expensive?
On Wed, Jul 13, 2016 at 12:12 PM, Wojciech Tyczynski <
<EMAIL_ADDRESS>wrote:

@lavalamp https://github.com/lavalamp - I'm also not 100% convinced.
But the rationale behind this is that we have kubemark500 that is blocking.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/contrib/pull/1360#issuecomment-232457016,
or mute the thread
https://github.com/notifications/unsubscribe/AAnglgVhTphyQFIKGZAwkGDDsW7Gv2lIks5qVTiegaJpZM4JLK6i
.

We'll be running it twice daily, but we don't want to block on that.

OK, so you're running it less often. LGTM


Zod continues to throw errors while using async refinements with react hook form when zod resolver mode is set to async

The title pretty much sums it up but, Zod throws errors when using async refinements via react hook form and Zod resolver even when you set mode to 'async'. This shouldn't be the case as it makes no sense. Refinements regardless of being async or not should not result in Zod throwing an error and instead should result in a validation error similar to any other function in Zod (e.g. min()).
I don't think this is an issue with Zod (though maybe?) but, it absolutely is a failure of the docs to not cover this specific situation given that Zod is so commonly used with RHF.

Please send a full reproducible code example.


yabai: 7.1.2 -> 7.1.3

Description of changes
https://github.com/koekeishiya/yabai/blob/master/CHANGELOG.md#713---2024-09-17

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


pm: Add power management states definition

Add definition power management states, these states were inspired by
ACPI specification. This commit is part of the following pr
https://github.com/zephyrproject-rtos/zephyr/pull/27315 from Wentong.
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

This is part of #27315
There is another pending commit replacing the usage of old states with the ones introduced here, but I'm holding it to avoid a huge clash with #29410

In #24228 we were discussing the names; are we going to continue to use Zephyr-specific terminology? I'd hoped we could come closer to using ACPI terminology for system and device power.

I thought that this was the outcome of that discussion. I saw your comment about having 1:1 with ACPI, but didn't see any agreement around it. Do we have this granularity need ? I see a trade-off here between clarity and granularity, also how many embedded platforms follow ACPI name convention ? TI CC1352 does not, at least.

In #24228 we were discussing the names; are we going to continue to use Zephyr-specific terminology? I'd hoped we could come closer to using ACPI terminology for system and device power.

I thought that this was the outcome of that discussion. I saw your comment about having 1:1 with ACPI, but didn't see any agreement around it. Do we have this granularity need ? I see a trade-off here between clarity and granularity, also how many embedded platforms follow ACPI name convention ? TI CC1352 does not, at least.

btw, I should have mentioned, but these are only the system states, I'll send later devices power states.

I thought that this was the outcome of that discussion. I saw your comment about having 1:1 with ACPI, but didn't see any agreement around it.

I didn't see anybody object.  The only documentation I know of for the architecture is @nashif's  powerpoint presentation which uses the ACPI S and D states.

I see a trade-off here between clarity and granularity, also how many embedded platforms follow ACPI name convention ?

I do think it makes sense to define Zephyr's behavior in terms of a well-defined and understood architecture such as ACPI.  Even if the names aren't used for some reason, the description of the Zephyr-only terms should at least have some relation to existing standards,

I thought that this was the outcome of that discussion. I saw your comment about having 1:1 with ACPI, but didn't see any agreement around it.

I didn't see anybody object. The only documentation I know of for the architecture is @nashif's powerpoint presentation which uses the ACPI S and D states.

I see a trade-off here between clarity and granularity, also how many embedded platforms follow ACPI name convention ?

I do think it makes sense to define Zephyr's behavior in terms of a well-defined and understood architecture such as ACPI. Even if the names aren't used for some reason, the description of the Zephyr-only terms should at least have some relation to existing standards,

Lets make it clear, you are proposing we to use ACPI states ? G0-3, S1-6 ... ? I don't have a strong argument against it, just that this seems more desktop/laptop orientated and even linux does not fully follow it, my main concern is that this granularity is not necessary for 99% of our targets, but I see the value of following a standard and having the power to cover that 1%
At this point, I want to have a consensus around it and move forward. Are you proposing 1:1 with ACPI ?

Lets make it clear, you are proposing we to use ACPI states ? G0-3, S1-6 ... ?

I'm proposing we document what we're going to do at the architecture level, then ensure the code matches it.  AFAIK that documentation is the power point presentation, which says that Zephyr "platform and device specific PM states needs to be mapped to [ACPI] S and D states respectively" (at least in the version I have).  Which suggests we should be using those states as the platform/device agnostic states.
We really need an active architectural lead for this effort.  We're not going to get very far if every time we pick this up we change where we're going.

I really can't keep track of everywhere things are being discussed, and what state they're being left in.
From what I can tell #24228 didn't reach a conclusion.  I don't see that #27315 did either; as I recall it simply captured the original proposal using Zephyr names, and started outlining solutions using them.  Some discussion in #27315 was targeted at making the state descriptions consistent with ACPI.  The PowerPoint presentation also uses ACPI states, and I thought it was the most recent documented and maintained architectural plan for Zephyr.  So yes, I was surprised to find that we're back to using Zephyr-specific state names with no reference to existing well-understood architectures.
Beyond the names and definitions, why are these bit fields?  That makes it difficult to have a type that can only represent a single state.
This PR is updating Zephyr to record a snapshot of a fragment of a solution.  It can't be more than that because we don't have a plan that goes any deeper than some slides.  I don't think it's helping us make progress.

what terminology are you proposing here? Can you please be specific about the terminology you are asking for?

You are still not answering my question:
what terminology are you proposing here? Can you please be specific about the terminology you are asking for?
The states mentioned in the slides (S0... and D0...) actually correspond to what we have here (also see your comment: https://github.com/zephyrproject-rtos/zephyr/issues/24228#issuecomment-663584642), so please if you think some state should be named differently, be specific what you want to be changed.

Thank you.  Then what I want is text in the description of the states that records the correlation between the Zephyr names and the ACPI states.

Thank you. Then what I want is text in the description of the states that records the correlation between the Zephyr names and the ACPI states.

This can be added as a note per state I guess.


Skip duplicate data during copy from one catalog to another

Following up from comment on #735, this PR provides extremely rudimentary duplicate skipping during a tiled.client.sync.copy.  I think it makes sense to put this behavior behind a flag skip_duplicates and leave it False by default.  Duplicate handling is a little tricky for performance; I think the scope of .copy() is pretty clear that it doesn't update nodes in the destination catalog if the source has changed (though this, of course, might eventually be desirable behavior).
Checklist

[ ] Add a Changelog entry
[ ] Add the ticket number which this PR closes to the comment section

Just one suggestion to lay track for future extensions. Could we make the parameter on_conflict and make the value a str or StrEnum with values skip and error (default)? In the future we might add warn, overwrite, etc. More discussion is needed, and this can be put off for a future PR, but if we choose an enum instead of a Boolean flag we leave space for extensibility.


make nebari API private

Implements 4. of nebari-dev/governance#37 in three steps:

62379f4449c12473fa5bf04faf92b6f2710e2370: Introduce a src/nebari layout. Right now we have the package directly in our repository root. Since we will ultimately have a nebari as well as a _nebari package, it is useful to tuck them together in one folder. This is done by pytest, which we are following with this API change, and many other Python projects as well.
be85b66378c9036a24eb4425361bc7956c3c6796: make nebari package private by renaming it to _nebari.
N/A: reintroduce a public nebari package that does nothing but expose the CLI and a __version__ attribute.

I'll send one commit per step outlined above to make it easier to review. Since the diff will get quite large, I advise reviewers to go commit by commit.
This PR will conflict with basically every other open PR and every patch that was merged into develop after I have started. To keep disruption to a minimum, I plan to only rebase once after this PR has been approved. For all other open PRs, I'm available for helping to migrate them. Tag me there if you need help.

Same deal as in https://github.com/nebari-dev/nebari/pull/1778#issuecomment-1560840288 with be85b66378c9036a24eb4425361bc7956c3c6796.


[BI-1363] Program Configuration and Share Ontologies

Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1363

Added a Program Configuration page
Create a Shared Ontology component
Handled errors coming back from the shared ontology endpoints.

Dependencies
biapi: BI-1363
Testing
See biapi PR for testing details, https://github.com/Breeding-Insight/bi-api/pull/166.
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have tested my code and ensured it meets the acceptance criteria of the story
[ ] I have create/modified unit tests to cover this change
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to documentation
[ ] I have run TAF: <link to TAF run>

passed testing


Cannot close Modal and Scene at once from inside of the Modal

I'm using react-native-router-flux : 3.40.1
Scenario and expected result.
I have a stacked scene and before pop this scene (using Actions.pop()),
I show a confirm Dialog using Modal from react-native-router-flux.
On OK press in the Dialog, I want to close Dialog (Modal) and pop the Scene at once.
Actual result
Actions.pop() dismisses the Dialog but not Scene.
My code structure
Same with Modal example in https://github.com/aksonov/react-native-router-flux/blob/master/docs/OTHER_INFO.md
I tried in the onPress() in the Dialog
// Call twice
Actions.pop();
Actions.pop();

// Pop with param
Actions.pop(2)

//Using setTimout()
setTimeout(Actions.pop, 10)
setTimeout(Actions.pop, 1000)

// Combine upper tries using async
async()=>{
setTimeout(Actions.pop, 10)
setTimeout(Actions.pop, 1000)
}

Am I doing right?

Sorry, v3 is not supported.

@aksonov How can we achieve this on v4?

@aksonov @luco did you ever find an answer to this?

I found workaround in v3.
Just calling setTimeout(Actions.pop)  works.
In my original post, I made some mistakes.
setTimeout(Action.pop, N) should works.


Return messages when not publish metrics while using metric_connectors in metrics middleware.

Ready for review.

:+1: when Travis is happy.

Landing before Travis to fix issue in production.


Update MD file on new branch 2017-19-08_12-11-33

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add proof of concept for T.Slog()

Addresses https://go.dev/issue/59928

Apologies. I meant to push this change to my fork.


Add intros to REST API pages

What article on docs.github.com is affected?

"Git database"
"Gitignore"
"Interactions"
"Issues"
"Licenses"

What part(s) of the article would you like to see updated?
Each of these articles needs an intro to help orient users to the content on the page and what each API can be used for. Intros should be one sentence long and define what the feature is.
For "Git database" and "Licenses," you can cut and paste the first sentences in the articles for the intros.
For "Gitignore," "Interactions," and "Issues" you will need to write new intros.
For more information about writing intros, see:

Information about writing intros in the GitHub docs content model
Information about the intro frontmatter property in the GitHub Docs content directory README

Additional information
This issue is for the Campus Experts + Docs program and not currently available for contributors outside the program to work on.

Would like to work on this. :)

@codewithdev Feel free to open a PR with the changes 👍


CSV / Excel Exports

Feature Description
A variety of sensible options and defaults to allow users to export data for use in a spreadsheet or another tool.

I have a basic CSV download function working from a query viewer, but trying to figure out the best place to put the download button.
A few questions will impact the decision on where to put it:

Is there a need for a "copy to clipboard" action on query results?

Would impact the "download to CSV" button position - if we'll be adding other buttons in the future, we may opt for more of a "toolbar" approach, where we're lining up buttons beside each other
Could be helpful for people who need to get data from Evidence into Google Sheets quickly
I'm unsure of size limitations for copying a table to the clipboard

Should our <DataTable/> component come with the same export options as the query viewer?

We may want the options available for the query results table and the <DataTable/> component to be the same (and to look the same)

Here is the general function behaviour:

And a few options on placement and messaging:

Looks very excellent. Nice.

Is there a need for a "copy to clipboard" action on query results?

Not something I would have used for large data sets, pulling into other tools etc. but I see your point re: excel/google docs. I think safe to treat that as another feature for consideration in the future. I think a "presentation table" (if you know what I mean), should support smooth copy/ paste for sure, but again I'd address it separately from this.

Should our <DataTable/> component come with the same export options as the query viewer?

I would vote yes, identical to this one.

And a few options on placement and messaging.

First one is basically perfect IMO. Exactly where I would expect it to be.
I would change the copy to just the word "Download" + the icon. Someone who doesn't know what a .csv is is going to download that file then open it in a spreadsheet without issue. Someone who does know what a .csv is is going to be expecting a csv. That also leaves open the option for multiple file formats in the future, presented in a little drop-down on-click on the download link.

I'm also interested in some sort of spreadsheet icon for the button

I think the download icon you have is perfect.
The only other idea I have on placement would be to:

Take the pagination (the "scrubber" + the indicator for what page you're on), squeeze them to be ~70% wide from the left, instead of 100%, and;
Push the download button up into the gap that would create above where it is in the first option.

Thanks for the feedback!
Button Placement
I like the bottom right placement and changing the label to just "Download". As we add more functions to the tables, we can move to the condensed/tooltip version (and possibly to more of a toolbar above the data as @archiewood suggested).
@mcrascal I like that idea for placement beside the pagination, but it would then look different than queries that don't have pagination. I suggest we go with bottom right for everything for now and reassess later
Copy to Clipboard
I think we should support copying to the clipboard in the query viewer. Waiting on adding that makes sense though...I assume we'll have a better idea of how it would be implemented after digging into the overall copy/paste features.
DataTable Download
The only thing that gives me pause on adding the function to the DataTable component is having the button visible to the reader when queries are hidden (it'll add noise to the page).
A couple of ideas for this - could do either or both:

Add a prop to DataTable to allow you to choose whether you want to expose the download button on a table
Have the button hidden by default, but show it when you hover over the table - example:

I like that idea for placement beside the pagination, but it would then look different than queries that don't have pagination.

adding the function to the DataTable component is having the button visible to the reader when queries are hidden (it'll add noise to the page).

Could we solve both of these concerns by placing the download button in the right hand corner of that "footer row" (the row that normally contains the slider) always, even if the slider isn't present to the left of it?

A couple of ideas for this - could do either or both

If you're not persuaded by the above, my gut is to go with the the hover, rather than the prop.
If we use a prop, I think most likely analysts are going to just go with the default behaviour, so if the default is to include it, we'll still get the visual clutter. If the default is no download, I think we'll generate a lot of follow up requests for our users. "Hey, can I get a spreadsheet of..."

Could we solve both of these concerns by placing the download button in the right hand corner of that "footer row" (the row that normally contains the slider) always, even if the slider isn't present to the left of it?

At the moment, the footer row only exists if the results are paginated, so if there's no pagination, the button would be hanging at the bottom:

I like that idea. Since we'll be updating the table design/features in the near future, I think we should tackle it as part of that. I'll put in the hover behaviour for now!

Closed by #269


refactor(gelato): break gelato-relay into separate crate

Don't need rust/gelato-relay in our rust monorepo
Want to make separate repo and publish to crates.io

https://github.com/nomad-xyz/gelato-sdk 🎉

Cool now we just gotta replace the imports in nomad-ethereum


fix: modified to use the latest terraform version

Description

Optional attributes are removed in order to support latest Terraform version i.e.
experiments = [module_variable_optional_attrs]
Terraform version is updated i.e.required_version = ">= 1.3.0"
Provider hashicorp/random is updated to version 3.4.3

Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[x] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[x] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Skip the VS Code directory from build

Purpose
Skip the VS Code directory from build.
Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Closing as this is not valid.


DecontX to deal with dataset with multiple batches

Please don't merge this. I will make another request.


Ouput in JSON

Summary
Some monitoring systems could use the output of tcping to be in JSON for easier parsing and processing.
Having a flag to change the output type would be nice. However, there are a lot to be changed since the current output is colorized.

@pouriyajamshidi
I think Ouput in JSON can be divided into three processes.

To be able to output both plane text and json text.
To be able to choose between plane text and json text output with a flag(Something similar to this has been done in the past).
Thinking about the contents of json text.

I'll take the first two.

@icemint0828  very clean and nice job.
the third point you mentioned, should be the exact same information as the planePrinter.

@pouriyajamshidi

the third point you mentioned, should be the exact same information as the planePrinter.

If you're not particular, this is fine.
Sorry but please work on it.

Partially addressed in https://github.com/pouriyajamshidi/tcping/commit/8296319fccd290d246c97c9a8dba52ef1b775283


Allow copy left plugins in the Marketplace

Summary
As discussed on Community there is no need to prohibit copy left plugins in the Marketplace.
Ticket Link
https://community.mattermost.com/private-core/pl/mk66rxs8etbffd8gc9bg9mfone

If we do get a plugin submission with a copy left license, we'll have a legal review at that point to confirm there are no concerns, correct?

Yes, we should do that.

The process owner i.e. me checks what license a submitted plugins has. Confirming that the license doesn't contain parts that Mattermost can't fulfill, is part of that check. 2/5 that a todo to do legal review shouldn't be part of this document as the audience are community members.


Mass not detected

Basic information

My operating system: windows 10
My mzmine version: 3.3.0

What happened
I have uploaded mzML files from raw data methods, import data.
after applying mass detection feature to both files, one file is not showing mass detection, hence further using chromatogram developer tool i am facing error.

Please describe what happened and how it differs from what you expected to happen.
Please include all parameter values for the mzmine modules you used.
Please upload screenshots of any errors and your log/mzmine.log file.
Please upload an mzmine project file that demonstrates the problem you are reporting.

Hi,
looks like you are running the centroid mass detector on profile data. You also use a spectrum type filter, set to centroid, during mass detection.
You can avoid this by using the latest version and the mzwizard.
kind regards,
Ansgar


Fix siteapi

Updates site api to expect/return site DTOs from clients.  Also added integration tests for SiteService and site controller round trip

AB#2


Sequence JSON return types are inconsistent across methods

I've noticed that the ledger sequence number isn't always returned as the same type in some of the Soroban-RPC methods. The getLatestLedger method returns the sequence as a uint32. Elsewhere when a ledger's sequence number is returned, it's stringified in the JSON response.
I could've sworn I noticed this same kind of thing with a protocolVersion field in two of the methods, but I'm not finding it now. I might've just been conflating some things in my head.

For some additional details and context, here are all the occurrences I can find of a ledger sequence number in the methods, and how it's returned

method name
return name
struct type
json type

getLatestLedger
sequence
uint32
n/a

getLedgerEntries
lastModifiedLedgerSeq
int64
string

getLedgerEntries
liveUntilLedgerSeq
*uint32
string

getLedgerEntries
latestLedger
int64
string

getEvents
ledger
int32
string

getTransaction
latestLedger
int64
string

getTransaction
oldestLedger
int64
string

 getTransaction
ledger
int64
string

sendTransaction
latestLedger
int64
string

simulateTransaction
latestLedger
int64
string

Seems like it's only returned as a number in the getLatestLedger method. I am curious if there's a significance or reasoning behind the use of int64 vs. uint32 vs. int32 vs. *uint32 in the structs, though? Maybe that's just how the data is retrieved from stellar core?

Ledger sequences are uint32 in the xdr, so I don't think we need to be communicating the sequence as a int64 or as a string. It looks like most of the fields need updating.
See:
https://github.com/stellar/stellar-xdr/blob/6a620d160aab22609c982d54578ff6a63bfcdc01/Stellar-ledger.x#L82

Looks like there's also some discrepancies between ledger close time representations. latestLedgerCloseTime, oldestLedgerCloseTime, and createdAt in the getTransaction method return a unix timestamp<PHONE_NUMBER>); same with latestLedgerCloseTime in the sendTransaction method. However, in the getEvents method, ledgerClosedAt is returned as an ISO-8601 timestamp (2023-11-14T02:42:23Z)

The change to getLatestLedger will be breaking for downstream systems, so we'll need to make sure to alert downstream SDK providers about this (possibly just a comment on the existing issues we sent out)


[WIP] Fix bug that causes objects in other namespaces to be set with the in correct owner if the owner's name in multiple namespaces is the same.

@staebler @dgoodwin This PR reverts the revert for the label ownership reconciliation and fixes the bug where it thinks that objects in other namespaces are the valid owner.

/test e2e


agent v3.39.1 incorrectly parses special Windows environment variables when running bash hooks

Is your feature request related to a problem? Please describe.
When running bash plugin hooks on windows, the new buildkite-agent env tool incorrectly parses some special environment variable names such as =C, which results in JSON entries such as the following:
.\buildkite-agent.exe env --pretty
{
  "": "C:=C:\\Users\\Administrator",
...
}

This later surfaces with very strange "environment variable changed" messages in our build logs such as the following:

Note that I am showing the buildkite-agent env invocation by setting set -x in our bash hook script, and to show that since we're using bash hooks, we don't use the typical powershell environment collector, which hasn't changed in v3.39.1.  To get these environment variables, you need to invoke cmd.exe at some point, which will automatically create the variables.  An easy reproducer is here, launched from within bash since it provides a convenient way of stripping out most variables:
$ env -i C:\\Windows\\System32\\cmd.exe /c ".\buildkite-agent.exe env --pretty"
{
  "": "C:=C:\\Users\\Administrator\\AppData\\Local\\Temp\\bk",
  "COMSPEC": "C:\\Windows\\System32\\cmd.exe",
  "MSYSTEM": "MINGW64",
  "PATH": "C:\\Program Files\\Git\\usr",
  "PATHEXT": ".COM;.EXE;.BAT;.CMD;.VBS;.JS;.WS;.MSC",
  "PROMPT": "$P$G",
  "SYSTEMROOT": "C:\\Windows",
  "WINDIR": "C:\\Windows"
}

I don't have much go experience, so I'm not certain what happens to the data after this point, but I can say that my updates to PATH do not get properly merged from this point on, despite the fact that there's no error in the build UI.
Describe the solution you'd like
I would like the special variables that start with = to be parsed correctly, or dropped.  These variables are not necessary for my use cases, but since they are technically legal (you can't set them via set in the cmd terminal, but you can set them via SetEnvironmentVariable, so a parent process could set these and then launch buildkite-agent start).  I personally am fine with them being dropped.
Describe alternatives you've considered
It is somewhat difficult to ensure that these variables are not set when I invoke buildkite-agent, so at the moment I am locking our infrastructure to using buildkite-agent v3.39.0.

hi there @staticfloat! thanks for your report. this is something that we've noticed in the process of using buildkite-agent env for bash and powershell hooks. I develop the agent on macOS, and imagine my surprise when i find out that windows has environment variables that start with = 🙃
rest assured that we'll come up with a solution here. dropping stuff that starts with an = is probably the easiest, but it's also possible that other people are relying on this, so i'll have a good think about this and ship a change when i get back to the PR linked above.


setDisabledDays  function error

When I disabled all the dates,it will never show and will broke down。

Can you elaborate a bit more?
Also: why would you disable all the days? If the user cannot select any days, wouldn't it be better to disable the button that shows the picker, rather than confuse the user with a dialog that is essentially useless?

Hi, i have this problem too. I dinamically disable some days and when i disable all the calendar don't show up and it freeze my app.
At your question: i have an app to booking, sometimes no days are available and i want a calendar with all grey days.


Add elasticsearch to default npm packages

Consider adding the elasticsearch npm package to the default list of supported packages. Since Bluemix has ES support, it would be nice.

@csantanapr FYI.
Closing as won't fix. Base packages are specific to deployment images.