Google-recommended way of structuring resource path is not supported (https://google.aip.dev/127)

Hi, I am trying to setup grpc-gateway for the service and doing it using Google AIP recommendations and provided linter.
So if you would take a look at https://google.aip.dev/127 -  the recommended way of using http annotations for more or less complicated APIs looks like that:
   post: "/v1/{parent=publishers/*}/books"
However protoc-gen-grpc-gateway-ts would not generate expected for that case /v1/${req["parent"]}/books, instead of that protoc-gen-grpc-gateway-ts would generate /v1/${req["parentpublishers"]}/books

There is also more complicated, but also commonly used case when (e.g. for update requests) nested field is used as a part of resource path, look at the Dialogflow proto for example: https://github.com/googleapis/googleapis/blob/master/google/cloud/dialogflow/cx/v3/intent.proto#L80
They have
    option (google.api.http) = {
      patch: "/v3/{intent.name=projects/*/locations/*/agents/*/intents/*}"
      body: "intent"
    };

👋  @Gugic  protoc-gen-grpc-gateway didn't cover this edge case yet unfortunately. However, contributions are welcome, ping me in a PR we can go from there.


JSON error with compiled version

When I compile the unaltered project to an .exe I get the following error

Error: Failed to parse JSON (-1,0)

Specifically: Unexpected character at position 0: "

		Line#
--->	231:Throw,Exception(failed to parse LSON(" r"," ErrorLevel")", -1,Format("Unexpected character at position {}: '{}'",(NumGet(pJson)-&_json)//2, Chr(NumGet(pJson), "short"))))

If I run the .AHK script then it works just fine.
I would really like to run this from an exe any help would be greatly appreciated.
p.s. love the robot icon!

I have done some digging and it seems like the result of the JSON.Dump is different when I run .AHK or .EXE. Here is the code
body := {}
body.model := MODEL_INSTRUCT_ID ;
body.input := CutText ;
body.instruction := UserInput ;
MsgBox, % "Body: " . JSON.Dump(body)

here are the 2 outputs
as .AHK
Body: {"input": " testing33", "instruction": "test inst", "model": "text-davinci-edit-001"}
as .EXE
Body: {"\u6E69\u7570t": "\u7420\u7365\u6974\u676E\u3333\u33343", "\u6E69\u7473\u7572\u7463\u6F69n": "\u6574\u7473\u6920\u736Et", "\u6F6D\u6564l": "\u6574\u7478\u642D\u7661\u6E69\u6963\u652D\u6964\u2D74\u30301: \"test inst\", \"model\": \"text-davinci-edit-001\"}"}

Thanks for reporting this issue @liamgwallace. Unfortunately, I wasn't able to reproduce this problem in my local machines (both .ahk and .exe versions are working fine here). Did you find some solution that solved it in your machine? If so, I'd appreciate hearing about it so I can also update this repository.


Rename Call Outs page metrics page

FY has requested that 'Call Outs' page is renamed to 'Take Part in Leeds 2023'. I would suggest this is actually 'Taking Part in Leeds 2023' - URL can stay the same.

I didn't discuss this at the sprint yesterday, but on reflection, ideally would like this to be complete ahead of the awards ceremony when lots of eyes might be on the page.
cc @taz-chiles @gilesdring


create a new nextjs template collection

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Like https://github.com/github/explore/pull/3631#issuecomment-1485842582, we'll be passing on this.

Thank Now I understand what my problem is.
I submitted my pull request again, removing the open-source project list.
Thank you for explaining it.
@kenyonj


Feature: @mux/mux-video-react should provide playback engine handle

Context
I'm trying to ensure that the user is always playing the latest of an ll-live stream, and to do so i'd like to seek to the hls live position as the playback core code does whenever the user pauses the stream, but this requires a handle to the playback engine, which the react bindings don't provide.
https://github.com/muxinc/elements/blob/main/packages/playback-core/src/autoplay.ts#L107
Feature Request
the react bindings should include a handle to the playback engine so that i can write code like
useEffect(() => {
  if (!playing) ref.current.currentTime = ref.current.playbackEngine.liveSyncPosition;
}, [])

@shrugs thanks for the feedback! there is a undocumented muxPlayer._hls property but keep in mind that it could be changed in the future with a new player version.
moving this issue to discussion (idea) because we might want to expose a getter for liveSyncPosition.


Which repository sbt-assembly 0.13.0 is stored in?

When I add sbt plugin addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.13.0"), i get following error:
com.eed3si9n#sbt-assembly;0.13.0: not found
Scala version 2.10.1
Is there specific repository with this plugin?

I

sbt plugin repo as usual:

https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/com.eed3si9n/sbt-assembly/scala_2.10/sbt_0.13/0.13.0/


the review menu is loading very slowly if we have many reviews

the review menu which is being initiated through this code in wagtail_hooks.py
class ReviewsMenuItem(MenuItem):
    def is_shown(self, request):
        return bool(Review.get_pages_with_reviews_for_user(request.user))

@hooks.register('register_admin_menu_item')
def register_images_menu_item():
    return ReviewsMenuItem(
        _('Reviews'), reverse('wagtail_review_admin:dashboard'),
        name='reviews', classnames='icon icon-tick', order=1000
    )

when checking the code for get_pages_with_reviews_for_user():
    @classmethod
    def get_pages_with_reviews_for_user(cls, user):
        """
        Return a queryset of pages which have reviews, for which the user has edit permission
        """
        user_perms = UserPagePermissionsProxy(user)
        reviewed_pages = (
            cls.objects
            .order_by('-created_at')
            .values_list('page_revision__page_id', 'created_at')
        )
        # Annotate datetime when a review was last created for this page
        last_review_requested_at = Case(
            *[
                When(pk=pk, then=Value(created_at))
                for pk, created_at in reviewed_pages
            ],
            output_field=models.DateTimeField(),
        )
        return (
            user_perms.editable_pages()
            .filter(pk__in=(page[0] for page in reviewed_pages))
            .annotate(last_review_requested_at=last_review_requested_at)
            .order_by('-last_review_requested_at')
        )

as you remark if we have many pages which is my case this loop is causing problems loading any page in the application with menu_items
to resolve this problem for the moment I was pushed to delete the hook through this command(because hiding the menu_item is not resolving the problem as the hook is always have been called):
sed -i "s/register_admin_menu_item//g" /usr/local/lib/python3.8/site-packages/wagtail_review/wagtail_hooks.py

my question is there any way to cancel showing the menu item with a more proper way?
thank you

@gasman
the description of this issue is not clear?
can you have a look if you do not mind
if you need more explanation I can add more details


How to force device.close()?

My device hangs when sending transfer sometimes.
I need to force devcie.close()
but i got Error: Can't close device with a pending request
OS: windows 10.
Node: 8.11.3

You can't close a device until all its transfers are completed or cancelled. .stopPoll() will cancel the transfers used in polling, but there is not currently a way to cancel transfers created by the .transfer() method. You could use a short timeout, though, and wait for them to time out.

WebUSB version doesn't have timeouts, how can this be worked around there? I've tried resetting the device but that disconnects other processes using other ports on the same device which is undesirable.

now that you mention it, WebUSB mandates that a .close() aborts all pending transfers? if we aren't doing that, maybe we should -- especially given that WebUSB gives no way of aborting transfers whatsoever

Yup, I ran into this incompatibility between browser and Node.js WebUSB variants as well. I believe this issue should be reopened.


Add lambda layers to releases

What are you trying to achieve?
AWS released Lambda Layers to facilitate sharing libraries and binaries across lambda functions.
With Lambda Layers, adopting Sharp.js into any AWS Lambda Node.js project will be a breeze.  Plus, there will be less setup, confusion, and errors surrounding compiling for the lambda execution environment.
I appreciate the existing installation instructions for AWS Lambda, and I think Lambda Layers could augment them.
What would you expect the API to look like?
With the releases, also publish the arn of the Lambda Layer for that particular version.  This step could be automated into the build process.  The docs for installation will need to be updated accordingly.
What alternatives have you considered?
Setting up my own Lambda Layer.  Will often be out of date and more error prone.
Building and packaging Sharp.js each time.  Build and upload speed will be slower and maintaining versions and consistency across multiple lambda functions will be difficult.
Is there a sample image that helps explain?
N/A.  Here are more links about lambda layers:

AWS News Announcement (2018)
AWS Documentation
An issue in this repo describing how to create a Lambda Layer specifically for Sharp.js #1702
Links to work done with Lambda Layers and Libvips in Ruby #1657
Documentation and build script for creating tarballs for the lambda execution environment

There are other tutorials for creating a Lambda Layer online.
Loving Sharp.js!  Just hoping to use it in more places 😄

Hello, I'm happy for the docs to link to public, third-party, well-maintained Lambda Layer(s) in the same way there are links to Docker images of a likewise nature.
I'm sure it won't be long before AWS provides a Lambda Layer Marketplace, at which point I might consider providing "official" layers at a small cost.
I regularly take on paid consulting should anyone wish me to create and maintain either private or public Lambda Layers custom to their needs - please feel free to send an email if this would be of interest to you or anyone else reading this.

@exonis any interest in publishing your third-party Lambda Layer?  🙏
I’m just a student so I can’t afford consulting services yet 😅
Otherwise, I’ll probably just use the prebuilt tarballs.

@jlarmstrongiv There are several solutions on github that generate a layer zip-file with sharp.
I also recently created one with the (currently) latest version - https://github.com/Umkus/lambda-layer-sharp.

AWS now provides the "Lambda Layer Marketplace" @lovell: https://serverlessrepo.aws.amazon.com/applications
E.g. imagemagick is on here at https://serverlessrepo.aws.amazon.com/applications/arn:aws:serverlessrepo:us-east-1:145266761615:applications~image-magick-lambda-layer
Using it in a serverless function with the serverless framework is as simple as:
functions:
  genThumbnailFromPNG:
    handler: dist/transform.thumbnailFromPNG
    layers:
      - !GetAtt IMLambdaLayer.Outputs.LayerVersion
    events:
      - s3:
          existing: true
          bucket: ${{env:AWS_S3_MEDIA_BUCKET_NAME}}
          event: s3:ObjectCreated:*
          rules:
            - prefix: public/
            - suffix: screenshot.png

resources:
  Transform: AWS::Serverless-2016-10-31
  Resources:
    IMLambdaLayer:
      Type: AWS::Serverless::Application
      Properties:
        Location:
          ApplicationId: arn:aws:serverlessrepo:us-east-1:145266761615:applications/image-magick-lambda-layer
          SemanticVersion: 1.0.0

Would be great if we can have the same plug-and-play solution with Sharp

I'm looking for a (zip) layer with gif support.
https://github.com/lovell/sharp/pull/2012#issuecomment-567397176
I couldn't do it myself I run into multiple issues with Docker. help appreciated ❤

please feel free to send an email if this would be of interest to you or anyone else reading this.

@lovell would you able to reply to my email? I sent it on Thursday. ❤

For anyone coming here looking for a lambda layer: I've created one that includes sharp with HEIC/HEIF support: https://github.com/zoellner/sharp-heic-lambda-layer
It can be added to any lambda function. See repo for details.

For anyone coming here looking for a lambda layer: I've created one that includes sharp with HEIC/HEIF support: https://github.com/zoellner/sharp-heic-lambda-layer
It can be added to any lambda function. See repo for details.

@zoellner this is awesome, any chance you can submit it to the AWS serverless application repository?

@zoellner this is awesome, any chance you can submit it to the AWS serverless application repository?

@tommedema added it to the repository and added some more details to the readme: https://serverlessrepo.aws.amazon.com/applications/us-east-1/776954778331/sharp-heic

@tommedema added it to the repository and added some more details to the readme: https://serverlessrepo.aws.amazon.com/applications/us-east-1/776954778331/sharp-heic

awesome, thanks!

awesome, thanks!

@zoellner It looks like you have published binary files (not source code) to AWS containing patent-encumbered HEVC logic. If so, please be aware this will expose you or your employer to potential royalty payments to patent pools/holders for every copy "downloaded". This might be construed under law to mean every time anyone deploys a Lambda function that uses it.

@zoellner It looks like you have published binary files (not source code) to AWS containing patent-encumbered HEVC logic. If so, please be aware this will expose you or your employer to potential royalty payments to patent pools/holders for every copy "downloaded". This might be construed under law to mean every time anyone deploys a Lambda function that uses it.

Thanks for the note. In order to stay on the safe side, I modified the repo to make it more suitable for self hosting and removed the application from the serverless application repository

Thanks for the note. In order to stay on the safe side, I modified the repo to make it more suitable for self hosting and removed the application from the serverless application repository

Would be great to get a non-hevc version of sharp published on the application repository. This makes it super easy to use sharp with lambda

Would be great to get a non-hevc version of sharp published on the application repository. This makes it super easy to use sharp with lambda

I automated the zip-building with Github Actions and Dependabot here: bubblydoo/lambda-layer-sharp.
Every time a new Sharp version is released, a new PR is automatically opened by Dependabot and a new zip is published to the releases page after merging.

I'll close this issue as, from the comments, it looks like there are now some good solutions to this. Many thanks to those who've created and maintain these layers.


Added ability to load GNUCash v. 3.0 xml

#777 Now it's possible to load xml from desktop version 3.0

Thanks @xzfantom

Oh man! I've just loaded gnucash (Linux desktop and mobile) again to try after many years hiatus.
This is a present from the gods.
Thank you very very much.
UPDATE: I was so excited that I was minded to reset SyncThing for the new setup now! Forgot about a little thing like the actual release of this update to 'production'! Doh!

@businessBoris you could join the beta program if you would like to get your hands on it fast. It will hit there first

Alright, no worries then. It'll come when it's fully baked.

Where do I find the find the actual xml on Android? I think it's hidden from me on Android 7.0
Happy to post to the wiki if that's a thing you want to do.

Gnucash Android don't use xml to store data, it uses internal SQLite database. Xml is used for import only.

Thank you.


Fix mistaken application of Assault move rules to War Engine units

On my first pass through the war engine rules, I assumed that the standard Assault move rules apply to war engines. See the latter sentence:
Movement of War Engine units in the Assault phase

In the Assault phase, you may choose not to move units in a War Engine detachment — but then you may not initiate close combats or firefights with them either. Otherwise, War Engine units are subject to the same movement restrictions in the Assault phase as other units.

This can't be correct, because the limitations on how war engines can turn make them unworkable. In effect, it seems that the Assault moves rules apply to Vehicle and Infantry units that are on Assault orders, but not to War Engine units which (at the moment) don't use orders anyway.
Fixes required, to remove this specific mistake and clarify the situation more generally.
@IJW-Wartrader Is there any aspect of the Assault move limitations that should apply to War Engine units?

@IJW-Wartrader Is there any aspect of the Assault move limitations that should apply to War Engine units?

All of them? ;-P
Setting snark aside, we've been applying them all in games for months now. Are there specific issues you're thinking of?

Off the top of my head:

You don't have to move WEs in the Assault phase. But if you do, do they have to move at least 5 cm (or into combat) where possible? Can you turn the unit on the spot (a 'move') without then also having to meet the 5 cm requirement?
If you do move the WE, do you have to move it towards an enemy unit? (Given the restrictions on turning, this was the bit that seemed most unworkable to us, depending on which way the WE was facing to start with.)
If you do move the WE, are you still restricted by the 'cannot move past' element? I'm not sure I could recall and describe the specific positions, but we had a situation where it seemed like a very odd contrivance indeed to say that this lumbering behemoth could not move past but due to the turning restrictions must instead either not move at all, or move in an oddly contrived way to at least attempt to move 'towards' an enemy or at the very least 'nearer to some enemies that it was at the start of its move'?

As you pointed out in our Facebook private message thread, there's a bit missing from the original about about "their own movement rules take priority". But I think this still leaves some room for interpretation.

I'm working from the basis that there is no text anywhere that says WEs get to ignore the standard restrictions on movement in the Assault phase.

1. You don't have to move WEs in the Assault phase. But if you do, do they have to move at least 5 cm (or into combat) where possible? Can you turn the unit on the spot (a 'move') without then also having to meet the 5 cm requirement?

Yes, they have to move 5 cm if possible. Turning on the spot won't stop you needing to move at least 5 cm unless you had to turn so far that you've got no movement left.

2. If you do move the WE, do you have to move it towards an enemy unit? (Given the restrictions on turning, this was the bit that seemed most unworkable to us, depending on which way the WE was facing to start with.)

As closely as possible, yes. Turn limitations will sometimes mean that it's not directly towards an enemy unit.

3. If you do move the WE, are you still restricted by the 'cannot move past' element? I'm not sure I could recall and describe the specific positions, but we had a situation where it seemed like a very odd contrivance indeed to say that this lumbering behemoth could not move past but due to the turning restrictions must instead either not move at all, or move in an oddly contrived way to at least attempt to move 'towards' an enemy or at the very least 'nearer to some enemies that it was at the start of its move'?

Yes, for the same reason that Bikes and Jetbikes etc. aren't allowed to freely move round behind the enemy to stop them being able to make a Retreat move. Don't forget there are WEs with 25 cm Speed, plus 5 cm for being on a road, plus 10 cm from a Fate Card.

It felt very weird to us, and overly contrived given the positions of our units. In our case it mean that my opponent couldn't take a course that seemed perfectly sensible given the terrain and all, but instead could only veer off towards my units on a course that wouldn't be sensible — or not move at all.
Okay, we're not doing a Double move in EA here — but still, it did seem very odd to us, to the point that my opponent felt that Assault move limitations are not meant for WEs and we abandoned it.

As closely as possible, yes. Turn limitations will sometimes mean that it's not directly towards an enemy unit.

Seems like that can't really happen — if you've got enough movement available to make a move that is 'not directly towards an enemy unit' then surely you'd be required to use that movement to turn more so that you do face towards an enemy unit...?

Yes, for the same reason that Bikes and Jetbikes etc. aren't allowed to freely move round behind the enemy to stop them being able to make a Retreat move. Don't forget there are WEs with 25 cm Speed, plus 5 cm for being on a road, plus 10 cm from a Fate Card.

I had forgotten XD But our situation wasn't about 'not moving past' in the sense of preventing an 'unfair' flanking move while close to the enemy — it was just about how weird this and the 'directly towards and enemy' requirement seemed to make many of our Assault phase moves with war engines.

Unfortunately, I can't remember the exact situations to describe them. If you say it works fine then we must've gotten some fundamental part wrong. Ah well, we'll see what happens the next time we get to play I suppose.

Okay, we're not doing a Double move in EA here — but still, it did seem very odd to us, to the point that my opponent felt that Assault move limitations are not meant for WEs and we abandoned it.

The problem is that the WE rules are written as exceptions to the standard rules, and no exception is mentioned (or even hinted at) for Assault moves.

As closely as possible, yes. Turn limitations will sometimes mean that it's not directly towards an enemy unit.

Seems like that can't really happen — if you've got enough movement available to make a move that is 'not directly towards an enemy unit' then surely you'd be required to use that movement to turn more so that you do face towards an enemy unit...?

Sure it can. If you choose to move, you have to move at least 5 cm. I can't see how turning on the spot fulfils that.

Anyway, I'll keep an eye out for odd situations!

The problem is that the WE rules are written as exceptions to the standard rules, and no exception is mentioned (or even hinted at) for Assault moves.

I'm just saying that we were so baffled by the situation that, in the absence of anything explicit either way, we felt compelled to drop the limitations where WEs were concerned out of sheer frustration. And then naturally the debate started as to whether in fact the limits for 'Assault moves' only apply to units that are actually on 'Assault orders', and therefore not to WEs which don't use orders. I didn't find that argument convincing myself, but that was where we were at by that point.
Meanwhile, the flyer rules made no sense to us either, given that the implications of the actual text (all in a line, all stop together) don't work well and don't match the example diagrams (seemingly, whatever formation the player likes). This didn't exactly boost our faith in GWs writing or lack thereof around exceptions either.

Sure it can. If you choose to move, you have to move at least 5 cm. I can't see how turning on the spot fulfils that.

If a turn does indeed counts as a move, then you can use up 5 cm by turning more than 45 degrees, to face the enemy more directly. So, if a free 45 degree turn wouldn't point the WE directly towards an enemy unit, then wouldn't you have to turn more towards the enemy and use the move that way rather than conveniently choose to move "not directly towards an enemy unit"...?
If a turn does not count as a move, then surely you'd still have to prioritise turning to face the enemy first, it's just that you'd still also have to actually move the model 5 cm.

Hmm, I think it's diagram time. This is a niche situation, although it's substantially more likely with Speed 10 cm WEs like Plague Towers or Leviathans.

A Speed 15 cm WE has one unit behind it and nothing in front.
If you use the free 45˚ turn and 'pay' for two more 45˚ turns (5 cm left), the remaining Speed can be used to move at least 5 cm, which will be moving as directly as possible towards the enemy unit. For me, this is the equivalent of having to detour around impassible terrain, but you're still taking the shortest route.
If you turn the WE to face directly at the enemy unit by making three and a bit turns, there is no movement left over to actually move.

And then naturally the debate started as to whether in fact the limits for 'Assault moves' only apply to units that are actually on 'Assault orders', and therefore not to WEs which don't use orders.

P.S. The rules for 'Assault moves' have to apply to all units. Because those rules include ignoring Snap-fire. Take away the 'Assault move' rules and it's impossible for WEs to reach base contact with enemy units if you're not using WE Orders... 😜

I'm probably not explaining myself very well, partly because I can't remember the exact situations. But in your diagrammatic example, you're saying that a turn does not count as a move, even though it consumes movement... in this case, your example reflects my second postulate:

If a turn does not count as a move, then surely you'd still have to prioritise turning to face the enemy first, it's just that you'd still also have to actually move the model 5 cm.

But the implications are different if a turn does count as a move, per my first postulate:

If a turn does indeed counts as a move, then you can use up 5 cm by turning more than 45 degrees, to face the enemy more directly. So, if a free 45 degree turn wouldn't point the WE directly towards an enemy unit, then wouldn't you have to turn more towards the enemy and use the move that way rather than conveniently choose to move "not directly towards an enemy unit"...?

So then your diagram should show an addition part of a turn to face the enemy directly, rather than a 5 cm move that is not directly towards the enemy.
So, which is it? Is a turn a 'move', or not?

P.S. The rules for 'Assault moves' have to apply to all units. Because those rules include ignoring Snap-fire. Take away the 'Assault move' rules and it's impossible for WEs to reach base contact with enemy units if you're not using WE Orders... 😜

I'm not saying that we thought no aspect of the Assault moves could apply (otherwise how would you charge, aside from anything else). I'm saying that we failed to reconcile the movement limitations on the assault moves with the limitations on war engine turning, and so we gave up on the former just so we could get the hell on with our game.


feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/

This would help prevent an ever-growing backlog for https://github.com/rust-lang/rust/issues/76268.

I think are more precise rule would work like this:

Warn if a PR modifies only library/ and src/test.

This actually should bring false-positive rate to almost zero I think.

Would this be part of x.py test tidy, or something else?

I don't think it should be part of tidy, because it could have false positives. tidy is a hard error, I want this to be more like submodules where it says 'only do this if you're sure'.

It would probably be better as a request against triagebot, where most new functionality should go. We are already receiving the webhook needed for this so mostly a matter of hooking up a check for the rule @matklad laid out above. AFAIK, no checks on the diff of PRs exists in triagebot today so we'll probably need to add some logic for that.

Opened https://github.com/rust-lang/triagebot/issues/831


9.6.15 RN

For KI: add links to all published fix versions

Merge dev in for previous KI fixes

Also merge https://github.com/mendix/docs/pull/5217/files


decouple BABE from session

Closes #3727

(handing over to @shawntabrizi and @HCastano to see it through to merge)

I managed to sync 200+ blocks with this, so it looks good!

+1

for me is working too (200+ blocks)


[Feature] Add affinity and toleration in ComputeTemplate

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently we can create a raycluster like
./kuberay cluster create --name kuberay-test --namespace ray --user chenk008 --head-image ray:1.9.2  --worker-image ray:1.9.2 --worker-compute-template kuberay-test --head-compute-template kuberay-test --worker-group-name test1

We need  some way to specify the pod' affinity and toleration.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

compute template is probably the best place to configure affinity and tolerations. Does it mean eventually we will have many kubernetes fields mapped to compute template? is there a better way to make it clean and flexible?


[Feature Request]: Honor typed handler lifetime

Is your request related to a problem you have?
Please let me know if this discussed somewhere 🙂
It appears that a consumer configuration similar to the following is not supported:
middlewareConfiguration
    .RetryForever((retryDefinition) =>
        retryDefinition
            .HandleAnyException()
            .WithTimeBetweenTriesPlan(
                TimeSpan.FromSeconds(10)
                )
        );

middlewareConfiguration
    .AddTypedHandlers(handlerConfiguration => handlerConfiguration
        .WithHandlerLifetime(InstanceLifetime.Transient)  // <----------------------------------------
        .AddHandlersFromAssemblyOf(assembly.DefinedTypes.First())
        );

Specifically, non-singleton values of InstanceLifetime do not imply that a new handler is created when an exception is thrown (deep) inside a handler and it bubbles up all the way to Polly. I can observe this by altering a handler dependency (i.e. setting a property value), watching the retry occur, and then inspecting that altered property.
This tends to cause a problem with disposed DB connections 😅
Describe the solution you'd like
Does this make sense? Is there a workaround? Should I try to minimally reproduce in case something else is going on?
Ideally the retry middleware would be placed in a way that creates the handler again as if it was a new incoming message.
Are you able to help bring it to life and contribute with a Pull Request?
No
Additional context
It may not be possible to do this with middlewares based on the implementation of https://github.com/Farfetch/kafkaflow/blob/master/src/KafkaFlow/MiddlewareExecutor.cs

Hi @seruminar,
From your description, it seems to be a bug, but we'll check this out and get back to you with further details.
Can you provide us with a minimal repro for us to look into it?

Hi @luispfgarces thank you for the response!
Attached is a csproj and Program.cs for .NET 6 and KafkaFlow 2.5.0 and KafkaFlow.Retry 2.1.3.
KafkaflowRetryScopeIssue1.zip
Assuming there is Kafka running at localhost:9092, for example from https://hub.docker.com/r/confluentinc/cp-kafka, my console output is as follows:
Hello, World!
Starting host

KafkaFlow: An error occurred creating topic {Topic}: {Reason} | Data: {"Topic":"topic1","Reason":"Topic \u0027topic1\u0027 already exists."}
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
      Content root path: C:\S\s\KafkaflowRetryScopeIssue1\KafkaflowRetryScopeIssue1\bin\Debug\net6.0
Starting test
Producing message

KafkaFlow: Partitions assigned | Data: {"GroupId":"KafkaflowRetryScopeIssue1_topic1","ConsumerName":"f8e87759-9de4-4f86-94da-11d33325acce","Topics":[{"Topic":"topic1","PartitionsCount":1,"Partitions":[0]}]}
Message with a new scope every time: test1

KafkaFlow: Consumer paused by retry process | Data: {"ConsumerGroup":"KafkaflowRetryScopeIssue1_topic1","ConsumerName":"f8e87759-9de4-4f86-94da-11d33325acce","Worker":0}

KafkaFlow: Exception captured by RetryForeverMiddleware. Retry in process. | Data: {"AttemptNumber":1,"WaitMilliseconds":2000,"PartitionNumber":0,"Worker":0,"ExceptionType":"System.NotSupportedException"} | Exception: {"Type":"System.NotSupportedException","Message":"Specified method is not supported.","StackTrace":"   at TestMessageHandler.Handle(IMessageContext context, TestMessage message) in C:\\S\\s\\KafkaflowRetryScopeIssue1\\KafkaflowRetryScopeIssue1\\Program.cs:line 186\r\n   at KafkaFlow.TypedHandler.TypedHandlerMiddleware.\u003C\u003Ec__DisplayClass3_0.\u003CInvoke\u003Eb__0(Type handler)\r\n   at System.Linq.Enumerable.SelectListIterator\u00602.MoveNext()\r\n   at System.Threading.Tasks.Task.WhenAll(IEnumerable\u00601 tasks)\r\n   at KafkaFlow.TypedHandler.TypedHandlerMiddleware.Invoke(IMessageContext context, MiddlewareDelegate next)\r\n   at Polly.AsyncPolicy.\u003C\u003Ec__DisplayClass40_0.\u003C\u003CImplementationAsync\u003Eb__0\u003Ed.MoveNext()\r\n--- End of stack trace from previous location ---\r\n   at Polly.Retry.AsyncRetryEngine.ImplementationAsync[TResult](Func\u00603 action, Context context, CancellationToken cancellationToken, ExceptionPredicates shouldRetryExceptionPredicates, ResultPredicates\u00601 shouldRetryResultPredicates, Func\u00605 onRetryAsync, Int32 permittedRetryCount, IEnumerable\u00601 sleepDurationsEnumerable, Func\u00604 sleepDurationProvider, Boolean continueOnCapturedContext)"}
Message with a reused scope: test1

KafkaFlow: Consumer resumed by retry process | Data: {"ConsumerGroup":"KafkaflowRetryScopeIssue1_topic1","ConsumerName":"f8e87759-9de4-4f86-94da-11d33325acce","Worker":0}

KafkaFlow: Offsets committed | Data: {"Offsets":[{"Topic":"topic1","Partitions":[{"Partition":0,"Offset":9}]}]}

I expect to see just the line Message with a new scope every time: test1 and an exception and retry loop over and over. Instead, it shows that and then completes with Message with a reused scope: test1.

This is a much needed bug and/or feature request. Any updates?


Updating the cac.yml to reflect membership

Updating cac.yml to reflect membership. Removing @ccronje and @erikamias. Adding @ragamouf. Can add pic @ragamouf if you provide. Also, are we missing anyone?

@maneesha it can be merged. On a separate task, I confused my self by updating maintainers on the lesson page that somehow ended up in this PR. But yes, please merge.


[Event Request] Table 64 "Merge Duplicates Buffer" events

Describe the request
Hi, we need some standard events in table 64 "Merge Duplicates Buffer" procedures. IsHandled parameter is optional.
local procedure MergeContacts()
var
    IsHandled: Boolean;
    Contact: array[2] of Record Contact;
begin
    OnBeforeMergeContacts(Rec, IsHandled);
    if IsHandled then
        exit;

    Contact[2].Get(Current);
    Contact[1].Get(Duplicate);

    MergeRecords(Contact[1].RecordId, Contact[2].RecordId, 0);
    Contact[2].Find();
    Contact[2].UpdateBusinessRelation();
    Contact[2].Modify();

    OnAfterMergeContacts(Rec, Contact);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeMergeContacts(Rec: record "Merge Duplicates Buffer"; var IsHandled: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterMergeContacts(Rec: record "Merge Duplicates Buffer"; var Contact: array[2] of Record Contact)
begin
end;

    local procedure MergeCustomers()
var
    IsHandled: Boolean;
    Customer: array[2] of Record Customer;
begin
    OnBeforeMergeCustomers(Rec, IsHandled);
    if IsHandled then
        exit;

    Customer[1].Get(Duplicate);
    Customer[2].Get(Current);
    MoveCommentLinesFromDuplicateToCurrent("Comment Line Table Name"::Customer, Customer[1]."No.", Customer[2]."No.");
    MergeRecords(Customer[1].RecordId, Customer[2].RecordId, Customer[1].FieldNo(SystemId));

    OnAfterMergeCustomers(Rec, Customer);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeMergeCustomers(Rec: Record "Merge Duplicates Buffer"; var IsHandled: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterMergeCustomers(Rec: Record "Merge Duplicates Buffer"; Customer: array[2] of Record Customer)
begin
end;

    local procedure MergeVendors()
var
    IsHandled: Boolean;
    Vendor: array[2] of Record Vendor;
begin
    OnBeforeMergeVendors(Rec, IsHandled);
    if IsHandled then
        exit;

    Vendor[2].Get(Current);
    Vendor[1].Get(Duplicate);
    MoveCommentLinesFromDuplicateToCurrent("Comment Line Table Name"::Vendor, Vendor[1]."No.", Vendor[2]."No.");
    MergeRecords(Vendor[1].RecordId, Vendor[2].RecordId, Vendor[1].FieldNo(SystemId));

    OnAfterMergeVendors(Rec, Vendor);
end;

[IntegrationEvent(false, false)]
local procedure OnBeforeMergeVendors(Rec: Record "Merge Duplicates Buffer"; var IsHandled: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnAfterMergeVendors(Rec: Record "Merge Duplicates Buffer"; Vendor: array[2] of Record Vendor)
begin
end;

Additional context
We need these events to handle some custom logic when merging customers, vendors and contacts and currently there aren't any events that fits our needs. When merging contacts we must know if customers and vendors of those contacts are already merged and after the merge we need to update fields in our extensions which aren't flowfields.Internal work item: AB#493936

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 14883.


[Request]: DID Comms Message Discover Features

Issue for adding https://identity.foundation/didcomm-messaging/spec/#discover-features-protocol-10 later on

Added in 9405f1e6


fix: arguments leak during _writeHead

Furthermore, https://github.com/expressjs/compression is much more interesting in terms of functionality, but would only work with express. Any plans to port it to restify as well?

Thanks. I haven't looked into it, but if it uses same connect-style API it would seem fairly straightforward to port (may even work out of the box). Have you tried using it before?

I've looked into it. Compression uses some express specific handlers extensions to req & res objects, but is rather easy to port if needed

Thanks for the PR @AVVS.


basic-github-commands page added

Looks really nice @pratham4434 .
Congrats 🎉, your PR got merged. To be eligible for the swags from iNeuron X ClueLess. Follow this steps.

SignIn / SignUp in ClueLess Website .

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


Load raw 30-second data from db96

Now that we have decided that it is impractical/impossible to load raw XML files for 30 second data (cf. #74), we'll instead load the data from db96.
Some steps that need to be worked out:

[ ] #105

[ ] Set up Snowpipe architecture for the data loaded by #105

[x] Making sure speed column is included in the schema

[x] Configuring workers / troubleshooting why the upload is taking a long time

[x] #149

[x] #150

[x] #151

@pingpingxiu-DOT-ca-gov the files you are uploading to S3 are now being loaded into RAW_PRD.DB96.VDS30SEC. Let's get #105 merged an call this issue done!

Pingping approved and merged the data.


Failure handling: timeout

Partially addresses #80

This change is

looks simple, can we have tests ?

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

sure, tests are in progress

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@pigmej  so we have tests :)

Reviewed 9 of 9 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 9 of 9 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

e2e/basic_test.go, line 192 at r2 (raw file):
Previously, dshulyak (Dmitry Shulyak) wrote…
framework.Clientset
framework.Namespace.Name

All above tests use local variables, I guess it all needs changing (unless it's changed in your PR)

Comments from Reviewable

Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion.

e2e/basic_test.go, line 192 at r2 (raw file):
Previously, nebril (Maciej Kwiek) wrote…
All above tests use local variables, I guess it all needs changing (unless it's changed in your PR)

@dshulyak done

Comments from Reviewable

Rebased against the latest master to avoid merge conflict

Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Reviewed 8 of 9 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


팀당 인원수 5명 이상 발견 해당 문제 논의

팀별 최대 참가 인원 : 4명 (squad)
5명 이상인 팀 :  11만여건( 팀별 묶음 전체 132만건 중)
kaggle에서 해당 사항 문의 발견
Note : You can see something strange in value counts. Four people are maximum team member and I do not know what it means more than four people.
michaelapers commented
I do want to get ahead of one inevitable question. You will notice that there are frequently more than the supposed max number of players in a group regardless of mode. For example, you might have more than 4 people in a group with matchType == 'squad'. This is caused by disconnections in the game. When disconnections occur, players of multiple groups are stored in the API's database as having the same final placement. This has the consequence that when I make the groupId feature from final placements, we have too large of groups. Please take groupId to mean "players that have the same final placement" and not "players that definitely played in a group together."

해당 문제는 팀원은 모두가 같은 등수 이므로 팀원의 평균을 구하여 팀원에게 다시 적용으로 표준화 작업


Specify refutability of patterns in let and if let

Specify that patterns in 'if let' expressions are refutable
while patterns in 'let' statements are irrefutable.

Of course! Sorry. I misunderstood the definition of refutable to encompass
irrefutable. If I may that change, is this a fix to which you are open?
On Wed, Aug 28, 2019, 4:53 AM Mazdak Farrokhzad<EMAIL_ADDRESS>wrote:

@Centril commented on this pull request.
In src/expressions/if-expr.md
https://github.com/rust-lang-nursery/reference/pull/660#discussion_r318465742
:

@@ -53,9 +53,9 @@ assert_eq!(y, "Bigger");

An if let expression is semantically similar to an if expression but in
place of a condition expression it expects the keyword let followed by a
-pattern, an = and a [scrutinee] expression. If the value of the scrutinee
-matches the pattern, the corresponding block will execute. Otherwise, flow
-proceeds to the following else block if it exists. Like if expressions,
+refutable pattern, an = and a [scrutinee] expression. If the value of the
The pattern in if let can be irrefutable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/reference/pull/660?email_source=notifications&email_token=ACCP2CWWYKNPSAXOCZTTR43QGY4J3A5CNFSM4IQ7VDRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC5N2DQ#pullrequestreview-280681742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCP2CT2AXDMSK3KPDIE7QDQGY4J3ANCNFSM4IQ7VDRA
.

This appears to contradict:
https://doc.rust-lang.org/book/ch18-02-refutability.html
On Wed, Aug 28, 2019, 5:47 AM Will Hawkins<EMAIL_ADDRESS>wrote:

Of course! Sorry. I misunderstood the definition of refutable to encompass
irrefutable. If I may that change, is this a fix to which you are open?
On Wed, Aug 28, 2019, 4:53 AM Mazdak Farrokhzad<EMAIL_ADDRESS>wrote:

@Centril commented on this pull request.
In src/expressions/if-expr.md
https://github.com/rust-lang-nursery/reference/pull/660#discussion_r318465742
:

@@ -53,9 +53,9 @@ assert_eq!(y, "Bigger");

An if let expression is semantically similar to an if expression but in
place of a condition expression it expects the keyword let followed by a
-pattern, an = and a [scrutinee] expression. If the value of the scrutinee
-matches the pattern, the corresponding block will execute. Otherwise, flow
-proceeds to the following else block if it exists. Like if expressions,
+refutable pattern, an = and a [scrutinee] expression. If the value of the
The pattern in if let can be irrefutable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/reference/pull/660?email_source=notifications&email_token=ACCP2CWWYKNPSAXOCZTTR43QGY4J3A5CNFSM4IQ7VDRKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC5N2DQ#pullrequestreview-280681742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCP2CT2AXDMSK3KPDIE7QDQGY4J3ANCNFSM4IQ7VDRA
.

This appears to contradict: https://doc.rust-lang.org/book/ch18-02-refutability.html

The book is wrong.

Ok. Should we reconcile the two?
On Wed, Aug 28, 2019, 6:14 AM Mazdak Farrokhzad<EMAIL_ADDRESS>wrote:

This appears to contradict:
https://doc.rust-lang.org/book/ch18-02-refutability.html
The book is wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/reference/pull/660?email_source=notifications&email_token=ACCP2CQX2TUKO435JNEXZDDQGZFXXA5CNFSM4IQ7VDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KTREA#issuecomment-525678736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCP2CS7U7V3LOF7JOPGF2TQGZFXXANCNFSM4IQ7VDRA
.

Thanks for working on this with me!
On Wed, Aug 28, 2019, 6:15 AM Will Hawkins<EMAIL_ADDRESS>wrote:

Ok. Should we reconcile the two?
On Wed, Aug 28, 2019, 6:14 AM Mazdak Farrokhzad<EMAIL_ADDRESS>wrote:

This appears to contradict:
https://doc.rust-lang.org/book/ch18-02-refutability.html
The book is wrong.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang-nursery/reference/pull/660?email_source=notifications&email_token=ACCP2CQX2TUKO435JNEXZDDQGZFXXA5CNFSM4IQ7VDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KTREA#issuecomment-525678736,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACCP2CS7U7V3LOF7JOPGF2TQGZFXXANCNFSM4IQ7VDRA
.

Yes we should. Please file a bug against the book's repo.

Closing to reopen because I am expanding the scope slightly.


Sleek Repeat From Due

Is it possible to repeat(Recurrence ) from Due Date, rather than Compelete Date?
*If your proposal is more a rough idea than a precise description of a feature, please consider starting a discussion instead: Currently it is possible to have recurrent task from complete date
for example if I set due date to 0509(recurrence by day), and compelete on 0510, the next date would be 0511
Did you check if a similar feature request has already been reported?
Yes
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
sometimes I just like to have tasks repeat from due date
in previous case the new occurence should be from 0510(one day after current due)
Describe alternatives you've considered
nothing specific

Yes, I think what you want is the "strict" recurrence "rec:+1d" which will make the next due date be computed relative to the previous due date, not the completion date.  See Recurring todos (rec:) · ransome1/sleek Wiki for more explanation.

@zerodat
Hi, thank you for your reply.
I tried and yes it worked.
only problem: Recurring from Completeion(Default) and Strict Mode Cannot be told from GUI without clicking on the task
a small problem though
Thank you so much!


Rename unused DriverErrorType.genericError

To avoid collision with ContainerErrorType.genericError.
This is a breaking change, whenever we release the next bump of driver-definitions.  @anthony-murphy where do we write down those breaking changes?  Seems like BREAKING.md may need to split up?

What collision are you avoiding here? could be possibly make it non-breaking, by having the driver error class append a namespace/prefix, rather than forcing all error strings to be unique?

it also looks like genericError is currently unused. should we just deprecate it.

Ok fine I just marked it as deprecated.


Support user-specified hdf5 and hdf5_hl libraries

If the netcdf cmake build is configured with explicitly specified hdf5 c and hl libraries:
    -DHDF5_C_LIBRARY:PATH=${ACCESS}/lib/libhdf5.dylib \
    -DHDF5_HL_LIBRARY:PATH=${ACCESS}/lib/libhdf5_hl.dylib \
    -DHDF5_INCLUDE_DIR:PATH=${ACCESS}/include \

Then it looks like the HDF5_C_LIBRARIES and HDF5_HL_LIBRARIES variables do not get set and then this causes the HDF5 libraries to be omitted from the TLL_LIBS symbol in liblib/CMakeLists.txt.  This is subsequently used to build ALL_TLL_LIBS which is used for LIBS which is output as the Extra libraries:        @LIBS@ in libnetcdf.settings.in
The output for -- Linking against: is also incorrect as it omits the hdf5 libraries:   Output without suggested change:
-- Linking against:      /usr/lib/libdl.dylib;/usr/lib/libm.dylib;/opt/local/lib/libz.dylib;/opt/local/lib/libcurl.dylib
(later in file)
Extra libraries:	-ldl -lm -lz -lcurl

versus output with suggested change:
-- Linking against:      /Users/gdsjaar/src/seacas-parallel/lib/libhdf5_hl.dylib;/Users/gdsjaar/src/seacas-parallel/lib/libhdf5.dylib;/usr/lib/libdl.dylib;/usr/lib/libm.dylib;/opt/local/lib/libz.dylib;/opt/local/lib/libcurl.dylib
(later in file)
Extra libraries:	-lhdf5_hl -lhdf5 -ldl -lm -lz -lcurl

This also causes a link failure when building libnetcdf.dylib

Thanks @gsjaardema !


How to create cali.txt and pose.txt data from custom data

First of all, thank you for providing excellent code and models.
I want to use RangeNet++ with my custom data.
I understand that I need to format the data similar to semantic-kitti.
So, I've labeled the data and converted it into .bin files, but I'm unsure how to create pose.txt and cali.txt files.
For pose.txt, it seems like I need to use surfel-based SLAM approach (SuMa) to obtain global coordinate values, but as a beginner, I don't  know how to do that.
I would really appreciate it if you could help me.
Thank you in advance.

if you are just interested in semantic segmentation, you don't need poses or the calib.txt. RangeNet++ uses a single scan. Not sure what you want to achieve. Can you maybe provide more information on your concrete problem.
The poses and calib.txt follows the KITTI conventions: see https://github.com/jbehley/point_labeler/issues/23#issuecomment-640119577
For pose estimation on your own data, you can give kiss icp (see https://github.com/PRBonn/kiss-icp)


Zoomed page creates gap between toolbar and grid

I have my default zoom level set at 110% in Opera and Chrome which creates a white gap between the toolbar and grid. See screenshot below.

Setting my zoom level to 125% and loading the page doesn't create this gap. If I load the page at 100% or 125% zoom and then change the zoom to 110% it doesn't break.
This happens using the 1.5rc1 and the February 'nightly' version in the dist folder in the Git repository.
Attached below a minimal demonstration.
test grid zoom.zip

I have the same, but have no clue how to fix it. I have tried to fiddle with css, but got no solution.


Unexpected input(s) 'excludeLabels', valid inputs are ['token', 'from', 'until', 'blobContainerName', 'blobStorageKey', 'configPath', 'appInsightsKey']

👍

Looks like this was created by accident, closing. If needed, feel free to reopen with more details, thank you!


file\\image.png not found.

Changed yaml file several times and entered the directory manually but Android Studio and flutter still display error messages.

Can you paste the output of Flutter Doctor and the complete error message?
What does your yaml file look like?

Are you still having this issue?


VSTest Issues with Agent 2.150.3

Agent Version and Platform
2.150.3
OS of the machine running the agent? OSX/Windows/Linux/...
Windows 10 (Azure hosted VM)
Azure DevOps Type and Version
dev.azure.com - hosted
If dev.azure.com, what is your organization name? https://dev.azure.com/{organization} or https://{organization}.visualstudio.com
What's not working?
Our self hosted agents all updated to version 2.150.3 yesterday (5/1/2019).
Since then the VSTest execution tasks have not been working properly. They execute and run all the tests, and the task returns succes, however the vstest.exe process continually crashes and generates dumps while running the tests. TRX file seems to be not getting generated at end of the run.
Have reproduced issue on 3 different agents that all received the update
The test run task log contains errors like this for each unit test assembly being run.
`Starting test execution, please wait...
 0 . 3 0 3 1 9 . 2 0 0
C o p y r i g h t   ( c )   M i c r o s o f t   C o r p o r a t i o n .
Also at the start of the test execution step the output is different than normal it is logging about a DtaExecutionHost and dumping the run settings xml to the console. Builds that ran correctly prior to this just showed vstest.exe running at this point.
`Test selector : Test assemblies
Test filter criteria : null
Search folder : C:\inst_agent_work\1\s
VisualStudio version selected for test execution : latest
Attempting to find vstest.console from a visual studio installation.
Attempting to find vstest.console from a visual studio build tools installation.
Attempting to find vstest.console from a visual studio installation.
Run settings file : C:\inst_agent_work\1\s\CodeCoverage.runsettings
Run in parallel : false
Run in isolation : true
Path to custom adapters : null
Other console options : null
Code coverage enabled : true
Diagnostics enabled : true
SystemVssConnection exists true
Run the tests locally using vstest.console.exe
Source filter: bin***.AutomatedTests.*UT.dll
SystemVssConnection exists true
[command]C:\inst_agent_work_tasks\VSTest_ef087383-ee5e-42c7-9a53-ab56c98420f9\2.151.4\Modules\DTAExecutionHost.exe --inputFile C:\inst_agent_work_temp\input_757da171-6d11-11e9-9797-1bfb3808d265.json
##########################################################################
DtaExecutionHost version 17.151.28818.1.
Starting TestExecution Model...
Provided settings file:

`
Have been trying to roll back to Agent 2.150.2 to see if issue would go away but have not found a way to prevent the agent from updating again on next run.
Agent and Worker's Diagnostic Logs
Noticed the following warning about authentication failure in the agent logs. (organization replaced with XXXX)
[2019-05-02 18:55:42Z WARN VisualStudioServices] Authentication failed with status code 401. Cache-Control: no-cache Date: Thu, 02 May 2019 18:55:42 GMT Pragma: no-cache P3P: CP="CAO DSP COR ADMa DEV CONo TELo CUR PSA PSD TAI IVDo OUR SAMi BUS DEM NAV STA UNI COM INT PHY ONL FIN PUR LOC CNT" WWW-Authenticate: Bearer authorization_uri=https://login.microsoftonline.com/771c9c47-7f24-44dc-958e-34f8713a8394, Basic realm="https://tfsprodcus3.visualstudio.com/", TFS-Federated x-tfs-processid: 4ff9a6a0-d2fd-4c59-aae0-d994d01ed37d Strict-Transport-Security: max-age=31536000; includeSubDomains activityid: 55c0e0fe-238b-4b52-a230-474186c40b41 x-tfs-session: b880c9d4-f165-4b60-b687-df0869d53299 x-vss-e2eid: 03a5412a-bae5-4ce6-9781-6cbea67daedb X-Frame-Options: SAMEORIGIN x-tfs-fedauthrealm: https://tfsprodcus3.visualstudio.com/ x-tfs-fedauthissuer: https://dev.azure.com/XXXX/ x-vss-authorizationendpoint: https://vssps.dev.azure.com/XXXX/ x-vss-resourcetenant: 771c9c47-7f24-44dc-958e-34f8713a8394 x-vss-s2stargetservice: 00000002-0000-8888-8000-000000000000/visualstudio.com x-tfs-fedauthredirect: https://spsprodcus2.vssps.visualstudio.com/_signin?realm=dev.azure.com&reply_to=https%3A%2F%2Fdev.azure.com%XXXX%2F_apis%2Fdistributedtask%2Fpools%2F10%2Fsessions&redirect=1&aadinmsa=true&hid=7ed04f47-ba34-4244-8010-65f049de9ae3&context=eyJodCI6MiwiaGlkIjoiZWViYzU3NTctZWFjYS00MjE4LTlmNDctNzQxNTVkZTI2NjFlIiwicXMiOnt9LCJyciI6IiIsInZoIjoiIiwiY3YiOiIiLCJjcyI6IiJ90#ctx=eyJTaWduSW5Db29raWVEb21haW5zIjpbImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSIsImh0dHBzOi8vbG9naW4ubWljcm9zb2Z0b25saW5lLmNvbSJdfQ2 request-context: appId=cid-v1:f88d1338-e7ba-4d7b-83e0-e573c40a2f62 Access-Control-Expose-Headers: Request-Context X-Content-Type-Options: nosniff X-MSEdge-Ref: Ref A: EB5AEB988BB84BC1A742BAD4ABBB42C6 Ref B: BY3EDGE0209 Ref C: 2019-05-02T18:55:42Z

Found that disabling the visual studio "DotNet Extensions for Test Explorer" on the visual studio installation on each build VM resolved this issue.


Accessibility - Form control element  has no associated label

the search input box has no label
reporting url https://ibmdocs-dev.mybluemix.net/docs/en/error
you can use the ibm equal access checker
<input value="" name="q" data-autoid="dds--header__search--input" placeholder="Search IBM Documentation" class="bx--header__search--input" aria-controls="react-autowhatever-1" aria-autocomplete="list" autocomplete="off" type="text">

Kenny will review and document more details for the next review.

Confirmed fix is needed for React version.


Second Linux link went to Windows doc instead

Change the markdown to point to the Linux doc for the Linux link.

@sbonds : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@mmccrory: I'm sorry - only the author of this article, @deanwe, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Merging with PM @mmccrory approval; thanks.


alternative hybrid relationship loading strategy

Is your feature request related to a problem? Please describe.
Right now we have two relationship loading strategies  : joined and select-in
I was a happy user of "joined" (the default option for postgress), but lately I started noticing my backend was extremely slow.
I think the issue is related to postgress' joined collapse limit. TLDR; if too many tables are joined, even if the final result is only a handfull of rows, even if all the tables are properly indexed, the query will be painfully slow.
I removed a few relationship to test my theory, and indeed it was fast again.
I tried switching to select-in, and this solves the issue, but creates another one : the requests look somewhat like select * from my_child_table where id in (.... a potentially very long list of all the parent entity id we want).
This long list of ids make this solution suboptimal
Describe the solution you'd like
add a new strategy "select-in-joined" that will execute one request per child entity (similar to the select-in strategy), but which will join on the parent entity rather than transferring all the invidivual ids (similar to the join strategy)
alternatively, update the select-in strategy so that it joins on the parents entity tables above a certain number of items (eg 100 by default)

I am planning something similar, joining things only for to-one relations, and using separate selects for to-many relations. This way the cartesian products won't explode. Such a strategy would be the default most likely in v7.
I don't think a huge where condition is the problem here, if you think so, please provide a complete repro that proves that, otherwise I will go with the approach highlighted above.

I am planning something similar, joining things only for to-one relations, and using separate selects for to-many relations. This way the cartesian products won't explode. Such a strategy would be the default most likely in v7.

I think this would help a lot with my issue! Looking forward to V7, and thank you for the amazing work you're doing on mikro ORM !!

I don't think a huge where condition is the problem here, if you think so, please provide a complete repro that proves that, otherwise I will go with the approach highlighted above.

I think there are two different issues:
1/ 'joined' doesn't work for me because postgress is notoriously bad at handling joins over too many tables (contrary to say MS SQLServer). That's why I like the select-in option, which avoids this issue entirely
2/ 'select-in' doesnt work either:
Let's say I have a table p (as parent entity) with 10.000 rows, and many tables c1..cn (as in child entity) with a FK on table p
If I want to load every single row, mikro orm will do this:
select * from p
select c1.* from c1 where p_id in (... a list of 10.000 ids)
.....
select cn.* from cn where p_id in (... a list of 10.000 ids)

We can't join all of thoses queries because that would be too many for postgress, but we coud at least do
select * from p
select c1.* from c1 inner join p on c1.p_id=p.id
....
select cn.* from cn inner join p on cn.p_id=p.id

This would be way more efficient, but it doesnt always work, eg:
select * from p where id in  (a very big and expensive subquery that returns only one id)

here, mikro orm current approach of passing the id(s) to each query seems totally warranted
That's why I think we would need a way to control on a query per query basis the strategy to use (or maybe this could be automated in mikro orm, I don't know!)
There were many assertions in my post, and it's unclear to me which one you would see a repro for!

I see, I guess we could just batch those select calls, just like we do it with the insert/update queries from flush. We can do that easily now.

I see, I guess we could just batch those select calls, just like we do it with the insert/update queries from flush. We can do that easily now.

I think that would help a lot to make the select-in strategy more viable! I'm looking forward to testing that when it's available.

I did a quick test and it looks quite fast on my end, a query with where in 10000 ids takes around 20ms locally with postgres. I guess things can go wrong with more complex scenarios, but without a repro its hard to optimize things.

I did a quick example showing how much the "joined" strategy is broken using postgress when the number of collection grows. The repo is here
Here is what I do:
I create a parent entity and 20 child entites (c1...c20). The parent entity has a collection of each.
I insert 10.000 parent entities, and 100 of each child entities in the db.
then for each parent, I randomly add to their c1 and c2 collections 10 childs. I don't touch the others c3 to c20 collections which remain completely empty
I then timed those three requests
await orm.em.find(Parent, {}, {strategy: 'select-in', populate: ['c1s', 'c2s', 'c3s', 'c4s', 'c5s', 'c6s', 'c7s', 'c8s', 'c9s', 'c10s', 'c11s', 'c12s', 'c13s', 'c14s', 'c15s', 'c16s', 'c17s', 'c18s', 'c19s', 'c20s'] });
// 3915ms

await orm.em.find(Parent, {}, {strategy: 'joined', populate: ['c1s', 'c2s', 'c3s', 'c4s', 'c5s', 'c6s', 'c7s', 'c8s', 'c9s', 'c10s', 'c11s', 'c12s', 'c13s', 'c14s', 'c15s', 'c16s', 'c17s', 'c18s', 'c19s', 'c20s'] });
 // 38111ms

  await orm.em.find(Parent, {}, {strategy: 'joined', populate: ['c1s', 'c2s'] });
// 4433ms

as you can see, joining on 18 addtional empty tables turns a 4s request into a 38s one ...

I wanted to see a repro where the select in strategy is slow, joining to-many relations is destined to be problematic due to the cartesian products, and your repro is using 20 M:N relations, those are literally the worse, since they require two joins for every property. This is kinda destined to be slow, and feels like a very artificial thing to do. If someone is doing this in their apps, they must be crazy 🙃
This is not really what you described as the culprit earlier, you said the problem is a huge where in (...) condition and I am not really sure that is the case.

I did a quick test and it looks quite fast on my end, a query with where in 10000 ids takes around 20ms locally with postgres. I guess things can go wrong with more complex scenarios, but without a repro its hard to optimize things.

yes it's quite fast locally with a trivial exemple.
Here is my real world scenario:

the backend and the db are not on the same server

i'm using uuids, not integers, so the primary keys are way bigger

i'm using pagination_tokens, so I typically want to select the first n 1000 entities with a token>x.

Calling our tables p (parent) and c (child), here is what Mirko orm does with select-in:
select * from p where pagination_token>x limit 1000
select * from c inner join p_c_jointable where p_c_jointable.parent_id in (... the big list)

And here what I think would make way more sense (maybe not as default, but at least to have the option)
select * from p where pagination_token>x limit 1000

select c.* from p
inner join p_c_jointable on p_c_jointable.p_id=p.id
inner join c on p_c_jointable.c_id = c.id
where pagination_token>x limit 1000

I wanted to see a repro where the select in strategy is slow, joining to-many relations is destined to be problematic due to the cartesian products, and your repro is using 20 M:N relations, those are literally the worse, since they require two joins for every property. This is kinda destined to be slow, and feels like a very artificial thing to do.
That being said, in my example I was comparing joining on 2 tables, and joining on those same 2 tables + 18 empty tables . This does absolutely nothing to the cartesian product, does it? the number of rows returned is exactly the same, it is just that postgress gets absurdely inefficient when handling too many joins! Hence the need for a finer grain control on the strategy to use.
For example, maybe you could automatically fall back to the select-in strategy if the request is going to join too many tables on postgres
In conclusion, I will use select-in for everything until the new v7 hybrid strategy is available !
Thank you for your time!
Brann

I wonder what hw you are using, I checked your repro and it behaves twice as fast on my end (M1 pro) :]

18 empty tables

Nope, they are not empty. The joined query you say is so slow returns 177786 results (and takes 1700ms on my end). The whole problem with that approach is not the query itself, but the hydration, caused by the huge cartesian product. You can see the numbers at the end of the queries. And that is exactly what could be solved with the approach I mentioned above.

[took 1702 ms, 177786 results]

As opposed to the select in queries, those, even when containing huge where in clause, often take less than 10 ms when they don't return any results. So I still have doubts about this being a problem (and would still like to see a repro if you still believe in your claim).

[took 8 ms, 0 results]

And here what I think would make way more sense (maybe not as default, but at least to have the option)

Also regarding this suggestion, you cannot use the limit clause like this, again, because of the cartesian product.


cherry pick import csv bug fix to Rel/0.12

To master or to rel/0.12?

To master or to rel/0.12?

to rel/0.12

Coverage decreased (-0.1%) to 67.89% when pulling 9ea83b5d558179b09c76f6ba0e7e272330e5d86a on haimeiguo:rel/0.12 into 4f7a15c2f6e0b0e2adbd42af2d2a4ab2443410dc on apache:rel/0.12.


Enforce object permissions on coupled DNS record

This is a possible solution to issue #166.
In web UI or API context, the coupled record is immediately saved when the "post_clean" signal is called. All record creation/modification happen in a transaction, so that object permissions are enforced.
To complete the coupling, the "ipam_ip_address" field must be updated to reference the IP Address. It can't be done at this this point because the IP address is not created yet. It's actually done at the very end, when "post_save" is called. At record creation/modification time, we monkeypatch the "request" object to hold the necessary informations into a "post_save_ops" attribute.
On another note, the semantic of a permission for record modification was not well defined. Two permission checks are done:

on the current record,
on the modified record.

The "test_modify_name_with_dns_object_permission" testcase takes care of this. Furthermore, two duplicated tests cases were removed.
This should have no impact in non-UI/non-API context, as permission checks are only done in "post_clean".

I did the PR in a branch this time. Sorry for being so clumsy.
The changes can be improved:
In ip_address_update_address_record (post_save), Record.save() can be called twice.
Maybe the whole "post_save_ops" handling should be moved into the else clause

Sometimes GH can get on one's nerves ... don't ask me how often I re-did things. It takes some time to wrap one's head around it.
I'm investigating some stuff regading checking object permissions that will probably make it necessary to make additional changes to the code, and which would probably fit very well into the context of your PR. Might take some time, though.

Hi @jean1, I added tests for creating IP addresses with/without the required object permissions, and they work fine with your code. They should be similar to your manual test in #166.
If you want to add further changes, please change the status of the PR to "draft" and set it back to "review required" when your done. Or drop me a not and I'll merge it.


Upgrade to Jackson 2.10

one deprecated method replaced by JsonBuilder.configure(...).

GA is expected before our GA.

Let's hold of merging until really their release!


Add support for SigV4 chunked signing

Currently HttpBody.Streaming payloads are only supported through UNSIGNED-PAYLOAD (see AwsSigV4SigningMiddleware). AWS SDK's should default to signed payloads whenever possible though with few exceptions:

Customer explicitly requests unsigned payload

assuming we even give a knob to do so, the context attribute exists already though to support the unsigned payload trait (see  AuthAttributes.UnsignedPayload)

Customer gives us an unbounded stream (e.g. ByteStream.Reader -> HttpBody.Streaming)

In the case of (2) there are only 3 options:

use unsigned payload (not desired as the default)
the stream must support a seek operation such that it can be read multiple times

computing the signature for a single chunk requires consuming the stream
SdkByteReadChannel is a "single use/pass" channel and the underlying SDK mechanism that supports async byte streams. It does not (and should not) arbitrarily support seeking because doing so would require buffering ALL of the writes in-memory

use chunked signing such that the stream only needs to be consumed once

NOTE: S3 still requires a known a Content-Length even for chunked signing so we can't support arbitrary streams of unknown length. It would be nice to be able to provide a UriContent type though that could e.g. upload content from a URI (assuming the content gives a Content-Length).

we would hopefully be able to default to chunked signing when given a stream such that rewinding or special casing files isn't necessary for computing the signature.
It's unclear what services or individual operations support chunked signing though. The CRT team indicated the following:

Generally only streaming operations will support chunked signing, and all other operations defined by the service will use conventional sigv4.
Transcribe Streaming supports chunked signing, but not the aws-chunked content-encoding

When we are sending chunked requests to S3, we don't need to include the Content-Length header.

Specify the Transfer-Encoding HTTP header. If you include the Transfer-Encoding header and specify any value other than identity, you must omit the Content-Length header.

https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-streaming.html
We will be specifying a value of chunked for Transfer-Encoding, so I'm pretty sure we can work around an un-rewindable stream.

When we are sending chunked requests to S3, we don't need to include the Content-Length header.

This unfortunately isn't true. S3 requires Content-Length even when streaming (see https://github.com/awslabs/aws-sdk-kotlin/issues/612#issuecomment-1136110897)

so I'm pretty sure we can work around an un-rewindable stream.

Correct, as long as the stream still supplies a total size then we can send it with Transfer-Encoding: aws-chunked and calculate the signature as we are sending it for each chunk.

Resolved via #747


slide reveal only with screen edge gesture

How can we restrict sliding of the reveal only with screen edge gesture rather than on swiping any where on screen.
Currently the reveal slides and show left option menu even when we swipe to right from right edge..

You will find the response here: #690 or #699.
You can also just use:
self.revealViewController.draggableBorderWidth = 50;

- (BOOL)revealControllerPanGestureShouldBegin:(SWRevealViewController *)revealController {
    CGPoint point = [revealController.panGestureRecognizer locationInView:self.view];
    // Menu is close, pan gesture should begin if pan start from border
    if (revealController.frontViewPosition == FrontViewPositionLeft && point.x < 50.0) {
        return YES;
    }
    // Menu is open, pan gesture should begin
    else if (revealController.frontViewPosition == FrontViewPositionRight) {
        return YES;
    }
    return NO;
}

Thank you so much @iDevelopper


Display user binding tenant if exist

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13909 (3d16d2a) into dev (d772f24) will decrease coverage by 0.04%.
 Consider uploading reports for the commit c23df69 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13909      +/-   ##
============================================
- Coverage     38.91%   38.88%   -0.04%
+ Complexity     4465     4454      -11
============================================
  Files          1158     1158
  Lines         42424    42394      -30
  Branches       4772     4752      -20
============================================
- Hits          16510    16484      -26
+ Misses        24097    24095       -2
+ Partials       1817     1815       -2

Impacted Files
Coverage Δ

...api/service/impl/ProcessDefinitionServiceImpl.java
35.09% <0.00%> (ø)

...heduler/api/service/impl/SchedulerServiceImpl.java
30.59% <33.33%> (+0.08%)
:arrow_up:

...inscheduler/api/service/impl/UsersServiceImpl.java
70.78% <100.00%> (+0.13%)
:arrow_up:

...pache/dolphinscheduler/service/cron/CronUtils.java
53.78% <100.00%> (+2.02%)
:arrow_up:

... and 32 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create example pipeline for static embeddings

We want to prepare an example pipeline using static word embeddings https://github.com/CLARIN-PL/embeddings#available-models

Onhold until #151 will be finished

@ktagowski what is the status for this issues?


Mock namespaces are not always showing up in doxygen

Bigtable docs don't show bigtable_mocks or bigtable_admin_mocks.
Spanner docs show spanner_mocks but not spanner_admin_mocks.
All other mock service libraries seem to be fine...

bigtable_mocks does not show up because all symbols within the namespace are internal. That is what we want, and not an issue. The issue is with the admin_mocks.


getting blurred output using Dev model

Please suggest what settings will work best with Dev model
prompt="Northern lights dancing over a snow-covered forest, starry night sky, lone wolf howling, moonlight casting blue shadows, digital art",
width=1024,
height=1024,
num_inference_steps=4,
guidance_scale=0,

With schnell, it's better using the same settings

For dev model, you should increase num_inference_steps. Try use num_inference_steps=50. schnell is the distilled version, which reduce the inference step to 4.

tried with 50 steps


Regular Expression

Hello Raja! Mate you can make this validator more efficient by adding RegExp for Email Validation. You checkout StackOverflow to add it.

Yeah, I am putting all the validations in later projects, maybe a second version!
Thanks for always carefully going through my work!

Also, the main reason behind letting it go was "As the front end uses Bootstrap" and bootstrap has got built-in simple validations like @ or email domain extensions.


Cannot upgrade UserPoolClientLambda from Nodejs14.x via the Amplify CI pipeline, therefore cannot deploy any code

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
20
Amplify CLI Version
12.10.0
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes that should be relevant to the problem I am describing
Describe the bug
As of March 6th 2024, AWS seems not to allow Lambda functions to be created or updated if they are running on Node.js 14.x or lower. I've updated all the Lambda functions in my project to Node v20, including the one mention I was able to find of UserPoolClientLambda, in the YAML CloudFormation file for the Cognito User Pool. If I push to Amplify from my computer, the everything succeeds, all my Lambda functions show up in the Lambda console as running Node v20. If however I run the CI pipeline, it fails with this message:

The following resources failed to deploy:
Resource Name: UserPoolClientLambda (AWS::Lambda::Function)
Event Type: create
Reason: Resource handler returned message: "The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: 4555eef4-63e6-4439-844c-84f091c5b402)" (RequestToken: 86bafbbb-1141-6401-6589-c5df4b2b63a2, HandlerErrorCode: InvalidRequest)

I don't know how to update that function. What's worse, I cannot even find that function in the Lambda console. This project was created in 2020, so it was created with a much older version of the Amplify CLI. Deleting resources or environments and recreating them is not an option, because this application is being used in production right now and has a lot of real user data stored.
Expected behavior
The build should succeed, or at the very least clear instructions should be provided on how to fix the problem
Reproduction steps
I cannot provide reproduction steps, because a new Amplify project created today would not have auto-generated Lambda functions that run on Node v14.
Project Identifier
8344d1fa6b3718c1a27d61c3551a1d8a
Log output

🛑 The following resources failed to deploy:
                                 Resource Name: UserPoolClientLambda (AWS::Lambda::Function)
                                 Event Type: create
                                 Reason: Resource handler returned message: "The runtime parameter of nodejs14.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (nodejs20.x) while creating or updating functions. (Service: Lambda, Status Code: 400, Request ID: 4555eef4-63e6-4439-844c-84f091c5b402)" (RequestToken: 86bafbbb-1141-6401-6589-c5df4b2b63a2, HandlerErrorCode: InvalidRequest)
2024-03-07T20:07:56.605Z [INFO]:
2024-03-07T20:07:56.610Z [WARNING]: ✖ There was an error initializing your environment.
2024-03-07T20:07:56.610Z [INFO]: 🛑 Resource is not in the state stackUpdateComplete
                                 Learn more at: https://docs.amplify.aws/cli/project/troubleshooting/
2024-03-07T20:07:56.616Z [INFO]:
2024-03-07T20:07:56.616Z [INFO]: Session Identifier: 26ba860a-eac4-499f-a21a-cfe2e58d6653

Additional information
No response
Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @dragosiordachioaia, thank you for reaching out. Does the CI pipeline also use the latest/updated Amplify CLI version?
As the UserPoolClientLambda is a inline function present in the auth CloudFormation templates, when running amplify push Amplify builds and updates the NodeJs version on the Lambda function.

YAML CloudFormation

It appears this is an un-migrated auth resource, you can update the resource by running amplify update auth which should prompt you to migrate the the auth resource.

Hey @dragosiordachioaia, thank you for confirming. Could you download and un-zip the #current-cloud-backend.zip from the AWS S3 deployment bucket.  In the CloudFormation templates under auth/<name>/build and the awscloudformation/build do you observe a userpoolclient lambda with a NodeJs runtime as 14?
Could you try pulling the project into a new directory outside your existing project directory. In the CloudFormation templates under backend/auth/<name>/build and the backend/awscloudformation/build do you observe a userpoolclient lambda?

@ykethan I've checked all of that, no Lambda uses Node 14, only 18 and 20.

app ID is d18apgfog4c8xo. One example of a failed build (before I disabled the back-end build altogether just to get the front-end to deploy) is 1740 (I hope this is the right identifier, it seems to be an auto-incrementing build number). As for switching to Amazon Linux: 2, I tried it just now (while using Node 16 for the build, since building the front-end with Node 18 seems to run out of memory no matter what I try, but that's a problem to solve later) and this is the error I get:
                                    npm ERR! command failed
                                    npm ERR! command sh -c -- node scripts/warn-maintenance-mode.js
                                    npm ERR! sh: node: command not found
                                    npm ERR!  Build failed
2024-03-11T20:41:57.271Z [ERROR]: !!! Error: Command failed with exit code 127
2024-03-11T20:41:57.271Z [INFO]: # Starting environment caching...
2024-03-11T20:41:57.271Z [INFO]: # Uploading environment cache artifact...
2024-03-11T20:41:57.340Z [INFO]: # Uploaded environment cache artifact
2024-03-11T20:41:57.340Z [INFO]: # Environment caching completed
2024-03-11T20:41:57.341Z [INFO]: # A new default build image based on Amazon Linux 2023 is now generally available. The image includes newer versions of Node.js, Python, and Ruby that you can use to build your app. To use the new image, select "Amazon Linux:2023" in the "Build settings" section for your app in the Amplify console.
Terminating logging...```

As it turns out, I had a command in my backend phase to install version
10.5.0 of the Amplify CLI. This was due to an issue I had encountered in
the past for which the only fix was to pin that version of the CLI. It
seems that issue is no longer present in the latest version, so I removed
that line and switched back to the Amazon Linux 2023 build image, now
everything works again. Sorry for the confusion!
On Mon 11 Mar 2024 at 21:18, Kethan sai @.***> wrote:

@dragosiordachioaia https://github.com/dragosiordachioaia could you
provide us the App ID and failed build?
additionally, if you switch the image to Amazon Linux:2 image does this
throw a similar error message?
—
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/13644#issuecomment-1989360440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAPREOT276SIEMIYSEJON3YXYNS7AVCNFSM6AAAAABEMUWKBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGM3DANBUGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@dragosiordachioaia thank you for the confirmation. Glad to hear you were able to mitigate the issue.


add social media url to both email

#99

Cool will merge after rolling our 1.4.0

It might be easier for everyone to separate linting and formatting from other changes into a separate PR

Please do rebase and force push to solve conflic

Sloved

Closed as outdated. Many Thanks anyway


distribution endpoint numMissingCases seems wrong

for umsp - weight i can see:
"numVarValues":2343855,"numDistinctValues":1814,"numDistinctEntityRecords":4104822,"numMissingCases":0
either i dont know what numMissingCases represents, or it shouldnt be 0 here since we have fewer values than entities?

Fixed.


[SUPPORT] Inquiry about distinguishing between different aspects

Tips before filing an issue

Have you gone through our FAQs?
Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
So you think you can tell? Heaven from hell? Blue skies from pain?
Additional context
Add any other context about the problem here.
Stacktrace
Add the stacktrace of the error.

From a cold steel rail?


Mute button stuck on modifiers like scroll-lock

Occasionally, the mute/unmute toggle will act as if it's held down when using a key like scroll-lock. Is it possible to implement some sort of soft cooldown to prevent this from happening?

I'm not sure I completely understand the issue
is the toggle hotkey set to scroll-lock or does the toggle hotkey get stuck when clicking scroll-lock at the same time?

Sorry if I've been unclear.
I have set my toggle to Scroll-Lock, it's a key I use the least and was a good choice on my limited keyboard.
Occasionally, when pressing scroll-lock, expecting the toggle, it will get stuck as if the key was held down causing a rapid mute/unmute cycle.
I suggested a cooldown for the toggle when the key is pressed as a possible means of preventing the toggle from getting stuck as if it were held down.
I have also tested this with multiple keyboards and can confirm that it is not the key on my keyboard itself getting stuck.

I had no luck reproducing this issue, perhaps it might be caused by another program with a conflicting shortcut? or if your keyboard has a driver utility (like razer or logitech)
Could you post your config.json file as well? you can access it by holding the shift key while clicking Edit Configuration from the tray menu

I figured it out, it was a key-binding inside of Xbox Accessories of all things, where my controller had Scroll Lock also bound.
Sorry to have taken your time, thank you.


Fix code quality issues

Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[ ] Tests
[x] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[ ] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
This pull request fixes some of the code quality issues raised by DeepSource on my fork of this repository. I have fixed some issues using DeepSource's Autofix.
Take a quick look at all the issues caught by DeepSource for this repository here.
Summary of fixes

Remove length check in favour of truthiness of the object
Remove reimported module
Remove unused imports
Merge isinstance calls

You can also have a look at the configuration file I used for DeepSource Analysis.

I find these tools have so many false positives they just create busy-work that has no real impact. I'm afraid this PR just confirm that.

Hey @willmcgugan :wave:
The false-positive rate of DeepSource is less than 5%.
I'd suggest you give it a try since DeepSource is free for Open Source.


Implement discoveryAdvertisingStateUpdateEvent in thaliWifiInfrastructure

It was discussed that the event discoveryAdvertisingStateUpdateEvent defined in thaliWifiInfrastructure.js is not required in first phase so it was not implemented yet.

@vjrantal Didn't we actually end up implementing this anyway in which case we can close this bug?

That is right.


ci: Introduce CI coverage for TruffleRuby

I'd like to introduce test coverage, both as a sign of solidarity with TruffleRuby and to learn a bit more about it.

[ ] Build base TruffleRuby OCI images for stable and nightly
[ ] Build nokogiri-test images for stable and nightly
[ ] Add a non-release-blocking job to the CI pipelines (master and PR)

Also see related issue #1882 which will drive upstreaming of TR patches into Nokogiri.

Note that I've created some base images at https://github.com/flavorjones/docker-truffleruby

LGTM!

stable: https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri/jobs/truffle-stable/builds/2
nightly: https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri/jobs/truffle-nightly/builds/2

/cc @eregon @chrisseaton for visibility.

@flavorjones Thank you for adding TruffleRuby in CI!
And for the Docker images too :)


Oscillator "gain" control

Suggested by Don Turnock
Provide a way to move all of the points in an amplitude envelope up or down by some percentage - as a way to change the "gain" of an oscillator without having to edit every point on the graph.   Particularly useful when tuning modulator signals.

Implemented for 2.4.0

Implemented for 2.4.0


Question:Failed to establish connection: HTTPSConnectionPool

Hello,
I am using localcolabfold and I am experiencing for the first time failure in establishing connection with the API, after a couple of weeks not using localcolabfold. I've been using it for a long time now without experiencing this issue.
You will find below what it systematically returns for all my jobs. Thank you in advance for your help:
Module GCCcore/10.2.0, zlib/1.2.11, binutils/2.35, numactl/2.0.13, XZ/5.2.5, libxml2/2.9.10, libpciaccess/0.16, hwloc/2.2.0, libevent/2.1.12, UCX/1.9.0, libfabric/1.11.0, PMIx/3.1.5, GCC/10.2.0, CUDA/11.3.1, OpenMPI/4.0.5, GCC/10.2.0, OpenMPI/4.0.5, CUDA/11.3.1, OpenMPI/4.0.5 unloaded.
Module GCCcore/10.2.0zlib/1.2.11binutils/2.35numactl/2.0.13XZ/5.2.5libxml2/2.9.10libpciaccess/0.16hwloc/2.2.0libevent/2.1.12UCX/1.9.0libfabric/1.11.0PMIx/3.1.5GCC/10.2.0CUDA/11.3.1OpenMPI/4.0.5GCC/10.2.0OpenMPI/4.0.5CUDA/11.3.1OpenMPI/4.0.5 loaded.
sbatch run_colabfold_AF2Mv2_unpaired_paired_Human_Barabasi_top_signi_predicted_missing_links_dms.sh 4
Submitted batch job 31762849
WARNING: You are welcome to use the default MSA server, however keep in mind that it's a limited shared resource only capable of processing a few thousand MSAs per day. Please submit jobs only from a single IP address. We reserve the right to limit access to the server case-by-case when usage exceeds fair use.
If you require more MSAs:

You can precompute all MSAs with colabfold_search or

You can host your own API and pass it to --host-url
2022-12-10 12:23:38,061 Running colabfold 1.3.0 (7ebcbe62e8d88400b0e75aa0878dce2ff3a6c71f)
2022-12-10 12:23:38,929 --max-msa can not be used in combination with AlphaFold2-multimer (--max-msa ignored)
2022-12-10 12:23:41,743 Found 7 citations for tools or databases
2022-12-10 12:23:45,211 Query 1/1: O60674_P08581 (length 2522)
0%|          | 0/300 [elapsed: 00:00 remaining: ?]
SUBMIT:   0%|          | 0/300 [elapsed: 00:00 remaining: ?]
SUBMIT:   0%|          | 0/300 [elapsed: 02:07 remaining: ?]
2022-12-10 12:25:52,518 Could not get MSA/templates for O60674_P08581: HTTPSConnectionPool(host='api.colabfold.com', port=443): Max retries exceeded with url: /ticket/msa (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b0fd6a80790>: Failed to establish a new connection: [Errno 110] Connection timed out'))
Traceback (most recent call last):
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connection.py", line 175, in _new_conn
(self._dns_host, self.port), self.timeout, **extra_kw
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/util/connection.py", line 95, in create_connection
raise err
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/util/connection.py", line 85, in create_connection
sock.connect(sa)
TimeoutError: [Errno 110] Connection timed out

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connectionpool.py", line 710, in urlopen
chunked=chunked,
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connectionpool.py", line 386, in _make_request
self._validate_conn(conn)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connectionpool.py", line 1042, in _validate_conn
conn.connect()
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connection.py", line 358, in connect
self.sock = conn = self._new_conn()
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connection.py", line 187, in _new_conn
self, "Failed to establish a new connection: %s" % e
urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPSConnection object at 0x2b0fd6a80790>: Failed to establish a new connection: [Errno 110] Connection timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/adapters.py", line 499, in send
timeout=timeout,
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/connectionpool.py", line 788, in urlopen
method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/urllib3/util/retry.py", line 592, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='api.colabfold.com', port=443): Max retries exceeded with url: /ticket/msa (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b0fd6a80790>: Failed to establish a new connection: [Errno 110] Connection timed out'))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/colabfold/batch.py", line 1429, in run
host_url,
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/colabfold/batch.py", line 860, in get_msa_and_templates
host_url=host_url,
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/colabfold/colabfold.py", line 140, in run_mmseqs2
out = submit(seqs_unique, mode, N)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/colabfold/colabfold.py", line 80, in submit
res = requests.post(f'{host_url}/{submission_endpoint}', data={'q':query,'mode': mode})
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/api.py", line 115, in post
return request("post", url, data=data, json=json, **kwargs)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/api.py", line 59, in request
return session.request(method=method, url=url, **kwargs)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/sessions.py", line 587, in request
resp = self.send(prep, **send_kwargs)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/sessions.py", line 701, in send
r = adapter.send(request, **kwargs)
File "/lustre/ssd/ws/iabdelha-IA-AF-SSD-workspace/alphafold/data/colabfold_batch/colabfold-conda/lib/python3.7/site-packages/requests/adapters.py", line 565, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='api.colabfold.com', port=443): Max retries exceeded with url: /ticket/msa (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x2b0fd6a80790>: Failed to establish a new connection: [Errno 110] Connection timed out'))
2022-12-10 12:25:52,525 Done

Is it related to https://github.com/YoshitakaMo/localcolabfold/issues/114 ?