Feature check: global log

Would you consider a PR that implemented support for globally defaulting log to something other than process.stderr? The way I’d expect this to work is debug would default to stderr unless process[Symbol.for(‘DEBUG_LOG’)] was set. Of course the local self.log would always take precedence.
The motivation for this feature is to allow an application to redirect all debug output to a logger of its choice, without knowing which all dependencies utilize debug.
I’ve chosen a global Symbol to circumvent the issue of multiple versions of debug in codebase.
Happy to submit this. Thoughts?

It might be much more practical to just have a top level function on the debug instance. However, it's usually an anti-pattern to modify a package's state in a way that affects other packages.
EventEmitters are a good candidate here, too.
const debug = require('debug');

debug.on('log', msg => writeToSomeStream(msg));

The problem with both of these solutions, is I need to know/iterate all of my dependencies that support debug and set up a listener or call a function on each of their debug instances.
The goal is to re-direct all debug output to a stream other than stdout. An example of why this is useful: to wrap log statements in a structured document so they're coalesced in a log management system, rather than having the messages parsed by line, which makes the debug output completely unreadable in any system other than console or a console redirect.

Right now it's going to stderr FWIW. Also, why not just use shell redirection?
I still think a top-level function that receives all of the raw output (that defaults to console.error()) would solve your problem.

Yes, stderr, thank you. Shell redirection offers no way to correlate multiple lines. For example, if one debug.log call results in 3 lines being written to stderr, I have no way of correlating them there. If I can redirect in-process, to something like Bunyan, then all three lines are correlated by virtue of the fact that they're in a single structured (JSON) document by the time they reach stderr or stdout.
If I have 3 modules, all using debug, that I authored, and I require them into my application - how do I instruct all three modules to output to my top level function?
I can appreciate that you think it's an anti-pattern; however, all I'm trying to do is control how my application handles debug output. If anything here is an anti-pattern, it's the fact that a dependency is outputting to stderr and there's nothing my application, which should govern all I/O, can do about it.
If this is out-of-scope for debug, that's fine. The reason I opened the issue prior to writing a PR was to suss out the receptiveness.

You wouldn't, it'd be a top level function that belongs to the module itself.

Ok; happy to implement this if this is something that you’d consider, but I’m getting the feeling you consider this to be an anti-pattern.
Let me know if you decide otherwise.

Definitely something I'm considering. I have an idea on how this will happen - stay tuned.

Within the discussion of #644 the idea of using node -r was brought up. I might be a bit biased, but I think it's a novel way of solving this problem.
Similar to SLF4J, adding log handlers at the end user level is becoming a common theme among use cases (see the closed issues above this comment). I think we should solve it as such.
I think adding a global log handler would be ideal, allowing extensions that use node -r to plug into it before the application is run.
Take the following example implementation:
// debug.js
let handler = (ns, msg) => console.error(`\x1b[2m${ns}\x1b[m`, msg);

const debug = ns => {
	return msg => handler(ns, msg);
};

debug.setHandler = _handler => {
	handler = _handler;
};

module.exports = debug;

// handler.js
const debug = require('./debug');
debug.setHandler((ns, msg) => console.error(JSON.stringify({
	namespace: ns,
	message: msg
})));

// index.js
const debug = require('./debug')('foo:bar');

debug('hello, world!');
debug({foo: 'bar'});

$ node index.js
foo:bar hello, world!
foo:bar { foo: 'bar' }

$ node -r ./handler.js index.js
{"namespace":"foo:bar","message":"hello, world!"}
{"namespace":"foo:bar","message":{"foo":"bar"}}

This solves a lot of the problems, features and pains users have felt for a while. Coupled with #644, this could be a large step forward whilst being backward compatible (with a default compatibility handler for the time being).
Thoughts?

The node -r option is a nice to have, but orthogonal to the issue raised here and proposed solution. What you’re suggesting would certainly solve the situation we’ve found ourselves in. And would remove some hacky code we’ve had to put in to patch this behavior. 👍

They would go hand in hand @jasonpincin. :)

@Qix- I believe this is relevant here so I'll post it as a comment instead of a new issue (let me know if you'd rather have it as a separate issue though)
I'm trying to stream all debug messages generated in a server via a websocket, is there an elegant way to listen to all messages sent to debug so that I can stream them, but still having them reported in the usual way (stdout)?

No, not elegant or "correct". That's exactly what this issue would solve.

@Qix- Thanks for the quick reply! So I guess the only non-hacky way will be to wait for the release of v5, I'll keep an eye on it!

Yes, sadly :| I have some vacation coming up and hope to knock out a ton of OSS that has built up.

I too am looking for a similar feature (and for node). Specifically I would like to be able to prepend all debug statements with some process-specific string that can later be used by AWS Cloudwatch Insights to parse log statements based on process-specific information.
For example, I would like to add a unique ID and process name to every debug statement and set this once in my application (not on every file). This makes it easy to filter multiple application's log statements (in AWS Log Insights) so I can see logging for just a a particular run of my process. Typically, an error would be reported by some mechanism (email) and filtering would allow me to see just the log statements that came in the same process just before the error line.
I would like to take this one step further and turn all log statements into a json string. This would give me some well-known structure for all debug statements in my specific application and that json makes it easy to filter in AWS Log Insights.
One thing to note is that I have a require debug in all my source code files and I do not want to modify each and every instance to have this data pre-pended.

@bodaro This would fit your use-case, but #582 is more what you'd be looking for.

RE: #582
If using the suggested #582 fix, In order to add a prefix to all log messages that is process specific, could I do something like this to set the ENV programmatically:
process.env.DEBUG_FORMAT=${process.env.PROCESS_UNIQ_ID} %N %m %D

@bodaro Yep, or just set it directly via DEBUG_FORMAT. Either way.

Doing a bit of poking around on this today, this appears to be soft-blocked by nodejs/node#40110. Not a deal-breaker but it'll be less than advantageous without allowing users to do this with ESM modules.
The other issue is code-based linkage. If you add a handler via code instead of pre-loading modules, then we'll run into the issue of libraries pre-loading their own handlers and causing unexpected output or mis-routed output (potentially) - something that, given the ubiquity of this package, simply won't do.
There needs to be a way to either prevent or disable added log handlers in application code.

Would you consider a PR that implemented support for globally defaulting log to something other than process.stderr? The way I’d expect this to work is debug would default to stderr unless process[Symbol.for(‘DEBUG_LOG’)] was set. Of course the local self.log would always take precedence.
The motivation for this feature is to allow an application to redirect all debug output to a logger of its choice, without knowing which all dependencies utilize debug.
I’ve chosen a global Symbol to circumvent the issue of multiple versions of debug in codebase.
Happy to submit this. Thoughts?

Tried a lot of installing it or reroute the repo but get 5he same results

2.6.8

I am sorry, but is there ANY solutions to users who trap into this module due to other modules using it who want debug information to be sent somewhere else? After 6 years of discussion I believe it might be time to look into at least something temporary instead of waiting for the most optimal, perfect solution

https://www.npmjs.com/search?q=logging


Authentication problems with GEE in Streamlit

First of all, thank you for sharing this awesom material.
I have a problem when adding a GEE leafmap in a deployed Streamlit app: it does not display. It asks for a code given by a webside, I have the code but there is no box where to paste it. How can I solve this problem?
Thank you!

You can find the token in the following file path:
Windows: C:\Users\USERNAME\.config\earthengine\credentials
Linux: /home/USERNAME/.config/earthengine/credentials
MacOS: /Users/USERNAME/.config/earthengine/credentials

Open the file and copy the token

Go to https://share.streamlit.io and set it as a secret for your app.

Thank you so much!


Add influx db component

This PR covers https://issues.apache.org/jira/browse/CAMEL-10066
So far it´s a producer only components, lets do iterations to improve it later.

Looks good to me. Can you rebase and maybe squash? I think improvements are possible. Also I don't understand why the documentation isn't automatically generated for this component..

Hi Andrea
I've rebased it will all the commits from master of camel. I've just realized I did not add the karaf features, I'll do it ASAP (this week) meanwhile let's review the other. I don't have a clue how to squash this thing.

To squash you just need to do:
git rebase -i HEAD~8

because you did the last 8 commits.
You should have a list of 8 commits with the pick instruction before.
Maintain pick for the first commit and change it to squash for all the other commits, then just save and add a unique commit message when asked for it.

Hi Andrea
But the last commit is a merge of camel trunk, that won't make your life (or whoever merges this into camel) harder?  see this one  Merge remote-tracking branch 'camel_upstream/master' into CAMEL-10066

The result should be just a single commit with a message like:
"Camel-10066 - Add an InfluxDB component"

So I believe it shouldn't be harder than now :-)

Here is a little guide about git squash
https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

Andrea,
I've run exactly the command you said, but I'd say this is not what you expected.

So maybe go back to the original PR, otherwise I'll try to understand what happened here.

Discarded by gitar hero.


Design data model for permissions (part 1)

Created by: @bayegan Oct 20 2021 at 02:29 CET
Last updated: Jul 18 2022 at 11:28 CET
ClickUp ID: IK-1667
Assigned in ClickUp to: Bohumil Pospíšil
Design data model for permissions according to huddle discussions. See https://drive.google.com/file/d/1NYy2h3Rw6nXH-Qr33Nep13W42mIsfHdv/view?usp=sharing for more information
Permission configuration: https://www.notion.so/Permissions-129e20063ae148c4a8eaa77bc78ca18e
Starting diagram in Miro: https://miro.com/app/board/o9J_kqVT93M=/?moveToWidget=3074457365203568644&cot=14
The design data model in Miro: https://miro.com/app/board/o9J_kqVT93M=/?moveToWidget=3074457365769592858&cot=14
New predefined permission groups - PlanPermission:
Authentication Editor
all permissions of AuthFlow, OAuth2Client, SAFRProvider
Customer, AppSpace, Tenant level
Editor
all permissions of all
Customer, AppSpace, Tenant level
OIDC Editor
all permissions of OAuth2App, OAuth2Provider
Customer, AppSpace level
Application Editor
all permissions of Agent, Application, Credential
Customer, AppSpace, Application level
Issue: How to support GUI and offer appropriate Permissions OR PlanPermissions on different levels.
New predefined PlanPermissions must be created by the definition in Wiki: https://www.notion.so/Permissions-129e20063ae148c4a8eaa77bc78ca18e
Existing predefined permission groups - PlanPermission:
MATCH (n:PlanPermission) RETURN n.name, n.actions ORDER BY n.name LIMIT 25
AppSpace Admin,"[AppSpace.READ,AppSpace.UPDATE,AppSpace.DELETE,Application.CREATE,Issuer.CREATE,EmailNotification.CREATE,AuthFlow.CREATE]"
AppSpace Administrator Permissions,null
Application Admin,"[Application.READ,Application.UPDATE,Application.DELETE]"
AuthFlow Admin,"[AuthFlow.READ,AuthFlow.UPDATE,AuthFlow.DELETE]"
Customer Admin,"[Customer.DELETE,Customer.READ,Customer.UPDATE,AppSpace.CREATE,EmailNotification.CREATE,AuthFlow.CREATE]"
EmailNotification Admin,"[EmailNotification.READ,EmailNotification.UPDATE,EmailNotification.DELETE]"
Issuer Admin,"[Issuer.READ,Issuer.UPDATE,Issuer.DELETE,Tenant.CREATE]"
Tenant Admin,"[Tenant.READ,Tenant.UPDATE,Tenant.DELETE]"
Existing predefined PlanPermissions must be revised.
Existing relationships
Existing relationships:
INHERITED_FROM between Permission and PlanPermission
CREATE between Permission and SchemaAppSpace
UPDATE between Permission and SchemaAppSpace OR Schema
READ between Permission and SchemaAppSpace OR Schema
DELETE between Permission and SchemaAppSpace OR Schema
Existing relationships INHERITED_FROM, CREATE, UPDATE, READ and DELETE must be revised.
Missing permissions are:
OAuth2Provider.CREATE
OAuth2Provider.DELETE
OAuth2Provider.READ
OAuth2Provider.UPDATE
Missing permissions must be added.
Impacted cypher queries are:
CreateConfigNodeAuthorizeCypher
ReadUpdateDeleteConfigNodeAuthorizeCypher
ListDocumentsAuthorizeCypher
ListCustomersAuthorizeCypher
...
Impacted cypher queries must be modified.
ListDocumentsAuthorizeCypher
...
CreateConfigNodeAuthorizeCypher
...
ReadUpdateDeleteConfigNodeAuthorizeCypher
...
ListCustomersAuthorizeCypher
...
...
Attachment(s):
https://github.com/indykite/clickup-attachments/blob/master/8c8f9a98-ecf3-47d8-b100-7900f899c291.xlsx

Commented by: @bayegan Oct 20 2021 at 14:09 CET
cc @marvinkite


endpoint: clean up exposure of functions / remove unneeded functions

This change is

test-me-please

Coverage decreased (-0.01%) to 43.995% when pulling 2051c69a1fcfcac415e4eb0e726b4a297015e365 on pr/ianvernon/moar-endpoint-cleanup into a3f76386742b8f5b619413d0c12243e42defcf58 on master.


ES 2.x

This provides support for Elasticsearch 2.x. It's currently setup to use 2.1.1 (the latest), but any 2.x should work fine.
(I can't get all specs to run locally, so any help testing would be much appreciated. I don't believe there are any failures... I'm just missing a config somewhere. [Storage$] Required repository (METADATA) configuration is missing.)

This compiles, but I get Exception in thread "main" java.lang.NoClassDefFoundError: org/joda/time/base/BaseInterval at runtime.
replacing the ShadeRule with this one:
ShadeRule.rename("org.joda.time.base.**" -> "shadeio.@1").inLibrary("org.elasticsearch" % "elasticsearch"  % elasticsearchVersion.value).inProject
resolves it. Please make that change, thanks.

@EmergentOrder thanks for the fix.

testing indicates a silent failure during training, which is probably because the write to ES using Spark requires an upgrade of the ES-Hadoop lib, from the docs: "ES-Hadoop 2.2.x and higher are compatible with Elasticsearch 1.X and 2.X" See discussion here: https://github.com/elastic/elasticsearch-hadoop
Looks like you can try 2.2.0-rc1https://github.com/elastic/elasticsearch-hadoop#beta-release-currently-220-rc1

I didn't think ES-Hadoop was a dependency in PIO. Not seeing it required anywhere...

ES-Hadoop is not a dependency of PIO proper, but rather of Universal Recommendation Template

I don't see a dependency in the template. Do you mean the server needs ES-Hadoop installed for UR to work with ES 2.x? Why not with ES 1.x?

in the UR build.sbt
"org.elasticsearch" % "elasticsearch-spark_2.10" % "2.1.0.Beta4"
  exclude("org.apache.spark", "spark-catalyst_2.10")
  exclude("org.apache.spark", "spark-sql_2.10"),

The upcoming v0.3.0 uses v 2.1.2. This is a packaging of ES-hadoop that includes only the Spark deps.

Ah, got it. Thanks! I'll test out an updated build shortly.
On Fri, Jan 15, 2016 at 7:53 AM Pat Ferrel<EMAIL_ADDRESS>wrote:

in the UR build.sbt
"org.elasticsearch" % "elasticsearch-spark_2.10" % "2.1.0.Beta4"
exclude("org.apache.spark", "spark-catalyst_2.10")
exclude("org.apache.spark", "spark-sql_2.10"),
The upcoming v0.3.0 uses v 2.1.2. This is a packaging of ES-hadoop that
includes only the Spark deps.
—
Reply to this email directly or view it on GitHub
https://github.com/PredictionIO/PredictionIO/pull/195#issuecomment-171966505
.

btw we noticed that it seems to be very fast, wonder if you see any speed improvement.

Is there any documentation on getting tests to run? I'd like to be able to run the suite, but I get an error ([Storage$] Required repository (METADATA) configuration is missing.).

Try this before run sbt test:
$ set -a
$ source conf/pio-env.sh
$ set +a
there are some development notes in README of https://github.com/PredictionIO/PredictionIO/tree/develop/data . it would be great if you could help update it too if you see anything unclear.

Thanks. I just get one failure.
[info] EngineSuite:
[info] - Engine.train
[info] - Engine.train persisting PAlgo.Model
[info] - Engine.train persisting LAlgo.Model
[info] - Engine.train persisting P&NAlgo.Model
[info] - Engine.prepareDeploy PAlgo
[info] - Engine.eval *** FAILED ***
[info]   java.lang.IllegalStateException: Cannot call methods on a stopped SparkContext.
[info] This stopped SparkContext was created at:
[info]
[info] org.apache.spark.SparkContext.<init>(SparkContext.scala:147)
[info] io.prediction.workflow.SharedSparkContext$class.beforeAll(BaseTest.scala:65)
[info] io.prediction.controller.EngineSuite.beforeAll(EngineTest.scala:18)
[info] org.scalatest.BeforeAndAfterAll$class.beforeAll(BeforeAndAfterAll.scala:187)
[info] io.prediction.controller.EngineSuite.beforeAll(EngineTest.scala:18)
[info] org.scalatest.BeforeAndAfterAll$class.run(BeforeAndAfterAll.scala:253)
[info] io.prediction.controller.EngineSuite.run(EngineTest.scala:18)
[info] org.scalatest.tools.Framework.org$scalatest$tools$Framework$$runSuite(Framework.scala:444)
[info] org.scalatest.tools.Framework$ScalaTestTask.execute(Framework.scala:651)
[info] sbt.TestRunner.runTest$1(TestFramework.scala:76)
[info] sbt.TestRunner.run(TestFramework.scala:85)
[info] sbt.TestFramework$$anon$2$$anonfun$$init$$1$$anonfun$apply$8.apply(TestFramework.scala:202)
[info] sbt.TestFramework$$anon$2$$anonfun$$init$$1$$anonfun$apply$8.apply(TestFramework.scala:202)
[info] sbt.TestFramework$.sbt$TestFramework$$withContextLoader(TestFramework.scala:185)
[info] sbt.TestFramework$$anon$2$$anonfun$$init$$1.apply(TestFramework.scala:202)
[info] sbt.TestFramework$$anon$2$$anonfun$$init$$1.apply(TestFramework.scala:202)
[info] sbt.TestFunction.apply(TestFramework.scala:207)
[info] sbt.Tests$.sbt$Tests$$processRunnable$1(Tests.scala:239)
[info] sbt.Tests$$anonfun$makeSerial$1.apply(Tests.scala:245)
[info] sbt.Tests$$anonfun$makeSerial$1.apply(Tests.scala:245)
[info]
[info] The currently active SparkContext was created at:
[info]
[info] (No active SparkContext.)
[info]   at org.apache.spark.SparkContext.org$apache$spark$SparkContext$$assertNotStopped(SparkContext.scala:106)
[info]   at org.apache.spark.SparkContext.defaultParallelism(SparkContext.scala:2086)
[info]   at org.apache.spark.SparkContext.parallelize$default$2(SparkContext.scala:728)
[info]   at io.prediction.controller.Engine0$PDataSource2$$anonfun$readEval$2.apply(SampleEngine.scala:69)
[info]   at io.prediction.controller.Engine0$PDataSource2$$anonfun$readEval$2.apply(SampleEngine.scala:65)
[info]   at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
[info]   at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
[info]   at scala.collection.immutable.Range.foreach(Range.scala:141)
[info]   at scala.collection.TraversableLike$class.map(TraversableLike.scala:244)
[info]   at scala.collection.AbstractTraversable.map(Traversable.scala:105)
[info]   ...

@pferrel -- I haven't had a chance to benchmark yet. I'm stuck on an engine registration issue: https://groups.google.com/forum/#!topic/predictionio-user/sVzM6z_eaCY

The test failure you are seeing is unrelated, fixed in PR #199

:+1: passing now.

I can't tell if my UR engine issue is related to ES 2.x or not. I'm a bit stumped on it. https://groups.google.com/forum/#!topic/predictionio-user/sVzM6z_eaCY

Any chance this will get merged soon? Any blockers I can help with?

I've used it in production for a year now. There aren't any issues I'm aware of.

@voran the reason this hasn't been merged is that ES 2.x libs are not built into Apache PIO. The previous version of ES in the 1.7.x line will need support for some time to come so we need to build for both. That means an sbt option for building 2 artifacts.
Also ES doesn't like the way sparkConf if used in engine.json so all Spark params must be possible to pass in on the command line. I think this works for all I know of so it means disabling a feature.
@jramos has not updated this PR for Apache PIO so it would need a little work, mostly in changing the PIO namespace to org.apache.predictionio as per the conflicts above. So to use it with Apache PIO you'd need to make those mods.

@jramos hi, please check possible negative effects on performance about use queries in exchange of
filters in elasticsearch:
https://www.elastic.co/guide/en/elasticsearch/guide/current/_queries_and_filters.html#_performance_differences

As a general rule, use query clauses for full-text search or for any condition that should affect the relevance score, and use filters for everything else.

@jorelcb To support ES 5.x, we are working on PIO-49.
https://github.com/apache/incubator-predictionio/pull/195 will be closed.
For query tuning, I'll check it after https://github.com/apache/incubator-predictionio/pull/358 is merged.


Invalid verilog generated for 0-bit Signals

Consider this minimal example:
from amaranth import *
from amaranth.back import verilog

class Foo(Elaboratable):
    def __init__(self):
        self.bar = Signal(0)
        self.baz = Signal(1)

    def elaborate(self, platform):
        m = Module()
        m.d.comb += self.baz.eq(self.baz > self.bar)
        return m

foo = Foo()
print(verilog.convert(foo, ports=[foo.bar, foo.baz], strip_internal_attrs=True))

This outputs:
/* Generated by Amaranth Yosys 0.10.0 (PyPI ver 0.10.0.dev46, git sha1 dca8fb54a) */

module top(baz);
  wire \$1 ;
  output baz;
  assign \$1  = baz > "";
  assign baz = \$1 ;
endmodule

This fails to verilate because "" is not a valid verilog identifier.
Tested on Python 3.10.7 + amaranth 392ead8d00c9a130b656b3af45c21fa410268301

This was due to using ancient version of amaranth-yosys.

This was due to using ancient version of amaranth-yosys and issue was resolved by updating to latest version.

Could you let me know how you ended up in that position? There is a version constraint on amaranth-yosys; did that not work with your installation method?

We have amaranth-yosys pinned to a specific version that hasn't been updated in ages and install with pip.

Ah, this looks to be a bug in Amaranth, as the version you have is expressly permitted. Fortunately there is already an open bug about this (https://github.com/amaranth-lang/amaranth/issues/931) so this will get fixed in time for the next release.


SVG is not defined when attempting to render a chart using jsdom with jest

Description

Steps to Reproduce

Install dependencies according to the package.json

{   "name": "apex-js-test",   "version": "1.0.0",   "description": "",   "main": "index.js",   "scripts": {     "test": "jest"   },   "keywords": [],   "author": "",   "license": "ISC",   "dependencies": {     "apexcharts": "^3.35.3"   },   "devDependencies": {     "@babel/preset-env": "^7.18.6",     "babel-jest": "^28.1.3",     "jest": "^28.1.3",     "jest-environment-jsdom": "^28.1.3"   } }

create a simple test to render a chart using jsdom
// myapex.js
`
import ApexCharts from 'apexcharts';
import uppercase from './uppercase.js';

console.log(uppercase('hello in myapex'));
var options = {
chart: {
type: 'bar'
},
series: [{
name: 'sales',
data: [30, 40, 45, 50, 49, 60, 70, 91, 125]
}],
xaxis: {
categories: [1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999]
}
}
var chart = new ApexCharts(document.querySelector("#chart"), options);
export default chart;
//chart.render();
`
// myapex.test.js
`/**

@jest-environment jsdom
*/

import chart from './myapex.js';
test('use jsdom in a test file', () => {
const element = document.createElement('div');
element.id = 'chart';
//const root = global.document.getElementById('root');
document.body.appendChild(element);

chart.render();

const mychart = document.getElementById("chart");
//const other = global.document.getElementsByTagName('p');

console.log('************');
//console.log(`Root is ${root}`);
console.log(`Object is  ${mychart}`);
console.log(`Length is  ${document.getElementsByTagName('*').length}`);
//expect(mychart).toHaveLength(1);
//expect(mychart.length).toBeGreaterThan(0);
expect(mychart).not.toBeNull();

});`

Here is my jest.confing.js

`// Sync object
/** @type {import('@jest/types').Config.InitialOptions} */
const config = {
verbose: true,
displayName: {
name: 'RODSTEST',
color: 'blue',
},
testEnvironment: 'jsdom',
testEnvironmentOptions: {}
};
module.exports = config;`

run npm test

Expected Behavior
Render succeeds with no errors
Actual Behavior
SVG is not defined error (on codesandbox)
locally: (node:14527) UnhandledPromiseRejectionWarning: Error: Element not found
(Use node --trace-warnings ... to show where the warning was created)
(node:14527) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:14527) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Screenshots

Reproduction Link
reproduction link

I am also having this issue. Is there a workaround for getting apexcharts to work with jest?

I am seeing the same issue (using Cucumber rather than Jest).
I've found it's coming from v2.0.2 of svg.filter.js because it's not getting and setting SVG explicitly on window so I guess because it's running outside of a Browser it doesn't assign top-level variables to window automatically as the library expects/assumes.
There is an updated version of svg.filter.js but it's designed for svg.js v3 so we'd need to upgrade both of them together, plus all of the other svg.js plugins. It looks like that would be a monumental effort because svg.js has been baked-in to repo and modified over time so that's probably best left alone.
The only way I can see this being fixed without a lot of headache is to move the svg.filter.js code into this repo in the same way it's been done for svg.js and prefix all the references to SVG with window.. I'll look to get a PR open and see how well this idea goes down.

In my case I use the excalidraw library and I notice it only brakes when i load the excalidraw board before rendering the chart


zulip: Respect NIXOS_OZONE_WL to enable Wayland mode

Description of changes
Chrome and various Electron apps in nixpkgs respect the NIXOS_OZONE_WL=1 environment variable to enable native Wayland mode. Add this to Zulip Desktop as well.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2507


[type: refactor] change class name

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2596 (9f0f3a8) into master (0f9fe44) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2596      +/-   ##
============================================
+ Coverage     60.83%   61.16%   +0.32%
- Complexity     4217     4230      +13
============================================
  Files           651      652       +1
  Lines         18410    18489      +79
  Branches       1657     1650       -7
============================================
+ Hits          11200    11308     +108
+ Misses         6332     6270      -62
- Partials        878      911      +33

Impacted Files
Coverage Δ

...in/base/condition/judge/ExcludePredicateJudge.java
100.00% <100.00%> (ø)

...a/org/apache/shenyu/admin/config/MapperConfig.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...pache/shenyu/admin/transfer/ConditionTransfer.java
56.09% <0.00%> (-21.96%)
:arrow_down:

...che/shenyu/admin/service/impl/RuleServiceImpl.java
82.85% <0.00%> (-12.85%)
:arrow_down:

...yu/admin/service/impl/PluginHandleServiceImpl.java
82.22% <0.00%> (-10.81%)
:arrow_down:

...a/org/apache/shenyu/common/enums/OperatorEnum.java
90.00% <0.00%> (-5.46%)
:arrow_down:

.../apache/shenyu/web/handler/GlobalErrorHandler.java
81.81% <0.00%> (-3.90%)
:arrow_down:

...enyu/admin/service/impl/ShenyuDictServiceImpl.java
96.15% <0.00%> (-3.85%)
:arrow_down:

...shenyu/admin/service/impl/SyncDataServiceImpl.java
93.10% <0.00%> (-0.45%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
62.76% <0.00%> (-0.40%)
:arrow_down:

... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f9fe44...9f0f3a8. Read the comment docs.


Stop counting pci device with number 30

The pci slot value is defined as the range from 0 to 31. And if the LPC needs to be hard coded to "-s 31,lpc", we have to stop counting PCI devices with number 30

Nice catch!


Update driver version during build time

Describe what this PR does
update driver version and add git commit to the container image. This will help us to identify what latest git commit image contains.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>Related issues
Fixes: #462

logs after  building
[🎩]mrajanna@localhost ceph-csi $]make
cephcsi image settings: quay.io/cephcsi/cephcsi version canary
if [ ! -d ./vendor ]; then dep ensure -vendor-only; fi
CGO_ENABLED=0 GOOS=linux go build -a -ldflags ' -X github.com/ceph/ceph-csi/pkg/util.GitCommit=0d566ee30c9519c37cc047b6267272362de8051b -X github.com/ceph/ceph-csi/pkg/util.DriverVersion=canary -extldflags "-static"' -o  _output/cephcsi ./cmd/
[🎩]mrajanna@localhost ceph-csi $]
[🎩]mrajanna@localhost ceph-csi $]_output/cephcsi
I0712 15:49:59.367607     392 cephcsi.go:96] Driver version canary and Git version: 0d566ee30c9519c37cc047b6267272362de8051b
F0712 15:49:59.367654     392 cephcsi.go:101] driver type not specified

Timedout. I am merging this PR.


update livereload js version

use go mod
update livereload.js version 3.4.1
embed livereload.js file

Changes applied in https://github.com/jaschaephraim/lrserver/releases/tag/v3.1.0
Thank you for your contribution!


Implement VPN process restart mitigation for internal builds

Task/Issue URL: https://app.asana.com/0/0/1201677777496579/f
Description
This PR implements the VPN process restart mitigation and does it ONLY for specific bad health alerts, ie. TUN Write IO exceptions caused by insufficient buffer memory.
The PR does three main things:

Differentiates between no buffer space available TUN Write IO exceptions and the rest
Adds the notion of Critical bad healt (for the type of exception above)
Implements a VPN process restart upon critical bad health only for internal builds
Adds a button to the diagnostics screen to simulate/test critical bad health

Steps to test this PR
Test VPN process restart

[ ] Install from this branch the internal build
[ ] Launch app and enable AppTP
[ ] Filter logcat by m_atp_did_restart_vpn
[ ] Go to diagnostics settings
[ ] Click on BAD HEALTH button
[ ] Wait until VPN restarts
[ ] Verify the m_atp_did_restart_vpn_process_on_bad_health_c/d is NOT sent
[ ] Verify the m_atp_did_restart_vpn_on_bad_health_c/d is sent
[ ] Click on CRITICAL HEALTH
[ ] Wait until VPN process restarts (Diagnostics screen should be killed)
[ ] Verify the m_atp_did_restart_vpn_process_on_bad_health_c/d is sent
[ ] Verify the m_atp_did_restart_vpn_on_bad_health_c/d is NOT sent

Inspect code to ensure the VPN process mitigation only happens in internal builds

[ ] Go to AppBadHealthStateHandler#restartVpn method
[ ] Double check the Runtime.getRuntime().exit(0) will only happen in internal builds

Current dependencies on/for this PR:

develop

PR #1731   (this PR)

This comment was auto-generated by Graphite.


[Yii::t + DbMessageSource] Rework

Perhaps there was already such a task
What steps will reproduce the problem?
Add a table with language
id
code -> ru, en, fr
locale -> ru-Ru, en-En, en-Us, fr-Fr ...
name -> Русский, English, USA, France
status -> use or not use
This table is needed to enable the user to select the language. In fact, now it needs to be hardcoded.
Change the table accordingly message
alter language on language_id
It is possible, but not necessary to modify the source_message table. Add category table and add Key to source_message table.
Where is the Key, this is the Key for the message field.
Let's say there is a long text, it is contained in the message field:
"Address sold jointure wicket supported home drift. Tried rest among long elinor the. Pleased polite resolve perpetual. Terminated full green seven ought instantly belonging some uncommonly absolute rejoiced nor the. Barton supposing engaged ferrars denote secure dwelling daughter. "
And the key to this text may be the first few words:
Yii::t('frontend/main', '...Address sold jointure wicket...')

Let's say to indicate a key, you can frame it with three dots.
I will try to implement it myself. But it would be nice to have it in the standard delivery of the framework.
Thank you!
What is the expected result?
What do you get instead?
Additional info

Q
A

Yii version
2.0.

PHP version
7.4

Operating system
Windows

Perhaps there was already such a task
What steps will reproduce the problem?
Add a table with language
id
code -> ru, en, fr
locale -> ru-Ru, en-En, en-Us, fr-Fr ...
name -> Русский, English, USA, France
status -> use or not use
This table is needed to enable the user to select the language. Now it needs to be hardcoded.
Change the table accordingly message
alter language on language_id
It is possible, but not necessary to modify the source_message table. Add category table and add Key to source_message table.
Where is the Key, this is the Key for the message field.
Let's say there is a long text, it is contained in the message field:
"Address sold jointure wicket supported home drift. Tried rest among long elinor the. Pleased polite resolve perpetual. Terminated full green seven ought instantly belonging some uncommonly absolute rejoiced nor the. Barton supposing engaged ferrars denote secure dwelling daughter. "
And the key to this text may be the first few words:
Yii::t('frontend/main', '...Address sold jointure wicket...')

Let's say to indicate a key, you can frame it with three dots.
I will try to implement it myself. But it would be nice to have it in the standard delivery of the framework.
Thank you!
What is the expected result?
What do you get instead?
Additional info
Q	A
Yii version	2.0.
PHP version	7.4
Operating system	Windows

And in the source_message table, instead of @@ add the status field
status -> use or not use
Or date_delete field

I'm not sure what would you like to add exactly. The first table you are talking about depends in total on the business logic of your application so it should not be a part of framework. As for the "shortened" key for the message you can use it like that already if I'm not mistaken (please correct me if so) - just use some arbitrary unique string in Yii::t() for it and force app to translate it with forceTranslation set to true.

forceTranslation - As far as I know it works for PhpMessageSource
For example:
return  [
'NAV_ITEM_USERS' => 'Users',
    'NAV_ITEM_ROLES' => 'Roles',
    'NAV_ITEM_REF' => 'Lists',
];

Yii::t('app', 'NAV_ITEM_USERS');

DbMessageSource (like PhpMessageSource) extends MessageSource where this is defined.

As @bizley said, one part of the issue is about application logic, another is possible by forcing translation and using keys instead of source messages in Yii::t().


Install with pipenv fails for version 1.0.3

On Debian in a Dockerfile with Pipfile:
RUN pip install pipenv && pipenv install
with cftime = "*" in Pipfile
results in:
pipenv.patched.notpip._internal.exceptions.InstallationError: Command "python setup.py egg_info" failed with error code 1 in /tmp/tmp3dy86zfkbuild/cftime/
Version 1.0.0 or also <IP_ADDRESS> does not have this problem.
Installation with pip install cftime works for both versions.

@gdetrez I can confirm that it's workign when I make
pipenv install Cython && pipenv install`
However, this should not be necessary as it goes against the principle of a pipfile


Update Project Isolation documentation page

[ ] Add information about our current plans, known caveats, get rid of mixed terminology, etc
[ ] Move it together with the rest of the documentation (without linking to it from anywhere just yet)

Moved to 8.10 RC1.
If this was delivered with 8.9, please close and update the milestone.

We need to make sure the updated page contains the words "project isolation" verbatim.
Even though we decided to go with the "Isolated Projects" name for the feature, folks outside Gradle who are aware of it keep calling it "project isolation". To me this is a signal we'll never get away from people referring to the feature like this.
We did discuss that "project isolation" is something the users will do to make their build IP compatible. So it can fit naturally in one of the first paragraphs on the page.
FWIW, search engines today show the right result for googling "gradle project isolation", but I'd like us to have the alternative spelling in clear text.
For the record, our own in-docs search shows nothing relevant with the "project isolation" lookup


Mostly functional energy pattern parsing & printing

Created classes & updated existing methods to parse, store, and use energy patterns from BNG output

The docstring for class EnergyPattern isn't perfect, but other than that it seems to be working as intended


Track played multiple times, but scrobble only one time

Hello!
In my device (Galaxy Mega 5.8 + default player), when I played track multiple times, data is sent only one playing. Why?
Thanks u in advance!

@SAOPP
@Pichu0102
If you know how download and build the .apk
Please use this branch https://github.com/tgwizard/sls/tree/testing-149
Otherwise you can use the latest .apk here.
https://drive.google.com/file/d/0B9lPaMaVVtiJLVlLendjSmxRZDA/view

Triplicate continue discussion in #155

@SAOPP
@Pichu0102
https://drive.google.com/file/d/0B9lPaMaVVtiJYTVVVDR4YkU1QUU/view?usp=sharing
This is a beta testing version. Let me know if it solves your problem.
It has a different key so you'll have to uninstall and setup SLS again.

Hi. Thanks u for continue developing... 4 me this problem is not actual, coz I use Poweramp. With this player scrobling working is ok. So thank u again. My old request need to test. Peace.


Checks did not release at end of game

Describe the bug
After defeating the Hollow Knight (not sealed siblings or radiance ending) the remaining checks for the game had to be released manually through server command.
To Reproduce
Steps to reproduce the behavior:

Collected the 3 dreamers
Defeated The Hollow Knight (did not have void heart in inventory)
Watched final cutscene
Skipped credits
Returned to the main menu with no checks released

Expected behavior
Expected the checks to be released automatically after starting the final cutscene

Whether the game automatically releases is a server setting. So,

Was the server set to release automatically or allow !release after goal completion?
Did the text client log that you had completed your goal?
Was your goal in the yaml set to either hollow knight or any?

If the issue is not user error, a modlog is required to diagnose the issue.


Attention

The attention formula has an unusual line that puts attention weights through tanh.

Is this intentional?
What is the reason for this? Normalization/entropy control?
Do you have plans to open source an attention kernel that can support this?

they just dumped this model  to github and call it a day

Maybe rewrite the title of this issue to be more descriptive.

I guess it's there to avoid gradient explosion, or vanishing gradients.
Normalizing attention logits using tanh helps in controlling the gradients during the backpropagation process, as it avoids extreme values improving numerical stability.


Installation Instructions?

Where are the installation / integration instructions?

Is this what you are looking for?
https://utteranc.es/#heading-enable

@bender2k14 Looks like maybe probably. I'm probably accustomed to looking for the word "Installation".
So yeah, that looks like I can give that a go. What is the issue-term?

issue-term is the name of the key whose value specifies what the title should be for the issue that the utterance-bot creates in your GitHub repo when someone makes the first comment.  There are six options for the value, and they are givenhere via radio buttons.  Changing the selected radio button changes the value of issue-term below.


Fix TravisCI settings

This PR will close #8

ROS Melodic are not supported yet, so it is set as allow_failures.


[5.3.x] JGRP-2805 GossipRouter NPE on startup

https://issues.redhat.com/browse/JGRP-2805

merged! thanks @ryanemerson !


large firmware

This is not a bug but there is no discussion board that I can see,
How much non-firmware memory does the bootloader take?  I have a uf2 file of size 2,178,560 bytes on my computer. Is this too large for this bootloader to handle?

Can you please specify what do you mean by non-firmware memory?
Also, please keep in mind that the size of the uf2 file is not equal to the size of the generated binary (because of additional data it contains). You should check the size of the .bin file in order to make sure it fits the downlaod partition.

Sorry about the vagueness - by non-firmware memory, all the memory taken up by the bootloader (so I have some idea how much space is left and if my firmware can fit)

As specified in README, current configuration reserves 36k for the bootloader + 4k for the non-volatile configuration. The bootloader itself is smaller, but I've reserved 36k for future expansion (e.g. new functionalities). That's why Application and Download partitions take 1004k.

Bummer - my firmware bin file is 1064 kb


Write tests for all actions

Filter - Completed
AddColumn - Completed
AddMessage - Completed
ComplexLogic
CopyRows - Completed
CopyUserId - Completed
DbAction
JumpTo - Completed
Log- Completed
Logic - Completed
Loop (1 match)
RenameSheet - Completed
RowExists - Completed
CreateSheet - Completed
Suggest - Completed
Read - Completed
save-Completed
upload- Completed
download- Completed
readWithSql- Completed
executesql- Completed

Old task - closed


fix: drop use of deprecated allauth.utils.email_address_exists function

allauth.utils.email_address_exists was removed recently, see
https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#0550-2023-08-22

@alexei - Can you close this out then? With the changes that django-allauth made, we should also change the dependency requirements.

Cool


Dependabot break Yarn 2 lockfile

Package manager/ecosystem
JavaScript / Yarn 2
Manifest contents prior to update
package.json
{
  "devDependencies": {
    "caniuse-lite": "^1.0.30001102",
    ...
  },
  ...
}

https://github.com/KaTeX/KaTeX/blob/master/package.json
yarn.lock
"caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30000981, caniuse-lite@npm:^1.0.30001093, caniuse-lite@npm:^1.0.30001097, caniuse-lite@npm:^1.0.30001102, caniuse-lite@npm:^1.0.30001109":
  version: 1.0.30001109
...

https://github.com/KaTeX/KaTeX/blob/master/yarn.lock
Updated dependency
caniuse-lite 1.0.30001109 -> 1.0.30001110
What you expected to see, versus what you actually saw
1,10c1,3
<  # This file is generated by running "yarn install" inside your project.
< # Manual changes might be lost - proceed with caution!
<
< __metadata:
<   version: 4
<   cacheKey: 5
<
< "@babel/code-frame@npm:^7.0.0, @babel/code-frame@npm:^7.10.4":
<   version: 7.10.4
<   resolution: "@babel/code-frame@npm:7.10.4"
---
>  "<EMAIL_ADDRESS>"<EMAIL_ADDRESS>>   version "7.10.4"
>   resolved<EMAIL_ADDRESS>12,15c5
<     "@babel/highlight": ^7.10.4
<   checksum: 05245d3b22a3ae849439195c4ee9ce9903dfd8c3fcb5124e77923c45e9f1ceac971cce4c61505974f411a9db432949531abe10ddee92937a0a9c306dc380a5b2
<   languageName: node
<   linkType: hard
---
>     "@babel/highlight" "^7.10.4"

According to https://github.com/dependabot/dependabot-core/issues/1297,

For the default configuration of yarn v2 dependabot already updates versions correctly.

so this seems to be a regression and not a duplicate.
Images of the diff or a link to the PR, issue or logs
updater | INFO <job_44411994> Checking if caniuse-lite 1.0.30001109 needs updating
  proxy | 2020/08/04 13:08:17 GET https://registry.npmjs.org:443/caniuse-lite
  proxy | 2020/08/04 13:08:17 200 https://registry.npmjs.org:443/caniuse-lite
  proxy | 2020/08/04 13:08:18 GET https://registry.npmjs.org:443/caniuse-lite/1.0.30001110
  proxy | 2020/08/04 13:08:18 200 https://registry.npmjs.org:443/caniuse-lite/1.0.30001110
updater | INFO <job_44411994> Latest version is 1.0.30001110
  proxy | ...
updater | INFO <job_44411994> Requirements to unlock own
  proxy | 2020/08/04 13:13:11 GET https://registry.npmjs.org:443/katex
  proxy | 2020/08/04 13:13:11 200 https://registry.npmjs.org:443/katex
updater | INFO <job_44411994> Requirements update strategy widen_ranges
updater | INFO <job_44411994> Updating caniuse-lite from 1.0.30001109 to 1.0.30001110
  proxy | ...
updater | INFO <job_44411994> Submitting caniuse-lite pull request for creation

Duplicate of #2030.


Upgrade code to "guzzlehttp/guzzle": "~6.0"

As discussed in #34 , this will be done in version 2.0.


fix: add helm release module

:tada: This PR is included in version 1.2.15 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


KML: out-of-spec coordinates

The correct way to separate tuples in the coordinates field is to separate them with a space, but I saw some kml documents that used a comma instead:
<LineString>
   <coordinates>13.08925,37.517,0,13.0859,37.517,0</coordinates>
   <altitudeMode>relativeToGround</altitudeMode>
</LineString>

Google Earth parses them correctly, so is there any chance that this library will support this out-of-spec syntax?

So, I think we could parse this, but it's highly ambiguous. The altitude part of the tuple is optional, so if you have a list of 6 numbers separated by commas in this style, it could be 2 (longitude, latitude, altitude) positions or 3 (longitude, latitude) positions. And the only way to tell the difference is guessing, and it's unreliable to guess - the numbers can all be in the same general range.

Thanks, I did some testing and google earth seems to use the same logic I implemented here: https://github.com/HandyMenny/leaflet-kmz/commit/b45dd44a3cfe45c395d5398281ca9843f22554d6
That is, every 3 numbers is a new tuple, so altitude would no longer be optional (in that syntax)

So I guess the approach would be to first detect this invalid syntax, and then take the approach that altitude is mandatory? I wouldn't want to make altitude mandatory for all datasets, which would make valid data parse incorrectly.

Yes, that would be a correct approach.
But I would just check if a coordinate has more than 3 elements (maybe better 6) and if the number of elements is multiple of 3 (actually google earth handles also cases where this is not true, using components of the previous coordinate). In that case the coordinate is split into two or more coordinates. Then a flatMap() takes care of recreating an array of consecutive coordinates


Can't Open Quest Log

Module Version: 0.7.3
Describe the bug
Can't open the quest log
Screenshots

Browser:
Safari
Foundry Version: v0.8.8
Game System: DnD 5e 1.3.6

This is an interesting issue as it indicates quite likely something else is wrong external to Forien Quest Log.
The line that fails is if (actor.isGM) { continue; } indicating that there is an undefined user in game.users which are all the users (players & GMs).  I see that you are probably using many other modules as libwrapper is involved in the error stack. Can you try to turn off as many other modules as possible and see if the problem remains. The next thing to try is to create a new world and only install Forien Quest Log.
As mentioned the error stack and what is failing is not exactly an issue of FQL itself, but indicates another serious problem with your world and internal state of Foundry itself. There is a big possibility that turning off all other modules may not fix this issue for this particular world.
I have read of issues with something possibly to do with libwrapper on 0.8.8 that is still an unknown situation that is hard to reproduce about the internal state of Foundry being inconsistent or something like that. Not sure if it is libwrapper related or Foundry itself...

Gotcha. It might have been due to me deleting a user that was previously in the quest logs. I will try re-introducing the exact username to see if it fixes the issue or not. Thank you for your attention!

Yes.. This indeed is the issue and I have been able to reproduce it by setting a quest and thereby the backing journal entry with a specific permission for a user that is then deleted from the game. So this quite possibly is a bug in FQL. I was under the impression that the permissions returned from a document / journal entry would be correct for the game state and updated when a user is deleted, but it appears that permissions data is not updated in the Foundry DB when a user is deleted and so there can be stale data that one has to ignore.
I will certainly add in protection for this case in 0.7.4 which will launch shortly. Thanks so much for filing this issue as it's a corner case that I was not aware of presently.
In the meantime sadly adding a new user with the same name likely won't fix the issue as the internal ID of the old user is what is used in the lookup in game.users. If you can delete this quest / backing journal entry by showing the hidden _fql_quests journal entries folder and then deleting the journal entry then things will work again. On the version of FQL you are using FQL shouldn't try to load quest data until you actually show the quest log, so you should be able to access the module settings / show the _fql_quests journal entry folders and delete the journal entry for the quest that was assigned to the deleted user and things should work again.

Another thing you can do without deleting the quest is to explicitly set the permissions of the journal entry in question. Context click the journal entry and select set 'configure permissions' / hit save and that should fix things without needed to delete the quest.

Got it fixed.. Thanks again for the report. Let me know if you need any more info on how to fix things / workaround your current situation w/ FQL 0.7.3.. The latest 0.7.4 should be out in a couple of days.

Shipped in 0.7.4 which is not available.


CSV Field Values in the formatE### Cause Parser Hang

Issue Type: Bug

Create a fairly standard CSV file.
Create a field value in the format E### (where # is a number) such as E011 , E052, etc. For best results have this value as the first field.
Attempt to import the CSV file into a database. When it comes to the screen where the data is previewed there will be a hang.

I speculate that this bug is likely caused by the parser attempting to treat the field as a special character value or somesuch.
Azure Data Studio version: Azure Data Studio 1.0.0 (cab8f3e37c9ac4367e0dacef5185da08bd8021c2, 2018-09-20T21:41:50.803Z)
OS version: Darwin x64 18.2.0

Closing this issue as I cannot reproduce this on the latest version of the extension. If it is still happening to you, can you please share a sample csv file for it. Thanks!


[New Feature]: Verify PackageDependency property

Description of the new feature/enhancement
Currently, Tools/SandboxTest.ps1 and winget validate --manifest won't validate if PackageDependencies property is correct in the manifest. If the property is incorrect, it won't pass the Azure Validation Pipelines.
If this fault can be validated locally before testing locally or with Windows Sandbox in advance, it would be great. (It's easy to check without trying to install it, right?)
Proposed technical implementation details (optional)
Add a hidden winget search <PackageDependency> during running winget validate --manifest <path>.

i want to work on this. please assign me.

@denelon - Thoughts on making this a feature at winget-cli instead of here at pkgs? I'm thinking that for anything in PackageDependencies the winget validate -m <> command could quite easily query the available sources to see if it is available, and throw a manifest warning if no packages are found, rather than us trying to implement this logic into the sandbox script

@Trenly Thank you for reminding me this.
Yes, I think it's better implement this feature in winget-cli rather than in winget-pkgs. Tools/Sandbox.ps1 script also validate local manifest files with winget validate.


Onboarding improvements - slide animation & Next button

New UX improvements requested for the onboarding screens:
Updated Mocks:
Screen 1: https://zpl.io/aByNwQp
Screen 2: https://zpl.io/2jQm0ZO
Screen 3: https://zpl.io/2EBOlmD
Screen 4: https://zpl.io/bJWvON9
Requested changes:

Better sliding animation (in the LTR version, i.e. Arabic locale, the screen should actually slide from left to right. You should be able to see two screens — the previous & the next — if you slide and hold your finger in the middle) - like so: https://www.google.com/url?sa=i&source=images&cd=&ved=2ahUKEwiz07_hwe_jAhWqyVQKHfqeAjkQjRx6BAgBEAQ&url=https%3A%2F%2Fwww.pinterest.com%2Fpin%2F271060471297761525%2F&psig=AOvVaw1cJHbK1uBXSFp6NGCv7WBl&ust=1565224475651079
Right now when the user opens onboarding, it's a bit random and unclear that the Onboarding is Onboarding. Maybe this can be improved if the first sentence of the app screen is changed to: "Welcome to Arrival Advisor, your go-to guide to getting settled in your new community." @ArtiBPG I am open to other suggestions.
Move up the four dots at the bottom, they are easy to miss
Change the teal in the highlighted dot in onboarding - this was a mistake in the previous mocks. The right teal colour is "teal" - #00858F
Add a "Next" button to all the screens except the last screen which should say "Start".
Maybe replacing the "X" with "Skip"? I know @bensinjin had some feedback on this on the last issue and recommended the X for consistency, but I feel like "Skip" is clearer for users. I am however open to be challenged on this, and open to the idea that we use the X for now until we feel like there is a major usability issue calling for "Skip".
The "Close" button is positioned too closed to the corner of the screen. On IPhone X, it is positioned right underneath the status bar which makes it difficult to click on.

Originally posted by @cherrielam in https://github.com/pg-irc/pathways-frontend/issues/724#issuecomment-518894414
Acceptance Criteria

[x]  1. Sliding animation exists and functions appropriately for LTR and RTL
[ ]  2. Onboarding copy for the first screen is improved to make it more obvious that onboarding is onboarding.
[x]  3. Four dots on the bottom are moved up
[x]  4. Teal used in the dots is #00858F
[ ]  5. "Next" buttons are added to all screens, except the last screen which says "Start"
[x]  6. Decision made as to whether to keep the "X" or implement "Skip" button
[ ]  7. Reposition the "close" button away from the corner of the screen to avoid usability issue.

Assigning @ArtiBPG and @rasmus-storjohann-PG to review issue (as per discussion this morning at standup)

Review drop off rate before adding to sprint backlog

This will be addressed in the next release. We can re-use the the horizontal slide animation seen on the bookmarks screen for the onboarding page.

Hi @niko-pg ! Sorry this may be a bit late, we had some research done that recommended we should swap the bookmark step in the onboarding with the personalize step. So the current 2nd and 4th image/text in the onboarding should swap pages. Are you able to do so? Much appreciated!

Thanks @cherrielam, updated my PR to account for your requested change.

Tested on Staging V1.26.0, Server V1.3.25 on iOS 7 plus:
Acceptance Criteria:

[x] Sliding animation exists and functions appropriately for LTR (Arabic) and RTL
[x] Onboarding copy for the first screen is improved to make it more obvious that onboarding is onboarding.
[x] "Next" buttons are added to all screens, except the last screen which says "Start"
[x] "X" was changed to "Skip" button
[x] Reposition the "Skip" button away from the corner of the screen to avoid usability issue.

Looks ok to me: (@cherrielam to confirm):

[x] Teal used in the dots is #00858F
[x] Four dots on the bottom are moved up

@ian-lin-PG @tomy-pg Tested on iOS 7plus. Would either of you test on Android?
@aron-chen-pg Could you test on iOS X to check if the "Skip" button is still too close to the corner of the screen?

@jparlina @tomy-pg there is an issue with the language translations
I can see that in French, the "next" button translates to "prochain question" which means "next question", not just "next". Language QA should be done for all languages too (since I can't understand all of them!) What is the process for that?

@jparlina looks like the mocks for me on Android.

@cherrielam see comment on https://github.com/pg-irc/pathways-frontend/issues/1067.

@cherrielam @tomy-pg I'm taking screenshots of all onboarding slides from the current staging for language QA. Were there recent changes to the English strings other than the first screen "Welcome to Arrival Advisor"?

@jparlina
Tested on iPhone X, everything looks functional and usable.

[ ]  Sliding animation exists and functions appropriately for LTR (Arabic) and RTL
[ ]  Onboarding copy for the first screen is improved to make it more obvious that onboarding is onboarding.
[ ]  "Next" buttons are added to all screens, except the last screen which says "Start"
[ ]  "X" was changed to "Skip" button
[ ]  Reposition the "Skip" button away from the corner of the screen to avoid usability issue.
[ ]  Teal used in the dots is #00858F
[ ]  Four dots on the bottom are moved up

@cherrielam
Now that we have "bookmark services" feature, do we want to update the strings on the second onboarding screen to say "Bookmark the topics and services that you find helpful for future use."? If yes, we'll need to get the revised string translated. Let me know.

That's not a bad idea, sorry I didn't catch that before. Will we be able to
get it translated in time? If so, yes please.
On Sun, Apr 5, 2020 at 8:10 PM jparlina<EMAIL_ADDRESS>wrote:

@cherrielam https://github.com/cherrielam
Now that we have "bookmark services" feature, do we want to update the
strings on the second onboarding screen to say "Bookmark the topics and
services that you find helpful for future use."? If yes, we'll need to
get the revised string translated. Let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pg-irc/pathways-frontend/issues/815#issuecomment-609542951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHY2UGUVCE4XQWI3EZAHBLRLFB37ANCNFSM4IXTKGEQ
.

--
Cherrie Lam (she/her), Design Lead
p.<PHONE_NUMBER>| skype. cherrie.l | peacegeeks.org
PeaceGeeks offices are situated on unceded xʷməθkwəy̓əm (Musqueam),
Skwxwú7mesh (Squamish), and Səl̓ílwətaʔ/Selilwitulh (Tsleil-Waututh)
territory.

@cherrielam I just sent the language QA this morning. I'll make a note to include it in the next batch of translation. We may not have enough time to get them QA'd for the production release next week. I think it's ok, I can give the translators the context (screenshot) so they know where it would appear on the app.

@tomy-pg Can I edit the strings directly on weblate? and I'll need to get new translations. How do you track edits and new translations needed on weblate?
Current: Bookmark the topics that you find helpful for future use.
Revised: Bookmark the topics **and service**s that you find helpful for future use.

@jparlina I need to directly edit the strings on a source .pot file since you cannot directly alter the source English strings on Weblate. I will do that soon.
I track them by looking at the issues and mocks, extracting the strings from our app and ensuring they are consistent. Ideally, I just  run an extract command to take all source strings from within our app to ensure this all happens. However we have been doing things differently in that I have had take a list of new and changed source strings and add them to Weblate before they have been added into the app in preparation for features for the production release.

@tomy-pg Thanks for clarifying the process. Let's discuss how to make the process easier and more efficiently for all of us to track moving forward when source strings are edited.

Language QA completed (with the OLD Onboarding 2 copy: Bookmark the topics that you find helpful for future use.)

[x] Arabic
[x] Chinese Simplified
[x] Chinese Traditional
[x] French
[x] Korean
[x] Punjabi
[x] Tagalog

Not yet QA'd: Revised copy on Onboarding 2: Bookmark the topics and services that you find helpful for future use. Will send to QA with the next batch of language QA (not enough to send to contractors just to QA this one string).

@jparlina should we make the second revised copy QA as a separate issue and close this one for now?

@cherrielam Sounds good. Closing this one.


Add examples for Environment resource

Goals

Add examples on how to create Environments via the provider in the examples folder
Use the following languages: @arunkumar611, please fill in here when you find out

Here are the customers who's interested and the languages they use. I'll update this comment as I hear more

vtex: typescript
Boost: python


DR2-1785 Add files change handler.

There's a load of changes linked to the restructure of the
da-aws-clients classes as well.

I think I'll leave the handler method. It is separated into methods inside the handler method. This is mostly so I don't have to pass in the Dependencies and Config objects to each method. I could put it in a seperate class but I don't know if it's worth it. We can always change it later.


netstandard2.0 support

Upgraded to net 4.6.1 - least full .NET supporting new csproj format. Added netstandard2.0 as target framework. Feel free to change them if you prefer to have only latest / broader support.

@henck Hi, are you able to prepare nuget pages with these merges, please?


synth: build/make gui_synth fix

Fixes the use-case below, but adds a openroad dependency to synthesis stage, which we don't want.
$ bazel run //sram:top_fakeram_synth `pwd`/build
INFO: Invocation ID: e4503934-006a-48df-9122-93d487b05d85
INFO: Analyzed target //sram:top_fakeram_synth (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //sram:top_fakeram_synth up-to-date:
  bazel-bin/sram/results/asap7/top/fakeram/1_synth.v
  bazel-bin/sram/results/asap7/top/fakeram/1_synth.sdc
  bazel-bin/sram/results/asap7/top/fakeram/mem.json
  bazel-bin/sram/results/asap7/top/fakeram/1_synth.rtlil
INFO: Elapsed time: 0.050s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
INFO: Running command line: bazel-bin/sram/top_fakeram_synth.sh /home/oyvind/bazel-orfs/build
make: Nothing to be done for 'yosys-dependencies'.
$ build/make open_synth
external/_main~orfs_repositories~docker_orfs/OpenROAD-flow-scripts/tools/install/OpenROAD/bin/openroad -no_init -threads 16   external/_main~orfs_repositories~docker_orfs/OpenROAD-flow-scripts/flow/scripts/sta-synth.tcl
OpenROAD HEAD-HASH-NOTFOUND
Features included (+) or not (-): +Charts +GPU +GUI +Python
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[INFO ORD-0030] Using 16 thread(s).
[INFO ODB-0227] LEF file: external/_main~orfs_repositories~docker_orfs/OpenROAD-flow-scripts/flow/platforms/asap7/lef/asap7_tech_1x_201209.lef, created 24 layers, 9 vias
[INFO ODB-0227] LEF file: external/_main~orfs_repositories~docker_orfs/OpenROAD-flow-scripts/flow/platforms/asap7/lef/asap7sc7p5t_28_R_1x_220121a.lef, created 212 library cells
[INFO ODB-0227] LEF file: sram/fakeram/sdq_17x64.lef, created 1 library cells
The design is gutted when mocking floorplan
openroad> report_clock_properties
Clock                   Period          Waveform
----------------------------------------------------
openroad>

can't be helped. We need this to work... we don't want the dependency on openroad in synthesis, but that's an refinement on top of this bugfix.


Allow for automated use in CI for 2FA accounts

We can use other things using fastlane and FASTLANE_SESSION to authenticate for CI. Is there a way to do that through environment variables?

@senmu I'm using fastlane's xcode_install lane currently but xcodes is faster in terms of setting up an Xcode. We are managing our CI ourselves and I want to use xcodes in place of fastlane for the Xcode setup on the machine. No it is not a current blocker since there is an alternative we can use.

Thanks for the insight, @tahirmt. At the moment our focus at Robots & Pencils is to ensure that the experience around manual use is taken care of first, so we won't have time to look into this in the near future. However if someone were to issue a PR for this, it would be welcomed.
In the meantime, we'll keep it in the back of our minds and continue to think about how it can be integrated in such a way that it's done in a secure manner for when that time comes.

I think a viable workaround for the issue can be #145. One can manually put an Xcode XIP in the same network as CI nodes and install it from there.
FYI it seems it's now not possible to download Xcode without 2FA and xcode-install has the same issue. It might be a good opportunity for xcodes to be the only tool that can be used in CIs.

would also love to see an option for an install that requires no manual input (ie by using environment variables to represent the developer email, password, and session)

I found a way to do this by making xcodes use the cookie generated by fastlane spaceauth. This allows for one login per 30 days. Which is how I'm managing our CI right now.

Use fastlane spaceauth -u 'email' to generate a fastlane cookie
If cookie isn't expired, run fastlane spaceauth -u 'email' again when reading cookies. (This is crucial because while the main cookie is valid, another cookie is only valid for 24 hours but running this doesn't require 2FA code. This bumps up the cookie time from 24 hours to 30 days.
Using a ruby script to load the cookies from the file stored by spaceauth into a json file that swift can read.
Load up the cookies into HTTPCookieStorage for URLSession to use.
xcodes now uses the cookies that were originally generated by spaceauth.

I'm sure there is a way to optimize some of this and maybe even make xcodes handle most of these things internally but for my use case I wanted to read the cookie already generated by fastlane.

I think this issue should be reopened now that Apple blocked the non-authenticated download workaround 😢
If possible @tahirmt could you share the code snippet to load the cookie into HTTPCookieStorage?

Opened https://github.com/RobotsAndPencils/xcodes/pull/265 with a modified version of @tahirmt solution, hope you can give it a review, thanks!

I had opened this new issue #248 to track it. Thanks for the PR. When I worked on it originally I didn't know what fastlane used internally so I ended up using ruby but your solution is much cleaner!


phpmyadmin:5 docker image is broken, so phpmyadmin is asking for login

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
No response
Current Behavior
PHPmyadmin image is not connecting to the database automatically. I get a login screen and when typing in credentials I get an error "mysqli::real_connect(): (HY000/2002): No such file or directory"
Someone borked the official phpmyadmin image. Please see here:
https://github.com/phpmyadmin/docker/issues/365
Expected Behavior
PHPmyadmin should be able to connect automatically to the database
Steps To Reproduce
Clean install
brew install drud/ddev/ddev
ddev start -y

Try vist phpmyadmin
Anything else?
Suggest pinning phpmyadmin and reviewing it rather than using the bleeding edge latest version.

Thanks for reporting and chasing this.  I note that the hostname must be broken too, because even logging in with db/db or root/root doesn't work.
The official image has been good for years, so not sure it's worth pinning it. Before we started using phpmyadmin:5 we were always running something too old and with security issues, etc.
I expect that in the v1.20 release cycle phpmyadmin will be removed from the default ddev setup and replace with an addon, so people can use adminer or whatever they like. Lots of people don't use phpmyadmin.
Please update when they've got it sorted.

Oh yay, the DDEV tests actually started catching this already, https://buildkite.com/drud/ddev-macos-m1/builds/2227#f2e18add-8590-4bcf-bcd0-870d37c31c89

I see the upstream problem has been closed, but there's not a new image yet.

This is fixed by the image being fixed upstream now. If it's still affecting you, docker pull phpmyadmin:5 and you should be good.

@richardfrankza thanks so much for finding, chasing, reporting. Now we have to restart gobs of tests :)

Has this been committed as we have to do it every single time?

This was fixed upstream a month ago, and the issue only happened for about 36 hours IIRC. What do you mean "We have to do it every single time". What is it you have to do? docker pull phpmyadmin:5 ? That would only be done once on each affected machine to fix it by getting a working phpmyadmin image.

@rfay, thanks for the update. We have ddev version v1.19.2 and have to pull pma 5 for every new project we deploy. Does that mean we need to upgrade ddev and then wouldn't have to repeat pulling pma 5 every time?

No, nothing here had anything to do with ddev, it was a temporary problem with library/phpmyadmin:5. And when you do a docker pull phpmyadmin:5 it updates the phpmyadmin image for all projects that are using the same docker service, for example Docker Desktop. So you have something much more exotic going on. I recommend doing a docker images | grep phpmyadmin and using docker rmi to kill all of them.
It's also possible that you have customized with a docker-compose.*.yaml? and that affects this?
Maybe you can just see if you have this problem on a plain vanilla drupal 9 site (or whatever CMS you use)? https://ddev.readthedocs.io/en/latest/users/cli-usage/#quickstart-guides

No, it should be pretty standard ddev setup. But running docker images | grep phpmyadmin shows two different versions, so probably newly created development environments pick up the earlier version:
docker images | grep phpmyadmin
phpmyadmin                        5                       0d0e4007d906   12 days ago    475MB
phpmyadmin                        <none>                  a2910b751aa7   4 weeks ago    475MB

Attempt to remove them give:
docker rmi 0d0e4007d906
Error response from daemon: conflict: unable to delete 0d0e4007d906 (cannot be forced) - image is being used by running container 13d9333e3357

docker rmi a2910b751aa7
Error response from daemon: conflict: unable to delete a2910b751aa7 (must be forced) - image is being used by stopped container ce645d49be38

but I've got the idea and will take it from here. Thanks a lot for pointers!

Do a ddev poweroff and docker rm -f $(docker ps -aq) and then use docker rmi -f.
 They just get downloaded again.


Refactor Realm DOM tests to use postMessage to communicate with realm under test

A recent chrome update broke how we were able to take advantage of cross site scripting within different ports of localhost in order to drive our Realm Server DOM tests. Details here: https://developer.chrome.com/blog/immutable-document-domain/
This PR refactors our realm server DOM tests to leverage postMessage to communicate with the Realm's document that resides within an iframe.

arg, the tests hang because testem is not actually serving the test container with the special new header value...


Gitops/s3-set-bucket-public-acess-disabled

Is it possible to set any of mentioned values to false? I though that there's some kind of enforcement make by AWS (probably configured by IT) that does not allow it.

BTW, version has to be incremented in Chart.yaml in order to package and publish a new chart release to public repo.


Grab the lock when calculating the count property

Calculating the number of active connection listeners requires iterating through the underlying storage array, hence we need to take the lock the lock since new listeners may be appended to it concurrently. This fixes crashes that are seen under non-trivial load.

Hi @ymanton. Whilst it may not be an issue due to timing - depending on the flow through the code -  shouldn't we also be protecting the access to storage in closeAll() as well?

You're right. It occurred to me at the time and I convinced myself that it wasn't necessary if one uses closeAll() sensibly.
In hindsight however if you're using it at shutdown the lock has little performance impact and if you're using it some other way you'll probably take contention over crashes so the module might as well protect itself. Change made.

Thanks @ymanton. LGTM. Merging.


Added Header & Footer with common Layout

What kind of PR is this?:

/kind feature
What this PR does / why we need it:

Added Header & Footer with common Layout
Updated CODEOWNERS for project separation
Updated Governance to reflect the changes

Perfect! Just one thing i would like to point out.
import React from 'react' is not required anymore
You can refer to the release note

Oh, didn't know about this.
But I think TypeScript will complain if you don't import React for tsx files. I might be wrong.


Update Alpha wallet logo & uri

Adjust wallet logo & uri to reflect github change (babilu-online -> alphabatem)

Apologies on the delay getting back to this, was focused on getting it onto google store, should be ok now!

Published<EMAIL_ADDRESS>


Second hash in hash mode is not encoded and parsed correctly

Version
2.7.0
Reproduction link
http://fiddle.jshell.net/nkovacs/wajqos5L/
Steps to reproduce

use hash mode in vue-router
navigate to a page with a hash: router.push({ path: "/foo", hash: "somehash" })
look at window.location.href

In the reproduction, click the "Navigate to hash with router" button, then look at the console.
What is expected?
The second hash in window.location.href should be encoded, e.g. https://fiddle.jshell.net/_display/#/foo%23somehash
What is actually happening?
The second hash is not encoded, e.g.
https://fiddle.jshell.net/_display/#/foo#somehash

The fragment should not contain a number sign: https://tools.ietf.org/html/rfc3986#section-3.5
Browsers are less strict about this, so it works.
Parsing the encoded number sign also doesn't work. I ran into this bug because I'm generating an url on the server, and the second hash is encoded correctly by the server-side code, but vue-router was unable to parse it.
I can't show this on jsfiddle though.

Tested on firefox, safari and chrome and works as expected. BTW, it's not changing anything but you forgot to include the router: http://fiddle.jshell.net/wajqos5L/1/
for the second bug you can send an html file as a repro

What do you mean it works as expected? Is the second hash encoded as %23? It's not for me on Chrome.
The two bugs are related. If vue-router generates urls with an encoded hash, it needs to be able to properly parse them two.

Here's a github pages version where you can see and change the url:
https://nkovacs.github.io/vue-router-bug/index.html#/foo#somehash
And this doesn't work:
https://nkovacs.github.io/vue-router-bug/index.html#/foo%23somehash

Sorry it wasn't clear, I meant that I couldn't reproduce it because the hash doesn't get escaped

But that's the problem. It should be escaped.

Oh man, sorry. Now I see why that conversation didn't make sense 😆
If you pass the hash using hash, it won't be escaped, that's intended. Are you using hashes for something in particular?

My problem is that I'm generating a redirect url on the backend, and it's generated with the second hash escaped, and vue-router can't parse that.
Here's a simple example in go: it can parse the url with the unescaped hash, but it generates an escaped hash: https://play.golang.org/p/_ROUG8dYVU
Why is this the intended behavior? The url that vue-router generates, https://nkovacs.github.io/vue-router-bug/index.html#/foo#somehash, is not valid according to RFC3986. It should be https://nkovacs.github.io/vue-router-bug/index.html#/foo%23somehash (which should be equivalent to https://nkovacs.github.io/vue-router-bug/index.html/foo#somehash if you turn on html5 history mode).

Aaah, now I see. I didn't get it because of number sign; I didn't understand it was referring to the hash character.
I wonder if this may affect other people. It's technically a breaking change, even if it's for the best

Go generates urls according to the rfc, so non-ascii character also get encoded: https://play.golang.org/p/wlXtWZ_NBa
However, the URL constructor doesn't do that (neither in chrome nor in firefox), and it doesn't even escape the second number sign: var u = new URL("https://nkovacs.github.io/vue-router-bug/index.html#/föű#somehash").
The funny thing is, if you try u.href in chrome's dev tools after that, chrome doesn't correctly autolink the url, it breaks at the accented letters.
If I'm reading the spec right, a number sign in the fragment part is supposed to be a validation error, but utf8 characters are allowed. Yet both firefox and chrome allow and even generate urls with a number sign in the fragment.
So given these and that the url looks better without all that encoding and that it would break backwards compatibility, I'll close this, and I'll deal with it on my backend.
Thanks.

Ok, glad you can work around it. I'm still keeping an eye on this and what is the impact when using hashes on hash mode


updated order constants to current api standard

Some constants weren't compatible with the arguments required for the API call.

This constants are used when parsing "Get recent trades" response; where you get <buy/sell> result as b or s. Check it out here: https://api.kraken.com/0/public/Trades?pair=XETHZEUR
You can see that even tests fail...

Yup, makes sense! Sorry =)


Example with next-routes

This example shows how you can use next-routes

I added a link to the parameterized routing example and more keywords. I am not sure what I can do to repair the tests

I wonder if we should call it with-next-routes?

Done! 👍


RTDB Stream (callback mode) missing updates

Describe the bug
We are using RTDB with callback mode for a project. When updates are sent very frequently (~100ms between updates) some of them are lost and never provided to the callback function.
To Reproduce
Steps to reproduce the behavior:

Go to examples/RTDB/Stream_Callback.ino
Configure all settings
Run it. We are using ESP32 from az-delivery
From some other device connected to the same realtime database, send a few updates under /Test/Stream node. See code below used in a test page, which sends updates to /Test/Stream/a0 to /Test/Stream/a9 every 100ms:

for(let i=0; i<10; i++) {
  setTimeout(function() {
     firebase.database().ref(`/Test/Stream/a${i}`).set(firebase.database.ServerValue.increment(1));
  }, 100*i);
}

Expected behavior
The ESP32 callback should be called and output the 10 updates:
Stream Data1 available...
STREAM PATH: /Test/Stream
EVENT PATH: /a0
DATA TYPE: int
EVENT TYPE: put
VALUE: 1

[9 more updates skipped]

Actual behavior
Some updates are missing / skipped, and never get provided to the callback function. See full output for one test with 10 updates:
Stream Data1 available...
STREAM PATH: /Test/Stream
EVENT PATH: /a0
DATA TYPE: int
EVENT TYPE: put
VALUE: 1

Stream Data1 available...
STREAM PATH: /Test/Stream
EVENT PATH: /a4
DATA TYPE: int
EVENT TYPE: put
VALUE: 1

Stream Data1 available...
STREAM PATH: /Test/Stream
EVENT PATH: /a7
DATA TYPE: int
EVENT TYPE: put
VALUE: 1

Stream Data1 available...
STREAM PATH: /Test/Stream
EVENT PATH: /a9
DATA TYPE: int
EVENT TYPE: put
VALUE: 1

Screenshots
N/A, output provided above
IDE and its version:
arduino-cli alpha Version: 0.15.2 Commit: 0d4cb150 Date: 2021-02-09T13:02:49Z
ESP32 Arduino Core

esp32:esp32

Additional context

This was tested with Stream_Callback (not removing updates from that code), but all callbacks should be sent between updates from Callback. Removing those doesn't solve the issue.
Depending on the test different updates are missed.
Changing timeout between updates to 500ms all updates are sent to the callback in my tests.
Changing timeout between updates to 300ms some updates start to be lost, but less frequently than with 100ms.
Other Firebase integrations (ie. web) get all the updates, so they are ok in Firebase.

This is not a bug or issue.
In the http stream, there are no guarantee and can't be guaranteed that all server data changes will push to client and client will get all changes.
Client is waiting for server's incoming data without sending request  All available payload data will be read from SSL buffer as the result you've got.
This different than other protocol e.g. TCP socket and MQTT which data will not miss as it can resend.
In http stream, client doesn't know anything about incoming stream event data as it has only payload without header which means client doesn't know the length or size of payload which used to determine the validity of data.

Other clients e.g. web, Android and iOS use the Firebase SDK that connected to server trough the Google own protocol which can't compare to REST client which use http protocol.

Hi,
We have been testing Firebase Stream and in the tests all 10 updates from the other device are consistently retrieved:
curl -Lv -X GET -H "Accept: text/event-stream" https://[my-project].firebaseio.com/Test/Stream.json

That command always outputs all the values, even
event: put
data: {"path":"/a0","data":22}

event: put
data: {"path":"/a1","data":22}

event: put
data: {"path":"/a2","data":22}

event: put
data: {"path":"/a3","data":22}

event: put
data: {"path":"/a4","data":22}

event: put
data: {"path":"/a5","data":22}

event: put
data: {"path":"/a6","data":22}

event: put
data: {"path":"/a7","data":22}

event: put
data: {"path":"/a8","data":22}

event: put
data: {"path":"/a9","data":22}

It might be that the data is delivered in multiple chunks or several updates in the same one, but it looks like the data will be there. If it's one chunk, it could generate multiple callback, while if it's multiple chunks it could keep track of the pending information to parse it when it's complete.
Is there a way to log all the payload processed by the library from Firebase Stream protocol? Maybe to Serial port, or connecting via a proxy?

I will fix this timing issue and update here.

The update of library v 2.0.9 is available with the issues fixed.
I tested with 100,000 times data storing iteration loop with no delay, no stream event data lost.


[Regression] Failed to assign to a discriminated union class property when its type is inferred from constructor

🔎 Search Terms
property infer constructor discriminated
🕗 Version & Regression Information

This changed between versions 4.3.5 and 4.4.4 (also in latest)

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=4.4.4#code/C4TwDgpgBAysCGxoF4oG8qkgLigcgCcBXAOxIEsSBzPAGigGdIIATXEogWwCMICoAvlAA+6TOAi48DYAHswkFnkEBuAFBqAxgBt4DBlACCmufzRqolqGALkAbomgzH6q1AD07t1YB6Afg03TVkSGWITWQIACgBKdAtvS2AAC3IGADpnJChUDCxJfBl5RWUhPVgEJFcrAUCrYhIopghWdi5eAjjzRKTUjKyUMXypBopqOkZmFkEEy1qBIA
💻 Code
type State = { type: 'running', speed: number } | { type: 'stopped' };

class Actor {
    private state;
    //       ^? Actor.state: State

    constructor() {
        this.state = { type: 'stopped' } as State;
    }

    run(speed: number) {
        this.state = { type: 'running', speed }
    }
}

🙁 Actual behavior
Type 'string' is not assignable to type '"running" | "stopped"'.(2322)
🙂 Expected behavior
No error, as in 4.3.5.
Additional information about the issue
If the property's type is explicitly declared as private state: State the error is gone.

I'm pretty sure this has changed in https://github.com/microsoft/TypeScript/pull/44601


animation plugin produces a delay before showing first stimulus

See discussion topic about this: #782

For what it's worth, we could still edit the package changelog and GH release message accordingly to get the same result as a changeset would have yielded.


Hey Can you explain what is this? I'm a newbie 😅

hello! it's the new best model for video classification (you have a video, you sample some frames from it, and ask what is happening inside the video [is it sports? is it cooking? is it gymnastics?])

Thanks for the quick reply and explanation . 😀


M gand levels

This pull request adds the Visualforce page for the Level Edit/New/Clone override, and improves error handling on overlaps.
Critical Changes
Changes
Issues Closed

@jjbennett once this passes build, this one is ok to review and merge.  Note that it is going into the MGAndLevelsREVIEWED branch, not dev.  Once Nic's Engagement Plan work goes into dev, and is auto-merged into MGAndLevelsREVIEWED, we will then be ready to put in the pull request to put it into Dev.  thanks.

Responses to @jjbennett's questions:

Should we not allow maximum do be less than minimum?

I had considered additional validation for this, and then thought it was just too basic a scenario that users wouldn't mess up, and it wasn't worth adding more code and another error message.  If @mpusto feels it is worth adding, I can.

Do we need to put in a few negative tests?

all of the validation is done in LVL_Level_TDTM, not the visualforce page & controller, and there are negative tests in LVL_LevelAssignBATCH_TEST.

After clicking Save and New and then Save, should the page return to the original record or the record last created?

Good catch.  It should be the record last created, but I'm letting the standard controller handle the save, and it must be going back to the original record since it doesn't really know about the new one.  I'll fix this by providing my own implementation of Save (unless there is a way to update the standard controller's current record).  I'll let Cancel continue to be handled by the standard controller and go back to the original record.

Are we going to provide a button that acts like Save and New, like New from Existing when viewing an existing level?

you get the same visualforce page whether you are creating a new Level or editing an existing Level.  Thus I think the Save & New button name works fine in both scenarios.  I do think we should document to specify this override for New, Edit, and Clone (which I've tested), so I think Clone gets them very close to what they want.  All they have to do is change the name and update both Min and Max.  Unfortunately I don’t believe we can tell its a Clone operation specifically, so that we could clear Max and copy Max to Min.  To have the Clone override tell us otherwise would require an additional visualforce page that could redirect to the edit page telling it was a clone.  I didn't think it was worth adding this complexity to the admin setup of another page, but if @mpusto feels it is necessary, I can do it.  Once again a tradeoff of more code, buttons, documentation to support.

Should we not allow the level and previous level fields to be the same?

another good question for @mpusto .  Seems pretty obvious to the user that they should be different, so I didn't put in validation to enforce this (due to a little more code and another error message).  But I'm fine adding it if @mpusto feels it is worth adding.

I noticed the comment about having to use addFields in your controller, this is because the Visualforce page has lvl.Name vs Level__c.Name. Are there namespace implications with using the custom object name or why is it preferable to use the variable name vs the standard object name?

I was under the impression that one had to use the variable name of the object in the controller.  Are you saying the standard controller implicitly supports binding to the object name directly?  What about with the field set?  I was wondering why it wasn't picking up all my field references, and I actually looked up in the Visualforce Developer's Guide info on Controller Extensions, but I didn't read, nor did it occur to me, that one should use the object name directly.  I'll give that a try and see if it works.  otherwise, we are stuck with addFields!

It's up to @mpusto but I thought we were specifically providing a 'Create Next Level' button that would clone the level and populate the Minimum Value based on the previous Maximum. And I also thought were were going to validate against level overlaps? I do think both of these are important, as it gets frustrating from the user perspective to fix mistakes after the fact. It's often not that one level that needs to change, an issue at the bottom of the ladder typically means multiple records need to be adjusted.

A few thoughts:
Yes, we should validate that the max is not less than the min. Should be
obvious to the user but it could happen.
Likewise, we should validate that the level and previous level don't point
to the same field. If it saved fine, the user would not realize their
error. Then when the process runs they would wonder why their level field
is being overwritten by the previous level (not sure the order, so this may
not happen but you get the idea).
As for Save and New, I'm confused because I thought we had agreed to the
pre-filling of the previous max as part of the behavior. We talked a bit
about that in our discussion of whether max would be inclusive or not.
Let me know if there are further questions
On Sep 3, 2016, at 5:23 AM, Judi Sohn<EMAIL_ADDRESS>wrote:
It's up to @mpusto https://github.com/mpusto but I thought we were
specifically providing a 'Create Next Level' button that would clone the
level and populate the Minimum Value based on the previous Maximum. And I
also thought were were going to validate against level overlaps? I do think
both of these are important, as it gets frustrating from the user
perspective to fix mistakes after the fact. It's often not that one level
that needs to change, an issue at the bottom of the ladder typically means
multiple records need to be adjusted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SalesforceFoundation/Cumulus/pull/2248#issuecomment-244538816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKbZDcX0AIMAnsGJJexm1xP8mLIFwc_Lks5qmUqMgaJpZM4JzKKK
.

@mpusto @judisohn There is a Save and New button when you are editing the record that copies the values over. I was asking if we should provide a similar button when viewing(not editing) an existing record. Currently the user can click edit on an existing record and then save and new which would do the same thing.

Oh cool, then that is all that's needed.
On Sat, Sep 3, 2016 at 8:47 AM, jjbennett<EMAIL_ADDRESS>wrote:

@mpusto https://github.com/mpusto @judisohn
https://github.com/judisohn There is a Save and New button when you are
editing the record that copies the values over. I was asking if we should
provide a similar button when viewing(not editing) an existing record.
Currently the user can click edit on an existing record and then save and
new which would do the same thing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SalesforceFoundation/Cumulus/pull/2248#issuecomment-244547491,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKbZDXQG2nHCIPqhWi-nydTb80vPqvFPks5qmXp0gaJpZM4JzKKK
.

--
Mary Pustejovsky
Technical Product Manager | Salesforce.org
e<EMAIL_ADDRESS>m:<PHONE_NUMBER> | @mpusto

@jjbennett all of the EP related files will hopefully go out of my merge, once I put Engagement Plans into Dev, which then will migrate them to the MGandLevelsREVIEWED branch.  And I've already identified those versioning issues for Nic to address when he is back.

@JenniferBennett I've merged dev into MGandLevels, which is building now.  Once this passes build, I would like to get it merged into MGandLevelsREVIEWED asap.  I believe you have already fully reviewed this pull request, so I'm hoping it can happen before your lightning talk meeting.  thanks.


Name error - numba doesn't find a function

Hi,
there is a very interesting issue. I am using compilation with signature specification, and then there is a name error, because he isn't able to find other functions. The code is like that
import numpy as np
import numba

@numba.jit(numba.types.int16(numba.types.int16),nopython=True)
def func1(a):
    a *= 5
    a = func2(a)
    return a

@numba.jit(numba.types.int16(numba.types.int16),nopython=True)
def func2(a):
    a *= 2
    return a

A=2
print(func(A))

and the error like that
TypingError: Failed in nopython mode pipeline (step: nopython frontend)
NameError: name 'func2' is not defined

Thanks for your help

@Hanni-ui thank you for asking about this on the Numba issue tracker. If you include the signature in the njit decorator, you will compile the functions eagerly, i.e. at definition time, thus, func2 must be defined before it can be used, try:
import numba

@numba.jit(numba.types.int16(numba.types.int16),nopython=True)
def func2(a):
    a *= 2
    return a

@numba.jit(numba.types.int16(numba.types.int16),nopython=True)
def func1(a):
    a *= 5
    a = func2(a)
    return a

A = 2
print(func1(A))


Crash when using default reporting

I'm seeing intermittent crashes that appear to be because of corrupted memory with effectively the same trace. Example:
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000072

Crashed: com.datatheorem.trustkit.reporterqueue
0  libdispatch.dylib              0x18fddb800 dispatch_sync_f + 1530
1  Security                       0x19138831c SecTrustGetVerifyTime + 112
2  Security                       0x191388440 SecTrustEvaluateIfNecessary + 76
3  Security                       0x191389a2c SecTrustGetCertificateCount + 32
4  ClientApp                      0x10087883c convertTrustToPemArray (reporting_utils.m:20)
5  ClientApp                      0x10p087beb8 -[TSKPinningValidatorResult certificateChain] (TSKPinningValidatorResult.m:24)
6  ClientApp                      0x100879794 -[TrustKit sendValidationReport:notedHostname:pinningPolicy:] (TrustKit.m:215)
7  ClientApp                      0x10087950c __46-[TrustKit initWithConfiguration:isSingleton:]_block_invoke_2 (TrustKit.m:178)
8  ClientApp                      0x10087bb6c __49-[TSKPinningValidator evaluateTrust:forHostname:]_block_invoke (TSKPinningValidator.m:204)
9  libdispatch.dylib              0x18fdd69e0 _dispatch_call_block_and_release + 24
10 libdispatch.dylib              0x18fdd69a0 _dispatch_client_callout + 16
11 libdispatch.dylib              0x18fde4ad4 _dispatch_queue_serial_drain + 928
12 libdispatch.dylib              0x18fdda2cc _dispatch_queue_invoke + 884
13 libdispatch.dylib              0x18fde6a50 _dispatch_root_queue_drain + 540
14 libdispatch.dylib              0x18fde67d0 _dispatch_worker_thread3 + 124
15 libsystem_pthread.dylib        0x18ffdf100 _pthread_wqthread + 1096
16 libsystem_pthread.dylib        0x18ffdecac start_wqthread + 4

The above implicates https://github.com/datatheorem/TrustKit/blob/master/TrustKit/Reporting/reporting_utils.m#L20 and I have other reports that implicate https://github.com/datatheorem/TrustKit/blob/master/TrustKit/Reporting/reporting_utils.m#L24 but always with EXC_BAD_ACCESS KERN_INVALID_ADDRESS.
I've worked around the issue for now by setting  kTSKDisableDefaultReportUri:@YES in my configuration but it'd be nice to be able to use the reporting feature in the future.

Hello,
Which version of TrustKit are you using? v1.5.0 had this problem, but it should have been fixed in v1.5.1. As for the reporting feature feel free to email me directly if you want access to the dashboard.
Thanks!

Thanks for the update! I was using a fork that was essentially v1.5.0 because of https://github.com/datatheorem/TrustKit/issues/131.
Definitely feel free to close this issue if it is a duplicate of another one. Would you also be able to link to a PR or commit that fixes this issue? I don't think I see anything relevant in the commit history of reporting_utils.m. Thanks again!

Sounds good - I will close this issue. My guess is that this was the issue fixed here: https://github.com/datatheorem/TrustKit/commit/3f3c437559fda1dfd87fce1f299e0a74ab2618f3