Why does ShoppingCartAjax use cart or form for messages?

When showing status-messages via AJAX, the ShoppingCartAjax extension seems to switch between using form or cart to get the message.
The most common case:
if (self::config()->show_ajax_messages && $this->owner->cart) {
    $response->triggerEvent('statusmessage', array(
        'content'   => $this->owner->cart->getMessage(),
        'type'      => $this->owner->cart->getMessageType(),
    ));
    $this->owner->cart->clearMessage();
}

…but there's also:
if (self::config()->show_ajax_messages) {
    $response->triggerEvent('statusmessage', array(
        'content'   => $form->Message(),
        'type'      => $form->MessageType(),
    ));
    $form->clearMessage();
}

The extension is added to AddProductForm and VariationForm where cart isn't available. This causes AddProductForm to not emit any status messages.
Both form and cart might be null, so maybe there should be a check of either of them exists and then pull the status message from there?

I think that makes sense to check both.


new js language extension breaking the core js grammar

I tried to make an extension to support this js grammar (https://github.com/Benvie/JavaScriptNext.tmLanguage) following the instructions with the yo code module. Not only it does not work, it breaks the core javascript highlighting. Why is that?

@ricmed205 You have to give more information on what was in your package.json.

@aeschli
{
	"name": "js-next",
	"displayName": "Javascript Next",
	"description": "Javascript Next Highlighting",
	"version": "0.0.1",
	"publisher": "ricmed205",
	"engines": {
		"vscode": "^0.10.1"
	},
	"categories": [
		"Languages"
	],
	"contributes": {
		"languages": [{
			"id": "js",
			"aliases": ["JavaScript Next", "js"],
			"extensions": [".js",".htc",".jsx"],
			"configuration": "./js.configuration.json"
		}],
		"grammars": [{
			"language": "js",
			"scopeName": "source.js",
			"path": "./syntaxes/js.tmLanguage"
		}]
	}
}

Excuse my ignorance (I'm a github newbie), why close the issue when needs more info?

The problem is, your extension registers the same extension as the built-in JavaScript extension under a different language id.
Since the December release we have a better Javascript grammar that also supports ES6.
If you still want to replace the grammar, all you have is an section 'grammar'
Note that the built-in JavaScript has id javascript
{
	"name": "js-next",
	"displayName": "Javascript Next",
	"description": "Javascript Next Highlighting",
	"version": "0.0.1",
	"publisher": "ricmed205",
	"engines": {
		"vscode": "^0.10.1"
	},
	"categories": [
		"Languages"
	],
	"contributes": {
		"grammars": [{
			"language": "javascript",
			"scopeName": "source.js",
			"path": "./syntaxes/js.tmLanguage"
		}]
	},
	"extensionDependencies": [
		"vscode.javascript"
	],
}

@aeschli I got an expected value error so I removed the last comma but I don't the option in the language mode options and if I select javascript it breaks (the whole highlighting is off).

Ah, of course if you want own option in the language dropdown, then having your own id is the right thing to do.
Highlighting is off: Sounds like an issue in the grammar, or a bug in our TextMate engine.
Did you check the console in the dev tools?

@aeschli  Thank you for help!
So this is my package.json
{
	"name": "js-next",
	"displayName": "js-next",
	"description": "Javascript Next Highlighting",
	"version": "0.0.1",
	"publisher": "rickmed",
	"engines": {
		"vscode": "^0.10.1"
	},
	"categories": [
		"Languages"
	],
	"contributes": {
		"languages": [{
			"id": "js-next",
			"aliases": ["JavaScript Next"],
			"extensions": [".js",".htc",".jsx"],
			"configuration": "./javascript.configuration.json"
		}],
		"grammars": [{
			"language": "javascript",
			"scopeName": "source.js",
			"path": "./syntaxes/js-next.tmLanguage"
		}]
	}
}

When a place my extension folder in the vscode's extension folder I get these messages (the new js language is selected by default):

When I select the core javascript language, I get this:


feat: Add model_load_time metric

What does the PR do?
Add new metric nv_load_time per model to metrics
Added load time gauge metric per model.
New metric added example
HELP nv_model_load_time Load Time per-model
TYPE nv_model_load_time gauge
nv_model_load_time{model="libtorch_float32_float32_float32",version="1"} 0.311423712

Checklist

[x] PR title reflects the change and is of format <commit_type>: <Title>
[x] Changes are described in the pull request.
[x] Related issues are referenced.
[x] Added test plan and verified test passes.
[ ] Verified that the PR passes existing CI.
[x] Verified copyright is correct on all changed files.
[x] Added succinct git squash message before merging ref.
[x] All template sections are filled out.
[ ] Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:
Check the conventional commit type
box here and add the label to the github PR.

[ ] build
[ ] ci
[ ] docs
[x] feat
[ ] fix
[ ] perf
[ ] refactor
[ ] revert
[ ] style
[ ] test

Related PRs:
https://github.com/triton-inference-server/server/pull/7697
Where should the reviewer start?
ReportModelLoadTime func use-age.
Test plan:
Added in server PR

CI Pipeline ID: https://gitlab-master.nvidia.com/dl/dgx/tritonserver/-/pipelines/19322776

Can you also add me to this PR?

If the server is started with two models, the first model takes 0.1 second to load and the second model takes 10 seconds to load. I wonder what will the model_load_time metric report for each of the two models?

Can you build with metrics disabled flags and make sure it works?
-DTRITON_ENABLE_METRICS=OFF -DTRITON_ENABLE_METRICS_CPU=OFF -DTRITON_ENABLE_METRICS_GPU=OFF -DTRITON_ENABLE_STATS=OFF


fix(Tactic/MoveAdd): add missing withContext

Adds a missing withContext, as mentioned in this Zulip message.
I also added the relevant test.

Thanks!
bors r+


Fix Project and License Urls

After pushing and being approved, noticed that the Project and License URL's in the nuspec file are incorrrect, these are still the old versions.  These need to be updated to:
https://github.com/chocolatey/ChocolateyGUI
https://raw.githubusercontent.com/chocolatey/ChocolateyGUI/develop/LICENSE
respectively.

Also remove historical release notes section.  This is a third duplicate of this information when you include the changelog.md and the releases section in GitHub, we don't need all this repeated information. One source of truth!

Ok, so turns out if it only the license URL that needs to be updated.


[ITK] solve itkeigen packaging pb

Fix https://github.com/medInria/medInria-public/issues/1111
Itkeigen since ITK5.1.1 had a problem at packaging on Ubuntu at least. It has been discovered during the work of this PR https://github.com/medInria/medInria-public/pull/1112
There were 2 directories at wrong location: include and lib. The include one is solved on line _eigen3_cmake_install_includedir and the lib one through ITK_INSTALL_PACKAGE_DIR. For the include one we could have used ITK_INSTALL_INCLUDE_DIR but unfortunately it does not compile because it affects other part of the code.
:m:

I put this PR as invalid because after some new tests, there is still a problem with ITKeigen on master, that can be particularly seen in RPM package. Indeed, DEB packages warn that there are linked to weird hardcoded ITKeigen locations in the package (/home/etc), but RPM not only warn but block the installation.
ITKeigen is the only ITK ThirdParty module to have this kind of packaging problem, and this could be an ITK bug.
For now, one quick solution is to rebuild the RPM removing the problematic lines as explained in this doc.
The other solution would be to find a proper debug in ITK and/or medInria, as began here. I'm working on it, if i find something i'll tell here.

ITKeigen debug done on https://github.com/medInria/medInria-public/pull/1112/commits/ff83d044b0ee16b05fd9d00c18a3c19f5c00638a on PR https://github.com/medInria/medInria-public/pull/1112
I close this PR


[#2738] feat(catalog-lakehouse-paimon): support PaimonCatalog implementation to manage Paimon table operations

What changes were proposed in this pull request?
Introduce baseline implementation of PaimonCatalog to manage Paimon table operations.
Why are the changes needed?
Support PaimonCatalog implementation to provide Gravitino catalog for Paimon table operation management.
Fix: #2738
Does this PR introduce any user-facing change?
Introduce PaimonCatalog, PaimonCatalogOperations and PaimonTableOps as implementation of a Paimon catalog in Gravitino.
How was this patch tested?

TestPaimonTableOps
TestCatalogUtils
TestTableOpsUtils
TestTypeUtils
TestPaimonConfig

Overal LGTM, except minor comments

@FANNG1, make sense to me. I will push other pull requests of Paimon catalog based on this pull request and compared with this pull request. WDYT?

@FANNG1, make sense to me. I will push other pull requests of Paimon catalog based on this pull request and compared with this pull request. WDYT?

ok

@FANNG1, @qqqttt123, I have addressed above comment. PTAL.

LGTM. Prepared for 0.6. After 0.5 branch is created, we will merge this pull request.

@FANNG1, I have pushed baseline implementation of PaimonCatalog based on the code skeleton. PTAL.

@FANNG1, I have pushed baseline implementation of PaimonCatalog based on the code skeleton. PTAL.

@SteNicholas  thanks for your work, could you split into smaller PR? like:

code skeleton
integrate test skeleton
schema operations
basic table operations
more advanced features like partition, distribution,alterTable etc.

@FANNG1, IMO, splitting this pull request have certain works. Could this pull request take a review firstly?

@FANNG1, IMO, splitting this pull request have certain works. Could this pull request take a review firstly?

sure, but we're struggling for 0.5 release recent days, plan to review it after 0.5 is released.  And totally I prefer to merge and review smaller PRs.

@SteNicholas @FANNG1 can you please move forward this PR?

@SteNicholas @FANNG1 can you please move forward this PR?

plan to review this PR today or tomorrow.

@FANNG1, IMO, splitting this pull request have certain works. Could this pull request take a review firstly?

@SteNicholas, the overall architecture LGTM, do you like to split to smaller PRs and add Integrate tests?

@FANNG1, I will split the implementation to small pull requests. Thanks for your review.

@FANNG1, I will split the implementation to small pull requests. Thanks for your review.

Hi, gently ping @SteNicholas May I ask if we have any plans to move this pr forward? Thank you!

@caican00, I will push the small implementation this week.

@caican00, I will push the small implementation this week.

Gently ping @SteNicholas hi, do you mind I help to split this PR into smaller ones?
we really hope to use this feature, thank you very much and looking forward to your reply.


bazel build failure, error occur no such package @androidndk

System information

**OS Platform and Distribution **: Ubuntu 16.04
**TensorFlow install **: installed from source
**TensorFlow version **: r1.9
**Python version **: pyenv + virtualenv to support python 3.6.6
**Bazel version **: 0.14.1 compiling from source
**GCC/Compiler version  **: gcc 4.9
CUDA, cuDNN version: CUDA 9.0, cuDNN 7.1
**GPU  **: NVIDIA Titan X 12GB
** no custom code **: source compile from released r1.9 source

Describe the problem
When compile tensor flow r1.9 from released source code, Bazel occur error message.
I try to compile r1.8 as same build env. there is no error occurred.

Building: no action
Building: no action
Building: no action
ERROR: /tmp/tensorflow-r1.9/tensorflow/contrib/lite/kernels/internal/BUILD:529:1: no such package '@androidndk//': The repository could not be resolved and referenced by '//tensorflow/contrib/lite/kernels/internal:cpu_check'
ERROR: Evaluation of query "deps(//tensorflow/tools/pip_package:build_pip_package)" failed: errors were encountered while computing transitive closure

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

I've update filled out following filed in the issue

Have I written custom code: no custom code
CUDA/cuDNN version: CUDA 9.0, cuDNN 7.1
GPU model and memory: NVIDIA GTX Titan X 12GB
Exact command to reproduce: update build env. setting

@hephaex : You need to configure AndroidNDK by running ./configure and update the path to NDK.

@shashishekhar : Thanks you kind comment. The Tensorflow r1.8 is successful build from released source as same as same build pipeline, but the TensorFlow r1.9 is not successful build. Why it happen stop during bazel compile sequence. I try to review bazel's configuration.

doesn't work for me too

@hephaex  can you attach your tensorflow/.tf_configure.bazelrc?

@shashishekhar
here is my tensorflow/.tfl_configure.bazelrc
build --action_env PYTHON_BIN_PATH="/usr/local/bin/python"
build --action_env PYTHON_LIB_PATH="/usr/local/lib/python3.6/site-packages"
build --python_path="/usr/local/bin/python"
build --define with_jemalloc=true
build --define with_gcp_support=true
build --define with_hdfs_support=true
build --define with_s3_support=true
build:kafka --define with_kafka_support=true
build --define with_xla_support=true
build:gdr --define with_gdr_support=true
build:verbs --define with_verbs_support=true
build --action_env TF_NEED_OPENCL_SYCL="0"
build --action_env TF_NEED_CUDA="1"
build --action_env CUDA_TOOLKIT_PATH="/usr/local/cuda"
build --action_env TF_CUDA_VERSION="9.0"
build --action_env CUDNN_INSTALL_PATH="/usr/lib/x86_64-linux-gnu"
build --action_env TF_CUDNN_VERSION="7"
build --action_env TF_NCCL_VERSION="1"
build --action_env TF_CUDA_COMPUTE_CAPABILITIES="3.5,3.7,5.2,6.0,6.1,7.0"
build --action_env LD_LIBRARY_PATH="/usr/local/nvidia/lib:/usr/local/nvidia/lib64"
build --action_env TF_CUDA_CLANG="0"
build --action_env GCC_HOST_COMPILER_PATH="/usr/bin/gcc"
build --config=cuda
test --config=cuda
build --define grpc_no_ares=true
build:opt --copt=-march=x86-64
build:opt --copt=-mavx
build:opt --copt=-mavx2
build:opt --copt=-mfma
build:opt --copt=-mfpmath=both
build:opt --copt=-msse4.1
build:opt --copt=-msse4.2
build:opt --host_copt=-march=native
build:opt --define with_default_optimizations=true
build --strip=always

My suspicion was correct, you don't have NDK configured, try running ./configure again make sure to configure for Android which will ask you about SDK and NDK. Once you have run configuration correctly your tensorflow/.tfl_configure.bazelrc should contain Android SDK and NDK path.
@hephaex : let me know if that doesn't work.

Sure, I don't use "Android NDK" in tensorflow 1.9.
I try running ./configure again , and then choose ./WORKSPACE for Android builds.
Would you like to interactively configure ./WORKSPACE for Android builds? [y/N]: N
Not configuring the WORKSPACE for Android builds.

Preconfigured Bazel build configs. You can use any of the below by adding "--config=<>" to your build command. See tools/bazel.rc for more details.
	--config=mkl         	# Build with MKL support.
	--config=monolithic  	# Config for mostly static monolithic build.
Configuration finished

It is same the result of bazel fetch, please refer to below build sequence,
root@e5f744e97dce:/tmp/tensorflow-r1.9# cd .;PYTHON_BIN_PATH=/usr/local/bin/python PYTHON_LIB_PATH=/usr/local/lib/python3.6/site-packages \
> bazel fetch //tensorflow/tools/pip_package:build_pip_package
Starting local Bazel server and connecting to it...
..................
ERROR: /tmp/tensorflow-r1.9/tensorflow/contrib/lite/kernels/internal/BUILD:529:1: no such package '@androidndk//': The repository could not be resolved and referenced by '//tensorflow/contrib/lite/kernels/internal:cpu_check'
ERROR: Evaluation of query "deps(//tensorflow/tools/pip_package:build_pip_package)" failed: errors were encountered while computing transitive closure
Building: no action

Sorry, I misread it to being related to APK.
@gargn Looks like it is coming from //tensorflow/contrib/lite/toco/python:toco_from_protos
and easy way to check it by running the following query:
bazel query "deps(//tensorflow/tools/pip_package:build_pip_package)"

After running

@Giribushan :  In my case, I don't need to Android NDK but it occurs failure when "TF_SET_WORKSPACE =1 & T_CUFA=1".  Temporary way, I install Android NDK to make Tensorflow wheels. I wish you solve error , please refer to my build configuration.

Nagging Assignee @case540: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This is still an issue.

Sorry, was on vacation. This is on my radar and I'll try to look into it sometime this week. Thanks for reporting it!

Adding @angersson, he might have just fixed this issue (or at least a very similar one)

Nagging Assignees @case540, @angersson: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignees @case540, @angersson: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This is still an issue.

I don't think I fixed this, unfortunately.
As a fast workaround for bazel query halting, you can use bazel query --keep_going, which ignores those errors.

Nagging Assignees @case540, @angersson: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Maybe the newest bazel has fixed this?

As far as I understand, in the configure.py the ANDROID_SDK_HOME and ANDROID_NDK_HOME should be passed into the Bazel's .bazelrc file into --action_env command line option.
For this, in the script it should be something like here: https://github.com/tensorflow/tensorflow/blob/d8b89170d98d200d3538a6435159f561aa888015/configure.py#L236
Hope that helps. I just run into the same problem with my use case (not TF-related), so decided to reach out.
/cc @case540

The configure script does add those --action_env args. Is this still an issue or obsolete?
As far as I know, if you run configure properly, and set the correct ANDROID SDK/NDK paths, everything should work.

As a temporary hack (if you don't want the android ndk) you can just remove it:
sed -i '/androidndk/d' tensorflow/lite/kernels/internal/BUILD

Not sure how I unassigned anything, I shouldn't even have permission for that.

comment code @ andoridndk//:cpufeatures in tensorflow/contrib/lite/kernels/internal/BUILD

Marking issue as resolved. Feel free to re-open this if it's unresolved or file a new issue


No ckpt.meta files in the release of 24 smaller BERT models

I'd like to try the smaller bert models referenced in readme but all files do not have *.meta files included, so it's impossible to use models without the file. Can you please update the modeld and meanwhile have links to metafiles what can be used for each model?

It's dup of 1172 but that was closed without updating models.

Bump. We need the *.meta files. please.


[SPARK-25097][ML] Support prediction on single instance in KMeans/BiKMeans/GMM

What changes were proposed in this pull request?
expose method predict in KMeans/BiKMeans/GMM
How was this patch tested?
added testsuites

Merged build finished. Test PASSed.

Test build #94671 has finished for PR 22087 at commit f6cbb46.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94671/
Test FAILed.

Test build #94723 has finished for PR 22087 at commit 5fe7ed3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94723/
Test PASSed.

@felixcheung Testsuites is added. Thanks for reviewing!

Test build #95990 has started for PR 22087 at commit 5fe7ed3.

Test build #95990 has finished for PR 22087 at commit 5fe7ed3.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95990/
Test FAILed.

Test build #98345 has started for PR 22087 at commit 2d6594e.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4691/
Test PASSed.

Merged build finished. Test PASSed.

Test build #98344 has finished for PR 22087 at commit f428a5d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98344/
Test PASSed.

Test build #98345 has finished for PR 22087 at commit 2d6594e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98345/
Test PASSed.

@zhengruifeng thanks, the PR looks good to me, maybe @felixcheung or @jkbradley can review and possibly merge?

Test build #98502 has finished for PR 22087 at commit fb3c6d1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98502/
Test PASSed.

This LGTM, but it raises a more general question about the lack of single-sample prediction over the entire hierarchy. For example (IMO) there should be some kind of single-sample method associated with org.apache.spark.ml.Model, or org.apache.spark.ml.Transformer.

Yeah it's a good point and I wonder if @jkbradley or @mengxr or @MLnick want to weigh in. If this superclass method existed, I think it would be predict(Vector):Int anyway, so seems pretty reasonable to expose the already-existing instances of it.

Aha. On the one hand, I suppose they can't extend that class because of the signature difference, and indeed it says it's the superclass of regression and classification models. I can imagine that the clustering algoritms should have a ClusteringModel superclass or something with predict(Vector):Int.  That I suppose can be decided later. That is, maybe there isn't going to be a logical overall superclass defining a universal prediction method, for reasons like this. Yes, these things can return an Int where a Double is needed but that to me isn't a great reason.

@srowen I think it would not be a big deal if we would change the return type of these to Double, since they are now private. If that is the only change needed we may be able to reuse the PredictionModel also for clustering models. But if we expose them, going back would be harder. So I'd first agree on whether to try or not to make them PredictionModels: if not, this PR is good IMHO.

I'd escalate to dev@ for more visibility. It has some longer-term consequences, and I'd like to hear current thinking on how much these APIs should change, etc.

@srowen @mgaido91 @erikerlandson I don't think it makes sense to use PredictionModel as it is currently because it is for supervised learning and contains label column specific params (eg getLabelCol() method).  KMeans and friends are unsupervised learning and should not have these params.  I definitely agree though that some of the goodness on prediction model should live on a common base class shared by the supervised and unsupervised algos.  Maybe a class hierarchy like:
predictionmodel
unsupervisedmodel                          supervisedmodel
would be ideal?  where the label specific params would live on supervisedmodel.
also tagging @jkbradley

PredictionModel as a super-class of unsupervised and supervised seems sane to me. Returning a double to unify the signature also seems sane, although the thought of casting it might irk people.

Test build #98574 has finished for PR 22087 at commit 01b726f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98574/
Test PASSed.

ah, good point @imatiach-msft , I missed the HasLabelCol in PredictorParams.  I do agree with @srowen to escalate this, and I'd also suggest to create a design doc for the new hierarchy, so that it can be reviewed more carefully and by a broader audience

I also expose GMM's predictProbability.
could you please make a final pass? @srowen @felixcheung

ping @srowen?

@srowen I have tried it, and found that it seems not good to make clustering models extend PredictionModel. The differences maken by PredictionModel are:
1, override def numFeatures: Int = parentModel.clusterCenters.head.size, it is OK
2, override def predict(features: Vector): Double, current output is Int, this is a breaking change
3, labelCol: Param[String] introduced from PredictionModel, while clustering algs do not have labels.

Ah good point on labelCol, otherwise it would work OK (predict's type we could work around).

Merged build finished. Test PASSed.

Test build #102509 has started for PR 22087 at commit 9e8e3ab.

Test build #102509 has finished for PR 22087 at commit 9e8e3ab.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102509/
Test FAILed.

This might be too much of a change, but the need for labelCol is a training requirement, so if things were factored so that training was decoupled from evaluation (analogous to Estimators & Transformers in ML pipelines?), the evaluation side would be unifiable. Possibly training could be organized so that trainers requiring a label are more specific subclass of unsupervised trainers that do not?

@erikerlandson
I think this PR is good as is, we should decouple what it is fixing and the requirement to have a better base class structure.  I agree that longer-term we need to figure out a better base class structure that brings some of the parts of predictor without the supervised learning requirements.  I suggested to break the class hierarchy into unsupervisedmodel/supervisedmodel that inherit from predictionmodel above.  Removing training params from the model would be a much more radical change across all learners.  In Spark ML we share a lot of parameters on both the estimator and model, even when those parameters are only used during training, which is a little weird.  I actually do agree that it would be a better and more clean change logically to only have training-related parameters on the estimator (and base classes of estimator), but it would put us in backwards compatibility hell, as there is probably tons of user code that relies on this fact.  Moreover, it may be that the label is in some cases used in some of the models for some reason, most likely not but we should make sure.  I think we would need to do more research into that approach.  However, if it were done I don't think it would make a lot of users happy, because suddenly parameters would be missing from the model which they could previously access.  While those parameters logically don't need to be there, they still do offer information about how the model was created so in some sense you could argue that it is good to have them on the model.  I guess it's just a matter of opinion, the important thing is to be consistent across the entire codebase.

retest this please

@imatiach-msft yes, "evaluation" as a synonym for "inference", "prediction", etc

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/8142/
Test PASSed.

Test build #102595 has started for PR 22087 at commit 9e8e3ab.

Test build #102595 has finished for PR 22087 at commit 9e8e3ab.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102595/
Test PASSed.

Merged to master


Create enum for Driver identification

An enum could contain a bunch of information like tag, version, etc. that identifies the driver (maybe a uuid) so that we aren't just relying on strings.

@micahswitzer What information should we include in this that would be useful besides a tag? When we request a driver would we have to know all of the information? How should we go about this? (It would be easy enough to implement)

Well it depends on why the drivers need to be looked up. If we need to get a specific driver, then all we need is a unique tag, otherwise a driver info struct/class could be added to allow the driver manager to find a driver that matches the requested parameters.


Wrap some more commands in "if selinux is enabled"

Pull Request (PR) description
Some selinux commands only work when selinux is enabled.  There are a few that were missed in previous updates.
This Pull Request (PR) fixes the following issues

Github isn't displaying the module.pp diff well, it really is just adding an if wrapper.


An Error message when running the script Run-IDEAR.R .

My environment:

R V3.3.1
RStudio V1.0.136

To start IDEAR,
I run the script "Run-IDEAR.R" in RStudio,but there is an error message on the shinny browser
"Error: missing value where TRUR/FALSE needed"
Any help would be appreciated, thanks.

Can you please provide the session info and the complete error message from RStudio console?

installed_packages <- rownames(installed.packages())
if (!"rmarkdown" %in% installed_packages){

install.packages("rmarkdown")
}

if (!"shiny" %in% installed_packages){

install.packages("shiny")
}

library(rmarkdown)
script.dir <- dirname(sys.frame(1)$ofile)
Error in sys.frame(1) : not that many frames on the stack
setwd(script.dir)
Error in setwd(script.dir) : object 'script.dir' not found
rmdfile = "IDEAR.rmd"
rmarkdown::run(rmdfile)
Error in yaml::yaml.load(string, ...) :
Scanner error: while scanning a simple key at line 3, column 1could not find expected ':' at line 4, column 1

For error:  "Error in sys.frame(1) : not that many frames on the stack", you may have tried to execute code in Run-IDEAR.R line by line. This issue should be resolved if you source Run-IDEAR.r by clicking 'Source' in RStudio.
For error, "Error in yaml::yaml.load(string, ...) ", it shows that your yaml file may have some formatting issues. You can find an example yaml here


@ju5t patch to fix mpm-itk / mod_ruid2 compatibility

This PR contains the patch by @ju5t (with minor adjustments due to change in lines). It's meant to fixing compatibility issues with apache2-itk and mod_ruid2 Apache modules and ModSecurity 2.9.x.
The tests are passing for this patch and according to some users the patch is safe.

Setting milestone to 2.9.3.


Update mosdepth in nf-core modules

Description of feature
Update mosdepth in nf-core modules to v3.3.3

closed by https://github.com/nf-core/modules/pull/1256


Ray ground filter is not actually removing ground points

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
Hello, I am using Autoware.ai + Carla Simulator. The issue I have is that my ray_ground_filter is actually not removing the ground points. So, my vehicle is unable to move because it detects the ground points. Any help would be appreciated.
Expected behavior
The output points topic points_no_ground should be without ground points.
Actual behavior
The ground points are not removed from the output points topic points_no_ground .
Steps to reproduce
Use ray_ground_filter node with points_raw as input topic.
Versions
Ubuntu 18.04
ROS Melodic
Autoware.ai 1.14
Possible causes
Bug in the code
Additional context
Please find the visualization of the no ground topic. i,e points_no_ground
https://drive.google.com/drive/u/0/my-drive

@jfqureshi We cannot determine if this is a bug or parameter issue just from your information.
I think your shared link to google drive isn't valid. If you want to share the file, you have to right click your file and get the link through "Share" option.

Relevant code
Here are some of the parameters that you might want to checkout.

min_height_threshold: points lower than this value will be removed
local_max_slope: angle of slope that the node use to determine if the point is ground or not. Roughly speaking, if the angle between two points has larger than this value, it will be considered as an obstacle.
min_point_distance: Minimum valid distance, points closer than this will be removed.

Also, you might want to make sure that you have tf published between your sensor frame and base_link frame.

@mitsudome-r Thanks for the answer and sorry for the wrong link. Here is the correct link https://drive.google.com/file/d/1X26bm_zTzDOzGxVh6XLew3RIIbcYLUAy/view?usp=sharing
I think the issue is with the parameters(quite convinced). I tried to play with them but I still couldn't get to a point where all the ground points are removed. I have my Lidar at (x,y,z = 0,0,2 m) from the base_link.
Also I wanted to ask the min_height_threshold is with respect to Lidar frame, right?
Here are my ray_ground parameters:

clipping_height = 2.0
local_max_slope = 5.0
min_point_distance = 1.85


Reveal compute wrong screen height and it's positioned relative to body instead of relative to window

I've got a Reveal modal windows which disappear in when opened.
The overlay element appear without the modal window.
Inspecting the code you can see that the modal is positioned outside the screen.
Example:
http://codepen.io/yurimorini/pen/obQQNa
In the example body has a very high height, the modal appear but the window is scrolled at half body dimension instead of half window dimension.
If you look at GetDimension function:
var rect = elem.getBoundingClientRect(),
    parRect = elem.parentNode.getBoundingClientRect(),
    winRect = document.body.getBoundingClientRect(),
    winY = window.pageYOffset,
    winX = window.pageXOffset;

winRect here is bodyRect, in fact replacing winRect with this, the modal is positioned in the right place
// not so cross browser
var winRect = { width: window.innerWidth, height: window.innerHeight };

Tested on Firefox and Chrome on Windows

@yurimorini so did you fix this and create a pull request

@bevdam GetDimension is used everywhere in the code, maybe I wrongly understand the meaning of the whole code, 'cause i never played with it. So I'm waiting for a feedback (is it a bug? the issues is not labeled as bug) and then, if I can i create a pull request.

@yurimorini  sure thing . Thanks

On the actual foundation documentation examples the popup is bugged to begin with. The scroll bar disappears(the track remains) which causes the content behind the modal popup to shift to the right.

Hi, I figured out what was causing my position errors. In foundation 6 they removed the ajax request.
I was ajax to populate the reveal using the open callback assuming it would resize and position  according to the content loaded. It did not. To fix after I change content I trigger resizeme.zf.trigger on the reveal. Problem no Problem. FYI

@yurimorini this appears to have been fixed in a recent update. When I bump the versions to 6.2.1 in your CodePen example it doesn't scroll halfway down the page when I close the reveal modal. Feel free to reopen the issue if there's still problems. Thanks!


📗 Update README.md

As asked by @Shougo, I'd updated README. I also fixed and improved lots of things and chose to sent everything in one commit & PR 🙃
I know it isn't an proper convention-like behavior but I was really short on time. Overall, it's looking like an production-like README file.
Changes

Add metadata badges using the widely used shields.io
Add details to give the option to hide the table of contents
Change features section to improve readability.
Add getting started section to help new users
Add details to control visibility of config examples
Add question & answers to answer most relevant questions.
Add feedback section to help user who want to contribute with the project
Change TODO section
Add License info in the footer to follow README conventions

Notes
It would be nice to have an way to track the versions. Setting it manually, everytime, seems a bit off. What you think?

Oh...    It is very big..  I need more time to check.

It would be nice to have an way to track the versions. Setting it manually, everytime, seems a bit off. What you think?

I don't know the better way...

It would be nice to have an way to track the versions. Setting it manually, everytime, seems a bit off. What you think?

I don't know the better way...

I think the most viable way would be:

To use the versioning system within Github together with Github Actions
This way we could automatically track version for each realese, and run all actions needed.

An example using the release system on Github we can do something like this:

![GitHub release (latest by date)](https://img.shields.io/github/v/release/microsoft/vscode)

Which would automatically get the latest stable release.
You can see more about here.

OK.  I will add release.

I have released 3.0.


[EH-checkpoint-store-blob] guard against undefined blob metadata

There's a recent behavior change in Blob SDK that empty metadata is now returned as undefined (issue# 21863) instead of previous value of empty string.  This PR adds a guard against undefined metadata so we don't access property off undefined.

API change check for @azure/eventhubs-checkpointstore-blob
API changes are not detected in this pull request for @azure/eventhubs-checkpointstore-blob

Hmm, that sounds like a breaking change on their part.

yup, the linked issue tracks that.

/azp run js - eventhubs-checkpointstore-blob - tests


virt_mshv_vtl: Remove comments relating to unwinding interrupts

The legacy HCL has a concept of 'rewinding' interrupts, which allows it to reevaluate interrupt state in certain scenarios that update it. I believe this is not needed in OpenHCL due to our architecture of always reevaluating all of our interrupt state every time we re-enter run_vp. Remove the comments mentioning this as a todo.

I actually think we do need to implement rewinding.

For SNP at least I don't think there's anything we need doing, as at the beginning of poll_apic we clear out the irq bit before proceeding, and we always call poll_apic for both vtls before exiting to the guest. What more would we need to do when?


M1 setup update: React instructions

This PR seeks to update the M1 instructions to include proper startup instructions for frontend-react.
Test Steps:

Follow the instructions in prime-router/docs/getting-started/Using-an-apple-silicon-mac.md
Log in to RS from the frontend to ensure network calls are returning properly

Changes

frontend-react/package.json:  Added proxy to alleviate cors issue when running prime-router on M1
frontend-react/src/resources/AuthResource.ts:  Returns localhost:3000 since proxy handles routing that to the proper port
prime-router/docs/getting-started/Using-an-apple-silicon-mac.md:  Updated to reflect React app setup

Checklist
Testing

[X] Tested locally?
[X] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[X] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#issue - List GitHub issues this PR fixes

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
34
18h 35m
25

cwinters-usds
25
8h 10m
12

kevinhaube
24
16m
4

carlosfelix2
23
4h 56m
186

clediggins-usds
21
1h 7m
34

sean-usds
16
1h 32m
2

jimduff-usds
12
17h 22m
28

RickHawesUSDS
11
1h 45m
16

whytheplatypus
9
17h 40m
67

ronaldheft-usds
8
1h 53m
7

TomNUSDS
8
1h 34m
11

jeremy-page
4
14m
0

brick-green-agile6
4
2d 20h 22m
1

jbiskie
3
1h 5m
0

sethdarragile6
2
10h 27m
9

ahay-agile6
1
2d 16h 45m
0

jorg3lopez
1
1h 48m
0

Also, the localhost port changes impact places outside the react project? e.g. Here

@TomNUSDS I pulled and tested on my Linux machine where RS is running in Docker, and the calls still work! The only downside is that when you're in Dev Tools > Network in your browser, the calls do show as being from localhost:3000 which is technically false. The proxy only applies to local development and is never built in when deploying.
I definitely encourage more people to pull down and try this on non-M1 with RS in Docker to ensure this proxy doesn't create issues!


[WIP] Step functions integration

Pull Request Test Coverage Report for Build 1224

0 of 0   changed or added relevant lines in 0 files are covered.
77 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.3%) to 65.829%

Files with Coverage Reduction
New Missed Lines
%

dist/plugins/Trace.js
2
85.05%

dist/plugins/integrations/AWSIntegration.js
75
73.3%

Totals

Change from base Build 1112:
0.3%

Covered Lines:
2144

Relevant Lines:
2999

💛  - Coveralls


supported orientations

Unless I'm missing it, I don't see any indication of the supported orientations for this lib. Can this lib record video in portrait and landscape?

nm, got the demo-playground app loading which seems to allow portrait recording


Problems with Firefox 68.0.1 non Mac OS 10.14.6

Installed FakeSpot but I am not getting an icon in the URL for Amazon.  (see pic) And the dropdown has it greyed out?  Suggestions?

So I just tried disabling and re-enabling and I have the icon now?  Sorry for the bother.


gem install rubysl-digest -v '2.0.8' gives error

gem install rubysl-digest -v '2.0.8'
Building native extensions.  This could take a while...
ERROR:  Error installing rubysl-digest:
ERROR: Failed to build gem native extension.
/Users/nehaboob/.rvm/rubies/ruby-2.0.0-p598/bin/ruby -r ./siteconf20160508-29924-1u51b91.rb extconf.rb

creating Makefile
make "DESTDIR=" clean
make "DESTDIR="
compiling digest.c
digest.c:544:6: error: use of undeclared identifier 'RUBY_TYPED_FREE_IMMEDIATELY'
(RUBY_TYPED_FREE_IMMEDIATELY|RUBY_TYPED_WB_PROTECTED),
^
digest.c:544:34: error: use of undeclared identifier 'RUBY_TYPED_WB_PROTECTED'
(RUBY_TYPED_FREE_IMMEDIATELY|RUBY_TYPED_WB_PROTECTED),
^
2 errors generated.
make: *** [digest.o] Error 1

As per https://github.com/rubysl/rubysl-digest/issues/1#issuecomment-217707809 you can not use rubysl Gems with MRI, they only work with Rubinius.


{App Service} Bugfix: az webapp create error handling, appservice tests

Description

Improve error handling for az webapp create
Test improvements so test_webapp_commands file can run live.

Fixes #13488
Testing Guide

az webapp create -g RG --plan NonExistentPlan --name "WebappName" Should return error "The plan {} doesn't exist in the resource group {} instead of "error: nonetype has no attribute location"

az webapp create -g RG --plan Plan --name "Invalid***name" Should return "Hostname must be less than 64 chars and must follow characte rguidelines..." instead of "The resource Microsoft.web/sites/Iinvalid***name under resource group {} was not found..."

az webapp create --resource-group RG --plan Plan --name ExistingWebappNameFromDiffRG Should return "The webapp {} exists in resource group {} and does not match the value entered {}. Please re-run command" instead of "The resource Microsoft.web/sites/Iinvalid***name under resource group {} was not found..."

azdev test test_webapp_commands --live should pass

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

App Service

hi @calvinsID @panchagnula would you like this PR to be merged now?


Nebula

This is the background/nebula thing. I also re-added the debug panel so we can configure the visual more easily.
Here’s a question, tho: If reveal means “danger mode”, and “danger mode” is red, does the game start in red? In this branch I start in flag mode (blue) and shift forces reveal mode. That actually works quite well, but might be very unintuitive for people who expect the old Minesweeper behavior.
// Edit: Changed my mind. The switch from blue to red is actually super nice as a signal that the game has started.
I also renamed altMode to dangerMode to make it more descriptive.

If you're happy with https://github.com/GoogleChromeLabs/graviton/pull/50, merge it into this branch first to avoid having to rebase.


Server log messages should use window/logMessage

Currently, the server uses the tracing module for log messages which sends everything to stderr. This gets picked up by the client and is added to the log messages at different level regardless of the level used in the server. This level is set by the client.
Here's what VS Code shows:
2024-04-16 12:00:50.229 [info] ┐ruff_server::server::api::notifications::did_change::run{file=file:///Users/dhruv/playground/python/animation.py}
┘
2024-04-16 11:59:47.905 [info]    0.101369s ERROR ruff_server::session The following error occurred when trying to find a configuration file at `/Users/dhruv/playground/python`:
No pyproject.toml/ruff.toml/.ruff.toml file was found
   0.101425s ERROR ruff_server::session Falling back to default configuration for `/Users/dhruv/playground/python`

Here's what Neovim shows:
[START][2024-04-16 12:06:02] LSP logging initiated
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.001027s DEBUG ruff_server::server No workspace(s) were provided during initialization. Using the current working directory as a default workspace...\n"
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.041356s ERROR ruff_server::session The following error occurred when trying to find a configuration file at `/Users/dhruv/playground/python`:\nNo pyproject.toml/ruff.toml/.ruff.toml file was found\n   0.041386s ERROR ruff_server::session Falling back to default configuration for `/Users/dhruv/playground/python`\n"
[ERROR][2024-04-16 12:06:02] .../vim/lsp/rpc.lua:789	"rpc"	"/Users/dhruv/work/astral/ruff-test/target/debug/ruff"	"stderr"	"   0.044606s WARN ruff_server::server LSP client does not support dynamic capability registration - automatic configuration reloading will not be available.\n┐ruff_server::server::api::notifications::did_open::run{file=file:///Users/dhruv/playground/python/errors.py}\n┘\n"

This is not a high priority. We would need to look at all the messages using tracing and convert most of them to use the notification request instead.

cc @snowsignal

Thanks for opening an issue for this @dhruvmanila

We decided to continue using stderr for now. I'll keep this issue open to track the tracing rewrite.


Find the build directory from kbuild.toml

Projects using the kbuild system store the kompiled directory in something like this:
/Users/user/.kbuild/mir-semantics/49061f8/target/v5.6.88-0-g4c09d86ed2/llvm
klsp should query kbuild and find that location.
@tothtamas28 can you explain how to do that?

Command kbuild which <target> should give that output.


[4552] Data migration to fix awarded trainees but with no award data

Context
https://trello.com/c/8DPsLkrO/4552-investigate-why-these-trainees-are-awarded-qts-but-have-no-awardedat-date-on-dqt
The following spreadsheet was used to code the data migration: https://docs.google.com/spreadsheets/d/1k-vS_QG03CTxfis-CQHICV-8b_kMKBsVQ02pvew5QW0/edit#gid=1116655494
Changes proposed in this pull request

Data migration that assigns an award date to a small number of awarded trainees, but changes the remaining trainees to either trn_received, withdrawn or deferred.

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Investigate why these trainees are 'Awarded QTS' but have no Awarded_at date on DQT


Possibility to define custom dartls command

Since it's not recommended using lspconfig in conjunction with dartls when using this plugin, I'm wondering about situations where you have a plain Dart codebase (no Flutter) that depends on an a specific version of Dart and not the one provided in the Flutter SDK.
I'm not sure if this is a real problem (maybe more like a question of if this setup can cause any issues relating to it), but thought I'd open an issue on it anyways because this came to mind during #30 when I was messing around with settings trying to override the dartls cmd like this:
require("flutter-tools").setup {
  lsp = {
    cmd = { "some", "custom", "path", "outside", "flutter", "sdk" }
  }
}

Or maybe it's a way to only use flutter-tools on flutter projects somehow via the neovim Lua APIs, and then manual lspconfig for others. I'm pretty new to all of this neovim 0.5 goodness, so there might be an obvious answer staring me right in the face.

@andersevenrud it wouldn't be too hard to allow the user to pass in a custom command and use that instead of the one this plugin derives. Tbh most of the current functionality is primarily aimed at flutter usage and even then the most common usages, I work on a few dart packages and this plugin works fine with those but dart only usage isn't what I prioritise.
anyway to the original point I can make a change to allow setting a custom command for the lsp

@andersevenrud this has been fixed by 791b57e.

Sweet! Thanks :)


render footnotes generated in richtextblock

How to name/ refer to footnotes in a block
In models.py I can generate footnotes as expected. Yet, if I use the same block it doesn't render the note. That is, I create and populates the notes in  Admin, in the template they appear with the Admin with system's ref, and the footnotes section is empty - {% include "wagtail_footnotes/includes/footnotes.html" %}.
class Notes1Page(Page):
    body = StreamField([
        ('fnotes', RichTextBlockWithFootnotes(label=("Feature type"), blank=True, default='abc',)),
    ])    ...

    content_panels = Page.content_panels + [
        FieldPanel('body', classname='full'),        ...
    ]

this above works, but the below doesn't:
class ColumnBlock(blocks.StreamBlock):

    paragraph = blocks.wagtail_footnotes.blocks.RichTextBlockWithFootnotes(editor='full', label='Paragraphe')
    # error: 'wagtail.core.blocks' has no attribute 'wagtail_footnotes'
    paragraph1 = blocks.RichTextBlock(editor='full', label='Paragraphe')    #full' is defined in WAGTAILADMIN_RICH_TEXT_EDITORS/base.py,
    paragraph2 = blocks.RichTextBlock(features=["bold", "italic", "link", "footnotes"], required=False, label='Paragraphe2')

    paragraph3 = RichTextBlockWithFootnotes(features=["bold", "italic", "footnotes"], required=False, label='Paragraphe Notes1')
#Paragraph1-3 generate footnotes in the Admin, but don't render them in the template.
    ...

Hi @DBonbon. I see the reference to blocks.wagtail_footnotes.blocks.RichTextBlockWithFootnotes. This should be wagtail_footnotes.blocks.RichTextBlockWithFootnotes, and you will need to have imported wagtail_footnotes.
I am unclear about what else you are describing, but I hope the change above is enough to help you resolve this. If you have further issues after this, please update the ticket.


Eigen 3.3 support

It seems that Eigen is changing its API for Eigen::ProductType structures, and as Ubuntu 16.04 LTS is coming with the last Eigen 3.3-beta development version, we need to comply with the new API.

solved by #213.


Add support for go errcheck

https://github.com/kisielk/errcheck
This checker checks for unchecked errors (ha ha), an idiom in go.

I think I looked at errcheck some time ago, and decided there is no reasonable way to make it run from syntastic.  Please feel free to prove me wrong by posting a (working) PR though. shrug

Currently ErrCheck is a bit slow to be able to run on ever save (which triggers :SyntasticCheck). Please keep this issue open until we resolve this.

Update: ErrCheck has become quite fast (see kisielk/errcheck/#56). Might be worth adding support for it now.

As far as syntastic is concerned, the speed of ErrCheck has never been the main issue.  The main problem was, and still is, how to make it run from syntastic.  Like I said: please feel free to post a working PR if you can figure out how to solve it.

will do

As of commit 8bb535b, the gometalinter checker can be used to run errcheck.

@lcd047 awesome, thanks for keeping up with this issue! :+1:


Updated TestAttributes, added runner

Any chance you can PR this from feature/tests to the feature/104 so it can be included there?


make dhtclient the default again

@lidel so I propose we change that back to dhtclient as long as we cannot ask the user if this is a mainly mobile computer since we would burn too much battery life.
Originally posted by @RubenKelevra in https://github.com/ipfs/ipfs-desktop/issues/1859#issuecomment-877710249

I mean isn't https://github.com/ipfs/ipfs-desktop/blob/c345eccc91a8612c182cb519c20b0895a07c17aa/src/common/store.js#L11 overwriting the config anyway?

Corect, nothing to do here, dhtclient is the default.
What we discussed in https://github.com/ipfs/ipfs-desktop/issues/1859#issuecomment-892054779 is adding UI for switching from dhtclient (default) to dht (server if publicly diallable)


Customized characteristics and Services not exposed

We are configuring our services in the following way.

We are able to connect to the device through app but whatever services we are configuring is not being detected by the ble scanner app on my phone.
Ble scanner output is like

If you could share more information regarding how to configure Services and Characteristics, it would be a great help.

Hi, can you share some information how this problem is resolved?


feat(task/prettier-conformance): splitting test cases by file

Current dependencies on/for this PR:

main

PR #1373   👈

PR #1374

This stack of pull requests is managed by Graphite.

This is awesome btw! Let's merge this asap.

You can run just lint before pushing ;-)

I always forget to run it, it would be nice to have a git hook to automatically check for it 😬

Merge activity

Nov 17, 7:13 AM: @Boshen started a stack merge that includes this pull request via Graphite.


Why does my Python 3.10 run with this error

File "/Users/oceanfly/.conda/envs/python3.10.0_env/lib/python3.10/site-packages/anyio/to_thread.py", line 56, in run_sync
return await get_async_backend().run_sync_in_worker_thread(
File "/Users/oceanfly/.conda/envs/python3.10.0_env/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 2177, in run_sync_in_worker_thread
return await future
File "/Users/oceanfly/.conda/envs/python3.10.0_env/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 859, in run
result = context.run(func, *args)
File "/Users/oceanfly/.conda/envs/python3.10.0_env/lib/python3.10/site-packages/gradio/utils.py", line 826, in wrapper
response = f(*args, **kwargs)
File "/Users/oceanfly/workspace/ai/HivisionIDPhotos/demo/processor.py", line 129, in process
return self._process_generated_photo(
File "/Users/oceanfly/workspace/ai/HivisionIDPhotos/demo/processor.py", line 327, in _process_generated_photo
return self._create_response(
TypeError: IDPhotoProcessor._create_response() takes 6 positional arguments but 7 were given

Is it the latest commit on the master branch? This issue should have been fixed yesterday


[stable/mongodb] fix README.md according to values.yaml

What this PR does / why we need it:

fixme README.md values according to values.yaml

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test
/lgtm


mb_strpos() expects parameter 1 to be string, object given

Hey there,
Just updated to the latest version. Suddenly all pages have stopped working. (They seem to be working once, until I navigate to the page again. Clearing the cache through the grav dashboard let's me visit the page again without error.)
The error I get is mb_strpos() expects parameter 1 to be string, object given in file /system/src/Grav/Common/Page/Page.php on line 684.
Anyone know what's up?

Which version? Stable or RC?

Which version? Stable or RC?

v1.5.10 Stable

I have no idea why page content would be an object:
$divider_pos = mb_strpos($this->content, "
{$delimiter}
");

Maybe the issue in a plugin you're using?

I have no idea why page content would be an object:
$divider_pos = mb_strpos($this->content, "
{$delimiter}
");

Maybe the issue in a plugin you're using?

It seems like you're right.


v0.0.300 documentation

write in rst to prevent accidental ruining the docs

-[ ] Get Started
-[ ] Installation and Setup
-[ ] Quick Start
-[ ] Configuration
-[ ] Concepts
-[ ] Cookbook
-[ ] Session Interactions
-[ ] RAG - Auto Developer
-[ ] RAG - Auto Researcher
-[ ] Async Function calling
-[ ] Rate Limited Concurrency
-[ ] API references
-[ ] Integrations

API references
-[ ] Messages
-[ ] Conversation
-[ ] Session
-[ ] Branch
-[ ] Services
-[ ] Base Nodes
-[ ] Flow
-[ ] CallUtils
-[ ] Nested Utils

Basically done, except bridge and integrations, they might need to wait until next release


Update index.html

Lihat usulan perubahannya di https://commons.wikimedia.org/wiki/Commons_talk:Wiki_Loves_Earth_2017_in_Indonesia#Translation

If logged out, when I go to https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wle-id&uselang=id
I only get an error message "Harus masuk log \n
Anda harus masuk log untuk dapat mengunggah berkas."
I do not see a banner.
I do not see anything else relevant to the campaign.
When I visit https://commons.wikimedia.org/wiki/Campaign:wcai-id while logged out, I see the campaign page, and the banner.

@jayvdb I suggest you must clear your browser cache. In mine, it is displaying the campaign page. Make sure you don't intentionally hide CentralNotice.

I believe this pull request should be closed right away, as @yakuka has already modified the page I would like to do.

@Rachmat04 , you must test it when logged out.

@jayvdb: I see that. If you click https://commons.wikimedia.org/w/index.php?title=Special:UploadWizard&campaign=wle-id&uselang=id (started with Special:UploadWizard), it required one to log in/create an account. However, if you directly go to https://commons.wikimedia.org/wiki/Campaign:wle-id (namespace Campaign), you can still see the upload page and the banner even you're not logged in.

CMIIW


Updating parameter restrictions for Microsoft.DevSpaces resource

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[x] The spec follows the guidelines described in the Swagger checklist document.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

@lmazuel We use AKS resource's information to create our resource and this is the restriction imposed by them for the resource name. Since we default to the AKS resource name when this parameter is not supplied in our client, I've changed the restriction here to reflect the same. Please take a look.


[Suggestion]: Add tooltip to indicate which word a tome is.

General Info

[X] I would like to propose new content
[X] I would like to propose changes
[ ] I would like to propose another thing

Suggestion Description
Other than first using the book, its nearly impossible to check which ancient tome gives which word. The only workaround for this is to use the \data get entity <player> command and look for the book. This is extremely inconvenient for those wanting to distinguish the books.
My proposal is to have add a tooltip which says the word it corresponds to, and maybe it's translation.

My dumbass didn't see the config option that does this exact thing which is disabled by default.
Sorry for the inconvienence.


Add left and right suffix parameters to join handler, plus unit test

I will refactor these tests to use new frameworks so that we don't have to write the tests again this weekend

retest this please


It is recommended to hide some icons in the toolbar in the upper right corner of vscode

Issue Type: Feature Request
Some plug-ins I installed will add corresponding icons on the toolbar in the upper right corner of vscode, which looks too uncomfortable. I hope to hide some icons. Make the toolbar in the upper right corner cleaner
VS Code version: Code 1.61.0 (ee8c7def80afc00dd6e593ef12f37756d8f504ea, 2021-10-07T18:13:09.652Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

/duplicate of #46403


[MBL-1685] NoShippingPostCampaignCheckoutViewController

📲 What
Creates a new NoShippingPostCampaignCheckoutViewController class so that we can keep our estimated shipping work behind our feature flag w/o touching the current flows on production.
🤔 Why
Unfortunately, PostCampaignCheckoutViewController has been where we've been updating the late pledge UI, however, we should have been working in a new NoShippingPostCampaignCheckoutViewController to stick with the pattern that the other VCs are following and so that the late pledge flow in Production can remain untouched.
🛠 How
Creates this new VC and VM and reverts the changes to the original, PostCampaignCheckoutViewController class and VM.
✅ Acceptance criteria
Granted there are remaining issues found in our QA party

[x] Both Checkout flows function and look as expected when featureNoShippingAtCheckout is OFF
[x] Both Checkout flows function and look as expected when featureNoShippingAtCheckout is ON
[x] All tests pass

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
Big PR

  Generated by :no_entry_sign: Danger

@ifosli feels like I'm still facing that local snapshot issue here 🫠


site loading torrent just spinning

site loading torrent just spinning, it never displays anything beside a spinning wheel.

Means that whatever you are trying to download doesn’t have webrtc seeds or you can’t connect to them
Diego

On 30/06/2022, at 1:36 AM, povch @.***> wrote:

site loading torrent just spinning, it never displays anything beside a spinning wheel.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

can you delete it and make it stop spinning? It has lots of seeds however.

delete what? are you sure there are WebRTC (webtorrent) peers? TCP/UDP (normal) desktop seed do not count.

https://ibb.co/7C5YHnx image of problem

Again, it's not a problem, it's by design. If there are no WebTorrent seeds for the torrent you are trying to download, there's nothing...

On Thu, Jun 30, 2022 at 8:09 AM Diego Rodríguez Baquero <
@.***> wrote:

Means that whatever you are trying to download doesn’t have webrtc seeds
or you can’t connect to them
Diego

On 30/06/2022, at 1:36 AM, povch @.***> wrote:

site loading torrent just spinning, it never displays anything beside a
spinning wheel.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

—
Reply to this email directly, view it on GitHub
https://github.com/DiegoRBaquero/BTorrent/issues/98#issuecomment-1171199027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ3NRFJEB7PT7ZJSNKZLZ5LVRWL7RANCNFSM52IFLWKA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Remove Driver::task_ member variable

Before this change Driver held two references to task: direct (task_ member
variable) and via DriverCtx (ctx_.task). Direct reference was dropped in
Driver::closeByTask and Driver::disconnectFromTask, but the other references
remained until Driver is destroyed.
Having two references is redundant, hence, this change is to remove task_ member
variable and use ctx_.task instead.

@majetideepak Deepak, thank you for reviewing. Addressed comments.


[iOS] Fix iOS export with manually specified signing/provisioning data.

Seems like Xcode now defaults to the Automatic signing mode unless Manual signing style is set in the project.

For automatic signing mode only App Store Team ID should be set, the rest can be left blank.
For manual signing, Provisioning Profile UUID and Codesign Identity should be also set.

Note: I do not have an Apple Developer account, and can't fully test it, but it seems to be working at least for the ad-hoc mode.
Fixes #57195

Thanks!

Cherry-picked for 3.5.

Cherry-picked for 3.4.3.

FYI, I still see "iPhone Developer" and "iPhone Distribution" when I'm trying to get the "Automatic" provisioning style. Worked around with this as a wrapper for xcodebuild (changed PATH before invoking Godot)
#!/bin/bash
PBX=out/ios/MyAmazingGame.xcodeproj/project.pbxproj

# undo godot's v3.5.2 wrong take here

sed 's/iPhone Developer//' < $PBX > $PBX.fix
mv $PBX.fix $PBX
sed 's/iPhone Distribution//' < $PBX > $PBX.fix
mv $PBX.fix $PBX

exec /usr/bin/xcodebuild "$@"


Loading Onnx file is not work

As the title said, when I run F5 with x64 Local Machine, it show this runtime error, please help, thanks~
this is my environment:

this is the error message

@Zenylin - can you set our min version to 17134 and let me know if the error continues please?

please re-open if still having the issue


Create logging for remove_inactive to log which or how many wells are removed from the simulation

Fixed in https://github.com/Deltares/imod-python/pull/1067


[team] Update team.json

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
I got invitation to the fastlane team 👨💻 some time ago.
Description
I added myself to the list of team members.

Thanks :)


Icon

Hm I think that's too big for the README. Maybe Alex can make a banner-shaped version for us to post?

Just pinged Alex about it on slack. We'll see what he comes back with.

Done! New banner.


Add batching for pending transactions query response

          I don't understand when it should be done. Consider adding description or create an issue

Originally posted by @Arjentix in https://github.com/hyperledger/iroha/pull/3621#discussion_r1272696671

there is no more pending transactions endpoint


Fix misc things

A few independent small commits drawn from a WIP branch.

lgtm after moving 5e7ab9367605c46146b907f2a8f425e91d450da0 to a new PR

@grahamc done

Rebased on master, merging.


USSD Public Registration - complete functionality

complete registration by adding functionality at the end of flow to save input and corresponding data

@gsvr at this point, the tests and corresponding fixtures need some work...

@imsickofmaps Please review.

first pass done, minor changes required then I'll re-review

@imsickofmaps Please have second look.

@gsvr minor comment and missing a test for someone not having health id - then :+1:


InvalidDataLayout error thrown from ViewIRGraph

Trying to use the ViewIRGraph executable provided by llvm-tools on an IR file created by clang 3.5 on a 64bit machine throws an error from src/LLVM/Parse.hs in this llvm-data-interop package.
$ ViewIRGraph -t Cfg -f Pdf -o out.pdf ~/tmp/example.ll
ViewIRGraph: InvalidDataLayout "e-i64:64-f80:128-n8:16:32:64-S128" "Invalid float alignment preference: 80:128"

The data layout in example.ll is:
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"

What version of llvm did you link llvm-data-interop against?  And what version of llvm-data-interop is in play?

LLVM version 3.5.0
llvm-data-interop-0.4.0


Design User Notifications

This is lacking a description and does not look like a priority to me. I'm closing it to do some backlog grooming.


No rule to make target '../deps/sqlite3.tar.gz'

When I tried to run npm rebuild better-sqlite3 --update-binary, the compilation failed with
make: *** No rule to make target `../deps/sqlite3.tar.gz', needed by `b857c92884e9598d609f6be182a2595df7a8e00f.intermediate'.  Stop.

The complete output is
0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   '/usr/local/bin/node',
1 verbose cli   '/usr/local/bin/npm',
1 verbose cli   'rebuild',
1 verbose cli   'better-sqlite3',
1 verbose cli   '--update-binary'
1 verbose cli ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 info readInstalled object
5 verbose rebuild path, id [
5 verbose rebuild   '/Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3',
5 verbose rebuild<EMAIL_ADDRESS>5 verbose rebuild ]
6 silly rebuild set [
6 silly rebuild set   '/Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3'
6 silly rebuild set ]
7 info build /Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3
8 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>9 info linkStuff<EMAIL_ADDRESS>10 silly linkStuff<EMAIL_ADDRESS>has /Users/jerry/Desktop/restructured-notes/node_modules as its parent node_modules
11 verbose rebuildBundles [ '.bin', 'minipass', 'tar' ]
12 verbose rebuild bundle /Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3/node_modules/minipass
13 info build /Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3/node_modules/minipass
14 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>15 info linkStuff<EMAIL_ADDRESS>16 silly linkStuff<EMAIL_ADDRESS>has /Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3/node_modules as its parent node_modules
17 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>18 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>19 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>20 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
21 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3/node_modules/.bin:/Users/jerry/Desktop/restructured-notes/node_modules/.bin:/Library/Frameworks/Python.framework/Versions/3.8/bin:/Library/Frameworks/Python.framework/Versions/3.7/bin:/usr/local:/Users/jerry/Qt/5.12.0/clang_64/bin:/Library/PostgreSQL/11/bin:/Library/Frameworks/Python.framework/Versions/3.8/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/aria2/bin:/opt/X11/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/Applications/Wireshark.app/Contents/MacOS:/Users/jerry/Library/Android/sdk/build-tools/27.0.0:/Users/jerry/Library/Android/sdk/tools:/Users/jerry/Library/Android/sdk/platform-tools:/opt/local/bin:/opt/local/sbin
22 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/jerry/Desktop/restructured-notes/node_modules/better-sqlite3
23 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'prebuild-install || npm run build-release' ]
24 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
25 info lifecycle<EMAIL_ADDRESS>Failed to exec install script
26 verbose stack Error<EMAIL_ADDRESS>install: `prebuild-install || npm run build-release`
26 verbose stack Exit status 1
26 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:332:16)
26 verbose stack     at EventEmitter.emit (events.js:210:5)
26 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
26 verbose stack     at ChildProcess.emit (events.js:210:5)
26 verbose stack     at maybeClose (internal/child_process.js:1021:16)
26 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
27 verbose pkgid<EMAIL_ADDRESS>28 verbose cwd /Users/jerry/Desktop/restructured-notes
29 verbose Darwin 18.7.0
30 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "rebuild" "better-sqlite3" "--update-binary"
31 verbose node v12.13.1
32 verbose npm  v6.14.5
33 error code ELIFECYCLE
34 error errno 1
35 error<EMAIL_ADDRESS>install: `prebuild-install || npm run build-release`
35 error Exit status 1
36 error Failed at the<EMAIL_ADDRESS>install script.
36 error This is probably not a problem with npm. There is likely additional logging output above.
37 verbose exit [ 1, true ]

I'm running under macOS 10.14.5 with Node 12.13.1.

Closing due to inactivity

Thanks @gz-95. That helped me find that the issue was .yarnclean for me also. In addition to Makefiles, I had the following in my .yearnclean file.
# misc
*.gz
*.md

Which was causing the following error for me.
*** No rule to make target '../deps/sqlite3.tar.gz'

Once, I deleted my .yarnclean everything compiled fine. You also need to rm -rf node_modules and run yarn or npm i again.


execute as bash script

and fail on error.
in order to better see what breaks.
PW @kdomanski @adebasi

FYI @Jimdo/wonderland


CI: network errors on macOS CI runs

Opening this for visibility.
Been seeing this issue come up again and again in the macOS CI runs. And it doesn't happen in the Linux runs.

At the moment, we're compiling 39 generated examples as part of our integration tests. And in many cases, at least one would have this error, causing the whole job to fail.
Of course, you can retry and, often, that works, but it's an issue nonetheless.
It seems the error might originate from git2, cargo uses this internally, and we do too.

 In this CI run, cargo included a suggestion that I'll investigate
test cargo::test_dependency_explicit ... FAILED
Caused by:
    `cargo metadata` exited with an error:     Updating git repository `[https://github.com/near/near-sdk-rs.git`](https://github.com/near/near-sdk-rs.git%60)
    warning: spurious network error (2 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
    warning: spurious network error (1 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
    error: failed to get `near-sdk` as a dependency of package `test_dependency_explicit v0.1.0 (/Users/runner/work/cargo-near/cargo-near/target/_abi-integration-tests/test_dependency_explicit)`

    Caused by:
      failed to load source for dependency `near-sdk`

    Caused by:
      Unable to update https://github.com/near/near-sdk-rs.git?rev=03bab8db6145e038626c4b15b34b0bd8a33fba44

    Caused by:
      failed to clone into: /Users/runner/.cargo/git/db/near-sdk-rs-7ba52202f378a9d9

    Caused by:
      network failure seems to have happened
      if a proxy or similar is necessary `net.git-fetch-with-cli` may help here
      https://doc.rust-lang.org/cargo/reference/config.html#netgit-fetch-with-cli

    Caused by:
      SecureTransport error: connection closed via error; class=Net (12)

If that works, we might have to favor the git CLI over the use of git2.
Some other failed runs from this error, to list a few:

https://github.com/near/cargo-near/runs/8051088839?check_suite_focus=true#step:3:479
https://github.com/near/cargo-near/runs/8050949081?check_suite_focus=true#step:3:665
https://github.com/near/cargo-near/runs/8051078310?check_suite_focus=true#step:3:641

Just ran into this issue while running our tests locally. So it's not a CI thing. But it's macOS only afaik.

It seems the error might originate from git2, cargo uses this internally, and we do too.

So you suspect this is some sort of concurrency issue between us and cargo (via git2)?

Seeing as we're cloning to a temp directory different from what cargo uses, I won't have expected a concurrency issue (at least not on the part of cloning the same repo to the same directory). Especially since this behavior is not observed in non-macOS tests. But the common denominator between us, and cargo is that dependency. Perhaps the concurrency issue might be the http protocol via curl, but that's even weirder of an issue. One request causing the other to fail.

Yeah, that is my intuition as well, was just wondering if you had a specific issue in mind. Yet to experience it myself, but I will keep my eyes open to see if there is a way to reproduce it consistently.


Limit Laserscan in z-Direction < X ?

Hi @koide3,
Is there a possibility to ignore the laserscans under a certain high?
Like for example, Velodyne is positioned in 2.5m high, ignoring all input under 2.0m.
Problem is our car stands in position while +10/20 pedestrians moving constantly around, probable causing this output:

Same launch-file and location by evening/night leads to a good map (Package download ~early/mid 2019):

Adding GPS didn't improve.
Tested on two different systems (Ubuntu 16.04 & kinetic) with the same result.

Off-Topic:
Btw when we use the latest download version with the same launch and bag-file from picture 2, we get this result (Package download 06.02.2020):

First loop should be the square shown in picture 2. We also get the shift in z-Direction with this version, some of the users already noticed.
Update: Seems like the the launch file got updated/more options? Get the same result now.
First problem still remains, trying to edit the range of my lidar signal with lidar_to_pointcloud and pointcloud_to_lidar.
Thank you!

Hi @ASE-HHN ,
Regarding the first issue, an easy solution is to create a small problem to filter out unnecessary points. Using lidar_to_pointcloud is also a good option.
If you see a problem relating to the second issue again, please let me know.


Add secondary content size

This now includes re-applying #13. Doing this "correctly" was impossible, so I ended up having to squash everything on this branch. See the extended commit message for the first commit to see the changelog.


Add support for tagged template literals

TODO:

[ ] type inference
[ ] code generation

Codecov Report

Merging #169 (4f70495) into main (a6de74e) will increase coverage by 0.03%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.03%
==========================================
  Files          32       32
  Lines        3573     3619      +46
==========================================
+ Hits         3317     3361      +44
- Misses        256      258       +2

Impacted Files
Coverage Δ

crates/crochet_ast/src/expr.rs
72.72% <0.00%> (-7.28%)
:arrow_down:

crates/crochet_codegen/src/js.rs
90.68% <ø> (ø)

crates/crochet_infer/src/infer_expr.rs
98.29% <ø> (ø)

crates/crochet_parser/src/expr.rs
99.57% <100.00%> (+0.07%)
:arrow_up:

crates/crochet_parser/src/lib.rs
98.55% <100.00%> (+0.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


Negative returns on efficient_return()

I'm trying to optimize the volatility of a portfolio with a given return. The portfolio is a long/short one and should be equally weighted, therefore I'm using the following code:

df = pd.DataFrame({symbol: prices[symbol] for symbol in symbols})
mu = pd.Series([returns[symbol] for symbol in symbols], index=symbols)
sigma = risk_models.CovarianceShrinkage(df).ledoit_wolf()
ef = EfficientFrontier(mu, sigma, weight_bounds=(-1,1))
pfolio = ef.efficient_return(mu.abs().mean(), True)

"mu" contains the expected returns for each ticker. Because it's a long/short portfolio it also contains negative predicted returns regularly (which should produce positive returns when short selling the asset). To make sure the return parameter given to the  "efficient_return" function actually is achievable, I'm using the mean of all predicted returns. Nevertheless, the function returns the followin error:

ValueError: target_return must be lower than the largest expected return

I'm pretty sure this happens because of the negative returns in "mu", but I'm not sure whether this is a bug or the expected behavior.
Can this library even handle negative returns? And if so, how else should the above function be used?

Hi @georgk10
Thanks for reaching out! I'm pretty sure this is a bug, in particular, this line. Basically, if you have two assets with respective mean returns -10% and +5%, although return targets of e.g +8% should be achievable by shorting the first asset, PyPortfolioOpt complains that 8% is above 5%.
I need to change target_return > self.expected_returns.max() to target_return > self.expected_returns.abs().max().
Before I push a fix, could you please change your target_return to mu[mu > 0).mean() to make sure there are no other problems?
Best,
Robert

Hi Robert,
thanks for the quick response. Using mu[mu > 0].mean() as target return causes no further exceptions, so it's most likely just that one line you pointed out that needs to be changed.
Thanks again & best regards
Georg

@georgk10
Great, will try to push a fix today!
Best,
Robert

Hi @robertmartin8,
I found the expected annual return, annual volatility and sharpe ratio using the template below with your help.

Now I'm trying to find Sortino Ratio and Max Drawdown (CDAR). I checked, the library I'm using is the one where you fixed the bug "target_return > self.expected_returns.max()" with "target_return > np.abs(self.expected_returns).max()". When I use the template below to find the Sortino Ratio, I get still a "target_return must be lower than the largest expected return" error. Can you help me?
For Sortino Ratio:
mu = expected_returns.mean_historical_return(df)
historical_returns = expected_returns.returns_from_prices(df)
es = EfficientSemivariance(mu, historical_returns)
es.efficient_return(0.20)
weights = es.clean_weights()
print(weights)
es.portfolio_performance(verbose=True)


Queries don't work being put into the domain.queries package

Basic information

Axon Framework version: 4.7.1 (I repeated the problem for different versions starting from 4.5)
JDK version:
java 17.0.2 2022-01-18 LTS
Java(TM) SE Runtime Environment (build 17.0.2+8-LTS-86)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.2+8-LTS-86, mixed mode, sharing)
Complete executable reproducer if available (e.g. GitHub Repo):
axon-bug-reproducer.zip

Steps to reproduce
Hi! I decided to try your Axon framework just for fun and tried to reproduce one project found online. Unfortunately, it didn't work as expected -- after invoking the query method of the QueryGateway nothing worked even if I had a suitable method annotated with @QueryHandler. It was just waiting before a timeout.
I tried to figure out why it didn't work and when I moved my query classes from their package com.art.poc.eventsdemo.domain.queries to com.art.poc.events.queries everything got worked.
I prepared a small reproducer that works if Axon Server has started.
In this demo, you don't see the line "You can see this line if you don't move out BookQuery from the domain.queries package!!!" unless you don't move out the BookQuery class.
axon-bug-reproducer.zip
Please, take a look at it! My mind was just blown away when I was trying to make my code work due to this issue.
Expected behaviour
I believe either @QueryHandler should work regardless the naming of packages or this "feature" should be mentioned in the project documentation. Or may be the problem is somehow connected to the depth of my packages.
Actual behavior
My conclusion that there is some kind of naming dependency for the behavior of the Axon framework. Please, correct my if I'm wrong.

Hi @swsms. I've pulled your zip file and tested it locally, against Axon Server Standard Edition 4.6.4.
Running the project through Intellij on JDK17, without any adjustments, I get the aforementioned log-line:

You can see this line if you don't move out BookQuery from the domain.queries package!!!

So...is that intended?
In all honesty, when reading this line:

In this demo, you don't see the line "You can see this line if you don't move out BookQuery from the domain.queries package!!!" unless you don't move out the BookQuery class.

The triple negation in your sentence doesn't make it overly clear.
A bit of side information, Axon Framework is by no means biased where you place your @QueryHandler (or command and event handler) annotated methods.
It starts to matter when you use Spring Boot, as then you are likely expecting the Framework to automatically scan all the beans in the Application Context for message handler annotations.
So, if a message handler is not discovered that typically means the bean in question is not part of the application context.
The QueryProcessor is annotated with @Service, making it part of the Application Context.
Furthermore, since it contains the @QueryHandler annotated method for the BookQuery, it is that exact method that's registered to the QueryBus.
Note that the placement of the BookQuery class itself should have zero impact on this behavior.
When moving the "query classes" (this is the BookQuery IMO) to the com.art.poc.events.queries package, which you state solves the issue, I actually get an exception:
2023-02-13T11:29:40.884+01:00  WARN 25364 --- [ueryProcessor-0] o.a.a.c.query.QueryProcessingTask        : Query Processor had an exception when processing query [com.art.poc.events.queries.BookQuery]

com.thoughtworks.xstream.security.ForbiddenClassException: com.art.poc.events.queries.BookQuery
	at com.thoughtworks.xstream.security.NoTypePermission.allows(NoTypePermission.java:26) ~[xstream-1.4.20.jar:1.4.20]
	at com.thoughtworks.xstream.mapper.SecurityMapper.realClass(SecurityMapper.java:74) ~[xstream-1.4.20.jar:1.4.20]
	at com.thoughtworks.xstream.mapper.MapperWrapper.realClass(MapperWrapper.java:125) ~[xstream-1.4.20.jar:1.4.20]
	at com.thoughtworks.xstream.mapper.CachingMapper.realClass(CachingMapper.java:47) ~[xstream-1.4.20.jar:1.4.20]
	at org.axonframework.serialization.AbstractXStreamSerializer.classForType(AbstractXStreamSerializer.java:171) ~[axon-messaging-4.7.1.jar:4.7.1]
	at org.axonframework.serialization.LazyDeserializingObject.<init>(LazyDeserializingObject.java:83) ~[axon-messaging-4.7.1.jar:4.7.1]
	at org.axonframework.serialization.LazyDeserializingObject.<init>(LazyDeserializingObject.java:63) ~[axon-messaging-4.7.1.jar:4.7.1]
	at org.axonframework.axonserver.connector.query.GrpcBackedQueryMessage.<init>(GrpcBackedQueryMessage.java:62) ~[axon-server-connector-4.7.1.jar:4.7.1]
	at org.axonframework.axonserver.connector.query.QuerySerializer.deserializeRequest(QuerySerializer.java:203) ~[axon-server-connector-4.7.1.jar:4.7.1]
	at org.axonframework.axonserver.connector.query.QueryProcessingTask.run(QueryProcessingTask.java:142) ~[axon-server-connector-4.7.1.jar:4.7.1]
	at org.axonframework.axonserver.connector.PriorityRunnable.run(PriorityRunnable.java:58) ~[axon-server-connector-4.7.1.jar:4.7.1]

This exception follows from the default XStreamSerializer and how JDK17 puts a halt to the reflective access XStream (sadly enough) performs to make serialization work.
To have your sample project work again, we can do the following things:

Provide an XStream instance in your Application Context that is allow to access thecom.art.poc.events.queries package.
Move the BookQuery 'query class' to com.art.poc.eventsdemo.queries instead. In a Spring Boot environment, the default XStream instance Axon Framework constructs for you is allowed to securely access the file.
Switch to the JacksonSerializer instead, This requires mapping configuration on your BookQuery class to succeed.

Concluding, in all honest, I am not entirely sure where the predicament lies for you, @swsms.
Did I even follow your instruction correctly? I hope my description above makes that clear.
Nonetheless, does the above help you further?
I have a hunch that you have not found a bug in Axon Framework, but merely have hit some other form of roadblock.
As such, I'll adjust the type of this issue to "Question."
Furthermore, as more information is required to deduce whether we're on the right track, a reflective status label is included.
Lastly, as we're waiting for a response, you're assigned to this issue, @swsms.

Hi. Thanks for your help!
I think it is really another kind of road blockers, you are right. It seems that your recommendation solved my problems.
I have created a larger pet-project and it works as expected now.
So, you can close the issue.

Of course, glad to help out, @swsms!

Unfortunately, a consideration of a new technology does not always go smoothly :|

That makes total sense.
Hence why you should be free to ask questions on how any of this works!
Just to be sure you haven't missed it yet, but we also have a dedicated forum for Axon-related questions.
I will, as suggested, close this issue as resolved.
Good luck and fun playing with Axon Framework, @swsms!
If any other questions pop up, you know where to reach us.


Implement initialization/shutdown support open-feature/spec@a4ffec3

Spec: open-feature/spec@a4ffec3
See: https://github.com/open-feature/dotnet-sdk/issues/126

Lets continue the discussion about the follow scenario described by @kinyoklion here https://github.com/open-feature/dotnet-sdk/pull/129#discussion_r1210810970


WFLY-18179 & WFLY-18230 Avoid redundant no-op runtime steps in undertow and security subsystems

https://issues.redhat.com/browse/WFLY-18179
https://issues.redhat.com/browse/WFLY-18230
... and assorted changes required by https://github.com/wildfly/wildfly-core/pull/5563

Thanks @pferraro


ls: cannot access '/cloud-encrypt': Transport endpoint is not connected

Hey there.
I have tried for several days to follow you tutorial to make this awesome docker container to work, but I keep getting this error.
Plexdrive is not running                                                                                ls: cannot access '/cloud-encrypt': Transport endpoint is not connected                                                                                Waiting for /cloud-encrypt
My docker create command looks like this.
docker create
--name cloud-media-scripts
-v /volume1/docker/Cloud-Media/media:/local-media:shared
-v /volume1/docker/Cloud-Media/mnt/external/media:/local-decrypt:shared
-v /volume1/docker/Cloud-Media/configurations:/config
-v /volume1/docker/Cloud-Media/mnt/external/plexdrive:/chunks
-v /volume1/docker/Cloud-Media/logs:/log
-v /volume1/docker/Cloud-Media/cloud-encrypt:/cloud-encrypt:shared
-e PGID="1000"
-e PUID="1000"
-e CLEAR_CHUNK_MAX_SIZE="200G"
--privileged --cap-add=MKNOD --cap-add=SYS_ADMIN --device=/dev/fuse
madslundt/cloud-media-scripts
I have tried both with and without the PGID & PUID but with the same result.
Any good idea on what I am doing wrong?
THX in Advance
EDIT: BTW i am running this container gonna Synology 916+ 8gb.
But have tried on a ubuntu vm with the same problem.

 Try running fusermount -uz /volume1/docker/Cloud-Media/cloud-encrypt and then run your docker container again.
If that doesn't work try remove -v /volume1/docker/Cloud-Media/cloud-encrypt:/cloud-encrypt:shared from your docker command

No, nothing inside the folder.
Tried with a brand new one as well.
I get this response to the fusermount command.
fusermount: failed to unmount /volume1/docker/Cloud-Media/cloud-encrypt: Invalid argument
I tried adding the line after the problem startet to see if that would solve anything, but I have just removed it and still have the same problem.

Yes, the error still occur.
I just tried adding it after I got the error to see if it did anything different.
Hmm ok, I would just like to have it inside a docker so I don't have to mess with the Synology OS.
So i am sure it will stil work after upgrading the DSM.

Okay I'll try see if I can enforce the error on my machine and maybe fix it

Ok, thx alot.
I have just tried agian and when i have inputtet the stuff in plexdrive_setup, nothing happens.
After i have set the auth code it just hangs in ssh, no now line or anything.
If i check the log on the docker container i get this error:
7. Enter your generated client ID: [PLEXDRIVE] [2017-10-12 08:45] ERROR  : Could not read configuration

2017/10/12 08:45:04 NOTICE: Config file "/config/rclone.conf" not found - using defaults

This time i tried with the same google credentials for both rclone and plexdrive, not sure if that is the matter with the rclone config?

I'm seeing something like this.
running
docker exec docker-plexdrive check
gives me
Waiting for /cloud-encrypt
looking in the logs there's not much there apart from the above.

oh.. and of course:
plexdrive not running
so entering the docker and running: plexdrive
gives me
"
panic: Mountpoint not specified
goroutine 1 [running]:
main.main()
/go/src/github.com/dweidenfeld/plexdrive/main.go:64 +0x1eb3"


detect ipv6 to enable extra haproxy container

@karmab We're a little hesitant to introduce this to mirror registry since we already run Nginx inside the Quay container. We have work planned to add IPv6 support to Quay directly and when that rolls out, should trickle down to mirror registry. See PROJQUAY-272. Would you be interested in contributing directly upstream?

@karmab We're a little hesitant to introduce this to mirror registry since we already run Nginx inside the Quay container. We have work planned to add IPv6 support to Quay directly and when that rolls out, should trickle down to mirror registry. See PROJQUAY-272. Would you be interested in contributing directly upstream?

thanks for the feedback, i ll look at contributing upstream but take this as a temp solution that will ease adoption of the mirror-registry in telco contexts instead of docker registry (which provides the ipv6 functionality).
should you consider adding this, note that it uses my own haproxy container which, although used relatively widely (in my own kcli side project in particular), is not a supported red hat asset. I couldnt find a valid haproxy container under registry.redhat.io

Closing for the moment, we'd like to include this upstream via PROJQUAY-272.


Error while brew install unused "Failed to load interface for..."

Hi,
I'm trying to install unused with brew : brew install unused
But I've got an error :
src/Unused/Projection/Transform.hs:10:1: error:
    Failed to load interface for ‘Text.Inflections.Parse.Types’
    Perhaps you meant
      Text.Inflections.Types
      Text.Inflections.Parse.CamelCase
      Text.Inflections.Parse.SnakeCase
    Use -v to see a list of the files searched for.
cabal: Leaving directory '.'
cabal: Error: some packages failed to install:
unused-<IP_ADDRESS> failed during the building phase. The exception was:
ExitFailure 1

Can someone help me?

@wRadion thanks for reaching out, and apologies for the confusion here!
I've pushed up a fix I've confirmed works locally - can you rerun the installation with homebrew's --HEAD flag and let me know if that fixes it for you?

@joshuaclayton it worked! Thanks a lot for the fast response and fix :).

@wRadion excellent, glad to hear! I've released <IP_ADDRESS> and bumped the Homebrew formulae so others don't run into the same issues.
Thanks again for reporting!