[BUG] Syntax Error:(/config/bigip.conf at line: 7346) ";" unknown property

Describe the bug
Opening this bug on behalf of Chris. Tried in his lab to migrate a BIG-IP from vCMP to VELOS but failed restoring the modified UCS with the following error message when trying to do a tmsh load sys config after platform-migrate command completed.
Syntax Error:(/config/bigip.conf at line: 7346) ";" unknown property
We also noticed the deployment never ends fails or succeeds in Journeys.
To Reproduce
Steps to reproduce the behavior:

Get UCS from SR 1-6993580048\INCOMING\jun_10\lab02.ucs
Restore the UCS on a vCMP guest <IP_ADDRESS>
Use Journeys 3.3.2 to migrate the config to a VELOS tenant <IP_ADDRESS> after resolving all the errors in the tool

Error
[root@bipmn013lab02:/S2-red-P::Offline:Disconnected (Sync Only)] config # tmsh load sys config
Loading system configuration...
/defaults/asm_base.conf
/defaults/config_base.conf
/defaults/ipfix_ie_base.conf
/defaults/ipfix_ie_f5base.conf
/defaults/low_profile_base.conf
/defaults/low_security_base.conf
/defaults/policy_base.conf
/defaults/wam_base.conf
/defaults/analytics_base.conf
/defaults/apm_base.conf
/defaults/apm_oauth_base.conf
/defaults/apm_saml_base.conf
/defaults/app_template_base.conf
/defaults/classification_base.conf
2022 Jun 10 18:55:57 slot3 logger[4145]: Re-starting lind
/var/libdata/dpi/conf/classification_update.conf
/defaults/ips_base.conf
2022 Jun 10 18:55:58 slot1 logger[2881]: Re-starting lind
/var/libdata/ips/ips_update.conf
/defaults/daemon.conf
/defaults/pem_base.conf
/defaults/profile_base.conf
/defaults/sandbox_base.conf
/defaults/security_base.conf
2022 Jun 10 18:55:58 slot3 logger[4413]: Re-starting mcpd
/defaults/urldb_base.conf
/usr/share/monitors/base_monitors.conf
/defaults/cipher.conf
/defaults/ilx_base.conf
Loading configuration...
/config/bigip_base.conf
/config/bigip_user.conf
/config/bigip.conf
Syntax Error:(/config/bigip.conf at line: 7346) ";" unknown property
Context

Please specify, app version: 3.3.2
And Platform version of the system you want to migrate: vCMP guest to VELOS tenant <IP_ADDRESS>

I encountered this recently, as well.  In my original UCS archive, this was the config stanza being processed:
security dos bot-signature "/Common/Citrix ICA Client" {
    category "/Common/Service Agent"
    risk na
    rule "headercontent:\"\\Citrix\\ICA Client\\\"; useragentonly; nocase;"
    user-defined false
}

This is what Journeys generated.  The line that reports a syntax error about is the rule line.  Note that Journeys has malformed the escaping:
security bot-defense signature "/Common/Citrix ICA Client" {
    category "/Common/Service Agent"
    risk na
    rule headercontent:"\\Citrix\\ICA Client\\"; "useragentonly;" "nocase;"
    user-defined false
}

The failure is evident just trying to load that config stanza onto a running v<IP_ADDRESS> system:
# cat /var/tmp/journeys-66
security bot-defense signature "/Common/Citrix ICA Client" {
    category "/Common/Service Agent"
    risk na
    rule headercontent:"\\Citrix\\ICA Client\\"; "useragentonly;" "nocase;"
    user-defined false
}
# tmsh load sys config merge verify file /var/tmp/journeys-66
Validating configuration...
  /var/tmp/journeys-66
Syntax Error:(/var/tmp/journeys-66 at line: 4) ";" unknown property
#

Is this a v14 problem?  The same stanza in v15 has a 'factory-rule' defined that is encoded:
security bot-defense signature "/Common/Citrix ICA Client" {
category "/Common/Service Agent"
factory-rule $M$wA$pbtF+8Up02HOaZ7awz6+CmNmu8+dnR0Em5qvNceInZGW5FqQ56z0EWq/AwotbC/W6e5bbSUJ5hba004YgrkR4A==
risk na
user-defined false
}

Is this a v14 problem? The same stanza in v15 has a 'factory-rule' defined that is encoded:

Sort-of.
It may only occur when the source configuration file originated in v14.1.x or earlier.
In my case, Journeys was migrating a configuration from v15.1.x to v15.1.x.  I no longer have the UCS archive around, but I suspect the source device was originally on v14.1.x and was upgraded to v15.1.x at some point in the past.
In other words: it's entirely possible to have systems on v15.1.x or above that still have that particular stanza in bigip.conf.
I haven't tested, but I assume it's also possible for a user to configure a similar signature rule that trips over the incorrect escaping.

The bug was fixed in release 3.3.5


Method enable() dose not work with Ionic2

I use Ionic2 with cordova-plugin-background-mode.  In the top of app.components I write BackgroundMode.enable() and nothing happened. My app dose not running when screen lock. Requests to the database are not performed.

You have three tickets open for essentially the same issue. Please close two of them.


Support for Si4732?

Hi,
I have a modded radio and would like to use this firmware on mine.
Will there be support for the Si4732 modification in the future?

Hello 🤗
About SI4732 support, I'm sorry, but no.
If you use SI4732, take a look to CEC firmware, who is made for this mod. KD8CEC do a great job.
Armel F4HWN.


sqlalchemy warning

SAWarning: Ignoring declarative-like tuple value of attribute proxy_id: possibly a copy-and-paste error with a comma left at the end of the line?
_as_declarative(cls, classname, cls.dict)

sorry, please close the issue.


Remove logout button for non-auth user

Describe the bug
User able to see, and click logout button even though user is not logged in
To Reproduce
Steps to reproduce the behavior:

Go to '/'
See top right corner

Expected behavior

If user is not logged in, hide Logout button and show Sign In and Register button instead.
If user is logged in, show Logout button and hide Sign In and Register button

Screenshots

Hey! How do I log in locally?
I tried to register a new account but I don't think this is possible locally - should I run bekreno?


Fix ixiatg op path

https://github.com/openconfig/kne/issues/295

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.272%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2639

Relevant Lines:
4307

💛  - Coveralls

/gcbrun


Lack of hierarchy will not scale for personal extensions

Currently unsandboxed custom extensions are limited to this repository. And considering #61 it is unlikely that another way of placing them will appear in the near future. This is where the problem arises, which I myself have already encountered 3 times. If any extension already exists, and one wants to add a similar one or make an alternative version, it will clog the directory and will not be accepted. This greatly limits the extension-creators! TurboWarp is a platform for everyone, and it would be right to keep this policy in relation to custom extensions!
Personally, I came up with such a solution method:
The ability to create a personal folder in /extensions/ that will not interfere with the main directory.

Or create a separate folder in the main.

This is just my suggestion for a solution, but the problem somehow needs to be fixed.

We should make it so that you can use folders in extensions, yeah

For now you can make changes to already existing extensions, the only limitations you have on doing that are the ones explicitly stated in CONTRIBUTING.md

we do user folders now


Random Closure

[X] I have read the FAQ.
[X] I have searched in existing issues.

Environment

OS: Windows 10
scrcpy version: 2.0
installation method: Windows release portable
device model: Samsung Galaxy Tab S7
Android version: 13

Describe the bug
When using wireless, randomly stops, closing the screenshare window without notice or warning after a random interval (sometimes hours, sometimes minutes). SCRCPY window says it's still running, and must be restarted to start share again. Can happen once or many times per windows boot.
No terminal windows or logs for this version of SCRCPY (unless you can tell me where to find them).

Run scrcpy-console.bat, the console window won't close if there is an error message.

There is no console window showing on the portable version.

If you run scrcpy-console.bat, yes, there is a console window. You can also run open_a_terminal_here.bat and execute scrcpy from there directly.

Still not sure how to help here. There is no console or error message to provide using scrcpy+.exe. Closure is completely silent.

I though it was an issue with my setup! It used to be stable pre-V2 but I can now see the behaviour described by OP.
Here's a screenshot of the issue, showing no error: the first session is 3+hours long but the second one is only 8 minutes before it disconnected.

WARN: Device disconnected

Your adb connection get closed. You can confirm this by running in a separate terminal adb shell or adb logcat, the command will terminate at the same time as scrcpy.
https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#device-disconnected


Media control keys

Hi, is there any way that the media keys on the keyboard can play/pause, skip and prev control playback?

I found how to do this with MPRIS. For anyone else that got stuck here's what I did (Manjaro, i3 wm):
Install playerctl
Add the following to the i3 config:
bindsym XF86AudioPlay exec "playerctl -a play-pause"
bindsym XF86AudioNext exec "playerctl -a next"
bindsym XF86AudioPrev exec "playerctl -a previous"


Can't Fetch params with branch deep link iOS

I am unable to fetch link properties in iOS (swift) with latest branch sdk. Every time the link properties are not returned but when I try with non-branch link the properties are there. Is this some issue with branch. Its so annoying issue. Can someone please help with that.
Branch.useTestBranchKey()
let branch = Branch.getInstance()

branch?.initSession(launchOptions: launchOptions, automaticallyDisplayDeepLinkController: false, deepLinkHandler: { params, error in
		//branch?.initSession(launchOptions: launchOptions, andRegisterDeepLinkHandler: { params, error in
			if let error = error {
				print(error.localizedDescription)
				return
			}
			print(String(format: "params\n%@", (params?.description ?? "")!))
			if let clickedBranchLink = params?[BRANCH_INIT_KEY_CLICKED_BRANCH_LINK] as! Bool?, clickedBranchLink {
			//print("params: \(cpName) and \(visitId)")
				guard let paramsDictionary = (params as? Dictionary<String, Any>) else {
					print("No Branch parameters returned")
					return
				}
				let referringLink = paramsDictionary["~referring_link"] as! String
				let content = String(format:"\nReferring link: \(referringLink)\n\nSession Details:\n\(paramsDictionary.description)")

				print(content)
				print(String(format: "Branch TestBed: Finished init with params\n%@", paramsDictionary.description))
			}
		})

@nitesh-homage Sorry that you are facing this issue. I think you wanted to report an issue with iOS sdk (or is there any thing related with Android SDK here?) . We are looking this on our iOS sdk and get back to you soon

@nitesh-homage This looks like a configuration issue.  You can talk with a support engineer at Branch to help you out:  https://support.branch.io/support/tickets/new

Plus, try
Branch.useTestBranchKey = true

Our support team is working with Nitesh directly over e-mail to resolve this integration issue. If you have follow up iOS inquiries please post on the iOS repo: https://github.com/BranchMetrics/ios-branch-deep-linking


added separate setter for Builder.opt

I would like to add (suggest) new setter method to set name of the option ('opt') in Option.Builder class outside of constructor.
So something like this would be allowed:
Option.builder().opt("a")
which would be equivalent to:
Option.builder("a")
Personally I find it more readable, maybe others will agree as well.

Coverage increased (+0.006%) to 96.364% when pulling bcef4c59f8d65e9eccfce6444bf5bc144573e6c1 on waso:feature/builder_opt into c12260c05ebcd27558265395df79b8b049534fbd on apache:master.

Hi @garydgregory
Thanks for the feedback.
I have updated my PR and it should be closer to current behavior, so fail fast if option name is invalid.


Accounts not using the saved Login Info

I've setup several accounts entered the backup info and used Recreate Loginfile for every account and watched the app enter the correct info and login. When I try to launch any account it does not fill in the correct account info for the selected account and uses the last set of login info instead. If I launch multiple accounts it will then launch one account multiple times.

I've had this same issue since I tried using Launchbuddy as well.

Also experiencing this issue on v1.9.3 alpha


undefined: build.MultiplePackageError

When I do
go get github.com/tools/godep
I Have
go/src/github.com/tools/godep/list.go:163: undefined: build.MultiplePackageError
Debian 8.2

What version of go (output of go version) are you using?

go version go1.3.3 linux/amd64

the same issue here, ubuntu 14.04
go1.2.1 linux/amd64

I had the same issue here, i don't know why but started yesterday with this new release.
What i did to solve temporarily was download the godep binary from a previous version (https://github.com/tools/godep/releases/download/v32/godep_linux_amd64 for example) directly to the /opt/go/bin/gopdep directory.

This is because go/build does not have MultiplePackageError previous to go1.4 (IIRC; didn't check). #350 should fix this as we don't use that error anymore.

ps: also using the v33 executable should also work (barring other problems fixed in #352)

v34 (#352) should fix this.


Removed the class "outline" for the semantic ui icon "close"

Issue:
Hamburger menu's close icon is not loading

Fix:
I don't see a semantic ui icon class by name "close outline". Hence, updated user-menu.html by removing the usage of class "outline"

Thanks @arpithaar !


access_log: include dynamic metadata in access logs streamed over gRPC

Signed-off-by: Andrew Schran<EMAIL_ADDRESS>Description: Adds dynamic metadata values set by filters to the access log messages streamed using GrpcAccessLogStreamer.
Risk Level: Low
Testing: Updated unit test.
Docs Changes: N/A
Release Notes: Updated docs/root/intro/version_history.rst.

@htuch @mattklein123 PTAL?


"Certificate has expired"

When I try to pull a template, I get a "certificate has expired" warning message.

If this is still an issue, could you please provide more details. Are you using a proxy?

Given this issue is 1.5 years old, I had uninstalled the plugin.  I just reinstalled, and it looks like the certificate has been fixed.


RBF: warn the user if they are about to shoot them in the foot.

If a user spends the unconfirmed change output from their transaction A in a later transaction B we should prevent them from RBF'ing A (and thereby invalidating B).

Should we just warn the user when creating the replacement or prevent them from doing so?
In case the transaction to be replaced is not in the mempool, I'll apply the check to any directly conflicting transactions. I could check these directly conflicting transactions for any outputs that are coins in our database that are being spent (in case this conflicting transaction is paying to one of our receive addresses or more than one change address).

I'm leaning toward asking confirmation. If they don't know what they are doing they wouldn't confirm. And an experienced user can still proceed.
I'm not sure i understood the latter part. How i was thinking about it was: if we get a request to replace a tx A, we check in database if it has a change output and if it's marked as spending in the DB (ie we have a tx B chained onto our own change). We would return an error with the txid in this case.
Thinking through it, making it a confirmation instead of an error would be more work (would probably have to include another parameter, like force). A warning could work but it's maybe too "soft"?

I'm not sure i understood the latter part. How i was thinking about it was: if we get a request to replace a tx A, we check in database if it has a change output and if it's marked as spending in the DB (ie we have a tx B chained onto our own change). We would return an error with the txid in this case.

My thinking was that this check should apply to the directly conflicting transactions of the replacement transaction, which may or may not be A. If A is in the mempool, then this will be the only directly conflicting transaction, but if not, then there may be one or more other directly conflicting transactions. Also, it's possible that one of the outputs of these directly conflicting transactions is a non-change coin in our DB, so I was thinking that we could check for any outputs that are coins marked as spending, not just for change outputs.

I'm leaning toward asking confirmation. If they don't know what they are doing they wouldn't confirm. And an experienced user can still proceed.

I agree we should allow the user to proceed. If there's a clear warning of some kind, then we can assume they know what they're doing.

Thinking through it, making it a confirmation instead of an error would be more work (would probably have to include another parameter, like force). A warning could work but it's maybe too "soft"?

Perhaps we can already show a warning in the modal before they click "confirm", which would have to be generated by the GUI. Even after generating the replacement PSBT, they still need to sign and broadcast it, so there would be a chance to show any warnings from rbfpsbt in the modal before they click on "go to replacement". I don't think a warning like this would be too soft, at least to start with. We could make it stricter later depending on user feedback.

I see. I think it's even more edgy a case and fine to not cover for now. Feel free to have a look and if it's a small diff do it in the same PR, otherwise you can open a separate issue to track this.
Ack for going the warning route.

I don't think checking for directly conflicting transactions in general will add any complexity as we already have the mempool_spenders() method.
We can assume that if an unconfirmed output is being spent, then the corresponding coin must already be in our DB (but possibly not yet marked as spending). In that case, we can look up all DB coins created by one of these directly conflicting transactions and then use mempool_spenders() on the outpoints of these coins to check if any of them are being spent.

Thinking through it, making it a confirmation instead of an error would be more work (would probably have to include another parameter, like force). A warning could work but it's maybe too "soft"?

confirmation looks better to me

It should be fairly straightforward to check in the GUI using just DB coins if there are any descendant transactions that would be dropped (assuming that all spending coins have already been marked as spending). This could be used for a preliminary warning when opening the RBF modal.
In addition, I plan to build on #905 and generate warnings in the rbfpsbt command for any descendant transactions that would be dropped by the replacement. These warnings would use mempool data and would catch anything missed by the preliminary warning in the modal.
Assuming rbfpsbt also returns any warnings from the lib create_spend function, there may be other warnings also returned by the command, e.g. regarding a change amount added to the fee, and so perhaps these warnings should all be shown together on the PSBT screen rather than in the RBF modal (how we will show these spend warnings in the GUI is still to be decided).

It might make sense to run the GUI check each time the PSBT screen is opened to see the latest unconfirmed transactions that would be dropped by broadcasting it. This way, the warnings would still be there if the replacement is not signed immediately. Even though a PSBT that would cause other transactions to be dropped could only be created by the rbfpsbt command, we could run this check against all PSBTs using DB coin info, as it should be fairly quick and we don't currently track which PSBTs are generated as replacements.

This makes sense to me. We already have a confirmation dialog for broadcasting a PSBT. This could be part of it.

we could run this check against all PSBTs using DB coin info

This would translate to use the listcoins command, right? Upon clicking on "broadcast" we'd:

Detect the change output, if any, from the PSBT
Call listcoins with parameters outpoints=[change_outpoint] and status=["spending"]
If it returns any transaction, warn the user in the dialog.

This would translate to use the listcoins command, right? Upon clicking on "broadcast" we'd:
1. Detect the change output, if any, from the PSBT
2. Call listcoins with parameters outpoints=[change_outpoint] and status=["spending"]
3. If it returns any transaction, warn the user in the dialog.

I think it would be slightly different if we're checking a not-yet-broadcast PSBT:

For all input coins of the PSBT, check if any are already spending and get their spend_txid. These are the directly conflicting transactions.
Check if there are any coins in the DB created by these directly conflicting transactions, and check if any of these coins are being spent. These coins would probably be change outputs, but any such coins would be dropped by broadcasting the PSBT, whether change or not, so I don't think we'd need to limit the check to change outputs only.

For this, it would be useful to implement https://github.com/wizardsardine/liana/issues/677 and possibly also add the ability to filter DB coins by txid.

Oh, right, you'd need to check the inputs.
You are right regarding not limiting the check to change outputs in this case. In fact we could also just stop at 1. List the spend_txids, if any, as conflicting and mention "any potential child transaction would be evicted" (not sure about the formulation here.
-------- Original Message --------
On Jan 15, 2024, 8:29 PM, jp1ac4 wrote:

This would translate to use the listcoins command, right? Upon clicking on "broadcast" we'd:

Detect the change output, if any, from the PSBT
Call listcoins with parameters outpoints=[change_outpoint] and status=["spending"]
If it returns any transaction, warn the user in the dialog.

I think it would be slightly different if we're checking a not-yet-broadcast PSBT:

For all input coins of the PSBT, check if any are already spending and get their spend_txid. These are the directly conflicting transactions.
Check if there are any coins in the DB created by these directly conflicting transactions, and check if any of these coins are being spent. These coins would probably be change outputs, but any such coins would be dropped by broadcasting the PSBT, whether change or not, so I don't think we'd need to limit the check to change outputs only.

For this, it would be useful to implement #677 and possibly also add the ability to filter DB coins by txid.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

In fact we could also just stop at 1. List the spend_txids, if any, as conflicting and mention "any potential child transaction would be evicted" (not sure about the formulation here.

That's true. If this is a general check performed on the PSBT screen rather than the RBF modal, then I think it would make sense to show the directly conflicting transactions and just mention about any child transactions also being evicted.

Even though a PSBT that would cause other transactions to be dropped could only be created by the rbfpsbt command

I think I was wrong before, as the two PSBTs could be created before either is broadcast, rather than the second PSBT being created once the first has already been broadcast. This would be another reason to check on the PSBT screen rather than the RBF modal.
Perhaps for now we don't need to add any warnings to the rbfpsbt command and can just add a check for directly conflicting transactions in the GUI PSBT screen (and maybe also a check in the RBF modal for any conflicting descendant transactions).

I think this issue can be closed now that warnings have been added to the GUI.
We could additionally add a warning in the rbfpsbt command, but I think the GUI warnings should be enough for now.


Fix for LPP-21716 base 6210 sp13: IE8 showing error "Object doesn't support this property or method" for aui-form-validator.js file

Hi Omar,
Thanks for your fix for this issue.
I needed to extend and reorganize your commits. Please check it.
Forwarded it to Jon Mak: https://github.com/jonmak08/alloy-ui/pull/346
Zsaga


Review and Combine Project Documentation

Create a Single team set of Project Documentation

Currently, we have 3 sets of Project Documentation where we did breakdowns of Themes, Initiatives, Epics, Stories, and Tasks on an individual basis. We need to review and combine these into a single set of Project Documentation to guide our development effort for MyWebClass.

Project documentation was completed and tasks were added to the Sprint 1 backlog.


Hermes now supported on iOS CodePush

Describe the bug
Docs need to be updated:
https://docs.bugsnag.com/build-integrations/js/source-maps-react-native/#codepush-and-hermes
CodePush has been updated to support Hermes on iOS:
https://github.com/microsoft/appcenter-cli/releases/tag/v2.10.0

Thanks, I'm actually experiencing a crash recently when loading a new CodePush so perhaps this isn't actually working properly.
Thanks to Bugsnag for providing :)

Thanks, I'm actually experiencing a crash recently when loading a new CodePush so perhaps this isn't actually working properly.

Thanks to Bugsnag for providing :)

Have written up a crash report here: https://github.com/microsoft/react-native-code-push/issues/2124
Weird one!

Hey @henrymoulton & future travellers: We've tested this through with appcenter-cli v2.10.0 on iOS and Android; the source maps appear to now be generating all as expected for both platforms when Hermes is enabled, the docs have been updated accordingly. Thanks for raising this with us!


chore(master): release 1.2.7

:robot: I have created a release beep boop
1.2.7 (2023-05-28)
Miscellaneous

deps: update dependency phpstan/phpstan-phpunit to v1.3.13 (dbc3e6e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/php-cs-fixer-config/releases/tag/v1.2.7 :sunflower:


Issue with k8s.io/docs/tasks/debug-application-cluster/resource-metrics-pipeline/

This is a Bug Report

Problem:
The "deployment yamls" link is broken as it still points to https://github.com/kubernetes-sigs/metrics-server/tree/master/deploy
Proposed Solution:
Page to Update:
https://kubernetes.io/...

Might be because it is now being used only for development. For more info, Metric server deployment README
Page to Update:
https://kubernetes.io/docs/tasks/debug-application-cluster/resource-metrics-pipeline/#metrics-server
/language en
/kind bug

This issue has been fixed. Feel free to reopen if the link still doesn't work.
/close


update license file name in setup.cfg, fix #26

The more common case seems to be a license named LICENSE rather than LICENSE.txt, so I would suggest renaming the file instead.

Renaming the file is my preference too, I'll make the change soon, as well
as a new release.
On Sat, Jan 21, 2017 at 8:51 PM FichteFoll<EMAIL_ADDRESS>wrote:

The more common case seems to be a license named LICENSE rather than
LICENSE.txt, so I would suggest renaming the file instead.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/datamachine/twx.botapi/pull/27#issuecomment-274308482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGqleDVm7UgseUGaXv_Dq9oVsVLNoAPks5rUuBIgaJpZM4LqQ_i
.


add hasOne / belongsToMany as aliases of belongsTo / hasMany

@samselikoff , would you take a PR adding hasOne & belongsToMany relationships, that would just behave like aliases of belongsTo / hasMany in Mirage?
=> running some scripts on our domain model here, and need to order by child / parent so useful to specify in the relationships if only for doc purposes (I also believe there may be some room to destroy children as opposed to parents when deleting a model in some cases in Mirage but that would not be part of this PR).

Not sure I follow... literally new imports that behave the same way?
import { hasOne } from 'ember-cli-mirage';

like that?

Yes, that's what I would have in mind.

Why not
import { belongsTo as hasOne } from 'ember-cli-mirage';`

?

@samselikoff I was hoping for something simple like that yes. Are saying it just works as of now if I import like that in my app? 🥇

I guess I can just try and it will, closing this issue before I forget and thanking you a lot for the tip which is always obvious once you know it. Think it should be in all wikis of the world that you can just do that.

Yep, that's part of the ES6 module spec! https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Syntax


AD API reports v3: Gross and invalid traffic reports contains campaignId in example request, but it is missing from allowed metrics

Describe the bug
AD API reports v3: Gross and invalid traffic reports contains campaignId in example request, but it is missing from allowed metrics.
Actually it is not possible to request campaignId as for now, which makes example request misleading. But also I wanted to state that it would really make sense to allow requesting campaignId as otherwise it makes impossible to join this report data with other reports for some analytics and forecasting etc.
URL of the content
Gross and invalid traffic report page
Screenshots

Additional context
Please consider adding campaignId to Gross and invalid traffic report!
Thank you in advance!

Thanks for pointing this out! CampaignId is not supported for now. I have updated the example and will pass this feedback on to the team.


⚠ ClamAV has degraded performance

In 43f3392, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 192 ms

Resolved: ClamAV performance has improved in 8ca1213 after 11 minutes.


Changed link to use https

This is a very minor change. I just changed the link to stackoverflow to use https instead of http. ^ _ ^

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mbrickn, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

thanks!!

Thank you! 😄


SiteMap URL

Hi, I am new to sitemaps.
Using this plugin generated a several files. What are they for?
Also, I have no idea how to let the generator generates the right URL to replace your site.
    <sitemap>
        <loc>http://yoursite.com/post-sitemap.xml</loc>
        <lastmod>2016-04-19T01:19:19.000Z</lastmod>

Hi,
Quote from : https://support.google.com/webmasters/answer/156184?hl=en

A sitemap is a file where you can list the web pages of your site to tell Google and other search engines about the organization of your site content. Search engine web crawlers like Googlebot read this file to more intelligently crawl your site.

To replace yoursite.com, you need to edit the _config.yml file in hexo project root and set url property to your website url.
I hope this will help.


Rename repo to seneca-file-spider

Repository should be renamed to seneca-file-spider to avoid confusion with file naming conventions

Assigned to @rjrodger


Message: collection_store: Failed to access DBM file "/var/cache/modsecurity/ip": Permission denied

Hey there,
I actived comodo rules then I tried fixing the following error:
ModSecurity: collection_store: Failed to access DBM file "/var/cache/modsecurity/ip": No such file or directory
with the guide on https://support.plesk.com/hc/en-us/articles/213368509-Comodo-rule-set-does-not-work-Failed-to-write-to-DBM-file-var-cache-modsecurity-ip-Invalid-argument
I used the command: mkdir the folder
and ls -ld /var/cache/modsecurity/
but received:
drwxr-xr-x 2 root root 6 July 4 /var/cache/modsecurity/
instead of what they have in the example:
drwxr-xr-x 2 apache root 4096 Jun 29 18:37 /var/cache/modsecurity/
Now I am having this permission issue below; how can I fix it? Please help me out with this one guys, i hardly now any commands on linux.
Message: collection_store: Failed to access DBM file "/var/cache/modsecurity/ip": Permission denied
Apache-Error: [file "apache2_util.c"] [line 271] [level 3] [client %s] ModSecurity: %s%s [uri "%s"]%s
Apache-Handler: application/x-httpd-php
Stopwatch:<PHONE_NUMBER>580453 12703 (- - -)
Stopwatch2:<PHONE_NUMBER>580453 12703; combined=3742, p1=1008, p2=2410, p3=24, p4=35, p5=158, sr=173, sw=107, l=0, gc=0
Response-Body-Transformed: Dechunked
Producer: ModSecurity for Apache/2.9.1 (http://www.modsecurity.org/); CWAF_Apache.
Server: Apache
Engine-Mode: "ENABLED"

It seems like you're having a permission problem where ModSecurity/Apache is not able to create the DBM file.
A good workaround for your problem is simply changing the owner of the folder for the same user that runs your Apache web server. If the user is named "apache" you can do that by executing the following command on the terminal when logged in as the root user:
chown apache /var/cache/modsecurity/

If that doesn't work for any reason (e.g. your Apache runs with a different user name) you can get it working by setting the folder permission to be world readable/writable/executable:
chmod 777 /var/cache/modsecurity/

Just a bear in mind that the command above is not an elegant solution and it's a bad idea if you are doing this on a production server since these permissions would allow for any other process/user on the server to change this file.
This other thread should also help you: https://github.com/SpiderLabs/ModSecurity/issues/919

This issue is applicable to ModSecurity/Apache on Windows platform. If Apache is running under NT AUTHORITY\LocalService you will get errors about ModSecurity: Audit log: Failed to create subdirectories.
To avoid this create an user and set permission Log on as service via secpol.msc. When run Apache under this user.


generate_nirspec.py failing with TypeError

Running generate_nirspec.py errors with the following traceback:
Loading reference files from directory: /Users/sosborne/repos/pysiaf/pysiaf/source_data/NIRSpec/delivery

  =============================================%

/Users/sosborne/repos/pysiaf/pysiaf/source_data/NIRSpec/delivery/delivery_SCA491toGWA.pcf
2016/6/16

Order 5 21  terms

 /Users/sosborne/repos/pysiaf/pysiaf/source_data/NIRSpec/delivery/delivery_SCA491toGWA.pcf
A
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-49d4545cdb06> in <module>
----> 1 import generate_nirspec

~/repos/pysiaf/generate/generate_nirspec.py in <module>
    703 for field in pcf_file_mapping.keys():
    704     pcf_data[field] = {}
--> 705     pcf_data[field]['A'], pcf_data[field]['B'], pcf_data[field]['C'], pcf_data[field]['D'] = reorder(os.path.join(source_data_dir, pcf_file_mapping[field]), verbose=True)
    706
    707 # reference file delivered by IDT

~/repos/pysiaf/generate/generate_nirspec.py in reorder(pcfName, verbose)
    441         print('\n', pcfName)
    442         print('A')
--> 443         polynomial.print_triangle(A2, order=5)
    444         print('\nB')
    445         polynomial.print_triangle(B2, order=5)

TypeError: print_triangle() got an unexpected keyword argument 'order'

OK. this is caused by an update to the polynomial module and has a simple fix.
the polynomial degree can be deduced from the number of coefficients, i.e. len(A2), therefore the argument is not necessary. The errors can be avoided by removing , order=5 from any call to print_triangle


Towards #3502 - Define ReadinessCheckExecutor

Also make Task.(host)Ports a Seq since their order is important
Implement deriving the target of readiness checks
Provide a dummy implementation such that integration is already possible

LGTM.

Ok, I hopefully fixed the host port handling now.

Thanks!

Waiting for the tests.


Automated Package Upgrade

:tada: This PR is included in version 7.7.148 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Re-implement JSON encoder.

Mostly a reminder for myself.
After long discussions with @Aathish04, we are going to try to implement our own JSon encoder for scene cahing.
We used before the built-in one but it causes some un-fixable issues (without touching the builtin implementation), as #302 and some more.
The pros are that it will be easier to debug and closer to the scene caching needs.
Buuut it will be written in python, not in C (as in theory the builtin one is in theory the C version, (you can choose between both)), maybe it will be a little bit slower. I will benchmark.

Are we sure this is the only possible path forward for the scene caching component? Before rewriting a piece of stdlib ourselves we would do well to consider all our options. I would like to know how it was decided that this was the path forward :)

We've tried pretty much all libraries, without success.
We won't rewrite the whole thing, there is just some piece of code that needs to be added to be fittable to our use. This is pretty quickly, as the JSon encoder is not very complex (even pretty simple)
And, it's just a try, not for the moment a real thing. If it is working, then all good, but I will be careful.

Closing this. I found a workaround, not optimal though


TypeScript cannot auto-complete keyword typeof

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.76.2
OS Version: macOS 13.1 (22C65)

Steps to Reproduce:

there is an const object
want to create a type of that object
keyword typeof not showing auto-complete

Thank you @a-tarasyuk!


Dockerize

To be frank, no one wants to use Cloud 66's Rails provisioning. Let's dockerize Cortex.

This has been resolved by https://github.com/cortex-cms/cortex-starter/pull/4


Remotes Tab

We should have a Remotes tab on the workbench where you can do the following:

Follow a GUI workflow to set up a Remote. DoltHub or DoltLab? If DoltLab, what is the URL? Are you logged in? If not, do so. Does remote exist? No. Create it?
List all configured remotes and whether you are out of sync with both the tracking branch and the upstream.
If out of sync allow pull/push.
A fetch button to update all remote info.

Remotes Tab and pull/push are in production.
Checking for out-of-sync branches requires adding dolt functions. I'll add this to the to-do list.


Update to .NET 5.0

Fix #31

@Jadhielv I see we will also need to update the github workflow in the dotnet-core.yml file

Done @nminaya

@Jadhielv Amazing! Thanks


Veracode scaning report flaws.

The method java.io.File.setReadable() is writing data in an unsafe manner, bypassing security mechanisms that would normally prevent unauthorized access.

Can you be more specific?  What would you like to see changed here and why?


update configurable sigalgs documentation for providers

Since OpenSSL 3.2, providers can change the list of supported TLS signature algorithms. This documentation update makes this explicit providing reference to the mechanism.
This may be made even more clear by referencing the openssl list -signature-algorithms command -- but I'm unsure whether this is desirable in this section of the documentation. Glad to update the PR if anyone thinks so.

This pull request is ready to merge

Squashed and merged to the master, 3.3 and 3.2 branches. Thank you for your contribution.


Documentation missing shortcut list

The documentation doesn't seem to state which keystroke opens the tab list.
All I want is it swtich between last-used tabs, similar to alt-tab in windows or cmd-tab on mac... is that possible?

Hi @sheam,
You can, the documentation needs updating but you can manage the keyboard shortcuts from the Extensions > Keyboard shortcuts page in Chrome;
I have mine set like this:

Just be aware that "next tab" is only available for a second or so (while the tab count is orange) before the extension updates its tab order.

Ahh, I see now.


Generate index page for the docs

Currently, the CI pushes the docs output into the docs/git subdirectory in the gh-pages branch and the book into book/git. I created a very simple page in the main directory so that https://gtk-rs.org/gtk4-rs would point you to both the docs/book.
The link above works fine, but the docs have to point to a specific crate as there's no generic index page. It seems like there's a index-page flag we can pass to rustdoc but that doesn't actually works :D
Building the docs with RUSTDOCFLAG="--index-page=./README.md -Z unstable-options" cargo doc doesn't seem to generate an index.html page.
cc @GuillaumeGomez

It requires an option for that: https://doc.rust-lang.org/rustdoc/unstable-features.html?highlight=index#--enable-index-page-generate-a-default-index-page-for-docs

The docs mentions

Using index-page option enables enable-index-page option as well.

Even with --enable-index-page it doesn't do anything

I think it requires another parameter (for the index page file). Let's check together that in the hackfest.

it needs nighlty rust. This works: https://github.com/matrix-org/matrix-rust-sdk/blob/master/.github/workflows/docs.yml


Does this use require computer configuration? I used it the same way as the blueprint node is connected. This will cause UE4 to get stuck

Does this use require computer configuration? I used it the same way as the blueprint node is connected. This will cause UE4 to get stuck

It can stack when closing the editor while running a background worker for speech recognition, until the thread ends. If this is your case, then this is the intended behavior to ensure that the thread has completely finished running at the time of closing. Is this what you mean? Also, please send your logs.


Add clarifications about using different gates in the terra tutorial

Based on an email thread with @rraymondhp and @ajavadia, I've added some content to the tutorial on basic quantum operations (file terra/using_different_gates.ipynb) that:

explains the tensor product operation a bit more
provides some clarification about how terra thinks about ordering multi-qubit states
explicitly works through computing the matrix representation of a controlled gate
adds content on the Toffoli and Fredkin gates

The reason for these changes is that I was confused when working through the tutorial, and figured adding these changes would help prevent others from becoming confused.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Travis Scholten seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

also can you accept the cla

Thanks @Travis-S.
The latex under the Mathematical Preliminaries section doesn't render correctly. Can you double check please?

@ajavadia If you mean "rendering through Github directly looks bad", I agree - see here. However, rendering the NB using the Jupyter NB viewer looks just fine - see here.
Also, my local render looks just fine. This appears to be an issue with how Github renders the NB, not the NB itself.


NaNs in IMU data

I have a log where rosflight_io has published NaNs.  Any ideas on how that could have happened?

I think that I had a mis-matched mavlink version between the firmware and rosflight_io.


Waiting for server response!

Unfortunately, I can't connect to server!
The TunnelBlink always stock on "Waiting for server response"!
What should I do? Is there any needed configuration on my server?
My server from Hetzner.cloud:
Linux my-server 4.15.0-39-generic #42-Ubuntu SMP Tue Oct 23 15:48:01 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Please, provide client log.

Is OpenVPN running on the server?
netstat -ulnp
netstat -tlnp
ps faux | grep openvpn


Support to send events to PagerDuty / Webhook-based consumers

https://developer.pagerduty.com/documentation/code
There's been an explosion of services using HTTP + JSON to feed event systems. It should be trivial to add support for PagerDuty (or other webhook service).

Does this work for you?
Generic webhooks would be nice too

Hey, sorry for the late reply. I haven't had a chance to test that yet: I plan to dig into this more in January, and I was asking some folks on Reddit that know Python better than I to take a look as well.

OK I will close this for the time being but let me know if you want me to reopen.


Move test utilities into __tests__

Applies to the items discussed in https://github.com/prisma/prisma/pull/11156

Hi there,
As part of our effort to clean up our GitHub repo, we’re closing this issue to help focus on features and improvements that align with our focus areas and those of our community.
This issue was originally created for internal tracking purposes, but if you feel this is important to you, feel free to reopen the issue and get like-minded users to upvote as we will prioritize fixing issues based on community interest.
For more insight into our priorities and how we’re thinking about the future of Prisma, please see our blog post: https://www.prisma.io/blog/prisma-orm-manifesto.
Thank you for your understanding and support!


[SE-0296] Update the "Await expressions" section

Change the return type of dataTask(with:),
from a URLSessionDataTask to a (Data, URLResponse) tuple,
matching the let (data, response) = ... examples.

(The real Objective-C APIs aren't translated into async Swift methods.)
https://github.com/DougGregor/swift-concurrency-objc/blob/5b4aafae84e302db9a60146093595b5c73ea3e9b/iOS/Foundation/NSURLSession.swift#L68-L69


Add NuGet package

Maybe add a NuGet package, so you have the option to install Tea Commerce via NuGet?

With the upcoming Tea Commerce 3.2 we have removed the use for package actions as Tea Commerce will support install for Umbraco Cloud (not mobing data). So it might be pretty easy to make a Nuget installer. Have you done this before? Maybe it could be a simple weekend pull request from you?`:)

+1

I would like to see this done too. Would it be worth trying to do this internally so that if there is a restructuring of the assemblies it would be easier to update the build?

The build of a Umbraco package is just a click on an exe file. So I think the same could be done with Nuget. I know some other Umbraco packages that have a Nuget builder. So if someone would be able to help that would be really nice. Try see this package. The basic would be to make a nuget file and the package the right files. https://github.com/jamiepollock/umbraco-grid-settings/tree/develop/build


TFJ-855 Fixed Wrong javadoc

Hi.
I fixed wrong javadoc for twitter.api.UserResources#lookupUsers(long[] ids).
It resolve the issue "TFJ-855".

add name in readme.txt

LGTM, thanks!


Split Pulsar reference into multiple documents

The pulsar.adoc page is very long and renders as 26 pages in the page navigation view in Antora (which then requires scrolling).
This should be split out into multiple pages where each section is a new page.
See spring-kafka for a reference as it had the same issue.

Hey @onobc, can I work on this?

Hi @KartikShrivastava ,
That would be most welcomed.
As a point of comparison you can look at the Spring Kafka docs https://docs.spring.io/spring-kafka/reference/ and you will see how the "Using Spring for Apache Kafka" https://docs.spring.io/spring-kafka/reference/kafka.html is split into sections. But if you look at the Spring for Apache Pulsar counterpart https://docs.spring.io/spring-pulsar/reference/reference/pulsar.html there is no sections and the right hand side of this page is a HUGE menu of nested links. It is hard to navigate.
We want Spring Pulsar to look similar to Spring Kafka docs.

Hi @KartikShrivastava ,
We have been busy and have not had a chance to review but should get to this w/in the next 24hrs.
Thanks for the contribution.


[iOS] Disk cache is not used

Which platform(s) does your issue occur on?

iOS

The bug
If I have no network connection on iOS the images are not loaded, even though the images are cached on the disk:
isInDiskCache(key) returns true, but failureImageUri is used.

@benediktveith please add informations about versions (plugins, pods...)
Could you please create a simple example to reproduce?
Thanks

@farfromrefug
Added the plugins / pods above.
Hmm I retested the plugin in an empty project and it is working there.
Seems like the bug is caused because of the uri I am using.
It is basically an endpoint which provides an image as response (something like: xyz.com/image/1234-5678

@benediktveith ok so a few things:

you use ^3.0.5: When so please give the actual used version (from the node_modules folder). Cause if you didnt do a npm install might be an old one.
Now that being said i dont think it matters there.
So i am not sure why it would not work in one app but would with others.
Can you share the sample code using your uri.
As a reference might be related  to this https://github.com/SDWebImage/SDWebImage/issues/2960

@farfromrefug Hey,
Doesn't matter anymore, I investigated further and realised it is working if I am using a domain name instead of my IP-Adress. To explain it a little bit more:
For local device testing (iOS / Android) I am using the IP-Adress of my Mac (192.168.178.XX).
If I change the url to, for example, projectname.local, which is the ServerName of one of my virtual hosts running locally, it is working as expected.
Thanks for your fast replies btw :)


fix features links

small fixes and docs cleanup.

I'm working on resample (using it again for my own work 😄 ) and probably it should be best to use this opportunity to combine and finish #730 + #801 (as a tutorial) and #809  . Not in this PR, but in the next one.

Yeah there are a few half done PRs building up it would be nice to incorporate them


PPD sync issues

startail reported that all his nodes that were upgraded to <IP_ADDRESS> got stuck during the night with this:

02/03/18 03:38:04 ERROR: ProcessBlock() : AcceptBlock FAILED
02/03/18 03:38:04  Received block a08984c15b041e076b248409816d92aea80ce43cdf316af3e7444e94a6ae035d; AcceptBlock: Proof Of Stake V8 9
02/03/18 03:38:04 ComputeResearchAccrual: Researcher PPD 15.672593 > Reference PPD 2.827814 for CPID cd92b9525a14df746f32ca1f14513ffc with Lifetime Avg Mag of 11.311258, Days 832.116481, MagUnit 0.250000ERROR: CheckProofOfResearch: Researchers Reward Pays too much : claimed 1.690000 vs calculated 0.000000 for CPID cd92b9525a14df746f32ca1f14513ffc
02/03/18 03:38:04 ERROR: WARNING: AcceptBlock(): check proof-of-research failed for block a08984c15b041e076b248409816d92aea80ce43cdf316af3e7444e94a6ae035d, nonce 0

Restarting the nodes got them back on sync.
I have looked into the PPD calculations and they should be correct after tally and GetLifetimeCPID done after disconnecting.

That block is not in main chain. So it was indeed bad.
I think a way to test and compare intermediate values is necessary. Eg we keep logs and when your node rejects and mine accepts a specific block, we compare the logs and see which intermediates differ.

Part of the errors may be caused by passing different iVerificationPhase parameter to ComputeResearchAccrual.

Hi all, I am also getting the "ERROR: CheckProofOfResearch: Researchers Reward Pays too much" error message.
Sync is stuck at block 1148585 for over 48h... I'm on OSX 10.13.13 and running gridcoin v<IP_ADDRESS>-unk.
Any idea how to resolve this issue? Or where to keep looking?

Please upgrade to <IP_ADDRESS> MANDATORY to fix this.

@pabliedung error log is unrelated. Please keep this open for original topic.

@pabliedung That's probably not THE message. When you see CheckProofOfStake (txPrev) error, try searching for ConnectBlock error, often quite a distance before that.

This should be fixed in <IP_ADDRESS>.

How it was fixed @denravonska ?

@tomasbrod Research age calculations being the same as on init (#939). So I suppose <IP_ADDRESS>.

thank you


New aortic valve terms

Add new terms :
small aortic valve (under abnormal aortic valve morphology MP:0002747)
DEF: a decrease in the total area occupied by the aortic valve
SYN: small aortic valves
SYN: decreased aortic valve size
SYN: reduced aortic valve size
SYN: small left ventriculoarterial junction
SYN: small left semilunar valve
SYN: small left arterial valve
SYN: small aortic semilunar valve
aortic valve hypoplasia (under small aortic valve)
DEF: decrease in the number of normal cells in normal arrangement in the aortic valve, typically resulting in decreased size
SYN: hypoplastic aortic valve
SYN: hypoplastic aortic valves
SYN: left ventriculoarterial junction hypoplasia
SYN: left semilunar valve hypoplasia
SYN: left arterial valve hypoplasia
SYN: aortic semilunar valve hypoplasia
aortic valve hyperplasia (under enlarged aortic valve MP:0010591)
DEF: increase in the number of normal cells in normal arrangement in the aortic valve, typically resulting in increased size
SYN: hyperplastic aortic valve
SYN: hyperplastic aortic valves
SYN: left ventriculoarterial junction hyperplasia
SYN: left semilunar valve hyperplasia
SYN: left arterial valve hyperplasia
SYN: aortic semilunar valve hyperplasia
aortic valve hypertrophy (under enlarged aortic valve MP:0010591)
DEF: increase in the bulk size of the aortic valve due to cell enlargement
SYN: hypertrophic aortic valve
SYN: hypertrophic aortic valves
SYN: left ventriculoarterial junction hypertrophy
SYN: left semilunar valve hypertrophy
SYN: left arterial valve hypertrophy
SYN: aortic semilunar valve hypertrophy
see #3877 for additional aortic valve synonyms

Added new terms :
small aortic valve MP:0031566
aortic valve hypoplasia MP:0031567
aortic valve hyperplasia MP:0031568
aortic valve hypertrophy MP:0031569


Episode Countdown doesnt work

Steps to reproduce
There used to be a countdown when you track an anime with Mal or Anilist
Now, when you open a tracked anime series, it doesn show that next episode timer anymore
Expected behavior
When you track an anime series with Mal / Anilist it should show a timer for next episode releasing
Actual behavior
The timer doesnt exist anymore on the app after tracking an anime with tracking service API
Crash logs
No response
Aniyomi version
v<IP_ADDRESS>-7801
Android version
Android 12
Device
Samsung Galaxy M31
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extension's repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Fixed and should be coming in the next preview.


make personal and financial goals editable

Changes

Fixes the goals so that they're editable
Risks and Red Flags are not editable

Testing

Try to delete a personal or financial goal (you should be able to)
No delete buttons appear by Risks or Red Flags, except for new ones added by user.

Review

@huetingj
@virginiacc

Screenshots
Goals with delete buttons, note the 3rd financial goal has been deleted

Risks/Red flags with no delete buttons

Selfie

:+1:  Thanks!


Introduce separate Save and Publish buttons to Content Tagger

Adds save draft button when editing a published taxon.

Trello: https://trello.com/c/OLoVUuaI/180-introduce-separate-save-and-publish-buttons-to-content-tagger

I think this is heading in the right direction, but we'll need to be a bit more thorough with removing everywhere where Content Tagger publishes taxons if they have been published in the past.
The bulk updating of the phases is an example of this. If we make it possible to draft changes without publishing, it will be not a great experience for the bulk updating of the phases to publish drafted changes to taxons (which have been published in the past).
On minor point on the UI, is that it might be better to have the publish button on the taxon page, rather than the edit page, as that would allow you to publish without having to do in to the edit page. What do you think?

The changes look fine, some additional information in the commits about the "why" would be good.


Vulkan: Geometry occasionally not being rendered, but not consistently

Commit 18d1c7e00a4cdb6c71191c710028c0c3c0d6e180 replaced the vkQueueWaitIdle with fences, for improved performance.  The synchronisation is not quite correct, however, as there are rendering oddities such as geometry flashing in and out.  It is most noticeable in wireframe mode.

The current model seems largely incorrect for MT, or at least generally unsafe. The advice from Vulkan devs appears to be to use per-thread command pools. The MT API sample also uses multiple render passes and an explicit clear command.

Correction: The MT Command Buffer sample uses a single render pass, but begins and ends the render pass in each thread.

Commit 7753b07c4ad896f189cf233846db46f932a4ff47 goes a long way to fixing multi-threading, but synchronisation is still not working yet.

Commit 5741799ddfdf1f5d401dbc329d5b40848f4a2c67 improves the rendering considerably by fixing the depth buffer clearing, and commit 789a49f18225d7db2ef04d37597d449ae708d055 fixes the alpha-blending configuration in the graphics pipelines, but there are still rendering issues -- particularly when using multi-threading:
a) The water is still flickering
b) The problem seems to be really bad when the camera moves
c) The font transparency is flickering on and off
Fixing the depth buffer clearing clearly went a long way to improving things, but it's looking like the remaining issues are due to operation ordering with alpha-blending, so the dependencies are still not correct.

Commit 624589de99b59c4b1e49e1bbaf9b3536c1f9e4ad transitions the Vulkan renderer to gross synchronisation at each end_pass() call, which fixes the rendering.  Performance work will follow on now that there is a working baseline.


Node js crashes when Redis Server goes down

Hi,

Version: redis 2.8.0  redis server version 4.0.11
Platform: Ubuntu 18.0.1 LTS VM
Description: I have implemented the logic for redis connection, key retrieval and key value assignment operations using redis 2.8.0 in a Node-Red function node which runs on top of Node JS.I was able to accomplish the above mentioned operations but I was encountered with nodejs crash when redis server goes down(after successful connection) while the application was running.At the same time I could catch the errors when a host cannot be reached.Please see the below code structure implemented.The error block event handler is not catching the disconnection error.Please suggest a workaround for the same.

try{
var redis = context.global.redis;
var path = context.global.path;
var fileName = path.basename(msg.filePath);
var host = flow.get("host");
var port = flow.get("port");
var expirationIntervalInSeconds = flow.get("expirationIntervalInSeconds");
var logMessage;
var connectionUrl = flow.get("connectionUrl");
const client = redis.createClient({"host":host,"port":port,"url":connectionUrl});
//handle errors
client.on('error', function (error) {
try{
console.log("Error occurred " + error.toString());

}catch(exception){

 console.log("Exception occurred while handling error for filename");
 console.log(exception.toString());

}

});
client.on("connect", function (error,result) {
try{

console.log("connected");

client.get(fileName, function (error, reply) {
try{
console.log("calling get on "+ fileName);
if(reply === null){
client.set(fileName, "VAL",'EX',expirationIntervalInSeconds,function (error, response) {
try{
node.send(msg);
}catch(exception){
console.log(exception.toString());

}finally{
releaseConnection(client);
}
});
}else{

releaseConnection(client);

}

}catch(exception){
console.log(exception.toString());
}
});
}catch(exception){
}
});
}catch(exception){
console.log(exception.toString());
}finally{
}
function releaseConnection(client){
client.quit(function (error, reply){

    try{

    console.log("Ended connection");

    }catch(exception){

    console.log(exception.toString());

    }finally{

    }
});

}
Regards
Surya

similar issue

(Dis)Connection errors are orthogonal to reply errors.  Reply errors come from the Redis server (e.g. incorrect syntax, etc.) - don't depend on this for detecting connection issues. Additionally, @suryas18, I think you're structuring callback code incorrectly (use if (err) { ... } rather than try...catch.)
To properly handle connection issues, use retry_strategy options in createClient.


[QUESTION] Busboy and Expressjs - response not sent back to the client if next(new Error(...)) is called inside "file" event

Hi, I am trying to load a zip file through busboy-connect.
I am using expressjs for the server side. The flow would be to load the zip file, check if the content of the zip (which is a folder) already exists in the file system and if not, unzip it e save it in the desired path.
In the case that the file does not exist everything is fine, the problem I am having is with my custom middleware that handle the error for an already existing file.
The problem is that in this case the request remain pending and it is not sent back to the client.
I also tried to use my custom middleware outside the busboy "file" event and in that case everything is fine (i.e. the error is thrown ) the response is sent back to the client.

const busboy = require('connect-busboy');
app.use(busboy({
  highWaterMark: 5 * 1024 * 1024, // Set 2MiB buffer
})); // Insert the busboy middle-ware

    app.post("/upload_report", async (req, res, next) => {
    let uploadPath = 'C:/Users/admin/Desktop/reports/allure-reports';
    let _filename;

    try{
    req.busboy.on('file', (fieldname, file, filename) => {

      if (req.complete) {
        return;
      }

      if (!fs.existsSync(path.join(uploadPath, `${filename.filename}`).replace(/.zip/, '')))
      {

        console.log(`Upload of '${filename.filename}' started`);
        _filename = `${filename.filename}`;

        // Create a write stream of the new file
        const fstream = fs.createWriteStream(path.join(uploadPath, `${filename.filename}.temp`));

        // This is here incase any errors occur
        fstream.on('error', function (err) {
          console.log(err);
        });

        // Pipe it trough
        file.pipe(fstream);

      } else {
        req.unpipe(req.busboy);
        next(new Error("Custom error to pass to middleware"));
        //next(new Error('This folder already exists in the filesystem. You may want to consider to contact the system administrator to delete->replace it.'));
      }

      // });
    });

    req.busboy.on("close", async () => {

      console.log("File caricato, si procede con l'estrazione del file...");

      console.log(`Upload of '${_filename}' finished`);
      await fse.rename(path.join(uploadPath, `${_filename}.temp`), path.join(uploadPath, `${_filename}`));

      try {

        await extract(path.join(uploadPath, `${_filename}`), { dir: uploadPath });
        await fse.remove(`${uploadPath}/${_filename}`);
        console.log(`Rimosso ${uploadPath}/${_filename}`);
        return res.status(200).send({ title: 'upload_report_success', message: `Report ${_filename} correctly uploaded` });

      } catch (e) {

        await fse.remove(`${uploadPath}/${_filename}`);
        console.log(`${e} - Rimosso ${uploadPath}/${_filename}`);
      }
    });

    req.pipe(req.busboy); // Pipe it trough busbsoy

       } catch (e) {
        return res.status(500).send({ title: 'upload_report_error', message: e.message });
       }

       });

this is my middleware (which is put after every other app.use() ones.
 app.use((err, req, res, next) => {
  console.log(err.message);

   res.status(500).json({ title: 'upload_report_error', message: 'This folder already exsists in the filesystem. You may want to consider to
   contact the system administrator to delete->replace it.' });
    })

The problem is that I would need to know the name of the file server side but I can check it only inside the "file" event

There are a few issues I see with the code you've posted:

      if (req.complete) {
        return;
      }

is not correct, you should always consume file whether you're interested in it or not if you have a 'file' event handler. At the minimum that means using something like file.resume(); before your return.

Using the filename as-is like that puts you at risk for security issues if the filename is maliciously crafted (e.g. contains a relative path to escape your upload directory).

If the request is still pending after you've verified a response has been sent, then perhaps something (in Express or elsewhere) is still waiting for the request to be completely drained. If that's the case, you'll need to add something like req.resume() after you req.unpipe(busboy) to ensure any remaining data is drained out.


Add Styling to Task Manager App

The current We need to enhance the user interface of the Task Manager app by adding styles to make it more visually appealing and user-friendly

hey @DhanushNehru can you assign me this issue under Hacktoberfest 2024
/assign


Visual Studio Codespaces will not allow me to clone any repos

I have just set up my first VisualStudio CodeSpace. I am not able to clone any repos. I am the owner of those repos. I am not being prompted to sign in. I have given VisualStudio CodeSpaces access to my repos.
The command:
git clone https://github.com/flx-systems/name.git
Gives this:
Cloning into 'name'...
remote: Repository not found.
fatal: repository 'https://github.com/flx-systems/name.git/' not found

Is that repository private?


Warning about deprecated class usage

As noted in sparky8512/starlink-grpc-tools#81, the google.protobuf.message_factory.MessageFactory class has been deprecated as of a few months ago, so the code in reflector.py that uses it needs to be adjusted to the replacement API.

Before I forget to update this again: the actual fix here is simple: the new API is a drop-in replacement for the old one, just without a class wrapping it. However, there are a few issues with the tests running against later versions of protobuf (aside from the warning that is the subject of this issue):

The checked-in generated protocol modules are out of date, so won't run against later protobuf. These just need to be re-generated with later build of the grpcio-tools package.
One of the tests broke because it was monkeypatching some grpc-reflection service internals which changed a bit, so that test will need to be rewritten a little.
Most concerning, 2 of the tests now crash the python interpreter process. I'm pretty sure this is a bug in the native implementation bits of later protobuf, though, since yagrc doesn't have any native code, thus should not be able to hard crash the interpreter. Also, switching to the pure python implementation (by setting PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python) makes the crashes go away.

With that last change, all tests are now passing without emitting warnings.
For reasons that I don't fully understand, the test cases that were crashing in native code (without the PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION override) also no longer crash. It appears it was the warning itself that was somehow involved with triggering that crash, since just removing the warnings also prevented the crashes. Perhaps the result of some thread safety mischief. Regardless, if there is an underlying problem there, it's in protobuf, not yagrc.


Page doesn't load on safari browser

Basic setup in example works with Chromium browsers but doesn't show the buttons UI on safari

Same issue as #27


[Sema] NFC: refactor coerceToType() to use switch statments

The current series of "unrelated" if statements makes understanding and updating this function harder than necessary. By using two switch statements, we can avoid these problems and as a bonus, generate more efficient code gen.

@swift-ci please smoke test

Overall, looks good.    Once the tests pass, I'd sleep better at night if you ran the full tests and the compatibility suite ✨

@swift-ci please test platform
@swift-ci please test source compatibility

@swift-ci please smoke test linux

@swift-ci please smoke test linux


Update expander.md

Testing PR auto-assignment. Please do not merge.

@MancunianBandit - please close this when you're done. thanks


Add object-service-dashboard test

Signed-off-by: Timothy Asir Jeyasingh<EMAIL_ADDRESS>

@bipuladh , @vbnrh Please review, This PR will go after obc-test

/test ci/prow/odf-console-e2e-aws
Checking for flakiness.

/test odf-console-e2e-aws

/approve
/lgtm


[3.9.0] [enhancement] move assets into git modules

The current problem with VPS storage size of each fork stems from the assets folder being so large. By moving the assets into a separate repo and referencing it using git modules, a lot of VPS storage space could be saved.
This has concequences. This means that repo initialization would get slightly more difficult (git modules init --recursive), and that you likely want to purge history to remove the assets folder from history. An option here is to rename the repo to server-old and marked archived, then create a new repo from 3.8.0 source.

Originally written by Ghost

The repo size as reported by Gitea is misleading and not representative of the repository size on disk inside our VPS. I've checked the git object sizes and they're well within reasonable amounts.
I see no reason to complicate the repository structure, given that we don't have a disk space issue, and Gitea is already proving to be unreliable for end-users that fork our repositories even with the current setup.
EDIT: I just checked to grab exact numbers, and the entire SPT-AKI organization only takes up 2.2GB

Originally written by Terkoiz

You're missing the point.
The other repositories (publicly visible) take up very little space. The next largest repo (Launcher) is 246MiB. The server on the other hand is 2.2GiB and also the most forked project.
But that wasn't the point.
Assuming not all forks are up to date, 2GiB * 64 (forks) = 128GiB or 137GB of data total. That's a huge amount of storage space taken needlessly.
It's not the server source that take up most of the space, it's the assets folder and the commits to it that require so much space. By using git modules, it avoids wasting needless storage space by not having to copy the assets folder in these forks.
The complexity added to cloning the repo for someone else is a single command, like with git lfs. I'm not sure where you precieve there to be additional complexity within the repo structure itself.

Originally written by Ghost

On second thought, you might be right:

Not sure how a cloned repo jumps to 7 GiB, this is confusing hahaha. Then just out of curiousity, how much space does a forked repo take on the server?
Feel free to mark the issue closed :)

Attachments

image.png (1 KiB)

Originally written by Ghost

It's difficult to group the data by specific forks, but it seems that all the repositories combined are currently sitting at 12GB of data. Storage space is really not that big of a deal and we REALLY don't want to complicate the repositories by introducing submodules.
Still, thank you for the thoughtful suggestion!

Originally written by Terkoiz


Issue on tests

I'm trying to test features that use Landlord but the scope is not applied unless I call $landlord->applyTenantScopes(new Model); manually before query.
Simple failed test example:
/** @test **/
function scopeTest()
{
    $user = User::create([
        'name' => 'User name',
        'email' =>'test@domain',
        'password' => bcrypt('secret'),
        'remember_token' => str_random(10),
    ]);

    Landlord::addTenant($user);

    Account::create([
        'name' => 'Account name',
        'user_id' => $user->id,
    ]);

    Account::create([
        'name' => 'Account name',
    ]);

    $count = Account::count();

    $this->assertEquals(1, $count);
}

I can fix easy the test calling applyTenantScopes() but I can't fix real tests that are using controllers, repositories...

Hi @mariomka!
I'm having this same issue. Did you manage to solve it?
Also, how are you using $landlord->applyTenantScopes(new Model); ?
Thanks!

@fgilio I didn't find a solution.
Finally I wrote a simple multi-tenancy system for my project.
I don't remember exactly. I think that you can call Landlord::applyTenantScopes($account); before get the count to fix this simple test.
Good luck!

Hi @mariomka, thanks for the reply!
I was actually editing the comment with my temporary solution:
I added this method to the model and I call it when I need to re apply the scope with a different ID. But of course, I was already doing Landlord::addTenant($tenant); on start and  Landlord::removeTenant($tenant); on finish (which I think is not necessary, as it resets when you add a new tenant of the same type) of the loop.
public static function reApplyTenantScopes()
{
    static::$landlord->applyTenantScopes(new static());
}

So in the DB seeder I call it like this before executing a query:
App\MyTenantScopenModel::reApplyTenantScopes();

I just feels too hacky for my like, but seems to be working ok. I'll keep testing it and update here if I find that this brings some kind of problem.
I hope it helps other having similar issues, I can't believe the amount of time I spent debugging this.

Seems to be a bit ugly solution but if works for you is enough. For sure it will help other users.
I'm remembering that the problem is that the library applies a global scope on boot by each tenant. Maybe It can be fixed if applies a global scope for all tenants.
Something like (I didn't test it):
public function applyTenantScopes(Model $model)
    {
        if (!$this->enabled) {
            return;
        }

        $model->addGlobalScope('landlord-scope', function (Builder $builder) use ($model) {
            $this->modelTenants($model)->each(function ($id, $tenant) use ($builder, $model) {
                $builder->where($model->getQualifiedTenant($tenant), '=', $id);
            });
        });
    }

When current code is ( https://github.com/HipsterJazzbo/Landlord/blob/master/src/TenantManager.php#L118 ):
public function applyTenantScopes(Model $model)
    {
        if (!$this->enabled) {
            return;
        }
        $this->modelTenants($model)->each(function ($id, $tenant) use ($model) {
            $model->addGlobalScope($tenant, function (Builder $builder) use ($tenant, $id, $model) {
                $builder->where($model->getQualifiedTenant($tenant), '=', $id);
            });
        });
    }

A much cleaner solution, and seems to be working fine!
Thanks!

Nice! I didn't have time to try. Maybe I'll make a pull request when I have time, Right now I don't know if the change breaks anything.

There are a few things I'm aware of (just generally) that don't play nice between Eloquent boot functionality and tests, because the framework doesn't re-boot between each test. If someone finds a good solution to this issue I'll consider it.

Didn't do the pr because I didn't have time to do formal tests. But, I'm using @mariomka solution since then and It's working flawlessly.

Unfortunately, that breaks some pretty important functionality for the library, namely that you can no longer run queries without a single tenant scope while leaving the others on:
// Will not scope by 'tenant_id', but will continue to scope by any other tenants that have been set
ExampleModel::withoutGlobalScope('tenant_id')->get();

What if we make this optional?
It could be like having a master switch that dictates how the library will behave, and the default would still be the current behaviour.
Honestly, I'd like to continue using the official library and not a fork.

Why is there no solution in order to work together globally?
as brainstorming,
If requested this method
ExampleModel::withoutGlobalScope('tenant_id')->get();

Stop work for this method
applyTenantScopes(Model $model)

Sorry guys, I haven't had much time to dig into this, but I won't be putting this into the package. Being able to deal with the individual tenancies separately is a core function of Landlord.
At some point when I have time to really dig into it, I'll have to figure out why that solution even works — why would it fail when applying 2 scopes, but not when applying 1? That's the real issue as far as I can see.

I managed to get it to work by creating the following middleware and adding it to the web middleware group in Kernel.php:
public function handle($request, Closure $next)
{
    if (Auth::check()) {
        foreach (Auth::user()->getTenantColumns() as $tenant_scope) {
            Landlord::addTenant($tenant_scope, Auth::user()->{$tenant_scope});
            Landlord::applyTenantScopes(Auth::user());
        }
    }

    return $next($request);
}

I think it has something to do with the user model being booted before the global scope is being applied.
If I change the above code to use the authenticated user directly in the addTenant method, it doesn't work:
public function handle($request, Closure $next)
{
    if (Auth::check()) {
        foreach (Auth::user()->getTenantColumns() as $tenant_scope) {
            Landlord::addTenant(Auth::user());
            Landlord::applyTenantScopes(Auth::user());
        }
    }

    return $next($request);
}

This is absolutely to do with the way laravel runs tests. Every mode is booted once for the whole test run. This means that things can get out of whack on any test after the first one — this is the case for any global scope on  an eloquent model, not just Landlord.
Unfortunately, I don't think there's much that can be done about it from this package. I've opened PRs in the past to fix it in the framework, but Taylor has declined them. Perhaps that'd be the better strategy?

public function handle($request, Closure $next)
{
    if(auth()->check())
    {
        $tenantId = auth()->user()->tenant_id;
        Landlord::addTenant('tenant_id', $tenantId);
        Landlord::applyTenantScopes(auth()->user());
    }
    return $next($request);
}

I just added this as my middleware and it worked somehow. I am not sure 👯♂

Hey guys, does anyone have a solution on how to test queries being scoped (testing through http, not unit tests) without explicitly calling applyTenantScopes() for each scoped model in the middleware?


Updated to GhostBSD 6-21, and now update-station, software-station, firefox missing gtk support.

Line 790, in , Line 756, in init_,.
File /=use/local/lib/python3.8/site-packages/hi/overrides/Gtk.py"
line 515
Gtk  could not be initialized  Use Gtk.init_check() if you want to handle this case.
Will add picture later.
Rebooted GhostBSD and problem repaired.

Was that system rebooted after it got updated?

Rebooted and problem was repaired.
So a reboot, and GhostBSD was up and running again.   I wonder if you might consider putting in a  GTK_init_check() function??

Was that system rebooted after it got updated?

Did you see that error before rebooting the upgrade?

Still waiting for that anwser

I can't reproduce it.


ncRNA of Transposon origin

Back in 2015 these terms were requested(#299 ):
Transposable_element_pseudogene (SO:0001897)
and
transposable_element_CDS (SO:0001896)
Do you think it would be appropriate to have:
transposable_element_ncRNA with Parent ncRNA(SO:0000655) and transposable_element (SO:0000101)
This would be used to annotate ncRNAs that reside within the span of a transposable_element.
Background: We have a bacterial transposon that jumped into one of the C. elegans Fosmids used in the generation of the reference genome. This remains marked up in the reference genome and I am in the process of suppressing the ncRNA annotations, but don't want to delete them, just treat them like we do CDSs and Pseudogenes from Transposable elements.
Paul

Now looking at:
transposable_element_pseudogene
transposable_element_CDS
transposable_element_ncRNA
Should these be moved out into their own branch?

Paul -- for the C. elegans Tn10 insertion, I'd be inclined to annotate it as sequence_alteration_artifact (SO:0002172) rather than a transposon, on the basis that it is not a transposon that exists in C. elegans. And with that view, I'm not sure there's value in retaining the two ncRNAs in any form. My 2 cents -- I'm sure there will be many different viewpoints on this.
-Terence

Thanks @murphyte, we are going to be changing the way the region is marked up in our ENA records and removing the ncRNAs from the native transcript set, but as the object has existed in the database we need to retire them inline with what we do with all Transposon genes so having a SO compliant term as a classifier is still desirable.
P

Hi Paul,
I have looked at the SO terms transposable_element_pseudogene, transposable_element_CDS and transposable_element_ncRNA. All of them have two parents, one of which is transposable_element and the other is the other part of the name of the term. I believe this is the correct way to classify them. I do not believe that these terms should be moved to a separate branch as they do seem to fit within their assigned positions. Please comment with specific suggestions such as the name and location of the branch along with reasoning or publications regarding the matter if you still believe a separate branch must be created.
Thank you,
Dave


LAMHDI SO review ticket #3: ‘sequence alteration’

The current definition of ‘sequence alteration’ is “a sequence_feature whose extent is the deviation from another sequence”
There has historically been some confusion between ‘sequence alteration’ and ‘sequence variant’. To be explicit about the ‘extent of sequence’ to which a ‘sequence alteration’ refers, and clearly distinguish it from ‘sequence variant’, consider a clarifying comment such as: “The extent of a sequence alteration is limited to a continuous span of residues that are altered with respect to another sequence.”
It may also help to give some examples of the extent of different types of alterations, for example that the extent of a deletion is zero (and it is for this reason that a ‘sequence alteration’ is a type of ‘sequence feature’ and not a ‘sequence region’).

Response from @keilbeck
Hi Matt
Since we got the travel grant to work with you on these issues, I am making all the lamdi requests 'pending'
--K


when i open tq i get a couple errors ive no idea what they are

ive no idea what they are or mean and ive no idea what to do

Somehow the program fail to read Json vault files.
Maybe one of them is corrupted or a sector of your harddrive is corrupted.
Move all of the vault files outside it's directory and reintroduce them progressively, checking at each step by running the program.
Directory : %USERPROFILE%\Documents\my games\Titan Quest\TQVaultData

Thx I fixed it by deleting my old data from when I used it before


[fixed] Respect overflow css property when determining whether or not a tabbable node is hidden

Fixes #211.
Changes proposed:
When checking whether or not a node is hidden, we traverse up through the body element and say "Hey, if this element is 0x0, then it is hidden. Don't allow tabbing to its descendant." But if I, for example, position an element absolutely from its parent, theres a good chance that parent may collapse to 0x0. And if that parent has an overflow of 'visible', my input element is still visible and should be tabbable.
In our case it was .ReactModalPortal that was collapsing down to 0x0 and failing the tabbable check because it was considered hidden, even though our modal was visible. In this case, tabbing within a modal had no effect, as everything was descendent from the portal. My guess is most of the struggles people are having with tabbing come from a similar setup. As a work-around you can fix tabbing by setting the width or height of your collapsed parent element(s) to 1px
I've fixed this by changing the check from hidden to hidesContents, and altered it to respect the overflow property when the node has contents.
I've also gone ahead and added testing for the entire tabbable helper.
Upgrade Path (for changed or removed APIs): n/a
Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.

One thing I wasn't quite sure of... It looks like tabbable will traverse detached nodes up to their root and potentially return true... Is that intentional?

@conlanpatrek @diasbruno Any plans to merge this?

This PR fixes the tab issue I was having mentioned in #211

Coverage increased (+3.4%) to 86.375% when pulling 2c3ba5ae92459e60614d3bafe7ac12b8f2e31f7a on conlanpatrek:fix-visibility-check into 4b19b3db484726f2f4ca5ce28698b0b77590dc0e on reactjs:master.

@diasbruno I have rebased this. Was forced to shift some stuff around for the lint constraints. Take a look and let me know if you have any questions.

Coverage increased (+3.5%) to 86.441% when pulling 4bb297c2d75fb0dafc6bb39a438004bb1ea45358 on conlanpatrek:fix-visibility-check into 4b19b3db484726f2f4ca5ce28698b0b77590dc0e on reactjs:master.

Coverage increased (+3.5%) to 86.441% when pulling b6d5718040c871dc1e951fb2f47fb7d51445a5f1 on conlanpatrek:fix-visibility-check into 4b19b3db484726f2f4ca5ce28698b0b77590dc0e on reactjs:master.

Coverage increased (+3.5%) to 86.441% when pulling b6d5718040c871dc1e951fb2f47fb7d51445a5f1 on conlanpatrek:fix-visibility-check into 4b19b3db484726f2f4ca5ce28698b0b77590dc0e on reactjs:master.

Looks good! @mandazi Can you confirm the fix? If it is ok, you can approve and we merge this.

@diasbruno Confirmed. It works!

Thank you @mandazi and @conlanpatrek!

Released v3.1.3.

@diasbruno It might be worth checking if this solves the "me toos" presented in the comment threads of PR #224 and #266

Sure, I'll try to check those PRs later.


Food preferences language does not change immediately after app language change

What

Food preferences language does not change immediately after app language change
Spotted as we were demoing the app to a European Commission employee

Food preferences language does not change immediately after app language change

@teolemon If you mean the following data, that's because we use the server for localized data:
[{
  "id": "not_important",
  "name": "Not important"
}, {
  "id": "important",
  "name": "Important",
  "factor": 1
}, {
  "id": "very_important",
  "name": "Very important",
  "factor": 2
}, {
  "id": "mandatory",
  "name": "Mandatory",
  "factor": 4,
  "minimum_match": 20
}]

Given the very small number of labels to localize in init_preferences_en.json (4) we could do that as "normal" .arb translations, instead of using the server for that, what you you think?
PS: the same solution may not apply regarding init_attributes_groups_en.json because there are much more items to localize (or we limit to a couple of local localizations per attribute as a fallback while downloading).
[{
  "attributes": [{
    "icon_url": "https://static.openfoodfacts.org/images/attributes/dist/nutriscore-a.svg",
    "setting_note": "The Nutri-Score is computed and can be taken into account for all products, even if is not displayed on the packaging.",
    "name": "Nutri-Score",
    "default": "very_important",
    "setting_name": "Good nutritional quality (Nutri-Score)",
    "id": "nutriscore"
  }, {

...

@teolemon I didn't face this bug when I tried to change the language (in debug mode).
What i did:
1- Open the app.
2- Go to App settings screen.
3- Change language.
Please see the video: https://www.youtube.com/shorts/8Rj9cmulnq0

@abdullah-khudher The call to refresh is instant anyway. But how fast will the download be? And haven't we cached the downloaded file in a previous language change?

@teolemon There's no way we can solve this issue as is:

we cannot guarantee that the connection and the server would be ok at any moment, more specifically when you change the language
I would be ugly to store all localizations in the app assets "just in case"

That said, if you want to have a better "demo" effect, we can imagine something specific (like pre-downloading specific language localizations in dev mode).
But there's something not working here; it looks like you have to close the app so that in the next restart the localizations will be downloaded (if needed) and displayed.
@LuanRoger Do you feel like solving this issue?

Sure! I'll investigate this later, but what I've figure out for now:

that's because we use the server for localized data.

That's made by the ProductPreferences, but he's just called once since the app started (more specifically on app_navigator), so probably, this is the only moment that the localization is pulled from the server, when the app starts.
Some possible solutions I can think for now:

Use the .arb files (as mentioned by @monsieurtanuki) as a "local" and network/server independent solution.
Refresh the food preferences in some other moment on the app (when the user enter on the food preferences page, idk yet). This come with a pitfall:

Could cause UI frozen during the download, so it would be good run it on a background tasks or just show a simple progress bar when enter on the preferences pages during the download.

A more sophisticated one, could create a sort of language history to cache the ones that the user already pulled from the server, so when he changes the language again, it will check the cache and if exist the it will use it. But this would be a more complicated solution than just use the .arb files, since the localization will be local anyway.

@LuanRoger Let me give you some additional info:

we store one localization in the assets (English) as a fallback. As the app supports dozens of languages and there are about 30 items to localize, including verbose warnings regarding allergens, storing all the localizations in assets (or .arb) would probably not be a relevant option, let alone the induced lack of flexibility
when we download a localization, we already store it locally so next time it's needed we don't use the server
the problem here is that when we change the language we don't even check if we have a localization or try to download it - that is the issue. As I coded it a long time ago I'm almost certain that it worked, but since then many things changed, and our new route management or fixes about the classes in main.dart being refreshed too often may explain why we don't try to use the correct localization.
we probably don't really need background tasks here, but just an async without an await. It's also called at app start anyway.

TL;DR
It used to work, the main thing here is to call the specific localization refresh method when we change languages as an async without await.


Menu not working on dynamically injected dom.

specifically in $scope injected values and appending it using directives.
Does anyone has the same issue? or am I missing something?

nevermind, I fixed it myself.
here is the antagonist:
$(this._element).find('li').has('ul').children('a').on(Event.CLICK_DATA_API, function (e) {
the fix -- change it to. notice the ID selector though. will this is just a fast fix. just giving the hint why is it not working.
$(document).on('click', '#side-menu>li>a', function(e) {
just a note I am using v2.5.0


[FEATURE REQUEST] Create Controller method to delete a Comment

Is your feature request related to a problem? Please describe.
creating a controller method to enable users to delete an already made comment

i would like to work on this


Cleaned up code a bit, and use meshio package to create mesh object.

OK, Chris.  So far I’ve just done very trivial full scale tests (code is not yet big enough for unit tests, I think), and I haven’t implemented any checks on the results yet.  I’m open to new techniques.
Cheers,
Charles
Charles Williams I Geodynamic Modeler
GNS Science I Te Pῡ Ao
1 Fairway Drive, Avalon 5010, PO Box 30368, Lower Hutt 5040, New Zealand
Ph 0064-4-570-4566 I Mob 0064-22-350-7326 I Fax 0064-4-570-4600
http://www.gns.cri.nz/ I Email: C.Williams<EMAIL_ADDRESS>On 14/08/2020, at 10:10 AM, Chris B Chamberlain <notifications<EMAIL_ADDRESS>wrote:
@chrisbc approved this pull request.
Hi Charles all good thanks. FYI - I want to do a session soon on testing patterns as there are some techniques I'd like us to make use of in future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/GNS-Science/eq-fault-geom/pull/10#pullrequestreview-467164778, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJHOVOIIOC66KC4WLQJITDSARQFNANCNFSM4P5UFW6A.
Notice: This email and any attachments are confidential and may not be used, published or redistributed without the prior written consent of the Institute of Geological and Nuclear Sciences Limited (GNS Science). If received in error please destroy and immediately notify GNS Science. Do not copy or disclose the contents.

Thanks @willic3 no rush - just jotting it down while I had it in mind :+1:


how to add and remove atom index?

If I have a SMILES string like:
COC(=O)[C@H](CCCCN)NC(=O)Nc1cc(OC)cc(C(C)(C)C)c1O,
How can I add atom indexs to convert the SMILES to string like :
[NH2:1][CH2:2][CH2:3][CH2:4][CH2:5][C@@H:6]([C:7]([O:8][CH3:9])=[O:10])[NH:11][C:12](=[O:13])[NH:14][c:15]1[cH:16][c:17]([O:18][CH3:19])[cH:20][c:21]([C:22]([CH3:23])([CH3:24])[CH3:25])[c:26]1[OH:27]
Also, if I have the latter one, how can I get the former one?
I have another dataset, and would like to run your model, I am not sure how to convert the data format.

Hi,
If you're using RDKit as your main cheminformatics toolkit, you can use the SetAtomMapNum and GetAtomMapNum methods of atom objects (e.g., https://www.rdkit.org/docs/source/rdkit.Chem.rdchem.html#rdkit.Chem.rdchem.Atom.SetAtomMapNum)
For example,
import rdkit.Chem as Chem

smi = 'COC(=O)[C@H](CCCCN)NC(=O)Nc1cc(OC)cc(C(C)(C)C)c1O'
mol = Chem.MolFromSmiles(smi)
[a.SetAtomMapNum(i+1) for i,a in enumerate(mol.GetAtoms())]
print(Chem.MolToSmiles(mol))

smi = '[NH2:1][CH2:2][CH2:3][CH2:4][CH2:5][C@@H:6]([C:7]([O:8][CH3:9])=[O:10])[NH:11][C:12](=[O:13])[NH:14][c:15]1[cH:16][c:17]([O:18][CH3:19])[cH:20][c:21]([C:22]([CH3:23])([CH3:24])[CH3:25])[c:26]1[OH:27]'
mol = Chem.MolFromSmiles(smi)
[a.SetAtomMapNum(0) for a in mol.GetAtoms()]
print(Chem.MolToSmiles(mol))

Hi Connor,
Thanks for your kind reply! You solution works perfectly as I want.
One more question, how can I align atom index between reactants and products?
For example,
I have:
COC(=O)[C@H](CCCCNC(=O)OCc1ccccc1)NC(=O)Nc1cc(OC)cc(C(C)(C)C)c1O>>COC(=O)[C@H](CCCCN)NC(=O)Nc1cc(OC)cc(C(C)(C)C)c1O
I can get:
[O:1]=[C:2]([O:3][CH2:4][c:5]1[cH:6][cH:7][cH:8][cH:9][cH:10]1)[NH:11][CH2:12][CH2:13][CH2:14][CH2:15][C@@H:16]([C:17]([O:18][CH3:19])=[O:20])[NH:21][C:22](=[O:23])[NH:24][c:25]1[cH:26][c:27]([O:28][CH3:29])[cH:30][c:31]([C:32]([CH3:33])([CH3:34])[CH3:35])[c:36]1[OH:37]>>[NH2:1][CH2:2][CH2:3][CH2:4][CH2:5][C@@H:6]([C:7]([O:8][CH3:9])=[O:10])[NH:11][C:12](=[O:13])[NH:14][c:15]1[cH:16][c:17]([O:18][CH3:19])[cH:20][c:21]([C:22]([CH3:23])([CH3:24])[CH3:25])[c:26]1[OH:27]
How can I get:
O=C(OCc1ccccc1)[NH:1][CH2:2][CH2:3][CH2:4][CH2:5][C@@H:6]([C:7]([O:8][CH3:9])=[O:10])[NH:11][C:12](=[O:13])[NH:14][c:15]1[cH:16][c:17]([O:18][CH3:19])[cH:20][c:21]([C:22]([CH3:23])([CH3:24])[CH3:25])[c:26]1[OH:27]>>[NH2:1][CH2:2][CH2:3][CH2:4][CH2:5][C@@H:6]([C:7]([O:8][CH3:9])=[O:10])[NH:11][C:12](=[O:13])[NH:14][c:15]1[cH:16][c:17]([O:18][CH3:19])[cH:20][c:21]([C:22]([CH3:23])([CH3:24])[CH3:25])[c:26]1[OH:27]
It seems like your dataset already has this mapping. But now I have a new dataset. I am not sure how to process it. Thanks a lot for any suggestions!

The process of assigning atom map numbers is called "atom mapping" or "atom-to-atom mapping". If you do a quick Google Scholar search, you'll see that there have been a number of algorithms and methods proposed over the years. None of them are perfect. A primer is here: https://www.nextmovesoftware.com/products/AtomMapping.pdf
If you're potentially interested in a commercial solution, I might suggest contacting NextMove Software about their NameRxn software. If you already have licenses to any of the following software (or can get a trial as an academic), you could look at ChemDraw's atom mapping, ChemAxon's, or PipelinePilot. A completely open-source implementation that was used for the original USPTO data is part of the Indigo toolkit (https://lifescience.opensource.epam.com/indigo/api/index.html).

Thanks a lot for your information! I wil give it a try. Apprecidated.


Clarify steps to test node function locally

When it says this is a "reminder", it makes me go back to find where I missed a step - but it doesn't seem that is specified anywhere else when going through this tutorial, so it ends up being a waste of time.  This puts the steps in proper order for someone going step by step through this tutorial.

#in-progress

If you are using V3 of Functions core tools and the latest Azure Functions extension, these step shouldn't be necessary at all. If you find that it is necessary, can you tell me what version of these 2 tools you are running along with what version of Node.js you are running locally?

@diberry Cool, confirmed.  In that case, can I just adjust this PR to get rid of that line altogether instead of moving it?  I'm just trying to make it so people aren't tracing back to see what they missed, as indicated by remember.

@mlevinem6 - I updated this doc to make sure it matches with v3 of the functions local development. I don't believe a mention of running server is required anymore. I don't think the PR is relevent but if you still feel the text needs to change, please adjust and I'll take a look at it.

Changes look great, thank you @diberry !