Better game serialization during CFR serialization

Use game serialization that also covers sampled stochastic game implementations when de/serializing CFR solvers.

Hi @inejc thanks for the PRs. I am off until the 10th so will take a look when i am back.


[ko]Translate website/docs/tasks/administer-cluster/safely-drain-node into Korean

This is a Feature Request

What would you like to be added

Translate reference docs/tasks/administer-cluster/safely-drain-node.md into korean.
Why is this needed
There is no document of docs/tasks/administer-cluster/safely-drain-node.md which is translated into korean.
Comments

Pages to translate: https://kubernetes.io/docs/tasks/administer-cluster/safely-drain-node/
/language_ko
/assign

/assign


[sdk_migration] Run LUCI builders on presubmit and delete framework tests from cirrus

framework tests are already running in LUCI we need to run them by default in all the flutter sdk PRs and remove the windows and linux tasks from cirrus to avoid duplication.

This is complete


bert model

I used pretrained BERT model from hugging face. This was done to establish a proof of concept and are thus very preliminary findings and I did not perform an extensive analysis -- just set up the infrastructure.  In the example, I used a 1-5 star sentiment analysis.

@saatvikkher for some reason this is the most up to date request (it doesn't let me create a new one) -- let's merge this for website


mgmt: mcumgr: Remove Kconfig values that were deprecated in zephyr 3.1

Removes deprecated Kconfig values that have been replaced, includes release notes.
Fixes #50592

Deprecation is for 2 releases, not one.

They were deprecated in 3.1 so 3.1 and 3.2 have been out with the feature marked as deprecated, for 3.3 (now) they can be removed

Right, got it.


[BUG] Accordion has black outline above the focus state style

Description
The focus state in the accordion header is overwritten by the black outline.

Expected result
There is no black outline on the accordion header's focus state.

Steps to reproduce
  <Accordion type="multiple">
      <AccordionItem key={item.title} value={item.title}>
        <AccordionHeader size="lg">
          <TocText>{item.title}</TocText>
        </AccordionHeader>
        {item.items.map((itemChildern) => {
          return (
            <AccordionContent key={itemChildern.title}>
              <TocAnchor href={itemChildern.url}>{itemChildern.title}</TocAnchor>
              {itemChildern.items?.length ? <TocJsonWrapper tree={itemChildern} /> : null}
            </AccordionContent>
          );
        })}
      </AccordionItem>
</Accordion>

check canary 26
accordion story has been updated for this case


Update wireutils

just some standardization of wireutils across the myriad places it's used :P

I'll check it out tonight and merge/comment :)

did you? :P

Sorry, life came in the way. I'll try to do it tomorrow :)

luckily i got THAT one in before you pulled

checkdependencies.py seems to hang after warning that you're not root.

huh. lemme check on that.
On Wed, Oct 21, 2015 at 7:39 AM Jonatan Nordentoft<EMAIL_ADDRESS>wrote:

checkdependencies.py seems to hang after warning that you're not root.
—
Reply to this email directly or view it on GitHub
https://github.com/Locercus/Perdyshot/pull/4#issuecomment-149862387.

fixed
On Wed, Oct 21, 2015 at 7:40 AM Wire Segal<EMAIL_ADDRESS>wrote:

huh. lemme check on that.
On Wed, Oct 21, 2015 at 7:39 AM Jonatan Nordentoft <
<EMAIL_ADDRESS>wrote:

checkdependencies.py seems to hang after warning that you're not root.
—
Reply to this email directly or view it on GitHub
https://github.com/Locercus/Perdyshot/pull/4#issuecomment-149862387.

Looks great, merging! Thanks :smile:


CIV-6264: Trigger WA Task for Case Flags

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Moved to new branch


Windows 2012 Support

Windows 2012 isn't documented as being supported, for example in the readme.

This is a good question, has anyone found out for sure if this works with 2012?

win8 surfpro3 here, I could check out at least parts, but I'm a chef newbie.

Therefore the recipe would work if you just use Windows 8 as the platform

How do I change the platform? ty! AnneTheAgile

I've been successful with it on Windows Server 2012 and R2.  Haven't seen a use to using it on a Surface Pro.

I've used batch, dism, powershell and registry with 2012 r2 without issue.  Having trouble with the reboot handler but I think that's just me.

reboot handler works fine for me on 2012 R2


Reimplement the auto-completion for the Command Editor

Firebug 2 used to have the auto-completion, which is pretty powerful. We should have it back in firebug.next.
Florent

This needs to be implemented on the platform.
Honza

Wait, do they really have a command editor on the platform?
Florent

Wait, do they really have a command editor on the platform?

Not yet, but it's one of the top priority features planed.
If you want to work on this, please create a bug report in bugzilla.
Or do you want me to keep this open?
Honza

No, that's fine after what you said.
Florent


remove: create pull request to just creating branch for manual pull request

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a6f2f1) 88.40% compared to head (783c345) 88.40%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   88.40%   88.40%
=======================================
  Files          19       19
  Lines         742      742
=======================================
  Hits          656      656
  Misses         86       86

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automated Package Upgrade

:tada: This PR is included in version 7.7.286 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enabling/disabling tracing cannot be done after redirect

Describe the bug
When redirecting a request from one location to another, I cannot turn tracing on or off in the "child" location. It can only be turned on/off in the root location. I can set span attributes in the child location, which properly sets the attributes in the span.
It seems that the decision to sample or not is decided before a redirect happens. The problem here is that I could redirect to different child location blocks depending on the request, and I only want tracing for a specific child, not all children.
To reproduce
When sending requests to /:
The following config will not enable tracing:
      server {
        listen 80;

        location / {
          try_files /dev/null /child;
        }

        location /child {
          otel_trace on;
          otel_span_attr "testkey" "val";
          return 200 "ok";
        }
      }

The following config will enable tracing and set the span attribute:
      server {
        listen 80;

        location / {
          otel_trace on;
          try_files /dev/null /child;
        }

        location /child {
          otel_span_attr "testkey" "val";
          return 200 "ok";
        }
      }

The following config will not disable tracing:
      server {
        listen 80;

        location / {
          otel_trace on;
          try_files /dev/null /child;
        }

        location /child {
          otel_trace off;
          return 200 "ok";
        }
      }

May be somewhat related to https://github.com/nginxinc/nginx-otel/issues/47?
Expected behavior
I want to be able to make a sampling decision on a trace after a redirect happens. The following config should work.
      server {
        listen 80;

        location / {
          try_files /dev/null /child;
        }

        location /child {
          otel_trace on;
          return 200 "ok";
        }
      }

Your environment

nginx 1.27.0

Closing. Intended behavior, may be able to workaround with some conditions.


Where is the data?

From looking at the docker compose file I was not able to locate how and where the data is saved to disk between restarts. Is there a mounted volume for the mariadb database?
As an aside, great project!

@Belval I think the linked PR answers your question. If yes, you can close this issue :)

It does, thank you!


Unable to reproduce the article's results or metrics

First of all, I would like to express my sincere gratitude for your valuable work, which has provided me with new research insights. However, I encountered some difficulties when evaluating the model using the provided weights. Specifically, when I used the refinement weights to replicate the results, I obtained IOU values of 16%, 11%, and 6% at Voxel sizes of 0.5m, 0.2m, and 0.1m, respectively, rather than the reported values of 40.71%, 38.92%, and 24.75% in your paper.
Could you kindly provide the original weight file used in your paper for the metrics mentioned? I would greatly appreciate your assistance.
Thank you again for your work and your time.

I would suggest reverting any changes you did in the code and also git pulling the latest version of the code. This error is strange to me since I cannot reproduce it and also other people could already reproduce the results we reported in the paper.


Consistent version across entire workspace

Motivations
Currently, if you have a workspace with many crates, even if you start each crate off at the same version (e.g. v0.1.0), their versions will slowly diverge overtime.
The primary reason this seems to happen in when one crate (crate-a) has a breaking change when another crate (crate-b) does not, for example crate-a goes to v0.2.0 while crate-b goes to v0.1.1. Another reason is simply that one of the crates has not been updated since last release, and therefor release-plz doesn't detech any change.
Solution
It would be great if every single crate in the workspace would all stay on the same version, even if they haven't been changed. Optionally: it should just match the highest required version bump. In the above case, both crate-a and crate-b would go to v0.2.0.
Alternatives
Also open to other options, maybe something like this can already be enabled by using the existing features?

Release-plz supports cargo workspace versions.
https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table
Write the version in the main cargo.toml and inherit it in the other cargo.toml by specifying version.workspace = true


[Fix #10698] Enhance Style/HashExcept to support array inclusion checks

Fixes #10698.
I'm not sure if in?, exclude? should be covered by RuboCop, since it is an extension by ActiveSupport.
# Note the actual behaviors because it is confusing.

require 'active_support/core_ext/enumerable'
require 'active_support/core_ext/object'

# except
{ foo: 1, bar: 2, baz: 3 }.except(:foo, :bar)
# => {:baz=>3}

# reject
{ foo: 1, bar: 2, baz: 3 }.reject { |k, v| k.in?(%i[foo bar]) }
{ foo: 1, bar: 2, baz: 3 }.reject { |k, v| %i[foo bar].include?(k) }
{ foo: 1, bar: 2, baz: 3 }.reject { |k, v| !%i[foo bar].exclude?(k) }
# => {:baz=>3}

# select
{ foo: 1, bar: 2, baz: 3 }.select { |k, v| !k.in?(%i[foo bar]) }
{ foo: 1, bar: 2, baz: 3 }.select { |k, v| !%i[foo bar].include?(k) }
{ foo: 1, bar: 2, baz: 3 }.select { |k, v| %i[foo bar].exclude?(k) }
# => {:baz=>3}

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

I'm not sure if in?, exclude? should be covered by RuboCop, since it is an extension by ActiveSupport.

That's a tricky question. Normally I'd say "no", but ActiveSupport extensions are kind of special and most people use Rails. On the other hand they might have disabled some AS extension...
I don't think there's a high chance for false positives, though, so perhaps you can add some check if rubocop-rails is present and check for in? an exclude? or put this behind a config option.

Perhaps we need a configuration option whether rubocop cops to account for ActiveSupport methods, so people can just turn it on or off, and cops have common way to extend their own checks based on that.

Perhaps we need a configuration option whether rubocop cops to account for ActiveSupport methods, so people can just turn it on or off, and cops have common way to extend their own checks based on that.

Keep in mind that outside of Rails you can require those in a very granular way, though. But I guess a single option will be fine for most people, as I assume it's rarely used outside of Rails.

Looks good! We'll have to see which other cops can benefit from this setting and perhaps auto-set it to true in the presence of rubocop-rails, but overall we're on the right track.

All photos need to be linked #state #city #type #number ( 1,2,3,4,....)


Linux commands to get the status of running issues.

share the commands that gives the status of running processes

The htop command can be used. It is the most user friendly for a new user. Do you want me to write on it?

yep go ahead


Add files via upload

University of Solvay in Brussels
University website: https://exed.solvay.edu/
Student email has the following build<EMAIL_ADDRESS>Advanced master that includes machine learning that needs python  https://exed.solvay.edu/en/11-program/542-advanced-master-in-financial-markets-2?utm_source=adwords&utm_medium=ppc&utm_term=solvay master financial markets&utm_campaign=N4.1+-+AM+programs+-+BE+-2019&hsa_cam=8924254275&hsa_mt=e&hsa_ver=3&hsa_src=g&hsa_ad=494615038508&hsa_net=adwords&hsa_tgt=kwd-1646292526038&hsa_acc=2682379331&hsa_grp=89933922476&hsa_kw=solvay master financial markets&gclid=CjwKCAiAoL6eBhA3EiwAXDom5rWTXkcVrSbYTlgUDqxUbQ0SdBOsyvp6Jd9mwbLw6X_tSXXiibys2BoCCSsQAvD_BwE
Jetbrains access would be used for the machine learning and AI courses

file.zip

@AMFMleader Please provide us with:

some more info on email address retention policy: do graduated students lose access to their email addresses after graduation, or keep the addresses for their lifetime?
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

You can provide us with any of the following as the proof:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@philipto
Graduated Students lose their access to their email addresses and their Microsoft 365 upon the end of the year
We received an email on our main email address, since I cannot upload a .eml file I converted it to pdf, hope this has the required information to confirm the @solvaypostgrad.net  Email instructions.pdf

@AMFMleader  Thank you for the clarifications. Pull request merged.


Adding Links on the top of readme

@ykdojo  I added links on the top of readme #43

Added under the main Header. #44

Hii @ykdojo Please check this is it correct now. #44

Done sir


Fine-tuning on conversations (format of conversations)

Hello
I have a dataset consisting of dialogues between two people which I would like to use for fine-tuning GPT-J. Please see below for two example dialogues. The dialogues vary in length and can be longer than the examples.
Is the format of the conversations ok? For fine-tuning, should I just concatenate all conversations into one big file or do I have to use a separator between the conversations (if yes, which separator)?
First Dialogue:

user1:
Hey there. What’s up?
user2:
Not much, just hanging out. What about you?
user1:
Just thinking about what I’m going to do this weekend. You?
user2:
Probably just relaxing. What do you have planned?
user1:
I’m thinking about going to the beach. It’s supposed to be nice this weekend.
user2:
That sounds like a great plan! Have you been to the beach recently?
user1:
Not in a while. It would be nice to get out and enjoy the sun.
user2:
Definitely! I’m sure it’ll be a great time. Do you have any other ideas for the weekend?

Second Dialgoue:

user1:
Good morning. What is your profession?
user2:
Good morning. I’m an accountant. What about you?
user1:
I’m a software engineer. How long have you been an accountant?
user2:
I’ve been an accountant for about five years now. What about you? How long have you been a software engineer?
user1:
I’ve been a software engineer for three years. What do you like most about accounting?
user2:
I like how challenging it can be. There’s always something to learn or something new to figure out. What do you like most about software engineering?
user1:
I like how creative it can be. I get to come up with new ideas and new ways of solving problems. It’s a great feeling when you can come up with something that works.

sorry, why is this related to Codegen?


Security Issue Report

At api.main.py Stack trace information flows to this location and may be exposed to an external user.
static/execute.js uses a cryptographically insecure random number generated at Math.random() in a security context.

Thank you for reporting! I'll fix that!


codegen: Add support for nil msg and field to Pb(msg) and FromPb(msg)

Closes #401
To note:

not all nil cases will be detected.
Using reflection one can detect them all, e.g.:

jen.If(jen.Qual("reflect", "ValueOf").Call(jen.Id("pb")).Dot("IsNil").Call()).Block(
					jen.Return(jen.Nil()),
				),

But using reflection makes each call about 20 times slower than just comparing nil directly
Not using reflection should be fine except for the transport module, particularly when the transport module reconstructs the message from the stream (see 1, 2). As long as the unmarshaling or reconstruction FromPb in these two lines manage to clear out the possibility of a external node sending a message that will be reconstructed as shown in (1) (and assuming we also do not this locally when sending events), no reflection will be needed vs. ==nil. Not sure what is the behavior of proto.Unmarhsal, so unless otherwise clear for the reviewer, I suggest making a couple tests to rule out this possible vulnerability.

I cannot make lint happy for some reason, even if I make format. Lint is not liking my comment above canBeNil.

for 1-3, (disregarding what I suppose is a typo in your comment), with the current == nil it is possible for the adversary to fabricate a variable  so that it is actually nil. See this code for example:
import "fmt"

type myStruct struct {
	something uint64
}

func (ms *myStruct) doSth() {
	fmt.Println("I just did something")
}

func (ms *myStruct) doSthWithField(val uint64) {
	ms.something = val
	fmt.Println("just assigned val")
}

func main() {
	nilStruct := (*myStruct)(nil)
	if nilStruct != nil {
		nilStruct.doSth()
		nilStruct.doSthWithField(2)
	}
}

Running this code panics:
I just did something
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x481038]

goroutine 1 [running]:
main.(*myStruct).doSthWithField(...)
	/tmp/sandbox2129581525/prog.go:16
main.main()
	/tmp/sandbox2129581525/prog.go:24 +0x98

And this is a similar behavior that can be caused by an adversary if for example it casts variable sc := (*StableCheckpoint) nil, because:
func (m *StableCheckpoint) Pb() *checkpointpb.StableCheckpoint {
	if m == nil {
		return nil
	}
	return &checkpointpb.StableCheckpoint{
		Sn:       (uint64)(m.Sn),
		Snapshot: (m.Snapshot).Pb(),
		Cert: types3.ConvertMap(m.Cert, func(k types2.NodeID, v []uint8) (string, []uint8) {
			return (string)(k), v
		}),
	}
}

Which is why I mentioned that incoming messages should make sure an adversary cannot externally send something like this. If, as you mention, unmarshaling handles this, then that is perfect.

As for 4. and ...FromPb methods, yes, they tolerate nil values, see for example:
func StableCheckpointFromPb(pb *checkpointpb.StableCheckpoint) *StableCheckpoint {
	if pb == nil {
		return nil
	}
	return &StableCheckpoint{
		Sn:       (types.SeqNr)(pb.Sn),
		Snapshot: types1.StateSnapshotFromPb(pb.Snapshot),
		Cert: types3.ConvertMap(pb.Cert, func(k string, v []uint8) (types2.NodeID, []uint8) {
			return (types2.NodeID)(k), v
		}),
	}
}

func StateSnapshotFromPb(pb *trantorpb.StateSnapshot) *StateSnapshot {
	if pb == nil {
		return nil
	}
	return &StateSnapshot{
		AppData:   pb.AppData,
		EpochData: EpochDataFromPb(pb.EpochData),
	}
}
[...]

// ConvertMap is used by the generated code.
func ConvertMap[K, Rk comparable, V, Rv any](tm map[K]V, f func(tk K, tv V) (Rk, Rv)) map[Rk]Rv {

	if tm == nil {
		return nil
	}

	rm := make(map[Rk]Rv)
	for k, v := range tm {
		_k, _v := f(k, v)
		rm[_k] = _v
	}
	return rm
}

I think that the two code snippets in your first comment are actually different. The first one panics, but the second one should not. The difference is this guard in the second snippet:
if m == nil {
	return nil
}

In the first snippet, the panic is caused by trying to access the field ms.something in doSthWithField, but ms is nil. If you changed the function implementation to
func (ms *myStruct) doSthWithField(val uint64) {
	if ms != nil {
		ms.something = val
		fmt.Println("just assigned val")
	}
}

The code would not panic. And this is exactly what happens in the mir code (second snippet).
So we just need to make sure all the generated code is properly guarded this way (but it seems to me that those already are in place).

We are on the same page for everything except for the certainty that the attack cannot happen. If the pointer is cast by the caller of the function to a particular type other than jnterface{}, but of value nil, I am not so sure that the problem will not happen (like in the example). For me the question is whether this can happen in Mir after reconstructing such pointer from a received message. If this is not possible then great. Otherwise I still believe an adversary could send a message with a field with a particular pointer type but a nil value and make the recipient crash.
In any case, this is fine-threading, but should be considered.

At message reception, the protobuf unmarshaller always decodes a messagepb.Message or returns an error. The content of the message can be as malicious as it wants, but the types of the fields are always correct, as defined in the .proto file. Also, in general, methods can only be called on the appropriate types, that's a compile-time check. So it's impossible to call a method with a "wrong" receiver type. In particular, the receiver is never an interface type, it is always a concrete pointer that can be simply checked against nil, which our generated code does (at least I assume it does, from what I've seen).

[Solved with the message and in sync] sorry for the confusion!


How to use method_profiler in rails app ?

Hello,
I had studied readme.md but I am not able to find that how to configure method_profiler with rails app. How to  use with rails app ?
Thanks
Best Regards
Fahim Babar Patel

I have used method_profiler with Rspec. Was kinda simple once i figure out how to modify spec_helper. Update the spec_helper with this.
require 'method_profiler'
RSpec.configure do |config|
config.before (:all) do |spec|
@file = File.open("performance-test.txt", "a")
@profiler = MethodProfiler.observe(spec.described_class)
end
config.after :all do |spec|
@file.write @profiler.report.to_s
@file.close
end
end

Simplest example:

Include in Gemfile gem "method_profiler"
Use it where it interesting for you:

# for ex. in Controller:
def some_action
  profiler = MethodProfiler.observe(Project)
  p = Project.find params[:id]
  p.calculate_something
  puts profile.report
end


Fix product sorting for processes graphql resource

also improved workflot filter because workflow.target wasn't filterable yet.

Codecov Report

Merging #353 (9b2b175) into main (7575ad4) will decrease coverage by 0.03%.
The diff coverage is 78.94%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   73.07%   73.05%   -0.03%
==========================================
  Files         183      183
  Lines        8716     8724       +8
  Branches     1429     1431       +2
==========================================
+ Hits         6369     6373       +4
- Misses       2165     2169       +4
  Partials      182      182

Files Changed
Coverage Δ

orchestrator/db/sorting/process.py
80.00% <71.42%> (-20.00%)
:arrow_down:

orchestrator/db/filters/workflow.py
87.50% <100.00%> (+2.88%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Activity ID need a review/edits

[ ] Mike S to review the current activity IDs and suggest edits.


after rule for date validation throws error when date is passed

consider the following:
const today = moment().format('YYYY-MM-DD');

<input v-validate ="'required|date_format:YYYY-MM-DD|after:' + today">

this will work perfectly fine - it invalidates when the date is before today. But there are still errors being thrown because vee-validate tries to use the date as a selector:

that was fast 👍

Was pretty simple to fix, the issue was that after pr #616 the rules that had a dependency that doubled as a value like after were not being handled properly. A simple try...catch fixed it.


Change name

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ec25d06). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   88.73%
=======================================
  Files           ?       12
  Lines           ?      142
  Branches        ?       16
=======================================
  Hits            ?      126
  Misses          ?        0
  Partials        ?       16

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Email settings design update

Updated Email settings and Portal settings design to make it more scalable and more consistent with the rest of the Admin.

Codecov Report

Merging #2359 (2610957) into main (75395a0) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2359      +/-   ##
==========================================
- Coverage   39.34%   39.24%   -0.10%
==========================================
  Files         621      621
  Lines       24367    24379      +12
  Branches     4276     4280       +4
==========================================
- Hits         9586     9568      -18
- Misses      14781    14811      +30

Impacted Files
Coverage Δ

app/components/modal-portal-settings.js
0.95% <0.00%> (-0.03%)
:arrow_down:

app/components/modals/newsletters/edit.js
6.06% <0.00%> (-1.35%)
:arrow_down:

app/components/gh-html-iframe.js
45.45% <0.00%> (-38.64%)
:arrow_down:

app/helpers/gh-price-amount.js
70.00% <0.00%> (-20.00%)
:arrow_down:

app/components/gh-image-uploader.js
94.66% <0.00%> (+0.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75395a0...2610957. Read the comment docs.


[Helm][minor] Make "disabled" flag for worker groups optional

This is a minor issue with the ray-cluster Helm chart.
It seems that leaving out the disabled flag from the default worker group may cause an error when deploying with Helm 3.7.2.
The RayCluster template should be modified such that the disabled flag can be removed without issue.
See https://github.com/ray-project/kuberay/issues/537 and https://github.com/ray-project/kuberay/pull/543.
The overall goal is to simplify default configuration as much as possible -- there should not be too many required fields.

PR: #548


[CONSULTATION NEEDED] Receive new events more quickly

Hi. I have an app that just listening for new events (text, files etc.) in a loop. This app doesn't invoke any API methods, just listening. Ocaisonally some events can arrive with a huge delay (in coparison to mobile app), delay can reach tens hours.
Example:

Original event has timestamp - 2021-04-05 16:27:35 +0000 UTC
Delivered to the app - 2021-04-06 08:49:12 +0000 UTC

It looks like some actions might trigger all events delivering.
Question: how to decrease time (in a right way) for new events receiving ?

Are you talking about updateNewMessage events or some other events?

Are you talking about updateNewMessage events or some other events?

Yes.

Do you have TDLib's log with verbosity level 4 for the whole time frame from the original event to the time the message was received?

Nope. I think it would be a huge log file. But I have something interesting.
Consider such situation:

App and Mobile Client use the same number and work with the same set of channels.

A, B, C - public channels with new events (non-stop arriving).

X - special public channel for testing.

We don't have new events in App.

We go to Mobile Client and post something (random typing) in the channel X.

App! received new events from the channel A. B and C sent nothing.

Are you a mamber of the channels?

Yep.

How much active sessions does the account have?

Currently it's 6 devices. But I don't see correlation right now. Previously I thought the same and killed all sessions from Mobile Client and nothing had changed.

The described delay could happen if you had 10+ sessions.

You can also try to bring the account online by setting option "online" to true.

Could you expand landscape of the problem ?

There should be no problem if the user is a member of the channels and has less than 10 active sessions.

I'am a member of the channel and I have less than 10 active session (6), but I have problem that server client gets event updateNewMessage only if I read this message of desktop or mobile client

@borzovplus Have you tried to use different account ?

@livelace yea, other accounts work correctly. And moreover, what is very strange - this problem is not with all channels in problem account. I passed "online: true" in the parameters of tdlib now and checking (but it doesn't look like that's the problem). I also tried restarting and deleting it .tlg but it didn't help.
I'm completely confused ((

@borzovplus 1.6.0 is too old. You need to regularly update TDLib to keep receiving updates in time.

Well, 1.6.0 gave me immediate delivery inside testing channels and delayed delivering with other channels. I switched my app to 1.7.0 and messages now delivering fast, but I'm not sure why it's happening because:

I used to use multiple td clients withing one app (1.6.0).
1.7.0 version has huge changes and some of them have forced me to use only one td client per app instance.

None of these. You just need to update TDLib frequently regardless any changes in TDLib.

To be honest, I don't expect so huge differences between minor releases.

It doesn't depend on actual changes in TDLib at all.

It doesn't depend on actual changes in TDLib at all.

Good to know. So, does it mean that "older" clients receive events more slowly by design (and bo doing this you force people to move to newer versions) ?
PS. Just blink, if so :)

Yes, "older" clients doesn't receive events in big channels in real time, but this is completely unrelated to forcing someone to update their clients.


Build errors Network.URI and unsafePerformIO

Hi,
I have tried to build openid and got to build problems:
src/Network/OpenID/Authentication.hs:35:8:
Could not find module ‘Network.URI’
It is a member of the hidden package ‘network-uri-<IP_ADDRESS>’.
Perhaps you need to add ‘network-uri’ to the build-depends in your .cabal file.
Use -v to see a list of the files searched for.
[11 of 17] Compiling Data.Digest.OpenSSL.SHA ( src/Data/Digest/OpenSSL/SHA.hs, dist/build/Data/Digest/OpenSSL/SHA.o )
src/Data/Digest/OpenSSL/SHA.hs:26:8:
Not in scope: ‘unsafePerformIO’
src/Data/Digest/OpenSSL/SHA.hs:32:10:
Not in scope: ‘unsafePerformIO’
I have tried to fix both problems:
https://gist.github.com/promi/596ce61dd824f27a28d9

I think that these errors should be resolved in version <IP_ADDRESS>. Sorry for the incredibly long delay!


Lookup error

Environment data

Language Server version: 0.5.45
OS and version: KDE Neon 5.18
Python version (& distribution if applicable, e.g. Anaconda): 2.7.15

Expected behaviour
Error getting search paths. Not sure how it affects completion.
Actual behaviour
No error.
Logs
[Info  - 4:18:22 PM] Analysis cache path: /home/cllamach/.cache/Microsoft/Python Language Server
[Info  - 4:18:22 PM] Microsoft Python Language Server version <IP_ADDRESS>
[Info  - 4:18:22 PM] Workspace root: /home/cllamach/Panopta/classic
[Info  - 4:18:22 PM] GetCurrentSearchPaths /home/cllamach/.virtualenvs/panopta_env/bin/python
Traceback (most recent call last):
  File "/home/cllamach/.vscode/extensions/ms-python.python-2020.3.71659/languageServer.0.5.45/get_search_paths.py", line 31, in <module>
    import site
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding
[Info  - 4:18:22 PM] Interpreter search paths:
[Info  - 4:18:22 PM]     /home/cllamach/bin/python
[Info  - 4:18:22 PM] User search paths:
[Info  - 4:18:22 PM]     /home/cllamach/Panopta/classic/src
[Info  - 4:18:23 PM] Initializing for /home/cllamach/.virtualenvs/panopta_env/bin/python
[Info  - 4:18:23 PM] Analysis caching mode: None.

Some quick searching shows that this message is an issue with the Python install. It shouldn't fail to find the UTF-8 encoder (that would be pretty catastrophic). Given this is a virtual environment, did you update the version of Python this environment is based on?
I'm also seeing people mention that it can occur when there's a module in the path called "unicode", i.e. you've named a module the same as a builtin.

No, this just happened on a freshly installed machine of KDE Neon 5.18, system python, 2.7.17 (sorry, thought it was .15). The base for neon should be Ubuntu 18.04, so not sure how that would mess up the python installation.
Other weird thing is that if I open an ipython shell from that virtualenv, encoding a string in utf-8 doesn't raise an exception.
[panopta_env] infrastructure [master]× » ipython                                                                                ~/P/infrastructure
Python 2.7.17 (default, Nov  7 2019, 10:07:09)
Type "copyright", "credits" or "license" for more information.

IPython 5.5.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.

In [1]: p = '/home/cllamach'

In [2]: p.encode('utf-8')
Out[2]: '/home/cllamach'

In [3]:

Is there a way I could replicate that get_search_paths.py call from outside the language server?

Yes, the file exists in the language server's download folder. It should be somewhere in $HOME/.vscode/extensions/ms-python-*/langaugeServer (a path like this, from memory), then runnable just as a script within the environment like:
$ python -S -E /path/to/get_search_paths.py

yeah, seems to be an issue with the virtualenv. Calling that without it activated works, but it raised an exception when using the virtualenv python.
languageServer.0.5.45 » python -S -E get_search_paths.py                                                                       ~/.v/e/m/languageServer.0.5.45
/usr/lib/python2.7|stdlib|
/usr/lib/python2.7/plat-x86_64-linux-gnu|stdlib|
/usr/lib/python2.7/lib-tk|stdlib|
/usr/lib/python2.7/lib-dynload|stdlib|
/home/cllamach/.local/lib/python2.7/site-packages|pth|
/usr/local/lib/python2.7/dist-packages|site|
/usr/lib/python2.7/dist-packages|site|

languageServer.0.5.45 » vf activate panopta_env                                                                                ~/.v/e/m/languageServer.0.5.45

[panopta_env] languageServer.0.5.45 » python -S -E get_search_paths.py                                                         ~/.v/e/m/languageServer.0.5.45
Traceback (most recent call last):
  File "get_search_paths.py", line 31, in <module>
    import site
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/cllamach/.virtualenvs/panopta_env/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding

Thank you for the update!

I'm currently hitting this after a fresh ubuntu install (18.04) with python2.7 as well, creating the virtualenv manually yields the same error.
[Info  - 3:19:34 a.m.] Analysis cache path: /home/jordan/.cache/Microsoft/Python Language Server
[Info  - 3:19:34 a.m.] Microsoft Python Language Server version <IP_ADDRESS>
[Info  - 3:19:34 a.m.] Workspace root: /home/jordan/dev/reponame
[Info  - 3:19:34 a.m.] GetCurrentSearchPaths /home/jordan/Envs/reponame/bin/python
Traceback (most recent call last):
  File "/home/jordan/.config/coc/extensions/coc-python-data/languageServer.0.5.50/get_search_paths.py", line 31, in <module>
    import site
  File "/home/jordan/Envs/reponame/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/jordan/Envs/reponame/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/jordan/Envs/reponame/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding

Any suggestions?

What happens if you call this python -S -E /home/jordan/.config/coc/extensions/coc-python-data/languageServer.0.5.50/get_search_paths.py while the virtualenv is disabled completely? That's how I figured out that it was my virtualenv that had the issue.

It seems to be specifically related to a python2 virtualenv. Running that command using global py2 works fine. I've tried recreating it with virtualenv manually and using virtualenvwrapper but no luck.
Anyway, appreciate the response @CMLL

Did the virtualenv came installed with python? Can you try installing it new? I believe it can be installed from pip.

I manually installed virtualenv and virtualenvwrapper globally with pip2

I'm having trouble also. I use pipenv in my project:
[Info  - 8:13:29 p.m.] Analysis caching mode: None.
Traceback (most recent call last):
  File "/home/alan/.vscode/extensions/ms-python.python-2020.6.80635-dev/languageServer.0.5.50/get_search_paths.py", line 31, in <module>
    import site
  File "/home/alan/.local/share/virtualenvs/fp_iss_offload-v_mstYUo/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/alan/.local/share/virtualenvs/project-v_mstYUo/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/alan/.local/share/virtualenvs/project-v_mstYUo/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding

I can repro with pipenv run:
$ pipenv run python -S -E /home/alan/.vscode/extensions/ms-python.python-2020.6.80635-dev/languageServer.0.5.50/get_search_paths.py
Traceback (most recent call last):
  File "/home/alan/.vscode/extensions/ms-python.python-2020.6.80635-dev/languageServer.0.5.50/get_search_paths.py", line 31, in <module>
    import site
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding

or just trying to import site;site.main() from pipenv run:
$ pipenv run python -S -E -c "import site;site.main()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 165, in <module>
    main()
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 19, in main
    load_host_site()
  File "/home/alan/.local/share/virtualenvs/project-GnuKVr7R/lib/python2.7/site.py", line 54, in load_host_site
    full_path = os.path.abspath(os.path.join(here, path.encode("utf-8")))
LookupError: no codec search functions registered: can't find encoding

However, dropping the -S flag makes it work:
$ pipenv run python -E -c "import site;site.main()"
$ pipenv run python -E -c "import encodings;print encodings"
<module 'encodings' from '/usr/lib/python2.7/encodings/__init__.pyc'>

...except for the language server, which demands -S:
$pipenv run python -E /home/alan/.vscode/extensions/ms-python.python-2020.6.80635-dev/languageServer.0.5.50/get_search_paths.py
Traceback (most recent call last):
  File "/home/alan/.vscode/extensions/ms-python.python-2020.6.80635-dev/languageServer.0.5.50/get_search_paths.py", line 27, in <module>
    raise RuntimeError('script must be run with -S')
RuntimeError: script must be run with -S

Any idea what I'm doing wrong?

I run into the same issue as @darkvertex, using pipenv with a Python 2.7.17 interpreter. This is what I found:

Running python2 directly from outside the virtualenv created by pipenv works file:

$ python2 -S -E -c "print('hi'.encode('utf-8'))"
hi

Running the same, but using the interpreter inside the virtualenv created by pipenv fails with the error I see on the language server console in vscode:

$ pipenv run python -S -E -c "print('hi'.encode('utf-8'))"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
LookupError: no codec search functions registered: can't find encoding

There's clearly something wrong with the virtualenv, but can't yet figure out what it is.

I'm experiencing the same problems.

@symc-gail - Try Pylance language server on the VS Code marketplace. This server is no longer actively developed.


Liveness and Readiness probes configuration

Tell us about your request
An option to configure our own readiness and liveliness probes in the karpenter deployment.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
with the default low values for the thresholds the containers in the pod are restarting and cannot get into ready status.
Are you currently working around this issue?
manually increasing the probe times
Additional context
Anything else we should know?
Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

What region are you deploying in so I can try to reproduce, and is this just the webhook, or both?

Should be fixed with https://github.com/aws/karpenter/pull/2032

This should be resolved in the v0.13.2 release from today.


Blocking Sentry seems to break the app

I loaded the main ShareDrop instance on Firefox (Steam Deck, which uses an Arch-ish Linux) with uBlock Origin enabled, and found myself unable to accept a transfer request from my Android phone.
Digging into the browser console on the Deck revealed failing requests to Sentry every time I tried to click the button that would accept the transfer. Disabling uBO for sharedrop.io let me complete the process.
Honestly, inability to connect to a logging service shouldn't be a show-stopper. I believe the app should handle the error and continue. (I also think it's hilarious and sad that ShareDrop would be immediately better than 95% of mobile-ordering apps I've had to install for various chains if it gracefully handled being blocked from sending out metrics.)
I apologize if I'm missing something obvious, or if I've followed a red herring in the JS error log. My interest is only in helping make ShareDrop more reliable even for privacy-conscious users.

Thanks for reporting it. I'll try to look into it this week.


Fix groupBy regression on time extractions named __time

Fixes #3683

👍

Hmm after thinking about this some more I wonder if it's something we really want to support. Maybe having this query fail is OK, and it should actually fail with a more descriptive error. The reason is that naming output fields __time is problematic for features like,

nested queries: If the inner query has granularity "hour" and also has a dimension with outputName __time, and the outer query filters or groups on __time, is that referring to the timestamp of the inner rows or is it referring to the dimension named __time?
having specs: If a query has a metric with output name __time, and a having spec filters on __time, is that referring to the timestamp of the rows or to the metric named __time?

Currently I believe for nested queries it refers to the timestamp but for having specs it refers to the metric named __time. This is inconsistent and weird and I think there's the best answer is to disallow dimensions or metrics with output names of __time.

You can see all of these issues come from the fact that groupBy results have anonymous timestamps in addition to actual named fields coming from dims and metrics and postaggregators. "Higher level" things like having specs and nested queries can access the timestamp by calling it __time, but that ends up shadowing any similarly named field from a dim or metric or postaggregator.
As a separate but related issue, I think nothing is really stopping anyone from defining a dimension and metric with the same output name. We should detect and fail on that at the constructor level, since otherwise one will clobber the other.

Maybe since this used to work, we can take the attitude that for 0.9.x that the behavior is that you are allowed to have a dimension or metric with name __time, and it will be returned to you just fine in the query result, but "higher level" Druid constructs like having specs and outer queries will not be able to see it. Instead, they'll see the anonymous timestamp of the row. I think this matches how <IP_ADDRESS> worked.
In 0.10.0 I'd like to make it so naming something __time just fails outright.

I suggested an alternate fix in #3685.
I also raised #3687 for discussing what to do about the remaining issues with __time and groupBy, and #3686 for 0.9.3 with validation of the "separate but related issue" that dimensions/metrics/postaggs could collide.

Closing in favor of #3685


The 'artisan optimize' command is now deprecated.

In Laravel 5.5, the artisan optimize command is deprecated, so this PR just removes it from the readme.md.
See https://laravel.com/docs/5.5/upgrade

And see: https://laravel-news.com/laravel-5-6-removes-artisan-optimize

@barryvdh Any chance you can look at this? The instructions obviously don't work for 5.6 since optimize is no longer a thing.


docs: Replace mongo queries with postgres queries to stay in sync wit…

…h CPAPI

I'm putting this as a draft until the postgres changes on cloud-pricing-api are released.


Vim Perl highlighter fails.

Hello,
I would like to report that syntax highlighter in vim does fully support lambdas in Perl:

#!/usr/bin/env perl

use strict;
use warnings;

sub say { print @_, "\n" }

say (&{ sub {
		my $m = 1;
		$m *= $_ for @_;
		return $m;
	}
}(1..8));

The code compiles and outputs 40320 with perl 5, version 16, subversion 2 (v5.16.2) built for darwin-thread-multi-2level.
My vim version:
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Nov  3 2015 11:37:52)
MacOS X (unix) version
Included patches: 1-903
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +syntax
+arabic          +file_in_path    +mouse_sgr       +tag_binary
+autocmd         +find_in_path    -mouse_sysmouse  +tag_old_static
-balloon_eval    +float           +mouse_urxvt     -tag_any_white
-browse          +folding         +mouse_xterm     -tcl
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+cindent         -gettext         -mzscheme        +textobjects
-clientserver    -hangul_input    +netbeans_intg   +title
+clipboard       +iconv           +path_extra      -toolbar
+cmdline_compl   +insert_expand   +perl            +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python          +viminfo
+cscope          +lispindent      -python3         +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      +lua             +rightleft       +windows
+diff            +menu            +ruby            +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      -sniff           -xsmp
+eval            +mouse_dec       +startuptime     -xterm_clipboard
+ex_extra        -mouse_gpm       +statusline      -xterm_save
+extra_search    -mouse_jsbterm   -sun_workshop    -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: /usr/bin/clang -c -I. -Iproto -DHAVE_CONFIG_H   -F/usr/local/Frameworks -DMACOS_X_UNIX  -Os -w -pipe -march=native -mmacosx-version-min=10.9 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1

This is a runtime file issue, so it should be discussed with the maintainer (See Contributing.md ). The perl syntax files seem to be maintained here. So please open an issue at the @vim-perl repository.


Make modal dialog exit animations visible

Problem: the /settings/profile route uses an <Outlet /> to display modals from child routes photo and two-factor. The models are opened and closed by client-side navigation to the child routes and back. The shadcn ui dialog component comes with CSS entry and exit animations, but when the navigation happens to exit the modal, it cuts off the animation before it can complete.
I drew on a blog post from Jacob Paris here for my approach to addressing this: https://www.jacobparis.com/content/remix-animated-page-transitions
Summary of changes:

Wrap the useOutlet hook with useState and replace the <Outlet /> with it
Add SwitchTransition and CSSTransition from react-transition-group
Update modal component's useLoaderData hooks to be able to fallback to using an empty object so that components don't error out when data is unloaded by navigation
Control whether the modal dialogs are open or closed using useState and trigger them to close before navigation happens

Test Plan

Verify that the e2e tests related to profile photos and 2fa still pass
Manually check that profile photo and 2fa modals look ok when closed:

by clicking outside of the modal
by clicking the 'x' icon
by submitting the form

Checklist

[x] Tests updated:

add a line to the profile photo settings e2e test so that playwright checks that the dialog is hidden before it checks that the redirect happens
change 2fa test to close modal dialog using 'x' icon as a button rather than a link

No docs changed.

Screenshots
Before:
After:
I think these changes are an improvement, but I'd certainly appreciate oversight and review here. I'm a little unsure about the case where the profile.two-factor.verify modal is closed by form submission; it is possible that that may warrant further work.

I'll have to see what's going on with that test later today

I'm not sure if I'll be able to find a good way to prevent that, but I'll try to figure something out


Basis of Qewd-Courier FHIR Demographics Service

The PR looks great. I just put some comments to some lines in the code but they do not change the logic heavily.

The coverage is about 82% and I think it can be increased because some parts are not covered with tests (see my comments "unit tests").

@richardcbrown Forgot to mention, could you please add .editorconfig to the root of the project?
Example:
https://github.com/QEWD-Courier/QEWD-Courier/blob/develop/.editorconfig

@richardcbrown Looks very good. I just have added some notes and thoughts.

Updated to address latest code review comments

thanks both Richard @richardcbrown  and Alexey @killmenot
Merging this
FYI @richardcbrown the Helm dev env is Docker based on Ubuntu, and we'll be deploying this via Docker in staging and production env also
Need chat with Rob @robtweed on this. thanks, T


[4.0 Beta3] Reflections of moving objects remain static when SDFGI is on

Godot version
4.0 Beta 3
System information
Win 10, RTX 2070 mobile
Issue description
Reflections on reflective surfaces (ie, surfaces with a standard material, low refraction + Environment node with SDFGI enabled) behave as if they were getting baked into the surface and don't update then the object casting the reflection is moving.
See this tweet (when the boat moves, its reflection in the water remains static): https://twitter.com/devinthewater/status/1584120475240009729
Steps to reproduce
Create a 3d scene
create any mesh object
create a mesh instance (plane), place it below the object, add a standard material
on the material, disable alpha and set refraction to 0 to make the surface reflective
create an Environment node, new environment
enable SDFGI with default settings - you should now see the object's reflection on the surface
grab and move the object, see how its reflection stays motionless.
Minimal reproduction project
No response

that isn't a bug, you're baking the boat into SDFGI, you should set the boat to dynamic instead of static, as it isn't static.

SDFGI doesn't support dynamic occluders. Use a ReflectionProbe node for fully real-time reflections.


"Save Branch as Scene" on node with "Scene Unique Name"

Godot version
3.5.stable
System information
Windows 10
Issue description
Using "Save Branch as Scene" on node with "Scene Unique Name" enabled creates a new scene with it's owner node having Scene Unique Name enabled.

Steps to reproduce

Create a new scene
Add a child node to the scene
Enable "Scene Unique Name" on the child node
Use the "Save Branch as Scene" context menu option on the child node

Minimal reproduction project
Scene Unique Name Bug.zip

I confirm this also happens in Godot 4.


Remove juce build artefacts from example project

@nick-thompson, minor thing to remove unwanted stuff from example project.

Yea, understandable :) I keep these things in here intentionally so that an end user needs nothing other than Xcode or VSCode (and, in this case, node/npm) to get an example project up and running.
I realize it's largely cruft, but I think I'd like to keep 'em in until we make our move to juce6/CMake. Once the examples are cmake-ified we can drop all this as well as the projucer files, and generally clean up the repo a bit

Ahhh on fair enough. I hadn't appreciated it was a conscious choice. Nothing to see here!


Result is Null

Hello! I like the module. However, for some reason csv.result is always null, even though csv.content contains the contents of my CSV.
In my controller:
    $scope.csv = {
      content: null,
      header: true,
      headerVisible: true,
      separator: ',',
      separatorVisible: true,
      result: null,
      encoding: 'ISO-8859-1', //also tried utf8
      encodingVisible: true,
    };

    // this is trigged by a button press.
    // I wait a few seconds to make sure the file has had time to load
    $scope.showFile = function () {
      console.log($scope.csv.result); //null
    };

Does this mean there is something wrong with my CSV file?

Whoops, I spelled the result attribute wrong: reesult


incorrect sum and average, 3.00 is not parsed correctly

For some reason numbers with to trailing zeroes are not parsed and summed correctly. Here's an example table
`
A1
B3.0
C3.00

`
When alt-selecting second column from top row the sum will yield 1, then 4 and 4 again after selecting last row. Count is correct, Average is also affected.

Cannot reproduce this anymore. I am not sure, but probably this was solved in commit 3e3c753.


Tasks/#60 update docs

connect #60

Coverage remained the same at 98.018% when pulling fb99d89e5388c5d776fbfa4b7f8cea54249541bd on hoatle:tasks/#60-update-docs into d13af035fe53d9cf825eeb4ac9f4bcbcad726678 on teracyhq:develop.

Hello @eligundry, @hjc, @mattbillenstein, @sh4r3m4n, @wodow, @AlJohri, I've updated the docs for v0.14.0 release, if you guys could help verify and let me know if there is anything missing, that would be very helpful, thank you guys :-)

hi @hoatle I haven't been using flask-classful but I verified that the trailing slash fix worked on my example app using the latest code in master.
if you get a chance, can you try to get flask-classful working with flask-apisec? I ran into trouble here: https://github.com/jmcarp/flask-apispec/issues/54
something to do with multiple metaclasses, I'm not sure. np if this out of scope, just figured I'd ask. this is the feature that made me go the django rest framework route instead. thanks!

also what is from representations import output_json - that seems a tad confusing? where is the import coming from

@AlJohri you need to see the full context here: https://github.com/hoatle/flask-classful/blob/fb99d89e5388c5d776fbfa4b7f8cea54249541bd/docs/index.rst#adding-resource-representations-get-real-classy-and-put-on-a-top-hat to know about from representations import output_json

@AlJohri for flask-apispec, I'll take a look at it soon.

@hoatle that make sense, I'm more used to the absolute from app.representations import output_json or relative from .representations import output_json so I got thrown off
and thanks for looking into it!

@AlJohri good point, I've updated to use the relative import, thank you.

Coverage remained the same at 98.018% when pulling fd1df9b24e0b8f9d77dcd5c9e8a6e1badb04c389 on hoatle:tasks/#60-update-docs into 5f01f55fca51644585250bffabe239c338a1ca40 on teracyhq:develop.

@hjc thank you for your reviewing, I tried to cover all possible docs by looking through the commits history https://github.com/teracyhq/flask-classful/commits/develop and the associated milestone of this release https://github.com/teracyhq/flask-classful/milestone/8?closed=1
For the change log draft, I'll add it later basing on https://github.com/teracyhq/flask-classful/milestone/8?closed=1

Coverage remained the same at 98.018% when pulling 631f79f9d6f76aa1fb66da8b27b25d3bb5df711c on hoatle:tasks/#60-update-docs into 5f01f55fca51644585250bffabe239c338a1ca40 on teracyhq:develop.

I'm going to merge this first, will continue updating more docs then.

docs updated http://flask-classful.teracy.org/develop/

@hoatle - gotcha. Just reviewed through that milestone in GitHub and I think there are a few things that are undocumented, I'll swoop through tomorrow afternoon and document to help out!


groovy-bom dependency has no LICENSE

I've recently upgraded from Groovy 3.x to 4.x. As part of that upgrade, my :checkLicense task (using https://github.com/jk1/Gradle-License-Report) has identified that groovy-bom has no license:
{
    "dependenciesWithoutAllowedLicenses": [
        {
            "moduleLicense": null,
            "moduleVersion": "4.0.1",
            "moduleName": "org.apache.groovy:groovy-bom"
        }
    ]
}

I'm assuming that groovy-bom is under Apache (as the rest of Groovy). I don't know if this is the "correct" way to add a license for :checkLicense.
I'm guessing https://github.com/apache/groovy/blob/master/gradle/licenses.gradle needs to be updated too?

This is a little strange. We don't have separate LICENSE files in general in each subproject since the main LICENSE file covers all subprojects. The LICENSE is embedded into the respective jars during assembly[1]. The BOM artifact has no jar, just a pom which contains among other things the following excerpt:
<licenses>
  <license>
    <name>The Apache Software License, Version 2.0</name>
    <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
    <distribution>repo</distribution>
  </license>
</licenses>

We'll need to examine what :checkLicense is expecting.
[1] https://github.com/apache/groovy/blob/master/build.gradle#L192

It looks like it would be safe (and in fact desirable) for you to set the :checkLicense excludeBoms property to true.
The relevant code is here:
https://github.com/jk1/Gradle-License-Report/blob/master/src/main/groovy/com/github/jk1/license/LicenseReportExtension.groovy#L97
So, if I understand correctly, it will not try to check boms if there is no jar artifact.

I'll close this based on my earlier comments. If you don't agree, let's discuss further.


Error when using ko.toJSON(viewModel)

Uncaught DOMException: Failed to read the 'selectionDirection' property from 'HTMLInputElement': The input element's type ('file') does not support selection.code: 11message: "Failed to read the 'selectionDirection' property from 'HTMLInputElement': The input element's type ('file') does not support selection."name: "InvalidStateError"stack: "Error: Failed to read the 'selectionDirection' property from 'HTMLInputElement': The input element's type ('file') does not support selection.↵    at Error (native)↵    at http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1904:60↵    at visitPropertiesOrArrayEntries (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1935:17)↵    at mapJsObjectGraph (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1903:9)↵    at http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1917:27↵    at visitPropertiesOrArrayEntries (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1935:17)↵    at mapJsObjectGraph (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1903:9)↵    at http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1917:27↵    at visitPropertiesOrArrayEntries (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1935:17)↵    at mapJsObjectGraph (http://localhost:1404/Scripts/knockout-3.2.0.debug.js:1903:9)"proto: DOMException knockout-3.2.0.debug.js:1904(anonymous function) knockout-3.2.0.debug.js:1904visitPropertiesOrArrayEntries knockout-3.2.0.debug.js:1935mapJsObjectGraph knockout-3.2.0.debug.js:1903(anonymous function) knockout-3.2.0.debug.js:1917visitPropertiesOrArrayEntries knockout-3.2.0.debug.js:1935mapJsObjectGraph knockout-3.2.0.debug.js:1903(anonymous function) knockout-3.2.0.debug.js:1917visitPropertiesOrArrayEntries knockout-3.2.0.debug.js:1935mapJsObjectGraph knockout-3.2.0.debug.js:1903ko.toJS knockout-3.2.0.debug.js:1879ko.toJSON knockout-3.2.0.debug.js:1888(anonymous function) VM659:2InjectedScript._evaluateOn VM562:732InjectedScript._evaluateAndWrap VM562:665InjectedScript.evaluate

It doesn't work for me. Still have the same error.

@michaleq91 can you please open another issue and explain what you encounter. I think you might have a different issue

No, it was my fault in the end. Works like a charm :)
Thank you for quick response


CoreDNS not starting - network not ready

I've been seeing an intermittent issue where the CoreDNS pods won't start and end up in a pending state until restarted. This happens early in setup. So far it seems to only happen on Hyper-V based deployments. Restarting the CoreDNS pods manually fixes the issue.
Currently after installing Calico we wait until all pods get to a "running" state. We should try to detect this and restart CoreDNS if necessary.

DONE

Reopening.  I'm seeing this on Azure.

FIXED now


Map CIM class 'Junction' to IEC 61850 SCL equivalent

As an engineer
I want to map the IEC CIM 'Junction' class to the IEC 61850 equivalent
So I can generate 61850 single line diagrams without manual editing
Background:
Mapping can be based on IEC/TS 62361-102

According to IEC/TS 62361-102; Junction is not supported by IEC61850. Therefore this issue can be closed.


small changes

remove log statement of access token for security reasons
closes #10

created a new branch with the subset

Oh, sorry I never got back to you. But yea these are definitely good changes. Thanks a ton! :D


.Net Framework and DbContext injection

I'm using a web api 2 (.Net Framework 4.6.1) solution and try to migrate from EF core 1.1 to EF Core 2.0.
Using Ninject, I inject my DbContext. There is a new DbContext each time the server is called.
With Ef Core 1.1, there is no problem, EF validates the db using onModelCreating only once.
With Ef Core 2.0, EF validates each time the db using onModelCreating. I'm trying to avoid that, but I'm not able to find answer.
Further technical details
EF Core version: 2.0
Database Provider:  Microsoft.EntityFrameworkCore.SqlServer
Operating system: Seven
IDE: Visual Studio 2017

@lanneshoa The expected behavior is going to depend on how types are registered in D.I. Can you post the code where you setup your container and register the DbContext?

Using NInject
``
public static class NinjectWebCommon
{
private static readonly Bootstrapper bootstrapper = new Bootstrapper();
    /// <summary>
    /// Starts the application
    /// </summary>
    public static void Start()
    {
        DynamicModuleUtility.RegisterModule(typeof(OnePerRequestHttpModule));
        DynamicModuleUtility.RegisterModule(typeof(NinjectHttpModule));
        bootstrapper.Initialize(CreateKernel);
    }

    /// <summary>
    /// Stops the application.
    /// </summary>
    public static void Stop()
    {
        bootstrapper.ShutDown();
    }

    /// <summary>
    /// Creates the kernel that will manage your application.
    /// </summary>
    /// <returns>The created kernel.</returns>
    private static IKernel CreateKernel()
    {
        var kernel = new StandardKernel();
        kernel.Bind<Func<IKernel>>().ToMethod(ctx => () => new Bootstrapper().Kernel);
        kernel.Bind<IHttpModule>().To<HttpApplicationInitializationHttpModule>();
        RegisterServices(kernel);
        GlobalConfiguration.Configuration.DependencyResolver = new NinjectDependencyResolver(kernel);
        return kernel;
    }

    /// <summary>
    /// Load your modules or register your services here!
    /// </summary>
    /// <param name="kernel">The kernel.</param>
    private static void RegisterServices(IKernel kernel)
    {
        kernel.Bind<ServiceFactory<CustomCommonContext>>().To<ManagerFactory>();
    }
}

``
Manager
public class ManagerFactory : ServiceFactory<CustomCommonContext>     {         public ManagerFactory()         {             this.Context = new CustomCommonContext();         }     }
ServiceFactory
``
public abstract class ServiceFactory : IServiceFactory
where DBContext : CustomCommonContext
{
public DBContext Context { get; protected set; }
         public CoachingNoteManager<ServiceFactory<DBContext>, DBContext> MyManager
    {
        get
        {
            return new MyManager<ServiceFactory<DBContext>, DBContext>(this);
        }
    }
}

``
MyManager
    public class MyManager<Service, Context> : BaseManager<Service, Context>         where Service : ServiceFactory<Context>         where Context : CustomCommonContext     {         public MyManager(Service serviceFactory)             : base(serviceFactory)         {         } }

@lanneshoa There doesn't seem to be anything specific to EF in the code you posted. Would it be possible to post a full project or code listing that reproduces what you are seeing?

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.


Assets.getSound breaks SAMPLE_DATA generated sounds on ios

Here is the code which describes situation. I'm using -Dlegacy.
var track = new Sound();
// if uncommented here it breaks playing generated sound
//var tmp = Assets.getSound("sounds/click.ogg");
track.addEventListener(SampleDataEvent.SAMPLE_DATA, handleSampleData);
trackChannel = track.play();
// if uncommented here works well
//var tmp = Assets.getSound("sounds/click.ogg");

Playing sound from some external source (native share popup which called by extension) also breaks generated sound playback.

https://trello.com/c/r4Vb7UmA/20-add-support-for-sample-data-generated-sound


Figure out what we want to do with updating otel dependencies

#407 updated the opentelemetry crate, but when we attempted this upgrade before for providers it means we have to update everything to match new structs and require a dep on protoc to build all the otel stuff. Previously, we've said this is a dependency we don't want provider authors to need to install. So we need to do two things to resolve this issue:

Decide how we want to handle the protoc dependency
Actually update all the tracing and otel crates to the latest version

In terms of CI, protoc is already installed, and I thought that the protobuf build library used internally vendors the binary for all common systems, doesn't it?

I was pulling up the link to the issue where it mentioned they were removing the vendored binary and it turns out the latest versions have removed the dependency on generating the files with protoc: https://github.com/open-telemetry/opentelemetry-rust/pull/881. So we should be able to update these as soon as we have spare cycles


[BUG] Decoding non-encoded base64 value

First of all: Great library!
I ran into a small issue when I tried to setup the server locally.
Per default @upstash/redis is using the Upstash-Encoding header and therefore expects the returned result value(s) to be already base64-encoded (and hence tries to decode them again)
Trying to decode a non-base64-encoded value obviously leads to an error in general.
A possible solution would be to encode the result if the Upstash-Encoding header is set. That way, testing manually via an HTTP client would still return human-readable values.

Hello,
Thanks for the kind words!

A possible solution would be to encode the result if the Upstash-Encoding header is set. That way, testing manually via an HTTP client would still return human-readable values.

That makes sense to me. I don't use the @upstash/redis javascript client, I wasn't aware of this Upstash-Encoding header support. Happy to help review and merge a PR that would add this feature!
Martin


fix broken link in docs

Description
I merged my own pr too quickly, not realizing there was a broken link
closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

merging since this only fixes a broken link in docs


Fix lumina-support.desktop file

usr/share/applications/lumina-support.desktop: error: key "Terminal" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"
usr/share/applications/lumina-support.desktop: error: key "StartupNotify" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"
usr/share/applications/lumina-support.desktop: error: key "Categories" is present in group "Desktop Entry", but the type is "Link" while this key is only valid for type "Application"

Ok, I can understand removing the Terminal/StartupNotify flags for a Link, but the "Categories" value is actually still necessary so the link shows up in the proper place in the application menu tree. This almost appears to be an oversight in the FreeDesktop Specification[1] (since "Link" entries are still not very common), and should probably be addressed upstream in the specs team.
Which utility was giving you these errors by the way? Lumina has it's own internal .desktop file parser, so these extra fields should not be causing any issues with Lumina. Also, the desktop entry has the "OnlyShowIn=Lumina" field set, so no other DE's should even pay attention to this file.
[1] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html

These errors reported by desktop-file-validate utility. My build system automatically checks the desktop files during building a package.
I can made a patch to accept Lumina as desktop and category, but this is not upstreamed.
About the categories: alternatively, you can use an applications-merged xdg menu, and desktop directory.

Ok, I just removed the Terminal/StartupNotify fields, but I left the Categories field in place for now.
Let me know if there is anything else I can do to help this get adopted upstream in the FreeDesktop specs.
https://github.com/pcbsd/lumina/commit/b288fd560129c6e2fab4c85643020559f2352f60

Thanks.
Another things: the icon paths are hardcoded in the desktop files. For example:
Icon=/usr/local/share/pixmaps/Lumina-DE.png
The extension not required [The image files must be one of the types: PNG, XPM, or SVG, and the extension must be ".png", ".xpm", or ".svg" (lower case).], and if I set PREFIX to /usr, the Lumina-DE.png will be installed in the /usr/share/pixmaps/ directory (which is a standard icon path).
https://specifications.freedesktop.org/icon-theme-spec/latest/ar01s03.html
So an Icon=Lumina-DE is enough.

Good catch!
Fixed!
https://github.com/pcbsd/lumina/commit/a3cc82c0d4513a800d126fa845cb8d7b503a875f

Thank you. More fixes about this: https://github.com/pcbsd/lumina/pull/204


Update PyHive to latest

We are currently using pyhive 0.6.3, which does not include the fix for handling HTTPS https://github.com/dropbox/PyHive/pull/385
We should update to 0.6.5 released a few months ago which has that in

Based on https://openmetadata.slack.com/archives/C02B6955S4S/p1662964399679129


AndroidX support

I wonder if you could migrate to AndroidX?

Hi @amorenew , Probably I will do this weekend. Would you mind doing it?

@anish-adm Hi check my pull request I added Android X


Vertical borders still appear with noBorder set

Hello,
I played with the example and changed it to the following:
        // layout-tree defintion
        m := model{tui: boxer.Boxer{}}
        rootNode := boxer.CreateNoBorderNode()
        rootNode.VerticalStacked = true
        rootNode.SizeFunc = func(_ boxer.Node, widthOrHeight int) []int {
                        return []int{
                                // since this node is vertical stacked return the height partioning since the width stays for all children fixed
                                widthOrHeight - 1,
                                1,
                                // make also sure that the amount of the returned ints match the amount of children:
                                // in this case two, but in more complex cases read the amount of the chilren from the len(boxer.Node.Children)
                        }
                }
        rootNode.Children = []boxer.Node{
                        {
                                Children: []boxer.Node{
                                        // make sure to encapsulate the models into a leaf with CreateLeaf:
                                        m.tui.CreateLeaf(leftAddr, left),
                                        m.tui.CreateLeaf(middleAddr, middle),
                                        m.tui.CreateLeaf(rightAddr, right),
                                },
                        },
                        m.tui.CreateLeaf(lowerAddr, lower),
                }
        m.tui.LayoutTree = rootNode

When rendering I see the following:
left        │middle     │right
            │           │
            │           │
            │           │
lower: use ctrl+c to quit

I would expect to not see the | bars due to the root being a NoBorderNode. Filing as an issue under the assumption that those bars should not be present.
Cheers!

Thanks for the Issue!
But this is by design. The RootNode is a NoBorderNode but the contained one is not a NoBorderNode, so it has borders again.
So you have to make all nodes NoBorderNode's when you don't want borders anywhere.
Cheers!


how to get the pose_frame in python

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
L500

Firmware Version
<IP_ADDRESS>

Operating System & Version
ubuntu 20

Kernel Version (Linux Only)

Platform
PC

SDK Version

Language
python/unity }

Segment
other

Issue Description
I want to Align the z coordinate with the real horizontal.so I need the imu data to tansform my pointcloud data.I referenced rs-pose.cpp.
my code
import pyrealsense2 as rs

p = rs.pipeline()
cfg = rs.config()

cfg.enable_stream(rs.stream.pose, rs.format.six_dof)
p.start(cfg)

while True:
    f = p.wait_for_frames()
    ff = f.first_or_default(rs.stream.pose)
    print(ff)

out put:
Traceback (most recent call last):
  File "/home/liux/Desktop/jumpwork/temp.py", line 7, in <module>
    p.start(cfg)
RuntimeError: Couldn't resolve requests

Process finished with exit code 1

rs-pose.cpp
// License: Apache 2.0. See LICENSE file in root directory.
// Copyright(c) 2019 Intel Corporation. All Rights Reserved.
#include <librealsense2/rs.hpp>
#include <iostream>
#include <iomanip>
#include "example-utils.hpp"

int main(int argc, char * argv[]) try
{
    std::string serial;
    if (!device_with_streams({ RS2_STREAM_POSE}, serial))
        return EXIT_SUCCESS;

    // Declare RealSense pipeline, encapsulating the actual device and sensors
    rs2::pipeline pipe;
    // Create a configuration for configuring the pipeline with a non default profile
    rs2::config cfg;
    if (!serial.empty())
        cfg.enable_device(serial);
    // Add pose stream
    cfg.enable_stream(RS2_STREAM_POSE, RS2_FORMAT_6DOF);
    // Start pipeline with chosen configuration
    pipe.start(cfg);

    // Main loop
    while (true)
    {
        // Wait for the next set of frames from the camera
        auto frames = pipe.wait_for_frames();
        // Get a frame from the pose stream
        auto f = frames.first_or_default(RS2_STREAM_POSE);
        // Cast the frame to pose_frame and get its data
        auto pose_data = f.as<rs2::pose_frame>().get_pose_data();

        // Print the x, y, z values of the translation, relative to initial position
        std::cout << "\r" << "Device Position: " << std::setprecision(3) << std::fixed << pose_data.translation.x << " " <<
            pose_data.translation.y << " " << pose_data.translation.z << " (meters)";
    }

    return EXIT_SUCCESS;
}
catch (const rs2::error & e)
{
    std::cerr << "RealSense error calling " << e.get_failed_function() << "(" << e.get_failed_args() << "):\n    " << e.what() << std::endl;
    return EXIT_FAILURE;
}
catch (const std::exception& e)
{
    std::cerr << e.what() << std::endl;
    return EXIT_FAILURE;
}

Hi @TitansWhale  The pose stream is only accessible on the RealSense T265 Tracking Camera model.  This is reflected in the RunTimeError: Couldn't resolve requests error message that you experienced, because pose is not a supported mode on L515 and 400 Series cameras.
As an alternative for establishing a relationship between the camera and the ground, a plane-fit algorithm may meet your needs, as described by a RealSense team member at https://github.com/IntelRealSense/librealsense/issues/6338#issuecomment-623350905

Hi @TitansWhale The pose stream is only accessible on the RealSense T265 Tracking Camera model. This is reflected in the RunTimeError: Couldn't resolve requests error message that you experienced, because pose is not a supported mode on L515 and 400 Series cameras.
As an alternative for establishing a relationship between the camera and the ground, a plane-fit algorithm may meet your needs, as described by a RealSense team member at #6338 (comment)

thanks


Docker agent stop and build forever pending

Version 0.5.
agent log:
panic: send on closed channel

goroutine 783 [running]:
panic(0x83cf80, 0xc8201a2ce0)
       	/usr/local/go/src/runtime/panic.go:481 +0x3e6
github.com/drone/drone-exec/build.(*Pipeline).step.func2(0xc82072a320)
       	/go/src/github.com/drone/drone-exec/build/pipeline.go:114 +0x62
created by github.com/drone/drone-exec/build.(*Pipeline).step
       	/go/src/github.com/drone/drone-exec/build/pipeline.go:115 +0x64

bug happens sporadically.

github.com/drone/drone-exec in the logs indicates this is 0.4 and not 0.5. we are not backporting fixes to 0.4 at this time

Or this means u are using an old agent prototype. Please ensure you use drone/drone agent and not drone/drone-agent.
Also per issue template let's use the gitter room to triage problems before creating github issues. Thanks!


a zpool is also a dataset

This template differentiates a zpool from a zfs dataset by the presence of "/" in the name, is this correct?
I happen to have some hosts where the zpool itself is the only dataset, like here:
# zpool list
NAME    SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
users   472G   147G   325G        -         -    13%    31%  1.00x    ONLINE  -
# zfs list
NAME    USED  AVAIL     REFER  MOUNTPOINT
users   147G   311G      147G  /users
#

Thus I'm missing useful statistics (e.g. compression ratio) about the dataset "users" because the template does not recognize "users" as a rightful dataset.
Is there a way to circumvent this other than create children datasets in the pool and move all data thereto (I would hate this)?

Interesting case, I never thought of that. This make a case to simply drop the regex and consider the first dataset like any other datasets.
This would also simplify the installation of the template, I think I'll just do that.

Interesting case, I never thought of that. This make a case to simply drop the regex and consider the first dataset like any other datasets.
This would also simplify the installation of the template, I think I'll just do that.

Interesting case, I never thought of that. This make a case to simply drop the regex and consider the first dataset like any other datasets.
This would also simplify the installation of the template, I think I'll just do that.

It will probably break the detection of zpools? Doesn't the detection of zpools also rely on this regex?

Interesting case, I never thought of that. This make a case to simply drop the regex and consider the first dataset like any other datasets.
This would also simplify the installation of the template, I think I'll just do that.

It will probably break the detection of zpools? Doesn't the detection of zpools also rely on this regex?

Nope, the zpool LLD is based on zpool list so that's completely unrelated, this will also solve #22 since the expression will no longer be necessary.

Nope, the zpool LLD is based on zpool list so that's completely unrelated, this will also solve #22 since the expression will no longer be necessary.

Nope, the zpool LLD is based on zpool list so that's completely unrelated, this will also solve #22 since the expression will no longer be necessary.

So, is it safe to remove those 2 filters from my production Zabbix system? And my top-level datasets like /users and /d01 will start being monitored?

Nope, the zpool LLD is based on zpool list so that's completely unrelated, this will also solve #22 since the expression will no longer be necessary.

So, is it safe to remove those 2 filters from my production Zabbix system? And my top-level datasets like /users and /d01 will start being monitored?

@victor-sudakov : import the latest version of the template first, then you can remove the global expression. You should see at the next discovery cycle your "base" dataset.

@victor-sudakov : import the latest version of the template first, then you can remove the global expression. You should see at the next discovery cycle your "base" dataset.

@victor-sudakov : import the latest version of the template first, then you can remove the global expression. You should see at the next discovery cycle your "base" dataset.

It works! Thanks.
Looking at git diff 12eecbf..ffc0105 though, I could have simply deleted the filters without updating the template.

@victor-sudakov : import the latest version of the template first, then you can remove the global expression. You should see at the next discovery cycle your "base" dataset.

It works! Thanks.
Looking at git diff 12eecbf..ffc0105 though, I could have simply deleted the filters without updating the template.


error loading docs.angularjs.org again

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (see above))

Current behavior:

Error loading docs.angularjs.org. This issue has existed before in several places, but the documentation website is having issues displaying properly.
Old issue: https://github.com/angular/angular.js/issues/12960
Expected / new behavior:

https://docs.angularjs.org/ Should display properly.
Minimal reproduction of the problem with instructions:

AngularJS version: 1.x.y

Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Anything else:

somebody already created a new issue for this a few hours ago.


Run other tasks in "task" function

It would be good to run other tasks in task definition, such as:
task("my_task", function(){
run_task("deploy:prepare");
run("something I want to do");
run_task("deploy:release");
run("another thing I want to do");
......
});

You can try:
task('task1', function(){
    run('something you want to do');
});
task('task2', function(){
    run('another thing I want to do');
});
task('my_task', [
    'deploy:prepare',
    'deploy:release',
]);
after('deploy:prepare', 'task1');
after('deploy:release', 'task2');

Good luck!


Detected

I pasted osiris, removed tons of features and vmprotected with virtualization+mutation, and I got overwatched on the 7th of june and vac'd on the 9th. Is osiris detected or is valve tricking us and masking overwatches as vac? (edit: injector used was randoinjector with asm emit bytes)

no, you are just blatant hacking. i ve been using it for 2 months... still no vac or ow ban, i am using vac bypass loader and xenos injector

and ya overwatch ban turns into vac ban in a fewday because of vacnet

vac bypass still works?

i guess it does...have to test it with detected cheat

Yea, I got banned too today. No notification about overwatch, just vac. I didn't use vac-bypass or anything like that so I think that's the case. My friend's account suprisingly hasn't got banned, but we used the same settings. I only used skinchanger.

yesterday i try to test this cheat, play blatant, after 4 match i got ow ban but on the next day it turn to vac ban

@Btibor12  you probably used a detected injector and he didnt
@aljawary ow bans turns into vac ban in a few minutes/hours/days. if it gives only vac either ur dll is detected or ur injector is

@infinity1211 We used the same injector (Process Hacker)

yesterday i try to test this cheat, play blatant, after 4 match i got ow ban but on the next day it turn to vac ban

OW ban turns into VAC most of the time

Really funny, 3 month later and see what happened, nobody believed me, even now, everyone deny it. Anyone who is interested should read these closed issues below.
It is really simple, stop using osiris till it get fixed.
I wasted over 5 accounts with osisris and got vac, my osiris clone was highly modificated.
I use my own injector over 15 years now, never got vac.
Im still using my injector over 3 month now. No vac, no ban, nothing. Just other dll, no osiris anymore ;)
#1246
#1238
#1251
#1268
#1306

Close this issue, hook is not detected.


Add expression usage in english

Add expression usage so user can understand scalar filtering better.
We add link from explore milvus to this page

Thank you, it's well received. It's a substantial piece of work, and will take us some time to review it.


Added Linear detrend function for data that has more than one dimension

Codecov Report

Merging #15 into master will decrease coverage by 0.05%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage    90.9%   90.85%   -0.06%
==========================================
  Files           1        1
  Lines         154      175      +21
  Branches       52       56       +4
==========================================
+ Hits          140      159      +19
- Misses          7        8       +1
- Partials        7        8       +1

Impacted Files
Coverage Δ

xrft/xrft.py
90.85% <92.3%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73dffbf...9bd2ba6. Read the comment docs.

This looks pretty good.
I'm just concerned that it might not play well with dask arrays.

Yea, you were write, scipy.signal.detrend doesn't keep the dask attribute

I think the detrend function works now for dask arrays but the output of dask.array.map_blocks returns a numpy array so if the data is detrended, the fft will be taken over an xarray.DataArray (for now).

Ok this is fine for now.
We will have to clean up and refactor this a bit at some point over the summer.


user registration error

Hi,
If I try to register a user on local secured couchdb instance with "userDBs" option. It fails with
[SyntaxError: Unexpected token u]
[SyntaxError: Unexpected token u]
SyntaxError: Unexpected token u
at Object.parse (native)
at /home/dixitne/work/nodetest/node_modules/superlogin/lib/dbauth/index.js:245:39
Here is my sample config
var config = {
dbServer: {
cloudant: false,
protocol: 'http://',
host: 'localhost:5984',
user: 'test1',
password: 'test1234',
userDB: 'sl-users',
couchAuthDB: '_users'
},
userDBs: {
defaultDBs: {
private: ['test']
}
}
}
I tried to debug and the problem is with the way it tries to send request to create the user on localDB which in turn is because of the way superagent.js client parses the url.
I was able to get this working for local env by changing the "getDBURL()" in util.js to not add username and password to the url instead use
.auth('couchdb_admin_username', 'couchdb_admin_password')
in "createDB()"
I hope this helps in fixing the problem
Thanks,
Neeraj

Hi @neerajdixit , thank you for reporting this. It could be that the username and password need to be URL encoded first if they are using any non-url characters. Go into /node_modules/superlogin/lib/util.js, line 50 and change it to:
url = db.protocol + encodeURIComponent(db.user) + ':' + encodeURIComponent(db.password) + '@' + db.host;

Let me know if this fixes the problem. Otherwise I will do it your way, but that involves more code.

But before you do that, go to /node_modules/superlogin/lib/dbauth/index.js, line 245 and change it to:
return BPromise.reject(err.text);

(remove JSON.parse) so we can know what the exact error is.

what you suggested works perfectly and yeah the JSON.parse was a problem to get exact error that I forgot to mention.
thanks..

OK, I will create a release with the fix.

The error was an illegal character in the URL?

Should be fixed in SuperLogin 0.4.2. Let me know if you have any further problems.

thanks. I did have some special characters in the password.


Create API for loading transports and interfaces as "middleware"

Right now, transports and interfaces are loaded in via config.json in a way that is not always 100% useful. By utilizing an Express-like API a la app.use(some_middleware), we can load in transports and interfaces in a safer fashion with a better way to customize for all use-cases.

lol

@eliperkins anxiously awaiting this api, when will it be released?


[Request] card-post-hiring

https://dribbble.com/shots/19800671-Freelance-Platform-Components

Can I reserve this?