ESLint と Prettier の競合を解消する

📝 関連issue / Related Issues

close #507

⛏ 変更内容 / Details of Changes

.eslintrc の "extends に "prettier/vue" を追加しました

ref. eslint-config-prettier の README

付随して yarn lint した結果が変化しています(以下 Before / After 参照)

Before
see detail
yarn run v1.17.3
$ eslint './**/*.{js,ts,vue}' --fix

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/ConfirmedCasesTable.vue
  178:5  warning  Prop "検査実施人数" is not in camelCase              vue/prop-name-casing
  178:5  warning  Prop "検査実施人数" should define at least its type  vue/require-prop-types
  179:5  warning  Prop "陽性物数" is not in camelCase                vue/prop-name-casing
  179:5  warning  Prop "陽性物数" should define at least its type    vue/require-prop-types
  180:5  warning  Prop "入院中" is not in camelCase                 vue/prop-name-casing
  180:5  warning  Prop "入院中" should define at least its type     vue/require-prop-types
  181:5  warning  Prop "軽症中等症" is not in camelCase               vue/prop-name-casing
  181:5  warning  Prop "軽症中等症" should define at least its type   vue/require-prop-types
  182:5  warning  Prop "重症" is not in camelCase                  vue/prop-name-casing
  182:5  warning  Prop "重症" should define at least its type      vue/require-prop-types
  183:5  warning  Prop "死亡" is not in camelCase                  vue/prop-name-casing
  183:5  warning  Prop "死亡" should define at least its type      vue/require-prop-types
  184:5  warning  Prop "退院" is not in camelCase                  vue/prop-name-casing
  184:5  warning  Prop "退院" should define at least its type      vue/require-prop-types

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/DesktopFlowSvg.vue
   14:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   19:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   23:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   40:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   44:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   65:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   70:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   76:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   82:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   90:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   95:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
   99:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  104:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  109:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  113:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  117:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  123:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  128:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  133:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  139:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  144:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  148:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  153:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  159:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  164:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  168:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  172:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  176:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  180:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  184:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  188:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  189:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  190:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  197:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  201:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  205:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  209:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  213:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  217:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  221:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  225:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent
  229:1  warning  Expected indentation of 8 spaces but found 10 spaces  vue/html-indent

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/NumberDisplay.vue
  44:11  warning  Prop "title" should define at least its type   vue/require-prop-types
  44:20  warning  Prop "number" should define at least its type  vue/require-prop-types
  44:30  warning  Prop "unit" should define at least its type    vue/require-prop-types

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/SideNavigation.vue
  74:71  warning  Expected no line breaks before closing bracket, but 1 line break found  vue/html-closing-bracket-newline

/Users/cheezenaan/src/github.com/cheezenaan/covid19/pages/about.vue
   92:1   warning  Expected indentation of 6 spaces but found 8 spaces                     vue/html-indent
   92:30  warning  Expected no line breaks before closing bracket, but 1 line break found  vue/html-closing-bracket-newline
  100:1   warning  Expected indentation of 6 spaces but found 8 spaces                     vue/html-indent
  100:25  warning  Expected no line breaks before closing bracket, but 1 line break found  vue/html-closing-bracket-newline

/Users/cheezenaan/src/github.com/cheezenaan/covid19/pages/flow.vue
  80:37  warning  Expected no line breaks before closing bracket, but 1 line break found  vue/html-closing-bracket-newline
  81:1   warning  Expected indentation of 12 spaces but found 14 spaces                   vue/html-indent
  81:75  warning  Expected no line breaks before closing bracket, but 1 line break found  vue/html-closing-bracket-newline

✖ 67 problems (0 errors, 67 warnings)
  0 errors and 50 warnings potentially fixable with the `--fix` option.

Done in 14.45s.

After
see detail
yarn run v1.17.3
$ eslint './**/*.{js,ts,vue}' --fix

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/ConfirmedCasesTable.vue
  178:5  warning  Prop "検査実施人数" is not in camelCase              vue/prop-name-casing
  178:5  warning  Prop "検査実施人数" should define at least its type  vue/require-prop-types
  179:5  warning  Prop "陽性物数" is not in camelCase                vue/prop-name-casing
  179:5  warning  Prop "陽性物数" should define at least its type    vue/require-prop-types
  180:5  warning  Prop "入院中" is not in camelCase                 vue/prop-name-casing
  180:5  warning  Prop "入院中" should define at least its type     vue/require-prop-types
  181:5  warning  Prop "軽症中等症" is not in camelCase               vue/prop-name-casing
  181:5  warning  Prop "軽症中等症" should define at least its type   vue/require-prop-types
  182:5  warning  Prop "重症" is not in camelCase                  vue/prop-name-casing
  182:5  warning  Prop "重症" should define at least its type      vue/require-prop-types
  183:5  warning  Prop "死亡" is not in camelCase                  vue/prop-name-casing
  183:5  warning  Prop "死亡" should define at least its type      vue/require-prop-types
  184:5  warning  Prop "退院" is not in camelCase                  vue/prop-name-casing
  184:5  warning  Prop "退院" should define at least its type      vue/require-prop-types

/Users/cheezenaan/src/github.com/cheezenaan/covid19/components/NumberDisplay.vue
  44:11  warning  Prop "title" should define at least its type   vue/require-prop-types
  44:20  warning  Prop "number" should define at least its type  vue/require-prop-types
  44:30  warning  Prop "unit" should define at least its type    vue/require-prop-types

✖ 17 problems (0 errors, 17 warnings)

Done in 4.24s.

📸 スクリーンショット / Screenshots

すみません。競合しているので調整いただけますか？

最新の development の内容で rebase しました。 @halsk
rebase した状態で #507 の内容が解消されていることを手元の環境で確認しています。


Design kit access request

Thanks for your interest in the IBM.com Design Adopter Kit!
We are in a closed adoption phase at the moment. Please answer the following questions to help us better understand your interest. Someone from Carbon for IBM.com will reach out to you soon regarding your request for access.

What is your email address?
<EMAIL_ADDRESS>

Which team are you on?
Systems.

What experience are you designing for?
Z Content Solutions

What platform is your experience on? (ie. Drupal, Wordpress, etc)
Not sure

Please list a point of contact for:
Offering manager
Design lead
Development lead: Danielle Atwood

Please share any additional information you'd like to share about your project?
I'm a UX designer helping out with the content solutions pages. We've been looking to redesign the Z content solutions for a while now and I just found out about the carbon for ibm.com. I'm hoping this would be a useful asset for the redesign
https://www.ibm.com/support/z-content-solutions/

Added to our box folder!


Is it planned to provide Debian packages?

Hello,
is it planned to provide Debian packages for this project?
At least I couldn't find any, while https://github.com/IdentityPython/pysaml2/ is part of Debian (https://packages.debian.org/buster/python3-pysaml2).

Debian packages are managed by Debian community.
I guess you may ask at Debian community about include this tooklit as well.


Fix hmrc contacts with no Location

https://govuk.zendesk.com/agent/tickets/1371252
The publishing-api previously had a bug which prevented contacts which have a base_path
from populating a corresponding Location record. This has now been updated so that
contacts and other formats can optionally specify a path and the relevant Location
object will be created. There are around 21 records without a Location object
which need updating.

Given that it is a small and unchanging set of items that need fixing, I would prefer the migration to just contain the ids for the items which need fixing, rather than the query to select them (as its then possible to see what the migration changed). But, I'm fine if you want to stick with the current implementation.

@cbaines a plus if it contained the ids is we could have a up and down implementation. Currently it'll perform same thing being rollbacked as migrated.


Camera and mic permissions on Android

Hi,
is there anything that should be done to use camera and mic inside InAppWebView on Android? I've granted both permissions and used androidOnPermissionRequest but it's still not working. Maybe there is something that should be done on the native side?

Follow this, answer by the author itself- https://stackoverflow.com/a/59084871/7857541


500 error on add evidence

Just tried submitting an evidence statement on public site got server error 500. :-(

Looks like the form auto-completion help was sending back some unexpected parameters - I pushed out a hotfix to handle them for now (and tried submitting this evidence item as a test) and it seems to be working as expected. When Josh is back I will talk to him about a more permanent fix!

I guess this error is back. Trying to get this new piece of evidence out.

This seems to have been fixed. The above evidence statement was successfully submitted, approved and is now live!


Fix imdb folder hierarchy

@yotamazriel  I think you've deleted the .tensorleap folder instead of renaming it to fix hierarchy.


Unable to install modules

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Unable to install any Powershell module. The error I get is "Install-Package: Package xxxx failed to download." When I run the command with -Verbose I see "The SSL connection could not be established, see inner exception."
Expected behavior
Powershell module should download and install

Actual behavior
4

Error details
Exception             :
    Type    : System.Exception
    Message : Package 'ExchangeOnlineManagement' failed to download.
    HResult : -2146233088
TargetObject          : /tmp/1053979679/ExchangeOnlineManagement.3.4.0/ExchangeOnlineManagement.3.4.0.nupkg
CategoryInfo          : ResourceUnavailable: (/tmp/1053979679/Exc…agement.3.4.0.nupkg:String) [Install-Package], Exception
FullyQualifiedErrorId : PackageFailedInstallOrDownload,Microsoft.PowerShell.PackageManagement.Cmdlets.InstallPackage
InvocationInfo        :
    MyCommand        : Install-Package
    ScriptLineNumber : 9711
    OffsetInLine     : 34
    HistoryId        : 2
    ScriptName       : /opt/microsoft/powershell/7/Modules/PowerShellGet/PSModule.psm1
    Line             : $installedPackages = PackageManagement\Install-Package @PSBoundParameters

    PositionMessage  : At /opt/microsoft/powershell/7/Modules/PowerShellGet/PSModule.psm1:9711 char:34
                       + … talledPackages = PackageManagement\Install-Package @PSBoundParameters
                       +                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    PSScriptRoot     : /opt/microsoft/powershell/7/Modules/PowerShellGet
    PSCommandPath    : /opt/microsoft/powershell/7/Modules/PowerShellGet/PSModule.psm1
    InvocationName   : PackageManagement\Install-Package
    CommandOrigin    : Internal
ScriptStackTrace      : at Install-Module<Process>, /opt/microsoft/powershell/7/Modules/PowerShellGet/PSModule.psm1: line 9711
                        at <ScriptBlock>, <No file>: line 1
PipelineIterationInfo :

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.9
PSEdition                      Core
GitCommitId                    7.3.9
OS                             Linux 3.10.0-1160.88.1.el7.x86_64 #1 SMP Sat Feb 18 13:27:00 UTC 2023
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Install-Package is part of OneGet and not PowerShellGet.  You need to use Install-Module (or Install-PSResource from PSResourceGet which replaces PowerShellGet).


feat: author entity props blocking

Ticket
https://github.com/VirtusLab-Open-Source/strapi-plugin-comments/issues/183
Summary
What does this PR do/solve?

removing selected fields from author object in the response by config
minor UI issue

Test Plan

set blockedAuthorProps in config
query for comments
blocked props should be blocked

Codecov Report

Merging #186 (3c41b33) into develop (890d348) will increase coverage by 0.04%.
The diff coverage is 86.95%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
+ Coverage    79.36%   79.41%   +0.04%
===========================================
  Files           34       34
  Lines          882      889       +7
  Branches       292      292
===========================================
+ Hits           700      706       +6
  Misses         179      179
- Partials         3        4       +1

Flag
Coverage Δ

unittest
79.41% <86.95%> (+0.04%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/utils/constants.ts
100.00% <ø> (ø)

server/services/utils/functions.ts
82.27% <66.66%> (+0.22%)
:arrow_up:

server/services/common.ts
79.42% <77.77%> (-0.23%)
:arrow_down:

server/services/admin.ts
76.59% <100.00%> (ø)

server/services/client.ts
85.81% <100.00%> (+0.29%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I tried pulling the PR locally and building it into my website. I added blockedAuthorProps: ['email'], to my plugins.js file, but I can still see the email field on the front end.
When debugging the code, I see it isn't finding the blockedAuthorProps key in my config. It looks like it's only finding the config values I have set inside my admin panel and skipping the local config. This seems to be happening because the useLocal parameter defaults to false here: https://github.com/VirtusLab-Open-Source/strapi-plugin-comments/blob/master/server/services/common.ts#L61. When I override this value to true I am able to get the functionality I expect, the email field is not returned.

@cyp3rius I did use the restore feature after setting the new config field. Is this new field integrated with that restore functionality properly? It didn't seem to do anything for me. If I get time later I'll try to run a restore through the debugger to confirm.

I added a new input for the settings page. From now on you don't need to put settings in the file.

I pulled in the latest updates and everything is working great! I was able to use the reset button from the admin panel and it reset the blocked props field to the value from my plugins config. Calling the comments plugin API from my frontend did not return the email field.


[subset CFF] Fix de-subroutinizing bug when subroutines contain hints

Fixes issue 1493
The  code was skipping executing a subroutine if it had already been desubroutinized. The initial set of vstemhm and hstemhm operators and values may be in a subroutine. If a charstring is being executed which calls such subroutines, they still need to be executed in order to count the number of hint values seen, so that the byte length of the hintmask can be calculated.
I fixed this bug by executing subroutines even if they have already been desubroutinized, as long  as  (we don't know yet if we are doing hintmasks) or ( we do need a hintmask, but have not yet seen it).

when calling the subsetter with --desubroutinize as well as with --no-hinting, we still get AttributeError for GlobalSubrs inside remove_unused_subroutines method, which is called at the end of remove_hinting method. This is because the desubroutinize method deletes the attribute on the FontDict.
This patch fixes this. Do you mind applying this and also add a little test case for using the two options in combination?
diff --git a/Lib/fontTools/subset/cff.py b/Lib/fontTools/subset/cff.py
index ee6048a0..9dc099b8 100644
--- a/Lib/fontTools/subset/cff.py
+++ b/Lib/fontTools/subset/cff.py
@@ -486,9 +486,7 @@ def desubroutinize(self):
                        decompiler.execute(c)
                        c.program = c._desubroutinized
                        del c._desubroutinized
-               # Delete All the Subrs!!!
-               if font.GlobalSubrs:
-                       del font.GlobalSubrs
+               # Delete all the local subrs
                if hasattr(font, 'FDArray'):
                        for fd in font.FDArray:
                                pd = fd.Private
@@ -502,6 +500,7 @@ def desubroutinize(self):
                                del pd.Subrs
                        if 'Subrs' in pd.rawDict:
                                del pd.rawDict['Subrs']
+       # as well as the global subrs
        cff.GlobalSubrs.clear()

Note that it is not necessary to call del font.GlobalSubrs to delete the global subroutines, since the attribute is shared by all the font dicts in the CFFFontSet and we call clear() at the end of desubroutinize to set it empty.


DOC: update Anaconda install instructions

The motivation for making this change (or link the relevant issues)

I use Anaconda on Windows, and I just tried to install manim, leaving open the possibility of hacking the source. The Anaconda installation instructions seemed a little out of date (maybe environment.yml has been updated since they were written?) so I thought I'd update them according to the procedure I needed to follow. I'll explain each change in a self-review.

How you tested the new behavior (e.g. a minimal working example, before/after
screenshots, gifs, commands, etc.)

Only by installing manim on my computer and confirming that the example runs.
Feel free to close if the instructions are fine as they are. I won't be hurt : )

OK, I'll go ahead and close : )


add status bar prop

Summary

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Could you please update the description comment for the PR a bit?

@s-sushkevich Could you resolve conflicts and also update based on @trcoffman's requests?

Any updates on this? There are multiple open issues / requests regarding this problem.
See here #1219, here #1059, here #914 and here #735

@jamonholmgren @Titozzz any updates on this?
as far as I can see, this is the same as #914 - unfortunately none of these are merged yet 😢

autoManageStatusBarEnabled should de disabled by default


Failed: Update autorest version to prerelease 3.0.0-alpha.20240509.2

Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/4665

API change check
API changes are not detected in this pull request.


Travis build out of tree

Coverage remained the same at 96.127% when pulling 5de61cfcb6ebc881046a61843fe9269e2e812768 on zanebeckwith:travis-build-out-of-tree into b4bd4375ebfa0d8880897aac500eb2d3a4a447ce on xaptum:master.


DrmEngine#fillInDrmInfoDefaults_ error logging is misleading

This is very minor but has come up recently in our work on Tizen.
Tizen supports both Widevine and PlayReady, and Shaka's behaviour is to pick the first supported keySystem based on the order of the ContentProtection blocks in the manifest (if I recall correctly). However, we have a business rule which says "Tizen shall use PlayReady", so in order to force this, we only configure a license server for com.microsoft.playready. This will cause Shaka to log an error, since there is a DrmInfo for Widevine, but no license server configured:
shaka.log.error('No license server configured for ' + keySystem);

I think this logging is misleading since it's not an error. At most it could be a warning but even that seems like a stretch, since this seems like an ordinary use case to me. I imagine that clients would never want to leave the selection of keySystem to chance. They want to know definitively what DRM they're using. (We encountered this problem on Tizen because the order of the ContentProtection blocks is different for our cloud DVR content than the rest of our content.)
I can submit a PR for this but I'd like to know if you think it could be changed to a warning, or removed altogether, or if you disagree with this assessment.

This sounds reasonable to me. An info log, maybe with an additional warning if the variant has DrmInfos but every single one of them ends up with no licenseServerUri. What's your opinion, @joeyparrish?

an additional warning if the variant has DrmInfos but every single one of them ends up with no licenseServerUri

This sounds like an actual error scenario to me, though I'm not sure if Shaka should fail with an assertion or publish a shaka.util.Error.
But perhaps there are some edge cases where clients know that some content will have ContentProtection blocks in the manifest, but the content itself is clear, so they don't provide license urls?

We already throw an error if we don't have a license server URL for the chosen key system, so maybe the log isn't needed.  We also need to change our code so on multi-DRM platforms we pick the one with a license server given.  I think we will still choose the first and error out if we don't have a license server for it.

I believe we try the key systems with license servers before the others.  If no license-server-configured key systems work, we only try the others so we can give a more useful error message (no license server vs unsupported config).  This is from memory, though.  I could be wrong.
I think misleading error messages should be removed.  If there is a usable key system with a configured license server, there is no reason for a "no license server" error message to appear.

Cherry-picked for v2.3.3.


Preview Editor without localisation

In http://preview.ideditor.com/master/ i want to see the latest transifex translations, but i cannot switch to German. Yesterday that was - on another computer - automatically. Please help.

My mistake, did configure languages in the browser, sorry


Update AnimationNodeTransition to have the correct enabled inputs in the blend tree automatically after tweaking in the inspector

Update AnimationNodeTransition to have the correct enabled inputs in the blend tree automatically after tweaking in the inspector

Does this close an already-reported issue on this tracker? If so, please edit your first post to add "This closes #xxxx" :slightly_smiling_face:

Not sure, something I noticed when using the editor myself. I will double check.

Can't see an issue for it logged at the moment

@Huxellberger Is this still desired? If so, it needs to be rebased on the latest master branch.


all: Reorganize backend

Remove incrementer
status: Merge status/handlers into status
Rename status to gpustats
Rename status.GPUStatusPacket to uplink.GPUStats
groundstation: Move most of implementation to internal/groundstation.

I've not moved database or config yet, to not disrupt #37, but they can be done later.

Right okay, so let me check my understanding of what's going on here:

We have a cmd folder that contains folders for each binary we're producing - they only contain the main.go file required for building.
Every other module is in internal (because we don't produce libraries) and is either a sub-module of satellite/groundstation when the behaviour is specific to that binary or just a sub-module of internal when behaviour is shared between them

If so, that looks good to me. I'll rebase #37 and move the database module to internal/groundstation/database

Almost:
Go doesn't have a concept of "sub-module"s or sub-packages. IE theirs no relationship between internal/groundstation and internal/groundstation/database, other than having similar paths. Also the name of the packages would be groundstation and database.  (This is why in std, it's "net/http/httptest", not "net/http/test".
Therefor, I'm aiming for a much flatter package layout. IE the DB should live in internal/database. (Also, it'd also be used by webapi, so it's not groundstation specific). This also means theirs little point in having internal/database/postgres imo.
See https://go.dev/doc/modules/layout#server-project for the layout we're going for.
(aside: your using module where you mean package. Everything in this repo is in one module, but it's split into packages. Modules are used for versioning, but packages are used for visibility, coherency and separate compilation. See https://go.dev/ref/mod#modules-overview for details).


Primary network (to communicate with minions and to master itself) is not available until Vagrant creates it

At the moment, if minions are provisioned using Vagrant, the (virtual) network is not available until vagrant up is used.
Many states which require communication to Salt master via this generic (virtual) network fail.
It also constitutes (partial) "chicken and egg" problem:

In order to connect over this network, highstate has to be run (to get Vagrantfile configured to run vagrant up for minions).
In order to complete highstate successfully, network should be already created (via Vagrant).

The solution could be creation of special virtual network outside of Vagrant (using virsh via libvirt) as part of the orchestrate states. Then Vagrant-provisioned hosts may be configured to join this network.

Ideally, the network prerequisite should be handled by configure_salt.py script.

If the script is executed on Salt master and network is marked as virtual, the script can create network.
If the script is executed on Salt master and network is not marked as virtual, network test can be performed (calling the same test functions which are executed at bootstrap process).
If the script is executed on Salt minion (regardless of the network type) it should only test the existence of the network (similar to non-virtual network case for Salt master). The reason for such behaviour is that primary network (if virtual) can only be created by single host (Salt master).

As a quick manual way to fix the problem, commit c49b510e5cd258ea4138f0042f5b13b70a5f47ad adds create_primary_network.py script to create primary_network based on path to properties.yaml file. This can make life easier now, but does not provide solution to close this task.


cmd/go: Windows: "go get ..." doesn't work: "The system cannot find the file specified."

What version of Go are you using (go version)?
go version go1.9 windows/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Go
set GORACE=
set GOROOT=C:\bin\go
set GOTOOLDIR=C:\bin\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?
I want to get "x/net/websocket" into my project via:
go get golang.org/x/net/websocket
What did you expect to see?
I expected no errors.
What did you see instead?
go get golang.org/x/net/websocket
# cd C:\Go\src\golang.org\x\net; git submodule update --init --recursive
package golang.org/x/net/websocket: chdir C:\Go\src\golang.org\x\net: The system cannot find the file specified.

Please show us the complete output of  go get -x golang.org/x/net/websocket.


Ignored return value of token.mint in Crowdsale contract

[x] 🐛 This is a bug report.
[ ] 📈 This is a feature request.

Function mint from MintableToken returns a boolean value, similar to transfer. However, its return value is not checked when the token is used in the Crowdsale contract.
Instead of:
token.mint(beneficiary, tokens);

Should be:
require(token.mint(beneficiary, tokens));

On the other hand, the implementation of mint does not return false, and instead should revert if it fails.
Discuss whether we want to remove the return value from mint, or we want to check it whenever we invoke the method.

This has now moved to the MintedCrowdsale under the crowdsale refactor #744.
I'm not fixing this quite yet in hope for more input regarding the mint return value.. Any reason for keeping it? (See also finishMinting in MintableToken).

The main reason for keeping it would be consistency with the transfer method (you can consider mint as a transfer from address zero, which is reflected in the Transfer event emitted). My vote would be to keep the boolean, and check the return value in the crowdsale.

Understood, pushed fix for this in the crowdsale refactor #744.


fix: Add seed support in MySQL

Ref #541.
New capability of "seeding" a db container using image's support for /docker-entrypoint-initdb.d/ folder.

Updated to use "transferable" like kafka does, which makes this support remote docker engines!


PYTHON backend does not handle overflow half

more problematic than just PYTHON because Tensor(list) is handled by PYTHON now (instead of numpy), for example this fails
python -c "from tinygrad import Tensor, dtypes; print(Tensor([80000.0], dtype=dtypes.float16).numpy())"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/chenyu/code/tinygrad/tinygrad/tensor.py", line 121, in __init__
    else: data = _frompy(data, dtype)
                 ^^^^^^^^^^^^^^^^^^^^
  File "/Users/chenyu/code/tinygrad/tinygrad/tensor.py", line 54, in _frompy
    data =<EMAIL_ADDRESS>*fully_flatten(x))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OverflowError: float too large to pack with e format

could not find a built-in method to convert this, might need to manually manipulates the bits (would need this for bfloat16 anyway)

how cpython packs float https://github.com/python/cpython/blob/ac37a806018cc40fafebcd0fa90250c3e0261e0c/Objects/floatobject.c#L2048

fixed by #5022. catch the struct.pack OverflowError for now


No warning when default.physics_config.json is missing

Habitat-Sim version
master
🐛 Bug

Steps to Reproduce
Steps to reproduce the behavior:

conda install habitat-sim withbullet headless -c conda-forge -c aihabitat-nightly
python -m habitat_sim.utils.datasets_download --uids ci_test_assets --data-path data
Run the following

import habitat_sim

def test_physics_config_file(physics_config_file):
    sim_cfg = habitat_sim.SimulatorConfiguration()
    sim_cfg.enable_physics = True
    if physics_config_file:
        sim_cfg.physics_config_file = physics_config_file
    agent_cfg = habitat_sim.AgentConfiguration()
    camera_sensor_spec = habitat_sim.CameraSensorSpec()
    camera_sensor_spec.uuid = 'rgb'
    camera_sensor_spec.sensor_type = habitat_sim.SensorType.COLOR
    camera_sensor_spec.resolution = [480, 640]
    camera_sensor_spec.position = [1.5, 0.5, 0.0]
    camera_sensor_spec.orientation = [-0.1, 1.57, 0.0]

    agent_cfg.sensor_specifications = [camera_sensor_spec]
    hab_cfg = habitat_sim.Configuration(sim_cfg, [agent_cfg])
    with habitat_sim.Simulator(hab_cfg) as sim:
        art_obj_mgr = sim.get_articulated_object_manager()
        urdf_path = "data/robots/hab_fetch/robots/hab_fetch.urdf"
        robot = art_obj_mgr.add_articulated_object_from_urdf(urdf_path, fixed_base=True)

test_physics_config_file('wrong/path/to/physics_config_file')

Expected behavior

addArticulatedObjectFromURDF not implemented in base PhysicsManager.
E0720 17:37:50.838002  3802 ManagedContainerBase.h:203] ::getObjectHandleByID : Unknown ArticulatedObject managed object ID:-1. Aborting
E0720 17:37:50.838011  3802 ManagedContainerBase.h:331] <ArticulatedObject>::getObjectCopyByID : Unknown ArticulatedObject managed object handle :. Abortin

It seems that the physic backend is not set correctly due to the missing config file.
Two suggestions to improve:

Some warnings should be raised to inform the users of the missing config file, otherwise it is quite subtle.
How to download default physics_config_file can be highlighted somewhere, or automatically downloading it should be enabled.

Additional context

System Info
Please copy and paste the output from the
environment collection script
(or fill out the checklist below manually).
You can run the script with:
# For security purposes, please check the contents of collect_env.py before running it.
python habitat_sim/utils/collect_env.py

OS (e.g., Linux): Linux-5.4.0-77-generic-x86_64-with-debian-buster-sid
How you installed PyTorch (conda, pip, source): pip
Build command you used (if compiling from source):
Python version: 3.6
GPU models and configuration: 1080Ti
CUDA version: 11.2
PIP/conda dependencies packages versions
Any other relevant information:

CC: @jturner65

Note that the default behavior with a missing config is improved by #1409.
We should still add a better warning for users expecting to have their own file picked up.


Max data rate?

Is there a maximum rate (Hz) that the values can be read at?

I am not low-power mode yet seem to only be able to achieve approximately 370Hz.


Pod not fetching all files.

Did you managed to solve this problem?

I think pod is not downloading all files. I dont have KeyboardSettings class. Xcode says Use of unresolved identifier 'KeyboardSettings'

i check pod for swift downloads version 0.0.4. I added version 0.1.2 terminal says version not found. Please check podspec file

This can be fix by typing
pod 'ISEmojiView','~> 0.1'
in podfile for swift


Resolve sonatype issues

commons-io upgraded
netty-all upgraded
log4j upgraded to log4j2
Also, would not build due to node-sass 4.12.0 no longer found at location.  Upgraded to 4.14.1 to resolve the build issue.

This is quite a major dependency reshuffle so please could you share the specific issues Sonatype is raising and how these changes resolve them?


Better YAML support

We should provide support for YAML that's as good as that of JSON:

Retrieving YAML as JSON
Querying YAML
Including YAML from YAML

.. so that we can say 'Central Dogma has first-class support for JSON and YAML.'

It seems like there is already a PR #616 but it is very old. I wonder if there is any initiative at the moment for this?


Correct typos

I noticed (and corrected) this typo

as well as a few spelling typos.

Thanks so much for this and sorry for the slow reply!


snap to zero crossing does not work on rightmost non-MAUS generated Segment levels

Cf. #265.
This appears to be because there isn't a rightmost boundary to snap to anything.
Consider:

Note that on the first (PHO) level (which was generated by MAUS) the duration of the final segment (labeled <p:>) is indicated in the lower right-hand corner. For the ORL level, there is no such information. And there is no black boundary descending from the top of the right edge of the final segment of the ORL level (labelled o, here).
In this way, it makes sense that x doesn't work on this boundary, because it's not really a boundary. But why not? This is what happens when you create segment on a Segment level by selecting a region of a file and hitting ENTER: you get a left boundary, but not a right one. Yet MAUS-generated Levels display the 'expected' behavior.
I did have a cursory look through the *annot.json files but couldn't see anything obviously different in the JSON of the two levels.

"But why not?"


hwinfo: 21.23 -> 21.38

Motivation for this change
Update
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Hello,
I tried to build that and run the binaries produced. hwinfo works fine :

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/hwinfo --version
21.38

But two other commands gives unexpected results :

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/mk_isdnhwdb
Cannot open /usr/share/hwinfo/ISDN.CDB.txt as stdin
The path /usr/share does not exist under NixOS.

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/convert_hd
Can't locate XML/Writer.pm in @INC (you may need to install the XML::Writer module) (@INC contains: /home/demo/.nix-profile/lib/perl5/site_perl /nix/var/nix/profiles/default/lib/perl5/site_perl /run/current-system/sw/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /run/current-system/sw/lib/perl5/site_perl/5.22.2 /run/current-system/sw/lib/perl5/site_perl /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2 /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2 .) at ./result/bin/convert_hd line 4.
BEGIN failed--compilation aborted at ./result/bin/convert_hd line 4.
A Perl module is missing.

The two other commands, did they work before? (If this PR does not cause regressions, we merge it even if some things are broken.)

I don't think the other commands ever worked. I wasn't aware they existed nor what their use is (can't find them in man). I can check them out tonight.

Those two commands never worked indeed. I did not mean to imply it was a regression of this PR. :)
Just wanted to point that out so we know there is room for improvement in a future PR on this package.

]$ nix-env -iA nixos.hwinfo
[demo@nixos:~/testbuilds]$ hwinfo --version
21.23
]$ mk_isdnhwdb
Cannot open /usr/share/hwinfo/ISDN.CDB.txt as stdin
]$ convert_hd
Can't locate XML/Writer.pm in @INC (you may need to install the XML::Writer module) (@INC contains: /home/demo/.nix-profile/lib/perl5/site_perl /nix/var/nix/profiles/default/lib/perl5/site_perl /run/current-system/sw/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /run/current-system/sw/lib/perl5/site_perl/5.22.2 /run/current-system/sw/lib/perl5/site_perl /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2 /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2 .) at /home/demo/.nix-profile/bin/convert_hd line 4.
BEGIN failed--compilation aborted at /home/demo/.nix-profile/bin/convert_hd line 4.

Thanks! Pushed to master (d12030d17589bc19686d300748362b82c41950b4) and release-17.03 (d60e77f1c8b8546efb5607fba3d170198312b88c).


Sentry\Monolog\Handler: Support logging of $context

The monolog handler doesn't save $context parameter and seems there's no way to customize that:

https://github.com/getsentry/sentry-php/blob/ecbd09ea5d053a202cf773cb24ab28af820831bd/src/Monolog/Handler.php#L40-L62

             $scope->setExtra('monolog.context', $record['context']);

this would send everything

Thank you for the contribution. I already started the work in #1244, and although it has been abandoned for some time I intend to get back to it in the new year. Therefore, I'm closing this PR as duplicate

This has been fixed in #1244 and will be released with the next minor version


tree gives different names for same ref

I'm a bit baffled by this, for rebar3 tree shows different version strings for the same ref, this is a bit confusing. In the example below both refs (git refs) are a62b0cc but the version is vastly different. It looks like one counts the build from tag 2.1.1 the other from tag 2.1.0
-├─ riak_ensemble─2.1.1+build.26.refa62b0cc
+├─ riak_ensemble─2.1.0+build.159.refa62b0cc

possibly related: https://github.com/rebar/rebar3/pull/825 and formerly https://github.com/rebar/rebar3/pull/811

Yea... need more info on this. Did you run the same rebar3 version and get different results or are you just noticing the change in rebar3's git versioning code?

it disappeared somewhere during recent updates - no complains about that ;) I'll reopen if I come across over it and find something to reproduce otherwise I'm happy calling it a freak accident.


Rails.root vs Dir.pwd

allows running teaspoon via rails daemon

Haha, that's because I didn't fully understand private at the time -- lessons learned over the years. =)
Ok, so hey, that broke all the builds, so do you want to look into it further? It can't be merged in the current state, but I don't disagree with this directly.
Can you give me some background on why you want this change, and what it's intended to directly resolve?

If you run rails ad a daemon (rails s -d), taspoon doesn't run due to pathing issues.  I believe things like pow and other similar tools run rack applications as daemons, so it might be a nice ability. This was quick attempt at resolving that that I made quite awhile ago so i am a bit fuzzy on the details, but if it something you would be interested in merging as a feature, i can look into writing some tests and getting the build to finish successfully... One issue though is I am planning a trip out of town for 6 weeks soon, so it may not be something i can look into right away :/
Let me know what you think!

That's fair, and I appreciate your explanation. Have you tried running teaspoon with a specified port via the CLI? This won't start a server internally and will look at the specified port to see if there's already a server running there (at least that's how the code reads in server.rb) -- try it and see if that works?

Jeremy Jackson
303-507-6846

On Mar 14, 2016, at 7:40 PM, Brewster<EMAIL_ADDRESS>wrote:
If you run rails ad a daemon (rails s -d), taspoon doesn't run due to pathing issues. I believe things like pow and other similar tools run rack applications as daemons, so it might be a nice ability. This was quick attempt at resolving that that I made quite awhile ago so i am a bit fuzzy on the details, but if it something you would be interested in merging as a feature, i can look into writing some tests and getting the build to finish successfully... One issue though is I am planning a trip out of town for 6 weeks soon, so it may not be something i can look into right away :/
Let me know what you think!
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/modeset/teaspoon/pull/465#issuecomment-196601482

well it's not so much a port issue as it is with background processes. they don't have the same CWD context that you have running it from an explicit directory. using Rails.root keeps everything self contained.
did you look into the failing tests at all? it may just be a single point of failure.


LSP signatureHelp result is null

Description
Hi again,
I'm debugging my Nova integration signatureHelp request of the ruby-lsp and would need your insight. I'm using code from your test file locally as my localtest.rb file.:
class Foo
  def bar(a, b)
  end

  def baz
    bar#<-- cursor here, entering '('
  end
end

the file seems to be indexed correctly (I get valid hover responses) but see the following request/response exchange from Nova with the LSP log for signatureHelp:
Ruby Language Server[11:16:17.839000] Sending JSON-RPC request: number(178) textDocument/signatureHelp
{
  "params" : {
	"position" : {
	  "line" : 5,
	  "character" : 6
	},
	"textDocument" : {
	  "uri" : "file:\/\/\/Users\/olifink\/Courses\/pickaxe\/localtest.rb"
	},
	"context" : {
	  "isRetrigger" : false,
	  "triggerCharacter" : "(",
	  "triggerKind" : 2
	}
  },
  "jsonrpc" : "2.0",
  "method" : "textDocument\/signatureHelp",
  "id" : 178
}

Ruby Language Server[11:16:17.850000] Received JSON-RPC response: number(178) textDocument/signatureHelp
{
  "jsonrpc" : "2.0",
  "id" : 178,
  "result" : null
}

the request doesn't seem incorrect and is not very different from the one in your test case, I'm wondering why I get a null result in the response?

Closing this for now as it does not seem to be a bug with the Ruby LSP.


Stopped during Audioset training

Hi, Thanks for your good study.
I tried to trianing Audioset using your code.
After epoch 2 10%, Training is not working.
Not shutdown just not working.
Can I know why it was happened?
I attached log monitor.

Hi,
I remembered that there was a case when training in the multi-gpu mode (ddp mode), the model will stuck in the saving checkpoint step, you can check the test_epoch_end and validate_epoch_end in the file sed_model.py (SED wrapper class).
It is a strange problem of pytorch lightening. I once met this problem when the model tries to save a model checkpoint that exceeds the max number of the checkpoints. For example, the code wants to save the 11th model, which beats one of the saved top-10 checkpoints, and it has some problems when replacing the ckpt. You can try to change the number of top-k in the pl.trainer in the main.py to see if the stuck point/step changes (I guess it will also change)
If so, I give my suggestions:
(1) You can revise my code test_epoch_end/validate_epoch_end to be trained in a single-card (just add a branch if device_num == 1 and directly compute the metric without using the dist.all_gather. And you can see if this problem happens again or not.
(2) You can try to install the torch (1.7.0), or changing the naming of the saving model to see if happens again. I remembered I fixed this bug using dist.barrier, but I'm not sure if it works in other slightly different environments.


Submariner Repos OWNER Request

name: Submariner Owner Request
about: Request Owner rights on all Submariner repos
title: 'REQUEST: New Owner rights for vthapar'
labels: committer-request
assignees: ''

GitHub Username
@vthapar
Code you are requesting Owner rights for
shipyard/*
cloud-prepare/*
admiral/*
submariner/*
lighthouse/*
submariner-operator/*
subctl/*
submariner-website/*
releases/*
submariner-charts/*
Requirements

[x] I have reviewed the contributor roles guidelines (https://submariner.io/community/contributor-roles/)
[x] I have enabled 2FA on my GitHub account (https://github.com/settings/security)
[x] I have subscribed to the submariner-dev e-mail list (https://groups.google.com/forum/#!forum/submariner-dev)
[x] I have been actively contributing to Submariner for at least 3 months
[x] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

@skitt
@tpantelis

List of required reviews to Submariner project PRs

At least 20 PRs to the relevant codebase that you reviewed, and at least 5 for which you were the primary reviewer

https://github.com/submariner-io/lighthouse/pulls?q=is%3Apr+reviewed-by%3Avthapar+-author%3Avthapar
https://github.com/submariner-io/submariner-operator/pulls?q=is%3Apr+reviewed-by%3Avthapar+-author%3Avthapar

+1

What's the next step?

+1


Expose Message::Field Unparsed Value

I know this is not mandrill_dm fault mail gem doesn't expose public api to retrieve origin message field value, particularly merge vars. But my colleagues constantly argues on instance_variable_get(:@value) in specs to verify mail message correctness. So I propose to extend Mail::Field with required attribute reader.
Improvements

Add appraisal gem to test against different dependency versions

Related PRs & Issues

https://github.com/mikel/mail/issues/1195
https://github.com/mikel/mail/pull/1196

https://github.com/mikel/mail/commit/7c22a8e9b5682d835f33a2f4e54bee409b944516
Exposed API was merged. I'll update the PR as soon as mail 2.8.0 is released at rubygems.
@kshnurov, would you like to have appraisal anyway in this gem?

@Tensho sure, why not.

mail 2.7.1 was released yesterday. Updated the branch with commits squash.
@kshnurov, @spovich Please let me know if I can do something else here 🙇

@kshnurov Fixed

@kshnurov Addressed all your concerns I think. Let me know if there's anything else you can think of 🙇

@kshnurov Fixed. I'm eager to squash commits before the merge.

@Tensho thanks!

@Tensho sure.
@spovich I've made a 1.3.6 release, could you please push it to Rubygems or give me access?

@kshnurov Please could you tag the release commit either (if you have access)?

@kshnurov done

👍  Just small note, I think it's reasonable to put the tag exactly on Release 1.3.6 or Bump to 1.3.6 commits. Anyway, thank you 🙇


Callback functions don't have the expected indentation

From @battmanz on January 24, 2017 19:14

In TypeScript (maybe other languages too), callback functions don't have the expected indentation when placed on a new line. Such is the case when using the subscribe method on an Observable in rxjs.

VSCode Version: 1.8.1
OS Version: macOS Sierra

Steps to Reproduce:

The following file was formatted using the keyboard shortcut. Notice how the onNext and onError callbacks line up with the subscribe method.

I would rather see those two callbacks indented one more level like so:

Copied from original issue: Microsoft/vscode#19260

From @mousetraps on January 25, 2017 19:27
Thanks for reporting! Confirmed this issue impacts both javascript and typescript.
function the() {
	return quick
		.brown(
		fox => console.log('jumped'),
		over => console.log('the'),
		lazy => console.log('dog')
		);
}

cc @mjbvz

Here's a minimal repo:
obj
    .meth(
    1
    );

is left unformated. The expected formatting would be:
obj
    .meth(
        1
    );

seems fixed in latest.


Install failure signal handler

Print backtrace to stderr after getting fatal signal like sigsegv.
I find it really useful during development. It should also help in bug report analysis.

Codecov Report

Merging #1000 (8c556f0) into master (70933e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1000   +/-   ##
=======================================
  Coverage   92.76%   92.76%
=======================================
  Files         325      325
  Lines       21116    21117    +1
=======================================
+ Hits        19589    19590    +1
  Misses       1527     1527

Impacted Files
Coverage Δ

common/util/init_command_line.cc
47.05% <100.00%> (+3.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70933e3...8c556f0. Read the comment docs.


Allow SBLDCFG var to override cwd-based detection

It might be preferable in some settings to not have the search for simplebuild.cfg be based on current working directory, but instead be specified via an environment variable.

This is actually already the case, just let the SIMPLEBUILD_CFG env var point at the simplebuild.cfg file in question (which can have any name).


Drag & drop item from one timeline calendar to other

Hi,
Let's say I have two timeline calendars, is it possible to drag & drop item from one calendar to other? I would appreciate if anyone can provide me a hint/pointers.
Thanks

Need suggestions/pointers for my question! Anyone? I am thinking of using this library for drag and drop item between two timeline calendar but before that I want to know if it's possible.

I have managed to extend react-calendar-timeline to support Drag and drop from a tree view (treebeard), so I expect that drag and drop from another calendar would be quite possible, unfortunately my fork of the timeline is from quite a while ago, however, I expect that in the coming month I will be updating my fork to use 0.15. I ended up adding several extension points for handling drop events on the timeline, and the groups.

Hi @foufee i am still stuck with the drag and drop between two time calendars. Do you have time to update fork? Let me know the status!
Thanks

Yes, i too struck with drag & drop of items between two calenders


Fatal Exception: java.lang.IllegalStateException

##Description

Getting illegal state exception
Fatal Exception: java.lang.IllegalStateException: Fragment not attached to an activity.      at androidx.fragment.app.Fragment.requireActivity(Fragment.java:833)      at com.packageName.FragmentPermissionsDispatcher.functionWithPermissionCheck(FragmentPermissionsDispatcher.java:33)

This is happening because hasSelfPermissions requires activity context and for that, you guys are using requireActivity()
which can be null too
@NonNull     public final FragmentActivity requireActivity() {         FragmentActivity activity = getActivity();         if (activity == null) {             throw new IllegalStateException("Fragment " + this + " not attached to an activity.");         }         return activity;     }
Environment

Which library version are you using? - 4.6.0
On which devices do you observe the issue? - Many Device and almost every Android Version

thx for the report.
But I'm afraid you should avoid calling functionWithPermissionCheck when activity could be null because then we can't do anything(PermissionChecker.checkSelfPermission requires context and we eventually need activity or context).

please use "by lazy" in your fragment


Add debug script to react-server-test-pages

Let us use npm run debug in react-server-test-pages! I didn't know whether or not to pin a version on node-inspector, please let me know if I should and which one to pin to!

This is awesome @lidawang!  Worth mentioning in packages/react-server-test-pages/README.md.


acl: more interfaces

@philips @barakmich updated

@barakmich This and the acl interface need some rework.


[SP-5279] Backport of PDI-18397 - Refreshing database connection tree…

… on jobs and transformations causes performance issues in Spoon (8.3 Suite)
@pentaho-lmartins

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/job/entry/JobEntryDialog.java
  ui/src/main/java/org/pentaho/di/ui/spoon/tree/provider/DBConnectionFolderProvider.java
  ui/src/main/java/org/pentaho/di/ui/trans/step/BaseStepDialog.java
  ui/src/test/java/org/pentaho/di/ui/job/entry/JobEntryDialog_ConnectionLine_Test.java
  ui/src/test/java/org/pentaho/di/ui/trans/step/BaseStepDialog_ConnectionLine_Test.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:


Search

Add an input search.
See http://api3.geo.admin.ch/examples/geoadmin_search.html for an example
Search by locations and by coordinates

Therefore we dont provide a search by layers? This is not defined in the spec

I would say it could come after the first prototype and discussions with IKP

no there is a beautiful catalog to search layers


Added live news app

Have you read the Contributing Guidelines ?
(Write your answer here.)
Description
This app is made my python. News api fetches the data and show into the shell.
Fixes #654
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

Kindly review this.


connection spec v2

swagger.yaml absorbing connection request spec v2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 276 (0.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-13.8%) to 63.84%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sdx_lc/models/connection_qos_unit.py
0
26
0.0%

sdx_lc/models/connection_scheduling.py
0
26
0.0%

sdx_lc/models/connection_qos_metrics.py
0
76
0.0%

sdx_lc/models/connection_v2.py
0
148
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-13.8%

Covered Lines:
978

Relevant Lines:
1481

💛  - Coveralls

Test coverage dropped because of the new model files.  But I am not quite certain that we are actually using them.
As far as I have understood, the case for these model files is when doing JSON serialization and deserialization.  In controller methods, we are not serializing the request bodies to objects of the model classes, nor are we returning such objects. We're mostly working with regular Python dicts and JSON.
The only exception is perhaps the unit tests in sdx-lc.  But I made them that way, before I understood that we can use the static JSON files we now have in datamodel.


match does not select team_id since 2.157.3

I think this commit caused the issue:
https://github.com/fastlane/fastlane/commit/00863a5c305605c4eb14d70ef34a03807d1f049a
I am using match the same way, but since 2.157.3 it goes in error as i call it from jenkins and am not able to select the team by user input.
The error I get is:
_Verifying that the certificate and profile are still valid on the Dev Portal...
The current user is in 7 teams. Pass a team ID or call select_team to choose a team. Using the first one for now.
Multiple teams found on the Developer Portal, Your Terminal is running in non-interactive mode! Cannot continue from here.
Please check that you set FASTLANE_TEAM_ID or FASTLANE_TEAM_NAME to the right value.
Available Teams:
...
Multiple Teams found; unable to choose, terminal not interactive!_
Please fix this asap.
Thank you

We are also encountering this bug. Pls. note that you can work it around, if you set the FASTLANE_TEAM_IDenv variable.

Also, I think this is a duplicat of #17153

Looking into! Duplicate of #17153. Sorry, fam 😔


Remove class constant for PHP 5.4 compatibility

What is the rationale for not supporting 5.4?

And even if you don't accept it for 5.4 compatibility, accept it for consistency reasons; nothing else in the package uses "::class".

Firstly - Laravel 5.1 will be 5.5+.
Secondly, we use it throughout our tests and the package on the whole (check the service provider) so saying we don't use it elsewhere, is incorrect. If there are locations where it's not being used, then in fact THOSE areas are being inconsistent.

Firstly - Laravel 5.1 will be 5.5+.

This isn't 100% confirmed btw. I want it to be 5.5+, but Taylor doesn't seem to want to move until the 5.2 release.

Also, I don't see the point in supporting php 5.4 if you want to use php 5.5 features, like we are here, even if they're only minor things.

@kirkbushell It is used solely in the service provider in the master and 0.6. I was looking only in the develop branch where it isn't used at all (after my change). If you are using in the tests, I don't see it.
But regardless, the first reason would be sufficient enough - if true. If it's not true, I would suggest not abandoning it for a good reason.
@GrahamCampbell What other features would be lost if you had to support 5.4?

It's mostly just syntactical sugar, but it does help when things change/get refactored. I'll chat with mitch tomorrow - though we've already had this chat before and wanted to move to 5.5, regardless of other library's official support.

I agree, we shouldn't support php 5.5.

I agree, we shouldn't support php 5.4.

@jasonlfunk I'll chat with Mitch - there's plenty of reason to support PHP 5.4. We'll have another chat about it - you're the only the only one to have raised it :)


Test new configuration documentation

testing new configuration documentation on Netlify

Reminder that you can make a PR draft to prevent accidental merging.

Reminder that you can make a PR draft to prevent accidental merging.


Attendance Statistics for Events and Profiles

Volunteer Stats Page
How to Test
Screen can be accessed by clicking on profile icon on top right and selecting the "Stats" tab
Important Changes

created the API connection to get the list of events only for the specific volunteer (took a while to get past blockers)
frontend work: "History" is basically complete, need to work on medals

Checklist

[x]  BUG FIX: medals are always bronze, not changing when the variables are adjusting on API call
[ ] ability to sort by date

@ShmulTomer Great work on the UI! One thing, you are currently populating statistics via the event model.  This is incorrect.  Basically, you are giving people credit for an entire event (start to end time) if they registered.  Instead, we need to tie this to the attendance objects.  Take a look at volunteersByAttendance.ts in pages/api/events/[id] to understand how queries with attendance work.
For your statistics, you will need to write a query that returns all attendance objects with the current user's id. Then you can use that object to populate events attended + total hours.  Additionally, you can use the event id to look up the event name.

Looking good with the default data! One thing: this stats page currently can also be accessed by Admins, which is not desired. Only volunteers should have participation statistics.
Please see this report: https://go.playerzero.app/share/6357fdd864f03f2e9952cef0

Great work!!
There is one issue with the admin view:
On the event statistics page for Admins: if an admin modifies a volunteer's check-in/check-out time, the hour count is not updated until the page is refreshed.
Please see more details in this report: https://go.playerzero.app/share/635d670ea5d2ca4d8dfef775
And it would be great if we can add the following:
On the participation statistics page for volunteers, sort the event histories by date and time with the most recent event at the top.

This looks awesome!!


Update README.md

TOC appears for me on the righthand side now.

ah interesting, GitHub seems to have changed that lol. Thanks for the catch.


AssociationList.getUUID Closed ResultSet

2015-05-28 13:27:05 [WARN] java.sql.SQLException: Operation not allowed after ResultSet closed
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1073)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:987)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:982)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:927)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.ResultSetImpl.checkClosed(ResultSetImpl.java:794)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.ResultSetImpl.checkRowPos(ResultSetImpl.java:838)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.ResultSetImpl.getStringInternal(ResultSetImpl.java:5656)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.ResultSetImpl.getString(ResultSetImpl.java:5576)
2015-05-28 13:27:05 [WARN]      at com.mysql.jdbc.ResultSetImpl.getString(ResultSetImpl.java:5616)
2015-05-28 13:27:05 [WARN]      at vg.civcraft.mc.namelayer.database.AssociationList.getUUID(AssociationList.java:105)
2015-05-28 13:27:05 [WARN]      at vg.civcraft.mc.namelayer.NameAPI.getUUID(NameAPI.java:24)
2015-05-28 13:27:05 [WARN]      at vg.civcraft.mc.civchat2.CivChat2Manager.sendGroupMsg(CivChat2Manager.java:436)
2015-05-28 13:27:05 [WARN]      at vg.civcraft.mc.civchat2.listeners.CivChat2Listener.PlayerChatEvent(CivChat2Listener.java:98)
2015-05-28 13:27:05 [WARN]      at sun.reflect.GeneratedMethodAccessor262.invoke(Unknown Source)
2015-05-28 13:27:05 [WARN]      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2015-05-28 13:27:05 [WARN]      at java.lang.reflect.Method.invoke(Method.java:497)
2015-05-28 13:27:05 [WARN]      at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301)
2015-05-28 13:27:05 [WARN]      at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
2015-05-28 13:27:05 [WARN]      at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502)
2015-05-28 13:27:05 [WARN]      at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:484)
2015-05-28 13:27:05 [WARN]      at net.minecraft.server.v1_8_R2.PlayerConnection.chat(PlayerConnection.java:1061)
2015-05-28 13:27:05 [WARN]      at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:999)
2015-05-28 13:27:05 [WARN]      at net.minecraft.server.v1_8_R2.PacketPlayInChat$1.run(PacketPlayInChat.java:39)
2015-05-28 13:27:05 [WARN]      at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
2015-05-28 13:27:05 [WARN]      at java.util.concurrent.FutureTask.run(FutureTask.java:266)
2015-05-28 13:27:05 [WARN]      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
2015-05-28 13:27:05 [WARN]      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
2015-05-28 13:27:05 [WARN]      at java.lang.Thread.run(Thread.java:745)
2015-05-28 13:27:05 [ERROR] Could not pass event AsyncPlayerChatEvent to CivChat2 v1.0.3
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[spigot.jar:git-Spigot-1d14d5f-7722428]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1d14d5f-7722428]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-1d14d5f-7722428]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:484) [spigot.jar:git-Spigot-1d14d5f-7722428]
at net.minecraft.server.v1_8_R2.PlayerConnection.chat(PlayerConnection.java:1061) [spigot.jar:git-Spigot-1d14d5f-7722428]
at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:999) [spigot.jar:git-Spigot-1d14d5f-7722428]
at net.minecraft.server.v1_8_R2.PacketPlayInChat$1.run(PacketPlayInChat.java:39) [spigot.jar:git-Spigot-1d14d5f-7722428]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_45-internal]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_45-internal]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_45-internal]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_45-internal]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45-internal]
Caused by: java.lang.NullPointerException
at vg.civcraft.mc.civchat2.CivChat2Manager.sendGroupMsg(CivChat2Manager.java:449) ~[?:?]
at vg.civcraft.mc.civchat2.listeners.CivChat2Listener.PlayerChatEvent(CivChat2Listener.java:98) ~[?:?]
at sun.reflect.GeneratedMethodAccessor262.invoke(Unknown Source) ~[?:?]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45-internal]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45-internal]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[spigot.jar:git-Spigot-1d14d5f-7722428]
... 11 more

What build of namelayer is up?

v2.3.5

Of the jar i mean.

NameLayer-2.3.5-131.jar
Please increment the plugin's version instead of relying on build number...

I need to figure out how to get jenkins to pull the version from maven and inject into the plugin.yml  136, fixes this.

I see a build 132 at http://civcraft.co:8080/job/NameLayer-master/

Guh, can you forward civcraft.co:8080 to http://<IP_ADDRESS>:8080/ .  I thought ttk2 mentioned this to you?

We'll use build.civcraft.co from now on.
On Thu, May 28, 2015 at 11:45 AM, rourke750<EMAIL_ADDRESS>wrote:

Guh, can you forward civcraft.co:8080 to http://<IP_ADDRESS>:8080/ . I
thought ttk2 mentioned this to you?
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/109#issuecomment-106563489.

@ttk2 Does http://<IP_ADDRESS>:8080/job/NameLayer-master/136/ need testing? If not this should go online.

I know know, that's rourkes determination.
On Thu, May 28, 2015 at 2:13 PM erocs<EMAIL_ADDRESS>wrote:

@ttk2 https://github.com/ttk2 Does
http://<IP_ADDRESS>:8080/job/NameLayer-master/136/ need testing? If not
this should go online.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/109#issuecomment-106569640.

These are the only changes: https://github.com/Civcraft/NameLayer/commit/c357be874b2b765dc6e67394ce5133208df410dd#diff-ccd94b3aade3ad8210eac6c7d3584b15
The first part is to better handle tab completion, if that breaks its nothing too important and players will report.  The second part I just created preparedstatement objects inside the methods so no more of that resultset closed since they are all handling their own preparedstatement.
I think its good to go but those words always seem to cause the worst kinds of problems.
Is this on civtest?  If its broken basicly logging in will show it.

its on Civtest now, what should I look for?
On Thu, May 28, 2015 at 7:50 PM rourke750<EMAIL_ADDRESS>wrote:

These are the only changes: c357be8#diff-ccd94b3aade3ad8210eac6c7d3584b15
https://github.com/Civcraft/NameLayer/commit/c357be874b2b765dc6e67394ce5133208df410dd#diff-ccd94b3aade3ad8210eac6c7d3584b15
The first part is to better handle tab completion, if that breaks its
nothing too important and players will report. The second part I just
created preparedstatement objects inside the methods so no more of that
resultset closed since they are all handling their own preparedstatement.
I think its good to go but those words always seem to cause the worst
kinds of problems.
Is this on civtest? If its broken basicly logging in will show it.
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/109#issuecomment-106643296.

Log and if it doesnt crash youre good.  Pearl yourself, that triggers some
namelayer stuff.
On Thu, May 28, 2015 at 9:23 PM, ttk2<EMAIL_ADDRESS>wrote:

its on Civtest now, what should I look for?
On Thu, May 28, 2015 at 7:50 PM rourke750<EMAIL_ADDRESS>wrote:

These are the only changes: c357be8#diff-ccd94b3aade3ad8210eac6c7d3584b15
<
https://github.com/Civcraft/NameLayer/commit/c357be874b2b765dc6e67394ce5133208df410dd#diff-ccd94b3aade3ad8210eac6c7d3584b15
The first part is to better handle tab completion, if that breaks its
nothing too important and players will report. The second part I just
created preparedstatement objects inside the methods so no more of that
resultset closed since they are all handling their own preparedstatement.
I think its good to go but those words always seem to cause the worst
kinds of problems.
Is this on civtest? If its broken basicly logging in will show it.
—
Reply to this email directly or view it on GitHub
<https://github.com/Civcraft/NameLayer/issues/109#issuecomment-106643296
.

—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/NameLayer/issues/109#issuecomment-106648248.


[BWC and API enforcement] Decorate the existing APIs with proper annotations (part 1)

Description
Decorate the existing APIs with proper annotations. This is merely the first part so we could work through the small changesets vs big bang pull request. The API validations are fully automated (as annotation processor https://github.com/opensearch-project/OpenSearch/issues/9304), here is the sample output (the annotation processor is not part of this pull request since it would generated noisy warnings right now):
error: The element org.opensearch.core.xcontent.XContentBuilder is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.Version)
error: The element org.opensearch.client.Client is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.cluster.service.ClusterService is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.threadpool.ThreadPool is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.watcher.ResourceWatcherService is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.script.ScriptService is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.core.xcontent.NamedXContentRegistry is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.env.Environment is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.env.NodeEnvironment is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.core.common.io.stream.NamedWriteableRegistry is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.cluster.metadata.IndexNameExpressionResolver is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.index.IndexModule is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.plugins.Plugin)
error: The element org.opensearch.core.common.io.stream.StreamInput is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.SettingsException)
error: The element org.opensearch.core.common.unit.ByteSizeUnit is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings.Builder)
error: The element org.opensearch.core.xcontent.MediaType is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings.Builder)
error: The element org.opensearch.core.common.io.stream.StreamInput is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings)
error: The element org.opensearch.core.common.io.stream.StreamOutput is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings)
error: The element org.opensearch.core.xcontent.ToXContent.Params is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings)
error: The element org.opensearch.core.xcontent.XContentParser is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings)
error: The element org.opensearch.core.xcontent.XContentParser is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings)
error: The element org.opensearch.core.common.unit.ByteSizeUnit is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings.Builder)
error: The element org.opensearch.core.xcontent.MediaType is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.common.settings.Settings.Builder)
error: The element org.opensearch.core.xcontent.ToXContent.Params is part of the public APIs but is not maked as @PublicApi or @ExperimentalApi (referenced by org.opensearch.Version)

Related Issues
Part of https://github.com/opensearch-project/OpenSearch/issues/9303

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I have some initial questions. The big one is around marking server classes as Public before we have their JPMS package home. Is that namespace enforced

Thanks @nknize , so JPMS won't help here: these classes we expose through Plugin interface to all plugin developers. We could hide them behind JPMS modules but the Plugin interface will become unusable. The ways we could approach them are a) reduce the Plugin interface (removing some hooks) b) introduce alternative interfaces with significantly smaller APIs blast radius c) something else?
We could always put @InternalApi to such classes but we'll be lying ourselves and most importantly, confuse the users (plugin implementers) with restrictions.

Thanks @nknize , so JPMS won't help here: these classes we expose through Plugin interface to all plugin developers.

The working alternative is https://github.com/opensearch-project/opensearch-sdk-java. None of the interfaces in those implementations drag in the kitchen sink. Import the SDK here and make that the interface you publish to plugins. We can remove the self-hosted nature of extensions and call that plugin v2, too.

The working alternative is https://github.com/opensearch-project/opensearch-sdk-java. None of the interfaces in those implementations drag in the kitchen sink.

Thanks @dblock , we already touched on that (as an example, see please https://github.com/opensearch-project/opensearch-sdk-java/blob/main/src/main/java/org/opensearch/sdk/api/AnalysisExtension.java for core public API exposure needed), but extensions (eventually) should be clean and green, but they are not yet. As we also discussed, plugins are here to stay and we have difficulties evolving the APIs.

so JPMS won't help here...

No I mean how about not annotating any server classes in this PR yet, until after we move the classes to the "rightful" namespace for the JPMS effort. e.g., SecureSettings is going to move to core so the namespace is going to change from o.o.common.settings to o.o.core.common.settings (or something similar). If we mark that w/ @PublicApi will the enforcement break when it's moved namespaces?


Steam Deck - LanguageBarrier exception

Hello,
I installed this patch before on my Steam Deck without any issues. However, the console broke and I got a new one. Unofrtunately, on the new SD I cannot get the patch to work, I am following all the steps exactly like before but I am getting following error
LanguageBarrier exception
json.exception.parse_error.101] parse error at line 1, column 1: syntax error while parsing value - unexpected end of input; expected [', {', or a literal
Any idea what could cause this?

@Skretkowicz
Sorry for the super late reply. Development of this seems to have stalled. Ultimately the issue you're experiencing most likely has to do with flatpak permission issues which this version does not handle very well.
That said, one of the forks on this project has done some extensive work on making a more robust patch launcher script. I recommend checking it out here: https://github.com/Macitron/polyversal-linux-coz-patcher


Replication process, point number 3

Under replication process, point number 3: "If disk changes occur while initial replication is in progress," - is some information missing here? or is point 4 the continitation.  Not very clear. - Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e6273c8f-6017-fbf5-f7e0-510739cf1eb5
Version Independent ID: ac18167a-d049-1ef4-1a2f-3872add854ac
Content: Hyper-V replication to secondary site architecture in Azure Site Recovery
Content Source: articles/site-recovery/hyper-v-vmm-architecture.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

@RavSalgado Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Thanks. This is fixed. @femsulu #please-close

@RavSalgado We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add Electron 10 and 11 prebuilds, and make adding support for new Electron/node versions a little easier

This adds support for prebuilding for Electron 9 by updating to the latest version of node-abi, which is a dependency of both prebuild and prebuild-install.
I did the same thing for another library here: https://github.com/MadLittleMods/node-usb-detection/pull/117
Some more explanation is available here: https://github.com/MadLittleMods/node-usb-detection/pull/106
Fixes #361

Hmm, looks like #362 already takes care of Electron 9. However, this PR should still make the process of supporting future Electron and Node versions simpler, since you don't have to mess with the lock file.

Hmm, looks like #362 already takes care of Electron 9. However, this PR will still make the process of supporting future Electron and Node versions simpler, since you don't have to mess with the lock file.

Just out of curiosity: would this also make it easier to support Electron 10 which has been released in the meantime?
    prebuild-install http 404 https://github.com/tessel/node-usb/releases/download/v1.6.3/usb-v1.6.3-electron-v82-linux-x64.tar.gz
    prebuild-install WARN install No prebuilt binaries found (target=10.1.1 runtime=electron arch=x64 libc= platform=linux)

Hmm, looks like #362 already takes care of Electron 9. However, this PR will still make the process of supporting future Electron and Node versions simpler, since you don't have to mess with the lock file.

Just out of curiosity: would this also make it easier to support Electron 10 which has been released in the meantime?
    prebuild-install http 404 https://github.com/tessel/node-usb/releases/download/v1.6.3/usb-v1.6.3-electron-v82-linux-x64.tar.gz
    prebuild-install WARN install No prebuilt binaries found (target=10.1.1 runtime=electron arch=x64 libc= platform=linux)

Yep, just updated my PR :)

Actually, it looks like node-abi failed to auto-release when Electron 10 came out, so the latest version doesn't include that change yet.

I'm told that the current node-abi version has electron 10 support.

Can y'all please get this PR finished? What's the hold up?

prebuild-install http 404 https://github.com/tessel/node-usb/releases/download/v1.6.3/usb-v1.6.3-electron-v82-win32-x64.tar.gz
prebuild-install WARN install No prebuilt binaries found (target=10.1.3 runtime=electron arch=x64 libc= platform=win32)

This PR now updates to a version of node-abi that should definitely provide details about Electron 10, and 11 as well.

Closing in favor of #407

Closing in favor of #407


[DO NOT MERGE] Rename the property name to "RealId"

Could you file an Issue for this? I don't think we can take this change, as it would be breaking.
... but if you file the issue, we'll triage it and the group can look and decide the best way forward.

DO NOT MERGE - this would be a breaking change to everyone using CosmosDB provider.

@cleemullins I think the renamed property belongs to DocumentStoreItem which is a private class. So i guess the people using CosmosDB provider should not be impacted. Please feel free to correct me if I got any misunderstanding. Thanks

and the name in JsonProperty attribute is not changed, which means the serialized json is kept unchanged.

Hi @tony-xia - I looked at this in more depth today, and you're correct. This is a private class, and it could be changed w/o breaking compat.
However... I'm very risk adverse to making changes to anything having to do with stored serialized state, as it's so very hard to get right even with rigorous testing.
My vote is to leave this "as-is". I've added a detailed comment in the code saying "Don't fix this typo", that you can see here:
https://github.com/microsoft/botbuilder-dotnet/pull/2021


Integrate FireCheckout Patch into mainline

@jonahellison let me know if you need the patch file again.

Where can i get a copy of the fire checkout patch please?

Hi @mxsigns
This is available in the master branch now or in the 1.3.0 version of the extension available on Magento Connect. You should just have to enable "Show as Payment Option" in the configuration and make sure you have the checkout set to "Amazon Standalone Checkout".
https://github.com/amzn/amazon-payments-magento-plugin/wiki/Configuration#display-as-payment-option

Hi @ngrices thanks for your quick response, i am probably being stupid but i cannot see that option can you please tell me where it is.
Also i am getting a couple of display issues in RWD theme as below is there a fix for these?

@mxsigns In the admin, do you see an option called "Display As Payment Option"? If this is enabled the Amazon payments button should show up in the radio button group in firecheckout.
Let me look for the styles for the minicart button centering.

Take a look at the following line
https://github.com/amzn/amazon-payments-magento-plugin/blob/master/app/design/frontend/base/default/template/amazon_payments/button.phtml#L13
Can you edit this style to be centered? I think this is specific to the theme you are using

Thanks i will have a play with that and also see if i can see why the tooltip is hiding behind the cart.
I have just downloaded the extension here and re-uploaded but still can't see that option in admin though, i may just be looking in the wrong place, under what menu option does it display?

@mxsigns in the Payment Method - Amazon Payments config, the option should be there

@mxsigns see https://github.com/amzn/amazon-payments-magento-plugin/issues/215


Simultaneous VIRTUAL_READ and VIRTUAL_WRITE?

I am using the library installed by pip on my Raspberry Pi Model 3 B+.
Here is the version information:
Name: blynk-library-python
Version: 0.1.3
Summary: Blynk library
Home-page: http://www.blynk.cc
Author: Volodymyr Shymanskyy
Author-email<EMAIL_ADDRESS>License: MIT
Location: /usr/local/lib/python2.7/dist-packages
Requires:

Looking at the library code, it appears that when VIRTUAL_READ is used on a virtual pin, it sets the write callback to None. Similarly, when using VIRTUAL_WRITE it sets the read callback to None.
I have a need of both a read and write callback on the same virtual pin.
Is there a way to achieve this?

With the 0.2.0 update, this should work as expected

Wonderful! What is the timeframe you anticipate for the 0.2.0 update?

v0.2.0 is released and available via pip:
https://github.com/vshymanskyy/blynk-library-python/releases/latest


Miscellaneous CNV bug fixes and cleanup.

-Removed repeat fraction from AnnotateTargets.
Closes #645.
-Fixed BEDCodec and TargetCodec conflict in ConvertBedToTargetFile.
Closes #985, closes #986.
-Moved DataProvider for testSubsetTargetToUsableOnes.
Closes #827.
-Added exception for SNPSegmenter.
Closes #684.
-Removed hard-coded upper bound for copy-ratio variance slice sampling.
Closes #804.
-Removed some scripts for test data generation.

Some minor fixes.  Please review, @asmirnov239.


⚠ Bofrost.es has degraded performance

In 202d618, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1773 ms

Resolved: Bofrost.es performance has improved in f4a5b4a after 17 minutes.


Formatting for custom Typeguard

Once the custom typeguard is check-in, we should add support for its formatting
For example,
class B { }
function isB(b: any): b is     B {
    return true;
}

@tinganho wanna take a look at this next?

Do you mean by formatting the compiled JS code has appropriate formatting? I just checked it and it does have proper formatting in the above scenario.

no, formatting in an editor, in the typescript code. this is driven by the language service in https://github.com/Microsoft/TypeScript/blob/master/src/services/services.ts#L6479

@mhegazy I will check it out.

Just tried to fix this. I think I'm too unfamiliar with the formatting code base.

This might help as a comparison point -- https://github.com/Microsoft/TypeScript/pull/3470/files#diff-c00fb970b520e73379126b81f2de14f5L472

Just two lines of code :smile:

thanks @tinganho!


Feature/graph titles

Description
Adds dates to the vertical bar graph and pie graph on the graph page
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] npm test

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] My changes generate no new warnings
[ ] There are no merge conflicts

@didi-codes Should this PR include changes to the admin dashboard and AntTable component?


Add support for limit mime type for image upload

Version
Using @toast-ui/react-editor 1.0.0. Not sure which version of tui-editor using in React version.
Test Environment
macOS 10.13.6 Sierra, Chrome 74
Current Behavior
I want to accept only jpeg/png image types, but there's no way to do that. Especially I don't want to accept gif format.

There is no way to block image according mime type. We consider to use addImageblobHook.
When image will be imported, it will be able to check mime type of image in addImageblobHook handler and then if return return in the hander, default behavior of editor will be blocked.
This way is not implemented currently, this event processing should be implement.


Add persistent session support to ballerina

Current ballerina implementation doesn't support persistent sessions. We need to add this support to ballerina.

This is no longer valid since we have removed sessions


Add links to GitClear stat widgets

GitClear recently added a page that describes the free GitHub profile stat widgets users can generate.
There are actually quite a few other widget visualizations that GitClear can generate, but I left this PR w/ just two types of widgets GitClear offers so hopefully it still feels balanced among various GH profile widget providers
Happy to amend in any way upon request. Lmk if you think labeling these widgets as "free" matters, since it might not be obvious from the text itself.

@wbharding
According to me adding free might give the wrong indication that other tools are paid and this one is free.

Link names updated.


Issue with compress-json module import with Vite

Hi,
I'm having an issue with this module, imported in my project using quasar.
Description
When attempting to import the compress-json module in a Quasar project using Vite, I encounter an error preventing successful module import. The error message indicates that the decompress function is not exported by node_modules/compress-json/bundle.js.
Error Message
'decompress' is not exported by node_modules/compress-json/bundle.js, imported by src/boot/sumup.js
file: ***

Additional Information

Version 3.0.0 was the last version, where the import worked as expected.

How are you importing this library?
The bundle file is only intended for direct usage from vanilla js, if you're using vite, you should be able to import this package from npm using commonjs convention

If your bundler happens to prefer the bundle file over the index file, what if you explicitly import the index file like below code?
import { decompress } from "compress-json/dist/index.js"

How are you importing this library?
The bundle file is only intended for direct usage from vanilla js, if you're using vite, you should be able to import this package from npm using commonjs convention

I loaded the library using yarn, so it should be the same as npm.
import { compress, decompress, trimUndefined } from 'compress-json'

If your bundler happens to prefer the bundle file over the index file, what if you explicitly import the index file like below code?
import { decompress } from "compress-json/dist/index.js"

This solved my problem, but now the IDE is complaining.
Do you think it would be possible to add a hint for the bundler, e.g. in package.json, so that you don't have to specify the file explicitly in code?

import { decompress } from "compress-json/dist/index.js"

This solved my problem, but now the IDE is complaining.

Do you think it would be possible to add a hint for the bundler, e.g. in package.json, so that you don't have to specify the file explicitly in code?

It seems your setup with vite is not bundling common js modules properly.
I tested below setup with quasar (using vite 2 stable version).
Typescript Version Setup IndexPage.vue:
<template>
  <q-page class="row justify-evenly">

title

content

json: {{ a_json }}

compressed json: {{ b_json }}

decompressed json: {{ c_json }}

  </q-page>
</template>

Javascript version should be without below two lines:
import type * as CompressJSONType from 'compress-json'
declare var compressJSON: typeof CompressJSONType

Addition:
It seems the import line can be either
import 'compress-json/bundle.js'

or
import 'compress-json'

Both ways are fine with using quasar with vite.

I'm also having this issue, but I'm using webpack. previously I was using version 3.0.0 and having no issues with this line
import { Compressed, decompress } from 'compress-json';
I tested on version 3.0.1 and that also works fine, this issue was introduced with version 3.0.2 doing
import { Compressed, decompress} from "compress-json/dist/index.js" resolves it

I can confirm that is issue was introduced with commit bdd051f8f6e093cb5289d8dbc33341407a93753e which added the "browser": ... target in package.json

I'll remove the browser field if it helps. The min version and bundle version will still be accessible via CDN when the path is explicit.

I've renamed the browser field into jsdelivr, it should be working for webpack and vite now.
The patch is released as<EMAIL_ADDRESS>Please let me know if it works in your case.

Also added exports field in package.json for better compact as suggested by @siefkenj
The patch is released as<EMAIL_ADDRESS>Thanks for everyone's help 🌱

I'm going to close this issue as the problem is resolved. Please feel free to re-open it if the problem persist in your case.