Make 6to5 more accessible

It'd be great to make 6to5 more accessible to people who don't know that ECMAScript is a thing or even just for your average developer in general.

@sebmck This will be a continuous issue, but hopefully (?) the new site has made this issue closable.

@thejameskyle Definently been fixed with the new site.


Fixing issue 411

Fixes #411

The Jenkins tests passed, but Jenkins does not reflect this. @tar. I'm merging because I'm good on this.

Hmm, now it says passed. Suspicious...


Refactor Anisotropy

@mdoube I had an idea how to improve Anisotropy, and wanted to open this PR for discussion, before it's ready.
The current version blindly shoots sampling vectors from a plane through through the image. This plane needs to be bigger than the stack, so that the vectors have the chance to cover the entire stack, regardless of the plane's orientation. It needs to be d x d to be exact, where d is the largest diagonal of the stack. This means that some of the random vectors are going to miss the stack entirely. The result is that the total length of the MIL vector sampled through the stack will change between runs. I think this is why you see variance in the anisotropy of an empty stack, and why it's not 0.0.
Here I simply keep generating new random vectors, until a predetermined MIL vector total length is reached. Thus MIL vectors have the same base length (before dividing by interceptions). Attached here
are some initial results. I think with the new method the anisotropy of an empty stack is close enough to 0.0 to be attributed to the usual floating point rounding malarkey.

I decided to refactor the code so that the generation of random lines is (entirely) separate from sampling the phase changes. I realised that the tests we have are brittle because there's so much randomness involved. With the new structure we can test the phase change sampling with milOp(img, myTestGenerator), where myTestGenerator repeats some predetermined lines. This way we know exactly what lines pass through the interval, and what they should encounter.

Re: the forum discussion I think the total length of the lines sampled for phase changes, and thus the base length of the MIL vector should remain constant for each direction.  I don't think it's a good idea to just continue until something is hit, because that can take a very long time.
Separating between 0, 1 and >1 hits is a problem I was well aware of when originally implementing Anisotropy. I recall @alessandrofelder and I thought at the time that many 0 or 1 hits would mostly happen with "unsuitable" images. With this in mind, maybe the best strategy is to try to develop a clever warning about a potentially unsuitable image? We could also add more data to the output: "% MIL vectors that hit nothing" etc.

Okay, I did some testing. The findings are:

How you count phase changes (back-to-fore only i.e. current && !previous, or both i.e. current != previous) doesn't really matter
MIL vectors that hit nothing are not really a problem
Plugin parameters have a huge impact!

First I tested back-to-fore vs. both. Then I tried adding one to intercepts so that even one interception would affect MIL length. I used default parameters, unless otherwise specified. Results were:
Count only back-to-fore
bat-cochlea-volume.tif	0.5121949895513304
xy_sheets.tif	0.9998045952659281 (sampling increment 1.0)
Count both
bat-cochlea-volume.tif	0.5025547625132132
xy_sheets.tif	0.9997861764087104 (sampling increment 1.0)
Count both (and total + 1)
bat-cochlea-volume.tif	0.5029102165798932
xy_sheets.tif	0.9997991405855692 (sampling increment 1.0)
Then I found out that MIL vectors that don't hit anything are rare, unless you have an empty stack. This is because each MIL vector is the sum of all the lines (default = 10 000) of a direction / all the phase changes they encounter. To force the issue I ran bat-cochlea-volume  with 2 lines per dimension (so 4 per direction) and 1000 directions. Only 58 MIL vectors had zero or one interceptions.
The third finding is that sampling increment has a big impact on the results. For example, here's the test image xy_sheets run first with sampling increment 2.3 and then 1.0
(increment 2.3)
xy_sheets.tif	0.7773341107759795
xy_sheets.tif	0.8144465990396729
xy_sheets.tif	0.834347062634617
xy_sheets.tif	0.44605003170935276
xy_sheets.tif	0.6540519517056306
(increment 1.0)
xy_sheets.tif	0.9997861764087104
xy_sheets.tif	0.9997846343406255
xy_sheets.tif	0.9997560629338846
xy_sheets.tif	0.9997844830827932
xy_sheets.tif	0.9997724773066062
Of course also dropping lines per dimension and number of directions also increases variance, but not by this much. That also makes more sense, and is less surprising.
@mdoube What's your thoughts? What's the way forward? I suggest we add the constant MIL length and other refactoring introduced in this PR. I don't think we can create a reasonable warning about "bad" images. We'll just have try to document the stochastic nature of the algorithm, and warn about it's sensitivity to input parameters? Users should be aware of "feature size" for a reasonable sampling increment?

I also tested  e6a3528bb12990c1d5b43367c5d220144e51c8f1, with the anisoPPP.tif image from the forum post mentioned above. Now with default parameters its anisotropy is consistently 0.90 - 0.91, which I think is better.

Interesting findings. Did you look at the point cloud of the rose plot that you get when using different sampling increments? The trouble with using an increment that is <= pixel spacing is that you start to see the anisotropy of the pixel grid itself superimposed on the texture (pixel spacing is greater across the pixels' diagonals than in the orthogonal directions). Because the grid has rotational symmetry, its underlying anisotropy is 0, which may bias anisotropic textures to look less anisotropic than they really are.
Maybe it's a more honest representation of discrete space to allow the pixel grid to shine through than to pretend the pixel grid is not there. The best way to highlight this is to use a test image of binary noise, which should be isotropic, and set the sampling increment to << 1 pixel spacing, then look at the rose plot in the 3D viewer.
Some other ways to try to reduce these kinds of Moire-ish effects is to include some random, sub-pixel jitter in the starting positions. Or even, have variable sampling increments for the same image.
It would be most helpful to include a run-to-stable-result loop into the new Anisotropy, because it is hard to predict exactly which settings will provide a good enough estimate of an image's anisotropy. It would keep sampling until the result doesn't change much.
IIRC xy plates has plates of only 1 pixel thick, which means that a sampling increment of 1 samples the boundaries perfectly, whereas a sampling increment of 2.3 pixels is less efficient at finding boundaries (the ruler is bigger than the feature), so would have to sample more times in more directions to find the texture.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Tuesday, February 18, 2020 1:25 AM, Richard Domander<EMAIL_ADDRESS>wrote:

Okay, I did some testing. The findings are:

How you count phase changes (back-to-fore only i.e. current && !previous, or both i.e. current != previous) doesn't really matter
MIL vectors that hit nothing are not really a problem
Plugin parameters have a huge impact!

First I tested back-to-fore vs. both. Then I tried adding one to intercepts so that even one interception would affect MIL length. I used default parameters, unless otherwise specified. Results were:
Count only back-to-fore
bat-cochlea-volume.tif 0.5121949895513304
xy_sheets.tif 0.9998045952659281 (sampling increment 1.0)
Count both
bat-cochlea-volume.tif 0.5025547625132132
xy_sheets.tif 0.9997861764087104 (sampling increment 1.0)
Count both (and total + 1)
bat-cochlea-volume.tif 0.5029102165798932
xy_sheets.tif 0.9997991405855692 (sampling increment 1.0)
Then I found out that MIL vectors that don't hit anything are rare, unless you have an empty stack. This is because each MIL vector is the sum of all the lines (default = 10 000) of a direction / all the phase changes they encounter. To force the issue I ran bat-cochlea-volume with 2 lines per dimension (so 4 per direction) and 1000 directions. Only 58 MIL vectors had zero or one interceptions.
The third finding is that sampling increment has a big impact on the results. For example, here's the test image xy_sheets run first with sampling increment 2.3 and then 1.0
(increment 2.3)
xy_sheets.tif 0.7773341107759795
xy_sheets.tif 0.8144465990396729
xy_sheets.tif 0.834347062634617
xy_sheets.tif 0.44605003170935276
xy_sheets.tif 0.6540519517056306
(increment 1.0)
xy_sheets.tif 0.9997861764087104
xy_sheets.tif 0.9997846343406255
xy_sheets.tif 0.9997560629338846
xy_sheets.tif 0.9997844830827932
xy_sheets.tif 0.9997724773066062
Of course also dropping lines per dimension and number of directions also increases variance, but not by this much. That also makes more sense, and is less surprising.
@mdoube What's your thoughts? What's the way forward? I suggest we add the constant MIL length and other refactoring introduced in this PR. I don't think we can create a reasonable warning about "bad" images. We'll just have try to document the stochastic nature of the algorithm, and warn about it's sensitivity to input parameters? Users should be aware of "feature size" for a reasonable sampling increment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Did you look at the point cloud of the rose plot that you get when using different sampling increments? The trouble with using an increment that is <= pixel spacing is that you start to see the anisotropy of the pixel grid itself superimposed on the texture (pixel spacing is greater across the pixels' diagonals than in the orthogonal directions).

I didn't, but with this explanation I finally got what you meant by "the pixel grid imposing itself". Cheers! Actually, I think we already talked about his way back when, but again managed not to understand each other, even though we were going on about the same thing.
The problem of a line not necessarily visiting each pixel is passes through is well known in computer graphics, and is explained in this tutorial I read not long ago. The solution is Bresenham's algorithmm (3D variant here). For us it could ensure that the the distance between each voxel sampled is 1, i.e. sampling never jumps diagonally. The flip side is that the algorithm introduces an error to the coordinates sampled, the bigger the longer the line is. Then again this is only a problem when sampling increment is 1. If it's more, we want sampling to skip voxels, right?

include some random, sub-pixel jitter in the starting positions

The code's been doing this all along, see line 260.

It would be most helpful to include a run-to-stable-result loop into the new Anisotropy,

Unfortunately I have no idea how to achieve this. From what I've seen, even with a large number of directions & lines per direction there's always about 0.015 variance in the result between repeated runs. How would that stabilise? And that's in a good case. Consider how much the results swing in the xy_sheets.tif example above.

The solution is Bresenham's algorithmm (3D variant here).

Bresenham is a solution to a different problem, which is drawing a line without gaps on a screen using screen dots. We have to draw mathematically perfect vectors in continuous space, then at increments along the line see whether the current pixel is foreground or background. The main choice is whether to assume the pixel location is in the centre of its 'volume' or at the corner, which means you either Math.floor or Math.round. That is also very efficient, because you just add a fixed (dx, dy, dz) (double precision) increment to the current position, then floor (or round) to get the integer index of the pixel to look up. Bresenham's is way less efficient, which I discovered when trying to find all pixels on an ellipsoid surface.

It would be most helpful to include a run-to-stable-result loop into the new Anisotropy,

Unfortunately I have no idea how to achieve this. From what I've seen, even with a large number of directions & lines per direction there's always about 0.015 variance in the result between repeated runs. How would that stabilise? And that's in a good case. Consider how much the results swing in the xy_sheets.tif example above.

See https://github.com/bonej-org/bonej/blob/810f90299917d8a484102dc1e5cbefee384af8c0/src/org/doube/bonej/Anisotropy.java#L221
All it does is run a minimum number of iterations, calculate DA, then keep running more iterations of randomly selected vectors and intercept lines until the last n DA measurements have a variability that is sufficiently small. The idea is that some textures are sparse or highly variable throughout the image volume, but you don't know how much at the beginning, so the algorithm keeps sampling until the result stabilises. In other words, some images need more dense sampling than others to get a reasonable estimate of their anisotropy. This could be likened to the sampling needed to understand a noisy, irregular signal, versus that required for a regular, clean signal, but not knowing at the outset which one of noisy or clean you are dealing with.

@rimadoma please resolve the conflicts flagged in this PR


Added bootstrap service

Since in the configure-network playbook there were a lot of roles unrelated to the network configuration, we moved those roles into another playbook called bootstrap that should be called as the first role (right after download-cache, if/when used) in the deployment process.
https://issues.redhat.com/browse/OSP-28971
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/707

Could bootstrap be added here too?
https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/config/samples/dataplane_v1beta1_openstackdataplanedeployment_pre_ceph_hci.yaml#L11

Could this PR be updated to add bootstrap here too?
https://github.com/openstack-k8s-operators/dataplane-operator/blob/main/config/samples/dataplane_v1beta1_openstackdataplanedeployment_pre_ceph_hci.yaml#L11
otherwise, this is fine by me

You were faster than me :)

At usual, kuttl tests are failing because the image used for dataplane pods is:
quay.io/openstack-k8s-operators/openstack-ansibleee-runner@sha256:2b33d35abd0ed7137647b7a19e037dda84f37d09dadad54cf4348fd7f2200c10

which is the latest image, not the one generated by the edpm-ansible PR.

At usual, kuttl tests are failing because the image used for dataplane pods is:
quay.io/openstack-k8s-operators/openstack-ansibleee-runner@sha256:2b33d35abd0ed7137647b7a19e037dda84f37d09dadad54cf4348fd7f2200c10

which is the latest image, not the one generated by the edpm-ansible PR.

here is what I did to force latest on adoption: https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/tests/roles/dataplane_adoption/tasks/main.yaml#L1-L11
we might need to do the same for kuttl tests

recheck

/test dataplane-operator-build-deploy-kuttl

recheck

recheck

recheck
(added depends-on with ci platforms)

recheck


chore: perform startup zkEVM storage migration just before test contract execution

What :computer:

Perform startup storage migration in zksync mode after test contract deployment and just before test contract execution. This allows migrating any storage changes like nonce/balance that are performed before test execution.
Removes the startup_zk in favor of a more granular migration point.

Why :hand:

As per #731 we have certain scenarios where it's required that the test contract already be deployed for the sound functioning of our tests and scripts.
startup_zk was introduced as a quick and dirty solution.

Evidence :camera:
Tests pass

We can substitute it with functional and_then but it is actually the idiomatic way. I reckoned adding a 4th invariant (SkipInEvm, EvmModeNoop, etc.) but it didn't feel right in the enum category at all, and was requiring quite a bit of docs in explanation, which is usually a direct sign that it doesn't belong there.


Enable kubectl rollout restart on resources deployed via ManagedResources

How to categorize this PR?

/area ops-productivity
/kind enhancement
What this PR does / why we need it:
This PR preserves the kubectl.kubernetes.io/restartedAt annotation for Deployments, DaemonSets and StatefulSets to make kubectl rollout restart work on them
Which issue(s) this PR fixes:
Fixes https://github.com/gardener/gardener/issues/8463
Special notes for your reviewer:
Release note:

An issue preventing `kubectl rollout restart` to work for `Deployments`, `DaemonSets` and `StatefulSets` managed by a ManagedResource is now resolved.

/assign plkokanov

/lgtm

  [FAILED] in [It] - /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/managedseed/create_rotate_delete.go:57 @ 08/06/24 05:43:19.328
  < Exit [It] Create Shoot, Create ManagedSeed, Delete ManagedSeed, Delete Shoot @ 08/06/24 05:43:19.328 (81ms)
  > Enter [AfterEach] ManagedSeed Tests @ 08/06/24 05:43:19.328
  < Exit [AfterEach] ManagedSeed Tests @ 08/06/24 05:43:19.328 (0s)
  > Enter [AfterEach] ManagedSeed Tests @ 08/06/24 05:43:19.329
  < Exit [AfterEach] ManagedSeed Tests @ 08/06/24 05:43:19.329 (0s)
  << Timeline
  [FAILED] Expected success, but got an error:
      <*errors.StatusError | 0xc0007b54a0>:
      shoots.core.gardener.cloud "e2e-managedseed" is forbidden: 7 errors occurred:
      	* given Shoot uses non-registered given Shoot uses non-registered provider type: spec.provider.type ("local")
      	* given Shoot uses non-registered given Shoot uses non-registered provider type: spec.provider.type ("local")
      	* given Shoot uses non-registered given Shoot uses non-registered provider type: spec.provider.type ("local")
      	* given Shoot uses non-registered extension type: spec.extensions[0].type ("local-ext-seed")
      	* given Shoot uses non-registered extension type: spec.extensions[1].type ("local-ext-shoot")
      	* given Shoot uses non-registered extension type: spec.extensions[2].type ("local-ext-shoot-after-worker")
      	* given Shoot uses non-registered given Shoot uses non-registered operating system type: spec.provider.workers[0].machine.image.name ("local")

/test pull-gardener-e2e-kind-operator-seed

  [FAILED] in [It] - /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/managedseed/create_rotate_delete.go:236 @ 08/06/24 06:52:45.543
  < Exit [It] Create Shoot, Create ManagedSeed, Delete ManagedSeed, Delete Shoot @ 08/06/24 06:52:45.543 (25m51.933s)
  > Enter [AfterEach] ManagedSeed Tests @ 08/06/24 06:52:45.543
  < Exit [AfterEach] ManagedSeed Tests @ 08/06/24 06:52:45.543 (0s)
  > Enter [AfterEach] ManagedSeed Tests @ 08/06/24 06:52:45.543
  < Exit [AfterEach] ManagedSeed Tests @ 08/06/24 06:52:45.543 (0s)
  << Timeline
  [FAILED] Timed out after 600.000s.
  Expected success, but got an error:
      <*errors.errorString | 0xc000336d90>:
      ManagedSeed "garden/e2e-managedseed" is not deleted yet: Waiting for garden namespace to be deleted from target cluster
      {
          s: "ManagedSeed \"garden/e2e-managedseed\" is not deleted yet: Waiting for garden namespace to be deleted from target cluster",
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/managedseed/create_rotate_delete.go:236 @ 08/06/24 06:52:45.543

/test pull-gardener-e2e-kind-operator-seed

⏳ Checking conditions for garden/local...
❌ ERROR: VirtualComponentsHealthy not met for garden/local after 600 seconds.
exit status 1

/test pull-gardener-e2e-kind-operator-seed


epic:  Smart model routing / loading

Problem
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Success Criteria
A clear and concise description of what you want to happen.
Sub Issues
Additional context
Add any other context or screenshots about the epic request here.

This needs hardware auto sensing to work first in order to make it work fine.
The request FIFO queue or automatic load/ unload model based on POST body JSON is easy but it might have problem when loading new models/ unloading old models with no information for hardware available.

I don't understand this issue

Smart model routing / loading

Smart model routing / loading

yep , sorry to be confused. renamed. this one is an epic.

old issue


Add Infernal Robotics Model Rework part packs

Manually generated IR Model Rework part packs.
Differs from regular distribution to be more dependency-friendly:

Split off TweakScale support into own package, making it optional
Split off Struts from Utility pack into their own package due to multiple dependencies
Split the Core pack into a Robotics and a Structual package. Structural parts can now be installed without the need for IR

Unfortunately, the Struts pack is untested as the ActiveStruts download URL is currently broken

I fail to see which problems these changes adress. The author of the model rework have split them up into 3 different packs on KerbalStuff and as such https://github.com/KSP-CKAN/NetKAN/pull/952 and https://github.com/KSP-CKAN/NetKAN/pull/951 aim to fulfill the wish of the author about how the mod should be distributed.
If this is however a thing that should be done it belongs in NetKAN where new .ckan files would be generated every time an update happens on KS rather than in CKAN-meta where you'll have to create new .ckan files every update.
You can't have IRPartsReworkCoreRobotics provide IR-Model-Rework-Core since it does in fact not provide that mod seeing as parts of it are cut out. If another mod depends on IR-Model-Rework-Core expecting it to have structural parts and the user choose IRPartsReworkCoreRobotics the experience will not be the same.
There need to be conflicts in all of these files seeing as they do conflic with indexed mods. Or well not the utility pack seeing as that is still not merged. I see no dependency on CIT-utils even though that would appear to be a dependency for the utility pack.
Why make a new Expansion that is identical to the old one?

Pardon me, I completely overlooked that commit. It doesn't help that these packages didn't make it to CKAN-meta/master yet ;)
These come from a private CKAN repository I've built over the last few months, with the very specific purpose of splitting up bigger packs into small ones because of memory reasons (I'm on a mac, in-game memory is scarce).
The structural parts can be easily made part of the IR-Model-Rework-Core virtual installing experience by changing the "recommends" for them in the CoreRobotics package to a "depends". My intention was to add the option for the end user to install the structural parts without needing to have IR or any of the moving parts as an added bonus.
CIT-util is a dependency for ActiveStruts, and will be installed when IRPartsReworkRoboStruts will be installed because AS is a dependency. I split them off the Utilities pack so that the other parts will not be bothered by that, if the user chooses so. Also, the downloads for AS and CIT-util are currently broken (or at least were when I tried earlier), which triggered me to publish this.
And then lastly, I split off TweakScale support, as all 3 packages install the same file to accomplish this, and thus this would cause a conflict. I made it optional, seeing as the IRR parts (struts not tested) work fine without (albeit in a "lesser" experience).
I guess you can forego on this pull request, and I'll talk to ZodiusInfuser about splitting these packs.

Ah I did not know about the connection between ActiveStruts and CIT-Utils.
But yes I'll close this but if there is indeed a strong demand for something like this I recommend a PR to NetKAN which split the currently indexed files rather than creating semi-duplicates. As for why the added ones (core and expansion) aren't currently in CKAN-meta/master, that is a mystery to me aswell and I'll have someone whack the indexing bot to get them there asap.


win,build: fix compilation on ancient Windows systems

Fixes build on Windows XP with Visual Studio 2008.
R=@orangemocha, @piscisaureus

Please, don't ask.

LoL, it seems to fail only on 32bit systems: https://ci.appveyor.com/project/saghul/pyuv/build/1.0.43 Using Windows SDK 7.

LGTM, but do you really need to support compiling on such systems?

@orangemocha sadly, yes. Python 2.7 was compiled with Visual Studio 2008 and you have to compile your modules using that. It looks like it also fails with MSVC 2012 (see #881) , which is more recent.


1075 clean up sample config files

Cleaning up and streamlining config files

🗣 Description
I have formatted the sample config files to be more streamlined. I have also added the other EntraID exclusions that are now available for AAD

💭 Motivation and context
The sample configs have been updated and not streamlined in a while and needed a refresh.
I removed extra references to other baselines in baseline specific sample files and added a more detailed and standardized description. This resolves #1075

🧪 Testing
Sample config files no code was changed

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] PR targets the correct parent branch (e.g., main or release-name) for merge.
[x] Changes are limited to a single goal - eschew scope creep!
[ ] Changes are sized such that they do not touch excessive number of files.
[ ] All future TODOs are captured in issues, which are referenced in code comments.
[ ] These code changes follow the ScubaGear content style guide.
[ ] Related issues these changes resolve are linked preferably via closing keywords.
[ ] All relevant type-of-change labels added.
[ ] All relevant project fields are set.
[ ] All relevant repo and/or project documentation updated to reflect these changes.
[ ] Unit tests added/updated to cover PowerShell and Rego changes.
[ ] Functional tests added/updated to cover PowerShell and Rego changes.
[ ] All relevant functional tests passed.
[ ] All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

[ ] PR passed smoke test check.

[ ] Feature branch has been rebased against changes from parent branch, as needed
Use Rebase branch button below or use this reference to rebase from the command line.

[ ] Resolved all merge conflicts on branch

[ ] Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

[ ] Feature branch deleted after merge to clean up repository.
[ ] Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

The previous config files are referenced in the new-and-improved readme.  Please read through the readme to make sure that the documentation is still accurate.  ATM, you can find this on the 877 branch:
https://github.com/cisagov/ScubaGear/tree/877-streamline-the-docs
Look in /docs/configuration/configuration.md
Thanks!

@amart241 Any updates on this PR? It's been in "New" state with no updates for a month.

Just got back this week from being sick and lots of trips. Working on this afternoon to get this resolved.


7 refactor aws cli script

Refactor AWS CLI into bash script
Provide env var examples for AWS CLI requirements
set our env vars for AWS using gp env

[x] Refactor AWS CLI into bash script
[x] Provide env var examples for AWS CLI requirements
[x ]set our env vars for AWS using gp env


⚠ ClamAV has degraded performance

In 8fd8d48, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 101 ms

Resolved: ClamAV performance has improved in 170f90b.


How to show an error using HUD, if HUD.progress takes too long?

Hi,
Was wondering if HUD.show progress can have a time limit whereas if it passes more than 1 minute, to show a HUD.show subtitle: "error" with an error image? Please need guidance. Would really appreciate it. (using swift 2.0, Xcode 7.3.1) thanks

Hi @feliciaf. If you want to ask some questions, please use Stackoverflow with the tag 'pkhud' (read here for more details).
By the way you can achieve your goal using a Timer.
func showError(){
        HUD.flash(.error)
     }

    override func viewDidLoad() {
        super.viewDidLoad()
        Timer.scheduledTimer(timeInterval: 60, target: self, selector: #selector(DemoViewController.showError), userInfo: nil, repeats: false)
    }

Probably you are running a task in background, if yes you should remember to invalidate the timer if the task ends before 60 seconds and to stop the task if the timer is fired

ok thanks for that @PGLongo


Research twitter wall designs

The twitter wall was on display yesterday at the OpenTechSummit. Lots of people added content, because they saw the wall. We now need to improve the design, e.g. text was too small for the wall. Please research how other twitter wall display tweets and post links and screenshots of twitter walls here.

At the moment we have a vertical scroll animate and the main tweet on top, what we could do is rather, use horizontal scroll animate and show the large tweet in the centre and fade out up or down with another tweet taking over, that way the main tweet is always the center of attraction
What say @fuksi ?

@sudheesh001 It is easier to imagine what you propose, if you offer a wireframe of something similar. Also, it would be great, if you could each of you put a screenshot here of other existing twitter wall services. This would help us to understand what design options we have.

@sudheesh001 That sounds good.
I have another suggestion. Currently, as new tweets come, they keep on adding to the list. After a while, this list would undoubtedly become very long. Since the wall is supposed to be used in a desk/kiosk mode, why not just limit the list to 3 tweets or so? There will be one main tweet, as a centre of attraction as you mentioned, and just three below it. Older tweets will not be shown.

@sudheesh001 Yes, it is a possibility. We could also have a small menu on top, that appears when you go to the top with your cursor. Here people could configure options. BUT: Let us all take a step back, please and look at existing walls to understand how they function in regards to the interface and appearance.
I would like to see screenshots and short wrap ups of 10 different twitter walls here first before we talk about more details.

A good exemple: http://tweetwall.com
Ux/design totally different... But it's the core feature of this company, so i am pretty sure that know what is the best solution for this :-)

Other examples are

http://www.tweetbeam.com/show?query=loklak

http://www.activitywalls.com/?h=Loklak&c=fc1fff666 (Needs to authenticate app)

looking at the sites tweetwall, tweetbeam and activitywalls, I really think we need to get our landing page a makeover. Can I take that redesign work up until we decide on the wall UI/UX ?
Will post a wireframe soon for the wall

Mockup for twitter wall 1

Mockup for twitter wall 1, opacity is important

Mockup for twitter wall 3

Hi @sudheesh001 Good ideas for mockups, but this issue is dedicated to research about twitter walls. Mockup should go into another issue. Let's stay with the topic of issues, please. I added an issue for you here https://github.com/loklak/loklak_webclient/issues/54
@everyone Please have a look around, if there also maybe already an existing twitter wall or several twitter walls, that we might be able to integrate. Github gives me 122 results. Which ones do you like? Please post screenshots: https://github.com/search?utf8=✓&q=twitterwall and https://github.com/search?utf8=✓&q=twitter+wall
Someone even made a twitterwall.js.

@mariobehling https://github.com/EightMedia/TwitterFontana , This looks promising.

There seems to be two kinds of twitterwalls:
*Display one tweet at a time utilizing most of the screen http://twitterfontana.com/
*Display a queue of tweets, with new tweets getting added to the top. https://confwall.com/archived/54c565df1e7ea9e310691b0e
(This could also include a special highlighted tweet, like in the mockups me and @sudheesh001 posted.)
Although the first option looks aesthetically better, IMO we should go for the second option because it gives more information at a glance to the user. The first option is not particularly “useful”.

@sudheesh001 @aneeshd16 Give us some screenshots.
Other questions to consider: What technologies are they using? How easy is it to set them up? Could we possibly integrate them with Loklak? What options do those twitterwalls have for the users e.g. can the user change the display time of feeds, start date of tweet postings. Is there an option to exclude certain tweets or users? Is it possible to display a common list made from different hashtags?

Based on the mentioned examples above I suggest that the wall consists of 3 components:

Centre of attraction: the newest tweet.
A stream of tweets: the minor purpose of these is to show to capability of loklak, and also from this, the users can quickly see how popular is the current affair. We can easily integrate this form our current wall.
A stream of images: similar to stream of tweets.

Extra libraries that we can use: TwitterFontana for the center, Masonry for the pictures, and simple animate.css for all components.

For a user who watches the wall (literally on a projected screen or sth), the center should be big enough.
Normal users with browsers should be able to:

From the stream of tweets: Drag or just type right for older tweet
From the stream of images: hashtag #loklakcan disappear when hovered to the images area. Either that a modal is popped up or we can create a slide of images with slick, which is much more flexible than PhotoSwipe
Conduct an advanced search (we've already done this part before in statistics view)

@mariobehling About the last question, I believe it's already a feature from the server, if the search term contain multiple hashtags e.g. #javascript #web, we should receive only those tweets with both hashtags. Of if you meant the tweet should contain at least one of those hashtags, then we need to do multiple requests, but yes it's possible!

We do have a variety of options now, I especially liked @fuksi 's suggestion that shows images, the centre of attraction and the tweet stream in the same page, without making it too messy or cluttered.

Additional options like filters can be hidden in a popup linked to something like a gear icon. All the options that @mariobehling mentioned are supported by the server and have already been implemented in the statistics page. It should be easy to put them here.

The wall could possibly have an alternate view that shows statistics. So we have a stream view and an aggregate or statistics view. There could be a simple option that can switch views quickly.

I have been assigned the wall feature, and would like to use the one proposed by @fuksi

But i would like to get some opinions and feedback from @loklak/loklak_developers, especially from @mariobehling and @Orbiter :)

@aneeshd16 Let's have a chat about this. Please ping me on Gitter.

Thank you for the research, I close this now because we have a strategy for the wall now. @mariobehling please reopen if disagree on strategy.


Local parse and match is quite different to database results

I ran the parser locally for the latest JSONs for each organisation found in S3, but my results were quite different from the database.
I used uber_api_publications.csv to match against, this is 105,207 publications. I used the model and vectoriser in S3 (reference_parser_models/RefSorter_classifier.pkl and reference_parser_models/RefSorter_vectorizer.pkl). The code also used the new universal regex for each organisation.
The results are:

organisation
Scrape date
Number documents
Number references-doc matches
Time of whole process

Who_iris
who_iris_20190214
5174
1249
3586 secs

Nice
nice_20190131
280
15
280 secs

Unicef
unicef_20190131
105
37
78 secs

Msf
msf_20190131
151
2
90 secs

Gov_uk
gov_uk_20190116
1893
38
552 secs

Parliament
parliament_20190125
196
14
56 secs

TOTAL

7799 documents
1355   ( + 9 with no url, + 2 from url www.fao.org) = 1366 matches
1.3 hours

However in the database scraper.publication has 213,782 documents and in parser_references.reference there are 4784 matches.
Two reasons for differences could be:

possibly the latest data in the database was found with older scraped data than the ones I used,
the latest data in the database was probably found using the old regexes (this code was merged 14th feb)

However, in both cases we might not expect such a large difference results.
Does anyone have any other ideas of why there might be such a difference?

@SamDepardieu  - if you have a minute to look into this today or tomorrow, we should. (A good habit for OSS is to characterize bugs or provide feedback on them within 2 working days.)

Any update on this?

This is probably due to the scraper beeing killed before it sends the json to s3. It writes to the db everytime an item comes through, though it only push the json at the end of the process.
This will eventually get fixed as we are removing the pdf parsing task from the scraper and moving it to a separate process.
I'm leaving this open to keep you updated 👍

As per @hblanks suggestion we should not use or trust the database.

Yes, see my discussion which cc'd @nsorros  in March, https://github.com/wellcometrust/datalabs/issues/232#issuecomment-473937296


CamelCase handling

inline xml instances with element names containing upper case chars are converted to lower case.
   <greetingS>Hello world"</greetingS>

--> access with ./greetingS fails, ./greetings succeeds
instances loaded via submission are not converted (as expected)

this is pretty understandable - inlined instances are HTML DOM and are therefore limited. They'll be parsed to real XML at init time.
This is a limitation that cannot be overcome - inline instances should be used only for simple use cases. If it matters you should always use external XML instances. Same is true for namespace support btw.
Guess i'll need to spell that out somewhere in the docs.


System tray icon not showing up

My Setup

Operating System: Ubuntu 16.04 LTS
App Version: 2.15.0
Installation type: deb

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
The RC icon in the system tray does not appear anymore since last release.
Also with this version it does not seem to work.
Current Behavior
System tray icon does not appear
Expected Behavior
System tray icon should be shown

Is it enabled at menu View > Tray icon? It is disabled by default on the Linux platform.

It was indeed disabled. Thanks so much!
Has this changed one version before? Since I cannot remember to have removed this flag and it was working until I upgraded to the previous version.

@phlegx Yes. If you have not set it, you're running under a default value changed in version 2.14.0, because we can't detect if a desktop environment support tray/notification icons (e.g. Gnome on Ubuntu) or not (Gnome on Fedora).


Windows Terminal Preview hangs and cannot close

Windows Terminal version
1.16.2642.0
Windows build number
10.0.22621.0
Other Software
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
Steps to reproduce

WSL "somehow" ran into a unresponsive state (e.g. huge amount of IO access)
Run wsl --shutdown in the Windows "Run" program, trying to shutdown wsl
The Windows Run program opens windows terminal by default to execute the command

Expected Behavior
No response
Actual Behavior
The popped up windows terminal hangs and cannot close. It does not even show the Profile tab on the top left corner
A minidump of this process is attached below (not sure if helpful)
WindowsTerminal.dmp.zip

QQ, can you send a screenshot of the Terminal in this state?  I bet there's a dupe sitting on the backlog, where the Terminal can't be closed if there are no tabs open. I reckon that's the situation you're in, and a screenshot would immediately identify that case.

nope sorry I can't easily reproduce it. I just came across it and the best I can do is create a minidump and then force kill it

Does it look anything like this:

From #12951
That's my guess, since all the threads in the dump seem to be in a fairly normal state, just waiting for any message from the OS.

exactly the same!

You know, I'm gonna close this as a dupe then. Fixing that should fix whatever you were seeing.


Deck GL Screengrid overlay does not update

Probably root cause of #5470 - The deck gl screengrid overlay displays the same values for the same locations no matter how you pan and zoom the map
Expected results
Popup data corresponds to underlying map data
Actual results
The map renders with the popups misaligned (seems like largest point is in the upper left) and the overlays don't change
Screenshots

With the following Javascript tooltip generator we can illustrate the problem:
(o) => console.log(o) || JSON.stringify([o.object.position, o.lngLat]);

If applicable, add screenshots to help explain your problem.
How to reproduce the bug

Create a screengrid visualization
Pan and zoom the map

Environment
(please complete the following information):

the amancevice/superset:edge container
superset version: Superset 0.999.0dev (post 0.34.0)
python version: Python 3.6.9

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar (there are, but they were stale-botted

worth noting that I've observed this behavior on versions as early as 0.28. This deck.gl issue is possibly related

Also on Screen Grid Play no longer works

This should be .pinned

Closing this since not because it's resolved, but because it hasn't been commented on in 3 years, and references an long-unsupported version of Superset. If this still exists as an issue and needs triage, let's open a new issue! Thanks to all involved.


config: process.user.username is implementation-defined on Windows

On POSIX (currently Linux and Solaris), uid and gid are required. My preferred approach here is to make those optional and use platform defaults:
If unset, the runtime will not attempt to manipulate the user ID (e.g. not calling setuid(2) or similar).

But the maintainer consensus is that they want those to be explicitly required properties.
The Windows username, on the other hand, is optional, although the default behavior is unclear.  I see no discussion in #565 to suggest whether this was intentionally approved or not.  And in #618 (where I asked about the inconsistency), @crosbymichael said:

No, both should be made explicit unless there is something on windows that prohibits this.

So this commit is making that happen.
Pinging some Windows folks for review of the “unless there is something on windows that prohibits this” condition: @jhowardmsft, @RobDolinMS, @jstarks.
Note that there is also a JSON Schema PR for username in flight with #703, but that is orthogonal to this change (the JSON Schema cannot require username even if the field is REQUIRED on Windows, because it is not required, or even specified, on other OSes).
Fixes #618.

Does NOT LGTM. This absolutely IS an optional field on Windows.

On Thu, Apr 06, 2017 at 10:43:58PM -0700, John Howard wrote:

This absolutely IS an optional field on Windows.

uid/gid are technically optional on Linux too (just don't call setuid,
and you inherit the runtime caller uid/gid, modulo namespace mapping
1).  The spec has a policy (which I don't agree with, but I'm not a
maintainer) that the uid and gid values are required anyway (on
Linux).  See links in my original post for maintainers on this point.
If ‘username’ stays optional, then I think the spec should be updated
to clarify what happens when it is not specified.  For example, is
there a default username (e.g. is it inherited from the runtime
caller)?

And with an explicitly added user

Feel free to clarify. But this PR does not LGTM.

And no, it's not inherited at all.

So which of the following would make more sense in the spec.

If unset, username defaults to ContainerAdministrator.

or

The default username is implementation-defined.

?

I would prefer The default username is implementation-defined.

On Mon, Apr 24, 2017 at 09:31:32AM -0700, John Howard wrote:

I would prefer The default username is implementation-defined.

Done with 4e3945f → a3ef036.  I've also added JSON Schema for this,
and forbidden the empty-string value.  If anyone with Windows
experience feels that empty-string usernames should be allowed, please
let me know.

Closing based on feedback from the windows team

Closing based on feedback from the windows team

What feedback from the Windows team?  The current commit (a3ef036) has been endorsed by @jhowardmsft, who's the only Windows member involved in this PR.  Without this PR, the property remains:

Undefined (as in nasal demons) when someone takes advantage of the OPTIONAL-ness and leaves the property unset.  With this PR that use-case would be implementation-defined.
Unchecked in the JSON Schema.  With this PR, we'd validate that the value was a string.

And as I said earlier, I'm fine dropping the new “but not the empty string” requirement if anyone has issues with it.

Since the pivot from REQUIRED to OPTIONAL, the JSON Schema change in this PR mostly matches that which just landed in #703.  So the only remaining features of this PR (which I think we still want) are:

Making the default username implementation-defined (it is currently undefined).
Forbidding empty-string usernames (although I'm fine dropping this if Windows somehow supports empty-string usernames).


[FeatureRequest]: Add option to jump straight to search

Describe the feature
I'd really love if there was the option to straight up jump into the search box when i'm opening my bags. So I can start typing and searching immediatelly.
Describe the implementation
An option in the settings to opt in (disabled by default).
This would work best if it only focuses the search box when I'm using the hotkey (B) to open the search. Not when the bags are openend by context (e.g. vendor).

There is an "open to search" hotkey already in the key bindings for BetterBags in the wow keybindings configuration. You can just bind "B" to it, though it won't close your bag if you type it again. I might augment this down the line so it does.


Operator '+' cannot be applied to types 'number' and 'boolean'

Hi,
I have imported this angular component into a JHipster project and when I try to compile it for production I get this error:
ERROR in node_modules/ng2-smart-table/components/tbody/tbody.component.html(1,2005): : Operator '+' cannot be applied to types 'number' and 'boolean'.
node_modules/ng2-smart-table/components/thead/cells/title/title.component.d.ts.TitleComponent.html(3,17): : Expected 1 arguments, but got 2.
Also, the new angular does not like the keyword /deep/ in the CSS / SCSS file and it would be better to change with ::ng-deep

Hi! I'm in the same situation as you. Any news regarding this error or any workaround?

Hi @Sebi11 ,
I didn't know you already fixed it. Thanks a million, I will use your fork then 👍

Hello @Sebi11 How I can use your package?

@cjfigueiras Sure, no problem!

Thank you for your help.
I created my custom package on https://www.npmjs.com with this commit (Sebi11/ng2-smart-table@5b6fc41) and it's work for me :)

Thank you, used your npm package and it worked!

Hi all, just putting this here in case it helps anybody else.
I wanted to fix this without forking another user's repo; so I used patch-package. It sort of locks me into the version of ng2-smart-table I was using, but I was okay with that. I followed the changes in https://github.com/Sebi11/ng2-smart-table/commit/5b6fc41. Solved everything for me, and now I can use type checking!

That's a nice idea.
Just for information, it seems this issue has been fixed in the release 1.6.0 of the lib.


Add functionality to create and use Confluent environments by name

The code is updated to enable creation of new environments in Confluent by name if they don't exist already. It also changes the handling of environment selection from using environment ID to using environment name. The change is intended to simplify the process and improve user experience by letting the user interact with environment names instead of obscure IDs.

@davetroiano I've updated per your comments


Fix some ivory-http-adapter adoption edge cases

More details in live code comments from https://github.com/rezzza/rest-api-behat-extension/pull/29#discussion_r47421827

[ ] Add some more unit tests for RestApiBrowser::sendRequest('POST', $url, $body) into /tests/Units/Rest/RestApiBrowser.php with $body as either:

[ ] a string
[ ] an array
[ ] a resource

[ ] Fix the bugs.

https://github.com/rezzza/rest-api-behat-extension/pull/29#discussion_r47429980

No longer supported since #52


Doesn't sync with the new action

Describe the bug
Creating new action file in the new branch doesn't shows up the actions in the workflows section.
I have created a new branch from the main branch and added a new workflow file test.yml and tried two scenario to run the action in VSCode

I have committed and pushed the file but it doesn't shows the list action in the workflow action
I have merged that in the main branch and after that while clicking on refresh it showing the list

To Reproduce
Steps to reproduce the behavior:

create a new branch
add new workflow test.yml
add, commit and push the code
and check the Workflow section, newly added workflow is not listed

Expected behavior
It can show the list of newly created workflow action
Screenshots
If applicable, add screenshots to help explain your problem.
Extension Version
v0.25.7
Additional context
I am running in the Mac

The extension uses the actions workflows API to populate the list of workflows in the sidebar. It is therefor limited by/ consistent with workflow creation in all of Github Actions. It mirrors the behavior of GitHub web UI.
For a workflow to be created (and show up in the sidebar) it needs to either: a) be checked into the default branch or b) have a run associated with it. If your workflow has a workflow dispatch trigger, a workaround would be to introduce another trigger like push to trigger one run.


No typings for Typescript projects

the next gen branch is pure tpescript. If there is a request, I might jump as well back into the #moniorepo branch.
But be aware: it was my first typescript project.


Docs/improve-onboarding

Before submitting the PR:

[x] Is your PR referencing an issue? If not, please chat to the team before submission. Closes #300
[x] Is your branch prefixed with docs/, feat/, chore/, bugfix/, tests/? If not, please amend the branch name using branch -m new-branch-name

Tests

[x] Run the tests with npm test and lint the project with npm run lint

Documentation

[x] Does your PR require documentation updates? If so, please ensure that these are included.
[x] Does your PR avoid introducing new dependencies?

What does your PR add/fix/change?
Splits the documentation into one for contributing as a general guide, and one for component specific stuff.
Adds templates for issues
Adds template for Pull Requests
Adds a CONTRIBUTING.md for integration with GitHub
Adds a GitHub Action to enforce naming

@ryceg My man, we just talked through this just last night. I'm going to have to keep this response simple - either you resubmit with only the discussed changes to the Contribution section or this doesn't move forward at all.
The GitHub actions and submission templates seem interesting, but are definitely out of scope. Likewise I have some concerns about some of these changes. Consider adding a feature request so we can open some of these to be discussed with the community. We need to ensure we're serving the contributors and not just strong arming things.

@ryceg Saw the feature requests. Thank you sir!


Allow notebook extensions run in dedicated extension host

This is an attempt to run notebook extensions in a dedicated extension host without being affected by other extensions (or vice versa). In the changes, I spawned another LocalExtensionHost for notebook extensions. As @alexdima pointed out, it adds notebook knowledge to the extension service. A better approach is that extension service allow others to register filters (then the notebook component can register a filter for notebook extensions) and extension meet the filter can be grouped into a new extension host.

@rebornix I've just merged https://github.com/microsoft/vscode/pull/144840 . You can now use:
"extensions.experimental.affinity": {
   "ms-toolsai.jupyter": 1
}

This will move the extension together with all dependencies or dependents to a separate extension host.

Thanks @alexdima , will give it a try today!

I have been self hosting on this issue for a few days, it's working great ❤
I also spent a bit time looking into how to build a command which can find all notebook extensions (or jupyter related) and update the affinity in a single configuration update so users won't need to figure that out themselves. However the configuration update is blocked as this is an unregistered configuration. @sandy081 mentioned maybe we can make this an experimental config but I also like the idea of having it as an unregistered one without making it public. @alexdima any suggestions here?


Test againt php 7.4

The tests allow failure for 7.4, but it does have some issues

It seems all related to a single execution path in the ExpressionParser. I'll fix it later :wink:

Thanks @marcioAlmada & @nunomaduro


Need help writing Custom ACL

I am trying to write a custom ACL rule based on JWT token come in the request so that i WAF allow or block the request after decoding it. Somehow not able to find the correct way to do it. Can anyone help me sending any example code ?
OR my question in another way, Are we alloweed to write own custom ACL in python and deploy directly with thsi solution ?

Yes. You are allowed to write your own custom ACL & deploy directly :) Because this is open source, feel free to tweak it to make it work for you.

From last three-four days i am trying to write custom ACL in python. As i do not find any documentation about how to wirte a custom ACL in python that will be triggered with every request so that i can check the TOKEN come with every request HEADER and write my usecase to allow or block the request. Can you help me with step-by-step guide how to wirte  custome ACL, it will be really helpfull to us for developing the WAF as per our requirements.

Unfortunately that is not in the scope of the WAF security automation solution. I would suggest you to check with the Go SDK team or WAF service team on this: https://docs.aws.amazon.com/awssupport/latest/user/case-management.html Thanks!


Remove inline warning for multiple H1 headings

From another bug/enhancement request (issue #5): Regarding the H1 heading warning. I agree with you that that should not be an inline warning. I'll remove that when I get a chance (probably as a separate bug).

Fixed, v1.0 beta 5.


Research NAT+BRAS software projects

I'm as a ..., can deploy BRAS with NAT option in order to provide network access for small network on low-end hardware as a lightweight bundle.
Limitation: Up to 3 Gbps total troughtput and up to 300 subscribers.
Acceptance criteria:

[ ] pfsence assessed
[ ] vyos assessed
[ ] connection checklist prepared
[ ] demo BRAS deployed

pfSense can be BRAS, its support

captive portal (802.1x)
pppoe (has limit 255 users, but it can be fixed manually)
pppoe + external radius (if need statistics, traffic counter, blocking)

performance with Intel i3-7100 (OpenVPN):

400-500 users
2 Gbps

VyOS the same software router supports same techologies (and IPoE)

in my opinion best variant:

linux server with FreeRadius and web admin (https://github.com/netcore-jsa/radman)
mikrotik CCR* as NAT server
mikrotik CCR* as BRAS (or pfsense instance)


Gravity TOP pulls content up

If using a theme like Theme.AppCompat.Light.NoActionBar, the getStatusBarHeightInPx function returns a negative value which then pulls the content of the flashbar up.
This could also be what's causing #3

Merge it plox

Sorry, can't merge it since I don't have write access.
@aritraroy, can you have a look at this? :)

You should be able to use the latest 1.0.3 as a Gradle import. Please check and let me know.

I moved to version 1.0.3 to see if it fixed the Gravity.TOP issue, but it seems to behave the same as 1.0.2.

I worked around it by wrapping the showing of Flashbar in window.decorView.post {...}

just append \n\n in the message it works for me surprisingly...!


fix(planner): row handler not included when count(*) is used as subexpression

fix https://github.com/risinglightdb/risinglight/issues/501
> explain select count(*) from t;
PhysicalProjection: exprs [InputRef #0]
  PhysicalSimpleAgg: 1 agg calls
    PhysicalTableScan: table #10, columns [], with_row_handler: true, is_sorted: false, expr: None

> explain select 1 from t;
PhysicalProjection: exprs [Int32(1) (const)]
  PhysicalTableScan: table #10, columns [], with_row_handler: false, is_sorted: false, expr: None

> explain select count(*)+1 from t;
PhysicalProjection: exprs [Plus(InputRef #0, Int32(1) (const))]
  PhysicalSimpleAgg: 1 agg calls
    PhysicalTableScan: table #10, columns [], with_row_handler: true, is_sorted: false, expr: None

> explain select -count(*) from t;
PhysicalProjection: exprs [BoundUnaryOp { op: Minus, expr: InputRef #0, return_type: Some(Int(None)) }]
  PhysicalSimpleAgg: 1 agg calls
    PhysicalTableScan: table #10, columns [], with_row_handler: true, is_sorted: false, expr: None

> explain select count(*)+sum(v) from t
PhysicalProjection: exprs [Plus(InputRef #0, InputRef #1)]
  PhysicalSimpleAgg: 2 agg calls
    PhysicalTableScan: table #10, columns [0], with_row_handler: false, is_sorted: false, expr: None


Fixed compatibility with construct >=2.9.41

Coverage decreased (-0.3%) to 91.848% when pulling 38f519eecad597b9a87761879f641c62ce2d48b4 on release1.2.3 into ab473da017018a2c3add8ec4b7253fd2d32fb3ee on master.

Coverage decreased (-0.3%) to 91.848% when pulling 38f519eecad597b9a87761879f641c62ce2d48b4 on release1.2.3 into ab473da017018a2c3add8ec4b7253fd2d32fb3ee on master.


python310Packages.adb-enhanced: 2.5.14 -> 2.5.16

Diff: https://github.com/ashishb/adb-enhanced/compare/2.5.14...2.5.16
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219494 run on x86_64-linux 1

2 packages built:

python310Packages.adb-enhanced
python311Packages.adb-enhanced


"ranges" is used both as a method name and as a variable name

In Impact.py, the name "ranges" is used both as a method name(#L78) and a variable name(#L80) for a list. This is not recommended because it can lead to confusion and unexpected behavior.
I kindly request you to change the name.

@andrewpollock can I contribute to this issue ?

By all means. Please review https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md

Resolved in #1636


fix errors to ensure normal operation

fix errors to ensure normal operation

Is it necessary to wait for the core team to refactor the relevant extensions, yii3.0 will be released?

Is it necessary to wait for the core team to refactor the relevant extensions, yii3.0 will be released?
No. Core could be released before extensions.

Merged. Thanks!


Enhance/zh tw translation

Pull Request Checklist

[x] Description: Briefly describe the changes in this pull request.
[ ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.

There are no relevant documents, so there's no need for an update.

[x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

No. No need.

Description
In response to the call at https://github.com/open-webui/open-webui/blob/main/docs/CONTRIBUTING.md#-translations-and-internationalization, attempting to enhance the Traditional Chinese（zh-TW） translation.

Changelog Entry
Fixed

[List any fixes or corrections]

Changed

[List any changes or updates]

@tjbck The code isn't working as expected, and I'm stumped on why. So, I can't tweak the translation myself:
https://github.com/open-webui/open-webui/blob/f675a18b05735d860bc86b03de3cb243ea1d8b80/src/lib/components/chat/Settings/About.svelte#L46-L51
https://github.com/open-webui/open-webui/blob/f675a18b05735d860bc86b03de3cb243ea1d8b80/src/lib/i18n/locales/zh-TW/translation.json#L350
Open WebUI Version suppose to be Open WebUI 版本 instead:

I realized there's still room for improvement in the traditional Chinese translation, so I decided to reopen this PR.

LGTM, Thanks!


[CELEBORN-745] Match TransportMessage type use number not enum to support change MessageType name

What changes were proposed in this pull request?
Match TransportMessage type use number not enum to support change MessageType name，after this pr, then we can change the MessageType name.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?

ping @pan3793 @waitinfuture @FMX @RexXiong

I think this is a good approach, we should change it before 0.3, then we can change the enum name after 0.3 (maybe 0.3.1 because it's internal change)

Field addition and deletion are both compatible when deserialization with same serialVersionUID of java object, so I add a new field messageTypeValue for TransportMessage and mark messageType as deprecated, then messageType can be removed in next version. This change can compatible with old clients -> new server. @pan3793  @AngersZhuuuu

cc @waitinfuture @FMX


Parser error prettyprinting

As title, it is good if we can format the Expectations into Strings. Ideally, Trifecta's output style (with line numbers and offending lines) will be very nice.

Yes. See the LocationMap class that can compute the line and column.
It would be nice to have some utility that allows you to easily print.
I have some in another project but I use typelevel/paiges to produce the result and I didn't want to add that dependency here.
But we could do something with String or StringBuilder perhaps.

I wrote a simple prettyprinting utility: gist link.
I tried to test with the JSON parser in README. It gave these errors:
(repl):2:7: error: expected one of 'false', 'null', 'true'
2 | {"x": except}
  |       ^
(repl):2:7: error: expected '"'
2 | {"x": except}
  |       ^
(repl):2:7: error: expected '0' ~ '9'
2 | {"x": except}
  |       ^
(repl):2:7: error: expected '['
2 | {"x": except}
  |       ^
(repl):2:7: error: expected '{'
2 | {"x": except}
  |       ^

Should these errors (all at one position) be combined in some way?

Also, LocationMap does not support getting the EOF position (offset == length) which is inconvenient.

Yeah, that is an issue.
If you get None for the line/col, it might be EOL. It would have been nicer if I had noticed that earlier and I could have made an ADT return type:
sealed abstract class RowColResult {
  def toValid: Option[(Int, Int)]
}

object RowColResult {
  case object OutOfBounds extends RowColResult {
    def toValid = None
  }
  case class Valid(row: Int, col: Int) extends RowColResult {
    def toValid = Some((row, col))
  }
  case object EOF extends RowColResult {
    def toValid = None
  }
}

something like that...
We could probably add a method like that, and then have the current method just call toValid on that.
Want to make a PR?

About this: https://github.com/typelevel/cats-parse/issues/239#issuecomment-860181108
yes, I would group by location, and then aggregate all the expecations:
expected false, true, null, ", [, or {
something like that.

This comment:
I was thinking about also giving the EOF a position, which is one column after the last character. This way the offending line can be at the right position.

I think that's right. The EOF should be on the same row as the last real character, unless that character is an end of line itself.
Put another way, EOF should be at the position that would be the same if we did: str + "e" and asked for the position of that final "e".

I made some pretty printing in bosatsu here:
https://github.com/johnynek/bosatsu/pull/808
Maybe something general could make it in here, but people could also copy that code and tweak to suit them.

https://github.com/typelevel/cats-parse/pull/410


Orange Pi Zero 2 I2C pins

Hi,
Just wanted to add that using the overlays setting in orangepiDev.txt to enable I2C was unnecessary as the SCK and SDA pins already appear in /dev:
$ ll /dev/i2c-*
crw-rw---- 1 root i2c 89, 0 Apr 28 23:53 /dev/i2c-0
crw-rw---- 1 root i2c 89, 1 Apr 28 23:53 /dev/i2c-1

Adding the overlays parameter meant sudo i2cdetect -y 0 could not find the expected -0 and -1 pins.
There is one I2C error I can't resolve (yet) though:
$ dmesg | grep i2c
[    1.263757] i2c_dev: i2c /dev entries driver
[    2.712772] mv64xxx_i2c 7081400.i2c: can't get pinctrl, bus recovery not supported
[    2.713881] axp20x-i2c 0-0036: AXP20x variant AXP806 found
[    2.796056] axp20x-i2c 0-0036: AXP20X driver loaded

Thanks for the notes.

I'm still debugging but I might owe you an apology. When I apply overlays=i2c3 in orangepiDev.txt, it does change the I2C dev ports but I can then communicate on /dev/i2c-3 where I was receiving exceptions on /dev/i2c-1 even though i2cdetect -y 1 was showing a device present.

Please ignore, overlay required for I2C pins to communicate properly. Thanks for the docs.


#21 booleanliteral

Missing tests

Missing tests

Fixed

Missing tests

Fixed
Could you also add two more tests, for when there is no sub-operator, and for all suboperators? I did a similar thing in my PRs.

Missing tests

Fixed

Could you also add two more tests, for when all suboperators are blocked/allowed ? I did a similar thing in my PRs.

Fixed


showMonthYearPicker doesn't hightlight current month

Describe the bug
when you set showMonthYearPicker to select month, it doesn't mark current month. If compare with date

how to handle such situation? or can you fix it?

Class .react-datepicker__month-text--today is missing - can we add this class somehow, or we need to wait for fix?

what about this issue? Are you going to fix it?


Error: "Required MongoStore option db missing or is not a string."

Since the application could not start due to MongoStore updates, in 'express.js', please change the connection as below :
From
app.use(session({
secret: config.sessionSecret,
store: new MongoStore({
db: db.connection.db,
collection: config.sessionCollection
})
}));
To
app.use(session({
secret: config.sessionSecret,
store: new MongoStore({
mongooseConnection: db.connection,
collection: config.sessionCollection
})
}));

same issue


Add Send + Sync bounds to StorableSession

This is necessary for Client to implement Send, and thus be usable inside e.g. tokio::spawn.
Closes jesopo/bisky#4.

v0.2.2 uploaded to crates.io


Channel id parsing if fixed

Thanks for finding and fixing this issue. I'll create a milestone for prerelease.


G8RecognizedBlock unit tests

Some unit tests for recognized block class.
That unit tests helps to find an issue in a isEqual and hash functions.

Coverage increased (+3.02%) when pulling 0b1586cd8de394061ff1a3928a8de754cd207789 on ws233:more_unittests into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

Let's move discussion here.
What do you think about this code?
It will return immediately after any of the copnfitions is failed. That should wrong much faster, while searching in collections.

Coverage increased (+3.14%) when pulling 0f72cabf4321526cdb4e015f5fd5a7515f67eba7 on ws233:more_unittests into b9027032ae4f7efeca1eb4dc91a08c2e7acae46f on gali8:master.

Looks good. Why you not implemented not-empty block tests? Any difficulties?

No. Will do soon. Just decided to show the issue before to make sure there is no concerns about it and I do understand this correctly.

Looks good to me so far.

Just made a rebase to respect tonights merges in this PR.

Coverage increased (+3.07%) when pulling 97fe5111938d0c7c90164488335725a180713ec8 on ws233:more_unittests into 29fbaedaa4d2bfa91ebcd988a6e169a07c462e3f on gali8:master.

Coverage increased (+3.68%) when pulling 031403067d95e784f9bcc8f5f48f493f0e9fc63c on ws233:more_unittests into 29fbaedaa4d2bfa91ebcd988a6e169a07c462e3f on gali8:master.

Coverage increased (+3.68%) when pulling bc6135084cb095bdd5f742947f4134f732c20251 on ws233:more_unittests into c258b2df8c39e05842bef1bd4d2f255b748cdcff on gali8:master.

on more rebase

Merge?

Sure, I'll merge and close it now.


Startup aborted 'RocksDBEngine': Could not extract custom attribute

My Environment

ArangoDB Version:    3.4.5
Storage Engine:     RocksDB
Deployment Mode:  Single Server
Deployment Strategy:  ArangoDB Starter
Configuration:       Normal
Infrastructure:      AWS EC2
Operating System:    Debian GNU/Linux 9.9 (stretch)
Total RAM in your machine:   4GB
Disks in use:    100SSD
Used Package:    Debian or Ubuntu .deb

Component, Query & Data
Affected feature:

All DB
AQL query (if applicable):
Not applicable
AQL explain (if applicable):

Not applicable
Dataset:

Not available
Size of your Dataset on disk:

6GB
Replication Factor & Number of Shards (Cluster only):

Not applicable
Steps to reproduce
I can't reproduce. It happens randomly. I couldn't yet figure out what cause it.
Problem:
Database sometimes hangs and every feature stop . However, I can see that the service is running and I can't stop it. Then I would kill the process and I get this error :
ERROR {startup} startup aborted: caught exception during start of feature 'RocksDBEngine': Could not extract custom attribute. (exception location: /work/ArangoDB/lib/Basics/VelocyPackHelper.cpp:808). Please report this error to arangodb.com. shutting down
Expected result:
To start normally after shutdown .
Thank you

This error should never surface.
It is thrown from inside a compare function that can be called by RocksDB for figuring out the order of keys. As the log message shows it is happening at startup, it seems that the comparator is called very early in the startup process with values that require more context than is available then.
I guess it has to do with data in user-defined indexes, but this is just a guess. Is there any special data that you are storing in indexes (e.g. system attributes, entire documents etc.)? Any info here may help us reproduce the problem locally.
Finally, is it possible to gather more log output for the startup, e.g. by starting the server with the extra configuration parameters --log.line-number true --log.level trace --log.level startup=trace --log.level rocksdb=trace --rocksdb.debug-logging true?
This should produce some log output, which may or may not help narrowing down the exact cause of the problem.
Thanks!

If these hangs occur, can you please also check whether you are still able on the shell to execute
cat /bin/true > /dev/null
and whether it still runs in sub second time?
AWS has the concept of "Burst-Credits" - if you run out of them, I/O to the volume gets slow and the whole system comes to a grinding halt - including ArangoDB.

@jsteemann
I will restart the server with the configuration parameters you provided once we have the same issue I comment on this thread with the log output. I it think started to happen after we added user-defined functions to AQL everything else is the same like before. I was not sure if this bug is related to a new arangodb update or because of the user-defined function.
We added this function :
function roundDecimals(value) { return Math.round(value*100)/100}
@dothebart
I will do that if it happened again.
Thank you

@ayox: thanks!
I don't see a direct relation to the user-defined function though. I would suspect it has anything to do with the index setup somehow, but that's also still speculation from my side. Are there any indexes on system attributes, such as _id, _key etc.? Or are you storing entire documents as part of other documents (e.g. in sub-arrays or sub-objects)?

@jsteemann
yes. I am doing this :

storing entire documents as part of other documents (e.g. in sub-arrays or sub-objects)?

I use the document() in AQL to store part of other documents.  No indexes on system attributes.

@ayox: Thanks, that is something we should try in order to reproduce the issue.

I think I have an understand of what's going on now.
Is it possible that there is an index present on the attribute in which you store the other documents you are retrieving via the document() AQL function?
For example, if you fetch a document using the document() AQL function and store it inside an attribute "other", do you have an index on either "other" or a sub-attribute of "other"?

Got it reproduced by creating an index on the _id sub-attribute of an attribute that stores other documents:
2019-05-29T16:05:31Z [30922] INFO [a1c60] {syscall} file-descriptors (nofiles) hard limit is 524288, soft limit is 524288
2019-05-29T16:05:31Z [30922] INFO [3844e] {authentication} Authentication is turned on (system only), authentication for unix sockets is turned on
2019-05-29T16:05:31Z [30922] ERROR [4ec19] {startup} startup aborted: caught exception during start of feature 'RocksDBEngine': Could not extract custom attribute. (exception location: /home/jsteemann/ArangoNoAsan/lib/Basics/VelocyPackHelper.cpp:771). Please report this error to arangodb.com. shutting down
2019-05-29T16:05:32Z [30922] INFO [4bcb9] ArangoDB has been shut down
2019-05-29T16:05:32Z [30922] ERROR [5d508] arangod terminated because of an exception: startup aborted: caught exception during start of feature 'RocksDBEngine': Could not extract custom attribute. (exception location: /home/jsteemann/ArangoNoAsan/lib/Basics/VelocyPackHelper.cpp:771). Please report this error to arangodb.com (exception location: /home/jsteemann/ArangoNoAsan/lib/ApplicationFeatures/ApplicationServer.cpp:680). Please report this error to arangodb.com

@jsteemann That's great news. Do I need now to wait for update or should I do something from my side.

Hi @ayox,
Release Candidate 7 of ArangoDB 3.5, which includes a fix for this issue, has just been released.
Please find the latest RC in the download section.
From the changelog:

disallow indexing the _id attribute even as a sub-attribute.
Previous versions of ArangoDB did not allow creating indexes on the _id attribute, but didn't
check if an index was created on the _id attribute of a sub-attribute, e.g. referredTo._id
or data[*]._id.
Such indexes could be created with previous versions of ArangoDB, but they were non-functional.
From now on, such indexes cannot be created anymore, and any attempts to create them will fail.

In case the reported  error reoccurs, please comment and we will reopen.


mergeResolvers recursive crash

using graphql-tools to merge resolvers I get an error when merging the types from onTypeConflict.
import {
  makeRemoteExecutableSchema,
  introspectSchema,
  mergeSchemas
} from 'graphql-tools';
import { mergeResolvers } from 'merge-graphql-schemas';
import { HttpLink } from 'apollo-link-http';
import fetch from 'node-fetch';

const makeSchema = async (uri, index) => {
  const link = new HttpLink({ uri, fetch });
  const schema = await introspectSchema(link);

  return makeRemoteExecutableSchema({
    schema,
    link
  });
};

export async function makeMergedSchema(uris) {
  const schemas = await Promise.all(
    uris.map((uri, index) => makeSchema(uri, index))
  );

  schemas.push(`
    extend type Post {
      author: Author
    }
  `);

  return mergeSchemas({
    schemas,
    resolvers: mergeInfo => ({
      Post: {
        author: {
          fragment: 'fragment PostFragment on Post { authorId }',
          resolve(parent, args, context, info) {
            return mergeInfo.delegate(
              'query',
              'authorById',
              {
                id: parent.authorId
              },
              context,
              info
            );
          }
        }
      }
    }),
    onTypeConflict(left, right) {
      const merged = mergeResolvers([left, right]);
      // when merged gets to the post type in my schema, it crashes
      return merged;
    }
  });
}

{
  "error": {
    "message": "Maximum call stack size exceeded",
    "stack": "RangeError: Maximum call stack size exceeded
    at deepmerge (/usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1159:19)
    at /usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1153:32
    at Array.forEach (<anonymous>)
    at mergeObject (/usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1149:25)
    at deepmerge (/usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1171:16)
    at /usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1153:32
    at Array.forEach (<anonymous>)
    at mergeObject (/usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1149:25)
    at deepmerge (/usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1171:16)
    at /usr/src/app/node_modules/merge-graphql-schemas/dist/index.cjs.js:1153:32"
   }
}

@lifeiscontent I apologise for not responding sooner. Are you still having the issue reported above or did you resolve/come up with a work around?
Are the resolvers you are trying to merge extremely large or contain a lot of nesting/deeply nested objects?
To help us better solve this issue would you be able to share an example of the two resolvers you are trying merge so we can test against ourselves? Or a minimal reproduction with two schemas where this is occurring?
The error you report suggests/points to a memory issue occurring whilst we use deepmerge. I suspect that potentially the resolvers/schema you have might have a cyclic object/structure which is causing the problem.

@cfnelson hey! thanks for the response.
You can check out my example project here: https://github.com/lifeiscontent/postgraphql-schema-stitching
if you look at this file https://github.com/lifeiscontent/postgraphql-schema-stitching/blob/master/server/src/schema.js
graphql-tools mergeSchemas function takes an onTypeConflict arg, if you use that with merge-graphql-schemas, you can reproduce the errors.
this example is using docker, so if that's an issue for you, I can try to reduce the test case for you.

@lifeiscontent The bug is related to deepmerge and most likely trying to merge a cyclic object/structure. The latest release of deepmerge may resolve this issue for you.
If you are only using this package for mergeResolvers() I would recommend switching to using deepmerge or a similar npm pkg directly instead of this package.
You can simply replace your mergeResolvers([left, right]); line with merge.all([left, right]) which comes directly from deepmerge. You can see here that  mergeResolvers() is only wrapping merge.all().

Closing for now as the issue is related to deepmerge and the two resolvers passed to it.
Happy to continue the discussion further if help is needed. 😄


bootstrap_for_tag and collection_select giving bad name

Hello, I have a form that isn't associated with an object and therefore I am using bootstrap_form_tag. On this form I have a button where I can add different search filters which will add an an additional dropdown box when clicked. This means I can have an indefinite amount of dropdowns. My code abbreviated looks like the following:

= bootstrap_form_tag(bsf_opts(url: "/recorded_calls", method: :post)) do |f|
...
  %td= f.collection_select "durations_greater_less[]", @duration_options, :last, :first, hide_label: true

The html that the f.collection_select generates is found and cloned and added to the page with jQuery when the user clicks a button to add a new filter. The problem is the html that is generated has what I think is an incorrect name. Below is the html that comes out. the name is "[durations_greater_less[]]". This is a problem because lets says a user makes 5 of these dropdowns, I expect to receive as params an array for durations_greater_less, but since the name is enclosed with "[]" the params is not an array, it is a single value. I expect the name to be just durations_greater_less[].
<select class=form-control name=[durations_greater_less[]] id=_durations_greater_less[]>
  <option value=gt>Greater Than</option>
  <option value=lt>Less Than</option>
</select>

I tried to trace this out in the code, but I got stuck in the form_group method on form_builder.rb on the line

control = capture(█).to_s

I see that capture is delegated to @template, but I do not know where @template comes from. Before  the aforementioned line I did capture(1,2) just so it would raise an exception that I had the wrong number of args. In the backtrace I saw capture was going to code in another gem, so I'm not sure if it is the other gem where the issue lies or maybe there is just some data in bootstrap-forms I need to change to get this working.
In the meantime I can hack a solution with using rails select_tag and I'll set the classes manually to have it bootstrap styled.

If this was too complicated, allow me to clarify with a easier to understand example. Imagine I have a form where there is a button that says "Add Fruit". When clicked it will inset a text_field named amounts[] and a dropdown a fuits named fruits[]. So you can do something like

Hit "Add Fruit"
Enter "5" in the text field
Select "Banana "from the drop down
Hit "Add Fruit"
Enter "2" in the text field
Enter "Pineapple" from the drop down
Hit Submit

The params will be {amounts => ["5","2"], fruits => nil}

this might be coming from rails framework...


[MM-51964] Clean up MattermostView, remove tuple in preparation for id

Summary
This PR cleans up the MattermostView class and removes the tuple concept in the Desktop App, since we will be moving over to the id concept.
Ticket Link
https://mattermost.atlassian.net/browse/MM-51964
NONE

@devinbinnie - Are product or developer documentation updates needed for this PR? (I'll re-add the docs/needed label if so)


Link to public VCS

The majority of CPAN modules include a META.json file from where there is a link to the public VCS of the project. I saw you recently uploaded https://metacpan.org/dist/Mojolicious-Plugin-Debugbar where this file is missing. This seems to its VCS albeit I am not sure if it is up to date.

Is this really the source code?
Would you like to add that file and the link?

Hi @szabgab
Sorry for the late reply - yes, this is the source for that code and yes, I'll add that.
Thanks for pointing it out to me.


[Backend][Reentrant] Introduce Reentrant Backend

Level and memory backend are read mostly, so atomic value can a very
limited effect on performance; Only write map acces need to be done under
Mutex.
Now Backend loggers could be called from multiple goroutine.
Tests validated with : go test -v -race ./...

It's seems you testing your code with very old golang version, atomic.Value request Golang >= 1.4

@op : Did you have time to look my patch ?

@nplanel Sorry for the silence. Been very busy lately. Will try to get some time.

@op ok no pb, If you look at the commit, one is a bugfix that you can apply/cherry-pick today.

@op Any update ?

I thought I'd help out with some reviewing. Really would love to be able to set levels for all the loggers from a single routine. I'm thinking reloading configuration to enable debug logging - that would make diagnostics so much easier when a problem is happening.
I did have some concern with the handling though as it seems there may still be a race on the levels map. Not sure best way to get around that - but my first thought is why do we need to map lookup? Maybe each Logger need to pull in the level via sync.Value and it can access it there. Then it is fine to wrap the map in sync.Mutex since it'll only ever be used to lookup and set levels initially, and never during actual log calls (I think!)


Progressbar

Is it a good idea to add a nice progressbar?

For what/why?

For file uploads?

I think this has been brought up before and I'd like to see something like it added. We'll explore it in future iterations so I'll leave this open and file it as a future feature.

+1

+1

Update: started working on this yesterday and here's a screenshot of what I got: http://i.imgur.com/f4sAG.png
What do you think?

Looks impressive! Would be glad if you could finish an polish it soon, so that you can do a pull request, also I hope it will get accepted :D

2.0-wip. Is that correct?

It does not make many differences for me, since I use bootstrap-sass and
have to wait until bootstrap is ported after a release, it was just a
question out of curiosity.

This also needs a Javascript part to make it a full feature, I think?

Since #699 has le code, closing this out to punt any further discussion to there.


Create a Franchisee Training Acceptance Letter

Create a Franchisee Training Acceptance Letter to help them get into the USA.

Creating a letter for immigration purposes calls for unique prison and real facts. It's encouraged to consult with an immigration legal professional or felony professional to make sure that the letter meets the necessary requirements and appropriately represents the scenario. However, I can offer you with a trendy template that you may use as a starting point. Make sure to tailor it to your particular situations and seek advice from criminal experts if wished.
[Your Company Letterhead]
[Date]
[Franchisee's Name]
[Franchisee's Address]
[City, State, ZIP Code]
[Email Address]
[Phone Number]
To Whom It May Concern,
Subject: Franchisee Training Acceptance Letter for Immigration Purposes
I am writing on behalf of [Your Company Name], positioned at [Your Company Address], as the [Your Position Title]. We are thrilled to tell you that [Franchisee's Name], a potential franchisee of [Franchise Name] beneath our brand, has been widespread into our franchise education program. The motive of this letter is to verify their attractiveness into the training application and provide details about the training procedure.
Franchisee Information:
Name: [Franchisee's Name]
Passport/Identification Number: [Passport/ID Number]
Training Start Date: [Start Date]
Training End Date: [End Date]

Training Program Details:
The training application will cowl important aspects of operating a franchise below our logo. The application is designed to equip franchisees with the essential information and skills to efficiently manage and function their franchise enterprise. The training will include comprehensive periods on business operations, customer service, economic management, advertising strategies, and adherence to our logo standards.
Supporting Documentation:
We are supplying this letter to help [Franchisee's Name]'s utility for a visa to go into the US for the cause of participating in our franchise training program. [Franchisee's Name] is predicted to actively take part in all schooling classes during the required period.
Please do no longer hesitate to contact me without delay at [Your Contact Information] in case you require any additional facts or documentation to assist [Franchisee's Name]'s application.
We are dedicated to ensuring the achievement of our franchisees and accept as true with that [Franchisee's Name] will make a precious addition to our network. We respect your attention to this count number and thank you for thinking about [Franchisee's Name]'s application.
Sincerely,
[Your Full Name]
[Your Position Title]
[Your Contact Information]
[Your Company Name]
[Your Company Address]
[City, State, ZIP Code]
[Email Address]
[Phone Number]
Please observe that this is a standard template and should be custom designed based totally to your unique instances, the franchisee's info, and the education application information. It's vital to make certain the accuracy and legality of the facts provided inside the letter. Always visit experts who specialise in immigration matters to make certain compliance with relevant laws and regulations.
I think i should help some, I am not professional at github but its just a try, if need help full kindly feedback.


[Feature/Enhancement] Focus Request Body editor upon selecting Content-Type

Insomnia Version: 5.9.6
Operating System: Windows 10 (Creators Update)

Details
Current behaviour: No focus. After choosing Content-Type for the request, I have to click in the request body editor to get keyboard focus and begin typing/pasting JSON.
Desired behaviour: When I select "JSON" (or any other content-type) in the Request Body content-type dropdown, I would like the request body editor to get keyboard focus so that I can start to type the JSON immediately (or paste).
I type JSON by hand a lot, or copy-paste from other requests' responses, so a behaviour like this would make that process a bit smoother.

JFYI, instead of "copy-paste from other requests' responses" you could use template tags.

Hmm, I can't tell if this would be desired behavior for the general user or not and it seems like quite a small benefit. Your mouse is already likely hovering over the body editor when the dropdown closes. Why not just click it a second time to focus the editor?

Thanks for the tip about the template tags! Will definitely try that out.
I realise that this is an extremely small enhancement, and doesnt need to
be a top priority to implement, but as I see it doesn't break any current
functionality as the keyboard focus ends up on the dropdown menu, which
doesnt really do anything anyway.

On 8 November 2017 at 23:38, Gregory Schier<EMAIL_ADDRESS>wrote:

Hmm, I can't tell if this would be desired behavior for the general user
or not and it seems like quite a small benefit. Your mouse is already
likely hovering over the body editor when the dropdown closes. Why not just
click it a second time to focus the editor?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getinsomnia/insomnia/issues/559#issuecomment-342984857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJlhLJCs9kMbOaPMkVNMDvVonJ6BobyCks5s0i1YgaJpZM4QN8cI
.


Zod complaining non empty field is empty

I am using the latest version of solid js with zod.
I have set up a schema and am using the extend: [ validator({ schema })]. The problem is when I reactively update a Signal, the form inputs are updated with the latest input values, but for some reason Zod cannot see them and keeps throwing errors because it thinks the inputs are empty when they are not. Copy/pasting the values back into the inputs fixes the error messages.
const [profile, setProfile] = createSignal<Profile | null>();

function fetch(uuid: string): Promise<Profile> {
   return Client.get(id);
}

const { errors, form, isValid } = createForm({
   extend: [
       validator({ schema }),
   ],
   onSubmit: (formValues: any) => {
     // do update
   },
   onError: (e) => Logger(e),
});

function getprofile(uuid: string) {
       fetch(uuid)
           .then((res) => {
               if (res.success) {
                   if (res.data) {
                       setProfile(res.data);
                   }
               }
           });
}

export default (props: { id: string }) => {
   return (
       <>
           <Switch>
               <Match when={profile()}>
                   <StoreProvider store={profile}>
                       <ProfileForm
                           errors={errors}
                           form={form}
                           isValid={isValid()}
                       />
                   </StoreProvider>
               </Match>
           </Switch>
       </>
   );
};

ProfileForm:
export default (props: Props) => {
    const [profile] = useStore()!;
    const { form } = props;
    return (
    <form use:form>
        <section>
            <input text="name" value={profile().name} />
        </section>
    </form>
    );
});

Schema:
export default z.object({
    name: z.string().min(1, 'Enter a profile name'),
});

I have created a replication of the issue:
https://codesandbox.io/s/winter-tdd-n45wry?file=/src/main.tsx
Also, similar bug report was opened on solidjs, which also seems to suggest it is an internal issue with Zod: https://github.com/solidjs/solid/issues/1357

I'm not very familiar with SolidJS, but I tried your code sandbox link and everything seems to be working fine. What do I need to do to reproduce the problem?


Repackages

Changes include:

Refactory the package names: a. crypto -> cipher b. create conf package c. create stream package
Fix related make files and fix failed test cases

Thanks @winningsix . +1 for the whole idea.


Add required files fo nfv-hci scenario

Added nodeset value file for HCI
Added scenario file for nfv-hci

/lgtm

/approve


Build fails, when deploying to Netlify

So I just build a site using Victor Hugo and if I try to deploy a version where I am rendering {{ .Content }} on the index.html I am getting an error:

ERROR: 2017/01/09 23:55:08 template.go:132: template: partials/text.html:4:3: executing "partials/text.html" at <.Content>: can't evaluate field Content in type *hugolib.Node in partials/text.htm

So my guess is that, since including {{ .Content }} on the index.html file is a feature only implemented in Hugo v0.18 that there is an old version running on Netlify?

We're still running Hugo 0.17 by default. 0.18 changed so much that we didn't want to force all our user to migrate. You can still run Hugo 0.18 on Netlify thought, you need to change the build command to use hugo_0.18 rather than hugo.
Please, let me know if that work.

Cool thanks for the quick answer! Since I am deploying using the "npm run build" command, how would I specify the hugo_0.18 version?

I think you only need to change it here:
https://github.com/netlify/victor-hugo/blob/master/gulpfile.babel.js#L12

Alright yeah I am in the process of writing a netlify specific build script. I'll let you know how it went!

Worked thanks!


Add required 'karma-browserstack-launcher' to plugins

This isn't required, for more info : http://karma-runner.github.io/0.10/config/plugins.html


Pull out reasonml integration?

Hello! I'm a maintainer of Reason. @gmmorris has created to the reasonml highlight recently, and in order to iterate on it faster, I've pulled it out into https://github.com/reasonml-editor/reason-highlightjs.  I've been using it in place of the first-party one, and it's been solid.
Pulling the plugin out also makes it so that folks don't have to build highlightjs master to obtain it (which isn't always easily doable since it might be a transitive dependency). Last release was a year ago. Additionally, it seems that highlightjs would like to externalize the language plugins anyway; this would already be done.
So I'm wondering if we should just remove the reasonml plugin from this repo; if not, then I can sync that plugin back in if you'd like.
Thanks!

We should sync once and start emitting a warning. I’d love to hear more about the externalization approach. Really think it’s the way to go.

Oh, I'm just mentioning it because I saw it in #1759. If that's not in progress then never mind.

Yeah, not in progress... need to look at the architecture for how to actually do it ☺ I'm hoping to find folks in the community who can help.

While I completely support the approach, my concern would be that until it's a ubiquitous way of plugging in languages, it'll just create confusion.
It would only be a matter of time until someone else adds reason support to master without knowing the plug in exists.
This should be done as a whole refractor, extracting other key languages.

It would only be a matter of time until someone else adds reason support to master without knowing the plug in exists.

As the project maintainers would not accept any new languages, this should not happen. We would then push all languages out of core over time.

This should be done as a whole refractor, extracting other key languages.

Perhaps, but it depends on project resources (which are extremely limited). What we want to do is not have people wait to have their languages merged. We can just focus on the build system and core.

We should have this discussion in #1759 - it's off topic here:)

Alright, submitted a PR ^

Hey,
Just to clarify regarding:

As the project maintainers would not accept any new languages, this should not happen. We would then push all languages out of core over time.

I had assumed that's the case :) I just want to prevent developers spending time and submitting a PR just to be told it already exists as a plug-in.
Communicating this well is important, but definitely not a blocker. :)

Agree. We need to look at how Babel and, say, oh-my-zsh, have dealt with this on a communication level.
Having said that, the only way we can make this happen is to find a few more folks willing to help. It’s definitely doable, but might have to be an xmas project.

I'd actually be very happy to help... In between leading a 12 person team and pursuing my own OSS I'm kind of stretched, but who isn't. 🤣

@gmmorris, I'm in the same boat so totally understand! if you could help me a little bit with the PR backlog, it would be greatly appreciated (e.g,. one or two reviews per week would already be a massive help). Or even just helping close old bugs, etc.
The main thing the project needs is a new build system and to get rid of some of the old dependencies that are being flagged as insecure.

Happy to help 😁
I'll try and find the time.

@chenglou Ping.

Closing this issue due to lack of inactivity.  If @chenglou doesn't really want it merged back into core and we have no one else to champion doing so...  The lack of response isn't necessarily a great sign regarding the maintenance of the module outside core either, so removing it from core also seems premature.   I guess this is just dead for now, with no real resolution either way.
If anyone has interest or wants to champion this we can always revisit.  Closing for now.