Toml library fails its own tests

> Task :toml:test

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[3] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[8] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[23] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > testHardExampleUnicode() FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:512

net.consensys.cava.toml.TomlTest > shouldParseArray(String, Object[])[8] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:555

212 tests completed, 5 failed

> Task :toml:test FAILED

FAILURE: Build failed with an exception.

Hi!
Every commit merged to master must pass CI and run those tests successfullly. Which is to say: I’m unsure why it how you’re getting that error.
Can you provide more detail, like the OS, the version of Java, the checkout git hash, etc?

OS is Windows 10 1809.  Java version 1.8.0_144.
git checkout https://github.com/ConsensSys/cava.git
cd cava
git submodule update --init --recursive
cd toml
..\gradlew test

I assume this will help:
fakedir\cava\toml\src\test\java\net\consensys\cava\toml\TomlTest.java:512: error: unmappable character (0x9D) for encoding windows-1252
    assertEquals("├?├┤├║'ΓäôΓäô ╬╗├í╞¡├¿ ΓéÑ├¿ ├í╞Æ╞¡├¿┼Ö ╞¡╬╗├»╞¿ - #", result.getString("the.test_string"));

PR #153 ensures that all source files are treated as UTF-8, which should solve the "unmappable character" error, and possibly the test failures. Please test with the PR branch (or master after it is merged) and let us know if you still have an issue.

Thank you both for chasing this issue, very appreciated!

@pie-flavor That PR is merged, see if that resolves the issue or not.

D:\temp> git clone ConsenSys/cava
Cloning into 'cava'...
remote: Enumerating objects: 239, done.
remote: Counting objects: 100% (239/239), done.
remote: Compressing objects: 100% (98/98), done.
remote: Total 12199 (delta 55), reused 204 (delta 37), pack-reused 11960
Receiving objects: 100% (12199/12199), 4.14 MiB | 1.05 MiB/s, done.
Resolving deltas: 100% (7204/7204), done.
D:\temp> cd cava
D:\temp\cava [master ≡]> git submodule update --recursive --init
Submodule 'eth-reference-tests/src/test/resources/tests' (https://github.com/ethereum/tests.git) registered for path 'eth-reference-tests/src/test/resources/tests'
Cloning into 'D:/temp/cava/eth-reference-tests/src/test/resources/tests'...
Submodule path 'eth-reference-tests/src/test/resources/tests': checked out '91b73143a19d206adae0a08f3d94dd4c5cc9e738'
D:\temp\cava [master ≡]> cd toml
D:\temp\cava\toml [master ≡]> ..\gradlew test
Starting a Gradle Daemon (subsequent builds will be faster)

> Task :toml:test

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[3] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[8] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > shouldParseString(String, String)[23] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:81

net.consensys.cava.toml.TomlTest > shouldParseArray(String, Object[])[8] FAILED
    org.opentest4j.AssertionFailedError at TomlTest.java:555

212 tests completed, 4 failed

> Task :toml:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':toml:test'.
> There were failing tests. See the report at: file:///D:/temp/cava/toml/build/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 50s
7 actionable tasks: 7 executed

and could this issue be reopened since it is in fact still an issue?

The issues relate to the newline characters present in the expected value. The fix is to judiciously replace the '\n' characters with the proper newline character but only if the toml value is not quoted, in which case \n is escaped.
I also see that some tests in config fail for the same reason.
I managed to reproduce this after installing Windows 10 on a VM.

I fixed the issues regarding the toml tests here: https://github.com/ConsenSys/cava/pull/177
Please review and let me know if the issue can be closed.

Can't even get to the testing bit now.
D:\Temp\cava [master ≡]> git submodule update --init --recursive
Submodule 'eth-reference-tests/src/test/resources/eth2.0-tests' (git@github.com:ethereum/eth2.0-tests.git) registered for path 'eth-reference-tests/src/test/resources/eth2.0-tests'
Submodule 'eth-reference-tests/src/test/resources/tests' (https://github.com/ethereum/tests.git) registered for path 'eth-reference-tests/src/test/resources/tests'
Cloning into 'D:/temp/cava/eth-reference-tests/src/test/resources/eth2.0-tests'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:ethereum/eth2.0-tests.git' into submodule path 'D:/temp/cava/eth-reference-tests/src/test/resources/eth2.0-tests' failed
Failed to clone 'eth-reference-tests/src/test/resources/eth2.0-tests'. Retry scheduled
Cloning into 'D:/temp/cava/eth-reference-tests/src/test/resources/tests'...
Cloning into 'D:/temp/cava/eth-reference-tests/src/test/resources/eth2.0-tests'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:ethereum/eth2.0-tests.git' into submodule path 'D:/temp/cava/eth-reference-tests/src/test/resources/eth2.0-tests' failed
Failed to clone 'eth-reference-tests/src/test/resources/eth2.0-tests' a second time, aborting
D:\Temp\cava [master ≡ +0 ~1 -0 !]> cd toml
D:\Temp\cava\toml [master ≡ +0 ~1 -0 !]> ..\gradlew test

FAILURE: Build failed with an exception.

* Where:
Build file 'D:\temp\cava\build.gradle' line: 27

* What went wrong:
A problem occurred evaluating root project 'cava'.
> eth-reference-tests/src/test/resources/tests/README.md missing: please clone submodules (git submodule update --init --recursive)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s

Yes, see what it reads in the error message?
`* What went wrong:
A problem occurred evaluating root project 'cava'.

eth-reference-tests/src/test/resources/tests/README.md missing: please clone submodules (git submodule update --init --recursive)`

Never mind. Looks like you can't check out with git@github.com:ethereum/eth2.0-tests.git.
No support for git checkouts - will need to move this submodule to https.

I have fixed that issue, so it should be possible for you to build on Windows.


Feature Request - Set collection's background when asset_folders is set to false

When using asset_folders: false (where poster files are all in the base assets folder and named using the collection's name), you're unable to do the same with collection backgrounds files.
I imagine it could work by having the background file alongside the poster file, except with _background appended to the end. Example of what I mean:
assets
├── DCEU.png
├── DCEU_background.png
├── John Wick.png
├── John Wick_background.png
├── MCU.png
├── MCU_background.png
├── Star Wars.png
├── Star Wars_background.png

added in develop along with _Season## and _S##E##

Wow you're speedy, thanks very much!


Revert to assert function rather than use of blunt print statements

Reported by dietmarw on 18 Feb 2013 11:52 UTC
In 9e0d695a4dd019f7d038597c6b6822d178fd36d4 the following changes were done to System.mo:
-equation
-  assert(use_small == false, "Using obsolete system.m_flow_small and system.dp_small."
-         + " Please update the model to new use_small = false",
-         level=AssertionLevel.warning);
+initial equation
+  //assert(use_small == false, "Using obsolete system.m_flow_small and system.dp_small."
+  //       + " Please update the model to new system.use_small = false",
+  //       level=AssertionLevel.warning);
+  if use_small == true then
+    Modelica.Utilities.Streams.print("***");
+    Modelica.Utilities.Streams.print("Using obsolete global system.m_flow_small and system.dp_small.");
+    Modelica.Utilities.Streams.print("They do not distinguish between laminar flow and regularization of zero flow.");
+    Modelica.Utilities.Streams.print("Absolute small values are error prone for models with local nominal values.");
+    Modelica.Utilities.Streams.print("Moreover dp_small can generally be obtained automatically.");
+    Modelica.Utilities.Streams.print("Please update to the new system.use_small = false (see system, Advanced tab).");
+    Modelica.Utilities.Streams.print("***");
+  end if;

The problem is that the print statements might be generated for every iteration unless the tool does some optimisation. A much cleaner way would be the use of the assert() function just as the commented version already suggest. So I would strongly recommend to get rid of the print statements and use assert instead.

Migrated-From: https://trac.modelica.org/Modelica/ticket/989

Comment by sjoelund.se on 18 Feb 2013 15:25 UTC
Oh, and maybe also update the examples use the new way?

Comment by rfranke on 6 Mar 2013 10:46 UTC
First the intention was to declare m_flow_small/dp_small obsolete and enable the new feature use_eps_Re per default -- all existing examples would have used the new feature automatically. This appeared too aggressive for the minor release 3.2.1 though.
Then the idea was to declare m_flow_small/dp_small classic, in conjunction with the print statements. This obviously is annoying for someone who just wants to run all Modelica models -- consequently all examples should be updated. So far only the examples and tests that require the new feature have been updated. Most examples and tests run with both settings.
The appropriate solution might be to go back one step further and declare the new use_eps_Re feature experimental in the MSL 3.2.1 release.
28691a3d69f9b4a3bae08e5adf12ad5eb5d65cf7 removes the print statements and comments out the assertion.

Modified by rfranke on 6 Mar 2013 10:50 UTC


OpEn "teleports" after collision with MAD vehicle

By teleport, I mean the agent vehicle appears again after the crash with the same vehicle ID.

Seems that this PR https://github.com/huawei-noah/SMARTS/pull/369 introduced the teleport.
The difference after this change is we will wait for the SUMO process exit gracefully.

Seems that this PR https://github.com/huawei-noah/SMARTS/pull/369 introduced the teleport.
The difference after this change is we will wait for the SUMO process exit gracefully.


Rename master branch to main

Following process from https://github.com/jupyterhub/team-compass/issues/412
Actions to take, in order:

[ ] approve this PR
[ ] rename the master branch to main in GitHub (this should automatically update all PRs)
[ ] merge this PR
[ ] check the publish workflow publishes the expected outputs if relevant
[ ] If readthedocs.org is used, set main as the default branch explicitly: admin -> advanced -> default branch

$ git grep master
.github/workflows/release.yml:        uses: pypa/gh-action-pypi-publish@master

External action
docs/source/conf.py:# The master toctree document.
docs/source/conf.py:master_doc = "index"
docs/source/conf.py:        master_doc,
docs/source/conf.py:man_pages = [(master_doc, "repo2docker", "repo2docker Documentation", [author], 1)]
docs/source/conf.py:        master_doc,

Sphinx stuff
repo2docker/_version.py:        # "stabilization", as well as "HEAD" and "master".

Versioneer stuff
repo2docker/contentproviders/git.py:                if ref == "master":
repo2docker/contentproviders/git.py:                        "Failed to check out the 'master' branch. "
repo2docker/contentproviders/git.py:                        "Maybe the default branch is not named 'master' "

Explicit handling of master
repo2docker/utils.py:    https://github.com/docker/distribution/blob/master/reference/regexp.go
repo2docker/utils.py:        https://github.com/docker/distribution/blob/master/reference/regexp.go

External references
tests/conftest.py:    """Create a git repository with a git submodule in a non-master branch.
tests/conftest.py:    submodules are initialized properly when the master branch doesn't have
tests/external/reproductions.repos.yaml:  ref: origin/master
tests/external/reproductions.repos.yaml:  ref: master
tests/unit/contentproviders/test_git.py:    # indeed doesn't get any submodule, even though they are in master
tests/unit/test_clone_depth.py:    """Test a remote repository, with a refspec of 'master'"""
tests/unit/test_clone_depth.py:            ref="master",
tests/unit/test_clone_depth.py:    """Test a remote repository, with a refspec of the master commit hash"""
tests/unit/test_utils.py:            "--editable=git+https://github.com/popgensims/stdpopsim.git#egg=stdpopsim-master",

I've avoided changing anything under tests since it'll require code review to ensure we don't inadvertently remove a test case.
versioneer.py:(https://travis-ci.org/warner/python-versioneer.png?branch=master)
versioneer.py:  "master" and "slave" subprojects, each with their own `setup.py`,
versioneer.py:        # "stabilization", as well as "HEAD" and "master".
versioneer.py:        # "stabilization", as well as "HEAD" and "master".

Versioneer stuff

Thanks, I've updated the Sphinx conf.py.
I'm a bit hesistant to change a critical GitHub action to use HEAD without an official statement from the maintainers. We could switch to commit hashes or tags and rely on dependabot to bump them instead, which also means we'd be fully aware of any changes. Alternatively we could switch to release/v1?

Thanks @consideRatio.
Let's go for it then! I don't have permission to rename the branch.

Branch renamed!

Thanks! Do you know who's got access to readthedocs to check the branch name?
The Docker Hub artifact has been broken for a while, see https://github.com/jupyterhub/repo2docker/pull/1071

@manics from https://readthedocs.org/projects/repo2docker/ I conclude among others @yuvipanda @choldgraf have access to update the readthedocs to not be coupled to the master branch, but instead to the main branch.

done 👍


Way to trigger via tasker?

Just saw the new update, but it seems that oneui does not Support changing the Assistant.
I found a way to remap the Button to tasker to open an App for me.
When i select classic Power Menu, the settings get opened, is there a way to trigger the correct view?
Thanks

Already possible:
System > Send Intent
Set the data as shown and the target to activity. That's all.


install: Check if running in container earlier

Previously, the check to verify install to-filesystem is being run
within a container happened fairly late in prepare_install. This moves
the check up before some of the other container specific checks. Now,
the error should occur when trying a basic install to-filesystem
invocation, e.g. bootc install to-filesystem /var/mnt.
This also adds a test to verify the error occurs with minimal arguments
and adds host_is_container to the global state.

What we also should do here I think is add a test case...mmm in the nushell bits should be easy that verifies we do currently get an error.

reworked this to focus on more clearly validating if install to-filesystem is running in a container.


Enable Verbose Logging

Is there anyway to enable verbose logging to view in the debug console? https://firebase.google.com/docs/analytics/ios/events#view_events_in_the_xcode_debug_console

I was able to accomplish this through the Xcode build and adding the argument like described in the link.

On Android you can do:
adb shell setprop log.tag.FA VERBOSE
adb shell setprop log.tag.FA-SVC VERBOSE
adb logcat -v time -s FA FA-SVC


Vulnerabilities (Prototype Pollution) in lodash dependencies

Although the master was modified to include the latest dependencies, there was no new release since, making the most recent version vulnerable:
https://registry.npmjs.org/paperspace-node/-/paperspace-node-0.1.17.tgz

Any chance at publishing a new version?


ros2_planning_system: 2.0.0-1 in 'galactic/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros2_planning_system to 2.0.0-1:

upstream repository: https://github.com/IntelligentRoboticsLabs/ros2_planning_system.git
release repository: https://github.com/IntelligentRoboticsLabs/ros2_planning_system-release.git
distro file: galactic/distribution.yaml
bloom version: 0.10.7
previous version for package: null

plansys2_bringup
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson

plansys2_bt_actions

No changes

plansys2_core

No changes

plansys2_domain_expert
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson

plansys2_executor
* Fix default param
* Solve statically parameter error
* Fix compile issues for galactic
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson, bjnjo

plansys2_lifecycle_manager

No changes

plansys2_msgs

No changes

plansys2_pddl_parser

No changes

plansys2_planner
* Solve statically parameter error
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson

plansys2_popf_plan_solver

No changes

plansys2_problem_expert
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson

plansys2_terminal
* Fix compile issues for galactic
* Compile for ROS2 Galactic
* Contributors: Francisco Martín Rico, Jonatan Olofsson, bjnjo

Dear mantainers,
This PR depends on https://github.com/ros/rosdistro/pull/30109 and https://github.com/ros/rosdistro/pull/30110
Thanks!!

I think so...

I think so...

In that case, this patch needs an update :)

@fmrico it looks like this PR needs title and description updated to match the new release.

@hidmic done!!

Hi @hidmic
I have started to receive the "Build failed in Jenkins: " emails, but I find something strange. Maybe I am not an expert on this, but, for example, in plansys2_bringup for Galactic:
Invoking 'git clone --branch debian/ros-galactic-plansys2-bringup_2.0.0-2_focal --depth 1 --no-single-branch https://github.com/IntelligentRoboticsLabs/ros2_planning_system-release.git /tmp/sourcedeb/source'
Cloning into '/tmp/sourcedeb/source'...
fatal: Remote branch debian/ros-galactic-plansys2-bringup_2.0.0-2_focal not found in upstream origin

This branch doesn't exist. I have release/galactic/plansys2_bringup/2.0.0-2
Am I doing something wrong? I ran bloom, as I did in all the previous releases, following the guide
Thanks!!


Question about train_mb.py and tester_cam.py

Thanks for sharing your code! But I have a question. When training and testing the code(train_mb.py and tester_cam.py）, I found that dataset.input_labels[] was not found. It turns out that self.input_labels is commented out in Scannet_subcloud.py, there only exists self.subcloud_labels. After replacing dataset.input_labels in these two files with dataset.subcloud_labels, the following error will appear(Appear in the validation phase). What should I do?
File "/home/chn/Downloads/mprm-master/datasets/Scannet_subcloud.py", line 718, in spatially_regular_gen
cloud_labels = self.subcloud_labels[data_split][cloud_ind][point_ind][1:]
IndexError: index 2173 is out of bounds for axis 0 with size 30
I think the code in trainer_mb.py and tester_cam.py does not correspond to the code in Scannet_subcloud.py. Please fix this bug.

Thanks for pointing out the problem.
I updated the dataloader to load subcloud labels from npy files.  I forget to update the testing codes. I will fix this problem.

Thanks for pointing out the problem.
I updated the dataloader to load subcloud labels from npy files. I forget to update the testing codes. I will fix this problem.

OK, thanks ~ Looking forward to your updated code.

I replaced the Scannet_subcloud.py with the previous version that generate subcloud label online. You can use this version first and I will fix the problem later.


Custom attributes and spans for FeatureFlag service

Fixes #328.
Changes
Adds a custom span when new feature flags are created via the UI, and adds custom attributes for the feature flag to the auto instrumentation span on the grpc service.

Please update the change log and attribute doc too!
docs/manual_span_attributes.md


Configure Nvidia Container Runtime in AKS

https://docs.nvidia.com/datacenter/cloud-native/gpu-operator/latest/microsoft-aks.html
https://learn.microsoft.com/en-us/azure/aks/gpu-cluster?tabs=add-ubuntu-gpu-node-pool

It looks like I choose the wrong image when I built the GPU node pool, if I had choosen the correct one according to the documentation, It should show up as GPU: X under the Capacity section in kubectl describe node <gpu node> output:
kubectl describe node aks-gpu-46663711-vmss000000

Capacity:
  cpu:                4
  ephemeral-storage:  129886128Ki
  hugepages-1Gi:      0
  hugepages-2Mi:      0
  memory:             28736340Ki
  pods:               30

Command for re-creating node using correct image and instance type                    node.kubernetes.io/instance-type=Standard_NC4as_T4_v3
❯ az extension add --name aks-preview
Default enabled including preview versions for extension installation now. Disabled in May 2024. Use '--allow-preview true' to enable it specifically if needed. Use '--allow-preview false' to install stable version only.
The installed extension 'aks-preview' is in preview.
❯ az extension add --name aks-preview --allow-preview true
Extension 'aks-preview' 2.0.0b8 is already installed.
❯ az extension update --name aks-preview
Default enabled including preview versions for extension installation now. Disabled in May 2024. Use '--allow-preview true' to enable it specifically if needed. Use '--allow-preview false' to install stable version only.
Latest version of 'aks-preview' is already installed.

Use --debug for more information
❯ az feature register --namespace "Microsoft.ContainerService" --name "GPUDedicatedVHDPreview"
Once the feature 'GPUDedicatedVHDPreview' is registered, invoking 'az provider register -n Microsoft.ContainerService' is required to get the change propagated
{
  "id": "/subscriptions/13042e6e-d36a-43e0-a9ae-5f636f008225/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/GPUDedicatedVHDPreview",
  "name": "Microsoft.ContainerService/GPUDedicatedVHDPreview",
  "properties": {
    "state": "Registering"
  },
  "type": "Microsoft.Features/providers/features"
}
❯ az feature register --namespace "Microsoft.ContainerService" --name "GPUDedicatedVHDPreview"
Once the feature 'GPUDedicatedVHDPreview' is registered, invoking 'az provider register -n Microsoft.ContainerService' is required to get the change propagated
{
  "id": "/subscriptions/13042e6e-d36a-43e0-a9ae-5f636f008225/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/GPUDedicatedVHDPreview",
  "name": "Microsoft.ContainerService/GPUDedicatedVHDPreview",
  "properties": {
    "state": "Registering"
  },
  "type": "Microsoft.Features/providers/features"
}
❯ az feature show --namespace "Microsoft.ContainerService" --name "GPUDedicatedVHDPreview"
{
  "id": "/subscriptions/13042e6e-d36a-43e0-a9ae-5f636f008225/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/GPUDedicatedVHDPreview",
  "name": "Microsoft.ContainerService/GPUDedicatedVHDPreview",
  "properties": {
    "state": "Registering"
  },
  "type": "Microsoft.Features/providers/features"
}

az aks nodepool add --resource-group threadr --cluster-name threadr-dev --name gpunp --node-count 1 --node-vm-size Standard_NC4as_T4_v3 --node-taints sku=gpu:NoSchedule --aks-custom-headers UseGPUDedicatedVHD=true --enable-cluster-autoscaler --min-count 1 --max-count 1

Fixed:
Capacity:
  cpu:                4
  ephemeral-storage:  129886128Ki
  hugepages-1Gi:      0
  hugepages-2Mi:      0
  memory:             28742808Ki
  nvidia.com/gpu:     1
  pods:               30


Consider whether enums should be text255 rather than lzo

@bogaert's analysis suggests not

I followed Redshift's recommendations. If in doubt, it's always best to generate a test dataset, load it into Redshift, and see what is best: http://docs.aws.amazon.com/redshift/latest/dg/t_Verifying_data_compression.html

Migrated to iglu.


Remove archive button from mail list (multi-select) view

I appreciate the new design but there's a fault with the Archive button during multi selection.
It is absolutely furiating when you accidentally press it instead of the right-next-to-it mark-as-read button and you have no way to even revert the operation for 30+ mails selected. Even more problematic when you use the composed-all-inbox and then you need to restore emails to different IMAP folders (which is sometimes impossible as you can't remember where every single email was).
I'm using K9 in mixed environments and archiving shouldn't be a quick action, or at least shouldn't be next to the mark-as-read as it's so common and easy to mistake that it's just makes no sense.
I recommend putting the archive button into the (dotted) submenu or as a minimum change the two button should be switched (mark-as-read must be on the right-most side as the most commonly used one).
Thanks you!

There's a feature request to configure the actions in the message list: #5502
There's also a feature request for being able to undo actions: #624
You could hide the archive button by setting Settings > [Account] > Folders > Archive folder to None.
We're not going to move the archive button by default. A lot of people are using this functionality.

@cketti

You could hide the archive button by setting Settings > [Account] > Folders > Archive folder to None.

Tried that but the button is still there (seemingly doing nothing, but the selection is lost if you mistakenly tap on it)

@detoxhby: Ah, I forgot about that. It's a bug. Fixed in K-9 Mail 5.802, available to beta testers on Google Play right now. Or download the APK here: https://github.com/k9mail/k-9/releases/tag/5.802

We're not going to move the archive button by default. A lot of people are using this functionality.

I use it as well but mark-as-read is used 30 times more...that's what I was referring to.
Turning archive folders off is just PITA workaround for me and based on #5502 it's still not sure if I'll be able to hide that button without destroying the functionality. If the plan is "hidden action means button is moved to the submenu" than it will be a fine UX mode 👍🏻


ci: add feat-wrapping on push and on pull request ci triggers

Enables CI for feat-wrapping on push and pull request.
(brought up by #259)

The base branch requires all commits to be signed. Learn more about signing commits.

Uh-oh!


Fix OGG streams never ending playback

Fixes #54821
This was caused by improper detection of the end of an OGG stream.
This method needs a refactor though, I honestly can't explain why this solves the issue. Conceptually I understand that the stream isn't over until we're both out of packets and out of samples in the last packet, but my head is spinning trying to understand what's going on in the big picture. Not the best code I've ever written, that's for sure.

Thanks!


Add words starting with letter "Y"

Create a folder for "Y" and add a word
Refer Contribution.md for more details on how to contribute.
Comment here if you're are working on this issue to avoid conflicts.
Add reference to this issue i.e Issue #51 in your pull request description.

@Showndarya I'm taking this one

@Showndarya I'm working on this


Weapon's License Exam

Describe the feature
Just like the title says, it would be very nice to have a "Weapon's License Exam", similar to the "Driver's License Exam"... but for weapons haha ^^
Additional Context
No response

Would it be best to create a new page for weapon license exams, or have a type property within the current exams feature, then rename the feature from "Drivers license exam" to "License Exams"?
What do you think of this?

Would it be best to create a new page for weapon license exams, or have a type property within the current exams feature, then rename the feature from "Drivers license exam" to "License Exams"?
What do you think of this?

hmm.. well i think the first option (creating a new page) would be better, because we don't necessarily want to activate the Drivers License Exam but only the Weapons License Exam. Unless it's possible to put everything in one page, but give the ability to activate either the drivers exam, the weapons exam or both.
I hope you understand what i mean

ah yeah, fair enough! Will probably create a different page then.

ah yeah, fair enough! Will probably create a different page then.

yup, sounds good! Thanks for being so open to suggestions ^^

Could It also be made so police can lock the exams so criminals can't do them

Could It also be made so police can lock the exams for some people, so criminals can't do them

Oh yeah! Or at least give them the ability to revoke WL and block them for passing exams or some kind of BOLO like "This citizen is flagged as a (potential) criminal."


[Suggestion] Button to open all active bridges

Hello.
small suggestion : what about a button on top of the page to open (show more) all active bridges ?
bonus : button to close all ;)
Maybe no need to test : 2 buttons, one open all, even if already opened, one to close all, even if already closed ?

I understand.
Mixing search + show more is more relevant ;)


refactor: remove metric from evaluators

Linked to https://github.com/jina-ai/jina/pull/1570

You remove the metric property from MockDiffEvaluator in test_encodingevaluation_driver.py and test_craftevaluation_driver.py

You remove the metric property from MockDiffEvaluator in test_encodingevaluation_driver.py and test_craftevaluation_driver.py

You remove the metric property from MockDiffEvaluator in test_encodingevaluation_driver.py and test_craftevaluation_driver.py

is this a request? I will if I have not

You remove the metric property from MockDiffEvaluator in test_encodingevaluation_driver.py and test_craftevaluation_driver.py

is this a request? I will if I have not

sorry, yes I wanted to write "You could remove the metric property from..."

sorry, yes I wanted to write "You could remove the metric property from..."


change -s to -S in gpg verification codespaces page

Why:
adding -s signs-off the commit (just some text at the bottom of a commit message), whereas -S signs the commit
Closes https://github.com/github/docs/issues/10126
What's being changed:
A box at the bottom of https://docs.github.com/en/codespaces/managing-your-codespaces/managing-gpg-verification-for-codespaces
Check off the following:

[x] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@CyberFlameGO
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Why does money.New() take an int64

By making money.New() accept an int64 rather than a float or more inline with other libraries do (possibly more idiomatic?) a *big.Float it cuts off the ability to use a value with a decimal amount during allocation.
dollar := money.New(3.50, "USD") // type error
dollar := money.New(big.NewFloat(3.50), "USD") // would work

Hi @vendion,
Why you see problem using 350 instead of 3.50?
By the way, floating-points and currency are working well together.
"If I had a dime for every time I've seen someone use FLOAT to store currency, I'd have $999.997634" -- Bill Karwin

if your project requires usage of float, go-money shouldn't be responsible for type conversion. My suggestion would be to do type conversion inside your project (if required)

So some of the issues I see with taking ints are: 1) 350 isn't as obvious as 3.50 if hardcoded (for whatever reason that may be) at first glance it's impossible to know if that's three hundred and fifty, or three dollars (or insert your currency here) and fifty cents. 2) It is fairly common, at least from my experience, to use a datatype similar to a float with fixed precession to store currency in a database (https://www.postgresql.org/docs/current/static/datatype-money.html).
One advantage Go's *big.Float has is the ability to set the precision on it as well https://golang.org/pkg/math/big/#Float.SetPrec so it could be set to a precision of 2 places if need be. So in the case of the Bill Karwin quote he would have either $999.99 or maybe $1000depending on the rounding mode (by default it's the latter https://play.golang.org/p/p2wKfpbiofy BTW). Although that may not be the best example.
I wasn't trying to say that this implementation was bad/wrong or anything, it just seems odd to me and when I was originally looking for a good way to handle currency, it seemed like *big.Float was suggested more often, and even used in another package to handle formatting currency https://github.com/leekchan/accounting#caution

Anyways, closing this as you pretty much answered my question with the fact that go-money won't handle conversions


Support for EIP-16 style coupons

In support of EIP-16:

use new getters for coupon principal/premium queries
detect pre EIP-16 style coupons and provide a migrate button for calling migrateCoupons
report aggregate total coupons figure as combined principal + premium

Because I was there:

label fully redeemed coupons as Redeemed
disable Redeem button when the Redeemable pool is empty, show lock icon

I likey

I likey


How to configure prometheus when add ons are managed via ArgoCd?

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Please describe your question here
I'm managing add on through argo by setting argocd_manage_add_ons = true. I'm attempting to install prometheus on our cluster using the instructions described here, but enable_amazon_prometheus = true does create a AMP workspace.  My assumption was a AMP workspace should get created and the prometheus server install on our cluster would forward metrics to the workspace. Then using the workspace we could configuring various monitoring alerts for our applications. Is the assumption correct? With out a AMP workspace what value does setting enable_prometheus = true and enable_amazon_prometheus = true provide?

I'm facing the same issue

I would follow along here https://github.com/aws-ia/terraform-aws-eks-blueprints-addons/issues/114


Clarify the transmission mode of bandwidth

> What connection speeds are supported by ExpressRoute?
> Supported bandwidth offers:
>
> 50 Mbps, 100 Mbps, 200 Mbps, 500 Mbps, 1 Gbps, 2 Gbps, 5 Gbps, 10 Gbps
Regarding the above Q&A, the transmission mode (full or half duplex) is vague.
For example, if you have an ExpressRoute circuit with 100Mbps bandwidth, you may be wondering if you can use 100Mbps for both upstream and downstream, or 100Mbps in total (e.g. 70Mbps for upstream and 30 Mbps for downstream).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cdb32c0-628d-0be2-f514-477d46dfa1b8
Version Independent ID: fa096059-2d16-30a2-1e8b-8b9671afcaa4
Content: FAQ - Azure ExpressRoute
Content Source: articles/expressroute/expressroute-faqs.md
Service: expressroute
GitHub Login: @jaredr80
Microsoft Alias: jaredro

@juyamagu , We are looking into this query and will update you as soon as possible.

@juyamagu , Appreciate your patience. Azure Express Route interfaces works in full duplex mode and the bandwidth mentioned is for total. Which will be in variable proportional ratios between upstream and downstream.
We are closing this issue for now.If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

The answer is wrong. It's full duplex. 1Gbps Circuit has 1Gbps in AND 1Gbps out


Able to get around FTB claims

Describe the bug
Exchange tool and destruction tool are able to get around protection claims on servers
To Reproduce
Use tools in another players claim

What mod version?

Maybe include abit more info like- mod version, and what actual mod your using for protection? xD

Confirmed bug, need to ask FTB team how to fix :)

Any eta on fix?

Hey Dire, FTB team here :smile:
From what I can tell (unless I've missed it somewhere), you're not currently firing Forge block place/break events before placing or breaking any blocks.  Without events, FTB Chunks can't intercept and prevent player actions in claimed chunks.

Is there any fix for this yet?

Should be fixed now, thanks! Sorry for the delay!

Should be fixed now, thanks! Sorry for the delay!

currently using building gadgets and ftb claims in 1.20.1 and it is not working, is there some config i need to edit to allow it to work?


[Question] Is cmake run-time dependency necessary?

Does Howdy really depend on cmake during run-time, or is this only a build-time dependency?

I successfully installed Howdy using apt install howdy.
I used cmake in order to build another application.
After I finished installing the other application, I executed apt autoremove cmake (since I didn't need cmake for anything else).
To my surprise, the howdy package was also removed.

I see that cmake is listed in the Depends section of the debian control file.
However, is there a way to remove that cmake package dependency from Howdy?
(If not, that's OK-- I do understand that you need cmake during installation.).

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution (if applicable): Ununtu 22.04
Howdy version (sudo howdy version): 261

This is a very good question. cmake was originally used to recompile all of dlib because the version in the ubuntu repo was old, broke on a lot of installations and did not have the proper build flags set for nvidia GPUs.
Maybe it's worth setting some of those build dependencies as suggested and to skip building dlib if they are not provided?


Fix bug where bogus path info is prepended to TOC entries when directory argument doesn't include trailing slash

I believe this addresses issue #32
Running node cli.js -d docs/adr -i in this repository without this fix yields
- [ADR-0000](../adr0000-use-markdown-architectural-decision-records.md) - Use Markdown Architectural Decision Records
- [ADR-0001](../adr0001-extend-markdown-toc.md) - Extend markdown-toc
- [ADR-0002](../adr0002-use-console-stamp-as-logging-framework.md) - Use console-stamp as logging framework
- [ADR-0003](../adr0003-use-release-it-and-github-release-from-changelog-as-release-tooling.md) - Use release-it and github-release-from-changelog for releasing
- [ADR-0004](../adr0004-filename-as-direct-parameter.md) - Filename as direct parameter

With this fix, no changes are produced, as expected.

Thank you for the PR. I merged it to offer others using the latest development build to enjoy it.
It would be great if an entry to CHANGELOG.md could be added.


feat: Add strict mode for marshal, enforce use of uri and default to about:blank for type.

closes #11

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (eef42ea) to head (ed4b651).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           70        76    +6
  Branches         6         9    +3
=========================================
+ Hits            70        76    +6

Flag
Coverage Δ

unittests
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adding website endpoint as stored attribute

Adding the website endpoint associated with each bucket as a stored attribute

@jdmundrawala do you have the time to do the updates for this one?  Or is it already merged and this just wasn't closed?

@jkeiser refactored and rebased

@jdmundrawala merged, thanks!!!


Fix handling of PlotWidget background color

This PR fixes a regression on the handling of plot background colors following PR #2964.
closes #2967

Thanks a lot. It works.


chore: use --update-if-exists when pushing broker

Previously we would always try and create the broker, and if that failed (for any reason) then attempt to update it. This resulted in output that sometimes confused users.

Thanks @fnaranjo-vmw. I can see how checking the --space-scoped status consistency would be an improvement. If you're interested, the CF CLI is an open source project, and you could submit a PR for that.


Rename build artifact to include -min

Signed-off-by: Xue Zhou<EMAIL_ADDRESS>Description
Rename build artifact to include -min. Distinguish minimal distribution from bundle(with plugins from other repos in opensearch-project).
Issues Resolved
#1094
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

start gradle check

The failure looks related
org.opensearch.gradle.internal.InternalDistributionArchiveSetupPluginFuncTest > applies defaults to tar tasks FAILED
    org.spockframework.runtime.ConditionNotSatisfiedError at InternalDistributionArchiveSetupPluginFuncTest.groovy:67

The failure also occurs in the current main branch, and an issue was created to track the test failure #1250.

start gradle check

start gradle check

start gradle check

The failure in above check:
> Task :server:test

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.translog.TranslogTests.testFullRangeSnapshot" -Dtests.seed=B5CACAA1BCDFB9FE -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=de-AT -Dtests.timezone=America/Iqaluit -Druntime.java=15

org.opensearch.index.translog.TranslogTests > testFullRangeSnapshot FAILED
    org.opensearch.index.engine.MissingHistoryOperationsException: Not all operations between from_seqno [0] and to_seqno [15] found
        at __randomizedtesting.SeedInfo.seed([B5CACAA1BCDFB9FE:D23306AB85C68D18]:0)
        at org.opensearch.index.translog.Translog$SeqNoFilterSnapshot.next(Translog.java:1002)
        at org.opensearch.index.translog.TranslogTests.testFullRangeSnapshot(TranslogTests.java:786)

Tests with failures:
 - org.opensearch.index.translog.TranslogTests.testFullRangeSnapshot

start gradle check

Before merging, what do we need to change in https://github.com/opensearch-project/opensearch-build to accommodate for this change?

We’re going to have to backport this to 1.1 as well.

We’re going to have to backport this to 1.1 as well.

Yes. It's ready for merging. I will backport it.


docs: fix setup-guide instructions

add $RISCV_DIR to PATH
use python3 builtin venv package

Great work! I believe these changes close issue #89.


docs: update readme about team assignment

Hi Kentaro,
Thank you so much for the great application! 👍
I create a pull request to modify README.md and would like you to check it.
Thank you.

closed since it's no longer needed.


graphite-api.yaml loading issue

I am new to python and trying to install graphite-api using mod-wsgi and apache. I see the below errors in my error.log. I am assuming it is unable to read the /etc/graphite-api.yaml . I changed permissions on the yaml file as well as the index to read/write by all users. I did not see anything in my apache logs and process graphite-api is running with the below errors.
$ps -ef | grep graphite
daemon   27149 27146  0 19:07 ?        00:00:00 (wsgi:graphite-api)          -k start

Error.log details :
 [error] path='/etc/graphite-api.yaml' event='loading configuration'
 [error] path='/etc/graphite-api.yaml' event='loading configuration'
 [error] path='/etc/graphite-api.yaml' event='loading configuration'
 [error] path='/etc/graphite-api.yaml' event='loading configuration'
 [error] index_path='/srv/graphite/index' event='reading index data'
 [error] index_path='/srv/graphite/index' duration=3.0994415283203125e-05 total_entries=0 event='search index reloaded'

I even tried placing it in a different folder and using export GRAPHITE_API_CONFIG=/home/graphite-api.yaml
It still did not work.

The [error] prefix comes from apache -- these are normal events to see when you run graphite-api.
It looks like you're in debug mode though. Normally you should see json-formatted lines. Apart from that, nothing to worry about. Are you having issues accessing the API?

Thanks for the reply Brutasse. I am running it in debug mode hoping to get some insight into the errors. In my graphite-api.yaml, if I use the default graphite finder , and i hit /render?target=test, i see "GET /render?target=test HTTP/1.1" 200 2360 but if i replace it with cyanite finder, i get "GET /render?target=test HTTP/1.1" 500 291. Below is my graphite-api.yaml.
search_index: /srv/graphite/index
functions:

graphite_api.functions.SeriesFunctions
graphite_api.functions.PieFunctions
whisper:
directories:

/srv/graphite/whisper
time_zone: UTC
carbon:
hosts:
<IP_ADDRESS>:7002
timeout: 1
retry_delay: 15
carbon_prefix: carbon
replication_factor: 1
cyanite:
urls:
http://<IP_ADDRESS>:8089
finders:

cyanite.CyaniteFinder
allowed_origins:
*

My cyanite stand alone jar is up and carbon is listening on 2003 and I can successfully insert data into my cassandra cluster. I also did pip install cyanite, and i can see it added /usr/local/lib/python2.7/site-packages/cyanite . Not sure why it wants to complain  about cyanite finder. Please suggest. Below is my cyanite.yaml
carbon:
host: "<IP_ADDRESS>"
port: 2003
rollups:
- "1s:1h"
- "10s:14d"
- "10m:30d"
http:
host: "<IP_ADDRESS>"
port: 8089
logging:
level: debug
console: true
files:
- "/var/tmp/cyanite.log"
store:
cluster: 'c14.test.com'
keyspace: 'metric'
chan_size: 100000 # defaults to 10000
batch_size: 500 # defaults to 500
index:
use: "io.cyanite.es_path/es-rest"
index: "my_paths"
url: "http://<IP_ADDRESS>:9200"
chan_size: 100000 # defaults to 1000
batch_size: 1000 # defaults to 1000

Can you update graphite-api to the latest master? It now provides more debugging information with HTTP 500 response.

Closing this since it's been inactive for quite some time. Feel free to reopen if the problem persists with the latest release.


[SR-16117] Swift default Dockerimage should depend on ubuntu 22.04 (jammy)

Previous ID
SR-16117

Radar
None

Original Reporter
@fabianfett

Type
Bug

Additional Detail from JIRA

Votes
1

Component/s
Docker

Labels
Bug

Assignee
@shahmishal

Priority
Medium

md5: 04be5bcbf02fb803bfbe22b092f39455

Issue Description:
The current default Swift Dockerimage uses ubuntu bionic as the underlying os. Since Swift only supports arm64 starting with focal, users on arm processors can not use docker run swift. Instead they need to explicitly require focal: docker run swift-focal. With the next ubuntu lts release around the corner 22.04 ("jammy"), we want the default Swift Dockerimage to depend on "jammy" directly for Swift 5.7.

Jobs created:

https://ci.swift.org/job/oss-swift-package-ubuntu-22_04/
https://ci.swift.org/job/oss-swift-package-ubuntu-22_04-aarch64/

Swift default is Ubuntu 22.04 - 5.9.1, 5.9, 5.9.1-jammy, 5.9-jammy, jammy, latest


[DOCUMENTATION] missing a colour space in the example (<IP_ADDRESS>. More on colour spaces)

Hi,
In the subsection <IP_ADDRESS>. More on colour spaces, an example is given followed by:
These are in fact the only colour spaces supported by the Pi’s camera system. [...]
However, in the example, only the sYCC and Rec709 are shown. Later, in the Appendix B, in the table 5, for the parameter colour_space, we can see three permitted values: Sycc(), Smpte170m() and Rec709().
I think the colour space Smpte170m() should be added in the example.
Regards,
Vincent

Thanks for pointing this out. I've added the missing colour space, it will appear in the published version in due course...


Role of $field-02 token

$field-02 role column reads “Fields on $ui-02 backgrounds” . This yields a field the same color as it’s  background.  Seems as if it should read “Fields on $ui-01 backgrounds” instead.
Steps to reproduce the issue
Visit the Carbon Design System color usage page

Qs? contact @Maezlin-Avila-Taylor

This is a content bug. It should read: "Fields on $ui-01 backgrounds"


[flake-parts] Allow disabling the autowiring of flake check

https://github.com/numtide/treefmt-nix/blob/b25d1a3c2c7554d0462ab1dfddf2f13128638b90/flake-module.nix#L36
When https://github.com/cachix/pre-commit-hooks.nix already adds a check (it includes a treefmt hook), the check added by treefmt is redundant and will just slow CI down unnecessarily.
An option in the flake-parts module to disable this check would be nice.

Makes sense, I would accept a PR


Checkbox/radio aligned too low

The default checkbox/radio alignment seems to be with the bottom of it's associated label text.  To me, visually this makes the elements seem too low.  The inline variants appear to have the boxes aligned with the middle of the text, which looks better.

What version of Bootstrap? What browser (version and OS)? Screenshots?

Duh - right, sorry.
The v4 Alpha.  You can actually see this in the documentation on both Chrome and Firefox on OS X.

In practice the boxes seem to be aligned to the top:

so it looks to be a documentation/browser bug stemming from _forms.scss:193

X-Ref: #13936, #15791

Some findings:

OS X Chrome checkbox dimensions: 28x28 (native px)
OS X Chrome radio button dimensions: 32x32 (native px)

Currently, in bleeding-edge v4, the strikethrough line of the label text is 1 native px below the center of the checkbox/radio:

(Strikethrough being one possible interpretation of the "vertical center" of text)

For Firefox:

OS X Firefox checkbox dimensions: 24x24 (native px)
OS X Firefox radio button dimensions: 28x28 (native px)

Similarly, the strikethrough line of the label text is currently 1 native px below the center of the checkbox/radio, though Firefox's strikethrough is lower than Chrome's (in a bad way):

(Guess I should find a different metric..)

For Safari:

Safari radio button dimensions: 16x17 (native px)
Safari checkbox dimensions: 14x15 (native px)

Always bummed to find these problems, hah. Seeing it in Firefox, but not in Chrome. Going to close this as a won't fix since it's virtually impossible to get this 100% locked down across browsers. If y'all have any specific ideas for what we could try, I'm all for it though.


Add example Dockerfile to add missing tools to minimal delegate

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ X] Feature
[ ] Maintenance/Chore

This PR adds an example Dockerfile to add all of the tools missing from the minimal Delegate that are found in the full image.
House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


[WIP] Temporal workaround to bypass validation

What this PR does:
Bypass the drops validation on the International Trade form when the question C 2.1 is answered "yes"

Notes
This is a workaround if this change needs to enter as soon as possible, but it is not the best way to solve this problem.
Merge only if you are ok with this workaround.

is this check only on the frontend?

As far I could see in the code, this particular validation was made in the client only.. but I will have to check where and how this information is persisted.. I suggest wait for @rusllonrails  feedback on this issue.

Well done :+1:


Misc fixes to ipallocator & bridge driver about FixedCIDR

NetworkRange() function on which ipallocatore relies
to get the subnet limits has a bug in computing the upper limit IP

in case container subnet is specified (fixedCIDR), bridge driver has to
reserve bridge and gateway addresses only if they belong to the
container subnet

Make ipallocator more robust converting the passed network
to a canonical one before using its string form as a key in its public APIs

Fixes issue reported in docker/docker #14859 comment

Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

LGTM

LGTM


Add online evaluation sample

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

@ahughes-msft, Same thing here please use ignite2024


travis.yml: F25 is EOL, use F27

Signed-off-by: Vadim Rutkovsky<EMAIL_ADDRESS>

No need to updated release notes - test-only change


Create guest developer user & agency for Hacktoberfest

This functionality is to support users creating their own agency-admin user in a shared instance of the O-FISH Realm app.
There is a matching web issue for this feature: https://github.com/WildAid/o-fish-web/issues/197

[ ] Update README to indicate that anonymous authentication must be enabled if you want to host O-FISH in this development model

Create new function regNewAgency:

[ ] If there is already an Agency document with the same name, return with an error that the "Agency already exists"
[ ] Insert new document into the Agency collection
[ ] If there is already a User document with the same email address, return with an error that the "User already exists"
[ ] Insert new document into the User collection
[ ] Return success/error depending on the results

 Create issues for Hacktoberfest guest agency creation

 Implement developer agencies for Hacktoberfest - Realm


Increase kompose unit tests coverage 100%

Codecov Report

Merging #709 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #709     +/-   ##
=========================================
+ Coverage   96.98%   97.09%   +0.1%
=========================================
  Files          29       29
  Lines        2523     2651    +128
  Branches      215      382    +167
=========================================
+ Hits         2447     2574    +127
+ Misses         76       65     -11
- Partials        0       12     +12

Impacted Files
Coverage Δ

browser/pages/confirm/controller.js
78.88% <0%> (-2.93%)
:arrow_down:

browser/services/componentLoader.js
98.78% <0%> (-1.22%)
:arrow_down:

browser/services/data.js
98.55% <0%> (-0.46%)
:arrow_down:

browser/model/helpers/hash.js
100% <0%> (ø)
:arrow_up:

browser/model/devstudio.js
100% <0%> (ø)
:arrow_up:

browser/services/request.js
100% <0%> (ø)
:arrow_up:

browser/model/cygwin.js
100% <0%> (ø)
:arrow_up:

browser/main.js
100% <0%> (ø)
:arrow_up:

browser/model/installable-item.js
100% <0%> (ø)
:arrow_up:

browser/services/platform.js
100% <0%> (ø)
:arrow_up:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717fba7...f6fdcd7. Read the comment docs.


capt 1571/extract form object for qualification

This PR is currently blocked waiting on https://github.com/DFE-Digital/claim-additional-payments-for-teaching/pull/2663 which is blocked on me getting access to the repo! Once I have access I'll reissue these PRs.
There's some noise in this PR's diff as it's based off my pr branch so probably best to review these two commits directly

Extracts form object for qualification step
Remove callback

Hopefully on Monday I'll have access to the repo and can sort out these weird PRs!
This pr has two separate commits which should be reviewed separately. I'm happy
to break the commits out into separate PRs if that's better.
The main changes are:

break out a form object for the qualification step
remove a callback from the eligibility model

There's a little more details in the commit message.
I'm not familiar enough to know all the implications of removing the callback from the eligibility model but from what I can tell it seems safe todo and the test suite passes, let me know if I'm wrong and I can drop that commit.

Closing this and reopening a pr that's not from a fork so ci runs


Cleanup/Merge | Remove Reliability Section

Description: After some discussion with @saurabh500 we came to the conclusion that it's just not beneficial to have the ReliabilitySection code in the netfx project. It is only included in debug builds (which we don't even use for CI builds anyhow), and it makes massive clutter in the code base. Although I've experimented with some ideas to leave it in place but cleanup the code, simply removing it is probably the easiest solution.
Testing: Project still builds without it and since it provides no functionality, it won't break anything to remove it.

This looks good to me. Are the TdsParser.ReliabilitySection struct definitions due to be removed in a future PR?

These can be deleted as well in SqlDataReader:
https://github.com/benrr101/SqlClient/blob/431494fb30d153d4b7c7690a9b726d60e9dbbea9/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDataReader.cs#L264

@cheenamalhotra @mdaigle Can this be merged? That would help with #2953


Put an "give all commands" in the web editor

i wanted to create an owner rank but i have alot of plugins and who wants to sit there for an hour just clicking away at each individual command, if there is already a solution to this, please let me know

You need to learn what wildcards are.
Just add * and you'll get every permission. It's not really recommended
as you'll inherit some unwanted permissions so use it at your own risk.
On Fri, 20 Mar 2020, 12:52 pm rockey86<EMAIL_ADDRESS>wrote:

i wanted to create an owner rank but i have alot of plugins and who wants
to sit there for an hour just clicking away at each individual command, if
there is already a solution to this, please let me know
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lucko/LuckPermsWeb/issues/167, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACSYFB56JDHPFA42XWO4T6LRILD53ANCNFSM4LP4J5JQ
.


remote-it version v2.9.6

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?


Remove and uninstall styled components

issue #51
Remove  styled components code from
-app/src/components/ChoiceCard.tsx
-app/src/routes/ChoiceBoard.tsx
Uninstaled styled components with *npm uninstall --save styled-components

Hi @poleselfg ! Nice PR, thanks for submitting your contribution!
I'm reviewing it now and will come back soon to merge or request changes.


Safe Parse on a ZodFunction

Is there a way to do safeParse with a ZodFunction? I would like to avoid throwing errors
const unknownData = 'foo' // could be from user input, or api, or somewhere else
const doSomethingSchema = z.function()
    .args( z.literal( 'hello' ) )
    .returns( z.literal( 'hello world' ) )

const doSomething = doSomethingSchema.implement( x => `${x} world` )
doSomething( 'hello' ) // => 'hello world' // works
doSomething( unknownData ) // throws error

// maybe something like this
const safeDoSomething = doSomethingSchema.safeImplement( x => `${x} world` )
safeDoSomething( 'hello' ) // => SafeParseSuccess // works
safeDoSomething( unknownData ) // => SafeParseError // doesn't throw error

Was this ever revisited? I'd love to see a safeApply method on ZodFunction but I don't know if I should open up another issue or not.

@yonkeltron same here
@JacobWeisenburger why did you closed this issue ?
I can't find any safeImplement or safeApply

Since it's been two years and we still have no explanation as to why the issue was closed, can we reopen it? This feature sounds lovely.


Ordered mode for s3_iter_results

For a local project, I needed to iterate over a bucket's contents in order (they represent time series data), so I added a flag to switch between use of imap and map in s3_iter_results. I thought my changes might be more generally useful.
Because requiring ordered consumption makes it more likely that one or more producer queues will get backed up and cause a memory overflow, an additional maxresults option is added to limit the number of outstanding fetch tasks.

ping @samkaufman, when you plan to finish PR?

ping @samkaufman, are you planning to finish PR?

@menshikh-iv Yes. Thanks for the ping. I'll include documentation and tests.
@mpenkov Replying to previous feedback:

key_limit controls the total number of keys yielded before s3_iter_bucket returns, whereas maxresults controls the total number of keys in memory at any given time.
I don't believe maxresults does terminate early, whereas key_limit will. If it does, that's a mistake on my part.
Using a BATCH_SIZE constant won't suffice for workloads where, say, 1000 items is too large to fit in memory. The amount of memory consumed is not dependent on just the number of items, but also the size of the items. For example, I am using smart_open with a deep learning workload, where each item can be several hundred megabytes. I don't think this is a case of the user needing to understand implementation details of the library, and I don't know that there's a good way around requiring the user to understand something about memory in this case.
The proposal to yield in batches as opposed to limiting the number of produced keys has the downside of non-overlapping I/O at the end of a batch. For instance, at batch item 999 of 1000, only one request can be outstanding. My proposed PR allows, for example, items 999, 1000, and 1001 to all be in-flight even if maxresults is set to 1000.

@samkaufman great :+1: don't forget to resolve merge conflict first, please ping me when you are done with PR.

@samkaufman Please add tests for your new functionality.

@mpenkov Yep. I haven't forgotten. I'll ping @menshikh-iv when done.

Quick update: Been beating my head against Python issue #33997. Not sure what a good solution is yet.

How does that issue affect smart_open, e.g. does it hang our tests or do something else nasty?

Exactly. multiprocessing.Pool.terminate hangs during tests. I don't think I'm doing anything that shouldn't be allowed by multiprocessing, but this is somehow a side effect of my changes, so I expect there's a workaround. I'll have to revisit when I have a second (and some rest).

Hi @samkaufman, sorry for keeping this PR idle so long.
After thinking about it some more, I think the feature that this PR adds would belong more to the level above the smart_open library (application level) as opposed to the library itself. I think so for two reasons:

This new feature satisfies a narrow and very specific use case.
This feature could be implemented at the application level, above smart_open. The task can be generalized as: sort the output of a generator, keeping at most max_in_memory items in memory. In this specific case, the generator is the s3_iter_bucket function from smart_open, but it could be any generator in theory.

For the two reasons above, I'm closing this PR. Sorry for the long delay in getting back to you. I hope this doesn't discourage you from future contributions.

Hi @mpenkov,
Thank you for getting back to me—I appreciate it—and no trouble about the delay.
This cannot be implemented as you described because memory will still be allocated and held internally by smart_open, no matter what is done with the results of the generator. Put another way, smart_open will continue to make requests and hold their results, even if the generator is never consumed by the application.


Workflows Documentation

Sections

Passive

Triggers

Active

Overall workflow menu

define the 3 types of workflows

passive: triggered async on some event in the proxy
active: user trigger for request/responses
convert: user trigger for bytes (user selection)

enabled
download / import

Community workflows

Concepts

Logs (where)
Data types

Bytes
String
Bool
Integer
Request
Response

Colors

Yellow: Start/end
Green: Execution flow nodes
Red: External systems / code
Blue: rest

Examples in User Guides

Nodes
Unintuitive concepts

Data & variables
Examples like shell to JS (not really possible right now)
Passive cannot modify the request/response right now, they are ran async
JS runtime is quickjs (https://bellard.org/quickjs/)

Linked prs #89 and #90


transaction details did not get captured correctly

Priyank on telegram asked me to create the issue here. He said "this looks like an issue on cardano explorer graphql end...the UTXO seems to be alright, but the transaction details did not get captured correctly..."
transaction ID : 90187ad0b966f3550c4d2e2d155dc5f389540a93a6043bdc0719ec7c7a4e1e7c
To DdzFFzCqrhsu1uKFD4R9zHvdwziXKYVgYWiVfK9XRPoSWRJ1peUByaGPY8VnNmGd8RfVyS6tKMBve8o2yPYZHbnfgiCqGm8tMhDR2Knd
Is showing different amounts on:
https://seiza.com/blockchain/transaction/90187ad0b966f3550c4d2e2d155dc5f389540a93a6043bdc0719ec7c7a4e1e7c
and
https://explorer.cardano.org/en/transaction/?id=90187ad0b966f3550c4d2e2d155dc5f389540a93a6043bdc0719ec7c7a4e1e7c
19577.651648 on cardano explorer and 27565.686037 on seiza

Thanks @Logic999. Duplicate of https://github.com/input-output-hk/cardano-explorer-app/issues/304. I'll raise the priority on this internally, as it's clearly a sticking point.

Hey @rhyslbw
Can we keep the issue open until fixed?
Its easier to let people be pointed to (outside IOHK world) when hitting this issue - so that they know its known and being worked upon, instead of internal tracker which community has no visibility on :)

This issue was fixed by #304

Deployed to the mainnet instance


Revert bad commit, fix test byte string

What I'm doing in my repos is that I submit everything though PRs, and always wait for travis to succeed before merging.
If the change is trivial or urgent, I just merge myself after that.
If I'm not totally sure about the change, I leave the PR open until someone reviews it and merges it. If no-one does it after 1-2 days, I merge myself.
I suggest that you do something similar, it prevents lots of mistakes.

That all sounds good. I wasn't initially sure if you had enough time to look through the pull requests, but I'll make sure to utilize them more often now.

So, let's merge this one!


HTTP Queries

By visiting /query?query=querytext a user can query the MQE. (NaN in result causes a JSON encoding error).
@jeeyoungk @achow

LGTM


iOS crash fix

iOS build crashed on startup, build not crashing version for AppStore review.

Could you please test and close if it okay.
Android Apk Download link: https://install.appcenter.ms/orgs/esteem.app/apps/esteem/distribution_groups/beta_testers
IOS Ipa Download link:
https://install.appcenter.ms/orgs/esteem.app/apps/esteem-1/distribution_groups/beta_testers
Thank you. @feruzm


Establishing Connection tools

Includes necessary utility function to work around the autofix cyclic functionality that was getting in the way.
Still in draft due to existing bug, see comment below.

Acknowledging there is one critical bug present in dev and thus also here, whereby clicking on a RoadSegment to grab a RoadPoint results in thereafter not being able to use a RoadPoints's built in 3D transform gizmo. Everything gets treated as a drag. I will edit this PR once that is resolved. With that being just a (albeit nasty) UI interaction bug, all tests we currently have are still passing.
Checking out commits one-by-one, this issue first presented itself and has been there ever since: commit 17a16f4f1cd28423d7055d899031c17d1cea0552. Unfortunately that was one of the larger commits, so will need to dissect it further.

Need to call it a night after a fair bit of troubleshooting. In short, the issue remains:

Try selecting the roadpoint via the hierarchy viewer, or by clicking the blue square
Try manipuating the built-in 3D gizmo, it should work fine.
Now try clicking on the road segment to trigger an auto-selection of the nearest roadpoint
Now try using the built-in gizmo, you will be unable as it will continually be trying to do a "drag" selection there and after
Now select the RoadPoint by clicking the blue square or via the hierarchy viewer
Using the 3D gizmo should now again work as intended.

Basically it boils down to treating the click event as consumed or not:

If marked not consumed, then even though we set the selection, the built in editor immediately overrides that selection based on what the click would do on its own. ie clear selection if nothing underneath, or select the mesh/object underneath the mouse (if any)
If marked as consumed: We get stuck in a drag state. I'm not 100% why yet, but it comes down to what I think is an issue of 3D gizmos not marking their own clicks as "consumed". We are doing the selection change on release only, and that's only after first checking that the pressed position hasn't changed since the release position (to support dragging, such as any manipulation of the 3D gizmo). So if we mark the initial press as consumed, we completely disable any use of built in gizmos. But if we don't mark it, then we get stuck in the weird drag state where it's waiting for its ending "consumed" release press later.

I'll need to keep thinking on this. We may just be simply approaching this the wrong way, and need to roll up sleeves and actually update the gizmo mesh to include half of road segments in each direction. The simpler fallback would be to revert to the way we had it before, where we just tag a node to be re-selected right after the built in editor does it thing (I'm more likely to do that in the interest of time).

Ok I've reverted the selection code - so I'd say it's now ready for review! Side note, I am expected to update documentation separately, so no need to comment on that

Acknowledging this issue I found, regarding making connections that go in opposing orders (ie prior pt is set as the prior path on the newly connected RP, instead of prior connecting to next). Not sure yet if this is an issue of the connection tool itself, or a wider consequence of the restructure we engaged with for this 0.4.0 release. Ideally we do resolve this before merging though.
https://github.com/TheDuckCow/godot-road-generator/assets/2958461/e73f5f3d-bf9c-4162-8081-45dcb6fae2fc
At a first look of this video, it seems like the correct prior and next point paths are indeed being assigned to the property values, but it's clearly not being handled correctly and leading to duplicative geometry.

The newly developed functionality was focused on a new hierarchy for creating roads as well as some new tools for selecting, adding, and removing RoadPoints. So, I approached these tests from the angle of how how things ought work given how they used to work.
Tests:

Recreated previous process of adding a 2x2 road using new functionality. New behavior was to add a RoadManager. Then select it and add a RoadContainer. Then, add a 2x2 Road.

(Previous behavior was to add a RoadNetwork. Then select it to reveal a "Create" menu in the 3D view, which contained a "2x2 road" selection)
Created a scene and clicked "+" button in the Scene dock to add a new node. Searched for "RoadManager" in the node list. It showed up as expected along with RoadContainer, RoadIntersection, RoadLane, and RoadPoint.
Selected "RoadManager" and clicked "Create" to add it to the scene.
Selected RoadManager in Scene dock, which revealed a new toolbar in the 3D view.

Toolbar lacked tooltips to explain what the buttons did. But, there were 3 buttons and testing revealed that they were: 1 Select RoadPoint, 2 Add/Connect RoadPoint/Segment, 3 Delete RoadPoint/Segment.
There was also a "Roads" menu with the following items: "Refresh roads", "Select container", "RoadContainer", "RoadPoint", "RoadLane (AI path)", "2x2 road".

Went to "Roads" menu and clicked "RoadContainer". A new RoadContainer named "Road_001"was added as a child of the RoadManager in the Scene dock. The new RoadContainer was selected and a yellow warning icon was shown next to it that read: "Node configuration warning: Add RoadPoint nodes as children to form a road, or use the create menu in the 3D view header".
Went to the "Roads" menu in the 3D view, again, and clicked "2x2 road". 2 RoadPoints were added to the 3D view with a segment drawn between them. The 2nd RoadPoint was selected both in the Scene dock and the 3D view. A blue lane widget with blue handles was displayed on the selected RoadPoint and pink magnitude handles were also shown.
THE YELLOW NOTIFICATION ON THE ROADCONTAINER DID NOT GO AWAY WHEN THE 2X2 ROAD WAS ADDED. Toggling RoadManager/RoadContainer/RoadPoint selection in Scene dock and 3D view had no effect. Notification was cleared by going to the "Roads" menu and clicking "Refresh roads".

(continued in next post)

Tested new RoadPoint toolbar in the 3D view.

Observed that the buttons were identical to Godot's path editing buttons.
Toggled between each of the buttons and observed that the icons changed (slightly) to indicate which button was selected.
Select RoadPoint button caused 3D cursor to select objects in the 3D viewport as it normally would.
Add/Connect RoadPoint/Segment button performed two tasks. 1 Add a new RoadPoint, 2 Connect two RoadPoints.

The behavior was determined by the current selection and the location where the user clicked.
If an end RoadPoint was selected and the user hovered over another end RoadPoint, then blue dots were drawn on the source and destination RoadPoints and a blue line was drawn between them. If the user clicked on the RoadPoint where they were hovering, then a segment was created between the source and destination.
User could only connect to RoadPoints at the end of a chain. They could not connect to RoadPoints that were already fully connected.
If user selected a middle RoadPoint and engaged the Add/Connect RoadPoint/Segment button, then red dots were displayed on the source and destination RoadPoints and a red line was drawn between them. Clicking the destination RoadPoint resulted in the segment being removed between them.
THERE WERE SEVERAL INCONSISTENCIES IN THE WAY THIS BEHAVIOR WORKED. DUE TO LIMITED TIME FOR TESTING, I WON'T GO INTO MUCH GREATER DETAIL. BUT, DEVELOPER SHOULD CONSIDER CODING FOR SEVERAL SCENARIOS INCLUDING BUT NOT LIMITED TO:

Create road with 3 RoadPoints.
Select 3rd RoadPoint. Engage Add/Connect button and try disconnecting and re-connecting 2nd RoadPoint. (Cannot re-connect them.)
Select 3rd RoadPoint. Engage Add/Connect button and try disconnecting and re-connecting 1st RoadPoint. (Doesn't yield expected result.)
Repeat above steps. But, try selecting the 1st RoadPoint and disconnecting/re-connecting the 2nd and 3rd RoadPoints. (Doesn't yield expected result.)
Each one of this scenarios seemed to have erratic behavior and each outcome differed slightly from the others in terms of whether a blue or red connector line was or wasn't displayed and whether a connection could be restored.
If the above scenarios were prevented, then the developer wouldn't have to facilitate them. So, that's always an option.

Delete RoadPoint/Segment button allowed the user to delete RoadPoints.

Selected a RoadPoint and engaged Delete RoadPoint/Segment button.
When hovering over segments, a red "X" was displayed on the nearest RoadPoint. When the segment was clicked, the RoadPoint was removed.
(If there was no segment, then a RoadPoint could not be removed with this tool.)

Tested each of the elements in the "Roads" menu. Limited this testing for brevity and time.

Successfully added RoadContainer, RoadPoint, RoadLane, and 2x2 road.
WHEN A ROADLANE WAS ADDED, IT ACTIVATED A "ROADLANE TOOLBAR" IN ADDITION TO THE "ROADPOINT TOOLBAR". (BOTH WERE DISPLAYED SIMULTANEOUSLY.)
IT WAS UNCLEAR HOW TO INTERACT WITH ROADLANES. WERE THEY ATTACHED TO ROADPOINTS? COULD THEY BE MOVED SEPARATELY? (THEY WERE IMMOVEABLE.) SHOULD THEY BE CHILDREN OF THE ROADPOINT OR ROADCONTAINER? SHOULD THE RED "X" TOOLBAR BUTTON DELETE ROADLANES? (IT DELETED ROADPOINTS.)
Maybe the RoadPoint toolbar should be hidden when the RoadLane toolbar is shown and vice-versa.

Confirmed some unexpected behavior with RoadPoint gizmo. Although, it was slightly different than the reported behavior.

When segment was clicked, nearest RoadPoint became selected. But, blue lane widget WAS NOT displayed. Although, blue lane widget handles WERE displayed.
Observed that lane widget refreshed if user hovered over the blue handles or clicked on the RoadPoint selector. (Methinks this is an issue centered around plugin.gd on_selection_changed. Something needs to trigger a lane widget refresh.)
Observed that dragging the blue handles added and removed lanes as expected.

Developer described the following issue: "Clicking on a RoadSegment to grab a RoadPoint results in thereafter not being able to use a RoadPoints's built in 3D transform gizmo. Everything gets treated as a drag."

Unable to confirm or recreate this issue. When a segment was clicked, the nearest RoadPoint became selected. The RoadPoint's transform widgets then behaved as expected. Rotate, Translate, and Add/Remove lanes all worked.
Observed two unusual, but not necessarily unexpected behaviors when click-dragging.
First, if user click-dragged on the surface of a segment, a dragbox appeared and the selected item became deselected. One might have expected a different result. But, this outcome seemed normal and acceptable.
Second, if user click-dragged an unselected RoadPoint selector, then it remained unselected and the selected RoadPoint was dragged, instead.
One might expect a RoadPoint to become selected by a click-drag on its selector element. However, it only became selected with a click-release. Once the mouse button was released, the RoadPoint became selected. Then, it could be click dragged.
To the best of my knowledge, the developer had limited control of this behavior since some of it was pre-determined by Godot's internal processes. Some events were triggered on mousedown and others on mouseup. For instance: In the scene dock, the visual selection changed on mousedown. But, the "selection changed notification" may not have occured until mouseup.
This odd behavior was observeable in the 3D viewport. When changing selections in the Scene dock, the built-in 3D transform widget jumped immediately to the new selection on mousedown. But, the plugin widget didn't move to the new selection until mouseup.

Recommendations/Suggestions:

Update RoadContainer warning message behavior so that the warning goes away consistently when RoadPoints are added.
Add tooltips to buttons on "RoadPoint toolbar" in 3D viewport.
Review and update behavior of Add/Connect RoadPoint button. Sometimes blue connector line isn't shown when it should be. Sometimes red disconnector line is shown when it shouldn't be or it doesn't perform the expected disconnection between a length of several RoadPoints.
Review behavior of RoadLane toolbar. Consider only showing it when a RoadLane is selected and consider hiding RoadPoint toolbar when a RoadLane is selected.

Thanks a ton @bdog2112 for the detailed review! A number of good points and identifies some things I didn't consider would be confusing (like the road panel being active with RoadLanes selected) but you're totally right, they are not meant to work together at all.
I'll be going through all this feedback and making according changes. On the point of RoadLanes, just to be clear the point of having them in the menu is only so that they are quick and the user is aware they exist. There's no "correct" way of using them really, it's up to the developer to make any use of them at all. They just provide a path which has a canonical "forward" direction and a visualizer to match.
As for the warning triangle notification: I added the convenience "check if need refreshing" function but seems to be overly picky right now, needing extra refreshes when they aren't actually needed. Not sure if I'll have that resolved this round, and generally I'd prefer it was over-complaining that refreshes were needed rather than not warn of meshes being outdated, but indeed a goal to have it improved.
Will seek to improve what I can before the end of this weekend and hopefully we'll be in good-enough shape to call 0.4.0 a launch.

Fixes addressed with recent commits:

Adding 3 RP's then disconnecting the last one created a bad state. Was due to a typo in the "dot" function
Toolbar hides when RoadLanes are selected
Toolbar now has tooltips for all functions including sub menus
Can now delete a RoadPoint if the delete mode is active and the current selection is unconnected to anything (unless you hover over another area that is connected, or your mouse is too far away). Though this still isn't that convenient that you'd have to select said point first.

Open issues in my mind not yet addressed, and may be better for a v0.4.1 release:

Improving the delete function to actually run as a dissolve, although this is the most egregious issue and leaves many errors and even a bad state of nodes in the editor.
Attempt to refresh RoadPoint handles at the same time the gizmo refreshes.
Triangle warning to refresh being too aggressive, doing some investigation but not resolved yet

Now addressed: a hack but end-user very functional and reliable dissolve function. Going to merge this in the meantime and then work on making connections between different RoadSegments after.


Third party plugin used in website are not run

Example:
let take a site:
https://www.chubbiesshorts.com/products/the-arnolds
if inspect the website, and search for "yotpo-main-widget" class, the dynamic html content generated by this yotpo is not not rendered. Can any one help me?

@bikash615 Did you even manage to solve your issue?


qat: 4xxx: split generic resource to compress and crypto

VFs derived from a PF might be capable of crypto or compression only depending on the PF config. we need to detect this and report the resources accordingly (qat.intel.com/generic) is not a good fit anymore.

requires 5.17 kernel -> moving to backlog


Control 2f gripper in RVIZ/Gazebo simulation

Hi, I'm able to install the robotiq 2f 140 gripper to ur5 model and do path planning or move ur5 robot in gazebo/ rviz, but don't know how to control this gripper to close and open, is there a specific code example? Thank you so much!

hi,I've been combining gripper with ur5 recently，but i get some trouble ,The gripper is shaking all the time，would you like to tell me the steps to  combine gripper and ur successfully? thank you so much!

Hi, i tried the robotiq_2f_gripper_action_server on my real UR5 robot, but it doesn't seem to work.
It gives me a warning gripper could not accept goal because the gripper is not yet active, but I don't know how to activate it, it seems that I need to publish something in the /input topic

You can control it by using a SimpleActionClient (http://wiki.ros.org/actionlib_tutorials). It works as following: http://wiki.ros.org/actionlib#Client-Server_Interaction
For that, you'll need to:

add the  gripper controller to the .yaml file as following:
# Gripper controller gripper_controller: type: effort_controllers/GripperActionController gains:   finger_joint: {p: 10,  d: 0.1, i: 1, i_clamp: 1} joint: finger_joint #important to call it joinT in the singular! action_monitor_rate: 20 goal_tolerance: 0.002 max_effort: 100 stall_velocity_threshold: 0.001 stall_timeout: 1.0

the type must be a effort_controller or  a position_controller, according to the interface interface specified in the transmission [file] (https://github.com/ros-industrial/robotiq/blob/66961ec6b6c9c493f13410d16ce32cea1648babf/robotiq_2f_85_gripper_visualization/urdf/robotiq_arg2f_transmission.xacro#L7)

Send goal commands according to the message format GripperCommandGoal

Note: if grasping an object and commanding the gripper to fully close, the position won't be reached (gripper doesn't close fully because of the object). As consequence, won't be a result message returned from server.


[QUESTION] Preventing fetching django models

I want to prevent this query from executing, because I really just want raw results (id field mostly).
https://github.com/Sparrho/bungiesearch/blob/master/bungiesearch/__init__.py#L185
The reason for this is that after I search ElasticSearch I need to perform more complex logic in our database with the ids before I can decide if they should be loaded from the database and loading all those models from is a performance cost when I may only actually end up wanting to materialize half of them.
Looking at the code, it's not exactly clear. I'll keep looking and close this if I figure out how.

The answer is incredibly simple, to use custom_search instead of search. That is located here, https://github.com/Sparrho/bungiesearch/blob/21cf0cf6e7a7e5c77b904f773f2c3b1cc173e14d/bungiesearch/managers.py#L26

Yes. Alternatively, you can also take a slice with the step parameter set to True, as follows:
lazy = Article.objects.search.query('match', _all='Description')
print len(lazy) # Prints the number of hits by only fetching the number of items.
for item in lazy[5:10:True]:
    print item # Will print an ES Result object

I'm also just realizing that this functionality is not documented, although it is in the tests.


ins Doesn't work with tools.

It should do Object:IsA'Tool'or Object:IsA'HopperBin' and parent it to the player's Backpack.

I assumed all things inserted were inserted inside of a model....

Tested and confirmed to work properly with tools.


Create template-pi-commander repo

Create and seed a new template repo from Pi Commander: Getting Started

Seeded template-pi-commander

Seeded template-pi-commander


Handle objects that have omitted empty values

If a policy specifies an empty array or map in its object definition
and the property is set to omitEmpty, then the controller will
mark the policy as noncompliant when it compares the policy with the
object retrieved from the API since the property wouldn't be returned.
This commit makes it so that an omitted array or map value is equal to
it being empty.

/unhold


Adding CONTRIBUTING.md

Re https://github.com/symphonycms/docs.getsymphony.com/issues/5
I think the project would benefit from having this file. Github's integration with it is cool and it would state clearly what we want from a PR.

PSR0/1
Commented code
No whitespace changes

Any other suggestions ?

separate pull requests for each topic (?)

I think that cleaning up trailing whitespace should be OK or even encouraged, but that should always be in a dedicated commit.

separate pull requests for each topic (?)

Yes, if topics are really different, e.g. "compatibility" and "feature enhancement/fix".

but that should always be in a dedicated commit.

Yeah for sure. I am not against it, just not mixed with other changes.

Here's something prepared earlier

Awesome Brendan, it will be a great starting point. I'll see what I can do.

Closed via d68b132606c3aab638e87dd55cfcc68a62741b5a


calicoctl status is affected by bash 4.3 version

Hello there,
I am using CoreOS 1068.8.0 which uses bash version 4.3 on which there is a bug https://bugs.archlinux.org/task/39533. This seems to affect to the output of some commands of calicoctl. Regardless of this problem, calico seems to be working fine.
$  sudo ETCD_AUTHORITY=<IP_ADDRESS>:2379 calicoctl pool show
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
+----------------+-------------------+
|   IPv4 CIDR    |      Options      |
+----------------+-------------------+
| <IP_ADDRESS>/16 | ipip,nat-outgoing |
+----------------+-------------------+
+--------------------------+---------+
|        IPv6 CIDR         | Options |
+--------------------------+---------+
| fd80:24e2:f998:72d6::/64 |         |
+--------------------------+---------+

$ sudo ETCD_AUTHORITY=<IP_ADDRESS>:2379 calicoctl status
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
sh: symbol lookup error: sh: undefined symbol: rl_signal_event_hook
calico-node container is running. Status: Up 2 hours
Running felix version 1.4.0rc2

IPv4 BGP status
IP: <IP_ADDRESS>    AS Number: 64511 (inherited)
/bin/sh: symbol lookup error: /bin/sh: undefined symbol: rl_signal_event_hook
Couldn't connect to bird.
IPv6 BGP status
No IPv6 address configured.```

I know this issue is related to the bug in bash rather than to you but I wanted to let you know.

Thanks a lot for tracking this down @hectorj2f.  Someone else had reported the issue as #1063 but we hadn't managed to find the cause.  I've copied your comment over there and I'm going to close this one as a dupe so we get the whole trail.


Closing the last tab doesn't close the Terminal

From #460:

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

You could disable the tabs ability to close when it is the only tab, so to exit you must click on the close button on the window itself

With "alwaysShowTabs": true, the terminal is closed after a middle/wheel click at the last tab, but it takes about 3-5 sec or more.
(nothing happens when clicking the close button of the last tab).

Do we settle what is the expected behavior?

@mdtauk that seems like a good and reasonable setting, like preventing accidental closing with Ctrl+W.
@tkmikan I believe the behavior you're seeing is that the terminal actually crashes when you middle click the last tab. I believe that fix is #648, though that just prevents closing the last tab with middle click.
Should closing the last tab with the tab's close button and Ctrl+W be enabled, we should also make sure it's possible to close the last tab with middle-click again.

I believe this is done? Somebody fact-check me?


Update Circle CI configuration

[x] Run HLint properly on CI
[x] Use another Docker image
[x] Move a file to a directory (as suggested in Circle CI)

Done in PR #57


Issue/cq 4253537

Fixed Issues? CQ-4253537
Tests Pass? Yes
Documentation Provided? Yes (code comments and or markdown)
Any Dependency Changes?  No

Codecov Report

Merging #295 into development will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             development     #295   +/-   ##
==============================================
  Coverage          82.24%   82.24%
  Complexity           858      858
==============================================
  Files                 81       81
  Lines               2737     2737
  Branches             508      508
==============================================
  Hits                2251     2251
  Misses               199      199
  Partials             287      287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6657d03...df4f89a. Read the comment docs.

@msagolj - could you set a title for this PR and a bit of a description of the fix?

added title and description.


Change OpenAPI generation to not use setter directly

Hey, I included your changes in the @effect/platform rewrite MR along with update of the schema-openapi lib. I'm gonna close this one. Thanks a lot for your contributions 👍. I tagged you in the release notes.


refactor: generate 1wg-charters files via celery

The main goal of this PR is to update the 1wg-charters.txt and 1wg-charters-by-acronym.txt files via celery tasks instead of cron jobs. The cron job worked by using wget to retrieve a datatracker URL that generated the files. This was done once per hour and cached for an hour each time using the slowpages cache.
As a result, the slowpages cache is effectively always holding on to the data generated by the last run of bin/hourly and the view itself is always served from that cache except when the cron job regenerates it.
This seems needlessly baroque, so I've refactored the work at generating the charters files entirely out of the views and into a task. The views then simply grab the file the task updates and hand that back in their response.
The new method has a bunch of benefits. It avoids collecting the group data twice (the views gathered the same data twice, the task does it only once). It avoids the small chance that the charter data is occasionally an extra hour out of date depending on system load (the cron job might make its request at very slightly less than an hour since the previously cached value). It entirely moves the purportedly expensive data gathering out of the view.
Important: I did a careful comparison of the output of the old and new code and there are a couple of differences. Most notably, the groups in 1wg-charters.txt are sorted alphabetically by acronym within each area. Before, they were (to my eye) random within the area. This seems like an improvement to me, but it is a change.
Second, there were some \r\n line endings in the old output - I assume they were bleeding in from the charters. These are converted to \n by the new rendering path. This seems like an absolute win to me, but again it's a change.

Draft right now because I need to update tests

Acknowledging the ordering and whitespace changes. That might disrupt some people doing diffs for a day, but the tradeoff seems the right one.


Add sum of Nth term of Geometric Progression under General Maths

Is your feature request related to a problem? Please describe.
There is a calculator to find sum of nth term of a AP but no such for GP.I want to add that.
Describe the solution you'd like

A clear and concise description of what you want to happen.

issue is already opened for the same

/assign

#270


Next step in HDF5 separation - moving att HDF5 info to libhdf5

Part of #856.
Starting to move hid_t elements from nc4internal.h to hdf5internal.h. In this PR I do the attributes.
No effect on library operation, just moving these pointers to libhdf5 so that they are not in libsrc4.

Reviewing now, thanks!


Prevents the usage of .svg files from stylesheets via url()

Running into this problem when using the plugin
✘ [ERROR] Cannot use "some/path/to/my.svg" as a URL

    path/to/stylesheet.css:14601:30:
      14601 │   background-image: none, url("some/path/to/my.svg");
            ╵                               ~~~~~~~~~~~~~~~~~~~~~

The underlying cause is because this plugin treats all ResolveKinds as equivalent, meaning that url()s in CSS files will be referencing JS files which errors out.
The fix would be to likely restrict to handling just the following
import-statement
require-call
dynamic-import
require-resolve

as these will actually be from within JS by writing an onResolve fn that narrows the transformation.
Would a PR be accepted?

Thank you for flagging this! Yes, if you're able to submit a PR, I can create a new release for it or I can try to fix the issue.

@kazijawad @hibachrach Created a PR that hopefully fixes this problem! let me know if there's anything you'd like me to update.

Thank you for your changes @smol-honk.
After looking into it a bit more... I wonder if the default case should only return external: true as done here: https://github.com/kazijawad/esbuild-plugin-svgr/blob/main/index.js#L16-L18
I don't think we want to assume the user will always want to resolve it as an absolute path, but let me know if I'm missing something.

@kazijawad that sounds good to me! I think i added specific paths because I wanted to make sure it grabbed the right asset, but I think it's totally dependent on how the project is structured and not necessarily a svgr plugin situation.

I published a new version of the plugin, which should resolve this issue. I'm going to go ahead and close it now, thank you both for the help!