x/tools/cmd/guru: implements output is strange when cursor is over the interface keyword

For a simple main.go file:
package main

type Fooer interface {
	Foo() string
}

type Int int

func (Int) Foo() string {
	return "foo"
}

func main() {
}

When I run an implements query with the cursor over Fooer, I get reasonable output:
$ guru -json implements main.go:#40
{
	"type": {
		"name": "github.com/zmb3/foo.Fooer",
		"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:3:6",
		"kind": "interface"
	},
	"to": [
		{
			"name": "github.com/zmb3/foo.Int",
			"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:7:6",
			"kind": "basic"
		}
	],
	"method": {
		"name": "func (Fooer).Foo() string",
		"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:4:2"
	},
	"to_method": [
		{
			"name": "method (Int) Foo() string",
			"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:9:12"
		}
	]
}

However, when the cursor is moved a few bytes to the right (over interface) the output looks much different:
$ guru -json implements main.go:#50
{
	"type": {
		"name": "interface{Foo() string}",
		"pos": "-",
		"kind": "interface"
	},
	"to": [
		{
			"name": "github.com/zmb3/foo.Fooer",
			"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:3:6",
			"kind": "interface"
		},
		{
			"name": "github.com/zmb3/foo.Int",
			"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:7:6",
			"kind": "basic"
		}
	],
	"from": [
		{
			"name": "github.com/zmb3/foo.Fooer",
			"pos": "/Users/zbergquist/src/github.com/zmb3/foo/main.go:3:6",
			"kind": "interface"
		}
	]
}

It seems like guru is now identifying the selection as an anonymous interface and not the type declaration for the Fooer interface.
I'm finding the behavior in the latter case to be difficult to build tooling around, mostly because:

The type.name field is long and hard to read for anything but the most simple interfaces
The extra to entry makes it seem like there is an extra interface in the program
The type.pos field is no longer populated

The guru implements mode calls findInterestingNode to get the selected type. findInterestingNode stops at the type node and does not continue to the type spec (*ast.TypeSpec) (if there is one).

This effect can also be observed with a describe query (describe also calls findInterestingNode):
fun.go:
package main

type Fun func()

func main() {}

Output of guru describe fun.go:#20 (selects the type name):
…/fun.go:3.6-3.8: definition of type Fun (size 8, align 8)
…/fun.go:3.6-3.8: No methods.

Output of guru describe fun.go:#25 (selects the func keyword):
…/fun.go:3.10-3.15: type func()

The fix to your problem would be to continue to the type name, if the type node occurs in an *ast.TypeSpec:
case *ast.ArrayType,
	*ast.StructType,
	*ast.FuncType,
	*ast.InterfaceType,
	*ast.MapType,
	*ast.ChanType:
+	// Continue to type name, if possible.
+	if spec, ok := path[1].(*ast.TypeSpec); ok {
+		path = append([]ast.Node{spec.Name}, path...)
+		continue
+	}
	return path, actionType

For an example, similar to yours:
iface.go:
package main

type Iface interface {
	M()
}

type T int

func (T) M() {}

func main() {}

Output of guru implements iface.go:#30 (selects the interface keyword) after applying the change:
…/iface.go:3.6-3.10: interface type Iface
…/iface.go:7.6-7.6: 	is implemented by basic type T

This change also affects the output of the describe query.
Output of guru describe fun.go:#25 (selects the func keyword) after applying the change:
…/fun.go:3.6-3.8: definition of type Fun (size 8, align 8)
…/fun.go:3.6-3.8: No methods.

If this is not considered problematic, I could submit a CL.
Another possibility would be to introduce a specialized function for the implements mode.
/cc @alandonovan

findInterestingNode is also called by the pointsto mode and the whicherrs mode. The change proposed would not affect the result of those queries. Both, pointsto and whicherrs, abort if findInterestingNode does not return actionExpr as second return value, which is not the case for a path to an *ast.{Array,Struct,Func,Interface,Map,Chan}Type node.

guru was deleted in https://github.com/golang/go/issues/65880; closing as obsolete. Incidentally, gopls reports an "textDocument/typeDefinition returned no references" error if invoked over a non-identifier, such as an interface type.


ci: only build binary for main branch

IMO, we shouldn't remove this pull_request trigger for this job. It might help to spot some build errors for other OS's or even just build errors after applying some suggestions from reviews.
For example, I'm working on MacOS. But our code is also supposed to build and run on Linux and Windows, and sometimes, we might do things that won't even build on an other OS. The CI running on pull requests helps to make sure it build correctly and ensure that we won't have to fix it once merged on main branch.
I had this exact issue on https://github.com/massalabs/thyra/pull/657 with Windows not building because I forgot some imports that my IDE didn't notice were missing (branch has been rebased since, so it's not visible).


Support UTF-8 filenames for GIF

Fixes #2775

Original reporter (#2775) says that this patch fixes the problem. Merging.


Exhaustively list fatal exceptions in the error policy

~There is no point listing all exceptions that should shut down the node; we have zero guarantees that this list is exhaustive, and so it is inevitable that some PR at some point is going to introduce an exception not in the list. The default should simply be that the node shuts down and is restarted.~
EDIT:
The default case in the error policy is not shutdown, but log + disconnect from peer.

If a particular exception is not handled by any policy, a default kicks in, which currently means logging the exception and disconnecting from the peer (in both directions), but allowing an immediate reconnect. This is fine for exceptions that only affect that peer.

So the new goal of this ticket is to exhaustively list fatal exceptions in the consensus error policy.

The following comment in https://github.com/input-output-hk/ouroboros-network/blob/master/ouroboros-consensus/src/Ouroboros/Consensus/Node/ErrorPolicy.hs#L38-L43 actually states the opposite:

If a particular exception is not handled by any policy, a default
kicks in, which currently means logging the exception and disconnecting
from the peer (in both directions), but allowing an immediate
reconnect. This is fine for exceptions that only affect that peer.
It is however essential that we handle exceptions here that /must/
shut down the node (mainly storage layer errors).

@coot Is that comment correct? If so, would it make sense to make "shut down" the default?

Yes that's correct, and the default was chosen because we don't want to accidentally shut down the node, e.g. one might mount an attack in which triggers error exception somewhere in the code.  If the default is to shut down, one could shutdown possibly a large portion of network.  We want to avoid this, that's why the default is to persist.
@edsko if we miss a chance to shutdown because of an error what can go wrong? The node will keep running, maybe it will self corrupt its db.
Another note: all exceptions are logged (I hope with high severity - I will double check in cardano-node). So there is still information in the logs.  Maybe the ones that should kill the node, should be descriptive enough (or contain some keyword that could be parsed by tools).

@mrBliss so that means this ticket turns into "Let's make sure we really do exhaustively list all exceptions that should cause a DB revalidation" right?

@mrBliss so that means this ticket turns into "Let's make sure we really do exhaustively list all exceptions that should cause a DB revalidation" right?

Indeed, I'll update the ticket

One exception that is missing:
-- | Failed to strip off the envelope from an encoded header
--
-- This indicates either a bug or disk corruption.
data DropEncodedSizeException =
     DropEncodedSizeError CBOR.DeserialiseFailure
   | DropEncodedSizeTrailingBytes Lazy.ByteString
   deriving (Show)


Lists have spaces around them

A list usually ends up like this:
1. A

2. B

3. C

Which ends up with weird formatting (<p> elements around the list items) when converting to HTML.

I've just changed the script (among other things) to also glue together lists. I believe it has more code than necessary, but works for me. It seems only problem happens if a list follows a blank line in google docs (then it gets single line break in the end result).
Here's the gist with the updated code:
fabriciomurta/0b8479e61686933dfc852ef9e0d122d7


[BUG]: Chatbot doesn't scroll down automatically when content is generated

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I used the chatbot. When it replies, it does not automatically scroll down to the bottom.
A user may not see a response unless they scroll down themselves.
I want to make this process automatic.
As you can see in the screenshot, it generates something but doesn't automatically scroll down.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

/assign-me


1.20.1 Backport of the new features

im gonna close this just cause its not up to date with the current branch


Not good enough migration path!

There is no clone functionality available for Linux apps.
Also, you are making your internal engineering issues our problem.
There should be a command that migrates the entire app service plan to a different scale unit without any public visible changes, don't mind the potential downtime but doing this all manually with the knock on effect on DevOps pipelines is non-trivial once you have more than a couple of apps.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cfacf3d-4d48-317b-0c68-2f992ebb60bc
Version Independent ID: 9f00811a-bbf8-91e9-238b-d28066e19c83
Content: Configure PremiumV3 tier - Azure App Service
Content Source: articles/app-service/app-service-configure-premium-tier.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@phatcher Thanks for the feedback! We are taking a look into this and will get back to you soon.

@phatcher Thanks a lot for your valuable feedback! The best way to share your feedback would be to create a User Voice feedback item and upvote it. The product group monitors this site for feedback. This is the best way to ensure you are heard and you may receive a response depending on how much they information they can currently share.
We will now proceed to close this thread. If there are further questions regarding this matter, please let us know.

@phatcher we agree!
Please vote here https://feedback.azure.com/forums/169385-web-apps/suggestions/41716588-allow-scale-up-to-premium-v3-without-redeploy-or-c


share button show black screen

hello the exmple is nice but when press share button in android it give me black screen how to make share button screen work

Hi @samialfarra it can be something related to permissions, would you like to debug this library?

i set all permissions . and i installed this example . and i debug the library . no error but only black screen

did you test this  example in your android and ios and check share screen button ?

@samialfarra I guess previously it was working. But I haven't tested it for a long time


Add ability to order stats models data by channel name

Codecov Report

Merging #225 (63e1468) into master (a229f8e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   98.14%   98.15%   +0.01%
==========================================
  Files          40       40
  Lines        1022     1029       +7
  Branches      147      148       +1
==========================================
+ Hits         1003     1010       +7
  Misses          6        6
  Partials       13       13

Impacted Files
Coverage Δ

mne_nirs/statistics/_statsmodels.py
97.77% <100.00%> (+0.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a229f8e...63e1468. Read the comment docs.

Codecov Report

Merging #225 (63e1468) into master (a229f8e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   98.14%   98.15%   +0.01%
==========================================
  Files          40       40
  Lines        1022     1029       +7
  Branches      147      148       +1
==========================================
+ Hits         1003     1010       +7
  Misses          6        6
  Partials       13       13

Impacted Files
Coverage Δ

mne_nirs/statistics/_statsmodels.py
97.77% <100.00%> (+0.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a229f8e...63e1468. Read the comment docs.


[Feature Request] Black borders on iOS.

I think this is probably a limitation with PWAs on iOS, but in landscape mode the left and right borders of the screen are not black but instead the same color as the app icon. Especially on the OLED phones it would be quite nice to have these pixels turned off as well.

add head meta apple-mobile-web-app-status-bar-style


chore: update dependencies

@MierenManz does this look good?

Yeah j already got scared why the duff was 250 lines 😅 if the tests pass then I'll merge

I have an idea on why the tests are failing hold on.

I updated the link, and it looks like the test that was failing no longer fails, but now when I run the testing locally, I get a deno panic because of some broken pipe error. Wondering if there is a flaky test potentially somewhere?

pipes only have a 64kb buffer. So if it get's written to by the process but never read in deno it will eventually call broken pipe. It's a design limitation with the current api.
I really want to rework this fully so that it will be more flexible etc.
But that is into the future. For now I'll just merge this if the test failure is unrelated to the change


refactor: Change an instance type to an available for free trial

Change an instance_type Standard_F4s_v2 to Standard_D2a_v4 in Deploy to online endpoint.ipynb to make ManagedOnlineDeployment available for free trial.
Module: 11
Lab/Demo: 11
Fixes # 1
Changes proposed in this pull request:
Change an instance_type Standard_F4s_v2 to Standard_D2a_v4 in Deploy to online endpoint.ipynb to make ManagedOnlineDeployment available for free trial.

@h-dychko  Thank you for making the PRs. The labs will be tested and updated this week to reflect any necessary changes.


Only include Plausible if enabled

Plausible's JS is always included on non-home pages, even when disabled. This PR fixes that by mirroring the {{ if }} from the home page.

Thank you Shea!

Thank you Shea!


Mobile avatar helper

This is a little nasty but will clean up nice when I redo the mobile files API.

Superseded by #762


Implement projector REST API.

See #1506.

Everything done for the moment. Open new issues if there is something missing.


Select fails with "Call to a member function prepare() on null"

Note: I'm editing this issue, the original title is incorrect. Please see below for details.
I am using your package outside of laravel and can't get it to work. I've attached a minimal test case which illustrates plain Mongdb access working and shows it failing when using your package.
The error I'm getting is this:
PHP Fatal error:  Uncaught Error: Call to a member function all() on array in /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Builder.php:516
Stack trace:
#0 /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Builder.php(500): Illuminate\Database\Eloquent\Builder->getModels(Array)
#1 /var/www/html/BoostG8/vendor/illuminate/support/Traits/ForwardsCalls.php(23): Illuminate\Database\Eloquent\Builder->get()
#2 /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Model.php(1603): Illuminate\Database\Eloquent\Model->forwardCallTo(Object(Jenssegers\Mongodb\Eloquent\Builder), 'get', Array)
#3 /var/www/html/BoostG8/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Eloquent/Model.php(481): Illuminate\Database\Eloquent\Model->__call('get', Array)
#4 /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Model.php(1615): Jenssegers\Mongodb\Eloquent\Model->__call('get', Array)
#5 /var/www/html/BoostG8/mongoEloquent.php(49): Illuminate\Database\Eloquent\Model::__callStatic('get', Array)
#6 {main}
 thrown in /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Builder.php on line 516

Fatal error: Uncaught Error: Call to a member function all() on array in /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Builder.php on line 516

Error: Call to a member function all() on array in /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Builder.php on line 516

Call Stack:
    0.0001     402736   1. {main}() /var/www/html/BoostG8/mongoEloquent.php:0
    0.0121    2671112   2. Illuminate\Database\Eloquent\Model::get() /var/www/html/BoostG8/mongoEloquent.php:49
    0.0121    2671168   3. Illuminate\Database\Eloquent\Model::__callStatic() /var/www/html/BoostG8/mongoEloquent.php:49
    0.0127    2762784   4. TestModel->get() /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Model.php:1615
    0.0127    2762840   5. TestModel->__call() /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Model.php:1615
    0.0127    2762840   6. TestModel->__call() /var/www/html/BoostG8/vendor/jenssegers/mongodb/src/Jenssegers/Mongodb/Eloquent/Model.php:481
    0.0190    4367240   7. TestModel->forwardCallTo() /var/www/html/BoostG8/vendor/illuminate/database/Eloquent/Model.php:1603

A minimal test case is attached below.
For reference, I have the following illuminate components installed:
illuminate/cache                       v5.7.5   The Illuminate Cache package.
illuminate/container                   v5.7.5   The Illuminate Container package.
illuminate/contracts                   v5.7.5   The Illuminate Contracts package.
illuminate/database                    v5.7.5   The Illuminate Database package.
illuminate/events                      v5.7.5   The Illuminate Events package.
illuminate/filesystem                  v5.7.5   The Illuminate Filesystem package.
illuminate/support                     v5.7.5   The Illuminate Support package.

mongoEloquent.php.zip

I found https://github.com/jenssegers/laravel-mongodb/issues/1402 and pulling dev-master fixes the issue.


ValueError at ... The file cannot be reopened.

I'm using PPOIField, but when I save (using the admin) an exception is raised in /versatileimagefield/forms.py when data.open() is called.
My images are saved from external urls to s3, maybe this info and this link are useful.
Django==1.8.11
boto==2.39.0
django-s3-storage==0.9.8
django-versatileimagefield==1.3

Hey @fabiocaccamo !
What else can you tell me about this issue? I'm using Amazon S3 on many projects with django-versatileimagefield and I haven't been able to reproduce this issue.
Could you fork the repo and provide a test case that is able to reproduce this error?

@respondcreate thanks for your quick reply, I will investigate it.

I have this with VersatileImageField's with height/width/ppoi fields which are uploaded from an InlineAdmin. Same models work fine when edited from a regular form, and this error doesn't happen with local file storage.
I have the AlwaysChangedModelForm fix from https://github.com/WGBH/django-versatileimagefield/issues/44 and use django-s3-storage==0.9.8 on Django 1.9.2 and python 3.5
The error happens in the VersatileImageFormField's to_python() override. If I put a try-except around it I get another error 'ValueError: I/O operation on closed file.'
Looks like something is fishy with the Inline forms.

Hey @Bartvds –
Any chance you could write a test case that fails (i.e. raises ValueError) so I can start drafting up the fix?

Sure, I'll setup a case mirroring my situation. I'm not very experienced in providing cases but I'll put something together in a branch in my fork.

Hey @Bartvds –
Thanks! To run tests you'll need to create a new virtualenv, activate it and then run these commands to install test dependencies so you can actually run the test suite locally (now that I think about it, I should probably add this info to the docs, too!):
$ pip install -e .
$ pip install -q Django==1.9.5 djangorestframework==3.3.1 coverage

Now that you have a test virtualenv setup you can run the test suite by running this command in the django-versatileimagefield folder:
$ coverage run --source=versatileimagefield/ run_tests.py

If that passes with no errors then you can start writing your test case! WOOHOO! Here's how to do that:
For your test case just add a method on this class with a name that starts with 'test_', example:
class VersatileImageFieldTestCase(VersatileImageFieldBaseTestCase):
    def test_inline_valueerror(self):
        """Ensure VersatileImageField fields in inlines don't raise ValueError."""
        # code that raises ValueError here

Your test should fail by raising ValueError (so I can write the code to fix the error and therefore get the test to pass). Don't hesitate to reach out if you need any help, I'd be happy to answer any questions you have!

Cool, thanks for the info: I was fighting the test_req.txt but it is for older versions of everything.
I have the existing cases running with your info so next step it to get this reproducible; it'll involve doing a quick bootcamp on testing the django admin so may take a while.

I'm still struggling with making a test case but at least I have the issue reproducable when using a manual ./manage.py runserver (after makemigrations/migrate/createsuperuser etc).
I tested this with django-s3-storage==0.9.8 on python 3.5.1
If you check the models you'll see one Parent and a Child model, both have a VersatileImageField with width/height/ppoi, and the Child has a ForeignKey to the Parent. In the admin the Parent has an InlineAdmin for the Child models.
Weird thing is how earlier the parent model didn't have an image and then it works fine. Only when both have an image field, and the child is in an inline and it uses remote storage does it break like this.
https://github.com/Bartvds/django-versatileimagefield/tree/830bd3fa6223cf2fc1ce510ff5d144d20ada3176/tests


Added ability to control light color

These updates add the ability to control light color:

Added oauth_token variable to hold the OAuth2 token which is required for controlling Abode integration devices such as Phillips Hue.
Added uuid_token variable to hold the uuid required for same reasons above.
Added new methods to set the color temperature and hue/saturation.
Modified the has_color function to determine if the device is currently using color mode.
Added the is_color_capable function to determine if the device is capable of color adjustments.
Added some new constants.

Coverage remained the same at ?% when pulling 18f91839a3fdad8ff54a172bd4ca6d145e082a89 on shred86:dev into 8976db27212d0a587b404b6b22140f9f95794f4a on MisterWil:master.

Latest commit cleans up some of the code. Passing the json argument instead of data with requests automatically passes the 'Content-Type': 'application/json' header, which is required for the RGB control. Also removed some comments since we know where levels comes from (statuses) and corrected some other comments.


request.transformIntoExecuteSqlRpc() is not a function

tedious @ v14.0.0 and tedious-connection-pool @ v1.0.1
Connecting to an Azure DB, although I get the same issue with a standard local SQL as well.

Code
var ConnectionPool = require('tedious-connection-pool');
var Request = require('tedious').Request;

var poolConfig = {
    min: 2,
    max: 4,
    log: true
};
const connectionConfig = {
   //connection details
  };

//create the pool
var pool = new ConnectionPool(poolConfig, connectionConfig);

//acquire a connection
pool.acquire(function (err, connection) {
    if (err) {
        console.error(err);
        return;
    }
    //use the connection as normal
    var request = new Request('select 42', function(err, rowCount) {
        if (err) {
            console.error(err);
            return;
        }

        console.log('rowCount: ' + rowCount);

        //release the connection back to the pool when finished
        connection.release();
    });

    request.on('row', function(columns) {
        console.log('value: ' + columns[0].value);
    });

    connection.execSql(request);
});

Receive this:
connection.js:1359 - TypeError: request.transformIntoExecuteSqlRpc is not a function
If I use the tedious library without the pooling, then everything works fine
Possible Solution
I can remove the request.transformIntoExecuteSqlRpc() call in connection.js and the connection is then sent to the server, but it obviously fails as the statement is not interpreted correctly
Environment
Node.js Windows

Looks like it was removed in v14.3.0 in this commit.

Getting the same error. Is there a fix for this?

Can anyone confirm whether this is still an issue in<EMAIL_ADDRESS>

Hope it to have fixed.

I still have the issue. The connectionPool is established earlier with a separate connect() function.

I figured out the solution. Make sure you import from 'tedious-connection-pool/node_modules/tedious' instead of just tedious. I'm using TypeScript


feat: add transition for tabs

Summary
Implemented a smooth transition for tab-switching for both the LeftNavigation Tabs indicator and the background of the themes tab.
How did you test this change?
Switching tabs in LeftNavigation and themes should have a smooth transition.
Checklist:

[x] I have performed a self-review of my code
[x] Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Please also add same animation when switching between tabs of export modal, it seems it was missing from task description.

Good job, please also add same animation when switching between tabs of export modal, it seems it was missing from task description.

added.
@RanGojo

NIT: when I'm switching between tabs, before background color change, text color changes to white. It's not very important but I was wondering if we could fix it with some small changes in animation timings. @samobasquiat

NIT: when I'm switching between tabs, before background color change, text color changes to white. It's not very important but I was wondering if we could fix it with some small changes in animation timings. @samobasquiat

fixed. @RanGojo


Added Conveyor Subsystem

Is there a way to automatically implement the formatting changes that the linter suggests?

You can add a liner plugin that uses checkstyle and then have it use the rule set located in .github/linters/linter.xml    https://marketplace.visualstudio.com/items?itemName=shengchen.vscode-checkstyle


json-schema-for-humans: fix build and update

I chose this commit as a compromise.
Upstream has released no version that accepts the combination of dependency versions that we currently have in nixpkgs.
Fixes https://github.com/NixOS/nixpkgs/issues/359286
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We've got this in docs pipeline for knot-resolver and it didn't blow up, so I hope it's just OK.


Reimagine the layout

As part of the major release we should look to adjust the app layout
Some suggested areas of review would be

Move Team Quotas into the Team Administration
Create specific User Quotas that can be managed in User Administration
Combine Global and Team tokens into one Manage > Security Tokens section and you can create tokens for User, Team, or System scope
Combine Global and Team parameters into one Manage > Parameters section
Potentially move System and Template workflows back into the Workflows screen as additional tabs.
A user profile management screen where you can edit your own name / delete account.

Additionally look into AWS Application Composer -> https://aws.amazon.com/blogs/aws/aws-application-composer-now-generally-available-visually-build-serverless-applications-quickly/

This is nearly done


A keyboard shorcut for rearrange the splited tabs

I usually split tabs to the vertical dimension tabs and resize them to get more space to view codes so I really want to have a keyboard shortcut that makes the split tabs have equal width(or height)
For example, if we have two split tabs which resized, each tab should be 50 percent of the screen width after the action.
(I'm sorry for my poor English)

View: Reset Editor Group Sizes


update PR-template, add documentation and translations section

UHF-9711
Update PR template

remove designer section
add documentation section
add translations section

PR collection: https://github.com/City-of-Helsinki/drupal-helfi-etusivu/pull/565

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@24d8c12). Click here to learn what that means.

:exclamation: Current head d442c94 differs from pull request most recent head e1637ef. Consider uploading reports for the commit e1637ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #13   +/-   ##
==========================================
  Coverage           ?   58.33%
  Complexity         ?       15
==========================================
  Files              ?        3
  Lines              ?       60
  Branches           ?        0
==========================================
  Hits               ?       35
  Misses             ?       25
  Partials           ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issue 47 - Added Missing Scope Parameters

This PR addresses the Issue #47 Missing "Scope" Parameters as well as additional work on #46.
It contains the following changes:

xFirewall Parameters added:

Authentication
Encryption
InterfaceAlias
InterfaceType
LocalAddress
LocalUser
Package
Platform
RemoteAddress
RemoteMachine
RemoteUser

xFirewall resource reworked internally to use an Array that contains a list of all parameters and the source data elements and this is used in both the resource (Get/Set/Test) and the pester tests to eliminate code replication. The array is defined in data region called ParameterList in MSFT_xFirewall.psm1.
The profile parameter is now handled correctly as an array internally instead of being converted back and forth between comma delimited string and array.
Array comparison for array parameters now done using Compare-Object instead of loop and count comparison.
Unit Test template added.
Unit Test and Integration Test header/footer code standardized and copied to templates. Header/Footer code should be the same in all tests and test templates. Header/Footer code can now be moved into external helper module like DSCResource.Tools.
Integration Test configuration file renamed to MSFT_xFirewall.config.ps1 so that the Integration Test template can automatically figure out the expected name without the user having to set it.
Also changed ApplicationPath to Program in samples and Readme.md as it was changed a few PRs ago.

That is it for this PR I think.
There are still a few parameters needing to be added, but they should be much easier to add now that the parameter list is in an array. I'll add the remaining parameters to a new Issue so we can track that.
Thanks!

Looks pretty good, most of my stuff is minor. I think some of the style stuff chosen needs to be hashed out in a broader sense so I might end up merging it and then bringing up the point else where.

Once this has been merged I'll adjust all the other resources in this module with the changes as well as add integration tests. I'll also remove all the ################'s when I do this.


Sprk 102

Wrote sparkle_extractor_wrapper, based on the existing implemenation of spakle_run_default_wrapper.

Somehow these changes break the compute_features command
So far I understand that cfh.computing_features gets the variable "list_feature_computation_job" from the SparkleFeatureDataCSV, and the entries in the variable contain the names of the extractors that should be run to compute the feature data
The SparkleFeatureDataCSV, based on FeatureData/sparkle_feature_data.csv, now contains a lot more columns that are all converted to extractors, even though there is only one extractor available.
(This still works in development, only breaks in the version with the new extractor wrapper)

I found the error.
The problem was that the special_sparkle_string that you asked me to remove was used as a seperator in the compute_feature code. I brought the special_sparkle_string back and rewrote the rest of the wrapper based on your suggestions and now everything should work.


Mamba training loss at 7B parameters

Dear authors,
Very impressive work! I have just finished reading your paper and would be very curious about the training loss curve for a 7B Mamba model as shown in Figure S4 in the paper for Transformer++, Hyena, and Striped Hyena. Do you happen to have it?
Best wishes.

We will include a comparison in the next version of the preprint

Mamba 7B included in preprint v2 now


jsonschema module throws exceptions

This should be fixed so it does not throw an exception, but only exits with an error code and a message.
As it is now, if a config file fails the schema validation, it crashes out and displays an exception which is barely readable in the ansible output.
This should produce a non-zero result code with some useful output which could be displayed by ansible as it fails gracefully.

An example schema validation error:

TASK [kraken.config : Validate k2 configuration under schema] ********************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was:     'whatWereYouThinkingDavid?'
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Traceback (most recent call last):\n  File "/tmp/ansible_vzeMs6/ansible_module_jsonschema.py", line 184, in \n    main()\n  File "/tmp/ansible_vzeMs6/ansible_module_jsonschema.py", line 180, in main\n    module.fail_json(changed=False, msg="Validation failed", result=result)\n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 1993, in fail_json\n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 1973, in _return_formatted\n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 414, in remove_values\n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 414, in \n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 414, in remove_values\n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 414, in \n  File "/tmp/ansible_vzeMs6/ansible_modlib.zip/ansible/module_utils/basic.py", line 425, in remove_values\nTypeError: Value of unknown type: <class 'jsonschema.exceptions.ValidationError'>, 'whatWereYouThinkingDavid?' is too long\n\nFailed validating u'maxLength' in schema['properties']['deployment'][u'properties'][u'clusters'][u'items'][u'properties'][u'name']:\n    {u'description': u'Name of this cluster.',\n     u'maxLength': 13,\n     u'minLength': 1,\n     u'type': u'string'}\n\nOn instance['deployment'][u'clusters'][0][u'name']:\n    'whatWereYouThinkingDavid?'\n", "module_stdout": "", "msg": "MODULE FAILURE", "rc": 0}

This code was intended to catch the exception.
    try:
        validator = ApiValidator(schema, schema_uri, subschema_dir)
        validator.validate(config)
    except (jsonschema.ValidationError, jsonschema.SchemaError) as e:
        result['is_valid'] = False
        result['exception'] = e

It's not because TypeError was thrown. Ideally, we would have a table mapping ValidationError exceptions to useful error messages.


Unexpected comma in middle of array - no-sparse-arrays

Hey, I stumbled upon this while creating a new Nuxt 2.4.2 app.
Steps to reproduce
yarn create nuxt-app
Go through the install, under features select all, deselect one (mine was a for all, deselect Axios), continue.

The create-nuxt-app to finish without errors
What actually happened?
error  Unexpected comma in middle of array  no-sparse-arrays in nuxt.config.js
cat nuxt.config.js reveals this extra comma in the modules array:
  /*
  ** Nuxt.js modules
  */
  modules: [, '@nuxtjs/pwa'],

I assume it's left from when I deselected Axios.

This happened to me too. Is it safe to continue?

For now, feel free to delete the comma and go ahead :relaxed:
Thanks for the report

Fixed by #172


Improve announcements implementation

Per discussion in #steering-committee, this PR improves the implementation and display of site-wide announcements in preparation for an upcoming announcement. It adds attributes to config.toml to allow for greater flexibility in future.

@celestehorgan Thank you for implementing this so quickly! ✨
I notice that Training, Community, and other pages show two lines, but Documentation shows one. It’s not a blocker, just data.
https://deploy-preview-21465--kubernetes-io-master-staging.netlify.app/community/
https://deploy-preview-21465--kubernetes-io-master-staging.netlify.app/docs/home/

This idea is excellent. I would think that community level announcements should be placed only on
ks8.io (https://kubernetes.io/) and possibly the k8s community page (https://kubernetes.io/community/).
Also might be a good idea to add an entry to the Blog?
For full impact, a smaller banner could be placed on every page.
Another suggestion is to create a visual difference between the announcement banner and the rest of the header.

@celestehorgan Thank you for implementing this so quickly! ✨
I notice that Training, Community, and other pages show two lines, but Documentation shows one. It’s not a blocker, just data.
https://deploy-preview-21465--kubernetes-io-master-staging.netlify.app/community/
https://deploy-preview-21465--kubernetes-io-master-staging.netlify.app/docs/home/

This looks like a CSS error (thanks!) – the second line of text is showing up in docs, but isn't visible.

This idea is excellent. I would think that community level announcements should be placed only on
ks8.io (https://kubernetes.io/) and possibly the k8s community page (https://kubernetes.io/community/).
Also might be a good idea to add an entry to the Blog?
For full impact, a smaller banner could be placed on every page.
Another suggestion is to create a visual difference between the announcement banner and the rest of the header.

All of these are good ideas. I'll address 2 specifically:

Also might be a good idea to add an entry to the Blog?

I'll surface this to the steering committee.

This idea is excellent. I would think that community level announcements should be placed only on
ks8.io (https://kubernetes.io/) and possibly the k8s community page (https://kubernetes.io/community/).

This is a good feature request but probably out of scope for this very hack-and-slash implementation.
I discovered in re-doing announcements for the steering committee that the deprecation notice and announcements were both not loading their CSS styling correctly, among other wonky things (like being implemented both as a shortcode and a layout partial).
I think it's a good follow-up issue for me to re-implement both of these features in general as they're quite crufty D:. I've opened #21496 to track this.

/approve

/hold cancel

/LGTM
🖤


Please update the required Betweenlands version. Server refuse to start due to this.

Title.
https://pastebin.com/JBHYFB2T

Thats the minimum version, it will not work with anything lower.


rancher no monitoring for etcd in local cluster and import cluster

What kind of request is this (question/bug/enhancement/feature request):
bug/enhancement
Steps to reproduce (least amount of steps as possible):
Install Rancher as per Rancher 2.x installation guide
https://rancher.com/docs/rancher/v2.x/en/installation/ha/
install K8s cluster using RKE
install helm
install rancher as workload via server-chart
enable monitoring for cluster local
Result:
no monitoring Grafana link in cluster local
Alert like 'Etcd member has no leader' in cluster local  show No metric graph data
Seems etcd monitoring is off
Cluster other than local is ok

v2.2.0-rc14 replicated.

@loganhz can you explain what is going on here?

@loganhz @sangeethah has monitoring local cluster been tested? is it supported

@cjellick Now we only scrap ETCD metrics for RKE cluster (node template or custom).  local cluster is an imported cluster.  So it's not in our scope. But maybe we can detect if it is an imported RKE cluster, then we can scrap it.

so, but how to monitor local etcd metrics? have any suggestion ? thanks you

so, but how to monitor local etcd metrics? have any suggestion ? thank you

Same question here.

so, but how to monitor local etcd metrics? have any suggestion ? thank you

Since this isn't built into Rancher yet, you could build custom Grafana graphs to monitor etcd. Some Rancher customers build an external Grafana/Prometheus service which does this (and which also does monitoring and alerting outside of Rancher). I imagine it's also possible to build custom graphs within the existing Grafana service-- I'm sure that some etcd/grafana tutorials could help us to do this.

Now we only scrap ETCD metrics for RKE cluster (node template or custom). local cluster is an imported cluster.

Generally speaking, an RKE cluster shouldn't be considered an imported cluster to the point that it excludes expected features. Installing via RKE is Rancher's #1 recommended way to provide a standard HA cluster, and it's suprising  when important features like this don't work. This feels like Rancher software can't support other Rancher software, which makes for a disjointed user experience that feels disjointed. Would love to see this improved.

We are going to include this in scope of our overall monitoring improvements. At a minimum, it should at least be able to use the enhanced configurability of the cluster monitoring solution.

Hi,
How can I monitor ETCD and Kubernetes Components?
What is the alternative solution?
Regards

Hi,
Enterprise PKS had the same problem and resolved it:
https://kb.vmware.com/s/article/71049
Is there any solution in Rancher?
Regards

The support for scraping metrics from etcd is tested on both local cluster and imported RKE cluster on a Rancher:master-d19f179c4ff15bb782e27ed50d33d169dad79f80-head HA setup with rancher-monitoring v2.
As of today, with monitoring v2, the Rancher UI does not show the metrics;
Instead, we need to expose Grafana UI and Prometheus UI and check graphs and metrics from there.
here is the yaml file of the configuration used when installing the rancher-monitoring chart (if not installing rancher-monitoring from rancher's dashboard)
prometheus:
  prometheusSpec:
    evaluationInterval: 1m
    resources:
      limits:
        memory: 1000Mi
    retentionSize: 50GiB
    scrapeInterval: 1m
rkeControllerManager:
  enabled: true
rkeEtcd:
  enabled: true
rkeProxy:
  enabled: true
rkeScheduler:
  enabled: true

In Prometheus, we see the targets for etcd are active

and we can query etcd metrics

In Grafana, the etcd dashboard also shows metrics

Same question.


Page doesn't refresh automatically after removing all runs

https://github.com/Jumpscale/portal9/commit/e875f86121f2799c6baca67c561b5d294b86c503


Set gpg check to 'no' on scale version is lower than <IP_ADDRESS>.

Set gpg check to 'no' on scale version is lower than <IP_ADDRESS>.
Signed-off-by: Christoph Keil<EMAIL_ADDRESS>

Closing , as Christoph is planing to submit PR in different branch.


Add punycode (IDN) support

Add support for punycode (IDN) domains and records.
This is built upon the original PR#597.

domains and records now always show up pretty

CNAME records can be pointed at IDN names

IDN shows up correctly even when only the TLD is an IDN

Search is still not working (will require smart adjustments that probably go deeper into how this works for now)

Display of both idn encoded and non-idn-encoded values does not seem to be of much use for now (maybe as a tool-tip ?)

JS modals that display domain/record names still do not show the pretty version yet

is anybody home?

If someone could review and merge it would be nice :-)

Merged it. Thanks for your contribution :)


WebApp console in dev shows AntDesign FilteredKeys Warning

Running yarn start during WebApp development shows Warning: [antd: Table] 'FilteredKeys' should all be controlled or not controlled. This warning is due to not controlling each state of antd tables across the WebApp, for example in getColumnSearchProps we do row selection to do column search without doing store.dispatch() to update global state.

Closed as part of backlog grooming. Feel free to comment if you would like to contribute to this.


AdvGen 0.9.20 Server issue

Yesterday got server to start fine, but it wouldnt respond to any commands or player connection packets, interesting enough it would respond to shadowfact's discordchat mod commands (except !exec), Ive figured out that one of region files were causing some kind of error, so i looked what that region is, happend to be base of only person on the server that uses AdvGen, so i tried removing it which worked.
Dont have any crash logs as server doesnt crash and works 'fine'.
I can guess that it could be that adv generator was built on multiple chunks (had issues with multiblocks being built like that in GregTech before). Could also be that base was located partially in spawn region, so maybe partially loaded generator?
Modpack that gave error: ATM2 v.68 Havent tested without foamfix, since havent had time to do so, sorry.

I'm closing this issue as part of a spring cleaning of my issue trackers from old stuff.
If you believe it's a bug that is still relevant in Minecraft 1.12 - Feel free to reopen it.


Clarified that autoscaler addon only supports first agentPool

What this PR does / why we need it: Clarifies the documentation for the cluster-autoscaler addon, that is only supports scaling the first agentPool at this time.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2963
Special notes for your reviewer:
If applicable:

[x] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@sozercan FYI I asked the question once before in #2637 , so I figured I should help with the docs.

thanks @ewok2030


'make clean' leaves /tmp/luet-geniso511891688 in place

cos-toolkit version:
luet version 0.14.1-g946524f90de7c4c9f579749f868b91f5f58f5750 2021-05-04 07:56:58 UTC
git @ 680349531f07406685aaa200915f064c9d926527

CPU architecture, OS, and Version:
openSUSE Tumbleweed x86_64

Describe the bug
This is actually two bugs: a) failure of make local-iso and b) wasted disk space in /tmp.
make local-iso fails with
ERRO[0000] fatal error: stat /tmp/luet-geniso511891688/overlayfs/boot/vmlinuz: no such file or directory

I can't remember how I got into this state, but would assume that a make clean (or do we need a make realclean while make clean keeps a 'cache'  ?!) would give me a "clean plate" to start over.

To Reproduce
Simplest probably is to
rm `find /tmp/luet-geniso* -name vmlinuz`

Expected behavior
make clean resets everything and a subsequent make local-iso succeeds.

Logs

Additional context

you should be able to set TMPDIR temporarly to force a specific temporary directory, but we should make makeiso cleanup in case of failure

Hmm, removing this tempdir creates another one (/tmp/luet-geniso613094909) but gives me the same error when running make local-iso
ERRO[0000] fatal error: stat /tmp/luet-geniso613094909/overlayfs/boot/vmlinuz: no such file or directory

make local-iso needs another prerequiste. But which one ? :thinking:

make build puts vmlinuz back in place

@kkaempf Is this still happening?

well, it apparently is another privileged vs. unprivileged case and happens if you run "make build" (resp. "make clean") as non-root.
Docs have been adapted meanwhile. Closing.


Fix TagBot

The Julia TagBot didn’t automatically create a release so I created it manually for v0.1.0. It’s probably a permissions issue in the GitHub workflow. Marking this so I can come back and take a look.

Agreed. I think when you updated it 2 months ago, your changes worked. I tagged the registrator bot on the commit but didn't have to manually do the release like before.


Feature request: more settings

More specifficly i would like to disable "in response to" message. It breaks my character.
And also options to set bot's activity, status, and author mention in reply(idk how to do it here, but in discord.py it's await ctx.reply("text", mention_author=False)).

Under status i meant online, dnd etc.
I use this project with some of my own code on python, so yes, i would like to change that.
I would like to leave user nicknames in amode, but disable "in response to" message, only this part of amode breaks my character.

ability to change play activity field is useful~

@DdaannnRU @NekoraNeko

Added in #21


how to configure mongo.shell.path using docker container?

Tried the command from #311
"mongo.shell.path": "docker exec -it mongodb mongo"

but when execute the scrapbook still complains about
This functionality requires the Mongo DB shell, but we could not find it. Please make sure it is on your path or you have set the 'mongo.shell.path' VS Code setting to point to the Mongo shell executable file (not folder). Attempted command: "docker exec -it mongodb mongo"

May I know how can I configure to make it works?

Hi @sweetim, there seems to be a legitimate bug in this use-case. I can repro this.

Do you have docker setup with the mongo image?
Builld the docker image to a container named mongodb.
This command should work on  the powershell.

Yes, i have the docker setup already, and can be seen below (obtain using docker ps)
CONTAINER ID        IMAGE               COMMAND                  CREATED              STATUS              PORTS                      NAMES
34f327299918        mongo:4             "docker-entrypoint.s…"   About a minute ago   Up About a minute   <IP_ADDRESS>:27017->27017/tcp   mongodb

when I tried them on my wsl or Windows cmd, I could get the response from mongodb
docker exec -it mongodb mongo
MongoDB shell version v4.0.10
connecting to: mongodb://<IP_ADDRESS>:27017/?gssapiServiceName=mongodb
Implicit session: session { "id" : UUID("a65e33a4-493c-41cc-8202-4ce8f22e060b") }
MongoDB server version: 4.0.10
Server has startup warnings:
2019-06-12T12:31:32.226+0000 I STORAGE  [initandlisten]
2019-06-12T12:31:32.226+0000 I STORAGE  [initandlisten] ** WARNING: Using the XFS filesystem is strongly recommended with the WiredTiger storage engine
2019-06-12T12:31:32.226+0000 I STORAGE  [initandlisten] **          See http://dochub.mongodb.org/core/prodnotes-filesystem
2019-06-12T12:31:32.946+0000 I CONTROL  [initandlisten]
2019-06-12T12:31:32.946+0000 I CONTROL  [initandlisten] ** WARNING: Access control is not enabled for the database.
2019-06-12T12:31:32.946+0000 I CONTROL  [initandlisten] **          Read and write access to data and configuration is unrestricted.
2019-06-12T12:31:32.946+0000 I CONTROL  [initandlisten]
---
Enable MongoDB's free cloud-based monitoring service, which will then receive and display
metrics about your deployment (disk utilization, CPU, operation statistics, etc).

The monitoring data will be available on a MongoDB website with a unique URL accessible to you
and anyone you share the URL with. MongoDB may use this information to make product
improvements and to suggest MongoDB products and deployment options to you.

To enable free monitoring, run the following command: db.enableFreeMonitoring()
To permanently disable this reminder, run the following command: db.disableFreeMonitoring()
---

>

My current setup:

vscode 1.35
windows 10 1903
mongodb 4

#1104

Fixed by #1162.
There is a new "mongo.shell.args" setting which should give you what you need.


Images linger after page change

on a slow enough connection you can see old images being still shown (with new text) after changing a page. It looks like the app changes img's src instead of replacing the whole element.

yep, i've been noticing this for a while. not sure what the best way to fix it is yet. i'll leave this open until we can come up with something.

Looks like the Html.Keyed API in elm-html 1.1.0 should help here, I'll try this later today


Binary Distribution

It would be great if iadd was distributed as a binary package for those who have to install all the development tools just for compiling one addon.
I'm in need of one for Windows and Linux. On Linux, it should be possible to package an AppImage or another distribution-independent binary package.
Unfortunately, I can't currently try it out but in the screenshots it looks great. :)

I agree! There already is a binary for Archlinux on the release page, you could try if it works on your system. Unfortunately I don't have Windows but I can look into distro-independent linux packaging.

Homebrew is a not so bad option these days for mac/linux/windows. There's a hledger formula you could add to.
Nix too, but not for windows.

@simonmichael, when you're building the Ubuntu packages for hledger, hledger-ui, and hledger-web, could you also possibly build a package for hledger-iadd? Or would that be complicated?

Yes, I could do that in principle if @hpdeifel wants it. I feel like there would be some complications with bounds at times. Usually these binary artifacts are built when I push to ci-linux/ci-mac/ci-windows branches on github. That mostly happens a little before release time, but not only then.

I suppose it could make a best effort and tolerate build failures, to avoid breaking the CI.

Sure, if it's not too much overhead for you, that would be great!

Update: the binary in the .tar.xz archive released by @hpdeifel is working fine on an x86_64 Ubuntu 20.04 machine.  (I've just inflated the binary to ~/.local/bin/hledger-iadd).  It would be great if @simonmichael could add that binary to the hledger-ubuntu.zip file along with hledger-ui and hledger-web as part of the hledger release workflow.  Thanks!


Docker VM Build Strategy

Closes #1246
https://hackmd.io/HQHG0xXfT4CEc-iHsuMHpg

Closed in favor of bundling this functionality in #1204


Training parameters

How can I replicate similar results on only one GPU? What parameters need to be modified?
Can I display only the segmentation mask (without categories and scores) when running the demo.py for visualization?
Thank you!

Perhaps you could decrease the learning rate and batch size while increasing the number of iterations accordingly. For example, BASE_LR: 0.0000125, IMS_PER_BATCH: 1, MAX_ITER: 160000, STEPS: (112000,).

If you want to hide the class and score, please modify the draw_instance_predictions function on line 50 of visualizer.py.


Build: Migrate to yarn berry and update build scripts

What does this PR do?

[x] Migrate to use yarn berry
[x] Add useful yarn plugins (interactive-tools & typescript)
[x] Use peerDependencies so consuming app can (I believe) know how to link correctly
[x] Make dev and prod builds a scripts concern so yarn dev doesn't build prod
[x] Use rollup --watch flag

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jackw is this merge still needed or can we close it if not/resolved?


bitsandbytes interprets URLs from environment variables as paths

System Info
Ubuntu 22.04, Python 3.10
Reproduction
export TEST_VAR="http://localhost/"
python3 somescript_using_bitsandbytes.py

Results in
The following directories listed in your path were found to be non-existent: {PosixPath('//localhost'), PosixPath('http')}

https://github.com/TimDettmers/bitsandbytes/blob/ffd7d0db6a660c97b60a2c9605309ee4b5cd40e3/bitsandbytes/diagnostics/cuda.py#L66
is a bit too eager to interpret everything with os.sep in it as PATH variable.
Expected behavior
bitsandbytes should only look in relevant PATH variables for paths. This also avoids the risk of finding existing paths with wrong library versions that weren't meant to be used in the current script.

Related: #1126
I agree; this could use some improvement.

As bitsandbytes prints a lot of information on how to debug not found libraries, I wonder if it needs such a broad search for possible paths in the environment or could just check a list of known path variables and otherwise print help on how to set variables like CUDA_HOME as a clean way to provide the library paths.


Fix frontend bugs.

Console error while sorting the table (report is undefined). Extracted code for rendering the table.

Hi @omittones ! Is this still relevant?

No idea, haven't used locust in a while. Will see tomorrow and close it if
it's not.
On Fri, Oct 18, 2019, 23:05 Lars Holmberg<EMAIL_ADDRESS>wrote:

Hi @omittones https://github.com/omittones ! Is this still relevant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/locustio/locust/pull/822?email_source=notifications&email_token=AAJNDFVILKL4TI63PJVUV4LQPIQKFA5CNFSM4FFUCPH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBV7JCA#issuecomment-543945864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJNDFRHK3UUVFPV4MRHCPLQPIQKFANCNFSM4FFUCPHQ
.

Hi @omittones ! Is this still relevant?

Hey, I merged with master and this is still relevant. It includes a fix for error happening on frontend, and minor refactoring.

Thanks!


WebXR ES6 changes

Update WebXR codebase to a modern JS.
I confirm I have signed the Contributor License Agreement.

Great stuff, @Maksims! Thanks!


Suggestion/fix: use license identifier

I suggest you to use license identifier instead of steam.
Steam API and using it as identifier is considered as not reliable by CFX team.

Sure! why not?
I'll plan to have the user determining which license they wanted as the second license, might be completed in 1-2 days later.
Thank you for your help 😀

Yes, good idea making license default identifier as suggested by CFX and the other one being user configurable. Looking forward to your framework and if i would have more time in future i will contribute for sure!

Fixed in 1.4.0


Address branch cutting expectations

Please provide a description of this PR:
Set expectations for what can be merged in post-branch cutting (feature freeze, bug fixes, etc.) for a given Istio release.
The TOC asked for a PR to live closer to the code than a document on the Istio community drive (see https://docs.google.com/document/d/1Bns4gulQnM3sOcysxDTZvwboU0r_0TOPwqpgO314Vrc).
This document was started as a discussion in the T&R group and from previous release managers for expectations about PRs and the release management process.

LGTM

may need @nrjpoddar to ack on CLA with googlebot i consent.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster-tests_istio
0e16049df5959fe6fd8226f855c50f6653067204
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

@jacob-delgado: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
0e16049df5959fe6fd8226f855c50f6653067204
link
unknown
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retry

/retry


Create NathanRag.json

Hey, I am trying to figure this out. I dont have many links as of now but will add them in future.

Hey, I am trying to figure this out. I dont have many links as of now but will add them in future.

You have the e from socials you can use if you like?  Do you understand how to add them as links?


Switching to other context

How can I switch to another context?

@baselalali hey, will implement a few days

@baselalali this is implemented in the version 1.0.5, and it should work now. Thanks!