Button - experimental component (feedback from review)

From @laurenmrice on Nov 15, 2018 - Not sure if it's still valid, though:

[x] Create 48px button style option (to be used when there are 40 px fields option)
[ ] Ghost button icon relationship

[x] Ghost button has an opacity layer on it that needs to be taken off
[ ]  Make fixed 16px padding on both ends across the board

@asudoh still valid

Quick question since this issue seems related:
On the Security team, we've seen a lot of designs with very large buttons with icons in the lower right corner. A quick example I can think of is on the current Carbon X site (though those buttons are even bigger than the ones I'm thinking of): https://next.carbondesignsystem.com/

Was Carbon considering creating a standardized Large and maybe even X-Large button variation? It would be especially helpful for the React components, from our perspective.

@jendowns Eventually we will be designing a series of these larger fluid buttons. As of right now we only designed the one to one version of current Carbon (fixed buttons).

from what I can tell the points in the original ticket have already been addressed, unless I am misunderstanding them

@laurenmrice Would you agree with @emyarod's assessment that everything in this issue has been addressed...? Thanks!

The ghost button needs to have 16 px in these areas as speced. Right now on the website the icon is still hanging far right.

@laurenmrice I see, so we want to remove the minimum width rule from only our ghost buttons, is that right? I believe the reason why it appears that the icons are very far to the right in the ghost buttons is because they still have a minimum width value that's carried over from our other buttons, and the icon is just positioned 16px left of the far right edge

@emyarod Yes, correct ^

CC @tw15egan

This issue is being tracked here now:
https://github.com/IBM/carbon-components/issues/1928


Unable to add the Package

When I try to add the package, I get the following error message.
(@v1.5) pkg> add https://github.com/thomasfaingnaert/GemmKernels.jl
Updating git-repo https://github.com/thomasfaingnaert/GemmKernels.jl
Resolving package versions...
ERROR: Unsatisfiable requirements detected for package CUDA [052768ef]:
CUDA [052768ef] log:
├─possible versions are: [0.1.0, 1.0.0-1.0.2, 1.1.0, 1.2.0-1.2.1, 1.3.0-1.3.3] or uninstalled
├─restricted to versions 1.3.0-1 by GemmKernels [312cec97], leaving only versions 1.3.0-1.3.3
│ └─GemmKernels [312cec97] log:
│   ├─possible versions are: 0.1.0 or uninstalled
│   └─GemmKernels [312cec97] is fixed to version 0.1.0
└─restricted by compatibility requirements with LLVM [929cbde3] to versions: uninstalled — no versions left
└─LLVM [929cbde3] log:
├─possible versions are: [0.9.0-0.9.15, 1.0.0, 1.1.0-1.1.1, 1.2.0, 1.3.0-1.3.4, 1.4.0-1.4.1, 1.5.0-1.5.2, 1.6.0, 1.7.0, 2.0.0, 3.0.0, 3.1.0] or uninstalled
└─restricted to versions 3 by GemmKernels [312cec97], leaving only versions [3.0.0, 3.1.0]
└─GemmKernels [312cec97] log: see above

Could you try again with an empty environment?Op 1 okt. 2020 17:54 schreef Kirshanthan Sundararajah<EMAIL_ADDRESS>(@v1.5) pkg> add https://github.com/thomasfaingnaert/GemmKernels.jl
Updating git-repo https://github.com/thomasfaingnaert/GemmKernels.jl
Resolving package versions...
ERROR: Unsatisfiable requirements detected for package CUDA [052768ef]:
CUDA [052768ef] log:
├─possible versions are: [0.1.0, 1.0.0-1.0.2, 1.1.0, 1.2.0-1.2.1, 1.3.0-1.3.3] or uninstalled
├─restricted to versions 1.3.0-1 by GemmKernels [312cec97], leaving only versions 1.3.0-1.3.3
│ └─GemmKernels [312cec97] log:
│   ├─possible versions are: 0.1.0 or uninstalled
│   └─GemmKernels [312cec97] is fixed to version 0.1.0
└─restricted by compatibility requirements with LLVM [929cbde3] to versions: uninstalled — no versions left
└─LLVM [929cbde3] log:
├─possible versions are: [0.9.0-0.9.15, 1.0.0, 1.1.0-1.1.1, 1.2.0, 1.3.0-1.3.4, 1.4.0-1.4.1, 1.5.0-1.5.2, 1.6.0, 1.7.0, 2.0.0, 3.0.0, 3.1.0] or uninstalled
└─restricted to versions 3 by GemmKernels [312cec97], leaving only versions [3.0.0, 3.1.0]
└─GemmKernels [312cec97] log: see above
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

Great, It works now. Thank you.


use rapids-build-backend

Contributes to https://github.com/rapidsai/build-planning/issues/31
Contributes to https://github.com/rapidsai/dependency-file-generator/issues/89
Proposes introducing rapids-build-backend as this project's build backend, to reduce the complexity of various CI/build scripts.
Notes for Reviewers
What about the ongoing work to add wheels?
If #369 is merged before this, this should be updated to ensure it doesn't break wheel builds.
But opening this one separately so we can keep making forward progress on rolling out rapids-build-backend across RAPIDS.

/merge


Specify which endpoints can be used for peeking

the state endpoints seem to work, so its worth defining whether or not they should for dendrite and others

Related: https://github.com/matrix-org/matrix-doc/issues/757


Upload bin release artifacts

Currently for the latest release there are no bin artifacts. Users should be able to download the bins without having to build themselves. Building and uploading artifacts to a release can be automated in the workflow.

This work is pending a conversation surrounding the integration of osm-health and the osm cli.


Fix contrib CI for timm

Fix #1324.
HF helpers location changed in timm packages. This PR just changes the import (+test on smaller models to save bandwidth).

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Adding @objc to each OpenGraphData property

Hi,
To compile Objective C under Swift 4, each property needs to add @Objc to allow Objective c to access them. Can you help to add the codes below?
@objc public class OpenGraphData: NSObject {
@objc public let createdAt: Date
@objc public let imageUrl: URL?
@objc public let pageDescription: String?
@objc public let pageTitle: String?
@objc public let pageType: String?
@objc public let siteName: String?
@objc public let sourceUrl: URL?
@objc public let updatedAt: Date
@objc public let url: URL?
Thanks for sharing the codes and appreciate it :)
Thanks,
Calvin

Hi, @CalvinTp
Those have already added at 0.15.1
Please check this line.
Thanks


popovers: Redesign stream and topic action popover.

Redesigns the stream and topic action popover menu using the new popover-menu tippy theme. This is a part of the larger effort to redesign all the popover menus along the lines of the new gear menu/personal menu/help menu design. Also includes the new icons to go along with the redesign.
The redesign of topic visibility tab picker located in the topic action popover is being worked in #29479.
Fixes part of https://github.com/zulip/zulip/issues/28699.
CZO discussion

Screenshots and screen captures:
Stream Actions Popover

Light Mode

Before
After

Dark Mode

Before
After

With Color Picker

Before
After

Long Stream Name (Wrapped)

Before
After

Topic Actions Popover

Light Mode

Before
After

Dark Mode

Before
After

Long Topic Name (Wrapped)

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I haven't tested since it's a draft, but the screenshots look nice! I guess some day we should rework the color picker, but it's not a big priority (#14961, and whatever design changes we make as part of that).

There's some vertical alignment issues, at least with "Unsubscribe" and its icon.

@alya I agree on the need of a rework on the colorpicker. I noticed some issues with the current implementation,

While tabbing through the menu, we come across the cancel option, which has no text inside it. It basically resets the color selection to the previous default, in case we want to check what the previous color was before confirming. Due to such a small target area and no content inside, it is possible to trigger this only via tabbing through the menu or just spamming near that location with a cursor.

When we confirm a color, we don't close the color picker. Maybe that's a intentional design choice, since it might be irritating for a user to navigate back to the color picker after every change. But this might be worth a look.
The confirm button itself has an outdated/mismatched look when focused/clicked.

There's some vertical alignment issues, at least with "Unsubscribe" and its icon.
I'm also not sure about the increased minimum width for this one.

@timabbott The icon misalignment is due to most of the icons being the older font-awesome icons. It will get auto fixed once I request the new icons from Vlad, thanks! I'll start a design topic at CZO so that we can iron out the other issues.

UPDATED the PR to also include the topic action popover redesign. (changes are almost similar to those of the stream actions redesign).

Updates:

Added the new icons provided by Vlad, for both, the topic and stream action popovers.
Restored no-auto-hide-left-sidebar-overlay class, which I had removed my mistake.
Updated the PR to show the current state.

Merged, thanks @sayamsamal! Please do a before/after test of popovers popover in the spectators mode as an additional QA step -- I forgot to do that before merging, and it's a thing I could imagine breaking.
One immediate follow-up worth doing is renaming the files; we have web/templates/popovers/*_popover.hbs as the naming convention for modernized popovers, and these should get moved to that standard.


Update build tools

Updated command-line build tools to current Microsoft versions.
Addressed various build warnings.

Missing & extraneous icons
Mismatches in iOS app & service extension build configs
Several issues with iOS bindings
Gradle deprecation

☯

🍔 lgtm


How to get AR for every class?

As the title mentions, how can we get AR for every class?

You can set classwise parameters.  Add evaluation = dict(classwise=True) to the configuration file

You can set classwise parameters. Add evaluation = dict(classwise=True) to the configuration file

I tried but only get AP for every class, not AR.

For now, MMDet does not support showing AR for each class. You may use https://github.com/open-mmlab/mmdetection/blob/master/tools/analysis_tools/coco_error_analysis.py to see detailed AP/AR for each class.

A good idea


File RCTConvert+MapKit.m not found

Issue Description
File not found error after building project on XCode.
Steps to Reproduce / Code Snippets

Install react-native-mapsyarn add react-native-maps

Link react-native-mapsreact-native link react-native-maps

Open XCode projectopen ios/MyProject.xcproject

Build the project with ⌘ + B, crashing with the following output:clang: error: no such file or directory:
'/Users/username/Projects/MapsTest/node_modules/react-native-maps/lib/ios/AirMaps/RCTConvert+MapKit.m'
clang: error: no input files

Expected Results
Successful build
Additional Information

React Native Maps version: 0.14.0
React Native version: 0.43.0
Platform(s): iOS
No other libraries installed

This needs changing in the project file and various other places, it was renamed here but the contributors project file was not committed with the change. Will submit a PR now: https://github.com/airbnb/react-native-maps/commit/4926f5b53fac8e1ab9aaf877e81048e262dee8aa

PR can be seen here: https://github.com/airbnb/react-native-maps/pull/1214

Great @simonmitchell! Hope your PR gets merged soon.

Yeah, this is kind of a blocker for people upgrading. Need to also bump up the dependency versions, still wants React 15.4, and RN 0.43.2 wants 16 alpha.

Hi, thx @simonmitchell for your PR, you just forgot to update xcodeproj references. I created a new PR about it => #1224

This is a dup of https://github.com/airbnb/react-native-maps/issues/1193 and there's another PR https://github.com/airbnb/react-native-maps/pull/1195 (I think that makes three!)

@bberthelemy I shouldn't have missed anything, you just happen to have more changes to your project file which I can only assume are from changes you've made on your fork :)

I have no such file or directory: react-native/React/Views/RCTConvert+MapKit.m error. What should I do?
"react-native": "0.44.2",
"react-native-maps": "0.15.2"

That was part of the maps component bundled with RN, which has now been removed from RN. You can remove your references to it - it's not needed for react-native-maps.

@rh389, and we are these references?

Since the error is showing a full path like that, my guess is that it's referenced in your project file, or maybe the project file of another dependency, or maybe you're using CocoaPods and haven't updated your installation since updating RN. You'll have to have a look around - a text search on your project root should show it up.
All I can say for sure is that file was part of react-native in 0.43 and was removed in 0.44, and clearly you have something still looking for it despite using 0.44. The file at the path you mention is nothing to do with react-native-maps (since https://github.com/airbnb/react-native-maps/pull/1138) - it just happens to have the same name as the file in the OP's issue (which ironically is the reason the one in react-native-maps was renamed, which caused the OP's issue!).

I get this error, but i cant find the reference anywhere in the project, i'm searching for RCTConvert+Mapkit and it does not find anything. Sometimes the error disappears and everything works like it should. When i restart Xcode it appears again. Can this be some kind of a cache problem?

Anything we can do? We faced this issue also on a green field application based on RN 0.45

I recently made a fresh example build with pods and GoogleMaps with no issues.
https://github.com/alvelig/react-native-maps-pods-example.
Try to check it out or build through the README.MD. If it does not help, let me know.


Add Bismarck State College

@jaybyrd42 lib/domains/ndus.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@jaybyrd42 Please provide us with:

the school official website URL
the school street address, including city and country
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

@jaybyrd42 You might miss my previous comment. Please react.

@jaybyrd42 I am sorry, this request remains unanswered for a while. I have to close it without merging. Please reopen and comment if you have an update regarding the aforementioned issue. Thank you for your understanding!


while bundling the javascript code, the serialport import is not getting resolved

SerialPort Version
10.4.0
Node Version
v14.20.1
Electron Version
No response
Platform
Linux pterpnext 5.4.0-136-generic #153-Ubuntu SMP Thu Nov 24 15:56:58 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Architecture
x64
Hardware or chipset of serialport
Prolific
What steps will reproduce the bug?
While bundling the javascript code with 'bench build' in frappe framework (uses yarn and rollup), the serialport import is not getting resolved
What happens?
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by commonjs-external:stream, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'stream' is imported by<EMAIL_ADDRESS>but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
SyntaxError: Unexpected token (52:14) in<EMAIL_ADDRESS>heavy_check_mark Built js/posapp.min.js
sparkles Done in 2.022s
UNRESOLVED_IMPORT : 'tty' is imported by ../posawesome/node_modules/serialport/node_modules/debug/src/node.js, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'util' is imported by ../posawesome/node_modules/serialport/node_modules/debug/src/node.js, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'tty' is imported by commonjs-external:tty, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'util' is imported by commonjs-external:util, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'os' is imported by node_modules/supports-color/index.js, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : 'os' is imported by commonjs-external:os, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
UNRESOLVED_IMPORT : ' parser-readline' is imported by ../posawesome/posawesome/public/js/posapp/components/pos/ItemsSelector.vue?rollup-plugin-vue=script.js, but could not be resolved – treating it as an external dependency
Cannot find some dependencies. You may have to run "bench setup requirements" to install them.
What should have happened?
serialport import should have been resolved, because the package was installed in project folder, and 'yarn install' was also run
Additional information
No response

I'm sorry; I wasn't aware that Serial Port cannot be used in a browser app - closing this issue.


Optional Data sharing in runBiosimulations

Add a select box to runBiosimulations to allow the simulation results to be used as a part of a dataset for simulation/reproducibility studies.
Add a select box to runBiosimulations to allow the results to be publically available via a database

What is the purpose of the first point?
The second point could be addressed by a button to import a COMBINE archive into BioSimulations. However, this would be challenging to automate because this requires interpreting model files and supporting more of SED-ML.

I was thinking that a collection of simulation data might be interesting to Ion for example looking at  various simulators in terms of reproducibility/precision. It is also a general dataset that can perhaps be used for various machine learning/ statistical analyses. We can include the checkbox just so that if we later have some use for the data, it can be used

We would need to explain to users what the purpose is.
Alternatively, we could amend the terms of service to say (a) all submissions may be used to help improve the accuracy, precision, reproducibility, and consistency of simulation tools and (b) toward this end, they may be shared with the developers of simulation tools. The submissions would be used and shared in aggregate. This would enable us to use all data by requiring all users to opt-in to use the service. I see this as fairly similar to us collecting usage statistics to help us understand how many users use the service, from where, what simulators they use, etc for the purposes of improving the application.
@moraru, thoughts?

This will be folded into our new plan for populating the "platform".

User creates a simulation run (in RunBioSimulations)
User publishes this simulation run to the "platform" (BioSimulations)

Once published, the simulation can be used for any purpose permitted by its stated license, and a license statement (URL and human-readable description) will be required.


[QUESTION] Allowing nadeko to parse commands from another bot

I cannot find the entry point that excludes other bots from parsing nadeko commands.
How can I achieve this?
Thanks for the help in advance

https://github.com/Kwoth/NadekoBot/blob/1.9/NadekoBot.Core/Services/CommandHandler.cs#L234


Change indent char in nested lists

It would be nice if on nested lists, the indent char would change. I think it would be mode distinct.
eg.:
* one
    - a
    - b
        + x
        + y
    - c
* two

That's a nice idea. I'm going to make a note of it, and see how it feels when I've got some free time.


feat: Added features document.  Some corrections to components presence

Summary:
Closes #1661
Added a document with the list of components-features and how we determine if they are present.
Removed Blocks component
Corrected the code where components were duplicated because of a typo in their name,
Expected behavior:
I expect no change of behavior.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[x] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre This looks good! I think it would be good to link to the public GTFS components document in the "list of components" text at the top.

I thought the public GTFS components document was more a work document that was not that permanent.

@jcpitre This looks good! I think it would be good to link to the public GTFS components document in the "list of components" text at the top.

I thought the public GTFS components document was more a work document that was not that permanent.

It's being used in public facing meetings, so we can go ahead and add it. It's important context for anyone who reads the documentation and doesn't know what components are.

It's being used in public facing meetings, so we can go ahead and add it. It's important context for anyone who reads the documentation and doesn't know what components are.

Added the link


Build front-end for the app

I am thinking maybe React of Django. Contributions are welcome!

Completed in natquiz-web


Read only view in questions/forms too light

Describe the bug
The read only view on questions are a bit too gray (from my perspective) making them hard to read. I expect this to be an issue with quite a few of our users who may have poor eyesight.  I'm not sure if this is the Android default but I'd recommend we go with a much darker version of gray if possible.
Component
SDC library
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: [e.g. Pixel4a emulator]
Android version: [e.g. Settings -> About phone -> Android version]
Build number: [e.g. Settings -> About phone -> Build number]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle

@shelaghm

i agree with you here @mberg it's too light... we're just doing the default thing here... but may need to change that... thanks so much for the feedback!
does material have support for this type of stuff @shelaghm?

@jingtang10 @mberg @santosh-pingle
Yes, the contrast does seem very low, which makes this text not accessible/legible. Looking at the Material guidelines, they use 38% opacity for disabled text. @jingtang10 can you check what is implemented? From looking at colors in figma it looks like our implementation is a bit lighter than what's specified.
I recommend we use 38% Opacity of #000000 or 9E9E9E for disabled/read only text and containers.
However, I think there are two other UX challenges here.

It is not necessarily obvious to the user that this text is disabled/read only, just because we have applied the disabled text color style. I propose we add additional language in the 'helper text line' to the content pieces that are disabled to indicate they are read only/cannot be edited. (see screenshot)
It's uncommon to use the disabled text styling for such large blocks of text, and typically disabled text needs to be shown in comparison with enabled text for it to be obvious that it is disabled. I propose we increase the default to what's specified above and optionally add an icon to make it more clear it is view only. It might be a bit tricky to select an icon that is intuitive, that's where the 'helper text line' is crucial.

@santosh-pingle , please upload a screen shot once the changes are complete.

Thanks @shelaghm I think that looks a lot better!  I think having the eye in every field may be a bit more then what we want to go for.
For a bit of context, we'll probably be using this as an interim hack to view filled out forms for now.  I realize there are better UX approaches for that but that's an initial way I think people will be using it.
@jingtang10 do we have thoughts on a version of this can render a questionnaire response out in an array or some format we can visualize including support for things like skip logic?

@jingtang10 do we have thoughts on a version of this can render a questionnaire response out in an array or some format we can visualize including support for things like skip logic?

hey matt - not totally sure of the requirement here. do you mean like a summary table after the questionnaire is filled out?

@jingtang10
readOnly view state (text and the outline of the text box when state is disabled/enabled) are implemented for edit text view.
Created PR https://github.com/google/android-fhir/pull/939 for proposed solution, could you please check once?
Also, there are other views such as autoComplete view, checkbox group view, radio group view, datetime picker view, time picker view... and many more, do we need to apply readonly changes to all these views?
Please confirm once.
Before implementation
Edittext view with Mark input

After implementation
Edittext view with Mark input


How to connect to mqtt server

According to #25 the docker admin and pass should be set by env vars (MQTT_ADMIN and MQTT_PASS). I've setted these two, and then subscribed to the server with # to get all messages.
By subscribing to $SYS I can see there are 32 subscriptions active, but I can not see anything except for data I publish. Sensor data is being upated on the site, which makes me believe there should be traffic on the mqtt server.
Expected:

Subscribe to '#' with admin user
See all data from find3

Actually happening:

Subscribe to '#' with admin user
Nothing is published, ever.

I've also noticed any user can connect to the server, as said in #70
NOTE: I'm using the docker image.

Yeah something is wrong with MQTT on Docker it seems. I will give it a look in a week or so. Let's merge this discussion with #70


More entitiys like from the RCT-Portal

I would be very happy if it would be possible to get entitys as they are provided by the RCT-Power Portal.
I could already identify two by myself, it would be awesome if there is a chance to have for each showed value an own entity.
https://imgur.com/a/6nMuRs2
In the linked picture, I've put numbers below the entitys which I talk about.
1:
2:
3:
4:
5: sensor.rct_power_external_energy_production_day
6:
7: sensor.rct_power_grid_energy_production_day
Switched from "Today" to "All"
8: sensor.rct_power_all_generators_energy_production_total
9:
10: sensor.rct_power_grid_energy_production_absolute_total

Hey @Sectorchan, sorry for the delayed answer. I've never used the portal, but based on your screenshot this is my interpretation:

sensor.rct_power_all_generators_power
sensor.rct_power_consumer_power
sensor.rct_power_battery_power
sensor.rct_power_grid_power
This is not provided directly by the inverter, but calculated. If you use the energy dashboard of Home Assistant it will provide a percentage value for this.
same


ROX-20586: Adding title banner for new Overview Page

Should look as below:

This is encapsulated in a separate component for now (not rendered on the page, only shown above as illustration). I'm thinking of merging all changes related to this feature on the qa branches and once they're all good on qa, overriding the old Overview Page to look like the new one on qa, and then merging up prod in one swoop.
Alternatively, we could add a feature flag, but I'm not sure how that process is for ACSCS so I figured we can just keep it contained in the qa branches until it's ready to "flip" onto prod.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4dd19a2) 7.96% compared to head (617ce71) 7.96%.

:exclamation: Current head 617ce71 differs from pull request most recent head 0cbb22b. Consider uploading reports for the commit 0cbb22b to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #155   +/-   ##
=====================================
  Coverage   7.96%   7.96%
=====================================
  Files         37      37
  Lines        565     565
  Branches     113     113
=====================================
  Hits          45      45
  Misses       481     481
  Partials      39      39

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remaining arguments gets reparsed and split on spaces

Forked from spectresystems/spectre.cli#108 as requested
Scenario
My application wraps around execution of other applications so I need to pass all arguments as is, for example, this:
app run cmd -- /c "set && pause"

tells my app (app) to run (run) other application (cmd) and pass "other arguments "as is" (/c "set && pause").
I can see though that single argument "set && pause" get's reparsed as 3 "set", "&&", and "pause" (in context.Remaining.Raw) and I lose all clues that it ever was a single one.
Code
class Program
{
	static void Main(string[] args)
	{
		var testArgs = new[] {
			"run",
			"cmd",
			"-e", "A=7",
			"-e", "B=10",
			"--",
			"/c", "set && pause"
		};
		var app = new CommandApp();
		app.Configure(config => config.AddCommand<RunCommand>("run"));
		app.Run(testArgs);
	}
}

public class RunCommand: Command<RunCommand.Settings>
{
	public class Settings: CommandSettings
	{
		[CommandArgument(0, "<EXECUTABLE>")]
		public string Executable { get; set; } = null!;

		[CommandOption("-e <VAR=VAL>")]
		public string[] Environment { get; set; } = Array.Empty<string>();
	}

	public override int Execute(CommandContext context, Settings settings)
	{
		Console.WriteLine(JsonConvert.SerializeObject(settings));
		Console.WriteLine(JsonConvert.SerializeObject(new {
			Parsed = context.Remaining.Parsed.ToArray(),
			Raw = context.Remaining.Raw.ToArray()
		}));
		return 0;
	}
}

Expected
{"Executable":"cmd","Environment":["A=7","B=10"]}
{"Parsed":[],"Raw":["/c","set && pause"]}

Actual
{"Executable":"cmd","Environment":["A=7","B=10"]}
{"Parsed":[],"Raw":["/c","set","&&","pause"]}

(See: Raw array, expected 2 arguments, received 4 arguments)

@MiloszKrajewski Spectre.Cli have been merged into the Spectre.Console library. You might want to check the Migration guide to get this working.
Problem
The way you define the input is never how an application would be receiving them.
new[] {
    "run",
    "cmd",
    "-e", "A=7",
    "-e", "B=10",
    "--",
    "cmd", "/c", "set && pause"
};

It would expand to something like run cmd -e A=7 -e B=10 -- cmd /c set && pause.
Solution
The parameters run cmd -e A=7 -e B=10 -- cmd /c set && pause should be sent to the application as
new[] {
    "run",
    "cmd",
    "-e", "A=7",
    "-e", "B=10",
    "--",
    "cmd", "/c", "\"set && pause\""
};

or from the command line run cmd -e A=7 -e B=10 -- cmd /c "set && pause".
However, when I tried this I noticed a bug with string splitting. This has been corrected
and should work as expected in Spectre.Console version 0.37.

As long as it works (I didn't test it yet) it will be fine, but I'm afraid, you are not right saying: "The way you define the input is never how an application would be receiving them."
It does.
I used this "sophisticated" application:
static void Main(string[] args)
{
    foreach (var a in args) Console.WriteLine($">>> {a} <<<");
}

and ran it with:
app run cmd -e A=7 -e B=10 -- cmd /c "set && pause"
and received:
>>> run <<<
>>> cmd <<<
>>> -e <<<
>>> A=7 <<<
>>> -e <<<
>>> B=10 <<<
>>> -- <<<
>>> cmd <<<
>>> /c <<<
>>> set && pause <<<

Please note: no quotes set && pause are stripped by PowerShell (but it seems by cmd.exe as well) and argument is passed without them.

@MiloszKrajewski Yes, different shells does different things. You will need to quote the arguments for it to work.
If you're going to specify the arguments yourself from a .NET program you will need to quote them explicitly.

@MiloszKrajewski Try and see if the preview version works and get back to me. If there still are problems I can take another look tonight.

So I can work with that intercepting args and adding quotes around them.
Part of my confusion comes from the fact that they are treated differently before and after --, for example:
using System;
using System.Linq;
using Newtonsoft.Json;
using Spectre.Console.Cli;

namespace Spectre186
{
	class Program
	{
		static void Main(string[] args)
		{
			Console.WriteLine(JsonConvert.SerializeObject(args));
			new CommandApp<RunCommand>().Run(args);
		}
	}

	public class RunCommand: Command<RunCommand.Settings>
	{
		public class Settings: CommandSettings
		{
			[CommandArgument(0, "<ARGUMENT>")]
			public string[] Argument { get; set; } = null!;
		}

		public override int Execute(CommandContext context, Settings settings)
		{
			Console.WriteLine(JsonConvert.SerializeObject(settings.Argument));
			Console.WriteLine(JsonConvert.SerializeObject(context.Remaining.Raw.ToArray()));
			return 0;
		}
	}
}

This application prints:

arguments received (string[] args)
arguments parsed
arguments remaining (raw)

so when executed with:
app XXX -- YYY
I would expect:

received: ['XXX', '--', 'YYY'] (3 args)
parsed: ['XXX'] (1 arg)
remaining: ['YYY'] (1 arg)

...and that's what I get.
The confusion starts when parameters may have spaces in them:
app "three words before" -- "three words after"
as I get:

received: ["three words before","--","three words after"] (3 args, as expected)
parsed: ["three words before"] (1 arg, as expected)
remaining: ["three","words","after"] (why three? I would expect one argument)

I would expected that from initial args all arguments after -- are passed as-is (so one arg), because that's how it is on initial string[] args.
It is, of course, better than in previous version, as I can remove those extra args (behind '--') before passing them to CommandApp.Run and inject them into a command myself.
I know I'm a little chaotic, so if you have problem understanding my random stream of consciousness let me know.
Would like this project zipped?

@MiloszKrajewski The first one is an argument, so the parser knows that the provided string is a string and treats the input as such. The remaining arguments however can't be reasoned about in the same fashion. When we tokenize it, we treat the raw parts as words if they're separated by space. three words after could theoretically be three consecutive commands three, words, and after.
We could perhaps change this but I would need to investigate it a bit tonight.

I guess I just interfered with some design choices you made and they are not fitting exactly how I would reason about "remaining arguments". I absolutely understand how difficult it could be to change something like this when API is settled and library is used (by others! who may actually rely on this behaviour).
What I can offer is the justification to not break those "three words after":
They has been received as one arg (in void Main(string[] args) sense).
If they have been received as one arg, therefore they must have been quoted on command line.
If they have been quoted it must have happened intentionally (well, let's say I've quoting string in argument list by accident is low probability event).
If someone quoted them intentionally, he/she wanted them (words) to to be passed as one argument.
Anyway, regardless of your decision I know how to work around this, so I'm fine(-ish).

@MiloszKrajewski I'm actually quite open to changing this behavior. Your justification makes sense 😊

Hi Patrick Svensson,
Can i know details about joshua borre he prison in marikina city jail ?
Please answer my question.
Thank you ❤
On Thu, Dec 31, 2020, 4:53 AM Patrik Svensson<EMAIL_ADDRESS>wrote:

@MiloszKrajewski https://github.com/MiloszKrajewski I'm actually quite
open to changing this behavior. Your justification makes sense 😊
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spectresystems/spectre.console/issues/186#issuecomment-752754924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR4WWHXGALCWWG5V3ZMQ3BDSXOHM5ANCNFSM4VODNJQQ
.

@MiloszKrajewski I think I have a solution now for your problem.
@mhenggay21 I have no idea what you're talking about. Sorry.

@MiloszKrajewski I've merged a potential fix to your problem. Could you check and see if it does what you expect it to now?

@MiloszKrajewski I've merged a potential fix to your problem. Could you check and see if it does what you expect it to now?

Yes it is what I would expect.
Although... I by accident discovered unrelated bug (I managed to freeze/infinite loop parser).
I'll create new issue.

Yes it is what I would expect.
Although... I by accident discovered unrelated bug (I managed to freeze/infinite loop parser).
I'll create new issue.

@MiloszKrajewski Btw, I notice that you're trying to parse the form -e FOO=BAR -e BAZ=QUX. This is already supported. Just set the type of your Environment property to ILookup<string, string>, and it will be mapped automatically.
public class Settings : CommandSettings
{
	[CommandArgument(0, "<ARGUMENT>")]
	public string[] Arguments { get; set; } = null!;

	[CommandOption("-e <VAR=VAL>")]
	public ILookup<string, string> Environment { get; set; }
}

The types ILookup<string, string>, IDictionary<string, string> and IReadOnlyDictionary<string, string> will work here, but the two latter will, of course, not support multiple values for the same key.

@MiloszKrajewski Btw, I notice that you're trying to parse the form -e FOO=BAR -e BAZ=QUX. This is already supported. Just set the type of your Environment property to ILookup<string, string>, and it will be mapped automatically.
public class Settings : CommandSettings
{
	[CommandArgument(0, "<ARGUMENT>")]
	public string[] Arguments { get; set; } = null!;

	[CommandOption("-e <VAR=VAL>")]
	public ILookup<string, string> Environment { get; set; }
}

The types ILookup<string, string>, IDictionary<string, string> and IReadOnlyDictionary<string, string> will work here, but the two latter will, of course, not support multiple values for the same key.


Clarify _exmpl_band_gap vs _exmpl_bandgap lexical examples

We provide band_gap and bandgapas two examples for valid property names and filter examples. Whilst they are both valid, this may be confusing to readers, so we should change them (or provide alternative examples).

Good catch. While these nonstandard properties are used only in examples, consistency is important in examples too. I would suggest using one of these spellings based on which is more common among people dealing with band gaps.

Good catch.

We have the the paper reviewer to thank!

While these nonstandard properties are used only in examples, consistency is important in examples too. I would suggest using one of these spellings based on which is more common among people dealing with band gaps.

Yep, I'll prepare a PR later on.


Message must have the property "blocks"

repo subscription skipped invalid message ValidationError: Message must have the property "blocks"
after running the feed-generator, I got this exception quite a lot lately.
Am I using outdated lexicon ? seems some commits from firehose doesn't return with blocks

I have started to get this lately.  So much so that it's happening every couple of seconds now and my whole feed has stopped working.

https://bsky.app/profile/bnewbold.net/post/3lbikcy3jms2g
Explains why @peem5210


Rebase

Targetting the updated main branch for this work.

@agateaux I'm reopening this one to address the conflicts. Would you mind taking a look? FYI this was already merged in https://github.com/plotly/paketo-buildpacks_poetry-install/pull/2 before the branch fixes for the release flow.

@agateaux I'm reopening this one to address the conflicts. Would you mind taking a look? FYI this was already merged in #2 before the branch fixes for the release flow.

Ok, done

Pr for 5.4 create here: https://github.com/plotly/paketo-buildpacks_poetry-install/pull/5


Fix wrong query condition

Fix #2857

Coverage remained the same at 17.245% when pulling b3cda73c4df03e20227545796b4f1cdaa9269eef on log-query into ee7c4180cac01c5a0f253632007b7fcd31e238ef on master.


fixes #15 -<EMAIL_ADDRESS>not found on NPM Registry

CLA is valid!

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

It was a (false alarm)[https://github.com/facebookincubator/create-react-app/issues/1339#issuecomment-270016392]


Issue with Comments/Diff Color

Hi, Lightless Theme is my favorite VSCode theme that I've found so far. The only real problem I have with it is the color of the comments and/or diffs.
The comments, for one, are somewhat dark, a little too dark; it would be nice if they had more contrast. Also, and more importantly, they can be very difficult to see in a diff addition, due to having low contrast difference with that background color:

(The problem here is on the right side, not the left. ;)

Hey, thank you for your feedback. At the moment the theme is just a combination of Deepdark by Nimbda and Material Theme by Mattia Astorino, in the future it might change a lot, as a temporary fix you could use this to customize the colors to your liking. But keep the feedback coming, we are more than happy to see people getting involved.

Thanks for getting back to me so quickly. Here's what I came up with:
    "editor.tokenColorCustomizations": {
        "[Lightless Dark Theme]": {
            "comments": "#585858"
        }
    },
    "workbench.colorCustomizations": {
        "[Lightless Dark Theme]": {
            "diffEditor.insertedTextBackground": "#00a78a20",
            "diffEditor.removedTextBackground": "#a7008a20"
        }
    }

This makes the comments just light enough that you're encouraged to read them, but still keeps it in line with the dark theme I think.
It also changes the diff colors to look like this:

The transparencies on both colors were cut in half, that looks sooo much nicer. I also changed the red to purple (copying the green and just swapping the red + green channels); I personally like that better and think it fits Lightless Theme better but if not I'd go with #a7001d20, or something like that but maybe a different red.

While we're on this subject, I almost forgot that there was 1 other issue I had. I had code like this that looked kinda ugly, too much red:

Not quite sure what to do about that one, but yeah. Blegh.


Time Keeper Component

Test component does not work. Need to fix that up in prep for api, actions, reducers, etc


Docs for command_track

Very simple code, no need for much documentation, documented mostly the functions(godoc is awesome).

@thekafkaf thanks for the tweaks.
@technoweenie @rubyist look ok to you?

Whoop, I missed the extra commits.  There's a few slight grammar changes I'd like to make first.

Thanks for this, @thekafkaf! Pending the few minor misspellings I noted, along with @michael-k's comment about the trackCommand documentation, this should be good to go 👍

Going to close this one out for now, if you want to come back to this in the future, please let me know! 😄


App lags when navigating to different screen

Platform
Flutter Mobile
Obfuscation
Enabled
Debug Info
Enabled
Doctor
➜  ~ flutter doctor -v
[!] Flutter (Channel main, 3.7.13-0.0.pre.2, on macOS 14.4 23E214 darwin-arm64, locale en-MY)
    • Flutter version 3.7.13-0.0.pre.2 on channel main at /Users/zhenhao.ng/OlaProjects/flutter
    ! Upstream repository git@github.com:olachat/flutter.git is not a standard remote.
      Set environment variable "FLUTTER_GIT_URL" to git@github.com:olachat/flutter.git to dismiss this error.
    • Framework revision 1a4884310c (12 months ago), 2023-10-04 12:28:33 +0800
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/zhenhao.ng/Library/Android/sdk
    • Platform android-35, build-tools 34.0.0
    • Java binary at: /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (Zulu <IP_ADDRESS>-CA-macos-aarch64) (build 1.8.0_392-b08)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode 15.3.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 14 (API 34) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 14.4 23E214 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 129.0.6668.58
    ! Error: Browsing on the local area network for Flamy's iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 3 categories.

Version
8.6.0
Steps to Reproduce

Use the app for more than approximately 20 minutes.
App will start to lag when navigating to other screen.

This issue only starts happening when we enabled Sentry in our new version of app.
When checking with CPU profiler, it seems Sentry is using much of the time. I'm wondering if SentryNavigatorObserver is causing our app to lag?

Looks related to this PR comment with span_frame_metrics_collector.dart:
https://github.com/getsentry/sentry-dart/pull/2106#discussion_r1762199270
Thanks in advance.
Expected Result
The app should not lag when navigating to other screen.
Actual Result
After using the app for more than approximately 20 minutes, the app will start lagging when navigating to other screen,
Are you willing to submit a PR?
None

could you try disabling enableFramesTracking in the initializet

@buenaflor do we have expected ETA for this fix?

I'll look at it asap so that we can get a fix out this
Does it only happen after using the app continuously for a long time?

It only happens after using app for long time. The app becomes smooth back after restarting.

@zhenhao-ola I tried to replicate this issue but wasn't able.
I created this sample project and tried it on my Pixel 7 Pro (latest Android 14) and Emulator (Android 13) both in debug mode.
I left the application open for more than 20 minutes and navigated between the screens at the beginning and after 20 minutes without a significant impact on the performance.
Please provide us with a minimal sample code, where this error occurs.
Here is my Flutter doctor.
fvm flutter doctor -v

[✓] Flutter (Channel stable, 3.7.12, on macOS 14.6.1 23G93 darwin-arm64, locale en-AT)
    • Flutter version 3.7.12 on channel stable at /fvm/versions/3.7.12
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d9e56e694 (1 year, 5 months ago), 2023-04-17 21:47:46 -0400
    • Engine revision 1a65d409c7
    • Dart version 2.19.6
    • DevTools version 2.20.1

[!] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/martin/Library/Android/sdk
    • Platform android-34, build-tools 35.0.0
    • Java binary at: /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_331-b09)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13 (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 128.0.6613.138

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 2 categories.

@martinhaintz maybe it could be that for some reason we keep adding frames (for example a long running span which shouldn't happen in normal cases)
afaik we don't have a cut off where we say at this point we will drop the frame tracking because the number of frames captured limit has been reached.
That's my hunch why this is happening

@buenaflor makes sense, but I tried adding
final transaction = Sentry.startTransaction('startUnlimitedSpan()', 'task');

in the build method of my root Widget above the MaterialApp Widget with no difference after 20 minutes. Or did you mean something different?
I updated my previous sample code project.

@martinhaintz maybe you could try adding 72000 entries manually to the data structure that holds the frame data and see how the UI behaves when scrolling, navigating and so on

@buenaflor I updated my sample code and added 72k custom data entries to the span(and did not send it), and the app still works quite well.
here is a screenshot of the cpu profiler

As far as I can tell from testing this does happen because we are processing too many frames in onSpanFinished.
But inherently the issue is: a span is running for too long. Frame tracking only activates when a span is started.
@zhenhao-ola do you have any long running span in the background?

Nonetheless, we should add a guard in which after a certain amount of time or number of frames it will reject the frame capture.

Not sure what long running span means.
Does bottom navigation tabs and their screens with AutomaticKeepAliveClientMixin count?

long running span meaning something like Sentry.startTransaction that never finishes.
We do frame tracking per span which means if it is running in the background for too long e.g 20 minutes, it just keeps accumulating frames over and over again without removing them from memory. that's why at some point it lags when we try to process them.
We are now going to add a limit so this 'overflow' won't happen.

long running span meaning something like Sentry.startTransaction that never finishes. I'm asking if you're using sentry integrations because many of them create those spans automatically which might lead to this.
We do frame tracking per span which means if it is running in the background for too long e.g 20 minutes, it just keeps accumulating frames over and over again without removing them from memory. that's why at some point it lags when we try to process them.
We are now going to add a limit so this 'overflow' won't happen.

I found that, It happens after integrated SentryAssetBundle.
Your demo sample didn't integrate SentryAssetBundle, so that is why the scenario is not happened in it.
Maybe some reason cause the first span in activeSpans is not removed, so no frame will be removed in frames .
line 87  in span_frame_metrics_collector.dart
      frames.removeWhere((frameTimestamp, _) =>
          frameTimestamp.isBefore(activeSpans.first.startTimestamp));

I observed that frames accumulating during app start up.
Hope that help.

Thanks for the info, in the sentry dashboard do you see any long transactions that are around 20 minutes?

Thanks for the info, in the sentry dashboard do you see any long transactions that are around 20 minutes?
I found several cases, like "Global Key#xxxx" which are long transactions without detail info in its detail screen

Below one looks like a suspended case, but not sure

Hi @buenaflor Can we know the release date for the next version of SDK that includes this PR?
CMIIW, the newest SDK version 8.9.0 does not contain this fix yet. https://github.com/getsentry/sentry-dart/releases

@zhenhao-ola hey we're running some final tests and will release a pre-release this week which will include the fix

Waiting for that fix as well. Not sure if that is the same issue, but Sentry causes enormous lagging/performance issues after couple hours of alive app (tested with turn on/off Sentry, without it all is good after even 24h)

@marcinFDT pls read this comment for more context why this might happen: https://github.com/getsentry/sentry-dart/issues/2298#issuecomment-2373770916

We just released Sentry Flutter 8.10.0-beta.1 which includes the fix, please give it a try

Or I'm not 100% sure if that is fixed. I have user who had app opened for 4 days and he complains about the lags. It's really difficult to investigate that

@marcinFDT is there any more info on what exactly lags? navigating to a new screen?
If you like you can also test it by setting options.enableFramesTracking = false and see if it still lags after long usage


Passing opts to /usr/bin/env fails on linux

Passing options to /usr/bin/env in a shebang like this fails on linux.
$ bundle exec exe/cfme-versions
/usr/bin/env: ‘ruby --disable-gems’: No such file or directory
/usr/bin/env: use -[v]S to pass options in shebang lines

https://unix.stackexchange.com/a/63981

Since the version is based on an actual released version how do I release this? 😕

Since the version is based on an actual released version how do I release this? confused

@simaishi can you do a new CFME build? :laughing:

Since the version is based on an actual released version how do I release this? 😕

@agrare @Fryguy Done:  https://github.com/RedHatCloudForms/cfme-versions/pull/7


Use Airbrake.js?

It looks like the 4.x series of the Airbrake gem removed JavaScript notification functionality.
I'm assuming we want JavaScript notification by default?
It looks like it has been moved to https://github.com/airbrake/airbrake-js
The README seems to suggest that we should install it like so?
curl https://raw.githubusercontent.com/airbrake/airbrake-js/master/airbrake-shim.js > vendor/assets/javascripts/airbrake-shim.js

I think we should probably try this out somewhere to see if it's useful before adding it to Suspenders.
If we did add it, I think I'd be more comfortable pointing at a tag or something rather than master.

Merged the Airbrake.js change into FormKeep, the world's greatest form backend for static sites. Will report back.

How is this experiment on the world's greatest form backend for static sites going, @croaky? Do we have/need a research Trello card for it?

Also, @ckundo will try it soon, let us know how it goes!

@tute I'm working with Stripe.js, not airbrake.js. I've got no skin in this game :)

Looks like either FormKeep's JavaScript is error-free or Airbrake.js isn't reporting.

@croaky news on our Airbrake.js experiments?

@jsteiner does FormKeep use Airbrake.js? Should it be part of suspenders?

Closing for lack of activity.


Remove: imagePullSecrets from values.yaml

Issue - https://github.com/giantswarm/roadmap/issues/1022

Merging this one to create a new release for v17.4.0. Thanks @zewolfe ❤


Emails not being issued

Currently emails are failing when users are added to Mauro or the password has been reset.
Will the "Date/Time" column be populated when the email issue is fixed.

Currently you do not have a SMTP server setup yet on Mauro to actually send emails, this is a delay caused by your NHS networking team. Please check with Steve Bowring of when the status of this will be unblocked.

OK but will the "Date/Time" column be populated when we have a SMTP server setup?

Peter has demonstrated this but it still doesn't work for us.
@GSChandel - I have put this in the backlog but feel free to move it to where you think it should be.

Closing - SMTP function won't be setup. We will be using OpenID to login using Single Sign On. In addition, SMTP function stores the email (with password) that is sent to the user, and has been flagged by Cyber as a significant risk.


[WIP] Adds triggers for testing

What kind of change does this PR introduce?
Fix #114

Adding the following list to keep track of development.
PR Status:

[x] GET /triggers
[ ] GET /triggers?name=test_trigger&table_name=users
[ ] POST /triggers
[ ] DELETE /triggers?name=test_trigger&table_name=users
[ ] PATCH /triggers
Trigger properties that can be changed

[ ] Name
[ ] Extension dependence
[ ] Enable/Disable

The following are examples to test /triggers endpoints from 987f84fb6452391b4ca460dd709ffeb56cb720f0:
Setup:
create table public.users_audit (
    id BIGINT generated by DEFAULT as identity,
    created_at timestamptz DEFAULT now(),
    user_id bigint,
    previous_value jsonb
);

create function public.audit_action()
returns trigger as $$
begin
    insert into public.users_audit (user_id, previous_value)
    values (old.id, row_to_json(old));

    return new;
end;
$$ language plpgsql;

POST /triggers

Body:
{
    "name": "check_update",
    "table": "public.users",
    "timing": "before",
    "event": "update",
    "function_name": "public.audit_action",
    "orientation": "row"
}

GET /triggers

GET /triggers/:id (Grab the id from previous GET response)

PATCH /triggers/:id

Body:
{
    "name": "check_update_update",
    "is_enabled": "false"
}

DELETE /triggers/:id

@kiwicopple @soedirgo I have a bit more work to follow up https://github.com/supabase/postgres-meta/commit/987f84fb6452391b4ca460dd709ffeb56cb720f0 but wanted to push up my progress so everyone can play around with the endpoints and provide feedback.

@soedirgo thanks so much for the review!


Date Picker in Bottom sheet not filling up width.

Please consider making a Pull Request if you are capable of doing so.
Library Version:
3.0.0-rc4
Affected Device(s):
Google Pixel 3 XL with Android 9.0
and Pixel XL 10 (Beta)
Describe the Bug:
The Date window within a bottom sheet does not fill the dialog up all the way, width wise.
Time Dialog is fine.

To Reproduce:

Implement the date/time dialog in a bottom sheet or install the sample app.
Open said dialog.
Observe :)

Expected Behavior:
The Date window should fill the dialog up as much as it can.
Thanks!

Yes, my current plan is to integrate my new date picker library. Google's is not responsive.

What about the new material date pickers of the material design library?

What about the new material date pickers of the material design library?

https://material.io/design/components/pickers.html
That would also be the easiest way to stay up-to-date with the material design specs.


Bump puma from 3.8.2 to 3.9.1

Bumps puma from 3.8.2 to 3.9.1.

Release notes
Changelog
Commits

(Generated using Dependabot.)

Please interact with us prior to opening automated pull requests ❤ 🎉

Er, this isn't automated - I ran it on my fork and picked the dependencies you'd probably most want to update. Sorry!

@greysteil Apologies, I misunderstood the "Generated using..." bit of the message.  When we update dependencies, it tends to be a whole shebang a la bundle update, so this type of PR is a bit out of place.  If you're using this project in a way that needs specific deps updated, I'd love to discuss it over in an issue 👍


added extra info in rasa --version command

Proposed changes:
This PR implements the changes proposed here. The idea is to add extra information to the rasa --version command so that it is less effort to file a bug report.
This is the new behavior.
> python -m rasa --version
Rasa Version     : 1.9.7
Python Version   : 3.6.8 (v3.6.8:3c6b436a57, Dec 24 2018, 02:04:31)
Operating System : [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]
Virtualen Env    : /Users/vincent/Development/rasa/venv
Rasa SDK Version : 1.9.0

If you don't have rasa-x locally it won't print it.
> python -m pip uninstall rasa-sdk
> python -m rasa --version
Rasa Version     : 1.9.7
Python Version   : 3.6.8 (v3.6.8:3c6b436a57, Dec 24 2018, 02:04:31)
Operating System : [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]
Virtualen Env    : /Users/vincent/Development/rasa/venv

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

CI seems to complain about lines that are in master, found here.

Fixed a bug such that this will work outside of a virtualenv. The previous implementation looked at the environment variable for python path. It is now retreived from sys.path.
>  rasa --version
Rasa Version     : 1.10.0a3
Python Version   : 3.6.8 (v3.6.8:3c6b436a57, Dec 24 2018, 02:04:31)
Operating System : [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]
Python Path      : /Users/vincent/Development/rasa/venv/bin
Rasa SDK Version : 1.9.0

Mhmmm....
 FAILED: /home/runner/work/rasa/rasa/.pytype/pyi/rasa/__main__.pyi
/home/runner/.cache/pypoetry/virtualenvs/rasa-wb3tDUZd-py3.7/bin/python -m pytype.single --imports_info /home/runner/work/rasa/rasa/.pytype/imports/rasa.__main__.imports --module-name rasa.__main__ -V 3.7 -o /home/runner/work/rasa/rasa/.pytype/pyi/rasa/__main__.pyi --analyze-annotated --nofail --quick /home/runner/work/rasa/rasa/rasa/__main__.py
File "/home/runner/work/rasa/rasa/rasa/__main__.py", line 81, in print_version: Can't find module 'rasax.community.version'. [import-error]

I get why the Code Quality tool is complaining here, but then again, I don't see a way around this. We need to try to import something and we don't know if it is installed. I could remove rasa-x here since some of the time this information is not fetched from the command line but it feels like this command show list all relevant items. Would love to get advice on this.

@erohmensing I have now removed the check for rasa-X. It was giving build errors, but since typically people do not have rasa-x locally installed anyway it felt like something best removed.

@koaning maybe we can make pytype ignore the import error then? https://github.com/google/pytype/issues/163

The DeepSource: Python is currently complaining about these lines of code.
It is importing os and sys inside of a function that does not have a docstring is the complaint. I could fix it, but the comment # Running as a standalone python application makes me think twice about it.

It's fine to not always do exactly what deepsource says, though i was going to recommend a docstring because it's not just putting out the rasa version as one might expect

Sorry to clarify -- if deepsource is yelling at code that's not yours, don't worry about it. But a docstring for version() might be nice.

@erohmensing I think everything is now covered. The deepsource still complains about lines of code outside of the ones I made the code changes based on your comments.


Supporting Enum

Before I roll my sleeves up and try a PR is there a reason Enums are not supported, or is there something tricky about them I won't expect?
I can't remove the bug label. Can we get a new issue template that isn't bug or vulnerability?

Hi! I don't expect anything tricky about supporting Enums. It wasn't added because we didn't have any use cases to coerce Enums 😃 your contribution is definitely welcome here!!

I can't remove the bug label. Can we get a new issue template that isn't bug or vulnerability?

That's good to know! I will look into this.

Done! https://github.com/chanzuckerberg/sorbet-coerce/pull/46


Run ANALYZE after grafting

Fixes #3153.

I'm not sure if transforming the analyze async function to sync is desirable, but I assumed that would be easier than converting the upstream call hierarchy to async.
I'll be happy to implement it the other way around if it is preferable.

I'm not sure if transforming the analyze async function to sync is desirable, but I assumed that would be easier than converting the upstream call hierarchy to async.

I think removing the async is fine - the old use was in the CLI, where it doesn't really matter, and the new use is in a blocking context already, so not having async shouldn't be a problem.
It would probably be better to use the existing conn though in start_subgraph rather than getting a new one for each analyze command; that would require splitting the current analyze into an analyze and analyze_with_conn where analyze gets a connection and calls analyze_with_conn, and analyze_with_conn gets a conn: &PgConnection as an additional argument.


Suggestion: Improve Compare-Object by adding set operations (union, intersection, symmetric difference, relative complement)

This suggestion is the result of a conversation between @iSazonov  and me - see #4293.
The idea is to introduce new parameter sets that:

frame the operations in the more established set-theory terms
while introducing the relative-complement operation to make it easy to determine the objects unique to one side.
make it easier to retrieve just the selected input objects (without the custom-object wrapper that contains the .SideIndicator property
improve the performance of certain use cases

Below are examples of each desired new parameter (parameter set) that would be mutually incompatible and also incompatible with the current parameter sets.
Aside from referring to the desired set operation, their desired behavior is expressed as s command using Compare-Object's current capabilities:

Compare-Object -Union $A $B: union (A ∪ B)
Compare-Object $A $B -IncludeEqual -PassThru

Compare-Object -Intersection $A $B: intersection (A ∩ B):
Compare-Object $A $B -IncludeEqual -ExcludeDifferent -PassThru

Compare-Object -SymmetricDifference $A $B: symmetric difference (A ∆ B) - the same as the current default behavior, but without the wrapper objects
Compare-Object $A $B  -PassThru

Compare-Object -Complement $A $B: relative complement (A ∖ B) - getting objects unique to $B
Compare-Object $A $B  | ? SideIndicator -eq '=>' | % InputObject

Note that all commands above (effectively) suppress the custom-object wrapper with the .SideIndicator property and return the selected input objects directly (or, with -Property specified, the resulting [pscustomobject] instance would lack the .SideIndicator property).
One thing to note is the order in which objects are output - this is not currently documented (from a set perspective, order doesn't matter, but for subsequent processing it may), and I haven't dug into the source to verify, but from what I can tell, it is:

== (identical) objects first
>= right-side-only objects next
<= left-side-only objects last

On a related note, adding a  new switch would make sense in order to return a hashtable of original objects grouped by what is currently the .SideIndicator value.
Two names have been proposed for this switch:

-Group
-AsHashtable

-AsHashtable has the advantage of being familiar from Group-Object, although there it doesn't indicate a fundamental change in output structure.
The following example uses -Group for now:
$A = 1, 2, 3, 4
$B = 1, 3, 4, 5

# Wishful thinking
Compare-Object -Group -Union $A $B

The above would yield the equivalent of:
@{
  '==' = 1, 3, 4
  '<=' = , 2
  '=>' = , 5
}

Environment data
PowerShell Core v6.0.0-beta.4

I like this quite a bit. Compare-Object has long been... lacklustre... in implementation. I would personally also prefer if rather than ==, <=, and => symbols for the grouping (or indeed even for the current behaviour) the labels were changed to match the actual parameters the objects are passed to (i.e., ReferenceSet, DifferenceSet, and Both)
Currently the default display is actually surprisingly difficult to make sense of in my opinion with any appreciably large comparison sets. It may even make more sense for the default display to actually do a Format-Table -GroupBy Label similar to how GetChildItem will group the table display by folder in a recursive search. It would make comprehending the data you're getting significantly less befuddling. :)

Good point re default output format, @vexx32. Can I suggest you create a new issue to propose the grouped output?
As for the .SideIndicator property values: I fear that ship has sailed, as the value of that property is used programmatically. (We could transform the values just for display, but the resulting discrepancy between what is displayed and what you need to use programmatically may be confusing).
As an aside: It's unfortunate that the property wasn't defined as an [enum] type to begin with.
Personally it took me a while to remember the logic of <= vs. =>; here's how I remember it now: the arrow points to the side the object at hand is exclusive to.

Oh, I get that, but it's not clear at a glance which side is actually which; you have to examine your objects' input data and see which is <= and which is =>
I'll type up an issue on it. Whether or not it's actually used (which, frankly, I very rarely see because of its obscure and unclear implementation) it needs to change.

I don't think  -Group parameter should be used. That starts overloading parameters when the original intent is to pipe to a standard set of cmdlets to do that, like Group-Object. It is not any more complex to use and keeps the cmdlet code clean.
Compare-Object -Group -Union $A $B
vs
Compare-Object -Union $A $B | Group-Object

Back to using Sets, it would be nicer to have one parameter, like -UsingSet, with the option of Union, Intersect, Except instead of separate parameters. Hopefully a better name than I came up with.

How many set operations exist out of the propose so that we want -SetOperation?


Added Tabular Regression Model using Boston Housing dataset

Following the path of other models in this repo, such as the CIFAR-10, I've added here a Tabular sample project to train a regression model on the Boston Housing dataset.

@JacopoMangiavacchi This dataset and the example are awesome! Hope you don't mind I amended some bits to make the README in line with the rest of the Examples in /swift-models/. The dataset description is from keras.io/datasets/. The PR in your forked repo is here: https://github.com/JacopoMangiavacchi/swift-models/pull/1 - feel free to edit it. Your contributions and presentations are awesome 🙌

@JacopoMangiavacchi May I also suggest to perhaps rename Tabular to Regression-BostonHousing or Regression-BostonHousing-Tabular. This should aid the discovery process for current and future s4tf users and would look more descriptive under /Examples, similar to: Custom-CIFAR10, LeNet-MNIST, MobileNet-Imagenette, ResNet-CIFAR10, and VGG-Imagewoof. (And if you choose to rename it, some bits in package.swift and other places may need to be revised too.)

@JacopoMangiavacchi May I also suggest to perhaps rename Tabular to Regression-BostonHousing or Regression-BostonHousing-Tabular...

Absolutely, I'm renaming this with Regression-BostonHousing


Fix findNodeAtPoint returns incorrect view

Summary:

This fix majority work is based off of hoxyq https://www.internalfb.com/diff/D56185630

Changelog: [Internal]
Expectation: In React DevTools, user should be able to select an element on screen and it will show you what React component rendered it. This doesn't work in RN app that is using JS navigation
Root Cause:
In Fabric, when we try to find ShadowNode in the ShadowTree, pointerEvents props are not considered during the lookup of node using coordinate. Hence, in React DevTools when we inspect element, it was hightlighting the overlay View with pointerEvents props box-none was getting highlighted instead of its children view in the hierarchy.
Differential Revision: D56334314

It was synced in this commit https://github.com/facebook/react-native/commit/a9a7382d95a9e44cd97ff47464262df5af2ab358?fbclid=IwAR0H8sIvG_wgJjzNyOAmXex4IGfparsJE8wqAT961LoeLCDsSAX_V8eBkwc


Add (very basic) IIIF support

Probably very hard-coded URI patterns, but long-term it sounds like chronam might be looking for IIIF URIs in order to make it easier to use external image servers.  I'd say we'd only need to support two URI patterns still, since this service is very specific to newspapers (and JP2 is very slow to manipulate in complex ways)

See Mirador shim for ChronAm data: http://showcase.iiif.io/viewer/mirador2/chroniclingamerica.html

@kestlund, is there something that describes what you're talking about?  I just see a viewer page, so I'm not really sure what you're suggesting I look at.  Is there code or a spec or something beyond the standard IIIF spec?

http://iiif.io/api/image/2.0/compliance.html
I think we could be level-1-compliant just by implementing the URL patterns, proper status codes, JSON return, and a few of the http features.

Hmm, though it's worth noting we want to support the "native" quality to be more backward-compatible with IIIF 1.1.  Open Seadragon only mentions 1.1, so that would be a must for now.  There may be other compatibility issues to sort through as well.

DONE!


Samba: Possible to use it as NAS with freely configurable User and Shares?

Hi,
is there something to be said against using the samba Plugin and Hass.io Server as an NAS?
Add some more shares with specific user and permissions?
The samba services works great for me but I want to store our data separately to the home-assistent files currently accessible via the samba addon.
best regards

Hi there,
That is not the goal of the add-on. It provide access to the configuration files of the Home Assistant eco system.
If you are in need for such a thing, you probably better of using your NAS itself for that.


Resources not Displayed/Blank Canvas at startup

Describe the bug
When I initially load the perspective tool, I do not see any resources, only a blank canvas.
The resources have been discovered. They are visible in search results and the sidebar
To Reproduce
Steps to reproduce the behavior:

Deploy Perspective
Sign in to Perspective
See a blank Canvas

Expected behavior
I expected to see the resources discovered by Perspective
Screenshots

Browser (please complete the following information):

Name Any
Version Any

If you encounter this scenario, try selecting a resource from the sidebar on the left. The initial canvas is blank. Resources are only displayed when selected.
We are investigating how to improve the UX in a future version.


[Enhancement] CITATION.cff, Initial Workflow and Further Documentation

Hello, @wert007,
I just added some of the suggestions from the following issues:

#2:  valid CITATION.cff and GitHub Action for automatic validation
#4:  documentation of the suggested build commands in the repository README

Since both the ideas for the definition of the GitHub Action and the minimal template for a valid CITATION.cff originate from blank, I added it as an initial reference.  Feel free to extend the list of references.
Furthermore, since GitHub would list me as a contributor on the project's welcome page anyway after accepting this pull request, I added my name to the list of contributors in the CITATION.cff.
Pleases consider to accept this pull request in order to make it citable and to extend the documentation.

Okay, I left a reply for your comments in order to explain the design choices behind them.
Regarding the commit messages:  these might be a tad more difficult; the pull request would need to be closed, the fork deleted and all changes committed again in a new fork to be pulled by a new pull request.  I would suggest to simply honour your recommendation in the future; the easiest thing would be to focus on the content, for now, and to merge this Pull Request using squashing.  That way, the non-descriptive messages disappear and I just need to correct my fork.  Would this work for you?
Regarding the feedback:  I consider it constructive and not harsh at all.  I agree with you that some decisions might be confusing at the beginning and I am okay with explaining their origins.  I am going to fix the obvious errors you named and then, I would like to discuss how to go on with the other points.

I think you can just use git rebase -i or some variation like `git rebase -i HEAD~11' to edit your commits.
Glad to hear you took it that way. 😄

By the way:  how about creating a first release after this Pull Request is merged?  Just to pin the repository state to a certain set of changes.

Why do you think a release is necessary? What would it bring to the table?

This is not going to be the last contribution to this project and it would help to keep an overview about the recently added features and would show how this project has grown.
I am serious with "This is not going to be last contribution" because I would like to try at least to implement the reading from stdin, for instance.

Please do that, I would be happy to see the results! 😄
But I've seen some of your repositories with 17 or 18 releases and I do not think this would be fitting here. To me a release is more for a kinda done product, where you transition into a bug fix phase. This is not the case right now, I think 😅

Now, all requested changes are realised.

Thanks for your work. Looking forward to future contributions! 😄


How to run repeated SQL Query on background

I'm building a finance app using the flutter_drift for SQLite database and work manager for background tasks.
Now I need a way to run an insert query in the background even if the app is closed every while like day/week/month.
I'm running what is below and I get a successful task from the workmanager but nothing is happening actually, no new records have been added to the table.
Also, I don't know if that is the right way to do such a task?!
What I have done so far in code:
void callbackDispatcher() {
  // configureInjection(Environment.prod);

  final AppDatabase database = AppDatabase();

  final ITransactionService transactionService = TransactionService(
    TransactionRepository(TransactionsDao(database)),
    ContactPickerService(),
    ImagePickerService(),
  );

  Workmanager().executeTask(
    (task, inputData) async {
      print(inputData);
      switch (task) {
        case 'repeatedTransaction':
          // final String tId = inputData['string'];
          final String? id = inputData?['string'];

          optionOf(id).fold(
            () => print('id is null'),
            (id) async {
              print('id is $id');
              final Either<TransactionFailure, TransactionDomain?> t =
                  await transactionService.findTransactionById(id);

              print(t.toString());

              t.fold(
                (l) => print('failure $l'),
                (transactionDomain) {
                  if (transactionDomain != null) {
                    print('transaction not null yaay');
                    final TransactionDomain newTransaction =
                        transactionDomain.copyWith(
                      id: UniqueId(),
                      date: TransactionDate(DateTime.now()),
                      isRepeated: false,
                    );

                    print(newTransaction);

                    transactionService.create(newTransaction);
                  } else {
                    print('no transaction found in the DB');
                  }
                },
              );
            },
          );

          break;
        default:
      } //simpleTask will be emitted here.
      return Future.value(true);
    },
  );
}

AppDatabase Class:
@singleton
@DriftDatabase(
  tables: [
    Users,
    Settings,
    Wallets,
    Transactions,
    Categories,
  ],
  daos: [
    UsersDao,
    SettingsDao,
    WalletsDao,
    TransactionsDao,
    CategoryDao,
  ],
  include: {'categories.drift'}
)
class AppDatabase extends _$AppDatabase {
  static const Uuid uuid = Uuid();

  AppDatabase()
      : super(SqfliteQueryExecutor.inDatabaseFolder(
          path: 'db.sqlite',
          logStatements: true,
        ));

  @override
  int get schemaVersion => 3;

  @override
  MigrationStrategy get migration => MigrationStrategy(
        beforeOpen: _beforeOpen,
      );

  Future<void> _beforeOpen(OpeningDetails details) async {
    if (details.wasCreated) {
      // create new settings row on database first created
      await into(settings).insert(
        Setting(
          isFirstLaunch: true,
          id: 1,
        ),
      );

      await defaultCategories();
    }
  }
}

I don't know what optionOf is, but it looks like there's a missing await somewhere? The (id) async doesn't seem to be awaited.
Does await optionOf<FutureOr<void>>(id).fold(...) change anything? I haven't used background tasks a lot, but I wonder if not awaiting things could lead to the Flutter engine being shut down before you writ to the database?

Closing this since it doesn't look like there's more I can do about this without more information.


Support for Launchpad Pro Mk3

Added support for Launchpad Pro Mk3 based on Launchpad Pro Device files plus modified init code from Launchpad Mk3 Device files.

@jmsole this looks great. Is it tested and confirmed to work? .. and sorry for the late response!

It's working well for me. I didn't assign any other functionality to the additional buttons the Pro MK3 has, but all the buttons shared between Pros work the same. I'll get your latest changes to my fork in a bit and resolve the conflicts.

@westlicht Merged your change from yesterday so no more conflicts.

merged now, there was an issue with filename upper/lower case, but i've fixed that in master
thanks for the contribution


Minimize the permissions of Environment Admin Role

Describe the bug
Attached is the review of enhancements (please check column status) and anything with NeedsFixing is top priority and has to be addressed . CleanupEnhancements are very important as access to unused resources is not good to have .
followed by Good Enhancement. Please let me know if questions. The items marked review are candidates that can be explored for further clean up. What would be good is if you can add version on which issue will be fixed against each item and that will give us clear idea of what to expect.
How to Reproduce
*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*

Expected behavior
Permissions for the environment admin role must be minimally permissive.
Your project
No response
Screenshots
IAMRolesandPermissionAnalysis-EnvAdminRole.xlsx
OS
All
Python version
3.10
AWS data.all version
v1.3,v1.4,v1.5
Additional context
Having Least privilige is always good. and we request you to minimize the permissions for pivot role so that it follows the principles of least privilege.

This item is duplicated: #462


Read and skip validity buffer of UnionType Array for V4 ipc message

Which issue does this PR close?

Closes #1788.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #1789 (2daae77) into master (940b5b5) will decrease coverage by 0.01%.
The diff coverage is 52.38%.

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
- Coverage   83.39%   83.38%   -0.02%
==========================================
  Files         198      198
  Lines       56171    56188      +17
==========================================
+ Hits        46846    46851       +5
- Misses       9325     9337      +12

Impacted Files
Coverage Δ

arrow-flight/src/utils.rs
0.00% <0.00%> (ø)

...ng/src/flight_client_scenarios/integration_test.rs
0.00% <0.00%> (ø)

...ng/src/flight_server_scenarios/integration_test.rs
0.00% <0.00%> (ø)

arrow/src/ipc/reader.rs
90.49% <73.33%> (-0.35%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.53% <0.00%> (-0.46%)
:arrow_down:

parquet/src/encodings/encoding.rs
93.46% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940b5b5...2daae77. Read the comment docs.

Thanks @nevi-me
Yes, if specifying metadata_version as V4, the ipc writer also need to write validity buffer for UnionType Array. Currently it doesn't, although it doesn't affect the interop test.
I will create another PR after this for writer change and test.


<IP_ADDRESS> Dark Mode - default=system, splash screen

It was a surprise to get <IP_ADDRESS> start first time with different colours from before. I think that the Dark mode switch should not default to "System" for first run for existing users, but instead to "Light". For first time users, I guess "System" has more meaning.

Splash screen should IMO always be shown as Light theme - because otherwise it looks weird as a negative image.

Whilst we are talking splash screen, I do now get the software version number. A few very minor points:

"Start" should be "Starting", "Load" should be "Loading"
The "Loading" line doesn't change much - I am not sure whether this is because there are few modules being loaded or because it is not updating frequently enough - I get "main module" and "GUI". But with only two modules, I am not sure whether it is worth having (especially as I imagine that the splash screen only loads when you are loading the GUI anyway). Without this being updated, you can close the splash screen just before you display the GUI window.

Update - splash screen showed correctly on my (non-production) laptop, but was still cropped to only part of the image on my Surface Pro 3.

The cropped image is part of issue #2728
Everything is else is a feature request

I disagree with the default for existing users resulting in a sudden switch to dark mode being a feature request. It was a bad feature enhancement that causes a significant hiccup to the user experience.

So we agree to disagree

Splash screen works with scaling of 150% (but not 165%) as suggested in #2731. Not sure what #2728 has to do with this, though.

Addressed in

https://github.com/meerk40t/meerk40t/commit/14db72f5dcf54954cdd1c3d55c52b2763746e5bb
https://github.com/meerk40t/meerk40t/commit/c27cf9eb777529a2dbcfefe6d89a5e3e36690cbd


Fix for Kerberos listener property

Updated property for every KRB listener, not just at the global level.
Description
Fixes the issue for when Kerberos based listener is setup with a combination of other types of listeners like OAuthBearer.
The property sasl.kerberos.service.name needs to exist at the listener level and not just at the global level.
Fixes # (issue)
Type of change

[Y] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Deployment.
Test Configuration:
Kerberos + RBAC setup
Checklist:

[Y] My code follows the style guidelines of this project
[Y] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[Y] My changes generate no new warnings
[NA] I have added tests that prove my fix is effective or that my feature works
[NA] Any dependent changes have been merged and published in downstream modules
[NA] Any variable changes have been validated to be backwards compatible

@waliaabhishek Really great catch here!  Looks like we handle this properly in the 6.0.0 branches, but not in 5.5.  Can you rebase this PR to 5.5.0-post and we can merge it up from there to make sure it gets in all 5.5.x branches.  @domenicbove  do you see any issues here?

Not sure why, but I was not able to reply to that quote above. The test case was very simple. We had a 3 ZK , 3 Broker setup with Inter broker setup on Kerberos and INTERNAL listener setup with RBAC/OAUTHBEARER. As soon as you have two listeners, the Kerberos connectivity was broken. We tried connecting with a Kafka Client using kerberos on the broker listeners and it would refuse connectivity.

Deprecating this one in favour of PR in 5.5.0-post branch.
New PR -- https://github.com/confluentinc/cp-ansible/pull/434


Is it works with storybook 6 ?

I'm getting an error

Thanks for reporting - can you please try removing your node_modules and re-install?and make sure all your storybook packages are on the same version.

Sorry - just saw your question about version 6 - not sure if thats the issue. I do have theming as a peer dependency https://github.com/atanasster/storybook-addon-deps/blob/555d3c132dab4615e1d080d8e01424778213a5b7/package.json#L36

closing for now, usually this issue is solved by removing the  node_modules and re-installing storybook


Laser crate changes

About the PR
Changes the laser crate access lock to armory instead of security.
Changes the laser crate's icon to the retro laser gun instead of the laser cannon.
Moves the category of the laser crate to armory instead of security.
Screenshots

Changelog
:cl: Nairod

tweak: Changed the laser crate to now require armory access.

Please fix your editor so it doesn't do this.


Bblock loader: unsubscribe

IR-361
Description of the Change
Blocks request obtains a timeout. It also checks whether there are subscribers on its observable when it gets unblocked. This makes possible further reworking the synchronization pipeline.
This is part of closed #2142.

Benefits
Block requests do not hang. Failing block application terminates blocks request.

Possible Drawbacks

Several tasks in jira should be created:
* make BlockLoaderImpl testable with grpc mocks

* test that deadline in context is set

* test that nothing is emitted if there are multiple blocks but no subscribers

The created tasks are IR-409 and IR-410.


The image search is not working properly.

Steps To reproduce--
1. log in as a user
2. Try to search the products by the image.
Actual result: The image search is not working properly. Please find the below screenshot.
Expected result: The image search should work properly

.

This is not a bug, search results come on the basis of analysis trained by the model. If keywords are not matched then the result may not come.


update plugged videos in landing page

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:
Change the plugged video in the main page
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ed9e0f0e33b913d90e740abbaa5a0ef2057eb8b4

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


pyproject.toml and setup.cfg

just use pyproject.toml where possible, setup.cfg otherwise
there's no need to create a configuration file for each tool

Most of those files are read by pre-commit. To decouple the pre-commit environment from the project's environment we use dedicated files.
In this way, the pyproject.toml is not affected by the pre-commit configuration files.
WDYT?


[#109] Add security group output

tested with local stack build

Maybe a little sloppy here, sorry. Added a few more things that I needed.

Hey @aarcro - can you break up these commits into separate PRs?  Seems like they aren't related.  Also it looks like you have some pep8 violations that need fixed.

Will re-open as separate issues