Accuracy of perf_get_mcycle() and perf_get_mcycle64() using Arty a7 100T board

Hi @tcal-x ,
I've tried to profile some cfu-function calls for my accel. design and as well as for a "test-setup". I'm seeing some unusually high cycle times. For ex:- Using the basic template cfu.v file:
// Trivial handshaking for a combinational CFU
  assign rsp_valid = cmd_valid;
  assign cmd_ready = rsp_ready;

  //
  // select output -- note that we're not fully decoding the 3 function_id bits
  //
  assign rsp_payload_outputs_0 = cmd_payload_function_id[0] ?
                                           cmd_payload_inputs_1 :
                                           cmd_payload_inputs_0 ;

And using the "test-setup" code in the header file:
/*Single cycle cfu test*/
  int start_cfu_comb = perf_get_mcycle();
  int test_3 = cfu_op1(0,1,2);
  int test_4 = cfu_op0(2,1,2);
  int test_5 = cfu_op1(1,3,4);
  int test_6 = cfu_op0(0,4,5);
  int end_cfu_comb = perf_get_mcycle();
  printf("test_3 %d\n", test_3); //Exp: 2
  printf("test_4 %d\n", test_4); //Exp: 1
  printf("test_5 %d\n", test_5); //Exp: 4
  printf("test_6 %d\n", test_6); //Exp: 4
  printf("Time taken (perf ) %d\n", end_cfu_comb- start_cfu_comb);
  //Breaker
  while(1==1);
  printf("Done\n");

When running the above and profiling via perf_get_mcycle ( or mcycle 64) on the Arty a7 100T board @ 70 MHz clk rate, I'm getting cycle times around 180 (mcycle64()) and 92(mcycle()) for the above setup. It should ideally be around 4-6 cycles, so is there any issue with perf_get_mcycle() or mcycle64() ?
I'l try using custom counters in the cfu file to check it as well.
Please let me know soon.
Thanks,
Bala.

An update:
Following is the disassembly with 4 cfu instructions for conventional compute, 1 other cfu instructions (for time profiling). Even with custom counters, Im observing that the time taken  to come from cfu[0,0] instr to cfu[2,0] instr is around  86 cycles which is surprising since I thought the Vexriscv core is pipelined. Does this mean the Vexriscv core ( with default core chosen) is not being properly pipelined when synthesized on the arty a7? Or another possible issue being the RAM not being pipelined properly and hence when fetching instructions from I-MEM it's taking a long time ?
40020be8:	00fa858b          	cfu[0,0]  a1, s5, a5
40020bec:	04fa8a8b          	cfu[2,0]  s5, s5, a5
40020bf0:	00400793          	li	  a5,4
40020bf4:	00300913          	li	  s2,3
40020bf8:	02f9090b          	cfu[1,0]  s2, s2, a5
40020bfc:	00500493          	li	  s1,5
40020c00:	0697848b          	cfu[3,0]  s1, a5, s1
40020c04:	00000793          	li	  a5,0
40020c08:	00f7b40b          	cfu[0,3]  s0, a5, a5

I got these messages when synthesizing too:
INFO: [Synth 8-3971] The signal "VexRiscv/RegFilePlugin_regFile_reg" was recognized as a true dual port RAM template.
RAM Pipeline Warning: Read Address Register Found For RAM tag_mem_reg. We will not be able to pipeline it. This may degrade performance.
INFO: [Synth 8-5784] Optimized 4 bits of RAM "tag_mem_reg" due to constant propagation. Old ram width 24 bits, new ram width 20 bits.
RAM Pipeline Warning: Read Address Register Found For RAM tag_mem_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM mem_1_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM mem_1_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM data_mem_grain0_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM data_mem_grain0_reg. We will not be able to pipeline it. This may degrade performance.
.
.
.
RAM Pipeline Warning: Read Address Register Found For RAM data_mem_grain12_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM data_mem_grain12_reg. We will not be able to pipeline it. This may degrade performance.
RAM Pipeline Warning: Read Address Register Found For RAM data_mem_grain13_reg. We will not be able to pipeline it. This may degrade performance.

If you could suggest some flags or some settings to modify the Vexriscv core and it's RAM to sort of pipeline it a bit better, that would be very helpful
In my main basic simple accel design (with one compute unit), I'm experiencing the setup running faster without the basic accelerator than it is with an accel. peripheral surprisingly so, I wanted to ask this. Hopefully, in a large accel design, it will give performance boosts by parallel computes; avoiding memory accesses and also probably mainly reducing the total instructions read which seems to be the bottleneck here
Please let me know about this soon.

Hi @bala122 , sorry for the delay; I'll try to take a closer look soon.

FYI @dolu1990

@bala122 , can you provide the following information:

which CPU variant you're using (or if it's one you created yourself, what is the configuration?   ICache size etc)
which toolchain (Vivado I assume?) and version you're using (I'm using Vivado 2019.1)

I'm running the snippet you provided to time 4 consecutive CFU instructions, putting it all in a loop, and once the loop is running, it reports 12 cycles elapsed (using $mcycle).

Hi @tcal-x ,
Im currently using the default soc ( common_soc) without providing flags for modifying any of its parameters.
Yes, Im currently using vivado 2020.2 ( as far as I know its this,  but will confirm later too).
Are you also getting the RAM pipeline warnings that Im getting?

@bala122 , I DO have those warnings from Vivado.
The first time the test sequence is executed, 91 cycles elapse (presumably due to I-cache misses).
For each subsequent time, 12 cycles elapse.

The first time the test sequence is executed, 91 cycles elapse (presumably due to I-cache misses).

Sound right :)

Ok, sure @tcal-x  and @Dolu1990 , Thanks for that. Is there any way to change the I-cache parameters- like no. of sets, ways and also if possible its size so that the contribution to I-cache misses to runtime is reduced. Reading instructions from I-Mem or I-cache is a sort-of regular sequential task (ie, fetching instructions one-by-one after another) and I want to mainly focus on DMEM accesses which can be long due to irregular memory accesses that we see usually in conv2d or other functions. So, I want to simplify my problem of profiling the runtime by only dealing with those DMEM accesses first.
Thanks,
Bala.

Hi @tcal-x  and @Dolu1990 ,
I've tried building a custom cpu variant using sbt and scala with the following makefile command:
VexRiscv_CustomNewCfu.v:` $(SRC) Makefile
	sbt compile "runMain vexriscv.GenCoreDefault --dCacheSize 4096 --iCacheSize 16384 --csrPluginConfig linux --cfu true --iBytesPerLine 64 --outputFile VexRiscv_CustomNewCfu"

Originally, the wayCount was 1 , since csrPlugins flag was 'all'. This was changed to 'linux' to increase the number of ways in the i-cache , in order to reduce misses. I've even tried to increase the bytes per line to 512(too big actually), but it didn't reduce the runtime at all.
Here's a basic calculation of the codesize I made based on some assumptions:
The part of the code I want to accelerate has around 300 lines in instructions in the disassembly which corresponds to around 300*4 bytes = 1200 bytes of memory in instruction mem. This is around 2.3- 3 cache lines with a 512 byte block size. So, the full code in itself which can fit in within 3 cache lines (using I-cache which has around 4 waycounts ), should infact not give misses after its fetched once- since the full code can fit in the cache.
The surprising part is the profiling results before and after upgrading I-cache
Before upgrade: ~21M cycles
After upgrade: ~21M cycles again.
Please let me know if there could be any other issue causing this- maybe in synthesis/ in generating the i-cache of such size itself.
Thanks,
Bala.

Please let me know about the above soon.
Thanks,
Bala.

Hi, @tcal-x and @Dolu1990 ,
I realised my mistake. I think the framework is fine. I had a lot of stores/ loads causing many dcache misses. I had thought they were Icache misses initially.
I'll let you know if I have any further concerns.
Thanks,
Bala.

Cool :)

Hi @bala122 , thank for posting your findings here, we really appreciate it.
I had a couple of comments in case you suspect I-cache misses again in the future:

of course, doing some warm-up first to get code into the icache initially is useful, before you start profiling.
If there is a code address collision forcing icache misses, there are ways to fix certain routines at certain offsets to avoid the collision, using the linker.ld script (here's a commit that does some interesting stuff in this area).
If there are extra block rams on your FPGA, you could make them into an accessible memory region and place the code kernel in that region, so that you are operating directly out of low-latency RAM.   In that case, you'd want to put it in non-cached address space, or maybe just not have an Icache at all.


Cannot query external table - TableScan replaced with EmptyExec

Describe the bug
I am using the CLI to try and query a file. It shows that the file has no data but this is not the case.
To Reproduce
create external table partsupp (ps_partkey int, ps_suppkey int, ps_availqty int, ps_supplycost float, ps_comment varchar) stored as csv with delimiter '|' location '../benchmarks/data/partsupp.tbl';

❯ select count(*) from partsupp;
+-----------------+
| COUNT(UInt8(1)) |
+-----------------+
| 0               |
+-----------------+
1 row in set. Query took 0.001 seconds.

explain verbose select count(*) from partsupp;

| logical_plan                                               | Projection: COUNT(UInt8(1))                                     |
|                                                            |   Aggregate: groupBy=[[]], aggr=[[COUNT(UInt8(1))]]             |
|                                                            |     TableScan: partsupp projection=[ps_partkey]                 |
| initial_physical_plan                                      | ProjectionExec: expr=[COUNT(UInt8(1))@0 as COUNT(UInt8(1))]     |
|                                                            |   AggregateExec: mode=Final, gby=[], aggr=[COUNT(UInt8(1))]     |
|                                                            |     AggregateExec: mode=Partial, gby=[], aggr=[COUNT(UInt8(1))] |
|                                                            |       EmptyExec: produce_one_row=false

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Looks like a duplicate of https://github.com/apache/arrow-datafusion/issues/1736


App run in build but error in archive

Description
I can run application completely ok in build mode, but i wanted  to upload my app and when I try to archive it, I'm getting this error:
Build input file cannot be found: '/Users/parham/Library/Developer/Xcode/DerivedData/NAME-fpzdowyttevrefatnvgqejhxntva/Build/Intermediates.noindex/ArchiveIntermediates/NAME/InstallationBuildProductsLocation/Applications/NAME.app/NAME'
where NAME is my app name.
and when I checked, this folder doesn't exist: InstallationBuildProductsLocation
I've runned this project on other mac devices, and same is happening
Version
0.63.4
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.2.1
CPU: (8) x64 Apple M1
Memory: 21.72 MB / 8.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.18.2 - ~/.nvm/versions/node/v14.18.2/bin/node
Yarn: 1.22.17 - ~/.nvm/versions/node/v14.18.2/bin/yarn
npm: 6.14.15 - ~/.nvm/versions/node/v14.18.2/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.11.3 - /Users/parham/.rvm/rubies/ruby-2.7.4/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK:
API Levels: 30, 32
Build Tools: 28.0.3, 29.0.2, 32.0.0
System Images: android-32 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7935034
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_292 - /usr/bin/javac
Python: 2.7.18 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.4 => 0.63.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

clean project
click on archive.
click on Distribute app (or validate)
getting this error:

Snack, code example, screenshot, or link to a repository
No response

I've skipped the error with removing arm64 from excluded architectures.
I'll close the issue


How does warehouse store depedencies?

If a package has install_requires=['foo>=1.2'] in its setup.py how does warehouse store this information?
Does it store this in the database?
I tried to find the database schema, but I am not familiar with sqlalchemy (only django ORM up to now).
My use case: dependency resolving without full download.

It doesn't generally store install_requires but that's mostly because setuptools doesn't send that information. That data hasn't been mapped into the SQLAlchemy ORM yet, though the file upload branch I'm working on does that. The table is https://github.com/pypa/warehouse/blob/54c67bab2b150acad1267d4d0a4b32426adaa62d/warehouse/legacy/tables.py#L471-L485

What is "kind"?

According to the PEP there are several kinds of dependencies: https://www.python.org/dev/peps/pep-0426/#support-for-different-kinds-of-dependencies

I've mapped these into the ORM with an enum for the different types. I'm going to go ahead and close this issue since there's notthing really actionable here.


chore: update linkedom

resolve #235

Coverage remained the same at 98.598% when pulling 7538306faf28122e2d5ccfbc18a3917ac48ee6d6 on SettingDust:feat/update_linkedom into bf3bd048eb46e35eade28467336ca21080fe41ef on ndaidong:main.

I think it needs a new build and version to update the npm package.

I think it needs a new build and version to update the npm package.

@ndaidong remove the publish action. I can't publish without token. Waiting for him.
BTW, why you remove it?


Update Starscream to a recent (Swift 4 compatible) version

Birdsong depends on Starscream 2.0.1 which doesn't compile under Swift 4

Hey, thanks for the report about this! I'll look into this ASAP and get a new version pushed with Swift 4 support.

I've just pushed version 0.6.0 here and published on CocoaPods. This uses Starscream 3.0 which works with Swift 4.
Please let me know if you run into any issues, and thanks again!


Add 'diff' to default volatile_ftypes

This seems to be useful in general, but especially with .git/addp-hunk-edit.diff.

I am not familiar with .git/addp-hunk-edit.diff – would you enlighten me?

You get it with git add -p and then using e to edit the hunk (IIRC).
But given that it's based on the filetype, it would also apply to diffs in general - which would also skip vim-stay when e.g. editing some.diff.  Not sure if that's what you want.
There is no volatile_fnames setting, is there?

But given that it's based on the filetype, it would also apply to diffs in general - which would also skip vim-stay when e.g. editing some.diff. Not sure if that's what you want.

No, I would like to avoid that, which is why I asked.

There is no volatile_fnames setting, is there?

No, but known backup directories are ignored, so
set backupskip+=.git/*.diff

might help.

'backupskip'

Looks like a hack, and in fact I'd prefer to have backups for those files.
I'll use this instead:

au BufNewFile,BufRead */.git/addp-hunk-edit.diff let b:stay_ignore = 1

Yeah, that will work too. I’d assumed that a file you need no view state for is a transient one, i.e. one you need no backups for, hence my suggestion. I’ll think about adding some kind of g:volatile_fpatterns option in the future…


[stdlib] Improve performance of heterogeneous binary integer == and <

As it turns out, we can simplify this logic quite a bit and get more optimal generated code in the process:
In the first iteration of this PR, we unconditionally apply the "roundtripping" logic used in the existing code to widen a comparand without checking the instance property bitWidth:

If rhs can be represented as a value of type Self, or if lhs can be represented as a value of type Other, then the comparison is straightforward.
If neither is the case, then we can actually know which of lhs and rhs is smaller just by knowing which of Self or Other is a signed type (see comments in the code).

This change allows Swift to generate the same, optimal code (at -O) for the following input as reported in #62260, which isn't the case today:
func compare_direct(_ x: Int, _ y: UInt32) -> Bool {
    x < y
}

func compare_widened(_ x: Int, _ y: UInt32) -> Bool {
    x < Int(y)
}

However, because the roundtripping logic has to start with either the left-hand side or the right-hand side, the same optimal output can't be obtained when we swap the parameters above—i.e., when x is of type UInt32 and y is of type Int. The generated code is still better than the status quo, but it's not the best possible.

To address this issue, in the second iteration of this PR, we compare comparand bit widths explicitly, but only once along each code path in case it's expensive to compute for values of a hypothetical arbitrary-width type. (I'd expect this should be negligible as compared to the widening operation that follows anyway.)
For fixed-width integer types, this approach produces optimal code generation for heterogeneous comparison of any two types. This is because we defer comparison to zero until we reach the only scenario where it's required (when a signed and therefore possibly negative value is being compared to an unsigned value of greater bit width) and otherwise stick to operations that can be optimized away in the concrete case.
This change apparently speeds up generic floating-point conversion severalfold, improves code size for a number of integer and floating-point algorithms, and even shrinks libswiftCore.dylib code size by 2%. It also revealed brittleness in an IRGen test which has been modified as a result to improve robustness.

Resolves #62260.

Would appreciate guidance on where best to put a test for this code generation.

@swift-ci test

@swift-ci benchmark

In the implementation comments, I'm not sure that "bitcasting" or "bitcast operation" are the correct terms.

What would you suggest? I’d like something more succinct than “constructing a value of Foo type from
the bit pattern obtained by truncating or sign-extending as necessary the bit pattern of bar.” To do so, I’m adapting the terminology used in the existing implementation comment but I’m certainly open to other suggestions.

Could the (0 as Self) and (0 as Other) expressions be replaced by Self.zero and Other.zero?

It could, just as most if not all uses of literal 0 could be replaced by .zero, but we’ve always said that 0 is the preferred canonical spelling for integers. That there is an explicit type here is a reflection of an extant bug that causes < in generic contexts (but not concrete contexts) not to favor homogeneous comparison; this ought to be fixed because it is a footgun, and at such point when it is, this code can be rewritten lhs < 0, dropping the explicit type coercion.
I’d rather the workaround until then be (a) visually thorny rather than potentially appear like a stylistic preference; (b) generally applicable for all values—we can’t very well write lhs == Self.fortyTwo—so that authors who need to work on this code can see both the need for this workaround throughout the implementation and how to apply it no matter the comparand.

@swift-ci test

@swift-ci benchmark

Irksome is the apparent benchmark regression in string–substring comparison in all optimization modes; not sure how to explain that one.
This PR also apparently affects the temporary allocation codegen test, which I'll need to update I guess.

@swift-ci test Linux platform

@swift-ci test macOS platform

Most of the benchmark regressions are marked with (?) — "false alarms" or "noise". Can any of the results be trusted?

The string comparison benchmarks are consistently showing up, so it'll take some manual inspection of the generated code to know if it's noise or real.

@swift-ci please build toolchain

Can confirm identical SIL is generated for all benchmarks in SubstringTest using the toolchain versus the nightly, which answers that concern.

@swift-ci test Linux platform

@swift-ci test Linux platform

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test macOS platform

@grynspan I've had to make edits to the temporary allocation codegen test to keep CI happy.
In the IR, the relative order in which basic blocks for stack versus heap allocation are emitted for the large allocation test is arbitrary, but the existing test only accepts one specific order. With this PR, the basic blocks are now omitted in a different order on macOS because the generated code (rightly) has some different inlining choices earlier in the file with respect to a comparison operation with a randomly generated fixed-width integer.
To make the test robust to arbitrary changes in the order of basic blocks, I've changed certain "CHECK"s to "CHECK-DAG"s. At some point in the past decade, folks proposed a "CHECK-LABEL-DAG" feature to be added to FileCheck, but unfortunately it didn't gain traction and it doesn't appear possible to checkentire basic blocks being reordered relative to one another in one invocation of FileCheck, just single lines. Therefore, I've also changed the test to invoke FileCheck three times, with the first run testing for presence of the expected branch instructions, and the latter two specifically testing either the heap allocation IR or the stack allocation IR.
Note that the test as it currently exists on main has a RUN line that actually only tells FileCheck to check the platform-specific lines, as far as I can tell, so the vast majority of the "CHECK"s aren't being tested; I've changed the flags on the first invocation so that all "CHECK"s are actually tested--and fortunately it all seems to work fine.
Let me know if this change looks at least reasonable to you. I'd like to defer any detailed tinkering to you or others as it's not salient to this PR, but some degree of change was required to unblock this work and I figured I'd at least make a real effort.

I'm planning to rework these further, but this seems like a reasonable start...

One style nit, otherwise LGTM.

@swift-ci test and merge

We are seeing multiple aarch64 bots failing:
Failed Tests (1):
  Swift(linux-aarch64) :: IRGen/temporary_allocation/codegen.swift

https://ci.swift.org/job/oss-swift-package-ubuntu-20_04-aarch64//1442/console
cc: @xwu @stephentyrone

🫤 this is what I get for trying to unblock things by fixing rather than just disabling the test.
Most of the tests weren't actually being checked and my good deed was properly enabling it, but looks like zeroext on that call is applicable only for x86_64; I think the best way to unblock is to disable this test again for arm64.
cc @grynspan

#63093

Incidentally, @shahmishal, given CI passed multiple times, was there any way to spot this issue pre-emptively?


no (or less) space between Slides

Can I do just a simple div with background image wrapped inside an anchor (just like the print bellow) using any native props of the components?

+1 This would be really handy for my use case.

You can achieve this.  There is nothing preventing you from putting whatever content you want inside of each carousel cell and formatting however you desire.  It's one of the main goals of the project to be highly customizable.  There are currently plenty of ways to pass the CSS that you will have to write to the various components.  Each component has a className prop where you can pass in your own sass.  There are also hard-coded class names so you can write vanilla CSS.  This really isn't an issue.  You'll have to play around and figure it out.

You're probably write @mrbinky3000. Though it does require one to learn the inner mechanics of how the carousel operates since I have noticed that adding margins to slides screws up your slider since the slider's width is calculated only using the natural widths passed to the provider. Additionally, since adding a margin to the left of the first slide can screw up how slides align relative to other components, dealing with the special cases can be a hassle to do manually. It's not impossible, but perhaps a way to make it more convenient would be nice.

Yeah, archiving this behavior should be out of the box
@mrbinky3000, by the way, there isn't really an easy way to do it. Would be awesome if you could show us these magic CSS lines that will produce such behavior otherwise it will be an issue, don't you think? 🙂


Imod6 976 correction flux

-the functions that compute or set the correction flux were already made, but they were not used in the program
-the well package used for the correction flux in the modflow model was made by Hendrik, but it was not present in our t-model
so
-this changeset takes these building blocks and calls them from the driver to implement the correction flux
-also, a unit conversion was added. dflow-fm reports its time in seconds, while mf6 uses days  ( in our example)

Locally, it fails for me with:
FAILED tests/test_run_tmodel.py::test_run_tmodel - pydantic.error_wrappers.ValidationError: 1 validation error for DfmMetaModConfig

Not sure why it times out on TeamCity.

Not sure why it times out on TeamCity.
i found out it times out because of a precision issue.
in the statement:
while  self.dfm.get_current_time() < days_to_seconds(subtimestep_endtime  ):

it so happens that for the final time 365 days,  days_to_seconds(subtimestep_endtime  ) returns 31536000.0000002 whereas dflow-fm can compute up to 31536000. So no matter how many extra dfm timesteps we make, the ending condition is never met. I now added a tolerance to this comparison, and now it finishes.


ARXIVNG-1408 better support for cross-list, withdrawal requests

Coverage remained the same at ?% when pulling c7bd2e83863d14f7a5a0702defb5dd2a2bbf715c on feature/ARXIVNG-1408 into 6f1082ae2b2b5acd161a2e0d4c812eababd9fdbc on develop.


#3 chore: add auto generated assets & docs: add innersource reviewers is CODEOWNERS

Alaska Airlines Pull Request
Include auto generated assets from WC generator and added AuroToastInnersourceReviewers to the CODEOWNERS file.
Fixes: #3
Summary:
Include auto generated assets from WC generator and added AuroToastInnersourceReviewers to the CODEOWNERS file.
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Validate server TLS certificate

We will still need an option to disable this for testing.

Fixed in 7e03018e4038f7bfa775320f2080395169bce395


create error displays, text comes from api

This change was made to handle creating a Linode when your account
already had too many Linodes on it and you couldn't add any more it
would say contact support.  While this change supports that, it will
also support any error that doesn't have a field associated with it and
we take that to mean over the entire form.

closes #731

Coverage decreased (-0.07%) to 80.455% when pulling 3bd781d7f529b4e760b3a569f537989c9cf805ea on abemassry:create-errors into 55ddaa599fdeda1ba25d507aa0810c9b855c0ad1 on linode:master.


[FIXED]: Linting with Black Workflow

Description
Updated black.yml
Fixes #491
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

@avinashkranjan


Why is the source code so messy?

What is your question?
Why is it so messy?
For example, why is the everything in the mods folder not hard coded? Or at the very least copied into the "example_mods" folder which will copy everything into the mods folder anyway?
Why is a glow effect created every single frame? Rather than just using an asset? This causing the game to slow down to a crawl.
Also back to the mods folder thing, I assume this was compiled in debug mode. This on its own will take a bit of performance, compile the game without a debug flag geez.
Also why 4 separate cameras for the note effects, if it was an asset it would have been easier to use a colourswap shader on top of that.

You're right, when I was making the mod I wasn't very experienced with Haxe, I kinda just cut corners to everything and use the easiest approach/method that works. Right now I realized a lot of things could be done in a more straightforward way but I don't have the energy to redo all of them. This is the first mod I have been working on as a programmer, I still have a lot of things to learn. Hopely I won't make the same mistake on the next project.

I prefer to use Lua cuz my pc went slow every time I compile the game while in Lua I can just restart the level and see the result. The camera glow needs 4 colors for each type of note and it needs to be dynamic breathing. Simply applying shaders to that camera works but I cannot find a way to make it breathe so the current implementation is the shortcut for that (I don't even know about shaders while I made that). Maybe there are more resources to learn to code right now but way back then there is a limited amount of them or maybe I just haven't found them. I'm not good enough, and I saw making this mod as my opportunity to learn how to code. Thank you for pointing out all the improvements, I will definitely try them out in my next project.

That makes sense.
I have made a few optimizations, such as removing the glow effect. Which instantly made the game playable.
I would rather re-write most of everything here than fixing it.
Oh well, its fine. But I also don't think its worth my time to fix this.

Also with the glow effect, It might be more complicated but I you could probably render the glow effects as bitmap data, and put them onto camHUD.
And with Lua, you can always use the assets folder, they dont need to be in mods.

Thank you for the suggestions. I will definitely try those myself and see how it works. It is good to know that Haxe is a very powerful programming language and there are decent programmers like you to support the community. Again really appreciate your effort and hope you have a good day!

Thx and have a blessed day.


Added logic to load locations and VM sku's from json files

PR Summary
This change loads the vm sku's from a json file by location that is generated by a bash script in the build.yml action. Plus, loads the locations from another locations.json file.
The genertation of toe sku's is driven from a locations.json and skuFamilies.json files, which needs to be manually updated at this point in time.
The current locations and skufamilies files are aligned to the current list from main, excluding UKSouth2, which wasn't found in the API calls to fetch the sku's.
The screen has changed to also a custom sku to be entered and sku name has been added to the dropdown
Logic has also been added to handle the 3 compute types on the screen, but the IO Optimized and GPU Workloads are disabled for now.
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[x] Link to a filed issue
[x] Screenshot of UI changes (if PR includes UI changes)

@Gordonby I made an attemp to add the bash script to the build.yml process. I wasn't sure if if was correct or not. Plus, not too sure how to test it.

This looks really good @fireblade95402
Let me spin it up in a codespace

befpre

after

@fireblade95402  - i'm seeing this problem when running the script

@Gordonby If I run the script with "./generate-vm-sku-list-v2.sh" it works and when I run it with "sh generate-vm-sku-list-v2.sh" I get the same error you get. I'll have a look at why

Ok, I'm using "bash" shell and not the "sh" shell. Gather differences in language support. Should we be making it "sh" or would "bash" be ok

Needed to add an Azure Login step to the build, but now it works fine :)


Switch from Service Catalog to BTP Service Operator

Background
As announced in SAP help, service catalog is being deprecated and BTP service operator will be the way to consume SAP BTP services.
Target
Adjust helm charts and gh-pages for Kyma setup to use the new resource kind.

For the format of service instance see here
For the format of service binding see here

fixed with #1641


Changed loading icon (#144)

Thanks! Please put "fixes #144" in the description next time so it can be linked to the issue (and then the issue will automatically close when this PR is merged).


[validate] fix wrong payload commission

payload_hash: "9gEqoFCKQZI9dqBp3GfndQRTTjA2+vsZU5jlbIn+fow=",
payload_commission: 5015
......
V/NuDxzT7VFa/AqfBsAZ8suG4uj3u+l0kXOLE+nP+dU= validation failed: wrong payload commission, expected 5045

js count string len as unicode chars, rust need to use s.chars().count() to respect that fact


fix: update execa dependency to 2.1.0

This PR contains:

[x] bugfix
[ ] feature
[ ] refactor
[ ] tests
[ ] documentation
[ ] metadata

Breaking Changes?

[ ] yes
[x] no

If yes, please describe the breakage.
Please Describe Your Changes

Update execa dependency to 2.1.0 in package-lock.json. Without this
change, tests will fail when run with Node.js 13.x-pre and may fail when
13.0.0 is released in 13 days.
Refs: https://github.com/sindresorhus/execa/pull/370

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   97.24%   97.24%
=======================================
  Files           1        1
  Lines         145      145
=======================================
  Hits          141      141
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d221504...15f0d7b. Read the comment docs.

Thanks for this PR 🍺

I know it's just a test fix, but any chance I can persuade you to publish a new release? There seem to be some legitimate bug fixes since the last release, so it wouldn't be a complete no-change release for end users. This particular fix will help Node.js's ecosystem-testing tool CITGM, which downloads a tarball of the latest release and runs tests. So CITGM won't use this fix until it's part of a release.


New sequence for more cart supports

Add seq
_FLASH_WRITE(0x555, 0xAA);
_FLASH_WRITE(0xAAA, 0x55);
_FLASH_WRITE(0x555, CMD);
It's work for some old carts

I cant find any card for test theory


[RFC] Move props to components' types file

Divide and conquer!
This RFC on how we can re-organize the structure of our component and make it easier to read.
Our component's props are growing and also with comments around, it can get harder to grasp quickly the main logic and read the code.
I found for myself it's much easier when props are in separate *.types.ts file than when having everything in one file, kind of mix of many things.
I think it is more personal, depending on how you used to work. But I would love to hear your thought on it.
Currently, I made changes for Button and ButtonGroup, and if you like it, I can make this change for every component.

I'm going to downvote this change because it will complicate our docgen tasks:

we will need to watch for two files (Component.tsx, Component.types.ts) instead of one
it will require more work from react-docgen-typescript that also need to resolve these files, it will beat our performance
it's not a common practice

build:docs:docgen

Framework
Time

Semantic UI React
12 s

Stardust UI
36 s

And will take more time if we will separate definitions.

However, I think that we can move types to bottom of component files.


Error "console.log never called" - Challenge "Local Scope and Functions"

Challenge Local Scope and Functions has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

function myFunction() {
  'use strict';
  var myVar = "";

  console.log(myVar);
}
myFunction();

// run and check the console
// myVar is not defined outside of myFunction
console.log(myVar);

// now remove the console log line to pass the test

The code is good, but the output console show "console.log never called",
I think that my code is correct because the instruction is "Declare a local variable myVar inside myFunction"

Read the comments .

Closing as a duplicate of #6259
PS: Please go through Help I have found a bug

o meu funcionou
function myLocalScope() {
'use strict';
var myVar = "teste";
console.log();
}
myLocalScope();
// Run and check the console
// myVar is not defined outside of myLocalScope
console.log();
// Now remove the console log line to pass the test

function myLocalScope() {
'use strict';
var  myVar;
console.log("loc");
}
myLocalScope();
// Run and check the console
// myVar is not defined outside of myLocalScope
console.log("loc");
// Now remove the console log line to pass the test


⚠ Thumbnails API Endpoint has degraded performance

In 0fde86a, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 3666 ms

Resolved: Thumbnails API Endpoint performance has improved in 57fcf9b.


Bump zio-json

To be consistent with zio-schema 0.4.9 which uses zio-json 0.5.0

Duplicate of #120


Internal AVL wrapper is immature

The AVL wrapper used on ADR was developed during a phase where something that would "just work" was needed. The problem is: it is a very immature project that has many limitations, from how it handles files to the many hard-coded parameters.
Looking around I was able to find AVLWrapper, a wrapper written in Python, with a mature and well-maintained codebase and with many usage samples. It may be a perfect substitute.

Solved by #175


Hide content_format section on Article form

Every Article is formatted as Markdown now. HTML is only available has a artifact to support historical Features that have their own layout and styles.
https://crimethinc.com/categories/features/
Since no more of those are being created (for now), we don't need to expose this and add it as additional noise to the Article form.
Adding a .sr-only class to the .form-group wrapper will hide it with Bootstrap without possibly requiring any backend changes.

@just1602 Interested?


[sw/silicon_creator] Add spx signature field to manifest

This PR renames the current signature field in the manifest to rsa_signature and adds a new spx_signature field. This new field will be revisited when we start working on manifest extensions.
Note: Marked as draft until I update rust definitions

Thanks @jadephilipoom and @cfrantz. I addressed your comments, created an issue to revisit the manifest layout, and updated opentitantool. This PR should be ready to go once CI is done.


EHPR - Quick release

Added an alert warning Health Authority users to submit a request to access before downloading the registry.
Updated the alert component to have multiple colour options.

Looks like I don't have "write access", so is blocked.

Looks like I don't have "write access", so is blocked.

I have updated your access!

Looks like you have a "prettier format issue" from sonar cloud


Required properties are not validated when additionalProperties: true is provided

Problem statement
When I use this schema:
  "definitions" : {
    "Resource" : {
      "type" : "object",
      "required" : [ "sourceId", "title" ],
      "additionalProperties" : true,
      "properties" : {
        "id" : {
          "type" : "string",
          "example" : "oo000oo0001"
        },
        "title" : {
          "type" : "string",
          "example" : "My work"
        },
        "sourceId" : {
          "type" : "string",
          "example" : "bib12345678"
        }
      }
  }

and I don't provide a sourceId in the request, then it doesn't return a validation error.  If I remove the additionalProperties: true then it does return an error.
Swagger specification
2.0
Steps to reproduce
Environment
swagger version: 0.13.0
go version: 1.9
OS:  osX

There is a known issue around there. You might try the workaround suggested by #1198.

Wow, this is ugly.  I'm investigating.

@fredbi I attempted the workaround, but then it didn't generate ResourceAdditionalProperties into the model struct.

Anyone have a spec with additionalProperties that has validation?  I'm not seeing any in the repo and I want to test my fix.

Hi Greg. You may check out in the fixtures from fo-openapi/validate, there some test cases with additionalProps.
You might have the fixture/canary/kubernetes/swagger.json, but I don't see there are validations with additionalProps and anyway, this one has other problems with generation.

Yeah, I don't see any validations in any of those schemas. I guess I'll have to make one.

Even this one? https://github.com/go-openapi/validate/blob/master/fixtures/validation/valid-referenced-variants.yaml

I don't see anything there.  Am I missing something?

This spec is not valid (it's for testing validation messages). But you have a section with additionalProperties and patternProperties with different required / format patterns (actually patternProperties are not supported). Well this is probably not a good example. Better to start fresh off

@jcoyne Can you try out the latest version and see if it fixes your issue?

@gregmarr Yes! That looks great. Excellent work.

@jcoyne please close your issue if you are satisfied with the fix. Thanks

Thanks @jcoyne!


debugging in "java console app" not working

hello, when I try debug a java code in "java console app" the extern console is not appear. When i debuggin in "java" ist work fine but i cant insert dates in the console of vs code.
Sorry for my english i hope that understand me.

Hi, sorry for not removing the  "java console app" from the debug section
This will be supported in the next build.
You can insert (input) data into a console app only via the external console, not via vscode.

AH. Okay, then I'll be waiting for the next update

Fixed, in both windows and mac


correctly resolve relative #r

This PR ensures that relative #r references in scripts are correctly resolved (normalized to absolute paths)
So far we only resolved them correctly if they were absolute or if the script was directly located in the working directory for omnisharp (the folder where project.json is). This was already done for #load before.

travis you're drunk...

😞

🏄


postgresql11Packages.plpgsql_check: 1.15.2 -> 1.15.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/plpgsql_check/versions.
meta.description for postgresql11Packages.plpgsql_check is: "Linter tool for language PL/pgSQL"
meta.homepage for postgresql11Packages.plpgsql_check is: "https://github.com/okbob/plpgsql_check"
meta.changelog for postgresql11Packages.plpgsql_check is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/d88d4bd10d0cee2fae7903320b9bec28

du listing: https://gist.github.com/19839664ffc5563d40560251d0d12d64

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
postgresql11Packages.plpgsql_check
postgresqlPackages.plpgsql_check

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/iqd3djapg2dndzajmzfa8zmj6153l8kp-plpgsql_check-1.15.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A postgresql11Packages.plpgsql_check https://github.com/r-ryantm/nixpkgs/archive/6263b39f1bf0484cfec3df241fc7eadca2d83a44.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/iqd3djapg2dndzajmzfa8zmj6153l8kp-plpgsql_check-1.15.3
ls -la /nix/store/iqd3djapg2dndzajmzfa8zmj6153l8kp-plpgsql_check-1.15.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

postgresql11Packages.plpgsql_check

Maintainer pings
cc @marsam for testing.

Result of nixpkgs-review pr 112974 at 6263b39f run on aarch64-linux 1

1 package built:

postgresqlPackages.plpgsql_check (postgresql11Packages.plpgsql_check)

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/sql/postgresql/ext/plpgsql_check.nix:16:3:
   |
16 |   installPhase = ''
   |   ^


Documentation generated for docs-2-25

This is a documentation change.
Summary
Updating site references to docs version 2.25
Context
https://github.com/stan-dev/math/issues/2128

@serban-nicusor-toptal - travis is unhappy - can't install the Ruby(?) toolchain needed to build the docs.

Hey, looking into it now.

Looks like that was a general issue as master and other branches were failing too.
Merging this into master should fix all of them.
@mitzimorris ready now.


Update cats-core to 1.6.1

Updates org.typelevel:cats-core from 1.6.0 to 1.6.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.typelevel", artifactId = "cats-core" }]

labels: semver-patch

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          57     57
  Branches        5      5
=====================================
  Hits           57     57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e9ed7...3781e90. Read the comment docs.


Elasticsearch Curator fails the Kubernetes CronJob when there's no data

There shouldn't be an error if there's no data in Elasticsearch yet.

Do you mean es-index-cleaner?
Yes it fails because there are no jaeger indices.


can't select self downloaded inpaint mode

For files with the .safetensors extension, you can place them in the models/Stable-diffusion folder under the stable-diffusion-webui directory. These files will then appear in the Model ID list under the Inpainting webui tab (only if the filename contains inpaint, case insensitive).

file already inside of models\Stable-diffusion\90.Inpainting
and filename realisticVisionV60B1_v60B1InpaintingVAE.safetensors has inpaint

sd webui can see it

The inpainting model placed in the models folder of stable-diffusion-webui will not appear under the Inpainting tab of Inpaint Anything. Instead, it will be available in the Inpainting Model ID webui dropdown list found in the Inpainting webui tab, which is located next to the Cleaner tab.


Using jshint instead of jsxhint

Guys, thanks a lot for your amazing plugin. Unfortunately, I'm having hard times to make it work properly.
My JSX files are linted incorrectly (please see this screen shot).
If I turn on SublimeLinter debugger, I see following output
SublimeLinter: jshint version query: /usr/local/bin/jshint --version
SublimeLinter: jshint version: 2.6.0
SublimeLinter: jshint: (>= 2.5.0) satisfied by 2.6.0
SublimeLinter: jshint activated: /usr/local/bin/jshint
SublimeLinter: jshint: hello.jsx ['/usr/local/bin/jshint', '--verbose', '--filename', '@', '--config', '/Users/alexanderbeletsky/Development/Projects/experiments/react2/.jshintrc', '-']
SublimeLinter: jshint output:
/Users/alexanderbeletsky/Development/Projects/experiments/react2/js/components/hello.jsx: line 10, col 29, Unclosed regular expression. (E015)
/Users/alexanderbeletsky/Development/Projects/experiments/react2/js/components/hello.jsx: line 10, col 29, Unrecoverable syntax error. (62% scanned). (E041)

I my current setup, both linters are enabled jshint and jsxhint. If I try to turn jshint off (only leave jsxhint) there is console output at all.
My assumption that SublimeLinter is somehow missing the fact I want to use jsxhint for .jsx files.
What I'm missing?
Info: Sublime Text 3, Build 3065

You must select a JSX syntax type, or else SublimeLinter will not know
which linter to use. I can see from your console output that it is
activating SublimeLinter-JSHint instead of SublimeLinter-JSXHint.
Babel-Sublime (https://github.com/babel/babel-sublime) is the most
complete JSX/ES6 syntax type. Install it and switch your default syntax
for .jsx files and it will work.
On 2/17/15 6:56 PM, Alexander Beletsky wrote:

Guys, thanks a lot for your amazing plugin. Unfortunately, I'm having
hard times to make it work properly.
My JSX files are linted incorrectly (please see this screen shot
https://www.dropbox.com/s/n05cxsn3gasx31f/Screenshot 2015-02-17 12.45.47.png?dl=0).
If I turn on SublimeLinter debugger, I see following output
SublimeLinter: jshint version query: /usr/local/bin/jshint --version
SublimeLinter: jshint version: 2.6.0
SublimeLinter: jshint: (>= 2.5.0) satisfied by 2.6.0
SublimeLinter: jshint activated: /usr/local/bin/jshint
SublimeLinter: jshint: hello.jsx ['/usr/local/bin/jshint', '--verbose', '--filename', '@', '--config', '/Users/alexanderbeletsky/Development/Projects/experiments/react2/.jshintrc', '-']
SublimeLinter: jshint output:
/Users/alexanderbeletsky/Development/Projects/experiments/react2/js/components/hello.jsx: line 10, col 29, Unclosed regular expression. (E015)
/Users/alexanderbeletsky/Development/Projects/experiments/react2/js/components/hello.jsx: line 10, col 29, Unrecoverable syntax error. (62% scanned). (E041)
I my current setup, both linters are enabled |jshint| and |jsxhint|.
If I try to turn |jshint| off (only leave |jsxhint|) there is console
output at all.
My assumption that SublimeLinter is somehow missing the fact I want to
use |jsxhint| for |.jsx| files.
What I'm missing?
Info: Sublime Text 3, Build 3065
—
Reply to this email directly or view it on GitHub
https://github.com/SublimeLinter/SublimeLinter-jsxhint/issues/25.

@STRML Amazing, works as charm now.
Thanks a lot for you help and great job :)

I have installed jsxhint
I have syntax set to JavaScript (Babel); and set all jsx files to use it and restarted Sublime
If I run jsxhint path/to/my/file on the commandline, I get illegal import declaration.. which I'm not sure what that's about but at least I have jsxlint installed.
In my jsx file though it isn't using jshint:
`SublimeLinter: chdir not set or invalid, using /path/app/scripts
SublimeLinter: jshint: index.jsx ['/path/.npm-packages/bin/jshint', '--verbose', '--filename', '@', '--config', '/path/.jshintrc', '-']

Really not sure the culprit here or what else to try

Use https://github.com/roadhump/SublimeLinter-eslint , jsxhint can't handle most es6 syntax.

Ah k must be an issue w babel-sublime linting the entire file as es6 and not using Jsx anywhere, then, and the command line output makes perfect sense. Realize I mistyped there, too.. Should have said "is not using jsxhint" but I think whatever issue is not with this repo


Support creating volume snapshots and clones without flattening

Describe the feature you'd like to have
Support creating volume snapshots and clones without flattening
What is the value to the end user? (why is it a priority?)
I'm able to create snapshots (and therefore clones) of an existing PVC without needing to wait for the full flatten operation to complete. This means I'll be able to take advantage of Ceph's block-level copy-on-write to quickly create clones of existing PVC's via a their snapshot.
As it stands right now (presumably due to the work in https://github.com/ceph/ceph-csi/pull/1160), whenever I create a volume snapshot, it causes a full copy of the PVC I'm snapshotting due to flattening. This is the exact opposite of what I'd expect as a user. I want my snapshot to be a point-in-time record of the state of the PVC that I can then create subsequent clones of without needing to perform a full copies.
The current implementation of the Ceph CSI driver prevents this from being possible, effectively making the copy-on-write snapshot behaviour provided by Ceph inaccessible to me.
How will we know we have a good solution? (acceptance criteria)
When I create a VolumeSnapshot of an existing Ceph PVC, that should be equivalent to a Ceph RBD snapshot of the underlying PVC without any full-copying or flattening applied.
I'm then able to create clones of that VolumeSnapshot which maps exactly to the clone operation provided by Ceph.
Additional context
From a brief read, it seems that this "flattening" behaviour was introduced to avoid having a dependent relationship between the pvc <-> snapshot <-> clones, so that I can delete the PVC whilst still leaving the VolumeSnapshot around.
I actually want this relationship to exist. It's the reason I want to use Ceph in my cluster, so that I can quickly provision clones of PVCs without taking up all the disk space and time to do a full-copy.

@cjheppell Have you overridden softMaxCloneDepth to 1? It shouldn't be flattening images unless you make chains of clones longer than the softMaxCloneDepth setting. If it's always flattening, that sounds like a bug.

Not as far as I'm aware.
For context, the Ceph CSI driver I'm using is quay.io/cephcsi/cephcsi:v3.1.0 installed via Rook in a Kubernetes Cluster.
Having just manually patched the cephcsi version to v2.1.2 I'm getting the behaviour I'd expect:

Creating a VolumeSnapshot creates a snapshot on the corresponding rbd image representing my PVC
Creating a PVC with that VolumeSnapshot defined as the source creates a clone rbd image based off the snapshot created on the original rbd image

Perhaps there's something I'm missing, but I've definitely observed behaviour where (without any additional config out of the box via a Rook-provisioned Ceph cluster) creating a VolumeSnapshot from a PVC will immediately cause a flatten because rather than just creating a snapshot on the source rbd image it does this:

Create a temporary snapshot from the parent volume
Clone a new image from a temporary snapshot with options --rbd-default-clone-format 2 --image-feature layering,deep-flatten
Delete temporary snapshot created
Create snapshot from clone image

As far as I could understand, this caused a full-copy, and means that my new volume snapshot is completely detached from the original PVC?

As far as I could understand, this caused a full-copy to the clone layer (as the snapshot it was created from was deleted), and means that my new volume snapshot is completely detached from the original PVC?

None of the steps listed above will cause a flatten. Are you actually seeing a flatten?

None of the steps listed above will cause a flatten. Are you actually seeing a flatten?

This could well be a lack of understanding on my part on how Ceph works in that case...
I guess my confusion comes from the fact that reviewing the Ceph Dashboard (and indeed the output of ceph rbd ls) shows a new image representing the volumesnapshot with no parents, rather than a snapshot on the original rbd image.
I was under the impression that must cause a full-copy from the parent snapshot that was deleted down to the cloned child according to https://docs.ceph.com/en/latest/rbd/rbd-snapshot/#flattening-a-cloned-image

I guess my confusion comes from the fact that reviewing the Ceph Dashboard (and indeed the output of ceph rbd ls) shows a new image representing the volumesnapshot with no parents, rather than a snapshot on the original rbd image it was taken from.

Perhaps there is a bug in the dashboard. What does "rbd info" show against the snapshot image?
$ rbd create --size 1G image1
$ rbd snap create image1@snap
Creating snap: 100% complete...done.
$ rbd clone --rbd-default-clone-format=2 --image-feature layering,deep-flatten image1@snap image2
$ rbd snap rm image1@snap
Removing snap: 100% complete...done.
$ rbd snap create image2@snap
$ rbd clone --rbd-default-clone-format=2 --image-feature layering image2@snap image3
$ rbd info image2
rbd image 'image2':
	size 1 GiB in 256 objects
	order 22 (4 MiB objects)
	snapshot_count: 1
	id: 10337a6504ed
	block_name_prefix: rbd_data.10337a6504ed
	format: 2
	features: layering, deep-flatten, operations
	op_features: clone-parent, clone-child
	flags:
	create_timestamp: Wed Dec 16 13:48:01 2020
	access_timestamp: Wed Dec 16 13:48:01 2020
	modify_timestamp: Wed Dec 16 13:48:01 2020
	parent: rbd/image1@e4b72fcf-8d0a-42ab-8076-07918588c13f
	overlap: 1 GiB
$ rbd info image3
rbd image 'image3':
	size 1 GiB in 256 objects
	order 22 (4 MiB objects)
	snapshot_count: 0
	id: 103dac306e02
	block_name_prefix: rbd_data.103dac306e02
	format: 2
	features: layering, operations
	op_features: clone-child
	flags:
	create_timestamp: Wed Dec 16 13:50:21 2020
	access_timestamp: Wed Dec 16 13:50:21 2020
	modify_timestamp: Wed Dec 16 13:50:21 2020
	parent: rbd/image2@snap
	overlap: 1 GiB

Yes, you're quite right!
Having run rbd info on the "snapshot" image shows that its parent is indeed my original PVC. Thanks a lot for clearing that up 👍
What is confusing however, is that the dashboard is now only showing the "snapshot" rbd image, not the original PVC rbd image:

Whereas rbd ls is showing the original PVC rbd image too:
$ rbd ls
csi-snap-84cf774b-3fd3-11eb-ac83-1eaeb7b3b119
csi-vol-3957c2fc-3fd3-11eb-ac83-1eaeb7b3b119

I wonder if this ought to be reopened?
I've done a bit more digging and I've seen this flattening happen from the ceph csi-plugin pod itself.
See: https://github.com/ceph/ceph-csi/issues/1543#issuecomment-780132055


Incorrect parsing of ClientInfo when trying to authorize on some old accounts

While testing our application using the MSAL4j (authorization by code), we identified the following problem: some clients could not authorize, because when receiving a response from the server, they received a response parsing error:
java.lang.IllegalArgumentException: Illegal base64 character 2d
After debugging, I managed to find a problem: in the ClientInfo class, when parsing a response from JSON, Base64 encoded characters are expected, but in practice, responses arrive that may contain Base64url encoded characters, such as '_' and '-'.
More about encoding differences: RFC 4648
I corrected the code in the fork by replacing Base64.getDecoder with Base64.getUrlDecoder and our clients were able to log in
and user Microsoft Graph API.
We hope that you will correct this error so that we can use your version of the library again.
Link to pull request: #282
Best regards, Roman Nosachev, middle Kotlin developer at Getapy

@RomanNosachev Thank you for reporting this issue and providing PR with fix. Could you please provide more details about accounts for which you got this problem ? Was it federated account ?

PR is merged.


Border covering resized windows

hello there! I've been experiencing this pretty annoying bug with your fork of bspwm, and I am unable to use this fork because of it. Below I have provided two videos showcasing the difference between bspwm-git, and bspwm-rounded-corners-git
bspwm-git
https://user-images.githubusercontent.com/18248986/164218751-23af82d0-7369-4371-b42c-7b0109acdfe5.mp4
You can see in this video, when discord is closed as a different sized window, and then reopened maximised, the border extends and everything looks normal.
bspwm-rounded-corners-git
https://user-images.githubusercontent.com/18248986/164218764-0f1ad29d-11d1-4dcd-aab2-8fe3ad2bcf98.mp4
You can see in this video that when I resize discord, close it, and then reopen it, the border is covering the extended part of the window. This is really annoying and is only fixed by killing discord and reopening it.
There's also a few small white pixels at each corner, which should be visible in the video. I don't think these are meant to be there. I checked, and both my picom and my bspwm radii are set to the same amount.

Hey, I just merged the latest bspwm master into this, can you try and see if the issue persists?

Btw, which bar are you using? Looks cool

Hello again. I wanted to ask if the AUR package will ever be updated? Or maybe I can try and maintain it. Never done it before but it sounds fun

Hm, the PKGBUILD was pointing to the wrong branch. Fixed that, should be updated.


[Bug] Install-DbaInstance

Report

Host used

[X] powershell.exe
[ ] ISE
[ ] VS Code
[ ] Other (please specify)

Errors Received

VERBOSE: [17:29:00][Resolve-DbaNetworkName] Resolving SERVERNAME using .NET.Dns GetHostEntry
VERBOSE: [17:29:00][Resolve-DbaNetworkName] Resolving <IP_ADDRESS> using .NET.Dns GetHostByAddress
VERBOSE: [17:29:09][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:29:09][Get-DbaCmObject] [SERVERNAME] Retrieving Management Information
VERBOSE: [17:29:09][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM - Success
VERBOSE: [17:29:10][Resolve-DbaNetworkName] Resolving SERVERNAME.suffix.dns using .NET.Dns GetHostEntry
VERBOSE: [17:29:10][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:29:10][Install-DbaInstance] Looking for installation files in J:\setup.exe on remote machine
SERVERNAME.suffix.dns
VERBOSE: [17:29:10][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:29:10][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:29:12][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:29:12][Write-IniFile] Writing Ini file to
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini

Confirm
Are you sure you want to perform this action?
Performing the operation "Install 2016 from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe" on target
"SERVERNAME.suffix.dns".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
VERBOSE: [17:29:21][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:29:21][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:29:21][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:29:21][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:29:22][Invoke-DbaAdvancedInstall] Copying
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini to remote machine into
C:\Users\username\AppData\Local\Temp\
VERBOSE: [17:29:22][Send-File] Starting WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\]
VERBOSE: [17:29:22][Send-File] WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\] complete
VERBOSE: [17:29:22][Invoke-DbaAdvancedInstall] Setup starting from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
VERBOSE: [17:29:22][Invoke-Program] Starting process
[J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe] with arguments
[/IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere"
/CONFIGURATIONFILE="C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini"] on
SERVERNAME.suffix.dns through Default protocol
Remove-Item : Cannot find path
'C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini' because it does not exist.
At D:\dsi\SQLServer\psmodules\dbatools\allcommands.ps1:41602 char:13
+             Remove-Item $ConfigurationPath
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\usernam...suffix.dns_2016.ini:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

WARNING: [17:29:22][Invoke-DbaAdvancedInstall] Installation failed with exit code -1073741515. Expand 'Log' property to
 find more details.

ComputerName      : SERVERNAME.suffix.dns
Version           : 13.0
SACredential      : System.Management.Automation.PSCredential
Successful        : False
Restarted         : False
Configuration     : {OPTIONS}
InstanceName      : MyInstanceNameHere
Installer         : J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
Port              :
Notes             : {Installation failed with exit code -1073741515. Expand 'Log' property to find more details.}
ExitCode          : -1073741515
Log               :
LogFile           : C:\Program Files\Microsoft SQL Server\130\Setup Bootstrap\Log\Summary.txt
ConfigurationFile : C:\Program Files\Microsoft SQL Server\130\Setup Bootstrap\Log\20201116_134028\ConfigurationFile.ini

Steps to Reproduce

Install-DbaInstance -Verbose -Version 2016 -InstanceName MyInstanceNameHere -InstancePath "E:" -Feature Engine -Configuration @{ SQLCOLLATION = "Latin1_General_CI_AS"; AGTSVCSTARTUPTYPE="Automatic"; SQLSVCSTARTUPTYPE="Automatic" } -AdminAccount "DOMAIN\User1","Domain\User2" -EngineCredential $agentEngineCredential -AgentCredential $agentEngineCredential -PerformVolumeMaintenanceTasks -AuthenticationMode Mixed -SaCredential $saCredential -Path $setupPath

Expected Behavior

New instance installed on my server
Actual Behavior

No instance installed.
I run this command with a PowerShell consol as Admin (run as Administrator).
Before confirmation to install instance or not. I checked content of path: C:\Users\username\AppData\Local\Temp
And I saw this filename: Configuration_SERVERNAME.suffix.dns_2016.ini
But after confirmation to create this new instance this file is removed.
In the verbose log I saw:
VERBOSE: [17:29:22][Invoke-DbaAdvancedInstall] Copying
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini to remote machine into
C:\Users\username\AppData\Local\Temp\
VERBOSE: [17:29:22][Send-File] Starting WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\]
VERBOSE: [17:29:22][Send-File] WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\] complete

It is strange, because I performed Install-DbaInstance command directly on the server where I wish to have the instance.
It looks like it transfers the file as if I wanted to do the installation remotely.
Is the first instance creation with DBA tools for me :-)
Maybe I put some nonsense in my order in the first place.
Environmental information
PowerShell Version        : 5.1.17763.1490
dbatools latest installed :  1.0.131   (downloaded there are 1 or 2 hours ago)
Culture of OS             : fr-FR

Could you please run the following and see if it returns True of False?
Import-Module dbatools
$instance = [DbaInstanceParameter]"SERVERNAME"  # change the SERVERNAME here to the name of the server exactly how you used it in the function call
$instance. IsLocalHost

Did you use the real server name, or an alias?
Also, once the above is done, could you validate that changing the server name to localhost works around this issue?

Hi Nvarscar,
Thank you for your help, resulte of your command is: True with shortname or $env:COMPUTERNAME
I used real servername not alias name
You want me to replace parameter: -InstanceName MyInstanceNameHere
By: -SqlInstance localhost\MyInstanceNameHere
For example?
I will try at the end of my working day today. I keep you informed as soon as possible.

No, I'm talking about using -SqlInstance localhost instead of -SqlInstance servername. Thanks for the info, this gives me some food for thought.
If you don't mind, could you get the same output for me, but with -Debug switch instead of -Verbose?

Hi again,
It same issue with this command:
Install-DbaInstance -Verbose -Version 2016 -SqlInstance localhost\MyInstanceNameHere -InstancePath "E:" -Feature Engine -Configuration @{ SQLCOLLATION = "Latin1_General_CI_AS"; AGTSVCSTARTUPTYPE="Automatic"; SQLSVCSTARTUPTYPE="Automatic" } -AdminAccount "DOMAIN\User1","Domain\User2" -EngineCredential $agentEngineCredential -AgentCredential $agentEngineCredential -PerformVolumeMaintenanceTasks -AuthenticationMode Mixed -SaCredential $saCredential -Path $setupPath

VERBOSE: [17:55:59][Resolve-DbaNetworkName] Resolving SERVERNAME using .NET.Dns GetHostEntry
VERBOSE: [17:55:59][Resolve-DbaNetworkName] Resolving <IP_ADDRESS> using .NET.Dns GetHostByAddress
VERBOSE: [17:56:08][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Retrieving Management Information
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM - Success
VERBOSE: [17:56:08][Resolve-DbaNetworkName] Resolving SERVERNAME.suffix.dns using .NET.Dns GetHostEntry
VERBOSE: [17:56:08][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:09][Install-DbaInstance] Looking for installation files in J:\setup.exe on remote machine
SERVERNAME.suffix.dns
VERBOSE: [17:56:09][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:09][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:09][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:11][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:11][Write-IniFile] Writing Ini file to
C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini

Confirm
Are you sure you want to perform this action?
Performing the operation "Install 2016 from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe" on target
"SERVERNAME.suffix.dns".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
VERBOSE: [17:56:16][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:16][Invoke-DbaAdvancedInstall] Copying
C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini to remote machine into
C:\Users\tgaudin.adm\AppData\Local\Temp\
VERBOSE: [17:56:16][Send-File] Starting WinRM copy of
[C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\tgaudin.adm\AppData\Local\Temp\]
VERBOSE: [17:56:16][Send-File] WinRM copy of
[C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\tgaudin.adm\AppData\Local\Temp\] complete
VERBOSE: [17:56:16][Invoke-DbaAdvancedInstall] Setup starting from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
VERBOSE: [17:56:16][Invoke-Program] Starting process
[J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe] with arguments
[/IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere"
/CONFIGURATIONFILE="C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini"] on
SERVERNAME.suffix.dns through Default protocol
Remove-Item : Cannot find path
'C:\Users\tgaudin.adm\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini' because it does not exist.
At D:\dsi\SQLServer\psmodules\dbatools\allcommands.ps1:41602 char:13
+             Remove-Item $ConfigurationPath
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\usernam...suffix.dns_2016.ini:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

WARNING: [17:56:17][Invoke-DbaAdvancedInstall] Installation failed with exit code -1073741515. Expand 'Log' property to
 find more details.

ComputerName      : SERVERNAME.suffix.dns
Version           : 13.0
SACredential      : System.Management.Automation.PSCredential
Successful        : False
Restarted         : False
Configuration     : {OPTIONS}
InstanceName      : MyInstanceNameHere
Installer         : J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
Port              :
Notes             : {Installation failed with exit code -1073741515. Expand 'Log' property to find more details.}
ExitCode          : -1073741515
Log               :
LogFile           : C:\Program Files\Microsoft SQL Server\130\Setup Bootstrap\Log\Summary.txt
ConfigurationFile :

Hi again,
I retried with this command:
Install-DbaInstance -Verbose -Version 2016 -SqlInstance localhost\MyInstanceNameHere -InstancePath "E:" -Feature Engine -Configuration @{ SQLCOLLATION = "Latin1_General_CI_AS"; AGTSVCSTARTUPTYPE="Automatic"; SQLSVCSTARTUPTYPE="Automatic" } -AdminAccount "DOMAIN\User1","Domain\User2" -EngineCredential $agentEngineCredential -AgentCredential $agentEngineCredential -PerformVolumeMaintenanceTasks -AuthenticationMode Mixed -SaCredential $saCredential -Path $setupPath

But same issue:
VERBOSE: [17:55:59][Resolve-DbaNetworkName] Resolving SERVERNAME using .NET.Dns GetHostEntry
VERBOSE: [17:55:59][Resolve-DbaNetworkName] Resolving <IP_ADDRESS> using .NET.Dns GetHostByAddress
VERBOSE: [17:56:08][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Retrieving Management Information
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM - Success
VERBOSE: [17:56:08][Resolve-DbaNetworkName] Resolving SERVERNAME.suffix.dns using .NET.Dns GetHostEntry
VERBOSE: [17:56:08][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:08][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:09][Install-DbaInstance] Looking for installation files in J:\setup.exe on remote machine
SERVERNAME.suffix.dns
VERBOSE: [17:56:09][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:09][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:09][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:11][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:11][Write-IniFile] Writing Ini file to
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini

Confirm
Are you sure you want to perform this action?
Performing the operation "Install 2016 from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe" on target
"SERVERNAME.suffix.dns".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
VERBOSE: [17:56:16][Get-DbaCmObject] Configuration loaded | Cache disabled: False
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
VERBOSE: [17:56:16][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM - Success
VERBOSE: [17:56:16][Invoke-DbaAdvancedInstall] Copying
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini to remote machine into
C:\Users\username\AppData\Local\Temp\
VERBOSE: [17:56:16][Send-File] Starting WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\]
VERBOSE: [17:56:16][Send-File] WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\] complete
VERBOSE: [17:56:16][Invoke-DbaAdvancedInstall] Setup starting from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
VERBOSE: [17:56:16][Invoke-Program] Starting process
[J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe] with arguments
[/IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere"
/CONFIGURATIONFILE="C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini"] on
SERVERNAME.suffix.dns through Default protocol
Remove-Item : Cannot find path
'C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini' because it does not exist.
At D:\dsi\SQLServer\psmodules\dbatools\allcommands.ps1:41602 char:13
+             Remove-Item $ConfigurationPath
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\usernam...suffix.dns_2016.ini:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

WARNING: [17:56:17][Invoke-DbaAdvancedInstall] Installation failed with exit code -1073741515. Expand 'Log' property to
 find more details.

ComputerName      : SERVERNAME.suffix.dns
Version           : 13.0
SACredential      : System.Management.Automation.PSCredential
Successful        : False
Restarted         : False
Configuration     : {OPTIONS}
InstanceName      : MyInstanceNameHere
Installer         : J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
Port              :
Notes             : {Installation failed with exit code -1073741515. Expand 'Log' property to find more details.}
ExitCode          : -1073741515
Log               :
LogFile           : C:\Program Files\Microsoft SQL Server\130\Setup Bootstrap\Log\Summary.txt
ConfigurationFile :

I also see that there is a problem with the installer picking a wrong setup.exe file. Could you possibly screenshot Details page of the setup.exe file properties, such as Product Name and Product Version, the one that it's picking up and the one that it's supposed to run?

Sorry I re-post previous message to remove few information about path, it is a rules of my company.
I retry with of your last answer ;-)

Setup.exe properties used:

Command used:
Install-DbaInstance -Debug -Version 2016 -SqlInstance localhost -InstanceName MyInstanceNameHere -InstancePath "R:" -Feature Engine -Configuration @{ SQLCOLLATION = "Latin1_General_CI_AS"; AGTSVCSTARTUPTYPE="Automatic"; SQLSVCSTARTUPTYPE="Automatic" } -AdminAccount "DOMAIN\User1","Domain\User2" -EngineCredential $agentEngineCredential -AgentCredential $agentEngineCredential -PerformVolumeMaintenanceTasks -AuthenticationMode Mixed -SaCredential $saCredential -Path $setupPath

DEBUG: 62385 | [18:19:46][Resolve-DbaNetworkName] Resolving SERVERNAME using .NET.Dns GetHostEntry
DEBUG: 62395 | [18:19:46][Resolve-DbaNetworkName] Resolving <IP_ADDRESS> using .NET.Dns GetHostByAddress
DEBUG: 62465 | [18:19:55][Resolve-DbaNetworkName] Getting domain name from the remote host SERVERNAME.suffix.dns
DEBUG: 21077 | [18:19:55][Get-DbaCmObject] Configuration loaded | Cache disabled: False
DEBUG: 21090 | [18:19:55][Get-DbaCmObject] [SERVERNAME] Retrieving Management Information
DEBUG: 21242 | [18:19:55][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM
DEBUG: 21247 | [18:19:55][Get-DbaCmObject] [SERVERNAME] Accessing computer using Cim over DCOM - Success
DEBUG: 62486 | [18:19:55][Resolve-DbaNetworkName] Getting DNS domain from the remote host SERVERNAME
DEBUG: 62504 | [18:19:55][Resolve-DbaNetworkName] Resolving SERVERNAME.suffix.dns using .NET.Dns GetHostEntry
DEBUG: 21077 | [18:19:55][Get-DbaCmObject] Configuration loaded | Cache disabled: False
DEBUG: 21090 | [18:19:55][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
DEBUG: 21130 | [18:19:55][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
DEBUG: 21135 | [18:19:55][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM -
Success
DEBUG: 81350 | [18:19:55][Invoke-Command2] Creating new Default session
[dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f] for SERVERNAME.suffix.dns
DEBUG: 40499 | [18:19:55][Install-DbaInstance] Looking for installation files in J:\setup.exe on remote machine
SERVERNAME.suffix.dns
DEBUG: 81350 | [18:19:55][Invoke-Command2] Creating new Credssp session
[dbatools_Credssp_0c38385f-df9c-44e2-92fc-c0759383ae9f] for SERVERNAME.suffix.dns
DEBUG: 81375 | [18:19:55][Invoke-Command2] Found an existing session
dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f, reusing it
DEBUG: 21077 | [18:19:56][Get-DbaCmObject] Configuration loaded | Cache disabled: False
DEBUG: 21090 | [18:19:56][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
DEBUG: 21130 | [18:19:56][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
DEBUG: 21135 | [18:19:58][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM -
Success
DEBUG: 40303 | [18:19:58][Write-IniFile] Writing Ini file to
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini

Confirm
Are you sure you want to perform this action?
Performing the operation "Install 2016 from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe" on target
"SERVERNAME.suffix.dns".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
DEBUG: 21077 | [18:20:01][Get-DbaCmObject] Configuration loaded | Cache disabled: False
DEBUG: 21090 | [18:20:01][Get-DbaCmObject] [SERVERNAME.suffix.dns] Retrieving Management Information
DEBUG: 21130 | [18:20:01][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM
DEBUG: 21135 | [18:20:01][Get-DbaCmObject] [SERVERNAME.suffix.dns] Accessing computer using Cim over WinRM -
Success
DEBUG: 81375 | [18:20:01][Invoke-Command2] Found an existing session
dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f, reusing it
DEBUG: 41549 | [18:20:01][Invoke-DbaAdvancedInstall] Copying
C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini to remote machine into
C:\Users\username\AppData\Local\Temp\
DEBUG: 83369 | [18:20:01][Send-File] Starting WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\]
DEBUG: 83409 | [18:20:02][Send-File] WinRM copy of
[C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini] to
[C:\Users\username\AppData\Local\Temp\] complete
DEBUG: 41559 | [18:20:02][Invoke-DbaAdvancedInstall] Setup starting from
J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
DEBUG: 82259 | [18:20:02][Invoke-Program] Acceptable success return codes are [0,3010]
DEBUG: 82260 | [18:20:02][Invoke-Program] Starting process
[J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe] with arguments
[/IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere"
/CONFIGURATIONFILE="C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini"] on
SERVERNAME.suffix.dns through Default protocol
DEBUG: 81375 | [18:20:02][Invoke-Command2] Found an existing session
dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f, reusing it
DEBUG: 82272 | [18:20:02][Invoke-Program] Process
[J:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe] returned exit code -1073741515
DEBUG: 81375 | [18:20:02][Invoke-Command2] Found an existing session
dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f, reusing it
DEBUG: 81375 | [18:20:02][Invoke-Command2] Found an existing session
dbatools_Default_0c38385f-df9c-44e2-92fc-c0759383ae9f, reusing it
Remove-Item : Cannot find path
'C:\Users\username\AppData\Local\Temp\Configuration_SERVERNAME.suffix.dns_2016.ini' because it does not exist.
At D:\dsi\SQLServer\psmodules\dbatools\allcommands.ps1:41602 char:13
+             Remove-Item $ConfigurationPath
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\unsernam...suffix.dns_2016.ini:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

WARNING: [18:20:02][Invoke-DbaAdvancedInstall] Installation failed with exit code -1073741515. Expand 'Log' property to
 find more details.
DEBUG: [18:20:02][Invoke-DbaAdvancedInstall] Installation failed with exit code -1073741515. Expand 'Log' property to
find more details.

Confirm
Continue with this operation?
[Y] Yes  [A] Yes to All  [H] Halt Command  [S] Suspend  [?] Help (default is "Y"):

Hi,
If you want I can try to launch command with -SaveConfiguration and I can try to launch directly setup.exe with this ini file.
What do you think?
Idea would potentially be to get more information about the error I have (-1073741515).
For the moment I have enough time to try, but I think in the late afternoon I can try.

Hi,
I retried another installation from ISO of SQL Server 2012 Enterprise with SP4.
I tried 2 ways:

With inifile from another similar confiugration for this new instance (-ConfigurationFile parameter)
Without inifile provided, but some parameters similar of my previous tests in SQL Server 2016

Base of my commands:
$saCredential = Get-Credential -Message  "sa account" -UserName sa
$setupPath = "X:\setup.exe"
Install-DbaInstance -Debug -Version 2012 -Path $setupPath -SaCredential $saCredential ...

In both cases I get this error code from setup: returned exit code -2067529678
And my inifile is delete after confirmation to continue my installation in temp directory.
I tried to perform same command that Invoke-DbaAdvancedInstall tried to launch:

X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\110\Setup\qfdhsf2y\setup.exe /IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere" /CONFIGURATIONFILE="C:\Users\username\AppData\Local\Temp\Configuration_machine.suffix.dns_2012.ini"

It is failed, but if I try with setup.exe given initially to DBA tools (given previously of this current answer):

X:\setup.exe /IACCEPTSQLSERVERLICENSETERMS /SAPWD="saPasswordHere" /CONFIGURATIONFILE="C:\Users\username\AppData\Local\Temp\Configuration_machine.suffix.dns_2012.ini"

Working it is better.
There seems to be some kind of path resolution X:\setup.exe --

X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\110\Setup\qfdhsf2y\setup.exe

For information all ISO images povide of Volume Licensing Service Center of Microsoft.
This afternoon I will try the same thing with the same ISO image in 2016 as my previous problems.
Otherwise as far as the patch of instances is concerned it works perfectly (Update-DbaInstance) ;-) !
Regards

Hi again,
I confirm if I launch manually setup.exe with path given by Invoke-DbaAdvancedInstall
DEBUG: 41559 | [13:47:36][Invoke-DbaAdvancedInstall] Setup starting from
X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe

X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe MyParamsHere

Does not work.
But If I execute manually with my initial setup fullpath it is working correctly:
X:\setup.exe MyParamsHere

My DBA tools command was:
PS C:\windows\system32> $setupPath
X:\setup.exe
Install-DbaInstance -Debug -Version 2016 -ConfigurationFile "D:\myInstanceNameHere.ini" -SaCredential $saCredential -Path $setupPath

...
DEBUG: 40499 | [13:47:31][Install-DbaInstance] Looking for installation files in X:\setup.exe on remote machine machinename.suffix.dns
...

Performing the operation "Install 2016 from X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe" on target
"machinename.suffix.dns".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
...
DEBUG: 41559 | [13:47:36][Invoke-DbaAdvancedInstall] Setup starting from
X:\1033_ENU_LP\x64\Setup\sqlsupport_msi\PFiles\SqlServr\130\Setup\hyvs_tx2\setup.exe
...

I am running dbatool version1.0.139.  I am getting the same issue with "Installation failed with exit code -1073741515",
Remove-Item : Cannot find path 'C:\Users\UserName\AppData\Local\Temp\Configuration_ServerName_2016.ini' because it does not exist.  At C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.139\allcommands.ps1:41795 char:13
Commands like
a.  install-DbaInstance -Path D:\ -Version 2016
b. Install-DbaInstance -Path D:\ -Version 2016 -ConfigurationFile 'C:\temp\install\ConfigurationFile.ini'
I tried the example above, $setupPath
D:\setup.exe
Install-DbaInstance -Debug -Version 2016 -ConfigurationFile "C:\temp\install\ConfigurationFile.ini" -SaCredential $saCredential -Path $setupPath
but the sql GUI pops up and which is not I wanted.
Please help.
Thank you!

I think the key here is the property .IsLocalHost. You have already noticed, that Invoke-DbaAdvancedInstall does not get $true here, but $false and thus copies the file. I think because of the used copy mechanism, the file is deleted.
So let's see what Invoke-DbaAdvancedInstall does:
$isLocalHost = ([DbaInstanceParameter]$ComputerName).IsLocalHost

And what is $ComputerName? It is [string]$ComputerName in the param block of Invoke-DbaAdvancedInstall.
Inside of Install-DbaInstance, this is $fullComputerName (in the verbose output this is "SERVERNAME.suffix.dns").
So this will likely return $false and be the root cause of the problem:
Import-Module dbatools
$instance = [DbaInstanceParameter]"SERVERNAME.suffix.dns"  # like in verbose output of Invoke-DbaAdvancedInstall
$instance.IsLocalHost

So "suffix.dns" will not be "the correct USERDNSDOMAIN" as in this test:
if (Name.ToLower() == (Environment.MachineName + "." + Environment.GetEnvironmentVariable("USERDNSDOMAIN")).ToLower())

from line 51 of Validation.cs
What is your $env:USERDNSDOMAIN?
@nvarscar - Testing .IsLocalHost with the $fullComputerName might give false results - as we see here. As a solution I would set $fullComputerName to $ComputerName if .IsLocalHost inside of Install-DbaInstance.


API updated, intro notebook added

notebooks/intro_to_automl.py added
API simplified to be more clear

Hello @nicl-nno! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file fedot/core/chains/chain_template.py:

Line 235:21: W292 no newline at end of file

In the file test/unit/api/test_main_api.py:

Line 90:1: E302 expected 2 blank lines, found 1


Add version: Canonical.Multipass version 1.13.0+win

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Verify:

/AzurePipelines run


Improve Docs

add use-cases for options
closes #103 webpack-manifest-plugin-after-emit hook

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #104   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          78     78
=====================================
  Hits           78     78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409b0fb...8f7e3f0. Read the comment docs.

Thanks for opening this PR a while back, and I'm sorry that it didn't get attention sooner. We've updated the documentation as part of #222. If you'd like to add examples to the various methods, please open a new issue with your suggestions and we can talk about the concept of a recipes directory.


Don't Merge! PR real time test for webhook case

Docs Build status updates of commit fd5fb25:
:clock10: Pending: waiting for processors (21 builds ahead of you)
:warning: Docs Build is busy, currently there are 21 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit fd5fb25:
:clock10: Full build: the average full build time is 7 min(s) 44 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit fd5fb25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/testing.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Unittest: replaced unittestcoverage.py with symlink file

THis commit is to replace the existing file (e.g., unittest.coverage.py) with
a symbolic linke file to synchronize the same file between TAOS-CI/gcov and nnstreamer/tests.
Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.20190225. Thank you for submitting PR #462. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

:octocat: cibot: @nnsuite, There is a newline issue. The final line of a text file should have newline character. Please resubmit your PR after fixing end of line in .

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/462-201903051924290.57399797439575-ae1e8a47f80297abde87a965548cbbfeb37831a0/report/.


gh-719 - Updated wiki to include reference to JARs hosted in Maven central

Codecov Report

Merging #753 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #753      +/-   ##
=============================================
+ Coverage      60.08%   60.13%   +0.04%
- Complexity      2800     2802       +2
=============================================
  Files            425      425
  Lines          12820    12820
  Branches        1434     1434
=============================================
+ Hits            7703     7709       +6
+ Misses          4515     4511       -4
+ Partials         602      600       -2

Impacted Files
Coverage Δ
Complexity Δ

.../gov/gchq/gaffer/store/schema/SchemaOptimiser.java
80.64% <0%> (+6.45%)
23% <0%> (+2%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c0e79...3843573. Read the comment docs.


Fix follow_requests order

This PR fixes #23

Can you look into this @tribela? Not sure but looks like a bug.

Why is .layout-single-colume instead .layout-single-column?
In the multiple columns CSS it uses "single-colume" instead "multiple-columns".

My bad. I'll re-open new pr