[$500] DMs with a hidden notification preference show up in search without a name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.29-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @srikarparsi
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705731187838889
Action Performed:

Create a DM with another user that you have not previously DMed
Navigate to another chat so that the DM disappears from your LHN
Click search and see the DM that you have just created appear

Expected Result:
should be hiding these DMs from search entirely
Actual Result:
Only profile pics are shown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/2ec8dd3e-c31f-45df-9f47-985b654d3a66

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019a3378b1028ed211
Upwork Job ID:<PHONE_NUMBER>916659712
Last Price Increase: 2024-02-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
DMs with a hidden notification preference show up in search without a name
What is the root cause of that problem?
We are not filtering out personal details with accountID of NaN in Search Page
What changes do you think we should make in order to solve the problem?

We should filter out those with accountid of Nan in search page
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
should be hiding the empty DMs  from search entirely
What is the root cause of that problem?
When the chat just created we do not have the accountID and the any chat message in the report. And Even when we send a message the accountID still NaN
And when we get list recentReports,  we don't filter recentReports that don't have an accountID and alternateText is empty.
What changes do you think we should make in order to solve the problem?
We should filter recentReports with the condition accountID correct and alternateText is not empty
What alternative solutions did you explore? (Optional)
N/A

Updated to add more detail and alternative approaches

Updated to add more detail and alternative approaches

@kavimuru I might need clarification on the expected result. Should we exclude all the empty chat reports on the recent list or those that only show the profile pic?
From the above screenshot, I see a bug showing the report with only the profile picture.

@srikarparsi Could you help clarify the above question? Thank you!

Proposal
Please re-state the problem that we are trying to solve in this issue.
When we search for a user without internet, the recent search results do not show the users display name
What is the root cause of that problem?
The accountId never got resolved while offline. This results in a null accountId for the record.
Snapshot of the entity is here:

We return an empty displayName under this condition:
https://github.com/Expensify/App/blob/0efabc2b40fe845b13faa94ec508a6693167ede9/src/libs/ReportUtils.ts#L1608C1-L1611C6
Hence why we render null.
What changes do you think we should make in order to solve the problem?
We can update the displayName logic to fallback to option.text if it doesn't resolve the displayname here:
https://github.com/Expensify/App/blob/0efabc2b40fe845b13faa94ec508a6693167ede9/src/libs/ReportUtils.ts#L1645
It already short-circuits to login, but in this error case it's also not present.
Note:
After the user refreshes the page or interacts with the User - it fixes the database and will show the correct displayName.

What alternative solutions did you explore? (Optional)

Need clarification https://github.com/Expensify/App/issues/34900#issuecomment-1906275439
cc @kavimuru @srikarparsi

In regard to this question, I believe we should exclude all empty chats. I think the search function should be optimized for existing chats, for empty chats it would be just as simple to "re-create" them.

Does anyone want to update their proposal according to the above expectations?

Updated proposal in alternative solution considering the above expectation

Still awaiting proposals

@dukenv0307 So you suggesting removing the list that shows only the avatar? I think that will be better. @srikarparsi what are your thoughts on this?

Hm I'm not sure.

When User A creates a report with User B but doesn't send a message immediately, but switch to another report. Now User A has no way to find the chat with User B.

I personally think that you would just create the chat with them again. There's not really anything to find since there's been no messages in my opinion. But I asked for other opinions here and will update this GH.

Cool, I also asked internally and the consensus also seems to be only removing the list items that only show the avatar and not the name.

Sorry, what clarification are we waiting on?

@srikarparsi Sorry, I misunderstood the comment.
I tested again this issue with the latest main and it has a different issue this time. Instead of showing the list with only the avatar, now it shows with the email, but the duplication remains.

@srikarparsi I think we need to update the issue description and title.

Issue not reproducible during KI retests. (First week)

Yeah, I see that too, changing the issue title and description

With the new updated expected result, I think we can go with @dukenv0307 proposal. It did removing the duplicate option item.
🎀 👀 🎀 C+ reviewed!

Not overdue

@srikarparsi the issue missing label Awaiting Payment and the payment date, could you update it? Thank you!

Yup! Seems to be the case. Hey @muttmuure do you think you could help with payment for this PR after the regression period. Also, I don't believe the automation worked, do you know if there's a way to get around that?

@mollfpr - $500 for C+
@dukenv0307 - $500 for C

All paid up, @mollfpr needs to request in NewDot using the summary above

$500 approved for @mollfpr based on summary.


Plugins support

It would be great to handle Babel plugins with --plugins the same way as --presets. Typically people use babel-plugin-transform-decorators-legacy.
I can make a pull if the idea is good :-)

Hello @christianalfoni. This would be nice indeed. My only concern is the ambiguity of the plugins here. You wouldn't know then a

Note that an alternative is also to have a babelrc file or a babel config in the package.json and use the --babel option.

Ah, yeah, good point. It worked out completely fine using own config :) Really amazing to see how little configuration is needed!
Let me close this as plugins is easily solved

Happy to know it's useful to you :)


Add location to Cyclic Module Imports diagnostic

Description:
Currently the Cyclic Module Import (BCE2001) diagnostic does not contain a line range. Therefore it is not highlighted in vscode.

A valid line  range of the import statement should be added in order to improve the UX

The location is not added for cyclic dependencies to be consistent with cases where the cyclic dependency is formed within dependencies. Locationless diagnostics are issued on purpose and they will have the line position as (0,0) and text range as (0.0). Can we figure out a way to display these diagnostics?
What if we highlight the first/last line of the file or entire file?

The location is not added for cyclic dependencies to be consistent with cases where the cyclic dependency is formed within dependencies. Locationless diagnostics are issued on purpose and they will have the line position as (0,0) and text range as (0.0). Can we figure out a way to display these diagnostics?
What if we highlight the first/last line of the file or entire file?

@malinthar any thoughts?

The location is not added for cyclic dependencies to be consistent with cases where the cyclic dependency is formed within dependencies. Locationless diagnostics are issued on purpose and they will have the line position as (0,0) and text range as (0.0). Can we figure out a way to display these diagnostics?
What if we highlight the first/last line of the file or entire file?

@malinthar any thoughts?

We'll have to discuss and come to a conclusion

Closing according to the explanation in https://github.com/ballerina-platform/ballerina-lang/issues/37438#issuecomment-1282187448. Please reopen if you have any issues with implementing the suggested solution.


Help on detecting option for cmt module

Issue description
I can't seem to figure out how to correctly set config. Also can't really find anything relevant on the manual.
I have set options in nixpkgs/nixos/modules/services/x11/hardware/cmt.nix for all the different chromebook models as the files included in nixpkgs/nixos/pkgs/os-specific/linux/chromium-xorg-conf/default.nix has different xorg.conf.d files for different models.
I can't seem to enable these options and any help would be great
Steps to reproduce
Try to build my fork.
Technical details
Please run nix run nixpkgs.nix-info -c nix-info -m and paste the result.

@yegortimoshenko @Mic92

What does your nixos configuration looks like or the evaluation error?

[calvin@bitcoin:~/Documents/nix/nixpkgs/nixos/modules]$ nixos-rebuild build -I nixpkgs=~
/Documents/nix/nixpkgs/
building Nix...
error: The option 'atlas' defined in '/home/calvin/Documents/nix/nixpkgs/nixos/modules/s
ervices/x11/hardware/cmt.nix' does not exist.
(use '--show-trace' to show detailed location information)
building the system configuration...
error: The option 'atlas' defined in '/home/calvin/Documents/nix/nixpkgs/nixos/modules/s
ervices/x11/hardware/cmt.nix' does not exist.
(use '--show-trace' to show detailed location information)

I think my config isn't setup correctly in nixpkgs/nixos/modules/services/x11/hardware/cmt.nix
My configuration.nix is in github.com/kcalvinalvin/calvin-nix-conf

Take a look at https://github.com/kcalvinalvin/nixpkgs/commit/ca991dd97348ec9b22837fc2a983682bc05c8d23#r34545159

Take a look at ca991dd#r34545159

this solved it!


[Bug] Value for service.type is only respected for frontend

What are you really trying to do?
I am trying to enable NodePort services for all server components, not only the frontend.
Describe the bug
In the values.yaml all server components look like they're prepared to select a different Service type than the default ClusterIP. The final template will only respect the frontend though. The restrest is just rendered plain and static: https://github.com/temporalio/helm-charts/blob/master/templates/server-service.yaml#L60

Minimal Reproduction
Minimal values.yaml file to reproduce the issue:
---
server:
  frontend:
    service:
      type: NodePort
  history:
    service:
      type: NodePort
  matching:
    service:
      type: NodePort
  worker:
    service:
      type: NodePort

Environment/Versions

Helm version v3.7.0 on Linux
Temporal / Chat Version: 1.17.4

Additional context
I am not even sure if this is a valid use case, but we are trying to run Temporal across multiple Kubernetes clusters therefore need individual services to be reachable from outside of the cluster.

Aside from frontend, the services are used only for metric scraping. It does not make sense to expose them.


Is there any plan to release training script?

Hi, thanks for your wonderful paper and the released inference code!!! I am wondering if there is any plan to release the training script. Your reply will be highly appreciated~

I attempted to develop training for this, but the outcomes aren’t meeting my expectations (my goal was to overfit it for a single object, such as a shoe). Below given repo contains the code for training the model. This code is specifically designed to train 3D geometry, as I am deliberately inputting RGB images (manually captured) and CCM images (previously generated).
Repo link
please contribute to it if it has any mistakes / bug found

Thank you for your interest! The training code for the CRM is quite extensive, and it's difficult to organize it all in a short period. I will start by gradually uploading some of the utility functions I have organized.

Thank you for your interest! The training code for the CRM is quite extensive, and it's difficult to organize it all in a short period. I will start by gradually uploading some of the utility functions I have organized.

@thuwzy can you take a quick look to the training I have uploaded and plz identify mistakes I am making since I am not getting result as expected

Thank you for your interest! The training code for the CRM is quite extensive, and it's difficult to organize it all in a short period. I will start by gradually uploading some of the utility functions I have organized.

@thuwzy can you take a quick look to the training I have uploaded and plz identify mistakes I am making since I am not getting result as expected

Hi Sanket, I have read your code and found some problems. (1) the sdf should not be randomly initialized. Instead, it should be got from the output triplanes from the sdfMLP. (2) The learning rate is too high. I suggest 1e-4.


Manage Databases in shared RDS with Terraform

Overview
Databases (and their attendant secrets) should be managed using IaC (i.e. Terraform) and secret management in AWS.
Build out a database module for projects that need a database in the shared RDS.
Action Items

[ ] Build the module
[ ] Incorporate it into a first project

Resources/Instructions
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/secretsmanager_secret_version
https://registry.terraform.io/providers/SpencerBinXia/postgresql/latest/docs

@nyarly should this issue be moved to incubator?


LED_Fade Project

This is a project/issue that was mentioned in the Issues tan

Thanks for the contribution, All the best for Hacktoberfest 2021. Do let me know, if this PR counts

Thank you and yes it counted
On Sun, Oct 4, 2020 at 1:26 PM Ankur<EMAIL_ADDRESS>wrote:

Merged #48
https://github.com/Ankuraxz/NASSCOM-MHRD-IOT-Practical-Module_1-2/pull/48
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Ankuraxz/NASSCOM-MHRD-IOT-Practical-Module_1-2/pull/48#event-3837382230,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APXGQJTYZWUOV3ND7MLNQBLSJA5T7ANCNFSM4SDQ3RUQ
.


fix(CI): build the Archive and Counterexamples with --wfail also

This appears to be an oversight --- which has no consequences right now (the check for noisy output later would catch any warnings), but fixing it doesn't hurt either.
Zulip discussion.

bors d+
(after satisfying actionlint)


Change Marked extension priority order

This PR resolves #3378.
By changing the order of the Marked extensions, the priority is changed so definition list terms will no longer consume preceding mustache block definitions.

Thanks @G-Ambatte!


Running Cellpose in Mac 10.11.6: Symbol not found: _clock_gettime

I'm getting the following error while trying to run the Cellpose in my Macbook Pro:
ImportError: dlopen(/opt/anaconda3/lib/python3.7/site-packages/cv2/cv2.cpython-37m-darwin.so, 2): Symbol not found: _clock_gettime
Referenced from: /opt/anaconda3/lib/python3.7/site-packages/cv2/.dylibs/libavutil.56.31.100.dylib (which was built for Mac OS X 10.13)
Expected in: /usr/lib/libSystem.B.dylib
in /opt/anaconda3/lib/python3.7/site-packages/cv2/.dylibs/libavutil.56.31.100.dylib
I have an El Capitan 10.11.6. Is there any way to get rid of this problem?

Maybe try downgrading opencv-python? (the package name for cv2)
pip install opencv-python==<IP_ADDRESS>

(recommendation from here)


should we update the recommended hardware in the installation page?

Describe the change
the reth book here recommended s2.small.x86:

but latitude has already deprecated this box:

the new ones available are:

should we upgrade to c3.small.x86? if now and using the legacy version is still the recommended one, I think we can add some notes in the reth book to avoid confusion
Additional context
No response

Yeah, let's recommend the c3.small.x86 for pruned/full nodes.

https://github.com/paradigmxyz/reth/pull/10313 out for review


new urlizer breaks on draft-xxxx-xxxx-00.txt

At /doc/draft-calhoun-enh-radius-filter/history/
 New version available: draft-calhoun-enh-radius-filter-00.txt

Did you want the .txt included in the link text?

that would preserve the old implementation's behavior. The links that are being created now 404.

Fwiw, A rewrite of the URL handlers to make a url like what you construct not 404 isn't the right way to go. An alternative would be to directly produce what /doc/draft-xxx-xxx-nn.txt redirects to, which is /doc/draft-xxx-xxx/nn/, but then we need to fix the danging .txt (or .whatever) in the source material. So for now, using the gearing we have is the right step.

I ended up producing /doc/draft-xxx-xxx/nn/ and a related pair of variants for charter versions.


[Bug] [Module Name] Bug title sql task error: java.lang.RuntimeException: java.lang.ClassNotFoundException: com.mysql.jdbc.Driver

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Hi, Im's testing the function of dolphinscheduler2.0 and find the issue of mysql that when I execute the task of sql query from mysql, the result is that it cannot find com.mysql.jdbc.driver even though I put mysql-connector-java-8.0.27.jar into dolphinscheduler/lib. Howerver, Im's able to connect mysql by the way of datasource
What you expected to happen
[ERROR] 2021-12-09 21:15:26.542  - [taskAppId=TASK-3797991916704_1-29-37]:[210] - execute sql error: java.lang.ClassNotFoundException: com.mysql.jdbc.Driver
[ERROR] 2021-12-09 21:15:26.543  - [taskAppId=TASK-3797991916704_1-29-37]:[161] - sql task error: java.lang.RuntimeException: java.lang.ClassNotFoundException: com.mysql.jdbc.Driver
I think it's the issue of compatibility between the version of mysql server and mysql jdbc driver
How to reproduce
we can test a demo about sql with the statement of sql
Anything else
No response
Version
2.0.0
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please put the driver package under the path lib/plugin/task/sql

Similar problems: #7330

Thank you, I will try it
At 2021-12-10 18:49:27, "Kerwin" @.***> wrote:
Please put the driver package under the path lib/plugin/task/sql
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

close duplicate issue


cluster_name not populated in cassandra.yaml by k8ssandra-client

Issue Description:
I've noticed that the k8ssandra-client does not fill the cluster_name field in cassandra.yaml. The ClusterInfo struct contains a field for the cluster name, but it doesn't seem to be used anywhere in the code. This leads to incorrect monitoring metrics from the exporter because it fills the cluster_name label according to the cassandra.yaml parameters.
Example:
❯ cassandra@damir-test-damir-test-dc-rack1-sts-0:/$ cat /etc/cassandra/cassandra.yaml | grep cluster_name
cluster_name: Test Cluster

❯ k get pods -n mynamespace -o yaml | grep CONFIG_FILE_DATA -A 1
  - name: CONFIG_FILE_DATA
    value: '{"cassandra-env-sh":{"___OMITTED:___"cluster-info":{"name":"damir-test","seeds":"damir-test-seed-service,damir-test-damir-test-dc-additional-seed-service"},___OMITTED:___}'

Expected Behavior:
I believe the cluster_name field in cassandra.yaml should be properly filled by the k8ssandra_client.
Additional Information:
k8ssandra-client version: v0.2.0

resolved in https://github.com/k8ssandra/k8ssandra-client/pull/18


Rename weekday to workweek

Checklist

[x] I checked the Contributing Guidelines before creating this request.

As per this wikipedia page
Another variant is isAWorkday or isAWeekday, but I think isInWorkweek works better with isInWeekend

          2 Warnings

:warning:
Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger

Thank you @kaphacius, as mentioned in Apple's documentation, weekday refers to any day in the week, including weekend, which might be confusing here.
Personally I've never heard the word workweek before, but English is not my main language 😃
We might also consider renaming it to isWorkDay or isBusinessDay, what do you think guys?

I see, after looking at the documentation I wouldn't be opposed to isWorkday

done, isWorkday it is :)


MaxListenersExceededWarning because of window.mainApi.receive

MaxListenersExceededWarning
In the template a listener for msgReceivedVersion is registered. But this happens every time the component is mounted. So when switching from screen to screen 12 times, you'll get a warning. This is a possible memory leak.
To Reproduce
Switch from Main to Second at least 12 times.
Expected behavior
Listeners should be registered only once or destroyed on onUnmounted() (I guess)
Device information (please complete the following information):

OS Name: macOS
OS Version: Sonoma 14.2.1 (M1 Pro 2021)

Hello! Thanks for using Vutron template!
Thank you for reporting the issue. That's a very good point!
I hadn't thought about disabling the event listener in the past template code because there was only one screen.
I've fixed and committed the issue to the latest master code, which now uses sendSync to get the value immediately from the main process instead of going through two steps, and changed the event listener to not register.
Let me know if this doesn't work for you. If you have any other issues or want to leave a comment, please create a new issue and I'll close this one.
Thanks again for reporting the issue!

I suggest using .invoke() here and in IPC use .handle().
Still I'm wondering where to register the listeners if I would have any.

So what I do in onMounted is:
onMounted((): void => {
  // Get application version from package.json version string (Using IPC communication)
  window.mainApi.invoke('msgRequestGetVersion').then((version: string) => {
    appVersion.value = version
  })
})

and in IPCs:
// Get application version
ipcMain.handle('msgRequestGetVersion', () => {
  return Constants.APP_VERSION
})


AutoScoll to the End after each Log entry

I tested the Samples (WinFormsHostNet50Sample, WpfNet50Sample, and WpfNet462Sample) and when the Log reached the bottom of the form, it does not scroll. When I use Serilog to log to the Console, it does. I'm using the Hybrid WPF/Winforms Example (WinFormsHostNet50Sample), so I can't use a trigger or Event (that I know of). If its possible to enable ScrollToEnd() somehow, or give the option to reverse the log (richtextbox.Text="new Log data" + richtextbox.Text), that would put the newest log on the top.
I use the program to monitor alot of processes so it would be helpful to see the most recent output without manually scrolling down.

Hi i have posted @stackoverflow a solution for wpf richtextbox autoscroll.
Just replace in stackoverflow code "yourRichtTextBox"  with "_richTextBox" from the WpfNet50Sample code,
https://stackoverflow.com/a/69489605/5342618

Moving to GitHub discussions as this is out-of-scope for a Serilog Sink would do


Path to resources changes through packaging

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
When reading a file from the base directory of your app, you can usually just do fs.readFileSync("data.json") or similar. After packaging the path changes to fs.readFileSync("resources\app\data.json") and previously working code will break.

What command line arguments are you passing? Alternatively, if you are using the API, what
parameters are you passing to the packager() function?
electron-packager .

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-quick-start
is a good starting point.
This can easily be tested by installing quick start and changing renderer.cs to somthing like this:
var a = require("fs");
var b = a.readFileSync("data.json", "utf8");
document.writeln(b);

Then package and the script won't work anymore. There are obviously easy workarounds for this, like just changing the path before packaging, but that can become a time consuming and repetitive task. I also spent a couple hours to find this out in the first place.

Whenever you try to load a path in node.js through the fs API's, if you provide a non-absolute path it is resolved relative the the CWD of your application.  In dev this is the root of your app, in pacakged this is wherever your exe or .app file is.
You need to resolve absolute paths yourself using path.resolve(__dirname, 'data.json')

@MarshallOfSound Setting Absolute path is not working for me, I have a db file in a directory and I added it to my build file as:
"extraResources": [
      "app/clipboarddb/copydata.db",
    ]

When I look at the packaged apps resources I see the file, but in the Handler I have:
const dbPath = path.resolve(__dirname, 'copydata.db')
And I still get Error:
Cannot open Database because the directory does not exist

If you put copydata.db into extraResource, it's in the resources directory, not the app directory, per the docs. The resources directory is usually one folder above the packaged base app directory, if I remember correctly.


[FEATURE]: Agent audit function

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Problem Description
The DongTai  commercial version needs to review the agent.
Proposed Solution
I need change code in agent.jar and dongtai-core.jar.
Alternatives Considered
No response
Additional Information
No response

released in v1.1.1


fix(q): :bug: could not install plugin on cordova 9+

the error message is an attempt to communicate that we do not really want to support using "requireCordovaModule" to load non-Cordova module "q" any longer.

https://github.com/apache/cordova/issues/52#issuecomment-475696680
https://stackoverflow.com/questions/55304065/cordova-error-using-requirecordovamodule-to-load-non-cordova-module-q-is-no

Contributing checklist

[ ] Code must follow existing styling conventions
[ ] Added a descriptive commit message

Solves issue(s)

@msach22 @enricop89 do you mind having a look ? I was not able to use the plugin without this modification.

@msach22 @enricop89 do you mind having a look ? I was not able to use the plugin without this modification.

Thanks for the fix @cadesalaberry!


Graph from file?

I’m looking at OSMnx and needing to create a graph from a local OSM file, such as the ones generated by Metro Extracts. I would expect to see this in the group of graph_from_* functions (e.g. graph_from_address, graph_from_bbox, etc.). Does this exist someplace? If it doesn't, would it be a welcome addition to OSMnx?

I don't believe there exists, currently, the ability to do a graph from a local file.
All the graph_from_* (I believe) wrap just over graph_from_bbox, which feeds osm_net_download output into create_graph.
If it (a from_local were to be generated, I think there could be the option to read from a file instead of run osm_net_download and pass that to create_graph. Would just need to resolve the fact that the response is current a JSON and the extracts would be XML, PBF, etc...

Thanks Kuan! The way I'm thinking of using this data, I need to have a known version of OSM data to coordinate between a few different pieces of software. I’ll root around in the code to see if any obvious implementations jump out at me.

Yeah! What’s nice about starting from OSM files is that you can run Osmosis on them to do your filtering. I don't specifically have an issue with the OO vs. functions thing, just looking for another way to get vetted data in.

@migurski @kuanb correct, this functionality does not currently exist. However it would be a very welcome addition. I know there has been interest in this previously from other quarters... I just haven't had the time or personal need to develop it myself. But a graph_from_osm_file() function would be really useful if you have any interest in looking into it. It wouldn't take much processing to pass the read data off to the create_graph() function.

Resolved by #95

@gboeing Is there any way of saving a graph as osm (or pbf)? Is this reasonable a feature?

@zifeo no, OSMnx saves graphs as GraphML, ESRI shapefile, or regular old node/edge lists. Converting data back to .osm format would be a specialized task and probably best to consult https://wiki.openstreetmap.org/wiki/Converting_map_data_between_formats or similar.

Thanks!


Question about model prune   剪枝 问题

To get a small model, I try to use some model pruning schemes（Like network slim） to cut the basic model.

In order to facilitate pruning, I use build_detector to get the model first.
and simply use torch.save to save the whole model, the checkpoint is also saved as torch.save(model.state_dict(), checkpoint_path), and add 'meta' and 'optimizer' in the checkpoint.
Then, i use HFP to changes the number of channels and corresponding parameters of the network like

if name == 'layer1.0.conv1':
        module.weight.data = module.weight.data[keep_index_feature['backbone.layer1.0.bn1'], :, :, :]
        module.weight.data = module.weight.data[:, keep_index_feature['backbone.bn1'] , :, :]

and do the same operations in checkopint. e.g. with this operations, the backbone.layer.0.conv1's channel can be pruned from 64 to 49
3. after pruning, i want to test or retrain the model. And i modify the test.py, just use torch.load to get the model,
    # build the model and load checkpoint
    # model = build_detector(cfg.model, train_cfg=None, test_cfg=cfg.test_cfg)
      model = torch.load('./after_pruned_model.pth')
      fp16_cfg = cfg.get('fp16', None)

and modify config/base/default_runtime.py to load_from the pruned checkpoint
# yapf:enable
dist_params = dict(backend='nccl')
log_level = 'INFO'
load_from = './after_pruned_checkpoint.pth'
resume_from = None
workflow = [('train', 1)]

python ./tools/test.py configs/xxxx.py ./after_pruned_checkpoint.pth --eval bbox --out result.pkl

But always get dimension error messages Like

lib/python3.7/site-packages/mmcv/cnn/bricks/conv_ws.py", line 106, in _get_weight.py", line 106, in _get_weight
weight = self.weight_gamma * weight + self.weight_beta
RuntimeError: The size of tensor a (64) must match the size of tensor b (49) at non-singleton dimension 0

The original number of channels is 64, and 49 is my modified number of channels. I can be sure that the model and checkpoint have been modified correctly.
I wonder whether my processing flow is correct, or I can only manually define the network in config  rather modifying the trained model.pth.
Sincerely hope to get a reply  @jshilong @RangiLyu

@syswyl It seems that you did not prune the weight_gamma and weight_beta channel causing an error.

``> @syswyl It seems that you did not prune the weight_gamma and weight_beta channel causing an error.
well, i've done that.
def prune_bn(bn_layer, index):
    bn_layer.weight.data = bn_layer.weight.data[index]
    bn_layer.running_mean = bn_layer.running_mean[index]
    bn_layer.running_var = bn_layer.running_var[index]
    bn_layer.bias.data = bn_layer.bias.data[index]
    bn_layer.num_features = len(index)

and after prune, The backbone network structure of my model is as follows(show the prime layers)

conv1 torch.Size([49, 3, 7, 7])
bn1 torch.Size([49])
layer1.0.conv1 torch.Size([51, 49, 1, 1])
layer1.0.bn1 torch.Size([51])
layer1.0.conv2 torch.Size([62, 51, 3, 3])
layer1.0.bn2 torch.Size([62])
layer1.0.conv3 torch.Size([224, 62, 1, 1])
layer1.0.bn3 torch.Size([224])
layer1.0.downsample.0 torch.Size([224, 49, 1, 1])
layer1.0.downsample.1 torch.Size([224])

DetectoRS_ResNet(
(conv1): ConvAWS2d(3, 49, kernel_size=(7, 7), stride=(2, 2), padding=(3, 3), bias=False)
(bn1): BatchNorm2d(49, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(relu): ReLU(inplace=True)
(maxpool): MaxPool2d(kernel_size=3, stride=2, padding=1, dilation=1, ceil_mode=False)
(layer1): ResLayer(
(0): Bottleneck(
(conv1): ConvAWS2d(49, 51, kernel_size=(1, 1), stride=(1, 1), bias=False)
(bn1): BatchNorm2d(51, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(conv2): ConvAWS2d(51, 62, kernel_size=(3, 3), stride=(1, 1), padding=(1, 1), bias=False)
(bn2): BatchNorm2d(62, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(conv3): ConvAWS2d(62, 224, kernel_size=(1, 1), stride=(1, 1), bias=False)
(bn3): BatchNorm2d(224, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
(relu): ReLU(inplace=True)
(downsample): Sequential(
(0): ConvAWS2d(49, 224, kernel_size=(1, 1), stride=(1, 1), bias=False)
(1): BatchNorm2d(224, eps=1e-05, momentum=0.1, affine=True, track_running_stats=True)
)
)

Are there any other problems with the handling method？ @hhaAndroid

@syswyl It seems that you did not prune the weight_gamma and weight_beta channel causing an error.

oooh , i got it, thanks when i print the checkpoint's weights, those parameters are indeed not modified
thanks ~

@syswyl It seems that you did not prune the weight_gamma and weight_beta channel causing an error.

oooh , i got it, thanks when i print the checkpoint's weights, those parameters are indeed not modified thanks ~

你好，可以分享一下剪枝的经验吗，代码可以分享一下吗

@xuhao-anhe 您好，其实基于mmdet这一套剪枝的话不是很方便，我的实现是首先用内置的模型加载方式，然后再直接torch.save之后，套用一些开源的剪枝算法，没有特别的操作。如果是这个框架可以用mmlab自己的mmrazor试试。其他通用的torch模型的话建议试试微软的nni支持的model还是比较多的，使用也方便。如果是yolo系列的话可以看看yolov3-channel-and-layer-pruning，以及相关的repo

@syswyl Do you meet the question when you use nni pruning model of training by mmdetection?

@Audrey528 hi, That's because mmlab's model requires **data to be constructed during input, so directly used dummy_input = torch.ones (1,3,224,224) will cause errors.
You can consider modifying its forward function by referring to the onnx export requirements
link
model.forward = partial(model.forward, img_metas={}, return_loss=False)
torchtoonnx
In essence, it is a forward problem.I forgot how to solve it accurately, but the solution is like this


Laravel 5.5 support

Are you planning on offering Laravel 5.5 support?
The service providers are structured a little bit different there:

ConsoleSupportServiceProvider registers the MigrationsServiceProvider
ArtisanServiceProvider now contains the registerMigrateCommand etc methods

Hi,
currently I don't have any plans to adapt the source to Laravel 5.5, but feel free to send a PR if you like.

Alright, thanks for the quick reply.
I went with another approach for now, it might help someone.
I added a database connection for each tenant (platform): platform_1, platform_2... I put all the migrations for the platforms in a subfolder. Then I added a custom command migrate-platforms that does the following:
<?php

$connections = collect(config('database.connections'))
    ->filter(function ($value, $key) {
        return preg_match("/platform_\d/", $key) === 1;
    })
    ->keys();

$connections->each(function ($connection) {
    $this->call('migrate', [
        '--path' => 'database/migrations/platform/',
        '--database' => $connection,
    ]);
});


Add 'rosa delete ocm-role' command

The new command follows these steps:

Unlink role if needed.
Detach Attached role policies.
Delete the policies from step 2.
Delete permissions boundary (doesn't delete the policy).
Delete role.

Related: SDA-5202

@zgalor @zvikorn @pvasant @leshemnoa @vkareh PTAL

/lgtm


Add more debug info

This information might extremely helpful, if browser takes some sweet time to get the page or initiated in the grid

I signed it! So happy about this

Your welcome, you lovely thing

This PR is stale, so I'm declaring PR bankruptcy on these older ones and closing it. If this is still an issue for you, we can reopen or you can open a new one. Sorry this went unanswered for so long!


Modal not enabling scroll when close programatically

When I programatically close a modal by using code to set this.state.showModal to false, the component does not re-enable scrolling on the current window.
Note: I am not using clicks or keyboard to trigger the close.
            <Modal
                aria-labelledby="pg-redirect-modal"
                aria-describedby="pg-redirect-modal"
                open={(this.state.showModal) ? true : false}
            >

//Some content here

I noticed that the following CSS parameters are still set:
overflow-x: hidden;
overflow-y: hidden;
MUI Version: 3.6.0

@garygrubb This looks like a regression introduced in v3.6.0. Do you have a reproduction example?

v3.6.1 is out, let us know if it fixes your issue.

@oliviertassinari thanks. It works in 3.6.1


cli: Add --skip-build flag to anchor test resolve #276

This PR adds another flag called --skip-build to the command anchor test to skip the building of Solana program in the workspace. This would save time when working on a large workspace where building would take time.
Previously, if the users would like to alter their tests and run anchor test again, the cli would build everything again. With, --skip-build, tests could be run right away without going through the building of source code again.
Example usage:
anchor test --skip-build

workspace % anchor test --skip-build

  someProgram
    ✓ Should initialize (59397ms)
    ✓ Should pass the test (4472ms)

Awesome thanks for this!


Web3Inbox personal_sign messages are not decoded properly

Describe the bug
Connecting to web3inbox shows an incorrectly decoded messages.
SDK Version

100

To Reproduce
Steps to reproduce the behavior:

Go to web3inbox
Connect wallet
See error

Expected behavior
Messages is human-readable
Screenshots

Additional context
Needs to be base16 decoded
cc @Elyniss

This is now working


Fix kup version of kontrol by building the foundryx target

I tested this with both nix shell and kup shell, works as expected.


get before image not correctly when column is on update current_timestamp

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description
当有字段是DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP，update sql 回滚时，这个字段的时间会被更新为rollback的时间，导致这个值不一致；
Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
Just paste your stack trace here!

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

JDK version :
OS :
Others:

@hecyxy I will find out the cause of the problem.

@hecyxy I will find out the cause of the problem.

thank you

@hecyxy git clone -b develop_update  https://github.com/slievrly/fescar.git

@hecyxy git clone -b develop_update https://github.com/slievrly/fescar.git
please use this branch to make a local package to verify.

the problem has been solved,thanks

Is this the official branch?


ARTEMIS-2645 refactor CLI FQQN support

FQQN support for the CLI was implemented via ARTEMIS-1840 before general
FQQN support was added for producers via ARTEMIS-1867. The CLI's FQQN
functionality is slightly different from what is now generally available
and it can be confusing for users. By refactoring the CLI to use the
general FQQN support the code can be much simpler and consistent with
the expected behavior. Refactoring includes:

Deprecating the use of "fqqn://". The CLI commands use JMS so using
"fqqn://" (instead of "queue://" or "topic://") makes the destination
type ambiguous which can yield unexpected message routing behavior.
Now "queue://" and "topic://" can be used with the normal FQQN syntax
(e.g. address::queue).
Eliminating the use of the _AMQ_ROUTE_TO header when sending messags
to an FQQN. The _AMQ_ROUTE_TO header is an internal header used when
routing messages over a cluster bridge. Using it in the CLI for FQQN
support was a clever hack, but using the general FQQN support
eliminates complexity and makes behavior consistent between
standalone JMS clients using FQQN and the CLI.
De-duplicating MessageSerializer initialization boilerplate.
Removing limitation where using an FQQN with an anycast address
required the same name for the address and queue.

@jbertram I'm getting test failures
Failed tests:
MessageSerializerTest.testTextMessageImportExport:177->checkSentMessages:104->CliTestBase.consumeMessages:147 null
Tests in error:
MessageSerializerTest.testMapMessageImportExport:227 Â» InvalidDestination AMQ2...

@michaelandrepearce, there must be a race condition somewhere. When I run those tests I don't get any failures. I'll continue investigating.

@michaelandrepearce I was able to reproduce the failures and I've sent #3009 to address them.


Different behaviour between insomnia-inso from npm and binary release

Expected Behavior
Generate the same declarative config.
Actual Behavior
When running inso generate the two inso versions create different declarative configs.
Reproduction Steps
Example OpenAPI spec:
openapi: 3.0.0
info:
  version: 1.0.0
  title: Sample-API
servers:
  - url: https://example.com
paths:
  /list:
    get:
      description: Returns a list of stuff
      responses:
        '200':
          description: Successful response

Run inso generate config api-docs.yml -o kong-api-docs.yml with both inso cli types and compare the result.
Is there an existing issue for this?

[x]  I have searched the issue tracker for this problem.

Additional Information
When using hyphens in info.title (here "Sample-API") insomnia-inso from npm keeps the title as service name and the binary release converts every hyphen to underscore.
Insomnia cli version
2.4.1
What operating system are you using?
Linux in Kubernetes
Installation method
Downloaded using curl and installed using npm
Last Known Working Insomnia version
The version from npm is working

I was able to reproduce this.

installed via npm, npm install -g insomnia-inso

downloaded and unzipped macos build

Tried to covert above file with each:

issue4432 $inso generate config api-docs.yml -o via-npm.yml
Configuration generated to "via-npm.yml".
issue4432 $./inso generate config api-docs.yml -o via-download.yml
Configuration generated to "via-download.yml".

Result:
issue4432 $diff via-npm.yml via-download.yml
3c3
<   - name: Sample-API
---
>   - name: Sample_API
13c13
<         name: Sample-API-list-get
---
>         name: Sample_API-list-get
issue4432 $

(Was also able to reproduce with latest alpha build of inso)
cc @wdawson  - not yet sure why it is happening, but we know at least it is reproducible.

Hey @michbeck100 sorry for the wait regarding this issue.
We have identified the problem and prepared a fix (see PR #4657).
The fix should be included in tomorrow's beta release.

Hi @michbeck100, we've launched a new beta today, and from Inso CLI version 2.11.0-beta0 onwards, the behaviour between npm package and release binary should be similar.
Thank you for reporting this, feel free to report any other issues in the future!


Double minus in calc css

Bug Report
There are double minus in css file (--1px)
Steps
Download<EMAIL_ADDRESS>Expected Result
 .ui.attached.steps {
   width: calc(100% + (1px * 2)) !important;
   margin: 0em -1px 0;
   max-width: calc(100% + (1px * 2));
   border-radius: 0.28571429rem 0.28571429rem 0em 0em;
 }

Actual Result
 .ui.attached.steps {
   width: calc(100% + 2px) !important;
   margin: 0em -1px 0;
   max-width: calc(100% + 2px);
   border-radius: 0.28571429rem 0.28571429rem 0em 0em;
 }

Version
2.4.2
There are also some places with double minus like here (--1px)
I really think this is mistake. It it's not, please tell me what does it mean ?

That's due to math changes in LESS >= 3.5 and has been fixed in since Fomantic-UI 2.5 by
https://github.com/fomantic/Fomantic-UI/pull/97


Dev to main sync

Date: 09-1-24
Developer Name: @prakashchoudhary07

PR's going in

#1839
#1742

(Developer)s Name

@prakashchoudhary07
@satyam73

Is Under Feature Flag

[ ] Yes
[x] No

Database changes

[ ] Yes
[x] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

[ ] Yes
[x] No

Is Development Tested?

[x] Yes
[ ] No

Is it tested in staging?

[x] Yes
[ ] No

Add relevant Screenshot below ( e.g test coverage etc. )
https://github.com/Real-Dev-Squad/website-backend/pull/1841#issuecomment-1881758886

Staging proof of #1839

get request to get invite for user

post request if user invite is already present

post request for invitation code

Staging working proof of #1742

Get request with status query param initial connection with data: null

Get request with questionId and status query param initial connection with data: null

Post API /answers

Get api triiger when post api triggers

Unauthorized if user is not super user or member

Succesful patch request when member is true

Succesful patch request when super_user is true

status query with APPROVED value (get request) triggers when there is any update happens with PATCH request /answers

Looks good 👍

1852


pysam supported platforms excludes macOS

(Apologies if this is the wrong place/format for this issue; I'm a Nix newcomer.)
I'm trying to use the Python package pysam on macOS. The package itself lists macOS as a supported platform, and the package seems to work just fine for me on macOS (using NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-shell --impure -p python39Packages.pysam), but the pkgs.python39Packages.pysam derivation lists only Linux as supported. I'd be happy to contribute a patch to change this if someone could help me figure out what needs to happen.

That sounds reasonable to me. The list of supported platforms came from https://github.com/NixOS/nixpkgs/pull/34532, which doesn't mention MacOS, only that the package failed to build on aarch64-linux. I was locally able to build it on aarch64-darwin, so the restriction doesn't seem to be needed for MacOS.
You can open a PR that adds platforms.darwin (which is a list) to the platforms list (in Nix, ++ is the list concatenation operator), following the contributing guide.

per https://github.com/NixOS/nixpkgs/pull/34532#issuecomment-363357113, aarch64-linux failed due to lack of bcftools on aarch64. But nothing is marked as broken in bcftools.
FWIW, I successfully built both bcftools and pysam on aarch64-darwin.
Any volunteers to test it on aarch64-linux?


Having a week break

Hey everyone!
I'm going to NY for a week to celebrate my birthday so expect not to see such intensive support. It's been an amazing week and I love how Riot is evolving and how much help I have received.
I'm also working on a substantial reorganization of code currently trying to fix all those mounting, memory and child/parent- relationship issues.
Thank you @everyone!!

Happy birthday and have a nice trip! :satisfied:

Have a nice week. BTW isn't it the case to create a 'riotjs' github group with more than one admin? This project Is getting quite big to be managed only by one person IMHO.

Happy birthday !

Happy birthday and thanks for your work on Riot.js (it's awesome).

I pushed a major update to dev- branch. Feel free to poke around.
Here the the riotjs group. I'm happy to add members there if someone ambitious comes along!

@tipiirai the link is wrong somehow. Btw I would be happy to help you on the project ;)

Just tried the dev- branch, looks fantastic!
It solves #249 and also the unmount event issues I had in #256.

I just pushed another patch of updates. Unmounting is even more reliable now.

Nice! On the subject of events, try this code:
<works>

Normal element

    <test1 each={arr}></test1>

    this.arr = [];
</works>

<topic>

Custom element

</topic>

<fails>
    <topic></topic>
    <test2 each={arr}></test2>

    this.arr = [];
</fails>

<test1>
    Hi!

    this.on('mount', function(){
        console.log("This one doesn't run, which is as intended.")
    });
</test1>

<test2>
    Hi!

    this.on('mount', function(){
        console.log("This shoudn't run, but does so anyway.")
    });
</test2>

http://jsfiddle.net/9yd72rtj/14/
I seem to get extra mount events when I have custom tags with the each attribute, unless it's the first custom tag.

@luffs do you still experience the issue with the latest v2.0.8. If so, can you post a new issue – pretty please.
I'm closing this one since I'm back to work!


No need to verify obs studio version?

Since im using obs studio 28.0, i encountered connection error caused by obs version verification.
Actually it seems no need to verify obs studio version, I've tried commenting out the related codes (src/client/mod.rs line 333), and it runs well.
I believe it's okay to remove the obs version verification and retain the verification for the websocket version and rpc version, as they really matter.

This is not really a requirement for obws, but rather for the obs-websocket plugin. It is tightly tied to the version of OBS and nowadays even shipped together with it.
They require a certain version of OBS to work, so if you have the latest version of obs-websocket combined with an older OBS it may work but is likely to fail at some point.
So for obws it's rather a safety feature to avoid potentially problematic setups, which have caused many issue reports on the obs-websocket issue tracker in the past so I wanted to avoid similar things here.


create updated SDK and pwoerShell for Microsoft.OperationalInsights [FEATURE REQ]

Library or service name. : Microsoft.OperationalInsights
What library or service is this request related to? [e.g. Azure.Storage.Blobs]
Is your feature request related to a problem? Please describe.
What feature would you like to get added? What problem is it solving?
we recently released a new version: 2020-10-01 and require a new SDK and PowerShell update

Thank you for your feedback.  Tagging and routing to the team best able to assist.

Thank you for your feedback.  Tagging and routing to the team best able to assist.

@dabenhamMic could you share a bit more information about this? What version did you release? And what would you need help with?
/cc @pakrym

@dabenhamMic could you share a bit more information about this? What version did you release? And what would you need help with?
/cc @pakrym

@AlexGhiondea
we have updated 2 main flows: the first is DedicattedClusters and the other is our Table api's.
we have extended the Table contract.
Cluster is a new feature that is becoming GA.

@AlexGhiondea
we have updated 2 main flows: the first is DedicattedClusters and the other is our Table api's.
we have extended the Table contract.
Cluster is a new feature that is becoming GA.

@dabenhamMic thanks for that additional information. Unfortunately I am still not sure what is it that you are asking for 🙁. Are you asking for help releasing a new version of the SDK as the service maintainer or are you asking for help figuring out who the service owner is so that they can release a new version of the SDK?

@dabenhamMic thanks for that additional information. Unfortunately I am still not sure what is it that you are asking for 🙁. Are you asking for help releasing a new version of the SDK as the service maintainer or are you asking for help figuring out who the service owner is so that they can release a new version of the SDK?

@AlexGhiondea
I'm asking for help releasing a new version of the SDK :)

@AlexGhiondea
I'm asking for help releasing a new version of the SDK :)

@dabenhamMic got it! Please reach out to me on teams! 🙂

@dabenhamMic got it! Please reach out to me on teams! 🙂

The Microsoft.Azure.OperationalInsights package you're referring to was replaced by Azure.Monitor.Query. Azure.Monitor.Query is based on the latest stable Swagger file. As for the PowerShell work, that's being tracked at https://github.com/Azure/azure-powershell/issues/16787.


Check for scrollview before scrolling

Fixes crash reported today on tabs

#trivial

Fails

:no_entry_sign:
Missing Test Files:

src/lib/Components/__tests__/ScrollableTabBar-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

Warnings

:warning:
Missing Test Files:

src/lib/Components/__tests__/ScrollableTabBar-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

Thanks!
#MergeOnGreen

Btw, this is missing a ticket link and/or to the notion card.


create splashscreen based on icon

can we create a splash screen only based on an icon?
the idea is to center the icon and let the background to be white or other color

Hello, we just revamped the generator 😁
For up to date icon and splashscreen generation please use @bam.tech/react-native-make
The new version is offers 3 ways to handle splashscreen image positioning so it should solve your issue 😉


error in admin model actions

there is an error in when i use with django model actions , it return
 File ".... python3.11/site-packages/import_export/admin.py", line 566, in ExportActionMixin     actions = admin.ModelAdmin.actions + [export_admin_action]               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ TypeError: can only concatenate tuple (not "list") to tuple
and it happen when i use any admin mixin or even if only import anything from admin.py
django version : 4.2.7
django-import-export version : 2.5.0

i am sorry i was using an old version , and it had been fixed in the newer versions


double-beep: Blacklist janbasktraining.com

double-beep requests the blacklist of the website janbasktraining\.com. See the MS search here and the Stack Exchange search here.

janbasktraining\.com has been seen in 6 true positives, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


PSQL Support

Have resolved most. Didn't understand this correctly and left it as such for now.
https://github.com/PumpkinSeed/sqlfuzz/pull/13#discussion_r588178806

@borosr If you can do another round that would be nice.


Add MySQL App

This PR proposes a new --app for invoking the mysql CLI.
Example: terminus pc site.env --app mysql.
I'm not enthusiastic about using proc_open, but I wasn't sure what a good alternative would be for having Terminus handoff control to another cli process.
Thank you in advance for feedback!

Looks good, this is probably useful to some people who can't use drush. For validate can you use which instead?  (I just fixed it on master today so you prob should merge master back in, https://github.com/terminus-plugin-project/terminus-pancakes/pull/18/commits/e40aeaabefddbaaaf93a9343f9252c268af2e225)
Drush uses proc_open as well, it prob is the best way to do it.

@derimagia I updated the PR using $this->which (hope I did it right!) and rebased off master.
I appreciate the feedback (and the plugin)!

Can you put the commit on the your PR branch?

I fixedup the changes back into the original commit and pushed just that back into the branch.

My bad, I see you replaced the commit. Looks good to me, thanks!

Thank you!


Sort feature bug

When trying to reorder films via the re-order feature they move ok but when you go to save the screen twitches for a lack of a better description and the icon to save stays in place rather than saving the change.
Console log
mrTracker.TrackerPage.handleReorder:: starting mrTracker.TrackerPage.handleReorder:: finishing mrTracker.TrackerPage.handleReorder:: starting mrTracker.TrackerPage.handleReorder:: finishing mrTracker.TrackerPage.handleReorder:: starting mrTracker.TrackerPage.handleReorder:: finishing mrTracker.TrackerPage.toggleReorder:: starting mrTracker.TrackerPage.toggleReorder:: setting to false mrTracker.TrackerPage.toggleReorder:: saving changes mrTracker.StorageService.setEntry:: starting mrTracker.StorageService.setEntry:: passed in parameters key: trackerList, value:  (6) [{…}, {…}, {…}, {…}, {…}, {…}] mrTracker.TrackerPage.toggleReorder:: finishing mrTracker.StorageService.setEntry:: item saved for key trackerList mrTracker.StorageService.setEntry:: finishing N {__zone_symbol__state: null, __zone_symbol__value: Array(0)}__zone_symbol__state: true__zone_symbol__value: (6) [{…}, {…}, {…}, {…}, {…}, {…}]Symbol(Symbol.species): (...)Symbol(Symbol.toStringTag): (...)[[Prototype]]: Object mrTracker.TrackerPage.trackerList:: starting mrTracker.TrackerPage.trackerList:: trackerlist reset mrTracker.TrackerPage.trackerList:: finishing

after looking into the code I found that there both an issue with setting up the storage item for the list and when the reorder is saved it wasn't resetting the ui properly.
The storage was set up with only having one item initially but when the cex list was added and local storage was used to store that later the creating a fresh list was failings as there was no step to handle a storage setup with more than one item that wasnt the tracking list. Once this was handled both adding and re-order became more stable, then few locations that utilised the previous tracking list flow were updated. Once this was refactored, the reorder toggle flow was updated to create a toast on success as well as failure and revert the ui in both cases, leaving the list alone in the case of success.
Once this was checked test case updated to reflect new flows.

merged

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Manually walk to make normalizeSlashes a no-op

Experimental alternative to #44100.

@typescript-bot perf test this

I could probably rewrite this in terms of indexOf like described by @rbuckton, I didn't see that comment. It might be faster.

The suggestion I made in #44100 avoids an array allocation.

The suggestion I made in #44100 avoids an array allocation.

Isn't https://github.com/microsoft/TypeScript/pull/44100#issuecomment-841575001 potentially creating several intermediate "result" arrays on every iteration of the loop? Seems like it could go either way.

I guess I could technically just use one array.

@typescript-bot perf test this

@typescript-bot perf test this

@typescript-bot perf test this

@typescript-bot perf test this

Single run of large project load in node12 on linux:
indexOf
Type: wall
Time: May 18, 2021 at 1:29pm (PDT)
Duration: 38.46s, Total samples = 35755ms (92.98%)
Active filters:
   show=norm
Showing nodes accounting for 31856ms, 89.10% of 35755ms total
Dropped 5 nodes (cum <= 178.78ms)
      flat  flat%   sum%        cum   cum%
   26995ms 75.50% 75.50%    31881ms 89.17%  Interface._normalWrite readline.js:434
    4372ms 12.23% 87.73%     4556ms 12.74%  normalizePath /home/acasey/repos/ts_gh/built/local/tsserver.js:6028
     489ms  1.37% 89.10%      489ms  1.37%  normalizeSlashes /home/acasey/repos/ts_gh/built/local/tsserver.js:5917

This PR
Type: wall
Time: May 18, 2021 at 2:03pm (PDT)
Duration: 48.08s, Total samples = 44.53s (92.60%)
Active filters:
   show=norm
Showing nodes accounting for 40.63s, 91.26% of 44.53s total
Dropped 3 nodes (cum <= 0.22s)
      flat  flat%   sum%        cum   cum%
    30.98s 69.58% 69.58%     40.66s 91.32%  Interface._normalWrite readline.js:434
     5.55s 12.47% 82.05%      7.35s 16.50%  normalizePath /home/acasey/repos/ts_gh/built/local/tsserver.js:6021
     4.10s  9.21% 91.26%      4.10s  9.21%  normalizeSlashes /home/acasey/repos/ts_gh/built/local/tsserver.js:5899

The baseline includes other local changes, but was the same for both.


WIP - Adds sqlite storage

Which problem is this PR solving?

Adds an SQLite storage backend for traces thereby providing an alternative to badger. I realise Jaeger already has a solution for local storage using badger so understand if this contribution isn't welcome.

Short description of the changes

The PR adds a new storage backend using SQLite.

I was hoping I'd be able to tag this WIP until I add support for dependencies but it seems I can't use any tags. Please feel free to review but understand this isn't yet complete.

Can you elaborate why you want it? Pros/Cons?

Can you elaborate why you want it? Pros/Cons?

While trying out badger I was underwhelmed with its performance and thought it would be interesting to write an alternative backend to benchmark against. Having done that I could see no reason not to share it.
This could also be moved to a separate project as a gRPC plugin but that would defeat the whole purpose of SQLite which is to embed it with the program that uses it.
The cons are that it requires CGO so full integration would mean tweaking some of the makefiles and getting around possible issues w/ Alpine/musl.

I wonder what was your issue with the badger performance? On my machine I can write around ~30 000 spans / s to disk which far exceeds the capabilities of what my other parts of Jaeger can do.
Although I do notice that your PR does not actually store to the disk:
if _, err := db.Exec("PRAGMA journal_mode = MEMORY;", nil); err != nil {

So there's reduced integrity - the badger instance will store it to the disk always (even if application crashes, the WriteSync option will only reduce the amount of fsyncs to the physical disk). Are you testing the same things here?

I wonder what was your issue with the badger performance? On my machine I can write around ~30 000 spans / s to disk which far exceeds the capabilities of what my other parts of Jaeger can do.

I wonder if those are example spans or representative of production workloads with tags, logs, etc?

Although I do notice that your PR does not actually store to the disk:

That option controls where the transaction journal is kept, not the actual data. The actual value for the option should be user provided according to how they assess the risk/benefit.
To be clear, the current options are for benchmarking purposes and do persist to disk.

From sqlite3 documentation: The MEMORY journaling mode stores the rollback journal in volatile RAM, now journaling log / WAL / transaction log is the key to the integrity of a SQL database. The tables in the disk are not written after every write (as they need to be rebuit) but instead only during the checkpointing. I don't see SQLite doing this process any differently.
It's easy to check. Keep writing data, kill the process and reload. If you don't have all the transactions, you never wrote them to the disk. And this is what happens. It's great for benchmarketing purposes, sure, but only to replace in-memory storage. The WAL is a bottleneck for many DBs as those operations need to be acked from the disk interface before they can be acked back to the client. And they're raced by all the concurrent writers.
But, that aside, looking at the implementation - I noticed you don't write all the data to the SQLite. So the original span is not written anywhere? I guess you could rely on just the tables to rebuild them, but in that case you need to write all the fields (some are missing now). Logs need indexing (and storing) also, as well as duration (unless you sacrifice reading performance for write performance). Also "index spans by service_name, operation_name, start_time" is missing start_time in the actual index.
And yes, the amount of indexed tags plays a big role in badger (each one is a new write). So with 128 unique tags values per span I get 3k/s with large amount of time spent in the kernel processes. Although, none of this actually stresses my machine so there's clearly a bottleneck in some serial process, disk or something else.

I had mentioned this earlier, but the WAL mode and journal modes should be provided by the client when the PR is complete. I believe it's up to them to be the judges of risk/benefit of each combination for their use case. This, of course, means exposing the options and documenting them, which I have not done yet.

But, that aside, looking at the implementation - I noticed you don't write all the data to the SQLite. So the original span is not written anywhere?
I'm not sure I understand, the spans are stored and I can query and see them in the UI. Do you mean actually marshalling the model.Span struct and store it in some field in the db for faster recreation at query time?

you need to write all the fields (some are missing now).
This is why I tagged the PR "WIP". At the moment, as you mentioned, durations aren't indexed and logs aren't stored. They don't need indexing as there's no way of querying for them.

Also "index spans by service_name, operation_name, start_time" is missing start_time in the actual index.
Good catch, thanks!

By the way, this isn't obvious and I should have mentioned it before.

I'm not claiming this backend is faster than badger. I am writing it to benchmark against badger and submitted the PR in case someone is interested.
The choice of wal mode and synchronous mode should be exposed to the end user as they will be better informed about which makes more sense to their use case.
The benchmarks journal in memory but do persist to disk. Losing the journal during a restart is not something I consider an issue. Losing some spans or traces should be statistically insignificant and would happen anyway during a restart of an all-in-one deployment.

Closing due to inactivity.


fix OpenSearchClient import

Describe your changes:
Fixes

I worked on  fix OpenSearchClient import

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani do we have cypress tests for the glossary listing while adding to a entity?
This should've been caught in our tests no?


Add horizontalRatio, verticalRatio, and run query parameters

We may need to add query parameters supported by the old version of embed-dart and embed-inline.

horizontalRatio
verticalRatio
run
console (ref)

we may not need horizontalRatio and verticalRatio since we have the split option.

@johnpryan  What does "run" mean here?

In the original version, it immediately executes the code instead of waiting for the run button to be clicked

Moving to September milestone as a carryover


Camera access permission

Is there a way to give my android app camera access permission?
Like mWebView.setGeolocationEnabled(true) for location permission, is there anything like it to allow the camera access?

Thanks for your question!
It's actually not as easy as with the geolocation, unfortunately. But there are still ways to do it:
First, there's HTML5 media capture. Adding this to your WebView is possible, but requires some work. You can read more about that here:

https://github.com/delight-im/Android-AdvancedWebView/issues/10
https://developer.mozilla.org/en-US/docs/Web/Guide/API/Camera

Apart from that, there's a newer API called navigator.getUserMedia() in JavaScript. But this API is not supported before Android 5.0 -- and even then, it's only supported with the "webkit" prefix. You can read more about that API here:

http://www.html5rocks.com/en/tutorials/getusermedia/intro/
http://davidwalsh.name/browser-camera
http://caniuse.com/#feat=stream

Hope that helps!

Manage to make it work!
Once you have your camera capture working in webbrowser, to grant the camera permission:
public void iniciaWebView(){
    mWebView = (AdvancedWebView) findViewById(R.id.webview);
    mWebView.setListener(this, this);
    mWebView.setGeolocationEnabled(true);
    mWebView.addHttpHeader("X-Requested-With", appNomeLogs);

    mWebView.setWebChromeClient(new WebChromeClient() {
    	@Override
        public void onPermissionRequest(final PermissionRequest request) {
    		Log.i(appNomeLogs, "|> onPermissionRequest");

    		MainActivity.this.runOnUiThread(new Runnable(){
    			@TargetApi(Build.VERSION_CODES.LOLLIPOP)
                @Override
                public void run() {
    				Log.i(appNomeLogs, "|> onPermissionRequest run");
    				request.grant(request.getResources());
                }// run
            });// MainActivity

    	}// onPermissionRequest
    });// setWebChromeClient

    mWebView.loadUrl(url);
}// iniciaWebView

Only tested in android 5 so far.

obs: not forgeting the manifest
<uses-permission android:name="android.permission.CAMERA" />
<uses-permission android:name="android.permission.CAPTURE_VIDEO_OUTPUT" />

Thanks for sharing! Great that it worked for you :)
But getting this to work on Android 4.0+ as well and saving the captured image on the file system probably requires some more work, right?

@moirrer Looking at your code it looks like this will auto-accept all permissions requested. When you allow external websites in your webview you don't have control off, I think you don't want this without the users permission.

@RoelRoel That is correct.  But even then, you have to pay attention because external links might lead to external sites again.

For what it's worth, I ended up using parts of https://github.com/mgks/Os-FileUp to get it working.


chore(openchallenges): add all public Grand Challenges

Changelog

[x] #2351
[x] #2357
[ ] #2360

@vpchung I opened this PR so I can't technically review it. I did test the PR locally and it looks good to me. Couple of notes:

Most GC challenges don't have start and/or end date as discussed on Slack
The challenge logo comes from GC website. This comes with some limitations:

The image may much larger than needed and take time to load. Meanwhile, the logo will appear white with the alternative text (see screenshot)
The image may not be square. The OC style displays the image with an 1:1 aspect ratio, in which case the image would appear distorted.

Thanks, @tschaffter . I know this isn't what you intended to catch, but your screenshot for the CAMEO challenge (not GC as stated) was a bug in the curation.  This will be fixed with #2360 .
Re: the other image links, should we ignore the image links from GC until a solution for outside avatar links is handled?

Re: the other image links, should we ignore the image links from GC until a solution for outside avatar links is handled?

Let's keep the images to bring more colors to OC.
The "loading glitch" is a minor issue that we can fix in one of the next releases. Based on a random sampling of the GC challenges, most of the logos have a 1:1 aspect ratio and look fine on the challenge profile page.

Let's keep the images to bring more colors to OC.

You know, I never actually checked whether the logos were displayed.  This is awesome!!

@vpchung Checkout this one: http://localhost:8000/challenge/376


Q: How easy would it be to use this to use NVidia Tensorrt from C#?

Hi, this project looks really interesting. 👍 I want to use Tensorrt from c#, but as is unfortunately often the case there is no C API so simple p/invoke is not an option. How easy do you think it would be to wrap this using this project? For Windows.

Thanks for the interest! 💜
Short version: I think it should be pretty easy! Honestly the biggest problem if you were to do this yourself would probably be the lack of documentation.

I've never used TensorRT before (I'm not much of an machine learning guy), but looking through the API suggests this library would be trivial for Biohazrd to translate.
I have a (yet-to-be-published) tool that automatically assesses how compatible a given library is with Biohazrd, and it had a favorable outlook. (If you want to look at the report, I've uploaded it here)
To summarize the results:

Use of std::vector

nvonnxparser::IParser::supportsModel - In theory translating std::vector is possible, but it is not something that appears on the public API surface on any of the libraries me or my main sponsor are focused on.

You may have noticed NvOnnxParser.h was skipped. This is because parsing this file is blocked by an external issue https://github.com/microsoft/STL/issues/1300 -- I haven't had a chance to explore workarounds to this issue since it hasn't seriously affected me yet.
Note that this means the entire NvOnnxParser.h file could not be processed in Biohazrd as-is. You'd either have to figure out a good solution to that issue or modify it to avoid intrin.h getting included. Not the worst thing ever, but I thought I should mention it.

C++ templates

EnumMax<T> - Not of concern - This is a C++ template shenanigan to get the max value of an enum. If this were needed I'd just recommend special-casing its translation.
PluginRegistrar<T> - Not of concern - This is (another) template shenanigan to automatically register plugins when a library is loaded. If you implemented a plugin from C# you'd need to use a different strategy to register it.

Global variable/constant -- In general none of these are of great concern. In TensorRT these are all constants, which are tracked by #5. After #75 this is pretty viable, although none of these appear to be critical for using the library.

NV_TENSORRT_VERSION
MAX_DIMS - Biohazrd translates constant arrays with a Length constant field, so this constant isn't really necessary.
kFORMAT_COMBINATION_LIMIT -- This one may matter, but it could be hard-coded or special-cased for the time being.

I did not check anything in the `plugin directory since I am under the impression that these APIs are not meant to be used directly. If this assessment is incorrect let me know and I can look over them too. (Although at a glance they look like they'd require me to install the CUDA SDK.)

Outside of that, this stood out to me:

It is designed to work in a complementary fashion with training frameworks such as TensorFlow, Caffe, PyTorch, MXNet, etc.

Does TensorRT rely on one of these technologies in order to be useful? Would bindings for one of these need to be made for .NET too or do such bindings already exist? (Assuming there aren't already .NET equivalents to any of those.)

For my own reference (because NVIDIA loves to bury this stuff), here's the TensorRT API reference: https://docs.nvidia.com/deeplearning/tensorrt/api/c_api/index.html

For Windows.

I will note that currently only Windows x64 is supported. Linux x64 is currently planned/sponsored, but everything else is mostly up in the air. (Linux ARM64 is on the very distant roadmap. Anything else would likely require sponsorship.)
Some libraries generated by Biohazrd only support .NET 5 due to the use of C#9 function pointers, and TensorRT would be one of them.
In theory supporting older .NET versions is possible, but I'm not particularly keen on supporting them without a strong incentive. Biohazrd is extensible enough that you could probably add legacy UnmanagedFunctionPointer support yourself, but it might not be pretty.

@PathogenDavid thank you very much for the very detailed and thoughtful reply. My apologies for my tardiness. :) This sounds great. Some answers and comments below.
You can see examples of usage in e.g.:
https://github.com/NVIDIA/TensorRT/blob/master/samples/opensource/sampleOnnxMNIST/sampleOnnxMNIST.cpp

nvonnxparser::IParser::supportsModel -

This shouldn't be needed I think.

the entire NvOnnxParser.h file could not be processed in Biohazrd as-is

Good to mention this. Since I need to use this given my models are in ONNX format, it is unfortunately a requirement.

PluginRegistrar - Not of concern
If you implemented a plugin from C# you'd need to use a different strategy to register it.

Don't need to do that. But need to load/use the nvinfer_plugin.dll plugin, not sure this is impacted by this issue.

Global variable/constant

Shouldn't be a problem.

It is designed to work in a complementary fashion with training frameworks such as TensorFlow, Caffe, PyTorch, MXNet, etc.
Does TensorRT rely on one of these technologies in order to be useful? Would bindings for one of these need to be made for .NET too or do such bindings already exist? (Assuming there aren't already .NET equivalents to any of those.)

No not at all, TensorRT is useful in it self. I prefer using it via https://github.com/microsoft/onnxruntime but this does not support all the use cases via that. TensorRT is mainly for running "inference" of models, that is after training. It usually provides big performance improvements compared to running inference based using standard CUDA.

currently only Windows x64 is supported

TensorRT only supports x64 anyway 😅 So no problem.

Would bindings for one of these need to be made for .NET too or do such bindings already exist?

Bindings to more ML libraries and frameworks for .NET would be great overall! This is lacking a lot for .NET. For some reason a lot of these libraries have bindings to python and this without a C API and apparently this is easier to do for some reason. I don't know why that is the case? If there was a C API everything would be easier, but a lot of ML libraries don't have that. Luckily, ONNX Runtime does, though.

Some libraries generated by Biohazrd only support .NET 5 due to the use of C#9 function pointers, and TensorRT would be one of them.

Yes, that I expected, but function pointers are more a C# 9 thing that a specific .NET 5 thing I think. If you wrap these with normal calls this should be .NET Standard 2.0 compatible I think. But this can be addressed after.
Do you think it is possible to progress based on this? Could I do or help with something here to try to go forward with this and explore this? :)

@PathogenDavid I found it interesting the code contains SWIG stuff, so perhaps one can wrap this using SWIG and perhaps that is how python interops with the library...
#ifdef SWIG
inline IParser* createParser(nvinfer1::INetworkDefinition* network,
                             nvinfer1::ILogger* logger)
{
    return static_cast<IParser*>(
        createNvOnnxParser_INTERNAL(network, logger, NV_ONNX_PARSER_VERSION));
}
#endif // SWIG

https://github.com/NVIDIA/TensorRT/blob/492878b2df3c9bf19a26c2b66cba129f450475bc/include/NvOnnxParser.h#L237-L244

It's only defined once so not sure that is true... https://github.com/NVIDIA/TensorRT/search?q=SWIG

thank you very much for the very detailed and thoughtful reply. My apologies for my tardiness. :)

No problem!

Good to mention this. Since I need to use this given my models are in ONNX format, it is unfortunately a requirement.

Well the good news is a Microsoft engineer gave me their fix for the issue blocking this file. Since that fix won't land in Visual Studio until 16.9 (2019 current is 16.7 so 16.9 is probably the 2021 Q1) I'm going to investigate working around this issue from Biohazrd's end until their fix is released.
If you want to work on TensorRT before I develop that fix, you can work around the issue using this slightly modified NvOnnxParser.h. (Note that Biohazrd will happily generate an unusable nvonnxparser::IParser::supportsModel with this workaround, so don't try calling it. The method has to stay there in order to keep the vTable layout the same.)

Don't need to do that. But need to load/use the nvinfer_plugin.dll plugin, not sure this is impacted by this issue.

Nope, that won't be affected.

No not at all, TensorRT is useful in it self. I prefer using it via https://github.com/microsoft/onnxruntime but this does not support all the use cases via that. TensorRT is mainly for running "inference" of models, that is after training. It usually provides big performance improvements compared to running inference based using standard CUDA.

Cool, just wanted to make sure since I'm not a machine learning guy. I didn't want to tell you TesnorRT would work when some obvious-to-ML-people dependency was also implied by the question.

TensorRT only supports x64 anyway 😅 So no problem.

Bindings to more ML libraries and frameworks for .NET would be great overall! This is lacking a lot for .NET.

Biohazrd may definitely be the answer there!

For some reason a lot of these libraries have bindings to python and this without a C API and apparently this is easier to do for some reason. I don't know why that is the case?

I don't think it's that it's necessarily easier to do. It's more a lot of academic types like Python and machine learning is still in that stage where the main users are academic types.
There's basically three ways to do interop to C/C++ from non-C/C++ languages:

Have the language support C headers and linking. (From my limited understanding, Swift works this way)
Have the language support redefining the functions and structs in that language. (.NET, Python, Rust, Beef)
Manually implement language bindings in C/C++ using support from the runtime. (Basically you write (Python, Java)

(.NET doesn't really have 3, but one could argue FCall functions is kinda similar. They only exist to support the runtime though.)
Option 3 is pretty labor-intensive, but it means C++ developers get to keep writing C++ and it doesn't require a C layer. The Python parts of TensorRT are closed-source, but if you poke at things this is what they're using.

I found it interesting the code contains SWIG stuff, so perhaps one can wrap this using SWIG and perhaps that is how python interops with the library...

(Answering this out of order, but...) It would not surprise me if the SWIG strategy for Python involves generating a native library as mentioned above. That brief mention of it does suggest that could be what they're using for the Python bindings.
SWIG does support C#, but personally I wasn't too impressed with the codegen or the strategies it uses. If I thought SWIG was a good binding generator I probably wouldn't have been working on Biohazrd for so long 🤡

If there was a C API everything would be easier, but a lot of ML libraries don't have that. Luckily, ONNX Runtime does, though.

The biggest issue with making C APIs for C++ libraries is you can't really surface anything besides POD structs on the API. (You can try, but compilers will warn you this is a bad idea and you may or may not run into issues.) At best this constrains how the C++ side of the library is written at worst it requires maintaining a much thicker C API layer and in some cases hurts performance.

but function pointers are more a C# 9 thing that a specific .NET 5 thing I think. If you wrap these with normal calls this should be .NET Standard 2.0 compatible I think.

True, but officially this isn't a supported scenario as far as .NET is concerned. If I remember right, getting function pointers to managed functions was something that required some degree of runtime support. Biohazrd doesn't need this out of the box, but there's reasons you might want to in your library.
Downlevel .NET is not a priority for me or my sponsor, but if someone does try to use a Biohazrd-generated library in downlevel .NET I'd definitely be interested to hear how it went.

Do you think it is possible to progress based on this? Could I do or help with something here to try to go forward with this and explore this? :)

Definitely! Things are still a little rough (for example I don't have NuGet packages yet and there's basically no documentation), but if you're brave you can try to make a generator based off of InfectedImGui or InfectedPhysX. It'd be helpful for me to get feedback from someone else trying to use the library since all of my feedback thus far has been people reading example code I've sent them. I'd be willing to get on Discord or Teams to answer questions you might run into as you go along.
If you aren't feeling quite so brave and you aren't in a rush, I could probably find some time soon to get a basic generator going for TensorRT. (I don't mind doing it since the library has such a simple API, but I'm definitely interested in hearing your feedback.)

SWIG does support C#, but personally I wasn't too impressed with the codegen or the strategies it uses. If I thought SWIG was a good binding generator I probably wouldn't have been working on Biohazrd for so long

I agree on that. We use CNTK via SWIG generated bindings and there are not exactly optimal in all cases. It works, though. So had thought about using SWIG for Tensorrt too. But SWIG depends on generating a C API in a new library/dll which is annoying, hence why I thought of Biohazrd. 👍

Downlevel .NET is not a priority for me or my sponsor, but if someone does try to use a Biohazrd-generated library in downlevel .NET I'd definitely be interested to hear how it went.

No problem, we will see 👍

aren't in a rush, I could probably find some time soon to get a basic generator going for TensorRT. (I don't mind doing it since the library has such a simple API, but I'm definitely interested in hearing your feedback.)

I'm not in a rush so this sounds great! And I also thought with this simple API it might be good example/use case. Please do not hesitate to contact me if there is anything at all. Thanks!

I'm not in a rush so this sounds great!

Turns out this plan might've been for the best. I ended up finding a few missing features in Biohazrd that were pretty easy for me to solve, but I would've felt guilty if you had run into them. So in the end it turned out to be a good exercise of Biohazrd regardless.
I've gotten the generator done, and I've ported the MNIST sample as well as the necessary portions of the common sample code.
The only real unexpected roadblock was the fact that Biohazrd doesn't support namespaces yet. (Things can be in namespaces, but it translates everything into a global namespace.) This hasn't been an issue with PhysX or Dear ImGui, but TensorRT has conflicts between its own namespaces. (For example nvinfer1::IPluginFactory and nvcaffeeparser1::IPluginFactory.) In theory it was still usable because Biohazrd auto-renamed them to IPluginFactory_0 and IPluginFactory_1, but that's obviously not very usable. I hacked together good enough namespace support specifically for TensorRT, but a proper solution (which was already on my mental roadmap) will still be necessary. (The API looks OK, but the codegen and the way it works at generation time is pretty gross.)
I'm currently investigating a crash in the sample that is caused because IConstantLayer has no input tensors for some reason. (Native equivalent location) I wanted to run the NVIDIA C++ sample in the debugger and compare values, but for whatever reason the debugger wasn't working with the sample and I didn't have time to investigate yet.
I've given you access to the WIP repository (You have to accept access, check your email.) If you have some time I'd definitely appreciate it if you could look over the ported sample code and see if something sticks out. I'm pretty sure there's just a typo somewhere that I'm not noticing, so another set of eyes would probably help. (Unfortunately this part of the code somehow ended up with almost all of the BIOQUIRK notes, so it's a little rough.) Plus I'm definitely out of my element here, I'm not even sure what would indicate how many inputs or outputs the IConstantLayer should have. There's some rough instructions in the readme on setting things up to run the sample.
Off the top of my head, here's the main tasks left:

[ ] Fix the sample
[ ] Implement a workaround for https://github.com/microsoft/STL/issues/1300 so that we can use NvOnnxParser.h
[ ] Implement one of the samples that uses the Onnx parser.
[ ] (Maybe) Implement https://github.com/InfectedLibraries/Biohazrd/issues/30 since some of the API is annoying to use without it.
[ ] Cleaning up the readme and clarifying the license of the sample code.

The MNIST sample is almost entirely a mechanical translation of the C++ sample, so minimal effort went into C#ifying it. I put a bit more effort into C#ifying the common sample code, but for the most part it's the same.

I've gotten the generator done, and I've ported the MNIST sample as well as the necessary portions of the common sample code.

Awesome! :) Since the example isn't the onnx sample I referred to, things are a bit different that what I am used. onnx file contains both network and weights in the same file making it easier.

caused because IConstantLayer has no input tensors for some reason.

Haven't seen this before, and just to be clear I don't have a lot of experience using the raw Tensorrt API myself, sorry. Mainly used in via ONNX Runtime or the trtexec tool, which can also be used to verify things work on a certain file for example. I could think this might relate to how weights and the mean stuff and network are mapped together. The onnx example doesn't have this rather esoteric bit in it, so think it would be easier to get that working once NvOnnxParser can be used.
Overall, what I find it great is that it appears all the config options are available which is the primary driver for my interest in this. In ONNX Runtime one can't define this on your own, it uses a single optimization parameter instead but that means certain things can't be configured. The trtexec allows one to play around with that.
I haven't had time to look into this in detail, unfortunately. I, of course, can see, as you already noted, that this is very raw with no C#'ification around life time management etc. But it looks promising to me. NvOnnxParser is missing of course, I think that would be the no. 1 priority for me and I believe if we get this the example will be easier to get working given the sample code is simpler for that :)

Awesome! :) Since the example isn't the onnx sample I referred to, things are a bit different that what I am used. onnx file contains both network and weights in the same file making it easier.

Yeah, I wanted to start with this sample since NVIDIA seems to present it as the Hello World of the library. That sample will come next.

Haven't seen this before, and just to be clear I don't have a lot of experience using the raw Tensorrt API myself, sorry.

No worries. I have basically zero practical experience with machine learning, so I have no idea how portable the terminology is.

I haven't had time to look into this in detail, unfortunately.

No problem, I just wanted to give you an update. If you find some time to help debug the sample I'd of course appreciate it. (I know you only care about the ONNX bits, but want to be sure the sample is broken because of an error I made while re-writing it and not because of an error within Biohazrd.)

I, of course, can see, as you already noted, that this is very raw with no C#'ification around life time management etc.

Yup. Also I feel like I didn't make it super clear earlier: The are plans for how Biohazrd will be able to help* you wrap libraries in a safer manner, but it currently doesn't provide much support out of the box. (Right now the focus is on the unsafe interop layer.) You can of course implement the safe layer yourself (or even use Biohazrd to generate it in your own style), but I'm still shaping how Biohazrd "recommends" (and helps) you do this.
(*Part of the reason this I use the word "help" here is I don't believe there's a one size fits all approach for wrapping native interop. For example, an approach that works well for TensorRT wouldn't work well for PhysX.)

@nietras
I developed a workaround for the intrin0.h issue (https://github.com/InfectedLibraries/Biohazrd/issues/98) and ported the ONNX MNIST sample and it works!

Changes are live on the private InfectedTensorRT repo if you want to check them out. I haven't had time to look at the non-ONNX sample again to figure out why it's broken.


Update AppAuthentication Package to point people to Azure.Identity

Tracking
Problem
It's not clear to customers searching nuget.org for Azure Identity if they should use AppAuthentication or Azure.Identity
Details
https://twitter.com/mderriey/status/1281708180225921024?s=20

It seems that Azure.Identity and Microsoft.Azure.Services.AppAuthentication serve the same purpose, and are both actively worked on.
Is there guidance as to which one should be used going forward? #azure #dotnetcore

The AppAuthentication nuget package points to https://docs.microsoft.com/en-us/azure/key-vault/general/service-to-service-authentication, which gives customers a warning

Which points here: https://docs.microsoft.com/en-us/azure/key-vault/general/authentication
Which has Azure.Identity mentioned at the bottom of the page.
If customers read all of this, then they can end up correctly using Azure.Identity.  But many people won't follow this rabbit hole all the way down.
Proposal
Mark AppAuthentication deprecated and update the .nuspec file to include a new description which links directly to the Azure.Identity nuget package.

We are moving out marking the AppAuthentication deprecated this until we have ARM libraries which support authenticating with Azure.Identity.

Given AppAuthentication package has been deprecated can this be closed? @scottaddie , @schaabs


GEODE-7596 - Use ASF repo:status token sparingly.

For polling GitHub for PRs, don't waste ASF rate-limitted API calls.

Use apachegeode-ci account for all queries.
Use asf-ci account for all status-sets.

Co-authored-by: Robert Houghton<EMAIL_ADDRESS>Co-authored-by: Scott Jewell<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[X] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[X] Is your initial contribution a single, squashed commit?

[X] Does gradlew build run cleanly?

[n/a] Have you written or updated unit tests to verify your changes?

[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

The path parameter
On Wed, Dec 18, 2019, 12:24 Owen Nichols<EMAIL_ADDRESS>wrote:

@onichols-pivotal commented on this pull request.
How do we know we’re PUTting status on the same version that we built
against, now that they are two separate resources?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/geode/pull/4501?email_source=notifications&email_token=AHVPPUVMRCV7R56VPT4H7L3QZKBGHA5CNFSM4J4Q6WU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPWB2DY#pullrequestreview-334241039,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHVPPUW24466OGHOTB7SMGTQZKBGHANCNFSM4J4Q6WUQ
.


HIVE-27408: Parquet file opened for reading stats is never closed

What changes were proposed in this pull request?

Parquet file opened for reading stats is never closed
Why are the changes needed?

ParquetRecordWriterWrapper while closing the writer tries to collect the stats by creating a reader and opening the file. But it never closes the reader (hence not closing the file). This can leave the file open hence consuming memory and associated file handle resources.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/ParquetRecordWriterWrapper.java#L143-L155
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests

@aturoczy Thanks for the review. I have added an info log statement containing the file path and the exception message.

Nice catch, LGTM +1


feat:nanotime

goos: darwin
goarch: arm64
pkg: github.com/go-kratos/gateway/nanotime
BenchmarkTimeNow
BenchmarkTimeNow-10            	16510741	        71.73 ns/op
BenchmarkRuntimeNanotime
BenchmarkRuntimeNanotime-10    	32881779	        37.22 ns/op

goos: linux
goarch: amd64
pkg: aqgs/gateway/internal/proxy
cpu: Intel(R) Xeon(R) Platinum 8369B CPU @ 2.70GHz
BenchmarkTimeNow-4              16721013                68.36 ns/op
BenchmarkRuntimeNanotime-4      24591564                46.54 ns/op
PASS

Codecov Report

Merging #141 (57d35d6) into main (a1f9006) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   37.76%   38.06%   +0.29%
==========================================
  Files          12       13       +1
  Lines         842      846       +4
==========================================
+ Hits          318      322       +4
  Misses        480      480
  Partials       44       44

Impacted Files
Coverage Δ

nanotime/nacotime.go
100.00% <100.00%> (ø)

proxy/proxy.go
51.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f9006...57d35d6. Read the comment docs.


Complete iOS and MacOS Native support

Requires #113
Supersedes #52
Closes #98

Awesome! Thanks for the improvements in the previous iOS PR (#52).


fix: undefined health in pod info

What does this PR do?
check if health is undefined on pod inspect data
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #746
How to test this PR?

@axel7083 I cannot reproduce the issue on my mac. Is it the container *-infra which has an undefined Health?
On my system, I get:
  "State": {
    "Status": "running",
    [...]
    "Health": {
      "Status": "",
      "FailingStreak": 0,
      "Log": null
    }
  },


Double TOC in chrome

When open bookmark bar in zh-cn/docs, and scroll to bottom, it happens.
Chrome  60.0.3112.90，the latest Chrome too.

I found it ups to the screen resolution(2560*1440 2K)

the latest Chrome too

I couldn't reproduce the issue. Can't afford a 2K monitor either. 😢

Can't reproduce either on Chrome 60 macOS 10.12. Could you disable the extension to see if this issue can be reproduced? Thank you.

If I disable the Adblock extension, it return to normalness.
Seems to be extension problem.
Sorry.

Glad to hear you solve the issue.

Probably browser render problem.