Some nested redirects return "Error code: 522"

Hi! We observed that some of our nested redirects from the old sections now return "Error code: 522".
For example, here is the redirect: /patrol/finders/advanced
And when you go to the actual page: https://patrol.leancode.co/patrol/finders/advanced
You can see "Error code: 522".
This redirect works:
https://docs.page/leancodepl/patrol/patrol/finders/advanced -> https://patrol.leancode.co/finders/advanced
So it looks like it doesn't work on custom domains. 🤔

Thanks for flagging! Will investigate.
The full URL may work instead of relative as a workaround, but will check what's happening here.


Update concepts-connectivity.md

Fixed toc navigation

@kartben : Thanks for your contribution! The author, @dominicbetts, has been notified to review your proposed change.

Hi @kartben - thanks for taking the time to fix this!
#sign-off

@GitHubber17 : Thanks for your contribution! The author, @dominicbetts, has been notified to review your proposed change.


Split chart utils in a different package. Add Gopkg files and unit tests

Added Gopkg.toml, Gopkg.lock and update vendor dependencies (generated after dep init)
Move charts specific functions to a package. Added tests for FindChartInRepoIndex
Added unit tests for the controller method updateRelease

You've combined 3 separate changes into one PR, which makes it more difficult to review

Yes, I wanted to make a separate PR for the Gopkg changes but I needed the changes for the controller unit testing. I could also have done a separate PR for the unit testing of the chart-utils pkg but since it include some small changes I wanted to ensure that the e2e functionality is not broken with the controller tests.
In any case, if you still want me to split this in three different PRs just let me know.


Kernels refactoring

Description of changes
Big rewrite of the kernel updater script so we don't have to rely on sed wizardry. Should be rebuild 0.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ah sorry, I thought it was still open :sweat_smile:
Anyways, would be cool if this would be picked up eventually, otherwise I'm adding it to my todo list %)

I actually agree with most of the points, let's do a follow up on this.
Le ven. 22 sept. 2023 à 13:24, Maximilian Bosch @.***>
a écrit :

@.**** commented on this pull request.
In pkgs/os-specific/linux/kernel/kernels-org.json
https://github.com/NixOS/nixpkgs/pull/256099#discussion_r1334249047:

@@ -0,0 +1,38 @@
+{

"testing": {

   "version": "6.6-rc1",

   "hash": "02zh3dnikyhhlas9xccia963d4yqmzq0m4b8s10x8mjng3na45hd"

Even though this is an internal data-structure, I don't like the naming
here: hash expects either an SRI hash or something in the form of <algo:base{32,64}
repr>, not a base32 sha256.
I'm fine with either solution, but please call this field sha256 or fix
the form of the value.
In pkgs/os-specific/linux/kernel/update-mainline.py
https://github.com/NixOS/nixpkgs/pull/256099#discussion_r1334252722:

   return f"{major}.{minor}"

+def get_hash(url: str):

return subprocess.check_output(["nix-prefetch-url", url]).decode().strip()

+def commit(message):

return subprocess.check_call(["git", "commit", "-m", message, VERSIONS_FILE])

+def main():

kernel_org = urllib.request.urlopen("https://kernel.org/")
soup = BeautifulSoup(kernel_org.read().decode(), "lxml")
release_table = soup.find(id='releases')
if not release_table or isinstance(release_table, NavigableString):

Is the HTML actually stable? I'm wondering if it isn't actually a better
option to use e.g. https://www.kernel.org/feeds/kdist.xml (i.e. something
with a well-defined format).
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/256099#pullrequestreview-1639757265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRGBW7R6VIGW55RXIYTX3VYPXANCNFSM6AAAAAA46HGC4Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

sha256 to hash here: https://github.com/NixOS/nixpkgs/pull/256670
Unfortunately breaks FODs so probably for the next bump.

I think you are right but I don't think it is a big deal because fixing the
script is easier now than trying to extend the old script for our needs.
We go for the XML anyway and we can see what happens.
Le ven. 22 sept. 2023 à 13:40, Maximilian Bosch @.***>
a écrit :

@.**** commented on this pull request.
In pkgs/os-specific/linux/kernel/update-mainline.py
https://github.com/NixOS/nixpkgs/pull/256099#discussion_r1334268606:

   return f"{major}.{minor}"

+def get_hash(url: str):

return subprocess.check_output(["nix-prefetch-url", url]).decode().strip()

+def commit(message):

return subprocess.check_call(["git", "commit", "-m", message, VERSIONS_FILE])

+def main():

kernel_org = urllib.request.urlopen("https://kernel.org/")
soup = BeautifulSoup(kernel_org.read().decode(), "lxml")
release_table = soup.find(id='releases')
if not release_table or isinstance(release_table, NavigableString):

It assumed certain URLs to exist which is a way weaker assumption than how
the entire release table is displayed / structured in HTML (#releases >
tr > td), so I do think that there's a chance that certain changes in the
HTML were not noticed because the URLs the sed looks for stayed the same.
In other words: I do think there's a chance that changes to kernel.org we
wouldn't have noticed with the old script may be noticed now.
Or am I missing something?
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/256099#discussion_r1334268606, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRHULY7ZHBPTHZHR2FDX3V2LZANCNFSM6AAAAAA46HGC4Q
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

This has totally broken linux_testing.  RCs don't have tarballs on kernel.org.  You have to fetch them from cgit (which also means they have to use fetchzip, because cgit tarballs are not stable).

I don't understand: https://git.kernel.org/torvalds/t/linux-6.6-rc2.tar.gz isn't this a tarball?

Ah, only, latest RC has a tarball online… ?

It's a dynamically generated tarball from cgit, not a static release tarball hosted on kernel.org's CDN.


Setting new proxies should happen last, not first, in the orchestration process

There's no point redirecting traffic if the new application hasn't been setup yet.
OTOH the real way to do it would be to wait until the other nodes are done, lacking that I imagine we might end up with loops...

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-380. You are welcome to file additional issues in GitHub if that's easier for you.


added Telegram ChatBot

Added a project using this API which is made by me, a Telegram ChatBot.
https://github.com/Tele-Bots/CovidBot

Thanks! There seems to be one already developed.
Please take a look at the official bot @COVID19IND1A_BOT


Add support for Ruby 1.9.3 back

Up until recently (Feb 2015) RubyInstaller (probably, the most popular way to install Ruby on Windows) recommended to use MRI 1.9.3
Watir-Webdriver is a web application testing library so many users might use for testing web app against browsers on Windows
Cucumber on Windows doesn't support Ruby > 2.0 so it doesn't quiet worth for users to upgrade for only one version

Support for Ruby 1.9.3 ended on February 23, so we are no longer supporting it, either. You can still use Cucumber 1.3 if you want to use a different version of Ruby, or you can use the Ruby version that Cucumber 2 supports. Either way, this isn't a reason for Watir to change the versions it supports.

Watir should be properly working on Ruby 1.9, it's just no longer supported. Also, there is still no official watir-webdriver release which drops Ruby 1.8/1.9.

Actually, current Watir's master doesn't work on Ruby 1.9.3 because of e.g. this - https://github.com/watir/watir-webdriver/blob/master/lib/watir-webdriver/window.rb#L14
I think usage of Ruby 2.0 special syntax doesn't provide huge enough benefits to break work of Watir with Ruby 1.9.3

Right, I've forgotten about symbol array shorthands.
I guess we can revert them to simple arrays and it should work fine.

@abotalov Could you check and see how it works now?


xDAI - Approve Transaction modal closes on its own

Env and safe: https://safe-team-xdai.staging.gnosisdev.com/app/#/safes/0x8B22bAf910E83a66FacF8539AFC125cBc026059b/transactions
After trying to sign a tx, if you keep the modal open it will close on its own after a few seconds.
It seems it has to do with an error that pop's up ever 10 or 15 seconds in the console.
Try to execute a tx, but instead of clicking "Approving Transaction" wait there for 10 or 15 secs and the modal will close on its own
See the gif:

The error in the console is not showing anymore, but the modal keeps closing on its own


Update package for rollup v4 support

Describe the bug
Not compatible with rollup v4. Please update. Thank you.
─┬ vite-plugin-stylelint 5.1.1
  └── ✕ unmet peer<EMAIL_ADDRESS>|| ^3.0.0": found 4.1.4

Reproduction
https://github.com/webdevnerdstuff/vuetify-color-picker-field
System Info
System:
    OS: macOS 13.5.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 4.69 GB / 64.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 20.4.0 - ~/.nvm/versions/node/v20.4.0/bin/node
    Yarn: 1.22.19 - ~/node_modules/.bin/yarn
    npm: 9.7.2 - ~/.nvm/versions/node/v20.4.0/bin/npm
    pnpm: 8.6.9 - ~/.nvm/versions/node/v20.4.0/bin/pnpm

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Hi @webdevnerdstuff . Please try v5.2.0. Please note that<EMAIL_ADDRESS>and above support rollup@4.

I am closing this issue since there are no responses. Feel free to open a new one. Thank you.


Editor for Character-Features is unusable on Firefox.

The editor for the Chareacter-Features (below Drive, Quality and Downfall) is too small to use on Firefox (see first screenshot). Setting a min-height of about 100px for the enclosing div fixes this behaviour (see second screenshot).

Thanks for you comment. Could you shate the code snippet, so I can fully understand your suggestion? I will add this fix in the next revision.


MWPW-150666: Spectrum 2 Tokens Integration into Milo

This work presents 3 potential options for integrating Spectrum 2 Tokens into Milo's main stylesheet.
Option 1: Slimmed Spectrum 2 Tokens Integration into Milo styles.css - 48.6kB - (7.95kB gzipped) Raw

This option presents an integration of a slimmed down version of Spectrum 2 Tokens, consisting only of what's currently needed. Additional properties would be added as needed. We will need to further assess and determine the immediate tokens required for Milo.

Option 2: Entire Spectrum 2 Tokens Integration into Milo styles2.css - 54.5kb - (9.4KB gzipped)

This option presents an integration of the entire Spectrum 2 Tokens properties required by Milo from design.

Option 3: Spectrum 2 Token Variables Integration into Milo styles2-var.css-  68kb - (10.46kb gzipped) Raw

This option explores a Spectrum 2 integration into Milo css using variables imported from spectrum2-styles.css

Changes

Combines Spectrum 2 Tokens into Milo css file in the 3 scenarios above.
Creates new build that reads Spectrum Tokens and replaces values directly from and to main Milo style.css (build-main.mjs)
Refactors original script to accommodate the restructuring of architecture in spectrum2-styles.css
spectrum2-styles.css size reduction to 3.18kb gzipped RAW after changes.

Resolves: MWPW-150666
Test URLs:

Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://saasha-mwpw-150666-spectrum2-milo-integration--milo--adobecom.hlx.page/

This will require a few more review sessions, since it's quite large. I have some initial quick feedback. Option-wise, I'm currently leaning towards the second one. First one would need maintenance as soon as something new is required and consumers might not be aware of this, slowing down the process. Third one adds too much overhead. So the second one feels like a good middle ground.

Agreed! Removed the other options to cut down the files.

Looking better! I have a few more observations. It's still a complex PR, so it's difficult to spot everything in one go, I may need a few more sessions on this one.

Thanks for hanging in there! This was a lot of manual data input so I appreciate the second pair of eyes.


login page form

Need login page with these fields
email
password

login page is done

login page is completed
Branch which is holding the code :
https://github.com/narinder07/intern-best-practices/tree/new-login-page
Commit for this branch:
https://github.com/narinder07/intern-best-practices/commit/aade6105fe12b7028bf27c559aec5d9b0e736b21


p4: 2020.1.2007551 -> 2020.1.2156517

Motivation for this change
Update P4 to latest. Unfortunately without a mirror it is necessary to update our package's revision version and SHA periodically, since perforce only makes the latest tarball available at a single URL.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131292 at 54d3408b run on x86_64-linux 1

1 package built successfully:

p4

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/version-management/p4/default.nix:18:3:
   |
18 |   installPhase = ''
   |   ^

Closed by #152439.


Notebook cell execution model

Somewhat a continuation of https://github.com/microsoft/vscode/issues/103713
Today, execution results are parts metadata and output and execution itself is done via kernels which come from kernel providers. We should try to model execution results into a single entity, e.g execution status (idle, running, scheduled? etc)

One thing that we should do is to allow the executeCell-functions to return a promise. The promise should resolve that execution has been successfully started. It would allow to show feedback on the run button in cases in which the kernel needs to be resolved or isn't idle.

Some execution API TODOs that I didn't have time to put into code, including some suggestions from Kai a few weeks ago

Rethink naming to be more explicit in the intent. Write all the jsdoc to explain the usage to check whether a normal person can follow the flow. Get someone else on the team to review it. Check which words are used in the explanation and use those in names.

Should the execution object be called "execution", maybe it is a "task".
"executeCells" could be "executeCellsRequest" because it really is just a request

Normalize "run" vs "execution" name
createNotebookCellExecution - only a kernel can access this, and only the active kernel can trigger an execution.

Two things not in the PR

Preemptively setting a cell as "pending" as soon as it is clicked, not having to wait for a Task to be created. We discussed this some, but in trying to implement it and explain it in the API jsdoc, I was wondering whether it's really worth the extra complexity. Will leave it alone for now until we really think it's an issue.
Canceling executions when a cell is deleted. Just because I'm not sure of the right place to implement this. https://github.com/microsoft/vscode/issues/119504

@jrieken maybe you can call this verified since you implemented it and filed some issues


vmi-mutator: Set default for VMI guest memory

What this PR does / why we need it:
This PR adds the DefaultGuestMemory field to KubeVirtConfiguration.
This value will be used to set a default amount of memory for VMIs, which have no memory
configured.
Follow up to https://github.com/kubevirt/kubevirt/pull/10450 and https://github.com/kubevirt/kubevirt/pull/10463
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10521
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

None

/cc

Looks like you missed a functional test asserting the previous behaviour:
Tests Suite: [sig-compute]Configurations VirtualMachineInstance definition [rfe_id:140][crit:medium][vendor:cnv-qe@redhat.com][level:component]with no memory requested [test_id:3113]should failed to the VMI creation

It is just a proposal, I also thought about making the default value non-configurable. Which other means would you propose?

Fail if someone has not set one (i.e. making it obligatory).
Or have a higher level abstraction doing this (e.g. templates).

Defaults, especially in the KV config, caused a lot of issues in the network area. It mainly increased complexity in many areas of the code, many times causing bugs.

Were these defaults mutated into to a resource once or always looked up from the KV CR?

The code is confusing (me), it appears as if the default network is applied both on the mutation [1] and on the vm controller [2]:

https://github.com/kubevirt/kubevirt/blob/ed6a2ab320733830b784df4ddb18af4c83e037be/pkg/virt-api/webhooks/defaults.go#L99
https://github.com/kubevirt/kubevirt/blob/eb96837b62048c96b82549fc825604241970cbe9/pkg/virt-controller/watch/vm.go#L1126

IMO, the pattern of having defaults defined this way is problematic. It would be preferred if the values would come in through other means.

Such as?

A higher level component that creates the VM/VMI with the "default" not requiring it as a must.

BTW, do I understand correctly that this is done through the mutation hook? i.e. the spec is changed? Are there other fields we do this?

Yes much of the VirtualMachineInstanceSpec has associated defaults that we apply during mutation:
https://github.com/kubevirt/kubevirt/blob/0bacc588bd5c195f6a048581a151ad8d9f83e900/pkg/virt-api/webhooks/mutating-webhook/mutators/vmi-mutator.go#L81-L85

Yea, now I see that even the default network may be handled there (although I do not understand why it appears in the controller as well).
Isn't this a problem with a potential race?
I mean, isn't it possible that others will create custom webhooks that may get triggered before "our" webhook? I remember vaguely that the order cannot be controlled (but maybe things changed or my memory fails me here).

@lyarwood Updated to change the expectations of the failing test.
@EdDev Right now you may create a VM without memory, but you cannot start it (VMI creation fails). I would either say fail fast, like you say, and already fail the creation of the VM. Or be more tolerant about it and fill in a default value for the memory. E.g. for the CPU we do it too, so I think this is reasonable.

Defaults, especially in the KV config, caused a lot of issues in the network area. It mainly increased complexity in many areas of the code, many times causing bugs.

Were these defaults mutated into to a resource once or always looked up from the KV CR?

The code is confusing (me), it appears as if the default network is applied both on the mutation [1] and on the vm controller [2]:

https://github.com/kubevirt/kubevirt/blob/ed6a2ab320733830b784df4ddb18af4c83e037be/pkg/virt-api/webhooks/defaults.go#L99
https://github.com/kubevirt/kubevirt/blob/eb96837b62048c96b82549fc825604241970cbe9/pkg/virt-controller/watch/vm.go#L1126

Yeah the VirtualMachine controller needs to set these defaults on VirtualMachineInstances it is submitting so we can also apply preferences ahead of submission, for example a preferred interface model for the default interface.
We also need to support users creating VirtualMachineInstances directly thus the slight duplication here.

IMO, the pattern of having defaults defined this way is problematic. It would be preferred if the values would come in through other means.

Such as?

A higher level component that creates the VM/VMI with the "default" not requiring it as a must.

We could move all of the defaulting out of the mutation webhook into the VirtualMachine controller but you'd then end up in a situation where current users of VirtualMachineInstances would see different behaviour during submission. I don't think this is a change we could land while the API is v1 but maybe something for v2 if that was ever to happen.

BTW, do I understand correctly that this is done through the mutation hook? i.e. the spec is changed? Are there other fields we do this?

Yes much of the VirtualMachineInstanceSpec has associated defaults that we apply during mutation:
https://github.com/kubevirt/kubevirt/blob/0bacc588bd5c195f6a048581a151ad8d9f83e900/pkg/virt-api/webhooks/mutating-webhook/mutators/vmi-mutator.go#L81-L85

Yea, now I see that even the default network may be handled there (although I do not understand why it appears in the controller as well).

As above.

Isn't this a problem with a potential race? I mean, isn't it possible that others will create custom webhooks that may get triggered before "our" webhook? I remember vaguely that the order cannot be controlled (but maybe things changed or my memory fails me here).

Yeah I don't think the order of mutation webhooks can be controlled when several target the same resource, namespace etc but they are still documented as they best place to set defaults during submission.

@0xFelix CPU is a compressible resource (you just get throttled if you don't have enough), but memory is not. I wouldn't treat them equally.
I'd rather have KubeVirt fail fast rather than automatically assign some amount of memory.
Thanks for bringing this up by the way, I didn't realize you could create a VM without specifying memory.

@acardace They are not equal, you are right. But from a virtctl UX point of view I would prefer to have a default for the memory instead of failing the creation. I would say at some point a user will notice if they need more memory.

/hold
I don't understand why we are doing this.
From my point of view, explicitly setting memory is an absolute requirement for running a VM.
Memory is directly related to the boot image, which is also a requirement for running a VM.
Imagine that we will set a default memory which is not enough for running the operating system. The VM will be created, and scheduled but will not boot.
We will waste resources, scheduler, and controller cycles for no reason.

The idea was to allow creation of a somewhat bootable VM, in case of ignoring an instancetype inference failure for a VM created by virtctl create vm. Prior to #10450, virtctl create vm defaulted to 512Mi of memory, if no instancetype was specified. Since enabling inference by default (#10450) and introducing a failure policy for inference (#10463 ) this PR would be required to keep the previous behavior when inference fails.
In general I noticed that you can create VMs without specifying any memory (#10521), so I consider this a bug not directly related to virtctl.

@0xFelix did you want to switch this PR over to rejecting VirtualMachines without memory defined?

@lyarwood Will open a new PR for that.

Closed in favor of #10546


Can't add multiple user-assigned managed id with new UI of Logic Apps Standard designer

Describe the Bug with repro steps

Add multiple user-assigned managed id in [Settings - Identity] blade.

Move to any workflow
Move to [Developer - Designer] blade
You can see error message "Invalid Number Of User Identities Multiple user identities are not supported. Please select only one user identity."

What type of Logic App Is this happening in?
Standard (Portal)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Google Chrome
Additional context
No response

@rllyy97 can you take a look?

@hartra344 This was implemented due to some errors we were getting from backend both in preview and in GA, logged in this GH issue: https://github.com/Azure/LogicAppsUX/issues/2076
It looks like these errors are not occurring in GA anymore, I get clarification from backend and remove the catch in Portal

If we do support multiple user assigned identities then we have to update all our designer code to accept multiple identities because that never does today and we didnt have code in old designer to handle that as well..
@ShingoHanai - was this working for you for connection creation earlier?

@preetriti1
I can choose one user-assigned managed id in multiple user-assigned managed id list at HTTP action with old UI.

I tested whether it works correctly from making HTTP action run with alternatively 2 user-assigned managed id and decoding received both access token.
As a result of this test, I found it works correctly and available to switch 2 managed id.
(object id is used each user-assigned managed id's.)
However performance it too slow.


⚠ Samsung has degraded performance

In b13c2ee, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2466 ms

Resolved: Samsung performance has improved in a34c0ef.


[HTML5] Port inline JS code to libraries, AudioWorklet support.

In this PR:

Usual fixes to the RasterizerDummy
Fix gdnative build when WebRTC module is disabled.
Update syntax for lto. (we could do better, and specify lto=thin lto=full etc, but keep it short for now).
A huge refactor of the JavaScript code porting it to libraries:
The API is implemented in JavaScript, and generates C functions that can be called from Godot.
This allows much cleaner code replacing all EM_ASM calls in our C++ code with plain C function calls.
This also gets rid of few hacks and comes with few optimizations (e.g. custom cursor shapes should be much faster now).
AudioWorklet API implementation.
Rewrote AudioDriverJavaScript to support multiple processor nodes.
The old (and deprecated) ScriptProcessorNode when threads are not available, and the new AudioWorklet API when threads are enabled.
The new implementation uses two ring buffers and a shared state to communicated with the AudioWorklet thread.
The audio.worklet.js JavaScript file is always added to the export template, but only really used (and downloaded) in the thread build.

Fixes #40891 (on thread builds, which is the only build that can be fixed).
Potentially others, which I will review.
There is a 3.x version here: https://github.com/Faless/godot/tree/js/3.x_audio_worklet

Thanks!


Syntax colouring of code blocks confused by language specifier

Description
The syntax colouring gets confused while editing markdown files containing code blocks with language specifier.
Steps to Reproduce

create a markdown file
insert a code block with the three back tick syntax
inside the block enter a single asterisk in the middle of the code
insert a second code block with the three back tick syntax and follow them by a name (like cpp)
inside the block enter an asterisk
after the second block enter any text.

Expected behavior:
the asterisk in the middle of the second code block should not affect the formatting.
Actual behavior:
the asterisk switched formatting to italics, and this goes to the end of the file, including the final text.
Versions
v1.8.0 running on macOS.

the GitHub syntax of highlighted code blocks is defined in
https://help.github.com/articles/creating-and-highlighting-code-blocks/

Duplicate of https://github.com/atom/language-gfm/issues/44.

the problem is not exactly a duplicate of https://github.com/atom/language-gfm/issues/44, but it might be related.

It is caused by the same problem as the original report, but the issue contains multiple similar issues. The first of which is identical to your issue — see https://github.com/atom/language-gfm/issues/44#issuecomment-73679692.


[2.x]: Use https in pom.xml schemaLocation - iteration 7 (#6063)

Part of #6063

/trigger

/trigger


Generated RSA key has invalid exponent?

I generate the key like:
$ jwkgen rsa --jwk

Example output:
{
  "kid": "Urv7E0SAY2vo-fk5cT26i89TmRgWJZAQ4kxRTPq-4-Q",
  "kty": "RSA",
  "n": "q_6BBpjyQHzOFIE13Rv7G5JDL5CqOJpSGVlB9HoiAW4lCdGxnRB5Zbr8FioQwxJYmaEjqQfBXX7ZUYalFdoxKWRcD8ISNc9u5gjOmL_hi0UR0oB7DfiHsQSZKaOM1lXPwF3thM1y7XKoM1ftW7tFHHeJbe5sxzqCjmSqeio-teUnQ_tQSgJ4ck7l8HVbZgqGG4cHGyPpCYyMQ2VvYIr6qL5CElqMQGvwKeRewaSCV9YTiTThLikaueTA4oo6R2F658VfZG8Ds7tuCqqEAnF4J5frhdzpnbQLN5aP9G0yvJBE0Xlqa9G5bD3OJDBLhMcxbddOlM2avAQocIqaQK4ofw",
  "e": "AAAAAAA",
  "d": "Gt5RTbSK86QLlYxx267JVY9Ny5pv3RPOi4M0GHsT4OFSC-ykMIMoU8oYI2ZC5BZznNxdc8RwYqi0TlYYaAeD8pFpCFUq_xj-nBT4IUiodVc-54GGt7IBkJfFTYntMHaLU-PYfQyTTaDBwfOUcuYYb9AEuhWrDJyJVLFJKHh8_3EhV5LtOmpjEeyo27OsXPRj7PgzTwwg4kYZr6woi4nFgQmUotZvY1SZ6jIUNYXmyArik-VyONLLta15YOUf_Jl3VPzTAyqWFaE618RJPJLEfJlD0_O0RANqS1xg_fp69ULzyhaY7qSJlFqTCfSDv6WI9s1WBbYAiSx7eTBEpMKB4Q",
  "p": "0qtuz-qCqOQq3ft13RoYt2FzkIokX7SP_YU5L_c5bVET-wE5Y6tovq5X4cL3cMkV4WvCogWGgymSIKRDFV710EsYPBZ5epzjSseczp2QCjrRF6KI_dy6JcvGEQ8ijWycgpT1Tudvk9QwBt56N-ny0xyAkdk7GX6wpWjIXuNKSNc",
  "q": "0QCplks0dXrX_yVxtsrAIDVybLu4eWs3Xr05_rTTTSjg_xenbdn56QxtXz-8afnuFtcU-b0J5h4FVZ6ViZWeOmD1877XWSyqasA_8Xv8KHopFhIMc5ZgNV4Lf5Y9RQzKkw0Y3Gx98lyWns0ZTamAFjH5pgCI_y9MS1PhSsrIYJk"
}

When I try to load it using gopkg.in/square/go-jose.v2, I get the following error:
crypto/rsa: public exponent too small

This is strange because it looks like AAAAAAA is pretty large. Maybe too large?

It definitely looks incorrect. I'll look into it.
Generally, when generating an RSA key the exponent should be specified by the user as input parameter (perhaps with a reasonable default such as 65537), but I somehow missed that.

Solved in 9e84ac4e104ae3474af623d2d74e607cbbcf930c


Routing key convention for inter-service requests

As mentioned in https://gocardless.com/blog/hutch-inter-service-communication-with-rabbitmq
All messages are assigned routing keys, which typically specify the originating service, the subject (noun) of the message, and an action (e.g. paysvc.mandate.transfer).

This is a good example of convention for service emitting event of its current activity.
Could you give an example of such convention for the service, that is requesting some information from another service, to make its job done?

Say, when the UserPasswordResetsService asks UsersService to check for user existence.

And then the second example, when UserPasswordResetsService asks MailerService to send email to given address.

Thanks in advance!

users.exists, users.user.exists
mailer.deliver, mailer.email.deliver-to

Simple.
Thanks.


Test: Multiplatform Sample Apps

Hi, This is my last PR for Multiplatform.
In #9, I converted the neumorhic module only and it is enough to release as multiplatform library.
This PR is an addition of desktop and iOS target for test.
There's no problem to run the app on two listed platform in my environment.
But, if you encounter any problem, then let me know.
Below is a screenshot of test application.

`
Please review this pull request and I'd like to express thankness to you for making this Great library!
If you need any help or description on what I did then please leave comment.

Sure! No problem.

Sure! No problem.


Using AWS cognito with 1.4.x does not work

Bug Report or Feature Request (mark with an x)
- [ x] bug report -> please search issues before submitting
- [ ] feature request

Starting with the 1.4.x versions of angular-cli, I am not able to use the AWS cognito libraries. It has worked with all the 1.2.x and 1.3.x versions.
Versions.
@angular/cli: 1.4.3
node: 6.11.1
os: linux x64
@angular/animations: 4.4.3
@angular/common: 4.4.3
@angular/compiler: 4.4.3
@angular/core: 4.4.3
@angular/forms: 4.4.3
@angular/http: 4.4.3
@angular/platform-browser: 4.4.3
@angular/platform-browser-dynamic: 4.4.3
@angular/router: 4.4.3
@angular/cli: 1.4.3
@angular/compiler-cli: 4.4.3
@angular/language-service: 4.4.3
typescript: 2.3.4
Repro steps.
$ ng new aws-ng-cli-test
$ cd aws-ng-cli-test
$ npm install --save aws-sdk amazon-cognito-identity-js
Add the following to the "apps" section of .angular-cli.json
      "scripts": [
        "../node_modules/aws-sdk/dist/aws-sdk.js",
        "../node_modules/amazon-cognito-identity-js/dist/aws-cognito-sdk.js",
        "../node_modules/amazon-cognito-identity-js/dist/amazon-cognito-identity.js"
      ],

$ ng serve
Open the page in the browser and see the following error message in the console:

scripts.bundle.js:126805 Uncaught Error: Cannot find module 'function webpackUniversalModuleDefinition(root, factory) {
if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory(require("aws-sdk/global"), require("aws-sdk/clients/cognitoidentityserviceprovider"));
else if(typeof define === 'function' && define.amd)
define(["aws-sdk/global", "aws-sdk/clients/cognitoidentityserviceprovider"], factory);
else if(typeof exports === 'object')
exports["AmazonCognitoIdentity"] = factory(require("aws-sdk/global"), require("aws-sdk/clients/cognitoidentityserviceprovider"));
else
root["AmazonCognitoIdentity"] = factory(root["AWSCognito"], root["AWSCognito"]["CognitoIdentityServiceProvider"]);
}'
at s (scripts.bundle.js:126805)
at scripts.bundle.js:145560

Because of that error, none of the cognito functionality is available.

do not include like that. take a look at this example from aws lab aws-cognito-angular2-quickstart

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.


bump dependency yacht to v0.4.0

What type of PR is this?
kind/dependencies
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #663 (e9617f2) into main (e2ffa5f) will decrease coverage by 0.23%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   13.60%   13.37%   -0.23%
==========================================
  Files          66       71       +5
  Lines        7492     7740     +248
==========================================
+ Hits         1019     1035      +16
- Misses       6391     6621     +230
- Partials       82       84       +2

see 38 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


 This means that if you define a Transform inside an object (or in an environment like a REPL that is wrapping things in objects), if you call the name method of a Transform (delete an annotation, run with -ll info) then you'll wind up with a malformed class name exception.
This changes all usages of getSimpleName to use getName. This is not super desirable from a readability perspective, but it's actually safe.
Alternatively, we could define a custom method like https://github.com/freechipsproject/chisel3/pull/1224. However, I don't think this is really necessary here as a Transform name is intended for printing and debugging, not for Verilog naming.
Checklist

[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?

Type of Improvement

bug fix

API Impact

This should have no API impact, but does change the default name of all Transforms. This may have impact for things relying on DeletedAnnotations or on parsing -ll info output. The former matters as some of the Driver Stage/Phase backwards compatibility is relying on DeletedAnnotations. However, Chisel does not use hard-coded strings. Anything that does use a hard-coded string will break due to this PR.
Backend Code Generation Impact
No impact.
Desired Merge Strategy

Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

We are ok with this change being in a minor release, correct? @seldridge

@Mergifyio backport 1.2.x

Yeah, this is fine to go in a minor release. No effect on the output Verilog.


Demo not work

I clone the proj, install the beta-metamask. Run:

yarn
yarn demo
yarn global add snap-cli

but with the following error:

I was wondering if that because of the wrong version of snap-cli? My snap-cli version is 0.4.1

Hi, I cloned a fresh instance of repo and then run yarn followed by yarn start demo - and everything seems to be working properly.
I think that your snap-cli version is actual problem - we had to use our fork of snap-cli to successfully implement all functionalities, so in this repo we are using @nodefactory/snaps-cli (version 1.5.0).

@MakMuftic Could you share more about prerequisites to run the demo? I've tried running it with different versions of metamask-snaps-beta but I always arrive at issue with RPC Error: Plugin RPC message handler not found.

@zikunfan @piotr-roslaniec any luck of running this demo with 9.3.0 beta ?


Drop non-terraform support, including k8s testing

Ok, so there are 4 failing legs here (and the roundup), triaging:

busybox and git are toast until Alpine serves consistent indices.
hugo is broken because we inadvertently dropped the dev packages from the Wolfi dev image (Fixed here: https://github.com/chainguard-images/images/pull/1071)
buck2 appears broken at HEAD by some starlark thing, started a slack thread

I'm inclined to bypass presubmits and merge since none of these issues are related to this change.


Date for station CRM17

[Enter feedback here]
Hello,
Switzerland is a new station, can you tell when the wave is available exactly?
Thank you
Pierre-Olivier

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dea32204-b115-83f9-daaf-0dfc6a4a7318
Version Independent ID: 96d429a7-8856-a481-c5df-6b80f0bc632b
Content: General availability deployment - Power Platform
Content Source: power-platform/admin/general-availability-deployment.md
Service: power-platform
Sub-service: admin
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

@popujol
We've updated the contact with Switzerland deployment information.


sendSynchronousRequest is deprecated

apparently sendSynchronousRequest is deprecated from ios 9 and later. it should be replaced.

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


tf.keras throws AlreadyExistsError for LSTM training whereas keras stand-alone throws no error.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): pip
TensorFlow version (use command below): 1.13.1 (keras version 2.2.4)
Python version: 3.6.5
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: None
GPU model and memory: None (CPU Training)

Describe the current behavior
When using tf.keras models and layers to build a simple LSTM and train on the Penn Treebank Dataset a long list of errors are thrown of the form:
W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
However, when just importing keras and building the same LSTM, no errors occur.
Describe the expected behavior
It would be expected that both keras's should be operational. I am also not mixing and matching keras and tf.keras layers.
Code to reproduce the issue
Attached is a test case that reproduces the problem. It is required that the Penn Treebank Dataset is downloaded/available (Directions in source). Code was modified from:
https://github.com/adventuresinML/adventures-in-ml-code/blob/master/keras_lstm.py
Run option 1 to use keras with no errors and use option 2 to run with tf.keras and see all the errors.
Other info / logs
2019-06-04 15:27:39.644788: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.647428: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.664264: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.666201: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.671178: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.676772: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.680910: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.685541: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.689694: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.693689: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.702369: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.703234: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.713664: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.725751: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.727035: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.731410: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.734116: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.745524: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.749895: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.750059: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.754578: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.757058: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.764737: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.769848: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.779327: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.779501: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.787285: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
2019-06-04 15:27:39.793182: W tensorflow/core/framework/op_kernel.cc:1401] OP_REQUIRES failed at variable_ops.cc:104 : Already exists: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/
Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19TemporaryVariableOp6TmpVarE
Traceback (most recent call last):
File "keras_lstm_issueFile.py", line 152, in
validation_steps=len(valid_data)//(batch_size*num_steps))
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 1426, in fit_generator
initial_epoch=initial_epoch)
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/keras/engine/training_generator.py", line 191, in model_iteration
batch_outs = batch_function(*batch_data)
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 1191, in train_on_batch
outputs = self._fit_function(ins)  # pylint: disable=not-callable
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/keras/backend.py", line 3076, in call
run_metadata=self.run_metadata)
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1439, in call
run_metadata_ptr)
File "/home/cyakaboski/python/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 528, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.AlreadyExistsError: Resource __per_step_5/training/Adam/gradients/lstm/while/ReadVariableOp/Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var/N10tensorflow19Tem
poraryVariableOp6TmpVarE
[[{{node training/Adam/gradients/lstm/while/ReadVariableOp/Enter_grad/ArithmeticOptimizer/AddOpsRewrite_Add/tmp_var}}]]
keras_lstm_issueFile.zip

@yakaboskic I tried reproducing the issue of option 1 and option 2 separately but I am not able to reproduce the it, Could you please provide minimal code snippet to reproduce issue. Thanks!

I have the same issue, but also complicated/long code - thus no minimal example.
When learning with a lear-rate of 0 the error vanishes, but the network is not learning ;)
A bit of googling hinted at some weights degenerating and yielding similar errors.
Also the net trained ~1.8 Epochs yesterday (around 800 iterations) and then encountered this error. When fiddling with the learning-rate i can make it crash after 1 iteration (with a lr of 1) or not at all (with a lr of 0).
Hope this information help a bit.
System is debian stretch with python 3.5.3 (GCC 6.3.0) and a GTX1080 for training. Also current tensorflow from pip.

reverted back to 1.12. That version works without problems.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@Drezil Thanks a lot! It works! :)
I tried in 1.14.0 and 1.13.1, error occurs.
but with 1.12.0, it's perfect!

Is this issue still present in TF 2.0 in graph mode (with tf.function decorator?)

@gavinlive,
Can you please post a new issue by providing the information asked by the template?
The reason for this is we can focus on your specific configuration and problem since the root cause can be unrelated even though the error messages are similar. Thanks!


AppSignal gem throws errors when running sequel migrations

When running migrations with with sequel log level set to debug (in the Rails config: Rails.application.config.log_level = :debug) every migration throws an error.
bundle exec rake db:migrate:reset

This runs normally until migrating and then for every query it throws this error:
Could not log "sql.sequel" event. NoMethodError: undefined method `squeeze' for nil:NilClass
["/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/log_subscriber.rb:40:in `sql'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/subscriber.rb:100:in `finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/log_subscriber.rb:83:in `finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/fanout.rb:102:in `finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/fanout.rb:46:in `block in finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/fanout.rb:46:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/fanout.rb:46:in `finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/instrumenter.rb:36:in `finish'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications/instrumenter.rb:25:in `instrument'",
"/Users/tom/.gem/ruby/2.3.0/gems/activesupport-4.2.4/lib/active_support/notifications.rb:164:in `instrument'",
"/Users/tom/.gem/ruby/2.3.0/gems/appsignal-1.0.1/lib/appsignal/hooks/sequel.rb:12:in `log_yield'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:184:in `execute_query'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:171:in `block in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:147:in `check_disconnect_errors'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:171:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:524:in `_execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:340:in `block (2 levels) in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:545:in `check_database_errors'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:340:in `block in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/database/connecting.rb:249:in `block in synchronize'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/connection_pool/threaded.rb:103:in `hold'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/database/connecting.rb:249:in `synchronize'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:340:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/dataset/actions.rb:950:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/postgres.rb:668:in `fetch_rows'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/dataset/actions.rb:139:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/adapters/shared/postgres.rb:330:in `foreign_key_list'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/extensions/schema_dumper.rb:255:in `dump_table_generator'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/extensions/schema_dumper.rb:144:in `dump_table_schema'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/extensions/schema_dumper.rb:134:in `block in dump_schema_migration'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/extensions/schema_dumper.rb:134:in `map'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-4.30.0/lib/sequel/extensions/schema_dumper.rb:134:in `dump_schema_migration'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/database.rake:26:in `block (4 levels) in <top (required)>'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/database.rake:25:in `open'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/database.rake:25:in `block (3 levels) in <top (required)>'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/appsignal-1.0.1/lib/appsignal/hooks/rake.rb:15:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'",
"/Users/tom/.rubies/ruby-2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/database.rake:75:in `block (2 levels) in <top (required)>'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/appsignal-1.0.1/lib/appsignal/hooks/rake.rb:15:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'",
"/Users/tom/.rubies/ruby-2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'",
"/Users/tom/.gem/ruby/2.3.0/gems/sequel-rails-0.9.12/lib/sequel_rails/railties/database.rake:165:in `block (2 levels) in <top (required)>'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:240:in `block in execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:235:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/appsignal-1.0.1/lib/appsignal/hooks/rake.rb:15:in `execute'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:179:in `block in invoke_with_call_chain'",
"/Users/tom/.rubies/ruby-2.3.0/lib/ruby/2.3.0/monitor.rb:214:in `mon_synchronize'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:172:in `invoke_with_call_chain'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/task.rb:165:in `invoke'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:150:in `invoke_task'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:106:in `block (2 levels) in top_level'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:106:in `each'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:106:in `block in top_level'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:115:in `run_with_threads'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:100:in `top_level'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:78:in `block in run'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:176:in `standard_exception_handling'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/lib/rake/application.rb:75:in `run'",
"/Users/tom/.gem/ruby/2.3.0/gems/rake-10.5.0/bin/rake:33:in `<top (required)>'",
"/Users/tom/.gem/ruby/2.3.0/bin/rake:23:in `load'",
"/Users/tom/.gem/ruby/2.3.0/bin/rake:23:in `<main>'"]

slightly formatted for readability
AppSignal gem version that works: 0.11.8
It doesn't work anymore with the latest: 1.0.1
Sequel gem version: 4.30.0
Sequel-rails gem version: 0.9.12
A quick look make me think this is the commit that broke it: https://github.com/appsignal/appsignal/commit/f0f00b4f3a03f3811915ebe46dbd04a3ec781eac#diff-dc2ceb9af0184cfe8b1141877ccc41e3L6
The payload is lost in appsignal as the commit removes it from the instrument call, but sequel-rails still depends on it to show it in the logs.
This is the line in sequel-rails why it only happens in debug: https://github.com/TalentBox/sequel-rails/blob/ad1a51b3ee45f90c99e28413bcc9d45c1eaf2eb8/lib/sequel_rails/railties/log_subscriber.rb#L35
Let me know if you need more information!

It seems sequel-rails already has instrumentation. Could you try and disable our sequel instrumentation and see what the result is?
in config.yaml:
instrument_sequel: false

When disabling the instrumentation sequel-rails doesn't seem to throw any errors anymore, but since this disables the instrumentation for sequel we can't see queries in appsignal anymore, right?

sequel-rails seems to have built-in instrumentation: https://github.com/TalentBox/sequel-rails/blob/89e71cc58ea44ccc85e9c30b7fb55889d36c0287/lib/sequel_rails/sequel/database/active_support_notification.rb
so that should generate the instrumentation (it's pretty much the same code as appsignal's instrumentation)

oooh... That's actually quite nice then.
So if we rely on this we don't need to activate appsignal's instrumentation.
We'll try running it and let you know if we have any other issues concerning this.


RFC: Avoid dependency on Rust nightly for capturing test output

Instead of using unstable API available only on Rust nightly, this uses the gag crate to capture stdout and stderr of the test scenarios.
This has one downside though, that crate currently works only on Unix-like systems. But it is also strictly more general as it redirects file descriptors instead of just changing the Rust-specific stdout and stderr
locked readers and writers.

It is an important requirement that this framework works on Windows, so I had avoided using these types of workarounds. However, we could use this in the stable config so at least on unix-like systems it behaves as expected?
I have given you commit rights now, btw. :smile:

It is an important requirement that this framework works on Windows, so I had avoided using these types of workarounds. However, we could use this in the stable config so at least on unix-like systems it behaves as expected?

I understand. I will try to retarget this to the shh crate which should be able to achieve the same and do so on Windows as well. The reason I tried gag first is that it is more popular and we have used it before at work.

I have given you commit rights now, btw. smile

Thank you very much! I hope I'll be able to justify the level of trust implied by that action.
One practical question remains though: Should I try to avoid "bothering" you with maintenance work and commit directly to master? Or would you prefer I always open MR and let them sit for day for you to veto them. Or I could always open MR as now which I wouldn't mind but which would make the commit rights rather pointless and keep your workload up.

Everything you've committed so far has been problem free, so I'm willing to work on a "I will revert anything troublesome" basis. Commit what you think is reasonable, and discuss larger changes like this one. :smile:
shh looks really interesting. Looks worth a try!

I have pivoted to using shh and it seems work as intended even though I have tested it only on Linux for now. The only downside is that we have a hard time merging stdout and stderr into a single byte slice, but this wont work reliably anyway if threads are involved and we can just output them separately as well, so this seems to be a small price to pay for being independent of Rust nightlies.

Ah, I had intended to separate them one day anyway. :smile: Thanks again!


Adds OTA Support to CY8CKIT_064S0S2_4343W

Adds OTA Support to CY8CKIT_064S0S2_4343W
Description
Patch set introduces OTA support to the kit. However, the "phone home" feature is absent.
Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Why does this PR have changes in vendors/espressif/esp-idf?

That's a good question. Removed. Apologies.


Fix version used for sphinx-action.

Codecov Report
Patch and project coverage have no change.

Comparison is base (b7a77a2) 100.00% compared to head (24c79bf) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          129       129
=========================================
  Hits           129       129

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Please release a new version

@cyijun please create a new 0.2.0 release with the latest changes for CA cert, client cert and client keys so I can use them automatically with the Arduino IDE.
Thanks!!

done


Add increment number to clientId

Add increment number to clientId if the ConsumerConfig.CLIENT_ID_CONFIG has been setted.
This modify could fix the "WARN" when I use spring-kafka that the same client.id can't regist to the mbean.
Thanks.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5552/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5538/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5554/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5540/
Test FAILed (JDK 8 and Scala 2.12).

We can't do this because quotas rely on client ids and it's not safe to change a user supplied one.

Closing this since it is an incompatible change. Please write a KIP if you think the change is needed, but I think it is unlikely to get acceptance without addressing the compatibility issue with quotas.


Add test for users

Description

Add test for user

Hello @yohannesdagnachew
Approved 🎆
Well done !!!
Highlights:
✔ Descriptive PR
✔ Passing linters
✔ Good branch name
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete! There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


Is it possible to change the weekly number displayed in monthly mode?

Summary
The number of visible schedules in the cell has to be increased to 5 while maintaining the monthly view mode, so options.month.visibleWeeksCount = 5; to adjust the size of the cell, but the displayed calendar
The start date doesn't start from the first week of the month and starts from the week that belongs to the current date, which is not the intended month view.
Screenshots

As in the image above, it should start from the first week of the month. You should be able to shorten or increase the week you show

The final goal is to display more than 4 schedules like the second image and customize it so that the more button is positioned downwards.
Version
Write the version of the calendar you are currently using.
Additional context
Add any other context about the problem here.

@3bgdragon
Looks like the month.visibleWeeksCount option working for me. I'd like to know the exact code block when you have trouble.
About your final goal, the calendar doesn't provide a way to customize where to render the 'more' button, like what you want.


fix: tab behaviour on editor #42

This pr fixes #42 by using codemirror's builtin indentWithTab command as an extension.

@kartik-madhak requesting review

I've put the indentWithTab command in the customKeymap.ts file :)


Add command: /startgame - emulation to run the game

Hello, I would suggest to add one useful command:
/startgame <game ID>
/stopgame

Command /startgame <game ID> - emulates the running game with id; /stop - stop .
For example:

/startgame 730

730 - CS:GO game ID

Already implemented, command is !play <appid> to start, !play 0 to stop. Read wiki article.

Oh, thx, I have not noticed.


Not able to find the attached Toast message in files

Hi, i am not able to find the Toast message in the plugin files, can you please guide where this toast comes from.
P.S. attaching screenshot.

I search here in all the package and i didn't find any toast here, i think its from the library

From which library can i check it?

its inside the core , there is nothing that i can do

Thankyou, appreciate the help!

Thankyou, appreciate the help!

Are you using the latest version ?


[test] Run all test nightly

In particular, we should be running tests with features = slow_tests nightly against the emulator.
In general we should also be running all tests (other than verilator, which take a ton of time to run) nightly.

Resolved by #1096


⚠ Bofrost.com has degraded performance

In 1915594, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 541 ms

Resolved: Bofrost.com performance has improved in 2f13ad3 after 9 minutes.


More control on who can hijack who

Hi !
Nice package !
Features that would be nice:

hooks to handle these cases:

hijacker has to be in a specific group or have a specific permission
hijacked user must respect some conditions (for instance : filter the user queryset)

some internationalisation
interpret LOGIN_REDIRECT_URL as a named url (cf django.shortcuts.resolve_url and its usage in the django login view : https://github.com/django/django/blob/002425fe39f62faafaa32e400f7531809181a1a0/django/contrib/auth/views.py#L48 )

Hi @NotSqrt
Thanks for your inputs.
We are working on the "who can hijack who" thing in #54 and will rework the defaults and how to set them. The group permission could be an option as well.
Could you please split up your issue so it will be easier to priories them. Thank you.

I was about to add multiple items, I'm going to create separate issue.

:+1:


More gen 17 - tracker

Ok,
This one is huge (sorry)
Couple of big changes

The reducer is now one switch so we can type it better. After we refactor this into sagas and to use entities i think a lot of this will go away. Also using immutable would help (we can't do this right now as we can't send this over the wire to remote windows but i have a fix for that later)
I ditched the UserOrNonUserTracker to make things more explicit. We now have 2 properties in the store to hold the two types
Moved the tracker types into their own file to fix cyclic deps. aka constants/* tends to pull in TypedState which pulls in constants/*

actions/tracker has a bunch of thunks which really should be sagas w/ side effects. confusingly they do stuff like
function onClose(){
...
dispatch({type: 'tracker:onClose')
}```

so we have very confusing name collisions. In the short term I am generating TrackerGen.setOnClose() to differentiate but longer term we should sagaize this and have that be a takeEvery that does that side effect instead of this explicit thunk

TODO

[x] test tracker (user, nonuser)
[x] test profile (user, nonuser)

@keybase/react-hackers this is ready. please actually test this code out
Likely easiest to use whitespace diffs
https://github.com/keybase/client/pull/9536/files?w=1

Notes from first pass:

the tracker popup closes after you click follow
the gui crashes whenever tracker is triggered by kbfs access
when I block my proofs via /etc/hosts, "Some of your proofs are unreachable". when I block cjb's proof, "Some of cjb's proofs have changed since you last followed them".

@akalin your stuff is address also, ptal


Understanding polymorphism & abstract classes using C#

Proposed title of the tutorial.
Understanding polymorphism & abstract classes using C#.
Introduction paragraph(s):
Polymorphism is often referred to as the third pillar of object-oriented programming, after encapsulation and inheritance. Polymorphism is a Greek word that means "many-shaped". At run time, objects of a derived class may be treated as objects of a base class in places such as method parameters and collections or arrays. When this polymorphism occurs, the object's declared type is no longer identical to its run-time type.
Polymorphism is a very helpful concept when it comes to a single abstract idea used in different ways and shapes.
With polymorphism, you can define a single abstract class and reshape it in different ways to suit your methods & ideas.
Key takeaways:

Understand the concept of polymorphism
Understand abstract classes
Multiple examples of polymorphism

References:
https://docs.microsoft.com/en-us/dotnet/csharp/fundamentals/object-oriented/polymorphism

Approved - @mohamedgh16


Theme: Improve startup and throughput using runtime execution information (PGO)

Profile guided optimization is a standard feature of many development platforms. We would like to make it a standard feature of .NET. It is already a feature of .NET in that the platform is PGO-optimized, but it doesn't extend beyond that. PGO for .NET is a multi-release journey, with the goal of significantly improved startup and throughput performance and working set reduction using both automatic and opt-in mechanisms/scenarios.
Today, both the native runtime and managed libraries are PGO-compiled using training data that we produce ourselves. The native runtime uses standard C++ compiler tools. The managed libraries use a technology called "Instruction Block Count" (IBC). IBC is notoriously hard to use (only a few people on the .NET team can use it effectively). Going forward, we intend to produce new tools that are straightforward to use, for both training (that product PGO data) and PGO-optimized compilation (that consume PGO data).
A key split in the PGO domain is static versus dynamic PGO. We are interested in both, with the following prioritization/staging:

Enable optimizing ready-to-run images based on static PGO data.
Enable optimizing JITed code based on static PGO data, as a new feature of tiered compilation.
Enable optimizing JITed code based on PGO data collected (and not persisted) at runtime.

More context:

MPGO is a past attempt at achieving similar goals.
Other platforms, like Rust support PGO.

User stories:

[ ] PGO collection tools can be used to collect PGO data from apps in a variety of scenarios: local machine, VMs and containers. (#5492)
[ ] People that build .NET from source can use existing PGO data (stored in a repo in the dotnet org) to optimize the .NET runtime and libraries.
[ ] .NET applications startup and run faster and use less memory, using static PGO data

Ready to run images are optimized using PGO data, including when assemblies are trimmed (which currently breaks the existing PGO system).
The JIT can use static PGO data, either when read-to-run images are not available, or when tiering from tier 0 to tier 1. The JIT should produce better code than what is available in ready-to-run images.

[ ] .NET applications are progressively optimized at runtime, using dynamic PGO data, for example by inlining devirtualized virtual methods. (#5494)

@billwert @DrewScoggins @davidwrighton will our microbenchmark data continue to be gathered on pre-PGO bits, or on PGOized bits? My assumption is the former, because (1) PGO may introduce unexpected "regressions" and "improvements" when training data is updated, which would hide real regressions (2) PGO is not designed to improve microbenchmarks, in general. cc @stephentoub

My understanding is that when you do a normal release build you get PGO data applied. This is the pattern that we follow. I know that we do not use the JIT PGO opt-out currently. I know that in the past we have been able to see the signs of stale PGO data in microbenchmark numbers, but I will admit I am not an expert in this space.

I see. I am interested in others' thoughts
Cc @jeffschwMSFT @AndyAyersMS
In my mind it is a non goal for micro benchmarks results to closely track customer experience but rather the goal is to reliably and promptly detect regressions caused by changes in the implementation, by keeping as many other factors constant as possible. Perhaps I'm thinking about it wrongly.

I would expect to use our previous release as a means to detect regression.

I was talking about day to day measurements, but good point: it's probably inevitable that any GA  baseline is PGO bits.

Even for day to day, I would only measure our shipping scenario (eg. pgo) and then compare to previous release for regression/improvement.

Ideally we'd track both PGO and non-PGO performance anywhere we care to make measurements. This accomplishes a few things:

makes it easier to spot PGO-only regressions/improvements during triage
if aggregated, gives us an overall figure of merit for the impact of PGO (which, if stable, can also be used to detect stale PGO)

For local benchmarking disabling PGO may give more reliable results (as PGO data may not apply to changed code).
For BDN style measurements it is simple to disable PGO via a runtime option (COMPlus_JitDisablePgo=1), since all the code we measure is jitted. For end-to-end scenarios it is harder to measure non-PGO; PGO alters the R2R contents and so non-PGO measurements would require a special build.
Given resource constraints we can't measure both PGO and non-PGO all the time. Since the product default will (likely) be to use PGO, we should measure and focus on that as our primary metric, and try and measure non-PGO if/when we can -- maybe 1x day or so would be sufficient.

Sounds good. We should maybe document the PGO disable flag in our perf workflow if we don't already.
Cc @adamsitnik

For BDN style measurements it is simple to disable PGO via a runtime option (COMPlus_JitDisablePgo=1), since all the code we measure is jitted.

This is not true. The vast majority of the code we run through microbenchmark testing with BDN is library code, which is all precompiled and would have PGO applied. We would need to build the product in a release configuration without PGO applied to effectively test it in this manner.

Perf measurements on non-PGO builds in general are of questionable value to me. For scenario (startup, size, etc) we count on PGO to fix pages and improve page density. Unoptimized binaries are also going to be somewhat more random day over day as code is added and removed, which can lead to unexplained changes in the non-PGO trend. This decreases the usefulness.
For microbenchmark style testing, non-PGO perhaps makes more sense. (At least until PGO starts doing heavy lifting on block rearrangement, intra-method splitting, etc.) (Maybe it already does?) However, let me pose a question: if the non-PGO trend moves (and it's not due to a random effect) and the PGO trend does not, what do you do? There's nothing to "fix" from the customer perspective.

The vast majority of the code we run through microbenchmark testing with BDN is library code, which is all precompiled and would have PGO applied

That would be true if we measured BDN perf with TC disabled. But when TC is on, we will only ever be measuring the perf of jitted code.

At least until PGO starts doing heavy lifting on block rearrangement, intra-method splitting, etc.) (Maybe it already does?)

Block arrangement yes, splitting, not yet -- though it is opportunistic for 6.0  (but not likely, I would guess).

Perf measurements on non-PGO builds in general are of questionable value to me.

Despite what I wrote above, I agree with that, for non-BDN scenarios. Especially so if we have some independent measure of "work" like instructions retired to look at (we seems to have lost that ability recently on windows, and have never had it elsewhere).

For scenario (startup, size, etc) we count on PGO to fix pages and improve page density.

We don't do those things (yet) for R2R images. Hopefully we get to it soon.

let me pose a question: if the non-PGO trend moves (and it's not due to a random effect) and the PGO trend does not, what do you do?

We only use the non-PGO results for diagnostic purposes. Which is why we only run them ever so often.
If both PGO and non-PGO regress then the issue is likely not a PGO issue (so we look at libraries, jit, runtime commits). If only PGO regresses the issue is with the PGO data or the way the jit interprets the PGO data (so we look at PGO data age/collection, and jit commits). If only non-PGO regresses then we don't worry about it as much (provided instructions retired data can verify non-PGO perf difference was purely in clocks and not in instructions).

Not to muddy the waters any further,  but it would also be nice to start measuring dynamic PGO perf on a regular basis. I do this on a somewhat ad-hoc basis currently for parts of TechEmpower.
So I'd suggest:

frequent, dense collection of perf for the default case: static PGO. Triaged regularly. (we do this already)
infrequent, sparse collection of perf for dynamic PGO. Triaged less regularly. (new)
infrequent, sparse collection of perf for non-PGO. Used only during triage of the above two. (new)

That would be true if we measured BDN perf with TC disabled. But when TC is on, we will only ever be measuring the perf of jitted code.

This is something I didn't appreciate. My belief was that R2R would be used even if TC was on, and R2R would be the best code we could make. That of course changes things.

Bulk closing .NET 6 epics and user stories. If you think this issue was closed in error, please reopen the issue and update it accordingly.


chore(release): v1.2.4 🎉

:robot: I have created a release beep boop
1.2.4 (2024-08-18)
Bug Fixes

logs: gracefully log errors with log trail (baac9b1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ehmpathy/visualogic/releases/tag/v1.2.4 :sunflower:


reusing pascal-voc annotation to re-train a VIAME detector

I am using VIAME desktop on Linux with GPU support - I have a number of annotated seafloor images (~58K HabCam V4)  - is there a way to further train a VIAME detector/network based on my annotation?
The annotations are available as an XML file (one for each image)  in pascal-voc format, I may try to convert the annotation in Yolo format if that can help. Thanks for any advice!

is there a way to further train a VIAME detector/network based on my annotation?

Yes

We only support the file formats listed here:
https://viame.readthedocs.io/en/latest/section_links/detection_file_conversions.html
Predominately VIAME CSV and COCO JSON across the board, in both the DIVE interface and project folders - so you'd need to convert to one of them if you want to train things out of the box, or alternatively write file format parser code for Pascal-VOC and add it to https://github.com/VIAME/VIAME/tree/main/plugins/core

@mattdawkins thank you for your reply -
I guess the reader code is in  is that correct?
from the sample line:
/// "201503.20150525.102214751.575250.png" 185 "boundingBox" 1195 380 1239 424

the fields are:
/// "image_name" annotation_unique_ID "boundingBox" lower_left_x lower_left_y upper_right_x upper_right_y

means for multiple bbox in the same image, I will have the image l;listed N times for how many bbox, with unique ID
Is my interpretation correct?
May I ask for a pointer to the docs on how to initiate the training process?
Ideally I'd like to start from a pre-trained network and add my dataset to fine-tune the detector. I can begin by adding annotation for a pair of classes (scallops and sea anemones)


Files for French Translation

Hello,
As planned I translated you the 2 files. Let me know if it is ok for you. It's the first time that I do this.
Thanks.

Hey @Christophe85! I merged this now.
However, I noticed that I based the french strings file on the english one, which relies a lot on defaults and is not complete. I updated the french strings file now with the missing strings based on the german strings file, so that it should hopefully now contain all required strings (🤞).
If you have another minute, maybe you can have another go at the new strings?

I also pushed build 24 to TestFlight which includes the translations you added so far.

Hello Paul,
I have translated the file. I am not expert with github but I have deleted my old Fork as you asked for and I created a new one with the file translated.
tell me if it is ok...
I can't wait for the new version on testflight that includes this file.
Have a nice day.

I think you'd have to open a new PR using your main branch. Could you try that?


New version DiffEqBase: 5.7.0

Registering: DiffEqBase
Repository: https://github.com/JuliaDiffEq/DiffEqBase.jl
Version: v5.7.0
Commit: f88b3c20a0999cb5a3ec50c2f58c5183acaf8fa0
Proposed by: @ChrisRackauckas
Reviewed by: @ChrisRackauckas
Reference: https://github.com/JuliaDiffEq/DiffEqBase.jl/issues/214#issuecomment-487394992

Add compatibility for julia?

@fredrikekre is that not handled here? https://github.com/JuliaDiffEq/DiffEqBase.jl/blob/master/Project.toml#L25

Okay, then "use reasonable julia constraints", e.g.
[compat]
julia = "1"

Consider enabling TagBot to make sure the release is persistent in your repo, see https://discourse.julialang.org/t/ann-tagbot-creates-tags-and-releases-for-your-julia-packages-when-theyre-registered/23084

TagBot tag


Efficient way to find and update marker

Is there an efficient way to find and update a marker? (either remove it or update its location)
Also, I am getting an error when calling removeLayer(markers)
Thank you,

I ran into the removeLayer() because when calling remove layer it just gets passed to remove marker but it is not a marker...


Reload with different config file

Am using keyd v2.5.0
What I am trying to do is have different config files, to use at different points in time,
and I am not sure about how to do this, reading this: https://github.com/rvaiya/keyd/blob/master/docs/keyd.scdoc
I know how to change default.conf and then reload the config( with systemctl reload keyd), but I haven't been able to reload a different config.
I want to do this for two reasons, some applications that I can use better with different keybinds, and to learn about how keyd works without changing my default config.

I want to do this for two reasons, some applications that I can use better with different keybinds

Doesn't application specific remapping helps with that?

and to learn about how keyd works without changing my default config

When working on my main keyboard config I usually connect another cheap one so even if the config breaks it is only applied to my main keyboard id, while the cheap one is using a copy of my latest config.


Parallelize e2e runs on the test-level

Currently each thread executes a single test file (--dist loadfile). In the case of the ElastiCache controller, tests are organized by resource. Since the Replication Group resource contains the most tests and the longest-running tests, both the actual tests and the teardown are prone to fail due to credential expiration during Prow runs. Using the option --dist no should mitigate this issue, which other controllers may eventually run into as well.

/lgtm