Make a CLI version that can accept arbitrary arguments

A CLI tool that can take a DL training command (and it's arguments) as arguments would be helpful. It doesn't need to show per epoch consumption: just the total one.
Here's an example use case:  carbontracker <training-command> <*args>.  The training-command can be something like allennlp-train or something else.

Thank you for your suggestion. We're pleased to inform you that we have introduced a Command Line Interface (CLI) tool for CarbonTracker in our latest release v1.2.0. This should essentially provide the functionality you were looking for.
Basic example:
carbontracker --script train.py --log_dir ./logs
Your usage example:
carbontracker --script "train.py arg1 arg2 ..." --log_dir ./logs
Given this new feature, I'm closing this issue. If you have any further feedback or face any issues with the new CLI tool, please don't hesitate to open a new issue.


Softfloat integer truncation overflow checks are wrong, and missing softfloat conversion tests.

For the integer truncation operations, the checks for overflow were incorrect.  They only check for the floating point number to equal the min or max for the integer type being truncated to.  To fix this, change the condition to check for greater than or less than max or min, this will also remove the need to check for infinity and negative infinity as they will be subsumed by the previously mentioned checks.
Also, the conversion spec tests for softfloat and corresponding f32_f64_conversion_tests need to be updated and fixed.

Can we have ATC for this?


plotting 3D boxes on the point cloud

Hi,
I wish to do this:
range image -> pcl -> plot 3D boxes from the labels in the PCL
How can I do that?
Please help.
I tried the following code but I don't understand the result.
`# get the 3D box coordinates for the point cloud - each frame will have many objects and as many labels
for label in frame.laser_labels:
        # compute the 3D box corners in the point cloud
        box_T_mat = utils.get_box_transformation_matrix(label.box)
        vertices = np.empty([2, 2, 2, 2])
        for k in [0, 1]:
            for l in [0, 1]:
                for m in [0, 1]:
                    # 3D point in the box space
                    v = np.array([(k - 0.5), (l - 0.5), (m - 0.5), 1.])

                    vertices[k, l, m, :] = [v[0] / v[2], v[1] / v[2]]

        # vertices = vertices.astype(np.int32)`

Hi,
This function takes a 3D bounding box described by its position, orientation and size and project its 8 corners onto an image. The array vertices contains the 2D position (in pixels) of each corner in the image.
I assume that you are using the top 360° lidar. In this case, this function is not directly usable because it was designed for perspective projection whereas the range image is more like an equirectangular image using spherical coordinates.
Here is a variant of this function which I have used in another project to draw 3D bounding boxes into 360° panoramic images.
Have a look at this function to see the exact details of how the range image is mapped to a pointcloud in this dataset.


What is the recommended base model for realistic photo generation? Or it'll always look AI'sh?

What is the recommended base model for realistic photo generation? Or it'll always look AI'sh?
I was wondering if it's possible to create more realistic results rather than artistic results.
Any recommendation for steps/base model/ ip_adapter_scale / controlnet_conditioning_scale?
And one last question, when using Replicate, do I have a specific way to refer to the object in my prompt? Similar to the tag system we have in SD (like cjw which refer to the trained subject)?
Thank you!

Hey @haofanwang
Any pre-processing I can do to improve user input image similarity to results? In the thread you linked the input image not similar to the results of the model (for realistic usage). Any advice on how to prepare the input image / prompt / properties better for accurate results?

@haofanwang  Would love your feedback! Thanks


Docker restart an container after an rm

Hello i started an container and now i can't remove it.
Example :
Here is the container : https://puu.sh/ut8do/7b8beb929f.png
Now i run the command "docker rm -f 9a0f59433517"
https://puu.sh/ut8h6/8dfe8904a6.png
And it come back with another name : https://puu.sh/ut8iW/8d333ec637.png
Thanks

that's because those containers are part of a service; see this comment for more information https://github.com/docker/docker/issues/31439#issuecomment-283216834
Please keep in mind that the GitHub issue tracker is not intended as a general support forum,
but for reporting bugs and feature requests. For other type of questions, consider using one of;

https://forums.docker.com
the Docker community Slack channel
StackOverflow

I'm going to close this issue because this is not a bug, but feel free to continue the conversation 👍


csolution convert - generate information files also when errors appear, Add missing information

The Problem To Be Solved
We should consider to use the build information files for IDE integration. This file is not generated when for example a component or pack is missing.
Could this be fixed (and should we introduce a nodes that indicate errors)?
Next steps are then. Add:

code template files
api header files (from user view)
documentation files
generator ID (for run command)

Implemented in CMSIS-Toolbox 2.3.0


Add Agent getters to data.yml

This PR adds agent getter functions to the data.yml.
The following ones do not have any callers, so I left them out (unless I should add them? seems pointless 🤔 ):
0x140225660: GetAgentScenarioTree
0x140225670: GetAgentMateriaAttach
0x140225710: GetAgentTourismMenu
0x1402257F0: GetAgentPerformanceMode
0x1402258F0: GetAgentTofuList
0x140225940: GetAgent142
0x140225950: GetAgent433
0x140225980: GetAgentContext

I would say just add them even if they have no callers. Just so we have more named when going through the decompilation

not with their id for names, the IDs change

oh right, i'll leave the ones with id out


add the extenstions:

Snap&Read
Kami for Google Chrome™
Co:Writer

these arent blocker extensions bro

There are extensions that are installed by default and stuck on there


llm chat errors on followup since 0.6

$ llm chat
> hello
how are you?
> not much, how are you?
Traceback (most recent call last):
  File "/nix/store/bhbq5lpdd2ncpn7b12w8d5sl6x9xm4gy-python3.12-llm-0.17/bin/.llm-wrapped", line 9, in <module>
    sys.exit(cli())
             ^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/llm/cli.py", line 535, in chat
    for chunk in response:
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/llm/models.py", line 169, in __iter__
    for chunk in self.model.execute(
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/llm_claude_3.py", line 159, in execute
    "messages": self.build_messages(prompt, conversation),
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/c2d99rarg0lj5lacxghi4xwxfas6w8vf-python3-3.12.4-env/lib/python3.12/site-packages/llm_claude_3.py", line 110, in build_messages
    if response.attachments:
       ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Response' object has no attribute 'attachments'

This happens with Claude 3.5 Sonnet and GPT-4o, so I think it's a bug in LLM.

I'm not sure why this test didn't catch this:
https://github.com/simonw/llm/blob/122265a3d2131a7140911c2a3d99ad045d61c847/tests/test_chat.py#L20-L31
I've manually tested the fix and confirmed that it works. I'll need to rethink this when I add attachment support to llm chat directly.

Manual testing:
% llm chat -m gpt-4o-mini
Chatting with gpt-4o-mini
Type 'exit' or 'quit' to exit
Type '!multi' to enter multiple lines, then '!end' to finish
> A short pun about pelicans
Why don’t pelicans ever get invited to parties? Because they always bring their own bag!
> banana slugs
What do banana slugs wear to impress each other? Slug-phy attire! 🍌🐌

And llm logs -c now returns:

2024-11-01T21:18:36    conversation: 01jbmsg3f181dntajvanx0ep5g
Model: gpt-4o-mini
Prompt:
A short pun about pelicans
Response:
Why don’t pelicans ever get invited to parties? Because they always bring their own bag!
2024-11-01T21:18:41
Prompt:
banana slugs
Response:
What do banana slugs wear to impress each other? Slug-phy attire! 🍌🐌

This was a duplicate of #597 so please close that too -- glad to see it fixed, thanks Simon!


Error while loading shared libraries

Ubuntu 20.04.2 LTS
Steps to reproduce:

clone electron quick start
yarn
yarn start

Result:
/node_modules/electron/dist/electron: error while loading shared libraries: libatk-1.0.so.0: cannot open shared object file: No such file or directory
error Command failed with exit code 127.

if you are running on wsl system. here would help https://github.com/electron/electron-quick-start/issues/486#issuecomment-1050782211

if you are running on wsl system. here would help #486 (comment)

Nope, look at my comment there instead for WSL

Nope, look at my comment there instead for WSL

I confirm that installing chrome under WSL works out of the box and might be a better cross-platform solution than combining WSL with platform=win32, which, as others reported, might not even work for some.
sudo apt update
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo dpkg -i google-chrome-stable_current_amd64.deb
sudo apt-get install -f
google-chrome --version

If you get issues along the way, follow the link in the original post above.


Improve handling of line number and column information in CodeSourceMaps for the precompiled runtime

After 7c34a80, we now have some amount of column information available in the precompiled runtime, as long as the column is <= 2^10 (1024) and the line is <= 2^20 (1048576). In doing so, we've lost the ability to represent line numbers between 2^30+1 and 2^31-1 (since we use a bit to determine whether column information is present).
While good enough for realistic cases, it'd be nice if we could just store a pair of compiler::target::word in the CSM for precompiled line/column information (and only store a single int32_t for the non-line/column (i.e., negative) position case). This would work for non-symbolic stack traces, because the DWARF builder manually reads the CSM stream and so can pull out the pairs directly and insert them into the DWARF information. However, for uses of CSMs in the dart precompiled runtime when not running with --dwarf-stack-traces, we generate TokenPositions in the CSMReader, which are then used by the symbolic stack trace printer.
Thus, we'd need to modify the TokenPosition class to include this extra information instead so appropriate TokenPosition objects can be created by the CSMReader. However, TokenPosition::value() is public, and there are definitely users of TokenPosition objects that manipulate the value directly, possibly re-creating TokenPosition objects, which might now lose information. We'd need to change ::value() to private, add move/copy constructors for most TokenPosition users to use instead, and then fix up any users with bad behavior to not do that.
Putting this in an issue so it can be returned to at a later date when time allows (or when doing this fix becomes higher priority).

Just as a note, 7c34a80 was reverted due to increased CodeSourceMap size in snapshots. A modified version that only takes affect when non-symbolic stack traces are enabled (and thus CodeSourceMaps are elided entirely from snapshots) in 3e40abbc.
Since this is now restricted to non-symbolic stack traces, we can probably just change the encoding of CSMs in this mode entirely and avoid the TokenPosition changes, since the DWARF builder manually reads and interprets the CSM data itself.

Commit above does exactly as I outlined above, and also ensures that debugging uses of the CSM in the precompiler when non-symbolic stack traces are enabled (e.g., in the disassembler) return the same info as in the symbolic case (a token position that is the line number).
Given the effect that adding the columns has to the CodeSourceMap and the resulting .rodata size increase when they are serialized, I expect this will be the extent of the changes needed unless we move to a --dwarf-stack-traces by default world and no longer worry about the effect on serialized CSMs.


Fix typo

'and' instead of 'an'

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We have moved the Hugo site source to its own repository, so we would appreciate if you could open this PR directly in hugoDocs:  https://github.com/gohugoio/hugoDocs/pulls


Compatibility with ARM CPUs

Currently, the build fails with lots of errors like:
error[E0609]: no field `rax` on type `&user_regs_struct`
   --> src/main.rs:326:43
    |
326 |     syscall.errno = errno_check(registers.rax);
    |                                           ^^^ unknown field
    |
    = note: available fields are: `regs`, `sp`, `pc`, `pstate`

Edit: Just noticed this in your readme

intentrace currently only supports x86-64, given that the program is currently in beta, PRs for cross compatibility will unfortunately not be accepted until the program is stable enough.

I guess this can be considered a tracking issue then. We'll see how many potential users chime in.
Note, we found this while packaging intentrace for nixpkgs/NixOS: https://github.com/NixOS/nixpkgs/pull/354843

I generally believe cross compatibility at this stage is technical debt, but I'll leave this issue open


Added fix for wrong application of height for herringbone-helical gears.

Added fix for wrong application of height for herringbone-helical gears.

There was 1 error from OCP instability out of 4000 tests. The OCP / CAD construction method is not the focus or scope of this branch, just the new tests added revealed the issue.
Closing this PR despite the failure, further work is planned on CAD construction robustness.


The letter "h" is omitted from the word "typography" in config.js

Hey @biloltuliboev , It's fixed.


GHC 9.6.1-alpha1

This PR is not meant to be merged. I just want to have the first GHC 9.6.1 alpha (<IP_ADDRESS>30111) available here.

[ ] I manually tested the code locally to make sure that it works.
[ ] If there is documentation, I made sure it's accurate and up to date.
[ ] If possible, I wrote automated tests for the new behavior.

If you're reading this and you're interested in trying out GHC 9.6.1-alpha1 using a Docker container, use public.ecr.aws/acilearning/haskell:<IP_ADDRESS>30111-7714b1adf6210c8a235445693a455d4ee2e34dba. For example:
$ docker run --interactive --rm --tty \
  public.ecr.aws/acilearning/haskell:<IP_ADDRESS>30111-7714b1adf6210c8a235445693a455d4ee2e34dba

% ghc --version
The Glorious Glasgow Haskell Compilation System, version <IP_ADDRESS>30111

I'm going to close this since it's not meant to be merged anyway. The Docker image will be usable regardless.


Add possibility to add a header to format-opts

(format-opts {:spec <spec> :header true}) adds a header.
You can customize the strings in the header using a map like this: (format-opts {:spec <spec> :header {:alias "alias-header-string" :long-opt "long-opt-header-string" …}}).
Currently the header is separated from the rows with a row of dashes. Not so sure about that.
Closes #72

Splits format-opts into opts->table and print-table. This way it's easy to customize the output of opts->table to add a header.
format-table pads the last element to the width of the table, i.e. may add trailing whitespace. This is a potentially breaking change to how things were formatted before.

Taking a look

@Sohalt Perhaps I'm misunderstanding but does your change actually show how to produce headers now?

No. It still needs documentation.
To add a header you'd do something like (format-table (concat ["alias" "opt" "ref" "default" "desc"] (opts->table …)))

Alright, perhaps you can finish that up then? The approach looks good to me.

Should I add the :header option back to format-opts? Or is it enough to document opts->table and format-table in the README?

@Sohalt We can start with documenting this and if it's not convenient enough, we can add the :header option later

OK. Can you check then, if the docs are fine like this?

Will do right now!

If you can get rid of the right-side whitespace (with str/trim-right or so)` and add a test which actually tests your desired header functionality, it's good to go.


Vt parallise source detection

Adds parallized source detection
Adds functionality to split a karabo.image into multiple parts
Adds mosaicking for source detection plots
General improvements of the karabo image class

Overall nice changes.
Before merging, please address the requested changes.

Done! Please have another look.

@Lukas113 Please have another look. I would like to later restructure source detection completely, see #528


aeroway=aerodrome is classified as industrial? Confused about tagging system

Hello MapBox team.  I have recently been using Mapbox Studio, and as an avid user of OSM, I am impressed.  I am, however, a bit confused regarding your classification scheme.  I wanted to style airports and had expected that the #aeroway selector would have controlled the "aeroway=aerodrome" tag, but instead it seems to be controlled by the "#landuse[class='industrial']" selector in Mapbox Studio.  I am not necessarily saying you guys are wrong about this, and don't want to start that debate, but this was confusing, and I am left wondering what other "surprises" I can expect.  Is there a complete list of the EXACT OSM tags that are used for each layer and sublayer classification for Mapbox Studio?  If I could get my hands on this, it would save me a lot of time.  I understand you created these groups to make things easier, but in my case, due to very specific requirements, it is actually making my job harder.  Any help in this regard would be most appreciated.  Thank you, and keep up the great work.

Sorry for leaving this so long. The short answer is no, we do not currently have a list of exactly how OSM tags map to properties in Mapbox Streets.
For some layers there are rather complex rules checking for the presence and absence of many tags, as well as looking at things other than tags such as the size/type/location of the geometry. Even for simpler layers it would take some time to compile and maintain such a list since the rules are spread out across different steps in the process, and we are always tweaking and refining them.
Many of the schema decisions in the Mapbox Streets vector tiles are held over from when we were only using it to style a single CartoCSS project (the default Mapbox Streets style). We've been refining and expanding it to help with custom Mapbox Studio styles, but at a conservative pace in order to keep style migrations simple and to avoid major CartoCSS performance traps and file size bloat. (If these were not concerns we could just include all the original OSM tags in the vector tiles for power users.)

@ajashton Thank you for your answer. It's not something we wanted to hear, but it's better than nothing.
I'm excited with your styles and want to use them for my own Vector Tile Server based on OSM data. However it's impossible now.
Could you please share some mapping rules from OSM tags/sizes to Classes and Types (in any form)? Or you specially made those styles to use with Mapbox services only?


SerdeEncryptSharedKey

see: https://github.com/laysakura/serde-encrypt/issues/34#issue-918640755

supporting various algorithm may important.
Each company has their security policy.


Add an entry for ets_write_char_uart

It is mentioned in ets_sys.h, but not actually PROVIDEd.

Thanks for sending this. I've cherry-picked it into our internal review & merge queue.

Cherry-picked as a40fd2e7b, thanks!


Define ObjectMeta metav1.ObjectMeta at Test case level for baremetal package tests

This PR is specific to the baremetal package and is required before parameterizing hard coded resource names.
It mainly removes objects such as the following.
    testObjectMeta = metav1.ObjectMeta{
        Name:     "",
        Namespace: namespaceName,
    }

The problem we are facing is that objects such as testObjectMeta are used for any resource, such as metal3Machine, Machine, cluster and so on. This creates a problem when a specific test cases needs to change the name or namespace.

/retest

/retest

/hold

/test-v1b1-ubuntu-integration

/test-v1b1-ubuntu-integration

/test-v1b1-ubuntu-integration

/test-v1b1-ubuntu-integration

/hold cancel


Default values for const generic parameters MAX_DIRS, MAX_FILES, don't work as expected.

Commit https://github.com/rust-embedded-community/embedded-sdmmc-rs/commit/566f2023653dace195a43b05a6429f47e6be8a50 added two const generic parameters MAX_DIRS and MAX_FILES to Controller.
Those parameters have default values equal to the values used before, and the new docs say: "By default the Controller will initialize with a maximum number of 4 open directories and files. This can be customized by specifying the MAX_DIR and MAX_FILES generic consts of the Controller"
However, the default values don't work as expected. The following code causes a compile failure:
let mut cont = Controller::new(block, DummyTimesource::default());

error[E0282]: type annotations needed for `embedded_sdmmc::Controller<BlockSpi<'_, rp_pico::rp2040_hal::Spi<rp_pico::rp2040_hal::spi::Enabled, SPI0, 8>, rp_pico::rp2040_hal::gpio::Pin<Gpio5, rp_pico::rp2040_hal::gpio::Output<rp_pico::rp2040_hal::gpio::PushPull>>>, DummyTimesource, MAX_DIRS, MAX_FILES>`
   --> boards/rp-pico/examples/pico_spi_sd_card.rs:276:9
    |
276 |     let mut cont = Controller::new(block, DummyTimesource::default());
    |         ^^^^^^^^
    |
help: consider giving `cont` an explicit type, where the the value of const parameter `MAX_DIRS` is specified
    |
276 |     let mut cont: embedded_sdmmc::Controller<BlockSpi<'_, rp_pico::rp2040_hal::Spi<rp_pico::rp2040_hal::spi::Enabled, SPI0, 8>, rp_pico::rp2040_hal::gpio::Pin<Gpio5, rp_pico::rp2040_hal::gpio::Output<rp_pico::rp2040_hal::gpio::PushPull>>>, DummyTimesource, MAX_DIRS, MAX_FILES> = Controller::new(block, DummyTimesource::default());
    |                 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

For more information about this error, try `rustc --explain E0282`.

(This was noticed in rp-hal, see this ticket for context.)
There is a blog post which nicely explains why this happens: https://gankra.github.io/blah/defaults-affect-inference/#default-type-parameters

One way to handle this without a breaking change, and without forcing every caller to specify the two parameters, would be to provide two separate constructor methods:
       pub fn new(block_device: D, timesource: T) -> Controller<D, T>; // this one uses the default values and keeps the old API stable
       pub fn new_custom_max(block_device: D, timesource: T) -> Controller<D, T, MAX_DIRS, MAX_FILES>; // this one allows - and forces - the caller to specify the maximum values

This is essentially the same workaround as was used for HashMap with the two constructor methods HashMap::new and HashMap::default.

Hi @jannic, I'm sorry my change has caused an issue for you.
I think there are some other underlying issues here at play, mainly that there is an expectation that no breaking changes can be committed to the develop branch. No official release was made, so in my opinion breaking changes should always be expected.
For me personally I would expect that a library like this can change its API freely on its development branches, and when its time for a breaking version release (a major semver release I guess?) the community can react accordingly and update its packages and fix the issues in a controlled way. What I would like to see is controlled releases to crates.io.
Evidently we aren't doing this here, so your request for backward compatibility is justified. I have no issue with having two constructors, but I think @eldruin or @thejpster should chime in here with what the best approach is

Sorry if it sounded like I was complaining, that was not intended. Of course breaking API changes are perfectly OK at this point.
I was just wondering if the change was intended. The sentence "By default the Controller will initialize with a maximum number of 4 open directories and files" appears to indicate that there is a default value. But as it is, that default just isn't effective and the caller has to specify the values manually.
And as @eldruin was planning to do a release, an unintended breaking change at this point would be unfortunate.
I'm not qualified to evaluate which API would be best, as I'm not using this library myself, I just noticed the issue when an example in the rp-hal repo failed to build. (And the fact that this example relies on a development git version of embedded-sdmmc is of course the root cause of the build failure.)

I think there are some other underlying issues here at play, mainly that there is an expectation that no breaking changes can be committed to the develop branch

The problem here is not that users expect the develop branch to not have breaking changes, it's that no release has happened in nearly 3 years.
There's no point using the stable branch (or crates.io) from the end-user perspective if it is effectively unmaintained.

We should do a release.
@jannic 's workaround looks good to me. Would you mind adding it in a PR along with some documentation? Then we can move forward with this.

I opened https://github.com/rust-embedded-community/embedded-sdmmc-rs/pull/69.
However I'm not entirely happy with the function name new_custom_max. Any better suggestions?

with_capacity? I know the value isn't an argument so it's not exactly the same, but the precedent is set that constructor functions don't have to be called 'newX'.


Does this work with NVidia?

Amazing project, thanks. Excuse the noob question. Does it work with Nvidia GPU? Seems OpenVINO is intended for Intel only.

Will leave open in case someone else replies. Feel free to close whenever.


Submitting the merged files again

Submitting the merged files again but with two input laser ports on both of the GCs.

Would you please sync your fork? I see some conflicts.
Also, there are changes requested to the yaml files

I just synced the


feat: custom resource specs

Signed-off-by: Ayush Kamat<EMAIL_ADDRESS>

i would give people the option of up to 96 cores + 180 Gi RAM. if over the thresholds you've created here, just construct a pod on one of the 96-spot node families


[Ensou Senkyoku] Difficulty icons from maps with both Ura and Oni disappears while selecting them during the song select/difficulty select transition

Fixed


Never display multiple notifications

Previously the editor would show a new notification for each paste that went over the limit. This meant the user would see multiple notifications at the same time.
This change limits the number of notifications displayed at any one time to 1.

I see I mised a comma in the var statement. Will fix tonight.


MM-22042 Only scroll RHS to bottom when current user posts

The previous fix for this issue had the post list backwards, so it tried to scroll if the first post in the thread was made by the current user, instead of checking the most recent post.
Ticket Link
https://mattermost.atlassian.net/browse/MM-22042
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/2803

/cherry-pick release-5.21


Support sbt 1.0.

I'm using this, and we are upgrading to sbt 1.0.  It seems to fail.
Curious if this project is maintained.  And if not if anyone has a fork?

Well there is a PR for support of sbt 1.1.0 and cross compilation: https://github.com/hmrc/sbt-git-stamp/pull/10

This is now cross-build for sbt 1.3.4 as of version 6.0.0


Suggest git-like moving forward in tasks

Thanks for the idea, looks useful. Merged after a couple of adjustments:
https://tmt.readthedocs.io/en/latest/stories/cli.html#interactive


Better plugin mechanism

We want to replace chePlugin and cheEditor with a  new plugin component type that:

can be specified using the devfile syntax (opposed to 1.0.0 meta.yaml, a devfile-like format)
is not Che specific, plugins can be specified for odo or even desktop IDEs

Use cases
These are the use cases of devfile plugins (basically Che use cases):

Reference one or more vs code extensions and the sidecar container that will host them (e.g. the java plugin)
Reference a container component that is re-used in multiple devfiles/stacks (che-theia is an example)

Proposal
devfile.yaml
---
components:
  - plugin:
      name: 'java language server'
      id: redhat/dependency-analytics/latest  # <= reference plugins published
                                              #    in a plugin registry
      registry: https://plugin-registry.io/
  - plugin:
      name: 'k8s workspace plugin'
      kubernetes:
        namespace: mynamespace
        selector: mykey=myvalue               # <== reference a kubernetes
                                              #     devworkspacetemplate resource
  - plugin:
      name: ...
      uri: https://..../java8-plugin.yaml     # <== reference external raw devfile
      components:                             # <== customise plugin's configuration
        - kubernetes:
            name: ...
            reference: ...
        - container:
            name: vscode-java
            memoryLimit: 2Gi
        - volume:
            name: m2
            size: 2G

java8-plugin.yaml
---
schemaVersion: 2.0.0
metadata:
  publisher: redhat
  name: java8
  version: 0.57.0
  displayName: Language Support for Java 8
  title: Language Support for Java(TM) by Red Hat
  description: Java Linting, Intellisense, (...)
  icon: https://(..)/logo.svg
  repository: https://github.com/redhat-developer/vscode-java
  category: Language
  firstPublicationDate: "2020-02-20"
  pluginType: che-theia-vsx    # <== mandatory for plugins. Valid types
                               #     are che-theia-vsx, che-editor, che-theia-plugin,
                               #     che-theia-extension, generic-service and
                               #     generic-ui
parent:
  id: redhat/theia-vsx-stack/latest
  components:
    - container:
        name: vsx-installer
        env:
          - name: VSX_LIST
               value: java-dbg.vsix,java.vsix
components:
  - kubernetes:
      name: ...
      reference: ...
  - container:
      image: ...che-sidecar-java
      name: vscode-java
      memoryLimit: "1500Mi"
      volumeMounts:
        - path: "/home/theia/.m2"
          name: m2
  - volume:
      name: m2

Spec Details

Plugins are defined in separated devfiles
There are 3 ways to reference a plugin: id, kubernetes, uri. This is consistent with how a parent can be referenced (c.f. #25).
chePlugin is replaced by non Che specific plugin
There is no editor/plugin distinction (a cheEditor is a plugin with pluginType: che-editor)
Every plugins configuration can be customised using a kustomize approach. This is consistent with how a parent can be customized.
Devfile metadata should contains new fields needed to publish it in a registry (the list is shown in the sample)
Plugins should have a mandatory pluginType metadata that allow tools to figure out if they supported the plugin or not. The list of supported types are che-theia-vsx/che-editor/che-theia-plugin/che-theia-extension/generic-service/generic-ui.

Plugin Registry vs Devfile registry
Plugins are devfile too now. Hence we should rename the devfile registry as stack registry.
As a consequence there will be 2 registries (as before) but name differently:

the stack registry: a registry of devfiles to be used as parents
the plugin registry: a registry of devfiles to be used as plugins

Alternatives (rejected for Devfile 2.0.0)
We do not need plugins because we have parents
We may consider to eliminate the plugin concept from the devfile and instead use devfile composition (a.k.a. parents).
registry/uri/kubernetes as different plugins types
For consistency with the Kubernete API spec we may want to use polymorfic plugin type (as we do for components):
  - plugin:
      name: ...
      registryReference:
        id: ...
  - plugin:
      name: ...
      kubernetes:
         ...
  - plugin:
      name: ...
      uriReference:
        uri: ...

instead of
  - plugin:
      name: ...
      id: ...
  - plugin:
      name: ...
      kubernetes:
         ...
  - plugin:
      name: ...
      uri: ...

using parameters in parents
Instead of the simple customisation of a plugin seen above (a la kustomize) we may use parameters to customize some some attributes of a plugin:
parent:
  id: redhat/theia-vsx-stack/latest
  parameters:
    - VSX_LIST: java-dbg.vsix,java.vsix

instead of
parent:
  id: redhat/theia-vsx-template/latest
  components:
    - container:
         name: vsx-installer
         env:
            - name: VSX_LIST
               value: java-dbg.vsix,java.vsix

A couple of questions that have emerged during today discussion:

Is the plugin abstraction in a devfile something that is only interesting for Che, or is it interesting for odo as well? If it's for Che only should it be part of the Devfile 2.0.0 specification?
Is the plugin abstraction something that can be re-used to setup other IDEs workspaces? For instance if a devfile specifies the java plugin can that have a meaning in a VS Code extension context, or in a desktop eclipse context?

We have reviewed and approved this spec today.

question: I assume uri can be relative thus these would resolved both locally on a filesystem or over http/https if loaded there, correct ?

@maxandersen yes that would be possible. But I would not recommend it. That makes dev workspaces not repeatable. It would work on your machine but not on mine.

it would work fine on yours if you have a copy of the devfiles in lets say a git repo. Also makes it easier to develop and do experiments when writing devfile to not have absolute paths  as you can do it locally or just move it to some other directory/server if need be.

that's right @maxandersen, that's an interesting use case we didn't thought about.

Implemented


Any chance to get keyboard shortcuts support?

I am by no means familiar with the electron frameworks. Is it possible to get global keyboard shortcuts support?

It seems possible from a quick search https://electronjs.org/docs/tutorial/keyboard-shortcuts

Oh, I see there is already Gnome media key support. I am going to close this issue.

it does support the gnome media key, macOS media key and touch bar.


Create dataset loader for TSynC2 Corpus

Dataloader name: tsync2/tsync2.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?tsync2

Dataset
tsync2

Description
TSynC2 is a Thai text-to-speech (TTS) dataset from NECTEC. An earlier smaller version called TSynC1 is also available. The dataset is also available for download from the AI for Thai platform.

Subsets
-

Languages
tha

Tasks
Text-To-Speech Synthesis

License
Creative Commons Attribution Non Commercial Share Alike 3.0 (cc-by-nc-sa-3.0)

Homepage
https://github.com/korakot/corpus/releases

HF URL
-

Paper URL
https://lexitron.nectec.or.th/KM_HL5001/file_HL5001/Document/krrn_14518.pdf

#self-assign


TODO(Web)

Create a simple TODO web application

Hello, I would like to take on this issue, may I?

Can i do this?

Sure Try to write clean code

Can I help you in this?

Sure Try to write clean code

Done mate. #72


FIX : Invisible trails for Rectangle and Lines

Title and Issue number
FIX : invisible trail for rectangle and line
Title 👍 #3
Issue No. :
Code Stack :
Close #<issue_no>

Video/Screenshots (mandatory)

Checklist:

[ x] I have mentioned the issue number in my Pull Request.
[x ] I have commented my code, particularly in hard-to-understand areas
[x ] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

@sd012gfhkhhvh  Please review this. Now Its working fine in my system.

@sd012gfhkhhvh Please review this. Now Its working fine in my system.

I tested it locally But it still has defects. Please test it properly in your machine, and put a proper video of 2 users interacting in split screen view.
Though the trails are visible now but it has some crucial bugs -

eraser does not works
elements drawn on by one user vanishes in the other users window when the other user tries to draw something.
HINT - (It's is probably because of clearRect function used under useEffecct, As the other user doesnot have the elements drawn by another user it its own elements array it keeps only the elements drawn by him when you perform the foreach loop)

Try to clean the code a little, I can see two useEffects there with same functionalities. And there are no comments on your changes.


New Import/Export Instructions with TOC update.

Created new file with instructions on how to import and export applications in Configuration Manager. Updated TOC to link to this file.
This is a submission for #MMS2019Docathon

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/Microsoft/azure-docs/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Microsoft/azure-docs-pr/blob/master/articles/azure-portal-overview.md
We have closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions

@aczechowski , can you please review this as well?  @AdamGrossTX tells me it's because they're new files and you need to work some magic before we can include them.

@ChrisKibble yeah, new articles are a bit different. 😄
I can't just open this as there's something awry. I'll wait to review in depth early next week. Stay tuned
But...will still include the commits and lines changed in the contest


Error: Could not find option 'env' in the list of available options: ...

Issue Description
I receive this error in azure pipelines:

[!] Could not find option 'env' in the list of available options: ...

It worked before. The strange thing is that nothing seem to be changed in the project and azure pipelines, just some images updated and version increased. I don't even know where to search for the reason of the error. I can't find what is the 'env' option, and why it broke.
Command executed
fastlane deliver --force -u *** -a *** -i /Users/runner/runners/2.168.2/work/1/s/output/iphoneos/Release/***.ipa -j ios -m /Users/runner/runners/2.168.2/work/1/s/metadata/ --skip_screenshots true -e ***
Complete output when running fastlane, including the stack trace and command used

/usr/local/opt/ruby/bin/gem install fastlane
(node:5844) Warning: Use Cipheriv for counter mode of aes-256-ctr
(node:5844) Warning: Use Cipheriv for counter mode of aes-256-ctr
Successfully installed fastlane-2.148.1
Parsing documentation for fastlane-2.148.1
Installing ri documentation for fastlane-2.148.1
Done installing documentation for fastlane after 20 seconds
1 gem installed
/usr/local/opt/ruby/bin/gem update fastlane -i /Users/runner/.gem-cache
Updating installed gems
Nothing to update
fastlane deliver --force -u *** -a *** -i /Users/runner/runners/2.168.2/work/1/s/output/iphoneos/Release/***.ipa -j ios -m /Users/runner/runners/2.168.2/work/1/s/metadata/ --skip_screenshots true -e ***
[15:10:55]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[15:10:59]: Sending anonymous analytics information
[15:10:59]: Learn more at https://docs.fastlane.tools/#metrics
[15:10:59]: No personal or sensitive data is sent.
[15:10:59]: You can disable this by adding `opt_out_usage` at the top of your Fastfile
[!] Could not find option 'env' in the list of available options: username, app_identifier, app_version, ipa, pkg, build_number, platform, edit_live, use_live_version, metadata_path, screenshots_path, skip_binary_upload, skip_screenshots, skip_metadata, skip_app_version_update, force, overwrite_screenshots, submit_for_review, reject_if_possible, automatic_release, auto_release_date, phased_release, reset_ratings, price_tier, app_rating_config_path, submission_information, team_id, team_name, dev_portal_team_id, dev_portal_team_name, itc_provider, run_precheck_before_submit, precheck_default_rule_level, individual_metadata_items, app_icon, apple_watch_app_icon, copyright, primary_category, secondary_category, primary_first_sub_category, primary_second_sub_category, secondary_first_sub_category, secondary_second_sub_category, trade_representative_contact_information, app_review_information, app_review_attachment_file, description, name, subtitle, keywords, promotional_text, release_notes, privacy_url, apple_tv_privacy_policy, support_url, marketing_url, languages, ignore_language_directory_validation, precheck_include_in_app_purchases, app
##[error]Error: fastlane failed with return code: 1
Finishing: Publish to the App Store Production track

Possibly related: https://github.com/fastlane/fastlane/issues/16461

Soory I opened  issue 16901, instead commenting here. I'm getting the same issue, I have been using this method for the past 2 years without issue. I did log the env in my posting


Extreme differences in execution time from frame to frame

I get extreme differences in execution time with the default setup when running BoTSORT with Yolov5:
0: 480x640 1 person, Done. YOLO:(0.038s), StrongSORT:(0.073s)
0: 480x640 1 person, 1 tv, 1 keyboard, Done. YOLO:(0.038s), StrongSORT:(0.066s)
0: 480x640 1 person, 1 tv, 1 keyboard, Done. YOLO:(0.040s), StrongSORT:(0.044s)
0: 480x640 1 person, 1 keyboard, Done. YOLO:(0.039s), StrongSORT:(9.272s)  ################# !
0: 480x640 1 person, 1 tv, Done. YOLO:(0.039s), StrongSORT:(0.090s)
0: 480x640 1 person, 1 tv, 1 keyboard, Done. YOLO:(0.040s), StrongSORT:(8.932s) ############ !
0: 480x640 1 person, 1 tv, 1 keyboard, Done. YOLO:(0.039s), StrongSORT:(9.535s) ############ !
0: 480x640 1 person, 1 tv, Done. YOLO:(0.040s), StrongSORT:(0.037s)
0: 480x640 1 person, 1 tv, Done. YOLO:(0.041s), StrongSORT:(0.687s) ######################## !
0: 480x640 1 person, 1 tv, 1 keyboard, Done. YOLO:(0.039s), StrongSORT:(0.020s)

Is this BoTSORT's normal behavior? If not, do you have any ideas why this is the case

I identified the slow part. step2 in bot_sort.py. Some example of timed steps:
0: 480x640 1 person, Done. YOLO:(0.045s), BoTSORT:(0.092s)
step2: 0.46398663699999965
step3: 0.0002665390000000656
step4: 6.4769999994496175e-06
step5: 6.332999999969502e-06
merge: 0.00024224299999886512

0: 480x640 1 person, Done. YOLO:(0.044s), BoTSORT:(0.125s)
step2: 0.511612865
step3: 0.00026188500000046133
step4: 4.029000001182226e-06
step5: 4.534000000333549e-06
merge: 0.00018842100000071582

0: 480x640 1 person, Done. YOLO:(0.044s), BoTSORT:(0.225s)
step2: 0.21331869099999956
step3: 0.00011200399999999888
step4: 1.0119999984681272e-06
step5: 1.358000000450943e-06
merge: 0.0001030410000009141

Ok, the camera motion compensation seem to be the issue:
# Fix camera motion
warp = self.gmc.apply(img, dets)
STrack.multi_gmc(strack_pool, warp)
STrack.multi_gmc(unconfirmed, warp)

Hi @mikel-brostrom, this is not normal behavior.
Please try to use the new --cmc-method I uploaded: sparseOptFlow.
Please let me know if it was able to fix this problem.

Sorry for my late response. Just saw that I never responded to this. Yes, this solved the real-time issue. Thank you for your time again.


Bugs in clean_use.py script

The clean_use.py crashes when there is a "use" line without "only", e.g.:
use mpi
Also, during the counting of variables, the commented lines are considered. It shouldn't be the case.

Closed by #16


Unknown header detected while attempting to read CredScan Tsv output

We receive an error when the Sarif report is being build in the pipeline task.
` Detected 1 issue(s) in C:\a\10\s\src\Func.Importer\settings.json
NumberOfAsset : 14
NumberOfAssetScanned : 10
NumberOfAssetBytes : 12,939
NumberOfAssetBytesScanned : 4,670
NumberOfScanResult: 1
NumberOfRankedResult : 1
NumberOfCredentialRecord: 1
NumberOfSuppressedRecord: 0
NumberOfScanError: 0
Scan completed in 6.67 seconds
Tool run time: 6.7779605 seconds
------------------------------------------------------------------------------
Credential Scanner completed with exit code 4
------------------------------------------------------------------------------

Process:
Convert:
Converting any raw tool logs to Sarif format ...
Found 1 logs for tool credscan.
##[error]CredScanTsvUnknownHeaderException: Unknown header detected while attempting to read CredScan Tsv output.
##[error]Actual Header: TimeofDiscovery	Source	Searcher	Description	Line	IsSuppressed	HashKey	SuppressJustification	MatchingScore	Severity
##[error]File Path: C:\a\10\s.gdn.r\credscan\001\credscan-matches.tsv
##[error]MSDO CLI exited with an error exit code: 1
`

This is a bug in MSDO. We have created a tracking item for fixing it. Thanks for reporting.

Hi, any news on this @JiandongJiang ?

This should have been fixed in Microsoft.Security.DevOps.Cli v0.171.1 NuGet package. You can try a rerun which is supposed to get that version automatically, and then let us know how it goes. Thanks.

Great! Can confirm this is solved. Thank you

This issue seems to be back in version v0.174.2, can somebody confirm?


[Bug]: Uncaught TypeError: Cannot convert undefined or null to object

What happened?
I am not able to get the plugin working as the get the error in concole from the js file.
How to reproduce the bug
<?php

namespace App\Filament\Pages;

use Filament\Pages\Dashboard as BasePage;
use JibayMcs\FilamentTour\Tour\HasTour;
use JibayMcs\FilamentTour\Tour\Step;
use JibayMcs\FilamentTour\Tour\Tour;

class Dashboard extends BasePage
{
    use HasTour;

    /**
     * Columns
     */
    public function getColumns(): int | string | array
    {
        return [
            'base' => 1,
            'md' => 2,
            'xl' => 6,
        ];
    }

    public function tours(): array
    {
        return [
            Tour::make('dashboard')
                ->steps(
                    Step::make()
                        ->title("Welcome to your Dashboard !")
                        ->description("hello"),
                    Step::make('.fi-avatar')
                        ->title('Woaw ! Here is your avatar !')
                        ->description('You look nice !')
                        ->icon('heroicon-o-user-circle')
                        ->iconColor('primary')
                ),
        ];
    }
}

Package Version
3.0.0
PHP Version
8.2.12
Laravel Version
10.0.0
Which operating systems does with happen with?

Yes, added to the provider

I am able to add it to a page, but the issue here is on the Dashboard page

Hi, I need an answer please to this

Same problem here on Mac OS, PHP 8.2 and 8.3, can anyone epxlain?

same problem here

Hi !
I'm unable to reproduce the bug, maybe the last release fixed it ? v<IP_ADDRESS>

i have also the same problem for version <IP_ADDRESS>

I'm not getting any error but the Done and the 'X' buttons are not working and they're not closing the tour so there's no way to get out of the tour now.
Same thing for the highlights.


bellpepper-emulated: Fix constant bug in sub_op

Constant elements were not being subtracted properly. Noticed this by calling .neg() on a constant and seeing the result was equal to the input.

Closing, will re-open a better PR with proper tests. This change fails because we're asserting that the bigint is not negative in other parts of the code.


Bugfixes

Just a bunch of bugfixes

Drops :plot:: directives in the custom saving example and properly sets up the :doctest:: directives... Closes #181

Small change to preprocessor so the correct error is thrown when pyDeltaRCM is called from the command line without any arguments. Now the error message thrown if you call >>> pyDeltaRCM without any arguments is ValueError: You must specify a run duration configuration in either the input YAML file or via input arguments. Which is the one we want, so this closes #175

Adds some small doc-strings so that all of our functions now have at least something in the doc-string (#3).

Adds integration test that attempts to cover behavior described in #100. Checkpoint netCDF file pathway has been refactored since that issue, and so I wasn't getting the same error in the integration test. Possibly because now the old netCDF is renamed (so the object isn't messed with), and a new netCDF file is created. Will leave the issue open until we're sure this is no longer a problem.

Pretty minor PR but if you don't mind giving it a once over @amoodie before we merge that can't hurt.

I spoke too soon, looks like I need to implement a fix that will resolve #100 and the failing Windows tests

Just looked at your fix for the preprocessor bug and I agree that that makes sense as a fix. Thanks for smashing like 3 issues! :tada:


Reverse Y Axis Values

Couldn't find anything in the docs, is it possible to reverse the Y axis so values go from high to low instead of the usual low to high?

Currently, no direct option to flip the Y-axis, but can be easily achieved by tweaking the data-values and y-axis formatter.
Here is something I tried by inverting all data-values, then formatting yaxis.labels.formatter
var seriesData = [10, 41, 35, 51, 49, 62, 69, 91, 148];
var inversedData = seriesData.map((s) => {
  return s * -1
})

var options2 = {
    chart: {
        type: 'line',
    },
    series: [{
        data: inversedData
    }],
    yaxis: {
        labels: {
        formatter: function(val) {
            return val * -1;
        }
        }
    }
}

Codepen Demo

Thanks will give this a try.

An option to reverse flip y-axis is added in v3.6.0.
So, now you can just do
yaxis: {
  reversed: true
}

guys @junedchhipa provided correct information. stop down voting it please :)
Source: https://apexcharts.com/docs/options/yaxis/

v3.31.0 and it's not working !

This is wrong answer

An option to reverse flip y-axis is added in v3.6.0. So, now you can just do
yaxis: {
  reversed: true
}

it works well. Thanks


Add SASS file

Converted LESS to SASS styles file.

I think it is not really good to use 2 different preprocessors because it means that we need to maintain them at each change.

@ValentinH the styles are very short and difference between aren't really big so maintaining it is pretty easy in my opinion. Having both LESS and SASS would make users life a lot easier :)

OK, let's wait to see if there are more people voting for this PR. ;)

+1 SASS

:+1:

I'm closing it since the files architecture has changed a lot since this PR. Also, the .less file has changed.
If SASS and LESS are that similar, then it is easy for a user to convert the less file. It will be a mess to maintain both and only one will be used to generate the dist CSS file...

Hi, i think you should think about switching from LESS to SASS than.
Upcoming Twitter Bootstrap 4 CSS framework is moving to SASS:
"Moved from Less to Sass. Bootstrap now compiles faster than ever thanks to Libsass, and we join an increasingly large community of Sass developers."
If i'm not wrong ZURB Foundation 6 CSS Framework also moves to SASS. They use it for Motion UI:
"In preparation for the upcoming release of Foundation for Sites 6, today we're open-sourcing Motion UI, a Sass library for creating custom CSS transitions and animations."
All the big players moves to SASS - let's do the same imo. :)

Why not directly using postCSS? :D
See this post of Bootstrap creator: https://twitter.com/mdo/status/591364406816079873

+1 Sass


setup S3 bucket for extension store

Reopen because of https://github.com/neondatabase/aws/pull/346

neondatabase/aws#352


⚠ GitHub has degraded performance

In 0cd4522, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 196 ms

Resolved: GitHub performance has improved in 82afc8b after 20 minutes.


Update to the latest version of TypeScript compiler, linter, and formatter

Codecov Report

Merging #1958 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1958   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files           1       1
  Lines        4053    4055    +2
  Branches      715     715
======================================
+ Hits         4053    4055    +2

Impacted Files
Coverage Δ

dist/esprima.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dfa42...29fbe9d. Read the comment docs.


Create hwpro2.md

What the program do ?
Prints hello world.
In what programming language it is written?
C

This pull request do not contains files in specific folders. Please fix it and reopen


Remove version: Neemb.Distill version 3.6.6-alpha

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dev-distill-releases.s3.us-east-2.amazonaws.com/web-monitor/alpha/3.6.6/installer/Distill Web Monitor-win32-x64-3.6.6-alpha.exe
Response Error: The remote server returned an error: (403) Forbidden.
(Automated message - build 912)


[Feature request] Hotkeys

It would be nice to have hotkeys for the RBM menu in hex editor (probably also for other stuff).
E.g.:

CTRL+G -> Go to address
CTRL+S -> Save to file

Also the hotkeys should be displayed in the menu items, so it would be easy to familiarize with them.

This feature is already scheduled for the June's release. We plan to have shortcuts for +/- everything and a shortcut editor. And maybe a command palette somewhen in the future ;)

Implemented and merged to master (including shortcut editor).
See https://github.com/codilime/veles/commit/bc0244852ab068ea0c1d2570f5b2f539a97f8fa9 and https://github.com/codilime/veles/commit/ac1a0ec91ed996c63dae1e2e52e2bd8295218992.


Refactor low-level layer operations

This PR refactors the internal functions in layer/handling.rs in preparation of a new Layer API PR. The only public (and strictly speaking breaking) change are the new error enums for writing SBOM and exec.d.
The initial PR that also exposed these low-level building blocked proved to be more controversial than I expected so this PR changed to only refactor the internal bits.
Old PR description
This PR is the first phase for a new high-level Layer API. It exposes the low-level building blocks needed to work with CNB layers. It is not the new layer API.
Why do we need this when we're aiming for a new high-level API?
First of all, that new high-level API needs access to these operations. They were originally written as helpers for the Layer trait API and and needed some adjustments to make them usable in other contexts. I mainly improved error handing and naming. This work needed to be done in any case and this PR front loads these changes in a separate PR for easier review. :)
Secondly, regardless of how great the new high-level API will be, there will always be fringe use-cases where low-level building blocks are needed. Right now, users of libcnb.rs are out of luck if they ever hit these uses-cases. After this PR, we have an escape hatch when a higher-level abstraction (either the current or new one) doesn't work.
Notes for reviewers
Start with the BuildContext changes in libcnb/src/build.rs. This is the newly exposed API for users. Everything else is just supporting changes.
I've broken up the steps I took in separate commits. It might be helpful to refer to those to see how things changed in atomic steps from the original.

@schneems, @edmorley since the exposure of the low-level building blocks seems much more controversial than I expected, those changes have been removed from this PR. It's now only refactoring the internal functions and slightly changes WriteLayerError.
I still think we want to do this eventually (and some of it is needed for the new Layer API), but I want the internal changes merged ASAP to be able to open the actual new Layer API PR.
I will re-request review from you both. :)


[YUNIKORN-875] Fix unit test failures with Kubernetes 1.20.

What is this PR for?
Fixes the unit test failures introduced by upgrading to Kubernetes 1.20 as part of YUNIKORN-872.
What type of PR is it?

[ ] - Bug Fix
[ ] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-875
How should this be tested?
Local unit tests / linters now pass.
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

@kingamarton, @yangwwei can you review?


Add placeholder with quick help on textbox

Quick help about format:

markdown: {tag} will be replaced with value of tag
overpass query: use "{{bbox}}" and finish with "out center body;" not set format ("[out:json]")

As bonus add a way to provide more help ;-)

It's done and will be available in the release to be out those next days.


Add a short description for each teacher

It would describe his/her background, the techs s/he likes working with etc.
It would be nice if we can make it visible on the lesson page.

This is a great idea! It's actually a flat haml file committed to source control. I would love to see someone get this started. You can put in something embarrassing for me too and I will jump in and clean mine up.


Data Explorer incorrectly shows context menu action

The context menu actions in the Data Explorer (Not Object Explorer) incorrectly shows the Properties context menu action, when it's not shown in the Object Explorer:
Context Menu for Object Explorer -

Context Menu for the same table in CMS -

The incorrect context menu shows up in Azure too -

Clicking on the Properties context menu action gives the following error -

Approved in shiproom


[newrelic-logging] Update parsers with fluentbits parsers.conf

Is your feature request related to a problem? Please describe.
The fluentbit parsers.conf includes additional parsers for apache and nginx. I'd like to either update the chart with these, or add the ability to specify custom parsers which would be covered by #75  I believe.
Describe the solution you'd like
The parsers.conf to be updated, or the ability to specify custom parsers
Describe alternatives you've considered

Patching the configmap, however we use Infrastructure as Code via ArgoCD which makes this task much harder.
Using a forked branch. We're doing this now but this means our deployment will likely fall out of date. Would much prefer an upstream solution.

Additional context
I can make a PR for this change. I just need to know whether we'd like to include more parsers by default or omit the parsers and have users specify their own custom ones instead.

Hi @Voziv , we currently just include the necessary parsers to parse logs when using the Docker interface and the CRI interface.
Our DaemonSet collects all the logs emitted by all the pods running in each physical host, without distinguishing them by pod. In order to use the apache or nginx parsers, you'd need to have a way to say "the logs from this particular pod are of type 'apache'". Is this something you do in your fork? Could you provide an example?
Thanks.


Utils functions able to process ndarray of SPD matrices

Using #186, this PR improves other utils functions to process ndarray of SPD matrices, and completes tests.

thx @qbarthelemy


Implement a schema from the Model annotations

Details
The metadata is scanned in by the MetadataScanner.scan method currently. When this happens actually the metadata is loaded into these MetadataProxy objects.
There is the ModelMetadata for the annotated model. The whole thing should be translatable to a representation of a schema.
The types are needed during conversions and the field metadata is needed for the DatabaseAdapters.

Have been getting bogged down in thoughts of refactoring to get this perfect whilst realizing that the current ModelMetadata already has the attributes we need, then in combination we just need the names which were jammed into the Metadata class
It will be easier to just leverage this stuff either post or during scan to create this schema representation.
Then consider a refactor after with working functionality. That strategy has been most successful so far and will be better here too likely.
We just need a Schema object that has all the detail from the Model and all the Attributes which link to the field names. A combo of the names and the metadata annotation is all that is needed. The a list of Schemas will be passed to the adapter on configure and they can be retrieved at anytime from a cache.

Implemented a basic version of this. All schemas are loaded on started up, can find them with Schema.getAll() or by name as Schema.get('User').  Later adjustments to this will be enhancements post release.


Verbose Output/Progress?

It would be nice have the option of verbose output or some indication of progress. I wasn't even sure anything was happening until I opened another console and did iectrl status.

I also thought that it had stalled when trying to install.
Should this be the default mode? and offer a silent option?
Anyway, this is the command that worked successfully for me to see what was happening.
export DEBUG='iectrl:*' && iectrl install


Bump g/g to 1.88.3

We will directly use g/g 1.91.4. Closing this PR, because #6  will be used instead.


[Release-1.28] - Validate resolv.conf for presence of nameserver entries

Backport fix for Validate resolv.conf for presence of nameserver entries

#9874

fixed here
https://github.com/k3s-io/k3s/pull/10302


Weaver does not include public fields in base classes when generating reader/writer

This effects both arguments in functions like RPC and Serialization of MessageBase
public class CreatesForClassInherited : NetworkBehaviour
{
    [ClientRpc]
    public void RpcDoSomething(SomeOtherData data)
    {
        // empty
    }
}

public class BaseData
{
    public bool baseField;
}
public class SomeOtherData : BaseData
{
    public int usefulNumber;
}

The Rpc will not include baseField in the auto-generated reader/writer

Branch: https://github.com/vis2k/Mirror/tree/weaver-reader-writer-base-class

I copy my situation here. I noticed if the row of the class is wrong so it is not working.
Example
public class ResponseMessage : RequestMessageBase
public abstract class RequestMessageBase : MessageBase

So if I use ResponseMessage, so the fields of RequestMessageBase are ignored. But inverted
public abstract class RequestMessageBase : MessageBase
public class ResponseMessage : RequestMessageBase

it works.
First how I use and what I except before I go into the detail. I use first RequestMessageBase  - something like SelectTeamMessage from client and send to server. SelectTeamMessage.responseId will be 1. Server receives and it is correct. The value is 1. Then I send back to client a ResponseMessage and the ResponseMessage.responseId get the value 1 before I send. I see it in the debugger as well. Everything fine there. After I send the msg to client the ResponseMessage.responseId on the receiver (in this case the client) is 0. So it didn't serialized or deserialized. Not sure. All other fields are correct from ResponseMessage. Even the message field has a debug text.
Full code:
This is when it NOT works.
    public class ResponseMessage : RequestMessageBase
    {
        public ResponseState state;
        public bool IsOk => state == ResponseState.OK;

        public string message = "";
        public int errorCode = 0; // optional for error codes
    }

    public abstract class RequestMessageBase : MessageBase
    {
        public int responseId = 0;
    }

Remember. If the abstract class is not under the class ResponseMessage but above ResponseMessage then it works like so:
    public abstract class RequestMessageBase : MessageBase
    {
        public int responseId = 0;
    }

    public class ResponseMessage : RequestMessageBase
    {
        public ResponseState state;
        public bool IsOk => state == ResponseState.OK;

        public string message = "";
        public int errorCode = 0; // optional for error codes
    }

But also if I change and add override myself to RequestMessageBase it is working again (even if its at bottom).
        public override void Deserialize(NetworkReader reader)
        {
            base.Deserialize(reader);
            responseId = reader.ReadPackedInt32();
        }

        public override void Serialize(NetworkWriter writer)
        {
            base.Serialize(writer);
            writer.WritePackedInt32(responseId);
        }

And I checked with ILSpy (without to override)
public class ResponseMessage : RequestMessageBase
{
	public ResponseState state;

	public string message = "";

	public int errorCode = 0;

	public bool IsOk => state == ResponseState.OK;

	public override void Serialize(NetworkWriter writer)
	{
		base.Serialize(writer);
		writer.WritePackedInt32((int)state);
		writer.WriteString(message);
		writer.WritePackedInt32(errorCode);
	}

	public override void Deserialize(NetworkReader reader)
	{
		base.Deserialize(reader);
		state = (ResponseState)reader.ReadPackedInt32();
		message = reader.ReadString();
		errorCode = reader.ReadPackedInt32();
	}
}

public abstract class RequestMessageBase : MessageBase
{
	public int responseId = 0;

	public override void Serialize(NetworkWriter writer)
	{
		base.Serialize(writer);
		writer.WritePackedInt32(responseId);
	}

	public override void Deserialize(NetworkReader reader)
	{
		base.Deserialize(reader);
		responseId = reader.ReadPackedInt32();
	}
}

This looks ok, right? Because it does not look different then when I would use my override.

Re-opening as this still doesn't work with message


PortGroup: make group membership APIs idempotent

Rather than checking to see if a given port is already in a group, just
always transact. The ovsdb protocol already understands set membership
and will happily allow duplicate adds.
Signed-off-by: Casey Callendrello<EMAIL_ADDRESS>

Note: a few gofmt updates in this PR, just view the diff ignoring whitespace.

/cc @anfredette, who added the original API here.

LGTM. @anfredette do you want to take a look?

One concern here is, if this idempotent behavior is abused, it could lead to unnecessary load on the OVSDB server. It would be the user's responsibility not abusing it. Alternatively we can also make it idempotent by checking in the library just like now without sending request to the server, just returning success, but the current implementation of the local check is slow, and the cost is there even for regular operations. So, I am ok for either approach.


Escaped double qoutes are treated as quotes in string properties

Hi and thanks for a great library! I use it to parse rather hefty amount of json in a process pipe (alike) JSON model that I've invented :). Thus i have a set of operation that may take place and need for passing strings.
The problem I've encounter is that it seems to not respect \" as part of the whole string. It rather terminates at the " instead. So for example this expression do not work:
"ODT": "[select(source, \"ObjectName == 'P1 Outs.temp.design'\")]"

When I try to access the property (value.Str) it just gives me back select(source, " and not the whole expression. I use it using a ForEeach like this
	obj.ForEach(func(key, value gjson.Result) bool {
		switch key.Str {
		case "c":
			ass.C = value.Str
		case "e":
			ass.E = value.Str
		case "f":
			ass.F = value.Bool()
		case "d":
			ass.D = value.Value()
		}
		return true
	})

Cheers,
Mario

Hi, Could you provide a working example? I would like to reproduce the bug on my side. Thanks.

@tidwall I think I back down on this
Many thanks for a really good library!


After revert: Defer local updates if there are missing updates and only call GetMissingOnyxMessages once

@danieldoglas
Details

This PR applies back the changes from https://github.com/Expensify/App/pull/38997 after the revert in https://github.com/Expensify/App/pull/39668
Fixed Issues

$
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Take a look on test build 👀

@chrispader Could you kindly elaborate how this PR fixes those deploy blocker issues? Thanks!

BUG: It always redirects to NotFound page after refreshing a page.
https://github.com/Expensify/App/assets/16502320/d047b828-1814-4357-9fbe-e03715b1497b

@chrispader Could you kindly elaborate how this PR fixes those deploy blocker issues? Thanks!

I cannot say if the change fixes the problem, because this seems to only happen on very-high traffic accounts.
I removed this check for invalid update formats, which unpauses the SequentialQueue which might cause the problem

@hungvu193 I think that's an issue unrelated to this PR, it happens on the PR testing domain

@eh2077 @hungvu193 You'll need to try to simulate a situation with a lot of data going on between you. sending lots of messages on groups both of you are and etc.  It's gonna be a tough one to test.

@danieldoglas  Can you create a slack thread to discuss about testing this PR? It would be better

@danieldoglas Can you create a slack thread to discuss about testing this PR? It would be better

i asked about that here: https://expensify.slack.com/archives/C049HHMV9SM/p1712330961862649?thread_ts=1712264151.436019&cid=C049HHMV9SM
@danieldoglas could you check if there are (other) people that have time and can test this with their accounts?

I tried to reproduce this DB issue https://github.com/Expensify/App/issues/39650 but failed to dupe it. I use high traffic accounts.

I tried to reproduce this DB issue #39650 but failed to dupe it. I use high traffic accounts.

@chrispader I managed to reproduce #39650 using two high traffic accounts. It's not stable but I reproduced it by following steps
Preq: Account A on mobile device, Account B on Chrome Web

Send several messages from B to A
Send several messages from A to B
Observed that messages are received normally
Wait a few minutes
Send several messages from A to B
Observed that, from B, the last message is shown in LHN but is not shown in the chat

I tried to reproduce this DB issue #39650 but failed to dupe it. I use high traffic accounts.

@chrispader I managed to reproduce #39650 using two high traffic accounts. It's not stable but I reproduced it by following steps Preq: Account A on mobile device, Account B on Chrome Web

Send several messages from B to A
Send several messages from A to B
Observed that messages are received normally
Wait a few minutes
Send several messages from A to B
Observed that, from B, the last message is shown in LHN but is not shown in the chat

you reproduced this with the current branch still?

@chrispader any movement on this one? What's the ETA?

I tried to reproduce this DB issue #39650 but failed to dupe it. I use high traffic accounts.

@chrispader I managed to reproduce #39650 using two high traffic accounts. It's not stable but I reproduced it by following steps Preq: Account A on mobile device, Account B on Chrome Web

Send several messages from B to A
Send several messages from A to B
Observed that messages are received normally
Wait a few minutes
Send several messages from A to B
Observed that, from B, the last message is shown in LHN but is not shown in the chat

Unfortunately i cannot reproduce this. I see that when sending a lot of messages (from both accounts) the chat flickers and refreshes a lot of times, but in the end i always have the latest updates.
I tested this with two high-traffic accounts on both

device web, 2. device web

device Android, 2. device web

@chrispader Thanks for the update. I'll review and re-test it and post an update tmr.

@chrispader I pulled latest changes of this branch and I caught a different inconsistency - LHN message is not updated. I'm not sure if it's related to this change or it's a different bug.

unfortunately i cannot reproduce any of these issues with 2 high-traffic accounts 🥲
also, i feel like the problems shown in both recordings stem from a different reason, this seems to be related to logic that handles the "New messages" toast and divider line that you can click. Once you clicked it, the content in LHN got updated.

high-level feedback is that this code looks like it could really benefit from some automated test coverage

yes that's true. @danieldoglas and i were planning on creating a follow-up PR which adds tests and more documentation (maybe a flow diagram) that explains this logic even more.

I hear that a lot when I ask for tests on complex PRs: "yes we absolutely should add tests, and that's why we'll do it after", and then about 30% of the time that actually happens.
My two cents: just add the tests. What you lose in time now you'll gain in not having to redo this, and making it easy to add coverage for any edge cases you missed here.

I think this PR was delayed for a long time already, so we can wait one more week on it while adding tests. let's do that @chrispader

I think this PR was delayed for a long time already, so we can wait one more week on it while adding tests. let's do that @chrispader

i'm gonna work on the tests tmrw!

I now added tests for the OnyxUpdateManager. These test the deferral logic inside OnyxUpdateManager with mocked Onyx update application. Is this sufficient, or do we need to also test this E2E with actual Onyx data?
cc @danieldoglas @quinthar

@chrispader I found that tests is failed. Can you take a look?

i'm gonna add a few more "E2E" tests, where we actually apply data to Onyx and run the whole flow starting from applyOnyxUpdatesReliably

@danieldoglas @quinthar @arosiclair i've now also added some broader "end-to-end" test under tests/actions/OnyxUpdateManagerTests, that cover all the logic from calling applyOnyxUpdatesRealiably to the updates being written to storage with Onyx.
These tests also ensure, that the SequentialQueue is paused and the updates have been applied in the correct order.
There are also unit tests in tests/unit/OnyxUpdateManagerTets that test only the logic in OnyxUpdateManager without references/dependencies to other components in E/App. These tests are heavily mocked, which means there are no network calls and onyx writes, whereas we also check for correct values in the deferredUpdates array.
I think this PR should now be ready for a final round of reviews and hopefully merge. Lmk if you think there are any more useful tests or missed edge-cases.

@danieldoglas Can you please apply Ready to Build label again?

Triggering build

@chrispader Can I still use the test branch you mentioned in the test steps? I saw it's a little bit outdated.

bump @hungvu193 @eh2077

I took few tests today, no problem so far, but I still need to take another few tests ti make sure it works
https://github.com/Expensify/App/assets/16502320/72d80f7e-a7c8-4a6e-9447-39b287f6bbb9

Thanks for the ping. It's EOD for me and I'll review and test it early tmr.

Test 2 worked perfectly for me however I found issue with Test 1 where we received Pusher event but the reaction didn't update, please see the video below, mostly at the end of the video.
https://github.com/Expensify/App/assets/16502320/a22fc31e-8f72-4411-a08b-cbd6954c50ab

Precondition: Checkout testing branch
Steps to reproduce:

Create a policy room between 2 users.
User1 send some messages then added few edits and add reactions
Observe update from User2,

Precondition: Checkout testing branch Steps to reproduce:

Create a policy room between 2 users.
User1 send some messages then added few edits and add reactions
Observe update from User2,

hmm, again unable to reproduce unfortunately :/
i did exactly as described in your steps and as seen in your video. I sent a bunch of messages from one user to the other, then in the other direction. Updated messages and added reactions. After a while (because a in the testing branch updates a delayed and some are dropped on purpose) the app is able to fetch all missing updates with GetMissingOnyxUpdates.
Do you have any more specific repro steps? Still curious if this is actually caused by this PR and if i need some special sort of account, to repro this.

@hungvu193 i'm also not 100% sure if this isn't somehow caused by my changes in the testing branch by the way i intentionally drop updates and delay them.

JFYI @danieldoglas @hungvu193 @arosiclair
I'm gonna be OOO from 28/04 until 7-8/04. If we cannot resolve this issue until then, i'm gonna have to hand the PR over to one of my colleagues from Margelo.

@hungvu193 i'm also not 100% sure if this isn't somehow caused by my changes in the testing branch by the way i intentionally drop updates and delay them.

Can you try these steps?

Send message from 1 to 9.
Edit messages 9 to 5.
Wait for all updates to be applied.
Add and remove few reactions
Observer the result

@hungvu193 i'm also not 100% sure if this isn't somehow caused by my changes in the testing branch by the way i intentionally drop updates and delay them.

Can you try these steps?

Send message from 1 to 9.
Edit messages 9 to 5.
Wait for all updates to be applied.
Add and remove few reactions
Observer the result

I saw the timeout, however I waited for few minutes and still didn't see the updated. I'll take another test later today

Ahh i see now what might be the problem in the testing branch. I basically drop every third and fourth update, to simulate missing updates. If one or both of these (omitted) updates are at the end of all the updates, they will never be applied, because there is no later update that triggeres the GetMissingOnyxMessages flow.

In the testing branch in applyOnyxUpdatesReliably if you set the shouldOmitUpdate flag to false, this issue should not happen anymore. Can you confirm that?

you mean shouldRunSync to false right?
https://github.com/Expensify/App/blob/10fc359d9fdd1e05e03a4769e2a73f95e703be51/src/libs/actions/applyOnyxUpdatesReliably.ts#L14

Nice. Seems like this is almost there... @hungvu193 @eh2077 you think we're good to merge this?

Nice. Seems like this is almost there... @hungvu193 @eh2077 you think we're good to merge this?

Sounds good to me 😄

If only resetting deferredUpdatesProxy.deferredUpdates after calling method detectGapsAndSplit, the two tests are also passed.

i'm not sure i understand what you mean. what scneria would resetting deferred updates after detectGapsAnsSplit simulate?
The deferred updates should/can only be reset by the OnyxUpdateManager.
Do you mean we should protect this export, so manipulation from the outside is not possible?

@chrispader thanks for your comment. Sorry, please omit my comments as I overlooked and misunderstood something.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.69-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@chrispader @danieldoglas QA team is blocked to verify this PR, having the following error when trying to run the code snippet in console. Can you please verify internally?

The QA steps shouldn't involve commenting code out, can you guys think of an alternative way to QA this internally please?

@kbecciv Updated the tests

@danieldoglas
This PR is failing because of issue https://github.com/Expensify/App/issues/38748 - there are multiple GetMissingOnyxMessages requests in request tab.
The issue is checked in: Web and Desktop

https://github.com/Expensify/App/assets/93399543/8a3963ef-7d7f-4713-8ee0-f5d1fade9dd0

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

That actually seems correct - it did 3, but one at a time, not 3 at the same time.

@danieldoglas i didn't follow recent conversations 100%, but i think the implementation in this PR is still valid and there's no need to fix anything right now, right?

Yep, this is all correct.


Add config_file_location option

closes elastic/apm-agent-java#701

[x] Implement code
[x] Add tests
[x] Update documentation
[x] Update CHANGELOG.md
[ ] Update supported-technologies.asciidoc

Codecov Report

Merging #750 into master will decrease coverage by 0.57%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##             master     #750      +/-   ##
============================================
- Coverage     64.89%   64.31%   -0.58%
  Complexity       68       68
============================================
  Files           210      210
  Lines          8955     8797     -158
  Branches       1157     1116      -41
============================================
- Hits           5811     5658     -153
- Misses         2784     2787       +3
+ Partials        360      352       -8

Impacted Files
Coverage Δ
Complexity Δ

...nt/configuration/ApmServerConfigurationSource.java
78.4% <100%> (-0.48%)
0 <0> (ø)

...tic/apm/agent/configuration/CoreConfiguration.java
90.63% <72.72%> (-7.1%)
0 <0> (ø)

...in/java/co/elastic/apm/agent/report/HttpUtils.java
50% <0%> (-11.12%)
0% <0%> (ø)

...astic/apm/agent/report/ApmServerHealthChecker.java
89.65% <0%> (-6.9%)
0% <0%> (ø)

...lastic/apm/agent/impl/ElasticApmTracerBuilder.java
72.63% <0%> (-5.31%)
0% <0%> (ø)

...apm/agent/impl/transaction/TraceContextHolder.java
53.19% <0%> (-5.15%)
0% <0%> (ø)

...va/co/elastic/apm/agent/impl/ElasticApmTracer.java
74.05% <0%> (-1.7%)
0% <0%> (ø)

...lastic/apm/agent/impl/transaction/Transaction.java
84.29% <0%> (-0.41%)
0% <0%> (ø)

...astic/apm/agent/impl/transaction/TraceContext.java
90.25% <0%> (-0.17%)
0% <0%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113167e...079131f. Read the comment docs.


$red not found when precompiling assets

In this edit on line 14, red was changed to $red.  When precompiling assets, $red is not defined.

In config/application.rb, I changed...
config.assets.precompile += %w( rails_admin/rails_admin.css rails_admin/rails_admin.js rails_admin/**/*)
to
config.assets.precompile += %w( rails_admin/rails_admin.css rails_admin/rails_admin.js)
and everything went back to working.

application.css:
/*
 * This is a manifest file that'll automatically include all the stylesheets available in this directory
 * and any sub-directories. You're free to add application-wide styles to this file and they'll appear at
 * the top of the compiled file, but it's generally better to create a new file per style scope.
 *= require_self
 *= require "style"
 *= require_directory .
*/

As you suspected.. bad idea.  Still broken for production.

Blah turns out the error being reported is now ckeditor having bad sass markup.  Example: something{ filter;: }
Guess you're not allowed to have no parameters.  So, looks like the rails_admin stuff is good so far.


Split the shared cloud-init metadata by service

Instead of checking the TURBINE_MACHINE env var, it would be nice if each service stack created its own specialization of the cloud-init process.

Solved in branch develop by #161


Progresively interactive NSGA-II

An implementation of PI-EMO-VF (Deb et al 2010) for NSGA-II

This commit breaks NSGA-II with compiled libraries.
File "pymoo/cython/non_dominated_sorting.pyx", line 23, in pymoo.cython.non_dominated_sorting.fast_non_dominated_sort
TypeError: fast_non_dominated_sort() got an unexpected keyword argument 'dominator'

Can you please have a look?

I have quickly added a fix which breaks PI-NSGA-II.
I think the cleanest way might be defining a survival just for the algorithm and modifying dominance there. Happy to look at another PR.


Changed the font properties and footer section

I have changed the font properties like color, weight, etc to improve the readability. Also I have changed the alignment of social links and the copyright to make it look nice.

Hey @shruti8302 , your commit has some conflicts, through which I won't be able to merge, please pull the repo properly and then make required changes and also add reuired screenshots


[#2939] Improve (trino-connector): Trino connector Support retrieve catalogManager object from  io.trino.server.Server.

What changes were proposed in this pull request?
Support building a Trino with  patch https://github.com/datastrato/Trino/commit/93b91791f9148c1885c5fac4d59cd5960feec685
Store the CatalogManager object with a member of io.trino.server.Server.
Why are the changes needed?
Fix: #2939
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Manually test

@yuqi1129 can you please help to review this?

@diqiu50
Please resolve the comments if you have time.


OpenSSL / Default CA issues with latest Rails images

$ docker run -it rails:<IP_ADDRESS> curl -v https://api.outbrain.com
* Rebuilt URL to: https://api.outbrain.com/
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to api.outbrain.com (<IP_ADDRESS>) port 443 (#0)
* successfully set certificate verify locations:
*   CAfile: none
  CApath: /etc/ssl/certs
* SSLv3, TLS handshake, Client hello (1):
* SSLv3, TLS handshake, Server hello (2):
* SSLv3, TLS handshake, CERT (11):
* SSLv3, TLS alert, Server hello (2):
* SSL certificate problem: unable to get local issuer certificate
* Closing connection 0
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

$ docker run -it rails:4.2.4 curl -v https://api.outbrain.com
* Rebuilt URL to: https://api.outbrain.com/
* Hostname was NOT found in DNS cache
*   Trying <IP_ADDRESS>...
* Connected to api.outbrain.com (<IP_ADDRESS>) port 443 (#0)
* successfully set certificate verify locations:
*   CAfile: none
  CApath: /etc/ssl/certs
* SSLv3, TLS handshake, Client hello (1):
* SSLv3, TLS handshake, Server hello (2):
* SSLv3, TLS handshake, CERT (11):
* SSLv3, TLS handshake, Server key exchange (12):
* SSLv3, TLS handshake, Server finished (14):
* SSLv3, TLS handshake, Client key exchange (16):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSLv3, TLS change cipher, Client hello (1):
* SSLv3, TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* Server certificate:
* 	 subject: C=US; ST=New York; L=New York; O=Outbrain Inc.; OU=Operations; CN=*.outbrain.com
* 	 start date: 2014-10-20 00:00:00 GMT
* 	 expire date: 2016-12-18 23:59:59 GMT
* 	 subjectAltName: api.outbrain.com matched
* 	 issuer: C=US; O=thawte, Inc.; CN=thawte SSL CA - G2
* 	 SSL certificate verify ok.
> GET / HTTP/1.1
> User-Agent: curl/7.38.0
> Host: api.outbrain.com
> Accept: */*
>
< HTTP/1.1 302 Found
< Cache-Control: no-cache
< Content-length: 0
< Location: http://www.outbrain.com/?proxy-redirect=1
< Connection: close
<
* Closing connection 0
* SSLv3, TLS alert, Client hello (1):

The version of ca-certificates changed between these two releases:
$ docker run --rm rails:4.2.4 dpkg -l ca-certificates
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name            Version      Architecture Description
+++-===============-============-============-=================================
ii  ca-certificates 20141019     all          Common CA certificates
$ docker run --rm rails:<IP_ADDRESS> dpkg -l ca-certificates
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name            Version         Architecture Description
+++-===============-===============-============-=================================
ii  ca-certificates 20141019+deb8u1 all          Common CA certificates

The latter version no longer has the /C=ZA/ST=Western Cape/L=Cape Town/O=Thawte Consulting cc/OU=Certification Services Division/CN=Thawte Premium Server<EMAIL_ADDRESS>certificate that is the root of trust for the api.outbrain.com certificate.
This appears to be due to an update to version 2.6 of the Mozilla CA bundle. See this ticket: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=807273

Given that the recommended usage for Rails itself is to add it to your project's Gemfile and use bundle to install it, the rails official image has been deprecated as of Jul 5 in favor of using the ruby image directly (see https://github.com/docker-library/docs/pull/503 for more details).
Sorry for the inconvenience!  Since the image will not be receiving anything besides minor maintenance updates (version bumps for example), we're closing out old issues accordingly.  Thanks!