add GitHubPackageMetadataProvider

motivation: continue to implement package collections
changes:

add metadata provider for repositories on github
add tests

TODO

more tests

I'm wondering a bit about the feasibility in practice here since an unauthenticated client can only make 60 requests per hour (see https://developer.github.com/v3/#rate-limiting). We are making four requests per repo which would end up meaning we can only get data for 15 repos per hour, right?

@swift-ci please smoke test

@swift-ci please smoke test

I'm wondering a bit about the feasibility in practice here since an unauthenticated client can only make 60 requests per hour (see https://developer.github.com/v3/#rate-limiting). We are making four requests per repo which would end up meaning we can only get data for 15 repos per hour, right?

this is a very good point @neonichu, I think we would need to include an authtoken in the getPackageMetadata to accommodate for one when we have it

@swift-ci please smoke test linux

@swift-ci please smoke test linux

@swift-ci please smoke test

I'm wondering a bit about the feasibility in practice here since an unauthenticated client can only make 60 requests per hour (see https://developer.github.com/v3/#rate-limiting). We are making four requests per repo which would end up meaning we can only get data for 15 repos per hour, right?

this is a very good point @neonichu, I think we would need to include an authtoken in the getPackageMetadata to accommodate for one when we have it, I'd like to do this in a follow-on PR tho

@neonichu @yim-lee  https://github.com/apple/swift-package-manager/pull/3077


View archived rooms

Or just an admin panel like slack's subdomain.slack.com/admin

+1
@tejasmanohar

+1


add madwallet provider

Hi, Madwallet is a new injected wallet developed by xend.finance.
We want to add madwallet option to official web3modal package.
For more information, plz contact<EMAIL_ADDRESS>

With stable version 2.0.0 of Web3Modal now released, we are officially dropping support for version 1.x
Due to this this issue/pr was marked for closing. It is highly recommended to upgrade as 2.x will be receiving further updates that will enable functionality for some of our newer sdks like auth and push as well as support for WalletConnect v2 (See this post about WalletConnect v1 being deprecated https://medium.com/walletconnect/walletconnect-v1-0-sunset-notice-and-migration-schedule-8af9d3720d2e)
If you need to continue using Web3Modal 1.x and require this feature/fix implemented, we suggest adding it via forking V1 branch.


Brave and multi threading

Hi,
I'm new to distributed system tracing and now going through the code of Brave. I have some doubts about the topic of multi threading in Brave. I would be greatly grateful that someone could provide some hints.
First, in ServletHandlerInterceptor.java of brave-spring-web-servlet-interceptor module, the afterConcurrentHandlingStarted method sets the current span from the binder into the request, what's the purpose of this? In my understanding, in a async request, even if the task is put into the thread pool, the request still holds the span info, there might be no need to add currentspan in request. Thus, I would like to know the role of serverThreadBinder played in async http request.
Second, in brave-core module, there are BraveCallable, BraveRunnable and BraveExecutorService. Where are they used? The README.md says they might be used in scenario where you start a new thread yourself from a request Thread, but is there any implementation of this scenario in this Brave project?
I know my questions are stupid, but it's hard to find hints to resolve them. Hopefully someone can help! Thanks!

Second, in brave-core module, there are BraveCallable, BraveRunnable and BraveExecutorService. Where are they used? The README.md says they might be used in scenario where you start a new thread yourself from a request Thread, but is there any implementation of this scenario in this Brave project?

This can be used for Hystrix calls, which sometimes starts requests in new threads, or in the Hystrix thread pool. Span state is stored in a ThreadLocal, so the state needs to be passed on into the Hystrix call.

@eirslett Thanks for your reply. It helps a lot !~

ps Brave 4.3 includes async tracing for servlet, okhttp and apachehc. You can also do custom things with CurrentTraceContext


Changed from offsetParent to parentElement. Use of offsetParent is a …

…major performance degradation (in IE, any use of offsetParent, offsetWidth or offsetHeight should be used with extreme caution) , it causes document reflow/layout in the browser.
I can't see why this have to be offsetParent, it looks like it is the nearest parent of the element that is the target. If changed to parentElement this would have a positive effect on the initial rendering performance. If all calls to offsetWidth, offsetHeight and offsetParent are eliminated from the initial rendering, the initial rendering time drops by almost 40% in our application.

@c0bra: any thoughts on this?

LGTM


CldVideoPlayer fullscreen object-cover issue

I'm having a challenge getting a full-screen video with object-cover to work with CldVideoPlayer in nextjs 14. I think the styles from next-cloudinary/dist/cld-video-player.css may be causing an issue here. A regular video element works as expected.
The poster image correctly sizes itself, but the video refuses to fill the container.
This is on "next-cloudinary": "~5.20.0"

hey @apetta can you share the code you're trying to use and an example of what you're trying to achieve?

@colbyfayock Sure thing! Here's a repo with the issue
You can see the issue on a desktop viewport.
Desired layout:

With next-cloudinary:

Thank you!

thanks for the example, that was really helpful
i think this is currently simply not supported natively. I'm currently wrapping the player with an aspect ratio'ed container in order to provide better responsiveness and id imagine that's certainly preventing this ability
looking into the issue itself though, the video player uses videojs under the hood, and found some potential solutions here: https://github.com/videojs/video.js/issues/3431
id be happy to rethink that and add this capability, but currently working on wrapping up a major release, so would need to be once im through with that: https://github.com/cloudinary-community/next-cloudinary/pull/407
that said, i think there are two options in the meantime:

you may be able to figure out a hacky solution using absolute positioning or a little javascript to make a video fill its container and hide the overflow

along the lines of:
<div that fills the container and hides overflow>
  <CldVideoPlayer
</div>

or you could use getCldVideoUrl to generate the URL and use the native video tag, though im unsure if there are specific features with the Video Player you're hoping to maintain

https://next.cloudinary.dev/getcldvideourl/basic-usage

yeah im thinking that because im not exposing anything that allows you to modify the video element that won't be possible
yes please, can you create a new ticket for that one?

hey @apetta  did you find a solution? i'm having the same issue right now !

hey @apetta  did you find a solution? i'm having the same issue right now !

Hey, I think I just generated the URL and used a custom video element in the end


Updated README.md

Added Contributors Name

Describe your changes
I have added the contributor's list as required
Fixes #22
Checklist:

[ Yes ] I have performed a self-review of my code
[ Yes ] I have commented my code
[ Yes ] My changes generate no new warnings
[ Yes ] Have you successfully run tests with your changes locally?

@umarfarooq478 are you still working on this issue?

No, I updated this once
On Sat, Feb 18, 2023, 6:45 PM Ashutosh Aswal @.***>
wrote:

@umarfarooq478 https://github.com/umarfarooq478 are you still working
on this issue?
—
Reply to this email directly, view it on GitHub
https://github.com/ken1000minus7/YADA/pull/24#issuecomment-1435672680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWPZAOP7LWKCI3Y4W2IL5PTWYDG7LANCNFSM6AAAAAAU3XQL4E
.
You are receiving this because you were mentioned.Message ID:
@.***>

@umarfarooq478 can you make the required changes? I'll merge the PR soon after that.

Sure
On Sat, Feb 18, 2023, 6:49 PM Ashutosh Aswal @.***>
wrote:

@umarfarooq478 https://github.com/umarfarooq478 can you make the
required changes? I'll merge the PR soon after that.
—
Reply to this email directly, view it on GitHub
https://github.com/ken1000minus7/YADA/pull/24#issuecomment-1435673445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWPZAOPCF66NK6HYVDMTV2DWYDHPJANCNFSM6AAAAAAU3XQL4E
.
You are receiving this because you were mentioned.Message ID:
@.***>


shareReplay with refCount doesn't restart due to unsubscriptions if the source completes first

Bug Report
Current Behavior
shareReplay doesn't restart due to unsubscriptions when refCount is true if the source completes before the subscribers.
Reproduction

REPL

import {interval} from 'rxjs';
import {finalize, shareReplay, take} from 'rxjs/operators'

const sharedSource = interval(100).pipe(
  take(5),
  finalize(() => {
    console.log('The source has completed!')
  }),
  shareReplay({refCount: true, bufferSize: 1}),
);

const s1 = sharedSource.subscribe(x => console.log('subscription 1', x));
const s2 = sharedSource.subscribe(x => console.log('subscription 2', x));
console.log('Two active subscriptions...')

setTimeout(() => {
  s1.unsubscribe();
  s2.unsubscribe();
  console.log('Both subscriptions have been unsubscribed (refCount === 0)')
}, 550)

setTimeout(() => {
  console.log('Creating a new subscription...')
  sharedSource.subscribe(x => console.log('subscription 3', x))
}, 600)

Expected behavior
I would expect to restart the subscription to the source after the refCount has gone down to zero.
Environment

Runtime: Node v12.4.0,
RxJS version: 6.5.5

What you are seeing is the expected behaviour. Once the source completes, that's it. The completion is replayed.

Hi @cartant and thanks for your quick reply.

What you are seeing is the expected behaviour. Once the source completes, that's it. The completion is replayed. If you don't want this behaviour, use share instead.

I really thought that this was a bug. Please notice that in the PR that I've opened all the existing tests are passing and I also added a new one to cover this case.
One of the reasons why I thought that this was a bug is that currently there is a test for shareReplay that states:

should restart due to unsubscriptions if refCount is true

I don't understand why that shouldn't be the case if the source has completed and all the subscribers have unsubscribed. I thought that was the point of using refCount. If that's not the expected behavior perhaps would it be worth it to add a test that makes sure that once the source has completed then the refCount is ignored?
Also, I know how to create my own operator with this behavior, but is there a way that I can get this behavior using share or publishReplay... because I can't think of a way to get that.
Thanks a lot for looking into this.

I don't understand why that shouldn't be the case ...

Look at it this way: if it resubscribes to the source it is not replaying the notifications.

I do understand what you are saying, but another way to look at it could be: when using refCount: true, then if the refCount goes down to zero then it's like nothing ever happened :smile:.
I'm not saying that you are wrong, I'm just saying that's what I expected/wished and when I found a test that seemed to state that, then that lead me to think that this was a bug. Also, what I thought was: if I wanted that behavior, then I would do:
source.pipe(
  publishReplay(1),
  refCount(),
)

I thought that by having the refCount option in the shareReplay operator, then we would be able to get a behavior that's closer to the share operator...
Anyways, well, if it isn't a bug then 2 questions:

Would it be worth it to add a test that removes the current "ambiguity"?
Is there a way to get the behavior that I was expecting by combining other lower-level operators? or should I write my own operator if I wanted that behavior?

Thanks!

Would it be worth it to add a test that removes the current "ambiguity"?

Yes, definitely!

Is there a way to get the behavior that I was expecting by combining other lower-level operators?

Yes: multicast(() => ReplaySubject(1))

Thanks a lot! I'm going to get some rest now and I will send a PR with that test tomorrow. Once again: thanks a lot for being so responsive and supportive!

In the unlikely event that someone else comes here trying to find an operator that behaves the way that I was expecting. The following one is based on what @cartant said in his previous comment:
const reconnectableShareReplay = (bufferSize: number) =>
  <T>(source: Observable<T>) => source.pipe(
    multicast(() => new ReplaySubject(bufferSize)),
    refCount()
  )

This ^ operator makes sure that if the source has completed, when a new subscriber arrives, then the source gets reconnected.
In other instances you may need to have that exact same behavior, but you may not want for the subscribers to complete/unsubscribe when the source completes... Because maybe you want that while there are active subscribers, "everyone gets the same stuff", and only after everyone has "willingly" stopped listening, then we clean things up so that we can re-connect to the source when a new subscription comes. Weird, I know, but I think it can be useful when using RxJs with React.
You could easily accomplish that behavior like this:
const endlessReconnectableShareReplay = (bufferSize: number) =>
  <T>(source: Observable<T>) => concat(source, NEVER).pipe(
    reconnectableShareReplay(bufferSize)
  )

The names of these operators are awful, I'm sorry :see_no_evil:

Would it be worth it to add a test that removes the current "ambiguity"?

Yes, definitely!

Is there a way to get the behavior that I was expecting by combining other lower-level operators?

Yes: multicast(() => ReplaySubject(1))

Hi, this doesn't work for me, and at first, I was very confused on how this should work, but I think what I functionally want isn't really possible, or not that I can find or think of. So if you could provide some help to do the following:
"the source observable must be subscribed once during multiple subscriptions, and re-subscribed when it drops to 0 and a new subscriber subscribes, and for new subscribers, use the last emitted value."
I though that this is what the new shareReplay did, share the source among the subscribers, and use the last value to emit to late subscribers. But that's not the case, because if I understand correctly, the reset on error and on complete, does reset when these events happen when a new subscriber is added, and the reset on refCount doesn't happen when the source completed or has error. I could make sure that the source never errors or completes, and then shareReplay will behave like expected, as it will re-subscribe to the source only when all subscribers where gone, and the first subscribes again. But that doesn't feel right.
So what operators can be used to get this behavior? Or is this not possible, and I have to make sure the observable never errors nor completes?


Ignore .DS_Store files

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md

I am:

[ ] Suggesting edits to an existing Topic page
[ ] Curating a new Topic page
[x] Suggesting another change

This adds .DS_Store to the .gitignore
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

I'd normally say this should be just done in a global ~/.gitconfig but to avoid first-time contributors accidentally submitting these: I'm fine with this.


Crash when not enabling TCP parcelport

Expected Behavior

An error message explaining why things are not OK for the runtime
Explanation in manual which parcelport to enable
A CMake configuration error if this specific configuration is not supported

Actual Behavior
Crash at startup of runtime. See crash.txt
Steps to Reproduce the Problem

Configure HPX with MPI parcelport on and TCP parcelport off
Start a run with multiple localities. I use hpx::init.

Specifications

HPX Version: 1.5.0
Platform (compiler, OS): gcc 10.2.0, openmpi 4.0.4

Remarks

I was under the (possibly wrong) impression that when the MPI parcelport is turned on, the TCP parcelport is not necessary. When building with both MPI and TCP parcelports enabled, my program executes fine.
When using a Debug build, the following assertions fails: src/runtime/agas/big_boot_barrier.cpp:240, HPX_ASSERT(pp);

Thanks @kordejong, this should most likely not happen. We'll look into it (we have some related changes that need to be done as well, which may automatically take care of this: #4924).

@kordejong while working on #4924 I could not reproduce your issue (neither with or without those changes, so my environment is likely different enough). I'm guessing #4924 doesn't fix things for you, but just in case, have you tried latest master? Do you explicitly pass any options to the application to enable or disable the MPI parcelport? How do you launch your applications (slurm, hpxrun, mpiexec)?

I had a second look and this may well be a false negative, possibly because of a wrong set of command line arguments.  It is probably OK to close this ticket. If I run into a crash again, even when using the wrong command line arguments, I will report again.

I had a second look and this may well be a false negative, possibly because of a wrong set of command line arguments.  It is probably OK to close this ticket. If I run into a crash again, even when using the wrong command line arguments, I will report again.

@kordejong Do you remember what command line arguments you were using that caused things to fail?

@hkaiser No, not anymore unfortunately. But I plan to do similar scaling runs as I did some months ago. In case things go wrong I will report again. I now know tcp is not strictly required when mpi networking is turned on, so I will keep the tcp networking setting off when building HPX.

This is still an issue. I am using 1.6.0 now. If I turn on HPX_WITH_PARCELPORT_MPI and turn off HPX_WITH_PARCELPORT_TCP the HPX job crashes when using more than one locality. My command line is very simple:
nr_nodes=2
nr_localities_per_node=8
nr_cores_per_locality=6

srun -N $nr_nodes -n $nr_localities_per_node -c $nr_cores_per_locality python my_script.py

This crashes (same assertion as above). When I build with HPX_WITH_PARCELPORT_TCP turned on, all is well.
I am happy to provide more details.

Using the help from @hkaiser (mailinglist, different but related issue), I now know this issue is due to my srun not enabling MPI correctly / at all. When using mpirun all is well. Sorry for the noise.


Learning Resources Component - Documentation Updates

We need to have the Resources example code updated to show examples of real content to make it easier to understand all the parts. There are also a few things missing from the example.
Missing From the Droplets Example:

Headers (In my mockup they are "Required" and "Recommended"
Long title at the top of the notes section.
Examples of Multiple headers in the notes area.
Examples of Lists in the notes area.

Example Content:

In context:

https://media.uwex.edu/sandbox/bryan/resources_mockup/

The original Document Terry Sent me:

https://docs.google.com/document/d/1xoxdTezIzFfJwzAsOkEMBAMikc988fTW2iEhISK_tBE/edit

long done


pyflow

I was trying to running the davis2016_dataset_with_aug.
Some problems with pyflow.
happened in the file optflow.py
Q1 Why you have args of  (verbose , threshold) in pyflow.coarse2fine_flow Line 143
Q2 What is the function pyflow.warp_mask_flow Line 159

hi @ndschen123 , have you solve the problem?


Update mods

Hello, @ronoaldo
Please can you update the @APercy trike, hydro and demosielle to latest version in the contentdb / commit?
Best reagards
Fábio

CC @APercy

And also add ju52 mod

Hi @farribeiro thanks for the request. I'm updating them all and will have a PR ready soon so we can merge it
I could not find the ju52 mod on ContentDB. Is it only on Github as of now?
For the NSS Helicopter, I'm testing the migration from Git to Contentdb (so we can pin stable releases in Dockerfile). @APercy  do you know if I need to add aliases for that or it will "just works" after the move?

the ju52 stay in development in apercy github... but he maybe request add this mod , then the best way is wait fish the mod and upload to contentdb
Best regards
Fábio


Add Eton results

https://www.facebook.com/share/fFTY2SbXJRXMBzAi/
No idea of format or rules, different division headships sound like separate competitions rather than sandwich boats?

https://www.etoncollege.com/news-and-diary/school-news/eton-bumps-a-rowing-spectacle/

https://therowingclub.wordpress.com/2015/03/20/200-years-of-bumps-racing-by-howard-aiken/

https://www.etoncollege.com/news-and-diary/school-news/highlights-of-the-bumping-races/


Add Stream.repeatEffect/Stream.repeatEffectWith

Stream.repeatEffect should continuously evaluate the effect; repeatEffectWith should use a schedule.

cc @hmemcpy

What the diff with zstream.repeat ?


Support descending search order

According to the official documentation on service-ip-static-sub-range , Kubernetes prefers to allocate dynamic IP addresses to Services by choosing from the upper band.
I've come up with a similar situation, where existing servers are already occupying the lower IP segments, so in order to minimize conflicts, dynamic IP allocation should be in descending order of precedence.
The PR also fix cidr network should ignore NetworkID and BroadcastIP which some cidr network's BroadcastIP  is not xxx.xxx.xxx.255.

Minor nit, but a fantastic addition!

For these changes, I have tested in my RKE2 cluster.


Organize imports

Would be a killer feature!
Although I suppose it is quite a lot of work.

Any progress on this? It would be really nice if we could at least "Resolve and add missing imports from "Not found" errors" since that is the biggest pain point right now when using CommonJS style imports.

Sorry, no progress - I haven't had much time to work on this recently. If you'd like to take a look at implementing this feature we'd love to have the PR.


EPOLL SelectStrategy

Motivation:
NIO now supports a pluggable select strategy, but EPOLL currently doesn't support this. We should strive for feature parity for EPOLL.
Modifications:

Add SelectStrategy to EPOLL transport.

Result:
EPOLL transport supports SelectStategy.

@normanmaurer @daschl - FYI. This PR is dependent on https://github.com/netty/netty/pull/4955.
Only look at the second commit for this PR.


storage-longhorn code access

Hey,
While trying to understand the fundamentals of getting Longhorn to work across multiple nodes (not in a HA multi-host environment, but accessing volumes on other nodes while keeping storage on one host), I realised that the code repo for the storage-longhorn component isn't available publicly.
Is this something that will be released in due course, or will it remain closed?
For reference, the following components have public repositories:
longhorn-ui - https://github.com/rancher/longhorn-ui
longhorn-engine - https://github.com/rancher/longhorn-engine
longhorn-manager - https://github.com/rancher/longhorn-manager
Just missing a crucial part of the equation - storage-longhorn

It's current in a PR for Rancher storage. https://github.com/rancher/storage/pull/49
We're planning to clean it up and get it merged soon.


perf(tangle-dapp): Optimize nomination page

Summary of changes
Provide a detailed description of proposed changes.

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes

Screen Recording
If possible provide a screen recording of proposed change.

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Is this meant to be in draft still?

Is this meant to be in draft still?

@drewstone Commission calculation is pending. Will push in a bit.


feat: scrollbar theme

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

增加了 滚动条的主题 token
修复缩略轴的 label 在 dark 下的字体颜色
文档 close: #3394

Pull Request Test Coverage Report for Build 784653271

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.006%) to 93.491%

Totals

Change from base Build 783027847:
-0.006%

Covered Lines:
10921

Relevant Lines:
11326

💛  - Coveralls


Adding the build&test logic to release-1.0

We need this to get check-in before we are able to turn off run_after_success in the yaml file (run_after_success if blocker to move prow to head binary)
These changes is already in master for at least a couple weeks. We need this changes in release-1.2, release-1.1, release-1.0, and release-0.8.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: icygalz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ldemailly
If they are not already assigned, you can assign the PR to them by writing /assign @ldemailly in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test e2e-bookInfoTests-v1alpha3
/test e2e-dashboard
/test e2e-mixer-no_auth
/test e2e-simpleTests
/test istio-pilot-e2e-envoyv2-v1alpha3

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfoTests-envoyv2-v1alpha3

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests
/test e2e-mixer-no_auth

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-simpleTests

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth
/test e2e-simpleTests

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth
On Tue, Jun 18, 2019, 5:17 PM istio-bot<EMAIL_ADDRESS>wrote:

@icygalz https://github.com/icygalz: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/e2e-mixer-no_auth.sh 051201b
https://github.com/istio/istio/commit/051201b8fe801b8c1b2daa89445cd07502c10736
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/14964/e2e-mixer-no_auth/16868/ /test
e2e-mixer-no_auth
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/14964?email_source=notifications&email_token=AAIKIIK7AGRJTQPGEFTOMLDP3F3KLA5CNFSM4HZCW452YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYAKEXY#issuecomment-503358047,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIKIINTNXDCPUN3O7LWQT3P3F3KLANCNFSM4HZCW45Q
.

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth
I think mixer test has been failing for a while for release-1.0 branch. That's why we made it not required for release process.

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
051201b8fe801b8c1b2daa89445cd07502c10736
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[RESTEASY-2869]:Cache the hasDecorator result in Jackson2Provider

Actually, nevermind, I'm thinking we might want to discuss a general optimization here in another discussion thread.


Fix the issue of tf.divide's return value is not a tensor

This PR fixes the issue of #39475 where tf.divide's return value
is not a tensor in case x, y in divide(x, y) are both primitive python
types.
The reason was that tf.divide relies on implict x / y. However,
if both x and y are not tensor, the return value will fall through
python and will not be a tensor.
This PR fixes the issue.
This PR fixes #39475.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Thanks @jaingaurav for the review and really sorry for the confusion due to lack of comment in code.
The tf.math.divide will compute python style division x / y with output as tensor. Since '/' in tensorflow already registered for tensors (through __div__, __rdiv__ in python2 and __truediv__ and __rtruediv__ in python 3). Eventually they are routed to truediv_python3/_div_python2 with output as tensor.
However, '/' registered does not cover the case where both x and y are not tensors. In that situation, truediv_python3/_div_python2  will not be called and the python 's default '/' will take place. That means the following:
>>> tf.divide(5, 2)
2.5 <= should be <tf.Tensor: shape=(), dtype=float64, numpy=2.5> instead.

So this PR will check for input types, and, in case both x and y are not tensors, call truediv_python3/_div_python2 to enforce the tensorflow to process x / y.
I have updated the PR with comments added. Please take a look and let me know if there are any issues.

Thanks @jaingaurav. That makes sense. I have updated the PR now. Please take a look.

Thanks @jaingaurav for the review. The PR has been updated. Please take a look.

@jaingaurav The PR has been updated now. Please take a look and let me know if there are any other issues.

@jaingaurav Thanks! Let me know if additional update is needed to pass the internal tests.


Cannot login to last.fm

OS: Ubuntu 16.04
Issue Descriptions:

Pressing "Log in to last.fm" changes Not Authorized to Authorization in progress for a second and then comes back to Not Authorized. There is never any prompt to enter my last.fm credentials.
Steps to Reproduce:

Fresh install GPMDP
Login to google account
Enter desktop settings -> Last.FM
Press "Log in to Last.FM"

I have the exact same issue.

@rlach @proxemics Where did you install GPMDP from, if you built it manually or installed it from an unofficial source you will need to provide your own last.fm api keys

I installed it from the official site. though now I'm thinking it might be due to my work vpn/proxy.

@MarshallOfSound I installed it trough Ubuntu Software, which seems pretty official. Only apt would be better on Ubuntu.
After you wrote my version might be wrong I downloaded debian 64bit version from the webpage which works, so the Ubuntu Software version is broken. Installing webpage version fixed some other issues I had, for example I couldn't upload images for albums, because the app had no access to my home folder, non of the icons for desktop player showed(I had blank images everywhere).

The "Snap" version of the app is not maintained by me rather a third party user

I have the same issue. Installed from official Solus repository. It's a fresh install of system. Any ideas how to fix it? Is there any log file where we could see whats happening?

I installed it from git master through AUR on Arch Linux, where do I put my last.fm api credentials?

@MarshallOfSound can you please reopen this? I installed from the download link for OS X.
There are no fields to input last.fm credentials yet there is an Authorize button. It just sits and later will revert to login to last.fm
However no ability to enter my credentials.

Same issue on latest version 4.6.1 on Windows. Maybe a proxy/connection issue.
Is it possible to have a workaroung with API keys (as it's done for listenbrainz authentication)?


 We should correctly truncate labels and append ellipses.

We currently don't truncate labels, and instead refuse to render them outright if they're too long. We should still switch to using ellipses, once Gio has better support for it.


HTTPRoute with RedirectURI feature

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: user
  annotations:
    konghq.com/rewrite: '/requests/users_svc/$1'
    konghq.com/strip-path: 'true'

Not working for HTTPRoutes.
Expected Behavior
According to https://docs.konghq.com/kubernetes-ingress-controller/latest/guides/requests/rewrite-annotation/ I should be able to use the HTTPRoute example provided in the guide and be able to rewrite URI's.
Steps To Reproduce
You can actually use the guide.

Kong Ingress Controller version
3.0.2

Kubernetes version
No response
Anything else?
I enabled the plugin request-transformer and enabled the feature gate with feature_gates: RewriteURIs=true.
I found the working code for Ingress at https://github.com/Kong/kubernetes-ingress-controller/blob/main/internal/dataplane/translator/subtranslator/ingress.go#L629 but could not find any the code for HTTPRoutes.

After considering this approach we decided to go with the URLRewrite from Gateway API. Feel free to take a look at #5853 and comment there.


i18n(pt-BR): Add troubleshooting.md and update ui.ts translations

What kind of changes does this PR include?

[ ] Minor content fixes (broken links, typos, etc.)
[ ] New or updated content
[x] Translated content
[ ] Changes to the docs site code
[ ] Something else!

Description
Adds PT-BR troubleshooting.md page and updates ui.ts with translations for the new entries.

Thanks for the review, @victor0x16!!


the fiters lib has js versions?

i see the kernel code  is not js,
i want to lean it , i can't read the language

The non-JavaScript language bits are GLSL.

@bigtimebuddy Can I implement it using js?

GLSL is the OpenGL Shader Language. It is a language we use to write code that runs on the GPU, not the CPU. Writing it in JS isn't really an option.

@englercj can i use GLSL in node the environment ? i need change the color color for png  in node,because i use PIXI.js in web.

I think you want something like https://www.npmjs.com/package/pngjs

thank all~


Store passwords in secrets for Strimzi

Need a mechanism to store passwords in k8s secrets for strimzi kafkaconnectors

@subkanthi is this available now ?


Naiming pillar out string

the piller panic log message output has changed, used to have the "pillar.out" and now is just "pillar". fix this so the panic stacks can be saved into the /persist/reboot-stack file.

wrong repo to push to

reopen


feat: add base agent

Hello!
This PR aims to add the agent, whose job is:

To execute commands the api provides
To send back the standard output & standard error output to the agent.

Resolves #5 & #6

Hey @sameo :wave:, we did some cleanup on our branch.
You might notice some things:

@Alexis-Bernard's commits are signed with @GridexX and my emails as he forgot to add the -s flag and did not have time to amend the commits himself.
Commits c12f4af to c12f4af belong to PR #9. You should merge this first.

Hey @sameo 👋, we did some cleanup on our branch.
You might notice some things:

@Alexis-Bernard's commits are signed with @GridexX and my emails as he forgot to add the -s flag and did not have time to amend the commits himself.
Commits from c12f4af to 6517574 belong to PR Feature: add base architecture #9. You should merge this first.

I merged #9 now.
For me to review this PR, I need you to:

Rebase it on top of main
Clean your git history up. It's not important to me (the reviewer), or to anyone else looking at this repo git history to know that you fix some formatting issues with e210ec9c09d846a6009130c0ef78e7178e9a72ca, for example. Structure your git history into commits that show how you logically implemented the feature this PR is bringing.

Hello @sameo  We both have Rebase it on top of main and clean our git history up without the fix and chore commits.
The PR is ready to be reviewed :smile:

Here are the fixes, I hope these are okay

Please rebase this PR on top of main. Do not try to merge main back into it. Let me know if you need help with this.

@sameo @WoodenMaiden
I completely rewrite the commits history, and we add your changes with Yann.
4 commits are from @iverly, because they are on our main branch and the PR where the changes were made need to be merged first :+1:


Gevent/Eventlet support

I see that there are no async I/O support yet.
Would you like me to add it?

sure! sorry for this epic delay :D

@thedrow,
Do you have any news on async? Did you plan gevent support as the subject states or the new Python 3.4 Tulip support?

We opted against using nats at the time being so no, sorry. This still should be supported and addressed to.


[Servicebus] test failing in nightly runs

Servicebus nightly test runs are failing with:

Error message
Azure.Messaging.ServiceBus.ServiceBusException : The operation did not complete within the allocated time 00:00:00 for object out-connection998. (ServiceTimeout)
----> System.TimeoutException : The operation did not complete within the allocated time 00:00:00 for object out-connection998.
Stack trace
at Azure.Messaging.ServiceBus.Amqp.AmqpSender.SendBatchInternalAsync(IEnumerable1 messages, TimeSpan timeout, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpSender.cs:line 286    at Azure.Messaging.ServiceBus.Amqp.AmqpSender.<>c.<<SendAsync>b__20_0>d.MoveNext() in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpSender.cs:line 313 --- End of stack trace from previous location ---    at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.<>c__201.<b__20_0>d.MoveNext() in //sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 113
--- End of stack trace from previous location ---
at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 144    at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1,TResult](Func4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken) in //sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 164
at Azure.Messaging.ServiceBus.ServiceBusRetryPolicy.RunOperation[T1](Func4 operation, T1 t1, TransportConnectionScope scope, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusRetryPolicy.cs:line 110    at Azure.Messaging.ServiceBus.Amqp.AmqpSender.SendAsync(IReadOnlyList1 messages, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpSender.cs:line 310
at Azure.Messaging.ServiceBus.ServiceBusSender.SendMessagesAsync(IEnumerable1 messages, CancellationToken cancellationToken) in /_/sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs:line 211    at Azure.Messaging.ServiceBus.Tests.Processor.SessionProcessorLiveTests.CanCloseSession(Int32 maxCallsPerSession) in /Users/runner/work/1/s/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Processor/SessionProcessorLiveTests.cs:line 1759    at Azure.Messaging.ServiceBus.Tests.Processor.SessionProcessorLiveTests.CanCloseSession(Int32 maxCallsPerSession) in /Users/runner/work/1/s/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Processor/SessionProcessorLiveTests.cs:line 1817    at Azure.Messaging.ServiceBus.Tests.Processor.SessionProcessorLiveTests.CanCloseSession(Int32 maxCallsPerSession) in /Users/runner/work/1/s/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Processor/SessionProcessorLiveTests.cs:line 1818    at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter1.BlockUntilCompleted()
at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func1 invoke)    at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)    at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)    at NUnit.Framework.Internal.Commands.TimeoutCommand.<>c__DisplayClass5_0.<RunTestOnSeparateThread>b__0()    at System.Threading.Tasks.Task1.InnerInvoke()
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
at NUnit.Framework.Internal.Commands.TimeoutCommand.Execute(TestExecutionContext context)
--TimeoutException
at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)
at Microsoft.Azure.Amqp.AmqpObject.OpenAsyncResult.End(IAsyncResult result)
at Microsoft.Azure.Amqp.AmqpObject.EndOpen(IAsyncResult result)
at System.Threading.

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1032137&view=results

This was a transient issue.


Cannot specify return type for class constructor

The compiler complains if the return type of a class constructor is not strictly an instance of this constructor. (Since I upgrade from the august version to v20181008).
As javascript allows to return anything from a constructor, the compiler should allow users to specify a custom return type using the "@return" doc.
Just for example if I do:
class Translator
{
    /**
     * Constructor with custom return type.
     *
     * @return {Promise.<Translator>}
     */
    constructor()
    {
        return this.bootstrap();
    }

    /**
     * @return {Promise.<Translator>}
     */
    async bootstrap()
    {
        return this;
    }
}

I don't want to get this warning:
Translator.js:10: WARNING - inconsistent return type
found   : Promise<Translator>
required: Translator
        return this.bootstrap();
               ^^^^^^^^^^^^^^^^

The compiler changed behavior in v20181008 because it switched from transpiling classes before typechecking to natively typechecking ES6 classes.
I believe that restricting what can be returned from a class constructor simplified a lot of the typechecking logic. There are a few other places where the type system is intentionally less dynamic than the JavaScript language, in order to let the compiler do better static analysis.
@shicks (who added support for native class typechecking) is that correct?


Is out-of-bound memory access detection complete?

Miri can detect out-of-bound memory access even with pointer arithmetic. I'm curious about how the detection is conducted while interpreting MIR code, and whether it's complete—meaning a program that passes Miri tests is essentially sandboxed and SFI-safe.
I would greatly appreciate any response and the opportunity to discuss further 😃!

meaning a program that passes Miri tests is essentially sandboxed and SFI-safe.

This is never true. Miri can only detect UB, not its absence. If your program takes user input, any input you didn't test may cause UB and miri never notices.
Usually this means that with lots of test coverage, you'll catch the edge cases, but we cannot guarantee this.

Thanks for the response! Can we narrow it down in this way: Does Miri detect all out-of-bounds memory accesses when the pointer values are not dependent on user input?
I'm a little confused by Miri's claim about such detection and what Ralf said on the Rust Zürisee June 2023—an audience asked about doing I/O via writing to a specific address (on an embedded device) and Ralf said it's not considered UB and not detected.

User input can also change which code paths get excersized.so you could have a code path that does *std::ptr::null::<u32>(), but if your tests don't run that code path, miri doesn't detect it.

doing I/O via writing to a specific address (on an embedded device) and Ralf said it's not considered UB and not detected.

That's a different topic, we just don't support emulating arbitrary embedded memory. You can emulate some of it with miri, but it requires additional work to make it pass miri.

Maybe you could write concrete code examples? I think I'm not answering the question you are actually asking

Miri's detection of out-of-bounds pointer usage is exact. If you manage to execute an inbounds offset operation (such as ptr::offset or ptr::add but not ptr::wrapping_offset which allows out-of-bounds offset) or a read or write through the pointer, then the pointer is surely at that time in-bounds for that offset or read/write.
The detection is exact because Miri knows about all allocations that exist in the program. And in the interpreter, the implementation of pointers stores the numeric ID of the allocation they point to. At any time the interpreter can look up the properties of the allocation that a pointer is valid for, and compare that to the address stored in the pointer. All allocations are done by the interpreter, there's no way to smuggle new memory in, primarily because we haven't gotten around to implementing things like support for calling functions over FFI. When we do support things like that, it will be opt-in because using such features weakens UB detection.

@oli-obk Oh, I think you did! Thanks for telling me that Miri doesn't support emulating embedded memory out of the box. This is good news for me. And yes, the fact that not all execution paths are covered definitely is against what I wish. I'll start doing some testing to get more familiar with Miri.
@saethlin Thank you for explaining how Miri interprets code and governs memory. I believe Miri has reasonable goals, and it makes sense that FFI calling is not a priority.
I have a follow-up question—Miri. I noticed that Miri can use symbolic execution to detect unaligned addresses and remove randomness. Could you please explain how Miri accomplishes this? Specifically, does Miri only perform symbolic execution on memory address alignment? Additionally, if I wanted to incorporate more symbolic checks for out-of-bounds memory access, would it be difficult to do so?

-Zmiri-symbolic-alignment-check does not use symbolic execution, this is a very common misunderstanding. The effect of the flag is documented in the README.
As a demonstration, consider this program which ensures that the *const u16 that it dereferences is aligned:
fn main() {
    let bytes = [0u8; 3];
    unsafe {
        let ptr = bytes.as_ptr();
        let aligned = ptr.add(ptr as usize % 2).cast::<u16>();
        assert!(aligned as usize % 2 == 0);
        dbg!(*aligned);
    }
}

-Zmiri-symbolic-alignment-check will report UB with this warning:
= help: but due to `-Zmiri-symbolic-alignment-check`, alignment errors can also be false positives

And yes, the fact that not all execution paths are covered definitely is against what I wish.

If you want all possible executions to get covered, you may want to look at https://github.com/model-checking/kani, although that is limited around recursion and loops, just like any other model checker or symbolic interpreter

@saethlin Thank you for correcting me! I checked README again and now it's clear.
@oli-obk Awesome! I'll check it out.
I appreciate the discussion a lot!


docs(roadmap): latest roadmap update

Issue number: #3754
Summary
Update roadmap as per new monthly process.
Changes

Please provide a summary of what's being changed

[x] Rename Themes to Key areas as Board is no longer up-to-date
[x] Update key areas with latest updates
[x] Add Launched section
[x] Add Dropped section
[x] Add new Amazon Bedrock Agent resolver for Event Handler
[x] Add enhancement to Parameters to set params/secrets
[x] Update feedback email
[x] Remove Python 3.7 support banner

Unrelated change

[x] Enable content tab link (deep link code snippets)

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca or @sthulb can I get your review please?


AWS::AutoScaling::Errors::ValidationError: At least one Availability Zone or VPC Subnet is required.

aws_auto_scaling_group "appserver_group" do
  launch_configuration 'appserver_config'
  max_size(2)
  min_size(1)
  desired_capacity(1)
  load_balancers(["appserver-elb"])
end

Fails with:
ERROR: aws_auto_scaling_group[appserver_group] (@recipe_files::/home/christine/provisioning/awsgen/aws_mod_v1.rb line 36) had an error: AWS::AutoScaling::Errors::ValidationError: At least one Availability Zone or VPC Subnet is required.

It didn't use to!

@christinedraper  works for me with subnet:
aws_auto_scaling_group 'provisioning-test-auto-scaling-group' do
availability_zones ['us-east-1e']
desired_capacity 2
min_size 1
max_size 3
launch_configuration 'provisioning-test-launch-configuration'
load_balancers 'provisioning-test-elb'
options subnets: 'subnet-x185ba9w'
end

I know it works with a subnet. It used to work without being explicit - at least it seemed to.

Closing based on avail zone being required by AWS sdk.

@christinedraper  Did it work after providing the avail zones?

@Kajalk-k  I think so but it was a very long time ago!


Python 3.5.2

+1. Python 3.5.2
+2. Django 1.11
+3. Nginx 1.10.0
+4. uWSGI 2.0.15
+5. Psycopg2 2.7.1
+6. SSH
** only support remote PostgreSQL, no local PostgreSQL as the site share permission issue

Please submit a PR to https://github.com/Azure-App-Service/python . Also remove Django from the docker image , keep all the other components.


Update release-notes-v6.0.2.rst

Fix URL to the PSMDB 6.0.2-1 release notes.

Doh! I should have been more careful - thanks for capturing my mistake, @nastena1606


I have added more tests and tested them with pytest

Hi,
I have added more stuff to the /test/ folder based on the docstrings  that were originally provided by Mike, skipping functions or modules with missing examples.
Let me know if this is good to go.
Thanks.

These tests look great!!  Good job!

All of the test functions should be in one file. Please consolidate.
The pychache and .DSStore should not be added to the repo. Instructions on how to get rid of them are here:
https://vovaprivalov.medium.com/remove-pycache-files-from-github-repo-fb7220be3415
please add a .gitignore to the PR.

Considering how big these changes are, you may want to close this PR and open a new one with these modifications.


Ensure workspaces show after signing in

Details
We weren't resetting a variable after signing out, which caused policies to not load after signing out and signing back in. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173118#
Tests/QA

Launch web in an incognito window and sign in, confirm that after signing in the user's workspaces show on the Settings page
Sign out and sign back in, confirm that the workspaces show on the Settings page

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web/Desktop

Mobile

🚀 Deployed to staging         in version: 1.0.82-11🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Documentations

Hi,
I saw the videos and they were great but i though a sort of "guide" which can be accessible for others to improve might be useful. So here is the alpha version.

@KenyanGeek thank you so much for providing this. Merging now.

Great!!


emphasize the relevance of seeds for reproducibility

Sometimes even seeds are not sufficient, e.g. with paralellization. Maybe also acknowledge that in some cases exact reproducibility is just hard to achieve and mention the concept of Monte Carlo error?

The parallelization/seed problem has efficient solutions nowadays (cf. the future package). Aaron has put a lot of thought into this already. Should be easy to address. Also, please point to Peikert & Brandmaier (https://qcmb.psychopen.eu/index.php/qcmb/article/download/3763/3763.html?inline=1), where we discuss similar issues.

Remember we had a long section on this in the first draft (including parallelization) and cut it out as off-topic.

OK! If too long, consider shortening it a little.


Double/Float Loss: can we tell to GraalVM that 'loss' is ok?

Hi guys,
I've got a bounce of statistic functions that accept float as parameters. They are coded in Java. Example:
public float differencePerc(final float value1, final float value2) {
  return (value1 - value2) * 100F / value2;
}

When I try to use it with differencePerc( otherFunctionThatReturnsFloat(), 1429.1)
GraallVM returns this error:
invokeMember (differencePerc) on failed due to: Cannot convert '1429.1'(language: Java, type: java.lang.Double) to Java type 'float': Invalid or lossy primitive coercion.

AFAIU, Graal checks if (double) 1429.1 == (float) 1429.1 and decides that there could be a loss in the conversion.
In facts, this Assertions.assertEquals((float) 1429.1, (double) 1429.1);
Returns:
org.opentest4j.AssertionFailedError: expected: <1429.0999755859375> but was: <1429.1>
So I've tried to convert my function to accept doubles:
public float differencePerc(final double value1, final double value2) {
  return (float) ((value1 - value2) * 100F / value2);
}

And it works.
Without rewriting all the functions, why do not support a setting in the Engine that specifies that it's ok with the loss? In this way, all the conversions will run smoothly.

You can specify your own converters through HostAccess of Context. For example,
HostAccess hostAccess = HostAccess.ALL;
Context context = Context.newBuilder("js").allowHostAccess(hostAccess).allowHostClassLookup(className -> true).build();
context.eval("js", "java.lang.Float.isFinite(1429.1)");

fails with the message that you mentioned but when you replace the first line with
HostAccess hostAccess = HostAccess.newBuilder(HostAccess.ALL).targetTypeMapping(Double.class, Float.class, null, x -> x.floatValue()).build();

then the specified conversion of Double to Float is used successfully.

@iamstolis thanks!


[Audius] change youtube-dl to yt-dlp in comment

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

ADD DESCRIPTION HERE
Fixes #
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

If you are making other changes to the function, feel free to add this change to that PR. Otherwise, leave it be


OBS integration

Requirements to arrive.
Some preliminary info: https://github.com/obs-websocket-community-projects/obs-websocket-js

Implemented in v2.3.65


Support Team Issues

We are currently testing the tool and have issues with running the tool  as it appears to fail if the topic list being queried is greater that 100+ and is dependant on the topics an api key has.
For a client the tool would work well but for a support team it would mean creating and maintaining  over 10 new service accounts as we have over 1000 topics which is not practical. We also would prefer more details in the output as we can not risk removing client topics with proper safeguards.
Is it possible to update the code

Resolve the issue with querying large number of topics (may not be possible)

Restrict queries to a list in a file or  topic prefix rather that the access available to an api-key

update the output to include some verification or date last used as well as topic name so we can sort by least active

update the docker image to allow the use of the additional parameter (-idleMinutes) that can be used on the command line

These are all excellent ideas for improvement. I have carved out time in Q1 for improvements in this project, I’m pretty sure these should be able to be implemented. In the meantime, I am happy to take any PRs related to it. If anyone starts working on it please comment here so there isnt duplicate work in Q1.

Thanks for the feedback. The following will be implemented in v1.1:

Resolve the issue with querying large number of topics (may not be possible)
Restrict queries to a list in a file or topic prefix rather that the access available to an api-key
update the docker image to allow the use of the additional parameter (-idleMinutes) that can be used on the command line
- This should be possible by setting an env variable to the docker run now.

I've decided not to implement the extra metadata of the topic in the output. This information is pretty widely available now in multiple monitoring tools for kafka, so it would be redundant work.


Delete By Filter Command

Enhance existing delete command to allow users to specify which entries to be deleted. For example delete s/Applied would delete all entries whose status is Applied.

Fix by #100


Replace enzyme adapter with react testing library

Replace enzyme-adapter for testing with React testing library (RTL) because Enzyme is no longer supported.

Can you provide the pull request?


editor.rulers is ignored

Issue Type: Bug
editor.rulers is entirely ignored. There is always a vertical rule between column 78 and 79.
VS Code version: Code - Insiders 1.46.0-insider (1bfa086adb9271ff56be11821da686e4cfffb672, 2020-06-02T08:10:00.819Z)
OS version: Darwin x64 19.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz (8 x 3100)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
4, 3, 2

Memory (System)
16.00GB (0.91GB free)

Process Argv
-psn_0_614550

Screen Reader
no

VM
0%

Extensions: none

It would help if you included your editor.rulers setting.  And do you get the vertical if you have no editor.rulers at all?

Yes, please share both your user and workspace settings. Thanks!
/needsMoreInfo

@ArturoDent @connor4312 Sure thing, here you go.
Workspace settings is simply:
{
}

My user settings: settings.json.zip
Inside of the user settings, I have (among other things):
    "editor.rulers": [
        100
    ],

If I delete that setting, the vertical ruler between 78-79 disappears, but if I have that present with any value, then the ruler between 78-79 reappears (and no other ruler).

With today's build, everything works, even before making any of your changes. I wasn't in a handlebars file.  🤷♂


can not get the request url to use the storagedriver.UrlFor() interface

User want to get the request Url when use the interface
" storagedrive.URLFor(ctx context.Context, path string, options map[string]interface{}) (string, error)".
The Url is important to distinguish the user's 'pull' or 'push' requst is to private registry or public registry.
The Parameter of "Options" can include the Url of the request.
This interface is called in the blobserver.go like this:
redirectURL, err := bs.driver.URLFor(ctx, path, map[string]interface{}{"method": r.Method})
I think we can call like this:
redirectURL, err := bs.driver.URLFor(ctx, path, map[string]interface{}{"method": r.Method,"url":r.URL.Path})

To speed up the download，we can use CDN . But we need to get the request url,to decide which images we want to use the CDN network.

"The Url is important to distinguish the user's 'pull' or 'push' request is to private registry or public registry."
The only URL that will be seen is for the running registry instance. Blobs can be served via a CDN by implementing a middleware to generate the correct URL.  This is currently done for Amazon Cloudfront.

Thanks！Ineed to get the request url,to decide which images we want to use the CDN network. Pass the url param is not a better way to implement？ But I think it‘s too difficult to add a milddleware for this."storagedriver.URLFor(...)" interface is to generate the correct url,it's much simple that pass the url.

The storage APIs work with paths not URLs and middleware is designed to mirror this API with a reimplementation of the functionality.
Which part of the URL do you require to make the decision with?  Why is the path not sufficient?

I want to get the url to distinguish the user‘s pull request 。 if the pull cmd is to public repo，i will return the CDN url，in contrast，I will return a normal url。It will be easy to get ，if blobserver use the interface that take this url parameter。

Blobs do not belong to individual repositories - they are de-duplicated and referenced from repositories.
Public and private repositories can share the same blob so I'm not sure this approach will work.  Will you store shared blobs locally and in your CDN?

Yeah，i will configure the public  repositories in the config.yml. So, when i get the url ,i wll know which is request the public repositories. If so,i will return a CDN uri to the docker client for download.

My point is that blobs are not private or public, they can belong to both types of repositories.

'i will configure the public repositories in the config.yml'

can you expand on this?

I compelete my own storage driver ,i can configure my storage driver in the config file .In the config file，i will set bucket，chunksize ，accesskeyid and etc. To dinstiguish which image will use the CDN ne, i will config the public repo.
For exampel in configure  config.yml:
accesskeyid:XXX
bucket:XXX
chunksize:XXX
publicRepo:
- "library1"
- "library2"
So when i get users' pull request url like "/repo/ubuntu",i will know which url contains "library1" or "library2"  or others in publicRepo configured.
If the url contains "library1",like "library1/ubuntu",i can return a CDN URI for docker client to download.

OK, I understand now.
The repository name is held within the context which is propagated through to the middleware.  You can access it in your middleware like this
context.GetStringValue(ctx, "vars.name")

OK，Thanks，i will try。


ndim == 2?

When I try to train a convolution layer using torchode, I get the following error.
assert y0.ndim == 2

Doesn't torchode support more than 3d data?

Thank you for the help!


Apply Persistent Subscriptions RFC - 022.

@ylorph samples added!

I'm missing or missed in the sample
CreatePersistentSubscription
ConnectToPersistentSubscriptionToAll ( i.e no manual ACK)
( those are manily to have the correcect samples to point to from the docs )

@ylorph I added the missing create persistent subscription sample.


scoreboard steam names

ive tried looking into the code myself and cannot see anyway i can change the names to in-game usernames rather than showing steam names?

Replace lines:
40 - 52
its:

MySQL.Async.fetchAll('SELECT firstname, lastname, name FROM users WHERE identifier = @identifier', {
['@identifier'] = identifier
}, function (result)
if result[1].firstname and result[1].lastname then
connectedPlayers[player].name = result[1].name
elseif result[1].name then
connectedPlayers[player].name = result[1].name
else
connectedPlayers[player].name = 'Unknown player name'
end
  TriggerClientEvent('esx_scoreboard:updateConnectedPlayers', -1, connectedPlayers)

end)

and
Replace lines 104 - 116
its:

  MySQL.Async.fetchAll('SELECT firstname, lastname, name FROM users WHERE identifier = @identifier', {
  	['@identifier'] = identifier
  }, function (result)

  	if result[1].firstname and result[1].lastname then
  		connectedPlayers[player].name = result[1].name
  	elseif result[1].name then
  		connectedPlayers[player].name = result[1].name
  	else
  		connectedPlayers[player].name = 'Unknown player name'
  	end

  end)


Updated README.rst

Based on the email conversation, pasting the frequent questions people ask.

Sorry for the delay in getting back to you about this.  We actually have an FAQ at docs/source/faq.rst, so if you could update your PR to make the changes there instead of in the README, that would be greatly appreciated.


Docs Menu Vertical Scrolling

This is a Bug Report

Problem:
The menu on the documentation page scrolls vertically on some pages, not all. For example: https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-intro/

Proposed Solution:
#docs #vendorStrip { overflow-y:hidden; }

Page to Update:
https://kubernetes.io/docs/tutorials/kubernetes-basics/explore/explore-intro/

@adrazich This is a great find!! Would you like to fix it? 😄

/kind bug

Happened upon this issue and looked around for the source of the css discrepancy between pages.
What pages show the discrepancy?
This internal scrolling appears on the vendorStrip of all pages under /docs/tutorials/kubernetes-basics/*.
What style is causing the scrolling?
Unlike the other pages, this strip has the css property margin-bottom: 10px on the ul, ol elements:

Unchecking this 10px margin-bottom style in the chrome dev tools removes the undesirable internal scrolling with no visible changes to the page style.
Where is this style attribute coming from?
This property is coming from styles.css:858, which is a Bootstrap v3.3.7 stylesheet. Bootstrap is imported on Line 54262 in/static/docs/reference/generated/kubernetes-api/v1.14/index.html. Since it's one of the last things that's imported, could it be overriding our css resets and styles?
<!-- Line 54260 in index.html -->
</DIV>
<SCRIPT src="/js/jquery-3.2.1.min.js"></SCRIPT>
<SCRIPT src="jquery.scrollTo.min.js"></SCRIPT>
<SCRIPT src="/js/bootstrap-3.3.7.min.js"></SCRIPT>
<SCRIPT src="navData.js"></SCRIPT>
<SCRIPT src="scroll.js"></SCRIPT>
</BODY>
</HTML>

How to fix it?
The source of the style issue is an additional ul, ol {margin-bottom: 10px} property that comes from a bootstrap stylesheet (not in the website source code). I'm not yet ramped up to speed on how the css assets are organized, decided, and compiled for this website, so I don't have an immediate solution.
I can see that all of the affected pages (53 of them --> all tutorials/kubernetes-basics/* in all languages) are doing a unique additional css import:
<link href="/docs/tutorials/kubernetes-basics/public/css/styles.css" rel="stylesheet">

ex: https://github.com/kubernetes/website/blob/master/content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro.html#L12
Running the website locally, I know what doesn't fix this problem. 😅 If you delete <link href="/docs/tutorials/kubernetes-basics/public/css/styles.css" rel="stylesheet">... it does indeed fix the internal scrolling... but removes desired formatting on main parts of the page. Well, had some fun digging around, passing the baton back now!

@daminisatya I would like to work on this.
Thankyou


dice

Hello, how to evaluate dice after the test?

Hello,
You can use the method in https://github.com/himashi92/VT-UNet/blob/main/utils.py#L141 to calculate dice score.


Drag START_RANGE_DAY or END_RANGE_DAY

Hi,
this library is great. It's possible to drag the FIRST_RANGE_DAY or END_RANGE_DAY to extend or reduce the selected days?

Hi,
There is no such functionality in current state and we think that it will be not an easy task to implement with existing architecture.
BR,
Applikey team


Deployment fails with python >= 3.12

The CD step deploying to conda fails due to a missing import imp
https://github.com/payu-org/payu/actions/runs/7382868756/job/20083209964#step:4:399
  ModuleNotFoundError: No module named 'imp'
  WARNING: Tests failed for payu-1.0.30-py_0.tar.bz2 - moving package to /usr/share/miniconda3/envs/test/conda-bld/broken
  TESTS FAILED: payu-1.0.30-py_0.tar.bz2
  export PREFIX=/usr/share/miniconda3/envs/test/conda-bld/payu_1704176755527/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl

This appears to be a problem with python >= 3.12 due to that module being missing/deprecated
https://github.com/MultiQC/MultiQC/issues/2112

This could have been avoided if the CI includes the conda package build steps, and CD just installs the produced artefact.

Would be keen to add the package build as a CI step as a later, non-bandaid solution. Right now, to get the releases out the door, pinning the version of Python used to 3.11 will be good enough.


Create a random file for easyrsa rng

What's the need for this, can you provide some justification? I'm not familiar with the need.


MWPW-156810: adding caas config change for live CTAs

As a Virtual Events Product Manager, I want to have a way for a different destination (e.g anchor link) and CTA copy when an event card is live so that when we use event cards to promote the upcoming homepage schedule, a click to the card will take the user to the specific destination (specifically to the marquee video player on the homepage).
This PR adds the configuration change necessary to facilitate the above in CAAS.
Resolves: MWPW-145727
MWPW-156810
Test URLs:

Before: https://main--milo--adobecom.hlx.page/tools/caas?martech=off
After: https://MWPW-145727--milo--sheridansunier.hlx.page/tools/caas?martech=off

@sheridansunier is out on PTO and will be back on 08/20 and add fix then (she doesn't have access to internet on her PTO):
The fix she needs is this:

@sanrai you could close this PR and open a new one

to clarify it was "reliable access to internet on her pto" - @mokimo the unit tests should be fixed now


Library not found for libPods-TwilioVideo-VideoQuickStart

I am trying to use the quick start video for iOS example.
When I try to build from within XCode, I get the following missing library:
ld: library not found for -lPods-TwilioVideo-VideoQuickStart
clang: error: linker command failed with exit code 1 (use -v to see invocation)
I was able to successfully run
pod install
however, I got error with
pod repo update twilio
Unable to find the twilio repo.

figured out. I was trying to run the individual project. You have to run through the main root directory


Expose typings for Plugins

I think it would be helpful to expose the Instance type so plugins can type the argument (https://vue-test-utils.vuejs.org/v2/guide/plugins.html#writing-a-plugin) as well as adapting the install function to infer the options parameter:
    install(handler: (instance: Instance) => Record<string, any>, options?: Record<string, any>): void;

Similar to https://github.com/vuejs/vue-next/pull/2758

Oh cool, this is a good idea. I will give this one at try.

Just to confirm @posva, are you referring to

plugins as in app.use, so basically just do the same as #2758
as opposed to the plugin system that only exists in VTU for extending wrapper? (I don't see what you mean if you are referring to VTU plugins, which we should probably rename extensions to avoid confusion with Vue plugins

Edit: Seems VTU plugins was not actually working properly in the first place, fixed: https://github.com/vuejs/vue-test-utils-next/pull/276
Are you using this for the mock router? Sorry I did not have time to work on that lately... :(

the plugin system that only exists in VTU for extending wrapper (which you linked to)?

Yes!
Specifically, one should be able to do something like this:
function myPlugin(wrapper: Instance, options: { n: number }) {}

// @ts-error
config.plugins.VueWrapper.install(myPlugin, {n: true})

That's why I was referring to https://github.com/vuejs/vue-next/pull/2758/files

Cool, I can update the typings on top of #276.
No problem, I will try test the mock router soon (or have a hack on it if it's not ready yet).

Sorry for the delay! I submitted a PR
I'm finishing up an initial 0.0.1 version for the mock but at the end I don't think I need even need the plugin API. But It could be useful in the future to add functions to the wrapper or even the router!


Event API serializers imporvements (closes #1376, #1396)

Implemented #1376 and #1396 issues

I'm not sure. @ElviraMiro probably knows.

@mod It should be merged ASAP. I remember she said they need it for react things

@rxx We need the same PR for master branch

@rxx can you make the PR on master?


Let mapToProps optional

This PR add a new funcionality to connect HOC, to return all state as props when mapToProps function is not passed.

It's awesome to have you here, @fdaciuk
Just two things before I can merge:

Please add the changes to changelog file
Please bump the npm version to 4.2.1

Thanks 💯

Nice @matheusml! Thanks :heart:
Done ;)

@malbernaz could you please also check if this is ok, before I can merge?

It looks good :ok_hand:. I'm ok with it


OpenAPITools generators produce Helidon 3 projects that won't compile

I tried the latest generators (as of Tim's commit 3e0dad4ce3f17511660a59b5f0a0ce61373de275) and if I use helidon 3.0.1 then three of the four generators create projects that fail to compile because of the javax -> jakarta java package change. The failing generators are:

[ ] Server MP
[ ] Server SE
[ ] Client MP

Client SE is OK.  To reproduce:
java -jar ${OPENAPIWS}/modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g java-helidon-server --library mp -i ../../quickstart-openapi.yaml  --additional-properties "helidonVersion=3.0.1"

mvn clean install
. . .
[ERROR] /Users/jdipol/tmp/openapi/3.x/server-mp/src/main/java/org/openapitools/server/api/DefaultServiceImpl.java:[18,24] package javax.ws.rs.core does not exist
. . .

In this case I used the openapi spec produced by the Helidon MP Quickstart. But I imagine any of the test specs will reproduce the error.

Although many (all?) of the relevant templates use the tag rootEEPackage as a prefix for various generated import statements, our Java code neither sets rootEEPackage according to the effective Helidon version (if the user did not explicitly set the package) nor does it check that the user didn't specific an invalid value for it. (Although we do not advertise this setting, users could specify it on the command line so we should check for that.)


Add fibonacci in kotlin

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy

Some things regarding contributing has changed. Please read them carefully once again in the Contributing.md doc.
You're just another step away for your contribution,
Happy Coding!!
Happy Contribution!!

Hello, here are the print screens as asked. Had to split in 2 in order to get 100 members.
Also noticed there were an error in the logic, which I fixed :)

Great! Thank you for your enormous contribution.
Feel free to add your name in the contributors.md doc and add the language under the languages.md doc.
Once these are done just comment here. I'm ready to accept your PR.
Once again, Thanks for your sincere effort.


Ziechael: Adding HeroQuest and Risus character sheets

The html file for Risus is labeled as a .txt instead of .html. Once you fix that just update it and let me know and  I will be able to merge it in

Thanks Ryan, that'll teach me to learn how to use github while in a meeting!


annulus fibrosus

add new term abnormal annulus fibrosus morphology
child of abnormal intervertebral disk morphology
def: any structural anomaly of the sturdy tire-like structure consisting of water and sturdy elastic collagen fibers that encases the gel-like center of the disk
ref: https://www.coloradospineinstitute.com/education/anatomy/intervertebral-discs/
see J:224002, also other annotations

MP:0021153


docs: Update audit examples

Due to a change in how config is unmarshaled, the defaults are not
correctly being set. Until that issue is fixed, we need to update the
examples to instruct the users that they should explicitly set the
accessLogsEnabled and decisionLogsEnabled settings.
Signed-off-by: Charith Ellawala<EMAIL_ADDRESS>

👍

Codecov Report

Merging #950 (ff7d77a) into main (6ba9dd9) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
+ Coverage   54.47%   54.68%   +0.20%
==========================================
  Files         106      106
  Lines       11440    11440
==========================================
+ Hits         6232     6256      +24
+ Misses       4683     4661      -22
+ Partials      525      523       -2

Impacted Files
Coverage Δ

internal/audit/conf.go
70.27% <ø> (ø)

internal/audit/local/badgerdb.go
63.80% <0.00%> (+0.63%)
:arrow_up:

internal/engine/engine.go
73.69% <0.00%> (+0.78%)
:arrow_up:

internal/storage/index/builder.go
84.35% <0.00%> (+5.02%)
:arrow_up:

internal/compile/errors.go
55.55% <0.00%> (+15.87%)
:arrow_up:


Query pushdown to prometheus with external labels doesn't work.

When query_pushdown is enabled on our thanos-query pods it results in no data from valid queries if the inner query contains external labels.
For example if we have the following external labels:

cluster
prometheus

and this query:
max by (horizontalpodautoscaler) (
    kube_horizontalpodautoscaler_spec_max_replicas{
    prometheus="monitoring/monitoring",
    namespace="test",
    cluster="cluster-a")
 }

When executed via thanos-query we get no results back, but if we remove the external labels from the query, we successfully get results back. Disabling query_pushdown resolves the issue.
My theory is that the sub-query in side of max() is getting pushed down to prometheus verbatim and prometheus does not know how to handle the external labels but I have not been able to prove it.
thanos version: v0.28.0
prometheus version: v2.38.0

This is a duplicate of https://github.com/thanos-io/thanos/issues/5630


[BEAM-6857] Recategorize UsesTimerMap tests to ValidatesRunner

NeedsRunner tests are not run against all runners so we need to
recategorize those to validate runners implementation.

 Unfortunately due to a bug in the test description (one I didn't catch in code review), the test never ran on Dataflow.


BUGFIX: invalid landing page link when filter-extension is enabled

There was a unnecessary method: "GET" added to the queryable link in the landing page

CI is failing but will be resolved with next stac-pydantic version

@jonhealy1 this is now ready for review 🙏


docs: use more beta-like language in readme

What I did
I noticed this disclaimer still references the alpha
I tried to update it to make it sound more beta.
How I did it
Adjust language to be less severe than the alpha.
How to verify it
Read it, give feedback.
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

make it sound more beta.

lel


added link to IntelliJ IDEA plugin

Description of changes:
added link to IntelliJ IDEA plugin
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Great, but I cannot find it in IDEA. Do I need to do something special?

Cool, he built it! 👍  Lekker 🎉
It's incompatible with my PyCharm CE installation, can I drop a feature request somewhere @mvanholsteijn ? 😉

I am not quite sure why it does not show up in your versions of IntelliJ. The plugin states that it supports build versions since 145.
Perhaps  you can try a manual install?
Download from https://github.com/binxio/cfn-lint-plugin/releases and following the
https://www.jetbrains.com/help/webstorm/2016.1/installing-plugin-from-disk.html?origin=old_help


Rotation loses data

testing this code with sleep works, but without sleep, it's losing the file that should contain "1"
dir, err := ioutil.TempDir("/tmp", "testrotation")

if err != nil {
	log.Fatal(err)
}

fmt.Println(dir)

tmpfn := filepath.Join(dir, "tmpfile.txt")
logger := &lumberjack.Logger{
	Filename:   tmpfn,
	MaxSize:    1, //rotate logs if it reaches 1 megabyte
}

log.SetOutput(logger)

log.Println("1")
logger.Rotate()
log.Println("2")
time.Sleep(2000 * time.Millisecond)
logger.Rotate()
log.Println("3")

So, this is a bug, technically.  But in reality, it's not something that should ever get hit.
The problem is that the backup files are expected to always be unique because of their timestamp.  However, the timestamp only has millisecond resolution.  If you rotate the file twice during the same millisecond, then both backup files will have the same name, and you'll end up overwriting the first one.
This could be mitigated by changing the resolution of the timestamp to go down to the microsecond or even nanosecond resolution.... however, in a real system, you'd basically never actually rotate logs twice in the same millisecond.
If this is actually causing a bug in production code, I could change the timestamp, but this is non-trivial, since we have to be backward compatible with existing backup files that use the old timestamp.
Thanks for bringing this to my attention. While I don't think anyone would actually hit this in production, it is something to think about for any future iterations.  And again, if this actually causes problems with you code, please let me know and I will fix it.


Add a "Wihdraw Submission" button for profiles in vouching phase

withdrawSubmission() fucntion does not have a button in the UI.

Let's add a button on the bottom left in vouching phase profiles (where "Challenge Registration" button is for Pending registration profiles).

Done.


A is not focusable in Firefox

Describe the bug
When using the A component from solid-router, I can't focus the rendered anchor element properly via keyboard. Pressing Tab jumps over the anchor as if it was non-focusable. This issue only happens in Firefox, not Chromium-based browsers.
Your Example Website or App
https://stackblitz.com/edit/solidjs-templates-7joygr
Steps to Reproduce the Bug or Issue

Open the example in Stackblitz in Firefox
Click into the first input on the page
Use your Tab key and try to focus the below anchor element

Expected behavior
As a user, I expect to be able to focus all anchor elements rendered by solid-router, no matter the browser.
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Firefox
Version: 109

Additional context
No response

It looks like this is intended behavior for Firefox on macOS. https://stackoverflow.com/a/11713537
I have both a Windows 11 device and a MacBook Pro. I tested your Stackblitz with Firefox on both machines and found that the A tag is focuseable on Firefox on Windows but not on Mac. Below is a screen recording of my test.
https://watch.screencastify.com/v/iAW4GlP4y1yAmY8yY8Y3
After following the instructions on ths StackOverflow link, I was able to get A tag focusing to work.

Interesting, thanks for the update. I have to work with macOS due to my company, usually I am more familiar with Linux and didn't know this. I'll close the issue then.


Several RPC calls invalid Params

I have a local network setup and the nctl-view-faucet-account call works.
Also deploy tests from the keys-manager seem to work.
However several calls in the CasperServiceByJsonRPC seem to return no data.
To investigate this, I have setup a test client that calls the getBlockInfoByHeight(1) first and then the getLatestBlockInfo().
getBlockInfoByHeight(height) behaved as expected, however when calling getLatestBlockInfo() an JsonRPC "invalid parameter" error is thrown and the length of the data received is 0.
(Working steps and Errors attached)
The getBlockInfoByHeight() function returns a result from the request, which makes sense and seems to work.
So shouldn't the getLatestBlockInfo() be doing the same?

I am also having issues with calls returning no data.  Any updates on this?

I am now not getting any results from any calls using CasperServiceByJsonRpc client.  I am getting CORS errors and 'failed to fetch' errors tracing back to casper-js-sdk/dist/lib.js.  Please is there any updates for this issue?  It began after the casper testnet went down a few weeks ago and came back live.


Update TFRecord.jl to work with julia 1.7+ and ProtoBuf v1.0+

Hello, I have updated the package to work with new versions of the dependencies, in particular ProtoBuf.
The test cases are passed successfully, but please check that Tensorflow can read the tfrecord files properly before merging. Have a good day!

Codecov Report

Merging #26 (dbb70b0) into master (d043a43) will increase coverage by 3.61%.
The diff coverage is 47.16%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   53.26%   56.88%   +3.61%
==========================================
  Files           2        2
  Lines         306      276      -30
==========================================
- Hits          163      157       -6
+ Misses        143      119      -24

Impacted Files
Coverage Δ

src/jlout/example_pb.jl
44.22% <43.15%> (-7.26%)
:arrow_down:

src/core.jl
89.61% <81.81%> (+30.19%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks!
Just realized that ProtoBuf.jl@v1 released.
I modified this PR slightly to keep it working on v1.6


haskellPackages.ghc96.singletons-base: unbreak

Description of changes
Just saw that my previous singletons fix didn't have any impact on hydra as hydra runs on GHC 9.6. This change also fixes singeltons-base on 9.6.
@maralorn why is hydra only running ghc 9.6. Can we also do CI runs with 9.8?
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why is this override in the 9.6 specific file? Wouldn’t it make more sense to do this override once in configuration-common.nix?

@maralorn why is hydra only running ghc 9.6. Can we also do CI runs with 9.8?

Because build capacity is limited we only build and maintain the most essential packages on the non-default ghc versions (currently 9.6). We can opt-in to more jobs for some packages if there is a good reason.

singletons-base relies on GHC internals. So often times the versions are broken for different reasons. E.g. the version that is compatible with ghc9.6 has issues with the test suite. The version with ghc9.8 has a working test suite but had other issues (addressed in the previous pr)

Hm, hm. Not super exited about the dontCheck without a comment, but let’s not waste more cycles on this …


Debug Banner is turned on

IMO we don't need to fix this, a debug build is a debug build and that's what the indicator shows no harm in showing it when developing, plus point if we ever ship a debug build we would be able to figure it out much more easily