add "status" to the request details page

Issue Reference
This PR addresses the Issue : Fixes # 635.
Display 'status' field data on request page
Summarize
Please, describe what the PR does, the changes you have made.
Add another row to the request details table to display the status of a request.

Also, mention the key points if any to look into while code reviews

Code looks good

@biswaz, @syam3526  Please have a look

is the Status field being actively updated? I have not seen any page that lets the user update the status of a request. Kindly clarify and I will then merge this one.


Unable to add custom twig loaders

Ticket: https://github.com/timber/timber/issues/1253
Issue
Unable to add custom twig loaders.
Solution
Add a new filter (hook), that exposes the Twig_Loader_filesystem that TImber creates. This allows theme developers to modify this or add their own loader and create a new loader chain.
Impact
This fix is additive, and therefore should be backwards compatible. It's also possible that developers could not return the correct thing in the filter which could cause unexpected behaviour. I'm not sure there's much value in trying to defend against this though.
Usage
An example use case:
namespace App;

// Hook into when Timber initialises the Twig_Loader_Filesystem
add_filter('timber/loader/loader', function ($loader) {
    $customLoader = new \App\CustomLoader(get_stylesheet_directory() . '/views');
    // Add our loader to the end of the chain (i.e. Timber does its lookup, then runs ours)
    $chainLoader = new \Twig_Loader_Chain([$loader, $customLoader]);

    return $chainLoader;
});

class CustomLoader implements \Twig_LoaderInterface
{
    // Base path for patterns lib.
    protected $patternsPath;

    public function __construct($patternsPath)
    {
        $this->patternsPath = $patternsPath;
    }

    /**
     * Gets the source code of a template, given its name.
     *
     * @param  string $name string The name of the template to load
     *
     * @return string The template source code
     */
    public function getSource($name)
    {

        // Remove the extension at this point as we add it ourselves below
        $id = preg_replace('/\.twig$/', '', $name);

        // Add template.twig into path
        $path = $this->patternsPath . '/' . $id . '/template.twig';

        return file_get_contents($path);
    }

    /**
     * Gets the cache key to use for the cache for a given template name.
     *
     * @param  string $name string The name of the template to load
     *
     * @return string The cache key
     */
    public function getCacheKey($name)
    {
        return md5($name);
    }

    /**
     * Returns true if the template is still fresh.
     *
     * @param string    $name The template name
     * @param timestamp $time The last modification time of the cached template
     */
    public function isFresh($name, $time)
    {
        return true;
    }
}

Considerations
This solution simply exposes the loader, which allows people to do a lot more. Another approach may be to let Timber handle the Twig_Loader_Chain and just expose an addLoader() method or something similar. However, that feels less flexible and scaleable.
Testing
Sorry, no tests written. An example test could be something like:
function testTwigLoaderFilter () {
    $php_unit = $this;
    add_filter('timber/loader/loader', function ($loader) use ($php_unit) {
        $php_unit->assertInstanceOf('Twig_Loader_Filesystem', $loader);
    });
    $str = Timber::compile('assets/single.twig', array());
}

Coverage increased (+0.001%) to 96.108% when pulling 6431487e36b2326af542f893a7832b8509277fcc on Rareloop:master into 2a0b07c46df8c980cf393b5e2f5d56f1e3d14cad on timber:master.

Current coverage is 96.33% (diff: 100%)

Merging #1254 into master will increase coverage by 0.01%

@@             master      #1254   diff @@
==========================================
  Files            44         44
  Lines          3173       3189    +16
  Methods         424        425     +1
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3056       3072    +16
  Misses          117        117
  Partials          0          0

Powered by Codecov. Last update 2a0b07c...6431487

timber/loader/filesystem sounds better than the timber/loader/loader..?

I would agree.
My original thinking was that the filesystem was only one type of loader. You could in theory have a database loader. So I tried to keep the name generic - but actually timber/loader/filesystem better describes what is actually going on, i.e. the filesystem loader is being exposed.

For database loader I would have event timber/loader/database just because of people start assuming that loader is always of the same type and when it gets changed -- plugins will stop working.
It would be nice to have chain loader in the top, though :)

Been thinking about the name change this morning & I think I disagree with timber/loaders/filesystem now.  Timber has a method called get_loader() which currently returns a Twig_Loader_Filesystem. But Timber, as far as I know, doesn't care that this loader is the filesystem; the only thing it cares about is that it implements Twig_LoaderInterface.
The fix in this PR allows developers to:

overwrite the filesystem loader with their own
create a Twig_Loader_Chain with Timber's filesystem loader and any additional loaders

Maybe the method needs better naming:
// ...
$loader = new \Twig_Loader_Filesystem($paths, $rootPath);
$loader = apply_filters('timber/loader/loader', $loader);
return $loader;

@adamtomat Thanks for the PR! I'm sympathetic to the idea that timber/loader/filesystem is much prettier, but given your reasoning and @mahagr's, it makes sense that accuracy is the most crucial guiding factor at this "deep" level. Merged!

also, extra special points for the little test you put in your notes. I added it to PHPUnit so we can make sure loader/loader works well into the future

Forgot to reply earlier: I'm fine with loader/loader.


Fixed if condition in submit standard form

We removed the admin code (and handled it in BE instead), this was forgotten in the PR

It was causing the form to create a new admin each time the form was submitted


Small unexpected margin

I'm new to Flutter so maybe I'm not doing things properly, but I'm getting a tiny unexpected margin for a specific case. When I have a Column with more than one child that have a color and a Padding as their child, a ~1px margin is drawn between the Containers.
Here's an example:
class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Column(
        children: <Widget>[
          Container(color: Colors.black, child: Padding(padding: EdgeInsets.all(50))),
          Container(color: Colors.black, child: Padding(padding: EdgeInsets.all(50)))
        ],
      )
    );
  }
}

This example displays 2 black boxes with a tiny line shown between them. I know this example is not typical since both containers have the exact same background color, but I noticed this issue with two different colored Containers. I am testing on Android Pie.
Edit: Using a Container or SizedBox instead of the Padding also shows the margin so it's not as specific as I thought.

This is a known problem with antialiasing and mapping from logical pixels to device pixels. There's an open issue for a documentation fix: https://github.com/flutter/flutter/issues/14288
More info about the problem can be found here:
https://github.com/flutter/flutter/issues/14288#issuecomment-361375791
https://github.com/flutter/flutter/issues/17084#issuecomment-385718108
https://github.com/flutter/flutter/issues/15035#issuecomment-370028740

I'm going to close this as another dupe of #14288.


Groups: navigation between items does not work

When you have a group selected and then click on an item, the arrow keys or nex/previous buttons do not lead to the correct item in the current group but rather to the next item from the unfiltered group.
Should be the next item in line from the previously selected group.

I second that. The Groups-Feature is great for I can sort my feeds now by priority, but it's not really usable if you can't use the read-navigation buttons.

It could be nice if people who have made the groups-feature can send a PR to fix this issue.

@kordianbruck would you please close this ticket as well. The issue has been fixed.


delete imported redundantly

cargo build warning:
11 |   use crate::{include_file_descriptor_set, Code, Request, Response, Service, Status, Streaming};
   |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
  ::: /Users/gerald/test/rust/poem/poem-grpc/src/macros.rs:11:1
   |
11 | / macro_rules! include_file_descriptor_set {
12 | |     ($package: tt) => {
13 | |         include_bytes!(concat!(env!("OUT_DIR"), concat!("/", $package)))
14 | |     };
15 | | }
   | |_- the item `include_file_descriptor_set` is already defined here
   |
   = note: `#[warn(unused_imports)]` on by default

what Rust version are you using?

rustc 1.79.0-nightly (c9f8f3438 2024-03-27)  will reproduce


[Settings] Switch focus to last Image Size ListViewItem on adding new size

Summary of the Pull Request
What is this about?
This PR adds code to switch the tab focus to the new ListViewItem when the Add Size button is pressed.
The logic needs to happen in ContainerContentChanging and not the Button_Click handler as the ListView doesn't get updated immediately after ViewModel.AddRow is called.
Note: This PR only makes the focus change mentioned in the issue and not the "announcement after successful add/delete" feedback on the issue.
PR Checklist

[X] Applies to #7047
[X] CLA signed. If not, go over here and sign the CLA
[X] Tests passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed
How does someone test & validate?
Turn on Narrator

Tab through the Image Resizer page till the Add Sizes button and press it
Validate that Narrator reads out the new item in the ListView and it focus is on that element
Move focus to the remove button and press it
Validate that narrator reads out the adjacent element and focus is on it.

/azp run


Cannot rename items by pressing twice with the mouse in views other than details view.

Describe the bug
Cannot rename items by pressing twice with the mouse in views other than details view.
To Reproduce
Steps to reproduce the behavior:

Go to any folder with items in it.
Set view to details.
Attempt to rename a file by pressing the name twice.
Should work.
Switch to any other view and attempt the same.
See error.

Expected behavior
File/folder should show rename box.
Screenshots
https://user-images.githubusercontent.com/8879244/104462546-b8d2e000-557e-11eb-8087-fc1cc71b9fae.mp4
Desktop (please complete the following information):

OS Version: Windows 10 2004 21286.1000
App version: <IP_ADDRESS>

@gave92 sorry about the duplicate posts, Github was giving me a 404, and I didn't see the first one get posted.

@gave92 sorry about the duplicate posts, Github was giving me a 404, and I didn't see the first one get posted.

@generalguy41 no issue 👍

@generalguy41 no issue 👍


feat: Add ability for buttons to have specific tag/component

What:
The buttons, as well as the dots, can now receive a tag prop to allow to use custom element, either native tags, as well as React components. The dotGroup component also handles a dotTag prop, that is forwarded to all the dots, if not manually rendered.
Why:
This allows developers to use existing components (for both functional and style purposes) instead of relying on pure HTML classes for style.
How:
The tag prop was added on the following components: <ButtonBack />, <ButtonFirst />, <ButtonLast />, <ButtonNext />, <ButtonPlay />, and <Dot />.
The dotTag was added to the <DotGroup /> component, which forwards the value as the tag prop to every <Dot />, if not manually rendered.
Checklist:

[x] Documentation added/updated
[x] Typescript definitions updated
[x] Tests added and passing
[x] Ready to be merged

This feature does not contain any breaking change and could be part of a minor release IMO.

We are reviewing this.

We are reviewing this.

I know it took a while to update the PR, but could you give me an ETA for this feature to be released?
If you don't have time to do it soon, I'll use my fork until then. I just want to prevent this if this can be merged in the next few days/weeks.
Thanks!

Hi, this is much needed feature for me. Any update on this? Thanks.


Add tslint as a dev dependency

I wasn't getting lint until I installed this dependency. It looked like this was setup in the repo but the dependency wasn't listed. I'm assuming you may have had this installed globally.

Probably, thanks!


Cannot add namespaced loggers

Adding namespaced Winston loggers via configuration seems to be broken. When I set the configuration like this:
app.config.set("log:namespaces:foo", { console: { colorize: true } });

then I would expect Broadway to configure a logger named foo for me with the stated configuration:
app.log.get("foo").info("Colored output here");

but this is not the case. I believe Broadway's log plugin is not picking up the configuration for namespaced loggers correctly. Probably the cause is here: https://github.com/flatiron/broadway/blob/master/lib/broadway/plugins/log.js#L103
Happy to submit a pull request if this is indeed a bug!

It is likely a bug, but a lot has changed in v1.0.0, so I'm going to close this. Would love to get your input on the new API for v1.0.0!


Add data repo list

Adds data to the repo list page from pixel-point.

Most files are just prettier updates because I ran prettier from the root.


[Beta] Application crashes if applicationinsights.azure.com can't be reached

Hello it seems as if the server can't reach applicationinsights.azure.com when exporting spans the application crashes. I would assume that's not the desired behavior as telemetry is a nice-to-have and not an application crucial feature.
Here is an example log from when that happened!
2023-03-22T20:38:17.974032471Z ApplicationInsights:Envelopes could not be exported and are not retriable. Error message: [
2023-03-22T20:38:17.974110773Z   'getaddrinfo ENOTFOUND northeurope-2.in.applicationinsights.azure.com'
2023-03-22T20:38:17.974118673Z ]
2023-03-22T20:38:17.976989330Z ApplicationInsights:{"stack":"RestError: getaddrinfo ENOTFOUND northeurope-2.in.applicationinsights.azure.com\n    at ClientRequest.<anonymous> (/node_modules/.pnpm/@azure+core-rest-pipeline@1.10.1/node_modules/@azure/core-rest-pipeline/dist/index.js:1700:24)\n    at /node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:55\n    at AsyncLocalStorage.run (node:async_hooks:330:14)\n    at AsyncLocalStorageContextManager.with (/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AsyncLocalStorageContextManager.js:33:40)\n    at ClientRequest.contextWrapper (/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:32)\n    at Object.onceWrapper (node:events:628:26)\n    at ClientRequest.emit (node:events:513:28)\n    at TLSSocket.socketErrorListener (node:_http_client:494:9)\n    at TLSSocket.emit (node:events:513:28)\n    at emitErrorNT (node:internal/streams/destroy:157:8)","message":"getaddrinfo ENOTFOUND northeurope-2.in.applicationinsights.azure.com","name":"RestError","code":"ENOTFOUND","request":"[object Object]"} []

2023-03-22T20:38:26.690944014Z ApplicationInsights:Envelopes could not be exported and are not retriable. Error message: [
2023-03-22T20:38:26.691028115Z   'getaddrinfo ENOTFOUND northeurope-2.in.applicationinsights.azure.com'
2023-03-22T20:38:26.691035415Z ]
2023-03-22T20:38:26.701496408Z /node_modules/.pnpm/@azure+core-rest-pipeline@1.10.1/node_modules/@azure/core-rest-pipeline/dist/index.js:1700
2023-03-22T20:38:26.701530309Z                 reject(new RestError(err.message, { code: (_a = err.code) !== null && _a !== void 0 ? _a : RestError.REQUEST_SEND_ERROR, request }));
2023-03-22T20:38:26.701537509Z                        ^
2023-03-22T20:38:26.701541909Z
2023-03-22T20:38:26.701555409Z RestError: getaddrinfo ENOTFOUND northeurope-2.in.applicationinsights.azure.com
2023-03-22T20:38:26.701560709Z     at ClientRequest.<anonymous> (/node_modules/.pnpm/@azure+core-rest-pipeline@1.10.1/node_modules/@azure/core-rest-pipeline/dist/index.js:1700:24)
2023-03-22T20:38:26.701565309Z     at /node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:55
2023-03-22T20:38:26.701569809Z     at AsyncLocalStorage.run (node:async_hooks:330:14)
2023-03-22T20:38:26.701573810Z     at AsyncLocalStorageContextManager.with (/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AsyncLocalStorageContextManager.js:33:40)
2023-03-22T20:38:26.701578310Z     at ClientRequest.contextWrapper (/node_modules/.pnpm/@opentelemetry+context-async-hooks@1.9.1_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:32)
2023-03-22T20:38:26.701582610Z     at Object.onceWrapper (node:events:628:26)
2023-03-22T20:38:26.701586510Z     at ClientRequest.emit (node:events:513:28)
2023-03-22T20:38:26.701590210Z     at TLSSocket.socketErrorListener (node:_http_client:494:9)
2023-03-22T20:38:26.701594010Z     at TLSSocket.emit (node:events:513:28)
2023-03-22T20:38:26.701597810Z     at emitErrorNT (node:internal/streams/destroy:157:8) {
2023-03-22T20:38:26.701601710Z   code: 'ENOTFOUND',
2023-03-22T20:38:26.701605410Z   statusCode: undefined,
2023-03-22T20:38:26.701609110Z   request: PipelineRequestImpl {
...
2023-03-22T20:38:26.701764113Z     timeout: 0,
2023-03-22T20:38:26.701767813Z     formData: undefined,
2023-03-22T20:38:26.701771613Z     disableKeepAlive: false,
2023-03-22T20:38:26.701775413Z     proxySettings: undefined,
2023-03-22T20:38:26.701779213Z     streamResponseStatusCodes: Set(0) {},
2023-03-22T20:38:26.701782913Z     withCredentials: false,
2023-03-22T20:38:26.701786613Z     abortSignal: undefined,
2023-03-22T20:38:26.701790414Z     tracingOptions: undefined,
2023-03-22T20:38:26.701794114Z     onUploadProgress: undefined,
2023-03-22T20:38:26.701797914Z     onDownloadProgress: undefined,
2023-03-22T20:38:26.701805614Z     requestId: 'b0c23557-0886-4ad9-acfd-087adef6c7d6',
2023-03-22T20:38:26.701809814Z     allowInsecureConnection: false,
2023-03-22T20:38:26.701813614Z     enableBrowserStreams: false
2023-03-22T20:38:26.701817314Z   },
2023-03-22T20:38:26.701821114Z   response: undefined
2023-03-22T20:38:26.701824914Z }
2023-03-22T20:38:26.750497011Z  ELIFECYCLE  Command failed with exit code 1.
2023-03-22T20:38:26.799116606Z  ELIFECYCLE  Command failed with exit code 1.

@marcus13371337 do you any more details in the exception?, telemetry failed to be delivered to ingestion endpoint is quite common, I cannot see a single place where this could throw an unhandled exception, can you double check if there is no other exception part of this?

@hectorhdzg I might have found something, we are using node v16, and an unhandled promise in node >=15 will kill the application if I understood it correctly.
From what I can see, the promise created here does not have any .catch-attached as far as I can see.
From the log message in the logs I sent the code got to this line which rejects the promise created here, and boom we have a uncaught rejected promise!

Fixed in latest release

Nice! Thanks for your fixing the issue!


Symfony 6 and PHPUnit 9.

Drupal uses stack/builder and so we need to add Symfony 6 compatibility here for us to be able to upgrade.
Locally the tests pass for me with these changes:
$ vendor/bin/phpunit
PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

...............                                                   15 / 15 (100%)

Time: 00:00.021, Memory: 8.00 MB

OK (15 tests, 22 assertions)

However the new return type in StackedHttpKernel::handle() might mean this has to be a 2.0 release?

It has to be a 2.0 release indeed.
But I would strongly recommend stopping using this and replacing it with standard Symfony classes instead.


Add new feature-overlap command to demonstrate new region joins

Add a new feature-overlap command to demonstrate new region joins added in #1109.

@devin-petersohn is working on this, but I believe it will go outside of the ADAM core. As such, let's close this ticket. We can reopen if necessary.


WorkManager does not work after release build

After going through your code I have tried to implement WorkManager to show local notification after 24hrs of inactivity in my app. I have these codes to start WorkManager:
// InactivityReminder::Class()
private static Long MILLISECS_PER_DAY = 86400000L;
private static Long MILLISECS_PER_MIN = 60000L;
public static long delay = BuildConfig.DEBUG ? (MILLISECS_PER_MIN * 1) : (MILLISECS_PER_DAY);

// In MainViewModel
OneTimeWorkRequest request = new OneTimeWorkRequest.Builder(InactivityReminder.class)
                .setInitialDelay(InactivityReminder.delay, TimeUnit.MILLISECONDS)
                .build();
WorkManager.getInstance(getApplication())
                .enqueueUniqueWork(AppConstants.INACTIVITY_REMINDER_WORK_NAME, ExistingWorkPolicy.REPLACE, request);

Problem is this code works perfectly when in debug mode and it gives notification after every 1 minute (as set in delay var). But when I make it in release mode then never gives notification after 24 hrs.
Any idea what causing an issue in release mode? I am testing it on my Android 9 device.

my bad. :)

@zishanj Did you solved this problem? I am facing the same issue in my app.

yes... its working but I don't remember exactly now what was the issue but it was probably coding issue.

Ah, Okay. Hopefully, I might figure it out too. Thanks.


Dependency Graphs

We should produce dependency graphs for each library in each language.

[x] Python
[x] Java
[x] JS
[x] .Net

@kurtzeborn is this one complete and can be closed?

This is done!  Closing.


Usernames only stay connected for about 30 seconds

When using the site hackkahoot.xyz, the usernames only stay connected for a limited time before being removed. This is probably because the connection for each user is not left open.
I suspect it is the same for the command line utility but I am suffering from bug #9 so cannot test it - I would appreciate this being confirmed in the command line as well.
This could be fixed by keeping the connection open, continually connecting in a forever while loop; this would have to be done for each user.

I intentionally do this so that my server is not overloaded with outgoing connections--and so that it cannot be used to DOS kahoot.it. The flood tool itself stays connected until you kill it, as do most of the other tools. The kahoot-rand tool in particular is my favorite, because it not only stays connected but actually answers each question from every registered user.

It should be noted that my actual code does send keepalives correctly, at least as far as I have tested, so it will not be deauthenticated.


Doesn't work with shell.azure.com

Azure:
PS Azure:> Get-AzureRmSqlDnsAlias
Get-AzureRmSqlDnsAlias : The term 'Get-AzureRmSqlDnsAlias' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was
included, verify that the path is correct and try again.
At line:1 char:1

Get-AzureRmSqlDnsAlias

  + CategoryInfo          : ObjectNotFound: (Get-AzureRmSqlDnsAlias:String) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b37efd3e-9e52-391c-1680-8c35292f8919
Version Independent ID: b98aa91b-b272-cce2-329d-409511f92596
Content: PowerShell for DNS alias Azure SQL
Content Source: articles/sql-database/dns-alias-powershell.md
Service: sql-database
GitHub Login: @MightyPen
Microsoft Alias: dmalik

@tarunaroraonline Thanks for the feedback. We are actively investigating and will get back to you soon.

@tarunaroraonline We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.
Regards,
Mike


Add example of distributed query execution with DataFusion/Ballista

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There are no examples for Ballista, other than the benchmark suite.
Describe the solution you'd like
A simple example for Ballista.
Describe alternatives you've considered
N/A
Additional context
N/A

Duplicate of #774


please do not forget to upload into pypi 1.7.6

Hello,
can you upload guidata and guiqwt into pypi.
pypi is used as source for the debian packaging.
thanks
Fred

Done.
Had some issues with my automatic building scripts without noticing it... thanks for pointing that out!


Some configs pointing to old NEAR Wallet

Small one, but noticed that in the configs directory we probably need to point elsewhere, like to https://testnet.mynearwallet.com instead of
wallet_url = "https://wallet.testnet.near.org"

wallet no longer used in relayer. removed in this branch: https://github.com/near/pagoda-relayer-rs/pull/65


Use TextBlock instead of png in PullToRefresh

Pull Request Type
[ ] Bugfix <!—Please add link to related Issue below -->
[ ] New Sample
[x] Other - Please describe:
Issue
 #
Proposed Changes
Minor refactoring
Screenshot/GIF (if applicable):
I managed to achive pretty similar results

We're archiving this repo and have moved everything to https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/SceneGraph instead.


Initial Components (Access Code Table)

Moved lots, renamed lots. Not saying we have to keep the changes, but it was just easier to show most of it rather than typing out, so here it is. I suppose this PR is more of an RFC, it's meant to be taken apart, so we can hopefully land on some consistent conventions going forward.
Style guide mostly follows the Airbnb style guide.
Run npm run start to see the components in storybook
Screenshots

Other Notable things

Removed /hooks/*. Personally I find it easier to find things when they're named by use-case (vs. type). Here being able to browse the seam api by directory, and seeing the resources available is helpful.
Turned off the explicit-return rule to let TS infer away.
We don't have webpack! Not sure if a module bundler is incoming, but in the meantime I've added a  manual sass compile script, and used svg strings for images.
Don't have a watcher for scss file changes, so you'll need to re-run npm run build each time to have it take effect.
Not sure why TS is not happy with MUI components, could use a hand here:

TS Error for MUI components:
JSX element type 'Dialog' does not have any construct or call signatures.

Side note on the CSS stuff: even without a bundler for npm:build at the moment, we still need to make sure it can integrate into our dev flow for storybook / the examples which do have proper tooling.

I suppose this PR is more of an RFC, it's meant to be taken apart, so we can hopefully land on some consistent conventions going forward.

Missed this on my first look, but +1 to this approach!

Hmm, storybook shows the new story locally, but it's missing in the preview build.
https://react-ad8qlxqm1-seamapi.vercel.app/?path=/docs/seam-react-components--docs
@razor-x , @seveibar  any ideas here?

@razor-x  I think I've addressed all the threads. Open items should also have been spun off into separate issues. If everything looks good I'd like to merge this PR first before opening another one to flesh out the rest of the UI.

Overall look and feel looks good. Guessing that the menu / search / code count values will be hooked up later?


work section

when link to work is selected, the UI should scroll to a section with titled images of my apps

these images should have pseudo-classes - see module 2.

add title


Having svg as top-level Figure element is problematic

Since we now use phosphor-based widgets, and phosphor uses the classList attribute a lot, and IE 11 (apparently) doesn't support classList for SVG elements (http://caniuse.com/#feat=classlist), we have a problem having a phosphor widget controlling an svg element (like Figure.pWidget controls Figure.el in bqplot figures).
Options include:

Ignore IE 11, and consider it broken.
Add a polyfill for IE 11 (for example, a quick search turns up https://github.com/eligrey/classList.js/, which seems to maybe work for svg?)
Rewrite bqplot to not have a phosphor widget with an svg node

Thoughts?

We should move down the svg in the DOM and have the top-most element in bqplot be a div.
There are other benefits to this:

The toolbar should be a child widget to the figure. In doing so, the toolbar view will have a reference to the figure view, and the toolbar save button will be able to only save the current view, and not all the views of a given model...

We will be about to do other strategies for zoom that include operations on ranges...

We will be able to add canvas layers outside of the svg.

I was afraid you were going to pick the option that entailed the most work! :)

I think we can close this as we changed the top level element to a div.

Yep, thanks.


Potential dependency for older code?

I had a failure when testing Pivotal's "fortune-teller" application whose last commit was back in 2016: https://github.com/spring-cloud-samples/fortune-teller
Steps to reproduce:

install Wavefront for Spring Boot Autoconfigure

git clone https://github.com/wavefrontHQ/wavefront-spring-boot.git
cd wavefront-spring-boot
mvn install
cd ..

install Fortune Teller

git clone https://github.com/spring-cloud-samples/fortune-teller.git

cd fortune-teller

mvn clean package [FAIL]

cd fortune-teller-ui

Edit pom.xml to add dependency:
groupId: javax.xml.bind
artifactId: jaxb-api
version: 2.3.0

mvn clean package [SUCCESS]

Edit pom.xml for each service with version equal to 2.0.0-SNAPSHOT
[NOTE: document does not state to add word SNAPSHOT

Add wavefront.properties for each service in src…main…resources.

mvn clean package [FAIL]
KEY ERROR found in io.spring.cloud.samples.fortuneteller.ui.services.fortunes.FortuneServicePactTest: Caused by: java.lang.IllegalStateException: Could not evaluate condition on io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration#tracingHandlerInterceptor due to org/springframework/boot/web/servlet/FilterRegistrationBean not found. Make sure your own configuration does not rely on that class. This can also happen if you are @ComponentScanning a springframework package (e.g. if you put a @ComponentScan in the default package by mistake)
at org.springframework.boot.autoconfigure.condition.SpringBootCondition.matches(SpringBootCondition.java:55)

Will need to validate after the spring boot and micrometer changes, leaving open for now

Closing this since we have overhauled the code, please file a new issue with the "v2" code if it still persists.


Fix for STORE-1111

This fix might brake UI test cases in Enterprise Store. We will merge this pull request targeting GREG 5.1.0.


Make PlanMaker pluggable

Make PlanMaker pluggable through server config
Use PluginManager to plug QueryExecutor and PlanMaker
Clean up the config and put proper default value
Remove DefaultHelixStarterServerConfig which is not required when default value is properly set when reading the config

Incompatible (compile)
DefaultHelixStarterServerConfig is removed

Codecov Report

Merging #10269 (6734cc2) into master (874d9d6) will decrease coverage by 45.91%.
The diff coverage is 87.75%.

@@              Coverage Diff              @@
##             master   #10269       +/-   ##
=============================================
- Coverage     70.40%   24.50%   -45.91%
+ Complexity     5772       48     -5724
=============================================
  Files          2017     2003       -14
  Lines        109295   108901      -394
  Branches      16615    16573       -42
=============================================
- Hits          76953    26682    -50271
- Misses        26933    79399    +52466
+ Partials       5409     2820     -2589

Flag
Coverage Δ

integration1
24.50% <87.75%> (-0.05%)
:arrow_down:

integration2
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...pache/pinot/core/query/executor/QueryExecutor.java
12.50% <ø> (ø)

.../apache/pinot/server/worker/WorkerQueryServer.java
70.00% <0.00%> (ø)

...va/org/apache/pinot/spi/utils/CommonConstants.java
0.00% <0.00%> (-22.50%)
:arrow_down:

...core/query/executor/ServerQueryExecutorV1Impl.java
72.15% <71.42%> (-10.28%)
:arrow_down:

...e/pinot/core/query/config/QueryExecutorConfig.java
85.71% <80.00%> (+9.24%)
:arrow_up:

...pinot/core/plan/maker/InstancePlanMakerImplV2.java
43.57% <100.00%> (-31.96%)
:arrow_down:

...e/pinot/core/query/config/SegmentPrunerConfig.java
100.00% <100.00%> (ø)

.../java/org/apache/pinot/server/conf/ServerConf.java
92.00% <100.00%> (+9.24%)
:arrow_up:

...rg/apache/pinot/server/starter/ServerInstance.java
73.42% <100.00%> (-12.59%)
:arrow_down:

.../pinot/server/starter/helix/BaseServerStarter.java
55.28% <100.00%> (-1.72%)
:arrow_down:

... and 1500 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Break AsyncRun into more exposed functions

This enables a user to save stopified code generated from a runner before doing
an eval, in order to support caching, inspect the stopified result themselves,
do some custom evaluation, etc.

I assume the failures were due to the chromedriver issue, so it should get fixed after my merge.
API suggestion: how about the compile functions be pulled out of the runner object? They don't need to be methods, I think.

It's nice that it closes over the composition of the options in this.evalOpts. Does it make sense to change compilerOpts from one call to another?

Ah, that is a very good point. Changing compiler opts is definitely not okay between calls to eval.


Update demo app dependencies, delete builds

Changes proposed in this Pull Request:

Dev to Master
Updates PX Blue dependencies
Removes demo build folder
Removes package dist folder

There shouldn't be any package-related edits in this PR, so the version number stays the same.


Kitchen VM creates and works until the IP change is attemped

I've watched the process, the VM starts and works but has the template IP. It then reboots and attempts to change the IP and won't start with an error stating that it could not parse or process the unattend file. The machine is then just stuck on a loop where it reboots with an error stating that there was a problem with the installation. If I use regedit to change the following value HKLocal machine/SYSTEM/SETUP/STATUS/ChildCompletion/setup.exe to 3 it will boot with everything working fine including the IP.
The unattend.xml before IP change and after is the same except for the mac address. Can you actually set an IP in the kitchen.yml file? It works fine if you leave the IP alone but this leaves my testing limited to one VM at a time unless I have loads of templates.
My config:
---
driver_plugin: vsphere
driver_config:
  driver_options:
    host: 'vcentre.host.net'
    user: 'gwhiting'
    password: 'password'
    insecure: true
  machine_options:
    start_timeout: 600
    create_timeout: 600
    ready_timeout: 600
    bootstrap_options:
      use_linked_clone: true
      template_name: 'vsphere-test'
      template_folder: 'Ops Test Lab/Gregs Sandbox/'
      vm_folder: 'Ops Test Lab/Gregs Sandbox/'
      datacenter: 'GS-Datacenter'
      num_cpus: 2,
      network_name:
        - VLAN-36
      memory_mb: 4096
      resource_pool: pex-vmware07.host.net
      datastore: v7000-vmware-uat12
      ssh:
        user: Administrator
        paranoid: false
        password: 'adminpw'
        port: 22
      convergence_options:
      customization_spec:
        ipsettings:
          ip: '<IP_ADDRESS>'
          subnetMask: '<IP_ADDRESS>'
          gateway:
            - <IP_ADDRESS>
          dnsServerList:
              - <IP_ADDRESS>
              - <IP_ADDRESS>
        domain: my_domain.local
        domainAdmin<EMAIL_ADDRESS>        domainAdminPassword: my_password
        org_name: my_org
        product_id: 11111-22222-33333-44444-55555
        win_time_zone: 4

provisioner:
  name: chef_zero

platforms:
  - name: WindowsServer2012R2x64v1_2
    transport:
      name: winrm
    driver:
       guest: windows

suites:
  - name: default
    run_list:
      - recipe[bg-chocolatey::default]

You can set an IP in the yml but like you say that's not ideal. Not sure what's going on but one thing that stands out in your config is the ssh port is 22 and should probably just be removed.
I'll admit this is confusing that even for winrm we use the ssh config options. If you leave them alone then the driver uses the safe defaults depending on the transport.
This would prevent the driver from reaching the vm and mess up the final stages of the provisioning and may be your issue here. Try removing that and report back.

Thanks for getting back to me Matt. Removed the ssh and it does seem to use the correct winrm port. But the issue is the same, something causes that unattend.xml error at the last hurdle. I'm wondering if it's the template that could be the problem, are there any requirements there?
I can actually remote to the desktop using the template IP right before kitchen tries to change it.
Probably not related but I've also noticed that in the unattend.xml the domain is set to the VM name minus one character -
< Domain>kitchen-cacc3a9</ Domain>
when the VM name is kitchen-cacc3a9f.
 Did you remove ipsettings (except for maybe the dnsServerList) from your config? Thats needed for DHCP to work.
One thing I found when creating vmware templates is to make sure the template is set to use DHCP even if cloned VMs will be using static IPs. I seem to remember having trouble if the template was assigned to a static ip. That said, even if the template uses DHCP, its normal for the clone to initially come up using the same ip that the template last used. However it is also "normal" for that ip to change after the vmware tools start up and the customization process kicks in.
Also, just to be sure, the unattend.xml file we are talking about is the vmware generated one and not a custom unattend file you have created correct? If its one you have crafted and expect to use that would be a problem.

I'm not using DHCP at all here, it's all static so if I remove the IP part it just uses the template IP. Is it a requirement to use DHCP?
The unattend.xml is created during the kitchen test process and is not a custom made one. It looks very different from the original file on the template.

No its not a requirement to use DHCP. I personally find it easier to use DHCP in kitchen scenarios and I thought you had commented trying to use it but static IPs should work too.
vmware generates the unattend files as part of its vm customization. So as long as you are not trying to manually intervene with your own unattend file, you should be good.
Do you mind including a gist of the kitchen output with debug logging on? That may help to get a better picture of what's going on.

Well this is the output https://gist.github.com/gleg/7389f98cbcd493f719c9
The VM does actually have the correct IP but if I open it in a console I see the following error
http://imgur.com/23DDdHl
Which would explain why winrm fails to reach it.

ah interesting. My guess is bad product key. I'd try manually cloning and see if you can successfully activate windows with the same key you are using.

Wow I think you might be right! I changed the key and it seems to be working. I'll test more after the weekend and share the results.
Thanks!

I've managed to test a few different cookbooks with this without any problems. I am wondering if there is a way to deal with encrypted data? I use chef vault and with vagrant you can just sync the VM to a key on your own host. Is there a way to use chef-vault with this driver?

Glad to hear converging is working now. Unfortunately there is no vault integration with kitchen.yml. You might try putting the key in an environment variable and then embedding ruby in the yaml to extract it. Not ideal but does that make sense?

Closing this as the vault thing is a separate issue. Thanks for your help Matt


Add pcre

This is needed to build https://github.com/input-output-hk/cardano-addresses

Looking at the build failures. Thank you for the PR!


Fix parameter style as required by Deno CLI

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Shader material - add default slots

Such as:
Color
Opacity
Transparent
Blending
Side
and something else?

Related to a bigger investigation of how the Shader material should work.


[#1791] feat(spark)(coordinator): Take more infos on get assignment to track app reassign/stageRetry

What changes were proposed in this pull request?
Take more infos on get assignment to track app reassign/stageRetry
Why are the changes needed?
For #1791
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests

ping @jerqi

ping @jerqi

gentle ping @jerqi again


API rate limiting when importing a package from a gitlab.com repository

When importing a new package from a private gitlab.com repository, most of the time I get an error during the package syncrhonization step that immediately follows.

Error: Failed to download vendor/package from https://gitlab.com/api/v4/projects/path%2Fto%2Frepository/repository/archive.zip?sha=5e925b01ce8143e5e3caf36b86dc840be8c33559

When downloading this URL using my brwoser, everything works fine.
Digging in the output of the bin/console messenger:consume -vvv command output, I found the following error:

11:01:13 DEBUG     [php] Warning: fopen(https://gitlab.com/api/v4/projects/path%2Fto%2Frepository/repository/archive.zip?sha=5e925b01ce8143e5e3caf36b86dc840be8c33559): failed to open stream: HTTP request failed! HTTP/1.1 429 Too Many Requests

After waiting for some time and forcing a new sync, it usually succeeds, but it's a pain having to go through this every time.
I am the only one facing this issue? Is there any setting I can change in either gitlab.com or repoman to mitigate this issue?

Hi @nstCactus!
I have same issue here!
The solution for this problem will be add a little interval between requests to Gitlab. But I didn't identify the file that makes this request yet;

Same here.

I found a possible workaround: getting only the last ten releases. This is less than ideal…


build: fix master build

After #2200, we now see that "master" is broken with compilation errors in:

app delivery integration test

Superceded by #2190


C++: recompute IRBlock membership at each stage

This enables the addition of new instructions in later phases of IR
construction; in particular, aliasing write instructions and inference
instructions.
@jbj this undoes part of #47, but I expect this to be the best way to unblock work on alias analysis and inference operators. There might be a more performant way to handle newly introduced nodes in later phases of IR generation, but I'd prefer to get moving on new features and reinvestigate performance later

I fixed the trivial changes I asked for, and rebased to resolve conflicts.

Since we aren't doing pi nodes immediately, I'm going to close this PR and roll it into the call side effects branch


Grammatical adjustments of writing templates usage guide to resolve issue #9400

Corrections to the grammar in Writing Templates section of the Usage guide. This will enhance readability and resolve issue #9400.

@thibaudcolas Alright. I would do just that.


Fix spaces in email addresses

Occurring when the last name consists of 3 or more words, only the first space would be replaced
Fixes #72

Looks great @Dennis123789, thanks for the fix!


error for installation

I receive the following error after executing "./gradlew distribution" for installation. Any idea what the problem is?

Configure project :console
exec distribution Task!

Task :core:compileJava FAILED
/Users/saramohamadi/Desktop/jyo/Colab_Laura/MoonLight/core/src/main/java/eu/quanticol/moonlight/signal/StaticLocationService.java:23: error: cannot find symbol
return List.of(new Pair<>(0.0,model)).iterator();
^
symbol:   method of(Pair<Double,SpatialModel>)
location: interface List
where V is a type-variable:
V extends Object declared in class StaticLocationService
Note: /Users/saramohamadi/Desktop/jyo/Colab_Laura/MoonLight/core/src/main/java/eu/quanticol/moonlight/util/ObjectSerializer.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':core:compileJava'.

Compilation failed; see the compiler error output for details.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1s
1 actionable task: 1 executed

Yes, there is a known problem with that method. Simply use JDK 9.0 instead of 8 and the problem should be solved

@saramohammadinejad should be fixed in a1f5a0c007528198fef3eac175603a133a8b94c0.


Builtin TypeScript bug

The following stack trace is given when using the built-in TypeScript version:
TypeError: Cannot read property 'getOptionsDiagnostics' of undefined
    at Object.getCompilerOptionsDiagnostics (/home/guybedford/Projects/ncc/dist/ncc/loaders/ts-loader.js:153789:28)
    at provideCompilerOptionDiagnosticErrorsToWebpack (/home/guybedford/Projects/ncc/dist/ncc/loaders/ts-loader.js:25004:31)
    at /home/guybedford/Projects/ncc/dist/ncc/loaders/ts-loader.js:24982:9
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/guybedford/Projects/ncc/dist/ncc/index.js:19628:10), <anonymous>:16:1)
    at AsyncSeriesHook.lazyCompileHook (/home/guybedford/Projects/ncc/dist/ncc/index.js:121606:20)
    at compilation.seal.err (/home/guybedford/Projects/ncc/dist/ncc/index.js:54813:32)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/guybedford/Projects/ncc/dist/ncc/index.js:19628:10), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook (/home/guybedford/Projects/ncc/dist/ncc/index.js:121606:20)
    at hooks.optimizeAssets.callAsync.err (/home/guybedford/Projects/ncc/dist/ncc/index.js:56201:36)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/guybedford/Projects/ncc/dist/ncc/index.js:19628:10), <anonymous>:6:1)
(node:8596) UnhandledPromiseRejectionWarning: Error: Callback was already called.
    at throwError (/home/guybedford/Projects/ncc/dist/ncc/index.js:35007:11)
    at /home/guybedford/Projects/ncc/dist/ncc/index.js:37809:7
    at cache.get (/home/guybedford/Projects/ncc/dist/ncc/index.js:57356:16)
    at needCalls (/home/guybedford/Projects/ncc/dist/ncc/index.js:91498:6)
    at err (/home/guybedford/Projects/ncc/dist/ncc/index.js:91457:11)
    at gotHandlers.push (/home/guybedford/Projects/ncc/dist/ncc/index.js:112872:8)
    at hooks.get.callAsync (/home/guybedford/Projects/ncc/dist/ncc/index.js:91501:6)
    at _promise1.then._result1 (eval at create (/home/guybedford/Projects/ncc/dist/ncc/index.js:19628:10), <anonymous>:30:1)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Where the underlying bug is this ts-loader call path - https://github.com/TypeStrong/ts-loader/blob/69dc5e2acfff9fad2664c8ec2ea341c794cd157e/src/after-compile.ts#L92 matching the program === undefined path and then calling into TypeScript at the following lines:
        function getSuggestionDiagnostics(fileName) {
            synchronizeHostData();
            return ts.computeSuggestionDiagnostics(getValidSourceFile(fileName), program, cancellationToken);
        }
        function getCompilerOptionsDiagnostics() {
            synchronizeHostData();
            return program.getOptionsDiagnostics(cancellationToken).concat(program.getGlobalDiagnostics(cancellationToken));
        }
        function getCompletionsAtPosition(fileName, position, options) {
            if (options === void 0) { options = ts.emptyOptions; }
            // Convert from deprecated options names to new names
            var fullPreferences = __assign({}, ts.identity(options), { includeCompletionsForModuleExports: options.includeCompletionsForModuleExports || options.includeExternalModuleExports, includeCompletionsWithInsertText: options.includeCompletionsWithInsertText || options.includeInsertTextCompletions });
            synchronizeHostData();
            return ts.Completions.getCompletionsAtPosition(host, program, log, getValidSourceFile(fileName), position, fullPreferences, options.triggerCharacter);
        }

where the getCompilerOptionsDiagnostics() call is finding program to be undefined even after calling synchronizeHostData.
This could be a bug in ts-loader, or it could be a bug in the ncc build of TypeScript, or some combination.
It may turn out to be some kind of instancing issue too with TypeScript, but we very carefully only have a single builtin version of TypeScript associated with the ts-loader build, unless there might be some missed dynamic import or something like that.

Did we update typescript or ts-loader between 0.18.5 or 0.20.1? I'm confused why this started happening recently 🤷♂

Yes, bisecting these upgrade paths will likely be the debugging technique :)

The break happens directly with https://github.com/zeit/ncc/pull/378 here unfortunately, so it is a bug in our build of TypeScript and ts-loader somehow in the new analysis rather than an upgrade path of either of those dependencies.

Reopening as we now get errors for internal definitions files here -
ncc: Version 0.20.2
ncc: Compiling file index.js
ncc: Using<EMAIL_ADDRESS>(ncc built-in)
Error: [tsl] ERROR TS6053: File<EMAIL_ADDRESS>not found.
[tsl] ERROR
      TS2318: Cannot find global type 'Array'.
[tsl] ERROR
      TS2318: Cannot find global type 'Boolean'.
[tsl] ERROR
      TS2318: Cannot find global type 'CallableFunction'.
[tsl] ERROR
      TS2318: Cannot find global type 'Function'.
[tsl] ERROR
      TS2318: Cannot find global type 'IArguments'.
[tsl] ERROR
      TS2318: Cannot find global type 'NewableFunction'.
[tsl] ERROR
      TS2318: Cannot find global type 'Number'.
[tsl] ERROR
      TS2318: Cannot find global type 'Object'.
[tsl] ERROR
      TS2318: Cannot find global type 'RegExp'.
[tsl] ERROR
      TS2318: Cannot find global type 'String'.
    at compiler.close.n (evalmachine.<anonymous>:1:1539399)
    at _promise0.then._result0 (eval at create (evalmachine.<anonymous>:1:273358), <anonymous>:13:1)
    at <anonymous>

Fixed in 0.20.4.


Investigate and fix Consent behat test break

This issue is imported from pivotal - Originaly created at Sep 23, 2019 by Michiel Kodde
In #166206956 a couple of Consent tests where marked as WIP. They where marked that way because they started breaking on Travis, but not on local test builds. The problem was not debugged as this would be rather time consuming. We want to have more control over the builds and shoud investigate how we can make our CI more robust.

Would a docker image of EB Deploy be a good alternative?
What would it cost to maintain that?
What other test features would be opened up with that?
Can we keep using our current Travis setup, but make it more robust, and less prone to break?

Personally I would create at first only the test setup in docker. Travis has docker support so it won\'t be hard to get it working. When we have this container we could then decide if it could work for OC-deploy and we could decide if additional changes are needed. Also the PO could then decide if the setup deliveres what is expected and has a base container to possibly use in OC-Deploy. I think it would be a too big step to implement it directly in OC-deploy as a lot of additional services should be configured in order to let the whole stack work.

We have the added benefit that we:

could debug the CI tests locally whit the same state which currently is very hard
could move our codebase for example to gitlab if we want to (not that we have to)
could automate a release build
loose the dependency on possible broken base images in Travis
need less time to maintain the tests because we have full control and can reproduce the same state

https://docs.travis-ci.com/user/docker/ (bstrooband - Sep 25, 2019)


[FEAT] Code Block Sanitizer for Docs

:bulb: Feature request
Feature Name

Code Block Sanitizer for Code Blocks
The Desired Behavior

I want links and other relevant info to be preserved.
I want HTML elements and other code content to be sanitized.
Your Use Case

As an app dev, I want links in API docs to work.
As an app dev, I want to see code block content, not have it rendered in daff.io.
Prior Work

#1798

Blocked by https://github.com/graycoreio/daffodil/issues/2641


Depend on specific/minimum Node.js version for tests?

I was wondering why some tests (namely the date.toLocale* methods) were failing for me locally and it turns out the Node.js version is the culprit. Examples:
new Date(Date.UTC(2012, 11, 20, 3, 0, 0)).toLocaleString('en-GB', { timeZone: 'UTC' })

'12/20/2012, 3:00:00 AM' // Node 8.11.3 (LTS)
'20/12/2012, 03:00:00' // Node 10.5.0 (Current)

new Date(Date.UTC(2012, 11, 20, 3, 0, 0))
  .toLocaleDateString('de-DE',  { weekday: 'long', year: 'numeric', month: 'long', day: 'numeric' })

'2012 M12 20, Thu' // Node 8.11.3 (LTS)
'Donnerstag, 20. Dezember 2012' // Node 10.5.0 (Current)

Now I don't understand why the second example is green on Travis/Appveyor (which appear to be using Node 10+) when the expected output of toLocaleDateString matches neither of the strings I got above.
Apart from the toLocale* changes there are also some differences in the assert module which is used in the tests, e.g assert.strictEqual(NaN, NaN) fails in Node 8.11.3 but succeeds in 10.5.0.
Node 10 also recommends using the new strict mode of the assert module instead.

I'm not sure that it's due to the version of Node necessarily, rather it appears it is something that you need to require when installing / compiling node. See here
So instead of the current way installing node in Travis it should probably be nvm install -s 10.5 --with-intl=full-icu --download=all or perhaps one of the other options listed in the link.
@jhenninger Would you like to check to see if that solves the issue?

@jhenninger yes @jonathan-s is correct. I too faced the same error and it is based on the OS. That is why it works well in CI without any issues.

Thanks for clearing that up! (I'm on Arch Linux and the 10.5.0 version was installed using pacman, all other versions using nvm).
Besides the locale issue there are other version differences that can affect the tests though. E.g. String.prototype.trimStart and  trimEnd don't exist in in Node 8.x.

I'd personally be in favor of aggressively following the newest standard and binding as many functions as it contains, regardless of whether the actual runtime supports the method. This matches what the libc crate does and it puts the onus on users to do version detection of their runtime (e.g. Node, Chrome, Firefox, etc).
Version detection tends to be really tricky and highly specialized, so we wouldn't necessarily be able to get a good implementation in wasm-bindgen itself.

Thanks @alexcrichton for the clarification. With that I think the ticket can be closed.
@jhenninger feel free to re-open if you have any further comments or issues with this.


dbt task to build the "catalog"

catalog.json
[
  {
    "database": "dbt",
    "schema": "public",
    "identifier": "orders",
    "type": "table",
    "column_name": "order_id",
    "column_type": "INT",
  },
  ... one entry here for every column we care about ...
]

general structure
we want a new dbt task -- dbt catalog generate
tasks/??.py
the end goal of this task is to:

select all the columns that we care about
may involve running multiple queries / multiple api calls > use adapter.execute with fetch=True, this will return a data frame as the second return value
this data needs to unioned back together into one big list
finally, dump that thing to disk

what do we care about?
for the first pass, i think this should just be the result of:
select database, schema, identifier, type, column_name, column_type from information_schema.columns
-- maybe join information_schema.tables

concrete API stuff

new adapter function: adapter.get_catalog_for_schemas(cls, profile, schemas: [str]) ->[dict]

future work
there are two dimensions that we plan to filter / expand this on:

we plan to filter this down to specific schemas / tables

for now this isn't a big issue, because we can just throw irrelevant data away in the docs frontend
in the future, as we add more complex statistics and other things to this dataset, these queries actually will become slower, and it will be important to filter down to the schemas that dbt cares about

we plan to add statistics that may be expensive to compute so that they are easily available in the docs

redshift: dist skew, unsorted %, current compression vs ideal compression, etc
snowflake: ???
bigquery: ???

schema name: analytics
table name: orders
{
    "analytics": {
        "orders": {
            "metadata": {
                "name": "orders",
                "type": "BASE TABLE"
                "comment": null
            },
            "columns": [
                {
                    "type": "TIMESTAMP WITHOUT TIME ZONE",
                    "index": 1,
                    "name": "_sdc_batched_at",
                    "comment": null
                },
...

Query for postgres:
with tables as (

	select
		table_schema,
		table_name,
		table_type

	from information_schema.tables

),

columns as (

	select
		table_schema,
		table_name,
		null as table_comment,

		column_name,
		ordinal_position as column_index,
		data_type as column_type,
		null as column_comment

	from information_schema.columns

)

select *
from tables
join columns using (table_schema, table_name)

where table_schema != 'information_schema'
  and table_schema not like 'pg_%'

Added in #768 - closing


Publish children from same collection

Can publish-composite publish children from the same collection? Why would I do this instead of just making the find query more robust? See example below:
Meteor.publishComposite('myData', function () {
    return {
        //return my user
        find: function () {
            return Meteor.users.find({_id: this.userId});
        },
        children: [
            {
                //return my trainer's user, based on a field stored in my profile
                find: function (me) {
                    return Meteor.users.findOne(me.profile.trainer);
                }
            }
        ]
    }
});

Right now if I do this, it's only returning my user.

Nevermind, this does work, I was just doing the multiple cursor call wrong (per #36).


[tracy] support for disabled tracy

Is your feature request related to a problem? Please describe.
Tracy has a TRACY_ENABLE flag that makes the all its functions NO-OPS (empty defines). What it means that users of the library can use the same source without additional ifdefs for release for end users and internal performance testing.
It would be helpful if vcpkg had a "null" port of tracy for use in final releases.
Proposed solution
Add a (possibly default) feature that sets TRACY_ENABLE to ON (otherwise OFF)
Describe alternatives you've considered
No response
Additional context
No response

TRACY_ENABLE: ON has been set in the cmakelists.txt file of the upstream code, and no additional settings are required.

Couldn't a default feature profiling solve the issue?

TRACY_ENABLE: ON has been set in the cmakelists.txt file of the upstream code, and no additional settings are required.

Misses the point.

Not being able to set TRACY_ENABLE to OFF makes the tracy port basically useless for real projects as there is no way to disable Tracy for production builds.

I agree that this is important, but it is not clear to me how to best fix it. Making a vcpkg feature to set TRACY_ENABLE has the downside that you have to reinstall a package to disable profiling; as effectively blocks using manifest mode with two build configurations (one with and one without profiling).
My preferred solution would be to set TRACY_ENABLE to OFF like
vcpkg_cmake_configure(
    SOURCE_PATH ${SOURCE_PATH}
    OPTIONS
        -DDOWNLOAD_CAPSTONE=OFF
        -DLEGACY=ON
        -DTRACY_ENABLE=OFF
        ${FEATURE_OPTIONS}
    OPTIONS_RELEASE
        ${TOOLS_OPTIONS}
    MAYBE_UNUSED_VARIABLES
        DOWNLOAD_CAPSTONE
        LEGACY
)

And then tell the user in the usage notes to define the TRACY_ENABLE macro themselves like
tracy provides CMake targets:

  find_package(Tracy REQUIRED)
  ...
  target_compile_definitions(main PRIVATE -DTRACY_ENABLE)
  target_link_libraries(main PRIVATE Tracy::TracyClient)

But this has the downside that many users might end up thinking the tracy package is broken.
@dg0yt @maxime-modulopi any thoughts?

This is what I see and understand:
The TRACY_ENABLE setting is

burnt into the binary lib.
burnt into the CMake config's INTERFACE_COMPILE_DEFINITIONS.

The first might not be a problem because the functions could be just dead code...
...until linking to Tracy::TracyClient forces the header to emit actual calls into the library, due to the INTERFACE_COMPILE_DEFINITIONS.
I do share the concern that requiring an explicit -DTRACY_ENABLE might be confusing. Default behavior should be as expected.
But vcpkg port could modify the installed header to make -DUNOFFICIAL_TRACY_DISABLE override the -DTRACY_ENABLE. (Or somebody asks upstream, for coordinating an official name for such a macro.)

Other solution: leave it up to the end user
It would also be possible for an end user to remove the TRACY_ENABLE definition by removing it from the target interface if they want to disable profiling:
find_package(Tracy REQUIRED)

if (DISABLE_PROFILING)
  get_target_property(TRACY_INTERFACE Tracy::TracyClient INTERFACE_COMPILE_DEFINITIONS)
  list(REMOVE_ITEM TRACY_INTERFACE "TRACY_ENABLE")
  set_target_properties(Tracy::TracyClient PROPERTIES INTERFACE_COMPILE_DEFINITIONS "${TRACY_INTERFACE}")
endif ()

This could be added to the usage notes.

But the vcpkg port could modify the installed header to make -DUNOFFICIAL_TRACY_DISABLE override the -DTRACY_ENABLE. (Or somebody asks upstream, for coordinating an official name for such a macro.)

Certainly possible, but it would be a large patch.

Certainly possible, but it would be a large patch.

10 installed headers affected, one line each. Could be done with a post-install glob/replace.

to remove the TRACY_ENABLE definition by removing it from the target interface

This might be tricky with subdirectories. And it is more than a single line for each user.

Next idea (untested): Guard the imported definition with a generator expression. One replacement after installation.
-   INTERFACE_COMPILE_DEFINITIONS "-DTRACY_ENABLE"
+   INTERFACE_COMPILE_DEFINITIONS "$<IF:$<BOOL:${UNOFFICIAL_TRACY_DISABLE}>,,-DTRACY_ENABLE>"

One (optional) option in user projects.
option(UNOFFICIAL_TRACY_DISABLE "")


Terminal Keeps Scrambling Up.

I'm working on a node backend project, and few minutes after running my server, the terminal stops reloading my server each time i make a change,  then when i try stopping the server with CTRL + C, the terminal dies.

@Emyboy can you define what terminal stops and terminal dies means? Screenshots might be helpful.

I have a similar if not the same issue. After running either git bash or power shell (possibly others) for a while, the text disappears:

Text is still there it's just either the wrong color or not rendering correctly. The processes remaining running and I can blindly type in new commands. On the right side of that split terminal is running git status after it goes blank. Some of the text appears.

I have a similar if not the same issue. After running either git bash or power shell (possibly others) for a while, the text disappears:

Text is still there it's just either the wrong color or not rendering correctly. The processes remaining running and I can blindly type in new commands. On the right side of that split terminal is running git status after it goes blank. Some of the text appears.

This is exactly what I was talking about.

sorry for the late reply.

The processes I spawned from the terminal still work, though. Or, I can wipe these and create a new terminal and that resets it.

/duplicate https://github.com/Microsoft/vscode/issues/69665
See https://github.com/Microsoft/vscode/issues/69665#issuecomment-519194905 for workarounds


Mac: Refactor testShouldHandleFileOpEvent test:

Resolves #1187

Split testShouldHandleFileOpEvent into separate test cases with more descriptive names
Fix an issue where the testShouldHandleFileOpEvent_VnodeCacheUpdated tests were sometimes failing due to vnode cache collisions from other tests
Updated the provider initiated I/O and provider offline scenarios to use file vnodes rather than the repo root vnodes

@pmj thanks for the feedback, I've filed #1195 to make additional changes based on your feedback and will have a follow up PR with the changes.


[Code-health] Add task for dependency check to Cloud Build

Config task updateDependency
Set output dir to /gnd/build/reports/ so that the reports are uploaded to GCS
Add TODO for future task

What does this do in practice? Please describe in PR description how it will look to contributors. (e.g., will checks fail on PRs if dependencies aren't all at the latest version? If so this may be too strict - we can't always use the latest version due to compat issues between different libraries we use, for example)

This only displays a report in the console and also creates a report in json format. The plugin also claims to account for constraints while checking for latest version.
This will never fail any build and only prints the suggestions. My guess is that no one will ever run this check manually. So, I plan to copy the reports file to GCS dir and dynamically create a SVG with dependency health
eg.
The json contains the total number of dependencies with latest versions and obsolete ones too.
Just a simple % healthy dependencies with background color


cargo-crev: 0.24.3 -> 0.25.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/crev-dev/cargo-crev/releases.
meta.description for cargo-crev is: A cryptographically verifiable code review system for the cargo (Rust) package manager
meta.homepage for cargo-crev is: https://github.com/crev-dev/cargo-crev
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.25.0 with grep in /nix/store/1ssbcfc9sl7yva6bcdx5kp9c7nmhjjhc-cargo-crev-0.25.0
found 0.25.0 in filename of file in /nix/store/1ssbcfc9sl7yva6bcdx5kp9c7nmhjjhc-cargo-crev-0.25.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-crev

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1ssbcfc9sl7yva6bcdx5kp9c7nmhjjhc-cargo-crev-0.25.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-crev https://github.com/r-ryantm/nixpkgs/archive/42cfdd46b35f4a5ad58d9eed4eb0761ea3a76984.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/42cfdd46b35f4a5ad58d9eed4eb0761ea3a76984#cargo-crev

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1ssbcfc9sl7yva6bcdx5kp9c7nmhjjhc-cargo-crev-0.25.0
ls -la /nix/store/1ssbcfc9sl7yva6bcdx5kp9c7nmhjjhc-cargo-crev-0.25.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-crev

Maintainer pings
cc @B4dM4n @matthiasbeyer for testing.

Result of nixpkgs-review pr 256029 run on x86_64-linux 1

1 package built:

cargo-crev


Add short tutorial on filling in config files.

Original link was dead, so I just filled it in with a quick tutorial.

Sorry for taking most of the year to respond to this. I find that this section is redundant as the section above already explains which files are required to be edited.


After increasing CRF, how much can the final effect be raised?

After increasing CRF, how much can the final effect be raised?
thanke you very much！

please refer to the paper


Correct use of sponge in the Proof Transcript

The paper on Duplex Keccak defines the duplex mode as absorbing and squeezing <=r (rate) bits (including padding) at each Keccak invocation. Our current implementation allows writing arbitrary string and then reading arbitrary string w/o absorbing any input, with padding applied only to the last block, and only at the absorbing phase.

Fixing this would require a new Keccak API designed specifically to support duplex mode. Crate tiny-keccak does not seem to support this at the moment.

We are lucky that current version of tiny-keccak (1.3) actually allows doing exactly the duplex mode as described in the Duplexing Keccak paper. Meaning, if we squeeze less that rate number of bytes, we will not disturb the internal state. Doing this right after absorbing gives us the duplex behavior that we need.

Seems like STROBE does not length-prefix the input data to allow streaming, and instead relies on either user providing appropriate metadata inputs, or MACs. Same goes for MACs themselves: Mike has a notice saying:

the first message that Alice sends to Bob will verify with a truncated MAC, but any message that either sends later in the protocol will fail, because of the different transcript before that point. This is unlikely to cause a huge security problem.

What's the status of this issue, given merlin integration?

#133 closes this issue.


Remove dart:io/dart:isolate from transitive closure of web applications

Description
I'm pulling the thread on https://github.com/flutter/flutter/issues/34858. I've discovered that the hack I added to psuedo-support dart:io has lead to debug and release web builds resolving config specific imports differently. The fix is to remove dart:io usage from framework, which will allow the incremental web compiler to correctly select the right config import.
I think this can be done in a mostly non-breaking way. We have some usage of Platform.isFoo that could really be defaultTargetPlatform, and Platform.resolvedExecutable doesn't actually print useful information in release applications, so that can go.
There are a few places like FileImage where the type is unfortunately part of the public API. One solution would be to change the type to Object/dynamic, and then have the runtime implementation perform the type check. Another would be to define our own stub and substitute that using more config specific imports.
Then of course, there are breaking changes to fix it, like making FileImage take a String path instead.
https://github.com/flutter/flutter/issues/34858

cc @goderbauer @Piinks

FYI: I realize there are already merge conflicts to resolve here, but I noticed https://github.com/flutter/flutter/pull/39589 adds dart:io to packages/flutter/lib/src/widgets/focus_manager.dart  👍

I'm going to break this PR up so it is landable into cleanups of the various separate libraries, starting with flutter_test.


BlackBox Terminal doesn't seems to support Sixel

Describe the bug
The latest version of blackbox-terminal, from the unstable branch. It does not have support for sixel, neither does the stable version terminal.
Expected behavior
Open any image like nixos.six or similar.
Screenshots

Additional context
I searched if there were any similar problems, and although I found other issues, none concerning the problem itself.
Notify maintainers
@chuangzhu @linsui
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.9, NixOS, 24.05 (Uakari), 24.05.20240507.b211b39`
 - multi-user?: `yes`

 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/f0ssy3p6898x9k880l23mhd0fl6rvrb2-source`

If you don't enable sixelSupport, it's not supported.

https://www.arewesixelyet.com/#black-box
Basically Blackbox uses GNOME VTE and VTE doesn't support it. That's not really a bug, just a missing feature, and you'll have to follow upstream.

Apologies, seems I was incorrect about the current status,
VTE can be built with sixel support and blackbox will pick it up. And it appears to be enabled in the current expression:
https://github.com/NixOS/nixpkgs/blob/1b8f21cb6152b964662fd5c79b54b3b52eb00368/pkgs/applications/terminal-emulators/blackbox-terminal/default.nix#L80

It's not enabled by default. https://github.com/NixOS/nixpkgs/blob/1b8f21cb6152b964662fd5c79b54b3b52eb00368/pkgs/applications/terminal-emulators/blackbox-terminal/default.nix#L23

Hi guys, I see you have reopened the issue. I understand that by default it is disabled, that's exactly what I wanted to mention yesterday, when I opened the issue. Sorry if I opened the issue and mislabeled it, that was my mistake for sure! I want to know if you/I can enable sixel from the configuration or at least understand why it is disabled?
I also understand that it is not yet supported, as mentioned. However in the Blackbox repository tracking you see that some users enabled it, and it was working.

In the place where you use blackbox-terminal, presumably environment.systemPackages, change blackbox-terminal to (blackbox-terminal.override { sixelSupport = true; }). Check https://nixos.org/manual/nixpkgs/stable/#chap-overrides for more examples

(blackbox-terminal.override { sixelSupport = true; })

This work, thx u <3


get States data in the API along with disctricts

I am using a rapid api which sends me the data of state_wise very similar to yours but it highlights the states highlights before jumping to disticts.
"Maharashtra":{
"active":"2066"
"confirmed":"2455"
"deaths":"160"
"deltaconfirmed":"121"
"deltadeaths":"0"
"deltarecovered":"0"
"lastupdatedtime":"14/04/2020 12:42:10"
"recovered":"229"
"state":"Maharashtra"
"statecode":"MH"
"statenotes":""
"district":{...
}30 items

Will it be possible to add this data? From the current data, I can add up the confirmed cases and delta in confirmed. But there is not data for state level recovered and deceased.

Hey @shree-vastava, have a look at this API. It contains the state-wise breakdown of confirmed, recovered and deaths. Hoping this is what you need.

@shuklaayush Thanks. I knew about this API. Could not see the statewise array. Didn't pay attention to the whole data, my bad.
Thanks a lot. i have made an android app using this.


Conflict names causing same color to different predicated

I think the ratel it's confusing with same prefix of predicates:
Queries showed are equals, changing only predicates aliases.
All predicates have records.
Note that in first image, both predicates pessoa.recebeu_empenho and pessoa.emitiu_nota_fisical has same prefix, then UI ratel aliased predicates to pe.

For testing, also tried alias to same name of predicate, wrong colors also happen:

Here we force a alias, then colors works as expected.

Even using more adequate names for predicate, always that prefix conflict happen, also happen colors confusion.

Thank you for taking your time to write a very detailed bug report.
I'm having difficulties reproducing it on a test dataset though, so need to clarify a few things:

Are you sure you are running the latest Ratel version? Is the bug present on https://play.dgraph.io ?
Are there any non-latin characters in the predicate names you are using? I've copy-pasted the names you've provided, but maybe your dataset has umlauts or something? (sorry I have no idea what language is that and what alphabet it uses)
If two different predicates are pointing to the same uid Ratel may visualize only one of the relationships. (e.g. <:Alice>  <:Bob> and also <:Alice>  <:Bob>). Can this be the case in your failing tests?

Test mutation I've used:
{
  set {
    <_:a> <pessoa.recebeu_empenho> <_:b> .
    <_:a> <pessoa.emitiu_nota_fisical> <_:c> .

    <_:a> <pessoa.recebeu_empenho> <_:d> .
    <_:a> <pessoa.emitiu_nota_fisical> <_:e> .
  }
}

Test query:
{
  q(func: has(pessoa.recebeu_empenho)) {
    uid,
    pessoa.recebeu_empenho {
      uid
    },
    pessoa.emitiu_nota_fisical {
      uid
    },
  }
}

Result seems correct to me:

I've tried reproduce the issue and i noticed that maybe it's issue is not related with colors, but related with limit of showing node and ordering of result.
I think that rename predicates cause reordering of results. Testing a query direct in dgraph (reordering is not applied without/with predicate alias), i think that is ratel related and maybe it's not a issue, but probably it's causes confusion.
What do you think about it?
Try this on https://play.dgraph.io/:
{
  node(func: uid(0x234)) {
    uid
    starring {
        uid
    }
    other_crew {
        uid
    }
  }
}

After
{
  node(func: uid(0x234)) {
    uid
    a: starring {
        uid
    }
    b: other_crew {
        uid
    }
  }
}

@ptsilva  can you please try this query:
{
  node(func: eq(pessoa.cpf_cnpj, "xxxx")) {
    b: pessoa.recebeu_empenho {
      uid
    },
    a: pessoa.emitiu_nota_fisical {
      uid
    },
}

I have swapped a and b to make sure alphabetic order of predicates is same as your original query. If this new query produces a graph with only green edges we have a confirmation that this is due to ordering of nodes in the response.
I cannot explain why forcing aliases would cause nodes to be returned in a different order, but that behavior would definitely explain the coloring difference, and would not be a bug. Will ask the backend team about this

I've changed my previous comment exactly changing the alias alphabetically

I think that is not a ordering of nodes in response. I've tried query in dgraph http and result seems preserve ordering with and without alias.

Could be related with JSON parse of result.

I couldn't find a way to reproduce this issue, so will close the bug as stale.
If it is still happening please re-open.
I think most likely it was due to expansion order on big graphs, because we have code to avoid prefix conflicts: https://github.com/dgraph-io/ratel/blob/1d98cc18bc80e402fae7dd8a58bc1592392f9e79/client/src/lib/GraphLabeler.js#L82


Way to open parameters

Hi,
Recently I am doing some work in BNN for federated learning, found this nice work(TyXe) for BNN. Is there a way that TyXe can open the parameters of BNN and then we can do some aggregation among several BNNs.
For example, if we can get the BNN1 weight as Gaussian G(mean1, variance1), another BNN2 G(mean2, variance2). We can aggregate as two gaussian fusion.
really want to use and cite this code if possible.
Thanks.

Yes that should be possible. The easiest way of accessing parameters would be through pyro's parameter store, i.e. just call pyro.get_param_store(). This gives you a global key-value mapping where all parameters live.
Just be aware that if you instantiate multiple BNN objects you will need to use the name argument in the init function for the BNNs to avoid name clashes (we should mention that in the docs, thanks for bringing it up!). Let me know if you encounter any issues, I haven't tested that use case before, but would expect things to work.


Change CertifiedTransaction to use bitmap instead of AuthorityNames

This is an idea to save some space in the CertifiedTransaction, which contains this field:
pub signatures: Vec<(AuthorityName, AuthoritySignature)>,

While the signatures vary, the AuthorityNames are repeated many times for all certified TX's in an epoch.  This is because the set of authorities for a given epoch are fixed.
So instead, we can store the following:
pub struct AuthoritySignatures {
    authority_bitmap: Vec<u8>,
   signatures: Vec<AuthoritySignature>,

The authority_bitmap would be a bitmap which has n bits where n = number of authorities in the epoch committee.  One bit is assigned for each possible authority.  The bitmap would have a 1 for each authority which has a signature included.
The signatures would be in order of the appearance of authorities in the bitmap which has set bits.
The space saved would be almost 32 bytes per authority.
//cc @gdanezis

For this to work we have to maintain an ordered map/list of authorities per epoch and atm we use a Btree and HashMap. It will need some refactoring, we could also explore delegating sig verification to this ordered data structure (under committee) that will carry the ID to pubKey mapping. Also if we do u8 IDs, we should assume that the max num of authorities is 256. Do we want to limit that in our application or explore a more efficient encoding?

@kchalkias regarding encoding, a bitmap uses only 1 bit per authority and does not have an upper bound limit like a fixed size u8.    Let's say for up to 256 authorities, where you would expect (2f+1) or say 193 authorities.
u8 encoding (with max 256 limit) - 193 bytes
dumb bitmap - 32 bytes

There are two options, right?
a) we include a u8 per authority signature, where this counter is a mapping between PubKey -> ID u8
b) a generic bitmap for the aggregated validators, so 32 bytes will be able to accommodate up to 256 validators.
benefits of (a) and (b), assuming a maximum of 256 authorities.

If there are less than 32 validator signatures, than (a) requires less bytes.
For more than 32 signatures, (b) is more succinct.

Then, because we expect 2f+1 sigs, we'll pick option (b) and we'll know that the bitmap size is highly dependent on the number of max validators. Also signatures should be ordered by validator ID sequence (while in option (a) does not require ordering).

@kchalkias yes that's a good summary.

We'll use option (b) and update the model when accountable BLS is available.

@kchalkias sorry what is accountable BLS?

Should this be closed?

https://github.com/MystenLabs/sui/pull/2929


Avoid using async v2

The base fluent/fluentd docker image for v1.15.1-1.0 include async v2 gem but fluentd isn't ready for it. To avoid using it, rebuild images with fluent/flunetd:v1.15.1-1.1.

Waiting to compete rebuilding fluent/fluentd images.


[WIP] Update user roles

Resolves #157
Description
I have gotten rid of the role user.
I added the role to the User table at /user, along with a link to activate/deactivate a user.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tests need to be added.
New code does not break any existing tests.
Screenshots

@dixpac as we discussed this before, wondered if you could review.  I still need to add tests but if you have any feedback about how I've implemented this, that would be great.  Thanks!!

BTW, I'm not crazy about the naming of Deactivate because it feels weird to create a deactivate to activate a user as well as deactivate them. So maybe some refactoring for the name is in order but this was the best I could do for the time being :)

@dixpac Hey!  I updated based on your feedback, and added tests.  Let me know what you think.  Thanks!

@dixpac  thanks so much for your help with this!


Delete duplicate TestUtils in pinot-common

Also fix some wrong import on junit

Current coverage is 45.94% (diff: 100%)

Merging #422 into master will decrease coverage by 0.06%

@@             master       #422   diff @@
==========================================
  Files           719        719
  Lines         34156      34156
  Methods           0          0
  Messages          0          0
  Branches       5111       5111
==========================================
- Hits          15716      15693    -23
- Misses        17185      17211    +26
+ Partials       1255       1252     -3

Powered by Codecov. Last update 4571ee4...1c3cda5

lgtm


Dark Mode/Custom CSS support for Todo Panel

Is your feature request related to a problem? Please describe.
For services like Microsoft Todos or Google Tasks, if those pages do not natively support a Dark Mode, we are stuck with a contrasting white background when the rest of the services offer dark mode via Universal Dark Mode.
Describe the solution you'd like
It would be nice if we could apply custom CSS overrides to the Todo Panel pages

I wish the same as therealgorgan. It's not eyes-friendly to have part of the window in white and all other parts in black (dark). I'm trying to figure out how to override the css for the Todo panel, but couldn't find a solution yet.


Add osquery to the standard rpco deployment

The osquery stack is being added to the standard rpco deployment. This
change enhances our ability to operate clouds by providing a means to
query environments via CLI and UI as well as to report security
characteristics of an environment to our ELK stack.
Signed-off-by: Kevin Carter<EMAIL_ADDRESS>(cherry picked from commit 87433e4487648e8ca021f2a2b75c0be0a85dc877)

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.

gonna wait for a second approval to merge since this is larger than just a 'quick patch'.


Move enumerations to enumerations attribute in enum

Enum was designed a little different to other data structure elements. Other Data Structure elements contain a value of the data structure under content, however enum doesn't contain a single value that the enum was representing but instead all the possible values (enumerations) that may be inside the enum.
This pull request changes enum so that the enum content contains the single selected enumeration, and move the available enumerations to the enumerations attribute. This allows the element to follow the normal data structure rules regarding the type for default and samples where they would match the same type as the data structure elements content.
Examples
To describe an enum with 4 possible string values, north, east, south, west we could represent that as an enum element as follows:
{
  "element": "enum",
  "attributes": {
    "enumerations": {
      "element": "array",
      "content": [
        {
          "element": "string",
          "content": "north"
        },
        {
          "element": "string",
          "content": "east"
        },
        {
          "element": "string",
          "content": "south"
        },
        {
          "element": "string",
          "content": "west"
        }
      ]
    }
  }
}

To describe the same enum with the four directions, and to provide a default value of north. We can represent that as an enum as follows:
{
  "element": "enum",
  "attributes": {
    "default": {
      "element": "string",
      "content": "north"
    },
    "enumerations": {
      "element": "array",
      "content": [
        {
          "element": "string",
          "content": "north"
        },
        {
          "element": "string",
          "content": "east"
        },
        {
          "element": "string",
          "content": "south"
        },
        {
          "element": "string",
          "content": "west"
        }
      ]
    }
  }
}

To describe the same enum, but also to provide a selected sample value of south:
{
  "element": "enum",
  "attributes": {
    "default": {
      "element": "string",
      "content": "north"
    },
    "enumerations": {
      "element": "array",
      "content": [
        {
          "element": "string",
          "content": "north"
        },
        {
          "element": "string",
          "content": "east"
        },
        {
          "element": "string",
          "content": "south"
        },
        {
          "element": "string",
          "content": "west"
        }
      ]
    }
  },
  "content": {
      "element": "string",
      "content": "south"
    }
}

Can you add an example for non-selected sample in PR description? I am approving it for now, but not merging yet since @klokane and @w-vi need to take a look too.

:+1:

Ops, we need change description.
Enumeration type. Exclusive list of possible elements. The elements in content's array MUST be interpreted as mutually exclusive.


Inline image syntax?

Could you implement some special syntax for inline mode that prompts with card images instead of scryfall card urls?
For example
@Scryfallbot image: <query>

Great idea!
It would be cool if we got more of the features that have been added in the always-on mode supported in inline mode as well. Will need to think about some extensible syntax up front.

Ok, I've done some experimenting on this. Turns out the only way to send an image from inline mode, is by listing images during search as well. (InlineQueryResultArticle vs InlineQueryResultPhoto).
I'm trying this out on the Scryfall Beta bot, but it's really hard to use because the images are so small:

So I'm gonna put some more thought into this.


Writes up steps for running multiple pyrsia nodes on a macosx

requires to download the codebase and build

Description

This PR documents the steps for running multiple pyrsia nodes on a macosx machine
Screenshots (optional)
PR Checklist

[x] I've read the contributing guidelines.
[x] I've read "What is a Good PR?"
[x] I've included a good title and brief description along with how to review them.
[x] I've linked any associated an issue.
[x] I've requested a review  from pyrsia/collaborators.

in #541 I choose /docs/tutorials as the location for a tutorial like this. We should either move this one there as well or move the demo.md to the /docs root.
Also, /docs/local_dev_setup.md seems to have some overlap with this write-up. I think local_dev_setup should focus more on the technical details of the setup and then refer to this document.

@prince-chrismc These are steps we want to share with people who want to see Pyrsia in action on the Mac OSX. These steps assume minimum setup outside of the steps mentioned here. Local Dev Setup would require the user to learn and install tools used for development including testing etc. This document requires only one cargo command to be run and the rest are steps to run a demo. Even though there might be steps that are individually duplicated this document is intended to be consumed without any other reference.


fix tomcat download link to go to archive instead of the latest release

docker build was giving a 404 due to new 9.0.91 release

I can do that, wasn't sure if we waited for districts to update before targeting new versions.


Added navbar

Added nav3 under Navbar. It looks good. Kindly have a look and merge it.

It looks like this:

This is not in the Figma File. @mandiraghosh783  Closing this PR.


Collab issues

Switching pages should keep the comment mode
Init unread status for comment threads
Comment icon fidelity
Reactions by users in a tooltip


No  is included in the pom.xml

the pom.xml generated by 0.5.5. is as follows:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.kazurayam</groupId>
  <artifactId>inspectus</artifactId>
  <version>0.5.6-SNAPSHOT</version>
  <name>inspectus</name>
  <description>A Java/Groovy API to store objects (Screenshots, HTML, JSON, XML) collected during End-to-end testings empowered by diffing and reporting tools</description>
  <url>https://kazurayam.github.io/materialstore/</url>
  <licenses>
    <license>
      <name>The Apache License, Version 2.0</name>
      <url>https://www.apache.org.licenses/LICENSE-2.0.txt</url>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>kazurayam</id>
      <name>URAYAMA,kazuaki</name>
<EMAIL_ADDRESS>    </developer>
  </developers>
  <scm>
    <connection>scm:git:https://github.com/kazurayam/inspectus.git</connection>
    <developerConnection>scm:git:git@github.com:kazurayam/inspectus.git</developerConnection>
    <url>https://github.com/kazurayam/inspectus</url>
  </scm>
</project>

No <dependencies> element is included.

See https://github.com/kazurayam/materialstore/issues/376 for the solution

I applied the approach suggested in https://github.com/kazurayam/materialstore/issues/376. I mean, I just added
        pom.Xml {
            ...
        }

I got the following pom.xml:
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.kazurayam</groupId>
  <artifactId>inspectus</artifactId>
  <version>0.6.0-SNAPSHOT</version>
  <name>inspectus</name>
  <description>A Java/Groovy API to store objects (Screenshots, HTML, JSON, XML) collected during End-to-end testings empowered by diffing and reporting tools</description>
  <url>https://kazurayam.github.io/materialstore/</url>
  <licenses>
    <license>
      <name>The Apache License, Version 2.0</name>
      <url>https://www.apache.org.licenses/LICENSE-2.0.txt</url>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>kazurayam</id>
      <name>URAYAMA,kazuaki</name>
<EMAIL_ADDRESS>    </developer>
  </developers>
  <scm>
    <connection>scm:git:https://github.com/kazurayam/inspectus.git</connection>
    <developerConnection>scm:git:git@github.com:kazurayam/inspectus.git</developerConnection>
    <url>https://github.com/kazurayam/inspectus</url>
  </scm>
  <dependencies>
    <dependency>
      <groupId>com.kazurayam</groupId>
      <artifactId>materialstore</artifactId>
      <version>0.13.0-SNAPSHOT</version>
    </dependency>
    <dependency>
      <groupId>org.slf4j</groupId>
      <artifactId>slf4j-api</artifactId>
      <version>1.7.25</version>
    </dependency>
  </dependencies>
</project>

This pom.xml include the dependiencies immediately declared in this project.
I does not include the transitive dependencies on which the materialstore-0.13.0-SNAPSHOT.jar depends.

https://stackoverflow.com/questions/30287826/how-to-get-the-information-of-transitive-dependencies-in-a-gradle-task

done at 0.6.0


None compressor

Currently there is a NoneCompressor class which provides no compression. This could be removed if the Array class explicitly handles the case where the compressor is None, resulting in some code simplification.

Removed in #42.