It can't support spree 3.0

Bundler could not find compatible versions for gem "spree_core":
In Gemfile:
spree_auth_devise (>= 0) ruby depends on
spree_core (~> 3.0.0) ruby
spree_auth_devise (>= 0) ruby depends on
  spree_core (~> 3.0.0) ruby

spree (= 3.0.0) ruby depends on
  spree_core (= 3.0.0) ruby

spree_alipay (>= 0) ruby depends on
  spree_core (~> 2.2.0) ruby

Thanks for report first.
Yes, it do not support spree 3.0 now. i am busy these days, i think i could not  upgrade it recently. Maybe late of June, i could handle it. PR is welcome.

@caiqinghua  it support 3.0 now.


Send notification emails to job alert subscribers when alert is going to end

Trello card URL:
https://trello.com/c/WVP6sEtD/849-send-notification-emails-to-job-alert-subscribers-when-alert-is-going-to-end-after-3-months
Changes in this PR:
This adds two reminders to be sent one week and one day before a subscription is due to expire. Users click on a link and are then taken to a page where they can review their subscription and resubscribe.
Screenshots of UI changes:

Next steps:

[x] Terraform deployment required?

[ ] New development configuration to be shared?

 Send notification emails to job alert subscribers when alert is going to end after 3 months

Can we remove 5ee65ce with a rebase, please.

@erbridge All done now - I've ignored the copy ones for now as I imagine copy changes will come from Michael too, so don't want to change stuff that's likely going to get changed again

Closing for now, as deprioritised.


Text gets blurred after text editing looses focus

How to reproduce

start with fresh canvas
enable the text tool, choose the “code” font
click in the empty space to insert text
type "hallo"
click somewhere else to end the text entering/loose focus from the text object

What happens
The text gets a bit blurry.
What should happen
The text should stay sharp
Environment
Ubuntu 19.10, Firefox 75.0

After step 4
After step 5

Yes, this is super annoying. It's likely caused by subpixel rendering (although we should be rounding it before render, so technically it shouldn't), and depends on where you happen to position text. Sometimes it is blurred , sometimes not.

Just checked, and it's indeed caused by subpixels:

x: 600.5px
x: 600px

Still an issue. :(

I'd like to note that excalidraw's closest competition, which is tldraw, has proper subpixel font rendering. Regardless of whether the text is selected. That's basically because text is in the DOM at all times.

Hi,
I'm facing the same issue. Using the latest version of Chrome on MacOS, when I try to reduce the resolution to 1280x720, the text that is not selected becomes blurry/fuzzy.

It's unclear what we can do about this, although currently we have anti-aliasing disabled, which may cause sharp edges on text — though it should help with blurry text. Sometimes it tends to help with neither, so it's a toss :/.


Remove 8 unnecessary stubbings in PiwikTrackerTest.java

In our analysis of the project, we observed that there are 6 tests: PiwikTrackerTest.testSendBulkRequestAsync_Iterable, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringFF, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringFT, PiwikTrackerTest.testSendBulkRequestAsync_Iterable_StringTT, PiwikTrackerTest.testSendBulkRequest_Iterable_StringTT, PiwikTrackerTest.testSendRequestAsync contain 8 unnecessary stubbings in total.
Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.

Thanks, @ARUS2023 !


Suppress plots

When running the calibration, many plots are created.
We should have a boolean argument that turns these off by default.

Resolved with PR #112


fix(ci): Sanitize PR title by using ENV variable

We need to sanitize the PR title by leveraging an environment variable as an intermediate step to prevent potential script injection attacks. This additional measure enhances the security of the workflow.

Hey this repo is not actively used. Was just used for testing while we were doing the CLA check. I can archive it completely if that's easier.

If you delete it, then we don't need the change, otherwise I would just merge the change to be on the safe side.


⚠ Bofrost.at has degraded performance

In 67b77da, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 890 ms

Resolved: Bofrost.at performance has improved in 9181712.


Assignment-2-Autotest

The assignment-2 has a requirement which should be done by the developer.

The assignment-2 unit test cleans and rebuilds the application writer as well. This causes a problem if the developer forgets to update his script as per the above requirement.
Solution:
The unit test should not clean and rebuild the writer. Instead, this should be done in finder-test.sh and verified using the unit test.

PR:
https://github.com/cu-ecen-aeld/assignment-autotest/pull/35

Latest Commit can be found here : https://github.com/cu-ecen-aeld/assignment-autotest/pull/35/commits/9dedbcef1781dfeb4b335b010aa64d0e2ebe3cb3


Can't open device Tobii Eye Tracker 4C

Linux distribution: Arch Linux 5.13.4-arch1-1
Howdy version: Howdy 2.6.1
Hello there, I'm trying to set up Howdy with my Tobii Eye Tracker 4C, but Howdy can't seem to open the device. I have tried setting the device_path variable to both /dev/video0 and /dev/video4 (those show up when running v4l2-ctl --list-devices but in both cases sudo howdy test doesn't work.
If I try with my Logitech C920 everything works fine.

Can you access those devices from other apps such as cheese?

No, I can't.

Then your camera is probably not supported unfortunately. You could try updating your kernel but seeing how specialized this camera is it might just not use the encodings Howdy needs.


maliput: 1.0.8-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository maliput to 1.0.8-1:

upstream repository: https://github.com/maliput/maliput.git
release repository: https://github.com/ros2-gbp/maliput-release.git
distro file: foxy/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.0.7-1

maliput
* Brings range validator from maliput_malidrive. (#529 <https://github.com/maliput/maliput/issues/529>)
* Update triage.yml (#526 <https://github.com/maliput/maliput/issues/526>)
* Adds convenient test utility method. (#525 <https://github.com/maliput/maliput/issues/525>)
* Adds a test function for LaneEnds. (#524 <https://github.com/maliput/maliput/issues/524>)
* Adds IsLanePositionResultClose macro. (#522 <https://github.com/maliput/maliput/issues/522>)
* Contributors: Agustin Alba Chicar, Franco Cipollone

cc: @tfoote

Holding for sync


Special character are escaped in messages

Special characters are saved in DB escaped, in the front we should unescape then when the message arrive from another user.


OLS-444: allow service account running app server to create tokenreview

Description
This completes OLS-444, allow the app server service account to create tokenreview, so that it can authenticate users from incoming query.
This PR extracts the authentication activation part of OLS backend from the PR about service monitor.
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #
Closes # OLS-444

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[x] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

@raptorsun does the operator currently configure OLS to require auth?  (i know at one point it did, but then i think we were going to roll that back until this tokenreview issue was fixed)
if the operator is not currently configuring OLS to require auth, we should change that as part of this PR

@raptorsun does the operator currently configure OLS to require auth?  (i know at one point it did, but then i think we were going to roll that back until this tokenreview issue was fixed)
if the operator is not currently configuring OLS to require auth, we should change that as part of this PR

The CR has an option to turn off the authentication on the OLS backend. By default it activates authentication.

/lgtm

/hold

/lgtm cancel

@raptorsun The tokenreviews is only required for AppServer ServiceAccount . Why do we extend to the operator's serviceaccount ?

@raptorsun The tokenreviews is only required for AppServer ServiceAccount . Why do we extend to the operator's serviceaccount ?

To grant access on tokenreviews to the AppServer ServiceAccount, the ServiceAccount of the operator itself must have this access before granting it to other ServiceAccounts.

/unhold

/lgtm
/approve


odb: derating relocation from GRT to dbTechLayer

Implemented the insertion of derating (layer adjustment) into RUDY, using an average value from the routing layers.
- Note: RUDY does not have access to layer information. Instead, derating values for each layer are set within GRT.
Moved derating from GRT to dbTechLayer through the use of a code generator.

mock array should be quite readily predicted.  I'm wondering why rudy w/weight-avg is showing >100 congestion.

There are two things that influence the > 100% values: the derating itself, and the fact that RUDY is considering the presence of 2 nets per tile per blockage on the macros. Here you can see the case with 0 derating for reference. Notice RUDY values are actually lower when derating is 0.
RUDY:
GRT:
There are other examples where RUDY overestimates congestion due to derating, in the current format. I thought of a condition, prior to derating adjustment, to not add too much if the value is already high, but seems strange to do that, any ideas?

When you consider the macro for track usage do you consider derating?  If the macro blocks all the tracks, it should be blocking all the derated tracks not the underated tracks

When you consider the macro for track usage do you consider derating? If the macro blocks all the tracks, it should be blocking all the derated tracks not the underated tracks

If you look at RUDYCalculator::calculateRUDY() you will notice I first calculate RUDY for the nets (different methods for supply versus signal nets), afterwards I loop over the instances to process the macros.  Then only afterwards I adjust every tile based on the derating at dbTechLayer.
So the derating and the macro blockages are processed separately first the blockages than the derating on all tiles (considering RUDY values are stored on the tiles).

I tried using a sigmoid function to reduce the derating addition on values that are already high. Some examples look better:
-IBEX

-Mock-array

I am executing more examples right now.

@eder-matheus please advise on how derating and macros are handled in grt

@eder-matheus please advise on how derating and macros are handled in grt

Regarding user-defined derating, GRT iterates through every tile of the gcell grid and applies the reduction percentage over the current resource value. With that, we avoid over-reducing the tile resources because it doesn't reduce anymore when it reaches zero.
For the macro obstructions, it iterates over every macro obstruction, gets the tiles overlapping with the obstruction, and sets the resources to zero when it is completely blocked. GRT will estimate how many tracks are blocked to define the reduction value when it is partially blocked.

@eder-matheus do you think we can share the code/logic with rudy so there is one way to handle macros?

@eder-matheus do you think we can share the code/logic with rudy so there is one way to handle macros?

I think @gudeh can explain better, but I understand that rudy doesn't see resources. It only considers the congestion in the tiles. Also, GRT looks at layers, while rudy doesn't have this capability.
I suggested to @gudeh to check if the tile already has 100% congestion and avoid adding the user-defined reductions to these tiles. This is what we do in GRT.

For future reference, we have decided during a sync meeting to implement a generic function in ODB that can be called by GRT, RUDY, or any other process. This approach will provide us with a unified method for calculating congestion for the power grid, macro obstructions, and derating.
The difference among RUDY and GRT should be only for signal nets.

I think this is obsolete in light of #4927 - close?

I think this is obsolete in light of #4927 - close?

I believe you are correct. With the new code structure I see no reason to relocate derating to odb.


PHP 7.2 + QA Tools + Docs

documentation moved into docs
added support files all in docs dir
updated composer skeleton and dependencies
updated Travis CI configuration (PHP 7.2, removed nightly)
updated .gitattributes and .gitignore
updated PHPUnit config

Thanks, @webimpress!


Every connection makes a Http1 and Http2 connection and does a lot of allocating

The http2 connection allocates at least 40k in byte arrays in the constructors.
Below are the ones I found from a quick search
Http2Connection
  - Http2Frame
    - 16k byte[]
  - Http2Framewriter
    - Http2Frame
      - 16k byte[]
  - HPackDecoder
    - 4k byte[]
    - 4k byte[]
    - 4k byte[]

@davidfowl @halter73

@BrennanConroy did you do another pass to verify it works well?

No, I'll try it out

Tried it out, way better now

@BrennanConroy can you update the SignalR issue with the latest details on the per connection memory


Add support for other version of Petkit feeder [Help Needed!]

Some of you may not have a Petkit Feeder mini, and still wants to use this plugin.
So I decide to add this feature and hope it will go public ASAP, but I may need some help since I personally just ownd a Petkit Feeder mini.
If you wanna help me, you can do some thing for me:

Your device exact model, like Petkit feeder mini or so. If possible, a link to Petkit store of your device is very very helpful.

If you know how to capture iOS app http netflow, post the url you captured, which may like one below:(“xxxxxx” is your device Id, please hide it before post it to the public.)

http://api.petkit.cn/6/feedermini/devicestate?id=xxxxxx
http://api.petktasia.com/latest/feeder/devicestate?id=xxxxxx
http://api.petkt.com/latest/feeder/devicestate?id=xxxxxx

Send a HTTP request to "http://api.petkit.cn/6/discovery/device_roster" with all the headers you captured above, and you will receive a response like below:

{
  "result": {
    "devices": [{
      "data": {
        "name": "your device name in Petkit app",
        ...
      },
      "type": "FeederMini"
    }],
    ...
  }
}

comment with the result.devices[].type string. The example above show as "FeederMini"
elfive at 2020.12.08
Thank you

If you wanna test the plugin, you can follow this guide:
install the demo version:
git clone -b develop_new_device https://github.com/elfive/homebridge-petkit-feeder-mini.git
cd homebridge-petkit-feeder-mini
npm link

configure the plugin:
I add a configure to specify the device model: model. Other settings are just like the README.md said.

you can modify it throuth Homebridge UI plugin settings page:

or you can modify it directly in config.json file:
for Petkit Element feeder:
"model": "Petkit Element Feeder"
for Petkit Feeder mini
"model": "Petkit Feeder mini"

remove this plugin:
goto plugin folder. (where you perform the git clone command)
cd homebridge-petkit-feeder-mini
npm unlink
cd .. && rm -rf homebridge-petkit-feeder-mini

change model string:
# goto plugin folder. (where you perform the git clone command)
cd homebridge-petkit-feeder-mini

# modify index.js, use vim or whatever editer you like:
vim index.js

# then locate to line 548, which says:
if (item.type == 'Feeder' && item.data) {```

# change the string Feeder to whatever you find out previosly through http request. save and restart homebridge.
service homebridge restart   // or restart homebridge through Homebridge UI.

Looking forward to your feedback.

Petkit version 2.0.0 is released, which support Petkit Feeder Element, you can upgrade to v2.0.0 and have a look.


Instruction on how to build containers for FDA using singularity

Can you please share the instructions ...

Sure:
https://github.com/FDA-ARGOS/GWProd/tree/deploy-testing/docker-deploy/singularity-sandbox

complete


Calendar Offsets Issue

Dear Zipline Maintainers,
I apologize if this is the wrong place to post this issue. I have already posted in on Stack Overflow but haven't gotten a response yet.
I am trying to backtest a futures trading strategy with daily frequency. I have a database of several thousand futures contracts, which need to be stitched toghether via Zipline's calculation of the roll. I was able to create a bundle via ingest, but I am running into an error as soon as I execute zipline.run_algorithm, more specifically, this code:
hist = data.history(
        context.universe,
        fields=['close','volume'],
        frequency='1d',
        bar_count=250,
    )

In calculating the history, it appears zipline is already calculating the roll (a point I am a bit confused about since I have also seen the roll calculated elsewhere in several tutorials), and in this calculation it is trying to access self._calendar_offsets with each sid. The error is happening when it tries to access self._calendar_offsets with sid = 2.
except Exception as exc:
    629     raise NoDataOnDate(
    630         "day={0} is outside of calendar={1}".format(day, self.sessions)
    631     ) from exc
--> 632 offset = day_loc - self._calendar_offsets[sid]
    633 if offset < 0:
    634     raise NoDataBeforeDate(
    635         "No data on or before day={0} for sid={1}".format(day, sid)
    636     )

KeyError: 2

I suspect this has to do with how I am assigning sids. Should I be assigning unique sids to every contract or every chain of contracts (with the same underlying asset, i.e. Corn)? The tutorial code I am working with does the former.
If my problem requires further details about my environment or my code, I am happy to respond. My only hunch is the SID issue--beyond that I don't know what could be driving this error. I am sorry for not providing a MVP--I would appreciate even general advice about what could be causing this error (i.e. data issue, something when i'm ingesting it, how i'm handling SIDs, etc). If it is necessary, I can try to make an MVP that shows this problem but I suspect that it would be highly non-trivial work.

Yes, every contract should have a unique sid. But what is important for the futures to work, is to pay attention to the root_symbol, and that all the the futures contracts important dates are correctly defined and aligned with the calendar your are using, otherwise you will run into all kind of issues during the contract roll. Check how  A. Clenow and https://github.com/hsm207/trading_evolved ingest the data.


CORS

how to make a cross-origin json request

See the discussion in #181 for cross-origin debugging tips. A link to a CORS tutorial is also provided there.


Added macro calls for sign output size and export key buffer size

Signed-off-by: Samuel Bailey<EMAIL_ADDRESS>

thread 'generate_integration_test' panicked at 'called Result::unwrap()on anErr value: InvalidHandle', psa-crypto/tests/mod.rs:97:23
I am pretty sure Travis fails because of a data race in psa_close_key that is called simultaneously in our test. I propose to fix the problem in a later PR and force the tests to be single threaded for now.
You can apply the following change to ci.sh:
-RUST_BACKTRACE=1 cargo test
+RUST_BACKTRACE=1 cargo test -- --test-threads=1


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit bd67779:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


26 search schoening

Alternative implementation for search and schoening, as follow up to #93 .
Uses typeclasses, so users can (if they want) customize certain parts of search.

Type class approach ditched in favor of class with abstract methods, see #93 for current approach.


Add 'live_action' twig function

Q
A

Bug fix?
no

New feature?
yes

Issues
N/A

License
MIT

Adds a new live_action twig function.
This helps with creating the proper attributes to call a live action. I can never remember the syntax and need to look up the docs every time to add a live action. This will make the process much easier.
Example Usage:
- <button data-action="live#action" data-live-action-param="save">Save</button>
+ <button {{ live_action('save') }}>Save</button>

Additional Parameters:
<button
-  data-action="live#action"
-  data-live-action-param="addItem"
-  data-live-id-param="{{ item.id }}"
-  data-live-item-name-param="CustomItem"
+  {{ live_action('addItem', {'id': item.id, 'itemName': 'CustomItem'}) }}
>Add Item</button>

Adding Modifiers:
<button
-  data-action="live#action:prevent"
-  data-live-action-param="debounce(300)|save"
+  {{ live_action('addItem', {}, {'debounce': 300, 'prevent': true}) }}
 >Save</button>

TODO:

[ ] Add CHANGELOG entry
[ ] Update docs

Hi @pierredup !
I like the idea very much (in term of DX), but internally i think we should leverage the StimulusAttribute already present in the Stimulus-Bundle  ...  https://symfony.com/bundles/StimulusBundle/current/index.html#stimulus-action
... what do you thinkl ?

Depending on your answer on the previous question, this comment could be useless ;)
We'd need to specify the trigger, as even if an action is often trigger by the "default event" on the DOM element it's registerered on, but this can be more specific / diverse
Examples here: https://stimulus.hotwired.dev/reference/actions#keyboardevent-filter

internally i think we should leverage the StimulusAttribute already present in the Stimulus-Bundle

I did initially start to go down this route, but then noticed the StimulusBundle is not a direct dependency of the LiveComponent, so didn't want to use classes that's not guaranteed to be available. Will then just add the StimulusBundle as a dependency to LiveComponent

We'd need to specify the trigger, as even if an action is often trigger by the "default event" on the DOM element it's registerered on, but this can be more specific / diverse

Cool, yeah that makes sense, will add it to the function


Not working with IDEA 2024.X.X

Hey @AskMeAgain the plugin is not working with IDEA 2024 and later, can you fix it?

Thank you!

Hi, iam using this plugin at work with the newest intellij version and its working fine.
The description of the plugin is sadly wrong: there is no UI checkbox anymore since i figured that anyone who wants to have this plugin will just always have it active anyway.
So just install the plugin and it will just work. No manual input required by you.
I will update the description of the plugin to reflect that

Is everything working fine? :)

Can you be a bit more specific? It 100% works as iam using it at work all the time with the newest intellij version :)

@AskMeAgain can you describe your flow of work? And when you create or add bookmarks?


feat(api):  Use 10mm/s-equivalent flow rates for GEN2 singles in API Version 2.6

(target is that other pr because it's based on it)
Intro
Hardware changes to the test protocol for GEN2 single pipettes mean we can (and must, since this is the new way they're tested) double the flow rates across the board for GEN2 single pipettes to values equivalent to 10mm/s plunger speeds.
This data change is. set in #6279 .  This PR reads the data correctly in the api, creates a new protocol API version, and uses the new data to set the faster flow rates for protocols that request API Version 2.6.
Changelog

Add typeguard to API dev dependencies and use it for checking the attached_instruments results, which cuts down on some noise in tests and makes sure the new TypedDict specifying the result of attached_instruments stays synced to the implementation
Load the new data in pipette config, use it in the hardware controller pipette, and expose it up the stack
Use the new data to set appropriate flow rates in protocols when InstrumentContexts are built
Refactor the hardware pipette and its owners to store flow rates in instance members and modify them there rather than poking the config every time

Review Requests

Does this look sane?

Testing

Run some protocols, with and without Gen2 Singles,  on 2.6 and below. Verify that smoothie logs look right, and nothing's broken (I need to do this myself also - I put this PR up early so we can get eyes on it).

Closes #5968

Are there any additional examples in the docs we should bump to 2.6?

 Restored the typeguard commit.


bash not found after installing dotnet on macos

Hi all

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install

Operating System: macos Mojave Version 10.14.3

dotnet version downloaded: dotnet-sdk-2.2.107-osx-gs-x64.pkg

Install succesful

Description:
When I try to run the command dotnet I am getting the following error:
-bash: dotnet: command not found
I reinstall and I got the same issue.
Any ideas?
Thanks in advance

I have close and open again the terminal and problem solved.

I have close and open again the terminal and problem solved.


validate minimum shape produces a "valid" output after processing

Parametrized input shape is currently defined as: shape = min + k * step for k in {0, 1, ...}
The output shape is defined as shape = shape(input_tensor) * scale + 2 * offset as well as shape_after_crop = shape - 2 * halo.
As a tiling consumer software, one would always remove halo. So, it is possible, that for some k the output shape could be <=0 (for some dimensions), which I would say constitutes an invalid model. Could we enforce that the input shape has to be given such that the output after halo cropping is still a valid shape?

I agree that this should be checked. It might not be possible to check this statically though (which is implemented here), but rather only possible in the dynamic check (in https://github.com/bioimage-io/core-bioimage-io-python). But @FynnBe would know how to best do this.

we should be able to do this statically....


976: prevent password pasting

fixes #976

Do we really want that? If you use a password manager with autogenerated and little longer password with special characters this is really annoying :see_no_evil:

Personally, I would also be super annoyed by this (and I don't see this very often at all in practice).
Here's also some officially looking blog post that supports my opinion^TM :D
https://www.ncsc.gov.uk/blog-post/let-them-paste-passwords
We could also ask our security expert @maxammann  :D

I don't really have a super strong opinion on this.
I am also very fine with not doing it, but maybe let's see what @maxammann says.
Small disclaimer. onPaste={e => e.preventDefault()} does not stop the user from drag'n'dropping a text into the field. Further it seems that especially managers that already run in the browser set the text on the dom element directly, as the firefox password manager still works.

I'm usually very annoyed if a website forces me to retype a password :D
I think if a user knows copy paste that well, then it is fine to do that.

Apart from that the solution is sufficient I think.


add wasm_struct_obj_get_field_count API support.

@wenyongh Can you review this PR that merges into the main branch?

Merge this PR since it was reviewed and discussed in PR https://github.com/bytecodealliance/wasm-micro-runtime/pull/3226.


MsgSubmitProposal RLP Type

Anyone have any idea what the problem is with submitting a text-based governance proposal?
This is the only type of message for which I can't get Evmos + Ledger to work with Keplr.
I get the below error:
Error: signature verification failed; please verify account number (1990873) and chain-id (evmos_9001-2): feePayer pubkey EthPubKeySecp256k1{026F434A5E0356CDC54D9999145F5681628D042AE487DE0E44293C134DBBAE5CB6} is different from transaction pubkey EthPubKeySecp256k1{022E10BA94588FE6B3965F46F29F6EF68008B80EF823B0FFB746A53BCD61A3B915}: invalid pubkey [evmos/ethermint@v0.19.3/app/ante/eip712.go:253]: unauthorized
    at r (injectedScript.bundle.js:1:15627)

The used RLP Type:
{
    MsgValue: [
      { name: "content", type: "TypeProposalTextDescription" },
      { name: "initial_deposit", type: "TypeAmount[]" },
      { name: "proposer", type: "string" },
    ],
    TypeProposalTextDescription: [
      { name: "description", type: "string" },
      { name: "title", type: "string" },
      { name: "type", type: "string" },
    ],
    TypeAmount: [
      { name: "denom", type: "string" },
      { name: "amount", type: "string" }
    ],
}

The signDoc content looks like this:
{
    "chain_id": "evmos_9001-2",
    "account_number": "1990873",
    "sequence": "54",
    "fee": {
        "amount": [
            {
                "amount": "2500000000",
                "denom": "aevmos"
            }
        ],
        "gas": "250000",
        "feePayer": "evmos1lmdw0am9y4pa53n33rn8m9wgsyvhl8dhcllmm6"
    },
    "msgs": [
        {
            "type": "cosmos-sdk/MsgSubmitProposal",
            "value": {
                "content": {
                    "type": "cosmos-sdk/TextProposal",
                    "title": "test evmos+ledger with Keplr (please don't deposit for this proposal)",
                    "description": "test evmos+ledger with Keplr (please don't deposit for this proposal)"
                },
                "initial_deposit": [
                    {
                        "amount": "1000000000000",
                        "denom": "aevmos"
                    }
                ],
                "proposer": "evmos1lmdw0am9y4pa53n33rn8m9wgsyvhl8dhcllmm6"
            }
        }
    ],
    "memo": ""
}

If I use type: any for the content property, I get the below error:
Error: unknown type "any" (argument="types", value={"Tx":[{"name":"account_number","type":"string"},{"name":"chain_id","type":"string"},{"name":"fee","type":"Fee"},{"name":"memo","type":"string"},{"name":"msgs","type":"Msg[]"},{"name":"sequence","type":"string"}],"Fee":[{"name":"feePayer","type":"string"},{"name":"amount","type":"Coin[]"},{"name":"gas","type":"string"}],"Coin":[{"name":"denom","type":"string"},{"name":"amount","type":"string"}],"Msg":[{"name":"type","type":"string"},{"name":"value","type":"MsgValue"}],"MsgValue":[{"name":"content","type":"any"},{"name":"initial_deposit","type":"TypeAmount[]"},{"name":"proposer","type":"string"}],"TypeAmount":[{"name":"denom","type":"string"},{"name":"amount","type":"string"}]}, code=INVALID_ARGUMENT, version=hash/5.7.0)
    at r (injectedScript.bundle.js:formatted:847:41)

Thanks in advance 🙏

I need to create some examples and fix some issues on the submit proposals to make sure that it works. Probably at the end of this week I should be able to do it!

Okay, thank you very much @hanchon. I tried to change the order of the properties of the RLP types, but it didn't work.
I also have the same problem with the message set-withdraw-addr (whatever the order, it doesn't work either).
I use the below RLP information:
MsgValue: [
      { name: "withdraw_address", type: "string" },
      { name: "delegator_address", type: "string" },
    ]

I would like to understand what could be the problem (by the way, I don't use this repository to avoid overloading with dependencies, I have my own EIP712 type file and custom binding logic).
Thanks in advance

@hanchon It would be great to have some examples! I'm trying to get it to work and I'm having a hard time


Updating packages

Update all dependencies to their latest version ? Or is there a simple way to do this. My first guess would be to go after the Pipfile.lock file. to do this manually. Can it be automated or does it have to be done by hand (replacing the versions and the hashes)?

Not sure about pipenv, I'm using poetry these days :sweat_smile:! But I don't think either of them as the ability to update the pyproject.toml or Pipfile automatically to update version (I do have an ugly Python script to do that for Poetry though, if you're interested). I think you'd have better luck with https://pyup.io/ or something equivalent.
I don't want to update the Pipfile in this repo, so I'm closing this, but if you want to send a PR I'll gladly accept it!


Mention foo.bar =  syntax for attrsets

https://book.divnix.com/ch05-01-language-basics.html#attribute-set-attr-set should probably mention that you can set keys in nested attrsets with foo.bar = , and that you can set multiple keys under the same top-level key with multiple lines, not necessarily grouped together:
{
  foo.bar = 1;
  quux = 2;
  foo.baz = 3;
}

The fact that this also works for lets... we can probably skip. :-P

oh yea, how did I forget this... lol


feature: Option to disable search integration

Did you check the docs?

[x] I have read all the flash.nvim docs

Is your feature request related to a problem? Please describe.
I like the way you integrate with other neovim tools, but it would be nice to have the option to disable that behaviour.
Describe the solution you'd like
Options to disable certain integrations like
opts = {
  search = false,
  multi_window = false,
}

Describe alternatives you've considered
I don't consider other options. Flash seems to be the superior nvim motion plugin. :)
Additional context
No response

You can already do all of that. Please read the docs

It might wasn't clear.
I can disable a search direction.
opts = {
  search = {
    forward = false,
    wrap = false,
    multi_window = false,
  }
}

I can't disable the plugin on search using slash, while still using the hotkey e.g. <leader s>.

Haven't seen this, sorry.
For everyone coming across this issue, this is my final config:
-- flash: disable multi window, plugin on / and ?
{
  "folke/flash.nvim",
  event = "VeryLazy",
  ---@type Flash.Config
  opts = {
    search = {
      multi_window = false,
     },
    modes = {
      search = {
        enabled = false,
      },
    },
  },
},


Roadmap

Thanks for this useful code!
Do you have a kind of TODO list that potential external contributors (such as myself) can look into?
I'm specially interested in "non-functional" updates to the code so it uses type signatures, maybe uses @singledispatch instead of isinstance checking and maybe make the code more readable with dataclasses. But that may not be in your roadmap if you're focused on supporting a range of older Pythons.

Hello,
I have no plan to improve this tool for the moment. It's purpose is to be as close as the original implementation and nothing more. Glad it is usefull, but I do only some maintenance on it.
If you have contribution to improve the code, fix bugs, documentation, I would be glad to accept them, but I do not plan to add any features
Best


RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd

RuntimeError: module compiled against API version 0xe but this version of numpy is 0xd

numpy version is not the same.

pip show numpy


Replace conda in agenda

There's a preliminary SWC-style conda lesson that might be good to send to our workshop attendees before they arrive. That would help us focus on use cases, and better hands-on practice.

Closed by #427.


slickRemove does not renumber data-slick-index in right way

The problem occurs when we deleting item from the middle, or more precisely  when we deleting item that is not last item of carouse. As a consequence of this we have two different elements with the same data-slick-index.  Here is my   JSFiddle  example, where we have two duplicate indeces.
Now it turns out that the problem locates in setupInfinite() method :

for (i = 0; i < infiniteCount; i += 1) {
                    slideIndex = i;
                    $(_.$slides[slideIndex]).clone(true).attr('id', '')
                        .attr('data-slick-index', slideIndex + _.slideCount)
                        .appendTo(_.$slideTrack).addClass('slick-cloned');
}

When some element, that is not last, was removed the data-slick-index of the last 'real' element did not changes, but the _.slideCount decreases by 1, and hence we have following math:
Before deletion:
data-slick-index (of the last 'real' carousel element) = _.$slides.length - 1
and the data-slick-index of additional clone elements starts with
 slideIndex + _.slideCount which in fact is equal to _.$slides.length
After deletion:
data-slick-index (of the last 'real' carousel element) is still the same as it was before i.e equals to  _.$slides.length - 1
but now data-slick-index of additional clone elements starts with
 slideIndex + .slideCount =  .$slides.length - 1
That is how duplicates occurs.

I am seeing this issue as well.

Hey, it looks like this might have been resolved at some point in the master. I'm going to close, but if you want to circle back with a fresh test case, please feel free. Thanks!

still an issue


Version Bump

Changes since release 0.50.3:

Make small improvements to project run retry code and logging (#6030)
Timeout and retry xcodebuild -showBuildSettings (#5188)
Note reason for work-around (#6024)
Add clean to xcodebuild -showBuildSettings to workaround hang with core data projects
[fastlane] Refactor fastlane runner to make it easy to access from docs (#5951)
Add a ROOT path constant for fastlane_core (#5854)

:+1:

👍


Support for .resx generated code?

Are there plans to add support for the generated code from resx files, allowing localisations to be referenced using typed properties?
e.g. in Translations\Sample.resx

and in C# (class1.cs):
  Bridge.Html5.Window.Alert(Translations.Sample.Name);

Currently when a resource file is added to a Bridge.NET project compilation gives the follwing compilation errors:

Thanks for the great feature request. This would be awesome to get working, although we would need to add to the Bridge2 development plan.
I have logged as a feature request, and we will keep this thread updated with any progress that is made.

:+1: for this feature.

@geoffreymcgill Are there any updates on the likelihood of including support for ResX?

We were not able to add this feature to Bridge 15.0, but we will try our best to include in Bridge 16.0.

Isn't this part of the winforms api, which is not supported, so this shouldn't be either?

Script# was able to convert a standard resx file of strings into a JSON dictionary - this was quite convenient and allows for resx sharing across platforms.

I don't think resx files are related to WinForms - we use them in our ASP.NET projects and manage/create them entirely through Visual Studio. There's VS support and code-gen tied to them, but they seem to work in many (maybe all?) types of .net projects.
That said; this might be less important to us (I work with @calcock) since this was posted as we're looking at other ways for supporting translations that include function calls to allow better "typing" of placeholders in dynamic translations.

At least in UWP projects RESW is the standard which has exactly the same XML schema but the usage is slightly different and there is no out of the box code generator. It seems to me that RESW is the future of the resource storing but either having RESX or RESW support would be very nice. Multilingual Toolkit works with both anyway.

I'd like to add my support for this request. My Bridge.NET source is also compiled into a C# assembly, and Code Analysis in that project is recommending that I move literal strings into a resource file. While I don't desperately need a RESX for managing the strings in my Bridge.NET projects, I don't want to either disable the warning in a Code Analysis ruleset (that's shared with traditional .NET projects) or scatter my Bridge.NET projects with local suppressions - I'd rather just be able to follow the good practice consistently across all projects.


Run and Command Prompt doesn't work

Maybe this project could implement something like https://js-dos.com/


chore(main): release 2.3.0

:robot: I have created a release beep boop
2.3.0 (2024-05-18)
Features

:sparkles: added an update banner and button (#12) (357c569)
script: :sparkles: added script version to user scripts (#14) (c9fd3e2)
script: :sparkles: updated user scripts to make the update button work (#12) (357c569)
update-banner: :sparkles: added a script version check and tooltip to the button (#14) (c9fd3e2)

Bug Fixes

script: :bug: fixed undefined variables (#15) (ae2a670)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/davids-ensemble/tj-jira-panel/releases/tag/v2.3.0 :sunflower:


Argo-workflows or argo-cd should change its project name

Summary
I understand the huge refactoring it would need and I guess there is little chance that this idea could be implemented, but in regards of the long term project emancipation, I think it would be the best to do.
argo-workflows and argo-cd are two separated applications though they share things. When searching for "argo" on search engines results are a mix of both argo-workflows and argo-cd and it makes things difficult for newcomers to find its way. Even later, when you need to find some piece of information, you always get ambiguous results.
When you have both argo-cd and argo-workflows installed on a same kubernetes cluster you get ambigous objects : you have a mix of argo objects instanciated, some related to argo-cd, some related to argo-workflows.
It is also about identity : when I talk about argo at work, most of people know argo-cd but are not aware of argo-workflows and it creates a lot of ambiguities in the talks. My talk must always start by a disambiguation introduction.
Things would be much more clear if the 2 projects were more differentiated and would get a strong separated identity:

different name for the products
different blog for both of them

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Not fixable.


u and v may be NaN from the beginning

At first, thanks for the great implementation.
I found that this initialization is somewhat critical:
https://github.com/dhruvramani/Transformers-RL/blob/fc3d8af2f9b2ffc055855c755a1c892e4ae359d2/layers.py#L256
It may occur that self.u and self.v will be initialized containing nan. Eventually, this leads to everything becoming nan.

Thanks for the PR!


sidebar for blueprints

can utilize same design and functionality as it exists live on blueprints.liferay.design (reference clayui.com for most up-to-date code)
this is critical for the blueprints portion of the site, and will also be reused for the design handbook and lexicon portions (in the future).

Desktop styles: https://github.com/liferay-design/liferay.design/pull/99

thanks a ton @protoEvangelion ! works great


Introduce new module for shared interfaces

Introduce new module for shared interfaces

@akphi - Can we please include this in the next release of legend-engine ? Thanks

Initial use cases for this module : (1) Mark new/wip apis for authn (2) Rename/simplify test classes/surefire configurations for tests such as Test_Relational_DbSpecific_Athena_UsingPureClientTestSuite, ExternalIntegration_TestConnectionAcquisitionWithFlowProvider_Databricks


odometry units

I want to use odometry with approximate_ndt_mapping. I have a bag with odometry and lidar scans. Unfortunately, odometry doesn't seem to work. I have better mapping results without odometry.
Can this be caused by units in my odometry that are not compatible with Autoware. Please, what are the units used for twists in ndt ? Is it m/s rad/s or distance and angles during one timestamp period ?
Thanks a lot for your help.

Thanks for using Autoware and for your question. However the issue tracker is for posting confirmed bugs and feature requests.
We ask that you please ask questions on the Autoware Discourse category following our support guidelines: https://github.com/CPFL/Autoware/wiki/Support-guidelines. Please pay particular attention to the information we ask you to provide.


3.0.0 documentation for java

Hello, I wanted to use this lib in my project in java.
I can only see documentation for Kotlin tho.
Is there any for java? Can you send me a link to it and perhaps add it also to README?

OK I have just read that versions 2 and 3 are essentially only for Kotlin.


[BUG] "Get started" image is not adaptive to the browser window size.

What is the bug?
The image goes out of the text area when the browser window is minimized.
How can one reproduce the bug?

The image is scaled down to match the browser window size or goes out of the range gracefully.
What is your host/environment?

OS: Ubuntu
Version: 18.04
Browser: Firefox
Browser version: 111

HI @curq, I will take a look now!


Error while handling range element in react app

Describe the bug
While selecting a range value in a react app, it appears that the event handlers are not being triggered correctly
To Reproduce
Deployed a sample app to demonstrate the behaviour https://cocky-noether-e87ec6.netlify.app/
Sign up button is enabled only if the age threshold is met. Taiko is able to set the age correctly for the range but the button does not get enabled. It works for a manual run.
I think a similar issue affects timefield and checkbox element types as well
const { openBrowser, goto, range } = require('taiko');
> openBrowser()
 ✔ Browser opened
> goto("https://cocky-noether-e87ec6.netlify.app/")
 ✔ Navigated to URL https://cocky-noether-e87ec6.netlify.app/
> range("Age").select(50)
 ✔ Selected value 50 for the given input value 50

Expected behavior
Button should be enabled for the above set of commands.
Screenshots
Manual run:

Taiko run:

Additional context
Maybe related to https://coryrylan.com/blog/trigger-input-updates-with-react-controlled-inputs

Thanks for reporting with a sample, managed to replicate will take a look

There is a workaround for this issue. Please use the following steps:
openBrowser()
goto("https://cocky-noether-e87ec6.netlify.app/")
mouseAction($("#range1"),'press', {x:100,y:10})

You can change the values of x and y as appropriate to the application.


chore(main): release 1.6.0

:robot: I have created a release beep boop
1.6.0 (2023-09-24)
Features

重新使用 secrets.token (714e09e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/xyy94813/github-actions-test/releases/tag/v1.6.0 :sunflower:


Btc testnet IBD stuck.

After restarting node throws:
[2017-12-28 16:24:10.3801 1] INFO: Stratis.Bitcoin.FullNode.Initialize Full node initialized on TestNet
[2017-12-28 16:24:10.4116 1] INFO: Stratis.Bitcoin.FullNode.Start Starting node...
[2017-12-28 16:24:10.5016 1] INFO: Stratis.Bitcoin.Base.BaseFeature.StartChainAsync Loading chain
[2017-12-28 16:24:23.5532 7] INFO: Stratis.Bitcoin.Base.BaseFeature+<StartChainAsync>d__22.MoveNext Chain loaded at height 1256485
[2017-12-28 16:24:23.5532 5] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 FlushChain starting
[2017-12-28 16:24:23.5532 1] INFO: Stratis.Bitcoin.Base.BaseFeature.StartAddressManager Loading peers from : C:\Users\user\AppData\Roaming\StratisNode\bitcoin\TestNet...
[2017-12-28 16:24:23.6989 4] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 Periodic peer flush... starting
[2017-12-28 16:24:23.7143 6] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 Consensus Loop starting
[2017-12-28 16:24:23.7476 5] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 BlockStore.RelayWorker starting
[2017-12-28 16:24:23.7476 7] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 BlockStore.DownloadAndStoreBlocks starting
[2017-12-28 16:24:23.7476 1] INFO: Stratis.Bitcoin.Features.MemoryPool.MempoolManager.LoadPoolAsync Loading Memory Pool...
[2017-12-28 16:24:23.7540 4] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 MemoryPool.RelayWorker starting
[2017-12-28 16:24:23.8283 1] INFO: Stratis.Bitcoin.Features.RPC.RPCFeature.Initialize RPC Server listening on:
http://[::1]:18332/
http://<IP_ADDRESS>:18332/
[2017-12-28 16:24:23.8325 5] INFO: Stratis.Bitcoin.Utilities.AsyncLoop+<>c__DisplayClass12_0.<StartAsync>b__0 wallet persist job starting
[2017-12-28 16:24:23.8325 1] INFO: Stratis.Bitcoin.Features.Wallet.WalletSyncManager.Start WalletSyncManager initialized. Wallet at block 1256485.
[2017-12-28 16:24:23.8519 1] ERROR: Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Initialize An error occurred starting the application: System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.) ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Stratis.Bitcoin.Connection.ConnectionManager.AddDiscoveredNodesRequirement(NetworkPeerServices services) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Connection\ConnectionManager.cs:line 224
   at Stratis.Bitcoin.Features.Consensus.ConsensusFeature.Initialize() in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin.Features.Consensus\ConsensusFeature.cs:line 120
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.<>c.<Initialize>b__3_1(IFullNodeFeature service) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 57
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute(Action`1 callback, Boolean reverseOrder) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 102
   --- End of inner exception stack trace ---
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute(Action`1 callback, Boolean reverseOrder) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 120
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Initialize() in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 57
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
   at Stratis.Bitcoin.Connection.ConnectionManager.AddDiscoveredNodesRequirement(NetworkPeerServices services) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Connection\ConnectionManager.cs:line 224
   at Stratis.Bitcoin.Features.Consensus.ConsensusFeature.Initialize() in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin.Features.Consensus\ConsensusFeature.cs:line 120
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.<>c.<Initialize>b__3_1(IFullNodeFeature service) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 57
   at Stratis.Bitcoin.Builder.FullNodeFeatureExecutor.Execute(Action`1 callback, Boolean reverseOrder) in C:\Users\user\Desktop\TEST\src\Stratis.Bitcoin\Builder\FullNodeFeatureExecutor.cs:line 102<---

Cleaning cache and syncing from scratch fixes it.

Update:
Most likely this bug is introduced by https://github.com/stratisproject/StratisBitcoinFullNode/pull/998 so it's not on master yet.
It is confirmed that not only I got this bug.


Spaces and special characters removed from style names

Handling of style names does not work properly: #2

Character Style

Spaces and special characters (+, underscore) are deleted in name

Paragraph styles

Spaces and special characters (+, underscore) are deleted in name
Normal style became Standard

Fixed in v0.2-beta


Missing #!/usr/bin/env bash in main bash script

The bash script that gets downloaded to ~/.sourcerer/sourcerer is missing the #!/usr/bin/env bash header.
So when I run sourcerer in my terminal I get the following error message:
Failed to execute process '/usr/local/bin/sourcerer'. Reason:
exec: Exec format error
The file '/usr/local/bin/sourcerer' is marked as an executable but could not be run by the operating system.

@anatolykislov should we close this?

Yes. Thank you @hugogrochau !


Ability to work with logical-systems for junos

Proposed Functionality
Will be good to have ability to work with logical-systems on juniper routers. It`s just simple. need to place "set cli logical-system LOGICAL-SYSTEM-NAME-HERE" at start of dialog. and than all other commands will be executed within logical router context.
Some times need to split physical host to some virtual. This feature will make possible automatic peer configuration.

I would imagine you could get the functionality you are after using BGP groups that you could then reference in a configuration template, couldn't you?

I suppose that there several ways to achieve this:

Logical systems being "logical routers", you could create one router instance in Peering Manager per logical system and attach it a configuration template
You could use a tag to identify the logical system an IX or BGP group is supposed to belong to

I'd prefer using option number one since it a bit more flexible in my opinion.

Not relevant. You can close it. Found a direct solution without crutches.


added 3rd point to explnation text in criteria catalog overview page

added 3rd point to criteria catalog overview text


This fixes a few runtime errors for joystick input inside handle_input

This PR fixes a few runtimes I encountered while using a joystick input inside the handle_input function. (e.g gamepad_move variable was uninitialized and the screen variable  used by move_update_circuit_grid_display wasn't passed as a parameter)

Wow, thanks for your interest in the game and fix some bugs! @Unathi-Skosana I am not sure where this problem come from. Could you use joystick before modifying the code? Are you running on Windows? Let's test the code.

I could not use the joystick before modifying the code, I got a few attributes errors such as
AttributeError: module 'pygame.joystick' has no attribute 'get_hat'
I'm on Linux and have installed pygame==1.9.6 on a python 3.6.10 virtual environment.

Sorry, i couldn't get hold of a joystick to test it. But I trust you! Thank you again for making the contribution!


Add Aqara lumi.sensor_switch.aq2 to quick initialize device list

Add Aqara WXKG11LM, reporting itself as a lumi.sensor_switch.aq2 to "quickly initialized" devices .

Pull Request Test Coverage Report for Build 383564956

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.696%

Totals

Change from base Build 383516625:
0.0%

Covered Lines:
2728

Relevant Lines:
3423

💛  - Coveralls


NPM error issue

Thank you for sharing your repository. I encountered an error while trying to add a configuration to the package.json file. I guess you may need to update the npm version in your main code to resolve this issue.
Error :
API request error: NPM Execution error: npm notice npm notice New major version of npm available! 8.18.0 -> 10.5.2 npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.5.2 npm notice Run npm install -g<EMAIL_ADDRESS>to update! npm notice npm ERR! code E404 npm ERR! 404 Not Found - GET https://codeload.github.com/devoteamgcloud/dataform-assertions/tar.gz/refs/tags/[RELEASE_VERSION] npm ERR! 404 npm ERR! 404 'dataform-assertions@https://github.com/devoteamgcloud/dataform-assertions/archive/refs/tags/[RELEASE_VERSION].tar.gz' is not in this registry. npm ERR! 404 npm ERR! 404 Note that you can also install from a npm ERR! 404 tarball, folder, http url, or git url. npm ERR! Log files were not written due to the config logs-max=0

Hello @aliasoblomov,
Please replace in the package URL "[RELEASE_VERSION]" by the latest version. Today the latest version is "v1.1.0".
Here is the release link: Link
It should work after that!


nerf reaver shark, and add some utils class

thx, i will fix that

Unable to review the code due to missing assembly references for FargowiltasSouls, SpiritMod and CalamityMod. Please make sure to add the assembly references (.dll files for the mods) in the lib/ folder of this repo in the same way it's done for SOTS in #14. Also make sure to update the weakReferences section of the build.txt file to include Calamity and Spirit mod.

Most of the code in this PR is outdated/redundant. If you want you can open a new PR in order to just nerf the reaver shark.


proxy config json contents needs to be in sequence to work correctly

Command
other, serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
I don't know
Description
Below is the command I'm using
ng serve --proxy-config proxy.conf.json
Contents of proxy.conf.json are:
{
    "/api/code": {
        "target": "http://localhost/api/code",
        "secure": false,
        "changeOrigin": true
    },
    "/api/codenames": {
        "target": "http://localhost/api/codenames",
        "secure": false,
        "changeOrigin": true
    }
}

If I make a call to  GET /api/codenames it gets called as  GET /api/code/api/codenames
Below is my angular http service code:
baseUrl = `${window.location.protocol}//${window.location.host}`
getCode(codename: string): Observable<any> {
    let payload = {
      'codename': codename,
    }
    return this.http.post(`${this.baseUrl}/api/code`, payload);
  }

  getCodeNames(): Observable<any> {
    return this.http.get(`${this.baseUrl}/api/codenames`);
  }

Minimal Reproduction
ng serve --proxy-config proxy.conf.json
just make 2 dummy apis with similar name prefix
e.g.

/api/test
/api/testcases

when you try to call /api/testcases it will call /api/test/api/testcases
Exception or Error
No response
Your Environment
Angular CLI: 16.1.1
Node: 18.16.0
Package Manager: npm 9.7.2
OS: darwin arm64

Angular: 16.1.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1601.1
@angular-devkit/build-angular   16.1.1
@angular-devkit/core            16.1.1
@angular-devkit/schematics      16.1.1
@angular/cdk                    16.1.4
@angular/cli                    16.1.1
@schematics/angular             16.1.1
rxjs                            7.8.1
typescript                      5.1.3

Anything else relevant?
proxy resolving is just wrong I have to put the config in sequence like /codesnames first and then /code in order to make it work:
After changing sequence like below then only I'm able to call correct endpoint:
{
    "/api/codenames": {
        "target": "http://localhost/api/codenames",
        "secure": false,
        "changeOrigin": true
    },
    "/api/code": {
        "target": "http://localhost/api/code",
        "secure": false,
        "changeOrigin": true
    }
}

Are you using the webpack based builder or esbuild based builder? What's the value of the "builder" option in the build section of your angular.json?

Closing as author did not get back to use.

"builder": "@angular-devkit/build-angular:browser"
in angular.json

In that case, likely this is a problem with http-proxy-middleware which is a dependency of webpack-dev-server as for the webpack based dev-server we do not process the proxy configuration ourselves.


Checkout submodules recursively

Change to
      - name: Checkout repository
        uses: actions/checkout@v4
        with:
           fetch-depth: "0"
           submodules: recursive

See https://github.com/actions/checkout

Pull requests:

https://github.com/Senzing/github-action-docker-buildx-build/pull/8


remove align(1)

align(1) do nothing here. The struct is already packed because both fields are 64-bit integers.

Doesn't this make alignment compiler-dependent? Looking at https://dlang.org/spec/attribute.html#align

If structure should have align(1), then both fields and structure declaration should be anotated with align(1). If structure should satisfy C's packed attribute, than it will be always packed, because it consist from 2 64bit integers.

It it should be _packed_ to match libtraildb memory layout. I agree that it is hard to think of a sane compiler that would add any padding in this case, but I'd leave it in just as a safeguard and an indication that this struct is intended to be packed regardless of what's in it right now (or what may be added there in future versions).


date_as_argument set as deployment time not time of execution

I'm using YML configuration.
However I see that the cron schedule is stored with the deployment time (or when the sidekiq worker started) as the date argument, whereas I'd expect it to be the time the job was called?

I agree that this is really confusing: I also expected to see the time when the single job instance is created (i.e. a time matching the cron pattern). Unfortunately the time passed as argument is the time when the initializer / sidekiq starts, and it is basically the same for all the job executions.

Just ran into this bug. Agreed that it should be the time at which the job is being added to the queue in sidekiq.

try to fix it, #329

Fixed by #329


Any option for checking the VM in idle state for more than a specific time period

@helderpinto Can this tool show us, number of vm's and its details which are in idle state for more than a specific time period like 30/60/90 days? It would be really helpful.

Hi, @ashrafcitius.  Can you clarify what you mean by "idle state"? Is it a deallocated VM? Is it a VM running with very low CPU usage?

@helderpinto I mean the VM which are having low CPU usage for a longer period of time like 30/60/90 days

@ashrafcitius , this isn't controlled by AOE. This is an Azure Advisor setting, you can change in the Advisor Configuration. More details here.


Followed the setup guide get 404

Followed the setup instruction in the readme and when I visit http://<IP_ADDRESS>:8000/ I get a json reply of 404. Not sure what happened, step by step was followed twice and same thing happens every time.

Thanks for opening an issue. It's really hard to help with only the information you've shared.


[SPARK-33374][CORE] Remove unnecessary python path from spark home

What changes were proposed in this pull request?
Remove pyspark and py4j-0.10.9-src.zip under spark home from python path
Why are the changes needed?

Staging folder already contains uploaded pyspark and py4j-0.10.9-src.zip.
If local machine has different version of both files, confliction would happen.

Does this PR introduce any user-facing change?
No
How was this patch tested?
UT

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Hi, @warrenzhu25 .
In addition to @HyukjinKwon 's comment, according to GitHub Action, this seems to break Spark documentation generation too. Shall we close this PR?

Thank you for your decision, @warrenzhu25 .


TST: Test GUI frameworks

I expect this to fail because we need something like nbclient. It should be light enough to add if we do...

I expect this to fail because we need something like nbclient. It should be light enough to add if we do...

Just add it, then :) with a comment that we need it for testing only

... it did not fail, at least on Windows and Linux. macOS failed because we can't switch from the MacOSX backend to Qt, so I separated out the default from non-default for that OS. Ready for review/merge from my end @hoechenberger !

macOS failed because we can't switch from the MacOSX backend to Qt

Why's that?
Feel free to merge once we're green!

Why's that?

Probably some protection against using multiple frameworks simultaneously in a given session. I know it can cause problems sometimes... I've lost the log now, but matplotlib.use('QtAgg', force=True) failed with an error message saying that it couldn't switch because MacOSX was already in use.


ORC-1055: [C++] Add the timezone option for the csv-import tool

What changes were proposed in this pull request?
The pull request provides the csv-import tool with support for timezone settings
Why are the changes needed?
The patch is used to fix the ORC-1055 bug.
How was this patch tested?
The unit case is TestCSVFileImport.testTimezoneOption in TestCSVFileImport.cc

@wgtmac Hi, please take a look!

These timezones alias information is a reference to https://github.com/frohoff/jdk8u-dev-jdk/blob/master/src/share/classes/sun/util/calendar/ZoneInfoFile.java line:220-244

ed before your PR. Do

+1 for adding a test case. We can directly use the csv file from the JIRA.
After some investigation, I think the Java odlMappings may introduce new issues. For example, CST can either be Central Standard Time (America/Chicago) or China Standard Time (Asia/Shanghai).

Thank you for updating, @coderex2522 .

The PR title and descrition has been modified, @dongjoon-hyun please take a look again!

@williamhyun Hi, can you help investigate this problem in continuous-integration/appveyor/pr?
The error message shows "The build phase is set to "MSBuild" mode (default), but no Visual Studio project or solution files were found in the root directory. If you are not building Visual Studio project switch build mode to "Script" and provide your custom build command."

@coderex2522 It looks like ORC-1073 forgot to remove appveyor.yml in labeler.yml. Don't worry, it has nothing to do with your pr
https://github.com/apache/orc/blob/d84df2129adea01469871fc1ba6be5b758cbd7ac/.github/labeler.yml#L22

Merged to main/branch-1.7 for Apache ORC 1.7.3.
cc @williamhyun


Airline disappears when I source init.vim

Hey, I use neovim with airline, and it's really cool.
But recently I ran into a slight issue: when I source my init.vim file, airline disappears, and I need to refresh it, or do some actions with windows to make it appear again.
Can you tell me, what is the problem here, I how I can fix it?

Does it happen in Vim too?

I don't have vim installed, is it necessary to reproduce this bug in it?

i can only fix it, if I can reproduce it. To me it looks like a bug in neovim currently.

Give me a few minutes, I'll see if it's in vim too.

By the way, the problem was first noticed after I changed repos for airline (from old bling/vim-airline to new ones).

Do you set the airline_theme? or have some kind of autocommand running?

Hey, I've found the problem.
It was syntastic, I had these lines in my init.vim (by the way, in vim they crash airline to)
set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

Anyway, thanks for your help.

Hey, I've found the problem.
It was syntastic, I had these lines in my init.vim (by the way, in vim they crash airline to)
set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*

Anyway, thanks for your help.

Yeah, that is expected.

These are the recommended settings by Syntastic.  I take it that that let g:airline#extensions#syntastic#enabled = 1 does not fix this?
I've also opened an issue on Syntastic.

The status line disappears whenever I source init.vim, without modifying it or any configs related to airline. The tabline stays.


Valid Markdown link using HTML syntax is not recognized

Testing #149979
Our vscode-wiki repo has a header like so:
# Closing Issues "With a Commit"

This link is valid https://github.com/microsoft/vscode-wiki/blob/89908e15bbba882528cd0bdc906482cb7923d1a3/Automated-Issue-Triaging.md#closing-with-a-commit but references to it in the same document are reported as invalid:

This is a known limitation. It is difficult to correctly parse html embedded in markdown to extract ids/names and just does not seem worth the engineering effort. Instead we assume all links are to MD headers and allow other anchor links to be excluded from validation


Refactor  chatGptSendMessage()

method is 122 lines long, very nested and definitely not doing too well on the Single Responsibility front. I'd very much like it refactored and shortened before carrying out #493. To do this, I will separate big chunks of logic into smaller helper methods, and add guard clauses for unhappy paths.
This is a tricky ticket to write acceptance criteria for...

TESTING
As this is a refactor ticket, I'm just going to do some regression testing, making sure everything still works. Especially around chat bot communications.

All looks good to me, checked general chatting, blocked messages, and transformed messages.


Make trace profile names consistent between dotnet-monitor and dotnet-trace

From @noahfalk

Feedback on dotnet-monitor itself: 'Http' could also easily be interpretted as the http client code in the BCL rather than the Http server code in Kestrel. We may want to consider a less generic name.
We should also look at how names here align with names in dotnet-trace --profile. I don't think we want two different sets of named policies.

Tracking more profiles being added to dotnet-trace: https://github.com/dotnet/diagnostics/pull/2132

Preserve existing names and add new names.

If this is confusing in the future, we will add aliases to our profile names.


Login Screen shows 'old' Twitter/X name

Description
The redirects to  'Twitter' login: https://logigator.com/login
It's called 'X' now!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!111

Twitter login got removed, so this is not relevant anymore. :)


nvm_write incompatible pointers  main.c

src/main.c:202:13: warning: passing 'volatile uint8_t *' (aka 'volatile unsigned char *') to parameter of type 'void ' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
nvm_write(&N_storage.dataAllowed, (void)&value, sizeof(uint8_t));
^~~~~~~~~~~~~~~~~~~~~~
/opt/nanos-secure-sdk/include/os_nvm.h:19:30: note: passing argument to parameter 'dst_adr' here
SYSCALL void nvm_write(void *dst_adr PLENGTH(src_len),
^

nvm_write is a ledger function to write 64 byte pages to NVRAM. Looking for the definition of nvm_write to see what makes sense here.
https://github.com/eosnetworkfoundation/ledger-app/blob/main/src/main.c#L200-L204

consolidating duplicate issue different code location
https://github.com/eosnetworkfoundation/ledger-app/blob/d2aa9efd31f7dfe54d778223f703a0c2d9fbe689/src/main.c#L1048-L1055

param src_adr can be null to zero out data. that explains the void *. Need to come up with best fix.
// @param src_adr NULL to fill with 00's
SYSCALL void nvm_write(void *dst_adr PLENGTH(src_len),
                       void *src_adr PLENGTH(src_len), unsigned int src_len);

Found the definition in /opt/nanos-secure-sdk/include/os_nvm.h on the nano ubuntu env.

not blocking leaving, won't fix


iptables, loader: add rules for multi-node NodePort traffic on EKS

Description
Multi-node NodePort traffic for EKS needs a set of specific rules that are usually set by the aws daemonset:
# sysctl -w net.ipv4.conf.eth0.rp_filter=2
# iptables -t mangle -A PREROUTING -i eth0 -m comment --comment "AWS, primary ENI" -m addrtype --dst-type LOCAL --limit-iface-in -j CONNMARK --set-xmark 0x80/0x80
# iptables -t mangle -A PREROUTING -i eni+ -m comment --comment "AWS, primary ENI" -j CONNMARK --restore-mark --nfmask 0x80 --ctmask 0x80
# ip rule add fwmark 0x80/0x80 lookup main

These rules mark packets coming from another node through eth0, and restore the mark on the return path to force a lookup into the main routing table. Without them, the ip rules set by the cilium-cni plugin tell the host to lookup into the table related to the VPC for which the CIDR used by the endpoint has been configured.
We want to reproduce equivalent rules to ensure correct routing, or multi-node NodePort traffic will not be routed correctly. This could be observed with the pod-to-b-multi-node-nodeport pod from connectivity check never getting ready.
This commit makes the loader and iptables module create the relevant rules when IPAM is ENI and egress masquerading is in use. The rules are nearly identical to those from the aws daemonset (different comments, different interface prefix for conntrack return path, explicit preference for ip rule):
# sysctl -w net.ipv4.conf.<egressMasqueradeInterfaces>.rp_filter=2
# iptables -t mangle -A PREROUTING -i <egressMasqueradeInterfaces> -m comment --comment "cilium: primary ENI" -m addrtype --dst-type LOCAL --limit-iface-in -j CONNMARK --set-xmark 0x80/0x80
# iptables -t mangle -A PREROUTING -i lxc+ -m comment --comment "cilium: primary ENI" -j CONNMARK --restore-mark --nfmask 0x80 --ctmask 0x80
# ip rule add fwmark 0x80/0x80 lookup main pref 109

Steps for verification
Apply the patch, build and push the Docker image:
$ DOCKER_DEV_ACCOUNT=qmonnet make dev-docker-image
$ docker push qmonnet/cilium-dev:latest

Follow the instructions to install Cilium on AWS EKS. When deploying Cilium with Helm, do not forget to pass the location of the custom image for the agent:
$ helm install cilium [...] --set agent.image=docker.io/qmonnet/cilium-dev

Deploy the connectivity check. Pick the version from Cilium v1.8 (latest version does not have pod-to-b-multi-node-nodeport:
$ kubectl apply -f https://raw.githubusercontent.com/cilium/cilium/v1.8/examples/kubernetes/connectivity-check/connectivity-check.yaml

Wait a few seconds. On a cilium pod, the newly-added rules should be visible:
# sysctl net.ipv4.conf.eth0.rp_filter
net.ipv4.conf.eth0.rp_filter = 2
# iptables-save|grep -w 0x80
-A CILIUM_PRE_mangle -i eth0 -m comment --comment "cilium: primary ENI" -m addrtype --dst-type LOCAL --limit-iface-in -j CONNMARK --set-xmark 0x80/0x80
-A CILIUM_PRE_mangle -i lxc+ -m comment --comment "cilium: primary ENI" -j CONNMARK --restore-mark --nfmask 0x80 --ctmask 0x80
# ip rule|grep -w 0x80
109:    from all fwmark 0x80/0x80 lookup main

All pods from the connectivity-check should be marked as ready, in particular the pod-to-b-multi-node-nodeport:
$ kubectl get pods
NAME                                                     READY   STATUS    RESTARTS   AGE
echo-a-58dd59998d-ct49w                                  1/1     Running   0          3m8s
echo-b-865969889d-xlb2v                                  1/1     Running   0          3m8s
echo-b-host-659c674bb6-895qn                             1/1     Running   2          3m8s
host-to-b-multi-node-clusterip-6fb94d9df6-7lk9s          1/1     Running   1          3m8s
host-to-b-multi-node-headless-7c4ff79cd-9zk4c            1/1     Running   1          3m8s
pod-to-a-5c8dcf69f7-5jnmh                                1/1     Running   0          3m8s
pod-to-a-allowed-cnp-75684d58cc-flpb9                    1/1     Running   0          3m8s
pod-to-a-external-1111-669ccfb85f-mljxd                  1/1     Running   0          3m7s
pod-to-a-l3-denied-cnp-7b8bfcb66c-tnqqf                  1/1     Running   0          3m8s
pod-to-b-intra-node-74997967f8-phb8v                     1/1     Running   0          3m8s
pod-to-b-intra-node-nodeport-775f967f47-8tjkq            1/1     Running   1          3m8s
pod-to-b-multi-node-clusterip-587678cbc4-4kzpg           1/1     Running   0          3m7s
pod-to-b-multi-node-headless-574d9f5894-vsbjt            1/1     Running   1          3m7s
pod-to-b-multi-node-nodeport-7944d9f9fc-wn4j2            1/1     Running   1          3m7s
pod-to-external-fqdn-allow-google-cnp-6dd57bc859-4h4pj   1/1     Running   0          3m7s

Discussion
I am not entirely sure of my implementation. In particular, reviewers might want to consider:

Is this the best location to add the rules? I initially considered the AWS-related code for the cilium-cni but I don't think this is used to manage the node itself.
Should the rules depend on masquerading being used? I was under the impression we always use it for EKS, and that the interface we use for egress masquerading is the one to target with the rules. But I may be wrong.
I picked a preference for the ip rule (linux_defaults.RulePriorityEgress - 1) so it gets looked up just before the rule we want to avoid, but maybe I should create a new constant in linux_defaults for that? Not sure if this is worth.
Style: The processing of interface names for the ip rule addition feels a bit cumbersome (with this + prefix to process). I'm not sure we have a helper for this somewhere, I could not find one (other lxc+-style names are passed directly to iptables from what I could see). We do have a helper somewhere for setting rp_filter but it is not used in Reinitialize() from the loader, so I just stuck to local code and appended to sysSettings.

Tests
None in this PR. Ready-state can be tested with connectivity check from Cilium v1.8 (I didn't realise it was gone until writing this description).
Follow-up: Re-introduce pod-to-b-multi-node-nodeport or equivalent in connectivity checks.
Fixes: #12098

test-me-please

Sidenote: Discussing with @joestringer on Slack, it appears that the removal of pod-to-b-multi-node-nodeport from the connectivity checks was unintentional. I'll work on restoring it, but this may be for a follow-up PR and should not be blocking this one.

Coverage decreased (-0.04%) to 36.826% when pulling dada054d955d01adcdd340b4a6ff1acca896fe60 on pr/qmonnet/eks_nodeport_rulefix into 9606ff5a7552cbb8c4160ef3ff19111e05930b8f on master.

Thanks a lot Tobias, Chris and Joe for the verification and the reviews! It's been really helpful and much appreciated.
I addressed the comments from Tobias and Chris, there are some points that I still need to sort out regarding Joe's feedback (see inline answers).
Incremental diff
diff --git a/pkg/datapath/iptables/iptables.go b/pkg/datapath/iptables/iptables.go
index c59a76f5399a..b6f424ca646d 100644
--- a/pkg/datapath/iptables/iptables.go
+++ b/pkg/datapath/iptables/iptables.go
@@ -1037,10 +1037,10 @@ func (m *IptablesManager) InstallRules(ifName string) error {
 	}

 	// EKS expects the aws daemonset to set up specific rules for marking
-	// packets It marks packets coming from another node and restores the
+	// packets. It marks packets coming from another node and restores the
 	// mark on the return path to force a lookup into the main routing
 	// table. We want to reproduce something similar. Please see note in
-	// Reanitialize() in package "loader" for more details.
+	// Reanitialize() in pkg/datapath/loader for more details.
 	if option.Config.Masquerade && option.Config.IPAM == ipamOption.IPAMENI {
 		if err := m.addCiliumENIRules(); err != nil {
 			return fmt.Errorf("cannot install rules for ENI multi-node NodePort: %w", err)
@@ -1153,6 +1153,8 @@ func (m *IptablesManager) addCiliumNoTrackXfrmRules() error {
 }

 func (m *IptablesManager) addCiliumENIRules() error {
+	nfmask := fmt.Sprintf("%#08x", linux_defaults.MarkMultinodeNodeport)
+	ctmask := fmt.Sprintf("%#08x", linux_defaults.MaskMultinodeNodeport)
 	if err := runProg("iptables", append(
 		m.waitArgs,
 		"-t", "mangle",
@@ -1160,7 +1162,7 @@ func (m *IptablesManager) addCiliumENIRules() error {
 		"-i", option.Config.EgressMasqueradeInterfaces,
 		"-m", "comment", "--comment", "cilium: primary ENI",
 		"-m", "addrtype", "--dst-type", "LOCAL", "--limit-iface-in",
-		"-j", "CONNMARK", "--set-xmark", "0x80/0x80"),
+		"-j", "CONNMARK", "--set-xmark", nfmask+"/"+ctmask),
 		false); err != nil {
 		return err
 	}
@@ -1170,6 +1172,6 @@ func (m *IptablesManager) addCiliumENIRules() error {
 		"-A", ciliumPreMangleChain,
 		"-i", getDeliveryInterface(""),
 		"-m", "comment", "--comment", "cilium: primary ENI",
-		"-j", "CONNMARK", "--restore-mark", "--nfmask", "0x80", "--ctmask", "0x80"),
+		"-j", "CONNMARK", "--restore-mark", "--nfmask", nfmask, "--ctmask", ctmask),
 		false)
 }
diff --git a/pkg/datapath/linux/linux_defaults/linux_defaults.go b/pkg/datapath/linux/linux_defaults/linux_defaults.go
index 8d9dda86755b..33040aa7324c 100644
--- a/pkg/datapath/linux/linux_defaults/linux_defaults.go
+++ b/pkg/datapath/linux/linux_defaults/linux_defaults.go
@@ -34,6 +34,15 @@ const (
 	// RouteMarkMask is the mask required for the route mark value
 	RouteMarkMask = 0xF00

+	// MarkMultinodeNodeport is used on AWS EKS to mark traffic from another
+	// node, so that it gets routed back through the relevant interface.
+	MarkMultinodeNodeport = 0x80
+
+	// MaskMultinodeNodeport is the mask associated with the
+	// RouterMarkNodePort for NodePort traffic from remote nodes on AWS
+	// EKS.
+	MaskMultinodeNodeport = 0x80
+
 	// IPSecProtocolID IP protocol ID for IPSec defined in RFC4303
 	RouteProtocolIPSec = 50

@@ -46,6 +55,13 @@ const (
 	// of endpoints. This priority is after the local table priority.
 	RulePriorityEgress = 110

+	// RulePriorityNodeport is the priority of the rule used on AWS EKS, to
+	// make sure that lookups for multi-node NodePort traffic are NOT done
+	// from the table for the VPC to which the endpoint's CIDR is
+	// associated, but from the main routing table instead.
+	// This priority is before the egress priority.
+	RulePriorityNodeport = RulePriorityEgress - 1
+
 	// TunnelDeviceName the default name of the tunnel device when using vxlan
 	TunnelDeviceName = "cilium_vxlan"

diff --git a/pkg/datapath/loader/base.go b/pkg/datapath/loader/base.go
index 629cebf118ee..75ef8197fb53 100644
--- a/pkg/datapath/loader/base.go
+++ b/pkg/datapath/loader/base.go
@@ -137,8 +137,9 @@ func getEgressMasqueradeInterfaces() ([]string, error) {
 			ifaces = append(ifaces, l.Attrs().Name)
 		}
 	} else {
+		ifPrefix := strings.TrimSuffix(*egMasqIfOpt, "+")
 		for _, l := range links {
-			if strings.HasPrefix(l.Attrs().Name, (*egMasqIfOpt)[:len(*egMasqIfOpt)-1]) {
+			if strings.HasPrefix(l.Attrs().Name, ifPrefix) {
 				ifaces = append(ifaces, l.Attrs().Name)
 			}
 		}
@@ -358,9 +359,9 @@ func (l *Loader) Reinitialize(ctx context.Context, o datapath.BaseProgramOwner,
 				setting{"net.ipv4.conf." + iface + ".rp_filter", "2", false})
 		}
 		if err := route.ReplaceRule(route.Rule{
-			Priority: linux_defaults.RulePriorityEgress - 1,
-			Mark:     0x80,
-			Mask:     0x80,
+			Priority: linux_defaults.RulePriorityNodeport,
+			Mark:     linux_defaults.MarkMultinodeNodeport,
+			Mask:     linux_defaults.MaskMultinodeNodeport,
 			Table:    route.MainTable,
 		}); err != nil {
 			return fmt.Errorf("unable to install ip rule for ENI multi-node NodePort: %w", err)

From discussion on Slack, while this is important to fix and it would be great to include in a release shortly, it should not block other important fixes from being released. Removed the corresponding label.

test-me-please

Discussion on Slack (link and link):
The fix in this PR solves the basic case but is not the perfect solution and will likely need follow-ups.
The ideal fix should add the rules for all interfaces, but the list of interfaces that can be used for traffic between nodes is not trivial to obtain. Thomas has worked on a more comprehensive fix, with:

Extended IPAM to store full IPAM result so we get MACs of all ENIs
Set up marks on ingress with 0x80000000 | ifindex to have unique marks for each ENI
Set up iptables rules via pkg/datapath/loader on initial build
Move sysctl setting to that hook as well

As of the Slack discussion, there was at least the following item remaning:

Change ip rules to lookup the table of the ENI instead of the main table

Long term, it may be worth to look at a pure eBPF implementation as well.

4.9 run hit known issue #12993 which randomly affects some PRs and causes significant numbers of failures. Given that the 4.19 tests all passed, I take that to mean that these are flakes and there is no reliable failure here. Waiting to hear back on net-next CI run.

Please also give me a bit more time to validate it on EKS. Although I don't expect any surprise, I haven't had time to run the latest version yet.

The test K8sPolicyTest Multi-node policy test validates ingress CIDR-dependent L4 connectivity is restored after importing ingress policy failed with an inaccurate count where we expect a specific number of packets but the number is off-by-two. I see a similar failure in the quarantined "host" variation of this test (from https://datastudio.google.com/s/n3goM_hIP4Y), and generally it seems similar to previous monitor tests where we test for specific packet counts and end up being off by a couple of packets sometimes due to test infrastructure not being able to track all packets.
Given that the code in this PR depends on IPAMENI mode which is not enabled in any of the test cases, this is clearly a flake so we can safely ignore to merge.


D3D12/DXGUID broken?

My current task is to implement a simple abstraction above D3D12 using pure C.
In the initialisation procedure I reference IID_IDXGIAdapter4 (Querying interface from IDXGIAdapter1 to IDXGIAdapter4). However, this code does not build, as the linker is not able to resolve its symbol.
I have following libraries linked, which to my understanding, should be sufficient
d3d12.lib
dxgi.lib
dxguid.lib

Am I missing something? (I am building with WinSDK 10.0.18362.0).
P.S.: Also, I am not sure, whether this is the right place to post such things, but reading the other issues it seems like so. Correct me, if I am wrong.

It's just a bug. The dxgi1_6.h header was never added to the dxguid.lib.

You'll also need an SDK preview newer than 19041 in order to have proper C headers for D3D12. Prior to that, MIDL doesn't produce ABI-correct function declarations for some of our functions, specifically the ones which return structures.

This bug is fixed in the current Windows 10 SDK Insider Preview builds

@jenatali I am wondering. If I use MIDL (from an SDK newer than 19041) to generate a new header and use this header over the default D3D12.h, would I be able to circumvent that problem?
Are only the declarations broken or is there something going on within the implementation that might be broken as well for prior versions?

The issue is not with the header. It's the fact that the DXGUID.LIB generation wasn't done with dxgI1_6.h included.###
You can use __uuidof instead or you can just define your own instance of the missing GUIDs.

@HiImJulien Yes-ish. There's a new command line switch to MIDL which produces correct C headers for C++ implementers of returning structs via COM: /cstruct_out. Though at that point you might as well just grab the updated d3d12.h from the newer SDK instead of making your own.

@jenatali Is there a documentation regarding /cstruct_out anywhere? Also in which version did it appear? Thank you!

I didn't write documentation for it, so probably not. I'll see if I can get that added.
The updated MIDL should be present in SDKs versioned 19547 or newer.

@jenatali Or I could use your repository, that you created sneakily.
This is perfect, because I am stuck on a machine without any administrative privileges. The machine is stuck on "10.0.18362.0".

Ah, right, I didn't even think about the fact that would fix this issue otherwise I would've mentioned it here.

I guess it's time to close this, as this is finally solved.

This bug in dxguid.lib is fixed in  Windows 10 SDK (20348), version 2104.


End() cleanup Crash when calling invalid officer

Calling officer without checking if officer is valid
can result in calling invalid officer. causes crash
foreach (var officer in UnitOfficers) {
    officer.Delete();
}

Reported Error Log: (anonymized)
RagePluginHook.log


review: Ontology term: small mitochondria present in increased numbers, with normal total mitochondrial volume (FYPO:0003810)

Ontology term: small mitochondria present in increased numbers, with normal total mitochondrial volume (FYPO:0003810)

Definition
Parents

A cell phenotype observed in the vegetative growth phase of the life cycle in which total mitochondrial volume is normal, but mitochondria are smaller and more numerous than normal.

[ ]  Either:
remove  with normal total mitochondrial volume
OR
add an additional term.

[ ] Update PMID:37590302

see https://github.com/pombase/fypo/issues/4421


Don't overwrite existing litecoin.conf

I can't merge this, this would break my deployments of BTCPay because I always set the configuration file as environment variable in docker-compose.
If one day I decide to change the config file, in the docker-compose it won't be reflected because of this.
Add an environment variable like LITECOIND_DO_NOT_OVERWRITE.


feat: strict policy definition validation

WHAT
Enables strict policy definition validation by default. If necessary the validation can be disabled with helm configuration/ env variables.
Two additional Constraint functions were introduced:

ContractReferenceConstraintFunction  (cx-policy:ContractReference)
UsagePurposeConstraintFunction (cx-policy:UsagePurpose)

Both evaluate to true always, they are only there as placeholder for enabling the  validation of policy definitions.
WHY
user experience
FURTHER NOTES
The current validation only checks if there are functions that can be evaluated with the posted policy definition and the left operand is bound to at least a policy context.
Additional validation could be introduced in policy functions by implementing AtomicConstraintRuleFunction#validate which allows validating for example right operand values and operators supported.
Closes #1685

/cc @gerbigf


Remove OpenShift expose config property as it has been removed from Quarkus

Summary
Quarkus doesn't recognize this property and we already set quarkus.openshift.route.expose.
Please see https://github.com/quarkusio/quarkus/pull/30977 for more information.
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

OC failures seems related but the change is ok. Let's rerun OC tests to make sure

run tests

run tests

OpenShift test failure is unrelated and was fixed by https://github.com/quarkus-qe/quarkus-test-framework/pull/852


nsd: 4.1.24 -> 4.1.25

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nsd/versions.
meta.description for nsd is: '"Authoritative only, high performance, simple and open source name server"'.

Checks done (click to expand)

built on NixOS
/nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin/nsd passed the binary check.
Warning: no invocation of /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin/nsd-checkconf had a zero exit code or showed the expected version
/nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin/nsd-checkzone passed the binary check.
Warning: no invocation of /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin/nsd-control had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin/nsd-control-setup had a zero exit code or showed the expected version
2 of 5 passed binary check by having a zero exit code.
0 of 5 passed binary check by having the new version present in output.
found 4.1.25 with grep in /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25
directory tree listing: https://gist.github.com/43f2d8bbd65561b1489d957a8fe18303
du listing: https://gist.github.com/43fdd2652b10c9a1deb57cda14726d05

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/328144f5ade461e80467bc0b42cb0574fb17ae22.tar.gz -p nsd
ls -la /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25

cc @hrdinka for testing.

Success on x86_64-darwin (full log)
Attempted: nsd
Partial log (click to expand)
./install-sh -c -m 644 nsd-control.8 /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/share/man/man8/nsd-control.8
./install-sh -c -m 644 nsd.conf.5 /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/share/man/man5/nsd.conf.5
post-installation fixup
gzipping man pages under /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/sbin
patching script interpreter paths in /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25
/nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/sbin/nsd-control-setup: interpreter directive changed from "/bin/sh" to "/nix/store/f2lp21azk4w88f17zgf4mji64agb18ga-bash-4.4-p23/bin/sh"
moving /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/sbin/* to /nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25/bin
/nix/store/jvpcfcz79ndcbgz4fr490wwkkbprjvfj-nsd-4.1.25

Success on aarch64-linux (full log)
Attempted: nsd
Partial log (click to expand)
shrinking /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/sbin/nsd-checkconf
shrinking /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/sbin/nsd
gzipping man pages under /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/sbin
patching script interpreter paths in /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25
/nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/sbin/nsd-control-setup: interpreter directive changed from "/bin/sh" to "/nix/store/017xymp5i03qzigafnfx7sgf6602gmzq-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25...
moving /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/sbin/* to /nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25/bin
/nix/store/wiywmw1848w4v4b72sihvq9wx3ir2kbg-nsd-4.1.25

Success on x86_64-linux (full log)
Attempted: nsd
Partial log (click to expand)
shrinking /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/sbin/nsd
shrinking /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/sbin/nsd-control
gzipping man pages under /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/sbin
patching script interpreter paths in /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25
/nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/sbin/nsd-control-setup: interpreter directive changed from "/bin/sh" to "/nix/store/nii7pk6pv4x4as7vsxbvwyzjn67vax6r-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25...
moving /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/sbin/* to /nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25/bin
/nix/store/ys5xg4zcanz3dfifv6dvgrg13wfqvk2g-nsd-4.1.25

Tested locally, thanks!


Update mockito-core to 3.3.3

Updates org.mockito:mockito-core from 3.3.0 to 3.3.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-core" } ]

labels: library-update, semver-patch

Codecov Report

Merging #222 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   47.68%   47.68%
=======================================
  Files          24       24
  Lines         281      281
  Branches        1        1
=======================================
  Hits          134      134
  Misses        147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2b094...94bac20. Read the comment docs.


How to perform the retrieval and comparison tasks on validation set

Dear authors,
    Thanks for providing this amazing dataset.
    I would like to test the performance of my model on your reasoning benchmark.
    Could you please provide more details on how to test models on the benchmark? How to extrat distractors for retrieval and comparison tasks from https://storage.googleapis.com/ai2-mosaic-public/projects/sherlock/data/sherlock_val_with_split_idxs_v1_1.json.zip?
    I would like to know how I can get the split index for the retrieval tasks and distractor inferences for the comparison tasks.
    Thanks in advance.

Regards,
Zhenfang

Hi Zhenfang,
Thanks for your interest in our work! There are details/examples/scripts of how to compute the official leaderboard metrics on the validation set here:
https://github.com/allenai/sherlock/tree/main/leaderboard_eval
The leaderboard formatted data is split on the particular index. For something a bit more lightweight, here's an example of how to get the evaluation metrics for, e.g., mean rank, during training
https://github.com/allenai/sherlock/blob/main/training_code/train_retrieval_clip.py#L526-L536
Jack

Solved.