Set Clang-format column width to 120

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3d9cafa) 97.16% compared to head (fc288fc) 96.16%.

Files
Patch %
Lines

src/strategies/flexiblerollout.cpp
85.71%
1 Missing :warning:

src/strategies/gradualrolloutrandom.cpp
80.00%
1 Missing :warning:

src/strategies/gradualrolloutsessionid.cpp
83.33%
1 Missing :warning:

src/strategies/gradualrolloutuserid.cpp
83.33%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   97.16%   96.16%   -1.00%
==========================================
  Files          16       16
  Lines         317      313       -4
==========================================
- Hits          308      301       -7
- Misses          9       12       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Styleguide changes [Batch 1.2]

Removed read statement from scripts,
Converted run to sentence-case;
Removed <> brackets;
Converted run parameters PARAMS to params;
Code, grammar, and markdown refactoring/reformatting;
Removed "Step #" from headings

@kamil-kaczmarek

You changed code in many files: PARAMS -> params -> pls make sure that tests are passing.

Tests look good... we've many import errors.. might have to fix the tests

Worth adding to the DSG that NB needs a title as H1. This will also have downstream effect on the notebook headers hierarchy.

Will add titles and adjust hierarchy of other headers. @normandy7 , can you add this to the notebook template too?

In the next batch, we should change ' to " in NBs and scripts.

Already done for code cells and scripts... missed a few in markdown cells. Will update
Working on the other revisions

can you add this to the notebook template too

Will do. In well-formed Markdown, you start with h1 and then consecutively increase heading levels without skipping any. One of my (many) complaints about GitBook is that it doesn't mark the page title as h1, but instead label the first section heading as h1, even though it's ## in the source... But soon we'll be doing all of this directly in source mode instead :)

@SiddhantSadangi seems that @normandy7 applied batch of comments. Can you check it and re-request review?

@SiddhantSadangi did you have a chance to have a look at this PR and resolve @normandy7 suggestions?

@kamil-kaczmarek , yup... I've pushed changes and requested a re-review from @normandy7

@SiddhantSadangi ok, let me have a look as well

"Neptune UI" should be just "Neptune" (or "Neptune app" if there is a clear need to distinguish between client and UI)

The docs still mention Neptune UI. We should first make the changes in the docs if this is going to be our standard terminology

"Neptune UI" should be just "Neptune" (or "Neptune app" if there is a clear need to distinguish between client and UI)

The docs still mention Neptune UI. We should first make the changes in the docs if this is going to be our standard terminology

The docs mention both, but on the product side, "app" has already been agreed on. I won't be making bulk changes as long as we have GitBook since it might break things unexpectedly, but I've changed "UI" to "app" where I've come across it.
If you think it's outside the scope of this PR, that's alright, but there is no need to hold back with this artificially. (Changing "app" to "UI" at this point seems a bit backwards, though.)


Bdmoore1 add vscode 0928

Existing Sample Changes
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Command Line
[ ] oneapi-cli
[ ] Visual Studio
[ ] Eclipse IDE
[ ] VSCode
[ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample
Delete this line and all above it if this PR is for a new code sample
Adding a New Sample(s)
Description
Please include a description of the sample
Checklist
Administrative

[ ] Review sample design with the appropriate Domain Expert:
[ ] If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

[ ] Implement coding guidelines and ensure code quality. see wiki for details
[ ] Adhere to readme template
[ ] Enforce format via clang-format config file
[ ] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
[ ] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
[ ] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

[ ] OSPDT Approval (see @JoeOster for assistance)
[ ] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
[ ] Bandit Scans (Python only)
[ ] Virus scan

Review

[ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
[ ] Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
[ ] Tested using Dev Cloud when applicable

@bdmoore1 -- Tom Ingleby is @tingleby and I don't know what Donna Boyer's user ID is.

I tried to capture Paul's intent. I don't want to give explicit instructions on opening a terminal before they've set their environment. Hopefully this accomplishes that. Also I moved the VS Code section above the CLI instructions in the readme, so that I can say "see instructions below".

@praveenkk123 I changed the pull request. Paul Fischer had a suggestion to make some changes but they were not required for this PR. I will make those changes in a future PR so you can merge this one when you are ready.


chore: add codeql analysis

What this PR does / why we need it:
This patch adds codql (from github) to our CI in order to scan regularly for vulnerabilities in our code and other
common language problems.

@mflendrich rebased


New Bluesky user

Andrew Taylor
https://bsky.app/profile/andrewstaylor.bsky.social
Intune MVP

Done. Added!


[TC-TM-1.1]- In Temperature Measurement Cluster, the cluster revision value is not matched with the expected outcome.

In Temperature Measurement Cluster, testcase 1.1 (TC-TM-1.1), the "cluster revision attribute" value must be 4 as per the Testplan,
But the actual outcome is 3. This needs to be fixed as per Test plan expected outcome.
Test Test-plan link:
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/temperaturemeasurement.adoc
expected behavior - cluster revision attribute - 4
actual behavior - cluster revision - 3
Actual command:- ./chip-tool temperaturemeasurement read cluster-revision 1 1
Actual log is attached below
[TC-TM-1.1]-Cntr.txt

dup to https://github.com/project-chip/connectedhomeip/issues/12190

https://github.com/project-chip/connectedhomeip/issues/12190


compile error in Xcode 10

Hi,
I was using 7.0.0 version in  xcode 9, everything is ok. But when I upgrade my xcode to xcode 10,  I've got following error when compiled.

I ran into the same issue. I've created a pull request that solves it but it has yet to be approved and merged.
https://github.com/ankurp/Cent/pull/32

Hello，I  got a error in xcode10，How can I solve that?

If you are using Cocoapods you can point the Cent pod to my fork.
pod 'Cent', :git => 'https://github.com/ashitanojoe/Cent.git'
Or if you aren't comfortable doing that, you can create your own fork and merge/copy my changes into it, and point the Cent pod to your own fork. Otherwise you will have to wait for the pull request to be merged.

I have merged the code to remove this. Thanks @ashitanojoe


Update dependencies

Bumping to alpha08 to get the latest RemoteMediator fixes which fixes a crash to do with cancellation in remote REFRESH.
Also updating a few other things while I'm at it :smile:

@florina-muntenescu

All steps updated!


Consolidate Security related settings into a single form

Overview
The current settings are poorly organized and are unnecessarily confusing.
Acceptance Criteria

All individual settings under 'Authentication' section should be consolidated into a single compound form under a new 'Security' section
Clickatell settings should not be its own section but be moved under the SMS section and renamed 'Clickatell Gateway'
'Emails enabled' and 'Redirect all emails to' should be consolidated into 'SMTP Settings' (in separate panels)
All individual settings under 'One-Time Pins' section should be consolidated into a single compound form called 'One-Time-Pins' under the 'Security' section
'Push' settings should be moved to the Shesha.Mobile module and therefore should not appear under Core
RabbitMQ should be moved to Shesha.Enterprise module and therefore should not appear under Core
'Redirect all messages to' and 'SMS Gateway' settings should be consolidated under a compound SMS settings page

Include this item in the breaking changes section of the release notes


Update volumes.md - adjusted cephfs

Hi @iamgini, there is already PR opened to fix this issue, Here is the PR: #44657
/triage duplicate

Closing this since it's a duplicate of changes in PR https://github.com/kubernetes/website/pull/44657 and this PR does not have a proper description
/close


Create CS8817

Summary
Add new undocumented error page, CS8817.

Internal previews

📄 File
🔗 Preview link

docs/csharp/language-reference/compiler-messages/cs8817.md
Compiler Error CS8817

docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md
Sorry, we don't have specifics on this C# error

May I know how to determine whether a fresh new error page belongs in compiler-messages or misc?


Version Installation

Hi,
I'm new user to this, and I started using this a few days ago, and I have MacOS 10.12.4, which the only way I could install this was using OPAM, but after the installation it's telling me that I have 0.6.15 and here show the latest version is 0.6.17, I know not much is changed, but I'm not sure if the OPAM didn't get the update, or I'm doing something wrong.
I would appreciate it if someone lead me to right direction.

You are right, I've not yet uploaded 0.6.17 to the OPAM repository, but there are no big differences between 0.6.15 and 0.6.17 (just a fix for Google Apps Scripts json files and a useless option removed).

Thanks :)