Unable to populate files data on unit tests

I am trying to unit test flask file uploader code
@bp.route('/upload', methods=['POST'])
def api_upload_replays():
   .... unrelated code

    uploaded_files = request.files.getlist("replays")

But no matter what I put into my unit tests this is always empty
self.context = app.test_client()
file_storage = FileStorage(stream=f, filename='replays')
response = self.context.post('/api/upload', data={'files':(file_storage, 'replays')})

How do I correctly fill out data so that the files result is filled out correctly like it is in production?

Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.

https://stackoverflow.com/questions/56096412/requests-in-test-for-flask-app-is-has-no-files
I did write a stack overflow I would love it if you could comment on it then :)


Add exclude_pattern argument to dependency_tree

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

coverage: 91.538% (+0.1%) from 91.406%
when pulling 392ce81a9531d54a58c076ff5e9408f8b1b3603e on better_graphviz
into b4910e560a6a7f11288a4368816e692c26f8bc73 on master.


Add ISO 8601 (Date) as Template

We need an OpenAPI template for ISO 8601.

Nice to have as query parameter and schema property.

Example here:
https://www.postman.com/postman/workspace/postman-open-technologies-openapi-governance-templates/api/eb32d2f8-f6c9-472f-868d-62b7f0e8005c/version/a9f4a852-f0fb-4e16-9bba-3726813294ee


ssl2

If I try to use -ssl2 it tells me: unknown parameter. Do you have the same issue or does anyone know, why its not working? ssl3 and the tls versions are working properly.

What version of OpenSSL are you using it and where did you get it from? If you're using a distro version then it is quite likely that SSLv2 support has been compiled out as it is considered insecure.

Matt's advice is solid: SSLv2 is terrible these days.  SSLv3 is not good either and should also be avoided for green-field deployments.

No response from OP. Closing this issue.


#10405 Attaching CORS filter by default to yii\rest\Controller

when following common docs examples on implementing behaviors by doing this:
class TokenController extends \yii\rest\Controller
{

    public function behaviors()
    {
        $behaviors = parent::behaviors();

        $behaviors['corsFilter'] = [
            'class' => \yii\filters\Cors::className(),
        ];

        $behaviors['authenticator'] = [
            'class' => \yii\filters\auth\HttpBearerAuth::className(),
            'except' => ['options'],
        ];

        return $behaviors;
    }

the $behaviors outputs structure will look like this:
Array
(
    [contentNegotiator] => Array(...)
    [verbFilter] => Array(...)
    [authenticator] => Array(...)
    [rateLimiter] => Array(...)
    [corsFilter] => Array(...)
)

corsFilter will always be sent to the bottom of the array and treated after authenticator because only authenticator is defined in the parent array at yii\rest\Controller::behaviors() (see code here) which raises those kind of errors in browsers:
XMLHttpRequest cannot load http://localhost/foundapps/backend/auth/token/revoke. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8079' is therefore not allowed access.

This is expected as it is already mentioned in CORS docs :

The Cors filter should be defined before Authentication / Authorization filters to make sure the CORS headers will always be sent.

It usually happens when authentication fails like a request header holding an expired token so CORS won't be reached. To prevent the issue we could merge arrays without defining keys as it is done in the CORS docs I just linked (authentication will be defined twice but the one we need will be sent to bottom and CORS will be treated) or we can simply define CORS in yii\rest\Controller with its default values (see here) which I think it should be fine as it is a must do when doing REST web apps any way.
This may fix #10405, #6254 and #8626 and could also be related to  #6804 and #7966.

unsetting the parent authenticator that we won't use any way is a better option to make it work with current code: see https://github.com/yiisoft/yii2/issues/6254#issuecomment-199736037.
I also think that something about adding 'except' => ['options'] to the authenticator filter should be mentioned in docs. As a note maybe after the 2 first implementation samples here ?

simply adding the Cors filter like this will let it automatically respond with Origin: * on APIs that did not respond before. This will break existing apis.

@tunecino I have updated the guide to cover this problem. can you please check my commit  	7ba631b if everything is correct?

:+1: perfect


⚠ Cioos National CKAN Sitemap has degraded performance

In f90a509, Cioos National CKAN Sitemap (https://catalogue.cioos.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 25500 ms

Resolved: Cioos National CKAN Sitemap performance has improved in 12b6f98 after 3 minutes.


enhanced ui for tic tac toe

This PR enhances the user interface (UI) for the Tic-Tac-Toe app to provide a more modern, user-friendly experience. The updated design improves overall usability and aesthetics, creating a smoother and more engaging gameplay experience.

here is the output before and after

mention the issue no

#267


cmake: generate the macOS namespace for pugl

This implements the pugl namespace in the macOS build with cmake.
In addition:

for now, disable cairo stuff on macOS (and MSVC)
add the CI workflow for macOS and CMake
make build artifacts available, to validate that macOS namespacing works (it does)
add required changes for macOS to build

Thanks for those, will merge.
Some questions / stuff to verify:

builds need to use -Wl,--no-undefined (default and unavailable on macOS, but should be set for all others)
win32 needs -mstackrealign
macos needs -Wno-deprecated-declarations besides -DGL_SILENCE_DEPRECATION=1

macos needs -Wno-deprecated-declarations besides -DGL_SILENCE_DEPRECATION=1

Can it be silenced by warning suppressions written in code instead?
I wouldn't want no-deprecated-declarations to affect the user code also.

Right, I only applied it when building DGL, things will be different in cmake.


Allow CTR mode counter to overflow until it cycles

Fixes #198

LGTM, but I'll ask @thaidn to double-check as it changes crypto.

Two comments:

Can you test this against more NIST SP 800-38A test vectors?
It's a bad design to allow callers to specify the IV. You will have to ensure that each time you call e2e.ciphermode.Ctr.prototype.encryptSync, the IV is correctly generated. Why don't you generate a random IV in e2e.ciphermode.Ctr.prototype.encryptSync?

.encrypt is inherited from ciphermode which specifies an IV parameter.
.encryptSync performs the encrypt operation minus wrapping in an async Result.

Additional tests added in #284

Rebuild CI

@thaidn, some more test vectors have been added in 7fa39bb1cce553ce39c42af5eebb7aac46d2fe1d. As for IV, Ryan is right - we use this design for all other ciphermodes.


For revisions that add or change the Publication DOI, the citations for all datasets in the collection must be updated.

Requires writing to labeled h5ad, rds, and cxg artifacts. Implementation Requirements TBD

@brianraymor if the publication DOI is updated in a revision, but it is the only change affecting a particular dataset in that revision--should the update to the 'citation' field represent a new dataset version (and thus, we retain the previous dataset version history with the prior citation)? or should it be an in-place update and retain the same version ID?

The original policy was based on the fact that updating collection information had no impact on the dataset. If a DOI is added or updated in a revision, then dataset metadata is being updated. Therefore, I would agree that this is a new dataset version.

CC: @jahilton ^^^


GH-36655: [Dev] Fix fury command to upload nightly wheels

Rationale for this change
The fury command was missing the push command.
What changes are included in this PR?
Fix the fury command
Are these changes tested?
Will test with CI.
Are there any user-facing changes?
No

Closes: #36655

github-actions crossbow submit wheel

@github-actions crossbow submit wheels

@github-actions crossbow submit -g wheel

Does this need to be backported? (tagged with 13.0) I suppose the release branch doesn't push wheels to fury?

Does this need to be backported? (tagged with 13.0) I suppose the release branch doesn't push wheels to fury?

I had the same doubt but I am pretty sure is not necessary as:

We specifically check: {%- if arrow.is_default_branch() -%} for this step.
Wheels for 12.0.0 and 12.0.1 were generated and uploaded successfully as part of their releases.


Some VC documents always pass validation

Problem description
The standard mandate that VC documents contain "credentialSubject" property, which are populated with data and some service attributes, the example is shown below:
"credentialSubject": [
  {
    "field1": 123123,
    "@context": [
        "https://ipfs.io/ipfs/bafkreidfufvsbnreh6mitnzleSmyltnxwikik51zbayfrm2j3qdstuw34j"
     ],
    "id": "3841453-234a-425e-924c-820c2904eff4",
    "type":"Test",
  }
]

The id element is required to have values in URI format, this requirement is not followed in the example above. It appears that such mis-formatting of the content of id field makes the validation library to create signatures which then always accepted as 'valid' regardless of the changes in the content of the element.
Step to reproduce
Steps to reproduce the behavior:

Create a VC document with mis-formatted id element as per above
Generate signature
Change value of the field1 attribute (or any other attribute in your document)
Call validation function in the transmute library, observe the 'valid' status reported

Expected behavior
The library needs to report signature as invalid when the document has changed, regardless of the correctness of formatting of the original document.
Screenshots
TBD

Posted on the transmute library repo as https://github.com/transmute-industries/verifiable-data/issues/229

A couple of additional issues with transmute's handling of BBS signatures:
https://github.com/transmute-industries/verifiable-data/issues/230
https://github.com/transmute-industries/verifiable-data/issues/231


Security settings

Update config file
With initial pull request #507   only configuration present in FLW module is coming in dynamic URL setting.
Now i have updated "origin" in each files from "all" to "SYSTEM_MODULE_" and luckily i get all the entries in dynamic URL list.

ok to test


Failed to create projection

Dear SCEC community,
I recently encountered a problem while setting up UCVM on my local computer (Ubuntu 20.04) using the default installation path.
As described in the wiki, I followed the following steps:

git clone https://github.com/SCECcode/UCVMC.git
cd UCVMC/largefiles
./get_large_files.py
./check_largefiles_md5.py
./stage_large_files.py
cd ..
./ucvm_setup.py

However, once "ucvm_setup.py" successfully finished the installation of UCVM, the "make check" command showed an error while creating the UCVM projection:
Failed to create output UCVM projection +proj=aeqd +lat_0=36.0 +lon_0=-120.0 +x_0=0.0 +y_0=0.0
Proj.4 Error: major axis or radius = 0 or not given
Failed to setup proj +proj=aeqd +lat_0=36.0 +lon_0=-120.0 +x_0=0.0 +y_0=0.0.
Failed to initialize UCVM map

I went through the codes of both UCVM and the proj library to see where it originated (from top to bottom):

p->opj = pj_init_plus(pstr); returns NULL (l. 17) in routine ucvm_proj_ucvm_init in "src/ucvm_proj_ucvm.c"
err = pj_ellipsoid (PIN); is set to 2 (l. 594) in pj_init_ctx which eventually returns NULL (l. 600) in "proj-5/src/pj_init.c"
the condition if (0 != ellps_size (P)) is True (l. 94) in pj_ellipsoid in "proj-5/src/pj_ell_set.c"

I did not go further and I still do not know if the problem I observed was only indirectly related to that condition on "ellps_size" but there seems to be an incompatibility of UCVMC, proj and my local configuration.
My configuration is the following:

Ubuntu 20.04 - kernel 5.4.0-050400rc1-lowlatency
libopenmpi libraries version 4.0.3-0ubuntu1
gcc/gfortran binaries version 9.3.0-1ubuntu2

Note that I also tried to install UCVM with downgraded versions for libopenmpi (3.1.3-11build1) and gcc/gfortran (8.4.0-3ubuntu2) but that did not solve the problem.
There is a similar problem mentioned in the wiki: http://scec.usc.edu/scecwiki/index.php?title=UCVM_User_Guide&redirect=no#Proj._4_Error:major_axis_or_radius.3D_0_or_not_given
But in my case, the following is true: "--prefix directory is actually visible to the compute nodes". Therefore, I am not sure how it applies to my problem.
Do you have any idea where the problem could originate from?
Thank you a lot for your help.

Hi,
Could you check if this might be the issue in your case ?
https://github.com/SCECcode/UCVMC/issues/116
Mei

From: Quentin Brissaud<EMAIL_ADDRESS>Sent: Monday, May 11, 2020 4:51 PM
To: SCECcode/UCVMC<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [SCECcode/UCVMC] Failed to create projection (#117)
Dear SCEC community,
I recently encountered a problem while setting up UCVM on my local computer (Ubuntu 20.04) using the default installation path.
As described in the wiki, I followed the following steps:

git clone https://github.com/SCECcode/UCVMC.githttps://urldefense.com/v3/__https://github.com/SCECcode/UCVMC.git__;!!LIr3w8kk_Xxm!5NyuoL-1aPgCX6CaorfRgoRTpKdejnb2MJx2e57AjbRVt_nXyGtWL8KLwtQ$
cd UCVMC/largefiles
./get_large_files.py
./check_largefiles_md5.py
./stage_large_files.py
cd ..
./ucvm_setup.py

However, once "ucvm_setup.py" successfully finished the installation of UCVM, the "make check" command showed an error while creating the UCVM projection:
Failed to create output UCVM projection +proj=aeqd +lat_0=36.0 +lon_0=-120.0 +x_0=0.0 +y_0=0.0
Proj.4 Error: major axis or radius = 0 or not given
Failed to setup proj +proj=aeqd +lat_0=36.0 +lon_0=-120.0 +x_0=0.0 +y_0=0.0.
Failed to initialize UCVM map
I went through the codes of both UCVM and the proj library to see where it originated (from top to bottom):

p->opj = pj_init_plus(pstr); returns NULL (l. 17) in routine ucvm_proj_ucvm_init in "src/ucvm_proj_ucvm.c"
err = pj_ellipsoid (PIN); is set to 2 (l. 594) in pj_init_ctx which eventually returns NULL (l. 600) in "proj-5/src/pj_init.c"
the condition if (0 != ellps_size (P)) is True (l. 94) in pj_ellipsoid in "proj-5/src/pj_ell_set.c"

I did not go further and I still do not know if the problem I observed was only indirectly related to that condition on "ellps_size" but there seems to be an incompatibility of UCVMC, proj and my local configuration.
My configuration is the following:

Ubuntu 20.04 - kernel 5.4.0-050400rc1-lowlatency
libopenmpi libraries version 4.0.3-0ubuntu1
gcc/gfortran binaries version 9.3.0-1ubuntu2

Note that I also tried to install UCVM with downgraded versions for libopenmpi (3.1.3-11build1) and gcc/gfortran (8.4.0-3ubuntu2) but that did not solve the problem.
There is a similar problem mentioned in the wiki: http://scec.usc.edu/scecwiki/index.php?title=UCVM_User_Guide&redirect=no#Proj._4_Error:major_axis_or_radius.3D_0_or_not_given
But in my case, the following is true: "--prefix directory is actually visible to the compute nodes". Therefore, I am not sure how it applies to my problem.
Do you have any idea where the problem could originate from?
Thank you a lot for your help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/SCECcode/UCVMC/issues/117__;!!LIr3w8kk_Xxm!5NyuoL-1aPgCX6CaorfRgoRTpKdejnb2MJx2e57AjbRVt_nXyGtWteBUNnw$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACE7UF5TE4BGHWO3CCNWTNDRRCFQZANCNFSM4M6LBWVA__;!!LIr3w8kk_Xxm!5NyuoL-1aPgCX6CaorfRgoRTpKdejnb2MJx2e57AjbRVt_nXyGtWsFeJvvs$.

Hi Mei,
Thank you for your help.
I actually had the same issue than in #116 , I had to unset the variable PROJ_LIB to make it work.
Additionally, with new mpi libraries such as the version 4.0.3 on Linux, the structure "MPI_Type_struct" does not exist anymore and make the compilation crash in "ue_mpi.c" and "um_mpi.c". Simply switch to "MPI_Type_create_struct" to resolve the issue.
Thank you again.
Quentin

Glad that it worked out for you.
Thank you for the MPI info. We will look into it.
Mei

From: Quentin Brissaud<EMAIL_ADDRESS>Sent: Tuesday, May 12, 2020 8:14 AM
To: SCECcode/UCVMC<EMAIL_ADDRESS>Cc: Mei-Hui Su<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [SCECcode/UCVMC] Failed to create projection (#117)
Hi Mei,
Thank you for your help.
I actually had the same issue than in #116https://urldefense.com/v3/__https://github.com/SCECcode/UCVMC/issues/116__;!!LIr3w8kk_Xxm!7Hiogo9LrOCe2lbdpCxwn0agt4pP7w-xrAIKlfGkPOIQTNFy-oAnGYpyo2k$ , I had to unset the variable PROJ_LIB to make it work.
Additionally, with new mpi libraries such as the version 4.0.3 on Linux, the structure "MPI_Type_struct" does not exist anymore and make the compilation crash in "ue_mpi.c" and "um_mpi.c". Simply switch to "MPI_Type_create_struct" to resolve the issue.
Thank you again.
Quentin
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/SCECcode/UCVMC/issues/117*issuecomment-627409042__;Iw!!LIr3w8kk_Xxm!7Hiogo9LrOCe2lbdpCxwn0agt4pP7w-xrAIKlfGkPOIQTNFy-oAnsKWRM4k$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACE7UFZANOQUA26HXIEVLR3RRFRXBANCNFSM4M6LBWVA__;!!LIr3w8kk_Xxm!7Hiogo9LrOCe2lbdpCxwn0agt4pP7w-xrAIKlfGkPOIQTNFy-oAn0xMb_fU$.


basefd on xml-rs, what did it given as extra?

Hello,
this lib is based on xml-rs. It could be helpfull to have some documentation explaining what's added.
thanks

Yup! It could do with some more examples too.
I'll work on adding them with the next clean-up commit.

thanks


Restore Purchase?

How can ı add restore purchases button? what is the function for it?

Non-renewing subscriptions are like consumable, don't require restore purchase. Because they are consumed (and disappear) once handled by the app.

But my app rejected by Apple cause of this problem. How is it possible ?
Here ;
We found that your app offers In-App Purchase(s) that can be restored but does not include a "Restore Purchases" feature to allow users to restore the previously purchased In-App Purchase(s), as specified in the "Restoring Purchase Products" section of the In-App Purchase Programming Guide
"Users restore transactions to maintain access to content they've already purchased. For example, when they upgrade to a new phone, they don't lose all of the items they purchased on the old phone. Include some mechanism in your app to let the user restore their purchases, such as a Restore Purchases button."
To restore previously purchased In-App Purchase products, it would be appropriate to provide a "Restore" button and initiate the restore process when the "Restore" button is tapped by the user.

Did you have created a purchase product that isn't a non-renewing subscription? Make sure you delete all but the non-renewing subscription.
Ref: http://stackoverflow.com/a/23931953/2343390


When changing a block, replicas ones become duplicated

Describe the bug
Given a block with a replica, when changing original one then the replica is duplicated as a new file
To Reproduce
Steps to reproduce the behavior:

Create a block (airtable in example)
Create a replica in the pipeline (airtable_2 in example)
Modify the original block and save it
The replica block is duplicated as a new file (airtable_2.py in example)

Expected behavior
When changing the original block, replica should not be duplicated as a new file and still point to the original file
Screenshots

Desktop (please complete the following information):

OS: MasOS ventura
Browser: chrome
Version: 120.0.6099.109 (Official Build) (arm64)

Additional context
No

@csauge Is this issue still happening for you? I tried to recreate it but it seems fine for me (making a change to the original block and saving it did not create a new file for the replica block). I tested this on the latest version of Mage (v0.9.62)
Which version of Mage are you using?


Use activeComponentBG for Workspace menu items

Details
Uses a darker grey background for active menu items in the Workspace LHN (Left Hand Nav)
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/171672
Tests

Log into account that has a Workspace setup
Click on your profile pic to bring up settings nav
Click into your setup Workspace to see your options
Click on the menu items and confirm darker grey background on the active item

QA Steps

Same as tests steps above.
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

https://user-images.githubusercontent.com/3387421/127570526-464b3ccf-ba41-4bef-b21a-5985f1f5777a.mov
Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging         in version: 1.0.82-8🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Example of Good Commenting - Hello Mario Engine

I know this isn't really a bug, but I think that this is important for Godot, more specifically its documentation and example projects
https://github.com/HelloFangaming/HelloMarioEngine
This engine written in Game Maker Language is very good at explaining all things written in the object code that aren't immediately obvious from the GameMaker UI (which means such as which parent the object has, which default sprite the object uses, and which mask the object has). For example, the code explains an object's behaviors such as setting the object's creation parameters in the Create event (such as facing direction, which state of the FSM it is in when starting, and which qualities it has such as immune to fireballs, can be stomped, etc.) Speaking of those, it also helped me understand finite state machines in the step events, too (such as how an object changes graphics and movement behavior when it changes to a state, such as throwing, jumping, etc., and how they have variables such as having one sprite when jumping but switch to another when they land). I'm sorry for my fuzzy instructions, because it's been a while since I used that engine due to not wanting to continue development on a project that wasn't GPL-friendly. What I mean to be taken away from this is that I really appreciate when projects do not assume knowledge of the student, and that seeing the same "you do this to x" explanation in each object helped me get the concepts in a general sense.

This was brought up many times, but you have to understand that Godot is
nearly a million lines of code and the internals use advanced programming
techniques that already require programmers to have a considerable
background before tackling many of it's subsystems.
That said, the exposed API should be as best documented and easy to use as
possible, so any feedback on improving this is welcome
On Jul 28, 2017 11:11 PM, "P-Star7"<EMAIL_ADDRESS>wrote:
I know this isn't really a bug, but I think that this is important for
Godot, more specifically its documentation and example projects
https://github.com/HelloFangaming/HelloMarioEngine
This engine written in Game Maker Language is very good at explaining all
things written in the object code that aren't immediately obvious from the
GameMaker UI (which means such as which parent the object has, which
default sprite the object uses, and which mask the object has). For
example, the code explains an object's behaviors such as setting the
object's creation parameters in the Create event (such as facing direction,
which state of the FSM it is in when starting, and which qualities it has
such as immune to fireballs, can be stomped, etc.) Speaking of those, it
also helped me understand finite state machines in the step events, too
(such as how an object changes graphics and movement behavior when it
changes to a state, such as throwing, jumping, etc., and how they have
variables such as having one sprite when jumping but switch to another when
they land). I'm sorry for my fuzzy instructions, because it's been a while
since I used that engine due to not wanting to continue development on a
project that wasn't GPL-friendly. What I mean to be taken away from this is
that I really appreciate when projects do not assume knowledge of the
student, and that seeing the same "you do this to x" explanation in each
object helped me get the concepts in a general sense.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/9962, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z21Hqffx63FfeCsNSmOprl-jRrCdSks5sSpTdgaJpZM4OnOdp
.

Oh, sorry, what I meant was making a project IN Godot, not editing the engine itself. Hello Mario Engine helped me learn a lot about GML, the scripting language in GameMaker.

(Sorry, can't edit)
I've only used Hello Mario Engine in GameMaker instead of using a less-featured base or making a project from scratch, but it made me feel that, even if I couldn't completely replicate its systems, that I was equipped with the knowledge change player physics and actions, make new items, weapons and enemies, and generally all the other creative things that would be required for a platformer-type game, even though I didn't have much prior experience with GML. I hope that the platformer demo for Godot will be educational enough for me to feel the same about GDScript!

Don't get the point of this issue. Is it about the demo projects? If so, you should open an issue in their repository (https://github.com/godotengine/godot-demo-projects). If it's a lack of tutorials, you should post on the documentation repository (https://github.com/godotengine/godot-docs).
Do you want a fully commented project? I'm not sure how helpful that might be. There are tons of different game styles that Godot can handle, it's hard to provide useful commented project for every genre. Don't know the Hello Mario Engine or its code, nor how it presents to the user, but if you need something on Godot, you should be a bit more clear about what you want to see.

If you can't add comments or the details you think documentation or projects need (understandable if you don't know much about the engine), try going to one of the other official communication channels to discuss about it.
There are many GM users lately and all could organize a new documentation section too, like the one for Unity users.

Oh yes, I agree with a "GM to Godot" section. A kind user helped me when I asked on the forums. I haven't used Godot yet because I'm waiting for the 3.0 version, so I'm sorry if what I said was confusing. I just meant to post this as an example of how to effectively include comments in a project in a way that helped me learn.

Discussion has stalled.


How can I enable or disable the drag and drop?

I want control the dnd by a toggle button, can you add this control function?
thanks

Hey @someok, This should be pretty straight forward to implement, but in the mean time you can just conditionally call this.props.onLongPress in the row component depending on whether you want it to be enabled or not.

Closing due to inactivity


When maximized, tile popup not work

https://user-images.githubusercontent.com/43477782/229288851-2c2d8f75-f8f3-4d91-9395-db26b7d9362e.mp4
Hello, sorry to bother you again but there is this bug where if i put a window in full size, the tile script don't work.
I put a video to make you see what i mean

When a window is fullscreened, the script automatically puts it in the front above other tiled windows. Try disabling "tiled windows to the back" in settings and untile the fullscreen window before you fullscreen it. The script puts fullscreen windows back into their tiles when they exit fullscreen, so they will still take up a tiled space.
If this is not your issue, please provide a journalctl log.

Ahhh okay okay.
Thanks, it works.

I added a toggle to the settings as well to configure whether fullscreen windows are kept above, even when they are tiled. This setting may help you if you want to keep tiled windows below for the most part as well.
This is available in the autotile.kwinscript straight from github, I'll release it to the KDE store if the other features in this release are deemed stable enough.

perfect!
Thank you


[INFINITY-1012] parallelize pr tests

Not chomping at the bit to merge this; but want to see what the PR job does with it for sure.

Can you add [WIP] until this is ready for review?

I've figured out I don't need this pull request to run jenkins tests resonably, so I can do one better.


add getUnderlyingEquivalentForPi to basic router and pi token

Codecov Report

Merging #96 (54c7fb6) into master (b67a38c) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   89.95%   89.39%   -0.56%
==========================================
  Files          40       40
  Lines        2448     2461      +13
  Branches      367      368       +1
==========================================
- Hits         2202     2200       -2
- Misses        246      261      +15

Impacted Files
Coverage Δ

...tracts/powerindex-router/PowerIndexBasicRouter.sol
100.00% <100.00%> (ø)

contracts/powerindex-router/WrappedPiErc20.sol
100.00% <100.00%> (ø)

contracts/PowerIndexPoolController.sol
61.90% <0.00%> (-35.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67a38c...54c7fb6. Read the comment docs.

Codecov Report

Merging #96 (54c7fb6) into master (b67a38c) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   89.95%   89.39%   -0.56%
==========================================
  Files          40       40
  Lines        2448     2461      +13
  Branches      367      368       +1
==========================================
- Hits         2202     2200       -2
- Misses        246      261      +15

Impacted Files
Coverage Δ

...tracts/powerindex-router/PowerIndexBasicRouter.sol
100.00% <100.00%> (ø)

contracts/powerindex-router/WrappedPiErc20.sol
100.00% <100.00%> (ø)

contracts/PowerIndexPoolController.sol
61.90% <0.00%> (-35.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67a38c...54c7fb6. Read the comment docs.


Java syntax color for multi line comment didn't work the right way

type
/**
 *  some text
 */

it should show the "some text" in comment style. For now, VIM show it as string's color. Please notice, there are two "*" in the first comment line.

Please discuss this with the syntax file maintainer.

closing


Jsonp error Before you use jsonp, please run "npm i -S jsonp-body".

Error: Before you use jsonp, please run "npm i -S jsonp-body"

    at Function.requireCatch (/home/app/function/node_modules/@ursajs/core/lib/loader/LazyModules.js:10:19)
    at Function.get jsonpBody [as jsonpBody] (/home/app/function/node_modules/@ursajs/core/lib/loader/LazyModules.js:14:28)
    at Object.jsonp (/home/app/function/node_modules/@ursajs/core/lib/extends/Context.js:19:43)
    at jsonp (/home/app/function/node_modules/@ursajs/core/lib/extends/Results.js:27:20)
    at Function.finish (/home/app/function/node_modules/@ursajs/core/lib/core/Result.js:69:52)
    at callMethod (/home/app/function/node_modules/@ursajs/router/lib/router.js:55:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Should it be add to dependencies in frame core modules? but now , i need npm install this dependent in my project package.json

Add dependencies when using, the purpose is to reduce dependencies, speed up installation,
and also allow users to control the version by themselves.


[blockchain] clean consensus service

just remove consensus service in ~block.go~ service.go in blockchain component

작업하겠습니다


Version 1.8.11 Debian bulseyes

New Debian version 11 (bulseyes) includes a msmtp upgrade to version 1.8.11 (Debian 10 buster has 1.8.3 by default).
This new version (since 1.8.8) allows to replace From: header with set_from_header on parameter.
Could you please include this parameter in config?
Many thanks

Hello @esprit-libre
Thank you for the feedback.
This role is optimized for Raspberry Pi OS only.
The current Raspberry Pi OS version is based on Debian 10 (Buster).
See also https://en.wikipedia.org/wiki/Raspberry_Pi_OS
So I will not implement this suggestion for the time being.
As soon as Raspberry Pi OS changes to Debian 11 I will adapt the role.
Feel free to fork this repository and make the change yourself.
Best regards
Felix

Hello @esprit-libre,
I have updated the role to Debian Bullseye.
To use the set_from_header switch, just overwrite the msmtp_defaults variable.
Example:
msmtp_defaults:   aliases: "/etc/aliases"   auth: "on"   syslog: "on"   tls: "on"   set_from_header: "on"
Best regards
Felix


[Feature Request] Convienence method Structured Sort

There exists an option ND4J.sort(...) that will ascend or descend the data in the ND array. However, there seems to not be any way to sort rows or columns of data out of the box. 2D sorting seems to be pretty natural, I'm unsure how often 3+ dimensional sorting would be needed.
I propose a method that allows a specific dimension to sorted upon, while maintaining structure of the ND array.
I.E.
Nd4j.sortRows(INDArray array, int idx, boolean ascending)
Nd4j.sortColumns(INDArray array, int idx, boolean ascending)
A rough general purpose:
ND4J.sortByDim(INDArray array, int dimension, int index, boolean ascending)
An example:
array = [
[.32,.22,.34],
[.11,.45,.62],
[.58,.98,.57],
[.43,.52,.74]
]
Nd4j.sortRows(INDArray array, int idx, boolean ascending)
giving us:
array = [
[.58,.98,.57],
[.43,.52,.74]
[.11,.45,.62],
[.32,.22,.34],
]

Very quick sortRows and sortColumn methods I threw together:
public static void main( String[] args ){
	Nd4j.getRandom().setSeed(123);

	INDArray arr = Nd4j.rand(10,4);
	System.out.println("Original:");
	System.out.println(arr);
	System.out.println("\nSort rows (idx=2):");
	System.out.println(sortRows(arr,2,true));

	System.out.println("\nSort columns (idx=1):");
	System.out.println(sortColumns(arr,1,true));

}

public static INDArray sortRows( INDArray in, int idx, boolean ascending ){
	if(in.rank() != 2 ) throw new IllegalArgumentException();

	INDArray out = Nd4j.create(in.shape());
	int nRows = in.rows();
	ArrayList<Pair<Double,Integer>> list = new ArrayList<>(nRows);
	for( int i=0; i<nRows; i++ ) list.add(new Pair<>(in.getDouble(i, idx),i));
	Collections.sort(list, new PairComp(ascending));
	for( int i=0; i<nRows; i++ ){
		Pair<Double,Integer> p = list.get(i);
		out.putRow(i, in.getRow(p.getSecond()));
	}
	return out;
}

public static INDArray sortColumns( INDArray in, int idx, boolean ascending ){
	if(in.rank() != 2 ) throw new IllegalArgumentException();

	INDArray out = Nd4j.create(in.shape());
	int nCols = in.columns();
	ArrayList<Pair<Double,Integer>> list = new ArrayList<>(nCols);
	for( int i=0; i<nCols; i++ ) list.add(new Pair<>(in.getDouble(idx, i),i));
	Collections.sort(list, new PairComp(ascending));
	for( int i=0; i<nCols; i++ ){
		Pair<Double,Integer> p = list.get(i);
		out.putColumn(i, in.getColumn(p.getSecond()));
	}
	return out;
}

public static class PairComp implements Comparator<Pair<Double,Integer>> {
	private final boolean ascending;
	public PairComp(boolean ascending){
		this.ascending = ascending;
	}

	@Override
	public int compare(Pair<Double, Integer> o1, Pair<Double, Integer> o2) {
		if( ascending ) return Double.compare(o1.getFirst(), o2.getFirst());
		else return -Double.compare(o1.getFirst(), o2.getFirst());
	}
}

Output:
Original:
[[0.70,0.29,0.23,0.55]
[0.72,0.42,0.98,0.68]
[0.48,0.39,0.34,0.73]
[0.44,0.06,0.40,0.74]
[0.18,0.18,0.53,0.53]
[0.63,0.85,0.72,0.61]
[0.72,0.32,0.36,0.23]
[0.29,0.63,0.09,0.43]
[0.43,0.49,0.43,0.31]
[0.43,0.89,0.94,0.50]]
Sort rows (idx=2):
[[0.29,0.63,0.09,0.43]
[0.70,0.29,0.23,0.55]
[0.48,0.39,0.34,0.73]
[0.72,0.32,0.36,0.23]
[0.44,0.06,0.40,0.74]
[0.43,0.49,0.43,0.31]
[0.18,0.18,0.53,0.53]
[0.63,0.85,0.72,0.61]
[0.43,0.89,0.94,0.50]
[0.72,0.42,0.98,0.68]]
Sort columns (idx=1):
[[0.29,0.55,0.70,0.23]
[0.42,0.68,0.72,0.98]
[0.39,0.73,0.48,0.34]
[0.06,0.74,0.44,0.40]
[0.18,0.53,0.18,0.53]
[0.85,0.61,0.63,0.72]
[0.32,0.23,0.72,0.36]
[0.63,0.43,0.29,0.09]
[0.49,0.31,0.43,0.43]
[0.89,0.50,0.43,0.94]]

https://github.com/deeplearning4j/nd4j/pull/339


train multistep

when data prepared, and i try to run train_multi_step and modify the corresponding parameters, there is an error occurs.
MTGNN/layer.py", line 187, in forward   s1,t1 = adj.topk(self.k,1)
RuntimeError: invalid argument 5: k not in range for dimension at /tmp/pip-req-build 4baxydiv/aten/src/THC/generic/THCTensorTopK.cu:23
How to fix it?

I try to modify subgraph_size to less than 5, for example ,used 4.


Issue Saving Some .mp3 Files

Package Version
v1.2.0
Are the dependencies being used satisfy the minimum specification?
Yes
Summary

[!NOTE]
Report from Nothing Community Forum: https://nothing.community/d/12384-music-open-source-offline-music-player/13

Someone seems to be having issues with saving some of their .mp3 files on the Music app. They have 80 songs, only 4 were detected.

I'm wondering if the problem is that they have a different metadata container like APE?

Another problem is that he says it took about 10 minutes to get through that process, which seems wrong.

This might point to a different potential issue which is maybe their tracks uses unsynchronization, which isn't tested thoroughly and it might be performance hitting.

Minimal reproducible example
n/a

Viewed the tags on the file and saw it wasn't tagged properly — it only had the title field properly.
The 10 minutes to attempt to save 80 tracks seems to be a different problem and needs investigating. This is potentially due to maybe the code going through the whole file in attempt to find these fields that don't exist?

A different report with an issue of a file not being indexed has the required fields populated (title & artist) in the ID3 tag.
This is probably a bug in the code somewhere.

[!IMPORTANT]
Both issues so far are tagged with ID3v2.4.

Closing issue as we hit the expected outcomes for the files provided:

First file was missing the artist tag, so it wouldn't be saved in the music app. However, we do get a value for the name field in the metadata as it was provided.
Second file was found by the music app, so it's unrelated to this repository.

The long save duration may be an issue for this repository, however, this is the only report and for the purpose of this issue, this shouldn't prevent this issue from being closed. If the long read times is encountered by someone else, a new issue should be created.


Merge commit '98e8b36fbc41fd4abca9bfd41c0a72cc53c06363' into low_level_rendering

This merges everything up until today's reformat into low_level_rendering.

This is definitely a best effort from someone just learning the codebase.
Feel free to discard if we don't trust it.
Main issues I ran into:

It looks like different variations of stroke invalidation found their ways into both branches. I kept both.

artboard.cpp has two "instance()" methods now. This probably is not correct.

Everything else I'm more or less confident in.

I remember needing to implement instancing in low_level_rendering before the official implementation landed in master.
I think that we actually do want both, one is used to make a deep clone of the same type of object and the other uses an already generated object (which must inherit from artboard) as the clone target. This is useful if you want to clone to a different concrete type of Artboard.
Looks like the merge tried to keep the old code which was all in instance() before I moved the bulk of it into instance(Artboard*).
I see some of the tests are failing. It does look like "invalidateStrokeEffects" might be missing.
RenderPaint::invalidateStroke was for invalidating any cached stroke buffers (should be recomputed on next draw). That looks like it made it through fine.
ShapePaintContainer::invalidateStrokeEffects was added to master and doesn't directly affect the low level renderer. It's for internally invalidating all cached stroke effects (currently only trim path). Rive uses it internally when a dependent property changes which will affect the trim path. That internally calls Stroke::invalidateEffects.
It also looks like maybe the formatter didn't run after the merge. @mikerreed what's a good way for running clang-format on the whole codebase?


Multiple elements on one line, Headers & Line Breaks

Hi There,
First, great product.... In my version, I am able to save the elements to MySQL and reload the form from there - very nicely done.
Just need some niceties to make it perfect for us.  Would appreciate direction and/or hints on how to do it.
1- put multiple elements in one line - for example:
Name:      [first name]  [last name]
or
Address:  [Address Line 1]
[Address Line 2]
[City] [State] [Zip]
2- add text header boxes - somewhere to put instructions and other text without any field.
3- add line beaks to group elements vertically.
Thank you in advance for your attention on this.
Q

@qfard @siddarth-rajavelu @tariq-mahmood-nxb @itsazzad
can anyone sent this to me on<EMAIL_ADDRESS>Thanks.

@qfard @siddarth-rajavelu @tariq-mahmood-nxb @itsazzad
can any of you guys send me thechanges related to this issue? thanks
<EMAIL_ADDRESS>


Create HOC for get report data or navigate to home

Details

The issue occurred when the report from Onyx return undefined on ReportDetailsPage, ReportParticipantsPageandReportSettingsPage.
Fixed Issues

$ https://github.com/Expensify/App/issues/11982
$ https://github.com/Expensify/App/issues/11982#issuecomment-1284159762
Tests

Navigate to a room, open the details page or participants page, or settings page
Copy the URL
Open another account that doesn't have access to that room
Go to the URL from step 2
Verified that the page (details, participants, or settings page) modal dismisses and shows the current account chat

[x] Verify that no errors appear in the JS console

QA Steps

Navigate to a room, open the details page or participants page, or settings page
Copy the URL
Open another account that doesn't have access to that room
Go to the URL from step 2
Verified that the page (details, participants, or settings page) modal dismisses and shows the current account chat

[x] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

https://user-images.githubusercontent.com/25520267/197564119-06e50beb-e970-4cf4-8405-50daebcf768b.mov
Mobile Web - Chrome

https://user-images.githubusercontent.com/25520267/197564126-c67fcdbe-c3e4-49b5-ba11-fb01fcc303ae.mov
Mobile Web - Safari

https://user-images.githubusercontent.com/25520267/197564143-423bd4e5-82f1-427b-9f58-06f6547b3543.mov
Desktop

https://user-images.githubusercontent.com/25520267/197564165-e92750f7-1761-40b8-a4f7-442722faccad.mov
iOS

https://user-images.githubusercontent.com/25520267/197564185-ca200547-b86e-4513-806d-6854a6928fe5.mov
Android

https://user-images.githubusercontent.com/25520267/197564200-852b9475-609f-4d19-ac04-c473afa06abc.mov

@mollfpr I am getting a console error when the I hit the URL. Can you please check this?

--
Please note I'll be available for a few hours for this week, and expect delayed responses.

@mananjadhav I just update the HOC component to use the class component and move the navigation redirect to componentDidMount. I also add a fix after redirection if the report.participants not yet loaded and throwing error page.

Thanks for the changes @mollfpr I am going to review and test this by tomorrow.

Code looks good to me! @mananjadhav can you try fixing your PR review checklist then we'll see if the final test passes? 👍

@Beamanator Thanks for pointing that out. I've updated the checklist and all checks are passing now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Beamanator in version: 1.2.22-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @Julesssss in version: 1.2.22-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[now-next] Add support for experimental basePath

This adds support for https://github.com/zeit/next.js/pull/9872. ~Note: the added tests won't pass until the below PR is shipped on canary~
relies on: https://github.com/zeit/next.js/pull/9875

Codecov Report

Merging #3478 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3478      +/-   ##
==========================================
- Coverage   14.59%   14.58%   -0.01%
==========================================
  Files         267      267
  Lines       10779    10791      +12
  Branches     1483     1484       +1
==========================================
+ Hits         1573     1574       +1
- Misses       9039     9050      +11
  Partials      167      167

Impacted Files
Coverage Δ

src/util/metrics.ts
61.53% <0%> (-6.65%)
:arrow_down:

src/util/prefer-v2-deployment.ts
55.1% <0%> (-4.9%)
:arrow_down:

src/util/projects/get-project-by-id-or-name.ts
19.04% <0%> (-4.49%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4237d3...1e267ef. Read the comment docs.


Bad response Exception

I download and run this library but when I type command 'url' or 'profiles' get below exception
`SEVERE: SAAJ0008: Bad Response; Bad Request
Unexpected response. Response should be from class class org.onvif.ver10.media.wsdl.GetProfilesResponse, but response is: null
com.sun.xml.internal.messaging.saaj.SOAPExceptionImpl: com.sun.xml.internal.messaging.saaj.SOAPExceptionImpl: Bad response: (400Bad Request
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.call(Unknown Source)
at de.onvif.soap.SOAP.createSOAPRequest(SOAP.java:89)
at de.onvif.soap.SOAP.createSOAPMediaRequest(SOAP.java:49)
at de.onvif.soap.devices.InitialDevices.getProfiles(InitialDevices.java:159)
at de.onvif.Main.main(Main.java:69)
Caused by: com.sun.xml.internal.messaging.saaj.SOAPExceptionImpl: Bad response: (400Bad Request
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.post(Unknown Source)
... 5 more
CAUSE:
com.sun.xml.internal.messaging.saaj.SOAPExceptionImpl: Bad response: (400Bad Request
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.post(Unknown Source)
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.call(Unknown Source)
at de.onvif.soap.SOAP.createSOAPRequest(SOAP.java:89)
at de.onvif.soap.SOAP.createSOAPMediaRequest(SOAP.java:49)
at de.onvif.soap.devices.InitialDevices.getProfiles(InitialDevices.java:159)
at de.onvif.Main.main(Main.java:69)
CAUSE:
com.sun.xml.internal.messaging.saaj.SOAPExceptionImpl: Bad response: (400Bad Request
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.post(Unknown Source)
at com.sun.xml.internal.messaging.saaj.client.p2p.HttpSOAPConnection.call(Unknown Source)
at de.onvif.soap.SOAP.createSOAPRequest(SOAP.java:89)
at de.onvif.soap.SOAP.createSOAPMediaRequest(SOAP.java:49)
at de.onvif.soap.devices.InitialDevices.getProfiles(InitialDevices.java:159)
at de.onvif.Main.main(Main.java:69)
Exception in thread "main" java.lang.NullPointerException
at de.onvif.Main.main(Main.java:70)`
can help me why this exception occures

Your network video transmitter doesn't seem to support the simple requests for url or profiles because it delievers no answers for the SOAP requests.

Thanks for the answer
my problem was incorrect password now i connect to camera and get url and profiles without exception


Quick SSH/Telnet Connection button

Please add a quick connect button.
Please add a quick connect button so it will be like putty, that we can just put the IP, connection type (Telnet, SSH, Serial, etc) and  click connect, without the need to edit the settings.json file.
Sometimes we don't need to save a session, just a quick connect to a device and exit, it will be a great time saver if it has that feature, that the main difference with simple programs as Putty and more complete as SecureCRT.

Thank you for the request!
Windows Terminal does not want to be a generic SSH client, so we are not likely to add a Quick Connect feature. It's a little too specific of a use case for a local Terminal, but it's something we can discuss for the future.
For now, it's easy enough to run ssh <IP_ADDRESS> from another WT profile. :smile:


Proper way to promisify npm mysql module

I was going through the documentation this morning, and stumbled across the following example for promisifying the npm mysql module:
var Pool = require("mysql/lib/Pool");
var Connection = require("mysql/lib/Connection");
Promise.promisifyAll([Pool, Connection]);

This seems to work, however, I'm curious how it is different than this:
var mysql = require('mysql');
Promise.promisifyAll(mysql);
Promise.promisifyAll(require("mysql/lib/Connection"));
Promise.promisifyAll(require("mysql/lib/Pool"));

which doesn't work. I ask because I've always been used to promisifying the mysql module by directly promisifying the prototypes, like so:
var mysql = require('mysql');
Promise.promisifyAll(mysql);
Promise.promisifyAll(require("mysql/lib/Connection").prototype);
Promise.promisifyAll(require("mysql/lib/Pool").prototype);

and so I'm just curious, what is the "proper" way to promisify this module?
I'm running v3.3.4 of the bluebird module and v4.1.1 of Node.js. Thanks!

There is also at least one instance in the documentation in http://bluebirdjs.com/docs/api/promisification.html where the first of those three promisifications is omitted, and now I'm not sure if it was intentional:
var mysql = require('mysql');
Promise.promisifyAll(require("mysql/lib/Connection").prototype);
Promise.promisifyAll(require("mysql/lib/Pool").prototype);

The array is basically a module of classes, that's why it works. If you have separate classes like Pool, Connection you need to promisify their prototypes

I ran into the same thing, assuming that require('bluebird').promisifyAll(MyClass) would DTRT and promisify each prototype method.
Would you accept a PR that changes promisifyAll so it detects that a function is passed and dives into the prototype in that case? Or would it introduce ambiguity?


Transformers based GPTQ Models missing bits weight

System Info
latest docker
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
docker run --pull always --gpus all -d --shm-size 1g -p 8080:80 -v ./data:/data ghcr.io/huggingface/text-generation-inference:latest --max-total-tokens 4096 --max-batch-prefill-tokens 4096 --max-input-length 3000 --model-id flozi00/codellama-34b-german-assistant-v1-4bit-autogptq --quantize=gptq --cuda-memory-fraction 0.5

Traceback (most recent call last):

  File "/opt/conda/bin/text-generation-server", line 8, in <module>
    sys.exit(app())

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/cli.py", line 81, in serve
    server.serve(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 195, in serve
    asyncio.run(

  File "/opt/conda/lib/python3.9/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)

  File "/opt/conda/lib/python3.9/asyncio/base_events.py", line 647, in run_until_complete
    return future.result()

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/server.py", line 147, in serve_inner
    model = get_model(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/__init__.py", line 187, in get_model
    return FlashLlama(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/flash_llama.py", line 68, in __init__
    model = FlashLlamaForCausalLM(config, weights)

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 461, in __init__
    self.model = FlashLlamaModel(config, weights)

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 399, in __init__
    [

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 400, in <listcomp>
    FlashLlamaLayer(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 336, in __init__
    self.self_attn = FlashLlamaAttention(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 209, in __init__
    self.query_key_value = _load_gqa(config, prefix, weights)

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/models/custom_modeling/flash_llama_modeling.py", line 156, in _load_gqa
    weight = weights.get_multi_weights_col(

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/utils/weights.py", line 134, in get_multi_weights_col
    bits, groupsize = self._get_gptq_params()

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/utils/weights.py", line 220, in _get_gptq_params
    raise e

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/utils/weights.py", line 213, in _get_gptq_params
    bits = self.get_tensor("gptq_bits").item()

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/utils/weights.py", line 66, in get_tensor
    filename, tensor_name = self.get_filename(tensor_name)

  File "/opt/conda/lib/python3.9/site-packages/text_generation_server/utils/weights.py", line 53, in get_filename
    raise RuntimeError(f"weight {tensor_name} does not exist")

RuntimeError: weight gptq_bits does not exist

Expected behavior
The gptq bits value is not recognized from config.json what is needed when using gptq models from transformers instead of Autogptq which has its own config file for that

I can confirm that I am having the same issue trying to use models converted using transformers/accelerate.  Gonna try different methods of conversion.

PR to solve is linked here


Object ID properties return 0 instead of null

if a user or event object has ID properties which are of type [int], and the property is null, 0 is returned. This should return null. One solution might be to simply return a string.

fixed in commit 213bfec03fd30a6ece88bb809f50d043ec653308


#227 BkParallelTest is not implemented

As suggested in pull request #246, implemented a test case which launches several requests from separate threads and ensures that requests are being executed in parallel

@komaz Many thanks, I will find someone to review it before we merge

@carlosmiranda review this one, please

@komaz Looks good! Some minor comments above.

@carlosmiranda Thanks! I just pushed suggested changes

@rultor Looks good to merge

@rultor Looks good to merge

@carlosmiranda Thanks for your request. @yegor256 Please confirm this.

@rultor try to merge

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 14min)

@elenavolokhova please, review this task for compliance with our quality rules

@rultor deploy

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor deploy

@davvd Done! FYI, the full log is here (took me 13min)

@davvd Quality is good here.

@davvd Quality is good here.

@elenavolokhova thank you :)

@carlosmiranda 10 mins added to @yegor256 account (our architect), payment ID is 000-971ec313, since quality is good here

@carlosmiranda 10 mins was added to the account of @elenavolokhova (for QA review), in transaction 57310607. Much obliged! I have added 17 mins to your account in payment "57310646", 44 hours and 51 mins spent. review comments (c=2) added as a bonus. +17 to your rating, your total score is +4300


Pin the rancher-webhook chart to an exact version

Issue: https://github.com/rancher/rancher/issues/40159
Problem
Rancher specifies the minimum version of the webhook in its configuration. When there is a newer version of the chart, Rancher will try to install it, which we don't always want, since there might be incompatibilities of Rancher and a given version of the webhook.
Solution
Install only the webhook specified in configuration. Do not use the notion of a "minimum" version for the webhook chart. Instead, use exact version that doesn't change automatically for a given version of Rancher - it's to remain fixed.
Testing

Engineering Testing
Manual Testing

Run Rancher with the webhook chart version specified with CATTLE_RANCHER_WEBHOOK_VERSION. Ensure that Rancher installs that version only, whether there are any newer versions or not.
In the UI, upgrade or downgrade to another version. Ensure that after some time (depending on the configurable chart refresh interval), Rancher switches back to the original version.
Rerun Rancher with a different version specified. Ensure Rancher installs that version of the webhook chart.

Automated Testing

QA Testing Considerations

Regressions Considerations
Ensure no changes occur for other system charts, like fleet. For them, the minimum version should behave as before, that is, Rancher may upgrade to a newer version if one is available.

Spoke with @MbolotSuse and @KevinJoiner. We decided to fix one regression (the new code no longer uses a merged version of old and new values) and aim to merge this PR. Later, we will have another issue whose goal is to have a more substantial refactoring.


the --log option doesn't actually save the output to a log file

Thanks - this was leftover from some logging scaffolding that was there previously but that was pruned to minimize dependencies. Will be removing it as a PR.

Resolved with https://github.com/google/gemma.cpp/pull/66. Thanks for reporting!


simple_ota_example: Firmware upgrade failed (IDFGH-4520)

I (4708) simple_ota_example: Starting OTA example
I (7228) esp_https_ota: Starting OTA...
I (7228) esp_https_ota: Writing to partition subtype 16 at offset 0x110000
D (9338) HTTP_CLIENT: esp_transport_read returned:-1 and errno:128
I (9338) esp_https_ota: Connection closed
I (9338) esp_image: segment 0: paddr=0x00110020 vaddr=0x3f400020 size=0x05b2c ( 23340) map
E (9358) esp_image: invalid segment length 0xffffffff
E (9358) simple_ota_example: Firmware upgrade failed

@kaibin1111
Information you have provided is not sufficient, please follow issue template.
Please see if suggestion from below comment help you:
https://github.com/espressif/esp-idf/issues/5240#issuecomment-639292839

Thank you for your reply. The problem has been solved.

@kaibin1111 Thanks for update, I will close the issue.


NIFI-7493: When inferring schema for XML data, if we find a text elem…

…ent that also has attributes, infer it as a Record type, in order to match how the data will be read when using the XML Reader
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Merged to main, thanks @markap14 !


how to talk remotely with any npc?

id like to know what key i have to press or what do i have to do to talk remotely with the NPCs

When a new area is loaded, you can see a list of NPCs in the console window the game will spawn. Ingame, you can send the chatmessage .talk {guid} where {guid} is the GUID of the NPC.

Everything you can do is in the readme. If it's not in there, it is not implemented.

im asking because u said that i the readme: Any other functionality you can think of.
block battles is possible?
like when u run in the grass

do u think that would be possible to edit the amount of the money  we will get for a specific quest ?
<- Quest {"ID":"ViridianCity1_Main","Name":"Viridian City","Description":"Challenge Old man San Tsu","Type":"Main","Step":4.0,"ProgressType":"None","ProgressID":0,"Progress":0,"Required":0,"Target":"00000000-0000-0000-0000-000000000000","TargetCompleted":"00000000-0000-0000-0000-000000000000","Completed":true,"AutoComplete":false,"Reward":{"Money":0,"Gold":0,"Items":null,"Pokemon":0,"PokemonLevel":0,"PokemonShiny":false,"Badge":0,"Exp":0},"CanCancel":false,"CanShare":false,"TargetArea":null,"TargetCompletedArea":null,"SourceNPC":"Old Man San Tsu","SourceArea":"Viridian City","_Name":"Quest"}
**<- Money {"Game":970,"Gold":160,"_Name":"Money"}**
<- Quest {"ID":"ViridianForest_Main","Name":"Viridian Forest","Description":"Travel through Viridian

No, that's all decided by the server. Your client simply tells the server what actions it does, while the server stores your actual state (your gold, position, completed quests, ...). If you would change the packets containing the amount of gold you have, you would only see a change client-side but the server would still have the correct amount.
Something you could do instead is finding errors on their part. For example, trying to submit the same quest twice, selling a negative amount of an item, selling an item you don't have, etc. These exploits could end up giving you gold. I have already done a little bit of research into this but didn't find anything worthwhile, but you're free to try for yourself.


Allow handling of 401 and 403 errors differently by implementing user

An issue I've encountered is 401 and 403 both being returned to the end user in an error object as 403.
(Roughly) 401 means unauthenticated / authentication expired, 403 means no permission to access - fairly different things

@tenxcloud Hi there! Any thoughts on this?

+1 A subtle difference between knowing if the token has expired or the user isn't authorized

@tenxcloud ping

Thanks @huangqg! Any chance of an NPM publish?

@cianclarke   yes, NPM was published. thanks for the changes.


Add FairEmail

{
          "name": "FairEmail - Fully featured, open source, privacy friendly email app for Android",
          "url": "https://github.com/M66B/FairEmail/releases/latest",
          "moreinfo": "https://github.com/M66B/FairEmail"
}

Added. Thanks!
https://github.com/wacko1805/Fossapps-creator/commit/d94c3270119547679c7ad3cdfe87069925693b32


where is your string to floating point algo?

I cannot find out code

From README:

I also developed an algorithm for the reverse procedure, that is, to convert decimal floating-point numbers into IEEE-754 binary floating-point numbers, using a similar idea. With the assumption of limited precision (at most 9 digits for float's, at most 17 digits for double's), this reverse procedure is actually far simpler than the binary-to-decimal conversion, because we do not need to search for the shortest representation. I ran a joint test of this algorithm and Grisu-Exact, and confirmed that these algorithms successfully round-trip for every single float. (Since both of the algorithms are very fast, the whole test takes only less than 2 minutes😉) Therefore, I am very confident about the correctness of both of the algorithms. I will make a separate repository for the reverse algorithm in a near future.

So in short, I didn't publish it yet :)
But you can give a try if you want: grisu_reverse.txt
This version of implementation presumes the existence of grisu_exact.h in your include directory. The function to convert a decimal to binary is on the line 1175. It does not include string-to-decimal conversion routine.

(EDIT: the cache table in the file is mostly the same as that in grisu_exact.h, but it is not perfectly identical.)

Can you make them identical so we can merge them? Or it causes more binary bloat.

Can you make them identical so we can merge them? Or it causes more binary bloat.

Though (I hope) I will eventually do that in a different repo, I will not touch the table in this repository. To me, Grisu-Exact is a (sort-of) completed project, and I don't want to degrade its current quality in order to add a completely different feature. Grisu-Exact will probably remain as it is, except for possible bug fixes and performance improvements.
But you can do that yourself.
The table in grisu_exact.h spans the range k=-30 to k=46 for float, and k=-290 to k=325 for double.
The table in grisu_reverse.h spans the range k=-53 to k=38 for float, and k=-340 to k=308 for double.
Hence, to merge two tables together, you should add first 23 entries from grisu_reverse.h into the table in grisu_exact.h for float, and first 50 entries from grisu_reverse.h into the table in grisu_exact.h for double. You also need to adjust the routine get_cache as well. To be more precise, the range of k is defined in the struct common_info; see min_k and max_k. (Their values are not hard-coded.)
You need to note that, as a result, the table size will grow (77+23 = 100 for float, 616+50=666 for double), and the resulting size is not really different from Ryu's. (I think this is the primary reason why Ryu have had a bigger table in the first place, I mean, to provide stof feature along with the original ftos?)

Here I've found a SIMD floating-point parser. Do you think it is useful?
https://gist.github.com/Eichenherz/657b1d794325310f8eafa5af6375f673

Sorry I was busy working on dragonbox. I've checked the link and I expect it to be very fast, though I wonder why you call it SIMD. But it seems working only for very special types of inputs, isn't it?


how to send email to multi users

I want to send mail to multi receivers, How should I do ?
For example, listing all of their email addresses in the receiver_email and delimited by ";" ?
If it's possible, it's better to add an example in readme or wiki.

The software doesn't currently support this feature.  But sendmail can do it does support multiple recipients.  I'll look into updating to fully support multiple email addresses although I don't have time today.
In the meantime you should be able to change line 216  of ipwatch.py from receivers = [receiver_email] to something like receivers =<EMAIL_ADDRESS><EMAIL_ADDRESS>I'll leave this open until I can update the software to fully support multiple recipients from the config file.

I've updated the software to support emailing multiple recipients.  Simply amend the "receiver" and "receiver_email" lines with additional, comma delimited, email addresses (see updated README.md for an example).
See commit https://github.com/begleysm/ipwatch/commit/65cda6df73ef3ab3da647b06204cc4e2e2bfd262


Being able to see model's responses when using verbose mode

Feature request
Currently, when the verbose attribute is set to True in the constructor of an LLMChain object, only the input passed to the LLM is shown. It would be desirable to also see the raw output of the LLM before it is parsed.
Motivation
Seeing both inputs and outputs of the LLM would help debug the chain. Exceptions often occur when an output parser is used and the parser throws an exception (because the LLM's output was not in the expected format). In that case one cannot see what the LLM's output was.
Your contribution
I had a look at the code of LLMChain and it seems that a print (or a callback) could be added in the _call method, between the call to generate and the call to create_outputs:
    def _call(
        self,
        inputs: Dict[str, Any],
        run_manager: Optional[CallbackManagerForChainRun] = None,
    ) -> Dict[str, str]:
        response = self.generate([inputs], run_manager=run_manager)
        # Add a print/callback here
        return self.create_outputs(response)[0]

@kevin-guimard-ext can you share code that raises such an exception with a parser so we can recreate it?

Well, just add a raise statement in the parse method of the parser... But this was not the point of my request: the problem is that in verbose mode, only the inputs are shown, and not the outputs. I introduced the example of a parser throwing an exception to justify a case when this feature could be useful. There could be others.

If you include import langchain; langchain.debug = True, you can get more granular information than verbose mode. When I use it with a MultiPromptChain, it appears to show the pre-parsed output from the router before going into RouterOutputParser; your use case may vary


Fix #1884: support np.lib.stride_tricks.as_strided()

The strides argument is mandatory, which corresponds to all use cases I've found in the wild.

[Current coverage][cc-pull] is 87.51%

Merging [#1917][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master      #1917   diff @@
==========================================
  Files           293        293
  Lines         52497      52562    +65
  Methods           0          0
  Messages          0          0
  Branches       5431       5418    -13
==========================================
+ Hits          45926      45999    +73
- Misses         5646       5654     +8
+ Partials        925        909    -16

3 files (not in diff) in numba/typing were modified. more

Misses -1
Partials -1
Hits +2

3 files (not in diff) in numba/tests were modified. more

Misses -1
Hits +1

2 files (not in diff) in numba/npyufunc were modified. more
7 files (not in diff) in numba were modified. more

Partials -16
Hits +16

File ...umba/targets/base.py was modified. more

Misses 0
Partials -3
Hits +3

Powered by Codecov. Last updated by [f472ab0...3675b82][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/f472ab0550376faf2f970cf09ddccfbb5d65b48e...3675b820a9a44e26ae612adb2bfa6b2a6d32da99
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1917?src=pr


[SR-12758] Clang targets imported by other Clang targets should only use modulemaps for tools version 5.2 or later

The fix for SR-10707 unconditionally added a -fmodule-map-file argument to the build of any Clang target that imports another Clang target.  This broke packages whose headers are incompatible with module maps, even if those packages specify an older Swift Tools version.  In order to apply the new semantics introduced by the fix for SR-10707, while also letting older targets build unmodified, this PR makes the addition of the -fmodule-map-file flag be conditional on whether the package that defines the target specifies a tools version of 5.2 or later.
There is a risk that this will break some other packages that specify a tools version older than 5.2 but that rely on the new behavior introduced in 5.2.  That has to be balanced against unbreaking the older packages that were broken by the change in 5.2.  There doesn't seem to be a good way to unbreak older packages, such as the ones described in [SR-12758 (https://bugs.swift.org/browse/SR-12758)] and [SR-12197 (https://bugs.swift.org/browse/SR-12197)] without risking also breaking packages that rely on the new behavior but specify an older tools version (note that such packages would also have been broken when building using an older version of the toolchain).
Conceptually, it seems correct that the change in the behavior introduced in 5.2 should be conditional on a Swift tools version of 5.2 or later.  In general, changing to the semantics of how packages get built should go by the tools version when possible, so that existing packages don't break.
This PR adds a PackageGraph method to look up the ResolvedPackage that defines a particular ResolvedTarget.  This is done in favor of adding the tools version to each ResolvedTarget, as a separate PR had proposed to do.
rdar://66294379

@swift-ci please smoke test

Looking into the test failure on Linux ("unexpected failure matching ':0: warning: missing submodule 'Dispatch'").  Not yet clear whether it's related to this change.

@swift-ci please smoke test linux

Withdrawing this after discussion.  This would make SwiftPM diverge from Xcode's behavior, and risks breaking newer packages.


[Feature Request] Add ability to "prefer" zen workspace gradient over super gradient

The related Mod/Theme:
SuperGradient
Your Enhancement Suggestion/Feature Request
This would be a toggle in the options: Prefer workspace gradient over SuperGradient
Essentially, SuperGradient only shows when a workspace does not have a defined (zen) gradient. When it does, give preference to the user defined zen gradient.
Also, it doesn't show up in the sidebar when expand on hover is enabled.

Sry for the late answer but SuperGradient is no longer on the mods store

What?

Yeah, but Zen's native gradients are good enough, you're probably right regarding the presets, but overall having  a mod that's too similar to the native implementation, just less intuitive wouldn't make much sense. When creating the mod I hoped that gradients would get a native implementation some day which they did, which is why it's of the store. Sry

Well, no need for a sorry. Thank you for making this in the first place!


org.elasticsearch.hadoop.EsHadoopIllegalArgumentException: Field [_col1] needs to be a primitive; found [array<map<string,string>>]

I defined the external table as:
CREATE EXTERNAL TABLE IF NOT EXISTS ${staging_table}(
customer_id STRING,
store_purchase array<map<string,string>>)
ROW FORMAT SERDE 'org.elasticsearch.hadoop.hive.EsSerDe'
STORED BY 'org.elasticsearch.hadoop.hive.EsStorageHandler'
TBLPROPERTIES (
'es.nodes'='localhost:9200',
'es.resource'='user_activity/store',
'es.mapping.id'='customer_id',
'es.input.json'='false',
'es.write.operation'='upsert',
'es.update.script'='ctx._source.store_purchase += purchase',
'es.update.script.params'='purchase:store_purchase'
) ;"
but it throws EsHadoopIllegalArgumentException: Field [_col1] needs to be a primitive; found [array<map<string,string>>]. Is array<map<string,string>> supported yet? If not, how can I get around this issue?

The issue here that is tripping up the table creation is that the array<map<string,string>> column is being used as the script parameter. For the time being, we only support using primitives in the script params for Hive.

HI jbaiera, is there a recommended way to circumvent this issue? Matt Henricks

@matthenricks sadly there is no work around right now. The logic that performs serializing records from different integrations into JSON is different between rendering script parameters and rendering  the final JSON document. We'll update here as new updates become available.


[BUG] Client doesn't handle basic auth passwords with special characters in url correctly

What is the bug?
It seems like OpenSearch::Client doesn't handle hosts/urls that contain passwords in the url with special characters correctly. When making requests with one of these urls, I get an "Unauthorized" error. I believe the problem is that __parse_host doesn't decode the special characters.
How can one reproduce the bug?
Example code snippet:
client = OpenSearch::Client.new(
    url:  "https://user:pass%7D%7Dword@host.docker.internal:15000",
    transport_options: { ssl: { verify: false } }
)
client.search(index: '_all', body: {})

I can however get around this problem by passing a hash in the url parameter that does the decoding myself:
url = URI("https://user:pass%7D%7Dword@host.docker.internal:15000")
client = OpenSearch::Client.new(
  url: {
    scheme: url.scheme,
    user: CGI.unescape(url.user),
    password: CGI.unescape(url.password),
    host: url.host,
    path: url.path,
    port: url.port
  },
  transport_options: { ssl: { verify: false } }
)
client.search(index: '_all', body: {})

What is the expected behavior?
I expect that passwords embedded in the url with standard url encoding should not cause authentication errors
What is your host/environment?

OS: macOS 12.3.1
Version: 1.0.0

Let me take a look on this. Will get back.

The password pass%7D%7Dword is used as is (without decoding). @NoahCarnahan you mean to say the decoding should be happening here ?

Correct, I believe that the library should decode the password before trying to use it for authentication.
I realize I left a detail out of my initial bug report:
The password for this user is pass}}word. } is a special character, therefore it must be encoded to be included in the basic auth section of the url. As per url encoding rules, } is replaced by %7D, which gives us a url of https://user:pass%7D%7Dword@host.docker.internal:15000 in this example.
If I were to try specifying the password without URL encoding like https://user:pass}}word@host.docker.internal:15000, then an exception would be thrown about an improperly formatted url.
Additionally, I can use curl with the https://user:pass%7D%7Dword@host.docker.internal:15000 version of the url to successfully access my AWS OpenSearch cluster.

Ruby default parser doesn't seem to want to decode the password.
2.6.5 :009 > parsed = URI.parse('https://user:pass%7D%7Dword@host.docker.internal:15000')
 => #<URI::HTTPS https://user:pass%7D%7Dword@host.docker.internal:15000>
2.6.5 :010 > parsed.password
 => "pass%7D%7Dword"

The RFC says "Within the user and password field, any ":", "@", or "/" must be encoded."
> URI.parse('https://user:pass%40word@host.docker.internal:15000').password
 => "pass%40word"

So this doesn't decode the password either.
It seems like in most libraries unencoding is left to the caller, e.g. in addressable:
require 'addressable'
Addressable::URI.unencode('https://user:pass%40word@host.docker.internal:15000/%40%40')
 => "https://user:pass@word@host.docker.internal:15000/@@"

Calling decode first would be a breaking change. I vote to leave things as is.

Agree with @dblock , this will be breaking change. We should leave the decoding to caller.

@NoahCarnahan Do you feel strongly otherwise? Otherwise let's close this?

I agree that the default ruby parser doesn’t do any decoding, but I think it’s the responsibility of opensearch-ruby as a user of URI to do the decoding. As a point of comparison, the opensearch-py library handles URLs with encoded characters just fine (encoded characters in the password part of the url don’t prevent the library from authenticating with the server).
I recognize that passing username and password in the url isn’t ideal, but I do wonder if this library also can’t handle escaped characters in the path part of the url, which I imagine could come up with certain index names (I haven’t tested this).
Ultimately, I’m not a contributor to this project, so I’m not going to push too hard for the change, but I do feel that the current behavior of the library doesn’t handle all valid RFC 1738 urls correctly, which seems like a bug to me.

@NoahCarnahan If you have some spare time, add a few RSpec tests and document this behavior? This way we will know what we are changing, if we are and it will help the next person.

It looks like the password part is as per the RFC and is also a deprecated practice.  I propose we close this issue and if anyone finds an issue with the url parsing, we can create a new issue.

I think we should implement some specs and document this behavior before we close it.


Cannot truncate because of foreign key constraint

I have a test that passes, but during the cleanup process throws this error:
Exception: SQLSTATE[42000]: Syntax error or access violation: 1701 Cannot truncate a table referenced in a foreign key constraint (`fg4_test`.`addresses`, CONSTRAINT `addresses_ibfk_4` FOREIGN KEY (`warehouse_office_id`) REFERENCES `fg4_test`.`warehouses` (`id`))
In [/Library/WebServer/Documents/ampfg4/vendor/robmorgan/phinx/src/Phinx/Db/Adapter/PdoAdapter.php, line 188]

There is indeed a foreign key referencing warehouses on the addresses table. Is there something else I should be doing in my test or elsewhere to inform the system of the relationship?
This is my test:
    public function testExample()
    {
        WarehouseFactory::make(1)->persist();
        $warehouse = TableRegistry::getTableLocator()->get('Warehouses')
            ->get('1');
        $this->assertInstanceOf(Warehouse::class, $warehouse);

    }

This is my factory code:
    protected function setDefaultTemplate(): void
    {
        $this->setDefaultData(function(Generator $faker) {
            return [
                'name' => $faker->company(),
                'token' => $faker->uuid(),
                'active' => 1,
            ];
        });
    }

This is the sequence of sql commands that are running:
'START TRANSACTION
''COMMIT
''INSERT INTO `cakephp_fixture_factories_phinxlog` (`version`, `migration_name`, `start_time`, `end_time`, `breakpoint`) VALUES (\'20200512051455\', \'TruncateDirtyTables\', \'2020-06-01 19:04:47\', \'2020-06-01 19:04:48\', 0);
''START TRANSACTION
''COMMIT
''DELETE FROM `cakephp_fixture_factories_phinxlog` WHERE `version` = \'20200512051455\'
'
'START TRANSACTION
''TRUNCATE TABLE `warehouses`

I'm on v0.2.13
I've tried this by baking both
bin/cake bake fixture_factory warehouses -f -m
and
bin/cake bake fixture_factory warehouses -f
I also baked the linked addresses table using the -m option
and I've both included and excluded the test/boostrap Migrator::migrate()

In case some detail of the schema is relevant:
CREATE TABLE `warehouses` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `name` char(100) NOT NULL,
  `token` char(255) NOT NULL,
  `active` tinyint(4) NOT NULL,
  `created` datetime NOT NULL,
  `modified` datetime NOT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `name` (`name`(20))
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

CREATE TABLE `addresses` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `name` varchar(128) DEFAULT '',
  `company` varchar(128) DEFAULT NULL,
  `address` varchar(128) DEFAULT '',
  `address2` varchar(128) DEFAULT '',
  `address3` varchar(128) DEFAULT '',
  `city` varchar(128) DEFAULT '',
  `state` varchar(8) DEFAULT NULL,
  `zip` varchar(20) DEFAULT '',
  `country` varchar(20) DEFAULT '',
  `residence` tinyint(1) DEFAULT '0' COMMENT '1=home delivery 0=business',
  `shipping_account_id` int(11) DEFAULT NULL COMMENT 'provides a billing address to a shipping account',
  `warehouse_office_id` int(11) DEFAULT NULL COMMENT 'links the ''contract-relevant'' address (billing etc) for a warehouse',
  `facility_id` int(11) DEFAULT NULL,
  `tenant_office_id` int(11) DEFAULT NULL COMMENT 'links the ''contract-relevant'' address (billing etc) for a tenant',
  `tenant_id` int(11) DEFAULT NULL COMMENT 'creates a shipping addressbook attached to Tenants, visible to their workers',
  `person_id` int(11) DEFAULT NULL COMMENT 'creates a shipping addressbook for registered users',
  `created` datetime DEFAULT NULL,
  `modified` datetime NOT NULL,
  PRIMARY KEY (`id`),
  KEY `person_id` (`person_id`),
  KEY `tenant_id` (`tenant_id`),
  KEY `tenant_office_id` (`tenant_office_id`),
  KEY `warehouse_office_id` (`warehouse_office_id`),
  KEY `shipping_account_id` (`shipping_account_id`),
  KEY `facility_id` (`facility_id`),
  CONSTRAINT `addresses_ibfk_1` FOREIGN KEY (`person_id`) REFERENCES `people` (`id`) ON DELETE CASCADE,
  CONSTRAINT `addresses_ibfk_2` FOREIGN KEY (`tenant_id`) REFERENCES `tenants` (`id`) ON DELETE CASCADE,
  CONSTRAINT `addresses_ibfk_3` FOREIGN KEY (`tenant_office_id`) REFERENCES `tenants` (`id`) ON DELETE CASCADE,
  CONSTRAINT `addresses_ibfk_4` FOREIGN KEY (`warehouse_office_id`) REFERENCES `warehouses` (`id`) ON DELETE CASCADE,
  CONSTRAINT `addresses_ibfk_5` FOREIGN KEY (`shipping_account_id`) REFERENCES `shipping_accounts` (`id`) ON DELETE CASCADE,
  CONSTRAINT `addresses_ibfk_6` FOREIGN KEY (`facility_id`) REFERENCES `facilities` (`id`) ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

I see. This is due to the fact that the internal truncation migration are blocked by the DB constrains. I will get back to the truncation fashion we used previously, namely without migration but rather plan sql queries. I'll let you know in a moment when this can be pulled.

@dreamingmind I have updated the package to v0.2.14. The truncation is not performed anymore with intern migrations, but with SQL commands directly. In your case, these are located here: https://github.com/pakacuda/cakephp-fixture-factories/blob/master/src/TestSuite/Sniffer/MysqlTableSniffer.php
This should solve your issue. Do you confirm?

That looks like it did the trick! Thanks.

Thanks for the feedback!


fix(ios): Add support for reading __NSCFData key strings

I'm creating a Cordova app to replace an existing native iOS app. When trying to read the existing keys from the previous app, the app crashed when trying to serialize the key strings because they had a different encoding (I think - the error message complained about the strings being of type "__NSCFData").
This commit fixes that issue for me, however I know nothing about native iOS development or Objective-C so I'm not sure my quick-fix is the optimal solution. I also don't know how to properly add tests for this change.
If I need to change anything to get this PR accepted please let me know.
Thanks for the great plugin!

Since this is not very useful for anybody else, I am reluctant to merge. I would suggest you have a migration that checks the existing keys and migrates them before initialising secure storage.

Unfortunately I won't be able to do any more builds of the current apps before it's replaced with the Cordova version, so this is the only way I could think of.
I see your point about the limited use for others though. 👍