Add support for OpenCensus traces

Loving the project! I just wanted to add support OpenCensus. I realise there is a OpenTelemetry coming along which should subsume OpenCensus and OpenTracing, however it's not clear how long it will be until it's usable.
OpenCensus supports pluggable exporters, but I've only added an implementation for the standard agent. Unfortunately it seems the way exporters are configured and resolved is a bit side effecty and uses singletons, so we can't stop someone configuring new exporters outside of a resource.
I'm not sure what formatting standard you were using, so I just used the default scalafmt config. I can add a different config if you'd like?

Thanks! This looks good. Can you add doc comments that explain the edge case re: singletons?
I'm using the "tpolecat likes it" formatter which has no machine-readable representation. What you have here is fine.

This looks good. Can you add a doc comment that explain the edge case re: singletons?

Thanks, will do!

I'm using the "tpolecat likes it" formatter which has no machine-readable representation.

😆


Changing viewFinder* props doesn't have any effect

As the title already states... I tried to set custom values for viewFinder* properties and none of those worked: viewFinderDrawLaser, viewFinderLaserColor, viewFinderBorderLength, viewFinderBorderWidth.

Changes of ReactProp class in react native 0.19 introduced these issues (https://github.com/facebook/react-native/issues/5649). Please update to newest version 1.0.0 which corrects these. Could you close the issue if the problem is solved after the update? Thank you.

Sure @andreaskeller.

Well, it worked partially, @andreaskeller. viewFinderDrawLaser still doesn't have any effect.


Build for more versions of electron, restrict when a Windows warning is shown

This makes a couple of Electron related changes:

Build artifacts for Electron 1.5 and 1.6 and change the portability test to test against 1.6.
Modify a warning in the gyp file for building on Windows to not show when building for Electron, because it isn't relevant then.

Performance differences noted:
Benchmark                           cpu_time    real_time
--------------------------------  ----------  -----------
BM_MetadataFromNonInternedSlices      +12.00       +12.00
BM_TransportEmptyOp                   +16.50       +16.50
BM_TransportStreamRecv/64            +121.00      +121.00
BM_TransportStreamSend/4k             +55.00       +55.00

The Mac failure looks the same as #9979. The Windows failure is #10685. The interop failures are #10640 and #10576.


TIME-X Test Hackathon: Finish test for SwitchEstimator

During the TIME-X test hackathon at TU Darmstadt, I started with writing a test for SwitchEstimator. A previous version of the test is available here. The file provides a combination of unit-tests and integration tests (?).

Here, it is checked when the event does occur exactly at the boundary (i.e., on a collocation node at the boundary) whether a restart is executed or not. When the event does occur on the boundary no restart should be executed since here the resolution of the numerical solution for a specific accuracy is already given.

Another test checks whether the adapt_interpolation_info does what it is supposed to do. This method is intended to adapt the interpolation x-axis t_interp with corresponding y-values state_function. Using quad_type='RADAU-RIGHT' leads to len(t_interp) = self.coll.num_nodes while len(state_function) = self.coll.num_nodes + 1. The reason is that the initial time L.time is not included here because it is no collocation node but can be used for the interpolation anyway. Hence, it should be added to t_interp in adapt_interpolation_info. For quad_type='LOBATTO', we have len(t_interp) = self.coll.num_nodes + 1 but len(state_function) = self.coll.num_nodes. Here, the initial time of the subinterval is also a collocation nodes, hence t_interp[0] = t_interp[1] and the first entry has to be removed.

[ ] quad_type='RADAU-RIGHT': After adding L.time to t_interp test
assert t_interp[0] == L.time.

In a third test SwitchEstimator is applied to a problem for different tolerances tol passed to the switch estimator. This tolerance is used to decide whether the event is already close to the boundary or if the value of the state function at the event does already satisfy the tolerance. Intuitively, the smaller tol is the smaller the event error could be expected.

For all these tests, a specific dummy problem ExactDiscontinuousTestODE is implemented. This class inherits from DiscontinuousTestODE is does nothing than returning the exact dynamics of the parent class:

eval_f returns the derivative of the exact solution u_exact,
solve_system returns the exact solution.

Since this class returns the exact dynamics, for switch estimation the event should be estimated in a very accurately way, i.e., the event to be found can be assumed to be very close to the exact event time t_switch_exact. Discussion with @brownbaerchen led to this idea. The question is: Does this dummy problem make sense to test the correct framework of SwitchEstimator?
For the test, also piecewise linear interpolation for SwitchEstimator is implemented, and first observations does indicate a very small rate of restarts as compared to Lagrange interpolation. This could be observed for number of collocation nodes $M=3,4,5$, but seems to be not true for $M=2$.
Final question(s) to this issue:

Are tests sensitive enough to throw errors if the switch estimator does not work correctly anymore after an update?
Do the tests provide an answer to the question of whether the switch estimator works well in a specifically intended sense?

The test I was suggesting is slightly different, actually. One source of error in the switch estimator is the polynomial interpolation. But you can remove this source of error when the interpolation is exact. That is the idea behind the polynomial_testequation. Maybe you can modify this class such that you can force it to have a root within some interval.
Then, you can setup a controller, but instead of doing the whole time-stepping, you can just execute the specific parts of the switch estimator that you want to test. I do a similar thing here. Now, the switch estimator has to find the "switch event" i.e. the root of the state function exactly. Does this make sense? Of course, a root of the state function is not the same as a root of the right hand side. So maybe you need to write a completely different test problem.
But to my understanding, the switch estimator would be well tested if you verify that for exact interpolation, the correct step size is chosen to very high accuracy and if you switch to Thibaut's interpolation, which is already tested. Ofc, if you do some other kind of interpolation, you would have to test that separately.

Note for myself: The choice of the finite difference (FD) approximation to approximate the derivative of the state function inherently influences the performance of the switch estimator. Battery models does not like centered FDs but backward ones, whereas for the discontinuous test problems centered FDs seem to be a good choice. It seems like that it does make a difference if the state function changes its sign from positive to negative or vice versa.

If I understand correctly, you are using the derivative of the state function in a Newton solver to find roots. But the state function is not smooth, is it? So if you are using a backward stencil you are maybe not including the non-smooth part? That would be my guess why centered stencils sometimes perform poorly.
If you want to be a bit fancy, you can use the generic FD framework inside pySDC to generate a suitable stencil for you. You can use this function and experiment with high order centered stencils, lopsided stencils or whatever.

If I understand correctly, you are using the derivative of the state function in a Newton solver to find roots. But the state function is not smooth, is it? So if you are using a backward stencil you are maybe not including the non-smooth part? That would be my guess why centered stencils sometimes perform poorly.
If you want to be a bit fancy, you can use the generic FD framework inside pySDC to generate a suitable stencil for you. You can use this function and experiment with high order centered stencils, lopsided stencils or whatever.

So would only be a note for myself, so thanks a lot for your comment! Yess that's true, the state function is not smooth so your comment might make sense for me! This inherently improves the performance of the switch estimator.


Update README.md to be consistent with the new AP

The README.md was still showing the old API.
Just copied the part of the @docs to the README to make it consistent.

Oops thanks for catching this!


How to run without proxy?

Hi, is there such an option? Would like to run it just in container.

https://github.com/web3bothub/gradient-bot/issues/25


MLP: Add grouping support to neural nets

JIRA: MADLIB-1149
Changes to support grouping with neural nets. Changes include:

Standardize independent features by group.
Use GroupIterationController to iterate.
Create a temp scaled input table to be used by the
GroupIterationController
Create a new UDF that converts a standard deviation value of
0.0 to 1.0 when standardizing the independent variable.
Update docs, add more examples.
Refactor some utility functions code that was used by other
modules such as svm and elastic_net.
Update install check test cases scenario for MLP.
Create a new standardization output table that stores the
x_mean and x_std per group.
Add a new method in in_mem_group_control.py_in that returns
back a specific index's value from the state variable.

Closes #179

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/197/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/200/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/206/

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/207/

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/208/

Jenkins ok to test

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/210/

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/212/

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/213/

Jenkins ok to test

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/222/

Thank you for the comments @orhankislal , will update the PR with relevant changes.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/224/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/228/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/235/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/243/


feat(filtered-list) Allow quoting for exact values in filtered list

To allow exact quoting of values including spaces, e.g. "This thing" or 'this thing'
What I like about the implementation is that you can go back and add the quotes without the filter clearing.
I'm somewhat optimistic that with wildcards and quotes, there is not much more I would want in the filtered list for a text entry search (unless we did a full regex search) for "narrowing of the search"
Closes #1158

We think a new cooler behaviour is required and we spent, like, half an hour debating it so I think we'll close this!


fix:  Improve speed of kdtree grouping by pointops

Thanks for your nice work.
When the point count is too large, CPU loop querying for the nearest points becomes too slow. It is recommended to switch to point operations querying

Thank you for interest in our work and pull request! I notice that the function get_matching_indices is missing a return.

Thank you for interest in our work and pull request! I notice that the function get_matching_indices is missing a return.

Soory，I have added it

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

I check it, and the problem is 186 line in sam3d.py, it is modified.

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.
The code is copied from another project, so something can be missing

I tried it on scene0000_00, but met an IndexError: at here, index 3007 is out of bounds for axis 0 with size 3005.

Thank you, I try this modified code, there is no error.

Thank you !


Not updated for Android 7

Demo needs to be updated for Android 7 (Nougat).
I can volunteer to update the sample app.

Pull request here:
https://github.com/cmusphinx/pocketsphinx-android-demo/pull/24

Ok, thanks. I'm closing this one since pull request is there.


167 generic

This method looks pretty efficient and sensible to me. Could be useful to apply some of this to any code in menelaus.experimental re: NLP algorithms that are merged into the main repository.


3d Doors problem

Hi, I have a problem with doors in 3d view.
I have this room:

And the problem is this:

i dont know where is the problem. Apparently doors and well positionated, and well rotated.
The doors with fail are the bottom and the right ones.
In each door there arent any error:

I'm completely lost xD. Can you give me any idea of whhich can be the error?
Regards

Solved, problem was that colldiers doesnt fit grid.
Regards


k40-whisperer: init at 0.59

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Just realized that there was a hard-coded dependency to inkscape which needed patching. Updated the PR accordingly.

Entry in release-notes added.


Support BuckleScript 5.x.x

Opening this for visibility, and in response to https://github.com/ostera/bsdoc/issues/10
@dteoh is this somewhat close to what you got as well? I can't get this to build an esy npm-release correctly.

Yeah, this is pretty similar to what I ended up with.
I tried building your branch locally. esy npm-release is failing because one of the dependencies uses String.split_on_char, which seems to have been introduced in OCaml 4.04.

I downloaded the source tarballs of all dependencies to grep for split_on_char, but no luck.


VSCode在滚动时总是自动打开输出面板

这个很是影响用户体验，我不需要这个时候打开，wohai我还在调试代码，代码都没写完，她就自动打开，我需要的是他是用户选择打开

@Microsoft :
Translated into English is:
The output panel is always opening while debugging codes, and I didn't finish my codes yet.
@Rain120 ：
Would you mind making a record video and submit here for Microsoft members to make an analyse? And for the next time, please put down your ideas in English ;)
You can use something like: https://obsproject.com/, A free video maker.

You can control the behavior with the debug.internalConsoleOptions setting.


Add Ruby 2.3.0

Thanks.  I'll partly merge this, I'm not going to drop support for 1.8 in minor updates.

@knu I can revert this commit but then I should restrict test-unit version to one that still supports 1.8

...because test-unit developers aleady dropped ruby 1.8.7 support in a minor relase 3.1.6

@knu it's okay now, i can rebase if you want.


Feature request - integrate with bindata

Wouldn't it be neat to integrate with bindata or other binary embedding tech? Executables could be reconstructed and executed without needing to know paths.

Nice idea, however, I think it would be best to solve it in another package. For one thing, it has some heuristics to implement.
To execute the embedded binaries you still need to write them down to the filesystem somewhere. Where? Maybe not in the temp files, there executables might not be allowed. So I guess for that too we might need user conf.


Add annotations and fix bugs

Fix bugs of temporal sliding windows
Fix bugs of quad tree rotation issue
Fix typo
Add detailed annotation to 01.AdaSTEM_demo.ipynb
rm 04.Prediction_visualization.ipynb

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0f83154) 73.89% compared to head (413e553) 74.08%.
Report is 2 commits behind head on main.

Files
Patch %
Lines

stemflow/manually_testing.py
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   73.89%   74.08%   +0.19%
==========================================
  Files          15       15
  Lines        1180     1181       +1
==========================================
+ Hits          872      875       +3
+ Misses        308      306       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Do we need the "Original Code" column in the DB?

Is this crucial to their creation? It will always be the "stock template", I believe, which is hardcoded.
Can we replace it with "last save" instead so it is a one-instance version control?
Aside, and probably for its own issue: We can probably spin off the above idea to let it record the past e.g., 5 version or let us "lock" in one version of a program's code to protect against accidental overwrites or breaking changes.

During a meeting, JB noted that the Original Code column is tied to the "Revert to original code" functionality in the Editor. We don't want this with the current way Programs are created, and we probably don't want it at all. It'd be better to replace it with some light version control as described above, combined with hardcoding some of the database to the repo and creating regular backups.


fixed typo

'mordern' -> 'modern'

Thank you very much!

BTW that was my first pull request ever, you made my day!

haha no problem! && it's one of my first accepted by another person :)


timer: restarting a closing timer succeeds and leads to a limbo

Version: 1.29.1, 1.30.1
Platform: All

Calling uv_timer_start() on a closing timer unexpectedly succeeds and leads to a limbo (uv_run() does not exit).
#include <uv.h>

static void close_cb(uv_handle_t *handle) {
    printf("close_cb(%p)\n", handle);
}

static void timer_cb(uv_timer_t *handle) {
    printf("timer_cb(%p)\n", handle);
    if (uv_is_closing((uv_handle_t *)handle)) {
        uv_print_all_handles(handle->loop, stderr);
        return;
    }
    uv_close((uv_handle_t *)handle, close_cb);
    uv_timer_start(handle, timer_cb, 1000, 0);
}

int main() {
    uv_loop_t *loop = uv_default_loop();
    uv_timer_t timer;

    uv_timer_init(loop, &timer);
    uv_timer_start(&timer, timer_cb, 1000, 0);

    uv_run(loop, UV_RUN_DEFAULT);

    /* Omit cleanup */
    return 0;
}

Output:
$ ./a.out
timer_cb(0xfffaa7f4)
close_cb(0xfffaa7f4)
timer_cb(0xfffaa7f4)
[--I] signal   0xf7ede2f4
[-AI] async    0xf7ede200
^C

Sounds like uv_timer_start needs a check for uv_is_closing? Would you be interested in submitting a PR? It looks like you essentially already have the test written there! 🙂

Ok, done.
On the side note, it appears there's no clear error policy as to where an assertion (compile time error) is preferred rather than returning an error code (runtime error). Some handle starting routines make an assertion that a handle isn't closing, some return EINVAL whereas others don't bother checking at all. Some housekeeping is probably required.


Terminal line height is too large

Issue Type: Bug
Win10 Home, bash (WSL I assume), font: Fira Code
"editor.lineHeight": 0
"terminal.integrated.lineHeight": 0.5
In editor view, line vertical spacing is by default snug; the way I like.  In Terminal, seems lineHeight is 1.5, with large spacing, despite my setting.  (Restarted terminal in New Window).  Even if hardwired at 1.0, the line height is simply wrong, & hard to read.  The terminal wasn't like this before; happened within last few weeks/months.

VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz (4 x 2400)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
19.91GB (10.45GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (12)

Extension
Author (truncated)
Version

google-search-ext
ade
0.2.1

vscode-toggle-quotes
Bri
0.3.2

bracket-pair-colorizer-2
Coe
0.0.28

gitlens
eam
9.8.1

svg
joc
0.1.4

vscode-github
Kni
0.30.2

rainbow-csv
mec
1.1.1

indent-rainbow
ode
7.4.0

vscode-versionlens
pfl
0.23.0

partial-diff
ryu
1.4.0

es-quotes
vil
0.2.6

glean
wix
4.11.0

(6 theme extensions excluded)

I believe this is already fixed, can you see if you can reproduce in the Insiders build?


Feature: Script similarity

Description
If someone finds a script, they might want to find a similar looking script.

How do you identify similarity without looping through every script? This feels a bit like an algorithm problem. If I just loop through every script and compare similarity that at the moment is possibly the best method because there are only 130 odd scripts. But then this could grow to a huge number and then you probably want to coalesce the scripts that share 1 with you, then which share any 2 (although any 2 is hard).

Currently testing out this feature https://github.com/AdmiralGT/botc-scripts/pull/121


Fix antimeridian centroid bug

Codecov Report

Merging #92 (5959550) into stable (1710897) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           stable      #92   +/-   ##
=======================================
  Coverage   79.50%   79.51%
=======================================
  Files          26       26
  Lines         527      532    +5
=======================================
+ Hits          419      423    +4
- Misses        108      109    +1

Flag
Coverage Δ

unittests
79.51% <85.71%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

asf_search/ASFProduct.py
82.14% <85.71%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1710897...5959550. Read the comment docs.


Installing on Nokia E71

Hi, I have a Nokia E71 lying around, and was wondering if I can install a xen hypervisor and a mirage unikernel on it.. Can I?

Getting MirageOS working on a mobile device/phone would be pretty cool but my guess is that wouldn’t work with the E71 [1].  The hardware is quite old and likely not able to run Xen as required. There are probably a lot of other issues with trying to use an old phone handset as a dev environment.
We use the Cubieboard2 (and CubeTruck) [2] as our ARM dev environments and I’d suggest you consider those.  The prebuilt images from http://blobs.openmirage.org make it much quicker to get started (and are based on this repo).
[1] http://www.gsmarena.com/nokia_e71-2425.php
[2] http://cubieboard.org

On 18 May 2015, at 03:10, Amitai Hoze<EMAIL_ADDRESS>wrote:
Hi, I have a Nokia E71 lying around, and was wondering if I can install a xen hypervisor and a mirage unikernel on it.. Can I?
—
Reply to this email directly or view it on GitHub.


app: No option to go back to default avatar style in option panel

Right now we have two of the avatar styles implemented but we do not have an option to go back to original default avatar. Only way is to reload the app.

I think the way we will do it is instead of deleting the old avatar when we switch, we will leave the old avatar in place.

Or we can add another option for default avatar style as a 5th option. Can we?

Maybe we are talking about different things. I was talking about the ability to wear an avatar in-world, and still having access to the previous avatar.
If this is about changing avatar render modes, but not changing the avatar, then I think we should just finish implementing all of the settings in the options panel. There is no need for a 5th option. The default will be auto-detected from one of the existing four options.


Extended lane changes capabilities

Description
Extended the lane changes capabilities so that multiple-lane lane changes are possible. This affects both the LaneChangeAction at OSC as well as the LaneChange atomic.
Failed lane changes no longer break the simulation, but correctly stop it instead
Fixed bug causing the ChangeLane scenario to never end.
Where has this been tested?

Platform(s): Ubuntu 18.04
Python version(s): 3.6
Unreal Engine version(s): 4.24
CARLA version: current master (0.9.10 pre release)

This change is

Can you update the branch? Then we can merge it :)


Fix a typo in docstring

Codecov Report

Merging #110 (6fe672d) into master (7321be1) will decrease coverage by 5.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   77.54%   71.67%   -5.87%
==========================================
  Files          12       12
  Lines        1777     1762      -15
==========================================
- Hits         1378     1263     -115
- Misses        399      499     +100

Impacted Files
Coverage Δ

src/Enzyme.jl
82.55% <ø> (ø)

src/compiler/orcv1.jl
0.00% <0.00%> (-82.00%)
:arrow_down:

src/compiler/validation.jl
44.39% <0.00%> (-19.25%)
:arrow_down:

src/compiler.jl
78.50% <0.00%> (-2.67%)
:arrow_down:

src/typetree.jl
80.89% <0.00%> (-1.33%)
:arrow_down:

src/compiler/orcv2.jl
96.82% <0.00%> (+9.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7321be1...6fe672d. Read the comment docs.

Oops, sorry, I was using the wrong version.

I was about to say xD


Rejected by several companies

In late 2012, during a phone interview, I was told that, by judging from my résumé, I might better look for a trainee position – but somewhere else, please, kthxbye.
One week later I applied at Smashing Magazine and was hired right away – full time. Almost 2 years later it was one of the fastest blogs on the web – still improving on a daily basis.

Thank you!


EventStyles disappearing after page refresh

I'm having the weirdest bug where if you load the timeline the first time it has the icons etc. in event styles, but afterwards they seem to disappear. I'm not sure what this is, but it may be a frontend bug, or it could have something to do with the seeds.

Duplicate of #134


Compile Scala 3 version with Scala LTS (3.3.4)

Compile Scala 3 version with Scala LTS (3.3.4). See issue https://github.com/pac4j/play-pac4j/issues/731

Copy that. Thanks

Thanks you for merging this.
Do you think that would be possible to publish a release?
The last patch is unusable within a Scala 3 application for this reason.

[error] error while loading scala,
[error] TASTy file scala/NamedTupleDecomposition.tasty could not be read, failing with:
[error]   Forward incompatible TASTy file has version 28.6, produced by Scala 3.6.1-bin-nonbootstrapped,
[error]   expected stable TASTy from 28.0 to 28.5.
[error]   To read this TASTy file, use a newer version of this tool compatible with TASTy 28.6.
[error]   Please refer to the documentation for information on TASTy versioning:
[error]   https://docs.scala-lang.org/scala3/reference/language-versions/binary-compatibility.html

Sure. I just cut the v12.0.2-PLAY3.0 release. It will show up in the Maven central repo within a few hours/minutes.


Doc updates for Gettext usage

Per #318.
There already was some docs on gettext, it just wasn't being picked up by rdoc (rdoc, ugh 😷). I did make a small update here.

Thanks @sshaw! This looks good to me.


Bug: YAML Title does not pull from filename

Describe the Bug
If there are any headers in the file, "YAML Title" will pull the first header for the title instead of using the filename (or even an h1 later in the file) for the YAML title field.
How to Reproduce
Steps to reproduce the behavior:

Create a file with a header besides an h1
Lint
The YAML will contain title: headername

Expected Behavior
The YAML should contain title: filename
Device

[ ] Desktop
[x] Mobile

This is actually a part of the documentation: https://github.com/platers/obsidian-linter/blob/master/docs/rules.md#yaml-title
It will pull the filename only if no H1 is present.

There is no h1 in the file, so it pulls from the first header of any level.
Actually it pulls from the first header of any level even if there is an h1 in the file, so if you have
Text
### not the title

# Title

The result will be
---
title: not the title
---

Interesting. I will see if I can reproduce this when I get a chance later this week.
For future reference, it would help if the initial creation of these bugs and feature requests included the example to help avoid misunderstandings on my or other dev's parts as the example makes it clear that you mean a non-H1 header while the words describing this scenario are a little more ambiguous.

I see the issue with it grabbing the wrong header: https://github.com/platers/obsidian-linter/blob/master/src/utils/regex.ts#L5
It needs to be updated to use a regex that just checks that the header is just an H1. I will update that soon.

Yeah, I see now that I edited it to make it less clear. Oops!

No worries. This should be a simple fix.

The fix for this should be pushed onto master shortly.

This should be fixed on master and in the next release. Please let us know if that is not the case.


gst-plugins-bad: patch nvcodec to check opengl path

Description of changes
Fixes #189217 by loading the absolute paths for cuda userspace if normal lookup fails. Since it is a fallback it should not break non-nixos users or users overriding through LD_LIBRARY_PATH.
This patches libcuda, nvenc (libnvidia-encode) and nvdec (libnvcuvid). It does not patch libnvrct since that is not part of the nvidia driver.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Rebased to staging, since changing gst-plugins-bad causes quite a few rebuilds

@ofborg build gst_all_1.gst-plugins-bad

I should note that this patch will clobber the g_module_error() output. But in practice this doesn't matter since the only failure modes are "generic failure"  and "g-module check failure". And none of the libraries loaded are g-modules.

The failure of darwin builds is caused by gst-plugins-bad's dependencies according to the log.
BTW, is there a way to download ofborg's build log?

BTW, is there a way to download ofborg's build log?

If you scroll up on the log page, there is a link to the full log: https://logs.nix.ci/logfile/nixos/nixpkgs.190023/b7db2e2c-266d-4d9b-9831-9cd6b91cdd43

Since the only change this PR does is add a duplicate to a library call that was already there, I don't think this will break macos more than it already was. At least the x86_64-macos failure seems to be upstream in librsvg.


String as a second argument won't appear in logs

Bug Description
How to reproduce
const logger = new Logger();
const err = new Error('This is second argument');

logger.log('This is message.', err.message);  // show `This is message.` only.

Expected behavior
Shows both, like
logger.log('This is message.', err.message);  // show `This is message. This is second argument`.

Add delimiter for better readability. - as  delimiter.
// show `This is message. - This is second argument`.


Uncaught Error: class does not have id

I am new to using any sort of Chartjs plugin so maybe I am doing something silly.
But I can't get this plugin to work. I have Chart.js 3.0.2 and chartjs-plugin-annotation 0.5.7
I am using Webpack and was able to get Chartjs working fine, but couldn't import annotation without the following error.
Simply commenting/uncommenting the line Chart.register(annotationPlugin) will toggle the error.
To do a minimal example I just reduced down to a file with nothing but this code from the docs:
import { Chart } from 'chart.js';
import annotationPlugin from 'chartjs-plugin-annotation';

Chart.register(annotationPlugin);

And that results in the same error
Uncaught Error: class does not have id: function(chartInstance) {
			var chartOptions = chartInstance.options;

			// Initialize chart instance plugin namespace
			var ns = chartInstance.annotation = {
				elements: {},
				options: helpers.initConfig(chartOptions.annotation || {}),
				onDestroy: [],
				firstRun: true,
				supported: false
			};

			// Add the annotation scale adjuster to each scale's afterDataLimits hook
			chartInstance.ensureScalesHaveIDs();
			if (chartOptions.scales) {
				ns.supported = true;
				chartHelpers.each(chartOptions.scales.xAxes, setAfterDataLimitsHook);
				chartHelpers.each(chartOptions.scales.yAxes, setAfterDataLimitsHook);
			}
		}
    register chart.esm.js:4468
    _exec chart.esm.js:4594
    _each chart.esm.js:4586
    each helpers.segment.js:109
    _each chart.esm.js:4584
    _each chart.esm.js:4579
    add chart.esm.js:4536
    value chart.esm.js:5768
    js barChart.js:63
    Webpack 5```

You'll need to use the @next pre-release of this plugin with Chart.js v3. I'd expect a full release quite soon though.

Thank you, that worked.


Schemas to Open-API Spec

Adds schemas to Open-API specification.
I had some troubles when bringing my local fork up to date. @cmil you could also just take the updated api.yaml file and close this pull request without merging, that it won't mess anything up.

To keep the history concise I just added api.yaml in a single commit here: 940d6ddbeb04ccf4700bca4da4ef8da10d5423a3.


UI Changes to the Magium App

Here is the list of changes:

Added a fixed header, with dummy buttons
Added logic to infer book and chapter number from the id (we may want to discuss later on improving this, either the logic, or a way to store it in the json data itself, i am personally more biased towards the latter)
Added the required styling to match the app's look-n-feel
Added dark theme using cookies.
Added a fixed footer, with a temporary dark theme toggle button

https://github.com/user-attachments/assets/8ef6c0d0-f5f7-48db-b41d-7bc615d0d2d2

Based on the discussions in the group, I am merging these changes, since we do have to iterate fast.


How set default service uuid for multiple mobile devices running same app, so that it will scan only those devices only?

Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

[x] I am running the latest version
[ ] I checked the documentation and found no answer
[ ] I checked to make sure that this issue has not already been filed
[x] I'm sure that question is related to the library itself and not Bluetooth Low Energy or Classic in general. If that so, please post your question on StackOverflow or on our Gitter channel.

Question
Please describe the question.

How set default service uuid for multiple mobile devices running same app, so that it will scan only those devices only?

To scan only devices that advertise a particular UUID one needs to add it as a parameter. bleManager.startDeviceScan([uuid], ...)


Generalize the wide reduction kernel in max_pool2d to work with non-max-tile-multiples

Blocked by LLK issue

blocked by LLK issue: https://github.com/tenstorrent/tt-metal/issues/14973


Misidentified url in markdown footnote

Hello,
I'm using Codemirror 5 with blackboard theme and markdown language mode. Everything works perfectly (thanks!) except for the following: in a markdown footnote the first word of the text is misidentified as cm-link.
The result is an annoying color change:

The line content is:

Instead a regular link like [test](http://example.com) has the URL correctly identified as cm-url and correctly colored.

From my side seems there is nothing I can do to distinguish the two cases.
Anything that could I do?
Thanks!
mario

With v6 the problem happens if there is only one word after the [^1]: so I close this issue.


Migrate Swift 4.2

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Any news about migration?

Sorry about the delay, thanks so much for taking the initiative here :)


Commenting not working on pages with read_only FieldPanels

Issue Summary
When editing pages with read_only FieldPanels commenting does not work on the whole page.

No Toggle button is visible

Error is show in the browser

I guess this is the specific line:
https://github.com/wagtail/wagtail/blob/fd08d209be121b7761f618393c2a490768a03b24/client/src/entrypoints/admin/comments.js#L22
At the execution the fieldNode is null.
Steps to Reproduce
For me it can be reproduced in a Page model with following content_panels:
content_panels = [FieldPanel("title", read_only=True, classname="title")]

Technical details

Python version: Python 3.11.1
Django version: Django==5.0.4
Wagtail version: wagtail==6.0.2
Browser version: Edge 123

After a litte bit of investigation:
A read only FieldPanel has no field key inside the context:
https://github.com/wagtail/wagtail/blob/fd08d209be121b7761f618393c2a490768a03b24/wagtail/admin/panels/field_panel.py#L331-L342
The variable contentpath from the formattedfield tag is empty:
https://github.com/wagtail/wagtail/blob/366a2a48c81f3c6283b01e7e8398e998e0bd454b/wagtail/admin/templatetags/wagtailadmin_tags.py#L1205
Therefore the tag data-contentpath is not filled:
https://github.com/wagtail/wagtail/blob/fd08d209be121b7761f618393c2a490768a03b24/wagtail/admin/templates/wagtailadmin/shared/formatted_field.html#L28
The FieldLevelCommentWidget wants to build a fieldNode and expects a data-contentpath:
https://github.com/wagtail/wagtail/blob/fd08d209be121b7761f618393c2a490768a03b24/client/src/entrypoints/admin/comments.js#L247-L253
As a consequence, the fieldNode is null which leads to the error inside the browser from the screenshot above and no commenting is possible.

I can confirm that the issue exists.
When I set read_only=True for any field, I'm not getting option to add comments to any other fields. Also, an error shows up in the console.

After doing some research, I mostly agree with what @mattibo mentioned above. When I changed the context's content_path to "contentpath": field.name if field else "disabled", the problem was fixed. But, I don't think hardcoding a value is the right way to solve this. So, I'm pretty sure the issue comes from the empty string we're using in the else condition. And, it's likely that one of these parts of the comments.js file is causing the problem.
https://github.com/wagtail/wagtail/blob/b664169b3288385c4a7e2c8bccda92fe5e6d402a/client/src/entrypoints/admin/comments.js#L22
https://github.com/wagtail/wagtail/blob/b664169b3288385c4a7e2c8bccda92fe5e6d402a/client/src/entrypoints/admin/comments.js#L249
@lb-, I'm trying to find out the exact issue, but it would be really helpful if you could take a look too.

i was able to fix this issue, would be able to push a fix for it soon


Remove parameter "-organization" from line 247

In line 247, the parameter mentioned in the command should be removed as it is just for internal use only, so, its existence in this article is misleading the article readers who does not have enough experience about Exchange online PowerShell. Here is below the command documentation article that mentions that the parameter "-organization" is for internal use only and it will not work with Exchange online administrators: https://learn.microsoft.com/en-us/powershell/module/exchange/get-serviceprincipal?view=exchange-ps#-organization

Docs Build status updates of commit 242fc90:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/legacy-protocols/how-to-authenticate-an-imap-pop-smtp-application-by-using-oauth.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update to prettier 2.5.1

Closes #10837

Lost of noise for not much value (mostly newline changes), will revisit later.


"Site changed" webhook

Alongside the API v2 and new auth mechanisms we'll be exposing our webhooks functionality via the admin UI and adding a new "site changed" webhook.
Brief feature outline:

allow registration of webhooks via the admin UI
add a new "site changed" webhook that can be used to trigger rebuilds when using static site generators such as gatsby.js with Netlify

It'd be great to have webhooks validated like GitHub's are! https://developer.github.com/webhooks/securing/#validating-payloads-from-github
Apologies if this has already been considered, I can't see anything hinting towards it.

@rishabhgrg Can we close this issue?

@kirrg001 Keeping it open till the UI is enabled for this, will close after.


i dont think its working with the latest version

i dont think its working with the latest version

getting same issue

first think its a plugin's Rte then i realize that its the default RTE from grapesjs

This plugin is won't work because of the new changes in GrapesJS.
look 👀 cusotm Rte


Removing redirect url

After looking in the (thin) ASDF documentation I couldn't find any way to tell the bash script when an installation is from asdf or not 🙁
Hope this solves issue #11

❤❤❤❤❤


UnknownHostException for resolve bootstrapServers.

Issue submitter TODO list

[X] I've looked up my issue in FAQ
[X] I've searched for an already existing issues here (legacy) and here
[X] I've tried installing latest charts and the issue still persists there
[X] I'm running a supported version of the application & chart which is listed here

Describe the bug (actual behavior)
Got exception UnknownHostException for host from bootstrapServers field.
But in container host resolved correct.
Expected behavior
Resolve host from bootstrapServers.
Your installation details

56fa824
version: 0.7.5, appVersion: v0.7.1
config.yaml:

auth:
  type: disabled
kafka:
  clusters:
  - bootstrapServers: kafka-node3:9092
    name: prod-k8s-htz
  - bootstrapServers: infra-cluster-kafka-bootstrap:9092
    name: infra-kafka-logs
management:
  health:
    ldap:
      enabled: false

Steps to reproduce
I add to config two clusters.
First is external host with kafka.
Second is kafka in k8s.
Can resolve hosts in container:
/ $ cat /etc/resolv.conf
search infra.svc.cluster.local svc.cluster.local cluster.local example.com
nameserver <IP_ADDRESS>
options ndots:5

/ $ getent hosts kafka-node3
<IP_ADDRESS>        kafka-node3.example.com  kafka-node3.example.com kafka-node3

/ $ getent hosts infra-cluster-kafka-bootstrap
<IP_ADDRESS>     infra-cluster-kafka-bootstrap.infra.svc.cluster.local  infra-cluster-kafka-bootstrap.infra.svc.cluster.local infra-cluster-kafka-bootstrap
/ $

But in log i see for external server:
2024-02-06 22:40:59,380 WARN  [kafka-admin-client-thread | kafka-ui-admin-1707259237-3] o.a.k.c.NetworkClient: [AdminClient clientId=kafka-ui-admin-1707259237-3] Error connecting to node kafka-node3.example.com:9092 (id: 5 rack: null)
java.net.UnknownHostException: kafka-node3.example.com: Name does not resolve
	at java.base/java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
	at java.base/java.net.InetAddress$PlatformNameService.lookupAllHostAddr(InetAddress.java:933)
	at java.base/java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1534)
	at java.base/java.net.InetAddress$NameServiceAddresses.get(InetAddress.java:852)
	at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1524)
	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1381)
	at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1305)
	at org.apache.kafka.clients.DefaultHostResolver.resolve(DefaultHostResolver.java:27)
	at org.apache.kafka.clients.ClientUtils.resolve(ClientUtils.java:110)
	at org.apache.kafka.clients.ClusterConnectionStates$NodeConnectionState.currentAddress(ClusterConnectionStates.java:510)
	at org.apache.kafka.clients.ClusterConnectionStates$NodeConnectionState.access$200(ClusterConnectionStates.java:467)
	at org.apache.kafka.clients.ClusterConnectionStates.currentAddress(ClusterConnectionStates.java:173)
	at org.apache.kafka.clients.NetworkClient.initiateConnect(NetworkClient.java:990)
	at org.apache.kafka.clients.NetworkClient.ready(NetworkClient.java:301)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.sendEligibleCalls(KafkaAdminClient.java:1143)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.processRequests(KafkaAdminClient.java:1403)
	at org.apache.kafka.clients.admin.KafkaAdminClient$AdminClientRunnable.run(KafkaAdminClient.java:1346)
	at java.base/java.lang.Thread.run(Thread.java:833)

Looks like bug.
I can use as workaround two dedicated kafka-iu:

for external kafka with ndots:1 and fqdn in bootstrapServers.
for kafka in k8s with default ndots: 5

But it is strange that in container resolver i can get ip for hosts but application show error.
Screenshots
No response
Logs
No response
Additional context
No response

Here Are the modified Dockerfile
FROM azul/zulu-openjdk-debian:17-jre-headless

RUN apt-get install \
    # snappy codec
    # gcompat \
    # configuring timezones
    tzdata
RUN groupadd kafkaui && useradd kafkaui -g kafkaui

# creating folder for dynamic config usage (certificates uploads, etc)
RUN mkdir /etc/kafkaui/
RUN chown kafkaui /etc/kafkaui

USER kafkaui

ARG JAR_FILE
COPY "/target/${JAR_FILE}" "/kafka-ui-api.jar"

ENV JAVA_OPTS=

EXPOSE 8080

# see JmxSslSocketFactory docs to understand why add-opens is needed
CMD java --add-opens java.rmi/javax.rmi.ssl=ALL-UNNAMED  $JAVA_OPTS -jar kafka-ui-api.jar

I had it running with keycloak but got a nice formatted 404 when logging in that my browser debug mode didn't see. Also needed to press F5 a few times to get it to log in.
I gave up on Kafka UI for now, and am running AKHQ with keycloak integration behind a reverse proxy on kubernetes.
I do hope that the Kafka UI devs look into the problems when running kubernetes. Main problem seems to be Alpine Linux and strange issues when behind a reverse proxy. I do believe that they are doing their best and will ultimately turn it into the enterprise grade tool it was intended to be. I will check back in the future.

@likeMyCoffee #4255
https://github.com/kafbat/kafka-ui


Bump up rust to 2021 edition

Any reasons for sticking to 2018?

With 2018 -> 2021 change we will need to add field rust-version to Cargo.toml.
https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field

Looks like the build is broken until this is addressed.

we're now using rust 2021 so im closing this


Top header and nav bar with icons

-Add a black bar with heading on top of page
-Use Bootstrap icons and create a navigation switch
-Remove temp images used

@lawongsta Can you review please?


Removed Jenkinsfile not used

So the PR job on ASF Jenkins is now configured via Jenkins UI, right? What can I do to get read access to those settings?

You should already have read access to the ui with your ASF account. To modify the stuff you need to be committer.

Yes, I can see a bit more when I log in, but https://builds.apache.org/job/camel-quarkus-pr/configure/ still returns 404.
But actually, there is a workaround: in the full build log I can see the commands that Jenkins uses to build the repo, so I am fine.


ERROR in import

Copy Diagnostic Log
VS402362: No process template with type 62a4d689-9a18-49ea-a6f9-a7d6de8345dc was found.

Looks like this error is from the customized template. When you are importing the custom generated template, make sure that you have the same process Id in the source and target organization or import the template in the same organization.
Other option is, change the process template Id in the ProjectSettings.json file and import the template.


Keychain doesn't work with XCode 8 Beta 6

After porting my app to XCode 8 with Swift 2.3 (I waited until Beta 6 to do so), all of my tests passed with the exception of 1 set where I was storing Account information in the keychain and seeing if I could read it out.  Everything I read out was nil.  Note: I'm using a prefix.
To see if this was my issue or a an issue with keychain-swift, I did the following:

Cloned the keychain-swift repository, checked out the Swift_2_3 branch.
Loaded it into XCode 8 Beta 6, selected the KeyChainSwift target and ran tests.

What I got was a failure in KeychainWithPrefixTests.swift, line 35.
Is there something I'm doing wrong?
Btw, I'm not on Swift 3.0 because some other libraries I use are not yet compatible.

Just a note: I opened the same project in XCode 7.3.1 and tests ran fine.  In XCode 8, while debugging, I found that SecItemAdd was returning -34018, which is weird.

Hello, thank you for your feedback. Yes, unfortunately, keychain does not work at all in Xcode 8 / iOS 10 unless one enables Keychain Sharing in the Capabilities tab.
http://stackoverflow.com/questions/38456471/secitemadd-always-returns-error-34018-in-xcode-8-beta-4-in-ios-10-simulator/38543243#38543243
Let me know how it goes.

Hi, thanks for the suggestion.  Setting the Keychain did indeed allow all tests to pass.  I also noticed a app.entitlements that was created.  I didn't set anything in it.
Is XCode 8 buggier than one might expect at this point?  I'm having terrible luck with it.  I was able to actually get my Xcode 8 branch working in Xcode 7, but have found even that to be much worse than my pre 8 changes branch.  For example, I'm not able to run my app on my device.  Could that be related to the KeyChain sharing?
Thanks for the help and for keychain-swift.  I really like it.

Thank you for kind words. I am not sure why the Keychain is still not fixed. It is still not clear if it is even a bug or intended functionality in iOS 10. There is one possibility that from iOS 10 it is now required to always enable Keychain Sharing in order to use Keychain, but I have not found any official information about this. Feel free to point to it if you found it.
And yes, the entitlements file is created automatically when you enable the Keychain Sharing, this is where the keychain access group is stored.
All the best.

Hi - I am writing a framework (using Keychain-swift) and so now my tests don't work building for iOS 10 / using Xcode 8. As it is a framework, I don't believe i can add an entitlements file - do you know if there is there any way around this?
Thanks :)

Hi @tendaimoffatt, very good point. No, unfortunately I do not know the way around this. I have the same problem. You can run the tests with your developer profile by enabling the keychain sharing in a demo app and setting it as the host application in the test target, but others will need to select their profiles to do that. If you find a solution feel free to share.

Hello friends, just an update. It looks like the Keychain bug was fixed in Xcode 8.2. The Keychain now works in iOS 10 simulator and there is no need to enable Keychain Sharing as a workaround. Cheers.

Closing the issue, since the problem appears to be fixed in Xcode 8.2. Feel free to reopen if needed.


Understanding the format: How to include addition info in collection response

Being new to siren I am struggling with the following scenario.
I have a collection resource that returns a different result based on a query param:
/items?code=FOOBAR
What would be the responses class and properties?
The response would contain the items but I'd like it to also include information about the code, especially when it is about to expire. Would the _links key the right place to put a rel: ["code"] in there that references the code resource where the client could get more info about the code? Could the collection response also already contain parts of the code resource, like the expireDate as inline properties?
Could the expireDate be part of the responses properties?
Thanks for helping out here.

Have you seen issue  https://github.com/kevinswiber/siren/issues/54 ?


cli: add explicit --standby argument

Before:

--replica=1 --replica_count=2 creates an active replica with index=1
--replica=2 --replica_count=2 creates a standby with index=2

Now:

--replica=1 --replica_count=2 creates an active replica with index=1
--standby=2 --replica_count=2 creates a standby with index=2
--replica=2 --replica_count=2 is an error

That is, the semantics of the argument is the same, its replica index stored in the superblock, but the name must be --replica for active replicas and --standby for standbys.
This binds intention into the CLI and makes it more self explanatory and less error prone.
Additionally, we have an easier time "hiding" --standby feature until we need it for reconfig, backups, cdc, or canaries.

Well, let me expand this to a large experimental CLI idea.


Feature

Add
Per week , month , season or customed time leader board and score hud and dayli players time loging

Fpr pm4

No pm5

PlayedTime won't get new features and updates for PM4. The PM4-version of PlayedTime (and also theSpawn) are end-of-life.
Please use PM5.

Are you see my first message? :|


Implement react-hook-form and Zod in Kontakt page

Fixes #272
Implement React Hook Form and Zod in the Kontakt page and update Jest tests.

KontaktContent.component.tsx

Replace useState and useRef with useForm from react-hook-form.
Add Zod schema for form validation.
Update form handling to use react-hook-form and Zod.
Update form fields to use register from react-hook-form.
Display validation errors from Zod.

package.json

Add react-hook-form and zod to dependencies.

KontaktContent.test.tsx

Mock react-hook-form and Zod.
Update tests to work with react-hook-form and Zod.

jest.config.js

Add react-hook-form and zod to moduleNameMapper.

For more details, open the Copilot Workspace session.

Codecov Report
Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.23%. Comparing base (4003b72) to head (4598d53).

Files
Patch %
Lines

...rc/components/Kontakt/KontaktContent.component.tsx
72.22%
5 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   98.00%   93.23%   -4.77%
==========================================
  Files          22       22
  Lines         200      207       +7
  Branches       59       62       +3
==========================================
- Hits          196      193       -3
- Misses          4       14      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DestinationType.NATIVE_URI returns content URI on Android.

DestinationType.NATIVE_URI returns content URI on Android which results in this error:
Not allowed to load local resource: content://com.android.providers.media.documents/document/image%3A6770
I had to use cordova-plugin-filepath to get the real native URI.
Stack overflow issue can be found here:
https://stackoverflow.com/questions/54088732/cordova-camera-plugin-not-allowed-to-load-local-resource-content

I checked latest code in master, and I found that NATIVE_URI option actually returns the right native URI that starts with file:// prefix.

@sohrabtaee another note, try to use Camera.DestinationType.NATIVE_URI instead of Camera.DestinationType.NATIVE_URL.
Destination type constants are defined as follows:
    DestinationType: {
        /** Return base64 encoded string. DATA_URL can be very memory intensive and cause app crashes or out of memory errors. Use FILE_URI or NATIVE_URI if possible */
        DATA_URL: 0,
        /** Return file uri (content://media/external/images/media/2 for Android) */
        FILE_URI: 1,
        /** Return native uri (eg. asset-library://... for iOS) */
        NATIVE_URI: 2
    },

Hi @hazems
Thanks for taking the time to review this bug. Unfortunately, when I changed NATIVE_URL to NATIVE_URI still I get a broken image preview when I choose the photo from the photo library.
Note that it works fine when I take a photo using the camera.

This is weird, what is the device model and Android OS version does it has?

I have tested on Galaxy S9 with both Android 8 and 9, but our customers have tested it with some other Android devices and the results were the same.

I also experience this issue...

Closing as native_uri return type was removed on 5.0.0


Suggestion: check for if player's spawn is in same chunk as expulsion pylon to prevent griefing

Currently the expulsion pylon just sends people away no matter where their spawn is. However, if the pylon is placed in the same chunk as the player's spawn they are basically trapped until it is destroyed. Is there any way that the pylon could check where the player has their spawn set and send them to world spawn or just not send them away at all? Otherwise this could be used to permanently trap players inside their base or even at world spawn, especially if they aren't using beds to set their spawn.

What version are you on? It does check for both player spawn and world spawn, and should do nothing if they are within the spawn chunk. But I had to rewrite some of that code for 1.18 and I may have missed something.

minecraft 1.18 atm7

Should be fixed in 2.0.1. Thanks for the report!


Create ReadTheDocs Website account for MELODIES-MONET

@rschwant Can you create the MELODIES-MONET readthedocs website account.  I think that we can add multiple people to the account once it is created.  Once that is done we can setup the link between GitHub and ReadTheDocs to automatically create docs upon a push or pull request.

@rschwant has done this and it is live (at least the develop branch)


docker repository parameter default

When parsing the repository place holder: your/repository from the soopervisor, it should not look for a repo called your/repository. - the solution can be either fix it to null or filtering it out, there should be a clear error message stating the remote repo can't be found.

Reopening this since we had a discussion earlier and we're considering removing the validation code I added in 69d9d9c  and set the value to null


Envoy forward invalid header http2 request to upstream server

Description:
As I know, the PR #23267/ #23266 intended to keep compatibility on legacy test and system.
However, it still does not follow to standard RFC9113
Moreover, according to https://datatracker.ietf.org/doc/html/rfc7540#section-<IP_ADDRESS>
Intermediaries that process HTTP requests or responses (i.e., any
intermediary not acting as a tunnel) MUST NOT forward a malformed
request or response.
So should envoy reject the invalid/malformed http2 request by default? or at least envoy should have a parameter/flag which allows turn on/off of http2 validation?

I guess the UHV is going to help here.
https://github.com/envoyproxy/envoy/issues/10646
cc @yanavlasov

Hi @soulxu ,
I still see the lines of fixed code in latest main
https://github.com/envoyproxy/envoy/blob/2f8e1a36ed808d760d6f791cdfc8f8cd568a1ad7/source/common/http/http2/codec_impl.cc#L1801C1-L1804C81
Seems @yanavlasov commit did not touch that part.
Regards,
Duong


Update TreeView.md

TreeViewSelectionMode added in the import

Q
A

Bug fix?
[X]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
TreeViewSelectionMode added in the import
Guidance

You can delete this section when you are submitting the pull request.
Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to dev branch.

Thank you @ravichandran-blog  for the PR!
It has been manually merged and will be included in the next release.

Thank you @ravichandran-blog  for the PR!
It has been manually merged and will be included in the next release.


Input buffering framework + Leverage on Android

Forward port of #42220 + #51601 to 4.0.
UPDATE:
Smoke tested on the Windows editor and the Android multitouch view test project. Everything seems fine.
Regarding the real benefits, they should be the same as in the 3.x version, but it's not easy to test.

The classref needs to be synced to fix ordering and a syntax error (missing </member>):
https://github.com/godotengine/godot/runs/3317681823
https://github.com/godotengine/godot/runs/3317681832

Thanks!


All Windows agent VMs should allow login via SSH

It would be nice if all Windows agent VMs had a 'Jenkins' account that was accessible via SSH (using the pub/priv key that the Jenkins controller uses). It would make debugging easier, if there was a consistent interface for debugging regardless of the particular agent type.
This requires a couple of things, on all agent VMs:

Install Chocolatey/OpenSSH
Fetch public-key from Secrets Manager
Deploy public-key as admin authorized_keys (with appropriate settings)

Perhaps fetch/deploy and image resize both should be part of a "standard instance bootup" service? That way, the regular agent script will complete (and connect to Jenkins) as quickly as possible.

Done by https://github.com/falldamagestudio/UE-Jenkins-Images/commit/6007c3a1dade23878402235c47e6a5f8110629ca !


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/942 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit 6e37ce5:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-07-07-08-34-55 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fixed the bug of not receiving incomingCall

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


 I just transferred some files between two computers and it was so simple. Thank you for making it.

On the sending side, the peers connect and authenticate, then I get the error:
Peer connected and authenticated!
Error transferring file read BraveSoftware: is a directory

Then, the sending side exits.
On the receiving side, I receive no error.
Looking for peer camp-match-exhaust-fire...
Peer connected and authenticated!

and it does not close.
It seems the following behavior should be expected:

pcp should either wrap/compress/file-ify the folder before sending (and unwrap it on the receiving side)
pcp should throw an error as soon as it sees the input is a folder, before it connects and authenticates to the peer.

Hi @jakehemmerle ,
awesome that you're checking out the tool :)
Today I created a couple of work items that I want to address for a 1.0 release (list is not yet complete). I just moved the Folder Transmission card up in the priority.
I'm definitely planning to add the ability to transfer directories so I think your point 2. would be the quick fix and your point 1. the proper feature.


updated

Hi @anishmoktan, not sure if this PR was intended. It doesn't seem to have any changes inside.


Add support for deserialization of STL containers of non-default constructable types (fixes #2574).

This PR fixes the issue mentioned in #2574, i.e. the fact that std::array, std::pair, and std::tuple of non-default constructable types can't be deserialized.
A summary of what I did:

Added an second from_json function to the default adl_serializer class. This second from_json returns an object, instead of taking an already existing object by reference. Expression SFINAE is used to disambiguate between the two function, so at most one should exist for any given type with which adl_serializer is constructed.

Similarly I added a second operator() function to detail::from_json_fn. Again, due to SFINAE only one should only be available for any given type. Even if both are available, this should not be an issue, since the new function takes as its second argument an object nlohmann::detail::tag<T>. I.e. if you're manually calling functions with that object you're clearly actively trying to break something.

The tag type mentioned above was added, since some method is required to disambiguate nlohmann::detail::from_json(j) for std::array, std::pair, and std::tuple. I'm using tag dispatching, that seems the simplest (only?) option.

I've added some SFINAE to the existing deserialization code for the mentioned types, using std::is_default_constructible. While this seems OK for std::pair and std::tuple the existing code to deserialize (various types) of arrays had a lot of SFINAE checks, so it might be worthwhile to double check whether the checks on from_json(BasicJsonType && j, tag<std::array<T, N>> t) are sufficient.

All of from_json's const BasicJsonType & arguments for the mentioned types were replaced with BasicJsonType && and std::forward was added. It's most likely unnecessary, but I don't see how it could hurt.

Added extra checks to ensure that the JSON is an array to the std::pair and std::tuple deserialization code.

Any user-written specialization should still get precedence due the way I implemented the changes. I.e. if someone worked around this issue in their private code by specializing adl_serializer for e.g. std::array then that specialization will be used. Since an internal tag type is used for dispatching, there is no risk of this colliding with any existing code out there.
As mentioned I've added support for std::array, std::pair, and std::tuple. As far as I know these are the only STL containers which might not be default constructible due to the type they're templated on. In case I missed some types, it should be easy to add them by implementing T from_json (BasicJsonType && j, tag<T>) in detail/conversions/from_json.hpp.
Looking forward to feedback! This was definitely more involved than what I had in mind. Writing the code to deserialize to those "problematic" objects was actually the easy part :grin:.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Coverage decreased (-0.09%) to 99.909% when pulling 1e825e4f92b84bea316dbd935bfef0e1299b6ccf on AnthonyVH:non_default_constructable_stl_containers into 01f6b2e74185371ee005379b1661be1780fc1344 on nlohmann:develop.

Coverage decreased (-0.09%) to 99.909% when pulling 1e825e4f92b84bea316dbd935bfef0e1299b6ccf on AnthonyVH:non_default_constructable_stl_containers into 01f6b2e74185371ee005379b1661be1780fc1344 on nlohmann:develop.

I would appreciate if @theodelrieu could have a look at this PR as well. They wrote the whole code for the to/from JSON conversions.

I would appreciate if @theodelrieu could have a look at this PR as well. They wrote the whole code for the to/from JSON conversions.

I notice some regressions are failing to compile on older compilers. I'll try and take a look at them tonight. The errors seem to be in a rather unexpected place I must say, e.g.:
/usr/include/c++/4.9/bits/stl_pair.h: In instantiation of ‘constexpr std::pair<_T1, _T2>::pair()
[with _T1 = NonDefaultConstructible; _T2 = NonDefaultConstructible]’:

/usr/include/c++/4.9/type_traits:806:28:   required by substitution of ‘template<class _Tp, class>
static std::true_type std::__do_is_default_constructible_impl::__test(int)
[with _Tp = std::pair<NonDefaultConstructible, NonDefaultConstructible>; <template-parameter-1-2> = <missing>]’

I notice some regressions are failing to compile on older compilers. I'll try and take a look at them tonight. The errors seem to be in a rather unexpected place I must say, e.g.:
/usr/include/c++/4.9/bits/stl_pair.h: In instantiation of ‘constexpr std::pair<_T1, _T2>::pair()
[with _T1 = NonDefaultConstructible; _T2 = NonDefaultConstructible]’:

/usr/include/c++/4.9/type_traits:806:28:   required by substitution of ‘template<class _Tp, class>
static std::true_type std::__do_is_default_constructible_impl::__test(int)
[with _Tp = std::pair<NonDefaultConstructible, NonDefaultConstructible>; <template-parameter-1-2> = <missing>]’

Regarding the regressions which fail to compile: I need to look into it some more, but I did a quick search and it seems to be a language defect/STL implementation issue/whatever you want to call it. Basically std::is_default_constructible was not correctly implemented for std::pair and std::tuple. See LWG 2367.
The LWG report seems to indicate that this was only fixed for C++17, but clearly it got fixed sooner (maybe I'm just misreading the report). Here's some more info: https://stackoverflow.com/a/31438404. It seems it's been fixed in clang 3.6 and in gcc in a commit from 2015-06-30, though it's not clear what the earliest version was which contained this commit.
How do you want to handle this? I think the cleanest solution would be a "custom" is_default_constructible trait which dispatches to the STL one, except for std::pair and std::tuple. That should make the code functional for the problematic compilers as well. I guess the "custom" is_default_constructible could always skip the specializations for std::pair and std::tuple for e.g. C++17 and higher.
An alternative solution would be to keep this type of deserialization broken for older compilers by adding some #ifdefs around the regression and the new deserialization code. Of course in that case the library behavior depends on which compiler is used, which doesn't sound too great.

Regarding the regressions which fail to compile: I need to look into it some more, but I did a quick search and it seems to be a language defect/STL implementation issue/whatever you want to call it. Basically std::is_default_constructible was not correctly implemented for std::pair and std::tuple. See LWG 2367.
The LWG report seems to indicate that this was only fixed for C++17, but clearly it got fixed sooner (maybe I'm just misreading the report). Here's some more info: https://stackoverflow.com/a/31438404. It seems it's been fixed in clang 3.6 and in gcc in a commit from 2015-06-30, though it's not clear what the earliest version was which contained this commit.
How do you want to handle this? I think the cleanest solution would be a "custom" is_default_constructible trait which dispatches to the STL one, except for std::pair and std::tuple. That should make the code functional for the problematic compilers as well. I guess the "custom" is_default_constructible could always skip the specializations for std::pair and std::tuple for e.g. C++17 and higher.
An alternative solution would be to keep this type of deserialization broken for older compilers by adding some #ifdefs around the regression and the new deserialization code. Of course in that case the library behavior depends on which compiler is used, which doesn't sound too great.

@AnthonyVH

I think the cleanest solution would be a "custom" is_default_constructible

Agreed, I've add this kind of issues in other projects, and I've reimplemented those everytime.

@AnthonyVH

I think the cleanest solution would be a "custom" is_default_constructible

Agreed, I've add this kind of issues in other projects, and I've reimplemented those everytime.

By the way,  PR #2558 is going to create quite a few merge conflicts with my changes. Do you have any idea if that PR is going to be merged soon? If so, I can wait for it to be merged and fix the conflicts myself.

By the way,  PR #2558 is going to create quite a few merge conflicts with my changes. Do you have any idea if that PR is going to be merged soon? If so, I can wait for it to be merged and fix the conflicts myself.

Lots of failures on older compilers :disappointed:. Looking into it!

Lots of failures on older compilers :disappointed:. Looking into it!

Progress :smile:! Some tests still don't compile for GCC 4.8 on my PC, I'll try and take a look at that tomorrow evening.

Progress :smile:! Some tests still don't compile for GCC 4.8 on my PC, I'll try and take a look at that tomorrow evening.

Ok, it's going to take some more effort to work around a bunch of compiler bugs on older compilers. I see e.g. older MSVC versions throwing compile errors listed here: https://devblogs.microsoft.com/cppblog/expression-sfinae-improvements-in-vs-2015-update-3/.

Ok, it's going to take some more effort to work around a bunch of compiler bugs on older compilers. I see e.g. older MSVC versions throwing compile errors listed here: https://devblogs.microsoft.com/cppblog/expression-sfinae-improvements-in-vs-2015-update-3/.

I took another quick look and managed to fix the compile error. But first...
I can't make head or tails from the compile errors. In particular, it seems as if the get() function gets called for no reason at all. Here's part of the error message that I can't make sense of. This was generated by clang 3.9 when compiling with multiple headers. gcc 4.9 seems to do the exact same thing, the errors are just a lot less readable :smile:.
.../include/nlohmann/json.hpp:3075:16: note: in instantiation of function template specialization 'nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > >::get_impl<std::initializer_list<nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned
      long, double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > > >, 0>' requested here
        return get_impl<ValueType>(detail::priority_tag<4> {});
               ^
.../include/nlohmann/json.hpp:5584:20: note: in instantiation of function template specialization 'nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > >::insert_iterator<const nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > > &>' requested here
            return insert_iterator(pos, val);

I have no clue how it gets from insert_iterator() to get(). Or where that std::initializer_list suddenly comes from.
Either way, removing constexpr from get() fixes the compile errors. There's a bunch of constexpr functions (e.g. get_ptr(), which might get called by get_impl(), hence why I tagged get() as constexpr as well), but none of the json constructors seem to be constexpr, so I fail to see how any of these functions could ever have been called at compile time. Do you agree that removing constexpr from get() is not going to be an issue for anyone?
AFAIK, it should be legal to put constexpr there, at least if this StackOverflow answer is correct, which cites [dcl.constexpr]/7:

If the instantiated template specialization of a constexpr function template or member function of a class template would fail to satisfy the requirements for a constexpr function, that specialization is still a constexpr function, even though a call to such a function cannot appear in a constant expression.
If no specialization of the template would satisfy the requirements for a constexpr function when considered as a non-template function, the template is ill-formed, no diagnostic required.

That last sentence doesn't seem to apply here, since get_ptr() is constexpr, which gets called by get_impl(priority_tag<4>), which can get called by get() when called with a pointer type template argument.
Since newer compilers don't object to it, I'm guessing the errors here are due to either compiler bugs or changes in the spec. Unfortunately I have no clue what to search for, "conditional constexpr" doesn't seem to do the trick (that just returns a whole bunch of pages on if-constexpr).

I took another quick look and managed to fix the compile error. But first...
I can't make head or tails from the compile errors. In particular, it seems as if the get() function gets called for no reason at all. Here's part of the error message that I can't make sense of. This was generated by clang 3.9 when compiling with multiple headers. gcc 4.9 seems to do the exact same thing, the errors are just a lot less readable :smile:.
.../include/nlohmann/json.hpp:3075:16: note: in instantiation of function template specialization 'nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > >::get_impl<std::initializer_list<nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned
      long, double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > > >, 0>' requested here
        return get_impl<ValueType>(detail::priority_tag<4> {});
               ^
.../include/nlohmann/json.hpp:5584:20: note: in instantiation of function template specialization 'nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > >::insert_iterator<const nlohmann::basic_json<std::map, std::vector, std::__cxx11::basic_string<char>, bool, long, unsigned long,
      double, std::allocator, adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> > > &>' requested here
            return insert_iterator(pos, val);

I have no clue how it gets from insert_iterator() to get(). Or where that std::initializer_list suddenly comes from.
Either way, removing constexpr from get() fixes the compile errors. There's a bunch of constexpr functions (e.g. get_ptr(), which might get called by get_impl(), hence why I tagged get() as constexpr as well), but none of the json constructors seem to be constexpr, so I fail to see how any of these functions could ever have been called at compile time. Do you agree that removing constexpr from get() is not going to be an issue for anyone?
AFAIK, it should be legal to put constexpr there, at least if this StackOverflow answer is correct, which cites [dcl.constexpr]/7:

If the instantiated template specialization of a constexpr function template or member function of a class template would fail to satisfy the requirements for a constexpr function, that specialization is still a constexpr function, even though a call to such a function cannot appear in a constant expression.
If no specialization of the template would satisfy the requirements for a constexpr function when considered as a non-template function, the template is ill-formed, no diagnostic required.

That last sentence doesn't seem to apply here, since get_ptr() is constexpr, which gets called by get_impl(priority_tag<4>), which can get called by get() when called with a pointer type template argument.
Since newer compilers don't object to it, I'm guessing the errors here are due to either compiler bugs or changes in the spec.

This rings a bell, I recall that basic_json types must be SFINAEd out.
Do you compile with JSON_USE_IMPLICIT_CONVERSIONS=False? If not, you should use it to know if the operator T() is the source of this trouble.
I highly recommend looking back at all the discussions in #958 to understand how such types can get there, and why get SFINAE checks must cover everything.

have no clue how it gets from insert_iterator() to get().

This rings a bell, I recall that basic_json types must be SFINAEd out.
Do you compile with JSON_USE_IMPLICIT_CONVERSIONS=False? If not, you should use it to know if the operator T() is the source of this trouble.
I highly recommend looking back at all the discussions in #958 to understand how such types can get there, and why get SFINAE checks must cover everything.

This rings a bell, I recall that basic_json types must be SFINAEd out.

I'm a little confused, because there was already an overload for get() to convert to basic_json. And I made it the 2nd most preferred overload, and it doesn't call from_json()...
Anyway, I'll take a look with implicit conversion disabled and see if that points to anything. Either way, the code seems to be fully functional on all tested compiler now (well, the complete regression hasn't finished yet, but I don't expect any issues given that multiple old compilers already passed the tests).

This rings a bell, I recall that basic_json types must be SFINAEd out.

I'm a little confused, because there was already an overload for get() to convert to basic_json. And I made it the 2nd most preferred overload, and it doesn't call from_json()...
Anyway, I'll take a look with implicit conversion disabled and see if that points to anything. Either way, the code seems to be fully functional on all tested compiler now (well, the complete regression hasn't finished yet, but I don't expect any issues given that multiple old compilers already passed the tests).

How do you want to proceed with this? Merge in the current version (i.e. with get() marked constexpr only for C++14 and up, see my comment earlier)? Or do you prefer this to be working with a constexpr get() in all versions?
I'm not sure if the compile errors I'm seeing with constexpr are due to the code, or due to language/compiler issues. Since the errors don't seem to point at the exact issue (e.g. function A() supposedly calling B() even though there's no mention of B() anywhere in A()), it might take a while before I figure out what's going on.

How do you want to proceed with this? Merge in the current version (i.e. with get() marked constexpr only for C++14 and up, see my comment earlier)? Or do you prefer this to be working with a constexpr get() in all versions?
I'm not sure if the compile errors I'm seeing with constexpr are due to the code, or due to language/compiler issues. Since the errors don't seem to point at the exact issue (e.g. function A() supposedly calling B() even though there's no mention of B() anywhere in A()), it might take a while before I figure out what's going on.

@AnthonyVH
constexpr being broken in many old compilers (and practically unusable pre C++14), I'd go with merging now.

@AnthonyVH
constexpr being broken in many old compilers (and practically unusable pre C++14), I'd go with merging now.

Ok, great! Looking forward to the merge :smile:!

Ok, great! Looking forward to the merge :smile:!

Is there a need to update the README file?

I don't think so. My changes only affect how deserialization happens internally. Since it currently doesn't explicitly mention the lack of support for deserialization of non default-constructable STL "containers", I don't think support for it should be called out?

Is there a need to update the README file?

I don't think so. My changes only affect how deserialization happens internally. Since it currently doesn't explicitly mention the lack of support for deserialization of non default-constructable STL "containers", I don't think support for it should be called out?

Hm, not sure what's going on with AppVeyor. No progress in the last 14 hours, all jobs still in queued state...

Hm, not sure what's going on with AppVeyor. No progress in the last 14 hours, all jobs still in queued state...

Hm, not sure what's going on with AppVeyor. No progress in the last 14 hours, all jobs still in queued state...

AppVeyor is just really slow... I cancelled some redundant jobs. Stay tuned...

Hm, not sure what's going on with AppVeyor. No progress in the last 14 hours, all jobs still in queued state...

AppVeyor is just really slow... I cancelled some redundant jobs. Stay tuned...

Seems like it went through :smile:. Do you want me to change anything else or is this OK to merge?

Seems like it went through :smile:. Do you want me to change anything else or is this OK to merge?

I was wondering if anything is holding back this PR from being merged? I'm a bit worried that new commits to the develop branch might create merge conflicts.

@AnthonyVH  Can you please update to the latest develop branch? I moved the CI away from Travis and fixes a lot of warnings. Then we can finally merge this.

Looks like the merge was successful :+1: . There were a bunch of merge conflicts in include/nlohmann/json.hpp which I was afraid of messing up, but all seems good.
All the conflicts were related to the get() and get_impl() functions which I had modified. As far as I could see, no actual code was modified by the changes in the upstream develop branch, only comments or annotations for e.g. clang-tidy.

@nlohmann Is there anything I can do to help speed this merge along?

@nlohmann Is there anything I can do to help speed this merge along?

I'll check tomorrow. Thanks for your patience!

The code looks fine - any update to the documentation required?

I don't think so, the current documentation doesn't mention this defect, so I don't see why it should be mentioned as explicitly being supported once this is merged.

Thanks a lot!

My pleasure! Great that this could be added to the library.


[Event Hubs] Update Scale Monitor

Summary
The focus of these changes is to update the scale monitor for the Event Hubs Function extension to correct some left over T1 patterns that are no longer applicable.  For example, it is valid to have null checkpoints for a partition, but not possible to have a checkpoint with null offset. Additionally, correcting the assumption that the beginning sequence number for a partition is always 0.  This may not be true if the partition has been previously used and events have aged out, such as for very low volume or DR/fail-over scenarios.

azp run net - eventhub - tests

API change check
API changes are not detected in this pull request.


ur-move-3@12-0

Press Submit! You don't need to edit this text or do anything else.
Be aware that your move can take a minute or two to process.
I see you @max-radin

you absolute legend

you absolute legend

@rossjrw who, me?


Combine tensorrt tool with NNI quantization algorithms.

NNI tensorrt support
Target:
1. Support real quantization speed up for NNI for different hardware(now only support TensorRT)
2. Support mixed precision search specially for mixed quantization(design interface)
3. Combine quantization inference and current simulated quantization interface in NNI, mainly support QAT.

@linbinskn  please update doc accordingly. And prepare unit test, we will setup environment for this unit test.

@linbinskn please update doc accordingly. And prepare unit test, we will setup environment for this unit test.

Have updated doc in #3512 . Unit test is also prepared and will be pushed after environment setup.


Redirect tracing

this branch contains the code (and tests) to enable redirect tracing per handler

this also fixes #14


Reload dialog stack to resume conversation after long-running activity

How can I load the dialog stack like this comment suggests?
https://github.com/microsoft/BotBuilder-Samples/blob/0dab95601c6a97324f5e3011eedf665233ae1d4a/experimental/immediate-accept-adapter/csharp_dotnetcore/Bots/EchoBot.cs#L117
I'm working on Middleware that reprompts a user after they have been silent for 15 seconds. I trigger this background task and then ask the last prompt again if it's been 15 seconds since the last message.
My issue is that if the user responds to the reprompt, their response is taken to the beginning of the conversation stack instead of as the answer to the prompt inside the dialog.
For example,
bot: Welcome, how may I help you?
user: book appointment
bot: What type of appointment?
15 seconds passes
bot on background thread: Sorry, I didn't hear you. What type of appointment?
user: Automobile
bot treats "Automobile" like it was the answer to "Welcome, how may I help you?" instead of the current prompt

Hi @lshade, we have been trying to generate a sample to reproduce this issue, it would be very helpful if you could share your code so we can better analyze the problem with the dialog stack.
Thanks!


Clews 14263 part2 analogous years

almost there!  the notebook is still has a little bit of cruft that's not ideal for a show case.

can you remove the commented out code at the end?
the table of contents is not that useful, and the links don't seem to work.. can you just remove it.
the Report section can be improved.  either make it an actual code  block or remove it... instead of making it a code snippet in text to be pasted elsewhere.
does logging.disable(level=logging.ERROR) override api.client.cfg.DEFAULT_LOG_LEVEL which is used in get_default_logger()? confusing it's better to just remove the local warnings manually

almost there! the notebook is still has a little bit of cruft that's not ideal for a show case.

can you remove the commented out code at the end?

Kept there as plotly produces cooler visualizations, but plotly plots could not be rendered in github. So, commented out if users wanted to download and use the notebook locally. Removed, in this version.

the table of contents is not that useful, and the links don't seem to work.. can you just remove it.

Discussed in slack. The links do not work because of github. They work fine if the notebook is downloaded locally or nbviewer is used. However, it makes the notebook longer. So, removed it.

the Report section can be improved.  either make it an actual code  block or remove it... instead of making it a code snippet in text to be pasted elsewhere.

Removed it.

does logging.disable(level=logging.ERROR) override api.client.cfg.DEFAULT_LOG_LEVEL which is used in get_default_logger()? confusing it's better to just remove the local warnings manually

Discussed in slack. I understand the need for a more concise notebook; hence, removed it. However, manually removing is a set back for reproducibility of the notebook.

almost there! the notebook is still has a little bit of cruft that's not ideal for a show case.

can you remove the commented out code at the end?

Kept there as plotly produces cooler visualizations, but plotly plots could not be rendered in github. So, commented out if users wanted to download and use the notebook locally. Removed, in this version.

the table of contents is not that useful, and the links don't seem to work.. can you just remove it.

Discussed in slack. The links do not work because of github. They work fine if the notebook is downloaded locally or nbviewer is used. However, it makes the notebook longer. So, removed it.

the Report section can be improved.  either make it an actual code  block or remove it... instead of making it a code snippet in text to be pasted elsewhere.

Removed it.

does logging.disable(level=logging.ERROR) override api.client.cfg.DEFAULT_LOG_LEVEL which is used in get_default_logger()? confusing it's better to just remove the local warnings manually

Discussed in slack. I understand the need for a more concise notebook; hence, removed it. However, manually removing is a set back for reproducibility of the notebook.

the user should be able to choose different log verbosity levels  when running it.  forcing the log level in code (with logging.disable) is bad practice because it would suppress other third party  warnings that the user may actually encounter (that may or may not occur in your case), even if the user wants to see warnings.
more importantly, please don't forget to follow-up to address the underlying causes of the warnings. in the meantime, it's not helpful to have them pollute the notebook


fix(core): 18465 Tune redirection on Atlas app

https://kontur.fibery.io/Tasks/Task/Tune-redirection-on-Atlas-app-18465

Routing overhaul

Summary by CodeRabbit

New Features

Enhanced routing setup with new components and improved logic for better navigation experience in the application.
Added new environment variables for testing and Slack bot integration.
Introduced new localization string for error handling related to an incorrect MCDA version.
Added support for uploading test reports to surge.sh and workflow artifacts.

Bug Fixes

Improved error handling in MCDA layer parameters to safely manage potential null or undefined values.

Refactor

Updated dependency versions for better compatibility and security.
Refined MCDA configuration handling by focusing on the name property instead of id, ensuring consistent and clear configurations.

Chores

Scheduled automated e2e tests every two hours on weekdays.
Added detailed Slack reporter configurations for test notifications.
Removed unused exports of Column and Row components from Layout.

Tests

Added new environment variables and configurations for e2e tests, including Keycloak admin credentials and Slack bot token.

I tried out the PR, and there's this new flickering of the Sidebar:
https://github.com/konturio/disaster-ninja-fe/assets/9570735/6786cb52-1b6a-4a8e-8905-b3e228774134

Would be nice to rename the PR to include the most important changes it brings (react-router dom update, routes refactoring, changes in redirects) so it's obvious from the squashed commit name

Approving, but let's add smth like "React Router updated to v6" to PR name, because it's good to keep this info visible in commit history


Output of any python code in VSC isn't showing properly. It doesn't show the letters of all the words in Output.

Whenever I run a code in VSC, it doesn't show proper output. As you can see in the screenshots, it misses some letters randomly of any word. Even if I write print('Hello World'), it'll show 'He lo W rld'. I thought it might be an issue with my OS (Linux Mint XFCE), so I installed Linux Mint Mate LTS. Issue is still there. Code runs fine in Python IDLE. Please let me know if I missed to mention anything.
VS Code version - 1.52.1

I tried VSCode Insider 1.53.0 and so far this still isn't there. Probably this is an issue with VS Code stable 1.52.1

I tried VSCode Insider 1.53.0 and so far this still isn't there. Probably this is an issue with VS Code stable 1.52.1

/extPython

/extPython

Please open this issue on the Python extension. Thank you!

Please open this issue on the Python extension. Thank you!