qBittorrent login failed with code 404

Hi,
Got this error when starting cross-seed:
info: Validating your configuration...
error: qBittorrent login failed with code 404

Running qBittorrent 4.5.2 and Cross-seed 4.4.1 on Unraid 6.11.5
According to the qBittorent API manual error code 404: "Torrent hash was not found"

Qbittorent is working also is qbitmanage

Well a single line error saying nothing is there doesn't help....you've provided no information at all.

Are you on some very old cross seed version that's no longer supported?
are you missing a base url?
can you curl qbit from within the cross seed container?
Is your ip/host and port accurate?

Well a single line error saying nothing is there doesn't help....you've provided no information at all.
* are you missing a base url?

No: qbittorrent.mydomain.com

* can you curl qbit from within the cross seed container?

Yes working fine

* Is your ip/host and port accurate?

Static ip and host and port ofcourse

* your understanding of qbit's 404 error is wrong and the login api route has nothing to do with getting torrents as you said

I understand, anything alse could be the cause?

I did some more testing and it seems the cross-seed container is not able to contact qbittorrent en the torznab prowlarr links, tried custom network, bridge and my docker VLAN, all other containers like qbit manage/sonarr/radarr/prowlarr etc can reacg qbittorent without a orivkel

sounds like basic docker dns issues or docker network configuration issues; nothing specific to cross-seed

getaddrinfo EAI_AGAIN is not a 404 so you're experiencing at least 2 distinct issues.

https://stackoverflow.com/questions/40182121/whats-the-cause-of-the-error-getaddrinfo-eai-again

Hi,
DNS problems should be solved now, all is reachable.
The torznab links are also woking when setting "action" to save I see cross-seed searching on all my indexers.
However connection to qbittorrent still gives me error 404... in the container I can do a ping to it and ir responds.
Can it be a setting in qBittorrent or something I can try?
Now running in "save" mode instead of "inject" also working but rather use it with inject
Thx


[Completion] Addd constructors from the completion cache back

31dee1ce1cb2ec339b39245e5f1601881f8e120c refactored the completion filter, accidentally dropping initializers when found from the cache. Add these back in and also modify the existing test to load from the cache as well.
Resolves rdar://107807707.

@swift-ci please test


Introducing ZStd compression codec plugin

Description
Introduces ZStd Compression Codecs as a plugin
Related Issues
Resolves #9422
Tests Covered:

[x] Long running tests to verify for any corruption or memory leaks
[x] Backward compatibility test to ensure that the segments that are created in OS 2.9, are readable in OS 2.10 with ZStd as a plugin.
[x] Reindexing between different compression codecs
[x] Create a snapshot, delete an index, restore from snapshot
[x] Split/Shrink api since they modify segments to some extent
[x] Index Blocks
[x] Upgrade from the minor version
[x] Force merge of segments with multiple compression mode into zstd
[x] Close an index, update the setting, test the indexing and search flows, snapshots, etc i.e. with multiple compression

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Looks like flaky tests have failed

@sarthakaggarwal97 a few minor things but look pretty good, thank you!

Thanks @sarthakaggarwal97 LGTM, could you confirm that the index created with ZSTD codec in 2.9.0 could be successfully read in 2.10.0 with custom-codec plugin installed? Just want to be sure we verified that

@sarthakaggarwal97 conflicts sadly, @nknize @andrross mind please taking a look? thank you

@reta @andrross build is green, please check this out.

@reta @andrross build is green, please check this out.

Thanks @sarthakaggarwal97 , still LGTM to me :)

@reta can we merge, and make it in time with for 2.10 release?

@reta can we merge, and make it in time with for 2.10 release?

We need @andrross signoff

:100: ready :-) thanks @andrross !

@sarthakaggarwal97 could you please take 2.x backport ? thank you


Error: subdir "modules/kubernetes-addons/helm-addon" not found

I use v4.28.0.
I ran terraform init today.
It gave an error.
Please help me
Message: Error: subdir "modules/kubernetes-addons/helm-addon" not found

you need to use version 4.32.1 to stay on v4.x

@bryantbiggs could this issue be pinned and could this message be documented in the README.md ? A lot of people currently use the blue prints for the helm addons and people may not be ready to migrate just yet so this error may catch people off guard

@nitrocode , I face the same issue and updated helm provider version and issue resolve for me.
helm = {
version = ">= 2.10.1"
source  = "hashicorp/helm"
}


addAttributesToSVGElement does not do anything

I am trying plugin { addAttributesToSVGElement: {attribute: "mySvg"}} but it does not seem to work.

This task just passes your options to SVGO. Better to ask there: https://github.com/svg/svgo/issues


small changes, should hopefully have better spk14 test

Coverage remained the same at 100.0% when pulling 93a742b0bb09710411999d27ddb16cba92206d70 on small_improvements into ea0875be493b392711af83cebdb6b5d363e40344 on master.

Coverage remained the same at 100.0% when pulling d1928bd1ed39d2bd97a0c31be146a2b2e89e59ef on small_improvements into ea0875be493b392711af83cebdb6b5d363e40344 on master.

Coverage remained the same at 100.0% when pulling d1928bd1ed39d2bd97a0c31be146a2b2e89e59ef on small_improvements into ea0875be493b392711af83cebdb6b5d363e40344 on master.

I'm not always right, but it does often work out that way (my wife loves it when I say that;-).
Just kidding; it's really nice to see it come together like this.
;-)


nextcloud-reloaded branch: ACME.sh fails during provisioning when host is IPv6 only

Testing nextcloud-reloaded on Ubuntu 20.04.1
Where host is dev.example.com and only has an AAAA dns entry pointing to 2001:db83:1234:5678::1
It will fail at the acme.sh step

TASK [tls-certificate : get certificates] ***************************************************************************************************************************************************************************************************
Saturday 19 September 2020  06:44:07 +0200 (0:00:00.029)       0:00:27.052 ****
fatal: [localhost]: FAILED! => changed=true
  cmd:
  - ./acme.sh
  - --issue
  - --home
  - /opt/acme/sh
  - --config-home
  - /opt/acme/sh/conf
  - --domain
  - dev.example.com
  - --keylength
  - ec-256
  - --cert-home
  - /opt/acme/sh/certs
  - --cert-file
  - /etc/ssl/private/dev.example.com/dev.example.com.crt
  - --key-file
  - /etc/ssl/private/dev.example.com/dev.example.com.key
  - --ca-file
  - /etc/ssl/private/dev.example.com/ca.crt
  - --fullchain-file
  - /etc/ssl/private/dev.example.com/fullchain.crt
  - --webroot
  - /var/www/letsencrypt
  - --reloadcmd
  - systemctl restart nginx
  delta: '0:00:07.122275'
  end: '2020-09-19 06:44:14.750375'
  failed_when_result: true
  msg: non-zero return code
  rc: 1
  start: '2020-09-19 06:44:07.628100'
  stderr: |-
    [Sat 19 Sep 2020 06:44:14 AM CEST] dev.example.com:Verify error:Fetching http://dev.example.com/.well-known/acme-challenge/RrbVs5H8YMAxm5bRI9sCisDW8rl6Giv5LMYPqflT91k: Connection refused
    [Sat 19 Sep 2020 06:44:14 AM CEST] Please add '--debug' or '--log' to check more details.
    [Sat 19 Sep 2020 06:44:14 AM CEST] See: https://github.com/acmesh-official/acme.sh/wiki/How-to-debug-acme.sh
  stderr_lines: <omitted>
  stdout: |-
    [Sat 19 Sep 2020 06:44:08 AM CEST] Using CA: https://acme-v02.api.letsencrypt.org/directory
    [Sat 19 Sep 2020 06:44:08 AM CEST] Single domain='dev.example.com'
    [Sat 19 Sep 2020 06:44:08 AM CEST] Getting domain auth token for each domain
    [Sat 19 Sep 2020 06:44:10 AM CEST] Getting webroot for domain='dev.example.com'
    [Sat 19 Sep 2020 06:44:10 AM CEST] Verifying: dev.example.com
  stdout_lines: <omitted>

If there is any interest in making IPv6 work I will take a look and see what ufw / nginx bits could be modified.

you may try to put proto: ipv6 in this line
https://github.com/ReinerNippes/nextcloud/blob/2b3db2bebe0f4eb385c2f84d625600211575363d/roles/webserver/tasks/firewall_config.yml#L10
if you want to disable ufw in the playbook, comment out the following tasks:
https://github.com/ReinerNippes/nextcloud/blob/2b3db2bebe0f4eb385c2f84d625600211575363d/roles/os/tasks/main.yml#L8
https://github.com/ReinerNippes/nextcloud/blob/2b3db2bebe0f4eb385c2f84d625600211575363d/roles/webserver/tasks/main.yml#L29
maybe you have to grep for ufw: to find all tasks.
and you may check if this jinja templating is working on your machine:
https://github.com/ReinerNippes/nextcloud/blob/2b3db2bebe0f4eb385c2f84d625600211575363d/roles/webserver/templates/nginx/nextcloud.conf.j2#L3
it should detect an ipv6 address and add this line (plus the one for ssl in line 19)

Thank you!
The playbook is pretty solid. Thanks for maintaining.


Word break navigation needs option for space skipping

Replicate

Paste the following pangram into the editor: Sphinx of black quartz, judge my vow.
Position the caret anywhere along the pangram.
Press Home to reposition the caret to the beginning of the line.
Press Ctrl+Right Arrow to move to the end of the current word.

Expected Results
Caret moves to the end of the word Sphinx, before the word boundary:
Sphinx| of black...
Actual Results
Caret moves to the start of the next word, of, after the word boundary:
Sphinx |of black...
Additional Details
This is inconsistent with most text editors. When using Ctrl+Left/Right Arrow the expected behaviour can be discovered by using a regular input field and moving around the words with Ctrl and the arrow keys. Generally speaking, when Ctrl+Shift are pressed together for jumping word boundaries, typing an extra space to separate the replaced text from the previous/next word should not be required.

Which version are you using?

This was fixed in 2c3bd1b6feb0d435cb5715862a71a241cda10f32 and this issue is a duplicate of #200. Unfortunately, a release does not yet exists containing the fix.

compile group: 'org.fxmisc.richtext', name: 'richtextfx', version: '0.7-M2'


Rewrite gleam-mode

This PR is a complete rewrite of gleam-mode from scratch, under the ~Apache-2.0 License~ GPLv3 with copyright to @lpil (should he ever want to relicense it).
It is built upon tree-sitter-gleam, and has these features:

Syntax highlighting
Indentation (kinda, see next section)
Imenu (find item—e.g. type def, functinon def—within file)
Formatting (by way of the gleam-format command which runs gleam format)
Compilation error recognition and jump-to-line

It also has the following limitations:

Indentation is best described as "meh", largely in part due to the tree-sitter-indent library being immature.
Requires a recursive git clone which may (?) prohibit it from being included in Melpa as-is. Since it relies on tree-sitter-gleam, it requires a compiled library version of that to be present somewhere. The current methodology is to incorporate tree-sitter-gleam as a git submodule, which gleam-mode will compile with cc if it does not find a compiled library asset. Another project with similar functionality, tree-sitter-langs, has a repository of compiled library assets which the mode will download and extract if they are missing. The downside of using this approach for gleam-mode is that someone would have to maintain a repository of compiled tree-sitter-gleam library assets for every platform that we'd want to support, which likely—at minimum—includes x86 Linux, x86 macOS, aarch64 macOS, x86 FreeBSD, and x86 Windows. I may be able to automate the building of all those library assets using GitHub Actions, nascent work for which has begun.

@lpil Sorry for the delay! I have relicensed the project as Apache 2.0 or, at the user's option, GPL v3.


Re-enable singleton-jdk for ubi8/openjdk-11

Jiri A noticed that java-1.8.0-openjdk-headless had snuck back into the ubi8/openjdk-11 RC build, and so this module is sadly still necessary for now.

I'm going to just merge this immediately to get this out fast. On my head be it!


Investigate why "go-containerregistry" package is overridden

What would you like to be added:
Ref: https://github.com/pipe-cd/pipe/pull/1344#issuecomment-755075915
The downloaded source inside bazel-pipe/external/com_github_google_go_containerregistry is not containing some functions. Maybe gazelle downloaded the wrong version.
As a workaround, we moved the go_repository part from repositories.bzl to WORKSPACE. We have to stop doing that ASAP.
Why is this needed:

This should be opened by an appropriate TODO comment.
/close

This should be opened by an appropriate TODO comment.
/close


chore(deps): update common-dev-assets digest to 4db24c1

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
5d5415d -> 4db24c1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.11.0 :tada:
The release is available on:

GitHub release
v1.11.0

Your semantic-release bot :package::rocket:


question: looking for a way to load a message of unknown type

Hello, I was wondering if there is any way to load a serialized protobuf message (string or bytes) without knowing its type beforehand. Some sort of mapping from typeName to the actual generated TS type?
Thank you!

Hey @nohehf, the protobuf binary format is not fully self-describing. To deserialize a message, you need to know it's type (i.e. the field numbers and field types).
You don't necessarily need generated code though. For example, you could use a registry to create message types at runtime from a set of descriptors, and use the dynamic message type to parse.

Some sort of mapping from typeName to the actual generated TS type?

Sounds like you may want to take a look at Any. It's a protobuf message that holds an arbitrary protobuf message (serialized), plus a type name. See here for an example with protobuf-es.

Oh, thank you, I didn't know about the registry, it definitely sounds like a solution, I'll look into it!
Maybe Any + reflection could be a solution too?
Thank you for the insight


fix(TCOMP-414): fix wrong dataset reference key in JDBCOutputProperties

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
See https://jira.talendforge.org/browse/TCOMP-414
What is the new behavior?
The reference key has been fixed to be consistent with the Dataset "@definitionName".
Does this PR introduce a breaking change?

[ ] Yes
[X] No

Pull request test result: success :star:


female->XX, male->XY

Small change to make this script compatible with the seqr sex_check.py script

I forgot to turn my autoformat on save off for this so it ran and dismissed the review, sorry @ch-kr !


Option to prune spent UTXO's?

Is there a way you guys can add a way to prune spent UTXO's? (Obviously after the 2160 required blocks to deal with rollbacks). I don't have need for spent UTXO data, so it would be great because the database will be much smaller and queries will be quicker, etc :)

It could be done I guess. You could write a new "Prune" task that depends on the input & output tasks and instead of writing to the database, removes from the database
Of course adding such a task means you wouldn't be able to use any other task hat depends on this data being present, but I sounds like you're okay with that for your use-case


something like this

apparently you can't issue oidc tokens for pull requests from forks. back to the drawing board.


set build to use static glibc

PR Summary
For gnu builds, set the rust c flag to use static linking
PR Context
Fix https://github.com/PowerShell/DSC/issues/583

The rust flags didn't produce a statically linked glibc, so abandoning this


Fix(@schematics/angular): support Fetch as Google（Google bot)

Fetch as Google (Google's bot checker) use ES5. So ES5 require polyfills (Fetch as Google need core-js/es6/array only ).
I think that Angular needs a response to Google in order to become a PWA.
thanks.

@alexeagle are you familiar with this situation?

FYI: Googlebot uses a renderer following the similar spec to Chrome 41.
https://developers.google.com/search/docs/guides/rendering
ES6 support is almost dropped.
https://caniuse.com/#compare=chrome+41
I think that current polyfills set is no bad, but it should be mentioned that crawlers possibly requires ES5 support.
I hope comments for the crawlers support will be placed in polyfill.ts as well as IE support.

Hi @rdlabo ,
This PR looks good, and I'd like to put it in. I agree that support for google bot is important. However, I feel this should be left to the user and not be on by default. Could you keep your comment but comment out the import statement?
Also, please rebase on top of master. Things have changed quite a bit since this PR was made.
Thanks!

@clydin will make a minor edit and push to this branch to fix it up

@hansl Thanks for review. I made and rebased!


Weekend days in different countries

Bangladesh's weekend days are Friday and Saturday, and for other countries listed here, the weekend days can be different:
Wikipedia.

I did some quick checks and they're already accounted for Malaysia's and Saudi Arabia's implementation.
While this likely won't affect Bangladesh in practice (since the current implementation has no in-lieu observances), adding them would be good as you said.


WIP/devel: lab with replay plugin

Consuming plugin https://github.com/redhat-openshift-ecosystem/provider-certification-plugins/pull/56

Replay plugin introduced[1] in the main workflow taking advantage of the openshift-tests plugin refact[2].
[1] https://github.com/redhat-openshift-ecosystem/provider-certification-tool/pull/104
[2] https://github.com/redhat-openshift-ecosystem/provider-certification-plugins/pull/57

Replay plugin introduced[1] in the main workflow taking advantage of the openshift-tests plugin refact[2].
[1] https://github.com/redhat-openshift-ecosystem/provider-certification-tool/pull/104
[2] https://github.com/redhat-openshift-ecosystem/provider-certification-plugins/pull/57


Feature RPC message protection

This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Summary
Added encryption required flag to policy table.
Added logic for processing RPC according to the proposal.
The permission change notification has been expanded.
CLA

[x] I have signed the CLA

@BSolonenko please process comments and we're good to go

@mked-luxoft Please accept or discard my notes.


Issue with proxy forwarder

Problem
I deployed the website on a container, and experienced a problem when clicking on the pagination.
I have been redirected to http://localhost:3000/?query=&sort=yotas_desc&page=1, who is not normal.
Expected behavior
Be redirected to https://potential-meme-xxxxxxx-3000.app.github.dev/?query=&sort=yotas_desc&page=1
Test environment
GitHub codespace.
Possible solution

remove full absolute URL build in src/views/partials/pagination.hbs.

Hi @pythonbrad,
In response to your issue, I’ve added a new helper function called removeDomain that parses and cleans URLs by removing the domain part. This function is now used in the constructUrl helper to ensure that URLs are properly formatted. Additionally, I’ve updated the pagination.hbs template to utilize this new helper, which should resolve the issue of incorrect redirections.
You can review the changes in the pull request linked above (#37). With these updates, you should now be redirected to the correct URL in the pagination component. Please let me know if this resolves the issue or if any further adjustments are needed.
Best regards,


Trying to retrieve a token using an invalid metascope, should reject the promise.

In Launch, we have a tool that helps our developers to upload extensions to our platform. In order to be able to upload an extension, we ask them to create integrations where they can select either the admin scope (ent_reactor_admin_sdk) or the extension developer scope (ent_reactor_extension_developer_sdk). Our tool tries to get an access token using one of these scopes. If it gets the invalid_scope error back, it tries to get a token using the other scope.
Using this code
auth(config)
  .then(token => console.log(token))
  .catch(error => console.log(error));

we were receiving an object like { error_description: 'The metascopes in the JWT are not a subset of the metascopes in the binding.', error: 'invalid_scope' } inside the promise then. I think it makes more sense to receive that inside the promise catch.
If you agree with this, then probably when the fetch command receives an HTTP code that is not inside the 200-299 range, the promise returned by the jwt-auth package should get rejected.
If you decide to do this change, one downside is that may break current implementations.

@dompuiu can you try out the fix in the issue6 branch? I agree with you on the behaviour and I'll bump the package to 0.1.0. I'm not too worried about a breaking change at this point as I can reach out to others using the package.

@macdonst I've tested the branch in my project. Looks good to me!

@dompuiu thanks for the sanity check. Merged into master and released a 0.1.0 version of the package.

@dompuiu how did you resolve this? Im still getting this issue for using the photoshop api

@kaizenjegan This PR is just changing the way jwt-auth library is rejecting the auth promise.  If you are receiving the invalid_scope error then maybe your integration is not having the correct scopes configured.

hmm. ok will have to raise a ticket to adobe. Im just plugging in the scope value value that I see in the documentation https://www.adobe.io/authentication/auth-methods.html#!AdobeDocs/adobeio-auth/master/JWT/Scopes.md
Thank you for the prompt response!

Ugh, trying to use these Adobe APIs for the first time ... and I too am getting that same invalid_scope error claiming "The metascopes in the JWT are not a subset of the metascopes in the binding".  I too have opened a "case" with Adobe Support for this - but if anyone knows a fix for this, please provide details.


GCC can't find MPC includes

As of build 5 the following error is obtained :
checking for the correct version of gmp.h... yes
checking for the correct version of mpfr.h... yes
checking for the correct version of mpc.h... no
configure: error: Building GCC requires GMP 4.2+, MPFR 2.4.0+ and MPC 0.8.0+.

These are indeed available since they are added with modules, but mpc isn't in /apprepo

solved in mpc repo


User Interface Improvements

This should encompass improvements to the interaction between the user and the bot for existing features.

@dialectrical Are you interested in taking any of these? They could be good first issues, just refactoring menus.

@danhendrix I can give it a go, sure.


Add dev docs on how to bump packages

Signed-off-by: Dimitris Karakasilis<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Codecov Report

Merging #842 (3f97fe9) into master (9e7a1ad) will increase coverage by 2.20%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   19.29%   21.49%   +2.20%
==========================================
  Files          18       21       +3
  Lines        1467     1521      +54
==========================================
+ Hits          283      327      +44
- Misses       1135     1142       +7
- Partials       49       52       +3

Impacted Files
Coverage Δ

pkg/config/schemas/p2p_schema.go
100.00% <0.00%> (ø)

pkg/config/schemas/root_schema.go
78.26% <0.00%> (ø)

pkg/config/schemas/install_schema.go
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Vector bit reversal

In the context of #17 (Vector extension: Carry-less Multiply) - How best to handle needing to reverse bits-in-bytes to get the input in the correct form?

In Markku's analysis for the scalar implementation of GCM, he used the Bitmanip "grev" instruction to reverse the bits in every byte of the input. I can't see an existing instruction in the V-spec which does this efficiently. Adding an instruction like
vbrev.vv vrt    // Bit reverse, destructive.

Which reverses the bits in every scalar element based on SEW, and requiring support for SEW=8 for the crypto extension seems reasonable?

There are other (non-obvious) ways to do bit reversal quickly which look amenable to vectorising, which we can fall back on.

The best alternative method I have seen so far, adapted for RVV from one of the methods in the link in the main post (this one) , uses masking and shifting and takes 15 base vector extension instructions to reverse the order of the 8 bits in all the bytes of all the elements in a vector (not counting loading and other set-up overhead)

Andy's proposal for vector grev can be found here. These will be transcribed into the draft spec.


Unable to use firebase-admin + adapter-node (cannot be made external)

Describe the bug
Trying to use adapter-node with firebase-admin has been broken since the switch from esbuild to rollup (pinning to v92 of adapter-node works).
With the pinned version, the firebase-admin imports are retained in the server chunks, e.g.
import { initializeApp } from "firebase-admin/app";

But with any version after that, the firebase package is bundled in to the server code (but incorrectly, which causes an error).
The symptom is the error below, but the issue is really that firebase-admin is being bundled in no matter what.
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'string_decoder' imported from /Users/simon/dev/thread-bare/experiment/build/server/chunks/2-2a51a21d.js
    at new NodeError (node:internal/errors:393:5)
    at packageResolve (node:internal/modules/esm/resolve:860:9)
    at moduleResolve (node:internal/modules/esm/resolve:909:20)
    at defaultResolve (node:internal/modules/esm/resolve:1124:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:837:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
    at link (node:internal/modules/esm/module_job:75:36)

Reproduction
https://github.com/CaptainCodeman/svelte-kit-firebase-admin-external
Logs
No response
System Info
System:
    OS: macOS 12.6
    CPU: (6) x64 Intel(R) Core(TM) i5-8500B CPU @ 3.00GHz
    Memory: 1.68 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.10.0 - ~/Library/pnpm/node
    npm: 8.19.2 - ~/Library/pnpm/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 106.0.5249.91
    Chrome Canary: 108.0.5351.0
    Firefox: 105.0.1
    Safari: 16.0
    Safari Technology Preview: 16.4
  npmPackages:
    @sveltejs/adapter-node: next => 1.0.0-next.96
    @sveltejs/kit: next => 1.0.0-next.512
    svelte: ^3.44.0 => 3.51.0
    vite: ^3.1.0 => 3.1.7

Severity
blocking an upgrade
Additional Information
I tried to "server module" all the things, and also set thing to external in vite.config.js, but nothing seems to prevent it being bundled in. I've also tried changing it to be a devDependency (which I think would be incorrect, but was clutching at straws).

I can confirm reproduction of this bug. This is a severe bug that makes deployment of adapter-node apps that use firebase-admin impossible. I also have had no luck in my search for a workaround.

Same issue here as linked above. It bundles things that shouldn't be bundled. And they were not bundled in previous versions of adapter node.

So it all happened on adapter-node 93 when it was switched from esbuild to rollup. However even going back to 92, gives me Error: Dynamic require of "http" is not supported so it's all broken now and I can't deploy with adapter-node.

Also looks like, in my case it's because monorepo structure. So project I am building doesn't have any devDependancies or dependancies (dependancies only have workspace dependency).
So it just bundles everything. If I add module in that project to dependancies it does not get bundled.
However it's a regress, as that was working fine before going to rollup.js.
So maybe there is better way to resolve dependencies, and account for mono repo structure ?

This is not fixed in my case. When there is dependancy in root package.json in monorepo in non dev dependancy, it's still being bundled. I have to add it to package/app  package.json into dependancies for it to be not bundled

I'd argue this is the right thing to do anyway in my opinion - each package in a monorepo should explicitly list its dependencies, even if that means some packages list the same dependencies over and over.


st2 pods stuck in loop

I'm deploying a stackstorm/stackstorm-ha cluster with helm and since yesterday some of the pods seem to be stuck in a loop.
"Deployment does not have minimum availability". This was previously working without any issues.
We don't have much info on the logs:
Logs: st2actionrunner
2019-03-21 08:40:38,795 DEBUG [-] Using Python: 2.7.12 (/opt/stackstorm/st2/bin/python)
2019-03-21 08:40:38,796 DEBUG [-] Using config files: /etc/st2/st2.conf,/etc/st2/st2.docker.conf,/etc/st2/st2.user.conf
2019-03-21 08:40:38,796 DEBUG [-] Using logging config: /etc/st2/logging.actionrunner.conf
2019-03-21 08:40:38,802 INFO [-] Connecting to database "st2" @ "aspiring-ferret-mongodb-ha:27017" as user "None".
2019-03-21 08:40:38,830 INFO [-] Successfully connected to database "st2" @ "aspiring-ferret-mongodb-ha:27017" as user "None".
2019-03-21 08:40:39,972 ERROR [-] (PID=1) Worker quit due to exception.
Traceback (most recent call last):
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/actionrunner.py", line 80, in main
_setup()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/actionrunner.py", line 41, in _setup
register_signal_handlers=True, service_registry=True, capabilities=capabilities)
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 187, in setup
start_heart=True)
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 224, in register_service_in_service_registry
coordinator.create_group(group_id).get()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/tooz/coordination.py", line 476, in create_group
raise tooz.NotImplemented
NotImplemented
=========================
Logs: st2workflowengine
2019-03-21 08:45:45,742 DEBUG [-] Using Python: 2.7.12 (/opt/stackstorm/st2/bin/python)
2019-03-21 08:45:45,742 DEBUG [-] Using config files: /etc/st2/st2.conf,/etc/st2/st2.docker.conf,/etc/st2/st2.user.conf
2019-03-21 08:45:45,743 DEBUG [-] Using logging config: /etc/st2/logging.workflowengine.conf
2019-03-21 08:45:45,748 INFO [-] Connecting to database "st2" @ "aspiring-ferret-mongodb-ha:27017" as user "None".
2019-03-21 08:45:45,774 INFO [-] Successfully connected to database "st2" @ "aspiring-ferret-mongodb-ha:27017" as user "None".
2019-03-21 08:45:46,633 ERROR [-] Traceback (most recent call last):
2019-03-21 08:45:46,633 ERROR [-] File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/workflow_engine.py", line 94, in main
2019-03-21 08:45:46,633 ERROR [-] setup()
2019-03-21 08:45:46,633 ERROR [-] File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/workflow_engine.py", line 65, in setup
2019-03-21 08:45:46,633 ERROR [-] capabilities=capabilities
2019-03-21 08:45:46,633 ERROR [-] File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 187, in setup
2019-03-21 08:45:46,633 ERROR [-] start_heart=True)
2019-03-21 08:45:46,633 ERROR [-] File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 224, in register_service_in_service_registry
2019-03-21 08:45:46,634 ERROR [-] coordinator.create_group(group_id).get()
2019-03-21 08:45:46,634 ERROR [-] File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/tooz/coordination.py", line 476, in create_group
2019-03-21 08:45:46,634 ERROR [-] raise tooz.NotImplemented
2019-03-21 08:45:46,634 ERROR [-] NotImplemented
2019-03-21 08:45:46,634 ERROR [-] (PID=1) Workflow engine quit due to exception.
Traceback (most recent call last):
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/workflow_engine.py", line 94, in main
setup()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/workflow_engine.py", line 65, in setup
capabilities=capabilities
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 187, in setup
start_heart=True)
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 224, in register_service_in_service_registry
coordinator.create_group(group_id).get()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/tooz/coordination.py", line 476, in create_group
raise tooz.NotImplemented
NotImplemented
=========================
This was installed with command: helm install stackstorm/stackstorm-ha
I've used the same layout to deploy and test few days ago. There's no resources issue.
root@aspiring-ferret-st2client-849f88776f-p4ntd:/opt/stackstorm# st2 --version
st2 3.0dev (0b95862), on Python 2.7.12

Let's continue here.
@nagrigore Did you figure it out?
It looks like it's related to recent service registry changes I worked on. Which coordination backed do you have configured in st2.conf?

Alright, I found there issue. Workaround is here - https://github.com/StackStorm/st2/pull/4607
Once that PR is merged and new v3.0.0dev packages built, redeploying stackstorm-ha should work.
Thanks again for reporting this issue.

Thanks @Kami for a quick fix.
We'll check again in a few days when both packages + docker images are available and close the issue.

Hello guys,
We're still can not deploy stackstorm-ha from helm.
helm install --name stackstormtest  stackstorm/stackstorm-ha
Here is the log from 1 pod
019-03-21 20:12:48,348 ERROR [-] (PID=1) Worker quit due to exception.
Traceback (most recent call last):
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/actionrunner.py", line 80, in main
_setup()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/cmd/actionrunner.py", line 41, in _setup
register_signal_handlers=True, service_registry=True, capabilities=capabilities)
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 187, in setup
start_heart=True)
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/service_setup.py", line 224, in register_service_in_service_registry
coordinator.create_group(group_id).get()
File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/tooz/coordination.py", line 476, in create_group
raise tooz.NotImplemented
NotImplemented
testcluster-st2actionrunner-77489f94c8-btbt4       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2actionrunner-77489f94c8-rj2v5       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2actionrunner-77489f94c8-tnklq       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2actionrunner-77489f94c8-tr242       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2actionrunner-77489f94c8-vr6r2       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2api-646fc6bfd7-hjjh5                0/1     CrashLoopBackOff   5          4m34s
testcluster-st2api-646fc6bfd7-z2h5w                0/1     CrashLoopBackOff   5          4m34s
testcluster-st2auth-5855d9d5bd-2ktlx               0/1     CrashLoopBackOff   5          4m34s
testcluster-st2auth-5855d9d5bd-sn4mf               0/1     CrashLoopBackOff   5          4m34s
testcluster-st2client-5c55669f6-k7v6j              1/1     Running            0          4m34s
testcluster-st2garbagecollector-8674bc649c-ns8hp   0/1     CrashLoopBackOff   5          4m33s
testcluster-st2notifier-c5b7d59b9-kg8l4            0/1     CrashLoopBackOff   5          4m34s
testcluster-st2notifier-c5b7d59b9-s2pkn            0/1     CrashLoopBackOff   5          4m34s
testcluster-st2rulesengine-fbff5c8dd-bzl5k         0/1     CrashLoopBackOff   5          4m34s
testcluster-st2rulesengine-fbff5c8dd-mkgpg         0/1     CrashLoopBackOff   5          4m34s
testcluster-st2scheduler-77db66bc5b-87crf          0/1     CrashLoopBackOff   5          4m34s
testcluster-st2scheduler-77db66bc5b-9fskj          0/1     CrashLoopBackOff   5          4m34s
testcluster-st2sensorcontainer-65c45f9445-9t9cz    0/1     CrashLoopBackOff   5          4m34s
testcluster-st2stream-599cb6b7b4-4dsmt             0/1     CrashLoopBackOff   5          4m34s
testcluster-st2stream-599cb6b7b4-s7zzn             0/1     CrashLoopBackOff   5          4m34s
testcluster-st2timersengine-6c54464b5f-bns59       0/1     CrashLoopBackOff   5          4m34s
testcluster-st2web-6dd96cf9f7-l5l28                1/1     Running            0          4m33s
testcluster-st2web-6dd96cf9f7-qmhjm                1/1     Running            0          4m33s
testcluster-st2workflowengine-7499f6d446-m9t8r     0/1     CrashLoopBackOff   5          4m33s
testcluster-st2workflowengine-7499f6d446-vmxm2     0/1     CrashLoopBackOff   5          4m33s

@nagrigore Just a heads up - PR has been merged and new packages built.
If you redeployed the cluster with the latest version of StackStorm packages, it should work now.

We'll check again in a few days when both packages + docker images are available and close this issue.

Still need some time for packages + Dockerfiles to build based on new code. That will happen likely tomorrow.

For me personally, the deployments have started to work again. Thanks a bunch @Kami @armab

Thanks for letting us know that it's working for you. I'll go ahead and close this issue now, please feel free to re-open if necessary.

Hello,
Seems like the the deploy is working now.
Thank you!


Installer should download latest compatible CLI version

The FuseML installer currently downloads the latest available CLI binary release. This behavior doesn't cover the following cases:

older installer (e.g. v0.2.1) installs older core sever release (v0.2.1) and downloads newer and possibly incompatible CLI (e.g. v0.3.0). This can result in CLI failures, as the 0.3 CLI isn't guaranteed to be backwards compatible.
installer should warn/fail if a compatible CLI isn't available for download
the fuseml/fuseml CI running on the release tags ignores the fuseml CLI downloaded by the installer and instead is re-compiling the CLI from the fuseml/fuseml-core code in the same branch. This doesn't reflect the end-user behavior and should be changed to use the installer downloaded CLI. To allow for periodic, pre-release testing, however, it should only do that for release tags.

We should assume that the CLI and installer are not release-locked and instead semantic versioning rules are followed. For alpha releases, this means that patch CLI releases are backwards compatible with server/installer releases in the same minor release (for example a v0.3.0 installer and server version are compatible with a v0.3.1 CLI and vice-versa).

The proposed rules are as follows:

if the installer release value is an official alpha release v0.X[.Y], then the latest compatible CLI release is v0.X.latest where latest>=Y
if the installer release value is an official production release vR.X[.Y] where R>0, then the latest compatible CLI release is vR.major-latest.minor-latest, where major-latest>=X and minor-latest>=Y
all other release values (e.g. generated from branch names or dev) should be treated as development and since the compatibility cannot be assessed, a compatible CLI binary should not be downloaded anymore

The solution:

the installer must fetch the latest compatible CLI binary as per the above rules
if a matching CLI release isn't found, an error should be returned (this helps detect problems during release, e.g. if the CLI release is missing)


docs: remove lensplay.xyz entry

This pull request removes the https://www.lensplay.xyz since the app is no longer maintained, and the authors did not respond for comment.

Closed since the website authors' confirmed that efforts are underway to restore the website's functionality.


update: updated notation key command based on spec

This PR updates notation key command based on the key_spec.
Signed-off-by: Patrick Zheng<EMAIL_ADDRESS>

Codecov Report

Merging #416 (c8c406b) into main (f747031) will increase coverage by 0.20%.
The diff coverage is 32.14%.

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   34.60%   34.81%   +0.20%
==========================================
  Files          23       23
  Lines        1254     1235      -19
==========================================
- Hits          434      430       -4
+ Misses        809      793      -16
- Partials       11       12       +1

Impacted Files
Coverage Δ

internal/cmd/flags.go
52.74% <ø> (ø)

cmd/notation/key.go
23.76% <32.14%> (+0.23%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Support XML 1.1

This is a blocking issue for my company. We have a string that contains control
characters – as defined by Character.isISOControl(char). These values can
legally be encoded in XML 1.1 (but not in XML 1.0). The XML version should be
selectable in JAXB RI (possibly through a System property) and the values
property encoded. The class responsible for encoding is:
com.sun.xml.bind.v2.runtime.output.Encoded
Environment
Operating System: All
Platform: All
Affected Versions
[2.0.6]

If a user wants to serialize content which contains control characters like 0x001A (substitute) then the only option is to use a custom CharacterEscapeHandler which provides the required escapes for XML 1.1 (e.g. via Apache StringEncodingUtils).
Would be really nice if we had something like setXMLVersion(..) which automatically deals with the encoding.


Ensure child memory pool name unique and use weak ptr to track

Ensure child memory pool name unique
Use weak ptr instead of raw pointer to track child pool
Add concurrent memory pool structure access test

@xiaoxmeng There are CI failures that appear related. Consider fixing these and also deploying custom build to Prestissimo clusters before landing.

@xiaoxmeng Looks good to me. The removal of FOLLY_NULLABLE makes it hard to see the actual changes. Next time consider making these changes in a separate PR.

Sure, thanks!

@xiaoxmeng There are CI failures that appear related. Consider fixing these and also deploying custom build to Prestissimo clusters before landing.

@mbasmanova  Fixed.


Wait for the controller to be rolled out in actions

Changes
As per title. This is very similar to #574. I'll go doublecheck if it makes sense to deduplicate the scripts for the future next.
/assign @nak3

/lgtm


DEP: replaced function that identifies file suffix

DEP: replaced function that identifies file suffix
Deprecated cogent3.parse.sequence.format_from_filename in favour of cogent3.util.misc.get_format_suffixes, which is a copy. Also created variable _compression in cogent3.util.misc, which format_from_filename was dependent on.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 91.33%

Files with Coverage Reduction
New Missed Lines
%

.nox/test-3-10/Lib/site-packages/cogent3/util/io.py
2
97.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
177761

Relevant Lines:
194636

💛  - Coveralls


Need to provide a way to add custom text to area-label for Icon component under TableHeader->th->button->Icon

We have a requirement to translate area-label text for Icon which comes under TableHeader->th->button->Icon.
The component is DataTable.
At present, I don't see any way to pass area-label text to the Icon.

Hi 👋 <TableHader> has translateWithId prop, where you can provide an instance of react-i18next or a compatible library. Make sure it has a translation for carbon.table.header.icon.description. Hope this helps!

Thanks @asudoh . It is working.


unable to build ports

Hello,
i have tried to use the readme instructions, but all i get is:
make: *** No targets specified and no makefile found.  Stop.
for esp32:
radu@homeserver:~/mpython_proj/mpy-mbedtls/ports/esp32$  make BOARD=GENERIC USER_C_MODULES=../../../../mpy-mbedtls FROZEN_MANIFEST=/home/radu/mpython_proj/mpy-mbedtls/ports/esp32/manifest.py -j4
make: *** No targets specified and no makefile found.  Stop.
for unix:
radu@homeserver:~/mpython_proj/mpy-mbedtls/ports/unix$ make USER_C_MODULES=../../../mpy-mbedtls FROZEN_MANIFEST=../../../mpy-mbedtls/ports/unix/manifest.py -j4
make: *** No targets specified and no makefile found.  Stop.

Hi @radu022003 you should use that command in the micropython dir, e.g.
$ ~/micropython/ports/esp32 make BOARD=GENERIC ...
and
$ tree
├── micropython
│   ├── ACKNOWLEDGEMENTS
│   ├── CODECONVENTIONS.md
│   ├── CODEOFCONDUCT.md
│   ├── CONTRIBUTING.md
│   ├── LICENSE
│   ├── README.md
│   ├── docs
│   ├── drivers
│   ├── examples
│   ├── extmod
│   ├── lib
│   ├── logo
│   ├── mpy-cross
│   ├── ports
│   ├── py
│   ├── pyproject.toml
│   ├── shared
│   ├── ssl.patch
│   ├── tests
│   └── tools
└── user_modules
   └── mpy-mbedtls

If you haven't build the firmware before check MicroPython README.md and the port README.md i.e. unix and esp32
 Also checkout MicroPython documentation about building USER_C_MODULES at https://docs.micropython.org/en/latest/develop/cmodules.html

Thanks for the hint, somehow I had the mindset that I will create a .mpy file out of it, not the whole mircopython.
Using your hints, I could pass over that error, but got another one.
I am trying to build it for raspberry pi pico, so I have tried to run it from ports/rp2.
and i got these:
`console
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c: In function 'mbedtls_ec_gen_key':
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:168:18: error: implicit declaration of function 'mbedtls_pk_write_key_pem'; did you mean 'mbedtls_ecp_write_key'? [-Werror=implicit-function-declaration]
if( ( ret = mbedtls_pk_write_key_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
^~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_ecp_write_key
[ 57%] Building C object CMakeFiles/firmware.dir/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c.obj
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:177:15: error: implicit declaration of function 'mbedtls_pk_write_key_der'; did you mean 'mbedtls_ecp_write_key'? [-Werror=implicit-function-declaration]
if( ( ret = mbedtls_pk_write_key_der( &key, output_buf, sizeof(output_buf) )) < 0 ){
^~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_ecp_write_key
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:194:18: error: implicit declaration of function 'mbedtls_pk_write_pubkey_pem'; did you mean 'mbedtls_pk_parse_public_key'? [-Werror=implicit-function-declaration]
if( ( ret = mbedtls_pk_write_pubkey_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
^~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_pk_parse_public_key
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:207:15: error: implicit declaration of function 'mbedtls_pk_write_pubkey_der'; did you mean 'mbedtls_pk_parse_public_key'? [-Werror=implicit-function-declaration]
if( ( ret = mbedtls_pk_write_pubkey_der( &key, output_der, sizeof(output_der) )) < 0 ){
^~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_pk_parse_public_key
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c: In function 'x509_gen_csr':
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:130:5: error: implicit declaration of function 'mbedtls_x509write_csr_init'; did you mean 'mbedtls_x509_crt_init'? [-Werror=implicit-function-declaration]
mbedtls_x509write_csr_init( &req );
^~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_crt_init
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:135:5: error: implicit declaration of function 'mbedtls_x509write_csr_set_md_alg'; did you mean 'mbedtls_x509_crt_parse_der'? [-Werror=implicit-function-declaration]
mbedtls_x509write_csr_set_md_alg( &req, MBEDTLS_MD_SHA256 );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_crt_parse_der
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:138:5: error: implicit declaration of function 'mbedtls_x509write_csr_set_key_usage'; did you mean 'mbedtls_x509_time_is_future'? [-Werror=implicit-function-declaration]
mbedtls_x509write_csr_set_key_usage( &req,  MBEDTLS_X509_KU_DIGITAL_SIGNATURE | MBEDTLS_X509_KU_KEY_ENCIPHERMENT |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_time_is_future
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:155:12: error: implicit declaration of function 'mbedtls_x509write_csr_set_subject_name'; did you mean 'mbedtls_x509_parse_subject_alt_name'? [-Werror=implicit-function-declaration]
ret =  mbedtls_x509write_csr_set_subject_name( &req, subject);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_parse_subject_alt_name
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:173:5: error: implicit declaration of function 'mbedtls_x509write_csr_set_key'; did you mean 'mbedtls_x509_crt_parse_der'? [-Werror=implicit-function-declaration]
mbedtls_x509write_csr_set_key( &req, &key );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_crt_parse_der
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:179:11: error: implicit declaration of function 'mbedtls_x509write_csr_pem'; did you mean 'mbedtls_x509_write_sig'? [-Werror=implicit-function-declaration]
ret = mbedtls_x509write_csr_pem( &req, output_buf, sizeof(output_buf) , mbedtls_ctr_drbg_random, &ctr_drbg );
^~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_write_sig
/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c:188:5: error: implicit declaration of function 'mbedtls_x509write_csr_free'; did you mean 'mbedtls_x509_crt_free'? [-Werror=implicit-function-declaration]
mbedtls_x509write_csr_free( &req );
^~~~~~~~~~~~~~~~~~~~~~~~~~
mbedtls_x509_crt_free
cc1: all warnings being treated as errors
make[3]: *** [CMakeFiles/firmware.dir/build.make:4096: CMakeFiles/firmware.dir/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c.obj] Error 1
make[3]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[3]: *** [CMakeFiles/firmware.dir/build.make:4109: CMakeFiles/firmware.dir/home/radu/mpython_proj/mpy-mbedtls/x509/mod_x509.c.obj] Error 1
make[2]: *** [CMakeFiles/Makefile2:1848: CMakeFiles/firmware.dir/all] Error 2
make[1]: *** [Makefile:103: all] Error 2
`

in between I have made some nasty changes to the mod_mbedtls.c, by copying out the functions with errors and I could successfully build the micropython uf2 image.
I have copied it on a pico W. I could also import the mbedtls module. I tired to execute the already existing example from you and I got the following error:

%Run -c $EDITOR_CONTENT

====== Test encode -----------------------------------------
Temperature: 25.06 Humidity: 50.55
Preparing data for encryption
13
16
Traceback (most recent call last):
File "", line 122, in
File "", line 106, in main
File "", line 76, in encrypt_payload
ValueError: cipher not found
can you please advise?

@radu022003 nice!, I haven't tested it on a pico so happy to see it kind of works 👀 ,
yes you need to use the config at https://github.com/Carglglz/mpy-mbedtls/blob/develop/mbedtls/mbedtls_config.h,
and in rp2 port it should be in micropython/ports/rp2/mbedtls/mbedtls_config.h,

EDIT:
After some small debug I saw that at least my image does not contain the CCM mode for aes.
the output of the mbedtls.aes_ciphers() function
['AES-128-ECB', 'AES-192-ECB', 'AES-256-ECB', 'AES-128-CBC', 'AES-192-CBC', 'AES-256-CBC', 'AES-128-GCM', 'AES-192-GCM', 'AES-256-GCM']

I've just realised I didn't update mbedtls_config.h to enable the latest changes.
diff --git a/mbedtls/mbedtls_config.h b/mbedtls/mbedtls_config.h
index 7f8413b..05e4222 100644
--- a/mbedtls/mbedtls_config.h
+++ b/mbedtls/mbedtls_config.h
@@ -35,6 +35,7 @@
 #define MBEDTLS_AES_ROM_TABLES
 #define MBEDTLS_CIPHER_MODE_CBC
 #define MBEDTLS_CIPHER_MODE_CTR // needed for MICROPY_PY_UCRYPTOLIB_CTR
+#define MBEDTLS_CIPHER_MODE_AEAD
 #define MBEDTLS_ECP_DP_SECP192R1_ENABLED
 #define MBEDTLS_ECP_DP_SECP224R1_ENABLED
 #define MBEDTLS_ECP_DP_SECP256R1_ENABLED
@@ -65,6 +66,7 @@

 // Enable mbedtls modules
 #define MBEDTLS_AES_C
+#define MBEDTLS_CCM_C
 #define MBEDTLS_ASN1_PARSE_C
 #define MBEDTLS_ASN1_WRITE_C
 #define MBEDTLS_BIGNUM_C

So I've updated it in the latest commit, it should work now 👍🏼

Hi @Carglglz,
I have encountered different errors and I had to remove the following defines in order to make it compilable. With these changes, i get no error, but also no output. CPU seems to crash when the function mbedtls.aes_encrypt is called.

I have also tried with this config, but cpu is still crashing without any error
diff --git a/mbedtls/mbedtls_config.h b/mbedtls/mbedtls_config.h
index 05e4222..2b57160 100644
--- a/mbedtls/mbedtls_config.h
+++ b/mbedtls/mbedtls_config.h
@@ -77,7 +77,7 @@
 #define MBEDTLS_ECP_C
 #define MBEDTLS_ENTROPY_C
 #define MBEDTLS_ERROR_C
-#define MBEDTLS_HAVEGE_C
+//#define MBEDTLS_HAVEGE_C
 #define MBEDTLS_MD_C
 #define MBEDTLS_MD5_C
 #define MBEDTLS_OID_C
@@ -93,16 +93,16 @@
 #define MBEDTLS_SSL_CLI_C
 #define MBEDTLS_SSL_SRV_C
 #define MBEDTLS_SSL_TLS_C
-#define MBEDTLS_TIMING_C
+//#define MBEDTLS_TIMING_C
 #define MBEDTLS_TLS_DEFAULT_ALLOW_SHA1_IN_KEY_EXCHANGE
 #define MBEDTLS_X509_CRT_PARSE_C
-//#define MBEDTLS_X509_CRL_PARSE_C
-#define MBEDTLS_X509_CSR_PARSE_C
-#define MBEDTLS_X509_CSR_WRITE_C
+#define MBEDTLS_X509_CRL_PARSE_C
+//#define MBEDTLS_X509_CSR_PARSE_C
+//#define MBEDTLS_X509_CSR_WRITE_C
 #define MBEDTLS_X509_CREATE_C
 #define MBEDTLS_X509_USE_C
-#define MBEDTLS_PEM_PARSE_C
-#define MBEDTLS_PEM_WRITE_C
+//#define MBEDTLS_PEM_PARSE_C
+//#define MBEDTLS_PEM_WRITE_C
 #define MBEDTLS_BASE64_C
 #define MBEDTLS_HAVE_TIME
 #define MBEDTLS_HAVE_TIME_DATE

After some more trials, I have made a hard reset of this repo and only made these changes:
diff --git a/mbedtls/mbedtls_config.h b/mbedtls/mbedtls_config.h
index 7f8413b..49fdcfe 100644
--- a/mbedtls/mbedtls_config.h
+++ b/mbedtls/mbedtls_config.h
@@ -75,7 +75,7 @@
 #define MBEDTLS_ECP_C
 #define MBEDTLS_ENTROPY_C
 #define MBEDTLS_ERROR_C
-#define MBEDTLS_HAVEGE_C
+//#define MBEDTLS_HAVEGE_C
 #define MBEDTLS_MD_C
 #define MBEDTLS_MD5_C
 #define MBEDTLS_OID_C
@@ -91,7 +91,7 @@
 #define MBEDTLS_SSL_CLI_C
 #define MBEDTLS_SSL_SRV_C
 #define MBEDTLS_SSL_TLS_C
-#define MBEDTLS_TIMING_C
+//#define MBEDTLS_TIMING_C
 #define MBEDTLS_TLS_DEFAULT_ALLOW_SHA1_IN_KEY_EXCHANGE
 #define MBEDTLS_X509_CRT_PARSE_C
 //#define MBEDTLS_X509_CRL_PARSE_C
@@ -106,5 +106,5 @@
 #define MBEDTLS_HAVE_TIME_DATE

 #include "mbedtls/check_config.h"
-
+#include <time.h>
 #endif /* MICROPY_INCLUDED_MBEDTLS_CONFIG_H */

I had to give up on MBEDTLS_HAVEGE_C and MBEDTLS_TIMING_C because of this error:
 /home/radu/micropython/lib/mbedtls/library/timing.c:33:2: error: #error "This module only works on Unix and Windows, see MBEDTLS_TIMING_C in config.h"  #error "This module only works on Unix and Windows, see MBEDTLS_TIMING_C in config.h"   ^~~~~ make[3]: *** [CMakeFiles/firmware.dir/build.make:3966: CMakeFiles/firmware.dir/home/radu/micropython/lib/mbedtls/library/timing.c.obj] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [CMakeFiles/Makefile2:1848: CMakeFiles/firmware.dir/all] Error 2 make[1]: *** [Makefile:103: all] Error 2 -e See https://github.com/micropython/micropython/wiki/Build-Troubleshooting make: *** [Makefile:46: all] Error 1
In this status, the compilation is fine, but now it complains about this:
>>> %Run -c $EDITOR_CONTENT

====== Test encode -----------------------------------------
Temperature: 25.06 Humidity: 50.55

Preparing data for encryption
13
16
Traceback (most recent call last):
  File "<stdin>", line 122, in <module>
  File "<stdin>", line 106, in main
  File "<stdin>", line 76, in encrypt_payload
AttributeError: 'module' object has no attribute 'aes_encrypt'
>>> import mbedtls
>>> dir(mbedtls)
['__class__', '__name__', '__dict__', 'FORMAT_DER', 'FORMAT_PEM', 'ec_curve_info', 'ec_curves', 'ec_gen_key', 'ec_get_pubkey', 'ec_key_sign', 'ec_key_verify', 'version']
>>>

I tried to start it all over and reset the develop branch in order to have a better understanding, during the compilation I am getting this error:
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c: In function 'mbedtls_aes_enc':
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:697:9: error: implicit declaration of function 'mbedtls_cipher_auth_encrypt_ext'; did you mean 'mbedtls_ccm_auth_decrypt'? [-Werror=implicit-function-declaration]
   ret = mbedtls_cipher_auth_encrypt_ext( &ctx, iv, iv_len, addata, addata_len, data,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         mbedtls_ccm_auth_decrypt
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c: In function 'mbedtls_aes_dec':
/home/radu/mpython_proj/mpy-mbedtls/mbedtls/mod_mbedtls.c:820:9: error: implicit declaration of function 'mbedtls_cipher_auth_decrypt_ext'; did you mean 'mbedtls_ccm_auth_decrypt'? [-Werror=implicit-function-declaration]
   ret = mbedtls_cipher_auth_decrypt_ext( &ctx, iv, iv_len, addata, addata_len, data,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         mbedtls_ccm_auth_decrypt

@radu022003 did you replace or merged original config file at micropython/ports/rp2/mbedtls/mbedtls_config.h with https://github.com/Carglglz/mpy-mbedtls/blob/develop/mbedtls/mbedtls_config.h?, try combining both files and see if that works 👀

@radu022003

I have double checked and in my micropython/lib/mbedtls/include/mbedtls/cipher.h i can find the declaration of these 2 functions.

In micropython/lib/mbedtls, you should be at commit 981743de6 ($ git checkout 981743de6)
* (HEAD detached at 981743de6) 981743de6 Merge pull request #1009 from paul-elliott-arm/mbedtls-2.28.3rc0-pr

They should be there now
micropython/lib/mbedtls $ rg mbedtls_cipher_auth_encrypt_ext
tests/suites/test_suite_cipher.function
543:    /* mbedtls_cipher_auth_encrypt_ext */
546:        mbedtls_cipher_auth_encrypt_ext(NULL,
554:        mbedtls_cipher_auth_encrypt_ext(&valid_ctx,
562:        mbedtls_cipher_auth_encrypt_ext(&valid_ctx,
570:        mbedtls_cipher_auth_encrypt_ext(&valid_ctx,
578:        mbedtls_cipher_auth_encrypt_ext(&valid_ctx,
586:        mbedtls_cipher_auth_encrypt_ext(&valid_ctx,
1312:        ret = mbedtls_cipher_auth_encrypt_ext(&ctx, iv->x, iv->len,
1326:        ret = mbedtls_cipher_auth_encrypt_ext(&ctx, iv->x, iv->len,

library/cipher.c
1286: * mbedtls_cipher_auth_encrypt() and mbedtls_cipher_auth_encrypt_ext().
1363: * mbedtls_cipher_auth_encrypt() and mbedtls_cipher_auth_encrypt_ext().
1516:int mbedtls_cipher_auth_encrypt_ext(mbedtls_cipher_context_t *ctx,

library/ssl_msg.c
908:        if ((ret = mbedtls_cipher_auth_encrypt_ext(&transform->cipher_ctx_enc,

library/ssl_ticket.c
272:    if ((ret = mbedtls_cipher_auth_encrypt_ext(&key->ctx,

include/mbedtls/cipher.h
883: * \deprecated          Superseded by mbedtls_cipher_auth_encrypt_ext().
887: *                      mbedtls_cipher_auth_encrypt_ext().
1041:int mbedtls_cipher_auth_encrypt_ext(mbedtls_cipher_context_t *ctx,

ChangeLog
689:     Please use mbedtls_cipher_auth_encrypt_ext() and
702:     functions mbedtls_cipher_auth_encrypt_ext() and

The 2 functions were present before checkout too, but during the compilation, are not to be found.
Checking out to that commit didn't improved it.

then the problem is in the config file, use the original file at  micropython/ports/rp2/mbedtls/mbedtls_config.h and add the following
#define MBEDTLS_X509_CSR_PARSE_C
#define MBEDTLS_X509_CSR_WRITE_C
#define MBEDTLS_X509_CREATE_C
#define MBEDTLS_X509_USE_C
#define MBEDTLS_PEM_PARSE_C
#define MBEDTLS_PEM_WRITE_C
#define MBEDTLS_BASE64_C
#define MBEDTLS_HAVE_TIME
#define MBEDTLS_HAVE_TIME_DATE
#define MBEDTLS_CCM_C
#define MBEDTLS_CIPHER_MODE_AEAD

original file, from this repo?

I meant from micropython repo, with the changes I mentioned above should be something like this:
/*
 * This file is part of the MicroPython project, http://micropython.org/
 *
 * The MIT License (MIT)
 *
 * Copyright (c) 2018-2019 Damien P. George
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */
#ifndef MICROPY_INCLUDED_MBEDTLS_CONFIG_H
#define MICROPY_INCLUDED_MBEDTLS_CONFIG_H

// Set mbedtls configuration
#define MBEDTLS_ECP_NIST_OPTIM
#define MBEDTLS_KEY_EXCHANGE_ECDHE_RSA_ENABLED

// Enable mbedtls modules
#define MBEDTLS_GCM_C
#define MBEDTLS_HAVE_TIME
#define MBEDTLS_HAVE_TIME_DATE
#define MBEDTLS_X509_CSR_PARSE_C
#define MBEDTLS_X509_CSR_WRITE_C
#define MBEDTLS_X509_CREATE_C
#define MBEDTLS_X509_USE_C
#define MBEDTLS_PEM_PARSE_C
#define MBEDTLS_PEM_WRITE_C
#define MBEDTLS_BASE64_C
#define MBEDTLS_CCM_C
#define MBEDTLS_CIPHER_MODE_AEAD

// Time hook
#include <time.h>
time_t rp2_rtctime_seconds(time_t *timer);
#define MBEDTLS_PLATFORM_TIME_MACRO rp2_rtctime_seconds

// Set MicroPython-specific options.
#define MICROPY_MBEDTLS_CONFIG_BARE_METAL (1)

// Include common mbedtls configuration.
#include "extmod/mbedtls/mbedtls_config_common.h"

#endif /* MICROPY_INCLUDED_MBEDTLS_CONFIG_H */

understood, did as you said, compiled successfully, but it is still crashing when running the example

finally managed to make it work

Thank you very much for your help, couldn't have done it without you.
I feel that we should bring these changes/experiences into your repo, so other can benefit out of it.
The main thing was the mbedtls_config.h that had to be changed.
Perhaps you can add another port in your repo for rp2?

yes,  as you can see mbedtls config is split in micropython repo between extmod/mbedtls/mbedtls_config_common.h and ports/<...>/mbedtls/mbedtls_config.h and the key part I think was #define MICROPY_MBEDTLS_CONFIG_BARE_METAL (1) this option which was missing from the config file in my repo. Thank you for testing 🥇

Perhaps you can add another port in your repo for rp2?

Yes I will do it now that you confirmed it is working.

It is me again :)
I have built the micropython (with the mbedtls module) with the flagh BOARD=PICO_W.
This would give me the bluetooth module.
The problem is that as soon as I run the command ble.activate(True), pico is crashing.
I know that the hardware is ok because I tested the same with the official micropython version.
Can you please advise me?

mmm try disabling
#define MBEDTLS_PEM_PARSE_C
#define MBEDTLS_PEM_WRITE_C
#define MBEDTLS_BASE64_C

it may be a memory problem, but I cannot tell for sure 😕

I did as you suggested and I am now able to use the ble module and the aes_ccm (not yet successful with BTHOME).
I had to comment these lines out in order to make the compilation successful:
diff --git a/mbedtls/mod_mbedtls.c b/mbedtls/mod_mbedtls.c
index acc18e1..1ef825b 100644
--- a/mbedtls/mod_mbedtls.c
+++ b/mbedtls/mod_mbedtls.c
@@ -165,10 +165,10 @@ STATIC mp_obj_t mbedtls_ec_gen_key(size_t n_args, const mp_obj_t *pos_args, mp_m
        mp_obj_t pkey;
     memset(output_buf, 0, bits);
        if (format == FORMAT_PEM){
-       if( ( ret = mbedtls_pk_write_key_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
-               goto cleanup;
+       //if( ( ret = mbedtls_pk_write_key_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
+       //      goto cleanup;

-       }
+       //}
                len = strlen( (char *) output_buf );
                pkey = mp_obj_new_bytes(output_buf, len);
        }
@@ -191,10 +191,10 @@ STATIC mp_obj_t mbedtls_ec_gen_key(size_t n_args, const mp_obj_t *pos_args, mp_m
        mp_obj_t pubkey;
     memset(output_buf, 0, bits);
        if (format == FORMAT_PEM){
-       if( ( ret = mbedtls_pk_write_pubkey_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
-               goto cleanup;
+       //if( ( ret = mbedtls_pk_write_pubkey_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
+       //      goto cleanup;

-       }
+       //}
                len = strlen( (char *) output_buf );
                pubkey = mp_obj_new_bytes(output_buf, len);
        }
@@ -277,10 +277,10 @@ STATIC mp_obj_t mbedtls_ec_get_pubkey(const mp_obj_t key_in, const mp_obj_t form
     size_t len = 0;
     memset(output_buf, 0, key_len);
        if (fmt == FORMAT_PEM){
-       if( ( ret = mbedtls_pk_write_pubkey_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
-               goto cleanup;
+       //if( ( ret = mbedtls_pk_write_pubkey_pem( &key, output_buf, sizeof(output_buf) )) != 0 ){
+       //      goto cleanup;

-       }
+       //}
                len = strlen( (char *) output_buf );
                pubkey = mp_obj_new_bytes(output_buf, len);
        }
diff --git a/x509/mod_x509.c b/x509/mod_x509.c
index 277ccfb..7f7eec5 100644
--- a/x509/mod_x509.c
+++ b/x509/mod_x509.c
@@ -176,7 +176,7 @@ STATIC mp_obj_t x509_gen_csr(const mp_obj_t sub_in, const mp_obj_t key_in){
     unsigned char output_buf[512];
     memset( output_buf, 0, 512 );
     size_t len = 0;
-    ret = mbedtls_x509write_csr_pem( &req, output_buf, sizeof(output_buf) , mbedtls_ctr_drbg_random, &ctr_drbg );
+    //ret = mbedtls_x509write_csr_pem( &req, output_buf, sizeof(output_buf) , mbedtls_ctr_drbg_random, &ctr_drbg );
     if (ret < 0){
        goto cleanup;
     }

I have successfully connected the raspberry pi W with home assistant using the BTHome protocol.
I will create a repo with the example.

I had to comment these lines out in order to make the compilation successful

I may be able to add a macro so commenting won't be necessary, I will look into it.
In any case I'm happy to see this is finally working 🚀


Fix using the plugin with gradle v7

Gradle v7 is failing with the message:
Type 'DevTask' property 'container' is missing an input or output annotation.

@dkrtic Thank you for bringing this to our attention. Since Gradle 7 is a milestone release, we have not provided support for it yet. I have opened issue #592 to look into supporting Gradle 7 for our entire plugin. We would typically not put fixes in until closer to an actual generally available release.

Thanks for the PR, @dkrtic.  Merging this fix for DevTask.
Any other changes needed for Gradle 7 will be handled in https://github.com/OpenLiberty/ci.gradle/issues/592.


Multi Color Line Legend

Is there an option for a legend per color segment?
If there is, once hovered does the corresponding line segment highlight?

Hello,
If you want legend per color segment, then it would be better to use multiple series :) Simply, before rendering data, split all points into separate series. It also will highlight the segment (as this is one series).


xmake f --menu报错

Note: If you use the fuzzy expressions such as 'can't use/no effect/problem/error', but don't give any relevant auxiliary information according to the template below, this issue will be not replied.

Describe the bug
运行xmake f --menu 报错 error: attempt to call field 'isdone' (a nil value)
Error output
error: attempt to call field 'isdone' (a nil value)
Related Environment
Please provide compiling and running environment information:

xmake version:v2.3.6
os:winows10  2004 19041.388
target platform:x64

I have fixed it, you can update to dev branch and try it again.
$ xmake update dev
$ xmake f --menu

Or you can download the dev version from https://github.com/xmake-io/xmake/actions/runs/187948204


[TEST] BE COV

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[80]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[81]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[81]

[BE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
be/src/agent/agent_task.cpp
1
1
100.00%
[]

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
be/src/agent/agent_task.cpp
0
1
00.00%
[81]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[81]

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[81]

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 1 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/agent/agent_task.cpp
0
1
00.00%
[81]

[BE Incremental Coverage Report]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
be/src/agent/agent_task.cpp
1
1
100.00%
[]


Android Studio project import memory regression in 8.6-rc1

Current Behavior
There seems to be a memory regression in 8.6-rc1 during project configuration.
Our 2000 sub-project benchmark for Android Studio import reports significantly more memory use after project evaluation in Gradle 8.6-rc1

Expected Behavior
See image above for before/after values.
Context (optional)
No response
Steps to Reproduce

Clone the benchmark project. git clone https://github.com/gavra0/android-extra-large-benchmark -b 2022.9
Optional but recommended, set up a smaller subset (i.e. maybe 200):  https://github.com/gavra0/android-extra-large-benchmark/tree/2022.9?tab=readme-ov-file#working-with-smaller-subsets
Enable the measurement plugin for use during sync: https://github.com/gavra0/android-extra-large-benchmark/tree/2022.9?tab=readme-ov-file#working-with-smaller-subsets
Open Android Studio and import the project
Once import finishes, captured histograms will be found at measurements directory.

Gradle version
8.6-rc1
Gradle version that used to work
8.4
Build scan URL (optional)
No response
Your Environment (optional)
No response

Thank you for providing a valid report.
The issue is in the backlog of the relevant team and is prioritized by them.

If I run the benchmark again with the latest gradle nightly(e.g.  8.7-20240121001303+0000, released on 21 Jan 2024), I should  be able to see the difference, right?


Deploy Checklist: New Expensify 2021-12-08

Release Version: 1.1.18-5
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

https://github.com/Expensify/App/pull/6137

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/6498

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/6573

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/6583

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/6608

[ ] QA
[ ] Accessibility

https://github.com/Expensify/App/pull/6615

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/6629

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/6630

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/6631

[x] QA
[x] Accessibility

https://github.com/Expensify/App/pull/6639

[ ] QA
[ ] Accessibility

cc @Expensify/applauseleads

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

Nice short checklist here 😄

My favorites ❤

@isagoico Feel free to lock the checklist and begin QA as soon as you're ready.

Starting QA

The fix for https://github.com/Expensify/App/issues/6667 was deployed in 1.1.19-1, and the fix for https://github.com/Expensify/App/issues/6666 was deployed in 1.1.19-2, so feel free to retest those whenever you're ready.

Manually CPing https://github.com/Expensify/App/pull/6684 to staging in 1.1.19-4 to fix https://github.com/Expensify/App/issues/6675 and also to test https://github.com/Expensify/App/pull/6655.

Regression is almost complete. Few re-tests in progress
Deploy blockers found (we are re-testing)

iOS - Payment - Save and continue button hidden behind keypad #6666
mWeb - iPad 7- Welcome screen is not fully displayed on large screen iPad #6667
Missing avatars in the center of the group conversation #6675

Comments added
https://github.com/Expensify/App/pull/6608#issuecomment-990615263
Issues logged
https://github.com/Expensify/App/issues/6676
https://github.com/Expensify/App/issues/6681
https://github.com/Expensify/App/issues/6685
https://github.com/Expensify/App/issues/6688
https://github.com/Expensify/App/issues/6691
https://github.com/Expensify/App/issues/6689
https://github.com/Expensify/App/issues/6669

Thanks @mvtglobally, keep me posted with the status of deploy blocker retests.

Any update here? Seems like we should be almost ready-to-go here.

@roryabraham, Regression is almost done.
Blockers are re-tested and passed. I checked off all PRs and issues
We had a bit inconsistent notifications behavior on Android. Team is trying to re-verify "Receive notification while app is backgrounded" steps. We should be able to close this in the next hour.

@roryabraham  We are able to repro this https://github.com/Expensify/App/issues/5022 today. I dont think its a deploy blocker as this is still open.
Regarding #6675 We are getting very mixed results.
Few testers still able to repro on build 1.1.19-4. I am not able to repro on any device. Can you also double check?
https://user-images.githubusercontent.com/43995119/145620704-05838316-adc0-4841-a5fa-bedf768b3f8e.mp4
https://user-images.githubusercontent.com/43995119/145620894-bf3ad384-c2d1-450f-850e-f13b86ab0444.mp4

Shoot, I was able to reproduce on iOS 😞 Going to reopen and look into it some more.

Going to demote https://github.com/Expensify/App/issues/6675 from deploy blocker to KI. @mvtglobally Please include it in your weekly retests.

:shipit:


Add 'submission' tab at top of page

https://ebi-ait.github.io/sars-cov2-data-upload/app-documentation has a link at the top towards 'documentation' - should we add a tab 'submission'? the only other way to go back is otherwise at the bottom of the page.

Added submission link.
@mcourtot - We need to find a deployment window for these new changes. I will do all changes and then may be we deploy all together at once. When we deploy we should be sure that no one is using the UI for uploads because the uploads will be terminated immediately.

do you know how long the deployment takes approximately?

is there an option to have a second server and just bounce to this one (I suspect not possible once the upload started in one client, but just to confirm)

The deployment time is approx 20 mins.
There is not much flexibility of having a second server in GH pages, URL will be different and load balancer setup is not supported. I will think of something that will not be disruptive.

if we were able to deploy on 2 EBI VMs, would there still be interruption of uploads as the load balancer redirects to the other VM?
eg I start the upload through VM1, then we take VM1 down for update, the load balancer sends me to VM2 - will that reinitialise all my work?

Yes is there is a load balancer setup, everything should be fine.


Marking generated meshes as static by default

Is there an option to mark generated meshes as static by default? Right now I have to do that manually after every rebuild.

I can't reproduce this problem. If you set the CSG Model and its children to static (and optionally tick the "Generate Lightmap UVs" option) it never changes, even with new meshes due to additional materials.

ah, didn't know the generated mesh inherited the static settings from the CSGModel parent, yes it works this way, thanks!


Sev concurrent syscalls

feat(shim-sev): Use multiple sallyport::Block
Because the setup area is limited in memory size, not each thread can
get its own sallyport::Block to communicate with the host.
Therefore a pool of blocks is reserved, which can be dynamically used
by the shim indicating the actual block via the value passed in the
IOPort.
A future extension could reserve additional blocks via a enarx specific
syscall.
Fixes: https://github.com/enarx/enarx-keepldr/issues/156

fix(shim-sev): rename ALIGN_ABOVE_2MB
Rename ALIGN_ABOVE_2MB to MAX_SETUP_SIZE to reflect its meaning.

Needs https://github.com/enarx/enarx-keepldr/pull/188 first

also removed backend::kvm::vm::Builder::Config


Send wallet address error

You can send /start command and try to update wallet again. Sometimes it works.


Add method to get relative paths (for paths)

It would be nice (especially for logs) if DirectoryPath and FilePath had a GetRelativePath method that returned a new path that is relative to another path.
public class FilePath {
  public FilePath GetRelativePath(FilePath to) {
    // Use file's directory as from path.
  }
  public DirectoryPath GetRelativePath(DirectoryPath to) {
    // Use file's directory as from path.
  }
}

public class DirectoryPath {
  public FilePath GetRelativePath(FilePath to) {
    ...
  }
  public DirectoryPath GetRelativePath(DirectoryPath to) {
    ...
  }
}

Requirements

Full unit test coverage proving that the functionality works as expected.
No PInvoke calls to Shlwapi.dll to get the relative path.
No URI tricks to get the relative path.
Both from/to paths must be absolute.
If no relative path can be calculated, the method should throw.

Basic test cases
var path = new DirectoryPath("C:/A/D/E");
var result = path.GetRelativePath(new DirectoryPath("C:/A/B/C"));
Assert.Equal("../../B/C", result.FullPath);

var path = new DirectoryPath("D:/A/B/C");
var result = Record.Exception(() => path.GetRelativePath(new DirectoryPath("C:/D/E/F")));
Assert.IsInstanceOf<InvalidOperationException>(result);
Assert.Equal("Paths must share a common prefix.", result.Message);

var path = new DirectoryPath("C:/A/B/C/D/E/F");
var result = path.GetRelativePath(new DirectoryPath("C:/A/B/C"));
Assert.Equal("../../..", result.FullPath);

var path = new DirectoryPath("C:/A/B/C");
var result = path.GetRelativePath(new DirectoryPath("C:/A/B/C/D/E/F"));
Assert.Equal("./D/E/F", result.FullPath);

@patriksvensson I am looking into this feature. What do you expect the returned FilePath to be for this code:
var path = new FilePath("C:/hello.txt");
var result = path.GetRelativePath(new FilePath("C:/hello.txt"));
result = ???

Should it be ".", or "./hello.txt", or just "hello.txt"?

And shouldn't the GetRelativePath(DirectoryPath to) method return a DirectoryPath instead of a Directory?

@ErikSchierboom
Great that you're looking at this! :+1:
Not 100% sure about the specification I wrote though, since it was only something i threw together when I wanted the functionality, but I think this is what we want though. What do you think? Something you see that would improve it?

Do you mean the FullPath property of the FilePath/DirectoryPath that is returned? Creating a path with or without ./ will result in the same thing (a relative file/directory path without the ./ part).

My bad. It should indeed return a DirectoryPath. I've updated it. :smile:

@ErikSchierboom Funny - I was literally just thinking about this. I'm porting Path, FilePath, and DirectoryPath into an unrelated project that needs to calculate relative paths. If it helps, I have some code that does something similar based on System.IO.Path here: https://github.com/Wyamio/Wyam/blob/develop/src/Wyam.Common/IO/PathHelper.cs#L32

@patriksvensson That answers my questions, thanks!
@daveaglick I'll have a look! Thanks

Resolved via #650.


PyTorch scaled_dot_product_attention doesn't support broadcast for grouped-query-attention

❓ The question
I tried implementing grouped query attention in this pull request, but seems that pytorch's scaled_dot_product_attention doesn't support the kind of broadcasting we'd need for this. Revisit if/when this gets fixed on pytorch's end.

I apologize for our delay in response. In order to help surface current, unresolved issues, we are closing tickets prior to February 29.
Please reopen your ticket if you are continuing to experience this issue.
Thank you!


Synced with your devel branch and merged in new code

Fixed a few stray issues with the way I had committed things. Fixed the code for frequency scan to handle threading, and hopefully there's nothing major broken by my changes at this point. Still have to implement "wait for signal" style pause and lockouts for bookmark scan. I had commented out the "activity notifications" as they conflicted with continuous scanning, but think selectable logging of all activity seen would be ideal. That's where the "log" checkbox is headed.

Update: wait-for-signal pause implemented, signal_check recoded to prevent some false positives I was having.

Have added bookmark lockout support and made the start/stop buttons into a single toggle. The lock button also toggles, though the text doesn't update. Locked bookmarks highlight in red, and this technique can be used to highlight scanning in general. Will add activity logging to a log file next.

cool,
thanks for the work done.

Hello,
checked the code and the features. It looks great! Thanks!.
Can I ask you to provide some unit tests for the code you are writing?

This work seems to fall in:
https://github.com/Marzona/rig-remote/issues/6
would you like to comment on that issue?

actually, this merge broke 11 unit tests.

Hi Simone - My apologies, I did not run the test suite against the modified code. I've not used the pytest package. I don't think I changed any of the disk_io code, or any of the parameter entry checking code that you wrote, so that functionality should be the same. I haven't reviewed it yet, but if the test code depends on structures in the modified code, then it will have to be updated to reflect changes in those structures. I'll be glad to go over it, but won't be able to do so until tomorrow.
As to issue #6, the UI isn't blocking at this point, so full interactivity is possible. However, as coded right now, changes to parameters passed when the scanning thread is started aren't detected by the scanning thread, but they certainly could be, or a queue used to pass changes to the scanning thread.

Just took a quick look at test_scanning and it does look like the tests need to be updated to reflect the additional parameters in ScanningTask (scan_stop_button, passes, and probably log and wait).

no hurry at all.
when you've time, and thanks for taking a look to it so quickly.
I'm going to set you as a contributor to avoid blocking you, and so to assign you the issues.

Sounds good. I'll close the fork tomorrow. On a side note, the readme file that I set up on the fork was copied over to this devel branch, so I just updated it to remove the fork references, but left the added features list so folks can see what's being worked on, if that works for you.

looks good to me


kubernetes_sd_config (alertmanagers): reloading config doesn't work

What did you do?
It is possible to automatically discovery alertmanagers if they are hosted in Kubernetes, something like this:
alerting:
  alertmanagers:
    - kubernetes_sd_configs:
        - role: pod
          namespaces:
            names:
              - monitoring
      relabel_configs:
        - source_labels: [__meta_kubernetes_pod_label_app_kubernetes_io_name]
          regex: alertmanager
          action: keep

What did you expect to see?
Updating the configuration when adding new alertmanagers.
What did you see instead? Under which circumstances?
Prometheus only discovery alertmanagers at startup. If the pods with the alertmanagers were recreated (and their ip changed), then Prometheus will not know about them.
System information
No response
Prometheus version
Version	2.36.2
Revision	d7e7b8e04b5ecdc1dd153534ba376a622b72741b
Branch	HEAD
BuildUser	root@f051ce0d6050
BuildDate	20220620-13:21:35
GoVersion	go1.18.3

Prometheus configuration file
...
    alerting:
      alertmanagers:
        - kubernetes_sd_configs:
            - role: pod
              namespaces:
                names:
                  - monitoring
          relabel_configs:
            - source_labels: [__meta_kubernetes_pod_label_app_kubernetes_io_name]
              regex: alertmanager
              action: keep
...

Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

2.40.1 – same problem

Same issue on 2.39.X . SD for scraping metrics work fine.

cc @brancz, although I'm not sure how it could work for scraping and not for alerting.

Hello from the bug scrub. Apologies for the delay on this.
If this is still happening then this could be a serious bug and needs investigating. cc @brancz


GDPR compliant Consent Design part is not linked

Page: https://docs.wso2.com/pages/viewpage.action?pageId=85392485

Linked off to the relevant library article.


Move listAll logic to list.go

The idea of this pull request is to move listAll logic into list.go so it can be reused by every entity_service.go
This function allows the handling of entities that can be disabled or just missing on the kong version (Not found on first call)
The use of the default page size is managed by the newOpt function.
The interfaces of the entites would become
List(ctx context.Context, opt *ListOpt) ([]*Entity, *ListOpt, error)
ListAll(ctx context.Context) ([]*Entity, error)
ListAllByOpt(ctx context.Context, opt *ListOpt) ([]*Entity, error)
ListAllByTags(ctx context.Context, tags []strings) ([]*Entity, error) // Only if the entity supports tags

where
func (s *EntityService) ListAll(ctx context.Context) ([]*Entity, error) {
	return s.ListAllByOpt(ctx, newOpt(nil))
}

func (s *EntityService) ListAllByTags(ctx context.Context, tags []strings) ([]*Entity, error) {
	return s.ListAllByOpt(ctx, newOpt(tags))
}

The main change is that the mapping from json.RawMessage to Entity would be done after all List() have been called instead of being done after each one. Would it have any performance impact ?
The next questions would be :

Would List(ctx context.Context, opt *ListOpt) ([]*Entity, *ListOpt, error) still be used ? I mean, is there any use case to ask for a partial result?
Shall ListAllByOpt(ctx context.Context, opt *ListOpt) ([]*Entity, error) be published by the interface ?
After all if it is decided to get rid of partial results every ListAll*() function except the one defined in the client can be renamed List*()

@rainest, @hbagdi  , I would like to have your opinions about this approach before going further.

The interfaces of the services hasn't been changed.
I just added the ListAllByTags for the entities which required it ( cf. dump.go in deck )

@hbagdi what do we know about third-party users of List()? How feasible would it be to make breaking changes
I'd recommend against it. Not having a ListAll in this API is OK but making List do pagination might be a bit too much. With some use-cases, users want to wish to have control over pagination for a variety of reasons.

Shall we close this PR, just take the list refactoring as it is , or anything else ?

@mflendrich it has been a while, can I ask you to refresh your memory and respond back here?

Hi @mflendrich, any hope for this refactor or shall we just drop the branch ?

@mmorel-35,
I think that we need to get this refactoring done but right now the whole maintainers team is heads down with unrelated work on KIC 2.0 release so I cannot commit to a specific time when we'll come back to this, but my expectation is that we'll pick this up in a few weeks from now.


amitq2contributionsectionwise

amit Q2 contribution section-wise

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

the build is failing. Probably due to a broken link or a unescaped "<" character. Please fix!

https://github.com/harness/developer-hub/pull/7813
Created a new PR for the change. Will merge this
closing #7550


webhook-service: Failed request of a list of requests results in result=pass

Affected Component

[ ] Approval
[ ] Bridge
[ ] CLI
[ ] Datastore
[ ] Docs
[ ] Distributor / Event Broker
[ ] Helm
[ ] Istio
[ ] Jmeter
[ ] Kubernetes Integration
[ ] Openshift Integration
[ ] REST API
[x] Webhook

Use Case
As a user, I define a list of requests that need to be called as part of a webhook subscription:

However, the first request is configured wrong. (see screenshot: webhook.badsite). This is also reported as an error when executing the request:

Bug
The bug is that the mytask.finished event, which is sent by the webhook-service contains a result=pass even though a request failed. Hence, the user still assumes that everything worked fine:
{
  "data": {
    "labels": null,
    "mytask-silent": {
      "responses": [
        ""
      ]
    },
    "project": "demo",
    "result": "pass",
    "service": "casdemoapp",
    "stage": "production",
    "status": "succeeded"
  },
  "id": "6058af4b-d682-4903-b00a-e6a7b6b238c4",
  "source": "webhook-service",
  "specversion": "1.0",
  "time": "2022-01-11T14:04:44.752Z",
  "type": "sh.keptn.event.mytask-silent.finished",
  "shkeptncontext": "e93cf888-7bed-4e61-bc96-c572222cc3dc",
  "triggeredid": "8b4ff55c-7b83-4711-8219-28fbb54552f2"
}

Expected behavior

Once there is a request that could not be executed, the webhook-service stops calling the other requests and returns a task.finished with result=failed including a message: "Error when executing the 1. request of the webhook configuration"

This occurred in Keptn 0.10. This might be already fixed in newer versions of Keptn.

Duplicate of https://github.com/keptn/keptn/issues/5729