[Bug]: Unable to use costumized dataset following anomalib tutorial

Describe the bug
I want to use a customized dataset and train reverse distillation. My dataset doesn't have binary masks. I followed the anomalib tutorial in: https://openvinotoolkit.github.io/anomalib/how_to_guides/train_custom_data.html
But I keep getting the error:
File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/folder.py", line 59, in make_folder_dataset
assert normal_dir.is_dir(), "A folder location must be provided in normal_dir."
AssertionError: A folder location must be provided in normal_dir.
Even if I'm providing a folder as input to the parameters. I also tried with the hazelnut_toy dataset provided by anomalib and I keep getting the same error
Dataset
Other (please specify in the text field below)
Model
Reverse Distillation
Steps to reproduce the behavior
I followed the tutorial in: https://openvinotoolkit.github.io/anomalib/how_to_guides/train_custom_data.html

I took the config.yaml of the model reverse distillation
I modified the dataset config in order to use a customized dataset
I keep getting the following error: AssertionError: A folder location must be provided in normal_dir  even if I'm giving folders as input

I also try to use hazelnut_toy dataset to recreate the same configuration of the tutorial and I keep getting the same error.
OS information
OS information:

OS: [e.g. Ubuntu 22.04]
Python version: [e.g. 3.10.8]
Anomalib version: [e.g. 0.6.0]
PyTorch version: [e.g. 2.0.1]
CUDA/cuDNN version: [e.g. 12.1]
GPU models and configuration: [NVIDIA A100]

Expected behavior
I was expecting to train revers distillation with my customized dataset instead it seems like the code is not able to recognize that I'm giving a folder as input
Screenshots
No response
Pip/GitHub
pip
What version/branch did you use?
I used the following command: pip install anomalib[full]
Configuration YAML
dataset:
    name: hazelnut
    format: folder
    root: ./datasets/hazelnut_toy
    normal_dir: good # name of the folder containing normal images.
    abnormal_dir: colour # name of the folder containing abnormal images.
    task: classification # classification or segmentation
    mask_dir: null #optional
    normal_test_dir: null # optional
    extensions: null
    split_ratio: 0.2  # normal images ratio to create a test split
    seed: 0
    image_size: 256
    train_batch_size: 32
    eval_batch_size: 32
    num_workers: 8
    normalization: imagenet # data distribution to which the images will be normalized
    transform_config:
      train: null
      eval: null
    test_split_mode: from_dir # options: [from_dir, synthetic]
    test_split_ratio: 0.2 # fraction of train images held out testing (usage depends on test_split_mode)
    val_split_mode: same_as_test # options: [same_as_test, from_test, synthetic]
    val_split_ratio: 0.5 # fraction of train/test images held out for validation (usage depends on val_split_mode)
    tiling:
      apply: false
      tile_size: 64
      stride: null
      remove_border_count: 0
      use_random_tiling: False
      random_tile_count: 16

model:
  name: reverse_distillation
  lr: 0.005
  backbone: wide_resnet50_2
  pre_trained: true
  layers:
    - layer1
    - layer2
    - layer3
  early_stopping:
    patience: 3
    metric: pixel_AUROC
    mode: max
  beta1: 0.5
  beta2: 0.99
  normalization_method: min_max # options: [null, min_max, cdf]
  anomaly_map_mode: multiply

metrics:
  image:
    - F1Score
    - AUROC
  pixel:
    - F1Score
    - AUROC
  threshold:
    method: adaptive #options: [adaptive, manual]
    manual_image: null
    manual_pixel: null

visualization:
  show_images: False # show images on the screen
  save_images: True # save images to the file system
  log_images: True # log images to the available loggers (if any)
  image_save_path: null # path to which images will be saved
  mode: full # options: ["full", "simple"]

project:
  seed: 42
  path: ./results

logging:
  logger: [] # options: [comet, tensorboard, wandb, csv] or combinations.
  log_graph: false # Logs the model graph to respective logger.

optimization:
  export_mode: null # options: torch, onnx, openvino

# PL Trainer Args. Don't add extra parameter here.
trainer:
  enable_checkpointing: true
  default_root_dir: null
  gradient_clip_val: 0
  gradient_clip_algorithm: norm
  num_nodes: 1
  devices: 1
  enable_progress_bar: true
  overfit_batches: 0.0
  track_grad_norm: -1
  check_val_every_n_epoch: 2 # Don't validate before extracting features.
  fast_dev_run: false
  accumulate_grad_batches: 1
  max_epochs: 200
  min_epochs: null
  max_steps: -1
  min_steps: null
  max_time: null
  limit_train_batches: 1.0
  limit_val_batches: 1.0
  limit_test_batches: 1.0
  limit_predict_batches: 1.0
  val_check_interval: 1.0 # Don't validate before extracting features.
  log_every_n_steps: 50
  accelerator: auto # <"cpu", "gpu", "tpu", "ipu", "hpu", "auto">
  strategy: null
  sync_batchnorm: false
  precision: 32
  enable_model_summary: true
  num_sanity_val_steps: 0
  profiler: null
  benchmark: false
  deterministic: false
  reload_dataloaders_every_n_epochs: 0
  auto_lr_find: false
  replace_sampler_ddp: true
  detect_anomaly: false
  auto_scale_batch_size: false
  plugins: null
  move_metrics_to_cpu: false
  multiple_trainloader_mode: max_size_cycle

Logs
/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/config/config.py:275: UserWarning: config.project.unique_dir is set to False. This does not ensure that your results will be written in an empty directory and you may overwrite files.
  warn(
[rank: 0] Global seed set to 42
2023-07-24 15:05:07,560 - anomalib.data - INFO - Loading the datamodule
2023-07-24 15:05:07,561 - anomalib.data.utils.transform - INFO - No config file has been provided. Using default transforms.
2023-07-24 15:05:07,561 - anomalib.data.utils.transform - INFO - No config file has been provided. Using default transforms.
2023-07-24 15:05:07,562 - anomalib.models - INFO - Loading the model.
2023-07-24 15:05:07,562 - anomalib.models.components.base.anomaly_module - INFO - Initializing ReverseDistillationLightning model.
/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/torchmetrics/utilities/prints.py:36: UserWarning: Metric `PrecisionRecallCurve` will save all targets and predictions in buffer. For large datasets this may lead to large memory footprint.
  warnings.warn(*args, **kwargs)
2023-07-24 15:05:07,568 - anomalib.models.components.feature_extractors.timm - WARNING - FeatureExtractor is deprecated. Use TimmFeatureExtractor instead. Both FeatureExtractor and TimmFeatureExtractor will be removed in a future release.
2023-07-24 15:05:08,724 - timm.models.helpers - INFO - Loading pretrained weights from url (https://github.com/rwightman/pytorch-image-models/releases/download/v0.1-weights/wide_resnet50_racm-8234f177.pth)
2023-07-24 15:05:09,246 - anomalib.utils.loggers - INFO - Loading the experiment logger(s)
2023-07-24 15:05:09,246 - anomalib.utils.callbacks - INFO - Loading the callbacks
/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/utils/callbacks/__init__.py:142: UserWarning: Export option: None not found. Defaulting to no model export
  warnings.warn(f"Export option: {config.optimization.export_mode} not found. Defaulting to no model export")
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - GPU available: True (cuda), used: True
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - TPU available: False, using: 0 TPU cores
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - IPU available: False, using: 0 IPUs
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - HPU available: False, using: 0 HPUs
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - `Trainer(limit_train_batches=1.0)` was configured so 100% of the batches per epoch will be used..
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - `Trainer(limit_val_batches=1.0)` was configured so 100% of the batches will be used..
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - `Trainer(limit_test_batches=1.0)` was configured so 100% of the batches will be used..
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - `Trainer(limit_predict_batches=1.0)` was configured so 100% of the batches will be used..
2023-07-24 15:05:09,260 - pytorch_lightning.utilities.rank_zero - INFO - `Trainer(val_check_interval=1.0)` was configured so validation will run at the end of the training epoch..
2023-07-24 15:05:09,260 - anomalib - INFO - Training the model.
2023-07-24 15:05:09,466 - pytorch_lightning.utilities.rank_zero - INFO - You are using a CUDA device ('NVIDIA A100-SXM4-80GB MIG 1g.10gb') that has Tensor Cores. To properly utilize them, you should set `torch.set_float32_matmul_precision('medium' | 'high')` which will trade-off precision for performance. For more details, read https://pytorch.org/docs/stable/generated/torch.set_float32_matmul_precision.html#torch.set_float32_matmul_precision
Traceback (most recent call last):
  File "/home/clusterusers/cugwu/codes/cvl/./anomalib/tools/train.py", line 79, in <module>
    train(args)
  File "/home/clusterusers/cugwu/codes/cvl/./anomalib/tools/train.py", line 64, in train
    trainer.fit(model=model, datamodule=datamodule)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 608, in fit
    call._call_and_handle_interrupt(
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/call.py", line 38, in _call_and_handle_interrupt
    return trainer_fn(*args, **kwargs)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 650, in _fit_impl
    self._run(model, ckpt_path=self.ckpt_path)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1051, in _run
    self._call_setup_hook()  # allow user to setup lightning_module in accelerator environment
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1298, in _call_setup_hook
    self._call_lightning_datamodule_hook("setup", stage=fn)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1375, in _call_lightning_datamodule_hook
    return fn(*args, **kwargs)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/base/datamodule.py", line 102, in setup
    self._setup(stage)
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/base/datamodule.py", line 118, in _setup
    self.train_data.setup()
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/base/dataset.py", line 162, in setup
    self._setup()
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/folder.py", line 178, in _setup
    self.samples = make_folder_dataset(
  File "/home/clusterusers/cugwu/anomalib_env/lib/python3.10/site-packages/anomalib/data/folder.py", line 59, in make_folder_dataset
    assert normal_dir.is_dir(), "A folder location must be provided in normal_dir."
AssertionError: A folder location must be provided in normal_dir.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello. This could be happening since you are using relative path and your current working directory might be wrong. Are you inside root directory, where you also have datasets folder?

Oh, I see you installed using pip. Can you provide the code and commands that show how you call the training code?

Hi, even I use the full path instead of the relative one I still have the problem. For calling the training code I use:
python ./anomalib/tools/train.py --config ./anomalib/reverse_distillation_config.yaml

I also tried to re-install everything and instead of using pip install anomalib[full] I cloned the repo and did: pip install e .
But I still have the problem

Hello. Try setting the path to datasets/hazelnut and then run the program from inside the anomalib folder, so python tools/train.py...`

Thanks this last suggestion works!


Help and version flags

closes #38
opted for minor version patch, since although these are technically API additions, they relate only to the CLI in an informationally supportive role - e.g. there's not really any functionality being added, rather human accessible tooling

@mcollina please review 🙇

Beautiful! LGTM

merged and published :bowtie:


lowering failureThreshold to 1 for fluentd-papertrail

Based on finicky behavior we've seen with the papertrail plugin and fluentd, this lowers the failureThreshold to 1 for the fluentd daemonset's pods.

Bumped to 1.1.2.

Thanks!


Upgrade metrics to 4.0.7, add CachedHistogram

Upgrade codahale 3.x to dropwizard 4.0.7, which includes fixes for
histogram accuracy.
Fix high contention getSnapshot code by introducing caching for
histogram values used by AdaptiveOperationTracker. Calling
Histogram:getSnapshot is more expensive in recent versions of the
metrics library because of a lock taken for reservoir rescaling.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b9fa880). Click here to learn what that means.
The diff coverage is 94.89%.

@@            Coverage Diff            @@
##             master    #1319   +/-   ##
=========================================
  Coverage          ?   72.16%
  Complexity        ?     6480
=========================================
  Files             ?      470
  Lines             ?    37160
  Branches          ?     4681
=========================================
  Hits              ?    26815
  Misses            ?     9099
  Partials          ?     1246

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com.github.ambry.cloud/VcrServer.java
82.35% <ø> (ø)
8 <0> (?)

.../main/java/com.github.ambry/store/DumpLogTool.java
0% <ø> (ø)
0 <0> (?)

...rc/main/java/com.github.ambry.rest/RestServer.java
91.87% <ø> (ø)
13 <0> (?)

...main/java/com.github.ambry/store/DumpDataTool.java
0% <ø> (ø)
0 <0> (?)

...main/java/com.github.ambry.server/AmbryServer.java
79.02% <ø> (ø)
10 <0> (?)

....github.ambry/tools/perf/rest/NettyPerfClient.java
0% <ø> (ø)
0 <0> (?)

....github.ambry.router/AdaptiveOperationTracker.java
91.91% <100%> (ø)
29 <0> (?)

...n/java/com.github.ambry.utils/CachedHistogram.java
100% <100%> (ø)
3 <3> (?)

...ain/java/com.github.ambry/config/RouterConfig.java
97.75% <100%> (ø)
1 <0> (?)

....github.ambry.router/NonBlockingRouterMetrics.java
87.18% <87.8%> (ø)
62 <13> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fa880...c2c8a6b. Read the comment docs.


Blockquote text style

Is it possible to style Text inside the blockquote?

👍  Need that too

This is really quick and dirty but I used this rule:
styleChildren(child, style){
   let grandChildren = []
   if(_.isNil(child)){
     return child
   }
   if('props' in child && 'children' in child.props){
     if(typeof(child.props.children) != 'object'){
       grandChildren = child.props.children
     }else{
       grandChildren = _.map(child.props.children, (grandChild) => {
         return this.styleChildren(grandChild, style)
       })
     }
   }
   return React.cloneElement(child, {
     style: style,
     children: grandChildren
   })
 }
[...]
rules = {
    blockquote: (node, children, parent, styles) => {
      return (
         <View key={node.key} style={styles.blockquote}>
           {_.map(children, (child, index) => this.styleChildren(child, {color: 'red'}))}
         </View>
       )
    }
}

Then apply that like so
<Markdown rules={rules}>
{myMarkDown}
</Markdown>

Probably has a tonne of knock on effects by overriding all the style of all the child objects, but it's working for me so far!


Adding cocktail sort in Python

🚀 Feature
Implementation of cocktail sort in python.
Cocktail sort being a variation of bubble sort ,sorts an array alternatively from both sides as opposed to that of the former.Space complexity is O(1) and time complexity is O(n).
Have you read the Contributing Guidelines on Pull Requests?
yes
Motivation
To learn implementation of sorting algorithms in python
Pitch
Cocktail Sort traverses through a given array in both directions alternatively.

/assign


Incorporating Hive into CI/CD

Incorporating Hive testing into the Besu CI/CD --> GHA.

Solution / results need to be available to all Besu contributors

Note Fabio wrote a script that will spit out new failures since last time the script was run. We should be able to use GHA to run and possibly format the results.
(Also investigate then sending to sonarqube as a custom quality gate.)
Script uses sqlite and curl and that's about it.

closing this as we're going to handle this without directly integrating into Besu CI/CD


[FLINK-10257][FLINK-13463][table] Support VARCHAR type generalization consistently

What is the purpose of the change
The Blink planner generalizes multiple CHAR literals into VARCHAR. It seems likely that we will adopt this behavior in the future to prevent unwanted side-effects for users. This PR removes the exception in the SQL Client and updates the existing type generalization classes.
Brief change log
See commit messages.
Verifying this change
Manually tested.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Thanks @dawidwys. Merging...


Add FCREPO_DEVELOPMENT_CONTEXT environmental variable and SOLR_DEVELOPMENT_CORE

The VM uses the Ansible roles to provision so the fedora.yml what's in the californica repo doesn't quite match up. We need to parameterize the fedora.yml to take a customizable Tomcat context, while still using /rest as a default.
What's there:
vagrant@localhost:~/californica$ cat config/fedora.yml
development:
  user: fedoraAdmin
  password: fedoraAdmin
  url: http://<IP_ADDRESS>:<%= ENV['FCREPO_DEVELOPMENT_PORT'] || 8080 %>/rest
  base_path: /dev
test:
  user: fedoraAdmin
  password: fedoraAdmin
  url: http://<IP_ADDRESS>:<%= ENV['FCREPO_TEST_PORT'] || 8986 %>/rest
  base_path: /test
production:
  user: fedoraAdmin
  password: fedoraAdmin
  url: http://<IP_ADDRESS>:8080/fedora/rest
  base_path: /prod
vagrant@localhost:~/californica$ lynx http://<IP_ADDRESS>:8080/fedora/rest

We need something like: url: http://<IP_ADDRESS>:<%= ENV['FCREPO_DEVELOPMENT_PORT'] || 8080 %><%= ENV['FCREPO_DEVELOPMENT_CONTEXT'] || /rest (there is a separate ticket in californica for this: uclalibrary/californica#59).
Once this is done we just need to add the FCREPO_DEVELOPMENT_CONTEXT parameter to this Packer build.
Related #28

The main question I think is are there other Tomcat contexts other than Fedora in the Ansible build. If there are, we definitely need to parameterize the Californica config instead of the roles.

I think it's just best to update 'californica' to parameterize FCREPO_DEVELOPMENT_CONTEXT, with a default of '/rest'. Packer can override that to be 'fedora/rest'

The solr.yml also needs to be parameterized so Packer will need to supply the value for that parameter once that's done.

Bess made a good suggestion to just use a single parameter for port and context/core. Do that instead.


fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
patch
1.23.3 -> 1.23.5

terraform-ibm-modules/kms-all-inclusive/ibm (source)
module
patch
4.15.3 -> 4.15.4

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.17.1 -> 1.17.2

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.23.5
Compare Source
Bug Fixes

Set enforcement mode as disabled for EN by default, as SMTP API does not support report mode.(#497) (e76f4b4)

v1.23.4
Compare Source
Bug Fixes

mqcloud is removed from default target service list and fscloud doc is updated (#495) (5af76ee)

terraform-ibm-modules/terraform-ibm-kms-all-inclusive (terraform-ibm-modules/kms-all-inclusive/ibm)
v4.15.4
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#528) (2daf902)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.17.2
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#175) (79f9f8d)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This issue has been resolved in version 1.17.1 :tada:
The release is available on:

GitHub release
v1.17.1

Your semantic-release bot :package::rocket:


The Road to Stable

The Road to Stable
Background
RFC #0779: First-Class Component Templates picked one of the formats from this repo as the the ability for Ember (and Glimmer) developers to write components with template tags embedded in their JS, like so:
import Component from '@glimmer/component';

const Button = <template>
  <button
    type='button'
    class="my-button"
    {{on "click" @onClick}}
  >
    {{@label}}
  </button>
</template>

export default class Player extends Component {
  @tracked isPlaying = false;

  play = () => (this.isPlaying = true);
  pause = () => (this.isPlaying = false);

  <template>
    <audio src={{@srcUrl}} {{playWhen this.isPlaying}} />

    <Button @label="Play" @onClick={{this.play}} />
    <Button @label="Pause" @onClick={{this.pause}} />
  </template>
}

This is not only a general win for ease of working with Ember: it is also a key part of our TypeScript story, because it makes things like go-to-definition, documentation hovers, autocomplete, auto-import, etc. all much easier to manage. So: what do we need to do to finish unblocking its adoption?
Work to be done
There are only three fundamental blockers to adoption:[^spec]

[x] Prettier support.
[x] ESLint support.
[x] ember-template-lint support.

[^spec]: Beyond this, the specification working group is also working on nailing down what we want the exact design constraints for <template> tags (as well as any other future tags in the same direction), which we expect to publish as  and we take that design to be a blocker for making it the recommended and default experience for Ember developers, but not a blocker for folks adopting and using it.
Prettier support
Thanks to @wondersloth at LinkedIn, there is an existing Prettier plugin for one of the alternatives to the final first-class component templates design, which used hbs tags (like you see in tests), as used by Play/Glimmer. You can find that here. In this case, the work to be done is building on that and using the preprocessor from ember-template-imports to get the contents of the template, with the existing indentation, run Prettier on that, apply appropriate indentation, and replace it in the <template> tag.
ESLint support
This is really two things:

Help land this PR by @NullVoxPopuli (who would welcome the help)! It may be helpful to compare with the eslint plugin for GlimmerX, which works with hbs tagged template literals and would need similar updates as the Prettier plugin, but may be useful input.

See the next section about ember-template-lint: we want to basically make ember-template-lint an embedded ESLint reporter.

ember-template-lint support
For ember-template-lint, we need to integrate it with ESLint, so that from the end user’s perspective, they just have one linter giving them feedback on their.
There is a branch of this work started here, but again, @NullVoxPopuli does not currently have time to finish it and would love help!

compare with the eslint plugin for GlimmerX, which works with hbs tagged template literals

To catch folks up,
I started with this, and didn't find it all that useful.
In the eslint plugin, the current approach is:

preprocessor (emit strict mode raw format to eslint, so native eslint can run normally)
postprocessor (process the messages from eslint running normally to map back to the line/column in the original source)

pre/post processors run "automatically" based on file extension when a plugin provides a file extension<->processor mapping
(more information in the already linked PRs)
Thanks, @chriskrycho !!

Thanks for the clarification – that’s super helpful!

Thanks to @ventuno, we have ember-template-lint support!
Thanks to @gitKrystan, we have Prettier support!
Thanks to @NullVoxPopuli, we have ESLint support!

I’ll make sure we follow up on this in one of the next few Framework Core team meetings—this is amazing progress, and represents a huge step toward stabilizing this and eventually making it the recommended way of writing Ember templates.
(Keep your eyes open for code-mods coming soon™!)

This is done. We will keep polishing, but all the hard blockers are wrapped; now we need to (a) do that polish work, (b) write an RFC for route templates, and (c) start the path to documenting it as a supported path (though not yet a recommended one).


chore: use fluvio 0.11.8

in order to make CI happy I added this:
https://github.com/infinyon/mqtt-connector/blob/82a70705af68b9604de1edff0f9925fe1e9c777f/.github/workflows/ci.yml#L91

Probably we can remove that line so we use stable now. And maybe we can remove all the k3d usage and use local instead like we do in the other connectors

Could you update this line too:
https://github.com/infinyon/mqtt-connector/blob/82a70705af68b9604de1edff0f9925fe1e9c777f/Connector.toml#L6

Gotcha! Sure thing!


EK-410: Stopped including pubs that have a status other than "published"

Test:

We only display publications that have been Published.  Submitted and accepted publications are no longer displayed.
The status, type, and dash at the beginning of each publication is no longer displayed.  It should start as [elem.lname], [elem.fname.substr(0,1)]. ([elem.dty_pub]). ......

Compare with production https://faculty.stevens.edu/oasan
This user has all 3 statuses currently being displayed.

Test procedure should include a link to a profile that showcases the change. Best to find some profile that, in production currently, contains a mix of all 3 statuses, so we can see that publications matching 2 of the 3 status are omitted in the deploy preview.

Test procedure should include a link to a profile that showcases the change. Best to find some profile that, in production currently, contains a mix of all 3 statuses, so we can see that publications matching 2 of the 3 status are omitted in the deploy preview.


Implements :origin field to Secret struct

Finishes the third task from #1621

I'll add more tests for the Grant Access and Missing Secret features, just to make sure about future changes


Release a new major version after PR #349

Seems like that #349 considerably changed the way to use .env values in iOS build settings/info.plist file. It might be a good idea to release the version of the lib with these changes, as installation instructions in current readme.md won't work for the most recently published NPM package.

As a stop gap measure, I've installed the specific commit on master right now (89a602bf8be3808838403a97afaf915caeec76c2) directly from GitHub and it's working on both Android and iOS. Tested the Info.plist iOS modifications and those are also working on master.
Obviously installing directly from GitHub isn't recommended but as a temporary measure, anyone who needs these latest changes can run:
yarn add react-native-config@"luggit/react-native-config#89a602bf8be3808838403a97afaf915caeec76c2"

It would really help to have a new release. I got stuck for a day trying to solve the "'GeneratedDotEnv.m' file not found" until I installed from github

@erwann-miriel-nv add in the script found here-  https://github.com/luggit/react-native-config/issues/365
I forgot to do pod install and ended up back here, sure it will happen again with this library.

@pedro @jordanbrown @erickreutz can someone please make an npm release or fork this package, what's the point of merging PRs and then not releasing an update?

Oops, sorry for the delay folks, 0.12 has been released with #349.
For updates on repo ownership and updates follow #382.
Thanks!


Getting a list of all users in a subscription

How can I get all users with access to a subscription along with there role (i.e., contributor, reader, etc.)?  I thought using --all would do the trick, but it provides info only for my identity.  Given I am the administrator and owner of the subscription I could get the info.  Similar to what I see in the portal when I view the IAM for the subscriotion.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9dacfad8-cb2f-2534-3b29-89b0930a2252
Version Independent ID: 17325cd4-44c5-4069-d9f6-940a55f0f7c9
Content
Content Source
Service: azure-resource-manager

Okay "az role assignment list" does work.  I was viewing a subscription with only I as the user.

@marjorienorm glad that worked for you!


Rename the BedBlock.isOverworld method to isBedWorking

Fixes #2645

Documentation should be added to the method in DimensionType.


MappedGene Associations - Rest endpoint to get all associations resources associated to a given Mapped Gene

As developer
I want an api endpoint
So that when I send a GET request, hateoas, paginated list of all associations associated to a given Mapped Gene in the database is returned in JSON Format
Management Rules:
Rule 1: Endpoint - /v2/genes/{genesId}/associations
Rule 2: HTTP Request Method - GET
Rule 3: HATEOAS, with filer, sorting, pagination, and sizing
Rule 4: Endpoint should accept filter, and sort parameters as in /associations?mapped-gene=...&page=0&size=20&sort=...
Rule 5: Search filter should be available for: variant-risk-allele, p-value-annotation, mapped-gene, reported-trait, efo-trait, background, accession, location
Rule 6: Sort feature should be available for: p-value, p-value-annotation, raf, or, beta, location, Optional Sorts (reported-trait, efo-trait, background-trait)
Rule 6: Returned Study Json entity must include: Variant and risk allele, P-value, P-value annotation, RAF, OR, Beta, CI, Mapped gene, Reported trait, Trait(s), Background trait(s) , Study accession, Location
Acceptance Tests:
Given no parameter
When the front end sends a GET request to the endpoint
Hateoas compliant list of studies is returned in the specified JSON Format
Given sorting, pagination, and/or some search and filter parameters
When the front end sends a GET request to thesame endpoint
Hateoas compliant filtered list of studies satisfying the conditions in the url parameter must be returned

Hi @ala-ebi  The API details are as follows -:
Uri -: http://gwas-snoopy.ebi.ac.uk:9780/gwas/api/v2/genes/{geneId}/associations
Sort & Search params same as other Association entries


Disable vault and cluster-service rules for CAPO and CAPV

Towards https://github.com/giantswarm/roadmap/issues/640
We don't install cluster-service into CAPO and CAPV clusters. We don't have vault machine as well. We deploy vault into MC now. Vault monitoring will be supported soon but we need to disable those now.
Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
[ ] Alerting rules must have a comment documenting why it needs to exist.

@QuentinBisson I tested by setting managementCluster.provider.kind to kvm and openstack.


python scripts for extracting text from pdf files

initial commit

No conflicts with the base branch. Okay to merge.


Fix to Issue #25 - Not found error on iterator when over 1000 volumes

I ran into this issue as well and found what appeared to be a missing / on line 561 of common.py and removed an issue on line 1331 of provisioning.py that looks for ['result'] but that attribute doesn't actually exist.  This path only gets exercised if your have multiple pages of data, which is why it worked for 1000 items or less.  Tested these changes in my local environment successfully on a system with >1000 vols and one with <1000 vols and it works.

Sorry, I forgot to update on this case.
@mrhorrible78 Thank you very much, this has resolved my issue.

Closing pull request, no unit tests included. For all pull requests please include unit tests and ensure all are running clean.
Will add the above fixes myself with tests


Unable adding identity when no identity initially provided

Using docker.sunet.se/dc4eu/apigw:latest sha256:86501d0238553b509fe8780ef6749d31e937bf0d903476921610cd73266af03d created 2024-07-19T12:56:59.73451228Z
After uploading a document with minimal number of values, e.g.:
{
    "document_data": {
        "xfztruFXD": {
            "GG3iMeN": null
        }
    },
    "document_data_version": "508.538.858",
    "document_display": {
        "description_structured": {
            "en": {
                "en": "European Health Insurance Card"
            }
        },
        "type": "ZQW9gpwm",
        "version": "308.491.421"
    },
    "identities": [],
    "meta": {
        "authentic_source": "wQnlkS",
        "collect": {},
        "document_id": "sY1NyEj7Bsu70xk9d5J1TLpfeeJfada",
        "document_type": "PDA1",
        "document_version": "773.25.35",
        "real_data": false
    }
}

requesting to add an identity, e.g.:
{
    "authentic_source": "wQnlkS",
    "document_id": "sY1NyEj7Bsu70xk9d5J1TLpfeeJfada",
    "document_type": "PDA1",
    "identities": [
        {
            "authentic_source_person_id": "dWOTXYf1nFrtFi7ofb3b360Ykpqzo",
            "birth_date": "2175-08-06",
            "family_name": "Doesburg",
            "given_name": "Lamberto",
            "schema": {
                "name": "SK",
                "version": "650.819.504"
            }
        }
    ]
}

fails with:
{
    "error": {
        "title": "internal_server_error",
        "details": "write exception: write errors: [Cannot apply $addToSet to non-array field. Field named 'identities' has non-array type null]"
    }
}

I think this is related to the latest image, since the latest (now) does not support multiple identities. Please make the same requests to tag api28 and report back.

Do you mean: "image: docker.sunet.se/dc4eu/apigw:api28" in the docker-compose file? If so, I get:
"Error response from daemon: manifest for docker.sunet.se/dc4eu/apigw:api28 not found: manifest unknown: manifest unknown"

My bad, the path should be docker.sunet.se/dc4eu/apigw:apiv28

Should be solved with https://github.com/dc4eu/vc/commit/fbb5f520c817228b1344115139135beec5d40e45
use docker tag apiv28


EDB: Allow padstack plating thickness to be changed

Description of the feature
pyaedt.edb_core.EDB_Data.EDBPadstack Via plating attribute
EDBPadstack.hole_plating_thickness
is read-only.
Please add function to change the plating thickness of padstacks
Steps for implementing the feature
Either create a new setter function or adjust
EdbPadstacks.set_pad_property
Useful links and references
No response

Implemented


How to generate low-beam data？

It is mentioned in the paper that we need pseudo low-beam data generated from high-beam ones.
Does this project include the code to generate low-beam-data?

I found it.
It‘s in kitti_dataset.py
function porcess-single_scene


Load plugins

This change allows the use of plugins such as https://github.com/isri-aist/MujocoTactileSensorPlugin
I just copied part of https://github.com/deepmind/mujoco/blob/main/simulate/main.cc, but it may be modified to fit this project if necessary.

Just as Choreonoid automatically loads plugin libraries in the directory of the environment variable CNOID_PLUGIN_PATH, I think it may be a good idea to introduce MUJOCO_PLUGIN_PATH.

Hi @mmurooka san! I'm unable to play the video file in the README. What does the tactile sensor do? Is it different from the touch sensor introduced recently?

Hi @rohanpsingh I've updated the video so you can play it now. My plugin (MujocoTactileSensorPlugin) is implemented based on the touch grid plugin in the MuJoCo repo, with the following differences.

The touch grid plugin handles the contact forces in a site frame common to all sensor patches, whereas MujocoTactileSensorPlugin handles them in the frame of each sensor patch to accurately simulate tactile sensor measuring normal forces.
Supports both square and hexagonal grids for sensor arrays (I'm thinking of simulating a hexagonal grid sensor.)
Sensor values can be published as a ROS topic.

Anyway, this PR is intended to allow general plugins, including those in the MuJoCo repo, to be used with mc_mujoco.

Just as Choreonoid automatically loads plugin libraries in the directory of the environment variable CNOID_PLUGIN_PATH, I think it may be a good idea to introduce MUJOCO_PLUGIN_PATH.

I've updated it in this way.
The following is a use case of this PR. By loading the MujocoRosUtils::PosePublisher plugin in mc_mujoco with this PR, when running LocomanipController in mc_mujoco, the pose of the cart model is obtained via ROS topics.
https://github.com/rohanpsingh/mc_mujoco/assets/6636600/7567c53a-d372-479d-b540-ce6e03a7c7e8

Hi @mmurooka
This looks good to me. However, may I ask that you consider the following:

Consider using a configuration entry in mc_mujoco.yaml to define the search path (that would complement the MUJOCO_PLUGIN_PATH environment variable)
Maybe rename MUJOCO_PLUGIN_PATH to MC_MUJOCO_PLUGIN_PATH such that there's no confusion about it
Add some information in the README about the functionality

Thanks

Hi @gergondet  Thanks for your comment. I think I have addressed all of them. I have eliminated support for the environment variable because I began to feel that it fits better with the concept of mc_rtc. Feel free to modify the entry name, doc, etc.

I have rebased the commits to eliminate the changelog in main.cpp.


PostInstall issues

We started noticing jenkins errors when running the postinstall build of foundationpress:
<EMAIL_ADDRESS>postinstall /var/www/app
bower install && grunt build
[ERROR]: module.js:340
[ERROR]:     throw err;
[ERROR]:           ^
[ERROR]: Error: Cannot find module 'imurmurhash'

This was working as of two weeks ago. For now, we have commented out the postinstall. Suggestions?

What version of Node.js are you on? (Type node -v in your terminal to get your version number)
You can try
rm -rf node_modules
npm install

Because of lack of response, I would assume that this is now resolved.


Model evaluation

Hi, I've tried to evaluate your model with scibert pico data set, but the tokenization wasn't the same, could you please share the F1 score you get?

Hi @miladnouriezade. Thank you for your interests. The performance of a part of the entity classes including PICO is listed below (note that we have a new set of attribute categories for PICO and delete the original "modifier" and "measure". we will release our new version in the future):
Intervention: precision:  69.14%; recall:  73.68%; FB1:  71.34
Observation: precision:  70.54%; recall:  80.53%; FB1:  75.21
Outcome: precision:  71.51%; recall:  78.85%; FB1:  75.00
Participant: precision:  58.11%; recall:  70.49%; FB1:  63.70


Reformulate ConservationChecker

ConservationChecker is the last module dependent on component model specific data structures (e.g. integrator.u.... ).

[ ] remove dependencies on data structures in ConservationChecker module
[ ] apply in unit tests
[ ] apply in the AMIP driver

QA

[ ] no behaviour changes
[ ] negligible changes/ improvements on performance

this is completed via #436


ci: Update release workflow

Automate the release workflow.
Use Reusable workflows instead of workflow_dispatch. This will enhance the usability of e2e pipeline.
Remove unnecessary jobs.
Fix goreleaser to pick the current tag.
Add option to update k8s version for upcoming pipelines.
Add markdown link check workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.38%. Comparing base (0686a78) to head (30796f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   77.38%   77.38%
=======================================
  Files           3        3
  Lines         252      252
=======================================
  Hits          195      195
  Misses         56       56
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Inconsistent regularization loss computation when used with pretrained models.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Google Colab Environment
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): Binary (Colab Pre-installed)
TensorFlow version (use command below): 2.4.0-nightly
Python version: 3.6.9
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A (Colab CPU Environment used)
GPU model and memory: N/A

Describe the current behavior
I am trying to use MobileNetV2 pretrained model for a simple classification task. Here I want to add regularization loss for MobileNetV2 - base model along with added FC layers. I have conducted 3 experiments as per attached colab notebook, where I get different results for the computation of regularization loss. The MobileNetV2 regularizer loss is computed twice in the model. And I dont know why it happens.
Describe the expected behavior
The computation of the loss in all the experiments should be same.
Standalone code to reproduce the issue
Colab Link : https://colab.research.google.com/drive/1CeKMIAq_g0AOKdakupKIeUjEhkL_TtI1?usp=sharing
Other info / logs

I have tried the same on TF2.2 but got the same behaviour.
I have got the reference of this: issue-37511 for adding regularization loss into pretrained model.

Was able to reproduce the issue with TF v2.2 and TF-nightly. Please find the attached gist .Thanks!

Was able to reproduce  the issue with TF 2.5 and Nightly versions.Please find the gist here.Thanks!

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Suppress null pointer deref warnings

This is a known issue with bindgen under heavy discussion, but doesn't look like it will be resolved soon. This attribute suppresses genuine warnings about undefined behavior in a pattern generated by bindgen many, many times. It should be removed when the bindgen issue is resolved.
Until then, it obscures other helpful warnings and errors.
See: rust-lang/rust-bindgen#1651

Thanks for helping clean up the build!  Quickly read through that issue and something tells me that #![allow(deref_nullptr)] will be in there for a while...

Nice, thanks! Anyone have any idea of ways to get reminded to check on that issue from time to time? It's so easy to forget these TODOs exist.

I looked but couldn't find any. Within the language itself, every single function has required doc annotations that hint at it being possible. There, a feature is either stable and lists the "since" semver of the release it was stabilized in OR it's unstable and lists the issue number where the feature is being discussed. I couldn't identify a way to use those issue tags in code by mere mortals though.


documentation: Removed mui components and imports.

description: Is your feature request related to a problem? Please describe.
There are mui components imports in files like CoreButton.docs.js, CoreAvatar.docs.js, CoreSwitch.docs.js and CoreRating.docs.js.
Describe the solution you'd like
Removed mui imports from the file.

closing since it's done


Add block to viewer.show

Description
as per https://forum.image.sc/t/wait-for-napari-window-to-close-to-advance/52328/3
this adds a block parameter to napari.run() that will block even if ipython has the event loop.  It seems to work ok in ipython, but when I try in jupyter, it works the first time, but any subsequent cells after using block=True seem to hang indefinitely

worth adding again:
a much more natural approach here (at least as far as the qt part is concerned) would be to attach the blocking behavior to the viewer.window itself (via viewer.show()) rather than trying to add another level to the global event loop:
# so rather than this
viewer = napari.Viewer()
napari.run(block=True)

# we would have this:
viewer = napari.Viewer()
viewer.show(block=True)

where block=True would be the equivalent of QDialog open or exec instead of show...
but, I can't see a way to extract ourselves from the Viewer(show=True) problem without a pretty big breaking change...  I guess we could put block=True on the viewer itself?

unless @tlambert03 you've had more ideas here too.

nope, this is a decent start as far as I'm concerned


Ruby group capstone: set up your Kanban board

Hello, We are 3 in this group my partners
@romans-adi Team Member #1
@mrcbq Team Member #2
@lincoln1883 Team Member #3

[x] This is the link to the Kanban https://github.com/mrcbq/catalog-of-my-things/projects/2

Hi @mrcbq, @romans-adi , and @lincoln1883
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights
📌 Descriptive issue✅
📌 Great working on the set up of the project board✅
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add a callback when list reaches the end

Thanks for this Great package, I would like to propose two feature

[ ] add a callback when the list reaches the end.
Perhaps you could add an onScrollEnds callback.
[ ] Add a configurable scroll offset parameter with default offset of 100

https://github.com/burhanrashid52/marquee_list/blob/e7e5e2973292bb24c1dcacbb8c28783ebfe8e16c/lib/marquee_list.dart#L89
And a suggestion to add Tests, it will help maintain the package in the long run. If you would like I can contribute to this issue.

Thank you. I like the offset idea and testing is something I have in mind but have not implemented yet. If you want to contribute, I am happy to review the PR.
Also, on the onScrollEnds part, I am trying to understand what use case it will solve?
I am also planning to add ScrollMovement.forward/backward for the scroll to move.

I can't think of the exact use case on top of my mind atm, but imagine onScrollEnds User might want to show some interaction or redirect to a different page

@maheshmnj Would you like to contribute the suggested feature you mention in this issue ?

Sure will send a PR tonight.

@burhanrashid52 @maheshmnj as the PR has landed to the main, this issue should be closed :)

@AbhishekDoshi26 This issue have 2 tasks, out of which 1 is still remaining.


Show usage of memory maps in Pregel status

Scope & Purpose

[ ] :hankey: Bugfix
[x] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)
[ ] Backport for 3.7: (Please link PR)

I merged these changes into #16332


rtabmap/rtabmap_ros: 0.20.18-1 in 'noetic/distribution.yaml'

Increasing version of package(s) in repository rtabmap rtabmap_ros to 0.20.18-1:

upstream repository: https://github.com/introlab/rtabmap.git, https://github.com/introlab/rtabmap_ros.git
release repository: https://github.com/introlab/rtabmap-release.git, https://github.com/introlab/rtabmap_ros-release.git
distro file: noetic/distribution.yaml

Same comment as https://github.com/ros/rosdistro/pull/31952#issuecomment-1024855926
These should preferably be released via Bloom.


Romanesco plugin directory does not exists

I checked out current master and followed instructions in RTD. Ran into this issue:
Traceback (most recent call last):
  File "/home/chaudhary/tools/minerva/src.git/girder/utility/plugin_utilities.py", line 80, in loadPlugins
    plugin, root, appconf, apiRoot, curConfig=curConfig)
  File "/home/chaudhary/tools/minerva/src.git/girder/utility/plugin_utilities.py", line 122, in loadPlugin
    pluginParentDir = getPluginParentDir(name, curConfig)
  File "/home/chaudhary/tools/minerva/src.git/girder/utility/plugin_utilities.py", line 104, in getPluginParentDir
    raise Exception('Plugin directory %s does not exist' % name)
Exception: Plugin directory romanesco does not exist

What step produced this?

Just running girder master with minerva plugin
python girder


Remove prototype chart

Remove the prototype chart and rename the wip-catalog chart to catalog.

@vaikas-google nits addressed

General comment-- I'm finding the "knobs" documented in the README.md to be a bit confusing. It's broken down into three sections: deployment knobs, catalog knobs, and apiserver knobs. These three headings are like comparing apples to oranges to bananas. "Deployment" (an overloaded term) could refer to a k8s deployment object or it could refer to global options for the whole catalog. But if it's the latter-- isn't that what's expressed in the catalog section? And then apiserver is component-specific options? If so, where then is there a controller config section? Respectfully, I think this needs to be cleaned up a lot, because it's confusing right now.

We should also include a default values.yaml because it's commonplace for people to use that as a template for whatever customizations they wish to apply and preserve:
$ helm inspect values <chart> > values.yaml
# edit values.yaml and push it to your own source control
$ helm install <chart> --values values.yaml

Ok... after I registered many, many comments here, @pmorie and I discussed offline. We're really going to treat this like just a move, and given my previous experience in writing Helm charts, I'm going to open an issue for general cleanup of the chart and assign it to myself.
LGTM

#517 will take this the rest of the way.


Deleting an inference Service occasionally does not delete the knative service

kfserving version 0.6.0
knative serving version 0.24.0
Occasionally and randomly, I delete an inference service but all the knative components such as the knative service, configuration, revision, route and deployment hang around and do not get deleted.
The inference service was deleted for sure with no problem. I attempted to delete the knative service but it would recreate over and over although the inference service no longer exists.
I haven't been able to identify a pattern. This seems to happen randomly. The only way I was able to get rid of the knative service is by editing the owner references on it and setting blockOwnerDeletion: false

Closing this issue as it is too old


say Command

Unable to type message containing "/". For example if I need to tell someone, I type "You need to type /rule or /help" But I can't do that anymore.

Not really a rocket bug, the say command is in built in command, and it was modified, in the most recent update to unturned, to allow colors to be used on the command, but that means that you can no longer put anything in the command to say that contains a slash.

Added broadcast to prevent this, syntax is /broadcast "My Message" red

fr34kyn01535 can you put config to have a default RGB vaule for the text?


Seek to time with tolerance method deprecated in iOS 11

This method without a completion handler has been deprecated:
func seek(to time: CMTime,
          toleranceBefore: CMTime,
          toleranceAfter: CMTime)

In AVPlayerItem, Apple writes:

Use -seekToTime:toleranceBefore:toleranceAfter:completionHandler:, passing nil for the completionHandler if you don't require notification of completion.

Proposed Solution
Offer a new method on Player:
func seek(to time: CMTime,
          toleranceBefore: CMTime,
          toleranceAfter: CMTime,
          completionHandler: ((Bool) -> Swift.Void)? = nil)

This would continue to support use of the method without a completion handler as well.

commit cabf0893f0ac9ae89ec3d305a0a8d6a586bf37d8
Author: patrick piemonte<EMAIL_ADDRESS>Date:   Wed Sep 27 23:17:37 2017 -0700
Player, remove deprecated API (via dmzza)

https://github.com/piemonte/Player/pull/175


[G1-5164] Squash Merge commits

https://swicloud.atlassian.net/browse/G1-5164
Summary of changes:
I executed below script to create the PR. This is a tryout to squash the previous merge commit.
`
#!/bin/bash
git fetch origin
git checkout master
git pull origin master
COMMIT_BEFORE_MERGE=33805aab6d093b08d360520255e684126c5314db
git checkout -b clean-master $COMMIT_BEFORE_MERGE
git rev-list --reverse $COMMIT_BEFORE_MERGE..master | while read commit
do
if [ $(git rev-parse --is-merge $commit) = true ]; then
git cherry-pick -m 1 $commit || { echo "Conflict in merge commit $commit. Please resolve manually."; exit 1; }
else
git cherry-pick $commit || { echo "Conflict in commit $commit. Please resolve manually."; exit 1; }
fi
done
git push -u origin clean-master
echo "Now create a PR from clean-master to master on your Git hosting platform."
`

This solution doesn't work for squashing the commits. hence closing


Support for omitting input fields

The docs say this:

This behavior is temporary and will be improved soon by introducing input: true option to @TypeGraphQL.omit.

I just want an issue so I can track when this is done. I am not sure I would want to use this tool until it is, as it exposes write privileges to all fields to the world (eg; nobody should be able to arbitrarily write password field).

I'm running into a missing feature that I think could be part of the "omit input fields" spec: the ability to restrict nested relation input fields to just connect, without create / createMany / connectOrCreate. Something like @TypeGraphQL.restricted(input: ["connect"])
@MichalLytek what do you think? Happy to create a separate issue for it if you think it's outside the scope of this one.

We also would like the ability to omit input values and control nested relations.

A similar use case for related input fields, we are injecting an authenticated user via express middleware into the graphql context.
Omitting input fields - we'd like to omit several internal fields and relationships

Initial support based on @hirotachi PR #135 has been added in e7a1184 🚀

the ability to restrict nested relation input fields

@dickfickling Please create a new feature request issue. I'm closing this one 😉


fix a iframeUpload bug

This bug make iframeUpload always upload the first time picked file, for example:
You open the page in a browser only support iframe upload,
first time, you want to upload 'tree.jpg', so you pick it, then 'tree.jpg' upload automatically, it's good;
after that, you want to upload 'flower.jpg', so you pick it, but the bug make 'tree.jpg' upload again. (actually you couldn't upload any other file without refresh)
Reason:
iframeUpload clone and replace the input file element with a new one, but when change event trigger, the fileInput in callback is point to the old one.

is a merge possible ?

Yes I can merge this.
Can you please squash you commits into one first :)

I send a new pull request, close this one

You don't have to close the pull request, as long as you push to the same repository and branch, github will recognize that it belongs to this pull request and update it.


Unable to log into account on pypi.org and test.pypi.org

Every time I try to log into the web-based account, I get a "user not found" error.

I tried many things.
What I did:

Created an account at pypi.com with the email address<EMAIL_ADDRESS>DID NOT click on the verification email (missed it)
Tried logging in, and got the above error.
Tried resetting password. Succeeded and got into the account. I logged out.
Tried logging in, and got the above error.
Tried various things, the exact order of which I do not remember. This included changing the password internally, doing more password resets. I've manually typed in the password, and used my 1Password password manager. Always met with same results.

I also am experiencing the same issue on test.pypi.org. I even went as far as completely deleting my account, signing up from scratch, and correctly verifying my email address. I get the same error.

Hello @koliber! Logins to PyPI are performed with the username specified at signup not email addresses.
Does this help you?

That's it!  I wrongly assumed it's the email address.


Suppress prefer-const warnings for $props() and $derived()

I'm not sure what mechanism is being used to suppress prefer-const warnings for variables that have bind:s in the template, but these warnings should also be suppressed for $props() and $derived(). Using a const for a $derived() feels like a weird thing to force on people, and a mixture of bindable and non-bindable $props() can cause more serious issues where ESLint will encourage components that can't be compiled - https://github.com/sveltejs/svelte/issues/13897

A workaround for props is using the destructuring: all option in prefer-const for Svelte files.

I'm also encountering this with $derived() and $derived.by().

Fixed by https://github.com/sveltejs/eslint-plugin-svelte/pull/933


[Extensions] Add Play/Pause icon for meshmap

Signed-off-by: suod-NithishKarthik<EMAIL_ADDRESS>Description
This pr adds dependency required for #270
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4155 (ec141b1) into master (ef465ce) will decrease coverage by 7.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4155      +/-   ##
==========================================
- Coverage   26.87%   19.18%   -7.70%
==========================================
  Files          59       59
  Lines        5031     5031
==========================================
- Hits         1352      965     -387
- Misses       3264     3771     +507
+ Partials      415      295     -120

Flag
Coverage Δ

e2etests
?

gointegrationtests
?

integrationtests
?

unittests
19.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
0.99% <0.00%> (-53.32%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.85% <0.00%> (-36.76%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.78% <0.00%> (-32.15%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c85b5...ec141b1. Read the comment docs.


docs(tls): 3.0 defaults to tls enabled

Resolves #5608
Signed-off-by: Tianchu Zhao<EMAIL_ADDRESS>Checklist:

[x] My organization is added to USERS.md.

thank you!


hyper::header::Cookie not hashable

From what I can see hyper::header::Cookie provides cookies as separate "key=value" element, but there is no way to access the keys directly (let me know if I'm missing something here). I think there would be value to provide a way to access Cookies directly bye keys right in hyper rather than as a separate crate.
Are there reasons for not providing this? Is it worth adding a PR for it? Should this be done as part of hyper::header::Cookie, or as a separate struct (say hyper::header::hashedCookie)?

I assume you mean that there isn't a way to store and access cookies by their name. That's correct, it is likely out of scope for hyper. There is a lot of good work in the cookie crate.

Cookies are key to web server/client communication.
I agree that session management, keeping track of cookies etc... is out of scope for hyper, and as noted the cookie crate does a great job for this. But I think that any apps running on top of a web server will eventually need to look at cookies from requests, for all kind of reasons, and  for things simpler than session management. If splitting on the equal sign and provide a map to the cookies is out of scope, why wasn't splitting on the semi-colon and provide individual cookie "strings" not out of scope.
The effort to add this seems minimal, it's basically one struct and a couple of methods,. I'm happy to add a PR for this. Let me know your thoughts.

Hyper actually used to depend on the cookie crate, and so you would have Cookie structs that you could poke at. The dependency was removed because cookie had an optional dependency of openssl, which caused a lot of problems. I recall discussion of eventually removing that.
I wouldn't say that parsing the cookie string into a struct with name and value and such is necessarily out of scope, but anything more than that likely is.

This is being revisted in #1145.


Placeholder shrinks after leaving textField

Just updated to version 1.0.3 and this started to happen...
When I leave the textfield with some text inside, it shrinks the placeholder

No code changes were made by me

Same here.

I tested 1.0.4 version now and it is still shrinking in some cases after I set the field content and set focus on another text field. It seems its also losing the padding that I previously set on my appDelegate.

Here is what I have in custom code for the textField class:

And in my app delegate:


Create a Kubernetes cluster with Azure Kubernetes Service and Terraform - Example does not work

Related: #5284
This issue has implicitly already been reported in this comment but I'd like to open a separate issue for this problem

When following the example and calling terraform apply, the example does not work and the following error gets returned (note that the docs contain a 2nd problem at the problem as well, a fix for the 2nd issue is already proposed in PR #35133 already)
Error: operationalinsights.WorkspacesClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="Conflict" Message="The workspace name 'testLogAnalyticsWorkspaceName' is not unique" Target="name"

I am not really sure what the problem is, changign the workspace name does not solve it. Maybe it is an issue with AKS/Terraform? I am on terraform 0.12.4 on Windows.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c22b6ec6-7a27-4029-ff8f-674a40c0e552
Version Independent ID: bd2884f3-831a-3761-0502-5eb1594872bd
Content: Create a Kubernetes cluster with Azure Kubernetes Service (AKS) and Terraform
Content Source: articles/terraform/terraform-create-k8s-cluster-with-tf-and-aks.md
Service: azure
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Log Analytics workspace names have to be unique across the whole of azure, rather than just the current subscription/tenant, so doing something like adding a random number to the end of the name will resolve this problem. For example, if I put the name as testLogAnalyticsWorkspaceName68163 then that is accepted and the workspace will deploy OK. The error returned could really do with making that clearer.


nmap: update clang specific patch

The upstream PR had two parts: adding a missing include and resolving
an ambiguous reference. The upstream project fixed the first but not
the second. We still need the second part, so extract it by filtering
the patch.

Motivation for this change
Fixes #67223
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @thoughtpolice @fpletz

@GrahamcOfBorg build nmap


Wrong size inference when writing to buffer

import tgpu from 'typegpu';
import { vec3f } from 'typegpu/data';

const adapter = await navigator.gpu.requestAdapter();
const device = await adapter?.requestDevice();

if (!device ) throw new Error();

const b = tgpu.createBuffer(vec3f).$device(device);

tgpu.write(b, vec3f(2,2,2))

Results in:
Write range (bufferOffset: 0, size: 16) does not fit in [Buffer (unlabeled)] size (12).
 - While calling [Queue].WriteBuffer([Buffer (unlabeled)], (0 bytes), data, (16 bytes))

In this particular example we have a buffer that has just a vec3f so the size is 12 bytes. When we write to a buffer we determine the size by rounding up the size by the alignment. This is correct for structs, arrays and matrices (which are essentially arrays). Primitive types, however, do not have such behavior. It happens to not make a difference for any other data apart from vec3f as it is the only primitive type that has a different alignment than size.

Nice catch! 🙌


Content-type clarification and preflight requests

You specify that the Content-type: application/vnd.api+json is REQUIRED in all requests, but then within your specification-page examples you don't include it -- instead you specify Accept header which I understand is OPTIONAL, e.g.
GET /articles HTTP/1.1
Accept: application/vnd.api+json

Also, is it really necessary to require Content-Type header? Doing that will effectively make even GET/POST requests issue preflight requests (for CORS), which will hurt page responsiveness (added latency). I think the Accept header alone would be fine, and it wouldn't produce preflights.

You specify that the Content-type: application/vnd.api+json is REQUIRED in all requests

No, only when there's "JSON API data", which is supposed to mean an HTTP message body. Thus, GET requests are exempt.
The spec should either formally define "JSON API data" or revert to the common HTTP terminology in the Content Negotiation section.

Makes sense. Yea the wording is a bit confusing but mistake is on my part.
The POST will still make a preflight, though. I agree including the Content-type is semantic and correct, but just a tad annoying (which for some remote users might add up to more than a tad).

I also think it should be mentioned that GET and DELETE requests should not send the Content-Type header and that the spec doesn't require them. When reading the spec, it's easy to miss that these requests do not contain JSON API data and therefore don't fall under this rule.

I think this has been clarified in upcoming v1.1 of the specification:

Clients and servers MUST send all JSON:API payloads using the JSON:API media type in the Content-Type header.

This clearly limits the Content-Type header to request and responses, which includes a JSON:API payload.
Do you see further need to clarify?


Support UTF-16BE

Fix #3
Adds support of UTF-16BE by adding all analogous functions that we have for UTF-16LE. For example, validate_utf16 now comes in two flavours: validate_utf16le and validate_utf16be. However, the functions that implement the actual algorithms are now template-based on whether the input/output is little endian or big endian. If big endian, we swap the bytes of using a single shuffle when we load/store data. I also added a function to swap endianness called change_endianness_utf16.

I have not tested the new functions yet. I am also unsure of what change_endianness_utf16 should return. Could it just be a void function? For now, it returns something silly.

I am also unsure of what change_endianness_utf16 should return. Could it just be a void function?

Definitively. I think it should return void.

@NicolasJiaxin This code looks very good to me. I just think that we ought to test it (at least minimally).

I added all tests and I did have a few bugs. But it is all working now, except that the debug tests on Visual Studio are getting stuck and I don't know why.

Let me investigate.

@NicolasJiaxin When you do (for example)
    std::vector<char16_t> utf16be;
    utf16be.reserve(size);
    implementation.change_endianness_utf16(utf16le, size, utf16be.data());

You will have that utf16be.size() is zero. Your code is technically unsafe. The reserve call is just an optimization hint, it may not allocate the memory the way you think (though it will in practice).
So you want to go through and do the following...
    std::vector<char16_t> utf16be(size);
    implementation.change_endianness_utf16(utf16le, size, utf16be.data());

That should solve the issue. You can also replace reserve with resize.
Note that your code is 'practically correct' but memory checkers might complain so better fix it.
One problem with using  std::vector is that the input is guaranteed to be zeroed. If you'd want to avoid that... You could also do the following...
std::unique_ptr<char16_t[]> utf16be_unique(new char16_t[size]);
char16_t * utf16be = utf16be_unique.get();
implementation.change_endianness_utf16(utf16le, size, utf16be);

But I am not sure what the benefit would be.

@NicolasJiaxin Try adding some bits of documentation to the README. And then I think we will merge.

Great stuff. Merging.


[vault-secrets-webhook] add batching support to get dynamic credential

Describe the bug:
vault-secrets-webhook is making separate vault call and will not give matching username/password combo for dynamic credential
Expected behaviour:
able to retrieve and use dynamic credential with vault-secrets-webhook
Steps to reproduce the bug:
Run bank-vaults and set up postgres database secret
Follow guild line on running vault-secrets-webhook to read vault secret and inject into k8s pod
Instead of reading from secret engine, have it retrieve dynamic username/password from postgres database engine using something similar to this

env:

name: INFLUX_HOST
value: vault:v1secret/training/influx#host_private
name: INFLUX_PORT
value: "vault:v1secret/training/influx#port"
name: INFLUX_USERNAME
value: vault:postgres/creds/influx-read-only-training#username
name: INFLUX_PASSWORD
value: vault:postgres/creds/influx-read-only-training#password

serviceAccount:
create: true
name: vault-auth
podAnnotations:
vault.security.banzaicloud.io/vault-addr: "https://<IP_ADDRESS>:8200"
vault.security.banzaicloud.io/vault-role: "default"
vault.security.banzaicloud.io/vault-skip-verify: "true"
vault.security.banzaicloud.io/vault-path: "kubernetes-training"
prometheus.io/scrape: "true"
prometheus.io/port: "7090"

because webhook will make a separate call to vault, the database username/password combo won't match and you won't be able to log into database
Additional context:
Add any other context about the problem here.
Environment details:

Kubernetes version (e.g. v1.10.2): v1.11.7
Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc): GKE
bank-vaults version (e.g. 0.4.17): 0.5.0
Install method (e.g. helm or static manifests): helm
Logs from the misbehaving component (and any other relevant logs):
Resource definition (possibly in YAML format) that caused the issue, without sensitive data:

/kind bug

@tnguyencota thanks for reporting this, it is fixed in #621 which is not in a released version yet, but you can test it from the master tag.


Unprefixed link blocks

I’m realizing that since #14 requires links to start with ./, ../, /, or scheme: it is possible to detect link blocks by sniffing the line with a regular expression.
We introduced this constraint to disambiguate wiki links from protocol links in #14. The disambiguation opens up an additional approach that was not obvious at the time of the RFC:

Remove sigil from link blocks, restrict them to path and URL, sniff out block type with regular expression.
Introduce a separate wiki link block.

This is very tempting because writing it looks like what you might do absent of any formal syntax. There are tradeoffs though. (TODO: Elaborate on these…)

Closed by #18, which introduces bare links, and slashlinks.


Fix Istioctl Analyze not consistently respecting Exports for ServiceEntry used by VirtualService

Please provide a description of this PR:
Fixes https://github.com/istio/istio/issues/46597
When a ServiceEntry exports to a namespace by name (rather than wildcard "*"), any VirtualService in that target namespace which references the ServiceEntry's hostname was showing as an error.

Example Config showing the issue
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: external-svc-virtualdestination
  namespace: foo
spec:
  hosts:
  - foobar.staging.mesh
  location: MESH_INTERNAL
  ports:
  - number: 80
    name: https
    protocol: HTTP
    targetPort: 80
  resolution: DNS
  exportTo:
    - "bar" # Note exporting to the bar namespace of the VS below
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: foo-route
  namespace: bar
spec:
  hosts:
  - foo.foo.svc.cluster.local
  http:
  - name: "foo-route"
    match:
    - uri:
        prefix: "/"
    route:
    - destination:
        host: foobar.staging.mesh
        port:
          number: 80

This was resulting in an error:

Error [IST0101] (VirtualService bar/foo-route) Referenced host not found: "foobar.staging.mesh"

Hi @Sodman. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@Sodman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
6f927882a96fa35ec9c38c67a9140eda2db3a4cf
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Sodman thx for your PR! So this VS works, but analyzer raises a error, correct?

@Sodman thx for your PR! So this VS works, but analyzer raises a error, correct?

@linsun yes that's correct.
Here are the minimal steps I used to reproduce if you're interested, it installs istio in registry only mode, sets up two apps in different [injected] namespaces.

Commands to setup env:
kind create cluster --name analyze-test

istioctl install --set meshConfig.outboundTrafficPolicy.mode=REGISTRY_ONLY -y

kubectl create ns foo
kubectl create ns bar

kubectl label ns foo istio-injection=enabled --overwrite
kubectl label ns bar istio-injection=enabled --overwrite

kubectl apply -n foo -f - <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
  name: curly
---
apiVersion: v1
kind: Service
metadata:
  name: curly
  labels:
    app: curly
    service: curly
spec:
  ports:
    - name: http
      port: 8000
      targetPort: 8080
  selector:
    app: curly
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: curly
spec:
  selector:
    matchLabels:
      app: curly
      version: v1
  template:
    metadata:
      labels:
        app: curly
        version: v1
    spec:
      serviceAccountName: curly
      containers:
        - name: curl
          image: curlimages/curl:7.83.1
          imagePullPolicy: IfNotPresent
          command:
            - "tail"
            - "-f"
            - "/dev/null"
EOF

kubectl apply -n bar -f - <<EOF
apiVersion: v1
kind: ServiceAccount
metadata:
  name: curly
---
apiVersion: v1
kind: Service
metadata:
  name: curly
  labels:
    app: curly
    service: curly
spec:
  ports:
    - name: http
      port: 8000
      targetPort: 8080
  selector:
    app: curly
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: curly
spec:
  selector:
    matchLabels:
      app: curly
      version: v1
  template:
    metadata:
      labels:
        app: curly
        version: v1
    spec:
      serviceAccountName: curly
      containers:
        - name: curl
          image: curlimages/curl:7.83.1
          imagePullPolicy: IfNotPresent
          command:
            - "tail"
            - "-f"
            - "/dev/null"
EOF

Now we have our env setup with REGISTRY_ONLY but no VirtualService or ServiceEntry, we should not be able to curl foo from bar at all:
# Curl from bar to foo
# Will return a HTTP 502, because foo only has a service on port 8000 and we are curling default http port 80
kubectl exec -n bar deploy/curly curl -- curl curly.foo.svc.cluster.local/anything -v

We can also confirm we can't curl httpbin directly from the foo pod:
# Also returns a HTTP 502, because REGISTRY_ONLY is set and httpbin.org isn't in our service registry yet
kubectl exec -n bar deploy/curly curl -- curl httpbin.org/anything -v

Now if we add our ServiceEntry and VirtualService:
kubectl apply -f - <<EOF
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: external-svc-virtualdestination
  namespace: foo
spec:
  hosts:
  - httpbin.org
  location: MESH_EXTERNAL
  ports:
  - number: 80
    name: https
    protocol: HTTP
    targetPort: 80
  resolution: DNS
  exportTo:
    - "bar"
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: foo-route
  namespace: bar
spec:
  hosts:
  - curly.foo.svc.cluster.local
  http:
  - name: "foo-route"
    match:
    - uri:
        prefix: "/"
    route:
    - destination:
        host: httpbin.org
        port:
          number: 80
EOF

And try to curl again:
# Curl from bar to foo, VS re-routes to SE-defined httbin.org
# Returns 200 success
kubectl exec -n bar deploy/curly curl -- curl curly.foo.svc.cluster.local/anything -v

So everything on the data plane works, but you can see with istioctl analyze it incorrectly picks up an error:
istioctl analyze -A

Will return the error:
Error [IST0101] (VirtualService bar/foo-route) Referenced host not found: "httpbin.org"
Info [IST0102] (Namespace default) The namespace is not enabled for Istio injection. Run 'kubectl label namespace default istio-injection=enabled' to enable it, or 'kubectl label namespace default istio-injection=disabled' to explicitly mark it as not needing injection.
Error: Analyzers found issues when analyzing all namespaces.
See https://istio.io/v1.17/docs/reference/config/analysis for more information about causes and resolutions.

Meanwhile a build of istioctl which contains the changes in this PR will not return the error (just the expected default namespace info from above)
$ ./out/darwin_arm64/release/istioctl-osx-arm64 analyze -A
Info [IST0102] (Namespace default) The namespace is not enabled for Istio injection. Run 'kubectl label namespace default istio-injection=enabled' to enable it, or 'kubectl label namespace default istio-injection=disabled' to explicitly mark it as not needing injection.


Compile Problem

I use make in Release folder, but it has the following errors:
g++ -O3 -Wall -c -fmessage-length=0 -pthread -std=c++0x -MMD -MP -MF"src/Edge.d" -MT"src/Edge.d" -o "src/Edge.o" "../src/Edge.cpp"
In file included from ../src/Edge.hpp:6:0,
from ../src/Edge.cpp:1:
../src/internal_config.hpp:9:7: error: expected nested-name-specifier before ‘EdgeIndexType’
../src/internal_config.hpp:9:7: error: ‘EdgeIndexType’ has not been declared
../src/internal_config.hpp:9:21: error: expected ‘;’ before ‘=’ token
../src/internal_config.hpp:9:21: error: expected unqualified-id before ‘=’ token
In file included from ../src/Edge.cpp:1:0:
../src/Edge.hpp:14:2: error: ‘EdgeIndexType’ does not name a type
../src/Edge.hpp:20:21: error: expected ‘)’ before ‘rec_src’
../src/Edge.cpp:4:11: error: expected constructor, destructor, or type conversion before ‘(’ token
../src/Edge.cpp: In copy constructor ‘Edge::Edge(const Edge&)’:
../src/Edge.cpp:9:2: error: ‘src’ was not declared in this scope
../src/Edge.cpp:9:16: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:10:2: error: ‘dst’ was not declared in this scope
../src/Edge.cpp:10:16: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp: In member function ‘Edge& Edge::operator=(const Edge&)’:
../src/Edge.cpp:14:2: error: ‘src’ was not declared in this scope
../src/Edge.cpp:14:16: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:15:2: error: ‘dst’ was not declared in this scope
../src/Edge.cpp:15:16: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp: In member function ‘bool Edge::selfEdge()’:
../src/Edge.cpp:20:11: error: ‘src’ was not declared in this scope
../src/Edge.cpp:20:18: error: ‘dst’ was not declared in this scope
../src/Edge.cpp: In function ‘bool operator<(const Edge&, const Edge&)’:
../src/Edge.cpp:24:10: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:24:20: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:26:15: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:26:25: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:28:15: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp:28:25: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp: In function ‘bool operator==(const Edge&, const Edge&)’:
../src/Edge.cpp:35:15: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp:35:26: error: ‘const class Edge’ has no member named ‘dst’
../src/Edge.cpp:35:37: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp:35:48: error: ‘const class Edge’ has no member named ‘src’
../src/Edge.cpp: In function ‘std::ostream& operator<<(std::ostream&, Edge&)’:
../src/Edge.cpp:39:15: error: ‘class Edge’ has no member named ‘src’
../src/Edge.cpp:39:36: error: ‘class Edge’ has no member named ‘dst’
../src/Edge.cpp: In function ‘bool operator==(const Edge&, const Edge&)’:
../src/Edge.cpp:36:1: warning: control reaches end of non-void function [-Wreturn-type]
../src/Edge.cpp: In function ‘bool operator<(const Edge&, const Edge&)’:
../src/Edge.cpp:32:1: warning: control reaches end of non-void function [-Wreturn-type]
../src/Edge.cpp: In member function ‘bool Edge::selfEdge()’:
../src/Edge.cpp:21:1: warning: control reaches end of non-void function [-Wreturn-type]
make: *** [src/Edge.o] Error 1
Thanks

Can you please tell me if you are modifying the files? For example, in the existing Release make the C++11 compilation flag is indicated with -std=c++11 however yours is -std=c++0x (not that it makes a difference).

Hi, I also got the compilation error can you please look into this
/Users/Narendra/Downloads/PaRMAT-master/src/PaRMAT.cpp
/Users/Narendra/Downloads/PaRMAT-master/src/PaRMAT.cpp:88:25: Implicit conversion loses integer precision: 'unsigned long' to 'unsigned int'
/Users/Narendra/Downloads/PaRMAT-master/src/GraphGen_sorted.cpp
/Users/Narendra/Downloads/PaRMAT-master/src/GraphGen_sorted.cpp:92:25: Implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int'
/Users/Narendra/Downloads/PaRMAT-master/src/GraphGen_sorted.cpp:100:25: Implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int'
/Users/Narendra/Downloads/PaRMAT-master/src/GraphGen_notSorted.cpp
/Users/Narendra/Downloads/PaRMAT-master/src/GraphGen_notSorted.cpp:81:6: Code will never be executed
/Users/Narendra/Downloads/PaRMAT-master/src/utils.cpp
/Users/Narendra/Downloads/PaRMAT-master/src/utils.cpp:65:13: Implicit conversion loses integer precision: 'time_t' (aka 'long') to 'unsigned int'
/Users/Narendra/Downloads/PaRMAT-master/src/utils.cpp:159:30: Implicit conversion loses integer precision: 'unsigned long long' to 'EdgeIndexType' (aka 'unsigned int')
/Users/Narendra/Downloads/PaRMAT-master/src/utils.cpp:161:51: Implicit conversion loses integer precision: 'unsigned long long' to 'EdgeIndexType' (aka 'unsigned int')
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@farkhor Yes, you are right! I use c++11 now, and it can successfully compile! Thanks!

Hi zipjack,
Can you please guide me how to use this in mac . please help me
Thanks,
Narendra


Challenges from Harvesters, delayed graph

Describe the bug
The Challenges from Harvesters graph can take a while to populate, and look deceptively sparse for current values.
To Reproduce
Refresh graph at time X, save image,
wait 2 minutes,
refresh graph again, save image,
compare old graph values at X with new values at X
Expected behavior
It would be nice if the graph values for plotted points should be consistant, not eventually consistant. Maybe there should be a cutoff in the timeline (now-1minute)?
System setup:
Machinaris v0.6.9
ghcr.io/guydavis/machinaris:test
Config

Additional context & screenshots

maybe this is just how it has to be, which is ok if thats the case 🤷♂

Hi, this is a good point.  I'll delay display of the right-hand side of the chart by a couple of minutes in the next version.  Details on the wiki.  Thanks for the suggestion!

Closing as Machinaris version 0.6.9 has now been released.


Refueling may create several sessions in special cases

Car sends soc while refueling

Fixed in 0.9.0


[toranj] adding test-026 for addition/removal of SLAAC IPv6 address

This test is expected to fail now. It would pass with https://github.com/openthread/wpantund/pull/355 merged.

The wpantund PR is merged, Kicked the travis-ci builds and the toranj did pass ok.


HAWQ-810. Add stringFormat for feature test library

cc @zhangh43 @huor

also cc @jiny2

+1 LGTM

+1 except for the test case for string format.

Merged into master.


Add chart to Artifacthub

ArtifactHub is an invaluable chart index for DevOps engineers. It's the to-go tool when comparing different releases, templates, values... I'm having a complex issue now and having no access to it through ArtifactHub is making it twice as difficult.
A certified developer of this project should request its addition here: https://github.com/artifacthub/hub/issues/new/choose
Select "Official status request" and fill out.
PS: It's a 5-minute process, no worries.

@GeiserX The Infinispan Helm charts and Operator are already available via Artifacthub.

@ryanemerson Thanks. The thing is that the publisher is a "joaquinito2051". I don't know if you could publish it yourselves so it doesn't confuse users like me.

I appreciate that's not ideal. The publisher is "joaquinito2051" because they added the "openshift" repo that we currently use to publish the helm chart. In order to create our own repository, we would have to self host our charts and add that to ArtifactHub. This isn't currently a priority, but is something we may consider in the future.
Self-hosting our chart would have the benefit of overcoming https://github.com/infinispan/infinispan-helm-charts/issues/60 while we wait on a fix for https://github.com/openshift-helm-charts/charts/issues/773.


"Date/Time" in comments should be in one line layout

"Date/Time" in comments should be in one line layout
It looks like "PM/AM" for time is going in another line , which gives distorted view

@naina-verma Can you verify if this issue exists

@SMahil This looks fixed now !! Verified

@SMahil , It looks like something again broke this fix

@SMahil , It happend on specific  Version 54.0.2840.59 (64-bit) chome , closing issue for now !


fix: [PL-57762]: delegate release note fix

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: delegate release note fix
Jira/GitHub Issue numbers (if any): PL-57762
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://671b95e51fb08a25ab5c80b0--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://671b977cfae58523a61dea12--harness-developer.netlify.app


Remove dead links to make tests pass again

All Travis CI builds are failing as of right now, because they see these dead links. I'm removing them to make the tests pass again.

For ipfs.pics I would rather change it to link directly to Github rather than removing completely. The second article makes sense, tried finding it elsewhere but seems to be gone... Thanks for helping out! :)

@VictorBjelkholm I was able to find the article! They changed their name to Monax. See #97

This PR is no longer needed since https://github.com/ipfs/awesome-ipfs/pull/97 exists. #97 even fixes the SSL problem I've been struggling with.


Ericmay

i feel so lost right now with being out for pretty much 2 days due to internet and damage on house.

sending agian


Fantomas version

Hi,
I understand that fsharp-support bundles Fantomas and I have a few questions regarding the Fantomas version:

Can I see the Fantomas version in Rider?
If not, which version is bundled with 2020.3?
Can I change the Fantomas version used by Rider? (some of our repositories are using older Fantomas versions)

Thanks, Jon

Hi Jon,
We bundle a custom Fantomas build that is usually forked from roughly the latest version at the time of a Rider release.
Rider 2020.3 uses ~4.2 version, and 2021.1 will base on 4.4.
If you need to override Fantomas version in Rider, it's possible to use it as an external tool, though we don't test this scenario and some bits of the integration may not work as expected.

Could you tell a bit more about reasons to stay on older Fantomas versions, please? Are there some breaking changes or bugs that prevent you from upgrading? cc @nojaf

Hi Eugene,

Could you tell a bit more about reasons to stay on older Fantomas versions, please?

Well, I have assumed that different versions of Fantomas formats code differently. If upgrading my Rider suddenly formats code differently then everyone who works in the same repository must also upgrade to the same Fantomas version, otherwise we will keep reformatting each others code, causing a lot of noise in git diffs and pull requests.
We can try to mitigate this by communicating a "known good" Fantomas/Rider version internally, but as the number of developers and repositories increase, this coordination becomes unwieldy or even impossible. What we need is a way to configure the Fantomas version, per repository, and have our tools (including Rider) pick that up.
So to summarize, it's not that we want to stay on older versions, it's just that it's hard to switch every developer and repository to a new formatting simultaneously.

Hello Jon, I recognize this problem and what I do in my projects is pin down a version of Fantomas via a tool manifest.
Usage in Rider is then indeed limited to configuring it as an external tool.
Every once in a while I update the local Fantomas tool as part of a separate PR (example).
If you are brave enough you could also configure Fantomas as pre-commit hook in git.
Personally, I use a FAKE target to format my changed code.
Perhaps it is also an option Eugene to sync to a tag of Fantomas for the Rider integration?

@jonekdahl Thanks! It makes sense to me now.
@nojaf The problem here is the custom builds of both FCS and Fantomas that we bundle, and Fantomas won't be able to use SyntaxTree from a different strong-name FCS build. I'll think about having way to use the published Fantomas version if it's somehow specified in a project.

@nojaf Thanks, I guess the external tool option is the one we have to go for.

@jonekdahl We've discussed it briefly with @nojaf and we'll think about having an automated way to use external Fantomas tool in future Rider/Fantomas version.

That would be awesome, looking forward to it!

@auduchinok Should I close this issue or do you want to keep it open?

@jonekdahl Let's keep it open for a while as a reminder.

It seems that Fantomas is missing from the open-source software list available in Rider in Help->About->Powered by open source software

@l3m Thanks for letting us know, I've forwarded it to the team (see RIDER-61672).

@johnekdahl, can you share how you are currently anchoring the Fantomas version in your organization?

This is implemented in #339, kudos to @DedSec256 and @Rizzen!


[nrf toup] zephyr: Add MCUboot configuration for Thingy:53

Change introduces default configuration of MCUboot for Thingy:53 secure cpuapp.

There are still some issues related to disabling logging in Kconfig overlay, but the outputted the configuration is proper. The warnings are related to being unable to deselect some of the log related choice options that was selected by prj.conf.

I hope that review would be quick, so I could add it as fromtree :) .

@MarekPieta what do you know, it was already merged upstream ;)


New package: GeometricAlgebra v0.1.0

Registering package: GeometricAlgebra
Repository: https://github.com/MonumoLtd/GeometricAlgebra.jl
Created by: @tpgillam
Version: v0.1.0
Commit: 2c1a2a0bc157455c0eca669ea8fc21b9da329130
Reviewed by: @tpgillam
Reference: https://github.com/MonumoLtd/GeometricAlgebra.jl/commit/2c1a2a0bc157455c0eca669ea8fc21b9da329130#commitcomment-106817694
Description: Geometric algebra in Julia.

I would like to request a manual merge of this package registration because an in-progress community discussion about how to organize the GeometricAlgebra package for General registry was not concluded before the this package registration was initiated.
The in-progress discussion is taking place at (see posts after 3/28/2023): https://github.com/JuliaGeometricAlgebra/GeometricAlgebra.jl/issues/1#issuecomment-1492256642

I second this. I would prefer not to rush with package registration for a name which members of the JuliaGeometricAlgebra organization agreed is central and require careful thought before using it. Once a package has been registered, changing it significantly in terms of content and/or ownership is not trivial and would cause unnecessary inconvenience to users. Alternatives to an early registration taking into account motivations of the author were already suggested which would leave time before taking a more consensual decision on this matter.

@ktchu @chrisjldoran
Apologies all; I made the merge request, and I hadn't been following the linked discussion. I agree that it is not concluded, and we should not register under this name.
Chris — personally I am in favour of renaming the Monumo package. I think there's a few good names that would suit your structure of this library.