Kanban Board

We are two members of this group project.

here is the link for Kanban board
https://github.com/muneeb3123/Food-App/projects/1

Hi @muneeb3123 @LarryIVC 👋,
Good job so far!
Highlights

Created Kanban board according to provided template ✔
Points are shared in a fair way ✔
All cards have a descriptive title, number of points and description of the task ✔

You still need to work on some issues to go to the next project, but you are almost there!
Required Changes ♻

[ ] Kindly add a card for this project requirement:

Make sure there are no N+1 queries happening.

Remember that all project requirements should have a corresponding card. Kindly implement this change. 👍 😎
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend considering them as they can improve your code.
You can also consider the following:
N/A
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please tag me in your question so I can receive the notification. You can tag me by typing @Gambit142
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, request a second opinion using this form.

successfully added

Hello @team
Your project is complete!  There is nothing else to say other than... Congratulations! 🎉

Status: APPROVED :fire:  :fire:
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Add confirmation message

Signed-off-by: MUzairS15<EMAIL_ADDRESS>Description
This PR adds support for confirming before proceeding with the selected operation.
Displaying k8s-context the operation will be applied to.
Notes for Reviewers
https://user-images.githubusercontent.com/79860504/170836632-8b7fb062-85ee-4a39-b57c-1fb900de7c5b.mov
Signed commits

[x] Yes, I signed my commits.

Closing commits pushed to https://github.com/meshery/meshery/pull/5528


feat:Introduce support for Int64 and UInt64 for protobuf

Fixes #11
Verified Tests locally:

@gabe-l-hart Not quite sure but I figured this was the expected outcome of the issue? Let me know if I misunderstood.

Thanks for the contribution @viveknshah! Minor NIT on the spacing which you can fix by running make fmt in the base of the repo. Also, IBM's org enforces signed commits, so you can do the following to sign: git fetch origin && git rebase origin/main --signoff.
Finally, it would be great to add a quick unit test to explicitly verify that the new types are supported. We've still got 100% coverage as is since the dict is declared, but it would be great to ensure that nothing breaks in the JTD validation. The test would look a lot like this one.

Thank you for your patient feedback. Have made the appropriate formating flows, verified the added tests and followed the signed commit command.


Document the risk of blockchain-non-availability

An attacker can, for example, produce many blocks with only a few transactions:
https://medium.com/coinmonks/how-the-winner-got-fomo3d-prize-a-detailed-explanation-b30a69b7813f

Probably README and the spec repo are the good places to document risks.

I saw something similar in the Raiden node doc.  I'll have a look.

Requirements for safe usage already has "Layer 1 works reliably".


Message disappears on undoing instead of a emoji.

When undoing(using Ctrl+Z) while typing a message followed by an emoji (just in case the user wants to change the emoji) , the phrase is removed on hitting Ctrl+Z instead of the emoji itself.

Worth noting that this is only reproducible if you select the emoji from the popover menu as opposed to manually typing out the emoji.

I think this is because the browser doesn't recognize the emoji added to the compose box as something being typed.

Right, we're using the jquery-caret module with $.caret() to insert these.  I think it's worth researching a bit whether there's a way we can do the insert that is treated by the browser as something ctrl-Z should interact with.  I'm not 100% confident this is possible, but it seems worth investigating.

browser don,t recognize

I would like to look into it, please which of the files contains the form code for typing in a message and sending to the stream cc @timabbott

@timabbott There is a solution here, to use document.execCommand to insert text instead of using $.caret() since that logs stuff into browser stack. Are there any reasons to not switch to document.execCommand? It seems to work fine for all cases I tried.

Check the browser compatibility situation for it; I don't know that feature.  @brockwhittaker I'd like your thoughts on this as well.

But I think it'd be reasonable to make a PR switching to using it, since I'm guessing it'll be a good approach.

Check the browser compatibility situation for it;

Acc. MDN docs, it works with all major browsers.

My only concern is that safari 9 (incompatible) is only a year old, but otherwise it has all the support we care about.

OK, well can we check if it's supported, use it if so, and otherwise fall back to $.caret, with a comment noting that the jquery.caret case is only needed for Safari 9?
@nalinbhardwaj we should also perhaps audit the codebase for other use of $.caret that we should switch ($.caret has other uses that I imagine wouldn't be convertible).  If so we might want to have a Zulip helper function in util.js that's e.g. util.insert_text and we can use in multiple places that does the backwards compatibility stuff.

@zulipbot claim

So, after some testing I've realised that the implementation of document.execCommand is actually extremely buggy in FF(even latest version), for example this fiddle doesn't work correctly in firefox.
One solution I found on SO was to use change textarea.val() without using execCommand, however, I am not sure if this has any shortcomings. It does seem much more backwards compatible. Opinions @timabbott , @brockwhittaker ?

The problem is that that will change the caret position to an undesirable position, right?

@zulipbot claim


[Bug]: In footer's github and home icon not have same radius when we hover on that.

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

I will make home and github radius same when hover
Expected behavior
NA
Add ScreenShots
NA
On which device are you experiencing this bug?
Chrome
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@VaibhavArora314 Kindly assign me this task !

@VaibhavArora314 @Ultimateutkarsh11 Please assign me this task and also #332


Implement a worker process with an http interface

The worker can now serve static HTML/CSS content.


When I connect mysql，I get "Access denied for user"

when I execute program
 sqlx::mysql::connect("mysql://rimer_test:xxxxxxx@xxxxxxxx:3306/rimer").await?,

DatabaseError { message: "Access denied for user<EMAIL_ADDRESS>(using password: YES)
but I can connect when I use other mysql client
use mysql_async::Pool;
Pool::new("mysql://rimer_test:xxxxxxx@xxxxxxxx.com:3306/rimer");

mysql> select user,plugin,host from mysql.user;
+------------------+-----------------------+-----------+
| user             | plugin                | host      |
+------------------+-----------------------+-----------+
| root             | mysql_native_password | localhost |
| mysql.session    | mysql_native_password | localhost |
| mysql.sys        | mysql_native_password | localhost |
| debian-sys-maint | mysql_native_password | localhost |
| rimer_test       | mysql_native_password | %         |
+------------------+-----------------------+-----------+

The released version does not (yet) support authentication (for MySQL). After we get CI setup ( hopefully today ) I'll push a release containing the additions from #18.
sqlx = { git = "https://github.com/launchbadge/sqlx" }

If you'd like to try master ( above ) to see if it works for you, that would help speed this up.

@liangyongrui This is now available as v0.1.2. Please re-open this issue if it doesn't work for you.


Update creating-a-github-pages-site-with-jekyll.md

add notes for domain, url, and baseurl settings when repo used as subfolder

Why:
adds important, missing information

What's being changed:
minor documentation & config example

@gojimmypi Thanks so much for opening a PR! I'll get this triaged for review ⚡

👋🏻 - there is an issue with the ordered list that I'll need to investigate.

I've fixed the issues with the ordered list restarting at one, and several list items being in the same paragraph 🙂
Now just waiting on someone to check that the updates are accurate from a technical point of view.

Thank you for your reviews @jriggins and @YiMysty - very much appreciated 💖 (I wouldn't worry about the item list numbering for now, that's something we'll need to sort out in the whole of our docs).


Please add Class Viewer

Please add a Class Viewer for Typescript

like QT Creator has for C++

@chrisdias assigning to you. This is more a general product decision.

@chrisdias @dbaeumer @isidorn @egamma
I've already open this issue on Nov 21st, see:
https://github.com/Microsoft/vscode/issues/397
and it went on the backburner as well.
Can you please tell me if you have plans to implement it in a not too distant release
or if it's somehow seen as non-priority or against the product philosophy feature?
Besides, with the current API I don't think a user plugin can:

add a button under the debugger icon one
create a vertical split window or substitute the File Lister
call Typescript compiler API and extract AST+TS files infos.

All this can be only accomplished by intervening in the core code of VSC.
Thank you for the time and all the good work!
-- R

@RobertoMalatesta VS Code supports the 'Go to Symbol...' action which allows you to quickly navigate to a method, property inside a typescript file.

:+1:
a tree version of that for the whole project or folder would be excellent

Problem solved switching back to Webstorm Jetbrain.
Unfortunately as some of my projects reach 30k lines and hundreds of classes VSC is no longer productive. Too many lacking basic features. Will try again in 6 months or so to see if the product matures.
-- R


adds failing test for dir stat bug

This adds two entries to the list of test files, demonstrating the bug reported in https://github.com/jszwec/s3fs/issues/3

Looks good to me, thanks!

now it is available in v0.3.2


refactor(datahub-frontend): upgrade frontend pac4j

Upgrade play components

scala 2.13
pac4j 6.0.6
oauth2-oidc-sdk/jose-jwt
java 11 -> java 17

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Will have to debug the unit test. Passes locally consistently.


[Cli] Can I hide file comments ?

Hello,
Is there an option to hide file comments ?
I just want to see the steps.
Thank you.

Can you give an example of what you'd like to see?

I don't think that Behat displays the file comments anywhere, so I am guessing that if anything this is something that should be configured in the IDE, so outside of our realm. I think we should close this one. @acoulton @ttomdewit what do you think?

Yeah I'm not sure what this is about but I don't think it's a behat issue.


Godot 4 version

Will the addon be ported to Godot 4 and when could this be?

Yes! But not soon. Sometime 2023. I started a new job a couple months ago, and will need to onramp for a few more before I'll have free time to work on this again.

Guess the godot 4 uppgrade sadly never happened.


Azure CLI commands for Azure Monitor Agent failing

I have put in reworked versions that work fine.
Note that the most recent versions seem to be:

Linux 1.12
Windows 1.1

As these will change regularly then it may be better to list the commands to show the versions, e.g.
az vm extension image list --publisher Microsoft.Azure.Monitor --name AzureMonitorLinuxAgent --location uksouth --output table

@richeney : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@richeney : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Tiptap: Add Extensions

Add in necessary extensions so it will have things for writing...
header, bold, italic, links, images, lists, quotes, if there's adjustment: left, right, center...
https://tiptap.dev/docs/editor/extensions
Will need to wire up buttons to work for adding these extensions

example to wire up buttons: https://github.com/jeffreymorganio/tiptap-editor-example

Customize the coloring for the tailwind typography plugin: https://github.com/tailwindlabs/tailwindcss-typography?tab=readme-ov-file#customizing-the-css

[ ] add highlight
[ ] add link
[ ] add images
[ ] add code
[ ] add justification: L, R, J


Unraid install

Hi ! Congrats for your work, I'm happy someone with dev skills made a project like this, I was looking for it for ages !
Would it be possible to create an Unraid template ?
It would be really helpfull for me (and probably for a lot of people using Unraid !)

Hey @guim31
I know very little about unraid and don't use it. Although I do think it would be cool to have it I'm not sure I'm the right one to do it.
If you go down that road or someone else and have question about running this in a container, feel free to ask, I'm happy to help there.


add Arizon logo to users of ReScript

At Arizon we use ReScript for most things - the startups we build, for client work, and for internal tools.
Here's how the logo looks when added:

Thank you for having a look!

manually rebased into master!


replace old eidas authn request resource

This PR replaces the old EidasAuthnRequestResource class with latest version, and updates the dropwizard version.

Believe I merged instead of rebase and changes were not at HEAD, closing for a new PR


Where is the "Release" button in the release section?

When the refined-github is disabled:
https://imgur.com/UcGa51P
When the refined-github is enabled:
https://imgur.com/oL1oE0o
How can I restore that section to the original one?

Why do you need to restore it? What exact information is needed from there that isn't available on the page?

I need to goto the Release page instead of the latest release page
The Release page contains all the releases including the latest one, now the latest button only contains the latest release.
This change is unnecessary to me.

The change is made so that the sidebar has fewer items. Refined GitHub adds a Releases tab to the repository navigation, which is always visible on every page, so the link in the sidebar is duplicate. That feature is called releases-tab

release-tab option is already enabled, but I've never seen such tab
https://i.imgur.com/1DrudVP.png

Did you set the token?


Allow multiple language application download URLs

The Bloom analog to:
https://www.pivotaltracker.com/story/show/169412575

AC:

User can download the application in the following languages: English, Spanish, Chinese (Traditional), Chinese (Simplified), Vietnamese, and Filipino
The Download Application dropdown only displays the application links for the languages that are provided in the database for a specific listing

Notes:
Each Listing may display different languages:

Listing A may only have English
Listing B may have English and Spanish, Vietnamese
Listing C may have English, Chinese (Traditional), Chinese (Simplified)

FWIW, my longer-term vision here is that we'll want a first class Attachment object (open to other names, maybe Asset?) with it's own ID and the relevant metadata, and then we can have a mapping between attachments and listings. I could think of cases where it will be M:M, such as program brochures or other supporting material that might be common to many listings.
This is sort of an iceberg feature, if you include upload functionality, versioning, etc. so I don't think we need to get too carried away with all of that now, but it would be great to get some of the object model parts worked out.

That sounds good to me (the Attachment object). I'll augment the current JSON to use that concept in as general a way as possible with the current URLs we have, and once we turn our attention to the backend we can evolve that further.


Add Binary Eye

Adds Binary Eye
(ignore 7e173f3, I only did it locally when running my fork on my phone as a placeholder)

Superseded by #606. Thanks for your interest in contributing though!


export phenotype ontology accessions

Description
The phenotype REST endpoint retrieves the existing phenotypes but currently does not report the associated ontology accession terms. This is now being updated.
Use case
The endpoint functionality stays the same.
Benefits
The result of the endpoint will now also contain ontology accessions.
Possible Drawbacks
None.
Testing
Have you added/modified unit tests to test the changes?
Yes. The corresponding tests have been updated.
If so, do the tests pass/fail?
Tests pass.
Have you run the entire test suite and no regression was detected?
Yes.
Changelog
Are you changing the functionality of an endpoint? If so, please give a one line summary for the public facing changelog.
The endpoint functions as before, just the output is enriched with accession terms if they are present.

Parallel to PR 252.


Apply better style for taxonomy terms

Grouped terms like a cloud instead of scattering each term on
its own line
Used a leading icon to make different taxonomy kinds
distinguishable
Also showed the page count matching each term as superscript

Fixes https://github.com/wangchucheng/hugo-eureka/issues/125

I'm using this on my blog right now. See examples:

https://www.lei.chat/tags/
https://www.lei.chat/categories/
https://www.lei.chat/series/

We can probably improve the style further, but this is a good starting point already I think.

IIUC these three are the default categories from Hugo so I think it's reasonable to have special icons for them. But good point on additional taxonomies. I think we can have a default icon for all of the rest.


hotfix/parking -> dev

This change is

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


kernel-modules-headers.bb: Allow do_patch

We need to allow do_patch to be able to take place as we patch the sources
from another location and this setting from here will prevent any patching
to take place.
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

LGTM


[Bug]: The plugin stops working when the status of a staged file is "renamed"

Describe the bug
The plug works fine when the status of staged files are "U", "D", "M".
But once your rename a file and try to stage the two [D]eleted and [U]ntracked file, the plug just stops functioning and leaves the refresh icon spinning. It seem it is not responding to a status of [R]enamed.
Relevant errors (if available)
No response
Steps to reproduce
Just rename a file, and stage the two deleted and untracked file.
I have reproduced this bug in the HELP vault, so it is most likely caused by the plug itself.
Expected Behavior
No response
Addition context
No response
Operating system
macOS
Plugin version
v1.25.1

Thanks for raising the issue. Should be fixed now.


Investigate why tensorflow needs to be restricted for nlp-primitives-complete tests on conda-forge

During the release of nlp_primitives V2.0.0 on conda-forge, the complete tests would not pass unless tensorflow was restricted to <2.6.0.
The tests for the regular install also use tensorflow, but those test would pass without the restriction in place. I believe that the difference in where the requirement is specified (run vs test) results in different package versions in the environment which causes the complete tests to fail while the normal tests pass.
We should investigate this issue and remove the upper bound on tensorflow from recipe/meta.yaml.
Related issue in the feedstock repo: https://github.com/conda-forge/nlp_primitives-feedstock/issues/7

There is no longer an upper bound restriction on tensorflow in the feedstock recipe.


[Redesign] Don't show "no readme" alert for packages with embedded readme that have not completed validation

Problem
Currently the redesign incorrectly shows the "no readme" alert when a package with an embedded readme is undergoing validation:

This alert is also shown when a package with an embedded readme fails validation:

Solution
Upon uploading a new package with an embedded readme, the redesigned display package page should:

Show an alert that the README will be available once the package completes validation
Don't show an alert that we defaulted to the description
Don't show the description

@dannyjdev You can verify this by uploading a package with an embedded README to the target environment. You should see this warning in the README tab when the package is pending in validation:

If package fails validation and has an embedded README, you should see:


intercepting http(s) any app under jailbreak env

Add theos build support, allows intercepting HTTP/HTTPS Traffic for any third party apps under jailbreak environment.

Thanks for your first contribution @qiudaomao 🎉
Can you share with me how to test it to make sure it works as intention?

There is a README.md in theos directory.
Sorry, I tried but app crash on start, seems theos still have issues with swift support.
Will reopen this PR once it run correctly.


Attach Fragment Normal Variable

other changing in progress about custom material
like atlas texture and tools attach shaderBuilder Compiler too but that take a time
and need your opinions about that (CustomMaterial)


PH-27 # mechanism for hosting static resources

Added

PH-27: add static hosting for files present in /app/public in the Docker container (#3, @jokeyrhyme)

code LGTM :+1:


root: cmakeBuildType = "RelWithDebInfo"

Description of changes
Build CERN ROOT with cmakeBuildType = "RelWithDebInfo" instead of the default "Release" for easier debugging.
As a data analysis framework, users spend most of the time debugging their C++ analysis code, and errors like Segmentation Violation occur in various situations ranging from going out of bound to file missing due to network error. A call-stack error message with line numbers provides real help.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Makes sense, but how much closure space do we have to pay for this?

The package size and the closure size grows smaller, which is somewhat strange.
nixpkgs_timeshift on  root-debug-info [$] took 4s
❯ nix path-info -S .#root
/nix/store/ddvxws306q93i377l1s77hfy59hxnj6z-root-6.26.10<PHONE_NUMBER>

nixpkgs_timeshift on  root-debug-info [$]
❯ nix path-info -S .?ref=origin/master#root
/nix/store/yscknw8l89m6xv46j4ff0mr7786fv22m-root-6.26.10<PHONE_NUMBER>

nixpkgs_timeshift on  root-debug-info [$]
❯ nix path-info -s .#root
/nix/store/ddvxws306q93i377l1s77hfy59hxnj6z-root-6.26.10	 438663432

nixpkgs_timeshift on  root-debug-info [$]
❯ nix path-info -s .?ref=origin/master#root
/nix/store/yscknw8l89m6xv46j4ff0mr7786fv22m-root-6.26.10	 445477272

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

python311Packages.hepmc3

5 packages built:

hepmc3
python310Packages.hepmc3
root
xfitter
yoda-with-root

I'm afraid that the debug information has got stripped away. I saw the strip running during the fixUp phase from OfBorg's build log.
Should we use dontStrip to prevent stripping as a whole or set separateDebugInfo = true and add the "debug" output to store the debug information separately?

The separateDebugInfo wouldn't work for builtin stack traces?

The separateDebugInfo wouldn't work for builtin stack traces?

At least I don't know how to make it work.

The debug information occupies ~500MB, which doubles the size of the ROOT output. The size is roughly the same whether the debug info is separated or not.
For some mysterious reason, the closure size also doubled (from 1.6GB to 3.1GB) after dontStrip = true;.

The 2-4x increase would be hard to justify. Are you dealing with a large rebuild when setting up for a debug?

Just didn't know it's that large. I had thought it would be trivial :sweat:
I'll ask on the ROOT forum if there's a way to use the separated debug information, as it would hopefully not increase the closure size of root.out and other packages depending on it.
BTW, considering the huge size difference, is there something other than debug symbols that is normally stripped away?

If you provide path to separated debug info to the ROOT, that would be a reference, so the closure size won't improve.

The closure size of the root.out output built with separateDebugInfo = true shrinks 7MB.
It would be doable if there's a way to make use of the separated debug information. The debug information could be made available either through a wrapper package, say, root-debug, or with user-side configuration using home-manager module or nixseparatedebuginfod plus corresponding .rc settings. Users who just install the root package should experience no closure increasing. (Not sure about the optimization level. The shrink of the build may result from the change of optimization strategies. RelWithDebInfo is still a kind of "release" build anyway.)
A ROOT developer answered in the above forum post that ROOT uses gdb to generate the stack trace. Maybe there's a way to make it show the line number in the stack trace.

Ah! Here it is:

$ NIX_DEBUG_INFO_DIRS="$(nix path-info .#root.debug)/lib/debug" nix run .#root -- -l
root [0] TFile::Open("nonexistence.root")->GetName();
Error in <TFile::TFile>: file /run/media/root/data-btrfs/shamrock-shared/targets/Projects/NixOS/nixpkgs_timeshift/nonexistence.root does not exist
#0  0x00007f0ea23a89ea in wait4 () from /nix/store/lqz6hmd86viw83f9qll2ip87jhb7p1ah-glibc-2.35-224/lib/libc.so.6
#1  0x00007f0ea231a02b in do_system () from /nix/store/lqz6hmd86viw83f9qll2ip87jhb7p1ah-glibc-2.35-224/lib/libc.so.6
#2  0x00007f0ea2ae8815 in TUnixSystem::Exec (shellcmd=<optimized out>, this=0x5cd800) at /build/root-6.26.10/core/unix/src/TUnixSystem.cxx:2104
#3  TUnixSystem::StackTrace (this=0x5cd800) at /build/root-6.26.10/core/unix/src/TUnixSystem.cxx:2395
#4  0x00007f0ea0752448 in cling::MultiplexInterpreterCallbacks::PrintStackTrace (this=<optimized out>) at /build/root-6.26.10/interpreter/cling/lib/Interpreter/MultiplexInterpreterCallbacks.h:158
#5  0x00007f0ea0751cee in cling_runtime_internal_throwIfInvalidPointer (Interp=0x65f3f0, Expr=0x1d49a70, Arg=<optimized out>) at /nix/store/9pgq84sf921xh97gjj2wh7a7clrcrh4m-gcc-12.2.0/include/c++/12.2.0/bits/unique_ptr.h:191
#6  0x00007f0e9b24d083 in ?? ()
#7  0x000000009b24d000 in ?? ()
#8  0x000000000134ea28 in ?? ()
#9  0x000000000134ea30 in ?? ()
#10 0x00007f0ea0751ca0 in ?? () from /nix/store/czl2bn94lbx01a1wamvyjgns0a90a7vc-root-6.26.10/lib/libCling.so
#11 0x000000000065f3f0 in ?? ()
#12 0x00007f0ea1e27890 in ?? () at /build/root-6.26.10/io/io/src/TFile.cxx:4352 from /nix/store/czl2bn94lbx01a1wamvyjgns0a90a7vc-root-6.26.10/lib/libRIO.so
#13 0x00007ffeb30587d0 in ?? ()
#14 0x00007f0ea07be3b8 in cling::IncrementalExecutor::executeWrapper (this=<optimized out>, function=..., returnValue=returnValue
entry=0x7ffeb30587d0) at /build/root-6.26.10/interpreter/cling/lib/Interpreter/IncrementalExecutor.cpp:381
#15 0x00007f0ea0753e21 in cling::Interpreter::RunFunction (this=0x65f3f0, FD=<optimized out>, res=0x7ffeb30587d0) at /nix/store/9pgq84sf921xh97gjj2wh7a7clrcrh4m-gcc-12.2.0/include/c++/12.2.0/bits/basic_string.h:1070
#16 0x00007f0ea0757981 in cling::Interpreter::EvaluateInternal (this=0x65f3f0, input=..., CO=..., V=0x7ffeb30587d0, wrapPoint=<optimized out>) at /build/root-6.26.10/interpreter/cling/lib/Interpreter/Interpreter.cpp:1414
#17 0x00007f0ea0757bb2 in cling::Interpreter::process (this=0x65f3f0, input=..., V=V
entry=0x7ffeb30587d0, T=T
entry=0x0, disableValuePrinting=disableValuePrinting
entry=false) at /build/root-6.26.10/interpreter/cling/lib/Interpreter/Interpreter.cpp:840
#18 0x00007f0ea08021ef in cling::MetaProcessor::process (this=this
entry=0x11d3080, input_line=..., compRes=
0x7ffeb30587bc: cling::Interpreter::kSuccess, result=result
entry=0x7ffeb30587d0, disableValuePrinting=disableValuePrinting
entry=false) at /build/root-6.26.10/interpreter/cling/lib/MetaProcessor/MetaProcessor.cpp:341
#19 0x00007f0ea068c00c in HandleInterpreterException (metaProcessor=0x11d3080, input_line=0x1d438b0 "#line 1 \"ROOT_prompt_0\"\nTFile::Open(\"nonexistence.root\")->GetName();", compRes=
0x7ffeb30587bc: cling::Interpreter::kSuccess, result=0x7ffeb30587d0) at /build/root-6.26.10/core/metacling/src/TCling.cxx:2441
#20 0x00007f0ea06a6528 in TCling::ProcessLine (this=0x65e730, line=<optimized out>, error=0x7ffeb3058b7c) at /nix/store/9pgq84sf921xh97gjj2wh7a7clrcrh4m-gcc-12.2.0/include/c++/12.2.0/bits/unique_ptr.h:191
#21 0x00007f0ea2c8a586 in TRint::ProcessLineNr (this=0x624e70, filestem=0x7f0ea2c9c298 "ROOT_prompt_", line=0x1d43710 "TFile::Open(\"nonexistence.root\")->GetName();", error=0x7ffeb3058b7c) at /build/root-6.26.10/core/rint/src/TRint.cxx:792
#22 0x00007f0ea2c8a97b in TRint::HandleTermInput (this=0x624e70) at /build/root-6.26.10/core/rint/src/TRint.cxx:650
#23 0x00007f0ea2ae4c66 in TUnixSystem::CheckDescriptors (this=this
entry=0x5cd800) at /build/root-6.26.10/core/unix/src/TUnixSystem.cxx:1306
#24 0x00007f0ea2ae7f38 in TUnixSystem::DispatchOneEvent (this=0x5cd800, pendingOnly=<optimized out>) at /build/root-6.26.10/core/unix/src/TUnixSystem.cxx:1061
#25 0x00007f0ea2a082e9 in TSystem::InnerLoop (this=0x5cd800) at /build/root-6.26.10/core/base/src/TSystem.cxx:406
#26 TSystem::Run (this=0x5cd800) at /build/root-6.26.10/core/base/src/TSystem.cxx:356
#27 0x00007f0ea299de73 in TApplication::Run (this=this
entry=0x624e70, retrn=retrn
entry=false) at /build/root-6.26.10/core/base/src/TApplication.cxx:1609
#28 0x00007f0ea2c8c1d0 in TRint::Run (this=this
entry=0x624e70, retrn=retrn
entry=false) at /build/root-6.26.10/core/rint/src/TRint.cxx:501
#29 0x00000000004011bf in main (argc=<optimized out>, argv=0x7ffeb305b028) at /build/root-6.26.10/main/src/rmain.cxx:84
terminate called after throwing an instance of 'cling::InvalidDerefException'
  what():  Trying to dereference null pointer or trying to call routine taking non-null arguments

@veprbl Do you think it's worth it to split the executable wrapping like what I did in the second commit?
If not, I can drop that PR, and access the .debug output manually.

@ofborg eval root.unwrapped.debug

@ofborg eval root.unwrapped.outputs

https://github.com/ofborg build root-unwrapped.debug

Building against wrapped root by default defeats the purpose of splitting the debug output. Did you mean to provide an optional wrapper?

@veprbl Yes. It would be something like root-debug aside from 'root'.
BTW, I just observed that the behavior of separateDebugInfo is different on Darwin and it doesn't produce the .debug output like it does on Linux! Not sure how to make a wrapper under such condition.

@ofborg build root.debug

BTW, I just observed that separateDebugInfo behaves differently on Darwin -- it doesn't even produce the .debug output like it does on Linux! Not sure how to make a wrapper under such condition.

Yes, it won't be possible to have that wrapper on macOS, see #203380.

@veprbl Yes. It would be something like root-debug aside from 'root'.

I don't even see a need for the wrapper. You could add a hook in nix-support into root.debug to set NIX_DEBUG_INFO_DIRS.

Alright, I'll just keep it simple and enable the debug build only on Linux.

I don't even see a need for the wrapper. You could add a hook in nix-support into root.debug to set NIX_DEBUG_INFO_DIRS.

How do I add hooks to a specific output?

See https://nixos.wiki/wiki/Debug_Symbols for a write up about how to use separate debug info, and https://github.com/edolstra/dwarffs and https://github.com/symphorien/nixseparatedebuginfod for third party projects that make this easier to deal with.
One of the main appeal of separate debug info is that you only download them when you use them, and in the case of root they are sizeable.

How do I add hooks to a specific output?

You'd probably need to hack $debug/nix-support/ yourself. I'd grep nixpkgs for ideas on how it's done.

thank you!


Fix CI/CD

what

Looks like travis has not yet been setup

why

Validate syntax

fixed in https://github.com/cloudposse/terraform-terraform-label/pull/4


Error when previewing pdf template

I get this error when trying to preview the provided template

october v 313
php 5.5.28
windows 8

This domPDF issue: https://github.com/dompdf/dompdf/issues/1027
Try to replace all IDs in template and layout with classes. You must also edit css to reflect your changes.
I will soon update plugin and do the same.


⚔ Remove Quests the Right Way! 🎉

Found out a very likely approach to removing quests!
Server will be reading player data already on death.
Instead of having to disconnect player so player can come back with manipulated player data file... the server can send the player a console command to have the player's client issue the command instead (which is supported).
ConnectionManager.Instance.Clients.ForEntityId(player.entityId)
?.SendPackage(NetPackageManager.GetPackage<NetPackageConsoleCmdClient>().Setup($"removequest {questId}", true));

Could also be an even better way to do it: NetPackagePlayerData.ProcessPackage
GameManager.SavePlayerData will apply the modified quest journal to the player... possibly... if you set the _cInfo.entityId value to the target player's entityId (i.e. suggest it's a request coming from the client that the player is controlling)

Example listing all quests by ID and POI name (Console Command)
private void ListQuests(CommandSenderInfo senderInfo)
{
    EntityPlayer player;
    if (senderInfo.RemoteClientInfo == null)
    {
        player = GameManager.Instance.World.GetPrimaryPlayer();
        if (player == null)
        {
            SdtdConsole.Instance.Output("No remote or local player could be found.");
            return;
        }
    }
    else if (!GameManager.Instance.World.Players.dict.TryGetValue(senderInfo.RemoteClientInfo.entityId, out player))
    {
        SdtdConsole.Instance.Output("Could not find remote player.");
        return;
    }

    for (int i = 0; i < player.QuestJournal.quests.Count; i++)
    {
        SdtdConsole.Instance.Output($"{player.QuestJournal.quests[i].ID}. {player.QuestJournal.quests[i].GetPOIName()}");
    }
}

Confirmed this is working now, but trader relationship doesn't update until log out/in; looking into that now


add git to installation instructions

closes #22 B-)
I guess power-users will realize that they don't have to install git and will just read over that line.

@haesleinhuepf I admire your chutzpah 😂  but I really dislike this proposal. Cookiecutter doesn't depend on conda at all and there's exactly 0 guarantee that any user, including non-power users, have conda installed.

@tlambert03 I guess if you agree we can just close this. Sorry @haesleinhuepf, we love you! 😂

Yeah, thank you! But I agree with @jni


Distributed issues

Opening in favor of #148.
~1. DQN with target networks update based on the number of training steps. So distributed mode DQN will update the target faster than intended since it will count each batch example as a timestep.(https://github.com/reinforceio/tensorforce/blob/master/tensorforce/models/model.py#L566).~
Edit: Timestep is handled by act not update so this is a non issue.

Global optimizer will need to use .read_value() for the global variables otherwise they will be a cached version of the global variables and in my original testing lag 1-2 steps behind.
(https://github.com/reinforceio/tensorforce/blob/master/tensorforce/core/optimizers/global_optimizer.py#L67)

Hey @Islandman93, I read about the problem that variables are cached and can cause inconsistencies in some circumstances. If this is the case here, would you mind creating a PR with a working .read_value() solution?

What is the status of this?


Remove comma before "that"

Looked at all files alphabetically through docs/framework/windows-workflow-foundation.
Also removes trailing whitespace so recommend diffing with ignore whitespace changes turned on.

@BillWagner Thanks for the review!


feat: Branch odometer reads

@cclinard84 Any ideas how to refactor the method BCH doesn't like?

Create the dictionaries in separate methods


add check to not rerun job contained in the cache

@ar-siddiqui do you think there may be a good use case to not destroy the sync results in case of repeated requests? Also, should we add a check to see (stop) jobs that are identical?

There is definitely a case for having a regular cache for sync processes that are not dependent on resources, for example, finding max min flood level for a location. If the user, submits multiple such requests within a short time we return the same result. But for the processes dependent on other resources (and we have discussed that they will not be synced) we can't have a cache because the underlying resources (like raster) may have changed, and the user is requesting a new run.
We can check the timestamp on files to see if they have been updated, but that may be overcomplicating things.


Makefile, bpf/Makefile: silence error messages in 'clean-tags' target

Silence the following error message which occur if the tag files don't
exists:
make[1]: Entering directory '/home/vagrant/go/src/github.com/cilium/cilium/bpf'
rm cscope.out cscope.in.out cscope.po.out tags
rm: cannot remove 'cscope.out': No such file or directory
rm: cannot remove 'cscope.in.out': No such file or directory
rm: cannot remove 'cscope.po.out': No such file or directory
rm: cannot remove 'tags': No such file or directory
Makefile:23: recipe for target 'clean-tags' failed
make[1]: [clean-tags] Error 1 (ignored)
Also ignore rm's exit status.
Signed-off-by: Tobias Klauser<EMAIL_ADDRESS>

Thanks @tklauser!


Speed up HTTP2 check

This PR adds a quick check for missed HTTP2 connections before we try to use the frame parser from Go. This reduces Beyla's CPU usage on the OTel demo from 25% to less than 3%.

Codecov Report
Attention: Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.

Project coverage is 35.31%. Comparing base (e406a94) to head (eed7f1b).
Report is 1 commits behind head on main.

Files
Patch %
Lines

pkg/internal/ebpf/common/http2grpc_transform.go
48.64%
16 Missing and 3 partials :warning:

pkg/internal/ebpf/common/tcp_detect_transform.go
0.00%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #923       +/-   ##
===========================================
- Coverage   78.92%   35.31%   -43.62%
===========================================
  Files         131      130        -1
  Lines        9862     9936       +74
===========================================
- Hits         7784     3509     -4275
- Misses       1572     6029     +4457
+ Partials      506      398      -108

Flag
Coverage Δ

integration-test
?

k8s-integration-test
?

oats-test
35.31% <46.15%> (-0.24%)
:arrow_down:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(models): :construction: add comment models

Codecov Report

Merging #2 into master will increase coverage by 6.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   69.05%   75.13%   +6.08%
==========================================
  Files           8        8
  Lines         711      720       +9
==========================================
+ Hits          491      541      +50
+ Misses        220      179      -41

Impacted Files
Coverage Δ

pyyoutube/__init__.py
100% <ø> (ø)
:arrow_up:

pyyoutube/models.py
82.94% <100%> (+10.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44ba7e...eafc5e8. Read the comment docs.


tf.nn.softmax overflow due to exp(x)

From reading the doc and code of tf.nn.softmax, it looks like this function naively call a _softmax function which may have the overflow problem if the x in exp(x) is too big. (underflow can happen, too)
This is a typical problem of machine learning, and googling 'log sum exp' gives some information. TF even has a function reduce_logsumexp to calculate the value in a robust way.
I think it makes sense that nn.softmax also use similar method of reduce_logsumexp. I ran into a loss  = NaN today and suspect this is the cause.
Thanks,

I'm not so sure you can do the exact same thing. That method is taking into account that if you scale the computation based on the range of the existing values, you can exp and reduce (sum) in a space where there is more floating accuracy. You'd have to do that scaling and return the caling to the user. That would make for a complicated interface for users of tf.softmax.  As you say this is a known problem, which is why we have reduce_logsumexp (and softmax_cross_entropy_with_logit), but tf.nn.softmax may be useful in other situations.

note that softmax does subtract the maximum logit, so the max value it will exponentiate will be 0.  I don't think this is the cause of your NaN.  Without more information it's hard to say.

This issue is automatically closed due to lack of activity. Please re-open if this is still an issue for you. Thanks!

@ekelsen I read this statement also regarding other softmax functions such as tf.nn.sparse_softmax_cross_entropy_with_logits. However, I do have this issue. Using TFdebug I figured out that an nan value (inf) often results from the output of the softmax calculation done within sparse_softmax_... Shouldn't this be impossible using a max value subtraction?

Another source of NaNs in sparse_softmax can be from passing in an int label that is >= than the number of dimensions in the logits. Hope that helps.


maxConcurrency variable declared globally

If one is using through2-concurrent across multiple modules at the same time in a node application, which each module defining its own level of maximum concurrency, the last one in wins.  That is, all the instances will use that level of max concurrency.  This is because the maxConcurrency variable is defined without the 'var' keyword causing it to be defined globally.

Oh wow, that's embarrassing! I've fix it and also added a "use strict" declaration so that mistakes like that will cause an obvious error.


feat: Delete wallet & Organization (BE)

Tasks:

[x] Implement API to delete organization
[x] Implement delete organization data in keycloak

Agent is spun up - Applied validations to check if any connection, ceredential and presentation and wallet is exists against that orgId
Agent is not spun up - Applied validations to check if any user or invitation is exists against that orgId
If only organization is created and if no data against that orgId, then organization should be deleted directly

[x] Implement API to delete wallet
[x] Implement API to delete organization invitations

Duplicate Issue: https://github.com/credebl/platform/issues/741

Pending Todos:
Backend

[ ] User should not be able to access the schema and credential definition from a different network


Cannot push null values into number field

Cannot push the following values into a number field from a csv.
Example csv:
a,b,c
a,1,a
b,NULL,b
c,,c

to clarify, this is the string 'NULL' that is being populated by sql server in leu of simply having an empty field

Correct


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 11:03:29 on 2023.04.20
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 2, errors out: 0
Original problem ID: 19789
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=19789

Problem has been resolved in 27m 0s at 11:30:29 on 2023.04.20
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 19789


"Share via link" still keeps the file open on Windows

Describe the bug
windows链接分享文件，对方下载后，退出链接分享界面。但是分享的文件一直被localsend占用，无法删除
To reproduce
链接分享文件，对方下载后，退出链接分享界面。但是分享的文件一直被localsend占用，无法删除windows
Expected behavior
返回主界面，应该解除文件占用。
Screenshots
No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional context
No response

if u share via link, large file better, then open browser and download this file,  immediately goto cancel download process ,  the file handle is forever be open, till programs exits.
i see download code :  send_controller.dart line 207
 return Response(
          200,
          body: File(file.path!).openRead(),
          headers: headers,
        );

the file open as stream, if has exception throw on the socket, for example the download connection broken.  the file stream never be closed.


raidboss: initial triggers for The Excitatron 6000

Description
Adds triggers for The Excitatron 6000 treasure map dungeon.
Additional Notes
There are two possible bosses for the final chamber; triggers are mostly complete for Lucky Face, but I am missing logs for Lucky Sphinx.

This all looks good to me.  Do you think this is worth merging and just leaving the rest as a TODO for a future PR?

This all looks good to me. Do you think this is worth merging and just leaving the rest as a TODO for a future PR?

The alternate final chamber boss continues to elude me; I'm going to mark this one ready for merge and hopefully come back to it when I finally see the Sphinx.

Thanks for all these trigger contributions lately! It's all super appreciated.


Ignore unchanged files

Requires some dependency analysis.

Need a local cache, remember compiled file, hashes, dependencies.


SPY-1859: SessionCatalog.lookupRelation enhancement

What changes were proposed in this pull request?
if the table name is of CSD's proprietary form, we remove version partitioning
information so that our custom hdfs file/dir selector path can be triggered.
this is to help CSD to transition to partition version scheme and maintain
backward compatibility for old queries
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

The failure does not seem caused b this PR.


nodePackages.prisma: 4.6.0 -> 4.6.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

We should close this, more recent version here: https://github.com/NixOS/nixpkgs/pull/203630

superseded by https://github.com/NixOS/nixpkgs/pull/203630


Split relay config onto multiple lines

Split the carbon-relay configuration section so there is one
configuration parameter per line. The relay will not start otherwise.

Oh how odd! Don't know how that has happened! Thanks!

No problem, thanks for the book! Really enjoying it thusfar.


Move logging to structlog and centralize logging

This PR resolves #277 by integrating structlog into the logging system. A new config format using json is added to allow both the default logger to be adjusted as needed as well as additional config related to structlog. Both pretty printing and json logging can now be toggled via an environment variable LOG_WITH_JSON as well as a new logconfig.json file setting in case no envonrment variable is provided. If neither of these are set then we fall back to json logging as requested. in addition all print statments have been removed.
Due to the limitations of structlog and the limited ability to modify 3rd party code structlog's processors where used to override the logging handled by uvicorn manually. logconfig.json can be adjusted to wrap other loggers from other libraries as needed for users.

[X] Logs should be structured, and streamed to stdout
[X] Output should be determined based on the environment as per [Pretty Printing vs. Structured Output]
[X] Format should be parameterized via an Environment Variable, defaulted to JSON
[X] No print statements used to send output to console

In addition more work is necessary to format database logging from the *-db services. The latest acapy version seems to support --log-json-fmt which should be enough to help us support this in the vc-authn-aca-py service.
Example json logging

Example pretty printing

Looking good overall! Just a few suggestions and nitpicky comments to keep the code as clean as possible 🙂


gitea: 1.5.3 -> 1.6.0

Motivation for this change
Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.6.0
from the security section:

Add CSRF checking to reqToken and add reqToken to admin API routes
Improve URL validation for external wiki and external issues
Make cookies HttpOnly and obey COOKIE_SECURE flag
Don't disclose emails of all users when sending out emails
Check that repositories can only be migrated to own user or organizations

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build gitea

Let's see aarch64 does not run into trouble with thread limits on the second try:
@GrahamcOfBorg build gitea

@GrahamcOfBorg test gitea

@GrahamcOfBorg build nixosTests.gitea

aarch64 fails with
runtime: failed to create new OS thread (have 6 already; errno=11)
runtime: may need to increase max user processes (ulimit -u)
fatal error: newosproc

Same problem with the last PR: https://github.com/NixOS/nixpkgs/pull/50229
However, Hydra could build it: https://hydra.nixos.org/build/85306028


[Desktop] [Mobile] Feed screen | Filter section Location not as in Figma design

env: https://staging.fightpandemics.work/feed
Steps:

Open Feed screen
Go to Filters -> Location
In the search box we have a wrong tooltip, wrong search icon
Arrow is different then the design
Share My Location text has a different size/font
Application:

Figma:

Im waiting on the design team to for the new share my location logo.


[GOBBLIN-536] Add user configured properties to mysql connection string

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-536

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Add user configured properties to mysql connection string

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@htran1 please review


Always blank after powered down

Whenever I restart the wemos D1 mini there are no IR controls stored. Should they be save in the file system between restarts?

No they are not saved. Storing them doesn’t really provide any benefit anyway it’s more just for debugging and setup
Sent from my iPhone

On Nov 21, 2017, at 15:08, Stephen Hall<EMAIL_ADDRESS>wrote:
Whenever I restart the wemos D1 mini there are no IR controls stored. Should they be save in the file system between restarts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

OK. I think I didn't get the point :) after it has been received you just need to keep a copy of the message to send. I was thinking it had to keep a copy of the message to send out but it's all contained in the http message. Thanks I understand now.


Added some error checking do countdown project

Type of change

[ ] Added new project
[ ] Bug fix
[x] New features
[ ] Enhanced documentation

Changes proposed in this pull request

Project name :

Countdown

Short description :

Added a try and except around the code to run the program , to catch bad user input
Checklist

[X ] The code is Python 3 compatible
[ ] I have added relevant comments in my file to make code understandable
[ X] I have added my project in a folder which includes all the necessary files

Added troubleshooting for README.md on Internet-speed-test project

@herepete

Looks good to me
@herepete thanks for your contribution 🚀


Add a section on using nextest

Inspired by this question: https://github.com/rust-lang/miri/issues/2805

@bors r+

:pushpin: Commit 93794b7e6916c441ad97c11b7b4f7382ae905651 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 93794b7e6916c441ad97c11b7b4f7382ae905651 with merge f115296d0dd5ec974b615206efd55d33eb56c834...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing f115296d0dd5ec974b615206efd55d33eb56c834 to master...


allow subscription id to be specified

In our use case, we wanted to be able to specify subscription id.
I've added an optional third id option to sub method.

Coverage remained the same at 100.0% when pulling 542c954dcab9bf74b8233ded60a54fc956d7b75b on the-shell-inc:master into a0d0083b6a1601572fe6670066725a5a5cfe6fdd on mondora:master.

Thanks for the PR! Could you add a test for the case? Otherwise LGTM

Coverage remained the same at 100.0% when pulling 48d8408c5dbdbac625fb1b70deb7e85147072810 on the-shell-inc:master into a0d0083b6a1601572fe6670066725a5a5cfe6fdd on mondora:master.

Coverage remained the same at 100.0% when pulling ff0098b7e26df1e72dc844da8f266cfc75551907 on the-shell-inc:master into a0d0083b6a1601572fe6670066725a5a5cfe6fdd on mondora:master.

Thanks! 👍

thank you too for nice work!

I've published 2.2.0 with your change. Let me know if all works as expected. :-)

thanks! worked very well :)
it needs an update on asteroid too. creating a pull request on asteroid in a bit.


Add "crop_top" and "ellipsis_top" options for vertical overflow of live display

Type of changes

[ ] Bug fix
[x] New feature
[ ] Documentation / docstrings
[ ] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
Hi!
I tried to use Live to display continuously updating stream of text and realized that existing vertical overflow options are pretty inconvenient. I'd like new lines to appear at the bottom of the console window so that only the latest information is displayed. So I added "crop_top" option for it, and also "ellipsis_top" for symmetry.

You're better of with Textual for this kind of thing...


Create a page where a user can customize & download config.php

With support for:

Editor selection for IDE:// links in called from
Permanent link a-la jQueryUI embeded so one can download the latest version at any time
Framework selection for path replacement in called from display
Customize shorthand functions (when they're implemented properly)

Not applicable to 2.0


Il 311 UI change first name

A structure has been created for UI automated tests.
Change first name test has been added.

Hooray, finally we will have UI tests, thank you! 🎉
The code itself LGTM, but I have to request changes, because I get the following error:
(venv) astriganova@annsmac ilsinyakov % python -m pytest ./UI
ImportError while loading conftest '/Users/astriganova/Desktop/Projects/forks/ilsinyakov/UI/conftest.py'.
UI/conftest.py:2: in <module>
    from selenium import webdriver
E   ModuleNotFoundError: No module named 'selenium'

I suspect that there is a missing dependency in UI/requirements.txt

Ann, hello!

There is selenium in requirements.txt. (See screenshot, please)
I think, that you used requirements.txt from root of repository.
Directory UI this is independent project. You must use it's requirements.txt.
Best wishes, kindness, peace, Ilya.

@ilsinyakov, thanks, I now see that it's actually in ./UI/requirements.txt, but why then the command below didn't install it... 🤔
pip install -r ./UI/requirements.txt

Could you please share the command that you use for installing dependencies for UI?

Could you please share the command that you use for installing dependencies for UI?

pwd = UI
pip install -r requirements.txt
Best way is to start pytest from "UI" directory:
pytest
It is also necessary to consider that the chromedriver must be installed in your operating system.


Its COM port is not showing after flashing

Its COM port is not showing after flashing this app from m5burner. COM port of this device gets detected for a blink time when I reset it by pressing and releasing the reset button (long holding of reset button does not work)

Hey! You should maintain G0 button and then press reset button to enter flash mode, it's not due to my app 😓
Anyway, I would suggest to flash M5Launcher, then download to SD card the firms that you want to try and install them, or install them directly through OTA ;)


Avoid redefining toJSON if already present.

rewrite as
if ('toJSON' in Error.prototype) {
  return;
}

and I will merge


Vim9: variable wrongly locked when saving option value

Describe the bug
In Vim9 script, sometimes, we cannot save an option in a buffer-local variable, because the variable is locked, even though we never asked to lock it.
To Reproduce
Run this shell command:
vim -Nu NONE --cmd 'au VimEnter * ++nested edit /tmp/file | tabe /tmp/file' -S <(cat <<'EOF'
    vim9script
    writefile([''], '/tmp/file')
    au BufWinEnter * Func()
    au BufWritePost * windo Func()
    def Func()
        b:name = &l:fdm
    enddef
    timer_start(0, () => execute('w'))
EOF
)

E741 is raised:
E741: Value is locked: name

It doesn't happen all the time.  If no error is raised, you might need to quit and re-run the command a few times.
Expected behavior
E741 is never raised because b:name is not locked by :const, :final, or :lockvar.
Environment

Vim version: 8.2 Included patches: 1-2301
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(363)

Additional context
Regression introduced in 8.2.2193.

The issue disappears when Func() is re-written in a legacy function:
vim -Nu NONE --cmd 'au VimEnter * ++nested edit /tmp/file | tabe /tmp/file' -S <(cat <<'EOF'
    vim9script
    writefile([''], '/tmp/file')
    au BufWinEnter * Func()
    au BufWritePost * windo Func()
    fu Func()
        let b:name = &l:fdm
    endfu
    timer_start(0, () => execute('w'))
EOF
)

The issue disappears when we save something else than an option value; e.g. a number like 123:
vim -Nu NONE --cmd 'au VimEnter * ++nested edit /tmp/file | tabe /tmp/file' -S <(cat <<'EOF'
    vim9script
    writefile([''], '/tmp/file')
    au BufWinEnter * Func()
    au BufWritePost * windo Func()
    def Func()
        b:name = 123
    enddef
    timer_start(0, () => execute('w'))
EOF
)

Workaround: wrap the assignment in an :exe:
# ✘
b:name = &l:fdm

# ✔
exe 'b:name = &l:fdm'

Which gives:
vim -Nu NONE --cmd 'au VimEnter * ++nested edit /tmp/file | tabe /tmp/file' -S <(cat <<'EOF'
    vim9script
    writefile([''], '/tmp/file')
    au BufWinEnter * Func()
    au BufWritePost * windo Func()
    def Func()
        exe 'b:name = &l:fdm'
    enddef
    timer_start(0, () => execute('w'))
EOF
)

Workaround: wrap the assignment in an :exe:
# ✘
b:name = &l:fdm

# ✔
exe 'b:name = &l:fdm'

Which gives:
vim -Nu NONE --cmd 'au VimEnter * ++nested edit /tmp/file | tabe /tmp/file' -S <(cat <<'EOF'
    vim9script
    writefile([''], '/tmp/file')
    au BufWinEnter * Func()
    au BufWritePost * windo Func()
    def Func()
        exe 'b:name = &l:fdm'
    enddef
    timer_start(0, () => execute('w'))
EOF
)

The issue has nothing to do with the unpredictability inherent to a timer, nor with the side-effects of :windo.
Where I found this issue, there is no timer, and no :windo.
The timer can be removed; but then we need to execute :w manually.
:windo can be replaced with a combination of map(), getwininfo() and win_execute(), without the issue being affected.
Here is more context on the real code.

The issue has nothing to do with the unpredictability inherent to a timer, nor with the side-effects of :windo.
Where I found this issue, there is no timer, and no :windo.
The timer can be removed; but then we need to execute :w manually.
:windo can be replaced with a combination of map(), getwininfo() and win_execute(), without the issue being affected.
Here is more context on the real code.

I managed to reproduce it manually, valgrind reports using uninitialized memory.
But haven't been able to have a test trigger this valgrind warning.

I managed to reproduce it manually, valgrind reports using uninitialized memory.
But haven't been able to have a test trigger this valgrind warning.


switch over to using  instead of , assuming fixed length ge…

…neration
https://github.com/lucidrains/DALLE-pytorch/issues/21

@sdtblck Hey Sid! Maybe this change will make it less confusing

@sdtblck Hey Sid! Maybe this change will make it less confusing


What about web components?

Hi everyone!
I tried Web Components and Styled Components together and they work well... the only thing is that the theme is not shared across the host and the child.
Now I am sharing the theme as an attribute but it is not the best solution
import theme from '../../../'

[...]

<rwc-app theme={JSON.stringify(theme)}/>

React Context does not pass between nested React instances, so there's no way to directly share it between web components either. What I've done here is to put the theme on the window, then each WC can grab it from the window to use inside the WC like you're likely using your theme value here.
I have some ideas of a context equivalent for web components, but that's a side idea at best right now.


Chairs sometimes don't buckle you

Description

Sometimes, when trying to buckle yourself or someone else (player or mob), the chairs while immediately unbuckle.
Probably needs reproducing.
Screenshots

Additional context

Relevant info (probably irrelevant):
Launcher used: Steam Version
Distro: Arch Linux
Linux Version: 5.17.4-arch1-1
Xfce Version: 4.16
WM: Xfwm 4.16.1 (revision 5f61a84ad)
Xorg version: 21.1.3-6
GPU: AMD RX 580
GPU drivers: amdgpu, xf86-video-amdgpu (22.0.0-1)
CPU: AMD Ryzen 3 3200G

Reproduction steps:
walk and press on a chair

And I think it might have fixed itself

It still happens, trust me.


Rename of import should be a local rename

TypeScript Version:  nightly (2.2.0-dev.20170213)
Code
import { readFileSync } from "fs";
readFileSync("a.txt");

Rename readFileSync to read.
Expected behavior:
import { readFileSync as read } from "fs";
read("a.txt");

Actual behavior:
import { read } from "fs";
read("a.txt");

And @types/node/index.d.ts is modified too!

The current behavior is exactly what I expect and want.
To rename all instances of something in a given file, Ctrl+D is really useful.

What editor are you using? What does Ctrl+D do?

I think it would be better to leave the current way as it is, and use this trick to do the alias rename only

Initial
import { readFileSync } from "fs"

Use alias
import { readFileSync as readFileSync } from "fs"

Rename alias (right readFileSync to read)

Unfortunately there is related bug: https://github.com/Microsoft/TypeScript/issues/10894

@andy-ms Ah, sorry; I was actually thinking of this as an editor feature/tool, rather than a language one (kind of surprises me that the language itself controls this). I use VS Code. Ctrl+D selects other strings of text matching the one you have highlighted. This is multi-line selecting, so you can edit all of them at once. Exceedingly useful feature.

I think the behavior should depend on the context, but I am not sure it is possible.
Say, given
import { readFileSync } from "fs";
readFileSync("a.txt");

If the cursor is in the readFileSync call, I'd expect renaming it to create an alias; while if I either go to the definition, or rename it from the import specifier itself, to rename the symbol definition.
A similar issue exists with object shorthand notation (renaming a symbol that's used in shorthand also renames its object key, instead of separating the key/value).

Related to #19173 and #15787

@krryan

Ah, sorry; I was actually thinking of this as an editor feature/tool, rather than a language one (kind of surprises me that the language itself controls this).

It makes a lot of sense for the language to control this; correct refactorings require deep knowledge of the semantics of the language being edited.

I use VS Code. Ctrl+D selects other strings of text matching the one you have highlighted. This is multi-line selecting, so you can edit all of them at once. Exceedingly useful feature.

It is a useful approximation when you don't have better tools for the job, i.e. semantically-aware refactorings.
I think this change is needed, at least in the case where a refactor would end up editing a file under node_modules; that's never what you meant to do.


Install command should fit in the box

/kind documentation
What mistake did you find / what is missing in the documentation?
Ok, I'll admit this is a bit of a nit, but currently the installation commands at https://odo.dev/docs/installing-odo/ that you copy/paste to install odo are not fully visible and you need to drag as you copy. IMHO they should be fully visible up front, e.g. either make the boxes wider or the font smaller.
What is the relevance of it?
I have two reasons for this request:

It's slightly awkward to start copying and have to drag in the middle and make sure you get it all; also a potential to miss a bit of it.
If I'm paranoid I can't actually see what it is doing to my system without pasting elsewhere or scrolling back and forth. Would be better to just see it all up front.

Probably we can do the following two things to improve the UX of odo installation:

Adjust box and font size to provide a better view
Add clipboard button to the top right of the box so that user doesn't need to worry about drag & copy

Similar example can be found here: https://docs.openshift.com/container-platform/4.4/cli_reference/developer_cli_odo/installing-odo.html

We do use the clipboard button on https://docs.openshift.com/container-platform/4.4/cli_reference/developer_cli_odo/installing-odo.html so I assume this issue is relevant only to docs on odo.dev

Yes, this is just for odo.dev.

Yes, there is no issue of https://docs.openshift.com/container-platform/4.4/cli_reference/developer_cli_odo/installing-odo.html, I mean we can use https://docs.openshift.com/container-platform/4.4/cli_reference/developer_cli_odo/installing-odo.html as an example to follow for odo.dev improvement work.

Still noticing this compared with other clis, we should at least 'copy the copy button' from docs.openshift.com.
/remove-lifecycle stale

/remove-lifecycle stale


Summary values have incorrect format

Checklist:

[X] I updated to the latest version available
[X] I cleared the cache of my browser

Release with the issue:
v0.0.4
Browser and Operating System:
Chrome/Firefox Windows, Android, Mac

Description of problem:
showSummary doesn't appear to be following column format.  No matter what the format is set for the column, the summary is always an unformatted number.
Example:

header: '%'
attr: changePercent
format: percentage
showSummary: true

The values in the column before the summary are formatted as % but the summary comes across as currency maybe?  I cannot tell.

header: Value
attr: totalValue
format: currency
showSummary: true

The values in the column as currency with a comma between thousands in the values, but the summary is just a straight number with no formatting at all.

I agree with the currency value being formatted incorrectly, when it comes to summarizing percentage values I'm not sure how it would work correctly as just summarizing individual percentage values would most likely show an incorrect value for the entire card


How can I addField to object, not an array?

Hi there! I want to use redux-form with dynamic fields that are objects and not arrays, e.g. I want to dynamically add new field, that is not listed in form fields settings. How can I achieve this?
E.g. my fields setting
  const fields = [
    'id',
    'geometry.type',
    'geometry.coordinates',
    'properties[]'
  ]

Now I can dynamically add new properties as array, but I want to treat it like an object, because properties is an JSON object and it may change later on form usage, so I need something like properties{} or something else.
I think, that I can store keys-indexes accordance somewhere and handle it somehow on form changes (e.g. addField with index) but it's really not so good as it can be with using properties as object.

You may pass the fields array as a prop, which means that the component containing your decorated form can add or remove items from it. This is demonstrated in the Dynamic Form example. You may put any arbitrary items into your properties array, but if you want them to be keyed and for the input events to be handled by redux-form, you will have to specify their shape, and they all must have the same shape...
const fields = [
  'id',
  'geometry.type',
  'geometry.coordinates',
  'properties[].name',
  'properties[].value'
];

...as seen in the Deep Form example.
Does that help?

Hi @erikras! I think that it may work, thanks for reply!


Bug in default gemspec spec.executables

From @stephan-nordnes-eriksen on June 27, 2014 13:23
I recently experienced a bug with the default spec.executables in the gemspec generated after "bundle gem new_gem".
I added a folder into a /bin folder, and that caused the command to remove sub-folders in the path of the executables.
spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }

Example:
If you have a file stored like this:
bin/sub_binary_folder/some_executable.extension

It will be added as:
bin/some_executable.extension

And thus the gem won't build.
To fix this, I made the following change:
spec.executables   = spec.files.grep(%r{^bin/}) { |f| f[3..-1] }

It is a bit crude, but it essentially strips away the extra "bin/" which is prepended to the path.
Copied from original issue: bundler/bundler-features#57

From @indirect on June 27, 2014 16:41
I'm not totally convinced this is a bug. Folders in bin doesn't really make sense for a gem, because Rubygems and Bundler will create files in a bin directory for each of the gem bins. it would be equally weird to have a subdirectory in /usr/bin; your PATH wouldn't make sense anymore.
Why do you want to create folders in bin? What's the problem you are trying to solve?
On Fri, Jun 27, 2014 at 6:23 AM, stephan-nordnes-eriksen
<EMAIL_ADDRESS>wrote:

I recently experienced a bug with the default spec.executables in the gemspec generated after "bundle gem new_gem".
I added a folder into a /bin folder, and that caused the command to remove sub-folders in the path of the executables.
spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
Example:
If you have a file stored like this:
bin/sub_binary_folder/some_executable.extension
It will be added as:
bin/some_executable.extension
And thus the gem won't build.
To fix this, I made the following change:
spec.executables   = spec.files.grep(%r{^bin/}) { |f| f[3..-1] }
It is a bit crude, but it essentially strips away the extra "bin/" which is prepended to the path.
Reply to this email directly or view it on GitHub:
https://github.com/bundler/bundler-features/issues/57

From @stephan-nordnes-eriksen on June 27, 2014 21:56
I have thought a bit about this, and to me it seems like an artificially enforced best practice. Yes, it might be best practice to have a flat structure in the bin-folder, but I don't really see any good reason for why you shouldn't be allowed to make a folder structure if you wanted to. You might have a bunch of related binaries in one folder for instance.
In my case I ran into this issue sort of unwillingly because I simply copied a bin-folder from a completely different project which I needed. It had a more complex structure and included some non-executable files. I could possibly have put it somewhere else, but the bin-folder was the most natural one.
Anyways. I do think it is an issue that could be addressed. If the decision is to have a flat structure it would be beneficial to inform about this somewhere, somehow, so that others like me would not run into these strange errors.

From @indirect on June 28, 2014 4:23
I'm not quite sure I buy that. The actual Ruby code that is run by your gem is explicitly agreed to be in lib. Putting a directory in bin means that Rubygems will either ignore it entirely (which I think is the case) or it will try to create an entire directory somewhere in your PATH. The entire point of the gem bin is so that Rubygems knows what to put into the directory on your PATH. Unix paths aren't designed to work with subdirectories, so it's very strange to me that you want to put directories into your bin.

@indirect what do you think we should do about this? Close as a wontfix?

ping @indirect

@colby-swandale thanks <3
@segiddins I think we can probably close this. If you put directories in bin, it's up to you to change the gemspec to exclude the directory from the list of executables.


[core] undo help.yaml changes in #8325, #8503 and #8535

Due to the transitions and the high cost-to-benefit ratio, the help.yaml project is being reverted. help.yaml issues will be closed. None help.yaml issues should still be addressed.

[x] Undo changes in #8325, #8503 and #8535
[ ] Ensure that there is no diff in generated sphinx documentation before and after
[ ] Undo extensions documentation changes in https://github.com/Azure/azure-cli-extensions/pull/503/

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

Hi @adewaleo , why do you add [Do Not Merge] label here?

Hi @adewaleo , why do you add [Do Not Merge] label here?

Hello @Juliehzl. I did so because we weren't sure if you wanted to keep the help.yaml changes or not. This PR is meant to undo it, but Travis suggested that we do not undo it because you might want to keep the changes. I will forward you a mail thread about this.

This PR stays for a long time. Close it right now. Please let us know if you still need this PR.


Introduce github actions

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8b0f7e6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   86.39%
=========================================
  Files             ?       18
  Lines             ?      272
  Branches          ?        7
=========================================
  Hits              ?      235
  Misses            ?       37
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b0f7e6...26b27de. Read the comment docs.


Use high compression in msi.

This takes msi installer size down to 104 MB from the current 146.
Which is still 20% more than what InnoSetup produces (80 MB), but I guess that's as good as we are gonna get.

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks!


Rename "Dual license" to "Selling exceptions" and expand

"Dual license" normally means something different, namely releasing one project under two or more licenses simultaneously, often for broader compatibility with other Open Source licenses. For instance, the Rust project is dual-licensed under MIT and Apache 2.0. "Dual license" doesn't normally describe the business model of selling separate alternative non-copyleft licenses.
Expand the text a bit, to clarify what kinds of companies might purchase such exceptions (not all companies prefer non-copyleft), and to allow for other legal structures in doing so.

Hmm. @joshtriplett what do you think about calling it Commercial licenses? I like these edits, just trying to think of a term that's a bit more descriptive.

selling is a speculation. Companies might provide a service that contains patented algorithms or there could be reasons when internal software licensing is unclear, so exposing it to public to comply to copyleft bring too much legal pain. Open sourcing things inside of corporations is hard.

I agree that Dual licensing means different things, so License exceptions probably a better name.

How about "Alternate licenses or exceptions"? "Alternate licenses" more clearly describes the concept of offering a different license separately from the primary license, and "or exceptions" includes the case of offering an exception to the existing license rather than a completely separate license.

Dual licensing and exceptions should cover all required parts of copyright law. But the text is about getting paid. License is kind of legal enforcement, so applying it to open source is weird.
I would leave it Dual license, but remove Apache and MIT from the code with just two choices Commercial License and Open Source. Often commercial license is just a legal way to provide support.

If OSI license contains exceptions, it is not OSI anymore, so it just providing two separate licenses - each with its own bonuses/conditions even if the code stays the same.

@joshtriplett Alternate licenses is clearer, but still feels vague, especially as it doesn't seem clearly distinguished from the Restricted license category further down.
Is there a reason why you'd rather not use Commercial license as a category name?

@nayafia Because I don't want to propagate the misconception that Open Source licenses are non-commercial.
@techtonik Licenses with exceptions can still be Open Source licenses. (For instance, consider the common case of GPL with an exception for OpenSSL; that's still an Open Source license.)

How about "Copyleft with paid exceptions/alternatives"? (I think we can consider alternative ways of "paying" to still be "paid exceptions/alternatives".)

@joshtriplett Copyleft + paid license?

@nayafia I can live with that.

@joshtriplett OSI licenses are non-commercial, because they don't force people to give money, but they don't limit people to selling the software if anybody wants to buy it.

Licenses with exception are not Open Source licenses.

Can I restrict how people use an Open Source licensed program?
No. The freedom to use the program for any purpose is part of the Open Source Definition. Open source licenses do not discriminate against fields of endeavor.

https://opensource.org/faq#restrict

Actually, linking to https://opensource.org/faq#commercial is a good idea.

@techtonik

@joshtriplett OSI licenses are non-commercial, because they don't force people to give money, but they don't limit people to selling the software if anybody wants to buy it.

In the context of software licensing, "non-commercial" has a fairly specific meaning: commercial purposes not allowed. All OSI licenses are required to allow commercial use.

Licenses with exception are not Open Source licenses.

Exceptions aren't additional restrictions, they're additional permissions.

@joshtriplett Updated and merged! Thanks for these edits, they're great.


The mercenary is alive, but he has to resurrect him every time

v0.4.4
The mercenary is alive, but he has to resurrect him every time.

Known issue. For some it work (e.g. on my machine) others have very bad template detection scores when the merc using alpha channel. You can either copy the current template into your release or download 0.4.4 release again. I reuploaded it with the old merc template.


fix [ansible] quality service test

Fixes #5283
Apparently there's been some upstream changes in the API which is now returning a proper 404 response code in the unknown project id scenario whereas before it was a 200 response with a body that was identical to a valid/known project that had no score.
This updates the existing test to handle the invalid project scenario and also adds an extra test to cover the no score available scenario (https://galaxy.ansible.com/s2504s/datadog). This was a project that was referenced as an example ~18 months ago when the badge was first added, so it seems to be a sufficiently stable test target.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @calebcartwright!

  Generated by :no_entry_sign: dangerJS against cd3e41fb4c588e854d54b736769753169617ef40


Frameless windows

Describe the Feature
The ability to hide the default title bar in browsers, thus enabling the possibility of creating a custom one.
Use Case
I'm currently trying to develop a desktop web app. It's not my first time building one, as I've start by using frameworks like Electron and Tauri.
If I understand correctly, this is not a framework but a library that enables the developer to create such apps with pretty much any backend language. Its mission is not to try and add all the functionalities that exist in the previously mentioned frameworks (or any others for that matter).
I've seen this commented on before (discussion and some comment on an issue found on the same discussion), but I can't seem to make it work on my end.
I've also seen that the feature "kiosk mode" is already available, but I also think that this one could enhance the desktop app, making it feel more like a desktop app rather than a fancy web browser (which it still is), and there are already multiple apps that have this feature (Teams, Discord, VS Code, and others).
But if the frame/title bar is hidden, we also need API calls to minimize, maximize, and close the app. I know I can close the app by binding a call from the backend, but I'm not sure about the other ones.
Proposed Solution
I guess it can be done the same way as with kiosk mode: void webui_set_frameless(bool status).
I'm not sure how the other three calls should be implemented, but I would like to have the calls available in webui.js as well, the same way as webui.isConnected().
Other Information
No response
Implementation

[ ] I may be able to implement the feature.
[ ] It might incur a breaking change.

Version
WebUI v2.4.2
Environment details (OS name and version, etc.)
AMD64 Family 25 Model 33 Stepping 0 (???)

I didn't know that it was possible with that version and with Firefox. When I find more time, I'll try it out.
To be honest, I would try to implement it myself and make a PR, but I have a problem: I don't understand the code, in the sense that I didn't write it, and I don't have a good grasp of the architecture/project.
The only way I can think of to learn how to understand the project is by reading it from start to finish and then trying to do things, but I don't think I have enough understanding to keep up with the project. So, sorry I can't help now (I really wish I could, since I like the project so far).
If it's of any help, or if it sounds useful, I could publish the template I'm building for my app. It's just Solid-ts as the frontend, and I'm using zig-webui as backend. I'll also be creating the webui.d.ts (since it's needed for TypeScript projects) that could allow building apps with any TypeScript framework. But, once again, I'm creating this for myself and to learn, so I'm not sure if it will be useful.
Anyway, thank you for considering implementing it, and if the idea of publishing the template or the d.ts sounds useful, I could do it.

I may work about an external C/C++ library that manipulates windows on Windows. (It will not be related directly with the WebUI to avoid harming the portability of WebUI, however WebUI will be first class citizen).  Technically I would support changing title, icon, opacity, appearance (including with the borders/frames) and placement Windows internal APIs. Even more if I find a way to adjust the background, I may support DWM effects like Mica or Acrylic.
It would be good to support fluent web components on Mica background. It also may increase the interest of WebUI.

This is related only to WebView2 on windows, you can easily create "offscreen" web views and render them with hardware acceleration into D3D11 textures. The only catch is that you have to pass input events to the compositor. I created a sample gist will all the things you need to make it work.
You can use it straight away as game overlay or inside your composition pipeline


MLClient Job.get function  returns JobParsingError

azure-ai-ml:
1.12.1:
Mac OSX:
3.10:

Describe the bug
When running the function to get the job status MLCllient.job.get(jobname) of a batch job in Azure ML, it raises an error. Error class is Error Class
To Reproduce
Steps to reproduce the behavior:

Deploy an Azure ML Job in Azure Machine learning workspace.
Get the batch job name
Attempt to invoke the call to get the job status - Execution to Get Job Status Documentation
Error response is - {'type': 'JobParsingError', 'message': "Expecting (<class 'str'>, <class 'azure.ai.ml.entities._assets.environment.Environment'>) for environment, got <class 'dict'> instead."}

Expected behavior
The function should return return the Job class that allows you to access properties of the job

Hi @Uzzije. Thanks for reaching out. Can you please let us know how you are submitting the job? Please, share as much code as possible.

Hi team,
Even I am facing the similar error. It was working until now and out of nowhere we started facing this issue.
model_submit.txt

Thanks for sharing the details. We are working on identifying the root of the issue. Hopefully and can come back soon with directions.

Hi, i'm basically running the job the same @amalprem stated. From investigating the issue, it seems the failure occurs here azure.ai.ml.entities._builders.command.Command._attr_type_map. This snippet  "environment": (str, Environment), is getting a type dict hence this traceback error -
Exception: Expecting (<class 'str'>, <class 'azure.ai.ml.entities._assets.environment.Environment'>) for environment, got <class 'dict'> instead..
Traceback (most recent call last):
  File "/opt/conda/envs/myenv/lib/python3.10/site-packages/azure/ai/ml/entities/_job/job.py", line 310, in _from_rest_object
    return PipelineJob._load_from_rest(obj)
  File "/opt/conda/envs/myenv/lib/python3.10/site-packages/azure/ai/ml/entities/_job/pipeline/pipeline_job.py", line 566, in _load_from_rest
    sub_nodes = PipelineComponent._resolve_sub_nodes(properties.jobs) if properties.jobs else {}
  File "/opt/conda/envs/myenv/lib/python3.10/site-packages/azure/ai/ml/entities/_component/pipeline_component.py", line 380, in _resolve_sub_nodes
    sub_nodes[node_name] = pipeline_node_factory.load_from_rest_object(obj=node)
  File "/opt/conda/envs/myenv/lib/python3.10/site-packages/azure/ai/ml/entities/_job/pipeline/_load_component.py", line 268, in load_from_rest_object

I'm getting a similar issue. It was working fine just a week ago.
I'm running a batch job: ml_client.batch_endpoints.invoke(), returns a "BatchJob" object.
Taking that object's "name" property and going to ml_client.jobs.get() no longer works and blowing up with:
JobParsingError: Expecting (<class 'str'>, <class 'azure.ai.ml.entities._assets.environment.Environment'>) for environment, got <class 'dict'> instead.

We have identified an issue in our service an a patch has been applied. We are rolling out the update to all the regions as we speak and you can expect the roll out to be completed by tomorrow, except for the region East US 2 which will be patched the day after. Apologies for the inconvenience. I will update this thread once the deployment is completed.

We have identified an issue in our service an a patch has been applied. We are rolling out the update to all the regions as we speak and you can expect the roll out to be completed by tomorrow, except for the region East US 2 which will be patched the day after. Apologies for the inconvenience. I will update this thread once the deployment is completed.

The fix has been deployed to all public regions. Customers should no longer experience this problem now.

We have validated that the patch has fixed the issue. We will close this issue, but please reopen it if you find any further problem using the service.


In shared/behaviors/pageable.html prevPage function changes the page index to negative numbers

prevPage function changes the current page index to negative values. The current page index should not go less than "0".
Solution
In the file, line number, 66
		prevPage: function() {
			if (this.page > 0);
				this.page--;
		},

The line with if condition should not end with ";".

thank you. merged.


BROOKLYN-305: handle invalid xml chars in attribute vals

I'm not convinced by this approach (calling a special method XmlUtil.xpathHandlingIllegalChars(), which retries the xpath having escaped the illegal characters). It works well enough for us because we are just making very basic use of xpath - it is primarily to just extact the entity id from the xml file, before we try to fully deserialize it.

LGTM

Thanks @duncangrant - merging now.
We can later look at including in our persisted state:
<?xml version=\"1.1\" encoding=\"UTF-8\"?>

But a very quick test gave the error below, which I still need to look into:
com.thoughtworks.xstream.io.StreamException:  : only 1.0 is supported as <?xml version not '1.1' (position: START_DOCUMENT seen <?xml version="1.1"... @1:19)


Fixed_subfolder_issue_in_Index.html

Se agrega "./" a todas las rutas

Hi @AMIGONA100
Kindly open the PR into v1.4.0
Thanks!

Hi @AMIGONA100
Still waiting on your PR into the v1.4.0 branch


Report: Last activities at Projects

Hello @vinijmoura ,
FOr a good maintenance of AzDO org, i think that it would be great to have a report where is a list of projects (and the owners of the projects) and last activity regarding last update in Boards / work items, Repos last update, TEst Plans last update, Pipelines last update, Wiki last update, and so on.
Then it will be useful to decommission projects or contact with admins to know what happens with the project.
;)

Hello @aldodfm
I just created a report based on Project Stats :-)
See the link https://vinijmoura.medium.com/how-to-project-stats-mapping-on-azure-devops-63ca0f0d4ca


unexpected equinix_ecx_l2_connection state: NOT_PROVISIONED

A user reported the following error:
Error message:
Error: error waiting for connection (...id omitted...) to be created: unexpected state 'NOT_PROVISIONED', wanted target 'PROVISIONED, PENDING_APPROVAL, PENDING_BGP_PEERING, PENDING_PROVIDER_VLAN'. last error: %!s(<nil>)
 with equinix_ecx_l2_connection.synapse,
 on peer.tf line 151, in resource "equinix_ecx_l2_connection" "example":
 151: resource "equinix_ecx_l2_connection" "synapse" {

Duplicate of #238


items not dismounted in useTransition

Encountered some bugs trying to convert my <Transition> to useTransition. Tried to remove most of my code to find the bug but couldn't make it behave correctly. (Un)luckily it seems it's also failing in the CodeSandbox examples.
https://codesandbox.io/embed/1y3yyqpq7q
If you look in the DOM, the pages are not dismounted. Just fades to opacity: 0 while more and more pages are mounted.

This was fixed today (7.1.1).

I'm no<EMAIL_ADDRESS>😭

I forked and updated the CodeSandbox to use 7.1.1. Does not work. https://codesandbox.io/s/vvlx67m375

You're right ... weird. We just had this issue. Hand in there. :-)
CC @ruggedy

Gonna have a look

Thanks @ruggedy ! Released a patch: 7.1.2

resolved by #378

@drcmda @ruggedy this bug seems to be back, check https://codesandbox.io/s/98j711344o and observe class='bg' in the Inspector. It doesn't get unmounted. I bumped react-spring to v7.2.7 in this Sandbox.


Support for running application as non-root user inside GSC docker conatiner

Description of the problem
Support for running the application as non-root user inside GSC docker container is needed.
Steps to reproduce

Create GSC docker with non-root user
Run the application inside docker container as non-root user. Ex, sudo -u

Expected results
Should be able to run the application as non-root user inside docker container
Actual results
Running application with non-root user fails with below error.

xargs sudo -u ovsa /ovms/bin/./ovms --grpc_bind_address <IP_ADDRESS>^M
MODEL_SERVER_PID=130^M
echo 'Model Server PID: 130'^M
Model Server PID: 130^M
echo 'Starting Nginx...'^M
Starting Nginx...^M
sudo: PERM_INITIAL: getresuid: Function not implemented^M
sudo: unable to initialize policy plugin^M
MODEL_SERVER_EXIT_CODE=123^M
echo 'Model server job finished with an exit code: 123'^M
Model server job finished with an exit code: 123^M
sudo -u ovsa nginx -g 'daemon off;'^M
NGINX_PID=102^M
echo 'Nginx PID: 102'^M
Nginx PID: 102^M
echo 102^M
wait 102^M
sudo: PERM_INITIAL: getresuid: Function not implemented^M
sudo: unable to initialize policy plugin^M
NGINX_EXIT_CODE=1^M
echo 'Nginx job finished with an exit code: 1'^M
Nginx job finished with an exit code: 1^M

#60 was merged, which should have solved this issue. Closing.


ASP core 3.1 Update

Hi, can you please release an update on the ASP Core version

Would be sweet :D

I have successfully updated from 2.2 to 3.1 :)

Hi @gaman547  can you share a link, was it straight forward

Has anybody had a successful update to 3.1?


errorCode logic not valid in rule cloudtrail_mfa_policy_abuse_attempt

Background
In the rule cloudtrail_mfa_policy_abuse_attempt the errorCode is not properly checked as part of the rule logic:
https://github.com/airbnb/streamalert/blob/d5c658fc73f5dad6c6577bd462a85f38102b1c10/rules/community/cloudtrail/cloudtrail_mfa_policy_abuse_attempt.py#L62-L70
It seems the intent is only to alert if there is any error for a CreateVirtualMFADevice or EnableMFADevice event. But because errorCode is specified in optional_top_level_keys, it actually gets assigned a default value of str(), even if there is no error.
https://github.com/airbnb/streamalert/blob/d7a879b9b463d9a304328e1d170a27f118ff5cb0/stream_alert/rule_processor/parsers.py#L245-L248
Description
The errorCode key is always set in records, regardless of an error or not, so the rule logic is not valid.
Steps to Reproduce

Sign into the AWS Console without MFA
Activate a new virtual MFA device
Observe the alert
For bonus points, check the event in CloudWatch to double check the actual event had no key errorCode in the event JSON.

Desired Change
Modify the rule to check if errorCode is not an empty string

Thanks for reporting this! We will definitely fix this, but how would you feel about taking a crack at it?

Sure, happy to submit a PR for this 👍