Passing a multi-element array to Image causes a crash on Android

Description
Hey RN maintainers,
I've made a repo with this one, which I hope is reproducible. The crash happens at least on Android Emulator, but we've also reproduced it on a Pixel 5. The repo was created with expo, but I'm not sure if that makes much of a difference.
The error message is Error while updating property 'src' of a view managed by: RCTImageView.
I've also posted this question on StackOverflow, as it might be a mistake on my end instead of an actual bug.
Version
0.69.5
Output of npx react-native info
info Fetching system and libraries information...
System:
    OS: macOS 12.6
    CPU: (8) arm64 Apple M1
    Memory: 775.95 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.7.0 - ~/.nvm/versions/node/v18.7.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.7.0/bin/yarn
    npm: 8.18.0 - ~/.nvm/versions/node/v18.7.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8815526
    Xcode: 14.0/14A309 - /usr/bin/xcodebuild
  Languages:
    Java: 15.0.2 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.0.0 => 18.0.0
    react-native: 0.69.5 => 0.69.5
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
I've made a repo, opening it on Android Emulator crashes the app on launch.
Snack, code example, screenshot, or link to a repository
https://github.com/flowchase/break-image-component

Does it work when you add width and height to each source object in the array?

@danilobuerger Yes, that makes the problem go away. The issue is, with these network images, I can't be sure what width/heights I'll be getting as they are assets uploaded by the team.

The error message could be better, but the docs are clear:

This prop can also contain several remote URLs, specified together with their width and height and potentially with scale/other URI arguments.

https://reactnative.dev/docs/image#source

Damn, I missed that. Do you know why it doesn't break on iOS?

Interestingly this is recent, since we upgraded to RN 0.69.5. Android didn't crash in our last build.

Can we consider this resolved?

I'd argue the behavior is sub-optimal, especially considering it's more of a regression (it didn't happen in 0.64). But by all means, go ahead and close it, as it is technically the intended behavior on your end.


Closing consumer client hangs if unable to connect to broker

Our application attempts to do a clean shutdown if we detect problems connecting to a customer's Kafka cluster or receive too many errors in some other part of the system.  As part of that process we do a Client.Close() to behave nicely.  We've discovered that in several situations -- basically, where the client was never able to connect to the broker successfully to begin with -- the Client.Close() call just hangs, waiting for either a metadata response or a loadCoordinator response that will never succeed, and unable to exit the related retry loop for those requests.
It appears that the only Context that can exit those loops is the Client.ctx, but that is simply a CancelContext with no option to override and no external way to call the cancel() function.  This is making it impossible to exit our application cleanly.
Is there something I'm missing here that will allow us to actually "kill" the client completely in these circumstances?

Do you have a way to repro this?
I've tried two things:
package main

import (
	"fmt"
	"os"
	"time"

	"github.com/twmb/franz-go/pkg/kgo"
)

func main() {
	cl, _ := kgo.NewClient(
		kgo.ConsumeTopics("foo"),
		kgo.WithLogger(kgo.BasicLogger(os.Stderr, kgo.LogLevelDebug, nil)),
	)

	time.Sleep(time.Second)
	cl.Close()
	fmt.Println("done")
}

In this case, nothing is running on localhost:9092, so no requests will ever succeed. This exits successfully:
$ go run .
[INFO] immediate metadata update triggered; why: querying metadata for consumer initialization
[DEBUG] opening connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0
[WARN] unable to open connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0, err: dial tcp <IP_ADDRESS>:9092: connect: connection refused
[INFO] metadata update triggered; why: re-updating metadata due to err: unable to dial: dial tcp <IP_ADDRESS>:9092: connect: connection refused
[DEBUG] opening connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0
[WARN] unable to open connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0, err: dial tcp <IP_ADDRESS>:9092: connect: connection refused
[INFO] metadata update triggered; why: re-updating metadata due to err: unable to dial: dial tcp <IP_ADDRESS>:9092: connect: connection refused
[DEBUG] opening connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0
[WARN] unable to open connection to broker; addr: <IP_ADDRESS>:9092, broker: seed_0, err: dial tcp <IP_ADDRESS>:9092: connect: connection refused
done

Case 2:
package main

import (
	"fmt"
	"os"

	"github.com/twmb/franz-go/pkg/kfake"
	"github.com/twmb/franz-go/pkg/kgo"
	"github.com/twmb/franz-go/pkg/kmsg"
)

func main() {
	kf := kfake.MustCluster()

	requested := make(chan struct{})
	kf.ControlKey(3, func(kmsg.Request) (kmsg.Response, error, bool) {
		fmt.Println("metadata is requested")
		close(requested)
		select {}
		panic("foo")
	})

	cl, _ := kgo.NewClient(
		kgo.SeedBrokers(kf.ListenAddrs()...),
		kgo.ConsumeTopics("foo"),
		kgo.WithLogger(kgo.BasicLogger(os.Stderr, kgo.LogLevelDebug, nil)),
	)

	<-requested
	cl.Close()
	fmt.Println("done")
}

In this case, the kfake cluster never returns a metadata response.
$ go run .
[INFO] immediate metadata update triggered; why: querying metadata for consumer initialization
[DEBUG] opening connection to broker; addr: <IP_ADDRESS>:56189, broker: seed_0
[DEBUG] connection opened to broker; addr: <IP_ADDRESS>:56189, broker: seed_0
[DEBUG] issuing api versions request; broker: seed_0, version: 3
[DEBUG] wrote ApiVersions v3; broker: seed_0, bytes_written: 31, write_wait: 62.875µs, time_to_write: 11.709µs, err: <nil>
[DEBUG] read ApiVersions v3; broker: seed_0, bytes_read: 233, read_wait: 16.75µs, time_to_read: 96.125µs, err: <nil>
[DEBUG] connection initialized successfully; addr: <IP_ADDRESS>:56189, broker: seed_0
[DEBUG] wrote Metadata v12; broker: seed_0, bytes_written: 43, write_wait: 851.75µs, time_to_write: 8.875µs, err: <nil>
metadata is requested
[DEBUG] read Metadata v12; broker: seed_0, bytes_read: 0, read_wait: 36.042µs, time_to_read: 91.542µs, err: client closed
done

Still, the request is canceled and the client exits.

While trying to reproduce I found a deadlock in a custom hook.  My apologies.


Add grabber code

This is the issue I created to add in your code.

This was done with Paul's code in commit #28


[Color Picker] Suggestions for improvement

A few suggestions to improve Color Picker.
GUI

When copying a color (in a specific format) it is good to have visual confirmation, but it would be nice if the "Copied to clipboard" message did not overlap with the list of formats. (is a nit though)

Settings

Toggle switches are widely used in (Windows) Settings nowadays, but I believe that in this case check boxes should be used. Because changing one of the check boxes does not directly start a new action or change something, the changes will only be visible in a different GUI that can't be used at the same time as when you're changing settings.

For a binary choice, the main difference between a check box and a toggle switch is that the check box is for status and the toggle switch is for action. You can delay committing a check box interaction (as part of a form submit, for example), while you should immediately commit a toggle switch interaction. Also, only check boxes allow for multi-selection.

https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/checkbox

Choosing between toggle switch and check box
For some actions, either a toggle switch or a check box might work. To decide which control would work better, follow these tips:

Use a toggle switch for binary settings when changes become effective immediately after the user changes them.
Use check boxes for optional ("nice to have") items.
Use a checkbox when the user has to perform extra steps for changes to be effective. For example, if the user must click a "submit" or "next" button to apply changes, use a check box.
Use check boxes when the user can select multiple items that are related to a single setting or feature.

https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/toggles

In the Windows Settings for languages, the list can be manually ordered and the top-most item is used as default. We can akso use the format on the top of the list to automatically be the one that will be copied. It would remove need for the dropdown combo/list. Which, to be honest, is pretty redundant.

When dragging one of the formats (to re-order the list) the item itself is invisible.

Open question: what color would make sense to use in the examples of the different formats? I suggest the current system accent color can be used in all the examples.

Personal preference would be to "start small" when ordering the text/actions in the radio buttons. For example: I would start with the simple  color picker on top. But again: personal.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

Adding the tracker label as there are multiple asks

Gui

Use the actual window height as minimal size and enable the user to change the window height to show all formats.
(Nor sure if this is a must have because the user can move the important formats on top of the list.)

I would definitely vote against notifications. Those should not be used often. Usually they are only used when an app has something to say, but the app is running in the background and has no window to show the information. Like new e-mail (in Mail app) or messages from a website (in a browser) or Windows system messages.

@jay-o-way, hate to do this to you but 1 ask per issue.  too hard to track otherwise


Add sql generation to Database module

Assign it to me, please.

ok

@cieslarmichal - Is there any progress made for this issue? If this needs to be tackled, I can give it a try. Can we get more clarity on what needs to be done? Is the ask to generate SQL statements (guessing data insertion scripts) for various engines involved here?

I think you can work on this :)
Basically you can create a sqlCommand function that takes one enum parameter to choose which type of command to use
These SQL commands are mainly categorized into five categories:
DDL – Data Definition Language.
DQL – Data Query Language.
DML – Data Manipulation Language.
DCL – Data Control Language.
TCL – Transaction Control Language.

So given query param you could generate something like SELECT email, name from users; where users and table columns can be randomized from some array, also there can be some chances to limit or offset appended to the end of query.
Given manipulation param it would be something like INSERT into users (id, name, email) VALUES ('id', 'name', 'email@gmail.com');
Similar to that you can do other commands like update, delete, grant, revoke etc.
Hope it helps, good luck!

https://github.com/cieslarmichal/faker-cxx/pull/532


⚠ Bofrost.de has degraded performance

In 5555222, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1214 ms

Resolved: Bofrost.de performance has improved in 1467ded after 7 minutes.


Coveralls

add coveralls

coverage to be at least 80%

Update:
deal with gradle and its plugin
including jacoco and codecov

jacoco moved to the next milestone


UI on the UI and UI Menu layers still interact without opening the in game menu

If UI is on the UI or UI Menu layer, they should not be interactable unless the menu is open.

Fixed in v0.3.4 with ffada50744c81024d8c716e2547fdf5ae0672b91
Note that standard interacts on UI and UI Menu layer will still interact, but this is a different bug.


switch to using crosswalk-app-tool

requires the next version of crosswalk-app-tool, so need to wait for that in order to set the dependency correctly :/

manually merged these changes...closing.


Allow adding Colorpleth map as a layer to an existing map

Hi,
I just discovered this library and I think it's really nice and elegant! My problem is that I already have
a Vue2Leaflet map and only want to add a Colorpleth map as a GeoJSON layer.
I guess it should not be too complicated to implement this as a layer + controls rather than a complete solution? I think this can be very useful!
Thanks!
Omri

Hi,
you're definitely right! I think moving the v-geojson-layer from the ChoroplethMap component to a new one (like ChoroplethLayer or something) would be a possible approach, and changing the API so you include it inside the scoped slot (like InfoControl and ReferenceChart).
This way, for your use case you could use this new ChoroplethLayer component into your map, without the whole ChoroplethMap component.
I'll look into this with a little time. If you end doing the separation yourself for your use case, feel free to send a PR :)
Thanks!


Allow authentication with bearer token on alerts and alertmanager commands

Cortextool client only supports authToken on rules command. This PR adds authToken argument to alerts and alertmanager commands.

LGTM, thank you!


masked secret key display

Masked secret key display with * . Provided an option to reveal the value if desired .

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.muhammed safvan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Screencast from 26-04-23 06:20:09 PM IST.webm

@Safvan-tsy, are you able to check the CI jobs, some of them are failing.
Also, let's only use the react-icons/fi package, there are similar icons there that are more consistent with the rest of the UI (it also bloats the package so much that the FF build fails).
Suggest running: yarn lint to see these too

@Safvan-tsy Do you want to mask the input as well as part of your PR here?

@Safvan-tsy, are you able to check the CI jobs, some of them are failing.
Also, let's only use the react-icons/fi package, there are similar icons there that are more consistent with the rest of the UI (it also bloats the package so much that the FF build fails).
Suggest running: yarn lint to see these too

Unfortunately I am travelling. Will definitely check it out.👍

@Safvan-tsy Do you want to mask the input as well as part of your PR here?

no

changed to react-icons/fi

@markmhx should this be assigned to me and included with the PR to mask key on sign in?

@fbwoolf this can go live with the other sign in work or released separately, whatever's easiest on your end. I presume it's code complete and just needs rebasing and merge?

Closing this in favor of: https://github.com/hirosystems/wallet/pull/3800


doc: Add instructions for creating PG read-only replica

Add instructions to PostgreSQL article on creating a read-only replica.

Ah. Now we use this for commit messages :)
e.g.
doc(postgresql): add instructions for creating read-only replica

hey, @staceysalamon-aiven! 👋
may we please get rid of duplicated commits in this PR?
also, please check https://conventionalcommits.org/en/v1.0.0/ out, thank you!


Fix how curveTo2 (v operator) is translated to SVG

Based on PDF spec, page 133, with v operator, current point should be used as the first control point of the curve.
Do not overwrite current point before an SVG curve is built, so it can be actually used as first control point.

Interesting. Do you have an actual PDF file that is broken because of this? I think the fix is fine because we do that already in the canvas back-end, see https://github.com/mozilla/pdf.js/blob/794744c3fad3411a886b697cd3c4c6cb96725880/src/display/canvas.js#L1229-L1241.

Unfortunately I don’t have an image readily available that I could share in a public forum.
I can try to come up with one, but I don’t have experience creating PDFs, so it’ll take some time.

/botio-linux preview

Thank you!


[FEATURE] Return error message sent from backend instead of standard message in ResponseError

Describe the feature
In case of error, it is important to know the reason of failure. In our use case, we need to display the reason for failure to the user. The backend sends the reason for failure in the error message, but pdk internally returns standard static message : "Response returned an error code". Is there a way to get the actual error message that the backend returns? If not, we should update this to pass back the actual error message sent by the backend.
Code:
protected async request(context: RequestOpts, initOverrides?: RequestInit | InitOverrideFunction): Promise<Response> {
        const { url, init } = await this.createFetchParams(context, initOverrides);
        const response = await this.fetchApi(url, init);
        if (response && (response.status >= 200 && response.status < 300)) {
            return response;
        }
        throw new ResponseError(response, 'Response returned an error code');
    }

export class ResponseError extends Error {
    override name: "ResponseError" = "ResponseError";
    constructor(public response: Response, msg?: string) {
        super(msg);
    }
}

Use Case
There's a UI screen that can fail for multiple reason. We need to tell the user the exact reason for the failure. We send the exact reason from backend but there's no way to get it in frontend with the current code.
Proposed Solution
response is already present in the code, just need to propagate the message in the final function.
Other Information
No response
Acknowledgements

[X] I may be able to implement this feature request
[ ] This feature might incur a breaking change

PDK version used
0.23.38
What languages will this feature affect?
Typescript, Java
Environment details (OS name and version, etc.)
Linux

Hi @raghibomar786,
Thanks for raising this! It would definitely be nicer if the generated typescript client returned the error message by default!
Sadly the way the generated typescript client is generated by OpenAPI generator, it doesn't extract the body of an error response. The long term fix for this is to completely own our own templates for the generated client, so we can adjust how errors are handled by default. I'm not sure when we'll be able to do this as it will take a bit of work.
The way I've worked around this for projects using PDK is to add some middleware to the client which throws the error earlier than when the generated client throws the generic ResponseError. You can pass the middleware when you instantiate the client. This might look something like this if you use the CloudScapeReactTsWebsite:
In packages/website/src/hooks/useTypeSafeApiClient.ts:
import useSigV4Client from "@aws-northstar/ui/components/CognitoAuth/hooks/useSigv4Client";
import { DefaultApi as MyApiApi, Configuration as MyApiApiConfiguration, BadRequestErrorResponseContent, InternalFailureErrorResponseContent, NotFoundErrorResponseContent, NotAuthorizedErrorResponseContent, Middleware, ResponseContext } from "myapi-typescript-react-query-hooks";
import { useContext, useMemo } from "react";
import { RuntimeConfigContext } from "../components/RuntimeContext";

// Interface for API errors
export interface ApiError {
  readonly status: number;
  readonly details:
    | BadRequestErrorResponseContent
    | InternalFailureErrorResponseContent
    | NotFoundErrorResponseContent
    | NotAuthorizedErrorResponseContent
}

export const isApiError = (e: unknown): e is ApiError =>
  !!(e && typeof e === "object" && "status" in e && "details" in e);

/**
 * Middleware for handling API errors
 */
const errorHandlingMiddleware: Middleware = {
  post: async ({ response }: ResponseContext) => {
    if (response && response.status >= 400 && response.status < 600) {
      let details;
      try {
        details = await response.json();
      } catch (e) {
        // Unable to parse response body, so continue with default error handling
        return response;
      }
      throw <ApiError>{
        status: response.status,
        details,
      };
    }
    return response;
  },
};

export const useMyApiApiClient = () => {
  const client = useSigV4Client();
  const runtimeContext = useContext(RuntimeConfigContext);

  return useMemo(() => {
    return runtimeContext?.typeSafeApis?.["MyApi"]
      ? new MyApiApi(
          new MyApiApiConfiguration({
            basePath: runtimeContext.typeSafeApis["MyApi"],
            fetchApi: client,
            // Add the middleware here
            middleware: [errorHandlingMiddleware],
          })
        )
      : undefined;
  }, [client, runtimeContext?.typeSafeApis?.["MyApi"]]);
};

It then becomes possible to access the actual error response from the hooks, eg:
import { Alert } from "@cloudscape-design/components";
import { ApiError, errorTitle, isApiError } from "../../hooks/useTypeSafeApiClient";
import { useSayHello } from "myapi-typescript-react-query-hooks"

export const ExampleComponent = () => {

  const hello = useSayHello({ name: "Jack" });

  return hello.error && isApiError(hello.error) ? (
    <Alert type="error" header="Error">
      {hello.error.details.message}
    </Alert>
  ) : ...;

};

Hope that helps!
I'll leave this open as I think we can improve things by providing this middleware or similar as part of the generated client, which isn't as heavy a lift as owning all the templates for the generated typescript fetch client.
Cheers,
Jack


Initial split of mrlegacy into hdfs and mr

Moving mrlegacy directory to hdfs, starting minimal mr directory, repointing references to mrlegacy everywhere.

There should be far less in mahout-hdfs than mahout-mr according to Dmitriy so I'd have started with nothing in mahout-hdfs and depend only on that in math-scala and spark. Start by migrating the missing classes. The debugger (IntelliJ IDEA) will flag missing definitions so much of it can be done with copy and pasting of files between mahout-mr and mahout-hdfs

Obviously too many changes for diffing, sorry.

Moved the contents of hdfs over to mr since there are more things staying in mr apparently.

i can't seem to see mods to spark/pom.
only the following files need to go to the shared module are really necessary dependency for /spark and spark-shell (unless something new happened):
/MatrixWritable.java
/MatrixWritableTest.java
/Varint.java
/VarintTest.java
/VarIntWritable.java
/VarLongWritable.java
/VectorWritable.java
/VectorWritableTest.java
There also was that Pair thing but it just needs to be replaced by regular scala's Tuple2 IMO in the code that uses it

Pair was remove awhile back

also def findMahoutJars needs to be adjusted to reflect new backend deps.

Yeah I don't see the spark/pom changes too but they're just like the others plus removal of a large comment for profiles.

I don't find "findMahoutJars" anywhere; where is that?

@andrewmusselman you need to fix filters line ~203 of ...sparkbindings/package.scala in the spark module.
mrlegacy out, hdfs in.

@andrewmusselman also: this code relies on reading output of mahout -spark classpath. Please double check running this is producing correct mahout jars. please double check the hdfs jar is reported there correctly.

findMahoutContextJars

Also: there's test that tests the classpath correct detection in SparkBindginsSuite. It is "ignored" because it requires correct MAHOUT_HOME and mahout compiled (which is not the case during CI build). But you can change "ignore" to "test" and try to run it. It should print the mahout spark context path and also asserts that it fished out exactly 4 jars there.

will fail then because the new dependency-reduced jar should also be included making it 5

why? we are replacing, not adding
On Thu, Mar 26, 2015 at 3:10 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

will fail then because the new dependency-reduced jar should also be
included making it 5
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86736028.

anyhow, nothing fails on my branch.
Granted, i don't run stuff like co-occurrence though.
On Thu, Mar 26, 2015 at 3:13 PM, Dmitriy Lyubimov<EMAIL_ADDRESS>wrote:

why? we are replacing, not adding
On Thu, Mar 26, 2015 at 3:10 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

will fail then because the new dependency-reduced jar should also be
included making it 5
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86736028.

Because Guava and Scopt are required for Drivers and they should be all that is included in that assembly jar

Actually IndexedDataset requires guava, drivers require scopt, and cooccurrence requires neither.

No.
Guava is included with hadoop. Assuming spark backend is set up correctly
with Mahout, it should see Guava 11 classes.
Scopt (cli option parser) must not be needed in the workers.
On Thu, Mar 26, 2015 at 3:20 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

Because Guava and Scopt are required for Drivers and they should be all
that is included in that assembly jar
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86737683.

Right, scopt is not needed for workers.
Guava is shaded in Spark (as of 1.2) and not sure what is in Hadoop. I ran into missing classes from Guava until I provided the jar and anyhow it makes the jar brew rather fragile if we rely on external things accidentally provided in Mahout or Spark as the move to Spark 1.2 shows.
All this makes me think that explicit jars should be provided in the future, not discovered. Spark stores optional jars in an "External" directory. Leave it for 0.10.1 though where we may want to rethink how we launch things.

Guava is shaded in spark exactly for the reason that hadoop already have
guava 11.  naming clashes caused conflict. there is no other reason.
So if anything, there's both guava 11 and 14 in the backend (although 14 is
shaded, and wouldn't be picked up). shipping yet another one is not only
unnecessary, but actually may mess it all up again.
On Thu, Mar 26, 2015 at 3:52 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

Right, scopt is not needed for workers.
Guava is shaded in Spark (as of 1.2) and not sure what is in Hadoop. I ran
into missing classes from Guava until I provided the jar and anyhow it
makes the jar brew rather fragile if we rely on external things
accidentally provided in Mahout or Spark as the move to Spark 1.2 shows.
All this makes me think that explicit jars should be provided in the
future, not discovered. Spark stores optional jars in an "External"
directory. Leave it for 0.10.1 though where we may want to rethink how we
launch things.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86745349.

As far as "reliance", i don't see how we can change spark java namespaces.
afaik spark doesn't isolate worker namespace from its own or hadoop's
dependencies (nor it probably should, since everything is built for
compatibility on class serialization level).
On Thu, Mar 26, 2015 at 4:07 PM, Dmitriy Lyubimov<EMAIL_ADDRESS>wrote:

Guava is shaded in spark exactly for the reason that hadoop already have
guava 11.  naming clashes caused conflict. there is no other reason.
So if anything, there's both guava 11 and 14 in the backend (although 14
is shaded, and wouldn't be picked up). shipping yet another one is not only
unnecessary, but actually may mess it all up again.
On Thu, Mar 26, 2015 at 3:52 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

Right, scopt is not needed for workers.
Guava is shaded in Spark (as of 1.2) and not sure what is in Hadoop. I
ran into missing classes from Guava until I provided the jar and anyhow it
makes the jar brew rather fragile if we rely on external things
accidentally provided in Mahout or Spark as the move to Spark 1.2 shows.
All this makes me think that explicit jars should be provided in the
future, not discovered. Spark stores optional jars in an "External"
directory. Leave it for 0.10.1 though where we may want to rethink how we
launch things.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86745349.

Although i suppose we could shade guava once again independently of spark
and hadoop, but i won't do it (for lack of "shading" expertise), and at any
rate, it would just inflate my job submission once again even though none
of my jobs are using guava. Guava use is exclusive to the co-occurrence
recommender. Therefore, if it needs to be listed for a particular method,
it needs to be listed in "customJars" attribute to the
"createMahoutContext" call. That's why it exists. To add jars not everyone
needs.
Aside from that, dependency conflicts are always a big issue, down to the
point of nightmares (e.g. try to embed spark context into a play
application just for the fun of it), and actually mahout is having it
super-easy so far. Believe me. Even spark having these nightmares with
hadoop, it looks like. We are nothing new really in that.
On Thu, Mar 26, 2015 at 4:08 PM, Dmitriy Lyubimov<EMAIL_ADDRESS>wrote:

As far as "reliance", i don't see how we can change spark java namespaces.
afaik spark doesn't isolate worker namespace from its own or hadoop's
dependencies (nor it probably should, since everything is built for
compatibility on class serialization level).
On Thu, Mar 26, 2015 at 4:07 PM, Dmitriy Lyubimov<EMAIL_ADDRESS>wrote:

Guava is shaded in spark exactly for the reason that hadoop already have
guava 11.  naming clashes caused conflict. there is no other reason.
So if anything, there's both guava 11 and 14 in the backend (although 14
is shaded, and wouldn't be picked up). shipping yet another one is not only
unnecessary, but actually may mess it all up again.
On Thu, Mar 26, 2015 at 3:52 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

Right, scopt is not needed for workers.
Guava is shaded in Spark (as of 1.2) and not sure what is in Hadoop. I
ran into missing classes from Guava until I provided the jar and anyhow it
makes the jar brew rather fragile if we rely on external things
accidentally provided in Mahout or Spark as the move to Spark 1.2 shows.
All this makes me think that explicit jars should be provided in the
future, not discovered. Spark stores optional jars in an "External"
directory. Leave it for 0.10.1 though where we may want to rethink how we
launch things.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86745349.

Fair point about custom jars feel free to create a Jira for 0.10.1 BTW I was you who asked for an assembly jar with "included" dependencies only when we discussed this exact issue before. Also feel free to change the code.

not sure what you are referring to. We never discussed backend classpaths.
we (well, I) discussed front end classpath, yes, and only for the issue of
scopt inclusion into it, which is 180 degrees different issue. But i never
suggested to change a bit in the backend classpath. Actually, if anything,
by doing the refactoring, i effectively reduced it to the minimum necessary
by throwing away mrlegacy behemoth.
On Thu, Mar 26, 2015 at 4:22 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

Fair point about custom jars feel free to create a Jira for 0.10.1 BTW I
was you who asked for an assembly jar with "included" dependencies only
when we discussed this exact issue before. Also feel free to change the
code.
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/83#issuecomment-86751727.

actually custom jars won't work here since it is in cooccurrence, not the driver.
I'll give this a spin tomorrow.

OK so no classes have been moved, just the structure created?
I'll start by moving the classes Dmitriy lists. The job jar should be part of mahout-mr so that will be moved.

That's right, just the structure; let me know what I can do next.

All other pending PRs will be messed up with this so starting now.

intermediate branch that compiles here: https://github.com/pferrel/mahout/tree/MAHOUT-1655


Add new APIs for nested predicate pushdown

Currently, Parquet's org.apache.parquet.filter2.predicate.FilterApi is using dot to split the column name into multi-parts of nested fields. The drawback is that this causes issues when the field name contains dot.
The new APIs that will be added will take array of string directly for multi-parts of nested fields, so no confusion as using dot as a separator.
See https://github.com/apache/spark/pull/27728 and [SPARK-17636] for details.
Reporter: DB Tsai
Note: This issue was originally created as PARQUET-1809. Please see the migration documentation for further details.

Gabor Szadovszky / @gszadovszky:
It would be nice to use string arrays (or maybe more properly ColumnPath objects) instead of the dot strings in all code parts but it seems to be a huge effort. And, in case of the mentioned configuration keys, it is not possible.
The problem with using '.' characters in column names is the potential collisions may occur in case of schemas like the following one:

message Document {
  required group foo {
    required int64 bar
  }
  required int64 foo.bar
}

Gabor Szadovszky / @gszadovszky:
I am afraid, it is not only the filter API that is affected by this problem. There are many places in the code that uses the dot string to address nested columns.
If we allow dots in column names it would break backward compatibility: old readers will not be able to read new files.
Also, we address column names in configs (e.g. switching bloom filters on/off for specific columns) so we have to deal with the string-column path conversion. If dots are not separator characters any more what else shall we use that we won't allow to be in the column names? Or, should we implement an escaping mechanism for such characters?

DB Tsai:
cc  @rdblue

Hi @gszadovszky
In Spark, we don't run into issues reading / writing parquet files containing dots as part of the column names. Can you elaborate the issues you are referring? There are people using parquet files with dots in production with Spark, and Spark has tests showing it works.
However, the only issue we have is Parquet's filter2.predicate.FilterApi is using dots as separators, so we intentionally disable predicate pushdown with column name containing dots in Spark.

I am adding the following code into Spark codebase to support predicate pushdown for columns containing dots in parquet, and the idea is taking the multi-identifiers to avoid using the separators.
https://github.com/apache/spark/pull/27780/files#diff-3e66dccc7ac87df6d2767138dd65c2beR33

Thanks,

Dongjoon Hyun / @dongjoon-hyun:
Hi, All.
According to the discussion history and the long pause (one year), it looks like being rejected due to the potential collision.
Since Apache Parquet 1.12.0 RCs also do not have this, is this a final conclusion?

Ryan Blue:
I think it should be fine to allow this. While there may be other problems when using . in names, the Spark PR that uses this shows that it works just fine to pass a string array instead of parsing a name.


Update inferno-stats plugin

@InfernoStats this ok?

@raiyni This PR is fine 👍

@InfernoStats this ok?

Yes this PR is fine 👍


Roll engine ca31a7c57bad..2e4f0a4a72d1 (15 commits)

https://github.com/flutter/engine/compare/ca31a7c57bad...2e4f0a4a72d1
git log ca31a7c57bada458fa7f5c0d3f36bc1af4ccbc79..2e4f0a4a72d1b051ff0f114289594975beeca6ba --no-merges --oneline
2e4f0a4a7 Put the testing lib in the flutter namespace. (flutter/engine#8661)
1239df96a Allow native bindings in secondary isolates. (flutter/engine#8658)
b0cbce417 Replace ThreadLocal with ThreadLocalUniquePtr<T> (flutter/engine#8659)
bd8c5b135 Only allow mappings for ICU initialization. (flutter/engine#8656)
206cab6e7 Roll src/third_party/skia cc5d3e09e394..1c0b05afdef8 (14 commits) (flutter/engine#8654)
1fe327914 Cleanup references to FLX archives from the engine. (flutter/engine#8653)
6257dfeb5 Add factory methods to FileMapping that make it easy to create common mappings. (flutter/engine#8652)
5fed72520 Roll buildroot to 380d0ed5c3399d5a2aaac4a66d98e3a3fda77c31 (flutter/engine#8649)
eaa0e9c70 Roll src/third_party/skia e5763787f920..cc5d3e09e394 (3 commits) (flutter/engine#8651)
7e37080ec Allow specifying the Mac SDK path as an environment variable to //flutter/tools/gn (flutter/engine#8643)
30c23e604 Roll src/third_party/skia e8a33ec6d084..e5763787f920 (1 commits) (flutter/engine#8650)
8f0af31ec Roll src/third_party/skia 8cdae55bf1ac..e8a33ec6d084 (3 commits) (flutter/engine#8648)
25c33dc9d Roll src/third_party/skia 9b67802a4cd0..8cdae55bf1ac (1 commits) (flutter/engine#8647)
1e5f59d4f Reland "Remove DartSnapshotBuffer and dry up snapshot resolution logic". (flutter/engine#8645)
4ead9c8f9 Remove unused Settings::ToString. (flutter/engine#8642)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5785772983582720

Commit queue failed; closing this roll.


'tuple' object does not support item assignment error if header contains tuples.

Simple example:
>>> from ambry_sources.intuit import RowIntuiter
>>> RowIntuiter.coalesce_headers([('Header0', ''), ('Header1', ''), ('Header2', 'Header2')])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/nmb10/projects/ambry_sources/ambry_sources/intuit.py", line 743, in coalesce_headers
    hl[i] = last
TypeError: 'tuple' object does not support item assignment

Done.


A0-3340: Remove committee change digest (main)

Description
Removal of the committee change digest.

Hi @krzysztofziobro  please update branch with main as there were CI breaking changes done on main (Change of required checks)


OSX: make 'library not found for -lusb-1.0'

While trying to make on OSX I received library not found for -lusb-1.0.
$ make
[  4%] Building CXX object src/CMakeFiles/gchd.dir/disk.cpp.o
[  9%] Building CXX object src/CMakeFiles/gchd.dir/fifo.cpp.o
[ 13%] Building CXX object src/CMakeFiles/gchd.dir/gchd.cpp.o
[ 18%] Building CXX object src/CMakeFiles/gchd.dir/main.cpp.o
[ 22%] Building CXX object src/CMakeFiles/gchd.dir/process.cpp.o
[ 27%] Building CXX object src/CMakeFiles/gchd.dir/socket.cpp.o
[ 31%] Building CXX object src/CMakeFiles/gchd.dir/streamer.cpp.o
[ 36%] Building CXX object src/CMakeFiles/gchd.dir/gchd/commands.cpp.o
[ 40%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure.cpp.o
[ 45%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_component_1080i.cpp.o
[ 50%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_component_1080p.cpp.o
[ 54%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_component_480p.cpp.o
[ 59%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_component_576p.cpp.o
[ 63%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_component_720p.cpp.o
[ 68%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_composite_480i.cpp.o
[ 72%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_composite_576i.cpp.o
[ 77%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_hdmi_1080p.cpp.o
[ 81%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_hdmi_1080p_rgb.cpp.o
[ 86%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_hdmi_720p.cpp.o
[ 90%] Building CXX object src/CMakeFiles/gchd.dir/gchd/configure_hdmi_720p_rgb.cpp.o
[ 95%] Building CXX object src/CMakeFiles/gchd.dir/gchd/settings.cpp.o
[100%] Linking CXX executable gchd
ld: library not found for -lusb-1.0
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/gchd] Error 1
make[1]: *** [src/CMakeFiles/gchd.dir/all] Error 2
make: *** [all] Error 2

This is because make didn't know where to find the library. You can specify it specifically by instead executing:
make LIBRARY_PATH=/usr/local/lib
I'll leave this open for the project owner to decide how to incorporate this.

Thanks for reporting! Issue #22 is related, so I will close this one.


google-app-engine-go-sdk: init at 1.9.53

Motivation for this change
AppEngine SDK for Go is tools for developing, deploying, and managing apps in Google App Engine.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

hmm.. I installed this package on macOS after nix-channel --update.
install is succeed but goapp fails.
/Users/lufia/.nix-profile/bin/goapp: line 7: Convenience wrapper for starting a Go tool in the App Engine SDK.: command not found
ssh: Could not resolve hostname argparse: nodename nor servname provided, or not known
import: EOF
ssh: Could not resolve hostname os: nodename nor servname provided, or not known
import: EOF

goapp's code that raises this errors is:
#!/nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env/bin/python2.7
#
# Copyright 2011 Google Inc. All rights reserved.
# Use of this source code is governed by the Apache 2.0
# license that can be found in the LICENSE file.

"""Convenience wrapper for starting a Go tool in the App Engine SDK."""

import argparse
import os
import sys

and /nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env/bin/python2.7:
#! /nix/store/d0vj5xfr85716dz2k8xb6fhygxgllk3b-bash-4.4-p12/bin/bash -e
export PYTHONHOME="/nix/store/37sk1sjzmky15nkxvyrw97sizx7fhlf2-python-2.7.13-env"
exec "/nix/store/95ssabrarnq5w597y51c66zmvkd44xh0-python-2.7.13/bin/python2.7"  "${extraFlagsArray[@]}" "$@"

Perhaps, macOS's shebang requires to be binary.
$ cat wrap
#!/bin/bash -e

exec /usr/bin/python "$@"
$ cat hello
#!./wrap

if __name__ == '__main__':
	print "hello"
$ ./wrap hello
hello
$ ./hello
./hello: line 5: syntax error: unexpected end of file

I think this error is issue of python27.withPackages on macOS.
What do you think?

@FRidh have you have heard of that issue before?

@lufia could very well be that we cannot use python.withPackages because of https://github.com/NixOS/nixpkgs/issues/11133.


Only works for first line with [ ]

Tags and dates also work but no other features work unless for the first checkbox in a .xit file
See demo:

Oh, that doesn’t look right. Could you share more details about your setup? For example, which Sublime text version (build number) you are using, or which platform (Linux/Windows/MacOS)?
I’m wondering whether this might be a platform-specific issue, as I’m not currently experiencing this on my end.

Ok cool, thanks for confirming this @StartingZone. I think it’s fair to close this ticket then.


Suggestion

It would be cool to have an option to blur the thumbnails and show the picture when mouseover.

Wow that's a great idea. And sounds totally doable to implement without asking for additional permission. I'm really busy the next few weeks but that's definitely something I'll put on my todo list.

2c19d6f addresses this. Showing the image on mouseover would require a content script and thus additional permissions, which I didn't want to do. So I split the difference and just added an option to block all thumbnail images, without the ability to display them on mouseover.


Update OpenBLAS library

The bundled version is 0.2.19 (Sep 2016)
https://github.com/commaai/openpilot/tree/devel/phonelibs/openblas
And the latest version is 0.3.6 (Apr 2019)
https://www.openblas.net/Changelog.txt

openblas is no longer used and will be removed in the upcoming release.

Would be good if you guys kept it for mapd in the future.


Styled components integration

Hey guys
First i want to say thank you for this polyfill, finally cqfill that really is maintained.
Just a quick question, do you know if there is a way to combine it in styled-components?
Thanks!

Styled-components won't generate styles with @container properly. This appears to be caused by the CSS processor they use, which doesn't recognize it yet.
I've also tried @emotion/styled, without success.

Eventually i did find some workaround
I inserted "@media @container" inside the styled components string and replaced the generated style tags from the html with @container
const styleElement = document.querySelector("yourStyleTag");
styleElement.innerHTML = styleElement.innerHTML.replace(/\@media \@container/g, "@container")

@Blazsoul how and when do you get the style tag reference?

Whenever they mounted, Personally in my project i inject the styles with StyleSheetManager
So its pretty easy catching the style elements this way, Try to find an easy way to target your styled components style tags

The polyfill should work with any library that generates <style> elements. Since this seems like an issue with styled-components not supporting the @container syntax, I would recommend filing an issue there if this is still a problem. Please feel free to open a new issue here if you run into a problem specific to the polyfill.
Thank you!


Move install template to its own file

The template used by conduit install was hard-coded in install.go.
This change moves the template into its own file, in anticipation of
increasing the template's size and complexity.
There were no changes to the template itself, just a move.
Part of #420
Signed-off-by: Andrew Seigner<EMAIL_ADDRESS>

@adleong

It's a straight copy-paste.
I would love to store this as a more readable/parseable install.yaml.tmpl, but I can't see a straightforward way to compile it into the cli binary. Open to suggestions.

For reference, one way to solve this: https://github.com/gobuffalo/packr

I think that might be something where the aesthetics are great but the practical considerations aren't so great. What we're doing now is dead simple and works. That thing looks like a lot of added complexity and doesn't seem to pay for itself.


README.md:  Tweak Wording Slightly

     Follows up on #6.

     Thanks for getting around to merging this now, @ashifolfi.


Any way to add eyes of ender?

Strangely my game seems glitched.
I've finished the Citadel normally and mow my eyes of ender is reset to 0.
No problem or so I thought - worse case I have to play 6 more missions.
The Endersent doesn't drop them this time round so I'm kinda screwed. Any way I can add that via the editor?

There seems to be bugs reported on this issue also:
https://bugs.mojang.com/projects/MCD/issues/MCD-6409


Warning: a promise was rejected with a non-error

First off thanks for the opportunity to cancel requests.
Now there is the "problem" if I use Axios with Bluebird the console is getting spammed with Warning: a promise was rejected with a non-error on cancelled requests.
Why is this not implemented with a custom Error class? If you're fine with changing this I would submit a PR.

Cancel must not derive from Error according the cancelable promises spec. Please see this for details.


The data and trained results will be cleared if reopen model builder and click the same scenario.

System Information (please complete the following information):

Windows 10 Enterprise, Version 20H2
ML.Net Model Builder (Preview): <IP_ADDRESS>5505
Microsoft Visual Studio Enterprise 2019: 16.9.3
.Net: 5.0.201

To Reproduce
Steps to reproduce the behavior:

Create new console app with .Net 5.0;
Add Model builder by right click on the project;
Go through "Re-Entrancy Test Pass";
After trained the model, closed and reopened the model builder;
Want to click the same scenario to go to next step, the data and trained results are cleared

Expected behavior
Reopen model builder, want to click the same scenario to see next step, but the data and trained results are cleared, this is not the expected, I do not want to train new model. Hope adding one prompt message to reminder user.
Screenshots

Additional context
Add any other context about the problem here.

I believe the issue here is clicking on the Scenario card registers as starting a "new" scenario. All data is reset. Clicking on the same scenario card should be the same as using the left hand for navigation.

Not repro this issue on latest main build: <IP_ADDRESS>0901


Warn if built-in subcommand aliases shadow user-defined aliases

This PR makes Cargo emit a warning if built-in subcommand aliases (b, r, and t) shadow user-defined aliases.
$ cat .cargo/config
[alias]
b = "foo"

$ ./target/debug/cargo b
warning: alias `b` is ignored, because it is shadowed by a built-in alias for `build`

In order to handle subcommand aliases after clap parses the command line options, it seems to be necessary to stop using clap for subcommand aliases.
So now help command does not work with subcommand aliases, but I think it is not a big problem.
Fixes #6221

r? @matklad
(rust_highfive has picked a reviewer for you, use r? to override)

Umm..., sorry for confusing.
My goal is to add a new built-in alias (#6218), as you know, but I think it is not absolutely necessary to maintain the perfect compatibility.
In the current version of Cargo, user-defined aliases cannot override built-in ones, right?
I do not think it is good to change this behavior, or to introduce inconsistency.
BTW, the AppVoyer failure seems to be spurious (timed out).

r? @ehuss

@ordovicia sorry for the delay. I think it would be best if user aliases took precedence over built-in ones. That would allow us to safely add aliases without disrupting existing user configurations. I think this would require not using clap aliases and instead checking them manually near where user aliases are checked.

Thank you all. I am convinced.
I will make a new PR that allows user aliases take precedence over built-in ones.


fix community team email

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)


iframe 'X-Frame-Options' to 'SAMEORIGIN' issue

Yesterday and today I was not able to run code because of next issue:Refused to display 'https://run.plnkr.co/xxxxxxx/' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.

Hi @laura-rodriguez can you give me some context on which browser you are using and whether you are using the main plunker editor, the embed, or the preview? Also, what browser are you using?
If you have a Plunk you can share to demonstrate the issue, please let me know.

Hi @ggoodman, I am using chrome (Version 51.0.2704.103 m) but it also happens to me with FF.
This is the url I am using: https://plnkr.co/edit/UyInn4YpQlc5SeVUXuh6?p=preview
but it also happens with a new simple project: https://plnkr.co/edit/?p=preview

Hello @laura-rodriguez, other users have reported similar issues in the past and this has been due to corporate networks injecting that header. Neither the editor, nor the run server are issuing that header:
Editor

Run server

Please consult whoever is responsible for the network environment that you run in to see if this change was recently introduced.

@ggoodman  I have tried again, and it is working now. This issue not only happened to me, at my home, but also to my co-workers at the office and other friends at their home.

Hi @laura-rodriguez. I'm going to close the issue for now. If it re-appears, please open your developer console and show me exact what headers are being served both for the editor (https://plnkr.co/edit/) and for the preview (https://run.plnkr.co/<random_string>/).

I am facing a similar issue..


#4969 : Fix gutter click behaviour on touch devices

Fix Bug #4969
Fix wrong behaviour on touch devices when using fold/unfold code.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

src/edit/mouse_events.js, line 329 at r2 (raw file):

function gutterEvent(cm, e, type, prevent) {
  let mX, mY
  if (e.type == "touchstart"){

Shouldn't there be a space between the bracket and curly brace? This makes it follow the coding style in other CodeMirror scripts.
if (e.type == "touchstart") {

Comments from Reviewable

The touch-related part of this has been merged as  eb18ac4e7ca0153, and cleaned up in dcbfd6e7053d1ef


Cannot Login, asking me for a passphrase that I dont have.

Expected Behavior
Been using insomnia since version 2 what loved most of you is the lack of login and account creation, so i've been using insomnia without account.
Currently acepted to create an account with my github but is not working at all.
Actual Behavior
Ask me for a passphrase that I dont have since i've created my account with github.
Reproduction Steps
Create a new account with github
Enter insomnia
Press login
Login with github
Redirect to a page with "enter passphrase"
I dont have that...
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
8.2.0
What operating system are you using?
Windows
Operating System Version
Windows 10 Pro
Installation method
Downloaded from  insomnia
Last Known Working Insomnia version
No response

I have the same problem but on a Mac.  Insomnia updated itself just as I was about to give a live demo (not goodness) and once updated all my projects had disappeared.  Like the OP I tried to log in via GitHub and it just doesn't work. Always cycles round asking for a token.

@tulindor @JonFP sorry for the bad experience. Please see and perhaps try the steps mentioned in another similar issue: https://github.com/Kong/insomnia/issues/6683#issuecomment-1761398540

I faced the similar problem then i reset the passphrase where it that all data will be lost.
But nothing happened I got all my projects without loosing them. just reset the passphrase

is time to change to another rest client, it was pretty good, but when it asked for login and you lost all your endpoints, it was bad,

I faced the similar problem then i reset the passphrase where it that all data will be lost. But nothing happened I got all my projects without loosing them. just reset the passphrase

Do not try this if anyone comes to see this and might be a good idea to try. I did reset the passphrase and everything was gone. Now I have to start from scratch.

What an UX ...

I faced the similar problem then i reset the passphrase where it that all data will be lost. But nothing happened I got all my projects without loosing them. just reset the passphrase

Do not try this if anyone comes to see this and might be a good idea to try. I did reset the passphrase and everything was gone. Now I have to start from scratch.
-- Update
I thought it was gone but it was under Preferences -> Data -> unassigned project. So do reset if you have not set the passphrase it will be there

I've ended up migrating to a similar well known tool by disgrace... but i've loved the old way to work with insomnia, don't know if its back or not, but i had to re do all my api's lost on insomnia by this issue.

IMO it's not back. I just lost all my data. Insomnia was ruined when they started to make all the sync / account features. It's not that the features are bad, it's that the way it's implemented makes it bad.
I'll just move to something else now


Remove deprecated function calls

Removed method calls on deprecated methods.

Set minimum version to 5.2.0
Usage of the new attribute system in Setup.php & Uninstall.php
Removed Shopware()->Bootstrap calls
Removed Enlight() calls with Shopware()

Todo:

engine/Shopware/Plugins/Local/Backend/SwagConnect/Bootstrap/Setup.php:610

@svenfinke The billing and shipping models will be available until Shopware 5.4, so it is not needed to replace the usage of them.
The only  deprecation which must be fixed is the \Shopware\Models\Article\Element

@SimonBaeumer, @sbofirov fixed all tests for php7 so you can see his change over here:
https://github.com/shopware/SwagConnect/pull/191

The changes from this PR are already applied or they will be with following PR https://github.com/shopware/SwagConnect/pull/238


[lab/analyzer] Dual-publish as CommonJS and standard modules

Some contexts where we want to use the analyzer, like tsserver plugins, are Common JS and sync everywhere, making it very difficult to consume standard modules. The easiest solution to dual-publish the analyzer.
require(esm) just landed in Node 23, and will eventually make it's way into Electron and VS Code, but that'll take quite a while.

Sorry, for the changes, but I don't think I need this myself anymore. The tsserver-plugin depends on other standard modules, including lit-html, which I can't convert.
I figured out async loading of code in a plugin, so I worked around this...

I'm going to close this. If someone else needs CJS, we can resurrect it, but hopefully TS plugins get official async-loading support and require(esm) spreads fast enough to make this not necessary.


Add support for quantified comparison predicates (ALL/ANY/SOME)

Allows comparisons against subquery results: https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#_8_9_quantified_comparison_predicate
For example:
SELECT 42 >= SOME (SELECT 41 UNION ALL SELECT 42 UNION ALL SELECT 43); -- true

Pushed doc changes as recommended.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

32 of 38 (84.21%)  changed or added relevant lines in 3 files are covered.
1052 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.008%) to 89.316%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser/mod.rs
21
22
95.45%

tests/sqlparser_common.rs
1
2
50.0%

src/ast/mod.rs
10
14
71.43%

Files with Coverage Reduction
New Missed Lines
%

tests/sqlparser_snowflake.rs
1
98.01%

src/dialect/sqlite.rs
1
80.0%

src/dialect/generic.rs
1
62.22%

tests/sqlparser_sqlite.rs
5
98.23%

src/dialect/mod.rs
12
67.51%

src/ast/ddl.rs
67
86.74%

src/parser/mod.rs
229
93.38%

src/ast/mod.rs
303
82.39%

tests/sqlparser_common.rs
433
89.58%

Totals

Change from base Build<PHONE_NUMBER>5:
0.008%

Covered Lines:
30105

Relevant Lines:
33706

💛  - Coveralls

Thanks again @yoavcloud


wishlist: port spec suite to RSpec3

Hi,
Please port the specs to RSpec v3. The Debian project wrote a patch for basic support. I'll send the link to the patch for reference.
Cheers,
Cédric

Here is the patch: https://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-roxml.git/tree/debian/patches/rspec3.patch?id=9e64a042ee6a7af131f4ee8eeb8741673e055fb4

Fixed, will be releasing today


Use navx for PointToTarget

resolves #70

#73 will conflict. Let's wait to test #73 first to ensure the MedianFilter is an appropriate choice for preprocessing and then merge it in here.

Admittedly this probably removes some need for the median filter, but I'm interested to see how the filter works on the robot first.

Also does this actually not check the limelight until it's done turning? Looks like it just turns based on the navX but is still checking the limelight to see if it's done, which I'm not sure it make sense to do until your navX has turned the original amount you wanted.


Instantiating a GameObject with a MonoBehaviour attached causes exception

Given the existing code to load a MonoBehaviour and attach it to a GameObject
var gameObject = new GameObject("original");
AppDomain domain = new AppDomain();

// Load the module
CLRModule module = domain.LoadModuleStream(new MemoryStream(assemblyModule.bytes), false);

// Find the main type
Type mainType = module.GetTypes()
    .Where(t => t.IsSubclassOf(typeof(MonoBehaviour)))
    .FirstOrDefault();

// Add component - cannot use 'gameObject.AddComponent' because it would crash the engine.
MonoBehaviourProxy.AddComponentOverride(domain, null, gameObject, new object[] { mainType });

The following code, which is the mainType in the code above, does not work
using UnityEngine;

namespace InstantiateMonobehaviourTest
{
    public class TestCase : MonoBehaviour
    {
        public void Start()
        {
            Instantiate(gameObject);
        }
    }
}

One GameObject "original" will be created with the correct MonoBehaviour. Once Start() is called, an exception will occur

8b14420 adds initial support for using instantiate with interpreted scripts. May need revisions in the future and does not support all cases at the moment like instantiating a disabled game object, but the above sample is now working as intended so I will close for now.


skip dea compatibility tests

For cf deployments with no DEA's, this test is not needed and should be skippable.

Thanks, @skibum55. Have you verified that opting into this new property works to skip the tests in https://github.com/cloudfoundry-incubator/diego-acceptance-tests/blob/master/diego/dea_compatibility_test.go? As I mentioned on https://github.com/cloudfoundry-incubator/diego-acceptance-tests/issues/3, since those tests are still in the diego package in the DATs repo, I don't think they'll get skipped by instructing ginkgo to skip a package called dea. You should already be able to skip that particular group of tests via the acceptance_tests.skip_regex BOSH property that the acceptance-tests job consumes.
Thanks,
Eric, CF Runtime Diego PM

Closing due to inactivity.


Enhancement: hold things that reference the owner

I think the functionality of this crate could be extended to hold an owner as well as something that has a lifetime less than or equal to the owner, in a manner similar to the map function. This would help getting rid of lifetime parameters that are carried all the way up through many structures.
For example, say I have an ArcRef<Mutex<T>>. I'd like to store a MutexGuard<'a,T> along-side it. This is safe as long as I know ArcRef<Mutex<T>>: 'a. I currently have an implementation that's not based on OwningRef which I intend to port to OwningRef.

I think I was looking for the same thing. A slimmed-down example of something I might like to have:
extern crate owning_ref;

use std::collections::HashSet;
use owning_ref::OwningRef;

fn main() {
    let or = OwningRef::new(Box::new(42));
    or.map(|answer| {
        let mut set = HashSet::new();
        set.insert(answer);
        set
    });
}

@Kimundi, do you feel like something like this is possible? I'd be happy to contribute some code if you could give some vague hand-wavy direction to start in. :smile_cat:

I don't think its possible due to language reasons right now - if you find a way to actually implement it, then by all means make a PR. :)

The https://github.com/diwic/refstruct-rs crate is some research on how to create something related to this issue. Might be useful?

Uhm, I patched together a possible solution. It should do exactly what OwningRef can, plus should support any struct that generically depends on the owned data (like Box<T>+Option<&T>, Vec+Iter, Box<Mutex>+MutexLock, MutexLock<T>+&mut T) and, as you can see from the example, it's also nestable.
Do you think it makes sense and it is worth developing? Does it look safe or do you spot any danger?
use std::marker::PhantomData;
use std::ops::Deref;
use std::sync::Mutex;

struct OwnedDep<'a, O: 'a, T: 'a> {
    phantom: PhantomData<&'a O>,
    owned: O,
    dep: T,
}

impl<'a, O, T: ?Sized> OwnedDep<'a, O, &'a T>
    where O: Deref<Target = T>
{
    fn new(it: O) -> Self {
        let a = &*it as *const _;
        OwnedDep {
            phantom: Default::default(),
            owned: it,
            dep: unsafe { &*a },
        }
    }
}

impl<'a, O, T> OwnedDep<'a, O, T> {
    fn map<'b, F, U: 'b>(self, f: F) -> OwnedDep<'b, O, U>
        where 'a: 'b,
              F: FnOnce(T) -> U
    {
        OwnedDep {
            phantom: Default::default(),
            owned: self.owned,
            dep: f(self.dep),
        }
    }
}

fn main() {
    let a = OwnedDep::new(Box::new(Mutex::new(1)));
    let a = a.map(|it| it.lock().unwrap());
    let a = a.map(|it| OwnedDep::new(it));
    println!("{:?} {:?}", a.owned, a.dep.dep);
}

Note: at the moment It's just a draft and lacks of the StableAddress safety mesures and all the goodies, but it should be reasonably clear.

If I haven't entirely misunderstood, then OwningHandle fills this need now. Closing.

Neat, thanks!


'make test' fails to run tests

When it is configured with -DSURELOG_BUILD_TESTS=ON make test fails:
[  0% 1/1] cd /usr/ports/cad/surelog/work/.build && /usr/local/bin/ctest --force-new-ctest-process
Test project /usr/ports/cad/surelog/work/.build
      Start  1: PPCache_test_NOT_BUILT
Could not find executable PPCache_test_NOT_BUILT
Looked in the following places:
PPCache_test_NOT_BUILT
PPCache_test_NOT_BUILT
Release/PPCache_test_NOT_BUILT
Release/PPCache_test_NOT_BUILT
Debug/PPCache_test_NOT_BUILT
Debug/PPCache_test_NOT_BUILT
MinSizeRel/PPCache_test_NOT_BUILT
MinSizeRel/PPCache_test_NOT_BUILT
RelWithDebInfo/PPCache_test_NOT_BUILT
RelWithDebInfo/PPCache_test_NOT_BUILT
Deployment/PPCache_test_NOT_BUILT
Deployment/PPCache_test_NOT_BUILT
Development/PPCache_test_NOT_BUILT
Development/PPCache_test_NOT_BUILT
Unable to find executable: PPCache_test_NOT_BUILT
 1/14 Test  #1: PPCache_test_NOT_BUILT ..............***Not Run   0.00 sec
      Start  2: CommandLineParser_test_NOT_BUILT
Could not find executable CommandLineParser_test_NOT_BUILT
Looked in the following places:
CommandLineParser_test_NOT_BUILT
CommandLineParser_test_NOT_BUILT
Release/CommandLineParser_test_NOT_BUILT
Release/CommandLineParser_test_NOT_BUILT
Debug/CommandLineParser_test_NOT_BUILT
Debug/CommandLineParser_test_NOT_BUILT
MinSizeRel/CommandLineParser_test_NOT_BUILT
MinSizeRel/CommandLineParser_test_NOT_BUILT
RelWithDebInfo/CommandLineParser_test_NOT_BUILT
RelWithDebInfo/CommandLineParser_test_NOT_BUILT
Deployment/CommandLineParser_test_NOT_BUILT
Deployment/CommandLineParser_test_NOT_BUILT
Development/CommandLineParser_test_NOT_BUILT
Development/CommandLineParser_test_NOT_BUILT
Unable to find executable: CommandLineParser_test_NOT_BUILT
 2/14 Test  #2: CommandLineParser_test_NOT_BUILT ....***Not Run   0.00 sec
      Start  3: PathId_test_NOT_BUILT
Could not find executable PathId_test_NOT_BUILT
Looked in the following places:
PathId_test_NOT_BUILT
PathId_test_NOT_BUILT
Release/PathId_test_NOT_BUILT
Release/PathId_test_NOT_BUILT
Debug/PathId_test_NOT_BUILT
Debug/PathId_test_NOT_BUILT
MinSizeRel/PathId_test_NOT_BUILT
MinSizeRel/PathId_test_NOT_BUILT
RelWithDebInfo/PathId_test_NOT_BUILT
RelWithDebInfo/PathId_test_NOT_BUILT
Deployment/PathId_test_NOT_BUILT
Deployment/PathId_test_NOT_BUILT
Development/PathId_test_NOT_BUILT
Development/PathId_test_NOT_BUILT
Unable to find executable: PathId_test_NOT_BUILT
 3/14 Test  #3: PathId_test_NOT_BUILT ...............***Not Run   0.00 sec
      Start  4: PlatformFileSystem_test_NOT_BUILT
Could not find executable PlatformFileSystem_test_NOT_BUILT
Looked in the following places:
PlatformFileSystem_test_NOT_BUILT
PlatformFileSystem_test_NOT_BUILT
Release/PlatformFileSystem_test_NOT_BUILT
Release/PlatformFileSystem_test_NOT_BUILT
Debug/PlatformFileSystem_test_NOT_BUILT
Debug/PlatformFileSystem_test_NOT_BUILT
MinSizeRel/PlatformFileSystem_test_NOT_BUILT
MinSizeRel/PlatformFileSystem_test_NOT_BUILT
RelWithDebInfo/PlatformFileSystem_test_NOT_BUILT
RelWithDebInfo/PlatformFileSystem_test_NOT_BUILT
Deployment/PlatformFileSystem_test_NOT_BUILT
Deployment/PlatformFileSystem_test_NOT_BUILT
Development/PlatformFileSystem_test_NOT_BUILT
Development/PlatformFileSystem_test_NOT_BUILT
Unable to find executable: PlatformFileSystem_test_NOT_BUILT
 4/14 Test  #4: PlatformFileSystem_test_NOT_BUILT ...***Not Run   0.00 sec
      Start  5: CompileExpression_test_NOT_BUILT
Could not find executable CompileExpression_test_NOT_BUILT
Looked in the following places:
CompileExpression_test_NOT_BUILT
CompileExpression_test_NOT_BUILT
Release/CompileExpression_test_NOT_BUILT
Release/CompileExpression_test_NOT_BUILT
Debug/CompileExpression_test_NOT_BUILT
Debug/CompileExpression_test_NOT_BUILT
MinSizeRel/CompileExpression_test_NOT_BUILT
MinSizeRel/CompileExpression_test_NOT_BUILT
RelWithDebInfo/CompileExpression_test_NOT_BUILT
RelWithDebInfo/CompileExpression_test_NOT_BUILT
Deployment/CompileExpression_test_NOT_BUILT
Deployment/CompileExpression_test_NOT_BUILT
Development/CompileExpression_test_NOT_BUILT
Development/CompileExpression_test_NOT_BUILT
Unable to find executable: CompileExpression_test_NOT_BUILT
 5/14 Test  #5: CompileExpression_test_NOT_BUILT ....***Not Run   0.00 sec
      Start  6: CompileHelper_test_NOT_BUILT
Could not find executable CompileHelper_test_NOT_BUILT
Looked in the following places:
CompileHelper_test_NOT_BUILT
CompileHelper_test_NOT_BUILT
Release/CompileHelper_test_NOT_BUILT
Release/CompileHelper_test_NOT_BUILT
Debug/CompileHelper_test_NOT_BUILT
Debug/CompileHelper_test_NOT_BUILT
MinSizeRel/CompileHelper_test_NOT_BUILT
MinSizeRel/CompileHelper_test_NOT_BUILT
RelWithDebInfo/CompileHelper_test_NOT_BUILT
RelWithDebInfo/CompileHelper_test_NOT_BUILT
Deployment/CompileHelper_test_NOT_BUILT
Deployment/CompileHelper_test_NOT_BUILT
Development/CompileHelper_test_NOT_BUILT
Development/CompileHelper_test_NOT_BUILT
Unable to find executable: CompileHelper_test_NOT_BUILT
 6/14 Test  #6: CompileHelper_test_NOT_BUILT ........***Not Run   0.00 sec
      Start  7: Elaboration_test_NOT_BUILT
Could not find executable Elaboration_test_NOT_BUILT
Looked in the following places:
Elaboration_test_NOT_BUILT
Elaboration_test_NOT_BUILT
Release/Elaboration_test_NOT_BUILT
Release/Elaboration_test_NOT_BUILT
Debug/Elaboration_test_NOT_BUILT
Debug/Elaboration_test_NOT_BUILT
MinSizeRel/Elaboration_test_NOT_BUILT
MinSizeRel/Elaboration_test_NOT_BUILT
RelWithDebInfo/Elaboration_test_NOT_BUILT
RelWithDebInfo/Elaboration_test_NOT_BUILT
Deployment/Elaboration_test_NOT_BUILT
Deployment/Elaboration_test_NOT_BUILT
Development/Elaboration_test_NOT_BUILT
Development/Elaboration_test_NOT_BUILT
Unable to find executable: Elaboration_test_NOT_BUILT
 7/14 Test  #7: Elaboration_test_NOT_BUILT ..........***Not Run   0.00 sec
      Start  8: Uhdm_test_NOT_BUILT
Could not find executable Uhdm_test_NOT_BUILT
Looked in the following places:
Uhdm_test_NOT_BUILT
Uhdm_test_NOT_BUILT
Release/Uhdm_test_NOT_BUILT
Release/Uhdm_test_NOT_BUILT
Debug/Uhdm_test_NOT_BUILT
Debug/Uhdm_test_NOT_BUILT
MinSizeRel/Uhdm_test_NOT_BUILT
MinSizeRel/Uhdm_test_NOT_BUILT
RelWithDebInfo/Uhdm_test_NOT_BUILT
RelWithDebInfo/Uhdm_test_NOT_BUILT
Deployment/Uhdm_test_NOT_BUILT
Deployment/Uhdm_test_NOT_BUILT
Development/Uhdm_test_NOT_BUILT
Development/Uhdm_test_NOT_BUILT
Unable to find executable: Uhdm_test_NOT_BUILT
 8/14 Test  #8: Uhdm_test_NOT_BUILT .................***Not Run   0.00 sec
      Start  9: ExprBuilder_test_NOT_BUILT
Could not find executable ExprBuilder_test_NOT_BUILT
Looked in the following places:
ExprBuilder_test_NOT_BUILT
ExprBuilder_test_NOT_BUILT
Release/ExprBuilder_test_NOT_BUILT
Release/ExprBuilder_test_NOT_BUILT
Debug/ExprBuilder_test_NOT_BUILT
Debug/ExprBuilder_test_NOT_BUILT
MinSizeRel/ExprBuilder_test_NOT_BUILT
MinSizeRel/ExprBuilder_test_NOT_BUILT
RelWithDebInfo/ExprBuilder_test_NOT_BUILT
RelWithDebInfo/ExprBuilder_test_NOT_BUILT
Deployment/ExprBuilder_test_NOT_BUILT
Deployment/ExprBuilder_test_NOT_BUILT
Development/ExprBuilder_test_NOT_BUILT
Development/ExprBuilder_test_NOT_BUILT
Unable to find executable: ExprBuilder_test_NOT_BUILT
 9/14 Test  #9: ExprBuilder_test_NOT_BUILT ..........***Not Run   0.00 sec
      Start 10: ParseFile_test_NOT_BUILT
Could not find executable ParseFile_test_NOT_BUILT
Looked in the following places:
ParseFile_test_NOT_BUILT
ParseFile_test_NOT_BUILT
Release/ParseFile_test_NOT_BUILT
Release/ParseFile_test_NOT_BUILT
Debug/ParseFile_test_NOT_BUILT
Debug/ParseFile_test_NOT_BUILT
MinSizeRel/ParseFile_test_NOT_BUILT
MinSizeRel/ParseFile_test_NOT_BUILT
RelWithDebInfo/ParseFile_test_NOT_BUILT
RelWithDebInfo/ParseFile_test_NOT_BUILT
Deployment/ParseFile_test_NOT_BUILT
Deployment/ParseFile_test_NOT_BUILT
Development/ParseFile_test_NOT_BUILT
Development/ParseFile_test_NOT_BUILT
Unable to find executable: ParseFile_test_NOT_BUILT
10/14 Test #10: ParseFile_test_NOT_BUILT ............***Not Run   0.00 sec
      Start 11: PreprocessFile_test_NOT_BUILT
Could not find executable PreprocessFile_test_NOT_BUILT
Looked in the following places:
PreprocessFile_test_NOT_BUILT
PreprocessFile_test_NOT_BUILT
Release/PreprocessFile_test_NOT_BUILT
Release/PreprocessFile_test_NOT_BUILT
Debug/PreprocessFile_test_NOT_BUILT
Debug/PreprocessFile_test_NOT_BUILT
MinSizeRel/PreprocessFile_test_NOT_BUILT
MinSizeRel/PreprocessFile_test_NOT_BUILT
RelWithDebInfo/PreprocessFile_test_NOT_BUILT
RelWithDebInfo/PreprocessFile_test_NOT_BUILT
Deployment/PreprocessFile_test_NOT_BUILT
Deployment/PreprocessFile_test_NOT_BUILT
Development/PreprocessFile_test_NOT_BUILT
Development/PreprocessFile_test_NOT_BUILT
Unable to find executable: PreprocessFile_test_NOT_BUILT
11/14 Test #11: PreprocessFile_test_NOT_BUILT .......***Not Run   0.00 sec
      Start 12: SymbolTable_test_NOT_BUILT
Could not find executable SymbolTable_test_NOT_BUILT
Looked in the following places:
SymbolTable_test_NOT_BUILT
SymbolTable_test_NOT_BUILT
Release/SymbolTable_test_NOT_BUILT
Release/SymbolTable_test_NOT_BUILT
Debug/SymbolTable_test_NOT_BUILT
Debug/SymbolTable_test_NOT_BUILT
MinSizeRel/SymbolTable_test_NOT_BUILT
MinSizeRel/SymbolTable_test_NOT_BUILT
RelWithDebInfo/SymbolTable_test_NOT_BUILT
RelWithDebInfo/SymbolTable_test_NOT_BUILT
Deployment/SymbolTable_test_NOT_BUILT
Deployment/SymbolTable_test_NOT_BUILT
Development/SymbolTable_test_NOT_BUILT
Development/SymbolTable_test_NOT_BUILT
Unable to find executable: SymbolTable_test_NOT_BUILT
12/14 Test #12: SymbolTable_test_NOT_BUILT ..........***Not Run   0.00 sec
      Start 13: StringUtils_test_NOT_BUILT
Could not find executable StringUtils_test_NOT_BUILT
Looked in the following places:
StringUtils_test_NOT_BUILT
StringUtils_test_NOT_BUILT
Release/StringUtils_test_NOT_BUILT
Release/StringUtils_test_NOT_BUILT
Debug/StringUtils_test_NOT_BUILT
Debug/StringUtils_test_NOT_BUILT
MinSizeRel/StringUtils_test_NOT_BUILT
MinSizeRel/StringUtils_test_NOT_BUILT
RelWithDebInfo/StringUtils_test_NOT_BUILT
RelWithDebInfo/StringUtils_test_NOT_BUILT
Deployment/StringUtils_test_NOT_BUILT
Deployment/StringUtils_test_NOT_BUILT
Development/StringUtils_test_NOT_BUILT
Development/StringUtils_test_NOT_BUILT
Unable to find executable: StringUtils_test_NOT_BUILT
13/14 Test #13: StringUtils_test_NOT_BUILT ..........***Not Run   0.00 sec
      Start 14: NumUtils_test_NOT_BUILT
Could not find executable NumUtils_test_NOT_BUILT
Looked in the following places:
NumUtils_test_NOT_BUILT
NumUtils_test_NOT_BUILT
Release/NumUtils_test_NOT_BUILT
Release/NumUtils_test_NOT_BUILT
Debug/NumUtils_test_NOT_BUILT
Debug/NumUtils_test_NOT_BUILT
MinSizeRel/NumUtils_test_NOT_BUILT
MinSizeRel/NumUtils_test_NOT_BUILT
RelWithDebInfo/NumUtils_test_NOT_BUILT
RelWithDebInfo/NumUtils_test_NOT_BUILT
Deployment/NumUtils_test_NOT_BUILT
Deployment/NumUtils_test_NOT_BUILT
Development/NumUtils_test_NOT_BUILT
Development/NumUtils_test_NOT_BUILT
Unable to find executable: NumUtils_test_NOT_BUILT
14/14 Test #14: NumUtils_test_NOT_BUILT .............***Not Run   0.00 sec

0% tests passed, 14 tests failed out of 14

Total Test time (real) =   0.01 sec

The following tests FAILED:
	  1 - PPCache_test_NOT_BUILT (Not Run)
	  2 - CommandLineParser_test_NOT_BUILT (Not Run)
	  3 - PathId_test_NOT_BUILT (Not Run)
	  4 - PlatformFileSystem_test_NOT_BUILT (Not Run)
	  5 - CompileExpression_test_NOT_BUILT (Not Run)
	  6 - CompileHelper_test_NOT_BUILT (Not Run)
	  7 - Elaboration_test_NOT_BUILT (Not Run)
	  8 - Uhdm_test_NOT_BUILT (Not Run)
	  9 - ExprBuilder_test_NOT_BUILT (Not Run)
	 10 - ParseFile_test_NOT_BUILT (Not Run)
	 11 - PreprocessFile_test_NOT_BUILT (Not Run)
	 12 - SymbolTable_test_NOT_BUILT (Not Run)
	 13 - StringUtils_test_NOT_BUILT (Not Run)
	 14 - NumUtils_test_NOT_BUILT (Not Run)
Errors while running CTest
Output from these tests are in: /usr/ports/cad/surelog/work/.build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
FAILED: CMakeFiles/test.util
cd /usr/ports/cad/surelog/work/.build && /usr/local/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.

Version: 1.50
FreeBSD 13.1

@timkpaine, @hzeller something to do with the recent packaging work?

I doubt it, but there's a lot of output omitted here so difficult to tell.

it looks like you're building Surelog in a slightly different build environment. It is not quite clear to me if you're using the third_party/ libs in the submodules, or are using the libraries supplied in your build environment.
In that case, make sure to give -DSURELOG_USE_HOST_GTEST=On to the cmake configuration
Then, in order to run the tests, you need to build the target UnitTests, they are not build by default. So t)he following minimal example should get you going (here: using my-build-dir as the build directory
cmake -DSURELOG_USE_HOST_GTEST=On -S . -B my-build-dir
cmake` --build my-build-dir --target UnitTests
cd my-build-dir ; ctest

I use all git submodules.
-DSURELOG_USE_HOST_GTEST=On failed, see a separate bug report about this.

There are 2 failures:
14/99 Test #14: src/Common/PlatformFileSystemTest.WorkingDirs_NonIdeal ..................................***Failed    0.03 sec
Running main() from /usr/ports/cad/surelog/work/Surelog-1.50/third_party/googletest/googletest/src/gtest_main.cc
Note: Google Test filter = PlatformFileSystemTest.WorkingDirs_NonIdeal
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PlatformFileSystemTest
[ RUN      ] PlatformFileSystemTest.WorkingDirs_NonIdeal
/usr/ports/cad/surelog/work/Surelog-1.50/src/Common/PlatformFileSystem_test.cpp:400: Failure
Expected equality of these values:
  expectedFsWorkingDirs
    Which is: { "", "/tmp/ws_nonideal" }
  actualFsWorkingDirs
    Which is: { "/home/yuri/bin", "/tmp/ws_nonideal" }
[  FAILED  ] PlatformFileSystemTest.WorkingDirs_NonIdeal (1 ms)
[----------] 1 test from PlatformFileSystemTest (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PlatformFileSystemTest.WorkingDirs_NonIdeal

 1 FAILED TEST

      Start 15: src/Common/PlatformFileSystemTest.WorkingDirs_Ideal
15/99 Test #15: src/Common/PlatformFileSystemTest.WorkingDirs_Ideal .....................................***Failed    0.03 sec
Running main() from /usr/ports/cad/surelog/work/Surelog-1.50/third_party/googletest/googletest/src/gtest_main.cc
Note: Google Test filter = PlatformFileSystemTest.WorkingDirs_Ideal
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from PlatformFileSystemTest
[ RUN      ] PlatformFileSystemTest.WorkingDirs_Ideal
/usr/ports/cad/surelog/work/Surelog-1.50/src/Common/PlatformFileSystem_test.cpp:515: Failure
Expected equality of these values:
  expectedFsWorkingDirs
    Which is: { "", "/tmp/ws_ideal/tests/testname", "/tmp/ws_ideal/third_party" }
  actualFsWorkingDirs
    Which is: { "/home/yuri/bin", "/tmp/ws_ideal/tests/testname", "/tmp/ws_ideal/third_party" }
[  FAILED  ] PlatformFileSystemTest.WorkingDirs_Ideal (1 ms)
[----------] 1 test from PlatformFileSystemTest (1 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PlatformFileSystemTest.WorkingDirs_Ideal

 1 FAILED TEST

      Start 16: src/Common/PlatformFileSystemTest.InMemoryTest
16/99 Test #16: src/Common/PlatformFileSystemTest.InMemoryTest ..........................................   Passed    0.60 sec

@alaindargelas
These tests still fail in 1.64:
The following tests FAILED:
	 14 - src/Common/PlatformFileSystemTest.WorkingDirs_NonIdeal (Failed)
	 15 - src/Common/PlatformFileSystemTest.WorkingDirs_Ideal (Failed)

flatbuffers, antlr4 and googletest are git submodules, the rest are external dependencies.
What is wrong with these tests?

Those are @hs-apotell  tests

/home/yuri/bin is picked from the PATH variable. Why does it do this?
And why is the other value an empty string?

Why do we need the program path in the first place ? Is it because all configuration is relative to it ? e.g. /foo/bin/surelog looks at /foo/bin/surelog/../share/something ?
Maybe the thing that is different is that @yurivict is working on BSD, while all our assumptions are fairly Linux-centric.

Is it looking for the program path? It can be resolved through the PATH variable. Other tests find it fine, I guess.


Type inference in linear solve

At the moment, since IterativeSolvers can return a convergence history depending on a keyword argument, our pushforward and pullback are type-unstable.
If this isn't fixed by #5, we can consider annotations like
linear_solver(A, b)::AbstractVector = gmres(A, b)

or
u::AbstractVector = linear_solver(A, b)

Wasn't this fixed by<PHONE_NUMBER>eb4a1e5bcb257c50f3239fcc8e5d7b?

Correct, thanks!


Upgrade MRTCore sample apps to use the Project Reunion NuGet.

How verified:

Built the class library.
Built and ran the C# app.
Built and ran the C++ app.

Do the samples links in our docs need to be updated or is the same URL?

Do the samples links in our docs need to be updated or is the same URL?
The link under Samples here
https://docs.microsoft.com/en-us/windows/apps/project-reunion/mrtcore/mrtcore-overview
took me here
https://github.com/microsoft/Project-Reunion-Samples/tree/main/MrtCore

So I think we're OK for the URL.

@mcleanbyron Just noting that we do not need to change any of the samples URL's based on Rohan. Thanks.


on authentication success, how to avoid re-direction to browser?

credentials = get_credentials()
http = credentials.authorize(httplib2.Http())
service = discovery.build('drive', 'v3', http=http)
gauth = GoogleAuth()
drive = GoogleDrive(gauth)
f = drive.CreateFile()
f.SetContentFile('document.txt')
f.Upload()

After uploading, I just want its webViewLink and avoid the redirection which is happening.
Also is there any way to know the file's webViewLink without searching whole of drive as follows?
results = service.files().list(
pageSize=10,fields="nextPageToken, files(id, name, webViewLink)").execute()

First a couple of clarifying questions:

What exactly do you mean by re-direction to the browser?
What is the purpose of the first 3 lines? I notice that you are building a service object with v3, note that PyDrive is currently using v2, which has differently named fields. As long as you are doing fairly standard operations on your files, you will not need to build your own service object as PyDrive takes care of this under the hood.
Are you calling this code in some sort of loop? In that case I would recommend creating gauth and drive only once and to refer to these object rather than rebuilding them.

For silent authentication flows, have a look in the docs for authentication flows if you haven't already. In the example in the docs, you can see the line save_credentials: True which ensures that you will only have to go through the authentication process once.

Also is there any way to know the file's webViewLink [...]?

If you know the ID, you can do it as follows:
file_id = '<your ID>'
file_obj = drive.CreateFile({'id': file_id})
file_obj.FetchMetadata(fields='webViewLink')
view_link = file_object.metadata.get('webViewLink')

You can find the docs on FetchMetadata() here.
Note: you will need the GitHub version of the library for FetchMetadata() to accept the fields parameter. Installation with pip is trivial and is described here.

Closing due to inactivity.


Improve convex meet algorithm performance

Implement a new convex_bound method
Improve convex_meet method
Add additional edge case test

Codecov Report
Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.00%. Comparing base (72ca697) to head (97d833d).

Files with missing lines
Patch %
Lines

src/PiecewiseLinearFunctions.jl
87.09%
4 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   94.30%   92.00%   -2.31%
==========================================
  Files           2        2
  Lines         246      250       +4
==========================================
- Hits          232      230       -2
- Misses         14       20       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs(htlc-coordinator): added the flow diagram

Resolve #603

Thanks for your proposal.
As I commented on PR587, I reviewed it again including the latest HTLC PR (PR 873), but it seems like I am just throwing away the HTLC smart contract as I deploy it, and it is hard to understand the positioning of your HTLC, which is frankly what I am talking about.
I am sorry but I will have a vacation until next week, but I want to prepare the alternative plan as soon as possible. I am sorry to have kept you waiting so long.

Thanks for your proposal.
As I commented on PR587, I reviewed it again including the latest HTLC PR (PR 873), but it seems like I am just throwing away the HTLC smart contract as I deploy it, and it is hard to understand the positioning of your HTLC, which is frankly what I am talking about.
I am sorry but I will have a vacation until next week, but I want to prepare the alternative plan as soon as possible. I am sorry to have kept you waiting so long.

@takeutak Thank you too! Hope you'll have a great holiday!

but it seems like I am just throwing away the HTLC smart contract as I deploy it

Throwing it away as in deleting it? From the ledger?

I put my detailed comments at Issue #603 with a suggested solution.
Can you give me your opinion for my observation first?
When we could clarify what to do, I will issue a Change Request to implement.
@kikoncuo @petermetz @jordigiam
Cc: @takeutak

I put my detailed comments at Issue #603 with a suggested solution.
Can you give me your opinion for my observation first?
When we could clarify what to do, I will issue a Change Request to implement.
@kikoncuo @petermetz @jordigiam
Cc: @takeutak

@sfuji822 Thank you for the response. CC-ing @jagpreetsinghsasan (did the same on the other thread)

@jagpreetsinghsasan Is this being worked on by you or did it get resolved in some other PR concurrently?

@petermetz as per the discussion in #603, I have created a new issue #1180 to implement the HTLC coordinator as explained by @sfuji822 as a new example/implementation of HTLC.
This flow diagram refers to the flow diagram of the HTLC plugin, we have here

@sfuji822 Is that all satisfactory in the context of this pull request?


Add packaging instructions into readme

Hey Oakes,
I am looking to write a game in clojure, and really enjoy your game engine.
However, I'm not sure where to begin to actually package and run a finished product for any project I have.
I'm sure I could figure out how to compile to javascript then integrate inside of electron somehow, but it seems that it would be helpful to include a section in the readme which discusses suggested deployment / packaging options.

If you are distributing on the desktop you should build a native version (as an uberjar), using the command in the readme, rather than a web version. You can then create native installers like .exe from your uberjar with jpackage.

Awesome.  Thank you.


Time series smoothing for passenger census

There are some notebooks related to this in the notebooks/trimet_seasonality folder but nothing ready for publication yet.


Update example for static files

fix #796
Type of Issue

[ ] :bug: (bug)
[x] :book: (Documentation)
[ ] :arrow_up: (Update)
[ ] :dizzy: (New Feature)
[ ] :radioactive: (Deprecation)
[ ] :no_entry_sign: (Removal)
[ ] :hammer_and_wrench: (Refactor)

Changes have been Documented (If Applicable)

[x] YES - Changes have been documented

Changes have been Tested

[x] YES - Changes have been tested

Next Steps

Is the following code snippet what you're expecting?
from render_engine import Site

class MySite(Site):
    static_path = "my_static"

Another option is to apply the static path after initialization as the paths are not merged until Site.render() is called.

app = MySite()
app.static_paths.add = "my_static"

The failing action is related to another issue and this change does not introduce a new problem.

The failing action is related to another issue and this change does not introduce a new problem.

I tried running ruff check . locally, and it's working fine on my local machine

it's not ruff it's markdownlint and it's based on the all contributors tag.


Respect optional param for ConfigMaps and Secrets

I am working on tests, but it might take some time :) I am new here.
#555

Hi, Keda is still throwing an error when we use the secretkeyref in the deployment with the latest version too, for example
      - name: SECRET_USERNAME
        valueFrom:
          secretKeyRef:
            name: mysecret
            key: username
            optional: true

Please let me know if need any other info.


Clicking on a face, make it´s texture distorted and shows the error

Clicking on a face, make it´s texture distorted and shows the error:
IndexOutOfRangeException: Array index is out of range.
Sabresaurus.SabreCSG.SurfaceEditor.TransformUVs (Sabresaurus.SabreCSG.Polygon polygon, Sabresaurus.SabreCSG.UVTransformation transformationMethod, Sabresaurus.SabreCSG.TransformData transformData, Boolean recordUndo) (at Assets/SabreCSG-master/Scripts/Tools/SurfaceEditor.cs:1037)
Sabresaurus.SabreCSG.SurfaceEditor.TransformUVs (Sabresaurus.SabreCSG.UVTransformation transformationMethod, Sabresaurus.SabreCSG.TransformData transformData, Boolean recordUndo) (at Assets/SabreCSG-master/Scripts/Tools/SurfaceEditor.cs:985)
Sabresaurus.SabreCSG.SurfaceEditor.OnMouseDragTranslate (UnityEditor.SceneView sceneView, UnityEngine.Event e) (at Assets/SabreCSG-master/Scripts/Tools/SurfaceEditor.cs:391)
Sabresaurus.SabreCSG.SurfaceEditor.OnMouseDrag (UnityEditor.SceneView sceneView, UnityEngine.Event e) (at Assets/SabreCSG-master/Scripts/Tools/SurfaceEditor.cs:280)
Sabresaurus.SabreCSG.SurfaceEditor.OnSceneGUI (UnityEditor.SceneView sceneView, UnityEngine.Event e) (at Assets/SabreCSG-master/Scripts/Tools/SurfaceEditor.cs:108)
Sabresaurus.SabreCSG.CSGModel.OnSceneGUI (UnityEditor.SceneView sceneView) (at Assets/SabreCSG-master/Scripts/CSGModel.cs:506)
UnityEditor.SceneView.CallOnSceneGUI () (at C:/buildslave/unity/build/Editor/Mono/SceneView/SceneView.cs:2075)
UnityEditor.SceneView.HandleSelectionAndOnSceneGUI () (at C:/buildslave/unity/build/Editor/Mono/SceneView/SceneView.cs:1405)
UnityEditor.SceneView.OnGUI () (at C:/buildslave/unity/build/Editor/Mono/SceneView/SceneView.cs:1242)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)

Rickomax, if you are still here, did you ever find the reason why it happened and how to fix this?
This issue is nearly a year old and I have never encountered this error before. If anyone is able to reproduce it and detail the steps or provide a link to a scene with this problem it's very much appreciated.
Worst case we will have to close this issue and hope that one day someone encounters it again (or not, as that would be a bad thing).

Hi @Henry00IS . I haven't used SabreCSG anymore...

Thanks @rickomax for taking the time to write a reply. That's too bad, I hope you will check it out again sometime, there are many new features and improvements.
I will close this issue until anyone ever encounters it again and finds a way to reproduce the error. For all I know the underlying cause may have already been fixed over time.


[WIP] Alternative fix for stdout/stderr redirects

An alternative to #25.
Benefits (?) of this implementation:

for tests marked as benchmarks (no fixture), the cache priming doesn't result in the same scope being run twice, e.g. the following works<EMAIL_ADDRESS>def test_tmp_path(tmp_path):
    (tmp_path / "random").mkdir()

this is accomplished via code borrowed from pytest-rerunfailures, see pytest_codspeed.plugin.prime_cache

Submitting to see benchmark results.

Closing in favor of #32


Update submodules, update to Zig 0.10.0

Excluding scripts/generate_blocks.zig, confirmed to work with stage2 and stage1
Errors in scripts/generate_blocks.zig with stage2 looks like compiler bugs, needs more investigation.

upd: some tests don't work, but I thinks it's normal behaviour?

I guess that's it 💯