Theme upload via custom storage adapter

With #7209 we made it possible uploading, downloading and deleting themes via Ghost.
This implementation has the restriction that theme uploads will use our default local-file-store for storing the themes on disk.
Uploading and downloading files in general is implemented by using a storage adapter (see https://github.com/TryGhost/Ghost/blob/master/core/server/middleware/index.js#L126) - in this case we are using the/your configured storage adapter to serve images.
To make it possible using a custom storage adapter for themes, we need to change how we browse available themes. Right now we read all available themes hardcoded from disk on bootstrap (see https://github.com/TryGhost/Ghost/blob/master/core/server/config/index.js#L81). With this hardcoded piece of code, configuring custom storage adapters for theme uploads is impossible. That's why it is restricted in #7209 (see https://github.com/TryGhost/Ghost/pull/7209/files#diff-198522c016d444fe14bb9882f7614d2dR201)
In https://github.com/TryGhost/Ghost/pull/7241 we already made the improvement choosing a specific storage adapter - getStorage('themes'). So each type (images, themes, apps) can have its own adapter.
If we would add a required storage function like browse, we could use that function to get all available themes. (storage.getStorage('themes').browse(..)).
The challenge is to define how a storage adapter should browse and what it should return.
Imagine you could plugin any  valid storage adapter and the behaviour must be always the same.
We are happy if somebody could pick that issue up 🎉

Helpful documentation to read: https://github.com/TryGhost/Ghost/wiki/Using-a-custom-storage-module

Similarly to https://github.com/TryGhost/Ghost/issues/5926#issuecomment-247947321, I'm going to close this issue for now.
Not that we don't need to implement something like this, rather that we need to review this change in the context of other changes that we intend to make and ensure we have a clear plan for how adapters and in particular storage adapters will work in future.


Mention and highlight the automated nature of the CODEOWNERS sync PR

Description
This PR updates the body of the CODEOWNERS PR to mention that the PR is automated. This is important because it otherwise appears to be from @kgodey's account.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I would also suggest adding a comment in the generated code owners file which says it a automatically generated and maybe links to this script.

@zackkrida in most cases the CODEOWNERS file is not generated by this script. It just makes additive PRs if it notices any missing entries. Saying that the file is autogenerated might be misleading.

Oh I didn't know that, I agree then. Thanks for clarifying!


WIP report invalid javac options without a stack trace

TODO:
[ ] - Update the unit test to check that the error log is printed (how?)

To validate this pull request against other sbt modules, please visit this link.

This doesn't log the error yet, closing until I figure that out.


[BUG] Template scripts return 404 when hosted on corp GitHub pages

On a corporate GitHub account and inside a project, react-static behaves differently while fetching route data.
This setup has following URL:
https://pages.github.corp.company.com
basePath = organization/repo-name
Reporting a bug?
Yes. Basic react-static template.
yarn global add react-static
react-static create
# repo-name
# basic template

static.config.js
basePath: "organization/repo-name",
package.json
"homepage": "https://pages.github.corp.company.com/organization/repo-name"
Actual Behavior
Navigating to blogs URL:
https://pages.github.corp.company.com/organization/repo-name/blog
In the network tab it threw 404 for
https://pages.github.corp.company.com/organization/repo-name/templates/__react_static_root__/src/pages/blog.12xxx.js
Expected Behavior
In a non corp and individual account without any organization the basePath is usually 1 folder which is the repo name and I think this is making it work for individual account without organization. I don't see any calls to templates/__react_static_root__/* path for individual account. This only happens with corp account and organization in the base paths.
Reproducible Demo
N/A as we need corp account with organization

So the issue is basically that basepaths can't be more than 1 deep?

it works with me when .nojekyll file is in the root directory
https://github.com/mpetrovich/stylemark/issues/65

It would be great if we could customize the name of the __react_static_folder__ so the .nojekyll hack wouldn't be needed.

I'll take a PR that makes that change, but be aware that there is quite some code relying on that exact value to be that exact value.
In my opinion, it's not React Static that is the cause of this issue but rather Jekyll, which shouldn't require the .nojekyll file or treat folders that start with _ like it does, nor should GitHub assume it's Jekyll to begin with.


Revert "[gpgmm] Add gpgmm. Highly experimental."

Reverts microsoft/vcpkg#25650
Reverted until we de-vendor vulkan dependencies on this port (@JackBoosY @BillyONeal)

@vicroms Could we instead just specify -DGPGMM_ENABLE_VK=NO? This backend (and it's dependencies) is not required.


Added documentation references for guide documentation snippets.

@doneill - I'd like to make a minor change to 'Display-scene' sample, to add some documentation snippet references. (Minor change to one variable name to make it fit with other snippets). Could you review?

@shellygill Thanks, looks good, I will merge to expedite.


Authorize improvements

Note:  Please ignore the "Better usage of Payment#number" commit.  It has its own PR (#22).
It's probably easiest to understand this going through commit by commit.
Main items:

Better error handling for authorizations
Starting switching over to use Amazon's Ruby gem for performing authorize calls.

Secondary item:

Allow using Sandbox Simulations for simulating errors while in Sandbox mode.  See code comments.

Also:

Remove some duplicated specs
Refactor amazon_spec.rb a bit

@jordan-brough can we rebase this please?

@manmartinez just FYI I've got some more stuff in the pipeline building on this that I haven't PR'd yet. When you have a minute to take a look that would be great. Thanks!

@jordan-brough I'll try to review this ASAP sorry for the delay but I've been caught up in another project

@manmartinez thanks for the feedback! I've responded to all the comments. Lmk what you think.
It'll be great to get this merged in so we can start swapping out AmazonMws for Amazon's gem!

Looks good! :+1: Sorry for the delay, it's been a bit hard finding time to work on this


Trivy scan update

Currently the trivy scan is pointed at the current directory. Once the large AWS PR is merged, it needs to be modified to point at the terraform directory

This ticket is obsolete the changes have been made and merged


Improve workflow for generating QC of manual corrections

In this example: https://github.com/spine-generic/data-multi-subject/pull/16, there were several back-and-forth between the contributor and the user, so at the end there is no single QC report that matches all the committed files on the branch, making it difficult to do a full review at once, and make sure there was no manual error between the back-and-forth.
One possibility would be to have the option to generate a "final" QC report, within the sg_manual_correction function, by looking at the files that are different between the master branch and the working branch. @valosekj @PaulBautin @kousu do you have comments/ideas?

Actually, a simple solution would be to have a function that just generate a QC, based on the yml config file.

Maybe we can add a flag sg_manual_correction -only-qc to only output the QC report. Any thoughts @valosekj @PaulBautin ?

Unless it is not the only function with this complication (in which case function should have a broader scope), seems great! Would the only needed input be the derivative files?

Would the only needed input be the derivative files?

not sure i understand this comment.
the input would be the same as what you typed-- the only difference is that the flag -qc-only would skip the copy and manual correction (ie only does the qc report, based on the derivatives that are already corrected)

ok i'll work on a fix-- shouldn't be long

Maybe we can add a flag sg_manual_correction -only-qc to only output the QC report.

Sounds as the good solution 👍

In this example: spine-generic/data-multi-subject#16, there were several back-and-forth between the contributor and the user

you mean that user did manual correction but admin requested some extra edit/improving only for some subjects? Something like I did here? I achieved manual correction only for one subject by creating new yml file only with one filename of certain subject. I think if I run sg_manual_correction script with original yml file (containing all filenames) and would like to skip some subjects by simply closing FSLeyes, sg_manual_correction would despite it replace previous manually corrected segmentation by new copies by shutil.copy command.
So I had to pay attention about not overwriting previously created manual corrections.

So I had to pay attention about not overwriting previously created manual corrections.
(I realized it fully when trying #160)

indeed, that's a major flaw in the current implementation-- we should probably add a warning, that let the user know that the file "-manual" already exists, and if he is sure he wants to continue.


[Partner] Update the 'partners#create' expect the organization's email and use it to set the reply-to and from on the invitation email

Summary
Once the Partner application starts to receive the organization's email via API call. We'll need to modify the partners#create API endpoint to start utilizing it to change the email from and reply-to.
Note - You might need to make modifications on mailers or make a custom mailer to accomplish this
Blockers
#1597
Criteria For Completion

[ ] Invitations emails have the from and reply-to set to the organization's email.

Closing this one for - https://github.com/rubyforgood/partner/issues/290


build: Delete .husky/_ files, add gitignore

By default, husky adds a .gitignore file in .husky/_ to ignore all files in there, as they may differ from one dev to another (OS, configs, etc). To see this in action, just run bunx husky init / npx husky init. Lefthook, when initialized with lefthook install, only adds the two files we stored previously without the gitignore.
Assuming everyone is able to install lefthook successfully, which shouldn't be a problem because we have a prepare command, we should not be committing these files to the repo.

maybe add .husky/ to the mayn gitignore or will that be wrong?

Sounds like a good idea, moved it now


Contradicting information about port mappings in service containers

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?

About service containers
Workflow syntax for GitHub Actions

What part(s) of the article would you like to see updated?
In both pages linked about, it says that if you don't specify the port, it maps the host port to a randomly chosen port on the container:
About service containers / Mapping Docker host and service container ports

❌ 8080/udp Map a randomly chosen UDP port in the container to UDP port 8080 on the Docker host.

I think, it's the other way around: "Map a randomly chosen port on the Docker host to UDP port 8080 in the container"
Workflow syntax for GitHub Actions / jobs.<job_id>.services / Example: Using localhost

❌ When you specify the Docker host port but not the container port, the container port is randomly assigned to a free port.

I think, it should be: "When you specify the container port but not the Docker host port, the container port is randomly assigned to a free port."
Additional information
In the following page, I think the correct statement is used:
Accessing contextual information about workflow runs / job context / Example usage of the job context

✅ This example workflow configures a PostgreSQL service container, and automatically maps port 5432 in the service container to a randomly chosen available port on the host.

content/account-and-profile/setting-up-and-managing-your-github-profile/index.md

Ok

@hsnabszhdn Thank you for raising this issue! I'll get this triaged for review ✨  Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

@hsnabszhdn Thank you so much for your patience while our SME team reviewed!

I think, it's the other way around: "Map a randomly chosen port on the Docker host to UDP port 8080 in the container"

I think, it should be: "When you specify the container port but not the Docker host port, the container port is randomly assigned to a free port."

Our SME team confirms you are correct 💛 I've added the help wanted label so that you, or anyone else, can open a PR to make these updates!


repeat.spec.js tests repeat object from jspm package instead of one from the project source

I'm submitting a bug report

Library Version:
1.4.0

Please tell us about your environment:

Operating System:
Windows 8

Node Version:
6.9.2

NPM Version:
4.3.0

JSPM OR Webpack AND Version
Aurelia CLI 0.30.1

Browser:
Chrome 60

Language:
TypeScript 2.4.2

Current behavior:
repeat.spec.js tests file
<EMAIL_ADDRESS>instead of file
src/repeat.js
STR:

Setup as described in Readme.md
Add "debugger;" line in one of the tests like so:

it('should do nothing if no items provided', () => {
      let didThrow = false;
      repeat.items = undefined;

      try {
        debugger;
        repeat.bind();
      } catch (e) {
        didThrow = true;
      }

      expect(didThrow).toBe(false);
    });

Run command karma start

Open dev tools in karma browser

Refresh page if needed, wait until "debugger" line starts debug mode

Step into repeat.bind(); method

Notice the repeat.js file is from jspm package instead of the project source:

Expected/desired behavior:

Repeat object is loaded from src/repeat.js file.
Additional observations:
I guess the reason for this is that repeat object from Repeat class imported like this
import {Repeat} from '../src/repeat';
is never created. Instead one retrieved like this
component = StageComponent.withResources().inView('<div repeat.for="item of items"></div>').boundTo({ items: [] });
...
repeat = component.viewModel;
is used and it comes from jspm package.

It seems this is left unattended for too long. I just created a duplicated issue, with some unsuccessful attempts to fix.


Windows: Doesn't work because of .bin executable issue

Environment

OS: Windows 7/10
Node: 8
now: latest
CLI: git for windows (2.13)

Steps
Install
npm install now
Run
./node_modules/.bin/now -v

Error
./node_modules/.bin/now: line 1: /../now/download/dist/now: No such file or directory

Findings
Current: node_modules/.bin/now
"$basedir/../now/download/dist/now"   "$@"
exit $?

Expected: node_modules/.bin/now
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../now/download/dist/now" "$@"
  ret=$?
else
  node  "$basedir/../now/download/dist/now" "$@"
  ret=$?
fi
exit $ret

Note: By making this change it fixes the issue
ESLint example
I used ESLint generated code and replaced the file paths.
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
else
  node  "$basedir/../eslint/bin/eslint.js" "$@"
  ret=$?
fi
exit $ret

Notes/Questions

Really not sure why this is happening, maybe how its packaged?
We at ESLint doesn't do anything special and all this is generated by npm install process.
Sorry if this is duplicate. I did try searching :smile: .

@igorklopov

@gyandeeps why you use node_modules/.bin/now instead of node_modules/.bin/now.cmd? Do you use Cygwin? Windows prepends extensions like .exe and .cmd once it is going to execute a program. So now files are not executed. Their .exe or .cmd counterparts are executed.
If you delete now.cmd and eslint.cmd from .bin do they stop working?

I am not doing anything special, that how npm works on windows.
example if i want to run eslint i do ./node_modules/.bin/eslint.
I deleted eslint.cmd and it still works.

Well, does node_modules/.bin/now.cmd work?

So whenever you execute a package through npm like
{
     "lint": "eslint"
}

npm run lint: will hit the eslint.cmd to execute that. same goes for things which are installed globally.
Initially I installed now globally and ran the command now. that also when i got the same error. I am using git bash on windows. Not sure if that makes a difference or not. But again just changing that file content made everything work regardless on how you call the command.

I am also getting this issue:
OS: Windows 8.1
Node: Using nodist (multiple versions)
now: latest
CLI: hyper w/ cygwin

Same issue here.

Using git bash (on Windows 10) and installing now globally I get the error:
$ now -v
[...cut $USERPROFILE path...]/AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory

$ now.cmd -v
7.1.1

https://docs.npmjs.com/files/package.json#bin

Please make sure that your file(s) referenced in bin starts with #!/usr/bin/env node, otherwise the scripts are started without the node executable!

For npm to create the shim right, as suggested by @gyandeeps, the script defined in the bin property of package.json must have the shebang line  #!/usr/bin/env node.

Any news? 7.2.2 doesn't fix it.
Below the script expected for $USERPROFILE/AppData/Roaming/npm/now:
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/node_modules/now/download/dist/now" "$@"
  ret=$?
else
  node  "$basedir/node_modules/now/download/dist/now" "$@"
  ret=$?
fi
exit $ret

You can notice there is something wrong in the installation because now script doesn't have executable permissions (in git bash environment).

https://github.com/npm/cmd-shim/pull/25

Fixed in https://github.com/zeit/now-cli/pull/713

The issue still exists on git bash on windows

@zusamann I don't think the patch was included in the latest version 7.2.4.
Or do you mean you test the master and it doesn't work?

Oh sorry for the confusion, I simply used the latest release and did not build from master.

7.3.0 works fine. Thanks.

👌

Getting this issue today on version 8.1.0, Windows 10, using gitbash.
Anybody have a solution? Keep getting No such file or directory.

same here... I had to use powershell to make it work...

Same on 8.2.1 with git bash...

Sigh. 8.2.1 doesn't work.
See also #729.
+<EMAIL_ADDRESS>updated 1 package in 24.149s
16:02:38 [/c/My/Dev]
$ now -v
/c/Users/xobeci/AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory
16:02:57 [/c/My/Dev]
$

Anyway using now.cmd is ok.

We haven't tackled Git for Windows yet, but I suppose we should do that, now that so many people are interested in it. @igorklopov?

now not working on Windows 10 : Git Bash.
Error: /c/Users//AppData/Roaming/npm/now: line 1: /node_modules/now/download/dist/now: No such file or directory
Content of /c/Users/Nikunj/AppData/Roaming/npm/now
"$basedir/node_modules/now/download/dist/now"   "$@"
exit $?

i'm getting the same

I'm no expert but shouldn't now be a shell script? For example, compare cat now and cat tsc:
$ cat /c/Users/Borek/AppData/Roaming/npm/now
"$basedir/node_modules/now/download/dist/now"   "$@"
exit $?

$ cat /c/Users/Borek/AppData/Roaming/npm/tsc
#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  "$basedir/node"  "$basedir/node_modules/typescript/bin/tsc" "$@"
  ret=$?
else
  node  "$basedir/node_modules/typescript/bin/tsc" "$@"
  ret=$?
fi
exit $ret

I think that's what I've seen in most bootstrap scripts.

Windows 10, Git Bash
$ now.cmd works

Per @JesusCrow, you can run this for a workaround:
echo 'alias now="now.cmd"' >> .bashrc

Sigh again.
Apart a few single releases, like 7.3.0, in 9.0.0-canary.9 there is the issue.
Any news?

https://twitter.com/zeithq/status/930180257864437760

@leo are you sure?
Using git bash 2.15.0.windows.1, node 9.1.0 and npm 5.5.1, now is installed locally (and not globally).
$ npm ls now
<EMAIL_ADDRESS>C:\My\Dev\zzz\tobedefined
`--<EMAIL_ADDRESS>
$ node_modules/.bin/now ls
node_modules/.bin/now: line 1: /../now/download/dist/now: No such file or directory

node_modules/.bin/now.cmd ls works.
If you use now inside a npm script, it works: "deploy": "now deploy --public && now alias".
The installation is fixed (#729).

@albertosantini What command did you use to install it?

npm install now

It should be npm install -g now. The -g flag is required for installing packages globally.

Well... I want to install locally (per project) the package and there should not be any diff in terms of "executable".
At least, I didn't notice any difference using other tools, if they are installed globally or locally.
I don't (cannot) think now doesn't support this use case. :)


reopen - feat: Ignore case when check for selected filter

Reopen of #380

I need to modify the url of the department filters, which includes leaving some parts of it in lowercase. Because of this, some filters are not marked as selected
This PR just ignores the case when it does this check

@guitavano I spoke to @tlgimenes and we thought it would be better to create a prop to ignore the case instead of putting it directly in the code, because this could affect some stores
Do you think you can merge it?


Annex A: Schema build

With the schema imported to the data platform in #60 , we now need to convert the existing Annex A schema to a pipeline schema that can be used in the Dagster Annex A pipeline.

2 days

Put in Annex A pipeline.
Output within repo for now - to be updated later.


[Module Testing] tfvars file is not being used by terraspace test

Checklist

[x] Upgrade Terraspace
[x] Reproducibility
[x] Code sample

My Environment

Software
Version

Operating System
Ubuntu 20.04 (WSL2)

Terraform
1.0.2

Terraspace
0.6.11

Ruby
ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux]

Expected Behaviour

Terraspace use spec/fixtures/tfvars/demo.tfvars for terraspace test at module level

Current Behavior

terraspace test run init, plan and apply without using demo.tfvars

variable "myvar" {
  type        = string
  description = "Required variable"
}

Terraspace test return success, but logs said it can't init, plan or apply because validation. It is not including tfvars file! as input for terraspace test

terraspace test
=> cd test && bundle exec rspec

main
Terraspace.logger has been reconfigured to /tmp/terraspace/log/test.log
Building test harness at: /tmp/terraspace/test-harnesses/mybug-harness
Test harness built.
=> terraspace up mybug -y
=> terraspace down mybug -y

Finished in 9.3 seconds (files took 0.42923 seconds to load)
0 examples, 0 failures

[2021-07-15T11:17:07 #17971 ]: Building .terraspace-cache/us-west-2/test/modules/mybug
[2021-07-15T11:17:10 #17971 ]: Built in .terraspace-cache/us-west-2/test/modules/mybug
[2021-07-15T11:17:10 #17971 ]: Current directory: .terraspace-cache/us-west-2/test/modules/mybug
[2021-07-15T11:17:10 #17971 ]: => terraform plan -input=false -out /tmp/terraspace/plans/mybug-3f31c6546719d94c6bba70979b8e06d2.plan
[2021-07-15T11:17:10 #17971 ]: ╷
[2021-07-15T11:17:10 #17971 ]: │ Error: No value for required variable
[2021-07-15T11:17:10 #17971 ]: │
[2021-07-15T11:17:10 #17971 ]: │   on variables.tf line 3:
[2021-07-15T11:17:10 #17971 ]: │    3: variable "myvar" {
[2021-07-15T11:17:10 #17971 ]: │
[2021-07-15T11:17:10 #17971 ]: │ The root module input variable "myvar" is not set, and has no default
[2021-07-15T11:17:10 #17971 ]: │ value. Use a -var or -var-file command line argument to provide a value for
[2021-07-15T11:17:10 #17971 ]: │ this variable.
[2021-07-15T11:17:10 #17971 ]: ╵
[2021-07-15T11:17:10 #17971 ]: Error running command: terraform plan -input=false -out /tmp/terraspace/plans/mybug-3f31c6546719d94c6bba70979b8e06d2.plan
[2021-07-15T11:17:10 #17971 ]: Building .terraspace-cache/us-west-2/test/modules/mybug
[2021-07-15T11:17:11 #17971 ]: Built in .terraspace-cache/us-west-2/test/modules/mybug
[2021-07-15T11:17:11 #17971 ]: => terraform plan -input=false -destroy
[2021-07-15T11:17:12 #17971 ]: ╷
[2021-07-15T11:17:12 #17971 ]: │ Error: No value for required variable
[2021-07-15T11:17:12 #17971 ]: │
[2021-07-15T11:17:12 #17971 ]: │   on variables.tf line 3:
[2021-07-15T11:17:12 #17971 ]: │    3: variable "myvar" {
[2021-07-15T11:17:12 #17971 ]: │
[2021-07-15T11:17:12 #17971 ]: │ The root module input variable "myvar" is not set, and has no default
[2021-07-15T11:17:12 #17971 ]: │ value. Use a -var or -var-file command line argument to provide a value for
[2021-07-15T11:17:12 #17971 ]: │ this variable.
[2021-07-15T11:17:12 #17971 ]: ╵
[2021-07-15T11:17:12 #17971 ]: Error running command: terraform plan -input=false -destroy

Step-by-step reproduction instructions

Create module
Create variables which is required to be set
Create spec/fixtures/tfvars/demo.tfvars with input for this variable.
Run terraspace test

Code Sample

https://gitlab.com/thuandt/tfspace-examples

Solution Suggestion
NA

Don't believe the example specifies the usage of the tfvars file. Suposed to specify tfvars files explicitly by design so you can use different tfvars in the test harness if needed. Here's an example repo:

https://github.com/tongueroo/terraspace-test-tfvars-example
And a spec that confirms that the produced length from test.tfvars is actually used.

Assertion: https://github.com/tongueroo/terraspace-test-tfvars-example/blob/2d2e8b9166d2a011c0810045b74f4cf98ee8531c/app/stacks/demo/test/spec/main_spec.rb#L28
test.tfvars file: https://github.com/tongueroo/terraspace-test-tfvars-example/blob/master/app/stacks/demo/test/spec/fixtures/tfvars/

    terraspace.build_test_harness(
      name: "example-harness",
      modules: {example: mod_path},
      # See: https://terraspace.cloud/docs/testing/test-harness/
      # config: "spec/fixtures/config",
      tfvars: {demo: "spec/fixtures/tfvars/test.tfvars"}, # <-- Make sure to have this
    )

Also covered in docs: https://terraspace.cloud/docs/testing/stack/


scrambled results when merging cached carbon data with whisper data

When merging cached data from carbon with the data pulled from the whisper file, the values were getting scrambled (i.e., values reported at the wrong timestamp).  In my case I was seeing this with:

a whisper file that stores data every 300 seconds
a request for the past 6 hours of data
a job that just rewrote 24 hours of data (so 24 hours were in carbon's cache)
a very slow rate of flushing carbon's cache into the whisper files

So while the whisper file was returning this:
Tue Mar 10 13:30:00 2015        41.000000
Tue Mar 10 13:35:00 2015        41.000000
Tue Mar 10 13:40:00 2015        41.000000
Tue Mar 10 13:45:00 2015        41.000000
Tue Mar 10 13:50:00 2015        41.000000
Tue Mar 10 13:55:00 2015        41.000000
Tue Mar 10 14:00:00 2015        41.000000
Tue Mar 10 14:05:00 2015        41.000000
Tue Mar 10 14:10:00 2015        41.000000
Tue Mar 10 14:15:00 2015        41.000000
Tue Mar 10 14:20:00 2015        41.000000
Tue Mar 10 14:25:00 2015        41.000000
Tue Mar 10 14:30:00 2015        45.000000
Tue Mar 10 14:35:00 2015        45.000000
Tue Mar 10 14:40:00 2015        45.000000
Tue Mar 10 14:45:00 2015        45.000000
Tue Mar 10 14:50:00 2015        45.000000
Tue Mar 10 14:55:00 2015        None
Tue Mar 10 15:00:00 2015        None
Tue Mar 10 15:05:00 2015        None

The graphite query was returning:
temperature.fahrenheit.mean,2015-03-10 13:30:00,35.1
temperature.fahrenheit.mean,2015-03-10 13:35:00,35.1
temperature.fahrenheit.mean,2015-03-10 13:40:00,41.0
temperature.fahrenheit.mean,2015-03-10 13:45:00,35.1
temperature.fahrenheit.mean,2015-03-10 13:50:00,41.0
temperature.fahrenheit.mean,2015-03-10 13:55:00,41.0
temperature.fahrenheit.mean,2015-03-10 14:00:00,41.0
temperature.fahrenheit.mean,2015-03-10 14:05:00,35.1
temperature.fahrenheit.mean,2015-03-10 14:10:00,35.1
temperature.fahrenheit.mean,2015-03-10 14:15:00,41.0
temperature.fahrenheit.mean,2015-03-10 14:20:00,41.0
temperature.fahrenheit.mean,2015-03-10 14:25:00,41.0
temperature.fahrenheit.mean,2015-03-10 14:30:00,35.1
temperature.fahrenheit.mean,2015-03-10 14:35:00,35.1
temperature.fahrenheit.mean,2015-03-10 14:40:00,45.0
temperature.fahrenheit.mean,2015-03-10 14:45:00,35.1
temperature.fahrenheit.mean,2015-03-10 14:50:00,45.0
temperature.fahrenheit.mean,2015-03-10 14:55:00,35.1
temperature.fahrenheit.mean,2015-03-10 15:00:00,45.0
temperature.fahrenheit.mean,2015-03-10 15:05:00,35.1

Once the cached data was flushed into the whisper file by carbon then the graphite query began to work properly again..
I'll preface this by stating I'm not a python programmer.  What I found is that when merging the cached data into the whisper data, the cached data (which is a longer series) attempts to write outside the bounds of the values array that holds the whisper file data.  I assumed the try block was there to catch those conditions, but the scrambled data problem was resolved as soon as I specifically checked that the cached data's calculated index was within the bounds of the array before attempting to write it.  I left the try in place, and perhaps there is a better fix than this (or a more idiomatic python approach than my fix).

I'm pleased that this fixes it for you but I think there are some larger issues wrt consistency. I'm looking into this and will let you know what I find out.

Would you mind reverting your change and trying out the patch in #1337 to see if that fixes it for you?

There have been a number of recent fixes, specifically to the merging of CarbonLink and Whisper data, that should address this issue. Closing this out but please let us know if you're still experiencing with the issue with the in-tree fixes.


FluentAPI does not work anymore on 4.16.1

Bug description
can't use fluent api
since this last 4.16.1 version
Property '[REDACTED]' does not exist on type 'PrismaPromise<GetResult<{ ....}

How to reproduce
try to use fluent api and latest version of Prisma
Expected behavior
No response
Prisma information
prisma.MODEL.findUnique().FLUENT_RELATION()

Environment & setup
on macOS and node 20 but not the problem here
Prisma Version
4.16.1

Oh no I was already on 4.16 with this error https://github.com/prisma/prisma/issues/19866
so 4.15 was working great for me, 4.16 gives the error with extends, and 4.16.1 this one

Hey @yovanoc, thanks for the report. I opened a PR to fix this, would you mind installing trying version 4.17.0-integration-client-extensions-fluent-api.1 and let us know if the fluent API works for you?

@millsp Yes, working perfectly!

:shipit: Note: This fix is now available as 4.16.2


Fix UG bugs and update index.md

Closes #168 , closes #169 , closes #174 , closes #184

Codecov Report

Merging #186 (9448703) into master (73cce49) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #186   +/-   ##
=========================================
  Coverage     53.06%   53.06%
  Complexity      525      525
=========================================
  Files           113      113
  Lines          2186     2186
  Branches        258      258
=========================================
  Hits           1160     1160
  Misses          948      948
  Partials         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cce49...9448703. Read the comment docs.


DBZ-7193 Unchanged toasted array columns are substituted with placeholder even if REPLICA IDENTITY == FULL

Jira Issue: https://issues.redhat.com/browse/DBZ-7193
Affected Debezium versions > 2.0

@Prabhu19 Applied, thanks


ch03: scripts update

The new repo is https://github.com/PacktPublishing/Hands-On-Design-Patterns-with-CPP-Second-Edition


Support rest parameters in interface files

Consider the following interface file, interface/foo.js:
declare module 'foo' {
  declare class Foo {
    bar(...args): Foo;
  }
}

Running flow 0.16.0 against this, I get:
.../interface/foo.js:3:16,16: Library parse error:
.../interface/foo.js:3:16,16: Unexpected token )

Am I doing it wrong, or is this just not supported yet?

Rest parameters are supported, but Flow is complaining that you have not provided a type annotation to the rest argument (unexpected ), when it was expecting white space or a : to kick off the type annotation).
This does work:
declare module 'foo' {
  declare class Foo {
    bar(...args: any[]): Foo;
  }
}

Note that the rest parameter has an array type.

Oh. Duh. Thanks!

Mayyyybe Flow's error message could be more helpful? Rather than suggesting that my syntax is broken, tell me that I'm missing a type annotation?


The dSYMs are missing when the task is launched for the first time after cleaning the build directory

./gradew clean
./gradlew createXCFramework //missing dsyms
./gradlew createXCFramework //dsyms ok
I tested it for release and arm64 architecture.
The problem is in this condition:
https://github.com/luca992/multiplatform-swiftpackage/blob/cb13b931835dcb8e05546a17ff056a2337ba2cc4/src/main/kotlin/com/chromaticnoise/multiplatformswiftpackage/task/CreateXCFrameworkTask.kt#L188

Ohh thanks for finding what was causing that! I haven't had time to dig into why I've had to run it twice.

I think that at the time when the task is being created, there is still an empty build directory, so the condition is false. Perhaps the command for creating the framework could be moved to the 'doLast' block.

@lukisk try 2.2.2-SNAPSHOT
Lmk if how it goes.
use this repo:
repositories {
    maven("https://s01.oss.sonatype.org/content/repositories/snapshots/")
}

I tried moving that part into doLast
https://github.com/luca992/multiplatform-swiftpackage/commit/d5273276d7d5bf873927677c295195787211ed45

@luca992
Build ends with this error:
`> Task :multiplatform:createXCFramework
Command line invocation:
/Applications/Xcode-15.0.1.app/Contents/Developer/usr/bin/xcodebuild
User defaults from command line:
IDEPackageSupportUseBuiltinSCM = YES
2024-01-03 16:17:36.355 xcodebuild[69274:14308976] Writing error result bundle to /var/folders/8k/7dd9jgn11z73smwj81b6nnlh0000gn/T/ResultBundle_2024-03-01_16-17-0036.xcresult
xcodebuild: error: The directory /Users/..../multiplatform does not contain an Xcode project.`

@lukisk alright I'll take a deeper look soon when I put out a release of one of my libraries using this, unless you want to dig into it more

@luca992 i fixed it

@lukisk Thanks for that! 2.2.2-SNAPSHOT has been updated with your fix. I'll release 2.2.2 after I try it out myself soon

just wondering if 2.2.2 is ready

@idevdroidapps It probably is. I just haven't tried it to make sure yet. I'll get to it in the next couple days. If the snapshot is working well for you lmk

@idevdroidapps released seems to be working well, thanks again @lukisk


Authentication token is missing

Hey Guys
So  have been hacking away on this problem since yesterday...and I can't seem to find the problem here. I was wondering if you guys might have some tips as to how I can further debug this issue.
problem statement
I have a feathers-rest service setup with some of the endpoints that I restricted with the feathers-authentication hooks. Now when I login I do receive the JWT token, but when I use this token to authenticate the action I got an Error message back that says the following "message":"Authentication token missing.". I send the token via the HTTP authorization header as specified by my config file. And I have checked XHR request header to see if the token is been send. And everything seems fine. So I don't know why the verifyToken() hook sends back the missing token message.
here is an example output of a console log on my feathers app's settings.auth
  shouldSetupSuccessRoute: 'false',
  shouldSetupFailureRoute: 'false',
  successRedirect: '/auth/success',
  failureRedirect: '/auth/failure',
  tokenEndpoint: '/auth/token',
  localEndpoint: '/auth/local',
  userEndpoint: '/users',
  header: 'authorization',
  cookie: { name: 'feathers-jwt', httpOnly: false, secure: false },
  token: { secret: 'xFsUsFG+/a+q2ee8wNuo4ZSE+FOxyqR9+tE4ck3fKX4K8VZneYOEQYOmsbQqZbukUw+Bu9MYg2jFLpS//Ch2bA==' },
  local: { usernameField: 'email' } }

I  can send you guys further gist and any information you guys need,  but I am happy enough to fix my own issues. It is just I do not know how to further debug this problem. Any tips?

So have made some progress on the issue. I have hacked around on the source code for feathers-authentication looking for the source of the problem. So the error message is generated in the /lib/hooks/verify-token.js on line 21. it appears it is looking for the token in the hook.params.token. So I have console.log the variable and it appears to be undefined. I am sending my token via the http headers using axios.  The reason I am not using feathers-client is that the service is a stand-alone service on a separate server so it needs to work via XHR request...for client purposes. So using feathers-client is not a solution. So how do get the token into hook.params without actually posting through form data?

I have manage to sort out the issue. I rearranged the order in which my feathers app was configured. I moved my feathers-rest and feathers-hooks config before the body parser thanks to the tip from one of my senior developers. It seems that the body parser might of been eating up my authorisation header. Not sure how though but everything seems to work after reordered the way the app was configured.


[google_maps_flutter_web] document that liteModeEnabled is not supported

liteModeEnabled is not supported in google_maps_flutter_web, but the web documentation gives no indication of such.

Related : https://github.com/flutter/flutter/issues/80287

/cc @ditman

We can surely add this as not supported in the web README, but in the linked documentation, it explicitly says Android only.


Shared_ptr fixes

@vigsterkr I think the only things failing now are related to the old parameter framework?


[FLINK-33480] Implement restore tests for GroupAggregate node

What is the purpose of the change
Implement restore tests for GroupAggregate node
Verifying this change
This change added tests and can be verified as follows:

Added restore tests for GroupAggregate node which verifies the generated compiled plan with the saved compiled plan)

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

The CI failure is from spotless.


Annotation - improve getting variable name

Coverage increased (+0.04%) to 93.148% when pulling 326ca1b21a3e744a7b93fa26c98fe5834283933d on werlos:annotations_improve_getting_variable_name into 6fe4c69fc46c8cae6d511778b548f628b88c2375 on FriendsOfPHP:master.

Thank you @kubawerlos.


firebase serve config

Whilst working through you Web Chat App Javascript tutorial I hit an error when executing firebase serve.
From, firebase-debug.log:
[debug] TypeError: Cannot read property 'public' of undefined     at Server.<anonymous> (/usr/local/lib/node_modules/firebase-tools/commands/serve.js:25:15)
I was able to prevent this error by commenting out the following lines in serve.js (obviously not ideal):
    if (config.public && config.public !== '.') {       logger.info(chalk.bold('Public Directory:'), config.public);     }

I had a similar issue. If you go into the web-start directory and run:
firebase init
when you get to this question:
=== Hosting Setup

Your public directory is the folder (relative to your project directory) that
will contain Hosting assets to uploaded with firebase deploy. If you
have a build process for your assets, use your build's output directory.

? What do you want to use as your public directory?

You can use ./ here (make sure you tell it not to redirect links or overwrite index.html as well in the other steps for init).
When you get to step 13:
https://codelabs.developers.google.com/codelabs/firebase-web/#12
firebase.json has a section that does the same thing:
"hosting": {
    "public": "./",

Thanks @uzusan, I was sure it was a rookie error.

Thanks for the report guys. I'll fix this. It seems the alpha version of the CLI that I was using did not require the hosting/public attribute to be set but it now does...


Update processor test to work with the new processor thread

Coverage decreased (-0.2%) to 77.043% when pulling 204b3a6f07021a68c6bf5fa6c9bf944a03add933 on jmedved:contiv-crd into 5cfd14ce75274bf08e03db69761b4cb43e5bef81 on contiv:contiv-crd.


Meshes Changed after mesh_resource_provider_system don't get initialized

With the latest performance fixes on master, there is an issue with creating meshes in stages that happen after mesh_resource_provider_system. I've debugged it and reduced it to this sample case (from my actual code which hits this).
This code will panic on bevy master:
With: thread 'main' panicked at 'Attribute Vertex_Position is required by shader, but not supplied by mesh. Either remove the attribute from the shader or supply the attribute (Vertex_Position) to the mesh. ', crates\bevy_render\src\pipeline\pipeline_compiler.rs:223:17
  use bevy::prelude::*;

  fn main() {
    App::build()
      .add_plugins(DefaultPlugins)
       // add_stage ends up adding it last in the stage order?
      .add_stage("panic_due_to_stage_order")
      .add_system_to_stage("panic_due_to_stage_order", panic_due_to_stage_order)
      .run();
  }

  fn panic_due_to_stage_order(commands: &mut Commands, mut materials: ResMut<Assets<ColorMaterial>>) {
    commands.spawn(SpriteBundle {
        material: materials.add(ColorMaterial::color(Color::RED)),
        ..Default::default()
    });
  }

The issue is that in the new optimized mesh_resource_provider_system implementation we are using Changed<> to detect when we need to initialize the render_pipeline for the mesh. Unfortunately, the mesh has not yet been flagged for Changed at the time the mesh_resource_provider_system runs and Changed gets reset every frame.
Ideally it shouldn't matter at what stage you spawn your entity/components.
Some half-baked ideas on how to fix this in bevy (obviously without reverting the perf improvement):

Just run mesh_resource_provider_system again at the end of the frame, it could capture the entities that Changed and weren't processed in the first pass. This seems a bit hacky. Also there's no way currently to pin a system at the end anyway.
Introduce a ChangedLastFrame<> query filter. This would allow us to build a system that can handle changes to entities and the order of the system doesn't matter. In this mesh system case we would check both this ChangedLastFrame and Changed<>

I'd like to contribute a fix to resolve this, if we can figure out what's a good way to fix this... Perhaps there's a trivial way I am not seeing!

Ideally it shouldn't matter at what stage you spawn your entity/components.

I don't think I agree. The whole point of stages is to be able to make different assertions about what has been done and what hasn't been done. I personally think it is 100% ok to say "meshes should be spawned before POST_UPDATE". The UPDATE stage is where app logic is supposed to go (and spawning entities is "app logic"). You can always create new stages directly after the UPDATE stage.

Ah in that case if we take that stance (which seems reasonable), it seems like we need some way to make this failure feel less like undefined behavior? In this case, the failure ends up happening pretty far down the line.

I think the "give someone a helpful error if they insert logic into the wrong stage" problem is a bit of a rabbit hole:

There are so many classes of error that fall into this category. We would be adding conditionals to literally everything
It would be expensive to do these checks everywhere to handle every case (both computationally and from a dev time perspective)
Even if the computational cost of the checks was negligible and we had infinite dev time to implement them, it would still have a cost on maintainability + overall code size.

Id rather just have a rule of thumb that "app logic goes in UPDATE". everything else is undefined behavior.

Gotcha, you've convinced me


Add alt text validation option to user preferences (supersedes #913)

Supersedes #913. Closes #907
Builds on the PR by updating the UI of the toggle

Error does not go away even if I add alt text. It will go way if I press post because all alt text is added, but it is confusing for the user.

Yeah agree. I got pulled into an unscheduled meeting that ate most of my day, and I need to start building the release so I'm going to come back to this tomorrow and try to get it into the next build.

Probably worth noting that the same behavior occurs with the "Did you want to say anything?" error

Error does not go away even if I add alt text. It will go way if I press post because all alt text is added, but it is confusing for the user.

@ansh okay I updated it to do that now, RFR


Polyline Issue with Star Burst feature in 2D/CV Mode

Per Sandcastle demo: Star Burst, polylines do not render correctly when expanding a star burst in 2D or CV modes.
3D Mode (Correct):

2D/CV Mode (Incorrect):

Thanks for reporting this @WebDevJR!

Brought up on the forum here: https://groups.google.com/forum/#!topic/cesium-dev/xe_WUQtF4uA


ng-click on task is not working

After upgrated to lasted version (1.3.0).
Task ng-click stop working.
        function taskTemplate() {

            var template = '';

            template += '' +
                '';

            template += '{{task.model.description}}';
            template += '';
            return template;
        }

any tips?

Same problem here. I couldn't find a quick solution so I'm using 1.2.14 for the time being.

I'll try to fix this issue, stay tuned.

This is due to a conflict with movable plugin. When removing the plugin, it works as expected.

@Toilal you r the guy! Thanks :)

How do we fire task ng-click ??? Thanks


Category display and creation issue

There is some issue with the newest revision when creating and displaying categories.
Rails v3.2.21, Ruby v2.0
Please see the gif below.

@joffems please take a look at this issue. It is completely breaking the ability to navigate around.  The database storage of the items seems correct with just one of each item stored, however duplicates are displayed.  I've attached a larger gif.

I am at latest master branch and I added new product and created category and I don't see any issue.
kiran@jaihanuman:~/testcasedb$ git log
commit fc0218628119249f5b4c45d3147ace632d3770f7
Author: Marc Joffe<EMAIL_ADDRESS>Date:   Sat Feb 7 00:23:26 2015 -0500
Add basic Redis instructions to the README

My Rails server is running in development mode on a Mac with OSX 10.9
I'll do a diff with my local code and the master branch and maybe try reinstalling TestCaseDB.

@agramian Are you still having this issue? I cannot reproduce this locally.
If it is still occurring, which browser are you using.

@joffems yes I still have this issue.  I am using the latest version of master with ruby-2.0.0-p598, Rails v3.2.21, Mac with OSX 10.9, Chrome Version 41.0.2272.89 (64-bit)
All objects are displayed as duplicates, not just the categories.  Are you using a mac to try and reproduce this?


A function get_ch_positions for DigMontage

Describe the new feature or enhancement
If I have an existing montage and want to add fiducials, there is currently no way to do that without calling make_dig_montage again. But the montage itself does not provide a way to get the ch positions.
Currently the only way I can find that gets a montage is either you make it from scratch make_dig_montage or you get it from raw using raw.get_montage. But if you say already have an existing montage via raw.get_montage() it seems you would have to hack out the channel positions and then call make_dig_montage again? Since there is no public API for getting the channel positions, I wonder if there's an easier way around this?
Describe your proposed implementation
Possibly a get_ch_positions() public function for DigMontage, that one can then do:
montage  = raw.get_montage()
ch_positions = montage.get_ch_positions()

Additional comments
TBD

sorry I don't get the usecase. Can you clarify what you start from and what
you are aiming for?

sorry I don't get the usecase. Can you clarify what you start from and what you are aiming for?
…

Sorry about that. I updated the description. I just want to add fiducials to an existing montage.

ok got it. You want an easy way to get the parameters ch_pos etc... required by make_dig_montage from a DigMontage instance.
montage.get_ch_pos?
but then shall we add get_nasion, get_lpa etc...
@larsoner thoughts?

but then shall we add get_nasion, get_lpa etc...

Maybe a more generic get_positions(kinds='all' | 'channels' | 'extra' | 'fiducials' | list of str)?

I prefer this yes. You would get a dict as output that you can directly
pass with **kwargs in make_dig_montage

In that case we should just make it get_positions(), and doing mon_2 = make_dig_montage(**mon.get_positions()) should have all attributes of mon and mon_2 the same. If you want the channel positions you just use mon.get_positions['ch_pos']

... or maybe get_params or get_parameters() is better, since coord_frame is an argument of make_dig_montage. So mon.get_parameters()['ch_pos'] if you want just channel positions. Or we use get_positions() and live it being a misnomer because of mon.get_positions()['coord_frame'] being there

(I guess coord_frame is information about the positions so I guess this wouldn't be so bad)

+1 for get_positions

So DigMontage.get_positions(), which returns a dictionary of channels positions and all the fiducials (if they're there).
Is there any reason we can't say just take the code inside get_montage rn:
        # obtain coord_frame, and landmark coords
        # (nasion, lpa, rpa, hsp, hpi) from DigPoints
        montage_bunch = _get_data_as_dict_from_dig(self.info['dig'])
        coord_frame = _frame_to_str.get(montage_bunch.coord_frame)

        # get the channel names and chs data structure
        ch_names, chs = self.info['ch_names'], self.info['chs']
        picks = pick_types(self.info, meg=False, eeg=True,
                           seeg=True, ecog=True)

        # channel positions from dig do not match ch_names one to one,
        # so use loc[:3] instead
        ch_pos = {ch_names[ii]: chs[ii]['loc'][:3] for ii in picks}

        # create montage
        montage = make_dig_montage(
            ch_pos=ch_pos,
            coord_frame=coord_frame,
            nasion=montage_bunch.nasion,
            lpa=montage_bunch.lpa,
            rpa=montage_bunch.rpa,
            hsp=montage_bunch.hsp,
            hpi=montage_bunch.hpi,
        )
        return montage

and make the part before make_dig_montage the code for get_positions()? If so it looks pretty straightforward.

That code operates on an info object. There is no info as part of DigMontage


powershell_script guards written as strings do not work

Version:
11.12.8
Environment:
Windows 2012 Server R2 (possibly all windows)
Scenario:
None of my string powershell_script guard expressions were working until I converted them to blocks. This is not required for other similar resources, such as execute.
Steps to Reproduce:
Does not work (guardtest.log is written to):
powershell_script "Powershell guard testing" do
  code "\"Script executed\" >> \"C:/chef/cache/guardtest.log\""
  not_if "$True"
  guard_interpreter :powershell_script
  convert_boolean_return true
end

This does work (guardtest.log is not written to):
powershell_script "Powershell guard testing" do
  code "\"Script executed\" >> \"C:/chef/cache/guardtest.log\""
  not_if { "$True" }
  guard_interpreter :powershell_script
  convert_boolean_return true
end

Expected Result:
Powershell guards should work written as a string and as a block.
Actual Result:
Powershell guards only works as a block, either using curly braces or do/end.

This appears to still be an issue in 11.18.12 (Can't run newer versions of chef due windows bug https://github.com/chef/chef/issues/2814 )
Is there a release version for this fix?


Received error on running Huggingface LLM on a Windows 10 machine

After installing your library and tried given example on my win10 machine I got following error
Invalid Parameter - 150 Traceback (most recent call last):   File "C:\Python310\lib\runpy.py", line 196, in _run_module_as_main     return _run_code(code, main_globals, None,   File "C:\Python310\lib\runpy.py", line 86, in _run_code     exec(code, run_globals)   File "C:\Python310\Scripts\dr-doc-search.exe\__main__.py", line 7, in <module>   File "C:\Python310\lib\site-packages\doc_search\app.py", line 68, in main     run_workflow(context, training_workflow_steps())   File "C:\Python310\lib\site-packages\py_executable_checklist\workflow.py", line 36, in run_workflow     __run_step(step, context)   File "C:\Python310\lib\site-packages\py_executable_checklist\workflow.py", line 29, in __run_step     returned_context = step_instance.execute() or {}   File "C:\Python310\lib\site-packages\doc_search\workflow\__init__.py", line 120, in execute     run_command(convert_command)   File "C:\Python310\lib\site-packages\py_executable_checklist\workflow.py", line 9, in run_command     return subprocess.check_output(command, shell=True).decode("utf-8")  # nosemgrep   File "C:\Python310\lib\subprocess.py", line 420, in check_output     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,   File "C:\Python310\lib\subprocess.py", line 524, in run     raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command 'convert -density 150 -trim -background white -alpha remove -quality 100 -sharpen 0x1.0 C:\Users\XXXX\OutputDir\dr-doc-search\parable_monetary_economy\parable_monetary_economy.pdf[1] -quality 100 C:\Users\XXXX\OutputDir\dr-doc-search\parable_monetary_economy\images\output-1.png' returned non-zero exit status 4.
Any Help to fix this issue?

This is probably related to #7

This is merged and available in 1.6.3. You'll need to set up an environment variable with the location of ImageMagick executable file before running this. See the README for more info


Support leaflet v1+ fractional zooms

Leaflet v1 supports fractional zooms and reports zooms such as 12.45 from map.getZoom(), which leaflet-hash does not expect. As a result, leaflet-hash will display hashes such as #11.375325620188496/40.7154/-73.9275 but only sets the view at zoom 11. This PR fixes this behavior if the Leaflet version detected is v1+:

Hash display is now set at the same precision level as lat/lng for more sensible looking URLs.
Hash is parsed as a float instead of as an integer, so that the map view is set to the correct zoom.

This behavior is not changed on Leaflet versions before v1 (zoom 12 will not start showing up with unnecessary precision, such as 12.0000 for example).

ping @mlevans

This would be a nice upgrade - a small change with a clear improvement in functionality.


LXD fail to start

Required information

Distribution: Ubuntu
Distribution version: xenial 16.04
The output of "lxc info" or if that fails:
error: Get http://unix.socket/1.0: read unix @->/var/lib/lxd/unix.socket: read: connection reset by peer

Kernel version: 4.13.0-37-generic
LXC version: 2.0.11
LXD version: 2.0.11
Storage backend in use: dir

Issue description
I was following the instructions on the Getting-Start page, after I finished the lxd init and reboot my machine, I couldn't get the lxd work normally.
I've tried $ lxc list and it output Connection refused; is LXD running?
Information to attach
I also tried $ sudo service lxd start and it said A dependency job for lxd.service failed. See 'journalctl -xe' for details. below is the full logs:
Mar 27 16:58:01 scope-B150M-D3H systemd[1]: Failed to start LXD - network bridge.
-- Subject: Unit lxd-bridge.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit lxd-bridge.service has failed.
--
-- The result is failed.
Mar 27 16:58:01 scope-B150M-D3H systemd[1]: Dependency failed for LXD - main daemon.
-- Subject: Unit lxd.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit lxd.service has failed.
--
-- The result is dependency.
Mar 27 16:58:01 scope-B150M-D3H systemd[1]: lxd.service: Job lxd.service/start failed with result 'dependency'.
Mar 27 16:58:01 scope-B150M-D3H systemd[1]: lxd-bridge.service: Unit entered failed state.
Mar 27 16:58:01 scope-B150M-D3H systemd[1]: lxd-bridge.service: Failed with result 'exit-code'.
Mar 27 16:58:01 scope-B150M-D3H sudo[2662]: pam_unix(sudo:session): session closed for user root
Mar 27 16:58:01 scope-B150M-D3H nm-dispatcher[2758]: req:2 'down' [lxdbr0]: start running ordered scripts...

The lxd-bridge systemd unit is the problem here. The most common source of failure for it is when you have another DNS server running on your system like bind9/named

Manually running sudo /usr/lib/lxd/lxd-bridge.start would likely show the underlying error which would confirm if it's a conflicting DNS server or something else.

I ran /usr/lib/lxd/lxd-bridge.start and here's the output:
dnsmasq: failed to create listening socket for <IP_ADDRESS>: Address already in use
Failed to setup lxd-bridge.

it seemed the ip address I set while doing lxd init is already taken
is there any way I can check which application is using that ip address or can I change the ip setting of lxd?
thanks

Ok, so that's the error I'd expect if you already had a DNS server running.
Running sudo netstat -lnp | grep 53 would let you check what's binding port 53 on your system.

here's the output
tcp        0      0 <IP_ADDRESS>:53        <IP_ADDRESS>:*               LISTEN      1518/named
tcp        0      0 <IP_ADDRESS>:53           <IP_ADDRESS>:*               LISTEN      1518/named
tcp        0      0 <IP_ADDRESS>:53            <IP_ADDRESS>:*               LISTEN      1236/dnsmasq
tcp        0      0 <IP_ADDRESS>:53       <IP_ADDRESS>:*               LISTEN      1236/dnsmasq
tcp        0      0 <IP_ADDRESS>:953           <IP_ADDRESS>:*               LISTEN      1518/named
tcp6       0      0 ::1:53                  :::*                    LISTEN      1236/dnsmasq
tcp6       0      0 ::1:953                 :::*                    LISTEN      1518/named
udp        0      0 <IP_ADDRESS>:5353            <IP_ADDRESS>:*                           1000/avahi-daemon:
udp        0      0 <IP_ADDRESS>:53        <IP_ADDRESS>:*                           3756/dnsmasq
udp        0      0 <IP_ADDRESS>:53        <IP_ADDRESS>:*                           1518/named
udp        0      0 <IP_ADDRESS>:53           <IP_ADDRESS>:*                           1518/named
udp        0      0 <IP_ADDRESS>:53       <IP_ADDRESS>:*                           1518/named
udp        0      0 <IP_ADDRESS>:53            <IP_ADDRESS>:*                           1518/named
udp        0      0 <IP_ADDRESS>:53            <IP_ADDRESS>:*                           1236/dnsmasq
udp        0      0 <IP_ADDRESS>:53       <IP_ADDRESS>:*                           1236/dnsmasq
udp6       0      0 :::53289                :::*                                1000/avahi-daemon:
udp6       0      0 :::5353                 :::*                                1000/avahi-daemon:
udp6       0      0 :::53                   :::*                                1518/named
udp6       0      0 ::1:53                  :::*                                1236/dnsmasq
unix  2      [ ACC ]     STREAM     LISTENING     29755    1517/dockerd        /run/docker/libnetwork/dd22f75434570b13809605a96f15bc9fc50412d862e723a5e537d0a5793273bf.sock

do I need to unbind all of them or there's specific one cause the problem ?
thanks

Ok, so as expected the problem is that you have the bind9 package installed (which runs that named service).
If you don't need a full DNS server running on your machine, then just removing the bind9 package will take care of the problem. If you do need that DNS server, then you'll have to configure bind9 to only listen to those interfaces you need it to. I can't remember exactly how that works, but it's some config in /etc/bind9/

so after deleting bind9 everything is working correctly and I can successfully launch my first container, thanks for the help .


Add support for specifying example parameters

Codecov Report

Merging #394 into master will decrease coverage by 0.12%.
The diff coverage is 95%.

@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
- Coverage     91.45%   91.32%   -0.13%
- Complexity      194      204      +10
============================================
  Files            10       10
  Lines           503      519      +16
============================================
+ Hits            460      474      +14
- Misses           43       45       +2

Impacted Files
Coverage Δ
Complexity Δ

src/Tools/Generator.php
93.79% <95%> (-0.79%)
63 <6> (+10)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f8692...ca9bc19. Read the comment docs.


Result image same size as crop area?

Is it possible to make result image to be the same size as crop area?

@kukipei I'm with you.
@alexk111 Your tool is quite easy to apply but when you use images/jpg's of high quality ... no way to utilize it. Why? Crop area shows bad quality preview image even if they aren't originally. Then I have to guess what size of cropped image must be to keep good quality. It should be taken as it is selected by user. For instance if original picture is 1000px x 1000px and user select half of the picture, the cropped image should result with 500px x 500px size. It doesn't work like that, does it?
Piotr

I see same thing happening. the result image size is set to a fixed size.... not the way I expected it to behave


Lazy loading from API

Any sample on how to lazy load using API?
The same feature for react here:
https://linguinecode.com/post/lazy-loading-react-i18next-translations
And also, does this support .NET 4.5?

It already tries to lazy load files from disk when the namespace is requested if you use the file based providers. If you need loading the translations from a database or some other source you have to implement your own translation backend and you can also implement lazy loading for namespaces there.
The package is built on .NET Standard 2.0 which is not supported by .NET Framework 4.5
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
You can use the package starting with .NET Framework 4.6.1


Update ktlint to 0.47.x

Expected Behavior
Dependencies are kept up to date.
Current Behavior
We're on 0.46.1
Context
Latest update has breaking API changes which detekt must adapt to: https://github.com/pinterest/ktlint/releases/tag/0.47.0

Do we consider this a blocker for 1.22.0?

I would not consider it a blocker.

Agreed, not a blocker - it would be better to update, but it didn't seem simple to do when I tried because of the API changes, and I'm not sure if anyone else is working on it.


Fixed typos

While looking through examples, I took the time to fix some typos.

Without visibility to the ADO build pipeline, I cannot tell why if failed.

It's not you, it's me. There's something up with the pipeline, but I'm not sure what. If everything built and all tests passed locally, you can be almost assured that things are fine on the server end. The pipeline is super vanilla; especially for PRs. The main reason it's there is for the internal MS code signing.
I've been really overloaded the past few months, but I'm planning to get back into all of the work here ASAP. Thanks for fixing my typos. ;)

Finally figured out the issues. It was a cascading set of problems related to SourceLink and code analysis. Looks like I'm back in business. Thanks.


classification GreenhouseGas

Is there a reason that GreenhouseGas is not a subclass of Gas? But its subclass FlourinatedGas is?

I think greenhouseGas should be a subClass of BFO: disposition and Gas a subClass of BFO: object. There are some gases (subclasses of gas) with has_disposition greenhouseGas.
FlourinatedGas should not be a subclass of greenhouseGas. Here again we should use the has_disposition relation to greenhouseGas.

#41

I agree with your analysis with respect to dispositions.
I am less sure w.r.t. BFO:object. This is a difficult issue.
In all ontologies the representation of mass terms is problematic, because the semantics of the underlying logic assumes a set of well-distinguished entities. However, mass terms by definition are instantiated by ‚masses‘, i.e., uncountable stuff that lack clear boundaries. E.g., you cannot count one water, two water, etc..  One way to get around the issue is to assume that the instances of a class like Water are portions of water. Portions of X may be counted, so this is a way to discretise things. (The strategy is explained on page 65 of the BFO book.)
A portion of gas has some mass, so it is clearly a material entity. However, an object needs is causally unified and maximally connected. Neither criterion is matched, so a portion of gas isn’t an object. I would classify it as object aggregate, where the parts of the aggregate are  the molecules of the gas. But I can check with Janna Hastings who worked on an ontology of chemicals. She should know.

Am 25.10.2019 um 17:23 schrieb stap-m<EMAIL_ADDRESS>I think greenhouseGas should be a subClass of BFO: disposition and Gas a subClass of BFO: object. There are some gases (subclasses of gas) with has_disposition greenhouseGas.
FlourinatedGas should not be a subclass of greenhouseGas. Here again we should use the has_disposition relation to greenhouseGas.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/OpenEnergyPlatform/ontology/issues/45?email_source=notifications&email_token=AAWE2W3KJMQAO63IW4SXYM3QQMFPDA5CNFSM4JE75GHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIWAUY#issuecomment-546398291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWE2WYTQYGRGTZWBOWAJRLQQMFPDANCNFSM4JE75GHA.

Janna recommends to distinguish between "Portion of Gas" as a subclass of object aggregate and "Gas" in the sense of a phase description which is a quality. This distinction may come handy if you encounter a liquified flourinated gas.

As all former subclasses of Gas, Liquid and Solid (except for FlourinatedGas) have another superclass (most of the time a subclass from EnergyCarrier) I decided to make the PortionOfMatter subclasses defined classes to get a nice monohierarchy. Eg. every object that "has_phase_description Gas" is automatically a subclass of PortionOfGas. I just don't know where to put FlourinatedGas in the EnergyCarrier hierarchy?


Slow-down and excessive memory and CPU usage

Wekan is slowing down after a certain amount of run time (order days to few weeks) to the point that it cannot be used at all; this issue can be temporarily resolved by restarting it. The problem seems to be caused by Node.js filling up the memory and using the CPU to full capacity.
Version 2.98~ynh1

Have you tried to upgrade to 3.45 ?

Following your suggestion, we upgraded some time ago (~1 week) - until now the problem has not resurfaced. Given that the problem usually showed itself after days to a few weeks, I'll close the issue if it has not reoccurred until the end of November. Thank you for your help (and your project of course)!

As of today the problem has not reoccurred, thanks again for your help!


How to get scan response

I found that there is a ESP_BLE_EVT_SCAN_RSP event define in esp_gap_ble_api.h, but I didn't find a sample to show how to get scan response. When ESP_GAP_SEARCH_INQ_CMPL_EVT event comes, I try to print scan_rst.ble_evt_type, but there is no ESP_BLE_EVT_SCAN_RSP event comes. Can anyone provide a sample to show how to get scan response?

HI,
you can refer to the process of ESP_GAP_BLE_SCAN_RESULT_EVT in gattc demo

Hi Nicholas3388, is this problem solved? Can we close this issue?

@FayeY  I think there is no process for ESP_BLE_EVT_SCAN_RSP in the gattc demo. Can you provide a sample to show how to handle ESP_BLE_EVT_SCAN_RSP event?

@Nicholas3388 , OK, we are going to work on it. Thanks for your interest in ESP32!

@Nicholas3388
If you want get scan response :
void esp_gap_cb(esp_gap_ble_cb_event_t event, esp_ble_gap_cb_param_t *param)
{
    switch (event) {
    case ESP_GAP_BLE_SCAN_PARAM_SET_COMPLETE_EVT:
        break;
    case ESP_GAP_BLE_SCAN_START_COMPLETE_EVT:
        break;
    case ESP_GAP_BLE_SCAN_RESULT_EVT: {
        esp_ble_gap_cb_param_t *scan_result = (esp_ble_gap_cb_param_t *) param;
        switch (scan_result->scan_rst.search_evt) {
        case ESP_GAP_SEARCH_INQ_RES_EVT:
                printf("ADV DATA:");
                for(int i = 0; i < scan_result->scan_rst.adv_data_len ;i++){
                    printf("%02x",scan_result->scan_rst.ble_adv[i]);
                }
                printf(", SCAN RSP DATA:");
                for(int i = 0; i < scan_result->scan_rst.scan_rsp_len ;i++){
                    printf("%02x",scan_result->scan_rst.ble_adv[scan_result->scan_rst.adv_data_len + i]);
                }
                printf("\n");
            break;
        case ESP_GAP_SEARCH_INQ_CMPL_EVT:
            break;
        case ESP_GAP_BLE_ADV_START_COMPLETE_EVT:
            break;
        default:
            break;
        }
        break;
    }
    default:
        break;
    }
}


Remove the advanced toolchain repo post installation

Lately have seen a lot of issues while talking to the AT repository while using both CentOS and RHEL images, as we don't need this repo post-installation, hence we need to remove this repository towards the end of the prep script.
Errors:
module.prepare.null_resource.bastion_packages[0] (remote-exec): Errors during downloading metadata for repository 'Advance_Toolchain':
module.prepare.null_resource.bastion_packages[0] (remote-exec):   - Curl error (28): Timeout was reached for ftp://public.dhe.ibm.com/software/server/POWER/Linux/toolchain/at//redhat/RHEL8/repodata/repomd.xml [Connection time-out]
module.prepare.null_resource.bastion_packages[0] (remote-exec): Error: Failed to download metadata for repo 'Advance_Toolchain': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

Error: error executing "/tmp/terraform_1200923779.sh": Process exited with status 1

[retry_terraform] Encountered below errors:
module.prepare.null_resource.bastion_packages[0] (remote-exec): Error: Failed to download metadata for repo 'Advance_Toolchain': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
Error: error executing "/tmp/terraform_1200923779.sh": Process exited with status 1
[retry_terraform] ERROR: Terraform command failed after 3 attempts! Please check the log files
/home/jenkins/workspace/daily-ocp4.5-powervs-script-tokyo-p9-min/deploy/build-harness/modules/deploy/Makefile.openshift4_pvs_script:11: recipe for target 'deploy:openshift4:powervs:script' failed
make[1]: *** [deploy:openshift4:powervs:script] Error 255
Makefile:319: recipe for target 'deploy-openshift4-powervs-script' failed
make: *** [deploy-openshift4-powervs-script] Error 2
[Pipeline] echo

/kind bug
/assign
/priority critical-urgent

/cc @yussufsh @sudeeshjohn


Does not work with specific command line arguments

Hi there!
If you use shortcuts/manager to log-in to multiple accounts it will not work.
I have narrowed it down to use of -nopatchui -email and -password (they come as a package, cant have one without the others)
As far as I can tell other arguments are not effected.
Not sure if its something ye can fix on yer end :/

I'll take a look and see if it can be solved, but I can't make promises unfortunately.

If you put a copy of the d3d9.dll file in the parent folder (same location that Gw2-64.exe), if will work: Launching the game while disabling the launcher UI makes it work from another directory.

Well that explains a lot. Thanks for the information!


Header doesn't respect MaxHeight in sub-view

When using the ScalingHeader in a view inside of a NavigationStack, the user can start to swipe up and then quickly swipe down to cause white space to show up.
https://github.com/exyte/ScalingHeaderScrollView/assets/5478660/de92ae7e-d827-48ab-b0a9-fb837280ce52

There might be a configuration property I need to change, but I don't see any documentation around it

Hey @ioslife, do you mean this white space?

@f3dm76, no, not that white space. I am talking about the white space that can be created in the status bar

@ioslife did you try headerAlignment modifier?

@ioslife did you try headerAlignment modifier?

Just tried it, no dice
When the page is on the root of the navStack, it works as expected. It also looks like I want it to when the page initially loads.
It's just when scrolling that this happens like in the video I posted.

@f3dm76 I just solved my issue. The problem occurs when the view does not have .navigationBarTitleDisplayMode(.inline) set.

I would still say this is an issue. IMO you shouldn’t have to set the navStyle

In this case, please provide full minimal compilable example and make sure the issue reproduces on this minimal example. Have a nice day


Update README.md

Clash Elite not found on Play Store

"wordpress" :D

@AmirSavand Yeah 🤣 And I didn't find it on store.. So I guess it has to be removed.


discuss and align on contribution model (3h)

goal: alignment on contribution to admiral core

proposal coming from Ross, Michael, Alice, Thomas, Lucy, Robin ready to be presented to the larger team

new issues: how to form a company specific admiral repo will be linked into the contribution model

@koegerr added this to our meeting agenda for 6th Oct - shout if you need anything earlier


⚠ Bofrost.be has degraded performance

In 53d38fb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 812 ms

Resolved: Bofrost.be performance has improved in 263a9df after 6 minutes.


fix(import): failure when multiple versions of the same CRD exist in different obejcts (#1042)

Backport
This will backport the following commits from 2.x to 1.x:

fix(import): failure when multiple versions of the same CRD exist in different obejcts (#1042)

Questions ?
Please refer to the Backport tool documentation

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1055

Questions ?
Please refer to the Backport tool documentation


Lesson preview page

Job Story
When I am creating lesson content,
I want to see it in its new state on a secure page
So that I can preview my work.
Implementation details

Pages in pupils/beta sit behind owa.thenationalacademy and so are not visible to the public
NB. this uses new MVs in DBT which will not be available until released to production
This is a consciously naive implementation. It is likely that some lessons will not render correctly due to missing data.

How to test

Go to https://deploy-preview-2699--oak-web-application.netlify.thenational.academy/pupils/beta/previews/lessons/understanding-dystopias
The lesson should be successfully rendered

Acceptance criteria

[x]  canonical page at pupils/beta/previews/lesson
[x]  shows lessons in new state
[x]  test coverage
[x]  documentation where relevant

:tada: This PR is included in version 1.520.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[FEATURE] Allow Docker Run With --userns=host

Is your feature request related to a problem or a Pull Request
Yes. Unable to run k3d cluster create when docker daemon has docker namespaces enabled.
Scope of your request
Do you need...

a new flag for a command

Allow Docker Run With --userns=host on k3d cluster create

Describe the solution you'd like
k3d runs docker with --privileged. With a docker daemon that has user namespaces enabled this will not work unless --userns=host is also passed to docker run. https://docs.docker.com/engine/security/userns-remap/#user-namespace-known-limitations
I propose to add a flag be added to k3d cluster create to allow setting userns.
Describe alternatives you've considered
The package Kind also has the same constraint. However it has addressed this issue by detecting if the docker daemon has namespaces enabled and if so it automatically adds the --userns=host flag. See https://github.com/kubernetes-sigs/kind/blob/5e58a0d40309675774a6df2b25c1947143a03c6c/pkg/cluster/internal/providers/docker/provision.go#L207-L209

Hi @kevinmstephens, thanks for opening this issue!
Actually, I never used that feature of docker, but it makes total sense.
I guess we'll add an automatic detection like kind does it, to keep the config more simple (and if there's no other way to use --privileged on userns-enabled docker systems anyway, it makes sense to do it automatically I guess) :+1:

Hi
i also enter the same issue. User namesapece is set on my dev PC without the possibility to bypass.
so to workaround the error, i rebuild k3d using a little modif in "/pkg/runtimes/docker/translate.go" file (line 128):
/* They have to run in privileged mode */
// TODO: can we replace this by a reduced set of capabilities?
hostConfig.Privileged = true
hostConfig.UsernsMode = "host"


allow removing nodes

For a project I'm working on, I need to be able to completely remove type declarations.
This change allows that (+ the ability to remove any Node) by returning nil from RewriteFunc.

Hi @OneOfOne
Thanks for all the work. I suggest you to fork this library and create your own changes. The reason I don't want to merge is that the upcoming changes in the go/ast package will have the ability to rewrite the AST easily. See the CL: https://go-review.googlesource.com/c/go/+/55790

OH I wasn't aware of that CL, thanks!


docs: storage compaction and manifest options

Storage compaction and manifest configuration.

@v0y4g3r Please take a look.


Added more event emits in SugarJournal component

Added event emits for new instance and error when loading from journal.

Nice. Thanks.


Cloud.gov Nightly job processes for Aggregation Data

The following tables are needed for aggregation & apportionment
2-MATS_UNIT_HOUR
2-UNIT_DAY
2-UNIT_HOUR
2-UNIT_MONTH
2-UNIT_QUARTER
3-MATS_MONITOR_HOUR
3-MONITOR_DAY
3-MONITOR_HOUR
3-MONITOR_MONTH
3-MONITOR_QUARTER

Needed for CAMPD after ECMPS 2.0 is out the door

Duplicate.


Translate setup/production-environment/tools/kubeadm/self-hosting/ into Korean

This is a Feature Request

What would you like to be added

Translate setup/production-environment/tools/kubeadm/self-hosting/ into Korean.
Why is this needed
There is no document of setup/production-environment/tools/kubeadm/self-hosting/ which is translated into Korean.
Comments

Page to translate:
https://kubernetes.io/docs/setup/production-environment/tools/
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/self-hosting/

/language ko
/assign

/triage accepted

/close


FreeBSD config dir variable names mismatch

Fix typo in variable names for FreeBSD config dir perms and ownership

@typo101 Thank you for your submission.   Could you update this PR with just the ca7a6d1 commit?

Merged in commit 7174e9fa5f507f9ac84068bbad34ebb4517edd15.


Update message usage for the examples in command as well as the command result for editexamcommand

Codecov Report

Merging #189 (90263e6) into master (cc2acf4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     26.45%   26.41%   -0.05%
  Complexity      351      351
============================================
  Files           160      160
  Lines          3096     3101       +5
  Branches        397      397
============================================
  Hits            819      819
- Misses         2239     2244       +5
  Partials         38       38

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...a/seedu/address/logic/commands/AddExamCommand.java
0.00% <ø> (ø)

.../seedu/address/logic/commands/EditExamCommand.java
0.00% <0.00%> (ø)

...edu/address/logic/commands/FindModulesCommand.java
0.00% <ø> (ø)

...seedu/address/logic/commands/FindTasksCommand.java
0.00% <ø> (ø)

...du/address/logic/parser/EditExamCommandParser.java
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add quick steps for adding docs to cmdlets

PR Summary
These are the quick steps for using PlatyPS to update docs for you.
PR Context
I've had to ask a couple of times so I'm documenting it so it's easy to link to contributors.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

@TravisEz13 Please update your review.