Feature request: Bulk API 2.0 Query

Is your feature request related to a problem? Please describe.

I need to query or count records in very large objects (hundreds of thousands to millions of records).
The force:data:soql:query returns a max of 50,000 records and if there's more than that then the command doesn't show me results but rather gives error:

(node:6739) Warning: The query result is missing 738431 records due to a 50000 record limit. Increase the number of records returned by setting the config value "maxQueryLimit" or the environment variable "SFDX_MAX_QUERY_LIMIT" to 738431 or greater than 50000.

Even if I increase the environment variable "SFDX_MAX_QUERY_LIMIT" to a sufficiently large value, I get the same error.

What are you trying to do

I would like to use force:data:bulk:query or similar command to conveniently use the Bulk API 2.0 Query API.

Describe the solution you'd like

A new command, force:data:bulk:query, with similar parameters as force:data:soql, to provide a convenient abstraction over the effort to set up and poll for results of a bulk query job.
The effort to create a bulk query job and poll for results, then download the results would be encapsulated in this new command.
To the end-user, usage would be no different than force:data:soql except the knowledge it's running a bulk query.

Parameters:
--apiversion      -- override the api version used for api requests made by t
--json            -- format output as json
--loglevel        -- logging level for this command invocation
--perflog         -- get API performance data
--query           -- SOQL query to execute
--resultformat    -- result format emitted to stdout; --json flag overrides t
--targetusername  -- username or alias for the target org; overrides default
--wait            -- minutes to synchronously wait for results (think force:package:install --wait)

Describe alternatives you've considered

Use another tool, like Data Loader, or write my own code using curl or jsforce library. These are not preferred because I'd like to script the bulk queries without developing something new myself, and be able to take advantage of orgs authorized with the CLI so that I don't have to fret about creating authorization headers.

Thanks

Please include an option to submit a Bulk Api 2.0 Tooling query as well - MetadataComponentDependency is kinda useless without Bulk API support.

🎉 https://github.com/salesforcecli/plugin-data/pull/328


Enable arbitrary inline expression as part of category composition.

How to efficiently implement following example with category composition.
if_safe_div_zero_2(X, Y, Fun) ->
    [option ||
        Result <- case Y == 0 of
                      true  -> fail("Cannot divide by zero");
                      false -> unit(X / Y)
                  end,
        unit(Fun(Result))
    ].

if_safe_div_zero_1(X, Y, Fun) ->
   [option ||
      cats:require(Y > 0, "Cannot divide by zero"),
      cats:unit( X / Y ),
      cats:unit(Fun(Result))
   ].

The proposal here is a function cats:require (or fail). It fails if predicate is evaluated to false with a reason provided by second arguments -spec cats:require(bool(), any()).

This is alight with EitherT design
def divide(a: Double, b: Double): Either[String, Double] =
  Either.cond(b != 0, a / b, "Cannot divide by zero")


[TASK]Verify already existing secrets encryption

Check how custom encryption mechanism (kube api server flag --encryption-provider-config) will behave with already existing secrets

This has been verified from a code and documentation perspective.
See: https://github.com/ondat/trousseau/wiki/Trousseau-with-HashiCorp-Vault#replace-existing-kubernetes-secrets-with-encrypted-ones-using-trousseau-kubernetes-admins


The Verify Middleware does not work

Laravel Version: 8.51.0
PHP Version: 7.4.9
Database Driver & Version: MySQL

Description:
I have setup a Laravel Project and installed Fortify and Sanctum as the frontend is a Vue SPA. I also have email Verification set up
everything works to this point.
but when I tried to access the following protected route without verifying the email,
Route::middleware(['auth:sanctum', 'verified'])->get('/user', function (Request $request) {
    return $request->user();
});

it works without the expected (403, 'Your email address is not verified.') error.
My User models implements MustVerifyEmail and I am not getting any errors
namespace App\Models;

use Illuminate\Contracts\Auth\MustVerifyEmail;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Notifications\Notifiable;

class User extends Authenticatable implements MustVerifyEmail
{
 ....

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


Failed to launch the browser process! Running as root without --no-sandbox is not supported

I got Error Message
Failed to launch the browser process! undefined [2864:2864:0723/132607.967276:ERROR:zygote_host_impl_linux.cc(100)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180. TROUBLESHOOTING: https://pptr.dev/troubleshooting
when export pdf
return Pdf.view('report/claim_show_pdf')
    .name(`Report_Claim_${claimData.claim_number}.pdf`)
    .format(Format.A4)
    .portrait()
    .toResponse(response)

on linux ubuntu 20
i host adonis 5 web application  using pm2 running from root user and nginx
Are there any specific configurations to make this package running puppeteer on no-sandbox ?

@firmanmimang Can you test with version 0.4.0? Sorry for the delay...

@brunolipe-a it works after upgraded to 0.4.0
@03balogun thank you bro


Use single branch for regular chef server and the one with openssl in fips mode

This PR will lets us build both versions from the same branch. We make a standalone assumption for the fips mode branch so that we can do all the localhost comms without ssl. This assumption will go away soon, but is required for now.

@jaym Anything left to do here?  This looks good to me.  Might be nice to rebase and squash some of those commits.

Awesome, I'll squash this down to a few commits

@chef/chef-server-maintainers this is ready for review.

:+1:


Update resolved dependencies to work with Node 12

Should fix failing CircleCI build for Node 12.

Passes local tests against Node 8, Node 10, and Node 12.


TypeScript compilation fails when calling create with model having Json field

Bug description
We have been using Prisma now for few weeks, and noticed that for some reason we are not able to call create/createMany with Prisma model instance with Json field, as TypeScript compilation fails.
How to reproduce
index.ts
'use strict'

import PrismaPkg, { Prisma, MyModel } from '@prisma/client';
const { PrismaClient } = PrismaPkg;
const prismaInstance = new PrismaClient();

let myJsonInstance = [
  { name: 'Bob the dog' },
  { name: 'Claudine the cat' },
] as Prisma.JsonArray

const myModelInstance: MyModel = {
  id: 1,
  my_json_field: myJsonInstance
}

prismaInstance.myModel.create({ data: myModelInstance });

Compilation error from tsc
src/index.ts:17:33 - error TS2322: Type 'MyModel' is not assignable to type '(Without<MyModelCreateInput, MyModelUncheckedCreateInput> & MyModelUncheckedCreateInput) | (Without<...> & MyModelCreateInput)'.
  Type 'MyModel' is not assignable to type 'Without<MyModelUncheckedCreateInput, MyModelCreateInput> & MyModelCreateInput'.
    Type 'MyModel' is not assignable to type 'MyModelCreateInput'.
      Types of property 'my_json_field' are incompatible.
        Type 'JsonValue' is not assignable to type 'string | number | boolean | InputJsonObject | InputJsonArray | undefined'.
          Type 'null' is not assignable to type 'string | number | boolean | InputJsonObject | InputJsonArray | undefined'.

17 prismaInstance.myModel.create({ data: myModelInstance });
                                   ~~~~

  node_modules/.prisma/client/index.d.ts:1442:5
    1442     data: XOR<MyModelCreateInput, MyModelUncheckedCreateInput>
             ~~~~
    The expected type comes from property 'data' which is declared here on type '{ select?: MyModelSelect | null | undefined; data: (Without<MyModelCreateInput, MyModelUncheckedCreateInput> & MyModelUncheckedCreateInput) | (Without<...> & MyModelCreateInput); }'

Found 1 error.

Expected behavior
No response
Prisma information
schema.prisma
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model MyModel {
  id                Int     @id
  my_json_field     Json?
}

Environment & setup

OS: Windows/WSL1
Database: PostgreSQL
Node.js version: v17.1.0

Prisma Version
prisma                  : 3.6.0
@prisma/client          : 3.6.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine dc520b92b1ebb2d28dc3161f9f82e875bd35d727 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli dc520b92b1ebb2d28dc3161f9f82e875bd35d727 (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core dc520b92b1ebb2d28dc3161f9f82e875bd35d727 (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt dc520b92b1ebb2d28dc3161f9f82e875bd35d727 (at<EMAIL_ADDRESS>Default Engines Hash    : dc520b92b1ebb2d28dc3161f9f82e875bd35d727
Studio                  : 0.440.0

@janpio Basically the issue is here: https://www.prisma.io/docs/concepts/components/prisma-client/crud#create-a-single-record-using-generated-types Why the user on that example is created with type Prisma.UserCreateInput okay. But if you already have a user of type Prisma.User shouldn't this work just fine at least in most examples. Basically we now have an issue where we have users of type Prisma.User but they can't be used to call like createMany without (user as Prisma.CreateManyInput) or (user as DeleteManyInput) also DeleteManyInput works just fine for createMany but simple ** Model User ** type doesn't work although has the same keys...

I have the same issue on my project. Did you find out a solution/workaround besides typing as any? 😞

I have the same issue on my project. Did you find out a solution/workaround besides typing as any? 😞

You can make your own type from the Prisma generated type where you override the JSON field to be "NonNullable"
type PrismaMyTypeNonNull = PrismaMyType & {   myJSONField: NonNullable<PrismaMyType['myJSONField']>; };

Excuse my ignorance, but what if the Json can be null, that is defines as Json? in the prisma schema.
Isn't the override "unsyncing" the reality?

Excuse my ignorance, but what if the Json can be null, that is defines as Json? in the prisma schema.
Isn't the override "unsyncing" the reality?

It depends what you do in TS side. It works in our case.

how to add the type?

Any chance this gets fixed any time soon ? 🙏 In my case I experience it with nullable Json fields as well.
error TS2322: Type '{ my_field: JsonValue; }' is not assignable to type '(Without<mymodelCreateInput, mymodelUncheckedCreateInput> & mymodelUncheckedCreateInput) | (Without<...> & mymodelCreateInput)'.
  Type '{ my_field: JsonValue; }' is not assignable to type 'Without<mymodelUncheckedCreateInput, mymodelCreateInput> & momodelCreateInput'.
    Type '{ my_field: JsonValue; }' is not assignable to type 'momodelCreateInput'.
      Types of property 'my_field' are incompatible.
        Type 'JsonValue' is not assignable to type 'NullableJsonNullValueInput | InputJsonValue | undefined'.
          Type 'null' is not assignable to type 'NullableJsonNullValueInput | InputJsonValue | undefined'.

The model field is of type:
 export type JsonValue = string | number | boolean | JsonObject | JsonArray | null
Related https://www.prisma.io/docs/concepts/components/prisma-client/working-with-fields/working-with-json-fields#using-null-values

/**

Matches any valid value that can be used as an input for operations like
create and update as the value of a JSON field. Unlike JsonValue, this
type allows read-only arrays and read-only object properties and disallows
null at the top level.
null cannot be used as the value of a JSON field because its meaning
would be ambiguous. Use Prisma.JsonNull to store the JSON null value or
Prisma.DbNull to clear the JSON value and set the field to the database
NULL value instead.

@see https://www.prisma.io/docs/concepts/components/prisma-client/working-with-fields/working-with-json-fields#filtering-by-null-values
*/
export type InputJsonValue = string | number | boolean | InputJsonObject | InputJsonArray

Seems this is due to JSON null being ambiguous and there being 3 enums for NULL....
Null in the context of create/update should be indeed ´Prisma.DbNull,to make updates/creates and typescript to work with a model where the JSON field is optional. If you really wanted a "null" to go in the JSON then that should be opt-in behavior by Prisma.JsonNull,`.
Anyway there's definitely a bug on having that null up there - why your "JsonValue" can have NULL but it doesn't store a DB NULL or JSON NULL but it's prohibited...?

Same with if using Json[] on schema, I'm getting Type 'JsonArray' is not assignable to type 'WidgetCreatefallbackDataInput | InputJsonValue[] | undefined'.


run_fastqe for jupyter notebooks

Implementing one of the suggestions of Issue #14 ... so this function can be used in jupyter notebooks

Great solution!


Adding AWS account id and GCP project number and name

Athenz domains contain cloud provider account data. adding gcp and was account data to the data source all_domain_details.

Please make sure to update the doc file as well docs/data-sources/athenz_all_domain_details.md

updated doc, and added azure subscription to the exported attribute.


Thread safety

Hi, this is a nice and clean code, however, I couldnt make it work in multithreaded environnement, also how should we do to make directly available just like fts5

I faced the same problem. Some investigations led to the following.
This extension has global snowball stemmers cache as struct StemmerListItem *availableStemmers.
It is not thread safe, because:

stemmer object is not thread safe - libstemmer.h says, that next call to sb_stemmer_stem invalidates previous token info (and so sb_stemmer_length). So we have race condition when many threads work with the same stemmer.
destroySnowball handler called on db connection close is not thread save too. Under heavy load we can get two connections in destroySnowball handler, so we will free cache twice.

This problem can be fixed so:

use locks:

lock stemmer untill all necessarry data copied somewhere.
lock when destroy cache
:heavy_plus_sign: Single stemmers cache - save ram (single cache) and cpu (one stemmer instance creation per language)
:heavy_minus_sign: working with stemmers is bottleneck due to locks.
:information_source: we can try use portable sqlite mutexes

make cache thread_local

:heavy_minus_sign: more ram and cpu consumed, because each thread have own stemmer instance
:heavy_plus_sign: no bottleneck with locks
:heavy_plus_sign: simple to implement - just write something like __thread
:information_source: thread_local supported by compilers - we can try this macros

remove cache at all:

:heavy_minus_sign: slightly difficult to implement - many code depends on availableStemmers indexes.
heavy_minus_sign: cpu and ram consumption
:heavy_plus_sign: simple - nothing to be broken...

Now I try use thread_local. It immediately helps with race condition on stemmers, but not helps with destroySnowball - we still have race condition between two db connections in one thread:

conn1 closes and disposes cache availableStemmers=NULL
conn2 calls fts5SnowballCb and fails when try do availableStemmers[...], because it is NULL.
It can be fixed by something like ref_counter - how many connections in the same thread use this cache. This idea is applicable for locks-solution too - why destroy global cache if it needed for other connections?

If I am successful, I will send a PR later.

"Race condition" in one thread with destroySnowball may occur implicitly in web api app if:

you have gc language (python)
every request processed in own thread (fastapi def routes)
thread got from thread pool
you forgot eplicitly close db connection in python code

I discovered this scenario under load:

thread1 processes request1 - opens conn1 to db
request finished, but no explicit conn1.close()
thread1 is free in thread pool
other request2 get thread1 and processes request - opens another conn2
python gc wakes up and closes conn1 - so call destroySnowball, so availableStemmers=NULL
request2 tries to continue work with conn2, but it has broken availableStemmers! seg fault in fts5SnowballCb on line
stemmed = (sb_symbol *) sb_stemmer_stem(availableStemmers[*stemmers].stemmer, (unsigned char*) aBuf, originalNBuf);.

Maybe I made a mistake and something else is happening, but this hypothesis is supported by the following techniques:

disable destroySnowball code - all works!
in fts5SnowballCb  check availableStemmers=NULL and printf("NULL!"). It becomes last message before segfault.

Ref count idea + thread local stemmers cache have a problem: it will not work as expected in python if:

multithread app, each thread opens db connection, loads this ext, do some work, return thread to thread pool.
no explicit db close again...
so GC goes to close db connections. But it works at one thread, no the same as where db connection were created!

@and-se, thanks for your detailed analysis. I'm away from my pc this weekend, but I will try to take a look at it next week. You mentioned pytho: do you have a python minimum working example?

Hello! The original test uses JMeter and a big python application (which uses fastapi), but it seems I managed to make a toy script that crashes in about the same way
import sqlite3
from threading import get_ident as thread_id
from concurrent.futures import ThreadPoolExecutor
import random

def connect():
    c = sqlite3.connect('testdb.sqlite3')
    c.enable_load_extension(True)
    c.load_extension("./fts5stemmer")
    return c

c = connect()
c.executescript("""
create virtual table if not exists Test using fts5(text, tokenize='snowball');
insert into Test values ("cats dogs"), ("cats dogs"), ("horse dogs")
""")  # I remember MIN_TOKEN_LENGTH = 3

sh = 10000  # cut ids

class ConnWrap:
    def __init__(self, conn):
        self.conn = conn
        self.thread = thread_id()
        self.cycle = self  # cyclic reference to avoid gc remove object immediately

    def execute(self, sql, params):
        return self.conn.execute(sql, params)

    def executescript(self, sql):
        return self.conn.executescript(sql)

    def __del__(self):
        if thread_id() != self.thread:
            # in thread_local cache  we need to delete the connection in the same thread where it was created - else memory leak
            print(f"!!! thread={thread_id()%sh} GC delete conn {id(self)%sh} - expected in thread={self.thread%sh}!")

def do_select(conn):
    conn.execute("select * from Test where Test = ?",
        (random.choice("cats dogs horse".split()),)).fetchall()

def tester(job, test_inner=True):
    """
    test_inner=True - test seg fault when two connections in one thread
    modify to test_inner=False to catch another seg fault
    """
    c = ConnWrap(connect())
    title=f"thread={thread_id()%sh} job={job%sh} conn={id(c)%sh}"
    print(title, "started")
    do_select(c)

    if test_inner:
        # seg fault two connections in one thread
        print(title, "inner conn start")
        c2 = connect()
        do_select(c2)
        c2.close()
        print(title, "inner conn end")

    do_select(c)
    # c.close() # no explicit db close - allow gc do work (in wrong thread!)
    print(title, "done")

# play around with this parameters
# my python 3.7.5 always fails with test_inner=True
# if test_inner=False, often fails with (20, 100)
with ThreadPoolExecutor(2) as executor:
    executor.map(tester, range(10))

# modify fts5stemmer.c lines 21-22:
# __thread struct StemmerListItem *availableStemmers;
# __thread int numberAvailableStemmers = 0;
#
# when test_inner=False segfault stops, but GC delete problems remain.
# when test_inner=True segfault continues.

print("All OK. May be...")

I have solution - see PR #9. It works until we have a separate connection for each thread (i believe this is usually the case).
It's tested with my real app under JMeter under heavy load - no seg faults.
It works with python script above. Warnings about deleting a connection from another thread are still issued, but this is not a problem for this solution.

@and-se, I have a different proposal that seems to work (at least with your python script). Please see PR #10. I like it because it simplifies the code a lot (please see commit 553fef2b21227cc5b746804b59c53512c6056538). Would you be so kind to test it in your application and confirm it works? If you have any comments, please let me know

Thank you! This is a really nice solution.
I have tested in in my app - works fine.
There is no cache in your solution, but I could not detect a noticeable performance drop compared to my solution.
If I have any problems, I'll let you know, but now you can merge it.

Thanks for the confirmation. Merged #11, so I'm closing this issue


Instagram Bridge failed with error 0

Second day when i get following error when trying to fetch data from instagram
in config.ini.php i have only configured session_id and cache_timeout set to 18h.
Running it on my private, and local instance with podman/docker
Error message: `Maximum (5) redirects followed (47)`
Query string: `action=display&bridge=Instagram&context=Username&u=tokariew&media_type=all&format=Html`
Version: `git.master.2c7a9d7`

It seems that removing session_id help to receive data… but then i can't follow private accounts.

Thanks for opening this because I'm experiencing the same behavior, but I assumed that Instagram blocked me and I didn't dig into it any further.  I am also seeing this on the console:
NOTICE: PHP message: HttpException: Maximum (5) redirects followed (47) in /app/lib/contents.php:206
Stack trace:
#0 /app/lib/contents.php(87): _http_request()
#1 /app/bridges/InstagramBridge.php(296): getContents()
#2 /app/bridges/InstagramBridge.php(91): InstagramBridge->getInstagramJSON()
#3 /app/actions/DisplayAction.php(137): InstagramBridge->collectData()
#4 /app/index.php(22): DisplayAction->execute()
#5 {main}

According to the console logs it started for me on June 29 at 20:17 GMT.
I confirmed that mine also works if I remove the session_id which means Instagram changed something with regard to cookies and presumably the RSS-Bridge redirect error is being caused by Instagram redirecting to its login page.
I went through some trial and error and discovered that things seem to work if I supply the ds_user_id cookie in addition to the sessionid cookie.  None of the other cookies present in a browser session seem to be required.
I'm not a coder/programmer, but since this seems like a minor change to add an additional cookie value I'll give things a try and see if I can get a pull request together to fix it.

I can't seem to fix this so if someone else wants to pick it up, feel free.
Tagging @em92 in the hope that it's a simple fix for him since he added the sessionid support.
Instagram now seems to be requiring the ds_user_id cookie in addition to the sessionid cookie.  I'm using a older custom hacked together version of InstagramBridge.php and I can get it working with the following changes:
const DSUSERID = '[removed]';
const SESSIONID = '[removed]';

// Within getInstagramJSON
$header = array('Cookie: ds_user_id=' . self::DSUSERID . '; sessionid=' . self::SESSIONID);
$data = getContents(self::URI .
                                'graphql/query/?query_hash=' .
                                self::USER_QUERY_HASH .
                                '&variables={"id"%3A"' .
                                $userId .
                                '"%2C"first"%3A10}',$header);

But I'm not successful in making similar changes to the getContents function in the current version.  Not sure what I'm doing wrong.

At the moment I don't have working instagram account at the moment in order to check solution and make PR.
Also I cannot register, for some reason SMS messages from Instagram are not received. That is required to confirm Instagram Account.

Made PR to fix issue, thanks @JimDog546 for pointing direction, how to fix it.

Thank you Tokariew, I have applied your patch fix and started working like a charm.


Allow triage when records in consent_refused state

When consent is refused nurses will still do triage and could transition to other states.
I think this is the fix, if so I will add tests.

This can partly fix the issue, but exposes other issues. Better to roll together a bigger fix for the triage & consent response flows I think.


Typos in test method name expect in enumerables/exercises_1/spec/reject_pattern_spec.rb

There are typos in the test method name expect in enumerables/exercises_1/spec/reject_pattern_spec.rb on multiple lines.
Lines 32, 38, 62, and 86 all show expected but should instead show as expect.

The same issue also exists in iteration/exercises/spec/group_by_pattern_spec.rb on line 20 - expected should be expect instead.


Package.activateConfig is deprecated.

Use a config schema instead. See the configuration section
of https://atom.io/docs/latest/hacking-atom-package-word-count and
https://atom.io/docs/api/latest/Config for more details
Package.activateConfig (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:265:11)
PackageManager.packageHasSettings (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:42:14)
PackageCard.hasSettings (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:612:34)
PackageCard.initialize (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:205:17)
PackageCard.View (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:184:25)
new PackageCard (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-card.js:22:48)

ping @Flynsarmy

I don't use Atom Editor anymore. I'm also fairly sure I took my plugins off the marketplace. Feel free to fork, fix and publish, though I'm sure there are plenty of alternatives to this plugin that do the same thing.

ok


pyvsc-run-isolated.py pip install -U pylint --user terminating with error

Using visual studio 'popUp' hint option, it is not possible to install some Extensions, like pylint or rope.
Starting with:
~/.vscode/extensions/ms-python.python-2021.1.502429796/pythonFiles/pyvsc-run-isolated.py pip install -U pylint --user
Final log lines are:
File "/usr/share/python-wheels/setuptools-39.0.1-py2.py3-none-any.whl/setuptools/py33compat.py", line 54, in  unescape = getattr(html, 'unescape', html_parser.HTMLParser().unescape)
AttributeError: 'HTMLParser' object has no attribute 'unescape'
Using pip install -U pylint --user from bash works well, terminating with success:
Successfully installed astroid-2.4.2 lazy-object-proxy-1.4.3 pylint-2.6.0 typed-ast-1.4.2 wrapt-1.12.1
========================================================
Solved:
VS run  Python 3.9.x; after switching to 3.8.3 context, install and functionality is OK.

Duplicate of #14327


Quest Support

v0.2.0 has no official support for Quest. This is because it was superfluous to the priority of making a smaller, easier-to-edit prefab.
Quest support is required for v1.0.0, as the table needs to have close to feature parity with the original prefab.
The priority here is simplicity. Personally, when doing cross-compatible work "Quest-first" is the correct route. So for 1.0.0, the code needs to fully work assuming Quest-level hardware is the default. (That means that we switch off PC-only features, or allow those features to work on Quest too).

Just a heads up that I had a Quest user test the pool table (v0.3.0 at the time) in my theater world and it worked fine. Only issue was an occasional flash which was from the reflection probe afaict. Just disconnect that from the main pool script inspector and add an extra null check for the probe variable on line PoolStateManager:2040-ish, then it seemed to work fine.
Here's a video clip for posterity/proof:
https://cdn.discordapp.com/attachments/836760608044613682/844107937177665576/Pooltable_Quest.mp4

Thanks Tech. 1.0.0-pre2 will automatically remove any reflection probe when booted on Quest/2.


Matching assembly references

I have a new project .NET Core Web API project which at first seemed to work fine with no errors. But today when I looked at the Startup.cs class I noticed a bunch of green lines telling me the following:
Assuming assembly reference 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' used by 'Microsoft.Extensions.Configuration.FileExtensions' matches identity 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' of 'System.Runtime', you may need to supply runtime policy

I have a few more of those, similar, messages in Startup.cs.

I haven't really changed anything in the Web API project. I just added a few .NET Core class libraries to the solution.
Why is the Web API project giving me these 'errors'?
PS. Clean and rebuild didn't work

Errors are gone... No idea why, but issue seems to be resolved.


Additional information in the log output when an InvalidCipherException occurs.

When a client application is starting with a mismatch symmetric key (between client and server), the output log prints before InvalidCipherException is thrown due to un-decryptable configuration properties, which creates additional information with log message because the message alone lacks information to guess why the InvalidCipherException occurred.
Relates to #1386

@ryanjbaxter I fixed the message.


Type of object value unexpectedly become never, won't happen when assign to variable first

TypeScript Version:  4.0.0-dev.20200615, 3.9.2

Search Terms: never, type never, type never if, type become never, type never variable
Expected behavior: description[key] shouldn't be never at description[key] = value
Actual behavior: description[key] is never at description[key] = value. But if I assign description[key] to a variable first then do assignedVariable = value, it becomes fine.

Related Issues: Couldn't find it.
Code
const description = {
  key: "",
  keyCode: 0,
  code: "",
  text: "",
  location: 0,
}

interface KeyDefinition {
  keyCode?: number
  shiftKeyCode?: number
  key?: string
  shiftKey?: string
  code?: string
  text?: string
  shiftText?: string
  location?: number
}

const definition: KeyDefinition = {}

const descriptionKeys = Object.keys(description) as Array<keyof typeof description>
descriptionKeys.forEach((key) => {
  const value = definition[key]
  // This doesn't work
  if (value) {
    description[key] = value
  }
  // But this works
  let a = description[key]
  if (value) {
    a = value
  }
})

Output
"use strict";
const description = {
    key: "",
    keyCode: 0,
    code: "",
    text: "",
    location: 0,
};
const definition = {};
const descriptionKeys = Object.keys(description);
descriptionKeys.forEach((key) => {
    const value = definition[key];
    // This doesn't work
    if (value) {
        description[key] = value;
    }
    // But this works
    let a = description[key];
    if (value) {
        a = value;
    }
});

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "alwaysStrict": true,
    "esModuleInterop": true,
    "declaration": true,
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "moduleResolution": 2,
    "target": "ES2017",
    "jsx": "React",
    "module": "ESNext"
  }
}

Playground Link: Provided

This is the intended behavior. You could corrupt description with a write like description[key] = value, but a will not be corrupted by this operation because its type is the general type string | number.

You could corrupt description with a write like description[key] = value

This is not explained. I run into these kind of typing issues a lot. This is very limiting. It makes it impossible to build an object key by key for instance (without resorting to type workarounds like 'any').


Hawkular-1101 Backfiller does not honor DOWN availability

Start listening for new FeedWebSocketClosedEvent messages on
HawkularCommandTopic and when detected force an avail backfill
for the down feed.
Also:

convert some hardcoded literals to constants
run the backfill job more often, default from 30s to 15s

@jmazzitelli Please review but don't merge, it depends on commons snapshot, so that PR will need to be merged first.  Also, waiting for @pilhuhn to add any comments on the Jira.

LGTM


Remove Natural Language v1beta2

This PR removes V1beta2 from Natural Language.

@landrito Should we keep this PR open (but on hold) for a while?

We can just close this!


Go to Definition is not considering the GOHOSTOS' when the function is defined for multiple GOHOSTOS'

From @Zignd on April 15, 2017 18:42
I was using Windows, I tried to Go to Definition on a call to the rename function (internal function in the os package), and the function definition for Plan 9 opened in my editor.
The rename function has definitions in GOROOT/src/os/file_plan9.go, GOROOT/src/os/file_unix.go, and in GOROOT/src/os/file_windows.go.
I was expecting the extension to open the definition from the GOROOT/src/os/file_windows.go file.
Copied from original issue: Microsoft/vscode-go#927

I am on a Mac, and for me the definition in GOROOT/src/os/file.go opens.
@rakyll What is the expectation here?

From @Zignd on April 16, 2017 15:12
@ramya-rao-a It works when I set "go.docsTool": "gogetdoc". It seems to be an issue with godef as you said. Should I open an issue there?

From @Zignd on April 15, 2017 23:6
Oh, it's not the os.Rename function, it's the os.rename function. os.rename is called from within os.Rename to perform the rename according to a specific operating system. I just tried it on Linux and the same occurs, GOROOT/src/os/file_plan9.go opens.
// Rename renames (moves) oldpath to newpath.
// If newpath already exists and is not a directory, Rename replaces it.
// OS-specific restrictions may apply when oldpath and newpath are in different directories.
// If there is an error, it will be of type *LinkError.
func Rename(oldpath, newpath string) error {
	return rename(oldpath, newpath)
}

Here's a snippet containing the os.Rename definition, as you can see it is calling os.rename.

@Zignd Ah, got it.
I tried on my Mac again, and the definition in file_unix.go opened for me.
But on Windows, I can repro what you are seeing i.e file_plan9.go opens.
If I update my settings to use the gogetdoc tool instead (set "go.docsTool": "gogetdoc"), then I get navigated to the right file.
Can you try using gogetdoc and see if that helps?
If it does, then this issue should be moved to the repo for godef


Fix cross section parsing behavior in read.from_yaml

Hi @joamatab
This recent change to the from_yaml() function is problematic. It is not safe to always assume a dictionary parameter has a key called function in it, and I would argue that you should not even assume it is a cross section spec if it does have the key function. This is unclear, unpredictable, and risky behavior.
I would suggest changing the spec of a cross-section dictionary to look instead like this
cross_section: the name of the cross section (replaces the function key)
settings: settings for the cross section
This would bring it closer to a component spec, and would also have a very clear signature. Otherwise I think it will be risky and buggy to have behavior like this embedded in this function...
Anyways, this MR doesn't go that far, but it proceeds a bit more cautiously when trying to convert potential cross-section-type parameters into cross sections.

awesome, thank you Troy


Trying to anchor a plant fails because the tool is hidden in the plant instead

Description
There are many potted plants around most of the stations. Should you want to anchor one, you would typically use a wrench. Trying to do so starts the action, but stops in the middle because the wrench gets hidden into the potted plant.
Given two actions are being done at the same time, I'd suggest linking one of them to an auxiliary action (ALT + Click).
Reproduction

Find potted plant
Try to anchor it
Smile at the progress bar being shown, anchor time is nigh
Loudly sob at your wrench being hidden in the potted planted instead

Screenshots
https://github.com/user-attachments/assets/b80fc6c5-569e-4e9a-bc74-a8c8524f4239
Additional context
Clearly not an issue that prevents playing, but I found that the other day.

I feel like this is a dupe

As a workaround put something else in the plant first, then anchor.

I feel like this is a dupe

Well...about that... it's definetly related to https://github.com/space-wizards/space-station-14/issues/31455

the same problem with toilet's secret stash


SSL_client_hello_get0_ext() wrong documention

version :1.1.1 and above
hey in the open ssl documention
https://www.openssl.org/docs/man1.1.1/man3/SSL_client_hello_get0_ext.html
it says that
SSL_client_hello_get1_extensions_present() can be used prior to SSL_client_hello_get0_ext(), to determine which extensions are present in the ClientHello before querying for them. The out and outlen parameters are both required, and on success the caller must release the storage allocated for *out using OPENSSL_free(). The contents of *out is an array of integers holding the numerical value of the TLS extension types in the order they appear in the ClientHello. *outlen contains the number of elements in the array. In situations when the ClientHello has no extensions, the function will return success with *out set to NULL and *outlen set to 0.
in the documnetion it says that on sucess of SSL_client_hello_get0_ext
the caller need to release out with OPENSSL_FREE. but it doesnt look like it allocated there, so i think its wrong to call OPENSSL_free.
am i  right?
cus all what SSL_client_hello_get0_ext does is to loop on an array of extensions and then return a pointer if found the
requested extension. its not allocated it or copy it.
https://github.com/openssl/openssl/blob/OpenSSL_1_1_1-stable/ssl/ssl_lib.c#L5222

IMO the documentation is fairly clear in the sense that  the caller must release the storage allocated for *out using OPENSSL_free(). The out in that sentence is an output parameter of the SSL_client_hello_get1_extensions_present() function as that sentence is in the paragraph for the SSL_client_hello_get1_extensions_present() and not SSL_client_hello_get0_ext().

Closing since this is marked as resolved.


WeightNormalization test are failing without symbolic tensors in build

Since https://github.com/tensorflow/tensorflow/commit/9df99aafc3480638cd8d2bf6a0caeab111b68302 our keras_layer test is failing on weightnorm.
This is the block that fails from the test util:
 # test serialization, weight setting at model level
  model_config = model.get_config()
  recovered_model = keras.models.Sequential.from_config(model_config)
  if model.weights:
    weights = model.get_weights()
    recovered_model.set_weights(weights)
    output = recovered_model.predict(input_data)
    np.testing.assert_allclose(output, actual_output, rtol=2e-3

So our model config isn't properly serializing the data.
@omalleyt12 could you take a look and provide some insight. I'm not overly familiar with ops.init_scope and the check for _keras_style
Here is our weight norm layer:
https://github.com/tensorflow/addons/blob/master/tensorflow_addons/layers/wrappers.py#L24

I submitted a PR which sets keras_style to false and then tests pass. From my understanding of keras_style though I don't think this is the correct thing to do? We are not utilizing any legacy tf.layers or tf.rnn

Thanks for the issue! Could you provide a minimal repro?


KFP pipeline for doc quality module

Search before asking

[X] I searched the issues and found no similar issues.

Component
KFP workflows
Feature
Of course, this will be done after the move for this module from the inner to outer repo has been completed.
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Where can we find the implementation code of the transform? Is it still not merged yet?

Right, @Mohammad-nassar10.  It is not merged yet. It is in the inner repo, but after the current immediate priorities, it will be copied to the open source repo.

If we are talking about this transformer, it is implemented and tested on KFPv1 and OpenShift AI (KFPv2).

No, @roytman. We are talking about the doc quality transform and not the code quality transform. The former has not been merged yet and there is a PR against it. (https://github.com/IBM/data-prep-kit/pull/282)) It is going through some changes right now and once it is merged (not in this release), creating a pipeline for it becomes a priority.


bug: generate text feature not working properly

The AI service was down for a while. It's now working.

Ohh thanks, @fuma-nama  now it working.


Bump all to latest and add netstandard16 support

I have added everything I could see so feel free to remove/check unrelated ones.
Also, make sure to update the .MsBuild stuff as well. [x] means either up-to-date or there is pr in line.
Packages

[x]  Serialization.JsonNet
[ ]  Serialization.ServiceStack
[ ]  Serialization.ProtBuf
[ ]  Bootstrappers.Unity
[x]  Bootstrappers.Autofac
[ ]  Bootstrappers.Ninject
[ ]  Bootstrappers.Windsor
[x]  Bootstrappers.StructureMap

Subrepos

[x] Nancy.Authentication.Basic
[x] Nancy.Authentication.Forms
[x] Nancy.Authentication.Stateless
[x] Nancy.Embedded
[ ] Nancy.Encryption.MachineKey
[ ] Nancy.Hosting.Aspnet
[ ] Nancy.Hosting.Self
[x] Nancy.Metadata.Modules
[ ] Nancy.Owin
[ ] Nancy.Validation.DataAnnotations
[ ] Nancy.Validation.FluentValidation (supports but dnxcore50 should be changed)
[x] Nancy.ViewEngines.DotLiquid
[ ] Nancy.ViewEngines.Markdown
[ ] Nancy.ViewEngines.Nustache
[ ] Nancy.ViewEngines.Razor.BuildProviders
Nancy.ViewEngines.Razor
[ ] Nancy.ViewEngines.Spark

Just a stupid question - netstandard16 meaning netstandard1.6, right?

@perlun Yes

The sub repos are all done by default so you can remove those

I think Nancy.Hosting.Self can be removed. It will be replaced by Kestrel host.

@cemremengu can you please elaborate on this PR a bit more? What does "bump all to latest" mean? All what?
And do we have projects that target netstandard, just not 1.6?
Please maintain this list and link the PRs for each project

Here's a sample of an Epic https://github.com/NancyFx/Nancy/issues/2000

The categories "packages" and "subrepos" confuses me a bit. They're all packages

Me again 😄
I need this issue to

clearly describe the purpose and scope
link to pull-requests that are sent in order to help close this
descriptive information why some aren't needed: like (already updated), (dependency does not support netstandard yet) and so on
have a clear description of how 3rd party dependencies will be bumped. Are we staying withing the minor or are we also considering bumping the major?

Bootstrappers.Ninject needs to be marked as rejected since it depends on Ninject.Extensions.ChildKernel which is not supported on core


Mini-map icon

With the "Show mini map icon" unchecked, it still shows up every time I log.

This is a duplicate of #568 and was fixed in 2.4.12.  You need to update to 2.4.13 which is the currently available version on Curse


CollectionEvent typescript constructor declaration omits arguments

This is the declaration of the constructor in @types/ol 6.3.1 (there isn't a 6.4.3??)
export class CollectionEvent<T> extends BaseEvent {
    constructor();
    element: T;
    index: number;
}

This is the declaration of the event in ol 6.3.4
**
 * @classdesc
 * Events emitted by {@link module:ol/Collection~Collection} instances are instances of this
 * type.
 */
var CollectionEvent = /** @class */ (function (_super) {
    __extends(CollectionEvent, _super);
    /**
     * @param {import("./CollectionEventType.js").default} type Type.
     * @param {*=} opt_element Element.
     * @param {number=} opt_index The index of the added or removed element.
     */
    function CollectionEvent(type, opt_element, opt_index) {

You may notice the types definition is missing the arguments for the constructor.
To Reproduce
Attempt to construct an Collection Event from a typescript file (my use case happens to be simulating adds to ensure that all existing collection content is updated per my ADD listener) - constructor typing errors ensue
Expected behavior
Type definition matches implementation, so I can create one
Workaround
new CollectionEvent(CollectionEventType.ADD, element, index) // desired
Object.assign(new BaseEvent(CollectionEventType.ADD), { element, index }) as CollectionEvent<BaseLayer> // workaround

The type definitions are using are maintained by a third party. I think reporting this issue at https://github.com/hanreev/types-ol or https://github.com/DefinitelyTyped/DefinitelyTyped would be more appropriate.


GH-XXX: [C++] Add WithinUlp testing functions

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Initially mentioned in https://github.com/apache/arrow/issues/12681#issuecomment-2490531049

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g cpp


latte-dock: build with libsForQt514

Motivation for this change
Fixes #101756
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 101857 run on x86_64-linux 1

1 package built:

latte-dock

Result of nixpkgs-review pr 101857 run on x86_64-darwin 1

1 package marked as broken and skipped:

latte-dock

@ofborg eval

This seems to have been fixed.


Revision and edit of Compose install doc

Needs signing off! :)

Minor typo and needs signoff; otherwise, LGTM.

@aanand @bfirsh Okay, should be good to go now. Not sure who merges... guess we should figure that out!

@fredlf We follow the Docker process, roughly. Two LGTMs from a maintainer.
Perhaps we should have additional process for docs?

Well, the docs process currently is two maintainers, or just one if the PR originates from a docs maintainer. So.... for now:  ping @jamtur01 @SvenDowideit
Two of us plus one technical (code) maintainer should be adequate, eh?

LGTM

Thanks, @jamtur01
@bfirsh You okay with me merging then?

Okay. Let's count you as a maintainer for docs on here, so that'll just require another set of eyes from a Fig maintainer.
Also: LGTM. Thanks. :)


Ballerina staging central shows incorrect latest version for modules

Description:
The version shown as the latest version in modules and module templates is not the latest version (the oldest version is shown).
https://staging-central.ballerina.io/irushi/module0
Related Issues:
https://github.com/ballerina-platform/ballerina-lang/issues/18174

Fixed with 1.0 release


Cant set custom change events on input element

I have an application in place that tracks changes to a form with the change or focusout events on all input elements.
But upon including this Datetetimepicker all custom $(':input').on('change' events were broken.
Now I know that there is a dp.change event, but I cant possibly add that as an additional event to all my listeners.
I tracked this down the following lines:
e.stopImmediatePropagation();
return false;

When I comment them out everything works as expected!
JSFiddle

I second this issue. It's causing parts of my program to now fail.

I am handling this situation in my application by doing the following:
$('.datetime-picker')
.datetimepicker()
.on('dp.hide',function (e) {
$(e.target).trigger('change');
});
So when the user has made a final selection of a date, when the calendar ui component is hidden, the onchange event will fire as usual.

+1
Thank you jrochelle for the work around, but it would be preferable for the events to propogate (even if it is just a config option)

The fix by @jrochelle doesn't seem to work for me... I've tried with the j


Added some extra options to the config

Forwarded ports and shell_always provisioners (eg. sync time after boot)

Forget to add the the ruby function to actual configuration. Do not merge


IOError: No such file or directory: 'info.txt'

Traceback (most recent call last):
File "/usr/local/bin/lazygit", line 9, in
load_entry_point('lazygit==0.7', 'console_scripts', 'lazygit')()
File "/usr/local/lib/python2.7/dist-packages/lazygit/main.py", line 47, in main
with open(file_name) as f:
IOError: [Errno 2] No such file or directory: 'info.txt'

Try uninstalling lazygit package and installing again. Or try upgrading the package. I released a newer version last night. Hopefully, this should solve the problem.

I installed the package for the first time a couple of hours ago only. Though I will give that a try.

It says that's already the recent most version. @mayank26saxena

I've just upgraded the package on PyPi. Added a new feature of pushing to a branch. This should be a more stable version than the previous one.
Can you try again? Sorry for the inconvenience.

I have not been able to replicate the above error on my system and hence have not been able to identify what went wrong.
The newer version of lazygit (version 1.1) should work fine hopefully.


Change type of version in suricata.quic to string

See https://docs.suricata.io/en/latest/rules/quic-keywords.html#quic-version.

Thanks for the fix! :bow:


add 3 day count down timer to claim proceeds notification

Mocks are in figma. When market is finalized and user has winning shares, show notification with count down timer from 3 days of market finalization.
The view button in the top mock needs to be greyed out.
When 3 day timer is out activate the notification like it's new and the view button is active.

I am not sure we need the "View" button on the one with the countdown clock.  Clicking it wont do anything ...i cant take the action of claiming until that clock expires

It can be disabled or removed. Def not active.
I think the mocks have a button. Create an issue we can remove it.

The VIEW button for this card will appear disabled and unclickable in the UI.

Im closing this ticket and making a new one to remove the view button when claim proceeds is in countdown


Allow icon links from a URL and from _static

Currently the icon link can be a fontawesome icon or an image whose path must be declared relatively to the root. It'd be nice to have a few more options, including a URL and being able to tap into _static folder.

I think #616 covers this one, @maximlt.
I will close it now... but feel free to disagree and I will reopen it.


UI hangs when rendering mermaid diagrams

Bug Report
Installation Method
Docker
Environment

Open WebUI Version: v0.3.12
Browser (if applicable): Chrome 127

Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[x] I have included the browser console logs.
[x] I have included the Docker container logs.
[x] I have provided the exact steps to reproduce the bug in the "Steps to Reproduce" section below.

Expected Behavior:
A prompt that generates mermaid syntax should be displayed as a mermaid diagram.
Actual Behavior:
The UI hangs indefinitely midway through streaming the response, as soon as it tries to render the diagram. Refreshing the page resolves the problem.
Description
Bug Summary:
Rendering mermaid diagrams in streaming chat responses seems to have been broken between 0.3.11 and 0.3.12.
Reproduction Details
Steps to Reproduce:

Enter the following prompt, using gpt-4o: "create a mermaid sequence diagram of the TLS handshake"
The chat response will stop streaming as soon as it attempts to output the diagram, and it will indefinitely hang until the page is refreshed.
Refresh the page, and you will see the full response including the diagram.

Logs and Screenshots
Screenshots/Screen Recordings (if applicable):
On 0.3.12:

On 0.3.11:

Additional Information
I can consistently reproduce this bug on 0.3.12, but not on 0.3.11.

Should be fixed on dev, let me know if the issue persists!

0.3.13 seems to have fixed it!

@tjbck Can you reopen this? The specific case I mentioned initially is fixed, but I can still reproduce it when asking for Pie charts.
Screen recording:
https://github.com/user-attachments/assets/462cc646-2c9f-4b1f-ae98-acb4561b594c

Opened #4731


Jacoco Problem with Gradle Transform Task #105

Expected Behavior
The jacoco Instrumentation code should exist in final classes.jar after using ScopedArtifacts.Scope.ALL to transform the code
Current Behavior
The jacoco Instrumentation code didn't exist in final classes.jar after using ScopedArtifacts.Scope.ALL to transform the code
Context (optional)
No response
Steps to Reproduce
Hi, I use jacoco and ScopedArtifacts.Scope.ALL to do some transform work in my project.
The gradle tool version is 8.0
My project structure is as follows:
app
module a
module b
app includes module a and module b
in app I use ScopedArtifacts.Scope.ALL to write a gradle plugin
there is the code :

and I use jacoco in module A and module B too
there is the jacoco code:

now there comes the problem the jacoco task is execute before transform task
After the jacoco task is finished, the transform task will get the input dir and input jar( module A class.jar module B class.jar)
but when I print the path of input jar , I found that the input jar is still the original jar file without jacoco Instrumentation code.
example:
after jacoco task
the input jar   @get:InputFiles abstract val allJars: ListProperty
class path in the plugin is
Module A/build/intermediates/runtime_library_class_jar/class.jar(without jacoco Instrumentation code)
Module B /build/intermediates/runtime_library_class_jar/class.jar(without jacoco Instrumentation code)
That means jacoco didn't work in my project due to the using of transform task by code mentioned above, because the transform task still use the original class jar ( module A class.jar without jacoco Instrumentation code and module B class.jar without jacoco Instrumentation code) to general the final class.jar that will finally saved in app/build/intermediates/classes/all/class.jar.
So how can I do to get the right class.jar of module A and module B that include jacoco Instrumentation code
and in gradle 7.0
I found that
Module A/build/intermediates/runtime_library_class_jar/class.jar
Module B /build/intermediates/runtime_library_class_jar/class.jar
include the jacoco Instrumentation code
but in gradle 8.0 it's not
Gradle version
8.0.0
Build scan URL (optional)
No response
Your Environment (optional)
No response

Sorry that you're having trouble with Gradle!
Your issue appears to be a question about how to use Gradle. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.
If you think you have come across a Gradle bug, please file a new issue describing the problem and how to reproduce it.
If you think Gradle is missing a feature, please file a new issue describing your use case for the feature.

Your configuration is applied to test execution. Jacoco runs with an agent, which is configured just for test runtime. You need to configure Jacoco for compilation.


Exported YAML not valid - "Unexpected value 'condition'"

Have you tried trouble shooting?
yes
Agent Version and Platform
Hosted VS2017
VSTS Type and Version
VisualStudio.com
What's not working?
When build definition is exported using "View YAML" the following is included:
queue:
  name: Hosted VS2017
  condition: succeeded()
  demands:
  - Cmd
  - DotNetFramework
  - vstest
  - java

If I try to create a build using the exported yaml this results in the following error: "Unexpected value 'condition'"
Removing "condition: succeeded()" resolves the problem with no ill effects.
Exported YAML should be valid.

@MireilleHanna is working on a fix for this.

@mireillehanna this in master now, correct? and will roll out with the next sprint deployment? let's close the issue here if so.

yeah that's correct, it will go out with this sprint

i thinks this has been fix.


Improve output from a variable and put in a file

https://github.com/henrybarreto/walkietalkie/blob/fce9babb354a80fed86676f4d1b49439bb9a9a00/soldier/src/main.rs#L38-L39
I guess it could be problematic if commands has outputs too large, using too much memory.
Instead of return a report vector, return a pointer to a file and let the method what send report deal with it.

Better!
Instead of receiving and put the commands/reports on memory, first put it in a file and read from it.
Actually, I'm working on to chuck the communication between soldiers and commanders

https://github.com/henrybarreto/walkietalkie/blob/3a26c0f1578cd5c1256cbcf0aed3445b33f49fb2/src/radio.rs#L50
This is the variable where all data is put on the heap.
I guess it could be a File pointer.


Force the use of python2 in the QEMU compilation

This small fix will make Eclipser easier to compile in ArchLinux.

Thank you for the PR! It seems nice to specify python version for QEMU build. Works well in Ubuntu 18, too.


[AutoPR containerservices/resource-manager] Support two apiversion for container service

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4237

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/3089


Java application

I have a java application with no web.xml file.
The application not running in tomcat or similar but it listen on port 8080.
Is still possible to monitor this app without rebuild the code?
I am not java expert so may be I am missing something.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c4add96-12df-37f9-05be-22a9f1a7b649
Version Independent ID: 794fb2e9-61d5-7e54-2fd8-8a45922d040b
Content: Application Insights for Java web apps that are already live
Content Source: articles/application-insights/app-insights-java-live.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@ripom  Thank you for building a solution with Azure!  The best place for specific answers about implementations are going to be the forums:
https://social.msdn.microsoft.com/Forums/en-US/home?forum=ApplicationInsights&filter=alltypes&sort=lastpostdesc
We actively look through posts in the forums, and will do our best to get you going in the right direction.  If you have any document specific questions (or suggestions), please tag me in your reply and I would be happy to continue the conversation.


Modal does not open without refreshing page

Hello,

I use modal on a user list to add extra information. On the first load of page, when i click on the user-plus (red), the popup did not reveal. If i reload page, it work as expected.
Any tips to avoid this erratic behaviour please ?
I get this on development and production :-(
Thanks for help.

Please paste the code you are using to open the modals. I have had problems with this in the past when relying on data-reveal-id. To fix this, add your own click handler and open manually:
$("#mybutton").on('click', function(){
    $('#myModal').foundation('reveal', 'open');
    return false;
});

Hello,
Thanks for your answer.
I implement this gem : https://github.com/kossnocorp/jquery.turbolinks and it works better now.
and it works better for modal and tabs.

I'll close this for now since it looks like you've got this solved. Feel free to reopen


OBS crashes when trying to use fullscreen projector

Whenever I try to multi-instance, all 6 instances crash with the ID "Process crashed with exit code -1073741819 (0xffffffffc0000005)." I open OBS, click generate scenes, then generate stream scenes, and then right-click Julti and open the fullscreen projector, and then they all crash. I am on a laptop, so I don't know if that is the problem. I am using an RTX 4060 with the latest driver and a Ryzen 7 7840HS.

Please provide a crash log of the instances. If you post one in the Julti or Minecraft Speedrunning discord, a bot can diagnose the issue and provide possible fixes.

Please use the discord's #help-and-support channel


Router-Redux: fireEvent is not changing the route

react-testing-library version:5.6.0
react version:16.8.1
node version:8.12.0
npm (or yarn) version:6.4.1

Relevant code or config:
import React from 'react'
import {withRouter} from 'react-router'
import {createStore} from 'redux'
import {Provider, connect} from 'react-redux'
import {Link, Route, Router, Switch} from 'react-router-dom'
import {createMemoryHistory} from 'history'
import {render, fireEvent, cleanup} from 'react-testing-library'

afterEach(cleanup)

const About = () =>
You are on the about page

const Home = () =>
You are home

const NoMatch = () =>
No match

const LocationDisplay = withRouter(({location}) => (

{location.pathname}

))

function App() {
  return (

      <Link to="/">Home</Link>
      <Link to="/about">About</Link>
      <Switch>
        <Route exact path="/" component={Home} />
        <Route path="/about" component={About} />
        <Route component={NoMatch} />
      </Switch>
      <LocationDisplay />

  )
}

const ConnectedApp = connect(state => ({}))(App)

// Ok, so here's what your tests might look like

// this is a handy function that I would utilize for any component
// that relies on the router being in context
function renderWithRouter(
  ui,
  {route = '/', history = createMemoryHistory({initialEntries: [route]})} = {},
  {initialState = {}, store = createStore(() => {}, initialState)} = {},
) {
  return {
    ...render(
      <Provider store={store}>
        <Router history={history}>{ui}</Router>
      </Provider>,
    ),
    // adding `history` to the returned utilities to allow us
    // to reference it in our tests (just try to avoid using
    // this to test implementation details).
    history,
    store,
  }
}

test('render home page', () => {
  const {container} = renderWithRouter(<ConnectedApp />)
  // normally I'd use a data-testid, but just wanted to show this is also possible
  expect(container.innerHTML).toMatch('You are home')
})
test('render about page on route navigation', () => {
  const {container} = renderWithRouter(<ConnectedApp />, {
    route: '/about',
  })

  // normally I'd use a data-testid, but just wanted to show this is also possible
  expect(container.innerHTML).toMatch('You are on the about page')
})
test('render about page on click navigation', () => {
  const {container, getByText} = renderWithRouter(<ConnectedApp />)

  const leftClick = {button: 0}
  fireEvent.click(getByText(/about/i), leftClick)
  // normally I'd use a data-testid, but just wanted to show this is also possible
  expect(container.innerHTML).toMatch('You are on the about page') // fails
})

What you did:
I am using redux and router to test my component. The navigation works via setting the route and the fireEvent is not triggering the route and renders same previous component. In other case, the fireEvent works and the route navigation doesnt. Please help
What happened:
Expected value to match:
"You are on the about page"
Received:
"HomeAboutYou are home
/"
Reproduction:
https://codesandbox.io/s/ypwzjqwjrj
Problem description:

Suggested solution:

Can anyone help, please?

@karimjavith I think it's a Codesandbox issue - it works when I download your repro sandbox and run it.

@alexkrolick  The test in question is react-redux-router. could you please try it?

@alexkrolick The test in question is react-redux-router. could you please try it?

OK. That one fails.

Not sure what is going wrong. The event listeners are not changing the location while navigation and vice versa.

The examples have their own repo - https://github.com/kentcdodds/react-testing-library-examples
Looks like the Codesandbox in general is failing in several files in the tests directory, so it's hard to diagnose exactly what the problem is

Hey! I am also new to this library!!

@karimjavith

@karimjavith
I am also new to this library.. and I had the same bug. My code looks like this and now it works :)

The codesandbox has been fixed and all the tests are passing. Hopefully that helps.
Closing this for inactivity. If someone wants to work on it in the future feel free to open a new issue. Thanks!

Found out. I did not wrap the parent component with WithRouter() which was causing the problem.
Thanks, everyone for your comments 👍


Re-enable Autobahn Tests on IIS when ANCM issues resolved

From @anurse on Thursday, March 23, 2017 10:09:49 AM
See https://github.com/aspnet/AspNetCoreModule/issues/80
We had to disable our Autobahn tests that run in the IIS+ANCM scenario because we were seeing frequent flakiness and random failures. This issue is to track re-enabling those tests when ANCM is able to consistently pass the test suite.
Copied from original issue: aspnet/WebSockets#160

From @anurse on Thursday, March 23, 2017 10:11:08 AM
Link to the code that ran these tests before we removed them: https://github.com/aspnet/WebSockets/blob/eb0ab115d84704af6ce30a6932fa08d427ce0a1d/test/Microsoft.AspNetCore.WebSockets.ConformanceTest/AutobahnTests.cs


Et Futurum breaks russian translation?

A user reported it on the forums that after installing Et Futurum his game switches to english despite it saying on the menu that it is in russian.
@Adaptivity would you know anything about this?

o_O will investigate. Probably fault on his side.

Yeah I think it's probably something derpy that he's doing or some other mod messing with translations. But he says he's sure it's Et Futurum causing it.

Can't reproduce. Et Futurum just can't break localization since it's using vanilla assets system for its localization as almost every mod doing the same thing in 1.7.10

Yeah, that's what I thought

Hello there.
I was the one who reported this issue on minecraftforum.
It is strange, but i have definitely language break, even only one this mod installed.
I'm tried to analyse the launch logs of the minecraft, and didn't find any useful information about the mod and the language.
The only one strange thing i noticed: the mod has the language folder in assets/minecraft/lang subfolder, but usually other mods have this subfolder in assets//lang subfolder.
I didn't understand anything in mod programming, so it may means nothing.
But anyway, can you try to help me to resolve this problem? :)
I can upload the logs and screenshots.

I'll move the lang folder to assets/etfuturum/lang but I doubt it will help. Feel free to speak russian if you prefer. @Adaptivity is russian (i think) =P

@ganymedes01 you shouldn't move anything. it's 100% user mistake. Especially since this will not solve the problem.
@user707 Можешь залить мне полностью папку .minecraft куда-нибудь? Яндекс.диск, dropbox, куда угодно.

Since you are already done this... can you drop a new build to @user707?

Yeah, I'll make a build. If it doesn't work I'll revert the change.

@user707 mind trying this?
https://www.dropbox.com/s/wccj529iv9h11ip/Et Futurum-1.4.3.jar?dl=0

@Adaptivity нет проблем, уже заливается :)
@ganymedes01 yes, one minute plz

@ganymedes01 Heh, its allright now! Now it is in Russian. Thanks very very much :D

@Adaptivity я хз почему так, но все заработало. Вот ссылка, если еще актуально :) https://yadi.sk/d/KuDsrvp-jED6R
Спасибо большое вам обоим :)

@user707 Да ладно, нет проблем :)
@ganymedes01 This was a really strange issue :) Never occurred for me. Glad it's fixed now.

Strange that the folder was causing an issue to him but not to you.
What OS do you guys use?

i have Windows 10 x64

I'm on Windows 7 x64

Weird...
well I have no idea why what I did fixed it, but it did. Glad the issue was fixed =P


zh: add handle-error-sql-statements.md

What is changed, added or deleted? (Required)
add handle-error-sql-statements.md

sql-skip/sql-replace 重构为 handle-error, 删除了原有的文档，新增的 handle-failed-sql-statements 借鉴了原来文档的结构和部分使用场景。其余地方几乎都不一样。
Which DM version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v2.0 changes for now)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?
DM#850

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

[x] Delete files
[x] Change aliases
[ ] Have version specific changes
[ ] Might cause conflicts

hi @GMHDBJD ，可以在 pr 描述里概括下你做的改动吗？两个修改的文件都太大了，不确定你修改的地方，不方便 review

PTAL again. 我直接把错误信息提炼出来了，会不会太简洁了。。。

/merge


Allow for multiple HelmRepositories to be Profile repos

After https://github.com/weaveworks/weave-gitops/issues/1144 has been finished, we have the ability to get profile related values for all HelmRepositories not just the ones configured. Since the watcher is watching and caching data from all repositories not just one.
This is, however, a breaking change as we will, remove or change, the following things:

The configurable HelmRepository namespace and name from the profiles server in wego-core
The UI component of GetProfileValues to use the HelmRepository from the previous call in order to find out which repository a profile belongs to and list values for that in wego-enterprise
The CLI command line arguments which define helmrepository values when starting in wego-core

These changes can be introduced after the Watcher and the Cache is finish to isolate the breaking changes as much as possible.
This is a relatively small change but spans two repositories so it is being left out from 1144.

We can hopefully incrementally move this forward:

scanning all, returning the repository in the responses
if no repository is provided in client calls, we default to the configured one
fail if no repository is provided (i.e. remove the defaulting)


Security.md: Grammatech CodeSonar link is 404

Checklist (Please check before submitting)

[x ] I reviewed the Contributing Guide.
[ x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Security.md contains a dead link describing CodeSonar
To Reproduce
Steps to reproduce the behavior:

Browse to https://github.com/nasa/cFS/security#codesonar
Click on the link
See error 404 from Grammatech

Expected behavior
Information about CodeSonar
System observed on:

Apple MacBookPro15,1
OS: MacOS Sonoma 14.7.1
Google Chrome Version 131.0.6778.109 (Official Build) (x86_64)

Additional context
N/A
Reporter Info
Douglas Held

I would like to take up this issue if it is still open.
Thanks.
@vinsdragonis

I have made the changes in the PR: CodeSonar URL correction

@vinsdragonis certainly - please review the Contributing guide and open a pull request. Appreciate the contribution!


Update Kong Admin API used by Dispatch

Feature Request
Detailed Description
Currently used API (https://docs.konghq.com/0.13.x/admin-api/#api-object) is deprecated in version 0.13.x and removed in 0.14.x (latest release). We should update the implementation to use new concepts (services & routes)
Complexity

[ ] Low - Simple enhancement or bug fix, no architectural changes or refactoring
[x] Medium - Change requires some thought, but is relatively isolated
[ ] High - Significant architectural change or large refactor

Should we move to the Kong ingress controller at this time?


To generate UpdateStatus for workflow and CronWorkflow

It also removes spurious files erroneously generated in previous commit
@clamoriniere1A

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   40.23%   40.23%
=======================================
  Files           9        9
  Lines         835      835
=======================================
  Hits          336      336
  Misses        473      473
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc20496...a481561. Read the comment docs.


a couple of comments

The function InfoBox.prototype.getCloseBoxImg_ on line 244 infobox-module.js
i believe using one string to build the img variable instead of doing 7 concatenations is lighter.
and i dont understand why some variables are set to null, why not just keep them undefined?
Thanks

@Bamieh, the infobox-module script is a copy of the infobox plugin, so there's nothing in there that should be changed.

this concerns to the plugin itself not to this modules, which is a wrapper for the plugin


BeginCreatingDeploymentAsync fails with default setting of ProvisionGuestAgent

I run into some issues with the BeginCreatingDeploymentAsync when I tried to create deployment using default setting for the ProvisionGuestAgent which is false. The following configuration fails with the error "BadRequest: In order to use extension reference, ProvisionGuestAgent must be set during virtual machine provisioning."
var deployment = new VirtualMachineCreateDeploymentParameters
{
    DeploymentSlot = deploymentSlot,
    Label = label,
    Name = name,
    Roles = new List<Role>()
    {
        new Role
        {
            ConfigurationSets = configurationSets,
            Label = roleLabel,
            OSVirtualHardDisk = new OSVirtualHardDisk
            {
                Name = hardDiskName,
                MediaLink = hardDiskUri,
                OperatingSystem = "Windows",
                SourceImageName = imageName,
            },
            RoleName = roleName,
            RoleSize = roleSize,
            RoleType = "PersistentVMRole",
        }
    },
};

I discovered that it is due to the ResourceExtensionReferences being initialized to an empty list. Because the property is not null the request will include an empty Xml element for <ResourceExtensionReferences/> which is enough to mark the request as invalid.
The workaround is to set ResourceExtensionReferences to null when you set ProvisionGuestAgent to false. It is not intuitive.
var deployment = new VirtualMachineCreateDeploymentParameters
{
    DeploymentSlot = deploymentSlot,
    Label = label,
    Name = name,
    Roles = new List<Role>()
    {
        new Role
        {
            ConfigurationSets = configurationSets,
            Label = roleLabel,
            OSVirtualHardDisk = new OSVirtualHardDisk
            {
                Name = hardDiskName,
                MediaLink = hardDiskUri,
                OperatingSystem = "Windows",
                SourceImageName = imageName,
            },
            RoleName = roleName,
            RoleSize = roleSize,
            RoleType = "PersistentVMRole",

            // Workaround starts here
            ProvisionGuestAgent = false,
            ResourceExtensionReferences = null,
        }
    },
};

Please update the request serialization code and make it skip <ResourceExtensionReferences/> element if the collection is null or empty.

Thanks for the feedback.  Routing this issue to the appropriate team.

testing.

testing

From our dev @huangpf
By design, the field 'ResourceExtensionReferences' is designed to be 'LazyInitialized', which means, if this code is not referred or 'touched' anywhere (like in Debug mode), it would be null.
If it's accessed somewhere, it would be empty list, for example, the following line will make it an empty list:
Console.WriteLine(role.ResourceExtensionReferences);


Improve extensions errors design

Current field errors returned through extensions are quite limited in its design.
When a request should return data about payment, it should, aside the payment request field if a new invoice is generated, provide also an invoice state information, otherwise there is a potential bottleneck when handling query responses and conditional rendering on client side

Closing issue as bottleneck should be handled through the designed flow proposal at #8

Closing issue as bottleneck should be handled through the designed flow proposal at #8


fix libh3 install on windows

3.6.4 regression: dll are not anymore installed in bin folder on Windows if h3 is built as a shared lib.
This PR fixes this issue.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 99.132% when pulling a55041672e896a69c5a030eb46926f8eb74e6dc4 on SpaceIm:fix/libh3-install-windows into 93b5a30adef3c60ff4a7dd773f03dba040eb8673 on uber:master.

Thanks for fixing this. I had a little trouble reproducing this issue because building H3 with -DBUILD_SHARED_LIBS=ON was also causing h3WithTestAllocators and generateFaceCenterPoint to fail. Could you let me know the Visual Studio version you're using and any CMake flags? I got around this by turning BUILD_TESTING and BUILD_GENERATORS off.

@isaacbrodsky
I've seen this issue while upgrading H3 to 3.6.4 for conan package manager https://github.com/conan-io/conan-center-index/pull/2139, therefore BUILD_TESTING and BUILD_GENERATORS were turned off indeed.


Feature Request: MFA or external authentication via OAuth2/OIDC

Hi, looks like a really interesting product you are building here.
TL;DR: MFA and/or a generic OIDC solution would be awesome.
The biggest issue that stops us from using this in a real way is security. It would be nice to have multifactor-authentication and/or external authentication (where we can have MFA).
I did not find anything about this in the documentation but the way it worked in Drone was very nice, although I understand that signing in with a git-provider account kind of defeats the purpose here.

I wanted to echo this request. Authentication with username/password blocks us from using gitness. Would be great to support external authentication!


Docker build

This is an attempt at building the Locutus development node inside Docker.
This should help people who have dependency issues.
Its working for me.
I had to change the local development node, so it can bind an address other than localhost,  because you can't expose localhost outside the container.

First, thanks a lot for the contribution.
No problem,  I am building a POC app with this, so I will be contributing as much as I can. :)

I can just squash them.
That would be easiest :)

Looks good, but will have to fix the compiler errors and pass tests.
To speed that up so you don't have to wait for CI to complete, you want to make sure that:

tests build
examples build
tests pass with the following flags:

"--no-default-features",
"--all-features",


Fixed error when there are no annotations in vmrk file

Before this fix, attempting to access a vhdr file with associated vmrk would give the following error:
~mne-python/mne/io/brainvision/brainvision.py in _read_annotations_brainvision(fname, sfreq)
    257         The annotations present in the file.
    258     """
--> 259     onset, duration, description, date_str = _read_vmrk(fname)
    260     orig_time = _str_to_meas_date(date_str)
    261

ValueError: not enough values to unpack (expected 4, got 0)

Presumably because there were no annotations. Now the code skips attempting to retrieve annotations when there are none.

Can you add a test?

This pull request introduces 5 alerts when merging 7aa9ff780fc0a2da159d51ea96b9efd745aa8131 into d0b8c005d3e14f911c6615788e4428052cbe2819 - view on LGTM.com
new alerts:

5 for Syntax error

Comment posted by LGTM.com


why name illegal file name

i download all zip file after upload my bim file on the website:https://extract.autodesk.io/.
in the folder:Resource____3D 155844\3\mats,there are three photo files,
their name are
one:woods & plastics.finish carpentry.wood.red birch.png
two:woods & plastics.finish carpentry.wood.teak.png
three:woods & plastics.finish carpentry.wood.white oak.png
why their name have the illegal character “&” and  blank space.it will rasie an error in a web site application.
i can't show them on my ipad.

@cyrillef thanks.

@cyrillef @autodesk-adn model can't show on safari brower.

@lwdred do you got a sample I can test?


[SYSTEMML-1606] Update notebook samples with latest code

Updated code to work with latest SystemML code.

Updated following line with setRawPredictionCol("prediction"), as code was throwing an exception "java.lang.IllegalArgumentException: Field "rawPrediction" does not exist."
BinaryClassificationEvaluator).setRawPredictionCol("prediction"))

@niketanpansare Please look at the changes.

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1469/

cc @niketanpansare

There is a bug in scala logistic regression that needs to be fixed. Setting prediction to raw prediction might not fix the issue. Here is my recommendation to be consistent wrt this notebook:

Create a separate PR and delete this notebook.
Keep this PR open until the bug is fixed.
Once the bug is fixed, merge the notebook :)

Can this be updated now?

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1767/

Let us close this one for now.


Memory leak: animation proxy 'transitionend' event listener never removed

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce
Go to the constructor of Map and find:
DomEvent.on(this._proxy, 'transitionend', this._catchTransitionEnd, this);

There is no removal of the event listener in the teardown code for Map, which means that creating/tearing down maps repeatedly will leak memory over time.
Expected behavior
Map.remove() should contain the following:
DomEvent.off(this._proxy, 'transitionend', this._catchTransitionEnd, this);

Alternatively, it could be done in an 'unload' event listener.
Current behavior
Memory leak.
Minimal example reproducing the issue
No response
Environment

Leaflet version: 1.9.2
Browser (with version): any
OS/Platform (with version): M1 Max Macbook Pro

Thanks for taking the time to report this with clear instructions, that is always appreciated. If you feel like you have an appropriate fix for this issue, a PR is always welcome.


new feature  about push new branch directly

push new branch to remote ,just click new branch checkbox,
Due to work requirements, there are many times when we cannot directly push to the main repository, but we still need a pull request. Therefore, the best approach is to push directly to a new remote branch and then merge it. Although this practice is not very common, tools like  (TortoiseGit) have this functionality and can be referenced.

Why not create a new branch locally first and then push it directly to the remote? Or use a workflow like git-flow?

[!NOTE]
When the selected local branch has no tracking upstream, and there's not a branch with the same name of selected local branch, a branch in ${SELECTED_LOCAL_BRANCH_NAME} (new) will be automatically selected - it means a new remote branch with the same name of selected local branch will be created and push current selected local branch into it.

Based on  TortoiseGit Function

Simplifying the push process, having too many local branches requires self-management.

Ok. This is just my suggestion.


_ensure_valid_dtype should also check for NETCDF4_CLASSIC

In netcdf.py, _ensure_valid_dtype tries to convert types like int64 and unsigned that aren't supported in NetCDF3 to int32. I think the test should also include NETCDF4_CLASSIC.
E.g. saving a cube from a model start dump gives a file with an int64 variable (path here is to our collection of the data for UM rose stem testing)
cube = iris.load_cube('/g/data/access/TIDS/UM/standard_jobs/inputs/vn10.4/N48L70_EG/n48_eg_start_dump', 'air_potential_temperature')
iris.save(cube,'theta.nc')

theta.nc has
        int64 model_level_number(model_level_number) ;

Saving with
iris.save(cube,'theta.nc', netcdf_format='NETCDF3_64BIT')

gives
       int model_level_number(model_level_number) ;

However trying to save as NETCDF4_CLASSIC
iris.save(cube,'theta.nc', netcdf_format='NETCDF4_CLASSIC')

fails with error
RuntimeError: NetCDF: Attempting netcdf-4 operation on strict nc3 netcdf-4 file

The netCDF documention http://www.unidata.ucar.edu/software/netcdf/docs/data_type.html says

Only files created with the netCDF-4/HDF5 mode flag (NC_NETCDF4) but without the classic model flag (NC_CLASSIC_MODEL) may use user-defined types or the new atomic data types.

If I modify _ensure_valid_dtype to include NETCDF4_CLASSIC in the test things work as expected.

This sounds like a sensible approach to me. Would you like to submit a PR making this change @MartinDix?

#2080

Looks like this was fixed by #2080.


0.4.0 TaskEither issues

Hey @gcanti, I'm upgrading to fp-ts 0.4.0 and I ran into this issue with TaskEither. See the error in the code.
Do you have any ideas what's going on here?
import * as apply from 'fp-ts/lib/Apply';
import * as tuple from 'fp-ts/lib/Tuple';
import { Task } from 'fp-ts/lib/Task';

import * as taskEither from './TaskEither';

import Tuple = tuple.Tuple;
import TaskEither = taskEither.TaskEither;

// tuple constructor
const toTuple2 = <A, B>(a: A, b: B): tuple.Tuple<A, B> => new tuple.Tuple([ a, b ]);

// lifted tuple constructor
const taskEitherToTuple2 = <L, A, B>(fa: TaskEither<L, A>, fb: TaskEither<L, B>) =>
    apply.liftA2(taskEither, (a: A) => (b: B) => toTuple2(a, b))(fa, fb);

type Tuple2TaskEither<L, A, B> = (tuple.Tuple<TaskEither<L, A>, TaskEither<L, B>>);

export const toTaskEitherTuple2 = <L, A, B>(t: Tuple2TaskEither<L, A, B>) =>
    taskEitherToTuple2(t.fst(), t.snd());

const taskEither1: TaskEither<number, number> = taskEither.of(1)
const taskEither2: TaskEither<number, number> = taskEither.of(2)
toTaskEitherTuple2(new Tuple([taskEither1, taskEither2]))
    // Error: [ts] Property 'chain' does not exist on type 'HKT<"TaskEither", Tuple<number, number>>'.
    .chain(tupleInstance => {

    })

How is defined your TaskEither?

@gcanti I've just copied/pasted the lates one in the repo: https://github.com/gcanti/fp-ts/blob/260ab3a720bed237fef2d2c18761f71c3a1523b7/examples/TaskEither.ts

Ok so, this fp-ts version is necessarily less smart than the previous one when it comes to transform a HKT<F, A> into a concrete type, it needs some hints through a list of "overloadings".
In this case liftA2 returns correctly HKT<"TaskEither", Tuple<number, number>> but while we, as developers, know that is equivalent to TaskEither<number, Tuple<number, number>> the compiler can't know that, so we need to add an hint

// add this to the `TaskEither` file

import { Curried2 } from 'fp-ts/lib/function'

declare module 'fp-ts/lib/Apply' {
  interface Ops {
    liftA2<A, B, C>(
      apply: Apply<URI>, // <= important: this is the URI of TaskEither
      f: Curried2<A, B, C>
    ): <L>(fa: TaskEither<L, A>, fb: TaskEither<L, B>) => TaskEither<L, C>
  }
}

In practice by doing that we provide a proof to the compiler that it can trasform a HKT<'TaskEither', A> into a TaskEither<L, A> in the context of liftA2. Does it make sense?

@gcanti Amazing, thank you. Good to understand why that is necessary.
Can we add this to the example TaskEither in this repo? I will try to write some documentation once I understand things a bit better.

btw this is the reason why you can find a file named overloadings.ts in the lib folder which contains a big list of built-in overloadings written by me (PRs welcomed)


[test] REQUIRE cpu arm64 when testing arm64 flags.

If llvm-targets-to-build doesn't include AArch64, then this test fails
unhelpfully because architecture-specific flags are missing.

@swift-ci please smoke test and merge


Fix calling ntop on tracepoint args

Commit f05b4cda691e82ab ("Introduce Type::ctx") introduced a ctx type
for values that come from the bpf prog context. This subtly broke ntop()
because ntop was not yet aware of Type::ctx.
Fix this by relaxing semantic analyser check to include Type::ctx.
Similarly relax for codegen.

Checklist

[x] Language changes are updated in docs/reference_guide.md
[x] User-visible and non-trivial changes updated in CHANGELOG.md

I wonder if Type::ctx should be limited to just the ctx builtin. Reasoning is that a value coming from the prog context is more an attribute and not a type unto itself. For example, saddr_v6 can be both an array and from the prog ctx. It doesn't necessarily have to be one or the other.
@mmisono any thoughts?

I wonder if Type::ctx should be limited to just the ctx builtin. Reasoning is that a value coming from the prog context is more an attribute and not a type unto itself.

I'm working on replacing cast with a pointer and a record type. As ctx can currently be both and more which makes it confusing I'm going to remove ctx too and make it an attribute instead.
https://github.com/fbs/bpftrace/tree/pointer_type

Sounds good. Looking forward to seeing that merged :)


Refactor APIs

This PR is a pretty big refactor.
Main changes

The concept of architecture and strategy have been removed. This might lead to slightly more code duplication, but a much more flexible code base and much easier to understand.
Introduce the concept of  Deployment and Runtime. Deployment describe the behavior while packaging and deploying the code while Runtime describe the behavior on the remote target (i.e. a TFJob on Kubernetes). Currently Runtime is pretty simple, but will be useful once we re-introduce hyperparameter tuning and Population based training
Each provider (native, kubeflow) now can export several decorators (e.g. Training and DistributedTraining) instead of always working with Train. Issue with the previous approach is that Train ended up having tons of parameters which may or may not apply to your particular training, it was confusing.
Remove dependency on metaparticle (fixes #8) and allow each step of the build/deployment to easily modify the generated k8s objects. This should make https://github.com/kubeflow/fairing/pull/15 much easier to achieve.
Introduce a Config object which can be used to specify which builder to use. With this Builders can now take whatever argument they need without having to surface them via the training decorator.

Temporary
This features where removed because the current approach was not right, but these are definitly valuable features to have, I will open an issue for each of them to discuss how to reintroduce them properly:

Remove hyperparameter tuning
Remove TensorBoard
Remove Population Based Training (Not sure if we want to reintroduce this for now)

cc @r2d4 @ashahab

This change is

/assign @r2d4

@r2d4 Thanks for the review!
I applied or responded to all your comments except for generateName as I don't have enough time to test it right away

Sounds good
/lgtm
/approve

Feel free to remove the /hold and merge when you want to

Some example things are other things in the pod spec(env, initContainers,
mounts, securityContext). Configmap allows us to not limit fairing
TFjobs to what we support today.
On Tue, Nov 20, 2018 at 5:57 AM William Buchwalter<EMAIL_ADDRESS>wrote:

@wbuchwalter commented on this pull request.
In fairing/training/kubeflow/deployment.py
https://github.com/kubeflow/fairing/pull/20#discussion_r235011340:

@@ -0,0 +1,52 @@
+from kubernetes import client as k8s_client

+from ..native import deployment
+
+class KubeflowDeployment(deployment.NativeDeployment):
+

def init(self, namespace, runs, distribution):

   super(KubeflowDeployment, self).__init__(namespace, runs)

   self.distribution = distribution

def deploy(self):

   self.backend.create_tf_job(self.namespace, self.job_spec)

def generate_job(self, pod_template_spec):

Yes I plan on opening a follow-up issue regarding admin config. I am not
sure yet what are all the things an admin would want to configure that I
think we need to discuss it a bit before implementation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/fairing/pull/20#discussion_r235011340, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAqJPRUkh2d12yzIJ3hEJ7hfyt5y3oAZks5uxAphgaJpZM4YoOVo
.

@r2d4 fixed. Can you re -apply lgtm when you have time?

/hold cancel


Add RFC 7111 "URI Fragment Identifiers for the text/csv Media Type" support

RFC 7111 support would allow the use of row=, col=, and cell= to be selected via the URL Fragment--or even a combination of them via Multi-Selection
Here are the basic syntax rules.

@BigBlueHat nice idea :-) Are you up for implementing?

@rgrp I wish I had the time right now...but alas. :cry:
Perhaps @iherman knows someone from the CSV Working Group? :wink: Although judging by the readme on CSVPlus...he may not. :disappointed:

@BigBlueHat : @rgrp is in the same CSV group, actually. But, indeed, there wasn't many javascript implementers. If somebody wants to pick up CSVPlus and complete it: that would be great. But I am not sure Rufus' library has the same goal.

@iherman is right that this library is just aimed at a very simple parsing of CSV - though extra features via URI fragment would definitely be considered if someone were interested to contribute :-)


Missing message "bad identifier ..."

Hi,
when create a new application, if name contains uppercase letter appear a this pop up

Message are not translated in Italian language, but I can't find it in "it_it" file. Such message isn't into en_en file also. I think it is hard coded in the application.
May you add in message files?
Thanks,
Fabio.

Hello Fabio,
You are right, this message is currently hard-coded. I will take a look at it.
Warm regards,
Gabriel

2.6 will introduce new error codes, which make it easier to deal with error messages from the backend on the frontend. This change also increases the number of translated error messages, including the one in this issue.


Tilesets can have objects inside of them since Tiled 1.0,

This just adds a field to the Tile so that data may be parsed and accessed
Also, the XML may omit the name for these objectgroups, so I made ObjectGroup::name default to an empty string

Nice, thanks very much!


Move travis to github actions

Which shellcheck github action should we use?

@bukowa Used manual configuration, downloading the current release and running it

Shellcheck warning some erros. Opened issue #35
Tests on OSX are not ok. Using issue #31


iCloud will not sync on iOS

I have NNW on 2 macs and iPad and an iPhone, all syncing feeds via iCloud. The 2 macs have no issue communicating with each other or feeds, however the iPad and iPhone will not update feeds (They wont even fully list what feeds I'm subscribed to). The loading bar just sits at the very start and never moves.
Its been like this for at least 8 months, I though for a long time it was just an issue with my iPad (I did try reinstalling the app a few times), but having recently gotten a new iPhone, it has exactly the same issue right out of the box.
At first I thought it was a conflict with ProtonVPN, however disabling that does not fix the issue. My next best guess is that something about my iCloud feed library is corrupt in some way, but I'm not sure what to do about that.

Initial sync with iCloud can take a very long time. This is due to a limit in how fast we can download iCloud data. This is especially true if you have a large number unread items.
You have to keep NNW in the foreground while the initial sync happens or you have to start the sync over again. This is due to a limit in how long we can run NNW in the background on iOS.
Please remove you iCloud account and add it again, keeping NNW in the foreground until it is done. This will likely take a good deal of time. It can literally take an hour or more. We understand this is tedious, but we don't have any better options on iOS due to system resource limitations.
I'm going to close this issue since we understand well that iOS initial syncs take a very long time. Please comment on this issue, even after I close it, and let us know how you do.

Ah thank you for your fast reply, leaving it open and the screen on did fix it! Although I realize now my mistake was trusting iCloud :P I took the opportunity to install FreshRSS and its instant! Although not exactly user friendly to setup..

Yeah, the other syncing services don't bandwidth constrain the way that iCloud does.