Build failure: motif

Steps To Reproduce
Steps to reproduce the behavior:

build motif

Build log
output of nix log /nix/store/7m27hlg1wdymiqf22drbdwcqh7jk9j5d-motif-2.3.8.drv | sed  -e 's/\x1b\[[0-9;]*m//g' (to remove color codes)
https://gist.github.com/cbarrett/302fb8409beaa8a36a8206ce9c77ba0a
Additional context
I'm on Mac OS 12.7.2, with Xcode 14.2. FWIW my ultimate goal was to build snd, which is how I noticed motif failing.
Notify maintainers

@alyssais @trofi
Metadata
~ $ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 21.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `""`
 - channels(cbarrett): `"darwin, nixpkgs-23.11-darwin"`
 - nixpkgs: `/Users/cbarrett/.nix-defexpr/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

hydra agrees: https://hydra.nixos.org/job/nixpkgs/trunk/motif.x86_64-darwin/all
Looks like motif broke around Nov 2023. Possibly after clang-16 update?
TextF.c:9352:13: error: call to undeclared function '_Xwcscpy'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            wcscpy(wc, call_data->text->string.wide_char);
            ^

Similar x96_64-linux reproducer:
$ nix build --impure --expr 'with import ./. {}; motif.override { stdenv = clangStdenv; }' -L
...
motif> XpmWrFFrI.c:122:7: error: call to undeclared library function 'strncpy' with type 'char *(char *, const char *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
motif>   122 |             strncpy(new_name, name, sizeof(new_name));
motif>       |             ^

https://github.com/NixOS/nixpkgs/pull/302635


Fix a crash for color grading

Set postprocess descriptor set for color grading

It's called from Renderer.cpp https://github.com/google/filament/blob/main/filament/src/details/Renderer.cpp#L1056


is not an issue itself is more than a curiosity ok

guys, supporters, people, please anyone can say to me which is the chromium version used on this browser it is because i love it and i love the fact that is lighter no matter that it is compatiible with a lot of google services (IT IS NOT AN ISSUE IF YOU ERASE IT IS FINE JUST I REQUEST ONE SINGLE THING THAT THE GUY WHICH DID POSSIBLE ALL THIS PROJECT OR THE TEAM ITSELF SEND ME AN EMAIL TO CONSIDER HIS CONTACT BECAUSE IT MUST BE GREAT)

Hi, thanks @soyDESKTOP68A2MRFT by your appreciation.
currently this project is maintained only by me, but I accept any kind of contribution.
The project uses electron as base, so for follow the chromium version you should check this electron doc: https://www.electronjs.org/docs/tutorial/electron-timelines
Currently the Companion uses the electron version 9.4.0 so the chromium version is M83 (it needs to be updated for sure).
I will not keep your issue, but I will open one for the electron update aside the chromium and to create a version label on the README file.

this will be closed for the sake of those two new issues below:
https://github.com/brunurd/companion/issues/27
https://github.com/brunurd/companion/issues/28


[WFLY-19145] When provisioning a wildfly-preview based server for tests, use wildfly-test-feature-pack-preview for test-specific content

https://issues.redhat.com/browse/WFLY-19145
Builds on #17731 which has another fix related to getting tests of WildFly Preview working properly.

<--- THIS SECTION IS AUTOMATICALLY GENERATED BY WILDFLY GITHUB BOT. ANY MANUAL CHANGES WILL BE LOST. --->

Wildfly issue links:

WFLY-19140

<--- END OF WILDFLY GITHUB BOT REPORT --->

Thanks @jfdenise


Issue with Tag version on Github

Hi ContainerdD Team,
Im seeing an issue on the github API page, if you check the link below, instead to point to the latest one, its pointing to the version 1.3.9, however  the latest version on the time 1.4.3.
https://api.github.com/repos/containerd/containerd/releases/latest
looks like, the version 1.3.9 has the tag latest

I agree this is confusing, but this is actually correct because we released 1.3.9 after 1.4.3.
I don't think there is an action we can take, unless GitHub supports setting the latest version explicitly.


if number value is over 2^53, that number is changed to wrong number because of Double-precision floating-point format

At rest tab, I have search with query like below
{
  "size": 100,
  "query": {
    "match_all": {}
  },
  "filter": {
    "bool": {
      "must": [
        {
          "term": {
            "LOG_NO":<PHONE_NUMBER>34043392
          }
        }
      ]
    }
  }
}

after Request, query is chaged to
{
  "size": 100,
  "query": {
    "match_all": {}
  },
  "filter": {
    "bool": {
      "must": [
        {
          "term": {
            "LOG_NO":<PHONE_NUMBER>34043400
          }
        }
      ]
    }
  }
}

LOG_NO is changed from<PHONE_NUMBER>34043392 to<PHONE_NUMBER>34043400

In jquery.js's parseJSON: function( data ) , window.JSON.parse( data ) call is not cover large number
json parsor that can cover biginteger : https://www.npmjs.com/package/json-bigint

@KangYongKyun you can send the value as a string :)
changing the code to handle this doesn't seem a good option for me


Update docs

This is a non-functional change which updates the format of the readme and also updates docs/.  This should also fix summary page on PyPi.

Going to merge this directly since it's just a documentation change and will improve on the README for the repo.


xwayland: update overrideRedirect on map and configure

Describe your PR, what does it fix/add?
Fixes surfaces that are originally starting with overrideRedirect = true not being updated on configure and map notifies.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I kept the update logic in the function in case the other pieces from wlroots needs to be added back in, but I think these already get handled? Might want to double check that.
Is it ready for merging, or does it need work?
Works on my end for account creation typing, but want to confirm #7507 works as I don't actually play the game anymore.

op busy but patch looks good, merging, thanks!


[NSKnownKeysDictionary1 _fastCStringContents:] iOS9

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSKnownKeysDictionary1 _fastCStringContents:]: unrecognized selector sent to instance 0x18a8de10'
during properties[entity.propertiesByName] in the  public static func keyForRemoteKey(remote: String, context: NSManagedObjectContext) -> String function
Only in iOS9!

Should be fixed in 0.0.4, let me know


💭 react-native-vision-camera:buildCMakeRelWithDebInfo[arm64-v8a] FAILED

Question
when i try make a Apk.
cd android && ./gradlew app:assembleRelease && cd ..
getting error
"Execution failed for task ':react-native-vision-camera:buildCMakeRelWithDebInfo[arm64-v8a]'.

com.android.ide.common.process.ProcessException: ninja: Entering directory `/node_modules/react-native-vision-camera/android/.cxx/RelWithDebInfo/6vrrw3b6/arm64-v8a'"

react native version 0.74.2
react native vision camera 4.3.2
react-native-worklets-core 1.3.3
how to fix this CMakeFile issue already try with troubleshoot no change happens
What I tried
when try to generate APK
VisionCamera Version
4.3.2
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

I have the same problem. Any solution?

Deleting folder android/.gradle worked for me

wrong issue template.

Related to #1913 probably


Bad request from usage of float4 column entry

There seem to be gaps in the validation and handling for the floating point column type data entry form.

Start a create record form such as using the "Copy" button on https://synapse-dev.isrd.isi.edu/chaise/record/#1/Zebrafish:Subject/RID=1-1V4R
Type a number with leading spaces e.g. '   5' without quotes
Backspace to remove the digits but not all the spaces
Hit submit

See Error 400 Bad Request The request is malformed. Bad JSON array input. ERROR: invalid input syntax for type real: "" .
It seems like part of the UI is stripping the spaces to create an empty string, but then sending a quoted string instead of resetting it to null as it should be for this column type.

@karlcz the above referenced commit to master fixes this issue. Reassigning this to you to test and close.

Closing the issue due to inactivity.


error when trying to use MediaLibrary.usePermissions()

Version
v0.2.2
Problem Area
react-native-pytorch-core (core package)
Steps to Reproduce
Tested on ios device with Playtorch app using expo (android device doesn't work as well)
1.package.json
{
"dependencies": {
"react-native-pytorch-core": "0.2.2",
"react-native-safe-area-context": "4.3.1",
"expo-media-library": "~14.2.0"
}
}
2. in App.tsx,
import * as MediaLibrary from 'expo-media-library';
3.in export default function in App.tsx,
const [status, requestPermission] = MediaLibrary.usePermissions();
4.Error occurs
Error Message : App.tsx (0:1) new NativeEventEmitter() requires a non-null argument. (Device)
Expected Results
Shows Alert if you're going to allow permission for this app to use in this device.
Code example, screenshot, or link to repository
No response

@qoientlmn, the PlayTorch app does not include the native code for expo-media-library, which means it can't be used with the PlayTorch app.
However, you can build your own app following instructions in the tutorial Expo App. Then, after npx expo install react-native-pytorch-core also run npx expo install expo-media-library. This will include the expo-media-library in the app build.
Alternatively, the PlayTorch app source code is open source, and we are open to accepting PRs from the community. Submit a PR that adds the expo-media-library to the app, and I'll have a look if we merge it for the next version update of the PlayTorch app (version 0.1.3).


feature(dspy): added retrieval module for Watson Discovery

This feature allow to search and retrieve documents stored in Watson Discovery

Thanks @andreswagner !


Fix Limelight Digital Bidder Adapter downloading

from https://docs.prebid.org/download.html page

thanks for the fix


[Documentation]: Custom docker image instructions should note that you can use a pre-existing docker image

What problem or use case are you trying to solve?
In our custom sandbox guide: https://github.com/OpenDevin/OpenDevin/blob/41ddba84bd0d62f8a4bc48d08addde4b4269a687/docs/modules/usage/custom_sandbox_guide.md?plain=1
We state that you can create a custom sandbox by creating your own docker image, then specifying it. But actually it's also easy to use an existing docker image from the docker hub, e.g. the following code if you want a sandbox with node installed:
sandbox = DockerSSHBox(
   container_image="node:21"
)

It'd be nice to make it clear that creating your own custom image is optional.

ready for review.

This has been fixed by the linked PR, so I'll close it. Please re-open if that's not the case.


Remove brand icons?

Since we don't add any brand icons, I think we should remove the current ones. What do you think?

I agree

I agree, maybe we can move the current brand icons to a separate repo. I can image people want to use it

@locness3 @delnyn What about the idea, to create a separate package in packges folder called: 'lucide-brands'. We can move all the brand icons to this separate package, if people like to have this type of brand icons they can use the package.
In the readme we can notice that the brand icons are deprecated and we don't update/maintain them.

Oh yes! Should I clone this one and remove the icons?

I don't know, but I think it'd be best if people didn't use them.

How about create deprecated section for icons instead of completely removing them?

Just for the record, this is/was also a concern in the Feather project, where is stated that

simple-icons/simple-icons repository already covers everything, uses SVG and the same 24x24 viewBox, so it could be a great replacement for people that need brand icons.

Agreed. Brand icons have no business in icon sets.

soooo? we just delete them all?

I'm thinking of defining the ultimate v1.0 for Lucide and I think this should be a part of it.

what do you mean by "defining the ultimate v1.0 for Lucide"?

We are going with a lot of requests to add icons. I'm think split project. Part for medical, part for programing, part for brand , ... .
In this case, 'quality, version, update, ...' of each package are different.
In angular, we can one project for handle of use multi package icon library.

I don't understand lol

what do you mean by "defining the ultimate v1.0 for Lucide"?
@delnyn I will create a separate discussion for that later. I need write down some points for that.

@SMAH1 Hmm I'm not fan of this idea. I think it wil add some unnecessary complexity. And can be really confusion as well.

Yeah, I agree, and apart from adding a layer unnecessary complexity, this would introduce the problem of having to deal with icons overlapping multiple categories. Categorising icons sounds like a potentially useful feature, but it's partly accomplished already via tagging. I would maybe add very basic filtering on tags to the lucide.dev UI and make sure that icon categories are properly filled in within icon tags.

Hello guys,
If I can offer my 2 cents here, I do think it's fine to just remove them all-together.
There are other alternatives so it's fine, there's no need to overcomplicate things just for some existing icons.

if I may chime in, I agree. They should be removed, maybe moved to a seperate lucide-brands or depreciated repository--where people would be able to add more brand icons, if they wanted. But they wouldn't be part of the main lucide.
Especially since, due to lucides design guidelines, it's hard to accurately represent the logos while keeping them both recigniseable, good looking, and representative of the logo.

yeah I think everyone agrees. this issue is literally older than my brother, please someone remove the brand icons

Interesting

I think this is something we should do for lucide 1.0 and create a separate package, like @tryoxiss mentions.

From what I understand, these brand icons were removed, and the only way to get them now is to use simple-icons?

@Sawtaytoes They haven’t actually been removed yet, but will be. In any case, I will be maintaining my own lucide-brands fork retaining them and some more…

I understand the logic for not adding any new brand icons, but I'd be against removing the current ones from the package. They fit in really well with the design language of the other icons, and make it easier for users to get started with just the single icon library.

From what I understand, these brand icons were removed, and the only way to get them now is to use simple-icons?

@Sawtaytoes They haven’t actually been removed yet, but will be. In any case, I will be maintaining my own lucide-brands fork retaining them and some more…

A lucide-brands package would be great. I want to keep using the same style for all the icons, but I need brand icons especially for social media stuff. If a new package emerges I will try to contribute.

@devlulcas They currently exist on the brands branch of my fork here: https://github.com/danielbayley/lucide/commits/brands. I haven’t decided exactly what to do with them in a more canonical way, yet… There are also a growing number of icons from rejected PRs here, which also should live somewhere. Possibly something like lucide-brands, and/or lucide-extra[s] packages… But need an easy way to hook into Lucide to add them to the fonts…

I don't get it, these icons are useful, keep them 🥲

I don't get it, these icons are useful, keep them 🥲

My understanding is that there are 2 major issues with brand icons. Keep in mind, I am not a lawyer and this is just my understanding when I talk about the legalities, not legal advice.

Design Guidelines & Trademarks:  Only a small subset of brand icons could be legally added, as most brands dont allow you to modify thier logo (which would be required to meet lucides design guidelines). Additionally, many logos cannot be simplified to fit within lucides design guidelines even if it was legal to do so. There is simpleicons.org which gets around this by not modifying the logo, and is a good alternative as thier icons are on the same sized canvas. (its also just better to have thier actual logo as its more recogniseable)

Existing brand icons are shaky: For the same reason as above legally. Many existing brand icons (to me at least) feel like they dont fit with the rest of the lucide icon kit.

Because new icons cant/wont be added, it feels weird to keep them around and creates a burden for the maintainers. People see brand icons, suggest new brand icons, maintainers need to reference the brand icon deprecation issue. If there were no brand icons, this would be less of a problem. And yes, the icon request template already makes people check off that they are not requesting a brand icon, and it still happens a lot)

I don't get it, these icons are useful, keep them 🥲

My understanding is that there are 2 major issues with brand icons. Keep in mind, I am not a lawyer and this is just my understanding when I talk about the legalities, not legal advice.

Design Guidelines & Trademarks:  Only a small subset of brand icons could be legally added, as most brands dont allow you to modify thier logo (which would be required to meet lucides design guidelines). Additionally, many logos cannot be simplified to fit within lucides design guidelines even if it was legal to do so. There is simpleicons.org which gets around this by not modifying the logo, and is a good alternative as thier icons are on the same sized canvas. (its also just better to have thier actual logo as its more recogniseable)
Existing brand icons are shaky: For the same reason as above legally. Many existing brand icons (to me at least) feel like they dont fit with the rest of the lucide icon kit.
Because new icons cant/wont be added, it feels weird to keep them around and creates a burden for the maintainers. People see brand icons, suggest new brand icons, maintainers need to reference the brand icon deprecation issue. If there were no brand icons, this would be less of a problem. And yes, the icon request template already makes people check off that they are not requesting a brand icon, and it still happens a lot)

I'm not a lawyer either, correct me if i'm wrong, i think this is common sense:

Follow the guidelines, give the user the option to change the icon as they please so the burden of legality falls in the user not the library.
Ignore if it fits or not, this is a library and people do whatever they want with it anyway, make an exception for the brand logos and put it in a different category.
People will still ask for brand logos anyway, gash they are used everywhere, add them, leave it to the user to deal with the legal matters.

IMO this will force me, and others to look for libraries that contains these icons. Or add multiple libraries? Is this what we really want?

I don't get it, these icons are useful, keep them 🥲

My understanding is that there are 2 major issues with brand icons. Keep in mind, I am not a lawyer and this is just my understanding when I talk about the legalities, not legal advice.

Design Guidelines & Trademarks:  Only a small subset of brand icons could be legally added, as most brands dont allow you to modify thier logo (which would be required to meet lucides design guidelines). Additionally, many logos cannot be simplified to fit within lucides design guidelines even if it was legal to do so. There is simpleicons.org which gets around this by not modifying the logo, and is a good alternative as thier icons are on the same sized canvas. (its also just better to have thier actual logo as its more recogniseable)
Existing brand icons are shaky: For the same reason as above legally. Many existing brand icons (to me at least) feel like they dont fit with the rest of the lucide icon kit.
Because new icons cant/wont be added, it feels weird to keep them around and creates a burden for the maintainers. People see brand icons, suggest new brand icons, maintainers need to reference the brand icon deprecation issue. If there were no brand icons, this would be less of a problem. And yes, the icon request template already makes people check off that they are not requesting a brand icon, and it still happens a lot)

I'm not a lawyer either, correct me if i'm wrong, i think this is common sense:
1. Follow the guidelines, give the user the option to change the icon as they please so the burden of legality falls in the user not the library.

2. Ignore if it fits or not, this is a library and people do whatever they want with it anyway, make an exception for the brand logos and put it in a different category.

3. People will still ask for brand logos anyway, gash they are used everywhere, add them, leave it to the user to deal with the legal matters.

IMO this will force me, and others to look for libraries that contains these icons. Or add multiple libraries? Is this what we really want?

Providing the icon at all may make it fall on the library. It is often literally impossible to follow both Lucides design guidelines and the brand logo guidelines.
Saying "ignore if it fits" on a library almost entirely built around having icons that fit together is a really weak point.
Probably less, but even if not it takes effort to add them -- effort that nobody wants to do. If its so simple create your own library for brand icons following the Lucide guidelines.

Yes, but it is very common practice to use different libraries for most icons and brand icons, assuming you need brand icons at all (most projects dont). You dont even need to add another library for them, you can just copy+paste SVG code.
At any rate this issue is pretty settled, all the mainers seem to want to remove brand icons and its a decision the vast majority of the community seems to agree with. I was just trying to be helpful and give you the reasoning why to my understanding.

I don't get it, these icons are useful, keep them 🥲

My understanding is that there are 2 major issues with brand icons. Keep in mind, I am not a lawyer and this is just my understanding when I talk about the legalities, not legal advice.

Design Guidelines & Trademarks:  Only a small subset of brand icons could be legally added, as most brands dont allow you to modify thier logo (which would be required to meet lucides design guidelines). Additionally, many logos cannot be simplified to fit within lucides design guidelines even if it was legal to do so. There is simpleicons.org which gets around this by not modifying the logo, and is a good alternative as thier icons are on the same sized canvas. (its also just better to have thier actual logo as its more recogniseable)
Existing brand icons are shaky: For the same reason as above legally. Many existing brand icons (to me at least) feel like they dont fit with the rest of the lucide icon kit.
Because new icons cant/wont be added, it feels weird to keep them around and creates a burden for the maintainers. People see brand icons, suggest new brand icons, maintainers need to reference the brand icon deprecation issue. If there were no brand icons, this would be less of a problem. And yes, the icon request template already makes people check off that they are not requesting a brand icon, and it still happens a lot)

I'm not a lawyer either, correct me if i'm wrong, i think this is common sense:
1. Follow the guidelines, give the user the option to change the icon as they please so the burden of legality falls in the user not the library.

2. Ignore if it fits or not, this is a library and people do whatever they want with it anyway, make an exception for the brand logos and put it in a different category.

3. People will still ask for brand logos anyway, gash they are used everywhere, add them, leave it to the user to deal with the legal matters.

IMO this will force me, and others to look for libraries that contains these icons. Or add multiple libraries? Is this what we really want?

Providing the icon at all may make it fall on the library in addition to the user. It is often literally impossible to follow both Lucides design guidelines and the brand logo guidelines, so its better to just not.
Saying "ignore if it fits" on a library almost entirely built around having icons that fit together is a really weak point. And if your making an exception for brand logos, just use a different library or get the brand icons directly from the source. If not in lucides style, why should lucide add them at all?
Probably less, but even if not it takes effort to add them -- effort that nobody wants to do. If its so simple create your own library for brand icons following the Lucide guidelines.

Yes, but it is very common practice to use different libraries for most icons and brand icons, assuming you need brand icons at all (most projects dont). You dont even need to add another library for them, you can just copy+paste SVG code.
At any rate this issue is pretty settled, all the mainers seem to want to remove brand icons and its a decision the vast majority of the community seems to agree with. I was just trying to be helpful and give you the reasoning why to my understanding.

I get it, I do appreciate your insight in this matter, I'm just a little bit frustrated because this library has been my go to solution for everything, but now I'll have to depend on another library just for brand logos which is sad. But as a developer, I get it. Thanks


python3Packages.vsure: 1.7.3 -> 1.8.1

Motivation for this change
Update to latest upstream release 1.8.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118177 at e89f2620 run on aarch64-linux 1

2 packages built successfully:

python38Packages.vsure
python39Packages.vsure

Result of nixpkgs-review pr 118177 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.vsure
python39Packages.vsure


NodPort doesn't work correctly when VLANs are involved

Bug report
Cilium version: 1.9.1
Kernel: 5.9.0-0.bpo.2-amd64
If you have an interface, say enp36s0f0, for internal traffic and than enp36s0f0.10 (that is tagged VLAN on the same physical interface) for external traffic than if the traffic is coming from the external side and is routed into internal, POD ips can be accessed, but NodePort (and anything that relies on them) does not work.
I have originally asked about this on slack, here is the original question <IP_ADDRESS>/24 network is on the tagged VLAN interface (enp36s0f0.10) and <IP_ADDRESS>/24 is on the untagged one (enp36s0f0):
i have two networks (<IP_ADDRESS>/24 and <IP_ADDRESS>/24) - the kubernetes cluster with cilium is in the 46 network - there is a router (with <IP_ADDRESS> and <IP_ADDRESS> as ip addresses) which doubles as control plane node, one normal worker node (<IP_ADDRESS>) and i also have one computer in 46 network, that is not running kubernetes or any cilium daemons (<IP_ADDRESS>) - the default gw in the 55 knows to route 46 network as well as POD CIDR (<IP_ADDRESS>/16) through <IP_ADDRESS>
Now i try to create NodePort service - POD is running on the worker node (.46.10). externalTrafficPolicy: Cluster. I see that cilium creates all the correct services (cilium service list) and it got port - 30698
Now from the .46.1 computer i can access this service on all addresses (<IP_ADDRESS>:30698, <IP_ADDRESS>:30698, <IP_ADDRESS>:30698), same on the .46.10 worker node and same for the .46.200 (which has .46.1 as default gw, but is not running any kubernetes or cilium)
But if i try to access this NodePort service from the <IP_ADDRESS>/24 network, it doesn't work as expected. I can access the service on <IP_ADDRESS>:30698 but i can't access the NodePort service neither on <IP_ADDRESS>:30698 or <IP_ADDRESS>:30698.

Just to accept the bug and to add the reason.
Cilium status:
KVStore:                     Ok   Disabled
Kubernetes:                  Ok   1.20 (v1.20.2) [linux/amd64]
Kubernetes APIs:             ["cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Service", "discovery/v1beta1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:        Strict   [wan0, wan0.4000 (Direct Routing)]
Cilium:                      Ok       OK
NodeMonitor:                 Listening for events on 32 CPUs with 64x4096 of shared memory
IPAM:                        IPv4: 20/255 allocated from <IP_ADDRESS>/24,
BandwidthManager:            Disabled
Host Routing:                BPF
Masquerading:                BPF   [wan0, wan0.4000]   <IP_ADDRESS>/16
Controller Status:           89/89 healthy
Proxy Status:                OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Hubble:                      Ok              Current/Max Flows: 637/4096 (15.55%), Flows/s: 10.63   Metrics: Disabled
Cluster health:              0/3 reachable   (2021-01-18T18:41:29Z)
  Name                       IP              Node        Endpoints
  xxxxxx-dev-1 (localhost)   <IP_ADDRESS>    reachable   unreachable
  xxxxxx-dev-2               <IP_ADDRESS>    reachable   unreachable
  xxxxxx-dev-3               <IP_ADDRESS>    reachable   unreachable

Cilium metrics list:
cilium_drop_bytes_total                               direction="EGRESS" reason="Unsupported L3 protocol"                                               7560.000000
cilium_drop_bytes_total                               direction="EGRESS" reason="Unsupported protocol for NAT masquerade"                               25819.000000
cilium_drop_count_total                               direction="EGRESS" reason="Unsupported L3 protocol"                                               104.000000
cilium_drop_count_total                               direction="EGRESS" reason="Unsupported protocol for NAT masquerade"                               253.000000

When using tcpdump I can see that packet which is targeted for wan0.4000 (vlan tagged interface) will appear on wan0 and after that cilium will drop it. With cilium disabled on wan0 packet will appear on wan0 (tagged) and after that I can see it on wan0.4000. CIlium should skip processing vlan tagged packets on interfaces and allow them to be processed in kernel before cilium will be able to process them on proper interface (untagged).

Just to accept the bug and to add the reason.
Cilium status:
KVStore:                     Ok   Disabled
Kubernetes:                  Ok   1.20 (v1.20.2) [linux/amd64]
Kubernetes APIs:             ["cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Namespace", "core/v1::Node", "core/v1::Pods", "core/v1::Service", "discovery/v1beta1::EndpointSlice", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement:        Strict   [wan0, wan0.4000 (Direct Routing)]
Cilium:                      Ok       OK
NodeMonitor:                 Listening for events on 32 CPUs with 64x4096 of shared memory
IPAM:                        IPv4: 20/255 allocated from <IP_ADDRESS>/24,
BandwidthManager:            Disabled
Host Routing:                BPF
Masquerading:                BPF   [wan0, wan0.4000]   <IP_ADDRESS>/16
Controller Status:           89/89 healthy
Proxy Status:                OK, ip <IP_ADDRESS>, 0 redirects active on ports 10000-20000
Hubble:                      Ok              Current/Max Flows: 637/4096 (15.55%), Flows/s: 10.63   Metrics: Disabled
Cluster health:              0/3 reachable   (2021-01-18T18:41:29Z)
  Name                       IP              Node        Endpoints
  xxxxxx-dev-1 (localhost)   <IP_ADDRESS>    reachable   unreachable
  xxxxxx-dev-2               <IP_ADDRESS>    reachable   unreachable
  xxxxxx-dev-3               <IP_ADDRESS>    reachable   unreachable

Cilium metrics list:
cilium_drop_bytes_total                               direction="EGRESS" reason="Unsupported L3 protocol"                                               7560.000000
cilium_drop_bytes_total                               direction="EGRESS" reason="Unsupported protocol for NAT masquerade"                               25819.000000
cilium_drop_count_total                               direction="EGRESS" reason="Unsupported L3 protocol"                                               104.000000
cilium_drop_count_total                               direction="EGRESS" reason="Unsupported protocol for NAT masquerade"                               253.000000

When using tcpdump I can see that packet which is targeted for wan0.4000 (vlan tagged interface) will appear on wan0 and after that cilium will drop it. With cilium disabled on wan0 packet will appear on wan0 (tagged) and after that I can see it on wan0.4000. CIlium should skip processing vlan tagged packets on interfaces and allow them to be processed in kernel before cilium will be able to process them on proper interface (untagged).

I wonder, what happens if you configure the --devices flag to specify the VLAN device?

I wonder, what happens if you configure the --devices flag to specify the VLAN device?

This problem will not occur. Cilium will not filter packets on wan0 in case only wan0.4000 will be in devices list. But this will lead to another bug (at least for me) - cilium will not masquerade packets on wan0 which is used to connect to internet from pods. The only way to have setup working is adding two options: --set bpf.masquerade=false and --set devices=wan0.4000. But this isn't what we want :)

This problem will not occur. Cilium will not filter packets on wan0 in case only wan0.4000 will be in devices list. But this will lead to another bug (at least for me) - cilium will not masquerade packets on wan0 which is used to connect to internet from pods. The only way to have setup working is adding two options: --set bpf.masquerade=false and --set devices=wan0.4000. But this isn't what we want :)

During all my tests, i had masquerade: "false" in the ConfigMap
for devices i tried only untahhed and tagged + untagged interfaces

During all my tests, i had masquerade: "false" in the ConfigMap
for devices i tried only untahhed and tagged + untagged interfaces

Discussed offline: validate_ethertype() on wan0 drops the tagged packet. One possible solution is to pass the packet to the stack. The kernel should pop the VLAN header and then reinsert into RX queue, which eventually should lead to the bpf_host invocation attached to wan0.4000.

Discussed offline: validate_ethertype() on wan0 drops the tagged packet. One possible solution is to pass the packet to the stack. The kernel should pop the VLAN header and then reinsert into RX queue, which eventually should lead to the bpf_host invocation attached to wan0.4000.

I would really like to see this fixed, as this prevents us from using Cilium


OSError: undefined symbol: __glewBindBuffer

Hello,when  I run PlaNet with the terminal in (ubuntu18.04,cuda10.0.130,cudnn7.3.1) :
python3 -m planet.scripts.train   --logdir ~/planet-master   --config default     --params '{tasks: [cheetah_run]}'
WARNING:tensorflow:Worker c14e0611-dcb3-43a0-86c5-a886b569ae93 run 00001: Start.
INFO:tensorflow:Collecting 5+ random episodes (test-cheetah_run).
I0403 21:33:35.180162<PHONE_NUMBER>75488 acceleratesupport.py:17] No OpenGL_accelerate module loaded: No module named 'OpenGL_accelerate'
I0403 21:33:35.266633<PHONE_NUMBER>75488 init.py:34] MuJoCo library version is: 200
INFO:tensorflow:Recorded episode 20190403T213335-5db0f651f77f497b99b330fb21a99663.
INFO:tensorflow:Recorded episode 20190403T213336-83adee5b7a1f40b1ad00c088885ae486.
INFO:tensorflow:Recorded episode 20190403T213336-458015a378c743fd8e223033725bbd2a.
INFO:tensorflow:Recorded episode 20190403T213337-cbd989f537834e3aa6c4629e18dcae4c.
INFO:tensorflow:Recorded episode 20190403T213337-7817524fc36d4f87a8d48e266941b6bd.
INFO:tensorflow:Collecting 5+ random episodes (train-cheetah_run).
INFO:tensorflow:Recorded episode 20190403T213338-6ab268afed1f486298a7c8530413f8af.
INFO:tensorflow:Recorded episode 20190403T213338-58d74c263fb145568708e5695b2e7d3a.
INFO:tensorflow:Recorded episode 20190403T213338-d77039b59d9a4773a8a2b7ef40aa6f69.
INFO:tensorflow:Recorded episode 20190403T213339-12edd59a999a4aa0ade7c61c7a9aa54c.
INFO:tensorflow:Recorded episode 20190403T213339-26402c3b172d40dba29992c0a8134687.
WARNING:tensorflow:From /home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/data/ops/dataset_ops.py:429: py_func (from tensorflow.python.ops.script_ops) is deprecated and will be removed in a future version.
Instructions for updating:
tf.py_func is deprecated in TF V2. Instead, use
tf.py_function, which takes a python function which manipulates tf eager
tensors instead of numpy arrays. It's easy to convert a tf eager tensor to
an ndarray (just call tensor.numpy()) but having access to eager tensors
means tf.py_functions can use accelerators such as GPUs as well as
being differentiable using a gradient tape.
WARNING:tensorflow:From /home/lls/planet-master/planet/tools/preprocess.py:24: to_float (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.cast instead.
INFO:tensorflow:Start a new run and write summaries and checkpoints to /home/lls/planet-master/00001.
WARNING:tensorflow:From /home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/framework/op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
INFO:tensorflow:Build TensorFlow compute graph.
WARNING:tensorflow:From /home/lls/planet-master/planet/networks/conv_ha.py:30: conv2d (from tensorflow.python.layers.convolutional) is deprecated and will be removed in a future version.
Instructions for updating:
Use keras.layers.conv2d instead.
WARNING:tensorflow:From /home/lls/planet-master/planet/networks/conv_ha.py:34: flatten (from tensorflow.python.layers.core) is deprecated and will be removed in a future version.
Instructions for updating:
Use keras.layers.flatten instead.
WARNING:tensorflow:From /home/lls/planet-master/planet/tools/overshooting.py:80: dynamic_rnn (from tensorflow.python.ops.rnn) is deprecated and will be removed in a future version.
Instructions for updating:
Please use keras.layers.RNN(cell), which is equivalent to this API
WARNING:tensorflow:From /home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py:626: to_int32 (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.cast instead.
WARNING:tensorflow:From /home/lls/planet-master/planet/models/rssm.py:94: dense (from tensorflow.python.layers.core) is deprecated and will be removed in a future version.
Instructions for updating:
Use keras.layers.dense instead.
WARNING:tensorflow:Worker c14e0611-dcb3-43a0-86c5-a886b569ae93 run 00001: Exception:
Traceback (most recent call last):
File "/home/lls/planet-master/planet/training/running.py", line 198, in iter
for value in self._process_fn(self._logdir, *args):
File "/home/lls/planet-master/planet/scripts/train.py", line 91, in process
training.define_model, dataset, logdir, config):
File "/home/lls/planet-master/planet/training/utility.py", line 160, in train
score, summary = model_fn(data, trainer, config)
File "/home/lls/planet-master/planet/training/define_model.py", line 71, in define_model
config.overshooting + 1)
File "/home/lls/planet-master/planet/tools/overshooting.py", line 80, in overshooting
swap_memory=True)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/util/deprecation.py", line 324, in new_func
return func(*args, **kwargs)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py", line 671, in dynamic_rnn
dtype=dtype)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py", line 879, in _dynamic_rnn_loop
swap_memory=swap_memory)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3556, in while_loop
return_same_structure)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3087, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3022, in _BuildLoop
body_result = body(*packed_vars_for_body)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/control_flow_ops.py", line 3525, in
body = lambda i, lv: (i + 1, orig_body(*lv))
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py", line 845, in _time_step
skip_conditionals=True)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py", line 276, in _rnn_step
new_output, new_state = call_cell()
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn.py", line 833, in
call_cell = lambda: cell(input_t, state)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/ops/rnn_cell_impl.py", line 234, in call
return super(RNNCell, self).call(inputs, state)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/layers/base.py", line 534, in call
_add_elements_to_collection(self.updates, ops.GraphKeys.UPDATE_OPS)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 653, in updates
return self._updates + self._gather_children_attribute('updates')
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1646, in _gather_children_attribute
getattr(layer, attribute) for layer in self._layers))
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1646, in
getattr(layer, attribute) for layer in self._layers))
AttributeError: 'Template' object has no attribute 'updates'
How to deal with this error?Thank you  ^_^

What's your TensorFlow version? Does it match the one mentioned in the readme?

yes,  tensorflow-gpu==1.13.1 and tensorflow-probability==0.6.0
But the code was downloaded two weeks ago. When I run the lastest code version ,this error is gone.
When I click the PyCharm's RUN button ,it runs successfully.But when I use the  terminal with the same interpreter ,another error raised:
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Create directory '/home/lls/download/planet-master/00001'.
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Start.
INFO:tensorflow:Collecting 5 initial episodes (test-cheetah_run).
W0404 09:47:12.196148<PHONE_NUMBER>66816 init.py:36] mjbindings failed to import mjlib and other functions. libmujoco.so may not be accessible.
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Exception:
Traceback (most recent call last):
File "/home/lls/download/planet-master/planet/training/running.py", line 199, in iter
for value in self._process_fn(self._logdir, *args):
File "/home/lls/download/planet-master/planet/scripts/train.py", line 64, in process
training.utility.collect_initial_episodes(config)
File "/home/lls/download/planet-master/planet/training/utility.py", line 286, in collect_initial_episodes
control.random_episodes(params.task.env_ctor, remaining, outdir)
File "/home/lls/download/planet-master/planet/control/random_episodes.py", line 23, in random_episodes
env = env_ctor()
File "/home/lls/download/planet-master/planet/scripts/tasks.py", line 120, in _dm_control_env
from dm_control import suite
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/suite/init.py", line 28, in
from dm_control.suite import acrobot
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/suite/acrobot.py", line 24, in
from dm_control import mujoco
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/init.py", line 18, in
from dm_control.mujoco.engine import action_spec
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/engine.py", line 44, in
from dm_control.mujoco import index
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/index.py", line 92, in
from dm_control.mujoco.wrapper import util
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/init.py", line 25, in
from dm_control.mujoco.wrapper.core import callback_context
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/core.py", line 32, in
from dm_control.mujoco.wrapper.mjbindings import functions
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/mjbindings/functions.py", line 21, in
mjlib = util.get_mjlib()
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/util.py", line 127, in get_mjlib
return ctypes.cdll.LoadLibrary(library_path)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/ctypes/init.py", line 426, in LoadLibrary
return self._dlltype(name)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/ctypes/init.py", line 348, in init
self._handle = _dlopen(self._name, mode)
OSError: /home/lls/.mujoco/mujoco200_linux/bin/libmujoco200.so: undefined symbol: __glewBindBuffer

Yes, I added support for TensorFlow 1.13.1 in a recent update. Your new issue is related to rendering in dm_control. Did you follow the instructions in the dm_control readme? If this doesn't work for you please try all three rendering options ('glfw, egl, osmesa`).

Yes,the mujuco 200 was installed successfully,and then I use the "pip install git+git://github.com/deepmind/dm_control.git".I can see the dm_control 0.0.0 pkgs in interpreter package lists

Did you try the different rendering options? If that doesn't work, please try to create a dm_control environment (suite.load('cheetah', 'run')) and render it (env.physics.render()) in a self-contined script outside of the PlaNet code.

Thank you.I will have a try.

Closing this for now. If you still run into problems please comment here so we can reopen it.

yes, tensorflow-gpu==1.13.1 and tensorflow-probability==0.6.0
But the code was downloaded two weeks ago. When I run the lastest code version ,this error is gone.
When I click the PyCharm's RUN button ,it runs successfully.But when I use the terminal with the same interpreter ,another error raised:
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Create directory '/home/lls/download/planet-master/00001'.
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Start.
INFO:tensorflow:Collecting 5 initial episodes (test-cheetah_run).
W0404 09:47:12.196148<PHONE_NUMBER>66816 init.py:36] mjbindings failed to import mjlib and other functions. libmujoco.so may not be accessible.
WARNING:tensorflow:Worker 7c829fd1-681c-463d-a6ed-e2cd118d29a1 run 00001: Exception:
Traceback (most recent call last):
File "/home/lls/download/planet-master/planet/training/running.py", line 199, in iter
for value in self._process_fn(self._logdir, *args):
File "/home/lls/download/planet-master/planet/scripts/train.py", line 64, in process
training.utility.collect_initial_episodes(config)
File "/home/lls/download/planet-master/planet/training/utility.py", line 286, in collect_initial_episodes
control.random_episodes(params.task.env_ctor, remaining, outdir)
File "/home/lls/download/planet-master/planet/control/random_episodes.py", line 23, in random_episodes
env = env_ctor()
File "/home/lls/download/planet-master/planet/scripts/tasks.py", line 120, in _dm_control_env
from dm_control import suite
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/suite/init.py", line 28, in
from dm_control.suite import acrobot
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/suite/acrobot.py", line 24, in
from dm_control import mujoco
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/init.py", line 18, in
from dm_control.mujoco.engine import action_spec
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/engine.py", line 44, in
from dm_control.mujoco import index
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/index.py", line 92, in
from dm_control.mujoco.wrapper import util
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/init.py", line 25, in
from dm_control.mujoco.wrapper.core import callback_context
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/core.py", line 32, in
from dm_control.mujoco.wrapper.mjbindings import functions
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/mjbindings/functions.py", line 21, in
mjlib = util.get_mjlib()
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/site-packages/dm_control/mujoco/wrapper/util.py", line 127, in get_mjlib
return ctypes.cdll.LoadLibrary(library_path)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/ctypes/init.py", line 426, in LoadLibrary
return self._dlltype(name)
File "/home/lls/anaconda3/envs/planet-master/lib/python3.6/ctypes/init.py", line 348, in init
self._handle = _dlopen(self._name, mode)
OSError: /home/lls/.mujoco/mujoco200_linux/bin/libmujoco200.so: undefined symbol: __glewBindBuffer

I see the same problem, because the pycharm can't load the LD_LIBRARY_PATH of .bashrc.
I resolved this problem after starting PyCharm from the terminal.


Handle local timezone

Now in data file is written only time without timezone (in GMT?) and duration. So today's statistics is not always correct. For correct today's statistics use system timezone for compute statistics.

To get system timezone from php, run:
/bin/ls -l /etc/localtime | /usr/bin/cut -d '/' -f 8,9
More info: https://stackoverflow.com/a/32604655

+1 to this! Was going to open an issue for the same thing. I was wondering why my build time was so low last night.
(Plugin in great btw!)

Resolved. You can update with "About -> Update" directly from the plugin


Add CD for project PRs

Need to add Continuous Delivery for new functionality after merging PRs

It should be resolved after #16

Little detail: ${GIHUB_REF:11} -> when tags like "v1.0" is update it to "1.0"
Every new release should use tags like "vX.X" where "X.X" is version of leetty-parent


split plugin add yum repo by url

Since we are able to squash, there's pretty much no need for injecting yum calls inside dockerfile. Much nicer way will be to add repos with ADD, install packages and remove repos (RUN rm /etc/yum.repos.d/*) -- exactly what "add yum repo by url" plugin does. Therefore I think we should split the functionality of the plugin to two:

fetch plugin: downloads repo files from web
add plugin: hooks repos to build process by adding ADD and RUN rm ...

I'm not sure about the first one, how exactly should the plugin operate:

put repo configuration to workflow.repos object
add plugin will take everything from the workflow.repos, creates repo file out of it and adds instructions in dockerfile

or

fetch plugin downloads repo files, store them in image
add plugin will use downloaded files and also creates repo files from whatever is in workflow.repos

@twaugh what do you think?

I'm not sure of the utility of splitting fetching from adding. I can see that it might be useful to make it into a more generic 'fetch, add, remove' operation, without assuming it needs to add fetched content to /etc/yum.repos.d/, though.
Do you mean that several plugins might want to use fetch separately, and then add would deal with them all at once? I'm trying to think of a use-case.

Right! My use case is that I want to use plugin which

will provide same functionality as plugin inject_yum_repo
can be used together with koji plugin

Essentially I want to take output of koji plugin and stuff that repo in dockerfile the same way add_yum_repo_by_url plugin does.
Does that make sense?

I see, got it. So how about this?:
{
    'name': 'fetch',
    'args': {
        'files': {
            '/etc/yum.repos.d/repo1.repo': 'https://example.com/repo1.repo',
            '/etc/yum.repos.d/repo2.repo': 'https://example.com/repo2.repo'
        }
    }
},
{
    'name': 'add'
}

where the pre_fetch plugin simply populates workflow.tmpconfig with the filename:url dict entries.

so the koji plugin should store the repo file to the workflow.tmpconfig?

Yes, that's what I'm thinking.
self.workflow.tmpconfig['/etc/yum.repos.d/koji.repo'] = ...

So the value of that key in the dict will be content of the repo file?

Oh, good point. Yes, let's do that. ;-)
self.workflow.tmpconfig['/etc/yum.repos.d/koji.repo'] = b'[fedora]\nname=...'`

Sounds great! Will you have time to work on that? I really would like have this thing done this week (meaning, if you don't have time, I can take care of this tomorrow).

@adamruzicka since you are using yum_inject plugin: we are planning to change behavior of the plugin so by default it injects repos by doing ADD repos/* and RUN rm /etc/yum.repos.d/*. Since we are able to squash layers, we know that no leftovers from yum will be in final image (nor in any of its layers). You can get the former functionality by using switch wrap_commands=True (it's False by default). This patch also changes the way plugins pass yum repos: there's variable files now on workflow object:
files["/etc/yum.repos.d/my.repo"] = "[my-repo]\nname=my-repo\n..."

I would like to merge this patch soon but certainly don't want break your workflow. Are there any concerns from your side?

@TomasTomecek we were using yum_inject only in the early stages before we switched to subscription-manager, so you don't have to worry about breaking my workflow.
I really like the way how injecting repos should work with this patch


issue on ios6

ios6 can't support auto layout margin,

how to resolve it? please help me.

@zhigangfang You can use a version before margins was added https://github.com/SnapKit/Masonry/tree/1ff3602d1c54cfd12be49bf44a3c3bc45b02b258


Expose UDP Services on Azure Container Apps

Is there a way to expose UDP Services running on Azure Container Apps?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 307a2025-0f86-5d45-dba6-7c859c4313e7
Version Independent ID: 171ef08d-42f2-c473-e6ab-469bf20cc11d
Content: Set up HTTPS ingress in Azure Container Apps Preview
Content Source: articles/container-apps/ingress.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@TimoWilhelm , thank you for your query. We'll investigate on this and get back to you shortly!

So....any update to this?

Apologies for the delay on this, Mike and Timo.   @craigshoemaker, requesting your comments on this. Thanks!

I'm interested on UDP ingress too.
Any updates on this request?
Thanks a lot!

Also interested in this, anything new to report?

@TimoWilhelm Thank you for your question.  Unfortunately, UDP ingress is not currently supported by Container Apps, therefore we do not include such information in our articles.   You can file a feature request here: https://github.com/microsoft/azure-container-apps
#please-close

Hi all, any news about this feature?
Is support for UDP in Container Apps in roadmap?
Thanks a lot

Its 2024, is no one working on this yet?

Cmon MS. This is basic stuff. Please support

@craigshoemaker hello, do you guys have any plans on implementing this feature any time soon?


[Doc] Add add_months() document

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_admit_test

@mergift branch-2.5 branch-2.4 branch-2.3

@mergify branch-2.5 branch-2.4 branch-2.3


Document what we decided the max subtree width should be in ADR13

https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md

Related https://github.com/celestiaorg/celestia-app/issues/1607


Change bindShared to singleton due to deprecation since Laravel 5.1

Since this is a bugfix to make it work with laravel 5.2 Projects, please tag a new version after merge as well. Thanks :smile:

+1 for the fix, please add this ASAP

Until this was fixed, you can use my fork in your composer.json as repo to make it work with laravel 5.2.
Add this to your composer.json:
"repositories": [
    {
      "type": "git",
      "url": "https://github.com/okaufmann/Notifynder.git"
    }
]

and then use dev-master as version tag.


Update

ADD ISSUE DESCRIPTION HERE
Version: 1.75.1
Commit: 441438abd1ac652551dbe4d408dfcec8a499b8bf
User Agent: Mozilla/5.0 (Linux; Android 12; SAMSUNG SM-A217F) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/19.0 Chrome/102.0.5005.125 Mobile Safari/537.36
Embedder: github.dev

Please provide details for the issues you are running into help troubleshoot.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!


Polish

New translation.
For the website I have to finish (I send you email with questions about this).

Hey! Thanks for your work, that's really cool!
But, I see two pull requests, which one should I merge?

I think both, the first one it's about core, and the second one - I create new branch and start translation for the website. Sow I think you should merge both requests (I just starting with github ;) )

Ok, I'm going to merge only this one since the core translation is also there :)

Yes, I replied to your email :)

Can I update the application with your current translations for core? Or they're not completed yet. (for core only, I'm not talking about website)

Yes, you can. Even better, when you update app - then I can check what should be better for polish people.

Sure, hold on a few minutes, I'm updating it.

Seems there are errors in the json file. I'm looking at it. Please tell me if you find an error.

Yes, I found one.
It's comma in the 230 line

I corrected, thanks :+1:

That was the error?

The error was the comma thing ;)


Added Security Advisory

You should keep track of CVEs.

That is a bogus CVE number. Assignments are not done with dates, and the date even has a typo. This makes no sense.

@Foxboron: Fine, fixed, used number - still getting used to 2019 ;)

It's still a bogus CVE and not assigned.
https://cve.mitre.org/cve/identifiers/index.html

@Foxboron: Removed bogus id, replaced with TODO.

I'm not of the opinion that this was ever an actual vulnerability with the product as deployed. You had to launch the program using a debug flag, which none of the default launchers used. So, to insinuate that this requires some sort of security advisory packaged with the software itself just seems overblown.

@nneonneo: It may have originally been intentional, given that up to (almost) now, the users were probably informed of this "feature", or the environment was such that this doesn't matter.
However, with the public release, that changed, and so the feature becomes a vulnerability.
You should always account for the fact that your users don't run your programs with the default settings, and not in the default environment, with a potentially deactivated/inactive/malfunctioning firewall.
  I'm not aware of any that do...  IMO there are better ways to present this information to the user.  For instance, I'd be in favor of a "Known Issues" section on the wiki that lists potential problems like this one, along with the conditions required for the issue to occur and the ramifications for the user.  Then, once the issue has been addressed, it can be easily removed from the "Known Issues" section into the Changelog / Release Notes.

@recvfrom: Well, the best way to deal with security problems in source-code is to quietly fix them upstream right away and don't mark the commit as security fix, so nobody notices it in the first place, and push the code along with a lot of other stuff,  like Torvalds does.
That said, Linux & associated software has a package manager that automatically updates all software on your computer.
So if you contact the owner of the repo, it will be quietly pushed on all machines.
However, as with non-packaged software, or on Windows, this won't be the case.
So the best way to deal with the issue is by way of automatic update checks, like google chrome.
Then update the software right away the next time the user starts it (or every hour or so if it's running).
And have a seperate issue tracker for security related bugs.
Problems like this don't belong in a wiki section that nobody reads.
Best way would be to fix the problem, and not (publicly) document it in the first place, and then quietly update old installs.

@ststeiger:

So if you contact the owner of the repo, it will be quietly pushed on all machines.

Lol wut? What Linux distribution are you running, doing rogue stuff like that? :joy:
Also, since when is security by obscurity a good idea? :joy:

@recvfrom: Well, the best way to deal with security problems in source-code is to quietly fix them upstream right away and don't mark the commit as security fix, so nobody notices it in the first place, and push the code along with a lot of other stuff, like Torvalds does.
That said, Linux & associated software has a package manager that automatically updates all software on your computer.
So if you contact the owner of the repo, it will be quietly pushed on all machines.
However, as with non-packaged software, or on Windows, this won't be the case.
So the best way to deal with the issue is by way of automatic update checks, like google chrome.
Then update the software right away the next time the user starts it (or every hour or so if it's running).
And have a seperate issue tracker for security related bugs.
Problems like this don't belong in a wiki section that nobody reads.
Best way would be to fix the problem, and not (publicly) document it in the first place, and then quietly update old installs.

Just because someone does something doesn't mean it's right.

https://youtu.be/866olNIzbrk
That being said, while its not a "vulnerability", it is indeed a default configuration problem. Also, can we not argue here? Its very unprofessional. As far as I can see, there are 2 choices:

Wait for the full open source release, then update the launch scripts.
Per Recv

https://youtu.be/866olNIzbrk
That being said, while its not a "vulnerability", it is indeed a default configuration problem. Also, can we not argue here? Its very unprofessional.
As far as I can see, there are 2 choices:
1.Wait for the full open source release, then update the launch scripts.
2.Per recvfrom's idea, add this to a known issues list along with any other known issues.

It looks like this also affects windows, since there is a similar line in launch.bat at line 140

The debug mode is part of the main jar file. All the scripts do is set a flag that tells Ghidra to go into debug mode with the provided parameters.

OK.
So regardless if debug mode is enabled, this should be updated in launch.bat, in case someone enables debug mode (if its not enabled by default)

Not enabled by default, but still a safe bet to update the script per release of the source code or for a more proper notice to be placed in the repository.

The mechanism proposed in this pull request to document security bugs does not strike me as being a good way to communicate security bugs. For one, I don't think it is a good idea to cite Twitter or archives of 3rd party private companies websites containing self-described exploits, in order to communicate vulnerabilities to affected users, as the proposed change in this pull request does.
Further, if any citations of vulnerabilities are gathered and listed by the project under the term "CVE", I would expect citations to be limited to official entries in the CVE database or the NVD. It is misleading to list items as CVEs when there exists no such entry in the CVE database, and such misleading items bypass the standard scoring mechanisms used by such curated databases in favor of individual personal opinions about severity. This does not seem like a good idea, either.
I think there are better alternatives to this proposal, including (options for consideration by the developer team): collecting serious bugs in a "Known Issues" section of a previous release's release notes (if such notes are documented in a central location, such as attached to release tags in GitHub), collecting them on a project wiki, such as the wiki associated with the GitHub repository, linking directly to the search results at the CVE and/or NVD websites, tagging GitHub issues with a label named "security", among other options.
Because I think there are better alternatives to consider for communicating serious issues to users, it is my personal opinion that this issue should be closed, with thanks for the suggestion. Of course, that's not to say that the interest in having such things documented should be ignored. Rather, I think some of the alternatives should be considered instead of this PR.

@Hacksawfred3232 I'm sorry for the thumbs down, must have misclicked and been too tired to notice. Fixed!

I think Github already has a built-in mechanism for Ghidra via issues. Perhaps having a "CVE" or a clearer "security bug" (or a better term) label is the better way to go.

This is already fixed in 9.0.1.


Feature/extended workflow support

This pull request adds
-convert and launch for workflows
-restub workflow
-WDL tool+workflow import and CWL workflow import (CWL tool import coming in next PR)
-note that file provisioning works for everything but CWL workflows and WDL output provisioning (This too is coming in next PR)
-some tests for new features

Seems like the mockedIT tests are failing due to errors with validating the user, as tests that don't validate the user are not failing.  I will look for a solution to this before I merge.

I've decided to leave out the fixes for MockedIT from this pull request, as I spent some time on trying to fix them and couldn't figure it out.  I will create an issue that these need to be fixed.


PauseRequest not being received by the debugAdapter

Issue Type: Bug
In 1.28.2, I'm unable to receive the pauseRequest in the debugAdapter which is causing me to be unable to pauseDebugging.
I've debugged it to the point where i notice that VS Code is not sending the request to the debugAdapter.
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.92GB (4.56GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

cpptools
ms-
0.19.0

I have verified this with both the C# and the C++ extension

@pieandcakes good catch, thanks for reporting it.
It would be great if you self hosted on vscode insiders so we try to catch issues like this earlier.

@isidorn I do try and use insiders, but I find I'm mostly using VS since our code is not C++.

@weinand I can test it as soon as the build is out.

yes, and a new Insiders build appears every weekday.

It works again.
Build:
Visual Studio Code - Insiders
Version: 1.29.0-insider (user setup)
Commit: d7ac6e838f51a03f7d417b4758f5fb075878d615
Date: 2018-11-01T06:20:59.729Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Thanks for letting us know, adding verified label


Redirect stubbing not working reliably

First of all, thanks for this great tool!
Sorry for the disorganized report
I've been having an issue that our redirect unit tests occasionally fail.
In the latest release I saw a fix that I was hoping to solve my problem ( #224) but unfortunately not.
Now I have a way to make the redirect stubbing fail reliably.
I added a test to NSURLSessionTests.m:
- (void)test_Redirect
{
    if ([NSURLSession class])
    {
        NSURLSession *session = [NSURLSession sharedSession];

        NSDictionary* json = @{@"Success": @"Yes"};
        [self _test_redirect_NSURLSession:session jsonForStub:json completion:^(NSError *errorResponse, NSHTTPURLResponse *redirectResponse, id jsonResponse) {
            XCTAssertNil(errorResponse, @"Unexpected error");
            XCTAssertNil(redirectResponse, @"Unexpected redirect response received");
            XCTAssertEqualObjects(jsonResponse, json, @"Unexpected data received");
        }];
    }
    else
    {
        NSLog(@"/!\\ Test skipped because the NSURLSession class is not available on this OS version. Run the tests a target with a more recent OS.\n");
    }
}

After inserting the sleep the data task completion handler starts  receiving the redirect response instead of the response after the redirect.
I can fix it by not calling didReceiveResponse for the redirect (301 code) but based on #175 this does not seem to be a valid solution
I will investigate further but wanted to create a ticket in case anyone already have a clue about the root cause.

🤔 Interesting, thanks for the report.
No guarantee I'll have much time to look at it soon, but will keep an eye on it and try to check it some time 👍

Hey @nevil did you manage to investigate this issue further and understand what was causing it?

@AliSoftware
Sorry. I didn't have the time yet to find the real cause.
I have temporarily changed the requestTime to 0.2 and responseTime to 0.5 (arbitrarily selected) and it prevents the issue from happening for me.
This does slow down my unit test execution a bit (though not more than 10 seconds :-) ) so I hope to have time to investigate soon.

Hey @nevil !
Any chance you'll have time to reopen the investigation anytime soon, or maybe at least re-test with a more recent iOS/SDK/Xcode to see if we can close this?

Thanks a lot @morrowa for all the investigative work, that's very interesting!


Clarify comment on CWG issue 2137

See also my post on r/cpp regarding this issue: https://www.reddit.com/r/cpp/comments/iotebm

I've moved it to the definition of data.hpp using the @note annotation.


store mime type on encode() in Image::mime

in my opinion the mime type should be stored in Image::mime when encoding the image, im using this to guess filetype because the transformed images are only present in the object while processing a command pipeline.
Im using this workaround to fix this problem.
$upload->setImage(\Image::make((string) $upload->getImage()->encode($format, $quality)));

+1


go: update to v1.21.0

Update go version to v1.21.0
Along the way update quic-go to v0.37.5

This change is

Please don't review until I get CI to pass


Example of REST2 in explicit solvent.

This is a pretty great idea! to run hamiltonian tempering serially on a single GPU!
Was not clear from the skimming notebook how can one set up REST2 with explicitly solvated protein?
Perhaps by using openmmtools' alchemical factory?
Any tips or an example of how to set up serial rest2 will be appreciated  :)

Hey @DPotoyan , thanks for commenting. There is a way to do this without openmmtools (see caveat below), although it's fiddly with lots of opportunity for bugs. I suggest that once you see the steps involved you'll probably find it easier to use an established tool :)

for starters, the non-bonded interactions between the solute and solvent should be scaled. This requires re-writing the NonbondedForce using both CustomNonbondedForces - one for LJ, and one for electrostatics, as well as a CustomBondedForce for the nonbonded exceptions. This is analogous to the 'free energy of hydration' notebook in this repo, but because your solute likely has charged interactions, it's more involved.
There's an example of how to do this (in the context of calculating hydration free energy) in this gist: https://gist.github.com/ljmartin/4e01f2b32033dcde32264dbbcec2b7df .
the key to the above is setting a 'flag' so the forces know which atoms' interactions to scale

Come to think of it, that doesn't seem too bad. I'll try and find time to add a charged solute example but it may be weeks.
For the caveat: there's a good reason not to do this: serial methods rely on learning the weights between different states, whereas parallel methods use an instantaneous decision at each swap. For larger solutes, you might find (as I have) that the weights don't converge for a very long time. If the weights aren't totally converged and the solute accesses a new state, then the simulation gets stuck in that state. How do you know if the weights are converged before it accesses a new state? Only by simulating for 100s of ns just to see it get stuck :)

I believe the original implementation of serial tempering in OpenMM did use Wang-Landau. Based on some discussion in their repo, they switched to the current method, demonstrated by Chodera and Shirts to show enhanced mixing (i.e. faster convergence). Might be worth a read: https://www.choderalab.org/publications/2014/4/26/replica-exchange-and-expanded-ensemble-simulations-as-gibbs-sampling-simple-improvements-for-enhanced-mixing
This algorithm is also implemented in GSST in this repo.
See this issue in the openmm repo for further discussion: https://github.com/openmm/openmm/issues/1452
100-200 ns certainly doesn't seem too bad! How many (and what) temperature levels were you using? And what was the switching frequency?
thanks!


No data from topic /camera/infra2/image_rect_raw

I get the following message when I run rs_camera.launch:

[ WARN] [1543919568.519673094]: Given stream configuration is not supported by the device!  Stream: Infrared, Stream Index: 2, Format: Y8, Width: 640, Height: 480, FPS: 30

I also dont see a message that "infra2 stream is enabled".
Can anyone suggest me on how to solve this issue.
Thank You.

Could you provide more details? camera, firmware? versions? launch file? etc?


Only pages from target domain should be committed

The changes in #10 modified how we specify which files should be committed after the crawl runs. Previously, we were explicitly adding the www.consumerfinance.gov/ folder. Now, we do a blanket git add . which includes both the HTML files on disk as well as the local log files.
The problem is that, even if we invoke wget with  --domains=www.consumerfinance.gov, because we use --trust-server-names, wget maybe store local files under other domain names. For example, on my fork the crawl generated a cfpb.github.io/source-code-policy/index.html file, because the URL https://www.consumerfinance.gov/developers/sourcecodepolicy/ (linked to on this page) redirects to https://cfpb.github.io/source-code-policy/.
We use --trust-server-names because we want to store redirected pages under their actual filenames (e.g. if a link to /foo/ redirects to /bar/, we should store the file as bar/index.html, not foo/index.html). But this causes problems if the redirect points to another server.
I don't know a way to tell wget to ignore only those redirects that point to another domain. So it seems like, if we want to  avoid committing these pages (which I think we do), we need to filter them out after the crawl. @schbetsy could you take a  look and see if I'm maybe missing something?
A straightforward option would be to change the git add . line to something like git add www.consumerfinance.gov  *.log.gz.
Before doing that, though, I was wondering if there was a more generic/flexible way of doing this, to avoid another hardcoding of the www.consumerfinance.gov domain in this repository. It would be nice, for example, to be able to fork this repo and run it against another domain without having to change a whole bunch of places.
Could we instead leverage an environment variable, maybe defined at the top of our Action, and then referenced below in the different steps? It'd also have to be passed to this line in transform_results.sh, maybe with a similar mechanism as crawl.sh.

Another risk of using git add . with --trust-server-names: a malicious server could host a redirect that resolves to a filename like .wgetrc  or crawl.sh or even .git/something. This would mean that the server being crawled could potentially get something malicious committed back to this repo.
(See CVE-2010-2252 which covers this vulnerability and related discussion on the wget mailing list.)
This makes me think that, besides restoring an explicit reference to the folder we want to add, maybe we should avoid crawling to the root of the repo to avoid hypothetical corruption of other repo files.


Regression: MacOS fullscreen mode 2.6.1 -> 2.6.2

Prerequisite Checklist

[X] I searched for existing issues to prevent duplicates
[X] I searched for existing discussions on the forum to prevent duplicates
[X] I am here to report an issue and not to just ask a question or look for help (use the forum or Discord instead)

Describe your issue here
On ARM64 MacOS, 2.6.1 worked as expected in full screen mode. In 2.6.2, when I enter full screen mode, there is a black border around the writeable area.
Your Environment

OS / distro / window manager: MacOS Sequoia
SFML version: 2.6.1 and 2.6.2
Compiler / toolchain: clang++
Special compiler / CMake flags: standard cmake build

Steps to reproduce
I built the following small app against both 2.6.1 and 2.6.2
#include <SFML/Graphics.hpp>
#include <SFML/Window.hpp>

#include <filesystem>
#include <iostream>
#include <vector>

int main(int, char* argv[])
{
    // Get the location of the executable (this will follow symlinks)
    std::filesystem::path executable(argv[0]);
    std::filesystem::path cwd = executable.remove_filename();

    std::vector<sf::VideoMode> modes = sf::VideoMode::getFullscreenModes();
    if (modes.empty()) {
        std::cout << "Empty set of modes returned\n";
    } else {
        for (std::size_t i = 0; i < modes.size(); ++i) {
            sf::VideoMode mode = modes[i];
            std::cout << "Mode #" << i << ": " << mode.width << "x" << mode.height << " - "
                      << mode.bitsPerPixel << " bpp" << std::endl;
        }
    }

    sf::RenderWindow window;
    if (!modes.empty()) {
        window.create(
            sf::VideoMode(modes[0].width, modes[0].height), "Test", sf::Style::Fullscreen);
    } else {
        // So we fall back to windowed. Any attempt at fullscreen will cause a segfault
        // owing to the bug outlined in my report at https://github.com/SFML/SFML/issues/2300
        window.create(sf::VideoMode(1280, 800), "Test");
    }
    window.setFramerateLimit(24);

    sf::Font font;
    std::filesystem::path fontFile = cwd / "open_sans.ttf";
    if (!font.loadFromFile(fontFile.c_str())) {
        std::cout << "Couldn't load font file " << fontFile.c_str() << std::endl;
        return 2;
    }
    sf::Text txt;
    txt.setFont(font);
    txt.setFillColor({ 0, 200, 0 });
    txt.setCharacterSize(100);
    std::string txtString = "Resolution: " + std::to_string(window.getSize().x) + " x "
        + std::to_string(window.getSize().y) + "\n\n" + "Press Esc to quit";
    txt.setString(txtString);
    txt.setPosition({ 100.f, 100.f });

    sf::RectangleShape rect;
    rect.setOutlineColor(sf::Color::Yellow);
    rect.setOutlineThickness(4.f);
    rect.setSize({ 1900.f, 1180.f });
    rect.setFillColor(sf::Color::Transparent);
    rect.setPosition({ 10.f, 10.f });

    while (window.isOpen()) {
        sf::Event event;
        while (window.pollEvent(event)) {
            if (event.type == sf::Event::Closed) {
                window.close();
            }
            if (event.type == sf::Event::KeyPressed) {
                if (event.key.code == sf::Keyboard::Escape) {
                    window.close();
                }
            }
        }
        window.clear({ 0, 0, 0 });
        window.draw(rect);
        window.draw(txt);
        window.display();
    }
}

Quick Makefile:
t: main.cpp
		clang++ -g -Wall -Wextra -Werror -Wpedantic -std=c++17 -o t main.cpp -L. -l sfml-graphics -l sfml-window -l sfml-system

Expected behavior
There should be no difference in the display between 2.6.1 and 2.6.2
Actual behavior
Black border around full screen app in 2.6.2

This is what it looks like under 2.6.1

I assume you're not setting anything specifically in the plist file, right? Just compile and run?

Yes, just compile and run after export DYLD_LIBRARY_PATH=. to pick up the local libs.

One other thing to add... the native resolution of my display (it's an M4 MB pro) is 3456x2234. I have mine set to 2056x1329 (the dimensions you see in the second screenshot). In the list of resolutions selectable, MacOS reports 1728x1117 as the default. Interesting that the first screenshot shows that as the screen size.

It looks like your code still accounts for 2.6.1 (and earlier) issues.
Instead of:
window.create(             sf::VideoMode(modes[0].width, modes[0].height), "Test", sf::Style::Fullscreen);     }
try using:
window.create(             sf::getDesktopMode(), "Test", sf::Style::Fullscreen);     }

Thanks for the suggestion, but I get the same result.
Incidentally, the stdout from the two runs show a difference in reported video modes.
2.6.1 reports just one available, the one I want:
Mode #0: 3840x2400 - 32 bpp

whereas the 2.6.2 version reports:
Mode #0: 1728x1117 - 32 bpp
Mode #1: 1728x1080 - 32 bpp
Mode #2: 1496x967 - 32 bpp
Mode #3: 1496x935 - 32 bpp
Mode #4: 1312x848 - 32 bpp
Mode #5: 1312x820 - 32 bpp
Mode #6: 1280x800 - 32 bpp
Mode #7: 1168x755 - 32 bpp
Mode #8: 1168x730 - 32 bpp
Mode #9: 960x600 - 32 bpp

... none of which match the full resolution of the screen.

What does getDesktopMode report?

        auto dm = sf::VideoMode::getDesktopMode();
        std::cout << "DM Width: " << dm.width << ", Height: " << dm.height
                  << ", bpp: " << dm.bitsPerPixel
                  << ", valid = " << (dm.isValid() ? "true" : "false") << "\n";
        window.create(sf::VideoMode::getDesktopMode(), "Test", sf::Style::Fullscreen);

gives
DM Width: 2056, Height: 1329, bpp: 32, valid = false
The requested video mode is not available, switching to a valid mode

Yes, using that branch stdout gives
Mode #0: 2056x1329 - 32 bpp
Mode #1: 1728x1117 - 32 bpp
Mode #2: 1728x1080 - 32 bpp
Mode #3: 1496x967 - 32 bpp
Mode #4: 1496x935 - 32 bpp
Mode #5: 1312x848 - 32 bpp
Mode #6: 1312x820 - 32 bpp
Mode #7: 1280x800 - 32 bpp
Mode #8: 1168x755 - 32 bpp
Mode #9: 1168x730 - 32 bpp
Mode #10: 960x600 - 32 bpp

and the fullscreen window displays as per the 2.6.1 screenshot in the original comment above.

But yeah... 2.6.1 wasn't reporting the right resolution either. It was just reporting a giant resolution, in which the window fitted.
Going to make a PR.

One other thing to add... the native resolution of my display (it's an M4 MB pro) is 3456x2234. I have mine set to 2056x1329 (the dimensions you see in the second screenshot). In the list of resolutions selectable, MacOS reports 1728x1117 as the default. Interesting that the first screenshot shows that as the screen size.

I have a MacBook Pro with, I believe, the same resolution display. I tried setting it to 2056x1329 just like you but when I run your example project it reports a resolution of 1728x1117. I would like to reproduce what you're seeing but something isn't quite lining up for me.

One other thing to add... the native resolution of my display (it's an M4 MB pro) is 3456x2234. I have mine set to 2056x1329 (the dimensions you see in the second screenshot). In the list of resolutions selectable, MacOS reports 1728x1117 as the default. Interesting that the first screenshot shows that as the screen size.

I have a M1 MacBook Pro with, I believe, the same resolution display. I tried setting it to 2056x1329 just like you but when I run your example project it reports a resolution of 1728x1117. I would like to reproduce what you're seeing but something isn't quite lining up for me.

That sounds like what I'm seeing - 2.6.1 reports 2056x1329 as per the second screenshot above, whereas 2.6.2 gives the incorrect 1728x1117 (first screenshot), with the black border.

Oh right, I just realized I was testing with 2.6.x and not 2.6.1. When I switch to 2.6.1 I can reproduce your initial issue.

Resolved by https://github.com/SFML/SFML/pull/3331


Understand the table relationships with "_id"- kind of key attributes

Description
In PDBx the data structure of choice is a table, where the category name represents a table name and the data ids are it's components. The are also attributes that connect each other by a certain attribute: that would usually contain a category_name.name_id.
When provided to a certain sample, for instance a concrete instrument (by id) will be associated and shown correctly on OneDep.
Issue
When ids are not provided at all, data is often not propagated to the fields.
Concerns
We don't really have that kind of relationship in OSC-EM. If we have many instances, it usually (?) does not affect the relationship with some other property.
Is it then save to just add enumeration-like id to these properties to tie them up to other properties?

I think it's usually ok. Looking through some EMDB entries it looks like ids can either be meaningful accessions (eg _chem_comp.id, entry_id) or sequential integers (eg entity_id). So I think as a default you can just use numbers.

yes, I forgot to close this issue, as it's solved - I am adding some IDs for neccessary  data items


Kinetics data loader

I tried to use the tutorial provided in the documentation "Training a PyTorchVideo classification model" using the kinetics dataset.
in the official annotation file I noticed there are 2 columns "time_start" and "time_end" which explains when the activity occurs. I didn't see any mention for that in the LabeledVideoDataset class, you just expect the csv to contain "video_path , label".
so my question is , do you assume the videos are already cropped in the right time ? or you don't care about the frame labels and you feed just a random crop of the video and you assume that the activity is contained in that ?
By the way, the official script for downloading the kinetics dataset doesn't work at list for me(I couldn't initialize new conda env with the environment file provided by them, and even after installing by hand the package the script doesn't do anything).

Have the same question..

Hi, good questions!
Yes, we already assume the videos are time cropped accordingly. We have scripts to preprocess and extract clips from videos in the original dataset. For more details on how to do it, please checkout our Kinetics downloading and preprocessing instructions here - https://pytorchvideo.readthedocs.io/en/latest/data_preparation.html#kinetics

Please re-open the issue if you have more questions or the problem persists. Thanks for trying out PyTorchVideo!


No expandpath in path variables

I would like configure the default jedi environment like this:
{
    "settings": {
        "pylsp.plugins.jedi.environment": "~/.virtualenvs/${project_base_name}",
    }
}

However, the plugin does not expand "~" into my home directory path. Could an expandpath be added on the settings variables that hold a path? (I don't know how to do that, otherwise I would have filed a pull request)

You can use $home: https://github.com/sublimelsp/LSP/blob/ed70eb24e70e43f6b2ba77d4ecc300cac78c31a8/plugin/core/sessions.py#L684

Oh right, I didn't tried this. Thanks!


Alternative Entrypoints

Feature
Feature description
In https://github.com/fishtown-analytics/dbt/compare/hackathon-2, we experimented with adding "alternative entrypoints" to dbt. Specifically, we built code into dbt that allowed it to load an already-generated manifest from disk and deserialize it. Then, when including dbt as a library, it was possible to use that loaded manifest to invoke other parts of dbt without re-compiling. For example, it would be possible to compile a single node, or run a single SQL query, when including dbt as a library.
This is an important first step towards client server.
The changes suggested here are:

Give dbt a way to load a manifest file from disk and deserialize it
Give dbt a way to use that manifest to take small, specific actions, e.g.

compile a SQL string
run a SQL query against the warehouse

Great writeup @cmcarthur. One thing I'd add: This entrypoint should optionally support compiling the manifest upon entry. Then, we'll always have a working manifest to operate with. As it stands from the hackathon-2 branch, you needed to manually compile the project before you could use the manifest.

@drewbanin agree -- this issue probably encapsulates dozens of issues related to the specific alternative entrypoints. Off the top of my head, here are some example entry points that I'd love to see dbt support:

given a manifest, and a change to one file, generate an updated manifest
given a manifest, and some SQL, compile that SQL
given a manifest, run a specific model in the manifest
given a manifest, run some SQL and return the result

Notably the common thread here in every case that I can imagine is the manifest. It's pretty clear to me that the manifest is the protocol for passing around the configuration for a dbt project. In a client-server world, I have to imagine that the manifest is the most frequently passed around entity.

You can imagine how those little atomic operations give you lots of powerful orchestration options, and power lots of different dbt clients.

how does "a full-fledged server" sound for an alternative entrypoint? :)
We'll still probably want to do something like this in the future, but we can queue up a more actionable issue when we get there


Problem with array type validation?

Live Try Flow Example
type TypeThing = {
  id: number
}

type TypePerson = {
  id: number,
  name: string
}

// Case 1
const person: TypePerson = { id: 1, name: 'Ryan' };
const thing: TypeThing = person;

// Case 2
const people: TypePerson[] = [person];
const things: TypeThing[] = people;

// Why does Case 1 pass but Case 2 fail?

Flow has no issues with Case 1, but does complain during Case 2 stating that "property name does not exist in TypeThing".
Why does Flow complain during Case 2, but not Case 1? Does type validation behave differently when Arrays are involved? Is this intended behavior?

Arrays are invariant: https://flowtype.org/docs/arrays.html

TypePerson is a subclass (or a more specific type) of TypeThing. Case 2 assumes that arrays are covariant.

If you use $ReadOnlyArray instead of Array things will work fine.
type TypeThing = {
  id: number
}

type TypePerson = {
  id: number,
  name: string
}

// Case 1
const person: TypePerson = { id: 1, name: 'Ryan' };
const thing: TypeThing = person;

// Case 2
const people: $ReadOnlyArray<TypePerson> = [person];
const things: $ReadOnlyArray<TypeThing> = people;

Thanks for the great information and a solution. I appreciate it.

@nmn is there a reason why things like $ReadOnlyArray and $Keys are not in the Flow documentation?

@hmillison Yes because the documentation is old. But it is being worked on.


Prior to computing delays asses how much of the model is needed

In relation to issue ticket #153 we should only use whatever of a model is needed and the extra buffer to cover the bbox requested. Downloaded models that are larger should be re-cropped upon calculation.

Closed by #239.

Closed by #239.


Sorting on plugin content

Hello!
One question: which is the order that the plugin takes to generate the upload list when dropping the content? Is it aleatory, as it comes from the user desktop (drop) or is there any logic (alphabetical, natural, order, etc.)?
This will be important to know in case we need to handle the sorting of the files once they are uploaded.
David.

It's defined by the OS, I'm not sure if it's the same everywhere to be honest. Maybe you can use the sort method.

Yes, that will work. Thanks!


Doc request -- compatability matrix

Can we get some sort of table indicating what versions of this are compatible with what versions of firmware and so on?
Trying to get a T-Beam 1.1 running with ATAK-CIV 4.7 and Meshtastic 2.x (currently 2.0.23 firmware, 2.0.20 app) and the plugin just isn't showing up in ATAK anywhere.  Other closed issues and posts have occasionally instructed users to install specific versions of meshtastic or their firmware, but there doesn't seem to be a straightforward list of what versions of all the pieces work with each other.
FWIW the meshtastic devices are paired fine and are communicating with the phone and with each other over LoRa, it's just the ATAK bit that's being stubborn.
Edit: The precise issue right now is that it shows up in the plugins list as "available" and all the checks are green, but installing it doesn't seem to work.  I get the popup, go ahead with the install (already said yes to the permission), and then afterwards, status is still "not installed" in the plugins list.

Going to close this myself.  The matrix would still be welcome, but some further searching leads me to believe that my issue is with the play store version of ATAK-CIV.  Going to give the atak.gov downloads a try and see how that goes.  A big red "don't use the play store version" warning on the main readme would be welcome. :)


Add Korrel8r deployment within COO

Add Korrel8r deployment within observability operator

/assign @jan--f

Closing this PR, and moving the work to here - https://github.com/rhobs/observability-operator/pull/497


newton line search

Codecov Report
Attention: Patch coverage is 78.89908% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 90.50%. Comparing base (ad37e72) to head (525979e).

Files
Patch %
Lines

src/serac/numerics/equation_solver.cpp
64.61%
23 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1112      +/-   ##
===========================================
- Coverage    90.58%   90.50%   -0.09%
===========================================
  Files          160      161       +1
  Lines        14331    14452     +121
===========================================
+ Hits         12982    13080      +98
- Misses        1349     1372      +23

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


File uploading and pod creation stuck

Create new pod
Upload and delete ~80 files
After some upload/deleting iteration fairos will not respond
Try to relogin and create pod. Pod creation will stuck

Closing it for now. Feel free to open it, it the issue still persists.