Modes

Can you help me? Is there an option within these available scripts to use different "modes" or "banks"? I wanted to use the same knobs for send A, send B and devices, for this it would be necessary to have the same script edited in 3 different modes, one for each and use three buttons to select these modes, one button for each mode. How to rewrite this based on these available scripts? I'm desperate for this!

I'm not the developer of this project, but as far as I can tell it can't do "banks" / "modes".
You can use my MIDI Scripter project to to make a proxy between your MIDI controller and this script.
One of the example scripts is exactly your case.

but with your script I can edit it and still use it in Ableton 11.3? Everything I tried to edit within the script to create some other function either didn't exist in Ableton or existed but didn't work

I have a nanokontrol2, my idea is to have two modes, one for Sends and one for Devices. I wanted to use one button to switch between these modes, use two buttons to navigate between sends in send mode and between devices in device mode. And the 8 knobs, one for each send on each track (8) when in send mode and in device mode, controlling the 8 device parameters. Note: I wanted two buttons to navigate between tracks to the right and left. A session box with 5 tracks per 1 scene.

MIDI Scripter isn't a replacement for "Ableton Live Custom MIDI Remote Script", it can be a proxy between your controller and Ableton remote script that do "banks" for you. It can alter MIDI messages from controller based on your "bank selector" position.
The example script assigns CC messages' channel for each bank, which will not suit "Ableton Live Custom MIDI Remote Script", but it's easy to change it to modify CC messages' control value. Like msg.data1 + 20 for second bank.
Your will still have to map controls for all banks in "Ableton Live Custom MIDI Remote Script".
If you have questions about MIDI Scripter I suggest opening an issue of discussion in it's repository.

 Besides, my English isn't that good, I'm from Brazil


Launch MxPlayer with subtitles

Is it possible to launch MxPlayer by intent including url or local path to subtitles?

Yes, you can pass subtitle key, values as args   launchMxPlayer(String url, String? mime, Map<String, dynamic>? args) .
You can check how to do it at MX PLAYER API LINK.


(GH-685) redis_reconnect_on_error now defaults to true

This if to reflect an update to the API and documentation.
https://sensuapp.org/docs/latest/reference/redis.html

Solves issue #685
https://github.com/sensu/sensu-docs/pull/601  should be merged before merging this.

@cwjohnston could you please merge the documentation

Released in v2.10.0


Mobu 2022 support

Hi and thank your for this amazing plugin.
Is there a version for the latest mobu 2022? I would like to take advantage of the python3 integration while still being able to use the plugin.
Thank you.

Support for MotionBuilder 2020 and 2022 was added in 0762b9a7c8af90c5aa41f3a5e7f02eaa41ec4256, which was released with version 2.5.0.
Thanks!


feat(gms): support basic auth header when connecting to elasticSearch

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

LGTM! Tested locally


Low risk contact seems like a high risk contact

Issue: If your app is warning you about a high risk contact it shows how many days it dates back. This works fine. The problem is: If you have a low risk contact during the time that your app is red it changes the number of days and the communication makes it seem like you had another high risk contact.
Example: your app is red and tells you the last high risk contact is 6 days ago. You go to the get tested where you probably have a good chance to have a low risk contact with a corona positive person. Let's assume that you actually do have a low risk contact. As soon as this person gets the test result another risk contact shows in the app and the number of days reduces by 6 days. In the communication it makes you believe that you had another high-risk contact. Which leaves you confused and afraid that you have to get tested once again. If you wait and Don't do anything about it your CWA is getting green again 14 days after the real high risk contact. (How you find out that the second contact actually was not high risk)
Expected behavior: if you have a low risk contact during the time you're app is red it should not be given the impression that it was a high risk contact.
Solution: also in the state of a red CWA there need to be distinction of low and high risk contacts.
Thank you for looking in to this!
Cheers Reggirella

Avoid duplicates

[ ] Bug is not mentioned in the FAQ
[ ] Bug is not already reported in another issue

Describe the bug

Expected behaviour

Steps to reproduce the issue

Technical details

iOS Version:
Device:

Possible Fix

Additional context

Duplicate of https://github.com/corona-warn-app/cwa-documentation/issues/422

Yes it is exactly this issue. Sorry have not found it when I was searching.

Dear @Reggirella,
Thank you very much for your contribution.
As @Ein-Tim suggests, your suggestion seems to be a duplicate of https://github.com/corona-warn-app/cwa-documentation/issues/422.
There are actually several issues open on the question how low risk encounters should be notified:

similar if not the same issue https://github.com/corona-warn-app/cwa-app-android/issues/1184
Differentiation between low and high risk matches https://github.com/corona-warn-app/cwa-wishlist/issues/233
Show more details about risk encounters https://github.com/corona-warn-app/cwa-wishlist/issues/100
See also https://github.com/corona-warn-app/cwa-wishlist/issues/100#issuecomment-690279530
show days for low risk encounters https://github.com/corona-warn-app/cwa-wishlist/issues/178
Different colour for low risk encounters https://github.com/corona-warn-app/cwa-wishlist/issues/132
Low Risk Exposure display optional https://github.com/corona-warn-app/cwa-wishlist/issues/181
Display of "Tage seit letzter Risiko-Begegnung" is irritating https://github.com/corona-warn-app/cwa-documentation/issues/433

Best wishes,
DS
Corona-Warn-App Open Source Team

Duplicate of https://github.com/corona-warn-app/cwa-documentation/issues/422


Better installation section

Hey, your library is really interesting.
The only problem I found was the README.md, which needs improvement in the Installation Section
I created this iOS Open source Readme Template so you can take a look on how to easily create an Installation Section
If you want, I can help you to organize the lib.
What are your thoughts? 😄

https://github.com/vsouza/awesome-ios/pull/1336


Integrate application with raven-js

Trello: https://trello.com/c/0pzXlC9R/144-track-javascript-errors-s
Raven-js is a JS module that is used to send errors to sentry.io. To
enable us to do this we expose our SENTRY_DSN and SENTRY_CURRENT_ENV
environment variables to HTML meta tags. We then read those attributes
in as part of our Javascript initialisation and install Sentry.
The code for the application is then wrapped in a Raven.context function
as recommended by: https://docs.sentry.io/clients/javascript/#configuring-the-client
Finally we set Raven as a global variable on window so that it can be
available in the console for testing purposes.
I've configured sentry to just accept errors from *.publishing.service.gov.uk hosts, ~I'm going to expand this to include heroku too.~ - actually I can't do that since we don't have a sentry dsn set up for heroku currently.

@benthorner Raven.context is used to wrap anything in a try / catch. As, like you, I'm not sure what advantage it gives us I've removed it for now and we can look at adding it if we find our JS tracking seems to be lacking. It's removed in 88585f0


fix: update required ibm provider version to < 1.7

/run pipeline

/run pipeline

:tada: This PR is included in version 1.3.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TPM Provision is not working for custom RegistrationID

Describe the bug
Renning the command Provision-EflowVM -provisioningType "DpsTpm" -scopeId "<ScopId>" -registrationId "custom-reg-id"
I get a success message, however, the provisioning didn't happen.
I can check under the DPS portal individual enrolment that the status remains unassigned. and no device has been created.
To Reproduce
Steps to reproduce the behavior:

Install EFLOW v1.1.2111.17111
Deploy a VM
Create a DPS individual enrolment with the device TPM endorsement key and a custom registration id
Run the provisioning command (DpsTpm type) using the parameter -registrationId "custom-reg-id"
Check in the output that Provisioning command are using the right registration id and scope id
Chek in the DPS portal that the individual enrollment wasn't used. Check that no IoT Hub device had been created.

Expected behavior
I expect a similar behavior to the one of running the command with no -registrationId "custom-reg-id" parameter and the default registration id was used.
Screenshots
DPS portal - Individual Enrolment after the provisioning command returns success:

Windows Host OS (please complete the following information):

Edition: [Enterprise
Version: [19042.1348]
Virtual Machine: [None]

Hi @ngmartins,
Thanks for your detailed information. I've just tested using a custom registrationId and worked perfectly fine.

Thanks,
Francisco

Great: so I may be doing something wrong.
Can you please describe your steps and validate the command I am using?
Thanks,
Nuno

@fcabrera23 just figured out: I may not use the char " around the parameter values.
Without the char, it works as expected.
Thanks for the help


Fix actor worlds

Signed-off-by: Ashton Larkin<EMAIL_ADDRESS>🦟 Bug fix
Fixes #647
Summary
While working on fixing the crash from launching actor.sdf (see #647), I noticed that there are issues with other actor example worlds as well. It seems like there is an issue using an <include> tag for actors in SDF (removing actor-related <include>s from the SDF resolves crashes on launch). I'm not sure when this became a problem, or why it is a problem. I need to look into this further (I haven't been involved with actor-related development for Ignition), so I've added a list of things I plan to investigate below.
TODO:

[ ] address empty actors_population.sdf file (should we delete this, or should we populate it with the corresponding erb file?)
[ ] Figure out when <include> tags became an issue (I need to look through the history/past PRs. One PR that I found so far that may be related is https://github.com/ignitionrobotics/ign-gazebo/pull/157)
[ ] Look at the stack trace in #647 to see if there is any useful information there
[ ] Update the tests for actors to handle <include> scenarios if this test case hasn't been handled yet

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Closing this PR because https://github.com/ignitionrobotics/ign-gazebo/pull/754 seems to be the appropriate solution.


[FW]Networked Variable fix

fw Networked Variable fix

this probably shouldn't be merged into the main branch atm, given that fw itself isn't there yet, this fix should probably come with a pr for a full fw mode

but the way we test other modes right now only server needs to download the scripts for the gamemode. Without this change Players who want to play this mode have to download the scripts as well, right?


fix certificates validation, add tests requirements

It looks like after the migration from requests to httpx, skipping certificates validation has stopped working, because it looks like when HttpTransport is used then verify parameter needs to be added to HttpTransport and this in Client (passed from **kwargs) is ignored then.
Before the change, for example script:
from api4jenkins import Jenkins
client = Jenkins("https://localhost:8443", verify=False)
client.system.run_script('println("howdi")')

I got:
Traceback (most recent call last):
  File "/some/path/tests/test_jenkins.py", line 13, in test_localhost
    client.system.run_script('println("howdi")')
  File "/some/path/venv/lib/python3.11/site-packages/api4jenkins/mix.py", line 64, in run_script
    return self.handle_req('POST', 'scriptText',
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/api4jenkins/item.py", line 100, in handle_req
    self._add_crumb(self.jenkins.crumb, kwargs)
                    ^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/api4jenkins/__init__.py", line 244, in crumb
    _crumb = self._request(
             ^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_client.py", line 814, in request
    return self.send(request, auth=auth, follow_redirects=follow_redirects)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_client.py", line 901, in send
    response = self._send_handling_auth(
               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_client.py", line 929, in _send_handling_auth
    response = self._send_handling_redirects(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_client.py", line 966, in _send_handling_redirects
    response = self._send_single_request(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_client.py", line 1002, in _send_single_request
    response = transport.handle_request(request)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_transports/default.py", line 227, in handle_request
    with map_httpcore_exceptions():
  File "/usr/lib/python3.11/contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/some/path/venv/lib/python3.11/site-packages/httpx/_transports/default.py", line 83, in map_httpcore_exceptions
    raise mapped_exc(message) from exc
httpx.ConnectError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1006)

@devqore thanks for finding this issue, and are you able to fix AsyncJenkins and other parameters as well?

@devqore thanks for finding this issue, and are you able to fix AsyncJenkins and other ignored parameters if customized HttpTransport is used as well?

I've added rest of parmeters to both methods.


Display Issue on Mobile

Describe the bug
The UI of the datepicker is buggy on mobile phones
To Reproduce
Steps to reproduce the behavior:
Build the picker into your website, and view it on mobile.
Expected behavior
Working and good looking datepicker
Screenshots

Desktop & mobile (please complete the following information):

Browser: Chrome & Safari
Library version: 4.3.0

To add: It now also doesn't work on desktop.

Please include css import in your app:
import<EMAIL_ADDRESS>


Can Kosovo be added to the list of countries?

https://www.britannica.com/place/Kosovo

Yes, absolutely. Do you happen to know what's people use as regions within the country? Districts or municipalities?
https://en.wikipedia.org/wiki/Administrative_divisions_of_Kosovo

I would simply put region name "Kosovo" for now. At least that will be an improvement


Add testing against Django 4.2 prereleases.

Fixes #33

Coverage: 92.141%. Remained the same when pulling d741fb5904c8a715ace20ba35013773cf7d82eb9 on terjekv/issue33 into 36a4b4e987ef77f70c3d35bbe1fd042c7c9bbfe8 on main.


Add tests for backup-lock

https://github.com/longhorn/longhorn/issues/612
Added tests for backup locks and fixed a few flake8 errors in the test_basic.py file.
Signed-off-by: khushboo-rancher<EMAIL_ADDRESS>

@meldafrawi This test should have covered test cases for https://github.com/longhorn/longhorn/issues/1393 as well.


TaskExit event can be sent for an exec process after TaskExit is sent for the init process

Description
When an exec process exits at around the same time as the init process, a TaskExit event for the exec process can be sent after the TaskExit event for the init process.
When using docker, this causes the client (running docker exec) to hang.
Steps to reproduce the issue
The following test case hangs for me after at most a few iterations:
#!/usr/bin/env bash
set -x
while true; do
    d=$((40000 + $RANDOM % 10000))
    ctrid=$(docker run --rm --detach alpine usleep $d)
    docker exec $ctrid true
done

The range of the value d may need to be adjusted.
Describe the results you received and expected
Expected: the test case runs infinitely.
Actual: the docker client (docker exec) hangs after a few iterations.
TaskExit is sent for the exec process (40004) after the init process (39954):
2024-01-31 08:36:37.082622552 +0000 UTC moby /tasks/start {"container_id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","pid":39954}
2024-01-31 08:36:37.108081891 +0000 UTC moby /tasks/exec-added {"container_id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","exec_id":"bf5b57cffb8ca1f7aa054e03bf9aa706c265543d14adeed39152c36020e86151"}
2024-01-31 08:36:37.150185466 +0000 UTC moby /tasks/exec-started {"container_id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","exec_id":"bf5b57cffb8ca1f7aa054e03bf9aa706c265543d14adeed39152c36020e86151","pid":40004}
2024-01-31 08:36:37.151223505 +0000 UTC moby /tasks/exit {"container_id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","pid":39954,"exited_at":"2024-01-31T08:36:37.151180595Z"}
2024-01-31 08:36:37.151675639 +0000 UTC moby /tasks/exit {"container_id":"57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e","id":"bf5b57cffb8ca1f7aa054e03bf9aa706c265543d14adeed39152c36020e86151","pid":40004,"exit_status":137,"exited_at":"2024-01-31T08:36:37.151196343Z"}

The following errors are seen from docker:
Jan 31 08:36:37 lima-docker dockerd[37321]: time="2024-01-31T08:36:37.294825280Z" level=error msg="failed to process event" container=57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e error="could not find container 57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e: No such container: 57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e" event=exit event-info="{57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e bf5b57cffb8ca1f7aa054e03bf9aa706c265543d14adeed39152c36020e86151 40004 137 2024-01-31 08:36:37.151196343 +0000 UTC false <nil>}" module=libcontainerd namespace=moby
Jan 31 08:36:37 lima-docker dockerd[37321]: time="2024-01-31T08:36:37.295188596Z" level=error msg="exit event" container=57aab64157c14148b12b9bda4e35588f4d534b50ef78ffab14c7ea280493592e error="no such container" module=libcontainerd namespace=moby process=bf5b57cffb8ca1f7aa054e03bf9aa706c265543d14adeed39152c36020e86151

I see no guarantees are made on the ordering of TaskExit for the init process vs TaskExit for execs in runtime/v2/README.md.
Is this a bug in containerd, or an omission in the runtime v2 API, or a bug in docker?
  Not seen on containerd 1.6.21.
https://github.com/containerd/containerd/pull/8617 seems a likely candidate, although I have not confirmed this via cherry-pick.
Show configuration if it is related to CRI plugin.
No response

Oooh, thanks, I can replicate this (though I to use a lower d). I think regardless of exit event order guarantees, we can probably try to harden things on the docker side so that it doesn't break there, so I'll maybe start by taking a look on that side.

I've been a bit busy over the last few days, but in the meantime I've confirmed via bisect that https://github.com/containerd/containerd/commit/5cd6210ad055ec3a0fc263fdde382191c52c40ce is at fault (pre-this commit, we just had big locks around exec which were extremely slow whenever we had more than a couple execs starting around the same time). Will look into a fix, and adding some tests around this.
cc @corhere

I'm more confused than when I started looking. I do not understand how execs are killed when the init process exits. Execs are weird beasts; they have a parent PID of 0 (in the container's pid namespace) just like the container init, making them roots of distinct process trees?! The ip.KillAll(...) call inside handleProcessExit kills the init process's process group, which would leave the exec process trees untouched. (Proof: if it did, the init process's TaskExit event would always be sent before the TaskExit events of execs because the handleProcessExit call handling the init process exit blocks the caller, the processExits goroutine, from processing any following exits.) What's killing the execs?

Yeah, I've been looking and as thoroughly confused as you. However (regardless of the mystery of who is killing the execs), since we do consistently receive the exec's exit event in processExits before we get the init process's, we should be able to handle it and emit an event for it before we do for the init processes.
From what I've seen, what's currently happening is: since we're forcing the timing to get the exec to start around the same time as the init process exits, the race we're forcing makes it so that the exec exit is always an "early exit", which is received around the same time as a "regular exit" from the init process, but the way that we handle early exits (let the subscribers know, and then when the subscribers call handleStarted we process the early exit) we delay emitting the exec's exit until after the init process's, which causes issues on the other side.
More explicitly:

Start init
Start exec
We receive, in quick succession, exit events for the exec first and the init process
handleStarted for the exec hasn't been called yet, it's not in s.running, so we register it in the subscribers and in the meantime we process the init process exit and emit the exit event for it
We eventually call handleStarted for the exec, handle things properly, but in the meantime we've reordered events (we received the exit for the exec first, but emit it last)

Even if we change the "exec killing" behavior, we still could run into this situation in cases where the exec is naturally exiting (as an early exit) around the same time as the init process, no? If that's the case, a general solution to this problem needs to involve explicitly delaying emitting the init process's exit if there are execs pending for that container.

Sidenote: right, the execs are being reaped by https://github.com/containerd/containerd/blob/main/pkg/sys/reaper/reaper_unix.go via https://github.com/containerd/containerd/blob/main/core/runtime/v2/shim/shim_linux.go

I pushed a little non-super-polished example of a fix w/ the "wait to emit init exit if there are pending execs" approach here https://github.com/containerd/containerd/commit/899fe6ee00a92199518efef9ed53c4a8ae0187a2 for discussion.
@corhere @dmcgowan @thaJeztah thoughts?

I would still like to understand the control flow of how the container's init process exiting gets resolved to the reaper publishing a stream of exec exits followed by the init process exit. We might be able to implement a cleaner fix with less state tracking if that is happening under the control of the runc shim. (I've seen what happens to a codebase when issues are worked around by applying workaround after workaround to another layer instead of addressing the root cause: libnetwork.)

Sure! I admit I can't see what a cleaner fix would look like – but maybe my assumptions are wrong. What I'm thinking is:

we want the exec to exit when init exits (right?)
we (probably) want the exec exit to be emitted before the init (if for nothing else, because that's the assumption built into most other things)

If those assumptions are correct, the reaper and the aforementioned exec exit stream followed by the init process exit conforms to what we want, and the issue is in us inverting the order of events by delaying the exec exit until handleStarted is called.
Maybe you have other ideas though.
Looking at https://github.com/containerd/containerd/blob/66ac08d89e68990016a3217ab66932d0062a777e/runtime/v2/shim/shim_unix.go#L73-L92 might be helpful for understanding.

Actually, after thinking about it for a bit I guess this (current) issue was introduced when attempting to fix another issue (lock contention due to locks present for preserving event order) which itself was perhaps addressed at the wrong layer, so that's fair – the weirdness between managing exits coming from runc vs emitting start events could maybe be fixed at another layer and we could remove all the complexity from the shim layer, and address this issue alongside that.
I don't think the issue is with the reaper though, but with the overall flow between emitting start and exit events.

I don't think the issue is with the reaper, either. The reaper is just wait4()ing child processes which have already exited.
I've solved the mystery of how execs get killed: it was the kernel all along! That means the task service is the right place for a fix.
The remaining question is whether the kernel guarantees a particular order that child processes are reaped by wait4 in that scenario. (We can depend on Linux-specifics in v2.) Your strawman fix assumes that the kernel guarantees that the pid namespace's init process is always the last process in the namespace to be reaped by wait, so it would be helpful to confirm we can rely on it. I think that is the case, but I'll need trace through the kernel sources some more to be sure.

Found it!
	 * Semantically it is also desirable to wait for EXIT_ZOMBIE
	 * processes before allowing the child_reaper to be reaped, as
	 * that gives the invariant that when the init process of a
	 * pid namespace is reaped all of the processes in the pid
	 * namespace are gone.

Nice!! That's great :) I'll polish up that fix and prepare a PR.

There is one other case to consider: the one where runc.ShouldKillAllOnExit() == true, i.e. when the container init process is not the init process of a PID namespace. But that case was always bugged even before https://github.com/containerd/containerd/commit/5cd6210ad055ec3a0fc263fdde382191c52c40ce so it's not a regression. It'd be nice to fix that case at the same time, but probably not critical.

Would that be in the --pid=container:<other container> or --pid=host case?

Would that be in the --pid=container:<other container> or --pid=host case?

Correct


missing-error ENV flag does not appear to be respected

We have a step defined like below
      - label: Run Physical Device Tests
        commands:
          - "ci/common/physical_device_test.sh"
        key: "physical_device_test_skippy"
        # other args omitted for brevity
        soft_fail: true
        env:
          ENABLE_SKIPPY: "true"
        plugins:
          - test-collector#v1.8.0:
              files: "**/build/fladle/*/results/*/JUnitReport.xml"
              format: "junit"
              debug: true
              api-token-env-name: ...
        retry: *retry_errors
        timeout_in_minutes: 60

The physical_device_test.sh script invoked in the command may sometimes intelligently skip running tests, so we want dynamically set the test-collector to exit with 0 in this case when it doesn't find any files. In practice the script does this in that event
export BUILDKITE_PLUGIN_TEST_COLLECTOR_MISSING_ERROR='0'

But it seems that this env is not respected when the plugin runs. Is it possible that it's resolving this env too eagerly (i.e. beginning of the step) rather than at test-result-collection-time? Or are we misunderstanding how that env is supposed to be used (or is it not visible to the test-collector plugin since it's set in the commands block)?

hi @ZacSweers! you got it right in your last comment. Environment variables in a command step are not visible to plugin executions. There is an experiment in the agent to support mutating the environment called job-api that may allow doing what you want/need, but it is not yet stable and I personally have not tested it to see how that interacts with plugin configurations (though I would expect it to work).
Another alternative would be to decouple the artifact uploading from the generation of the files using artifacts (as described in the documentation) but have your script do the pipeline upload of the step that uses this plugin instead of having it in the pipeline as it is.

Got it, thanks!


backend: split and ingest region size more precise

What problem does this PR solve?
try to resolve #365 by avoid writing and ingesting big regions
What is changed and how it works?
make ingest region size not exceed regionSplitSize by:

use sample data to calculate kv range for each region.
Sample. When split range, first split the range from start-key to end-key to (total kv count) / 100 ranges. Then seek to the key that is greater or equal to each range start. If the seeked key is smaller than the range end, add the range end to sample values. If there is enough sampled values, then split the sample values to the target count and each split end with be the range end. If there are no enough sample values, we will fall back to the old naive way to split, but will use the db iterator the check empty ranges and skip them.
Region Size. when split regions, use 3/4 of the splitRegionSize to calculate the split size. And when ingest, use 5/4 splitRegionSize as the threshold. At each write and ingest phase, write no more than this threshold byte to tikv and ingest it. If there are remian kvs, split target region and try to ingest the remain bytes. By this way, we can make sure each region size will not exceed 5/4 * splitRegionSize in bytes.

This pr also emit some useless logs to make the error and warn logs less annoying.
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Possible performance regression

benchmark with 14k warehouse tpcc data shows no performance regression

Increased code complexity

Related changes

sad for the code coverage decrease, the new logic for split need large scale test data

I'm not sure what's the implementation in this PR, but a kind remember: In TiKV there are two region split methods, by size and by number of keys. When size or number of keys exceed the threshold the region will be splited. In lightning we'd better respect both mechanism, to avoid too many keys (which will also slow down the scanning).

I'm not sure what's the implementation in this PR, but a kind reminder: In TiKV there are two region split methods, by size and by number of keys. When size or number of keys exceed the threshold the region will be splited. In lightning we'd better respect both mechanism, to avoid too many keys (which will also slow down the scanning).

Thanks for the reminder. I update the split regions by take both size in bytes and key-value count into account.

/run-all-tests

@kennytm  @3pointer  @YuJuncen  PTAL again


Update dbt_project config-version to 2 to silence warnings with dbt 0.17.0+

After the release of dbt 0.17.0, the snowflake_utils module causes the following deprecation warning to be emitted by dbt:
* Deprecation Warning: dbt v0.17.0 introduces a new config format for the
dbt_project.yml file. Support for the existing version 1 format will be removed
in a future release of dbt. The following packages are currently configured with
config version 1:
 - snowflake_utils

For upgrading instructions, consult the documentation:
  https://docs.getdbt.com/docs/guides/migration-guide/upgrading-to-0-17-0

This silences that warning.
I also propose bumping the minor version number if you merge this PR to 0.2.0 from 0.1.3.  I represented my intent by setting the dbt_project.yml::version to 0.2.0 although, that field is not yet used internally by dbt and you will need to tag post merge and whatever other mechanisms are needed for dbt-hub to have new versions published.

@sethwoodworth Seth, thank you for the contribution. :)


[1.16] Mystical agriculture ores not added to ore laser recipes

DO NOT REPORT AN ISSUE IF YOU HAVEN'T TESTED THE ISSUE WITH THE LATEST VERSION IN CURSEFORGE
Industrial Foregoing Version:
1.16.5-<IP_ADDRESS>-2b762d7
Titanium Version:
1.16.4-3.2.5
Crashlog If Applicable (Upload to pastebin/gist):

Any chance you adding Soulium ore to the Brown laser lens when in the nether?
As it doesn't exist at the moment with anything from Industrial Foregoing for the lasers.
If not that sorry to bother you


ressource id type array leads to invalid generated code

Problem statement
Using an array type as ressource id leads to invalid generated code.
func ({{ .ReceiverName }} *{{ pascalize .Name }}URL) Build() (*url.URL, error)
in
\templates\server\urlbuilder.gotmpl
expects that {{ varname .ID }} is a string, but {{ .Formatter }} does not work for arrays.
Please remove the sections that don't apply
Swagger specification
paths:
/resource/{resource}/{IDs}:
get:
...
parameters:
IDs:
name: IDs
in: path
description: A singele object ID or a comma seperated list of objects IDs.
type: array
items:
type: string
collectionFormat: csv
minItems: 1
uniqueItems: true
required: true
Steps to reproduce
generate go code with an array type as ressource id
Environment
swagger version: commit/278bee9f9204f7941f11df84fe6f09dded3bdb19
go version: 1.9
OS:  any

Should be fixed with PR #1394.
To be tested again.


Update aspnet50/aspnetcore50 => dnx50/dnxcore50.

Prepping to be merged once ready.

Hi @NTaylorMullen, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Taylor Mullen). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla2.msopentech.com.

TTYL, MSOTBOT;

:shipit:

:shipit:


Closes #94

Hello everyone,
I intend to solve this issue (#94) while I have some free time. But I am gonna need some help.
I rebased the latest version of knex-schema-inspector. But in the pipeline, I see the following errors;
1) sqlite
       .columnInfo
         returns information for all columns in all tables:
     SqliteError: select `name` from `sqlite_master` where sql LIKE "%AUTOINCREMENT%" - no such column: %AUTOINCREMENT%
      at Database.prepare (node_modules/better-sqlite3/lib/methods/wrappers.js:5:21)
      at Client_BetterSQLite3._query (node_modules/knex/lib/dialects/better-sqlite3/index.js:30:34)
      at executeQuery (node_modules/knex/lib/execution/internal/query-executioner.js:37:17)
      at Client_BetterSQLite3.query (node_modules/knex/lib/client.js:146:12)
      at Runner.query (node_modules/knex/lib/execution/runner.js:130:36)
      at ensureConnectionCallback (node_modules/knex/lib/execution/internal/ensure-connection-callback.js:13:17)
      at Runner.ensureConnection (node_modules/knex/lib/execution/runner.js:307:20)
      at Runner.run (node_modules/knex/lib/execution/runner.js:30:19)

https://github.com/knex/knex-schema-inspector/runs/8266354215?check_suite_focus=true#step:10:197

At this point, what should I do?

Should I extend dialects/sqlite.ts file?
Should I work on the dialects/sqlite.ts file, and implement the changes for Client_SQLite3?

Also, should I use the same test file or create a new one for the better-sqlite?

@kibertoad, can you review this, please?


ModuleNotFoundError: No module named 'pciSeq.src.preprocess.imimposemin'

Hi,
When I tried to do cell segmentation on a tif image provided at https://figshare.com/articles/dataset/CA1_neuron_cell_typing_results_of_pciSeq_probabilistic_cell_typing_by_in_situ_sequencing_/7150760/1. And I found I cannot import the function --imposemin.
from src.preprocess.imimposemin import imimposemin
from skimage.color import label2rgb
from skimage.util import img_as_ubyte
from skimage.morphology import disk
import math
from matplotlib import pyplot as plt
import logging
img_url = r"./CA1DapiBoundaries_4-3_right.tif"
coo, CellMap_0 = watershed(img_url)
ERROR: ModuleNotFoundError: No module named 'src'
Then I modified the code appropriately
from pciSeq.src.preprocess.imimposemin import imimposemin
ERROR: ModuleNotFoundError: No module named 'pciSeq.src.preprocess.imimposemin
I guess the immposemin package may be missing, can you re-upload it to github?
Sincerely look forward to your reply！！

Yes, this is missing indeed, the function was used for watershed segmentation but it is deprecated now, I should have removed it I would say use some other tool like cellpose if possible

Thanks for the prompt reply, cellpose is indeed a good choice.


Fix typo in byteCounts constant

If I'm understanding their specifications correctly, selectWord64 and byteCounts are giving incorrect answers for some inputs:
> map (\i -> selectWord64 (shiftL 1 i) 0) [0..16]
[0,1,2,3,4,5,6,7,72,72,72,72,12,13,14,15,16]
> map (\i -> selectWord64 (shiftL 1 i) 0) [37..46]
[37,38,39,40,40,40,40,44,45,46]
> printf "0x%06x\n" $ byteCounts 0x070302
0x021201

Comparing the byteCounts implementation against the paper, it seems there's a typo in the lsns constant which is expanding to 0xF1E1E1E1E1E1E1E0F instead of 0x0F0F0F0F0F0F0F0F. With the constant from the paper,
> map (\i -> selectWord64 (shiftL 1 i) 0) [0..16]
[0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16]
> map (\i -> selectWord64 (shiftL 1 i) 0) [37..46]
[37,38,39,40,41,42,43,44,45,46]
> printf "0x%06x\n" $ byteCounts 0x070302
0x030201

Thanks!

Thanks =)


Add option to report UDP source IP address and port to codec

This PR adds an option to report UDP source IP address and port to codec, which is disabled by default.
Related

logstash-plugins/logstash-codec-netflow/issues/76
logstash-plugins/logstash-codec-netflow/issues/9

@maltejk can you please agree to the CLA so that this PR can move forward?
I have submitted a PR to patch logstash-codec-netflow which requires you PR here.
Thanks.

@maltejk it would be really helpful if you could agree to the CLA so that this PR can move forward. Thanks!

Dear Rob,

On 20. Nov 2019, at 06:11, Rob Cowart<EMAIL_ADDRESS>wrote:
@maltejk it would be really helpful if you could agree to the CLA so that this PR can move forward. Thanks!

We scheduled a meeting for this today so I guess I have news then.
Regards!

I'm wondering if this can get merged now. Apparently, the pipelines get stuck after 10 minutes, which does not seem to be related to the change.

Does "logstash-input-udp (3.3.4)" have the change ?

Does "logstash-input-udp (3.3.4)" have the change ?

Yes, any update here?

No update yet I'm afraid. Still waiting for this to get merged.

Hope this looks fine now.

@maltejk  After looking a bit more into this here are my thoughts.
Although the proposed fix here is extremely simple, the problem we have is that passing extra argument(s) to the codec decode function is not a defined or supported API. This would be a one-off workaround to effectively carry a stream identity into a codec.
This strategy actually creates another deeper issue; it should not be a codec responsibility to manage per-stream state. A single codec instance should only be responsible to decode a single logical stream of data. A few problems would have to be looked into, for example in the context of the netflow codec, if templates are cached per stream ID (here the UDP host) the codec would have to deal with cache invalidation and the corresponding logic and I don't think this kind of logic should be solved in each specific codec that could work per-stream /cc @robcowart.
This problem of inputs vs codecs vs streams has a long conceptual struggle history in logstash. Our  last attempt to try and provide a coherent  way forward was with the creation of the IdentityMapCodec which currently lives in the multiline codec repo and for which I created an issue to extract it as a proper codec elastic/logstash/issues/11589.
The IdentityMapCodec is used for both the multiline codec and file input and abstracts the work for an input plugin to manage codecs per stream identity by acting as a kind of codec multiplexer for these identities by creating new codec instances per stream and managing their life-cycle (for example flush and discard a codec after some inactivity on a stream). It is currently critical for the file input and in that respect it has been in-use and tested for a while.
I think we should look into using the IdentityMapCodec as part of the solution here too. Conceptually I'd rather see different netflow codecs work independently for different streams. The way I understand it, no change would be required to make the netflow codec work in that context.
Let me know if that makes sense and if this is indeed a strategy you think would work for this udp input + netflow codec problem at hand. If so, we'd be happy to provide assistance in moving this forward.

@colinsurprenant Many thank for your feedback!
I understand the requested changes would add huge complexity to this change and would be hard to review.
I would highly appreciate if we could move forward with the simple fix to get the feature upstreamed as there seems to be some demand for it. Thank you!

@maltejk Unfortunately we will not merge this. As I explained above, this will introduce a one-off and incompatible behaviour with the rest of the ecosystem. Also, this strategy will necessarily require the netflow codec to manage per-stream states which will add complexity for a strategy we are not pursuing in the first place. The hard work of managing per-stream state is already done in the IdentityMapCodec.
What I am suggesting is that we look into having the IdentityMapCodec work with the udp input and the netflow codec. This will require a some work but it should not be that hard as it was already integrated with the file input and the multiline codec for example.


Fixed: A follow-up to the source rework

This is a follow-up on the source / institution re-work.

There were a few places where the source siglum was still being used, so I fixed this. I'll keep looking.
Optimized some admin queryset with select_related
The check for what groups a user was in was triggering several SQL queries. A new template filter was added that takes a comma-separated string and uses that in a single filter() query.
The source browse chants view was doing a lot of work before a simple check that would trigger a 404. This check was moved up and simplified (It no longer checks the queryset with in but just checks the segment id matches the expected one).
The pagination custom tags were also slowing down the page loads, so they were optimized as well.

@ahankinson Looks good! Realize you didn't explicitly request review yet so lmk if this is good to merge or I was premature...

Yeah a merge is okay.


Inherit DEFAULT_CHUNK_SPLIT_NS from strax

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
Depends on https://github.com/AxFoundation/strax/pull/865, where the minimum allowed splitting of chunk is DEFAULT_CHUNK_SPLIT_NS. This PR also temporarily uses the latest strax to be compatible with the latest codes.
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

coverage: 91.145% (+0.01%) from 91.135%
when pulling 77b0de348332941952a2485c09b0cdddf1493bc5 on inherit_safe_break_in_pulses
into<PHONE_NUMBER>4a6a62182eccd8536d64dacaab41d5 on master.


MZmine 4.03 not always generating supplementary pairs file for IIMN

Hi
OS:Windows 11
MZMine version 4.03
When I click export for molecular networking it creates the .mgf file and the feature quant table, but only creates the supplementary pairs file about half of the time. Sometimes I can get it to work if I rerun the whole project through MZmine using the same settings as before but its a bit of a pain

Currently, we only export the additional edges file if there are edges available.
Would you prefer that we export an empty file?
You are running metaCorrelate and ion identity networking in the same batch configuration and once it is exported and once not?


Build remove unused library b64

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
no
What this PR does / why we need it:
Remove all traces of library b64 which is not in use any longer.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The library used to be b64, then it was ported to another one named base64, and finally removed. I just observed this, I was not involved in the removal of the library.
Does this PR introduce a user-facing change?:
NONE

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: federico-sysdig
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: federico-sysdig, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: b2d7c4de448ab9f72b4f5ba81cc713022d52f97f

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, federico-sysdig, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Remove unused code in AnimationPlayerEditor::_update_animation_list_icons()

Left-over of #58969.
It was part of the original extracted code, but became unused after I rewrote the update logic.

Thanks!

Cherry-picked for 3.5.


[FEAT] Add command under menu

Is your feature request related to a problem? Please describe.
Currently unsure if this is supported but i would like the list my command under the Other -> terminal command and be able to add a description to my custon command using this api
Describe the solution you'd like
Add a method to add a description and another method to list the command under STORE or OTHER etc..
Describe alternatives you've considered
I know that the mod api LethalAPI or something like that supports this. But it would be a nice feature since this is solely terminal based
Additional context
None

Thanks for the request. If I get the time I will look into adding something like this.

If you need any help making this, you can assign me the issue and i can work on it

If you are willing, I would very much appreciate your help.

Could i get your discord, its related to my mod but im unsure whether its the API or my mod. Add me on 299792458 (my discord)

Nice!


Error after updating to version 1.9      android 13

https://github.com/aj3423/SpamBlocker/assets/23304238/0da9a728-e6c8-445a-8e62-752765b48259
After upgrading to version 1.9, the application does not start  crashes with an error .  Reinstalling the application does not help, the application does not start either

You mean it even crashes on fresh install? I can't reproduce that, tried on Android 13 emulator
https://github.com/aj3423/SpamBlocker/assets/4710875/56395932-3e4e-4593-b6eb-76e79d729125
Can you connect the phone to a PC and capture a log? I'll show you the steps.

Вы имеете в виду, что он вылетает даже при новой установке? Я не могу воспроизвести это, пробовал на эмуляторе Android 13
nocrash.mp4
Можете ли вы подключить телефон к ПК и записать журнал? Я покажу вам шаги.

Yes, even after reinstalling the app, it doesn't run on my phone.
Unfortunately I don't have a computer 🤷

Now there is crash report in the latest tag, looks like

Please copy the content here.

Maybe try the latest v1.1.1

Maybe try the latest v1.1. Hi. Yes, this version works fine, there are no errors. Thank you for quickly correcting the error


Wayland KDE Plasma 6 stuck on software rendering

Hi! I have some apps stuck on software rendering since updating to KDE Plasma 6. This has not occured on KDE Plasma 5, and this does not occur on X11; both KDE and glxinfo have run perfectly fine, as well as other apps. Some log outputs:
(1) KDE 6 (journalctl output):
Mar 12 21:25:49 amaterasu kwin_wayland[1455]: No backend specified, automatically choosing drm
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: OpenGL vendor string:                   Mesa
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: OpenGL renderer string:                 Apple M1 (G13G B1)
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: OpenGL version string:                  4.6 (Core Profile) Mesa 24.1.0-devel
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: OpenGL shading language version string: 4.60
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: Driver:                                 Unknown
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: GPU class:                              Unknown
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: OpenGL version:                         4.6
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: GLSL version:                           4.60
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: Mesa version:                           24.1
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: Requires strict binding:                no
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: Virtual Machine:                        no
Mar 12 21:25:50 amaterasu kwin_wayland[1455]: Timer query support:                    yes
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: (WW) Option "-listen" for file descriptors is deprecated
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: Please use "-listenfd" instead.
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: (WW) Option "-listen" for file descriptors is deprecated
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: Please use "-listenfd" instead.
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: DRI driver not from this Mesa build ('24.1.0-devel' vs '24.0.2')
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: failed to bind extensions
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: DRI driver not from this Mesa build ('24.1.0-devel' vs '24.0.2')
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: failed to bind extensions
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: DRI driver not from this Mesa build ('24.1.0-devel' vs '24.0.2')
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: failed to bind extensions
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: couldn't create gbm device
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: EGL setup failed, disabling glamor
Mar 12 21:25:50 amaterasu kwin_wayland_wrapper[1526]: Failed to initialize glamor, falling back to sw

(1a) KDE 6 on X11:
Mar 12 21:45:51 amaterasu kwin_x11[5971]: OpenGL vendor string:                   Mesa
Mar 12 21:45:51 amaterasu kwin_x11[5971]: OpenGL renderer string:                 Apple M1 (G13G B1)
Mar 12 21:45:51 amaterasu kwin_x11[5971]: OpenGL version string:                  4.6 (Compatibility Profile) Mesa 24.1.0-devel
Mar 12 21:45:51 amaterasu kwin_x11[5971]: OpenGL shading language version string: 4.60
Mar 12 21:45:51 amaterasu kwin_x11[5971]: Driver:                                 Unknown
Mar 12 21:45:51 amaterasu kwin_x11[5971]: GPU class:                              Unknown
Mar 12 21:45:51 amaterasu kwin_x11[5971]: OpenGL version:                         4.6
Mar 12 21:45:51 amaterasu kwin_x11[5971]: GLSL version:                           4.60
Mar 12 21:45:51 amaterasu kwin_x11[5971]: Mesa version:                           24.1
Mar 12 21:45:51 amaterasu kwin_x11[5971]: Requires strict binding:                yes
Mar 12 21:45:51 amaterasu kwin_x11[5971]: Virtual Machine:                        no
Mar 12 21:45:51 amaterasu kwin_x11[5971]: Timer query support:                    yes

(1b) KDE 5 on Wayland:
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: No backend specified, automatically choosing drm
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: OpenGL vendor string:                   Mesa
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: OpenGL renderer string:                 Apple M1 (G13G B1)
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: OpenGL version string:                  4.6 (Core Profile) Mesa 24.1.0-devel
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: OpenGL shading language version string: 4.60
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Driver:                                 Unknown
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: GPU class:                              Unknown
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: OpenGL version:                         4.6
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: GLSL version:                           4.60
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Mesa version:                           24.1
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Linux kernel version:                   6.6
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Requires strict binding:                no
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: GLSL shaders:                           yes
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Texture NPOT support:                   yes
Mar 12 21:50:44 amaterasu kwin_wayland_wrapper[1475]: Virtual Machine:                        no
Mar 12 21:50:45 amaterasu kwin_wayland_wrapper[1475]: kwin_wayland_drm: Failed to create gamma blob! Invalid argument
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: OpenGL vendor string:                   Mesa
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: OpenGL renderer string:                 Apple M1 (G13G B1)
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: OpenGL version string:                  4.6 (Core Profile) Mesa 24.1.0-devel
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: OpenGL shading language version string: 4.60
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Driver:                                 Unknown
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: GPU class:                              Unknown
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: OpenGL version:                         4.6
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: GLSL version:                           4.60
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Mesa version:                           24.1
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: X server version:                       1.23.2
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Linux kernel version:                   6.6
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Requires strict binding:                no
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: GLSL shaders:                           yes
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Texture NPOT support:                   yes
Mar 12 21:50:46 amaterasu kwin_wayland_wrapper[1475]: Virtual Machine:                        no

(2) glxinfo on KDE 6, Wayland session:
lena@amaterasu ~> LIBGL_DEBUG=verbose glxinfo -B
name of display: :0
MESA-LOADER: failed to open /run/opengl-driver/lib/dri/zink_dri.so: /run/opengl-driver/lib/dri/zink_dri.so: cannot open shared object file: No such file or directory
MESA-LOADER: failed to open zink: /run/opengl-driver/lib/dri/zink_dri.so: cannot open shared object file: No such file or directory (search paths /run/opengl-driver/lib/dri, suffix _dri)
failed to load driver: zink
MESA-LOADER: dlopen(/run/opengl-driver/lib/dri/swrast_dri.so)
did not find extension DRI_Kopper version 1
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
did not find extension DRI2_Flush version 1
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: llvmpipe (LLVM 17.0.6, 128 bits) (0xffffffff)
    Version: 24.1.0
    Accelerated: no
    Video memory: 15641MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 4.5
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 0 MB, largest block: 0 MB
    VBO free aux. memory - total: 12560 MB, largest block: 12560 MB
    Texture free memory - total: 0 MB, largest block: 0 MB
    Texture free aux. memory - total: 12560 MB, largest block: 12560 MB
    Renderbuffer free memory - total: 0 MB, largest block: 0 MB
    Renderbuffer free aux. memory - total: 12560 MB, largest block: 12560 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 827587 MB
    Total available memory: 843229 MB
    Currently available dedicated video memory: 0 MB
OpenGL vendor string: Mesa
OpenGL renderer string: llvmpipe (LLVM 17.0.6, 128 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 24.1.0-devel
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.5 (Compatibility Profile) Mesa 24.1.0-devel
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.1.0-devel
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

(2a) glxinfo output on KDE 6, X11 session:
lena@amaterasu ~> LIBGL_DEBUG=verbose glxinfo -B
name of display: :0
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
using driver apple for 4
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
MESA-LOADER: device is not located on the PCI bus
using driver apple for 4
MESA-LOADER: dlopen(/run/opengl-driver/lib/dri/apple_dri.so)
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
Using DRI3 for screen 0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: Apple M1 (G13G B1) (0xffffffff)
    Version: 24.1.0
    Accelerated: yes
    Video memory: 15641MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
OpenGL vendor string: Mesa
OpenGL renderer string: Apple M1 (G13G B1)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 24.1.0-devel
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.6 (Compatibility Profile) Mesa 24.1.0-devel
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.1.0-devel
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

(2b) glxinfo output on KDE 5, Wayland:
lena@amaterasu ~> LIBGL_DEBUG=verbose glxinfo -B
name of display: :0
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
using driver asahi for 4
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
MESA-LOADER: device is not located on the PCI bus
using driver asahi for 4
MESA-LOADER: dlopen(/run/opengl-driver/lib/dri/asahi_dri.so)
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/lena/.drirc: No such file or directory.
Using DRI3 for screen 0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: Apple M1 (G13G B1) (0xffffffff)
    Version: 24.1.0
    Accelerated: yes
    Video memory: 15641MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
OpenGL vendor string: Mesa
OpenGL renderer string: Apple M1 (G13G B1)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 24.1.0-devel
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.6 (Compatibility Profile) Mesa 24.1.0-devel
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.1.0-devel
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

(3) Hopefully relevant config snippets:
  hardware.opengl = {
    enable = true;
    driSupport = true;
    driSupport32Bit = lib.mkForce false;
  };

  hardware.asahi = {
    useExperimentalGPUDriver = true;
    experimentalGPUInstallMode = "replace";
    setupAsahiSound = true;
    withRust = true;
  };

Having the same overall issue, although with a different error after kwin tries to load the DRM backend:
Apr 03 23:31:39 nixos kwin_wayland_wrapper[4463]: MESA-LOADER: failed to open apple: /run/opengl-driver/lib/dri/apple_dri.so: cannot open shared object file: No such file or directory (search paths /run/opengl-driver/lib/dri, suffix _dri)

same issue for me running sway. I cannot get sway to render even with WLR_RENDERER_ALLOW_SOFTWARE = 1

may also be related to this https://github.com/tpwrules/nixos-apple-silicon/issues/159#issuecomment-2053684818

Also getting:
MESA-LOADER: failed to open apple: /run/opengl-driver/lib/dri/apple_dri.so: cannot open shared object file: No such file or directory (search paths /run/opengl-driver/lib/dri, suffix _dri)

when trying to run Hyprland

if you have macbook Pro with touchbar, it may use wrong gpu. Try to set
environment.variables = {
  WLR_DRM_DEVICES = "/dev/dri/card0";
};


Regression on generated schemas between 1.28 and 1.29

Hi. I think I've stumbled upon a regression in the generated schema in the contract tests. This appears to have been introduced in 1.29.
I've got an API that has its response defined as follows:
      responses:
        "200":
          description: A list of Category Objects
          content:
            application/json:
              schema:
                type: object
                properties:
                  categories:
                    type: array
                    items:
                      oneOf:
                        - $ref: "#/components/schemas/categoryObject"
                        - $ref: "#/components/schemas/categoryGroupObject"

So essentially, the API returns an object with a property called categories, which is an array of objects which can be one of two types.
In Portman 1.28, the schema generated in the contract test for this API looks like this (somewhat abbreviated for simplicity):
{
  "type": "object",
  "properties": {
    "categories": {
      "type": "array",
      "items": {
        "oneOf": [
          {
            "type": "object",
            "additionalProperties": false,
            "properties": {
              "id": {
                "type": "integer",
                "format": "int64",
                "nullable": false,
                "description": "A system defined unique identifier for the category."
              },
              "name": {
                "type": "string",
                "nullable": false,
                "description": "The name of the category.",
                "minLength": 1,
                "maxLength": 100
              },
              "is_group": {
                "type": "boolean",
                "enum": [
                  false
                ],
                "description": "For categoryObject, is_group is always false."
              }
            },
            "required": [
              "id",
              "name",
              "is_group"
            ]
          },
          {
            "type": "object",
            "properties": {
              "id": {
                "type": "integer",
                "format": "int64",
                "nullable": false,
                "description": "A system defined unique identifier for the category."
              },
              "name": {
                "type": "string",
                "nullable": false,
                "description": "The name of the category.",
                "minLength": 1,
                "maxLength": 100
              },
              "is_group": {
                "type": "boolean",
                "enum": [
                  true
                ],
                "description": "For categoryGroupObject, is_group is always true."
              },
              "group_id": {
                "type": [
                  "integer",
                  "null"
                ],
                "format": "int64",
                "description": "The ID of the category group this category belongs to or `null` if the category doesn't belong to a group, or is itself a category group."
              },
              "children": {
                "type": "array",
                "items": {
                  "type": "integer"
                },
                "description": "For category groups, this will populate with the child category IDs."
              }
            },
            "required": [
              "id",
              "name",
              "is_group"
            ]
          }
        ]
      }
    }
  }
}

So, the key thing to notice about this (correct) schema is that it captures the OneOf property.
Here's the (simplified) schema generated by 1.29.0:
{
  "type": "object",
  "properties": {
    "categories": {
      "type": "array",
      "items": {
        "type": "object",
        "additionalProperties": false,
        "properties": {
          "id": {
            "type": "integer",
            "format": "int64",
            "nullable": false,
            "description": "A system defined unique identifier for the category."
          },
          "name": {
            "type": "string",
            "nullable": false,
            "description": "The name of the category.",
            "minLength": 1,
            "maxLength": 100
          },
          "is_group": {
            "type": "boolean",
            "enum": [
              false
            ],
            "description": "For categoryObject, is_group is always false."
          }
        },
        "required": [
          "id",
          "name",
          "is_group"
        ]
      }
    }
  }
}

Notice that this generated schema does not have a oneOf property. It expects all objects in the returned array to match the first schema in the oneOf list.
I hope this makes sense. @thim81, I'm not ready to share the full spec publicly, but I've added you to a private repo that will allow you to grab it and reproduce it if you are able to.

@jpjpjp I'll look into this and see what we can find as a resolution.

hi @jpjpjp
We have found the cause of the OAS object not being Immutable and have a PR ready for review.

hi @jpjpjp
We just released Portman 1.29.3, which contains a fix for the JSON schema issue you faced.
Let us know if it your issue is solved, by closing the issue.
If there is another regression, please do keep reporting it.

Happy to confirm that v1.29.3 addresses the issue I originally reported, and continues to generate the rest of my tests as expected.
Thank you!!


Update dartdoc to 0.39.0.

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.39.0
The most interesting bit for Flutter is a fix for a regression in sidebar generation.
Tested by running the docs.sh script and spot checking that pages loaded and search works.

This did not merge ; I guess I didn't notice that I had accidentally removed the waiting-for-green label.


pipe after end with core streams

This shows a problem with Composer.pipeline when used with pipeline and Readable.from from node core streams.

was missing a plan, added in master


posterior_predictive and log_likelihood could have sample names

Here is an example of an InferenceData object
print(repr(combined['posterior_predictive']))
<xarray.Dataset>
Dimensions:          (chain: 1, draw: 1000, features: 2055, y_predict_dim_0: 381)
Coordinates:
  * chain            (chain) int64 0
  * draw             (draw) int64 0 1 2 3 4 5 6 ... 993 994 995 996 997 998 999
  * y_predict_dim_0  (y_predict_dim_0) int64 0 1 2 3 4 5 ... 376 377 378 379 380
  * features         (features) object 'EC:<IP_ADDRESS>' ... 'EC:<IP_ADDRESS>'
Data variables:
    y_predict        (features, chain, draw, y_predict_dim_0) float64 ...
Attributes:
    created_at:                 2021-05-01T19:35:39.705402
    arviz_version:              0.11.2
    inference_library:          cmdstanpy
    inference_library_version:  0.9.68

print(repr(combined['log_likelihood']))
<xarray.Dataset>
Dimensions:          (chain: 1, draw: 1000, features: 2055, log_lhood_dim_0: 381)
Coordinates:
  * chain            (chain) int64 0
  * draw             (draw) int64 0 1 2 3 4 5 6 ... 993 994 995 996 997 998 999
  * log_lhood_dim_0  (log_lhood_dim_0) int64 0 1 2 3 4 5 ... 376 377 378 379 380
  * features         (features) object 'EC:<IP_ADDRESS>' ... 'EC:<IP_ADDRESS>'
Data variables:
    log_lhood        (features, chain, draw, log_lhood_dim_0) float64 ...
Attributes:
    created_at:                 2021-05-01T19:35:39.710798
    arviz_version:              0.11.2
    inference_library:          cmdstanpy
    inference_library_version:  0.9.68

Here, y_predict_dim_0 and log_lhood_dim_0 correspond to biological sample names, but that information is lost when the InferenceData object is created. It would be super useful if the sample information is retained.  I think should boil down to modifying this block of code with

     if log_likelihood is not None:
         ll_ds = xr.concat(group_list[2], concatenation_name)
         ll_ds = ll_ds.rename_dims({'log_lhood_dim_0': sample_name})
         group_dict["log_likelihood"] = ll_ds
     if posterior_predictive is not None:
         pp_ds = xr.concat(group_list[3], concatenation_name)
         pp_ds = pp_ds.rename_dims({'y_predict_dim_0': sample_name})
         group_dict["posterior_predictive"] = pp_ds
     ...
     group_ds = group_dict[group].assign_coords(
            {concatenation_name: coords[concatenation_name],
             sample_name : coords[sample_name]}
      )

If I'm understanding your request correctly, this should already be possible by specifying the coords/dims of LL/PPC in to_inference_object.
See the following example from the custom LME page.
inference = nb_lme.to_inference_object(
    params=["beta", "phi", "subj_int"],
    dims={
        "beta": ["covariate", "feature"],
        "phi": ["feature"],
        "subj_int": ["subject"],
        "log_lik": ["tbl_sample", "feature"],
        "y_predict": ["tbl_sample", "feature"]
    },
    coords={
        "feature": nb_lme.feature_names,
        "covariate": nb_lme.colnames,
        "subject": groups,
        "tbl_sample": nb_lme.sample_names
    },
    alr_params=["beta"],
    posterior_predictive="y_predict",
    log_likelihood="log_lik",
    include_observed_data=True
)

Let me know if I've misunderstood.

got it ... ok I don't think this is a problem, looks like I wasn't specifying it correctly.


enforce dev=self binding

The role manager needs to enforce that dev=self, svro contraints are met.

open https://makecode.microbit.org/beta#pub:github:pelikhan/pxt-kitronik-i2c-16-servo/jacdac
run simulators
make sure roles are bound to the correct service

fixed


Some „Weblate“ components are locked due to incorrect configuration.

Seeing that I requested „sshtunnel“ and „alist“ a month ago to Lithuanian, not to mention some others, that I have missed, but they are simply blocked to be added for translation, due to how it is configured, more in depth discussion https://github.com/openwrt/luci/issues/3183
Simply put, some components are locked to maintainers, so when a component gets added, like „alist“ by a chinese developer, then only his translation is added, and every single other language is locked out.
Example:

The best way to fix this, is to add all components to the existing languages, Russian doesn't have „xinetd“, because it is also locked, making the 100% translated quote incorrect.
It's a very easy problem to solve.
Have a nice day, and happy Christmas along with the previous day's new year!

This is not a config issue, rather, neglect.
I've worked through the luci repo and everything should have po files for all languages now.
( from at least commit hash 7b445ef406d43ab64911c2b97481873d4333b6e4 )
Have at it 😄

Still didn't solve the problem This problem needs to be solved by the maintenance staff of the website I don't know why the OpenVPN translation was emptied

@systemcrash  Please delete the zh file. The translated documents of the Chinese are zh_Hans and zh_Hant

@systemcrash  Please delete the zh file. The translated documents of the Chinese are zh_Hans and zh_Hant

Once I get back home after holidays, I will try to figure out why some components seem locked for casual supers, while some are not. It is probably something in the component-specific config.
There have been lots of new languages for many modules created by casual users, while only a few seem to fail, and cause that "request".
So, I disagree with @systemcrash opinion, that "it is neglect, not config issue".
Weblate requires quite a few settings per component, so it is quite possible that some components are missing some settings.
Ps. Adding all languages to all components seems unnecessarily extensive, as only a few languages are really actively translated. Most languages have been started, but only small amounts have been translated. Adding those never-to-be-actually-translated languages to many components will just cause us lots of CPU cycle burning at buildbot.

I've probably single-handedly destroyed weblate "translated" stats  😃

@systemcrash Please delete the zh file. The translated documents of the Chinese are zh_Hans and zh_Hant

Yeah, well spotted. The fix is in 68d8c0517a7f4ee095603b1185a31059cc007f0f

So, I disagree with @systemcrash opinion, that "it is neglect, not config issue".

In any case, the .po(t) files now exist for the remainder of luci projects, so i18n is now at least possible.

Ps. Adding all languages to all components seems unnecessarily extensive, as only a few languages are really actively translated. Most languages have been started, but only small amounts have been translated. Adding those never-to-be-actually-translated languages to many components will just cause us lots of CPU cycle burning at buildbot.

I considered this. Although i18n is a continuous effort. At least some languages now have po files that weren't there before, for those popular languages.

@hnyman Perhaps config can be used to prevent more churn for those 'unpopular' languages. But if you wish to share which those are, I could update the luci i18n build tools and prune those out.
I don't think that would be a great strategy, however.

applications/luciappexample/po/zh_Hans/example.po,
There is an error with this suffix @systemcrash

In any case, the maintainers have noticed the problem of the translation website. They only need to solve this problem. In the future, users of newly added components will be able to create translation files and translate them by themselves. This problem seems to be traced back to LuCI/applications/smartdns


[SPARK-30564][SQL] Revert Block.length and use comment placeholders in HashAggregateExec

What changes were proposed in this pull request?
SPARK-21870 (cb0cddf#diff-06dc5de6163687b7810aa76e7e152a76R146-R149) caused significant performance regression in cases where the source code size is fairly large as HashAggregateExec uses Block.length to decide on splitting the code. The change in length makes sense as the comment and extra new lines shouldn't be taken into account when deciding on splitting, but the regular expression based approach is very slow and adds a big relative overhead to cases where the execution is quick (small number of rows).
This PR:

restores Block.length to it's original form
places comments in HashAggragateExec with CodegenContext.registerComment so as to appear only when comments are enabled (spark.sql.codegen.comments=true) and

Before this PR:
deeply nested struct field r/w:           Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
250 deep x 400 rows (read in-mem)                  1137           1143           8          0.1       11368.3       0.0X

After this PR:
deeply nested struct field r/w:           Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
250 deep x 400 rows (read in-mem)                   167            180           7          0.6        1674.3       0.1X

Why are the changes needed?
To fix performance regression.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.

Test build #120646 has started for PR 28083 at commit e67f80d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25348/
Test PASSed.

Test build #120646 has finished for PR 28083 at commit e67f80d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120646/
Test PASSed.

cc @maropu and @cloud-fan

Thank you for reporting, @peter-toth .
Can we have an example to verify?

The change looks fine to me. Could you put the WideSchemaBenchmark performance numbers in the PR description before/after this PR?

Any update? Still WIP?

Yes still WIP, didn't have time to work on this unfortunately. I will try to sort this out during the weekend.

Yes still WIP, didn't have time to work on this unfortunately. I will try to sort this out during the weekend.

I still prefer the other PR instead of this one so let me leave this in WIP for now.

I've added perf numbers as @maropu asked and removed WIP.
This PR can be an alternative to revert https://issues.apache.org/jira/browse/SPARK-21870 as a whole (https://github.com/apache/spark/pull/28041#issuecomment-613376751)
cc @kiszk @cloud-fan @dongjoon-hyun @rxin

Looks good to me

retest this please

Test build #121300 has started for PR 28083 at commit e67f80d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25984/
Test PASSed.

Test build #121300 has finished for PR 28083 at commit e67f80d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121300/
Test FAILed.

retest this please

Test build #121309 has started for PR 28083 at commit e67f80d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25993/
Test PASSed.

Test build #121309 has finished for PR 28083 at commit e67f80d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121309/
Test PASSed.

Test build #121357 has started for PR 28083 at commit 84a3e1e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26041/
Test PASSed.

The last Jenkins job passed and the last commit has only comments. So, I merged this to master/3.0. Thanks, all!

Thanks all for the review.

Test build #121357 has finished for PR 28083 at commit 84a3e1e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121357/
Test PASSed.

+1, late LGTM. Thank you all.


feat(UI): Use a double chevron as focus mode button icon

Closes #583

Could you please solve the merge-conflict @rouk1 , thanks.


Csv Export & CellTemplate

On UI-Grid, I have a cellTemplate on a field which add some addition information to that cell content.
If I export the data of this grid using csv export this does not considering cell template on that field.
Is there a way through which CSV export should export data displayed to user on grid using cellTemplate.
Example:
http://plnkr.co/edit/0IjYEdVsK7ryrcU8poYb?p=preview
In the above plunkr, ui-grid has a field as name having cellTemplate which prefix name with "Hello"  and I want to export the data with "Hello" name in the csv format.

Exporter cannot see the rendered data, it works against the data in the data array.  If you want custom formatting you'd need to use exporterFieldCallback: http://ui-grid.info/docs/#/api/ui.grid.exporter.api:GridOptions

If I have 10 columns each having different cellTemplate than in exporterFieldCallback function I need to handle each column differently, am I correct?

Yes, correct.  I believe the callback provides the row and column so you could detect this in code.

Solution provided that should allow resolution, no further correspondence, assuming that solution resolved the problem.


unpatch Object.defineProperty/ies after done using it

If there is a linked issue, mention it here.

[x] Bug - https://github.com/skatejs/skatejs/issues/1428
[ ] Feature

Requirements

[x] Read the
contribution guidelines.
[ ] Wrote tests.
[x] Updated docs and upgrade instructions, if necessary.
[x] Updated TS definitions, if necessary.

Rationale
Why is this PR necessary?
So that we don't mess with APIs that can be used by end users.
Implementation
Why have you implemented it this way? Did you try any other methods?
n/a
Open questions
Are there any open questions about this implementation that need answers?
n/a

Released in 0.19.2!


I want to run a JS wrapper within my application

Blocked by:

[ ] Define the developer experience
[ ] Create tests that invoke a JS wrapper directly


Refresh the rows for height and offset on every change

This commit ensures the infinite scroll handler is only executed, if the container is scrolled until the scrollDistance. Prior only the initial height was used, so if the height has changed, due to new elements being added, these were not considered in the new height.
Also I've put the scroll distance into the attributes, and defaulted the value to 0.3 so you can adjusted it from the outside.

thanks for PR I will take a look soon

@luaks and finally I have found time to merge it. Thanks!


improve management of queue archives

pgmq.archive() deletes the message from the queue and inserts it into the queue's archive table. Messages will remain in the archive table indefinitely. Depending on volume and available storage, that can become a big problem. There's nothing preventing users from managing the queue archives themselves, but I think ideally the PGMQ API provides this for users.
In the Tembo platform, we are partitioning the archive table with pg_partman manually. Below is how we migrate an existing archive table into a partitioned table. Note: this does not migrate existing archive data to the new partitioned archive table:
Here the queue name is "data_plane_events".
BEGIN;

ALTER TABLE pgmq.a_data_plane_events RENAME TO a_data_plane_events_old;

-- DDL from existing table / same as PGMQ def but with partitioning
CREATE TABLE pgmq.a_data_plane_events (
	msg_id bigint NOT NULL,
	read_ct int4 NULL DEFAULT 0,
	enqueued_at timestamptz NULL DEFAULT now(),
	archived_at timestamptz NULL DEFAULT now(),
	vt timestamptz NULL,
	message jsonb NULL
)
PARTITION BY RANGE (archived_at);
ALTER INDEX pgmq.archived_at_idx_data_plane_events RENAME TO archived_at_idx_data_plane_events_old;
CREATE INDEX pgmqarchived_at_idx_data_plane_events ON pgmq.a_data_plane_events (archived_at);

-- initialize partman
SELECT public.create_parent(
    'pgmq.a_data_plane_events',
    'archived_at',
    'native',
    'daily'
);
-- set retention
UPDATE part_config
    SET retention = '30 days',
        retention_keep_table = false,
        retention_keep_index = false,
        infinite_time_partitions = true
    WHERE parent_table = 'pgmq.a_data_plane_events';

select public.run_maintenance();

COMMIT;

Once data ages out the aged partitions are just dropped and that data is lost. I think a better solution would be have the option to move the partitions to S3 instead of dropping them. We could do this by integrating with pg_tier. Those aged partitions would move to S3 and remain queryable (albeit slower). This would effectively provide a "bottomless" storage for the queue archives.

partitioning added for archives in https://github.com/tembo-io/pgmq/pull/282
I think an integration with pg_tier would still be beneficial but will create a new issue to track that.


embassy-sync: add LazyLock

LazyLock is inspired by Rust 1.80.0's std::sync::LazyLock type.

Could you add an entry to the embassy-sync/CHANGELOG.md as well please? (under unreleased)

Done


Multiple random languages show up (Spanish, English, Hungarian) in same screen

So things generally work, but I still see multiple languages appear when using this component, sometimes even within the same screen. Voice navigation and directions are always in English (I'm in the US) but other text often appears in other languages.
In this case I'm seeing a mix of Spanish, English, and Hungarian. An odd mix. Could be a tasty cuisine :) but not ideal for a consumer-facing app.

Also, it seems like https://github.com/homeeondemand/react-native-mapbox-navigation/issues/21 is still an issue. I have showsEndOfRouteFeedback={false} but I'm still getting the navigation feedback screen, which I don't really want.
Also also, clicking on "End Navigation" here has no effect.

Hey, just to say that I have the same with shouldSimulateRoute enabled. And if I click the report a problem icon I get a mix of languages.

I'm having the same issue

@soboko and @jimhill Did you ever find a working solution?

Has anyone found something around this? Mine is only showing russian

Hey there. We actually ended up writing our own smaller lib (as we only needed a small bit) in combination with Swift Package Manager. I know that's not a great answer, but it meant we got to run v2+ rather than 1+. That completely fixed it.

@jimhill Oh nice, I'm trying to do that but can't find a clear way around using UIViewController since the native modules won't display those. Mind sharing any workaround you have for that with the current versions if you ran into something similar? I'm currently just following the steps here to try and get the map rendered https://docs.mapbox.com/ios/maps/guides/install/

I am still facing this issue. Did anyone manage to get it resolved?
I tested mapbox-navigation-ios-examples whcih is Swift project(https://github.com/mapbox/mapbox-navigation-ios-examples), but it's working properly.
But not working in the react-native project(https://github.com/homeeondemand/react-native-mapbox-navigation).
The difference I found is that the Swift project uses use_framework.


Placeholder is missing in datagrid that has footer

Placeholder is missing in data grid that has footer.

I was only able to reproduce this issue when using Datagrid with Grouping.
If you have more use-cases, please provide them as well.