fix: validate inputs before serialization in @farcaster/js

Motivation
closes #404
Change Summary

add validations on all serialization functions that take a hex value as input

Merge Checklist
Choose all relevant options below by adding an x now or at any time before submitting for review

[x] The title of this PR adheres to the conventional commits standard
[x] The PR has been tagged with the appropriate change type label(s) (i.e. documentation, feature, bugfix, or chore)

re #425, I refactored all the factories that returned hex strings with the Hex suffix (e.g. Factories.TransactionHash for bytes and Factories.TransactionHashHex for hex string) and followed this convention for validation functions (w/ Hex suffix for string validations, w/o for byte)


[RHCLOUD-16868] Setting the correct response status

One task for changes in handlers and one task for added tests
https://issues.redhat.com/browse/RHCLOUD-16868
https://issues.redhat.com/browse/RHCLOUD-16726

api/sources/v3.1/application_types/{{id}}/sources
api/sources/v3.1/source_types/{{id}}/sources

both use SubCollectionList() in source_dao.go, so for NotFound case we need to return "application type not found" or "source type not found" ... my idea was that we can use baseObject field in RelationObject struct, but it is private ... so I create new method which returns text representation of object type

I know this PR is mess a little bit ... I think in the end I can squash second and third commit if review will be ok

Checks failed but I will be solved by https://github.com/RedHatInsights/sources-api-go/pull/84


M kovalsky/caseinsensitivewarehouse

Loving this!! :-)

I saw your blog post so figured we can make things even simpler!

From: Mark Pryce-Maher @.>
Sent: Friday, October 11, 2024 2:35:37 PM
To: microsoft/semantic-link-labs @.>
Cc: Michael Kovalsky @.>; Author @.>
Subject: Re: [microsoft/semantic-link-labs] M kovalsky/caseinsensitivewarehouse (PR #200)
Loving this!! :-)
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/semantic-link-labs/pull/200#issuecomment-2407323376, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHBQBNS3A2HBMK6IRITXSRDZ27AZTAVCNFSM6AAAAABPYTXOSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXGMZDGMZXGY.
You are receiving this because you authored the thread.Message ID: @.***>


Added a gradio demo

Added a gradio demo with Paperspace

added necessary files

Can I ask what is the difference between this and chat_gradio/app.py ?

sorry no difference as such I missed to check the folder which had this file


[fix] Account for daylight savings when travelling to the future

Implemented in https://github.com/tactilenews/100eyes/pull/1973 out of frustration for not being able to get the test suite to pass for the flakiness of the tests.


[gpio/pinmux] Instantiate 2-stage sync in prim_filter

The GPIO instantiates prim_filter, which debounces the input signal with a shift register. However, the prim_filter module does not properly synchronize the input signal using a 2 stage synchronizer (there is path from input through the filter logic to the first flop enable).
I think it would be good to stay on the prudent side and always instantiate a 2 stage synchronizer in front of prim_filter - WDYT?

The PR adds a 2 stage synchronizer to prim_filter that is always enabled, no matter whether the debounce filter is selected or not. This also allows us to remove the synchronizer from the pinmux wakeup detector.
Signed-off-by: Michael Schaffner<EMAIL_ADDRESS>

Ok, I have made the instantiation of a 2-stage filter optional (via a parameter), and updated the affected modules.
I also extended prim_filter_cnt a bit so that the debounce threshold can be set at runtime.
I intend to use this module to unify the way things are debounced inside the sysrst_ctrl module, where relatively complicated FSMs are currently used to do the same thing.

Hm... this probably changes the timing in GPIO now, thereby leading to CI failures.
Need to dig a bit deeper.


Don't overwrite configuration with routing data.

This fixes #262, #307 and #269. I also believe it fixes #258.
It's a bit simpler than the fix proposed in #269, and passes all unit and integration tests.
I can push a beta package to npm with this fix in place, if anyone is interested in testing this. I'll release 1.11.5 including this fix and I'll port the fix to 1.12 and the master branch once someone confirms this is working for them.
//cc @gleeds @bretcope @tysjiang @SyRenity @spanditcaa PTAL

This should also fix #307.

Thanks @arthurschreiber we would be happy to help test.

@spanditcaa Let me go ahead and merge this. I'll push a beta release in a few minutes.

@spanditcaa I just pushed<EMAIL_ADDRESS>Please let me know if that version works for you.

@arthurschreiber I'll test this in my environment too.

This fails for me with the following error:
{ [ConnectionError: Database 'MYDATABASENAME' on server '' is not currently available.  Please retry the connection later.  If the problem persists, contact customer support, and provide them the session tracing ID of '{02AC65E1-3E6B-44D8-91A3-D6F977303E1F}'.]
  name: 'ConnectionError',
  message: 'Database \'MYDATABASENAME\' on server \'\' is not currently available.  Please retry the connection later.  If the problem persists, contact customer support, and provide them the session tracing ID of \'{02AC65E1-3E6B-44D8-91A3-D6F977303E1F}\'.',
  code: 'ELOGIN' }

I'm pretty sure the problem is that the serverName property in sendLogin7Packet needs to match the name of the server you are being redirected to, and not the initial server from your configuration.

@gleeds This is what @christopheranderson also described in https://github.com/pekim/tedious/issues/223, right? Let me take a look into what's going on.


Allow Entity List to filter by tags

This is a small update to the Entity Selection export mashup to allow the user to select tags to filter by. This is helpful if you are using tags to do version releases/hotfixes in complex or multi dev projects. This also includes a small change to the Git Utility Thing, to include the tags parameter for the entity query
Created and tested in TWX 9.2, I havent checked for backwards compatibility

Approved, but the functionality will be available in a new branch as part of release 5.0.0. This branch will not be used anymore as it contains 8.5 specific code.


Theme of the website (including navbar and card)

Change the theme of navbar, make each card have different theme according to category i.e. band piano and as well as the footer

/assign

Hey @Hardikpoudel  do you want to work on this issue ? If not @Abhishek-Sahoo can go ahead.


cant compile

Describe the bug
cant compile

maybe a bit more info like screenshots, what error etc would be helpful lol

I'm closing this. If you want serious help, at least submit a serious issue. Try with making one whole sentence first


Return new object in set

As proposed in #64

LGTM :deciduous_tree:

What's the difference with set bs assign if we make this change?

Only that it returns a new object instead of changing the passed one.

Ah whoops. I didn't realize assign and set were so similar, but I just remember assign works to ES6 spec (and doesn't support partial functionality).
IMO set indicates that it is setting the original object, and is more primitive than a clone and set. If a developer wants to clone the object before setting properties on them they could use 101/clone and then 101/set. However, if we make this PR's change and a developer is actually wanting to set properties on the original objects it would not be possible with a method provided in 101.

IMO set indicates that it is setting the original object

true
If we don't change the behaviour of set we should at least change the docs "returns a new obj"

@stoeffel I think you may have a typo above, so it's not clear what you mean. Currently set modifies the original object. Are you just suggesting to state that it "modifies the original" in the docs.

Since, @tomekwi was confused on set's functionality, I agree we should definitely make it more clear in the docs.
Do you guys agree about keeping set's functionality as is, because it is more primitive and can be composed with clone to produce the PR's behavior?

Do you guys agree about keeping set's functionality as is, because it is more primitive and can be composed with clone to produce the PR's behavior?

agreed :+1:

can be composed with clone

Good idea. But wait. compose(clone, set) would clone after setting. Would compose(set, clone)(obj, key, value) work like  set(clone(obj), key, value) then?

compose(set, clone)(obj, key, value) work like set(clone(obj), key, value) then?

Nope, this wouldn't be the same. But users can use it like this set(clone(obj), key, value) it's easy enough (IMO).
This compose(set, clone)(obj, key, value) is equivalent to set(clone(obj, key, value))
If we add a flip method we could do
compose(curry(flip(set), value, key), clone)

or if we make curry smarter we could add some thing like https://github.com/stoeffel/chickencurry#placeholder
compose(curry(set, void 0, value, key), clone)

This compose(set, clone)(obj, key, value) is equivalent to set(clone(obj, key, value))

So I thought, I just wasn't sure.
IMO it's not as straightforward as we'd like it — the compose way. I'd still really love set to return a new object. Here's why:

It's consistent with omit.
Immutability is at the heart of functional programming. Facebook had a take at that and ended up with a super-heavyweight immutable.js (over 50KB minified). I haven't checked set but I guess it won't be more than 10 KB with keypather and clone. And that'd probably become no more than 5 KB with ES6's assign. Anyway set could be the ultimate lightweight alternative to immutable.js.
We have lots of ways to do set without cloning. assign, the native keypather, or just obj[key] = value.
Array functions like map, filter, or reduce are immutable.
So mutability + array functions can be deadly. Even what happens in the example from the docs is really counterintuitive:

var obj = {
  foo: 1,
  bar: 2
};

// use it with array.map
var array = [obj, obj, obj]

array.map(set('foo', 100));
// `obj.foo = 100` has exactly the same effect

...isn't that confusing?
To be honest, this immutability has drawn me to 101. Like a gasp of fresh air in the ever-changing "everything is an object" environment. Let's not lose this!

Immutability is at the heart of functional programming.

Valid point since the readme states:

101 will only duplicate vanilla JS to provide Functional Programming paradigms

If we change set to return a new object we should check if all other functions are immutable.
I'm still torn between changing and not changing. But either way it should be documented correctly.

If we change set to return a new object we should check if all other functions are immutable.

It shouldn't be much of a change, if any. As far as I've seen, the only other function so far which deals with objects and changes their value is omit. It already returns a new object, just as stated in the docs and readme.

Hey guys thanks for you input, your contributions really means a lot. I've loved our conversations thus far.
I wanted to reply to explain my original thoughts with you guy on why I originally created set.
So my original intention for creating set was to create a functional version of obj[key] = val.
This way I could use it as a partial function with Array functions. I mistakenly allowed non-partial
usage set(obj, 'key', val), but I really should have not allowed this behavior (one should just
use obj['key']=val).
If we change set's behavior to return new objects this could break functionality of being able
to set properties on prototypical-class instances [new Cat(1), new Cat(2)].map(set('fur', 'spotted')).
I do not agree that set should parallel the behavior of omit (omit behaves like pick and pluck).
set should parallel del (which does not exist in 101 yet).
If I were to create del in 101, it would be a functional version of  delete obj['key'], and only allow partial
functionality. Now that you have been introduced to del, how do you guys think should it work? Does it
promote leaving set's behavior as is or does it help us see why set should be changed?
The big point for me to keep set's behavior is that changing it makes it lose functionality.
101 would not longer provide any method for setting properties on items in an array; while,
if we leave it it can be very easily composed with clone. Since it can be composed to produce
the PR's behavior, that would indicate set is more primitive as is (which is more flexible).

Then how about

keeping set as it is and pairing it consistently with del (good idea @tjmehta!)
and making a new function insert which creates a new object – in pair with omit?

If we change set's behavior to return new objects this could break functionality of being able to set properties on prototypical-class instances
It looks like clone is smart enough to leave the prototype chain intact. Check it out: http://requirebin.com/?gist=a8b46472118baa20ec6f

it can be very easily composed with clone
Can you post an example @tjmehta? I tried to figure it out above, but couldn't find an easy way.

I'm not saying we should change set if you don't like it @tjmehta – just that we need insert on top of that :)

Other ideas for insert's name:

put (my favourite)
inject
modify
...?

keeping set as it is and pairing it consistently with del (good idea @tjmehta!)

:+1:
You could compose insert like this:
var curry = require('101/curry')
var compose = require('101/compose')
var set = require('101/set')
var clone = require('101/clone')

var insert = compose(curry(set, 3), clone);

var obj = { foo: 1 }
insert(obj)('bar', 2)

http://requirebin.com/?gist=bb18a4f8a190bbf018dc

put (my favourite)

:+1:

I like the idea of 'put'!

We should not forget to update the doc:
returns a new obj with the key and value set
to
returns the same obj with the key and value set

:+1: :+1: :+1:
I'd be thrilled to do this :) But have no time until next week. Are you guys OK to wait?

I'd be thrilled to do this :) But have no time until next week. Are you guys OK to wait?

sure :+1:

@tomekwi :+1:


Removing the PBS port exposure seems to fix the torque health check

If I remove the exposure of the PBS port, the torque docker image seems to work fine in xenon. Why are these ports exposed ?

The docker-compose-rule can wait for all ports to be open using HealthChecks.toHaveAllPortsOpen().
By exposing the ports it will wait till all the torque demons are running.
The healthcheck embedded in the Dockerfile will use a client command to check if torque is ready for use.
The docker-compose-rule will by default wait for the containers to become healthy.
I guest one of these checks should be enough and I prefer the healthcheck of the Dockerfile because it is self contained and less leaky. So removing the exposed PBS ports is OK.

Great! I'll hit merge then ;-)

Please remove the section instead of commenting it out.

Will do.


test(mobile): add e2e test to ensure mobile page

make sure that it can load without errors

close #xxx

Pull Request Checklist

[ ] Related tickets or issues have been linked in the PR description (or missing issue).
[ ] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[ ] Unit tests have been added for the changes (if applicable).
[ ] Breaking changes have been documented (or no breaking changes introduced in this PR).

This should be continued after I split sheet-formula plugin.

Done in another PR.


query fails, debugSql produces valid query

Describe the bug
DebugSql returns a prefectly valid query, but the execution via Go-Jet results in a SQL error.
I suspect the issue is a boolean expression, appearing both in the group by and selection.
I have tried several different approaches, code-wise, but to no avail.
Environment (please complete the following information):

OS: linux
Database: postgres
Database driver: database/sql (via GORM)
Jet version v2.10.1

Code snippet
Code:
interactionCounts := CTE("interactionCounts")
isSelf := BoolColumn("is_self").From(interactionCounts)

col := InsightsInteractions.AuthUserID.EQ(UUID(uuid.MustParse(*authUserID)))
interactionCountsQuery := SELECT(col.AS(isSelf.Name())).FROM(InsightsInteractions).GROUP_BY(col)
err = interactionCountsQuery.Query(d.GetDBConn(), &results)

Resulting query (via DebugSql):
SELECT (insights_interactions.auth_user_id = '...') AS "is_self"
FROM public.insights_interactions
GROUP BY insights_interactions.auth_user_id = '...';

Error:
ERROR: column "insights_interactions.auth_user_id" must appear in the GROUP BY clause or be used in an aggregate function (SQLSTATE 42803)
Expected behavior
Well, besides the obvious, I'm wondering how reliable is DebugSql if the query being executed is obviously not the one being returned from that function.

DebugSql doesn't return a query executed on db.

debugSql - this query string can be copy-pasted to sql editor and executed. It is not intended to be used in production. For debug purposes only!!!

Sql will return the query and parameters passed to db.  Sql of your query will probably return something like this:
SELECT (insights_interactions.auth_user_id = $1) AS "is_self"
FROM public.insights_interactions
GROUP BY insights_interactions.auth_user_id = $2;

Because different parameters ($1 and $2) are used in select and group by postgres returns an error.
To fix it, you can use named column in group by:
interactionCountsQuery := SELECT(
	InsightsInteractions.AuthUserID.EQ(UUID(uuid.MustParse(*authUserID))).AS(isSelf.Name()),
).FROM(
	InsightsInteractions,
).GROUP_BY(
	BoolColumn(isSelf.Name()),
)


Mergeback release v0.28.0-rc2 to alpha

Autogenerated through GH-actions.

GH action detected a potential merge conflict with the base branch (alpha).
@oblodgett please resolve the merge conflict and merge the base branch manually.


rust-bicoin community tagline contains freenode

Tag line contains:
#rust-bitcoin on freenode
This is stale, probably should be updated to say librechat

Ah, I think this has come up in the past ... the issue is that Github no longer lets us choose a location that is outside of its fixed list of countries (I guess if you have a geopolitical disagreement with GIthub you can go to hell..), so I can't figure out how to update this.

Remove altogether then?

Yeah, I'll just do that.

Ok, removed. Ok to close this issue?

Thanks


text alignment

Text alignment is not up to the mark here.
Please assign this issue to me under gssoc-extd and hacktoberfest.

please assign me this task i havent done any issue !
@aditya-bhaumik

@Kajalmehta29  sure go ahead
Make sure to join the discord server for further communication
Don't forget to star the repository
Complete the task in next 2 days and kindly mention your issue # in your pr like this:
Closes #IssueNumber
Note: the level of the issue may change based on the quality of the PR code


Migration to SDK29 seems to be causing background geolocation issues

Your Environment

Plugin version: 0.6.3
Platform: Android
OS version: Android 10
Device manufacturer and model: PixelA3

Running in Simulator: YES (And real device too)
React Native version: 0.62.2
Plugin configuration options:

{
    desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
    fastestInterval: 20 * SECOND,
    interval: 20 * SECOND,
    activitiesInterval: 5000,
    distanceFilter: 50,
    stationaryRadius: 50,
    activityType: 'AutomotiveNavigation',
    startForeground: true,
    postTemplate,
    // @ts-ignore
    syncThreshold: 50,
  }

Link to your project:
Private sources

Context

I had to migrate from SDK28 to SDK29 on Android, and it looks like since i migrated, the background geolocation isn't working anymore.
Expected Behavior

It should work ok
Actual Behavior

It seems to only be working when the app is in the foreground
Possible Fix

It looks like the foreground service isn't working, I don't know why.
Steps to Reproduce

Create a new React Native App
Added this library
Migrate to SDK29
See the background geolocation fails

Context

Debug logs

@mauron85 Do you know anything related to this issue ?
I just read about the new changes about foreground services on recent version of android :
https://developer.android.com/preview/privacy/foreground-service-types
Looks like a service might need to be defined with a new property in the AndroidManifest.xml:
<service ...
        android:foregroundServiceType="location" />

What do you think ?

Did you request this permission?
android.permission.ACCESS_BACKGROUND_LOCATION
https://developer.android.com/about/versions/10/privacy/changes

Is it fixed?

Requesting the android.permission.ACCESS_BACKGROUND_LOCATION  permission at runtime seems to have fixed it on Android. I'm still having an issue on iOS where the recording stops for a reason I can's understand yet

Did you tried on Chinese custom rom such as Oppo, Vivo ...? i stuck with it for almost 3 weeks already.

Are you using headlessTask as well?

Would you mind of sharing snippet of it?

Did you tried on Chinese custom rom such as Oppo, Vivo ...? i stuck with it for almost 3 weeks already.

Hopefully I didn't have this issue, but it might be link to this : https://dontkillmyapp.com/ what do you think ?

Are you using headlessTask as well?

No only sending the geolocation to the API in the background

Would you mind of sharing snippet of it?

Sure.
BackgroundGeolocation.configure({
      desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
      fastestInterval: 20 * SECOND,
      interval: 20 * SECOND,
      activitiesInterval: 5 * SECOND,
      distanceFilter: 50,
      stationaryRadius: 50,
      notificationTitle: i18n.geolocation.title,
      notificationText: i18n.geolocation.text,
      activityType: 'AutomotiveNavigation',
      startForeground: true,
      httpHeaders,
      pauseLocationUpdates: false,
      locationProvider: BackgroundGeolocation.DISTANCE_FILTER_PROVIDER,
      saveBatteryOnBackground: false,
      debug: false,
      stopOnTerminate: true,
      maxLocations: 100000,
      stopOnStillActivity: false,
      syncUrl: `${baseUrl}/trips/${tripId}/coordinates`,
      url: `${baseUrl}/trips/${tripId}/coordinates`,
      postTemplate,
      // @ts-ignore
      syncThreshold: 10,
    });

I think it would be nice if this library was added to https://github.com/react-native-community @react-native-community

I think it would be nice if this library was added to https://github.com/react-native-community @react-native-community

Support!

Did you tried on Chinese custom rom such as Oppo, Vivo ...? i stuck with it for almost 3 weeks already.

Hopefully I didn't have this issue, but it might be link to this : https://dontkillmyapp.com/ what do you think ?

Are you using headlessTask as well?

No only sending the geolocation to the API in the background

Would you mind of sharing snippet of it?

Sure.
BackgroundGeolocation.configure({
      desiredAccuracy: BackgroundGeolocation.HIGH_ACCURACY,
      fastestInterval: 20 * SECOND,
      interval: 20 * SECOND,
      activitiesInterval: 5 * SECOND,
      distanceFilter: 50,
      stationaryRadius: 50,
      notificationTitle: i18n.geolocation.title,
      notificationText: i18n.geolocation.text,
      activityType: 'AutomotiveNavigation',
      startForeground: true,
      httpHeaders,
      pauseLocationUpdates: false,
      locationProvider: BackgroundGeolocation.DISTANCE_FILTER_PROVIDER,
      saveBatteryOnBackground: false,
      debug: false,
      stopOnTerminate: true,
      maxLocations: 100000,
      stopOnStillActivity: false,
      syncUrl: `${baseUrl}/trips/${tripId}/coordinates`,
      url: `${baseUrl}/trips/${tripId}/coordinates`,
      postTemplate,
      // @ts-ignore
      syncThreshold: 10,
    });

Thank you bro.

I was able to fix my problems on iOS using this library :
https://github.com/transistorsoft/react-native-background-geolocation
It's free on iOS and maintained frequently

How did you migrate this to SDK29?

is this package abandoned?


Inconsistencies in tyesetting between operating systems (or versions of library χ?)

I'm still trying to track down issues with the regression tests across platforms. For some reason Arabic doesn't want to behave itself. Specifically the tests/arabic.sil file (as current in my #122 PR) doesn't compile the same way on any of OSX, my Linux system or Travis's environment. All three systems now have exactly the same font versions, so that's not the issue. Perhaps you can point me in the direction of what could be the issue.
As you can see here, the leading migrates with the OSX version being larger (in black here):

Additionally, there are individual character differences in various places. Some of them are subtle, others less so (OSX version on the right):

Is this an issue with font-config? Harfbuzz? Where could these differences be introduced that would vary three ways between systems? Note I'm not seeing this in any of the English language tests.

I would guess Harfbuzz or freetype?

That looks like a promising lead but:

OSX + Harfbuzz 0.9.41 + Freetype 2.6.1 produce the same output as Ubuntu + Harfbuzz 0.9.26 + Freetype 2.4.8 while Arch + Harfbuzz 0.9.40 + Freetype 2.5.5 is, in this case, the different one. That doesn't sound like the culprit since it's bracketed.
In a similar issue (this time with images rather than with Arabic, the latter two are the same while the first is the odd one out.

What else could it be? Could Lua 5.3 vs. 5.2 be throwing this off somehow?

The image on the left is certainly wrong.  If images are not being sized properly, then we can ignore fonts/Harfbuzz/Freetype and just concentrate on Lua.

@simoncozens Okay my bad. I didn't examine that one closely enough and now that I have it's clearly a different sort of problem. That's a float vs. int output problem throwing off the debugger. The generated PDF is identical.
git diff -U0
diff --git a/tests/image.expected b/tests/image.expected
index 0161319..3da9998 100644
--- a/tests/image.expected
+++ b/tests/image.expected
@@ -11 +11 @@ T 84 87 79    (two)
-Draw image documentation/fig1.png  77.985571410771 29.76377985 50.0    69.242902208202
+Draw image documentation/fig1.png  77.985571410771 29.76377985 50  69.242902208202
@@ -19 +19 @@ T 84 87 79    (two)
-Draw image documentation/fig1.png  77.988630333249<PHONE_NUMBER>332  36.104783599089 50.0
+Draw image documentation/fig1.png  77.988630333249<PHONE_NUMBER>332  36.104783599089 50

@khaledhosny Thanks for the insight. My Turkish doesn't get me very far into Arabic! BTW, as of a few minutes ago your fork of Libertine is available as a Homebrew Cask (brew tap caskroom/fonts; brew cask install font-libertine) and an Archlinux package.

Alright I've confirmed that:

This is font specific. Half a dozen other Arabic fonts work fine and are consistent in both places.
The same problem surfaces with this font in other files with Arabic text.
It is not a difference in font versions. I've stripped all systems down of all copies of the font (confirmed sile couldn't find it at all) then added in the raw TTF file from the working systems to the one that was failing. Same TTF, different output.
It's not Lua version specific. Travis is finally good for something today. If it was 5.3 related I would have expected 2 of these builds to succeed.

Was going to try same font + content in LaTeX / other apps but ran out of time, will edit this when I do...

So this does seem to be SILE specific. The same content rendered in the same font on the same system in Firefox, Chromium, LibreOffice and XeLaTeX all work fine. All of those have slightly different font rendering pipelines, but none of them have a problem with positioning the Arabic diacritic marks.
Here is a minimal working SILE example:
\begin[papersize=a5]{document}
\script[src=packages/bidi]
\font[size=40pt,language=ar,script=Arab]
\thisframeRTL
\font[family=Noto Naskh Arabic]{ألمّ} — \font[family=Scheherazade]{ألمّ}
\end{document}

And here is a LaTeX equivalent:
\documentclass[a5paper,40pt]{scrartcl}
\usepackage{polyglossia}
\setdefaultlanguage{english}
\setotherlanguage{arabic}
\newfontfamily\scheherazade[Script=Arabic]{Scheherazade}
\newfontfamily\notonaskh[Script=Arabic]{Noto Naskh Arabic}
\begin{document}
\RTL
\textarabic{\notonaskh ألمّ} --- \textarabic{\scheherazade ألمّ}
\end{document}

As I surmised would be the case based on newer and older versions working on other systems, updating my system to Freetype 2.6 and Harfbuzz 0.9.41 and recompiling SILE made no difference.

@khaledhosny: That is exactly what is happening. Noto Sans is returning a U+0623 Alef+Hamza above for the rightmost glyph; Scheherezade is returning this:
  {
    codepoint = 272,
    depth = 0.029296875,
    height = 4.8291015625,
    name = "uni0627",
    width = 1.4501953125,
  },
  {
    codepoint = 1052,
    depth = -4.931640625,
    height = 6.4794921875,
    name = "uni0654",
    width = 0,
    x_offset = -0.046875,
    y_offset = 0.375,
  },
}

That's interesting, but what could be cause some systems to typeset Scheherezade correctly while others trip up over the two points?

Graphite installed versus not installed?

Maybe. In that event ① it is the with variant that is failing and ② I'm not sure how I can even test it without.

Bingo - it's a graphite problem. (Paging @khaledhosny)
And it's easy to test with Homebrew now. :-)
brew uninstall harfbuzz; brew install harfbuzz; ./sile examples/bug-124.sil

produces this:

brew uninstall harfbuzz; brew install harfbuzz --with-graphite2; ./sile examples/bug-124.sil

produces this:

I can reproduce it with hb-view, with `graphite2:
hb-view /usr/share/fonts/TTF/scheherazade.ttf --shapers=graphite2 ألمّ

hb-view /usr/share/fonts/TTF/scheherazade.ttf --shapers=ot ألمّ

So it looks like a Graphite bug or (more likely) a bug in Graphite integration in HarfBuzz. I wonder if the patch in http://lists.freedesktop.org/archives/harfbuzz/2015-June/004902.html handles this. CC @mhosken.

Dear Khaled,

I can reproduce it with hb-view, with `graphite2:
hb-view /usr/share/fonts/TTF/scheherazade.ttf --shapers=graphite2 ألمّ

hb-view /usr/share/fonts/TTF/scheherazade.ttf --shapers=ot ألمّ

So it looks like a Graphite bug or (more likely) a bug in Graphite integration in HarfBuzz. I wonder if the patch in http://lists.freedesktop.org/archives/harfbuzz/2015-June/004902.html handles this. CC @mhosken.

Yes. This is fixed by that patch. Just waiting for it to be applied.
Yours,
Martin

Well, this isn't a SILE bug, so I'm closing it. Will be fixed next time @behdad releases Harfbuzz.

New HarfBuzz should have the fix.

Spiffy. Thanks for the release and the heads up @behdad!


feat(pageserver): support schedule gc-compaction

Problem
part of https://github.com/neondatabase/neon/issues/9114
gc-compaction can take a long time. This patch adds support for scheduling a gc-compaction job. The compaction loop will first handle L0->L1 compaction, and then gc compaction. The scheduled jobs are stored in a non-persistent queue within the tenant structure.
This will be the building block for the partial compaction trigger -- if the system determines that we need to do a gc compaction, it will partition the keyspace and schedule several jobs. Each of these jobs will run for a short amount of time (i.e, 1 min). L0 compaction will be prioritized over gc compaction.
Summary of changes

Add compaction scheduler in tenant.
Run scheduled compaction in integration tests.
Change the manual compaction API to allow schedule a compaction instead of immediately doing it.
Add LSN upper bound as gc-compaction parameter. If we schedule partial compactions, gc_cutoff might move across different runs. Therefore, we need to pass a pre-determined gc_cutoff beforehand. (TODO: support LSN lower bound so that we can compact arbitrary "rectangle" in the layer map)
Refactor the gc_compaction internal interface.

the abstraction yields aScheduledCompactionTask

Yes I think we need a separation from compact options from compact task. We already have GcCompactionTask in compaction.rs. I'll do a refactor to separate them out after the patches go through.

I've created an issue to track that and I'll get it done by the next Wednesday to avoid having tech debt in the code


Add optional ExternalId to sts.assume_role calls

This PR adds an optional External Id field to the AWS account model. It also updates all calls to sts.assume_role to include that external_id if it's present. Resolves #1100.

Coverage decreased (-0.03%) to 72.962% when pulling b050fb9b71da4227cc41c777af6a73259df7bd13 on dgreene-r7:add-external-id into a22611390d7f77db0fcdd363dcc7584ba02a3d21 on Netflix:develop.

LGTM -- is this working for you internally?

Yup, works perfectly.

Pushed new cloudaux version. Re-running tests.


Clarification on "Using Chakra Execution Trace and Kineto Traces Generated By PyTorch"

Hi,
Following
https://github.com/astra-sim/astra-sim#using-chakra-execution-trace-and-kineto-traces-generated-by-pytorch
The result of
$ ./build/astra_analytical/build/bin/AstraSim_Analytical_Congestion_Unaware \
  --workload-configuration=./extern/graph_frontend/chakra/et_plus/dlrm_chakra \
  --system-configuration=./inputs/system/FullyConnected.json \
  --network-configuration=./inputs/network/analytical/FullyConnected.yml \
  --remote-memory-configuration=./inputs/remote_memory/analytical/no_memory_expansion.json

is "the number of cycles it took to run the simulation"
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
...
sys[0] finished, 13271344 cycles
sys[1] finished, 14249000 cycles

I wonder what cycles mean here?
Does a cycle map to a specific time unit?
Also, what does the simulator do in this case?
Does it take all compute/communication operations and their dependencies from the dlrm_chakra Chakra format traces, then replay (simulate) it based on the system, network, and memory configurations users pass to it?
If this is the case, is the timing information that trace_link.py links from the Kineto traces ever used during the simulation? Or perhaps the et_converter will drop that information?
Thanks!

Dear @ChenYuHo ,
Thank you for your patience. We have addressed a bug related to the timing unit: https://github.com/astra-sim/astra-sim/commit/dfb4245a9f0048c93d792eecda6ebed576cb01dc To clarify, all time units in ASTRA-sim are in nanoseconds. This means the frequency is set at 1GHz, corresponding to a clock period of 1ns. This decision ensures high fidelity when integrating ASTRA-sim with other simulators. For instance, a mismatch in time scales (e.g., microsecond-scale in ASTRA-sim and nanosecond-scale in a network backend) could lead to accuracy loss.
Regarding your query about cycles, the term refers to the number of cycles required for the NPU to execute a given trace. These can be converted to nanoseconds given the 1ns clock period.
As for the simulation process, ASTRA-sim actually supports two modes: replay and simulation. This can be configured in the system settings. For detailed reference, you might want to examine the following line of code: https://github.com/astra-sim/astra-sim/blob/dfb4245a9f0048c93d792eecda6ebed576cb01dc/astra-sim/system/Sys.cc#L455. In replay mode, the actual measured runtime of operators is utilized. In contrast, simulation mode employs ASTRA-sim’s performance models.
I hope this clarifies your concerns. Feel free to reach out for any further assistance.

Thanks for the clarification.
A quick look into the code lead me to:
https://github.com/astra-sim/astra-sim/blob/dfb4245a9f0048c93d792eecda6ebed576cb01dc/astra-sim/workload/Workload.cc#L112
which seems to suggest that either all types of ETFeederNodes are replayed or simulated. Am I understanding it correctly?
I think a use case would be to simulate a subset of the types, e.g., replay all compute and memory operations but simulate communications based on different network configurations.
This can help answer the "what-if" questions regarding different network topologies, etc.

Correct. When operators are replayed, issue_replay is called. Otherwise, the corresponding issue functions are invoked.
Yes, selectively replaying operators is possible, but this might require modifications to ASTRA-sim.
You can make local changes based on your specific requirements, or alternatively, you can contribute to ASTRA-sim.

Hi @TaekyungHeo,
In replay mode, what is being simulated by astra-sim?
I tried to add "replay-only": true and ran astra-sim with the example dlrm trace provided, but got errors:
./AstraSim_Analytical_Congestion_Unaware --workload-configuration=dlrm_chakra_et/dlrm_chakra --system-configuration FullyConnected.json --network-configuration FullyConnected.yml --remote-memory-configuration no_memory_expansion.json
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
ring of node 0, id: 0 dimension: local total nodes in ring: 8 index in ring: 0 offset: 1total nodes in ring: 8
AstraSim_Analytical_Congestion_Unaware: /data/fat/nic-for-llm/trace/astra-sim/astra-sim/workload/Workload.cc:162: void AstraSim::Workload::issue_replay(std::shared_ptr<Chakra::ETFeederNode>): Assertion `node->runtime() != 0' failed.

I used the latest astra-sim repo with all submodules up-to-date. I prepared the trace exactly as instructed in the readme. Is there something missing in the trace? What is the correct way to collect the trace so one can replay it?


Edit as Code // Custom Column Templates

Coming from https://community.getgrist.com/t/edit-as-code-custom-column-templates
Hi there,
I am currently diving into grist being really awesome.
Within my data there is a lot of repetition (like meta fields… Created. Modified. User. Etc)
Checks and references are repeatedly used.
Is there a possibility to edit the code?
Otherwise maybe custom column templates might help with that.
During the writing it might be possibility to prepare template tables and duplicate them. :thinking:
Defining documents as code would be awesome, if not already possible and I simpy overlooked it.
Thank you!
Gandalf

Starting to think about how we could help here. Will assign the team on this so that I don't forget.
@paulfitz @dsagal it would be useful if you could share with us whether you've considered this option already (seeing the "code view" panel in Grist makes me think that maybe was a plan at some point ?) and whether you think there are obvious hurdles we should keep in mind (I know the Grist data engine is designed like a high-end swiss watch ⌚)
My plan if we reached a working prototype would be :

this would first live behind a feature flag
turning this feature on in a document would need to be a very conscious action by the admin of a document
manually editing code in a grist doc would deactivate all no-code features that we fear may not work properly anymore. I quite like what Metabase does for example : the nocode editor takes you as far as it can so that you don't need to write SQL yourself, but if you decide to grab the wheel and actually write/edit the SQL yourself then you agree that you can't go back to the nocode view later on.


What are some common usecases where you would define clientFetcher and serverFetcher both?

Saw this in the documentation-

My initial expectation from the names clientFetcher and serverFetcher API was that serverFetcher will run on server (so I can fetch some initial data) and then clientFetcher runs post mount where I can fetch some additional data different from what I have on server.
From the current behaviour, it seems like these are more of a getInitialClientData / getInitialServerData kind of functions which let you set the initial data and depending on navigation / load / back button click / etc, either one of them is executed.
Case 1: I define clientFetcher and serverFetcher both
In this case I was wondering, in which scenarios would you want your page to look different if it's page load vs client side navigation? wouldn't the page have same products and data fetching logic on both server and client scenario?

What are some scenarios where you're defining different logic in these 2 functions when you define both?
This would also mean I see different page depending on whether I navigated to this page with <Link/> (or with <Link target="_blank"> or with <a/> 🤔 )

These concerns could be because its a bit different way to fetch data than what is defined in other frameworks so could be about familiarity as well. The behaviour just looks a little bit error prone in the first sight.
Case 2: I only define serverFetcher
Here, my page works fine on page load but does not load anything on navigation (which I understand from tech perspective that its client navigation) but from consumer-side, it seems a bit unexpected because while developing the app, I see things working as expected on page load but then while specifically testing the client navigation, it suddenly doesn't work.
This might be something that is initially not intuitive but later gets intuitive as people get more familar with framework.
But what would be cooler is if these pages have server navigation by default (might be possible with react server components although I haven't explored it much). Then navigation will also fetch these products

Other than this, everything looks super cool and super well built to me. I love how many edge cases are already covered. The treeshaking also seems to work fine which I initially thought would break seeing this API and love to see that serverFetcher gets clipped out from client-side code 🫡 ❤

I think you’re spot on here with the initial assumption and 1mg works on the same pattern even now.
The team’s mental model so far has been that functions being executed in the serverFetcher scope should always be a subset of clientFetcher. This would also mean that clientFetcher would have to bail out on functions that were already executed successfully in serverFetcher. Right now, this seems to be something the developers will have to ensure by reading data from the router and manually ignore that subset of operations.
As you pointed out, yes, it’s in an ambiguous state right now as we figure out the right data fetching mechanism for RSC but the bigger concern is still the one I mentioned above and whether we should offload it to the devs.
Case 1: If people end up defining the same things in serverFetcher and clientFetcher because of this quirky behaviour, we should eventually bridge them as one function that runs in both domains. I’m not a fan of it personally, I’d want to keep the server and client distinction.
Case 2: we would have to keep reverting to a server navigation for this to work as expected everywhere.
Do you think we should implement the pattern we use internally back into Catalyst?

I think both usecases might be valid in that case. Personally what your internal behaviour is seems more predictable because I get a predictable output irrespective of how I ended up on that page (either with load, client navigation, server navigation, etc)

This would also mean that clientFetcher would have to bail out on functions that were already executed successfully in serverFetcher

I'm guessing this usecase exists because in scenarios like client-navigation, server data fetching would not run.
One way would be having that as an option?
Homepage.clientFetcher = ({ isFetchedOnServer }) => {
  if (isFetchedOnServer) {
    // data is already fetched on server
    return;
  }

  // fetch again
}

Homepage.serverFetcher = () => {}

Or somehow always execute serverFetcher
Or you can always make an API call to server and execute the serverFetcher. So that scenario is never there where only clientFetcher executes. Although this would mean every navigation is an API call. You might be able to cache these API calls and save some time maybe 🤔

Hey, @saurabhdaware we have started a discussion for our new data fetching approach. Would love your inputs on the same.


[DEV-5717a] Add border to maps shapes

@Atash3000 if you're done with this branch we can start deleting them after merging as well, thanks!


[Bug]: OTP input height/alignment

What happened?
Is it just me, or height of OTP inputs is slightly too big ? Or just entered input not centered correctly ?

How to reproduce the bug
Just simply login with OTP login. Enter numbers in input. You should see that entered numbers is not in the center of the box.
Package Version
1.3.5
PHP Version
8.3
Laravel Version
11
Which operating systems does with happen with?
No response
Notes
No response

This is not a bug, it's just css problems. It is not something that will affect the operation or functioning of the plugin.


[Analysis] Try using log scale on those verbosity distributions

** Describe the analysis **
Rerender those squat violin plots with a log scale, see if anything interesting is hiding there. There is probably a power law distribution going on, right?
** Output **
If relevant, add to or replace existing plots.

Tried it, and while it does dramatically change the plot, it doesn't really reveal anything of note.
An idea to keep for future visualizations but I think the existing ones are fine the way they are.


Add support for events

I'd love to see controller events stuffed into influx in a way that I can show them as annotations in grafana.

 It's gross and difficult to use. These are not metrics, and influx is the wrong database for this data. Sorry, but poller doesn't solve every problem, and this is one it cannot solve. The best we could do is create another database (mysql, psql, etc) to store the data in. Honestly, I don't think there's enough value in that to justify the expense.
I'll leave this open [for a while] for others to +1 and leave their thoughts.

Events is actually one of the stated use cases of influxdb, which is why I brought it up. It’s really useful for overlaying with annotations in grafana.

If you can give me more data about how you'd expect to find (SELECT) this data in InfluxDB, it may help my understanding of what you're looking for.

Sample insert:
insert event,user=them,ap_from=old\ ap,ap_to=new\ ap,radio_from=na,radio_to=na,ssid=pretty\ fly\ for\ a\ wifi,key=EVT_WU_Roam,subsystem=wlan,site_id=42 channel_from=36,channel_to=149,msg="User[] roams from AP[] to AP[] ..."

A query:
select "msg","ssid" from "event" where "key" = 'EVT_WU_Roam' AND $timeFilter ORDER BY time ASC limit 100

This would show annotations on a graph indicating where roam events happened, channel changes, etc.
More on Grafana annotations and influxdb: https://grafana.com/docs/grafana/latest/features/datasources/influxdb/#annotations
Influx does require a field to be returned (you can't just select tags).

Does this request cover the Wifi Metrics Anomalies from the dashboard as well ?
Or are those already exported is some way ?
Anomalies over 4 devices

1:00pm   Excessive packet drops for Access Point
9:00am   Access Point experienced high retry rates
3:00am   Long association time for Access Point
9:00pm   Excessive packet drops for Access Point

Because I'd really like to create alerts for such kind of anomalies with alertmanager i.e.

My current question is:
Does /api/s/default/stat/event contain all the same events as /api/s/default/stat/ips/event (and more) ?

/api/s/default/stat/ips/event doesn't return any events for me. I'm not using a USG or similar. Is ips "intrusion protection system"(?) or "IP (addresse)s"?  Any other endpoints I could sniff out for you?

intrusion protection system

yes.

@varac What screen/link do you see these under in your UniFi UI?

Anomalies over 4 devices

Is this Alarms ?

@varac What screen/link do you see these under in your UniFi UI?

Anomalies over 4 devices

Is this Alarms ?

@varac What screen/link do you see these under in your UniFi UI?

Anomalies over 4 devices

Is this Alarms ?

Still working in a new feature. Events support will be released probably mid-August.

Try https://github.com/unifi-poller/unifi-poller/releases/tag/v2.0.2-beta1


Update notify job to run explicitly for push or schedule events

Before:

Notify fail build does not run for PRs

After:

Notify fail build does run for only push and schedule events

This makes it so that failed manual triggers of workflow_dispatch will not create a new issue. I'm thinking since we already know the build is failing, and we want to try again to check if it resolved itself, we don't need new issues.

The failed build is actually a good affirmative test that this still skips creating an issue for PRs. I think this can be merged despite the known build failure.


types should be inferred

I am on go version go1.10.4 linux/amd64
I would like to see more type inference in Go. For example:

The above compiles, but if I leave out the types, I get:

this kinda sux tbh :/

Changes to the language should follow the proposal process: https://github.com/golang/proposal
In particular, there already are proposals about better type inference. For example, see https://github.com/golang/go/issues/12854. There's also https://github.com/golang/go/issues/21498 for making anonymous functions easier to write.
This issue is way too short and informal for a proposal, so I'm going to close it. Feel free to open another one with a well-formed idea.


Not receiving alerts from kwatch to teams

Describe the bug
I configured kwatch to send alerts to discord and teams but it only send to discord.
To Reproduce
To reproduce all you have to do it. apply the following config file to your kubernetes cluster adn make sure to update the webhook urls to match yours.
apiVersion: v1
kind: Namespace
metadata:
  name: kwatch
---
apiVersion: v1
kind: ConfigMap
metadata:
  name: kwatch
  namespace: kwatch
data:
  config.yaml: |
    alert:
      discord:
        webhook: https://discordapp.com/api/
      teams:
        webhook: https://hubkaho.webhook.office.com/

i am sure the error is with kwatch and not teams because i used postman to send a post request to the teams webhook and it works
Expected behavior
Expected behaviour is for discord alerts to work and teams  to work.
Actual behavior
actual behavior is that  discord alerts  work and teams dont.
Version/Commit
A version or commit of kwatch

@EzekielCodes Should be resolved in v0.8.2


How to make preprocessed files?

I followed the steps in the Fairseq repository, and I'm getting warnings like this:
[2024-06-26 11:51:23,204][fairseq.data.audio.hubert_dataset][WARNING] - audio and label duration differ too much (|104.302875 - 36.33| > 0.1) in line 51 of /home/guilherme/hubert/feature/label/train.km. Check if `label_rate` is correctly set (currently 100). num. of samples = 1668846; label length = 3633

Which end up leading to this error:
Traceback (most recent call last):
  File "fairseq/fairseq_cli/hydra_train.py", line 28, in hydra_main
    _hydra_main(cfg)
  File "fairseq/fairseq_cli/hydra_train.py", line 53, in _hydra_main
    distributed_utils.call_main(cfg, pre_main, **kwargs)
  File "/home/guilherme/hubert/fairseq/fairseq/distributed/utils.py", line 369, in call_main
    main(cfg, **kwargs)
  File "/home/guilherme/hubert/fairseq/fairseq_cli/train.py", line 180, in main
    valid_losses, should_stop = train(cfg, trainer, task, epoch_itr)
  File "/home/guilherme/miniconda3/envs/contentvec/lib/python3.7/contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File "/home/guilherme/hubert/fairseq/fairseq_cli/train.py", line 291, in train
    log_output = trainer.train_step(samples)
  File "/home/guilherme/miniconda3/envs/contentvec/lib/python3.7/contextlib.py", line 74, in inner
    return func(*args, **kwds)
  File "/home/guilherme/hubert/fairseq/fairseq/trainer.py", line 761, in train_step
    **extra_kwargs,
  File "/home/guilherme/hubert/fairseq/fairseq/tasks/fairseq_task.py", line 492, in train_step
    loss, sample_size, logging_output = criterion(model, sample)
  File "/home/guilherme/miniconda3/envs/contentvec/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/guilherme/hubert/fairseq/fairseq/criterions/hubert_criterion.py", line 54, in forward
    net_output = model(target_list=sample["target_list"], **sample["net_input"])
  File "/home/guilherme/miniconda3/envs/contentvec/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1194, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/guilherme/hubert/fairseq/fairseq/models/hubert/hubert.py", line 433, in forward
    padding_mask = self.forward_padding_mask(features, padding_mask)
  File "/home/guilherme/hubert/fairseq/fairseq/models/hubert/hubert.py", line 403, in forward_padding_mask
    extra = padding_mask.size(1) % features.size(1)
ZeroDivisionError: integer division or modulo by zero

All this using the legacy model, because I don't know how to use the normal version, because when I select the normal model, when I preprocess the files, I get another error.
Also, I wanted to ask, is it possible to train a new model from kaggle/colab?

I've just tested it, and one of my settings was wrong, so problem solved


brotli 1.0.6+

https://github.com/google/brotli/releases/latest

https://github.com/google/brotli/releases/tag/v1.0.5
https://github.com/google/brotli/releases/tag/v1.0.6
https://github.com/google/brotli/releases/tag/v1.0.7

improve q=1 compression on small files
add rolling-composite-hasher for large-window mode
fix unaligned 64-bit accesses on AArch32
add ASAN/MSAN unaligned read specializations

Yup, will pull soon.

or 1.0.7 https://github.com/google/brotli/releases/tag/v1.0.7 ?

@eustas indeed due for an update :)

Please!

Issue can be closed now. 1.0.7 has been pulled in.


Questions about the results

Hi,
Thank you for your work and code!
I have a question on Fig. 6 of your paper.
In the caption, you said you were showing the results over the 3177 gaits. But in the figure, the total number of 4 classes (Angry, 1073, Happy 565, Sad 65 and Neutral 232) are 1935 not 3177. In adition, I think you trained the model on E-gaits dataset. In this case, are you reporting results on all the E-gaits not only on the test set? Because I think your test set does not have so many samples.
Finally, as shown in Fig.6, your sample classes are highly imbalanced. I am wondering if your training set is also imbalanced, and in this case, how much sense the accuracy can be used as the evaluation metric.
Sorry for so many questions. I am not sure if I misunderstood something. Could you please kindly help to clarify?
Many thanks!
Xingchen

Hi Xingchen,
You might be looking at an earlier version of the paper, which had some typos. I'd recommend looking at the final published version: https://aaai.org/ojs/index.php/AAAI/article/view/5490. We actually did report the confusion matrix on the full dataset, which, in hindsight, is not the most accurate style of reporting. I would recommend reporting only on the test set, as we have done in subsequent works. However, the reported numbers in this paper are fair since all the methods were evaluated on the full dataset.
And yes, we had way more happy samples in the dataset compared to other classes. We balanced each batch during training by forcing that batch to contain samples from all the classes. Reporting only the accuracy indeed doesn't show the full picture, which is why we also show the confusion matrix. Another useful metric is the weighted accuracy: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.balanced_accuracy_score.html

Thank you so much for your response!

Hi,
Sorry. Could I know the order of the emotions classes? For example is 0: angry, 1: happy, 2:neutral etc? And is this the same for labels, labels_ELMD and labels4DCVAEGCN?
Cause in the previous comment, the number of 0 labels is higher but it should be angry but you mentioned number of happy samples are greater
Thanks

My apologies, that might have been in a different context or in error. The labels are 0: angry, 1: neutral, 2: happy, 3: sad.

so angry has the maximum number of samples? and is that order the same for all datasets (ELMD,4DCVAEGCN and the normal one)?

Yes


Add reward controller

Replace the setRewardController with addReward controller to have multiple reward controllers.

Also do we need a rewardControllersLength function?


VS Code Telemetry

Visual Studio Code sending telemetry to the following domain
mobile.events.data.microsoft.com
The code: https://github.com/microsoft/vscode/blob/73fd3f11032e7b83c2ae011b5516e6ddd19e3db2/src/vs/platform/telemetry/common/1dsAppender.ts
Please take a look and add mobile.events.data.microsoft.com to the blocklist.

I'm not commenting on whether or not to add this, but is this not what the well established and well maintained VSCodium is for? It's literally VS Code minus telemetry. Just wanted to point that out.

Thank you very much for this @JobcenterTycoon. Good catch.
This is very interesting. I'd like broader input on this. Let's let this simmer for awhile.
Gerd @hagezi what do you think? Do you have any insight into the domain mobile.events.data.microsoft.com?

Thanks for the ping @StevenBlack.
Yes, it is used for client telemetry. If you disable telemtry in VSCode, the domain should no longer be triggered.
Microsoft has changed a lot in the past regarding telemetry. Because of the different data protection regulations, there are now region-based domains, the complete list of mobile events that I know of:
mobile.events.data.microsoft.com
us-mobile.events.data.microsoft.com
eu-mobile.events.data.microsoft.com
au-mobile.events.data.microsoft.com
jp-mobile.events.data.microsoft.com

The following domain seems to be used to retrieve the default configuration:
mobile.events-sandbox.data.microsoft.com
The telemtry changes can be seen in the following PR:
https://github.com/microsoft/cpp_client_telemetry/pull/1097/files/a5b293bd1b77b264c6bb79b39124f04c53d6c80b
I maintain a native tracker list for Windows and Office, it can be found here:
https://github.com/hagezi/dns-blocklists#native
https://raw.githubusercontent.com/hagezi/dns-blocklists/main/domains/native.winoffice.txt
Since there have been reports in the past that blocking various events.data.microsoft.com caused restrictions in Office 365 online (Office in the browser, Outlook, Teams, online collaboration on Office documents, Office Forms and ...), I only block these domains in my aggressive lists.
I myself have not noticed any restrictionsin my region (EU), except for the following domains, which have also been removed from my native list:
Breaks Office 365 Admin Center, saving Office documents in the cloud, Windows floods the DNS with queries when blocked:
self.events.data.microsoft.com
self-events-data.trafficmanager.net

Breaks Windows/XBox Achivements:
au-v10.events.data.microsoft.com
au-v20.events.data.microsoft.com
eu-v10.events.data.microsoft.com
eu-v20.events.data.microsoft.com
jp-v10.events.data.microsoft.com
jp-v20.events.data.microsoft.com
uk-v20.events.data.microsoft.com
us-v10.events.data.microsoft.com
us-v20.events.data.microsoft.com
us4-v20.events.data.microsoft.com
us5-v20.events.data.microsoft.com
v10.events.data.microsoft.com
v20.events.data.microsoft.com

I hope I could help, greetings,
Gerd

Thank you for this detailed insight Gerd @hagezi.  Wow.
To curate is to choose. I'm leaning towards not blocking this.
I'll sleep on it @JobcenterTycoon.

@StevenBlack
Blocking telemetry should not actually lead to restrictions. However, the past shows otherwise, bad software design or perhaps pure intention. Which, of course, does not mean that it will be the same tomorrow.  Microsoft seems to be making some changes in client telemetry.
I was also unsure whether I should block it in the non-aggressive lists, but after research I decided against it. For people who don't use Office 365 with Cloud, blocking shouldn't be a problem.

Thanks Gerd @hagezi I'm very glad I pinged you.

So it will not be added to the blocklist?

@JobcenterTycoon the issue here is, do we (do I) want an avalanche of complaints due to breaking MS Office and MS Outlook and MS Teams from potentially all quarters?

Thank you for your suggestion @JobcenterTycoon. I have decided not to list the domain mobile.events.data.microsoft.com.
Closing.


Exception on page info creation

Describe the bug
I am using 10.5.0-preview6
mutation {
  createUser(input: {name: "1234"}) {
    id
    name
    notes {
      nodes {
        id
        title
        content
        user {
          id
          name
        }
      }
    }
  }
}

Exception details:
"message": "Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')",
"stackTrace": "   at System.Collections.Generic.List1.get_Item(Int32 index)\r\n   at HotChocolate.Types.Relay.QueryableConnectionResolver1.ResolveAsync(IMiddlewareContext context, IQueryable1 source, ConnectionArguments arguments, Boolean withTotalCount, CancellationToken cancellationToken)\r\n   at HotChocolate.Types.Relay.ConnectionMiddleware2.InvokeAsync(IMiddlewareContext context, IConnectionResolver`1 connectionResolver)\r\n   at HotChocolate.Execution.ExecutionStrategyBase.ExecuteMiddlewareAsync(ResolverContext resolverContext, IErrorHandler errorHandler)"
Additional context
I tried to debug GetSelectedEdgesAsync->... tree, but not found more details. I guess there would be FirstOrDefault/bound checks like in previous versions
Preview version

Master version

Great catch :) and good that you found this one :)

This one is now fixed with:
https://github.com/ChilliCream/hotchocolate/releases/tag/10.5.0-preview.7


Gazebo+PX4-SITL implementation problem

I'm having trouble implementing faster on a Gazebo+PX4 SITL simulation.
I have my world and a Iris model.
I implemented a controller in python (option 2 of the architecture) but when I subscribe the /goal topic I get:
[ERROR] [1633099445.913813448]: Client [/Extars_Supervisor] wants topic /goal to have datatype/md5sum [snapstack_msgs/Goal/29f7a5b62089bdabd9ea1780f356bc8b], but our version has [geometry_msgs/PoseStamped/d3812c3cbc69362b77dc0b19b345f8f5]. Dropping connection.
I have deleted the workspace and recompiled several times but to no avail.
On the whole disk as a Goal message definition I have these in my workspace:
./home/robot/extars/extars_ws/devel/.private/snapstack_msgs/lib/python2.7/dist-packages/snapstack_msgs/msg/_Goal.py
./home/robot/extars/extars_ws/devel/lib/python2.7/dist-packages/snapstack_msgs/msg/_Goal.py
Does anyone have an idea?

Hi @giorgiovaccarino,
Could you check if you have any other node (apart from FASTER nodes) publishing the goal topic? I.e., run rostopic info /goal (or rostopic info /SQ01s/goal if you are using a namespace).
It should say that there only FASTER nodes are publishing to that topic, and that its type is snapstack_msgs/Goal?
Let me know if this helps!

There must be some problem with namespaces in my configuration that I can not understand for now.
To continue with the simulation I have renamed the topic /goal in /goalx and I can go on.
Thanks, I close this issue and open another one soon to ask for information about the yaw contained in the Goal message.


Theming is not applied to the input background of the search overlay

The theming colors are not applied to the background of the search overlay input field:

Fixed in 3.4.0


revert: back to version 0.6.x of source-map

source-map 0.7.0 has breaking change. As a temporary workaround, this
commit reverts to using version 0.6.x of source-map. See
https://github.com/karma-runner/karma/issues/3557 for details.

Thanks @puppe!
Please accept the CLA as requested by bot here and change commit message to fix: revert to version 0.6.x of source-map or something. It is important that scope is fix, so it will be automatically released once PR is merged.

:white_check_mark: Build karma 2760 completed (commit https://github.com/karma-runner/karma/commit/831b369f7c by @puppe)

I don't want to be rude but I only made this pull request because you asked me to. I didn't really understand why you didn't change that single line in package.json yourself. I won't read a CLA for such a minor little thing. And I won't sign anything that I did not read.

@puppe Karma is an open source project and a product of community work. It is nice when people not only report a bug, but also fix it and submit a pull request. So I just offered you to contribute back to the project and start with this small fix. I'll fix it myself if you are not interested in contributing.

@devoto13 I did not “only report a bug”, I also spent several hours looking for the source of the bug. If that’s not a contribution, I don’t know what is.
This is only a workaround anyway, and does not address the real issue. If you wanted me to fix the real issue eventually, you should have just told me so. And I would have had to tell you that I unfortunately don’t have time for that. This is only a hobby for me. I use Karma on a little project that I forked from somebody else. Node is not my dayjob.

@puppe And thank you for researching the issue. I do appreciate it.
I totally understand that not everybody has time to work on fixes, that's why I asked if you're willing to make a PR. In any case https://github.com/karma-runner/karma/pull/3559 should be merged and released soon.

@devoto13 Thank you for your work on Karma. I also appreciate that. Have a good one.


[FLINK-20533][datadog][release-1.12] Backport flink-metrics-datadog changes from master

I created this PR by copying the files from master because due to the code reformat it would have been cumbersome to cherry pick individual commits. Changes included:
commit 313e20e8e03953a5e1cec9daa467f561ccfbd599Author: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 16:20:29 2020 +0100
    [FLINK-20533][datadog] Add Histogram support
commit 38e424fd5fa7c4a6e6165921689a232a10e85bddAuthor: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 16:16:02 2020 +0100
    [FLINK-20533][datadog] Encapsulate metric meta data        This allows us to use the 'MetricMetaData' container for histograms later on, which will not directly extend 'DMetric'.
commit ea317c20ac4ab76c9e71fb0c1aa8a104e7173057Author: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 14:55:48 2020 +0100
    [hotfix][datadog] Remove outdated comments
commit f01e1916edf015d3f1b800065eeea4c2ae4af7baAuthor: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 16:14:01 2020 +0100
    [hotfix][datadog][tests] Rework tests        - re-parse JSON to ignore order of serialization    - restrict 'DatadogHttpClient.serialize()' to 'DSeries'    - test series serialization    - refer to constants where possible
commit 7fcb628c0cd6a3daf3f19917ef2414d8743bcc7aAuthor: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 14:40:08 2020 +0100
    [hotfix][datadog] Explicitly mark fields relevant for serialization        It was difficult to tell which fields are relevant for serialization. Adding annotations makes this more obvious, and allows us more freedom in regards to naming.
commit 4d5053067199d46134366abc5c8954c57757a82eAuthor: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 14:40:57 2020 +0100
    [hotfix][datadog] Merge DSeries#add*()        The distinction between metric types adds unnecessary complexity.
commit bf058d68acdcdcb4ea28e6fe3a22904a5f385b8aAuthor: Chesnay Schepler<EMAIL_ADDRESS>  Tue Dec 8 14:38:44 2020 +0100
    [hotfix][datadog][tests] Cleanup code

@zentol we are using Datadog and need the histogram support in 1.12.
I added the missing documentation changes.


Fix Intersector#overlapConvexPolygons

In some rare cases it's possible that Intersector#overlapConvexPolygons calculates an incorrect MTV. Currently the direction of the MTV is negated depending on the number of points on either side of the checked edge.
The correct way is to negate the direction of the MTV depending on the direction of the centers of both polygons.

I think your fix doesn't work for other cases. Imagine a right triangle (1 angle is 90º) with 2 equal sides resting on one cathetus (short side). The center point of that triangle will be in the middle of the hypotenuse. Imagine now a small rectangle with the same center than the triangle. If I understand your fix correctly in that case MTV will resolve to 0. Now, imagine we move the rectangle diagonally up-right or down-left the MTV will invert but it actually should keep being positive x and y. I think it's a complex geometry problem with complex corner cases.

So i had also issues with the function overlapConvexPolygons and i decided to understand the SAT Algorithm and how to handle the minimum translation Vector. I am making a game and completely did a rewrite on this function. If anyone is interested in seeing it here is the link. If you want, you can clone the repository and play with the Testclasses i made. Try changing my custom Intersector class with this of libgdx and you will see the issues with it. I made a Testclass where you can drag 2 triangles to overlap each other and when they collide, the minimum translation vector did return wrong results because the orientation of the x and y coordinates returned by the direction vector were wrong.

So i had also issues with the function overlapConvexPolygons and i decided to understand the SAT Algorithm and how to handle the minimum translation Vector. I am making a game and completely did a rewrite on this function. If anyone is interested in seeing it here is the link. If you want, you can clone the repository and play with the Testclasses i made. Try changing my custom Intersector class with this of libgdx and you will see the issues with it. I made a Testclass where you can drag 2 triangles to overlap each other and when they collide, the minimum translation vector did return wrong results because the orientation of the x and y coordinates returned by the direction vector were wrong.

On a first look it looks a good. I think we  can use your SAT algorithm implementation as a base to replace the current buggy implementation. I think there's a some room for improvement (such as using Vector2 for some operations) but I'd rather discuss them on a PR. Would you like to create a PR with your implementation including some non visual/interactive tests that also cover corner cases (such as containment)?

Now that we have #5048, can we close this one?

It will get closed when the PR is merged and closed.
On Sat, Sep 12, 2020, 10:39 Benjamin Schulte<EMAIL_ADDRESS>wrote:

Now that we have #5048 https://github.com/libgdx/libgdx/pull/5048, can
we close this one?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/5048#issuecomment-691446527, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AANWDPAJQF3RJX7H3R54BOLSFMXS5ANCNFSM4EKLHBBA
.


Reworking tune ls

Currently, tune ls is a bit unweildy. Can we make it better?
@joecummings

@SalmanMohammadi , do you have some example of what you would like to change?

Good question. This is the current output:
(venv) combuter:torchtune salmanmohammadi$ tune ls
W0805 18:37:08.061000<PHONE_NUMBER> torch/distributed/elastic/multiprocessing/redirects.py:29] NOTE: Redirects are currently not supported in Windows or MacOs.
RECIPE                                   CONFIG
full_finetune_single_device              llama2/7B_full_low_memory
                                         code_llama2/7B_full_low_memory
                                         llama3/8B_full_single_device
                                         llama3_1/8B_full_single_device
                                         mistral/7B_full_low_memory
                                         phi3/mini_full_low_memory
                                         qwen2/7B_full_low_memory
full_finetune_distributed                llama2/7B_full
                                         llama2/13B_full
                                         llama3/8B_full
                                         llama3_1/8B_full
                                         llama3/70B_full
                                         llama3_1/70B_full
                                         mistral/7B_full
                                         gemma/2B_full
                                         gemma/7B_full
                                         phi3/mini_full
                                         qwen2/7B_full
lora_finetune_single_device              llama2/7B_lora_single_device
                                         llama2/7B_qlora_single_device
                                         code_llama2/7B_lora_single_device
                                         code_llama2/7B_qlora_single_device
                                         llama3/8B_lora_single_device
                                         llama3_1/8B_lora_single_device
                                         llama3/8B_qlora_single_device
                                         llama3_1/8B_qlora_single_device
                                         llama2/13B_qlora_single_device
                                         mistral/7B_lora_single_device
                                         mistral/7B_qlora_single_device
                                         gemma/2B_lora_single_device
                                         gemma/2B_qlora_single_device
                                         gemma/7B_lora_single_device
                                         gemma/7B_qlora_single_device
                                         phi3/mini_lora_single_device
                                         phi3/mini_qlora_single_device
                                         qwen2/7B_lora_single_device
lora_dpo_single_device                   llama2/7B_lora_dpo_single_device
lora_dpo_distributed                     llama2/7B_lora_dpo
lora_finetune_distributed                llama2/7B_lora
                                         llama2/13B_lora
                                         llama2/70B_lora
                                         llama3/70B_lora
                                         llama3_1/70B_lora
                                         llama3/8B_lora
                                         llama3_1/8B_lora
                                         mistral/7B_lora
                                         gemma/2B_lora
                                         gemma/7B_lora
                                         phi3/mini_lora
                                         qwen2/7B_lora
lora_finetune_fsdp2                      llama2/7B_lora
                                         llama2/13B_lora
                                         llama2/70B_lora
                                         llama2/7B_qlora
                                         llama2/70B_qlora
generate                                 generation
eleuther_eval                            eleuther_evaluation
quantize                                 quantization
qat_distributed                          llama2/7B_qat_full
                                         llama3/8B_qat_full

Personally, I find this almost impossible to parse - my eyes go all blurry trying to scan through this to find a config I might be interested in.
This is scaling quickly with new models and new recipes and I'd like to open up discussion on how we can improve UX here. Will add an idea I have soon.

this is another discussion, but i wonder if we should delete qlora configs, and just make it a flag in lora configs, so we can reduce the amount of configs

I recall @joecummings mentioning we can call tune ls <recipe instead of listing all recipes. We can also split into a "models" column and a "config" column so it's slightly easier to read

this is another discussion, but i wonder if we should delete qlora configs, and just make it a flag in lora configs, so we can reduce the amount of configs

This is a really interesting point. My very radical suggestion here was going to be storing only template configs, and forcing users to always specify config parameters which aren't common across models (tokenizer, model, etc.). This is crazy though.
We're balancing keeping things clean and easily discoverable/accessible, with offering sufficient abstractions to allow the lowest-common-denominator technical user to use our features. Right now, the surface area of no-code pathways for our features is pretty good, so I'd suggest we think about when we're reducing that and asking the user to figure things out by themselves.

I recall @joecummings mentioning we can call tune ls  instead of listing all recipes. We can also split into a "models" column and a "config" column so it's slightly easier to read

I was thinking along similar lines. I'd looove to see some fuzzy matching here, so we might have:
-tune ls by default requires some entity to query over, either a config or model, e.g. tune ls llama2, tune ls lora, tune ls llama2_7b, tune ls single_device, etc.

tune ls as is is replaced by tune ls --all

bumping https://github.com/pytorch/torchtune/pull/1163 as relevant here. subsequently ccing @pbontrager for thoughts


Unable to upgrade bolt via brew (OSX)

Describe the Bug
Unable to upgrade bolt via brew (OSX), from 2.35.0 to 2.36.0
~$ brew upgrade puppet-bolt
==> Upgrading 1 outdated package:
puppetlabs/puppet/puppet-bolt 2.35.0 -> 2.36.0
==> Upgrading puppet-bolt
==> Caveats

    Puppet Bolt binaries are installed in /opt/puppetlabs/bolt/bin, which is sourced by an /etc/paths.d entry.
    /opt/puppetlabs/bolt/bin may not be included in your current $PATH but should be included in new shells.

==> Downloading https://downloads.puppet.com/mac/puppet-tools/10.15/x86_64/puppet-bolt-2.36.0-1.osx10.15.dmg
Already downloaded: /Users/yakir.g/Library/Caches/Homebrew/downloads/59d32d91e044a54c1a17ed3d88dc04ff7f08866bf598aba9e03aa95b8734c995--puppet-bolt-2.36.0-1.osx10.15.dmg
==> Purging files for version 2.36.0 of Cask puppet-bolt
Error: puppetlabs/puppet/puppet-bolt: SHA256 mismatch
Expected: 35267f348466e841085e95d27918197a82d5f8b4ddd7d247e6ca6c188823a127
  Actual: 14111da825fe29542e6a401982e388f920756be8dacab1fa5c8ed4498104a9d8
    File: /Users/yakir.g/Library/Caches/Homebrew/downloads/59d32d91e044a54c1a17ed3d88dc04ff7f08866bf598aba9e03aa95b8734c995--puppet-bolt-2.36.0-1.osx10.15.dmg
To retry an incomplete download, remove the file above.

Expected Behavior
Upgrade should work
Steps to Reproduce
Steps to reproduce the behavior:
brew upgrade puppet-bolt

Environment

2.35.0
OSX 10.15.7 Catalina
Homebrew 2.6.0

Hi thanks for raising this! This is an issue because we updated the Puppet package repos to use Puppet 7 packages instead of Puppet 6 packages, and Bolt doesn't yet publish packages to the Puppet 7 repos. All other repos (our apt repo, yum, etc.) pull from the puppet-tools repo, but homebrew was still pulling from the puppet repo.
All is a long way of saying: this has been fixed here: https://github.com/puppetlabs/homebrew-puppet/pull/246 and should successfully pull in Bolt 2.37.0 when it's released in a few hours here. I'll verify users can successfully upgrade once that's out, but I think this problem has already been fixed.

installer: Package name is puppet-bolt
installer: Installing at base path /
installer: The install was successful.
🍺  puppet-bolt was successfully installed!
osx@myhost ~ % bolt --version
2.37.0

Looks to be working now! Let us know if you have any issues.


List bulletpoints display glitch.

The bulletpoints stay visible about one second after i called supportFinishAfterTransition().
I guess onDraw is still getting called during the animation?
How can i disable this behaviour?
I tried hiding the view (Invisible + Gone) right before kicking off the animation but it didnt work.
Even better would be an implementation with the help of BulletSpan instead of the custom logic. However im not sure how flexible BulletSpan in regards to multiple bulletpoint display styles.

The problem might be related to the fact that the bullet points are drawn by the containing component... Would it be feasible to include this in the animation? I am not exactly sure what you are trying to do and how O:)

The simplest way i can describe it is the following:
Im using a shared element transition on an image element Fragment => Activity.
I call supportPostponeEnterTransition() in onCreate and then start it when the image is done loading and is rendered on screen. This works just fine!
If i scroll down to the Bulletpoints and press the back key on my actionbar / hw key. I use supportFinishAfterTransition() to return back to the fragment with an animation. However during that last part the bullet points are still visible until the animation is done but all the other content besides the image that has the shared element transition is hidden.

The bullets are drawn in AndroidContainerElement.onDraw. One possible issue might be that some aspect of the state is not properly taken into account in canvas.drawText at the end of this method? c

Im not too familiar with this but i will check what kind of state i might need to check

Hmm bad news from me i found no way to fix this.
As onDraw is called on every invalidation of the view it obviously gets called during the finishTransition and ends up drawing the dots.
I can workaround that by setting the htmlview to invisible before i call supportFinishAfterTransition() it looks kinda weird and totally defeats the purpose of the FinishAfterTransition but atleast it doesnt glitch out anymore.
Im not aware of any check that would help in the onDraw logic, maybe you can come up with something.

Maybe the cleanest solution would be to move bullet drawing from the ol/ul element to the corresponding li?

I think i tried the thing you mentioned in your first sentence i tried.
if (component.getVisibility() != View.VISIBLE) {
    continue;
}

and getAlpha() within the for loop and it did not change the behaviour.
However i noticed the following:
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4
E/debug_main_container: alpha:1.0visibleState0
E/debug: alpha:1.0visibleState4

this is produced by

This seems to indicate that moving the onDraw logic to the li element might fix it ?
Please correct me if iam wrong.


Long builds hang docker client when using TLS

When doing a specific large build remotely to a small VM, it appears to take around 10 minutes to complete. This may be expected due to disk/cpu constraints. However, the docker client hangs indefinitely. The server logs show that the client disconnected - but the Windows docker client is still running afterwards.
My publishing process waits on docker.exe to terminate, so everything looks like its hung.
VERBOSE: Building Docker image: webapplication1
Executing command [docker --tlsverify -H tcp://plang-docker-w2.westus.cloudapp.azure.com:2376 build -t webapplication1 -f "C:\Users\plang\AppData\Local\Temp\PublishTemp\WebApplication169\approot\src\WebApplication1\Dockerfile" "C:\Users\plang\AppData\Local\Temp\PublishTemp\WebApplication169"]
VERBOSE: Sending build context to Docker daemon 557.1 kB
VERBOSE: Sending build context to Docker daemon 1.114 MB
VERBOSE: Sending build context to Docker daemon 1.671 MB
...
VERBOSE: Sending build context to Docker daemon 165.3 MB
VERBOSE:
VERBOSE: Step 1 : FROM windowsservercore
VERBOSE:  ---> 6801d964fda5
VERBOSE: Step 2 : ADD . /app

Daemon version info:
time="2016-02-12T23:03:25.156991300Z" level=info msg="Docker daemon" commit=59a341e execdriver="\n Name: Windows 1854\n Build: 1.10.0-dev 59a341e \n Default Isolation: process" graphdriver=windowsfilter version=1.10.0-dev

OS: Windows Server 2016 TP4 - using Azure gallery image

Client:
Client:
 Version:      1.10.1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   9e83765
 Built:        Thu Feb 11 19:14:21 2016
 OS/Arch:      windows/amd64

Full logs are attached, but I think these excerpts may help narrow it down:
time="2016-02-16T19:57:18.408610800Z" level=debug msg="Calling POST /v1.22/build"
time="2016-02-16T19:57:18.408610800Z" level=info msg="POST /v1.22/build?buildargs=%7B%7D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=approot%2Fsrc%2FWebApplication1%2FDockerfile&memory=0&memswap=0&rm=1&shmsize=0&t=webapplication1&ulimits=null"

time="2016-02-16T20:06:59.123283200Z" level=debug msg="Calling proc"
time="2016-02-16T20:06:59.123283200Z" level=debug msg="hcsshim::NameToGuid Name bae19e317af6661e29fd9a5719ff9592e69f98e5986ba0e2dd710a94a3765d53"
time="2016-02-16T20:06:59.123283200Z" level=debug msg="Calling proc"
time="2016-02-16T20:06:59.123283200Z" level=debug msg="hcsshim::NameToGuid Name CN=Microsoft_WindowsServerCore_10.0.10586.0"
time="2016-02-16T20:06:59.123283200Z" level=debug msg="Calling proc"
time="2016-02-16T20:07:00.285349100Z" level=info msg="Client disconnected, cancelling job: build"

Around that time, the build appears to have completed.

docker images - lists WebApplication1:latest
docker ps - nothing else running

If I try the same build again immediately - it succeeds. I presume the caching is making it complete quickly enough to avoid this hang.
docker.log_truncated.txt

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

@PatrickLang haven't heard about this anymore, is this still an issue? @jhowardmsft

I'd be pretty sure this far down the road, it's safe to close this. Please re-open if you can repro on RTM builds.


[BUG] Cannot re-create a secret in KeyVault even after purging

Library name and version
Azure.Security.KeyVault.Secrets 4.4.0
Describe the bug
I am trying to delete a secret from KeyVault and replace it with another with the same key.
The KeyVault has Soft-delete enabled and Purge protection disabled.
Despite following the steps outlined at https://learn.microsoft.com/en-us/azure/key-vault/secrets/quick-create-net?tabs=azure-cli#sample-code when I try to create the secret again, an exception is thrown.
Expected behavior
The old secret should be successfully deleted so that a new secret with the same key can be created.
Actual behavior
The following exception is thrown:
Azure.RequestFailedException: Secret mySecret is currently being deleted and cannot be re-created; retry later.
Status: 409 (Conflict)
ErrorCode: Conflict
Content:
{"error":{"code":"Conflict","message":"Secret mySecret is currently being deleted and cannot be re-created; retry later.","innererror":{"code":"ObjectIsBeingDeleted"}}}
Headers:
Cache-Control: no-cache
Pragma: no-cache
x-ms-keyvault-region: uksouth
x-ms-client-request-id: 92f45d1f-cfcc-43bc-9367-2e64aba5e1bf
x-ms-request-id: 4685a803-62b0-46e0-a35e-3d15712c3d18
x-ms-keyvault-service-version: 1.9.713.1
x-ms-keyvault-network-info: conn_type=Ipv4;addr=<IP_ADDRESS>;act_addr_fam=InterNetwork;
X-Content-Type-Options: REDACTED
Strict-Transport-Security: REDACTED
Date: Fri, 17 Feb 2023 10:04:32 GMT
Content-Length: 168
Content-Type: application/json; charset=utf-8
Expires: -1
at Azure.Security.KeyVault.KeyVaultPipeline.SendRequestAsync(Request request, CancellationToken cancellationToken)
at Azure.Security.KeyVault.KeyVaultPipeline.SendRequestAsync[TContent,TResult](RequestMethod method, TContent content, Func`1 resultFactory, CancellationToken cancellationToken, String[] path)
at Azure.Security.KeyVault.Secrets.SecretClient.SetSecretAsync(KeyVaultSecret secret, CancellationToken cancellationToken)
at Azure.Security.KeyVault.Secrets.SecretClient.SetSecretAsync(String name, String value, CancellationToken cancellationToken)
at key_vault_console_app.Program.Main(String[] args) in C:\Repos\Sandpit\ConsoleApp2\ConsoleApp2\Program.cs:line 45
at key_vault_console_app.Program.(String[] args)
Reproduction Steps
I have created a console app based on https://learn.microsoft.com/en-us/azure/key-vault/secrets/quick-create-net?tabs=azure-cli#sample-code and added a step to add the secret again:
class Program
{
    static async Task Main(string[] args)
    {
        const string secretName = "mySecret";
        var keyVaultName = "MYKEYVAULTNAME";
        var kvUri = $"https://{keyVaultName}.vault.azure.net";

        var client = new SecretClient(new Uri(kvUri), new DefaultAzureCredential());

        Console.Write("Input the value of your secret > ");
        var secretValue = Console.ReadLine();

        Console.Write($"Creating a secret in {keyVaultName} called '{secretName}' with the value '{secretValue}' ...");
        await client.SetSecretAsync(secretName, secretValue);
        Console.WriteLine(" done.");

        Console.WriteLine("Forgetting your secret.");
        secretValue = string.Empty;
        Console.WriteLine($"Your secret is '{secretValue}'.");

        Console.WriteLine($"Retrieving your secret from {keyVaultName}.");
        var secret = await client.GetSecretAsync(secretName);
        Console.WriteLine($"Your secret is '{secret.Value.Value}'.");

        Console.Write($"Deleting your secret from {keyVaultName} ...");
        DeleteSecretOperation operation = await client.StartDeleteSecretAsync(secretName);
        // You only need to wait for completion if you want to purge or recover the secret.
        await operation.WaitForCompletionAsync();
        Console.WriteLine(" done.");

        Console.Write($"Purging your secret from {keyVaultName} ...");
        await client.PurgeDeletedSecretAsync(secretName);
        Console.WriteLine(" done.");

        // Additional step:
        Console.Write($"Creating a secret in {keyVaultName} called '{secretName}' with the value '{secretValue}' ...");
        await client.SetSecretAsync(secretName, secretValue);
        Console.WriteLine(" done.");
    }
}

Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Unfortunately, purging does take time and there's no way to poll for it like we do for deletions or recovery. This is a service limitation. @jlichwa for feedback. Is this something the service team might consider a change to?
@MattW52 alternatively, you can loop trying to create the key until it works, but can I ask why you're trying to purge a secret when creating a new one? You can create a new version just by calling SetSecret again. This way, old secrets are kept in case they are ever needed e.g., compare with possibly leaked credentials, make sure you don't reuse a past secret, etc.

We integrate with 3rd party systems on-behalf of our Customers and use Key Vault to store config.  Some of those 3rd parties require us to delete that config should the Customer decide to revoke our access.  Some actually require us to demonstrate this behaviour before they will allow us to access live data.
Key Vault seemed like a good fit, I just need to get the purging to work.
Thanks.

Purging does work, though. You just can't expect to turn around and create a new key/secret/cert for ~30s in many cases. That seems like an impractical scenario. There is, unfortunately, no wait to monitor when a purge is complete. See #6514 from years back where this was discussed with the service team.

It is async operation without ability to monitor completion. 30seconds sleep should be enough.
Key Vault Team

Ok, thanks.  I really mean "wait for the purging to work" rather than "get the purging to work".


IDisposable implementation

If I'm not mistaken, your Hub (and maybe HubConnection) could use an IDisposable implementation to ensure proper cleanup of connections.

If you insist. 😄

Thank you sir!


Icon on location marker should be bigger

location marker has more room for bigger icon.

Solved with 3.0.1


Link to US-CERT's DDoS page is broken

CISA moved the page on DDoS protection (though I can't find the new link easily).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e34a359d-9ba2-a8e3-8391-8dfa780a5c47
Version Independent ID: f8b7a25e-c8ea-c435-7a96-45cdcfd2e60e
Content: Compare Azure Content Delivery Network (CDN) product features
Content Source: articles/cdn/cdn-features.md
Service: azure-cdn
GitHub Login: @duongau
Microsoft Alias: duau

@SvenAelterman
Thanks for your feedback! We will investigate and update as appropriate.

@SvenAelterman
Thank you for your feedback. I have made a PR to address this issue which will replace the old link with https://www.cisa.gov/news-events/news/understanding-denial-service-attacks
The PR is currently under Doc author's review. I will follow up with the author there.
Thank you once again for your feedback!


Gocardless Payment Flow

[ ] Get ssl added
[ ] switch to pro api

We have an SSL already with dnsimple


Checkbox Options Not Displaying on Belly Screen

The EmotionShame, EmotionFear, etc features that are supposed to show checkboxes show only the main text and none of the checkboxes or the options within them.

Created pull request in backend repository for this issue, don't know how to link issues across repo's


Use of default parameters while URL creation.

Suppose we have a rule:
[
    'pattern' => 'post/<page:\d+>/<tag>',
    'route' => 'post/index',
    'defaults' => ['page' => 1],
],

This rule returns false while trying to create a URL without explicit page specification.
$rule->createUrl($manager, 'post/index', ['tag' => 'foo']); // false

Why can't we use default parameters in pattern while URL creation? Is it by design?
It seems to me that we should be able to use optional parameters both while URL creation and parsing.

@cebe it's very easy to verify - we can add a new test case in yiiunit\framework\web\UrlRuleTest at line 176:
['post/index', ['tag' => 'a'], 'post/2/a'],

This test case fails.

Is it by design?

I think yes. This rule only match with url ['post/index', 'page' => 1, ...]

if you need default value $_GET['page'], you should define it at action method
public function actionIndex($page = 1)
{
    ...
}

Duplicates #10970

@mdmunir it turns out that this is a bug.
@rob006 thank you!


 Is it possible to permanently save it?
Thanks,
Andre

Duplicate of #431


Made OmexHealthCheckPublisherHostedService to be used by default

Made OmexHealthCheckPublisherHostedService to be used by default.
When health checks were added using AddServiceFabricHealthChecks library used default health check publisher hosted service instead of our own.

Can you add more detail here?
I take it the intention is that all health checks registered using this library are using the same publisher.
Is that correct, and if so, what are the advantages and disadvantages?
Please add more detail to the summary.

@K-Cully The main advantage is that our health publisher is in development now (we are adding custom periods for publishing reports) and we have control over it.


[CONSENSUS] Error while creating a proposal: ReferenceError: txOps is not defined

{
  "insertId": ".......1IIz1VzEiQAh3mtLnPbJywZcf",
  "jsonPayload": {
    "metadata": {},
    "message": "[CONSENSUS] Error while creating a proposal: ReferenceError: txOps is not defined"
  },
  "resource": {
    "type": "gce_instance",
    "labels": {
      "instance_id": "4460521773284006620",
      "zone": "asia-east1-b",
      "project_id": "testnet-dev-ground"
    }
  },
  "timestamp": "2020-12-13T19:50:00.316999912Z",
  "severity": "ERROR",
  "logName": "projects/testnet-dev-ground/logs/winston_log",
  "receiveTimestamp": "2020-12-13T19:50:00.373285380Z"
}

Fixed by #158.


[Feat]: Implement Header Navigation Background Color Based on Theme for Improved Scroll Visibility

What feature?
I have an idea you can keep the header nav to be set with a background color white and black based on theme. So that it doesn't look transparent because of padding when scrolled above.
Add screenshots
Old Preview

New Preview with background added to header.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I pulled up a PR which implements this feature. Thanks for the feature request!

Hi, I would love to work on this issue. Can you assign it to me? Thanks!


fix: After merging the template the deployed version of the App was failing to load

Description

When we merge the template to an existing app, the deployed version should work without any issues. This PR fixes this issue. The cause was that the newly added page reference was added to the published reference of the application object as well. But since the app was not deployed the newPage collection publishedPage was empty hence the deployed version of the App was failing to load.

Fixes #17428
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally
Unit Tests

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=76d2d94

/ok-to-test sha=8f7fb19

This is fixed now, verified it on release deployed app is loading perfectly fine now. https://www.loom.com/share/77c4da1f456b4a3e9a29a66092bcec11