KAFKA-14133: Replace EasyMock with Mockito in streams test

Batch 3 of the tests detailed in https://issues.apache.org/jira/browse/KAFKA-14133 which use EasyMock and need to be moved to Mockito.
EDIT: This issue has been solved
Unfortunately some tests are failing and I am not exactly sure how and why this is happening, specifically

shouldNotUpdateLimitForNonSourceStandbyChangelog
shouldOnlyRestoreStandbyChangelogInUpdateStandbyState
shouldRestoreToLimitInStandbyState

As you can see from the diff in this PR, the changes from EasyMock to Mockito in these functions was quite trivial/mechanical but the tests are failing with errors that are confusing to me, i.e.
[2022-08-17 12:13:33,803] DEBUG test-reader Transiting to update standby tasks: {} (org.apache.kafka.streams.processor.internals.StoreChangelogReader:317)
[2022-08-17 12:13:33,803] DEBUG test-reader Resumed partitions [] from the restore consumer (org.apache.kafka.streams.processor.internals.StoreChangelogReader:899)
[2022-08-17 12:13:33,804] DEBUG test-reader Added partitions [topic-0] to the restore consumer, current assignment is [topic-0] (org.apache.kafka.streams.processor.internals.StoreChangelogReader:861)
[2022-08-17 12:13:33,804] DEBUG test-reader Start restoring changelog partition topic-0 from current offset 0 to end offset 7. (org.apache.kafka.streams.processor.internals.StoreChangelogReader:918)
[2022-08-17 12:13:33,805] WARN test-reader Encountered org.apache.kafka.clients.consumer.OffsetOutOfRangeException fetching records from restore consumer for partitions [topic-0], it is likely that the consumer's position has fallen out of the topic partition offset range because the topic was truncated or compacted on the broker, marking the corresponding tasks as corrupted and re-initializing it later. (org.apache.kafka.streams.processor.internals.StoreChangelogReader:438)
org.apache.kafka.clients.consumer.OffsetOutOfRangeException: Offsets out of range with no configured reset policy for partitions: {topic-0=1}
	at org.apache.kafka.clients.consumer.MockConsumer.poll(MockConsumer.java:208)
	at org.apache.kafka.streams.processor.internals.StoreChangelogReader.restore(StoreChangelogReader.java:433)
	at org.apache.kafka.streams.processor.internals.StoreChangelogReaderTest.shouldRestoreToLimitInStandbyState(StoreChangelogReaderTest.java:836)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.mockito.internal.junit.JUnitSessionStore$1.evaluateSafely(JUnitSessionStore.java:55)
	at org.mockito.internal.junit.JUnitSessionStore$1.evaluate(JUnitSessionStore.java:43)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
	at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
	at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
	at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:53)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:99)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:79)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:75)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:61)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy2.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60)
	at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:133)
	at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:71)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69)
	at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74)

Tasks [null] are corrupted and hence needs to be re-initialized
org.apache.kafka.streams.errors.TaskCorruptedException: Tasks [null] are corrupted and hence needs to be re-initialized
	at app//org.apache.kafka.streams.processor.internals.StoreChangelogReader.restore(StoreChangelogReader.java:446)
	at app//org.apache.kafka.streams.processor.internals.StoreChangelogReaderTest.shouldRestoreToLimitInStandbyState(StoreChangelogReaderTest.java:836)

@cadonna @clolov @C0urante @ijuma Maybe you have an idea what is going on here? Also note that due to Mockito not working with inline thenReturn mock statements (see https://github.com/mockito/mockito/wiki/FAQ#can-i-thenreturn-an-inlined-mock-) I did some refactorings in StoreChangelogReaderTest, i.e. mockTasks and mockTask have been moved from inner local methods to the class. This was also done as an attempt to solve the aforementioned problems but it ended up having zero effect (also note in general apart from these problems it had zero effect on the tests).
Also note that @SuppressWarnings("unchecked") is necessary because unlike EasyMock, Mockito doesn't have any support for generics in the mock method (see https://github.com/mockito/mockito/issues/1531)
Finally with ProcesserStateManagerTest some verifications, stubbed calls have been removed for the same reasons behind https://github.com/apache/kafka/pull/12505#discussion_r947652273, i.e. MockitoJUnitRunner.StrictStubs was complaining that there was extra erroneous stubs/verifications and I needed to remove them to make StrictStubs happy. This stubbing was also unnecessary in EasyMock.

Hey @mdedetrich--it looks like the issue here is caused by differences in default return values for boxed primitive types between Mockito mocks and EasyMock nice mocks; the former will return 0, but the latter will return null.
Adding when(storeMetadata.offset()).thenReturn(null); to the beginning of each of the failing test cases mentioned in the description seems to fix the issue.
I'm not too familiar with the Streams codebase, so probably best to get review from someone else, but if there are any other strange issues that don't seem Streams-specific, let me know!

@C0urante Thanks for finding the root cause, will definitely keep this as a mental note when doing other migrations. I'll update the PR later tonight

PR has been rebased and pushed which fixes the problem described earlier, i.e. usage of when(storeMetadata.offset()).thenReturn(null);

@cadonna I have just rebased the PR with the latest streams changes that got merged into. trunk. I also did some more improvements for StreamThreadTest with the usage of MockitoJUnitRunner.StrictStubs, i.e. before where we had
verify(taskManager)

we now have
verify(taskManager).handleCorruption(corruptedTasks);

Also MockitoJUnitRunner.StrictStubs revealed pointless stubs have been removed.

Thanks for the comments, I am still get my head around the tests and what precisely is being tested.
I forgot to mention earlier that StreamTaskTest needs more work (doing this now, will push changes). There are other fixes needed due to the MockitoJUnitRunner.StrictStubs, i.e. some tests throw exceptions and expect that exception path to never be hit and this needs to be replaced with verify(times(0)) or something similar.

@cadonna  Okay so I have just pushed and rebased the PR with these changes

As you have rightly pointed out there were a lot of things being stubbed/tested which made no sense due to peculiarities of how EasyMock works (which I am still trying to get my head around). I believe I have removed most of the unnecessary resets/stubs. There are still some verify's which can be argued are pointless (mainly in the setup of the mock), if you still want to remove these then let me know
StreamTaskTest previously with EasyMock used stub exceptions to verify a method was not meant to be called, i.e.EasyMock.expectLastCall().andThrow(new AssertionError("Should not have tried to checkpoint"));

This has now been replaced with using never, i.e. the above example translates to verify(stateManager, never()).checkpoint(); which

@cadonna I have addressed the comments which I could. I just noticed that I have gone back and forth between removing and adding the same stubs/verifications in various without realizing due to me force pushing so I pushed each of the changes as an individual commit to better track changes. If you want me to squash the PR then let me know.

@mdedetrich Some of our discussions on this PR are still unresolved. Did you forget to push some commits?

@mdedetrich I answered your question about InOrder. Sorry, I somehow missed that.
Note that I unresolved other two comments:
https://github.com/apache/kafka/pull/12524/files#r984332259
https://github.com/apache/kafka/pull/12524/files#r984332539
Let me know if my comments are not clear.

@cadonna

https://github.com/apache/kafka/pull/12524/files#r984332259

This one is resolved now, I think I somehow missed that, apologies

https://github.com/apache/kafka/pull/12524/files#r984332539

So this one is not clear to me, commented on it.

Hello @mdedetrich and @cadonna! Is there something still remaining for this pull request or are we ready to merge it? There are around 4 pull requests remaining of this migration and I would like to get them to a completion 😊

Sorry I have just been busy with other things, will look into it next week

Can this be closed now? It looks like this has been done in https://github.com/apache/kafka/commit/a33c47ea4ddc810d66b6ed17ab74e40c5b7668fb / https://github.com/apache/kafka/commit/8b72a2c72f09838fdd2e7416c98d30fe876b4078

Yes


Access logs aren't flusing on traffic_server death

If there are logs in the flush buffer when we kill traffic_server, we lose these logs. There needs to be a way for ATS to flush these logs upon receiving a signal.
The obvious way would be to call Log::flush_thread_main(..) in Main::proxy_signal_handler(..), but I highly doubt that function is signal safe.

well, I don't know it is still the old style, but TS have a shutdown command(way) to stop the server safely, while most init scripts just kill, you should prefer the shutdown if it still works, because you care it. flush on kill or crash sounds cool but may bring too many code complex or trouble, IMO

Is the shutdown command ./trafficserver stop? That makes sense if the script did a safe shutdown. The reason I bring this up is because @dragon512 is working on a testing framework and (I assume) only starting up the traffic_server binary and skipping the script. When we test for the presence of logs, if we kill too fast we get nothing in the logs.

Back some version early, there is a command line traffic_line:  -S, --shutdown          on    false     Shutdown traffic_server (local node) please find out. as I am sure the scripts mostly will do a kill, and trafficserver is the sysV init script.

I am not updated with the current traffic ctl commands etc, so maybe you can find it out current status on this.

70ef31e8ac76 removed traffic_line. I worked with the traffic_ctl code for process control earlier and I don't recall seeing any logging related code. I have a feeling this issue has always existed but just nobody noticed.

great that you take care of the ctl codes. afaict, MGMT_EVENT_SHUTDOWN handling is still in the codes, maybe you can find a way to use it?

#1937 may provide a chance for flushing logs.

If this is still an issue please reopen.


Start to move the fetching of data out so that we only do it once at …

…the beginning.

it's big. I'm sure it's fine!

This is too big for me to review effectively. If the tests pass I'm saying it's fine.
If there's ever an opportunity to move tests higher up the application away from testing individial classes and towards testing the listener or the service, I've found that these kind of refactors (where nothing functionally changes) become easier as you don't break lots of tests when moving functionality between classes.


Standardise hostnames on our machines

Follow-on to https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/131 - we should define a standard machine naming convention. Currently most are of this format:
<usage>-<provider>-<arch>-<os>-<sequence>
Although some are missing the architecture - mostly windows/macos boxes where they're all x64. We do also have an issue where some of our tests don't work properly when there is a . in the machine name (for example those with names includeding ubuntu-16.04) and in those cases we have replaced the . with a - on the machine itself.
This work item will discuss that convention and it is what's used in jenkins, nagios etc and listed on https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/master/infrastructure.md, and whether the hostnames on the machines we get from the providers should be changed to match these (possibly with the . to - translation ... Or whether we should just avoid having . in the names at all. At the moment some of the hostnames on the machines don't match what we call them, which is inconvenient when you're logged into multiple machines

yes I agree the . periods do not translate. using - dashes is better
Issue #165 (Set system hostname to match jenkins) is related to this

I would wote for . replaced by _ instead  by -.
reason is - ubuntu-16.04 would change to ubuntu-16-04 where the . had different meaning then have new dash.
Generality strict delimiter of various parts is currently dash. So it should not be used in sub parts.
Also, what is   and  .. well and  ... for?Well For us newbies, can you elaborate more on individual parts of ----?
Shouldn't be some of those handled elsewhere?  Ideally all except - ?

@judovana I'm not sure what you mean by the "what is and ... well and ... for?" question. Or "individual parts of ----?"

Ha. Markdown had eaten  the tags. Sorry
Also, what is <usage>  and <prvoder> .. well and <sequence> ... for?Well For us newbies, can you elaborate more on individual parts of  <usage>-<provider>-<arch>-<os>-<sequence>?
Shouldn't be some of those handled elsewhere? From those probably only  <arch>-<os>  are celar?

Ah :-D <usage> is mostly one of build test jck, provider is whichever cloud provider the machine comes from so softlayer marist joyent etc. <sequence is just a number to distinguish them if we have more than one of the same machine so -1 -2 etc. The link in the initial post has all the machines so has various examples.

Thank you. My nit would be that usage should be handled differently. Machine should (== one wish) transparent. Provider is interesting, and sequence made sense. TY!

closing this as we have now got our inventory.yml sorting this out. I will create new issues to bring any old machines up to date with the new hostname schema


Loot Table Datagen

Blocks in the mod have an onHarvested hook so that they drop themselves when a player breaks them, but that doesn't work when goo breaks them. This is not great.
Make it use the loot tables to drop itself so that it is instead great.

Done on both branches


New Terminal button doesn't work

Version: 1.0.0-alpha.57
Platform: win32 10.0.17134
Plugins:

Same here for version 1.0.0-alpha.57, platform win32 10.0.17134.
Screenshot of console error messages after bring up the app settings (these were already present - clicking new tab did not push anything to console):


ML_AGNzoo doesn't finish executing

I've had this notebook running for about an hour and it's still not done. It has been stuck on the second cell in section '4) Repeating the above, this time with ZTF + WISE manifold' for most of the time.  I don't know whether this is normal/expected or not.
Originally posted by @troyraen in https://github.com/nasa-fornax/fornax-demo-notebooks/pull/321#discussion_r1733620683

I ended up letting it run for at least 4 hours but it never finished that cell. This was on Fornax. @bsipocz reported having the same problem locally.
I see the following warnings which make me wonder if either a) it can't do some calculation without inverse_transform and just keeps retrying indefinitely; or b) it's intended to be running in parallel but actually isn't.
/opt/conda/lib/python3.10/site-packages/umap/umap_.py:1850: UserWarning: custom distance metric does not return gradient; inverse_transform will be unavailable. To enable using inverse_transform method, define a distance function that returns a tuple of (distance [float], gradient [np.array])
  warn(
/opt/conda/lib/python3.10/site-packages/umap/umap_.py:1945: UserWarning: n_jobs value 1 overridden to 1 by setting random_state. Use no seed for parallelism.
  warn(f"n_jobs value {self.n_jobs} overridden to 1 by setting random_state. Use no seed for parallelism.")

@xoubish any ideas?

It doesn't take that long for me running it. I think the whole notebook took less than ~20 minutes. But commenting DTW distance and using the other ones (e.g., Manhattan, euclidean, ...) would speed things up a lot.

I have to restart again with a fixed download cell and see, it may just run into CircleCI resources (my latest renderings are actually useless here)

OK, so the cell hits the timeout limit of 900s  on my laptop. It's configurable, so I'm changing it to 1200s for now. But nevertheless, if it makes sense for the content to change for a more speedy metric, then we may want to change it anyway.
File "/Users/bsipocz/munka/IPAC/worktrees/fornax-demo-notebooks/hacking/.tox/buildhtml/lib/python3.12/site-packages/nbclient/client.py", line 856, in _async_handle_timeout
    raise CellTimeoutError.error_from_timeout_and_cell(
nbclient.exceptions.CellTimeoutError: A cell timed out while it was being executed, after 900 seconds.
The message was: Cell execution timed out.
Here is a preview of the cell contents:

@xoubish, @troyraen. Can you report which environment/compute you are both using where one runs and the other does not.

It fails for me using both the root and science_demo kernels in the Default Astrophysics image and the Large server type.

It fails for me using both the root and science_demo kernels in the Default Astrophysics image and the Large server type.

Is this is the new deployment? Did you try the Dev image?

Same results in the new and old deployments, and in the Dev Astrophysics image on new deployment.

FWIW, I let the notebook run on my laptop and manually killed it after it was still running, spending 1hr20mins on the last cell. Right now I disabled its execution in CI.

@xoubish Did you mean to have the line in section 4 with
'mapper = umap.UMAP(n_neighbors=50,min_dist=0.9,metric=dtw_distance,random_state=20).fit(data) #this distance takes long'.
I think the line we actually want to run is commented out above this one, and the line that we don't want to run because it takes too long is uncommented.  It's an easy PR to fix, but I want to make sure that is the intent.

The last cell also has a DTW distance, and it's plotted up as such for a comparison of 4.

Shooby just confirmed on slack that we can comment out all the cases of dtw_distance (or replace depending on the situation; I haven't gone back yet to look at the last cell).


Fix node artifact building on mac

This should fix the npm: command not found we are seeing on mac workers (or just one of them).
Also a tiny bit of cleanup.

Will test this manually and let you know if it helps.

Seems this has worked nicely:
https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts/159/


Issue: OpenAI Bad Gateway results in Error in on_retry: asyncio.run() cannot be called from a running event loop (coroutine 'AsyncRunManager.on_retry' was never awaited) inside openai.acompletion_with_retry

Issue you'd like to raise.
I just saw a novel error, which appears to be triggered by a failed OpenAI API call (inside an asynchronous block) which is causing an asyncio.run() inside an asyncio.run().  Error pasted below.  Is this my (user) error?  Or possibly a problem with the acompletion_with_retry() implementation?
2023-07-29 05:53:14,838 INFO     message='OpenAI API response' path=https://api.openai.com/v1/chat/completions processing_ms=None request_id=None response_code=502
2023-07-29 05:53:14,838 INFO     error_code=502 error_message='Bad gateway.' error_param=None error_type=cf_bad_gateway message='OpenAI API error received' stream_error=False
2023-07-29 05:53:14,839 WARNING  Retrying langchain.chat_models.openai.acompletion_with_retry.<locals>._completion_with_retry in 4.0 seconds as it raised APIError: Bad gateway. {"error":{"code":502,"message":"Bad gateway.","param":null,"type":"cf_bad_gateway"}} 502 {'error': {'code': 502, 'message': 'Bad gateway.', 'param': None, 'type': 'cf_bad_gateway'}} <CIMultiDictProxy('Date': 'Sat, 29 Jul 2023 05:53:14 GMT', 'Content-Type': 'application/json', 'Content-Length': '84', 'Connection': 'keep-alive', 'X-Frame-Options': 'SAMEORIGIN', 'Referrer-Policy': 'same-origin', 'Cache-Control': 'private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0', 'Expires': 'Thu, 01 Jan 1970 00:00:01 GMT', 'Server': 'cloudflare', 'CF-RAY': '7ee3120dab9f1084-ORD', 'alt-svc': 'h3=":443"; ma=86400')>.
2023-07-29 05:53:14,839 ERROR    Error in on_retry: asyncio.run() cannot be called from a running event loop
/usr/local/python-modules/tenacity/__init__.py:338: RuntimeWarning: coroutine 'AsyncRunManager.on_retry' was never awaited
  self.before_sleep(retry_state)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Suggestion:
No response

I'm observing a big spike from this as well.
@hinthornw Looks like this error was likely introduced in https://github.com/langchain-ai/langchain/pull/8053. Any ideas?

@maspotts I'm seeing similar, what type of code are you running that is causing this? Thanks

The problem is that create_base_retry_decorator tries to asyncio.run something in the before_sleep callback, which breaks things when this is all happening inside an agenerate call.

@kylrth Thanks for the info, yea, I think I'm seeing similar. What kind of code are you running that causes it. For me it's doing a MapReduce.

I see it with just ChatOpenAI.agenerate when OpenAI returns a 502.

@hwchase17 Any chance someone's looking at this? It's a source of high billables potentially.

@maspotts I'm looking into this too, do you see the same issue on the latest version? @kylrth can you expand a bit more on why the asyncio.run is problematic here? I am running into this issue with agenerate, and notice my retries don't run after 4/8/10 seconds as they should - they are run after about 6-7 minutes, and I'm wondering if fixing this bug may fix my issue of retries from 502s failing.  Maybe I can take a go at tackling this.

@kylrth Thanks for the info, yea, I think I'm seeing similar. What kind of code are you running that causes it. For me it's doing a MapReduce.

Me too. A mapreduce chain via analayzeDocumentsChain

I think this issue is closed by #8659. @hinthornw ?

@kylrth Hah, I was just running through the same PR. Looks like the way tenacity's retry decorator works takes care of the async/sync switch. Can I ask - can you verify that on recent langchain that retries do indeed work after X (2/4/8) seconds? For me it's hanging for 6-7 minutes between retries even though it prints our retrying in X time.

So important notes regarding this issue from my investigation:

If using Async calls, when you receive a 502 bad gateway, it will timeout after the whole 600s. https://github.com/openai/openai-python/pull/387 Needs to be fixed in openai-python. We need read timeouts and not a total timeout.
After stalling your chain for the entirety of 10 minutes, you WILL BE BILLED for no generation, besides it absolutely destroying experience by forcing one part of the chain to wait an entire 10 minutes.

@hinthornw this was fixed in https://github.com/langchain-ai/langchain/pull/8659 right? If so, lets close it


Fix spelling errors

I noticed quite some spelling errors in the codebase, so I decided to fix some of them by running spell-checker.

Thanks! Looks good, just some false positives


WordPress integration: protect the search API

We don't want to leave the search endpoint wide open so anyone can use it, but we also can't use our existing authentication system because the societies' user database will likely be stored in wordpress or some other system, not in Auth0/Cognito.
Here's an idea: our search client issues search requests to the Wordpress server, and the wordpress server encodes the current timestamp as a JWT using a shared secret and adds it as a header when it forwards the search request to our search API. Our search API then uses the shared secret to decode the JWT and verifies the timestamp is within the last 30 minutes (in case of clock skew), returns the results to the Wordpress server, which then forwards them to our search client.

Could you expand on the use case here? Is our search page in an iframe in the Wordpress page and the user is logged in to WP but not our UI?
If the search requests go through the WP server and we trust the WP server to keep a secret, we can use the Client Credentials Flow. We issue an API key and secret to WP which they can exchange for an access token.
But as I said, I'm not clear on the scenario, so I may be misunderstanding.

I'm thinking that the javascript code for our search page is loaded directly into the Wordpress page (no iframe). We'd need to break out the search page into a separate client as Judy+Robert have done. And yes, the user is logged into WP but not our UI. I'm thinking that societies will use WordPress to manage their registered users because that's convenient for them, and use Auth0/Cognito to manage their volunteers.
So yes, the search requests go through the WP server and we trust the WP server to keep a secret, so we could use the Client Credentials Flow. I just have to find out how difficult it is to implement that in a Wordpress PHP script.


Updating to AspNetCore.NodeServices 1.1

Also updated the cake build script (to the latest version from the cake site).
I tested the NodeServices changes in an MVC5 project that I'm using this library in and everything seems to work fine.
I did not try the changes in a MVC core project.

I am working on a new release now.


Typo

ref: https://theasciicode.com.ar/ascii-control-characters/line-feed-ascii-code-10.html

@fjoshuajr : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Missing json files for tests

To run the tests the following files seem to be required but are missing from the repo:

/data/script_valid.json
/data/script_invalid.json
/data/sighash.json
/data/tx_valid.json
/data/tx_invalid.json
/data/sig_canonical.json

Could you supply these or tell what's supposed to be in it?

These guys come from the official bitcoin release. They are part of their unit tests.

Thanks, found them except the sig_canonical.json one.
Doesn't seem to be located at https://github.com/bitcoin/bitcoin/tree/master/src/test/data

Strange... Nbitcoin still has it though
https://github.com/NicolasDorier/NBitcoin/tree/master/NBitcoin.Tests/data

Deleted at https://github.com/bitcoin/bitcoin/commit/d6bed1514c2e72ea2006942c23c31e3f518d4a77
Doesn't seem to state why though...
Anyway, thanks :+1:


a:visited in code blocks messes up highlighting

The css has a general a:visited defined to a tint of blue, which applies to code blocks and thus changes highlighting:

Here to, from, Set and extensionality have been visited. This is less critical for function and type names but, as can be seen, changes the color for record fields (and would do for the refl type constructor as well) significantly.

Thank you, but I'm not sure what point you are making. The best way forward might be for you to file a pull request that fixes what you see to be the problem. Go well, – P

From: adql @.>
Sent: 02 May 2024 09:58
To: plfa/plfa.github.io @.>
Cc: Subscribed @.***>
Subject: [plfa/plfa.github.io] a:visited in code blocks messes up highlighting (Issue #989)
This email was sent to you by someone outside the University.
You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
The css has a general a:visited defined to a tint of blue, which applies to code blocks and thus changes highlighting:
code_block.png (view on web)https://github.com/plfa/plfa.github.io/assets/6893125/eedebf8f-88b4-46cf-986d-02343903f597
Here to, from, Set and extensionality have been visited. This is less critical for function and type names but, as can be seen, changes the color for record fields (and would do for the refl type constructor as well) significantly.
—
Reply to this email directly, view it on GitHubhttps://github.com/plfa/plfa.github.io/issues/989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFJ7MT7G2Y67DSAHMQP6MTZAH53XAVCNFSM6AAAAABHDJWXBWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TIOJXGE2TKMI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

Thank you, but I'm not sure what point you are making. The best way forward might be for you to file a pull request that fixes what you see to be the problem. Go well, – P

From: adql @.***>
Sent: 02 May 2024 09:58
To: plfa/plfa.github.io @.***>
Cc: Subscribed @.***>
Subject: [plfa/plfa.github.io] a:visited in code blocks messes up highlighting (Issue #989)
This email was sent to you by someone outside the University.
You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
The css has a general a:visited defined to a tint of blue, which applies to code blocks and thus changes highlighting:
code_block.png (view on web)https://github.com/plfa/plfa.github.io/assets/6893125/eedebf8f-88b4-46cf-986d-02343903f597
Here to, from, Set and extensionality have been visited. This is less critical for function and type names but, as can be seen, changes the color for record fields (and would do for the refl type constructor as well) significantly.
—
Reply to this email directly, view it on GitHubhttps://github.com/plfa/plfa.github.io/issues/989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFJ7MT7G2Y67DSAHMQP6MTZAH53XAVCNFSM6AAAAABHDJWXBWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TIOJXGE2TKMI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.

@wadler The issue is that clicking a definition for more info and then coming back messes up syntax highlighting.

Yes, that's right. Clicking the definitions changes the highlighting, which then remains wrong until the browser forgets the visited target, whenever that may be.
Agda.css doesn't contain any rules for a:visited, neither enabling or disabling. So it essentially reflects the style where it's embedded. I suppose escalating makes sense for a general solution.
As for PLFA itself, it seems like the "blame" is on $link-visited-color, which is defined in the various scss files in web/sass/theme/skins and applied in web/sass/theme/_base.scss#L133.

Yes, that's right. Clicking the definitions changes the highlighting, which then remains wrong until the browser forgets the visited target, whenever that may be.
Agda.css doesn't contain any rules for a:visited, neither enabling or disabling. So it essentially reflects the style where it's embedded. I suppose escalating makes sense for a general solution.
As for PLFA itself, it seems like the "blame" is on $link-visited-color, which is defined in the various scss files in web/sass/theme/skins and applied in web/sass/theme/_base.scss#L133.

No, I'm suggesting adding rules for a:visited to Agda.css that override any other highlighting to preserve consistent highlighting regardless of what other CSS is added.

I agree, my last paragraph was only for context.

I believe this is not an issue upstream in Agda after all, but rather a too low specificity of the selectors in PLFA's agda{-dark}.scss files. Check out Agda's original agda.css, where all selectors for highlighted definitions are under an .Agda parent. This is for some reason absent in PLFA's agda.scss, which causes a generic a:visited to have a higher specificity.


Switch to the SciTypes.jl package

Codecov Report

Merging #175 (50b43f2) into master (b100d72) will increase coverage by 0.61%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.


Fix 1.0.1

http://github.com/voidus/rspec-puppet/tree/1.X contains a fix for rspec-2.99 and sets the rspec version to ~> 2.99.
Please use it as a starting point for further 1.X development and release 1.0.2 because of the rspec-2.99 fix.
Thanks for the good work!

As I don't know anybody who's working on rspec 1.x, can we close this?


[Dubbo-issue-2136] Replace hard coded version number of hessian-lite with unified property variable. #2136

What is the purpose of the change
Replace hard coded version number of hessian-lite with unified property variable. #2136
Brief changelog
Replace hard coded version number of hessian-lite with unified property variable.
Verifying this change
dubbo-bom/pom.xml
From Baiji, Term 268, Team 3, Issue #2136, Q3-2

Please focus on one issue on a single patch.


Update project & source URL from MSysGit to Git for Windows.

Since the upcoming Git for Windows versions will be maintained under the git-for-windows instead of the msysgit account, this commit updates the corresponding variables for the Git for Windows project site (project_url) as well as for the source link (source_url).

Oops. I just realized this is a (partial) duplicate of #550. Closing mine.


fix(markdown) : Now it doesnt keep the edit mode on in desc box while switching WIs

Please Refer: https://github.com/openshiftio/openshift.io/issues/2453

Can one of the admins verify this patch?

@dlabrecq please review

can validate once the snapshot is available.

I don't think this has the snapshot set up. Something else to add to the list of things to do.


1.9.0: sh.CommandNotFound: ansible_galaxy

Hi,
A test on Travis installed version 1.9.0  (https://travis-ci.org/dj-wasabi/ansible-zabbix-proxy/builds/154438070) and it fails when it tries to download the dependencies.
--> Installing role dependencies ...
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.10/bin/molecule", line 11, in <module>
    sys.exit(main())
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/cli.py", line 68, in main
    CLI().main()
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/cli.py", line 64, in main
    util.sysexit(c.execute()[0])
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/command/test.py", line 57, in execute
    status, output = c.execute(exit=False)
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/command/converge.py", line 86, in execute
    galaxy.install()
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/ansible_galaxy.py", line 102, in install
    self.bake()
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/molecule/ansible_galaxy.py", line 68, in bake
    self._galaxy = sh.ansible_galaxy.bake('install',
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/sh.py", line 2301, in __getattr__
    return self.__env[name]
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/sh.py", line 2232, in __getitem__
    return Command._create(k, **self.baked_args)
  File "/home/travis/virtualenv/python2.7.10/lib/python2.7/site-packages/sh.py", line 776, in _create
    raise CommandNotFound(program)
sh.CommandNotFound: ansible_galaxy

I don't see on the documentation that ansible-galaxy needs to be installed separately?
Kind regards,
Werner

Hi @dj-wasabi molecule no longer installs ansible through it's requirements.  We assume people want to control the version of ansible they are running.
I noticed your travis file doesn't install ansible.  You should be good if you install ansible before molecule.

Ok, thanks! Will make sure I install it within the .travis.yml file.


Add marshal.MustUnmarshal() function

Codecov Report

Merging #3220 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

Impacted Files
Coverage Δ

go/marshal/decode.go
96.46% <100%> (+0.03%)
:white_check_mark:

go/chunks/put_cache.go
88% <ø> (-8%)
:x:

go/chunks/dynamo_store.go
74.61% <ø> (-0.62%)
:x:

go/nbs/table_reader.go
94.69% <ø> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1afbb9...49c001f. Read the comment docs.


Any precondition for the provided 2d points and 3d points

Hi, thank you for sharing your code.  I wonder that if the 2d points are sampled from object A in the image I, while the 3d points are sampled from object B in the image I. Could the bpnpnet be suitable for such an experimental setting? Since it seems that there is no correspondence between the 2d points and 3d points in such conditions.
Or is there any requirements/precondition for the provided 2d points and 3d points? (such as the number of the provided 2d and 3d points at least, the sample range of the 2d/3d points, etc.)

Hi @hetolin, no, it couldn't be used in such a setting. Some correspondences need to exist, even though they aren't known to begin with. That being said, the model will still try to align object A and B, which might be useful in some contexts (though not for camera pose estimation).
Yes, there are some requirements on the number and layout of 2D and 3D points, same as for any PnP algorithm. At least 4 2D-3D pairs are required at minimum, and they can't be degenerate.

Hi @hetolin, no, it couldn't be used in such a setting. Some correspondences need to exist, even though they aren't known to begin with. That being said, the model will still try to align object A and B, which might be useful in some contexts (though not for camera pose estimation).
Yes, there are some requirements on the number and layout of 2D and 3D points, same as for any PnP algorithm. At least 4 2D-3D pairs are required at minimum, and they can't be degenerate.

Thank you for your prompt reply. The network takes the paired 2D-3D points as input. The video provided in your paper mentioned that the lidar data and the image data are not paired, so the bpnpnet could not be used in such a setting?

Thank you for your prompt reply. The network takes the paired 2D-3D points as input. The video provided in your paper mentioned that the lidar data and the image data are not paired, so the bpnpnet could not be used in such a setting?

No, the number of 2D and 3D points aren't required to be equal. And yes, lidar + image data is suitable. The requirement is just that there is some overlap between the 2D points and the 3D points: some of the 2D-3D pairs must correspond approximately. So if you have taken a lidar scan of an object and image points of the same object, that is satisfactory.

No, the number of 2D and 3D points aren't required to be equal. And yes, lidar + image data is suitable. The requirement is just that there is some overlap between the 2D points and the 3D points: some of the 2D-3D pairs must correspond approximately. So if you have taken a lidar scan of an object and image points of the same object, that is satisfactory.

Thank you, I see what you mean. But there is a last one question left: As for an object M, I get the surface 2d pixel points and the 3d points sampled from the whole 3D model. And if I sent the partial 2d points and full 3d points into the bpnpnet.  That is, 2d points are a subset of the 3d points. In such a setting, would it degrade the performance or influence the accuracy of camera pose estimation?

Thank you, I see what you mean. But there is a last one question left: As for an object M, I get the surface 2d pixel points and the 3d points sampled from the whole 3D model. And if I sent the partial 2d points and full 3d points into the bpnpnet.  That is, 2d points are a subset of the 3d points. In such a setting, would it degrade the performance or influence the accuracy of camera pose estimation?

Hi @hetolin, yes the performance degrades as the overlap decreases. You can get an idea of the performance degradation in the supplementary material (Fig 1 for random outliers, Fig 2 for structured outliers - which is what you are talking about). These results show robustness to partial overlap despite only training with 1:1 data, so fine-tuning the model or retraining it with partially-overlapping data would probably improve the robustness even further.

Hi @hetolin, yes the performance degrades as the overlap decreases. You can get an idea of the performance degradation in the supplementary material (Fig 1 for random outliers, Fig 2 for structured outliers - which is what you are talking about). These results show robustness to partial overlap despite only training with 1:1 data, so fine-tuning the model or retraining it with partially-overlapping data would probably improve the robustness even further.

I got it! Thank you very much for your detailed reply.

I got it! Thank you very much for your detailed reply.


After updating yo aspnetcore-spa template with angular 4.0.2 "No NgModule metadata found for 'AppModule'."

This is my package.json
"dependencies": {
"@angular/animations": "^4.0.2",
"@angular/common": "^4.0.2",
"@angular/compiler": "^4.0.2",
"@angular/compiler-cli": "^4.0.2",
"@angular/core": "^4.0.2",
"@angular/forms": "^4.0.2",
"@angular/http": "^4.0.2",
"@angular/platform-browser": "^4.0.2",
"@angular/platform-browser-dynamic": "^4.0.2",
"@angular/platform-server": "^4.0.2",
"@angular/router": "^4.0.2",
"@types/node": "^6.0.42",
"angular2-platform-node": "~2.0.11",
"angular2-template-loader": "^0.6.2",
"angular2-universal": "^2.1.0-rc.1",
"angular2-universal-patch": "^0.2.1",
"angular2-universal-polyfills": "^2.1.0-rc.1",
"aspnet-prerendering": "^2.0.0",
"aspnet-webpack": "^1.0.17",
"awesome-typescript-loader": "^3.0.0",
"bootstrap": "^3.3.7",
"css": "^2.2.1",
"css-loader": "^0.25.0",
"es6-shim": "^0.35.1",
"event-source-polyfill": "^0.0.7",
"expose-loader": "^0.7.1",
"extract-text-webpack-plugin": "^2.0.0-rc",
"file-loader": "^0.9.0",
"html-loader": "^0.4.4",
"isomorphic-fetch": "^2.2.1",
"jquery": "^2.2.1",
"json-loader": "^0.5.4",
"preboot": "^4.5.2",
"raw-loader": "^0.5.1",
"rxjs": "^5.0.1",
"style-loader": "^0.13.1",
"to-string-loader": "^1.1.5",
"typescript": "^2.2.2",
"url-loader": "^0.5.7",
"webpack": "^2.2.0",
"webpack-hot-middleware": "^2.12.2",
"webpack-merge": "^0.14.1",
"zone.js": "^0.7.6"
},
"devDependencies": {
"@types/chai": "^3.4.34",
"@types/jasmine": "^2.5.37",
"chai": "^3.5.0",
"jasmine-core": "^2.5.2",
"karma": "^1.3.0",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-webpack": "^1.8.0"
}
---------- This is my app.module.ts --------------------
import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';
import { UniversalModule } from 'angular2-universal';
import { AppComponent } from './components/app/app.component';
import { NavMenuComponent } from './components/navmenu/navmenu.component';
import { HomeComponent } from './components/home/home.component';
import { FetchDataComponent } from './components/fetchdata/fetchdata.component';
import { CounterComponent } from './components/counter/counter.component';
@NgModule({
bootstrap: [AppComponent],
declarations: [
AppComponent,
NavMenuComponent,
CounterComponent,
FetchDataComponent,
HomeComponent
],
imports: [
UniversalModule, // Must be first import. This automatically imports BrowserModule, HttpModule, and JsonpModule too.
    RouterModule.forRoot([
        { path: '', redirectTo: 'home', pathMatch: 'full' },
        { path: 'home', component: HomeComponent },
        { path: 'counter', component: CounterComponent },
        { path: 'fetch-data', component: FetchDataComponent },
        { path: '**', redirectTo: 'home' }
    ])
]

})
export class AppModule {
}

I got following error on browser console when running the app. What should be the reason. "
Error: No NgModule metadata found for 'AppModule'."

I have the  same problem

In your AppModule are you exporting a class or a defualt class? In angular4
yiu cantora export a default class, so just export a class, like:
"export default class AppModule" -> "export class AppModule"
Try this and give a return please :)
Em 22 de abr de 2017 8:01 PM, "Strux"<EMAIL_ADDRESS>escreveu:

I have the same problem
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/akveo/ng2-admin/issues/999#issuecomment-296407093,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATe_Ey1noZPFBQL2jAaRnROcV4sPDlDXks5ryoa7gaJpZM4NC2DW
.


[DOCS] Fix typo

       ❨?❩
change BONDED_EXPONENTIAL_BACKOFF to BOUNDED_EXPONENTIAL_BACKOFF

nice catch! can we have a meaningful PR title for better git history? for example, Rename blablahbalah

thanks, merged to master for v1.2.0


don't rely on featured link to extract program url from discourse post

Needs testing.

Yup ham is good


Imtool3d td

#232
Replace current viewer with imtool3D_td
Currently imtool3D is a copy... I would recommend to use a submodule because imtool3D is going to evolve
Note that imtool3d open .nii files by default in the Matlab filebrowser (double click a .nii or .nii.gz file)

Coverage increased (+0.006%) to 43.687% when pulling 0ca9f92729da21a92413eeae58b5f41745d1e1b7 on imtool3d_td into 0e97155a6e310911e575ebd8f8870e5f2988a82b on master.

Thanks @tanguyduval ! I would actually recommend against using submodules. I did so a lot while working on my last paper (qMRLab was a submodule), and the problem is that the submodule lives independently from the branches on your local. So, if you're in a branch, update your submodule to the latest one, when you checkout another branch to work on something else, the newer version of the submodule is still there. It gets... messy, and fixing submodule bad commits gets really convoluted in my experience.
I would recommend for us to simply copy-paste your library in the External folder once it is stable enough and has all the initial features you want, and then we can update that one regularly using PRs so they can be properly vetted/tested, to ensure stability of it within qMRLab.

@mathieuboudreau all features are present. I will now stop updating this branch.

@TommyBoshkovski could you review this PR, since it contains similar functionality to the ROI GUI tool you implemented to qMRLab previously?

Sure @mathieuboudreau, I will review it shortly.

@tanguyduval Thanks for the quick fix! It works great now.

There was an orientation issue for data fitting.
Also I just added statistics/histogram in the different ROI:

@mathieuboudreau I had to modify slightly your histogram to handle multi-label mask

@TommyBoshkovski could you please do a final review following Mathieu's guideline https://github.com/qMRLab/qMRLab/wiki/Guideline:-Reviewing-a-pull-request
Thanks!

@TommyBoshkovski could you please test using the recommendations, I finished adding the functionalities required!! Thanks!
https://github.com/qMRLab/qMRLab/wiki/Guideline:-Reviewing-a-pull-request

Thanks for the updates @tanguyduval . I will test all of the functionalities and get back to you.

@TommyBoshkovski could you test the last version??

@TommyBoshkovski thank you! This branch is finally out!!
Just out of curiosity, which version of Matlab were you using to test the branch??
I manually compiled the new documentation. @mathieuboudreau I thought the compilation was automatic?
Since there are significant changes in this branch it would be nice if as many people as possible could pull this version and report potential bugs.

@tanguyduval cool! I will take a look at this today.

It's already been merged to master, so I guess all users will be testing this haha.
As for the RTD compilation, I thought it did so after merges to master, but maybe not? @agahkarakuzu any clue ?

@mathieuboudreau I will use to see if I am going to run into bugs before users do :)
For RTD,  we need to run GenerateDocumentation.m and commit all the changes. No problem if sphinx is not installed on your local, it will be taken care of. @mathieuboudreau I can do this today.

That's odd, on AxonDeepSeg we don't need to run it manually; RTD is always compiled automatically when we push (or at least, to master). Is this because we've customised it ourselves here?

I am not 100% sure of the rationale behind this convention, but may be due to a Matlab dependency.

@tanguyduval I am running into several issues, I will try to list them here. (Ubuntu 18.04, R2018b)

Cursor hides behind the main panel

This happens on several cases, such as I delete a circular ROI, or try to use tools successively (e.g. distance measure after magic brush). Right click appears to bring cursor back on the mail panel, found out by chance.

WindowButtonMotionFcn reference to an invalid or deleted object error invades main window.

This is also somehow resolved after right click (on any point), the error won't keep being printed after. However, the same complication happens for almost all tools once an item has been deleted, resulting in a main window swarming with red text.

Overall, right click recovers the default cursor functionality, but lots of errors are thrown during the ROI operations until then.
It is likely that users wont be able to get the hang of it quickly through intuition. Instead, one may need to visit the documentation first and realize that ordering of the operations matters for a stable behaviour.

@agahkarakuzu thank you for testing this! Indeed, if you have an error in the windowbuttonMotionfcn, that will keep generating errors each time you move your mouse :(
Could you please detail the steps to reproduce the bug?! I tried deleting a circle or draw a line after a circle but no bugs on my side. Maybe try restoredefaultpath, then run startup, then qmrlab

@agahkarakuzu Since this PR has already been merged to master, could you open an issue with your description of the bugs/behaviour problems, and set the priority to high? If it isn't resolved two weeks before ISMRM, maybe we should revert temporarily to the old behaviour and re-merge this branch after ISMRM.

Could you please detail the steps to reproduce the bug?! I tried deleting a circle or draw a line after a circle but no bugs on my side. Maybe try restoredefaultpath, then run startup, then qmrlab

@tanguyduval will do that and open an issue as @mathieuboudreau suggested right after finishing working on hackathon website, registration, payment etc. :)

@agahkarakuzu I could reproduce your error on ubuntu... slightly different behavior on linux apparently. I'll submit a fix tomorrow.

@tanguyduval I was about to write that I did not run into the issue on MBP, but reproduced on Ubuntu. Cool!

BP=MacBook Pro, it took me a while to figure this 🤣. You are getting more and more apple addict at neuropoly!! 😆😆

@mathieuboudreau @tanguyduval you can take a look at the latest documentation here: https://qmrlab.readthedocs.io/en/update_doc/
@tanguyduval was there supposed to be something for ROI toolbox?


Update sample code in README.rst

@zancas
What issues does this address?
Fixes #64
What's this change do?
Update the readme and docs to use the right parameters.
Where should the reviewer start?
Look at README and docs/index.rst
Any background context?
Issue found by user.

This needs to go against 1.0 instead of master.


Public key derivation

Currently we only support private parent key → private child key derivation. Deriving public child keys allows for sharing public keys, without needing to expose private keys.
For reference:

https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#public-parent-key--public-child-key
https://github.com/satoshilabs/slips/blob/master/slip-0010.md#public-parent-key--public-child-key

Note that this isn't supported by ed25519, as it only works with hardened keys.

Hey team! Please add your planning poker estimate with ZenHub @FrederikBolding @ritave @hmalik88 @Mrtenz


tinned meat doesnt stay deep fried once eaten

Description
empty tinned meat doesnt inherit deep fried-ness and i suspect several other items do this too
Reproduction

open meat
deep fry
eat it all
empty tin is not deep fried

I'm going to leave this as-is for now so long as it's a minor cosmetic issue.


Filter and Sort not working

Describe the bug
I can't filter or sort on any lists. Out of the box Users list can't even be filtered or sorted which I'd expect would work since it's the defaults. I can't filter or sort on other tables, but at the least I figured users and roles would work.
To Reproduce
Steps to reproduce the behavior:

Install clean copy of Laravel ^9.19 (9.29)
Install Orchid 13.1 per instructions on site
Add a few test users
Try filtering by name or email address

Expected behavior
I expect that sorting and filtering will work.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome 105.0.5195.102
Version [e.g. 22]

Server (please complete the following information):

Platfrom Version: Windows 10 running XAMMP 3.3
Laravel Version: 9.29
PHP Version:  8.1.2
Database:  MariaDB
Database Version:  10.4.22-MariaDB - mariadb.org binary distribution

Additional context
Add any other context about the problem here.

Remove UsersFilter::class in queue of UserListScreen

@Cregennan , thanks for the reply.
I commented out ->filters(UserFiltersLayout::class) in the query() method and UserFiltersLayout::class in the layout() method.
That did not fix the problem.

I'm doing some experiments to try finding the issue.
I've confirmed that the sort is being added to the query in orchid\platform\src\Filters\HttpFilter.php:203

@Cregennan
Oh, I get what you were saying. Change ->filters(UserFiltersLayout::class) to ->filters()
That fixes the filtering and sorting to work with name and email. However, I can't filter on role anymore. It's one or the other?
I also found that I had been calling defaultSort before the filters method on the other models. When I make sure to apply filters() first, I was able to get the other list screens to work. The order of things being called doesn't seem to be documented but the example found in "Automatic HTTP Filtering and Sorting" does show the order correctly. My bad.

Order that these are called in is very important it seems. The below code is working.
return [
            'users' => User::with('roles')
                ->filters(UserFiltersLayout::class)
                ->filters()
                ->defaultSort('name', 'asc')
                ->paginate(),
        ];

Call filters() empty after the other is what got it working.
I'd suggest either making it so that the order that these methods are called does not impact the query (besides paginate for obvious reason). Otherwise, document that the order is important.

@BrianWendt With the release of the update, this should be correct, please check.

@BrianWendt With the release of the update, this should be correct, please check.

For me not work. Same problem and using @BrianWendt suggestion...


Hotfix/api umbrella methods sync

Fixes

Api backends sync from ApiUmbrella

@apinf/developers Please review & test

@frenchbread Overall code and solution looked good. Settings file usage won't be anymore supported I suppose?

Yes. But basically, as I recall correctly there were some feature that transfers settings data from setting file to collection.

@frenchbread yes. We should probably still allow settings to be provided by settings.json, so in startup we could write the Meteor.settings object to the Settings collection. Everywhere else in the app, though, we should be getting settings from the Settings collection.

Not syncing, should I wait 5 mins, or still bug?

Generally:
On startup with fresh database I guess we don't have Settings collection, only possible is settings file that could have been passed.

Decided together to leave settings file case outside of this.

Added some more refactoring & checks

Tested again after meteor reset, sync runs now without errors.

Added one more close to the description. Merging and closing.
If one minute syncing interval causes issues for example in production when there might be more latency let's make it longer.
Great co-working guys @frenchbread @brylie

@jykae @brylie 👍


Fix failing test case

This test case started failing because two PRs raced.

@swift-ci Please test


Container still running after HealthCheck failure

Attempting to start a new container:
container = await new GenericContainer(DOCKER_IMAGE)
    .withWaitStrategy(Wait.forHealthCheck())
    .start();

If health check fails, the container is still running in the background and the object returned is 'undefined'.
This means I can't use container.stop() to actually stop the container.
Is there any way to stop it completely?

Hi @royprigat, thanks for raising the issue, I've created a PR for this, let me know if you want to take a look else I'll release it

Released in 4.2.0


GCE default cloud network not discovered

For Google Cloud Engine, each new project starts with a default network. The default network is an auto mode VPC network with pre-populated firewall rules.
There is a default VPC network on GCE:

But manageiq could not find it:

As a result, you will not be able to provision instance:

Because "'Environment/Cloud Network' is required"

@bsogithub were there any errors in the logs related to the Google NetworkManager refresh?  It looks like there are 0 Security Groups and Cloud Networks which both come from the NetworkManager.

Using podified, I was able to reproduce this problem as well......compute-related storage is working fine with these credentials, as instances, flavors, images, av zones, volumes are populated.  No network data is coming in:
I see a few errors in google-network-refresh pod (see similar messages in ManageIQ Network Manage summary page):

{"@timestamp":"2020-05-11T18:05:47.087500 ","hostname":"1-google-network-refresh-6-78fc57486-skglq","pid":7,"tid":"2b09b03e797c","level":"debug","message":"Error - #\u003cGoogle::Apis::ClientError: notFound: The resource 'projects/oceanic-guard-191815/zones/us-central1-b/instances/ja15gc-hv6kc-w-b-bw5fb' was not found\u003e\n"}```

I suspect this is due to lack of permissions, here is the relevant part of the stack trace:
"/usr/share/gems/gems/google-api-client-0.23.9/lib/google/apis/core/http_command.rb:93:in `execute'\n" +
"/usr/share/gems/gems/google-api-client-0.23.9/lib/google/apis/core/base_service.rb:360:in `execute_or_queue_command'\n" +
"/usr/share/gems/gems/google-api-client-0.23.9/generated/google/apis/compute_v1/service.rb:17808:in `get_target_pool_health'\n" +
"/usr/share/gems/gems/fog-google-1.9.1/lib/fog/compute/google/requests/get_target_pool_health.rb:12:in `get_target_pool_health'\n" +
"/usr/share/gems/gems/fog-google-1.9.1/lib/fog/compute/google/models/target_pool.rb:121:in `block in get_health'\n" +
"/usr/share/gems/gems/fog-google-1.9.1/lib/fog/compute/google/models/target_pool.rb:118:in `map'\n" +
"/usr/share/gems/gems/fog-google-1.9.1/lib/fog/compute/google/models/target_pool.rb:118:in `get_health'\n" +
"/usr/share/gems/bundler/gems/manageiq-providers-google-91a0dfa0970c/app/models/manageiq/providers/google/inventory/parser/network_manager.rb:328:in `load_balancer_health_check_members'\n" +
"/usr/share/gems/bundler/gems/manageiq-providers-google-91a0dfa0970c/app/models/manageiq/providers/google/inventory/parser/network_manager.rb:42:in `block (3 levels) in parse'\n" +
"/usr/share/gems/bundler/gems/manageiq-providers-google-91a0dfa0970c/app/models/manageiq/providers/google/inventory/parser/network_manager.rb:315:in `block in load_balancer_health_check'\n"

Where this is the last MIQ code that it goes through: https://github.com/ManageIQ/manageiq-providers-google/blob/91a0dfa0970c/app/models/manageiq/providers/google/inventory/parser/network_manager.rb#L328 so we're calling target_pool.get_health and it is failing inside the Google SDK.
We could catch this error and skip this load balancer instead of failing the whole refresh.
I checked the CloudManager and confirmed that instance isn't present in the list of collected instances so we don't have perms to collect it or it is "stuck" in the load balancer somehow on the GCE side.


make allowUndefinedInResolve true by default

Fixes #95
cc @helfer
TODO:

[x] Update CHANGELOG.md with your change (include reference to issue & this PR)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass

🎉 Thanks! 🎉


Minor issue: dump_xml_node() adds "xmlns:html" to the output

<SPEC-HIERARCHY xmlns:xhtml="http://www.w3.org/1999/xhtml" IDENTIFIER="_B92p0WunEeuNUYnTveUm8Q" LAST-CHANGE="2021-02-11T10:31:27.215+01:00">

It should be possible to deactivate this default behavior of lxml.

I encountered a similar issue while printing namespaced XHTML tags. The solution there was to write a custom printer of lxml nodes. That solution might prove itself to be fragile over time but it seems to work on some basic examples I could think of.
https://github.com/strictdoc-project/reqif/commit/17fea1fe15bdbf58ef69dbdfd10bf69ca2d3a5ef#diff-565e66fde2555a7053b16000c018da49ea3fab17d2a7e3517b8c62ee829bde28R11
After some time, it might be worth switching the dump_xml_node() to use that custom printer as well.


[META] Add linkchecker to docs CI

Is your feature request related to a problem? Please describe.
Adding issues for each broken link isn't a valuable use of time
Describe the solution you'd like
We should block merges to docs repo if there are broken links using a CI process.

Fixed in https://github.com/nearprotocol/docs/pull/188


Configuration by environment does not use the hostname but the url (docs are unclear here)

Configuration by environment says that a configuration by environment:

can be easily accomplished by providing an override of that setting in the file:
user/localhost/config/system.yaml
where localhost is the hostname of the environment (this is what the host you enter in your browser, e.g. http://localhost/your-site)

however this is problematic.
Example: I am using apache with virtualhosts and my server test.box.int on the host box. Thus, gethostname() returns box, but if I create an environment config in user/box/config/ it is not picked up by grav. So at least the term hostname is wrong here.
Secondly, I would argue in favor of really using the hostname as it is returned by gethostname(), not the URL/domain (see Edit 2) :

the domain is (in most cases, e.g. shared hosting) not the hostname.
there might be multiple domains defined for one grav instance box.org and box.com.
the name of the virtual server test.box.int might not be the hostname box nor what i type in the address bar (mynewsupergravsite without a TLD but defined in /etc/hosts).

Edit: however, this would require different servers/hostnames for staging, production, preprod aso. which might not be flexible enough.
Edit 2: so, the best idea is to use whichever is available from these:

subdomain.example.tld
example.tld
example
and perhaps edit the documentation to reflect this.

And if some of these environments share a config, I would symlink them, which is an important detail that one should not forget, because it might lead to (security) issues. E.g. if my production grav config is under example.com and my hoster provides a URL example.uber.space, then the config should apply to both environments (and it might be the case that the default configuration is not the production configuration, right?!). (Sorry for the lengthy text).

Yes, it is the URL, and this is not something we can change because it's been that way since the beginning.  If we were to change the behavior at this point, it would totally break configuration and options that have been set based on this premise.

I am going to move this issue to grav-learn then and close it here as wontfix.


Create a pull request template

Create a template for pull requests that will be created in this repo

Hi, I'd like to take this issue. Are there any guidelines for what you would like to see in the template? Thank you.

Hi @dylan-power 😄 , thanks for your interest in this issue. There is no specific guidelines that we have decided on for the template so you are free to show your creativity. Overall the template should contain at least the following

Description of the pull request
Issue that is resolved by it
Screenshots if applicable

Feel free to add any additional features to the template 😊
You can also work on an issue template (#15) after this if you wish to


[FEATURE REQUEST] Add capability for separate Update, LateUpdate, and FixedUpdate systems on same Systems

Is your feature request related to a problem? Please describe.
As of right now, an IExecuteSystem and Systems offer a single Execute method. In the past, this has meant creating multiple contexts for executing at different update intervals such as Update, FixedUpdate, and LateUpdate. It might make more sense for Systems to instead have the ability for a user to also add a system as an Update, FixedUpdate, and/or LateUpdate system so that a user can execute a single context's systems at all three update intervals. In this way a user would be able to still separate contexts for update intervals using Execute if they chose to do so, or not use separate update intervals at all, but others could execute systems on the same entities on the appropriate interval.
Describe the solution you'd like
There is a bit of investigation to do here as far as an approach. It might make sense to add new interfaces for:

IUpdateSystem
ILateUpdateSystem
IFixedUpdateSystem

as well as add new API functionality for Systems for adding these systems, which would then be categorized correctly. Visual Debugging would also need to be updated to account for new categories of systems.

Released in v1.1.0


Use catch_unwind() to catch actor panics

We could unconditionally convert actor panics into actor system shutdown, or perhaps allow users to supply a callback that decides the fate.

I think catch_unwind is the recommended way to handle subsystem panics, whether that's request handling in web servers or actors in an actor system.
One potential issue is that the subsystem's result type needs to be UnwindSafe, which is similar to Send / Sync thread safety. For portal this means that the Actor::Error type needs to be UnwindSafe and it seems all actors use anyhow::Error, which is indeed UnwindSafe 😌
I don't think it's optimal to make errors/panics trigger system shutdown (as opposed to just actor restart) but it seems reasonable to treat errors and panics the same for the time being.


[Bug]: Shopify CLI version is not updating

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Other
Expected behavior
I try to update the Shopify CLI version to latest one by running the command
npm install -g @shopify/cli@latest
After that I run the command
shopify version
It gives me 2.36
Actual behavior
However, It should be updated to version 3.50.0. I have updated the npm, node, and each and everything but still facing the same issue.
Verbose output
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/--verbose - Not found
npm error 404
npm error 404  '--verbose@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
npm error A complete log of this run can be found in: C:\Users\jawad\AppData\Local\npm-cache\_logs\2024-07-30T08_45_51_276Z-debug-0.log

Reproduction steps

Run the command to npm install -g @shopify/cli@latest
Check for the version

Operating System
window 10
Shopify CLI version (check your project's package.json if you're not sure)
2.36
Shell
cmd
Node version (run node -v if you're not sure)
20.16
What language and version are you using in your application?
ruby 3.2.5

It seems you have a conflict with an old installation of the CLI 2.x. You should be able uninstall it with gem uninstall shopify-cli.
More info: https://shopify.dev/docs/storefronts/themes/tools/cli/migrate#step-2-uninstall-shopify-cli-2-x


🐞 Lockstep is not working as it should in the new version of the simulation.

How to reproduce the bug:

Run the simulation
spawn drone
pause the gazebo
the drone complains and goes into the failsafe.

Correct behavior:

PX4 firmware knows that the physics has been paused due to Lockstep https://docs.px4.io/main/en/simulation/#lockstep-simulation

Solved! The lockstep is working correctly. Timeouts for disconnection of communication were triggered during the simulation pause. Solved by https://github.com/ctu-mrs/mrs_simulation/commit/52501737fa644f19687cae30d1ddd2153c485b84 and  https://github.com/ctu-mrs/mrs_simulation/commit/9433ca54865011b10d02af34f292553604f3257a


Incompatible with numpy 2.0.0rc1

Numpy 2 is around the corner with having its first release candidate: https://pypi.org/project/numpy/2.0.0rc1
emcee at least uses VisibleDeprecationWarning from numpy that will be removed with numpy 2: https://numpy.org/devdocs/release/2.0.0-notes.html

Warnings and exceptions present in numpy.exceptions (e.g, ComplexWarning, VisibleDeprecationWarning) are no longer exposed in the main namespace.

So with the release of numpy 2, emcee will run into some troubles.

But even doing from numpy.exceptions import VisibleDeprecationWarning and replacing np.VisibleDeprecationWarning with VisibleDeprecationWarning in ensemble.py, I run into the following error:
File ~/AtWork/Cloud/GIT/GitHub/GeoStat/GSTools/src/gstools/random/rng.py:92, in RNG.sample_ln_pdf(self, ln_pdf, size, sample_around, nwalkers, burn_in, oversampling_factor)
     90 initial_state = State(init_guess, copy=True)
     91 initial_state.random_state = self.random.get_state()
---> 92 burn_in_state = sampler.run_mcmc(
     93     initial_state=initial_state, nsteps=burn_in
     94 )
     95 # reset after burn_in
     96 sampler.reset()

File ~/mambaforge/envs/gstools_np2/lib/python3.12/site-packages/emcee/ensemble.py:444, in EnsembleSampler.run_mcmc(self, initial_state, nsteps, **kwargs)
    441     initial_state = self._previous_state
    443 results = None
--> 444 for results in self.sample(initial_state, iterations=nsteps, **kwargs):
    445     pass
    447 # Store so that the ``initial_state=None`` case will work

File ~/mambaforge/envs/gstools_np2/lib/python3.12/site-packages/emcee/ensemble.py:411, in EnsembleSampler.sample(self, initial_state, log_prob0, rstate0, blobs0, iterations, tune, skip_initial_state_check, thin_by, thin, store, progress, progress_kwargs)
    409 # Save the new step
    410 if store and (i + 1) % checkpoint_step == 0:
--> 411     self.backend.save_step(state, accepted)
    413 pbar.update(1)
    414 i += 1

File ~/mambaforge/envs/gstools_np2/lib/python3.12/site-packages/emcee/backends/backend.py:228, in Backend.save_step(self, state, accepted)
    226 self.log_prob[self.iteration, :] = state.log_prob
    227 if state.blobs is not None:
--> 228     self.blobs[self.iteration, :] = state.blobs
    229 self.accepted += accepted
    230 self.random_state = state.random_state

ValueError: could not broadcast input array from shape (50,0) into shape (50,)

So there is more to it...

Thanks for bringing this up! I've been meaning to look into this, but I'm not 100% sure how much capacity I'll have. If you or anyone else wants to start looking into this and opening up a PR that would be very much appreciated!!


Api changes

Squashed merge message
API changes.
New initialize_enclave, simplified individualized inits, simplified server_dispatch and init_client/server_ssl.
cc_trust_data is now cc_trust_manager.

@jlmucb - Somehow my code-level comment seems to have been lost.
I think your interface changes are not reflected in pytests / SWIG code. This is why your CI-job is now bombing completely early-on for pytests.
Re-jiggering pytests & SWIG to keep up with interfaces is a continual effort.
I suggest here's what you should do:

Delete this whole test code block named name: test-cert_framework-pytests from build.yml.
Check that into your dev branch, which will trigger CI. You'll get to see how the rest of the tests perform.
Let's try to get the rest of the review and your changes finalized thru review this week.

Later this week, I will find time to rework SWIG interfaces & pytests code to be in-sync with your newer interfaces. I will provide a delta-commit on your dev-branch just to re-engage and re-stabilize pytests.
Hope this works for you & @yelvmw


percentile() got an unexpected keyword argument 'interpolation'

Hi,
this my very first try working with my raspberry pi updated with all packages.
I get this when starting the script
Started WebServer, lendingbot status available at http://localhost:8000/lendingbot.html
2017-01-13 19:25:26 Error: percentile() got an unexpected keyword argument 'interpolation'
Traceback (most recent call last):
  File "lendingbot.py", line 69, in <module>
    Lending.lend_all()
  File "/home/pi/poloniexlendingbot/modules/Lending.py", line 141, in lend_all
    usable_currencies += lend_cur(cur, total_lended, lending_balances)
  File "/home/pi/poloniexlendingbot/modules/Lending.py", line 163, in lend_cur
    recommended_min = Analysis.get_rate_suggestion(active_cur)
  File "/home/pi/poloniexlendingbot/modules/MarketAnalysis.py", line 118, in get_rate_suggestion
    result = numpy.percentile(rates, int(percentile), interpolation='linear')
TypeError: percentile() got an unexpected keyword argument 'interpolation'

Unhandled error, please open a Github issue so we can fix it!
2017-01-13 19:35:28 Error: percentile() got an unexpected keyword argument 'interpolation'
Traceback (most recent call last):
  File "lendingbot.py", line 69, in <module>
    Lending.lend_all()
  File "/home/pi/poloniexlendingbot/modules/Lending.py", line 141, in lend_all
    usable_currencies += lend_cur(cur, total_lended, lending_balances)
  File "/home/pi/poloniexlendingbot/modules/Lending.py", line 163, in lend_cur
    recommended_min = Analysis.get_rate_suggestion(active_cur)
  File "/home/pi/poloniexlendingbot/modules/MarketAnalysis.py", line 118, in get_rate_suggestion
    result = numpy.percentile(rates, int(percentile), interpolation='linear')
TypeError: percentile() got an unexpected keyword argument 'interpolation'

Unhandled error, please open a Github issue so we can fix it!

Regards
chris

Hello ChrisG2711,
Raspbian repository have old version of python-numpy.
You have 3 options:

Remove the package and install the newer version via pip
Just remove the package and rely on "manual percentile method". Bot will complain but will work.
Comment out all Market Analysis lines in your config and it will work without it

Regards,
Dimitar

Hello Dimitar,
thank you very much for the solution!
Raspberry did not let me remove the package but "sudo pip install numpy --upgrade" seems to have done the trick. Running into a new error now unfortunately asking for reporting, will open a new issue for that.
Thanks again and have a great weekend!
Regards
Chris

hello, what version of numpy is required ? I am running on cent os 7 and numpy-1.7.1

@mikemr Hey mike, what output do you get when you run sudo pip install numpy --upgrade?

pip is not found on the vps I am using. I installed using - sudo yum install numpy

sudo yum upgrade numpy
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile

base: mirror.cisp.com
epel: mirror.steadfast.net
extras: mirrors.gigenet.com
updates: mirror.eboundhost.com
No packages marked for update

@mikemr  I believe a working alternative is sudo apt-get install python-numpy if you have access to that


Issue with k8s.io/docs/tasks/access-application-cluster/web-ui-dashboard/

This is a Bug Report

Problem:

Run command and Run command arguments: By default, your containers run the specified Docker image’s default entrypoint command. You can use the command options and arguments to override the default.

The entrypoint command link navigates to https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#containers-and-commands .
However, there is no ID #containers-and-commands.
Proposed Solution:
It would probably be fine to replace the link /docs/user-guide/containers/#containers-and-commands with /docs/tasks/inject-data-application/define-command-argument-container/.
Page to Update:
https://kubernetes.io/docs/tasks/access-application-cluster/web-ui-dashboard/

/assign @divyabhushan

/close


Client crashing Badargs error

I used this command to benchmark..
./emqtt_bench_sub -h "MY_BROKER.COM" -p 1885 -u temp_test_user123 -P temp_passw0rd -c 200 -t "test/topic"
On executing this i am getting this error -
=ERROR REPORT==== 28-Jun-2018::10:38:01.756401 ===
** State machine <0.474.0> terminating
** Last event in was timeout
** When State == connecting
**      Data  == {state,<0.473.0>,"<0.473.0>","MY_BROKER.COM",1885,undefined,
                     undefined,
                     {proto_state,undefined,undefined,4,<<"MQTT">>,
                         <<"Arihants-MacBook-Pro_bench_sub_1_176419070">>,
                         true,300,false,
                         {mqtt_message,0,false,false,undefined,undefined,
                             undefined},
                         <<"temp_test_user123">>,<<"temp_passw0rd">>,1,#{},
                         #{},#{},#{},
                         {gen_logger,console_logger,8}},
                     [],#{},[],[],#{},undefined,false,false,undefined,300,60,
                     4,8,undefined,tcp,undefined,
                     {gen_logger,console_logger,8},
                     [],[]}
** Reason for termination =
** {badarg,[{erlang,apply,[{gen_logger,console_logger,8},info,[]],[]},
            {emqttc,connect,1,[{file,"src/emqttc.erl"},{line,956}]},
            {gen_fsm,handle_msg,8,[{file,"gen_fsm.erl"},{line,486}]},
            {proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,249}]}]}

client 1 EXIT: {badarg,[{erlang,apply,
                                [{gen_logger,console_logger,8},info,[]],
                                []},
                        {emqttc,connect,1,
                                [{file,"src/emqttc.erl"},{line,956}]},
                        {gen_fsm,handle_msg,8,
                                 [{file,"gen_fsm.erl"},{line,486}]},
                        {proc_lib,init_p_do_apply,3,
                                  [{file,"proc_lib.erl"},{line,249}]}]}
=CRASH REPORT==== 28-Jun-2018::10:38:01.757457 ===
  crasher:
    initial call: emqttc:init/1
    pid: <0.474.0>
    registered_name: []
    exception exit: {badarg,
                        [{erlang,apply,
                             [{gen_logger,console_logger,8},info,[]],
                             []},
                         {emqttc,connect,1,
                             [{file,"src/emqttc.erl"},{line,956}]},
                         {gen_fsm,handle_msg,8,
                             [{file,"gen_fsm.erl"},{line,486}]},
                         {proc_lib,init_p_do_apply,3,
                             [{file,"proc_lib.erl"},{line,249}]}]}
      in function  gen_fsm:terminate/7 (gen_fsm.erl, line 609)
    ancestors: [<0.473.0>]
    message_queue_len: 1
    messages: [{'$gen_event',{subscribe,<0.473.0>,[{<<"test/topic">>,0}]}}]
    links: [<0.473.0>]
    dictionary: [{random_seed,{120,22138,27515}}]
    trap_exit: true
    status: running
    heap_size: 6772
    stack_size: 27
    reductions: 43471
  neighbours:

Can anyone suggest what's wrong here...

Can you give more details about the environment your emqttd and emqtt_benchmark runs? I ran your command on my machine and it shows nothing error.

Mac OS High Siera
Erlang/OTP 21 [erts-10.0.1]
Emq Bench mark tool latest from git

Oops!  emqttd and emq_benchmark doesn't support  Erlang/OTP 21 [erts-10.0.1] now . And I recommend you to downgrade you Erlang/OTP by using commands as follows:
brew install erlang@20
brew unlink erlang
brew link --force erlang@20

Our project would adapt to the latest Erlang/OTP version in the next few months.


Update README for release 0.7.1

What is the problem that this fixes or functionality that this introduces? Does it fix any open issues?
No it does not fix any issues.
Updated the README getting started.
Update pyproject to 0.7.1
Give a brief summary of what the PR does, explaining any non-trivial design decisions
Other references

Oh you might have to run "poetry lock --no-update" and include that too @mamoodi


About easymotion-sn: 3 problems

First, a lot of thanks to this awesome extension and @asvetliakov 's great job.
I've set up neovim in VSCode and try to use easymotion.
set number relativenumber
set autoindent

let mapleader=";"

function! Cond(Cond, ...)
  let opts = get(a:000, 0, {})
  return a:Cond ? opts : extend(opts, { 'on': [], 'for': [] })
endfunction

call plug#begin('D:/ProgramFiles/Neovim/plugged')
" inside；plug#begin:
Plug 'easymotion/vim-easymotion', Cond(!exists('g:vscode'))
Plug 'asvetliakov/vim-easymotion', Cond(exists('g:vscode'), { 'as': 'vsc-easymotion' })
call plug#end()

let g:EasyMotion_smartcase = 1

map <Leader> <Plug>(easymotion-prefix)
nmap <Leader>z <Plug>(easymotion-jumptoanywhere)
nmap <Leader>x <Plug>(easymotion-s2)
nmap <Leader>f <Plug>(easymotion-sn)

I've set my init.vim as above.
There are 3 problems
Problem
https://user-images.githubusercontent.com/49837632/179131581-6e5663fc-ff24-4101-9180-fe324ab64d43.mp4

When I'm using nmap <Leader>f <Plug>(easymotion-sn), the panel always pops up
The cursor jumps to the start of the next line, instead of where the indicator is.
The highlights of ta remains after jumping.

😄 thanks for your help!

https://github.com/vscode-neovim/vscode-neovim/issues/910
If you have other issues, switch to hop or lightspeed.

@ZXYFrank I have the same problem. Instead of using easymotion, you may consider using hop and hop's :HopPattern Function.


make development possible on different os/arch

The PR does the following:

Allow images to be built using both podman and docker
Update OPM version to 1.20.0
Run go-test as a sub-target instead of Docker step
Remove depricated linters and remove :Z (Ref: https://access.redhat.com/solutions/6985126)
Add --platform flag to target a specific arch/os
Move from sqlite based to file based catalog source
update setup-env test to the latest version

/restest

@rewantsoni re-running catalog-build job is still failing, could you ptal?

In the PRs where that Job is passing I see docker was being used
2024-04-02T07:56:03.0311035Z docker push localhost:5000/ocs-dev/ocs-client-operator-bundle:latest
2024-04-02T07:56:03.0556101Z The push refers to repository [localhost:5000/ocs-dev/ocs-client-operator-bundle]
2024-04-02T07:56:03.0600541Z 2a633eeac220: Preparing
2024-04-02T07:56:03.0601790Z 902922e1dcae: Preparing
2024-04-02T07:56:03.0602293Z e444f57ccc15: Preparing
2024-04-02T07:56:03.0800517Z 902922e1dcae: Pushed
2024-04-02T07:56:03.0805677Z 2a633eeac220: Pushed
2024-04-02T07:56:03.0834704Z e444f57ccc15: Pushed
2024-04-02T07:56:03.1006832Z latest: digest: sha256:a57a598dd6134d6330ca0194ec1d6b0d1a5c04249bd7c99cc2e9e266eb90fac3 size: 939

current PR
2024-04-03T03:13:29.0510314Z /usr/bin/podman push localhost:5000/ocs-dev/ocs-client-operator-bundle:latest
2024-04-03T03:13:29.1367136Z Getting image source signatures
2024-04-03T03:13:29.1756168Z Error: trying to reuse blob sha256:9d5b3afa09e709e7bc6053a8e4ac7135f607f34bb2ef0586afdfcbb149da06c6 at destination: pinging container registry localhost:5000: Get "https://localhost:5000/v2/": http: server gave HTTP response to HTTPS client
2024-04-03T03:13:29.1776377Z make: *** [Makefile:141: bundle-push] Error 125
2024-04-03T03:13:29.1795569Z ##[error]Process completed with exit code 2.


Stylex with webpack ssr

I use webpack ssr to render react. That mean I have to file webpack.server.dev.js and webpack.client.dev.js
Should I add stylex config to webpack.server.dev.js ? This is my webpack.server.dev.js file :
const nodeExternals = require("webpack-node-externals");
const webpack = require("webpack");
const { paths } = require("../scripts/utils");
const MiniCssExtractPlugin = require("mini-css-extract-plugin");
const LoadablePlugin = require("@loadable/webpack-plugin");

module.exports = {
  mode: "development",
  target: "node",
  entry: {
    server: [paths.srcServer],
  },
  output: {
    path: paths.serverBuild,
    filename: "index.js",
    publicPath: paths.publicPath,
    libraryTarget: "commonjs2",
  },
  resolve: {
    modules: [paths.src, "node_modules"],
    extensions: [".js", ".jsx", ".ts", ".tsx"],
  },
  module: require("./loaders.server.js"),
  plugins: [
    new LoadablePlugin(),
    new MiniCssExtractPlugin(),
    new webpack.DefinePlugin({
      "process.env.BROWSER": "false",
      "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
      "process.env.BACKEND_BASE_URL": JSON.stringify(
        process.env.BACKEND_BASE_URL
      ),
      "process.env.ASSETS_URL": JSON.stringify(process.env.ASSETS_URL),
    }),
  ],
  externals: [nodeExternals()],
  stats: "minimal",
};

Yes. You should add the stylex webpack plugin to the server webpack config as well.
stylex.create is a dummy function that should be transformed into the static classNames during the compilation, which then can be consumed by React DOM during the server-side rendering.

@SukkaW  both webpack.client and webpack.server right

@SukkaW both webpack.client and webpack.server right

Right. You need to enable stylex plugin for both of them because React DOM on both client and server can only consume static classNames.


Please check if CHEBI:79216 and CHEBI:141753 represent the same entity

Please check if CHEBI:79216 and CHEBI:141753 represent the same entity and if they do, please merge them trying to keep CHEBI:141753 as primary if possible.
Thanks

Now merged. Since CHEBI:79216 had a 3-star status, it was automatically selected as the primary identifier. The entry now contains 2 UniProt names, can you please delete one of them. Thanks


Documentation link does not open in a new tab on cluster's edit page

Describe the bug

Having an extra target attribute prevents the documentation link to open in a new tab on cluster's edit page.
To Reproduce

Go to any cluster's edit config page and click on the link provided inside the warning banner.

Tests pass, but the current link the user is being redirected to is https://ranchermanager.docs.rancher.com/v2.7/how-to-guides/new-user-guides/launch-kubernetes-with-rancher/rke1-vs-rke2-differences. I believe this link would be more suitable for the context of managing existing cluster configuration: https://ranchermanager.docs.rancher.com/v2.7/how-to-guides/new-user-guides/launch-kubernetes-with-rancher/use-new-nodes-in-an-infra-provider

@richard-cox @gaktive any thoughts on the link change? Wdyt?

The link should probably go to the fragment within the page which details when nodes are re-provisioned /how-to-guides/new-user-guides/launch-kubernetes-with-rancher/rke1-vs-rke2-differences#cluster-api

Tests pass in v2.9-0e88e978bdc9639a272422c8d611a9a7ba476761-head


WIP: Expose SslContextFactory

[clabot:check]

@confluentinc It looks like @jonchiu just signed our Contributor License Agreement. :+1:
Always at your service,
clabot


Adding support for initializing arrays with a list

As per issue #70 we have implemented array literal initialization. It supports int, double, float, etc. as well as strings.
Some interim tests and removal of sourcemap deletion (for debugging) are also present.

@dcodeIO This should be ready to go. Let me know if that's not the case!

I took some time to manually merge your progress into https://github.com/dcodeIO/AssemblyScript/tree/arrayliteral and simplified a couple of things, but unfortunately, it seems that I am not proficient enough at git to retain your authorship :/ (pulled the changes from your branch)
The fixture test passes, but I believe there's still an issue when initializing arrays within arrays because the inner block uses the same .arrptr local.

Now merged, thanks!


[ICT/Durham County Council:school names and addresses]

Please fill in the following information:
Base URL:
https://www.gov.uk/api/schooldetails.
Documentation URL:
The URL for the API documentation. For example https://content-api.publishing.service.gov.uk/durhamschools
Description:
We would like to link to details held on .gov website that display each school name and address within Durham County as referenced here - https://get-information-schools.service.gov.uk/Establishments/Search?SelectedTab=Establishments&SearchType=ByLocalAuthority&SearchType=ByLocalAuthority&LocalAuthorityToAdd=&d=95&OpenOnly=true&b=1&b=4
Can someone look into provision of an API please that would allow us to access this information rather than exporting to a spreadsheet.

I don't think this repository is for requests for new APIs, it only documents those that already exist unfortunately.
It might be worth trying to get in touch with the service team on the x-gov Slack.

I believe @BriDough got in touch with people at the DfE re this (feel free to email me at<EMAIL_ADDRESS>if not!); closing this issue as it's not directly relevant to the API Catalogue.


chore(dev): add es5 trailing comma

:tada: This PR is included in version 1.25.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Misc feedback on the UI flow

Addressing the following concerns brought up in a previous PR

use querySelector in place of addEventListener in the main script for the popup
handle NPE cases for the same script mentioned in 1
remove awkward if/else in the success page script, call window.close() to exit early
nit: address the spacing in the test classes
prefer any over interface{} in the RenderHTMLStatus method
change the Server struct to have a Controller then give the Controller struct the allowlist to avoid passing it as a param

LGTM, but I cant approve as Im not a writer.