use ng2-ckeditor

Please do not mark this question as replecated because none of the available solution on stackoverflow has resolve my problem, I am trying to integrate ng2-ckeditor ckeditor to an existing angular 4 project. I try to follow the steps described.
I procceed as follow
referenced the follwoing js files in my index file
1
2
import module in my app.module.ts
import{CKEditorModule} from "ng2-ckeditor";
.
.
.;
imports: [
BrowserModule,
AppRoutingModule,
.
.
.,
CKEditorModule,
],
But when I try to use the ckeditor code in my app
<ckeditor [(ngModel)]="description" >
it was marked as unkown element and I get The following text hint
[Angular]
'ckeditor' is not a known element:

If 'ckeditor' is an Angular component, then verify that it is part of this module.
To allow any element add 'NO_ERRORS_SCHEMA' to the<EMAIL_ADDRESS>of this component.
when I run ng serve command, the compilation succeeded but nothing is shown and I get the following Console error

Uncaught Error: Template parse errors:
'ckeditor' is not a known element:

If 'ckeditor' is an Angular component, then verify that it is part of this module.
To allow any element add 'NO_ERRORS_SCHEMA' to the<EMAIL_ADDRESS>of this component. ("N' | translate:lang }}
<div formControlName="description" [froalaEditor] >
[ERROR ->]

any help would be appreciated

Import FormsModule into app.module.ts class:
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import {FormsModule} from '@angular/forms';

import { AppComponent } from './app.component';
import {CKEditorModule} from 'ng2-ckeditor';

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    CKEditorModule,
    FormsModule
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

It should solve your problem.

I also have this issue.
FormsModule is imported into app.module.ts

The same issue , in other component it work properly but not in the component that i ' m using now


Add ability to 'flood publish' only own attestations

Description
The Gossip 1.1 has 'flood publish' option which may improve dissemination of own validator blocks and attestations.
The problem is that 'flood publish' is enabled globally and inbound attestations are also propagated via the same publish mechanism as own messages. Propagating inbound attestations via 'flood publish' can unnecessarily result in excessive network load if enabled on all clients.
There is currently no way to publish a separate Gossip message with either 'flood publish' or without it

Seems like I messed things:
Nashatyrev:

Hey channel!
Gossip 1.1 has flood publish option which is handy to push own validator attestations and blocks for better propagation time.
However inbound attestations are not propagated via regular Gossip mechanism but aggregated and also published as outbound. The flood publish option though can only be enabled globally and there is no ways to publish some messages with 'flood' option and some messages without 'flood' option
Curious if anyone already hit this limitation and rise any issue/discussion for Libp2p?

djrtwo:

However inbound attestations are not propagated via regular Gossip mechanism but aggregated and also published as outbound.

I'm not sure I understand here
non-aggregated attestations are gossiped in their non-aggregated form through the attestation subnets
aggregated attestations are then published (and gossiped) on a separate aggregate channel
I think the "flood publish" should be fine for both of these

Nashatyrev:

Oh, right. Seems like I've lost the track on this topic at some point

djrtwo:

all good!
I was just looking at the flood publish option the other day. I think in general that we should use it across the board on our topics

Nashatyrev:

Yes, we were discussing this option in Teku team. For some reason I thought that non-aggregated attestations are not propagated immediately by peers (right after validation) and the 'flood publish' option needs to be adjusted. But it looks now like good thing to go.


GDShader compiler crash when a void function returns a "void" value (void function call)

Tested versions

Reproducible in v4.3.stable.flathub [77dcf97d8]

System information
Godot v4.3.stable (77dcf97d8) - Freedesktop SDK 23.08 (Flatpak runtime) - X11 - Vulkan (Forward+) - integrated Intel(R) HD Graphics 5500 (BDW GT2) - Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz (4 Threads)
Issue description
The editor is allowing a void function to have "void" return values (like calling a function returning void), but this seems to not be allowed in GLSL, causing a long editor freeze followed by lots of error output with GLSL code.
Steps to reproduce
No errors are raised by the code editor in Godot:
void-return-bug.gdshader
shader_type spatial;
void g() {}
void f() {
	return g();
}
void fragment() {
	f();
}

The relevant part of the compiled GLSL code:
void m_g()
	{
	}

void m_f()
	{
return m_g();	} // ERROR here

ERROR: 0:672: 'return' : void function cannot return a value
ERROR: 0:672: '' : compilation terminated
ERROR: 2 compilation errors.  No code generated.

Minimal reproduction project (MRP)
N/A

Assuming this is something that isn't supported in GLSL this should probably be fixed by forbidding it in GDShaders as well


Ability to use a custom layout for the admin pages

Can we please add a config.admin_layout property, so we can change which layout is used to render the admin section?
Currently it is hard coded to comfy/admin/cms
I have a different layout which I want to use.
My workaround is currently to monkey patch in config/initializers/comfortable_mexican_sofa.rb, which is a bit of a pain:
require_dependency ComfortableMexicanSofa::Engine.root.join('app', 'controllers', 'comfy', 'admin', 'cms', 'base_controller').to_s

class Comfy::Admin::Cms::BaseController < ComfortableMexicanSofa.config.base_controller.to_s.constantize
  layout 'my_admin_layout'
end

If you really want to override CMS admin layout, what you're doing is the way to go. Just pointing it to some template won't work. Need to re-link js and partials anyways.
Didn't try it, but this might be cleaner?
Comfy::Admin::Cms::BaseController.class_eval do
  layout 'my_admin_layout'
end


Adding input validations

Hello I can add proper input validation for the login and register pages
Pls assign this to me

@Gauravtb2253  currently we are facing some problem in our auth apis ,we are working it.After it get fixed we  take issues related to it.


Incorrect kernel version detected in container

Linux kernel running on the host may differ from the version installed inside of container.
In that case the detection of the "recent" version fails for container having several kernels installed:
# dpkg -l | grep linux-image
ii  linux-image-4.19.0-1-amd64           4.19.12-1                                amd64        Linux 4.19 for 64-bit PCs (signed)
rc  linux-image-4.9.0-3-amd64            4.9.30-2+deb9u5                          amd64        Linux 4.9 for 64-bit PCs
rc  linux-image-4.9.0-4-amd64            4.9.65-3+deb9u1                          amd64        Linux 4.9 for 64-bit PCs
rc  linux-image-4.9.0-5-amd64            4.9.65-3+deb9u2                          amd64        Linux 4.9 for 64-bit PCs
rc  linux-image-4.9.0-6-amd64            4.9.88-1+deb9u1                          amd64        Linux 4.9 for 64-bit PCs
rc  linux-image-4.9.0-7-amd64            4.9.110-3+deb9u2                         amd64        Linux 4.9 for 64-bit PCs
ii  linux-image-4.9.0-8-amd64            4.9.130-2                                amd64        Linux 4.9 for 64-bit PCs
ii  linux-image-amd64                    4.19+101                                 amd64        Linux for 64-bit PCs (meta-package)

In example above 4.9.0-8-amd64 was used for starting qemu.
Moreover, after de-installation of unneeded images some artifacts left and the appropriate directories under /lib/modules weren't wiped out completely. So it is leading to non-working configuration since "detected" kernel version is not exists.

Since this issue the kernel&module detection has improved hugely; if still a problem please re-open.


Update README with multi-line value improvements

@cadwallion I failed to include some notes about the #318 changes in the README

Oh excellent, I was going to incorporate that into some documentation changes today and you beat me to it.  Thank you!


Duplicate test?

I think that this test https://github.com/bullet-train-co/bullet_train/blob/main/test/system/super_scaffolding_test.rb#L286-L290 has been superseded by this more in-depth test https://github.com/bullet-train-co/bullet_train/blob/main/test/controllers/api/open_api_controller_test.rb#L4-L19. Which I think means we could remove the old one.
@newstler, does that sound right to you?

Actually, after looking at it some more I think that the test is redundant, but that we want to keep it. Or at least some version of it. It's part of super_scaffolding_test.rb which is kind of a special test that we run in CI after generating a bunch of new models and super scaffolds. So I think this particular instance of the test is meant to ensure that the OpenAPI doc continues to be valid after we generate new models and scaffolds.
Or maybe we don't need the separate controller test version?

Or maybe we should explicitly run the separate controller test after running the other super scaffolding tests...

I also think that this test https://github.com/bullet-train-co/bullet_train/blob/main/test/system/super_scaffolding_test.rb#L286-L290 is causing test failures when people run the tests locally.
For example:
https://discord.com/channels/836637622432170028/836637623048601633/1144621336866586755
I ran into it when working on this PR https://github.com/bullet-train-co/bullet_train/pull/921. I think the change I have in that PR should resolve the problem, but probably doesn't need to be entangled with the cuprite stuff.
I think the issue is that the test is sidestepping capybara and calling an endpoint directly that ends up creating database records which are not cleaned up in the normal post-test process. Not entirely sure. Will look at it firs thing next week.

It's part of super_scaffolding_test.rb which is kind of a special test that we run in CI after generating a bunch of new models and super scaffolds. So I think this particular instance of the test is meant to ensure that the OpenAPI doc continues to be valid after we generate new models and scaffolds.

@jagthedrummer Yes, the Super Scaffolding system tests are usually run in isolation, so I'm for keeping the test even though we technically do the same thing somewhere else.
All of our system tests should pass after running the Super Scaffolding test setup script, but we don't do that in CI, and it's not guaranteed that developers using Bullet Train will do so either.

Closing this because we need the redundancy to ensure that super scaffolding processes don't break the OpenAPI document.


Screen Sharing and Token Issue

Hi, I had the application up and running and have run into an issue where if I share the screen, participants can see what I am sharing but I can't, I just get myself on the screen and I can't see what I am sharing. I installed the latest release yesterday to see if this would shine any light on the screen sharing issue and now we are facing the token issue below. Any help or guidance would be appreciated.

Hi @dublinwebdesigners ,
Thanks for the report. Sorry about the delay in the response. Is this a localhost version of the app you are running?
Regarding the screen share, its by design. The screen sharing participant will not see the screen in the UI. However, there is a status dialog at the bottom stating that you are sharing your screen. Please let me know if you saw that.

hi @manjeshbhargav thanks for comments, when you say this is my design, is there a way to get around this, like in zoom and other video apps i would like the person sharing their screen to be able to see what they are sharing.

Hi @dublinwebdesigners ,
Please check out this diff, which enables the person sharing the screen to see it in the main window.
Also, let me know if you were able to resolve the token issue.

Hi. I had faced the same issue almost. I'm unable to share my room with another person. Can anyone please help?


Wrong images is used after second zoom

Using v2.0.7 (because our project is still on React v15) our initialization of the component looks like this:
<ImageZoom
    shouldReplaceImage={false}
    image={{
        src: 'file1.jpg',
    }}
    zoomImage={{
        src: 'file2.jpg',
    }}
/>

When we click on the image for the first time, file2.jpg is in the zoomed dialog (expected!), then we close it and click it again for zooming and file1.jpg is in the zoomed dialog. Why? Expected behavior: file2.jpg has to be always rendered in the zoomed dialog.

Pavel,
Thanks for submitting an issue and using the component in general!
I’ve just got married and am on my honeymoon, and I can look at this sometime over the next week.
Until then,
Robert
--
Robert Pearce
https://robertwpearce.com
https://www.linkedin.com/in/robertwpearce
m-NZ: +64 20 41305113
m-US: +1<PHONE_NUMBER>
m-UK: +44 7477 424374

On Feb 25, 2018, at 12:57, Pavel Kornev<EMAIL_ADDRESS>wrote:
Using v2.0.7 (because our project is still on React v15) our initialization of the component looks like this:
<ImageZoom
shouldReplaceImage={false}
image={{
src: 'file1.jpg',
}}
zoomImage={{
src: 'file2.jpg',
}}
/>
When we click on the image for the first time, file2.jpg is in the zoomed dialog (expected!), then we close it and click it again for zooming and file1.jpg is in the zoomed dialog. Why? Expected behavior: file2.jpg has to be always rendered in the zoomed dialog.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@pavelkornev can you please provide a full example of the issue in a fork or repository somewhere?
If this is an issue, then it surely is a serious one. @joshsloat have you noticed this being a problem?

Oh. It would be much more easier if this library supports unpkg.com, then I would be able to do an example just in jsbin without any forks ;-) I'll do an example at earliest possible.

I don't know much about unpkg (except I think Michael Jackson and some folks created it?). What would need to happen to something like<EMAIL_ADDRESS>to make it support unpkg? If I can do something to help, I'm glad to

@rpearce - I haven't seen this, but we're also not making use of zoomImage in Rise. I did poke at this lightly using the storybook and the Provide a zoom image example appears to be working as expected. If we get some solid repo steps on this, I can take a 👀 so you can focus on slightly more important things like your honeymoon :)

We updated to React@16 and it's not reproducible with v3.x, only relevant for v2.x. You can decide whether to close it or investigate it further.
@rpearce, you just need to generate a minified version of the library with all bundled dependencies in one file and expose it into a global variable. Example<EMAIL_ADDRESS>https://stackoverflow.com/a/45807979/280989

@pavelkornev as this is the only reported case of it, I will choose to let that bug stay in the 2.x branch until I hear of it being a problem again (time...).
Meanwhile, I'll create an issue for getting this setup on unpkg


update po file

@codiebeulaine Please review.
Cleanup templates with translation.
General rw and en po files


Add a page of microbenchmarks for wasm-bindgen

This commit starts to add a page of microbenchmarks for wasm-bindgen
which we can hopefully track and compare over time. Right now it's
primarily focused on data collection, making it easy to collect data
across a number of benchmarks for comparison. It doesn't currently do
much in the way of actually comparing the results for you (aka drawing
pretty graphs), so let's left for a future step.
It's hoped though that we can use this to track performance improvements
as well as ensuring that they work over time!

This isn't deploying correctly and I'm still trying to figure that out... will report back when it's hopefully working.

Ok now live!


Issue - 42 WhisperKit support simulator fixed

#42

@bharat9806 based on this issue https://github.com/argmaxinc/WhisperKit/issues/65 I'd also like to push a fix to this branch and bundle them together, the tests are currently failing - will want to merge with main as well


NVM doesn't create a ~/.bash_profile file if it doesn't exist

Issue
I just installed NVM on a brand new environment. This environment didn't have a ~/.bash_profile file.
It seems that the NVM install script wouldn't write anything into ~/.bash_profile until I manually create the file.
Environment

Mac OS 10.11.5
Bash 3.2.57

When they would just add touch $HOME/.bash_profile I thing the problem would be solved. Still I had issues see: https://github.com/creationix/nvm/issues/1127 where somehow the proper paths weren't loaded.

As long as we only did that on OS X, that seems a reasonable change.


fix/psd_parser_deep_nesting

Section divider setting sometime has 16 byte code length
code to fix this bug

	if(size >= 12)
	{
		// Signature: '8BIM'
		if(psd_stream_get_int(context) != '8BIM')
			return psd_status_divider_signature_error;

		// blend mode
		layer->divider_blend_mode = psd_stream_get_blend_mode(context);
	}

	// Following is only present if length == 16
	if( size == 16 )
	{
		//Sub type. 0 = normal, 1 = scene group, affects the animation timeline.
		int divider_animation_timeline_mode = psd_stream_get_int( context );

		layer->divider_animation_timeline_mode = divider_animation_timeline_mode;
	}

Hi @irov. Could please clarify which source file this code is in? Also, do you have a sample PSD file that reproduces the issue?

Hi, source in file layer_mask.c line 265
PSD is simple, you must create 10+ sub group (maybe enough 8)
like this
-Group 1
--Group 2
---Group 3
----Group 4
-----Group 5
------Group 6
---------etc
----------Layer 1


[BUG] CloudFormation Mock: An error occurred (Unknown) when calling the CreateStack operation: Unknown

CloudFormation Mock: An error occurred (Unknown) when calling the CreateStack operation: Unknown

OS: Linux 5.13.0-30-generic #33~20.04.1-Ubuntu SMP Mon Feb 7 14:25:10 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Python: 3.8
moto installed via pip
boto3==1.21.14
botocore==1.24.14
moto==3.0.7

When running the unit test below, with@mock_sts and @mock_cloudformation, we encounter an exception.
    cloudformation_client = boto3_session.client('cloudformation', region_name=region)
    cloudformation_client.create_stack(
                StackName='stack',
                TemplateURL='template public accessible in our bucket',
                Parameters=[{
                            'ParameterKey': 'ExternalId',
                            'ParameterValue': '123'
                            }],
                Capabilities=['CAPABILITY_IAM', 'CAPABILITY_NAMED_IAM'],
            )

This exception happens:
  File "/home/myuser/dev/mysdk-sdk-python/mysdksdk/client.py", line 1537, in _deploy_cloudformation_mysdk_service_role
    cloudformation_client.create_stack(
  File "/home/myuser/.local/share/virtualenvs/mysdk-sdk-python-1KRJ608P/lib/python3.8/site-packages/botocore/client.py", line 395, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/myuser/.local/share/virtualenvs/mysdk-sdk-python-1KRJ608P/lib/python3.8/site-packages/botocore/client.py", line 725, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (Unknown) when calling the CreateStack operation: Unknown

If we change the code, to instead of receiving TemplateURL='template public accessible in our bucket', pass the same content on TemplateBody='', the error don't happen.
Is there any way to workaround this?

Hi @leonardoviveiros, Moto mocks all AWS requests. Even if you do not explicitly want to mock S3, it should still not connect to AWS' S3, to avoid any mistakes.
What happens if you add mock_s3 as well, and upload the template to S3 as part of you test setup?

@bblommers that's a great workaround and it actually fixed it. Thanks for the fast response.
Now I can use the normal s3 template URL, and I'm creating the S3 bucket using moto
  s3 = boto3.client('s3', region_name='us-east-2')
  s3.create_bucket(Bucket='tenchi-assets', CreateBucketConfiguration={'LocationConstraint': 'us-east-2'})
  s3.put_object(Bucket='my-assets', Key='my-service-role.template', Body=json.dumps(DUMMY_TEMPLATE))

And then I can proceed with my testing without changing my code.
I tried to workaround this before your answer and succeeded by changing the code to use TemplateBody, but then I ended up with bigger complexity to fetch the template and then pass its content to cloudformation. The solution you proposed is way better IMHO.
You can close it you you won't change the way it works with cloudformation+s3.

@bblommers that's a great workaround and it actually fixed it. Thanks for the fast response.
Now I can use the normal s3 template URL, and I'm creating the S3 bucket using moto
  s3 = boto3.client('s3', region_name='us-east-2')
  s3.create_bucket(Bucket='my-assets', CreateBucketConfiguration={'LocationConstraint': 'us-east-2'})
  s3.put_object(Bucket='my-assets', Key='my-service-role.template', Body=json.dumps(DUMMY_TEMPLATE))

And then I can proceed with my testing without changing my code.
I tried to workaround this before your answer and succeeded by changing the code to use TemplateBody, but then I ended up with bigger complexity to fetch the template and then pass its content to cloudformation. The solution you proposed is way better IMHO.
You can close it you you won't change the way it works with cloudformation+s3.

It's a feature @leonardoviveiros, not a bug :slightly_smiling_face:
Happy to hear this now works!


bootstrap-tools-linux: Qualify packages with multiple outputs

Things done

[ ] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/) (only tests)
[x] Fits CONTRIBUTING.md.
[x] Builds using nix-build . -A stdenvBootstrapTools.x86_64-linux

Fails currently on Hydra.
I added the output selector for every package with multiple outputs, not only for gcc/glib where it was missing.
The tests kept failing because of tar being built with acl and neither libacl nor libattr is copied. So I added a minimal tar version without acl.

Thank you!


provide minimum google authentication scope

What kind of change does this PR introduce?

Fix a bug not be able to authenticate using Google account

What is the current behavior?

Google throws Exception about lacking logging in scope due to recent Google authentication update

What is the new behavior?

The bare minimum required scope are ['email', 'profile'] for logging in were added, now can authenticate with Google again

I thought this update was a bug that was introduced by Google and later was removed. Do you have any thing that says the change was intentional and is here for good?

yes, you are right. Previously I have to add these minimum scope values into library code just to pass throught Google authentication in my own project (which also uses this package). As a result, I realize that this package has not used the passed in scopes anywhere. That's why I think it can be good to leverage the variable somehow.
But yes, since Google fixed the issue, minimum could be empty array rather than certain values.


Integrate Stepwise Planner into Copilot

marking as high pri since we've had a lot of customer asks about multi-pass support, i.e., https://github.com/microsoft/semantic-kernel/discussions/1356

Done -https://github.com/microsoft/chat-copilot/pull/121


Fix all flake8 issues in the code

The flake8 errors has been fixed. The build still will not pass on master branch as the build fails while deploying the master branch if it does not fail on flake8 tests.

Still some flake8 issues are there which did not show up locally on my laptop, I will upload a new commit fixing those.

Here flake8 command is running in Python 2.7. But there are code blocks used in the project specific to python 3 and invalid in the context of python version 2 e.g this. So if we want flake8 tests to pass without making any structural changes we need to run the test in Python 3 here. What should I do?

I need someone to look into this pull request. Should I alter the settings of testenv:checkqa?

First, thanks a heap for your contribution, highly appreciated !
Can you make sure tox -e checkqa passes too please ?
Thanks again, really nice !

I have another commit to push, that passes tox -e checkqa on python 3.7, it will pass on any python 3.x version but it won't pass on python 2.7 for the reasons I stated above. Base python currently in use in tox.ini is 2.7. So this command won't pass on travis test.

Thanks Munim, go ahead for the python upgrade

The branch is ready for merge now, waiting to see "build:passing" badge again :)

The tests passed, but the deploy script encountered some error. Now it's in your hand mate.

Deployment was on OpenShift 2 which is dead. We have a new infra (gitlab+k8s which you might have seen video demo of on the blog) but I don't have time to migrate DAL there. However, we're posting an offer maybe someone will take it who knows

Otherwise, it'll have to wait until i have time, maybe next year :joy:


docs: symlink to host device is resolved

Also apply changes from commit 3fd9f0c028f9dab7c8923629d4dc5d38e594db1a
to the other two commands that have the --device option.
Documents #4550
Signed-off-by: Stefan Becker<EMAIL_ADDRESS>

/ok-to-test
LGTM

/approve

Thanks @stefanb2

LGTM
On Sun, Feb 23, 2020, 09:47 Daniel J Walsh<EMAIL_ADDRESS>wrote:

Thanks @stefanb2 https://github.com/stefanb2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/5304?email_source=notifications&email_token=AB3AOCBCYVM2TAEJECN7YGLREKD7DA5CNFSM4KZ2KKD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMV5RKA#issuecomment-590076072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCATMV3UGA5NGUBRVV3REKD7DANCNFSM4KZ2KKDQ
.

/lgtm


Feature request: Show the user not only that an EV3 was found, but also whether it is an ev3dev, ev3lejosv0 or ev3lejosv1

When a user connects the EV3 to the computer, the connector program only shows that an EV3 was found.
If the connector Program could also tell the user whether or not "EV3 leJOS 0.9.0", "EV3 leJOS 0.9.1" or "EV3dev" was found, the user would directly know which robot system to pick in the Open Roberta Lab.
This feature is more or less useful for people who are quite new to the Open Roberta Lab.

Afaik the connector only can discover EV3 leJOS 0.9.0" and  "EV3 leJOS 0.9.1. As EV3 leJOS 0.9.0" is outdated I think there is no need to add this feature.

Then this is out of the question for now.


Inadequate rate-limiting when editing Wikimedia Commons

When editing files on Wikimedia Commons, it is possible to encounter rate-limits which imply that edits are not made on the wiki.
To Reproduce
Steps to reproduce the behavior: see the forum post.
Current Results
Edits are skipped.
Expected Behavior
The process waits before attempting edits, meaning that edits are successful.
Versions

OpenRefine: 3.8-SNAPSHOT

Additional context
Edits to Wikimedia Commons involve a bit more operations than on Wikidata, since separate API actions are required to upload the file (if any), edit the structured data and edit or update the wikitext. So it's not so surprising that we are running into a stricter rate-limiting than on Wikidata. The thresholds in use on both wikis might be different too. We need to investigate what those thresholds are and enforce them properly. Also, we should make sure that failed edits are detected properly and re-attempted.

@wetneb, do you think this is something that could reasonably be done in OR or would you need to change things in Wikidata-Toolkit?

Wikidata-Toolkit already exposes methods to define a particular rate-limiting (in the WikibaseDataEditor class, such as setAverageTimePerEdit). OpenRefine should be able to use those methods to set those parameters to something appropriate for the API actions / Wikibase instance it does.
If that's not sufficient, there could be either

additional waiting done on the OpenRefine side, without changing Wikidata-Toolkit
improvements to Wikidata-Toolkit to fit our use cases

@wetneb My finding is by setting the retry limit and exponential backoff settings, it will address this issue. I was able to verify this working. Let me know if this makes sense.

Oh great, if you have some changes which address the issue, that's totally worth submitting!
I had a look at the forum post again, and what I would prioritize doing is making sure the "purge" action and wikitext editing action correctly detect that they are throttled and wait the appropriate amount of time before retrying. I believe this detection is working for Wikibase editing but likely not for the new API actions we have introduced for Commons support.

@wetneb Added support in add / update and purge flows. PR raised.


Removed maven plugin

Hi
Since maven-publish plugin is already used having the maven plugin is not necessary. We had some users trying to install spek from JitPack.io and this small change makes it work.
Happy building!

Thanks

Build was successful https://jitpack.io/#JetBrains/spek/149f0d9bbe :+1:


TFRS - Add Submission Date to IDIR Compliance Reports index table

Title: Add the original Submission Date to the IDIR Compliance Reports index table
Description: Add a new column called 'Submission Date" (after the "Last Updated On" column) to display the date/time a compliance or exclusion report was originally submitted to government. Sorting needs to work on this new date column.
Wireframe:

Purpose and benefit to user: The addition of the Submission Date column enables users to easily view, sort, and filter reports based on their original submission dates, streamlining the process of tracking and managing compliance reports.
Acceptance Criteria:

[ ] Given I am an IDIR user with access to the Compliance & Exclusion Reporting feature, when I am viewing the Compliance Report page, then I see a column containing the report submission date/time (in the same format as the 'Last Updated On' column date/time).

Development Checklist:

[ ] Update the Compliance Report index view to include the new 'Submission Date' column and make it sortable
[ ] Make sure the Compliance Report serializer includes the 'submission_date' attribute and ensure it is populated when the api endpoint is called
[ ] Update the Compliance Report controller to handle sorting by 'submission_date'
[ ] Write tests to verify that the 'Submission Date' column displays the correct data and can be sorted correctly

tested with business area 3/29


format for blood pressure

currently in table is 125 80  should be 125 over 80, so at the least 125/80 (an easy fix)

I can see it 133/78 for me with '/' being in a dimmed colour.
I'm looking in 1.0 (18) which is the latest now.
@twoolf can you confirm you're looking into the same build?

Could be that the '/' was coming out too dim for the room that I was in --
my suggestion is to make is the same colour/intensity as the numbers --
On Wed, Jun 29, 2016 at 3:08 PM, Kostiantyn Sokolinskyi <
<EMAIL_ADDRESS>wrote:

I can see it 133/78 for me with '/' being in a dimmed colour.
I'm looking in 1.0 (18) which is the latest now.
@twoolf https://github.com/twoolf can you confirm you're looking into
the same build?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yanif/circator/issues/62#issuecomment-229457209, or mute
the thread
https://github.com/notifications/unsubscribe/AFIkjCPfJsspnQYWYysmNd3OB0DbP3h0ks5qQsK0gaJpZM4I_s8C
.

Put into backlog to double check and fix


fix(editor): Publish diagnostics on open for all run modes except disabled

Should the commit scope for this be editor or language_server?  I tried language_server with https://github.com/oxc-project/oxc/pull/6968, but it tagged the area as editor still.  So, not really sure which this should be.


Problems with deletes when creating image when $HOME is a symlink

This is on a machine with a slightly odd set up. $HOME is set to /usr/homes/frr7/ , but /usr/homes/frr7 is just a symlink to /home/frr7 . If I apply https://github.com/indigo-dc/udocker/pull/266 and try again:
~/.udocker/bin/udocker pull vitrivr/adampro:latest-selfcontained
~/.udocker/bin/udocker create --name=adampro vitrivr/adampro:latest-selfcontained

I get:
Error: delete outside of directory tree:  /usr/homes/frr7/.udocker/containers/3e756b95-fe2f-3d53-8e95-ef01a382adea/ROOT/etc/alternatives/pager.1.gz

The problem is that /usr/homes/frr7/ is always dereferenced when adding it to the safe prefixes, so only /home/frr7/.udocker/containers/ ends up as safe. The solution is to stop dereferencing symlinks so much.

Checking of safe paths has been improved in devel and devel3 branches

Addressed in v1.3.0.


image update

updated basemimage in ROOT_CONTAINER in docker-stacks/base and environment.yml for all images.

We just tested it on a similar server as will be used on Wednesday, everything seemed to be working fine 👍


Correct language on "print test result" view for negative test case

Related Issue or Background Info

The above screenshot accurately captures the issue but (at least I'm pretty sure - @LGFranklin correct me if I'm wrong) prescribes the text for the positive test case, which isn't what we want here

Changes Proposed

No longer refer to "antigen" in the test notes for negative results, as this is inaccurate and confusing

Additional Information

I treated the Patient test result content v4 as canonical when updating the text

@Rebecca-LM if this document is out-of-date in any way please let me know!

Screenshots / Demos
Before
English

Spanish

After
English

Spanish

Checklist for Author and Reviewer

[ ] @Rebecca-LM is the updated copy correct?
[ ] @LGFranklin is this the correct outcome?

UI

[x] Any changes to the UI/UX are approved by design
[x] Any new or updated content (e.g. error messages) are approved by design

Testing

[x] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

[x] Database changes are submitted as a separate PR

[x] Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
[x] Any changes to tables that have custom no-PHI views are accompanied by changes to those views
(including re-granting permission to the no-PHI user if need be)
[x] Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
[x] Each new changeset has a corresponding tag

[x] GraphQL schema changes are backward compatible with older version of the front-end

Security

[x] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[x] Any dependencies introduced have been vetted and discussed

Cloud

[x] DevOps team has been notified if PR requires ops support
[x] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Looks good to me; need to make this for negative AND inconclusive.

Looks good to me; need to make this for negative AND inconclusive.

@LGFranklin yes indeed, the negative and inconclusive test cases produce identical text in the "print" view:

@nullflux do we need updated language for the inconclusive too? Didn't see it here.
One thing to grab from the versions Nathan and I created is the written out URLs that are needed for print results. We have one for English and the Spanish URL for Spanish. They were formatted in the correct way (without https:// and some other stuff). Lmk if you have questions on this.

@nullflux do we need updated language for the inconclusive too? Didn't see it here.
The original requirement was that the negative and inconclusive cases should have the same test notes for the "print" view, so that is taken care of here:

One thing to grab from the versions Nathan and I created is the written out URLs that are needed for print results. We have one for English and the Spanish URL for Spanish. They were formatted in the correct way (without https:// and some other stuff)

@Rebecca-LM that's a good call - until this PR, that link to the CDC website didn't exist on the negative/inconclusive cases at all. The positive case has had links for a while and they are formatted correctly on the "print" view:

I can fix that for negative/inconclusive here real quick.


DBZ-2231 Fix test failure - SqlServerChangeTableSetIT#readHistoryAfterRestart

https://issues.redhat.com/browse/DBZ-2231

The test failure is unrelated but logged as https://issues.redhat.com/browse/DBZ-2319

@Naros Applied, thanks!


IE9: circle text not centered

You can fix it by adding '-ms-transform' as well:
'-ms-transform: translate(-50%, -50%);'

Hmm, that should be already done.
I set translate(-50%, -50%) with utils.setStyle function which deals with browser prefixes:
// element is <p>
utils.setStyle(element, 'transform', 'translate(-50%, -50%)');

utils.js
var PREFIXES = 'webkit moz o ms'.split(' ');
function setStyle(element, style, value) {
    for (var i = 0; i < PREFIXES.length; ++i) {
        var prefix = capitalize(PREFIXES[i]);
        element.style[prefix + capitalize(style)] = value;
    }

    element.style[style] = value;
}

so it will set:
element.style[msTransform] = 'translate(-50%, -50%)'

I added a console.log(JSON.stringify(element.style) there and it outputs:
{"0":"position","1":"top","2":"left","3":"padding-top","4":"padding-right-value","5":"padding-bottom","6":"padding-left-value","7":"padding-left-ltr-source","8":"padding-left-rtl-source","9":"padding-right-ltr-source","10":"padding-right-rtl-source","11":"margin-top","12":"margin-right-value","13":"margin-bottom","14":"margin-left-value","15":"margin-left-ltr-source","16":"margin-left-rtl-source","17":"margin-right-ltr-source","18":"margin-right-rtl-source","19":"transform","WebkitTransform":"translate(-50%, -50%)","OTransform":"translate(-50%, -50%)","MsTransform":"translate(-50%, -50%)}
Note the "MsTransform":"translate(-50%, -50%). Are those capitalizations later turned into html style notations? (ie. MsTransform -> -ms-transform)

Yes the browser prefixes are added like that in JS. Now that I think of it, it might be that ms was an exception in the naming convention

How can they not be :)

Fixed in release 0.8.1: https://github.com/kimmobrunfeldt/progressbar.js/releases/tag/0.8.1


[Scenario] Curse of Set (Nicola Zee)

Mansions of Madness Scenario
Expansions the scenario requires

Streets of Arkham (SoA)
Path of the Serpent (PotS)

Expansions the scenario can optionally use

Curse of Set

GitHub Url
https://github.com/NicolaZee/PublishedScenarios/tree/master/CurseOfSet

Ohh shiney! I'll add this now

I've added this to the manifest, @antontimmermans could you add this to the stats sheet, im not sure how to add to yours :)

Thanks for the quick response.

added to statistics


can not link the spirv-tools

Generating 64-bit Glslang Release CMake files for Visual Studio 17 0 -DCMAKE_INSTALL_PREFIX=install ..
CMake Warning (dev) at CMakeLists.txt:34 (project):
cmake_minimum_required() should be called prior to this top-level project()
call.  Please see the cmake-commands(7) manual for usage documentation of
both commands.
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19044.
CMake Deprecation Warning at CMakeLists.txt:39 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- Using Debug VC++ CRT: MDd
-- Using Release VC++ CRT: MD
-- Using MinSizeRel VC++ CRT: MD
-- Using RelWithDebInfo VC++ CRT: MD
-- Using Release VC++ CRT: MD
CMake Warning (dev) at CMakeLists.txt:233 (find_package):
Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
the cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:239 (find_host_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
-- Google Mock was not found - tests based on that will not build
-- spirv-tools not linked - illegal SPIRV may be generated for HLSL
-- Configuring done (1.3s)
-- Generating done (0.1s)

when build shaderc, it will use spirv-tools
Updating "E:\demo\git\vk_video_samples\vk_video_decoder\external"\shaderc
HEAD is now at 3fe94c6 Complete moving io.* to io_shaderc.*
E:\demo\git\vk_video_samples\vk_v... @ 2ec8f8738118cc483b67c04a759fee53496c5659
E:\demo\git\vk_video_samples\vk_v... @ a3fdfe81465d57efc97cfd28ac6c8190fb31a6c8
E:\demo\git\vk_video_samples\vk_v... @ 389cb68b87193358358ae87cc56d257fd0d80189
E:\demo\git\vk_video_samples\vk_v... @ 7107ebc4fbf7205151d8d2a57b2fc6e7853125d4
E:\demo\git\vk_video_samples\vk_v... @ ef3290bbea35935ba8fd623970511ed9f045bbd7
E:\demo\git\vk_video_samples\vk_v... @ e56beaee736863ce48455955158f1839e6e4c1a1
Building "E:\demo\git\vk_video_samples\vk_video_decoder\external"\shaderc
Making 64-bit shaderc Debug
CMake Deprecation Warning at CMakeLists.txt:15 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument  value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions.
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.19044.
-- Shaderc: build type is "Debug".
-- Configuring Shaderc to avoid building tests.
-- Configuring Shaderc to build examples.
-- asciidoctor was not found - no documentation will be generated
CMake Warning (dev) at cmake/setup_build.cmake:52 (find_package):
Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
the cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:58 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Warning (dev) at cmake/setup_build.cmake:17 (find_package):
Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
the cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
CMakeLists.txt:83 (find_host_package)
This warning is for project developers.  Use -Wno-dev to suppress it.
CMake Error at third_party/CMakeLists.txt:62 (message):
SPIRV-Tools was not found - required for compilation

Can you please try reverting 75a9ddda1aa09bd696a33eca6e67eab6a3b7d685 and try to fetch?


Create the model files on creation and during the synchronization step

Closes #44
Also fixes an issue where model files aren't generated until you open the .sq file

LGTM


[POPUP] Popup does not fit within the boundaries of the viewport

if you do not have enough space for the popup appears this error, such as open console.

That's correct behavior. You can specify a lastResort position in settings object if you need it to appear always even if it cannot fit.

I think default error throwing when popup cannot fit is not correct from UX point of view.

@matikucharski +1

@matikucharski +1
That's definitely not what users expect.

@matikucharski  +1

max-height can be set to 100vh instead.

use element children and set scroll and max-height:
`

`


Logger support

As titled, related to #8.
By default the logger is not enabled, if the user passes { logger: true } or { logger: options } it will be enabled for all the request.
If everything is ok for you, I can update the docs.
I've also updated the dependencies.

Coverage increased (+0.1%) to 96.273% when pulling 167ed0d20659919bcbd67a62ffb6947135217ce5 on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.

I think we should always enable the logger, because req.logger should be there 100% of the time, or writing code for fastify might be trickier.

Don't you think we are imposing too much on the freedom of the developers by using a 'cannot disable' logger? I don't know, maybe we could enable the logger by default, but I think we should expose an option to disable it.
👍  for the rest!

I'm ok in having the logger set to level: 'fatal' or level: error by default. I'm just not ok in not having the logger property on the request all the time.

Coverage increased (+0.1%) to 96.273% when pulling d39d60b7326650ccb53ebe288848488fd98734cc on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.

Coverage increased (+0.1%) to 96.273% when pulling d39d60b7326650ccb53ebe288848488fd98734cc on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.

Coverage increased (+0.1%) to 96.273% when pulling d39d60b7326650ccb53ebe288848488fd98734cc on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.

Can you please add docs?

Coverage increased (+0.1%) to 96.273% when pulling 8b827982e334d15e889261de6af59f0d87216319 on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.

Coverage increased (+0.1%) to 96.273% when pulling 8b827982e334d15e889261de6af59f0d87216319 on logger-support into 1ce1a910de4948d5f2546a90d1f4a62809472ce7 on master.


Simplify inverse trig functions

We can apply our trig constant tables backwards.
Inspired by https://github.com/davidedc/Algebrite/issues/111

Oh no, is it like symbolic form of sine but this time arcsine

🐷

Yes


Parser in docker 1.13 breaks backwards compatibility for comments in middle of RUN statement

Description
Previously (Docker 1.6+) one could document long RUN lines with comments interspersed. https://github.com/docker/docker/pull/24725 broke this.
FROM alpine
RUN echo \
# comment
hi

Steps to reproduce the issue:

build the above Dockerfile on 1.13-rc2

Describe the results you received:
Error response from daemon: Unknown instruction: HI
Describe the results you expected:
Docker build the above Dockerfile on 1.6 through 1.12 (thanks @tianon for testing all of them)
Successfully built xxx
Additional information you deem important (e.g. issue happens only occasionally):
Quick list of some official-images broken by this change:

arangodb:2.5.5 from June 2015

and all though arangodb:3.1.2

bash
cassandra
elasticsearch
golang:windowsservercore and nanoserver
httpd
irssi
julia
kibana
logstash
mariadb
mongo:windowsservercore
mysql:5.5

Output of docker version:
(working version)
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.7.3
 Git commit:   6b644ec
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.7.3
 Git commit:   6b644ec
 Built:
 OS/Arch:      linux/amd64

Output of docker info:
(working version)
Containers: 6
 Running: 4
 Paused: 0
 Stopped: 2
Images: 5715
Server Version: 1.12.3
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null overlay bridge host
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.8.8-gentoo
Operating System: Gentoo/Linux
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 30.87 GiB
Name: isengard
ID: UOCM:3F65:5FZC:6H5L:W3HY:34G4:A5XZ:SUOV:S2D4:XQTO:4KGA:6XSE
Docker Root Dir: /mnt/spare/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

Just for reference, https://github.com/docker/docker/issues/28587 was another issue discussing this, but I think at least the comment half of this change is a really serious regression (and is going to be a pretty severe breaking change for existing Dockerfiles in the wild), since there is no good workaround for adding comments in the middle of a really long RUN line (whereas an intentional empty line can easily get a \ added to workaround that change).

The last-known version where comments were not supported inline being 1.5 is amusing given https://blog.docker.com/2015/10/docker-hub-deprecation-1-5/ (1.5 and earlier no longer supported by Docker Hub :smile:)

Any way we could do some querying on the public automated builds to see at least in the public aspect what the impact of this breaking change is?

It also affects me. So there are no deprecation policies? Great.

@davidfischer-ch yes, it has been overlooked :sweat: :disappointed:. We are gonna work on it for the 1.13.0 GA so it does not break people Dockerfile… (@yongtang already proposed a changed :angel:)

There's a couple of issues at hand here;
I think the original design for RUN was that RUN is "agnostic" to its
content, because it doesn't know what shell is used to execute the RUN
statement in (i.e., everything after RUN should be treated as an opaque blob).
While this should probably be "true", the implementation does not match that;
before the content is sent to the shell, the Dockerfile parser / builder (in
no particular order here);

Removes empty lines inside the RUN
Skips "comment only" lines (including comments not starting at position 0)
Strips line-continuation markers (\)

Because of these steps, a RUN statement does not have the same behavior
as a regular shell (see this gist)
Basically, comment-only lines are handled by Docker, comments preceeded by
other characters are passed on to the shell.
Note that skipping comments not starting at position 0 is basically a bug,
because comments in Dockerfiles should only be seen as comment if they start
at position 0.
PR https://github.com/docker/docker/pull/24725 was created to fix cases where,
because of a combination of 1. and  3., a trailing \ resulted in the
Dockerfile continuing to see furter instructions as part of the RUN statement;
FROM busybox
RUN echo "foo" \
#&& echo "bar";

# Do something else
RUN echo "something else"

Resulting in;
Step 1 : FROM busybox
 ---> 47bcc53f74dc
Step 2 : RUN echo "foo" RUN echo "something else"
 ---> Running in 991b76486899
foo RUN echo something else
 ---> d488a4c21b22

I think we should fix that case, but we can consider it a "legacy" burden
we have to carry. Which leaves us with some options;
A. Revert all changes
Include both empty and comment lines as part of the RUN statement. This
would be a valid Dockerfile;
FROM busybox
RUN echo "foo"; \

# This is a comment

    # So is this

    echo "and this is part of the same RUN"

RUN echo "this is the next RUN"

B. Skip comment-only lines, but break on empty lines
This is what's being implemented in https://github.com/docker/docker/pull/29006. Users can use a \ on an empty line to add whitespace, but an empty line
stops the RUN.
With this change, this would still be valid;
FROM busybox
RUN echo "foo"; \
\
# This is a comment
\
    # So is this
    \
    echo "and this is part of the same RUN"

RUN echo "this is the next RUN"

C. Skip comment-only lines, warn / deprecate continuing on empty lines
Like B., but instead of breaking, print a warning ("skipping empty line"?),
Or a deprecation warning ("WARN: skipping empty line. Empty lines inside a RUN
instruction is deprecated, and will be removed in Docker 1.16")

High-order question (IMO):  If we were starting from scratch would we want it to act like the shell does? Meaning, stop when it hits a blank line AND when it hits a comment?
In a perfect world I'd say "yes".  Which would then lead towards us deprecating the new behavior and then removing it in 3 releases.
However, there's a catch.  Not only do we have a lot of Dockerfiles in the wild with this "odd" syntax (which by itself doesn't necessarily mean we should allow it to continue), BUT given there's no good way to prevent multiple layers from being created when you have multiple RUNs, which means people are kind of forced into using RUNs that span a lot of lines via continuation chars, there's no good way to allow people to be good citizens and add comments/docs to their long RUN cmds.
Now, if we had a "squash just certain layers" type of operation in Dockerfiles then people wouldn't need to create these huge RUN cmds. They could have multiple RUNs, with comments between them, and then squash them down afterwards.  Normally, in the past, we tried to align Dockerfile processing with shell processing, but this point (to me) is why we may not be able to align with the shell in this case.
Net: I think we should add back in support for comments in multi-line cmds but don't deprecate it until (or 'if') we add support for selective squashing.

@thaJeztah @duglin
I want to bring in another angle to look at the issue, which is related to the definition of comment line, and escaping \ after comment #. See (https://github.com/docker/docker/pull/24725#issuecomment-233158353) and (https://github.com/docker/docker/pull/24725#issuecomment-233166210)
From my understanding, the issue we are facing now is probably not about when to continue for RUN, but about when to stop for RUN.
For example, let's assume there is another command pair RUN-SHELL and RUN-END for Dockerfile:
RUN-SHELL
echo "foo"; \
\
# This is a comment
\

    # So is this
    \
    echo "and this is part of the same RUN"
RUN-END
RUN echo "this is the next RUN"

Then the above will be much cleaner and a lot easier to parse, because we could essentially cut any blob in between RUN-SHELL and RUN-END, and pass the whole blob to a shell. The commenting, escaping, etc. will be handled by shell, not by Dockerfile parser.
We could even add an additional flag to specify which shell, e.g.,
RUN-SHELL --shell bash
echo "foo"; \
\
# This is a comment
\

    # So is this
    \
    echo "and this is part of the same RUN"
RUN-END
RUN echo "this is the next RUN"

I think another alternative solution is to revert back the old behavior, while at the same time introduce a new command pair RUN-SHELL/RUN-END (or RUN-BEGIN/RUN-END, or RUNBLOCK/RUNEND, etc.)
At the same time, we encourage users to use RUN for one-liner and RUN BLOCK/END for multiple line shells.
I don't know if introducing another (pair) command for Dockerfile is the best solution. But to be honest, RUN with multiple lines and so many varieties of breaking/continuing/commenting, is really hard to maintain. And solve different issues user facing from different angles is really difficult as well.

@yongtang @duglin Yes, I think having "heredoc" (or similar) notation would be the solution for that https://github.com/docker/docker/issues/1554, something like RUN_BEGIN / RUN_END.
For 1.13 we should decide though if we go with A, B, or C (or another option if I missed one)

Yea, a heredoc is another option.  For now I think the current PR is the right approach - we can then decide on the rest later.

Any way we could do some querying on the public automated builds to see at least in the public aspect what the impact of this breaking change is?

@tianon I know it was done at some point, i.e. every Dockerfile on GitHub was built/tested for a change that was made in the builder. I'm not sure how it was done though; @crosbymichael may know

My own vote would be C, given that blank lines are trivially fixed by adding a \, but I'd be happy with B as well.  I think the discussion of adding better multi-line syntax is orthogonal at this point given how deeply invested we are into the current syntax still (but definitely interesting as a separate discussion point).

My preference is A for Docker 1.13.
B breaks all Dockerfiles (30+) in my team, and I suspect may impact many others. I believe such a significant breaking change should be communicated three releases in advance, as stated in Breaking changes and incompatibilities.
As for C, while blank lines are trivially fixed by adding a \, that makes the RUN instruction visually cluttered, in my opinion. Blanks lines play a role in the readability of long RUN instructions. I think changing that warrants much more discussion (separately).

Oh sorry, I misspoke -- my preference is for C, but I'd be fine with A.  I think B is a bit too aggressive on the breakage scale for 1.13 alone.

My preference goes to C, but with an extra note; let's see if we can find a better solution before 1.16 (such as the discussed heredoc/code-block).
We can extend the deprecation period if needed if no alternative is present yet.

For 1.13 I'd go for A.
This is something that requires more testing and I don't think we can afford to throw together a fix last minute.
We're already (nearly) 3 release candidates in, I don't think it's time for making changes to the parser other than to bring us back to where we were for 1.12 unless this was something that was broken in 1.12 (which I don't think it was).

So, let's go for A for 1.13 (see #29064) and work on C afterwars.

Just ran into this new feature. I have to say, solution C for 1.13 seems more reasonable.

@NicoTexas Added a PR #29161 for solution C. The PR generates a warning for empty line continuation, for 1.14 (maybe).

@duglin https://github.com/docker/docker/issues/29005#issuecomment-264177285 the other reason for RUN spanning multiple lines is because it would be annoying to prefix every shell command with RUN keyword.  i like the heredoc idea for that https://github.com/docker/docker/issues/29005#issuecomment-264181417


Refactor

Codecov Report

Merging #626 (e374806) into main (815b3dc) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   85.20%   85.17%   -0.04%
==========================================
  Files         307      307
  Lines       27433    27433
==========================================
- Hits        23374    23365       -9
- Misses       4059     4068       +9

Impacted Files
Coverage Δ

lib/hir-mir/src/expression_compiler.rs
88.32% <0.00%> (-0.80%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815b3dc...e374806. Read the comment docs.


pr2_common: 1.12.2-0 in 'lunar/distribution.yaml' [bloom]

Increasing version of package(s) in repository pr2_common to 1.12.2-0:

upstream repository: https://github.com/pr2/pr2_common.git
release repository: https://github.com/pr2-gbp/pr2_common-release
distro file: lunar/distribution.yaml
bloom version: 0.6.4
previous version for package: 1.12.0-0

pr2_common

No changes

pr2_dashboard_aggregator

No changes

pr2_description
* Merge pull request #269 <https://github.com/pr2/pr2_common/issues/269> from bmagyar/kinetic-devel
  Fix pr2_description warnings
* Remove playerstage xml schemas
* xacro.py -> xacro
* Contributors: Bence Magyar

pr2_machine

No changes

pr2_msgs

No changes

I have moved release repository for pr2_common from https://github.com/ros-gbp/pr2_common-release to https://github.com/pr2-gbp/pr2_common-release, because we have been releasing this from pr2-gbp so far.

:+1:

If this is ok, we could remove https://github.com/ros-gbp/pr2_common-release

It appears that the ros-gbp repository is the only one with the branches for a hydro release. As we don't modify distribution files after the distribution goes EOL, we'll need to keep that repository alive.
Though having all the hydro branches available on the https://github.com/ros-gbp/pr2_common-release.would be great as this will allow to have everything at the same place.


Use golang 1.5.1

@juliusv

Thanks! When upgrading to Go 1.5.1, this also needs to be removed: https://github.com/prometheus/utils/blob/master/Makefile.COMMON#L47-L49
...because the Mac Go 1.5.1 download links don't contain the OS X version anymore.

Updated. People wanting to install go < 1.5 will have to set GOPKG now.

Alrighty, I'll just hot-patch it myself :)


Added GrahamTheDevRel profile

Fixes Issue
Changes proposed
[X] - Add GrahamTheDevRel profile
Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

You're adding an empty file here.
Please follow the quickstart guide to help you add your profile data into LinkFree. 🛠

It really does help to not do things at 1am. I pressed save on the file this time 🤦🏼♂!
My apologies!


Ritual entities appear to be disappearing when restarting single-player server

To-do: confirm this is happening in 3.0.14 branch.


Documentation improvements

Add many jsfiddle examples !

We need UMD package in order to load the lib in JSFiddle (depends on https://github.com/wittydeveloper/react-apollo-form/issues/5)


proper level checks

Cleaner solution to https://github.com/alan-turing-institute/MLJ.jl/issues/540
xRef: https://github.com/alan-turing-institute/MLJ.jl/issues/540
Not gonna lie, this was a PITA; but at least now levels passed down by MLJ are preserved even if there's no example for a given class.

Codecov Report

Merging #73 into master will decrease coverage by 0.05%.
The diff coverage is 98.61%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   95.69%   95.64%   -0.06%
==========================================
  Files          21       21
  Lines         790      803      +13
==========================================
+ Hits          756      768      +12
- Misses         34       35       +1

Impacted Files
Coverage Δ

src/mlj/classifiers.jl
100.00% <ø> (ø)

src/mlj/interface.jl
87.71% <94.11%> (-1.57%)
:arrow_down:

src/fit/analytical.jl
100.00% <100.00%> (ø)

src/fit/default.jl
83.33% <100.00%> (+0.98%)
:arrow_up:

src/fit/iwls.jl
100.00% <100.00%> (ø)

src/fit/newton.jl
100.00% <100.00%> (ø)

src/fit/proxgrad.jl
95.00% <100.00%> (ø)

src/glr/constructors.jl
100.00% <100.00%> (ø)

src/glr/d_logistic.jl
100.00% <100.00%> (ø)

src/glr/utils.jl
90.90% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce79b5...cc660e8. Read the comment docs.


Rename offsets columns

To make offsets indication more clear we have to:
Topic details page:

Rename min/max offset to first/next (earliest/latest?) offset
Add a column "message count"

CC @iliax @GneyHabub

To make offsets indication more clear we have to: Topic details page:

Rename min/max offset to first/next (earliest/latest?) offset
Add a column "message count"

CC @iliax @GneyHabub


Add code for all the elements of our app

We need to each add some code for the app, including:

[ ]  app.R file for app layout and dash core components (this is the main app we run)

[ ] barplot.R file for barplot chart function

[x] choropleth_map.R file for choropleth  chart

[ ]  heatmap.R file for heatmap chart

All of these files should go into the /src folder

PR #16 adds in the Choropleth Map in choropleth_maps.r and Dropdown component in app.r

PR # 12 added the bar chart function in barplot.R and a rough app layout (with only bar chart included) - we can merge different versions of the app together later


Pythonic API for iteration

It would be neat to have a Pythonic API for iteration that let you write eg. for p in primes (rather than use a while loop)

@hickford - I think this issue can be closed, no? With the addition of the iterator from primesieve this is now possible I believe.

I agree.


Add support for default branch detection

If the --branch option isn't set, find and use the repo's default branch.

Addressed in PR https://dev.azure.com/mseng/TechnicalContent/_git/dotnet-docs-tools/pullrequest/577804


Handle incoming calls that are busy or offline

If a browser user has a call in progress, and another outside caller tries calling up the browser user, the outside incoming caller just rings continuously and eventually gets disconnected.
Instead, the outside incoming caller should enter a queue and have hold music waiting for the browser user to finish their current call. There should also be a spoken message like "The phone number you tried calling is busy. Please hold".
If the browser user is not available at all meaning their Twilio.Device is not ready or offline the incoming caller should be able to leave a voicemail message to the browser user. The spoken message for this should be "The phone number you tried calling is not available. Please leave a message".
Another idea would be to forward this incoming caller to a different browser user who is available. But this is only if more than one browser user exists. Otherwise maybe forward the incoming call to some other phone number like your actual cell / landline phone number as a backup.

This is outside the scope of basic functionality we want to include in the Quickstarts.
If you want to implement something like this, you have a few options.
Let's say you want to have a caller enter a queue if the Browser Device is busy:
Set up a new endpoint in app.py that is called something like '/no-answer. In that endpoint, you can use the <Record>, <Play> or <Enqueue> TwiML verbs.
Within your /voice endpoint in app.py, use the action attribute on your dial: dial = Dial(action="/no-answer")
The action attribute will fire a POST request to the specified URL when the call ends (or in this case, the browser client is busy).
If the Device is offline, you can also provide a fallback URL in your TwiML App. You can point that to another endpoint you create within this or another app or a Twilio Function or a TwiML bin. That's where you can play a message or prompt a caller to record a message.

Your team should make a set of non-quickstart github libraries in each of the programming languages to make something like what I am trying to express in these issues - one place to make and receive calls through the browser and have the other functionalities that a typical business phone system would have.
Does Twilio Flex seem to do most of what I am trying to express in these issues? Am I better off with that even though I am a 1 person business but in the future will likely expand? I imagine Flex would be more expensive than doing it through code. What about TaskRouter?
When I have time I will try to implement these things you are saying. I will let you know then if I need more assistance.

I'd love to chat with you about what functionalities you'd think would be highest value for customers to see in quickstarts/tutorials. Can you email me at the Twilio address in my profile?
Also, I'm the Developer Educator focused on Voice, so Flex is a bit out of my realm of expertise. I'd suggest reaching out to Twilio Support (there is a link on the top right called 'Talk to Support'). They may have a better idea of what would be best for your business needs.

Basically it is an all in 1 browser page to handle all your business call needs. I have seen something like this before at a previous company I worked for. Each username had something similar to this github project except it had more features. Basically replace an old fashioned physical business phone device where all business call needs would be done all from one page - put any type of call on hold, park the call, transfer the call to someone else, conferences (with or without entrance pins/passwords), etc. Somehow we gave customers 1 department phone number to call incoming and anyone who was logged in could take the call from that 1 department phone number.


Fix allow local url to be used as a link url (#275)

I just added logic for local url to be included as a url in link components.
I changed the type of the input to 'text' from 'url' and added custom pattern match.

I ended up opening a PR with a slightly different approach for this change #288. I added support for both relative URLs like /my/path/, as well as anchor links like #my-anchor, and added the ability for users to override/change the URL formatting behavior, in case they need to customize it. I'll close this out since it's not needed anymore, but thanks again for getting this started and opening the PR!


loading-bar on single DOM element

Is it possible to have loading bar on individual dom element. My view contains different sections which are fetched from http requests. I dont want to show the bar on entire page, rather show it on the div or span thats being fetched. Any suggestions?

+1

+1

+1

+1

+1

+1

+1

I've found that you can pass an (undocumented) parentSelector via the cfpLoadingBarProvider.parentSelector attribute.
I also had to change lastChild to firstChild on both line 209 and line 213 to get it to work correctly in my app. That's probably an implementation-specific issue though.

I have resolved the issue caused by the parentSelector implementation in pull 272.  Feel free to pull from me.


Change optional inputs of object detection model in Xcode

I cannot find documentation how to change the iouThreshold and confidenceThreshold Inputs for a Object Detection model generated with Turi Create 5.0b. Is there any information available on this topic?
What I tried so far is something along these lines:
let mlModel = object_detection().model
let visionModel = try VNCoreMLModel(for: mlModel)
let objectRecognition = VNCoreMLRequest(model: visionModel, completionHandler: output_handler_object_detection)

let requestOptions:[VNImageOption: Any] = [VNImageOption(rawValue: "confidenceThreshold"):0.1]
let ciImage = CIImage(cgImage: temp_img!)
let handler_features = VNImageRequestHandler(ciImage: inputImage!, options: requestOptions)

 do {
  try handler_features.perform([objectRecognition])
} catch {
  print(error.localizedDescription)
}

However, I do not see any change in the results. using VNImageOption was just a guess, and I do not get any error messages, regardless which rawValue I use.
Any help or info would be appreciated.

Hi @borderlineinteractive, it looks like the code examples we've provided that use the Vision API don't allow for those parameters to be set. I am tagging this issue as both a question and docs issue since I think we need to answer a few questions here in this thread, then update the docs. As far as I can tell, the open questions are:

Can we specify those parameters through the Vision API? (In general, is it currently possible to supply optional input parameters to a Core ML model through this API?)
2a. If so, how?
2b. If not, what is the alternative? Should users who need to pass in these parameters do so through the Core ML API directly? What would the alternative example code look like in this case?

Once the answers to these questions are determined we can update the docs.

It is unfortunately not possible today to change these parameters when making calls through Vision. The only alternative is to make the prediction directly through Core ML (predictionFromFeatures:error:). We should include a snippet for how to do this as well, to make it easier to switch over to this method.

@borderlineinteractive The current source code (which I think should be available in the latest 5.0b2 beta version), the function export_coreml takes optional arguments iou_threshold and confidence_threshold, where you can change the default values that go into the mlmodel file.
I agree that it is annoying to have to change all the prediction code to override these at runtime. We are definitely hoping to address this in the future. Sorry for the inconvenience!
By the way, more generally, the best way to open up an mlmodel and modify it is to use coremltools. Although, just a warning, this is not always trivial and can involve calling get_spec() on the MLModel and manually go through the protobuf object to change things. This can be tricky, but not as tricky as manually hacking the binary code. Hope that helps!

In the meantime, we can at least discuss this issue in the docs

Has there been any change on this issue? I am still unable to do this today for our iDetection app which uses a CoreML version of YOLOv3:
https://github.com/ultralytics/yolov3

@nickjong @gustavla @znation The model variables that we need to set on the fly at runtime, iouThreshold and confidenceThreshold are here in the NMS model, but I don't know how to programmatically modify them using Swift in Xcode. Can you help?

In the Xcode for the current betas (e.g. for iOS 13) you should now be able to specify these parameters at runtime, using new Vision framework API: https://developer.apple.com/documentation/vision/vncoremlmodel/3131933-featureprovider?language=objc
We can use this issue to track updating our User Guide with an example here


[ENHANCEMENT] add native support for Identity CORS configuration

Describe the use case:
This issue Invalid CORS Request is frequently occurring, especially with AWS ALB.
Describe the enhancement/feature:
Add native support the the 10.x helm charts to configure Identity CORS setting without using these undocumented env vars:
identity:
  env:
    - name: IDENTITY_CORS_ALLOWED_ORIGIN_PATTERNS
      value: *test.com,*another*.com
    - name: IDENTITY_CORS_ALLOWED_METHODS
      value: GET,POST

Which are in the config:
identity:
  cors-allowed-origin-patterns: ""
  cors-allowed-methods: ""

Desired outcome and acceptance tests:
### Tasks
- [ ]  I can reproduce Identity `Invalid CORS Request` error, e.g.: as shown in [SUPPORT-22437](https://jira.camunda.com/browse/SUPPORT-22437).
- [ ] I can configure Identity CORS setting in my values.yaml file without using env vars.
- [ ] After applying the new settings via `helm upgrade`, the Identity `Invalid CORS Request` error is resolved.
- [ ] No other Identity env vars are affected.

@jessesimpson36 Suggested a really good idea for this: a way to append any extra config without rebuilding the whole config, as we do in identity.configuration (also for all apps).


Purging Entities and Datasets

See this issue #666 for form and submission deletion. We need to handle dataset and entity deletion separately.

Since this would be a new feature that still needs to be fleshed out, I think we should close this issue and track the feature in the parking lot or future release criteria. This feature would probably require changes to Frontend as well.

I've made a note of this in the parking lot!


Request link lost from response function when exporting and re importing

Expected Behavior
If I have a request set up that uses a response function to get a value from the body of another response I expect that if I export and re import the function the request link should remain.
Actual Behavior
After exporting and re importing my request the request link cannot be found even though it is present in the json file that is exported.

Reproduction Steps
Create a GQL request
Created response function as part of Bearer auth
Export the entire project as insomnia V4 (json)
Delete the project and re import the json file
Inside the response function the request value is blank and an error message is shown "Could not find request"
Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
No response
Insomnia Version
2023.2.0
What operating system are you using?
macOS
Operating System Version
macOS Monterey
Installation method
Brew
Last Known Working Insomnia version
This worked in the previous version I had I assume 2023.1.0

Yes, I noticed this too. This can be very frustrating if you have a lot of environment variables and you need to set them all again after re-importing.
Notice: I think this bug occurs because the request (e.g. with id req_4b9ffe87e75f4ce2a476f9cddd3d541d) that is connected with the environment variable, does not exist anymore because it was deleted.
That means if you don't delete the insomnia collection before importing the json file (having two collections then), the environment variables work because the connected request is still there in the other collection that you didn't delete.
Currently I see the following solutions that could solve this:

Import the requests with the id specified in the json and don't create a new id when creating a request. Then the environment variables would be connected correctly to the request.
Change the export mechanism so the environment variables are not connected to the request via the request id but via another identifier?
When importing, somehow set the request id of the environment variables to the newly created request id.
See what has changed from the previous insomnia version, where this worked?

The same issue happens for me in test suites on a Windows 10 host.
I have a unit test which references a request by id in the JS code const response = await insomnia.send('req_436bfb93833b4cfd9ea188c1123076e3');. When I export->delete->import the document, this request, which are linked by id, will fail with failed to find request.

Seems like this is the same as the problem reported in https://github.com/Kong/insomnia/issues/5942. Request chaining is pretty broken at the moment.


Add Header template to remaining cairo contracts

I started a Discussion #49 about a contract header template:
# Contract title
#   Contract Description Line 1
#   Contract Description Line 2
#
# License

Here are the files I didn't feel confident in writing the title/description for. It's 3 lines total so should be pretty straightforward:
database/Storage.cairo
interfaces/IStorage.cairo
interfaces/ixoroshiro.cairo
utils/library.cairo
L03_Buildings.cairo
S03_Buildings.cairo
L05_Wonders.cairo
S05_Wonders.cairo

Just submitted PR #51 which covers most contracts

I took care of interfaces/ixoroshiro.cairo and utils/library.cairo


Fix autofill auto-disable for first time users

Task/Issue URL: https://app.asana.com/0/414709148257752/1202526099545584/f
CC: @GioSensation @THISISDINOSAUR
Description:
Fix issue where autofill was being disable once the user denied the save modal 3x.
This should only happen if the user disables 3x in a row for a first time user.
Steps to test this PR:

on a brand new app installation go to a website like https://news.ycombinator.com/login
Fill username/password
Reject the autofill modal to save it
Do the above 4x
On the 4th time, no prompt should be displayed to the user
Check under settings/autofill if autofill is disabled, it should

on a brand new app installation go to a website like https://news.ycombinator.com/login
Fill username/password
Reject the autofill modal to save it
Repeat the above, but on step 3 save the password instead of rejecting
Repeat steps 1-3 3x more (not saving it)
Autofill should be always enabled and prompting to save
Check under settings/autofill if autofill is enabled, it should

OS Testing:

[ ] iOS 14
[ ] iOS 15

Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@THISISDINOSAUR  I was testing the case where I never save anything and was still prompted every time
Just to confirm, was this from a brand new installation? Because if it was saved even once, it will never turn it off again.

@THISISDINOSAUR  I was testing the case where I never save anything and was still prompted every time
Just to confirm, was this from a brand new installation? Because if it was saved even once, it will never turn it off again.

Yeah, went through dad onboarding and everything, and saw the onboarding ui for autofill every time

The issue happens if the user dismiss the modal by tapping outside instead of "not now" or "X" button.
I'll move the conversation if this is a desired effect to Asana

On the Asana task it was decided that the way it's implemented in this PR is correct. i.e: ignoring the taps from outside the window when accounting for the dismissals.

Closing this PR since this behavior might change once the autofill design changes are done


message crypt() no salt parameters specified.you must use a randomly generated salt and strong hash function to a produce secure hash

This issue was opened on HHVM https://github.com/facebook/hhvm/issues/5021
The opinion seems to be this is a Laravel issue.
Basically our bugnsag on hhvm is catching an Exception from a warning
ErrorException crypt(): No salt parameter was specified. You must use a randomly generated salt and a strong hash function to produce a secure hash.
:0handleError
[internal]:0crypt
[internal]:0password_verify
vendor/laravel/framework/src/Illuminate/Hashing/BcryptHasher.php:45check
vendor/laravel/framework/src/Illuminate/Auth/EloquentUserProvider.php:108validateCredentials
vendor/laravel/framework/src/Illuminate/Auth/Guard.php:378hasValidCredentials
vendor/laravel/framework/src/Illuminate/Auth/Guard.php:359attempt
vendor/laravel/framework/src/Illuminate/Auth/Guard.php:263validate
[internal]:0call_user_func_array
vendor/laravel/framework/src/Illuminate/Support/Manager.php:138__call
src/SellerLabs/Snagshout/Auth/Authenticator.php:141run
src/SellerLabs/Snagshout/Auth/Controllers/AuthController.php:139postLogin

Why does this warning get raised to Exception? Is laravel not using the hash function with salt?

This appears to only be an issue with php 7.0 which is why laravel doesn't support it yet. HHVM seems to be implementing bits and pieces from php 7 which is why we observe this error.

To be more precise, this happens only when the password on your db is empty. This can be reproduced in hhvm using:
password_verify('hello', '')

Thanks guys. I'll get this sorted.

See https://github.com/laravel/framework/pull/9651.


The Road to 3.0

In order to release 3.0, we have some work ahead of us:

[ ] jekyll-paginate needs to be reworked per https://github.com/octopress/ink/pull/23
[x] Write octopress integrate
[x] Write octopress isolate
[x] image tag plugin
[x] pull_quote tag plugin
[x] video tag plugin
[ ] Documentation!

Anything else, @imathis? If we can get a comprehensive list here, then we can move forward more swiftly. Async.

@VirusKA Yes. I plan to work on a guide once I've finished the first new theme. I just posted a more lengthy comment on migration here

Update: I'm currently working on the new documentation site and things are coming together smoothly. One of the cool things I'm doing with the new Octopress is having each plugin be separate including their documentation. I've built a system that allows me to generate a website which sucks in the documentation from each plugin. The doc site is pretty barebones right now (no css even), but you can browse the documentation for lots of plugins.
To do that clone this repo, cd into site and run bundle then bundle exec jekyll server That should spin up a site where you can preview the documentation. At this point most plugins are simply adding their Readme and Changelog files.
Anyway, it's cool.

Oh and one more thing. If you're curious what "releasing 3.0" means, Here's a list of all the plugins that will be documented on the new site.
Each of these plugins are fully documented, tested, and feature complete aside from the Genesis theme (which is a work in progress) and Octopress Ink (which is done, but needs more documentation).

In the past couple of days I've released:

octopress-quote-tag
octopress-pullquote-tag
octopress-image-tag
octopress-video-tag

Each with tests and documentation. The documentation site is coming along (content-wise) and I think the last thing I have to do is finish that up and get the Genesis theme into a state where people might want to actually use it.
Things are looking good! I'm excited.

Piecemeal plugins, i.e. only-if-you-want-them optional? :smile:

Yep. People who have Octopress 2.0 sites will be able to get everything they need during the switch, but they'll have to add a lot to their gemfile—If they used that stuff. I'm eager to dispel the notion that Octopress is a different community from Jekyll. Making sure these work independently is an important part of that.

You are so awesome. :clap: :clap: :clap: :clap: :clap: :clap: :clap:

Alrighty. I've updated every single Octopress plugin. They now all have documentation, test and are automatically integrated into the new work-in-progress Octopress site. Other than some better documentation for Octopress Ink, the only thing I have left is to finish the Genesis theme.
Once those are done. I'll finish up the site, migrating whatever pages still make sense to keep from the old site. And then I'll be ready to replace imathis/octopress with this and do the release. Yay!

Hot damn!

I decided to count. There are 28 gems that are a part of this release. O.o. Exciting stuff.
@parkr you mentioned some headway on the pagination stuff. Any luck with that so far?

@parkr you mentioned some headway on the pagination stuff. Any luck with that so far?

I had made some headway but didn't like it. The struggle is the user interface – what is the best way to set this up? I reworked it to look like this:

Honestly, that looks really easy to configure. I'm guessing the default template for posts wouldn't be _posts/pager.html. Posts being different by default is maybe the only thing that may confuse users.

I was thinking about using _templates or some other "reserved" folder but now that there are custom collections, this isn't super possible. Maybe _layouts/pager.html would be better?

I know custom collections are a thing, but _includes, _layouts, _data, and _posts can't be reused for something else right now can they? It's probably too late to reserve other folder names, but it seems like as long as you can configure it, you should be okay with _templates. If not though, I think _layouts/pager.html works fine.

It's probably too late to reserve other folder names

That's how I feel right now. The more configuration we add, the harder it becomes to use so I'd rather not have yet another reserved folder name.

I think _layouts/pager.html works fine.

Another option is _layouts/templates/pager.html.

Another option is _layouts/templates/pager.html.

Of the suggestions, this is probably the least likely to interfere with an existing setup :+1:

It makes me wonder if I should change the way Octopress scaffolding works and use the same folder. Though, It's not really a layout per se.

say I wanted to whip up a quick site right now..
so I installed the Octopress gem, made a new site.
But I'm a bit lost - what would i do in place of the old octopress generate command?
Thanks for all your work on this. Can't wait to see the Genesis theme.

They are jekyll commands now.  to test via http://localhost:4000 you only need jekyll s.  If you are going to use the deploy option, do jekyll b; octopress deploy.
https://www.justinrummel.com/migrating-from-octopress-2-to-octopress-3/

Okay, that helps. Would there be any plans to still support octopress commands, even if it just translated them directly to underlying jekyll commands?

Personally I think they should be a 2.0 feature seeing as 3.0 isn't a replacement for Jekyll but something that goes along with it, having Octopress do the same commands that Jekyll is doing already seems a bit weird to me, KISS and all that.

I'm not planning to offer Octopress alternative to Jekyll command unless there is useful way I can augment the command. For example. octopress new . == jekyll new .; octopress init .. So far that's the only command I've seen the utility in coopting, and it directly references the Jekyll command, passing along options and all.

Okay, so what I'm getting is: learn Jekyll first, then use Octopress for extra features, like themes.

@daveheitzman Right on. Octopress is shifting away from being a thing that lives between you and Jekyll and towards being a cohesive ecosystem of plugins and UX enhancements for Jekyll.

Excellent.

Hi, Brandon, guys.
I have some questions, hope you can help ;)

do you have plans to integrate disqus comments to Octopress 3?
how to enable code highlighter with line numbers? I've installed codefence but still have the same look :(

If you're running your blog on a previous version of Octopress, you'll probably want to remove "@import "partials/syntax";" from your sass/_partials.scss file, then install octopress-solarized. That should do it for you.

@alec-c4 Oh, I forgot to answer your other question. On Disqus, I'd rather build a system that makes it easy to add whatever you want to your site. As I'm finishing up the new theme, I'll see how hard it is to manually integrate. If it's a pain, I'll probably build something.

hmmm, it looks like there are a lot of problems:
1 - I've reinstall Octopress with default config
on most of shel commands i see warning:
 octopress new alec-c4.com
/Users/alec/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/liquid-2.6.1/lib/liquid/htmltags.rb:43: warning: duplicated key at line 46 ignored: "index0"
New jekyll site installed in /Users/alec/Documents/Blog/alec-c4.com.
Added Octopress scaffold:
 + _templates/
 +   draft
 +   page
 +   post

as i understand - there are problems with liquid gem
2 - i've tried to install octopress-solarized theme. My gemfile looks like
source "https://rubygems.org"

gem 'octopress', '~> 3.0.0.rc.28'
gem 'rake'
gem 'octopress-deploy'
gem 'aws-sdk'

gem 'octopress-codefence'
gem 'octopress-linkblog'
gem 'octopress-ink'
gem 'octopress-solarized'

Also i've tried to wrap octopress-* gems with group :jekyll_plugins'.
My config looks like
# Site settings
title: Always Sleepy
email: my@email
description: > # this means to ignore newlines until "baseurl:"
  Notes of great and wonderful me :)
baseurl: "" # the subpath of your site, e.g. /blog/
url: "http://alec-c4.com" # the base hostname & protocol for your site
twitter_username: alec_c4
github_username: alec-c4

# Build settings
markdown: kramdown

gems:
  - octopress-codefence
  - octopress-linkblog
  - octopress-ink
  - octopress-solarized

exclude: [.bundle, bin, vendor]

I've added example code from codefence ready and it slit looks like http://take.ms/hqql3
You know - it looks like i have problems with gems loading. The same - with the themes.

And - i have no file sass/_partials.scss :(

@alec-c4 It looks like you probably haven't followed the installation instructions for octopress-solarized. You'll want to put {% css_asset_tag %} in your site's header to add the stylesheets. If you have further trouble, please file an issue at the octopress-solarized repository and I'll help you there.

If I were to create a new site right now, should I go with 2 or 3? Any idea when the first release of 3 will be?
Thanks for your great work!

I would say go with 3, I created a new site a few weeks ago using gems from 3 and have had no major problems.

3 has been released :)


Move ListVar into common, so it can be reused elsewhere.

Can we put this in a specific package please, not common.  If common is to have any valid rationale at all, it should be reserved for things which are genuinely an extremely common requirement.  This does not seem to fit that criterion.
I know that common is already down the slippery slope towards being a dumping ground for stuff that did not seem to fit anywhere else.  But the first step to addressing that is to stop making the problem worse.  And the problem of common is compounded by the fact that it is dot imported by various files.

Fair enough - any suggestions?  common/listvar?  common/flags?

Fair enough - any suggestions? common/listvar? common/flags?

It looks like it is specific to the mflag package.  Calling it just common/mflag would lead to an annoying clash.  So common/mflagext or similar.

@dpw PTAL

@dpw PTAL

Fine by me.


Eventname issue

Fix for events not handling exception in onEvent listener
Workaround for eventname not coming through (looks like first response is eventname, second response is data payload).

What was the issue here?

There were two issues:
https://github.com/spark/spark-sdk-android/issues/10
https://community.particle.io/t/android-subscription-event-is-getting-called-only-once/30054


RLPx onConnect and onDisconnect message

This is required for Status message to work.

Change RLPxStream message to enum with Connected, Disconnected and Message variation for Sink and struct for Stream.


Baseline updates for filter pushdown plan test after DRILL-6574

Need to be merged after Drill PR https://github.com/apache/drill/pull/1386

@rhou1 can you review this?

Denys, the plan introduces a sort.  Is this expected?

@rhou1 yes, sort is expected.

Yes, after the optimization (added limit just before scan), cost for StreamAgg + Sort + Limit + Scan is lower (40152.0 CPU and 16.0 memory) than it is for HashAgg + Limit + Scan (40161.0 CPU and 26.4 memory).

+1. LGTM. If Robert has no more concerns, we can have this merged.

+1.  Thanks for the explanation.

@rhou1 I think we merged this fix prematurely. I should have been merged after Drill PR apache/drill#1386 :) Now we can expect this test to fail.

I just opened a PR to revert it. Once the Drill PR is merged, we can revert the revert :)

Sorry, Boaz gave me the impression that this PR was preventing DRILL-6574 from being committed.  So I approved this PR and was in the process of updating the framework so Boaz could get a clean run.
I have stopped the framework update and approved the revert.

@denysord88 could you please open new PR with the same changes?

PR with the same changes https://github.com/mapr/drill-test-framework/pull/489 created

Created PR https://github.com/mapr/drill-test-framework/pull/490


Build time is too slow and executable is huge size.

I am fasinated with Nuitka because it converts *.py file to *.so (Native code)
Since few days I am trying Nuitka to make a successfull onefile binary.
Till now no success.

Every time buiding takes 45mins to 1 hour.
For the production even if a small correction on scource code and wanted to release the update
We have to wait for 1 hour.
I don't know why you convert all the deep scanned system libraries too ?
I am intested only my python modules are to be protected from bytecode and converted to *.so

Say I have 5 python modules (.py) and 1 main python file (.py).
How to make a single executable from Nuika
I need *.py to c to .so  only for these above 5 files.
Rest of the system modules can be bundeled as it is (.py)
So the build time will be smaller.

Please give me tips to reduce the build time and one single file output by converting my selected *.py to *.so

$  python3 -m nuitka --version
1.5.7
Commercial: None
Python: 3.7.3 (default, Oct 31 2022, 14:04:00)
Flavor: Debian Python
Executable: /usr/bin/python3
OS: Linux
Arch: aarch64
Distribution: Raspbian (based on Debian) 10
Version C compiler: /usr/bin/gcc (gcc).

It is recommended in this case to perform the build in a venv that only has the packages that you really need. Typically this issue is due to weird import logic within some packages that will cause Nuitka to pull in too many dependencies. Beyond that, you did not provide the list of packages that you are using and a short self contained example that takes so long to compile. Without commercial support, we are more strict about making sure all reports have all the information needed so we do not waste our time guessing.

The need to compile all code (convert) stems from using standalone mode. If you want a quick compilation, don't do it. Your 5 files will be really quick. And if you target a well known environment, they will work.

@Maxwell175

It is recommended in this case to perform the build in a venv that only has the packages

Thanks for your swift response.
First of all I do remote development between PyCharm and Raspberry Pi from Windows 10
In this situation PyCharm doesn't work well when I set venv at Raspberry Pi.
More over even if I have 1000s of packages on my system a cleaver project scan only should fetch only the packages used on the given project right ?
So I should not worry venv of global.

The need to compile all code (convert) stems from using standalone mode. If you want a quick compilation, don't do it. Your 5 files will be really quick. And if you target a well known environment, they will work.

@kayhayen
Thanks, I will further experiment to reduce the built time and built file size.

Wrong. A "clever" scan cannot detect optional dependencies being used just because they are there. For example, a bunch of code will use IPython if it's installed, which in turn will attempt to use every syntax highlighting framework on the planet, which will attempt to use all parsers, and also all web frameworks for rendering, and then all GUIs that are available from some of the dependencies.
If you are OK with slow Python startup from that, OK. But Nuitka is going to do the compatible thing, and make it happen on the end user machine too.
There is no way of knowing it. However, we do anti-bloat measures, namely to remove some dependencies by changing the code, to not use it. Some packages will still pull in e.g. IPython to your virtualenv, and we fight that with what we call anti-bloat. You are more than welcome to help there: https://nuitka.net/blog/tag/package_config.html
If you have something concrete, like an improvement, or observation, why you include a lot of stuff, fine. I personally develop in the full environment most of the time, and then try and do anti-bloat on those things. Then raise other issues, but I thnk this is not useful as it is now.

@kayhayen
Thanks again !
I generally avoid unnecessary arguments.
Always tell my experiance and opinions frankly.
My same project is also scanned by PyInstaller and build size in 10MB
I aggree Nuika crawls entire modules converts all the modules to native binary.
So 50% oversize is OK
But the output is 70MB size inside a huge folder.
(-onefile is set)
Inspite of that also the exe throw errors as this and that is missing.
Any how when I get time I will upload the samples.

Yes, bytecode is smaller, I am not surprised. Size is not a goal of Nuitka. Performance is. IP protection is for the commercial guys: https://nuitka.net/doc/commercial.html and that's size. The size of 70MB sseems good enough and mostly indistinguishable. There are people distributing 1GB of torch, they do not notice the difference.
So you stick with what is working for you, and you work with us to improve this. I am locking this, because I do not really think of this here as a chat forum. But you will be welcome on Discord.


Seventh day :/

Track your progress
write down what you are have learned so far celebrate each milestone i see you are crushing it