unable to install pyside with nix on osx sierra

Issue description
pyside is not compiling for pythin2.7
Steps to reproduce
I am new to nix, but got it working for imagemagick and other packages.
I got python, pip and wheel installed but if I try to install pyside using this command:
nix-env -i python2.7-pyside
I got a compiling error. I would expect all dependencies being downloaded and compiled.
The error looks like this:
1 warning generated.
4 warnings generated.
[  3%] Linking CXX shared library libpyside-python2.7.dylib
[  3%] Built target pyside
make: *** [Makefile:139: all] Error 2
builder for ‘/nix/store/8q7pafp19jzhaam07dj17rh5m5na12vc-python2.7-pyside-1.2.4.drv’ failed with exit code 2
error: build of ‘/nix/store/8q7pafp19jzhaam07dj17rh5m5na12vc-python2.7-pyside-1.2.4.drv’ failed

Nix looks awesome so far. Some help would be great, thanx in advance.
Technical details

System: osx sierra 10.12.4
Nix version: nix-env (Nix) 1.11.9
Nixpkgs version: 17.09pre107131.c882b967c1
Sandboxing enabled:  /etc/nix/nix.conf: No such file or directory

That error of course shouldn't happen. I'm not using Darwin so I can't help you much further here.
In any case, nix-env -i python2.7-pyside is not a supported workflow for Python on Nix. Please read the Python section in the Nixpkgs to find out how to install a Python environment.

Well, not sure if I did it right, most documentation seems to be outdated, but among other blogs and documentation I found this https://nixos.org/wiki/Python
Those are the packages I have installed when I run nix-env -q:
imagemagick-6.9.7-6
nix-1.11.9
nss-cacert-3.30
p7zip-16.02
python-2.7.13
qt-4.8.7
( qt-4.8.7 should not be needed, probably is detected as dependency already but I installed it just in case  )
When I do nix-env -qaP | grep pyside I get this :
nixpkgs.pysideApiextractor                                     pyside-apiextractor-0.10.10
nixpkgs.pysideGeneratorrunner                                  pyside-generatorrunner-0.6.16
nixpkgs.python27Packages.pyside                                python2.7-pyside-1.2.4
nixpkgs.python27Packages.pysideShiboken                        python2.7-pyside-shiboken-1.2.4
nixpkgs.python27Packages.pysideTools                           python2.7-pyside-tools-0.2.15
but as said, if I do nix-env -i python2.7-pyside or nix-env -i python2.7-pyside-1.2.4 doesnt work...

Here's the actual error:
/private/var/folders/vv/17b_hycx691699h20v458fnh0000gn/T/nix-build-python2.7-pyside-1.2.4.drv-0/PySide-1.2.4/plugins/customwidget.h:27:10: fatal error: 'QtDesigner/QtDesigner' file not found
#include <QtDesigner/QtDesigner>
         ^~~~~~~~~~~~~~~~~~~~~~~

To me that suggests that on Darwin, Qt is supposed to produce a .framework, and perhaps our common Qt builder doesn't build that. Someone more Qt-focused might want to chime in. Perhaps @periklis?

Installing pip, wheel, setuptools and qt and using pip to install pyside gives the same error. In case this helps anyone.
As a side note, I also had to fix some rights under the /nix folder. Suddenly I got no rights to write or remove some files ( nix-collect-garbage -d. and nix-env -i were failing because of that)

If you need the QtDesigner Headers then you should add qttools to your buildInputs. I patched a while ago the submodule qttools for qt-5/5.8 to work on darwin.

I don't need them. This is for pyside that is using qt-4.8.7.

But pyside needs qt and specifically qtdesigner from qttools. I am not sure if we even build qttools for 4.8.7

Yeah well I don't mind having the designer or other tools, but there is nothing I specifically need. With or without attools I don't mind.
That being said, if you need them for compiling pyside or qt you should solve that dependency...
In fact those may be gathered already (probably not the right version?)interesting test this, but sorry I cannot test right now

should be simple to fix this just the same for 4.8.7 right?

Oh boy, i don't understand a word of the last two comments. However, let me explain it again. In order to compile the package pyside you need qtdesigner, which i suspect that we would do not provide for qt 4.8.7 for darwin right now. What's next?
Please try to build qt-4.8.7 with nix-build on darwin and check if we you get qtdesigner.
Imho the only qt version in nixpkgs providing the qttools/qtdesigner stuff is qt5/5.8.

I think we understand each other very well.
I assume as well pttools are not working in qt-4.8.7.
The problem is I don't have the time to test this for you.

Pretty sure the tools are being built, as Qt Designer can be found at ${qt4}/bin/Designer.app/Contents/MacOS/Designer and successfully runs.
After changing makeFlags in pkgs/development/python-modules/pyside/default.nix to
makeFlags = [ "QT_PLUGIN_PATH=${pysideShiboken}/lib/generatorrunner" "VERBOSE=1" ];
I get the following log which includes the commands that make is running:
https://gist.github.com/Enzime/d24cc4910e0ddf02cba1fc43078b0e27
Of note is line 625, which has the command for compiling plugins/customwidgets.cpp the file where it fails to find <QtDesigner/QtDesigner>.
On this line you can find a clearly invalid path -iframework /nix/store/nd412ggfppsh7zwdml221psjkzznvycf-qt-4.8.7/include/nix/store/nd412ggfppsh7zwdml221psjkzznvycf-qt-4.8.7/lib.
After adding cmakeFlags = [ "-DALTERNATIVE_QT_INCLUDE_DIR=${qt4}/lib/QtCore.framework" ]; to to the pyside/default.nix, this leads to it correctly(?) generating -iframework /nix/store/nd412ggfppsh7zwdml221psjkzznvycf-qt-4.8.7/lib meaning that it now successfully finds <QtDesigner/QtDesigner> however the compilation fails later...
https://gist.github.com/Enzime/5a1e844358970533b8e11e1fbca1fc37

After noticing shiboken looking in the wrong directory for headers e.g. /nix/store/nd412ggfppsh7zwdml221psjkzznvycf-qt-4.8.7/lib/QtCore.framework/QtCore.framework/Headers/qglobal.h (line 516 in the previous log) I realized this was related to setting the ALTERNATIVE_QT_INCLUDE_DIR to ${qt4}/lib/QtCore.framework instead of just ${qt4}/lib.
After changing cmakeFlags I realized this now leads to the library being included as a system include dir instead of a framework include dir (-isystem as opposed to iframework) due to the Qt4 CMake Macros, so I had to add "-DCMAKE_CXX_FLAGS=-F${qt4}/lib" to cmakeFlags to get it to read the dir as a framework dir, effectively rendering the -isystem /nix/store/nd412ggfppsh7zwdml221psjkzznvycf-qt-4.8.7/lib generated by cmake useless.
This allows me to successfully compile pyside as well as syncplay.
However, whenever I attempt to run syncplay this leads to a segfault, potentially related to #31865 :/
https://gist.github.com/Enzime/ab6b6fd25581e87f062bfcf31146cb45
If anyone has another way of verifying that my instructions lead to a valid pyside compilation, I'd be happy to test.

Pyside 2/6 got packaged, gonna close this for now.


Database connection string "pg_opt" and "database" config options should not be used both

Please remove deprecated "pg_opt" from documentation.
Please check this is the only place.

Please also address #898
@LiraLemur Please consider to update example/config.sample and force Sphinx to load code sample from source-tree rather than copy contents to doc!

@kuvaldini the database too, right? The whole block? Or only the pg_opt?

"Database" is actual config, pgopt is old and deprecated.

@LiraLemur the best way is to load content from file  example/config.sample'

@kuvaldini it's possible for the general example but there's also a description part anyway, which is simply impossible to load and it's important.

The file should be loaded, description should forget about pg_opt and use corresponding config keys under "database" config tree

I will make it load the file but we need to load it from the default branch which is main atm and there there is no metrics yet.
Just FYI @kuvaldini
Should be fine when it's merged into the main though

For branch support/1.2.x or any other please use config.sample exactly from the same branch. NOT from main. That is important.
This does not touch anything about metrics.


Rename server that is part of Azure File sync

I have on-prem fileserver.old and fileserver.new
My plan is to migrate from fileserver.old to fileserver.new by syncing from old to Azure, and while fileserver.old is online sync from Azure to cache on fileserver.new.
When sync to fileserver.new is completed, i would like to shutdown fileserver.old and rename fileserver.new to fileserver.old - this way nothing has to be changed on the client side.
Will that server rename break sync?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 534b3ef3-5664-973e-b146-8c1f960bf536
Version Independent ID: 57c3ce18-2857-8ed0-10a5-5061d391a079
Content: Frequently asked questions (FAQ) for Azure Files
Content Source: articles/storage/files/storage-files-faq.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@oletho Thank you for your query, our team will review it and get back to you at the earliest.

@oletho  As I understand: Prior to Azure File Sync agent version 3, Azure File Sync blocked the move of tiered files outside the server endpoint but on the same volume as the server endpoint. Copy operations, moves of non-tiered files, and moves of tiered to other volumes were unaffected. The reason for this behavior was the implicit assumption that File Explorer and other Windows APIs have that move operation on the same volume are (nearly) instantaneous rename operations.
If you don't need that server, then you can safely delete the server endpoint
I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Support PixelMode::LcdV

This seems to work to me.  +1

Works for me, too

works for me and would close #1039


Create Database Artifacts Using Core Data Services (CDS) for SAP HANA Cloud - issues with tutorial

Tutorials: https://developers.sap.com/tutorials/hana-cloud-cap-create-database-cds.html
Write here what you need help with ...
Following along with this great tutorial mission but have come across two issues.

The initial deployment of db artefacts to HANA Cloud fails because after we do Hana-cli createModule we are not instructed to log into the db directory and run npm install
Something is not right with the way things work with hdi containers. Once I have successfully deployed the db module (from the rocket ship icon at db level) and I then try to directly navigate to the DB Explorer... the navigation fails saying it could not find the hdi container. I have found that in the db explorer you can tap + (add db) and find the hdi container and add it. You can then see all your deployed artefacts. but if you go back to BAS and click DB Explorer again the navigation still fails even though the hdi container does show. Also the hdi container generated has a different name for those shows in the tutorial. Mine is generated as: MyHANAApp-hdiMyHANAApp-db-deplpoyer-ws-zhk69 where the tutorial states that they should be names something like SharedDeveKey@MyHANAApp-hdiMyHANAApp-db-deplpoyer-ws-zhk69.

For item 1 above we could easily add the /db npm I step to the tutorial. But for item 2 I don't know. I have gone over what I did a second time and the same thing happens where the reality is different to what is shown in the tutorial. Any ideas?
;-)

The npm install command isn't necessary. The deploy action (rocket icon) from the SAP HANA Projects view will run npm install automatically.  See the video: https://youtu.be/hlHY7eBriRA?t=589
Notice right before I hit deploy there is no node_modules folder in /db:

But then you can see in the video that the the deploy task is running npm install: https://youtu.be/hlHY7eBriRA?t=598

I just re-tested this just now. I deleted the node_modules folder and package-lock.json from my /db folder.

And then just pressed the rocket icon - it does exactly as it did in my earlier tutorial run through in the video. It senses that the content is missing and runs the npm install automatically:

On the second part, you should not have to manually add the entry to the DB Explorer When you click the Open HDI container option from the SAP HANA Projects view, it creates the entry in the DB Explorer for you.
https://youtu.be/hlHY7eBriRA?t=670
I also just now retested the Open HDI container option too. I first deleted my entries from the DB Explorer.  I then press the Open HDI container option form the SAP HANA Projects view.  It did just now exactly what is shown in the video. It adds the entry to the DB Explorer that starts with SharedDevKey and navigates to/expands it.
I'm afraid I'm unable to recreate either scenario you describe. Upon retesting they both flow exactly as shown in the original video.

Thanks for the detailed reply Thomas. I run this only an hour ago and the build would keep failing and I noticed it was a missing dep. Ran the npm i manually and it worked. Lets just close this then but something must have glitched for me.   ;-)

I have just tried repeatedly and the hdi container is not automatically navigated to.... Could it be because you are testing with a trial account and I am using a production account (feature set A) ?

I am testing in trial because that is primarily what the tutorial is designed for. I'm not sure what would be different about this scenario in production accounts. Perhaps you lack the developer rights to the target space? The trial onboarding process does ensure that your developer rights are granted automatically. However I would have expected without the correct rights you wouldn't have been able to create the service instance at all in the earlier step. Maybe you are getting logged into Database Explorer with a different user identity then what you are using to connect manually to CF during the earlier wizard. That's the only way I could explain have the rights to create the service instance but not "See" it from Database Explorer.

Hmm the different user thing could be a possibility - will look into that now. As it is though I can (+) to add the hdi container and then everything works as per normal and my app runs just fine.


Unresponsive/ overflow of stat table for smaller devices

Describe the bug
Overflow of the table in smaller devices.
To Reproduce

Run application.
Right-click to inspect.
Change view to 375px * 667px (iPhone7/8)
Expected behavior
The table which displays COVID stats should not overflow horizontally

Screenshots

Additional context
Add any other context about the problem here.

I am sending PR solving this issue.


Can not publish datafusion-cli package to crates.io: expected at most 5 keywords per crate at line 1 column 3441

Describe the bug
While trying to publish the datafusion-cli package to crates.io I got the following error:
(arrow_dev) alamb@MacBook-Pro:~/Downloads/apache-arrow-datafusion-6.0.0$ (cd datafusion-cli && cargo publish)
....
    Finished dev [unoptimized + debuginfo] target(s) in 1m 20s
   Uploading datafusion-cli v5.1.0-SNAPSHOT (/Users/alamb/Downloads/apache-arrow-datafusion-6.0.0/datafusion-cli)
error: failed to publish to registry at https://crates.io

Caused by:
  the remote server responded with an error: invalid upload request: invalid length 7, expected at most 5 keywords per crate at line 1 column 3441

To Reproduce
 (cd datafusion-cli && cargo publish)

Expected behavior
Upload should work

bad news is if we need to release a new version of datafusion cli, we will need to bump datafusion to 7.x because we have breaking change already merged since 6.0.0 :( @alamb @andygrove @Jimexist @Dandandan  what do you think about moving cli also out of the core repo so it can be released at a higher frequency?
Alternatively, we could vote for a datafusion 6.1.0 release, but not actually publishing the core to crates.io to avoid releasing breaking change.

bad news is if we need to release a new version of datafusion cli, we will need to bump datafusion to 7.x because we have breaking change already merged since 6.0.0 :( @alamb @andygrove @Jimexist @Dandandan what do you think about moving cli also out of the core repo so it can be released at a higher frequency?

I think we could make a special datafusion-cli release branch (and branch from the 6.0.0 tag) and apply whatever changes were needed rather than having to release whatever is on master .
I find datafusion-cli very useful so I would like to keep it in the arrow-datafusion repo.
However, we could potentially just release it under a different versioning scheme, which might make sense too
https://crates.io/search?q=datafusion-cli

good idea, a special release branch also works :+1:


./configure requires download_from_google_storage

Loading required submodules...
Downloading GN from cloud storage...
Required command not found: download_from_google_storage

@TheModMaker, is this because of a missing install of depot_tools?
@clementgenzmer, do you have depot_tools installed?  (See https://github.com/google/shaka-player-embedded#setting-up-for-development)


[scripts][forge] write fgi in python and edit job in place

Motivation
Re-write fgi in python.
The motivation for python re-write:

Shell script was useful for MVP, but an actual language would make it easier to maintain going forward
vs rust, we really want a scripting language that's easy to run from a fresh environment. Python with its standard library is good for this.
Easier access to kube API and fetching templates via JSON to parse
Extensibility too. In the future if we see increased use of forge on k8s, we can implement cluster locking with s3 again.

Aside from the re-write in a different language, there are a few notable differences:

fgi edits the forge k8s job template rather than creating a singular pod whose lifecycle is managed completely by fgi. The job has a backoff limit of 0 for simplicity, meaning that it won't restart upon failure (this can probably be controlled programatically via fgi in the future, but would require some change in the way we determine a cluster's availability)
Removed the ability to build and push images locally for now for simplicity. I don't want to add a new script, or to edit the existing one and share between cti and fgi. Currently fgi can build images from PR, or use existing image by tag.
changed file paths, but otherwise maintain backwards compatibility of the commands/args. Command is invoked as scripts/fgi/run instead of scripts/fgi
a fancy new ascii art!

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run fgi with various options:
Help
$ ./scripts/fgi/run --help
usage: run [-h] [--timeout-secs TIMEOUT_SECS] [--workspace WORKSPACE]
           [--env ENV] (--tag TAG | --pr PR | --local-swarm)

Entrypoint for the Forge unified testing framework

optional arguments:
  -h, --help            show this help message and exit
  --timeout-secs TIMEOUT_SECS
                        Timeout for the Forge pod in seconds
  --workspace WORKSPACE, -W WORKSPACE
                        Workspace or kubernetes cluster to run Forge on,
                        rather than picking one at random
  --env ENV, -E ENV     Extra environment variables to pass to Forge
  --tag TAG, -T TAG     Image tag to use in kubernetes Forge tests
  --pr PR, -p PR        PR to build images from for kubernetes Forge tests
  --local-swarm, -L     Run Forge tests locally instead of on a kubernetes
                        cluster

Run with existing tag on kubernetes
$ time ./scripts/fgi/run -T dev_rustielin_pull_8674

    __________  ____  ____________
   / ____/ __ \/ __ \/ ____/ ____/
  / /_  / / / / /_/ / / __/ __/
 / __/ / /_/ / _, _/ /_/ / /___
/_/    \____/_/ |_|\____/_____/

Running Forge on backend: kubernetes testnet

Attempting to reach Forge Kubernetes testnets...
Updated context arn:aws:eks:us-west-2:853397791086:cluster/libra-rustietest in /Users/rustielin/.kube/config
Grabbing a testnet...
Running experiments on cluster: rustietest

Specfile: /var/folders/h2/5s1_h_yj343_wn3cg1_fx0yw0000gn/T/tmpmidk83mp.json
Creating job: forge-rustielin-1625095319
job.batch/forge-rustielin-1625095319 created
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
Waiting for forge-rustielin-1625095319 to be scheduled. Current phase: Pending
forge-rustielin-1625095319 reached phase: Running

**********
Auto refresh Dashboard: http://mon.rustietest.aws.hlw3truzy4ls.com/d/overview/overview?from=1625095348484&to=now&refresh=10s&orgId=1
**********

Log output: /var/folders/h2/5s1_h_yj343_wn3cg1_fx0yw0000gn/T/tmpv35m88y9
==========begin-pod-logs==========
deployment.apps/coredns scaled
Downloading and installing helm-s3 v0.10.0 ...
Checksum is valid.
Installed plugin: s3
"testnet-internal" has been added to your repositories
NAME                            CHART VERSION   APP VERSION     DESCRIPTION
testnet-internal/diem-fullnode  1.3.0           1.3.0
testnet-internal/diem-validator 1.3.0           1.3.0           Diem blockchain validator
testnet-internal/testnet        0.1                             Additional components for a multi-validator tes...

running 4 tests
Starting to serve on <IP_ADDRESS>:8001
Local kube pod healthcheck passed
test fund_account ... ok
test transfer_coins ... ok
test get_metadata ... ok
Will use 10 workers per endpoint with total 40 endpoint clients
Will create 15 accounts_per_client with total 600 accounts
Creating and minting faucet account
DD account current balances are<PHONE_NUMBER>504717807, requested 600000000 coins
Completed minting seed accounts
Minting additional 600 accounts
Mint is done
starting emitting txns for 10 secs
Test Statistics: emit_transaction : 540 TPS, 1180 ms latency, 1450 ms p99 latency,no expired txns
test emit_transaction ... ok

test result: ok. 4 passed; 0 failed; 0 filtered out

==========end-pod-logs==========

**********
Dashboard snapshot: http://mon.rustietest.aws.hlw3truzy4ls.com/d/overview/overview?from=1625095348484&to=1625095386085&orgId=1
**********

Job forge-rustielin-1625095319 succeeded!
./scripts/fgi/run -T dev_rustielin_pull_8674  13.84s user 7.22s system 29% cpu 1:12.56 total

Run with local swarm
$ ./scripts/fgi/run --local-swarm

    __________  ____  ____________
   / ____/ __ \/ __ \/ ____/ ____/
  / /_  / / / / /_/ / / __/ __/
 / __/ / /_/ / _, _/ /_/ / /___
/_/    \____/_/ |_|\____/_____/

Running Forge on local swarm backend
    Finished dev [unoptimized + debuginfo] target(s) in 0.74s
     Running `target/debug/forge --local-swarm`

running 5 tests
Wait for startup attempt: 0 of 10
rpc error: error sending request for url (http://localhost:58614/metrics): error trying to connect: tcp connect error: Connection refused (os error 61)
Wait for startup attempt: 1 of 10
Wait for connectivity attempt: 0
test fund_account ... ok
test transfer_coins ... ok
test get_metadata ... ok
Restarting node 652F27413456938EAA059F65231647CC
test restart_validator ... ok
Will use 10 workers per endpoint with total 10 endpoint clients
Will create 15 accounts_per_client with total 150 accounts
Creating and minting faucet account
DD account current balances are<PHONE_NUMBER>854773807, requested 150000000 coins
Completed minting seed accounts
Minting additional 150 accounts
Mint is done
starting emitting txns for 10 secs
Test Statistics: emit_transaction : 15 TPS, 14884 ms latency, 14900 ms p99 latency,no expired txns
test emit_transaction ... ok

test result: ok. 5 passed; 0 failed; 0 filtered out

/land

:broken_heart: Test Failed - ci-test

/land


Change regex to package

Fixes #27

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #30   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      1    -1
  Lines          75     74    -1
=====================================
- Hits           75     74    -1

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b1ce9...bc1f914. Read the comment docs.


Support for overwriting styles

Hi! Is there a way to overwrite/extend the styles of a component of a similar way Material UI v1 does with its approach overwrite with classes?
I am building a simple UI framework and I would like to support that in the components, something like this:
import React from 'react';
import ReactDOM from 'react-dom';
import withStyles, { ThemeProvider } from 'react-jss';

const buttonStyles = (theme) => ({
  root: {
    border: '1px solid ' + theme.color,
    color: theme.color,
    backgroundColor: theme.backgroundColor,
  }
});

// This component would have the styles:
// root {
//   color: #f40b85;
//   border: 1px solid #f40b85;
//   background-color: #ffffff;
// }
const Button = withStyles(buttonStyles)(({ classes, children }) => {
  return (
    <button className={classes.root}>{children}</button>
  );
});

const customButtonStyles = (theme) => ({
  root: {
    color: '#ff0000',
    fontWeight: 'bold',
  }
});

// This component would have the styles:
// root {
//   color: #ff0000;
//   border: 1px solid #f40b85;
//   background-color: #ffffff;
//   fontWeight: 'bold',
// }
const CustomButton = withStyles(customButtonStyles)(Button);

const App = () => {
  return (
    <div>
      <Button>Default Button</Button>
      {' '}
      <CustomButton>Custom Button</CustomButton>
    </div>
  );
};

const theme = {
  color: '#f40b85',
  backgroundColor: '#ffffff',
};

ReactDOM.render(
  <ThemeProvider theme={theme}>
    <App />
  </ThemeProvider>,
  document.querySelector('#root')
);

Which would render something like this:

Is there a future plan release with this support or a PR would be required? Thanks in advanced.

Do you mean something like this? https://twitter.com/oleg008/status/930186426574098432

Ah you mean a component that has been wrapped by injectSheet hoc to be rewrapped by another injectSheet hoc? I think you can do it already.

@kof yes! But with the exact code I posted doesn't work. How can I accomplish this? Or should I create another HOC to handle that situation?

If that is not supported, would it be a good idea to support it with react-jss HOC? Or should it be another HOC?

classes object is merged, so if you overwrite one property, just one property is overwritten. React-JSS doesn't merge though multi class strings {a: 'a'} > {b: 'b'} => {a: 'a', b: 'b'}, but if there is  {a: 'a b'} > {a: 'c'} => {a: 'c'}

Awesome! Then how do I implement it? Because the example above didn't work. Thanks!

I am gonna research how can I accomplish this. Thanks @kof !


KAFKA-16745: Implemented handleShareFetchRequest RPC including unit tests

About
Implemented handleShareFetch request RPC in KafkaApis.scala. This method is called whenever the client sends a Share Fetch request to the broker. Although Share Fetch request support acknowledgements, since the logic for acknowledging records is not completely implemented in SharePartitionManager.java class, this method currently includes placeholder code for acknowledging, which will be replaced by the actual functionality in the upcoming PRs.
Testing
Added unit tests to cover the new functionality added in KafkaApisTest

Hi @junrao . Thanks a lot for the review. I have made the required changes in the last commit. I have also left some replies to your comments, it will be really helpful if you could leave your suggestions there.

Hi @junrao, thanks a lot for the review. I have made the changes suggested by you. Also, I have replied to some of your comments and have left those conversations unresolved above. Could you pls take a look at those and let me know if anything else is required. Thanks a lot !
P.S. - I am looking into the test failure

Hi @junrao , looks like the sharePartitionManager wasn't being closed on the broker shutdown. I have pushed in a new commit with the changes, it should work now. Is there any other remaining gap in the PR ? If not can I get an approval on it ? Thanks a lot for all the suggestions !

@junrao : Looks like the tests are passing now, a couple of them fail probably because they are flaky


SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3

https://issues.apache.org/jira/browse/SOLR-17066
Description
SOLR-17066 introduced a withDefaultCollection builder method that can be used in lieu of providing a core URL as a "base".  (Core URLs are not ideal as they prevent clients from making core-agnostic requests.)
However, Solr's own client usage still needs modified to use this new builder method.
Solution
Please provide a short description of the approach taken to implement your solution.
Tests
This PR tackles this for all remaining usages of HttpSolrClient in Solr's codebase, including solrj's tests and the test-framework module.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.

This all LGTM....

gradlew :solr:core:test --tests "org.apache.solr.cloud.TestPrepRecovery.testLeaderNotResponding" -Ptests.jvms=96

[...] -Ptests.jvms=96 [...]

🤯 Man, easy to forget sometimes that these "Crave.io" machines are just absolute monsters.
Thanks for pointing out the failure @iamsanjay .  According to fucit, TestPrepRecovery is pretty flaky - it's been failing on between 5 and 10% of runs since November or so.  So my guess is that it's not directly caused by anything in this PR.  But I'll kick off some 'beast' runs on it locally and try to find out.  Will update this ticket shortly.
(If you're not familiar with "fucit", it's a really helpful test-aggregator that Chris Hostetter (who goes by "Hoss man") runs for us.  It gathers the test-reports from a bunch of Jenkins and other CI builds, and keeps track of how healthy or unhealthy each individual test has been historically.  It links out to the Jenkins builds for each failure so you can look at specific failures.
Really really helpful stuff if you haven't seen it.)


Feature-Request: Discard items only if Bag is full

Discard the items only if the Bag is full and not after every loot. This would be better in two ways:

more human-like behavior - nobody would discard 1 item after every loot
if you have set a maximum of 100 of each balls, the bot discards the pokeballs even if there is enough space in the bag. this is a waste of resources, you might need these balls until your bag is actually full.

What do you think?

To expand on this, I'd also propose keeping a priority list. When bag is full, throw away potions first, then revives, weakest balls and so forth as to maximize bag utility for the task one gives to the bot. For example potions are really useless for the bot and I keep them out of the inventory by keeping exactly 0 of echa kind, same with revives. but it sometimes throws away ultraballs because of the limit of 120 I set on them, but I'd rather have it throw away pokeballs, because they're so abundant.

#2219
Oops, dupe, seems my search didn't pick up this item. +1
Note mine has additional suggestions/comments for consideration

I changed this in my fork in seen_fort_worker.py


Forecast Question

Hi, First of great script.
Question, is there any way to limit the forecast on how many days to show? and not show all 10 days.

Yep, you can change for(var i=0;i<weather.forecast.length;i++) { to something like for(var i=0;i<3;i++) { to only show three days. A quick note on this is that if the API returns less than the number of days you put (ex: if you put 6 but the api for some reason returns 5) it would error out. In most cases you should be good but you can always add a check to make sure the weather.forecast.length is <= whatever number you put.

Thanks just what I need


Random generators are using default seed

There seem to be many places where boost random number generators are instantiated (e.g. boost::mt19937 rng; in simulate_count_covariance) but without a specified seed.  So the default seed for the generator is used.  Seems like they should be seeded with some function of the user-defined --seed value.  I noticed this because I see some isoforms for which the coverage estimate varies a lot when the BAM is perturbed slightly, but which do not vary when --seed is varied.
Ben

It turned out that the variability I was seeing was probably because of the empirical read/fragment length distribution and a problem with how it's used in the bias correction code:
https://github.com/cole-trapnell-lab/cufflinks/pull/32
But the random number generator seeding issue stands.

would there be any value in using the built-in RNG available with c++11 or newer standards? I think it provides for seed generation.
http://en.cppreference.com/w/cpp/numeric/random


Add suport for horizontal rule in Markdown

This feature will enhance current Markdown parsing to include <hr> tag when file contains ---

Closed by b6c26ed517518be7209899a88aca2f12036b73ab


Update fragment_slide.xml

margin is not reflecting. so changed those to padding. (Check layout bounds for proof)

Can someone please merge this? Having the text go all the way to the edge of the screen looks ugly:


Migrate Health Insights tests to use Federated Auth

Migrates Health Insights to use federated auth in live tests. For more information, see here.

/azp run java - healthinsights - tests

/azp run java - healthinsights - tests


Create MoveIt Drake tutorial

Would be nice to have a tutorial either here or in moveit2_tutorials.

Closing in favor of #48


Initial docs for DOM static resource loading functions

Add docs for the Float imperative functions: preconnect, prefetchDNS, preinit, preinitModule, preload, preloadModule.
@gnoff  Please read with a close eye for accuracy.
https://react-dev-git-fork-davidmccabe-float2-fbopensource.vercel.app/reference/react-dom#resource-preloading-apis
I think these are still canary only, is that correct?

I was looking for this documentation!
Let me explain my use case to hopefully give more priority to this documentation :)
We are using Next.JS (14.0.5-canary.5) with React (18.2.0) and have tried using the Image component.
It contains a preload function and all kinds of niceties about srcset.
However, it did not meet our requirements, because it does not work with our WordPress API / CDN setup.
We are tied to use <picture> with <source>'s because of our complicated art direction, instead of Next's <img> with sizes.
This means that we also have to take care of our own image preload.
Next briefly noticed this preload function in it's meta docs, but not all of the options.
It's thanks to TS I discovered the preload options are available, as Next and React did not document those yet.

In addition, I feel free to draw attention to this PR:
https://github.com/facebook/react/pull/27129
Adding media option to preload function.
The component I am working on is a hero image (LCP) and must therefore be preloaded with the highest priority.
The preload also needs to know which <source> is loaded into <picture>, depending on the media query.
This preload media query cannot yet be configured in any way.

This isn't related to the documentation per se, but since these resources aren't disposable, perhaps the docs could include information about what one wants to do if one wants to avoid memory leaks? Is cleanup React's responsibility? Are these scoped to the tree from which preconnect etc. are called? Presumably not, since they seem to be callable imperatively?
In addition, what happens if the cryptographic hash doesn't match? Is this exposed to the user anywhere?


Responsive Main Menu

The main menu at the top of the screen is not responsive enough. On phone screens you cannot see all the buttons. It is common for menus like this to change to a burger menu on small screens.
Implement a system like this. We may have to move from semantic UI.
The current button highlighting and button hiding whilst logged out should continue to work.

https://github.com/Semantic-Org/Semantic-UI/issues/3588 we might instead just do it the way they suggest: hide the sticky navbar and use the side bar instead when on smaller screens, instead of having to move away from Semantic UI

Nice find @themakshter - looks like a good solution :+1:

I could try it out. All though I tried and failed in implementing this a few months ago. But I've improved.

It would need to be something like an option set in the header component to only change the way the list is created, nothing more should be changed. It will be interesting. I can also try checking out and see which way is the best.

I'm building a platform with semantic ui and I noticed this too. I still like Semantic ui, maybe I will try what was suggested.

In short, no need. I will just customize responsiveness with CSS.

Any chance this is taken by someone. I would finally like to work on a frontend issue of impactasaurus.

doesn't look like it :)

Can I use basic css or should I try and find a Semantic ui Solution? I'm searching for the second one as I feel that a more generalized one but just wanted to make things clear.

I think trying to find a Semantic UI solution would be best

Decided to keep this simple, now the menu will fallback to icons on smaller screens.

Sounds good


Support for Vapor 3

There’s a vapor 3 branch. It’ll be merged to master once V3 is released.
Sent with GitHawk


IR explosion on big linalg.generic reduction

What happened?
The following code freezes iree-compile for multiple minutes, generating huge dump with --mlir-print-ir-after-all and eventually fails to compile:
#trait2 = {
  indexing_maps = [
    affine_map<(i, j) -> (i, j)>,  // a
    affine_map<(i, j) -> (i, j)>,  // b
    affine_map<(i, j) -> (0, 0)>   // x (out)
  ],
  iterator_types = ["reduction", "reduction"]
}

func.func @test() {
  %lhs = util.unfoldable_constant dense<1.00> : tensor<3456x2048xf16>
  %rhs1 = util.unfoldable_constant dense<0.01> : tensor<2048x1024xf16>
  %rhs2 = util.unfoldable_constant dense<0.01> : tensor<2048x1024xf16>
  %res = util.unfoldable_constant dense<0.01> : tensor<1x1xf16>
  %c0 = arith.constant 0.0 : f16
  %rhs = linalg.generic #trait2
     ins(%rhs1, %rhs2: tensor<2048x1024xf16>, tensor<2048x1024xf16>)
    outs(%res: tensor<1x1xf16>) {
      ^bb(%a: f16, %b: f16, %x: f16):
        %0 = arith.mulf %a, %b : f16
        %1 = arith.addf %0, %x : f16
        linalg.yield %1 : f16
  } -> tensor<1x1xf16>
  check.expect_almost_eq_const(%rhs, dense<20.2822> : tensor<1x1xf16>) : tensor<1x1xf16>
  return
}

Steps to reproduce your issue
iree-compile --iree-hal-target-backends=vulkan-spirv test-reduction.mlir --mlir-print-ir-after-all --iree-vulkan-target-triple=rdna3-unknown-unknown -o test.vmfb > out.txt 2>&1
What component(s) does this issue relate to?
No response
Version information
bb7e536ecd31ea24007aa7202f3a0c41b897e05c
Additional context
SPIRVInitialVectorLowering pass causes IR explosion with a lot of repeated lines:
...
      %11439 = arith.addf %5296, %11438 : vector<4xf16>
      %11440 = vector.insert_strided_slice %11439, %11437 {offsets = [132], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11441 = vector.extract_strided_slice %arg1 {offsets = [136], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11442 = arith.addf %5299, %11441 : vector<4xf16>
      %11443 = vector.insert_strided_slice %11442, %11440 {offsets = [136], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11444 = vector.extract_strided_slice %arg1 {offsets = [140], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11445 = arith.addf %5302, %11444 : vector<4xf16>
      %11446 = vector.insert_strided_slice %11445, %11443 {offsets = [140], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11447 = vector.extract_strided_slice %arg1 {offsets = [144], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11448 = arith.addf %5305, %11447 : vector<4xf16>
      %11449 = vector.insert_strided_slice %11448, %11446 {offsets = [144], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11450 = vector.extract_strided_slice %arg1 {offsets = [148], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11451 = arith.addf %5308, %11450 : vector<4xf16>
      %11452 = vector.insert_strided_slice %11451, %11449 {offsets = [148], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11453 = vector.extract_strided_slice %arg1 {offsets = [152], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11454 = arith.addf %5311, %11453 : vector<4xf16>
      %11455 = vector.insert_strided_slice %11454, %11452 {offsets = [152], strides = [1]} : vector<4xf16> into vector<8192xf16>
      %11456 = vector.extract_strided_slice %arg1 {offsets = [156], sizes = [4], strides = [1]} : vector<8192xf16> to vector<4xf16>
      %11457 = arith.addf %5314, %11456 : vector<4xf16>
...

@Hardcode84 I am looking at this issue. I am confused about %lhs. It does not appear to be used. Where is this mlir code coming from?
Secondly, I reduced the tensor dimensions to find a smaller example that demonstrates the fail. When I rescaled from 2048 to 128 (and accordingly the other dimensions) the compile finished and a vmfb file was created. With the slightly larger 2048->144 scaling the error still showed up.
Next, I tried to reduce the example to an 8x4 tensor. This also produces a vmfb file all right, but I get a fail during execution. In detail:
#trait2 = {
indexing_maps = [
affine_map<(i, j) -> (i, j)>,  // a
affine_map<(i, j) -> (i, j)>,  // b
affine_map<(i, j) -> (0, 0)>   // x (out)
],
iterator_types = ["reduction", "reduction"]
}
func.func @test() {
%lhs = util.unfoldable_constant dense<1.00> : tensor<9x8xf32>
%rhs1 = util.unfoldable_constant dense<0.01> : tensor<8x4xf32>
%rhs2 = util.unfoldable_constant dense<0.01> : tensor<8x4xf32>
%res = util.unfoldable_constant dense<0.01> : tensor<1x1xf32>
%c0 = arith.constant 0.0 : f32
%rhs = linalg.generic #trait2
ins(%rhs1, %rhs2: tensor<8x4xf32>, tensor<8x4xf32>)
outs(%res: tensor<1x1xf32>) {
^bb(%a: f32, %b: f32, %x: f32):
%0 = arith.mulf %a, %b : f32
%1 = arith.addf %0, %x : f32
linalg.yield %1 : f32
} -> tensor<1x1xf32>
check.expect_almost_eq_const(%rhs, dense<20.2822> : tensor<1x1xf32>) : tensor<1x1xf32>
return
}
(I kept that %lhs just to be consistent, though it is not used.)
The runtime gives me:
iree/runtime/src/iree/tooling/function_io.c:387: UNIMPLEMENTED; unimplemented cconv type v; parsing input 8x4xf32=[[0,1,2,3],[4,5,6,7],[8,9,10,11],[12,13,14,15],[16,17,18,19],[20,21,22,23],[24,25,26,27],[28,29,30,31]]; parsing function inputs; sync func @test() -> ()
Process 118179 exited with status = 1 (0x00000001)
So I got stuck here a bit, but will keep investigating.

%lhs is probably result of copypaste from another test, you can remove it, it shouldn't affect the reproducer. Also expect_almost_eq_const value is arbitrary, I've only added it here to prevent DCE.


make number literals behave like awk/gawk

Consider this:
for i in goawk gawk mawk nawk 'busybox awk'; do echo "$i"; $i 'BEGIN{a = 9; e = 19; print 1.2e+a}'; echo ""; done

The output is:
goawk
------------------------------------
BEGIN{a = 9; e = 19; print 1.2e+a}
                                ^
------------------------------------
parse error at 1:33: expected digits

gawk
1.228

mawk
1.228

nawk
1.228

busybox awk
1.228

This means that other version of awk treat things like "1e" like "1 e" (i.e. concatenation). So it is necessary to unread the 'e' if there are no digits after it.

I added new interp tests to test this behaviour, updated the lexer tests, and factored out unread into its own method on Lexer. Merging shortly. Thanks for your work on this!


Added BuildX Command

Checklist

[ ] All new jobs, commands, executors, parameters have descriptions
[ ] Examples have been added for any significant new features
[ ] README has been updated, if necessary

Motivation, issues

Description

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:1d0905447afd6f7e7f6a1106145213a4e12d3a68

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:c9d5cd57102aa098a3964f7362984fa258db9427

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:b47bbd57b4e6da115de04dfac47d4879cac59842

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:33d4f9c2c31284d40a0f5b88f4163ac5165cdb97

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:9d60659927c02610c3fe33f611bad20d5e68f098

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:775625a6836d049999273d6e8b3d9e5452b362e9

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:3ae77374a01cf97bb2443698774797f88661faae

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=dev:3ae77374a01cf97bb2443698774797f88661faae

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/kanopi/docker?version=1.1.0


Consider adding strong name signing

Is your feature request related to a problem? Please describe.
Unable to compile code with this project as my company uses strong name signing and all referenced libraries must be strong name signed. The error looks like this:
CSC: Error CS8002 : Referenced assembly 'Riok.Mapperly.Abstractions, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have a strong name.
Describe the solution you'd like
Add strong name signing the projects.
Describe alternatives you've considered
Tried to use the remove runtime dependencies with PrivateAssets="All" ExcludeAssets="runtime" but that didn't work. I may use StrongNamer for now but don't like doing this as it makes managing the dependency more difficult.
Additional context
None

What error do you get when excluding the runtime assets? Have you tried the latest next release (see docs here).
Regarding strong naming: we probably won‘t introduce SN since it doesn‘t bring a lot of benefits on newer .NET runtimes but it brings quite some complexity and limitations to Mapperly (e.g. what dependencies).
See also:
https://github.com/MudBlazor/MudBlazor/issues/7696#issuecomment-1782945903 and others.

Thanks @latonz that is helpful. I will instead consider removing the strong naming from our code base (🤞). We use MudBlazor too and it must be signed as there haven't been issues with it.
I didn't mean excluding runtime assets didn't work, but merely that it didn't work as a workaround.


use expanduser/abspath/normpath

It would be nice to normalise paths such that ~ is expanded correctly. i.e. this fails:
db = Dataset.from_metadata('~/path/dataset/cldf/cldf-metadata.json')

When you use the cldf command-line, your shell would do the expansion. When
you use the python API you could do expansion on caller side. So in the
spirit of explicit being better than implicit, I'd rather not implement
this little piece of magic.
Or am I missing a use case?
Simon J Greenhill @.***> schrieb am Do., 8. Dez. 2022,
23:09:

It would be nice to normalise paths such that ~ is expanded correctly.
i.e. this fails:
db = Dataset.from_metadata('~/path/dataset/cldf/cldf-metadata.json')
—
Reply to this email directly, view it on GitHub
https://github.com/cldf/pycldf/issues/163, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGUOKAWBEG6QF6J4YANM7DWMJMB7ANCNFSM6AAAAAASYUR36E
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

From my experience, introducing behaviour that is dependent on external context (getting current users, looking up environment variables, looking up /etc/passwd/, etc.) makes the code more fragile and harder to test/debug. I'd be ok with such code in user interfaces - but then, when run from the commandline the expected behaviour can be had anyway.


Check for internet connection on make up

Is there a way to add a check on the docker.mk file to see if the there is an internet connection and not do a docker-compose pull if not connected?
I sometimes run a dev environment without internet (airplane) and this command fails. I do get around it by running docker-compose up -d, but was wondering...

I don't know if you're still interested in this. I took the check below from one of my Bash scripts and changed it to fit. You could stick it in a Bash script and alias it.
Variable packetLoss will contain the percentage packet loss of the ping command. For example 0 when 0% packet loss. From this example ping -qc 10 wordpress.com output:
PING wordpress.com (<IP_ADDRESS>) 56(84) bytes of data. --- wordpress.com ping statistics --- 10 packets transmitted, 10 received, 0% packet loss, time 21ms rtt min/avg/max/mdev = 42.733/43.114/43.764/0.334 ms

PING wordpress.com (<IP_ADDRESS>) 56(84) bytes of data. --- wordpress.com ping statistics --- 10 packets transmitted, 0 received, 100% packet loss, time 117ms

#!/bin/bash

#-- Variable 'packetLoss' must be null (or > 100) before pinging. Because '0' means no packet loss.
packetLoss=
acceptablePacketLoss=0
packetLoss=$(echo $(ping -qc 10 wordpress.com) | sed -r 's|\s*.*,\s*([[:digit:]]*)% packet loss,.*ms$|\1|')
if [ "$packetLoss" -le "$acceptablePacketLoss" ]; then
  make up #-- docker-compose up -d
  return 0
else
  echo -e "Packet loss is $packetLoss%\nAcceptable packet loss is $acceptablePacketLoss%\nSkipping!"
  return 1
fi


Update jcl-over-slf4j, jul-to-slf4j to 2.0.5

Updates

org.slf4j:jcl-over-slf4j
org.slf4j:jul-to-slf4j

from 2.0.3 to 2.0.5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.slf4j" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.slf4j" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #344.


base.py - add type annoations

Addition type annotations to base.py as per https://github.com/shapely/shapely/pull/1687#issuecomment-1407043373
Discussion: https://github.com/shapely/shapely/issues/721
Related to https://github.com/shapely/shapely/pull/1687
Related to https://github.com/shapely/shapely/discussions/1316

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-3 of 147 (97.96%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 87.407%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

shapely/geometry/base.py
75
76
98.68%

shapely/_typing.py
69
71
97.18%

Totals

Change from base Build<PHONE_NUMBER>:
0.7%

Covered Lines:
2478

Relevant Lines:
2835

💛  - Coveralls

@caspervdw

As a generic remark; I am personally 👍 on the from __future__ import annotations, which would allow you to drop all the quotes around the types.

Forward references were deferred from python 3.11 because it might cause problems, see:
https://lukasz.langa.pl/61df599c-d9d8-4938-868b-36b67fdb4448/
Thus I'm -1 for using from __future__ import annotations

@idanmiara  I'd like to resume this subject of typing in shapely. Take for example the Geometry.contains. In this PR we have:
def contains(self, other: ScalarOrArrayLike["Geometry"]) -> ScalarOrArray[bool]:

Most people (@parched) work with scalar geometries. For these users, the problem here is that this will always need a cast(bool, result) to convince the typing that the return value is a bool. These users will actually find the following more useful:
def contains(self, other: "Geometry") -> bool:
    ...

Which, in my opinion, is also far more comprehensible. However, the more correct solution (as stated before would be using overloads:
@typing.overload
def contains(self, other: "Geometry") -> bool:
    ...

@typing.overload
def contains(self, other: ArrayLike["Geometry"]) -> Array[bool]:
    ...

def contains(self, other: ScalarOrArrayLike["Geometry"]) -> ScalarOrArray[bool]:
    ...  # actual code goes here

However, that is a lot of extra lines to cover and although it is good from a static type analysis point of view, it is harder to read.
We have to decide on this to go forward on typing.  @idanmiara @jorisvandenbossche  @sgillies  could you give your opinion on this?
My personal perference is going with the scalar-only version (option 2) and postpone the arrays for later. Maybe we can experiment a bit with stub files, or something.

Hi @caspervdw
Thanks for your input!
I agree about the scalar only version for the Geometry methods.
I think that we might consider the overload version for the shapely top level functions. I would assume that users who use vectorized input would use these mostly and not the Geometry methods wrappers.

@caspervdw I do not approve of how types are being figured out in a PR. I want to see an RFC or PEP type document explaining what the goal and scope of typing is and I want to see consensus on it before any work is considered. It feels to me like effort is being prematurely poured into this, and the effort is then being used to justify acceptance. I don't think that's how we should proceed.

@caspervdw I do not approve of how types are being figured out in a PR. I want to see an RFC or PEP type document explaining what the goal and scope of typing is and I want to see consensus on it before any work is considered. It feels to me like effort is being poured into this, and the effort is then being used to make a case for action. I don't think that's how we should proceed.

@caspervdw what did you mean by saying

We have to decide on this to go forward on typing.
?

Did the maintainers have an internal discussion about it already?
I don't mind writing an RFC if there is a consensus about including typing and we only need to decide the details. If you give me the the scope it could also help.

Shapely RFCs go to https://github.com/shapely/shapely-rfc and see inspiration is from NumPy's NEP 41 and NEP 42.

@mwtoews Thanks! I acknowledge that I'm raising the bar for working on type hints, and I probably owe the project some work on templating or reviewing the existing template.
Maybe, maybe, with such a document, a sponsor might be convinced to pay Idan to do such work, and pay others to review it. We've seen other sponsored Shapely work, and more would be fantastic.


Hide videos with 0 peers

On the homepage, some of the videos have 0 peers and therefore are unwatchable. It would be nice if these videos were hidden from the homepage until they have at least 1 peer seeding the video.

Adding to this, might be useful to sort the videos by peers as they indicate how popular a video is.

I don't know the number of peers until it is added on the torrent client and adding all the videos might be too much. What I can do is showing the video only if there is at least one peer find which will ask a little syncing time until it shows.
For the home page, I was thinking of showing the video with the most votes then I need to add a vote system.


Unable to use with multiple plugins that use the same event

Only the report folder is generated; the JSON report is not generated

I can’t recreate this, please can you share the following:
CTRF Reporter version
CTRF reporter config
Cypress version
Any logs generated by CTRF
The cypress default reporter summary output, tests passed etc

please see https://github.com/ctrf-io/cypress-ctrf-json-reporter?tab=readme-ov-file#handling-multiple-plugins-in-cypress
Thanks


Use data.onclick/onmouseover/onmouseout on pie/donut/gauge

Use data.onclick, onmouseover and onmouseout on pie/donut/gauge chart instead pie.onclick, pie.onmouseover, pie.onmouseout and so on.

thanks


Provide documentation about Eclipse ECA sign-off status

🆕🐥 First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
👾 Description of the issue
Adoptium and all it repos belong to the Eclipse Foundation since Adoptium is a top level project at Eclipse. To contribute to an Eclipse project the Eclipse Contributor Agreement must be (digitally) signed. To do so an account at Eclipse is needed. The ECA is checked at GitHub in each pull request. Eclipse provides some general information regarding GIT and ECA but it would make sense to have a newcomer friendly documentation that is made directly for GitHub and pull requests.
Additional Information can be found here and here.
The goal of this issue is to provide a tutorial / step by step guide for newcomers as an adoc in this repo.
📋 Step by Step
To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here.

[ ] Claim this issue: Comment below.
[ ]  Fork the repository in github by simply clicking the 'fork' button.
[ ]  Check out the forked repository
[ ]  Create a feature branch for the issue. We do not have any naming definition for branches.
[ ]  Commit your changes.
[ ]  Start a Pull Request.
[ ]  Done 👍 Ask in comments for a review :)
[ ]  If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
[ ]  You did it 🎉 We will merge the fix in the master branch.
[ ]  Thanks, thanks, thanks for being part of this project as an open source contributor ❤

🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a change to receive cool goodies like a T-Shirt. 🎽
🤔❓ Questions
If you have any questions just ask us directly in this issue by adding a comment. You can join our community chat at Slack. Next to this you can find a general manual about open source contributions here.

I'm on it


Idea:  Editor font zoom In/Out

Improvement Idea:
I checked two browsers now with the problem on the log output zoom In - Out, I recommend using a field with custom font size.
Browsers used:

Chrome Version 105.0.5195.102 (Official Build) (x86_64)
Brave v1.45.118 (Nov 2nd, 2022)

Why:

Alternative ideas:

Hi, can you provide some screenshots or a richer explanation - I'm not sure what you're asking for? The logs get larger with the rest of the site as you use the browsers zoom controls


validator: validate ingress backend source kind

Description:
Validates source.kind of the IngressBackend object.
Also updates an error message to be consistent.
Part of #4391

Testing done:
Unit tests

Affected area:

Functional Area

Ingress
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #4412 (405b912) into main (718517c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
+ Coverage   69.21%   69.23%   +0.02%
==========================================
  Files         212      212
  Lines       14554    14568      +14
==========================================
+ Hits        10073    10086      +13
- Misses       4429     4430       +1
  Partials       52       52

Flag
Coverage Δ

unittests
69.23% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/validator/validators.go
89.24% <100.00%> (+1.90%)
:arrow_up:

pkg/certificate/rotor/rotor.go
84.78% <0.00%> (-2.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718517c...405b912. Read the comment docs.


Spanner stops working sometimes; fixed by reloading Element

If I have Element One open for a while, the spanners stop working for me and I get this timeout. It can be fixed by reloading Element Web (1.10.1 as of filing this).

Possible related to #3 as I see that error earlier in the session.

I think this has been okay recently.


Crash on console command killing all biters

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[X] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[X] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
When running the 'kill all enemies' script in the console when having digosaurus working on a nextelite patch, pyalienlife crashes the game.
Another thing was that if I remove the working digosauruses from the digsite, the 'kill all enemies' command no longer causes pyalienlife to crash, however it deletes the digsite!
Script run in the console (from https://wiki.factorio.com/Console#Kill_all_enemies)

/c local surface=game.player.surface
for key, entity in pairs(surface.find_entities_filtered({force="enemy"})) do
entity.destroy()
end

Error message:

The mod Pyanodons AlienLife (2.0.10) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event pyalienlife::on_ai_command_completed (ID 119)
pyalienlife/scripts/digosaurus/digosaurus.lua:172: attempt to index local 'dig_data' (a nil value)
stack traceback:
pyalienlife/scripts/digosaurus/digosaurus.lua:172: in function 'on_ai_command_completed'
pyalienlife/control.lua:103: in function <pyalienlife/control.lua:101>

Steps to reproduce

Digsite near nextelite patch
Two working digosaurs
Run console script:

/c local surface=game.player.surface
for key, entity in pairs(surface.find_entities_filtered({force="enemy"})) do
entity.destroy()
end

Additional context
No response
Log file
factorio-current.log

Fixed for next release. Thank you.


Bootstrap 3

Hey thoughts or plans to move into Bootstrap 3?

If the above link ever goes away, here's the permalink.

Haha, archive! 👍🏻

Hi Above. The solution you posted is that having a touch support for drag and drop ??

no

Hi
Can we add a support for dynamically adding column structure to the form builder.?
Like the below guy has done.
http://demos.anupshinde.com/form-builder-part2-1_kevin_d/index.html

@tanwaniniranjan  Hi have you got any success in edit form reload by passing Json or any other method ??
I need help in that

Honestly, haven't tried. Needed it for an old project, but the module was removed.

Based on the Getting Started guide for Fuel UX's Form Builder, it looks like they support Bootstrap 3.


Error in train_paired.tsv for sentiment data

The positive sentiment line with batch_id 3011 uses a single space character to separate the text from the batch_id, rather than a tab.

Sorry, I just saw this. I have resolved this issue, it must have been this way since the PR. Thanks for pointing this out.


Use python string formatting

When I first came across this code I thought "key" was going to be an integer based on the "0" that was going to be prepended to it when making a key for the hashmap.  It probably is a string normally as this hasn't caused a problem but it is better to be safe than sorry.
I decided to go with the minimal change to cause less distractions.  There's a lot of metadata[name_prefix + somekey] = somevalue in this method which could be simplified but later on.

Thanks for doing this! The code LGTM, but please fix the CLA issue. It's probably related to either what email address is in the author field of the commits or what email addresses are associated with your GitHub account.


Add Knock-To-React to Other Hardware

Hey @MatheusCavalca, I really liked this project because it can enable a new way developers can create micro-interactions with the user. My favorite app that uses this technology is Knock to Unlock.
The only problem with your library right now is that is more like an example app than an actual library, and as you said in the README:

This project uses background tasks that is not guaranteed to be accepted by Apple in the app submission process.
What we can do is creating a library that enables the dev to easily implement this technology in their app, whether he/she wants to use it in background or foreground. I would be more than happy to help you in this transition.

What do you think?

Hey @lfarah, thank you for coming back to me and giving your feedback. I totally agree with you, actually since when I started working on this small project I wanted to make it work as a library that enables dev to easily implement this technology in their apps. I believe now I can give more attention to it and I would be really glad if you could help me in this transition.

@MatheusCavalca Awesome! Let's get work done! I'm closing this pull request right now, but I'm sure in a couple weeks the lib will be here!


Watchman:  spawn watchman ENOENT  -

I am getting the following error when starting on windows:
Watchman:  spawn watchman ENOENT
Error ---------------------------------------------------
Error: spawn watchman ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
at onErrorNT (internal/child_process.js:465:16)
at processTicksAndRejections (internal/process/task_queues.js:80:21)
Below is the full stack trace:
Serverless: Invoke offline:start
AppSync Simulator: backend-starter-vivekt AppSync endpoint: http://<IP_ADDRESS>:20002/graphql
AppSync Simulator: backend-starter-vivekt GraphiQl: http://<IP_ADDRESS>:20002
offline: Starting Offline: dev/us-east-1.
[offline] options: {
allowCache: false,
apiKey: 'd41d8cd98f00b204e9800998ecf8427e',
corsAllowCredentials: true,
corsAllowHeaders: [ 'accept', 'content-type', 'x-api-key', 'authorization' ],
corsAllowOrigin: [ '' ],
corsExposedHeaders: [ 'WWW-Authenticate', 'Server-Authorization' ],
disableCookieValidation: false,
dockerHost: 'localhost',
dockerHostServicePath: null,
dockerNetwork: null,
dockerReadOnly: true,
enforceSecureCookies: false,
functionCleanupIdleTimeSeconds: 60,
hideStackTraces: false,
host: 'localhost',
httpPort: 4040,
httpsProtocol: '',
lambdaPort: 3002,
layersDir: null,
noAuth: false,
noPrependStageInUrl: false,
noTimeout: false,
prefix: '',
printOutput: false,
resourceRoutes: false,
useChildProcesses: false,
useDocker: false,
useWorkerThreads: false,
webSocketHardTimeout: 7200,
webSocketIdleTimeout: 600,
websocketPort: 3001,
corsConfig: {
credentials: true,
exposedHeaders: [ 'WWW-Authenticate', 'Server-Authorization' ],
headers: [ 'accept', 'content-type', 'x-api-key', 'authorization' ],
origin: [ '' ]
}
}
Watchman:  spawn watchman ENOENT
Error ---------------------------------------------------
Error: spawn watchman ENOENT
at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
at onErrorNT (internal/child_process.js:465:16)
at processTicksAndRejections (internal/process/task_queues.js:80:21)
Get Support --------------------------------------------
Docs:          docs.serverless.com
Bugs:          github.com/serverless/serverless/issues
Issues:        forum.serverless.com
Your Environment Information ---------------------------
Operating System:          win32
Node Version:              14.16.1
Framework Version:         2.40.0
Plugin Version:            4.5.3
SDK Version:               4.2.2
Components Version:        3.9.2
offline: Offline [http for lambda] listening on http://localhost:3002
offline: Function names exposed for local invocation by aws-sdk:
[offline] Lambda Invocation Routes (for AWS SDK or AWS CLI):
offline: [HTTP] server ready: http://localhost:4040 🚀
offline:
offline: Enter "rp" to replay the last request
error Command failed with exit code 1.

Just upgraded to latest and same issue on a mac

Same thing,
and i noticed I have this 2 lines where Appsync is somehow going to <IP_ADDRESS>, no idea why or what it is :
AppSync Simulator: undefined AppSync endpoint: http://<IP_ADDRESS>:20002/graphql
AppSync Simulator: undefined GraphiQl: http://<IP_ADDRESS>:20002

This issue is resolved by installing watchman.
From the docs:

Hot-reloading relies on watchman. Make sure it is installed on your system.

@matmunn thanks! Installing watchman resolved this issue.
Note for people like me who didn't knew what watch is earlier. Watchman is not a npm package. https://facebook.github.io/watchman/docs/install.html

Thanks for posting the link, I should have done that myself.

Hey, this is the default behavior, as described in the doc, its reasonable to add this to the readme dependencies. Tough this is cleared in this issue, some guys who use the plugin at the first time (as I do) will need to do a bit of search to know what is happening when this problem raises.


How to manipulate to be created users when App is being installed

#182  Expected Behavior
I can't seems to find a way to manipulate the user creation during app installation, using this package together with other platform and need to label every users what platform they belongs. Or am I just missing something?
App being installed, during creation of the user(shop) need to have a way to describe what platform (in this case "shopify)
Current Behavior
Did not found any or am I just missing something?
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Package Version: latest (v11.2)
Laravel Version: v6.17.1
PHP Version: v7.2.9

Sounds like you could use the AfterAuthenticateJob for this.
The info is here: https://github.com/osiset/laravel-shopify/wiki/After-Authentication-Job

@Kyon147 Hi! yes I've already tackled this section already, but idk where and what to do from there. Take me as a not expert with dealing jobs. Do you happen to find any example how to implement or logic inside the jobs? Would be very much grateful thanks in advance.

Or how do I get $shop? was it automatically handled and no need to call the Jobs anywhere?

Just pass shop as a dependency to the Job
    public function __construct($shop)
    {
        //
        $this->shop = $shop;
    }

@Kyon147 Thank you very much. I will try it, and closing it for now

@Kyon147  Hi! Actually AfterAuthenticateJob is not the solution. What I want to know is where is the actual saving of shopify user to the database, so I can add another value and not run job everytime I authenticate. Would be very grateful if you'll response.

@Kyon147 Hi! Why the job is not firing? I successfully authenticate my shop but Job is not firing.


Host gets double the gold dropped from enemies

Basically all the enemies killed by my friend (host) dropped double the gold, but only for them.
Even mobs killed by me dropped double the gold for them, but normal amount for me.

Thanks, I'll look into it.


this.ref.clean() not clearing first box

I am working on an android app and when I call this.ref.clean() in the checkPinCode function prop, it clears all the boxes except the first one and focus on the second one. Any idea how to fix this?

Hi @whitney162,
Which version of CodePin do you use ?

@gkueny I'm using 0.5.1

I update to version 0.5.3 and I'm still having the same issue

Nevermind, it works correctly if I do:
                                             callback(true);                                               this.ref.clean();
Instead of:
                                             this.ref.clean();                                              callback(true);

an other way is to use success props.
<CodePin
    checkPinCode={ (code, callback) => callback(true) }
    success={ () => this.ref.clean() } // ensure that CodePin internal state is clean
/>

@whitney162 ,
an other way is to use success props.
<CodePin
    checkPinCode={ (code, callback) => callback(true) }
    success={ () => this.ref.clean() } // ensure that CodePin internal state is clean
/>


Integrated avatar module

PR Functionalities

Install the library using pip install requirement.txt.
Import generate_unique_identicon() and generate_random_identicon() from main.py file from avatar folder.
logic.py file contains the different logic to generate identicon, the preferred one is m4 and m2.
The output generated by the function is in base64 format.

Yet to be done

Testing of the logic functions.
Better functionalites which would take size and format into consideration.
Logic to develop a meaningful pattern.

Thanks @TheMightyRaider, merging! 🎉


Refreshing on the service detail page fails to show resource

Blocked on https://github.com/epinio/epinio/issues/1104

Solved by Epinio v0.3.3


Support regular TextToImage

It's not crystal clear from the docs, but there are two interfaces for TextToImage (ImageGeneration) models:

one is the SDXL one, which is actually custom (i.e it might support params not available in any other model) -- shipped like this: https://deepinfra.com/docs/advanced/custom_models
the other is shared among a few models, like:

https://stage.deepinfra.com/runwayml/stable-diffusion-v1-5
https://stage.deepinfra.com/prompthero/openjourney

Currently SDXL is very popular, so it makes sense to keep it's custom input specification intact. However, it should have a base model with Custom in the name with type-argument the concrete SDXL type (so other similar custom models can be added in the future). I'm not 100% sure how to do this in TS, but I can do some research.
And for the regular TextToImage (named ImageGeneration here) models you can have the ImageGenerationBaseModel, which has a common API across many models.

The main difference between the COG-based custom models and other models, is that cog expects all the input parameters under the input key, whereas regular text-to-image expects the arguments directly in the body (like embeddings and text-generation).

Thanks for the clarifications, @ichernev. Your input has been invaluable in enhancing the functionality and usability of the package.
The improvements you've suggested, including updating the documentation, adding a base model named Custom based on the SDXL type, and conducting research on how to implement this in TypeScript, will all be incorporated in the upcoming release by this weekend.


docs(configuration): add explanation of new path definition which includes first/last callback execution

Description

Add the document of Path analysis option, include_first_callback and include_last_callback.
Related links

https://github.com/tier4/CARET_analyze/pull/263

Notes for reviewers

Pre-review checklist for the PR author

[x] I've confirmed the contribution guidelines.
[x] The PR is ready for review.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR has been reviewed.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takeshi-iwanari
Thank you for your review. The explanations you proposed were good, so I have adopted them as they are.

@ymski
Thank you for working on it.
You can merge this PR by yourself.


URL of Image file attachment is null

I tried to get the URL of the first attachment, which is an image file by using the following codes:
card.Attachments[0].Url
However, the Url is a null value. Is that supposed to be that? If so, how could I get the image URL of the attachment?

That should be populated.  I'll look into it.
Thanks for the report.

I've confirmed the issue.  I'll have a fix out this weekend sometime.

Nope.  It's a typo in my code.  I'll have a fix out this weekend.

@sorosliuncu please update Manatee.Trello to v1.18.3

@gregsdennis Thank you! I have update the package to v1.18.3 and it works perfectly!


Orchestrator should support TLS

this current happens in prod environments now. the only hesitation may be supporting a docker-compose environment locally. we should explore running tests via tls as well.

to test, update your docker-compose.yml file to include both server cert and key file per the below -
services:
  hexa-orchestrator:
      .
    environment:
      .
      SERVER_CERT: '/home/databases/docker_support/initdb.d/server-cert.pem'
      SERVER_KEY: '/home/databases/docker_support/initdb.d/server-key.pem'

next, include the root ca located cmd/orchestrator/test/ca-cert.pem in your local keychain
then for macs, you should be able to just double click the ca-cert.pem file
then, once registered, right-click and trust the certificate
restart docker
using your web browser, navigate to the orchestrator health endpoint https://localhost:8885/health and confirm the orchestrator is healthy
{"status":"pass"}

once complete, you can remove the root certificate from your keychain


Examples

Will be used to track down the commits of the examples I'll add in the NOTES.md file.

Basic examples added, see b7fd01317856567e44b44c61ef1ba1aaf598a530.
New examples with interval functions will be added.


feat: add devcontainer configuration

Adds  basic devcontainer configuration. It will allow contributors to use codespaces, and vscode remote containers.

I am not familiar with devcontainers, but this looks like a good idea.


Add the official Docker image.

Hello! Awesome project!
Can you please add the official Docker image to the project?

Hi @mariushosting,
Great suggestion. I’ve just pushed the first Docker image to Docker Hub at dh1011/subscription-manager.
Thanks 🙌

Any hope for you to add an arm64 docker image?

Hi @limdul ,
I have pushed the arm64 image to dh1011/subscription-manager:latest

Hi @limdul , I have pushed the arm64 image to dh1011/subscription-manager:latest

Thank you, seems to be running on my RasberryPi 5 now. Will test more when I'm home.


IPFS status isn't reflected in the system tray menu if connected to a remote node

OS: Windows 10
Version of IPFS Desktop 0.15.0

Describe the bug
I connect my IPFS Desktop installation on Windows to another IPFS node on my Raspberry Pi on my local network. The connection is established correctly, but certain system tray menu items like Status / Files / Peers are disabled. If I open the UI of IPFS Desktop all the pages are fine, showing the status / files / peers of my remote node.
To Reproduce
Steps to reproduce the behavior:

Install an IPFS node on your local network
Start IPFS Desktop on another computer
Change the API address to the remote one
Right click on the system tray icon
You will see that certain items are disabled

Expected behavior
I would expect to see the Status / Files / Peers menu items enabled.
Also it would be great if the IPFS node status on the top of the tray menu and the tray icon itself would show the status of the currently connected (remote) node.
Screenshots
We are connected to the remote node, but the tray menu doesn't reflect that:

Setup of the remote API address:

Changing API address applies only to WebUI. Everything else reflects local node that ships with IPFS Desktop.
That is why you see remote API in webui, but desktop tray menu is still disabled.
The fix here is to either:

(A) hide "API Address" inputs when webui is running inside of IPFS Desktop
(B) make IPFS Desktop aware of "API address" changes made inside of webui

(A) is easy, (B) is tricky because it is unclear how to indicate "stop using remote API, restore running built-in node"
Unless we find an intuitive way to solve (B), I suggest fixing the UX gap with (A).

My suggestion would probably be an overkill, because I'm not sure how many would like to manage multiple node with one IPFS Desktop instance, but theoretically we could change the UI to handle multiple node addresses and switch among them.
I would imagine something like this on the Settings page:

What do you think?

I like it, this would make a good feature for ipfs-webui for power users,
but needs additional work if we want to show API ADDRESS section in ipfs-desktop.
FYSA for now we went with (A) and the next release with ipfs-webui v2.13.0   (https://github.com/ipfs/ipfs-desktop/pull/1903)  will be hiding API selection in Desktop app for now, to reduce user confusion described in the beginning of this issue.
Won't have bandwidth for more than that for the time being, but if someone submits a PR with (B) and the  UI you proposed, I'm happy to review and accept.


[Bug]: spanmetrics via connector not working with otel-collector v0.80.0

What happened?
The duration metric name is no longer normalized with the unit type by default.
The feature gate has been reverted back to off by default, see more details here: https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.80.0
Steps to reproduce
When trying to run the docker-compose monitor example, no data is visible in Jaeger's Monitor tab.
Expected behavior
I expect Jaeger to support both normalized and non-normalized metrics names, or at least document the need to have the feature gate enabled.
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.46.0
SDK
OpenTelemetry Collector v0.80.0
Pipeline
The default provided in the docker-compose monitor example.
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response

@albertteoh

Thanks for letting us know, @Multiply.
My mistake for not recognising the behaviour was caused by a feature gate in the first place!
Will take a look.

I'll be happy to test both locally and in production when something lands!


Solving the penalisation issue through a new objective function

Solved the issue of penalising the negative errors more than the positive ones by creating an objective function for the lightGBM Regression task. I have also included a working case on a sample dataset (just for demonstration  purpose) and did all types of testing on it and came down to 96-97% accuracy for that problem statement .

@navya002 the example you wrote just uses single node lightgbm and not distributed lightgbm in mmlspark, did you mean to post this example in:
https://github.com/Microsoft/LightGBM
this repo is for the spark-based distributed lightgbm only, sorry for any confusion

also in the example it looks like you are specifying custom metric and not objective:
'metric':['auc', 'penalisation_loss'],

I think you want to specify custom objective instead of metric?

Hi ,
Yes that is correct, I have submitted it for the problem :" I have a simple
regression task (using a LightGBMRegressor) where I want to penalize
negative predictions more than positive ones. Is there a way to achieve
this with the default regression LightGBM objectives  If not, is it somehow
possible to define (many example for default LightGBM model) and pass a
custom regression objective?"
I wanted to say that for solving underestimation and overestimation
quartile can be used and for that case I customised the loss
function(wherein the error could be better adjusted to the mean by squaring
the penalisation error) and yes you are correct , I will look into it.
Thank you for the clarification.
Thankfully
Navya Singh
On Mon, Aug 30, 2021, 20:03 Ilya Matiach @.***> wrote:

also in the example it looks like you are specifying custom metric and not
objective:
'metric':['auc', 'penalisation_loss'],
I think you want to specify custom objective instead of metric?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/SynapseML/pull/1173#issuecomment-908394479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALH4H5627O3SF6ESPBXBFETT7OJCHANCNFSM5DAJPWMA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@navya002 sorry I think there is still some confusion based on your reply.  The original question was in this repository for mmlspark distributed lightgbm, not single node lightgbm.  If you want to add this to lightgbm repository (https://github.com/Microsoft/LightGBM) please feel free to do so.  This repository is for the distributed spark-based version of lightgbm.


#40102: Link docs of abstractions over ACR / AKS integration

A starting point for the issue detailed in this issue

Hi @MicahMcKittrick-MSFT, you requested referencing in #40102; apologies for the delay

@qzdl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: qzdl sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@qzdl - please see the previous comment. can you sign the CLA so we can review your suggestions? thanks.


Linear tr

With this PR it will be possible to transform an image by linear segments specified by the user.
At this time only blue values are considered and the output is a gray-scaled image (with transformation applied), therefore this PR DOES NOT closes the related issue (#24 )

DO NOT delete  branch


newlib fails to cross-compile for arm-embedded

Steps To Reproduce
Steps to reproduce the behavior:

nix build nixpkgs#pkgsCross.arm-embedded.buildPackages.newlib

Build log
I believe the relevant errors are
[...]
/nix/store/1b9p07z77phvv2hf6gm9f28syp39f1ag-bash-5.1-p16/bin/bash: line 1: arm-none-eabi-cc: command not found
[...]
/nix/store/1b9p07z77phvv2hf6gm9f28syp39f1ag-bash-5.1-p16/bin/bash: line 3: arm-none-eabi-ar: command not found
[...]

full output here: https://gist.github.com/rndmono/b18bee838ef7e497dd17b1672ef72f87
Notify maintainers
@Ericson2314 @matthewbauer
Metadata

system: "x86_64-linux"
host os: Linux 5.15.63, NixOS, 22.05 (Quokka), 22.05.2764.0ba2543f8c8
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.8.1
channels(root): "nixos-22.05, nixos-hardware, nixos-unstable"
channels(user): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

I had the same issue and was told (on NixOS Matrix) to either omit .buildPackages or use .__splicedPackages.
$ nix build nixpkgs#pkgsCross.arm-embedded.__splicedPackages.newlib
$ nix build nixpkgs#pkgsCross.arm-embedded.newlib

Both of the above commands finish successfully on 22.11.

I had the same issue and was told (on NixOS Matrix) to either omit .buildPackages or use .__splicedPackages.
$ nix build nixpkgs#pkgsCross.arm-embedded.__splicedPackages.newlib
$ nix build nixpkgs#pkgsCross.arm-embedded.newlib

Both of the above commands finish successfully on 22.11.

Thank you! I can confirm that this still works on 23.05.

... and was told (on NixOS Matrix) to either omit .buildPackages or use .__splicedPackages.

Do you know why adding sub attrs buildPackages will cause this failure?

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/newlib-failed-to-build-in-pkgscross-armv7l-hf-multiplatform/36845/1


remove references to filter correction operation

Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c668344) 58.89% compared to head (29dff5e) 58.84%.

Files
Patch %
Lines

mth5/timeseries/ts_filters.py
25.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                      Coverage Diff                      @@
##           fix_mt_metadata_issue_173     #177      +/-   ##
=============================================================
- Coverage                      58.89%   58.84%   -0.05%
=============================================================
  Files                            138      138
  Lines                          14965    14934      -31
=============================================================
- Hits                            8813     8788      -25
+ Misses                          6152     6146       -6

Flag
Coverage Δ

tests
58.84% <25.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PostgreSQL: each time clicking on function "failed to find conversion function from unknown to regprocedure"

This morning, I've updated from OmniDB 2.8 to 2.9.
Unfortunately, I've encountered an annoying behaviour: Each time, I click in the tree on a function, the message failed to find conversion function from unknown to regprocedure appears.
This happens on two different DB clusters on all databases I've tested. I've even tested a fresh DB: same behaviour.
The functions tested could be as simple and plain as

CREATE OR REPLACE FUNCTION public.my_dummy_function()
 RETURNS integer
 LANGUAGE SQL
 SECURITY DEFINER
AS $function$

SELECT 42

$function$

I'm using PostgreSQL 9.6 on Ubuntu 16.04.

hi @cschwaderer,
Thanks for reporting. What OS are you using? OmniDB-app or OmniDB-server?

OS is as mentioned Ubuntu 16.04. I'm using OmniDB-app only.

Indeed, this was introduced in 2.9 when connecting to versions older than pg 10.
Will fix it.

Hi @cschwaderer ,
Thanks for reporting this. I have implemented a fix, it will be published with the next release next week.
Regards,
William Ivanski


space between rake and clean

Theres a space missing in rake:clean:all, should be rake clean:all

Indeed good catch thx


Inconsistent results for token_ratio between 2.15.1 and 3.0.0

Hi,
token_ratio returns inconsistent results when migrating from 2.15.1 to 3.0.0 (or later releases). See for example
Python 3.11.2 (main, Mar 24 2023, 00:28:48) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import rapidfuzz
>>> rapidfuzz.__version__
'2.15.1'
>>> rapidfuzz.fuzz.token_ratio(
...   "did lincoln. sin the national, banking act of 1863?",
...   "Did Lincoln sign the National Banking Act of 1863?")
98.96907216494846

and
Python 3.11.2 (main, Mar 24 2023, 00:28:48) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import rapidfuzz
>>> rapidfuzz.__version__
'3.0.0'
>>> rapidfuzz.fuzz.token_ratio(
...   "did lincoln. sin the national, banking act of 1863?",
...   "Did Lincoln sign the National Banking Act of 1863?")
87.12871287128714

Is this a bug, or an expected change? I couldn't seem to find anything related in the changelog.

In version 3.0.0 all scorers use processor=None as default to make the default more consistent. Previously some of them did use processor=utils.default_process. This changes the results in your case since the strings are no longer preprocessed. You can manually reenable the preprocessing:
>>> import rapidfuzz
>>> rapidfuzz.__version__
'3.1.0'
>>> rapidfuzz.fuzz.token_ratio(
...     "did lincoln. sin the national, banking act of 1863?",
...     "Did Lincoln sign the National Banking Act of 1863?",
...     processor=rapidfuzz.utils.default_process)
98.96907216494846

In the changelog this is mentioned as:

update defaults of the processor argument to be None everywhere. This changes the defaults of some of
the functions in rapidfuzz.fuzz and rapidfuzz.process.

Thanks for the clarification. Can you tell which functions had their default processor changed?

I updated the changelog to mention this might change the results, how to get back the old behaviour and which functions are affected: https://github.com/maxbachmann/RapidFuzz/releases/tag/v3.0.0.
Affected function are:

process.extract, process.extract_iter, process.extractOne
fuzz.token_sort_ratio, fuzz.token_set_ratio, fuzz.token_ratio, fuzz.partial_token_sort_ratio, fuzz.partial_token_set_ratio, fuzz.partial_token_ratio, fuzz.WRatio, fuzz.QRatio


When we e-file, still also send an email to the Appeals court

Just a quick, "Hey, something is in your queue!" so they respond quickly.

Should now be fixed by #61 .


Fetch stops and refactor parse files

Created Stop and StopParsing to fetch and initialize stops from shuttles.rpi.edu/stops. Refactored parse files and created a more elegant way to print the points of a Route object, printPoints().

See #9 instead.


Documentation should warn about MaxDirectMemorySize

Hi,
Based on the issue below:
https://github.com/cloudfoundry/java-buildpack-memory-calculator/issues/17
It appears that spring cloud stream kafka binder needs a good amount of direct memory buffer.
However, in pivotal cloud foundry java buildpack, MaxDirectMemorySize is set to 10M by default.
We noticed a lot of Direct Buffer Memory errors when we reached 20 partitions in a single instance running on PCF. When listening to 4-5 topics, it’s quite a reasonable scenario. We could not reproduce locally so it was very hard to find the root cause.
I think it is important to explain the relationship between Kafka and direct buffer memory, and that JAVA_OPTS parameter should set -XX:MaxDirectMemorySize to a higher value in PCF when using cloud steam Kafka.
Thanks.

@odedia Keep in mind that Spring Cloud Stream via Spring-Kafka are just the consumers of Apache Kafka API and technology in general. So what you pointing out is really not a Spring issue. And even with regard to documentation it also belongs in Apache Kafka documentation. So consider raising the issue with them.
So I am closing it with "won't fix" label with hopes that the explanation makes sense.


Switch from default branch from master to main

I would like to suggest switching the default branch to main away from the master identifier. Many other projects have done so in the last year as a way to retire the "master-slave" terminology used in the tech industry.
Other alternatives are possible like develop, dev, etc.
The docs would have to be modified to reference the new default branch.

we also have to update the settings in the GitHub Actions workflows and semantic-release configurations. We just didn't get around to it yet


Outdated typescript definitions

Describe the bug
@types/steam-user seems to have outdated types.
Versions
Node: 20.9.0
Typescript: 5.3.2
steam-user: 5.0.8
@types/steam-user: 4.26.8
Screenshots and Error Logs
Example is logOn method, when using machineAuthToken:
 if (session.steamGuardMachineToken) client.logOn({
        accountName: env.ACCOUNT_NAME,
        password: env.PASSWORD,
        machineAuthToken : session.steamGuardMachineToken
    });

@types/steam-user is not maintained by me.


fixed tests for Linux

On different systems, the list of files in the catalog, may vary

This is important because in some tests we have special order of the elements