feat: i18n support for Macedonian language

Provides i18n support for Macedonian language.
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[x] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[x] No debug or dead code
[x] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[x] Documentation/examples are up-to-date
[x] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

Hei @grobarko
Thank you very much for your contribution. 🙏🏼
We'd like to thank you with some swag from our side.
If you are interested please send an email to<EMAIL_ADDRESS>

Not sure why is the build failing. I see two warnings about formatting:
 > [angular-build 1/2] RUN npm run lint:
8.153
9.463
9.463 Linting "console"...
34.70
34.70 All files pass linting.
34.70
35.53 Checking formatting...
37.05 [warn] src/app/app.module.ts
78.12 [warn] src/assets/i18n/mk.json
80.65 [warn] Code style issues found in 2 files. Forgot to run Prettier?
------
ERROR: failed to solve: executor failed running [/bin/sh -c npm run lint]: exit code: 1

Error: Process completed with exit code 1.

However, I did run Prettier based on the config embedded in the project and I see no changes in those files... 🤔 Any ideas? Or is the Gitlab Action failing sporadically? 🤔

i had a quick look at it... runnning  npm run lint:fix changes the following:
diff --git a/console/src/app/app.module.ts b/console/src/app/app.module.ts
index 37731469d..f289c333b 100644
--- a/console/src/app/app.module.ts
+++ b/console/src/app/app.module.ts
@@ -7,9 +7,9 @@ import localeEs from '@angular/common/locales/es';
 import localeFr from '@angular/common/locales/fr';
 import localeIt from '@angular/common/locales/it';
 import localeJa from '@angular/common/locales/ja';
+import localeMk from '@angular/common/locales/mk';
 import localePl from '@angular/common/locales/pl';
 import localeZh from '@angular/common/locales/zh';
-import localeMk from '@angular/common/locales/mk';
 import { APP_INITIALIZER, NgModule } from '@angular/core';
 import { MatNativeDateModule } from '@angular/material/core';
 import { MatIconModule } from '@angular/material/icon';
diff --git a/console/src/assets/i18n/mk.json b/console/src/assets/i18n/mk.json
index 3d0b676d0..00fb96e17 100644
--- a/console/src/assets/i18n/mk.json
+++ b/console/src/assets/i18n/mk.json
@@ -2184,4 +2184,4 @@
       "DESCRIPTION": "Овде можете да ги видите најновите настани кои предизвикале промена во корисникот."
     }
   }
-}
\ No newline at end of file
+}

can you maybe check again or should i just push the changes? @grobarko

@livio-a I see now. Thanks for looking into this.
Yes, please just push those changes. I'll adjust my lint config for future contributions.


SyntaxError: Unexpected end of script with minified version on safari

Below is the url we are hitting.  Something must have changed recently as this used to work on Safari.
https://cdn.polyfill.io/v2/polyfill.min.js?features=default,Intl.~locale.fr,Intl.~locale.en,Intl.~locale.es
In the minified version you can find this offending code.  It is commenting out the rest of the file and causing the issue.  If we remove the "min" from the above URL it solves the issue.
//# sourceMappingURL=Intl.min.js.mapIntlPolyfill.__addLocaleData({locale:"en",date:{ca:

Looking into this :-) Thanks for reporting the issue. Have you considered trying out our QA service on your website? It would help us capture these regressions before rolling out to production. This version of the project has been on QA for over a week and we had no issues about this reported.

I also started getting this error in the last hour or so. The url I'm using is https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en,Intl.~locale.de,Intl.~locale.sv,fetch,Object.assign,Promise
Apparently, there's a missing }); at the end.

The intl polyfill now seems to include a sourcemap comment at the end, this is causing all polyfills after it to be commented out when requested in minified form.

The QA script is not working either https://qa.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en,Intl.~locale.de,Intl.~locale.sv,fetch,Object.assign,Promise

@JakeChampion yep, I saw that and thought it was something here on my site, but now I guess it isn't. Thanks for clarifying that :)

Correct, they are now returning the same version. This is because this went to QA over 7 days ago for public testing, no issues were reporting which meant we went to production with the changes made.

We can see that the version we had before did not include the sourcemap comment and the new version does.

@JakeChampion we would love to help by testing with your QA version.  Let us know how and what needs to be done.

@nmaves If you use qa.polyfill.io instead of cdn.polyfill.io then you will be using our QA version. We create issues on this repository when we cut a new release to QA, an example of this can be found here.

PR for this issue https://github.com/Financial-Times/polyfill-service/pull/821

@nmaves We also tweet when releases go to QA or to production -- https://twitter.com/polyfillio

When will be fixed minified version available again?

@JakeChampion when will this fix be available in QA? And production?

We'll announce this on twitter, see Jake's comment: https://github.com/Financial-Times/polyfill-service/issues/820#issuecomment-238654741.

@brenoferreira @vojtech-dobes @nmaves I've pushed the fix to QA.  Does this resolve your symptoms?  Here's @nmaves's URL on the QA host:
http://qa.polyfill.io/v2/polyfill.min.js?features=default,Intl.~locale.fr,Intl.~locale.en,Intl.~locale.es

If you could chime in on #824 that'd be grand.

We're still having this issue today with safari
//cdn.polyfill.io/v2/polyfill.min.js?features=es5|always|gated,Intl.~locale.en-AU|always|gated

SyntaxError: Unexpected token ')'. Parse error.

Removing .min works

@jswift are you sure this is not a local caching or network issue?  I evaluated the output from that URL in Safari 8 and got no SyntaxErrors.  Could you add a &ua=safari/8 or whatever version you are using to lock the output to the detected version and see if you get the same output.  If not, please diff it and tell us how it differs.
Finally, your syntax is out of date, so you may want to look at updating that:
//cdn.polyfill.io/v2/polyfill.min.js?features=es5,Intl.~locale.en-AU&flags=always,gated

Possibly caching, I'll have to look into it further. There was no difference using ua=safari/9 or using the new format.
Thanks for the note about the syntax

It's working for me now. Thanks guys :)

This problem is happening for us still when hitting
https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en&unknown=polyfill
With Samsung browser UA: Mozilla/5.0 (Linux; Android 6.0.1; SAMSUNG-SM-G920A Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/4.0 Chrome/44.0.2403.133 Mobile Safari/537.36
and with iOS 8 UA: Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/13B143 Safari/600.1.4
Service version states 3.11.0 when hitting non-minified version. Also it looks like I am currently hitting the LAX servers via CDN.
BTW, the non-minified version is fine with proper line breaks, just the minified version appears to be bad.


PeerJ R2C9b

Section 3
This section is a bit unclear on what is actually the target. On the one hand it is ‘ just’ advertising, on the other hand it mentions detailed code review.
If only high level functioning is reviewed, what is there actually to review in JOSS. How is quality and originality defined? So, how to determine impact and quality as peer review of scientific papers generally does? Does the code review have this role? Does this include coding standards, bench marking, checking for correctness of scientific result (in addition to code tests).

see #26

How's this?

The goal of peer review in JOSS is not to judge submissions for acceptance or rejection, but rather to bring the submission to an acceptable standard. Any submission that meets our standards should be accepted, as we do not filter based on potential impact or quality (beyond that implied by meeting our standards). The peer review encompasses the code, software functionality, tests, and any associated artifacts (documentation, examples, etc.). We have added a sentence to page 5 clarifying the target of peer review.

I've also added a sentence to the Open Peer Review section on page 5:

The actual review includes the code, software functionality/performance claims, test suite (if present), documentation, and any other material associated with the software.

👍 LGTM


links don't work for us on medium-draft 5.1

Hi, we're using medium-draft at yours.org. Great job! This is an awesome editor.
Unfortunately when we post a link the link does not show up on the view page. Is there something we're doing wrong? We're using react and building things with webpack. We are including the medium-draft CSS.

Something to do with decorators. What function are you using to create your editorState ?

We're using this method:
editorState = require('medium-draft').createEditorState()

And what about for pre-existing content (besides the empty editor). I tested the editor @ https://www.yours.org/create/ and links were working fine.

Yes, you can create links, but when you actually post content, the links don't show up. It's empty text. We are using createEditorState both for the create page and the view page.

So to answer your question, for pre-existing content, we are doing it like this:
let editorState = convertFromRaw(JSON.parse(this.props.content.editor1State))
editorState = EditorState.createWithContent(editorState)

You should try this instead
editorState = createWithContent(JSON.parse(this.props.content.editorState))

OK, great, will try that!

When I try that, I get this error on the view page:

No content is displayed.
On the create page, here's how we're storing the data to our db:
let editorState = JSON.stringify(convertToRaw(this.state.editorState.getCurrentContent()))

On the view page, creating the editor now looks like this:
let editorState = EditorState.createWithContent(JSON.parse(this.props.content.editorState))

The input in createWithContent should be the JSON that you get from convetToRaw

OK great - I figured it out. Thank you!
The problem was we were using EditorState.createWithContent where EditorState was taken directly from draft-js. But by doing that, we weren't calling the decorators in medium-draft.
But what we should have been doing was using the createEditorState method from medium-draft, and passing in our content.
Here's the diff to show what fixed it:
-      let editorState = convertFromRaw(JSON.parse(this.props.content.editorState))
-      editorState = EditorState.createWithContent(editorState)
+      let editorState = createEditorState(JSON.parse(this.props.content.editorState))

Thank you very much for your help!


emoji: Add support for animated GIF images.

This commit adds 'resize_gif()' function which extracts each frame,
resize it and coalesces them again to form the resized GIF while
preserving the duration of the GIF. I read some stackoverflow
answers all of which were referring to BiggleZX's script
(https://gist.github.com/BigglesZX/4016539) for working with animated
GIF. I modified the script to fit to our usecase and did some manual
testing but the function was failing for some specific GIFs and was not
preserving the duration of animation. So I went ahead and read about
GIF format itself as well as PIL's GifImagePlugin code and came up
with this simple function which gets the worked done in a much cleaner
way. It tested this function on a number of GIF images from giphy.com
and it resized all of them correctly.
Fixes: #9945.

@timabbott FYI. Mypy is complaining because there are no stub files available for GifImagePlugin.

@timabbott Gentle ping on this. What can I do to fix the mypy issue?

For the mypy error, there are two options.  Either edit mypy.ini to add an ignore_missing_imports block, or add stubs like what we have in the stubs/ directory, for the PIL function we're using.

Nice, merged, thanks @HarshitOnGitHub!

Nice job on the resizing !
One question: it was working fine for a while and now, every time I upload a new custom GIF emoji, the background, which should be transparent, is now black.
Do you think it would come from the resizing which doesn't keep the alpha ?

That seems quite likely.  @julievalet can you open a new issue for that and mention @HarshitOnGitHub on the thread?

#10351


New build system Errors - Earl Grey

Hello,
I have three targets which copies the Earl Grey as part of Copy phase , On building this on new build system , Xcode 10 beta 5 throws below error.
Should we remove copy phase from remaining two of them ?
Showing All Messages
:-1: Multiple commands produce '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/Evernote.app/EarlGrey.framework':

Target 'XXXUITests' has copy command from '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/EarlGrey.framework' to '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/XXX.app/EarlGrey.framework'
Target 'XXXUIFLETests' has copy command from '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/EarlGrey.framework' to '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/XXX.app/EarlGrey.framework'
Target 'XXXUIEditorTests' has copy command from '/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/EarlGrey.framework' to

'/Users/bvenkatnarayansetty/Library/Developer/Xcode/DerivedData/Lightning-bqwglibfxszbzcbfqlsqwrftorbm/Build/Products/Debug-iphonesimulator/XXX.app/EarlGrey.framework'

Yeah, we use the Copy Files Build Phase to embed EarlGrey into the app under test. Can you tell me how this is done with the new build system and we could check this?

Copy Phases are related to your Target's Build Phases and not necessarily to the schemes. Is there any new change for embedding frameworks that has been added to the Build system? I'll have to take a look in a bit.

what i think is we just need to add it once, so that respective targets will pick up. I am also invetsigatin where to add it.

@badrinathvm were there any updates here?


[SPARK-22393][SPARK-SHELL] spark-shell can't find imported types in class constructors, extends clause

What changes were proposed in this pull request?
SPARK-22393
How was this patch tested?
With a new test case in RepSuite

This code is a retrofit of the Scala SI-9881 bug fix, which never made it into the Scala 2.11 branches. Pushing these changes directly to the Scala repo is not practical (see: https://github.com/scala/scala/pull/6195).

Sorry, could not refactor the code better; since it makes heavy use of path-dependent types.

Can one of the admins verify this patch?

OK, so this just affects the Scala 2.11 REPL in Spark (good, because the 2.12 version works a little differently and the fix is already in 2.12), and you've just copied in the fixed classes and injected the fixed impl? sounds reasonable.

Test build #3998 has started for PR 19846 at commit 336446c.

@srowen Yes, exactly. Tried to minimize the risks of any problems caused by this change.

Test build #3998 has finished for PR 19846 at commit 336446c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@mpetruska, btw can you fill up the PR description about how it fixes?

@HyukjinKwon : Hi, yes: this is the "retrofitting" of the original bug fix, which never made it to Scala 2.11. Instead of copy-pasting the original discussion, let me link the original PR.
I can add more details about specific parts, of course.

Merged to master


Negation in navigateFallbackWhitelist

Hello everyone, i'm trying to use sw-precache on my project, but im currently struggling with the navigateFallback and navigateFallbackWhitelist.
For my static assets everything works fine, but I have a resource wich is used to download files, which should not be served by the service worker.
So I have paths like /.js, /.css, etc., wich should be cached, but everything behind /attachments/someID/download shouldn't.
In my understanding I would need more something like navigateFallbackBlacklist (as negation is not supported anymore by glob).

Yeah, blacklisting vs. whitelisting is a sticky issue.
The values that you pass in are RegExp objects, not glob patterns, so it's not too bad to negate it:
{
  navigateFallbackWhitelist: [/^(?!.*attachments)/],
  // other options
}

(In the currently WIP successor to this library, we'll support both white and blacklists.)


webpack: Introduce webpack.dev-asset.json.

Link to CZO conversation
This PR:

Move development only templates to templates/zerver/development.
Rename dev_panel.html to integrations_dev_panel.html for more clarity.
Add check to lint that ensures only development-related templates entrypoint name should start with dev.
Introduce webpack.dev-assets.json.

Also updated docs,

Before
After

Testing plan:
Tested it by running lints.
GIFs or screenshots:

integrations-dev-panel is currently failing your check, except that the failure isn’t fatal enough.
The lint check could be implemented more simply as a pair of rules in tools/linter_lib/custom_check.py, one with {"pattern": r'{% set entrypoint = "dev-', "exclude": {"templates/zerver/development/"}, and the other with {"pattern": r'{% set entrypoint = "(?!dev-)[^"]*"', "include_only": {"templates/zerver/development/"}. Although I’m not sure if we want the latter—it seems fine for some generic entry points to be shared between dev and non-dev templates.

The lint check could be implemented more simply as a pair of rules in tools/linter_lib/custom_check.py, one with {"pattern": r'{% set entrypoint = "dev-', "exclude": {"templates/zerver/development/"}.

Wow! Didn't know that. This is much simpler.

Although I’m not sure if we want the latter—it seems fine for some generic entry points to be shared between dev and non-dev templates.

Agree!
Updated the PR!
@andersk  Should we also add a pattern for webpack.dev-asset.json to check all the entries starts with dev?

Merged, after a bit of work on the documentation text to keep it brief, thanks @Riken-Shah!
One quick follow up that it'd be nice if you can do is splitting zerver/views/auth.py to move all the functions with dev_ in their name to zerver/views/development/dev_login.py; that's valuable mainly in that it'll more fully separate code with no production security impact (stuff only running in a dev environment) from authentication code (which is some of the most important for security).  Probably you'll end up having this block of code in login_page have an import statement inside it access add_dev_login_context.
    if dev_auth_enabled() and kwargs.get("template_name") == "zerver/development/dev_login.html":
        if "new_realm" in request.POST:
            try:
                realm = get_realm(request.POST["new_realm"])
            except Realm.DoesNotExist:
                realm = None

        add_dev_login_context(realm, extra_context)
        if realm and "new_realm" in request.POST:
            # If we're switching realms, redirect to that realm, but
            # only if it actually exists.
            return HttpResponseRedirect(realm.uri)


Two times doc/documentation entries

Hi,
I tryed to add doc to the match config. Is it intended to have two times 'doc:' commits in the changelog in that case?
https://github.com/marcpoppleton/gradle-changelog-plugin/blob/732d784a43fc420b590ace70386ee052c5b60bb3/src/main/groovy/org/gradle/api/plugins/changelog/GitChangelogService.groovy#L234

Indeed this is a bug!
Thanks for having opened an issue.


mobile: Remove the Swift async await test app

This app runs on CI and sends a 5MB POST request to httpbin.org. The app is flaky on CI due to sending requests to httpbin.org, and the app itself doesn't add much value to CI, as there are already hello world apps that test iOS app functionality on CI:
https://github.com/envoyproxy/envoy/blob/8c327f744db38b9fb1d9b29539475800860fba2b/.github/workflows/mobile-ios_build.yml#L161-L170.
Fixes #37485

/assign @alyssawilk

cc @phlax


feat(storage): Add additional tracing to tsm1 schema APIs

Additional tracing was added to the tsm1 schema APIs in an effort to identify significant variance in latency.

A new pkg/stopwatch was created to facilitate timing and tracing specific operations.

Added a meta property to the Measurement schema APIs to permit sending arbitrary data to influence how the server handles the request. In this instance, we will use it to choose which Measurement schema strategy to use (NoTime)

@stuartcarnie looks good to me. Have you got any thoughts about how this will be sufficiently tested given it looks like it's hard to FF?

@e-dard agree – it isn't really practical to feature flag changes that are specifically for increasing observability (tracing / logging), as they are almost always invasive.
In reality we'd have to copy it all and create a new function called "MeasurementNamesWithMoreTracing".
The only concern in this code would be if the call to StartSpanFromContext returned a nil span:
span, ctx := tracing.StartSpanFromContext(ctx)
defer span.Finish()

This API guarantees it does not, and will panic if ctx is nil. If ctx is nil, existing code would already panic.

This is no longer relevant for OSS


Extracting NDSB raw data Stage12

Hi Julian,
In step1_preprocess_ndsb.py should I extract both the Stage 1 and Stage 2 NDSB data into the same directory? or into to separate ones?
ie.
/data/ndsb3_extracted_images/<patient_dirs>
or
/data/ndsb3_extracted_images/stage1/<patient_dirs>
/data/ndsb3_extracted_images/stage2/<patient_dirs>
?

Hello,
I believe all in one map.
Regards,
Julian.

hii...teaghan
from where you got the ndsb raw data..???..also in luna raw images  ..only raw images from the dataset used or mhd  images also??...in extracted images of luna and ndsb....  extracted patches are used  or else used..?


fix typo

I don't think this need to be corrected; confer for instance the syntactical precedent of "I'm at the combination Pizza Hut and Taco Bell". Just style. But god bless you for pull requesting!! Pull requests are great.


Make it easier to disable weave integrations

Also:

Treat weave ps exit code like any other error (so we silence it if its failing all the time) (fixes #1599)
Don't run weave ps so aggressively (fixes #1078)
Log backoff-able errors at WARN (fixes #1008)

From #1078

Also weave expose invocation should be done with --local.

I can't see this being implemented

Good catch!
PTAL

LGTM


Uglify and lint support via Terser

Requires new button. Check syntax.
Minify will be default going forward. There's no reason you wouldn't want it.
Execute terser via anonymous webview.

It's not default, but it works now. Since 8f6cb72a39527075bbfc876c.


Warnings from Swift 5.2 compiler

Description:

Have a no warning when compiling

Actual behaviour:
Swift 5.2 included in Xcode Version 11.4 beta (11N111s) reports 2 warnings:

In Queryable.swift
 var prefixChars = [CChar]()

Initialization of variable 'prefixChars' was never used; consider replacing with assignment to '_' or removing it

In Document.swift

 public convenience init(cChars: [CChar]) throws {
    try self.init(buffer: UnsafeBufferPointer(start: UnsafePointer(cChars), count: cChars.count))
  }

Initialization of 'UnsafePointer' (aka 'UnsafePointer') results in a dangling pointer

and also gives instructions on how to address:

Implicit argument conversion from '[CChar]' (aka 'Array') to 'UnsafePointer' (aka 'UnsafePointer') produces a pointer valid only for the duration of the call to 'init(_:)'
Use the 'withUnsafeBufferPointer' method on Array in order to explicitly convert argument to buffer pointer valid for a defined scope

Environment

Package Manager:

[ ] Carthage, version:
[x] CocoaPods, version: 1.9.0.beta.2
[ ] Manually

Fuzi version: 3.1.1

Xcode version: Version 11.4 beta (11N111s)

How to reproduce:
Integrate project

Thank you! Fixed in release 3.1.3.


fix: show tooltips for entity name in explorer

Description

Show tooltips for entity name in explorer
Move popover styles for context menu to explorer from propertycontrols(these styles are only used in entity explorer so moved it here)
Fix width of datasource form name similar to action name

Fixes #8296
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Manually
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/entity-explorer-name

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.73 (0.01)
36.42 (0.02)
33.52 (0.01)
55.28 (0.01)

:red_circle:
app/client/src/components/propertyControls/StyledControls.tsx
67.14 (-0.47)
75 (-0.76)
43.9 (0)
67.14 (-0.47)

:green_circle:
app/client/src/pages/Editor/Explorer/TreeDropdown.tsx
68.29 (3.43)
57.14 (3.29)
44.44 (0)
66.67 (3.81)

:green_circle:
app/client/src/pages/Editor/Explorer/Entity/Name.tsx
61.18 (1.44)
33.33 (6.5)
40 (-6.15)
60.49 (1.59)

:green_circle:
app/client/src/pages/Editor/Explorer/Entity/index.tsx
93.15 (0.19)
79.63 (0.78)
83.33 (0)
92.86 (0.21)

:green_circle:
app/client/src/utils/helpers.tsx
59.25 (0.38)
30.34 (2.06)
45 (2.5)
56.1 (0.49)

/ok-to-test sha=9c83306

/ok-to-test sha=1aeb911

/ok-to-test sha=a2ad0a4


[Feature idea] Add stopwatch text to animation

Idea
I very often use the tool to record other applications running and to show that something takes (too) long time. Currently I was either record just the app (if the sluggishness is obvious) or place a stopwatch next to the recorded app to show the progress of time.
I was thinking it could be nice idea to have ability to add stopwatch text on the animation, the same way as it's now possible to add keystrokes or progress.
Haven't check if it's possible to calculate time for each frame but assuming there's a frame duration and delay it could be possible to do it.
@NickeManarin  I could work on this feature if it makes sense to be included in the application unless there's already something like that or you know that that's not possible to do for some reason.

Ok, this can be done by Progress of type Text. Didn't know that one ;)

Sorry to not being able to answer in time. :)


Point Addition Performance

Your library performance is Very good for Scalar Multiplication. But i am trying for Point Addition and getting slower speed.
pub1 = bit.Key.from_int(1)._pk.public_key
timeit pub1.combine_keys([pub1, pub1])
8.81 µs ± 287 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
In comparison, by using gmpy2 with https://github.com/iceland2k14/bsgs/blob/main/gmp_ec.py
timeit ec.G + ec.G
6.56 µs ± 106 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
Maybe i am not trying in proper way to do Point Addition with bit or coincurve. Can you please show ?

Can you give me a way to test like this:
$ python -m timeit -s "from coincurve import PrivateKey;pub_key=PrivateKey.from_int(1).public_key;keys=[pub_key, pub_key]" "pub_key.combine_keys(keys)"
50000 loops, best of 5: 5.87 usec per loop

Just to avoid Point Doubling inside, Adding G + 2G, here they are :
python -m timeit -s "from coincurve import PrivateKey,PublicKey;pub_key2=PrivateKey.from_int(2).public_key;pub_key1=PrivateKey.from_int(1).public_key;keys=[pub_key1, pub_key2]" "PublicKey.combine_keys(keys)"
50000 loops, best of 5: 8.41 usec per loop

python -m timeit -s "import gmp_ec as ec;pub_key1=ec.G;pub_key2=ec.Scalar_Multiplication(2)" "ec.Point_Addition(pub_key1, pub_key2)"
50000 loops, best of 5: 3.9 usec per loop


Closing a child window causes a crash in a WinUI3 XAML-hosted application.

Describe the bug
In a WinUI 3 XAML-hosted application, when closing an explicitly created child window, it throws exception and causes application crash.
We are creating and activating a WinUI 3 window using a button click handler available in the XAML page, which is hosted over the native application.
In this scenario, should we do any extra handling to close the newly created window properly?
Any help is appreciated.
Steps to reproduce the bug

Download and build the XAML Island sample application available in the following repo.
https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/Islands
Add the following lines of code inside the WinUI button click handler available in the "MainPage" cpp file.

auto ChildWindow = Microsoft::UI::Xaml::Window();
ChildWindow.Activate();

Build and run the application.
Click the WinUI 3 button.
Close the newly created WinUI 3 window using close icon.

Expected behavior
The window should close without any exception, and the parent app should continue to run as it is.
Screenshots
No response
NuGet package version
Windows App SDK 1.4.3: 1.4.231115000
Packaging type
Unpackaged
Windows version
Windows 10 version 22H2 (19045, 2022 Update)
IDE
Visual Studio 2022
Additional context
The same behavior is found if we create an XAML window using the Blank Window (WinUI 3 in Desktop) template and activate it inside the button click handler.

Hi there -- yes, thank you for the bug report!  The bug here is that when the last Xaml Window goes away, it does a PostQuitMessage(), which exits the message loop, causing the process to exit.  I'm hoping we can get a fix into WinAppSDK.
If you need this to work, there's an ugly workaround you could do here.  Usually, a message loop will exit when GetMessage() returns FALSE.  When the Xaml runtime calls PostQuitMessage(), the GetMessage() call in your message loop will soon return FALSE.  You can dodge this FALSE if you know it's coming by ignoring it and continuing the loop anyway.  I can add more detail if you're interested in trying this.

Hi there -- yes, thank you for the bug report! The bug here is that when the last Xaml Window goes away, it does a PostQuitMessage(), which exits the message loop, causing the process to exit. I'm hoping we can get a fix into WinAppSDK.
If you need this to work, there's an ugly workaround you could do here. Usually, a message loop will exit when GetMessage() returns FALSE. When the Xaml runtime calls PostQuitMessage(), the GetMessage() call in your message loop will soon return FALSE. You can dodge this FALSE if you know it's coming by ignoring it and continuing the loop anyway. I can add more detail if you're interested in trying this.

Hi,
Thank you for the reply.
We would like to try this workaround, and it would be highly appreciated if you could provide more details.

Hi there -- yes, thank you for the bug report! The bug here is that when the last Xaml Window goes away, it does a PostQuitMessage(), which exits the message loop, causing the process to exit. I'm hoping we can get a fix into WinAppSDK.
If you need this to work, there's an ugly workaround you could do here. Usually, a message loop will exit when GetMessage() returns FALSE. When the Xaml runtime calls PostQuitMessage(), the GetMessage() call in your message loop will soon return FALSE. You can dodge this FALSE if you know it's coming by ignoring it and continuing the loop anyway. I can add more detail if you're interested in trying this.

Hi,
Could you please share more information on this workaround? It would be very helpful for us.


Cannot match against 'undefined' or 'null'.

I'm getting this error when running the tests.
I just cloned the boilerplate and i'm trying to figure out why the tests are failing and what do the error messages mean after just adding the following lines tp Counter.js.
import { remote } from 'electron';
const { shell} = remote
...
shell.openExternal('https://www.facebook.com')

Are you still experiencing this?

I resolved it by separating the electron components to a separate file, so jest doesn't bump into it.


switching to style manager causes permanent (black) border on selecting elements

Using latest stable Grapes + Grapes preset webpage.
Steps to reproduce

go to https://jsfiddle.net/szLp8h4n/101/
select the text element
deselect the text element
notice the permanent black border appearing:

The expected behavior is that there is no black border when deselecting the element.
Note that this behavior is fixed by removing the logic that automatically opens the style manager when selecting a component:

Therefore there seems to be a bug when changing the active state of a view.

@artf the issue seems more serious than I thought: simply removing the logic to open style manager only resolves it partially, because it will still happen if you select a component and then switch to the style manager manually.
Something is happening when you activate the style manager that causes this bug to occur.
Can I help in any way to resolve this sooner?

Hi @tommedema, the index.html used in the demo is different from the one in Git. I use browser's 'View Page Source' to determine what was actually used in the demo. Hope this helps.

I experience the same issue.

It looks like there is a fix https://github.com/artf/grapesjs-preset-webpage/commit/af0bee78611ed5961587aca86ae9f65fe8be23b9

@maxtacco correct, it should be fixed now

@tommedema @maxtacco were you able to fix it? I still see the problem in the demo, I'm going crazy to solve it. It generates a lot of bigger problems if you play with the borders of some elements. If only we could use Hex colors and disable Rgb in the border, the bug would disappear.

@xamdam777, sorry, I don't use grapesjs-preset-webpage in my project, I have a custom configuration with some things borrowed from the grapesjs-preset-webpage and it works fine for me right now.

@maxtacco Thanks for replying!
Can you check if your project experience this other bug? https://github.com/artf/grapesjs-preset-webpage/issues/10
It is related, the style manager opening was just a trigger of the real bug: rgb colors in wrong format

I got working a dirty workaround and this is my current best solution based on @tommedema suggestion.
Just remove the "border" property from the decoration tab and add border-top, bottom, right and left instead.
buildProps: ["opacity", "background-color", "border-radius", "box-shadow", "background", "border-top", "border-bottom", "border-left", "border-right"],
This will completely remove the bugged border property and add 4 new properties.
The bad part of this workaround is that you will need to customize the new border properties by hand:
5px solid rgb(220, 22, 22)
Something like that will appear in every border text field, so your users will not have a color picker.
Maybe I'll try to code my own color picker for the borders. I am afraid that if I use the default grapesjs one, it can be hard to achieve and that crazy bug may come back.


refactor: idb transport to use bindParameters

resolves #305

Ran functional tests locally since the build system is down.
$ npm run test-integration

><EMAIL_ADDRESS>test-integration~/nodejs-itoolkit
> ./node_modules/mocha/bin/mocha --timeout 5s test/functional/*.js

  CommandCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    CL command tests
      ✓ calls CL command (220ms)
    SH command tests
      ✓ calls PASE shell command (1437ms)
    QSH command tests
      ✓ calls QSH command (2133ms)

  ProgramCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    addParam
      ✓ calls QWCRSVAL program checks if it ran successfully (74ms)
    addReturn
      - calls ZZVARY4 and checks the return value

  DataQueue Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    sendToDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:46:18
iDataQueue deprecated As of v1.0, 'iDataQueue.sendToDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:48:10
      ✓ sends data to specified DQ (71ms)
    receiveFromDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:60:18
iDataQueue deprecated As of v1.0, 'iDataQueue.receiveFromDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:62:10
      ✓ receives data from specfied DQ (65ms)
    clearDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:74:18
iDataQueue deprecated As of v1.0, 'iDataQueue.clearDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:76:10
      ✓ clears the specifed DQ (74ms)

  iNetwork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getTCPIPAttr
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:34:19
iNetwork deprecated As of v1.0, 'iNetwork.getTCPIPAttr()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:36:11
      ✓ retrieves TCP/IP Attributes (84ms)
    getNetInterfaceData
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:77:19
iNetwork deprecated As of v1.0, 'iNetwork.getNetInterfaceData()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:79:11
      ✓ retrieves IPv4 network interface info (100ms)

  iObj Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    retrUsrAuth
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:33:19
iObj deprecated As of v1.0, 'iObj.retrUsrAuth()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:35:11
      ✓ returns uses's authority for an object  (75ms)
    rtrCmdInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:78:19
iObj deprecated As of v1.0, 'iObj.retrCmdInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:80:11
      ✓ returns command info (74ms)
    retrPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:131:19
iObj deprecated As of v1.0, 'iObj.retrPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:133:11
      ✓ returns program info (89ms)
    retrSrvPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:206:19
iObj deprecated As of v1.0, 'iObj.retrSrvPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:208:11
      ✓ returns service program info (140ms)
    retrUserInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:262:19
iObj deprecated As of v1.0, 'iObj.retrUserInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:264:11
      ✓ returns specified user profile info (75ms)
    retrUsrAuthToObj
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:289:19
iObj deprecated As of v1.0, 'iObj.retrUserAuthToObj()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:291:11
      ✓ retrieves info for users who are authorized to an object using idb transpsort (75ms)
    addToLibraryList
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:317:19
iObj deprecated As of v1.0, 'iObj.addToLibraryList()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:319:11
      ✓ appends lib to user's lib list (67ms)

  iProd Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getPTFInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:33:20
iProd deprecated As of v1.0, 'iProd.getPTFInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:35:12
      ✓ returns info for specified ptf (127ms)
    getProductInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:76:20
iProd deprecated As of v1.0, 'iProd.getProductInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:78:12
      ✓ returns info for specified product (70ms)
    getInstalledProducts
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:109:20
iProd deprecated As of v1.0, 'iProd.getInstalledProducts()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:111:12
      ✓ returns info for installed products (867ms)

  iSql Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    prepare & execute
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:34:19
      ✓ prepares & executes stored procedure then fetch results (316ms)
    addQuery & fetch
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:68:19
      ✓ runs a query and fetches results (218ms)
    added test to ensure issue #11 was resolved
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:94:19
      ✓ should parse SQL result set empty data tags correctly (211ms)
    tables
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:121:19
      ✓ returns meta data for specified table (206ms)
    tablePriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:146:19
      ✓ returns privilege data for a table (243ms)
    columns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:173:19
      ✓ returns meta data for a column (266ms)
    columnPriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:211:19
      ✓ returns privilege data for a column (242ms)
    procedures
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:240:19
      ✓ returns meta data on for a procedure (208ms)
    pColumns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:268:19
      ✓ returns meta data for procedure column (250ms)
    primaryKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:307:19
      ✓ returns meta data for a primary key (212ms)
    foreignKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:333:19
      ✓ returns meta data for a foreign key (227ms)
    statistics
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:368:19
      ✓ returns stats info for table (463ms)
    special
      - returns meta data for special columns
    rowCount
      - returns the number of rows affected by statement

  UserSpace Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    createUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:51:25
iUserSpace deprecated As of v1.0, 'iUserSpace.createUserSpace()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:57:17
      ✓ creates a user space (93ms)
    setUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:75:25
iUserSpace deprecated As of v1.0, 'iUserSpace.setUserSpaceData()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:79:17
      ✓ sets data within the user space (81ms)
    getUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:96:25
iUserSpace deprecated As of v1.0, 'iUserSpace.getUserSpaceData()' is deprecated ad will be removed at a later time. test/functional/iUserSpaceFunctional.js:98:17
      ✓ returns specified length of data (75ms)
    deleteUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:113:25
iUserSpace deprecated As of v1.0, 'iUserSpace.deleteUserSpace()' is deprecated and will be removed at a later time test/functional/iUserSpaceFunctional.js:115:17
      ✓ removes a user space (77ms)

  iWork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getSysValue
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:34:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:36:12
      ✓ returns the value of system variable (68ms)
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:46:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:48:12
      ✓ returns an error when the specified system value is invalid
    getSysStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:58:20
iWork deprecated As of v1.0, 'iWork.getSysStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:60:12
      ✓ returns basic system status information about the signed-on users and batch jobs (88ms)
    getSysStatusExt
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:88:20
iWork deprecated As of v1.0, 'iWork.getSysStatusExt()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:90:12
      ✓ returns more detailed system status info (1163ms)
    getJobStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:133:20
iWork deprecated As of v1.0, 'iWork.getJobStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:135:12
      ✓ returns status of specified job (72ms)
    getJobInfo
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:149:20
iWork deprecated As of v1.0, 'iWork.getJobInfo()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:151:12
      ✓ returns info on specfed job (73ms)
    getDataArea
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:200:22
iWork deprecated As of v1.0, 'iWork.getDataArea()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:202:14
      ✓ returns contents of a data area (130ms)

  42 passing (11s)
  3 pending

Ran functional tests locally since the build system is down.
$ npm run test-integration

><EMAIL_ADDRESS>test-integration~/nodejs-itoolkit
> ./node_modules/mocha/bin/mocha --timeout 5s test/functional/*.js

  CommandCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    CL command tests
      ✓ calls CL command (220ms)
    SH command tests
      ✓ calls PASE shell command (1437ms)
    QSH command tests
      ✓ calls QSH command (2133ms)

  ProgramCall Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    addParam
      ✓ calls QWCRSVAL program checks if it ran successfully (74ms)
    addReturn
      - calls ZZVARY4 and checks the return value

  DataQueue Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    sendToDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:46:18
iDataQueue deprecated As of v1.0, 'iDataQueue.sendToDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:48:10
      ✓ sends data to specified DQ (71ms)
    receiveFromDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:60:18
iDataQueue deprecated As of v1.0, 'iDataQueue.receiveFromDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:62:10
      ✓ receives data from specfied DQ (65ms)
    clearDataQueue
iDataQueue deprecated As of v1.0, class 'iDataQueue' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:74:18
iDataQueue deprecated As of v1.0, 'iDataQueue.clearDataQueue()' is deprecated and will be removed at a later time. test/functional/iDataQueueFunctional.js:76:10
      ✓ clears the specifed DQ (74ms)

  iNetwork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getTCPIPAttr
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:34:19
iNetwork deprecated As of v1.0, 'iNetwork.getTCPIPAttr()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:36:11
      ✓ retrieves TCP/IP Attributes (84ms)
    getNetInterfaceData
iNetwork deprecated As of v1.0, class 'iNetwork' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:77:19
iNetwork deprecated As of v1.0, 'iNetwork.getNetInterfaceData()' is deprecated and will be removed at a later time. test/functional/iNetworkFunctional.js:79:11
      ✓ retrieves IPv4 network interface info (100ms)

  iObj Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    retrUsrAuth
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:33:19
iObj deprecated As of v1.0, 'iObj.retrUsrAuth()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:35:11
      ✓ returns uses's authority for an object  (75ms)
    rtrCmdInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:78:19
iObj deprecated As of v1.0, 'iObj.retrCmdInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:80:11
      ✓ returns command info (74ms)
    retrPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:131:19
iObj deprecated As of v1.0, 'iObj.retrPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:133:11
      ✓ returns program info (89ms)
    retrSrvPgmInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:206:19
iObj deprecated As of v1.0, 'iObj.retrSrvPgmInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:208:11
      ✓ returns service program info (140ms)
    retrUserInfo
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:262:19
iObj deprecated As of v1.0, 'iObj.retrUserInfo()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:264:11
      ✓ returns specified user profile info (75ms)
    retrUsrAuthToObj
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:289:19
iObj deprecated As of v1.0, 'iObj.retrUserAuthToObj()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:291:11
      ✓ retrieves info for users who are authorized to an object using idb transpsort (75ms)
    addToLibraryList
iObj deprecated As of v1.0, class 'iObj' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:317:19
iObj deprecated As of v1.0, 'iObj.addToLibraryList()' is deprecated and will be removed at a later time. test/functional/iObjFunctional.js:319:11
      ✓ appends lib to user's lib list (67ms)

  iProd Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getPTFInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:33:20
iProd deprecated As of v1.0, 'iProd.getPTFInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:35:12
      ✓ returns info for specified ptf (127ms)
    getProductInfo
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:76:20
iProd deprecated As of v1.0, 'iProd.getProductInfo()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:78:12
      ✓ returns info for specified product (70ms)
    getInstalledProducts
iProd deprecated As of v1.0, class 'iProd' is deprecated and will be removed at a later time. test/functional/iProdFunctional.js:109:20
iProd deprecated As of v1.0, 'iProd.getInstalledProducts()' is deprecated and will be removed at a later time test/functional/iProdFunctional.js:111:12
      ✓ returns info for installed products (867ms)

  iSql Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    prepare & execute
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:34:19
      ✓ prepares & executes stored procedure then fetch results (316ms)
    addQuery & fetch
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:68:19
      ✓ runs a query and fetches results (218ms)
    added test to ensure issue #11 was resolved
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:94:19
      ✓ should parse SQL result set empty data tags correctly (211ms)
    tables
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:121:19
      ✓ returns meta data for specified table (206ms)
    tablePriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:146:19
      ✓ returns privilege data for a table (243ms)
    columns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:173:19
      ✓ returns meta data for a column (266ms)
    columnPriv
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:211:19
      ✓ returns privilege data for a column (242ms)
    procedures
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:240:19
      ✓ returns meta data on for a procedure (208ms)
    pColumns
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:268:19
      ✓ returns meta data for procedure column (250ms)
    primaryKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:307:19
      ✓ returns meta data for a primary key (212ms)
    foreignKeys
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:333:19
      ✓ returns meta data for a foreign key (227ms)
    statistics
iSql deprecated As of v1.0, class 'iSql' is deprecated. Use odbc, idb-connector, or idb-pconnector npm package instead. test/functional/iSqlFunctional.js:368:19
      ✓ returns stats info for table (463ms)
    special
      - returns meta data for special columns
    rowCount
      - returns the number of rows affected by statement

  UserSpace Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    createUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:51:25
iUserSpace deprecated As of v1.0, 'iUserSpace.createUserSpace()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:57:17
      ✓ creates a user space (93ms)
    setUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:75:25
iUserSpace deprecated As of v1.0, 'iUserSpace.setUserSpaceData()' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:79:17
      ✓ sets data within the user space (81ms)
    getUserSpaceData
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:96:25
iUserSpace deprecated As of v1.0, 'iUserSpace.getUserSpaceData()' is deprecated ad will be removed at a later time. test/functional/iUserSpaceFunctional.js:98:17
      ✓ returns specified length of data (75ms)
    deleteUserSpace
iUserSpace deprecated As of v1.0, class 'iUserSpace' is deprecated and will be removed at a later time. test/functional/iUserSpaceFunctional.js:113:25
iUserSpace deprecated As of v1.0, 'iUserSpace.deleteUserSpace()' is deprecated and will be removed at a later time test/functional/iUserSpaceFunctional.js:115:17
      ✓ removes a user space (77ms)

  iWork Functional Tests
-----------------------
transport: idb
verbose: off
-----------------------
    getSysValue
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:34:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:36:12
      ✓ returns the value of system variable (68ms)
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:46:20
iWork deprecated As of v1.0, 'iWork.getSysValue()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:48:12
      ✓ returns an error when the specified system value is invalid
    getSysStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:58:20
iWork deprecated As of v1.0, 'iWork.getSysStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:60:12
      ✓ returns basic system status information about the signed-on users and batch jobs (88ms)
    getSysStatusExt
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:88:20
iWork deprecated As of v1.0, 'iWork.getSysStatusExt()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:90:12
      ✓ returns more detailed system status info (1163ms)
    getJobStatus
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:133:20
iWork deprecated As of v1.0, 'iWork.getJobStatus()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:135:12
      ✓ returns status of specified job (72ms)
    getJobInfo
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:149:20
iWork deprecated As of v1.0, 'iWork.getJobInfo()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:151:12
      ✓ returns info on specfed job (73ms)
    getDataArea
iWork deprecated As of v1.0, class 'iWork' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:200:22
iWork deprecated As of v1.0, 'iWork.getDataArea()' is deprecated and will be removed at a later time. test/functional/iWorkFunctional.js:202:14
      ✓ returns contents of a data area (130ms)

  42 passing (11s)
  3 pending


When using the findUniqueOrThrow method with Prisma, the N+1 problem occurs even though the include option is set, and the related data is not fetched efficiently.

Bug description
I am currently using Prisma version 4.6.1, and findUniqueOrThrow method was working properly. However, after upgrading to version 4.13.0, I have confirmed that the method causes an N+1 problem even when the include option is set.
I have tested with version 4.7.1 and it appears that the issue has been occurring since then.
Please let me know if there's anything I can do to help resolve this issue. Thank you.
How to reproduce
Verifying with Prisma 4.6.1 and 4.7.1 can reproduce the problem.
import { PrismaClient } from '@prisma/client';

const prisma = new PrismaClient({
  log: [
    {
      emit: 'event',
      level: 'query',
    },
  ],
});
prisma.$on('query', (event) => {
  console.log(`Query: ${event.query} took ${event.duration}ms`);
});

async function main() {
  const users = await prisma.user.findMany();
  console.log(`User size: ${users.length}`);
  const posts = await Promise.all(
    users.map(({ id }) =>
      prisma.user
        .findUniqueOrThrow({
          where: {
            id,
          },
          include: {
            posts: true,
          },
        })
        .then((user) => user.posts),
    ),
  ).then((posts) => posts.flat());
  console.log(`Post size: ${posts.length}`);
}

main()
  .catch((error) => console.error(error))
  .finally(() => prisma.$disconnect());

Expected behavior
It would be nice if N+1 would not occur when using findUniqueOrThrow as in version 4.6.1.

Prisma information
Schema

// This is your Prisma schema file,
// learn more about it in the docs: https://pris.ly/d/prisma-schema

generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlite"
  url      = "file:./dev.db"
}

model User {
  id Int @id @default(autoincrement())

  email String  @unique
  name  String?

  posts Post[]

  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
}

model Post {
  id Int @id @default(autoincrement())

  title   String
  content String?

  authorId Int
  author   User @relation(fields: [authorId], references: [id])

  createdAt DateTime @default(now())
  updatedAt DateTime @updatedAt
}

Seed
import { PrismaClient } from '@prisma/client';

const prisma = new PrismaClient();

async function main() {
  console.log('Start seeding...');

  const users = generateUsers(100);
  await Promise.all(users.map((user) => prisma.user.create({ data: user })));

  console.log('Seeding completed.');
}

function generateUsers(count: number) {
  const users = [];
  for (let i = 0; i < count; i++) {
    const email = `user${i +<EMAIL_ADDRESS>    const name = `User ${i + 1}`;
    const posts = generatePosts(2);
    users.push({ email, name, posts: { create: posts } });
  }
  return users;
}

function generatePosts(count: number) {
  const posts = [];
  for (let i = 0; i < count; i++) {
    const title = `Post ${i + 1}`;
    const content = `This is post number ${i + 1}`;
    posts.push({ title, content });
  }
  return posts;
}

main()
  .catch((error) => console.error(error))
  .finally(() => prisma.$disconnect());

Environment & setup

OS: Windows 11 22H2 / WSL: Debian GNU/Linux 11/<IP_ADDRESS>-microsoft-standard-WSL2
Database: MySQL 8.0.30 / SQLite
Node.js version: v16.18.1 / v18.13.0

Prisma Version
Versions checked: 4.6.1/ 4.7.1 / 4.13.0

In our application, we have made the following modifications in the middleware to address the issue temporarily by handling "findUniqueOrThrow" as "findUnique."
import { NotFoundException } from '@nestjs/common';
import { Prisma } from '@prisma/client';

export const batchQueryMiddleware = (): Prisma.Middleware => {
  return async (params, next) => {
    const action = String(params.action);
    if (action !== 'findUniqueOrThrow') {
      return next(params);
    }

    params.action = 'findUnique';
    return next(params).then((result) => {
      if (!result) {
        throw new NotFoundException(
          `Record not found for ${params.model}.${params.args.where}`,
        );
      }

      return result;
    });
  };
};

const prisma = new PrismaClient();
prisma.$use(batchQueryMiddleware());

Related issue: https://github.com/prisma/prisma/issues/16625

This is affecting a large number of Pothos users as well. Hoping we can get this fixed in the next release, but I may just need to work around it in Pothos instead

I think I tracked down the underlying issue: https://github.com/prisma/prisma-engines/pull/4014


Remove the numbering from the catalog examples

It's unclear whether the numbering is providing any reasonable value. If we need to sort examples we should probably do so by adding a feature to the catalog by convention library.

I've removed numerical ordering from the examples as of 3.1.0. We'll continue discussions around example ordering in catalog-by-convention.


add vanilla js basics

Just a start based on Discord feedback

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


PoC - React Query Factory

Description 📝
Introduces a new utility createQueryStore that enables automatic, type-safe management of React query keys.
In this PR, I demonstrate using createQueryStore to manage profile queries.
Changes  🔄
List any change relevant to the reviewer.

...
...

Preview 📷
Include a screenshot or screen recording of the change
:bulb: Use <video src="" /> tag when including recordings in table.

Before
After

📷
📷

How to test 🧪
Prerequisites
(How to setup test environment)

...
...

Reproduction steps
(How to reproduce the issue, if applicable)

...
...

Verification steps
(How to verify changes)

...
...

As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[ ] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>
Commit Types:

feat: New feature for the user (not a part of the code, or ci, ...).
fix: Bugfix for the user (not a fix to build something, ...).
change: Modifying an existing visual UI instance. Such as a component or a feature.
refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
test: New tests or changes to existing tests. Does not change the production code.
upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history

I can see the danger with over-abstraction. My main concern is that if there's a new breaking change to RQ we'd have to reimplement the wrapper. On the other hand, this approach gives us the strongest type-safety, particularly for methods like setQueryData

Closed in favor of @bnussman/query-key.


Find test suites,

Find test suites using expect, on which we can try this out.

knockout.selection
Feature branch with running tests: https://github.com/bramstein/knockout.selection/tree/feature/expectTheUnexpected

I'll volunteer the Podio code base as a beta tester. I'll just need to run some manual changes to get things working

Just updated to unexpected v6. Tested it succesfully on internal projects too... I think it is pretty stable :-)


YouTube Clone

Closes:
Fixes #704

Title : YouTube Clone
Name: :  Patamsetti Sree Vidya
Idenitfy yourself: :  GSSOC

Describe the add-ons or changes you've made 📃
I added Youtube clone
Developed a fully functional YouTube clone that replicates the core features of YouTube
Screenshots 📷

Type of change ☑

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.

Note to reviewers 📄

@Avdhesh-Varshney, kindly view this PR

@Avdhesh-Varshney, view this PR and if any changes required, let me know

@Avdhesh-Varshney, kindly view this PR


Use of version ranges for locally stored dependencies causes failure in JSON schemas aggregation

The plugin generates an error when a dependency point to a local file:
Example of a Chart.yaml dependency:
dependencies:

name: common
version: ^1.0.0
repository: file://../common

When executing the Refresh JSON schema the following stacktrace is raised:
java.net.URISyntaxException: Illegal character in path at index 23: https://default/common/^0.0.0 at java.base/java.net.URI$Parser.fail(URI.java:2974) at java.base/java.net.URI$Parser.checkChars(URI.java:3145) at java.base/java.net.URI$Parser.parseHierarchical(URI.java:3227) at java.base/java.net.URI$Parser.parse(URI.java:3175) at java.base/java.net.URI. (URI.java:623) at io.github.fstaudt.helm.JsonSchemaGenerator.toRelativeUri(JsonSchemaGenerator.kt:138) at io.github.fstaudt.helm.JsonSchemaGenerator.putGlobalProperties(JsonSchemaGenerator.kt:75) at io.github.fstaudt.helm.JsonSchemaGenerator.generateValuesJsonSchema(JsonSchemaGenerator.kt:50) at io.github.fstaudt.helm.JsonSchemaAggregator.aggregate(JsonSchemaAggregator.kt:44) at io.github.fstaudt.helm.idea.service.HelmChartService.aggregate(HelmChartService.kt:59) at io.github.fstaudt.helm.idea.tasks.AggregateTask.run(AggregateTask.kt:13) at com.intellij.openapi.progress.impl.CoreProgressManager.startTask(CoreProgressManager.java:429) at com.intellij.openapi.progress.impl.ProgressManagerImpl.startTask(ProgressManagerImpl.java:114) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsynchronously$6(CoreProgressManager.java:480) at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$3(ProgressRunner.java:252) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:186) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$executeProcessUnderProgress$13(CoreProgressManager.java:604) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:679) at com.intellij.openapi.progress.impl.CoreProgressManager.computeUnderProgress(CoreProgressManager.java:635) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:603) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:60) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:173) at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:252) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:702) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:699) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:699) at java.base/java.lang.Thread.run(Thread.java:833)

I just saw you already took care of local repository addresses here https://github.com/fstaudt/helm-values/issues/30.
The problem is in fact related to the ^ in front of the version number which is not supported.

Hello @cm0s ,
thanks for reporting the issue.
Issue seems indeed related to use of version ranges in chart dependencies.
Version ranges are currently not supported by the plugin, I still need to add it.

@cm0s
generation of JSON schemas has been fixed in plugin for locally stored dependencies.
Issue https://github.com/fstaudt/helm-values/issues/94 has been created to support version ranges for dependencies having JSON schemas stored in external repositories:\


Can make magic link work cross devices?

Please refer to the documentation, the example project and existing issues before creating a new issue.
Your question
Can make magic link work cross devices?
What are you trying to do
Given passwordless & magic link signin, is it possible to add the feature that kind of scenario:

I start signin process on my desktop
I open email with magic link on my phone and click on it
I get logged in on my desktop as on my phone

Documentation feedback
Documentation refers to searching through online documentation, code comments and issue history. The example project refers to next-auth-example.

[ ] Found the documentation helpful
[ ] Found documentation but was incomplete
[ ] Could not find relevant documentation
[ ] Found the example project helpful
[ ] Did not find the example project helpful

This isn't currently supported, but would welcome something like this as a feature request!
I would love to have session management and sign in / sign out be possible across devices.


add phone required to rate estimate

Problem
Some shipping rates require a phone number.
Solution
Add phone required to the shipping estimate.
Review: @kmcphillips @mdking
cc: @jnormore

:+1:


Mamba support

Changes:
cfg has the following new fields:

model_class: By default this is HookedTransformer, but can be changed to HookedMamba
hook_point_eval: Before this was hardcoded
model_kwargs: passed into all calls to the model (useful because you can enable the kernel support with {"fast_ssm": True, "fast_conv": True}

Fixes the get_name() function to still provide valid file paths when model paths have / in them (the typical model used is state-spaces/mamba-370m)
Prevent divide by zero in evals

Thanks @Phylliida  for making mamba-lens a package https://pypi.org/project/mamba-lens/
@chanind may have time to make the required changes :) Otherwise I'll get to it soon.

Ah excellent! I'll work on this today or tomorrow

@Phylliida I added a test case for loading a mamba model, but this test is currently failing. I think this is on mamba-lens's side. This test is just calling HookedMamba.from_pretrained("state-spaces/mamba-370m", device="cpu").
The error is ValueError: mutable default <class 'mamba_lens.HookedMamba.MambaInitCfg'> for field initializer_cfg is not allowed: use default_factory

@chanind ok that should be fixed now, I released a new version of mamba-lens on pypi

@Phylliida It looks like it's still not fixed. The issue is the following line: https://github.com/Phylliida/MambaLens/blob/main/mamba_lens/HookedMamba.py#L294C37-L294C49
Specifically, this has the following:
initializer_cfg: MambaInitCfg = MambaInitCfg()

This should be changed to
from dataclasses import field

initializer_cfg: MambaInitCfg = field(default_factory=MambaInitCfg)

It looks like this only errors in Python 3.11+, but it's good practice in general to never set mutable defaults on dataclasses without using default_factory. The problem is that the way this is set, if you create 2 instances of MambaCfg, they will share the same initializer_cfg object, so changing one initializer_cfg will change both of their initializer_cfgs.
e.g.
cfg1 = MambaCfg()
cfg2 = MambaCfg()

cfg1.initializer_cfg.dt_scale = 7.0
print(cfg2.initializer_cfg.dt_scale) # this will print 7.0 as well now

very sorry I thought I had made that change but for some reason it didn't go through, try it now

Looks like that worked! Just merged


fix 9521 Tab nav link error count is not correctly pluralised for screen readers

fixes issue https://github.com/wagtail/wagtail/issues/9521
the template tab-nav-link takes up  a template variable which is actually "fake" since it has nothing
and its been used into the template to display errors
actual code for class assignments and error statements resides in a js file hence i came up with fix that actually pluralize errors via js

i think we should also add some comments in the template making it clear that this template is supposed to be populated by client side code. that would make it easier for other contributors who might happened to stumble upon it

Sorry you will need to import ngettext
import { ngettext } from '../../utils/gettext';

@lb- thanks a lot for such a blazing fast review, i would love to work on the review suggestions, gonna begin working on it in few hours of time.

@lb- i have made the changes, review at your ease.


CSV Lookup builtin plugin

Types of changes

[ ] Enhancement (project structure, spelling, grammar, formatting)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

A description of the changes proposed in the Pull Request

This pull request adds CSV Lookup plugin to if framework's builtins.
Covers the introduced changes with documentation and unit tests.
Adds appropriate manifests samples.

@narekhovhannisyan When a value of output field is a two dimensional array and arrays contain only one field name, the output is broken.

@narekhovhannisyan When plugin output is "*", outputs contain duplicates from query.

@narekhovhannisyan please also check, all exported values are string.

@MariamKhalatova I've pushed fixes, please check


Fix subscribeStorage

A minor error prevented successful storage subscriptions. I tested this fix in our app and it works.

would you mind reviewing and testing @justkawal ? i'm ooo

would you mind reviewing and testing @justkawal ? i'm ooo

would you mind reviewing and testing @justkawal ? i'm ooo

Released under polkadart 0.2.6


Reformat README

Add .rst extension. Github didn't aware of it.
Reformat code block and domain list

excellent, many thanks


Make a small adjustment to hack/update-deps.sh

This form should be more hospitable to running things to auto-update knative/test-infra.
I canaried this change in knative/sample-controller, and was able to produce: https://github.com/knative/sample-controller/pull/11

/retest

/lgtm


Shortcut commads are not working in fresh tabs

ctrl + k shortcut is not working when the browser is in a fresh new tab.

Duplicate of #21. Sadly Chrome Extensions cannot be injected in the new tab :(

I've done a workaround and it should be working now.


Do we really need the "Additional Fields" toggle?

It's OK w/ me, but feels like clutter for not that much more--especially w/ Access Controls off to the side.

Yeah, I wondered about this too. If there are a significant number of fields I could see it, but as is maybe we just make everything a primary_field.

👍

I moved everything over. The button's still there, but it doesn't do anything. Made https://github.com/projecthydra-labs/hyrax/issues/481 and closing this.


Is multi-level menu supported?

The following syntax seems providing a root menu spot, is there someway I can make more than two levels of menu to organize our components?
{
"$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
"menu": {
"submenu": ["My Bot Actions"]
}
}

@dawwa this is possible, please refer to our new UI Schema documentation to see how to accomplish this.
The example from the docs:
{
  "menu": {
    "submenu": ["Microsoft Teams", "Get Teams Info"]
  }
}

Output:


Actually fix the link hover color

Ahem ;)

Yay, it actually worked this time! \o/

Thanks again! :) \o/


Adds query parameters field option

base-field-widgets beforeConstruct again. Soon to be all the same.

If built into the form form widget then I would want to make it enabled by an option. Having this as a separate widget is one way to 1) not require all apos-form users to enable it and 2) not include it in all forms.
It also has the built in ability to name the document property via the field name, rather than dictating what that will be (if one is whitelisting parameter keys they may prefer to name it something other than "query parameters"). Theoretically one could also have multiple fields like this named different things to capture different parameters. One might capture user type or product preferences and another might capture referral information (e.g., they got to the form from a newsletter).
The other idea we originally discussed that led to this was that the original request was to have a widget for a hidden field that could be flexible to do various things such as capturing query parameters (but not specifically and exclusively that). We decided to build this for the specific feature, but it also can serve as an example of a hidden field widget used to do that sort of thing.
I'll go ahead with the apos.utils update for now. Let me know what you think.

Hmmm. I take your point, but people can add form-level features as well as new form field widgets following our example(s), so I'm not sure anything is lost in terms of being instructive about how to add functionality.
My feeling is that widgets in an area are positional, visual things and if they are in reality neither visible nor position-dependent then a widget is the wrong abstraction.
So I suggest an array field, with both "name" and "label" fields to address your concern about potentially cryptic query parameter names.
As long as it is an array field, I don't see why an option is needed to enable it. No one has to whitelist any fields; if you don't whitelist any fields, no query parameters are captured... um, right?

For clarification, is this one array field for query param groups with a name field for the document property and then another nested array field for the list of parameter keys to capture?
Doing it at the form level could be fine, but I think this still needs to be a thing that's enabled. For one, whenever possible there should not be any UI that isn't useful. A query param vacuum isn't going to be used by the majority of users of this module, so presence of fields for it only creates confusion. As the requirements were defined, one use case is sucking up everything (no whitelist involved). So simply leaving out a whitelist wouldn't help with that unless there's another toggle.

OK, if we have to have a no-whitelist option then certainly there must be
at least a boolean field you select to turn the feature on at all, which
then uses showFields to toggle the whitelist, etc.
On Thu, Jun 20, 2019 at 2:40 PM Alex Bea<EMAIL_ADDRESS>wrote:

For clarification, is this one array field for query param groups with a
name field for the document property and then another nested array field
for the list of parameter keys to capture?
Doing it at the form level could be fine, but I think this still needs to
be a thing that's enabled. For one, whenever possible there should not be
any UI that isn't useful. A query param vacuum isn't going to be used by
the majority of users of this module, so presence of fields for it only
creates confusion. As the requirements were defined, one use case is
sucking up everything (no whitelist involved). So simply leaving out a
whitelist wouldn't help with that unless there's another toggle.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/apostrophe-forms/pull/64?email_source=notifications&email_token=AAAH27MI5SVXY3KYCNNZT7LP3PFK7A5CNFSM4HZND3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYGIOJY#issuecomment-504137511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAH27KO4NG4YRMCH65QJI3P3PFK7ANCNFSM4HZND3PA
.

--
Thomas Boutell, Chief Software Architect
P'unk Avenue |<PHONE_NUMBER>  |  punkave.com

Still prefer this to a widget.
On Thu, Jun 20, 2019 at 4:08 PM Tom Boutell<EMAIL_ADDRESS>wrote:

OK, if we have to have a no-whitelist option then certainly there must be
at least a boolean field you select to turn the feature on at all, which
then uses showFields to toggle the whitelist, etc.
On Thu, Jun 20, 2019 at 2:40 PM Alex Bea<EMAIL_ADDRESS>wrote:

For clarification, is this one array field for query param groups with a
name field for the document property and then another nested array field
for the list of parameter keys to capture?
Doing it at the form level could be fine, but I think this still needs to
be a thing that's enabled. For one, whenever possible there should not be
any UI that isn't useful. A query param vacuum isn't going to be used by
the majority of users of this module, so presence of fields for it only
creates confusion. As the requirements were defined, one use case is
sucking up everything (no whitelist involved). So simply leaving out a
whitelist wouldn't help with that unless there's another toggle.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/apostrophe-forms/pull/64?email_source=notifications&email_token=AAAH27MI5SVXY3KYCNNZT7LP3PFK7A5CNFSM4HZND3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYGIOJY#issuecomment-504137511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAH27KO4NG4YRMCH65QJI3P3PFK7ANCNFSM4HZND3PA
.

--
Thomas Boutell, Chief Software Architect
P'unk Avenue |<PHONE_NUMBER>  |  punkave.com

--
Thomas Boutell, Chief Software Architect
P'unk Avenue |<PHONE_NUMBER>  |  punkave.com

@boutell This is updated. I'm not seeing the utils method you mentioned. Do you remember what it's called?

I... imagined it? Weird. Could've sworn.
You need to uriDecodeComponent each field name and value.
On Thu, Jun 20, 2019, 6:06 PM Alex Bea<EMAIL_ADDRESS>wrote:

@boutell https://github.com/boutell This is updated. I'm not seeing the
utils method you mentioned. Do you remember what it's called?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/apostrophe-forms/pull/64?email_source=notifications&email_token=AAAH27PUKHSKS6Z4ZMGQ6YDP3P5PJA5CNFSM4HZND3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYG33WI#issuecomment-504217049,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAH27NIGUWGOGQBRQTLPFDP3P5PJANCNFSM4HZND3PA
.


Error: No panel/.mcd/.txt file found

I'm using this example to run steinbock: https://bodenmillergroup.github.io/IMCDataAnalysis/prerequisites.html
I'm at:
raw data preprocessing
steinbock preprocess imc panel --namecol Clean_Target
After  running that line I got the: Error: No panel/.mcd/.txt file found
Any advise on how I can fix this problem? I'm new at using a docker and new to analyzing IMC data.

Hi @icepsi23
It appears that you are missing some files or that they are not in the expected location. Please check that you have the necessary files at expected locations, as specified here. If you execute all commands in 4.3 successfully, that should be the case, therefore make sure all commands in 4.3 up the error causing line are executed successfully.

I actually have the panel file on the folder, and have run successfully run the 4.3 section successfully.

In that case I am afraid your error is not reproducible, I ran 4.3 from scratch and everything works fine. Is the above the content of your raw folder? You can try to provide the path(s) to the relevant files explicitly:

Yes, the above is my raw folder. I figure out the problem was the linux support software that I was using. Thank you for your help.


<EMAIL_ADDRESS>this library is no longer supported

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
getting this error please help
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑

Duplicate of https://github.com/angular/angular-cli/issues/20994