Why is importing models so complicated in Godot 3.0

In Unity I am able to very easily drag and drop a 3D model. It can be saved as a blend file or as a fbx file and it would work just perfectly fine.
How come in Godot 3.0 it is more complicated. I have to first export the model using better collada add on for Blender, and then I have to import the model etc?

FBX is an exported format.
As for better collada, it is because those editors don't actually do it correctly with their built in exporters, whether due to rushed implementations or otherwise. The better collada addon is there to remedy the fact that the exported format is totally broken, or at least is missing components.
Unity can license out the FBX importer (as far as I know, FBX requires licensing from autodesk - something which an open source project will rarely have the funds to do), and a blend file is a lot more complex than just a model or mesh, as it contains things like application settings, thumbnails, layer data, and loads of information you'd expect to work with godot, but it can't without baking it down every single time it loads up the editor.
Instead, Godot opts for open, well documented formats. DAE (collada) is one such format.

Hi Andrew,
I am seriously having confusions as to how to import a dae file format on
Godot 3.0. can you please give me a step by step guide please?
On Sun, Dec 10, 2017 at 1:21 PM, Andrew Silver<EMAIL_ADDRESS>wrote:

FBX is an exported format.
As for better collada, it is because those editors don't actually do it
correctly with their built in exporters, whether due to rushed
implementations or otherwise. The better collada addon is there to remedy
the fact that the exported format is totally broken, or at least is missing
components.
Unity can license out the FBX importer (as far as I know, FBX requires
licensing from autodesk - something which an open source project will
rarely have the funds to do), and a blend file is a lot more complex than
just a model or mesh, as it contains things like application settings,
thumbnails, layer data, and loads of information you'd expect to work with
godot, but it can't without baking it down every single time it loads up
the editor.
Instead, Godot opts for open, well documented formats. DAE (collada) is
one such format.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-350520262,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BlumCzDJgjFLRl4ei2QBPxrKnnj2ks5s-0A0gaJpZM4Q8VgN
.

Dae files should auto-import into Godot just like models auto import into Unity. Just make sure it's somewhere in the project folder and it will create a scene file that you can use. :)

Unity opens .blend files by actually calling blender to export an fbx and reading it, we can't do this because Blender does not come with any useful exporter for us out of the box. Maybe if they ever merge the GLTF2 importer we will be able to do the same.
Regarding FBX support, some users are working on FBX support via GDNative, which should be super easy to install once 3.0 is out, you will be able to get it from the asset library.

Well I do see a readable file so do I just click and drag it?
On Sun, Dec 10, 2017 at 1:55 PM, Nathan<EMAIL_ADDRESS>wrote:

Dae files should auto-import into Godot just like models auto import into
Unity. Just make sure it's somewhere in the project folder and it will
create a scene file that you can use. :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-350521360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BmUDWNORz-wbsZ3ua7ueir7pybe1ks5s-0ghgaJpZM4Q8VgN
.

@Raj2032 - Just put your DAE file in your godot project directory (assuming 3.0)
Would be nice to have tighter integration with blender.

godot might support blend directly in the near future . is a feature that has been debated on and off. right now i think the devs are working on other features that have higher priority thus i think they need to be focusing on that first

@Raj2032 Godot 3.0 works a lot like Unity as far as importing assets easily and non-destructively. If you've used Godot 2.x before you'll need to unlearn it since the import workflow is now completely different. You should be able to drag and drop in assets if you want to, but keep in mind it will make a copy of the asset, so any changes you make you'll want to do to the project copy that you dragged in, not the original. I usually just export my Blender/Modo/etc file directly, overwriting the existing dae file.

HI Nathan,
First of all how do you export the object to ensure its material properties
are coming up, and also when you first exported your materials, did it turn
to the colour blue? If so may I know what you did to remove the blue colour
in your ojbect?
On Mon, Dec 11, 2017 at 11:46 AM, Nathan<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 Godot 3.0 works a lot like Unity as
far as importing assets easily and non-destructively. If you've used Godot
2.x before you'll need to unlearn it since the import workflow is now
completely different. You should be able to drag and drop in assets if you
want to, but keep in mind it will make a copy of the asset, so any changes
you make you'll want to do to the project copy that you dragged in, not the
original. I usually just export my Blender/Modo/etc file directly,
overwriting the existing dae file.
[image: screenshot from 2017-12-10 19-39-37]
https://user-images.githubusercontent.com/629422/33811513-6506406e-dde2-11e7-8624-09273db1010a.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-350596781,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BhPReFvXODM-VpR3mcvgVRQWYhLkks5s_HtngaJpZM4Q8VgN
.

By default Godot uses the environment to light your object, so the blue color is actually coming from the environment, not the material itself. If you look just to the left of the image I added above, that's the default environment. Double click on that and you can change the settings. Don't forget to save it by clicking the save/disk icon in the inspector or it will revert the settings the next time you open Godot :)
Another option, which would be more realistic for outdoors than changing the environment, would be to add a directional light, rotate it how you'd like, and then tint it with a very slight reddish color. This would represent a more realistic look to your scene. :)

Here are some images regarding lighting from my previous post:
Before Adding a Light

After Adding a Light

Cycles materials won't be exported as they are something specific to Blender.

For materials, you want to use blender eevee I believe. The materials for that should be cross compatible. It isn't in the current mainline version of blender, but the current beta has it.

@Raj2032 To be honest I haven't exported any animations out of Blender into Godot yet, so I couldn't help you there. As for cycles materials, I'd have to go with what @Zireael07 and @Silvea12 said. I typically just use the standard materials in Blender which seem to export fine for me.

Hi all
So using the obj format I am able to export my materials but for some
reason the objects are reflective, how do I fix this issue? Also is the
materials supposed to be exported as well under Blender Render using the
Better Collada addon?
On Tue, Dec 12, 2017 at 5:04 AM, Nathan<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 To be honest I haven't exported any
animations out of Blender into Godot yet, so I couldn't help you there. As
for cycles materials, I'd have to go with what @Zireael07
https://github.com/zireael07 and @Silvea12 https://github.com/silvea12
said. I typically just use the standard materials in Blender which seem to
export fine for me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-350806677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BnDBsLzb09-CvqgNm3fpNmOHVxY-ks5s_W6lgaJpZM4Q8VgN
.

Hmmm, if they're being reflective, you may want to check and make sure the Metallic value under the Metallic foldout is set to 0.
I think the Blender render ones will export, but I'm not so sure about that if they are using a node graph. I know that they should if the materials are used in the generic, non-node graph, way. Someone else who uses Blender more would be better suited to answer that question more accurately. :)

Hi Nathan,
Where do I go to find the metallic foldout?
Also I just had a play around with Blender 2.8 and using the Eevee render,
when I exported my object using the obj format, the object would not appear
at all in Godot, is there something I have to do? I did use the better
collada addon for Blender but for some reason I am getting an error
everytime I try and export it using that.
On Tue, Dec 12, 2017 at 3:45 PM, Nathan<EMAIL_ADDRESS>wrote:

Hmmm, if they're being reflective, you may want to check and make sure the
Metallic value under the Metallic foldout is set to 0.
I think the Blender render ones will export, but I'm not so sure about
that if they are using a node graph. I know that they should if the
materials are used in the generic, non-node graph, way. Someone else who
uses Blender more would be better suited to answer that question more
accurately. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-350944046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bs7QMCKiYOlf7QLHiqR5oLB5zFSJks5s_gT8gaJpZM4Q8VgN
.

@Raj2032 Wavefront (OBJ) spec defines that the default material is phong shaded. That is why your stuff is glossy. You may want to use .dae or just edit the material manually - your .mtl file won't help you.

For materials: I use the gltf-Format with the Khronos exporter+node-group (For Cycles)
https://github.com/KhronosGroup/glTF-Blender-Exporter

Wavefront (OBJ) spec defines that the default material is phong shaded. That is why your stuff is glossy. You may want to use .dae or just edit the material manually - your .mtl file won't help you.

OBJ/MTL files don't support PBR materials, so you will have to use glTF 2.0 (as Collada doesn't support PBR materials either, IIRC).

I am going to try and use the gltf-Format with the Khronos. @MrJustreborn I
wanted to know do I just install the one file in Blender as provided in the
link?
On Wed, Dec 13, 2017 at 12:30 AM, Hugo Locurcio<EMAIL_ADDRESS>wrote:

Wavefront (OBJ) spec defines that the default material is phong shaded.
That is why your stuff is glossy. You may want to use .dae or just edit the
material manually - your .mtl file won't help you.
OBJ/MTL files don't support PBR materials, so you will have to use glTF
2.0 (as Collada doesn't support PBR materials either, IIRC).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351051427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BuNXwpe5Tfe6-WjOS8bk6gJzKY-wks5s_n_lgaJpZM4Q8VgN
.

Is it possible to leverage Assimp for doing model loading into Godot resources?  This would open the door to a lot of formats instead of fussing with plugins for blender and other software.

@Raj2032 It's very simple to install a extension: https://github.com/KhronosGroup/glTF-Blender-Exporter#installation
Here is a  installationguid for extension: https://blender.stackexchange.com/a/1689
How to use the glTF-Extension is documented here: https://github.com/KhronosGroup/glTF-Blender-Exporter/blob/master/docs/user.md

I understand how to install extensions but I don't understand this "I use
the gltf-Format with the Khronos exporter+node-group" Are these two
seperate addons?
On Wed, Dec 13, 2017 at 6:22 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 It's very simple to install a
extension: https://github.com/KhronosGroup/glTF-Blender-
Exporter#installation
Here is a installationguid for extension: https://blender.stackexchange.
com/a/1689
How to use the glTF-Extension is documented here: https://github.com/
KhronosGroup/glTF-Blender-Exporter/blob/master/docs/user.md
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351305544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Buid-CxjSJmYXACbKJjs23Nwq6whks5s_3tNgaJpZM4Q8VgN
.

No, the exporter is the extension and the node-group a just a node-group for the PBR-Material.
It's documented here: https://github.com/KhronosGroup/glTF-Blender-Exporter/blob/master/docs/user.md
Just link the group and use it for your materials.

I downloaded the zip file and then in Blender I went to addons, install
from file, so then I selected the zip file that I downloaded from the link
you have provided, but then it showed this (let me know if you did not get
an image)
[image: Inline image 1]
so how do I activate this addon as I can't find it?
On Wed, Dec 13, 2017 at 8:11 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

No, the exporter is the extension and the node-group a just a node-group
for the PBR-Material.
It's documented here: https://github.com/KhronosGroup/glTF-Blender-
Exporter/blob/master/docs/user.md
Just link the group and use it for your materials.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351329165,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bj3aju-dC-OhyNJlz3ekhiHLzMHcks5s_5S6gaJpZM4Q8VgN
.

@Raj2032 I can't see the image.
What ZIP did you download? - The Link is a GitHub-Repo, that you could download as ZIP but the addon is in the "scripts" folder. How to install this addon is documented here:

Otherwise, copy the io_scene_gltf2 folder to the scripts/addons folder of your Blender installation.
https://github.com/KhronosGroup/glTF-Blender-Exporter/tree/master/scripts#scripts

Hey man, thank you very much :)
On Fri, Dec 15, 2017 at 6:58 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 I can't see the image.
What ZIP did you download? - The Link is a GitHub-Repo, that you could
download as ZIP but the addon is in the "scripts" folder. How to install
this addon is documented here:
Otherwise, copy the io_scene_gltf2 folder to the scripts/addons folder of
your Blender installation.
https://github.com/KhronosGroup/glTF-Blender-Exporter/tree/master/scripts#
scripts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351938521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BmjiU8xJcFizXYp9Q8lR5tLbr8crks5tAiajgaJpZM4Q8VgN
.

Hey man
In this link
https://github.com/KhronosGroup/glTF-Blender-Exporter/raw/master/docs/glTF_03_Blender_Link_Material.png
Where do I find the links?
On Sat, Dec 16, 2017 at 1:25 AM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey man, thank you very much :)
On Fri, Dec 15, 2017 at 6:58 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 I can't see the image.
What ZIP did you download? - The Link is a GitHub-Repo, that you could
download as ZIP but the addon is in the "scripts" folder. How to install
this addon is documented here:
Otherwise, copy the io_scene_gltf2 folder to the scripts/addons folder of
your Blender installation.
https://github.com/KhronosGroup/glTF-Blender-Exporter/tree/
master/scripts#scripts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351938521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BmjiU8xJcFizXYp9Q8lR5tLbr8crks5tAiajgaJpZM4Q8VgN
.

Nevermind I found it
On Sun, Dec 17, 2017 at 5:54 PM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey man
In this link https://github.com/KhronosGroup/glTF-Blender-
Exporter/raw/master/docs/glTF_03_Blender_Link_Material.png
Where do I find the links?
On Sat, Dec 16, 2017 at 1:25 AM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey man, thank you very much :)
On Fri, Dec 15, 2017 at 6:58 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 I can't see the image.
What ZIP did you download? - The Link is a GitHub-Repo, that you could
download as ZIP but the addon is in the "scripts" folder. How to install
this addon is documented here:
Otherwise, copy the io_scene_gltf2 folder to the scripts/addons folder
of your Blender installation.
https://github.com/KhronosGroup/glTF-Blender-Exporter/tree/m
aster/scripts#scripts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351938521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BmjiU8xJcFizXYp9Q8lR5tLbr8crks5tAiajgaJpZM4Q8VgN
.

How do I make the node group glTF Metallic Roughness exactly the same as my
Diffuse BSDF? Here is the link to my full question
https://blender.stackexchange.com/questions/96713/i-am-using-the-gltf-addon-how-do-i-make-my-node-group-gltf-metallic-roughness-e
On Sun, Dec 17, 2017 at 7:14 PM, Joe Smith<EMAIL_ADDRESS>wrote:

Nevermind I found it
On Sun, Dec 17, 2017 at 5:54 PM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey man
In this link https://github.com/KhronosGroup/glTF-Blender-Exporter/
raw/master/docs/glTF_03_Blender_Link_Material.png
Where do I find the links?
On Sat, Dec 16, 2017 at 1:25 AM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey man, thank you very much :)
On Fri, Dec 15, 2017 at 6:58 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

@Raj2032 https://github.com/raj2032 I can't see the image.
What ZIP did you download? - The Link is a GitHub-Repo, that you could
download as ZIP but the addon is in the "scripts" folder. How to install
this addon is documented here:
Otherwise, copy the io_scene_gltf2 folder to the scripts/addons folder
of your Blender installation.
https://github.com/KhronosGroup/glTF-Blender-Exporter/tree/m
aster/scripts#scripts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-351938521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BmjiU8xJcFizXYp9Q8lR5tLbr8crks5tAiajgaJpZM4Q8VgN
.

Hey,
sorry but I'm NOT an expert in PBR-Materials. I can't help you here.

Oh ok thanks,
When exporting the object, is everything that is appropriate selected by
default?
When I exported my object, in Godot in the left panel, I see two thing, one
is Cube.gltf and the other one is .mesh (check out the link to see the
image) https://i.stack.imgur.com/eJvFV.png
Which one do I drag into the 3D world?
On Sun, Dec 17, 2017 at 7:23 PM, MrJustreborn<EMAIL_ADDRESS>wrote:

Hey,
sorry but I'm NOT an expert in PBR-Materials. I can't help you here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-352239816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79Bk5RaG39EeyxBUTH_3CTvzwGF17Pks5tBM-PgaJpZM4Q8VgN
.

You'll want to drag the Cube.gltf into the scene. The mesh is a resource, just like in Unity. The gltf file is more like a prefab.

Yo, sup.
For animations, you'll want to hit the "Export Animation" and "All Actions" tickbox on the left when you go to export the Collada file. Those options'll be on the left-hand side of the file browser in Blender.

For animations, you'll want to hit the "Export Animation" and "All
Actions" tickbox on the left when you go to export the Collada file. Those
options'll be on the left-hand side of the file browser in Blender.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-352272848,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BiW0MAf7DMN4Zf6JjHL1fQ36WVx4ks5tBVRdgaJpZM4Q8VgN
.

Can we natively code in GDNative (this is C++)?
On Mon, Dec 18, 2017 at 11:07 AM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey,
Thanks for your guy's help, shit is just starting to work now finally, so
glad things are fine now, thanks for everyone's help :)
On Mon, Dec 18, 2017 at 4:50 AM, SolarLune<EMAIL_ADDRESS>wrote:

Yo, sup.
For animations, you'll want to hit the "Export Animation" and "All
Actions" tickbox on the left when you go to export the Collada file. Those
options'll be on the left-hand side of the file browser in Blender.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-352272848,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BiW0MAf7DMN4Zf6JjHL1fQ36WVx4ks5tBVRdgaJpZM4Q8VgN
.

How do we set up GDNative? As I am so confused?
On Mon, Dec 18, 2017 at 8:52 PM, Joe Smith<EMAIL_ADDRESS>wrote:

Can we natively code in GDNative (this is C++)?
On Mon, Dec 18, 2017 at 11:07 AM, Joe Smith<EMAIL_ADDRESS>wrote:

Hey,
Thanks for your guy's help, shit is just starting to work now finally, so
glad things are fine now, thanks for everyone's help :)
On Mon, Dec 18, 2017 at 4:50 AM, SolarLune<EMAIL_ADDRESS>wrote:

Yo, sup.
For animations, you'll want to hit the "Export Animation" and "All
Actions" tickbox on the left when you go to export the Collada file. Those
options'll be on the left-hand side of the file browser in Blender.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14489#issuecomment-352272848,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ab79BiW0MAf7DMN4Zf6JjHL1fQ36WVx4ks5tBVRdgaJpZM4Q8VgN
.

This issue tracker is for bug reports and well-defined enhancements requests to implement in the engine, not for user support. Please use one of the other community channels for that: http://godotengine.org/community


webforms version

Hello and thanks for the software.
I'm trying to use webmethods and webforms but i have no luck.I'm using jquery in order to submit the formdata and i have tried a lot of ways but nothing until now!
Do you have any ideas?
And one second question which is important.As i can see you have a timeslice parameter and i know that a lot of people have written about it.My question is if i can ignore it.I mean that i don't want to use slices just press record,stop recording and then send the file to the web server(iis in my case).
Thanks!

RecordRTC do NOT support timeSlice. This feature is available on a separate implementation, here:

https://github.com/streamproc/MediaStreamRecorder

Did you test ASP.NET MVC demo?

https://github.com/muaz-khan/RecordRTC/tree/master/RecordRTC-to-ASPNETMVC

You've to enable maximum file upload via web.config file.
<configuration>
  <system.web>
    <httpRuntime maxRequestLength="1000000" /> <!-- 1000 MB -->
  </system.web>
  <system.webServer>
    <security>
      <requestFiltering>
        <requestLimits maxAllowedContentLength="52428800" /> <!--50 MB-->
      </requestFiltering>
    </security>
  </system.webServer>
</configuration>

For more info: http://stackoverflow.com/a/288675/552182

You are correct about the slice.My mistake!
About the other issue.The MVC version works correctly!
I just wanted to make it work on webforms(not mvc) but i'm having issues passing the files in the webmethod.I will try to find a solution and post a reply here in case someone would like to use it.
Thanks again!


MK3 teensy calibration code occasionally stuck in loop

Hi,
I've found that sometimes the calibration fails and one (or more) joints do not reach the goal. In these cases the teensy code gets stuck at the loop "while (!restPosReached)" in the calibration code, and won't resume operation without a reboot.
Since the MK3 already has a push button, the code could implement an ISR interrupt, setting a flag "x" to abort whatever loop is going on for cases like this.
I will investigate this further, but here are some preliminary findings (running the code directly from serial, not using ros), and just calling "JC".
The arm is reaching for:
{75556,   23333,  49444,   89600,   11477,  40000};
One time it was stuck, I debugged the values to
75653, 22481, 49547, 89507, 11242, 40101, where we can see values are still off, but the arm has stopped moving.
Another time stuck at
75653, 23249, 49546, 44967, 11432, 40099, where D is very far off (obviously this was very visible on the arm as well).
And now starting ros2 it has happened for the last joint, which stopped ca. 90 degrees before the goal.

Might be related to faulty encoder signals, this has happened less frequently after installing small caps at the end of the encoder wires.

It still happens. What is weird is that when it happens, giving the joint a physical nudge resumes it's movement and then it goes all the way fine.

Thanks for reporting the issue, will try implement a timeout mechanism for the calibration process, so that on the ROS side we can detect the failure and handle it accordingly.

implemented https://github.com/ycheng517/ar4_ros_driver/pull/22 which can help

I experienced some inconsistency in the robot returning to the home position at the end of the calibration routine as well, and this commit seems to help: https://github.com/ycheng517/ar4_ros_driver/commit/cbd5ef4b0914bb656a27ac53ff7b962b47f2505b
I can now calibrate successfully 6x in a row whereas before I would see a failure every 2-3 attempts.

switching limit swtiches to bounce2 in https://github.com/ycheng517/ar4_ros_driver/pull/28 should've also mitigated this issue. Closing due to staleness.


3D Dam Break With an Obstacle Example - VOF

Documentation
Write 3D Dam Break With an Obstacle example

[x] lethe/doc/source/examples/multiphysics/3d-dam-break/3d-dam-break.rst

Add to parent directory :

[x] lethe/doc/source/examples/multiphysics/vof.rst

Future changes

Low-viscosity fluid simulation needs to be improved

@AmishgaAlphonius just ping me when you think this is ready for a merge :)


Auto-select language?

As the interface is translated in many languages, I'd like to know if it is possible to select it automatically based on the user's browser / regional settings instead of having a prefixed selection in the configuration.php. Something like 'language' => 'auto'.
A big thanks to you for this project!!

Hi,
No, this is not possible at the moment, but I will leave this here as a feature request.
Cheers!

Hi,
No, this is not possible at the moment, but I will leave this here as a feature request.
Cheers!

It would be awesome, so I support the idea.


feat: add protobuf 3.23.4 release

update protobuf with release 3.23.4

:tada: This PR is included in version 1.157.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can I paste any custom string in rename input block?

Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to paste some custom string into rename input block, but it only can paste the value which is waiting for being renamed,
Describe the solution you'd like
I want to paste something else into rename input block.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I find a way to custom the clipboard in vim, this will be closed, thx~


windows 10 display rendering wrong

Windows 10 does not render the file menu properly, and the add credential window is shifted up by 20 pixels or so.

The behavior is the same with Windows 10 in dark or light mode.

Thanks for the report, this do sound similar to this issue: https://github.com/Yubico/yubioath-desktop/issues/161 A fix for it will be included in the next release. To verify that it is the same, could you try this development build?
https://yubico-builds.s3-eu-west-1.amazonaws.com/yubioath-desktop/yubioath-desktop-master--HEAD-win.zip
Just unzip the archive and run the app from the folder, no installer needed.

works for the file menu.  my yubikey doesn't recognize over remote desktop
so can't see if it fixes the screen being shifted, but will report back
asap when i install the dev build on another machine.
On Thu, Aug 17, 2017 at 12:58 AM, Dag Heyman<EMAIL_ADDRESS>wrote:

Thanks for the report, this do sound similar to this issue: #161
https://github.com/Yubico/yubioath-desktop/issues/161 A fix for it will
be included in the next release. To verify that it is the same, could you
try this development build?
https://yubico-builds.s3-eu-west-1.amazonaws.com/yubioath-
desktop/yubioath-desktop-master--HEAD-win.zip
Just unzip the archive and run the app from the folder, no installer
needed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Yubico/yubioath-desktop/issues/173#issuecomment-322969063,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFAJsZk21Qc5wm916H26wsFha5nWFP2Eks5sY8h4gaJpZM4O5bTc
.

Closing this, feel free to request it to be reopened if issue is still there.


Should we separateNumbers by default?

I don't think this is what most users intend to have as output (e.g. foo123foo => foo-123-foo) - and other packages like slug, speakingurl, etc do not do this by default as far as I know.

Otherwise, excellent work as always @lovell 👍

Hello, number separation makes a little sense in non-Latin scripts where Arabic numerals (0-9) are used, or at least I recall that's the original rational behind this feature.
Happy for a PR to switch the default behaviour if you're able. This would need to be released with a major version bump.

v2.0.0 now available with separateNumbers defaulting to false.


Refactored onload/onresize events to use event vs. Action

Sorry @BDisp  ;-)
THIS MAY BE A BREAKING CHANGE (but I think I own the only 'real' code that uses it: Out-ConsoleGridView).
This PR follows the guidelines in #447 to correct the mistakes made in PR #375 for how onload/onresize events were implemented.
Looking at existing code that uses these events (mine and @BDisp primarily) I see that they care about the new terminal size. I therefore implemented both events using:
		/// <summary>
		/// Event arguments for the <see cref="T:Terminal.Gui.Application.Resized"/> event.
		/// </summary>
		public class ResizedEventArgs : EventArgs {
			/// <summary>
			/// The number of rows in the resized terminal.
			/// </summary>
			public int Rows { get; set; }
			/// <summary>
			/// The number of columns in the resized terminal.
			/// </summary>
			public int Cols { get; set; }
		}

OnLoad is now:
		/// <summary>
		/// This event is fired once when the application is first loaded. The dimensions of the
		/// terminal are provided.
		/// </summary>
		public static event EventHandler<ResizedEventArgs> Loaded;

OnResize is now:
		/// <summary>
		/// Invoked when the terminal was resized.
		/// </summary>
		public static event EventHandler<ResizedEventArgs> Resized;

Apologies for the formatting changes. I have a habit of hitting "Ctrl-K-D" in VS to reformat files to what .editorconfig has set...

@tig feel free. It was surprising much better.

Apologies for the formatting changes. I have a habit of hitting "Ctrl-K-D" in VS to reformat files to what .editorconfig has set...

@tig me too. Later I only uses the "Ctrl-K-F" to not messed up. But I prefer to use that too. In that case the better is use a .editorconfig really.


Closes #1225: Bug in search.

Description
Now instead of appending count of Products, setText is used.
created a Boolean which ensures that recyclerview does not get stacked.
Related issues and discussion
closes #1225

@Karljoones I've tested the app and it is working fine. Also, I've used boolean setupDone variable to ensure recycler view doesn't get stacked so that when we do swipe refresh multiple times and then click on any product, we can come back to search result list by pressing back button single time.

Travis-ci test is getting failed due to and the message is:
The job exceeded the maximum time limit for jobs and has been terminated.
What should I do in this case?

Illustrating product search issue:

PR causing/related:  #1161

Thanks, I will fix this.

@policorn I've tried running the app on emulator Nexus6 API22 and I've found that after typing query and pressing enter from the keyboard of laptop I get the exact same case which you told, but after typing query and pressing search from the keyboard of emulator the app worked fine.
I think that it is just happening on the emulator and if we just use emulator's screen to run the app without using laptop's keyboard then also the app will work fine.
Please provide your thoughts. 😄

@Shubham2320 is there any chance you would be able to test this on a physical device? I know that this is not always the possible

Fixed conflicts, going to merge once build is complete

@Karljoones finally the travis-ci build is passed please merge this one.

Merged, thanks @Shubham2320


Refactor DomainBase into DomainContent and create DomainHistory

This is similar to #587 and #634, but for domains.
One caveat is that we refactor some of the Domain* instance methods to
be static so that they can be called either on DomainBase or
DomainContent, returning the appropriate type each time.
Note that we set DomainHistory to use the same revision ID sequence as
HostHistory and ContactHistory.
In addition, we refactor the tests to the History objects a bit to
reduce duplicate code and because we cannot guarantee yet that the
SQL-stored VKeys are symmetrical -- the ofy keys are not persisted at
the moment.
In addition, rename the DomainHost table to the default Domain_nsHosts so that it automatically creates two separate nsHosts tables for us -- one foreign-keyed on the domain repo ID, and one foreign-keyed on the history revision ID

This change is

Sorry about all the pushes; I had to fix up some tests and there were a decent bit of merge conflicts (especially due to the file moving, since Github doesn't handle that as nicely as Critique does).
PTAL, and thanks. Let me know if you have any questions on where to start; the main addition is the Transient annotation on nsHosts with the getter/setter method added in the subclasses for Hibernate's sake.


just a suggestion :-)

I think that the sentence "It works like other available transpilers" is confusing, as it is not "like" but the exact "opposite" :-)

:+1: Thanks.


virt-controller, services: Remove passt memory overhead

What this PR does
Remove passt memory overhead.
Passt binding required additional memory when no TCP/UDP ports are specified (i.e. all ports are forwarded to guest).
Once we used passt with binding plugins, we noticed that it works even without the overhead memory.
This change removes the overhead memory and checks it for the previous (deprecated) passt configuration.
TODO: Revert the vmi_pass test changes.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/test pull-kubevirt-e2e-k8s-1.29-sig-network

@sbrivio-rh , I am unsure if I can explain what changed that it works now.
Have been there an improvement to the memory consumption of passt when it is set to forward all tcp/udp ports?

I need a bit here as well ;)

Not on top of what we reported at https://bugs.passt.top/show_bug.cgi?id=20#c5 -- that was 487 MiB for TCP plus UDP, IPv4 and IPv6, and I still see that in the last CI run (see memory/passt in https://passt.top/builds/latest/test/test.log or skip to memory/passt of https://passt.top/passt/about/#continuous-integration).
However, do pods actually have IPv4 and IPv6 addressing at the same time? If not, we should be closer to this:

Yes, pods in a dual stack cluster have both IPv4 and IPv6 addressing.

> Memory usage: all TCP and UDP ports forwarded, IPv4
Memory usage summary

                                                                      type: |  MiB |
                                    used                                    |368.9 |
                                  userspace                                 | 38.2 |
                                   kernel                                   |331.6 |
                                                                            '------'
...passed.

...which should be similar for IPv6-only cases. Maybe at this point the overhead is not substantial enough to cause issues?

@sbrivio-rh , could you share how you are checking the memory consumption?
If I can use the same in the pod, it will be nice.

@sbrivio-rh , could you share how you are checking the memory consumption?

Sure, it's implemented in passt's test suite here. Skip at the start_stop_diff definition for a list of the essential commands.

This is not relevant anymore.
/close


Add a flag to disable downloads of uploaded files

Closes #223

I'm also interested in this feature. Use-case: I'm loading files to S3 and serve them with CDN. So I don't want to load my backend with location link usage. Can anyone look on this PR? @tim-kos?

Thank you for this PR! It looks good, but there are two things:

It's better to call the flag DisableTermination instead of DisableDelete because for tus we use the terminology "to terminate an upload".
Your PR removes the routes from the router, but I wonder if one can still access the DELETE/GET handlers by supplying a X-HTTP-Method-Override header: https://github.com/tus/tusd/blob/master/pkg/handler/unrouted_handler.go#L211 Can you test if this would circumvent the disabling of these endpoints?

It's better to call the flag DisableTermination instead of DisableDelete because for tus we use the terminology "to terminate an upload".

Done

Your PR removes the routes from the router, but I wonder if one can still access the DELETE/GET handlers by supplying a X-HTTP-Method-Override header: https://github.com/tus/tusd/blob/master/pkg/handler/unrouted_handler.go#L211 Can you test if this would circumvent the disabling of these endpoints?

❯ curl -X DELETE -H 'X-HTTP-Method-Override: DELETE' -H 'Tus-Resumable: 1.0.0' http://localhost:1080/files/d62477b5406a4d2c7725d0d8d498ec81
Method Not Allowed

❯ curl -X GET -H 'X-HTTP-Method-Override: DELETE' -H 'Tus-Resumable: 1.0.0' http://localhost:1080/files/d62477b5406a4d2c7725d0d8d498ec81
Method Not Allowed

❯ curl -X PATCH -H 'X-HTTP-Method-Override: GET' -H 'Tus-Resumable: 1.0.0' http://localhost:1080/files/d62477b5406a4d2c7725d0d8d498ec81
Method Not Allowed

Seems like you can't bypass it by using the X-HTTP-Method-Override header

Awesome @Acconut, do you think you could do a patch or minor release soon?

This is included in v1.9.0: https://github.com/tus/tusd/releases/tag/v1.9.0


Incorrect link redirecting to google internal pantheon

Hi, @amuramoto !!! I hope you are great!
I found an error in the codelab text: https://codelabs.developers.google.com/codelabs/maps-deck-gl/index.html?index=..%2F..index#2
As you may see in the image below, the link to the cloud console is redirecting incorrectly to pantheon...

Let me know if you need help to fix this issue if you give me access to the source of the codelab!
Cheers!

Thanks for catching this! Apologies for the slow response - didn't see the GH notification for this one.


Add experimentId to logged information

conda list --quiet codecarbon : codecarbon    2.1.4    pyh1a96a4e_0   conda-forge
python --version:  Python 3.9.16
uname -osri : Linux 5.14.0-1057-oem x86_64 GNU/Linux

Description
I want the experimentId I filled in the tracker to be logged.
What I Did
Local configuration .codecarbon.config
[codecarbon]
project_name = XP_analysis
save_to_file = True
output_dir = ./codecarbon
on_csv_write = append
log_level = ERROR

Code configuration .codecarbon.config
from codecarbon import EmissionsTracker
CODE_CARBON_FILE = "XP_classification.csv"
EXPERIMENT_ID = "XP_classification_full_data"
tracker = EmissionsTracker(output_file=CODE_CARBON_FILE, experiment_id=EXPERIMENT_ID)
tracker.start()

# workload here

conso = tracker.stop()
print(f"Consumption : {conso} gCo2")

Expected changes
Expected content of ./codecarbon/XP_classification.csv
timestamp,project_name,     >>experiment_id,<<    run_id,duration,emissions,...
2023-03-15T15:26:43,XP_analysis,    >>XP_classification_full_data,<<    fe8f6d31-bc72-4f22-8d30-7e22477f5e4f,151.68805646896362,0.0040710534969637,...

Likely changes to be done

output.py :

@dataclass
class EmissionsData:
    """
    Output object containg run data
    """

    timestamp: str
    project_name: str
    run_id: str

    experiment_id: str # add here

    . . .

emissions_tracker.py :

 total_emissions = EmissionsData(
       timestamp=datetime.now().strftime("%Y-%m-%dT%H:%M:%S"),
       project_name=self._project_name,
       run_id=str(self.run_id),

       experiment_id=self._experiment_id, # add here

       . . .

Additional suggestion
It would be nice to choose what fields are (or not) displayed in the logged csv.
It would nicer if you could freely add fields declaring the EmissionTracker in code.

Hello,
Thanks for your very well detailed issue.
experiment_id was supposed to be used with the Code Carbon API.
So your use case is to use it without the API to have a key to aggregate your data, right ? Indeed it could be use-full.
Please note that print(f"Consumption : {conso} gCo2") is wrong, the unit is in kg, not g.

Hello,

So your use case is to use it without the API to have a key to aggregate your data, right ? Indeed it could be use-full.

Yes I am working locally with different classification models and data set I'd like to train. I use experiment_id to label each setup. Up until now I have to add the experiment_id to keep track of settings for future analysis. The most generic fix would consist

@halsimov i want to try to make this change but receiving the below error. any guidance.
TypeError: non-default argument 'experiment_id' follows default argument

@halsimov I would like to contribute this enhancement. It my first contribution. Made the changes but the experiement id not flowing to the output. any further guidance would be appreciated.

@halsimov I would like to contribute this enhancement. It my first contribution. Made the changes but the experiement id not flowing to the output. any further guidance would be appreciated.

@essp-lbg You will have to be more specific if you want some help. You can check out the contribution guidelines newcommers guide to learn out to collaborate effectively.
I have posted a draft pull request #463 in which I have applied my Likely changes to be done and some tests. The tests I modified are passing (even though some of the others did not pass to begin with). You can check out my code to compare with yours.

@halsimov thank you. your code changes are very similar to mine. what you suggest? should I create PR mine code or would you like to?

I marked my draft PR as ready so we are waiting for a moderator. Have you achieved to make it works locally ?

Thank you @halsimov best to leave your PR in place. I will look for other issues


UX Improvement: Show SHA for commits (Map + Commit view)

The SHA is currently not trivial to get to. Would help being able to see it. Additionally that popup in Map could benefit from text selection.
Additionally, useful also in the commit view. You can't see the SHA of the commit, only the message.

@dlikhten: I think this is not the repo you meant. This is aanand/git-up, a helper command line helper for fetching and rebasing, not git-up/GitUp (a graphical interface).


Updates to FAM actions utility functions

Complete rewrite of how ActionManager manages resource resolvers
Identify assets with missing or outdated renditions
Activate content to a list of publishers in round-robin manner (parallelizes publishing where available)
Translation function to apply actions against renditions (useful for activating or deleting specific renditions)

Seriously?   Wow.  I thought that isLive() indicates if the session is open and false = closed.  Yeah, please change it for sure if you think it will be ok.


Can't open the project using vscode WSL

Type: Bug
I can login in wsl through powershell, but can't open the project in the wsl and got the information below:

[2024-02-05 02:16:44.178] WSLENV=VSCODE_WSL_EXT_LOCATION/up
[2024-02-05 02:16:44.178] Setting up server environment: Looking for /root/.vscode-server/server-env-setup. Not found.
[2024-02-05 02:16:44.178] WSL version: <IP_ADDRESS>-microsoft-standard-WSL2 Ubuntu-18.04
[2024-02-05 02:16:44.184] + CODE_PROFILE=/root/.vscode-server/server-env-setup
[2024-02-05 02:16:44.184] + printf Setting up server environment: Looking for %s.  /root/.vscode-server/server-env-setup
[2024-02-05 02:16:44.185] + [ -f /root/.vscode-server/server-env-setup ]
[2024-02-05 02:16:44.185] + echo Not found.
[2024-02-05 02:16:44.185] + VSCODE_REMOTE_BIN=/root/.vscode-server/bin
[2024-02-05 02:16:44.185] + uname -r
[2024-02-05 02:16:44.185] + WSL_VERSION=<IP_ADDRESS>-microsoft-standard-WSL2
[2024-02-05 02:16:44.185] + echo WSL version: <IP_ADDRESS>-microsoft-standard-WSL2 Ubuntu-18.04
[2024-02-05 02:16:44.185] + dirname /mnt/c/Users/xjshen/.vscode/extensions/ms-vscode-remote.remote-wsl-0.86.0/scripts/wslServer.sh
[2024-02-05 02:16:44.185] + /mnt/c/Users/xjshen/.vscode/extensions/ms-vscode-remote.remote-wsl-0.86.0/scripts/wslDownload.sh 05047486b6df5eb8d44b2ecd70ea3bdf775fd937 stable /root/.vscode-server/bin
[2024-02-05 02:16:44.487] WSL-shell-PID: 371
[2024-02-05 02:16:44.488] Node executable: /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937/node
[2024-02-05 02:16:44.488] Starting server: /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937/bin/code-server --host=<IP_ADDRESS> --port=0 --connection-token=3800400910-1787338711-2966562569-3028176761 --use-host-proxy --without-browser-env-var --disable-websocket-compression --accept-server-license-terms --log=trace --telemetry-level=all
[2024-02-05 02:16:44.488] + [ ! -d /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937 ]
[2024-02-05 02:16:44.488] + RC=0
[2024-02-05 02:16:44.488] + [ 0 -ne 0 ]
[2024-02-05 02:16:44.488] + echo WSL-shell-PID: 371
[2024-02-05 02:16:44.488] + echo Node executable: /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937/node
[2024-02-05 02:16:44.488] + echo Starting server: /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937/bin/code-server --host=<IP_ADDRESS> --port=0 --connection-token=3800400910-1787338711-2966562569-3028176761 --use-host-proxy --without-browser-env-var --disable-websocket-compression --accept-server-license-terms --log=trace --telemetry-level=all
[2024-02-05 02:16:44.488] + [ -f /etc/alpine-release ]
[2024-02-05 02:16:44.488] + uname -m
[2024-02-05 02:16:44.488] + [ x86_64 = aarch64 ]
[2024-02-05 02:16:44.488] + /root/.vscode-server/bin/05047486b6df5eb8d44b2ecd70ea3bdf775fd937/bin/code-server --host=<IP_ADDRESS> --port=0 --connection-token=3800400910-1787338711-2966562569-3028176761 --use-host-proxy --without-browser-env-var --disable-websocket-compression --accept-server-license-terms --log=trace --telemetry-level=all
[2024-02-05 02:16:44.567] Warning: Missing GLIBC >= 2.28! from /lib/x86_64-linux-gnu/libc-2.27.so
[2024-02-05 02:16:44.567] Error: Missing required dependencies. Please refer to our FAQ https://aka.ms/vscode-remote/faq/old-linux for additional information.
[2024-02-05 02:16:44.568] For help with startup problems, go to https://code.visualstudio.com/docs/remote/troubleshooting#_wsl-tips
[2024-02-05 02:16:44.569] NodeExecServer run: C:\WINDOWS\System32\wsl.exe -d Ubuntu-18.04 -e kill 371
[2024-02-05 02:16:59.585] Download in background is enabled
VS Code version: Code 1.86.0 (05047486b6df5eb8d44b2ecd70ea3bdf775fd937, 2024-01-31T10:28:19.990Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Connection to 'WSL: Ubuntu-18.04' could not be established  Visual Studio Code can only run on Linux distributions based on glibc 2.28 or later. Click on 'Learn More' for more information.

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz (12 x 3192)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
63.93GB (41.55GB free)

Process Argv
--crash-reporter-id 365c159f-43c7-4e68-9f59-93d4e21e6eb1

Screen Reader
no

VM
33%

Connection to 'WSL: Ubuntu-18.04' could not be established  Visual Studio Code can only run on Linux distributions based on glibc 2.28 or later. Click on 'Learn More' for more information.
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30899288
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
2e4cg342:30602488
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
0bi6i642:30917235
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixt:30902429
pythonregdiag2cf:30926736
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementsc:30887149
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
cp7184t:30925682

ubuntu 18.04 support is dropped because of glibc verion requirement upgrade (GLIBC >= 2.28) since 1.86.
follow #204269

ubuntu 18.04 support is dropped because of glibc verion requirement upgrade (GLIBC >= 2.28) since 1.86.
follow #204269 for workaround or use later os.

I ran the script by following the workaround you provided but still doesn't work, let me share some background here:
I installed devcontainer and the tragic thing happened, the project couldn't be opened anymore, I found some workaround and deleted the devcontainer user in OS, which made the WSL able to log in, but it doesn't work for vscode.

I suggest you follow https://github.com/microsoft/vscode/issues/204135.
For a temporary workaround you could disable automatic updates, then manually install 1.85.2.
/duplicate

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Update gpt2 to use wte if no lm_head

Closes #338
Based off of https://github.com/rustformers/llm/pull/343
Fixes the segfault issue mentioned in that bug, and adds a check that could help catch those errors faster.

Looks good! Can you add the comments from the original PR about why the tensor's optional and why we substitute with wte?

👍 done, thanks!

Brilliant, thanks 🚀


Enum improvements

Started to look at implementing #1003 and struggled understanding enums.
This patch addresses the following issues:

Make ambiant & const enums report similar errors (allow any constant number expression). fixes #2790
If an invalid enum constant expression is found, continue incrementing with the last valid initialized value.
If an enum expression references another enum member, then emit a reference to the other value.

Note that I'm still confused about what 'constant' means for an enum #538
Thinking that enum should allow for NumericLiteral, it's an enum<number>.
You could have a more restricted/subset enum:
enum<int32> a {
  a, // 0
  b, = 1.1 // error, initializer must be a constant expression of type 'int32'
  c, = -1, // ok
  d, // 1
}

Or if you don't want signed:
enum<uint32> b {
  a, // 0
  b, = 1.1 // error, initializer must be a constant expression of type 'uint32'
  c, = -1, // error, initializer must be a constant expression of type 'uint32'
  d, // 1
}

Hi @jbondc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Hi @jbondc, thanks for the PR. While I'm not sure if @vladima was working on it at the time, in the future please be mindful of the assignee of an issue if there is one, and ask if it would be okay to pick the issue up.
I have a few questions about your work though:

If an invalid enum constant expression is found, continue incrementing with the last valid initialized value.

Is there any reason for this behavior change? I don't see the previous behavior as an actual issue, and I'd rather not introduce new behavior for the sake of what one might feel is slightly more correct. Both are just as broken.

If an enum expression references another enum member, then emit a reference to the other value.

Sorry, from what I understand this is the current behavior, could you please elaborate?

You could have a more restricted/subset enum

For something like this, please put up a formal proposal.

If an enum expression references another enum member, then emit a reference to the other value.

I see what you mean now - can you write a test case like the following?
tests/cases/conformance/enumsMembersWithInitializersThatReferenceLaterMembers01.ts
enum E1 {
	a = c,
	b = 2,
	c = 3,
}

declare enum E2 {
	a = c,
	b = 2,
	c = 3,
}

const enum E3 {
	a = c,
	b = 2,
	c = 3,
}

declare const enum E4 {
	a = c,
	b = 2,
	c = 3,
}

enum E5 {
	a = c,
	b,
	c,
}

declare enum E6 {
	a = c,
	b,
	c,
}

const enum E7 {
	a = c,
	b,
	c,
}

declare const enum E8 {
	a = c,
	b,
	c,
}

Is there any reason for this behavior change? I don't see the previous behavior as an actual issue, and I'd rather not introduce new behavior for the sake of what one might feel is slightly more correct. Both are just as broken.

Pretty much. It felt slightly more correct because no errors are generated on the nodes that are undefined:

My expectation would have been to see red lines on d,e,f
By continuing to increment/assign values, it works with less errors.

Good catch, I'm thinking:
var E5;
(function (E5) {
    E5[E5["b"] = 0] = "b";
    E5[E5["c"] = 1] = "c";
    E5["a"] = E5.c;
})(E5 || (E5 = {}));

Would be the emit if a member references another member before it's emitted, does that seem right?

For something like this, it would warrant formal proposal beforehand.

Proposal #3105 though will likely make refinements in the upcoming weeks.

@jbondc "Why no errors after...".
Because inundating users with errors that all stem from an initial bad issue is not good compiler behavior.  We try to avoid this sort of cascading when we can.

While I'm not sure if @vladima was working on it at the time, in the future please be mindful of the assignee of an issue if there is one, and ask if it would be okay to pick the issue up.

Noted, wasn't my intent to work on enums, stumbled on it as it overlaps with number literal types, at least how I'd plan to implement it.

@DanielRosenwasser To follow up on the reverse mapping issue, here's a recent issue/use case within the compiler:
    export const enum SymbolConstraints {
        notWritable = 1,
        notMutable,
        Immutable = notWritable | notMutable,
        //ConstantBinding = notWritable,
    }

When debugging, I would normally see:
  *** infered type
  Type id=4122 ValueSetMember=67108864 NumberSet=2097152 Number=4
    Symbol name=valuesNumber id=15743 ConstEnum=128 -- constraints:  notMutable=2 notWritable=1

But if you uncomment 'ConstantBinding', I now get:
  *** infered type
  Type id=4122 ValueSetMember=67108864 NumberSet=2097152 Number=4
    Symbol name=valuesNumber id=15743 ConstEnum=128 -- constraints:  notMutable=2 ConstantBinding=1

That's clearly not my intent and quite annoying behavior.

Or just this one:
  Node kind=7 (FirstLiteralToken) pos=1296

What I really expect is
  Node kind=7 (NumericLiteral) pos=1296


Comment button positioning / styling issues

Follow-up to #8921. The comment annotations are leaving a lot to be desired across the UI.

Problematic issues:

[x] In field rows, the comment button is overlapping with fields. It needs tighter spacing to fit in column gaps.
[x] In rich text fields, the comment text annotation color isn’t the one intended in the designs (current has way too low contrast)

Spacing / cosmetic issues:

[ ] The fields should no longer become shorter in commenting mode. Instead, comment buttons can be positioned off to the side of the form.
[ ] For all single-line 42px fields, the comment button should be horizontally centred
[ ] For larger fields, the comment button can be at the same top offset as for single-line fields
[ ] In field rows, the comment button is too close to fields.
[ ] Bold text in rich text comment highlights moves the field’s content around.

Nice to have:

[ ] For chooser widgets, have the comment button center-aligned with the other chooser buttons
[ ] For the title field, have the comment button center-aligned with the field

bumping to 4.1 to cover the points that weren't handled in the final 4.0-merged version of #9072

I have updated the issue description based on changes done in Wagtail 4.0 – the two problematic issues have been fixed. We still have cosmetic / alignment issues to go through, which are now in #9111.


Add Blog on Refresh Tokens

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

[x] You created a branch from dev branch.
[x] You PR is raised on dev branch and not onmaster.
[x] Blog follows Blog Guidelines.
[x] You have read the Contribution Guidlines before creating this PR.
[x] Checked for any duplicate blog entry.
[x] Checked for all grammatical errors in the blog.
[x] You have not published the blog content anywhere else on the internet on platforms like medium, dev.to etc.
[x] The content is not copy-pasted from anywhere else on the Internet.

Author Details for Blog Post Entry
id:  Mcvean Soans
bio: Mcvean Soans is a Full Stack React Developer enthusiastic about Web Dev, Deep Learning, UX design and Cloud domains!
github: McTechie
linkedin: mctechiesoans
twitter: McTechieSoans

@raghunath-r-a it would be great if you could review the blog and suggest changes (if any xD)

Hi @McTechie
We have done the first phase of review, made some simple content changes, and updated the header image. We're now moving this to the second (final) phase of review. We'll get back to you if we need any changes from you.
Keep contributing!
@raghunath-r-a

Hi @McTechie We have done all the reviews and no changes are required. We'll merge this PR and publish this blog soon.
Please do fill this form to get branded swag from LoginRadius.


IndexError: list index out of range

Using Python 2.7.11 on Windows 10 I get the following error after entering my username and password:
Traceback (most recent call last):
File "D:\robinhood-to-csv\csv-export.py", line 32, in
for key, value in enumerate(executions[0]):
IndexError: list index out of range

Thanks for the heads up.  I think this should be fixed now.  Mind trying it again to confirm?
I didn't have any queued orders when I wrote the script so I missed the fact that queued orders are returned in a different structure from executed orders.

No problem.
I gave it another try and was able to get past the first error but I am now getting another new error which I've added as Issue #2.

Hmm.  Mind pulling the latest version and running it with the debug flag?  Then email me the debug.json file that is generated.
python csv-export.py --debug

Here you are!
I had to rename the file to .txt for Github to accept it.
Just a couple of thoughts, I have several Canceled orders in my order history as well as undeclared deposits; not sure if those could be causing the issue.
debug.json.txt


FileNotFoundError: The system cannot find the path specified: '/path/to/imagenet/train'

Where can I obtain the training and testing data? Thanks!

You can find the ImageNet dataset here - https://www.image-net.org/download.php.


fix(core): Fix log that panics if !ok

Self explanatory. :(

Codecov Report

Merging #1927 (4806089) into main (be77cac) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1927      +/-   ##
==========================================
+ Coverage   57.67%   57.74%   +0.06%
==========================================
  Files         245      245
  Lines       16164    16167       +3
==========================================
+ Hits         9323     9335      +12
+ Misses       5892     5885       -7
+ Partials      949      947       -2

Impacted Files
Coverage Δ

core/listener.go
52.77% <100.00%> (+4.89%)
:arrow_up:

libs/header/p2p/session.go
92.34% <100.00%> (+0.08%)
:arrow_up:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


euclidean distance algorithm server

created RecommenderServlet:

implemented overall class structure
implement fetching recommendation rating
implement distancePair class to represent a pair of recommendation ID and the euclidean distance to the user preference
implement function to calculate distance between rating
sort the top recommendation based on the distance
TODO:
fetch top 5 recommendation based on the calculated distance to send to the client
implement client side

NOTE: The majority of commits were incorrectly added (they belonged to other, irrelevant branches) but we can't work out how to remove them - any ideas? The only commits needed to be reviewed are @raniarusly commits and then the "Remove duplicate code".

Rebasing problem


List parameters are not encoded properly in Get request and Multipart/Form request even with ListFormat.multi (4.0.0-prev1)

In a Get and Multipart/Form request if any of the Parameter is a List and ListFormat is multi, previously in older versions the params were encoded properly ([]) was added in the params automatically. However with latest version, it doesn't get added. The culprit  is the following line
https://github.com/flutterchina/dio/blob/7abcfd1a758c45e81a11e7d63bb250ce8fe3fc25/dio/lib/src/utils.dart#L61
The check isCollection is false if a param is z: ['string 1', 'string 2']. The list is already checked in line
https://github.com/flutterchina/dio/blob/7abcfd1a758c45e81a11e7d63bb250ce8fe3fc25/dio/lib/src/utils.dart#L58
Is the check in L61 necessary?
If it is, should we explicitly add [] to the parameter name in Get and Multipart/Form request?
Thank you for your help.

try ListFormat.multiCompatible

@wendux I tried both, its that line (L61) for both list types, that initiates the problem. No matter which format I use

L58 check sub , but L61  check sub[i], they are different.
You'd better to give a case, and describe what you expected is，for example:

  var data = {
    'a': '你好',
    'b': [5, '6'],
    'c': {
      'd': 8,
      'e': {
        'a': 5,
        'b': [66, 8]
      }
    }
  };
  test('#url encode multi', () {

   // a=你好&b[]=5&b[]=6&c[d]=8&c[e][a]=5&c[e][b][]=66&c[e][b][]=8
    var result =
        'a=%E4%BD%A0%E5%A5%BD&b%5B%5D=5&b%5B%5D=6&c%5Bd%5D=8&c%5Be%5D%5Ba%5D=5&c%5Be%5D%5Bb%5D%5B%5D=66&c%5Be%5D%5Bb%5D%5B%5D=8';
    expect(Transformer.urlEncodeMap(data, ListFormat.multiCompatible), result);
  });

Here is what I expect
 var data = {
    'a': 'string',
    'b': 'another_string',
    'z': ['string'],
  };
  test('#url encode multi', () {

   // a=string&b='another_string'&z[]=string
    var result =
        'a=string&b='another_string'&z%5B%5D=string';
    expect(Transformer.urlEncodeMap(data, ListFormat.multi), result);
  });

//Actual result I get: 'a=string&b='another_string'&z=string'

我也遇到这个问题，之前3.0没有问题

@lohanidamodar

Here is what I expect
 var data = {
    'a': 'string',
    'b': 'another_string',
    'z': ['string'],
  };
  test('#url encode multi', () {

   // a=string&b=another_string&z[]=string
    var result =
        'a=string&b=another_string&z%5B%5D=string';
    expect(Transformer.urlEncodeMap(data, ListFormat.multi), result);
  });

//Actual result I get: 'a=string&b=another_string&z=string'

use ListFormat.multiCompatible, passing!

@wendux No matter what format I provide the encodeMap always receives the ListFormat.multi, and I believe the culprit here is this Compose function https://github.com/flutterchina/dio/blob/7534c1c9aa4577914a176e055a915b9b1220027a/dio/lib/src/options.dart#L274
If i however pass the listFormat to RequestOptions at line https://github.com/flutterchina/dio/blob/7abcfd1a758c45e81a11e7d63bb250ce8fe3fc25/dio/lib/src/options.dart#L270
it works!!

@wendux No matter what format I provide the encodeMap always receives the ListFormat.multi, and I believe the culprit here is this Compose function
https://github.com/flutterchina/dio/blob/7534c1c9aa4577914a176e055a915b9b1220027a/dio/lib/src/options.dart#L274
If i however pass the listFormat to RequestOptions at line
https://github.com/flutterchina/dio/blob/7abcfd1a758c45e81a11e7d63bb250ce8fe3fc25/dio/lib/src/options.dart#L270
it works!!

fix in 4.0.0-prev3

Resolved!! ❤ 👍🏻


Bump slimmer for new rendering app meta tag

So we can track which application renders which page in analytics update slimmer for a new version which outputs the rendering application.
This contains both https://github.com/alphagov/slimmer/pull/126 and https://github.com/alphagov/slimmer/pull/128

:+1:

:+1: post commit


Fix codecov not displaying on GitHub

As the image was being loaded via HTTP, GitHub seems to refuse the proxying.

Cannot proxy the given URL

These tests are really flaky, at least in the Azure Pipelines... 🫤


Case overall status type adding scrutiny, registration substage

moved to this PR- https://github.com/pucardotorg/kerala-mdms-data/pull/94


Type::Hash.map and to_h behaviour is unexpected

I was intending to use Dry::Types::Hash but I've found what I consider to be weird behaviour with #to_h
I was expecting that Struct.new(hash).to_h to equal hash
Below is a basic test that illustrates the issue.
require 'spec_helper'
require 'dry-struct'
require 'dry-types'

module Types
  include Dry::Types.module
end

class House < Dry::Struct::Value
  input input.strict

  class Dimensions < Dry::Struct::Value
    attribute :x, Types::Strict::Integer
    attribute :y, Types::Strict::Integer
  end

  attribute :rooms, Types::Strict::Hash.map(Types::Strict::String, Dimensions)
end

RSpec.describe House do
  let(:house_hash) { { 'rooms': {'bedroom' => { x: 300, y: 500}, 'kitchen' => { x: 400, y: 500} } } }

  subject(:struct) { House.new(house_hash) }

  it 'creates the struct from a hash' do
    expect{struct}.not_to raise_error()
  end

  it 'can convert the struct back to a hash' do
    expect(struct.to_h).to eq(house_hash)

    # Fails
    # expected: {:rooms=>{"bedroom"=>{:x=>300, :y=>500}, "kitchen"=>{:x=>400, :y=>500}}}
    #      got: {:rooms=>{"bedroom"=>#<House::Dimensions x=300 y=500>, "kitchen"=>#<House::Dimensions x=400 y=500>}}
  end
end

The fix was merged in master


[FEAT]: Create Issue forms and make the issue options more visually appealing

Describe the Feature you want to end

Currently, the issue template for this repo seems to be basic also it is less visually appealing.👇

Changes I will make

Expected behavior

Screenshots (optional)

Additional context (optional )
Will add issue forms to the respective issues to make it easier for the contributor to raise it.
Here is an example of how a Bug Issue Form will look like 👇

Kindly assign me this issue under GSSOC'24

Do it and be happy!.

I am Agamjot singh. Under GSSOC'24, I would like to work on this issue. Pls assign me this!!

fine go for it!

hey @Satyam1923 I have created the PR kindly review it.

done with merging


Import instant apps filter

Configures app to use Freeport McMoran's feature layer.
Portal: https://gisoneviewent.fmi.com/portal/
Layer: https://gisoneviewent.fmi.com/portal/home/item.html?id=5c4151007ebc464dbcb8a599bdb9b4dc

wrong repo


Replace errorprone with another static analysis tool

In version 3.0.0, errorprone removed support for Android. ☹ As a result, the plugin we used to use now does nothing, and errors are just ignored. This is a problem, because simple mistakes could slip through without static analysis.
So we should find and implement reasonable replacement for errorprone.

This is unfortunate. Although I think I understand why they did it, Android's compilation plugin has changed a lot recently so it's difficult to keep up with all the API breaking changes.
If it helps, I see that they still mention here that their tool could still work on android projects, is just that we'd have to manually plug it into the android compilation process on our side. So, I could take a look at that option in case there's no other alternative.

It seems like this enables it back, I haven't checked if test sources are still disabled from running these checks, which I think is the expected behaviour: https://github.com/open-telemetry/opentelemetry-android/pull/46

This is looking good, nice job finding a way to get it working again! 🤘🏻
I opened #48 to help with the existing violations. If we merge that first, I think #46 will be good.


bug: envd does not follow docker context

Description
envd would use the default context even if the default context of docker was changed.
Reproduction
# default context is `lima`
$ docker context list
NAME                TYPE                DESCRIPTION                               DOCKER ENDPOINT                                         KUBERNETES ENDPOINT                 ORCHESTRATOR
default             moby                Current DOCKER_HOST based configuration   unix:///var/run/docker.sock                             https://<IP_ADDRESS>:49413 (default)   swarm
desktop-linux       moby                                                          unix:///Users/rudeigerc/.docker/run/docker.sock
lima *              moby                                                          unix:///Users/rudeigerc/.lima/docker/sock/docker.sock

# docker works well with `lima`
$ docker images
REPOSITORY         TAG       IMAGE ID       CREATED         SIZE
envd-quick-start   dev<PHONE_NUMBER>ac   5 minutes ago   757MB
moby/buildkit      v0.10.3   a2c9241854f2   5 weeks ago     142MB

# envd uses `default`
$ envd get envs
error: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Additional Info
envd: v0.1.0-alpha.12+8531491
  BuildDate: 2022-06-17T01:20:35Z
  GitCommit: 853149189d88e6ecf6a5a924e3aa19d8f7993f7e
  GitTreeState: clean
  GoVersion: go1.18.3
  Compiler: gc
  Platform: darwin/amd64

Thanks for the issue! I will have a look ASAP.

We use docker client golang package to communicate with the Docker daemon. I am not sure if the package supports context.

The context info is stored in ~/.docker/config.json:
{
	"auths": {...
	},
	"currentContext": "docker-test"
}

We cannot get it without reading the file.


Sort users alphabetically

When adding a team to a competition, please show the list of users alphabetically sorted, because this would save a lot of time. Additionally: if possible, use text completion to select a user.

In the new editor, this feature is implemented. Thank you for the suggestion.


ORA1471 Check that worker balance and reputer stake increases during stress testing

This is not a strict test because some of the newly created accounts haven't had a chance to acquire rewards in some cases, either due to no contributing enough or not having a chance to be present during a round where there was not a nonce error

Good idea, I added a simple version of this.


Don't delete "delegation list" article!

What reason is delete this article? This is very important article.
https://github.com/MicrosoftDocs/powerapps-docs/blob/live/powerapps-docs/maker/canvas-apps/delegation-list.md

I can see this article moved to overview.
More details moved to each connector's docs
CDS for Apps
SharePoint
SQL Server
thanks.


Update font size for hero

Bug/issue #, if applicable: rdar://123779770
Summary
Change eyebrow font to body-reduced and add a new font intro for availability info.
Testing
Test Manually
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ ] Added tests - NA
[x] Ran npm test, and it succeeded
[ ] Updated documentation if necessary - NA

@swift-ci test

@swift-ci test

@swift-ci test


OLS-58: Limit conversation history

Description
Limit conversation history
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-58

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

So the messages are truncated per message and not in the actual message (like only half of the message is returned), right?
In theory, a single msg (that is long enough) from the user can truncate history to zero msgs? Do we have a limit on the user prompt?

So the messages are truncated per message and not in the actual message (like only half of the message is returned), right? In theory, a single msg (that is long enough) from the user can truncate history to zero msgs? Do we have a limit on the user prompt?

yes, truncation per message. To not to truncate in middle of sentence or so. User prompt limit is checked in existing code (above this one IIRC).

I see DEFAULT_RESPONSE_TOKEN_LIMIT, but nothing for prompts. Just thinking if we need to set it too.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.35%. Comparing base (18f79ab) to head (4622590).
Report is 22 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   96.82%   96.35%   -0.47%
==========================================
  Files          49       49
  Lines        1511     1537      +26
==========================================
+ Hits         1463     1481      +18
- Misses         48       56       +8

Files
Coverage Δ

ols/src/query_helpers/docs_summarizer.py
100.00% <100.00%> (ø)

ols/utils/token_handler.py
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


.github/workflows: Use centralized SLACK_CHANNELS variable

Description of proposed changes
Using the centralized variable makes it easier for us to update the slack channel value when needed.
As a part of this change, I've already added the SLACK_CHANNELS variable to the repo. I opted to use the channel ID instead of the channel name so that we have the option to rename the slack channel if desired.
Related issue(s)
Related to https://github.com/nextstrain/mpox/pull/220
Checklist

[ ] Checks pass

I didn't realize GitHub added support for non-secret variables - that's neat!

Yup! Unlike secrets, the vars context is directly available for jobs.<job_id>.with.<with_id> so we can use it directly here.


Tempfile created for a inline-style tag contains HTML

Tempfile created for a inline-style tag contains HTML.
Took a while to confirm this because the tempfile is automatically removed after it been processed.
	<style>
		body { background-color: black; color: white; }
	</style>

This sounds like https://github.com/SublimeLinter/SublimeLinter3/issues/356 is the cause. Sorry that this is currently happening.

Update in #356. consolidating this to that issue.


DynamoDB Lock Support

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

https://github.com/apache/arrow-rs/pull/4239 added copy_if_not_exists support for S3-compatible stores that support it, i.e. everything other than S3 :sweat_smile:.
Having native support for this, and potentially other conditional operations in the future (#4879), would reduce user friction and I think unlock a number of exciting use-cases by making support consistent across the backends.
Describe the solution you'd like

I would like to be able to configure a DynamoDB to use in a manner compatible with the AWS DynamoDB Lock Client.
Describe alternatives you've considered

These is a Rust port of the AWS lock client, but it depends on rusoto, and doesn't appear to have very strong fencing guarantees.
Additional context

FYI @wjones127

FWIW, the DynamoDB lock protocol hasn't become the preferred protocol for Delta Lake or Lance, mostly because of the dangers of lease-based locks. Spark Delta Lake went with a slightly different protocol, described in this doc. In Lance we did something similar. delta-rs still uses dynamodb-lock, but will eventually move to match the protocol used by Spark Delta Lake.
That being said, offering something decent out-of-the-box for S3 might be nice.

Hmm... Yeah, I spent some time bashing at this, and it isn't easy to provide strong guarantees with this approach :sweat_smile:
As iceberg also is doing something similar using DynamoDB to store the latest metadata file, I think lets not do this for now.


CompletionItem#additionalTextEdits are ignored

Sometimes completion item may not end up resolved when applied and additionalTextEdits are therefore ignored.
If use selects a completion item in the list with arrow keys items are resolved and additional edits are applied. However, if user clicks an item in the completion items list with mouse without selecting an item (probably this is the bug - that the item doesn't seem to get selected) i.e. a highlighted item in the list of completions the item isn't resolved and additonal edits never show show up.
Also, curious if restriction editing the completion line can be lifted. Or perhaps additional edits can be applied once the main edit is applied, i.e. edits are applied sequentially: 1. main edit, 2. additional edits. Currently it looks like these edits are applied in parallel.

I was not able to reproduce this. Do you have any detailed steps on how to do this?
Please note that a resolve call is only sent once. So if you scroll over items and the later on click on one it will not receive a second resolve call.

@dbaeumer I think it is my bad. Additional edits are applied it seems with a limitation that they must be applied to a line different from where the main edit occurs. As soon as i have same line edit in the list of additional edits all edits are ignored. Consequently, everything looks as designed at this point.
Do you know if this limitation of additional edits being not on the same line with the main edit can be lifted? I saw something about this topic here: https://github.com/microsoft/vscode/issues/96779#issuecomment-627954429

I think the same line limitation will not be lifted. Can't you replace more text on the same line?

It is the suffix for a property key that needs to be added based on the property value type. Depending on whether type is a map, list, enum/atomic. There are two options either add the suffix via completion item resolve or fetch java types to determine map, list, enum/atomic or whatever during the properties metamodel generation step (properties indexing). Type fetching during indexing would increase the time it takes to index the properties.
Adding the suffix works fine with the command though... it appears a bit later which is okay... the only annoying part is to undo the change one would hav to invoke undo twice: first - for the suffix, second - for the main edit


How to remove chrome warning for new SameSite cookie policy

I am getting a warning in the browser console when using the new Chrome (v80) regarding their new cookie security policy (https://blog.chromium.org/2020/02/samesite-cookie-changes-in-february.html). It seems like Segment cookies should be configured with SameSite=None;Secure in order to continue working.
If this is something we can fix ourselves, could a section be added in the Segment documentation showing us how?
If not, will this be fixed in a future version of Segment?
Thank you

This is now fixed. Just a note that there might be few cookie warning related to third party destinations, that is out of our control.

so this is fixed... how? Will consumers have to update theiranalytics snippet , or is there a new version of the analytics.js being percolated across CDN?

I'm still seeing the warning.
A cookie associated with a cross-site resource at http://segment.com/ was set without the `SameSite` attribute. A future release of Chrome will only deliver cookies with cross-site requests if they are set with `SameSite=None` and `Secure`. You can review cookies in developer tools under Application>Storage>Cookies and see more details at https://www.chromestatus.com/feature/5088147346030592 and https://www.chromestatus.com/feature/5633521622188032.

Is there a specific release this is fixed in, or am I maybe missing something?
Thanks

@kretz This is fixed here: https://github.com/segmentio/analytics.js-core/pull/128. If using the CDN version of analytics.js you should be getting the fix without upgrading. If using npm, upgrade to the latest analytics.js-core. Also sometime you have Segment related cookies set prior to the fix, so also try clearing the cookies to see if it fixes the warning.


backport: bitcoin#19668, #21598, #19979 - lock annotations

What was done?
These 3 backports improve noticeable implementation of thread-safety analysis by moving many possible warnings to compilation level.
There's a lot of fixes for annotations after that!
How Has This Been Tested?
Build with clang:
CC=clang CXX=clang++ ./configure --prefix=$(pwd)/depends/x86_64-pc-linux-gnu --enable-suppress-external-warnings   --enable-debug  --enable-stacktraces --enable-werror --enable-crash-hooks --enable-maintainer-mode

Breaking Changes
n/a
Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta any ideas how to make SharedMutex works again?
See 9c612292d9da768adfa245b63b80007265e24b52

PastaPastaPasta any ideas how to make SharedMutex works again?
See https://github.com/dashpay/dash/commit/9c612292d9da768adfa245b63b80007265e24b52

nevermind, fix a trivial, it is related to new code, not old code.


The code about the port of Protocol config is not consiste with the description of the Document

[ ] I have searched the issues of this repository and believe that this is not a duplicate.
[ ] I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

Dubbo version: latest

Step to reproduce this issue

Config the protocol, but do not config the port parameter
Start the application integrating dubbo.

According the document, if user does not config the port of protocol, Dubbo will pick an available port that count from the default port dynamically.
But the actual result is that Dubbo just pick the default port. It does not pick an available port dynamically.
So should we modify the code or document ?

can you submit a PR for document in https://github.com/apache/incubator-dubbo-website

@kimmking You means that we should update the document to comply with the code

@kimmking I have submit a PR #64


Avoid block scope issues in transpiled code

Fixes #8500, and makes callback invocation more consistent (i.e. also execute in a new cycle when animations are cancelled.

The fix is in v5.2.0.


ShulkerBullet not implemented in Projectile.

When writing a plugin, I ran into a problem. I need to get the entity that fired the shulker bullet.

I'm not 100% sure that a shulker bullet is a projectile in the classic sense.
But it should fit I think, and it should be doable. If it isn't it should at least be possible to expose some API for what you need.

It's not a projectile in the Minecraft source code, it's just an Entity with a Living owner and an Entity target (with a bonus direction).

I was able to get the required entity via the IndirectEntityDamageSource. But this method is not very convenient, it would be better to get through Projectile.

We could make it a Sponge DamagingProjectile, and the Shulker would be a ProjectileSource.

I think this will require more thoughts.
The ShulkerBullet needs a target otherwise it would be useless (its vertical motion would just decrease), and with the actual Projectiles it is impossible to give a target, just a velocity.
Also EntityShulkerBullet does not use an AI task, but just onUpdate to track the target and decide where to go in order to reach it.
It could be a simple Projectile / DamagingProjectile or a whole new thing. Maybe a projectile variant like TargetingProjectile and a new ProjectileSource#launchProjectile overload to take a target.

I haven't seen that onUpdate recently but it is definitely possible to make the bullet target a Location or follow a specific Direction.


Scroller pane slider bug

There is currently a bug with the slider that when enabling the negative spectrum for the scroll panel, you can't go from +X to -X without going to +Y then to -X. I.e: From 5 you can't go to -5, but you can go from 5 to -4, -6, -7 etc.
This is due to the fact that the slider seems to get confused where it really is. When selecting a positive value when the negative values are enabled, the slider after locking in the positive value, still loads in the negative slider's position every time you try and open the menu - instead of the positive slider right under.
1.19.2
1.5
Fabric

also, when you set the limit to a negative number it gets REALLY messed up, is the best way i can describe it. Just lock the panel if the limit is a negative number.
Also also when the number is really big (idk i just threw in a 9999999) it crashed my client when right clicking the ui so there should probably be a lock for that too-

If I understood you right, then the described bugs inside the UI seems to be something outside of our powers of fixing this. This feature is from Create, so you might want to open this in the Fabricators-of-Create repository (Correct me if I misunderstood you)
Other than that, the desribed crashes or REALLY messed up behaviour seems to be something we didnt had in mind.
Thank you for taking the time with this, I will try to fix this quickly!

Yeah the negative number issue seems more of a create issue! I wasn't sure if the mod can interface with how negative numbers work.

Oh the bug with switching the direction (aka minus spectrum) seems to be a bug on our side, sorry!

Alright, that setLimit crash got fixed now. That thing with not applying when switching minus and non-minus spectrum however not. I will keep this in mind however (and keep this one open because of this)


Change Scheme.Build.targets spec

I've just learned that the order of targets in a Scheme's build settings has no affect, and in fact when you reorder them, nothing gets changed in the project.
Within this in mind, this tweaks the Scheme.build.targets to be a bit simpler and mirrors the changes in #54. The change can be seen in the documentation diffs.
As a dictionary wouldn't be in a stable order for diffs, the targets are sorted by name.
Technically this is a breaking change, which is the reason I didn't document Schemes until now, so the format could be locked down.
Any thoughts?

@vhbit

Another benefit of this is it's impossible to duplicate targets that will be build. It also play's nice with the include feature, as you can override a single target's settings easily


Add "Dispers" client support

Sorry, I forgot to reply here. I have been in talks with other people and dispers has been sold to another company, which doesn't plan on providing it as a service. So there'd be no point in a public dispers client.
Sorry for the hassle!


feat: fix the age filter logic

Description
If the min age not set, min age will = max age but only in query but not in UI
If the max age not set, max age will = min age but only in query but not in UI
Query is fixed to use suitableFor param
Design updated:

Optional header added to Range component
Placeholders are optional as well (they are not needed anymore in hobbies filters
Hobbies filters translations fixed

Issues
Closes
DEV-XXX:
Related
Testing
Automated tests
Manual testing
Screenshots
Additional notes

Codecov Report

Merging #152 (1cda0be) into main (03decf2) will increase coverage by 8.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   58.40%   67.06%   +8.66%
==========================================
  Files         372      101     -271
  Lines        8677     2484    -6193
  Branches     1962      566    -1396
==========================================
- Hits         5068     1666    -3402
+ Misses       3384      747    -2637
+ Partials      225       71     -154

Impacted Files
Coverage Δ

...s-helsinki/src/domain/search/eventSearch/utils.tsx
90.22% <100.00%> (+0.14%)
:arrow_up:

...ps/sports-helsinki/src/assets/icons/IconMuseum.tsx

...events/components/shareLinks/LinkedInShareLink.tsx

apps/events-helsinki/src/assets/icons/IconCamp.tsx

...-helsinki/src/domain/graphql/createApolloServer.ts

apps/sports-helsinki/src/assets/icons/IconGym.tsx

...raphql/venue/instructions/VenueTprekIntegration.ts

...nki/src/domain/venue/venueContent/VenueContent.tsx

...rc/domain/search/combinedSearch/CombinedSearch.tsx

...i/src/common-events/utils/headless-cms/service.tsx

... and 262 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr152.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr152.dev.hel.ninja :rocket::rocket::rocket:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr152.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://harrastukset-pr152.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://tapahtumat-pr152.dev.hel.ninja :laughing::tada::tada::tada:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr152.dev.hel.ninja :rocket::rocket::rocket:

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr152.dev.hel.ninja :rocket::rocket::rocket:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr152.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://tapahtumat-pr152.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://harrastukset-pr152.dev.hel.ninja :laughing::tada::tada::tada:

TestCafe result is success for https://liikunta-pr152.dev.hel.ninja :laughing::tada::tada::tada:


Poetry Update

Sorry to bother you again, but would it be possible to update poetry so this will work with Python 3.11?

No worries :). You're not the first one asking for Python 3.11 support. The reason it's not supported is, that I wanted to support Pyside2.
Unfortunately, Pyside2 is not compatible with P3.11. And on top of that, it seems, that developers are not maintaining Pyside2 package anymore.
I think now it's good time to drop Pyside2 support and allow everyone to use modern Python versions.
I will make some testing and if everything works I will release version supporting 3.11 soon (possibly Tomorrow).

That would be great, thanks!

You should be able to run pglive 0.6.6 against Python3.11 now.

It's installing now, thank you!


Enables automatic textarea expansion on comment fields

As a visitor enters a comment, once the comment exceeds default of 7
lines it will start to expand the textarea vertically.
Closes #JOINDIN-589

Can one of the admins verify this patch?

add to whitelist

Thanks!


Position changes after saving ModelForm without position field

Hello,
After upgrading to 0.5.1, I noticed that when an object is saved via a ModelForm that does not include a position field, that object's position moves to last place. I think this is the responsible change: https://github.com/jpwatts/django-positions/commit/cfdb4847757a9d59caf026c0df95a451f292d67b#diff-d225dfacb4effdf5497b014c35da0d4eR92
I created a minimal project to demonstrate the issue using the models in the "photo" example. It's housed at https://github.com/jnm/django-positions-test, and the ModelForm I use there is:
class SillyForm(django.forms.ModelForm):
    class Meta:
        model = Photo
        fields = ['name',]

Same here. The last object saved gets the last position and all numbers being rebuilt. I didn't have time to look at it. Did anyone of those using django-position managed to solve the issue?

Update, solve in my fork. See the related pull request.


App Suggestion to List: the0neyouseek/MonitorControl

I'd like to recommend https://github.com/the0neyouseek/MonitorControl to be added to your awesome list. I was in need of controlling the audio and brightness for my USB-C monitor from my mac without having to go through the monitor's HW controls all the time. https://github.com/the0neyouseek/MonitorControl did the trick!

duplicated by #616


sails.io.js - websocket issue with AWS application load balancer.

Sails version: 0.12.14
Node version: 6.11.2
NPM version: 3.10.10
DB adapter name: N/A
DB adapter version: N/A
Operating system: Linux

For a couple days I've been trying to get my sails app (using sails & sails.io.js) to work with the ALB at AWS. I've gone through all the documentation and a number of posts but have had zero luck.
On my development machines the app works fine without any issue. However, when we put into production we get some strange things happening.
At first, the socket is connected to sails and I'm able to login and use my application fine. But after a few moments I notice that the Socket shows it was disconnected. Then says Socket is trying to reconnect to Sails, it gets connected after ~5 seconds and then it keeps getting disconnected.
Then it displays an error:
VM45:164 WebSocket connection to 'wss://companya.bidgemmer.com/socket.io/?__sails_io_sdk_version=0.14.0&__sails_io_sdk_platform=node&__sails_io_sdk_language=javascript&EIO=3&transport=websocket' failed: Error during WebSocket handshake: Unexpected response code: 502
I have followed the documentation and enabled only websocket in config/sockets.js
transports: ["websocket"]
Then inside views/layout.ejs I have added the following:
<script src="/assets/js/dependencies/sails.io.js" transports="websocket"></script>
I have enabled the sticky sessions (1 day) for the targetgroup which is associated with the application load balancer at AWS. And a deregistration delay of 300 seconds. Additionally, have create rule on the ALB to route the path pattern /socket.io to the targetgroup associated with the app.
Something I did notice is the sailsIOClient we use in the frontend goes to sails.io.js from the node_modules directory, not the /assets/js/dependencies/sails.io.js - but can't see how this would cause the connection issues.
We also created a sailsIOClient and set the transport ("websocket") directly to the io variable and we get the same result.
I'm pretty much at a loss at this point of what to do. Any assistance would be appreciated.

ok, fixed!

The most important part when using AWS ELB is setting up the Security groups like this

@luislobo - Thanks for the quick reply. Both http & https are open to anywhere on the security group associated with the ALB.

Regarding the listeners, the only difference is that I have a certificate applied for 443 via AWS Certificate Manager (ACM). By the way, I did try removing the cert (thinking maybe it's related to the ssl) but ended up with the same results.

@aaronjhoffman i am also facing the same issue with ALB. Working fine if one instance added to alb. If more than one instance, its throwing continuous 400 error to console.
Sails Version 0.12.4


time to merge is measured in days

Make it clearer that the time is measured in days
Signed-off-by: Dan Kenigsberg<EMAIL_ADDRESS>

Thanks! :)


Bugfix: MIDI input not working with AKAudioUnitInstrument

Hi, I wanted to use the AKSequencer with a AKAudioUnitInstrument, so I checked the sequencer example, but it wasn't working.
I found these 2 problems:

from my understanding, MIDI system command are the ones starting with status byte f0 and above. But the check at MIDIPacket+Extensions.swift:15 would identify all the packets as system command
the MIDI packets coming from an endpoint (set via the midiIn property of the AKMIDIInstrument) didn't reach the AKAudioUnitIntrument

Thanks!

@maksutovic the problem was affecting subclasses of AKPolyphonicNode, so AKMIDICallbackInstrument should also be fixed