fix(route_handler): fix std::accumlation related bug

Description
This is a fix based on clang-tidy warning
folding type 'double' into type 'int' might result in loss of precision	1

The accumulation is conducted as int, not as double, in the previous implementation.
Tests performed
No
Effects on system behavior
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Is this all the true positive warnings from clang-tidy? I'd appreciate if you get rid of all the warning in a single PR. Thanks!

@soblin
Thenk you for your quick review!

Is this all the true positive warnings from clang-tidy?

No. There are tremendous (true psitive) warnings from clang-tidy 🥹
I cannot fix all of them in one PR.
As for std::accumlation related warnings, there is acutualy one more same bug in system module.
Do you think this PR should include system module bugfix?

OK, then can you purge as many errors only in route_handler as possible? If this is all, then I will merge this ASAP

@soblin
Other warnings in route_hander are as follows.
These would not cause immediate bugs. They are rather improvements.
I will leave it up to you whether to accept them or not (and if you accept, I will include these modifications to this PR)

Local variable 'relation' shadows outer variable [shadowVariable]
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L1930

Consider using std::any_of algorithm instead of a raw loop. [useStlAlgorithm]
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L55
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L66
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L487
... 6 more same recommendations in route_handler

Consider using std::find_if algorithm instead of a raw loop. [useStlAlgorithm]
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L1037
https://github.com/autowarefoundation/autoware.universe/blob/c24ad46e156b0ff3564824e23936541f4834770e/planning/route_handler/src/route_handler.cpp#L1114


v1.2.0 when using ic-on-before-trigger - intercooler.min.js:1104 Uncaught ReferenceError: onError is not defined

i changed the line to
var onError = closestAttrValue(elt, 'ic-on-error');
if (onError) {
    ...
}

and it fixed the problem. i didn't get this error in 1.0.3, seems like onError is not in the scope of handleTriggerOn()

Thanks for the report, I have a fix (and a unit test :/) and will release a 1.2.1 soon.

fixed in the 1.2.1 release


Appended a conference in list.

First time contribution to open source project
In this pull request

[x]  I am adding a new resource.
[x]  I am adding a new step
[x]  I am providing an edit
[ ] Removing a resource

Adding new resource

The resource I am adding is _ _ _ _
I am adding this resource to _ _ _ _ step.
I think this resource deserves to be in this list because _ _ _ _

Do not add more than one during hacktoberfest
Add new step

The step I am adding is _ _ _ _
The reason why I think this step should be there is because _ _ _ _

[x] I have added at least one resource to this step

Do not add more than one during hacktoberfest
Providing an Edit

The edit I am providing is to _ _ _ _

Do not add more than one during hacktoberfest
Remove a resource

The resource I am removing is _ _ _ _
I am removing this resource from _ _ _ _ step.
I think this resource should not be in this list because _ _ _ _

Don't ask to remove stuff - unless you believe the content violates the code of conduct

First time open source contribution by following the guidelines !

@all-contributors please add @Yash2737  for doc content

@all-contributors please add @Yash2737 for doc content

@all-contributors please add @Yash2737 for doc content


fix dtype of const args

int ,float 默认的 dtype 都是 64 位。我们最高只支持 32。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.caowengang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Dead Space → no shadows

with d9vk

without d9vk

System information

GPU: Nvidia GT 730M
Driver: 430.34
Wine version: Proton 4.2
DXVK version: #725 (jobs)

Apitrace file(s)
https://mega.nz/#!juADkYpB!D2PaJ4ZWNY0NdOVq3bouO-SG0Af53CzDR5-nY1m0_hI
Log files
steam-17470.log

The shadows in the trace are working correctly for me on the latest master. Can you check if they are working for you? Get the latest build here: https://git.froggi.es/joshua/d9vk/-/jobs

Dead Space appears to have different rendering paths depending on which (hack-)formats are available.
Comparing different apitrace this sticks out:
Nvidia Windows
R32F
DF24 => D3DERR_NOTAVAILABLE
D24S8
INTZ
1111774798 (NVDB)
NULL
AMD Windows
R32F
DF24
1111774798 (NVDB) => D3DERR_NOTAVAILABLE
D9VK
R32F
DF24
1111774798 (NVDB) => D3DERR_NOTAVAILABLE

We have shadows! :tada:
But there is still an issue with the lights:
with d9vk:

without d9vk:

With d9vk, it's brighter.

https://i.imgur.com/1MyHK5n.jpg
I can confirm the brightness issue. Left one is Windows D3D9.

Josh found a small issue with the way D9VK handles gamma ramps. Please retest.

Nothing changed, unfortunately.

If you're playing full screen then I experienced the same brightness change on Windows only in that mode.
It won't capture on a screenshot with native tho

D3D9 and WineD3D change the system level gamma, which doesn't show up on screenshots. D9VK does the gamma correction using a shader.
That's why D3D9 and WineD3D screenshots look darker than D9VK screenshots.
From eyeballing it, it looks identical to me compared to Windows D3D9.

Hm, I disagree, it's not the screenshots, there is a real difference. Just try to switch between fullscreen and windowed, you'll see.

Just try to switch between fullscreen and windowed, you'll see.
This also happens with Windows D3D9.


Make clang-tidy happy.

Copying the ByteSource and ByteSink std::function objects is less preferred than using const references.
Don't pass member variable as parameter when calling a member function (for Copy.., Compress..).
While at it: use suggested std::clamp as we already require C++17.
Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Note, clang-tidy is disabled here, but will be ready to be used again when glog is removed ( #1448 )


Pip can't resolve dependencies

I'm having some trouble installing the following from a requirements file:
jinja2
piccolo[postgres]
piccolo_admin
xpresso
uvicorn

Pip can't resolve the dependencies and gets caught in an endless loop.
It only started today - I noticed because the CI started failing. I can't see anything in the latest Xpresso release which may have caused this.
Do you have any ideas?

Weird. I have made some changes in the last week, but mostly loosening dependencies. I'll try this and report back.

@adriangb Thanks :)

Worked fine in a colab notebook: https://colab.research.google.com/drive/1yojpO7dArlvlqh6GUay9NedM7AlSpH-g#scrollTo=wWX8WOo8FBzV
Could you post the Python/pip versions, and maybe point me to the failing CI runs and I can take a look at those as well?
Also I assume this works fine without Xpresso?

I was able to reproduce now. I narrowed the issue down to:
piccolo_admin
starlette>=0.19.0

As of accf69a6c6fc3201deb7da94fea2282c1bd84579 Xpresso depends on starlette>=0.19.0 so that we can use https://github.com/encode/starlette/pull/1435. I did this to avoid juggling compatibility; I thought there'd be no reason to install Xpresso along with  FastAPI. But it seems like piccolo_admin depends on FastAPI.
So there's two options here:

Do compatibility stuff in Xpresso to support Starlette >= 0.17.1 (like we did before)
Remove the direct dependency on FastAPI from Piccolo Admin. FastAPI pins specific Starlette versions, which makes it hard to maintain compatibility with it (I plan not to do this with Xpresso, but I just happened to update to >=0.19.0)

I'll look into the former, I don't think it will be too hard.

Thanks for looking into it. I've had problems too in the past with FastAPI version pinning a specific Starlette version.
I can't easily remove FastAPI from Piccolo Admin unfortunately.
I can temporarily disable the integration test, so there's no immediate pressure to get this fixed.

I think I'll have a fix up in the next 15 min, let me try that before you disable the integration tests 😄

Awesome, thanks! 🚀

All set! Build should be up on PyPi in the next 5 min

@adriangb Perfect, thank you!


[Bug]: CommonsMultipartFile class can't retransform

Preflight Checklist

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the issue tracker for an issue that matches the one I want to file, without success.
[X] I am not looking for support or already pursued the available support channels without success.

Version
1.0.4
Installation Type
Official SaaS Service
Service Name
DongTai-Core
Describe the details of the bug and the steps to reproduce it
I used DongTai to test any file upload vulnerability in the Spring project, but it could not be detected; after analysis, I found that the hook rule is missing: org.springframework.web.multipart.commons.CommonsMultipartFile
Additional Information
After analysis, it is found that the CommonsMultipartFile class cannot be transformed, but the class exists in AppClassLoader. The cause of the problem was finally located: the delayed start caused the class to be unable to be transformed, and eventually the hook point was lost, resulting in the vulnerability being unable to be detected. After the delayed start was deleted, the problem was fixed.
Logs
No response

Delayed loading caused the class to not go through the transform method and reTransform method, and eventually the class was not hooked. It fixed in v1.0.6


APIPermission session shouldn't be optional, right?

It's a bit off that you can be permissioned when your not logged in..

The logic behind this was due to using things like rate-limiters, where your permissions can be based on your region or something else.
It's a little annoying to wrap things inside of an if condition, but it does somewhat make sense.


Narrator is silent and focus lands to "Aqua" on pressing "Home" Key in the colors list in ItemsRepeater.

Describe the bug

Home and End keys are not handled in the repeater sample.
Steps to reproduce the bug

Steps to reproduce the behavior:

Turn on Narrator.
Launch XAML Controls Gallery.
Activate ItemsRepeater from home page, navigate to header "Animated Scrolling and Content Display" and press  "Home" Key and observe.

Expected behavior

Focus should go to the first item in the list i.e "AliceBlue"
Narrator should describe about the item.

Actual behavior

Focus does not land on the first list on pressing Home key but it's focus goes to  "Aqua" . Also, Narrator is silent.
Screenshots

Version Info

Gallery version (found on Settings page):

<IP_ADDRESS>
Additional context

Copied from internal bug

@anawishnoff FYI

@YuliKl
Hmm, this is interesting. I think my comment on #376 would apply here as well - if the list was infinitely scrollable, would it then make sense to have focus on Aqua after pressing Home key?
I see there is definitely also a lot of work to be done with making sure that Narrator is guiding the user through the samples correctly. I can look into how this is done.


Frontend: Incarceration

Preview Link

Click to demo updates
To Do

[x] confirm footer sources working
[x] spot check data thoroughly
[x] change alaska hi/lo message on jail to indicate private facilities only
[x] fix data type toggle spacing
[x] fix age buckets on data table for jail
[x] fix "sentenced" alert to either reflect that jail is "confined" population, or simply remove when on jail data type
[x] sum raw number of children in prison + jail on backend, and present on both prison and jail shortAlerts
[x] hide "confined children alert" on non-Age reports (or including confined children total on ALL demographic breakdown tables)
[x] display state alert on national jail, and all affected states. Alaska needs extra note re: private jails
[x] methodology needs to address missing people "supervised outside of jai"l 5% and serving weekend only 0.8%
[x] add pretty comma formatting to number of children confined
[x] create combined IncarcerationProvider to load in data. Need to further divide lookup by data type, as prison/jail will have different population comparison metrics and therefor different tables
[x] remove extra races from county level table cards
[x] disable age button on county level
[ ] update definitions for Vera (should mimic BJS but with some adjustments)
[ ] update methodology
[ ] figure out Vera data not as recent as their real (unpublished) API

Description

Displays BJS Prison data from #1581
Displays BJS Jail data from  #1616
Displays Vera County Prison + Jail data from #1622

Motivation and Context

#1582
How has this been tested?

[ ] all new frontend utility functions have unit tests
[ ] adds or extends relevant e2e tests

Screenshots (if appropriate):
Types of changes

New feature (non-breaking change which adds functionality)

@benhammondmusic Can we remove all the frontend/tmp files?


[Feature Request] Allow spcifying keys somewhere else

why do the keys need to be stored in an environment variable? couldnt they also be stored in the caddy file or another file which is kept safely?
also having the keys somewhere else would allow for usage different JSON keys for different paths, for example, different actors allowing access for different paths.

The main reason is that if you keep your keys in the Caddyfile you can no longer keep it in a public repository.  Putting sensitive information in there is probably not a good idea from a security standpoint either.  Using environment variables for sensitive configuration is a best practice.
The goal of this middleware is the same as for Caddy - to keep things as simple and secure as possible.  You can use the kid field in your JWT do your own custom key lookups on the backend and use as many different secrets/algorithms as you like.  Sophisticated security polices are beyond the scope of this middleware, so the right place to do that is in the app that you're proxying to.

Caddy supports substituting environment variables for any part of the caddyfile. See docs. Is that sufficient for your needs. I keep such things in an .env file and load it when I run with systemd or with zoo.

@BTBurke is it possible to use different keys for different sites within a caddyfile? Perhaps that would be a case where specifying something in the caddyfile might be useful.

@BTBurke well I did specifilically say the caddyfile or another file which is kept safely, also are environment vars that good  of an Idea? I mean especially in linux it is kind of a common practice to let servers and other daemons run as their own user, which cannot log in. but I dont remember a way of setting an environment variable for such a daemon user.

Sure, in systemd or some other init system you can set an environment variable for the running process.  I run caddy in a container so I haven't tried that, but it shouldn't be a problem.  There are a couple good reasons to go with environment variables:

Keeps sensitive config outside the Caddyfile
Allows you to change the secret without Caddy restart
Not as many corner cases with concurrent read/write access
Fits in with workflows for 12-factor style apps and containerization

So this assumes that you have some kind of service that is issuing your tokens.  You want that service to be in charge of generating/revoking/rotating your secrets.  Because Caddy doesn't yet have a way to hot reload the config (that I know of), if you put it in the Caddyfile you have no way of having your JWT service and this middleware stay in sync if you change the secret your JWT service is using.  You can't reload the Caddyfile without a restart of the process.  So my personal opinion is that isn't a great way to architect the system, in addition to the fact that I think it's a bad idea to put secrets in the Caddyfile.
You could use a file as a mechanism to pass the secret back and forth but now you are in a situation where you have the potential for concurrent read/write to your secret file at the same time.  You have your JWT service that needs to get an exclusive lock on the file to write a new secret at the same time you may have N goroutines that are trying to read that file to process requests.  You could cache the read at startup, but now you no longer have the ability to change the secret.  Of course, it all depends on which filesystem it's running on and how locks are handled, but I think it could be a source of weird corner cases and bugs.
To @captncraig's point, there is no way to specify multiple keys for different sites in a Caddyfile.  If we were to go this route, one way would be to keep the config in the environment and specify which environment variable contains the key.  The problem with this is that it can potentially open up an attack vector against the JWT in the case of the RS-family of algorithms where an attacker can potentially forge a key by changing the algorithm to HS in the header and signing a token with the public key.
There are ways to combat this, but it would be by doing stuff that's not in accordance with the JWT spec and/or adding a bunch of extra directives to the middleware and having a more complicated process for validating the config.
So, all that is to say that it quickly becomes complicated.  And in that case, my feeling is that you're treading into the realm of advanced use cases where it makes sense to move your JWT validation into your app where you have full control over your exact set up.

couldnt it be possible that the key definition could hold the name of the signing algo? that would patch that opening hole right shut again, for example:
HS256-nKp09d9bMBFPQq8M69v0LVYV16GSkIeJBlk4WDeb
and of course RSXXX-pubkey for RSA with pubkey obviously being the public key.

There's no hole there.  In fact, if you short-circuit the process of validating the token cryptographically you're giving away information about the signing algorithm, also known as a timing attack.  For example, if you specify HS256 and send a forged token with HS512, but you reject it immediately based on the header, an attacker can measure the response time to figure out what kinds of algorithms you are accepting.

the hole I referred to was what you said with the RS/HS swap when being able to store the variable somewhere else.
Let me quote you:

The problem with this is that it can potentially open up an attack vector against the JWT in the case of the RS-family of algorithms where an attacker can potentially forge a key by changing the algorithm to HS in the header and signing a token with the public key.

well this would open a timing to figure out what algorithms are okay, but even then if you literally tell an attacker what algos are accepted, he still has to get in with one of the allowed algorithms. also a small rethoric question: what is safer? 3 doors that can open with the right key or 1 one door which can opened with the right key and the other doors bolted shut?
putting the fact that all 3 HS algos are pretty much impossible to bruteforce at the speeds we have now
in terms of bruteforcing your way in, having 3 keyholes essentially gives an attacker the option to select the weakest one or to attack all of them at once, while the defender (aka the server) may want to shut anything that is either not used or not secure (HTTPS servers also dont have all possible theoretically secure combinations of algos enabled, usually just the common ones needed by the users, to keep the actual attack surface as small as possible.)

That's not the right way to think about it.  It's one door with three locks on it and all have the same key.  When people do a brute force attack against an HMAC, they are brute-forcing your key and not the signature.  The security depends on the length and entropy of your secret key, not the algorithm.  It doesn't matter if there are three locks on the door or one.  Once you guess the key, you can open any lock.  That's why taking two locks off the door doesn't do anything.
The bottom line is that you're free to use this library if you want.  You can fork it and put whatever you want in it and build your own version of Caddy from source.  You can move your JWT validation into your app and do what you want with it.  But I'm closing this issue because we're going around and around over nothing.


Some CommonMark 0.17 tests fail

Some CommonMark 0.17 tests in the section "Emphasis and strong emphasis", notably those containing intraword underscores, fail with the current master.
One example is пристаням_стремятся_ — it should render as
пристаням_стремятся_
 and not as
пристанямстремятся
.

https://github.com/markdown-it/markdown-it/tree/master/test/fixtures/commonmark
Currently conformed spec is 0.15. Also there are pending changes in emphasis, discussed on forum. We don't update immediately non critical changes, because it's too time-consuming.
Everything about spec is under the control, dont' worry. If you like to dig code, take a look at https://github.com/markdown-it/linkify-it . It's upcoming replacement for current linkifier, and it really needs intensive testing of edge cases.


Dark Theme and Theme Docs

Reason for change

Added dark theme
Modified Gatsby setup so that base theme loads before sample themes.
A start on theme docs (I think this still needs some work. I'll keep adding to it over time)

Testing

Apply Dark theme and ensure components render properly. Also test that other themes still work as expected.
Go to theming section on docs site and check for accuracy and quality of docs.

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   53.03%   53.03%
=======================================
  Files          30       30
  Lines         709      709
  Branches      164      164
=======================================
  Hits          376      376
  Misses        331      331
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 595383f...fc9b99c. Read the comment docs.


Cannot pass in a pretokenized dataset to SFTTrainer with error "text input must of type str"

Hi,
I tokenized my dataset and uploaded it to HF. When passing it into SFTTrainer I get the following error:
ValueError: text input must of type `str` (single example), `List[str]` (batch or single pretokenized example)
or `List[List[str]]` (batch of pretokenized examples).

Since my dataset is tokenized, all the data points are Integers and not Strings. Is it possible to use a pretokenized dataset at all? I could cast the datapoints to Strings (i.e. token 1234 will become "1234"). Would that mean that the strings will be tokenized again, thus creating garbage data? In the error message the term "pretokenized" is listed so I guess it is possible, but why are Integers not accepted?
Minimal example (cannot share my dataset so this uses a different dataset than mine, but still same issue):
from transformers import AutoModelForCausalLM, AutoTokenizer, DataCollatorForLanguageModeling, TrainingArguments
from datasets import load_dataset
from trl import SFTTrainer

dataset = load_dataset("kennbyee25/distilroberta-base_tokenized_english_patents")  # dataset that has integers in column "input_ids"
train_dataset = dataset["train"]

tokenizer = AutoTokenizer.from_pretrained("sshleifer/tiny-gpt2")  # small test model
tokenizer.pad_token = tokenizer.eos_token

data_collator = DataCollatorForLanguageModeling(tokenizer, mlm=False)

model = AutoModelForCausalLM.from_pretrained(
    "sshleifer/tiny-gpt2"
)

output_dir = "./results"
per_device_train_batch_size = 1
gradient_accumulation_steps = 4
optim = "paged_adamw_32bit"
save_steps = 10
logging_steps = 10
learning_rate = 2e-4
max_grad_norm = 0.3
max_steps = 2
warmup_ratio = 0.03
lr_scheduler_type = "constant"

training_arguments = TrainingArguments(
    output_dir=output_dir,
    per_device_train_batch_size=per_device_train_batch_size,
    gradient_accumulation_steps=gradient_accumulation_steps,
    optim=optim,
    save_steps=save_steps,
    logging_steps=logging_steps,
    learning_rate=learning_rate,
    fp16=True,
    max_grad_norm=max_grad_norm,
    max_steps=max_steps,
    warmup_ratio=warmup_ratio,
    group_by_length=False,
    lr_scheduler_type=lr_scheduler_type,
)

max_seq_length = 512

trainer = SFTTrainer(
    model=model,
    train_dataset=train_dataset,
    data_collator=data_collator,
    max_seq_length=max_seq_length,
    tokenizer=tokenizer,
    args=training_arguments,
    dataset_text_field="input_ids"
)

Btw: The "standard" trainer from HuggingFace accepts the pretokenized dataset, is that because Trainer requires tokenizing your data before passing it through and SFTTrainer requires non-tokenized data?

The SFTTrainer is a wrapper around the Trainer with the goal of making training on text easier, that's why tokenization is handled internally and you can't pass tokenized datasets. You have two options:

Decode the tokenized dataset again and pass it to the SFTTrainer.
Use the Trainer instead.

Hope this helps!

Yes thanks that helps a lot and is good to know!
Although I would say it would make things easier if both non-tokenized and tokenized datasets can be passed in. Maybe checking the datatype (which is already done) could be used to distinguish between the two types of datasets but I am not sure if this would be a robust solution.

yes

Ideally I think there should be a way of letting know that we are passing tokenised dataset to the SFTTrainer.
In my case, while I am performing multiple experiments with the same and huge amount of data (~10M samples of 2k seq_len), it  becomes cumbersome and time consuming on rented GPUs to wait for couple of hours first to tokenise and then train the model.

yes this and I need to be able to pass custom labels (some set to ignore index)


archive node to add genesis epoch ledger hash

if the archive database is new or the ledger hash changed then genesis epoch ledger hashes might not be in the snarked_ledger_hashes table

Hi there, wondering if there may be a package out here that has this fix in place already. I tried adding some snarked_ledger_hashes manually to the postgres db, but it appeared hit and miss. Sometimes blocks would be added. Other times it would complain that the snarked_ledger_hashes already existed which is bizzare because that would (I believe) imply that it's attempting to do an insert, but if I start the instance up with a fresh DB, no snarked_ledger_hashes are ever added.

Hi there, wondering if there may be a package out here that has this fix in place already. I tried adding some snarked_ledger_hashes manually to the postgres db, but it appeared hit and miss. Sometimes blocks would be added. Other times it would complain that the snarked_ledger_hashes already existed which is bizzare because that would (I believe) imply that it's attempting to do an insert, but if I start the instance up with a fresh DB, no snarked_ledger_hashes are ever added.

@mnguyen-io can you open an issue for this, with the commands you used, what you expected to happen, and what actually happened

@mnguyen-io can you open an issue for this, with the commands you used, what you expected to happen, and what actually happened

Apologies, here is the issue ticket:
https://github.com/MinaProtocol/mina/issues/7455

Apologies, here is the issue ticket:
https://github.com/MinaProtocol/mina/issues/7455


MCAPP creation error message does not include information about the missing roles for all target projects.

Rancher server build from master - Mar 7
Steps to reproduce the problem:
As global admin user , create a cluster - "mytest" .
Add user - "test1" to "Default" project as "read-only" member.
Add user - "test1" to another project "project1"  as "read-only" member.
Log in as test1.
Create a MCAPP with target project as "Default" from "mytest" cluster.
MCAPP fails to get created as expected with following error message:
```user does not have following roles in project Default of cluster mytest: [project-member]``
It does not include the information about the missing roles in other project.
Expected Behavior:
Error message should include information about the missing roles for all target project.

Tested with latest build from master - 5badc15e
Steps to reproduce the problem:
As global admin user , create a cluster - "mytest1" and "mytest2".
Add user - "test1" to "Default" project of "mytest1" as "read-only" member.
Add user - "test1" to "Default" project of "mytest2" as "read-only" member.
Log in as test1.
Create a MCAPP with target project as "Default"/"mytest1" and   "Default"/"mytest2".
App creation succeeds.
Expected Behavior:
MCAPP  Creation should fail with error message including information about the missing roles for all target projects.

Tested with latest build from master - 803c151a
As global admin user , create a cluster - "santestdo" and "santestdo2".
Add user - "test1" to "Default" project of "santestdo" as "read-only" member.
Add user - "test1" to "Default" project of "santestdo2" as "read-only" member.
Log in as test1.
Create a MCAPP with target project as "Default"/"santestdo" and "Default"/"santestdo2". (role gets defaulted to Project member).
Mcapp creation fails as expected and user is presented with following error message:
User does not have roles project-member in project Default of cluster santestdo, roles project-member in project Default of cluster santestdo2


Add pref to allow indenting line comments

Fixes #8012.
This pref is enabled by default, aligned with https://github.com/adobe/brackets/issues/8012#issuecomment-54155264.
The pref does not apply when there's no line comment syntax available and we fall back to block commenting the line.
cc @le717 @redmunds

@MarcelGerber Making this a preference (which can be specified per-language) is a good idea for languages where indenting on single-line comments is a user choice.
Can you also add a new property in languages.json file for languages that can only work as indented (or not) ? Otherwise, languages such as Jade won't work correctly when Brackets is initially installed -- users will need to manually set this preference first (and need to know to do this). There are some other languages (vbscript? bash?) that only work with single-line comments at start of line (so we can't simply change default to indented).
I think setting in languages.json should be the default, and preference will override it.
Please add a unit test.

This is great. I have been trying to implement this, but I had some issues with other changes I made and didn't had much time to fix them. So I don't mind that you implemented it.
But when I implemented it, I finished with 3 modes:

If the language had indented comments, the comment would be added right after the leading space. I did added this in language.json and could not be overwritten by other preferences, since commenting might not work.

I then added a preference to switch to indenting comments, this would add the line comments right after the minimum leading space in the selected block, so that the line prefixes where all the same indentation.

If that preference was set to false, then it would use the current commenting at the beginning of each line.

I would suggest something like this. If comments on a language only work when they are right before the content, then it shouldn't be possible to change this behaviour with a preference. If there are languages where the line comment needs to be at the start of the line, then we would need another attribute in language.json for those languages which should not be overwritten by a preference.

Ah, I found your work in progress at https://github.com/adobe/brackets/commit/1a87b7e56fca48cb2902037f22e5ad2ef2d82c22#diff-a4c3174140581e8c106b11103021b6a8. I might be able to reuse some of that. Thanks for pointing out!

Ready for another review.
I've implemented all 3 modes and implemented the possibility for a language to force comments at the beginning of line.
Unit tests still missing out, though.
I've tested .bat and .sh and it looks like both don't explicitly need to have the comment at the beginning (couldn't test VBScript). Also, SASS compiled just fine with comments not correctly indented.
That's why I only added Stylus for now.

#11954 landed which superceded this PR

Closing.


CASMINST-5900: direct cray-product-catalog-update output to /dev/null

When the code to update the cray product catalog with NCN image info was added, the output for the podman call was not redirected to /dev/null. As a result, that output was processed by processed by prerequisites.sh, which lead to other problems downstream.
This commit does two things:

Redirects stdout from the podman call to /dev/null
Adds a regex check on the output from the script to ensure the only thing we're getting is a valid UUID.

Description

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport main


Clarify how to override default components that use multiple slots.

The documentation lacked an explanation of how to override default components that use named slots. Passing all slots through is necessary. Omitting this step breaks the layout for example when user conditionally changes PageFrame.astro.
The commit adds an explanation and a code example.

---
// this could be: src/components/ConditionalPageFrame.astro
import type { Props } from '@astrojs/starlight/props';
import Default from<EMAIL_ADDRESS>const isHomepage = Astro.props.slug === '';
---
{
	isHomepage ? (

My great landing page 🌟

	) : (
		<Default {...Astro.props}>
			<slot />
			<Fragment slot="header"><slot name="header"/></Fragment>
			<Fragment slot="sidebar"><slot name="sidebar"/></Fragment>
		</Default>
	)
}

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/overriding-components.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Thanks for your contribution :raised_hands:
This is definitely something that we do not explicitly document and has come up a few times already. I'd like to get other people's opinion on this but my initial thought would be that this would better fit in the "Reuse a built-in component" section rather than the "Use page data" one. I'm also not sure we would need an entire new code example for this as this would be mostly identical to other ones we already have but we could link to the relevant Astro Docs section.
I think my idea would be to add a third bullet point to the "Reuse a built-in component" unordered list that could look something like this:

If the built-in component you are reusing also contains nameed slots, e.g. like the TwoColumnContent component which uses a right-sidebar slot, you need to transfer theses as well using the <slot name="right-sidebar" slot="right-sidebar" /> syntax.

Another possibility that comes to mind is to reference additional named slots in the "Overrides Reference" page for the few components that have them. At the moment, only TwoColumnContent and PageFrame have named slots.
For example, below the "Default component: TwoColumnContent.astro" line, it could say:

Default component: TwoColumnContent.astro
Named slots: right-sidebar

Like I said, I'd like to get your and other people's opinion on this before I make any changes. Let me know what you think.

Thanks @HiDeoo for reviewing the proposed change. I agree that the information fits better as a third bullet point under Reuse a built-in component. Also referencing the named slots in the Overrides Reference makes sense to me as most users probably won't check in the overridden file in depth and would appreciate a hint that they need to handle the slots.
I'll wait for others' opinions as well and proceed with your suggested change in this PR if I don't hear otherwise.

Hey @HiDeoo. As I haven't heard any other opinions on that I've made the suggested changes:

Removed the additional code example
Added a third bullet point containing the code example with TwoColumnContent
Added the named slots: line to the Override References

The general consensus seems to be that both your initial suggestion with a example and some of the changes I suggested are good ideas so I left a new suggestion matching both of them. Let me know what you think about it.

Sounds perfect. Thank you for getting back! I've added the suggested change.


internal depCache gets overridden when using merge-stream

I have a project that uses Bower to bring in 3rd party dependencies. I created a gulp task to grab all the stylus files from the Bower components and my apps assets and run them through glup-progeny and stylus. Because the folder structure is different, I used merge-stream to run the same stream on two different sources and dests.
However, when gulp-progeny is called from two different streams, the internal depCache only lists the assets from the second stream and the first stream is never listed. So any assets in the first stream do not have their dependencies listed and so editing a dependency does not update the parent.
Here is an example folder structure
./
├ assets
│  ├ foo.styl
│  ├ bar.styl
│  └ concat.styl
│
└ bower_components
   └ project
     ├ faz.styl
     ├ baz.styl
     └ concatz.styl

Where assets/concat.styl imports foo.styl and bar.styl, and bower_components/project/concatz.styl imports faz.styl and baz.styl.
Here is an example gulpscript
var gulp = require('gulp');
var stylus = require('gulp-stylus');
var cache = require('gulp-cached');
var progeny = require('gulp-progeny');
var merge = require('merge-stream');

function buildStylus(files, config, dest) {
  return gulp.src(files, config)
    .pipe(cache('stylus'))
    .pipe(progeny())
    .pipe(stylus())
    .pipe(gulp.dest(dest));
}

gulp.task('stylus', function() {
  var assetsStylus = buildStylus(
    'assets/**/*.styl'
    {base: 'assets', nodir: true},
    'dist'
  );

  var componentsStylus = buildStylus(
    'bower_components/**/*.styl'
    {base: './', nodir: true},
    'dist'
  );

  return merge(assetsStylus, componentsStylus);
});

gulp.task('watch', function(){
  gulp.watch('*.styl', ['stylus']);
});

Editing foo.styl or bar.styl never cause assets/concat.styl to update, but editing faz.styl or baz.styl do cause bower_components/project/concatz.styl to update.

Upon further investigation I don't believe this is the issue. I'll create another issue if I find what is truly going on.


sweep+lnrpc: enforce provided fee rate is no less than relay fee

Change Description
Fixes #7512 by enforcing that if a manual fee rate is provided in RPC calls then that fee rate is no less than the relay fee of the underlying chain node. To achieve this, as suggested, the calculateFeeRate() function was refactored out of rpcserver.go and into rpc_utils.go, and reused in walletkit_server.go. This way FundPsbt rpc call can use the same fee estimation logic as OpenChannel, SendCoins, etc.
I've tried my best to follow the required practices (code style, linting, comments etc.). Since this is my first PR, I'd love any feedback about what I may have overlooked :slightly_smiling_face:
Steps to Test
Attempt any one of the rpc calls whilst providing a manual sat per vbyte which would fall below the relay fee of the chain node that lnd is connected to. The call should error out:

OpenChannel
SendCoins
SendMany
CloseChannel
FundPsbt

Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[X] Tests covering the positive and negative (error paths) are included. (existing test was updated)
[X] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[X] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[X] Commits follow the Ideal Git Commit Structure.
[X] Any new logging statements use an appropriate subsystem and logging level.
[X]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

for fundpsbt it would be nice to provide a minimum relay fee to funding, maybe locally the minimum relay fee is higher than the chain daemon ultimately where it will be broadcast - a funded psbt can be broadcast outside of the local chain backend

for fundpsbt it would be nice to provide a minimum relay fee to funding, maybe locally the minimum relay fee is higher than the chain daemon ultimately where it will be broadcast - a funded psbt can be broadcast outside of the local chain backend

Why would you not just specify a custom --sat_per_vbyte value in that case?

Why would you not just specify a custom --sat_per_vbyte value in that case?

right but wouldn't this block that if the specified rate was too low?

right but wouldn't this block that if the specified rate was too low?

The change in this PR wouldn't block you from using that lower fee rate but increase the manually specified rate to the minimum local rate. I can see why this might not always be the desired outcome. Maybe we need a --i_know_what_i_am_doing_let_me_publish_with_low_fees flag? :D Not sure how much of an edge case this actually is though? Have you ever encountered a situation like this where you would have wanted to specify a rate that was too low for the local node?

right but wouldn't this block that if the specified rate was too low?

The change in this PR wouldn't block you from using that lower fee rate but increase the manually specified rate to the minimum local rate. I can see why this might not always be the desired outcome. Maybe we need a --i_know_what_i_am_doing_let_me_publish_with_low_fees flag? :D Not sure how much of an edge case this actually is though? Have you ever encountered a situation like this where you would have wanted to specify a rate that was too low for the local node?

yeah that's what i mean exactly
for fundpsbt definitely yes, especially in cases where psbts are being collaboratively formed but not all participants agree on a minimum relay fee. a lot of operators run a limited mempool to save on operational costs. for the other calls I can't think why you would care, only fundpsbt because that isn't necessarily going to be broadcast locally or maybe it will not be broadcast locally immediately

for fundpsbt definitely yes, especially in cases where psbts are being collaboratively formed but not all participants agree on a minimum relay fee. a lot of operators run a limited mempool to save on operational costs. for the other calls I can't think why you would care, only fundpsbt because that isn't necessarily going to be broadcast locally or maybe it will not be broadcast locally immediately

Okay, that case makes sense. Though I guess my question would be: Does it really make sense to publish a transaction with a fee rate that you know upfront won't make it into the default mempools? Assuming the resulting transaction most likely is a channel funding TX where you'd risk it not being confirmed in the necessary 2 weeks if the fee rate is too low? Or would the use case here be to low-ball it with 1 sat/vByte and then later CPFP it higher?

Okay, that case makes sense. Though I guess my question would be: Does it really make sense to publish a transaction with a fee rate that you know upfront won't make it into the default mempools? Assuming the resulting transaction most likely is a channel funding TX where you'd risk it not being confirmed in the necessary 2 weeks if the fee rate is too low? Or would the use case here be to low-ball it with 1 sat/vByte and then later CPFP it higher?

Yeah the issue is the publish time and place which can be variable - potentially low-balling with cpfp or just waiting for publish at a later date and creating a series of potential txs that all can be used, but at different fee rates

Thanks for the review @guggero ! I'll get started on the feedback you provided.
I would also like a bit of help tackling this failing itest:

It tries to fund a PSBT with a fee of 1sat/vbyte, which translates to 250 sat/kw. However, with these new changes, we enforce a floor of FeePerKwFloor which is a constant with the value 253 sat/kw. How best to remedy this? There are a lot of hardcoded numbers in this itest file and I would like to make the most minimal change that makes sense.
Finally, I tried to follow the discussion between you and @alexbosworth -- is the ask to additionally provide a floor for FundPsbt that overrides the relay fee setting? If so, that seems to be a larger scoped change involving CLI + RPC additions. If this is desired, may I ask if it's okay to either:

Keep this PR as-is and add the new flag in a separate PR OR
Remove FundPsbt changes from this PR and put those in a separate PR (with the added flag for the floor override)

?

For FundPsbt the idea is just to avoid the fee guardrails being mandatory
Another idea I had though is to allow for clamping the fee estimate, seems like a lot of times that this error condition happens it's because Bitcoin Core is returning a low end fee estimate that is below its minimum relay fee
This makes more sense in Bitcoin Core because the idea is that you rebroadcast your transactions and the mempool is more of a temporary cache rather than a guaranteed queue

Remove FundPsbt changes from this PR and put those in a separate PR (with the added flag for the floor override)

Yes, I think we should go with option 2, address FundPsbt in a separate PR (building on top of this one). The idea is to have an additional flag, for example --ignore_min_mempool_fee which would allow you to set --sat_per_vbyte explicitly without it being bumped to the minimum fee as it is done in the other RPCs. I'm not sure how Alex's fee estimate clamping would look like though, but I guess that can be discussed in the follow-up PR.

It tries to fund a PSBT with a fee of 1sat/vbyte, which translates to 250 sat/kw.

Ugh, yeah, that test is a bit of a pain with all the hard coded values. Since this sounds like a pure rounding thing (where the 3 additional sat/kw sometime result in a full satoshi more in fees), I think you just need to update the values until you get no failure. You can run that test in isolation by running make itest icase=lnd_wallet_import_test which should save you some time.

by clamping the fee estimate i mean just make sure that if you ask for a long confirm conf target like 1000 that it doesn't return or use a fee rate that is below the minimum relay fee rate

I believe that already happens for both bitcoind and btcd.

by clamping the fee estimate i mean just make sure that if you ask for a long confirm conf target like 1000 that it doesn't return or use a fee rate that is below the minimum relay fee rate

I believe that already happens for both bitcoind and btcd.

ah ok great, nevermind then

@shaurya947 thanks for the updates. Can you apply the fixup commits please? I'll give this another round of review afterwards.

Done @guggero :slightly_smiling_face:

Also, any ideas why the itest check for backend=bitcoind dbbackend=etc fails (but not the others)? Is that expected? When I try running locally using dbbackend=etcd I'm not even able to get past the test set up (says found nil RPC clients)

Hey @guggero and @yyforyongyu , I updated the PR to error out when the provided fee is too low. Updated the tests as well. Let me know how it looks now :slightly_smiling_face:

Looks like we actually use a fee rate lower than 253 sat/kWU in one of the integration tests: manual fee rate input of 250 sat/kw is too low to be accepted into the mempool or relayed to the network. So maybe that extra automatic bump from 250 to 253 is actually needed.

Hey @guggero thanks for looking into the test failure.
I wanted to make sure I fully understand your suggestion. So we're considering two values, FeePerKwFloor and RelayFeePerKW. And we'd like to uphold the following two constraints at the same time:

If the specified fee is below FeePerKwFloor, bump it to FeePerKwFloor
If the specified fee is below RelayFeePerKW, reject with an error

Is that accurate?
If so, we consider the 3 possible inequalities:

FeePerKwFloor < RelayFeePerKW: in this case, the bump (constraint 1) would always be a no-op because even after the bump we will always be below RelayFeePerKW
FeePerKwFloor == RelayFeePerKW: in this case, the bump (constraint 1) would indeed work as intended, but in doing the bump, we would violate constraint 2
FeePerKwFloor > RelayFeePerKW: I think this case has undefined behavior w.r.t the two constraints because now the interval [0, FeePerKwFloor) is split into two:

[0, RelayFeePerKW) conflict—should error out as per constraint 2, but do a bump as per constraint 1
[RelayFeePerKW, FeePerKwFloor) no conflict—bumps as per constraint 1 whilst also respecting constraint 2

Let me know if I'm misinterpreting or overthinking this. Otherwise I can just change the itest to use a higher fee value.

Hmm, you are right, there might be weird edge cases here. To me RelayFeePerKW is more or less a constant, since it requires an active config change in the bitcoind backend. But that might actually happen.

Otherwise I can just change the itest to use a higher fee value.

I wasn't sure how many tests would be affected. And it sounded a bit like a workaround to me. But maybe that is indeed the better option?
I guess what we always have to check is that the fee rate returned by feeEstimator.RelayFeePerKW() is larger or equal to FeePerKwFloor. Because if the rate is FeePerKwFloor it very likely won't propagate anyway (even if the local bitcoind would accept it due to custom/wrong user settings).
So perhaps do this in walletsweep.go instead?
		feePerKW := feePref.FeeRate
		minFeePerKW := chainfee.FeePerKwFloor
		minRelayFeePerKW := feeEstimator.RelayFeePerKW()
		if minRelayFeePerKW > chainfee.FeePerKwFloor {
			minFeePerKW := minRelayFeePerKW
		}

		if feePerKW < minFeePerKW {
			return 0, fmt.Errorf("manual fee rate input of %d "+
				"sat/kw is too low to be accepted into the "+
				"mempool or relayed to the network", feePerKW)
		}

Hey @guggero thanks for the feedback!

I guess what we always have to check is that the fee rate returned by feeEstimator.RelayFeePerKW() is larger or equal to FeePerKwFloor

This was actually going to be my next question :slightly_smiling_face: because I believe this already happens. RelayFeePerKW() calls minFeeManager.fetchMinFee(), which internally ensures that we're always >= FeePerKwFloor https://github.com/lightningnetwork/lnd/blob/bbbf7d33fb1527acebb44e2a69d16fbcf24cc2fa/lnwallet/chainfee/minfeemanager.go#L73
So what do you think then, just update the tests?

Updated itests. Hopefully I caught everything :)

Makes sense @guggero , updated!


[AutoPR network/resource-manager] Get Application Gateway Server Variables APIs changes for 2018-11-01

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5157

(message created by the CI based on PR content)

Codecov Report

Merging #4311 into restapi_auto_network-january-release will decrease coverage by 0.03%.
The diff coverage is 1.42%.

@@                           Coverage Diff                            @@
##           restapi_auto_network-january-release    #4311      +/-   ##
========================================================================
- Coverage                                 54.35%   54.31%   -0.04%
========================================================================
  Files                                      9772     9768       -4
  Lines                                    206380   206516     +136
========================================================================
- Hits                                     112181   112179       -2
- Misses                                    94199    94337     +138

Impacted Files
Coverage Δ

...rk/azure/mgmt/network/network_management_client.py
25.87% <1.42%> (-2.03%)
:arrow_down:

...osearch/azure/cognitiveservices/search/__init__.py

...datalake-analytics/azure/mgmt/datalake/__init__.py

azure-mgmt-documentdb/azure/mgmt/__init__.py

...computervision/azure/cognitiveservices/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f996cb...260a971. Read the comment docs.


Get output from clair-scanner as a json file

Can you make sure that your vulnerability report can be provided as a json file?

+1 for this or any other machine parsable output file would add with integrations with CI

Closed by PR #22


not able to install juju with snap install juju --classic

i am not able to install juju with snap install juju --classic command.
am getting below error:
root@juju:~# snap install juju --classic
error: cannot install "juju": cannot get nonce from store: Post
https://api.snapcraft.io/api/v1/snaps/auth/nonces: net/http: request canceled while waiting
for connection (Client.Timeout exceeded while awaiting headers)

Please file a bug on the juju project: https://bugs.launchpad.net/juju


[SPARK-14750][Spark][UI] Support spark on yarn user refer finished application log in historyServer

What changes were proposed in this pull request?
For spark on yarn, make user can refer application logs while application finished.
How was this patch tested?
manual tests
before：

after

Test build #56520 has started for PR 12570 at commit 80262ef.

Test build #56520 has finished for PR 12570 at commit 80262ef.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class YarnExecutorLogsPage(parent: ExecutorsTab) extends WebUIPage(\"executorLogs\") with Logging

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56520/
Test FAILed.

Merged build finished. Test FAILed.

Test build #56539 has started for PR 12570 at commit 6c84b44.

Test build #56539 has finished for PR 12570 at commit 6c84b44.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56539/
Test FAILed.

From what I can tell you reimplemented LogPage for yarn specifically. Wouldn't it make more sense to extend and surface LogPage for your use case? I've read through your code a bit and it looks like you have some good improvements over certain parts of LogPage but I think creating a completely separate log viewer for yarn is unnecessary and redundant. (Also note my other observations in the Jira.)
@srowen: you were commenting on the Jira, what do you think?

Yes, I think this PR should be closed.

@ajbozarth  oh...I not familiar with standalone... I have no idea about there had a class named LogPage, nice  for you to tell me about that...


When i type any command just show up the quest gui

What is your Quests version / build number (do not say "latest")?
3.6.2
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
When i type any command just show up the quest gui
Does not show anything in console just show quest gui in game
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
Quests.zip

Closing as OP did not follow issue instructions. Use Pastebin.com to post your quests.yml file
Sent with GitHawk


KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

The following actions results in this issue.

handle_1 gets the current log
ReplicaAlterLogDirsThread replaces current log by future log
handle_1 adds the new hw to “current” log but the log is actually invalid

The solution is that the action 1 and 3 must be executed within same read lock of leaderIsrUpdateLock to avoid adding new hw to invalid log (which is replaced by ReplicaAlterLogDirsThread)
Test Plan
Relying on PlaintextAdminIntegrationTest.testAlterReplicaLogDirs. I have looped the test with this patch 100 times. all pass
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

kafka.api.PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords

pass on my local.

@hachikuji @lbradstreet Could you take a look? maybeIncrementLeaderHW was called with holding lock (https://github.com/apache/kafka/commit/f3ded39a0556f9e43a66b238c89c6a60f3ef33df#diff-16590fdbe6661105c6faa87d68e39a553e66b34ee0a6d0b14a48d02e273bab4fL676) and https://github.com/apache/kafka/commit/f3ded39a0556f9e43a66b238c89c6a60f3ef33df changed it.

@junrao Could you take a look? There is no report about this bug in production but we can reproduce the bug by PlaintextAdminIntegrationTest.testAlterReplicaLogDirs. It happens infrequently but it is dangerous as it can misorder the HW.

Are test failures related to this PR?

They are unrelated error. Will rebase PR to trigger QA again.

kafka.api.TransactionsTest.testBumpTransactionalEpoch is traced by #9291
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta and SourceConnectorsIntegrationTest are known flaky

@junrao I will merge it to trunk tomorrow if there is no objection.


az aks browse always prompts for login for AAD/RBAC clusters

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
Using az aks browse on an AAD/RBAC enabled cluster prompts for credentials every time the command is run. kubectl/helm commands for the same cluster do not do this and re-use the access token.
To Reproduce

Setup AAD/RBAC enabled cluster
Run az aks browse -g  -n
Complete authentication (To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code xxx to authenticate.)
Ctrl+C to end the command once proxy is setup
Run again az aks browse -g  -n <mycluster

Expected behavior
The second az aks browse should not prompt for authentication as the token is still valid (and has a refresh token)
Environment summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Shell: bash
azure-cli 2.0.72 *
Additional context

Is there an update on this issue?

Any updates?

Any updates?

@Azure/aks-pm please take a look!

@jluk @robbiezhang


Update README.md

Added a repo that has been excluded from Hacktoberfest2023. It has many new PRs from those who want to contribute to hacktoberfest but come to know about 'Excluded' later on.
Contributing
If you want to add a project to this list, please make sure that:

[x] You read the contributing guide
[ ] The repository has hacktoberfest as topic and counts for hacktoberfest event
[x] The project can't be just an "add your name" or simply + 1 contribution to hacktoberfest
[ ] Place them in alphabetical order
[ ] One repository per PR/contribution - avoid conflicts and simplify review
[x] Your pull request is not spammy just adding an empty line, otherwise it will be marked as invalid and not count to hacktoberfest.

If they meet the requirements above, feel free to create a PR. Happy Hacking! :sparkles:

Adding some more repos.


Add a test for server disconnection

Reproducing of  #631 problem.
@fafhrd91 what should we do in the case?
Any opinions?

in my opinion current behavior is right


I have some questions

Hi,
Sorry if this isn't the right place to ask these questions, I wasn't sure where else.
I'm a Security Installer and I've been looking for a Alarm System which will integrate well into Apple Homekit via Homebridge (or Hoobs in my case).
I was just wondering what exact functionality will this give me exactly? I haven't installed Ness Alarms before so I'm not familiar with their terminology however this is basically what I'm looking to achieve with Homekit via Homebridge in order of priority:

Arm/Disarm the Alarm manually
Notifications for Alarm Events
Automatically Arm the System when nobody on premises (like Geofencing, is this done by Homekit somehow? Never tried an Alarm in Homekit before)
Automatically Disarm the Alarm when somebody arrives
Notifications for System Troubles

I realise this is not all done by the plugin.
I'm just curious how much of the Ness Alarm System is exposed to Homekit via Homebridge and if I would be able to make it work how I've mentioned above.
If only some can be accomplished could you please let me know which ones.
Thanks very much.

Hi,
The plugin interfaces with a Ness D8x/D16X panel to implement the functionality defined by the Apple HomeKit Security System Accessory.
This means it provides:
• Arm/Disarm the Alarm manually

• Notifications for Alarm Events - via Home Automations

• Automatically Arm the System when nobody on premises (like Geofencing, is this done by Homekit somehow? Never tried an Alarm in Homekit before)

	Using Home Automations as per above

• Automatically Disarm the Alarm when somebody arrives

	Using Home Automations as per above

• Notifications for System Troubles

	No interface is provided by Apple Home to act on this (that I’m aware of, although I’ve not investigated or considered this thoroughly)

Let me know if you’d like any more info or explanation ...

On 24 Mar 2021, at 23:04, chipped @.***> wrote:
Hi,
Sorry if this isn't the right place to ask these questions, I wasn't sure where else.
I'm a Security Installer and I've been looking for a Alarm System which will integrate well into Apple Homekit via Homebridge (or Hoobs in my case).
I was just wondering what exact functionality will this give me exactly? I haven't installed Ness Alarms before so I'm not familiar with their terminology however this is basically what I'm looking to achieve with Homekit via Homebridge in order of priority:
• Arm/Disarm the Alarm manually
• Notifications for Alarm Events
• Automatically Arm the System when nobody on premises (like Geofencing, is this done by Homekit somehow? Never tried an Alarm in Homekit before)
• Automatically Disarm the Alarm when somebody arrives
• Notifications for System Troubles
I realise this is not all done by the plugin.
I'm just curious how much of the Ness Alarm System is exposed to Homekit via Homebridge and if I would be able to make it work how I've mentioned above.
If only some can be accomplished could you please let me know which ones.
Thanks very much.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

… and the Trigger automation:

On 24 Mar 2021, at 23:04, chipped @.***> wrote:
Hi,
Sorry if this isn't the right place to ask these questions, I wasn't sure where else.
I'm a Security Installer and I've been looking for a Alarm System which will integrate well into Apple Homekit via Homebridge (or Hoobs in my case).
I was just wondering what exact functionality will this give me exactly? I haven't installed Ness Alarms before so I'm not familiar with their terminology however this is basically what I'm looking to achieve with Homekit via Homebridge in order of priority:
• Arm/Disarm the Alarm manually
• Notifications for Alarm Events
• Automatically Arm the System when nobody on premises (like Geofencing, is this done by Homekit somehow? Never tried an Alarm in Homekit before)
• Automatically Disarm the Alarm when somebody arrives
• Notifications for System Troubles
I realise this is not all done by the plugin.
I'm just curious how much of the Ness Alarm System is exposed to Homekit via Homebridge and if I would be able to make it work how I've mentioned above.
If only some can be accomplished could you please let me know which ones.
Thanks very much.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Feature/slab update

Update slab.

Defaults to white if no extension is given.
Added slab-default as it might be in use.

Codecov Report

Merging #168 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #168   +/-   ##
========================================
  Coverage    91.12%   91.12%
========================================
  Files          126      126
  Lines         2096     2096
========================================
  Hits          1910     1910
  Misses         186      186

Impacted Files
Coverage Δ

src/App/Documentation/components/Slab/index.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a5ca8...2e3a5e3. Read the comment docs.


[Host.AzureServiceBus] Pass ServiceProvider as arg to client factory

Factories for both ServiceBusClient and ServiceBusAdministrationClient exist in Host.AzureServiceBus transport already, but do not pass IServiceProvider to the factory.
I have barely scrathed the surface but it appears to be only stumbling block for integrating with Aspire at this point. Either way, it is a minor change that will improve the flexibility of the factories.

Do we want to keep this issue open for other Aspire aligning work?

I'm going to stop here as integration could not be simpler. If interested, I've thrown up a quick spike to demonstate usage (including distributed tracing).

Ok I will have a look. Perhaps we could link to this from the SMB docs.

I have no objection to that, but please feel free to bring it into your repo (in whole or in pieces). It would probably be better to keep the samples together.
I've only spent about 2 hours looking into Aspire so far, so it may not be the best implementation ...but it works at least, and with minimal effort :)


Replace markdown with pulldown-cmark

The original markdown package is unmaintained [1]. There is apparently a replacement, but it is still in alpha [2]. rustup (from which elan was forked) switched to using pulldown-cmark [3] five years ago.
I am the Debian package maintainer for elan[4] and rust-markdown[5]. I've been asked [6] if elan can please drop the dependency on markdown in order that rust-markdown can be removed from Debian.
This PR is a port of [3a-d] to elan.
N.B. I am not a rust developer, but I have checked that this PR compiles.
[1] https://rustsec.org/advisories/RUSTSEC-2022-0044.html
[2] https://github.com/wooorm/markdown-rs
[3a] https://github.com/rust-lang/rustup/pull/2009
[3b] https://github.com/rust-lang/rustup/pull/3071
[3c] https://github.com/rust-lang/rustup/pull/3662
[3d] https://github.com/rust-lang/rustup/pull/3838
[4] https://packages.debian.org/sid/elan
[5] https://packages.debian.org/source/sid/rust-markdown
[6] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040514#25

Thanks! Unfortunately, the line wrapping and indentation is a bit wonky with this change.
export ELAN_INIT_SKIP_PATH_CHECK=yes; (curl https://raw.githubusercontent.com/leanprover/elan/master/elan-init.sh -sSf | sh)
info: downloading installer

Welcome to Lean!

This will download and install Elan, a tool for managing different Lean
versions used in packages you create or download. It will also install a
default version of Lean and its package manager, lake, for editing files not
belonging to any package.

It will add the lake, lean, and elan commands to Elan's bin directory, located
at:

  /home/sebastian/.elan/bin

This path will then be added to your PATH environment variable by modifying the
profile files located at:

  /home/sebastian/.profile
  /home/sebastian/.zprofile

You can uninstall at any time with elan self uninstall and these changes will
be reverted.

Current installation options:

     default toolchain: stable
  modify PATH variable: yes

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
^C
$ ELAN_INIT_SKIP_PATH_CHECK=yes ./elan-init

Welcome to Lean!

This will download and install Elan, a tool for managing different Lean
versions used in
packages you create or download. It will also install a default version of Lean
and its package
manager, lake, for editing files not belonging to any package.

It will add the lake, lean, and elan commands to
Elan's bin directory, located at:

  /home/sebastian/.elan/bin

This path will then be added to your PATH environment variable by
modifying the profile files located at:

  /home/sebastian/.profile
/home/sebastian/.zprofile

You can uninstall at any time with elan self uninstall and
these changes will be reverted.

Current installation options:

     default toolchain: stable
  modify PATH variable: yes

1) Proceed with installation (default)
2) Customize installation
3) Cancel installation
^C


Are ObjectURLs a problem?

The proposal includes the ability to turn a module block into a blob URL for backwards compatibility
const m = module { /* ... */ };
const url = URL.createObjectURL(m);
CSS.paintWorklet.addModule(url);

url would be something like blob:https://domain.com/066985ec-eff1-4a58-8654-d3f37edb16dc.

Is Blob lifetime sufficiently defined for this to work?
Despite the blob: schema, can the module still inherit the import.meta.url of the embedder?

FWIW, they are as they can cause memory leaks. You should instead make the relevant APIs accept objects instead.

I agree that I shoulld make the relevant APIs accept Module Blocks, but we know that reality is different were some APIs will not have been updated but Module Blocks will have been shipped.
The whole point of supporting ObjectURLs is to allow those APIs to be used with module blocks.
If an ObjectURL causes a memory leak, isn’t that an implementation bug?

No, it's kind of inherent to the design. (And we'd rather not have web pages leak memory, even if they're buggy.)
I think it should be doable to ensure everything you want to see updated be updated before you ship. That's a matter of enumeration and ensuring all the specifications are updated and have tests and someone tracking all the relevant boxes are ticked off.

I wonder if:

Ship module { syntax.
Ship feature that makes it work with createObjectURL.
Modify all URL-accepting APIs so they know what to do with those URLs.

…is much different to:

Ship module { syntax.
Modify all module-accepting APIs so they accept those modules.

Especially when it comes to stuff like making import.meta do the right thing.
Also, the createObjectURL feature kinda clashes with this from the README:

Module blocks are only imported through dynamic import(), and not through import statements, as there is no way to address them as a specifier string.

createObjectURL would create a way to address them as a specifier string.

I talked to Dan and he agrees with y’all as well. I guess it is on me that no API gets forgotten at the integration with HTML :D
Should we drop createObjectURL support altogether then? I don’t think it’s essential for this proposal, and if they are considered leaky/bad, it might be better to not allow it at all?

createObjectURL would create a way to address them as a specifier string.

Not really, as that URL would be created at runtime so you have no way of getting it into a static import, outside of eval() et al.

Yeah, I think it should be dropped. We should probably clarify https://w3c.github.io/FileAPI/#creating-revoking at some point that it's not be extended further. (We already inlined the only two objects allowed, but didn't add a warning at the time.)
cc @mkruisselbrink

@surma

Not really, as that URL would be created at runtime so you have no way of getting it into a static import, outside of eval() et al.

You could:
const url = URL.createObjectURL(module { export default 'yo' });
document.head.insertAdjacentHTML('beforeend', `<script type="module" src="blah?import=${url}">`);

…which returns a static import for url.


change old GNU keyword real imag to CREAL, CIMAG macro

Hi,
Most file use the macro defined in common.h, but i guess cdot.c and zdot.c missed the memo ^_^ .
Best,
Min Dong

Just for the record I do not think now that this will work as is across all platforms, as in some cases the CREAL will expand to a macro or function rather than the keyword - which is illegal on the lefthand side.

Thank you for highlighting this problem (and eventually leading me in the right direction, I hope) all the same. It's a pity that your contribution apparently was not looked at for so long.

Hi, sorry if the deletion seems to be odd. I just come to understand that
my understanding was not complete, thanks for your explanation.
On Tue, Mar 14, 2017 at 12:02 PM Martin Kroeker<EMAIL_ADDRESS>wrote:

Thank you for highlighting this problem (and eventually leading me in the
right direction, I hope) all the same. It's a pity that your contribution
apparently was not looked at for so long.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/xianyi/OpenBLAS/pull/916#issuecomment-286469054, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABe3qaUSye2joWI0Fq1x9HBRgIUsvW7Nks5rlroagaJpZM4I-IMp
.


React: Masthead L0 grouped typeahead results enhancement Design PR review

User Story

As a [user role below]:
DDS Designer and Developer

I need to:
test the Masthead L0

so that I can:
be sure the developer's code correctly works as designed

Additional Information

See the Epic for the Design and Functional specs information
See comments posted by the engineer for testing links
Creating a QA bug
React Dev Issue (#4845 )

Tasks
Ensure the Masthead L0 component has been tested and reviewed by design + dev.
Acceptance criteria

[ ] Pattern is reviewed by designer and design defects are identified
[ ] New issues are opened to log individual defects
[ ] Screenshots of as-is and to-be design should be added to the issue when needed
[ ] Developer associated with building the pattern is assigned to the new issues
[ ] Appropriate labels are added to the issue  eg.  bug, dev

Based on Kenny's and Jenny's participation in the KC design and engineering meetings: The features needed are customized to the KC platform and are not something that we would ever add to the carbon for ibm.com code base.


Canceling Copy/Moving dont work

Describe the bug
Canceling Copy/Moving file operation from "Ongoing Task Menu" dont work, and continues even then Files app closed.
To Reproduce
Steps to reproduce the behavior:

Copy/Move any file
Click "X" in the ongoing task menu
You will see that current task in menu is close, but copy/move files operation continues. Closing Files app also dont canceling operations.

Expected behavior
Fix canceling copy/move files operations
Screenshots
nothing to shot sorry
Desktop (please complete the following information):

OS Version: Windows 10 20H1 19042.685
App version: v1.0

Additional context
Add any other context about the problem here. Does this problem occur again after restarting the app?
Yes
Log file
debug.txt
debug_fulltrust.txt

@duke7553 The "X" button is currently just a button to dismiss the item in the status center, what are your thoughts about repurposing the button to cancel the operation?

@duke7553 The "X" button is currently just a button to dismiss the item in the status center, what are your thoughts about repurposing the button to cancel the operation?

@yaichenbaum Congrats with 1.0 version!
Cant even imagine, i dont have UI/UX design exp. Need to be Stop and Cancel buttom, like native windows explorer transfering files dialog.
Also please, take a look what about percantage status meter in the ongoing task menu, it is dont work.

@yaichenbaum Congrats with 1.0 version!
Cant even imagine, i dont have UI/UX design exp. Need to be Stop and Cancel buttom, like native windows explorer transfering files dialog.
Also please, take a look what about percantage status meter in the ongoing task menu, it is dont work.

This issue should be resolved in main.


Display first shot counts

While it is great that the count for full vaccinations are displayed, it may be helpful for users to also know how many people have received only one dose.
The fix to this will involve modifying the API at https://github.com/njyjn/sg-vaccine-tracker/blob/3e3ff768033726a5b7d31409b9fa843681b2ec57/api/src/logic/count.ts#L40 to support the scraping for the Received at least First Dose DOM element, storing it in DynamoDB under a new type, and adding the associated text in the client UI.

Mocking test getHtmlContent.test.ts has been added, please modify the test accordingly as this feature is added.
Running npm test will help validate

Resolved


Add init_app() method to DebugPanel base class

Adds a method DebugPanel.init_app() that gets called from DebugToolbar.init_app().
This allows DebugPanels to register their own routes, and do setup work that should go across requests (as opposed to per-request setup) and needs access to the Flask app-object.

I know it's been a long time, but do you still have any interest in this?
If so, it will need to catch it up with master and retest. If not, we'll probably close it out.

@macnewbold Thank you for the flag. I've rebased on latest master now


Add some creative french dirties

Let's talk dirty!

@Treydone  I imported this to our DoltHub bad-words repository, and included your changes. DoltHub is GitHub for Dolt. You can see your additions in this commit, which I submitted in a PR.


Rescan buttons added to toolbar

Closes #15
I decided against rescanning on startup option (see comment: https://github.com/whyboris/Video-Hub-App/issues/15#issuecomment-515683230)
Instead, simply allow users to add two of the rescan buttons to the toolbar ✅
This should handle 99% of the use cases without any added complexity & unexpected behavior.
While some users might really prefer a rescan on startup, I think needing to click 1 more button after starting the app is a small-enough hassle to avoid the potential headaches for most other users.
ps - obviously two new icons will be added before 2.0.0 release 👍

Much simpler handling too! 👍


Can DPOTrainer support inputting encoded token IDs

Feature request
Can DPOTrainer support inputting encoded token IDs to customize the calculation of different attention masks, such as excluding the prompt part from loss computation? For example:
model_inputs['prompt_input_ids'] = prompt_input_ids
model_inputs['prompt_attention_mask'] = [torch.ones_like(input_ids) for input_ids in prompt_input_ids]
model_inputs['chosen_input_ids'] = chosen_input_ids
model_inputs['chosen_attention_mask'] = [torch.ones_like(input_ids) for input_ids in chosen_input_ids]
model_inputs['rejected_input_ids'] = rejected_input_ids
model_inputs['rejected_attention_mask'] = [torch.ones_like(input_ids) for input_ids in rejected_input_ids]

Currently it seems to only support text input before encoding
model_inputs['prompt'] = prompt
model_inputs['chosen'] = chosen
model_inputs['rejected'] = rejected

Motivation
excluding the prompt part from loss computation
or
customizing the length of intercepted prompt and message inputs
Your contribution
none

Can DPOTrainer support inputting encoded token IDs to customize the calculation of different attention masks

No, and won't be supported, unless we are provided with a good reason to support it.

excluding the prompt part from loss computation?

Actually, it's how dpo works by default. See
https://github.com/huggingface/trl/blob/b80c1a6fb8754c578f7178213e56d780abbe96d5/trl/trainer/dpo_trainer.py#L1089-L1091

@qgallouedec Thank you for your response


Removes unnecessary blank line in the Security section

Seems like GitHub has formatting issues when you include both - characters and * characters in the same bulleted list, so I replaced all of the * in that section to - and removed the blank line to remove the formatting issue.
Screenshot of the formatting issue:

done. thank you!


Add missing 18n calls and document failures

All user-facing messages need to be wrapped in the __ calls located in src/ui/i18n.
Additionally, some user-facing messages may not be wrappable due to embedded HTML or other issues. When identified, a comment containing the string i18nfailure should be added for tracking purposes.

These are tags Madiator reports are not translating (need to add tags?)
  "Top": "Top",
  "New": "Nowe",
  "Dark": "Ciemny",
  "Light": "Jasny",
  "dark": "ciemny",
  "light": "jasny",
  "Enter a LBRY URL here or search for videos, music, games and more": "Wprowadź tutaj adres URL LBRY lub wyszukaj filmy wideo, muzykę, gry i wiele więcej",


Array value in my compute kernel function

Hello!
i need to pass in my kernel function array of simd_float3x2 values
example kernel function
kernel void myKernel(texture2d<float, access::sample> colorTexture [[ texture(0) ]]
                                     constant array<simd_float3x2, 5> &values [[buffer(0)]]){ }
example my kernel params
{"values":[MTIVector vectorWithArrayValues] // for example }
it is not supported at the moment. Perhaps this can be done with existing functions. But until I figured out how to do it. I will be very grateful for the advice. thanks!

@alyfreym I think you can directly wrap the bytes in a NSData or MTIDataBuffer.


SW-5423 Implemented deletePhoto and DELETE endpoint

#2012  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

May 30, 5:19 PM EDT: @tommylau523 merged this pull request with Graphite.


[core-http] undo change to pass keepAlive to clone()

PR #5047 fixed the issue where proxySettings and keepAlive are not passed to
the clone. However, this change surfaced a new issue where we always create new
agents (proxy agent or keepAlive agent) when sending requests. In the keepAlive
case it leads to increased memory usage since GC cannot recycle agents until
timeout expires.
This is a temporary workaround for the memory leak issue. We need a proper
design to fix the root issue.

Logged a new issue to track the more proper fix: https://github.com/Azure/azure-sdk-for-js/issues/5398

Will we still have an possible issue by leaving in the proxySettings parameter, or do we only leak because of the timeout of the keep-alive agent?

I suspect the latter.  Will run a test quickly to test.

Yes for the proxySettings case I can see GC working (during loops memory usage fall back to almost the same as the beginning).

Awesome, thanks a lot for checking!


Switching between the weeks

When we pick from Days X Y and Z, it immediately goes to the next slide.
I think this is a small problem because the players might not realize that they're already on a different week, which might result in clicking more than once and skipping a week.
We might be able to change this by adding a pause between the weeks, or adding effects that makes it more obvious to players that they're on another week.

We have finished working on this issue for now.
We added a loading screen to make sure that users can't accidentally double-click a day.
Please open up this issue again if there are still changes you feel need to made.


Disable seccomp for Github Actions

Thank you for your contribution and for fixing our CI @fweimer-rh!


Syntax Highlighting is a bit off

Hi,
I suspect the syntax highlighting isn't accounting for newlines and spacing between keywords (or something like that). See sample image below of what's going wrong.

This extension is looking awesome by the way! Very much looking forward to being able to switch away from emacs.
Ed

Also, as usual, I'm working on Windows. I hope this isn't a "\n" vs "\r\n" problem!

Okay I changed the Line Ending Mode in VSCode to just LF and the syntax highlighting worked fine - so this is a \r\n vs \n issue.

Here's a simpler sample for you.
module Handle
  (Identifier : Set)
  where

open import Data.Maybe
  using ( Maybe
        ; just
        )

Handle = Maybe Identifier

Note that if you do c-shift-p and search for Change End of Line Sequence you can test Windows line endings on Linux (and vice-versa).

Line endings again! need to end this kind of problem for good
Thanks for reporting this!

Should be fixed in v0.0.8

Regarding the fix: Relying on the OS name seems like a really bad idea. Surely it would be better to just ask VSCode what the line ending mode of the current file is? That would make it work for any file regardless of the OS or whatever Git config someone may be using.

Yes, I actually thought about using line endings, and that's how it should be done.
I planned to port the fix to Atom (through a common editor API interface), but I cannot find any method regarding line endings on the Atom API, so it ended up this way.
I should leave this issue open until it's fixed properly


CI: enabled ruby workflow

Goal
Use GitHub Actions ruby workflow for CI testing.
Approach

Use default ruby workflow.
Remove Travis CI integration.

Coverage remained the same at 100.0% when pulling 881f55df41b197d3b940b171946227771cdcaa70 on ruby-workflow into e7ad59d432ebd76087707fc2bf7e439095e4a6f6 on master.


I can't add the account to the team.

I use Tweetdeck and would like to add accounts when managing multiple accounts. Is it inevitable to be redirected to the twitter.com URL and see "Rate limit exceeded"? X has an account delegation feature instead of the team feature.

i dont know how to fix it. dont open duplicate issues


Wrong explanation of @lry

In the guidelines it says
@lry: indicates the lower-left corner x coordinate
but it must be lower right-corner y coordinate

Yes, well spotted! Obviously a usual copy and paste error.


Provide mechanism for writing comments to NRRD files

See example for the NRRD file here:
http://teem.sourceforge.net/nrrd/format.html#content
Hans

Thanks. I have changed my name and pictures in Github.


Could this be extended to allow user session capture?

@JohnnyCurran I've discovered this recently while looking for session replay functionality for user testing (not debugging, as this lib seems to be intended).
Have you considered extending this to capture events without the browser plugin? And to allow replay / live viewing of a session? Similar to wha tools like posthog.com do, but without sending data out to 3rd parties.
Or, if I wanted to attempt extending this, do you think the current implementation is compatible with that concept or not?

Hi @alexslade ,
Sorry for the delay, this got buried under my other GH notifications
Obviously the biggest drawback to the Telemetry approach is going to be that you're unable to capture purely client-side events. That said, thinking about it, those are mostly limited to "show/hide a DOM element". Anything that updates client state is going to end up invoking some sort of update/handle_event/handle_info, etc.
You can see all of the telemetry events that LiveView emits here https://hexdocs.pm/phoenix_live_view/telemetry.html
You could absolutely extend this library to try and do what you need to do. You'll probably want to have a Live Hook that puts a random live session id into LiveView sessions where users are not logged in:
|> put_session(:live_socket_id, "users_socket:#{user.id}")

You may find it easier to create your own repo with this as a reference, too.  Really the interesting bits are all in here: https://github.com/JohnnyCurran/TimeTravel/blob/main/lib/telemetry_handler.ex
How you store the assigns would be very interesting, too. You could consider using :erlang.term_to_binary but that does have some security implications.
Best of luck to you and if you do decide to use Telemetry for session tracking I'd like to hear how you progress with it!


SQFormStepper requires every field to be filled to enable Next/Submit button

While working with SQFormStepper, I came across an issue where the next button was not getting enabled even all the required fields are filled. The stepper required every field to be filled in order to proceed further.
Here are my few findings regarding the issue: https://www.loom.com/share/347b61155d5f47cd8a4321467678e4f0

:3 Well I worked on it a bit and found the solution as well.
https://www.loom.com/share/6c2580b175de4a24afdcdc995202f0ec


Add is_group attribute to powercalc groups

This makes it easier to include / exclude these from template sensors

Resolved with #410


Fixed TypeScript bindings for nonshrink

changed typescript bindings to correct nonShrink to nonshrink, tests demonstrating them from within typescript are included

It's not clear to me what is actually failing on this build. When I look at the travisCI output it looks like all of the tests are passing. The only things that look like they are failing is that mocha is under versioned, as well as something about 'david'. Any idea what that is?

So it looks like david was the one complaining about mocha. I've updated the version to what david requested. We'll see if travis passes the build.

Thanks!

:v:


fix broken %~ parse specifier

the ~h option to parse XFF headers conflicted with the %~ option and
made it non-working
I was trying to parse a Squid logfile in native format (see attached log), which uses a variable number of spaces before the field for processing time. With the current goaccess v1.2 release, the %~ is not working (with v1.1 neither; more I did not check), because the code enters that path for parsing the XFF header (which obviously fails) upon encountering a ~. This PR should fix the behavior by checking if a % has been encountered before, in which case the 'blank eater' should be executed.
 Thanks for spotting this and submitting this PR!


CMS Tab Display Issue

https://github.com/silverstripe/silverstripe-framework/commit/6d9d53059c59aac8a866829e89926ba099f8b716#diff-c0701ff7c01adc103127bf454dc65f47R396

Fixed in 3.3 in https://github.com/silverstripe/silverstripe-framework/pull/5208, where the decision was made not to fix in 3.1 (as it’s minor, and would probably cause merging headaches)


Flatpak UI not scaled correctly on KDE+Wayland

it seems like the GUI in the flatpak doesn't like KDE display scaling settings
installed the flatpak from flatpak install --user https://dl.flathub.org/build-repo/72997/com.quexten.Goldwarden.flatpakref
Screens
=======
Active screen follows mouse:  yes
Number of Screens: 3

Screen 0:
---------
Name: DP-1
Enabled: 1
Geometry: 2932,677,2048x864
Scale: 1.25
Refresh Rate: 74991
Adaptive Sync: automatic
Screen 1:
---------
Name: DP-2
Enabled: 1
Geometry: 0,0,1396x785
Scale: 2.75
Refresh Rate: 120000
Adaptive Sync: always
Screen 2:
---------
Name: HDMI-A-2
Enabled: 1
Geometry: 1396,355,1536x864
Scale: 1.25
Refresh Rate: 74973
Adaptive Sync: automatic

Operating System: Garuda Linux
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.11
Kernel Version: 6.6.8-1-cachyos (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 5600X 6-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: AMD Radeon RX 6700 XT

Thanks for the report, will attempt to reproduce in a VM in a bit. From your display information, am I reading correctly that you are using fractional scaling?

Yup one of the reasons why I using Wayland. and I have diffrent scalling for some monitors
but I am running the app on DP-1 so 1.25 scale

Seems like this is an issue with XWayland+KDE. On XOrg the app works fine at any scale. On Wayland (non-Flatpak), it also works at any scale. On Flatpak, it seems to fall back to XWayland, and thus the scale is completely messed up. I'm not entirely sure yet what's missing for it to be able to use Wayland directly, but it's most likely just some permissions.

@zany130 ok, seems I tracked it down - at least on Kubuntu. The reason is a bug in the kde xdg desktop portal. To fix, set: /usr/share/xdg-desktop-portal/kde-portals.conf
to:
[preferred]
default=kde
org.freedesktop.impl.portal.Settings=kde;gtk;

Can you check if this works on your system too?
https://github.com/flatpak/xdg-desktop-portal/issues/1112#issuecomment-1733683797

nope, no luck. I already had that set (i think I had an issue with Flatpak apps not using my cursor, so I set it then)
I tried forcing the app to run with xwayland ( it was running under Wayland) by removing the Wayland flatpack permission and that actually fixed the scaling for me

I tried forcing the app to run with xwayland ( it was running under Wayland) by removing the Wayland flatpack permission and that actually fixed the scaling for me

Yeah, XWayland also avoids the issue. On my fixing attempt, I also rebooted inbetween, but from a clean Kubuntu system, that's all that was required for me. Either way, not a bug directly in Goldwarden. Eitherway, seems more like a bug with an upstream dependency (whether the kde portal, or gtk itself).

I tried forcing the app to run with xwayland ( it was running under Wayland) by removing the Wayland flatpack permission and that actually fixed the scaling for me

Do you have some instructions on this I could note on the wiki? Did you just build without the Wayland permission, or is there some command line parameter to block permissions (I didn't find anything like this in my brief search on the flatpak wiki).

For the last sync date, that's actually quite funny. It should say "never" but due to the timezone, the date does not start with 1970, so the detection of "no date" (being 0 in unix time, i.e 1970-01-01) fails. I'll fix that soon.

Do you have some instructions on this I could note on the wiki? Did you just build without the Wayland permission, or is there some command line parameter to block permissions (I didn't find anything like this in my brief search on the flatpak wiki).

I just used  kde built-in flatpak permission settings tool. Flatseal should also do the same thing

prob a way to also do it from the terminal. IDK if you can ship the flatpak with that forcibly disabled, but personal I think it may be better to add a note in the readme or something and let the user deal with that?

Guess this can be closed btw since its more of a upstream problem

I linked your comment in the Wiki now https://github.com/quexten/goldwarden/wiki/Flatpak-Configuration , thanks again!

fixed by installing the gtk portal https://wiki.archlinux.org/title/XDG_Desktop_Portal#Poor_font_rendering_in_GTK_apps_on_KDE_Plasma
maybe add a note on the wiki for this? @quexten