U turn support

Which area of IMT is your request about?  (ex:  Lines, Fillers, UI)
Describe your idea clearly and concisely.
A way to mark u-turns using IMT, possibly a u-turn mode and a straight line mode with a button to switch between them
Screenshots?
Provide a visual if possible what your idea would look like

Why would this idea be a good addition to IMT?
Add any other context or screenshots about the feature request here.
U-turns are kinda common and afaik there is no way to mark them

this is a duplicate of https://github.com/MacSergey/NodeMarkup/issues/296#issue-1079992215


Method access modifiers

function cleanUrl() is without defined access type (public, protected, ...)
I found next many functions with same issue.

You are right, this needs to be fixed

this has been fixed


Check external TxID is URL segment safe with server code

Current SDK code does not check percent encoding correctly


Golang Test

hi,
i need to add some arguments to a test command, how can i do that?
i.e go test -gcflags=all=-l -short ./...

This works for me. If you need a different tool change gotest with yours
let test#go#gotest#options = '-tags=dynamic'

hi @r-ghilardi thanks for the reply but i need the args which need to be the last, any idea on how to do that?


RStudio Initialization Errors/ Unable to Connect to Service

I've been getting these bugs lately, does anyone know how we would suggest debugging a build ?

nbrsessionproxy launches rserver --www-port=some_unused_port then proxies that web service on /rstudio. If you want to debug you could try picking some unused port, drop to a jupyter terminal, and run rserver --www-port=your_port. If rserver starts correctly, open a new tab on your notebook server with proxy/your_port/ appended, e.g. https://hub.mybinder.org/user/somebinderuser/proxy/your_port/.
One binder-specific debug trick I use is to run cat /proc/1/fd/2 in a jupyter terminal so I can see notebook's stderr.

nbrsessionproxy has been rewritten (and renamed to jupyter-rserver-proxy) several times, so I'm going to close this one for now. Please re-open if you run into this again!


Dashes in command names break completion scripts

Dashes aren't valid variable identifier characters for Zsh (~and maybe Bash~ just Zsh). When building a completion script for a command that includes one or more dashes in the command name, the completion script prints errors instead of providing completions.
ArgumentParser version: main branch
Swift version: Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1<IP_ADDRESS>)
Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Steps to Reproduce
Create a CLI tool with a dash in the command name, then generate and install a Zsh completion script for the command.
Command:
struct ExampleCommand: ParsableCommand {
  @Option var name: String
  @Flag var verbose = false
}

Script:
#compdef example-command
local context state state_descr line
_example-command_commandname=$words[1]
typeset -A opt_args

_example-command() {
    integer ret=1
    local -a args
    args+=(
        '--name:name:'
        '--verbose'
        '(-h --help)'{-h,--help}'[Print help information.]'
    )
    _arguments -w -s -S $args[@] && ret=0

    return ret
}

_custom_completion() {
    local completions=("${(@f)$($*)}")
    _describe '' completions
}

_example-command

Expected behavior
Typing example-command and then TAB should offer completions.
Actual behavior
The shell prints _example-command:3: command not found: _example-command_commandname=example-command.

Is this a problem with the ZshCompletionsGenerator or Parsing itself? I am having trouble finding exactly where the problem arises from, would appreciate any help. Thanks.

It's in the completions generator — specifically line 3 called out above, which creates a variable called _example-command_commandname. I think just changing any dashes in that variable name to underscores would do the trick.


Feature Proposal - Encrypt local config

Background:
Right now the file "KeeAnywhere.Accounts.json" is not protected at all (Windows Control Access is easy to overcome), yet it contains sensitive, unencrypted tokens that allows anyone to access all files on the Remote Drive (Google Drive, Dropbox, etc).
Proposal:

KeeAnywhere should encrypt the "KeeAnywhere.Accounts.json" file at account creation with a user password (different than the one to the KeePass database)
require a user password to provide the password at program start.
There should be a feature flag for that

It would feel like a better time investment to support this scenario than to implement a parallel encryption system which will inevitably be less mature and less secure than Keepass itself.

You may be right, but the users should be notified when the flow I'd described is used.

Actually, the json Secret field is encrypted. It just might not look like it. Here's where the encryption actually happens; it uses an OS-provided encryption/decryption API, meaning the decryption key for the secret is not stored in accounts.json, keepass.xml, or the plugin.


Known FWTS issues.

List known FWTS issues in this ticket (e.g. ACPI related ones).

 It seems that the table was not checked (probably as it does not exist). What do you think should be fixed?

@xiaobo55x Your test output was: esrt=skip. It seems that the table was not checked (probably as it does not exist). What do you think should be fixed?

@xypron The root cause was that most of the ACPI tables was not available and it can be fixed by adding the missing tables in Qemu on a virt riscv machine. You can refer to riscv-acpi for the required RISC-V ACPI tables.

results.log
@xypron Here comes the raw FWTS results log for your reference.

I have opened LP #2026305  ("Upgrade to ACPI 6.5")

Hi @xypron, we are planning to enable RISC-V support for FWTS. Could you share more info about how to submit a patch to FWTS project?

@xiaobo55x
https://wiki.ubuntu.com/FirmwareTestSuite has an overview of the development process.
The fwts project uses a mailing list for patches. Please, register at https://lists.ubuntu.com/mailman/listinfo/fwts-devel . You can turn off notifications afterwards.

Sure, Thanks!

LP #2026305  ("Upgrade to ACPI 6.5")

Patch https://lists.ubuntu.com/archives/fwts-devel/2023-July/013679.html adds ACPI 6.5 to fwts. This should fix the incorrect warning.


bin: replace .option with .command

fixes: https://github.com/pkgjs/wiby/issues/7

[x] At least 1 approval from package-maintenance members other than the author of the PR, unless there is single maintainer for the repository. In that case the single maintainer can land their own PRs.
[x] No blocking reviews
[ ] 72 hours since the PR was openened

:tada: This PR is included in version 0.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Ctrl+Shift+H (replace in files) should auto-reveal the replace field

The shortcut CTRL+SHIFT+H (replace in files), should reveal the replace field, normally hidden with search.

It should do that. Does it not do that for you? Could the keybinding be overridden?

Yes, sorry -- it was Activitus Bar that was breaking it!


Correct scaling up logic

It looks like the scale up logic is incorrect. We currently scale if even if there is an agent that is free but has yet to pick the job off the queue.
We inject metrics every 15 seconds by default into cloudwatch as per:
https://github.com/buildkite/buildkite-cloudwatch-metrics-publisher/blob/master/templates/cloudformation.yml#L45
Having an alarm of maximum over that 60 seconds will always trigger an alarm and a scale up event.
What this will mean is that agents will spin up to max-agent size quickly even though those agents are in fact idle.
Changing the scale up to minimum will mean that we will only scale up if there is a scheduled job that hasnt been picked up by an agent because the agent is busy doing other builds.

@tnh I am testing this in my stack will see if it scales better.

The aforementioned in the cloudwatch metrics for last Wednesday using the out-of-the-box metrics with the out-of-the-box buildkite metrics agent + stack.
Our scaling is
+1 scale up, -1 for scale down. Min agents 0, Max agents 10.

Yup, fair point, it does seem like it's incorrect to me.

Hmmm... I was seeing 2 agents always spinning up :/

What scaling increment @stramel?

Here is a quick update for Irexchange - we're scaling a little better and not spinning up agents that dont get used.

@lox I was trying the minimum that @tnh suggested.

bumb

I don't object to merging this in, @sj26 @toolmantim ?

Thanks for the pull request, explanation and awesome graphs. Makes it MUCH easier to reason about.
So there's one situation I have a question about… for the case of starting with 0 agents and waiting for the first one, instead of waiting 15 seconds this would require then to wait 60 seconds yeah? Because scheduled count needs to be a non-zero number for a full minute for a scale up to occur?
If this is the case, I don't know if it's be a deal breaker, but it would add another 45 worrying seconds to an already quite long first-start time. But maybe there's another solution to that problem, whilst keeping this much more sane scaling behavior.

Either way, I think this is probably a good thing to add. An extra 45 seconds on initial boot probably won't even be noticed, and is worth it for a probably large reduction in EC2 instance bill.

Alright, let's go with that. And we can try to optimise the "time to first instance" afterwards.


[ROCm] Adding macro GPU_DYNAMIC_SHARED_MEM_DECL

Add the macro so that gpu kernels can use dynamic shared memory. Dependent kernels includes:

depthwise_conv_op
bias_op
concat_lib
split_lib
bucketsize_op

@tatianashp @whchung @chsigg

@jerryin this seems to be a duplicate of PR #29095 .  please close this one out

@jerryyin this seems to be a duplicate of PR #29095 . please close this one out

Ha, thanks for point out. I thought there should be one, but didn't try hard enough.


Missing SQL 2022 on table for section Using SQL Server Side-By-Side with Previous Versions of SQL Server

[Enter feedback here]
On this section Using SQL Server Side-By-Side with Previous Versions of SQL Server, all SQL server are detailed but not SQL Server 2022.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6c5b2d5d-0a6b-46e2-cb87-be75e37c538f
Version Independent ID: 66e80689-5e06-fd53-bfdd-75058533df10
Content: Work with multiple versions and instances - SQL Server
Content Source: docs/sql-server/install/work-with-multiple-versions-and-instances-of-sql-server.md
Service: sql
Sub-service: install
GitHub Login: @rwestMSFT
Microsoft Alias: randolphwest

@iggonzalezMS Thanks, we'll have a refreshed article published in the next day or so.


Backward pass issue when there is implicit broadcasting in add

Describe the bug
You can reproduce this on crates.io 0.5, but it should also be reproducible on master.
To replicate the bug, try the following program
use burn::tensor::Distribution;
use burn::tensor::Tensor;
use burn_autodiff::ADBackendDecorator;
use burn_ndarray::NdArrayBackend;

type BackendAlias = NdArrayBackend<f32>;
type ADBackendAlias = ADBackendDecorator<BackendAlias>;

pub fn main() {
    let x: Tensor<ADBackendAlias, 2> = Tensor::random([2, 3], Distribution::Standard);
    let label: Tensor<ADBackendAlias, 2> = Tensor::random([2, 1], Distribution::Standard);

    let weights: Tensor<ADBackendAlias, 2> = Tensor::random([3, 1], Distribution::Standard);
    let bias: Tensor<ADBackendAlias, 2> = Tensor::random([1, 3], Distribution::Standard);

    let y = x.matmul(&weights).add(&bias);
    let loss = y.sub(&label).powf(2.0).sum();

    println!("y shape = {:?}", y.shape());
    println!("{:?}", loss.inner());
    let gradients = loss.backward();
    let weights_grad = weights.grad(&gradients);
    let bias_grad = bias.grad(&gradients);
    println!("{:?}\n{:?}", weights_grad, bias_grad);

}

When you run this, the forward pass works (it prints the shape of y and the value of the loss), but the backward pass produces a runtime error generating the error:
Tensor { value: NdArrayTensor { array: [15.016455], shape=[1], strides=[1], layout=CFcf (0xf), dynamic ndim=1 } }
thread 'main' panicked at 'ndarray: inputs 2 × 3 and 1 × 3 are not compatible for matrix multiplication', <path_omitted>/.cargo/registry/src/github.com-1ecc6299db9ec823/ndarray-0.15.6/src/linalg/impl_linalg.rs:299:5

Expected behavior
The expected behavior is if a forward pass is valid and runs without runtime error, a backward pass should also run without a runtime error.
Additional context
Note that this is not a typical model definition. This looks like an affine function, but it's actually a little different with an unexpected implicit broadcast in the add operation.
That is, for a proper Affine function, we should expect the bias term to have shape [1, 1] (or be reshaped to that). Instead, it has shape [1, 3]
This means the add operation in x.matmul(&weights).add(&bias) is adding tensors with shapes [2, 1] and shapes [1, 3] which produces a tensor with shape [2, 3] by implicitly broadcasting the first tensor along the second dimension to size 3, and implicitly broadcasting the second tensor along the first dimension to size 2.
Based on the error, I believe the issue is the backward pass is trying to push the head gradient of the add (with shape [2, 3]) onto the input with shape [1, 3], but the backward pass for add is not account for the fact that the broadcast could have happened. I think it would effectively have to inject a broadcast operation implicitly inside itself first and then the autodiff should work.

Here is a better example that narrows down the problem
use burn::tensor::Distribution;
use burn::tensor::Tensor;
use burn_autodiff::ADBackendDecorator;
use burn_ndarray::NdArrayBackend;

type BackendAlias = NdArrayBackend<f32>;
type ADBackendAlias = ADBackendDecorator<BackendAlias>;

pub fn main() {
    let x: Tensor<ADBackendAlias, 2> = Tensor::random([2, 1], Distribution::Standard);
    let y: Tensor<ADBackendAlias, 2> = Tensor::random([1, 3], Distribution::Standard);
    let z = x.add(&y);
    println!("{:?}", z.inner());
    let grads = z.backward();
    let x_grad = x.grad(&grads).unwrap();
    println!("{:?}, {:?}", x.shape(), x_grad.shape()); // Outputs: Shape { dims: [2, 1] }, Shape { dims: [2, 3] }
    assert!(x_grad.shape() == x.shape()); // FAILS
}

What this shows is when the add operation broadcasts, the gradients on the arguments do not have the right shape. The above program shows that because we see the gradient it computes on x has a different shape than the actual tensor x.

@nathanielsimard when you have a chance, lets triage this bug. We need to understand its impact on users and severity. Maybe this bug does not exist because of your recent changes and fixes.

@jmacglashan, @nathanielsimard has fixed the bug. If you have a chance, can you please confirm the fix is complete?


JAR-file?

Is this matcher and grpc extension for nodes v1.0.0, v1.0.1. v1.0.2??
Is there any JAR-file? Why this not working on new versions of nodes?

Is this matcher and grpc extension for nodes v1.0.0, v1.0.1. v1.0.2??
That's true for matcher.

Which gRPC extension?

If you meant grpc-server, it should. Please refer to https://github.com/wavesplatform/Waves/issues for more information about grpc-server.
We have own gRPC extension, it is still in development

Is there any JAR-file?
There ara DEB and TGZ artifacts. More information here: https://github.com/wavesplatform/dex#6-installing-and-running

Hello. I see matcher is working for node v0.17.1 with default config,
and I see here: https://github.com/wavesplatform/Waves/releases/tag/v1.0.0
for node v.1.0.0 matcher was been disabled, and not working with default config:
Matcher and gRPC server have been refactored into an extension, and there's definitely more to come.
So, by this reason, I found your extensions and asked about matcher and grpc-server...
After unpack, using 7z, .tgz -> into .tar, and .tar -> into folder, I see jar-files there, in the /lib-folder.
But... I still cann't run the Matcher REST API for node v1.0.2...
After unpack files, according this guide I created .bat-file, with name import_extensions.bat, and with content:
G:
cd "G:\coins\WAVES_FULL_NODE\NEW_NODE"
java -cp "G:\coins\WAVES_FULL_NODE\NEW_NODE\waves-all-1.0.2.jar;G:\coins\WAVES_FULL_NODE\NEW_NODE\dex-1.0.1\dex-1.0.1\lib\*" com.wavesplatform.Application node.conf
pause

in node.conf, I did write the following strings:
# ... here many lines of your Node's configuration

waves.extensions = [
  "com.wavesplatform.dex.Matcher"
  # ... here may be other extensions
]

waves.dex {
  account = "MY NODE WAVES ADDRESS" # This account must be known at the Node, e.g. created through POST /addresses
  # bind-address = "<IP_ADDRESS>" # uncomment this line to accept connections from any host
}

Also, in node.conf I have mather configuration earlier:
# Matcher settings
  matcher {
    # Enable/disable matcher
    enable = yes

    # Matcher's account address
    account = "WAVES_ADDRESS_OF_MY_NODE"

    # Matcher REST API bind address
    bind-address = "<IP_ADDRESS>"
    bind-address = "[::]"
    bind-address = "<IP_ADDRESS>"

    # Matcher REST API port
    port = 6886

    # Minimum allowed order fee
    min-order-fee = 300000

    # Fee of order match transaction
    order-match-tx-fee = 300000

    # Matcher's directories
    matcher-directory = ${waves.directory}"/matcher"
    data-directory = ${waves.matcher.matcher-directory}"/data"
    journal-directory = ${waves.matcher.matcher-directory}"/journal"
    snapshots-directory = ${waves.matcher.matcher-directory}"/snapshots"

    # LevelDB's internal cache size
    leveldb-cache-size = ${waves.leveldb-cache-size}

    # Snapshots creation interval
    snapshots-interval = 1d

    # Invalid/Expired orders cleanup interval
    order-cleanup-interval = 5m

    # Maximum allowed amount of open orders
    max-open-orders = 1000

    # Maximum allowed amount of orders retrieved via REST
    rest-order-limit = 100

    # Maximum orders stored in OrderHistory per address
    max-orders-per-address = 1000

    # Base assets used as price assets
    price-assets: []

    # Predefined ordering of base assets
    predefined-pairs: []

    # Maximum difference with Matcher server time
    max-timestamp-diff = 3h

    # Blacklisted assets id
    blacklisted-assets: []

    # Blacklisted assets name
    blacklisted-names: []

    # Blacklisted addresses
    blacklisted-addresses: []
  }

But... After running import_extensions.bat, I don't see the working Matcher REST API at port 6886 on my localhost...
Only Node REST API available at port 6869.
And only in version of node v0.17.1, Matcher REST API available at port 6886, with my previous settings.
So, how to configure and run Matcher REST API, using your extensions, for nodes v1.0.0, v1.0.1, v1.0.2???
Is there any guides??

Hi @username1565! v<IP_ADDRESS> it's just the version built from 1.0.1 version containing the internal configuration to run on our internal servers, like setups for Kafka and nodes pool. So it is the latest version currently.


zeros() not tracking shape based on input tensors

>>> shape = [constant([2])[0], 3]
>>> reshape([1,2,3,4,5,6], shape)
<tf.Tensor 'Reshape_13:0' shape=(2, 3) dtype=int32>
>>> zeros(shape)
<tf.Tensor 'zeros_2:0' shape=(?, 3) dtype=float32>

If reshape can understand the input values well enough to set a static shape for its output, shouldn't zeros() be able to?
This is using tensorflow 1.5

Ah, I believe in this case reshape() is getting all the information it needs from the static shape of the input tensor, and the other known constants in the shape.  I don't think this is a bug, then.


Zeroize and don't reveal private keys

astria-cli does not treat private keys with sufficient care and secrecy. It should

zeroize private keys before dropping them
refrain from printing as plain text private keys to stdout/stderr or as part of debug messages
not read private keys from stdin as plain text

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

This issue was closed because it was stale


JsonSchema*-Annotations ignored in kotlin code

Hey Morten,
thanks for this great library, but I have troubles to get it working in kotlin.
@Test
internal fun `json schema from object`() {
    val generator = JsonSchemaGenerator(jacksonObjectMapper())
    val schema = generator.generateJsonSchema(Example::class.java)
    println(schema.toPrettyString())
}

class Example {
    @JsonSchemaInject(
            ints = [
                JsonSchemaInt(path = "minLength", value = 3),
                JsonSchemaInt(path = "maxLength", value = 10)
            ]
    )
    val aString: String = ""

    @Size(min = 3, max = 10)
    val aString2: String = ""
}

produces the json schema
{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "title" : "Config Title",
  "description" : "Config Description",
  "type" : "object",
  "additionalProperties" : false,
  "properties" : {
    "astring" : {
      "type" : "string"
    },
    "astring2" : {
      "type" : "string"
    }
  },
  "required" : [ "astring", "astring2" ]
}

but minLength and maxLength are not set.
Do you have an idea?
Best

Not sure, for what its worth, I added your annotations to the KotlinWithDefaultValues type in the repo:
data class KotlinWithDefaultValues(
	val optional: String?,
	val required: String,
	@JsonSchemaInject(
			ints = [
				JsonSchemaInt(path = "minLength", value = 3),
				JsonSchemaInt(path = "maxLength", value = 10)
			]
	)
	val optionalDefault: String = "Hello",
	val optionalDefaultNull: String? = "Hello"
)

...and the schema was as expected:
{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "title" : "Kotlin With Default Values",
  "type" : "object",
  "additionalProperties" : false,
  "properties" : {
    "optional" : {
      "type" : "string"
    },
    "required" : {
      "type" : "string"
    },
    "optionalDefault" : {
      "type" : "string",
      "minLength" : 3,
      "maxLength" : 10
    },
    "optionalDefaultNull" : {
      "type" : "string"
    }
  },
  "required" : [ "required", "optionalDefault" ]
}

Have you tried the latest version of the library?

Not sure, for what its worth, I added your annotations to the KotlinWithDefaultValues type in the repo:
data class KotlinWithDefaultValues(
	val optional: String?,
	val required: String,
	@JsonSchemaInject(
			ints = [
				JsonSchemaInt(path = "minLength", value = 3),
				JsonSchemaInt(path = "maxLength", value = 10)
			]
	)
	val optionalDefault: String = "Hello",
	val optionalDefaultNull: String? = "Hello"
)

...and the schema was as expected:
{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "title" : "Kotlin With Default Values",
  "type" : "object",
  "additionalProperties" : false,
  "properties" : {
    "optional" : {
      "type" : "string"
    },
    "required" : {
      "type" : "string"
    },
    "optionalDefault" : {
      "type" : "string",
      "minLength" : 3,
      "maxLength" : 10
    },
    "optionalDefaultNull" : {
      "type" : "string"
    }
  },
  "required" : [ "required", "optionalDefault" ]
}

Have you tried the latest version of the library?

Long time since you posted the original issue, but thought this may help others who land here.
Have you tried prepending "@field:JsonSchemaInject"?
@Test
internal fun `json schema from object`() {
    val generator = JsonSchemaGenerator(jacksonObjectMapper())
    val schema = generator.generateJsonSchema(Example::class.java)
    println(schema.toPrettyString())
}

class Example {
    /*
     * Place it right here
     */
    @field:JsonSchemaInject(
            ints = [
                JsonSchemaInt(path = "minLength", value = 3),
                JsonSchemaInt(path = "maxLength", value = 10)
            ]
    )
    val aString: String = ""

    @Size(min = 3, max = 10)
    val aString2: String = ""
}

Kotlin's generates getters and setters under the hood at compile time, so it's better to be explicit with intent or you may not get the results you want.


no display on Firefox with Threejs r75 and r76

Hi,
rendered scenes are correct on Chrome with Threejs r75 and r76, but nothing apears on Firefox (v48 dev, v47 dev  and v45)
same thing with the example named explosion
Thanks for your great work, and sorry for my bad english :)

Does the same thing happen with Threejs r73?
I'll look into this, and thanks for letting me know.

Yes on Windows, 7 (32 and 64 bits with SP1) and XP SP3. Tomorrow I will made a test under Debian 8.2
I have not tested with threejs r73. And not all examples don't work, just some of them: explosion, fog and Emitter pooling.
I have made a smoke engine with your engine, it works well under Chrome and other webkit engines (like Opera), but not on FF (release, dev and aurora tested)
Thanks for your help

Hey @Grajon, sorry for being so tardy. Very busy with real life lately.
Interesting that removing the floor mesh fixes the issue on Win7... by the sounds of it, I'd put it down to either a ThreeJS issue or Firefox itself.
Are you still seeing problems with both the latest ThreeJS and latest Firefox releases?


Add usage of omitempty tag to Struct for related external reference ids

@kdmcclel Thanks for the PR! Just trying to understand the use case. Can you describe how this will be used? I'm not sure what you mean by "related external reference ids".

The REST API can set lookup relationships using an external ID on the
related object.  I ended up using something similar to the following struct
for a custom Event object which has a lookup relationship to Accounts.
This worked well except the relationship is optional so I would get a
hanging JSON tag which broke the REST API.
type Event struct {
...
Account__r       struct {
ExternalId__c float64 force:",omitempty"
} force:",omitempty"
}
json with account - {"Name":"Test","Account__r":{"ExternalId__c":101} }
json without - {Name: "Test","Account__r":{}}
Kept getting errors returned in the second case.
On Tue, Dec 29, 2015 at 7:47 PM, Nima Jalali<EMAIL_ADDRESS>wrote:

@kdmcclel https://github.com/kdmcclel Thanks for the PR! Just trying to
understand the use case. Can you describe how this will be used? I'm not
sure what you mean by "related external reference ids".
—
Reply to this email directly or view it on GitHub
https://github.com/nimajalali/go-force/pull/28#issuecomment-167907236.

But now i think maybe I should have just used a pointer to the struct.  No
way to empty the relationship if we don't send nil.
whoops.
On Tue, Dec 29, 2015 at 10:15 PM, Kevin McClellan<EMAIL_ADDRESS>wrote:

The REST API can set lookup relationships using an external ID on the
related object.  I ended up using something similar to the following struct
for a custom Event object which has a lookup relationship to Accounts.
This worked well except the relationship is optional so I would get a
hanging JSON tag which broke the REST API.
type Event struct {
...
Account__r       struct {
ExternalId__c float64 force:",omitempty"
} force:",omitempty"
}
json with account - {"Name":"Test","Account__r":{"ExternalId__c":101} }
json without - {Name: "Test","Account__r":{}}
Kept getting errors returned in the second case.
On Tue, Dec 29, 2015 at 7:47 PM, Nima Jalali<EMAIL_ADDRESS>wrote:

@kdmcclel https://github.com/kdmcclel Thanks for the PR! Just trying
to understand the use case. Can you describe how this will be used? I'm not
sure what you mean by "related external reference ids".
—
Reply to this email directly or view it on GitHub
https://github.com/nimajalali/go-force/pull/28#issuecomment-167907236.


Update mockito-scala-scalatest to 1.16.3

Updates org.mockito:mockito-scala-scalatest from 1.15.1 to 1.16.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-scala-scalatest" } ]

labels: library-update, semver-minor

Superseded by #561.

Superseded by #561.


Support new stage Alpha 2 for 4.10.0 in wazuh-dashboard repository

Description
This issue attempts to support a new stage Alpha 2 for 4.10.0 in the wazuh-dashboard repository.
Tasks

[x] Ensure changelog is updated for 4.10.0 (if applicable).
[x] Bump revision for branch 4.10.0 on wazuh-dashboard repository.

https://github.com/wazuh/wazuh-dashboard/pull/352

[x] Create tag v4.10.0-alpha2 from branch 4.10.0 on wazuh-dashboard repository.
[x] Create and publish a pre-release: https://github.com/wazuh/wazuh-dashboard/releases/tag/v4.10.0-alpha2.

LGTM


feat: used the standard date time formatter

Summary:
Closes #1652

report.json
Expected behavior:
Please see the validatedAt string on the screenshot and json report.
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
[ ] Add or update any needed documentation to the repo
[x] Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

Can we remove the milliseconds and the name of the timezone? Example: 2024-01-15T24:14:45+05:00

report.json
Voila @davidgamez

Regarding when --date is passed in the validator question @davidgamez, I tried java -Xmx1G -jar ./cli/build/libs/gtfs-validator-4.2.1-SNAPSHOT-cli.jar -d 2023-01-01 -o /Users/jingsi/code/data/gtfs-ws/delfi -i /Users/jingsi/Downloads/google-transit-darwin-200124.zip and it's working.


fix(docs): add imports for react-email in integrations step 1

Background
Previously, every integrations in the documentation, step 1, recommended to install a list of dependencies to have a particular integration work seamlessly. But that step missed the following dependency @react-email/render in each integration, which can lead to a misunderstanding when an error will show up
How this PR should fix it ?
This PR adds the relevant imports to make the integrations work as intended. It's a fix for #1501

Thank you so much for taking the time to do this!

I rebased it into main to avoid having extra changes from our canary, since I wanted to merge this directly into our main. Could you rebase it into main again?


Add GetSingleSelectionList

Sometimes I encounter scenarios where Each method is insufficient, for example when I need to return an error during the iteration. One of first things I tried was looping through selection.Nodes, but working with that brings it's own issues as far I remember. So, I ended up doing this:
func GetSingleSelectionList(selection *goquery.Selection) []*goquery.Selection {
	selectionList := make([]*goquery.Selection, selection.Length())
	selection.Each(func (i int, sel *goquery.Selection) {
		selectionList[i] = sel
	})
	return selectionList
}

This feels like doing something that should be built in though.
This is where this PR comes in. I am not sure how to name this method though - for now it's GetSingleSelectionList, unless it conflicts with existing naming. Maybe something with split or spread wording would fit better, or go other direction and make it more accessible.

Hello,
I'm not sure I understand the purpose this new method would serve, what you are building is a slice of single-element selections which is more or less what the original selection is. What would you do then with that slice of single selections? If it's just to return an error from Each as you mention, this is easy to accomplish by assigning to an error variable declared outside the Each (or EachWithBreak) closure.
If you could provide a representative task that you struggled to accomplish with the current API, it would help illustrate how adding this would help or perhaps I could see if a different approach using the (quite large) existing API would be better.
Martin

I am currently rewriting my scrapping program and managed to solve various problems differently than I initially did. This one is keep returning though. Unfortunately I don't remember all the scenarios I experienced through the way. Currently I have two where it's used:

Looping through a list and performing some actions, which can return an error
Looping through another list backwards

For the first one, your suggestion indeed solved the issue. I should have thought of that, especially that I already used non-error variables like that. For my defense, I am relatively new to Go.
For the second one I still need a slice of selections. The reason I go backwards on it is because I obtain the HTML, do some work on it and set it back to the selection. Doing it in normal order may invalidate further selections if they were found in that HTML, while doing it backwards seems to start from youngest/most nested/indented ones and then move to their ancestors. I am uncertain yet if this is reliable, it's a fresh idea. div can come into mind as example, but I find ul better one, as li elements are between layers - to make nested ul, it has to be in li element. Thoughts?

Yeah if you change the html of elements in the selection, it can definitely invalidate elements from the selection if some were nested inside the modified element. That being said, there are a number of html manipulation methods you can use that can append/prepend/wrap etc html on the selection as a whole, if the manipulation you have to do is the same for all nodes in the selection.
Otherwise, you can still do it in whatever order (assuming you don't have to re-select and re-process elements inside the newly assigned html?), because replaced elements will still be valid in the selection, it's just that they won't be part of the document anymore (e.g. if you print out the outer html of the root document, they won't appear, they are orphan nodes).
You cannot really rely on the order in a selection in general, because a selection can be created from many different ways (e.g. Add other selections, Intersection, Union, etc.) that can change the ordering. But for a single operation (e.g. doc.Find("div")), then yes, the document order is respected, so parent nodes will appear before nested ones in the selection.
If you really want to iterate in reverse order, you can use something like that (untested):
for i := sel.Length() - 1; i >= 0; i-- {
   singleSel := sel.Eq(i)
   // use selection...
}

Hope this helps,
Martin

Your suggestion seems to do the trick indeed. I expected that if such feature wasn't added this long, there are probably ways to do it somehow else. Well, in case someone runs into similar problem / requirement, this discussion may be in use. Thank You your time, help and the library.

Cool, no problem, thanks for your interest in goquery and have fun with your project!


Problem using Lombok + Eclipse + whatsappweb4j

Hey,
did anyone face this error before?

I am using a fresh copy of the current eclipse version with a lombok added. When importing the project with maven, I am immediately getting the above mentioned error ...
Kind regards
Dustin

Hey,
did anyone face this error before?

I am using a fresh copy of the current eclipse version with a lombok added. When importing the project with maven, I am immediately getting the above mentioned error ...
Kind regards Dustin

Are you using Java 17 to compile? Have you tried to clean your build and retry?

Hey,
did anyone face this error before?

I am using a fresh copy of the current eclipse version with a lombok added. When importing the project with maven, I am immediately getting the above mentioned error ...
Kind regards Dustin

Are you using Java 17 to compile? Have you tried to clean your build and retry?

Yes, I am using JDK 17. clean and everything did not work :/

Hey,
did anyone face this error before?

I am using a fresh copy of the current eclipse version with a lombok added. When importing the project with maven, I am immediately getting the above mentioned error ...
Kind regards Dustin

Are you using Java 17 to compile? Have you tried to clean your build and retry?

Yes, I am using JDK 17. clean and everything did not work :/

It's kind of strange. No one has had any problems compiling. Can you try to use Javac instead of the eclipse compiler, maybe it's a Lombok bug


[feat] Native support for use of assets unknown at build time within tauri windows.

Describe the problem
We have the use case where we have an app store in our tauri app from which apps can be installed by the user. The assets of those apps are then installed to dedicated folders and the user should be able to open the installed app in a tauri window.
We specifically want to use tauri windows because they provide a secure channel for messages sent by those apps and the tauri backend because we can ensure in this way that messages sent by the "external" applications to tauri core cannot be intercepted/tampered with along the way (the main application is connected to a keystore protected by a password and messages from those "external" apps need to be signed by private keys stored in the keystore). Obviously we ensure that those windows can only call a very limited set of commands to tauri core (currently one single command).
Currently this doesn't seem to be natively possible without what seems like a workaround. Any window built with either WindowUrl::External("http://localhost:[port]") or WindowUrl::App([path to assets not known at build time]) does not offer IPC calls, i.e. it will raise window.__TAURI__IPC__ is not a function.
We found a workaround with which we can still achieve the above described goal (and hope this workaround remains supported as long there is no other alternative!) but it is does seem quite unnatural. They way we solve it is that we call the window builder with WindowUrl("index.html") and then use the on_web_resource_request() method to redirect requests to the corresponding folderpaths where the assets are installed, including having to guess the MIME type of the response based on the filename of the requested resource.
Describe the solution you'd like
I would like to have the possibility to explicitly allow IPC calls by windows accessing assets unknown at build time. This could for example be implemented as a method allow_external_IPC_calls() of the WindowBuilder struct or to follow the tauri conf terminology dangerous_allow_external_IPC_calls().
Alternatives considered
See workaround described above.
Additional context
No response

Potentially related: #5088

I also have a similar use case, except assets are not written to disk. Assets for the "apps" are fetched from a remote resource via an RPC call, verified and forwarded to the web view. I'm currently handling this with a local file server, but on_web_resource_request could also work for my use case. As the OP mentioned, this gap between the file (on disk or in memory) and the webview is a security concern.


Add docs for flattening_enabled and flattening_max_depth

I searched the docs and couldn't find any explanation of the flattening feature. We should add something, either under the stream maps docs page, or on another page.
https://github.com/meltano/sdk/blob/3998ac14918b6b2338851b8bb428485a9378ff49/singer_sdk/helpers/capabilities.py#L29-L43
Was discovered here:

https://github.com/MeltanoLabs/meltano-map-transform/issues/24

Still relevant


Fail build script if lumen-tblgen errors

If lumen-tblgen fails to run, the build script can still succeed.
This will panic if lumen-tblgen returns an error.

Looks like we ended up making the same change just on different ends of the output being printed, so I'll close this in favor of printing the output always, regardless of whether it errors, since Cargo suppresses the output for successful builds anyway


Adding detection notebook for eval metrics and EXP5_eval for adding new cell type to reference of decov. cancer data

Two new notebooks, both for addressing reviewer comments on manuscript.

EXP1_detection.ipynb:  Uses simple simulated bulks w/ 5 cell types. Goal is to detect presence and number of missing cells.
EXP5_eval.ipynb: a lot of the code is repeated from EXP4_eval.ipynb. Uses cancer data with new cell added to reference

Merging pull request with reran NBs of bigger plots and new analysis for reviewer comments.


Video#empty? causes unexpected behaviour

Recently I found that usage of #present? or #blank? methods on a video object causes additional status queries
This is because of ActiveSupport's definition of #blank? method
# @return [true, false]
def blank?
  respond_to?(:empty?) ? !!empty? : !self
end

It calls #empty? method on a video object
# @return [Boolean] whether the video failed to upload to YouTube because
#   the video file is empty.
def empty?
  status.failure_reason == 'emptyFile'
end

Which was quite quirky for me , I didn't expect such behaviour
As a quick fix I would overwrite #blank? for a Video
What do you think?

I'm not sure, probably we should rename empty? or document somewhere that not to use blank? on videos.


Limit request body size and header size with configuration

Motivation
SM should be able to configure the maximum body request size and header sizes
Pull Request status

[x] Limit the incoming request body size
[x] Limit the incoming request headers size
[ ] Limit the response body size from brokers
[ ] Unit tests

Pull Request Test Coverage Report for Build 1355

16 of 28 (57.14%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.6%) to 91.129%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/server/server.go
5
10
50.0%

api/http_handler.go
11
18
61.11%

Files with Coverage Reduction
New Missed Lines
%

api/filters/authn/oauth/filter.go
2
91.3%

api/api.go
2
90.77%

api/http_handler.go
3
77.42%

Totals

Change from base Build 1346:
-0.6%

Covered Lines:
2219

Relevant Lines:
2435

💛  - Coveralls


docs: upgrade docs from Docker Compose

Skaffold is a TODO but I'm thinking it will follow this format.

Also I'll run make docs later, didn't want to muck up the diff with that for now.

also, you'll want to add this the the TOC so that it shows up in the sidebar


Agile development sprints for the Voice Assistant application

What to do?

Login Signup pages
Responsive preview
Firebase connectivity
User Authentication
Documentation

We need to work on the Milestone and must be done at least a day before the deadline.

:zap: On it ...!

Milestone achieved ..! 🎇


Does unsloth/Phi-3-mini-128k-instruct model exist?

Does unsloth/Phi-3-mini-128k-instruct model exist?

You can check here for all the available models.
Huggingface Unsloth
unsloth/Phi-3-mini-4k-instruct-bnb-4bit
unsloth/Phi-3-mini-4k-instruct
Both are mistralfied.
These models are available if I am not wrong.

Ye sadly not 128K yet - on the roadmap though! It's sadly not RoPE but some other scaling mechanism


ESM not working with new electron

Electron now has esm builtin and when I tried it with that I get:
PS C:\Users\13\Developer\electron-vite-project> pnpm run dev

><EMAIL_ADDRESS>dev C:\Users\13\Developer\electron-vite-project
> vite

vite v4.5.0 building for development...

watching for file changes...
vite v4.5.0 building for development...

watching for file changes...

  VITE v4.5.0  ready in 362 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help

build started...

build started... (x2)
✓ 1 modules transformed.
✓ 1 modules transformed. (x2)
dist-electron/main.js  1.54 kB │ gzip: 0.69 kB
built in 124ms.
dist-electron/preload.js  2.70 kB │ gzip: 1.10 kB
built in 127ms.

App threw an error during load
ReferenceError: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and 'C:\Users\13\Developer\electron-vite-project\package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
    at file:///C:/Users/13/Developer/electron-vite-project/dist-electron/main.js:2:18
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

Migration to v0.28.0-beta.1


[tests-only] against core branch tidy-up-user-cleanup-for-ocis-reva

Check that the acceptance tests pass with the core changes in https://github.com/owncloud/core/pull/38661

CI passes - good.

The real bump of commit id for master is PR #1984


adopting crates from the to-be-archived rustwasm org

Hey all, I'm working with the Rust project to shutter the long-defunct rustwasm github org and corresponding Wasm WG. Given we have BA members still actively maintaining a number of crates in the org, and we use a number of these in our projects, I wanted to open an issue here to propose adopting some of those crates in the BA. The full list of repositories can be found here. Based on maintainership, I was thinking the BA adopt the following crates:

weedle - a WebIDL parser (particularly relevant for jco, WebGPU, WebUSB)
walrus - a wasm transformation library

There are a number of other crates which seem generally useful, but haven't been updated in a minute. But perhaps we might want to adopt these in case they are still relevant?

twiggy - a code size profiler
wasm-tracing-allocator - a debugging allocator
wee-alloc - a small, wasm-enabled allocator
wasm-snip - replaces a wasm function's body with an unreachable

Process-wise, if the BA does not choose to adopt these crates, they will likely be marked as [archived] on GitHub as they have no other logical place to go. The flagship wasm-bindgen and wasm-pack crates should likely be adopted by their existing maintainers (non-BA afaik), and moved to a different org.
In terms of timing: any migration of crates is pending a decision from the Rust project to move forward with the deprecation of the Rust Wasm WG. I want to make clear that this is not a question about whether the BA wants the Rust Wasm WG to be shuttered, but about the steps that come after.
I'm keen to hear thoughts from the BA steering committee on this; I assume this should probably be raised at a future meeting? But I would in particular also want to hear from @alexcrichton and @fitzgen, who have worked on a number of these crates and are likely to have insights on whether they are relevant to the BA going forward.
Thanks!

This seems reasonable to me if we've got BA members signed up to maintain the repositories, so 👍 from me


Fix for https://github.com/near/near-cli/issues/786

If the seed phrase is used on the command line regardless of position, the seed-phrase middleware creates a key and adds it to the keystore.  This change considers that fact and eliminates output of the confusing message.
Also added the seedPhrase yargs option as it seems to be supported per how things work and even per the comment here:
https://github.com/near/near-cli/blob/63cd30cc27a3cefd9ff48c6d4e9b4b26816bb0ed/middleware/seed-phrase.js#L8

🎤 ✔ 12...

Any feedback on this one?

@volovyk-s


require files that aren't automatically required

instance_double doesn't hit const_missing, so the model is never
required which means that this test will fail when it is run in
isloation, but could randomly fail when run with the suite (depending on
the order of tests).
require the model so that the constant is available.

Good find @tenderlove
Normally, we'd do describe DialogTabSerializer do  to hit cont_missing but since this example is testing two classes, the single describe loads the DialogYamlSerializer but not the other.
This is good enough for now to fix this issue.


fixed for python 3 compatibility

Works for python 3.6!

@casebeer please approve this!  I've simply run 2to3 in my own fork with similar results.  This small package is extremely useful and it would be amazing to keep it alive in the python3 world.

You can install from the github branch as a stop gap.
pip install git+https://github.com/nkarman/audiogen.git@master

Thankyou for this!

Is there not an issue with generating tones in 3.7, because of some change to how generators call StopIterations, and now call RuntimeErrors? Sadly I can't show you the exact error right now as I'm on a school computer but I don't think this fix works for python 3.7. As it is it's great, however, if someone could help with this issue or explain what is going on that would be great.
https://docs.python.org/3/library/exceptions.html#StopIteration

Thanks everyone for the reports – @monty-wanty I see what you're talking about but it'll take more debugging since I don't see anything raising StopIteration. I'll see if I can catch up on this PR.


kiwi logger can not be used with LML Basic Template

Hi,
I used gdx-setup to create my testing project, I selected Kiwi from Third-party and select LML Basic from Templates. Then I import com.github.czyzby.kiwi.log.Logger; and import com.github.czyzby.kiwi.log.LoggerService; in my class and use it "private final Logger logger = LoggerService.forClass(gnk.class);¬ ". When I run my code there has a java.lang.NullPointerException. the error message is:desktop:runException in thread "main" java.lang.ExceptionInInitializerError
at citrine.gnk.gnk.(gnk.java:21)
at citrine.gnk.desktop.DesktopLauncher.createApplication(DesktopLauncher.java:15)
at citrine.gnk.desktop.DesktopLauncher.main(DesktopLauncher.java:11)
Caused by: java.lang.NullPointerException
at com.github.czyzby.kiwi.log.LoggerService.(LoggerService.java:38)
at com.github.czyzby.kiwi.log.LoggerService.(LoggerService.java:24)
... 3 more
I don't known what cause it, I used the kiwi logger successful with Autumn MVC Template.

LoggerService turns on LibGDX logging in the constructor:
Gdx.app.setLogLevel(Application.LOG_DEBUG);

It basically references Gdx.app before it is initiated. For now, you should import and use the logger after the application is created.


Add buildkitd-rootless startup script to extras

Similar to the containerd-rootless startup script
https://github.com/containerd/nerdctl/blob/master/docs/rootless.md

containerd-rootless.sh (https://github.com/containerd/containerd/blob/main/docs/rootless.md)

buildkitd-rootless.sh (https://github.com/moby/buildkit/blob/master/docs/rootless.md)

I think this should be submitted to buildkit repo

But the containerd script is not in containerd repo ?

containerd-rootless.sh is maintained here because it had to be written with nerdctl in unison during early development phase of nerdctl.
We could move it to the main repo but migration is not straight forward.


opt let DBA ignore some runtime filters

Proposed changes
example:
set ignore_runtime_filter_ids="3, 1";
after this setting, RF003 and RF001 will be ignored
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


socket_write result is not checked - partial write is possible

This issue is continue of SSL discussion https://github.com/duoshuo/php-cassandra/pull/20
Currently functions (a)syncRequest just do socket_write($this->connection, $request); without test return value, assuming that all data is always sent. This can lead to partial send.
Try following test:
$str ='';
for ($i=0;$i<10000000;$i++)	$str .= '#';

$s = socket_create(AF_INET,SOCK_STREAM, SOL_TCP);
socket_set_option($s, SOL_SOCKET, SO_SNDTIMEO, ["sec" => 5, "usec" => 0]);

socket_connect($s,"php.net",80);
//socket_set_nonblock($s);

$sent = socket_write($s,$str);
echo "Sent ".$sent ." bytes\n";

If network upload is slow (I set limitation in virtual machine to 28 kbps) socket_write is returns after several seconds and $sent is about 50K. If socket_set_nonblock is uncommented socket_write is returned immediately and only 18K is sent.
The same happens in current php-cassandra code. Connect to remote server with slow connection, make syncReqest and test socket_write result. It's extreme case, but if you send many long request via slow connection it can happen.
Now no non-blocking mode is used (and can not be used without usage some real async I/O mechanism, like dedicated I/O thread with socket_select) in php-cassandra, but partial send should be handled anyway, something like this:
	$reqstr = (string)$request;

	while(strlen($reqstr) >0)
	{
		$res = socket_write($this->connection, $reqstr);

		if ($res === false)
			throw new Exception(socket_strerror(socket_last_error()));

		$reqstr = substr($reqstr,$res);
	}

Basing on this I suggest to adopt my SSL addition with above fix. Stream performance is not issue at all.
Thanks.

vovodroid is right. Same thing happens if the connection is closed before any data is sent:
Warning: socket_write(): unable to write to socket [104]: Connection reset by peer in vendor/duoshuo/php-cassandra/src/Connection.php on line 242

----------Same thing happens if the connection is closed before any data is sent
Sure. Connect to C*, stop in debugger at socket_write, shutdown C* and continue.

Thanks, I've fixed this bug in https://github.com/duoshuo/php-cassandra/commit/07c90e70d2ebc84dda12d5db0c1836be9682828b

After this commit no exception is thrown on Cassandra error.
Try twice
$res = $connection->querySync("CREATE USER test WITH PASSWORD '123'",[]);
$res = $connection->querySync("CREATE USER test WITH PASSWORD '123'",[]);

Second $res is  Cassandra\Response\Error type

By a way, queryAsync ... getResponse also don't throw exception.

exactly, my fault, I'll fix it immediately

Here is my solution for queryAsync:
	public function getResponse(){
		if($this->_response === null){
			$response = $this->_connection->getResponse($this->_streamId);
		}else{
			$response = $this->_response;
		}

		if ($response instanceof Response\Error)
			throw new Exception($response->getData());

		return $response;
	}

I've merged your pull-request, and add Response\Error check.


Made a finetuning code for using huggingface (No llama-factory)

https://github.com/2U1/Qwen2-VL-Finetune
I made a code for who wants to use the huggingface version to finetune, and having difficult using some other frameworks like me.
This code only uses huggingface for fine-tuning the 7B and 2B model.
Also, you can set different learning_rate for vision_model and language_model (Also for the projector).
Feedback and issues are welcome!

Hey! I have a doubt regarding the dataset preparation. We require to have the dataset in the following format:
[
{
"conversations": [
{
"from": "human",
"value": "human instruction"
},
{
"from": "gpt",
"value": "model response"
}
],
"images": [
"image path (required)"
]
}
]
My doubt is can we have image URL instead of image path?

@codexankit Thanks for your interest to my work.
For now, the it dosen't accept the url form. I'll make a quick update for it.
Also, make sure your text data has a '\n' between <image> token and the text.
The purpose is to structure the dataset in a way that can be directly used by other models, as many models utilize the dataset format of LLAVA.

@2U1 Thanks for the reply man. As of now I have the dataset which has image URLs and I urgently need to finetune the Qwen2-VL. So is there any way I can use the URLs instead of image_path? I was thinking to modify the loader.py script of llama-factory but I don't know how to do it exactly. Can you guide me on this?

@codexankit Thanks for your interest to my work. For now, the it dosen't accept the url form. I'll make a quick update for it.
Also, make sure your text data has a '\n' between <image> token and the text.
The purpose is to structure the dataset in a way that can be directly used by other models, as many models utilize the dataset format of LLAVA.

Did you make the update for url support?

@codexankit Sorry it's a holiday in my country and I'm om a trip now. So I haven't yet.
You can fix the getitem in the data.py.
You could just comment the line 134 and 135 if it's a image file.

@codexankit Sorry for late update, I've updated the code to load from the urls too.


Material Face Assignments Ignored

I used a test character and exported from Maya 2017 with the Material Face Assignments turned on. In Unity it creates only one material assignment. I double checked the Alembic in Isotropix Clarisse and it has individual assignments for the shirt, pants skin etc...

Is it possible to have multiple materials without splitting the mesh into submeshes similar to how an FBX import works? Splitting up the mesh will introduce more draw calls.

@ShawnFrueh it's simply impossible. FBX importer also splits into submeshes.
if you want to draw multiple materials with single draw call, you can emulate it with special shaders (e.g. write a shader that has array of albedo colors and index it with material IDs)

I think you misunderstand. I don't need a single draw call. I need it to actually create the proper number of materials for each Face/Material assignment. And as I said in the first post. It works this way in othe software that uses Alembic.

@EddieSoloProjects yeah, I understand what you said. face set support is already implemented and it is in testing phase. I wish you to test if you can..  https://github.com/unity3d-jp/AlembicImporter/releases/tag/20180201

https://github.com/unity3d-jp/AlembicImporter/releases/tag/20180201

https://github.com/unity3d-jp/AlembicImporter/releases/tag/20180205


make ground items plugin hotkey configurable

Added a config option so that the hotkey for the Ground Items plugin is no longer hardcoded. As someone whose alt key is reserved as their modifier key for their window manager, this is much needed.
Also, this partly addresses #7831.

This doesn't work at all and trips at least one assertion
java.lang.AssertionError: null
	at net.runelite.client.config.Keybind.<init>(Keybind.java:72)
	at net.runelite.client.config.Keybind.<init>(Keybind.java:87)
	at net.runelite.client.plugins.grounditems.GroundItemsConfig.hotkey(GroundItemsConfig.java:461)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:710)
	at net.runelite.client.config.ConfigInvocationHandler.callDefaultMethod(ConfigInvocationHandler.java:169)
	at net.runelite.client.config.ConfigInvocationHandler.invoke(ConfigInvocationHandler.java:92)
	at com.sun.proxy.$Proxy98.hotkey(Unknown Source)
	at net.runelite.client.plugins.grounditems.GroundItemInputListener.keyReleased(GroundItemInputListener.java:80)
	at net.runelite.client.input.KeyManager.processKeyReleased(KeyManager.java:110)
	at net.runelite.client.callback.Hooks.keyReleased(Hooks.java:318)

This doesn't work at all and trips at least one assertion
java.lang.AssertionError: null
	at net.runelite.client.config.Keybind.<init>(Keybind.java:72)
	at net.runelite.client.config.Keybind.<init>(Keybind.java:87)
	at net.runelite.client.plugins.grounditems.GroundItemsConfig.hotkey(GroundItemsConfig.java:461)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:710)
	at net.runelite.client.config.ConfigInvocationHandler.callDefaultMethod(ConfigInvocationHandler.java:169)
	at net.runelite.client.config.ConfigInvocationHandler.invoke(ConfigInvocationHandler.java:92)
	at com.sun.proxy.$Proxy98.hotkey(Unknown Source)
	at net.runelite.client.plugins.grounditems.GroundItemInputListener.keyReleased(GroundItemInputListener.java:80)
	at net.runelite.client.input.KeyManager.processKeyReleased(KeyManager.java:110)
	at net.runelite.client.callback.Hooks.keyReleased(Hooks.java:318)

I just cloned a fresh repo, rebased, rebuilt, and this is still working locally for me... I also signed out of Runelite and reran the client in case this was happening on default settings, but I couldn't reproduce.
Would you have any suggestion on how I can reproduce this?

This doesn't work at all and trips at least one assertion
java.lang.AssertionError: null
	at net.runelite.client.config.Keybind.<init>(Keybind.java:72)
	at net.runelite.client.config.Keybind.<init>(Keybind.java:87)
	at net.runelite.client.plugins.grounditems.GroundItemsConfig.hotkey(GroundItemsConfig.java:461)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:710)
	at net.runelite.client.config.ConfigInvocationHandler.callDefaultMethod(ConfigInvocationHandler.java:169)
	at net.runelite.client.config.ConfigInvocationHandler.invoke(ConfigInvocationHandler.java:92)
	at com.sun.proxy.$Proxy98.hotkey(Unknown Source)
	at net.runelite.client.plugins.grounditems.GroundItemInputListener.keyReleased(GroundItemInputListener.java:80)
	at net.runelite.client.input.KeyManager.processKeyReleased(KeyManager.java:110)
	at net.runelite.client.callback.Hooks.keyReleased(Hooks.java:318)

I just cloned a fresh repo, rebased, rebuilt, and this is still working locally for me... I also signed out of Runelite and reran the client in case this was happening on default settings, but I couldn't reproduce.
Would you have any suggestion on how I can reproduce this?

Do you have assertions enabled? You have to pass the -ea vm argument.
I think the issue here is the keybinds don't support binding only modifier keys, since it makes setting a keybind to something with a modifier impossible. Eg,  you can set a keybind to alt+f1, and it is actually one keypress despite it requiring you to pass two keys.

I tried running with -ea and I'm still not noticing anything:
/usr/lib/jvm/java-11-openjdk/bin/java -ea -javaagent:/opt/intellij-idea-ultimate-edition/lib/idea_rt.jar=39799:/opt/intellij-idea-ultimate-edition/bin -Dfile.encoding=UTF-8 -classpath /home/david/runelite/runelite-client/target/classes:/home/david/.m2/repository/org/slf4j/slf4j-api/1.7.25/slf4j-api-1.7.25.jar:/home/david/.m2/repository/ch/qos/logback/logback-classic/1.2.9/logback-classic-1.2.9.jar:/home/david/.m2/repository/ch/qos/logback/logback-core/1.2.9/logback-core-1.2.9.jar:/home/david/.m2/repository/net/sf/jopt-simple/jopt-simple/5.0.1/jopt-simple-5.0.1.jar:/home/david/.m2/repository/com/google/guava/guava/23.2-jre/guava-23.2-jre.jar:/home/david/.m2/repository/com/google/inject/guice/4.1.0/guice-4.1.0-no_aop.jar:/home/david/.m2/repository/javax/inject/javax.inject/1/javax.inject-1.jar:/home/david/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar:/home/david/.m2/repository/com/google/code/gson/gson/2.8.5/gson-2.8.5.jar:/home/david/.m2/repository/net/runelite/pushingpixels/substance/8.0.02/substance-8.0.02.jar:/home/david/.m2/repository/net/runelite/pushingpixels/trident/1.5.00/trident-1.5.00.jar:/home/david/.m2/repository/org/apache/commons/commons-text/1.2/commons-text-1.2.jar:/home/david/.m2/repository/org/apache/commons/commons-lang3/3.7/commons-lang3-3.7.jar:/home/david/.m2/repository/org/apache/commons/commons-csv/1.4/commons-csv-1.4.jar:/home/david/.m2/repository/net/runelite/archive-patcher/1.0/archive-patcher-1.0.jar:/home/david/.m2/repository/net/java/dev/jna/jna/5.9.0/jna-5.9.0.jar:/home/david/.m2/repository/net/java/dev/jna/jna-platform/5.9.0/jna-platform-5.9.0.jar:/home/david/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar:/home/david/.m2/repository/net/runelite/jogl/jogl-all/2.4.0-rc-20200429/jogl-all-2.4.0-rc-20200429.jar:/home/david/.m2/repository/net/runelite/jogl/jogl-all/2.4.0-rc-20200429/jogl-all-2.4.0-rc-20200429-natives-windows-amd64.jar:/home/david/.m2/repository/net/runelite/jogl/jogl-all/2.4.0-rc-20200429/jogl-all-2.4.0-rc-20200429-natives-windows-i586.jar:/home/david/.m2/repository/net/runelite/jogl/jogl-all/2.4.0-rc-20200429/jogl-all-2.4.0-rc-20200429-natives-linux-amd64.jar:/home/david/.m2/repository/net/runelite/jogl/jogl-all-natives-macosx/2.4.0-rc-20210117/jogl-all-natives-macosx-2.4.0-rc-20210117.jar:/home/david/.m2/repository/net/runelite/gluegen/gluegen-rt/2.4.0-rc-20200429/gluegen-rt-2.4.0-rc-20200429.jar:/home/david/.m2/repository/net/runelite/gluegen/gluegen-rt/2.4.0-rc-20200429/gluegen-rt-2.4.0-rc-20200429-natives-windows-amd64.jar:/home/david/.m2/repository/net/runelite/gluegen/gluegen-rt/2.4.0-rc-20200429/gluegen-rt-2.4.0-rc-20200429-natives-windows-i586.jar:/home/david/.m2/repository/net/runelite/gluegen/gluegen-rt/2.4.0-rc-20200429/gluegen-rt-2.4.0-rc-20200429-natives-linux-amd64.jar:/home/david/.m2/repository/net/runelite/gluegen/gluegen-rt-natives-macosx/2.4.0-rc-20210117/gluegen-rt-natives-macosx-2.4.0-rc-20210117.jar:/home/david/.m2/repository/net/runelite/jocl/jocl/1.0/jocl-1.0.jar:/home/david/.m2/repository/net/runelite/jocl/jocl/1.0/jocl-1.0-macos-x64.jar:/home/david/.m2/repository/net/runelite/jocl/jocl/1.0/jocl-1.0-macos-arm64.jar:/home/david/runelite/runelite-api/target/classes:/home/david/runelite/runelite-jshell/target/classes:/home/david/.m2/repository/com/fifesoft/rsyntaxtextarea/3.1.2/rsyntaxtextarea-3.1.2.jar:/home/david/.m2/repository/com/fifesoft/autocomplete/3.1.1/autocomplete-3.1.1.jar:/home/david/.m2/repository/net/runelite/client-patch/1.8.11-SNAPSHOT/client-patch-1.8.11-20220122.195337-6.jar:/home/david/.m2/repository/net/runelite/arn/http-api/1.0.0/http-api-1.0.0.jar:/home/david/.m2/repository/com/squareup/okhttp3/okhttp/3.14.9/okhttp-3.14.9.jar:/home/david/.m2/repository/com/squareup/okio/okio/1.17.2/okio-1.17.2.jar:/home/david/.m2/repository/net/runelite/discord/1.4/discord-1.4.jar net.runelite.client.RuneLite
2022-01-22 15:59:38 [main] INFO  net.runelite.client.RuneLite - RuneLite 1.8.11-SNAPSHOT (launcher version unknown) starting up, args: none
2022-01-22 15:59:40 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached vanilla client
2022-01-22 15:59:40 [Preloader] INFO  net.runelite.client.rs.ClientLoader - Using cached patched client
2022-01-22 15:59:40 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch<PHONE_NUMBER>.22
2022-01-22 15:59:40 [main] INFO  n.r.client.account.SessionManager - No session file exists
2022-01-22 15:59:41 [main] INFO  n.r.c.plugins.kourendlibrary.Library - Library is now reset
2022-01-22 15:59:41 [main] INFO  n.r.client.discord.DiscordService - Initializing Discord RPC service.
2022-01-22 15:59:42 [main] INFO  net.runelite.client.RuneLite - Client initialization took 3687ms. Uptime: 4402ms
2022-01-22 15:59:42 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,822,113,1273x1032,invalid,layout=java.awt.BorderLayout,title=RuneLite,resizable,normal,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,1273x1032,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@fa14f88,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2022-01-22 15:59:43 [pool-2-thread-1] INFO  n.r.client.discord.DiscordService - Discord RPC service is ready with user Dave.
2022-01-22 16:00:38 [OkHttp https://api.runelite.net/...] INFO  net.runelite.client.ws.WSClient - Websocket okhttp3.internal.ws.RealWebSocket@67cd0fa opened
2022-01-22 16:00:46 [pool-2-thread-1] ERROR n.r.c.e.ExternalPluginManager - Unable to download external plugins
java.io.IOException: Non-OK response code: 404
	at net.runelite.client.externalplugins.ExternalPluginClient.downloadManifest(ExternalPluginClient.java:89)
	at net.runelite.client.externalplugins.ExternalPluginManager.refreshPlugins(ExternalPluginManager.java:183)
	at net.runelite.client.util.RunnableExceptionLogger.run(RunnableExceptionLogger.java:41)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
2022-01-22 16:00:46 [Client] INFO  n.r.client.plugins.gpu.GpuPlugin - Using device: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2
2022-01-22 16:00:46 [Client] INFO  n.r.client.plugins.gpu.GpuPlugin - Using driver: 4.6.0 NVIDIA 495.46

I can start the game, set the binding to either a single key, or a modifier + a key (in my case, I've tried both Ctrl and Ctrl + s, and Alt + F11) and the binding works and I can click to highlight items (can't click with Alt + F11 because of my window manager, but it still shows hidden items).

Try unsetting grounditems.hotkey completely first

Try unsetting grounditems.hotkey completely first

I was able to reproduce the assertion error if I reset the binding by either clicking on the label and then clicking reset, or resetting the entire plugin config via the reset button at the bottom of the config panel.
Oddly enough, if I unset the binding by clicking on it as though to set a new binding, and then clicking off of it, it successfully unsets with no assertion error.
Will look into this...

Using the constant Keybind.Alt seemed to fix the assertion errors... my bad

this should use HotkeyListener

this should use HotkeyListener

By this you mean GroundItemInputListener, right? Do you suggest I split it into a GroundItemMouseAdapter extends MouseAdapter and GroundItemHotkeyListener extends HotkeyListener? Looks to me like the mouse and key parts don't interact, so that should be possible.

yes, yes

Following up as it's been a couple weeks; is there anything else I ought to do?

Usually we use anonymous classes for the hotkey listeners since it is a bit cleaner eg
	private final HotkeyListener hotkeyListener = new HotkeyListener(() -> config.toggleKeybind())
	{
		@Override
		public void hotkeyPressed()
		{
...
		}
	};

also would refrain from reaming GroundItemInputListener  since the git rename detection seems to not pick up the rename. Also don't remove licenses in the process of doing that.

added in 43e8a57cadc232c151c002cbfe5a7e4dd95e8b53


URLs are broken when copied from Slack

The symbols are copied as :icon-description: instead of the proper unicode symbol.
example:
http://:rat:.ws/
instead of
http://🐀.ws/
Can something be done to fix it? (I think no, because domains with colons are not allowed..)

You're right, is not possible to fix. Too hipster project 😄
You can use the fallback URL: http://🐀.ws/


Crashing in stage 1

Instrument
NIRSpec (Stages 1-3)
What happened?
I am running stage 1 of Eureka pipeline for the source Wasp39-b. I am using the latest version of the pipeline. It appears that it is crashing midway after halting for a long time period (more than 1 hour). The very last line I am seeing is appended below. I am not able to go any further.
Error traceback output
2023-04-04 14:40:49,549 - stpipe.Eureka_RampFitStep - WARNING - /home/amit/anaconda3/envs/eureka/lib/python3.9/site-packages/stdatamodels/validate.py:38: ValidationWarning: While validating meta.exposure.p_readpatt the following error occurred:
'NRS|NRSRAPID' does not match '^((ACQ1|ACQ2|BRIGHT1|BRIGHT2|DEEP2|DEEP8|FAST|FASTGRPAVG|FASTGRPAVG8|FASTGRPAVG16|FASTGRPAVG32|FASTGRPAVG64|FASTR1|FASTR100|FGS|FGS60|FGS8370|FGS840|FGSRAPID|FINEGUIDE|ID|MEDIUM2|MEDIUM8|NIS|NISRAPID|NRS|NRSIRS2|NRSN16R4|NRSN32R8|NRSN8R2|NRSRAPID|NRSIRS2RAPID|NRSRAPIDD1|NRSRAPIDD2|NRSRAPIDD6|NRSSLOW|RAPID|SHALLOW2|SHALLOW4|SLOW|SLOWR1|TRACK|ANY|N/A)\s*\|\s*)+$'
Failed validating 'pattern' in schema:
OrderedDict([('title', 'Readout pattern'),
('type', 'string'),
('pattern',
'^((ACQ1|ACQ2|BRIGHT1|BRIGHT2|DEEP2|DEEP8|FAST|FASTGRPAVG|FASTGRPAVG8|FASTGRPAVG16|FASTGRPAVG32|FASTGRPAVG64|FASTR1|FASTR100|FGS|FGS60|FGS8370|FGS840|FGSRAPID|FINEGUIDE|ID|MEDIUM2|MEDIUM8|NIS|NISRAPID|NRS|NRSIRS2|NRSN16R4|NRSN32R8|NRSN8R2|NRSRAPID|NRSIRS2RAPID|NRSRAPIDD1|NRSRAPIDD2|NRSRAPIDD6|NRSSLOW|RAPID|SHALLOW2|SHALLOW4|SLOW|SLOWR1|TRACK|ANY|N/A)\s*\|\s*)+$'),
('fits_keyword', 'P_READPA')])
On instance:
'NRS|NRSRAPID'
warnings.warn(errmsg, ValidationWarning)
2023-04-04 14:40:49,580 - stpipe.Eureka_RampFitStep - INFO - Extracting gain subarray to match science data
2023-04-04 14:40:49,580 - stpipe.Eureka_RampFitStep - INFO - Extracting readnoise subarray to match science data
2023-04-04 14:40:49,580 - stpipe.Eureka_RampFitStep - INFO - Using algorithm = default
2023-04-04 14:40:49,581 - stpipe.Eureka_RampFitStep - INFO - Using weighting = default
What operating system are you using?
Linux-Ubuntu
What version of Python are you running?
python 3.9.16
What Python packages do you have installed?

Eureka! Control File for Stage 1: Detector Processing
Stage 1 Documentation: https://eurekadocs.readthedocs.io/en/latest/ecf.html#stage-1
suffix              uncal
Control ramp fitting method
ramp_fit_algorithm  'default'   #Options are 'default', 'mean', or 'differenced'
ramp_fit_max_cores  'none'  #Options are 'none', quarter', 'half','all'
Pipeline stages
skip_group_scale    False
skip_dq_init        False
skip_saturation     False
skip_ipc            True    #Skipped by default for all instruments
skip_superbias      False
skip_refpix         False
skip_linearity      False
skip_persistence    True    #Skipped by default for Near-IR TSO
skip_dark_current   False
skip_jump           True
skip_ramp_fitting   False
skip_gain_scale     False
#Pipeline stages parameters
jump_rejection_threshold  4.0 #float, default is 4.0, CR sigma rejection threshold
Custom linearity reference file
custom_linearity    False
linearity_file      /path/to/custom/linearity/fits/file
Custom bias
bias_correction     None    # Bias correction options: [mean, group_level, smooth, None]
bias_group          1       # Group number options: [1, 2, ..., each]
bias_smooth_length  201     # Window length when using 'smooth' bias correction
custom_bias         False
superbias_file	    /path/to/custom/superbias/fits/file
Saturation
update_sat_flags    False   # Wheter to update the saturation flags more aggressively
expand_prev_group   False   # Expand saturation flags to previous group
dq_sat_mode         percentile # Options: [percentile, min, defined]
dq_sat_percentile   50      # Percentile of the entire time series to use to define the saturation mask (50=median)
dq_sat_columns	    [[0, 0], [0,0], [0,0], [0,0], [0,0]]  #for dq_sat_mode = defined, user defined saturated columns
Background subtraction
grouplevel_bg       True
ncpu                40
bg_y1               6
bg_y2               26
bg_deg              0
p3thresh            3
verbose             True
isplots_S1          3
nplots              5
hide_plots          True
Mask curved traces
masktrace           True
window_len          11
expand_mask         8
ignore_low          None
ignore_hi           None
Manual reference pixel correction for NIRSpec PRISM
refpix_corr         False
npix_top            8
npix_bot            8
Project directory
topdir              /home/amit/Eureka_files/JWST/
Directories relative to topdir
inputdir            uncalibrated
outputdir           Stage1
Diagnostics
testing_S1          False

"Default" ramp fitting settings
default_ramp_fit_weighting          default             #Options are "default", "fixed", "interpolated", "flat", or "custom"
default_ramp_fit_fixed_exponent     10                  #Only used for "fixed" weighting
default_ramp_fit_custom_snr_bounds  [5,10,20,50,100]    # Only used for "custom" weighting, array no spaces
default_ramp_fit_custom_exponents   [0.4,1,3,6,10]      # Only used for "custom" weighting, array no spaces

Are you certain that you are only processing the FITS files that you intend to work on? I believe you said in your previously submitted issue that you are working on NRS1 observations - if so, are the only FITS files in your input directory NRS1 files, or are there also NRS2 files or other reference files? If there are other non-science data files in your input directory, the pipeline doesn't know which files you are trying to analyze and tries to process them all.
To resolve this, either:

Delete or move any non-science files from your input directory, or
Change your suffix setting in the Stage 1 ECF to be nrs1_uncal (assuming you're trying to work on NRS1 data)

Ah, so I just realized you're looking at the ERS team's WASP-39b PRISM data (I'd assumed you were looking at G395H data for some reason). For the PRISM data, the science observations are indeed in the NRS1 files, so you've got the right files. I've recently run the G395H data myself, but haven't run the PRISM data before. I'll try running it locally to see what's up.
My best guess though is that you're running into an issue that numerous folks have encountered, where Stages 1 or 2 of the jwst pipeline (which is what Eureka's Stages 1 and 2 are built from) end up exceeding your RAM limit and your computer then kills the code to avoid your computer crashing. How much RAM do you have on the computer you're using?

Hmm, so I don't get the "Failed validating 'pattern' in schema:" warning - not sure what could be causing that issue, but perhaps it's because I downloaded those PRISM data a month ago (perhaps they updated the uncal files since then? Unlikely but not impossible). My jwst version is 1.8.3 while yours is 1.8.0 (perhaps the source of the issue), and my stdatamodels version is 0.4.3 while yours is 0.4.5 (potentially the source of the difference as well). My CRDS version is also 11.16.16 while yours is 11.16.21 (not likely to be the cause, but who knows). As long as you get sensible outputs from your reduction and fit though, I think you're probably safe to ignore this warning.
And either way, the code runs without crashing on my laptop (64 GB of RAM) so I suspect it might be a RAM issue that caused your crash earlier. NIRSpec data files are pretty large, and 8 GB of RAM would probably be too small (especially if you're doing other things like using a browser) - 12 GB may or may not be fine, 16 GB is likely enough, and 32 GB really should be safe (my 64 GB is certainly overkill for these data). And the fact that it crashed once and didn't another time suggests that your other RAM-intensive tasks probably changed between the runs (e.g. fewer Chrome tabs). If you can't get it to run the whole way through and you can't upgrade your computer's RAM or use a machine with more RAM, you could look into using cloud computing resources like Google Colab (which has ~13 GB of RAM but only 1 fairly slow CPU thread but is free), but I can't support you in doing so.

I do not know if the crashing issue was due to the RAM because I was running on a different server which has quite high memory. However I was able to run the whole thing. The outputs are however not good (maybe and issue with the inputs I have given) which is a separate issue
I tried upgrading the version of jwst by running 'pip install --upgrade git+https://github.com/kevin218/Eureka.git@main#egg=eureka[jwst]'. Now the version of JWST is 1.8.2. I hope this will resolve some of the issues I was having previously (such as 'Failed validating 'pattern' in schema')

Hmm strange, well seeing as you can't reproduce the crash I'm just going to mark this issue as closed for now. If it crashes again, please do reopen the issue. I myself haven't tried reproducing the ERS's PRISM reduction yet (I've only done G395H and haven't yet checked how close a match it is), but I'll add a note to my to-do list to publicly post ECFs that approximately reproduce all of the ERS team's results when I can find the time


Fix to allow use with Cucumber 2.0

The sauce_public_link getter/setters rely on monkey-patching Cucumber.
However, Cucumber 2.0 was a rewrite and brought a change to the module
hierarchy.
We need to select the correct hierarchy depending on what version of
Cucumber you are running.

Nice, thanks for the PR!  Can I get you to also change Gemfile to run the tests with Cuke 2.0?

Sure. I missed that.

Easy to do, the gem's in a bit of a janky state ATM >.>
On Thu, May 28, 2015 at 11:52 PM, Felix Clack<EMAIL_ADDRESS>wrote:

Sure. I missed that.
—
Reply to this email directly or view it on GitHub
https://github.com/saucelabs/sauce_ruby/pull/329#issuecomment-106711893.

--
Dylan LaceyDeveloper Evangelist
Twitter: @dylanlacey
Github: @dylanlacey
Sauce Labs http://saucelabs.com/ | Sauce blog http://sauceio.com/
Talk to us anytime: [image: Twitter] https://twitter.com/saucelabs [image:
LinkedIn] https://www.linkedin.com/company/sauce-labs [image: Google+]
https://plus.google.com/+SauceLabs_Official/posts [image: Facebook]
https://www.facebook.com/saucelabs


Added a dependency on the new noisepy-seis-io and fixed the import statements

Added a dependency on the noisepy-seis-io and fixed the import statements. Moved channel_filter_store.py and test_channel_filter_store.py to noisepy-seis-io. Created a mock MockCatalog class to be utilized in test_crosscorrelation.py

The tutorial notebooks need to be updated too, right?

Yes, I plan to do that in the next PR. For now it would be just all the changes in the import statements


avoid calling QSUTIForAnyTypeString() twice

This seems to fix #2299. At the very least, it’s slightly more efficient.

Seems reasonable

I’m glad you think so since it was released. 😄


Near-Duplicate Lipoic Acid Transport Reactions

Background
There are currently three reactions representing sodium-dependent import of lipoic acid via SLC5A6 (ENSG00000138074):
MAR01483: ATP [c] + H2O [c] + lipoic acid [e] + Na+ [e] --> ADP [c] + H+ [c] + lipoic acid [c] + Na+ [c] + Pi [c]
MAR06406: ATP [c] + H2O [c] + lipoic acid [e] + 2 Na+ [e] --> ADP [c] + H+ [c] + lipoic acid [c] + 2 Na+ [c] + Pi [c]
MAR09608: lipoic acid [e] + 2 Na+ [e] --> lipoic acid [c] + 2 Na+ [c]
Problems
SLC5A6 is a sodium-dependent transporter, and while the sodium concentration gradient it depends on to bring its various substrates into cells is established by ATP-dependent sodium transporters, SLC5A6 does not itself hydrolyze ATP (sources: 1, 2). None of the references currently associated with MAR01483 or MAR06406 found SLC5A6 to be ATP-dependent (many aren’t even relevant to this reaction), and most directly state that the stoichiometry is 2 Na+ to 1 substrate, which is consistent with MAR09068 but not MAR01483. MAR01483 and MAR06406 should be removed, since neither accurately represent the function of SLC5A6, and MAR09606 does.
Proposed changes

[x] Remove MAR01483 and MAR06406
[x] Merge annotations for MAR01483 and MAR06406 in reactions.tsv with those for MAR09608
[x] Set the references for MAR09608 to PMID:9516450;PMID:10329687;PMID:15561972;PMID:20980265

the provided evidence for SLC5A6, as well as its Uniprot annotation, support the removal of MAR01483 and MAR06406, please move on to implementation.
additionally, would suggest to associate MAR01483 with Rhea id RHEA:73379/RHEA:73380

oh yea I should probably not add that to the list of references for MAR09608, since it only provides evidence that SLC5A6 isn't ATP-dependent, which is justification to remove the other two reactions, rather than evidence supporting the existence of MAR09608; I'll update the proposed changes accordingly


nginx-ingress/values.yaml: Updated tag to 0.15.0.

What this PR does / why we need it: Update to latest nginx-ingress
@jackzampolin @mgoodness @chancez

Looks good :+1:

@jackzampolin Can we /ok-to-test and merge in?

/ok-to-test

/lgtm


Better VS Code/PSScriptAnalyzer integration

PSScriptAnalyzer can be a manual build step to ensure code quality.  For example, PSScriptAnalyzer can enforce help comments on exported module functions.  VS Code's PowerShell linting supports configuration through PSScriptAnalyzer's settings file.  Following migration to PSScriptAnalyzer/VS Code, we would probably want to standardize code with the style used by VS Code's snippets and PSScriptAnalyzer-driven autoformatting.

Just so we're on the same page... You're taking about AppVeyor and TravisCI running PSScriptAnalyzer and using it to enforce clean code/best practices?

Pretty much.  You would tune its sensitivity and suppress rules at your discretion.
I'm not very familiar with AppVeyor or TravisCI, but wherever you run Invoke-Pester $RepoRoot, you would add something resembling:
Install-Module PSScriptAnalyzer
$issues = Invoke-ScriptAnalyzer $RepoRoot -Recurse
if ($issues.Count) {
    $issues | Format-Table | Out-String | Write-Error
}


Boost/Beast and Zlib vulnerability CVE-2022-37434

Hi all from the boost-beast community,
I've noticed when assessing vulnerabilities in my repo that the current latest beast lib (on master & dev) uses ZLib 1.2.12 library which has a critical vulnerability, see ( https://github.com/advisories/GHSA-cfmr-vrgj-vqwv ).  ZLib was updated to version 1.2.13 to fix this vulnerability
Is there any plan to use this new version ?
Thanks,
Sven

zlib 1.2.12 is only built for and used in tests, and the vulnerable function (inflateGetHeader) is not called anywhere in the code.


add koordlet arch design

Signed-off-by: zwzhang0107<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@067458b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage        ?   41.25%
=======================================
  Files           ?       65
  Lines           ?     5183
  Branches        ?        0
=======================================
  Hits            ?     2138
  Misses          ?     2840
  Partials        ?      205

Flag
Coverage Δ

unittests
41.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 067458b...ce811a3. Read the comment docs.

this docs should move to koordinator.sh/docs?

this docs should move to koordinator.sh/docs?

Agreeeeed. But we should also have this doc in this repo as well.

/approve


Batch-aware loss function?

As far as I my understanding goes, the lcfcn loss works with one sample per batch. Is that really the case?
If so, how hard would it be to adapt it to more than one sample per batch?
I have tried this code:
loss = torch.mean(
    torch.Tensor(
        [
            lcfcn_loss.compute_loss(points=points[i], probs=logits[i].sigmoid())
            for i in range(points.shape[0])
        ]
    )
)

Could that work? :thinking:
Thanks for any help!

Hiya @yassineAlouini , what you suggested should work! It might be a bit slow, and the learning rate might need to be adjusted.
LCFCN does not work natively with batch sizes larger than one, mainly because the watershed algorithm does not support more than one image. If there is a Pytorch-based watershed method, then we could incorporate and make LCFCN support larger batches.
Thanks for the nice, concise code in making the code support batches larger than 1.

Indeed, watershed is probably the limiting part for now. I will have a look at a pytorch implementation and update with more details. Thanks for the quick feedback.

I have found this: https://paperswithcode.com/paper/deep-watershed-transform-for-instance. Not sure how useful it could be, I probably need some exploration to see if we can extract the watershed part of it.


refactor(getPools): use multicall3

Summary by CodeRabbit

New Features

Introduced enhancements to pool fetching functionality, improving type safety and clarity.
Implemented batch processing of contract calls via a new multicall integration for enhanced performance.
Added a new JSON definition for the aggregate function to facilitate efficient contract interactions.

Bug Fixes

Improved error handling for contract call data, ensuring graceful management of unexpected scenarios.

@andresaiello please, review.

@zeta-chain/fullstack please, review.


Move files from src folder outside and remove src folder. Closes #13

Description
Empty src folder files into root and remove src folder
Fixes #13
Developer's checklist

[x] My PR follows the style guidelines of this project
[x] I have performed a self-check on my work

If changes are made in the code:

[ ] I have followed the coding guidelines
[ ] My changes in code generate no new warnings
[ ] My changes are breaking another fix/feature of the project
[ ] I have added test cases to show that my feature works
[ ] I have added relevant screenshots in my PR

@DevTrackClub done

cool


error when use mysql database.

Description
I use mysql with loco,
when run:
cargo loco generate scaffold post title:string content:text --api.
add run:
cargo loco db migrate
it error:
--> src\controllers\auth.rs:70:39
|
70  |         tracing::info!(pid = user.pid.to_string(), "user already verified");
|                                       ^^^^^^^^^ Vec<u8> cannot be formatted with the default formatter
src\models\users.rs:48:41
|
48 |             this.pid = ActiveValue::Set(Uuid::new_v4());
|                        ---------------- ^^^^^^^^^^^^^^ expected Vec<u8>, found Uuid
|                        |
|                        arguments to this enum variant are incorrect
please fix it

@lolongjin1991 which seaorm-cli are you using?
if lower then 1.x.x can you try to install the latest?

@lolongjin1991 which seaorm-cli are you using? if lower then 1.x.x can you try to install the latest?

i use loco anh seaorm latest:
loco-cli 0.2.9
sea-orm-cli 1.0.1
please suport mysql or mariadb database.

If you'd like to contribute, we welcome pull requests!


Template support for functions from https://github.com/Masterminds/sprig

In a gh extension (written in bash) I needed to implement a fuzzy matching on the content of a label. Specifically I needed to exclude issues which has a label with project: prefix. However, I couldn't find any functions in https://github.com/cli/go-gh/blob/trunk/pkg/template/template.go or standard go templates to support startsWith.
There are quite a few string related function in https://github.com/Masterminds/sprig including the function which would help in my case:

contains
hasPrefix
hasSuffix
regexMatch

If inclusion of sprig into go-gh is not an option, would it be possible to implement at least contains in the pkg/template/template.go?

@iilyak Thanks for writing in. Is the extension that you are working on written in bash? This repo is for the go-gh Go package which can be used by gh extensions written in Go. If you want commands from gh to support these template functions this issue is more suited for the cli/cli repo where this would need to be addressed.

Is the extension that you are working on written in bash? This repo is for the go-gh Go package which can be used by gh extensions written in Go. If you want commands from gh to support these template functions this issue is more suited for the cli/cli repo where this would need to be addressed.

The cli/cli calls out into go-gh to handle template rendering here (template module is imported here). For the context I am trying to do something similar to https://github.com/samcoe/gh-triage/blob/main/gh-triage
    {{- range $index, $label := $issue.labels -}}
      {{- if not $found -}}
        {{- if eq $label.name "p1" "p2" "p3" "core" "help wanted" "tracking issue" "needs-design" "blocked" "needs-user-input" -}}
          {{- $found = true -}}
        {{- end -}}
      {{- end -}}
    {{- end -}}

However in my case all labels in the condition would be prefixed with project:. So it would look like:
    {{- range $index, $label := $issue.labels -}}
      {{- if not $found -}}
        {{- if hasPrefix $label.name "project:" -}}
          {{- $found = true -}}
        {{- end -}}
      {{- end -}}
    {{- end -}}


adding myself to colllaborators

Officially expressing my interest in helping in any way I can 👋

fyi: @nodejs/community-committee
note that the committee details are still be determined at the foundation level so there may need to be some delay on reviewing/landing this until those details are handled. @hackygolucky can likely provide more detail about process.