Disabling metric endpoint for public access does not work

Description
As described in README I was expecting to disable the metric endpoint to public access. This is not possible by setting the env DISABLE_EXTERNAL_ACCESS to True since it also requires setting a header X-Forwarded-Host in the request. As a result, the endpoint is still public because I cannot control the request.
The code for MetricsEndpoint.java
    public Response get(@Context HttpHeaders headers) {
        if (DISABLE_EXTERNAL_ACCESS) {
            if (!headers.getRequestHeader("x-forwarded-host").isEmpty()) {
                // Request is being forwarded by HA Proxy on Openshift
                return Response.status(Status.FORBIDDEN).build(); //(stream).build();
            }
        }

        final StreamingOutput stream = output -> PrometheusExporter.instance().export(output);
        return Response.ok(stream).build();
    }

Expected Behavior
Setting var DISABLE_EXTERNAL_ACCESS to True should totally disable the metrics endpoint. However, at the same time if X-Forwarded-Host is set and is valid it should be accessible to the cluster only.
Actual Behavior
The endpoint is still public.
Steps to reproduce
See Description.
May be related to https://github.com/aerogear/keycloak-metrics-spi/issues/119
Cheers!

Hi @JaniszM ,
we faced the same issue, as you mentioned above.
Do you find a way to handle the problem to avoid public access to all metrics if not load balancer, etc is used?
BR Kim

Hi @kop-hmf .
Not really, just a workaround. My Keycloak was deployed to the K8 cluster (EKS), so I used ingress controllers to handle access on the higher level.

We are also facing this issue. It would be nice to have a way to disable this endpoint.


document an example vue package

we should document the following for vue users

creating vue app (using vue cli)
creating routes
setting the base url
deployment of the app on the threebot server (location based and domain based) and setting the base url during the deployment

Current state:

created a vuejs package with the routes.
base url changes according to environment if it's development will serve on "/example" else if it's on a domain will be served at "/"

Now adding  more actors and models to verify it's working as expected

working at branch : https://github.com/threefoldtech/jumpscaleX_threebot/tree/development_vuejs_package

after merge this is the new documentation we should follow
https://github.com/threefoldtech/jumpscaleX_threebot/blob/development/ThreeBotPackages/examples/vuejs/README.md
https://github.com/threefoldtech/jumpscaleX_threebot/blob/development/ThreeBotPackages/examples/vuejs/newproject/README.md


*: make config groups optional

Previously, both the reporting and collecting groups had to
be specified in every config snippet in order for the TOML
parsing to succeed. Instead make the groups and their keys
optional, and later perform validation for keys that are
required (such as reporting.enabled) once all the snippets
have been parsed.
This implicitly makes the default collecting.level value
"minimal", which only takes effect if metrics reporting is
enabled.

Since this is still an initial MVP (just a clean-up of #1), going to merge this. Can work out any issues later on.


Tracking issue for negative impls

Note that t-lang formed consensus on a plan to stabilize a subset https://github.com/rust-lang/rust/issues/68318#issuecomment-1832355185


Error while trying to install @subwallet/wallet-connect

Describe the bug
Getting this error when trying to install  @subwallet/wallet-connect
error An unexpected error occurred: "expected hoisted manifest for \"@polkadot/extension-dapp#@polkadot/util-crypto#@polkadot/wasm-crypto#@polkadot/wasm-crypto-wasm#@polkadot/wasm-util\"".
To Reproduce
Steps to reproduce the behavior:

yarn add  @subwallet/wallet-connect

Expected behavior
The package should install

Describe the bug
Getting this error when trying to install @subwallet/wallet-connect
error An unexpected error occurred: "expected hoisted manifest for \"@polkadot/extension-dapp#@polkadot/util-crypto#@polkadot/wasm-crypto#@polkadot/wasm-crypto-wasm#@polkadot/wasm-util\"".
To Reproduce Steps to reproduce the behavior:

yarn add  @subwallet/wallet-connect

Expected behavior The package should install

Thank for your feedback.
Please try to install the latest version 0.2.6 that I have just published. Is the problem solved?


Holy grail image for the fun!

Hi we had contact on reddit.. I made a fun background for my slide for the training.. inspired by your humorous name..
use it any way you choose!

that looks super cool! What did you use to generate the image? I'll try and add it to the repo later as a background image!

krea.ai + Flux
Glad you like it!!!
Groet,
Gerwald Radsma
*Kijk hier voor een podcast /interviewover kunst en vormgeving + Ai
https://youtu.be/wUSA39_jw9E?si=fGSvPfdt0v5NSSQR *
06 46 724 792
www.gerwald.nl http://goog_1736501860
@.***
On Thu, Nov 14, 2024 at 5:01 PM Zac frulloni @.***>
wrote:

that looks super cool! What did you use to generate the image? I'll try
and add it to the repo later as a background image!
—
Reply to this email directly, view it on GitHub
https://github.com/zacfrulloni/Prompt-Engineering-Holy-Grail/issues/5#issuecomment-2476793313,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDKFAMOBFXA24FAV4WQKCL2ATCNVAVCNFSM6AAAAABRZGDOESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWG44TGMZRGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've added it to my google ads campaign :)

Nice! well done
Groet,
Gerwald Radsma
*Kijk hier voor een podcast /interviewover kunst en vormgeving + Ai
https://youtu.be/wUSA39_jw9E?si=fGSvPfdt0v5NSSQR *
06 46 724 792
www.gerwald.nl http://goog_1736501860
@.***
On Sat, Nov 16, 2024 at 2:50 PM Zac frulloni @.***>
wrote:

I've added it to my google ads campaign :)
—
Reply to this email directly, view it on GitHub
https://github.com/zacfrulloni/Prompt-Engineering-Holy-Grail/issues/5#issuecomment-2480570451,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDKFAOC4P7B6PGYGNDXTWT2A5EQNAVCNFSM6AAAAABRZGDOESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBQGU3TANBVGE
.
You are receiving this because you authored the thread.Message ID:
@.***>


Adding linux support(old shallow-backup version)

Linux support for and old version of shallow-backup

I was working on an old fork of your application :/ , now a lot of things got refactor, hope you get the idea from this PR. Sorry about it.

Thanks for contributing!
Tag me when you've updated from master and fixed all the conflicts.

@rods-honorio Any update?

I incorporated this work into shallow backup in this commit: 5926b12
I've credited you as a contributor in the Contributors file.
Thanks for helping me out.


Create service level readmes

Update the service level and add READMEs (such as this one) to help directing people to the right package in the repo. Make sure to describe all of the packages and signal which one should be used for what

@mayurid


Overhaul on Cyberpunk 2020

New background, roll templates, weapon modifiers, adjusted armor table, made names into buttons.

You are awesome.  Thanks!


Extended support for localization languages

Please expand support for different languages. At least at the level of ownCloud classic. Is it planned to add the Russian language?

Hello @Pro100x3mal we are using Transifex for our translations, you can add your translation proposals there - you support is very welcomed 😄 The link is for the webinterface of Infinite Scale and contains a couple of sources.

This is the link for the russian language https://www.transifex.com/owncloud-org/owncloud-web/language/ru/

Russian is already in the transifex project that @mmattel linked in his post (thank you martin!). Better translation coverage is very welcome.
The web ui current master already fetches russian translations and also serves them if you don't set the language in the settings UI (fallback to browser language).
I will make a PR to ocis early in January so that ocis also offers Russian as language in the settings UI. If you manage to improve the translation coverage in the meantime, the initial user experience will be better. 😎
Maybe @ScharfViktor can also help with translations when he's back from holidays.


Fix typo

Signed-off-by: MarkAckert<EMAIL_ADDRESS>

Hey @MarkAckert! Could you either close and re-open this PR with a DCO signoff, or checkout on your local branch...
git commit --amend --signoff
git push --force-with-lease origin typo-fix


Proposal of passing position property directly to alerts instead of render multiple Providers

Hi @schiehll!
I have an issue with using a new multiple providers feature.
In my current project, I have a need to render alerts in three different positions. So, my main HOC looks the next way:
const BottomRightAlertContext = createContext();
const BottomLeftAlertContext = createContext();

const NotificationProvider = withRouter(({ children }) => {
    const alertOptions = {
        offset: '25px',
        timeout: 3000,
        transition: 'scale',
        template: Alert
    };

    return (
        <AlertProvider
            position={positions.BOTTOM_RIGHT}
            context={BottomRightAlertContext}
            {...alertOptions}
        >
            <BottomRightAlertContext.Consumer>
                {bottomRight => (
                    <AlertProvider
                        position={positions.BOTTOM_LEFT}
                        context={BottomLeftAlertContext}
                        {...alertOptions}
                    >
                        <BottomLeftAlertContext.Consumer>
                            {bottomLeft => (
                                <NotificationConsumer alerts={{ bottomRight, bottomLeft }}>
                                    {children}
                                </NotificationConsumer>)
                            }
                        </BottomLeftAlertContext.Consumer>
                    </AlertProvider>)}
            </BottomRightAlertContext.Consumer>
        </AlertProvider>
    )
});
export default NotificationProvider;

Why do I pass prop alerts to NotificationConsumer which I get from Context.Consumer - I use MobX and usage of its high-order functions (etc inject, observer) limiting me in using hooks in components (I can use them in components without MobX decorators or HOF).
If to talk about withAlert HOC - it's clear, that I can't get both references to the bottomRight and the bottomLeft alert at the same time.
Also, I did not add AlertProvider with the third needed position because of making the code look extremely ugly.
My proposal is to pass property position to Provider as it used now and also add property position directly to the alert which will overwrite the Provider position. In that case if user needs to show alerts in only one position it won't be the break changes, but for multiple positions - it will become less complicated. I think there can be used an approach which I used in PR #91.
I hope that you have an idea of how to help in my situation. If you need a PoC of the idea above - I can open new PR.

Hey @besLisbeth!
I think I have a solution, but it involves installing a new dependency in your project: this one. It has only 1kb tho, so I thing it's ok.
Here's a working example:
https://codesandbox.io/s/k99o44y40o
Let me know if it helps!

Thank you a lot for showing me the package, but the question was not itself in using hooks. What I didn't like in with-hooks-support - it added the possibility to use hooks in Component's render method. It means that render stop being pure and it seems to me improper for React philosophy.
I just proposed to avoid Provider's nesting.

I think that it's not overwhelming to add property position to alert instead of rendering multiple Providers. Besides, it can be an additional feature.
I added that in my local branch. Maybe you would like to have a look?

Yeah, I know that the question was actually how to use more than one alert consumer, which is possible with the HOC, but way easier with hooks, so that's why I suggested you that solution.
Here's one way to solve it using only the withAlert HOC:
https://codesandbox.io/s/o59mq0v3qz
About the nested provider thing, are you having any real performance issue with this approach? If that's the case we can try to find alternatives.
I would prefer not to have to include more loops and logic (hurting performance a little) for all use cases only to solve an edge one.

Thank you for the feedback.
About performance issue - from my point of view multiplying the Providers and Consumers is a more inefficient way than having only one Provider and one but flexible Consumer.
I've got two flame charts - one using master branch - with two Providers, and second - from my branch with one Provider but using local alert position.

master branch

my branch

There you can see, that having multiple Providers is a more consuming way than render multiple Wrappers.
Also, if you'll look at tests in my branch, you'll see that I didn't modify any of them - I just added new tests for the new functionality, so I propose that it is fully compatible with the existing features.

Nice! That's a considerable improvement. But can you do the same comparison using only one position with both, your branch and the master one? I just wanna make sure that it doesn't hurt the most common use case too much.

Here you are - almost the same

master branch

my

Awesome!
Can you open a PR and maybe update the docs?
I will have a busy day today, but later I will try to merge and publish it.
Thank you!

Thank you, Reinaldo! 🥳


Fix for escape chars in crypto functions

Purpose
Fixes https://github.com/ballerina-platform/ballerina-lang/issues/12555
import ballerina/io;
import ballerina/crypto;

public function main() {
    string baseString = "test\n message";
    string key = "key";
    string signature = crypto:hmac(baseString, key, crypto:SHA256);
    io:println(signature);
}

Output after the fix:
EA2CD08B195434A0259B1AE32C15A7712E3FB4ABBFE82771EE97E508F3843BA7

Please explain this change. With this, existing functionality breaks, where there are new line characters (and others) in strings to sign. Now every please there are character like "", newlines etc.. they will be replaced with string values "\" and "\n".


Update the cli to support the new ACL features

Since v0.8 Consul supports a whole new set of ACLs. Consul-cli does not allow you to set up anything but service and key ACLs.
Eg:
--rule="node::write" --rule="agent::write" --rule="session::write"

Anything on Agent and Session?

Nope, I will re-open this issue.


Is there any tricks to make transitions with shared elements?

As far as I understood transitions with shared elements applying at Activity, which means that standard methods such as "setSharedElementReturnTransition(Transition transition)" and "setExitTransition(Transition transition)" couldn't be applied and I need to create some custom activity with overridden Transitions framework processing in order to use your TransitionsEverywhere library? Am I right or have I missed something?

My transitions are cannot be compatible with android activity transitions unfortunately. Now I don't have a plan for porting similar api, but maybe someday i will try it.
It's not so simple to override transition framework processing in activity. For now you can use one activity and animate scene changes inside it.


Decide what to do about unstable warnings

Currently, there are a lot of warnings about the use of unstable functionality in the code. If my understanding is correct, nothing unstable will be shipped with stable Rust versions following the release of Rust 1.0. I think it's very desirable for this library to work with stable versions, too.
The best decision for now is probably to wait. A lot of the unstable stuff might still become stable before 1.0. However, if there are still warnings shortly before the 1.0 release, we should probably attempt to replace the code in question with something else, if possible.

Yes, I agree, it's a better idea to leave them on for now. As I mentioned in a commit comment, most of them will probably go away as they get marked stable by the Rust team. And some of them are useful, e.g. I saw the warnings about the new slicing syntax. Like you said, if it gets close to 1.0 and there are still unstable warnings, they can be replaced with stable code.


[Cosmos/WIP]: add missing chain IDS

Description
TODO: add more unit tests
How to test
Run C++ unit tests
Types of changes
Bug fix #2557
Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

add simple chain id test for swift / kotlin, we can update them async later if network upgrades

add simple chain id test for swift / kotlin, we can update them async later if network upgrades

I think it will multiply the maintenance if we keep them in C++ kotlin + swift, I guess it's fine to have it in C++ as other coin tests


Add speedtest data into MOBILE reward calculation

Description:

Speedtests are performed by hotspots
Speedtest data is sent every 12 hours
If speedtest fails, the retry will happen in 30 mins
There is no limit on the number of retries. If the speedtests are not successful, no data is sent. Only last successful retry will have measurement data.
We should treat missing speedtest values in any 12h period as such that reset accumulated rolling average and receiving of new speedtest data restarts the accumulation and makes hotspot eligible for reward consideration.
All calculations should be a 6-point rolling average, except when past data is not available after reset or on joining network. Two measurement is enough to be considered for reward if more is not available, use their average. Start using rolling average when 6+ measurements are available.

To be considered for reward, hotspot need to have ALL speedtest parameters meet or exceed:
Min DL: 100 Mbps
Min UL: 10 Mbps
Max Latency: 50 ms

@maplant can you please remove the speed test calculation from the mobile verifier for now? I will give you heads up when it should be added.


Paycoin as Peercoin fork; could it merge back into Peercoin?

I have more a question than an issue actually.
As Paycoin is a fork from Peercoin, would it be technically be possible to merge 'back' into Peercoin? Mainly it would be about preserving the blockchain and maintaining the wallet addresses and coins.
I have seen some people posting their "Peercoin/paycoin combi-wallet"-address, not sure what that is? Could those operate on the same network slowly merging back into each other or something (conversion on transaction of old coins into "new" coins)?
Ofcourse the community, capital, extra features, investors, future plans etc would be an issue, but that's out of scope. Would just like to know if it is possible at all :-)

The matter of the combined wallet addresses is actually what some would call a bug.
Basically the original developers didn't change the code used to generate a paycoin address from that of peercoin so the addresses themselves are the same.
However being on 2 separate blockchains means that the coins from one blockchain won't be accepted by the other. You can essentially use the same address for both peercoin and paycoin whilst having them exist entirely separately on the 2 blockchains.
They can't be merged together because of the differences in the process block functions; peercoin still has running proof of work (which as you are aware is disabled in paycoin), PoW blocks would be instantly rejected by the paycoin network. Paycoin has primecontrollers which stake at a different rate than other nodes, this stake is checked when a node receives a transaction and subsequently any peercoin nodes would instantly refuse a prime stake transaction.
There are probably more reasons the two networks/blockchains are incompatible that I am not thinking of ATM.
To be perfectly honest it's been discussed that we should fix the paycoin addresses so that they are not the same as peercoin ones.

Please close.
I don't think merging with Peercoin is really a solution to our problems nor possible. However, this did provoke an interesting thought on moving wallet addresses away from the Peercoin format. See issue #107 for further discussion.

Agreed, further discussion on the matter can be continued in issue #107.


Fixing codecov uploading~

it wasn't finding the test executables before, now it should.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c6a09d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             master     #42   +/-   ##
========================================
  Coverage          ?   8.20%
========================================
  Files             ?       6
  Lines             ?     134
  Branches          ?     134
========================================
  Hits              ?      11
  Misses            ?     123
  Partials          ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


QFLOAT_LIST in MetaData produces real KDB+ data type not float

Enforcing the data type as QFLOAT_LIST doesn't seem to work, as the KDB+ result is real (e), not float (f). Am I missing something?
from pandas import Series,DataFrame
import numpy as np
import qpython.qconnection as qconnection
from qpython import MetaData
from qpython.qtype import QFLOAT_LIST

d = {'col' : Series([1., 2.2, 3.45, 4.6564])}
tbl = DataFrame(d)
tbl[['col']].astype(np.float)
tbl.meta = MetaData(col = QFLOAT_LIST)
q = qconnection.QConnection(host = '<IP_ADDRESS>', port = 5000, pandas = True)
q.open()
q('set', numpy.string_('tbl'), tbl)
q('meta tbl')

#      t f a
# c
# col  e

Thank you

You have to use QDOUBLE_LIST instead of QFLOAT_LIST to enforce conversion to kdb+ float f list. The QFLOAT_LIST actual enforces conversion to kdb+ real e list.
In order to maintain consistency with other interfaces (qJava, qSharp) and 3rd party code relying on these we decided to keep naming of the QFLOAT, QDOUBLE, QFLOAT_LIST and QDOUBLE_LIST type codes inline with IEEE 754 standard.

Thank you Maciej, makes sense.


SQL ingestion fails when Instance name contains single quote

see issue #21

Is this a regression of the same bug? Can you provide more details, like runbook errors or a (masked) JSON recommendations file generated in your environment that is causing this failure?

So I just added a new rule like the solution of the previous issue, only changing so that is works for the Instance name
if ($jsonObjectSplitted[$j][$i].InstanceName -ne $null) {
$jsonObjectSplitted[$j][$i].InstanceName = $jsonObjectSplitted[$j][$i].InstanceName.Replace("'", "")
}
*note: it also gave an error if there was not a Instance name so therefor I used a if statement

this is the error I got before implementing my solution:
Exception calling "ExecuteReader" with "0" argument(s): "Incorrect syntax near 's'. The floating point value '2e8562228' is out of the range of computer representation (8 bytes). Incorrect syntax near the keyword 'with'. If this statement is a common table expression, an xmlnamespaces clause or a change tracking context clause, the previous statement must be terminated with a semicolon. The label 'https' has already been declared. Label names must be unique within a query batch or stored procedure. The label 'T06' has already been declared. Label names must be unique within a query batch or stored procedure. Incorrect syntax near the keyword 'with'. If this statement is a common table expression, an xmlnamespaces clause or a change tracking context clause, the previous statement must be terminated with a semicolon.

Thanks, @UserY03 . Can you give an example of such an instance name/recommendation, so that I am able to reproduce the error?

In our company the problem creator was named: let's encrypt

Thanks for reporting this! This issue will be fixed soon and will be closed automatically once the code is merged into the main branch.

alright, thanks for the fast responses
have a great day


F#-style optional arguments don't work properly for abstract/virtual methods

Originally opened at CodePlex by @latkin
Say we have a class with 2 methods leveraging F# style optional args, otherwise identical except for one being virtual:
type TBase() =
    abstract member Foo : int option -> int
    default this.Foo(?x : int) =
        defaultArg x 100

    member this.Bar(?x : int) =
        defaultArg x 100

The non-virtual method works as expected, the virtual one behaves as if it requires an explicit option type, i.e. as if the method were declared this.Foo(x : int option)
let test1 = TBase()
test1.Foo(1)  // fails: This expression was expected to have type int option but here has type int
test1.Foo()   // fails: This expression was expected to have type int option but here has type unit
test1.Bar(1)  // works
test1.Bar()   // works

Expected; All of above work.

comments
dsyme wrote Jun 27, 2014 at 10:10 AM [x]
You declare the abstract signature like this:
abstract member Foo : ?x: int -> int
So "?x:int" = "x : int option" for the purpose of abstract members and signature checking, but they give different effects at callsites.

Given this is how things work today, I think it's reasonable to keep this behaviour: with F# members, various attributes like ? optionalness can affect callsite behaviour.

latkin wrote Jun 27, 2014 at 11:09 AM [x]
Ok, that syntax does produce desired/expected behavior.
But I would say allowing abstract signature of int option when implementation is optional is very confusing and leads to totally nonintuitive behavior, and should be considered a bug. Is there any realistic scenario where this is the true intent of the developer? Perhaps a warning here would be valuable.

The behavior at the callsite is not consistent, either, sometimes it requires an option type, sometimes optional arg:

type TBase() =
    abstract member Foo : int option -> int
    default this.Foo(?x : int) =
        defaultArg x 100

let test1 = TBase()
test1.Foo(None) // <---- TBase call requires option here

type TDerived() =
    inherit TBase()
    override this.Foo(?x : int) =
        let newDefault = defaultArg x 0
        base.Foo(newDefault)  // <---- TBase call requires int here

@latkin - since there is a language design issue/request here I think this belongs on http://fslang.uservoice.com, and perhaps a request for an F# spec clarification in https://github.com/fsharp/FSharpLangDesign/


Smallest subarray with sum greater than x

Hi, Project Maintainers. I would like to include this important algorithm in the arrays section of the code. The folder in which I'll add code is Algo-Tree/code/java. I would like you to assign this issue to me.
Question will go like:
Given an array of integers (A[])  and a number x, find the smallest subarray with sum greater than the given value.

Hey @tarun26091999.
I'm a GSSOC'21 participant .
I want to solve this issue in PYTHON3 with proper comment, indentation and test-cases.
Please assign this issue to me.

hey @tarun26091999 can you please review and merge my code in c++ i have made a PR and let me know if something is wrong.

hey maintainer I can solve this issue in java. Please assign me this.


App soft-crashes in course view

To reproduce:

Go to a course
Turn the device to the side
Switch to another tab
Switch back to the exercises tab
Turn the device back to the original side
App soft crashes and reloads into the course list

Screencast:
https://github.com/ls1intum/artemis-ios/assets/18218285/d4722490-6083-42c1-9320-5d700f4f71ac

This should be fixed with version 1.3.0, could you please confirm whether the issue is resolved for you?


MSQ ingestion: Improve error message on encountering non-long timestamp column

Description
This PR improves the error message during MSQ ingestion if we encounter a non-long timestamp column.
Sample error message shown to user:

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@Akshat-Jain can you add a test case for this? I doubt there is already one since you'd have to change the error message.

@LakshSingla Have added tests for the method.


Implement Table::ReadRows() wrapper

We need to write a brief design down for the ReadRows() and its associated wrappers.  We also need a breakdown of the tasks associated with this work as issues in this repository.

The draft/wip DD is at go/cbt-cpp-readrows, with a list of proposed subtasks at the end.

Changed the name to reflect what we are actually doing in this issue.


Really long output for Terraform and GitHub Actions

Hi!
I have a problem with my setup that I don't really know how to solve myself. My setup:

GKE Private Cluster
Terraform infrastructure repository
GitHub Actions applying changes through dflook/terraform-apply@v1 action

The issue is that output of terraform plan has 8039 lines and causes GitHub to fail to add a comment (to show the plan and make sure it matches when applying). Those lines come mostly from yaml_body_parsed in kubectl_manifests.
Do you have any idea how to trim this output? Maybe I should file this issue to kubectl provider?

Sorry I have the same problem sometimes but this issue is more related to the kubectl provider rather than the flux provider.

I see. Thanks for the input @phillebaba :+1:


Store MD5 (or other hash) of file in migration log table?

I just read @drewolson's post on Sanity Tests (http://blog.drewolson.org/sanity-tests/), and it got me wondering if it would make sense to track the MD5 (or some other hash) of the file in the table that logs the migrations that were run.
This would allow the migrations to be checked against was was actually run against the database, e.g. a commit/tag that was run, e.g. rc-1 vs rc-2 where a fix was made to the migration during testing.
The default behavior could still be to run as they do today, but give warnings for any migration files that don't match.
Maybe for those who want it, there could be a strict mode that does a check first before running any migrations to make sure everything still matches, or there is a dry run mode that would not do any migrations but just give a success or failure and any migrations that need to be reviewed.
Feel free to let me know if I am off target in my thinking of how this works, or could work.

I think it is a good starting point but md5 file digests are too brittle. Maybe someone does an operation repo-wise that removes trailing whitespace and then... oops, you are stuck with a trailing whitespace for the rest of your live. :)
We would need some sort of mechanism that allows the hash to be updated in case the file changes for external reasons.

I was kind of thinking about that as well, but wasn't sure if that would get in the way of getting the idea out there as far as the first pass idea goes to get ideas on it.
That one one of the reasons I threw out a "dry run" style check, where you could do a dry run, and either have it just report issues, or give you the opportunity to address changes like that to a migration.
Another case where I might see a migration needing to be modified post run in production, is going back and adding some indexes at the time of a table create, e.g. migration goes out to production, DBA is monitoring a table (à la New Relic or something like it) and sees there is performance issues because of a lack of index and adds one live in production, which we then want to get added back to source control and migrations, especially if there are multiple release branches because you wind up hosting different releases/instances per customer.
Just more food for thought.  I know the best way is to add the migration at the time it is realized, but I also know that things sadly don't always work out that way.

Definitely expecting this to get some hammock time and larger feedback from others. ;)

I am closing this because we can't act on it right now and we have bigger fish to catch. :) If you have any break through on how we can implement this, suggestions are welcome!


The latest code update for blender 3.6.4 is not recognized in the addon list and therefore cannot be activated

Hello, I think I followed all the steps to test this script but unfortunately there is no way to activate it from the blender 3.6 program from preferences, addon, in the list. The pulp library has been installed and updated through the command prompt in Windows 10 and also in the blender directory itself C:\Program Files\Blender Foundation\Blender 3.6\3.6\python\bin\python" -m pip install pulp.
Which is necessary to have blender3.6 installed on storage drive C: I almost never install blender, I use everyday builds in which installations are not necessary
If you could take a look and maybe tell me something I'm doing wrong or why I can't activate it if the code is correct.
Thank you for your contribution, I think this tool will be very useful, more reliable and accurate than the one Blender offers us, which in most cases wreaks havoc on the topology.

@Ciblender
I think the problem is that you don't see Testing in Add-ons in Preferences.
I have it set to appear as described in the following article and forgot about it.
https://qiita.com/SaitoTsutomu/items/5872c5e0358394360697
One solution is to follow the above article. Another is to change "TESTING" to "COMMUNITY" in __init__.py and install.
bl_info = {
    "name": "Tris to Quads Ex",  # プラグイン名
...
    "support": "TESTING",  # サポートレベル
...
}

I had set it to "TESTING" because I had not tested it enough.

@SaitoTsutomu
It currently does not work to add a hotkey.
On line 22:
bl_idname = "object.tris_convert_to_quads_ex"
switch to
bl_idname = "mesh.tris_convert_to_quads_ex"
so you can add a hotkey. I don't know if it's correct but it works.

@Ciblender I updated bl_idname.
https://github.com/SaitoTsutomu/Tris-Quads-Ex/commit/6e9692bd48252e42d101f363668737c7af426bef


Use gpt_params instead of model_params and context_params

This would expose many more params to the user and would simplify the process. The issue is i cant seem to get the bindings to generate on my system. You will need to include llama.cpp/common/common.h to use gpt_params

Yes, there are two issues:
'common.h' is internal code and should not be used as an API.
'common.h' depends on 'sampling.h', which contains C++ code in its header. Dart/FFI can't handle this, which is why you're unable to generate its binding.
I've actually created a C wrapper for it here: https://github.com/netdur/llama_common_c
Yesterday, I started new code to implement sampling in pure Dart, effectively converting all those parameters you need

Yes, there are two issues:
'common.h' is internal code and should not be used as an API. 'common.h' depends on 'sampling.h', which contains C++ code in its header. Dart/FFI can't handle this, which is why you're unable to generate its binding. I've actually created a C wrapper for it here: https://github.com/netdur/llama_common_c
Yesterday, I started new code to implement sampling in pure Dart, effectively converting all those parameters you need

That would be awesome if you could get that working. Yeah i gave it shot also but found everything but c++ strings works

@danemadsen I did initial work to implement SamplingParams and implemented repetition penalties
https://github.com/netdur/llama_cpp_dart/blob/main/lib/src/llama.dart#L204
After a quick review of other bindings, it seems that, aside from Python, all are utilizing gpt_params in their implementation. Considering this, it might be wise for me to adopt the same approach. However, this would involve compiling some C code and integrating my efforts with llama_common_c

@danemadsen I did initial work to implement SamplingParams and implemented repetition penalties
https://github.com/netdur/llama_cpp_dart/blob/main/lib/src/llama.dart#L204
After a quick review of other bindings, it seems that, aside from Python, all are utilizing gpt_params in their implementation. Considering this, it might be wise for me to adopt the same approach. However, this would involve compiling some C code and integrating my efforts with llama_common_c

If you're going to do that its basically going to make it so a custom version of llama.CPP is needed for the bindings (which is fine) but the way we are currently doing it is to bind the the library in llama_CPP_dart and then link it to the actual .so elsewhere (eg in maid)

@danemadsen I have ported all code in sampling.cpp to dart https://github.com/netdur/llama_cpp_dart/blob/main/lib/src/sampling_context.dart
this covers a lot of options, but not all of them, if you don't mind, which options should I focus on?

@danemadsen I have ported all code in sampling.cpp to dart https://github.com/netdur/llama_cpp_dart/blob/main/lib/src/sampling_context.dart
this covers a lot of options, but not all of them, if you don't mind, which options should I focus on?

I don't actually know as I rarely ever tweak them much myself but a few of my users have expressed need for min_p and top_k in the past

Hi, I'm following your work with interest. Here are the most used one ordered to control a model.
https://github.com/ggerganov/llama.cpp/pull/4882#issuecomment-1907570980

@danemadsen here I have covered those options here I will work integrate them on Llama
thank you @Solido I actually have your list as my task list I just have no idea what all those options do, I can't really test if they are working as intended.
for your edit: it really depends on your context size, this crash would happen if prompt is exceed context size, to avoid crash I need to implement keep related functions where prompt recycle previous tokens...
also you may need to call clear between prompts to avoid mixing it response.

good news https://github.com/ggerganov/llama.cpp/issues/5214

good news ggerganov/llama.cpp#5214

Thats going to be helpful

list of implemented / unimplemented parameters   https://github.com/netdur/llama_cpp_dart/commit/c51f7d8b0aa3bbdaa124e58823a3577bab143696

This is great! I'm just out of luck right now because I can't load any models.
I'm building often so surely my llama dylib is out of sync and too recent.
I'll wait for your next release/sync.


Migrating from OctoberCMS fails the first time

Winter CMS Build: "modified version of 1.1.3"
PHP Version: 7.4.3
Database Engine: sqlite

I had October 1.0.472 installed, and followed the instructions for converting to WinterCMS in the FAQ, however, I had to run composer update twice. It failed the first time:
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 7 installs, 74 updates, 15 removals
  - Removing dnoegel/php-xdg-base-dir (v0.1.1)
  - Removing giggsey/libphonenumber-for-php (8.12.11)
  - Removing giggsey/locale (1.9)
  - Removing google/recaptcha (1.2.4)
  - Removing guzzlehttp/guzzle (6.5.5)
  - Removing guzzlehttp/promises (1.4.0)
  - Removing guzzlehttp/psr7 (1.7.0)
  - Removing jackocnr/intl-tel-input (16.1.0)
  - Removing october/backend (v1.1.0)
  - Removing october/cms (v1.1.0)
  - Removing october/rain (v1.1.0)
  - Removing october/system (v1.1.0)
  - Removing psr/http-message (1.0.1)
  - Removing ralouphie/getallheaders (3.0.3)
  - Removing symfony/polyfill-php70 (v1.18.1)
  - Upgrading composer/installers (v1.9.0 => dev-main ae03311)
  - Locking composer/semver (3.2.4)
  - Upgrading doctrine/cache (1.10.2 => 1.11.0)
  - Upgrading doctrine/dbal (2.11.1 => 2.13.1)
  - Locking doctrine/deprecations (v0.5.3)
  - Upgrading doctrine/instantiator (1.3.1 => 1.4.0)
  - Upgrading egulias/email-validator (2.1.22 => 2.1.25)
  - Upgrading fzaninotto/faker (v1.9.1 => v1.9.2)
  - Upgrading laravel/framework (v6.18.43 => v6.20.27)
  - Upgrading laravel/tinker (v2.4.2 => v2.6.1)
  - Upgrading league/commonmark (1.5.5 => 1.6.2)
  - Upgrading league/csv (9.6.1 => 9.7.1)
  - Upgrading league/mime-type-detection (1.5.0 => 1.7.0)
  - Upgrading meyfa/phpunit-assert-gd (v2.0.0 => v2.1.0)
  - Upgrading monolog/monolog (2.1.1 => 2.2.0)
  - Upgrading myclabs/deep-copy (1.10.1 => 1.10.2)
  - Upgrading nesbot/carbon (2.41.3 => 2.48.0)
  - Upgrading nikic/php-parser (v4.10.2 => v4.10.5)
  - Upgrading opis/closure (3.6.0 => 3.6.2)
  - Upgrading phar-io/manifest (1.0.3 => 2.0.1)
  - Upgrading phar-io/version (2.0.1 => 3.1.0)
  - Upgrading php-parallel-lint/php-parallel-lint (v1.2.0 => v1.3.0)
  - Upgrading phpspec/prophecy (1.12.1 => 1.13.0)
  - Upgrading phpunit/php-code-coverage (7.0.10 => 7.0.14)
  - Upgrading phpunit/php-file-iterator (2.0.2 => 2.0.3)
  - Upgrading phpunit/php-timer (2.1.2 => 2.1.3)
  - Upgrading phpunit/php-token-stream (3.1.1 => 4.0.4)
  - Upgrading phpunit/phpunit (8.5.8 => 8.5.15)
  - Upgrading psr/container (1.0.0 => 1.1.1)
  - Upgrading psr/log (1.1.3 => 1.1.4)
  - Upgrading psy/psysh (v0.10.4 => v0.10.8)
  - Upgrading scssphp/scssphp (1.2.1 => v1.4.1)
  - Upgrading sebastian/code-unit-reverse-lookup (1.0.1 => 1.0.2)
  - Upgrading sebastian/comparator (3.0.2 => 3.0.3)
  - Upgrading sebastian/diff (3.0.2 => 3.0.3)
  - Upgrading sebastian/environment (4.2.3 => 4.2.4)
  - Upgrading sebastian/exporter (3.1.2 => 3.1.3)
  - Upgrading sebastian/global-state (3.0.0 => 3.0.1)
  - Upgrading sebastian/object-enumerator (3.0.3 => 3.0.4)
  - Upgrading sebastian/object-reflector (1.1.1 => 1.1.2)
  - Upgrading sebastian/recursion-context (3.0.0 => 3.0.1)
  - Upgrading sebastian/resource-operations (2.0.1 => 2.0.2)
  - Upgrading sebastian/type (1.1.3 => 1.1.4)
  - Upgrading squizlabs/php_codesniffer (3.5.6 => 3.6.0)
  - Upgrading swiftmailer/swiftmailer (v6.2.3 => v6.2.7)
  - Upgrading symfony/console (v4.4.15 => v4.4.23)
  - Upgrading symfony/css-selector (v5.1.7 => v5.2.7)
  - Upgrading symfony/debug (v4.4.15 => v4.4.22)
  - Locking symfony/deprecation-contracts (v2.4.0)
  - Upgrading symfony/dom-crawler (v5.1.7 => v5.2.4)
  - Upgrading symfony/error-handler (v4.4.15 => v4.4.23)
  - Upgrading symfony/event-dispatcher (v4.4.15 => v4.4.20)
  - Upgrading symfony/finder (v4.4.15 => v4.4.23)
  - Upgrading symfony/http-client-contracts (v2.2.0 => v2.4.0)
  - Upgrading symfony/http-foundation (v4.4.15 => v4.4.23)
  - Upgrading symfony/http-kernel (v4.4.15 => v4.4.23)
  - Upgrading symfony/mime (v5.1.7 => v5.2.7)
  - Upgrading symfony/polyfill-ctype (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-iconv (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-intl-idn (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-intl-normalizer (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-mbstring (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-php72 (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-php73 (v1.18.1 => v1.22.1)
  - Upgrading symfony/polyfill-php80 (v1.18.1 => v1.22.1)
  - Upgrading symfony/process (v4.4.15 => v4.4.22)
  - Upgrading symfony/routing (v4.4.15 => v4.4.22)
  - Upgrading symfony/service-contracts (v2.2.0 => v2.4.0)
  - Upgrading symfony/translation (v4.4.15 => v4.4.23)
  - Upgrading symfony/translation-contracts (v2.3.0 => v2.4.0)
  - Upgrading symfony/var-dumper (v4.4.15 => v4.4.22)
  - Upgrading symfony/yaml (v3.4.45 => v3.4.47)
  - Upgrading twig/twig (v2.13.1 => v2.14.5)
  - Upgrading vlucas/phpdotenv (v3.6.7 => v3.6.8)
  - Upgrading webmozart/assert (1.9.1 => 1.10.0)
  - Upgrading wikimedia/composer-merge-plugin (dev-master b6f3410 => dev-master 47be3c0)
  - Upgrading wikimedia/less.php (v2.0.0 => v3.1.0)
  - Locking winter/storm (dev-develop 0bb68ef)
  - Locking winter/wn-backend-module (dev-develop 2f45d5a)
  - Locking winter/wn-cms-module (dev-develop 33fd0a1)
  - Locking winter/wn-system-module (dev-develop b230b88)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 56 installs, 26 updates, 17 removals
  - Downloading wikimedia/composer-merge-plugin (dev-master 47be3c0)
  - Downloading composer/installers (dev-main ae03311)
  - Downloading sebastian/type (1.1.4)
  - Downloading sebastian/resource-operations (2.0.2)
  - Downloading sebastian/recursion-context (3.0.1)
  - Downloading sebastian/object-reflector (1.1.2)
  - Downloading sebastian/object-enumerator (3.0.4)
  - Downloading sebastian/global-state (3.0.1)
  - Downloading sebastian/exporter (3.1.3)
  - Downloading sebastian/environment (4.2.4)
  - Downloading sebastian/diff (3.0.3)
  - Downloading sebastian/comparator (3.0.3)
  - Downloading phpunit/php-timer (2.1.3)
  - Downloading phpunit/php-file-iterator (2.0.3)
  - Downloading sebastian/code-unit-reverse-lookup (1.0.2)
  - Downloading phpunit/php-token-stream (4.0.4)
  - Downloading phpunit/php-code-coverage (7.0.14)
  - Downloading webmozart/assert (1.10.0)
  - Downloading phpspec/prophecy (1.13.0)
  - Downloading phar-io/version (3.1.0)
  - Downloading phar-io/manifest (2.0.1)
  - Downloading phpunit/phpunit (8.5.15)
  - Downloading doctrine/cache (1.11.0)
  - Downloading doctrine/deprecations (v0.5.3)
  - Downloading fzaninotto/faker (v1.9.2)
  - Downloading symfony/polyfill-php80 (v1.22.1)
  - Downloading symfony/dom-crawler (v5.2.4)
  - Downloading symfony/css-selector (v5.2.7)
  - Downloading vlucas/phpdotenv (v3.6.8)
  - Downloading symfony/var-dumper (v4.4.22)
  - Downloading symfony/routing (v4.4.22)
  - Downloading symfony/process (v4.4.22)
  - Downloading symfony/polyfill-php73 (v1.22.1)
  - Downloading symfony/deprecation-contracts (v2.4.0)
  - Downloading symfony/mime (v5.2.7)
  - Downloading symfony/http-foundation (v4.4.23)
  - Downloading symfony/http-client-contracts (v2.4.0)
  - Downloading psr/log (1.1.4)
  - Downloading symfony/debug (v4.4.22)
  - Downloading symfony/error-handler (v4.4.23)
  - Downloading symfony/http-kernel (v4.4.23)
  - Downloading symfony/finder (v4.4.23)
  - Downloading symfony/service-contracts (v2.4.0)
  - Downloading symfony/console (v4.4.23)
  - Downloading egulias/email-validator (2.1.25)
  - Downloading opis/closure (3.6.2)
  - Downloading symfony/translation-contracts (v2.4.0)
  - Downloading symfony/translation (v4.4.23)
  - Downloading nesbot/carbon (2.48.0)
  - Downloading monolog/monolog (2.2.0)
  - Downloading league/commonmark (1.6.2)
  - Downloading laravel/framework (v6.20.27)
  - Downloading jacobbennett/laravel-http2serverpush (v4.0.2)
  - Downloading meyfa/phpunit-assert-gd (v2.1.0)
  - Downloading php-parallel-lint/php-parallel-lint (v1.3.0)
  - Downloading nikic/php-parser (v4.10.5)
  - Downloading psy/psysh (v0.10.8)
  - Downloading squizlabs/php_codesniffer (3.6.0)
  - Downloading wikimedia/less.php (v3.1.0)
  - Downloading twig/twig (v2.14.5)
  - Downloading scssphp/scssphp (v1.4.1)
  - Downloading league/csv (9.7.1)
  - Downloading laravel/tinker (v2.6.1)
  - Downloading doctrine/dbal (2.13.1)
  - Downloading winter/storm (dev-develop 0bb68ef)
  - Downloading winter/wn-backend-module (dev-develop 2f45d5a)
  - Downloading winter/wn-cms-module (dev-develop 33fd0a1)
  - Downloading composer/semver (3.2.4)
  - Downloading winter/wn-system-module (dev-develop b230b88)
  - Removing symfony/polyfill-php70 (v1.20.0)
  - Removing symfony/polyfill-php56 (v1.20.0)
  - Removing october/system (v1.0.471)
Deleting modules/system/ - deleted
  - Removing october/rain (v1.0.471)
  - Removing october/cms (v1.0.471)
Deleting modules/cms/ - deleted
  - Removing october/backend (v1.0.471)
Deleting modules/backend/ - deleted
  - Removing mtdowling/cron-expression (v1.2.3)
  - Removing leafo/scssphp (v0.8.4)
  - Removing kylekatarnls/update-helper (1.2.1)
  - Removing kriswallsmith/assetic (v1.4.0)
  - Removing jenssegers/date (v3.5.0)
  - Removing jakub-onderka/php-console-highlighter (v0.4)
  - Removing jakub-onderka/php-console-color (v0.2)
  - Removing doctrine/common (v2.7.3)
  - Removing doctrine/collections (1.6.7)
  - Removing doctrine/annotations (1.12.1)
  - Removing dnoegel/php-xdg-base-dir (v0.1.1)
  - Installing wikimedia/composer-merge-plugin (dev-master 47be3c0): Extracting archive
  - Upgrading composer/installers (v1.10.0 => dev-main ae03311): Extracting archive
  - Installing sebastian/version (2.0.1): Extracting archive
  - Installing sebastian/type (1.1.4): Extracting archive
  - Installing sebastian/resource-operations (2.0.2): Extracting archive
  - Installing sebastian/recursion-context (3.0.1): Extracting archive
  - Installing sebastian/object-reflector (1.1.2): Extracting archive
  - Installing sebastian/object-enumerator (3.0.4): Extracting archive
  - Installing sebastian/global-state (3.0.1): Extracting archive
  - Installing sebastian/exporter (3.1.3): Extracting archive
  - Installing sebastian/environment (4.2.4): Extracting archive
  - Installing sebastian/diff (3.0.3): Extracting archive
  - Installing sebastian/comparator (3.0.3): Extracting archive
  - Installing phpunit/php-timer (2.1.3): Extracting archive
  - Installing phpunit/php-text-template (1.2.1): Extracting archive
  - Installing phpunit/php-file-iterator (2.0.3): Extracting archive
  - Installing theseer/tokenizer (1.2.0): Extracting archive
  - Installing sebastian/code-unit-reverse-lookup (1.0.2): Extracting archive
  - Installing phpunit/php-token-stream (4.0.4): Extracting archive
  - Installing phpunit/php-code-coverage (7.0.14): Extracting archive
  - Installing webmozart/assert (1.10.0): Extracting archive
  - Installing phpdocumentor/reflection-common (2.2.0): Extracting archive
  - Installing phpdocumentor/type-resolver (1.4.0): Extracting archive
  - Installing phpdocumentor/reflection-docblock (5.2.2): Extracting archive
  - Installing doctrine/instantiator (1.4.0): Extracting archive
  - Installing phpspec/prophecy (1.13.0): Extracting archive
  - Installing phar-io/version (3.1.0): Extracting archive
  - Installing phar-io/manifest (2.0.1): Extracting archive
  - Installing myclabs/deep-copy (1.10.2): Extracting archive
  - Installing phpunit/phpunit (8.5.15): Extracting archive
  - Installing dms/phpunit-arraysubset-asserts (v0.1.1): Extracting archive
  - Upgrading doctrine/cache (1.10.2 => 1.11.0): Extracting archive
  - Installing doctrine/deprecations (v0.5.3): Extracting archive
  - Installing doctrine/event-manager (1.1.1): Extracting archive
  - Upgrading doctrine/inflector (1.4.3 => 2.0.3): Extracting archive
  - Installing dragonmantank/cron-expression (v2.3.1): Extracting archive
  - Installing fzaninotto/faker (v1.9.2): Extracting archive
  - Installing symfony/polyfill-php80 (v1.22.1): Extracting archive
  - Installing symfony/dom-crawler (v5.2.4): Extracting archive
  - Upgrading symfony/css-selector (v5.2.4 => v5.2.7): Extracting archive
  - Installing phpoption/phpoption (1.7.5): Extracting archive
  - Upgrading vlucas/phpdotenv (v2.6.7 => v3.6.8): Extracting archive
  - Upgrading symfony/var-dumper (v3.4.47 => v4.4.22): Extracting archive
  - Upgrading symfony/routing (v3.4.47 => v4.4.22): Extracting archive
  - Upgrading symfony/process (v3.4.47 => v4.4.22): Extracting archive
  - Installing symfony/polyfill-php73 (v1.22.1): Extracting archive
  - Installing symfony/deprecation-contracts (v2.4.0): Extracting archive
  - Installing symfony/mime (v5.2.7): Extracting archive
  - Upgrading symfony/http-foundation (v3.4.47 => v4.4.23): Extracting archive
  - Installing symfony/http-client-contracts (v2.4.0): Extracting archive
  - Upgrading psr/log (1.1.3 => 1.1.4): Extracting archive
  - Upgrading symfony/debug (v3.4.47 => v4.4.22): Extracting archive
  - Installing symfony/error-handler (v4.4.23): Extracting archive
  - Upgrading symfony/http-kernel (v3.4.47 => v4.4.23): Extracting archive
  - Upgrading symfony/finder (v3.4.47 => v4.4.23): Extracting archive
  - Installing symfony/service-contracts (v2.4.0): Extracting archive
  - Upgrading symfony/console (v3.4.47 => v4.4.23): Extracting archive
  - Downgrading egulias/email-validator (3.1.1 => 2.1.25): Extracting archive
  - Installing opis/closure (3.6.2): Extracting archive
  - Upgrading symfony/translation-contracts (v1.1.10 => v2.4.0): Extracting archive
  - Upgrading symfony/translation (v4.3.11 => v4.4.23): Extracting archive
  - Upgrading nesbot/carbon (1.39.1 => 2.48.0): Extracting archive
  - Upgrading monolog/monolog (1.26.0 => 2.2.0): Extracting archive
  - Installing league/commonmark (1.6.2): Extracting archive
  - Upgrading laravel/framework (v5.5.50 => v6.20.27): Extracting archive
  - Installing jacobbennett/laravel-http2serverpush (v4.0.2): Extracting archive
  - Installing meyfa/phpunit-assert-gd (v2.1.0): Extracting archive
  - Installing php-parallel-lint/php-parallel-lint (v1.3.0): Extracting archive
  - Upgrading nikic/php-parser (v4.10.4 => v4.10.5): Extracting archive
  - Upgrading psy/psysh (v0.9.12 => v0.10.8): Extracting archive
  - Installing squizlabs/php_codesniffer (3.6.0): Extracting archive
  - Installing wikimedia/less.php (v3.1.0): Extracting archive
  - Upgrading twig/twig (v2.14.4 => v2.14.5): Extracting archive
  - Installing scssphp/scssphp (v1.4.1): Extracting archive
  - Upgrading league/csv (8.2.3 => 9.7.1): Extracting archive
  - Upgrading laravel/tinker (v1.0.10 => v2.6.1): Extracting archive
  - Upgrading doctrine/dbal (v2.5.13 => 2.13.1): Extracting archive
  - Installing winter/storm (dev-develop 0bb68ef): Extracting archive
  - Installing winter/wn-backend-module (dev-develop 2f45d5a): Extracting archive
  - Installing winter/wn-cms-module (dev-develop 33fd0a1): Extracting archive
  - Installing composer/semver (3.2.4): Extracting archive
  - Installing winter/wn-system-module (dev-develop b230b88): Extracting archive
 10/70 [====>-----------------------]  14%    Skipped installation of bin phpunit for package phpunit/phpunit: name conflicts with an existing file
 30/70 [============>---------------]  42%    Skipped installation of bin Resources/bin/var-dump-server for package symfony/var-dumper: name conflicts with an existing file
 40/70 [================>-----------]  57%    Skipped installation of bin bin/carbon for package nesbot/carbon: name conflicts with an existing file
 50/70 [====================>-------]  71%    Skipped installation of bin bin/commonmark for package league/commonmark: name conflicts with an existing file
    Skipped installation of bin parallel-lint for package php-parallel-lint/php-parallel-lint: name conflicts with an existing file
    Skipped installation of bin bin/phpcs for package squizlabs/php_codesniffer: name conflicts with an existing file
    Skipped installation of bin bin/phpcbf for package squizlabs/php_codesniffer: name conflicts with an existing file
    Skipped installation of bin bin/lessc for package wikimedia/less.php: name conflicts with an existing file
3 package suggestions were added by new dependencies, use `composer suggest` to see details.
Package fzaninotto/faker is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
58 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

Running composer update to apply merge settings
Loading composer repositories with package information
Updating dependencies
Lock file operations: 9 installs, 0 updates, 0 removals
  - Locking giggsey/libphonenumber-for-php (8.12.23)
  - Locking giggsey/locale (1.9)
  - Locking google/recaptcha (1.2.4)
  - Locking guzzlehttp/guzzle (6.5.5)
  - Locking guzzlehttp/promises (1.4.1)
  - Locking guzzlehttp/psr7 (1.8.2)
  - Locking jackocnr/intl-tel-input (16.1.0)
  - Locking psr/http-message (1.0.1)
  - Locking ralouphie/getallheaders (3.0.3)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 9 installs, 0 updates, 0 removals
  - Downloading giggsey/locale (1.9)
  - Downloading giggsey/libphonenumber-for-php (8.12.23)
  - Downloading google/recaptcha (1.2.4)
  - Downloading ralouphie/getallheaders (3.0.3)
  - Downloading psr/http-message (1.0.1)
  - Downloading guzzlehttp/psr7 (1.8.2)
  - Downloading guzzlehttp/promises (1.4.1)
  - Downloading guzzlehttp/guzzle (6.5.5)
  - Downloading jackocnr/intl-tel-input (16.1.0)
  - Installing giggsey/locale (1.9): Extracting archive
  - Installing giggsey/libphonenumber-for-php (8.12.23): Extracting archive
  - Installing google/recaptcha (1.2.4): Extracting archive
  - Installing ralouphie/getallheaders (3.0.3): Extracting archive
  - Installing psr/http-message (1.0.1): Extracting archive
  - Installing guzzlehttp/psr7 (1.8.2): Extracting archive
  - Installing guzzlehttp/promises (1.4.1): Extracting archive
  - Installing guzzlehttp/guzzle (6.5.5): Extracting archive
  - Installing jackocnr/intl-tel-input (16.1.0): Extracting archive
1 package suggestions were added by new dependencies, use `composer suggest` to see details.
Package fzaninotto/faker is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
59 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> php artisan october:util set build
PHP Warning:  include(/path/to/winter/modules/system/providers.php): failed to open stream: No such file or directory in /path/to/winter/config/app.php on line 126
PHP Warning:  include(): Failed opening '/path/to/winter/modules/system/providers.php' for inclusion (include_path='.:/usr/share/php') in /path/to/winter/config/app.php on line 126
PHP Warning:  array_merge(): Expected parameter 1 to be an array, bool given in /path/to/winter/config/app.php on line 130
PHP Warning:  include(/path/to/winter/modules/system/aliases.php): failed to open stream: No such file or directory in /path/to/winter/config/app.php on line 144
PHP Warning:  include(): Failed opening '/path/to/winter/modules/system/aliases.php' for inclusion (include_path='.:/usr/share/php') in /path/to/winter/config/app.php on line 144
PHP Warning:  array_merge(): Expected parameter 1 to be an array, bool given in /path/to/winter/config/app.php on line 148

In Application.php line 393:

  Class 'Config' not found

Script php artisan october:util set build handling the post-update-cmd event returned with error code 1

Then the second time I ran it, it worked correctly:
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 0 updates, 0 removals
Installing dependencies from lock file (including require-dev)
Package operations: 3 installs, 0 updates, 0 removals
  - Installing winter/wn-backend-module (dev-develop 2f45d5a): Extracting archive
  - Installing winter/wn-cms-module (dev-develop 33fd0a1): Extracting archive
  - Installing winter/wn-system-module (dev-develop b230b88): Extracting archive
Package fzaninotto/faker is abandoned, you should avoid using it. No replacement was suggested.
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating autoload files
59 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> php artisan october:util set build
NOTE: This command is now deprecated. Please use "php artisan winter:version" instead.

*** Detecting Winter CMS build...
*** Detected a modified version of Winter CMS build 1.1.3.
> php artisan package:discover
Discovered Package: laravel/tinker
Discovered Package: nesbot/carbon
Package manifest generated successfully.

@multiwebinc could be some composer-merge-plugin wonkiness - I've seen some reports of the merge plugin needing two composer update runs to get everything in sync.
It sounds to me like it dropped the October dependencies after installing the Winter dependencies, which would've resulted in the modules folder being emptied because both October and Winter use that folder.
I'm not sure if there's anything we can do here beyond suggest people running composer update again should they encounter the same issue.

That would make sense.

I've updated our migration guide to make note of this issue and how to fix it if anyone else encounters it during a migration. Cheers for the report, @multiwebinc.


armeventhub namespaces client list pager responses have nil PrivateEndpointConnections

Bug Report
When using the armeventhub list pager,   PrivateEndpointConnection property is consistently returned nil across all namespaces.
Documentation indicates that the response should be generated based on the API version 2021-11-01. While the JSON object from the Azure portal, generated using this API version, does include the PrivateEndpointConnection property, this is not reflected in the SDK response.
Despite upgrading from version 1.0.0 to the latest version 1.2.0, the issue persists, with the PrivateEndpointConnection property still being returned as nil.
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/eventhub/armeventhub

@Alancere, please help to check the root cause.  Thanks

Hi @rielida , could you provide your code for creating a private endpoint so that we can better repo it.

Hello @Alancere, I'm not responsible for creating the private endpoint, I only read Azure EventHub Namespaces.
I use the armeventhub namespaces client list pager, and noticed that the PrivateEndpointConnection property is consistently empty.

Hello @Alancere, I'm not responsible for creating the private endpoint, I only read Azure EventHub Namespaces. I use the armeventhub namespaces client list pager, and noticed that the PrivateEndpointConnection property is consistently empty.

Hi @rielida, if you need to use a private endpoint, create it first.

Hi @Alancere, as I mentioned in my initial comment - The private endpoint has been set up and is visible in the Azure Portal; It's also included in the JSON object from there. However, when accessed via the SDK, it returns empty.
Please review the bug description I provided. I believe you will be able to reproduce the issue.

Hi @Alancere, as I mentioned in my initial comment - The private endpoint has been set up and is visible in the Azure Portal; It's also included in the JSON object from there. However, when accessed via the SDK, it returns empty. Please review the bug description I provided. I believe you will be able to reproduce the issue.

Sorry, that seems to be the case. Please try PrivateEndpointConnectionsClient.NewListPager

Hey @Alancere, this requires us to make a separate API call for each namespace, which is quite costly.
Any chance you could populate the PrivateEndpointConnection field in the NamespacesClient.NewListPager response? It's already included in your response structure...

@lirenhe @Alancere, any update?
Any chance you could populate the PrivateEndpointConnection field of the NamespacesClient.NewListPager response, instead of leaving it empty?

I also debugged locally, and it seems that armeventhub.PrivateEndpointConnection is not returned.

Hey @Alancere, thanks for debugging. Are you planning to populate the property?


Download link for macOS?

So you released a new version for this, but I couldn't download this cause it's non-existent. Could you please fix this?

Hi!
This is a pre-release, I am still in the process of creating an assembly for mac os and am experiencing some problems.
I will try to make a build by the release of the release or remove the link if it does not work out.

Now you can try macOS instruction https://github.com/JargeZ/vhs#for-mac-os-x


[flutter_tools] ShaderCompilerException with exit code -1073740791

Two affected clients, 8 total reports, all with the same exit code on beta/3.1.0-9.0.pre
with command: flutter run -d chrome
ShaderCompilerException: ShaderCompilerException: Shader compilation of "C:\Users\USERNAME\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag" to "build\flutter_assets\shaders/ink_sparkle.frag" failed with exit code -1073740791.
at ShaderCompiler.compileShader(shader_compiler.dart:81)
at <asynchronous gap>(async)
at writeBundle.<anonymous closure>(bundle_builder.dart:175)
at <asynchronous gap>(async)
at Future.wait.<anonymous closure>(future.dart:522)
at <asynchronous gap>(async)
at writeBundle(bundle_builder.dart:161)
at <asynchronous gap>(async)
at WebDevFS.update(devfs_web.dart:842)
at <asynchronous gap>(async)
at ResidentWebRunner._updateDevFS(resident_web_runner.dart:491)
at <asynchronous gap>(async)
at ResidentWebRunner.run.<anonymous closure>(resident_web_runner.dart:286)
at <asynchronous gap>(async)
at asyncGuard.<anonymous closure>(async_guard.dart:111)
at <asynchronous gap>(async)

From the stacktrace, this is happening at https://github.com/flutter/flutter/blame/b005a34790add6032dedaadf5842be37b8ae38c6/packages/flutter_tools/lib/src/build_system/targets/shader_compiler.dart#L77
    final List<String> cmd = <String>[
      impellerc.path,
      // TODO(zanderso): When impeller is enabled, the correct flags for the
      // target backend will need to be passed.
      // https://github.com/flutter/flutter/issues/102853
      '--flutter-spirv',
      '--spirv=$outputPath',
      '--input=${input.path}',
      '--input-type=frag',
    ];

cc @zanderso any clue as to the cause of this crash from impellerc?

Some google searching indicates that that error code corresponds to corruption of the stack. Unfortunately, we probably won't be able to track that down without the native backtrace. Hopefully someone who experiences the crash will file an issue with logs.

This now looks like (on beta/3.3.0-0.1.pre):
ProcessException: This version of %1 is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.
  Command: C:\tools\flutter\bin\cache\artifacts\engine\windows-x64\impellerc.exe --flutter-spirv --spirv=build\unit_test_assets\shaders/ink_sparkle.frag --input=C:\tools\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag --input-type=frag
at _ProcessImpl._start(process_patch.dart:401)
at Process.start(process_patch.dart:38)
at LocalProcessManager.start(local_process_manager.dart:42)
at ErrorHandlingProcessManager.start.<anonymous closure>(error_handling_io.dart:691)
at _run(error_handling_io.dart:567)
at ErrorHandlingProcessManager.start(error_handling_io.dart:690)
at ShaderCompiler.compileShader(shader_compiler.dart:72)
at writeBundle.<anonymous closure>(bundle_builder.dart:184)
at <asynchronous gap>(async)
at Future.wait.<anonymous closure>(future.dart:521)
at <asynchronous gap>(async)
at writeBundle(bundle_builder.dart:162)
at <asynchronous gap>(async)
at TestCommand._buildTestAsset(test.dart:479)
at <asynchronous gap>(async)
at TestCommand.runCommand(test.dart:318)
at <asynchronous gap>(async)
at FlutterCommand.run.<anonymous closure>(flutter_command.dart:1209)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at CommandRunner.runCommand(command_runner.dart:209)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand.<anonymous closure>(flutter_command_runner.dart:281)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at FlutterCommandRunner.runCommand(flutter_command_runner.dart:229)
at <asynchronous gap>(async)
at run.<anonymous closure>.<anonymous closure>(runner.dart:62)
at <asynchronous gap>(async)
at AppContext.run.<anonymous closure>(context.dart:150)
at <asynchronous gap>(async)
at main(executable.dart:91)
at <asynchronous gap>(async)

Could this https://github.com/flutter/flutter/issues/109627 be related?

Similar issues reported on Windows and closed in favor of this issue:
https://github.com/flutter/flutter/issues/110391
https://github.com/flutter/flutter/issues/110409

I have this bug on the release 3.3.0

flutter doctor
[√] Flutter (Channel stable, 3.3.0, on Microsoft Windows [version 10.0.22622.586], locale fr-FR)
    • Flutter version 3.3.0 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffccd96b62 (3 days ago), 2022-08-29 17:28:57 -0700
    • Engine revision 5e9e0e0aa8
    • Dart version 2.18.0
    • DevTools version 2.15.0

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\maxen\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.70.2)
    • VS Code at C:\Users\maxen\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.46.0

[√] Connected device (4 available)
    • SM G996B (mobile) • R3CR30CV61H • android-arm64  • Android 12 (API 31)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [version 10.0.22622.586]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 104.0.5112.81
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 104.0.1293.70

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

flutter run
Launching lib\main.dart on Edge in debug mode...

Waiting for connection from debug service on Edge...                   -
Oops; flutter has exited unexpectedly: "ShaderCompilerException: Shader compilation of "C:\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag" to "build\flutter_assets\shaders/ink_sparkle.frag" failed
with exit code -1073740791.

Unfortunately I don't any addition information that would be relevant

I'm using VS Code flutter doctor
[√] Flutter (Channel stable, 3.3.0, on Microsoft Windows [version 10.0.22622.586], locale fr-FR)
    • Flutter version 3.3.0 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ffccd96b62 (3 days ago), 2022-08-29 17:28:57 -0700
    • Engine revision 5e9e0e0aa8
    • Dart version 2.18.0
    • DevTools version 2.15.0

[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at C:\Users\maxen\AppData\Local\Android\sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.70.2)
    • VS Code at C:\Users\maxen\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.46.0

[√] Connected device (4 available)
    • SM G996B (mobile) • R3CR30CV61H • android-arm64  • Android 12 (API 31)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [version 10.0.22622.586]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 104.0.5112.81
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 104.0.1293.70

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

flutter run
Launching lib\main.dart on Edge in debug mode...

Waiting for connection from debug service on Edge...                   -
Oops; flutter has exited unexpectedly: "ShaderCompilerException: Shader compilation of "C:\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag" to "build\flutter_assets\shaders/ink_sparkle.frag" failed
with exit code -1073740791.

Unfortunately I don't have any addition information that would be relevant

Can you try flutter run --verbose in case there is anything useful in the verbose logs?

We are having the same issue, as a quick solution, we downgraded our flutter :)
looking for a real solution here!

As #111378 was closed, i'm gonna post my error here too so then it can help the team:
Everthing was ok when i was using flutter 3.0.5, but after the update, everytime there's an ShaderCompilerException error if i try to build my project:
flutter doctor:
[√] Flutter (Channel stable, 3.3.1, on Microsoft Windows [versÆo 10.0.22000.856], locale pt-BR)
[X] Android toolchain - develop for Android devices
    X Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[√] Chrome - develop for the web
[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[!] Android Studio (not installed)
[√] VS Code (version 1.71.0)
[√] Connected device (3 available)
[√] HTTP Host Availability

! Doctor found issues in 3 categories.

flutter build web:
 Building with sound null safety

Target web_release_bundle failed: ShaderCompilerException: Shader compilation of
"C:\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag" to "build\web\assets\shaders/ink_sparkle.frag"
failed with exit code -1073740791.

Compiling lib\main.dart for the Web...                             52,1s
Exception: Failed to compile application for the Web.

flutter build web -v:
full_log.txt
tried running on master channel and the error is still here:
Channel master, 3.4.0-19.0.pre.192
Target web_release_bundle failed: ShaderCompilerException: Shader compilation of
"C:\flutter\packages\flutter\lib\src\material\shaders\ink_sparkle.frag" to "build\web\assets\shaders/ink_sparkle.frag" failed with exit code
-1073740791.
impellerc stdout:

impellerc stderr:

Compiling lib\main.dart for the Web...                             59,8s
Exception: Failed to compile application for the Web.

@darshankawar the same code that on @Lorenzobettega pc ended with an error but here everything went ok:
ok_log.txt
my flutter doctor:
[√] Flutter (Channel stable, 3.3.1, on Microsoft Windows [versao 10.0.22000.918], locale pt-BR)
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[√] Chrome - develop for the web
[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2021.2)
[√] VS Code (version 1.71.0)
[√] Connected device (3 available)
[√] HTTP Host Availability

Like it's shader related i don't know if it's something caused by our different gpus. We both are using windows 11, and nvidea cards. Mine is the gtx 1650 and his is the gtx 1050 ti.

@christopherfujino is there any way of avoiding impeller to build on web?

Googling the exit code leads here: https://stackoverflow.com/questions/50562192/process-finished-with-exit-code-1073740791-0xc0000409-pycharm-error.
Which implicates the /GS compiler flag, which we do use in our build. I suspect the underlying issue will be easier to track down by building impellerc with ASAN enabled instead of trying to debug this on Windows directly.

@christopherfujino is there any way of avoiding impeller to build on web?

I'm curious, is this happening to you on every build, or does it only sometimes crash?
Confusingly, this is crash is unrelated to impeller (impeller does not support web), but is actually about compiling the ink_sparkle shader.

@christopherfujino on lorenzo's pc it happens every build.
Running with flutter build web or just with pressing F5.
On mine it never appeared.
We tried downgrading to 3.0.5 and upgrading again to 3.3.0 / 3.3.1, deleting flutter folder and downloading it again and clearing flutter pub folder, but every build on 3.3+ returns this error.

We tried also stopping the antivirus on his pc (Iobit malware fighter), but the error is still occurring.

Sorry for the trouble this issue is causing. We should hopefully be able to work on this soon.
In the meantime, @Macacoazul01 (and others with a reliable reproduction) it would be very helpful if you could collect a crash dump and share it with us (or analyze it yourself if you can). The top answer here has instructions on how to do that. The Windows documentation is here. Thanks!

@zanderso gonna try upgrading again to 3.3 to generate this crash dump.
Are you guys planning to release the fix on the stable channel in a hotfix or only with the future 3.5?
I'm asking this because some packages that we use launched really cool updates that are only compatible with 3.3+ (and also flutter updates between 3.0 and 3.3).

@Macacoazul01 If the fix is low-risk, I will request that it goes into a 3.3 hotfix.

@zanderso i've never edited my registry, what should i do now to insert this here:
DumpFolder = REG_EXPAND_SZ "C:\Users\loret\OneDrive\Área de Trabalho\errorLogs"
DumpCount = REG_DWORD 0x00000001
DumpType = REG_DWORD 0x00000002

added the reg:

this is the result, @christopherfujino, @zanderso
impellerc.exe.4244.zip

Windbg says:

Microsoft (R) Windows Debugger Version 10.0.22621.1 X86
Copyright (c) Microsoft Corporation. All rights reserved.

Loading Dump File [C:\Users\dnfield\Desktop\impellerc.exe.4244.dmp]
User Mini Dump File with Full Memory: Only application data is available

Symbol search path is: srv*
Executable search path is:
Windows 10 Version 22000 MP (8 procs) Free x64
Product: WinNt, suite: SingleUserTS Personal
Edition build lab: 22000.1.amd64fre.co_release.210604-1628
Machine Name:
Debug session time: Wed Sep 14 15:21:00.000 2022 (UTC - 7:00)
System Uptime: 0 days 2:21:59.414
Process Uptime: 0 days 0:00:01.000
......
This dump file has an exception of interest stored in it.
The stored exception information can be accessed via .ecxr.
(1094.c74): Security check failure or stack buffer overrun - code c0000409 (first/second chance not available)
Subcode: 0x5 FAST_FAIL_INVALID_ARG
For analysis of this file, run !analyze -v
*** WARNING: Unable to verify checksum for impellerc.exe
impellerc+0x3107e4:
00007ff7`d2f107e4 cd29            int     29h
0:000> !analyze -v
*******************************************************************************
*                                                                             *
*                        Exception Analysis                                   *
*                                                                             *
*******************************************************************************

KEY_VALUES_STRING: 1

    Key  : Analysis.CPU.mSec
    Value: 2030

    Key  : Analysis.DebugAnalysisManager
    Value: Create

    Key  : Analysis.Elapsed.mSec
    Value: 3953

    Key  : Analysis.Init.CPU.mSec
    Value: 6358

    Key  : Analysis.Init.Elapsed.mSec
    Value: 78010

    Key  : Analysis.Memory.CommitPeak.Mb
    Value: 56

    Key  : FailFast.Name
    Value: INVALID_ARG

    Key  : FailFast.Type
    Value: 5

    Key  : Timeline.OS.Boot.DeltaSec
    Value: 8519

    Key  : Timeline.Process.Start.DeltaSec
    Value: 1

    Key  : WER.OS.Branch
    Value: co_release

    Key  : WER.OS.Timestamp
    Value: 2021-06-04T16:28:00Z

    Key  : WER.OS.Version
    Value: 10.0.22000.1

FILE_IN_CAB:  impellerc.exe.4244.dmp

NTGLOBALFLAG:  0

PROCESS_BAM_CURRENT_THROTTLED: 0

PROCESS_BAM_PREVIOUS_THROTTLED: 0

APPLICATION_VERIFIER_FLAGS:  0

CONTEXT:  (.ecxr)
rax=0000000000000001 rbx=000001fdfd804388 rcx=0000000000000005
rdx=0000000000000000 rsi=00000041a592f188 rdi=00000041a592f270
rip=00007ff7d2f107e4 rsp=00000041a592f0a0 rbp=00007ff7d2f5f3e0
 r8=0000000000000000  r9=0000000000000000 r10=00000041a592f1a0
r11=00000041a592f198 r12=000001fdfd804320 r13=00000041a592f2d0
r14=00000041a592f1c8 r15=000001fdfd7fe700
iopl=0         nv up ei pl nz na pe nc
cs=0033  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00000202
impellerc+0x3107e4:
00007ff7`d2f107e4 cd29            int     29h
Resetting default scope

EXCEPTION_RECORD:  (.exr -1)
ExceptionAddress: 00007ff7d2f107e4 (impellerc+0x00000000003107e4)
   ExceptionCode: c0000409 (Security check failure or stack buffer overrun)
  ExceptionFlags: 00000001
NumberParameters: 1
   Parameter[0]:<PHONE_NUMBER>000005
Subcode: 0x5 FAST_FAIL_INVALID_ARG

PROCESS_NAME:  impellerc.exe

ERROR_CODE: (NTSTATUS) 0xc0000409 - The system detected an overrun of a stack-based buffer in this application. This overrun could potentially allow a malicious user to gain control of this application.

EXCEPTION_CODE_STR:  c0000409

EXCEPTION_PARAMETER1:<PHONE_NUMBER>000005

FAULTING_THREAD:  00000c74

STACK_TEXT:
00000041`a592f0a0 00007ff7`d2c03bf0     : 00000041`a592f2d0 00000041`a592f1c8 000001fd`fd7fe700 00007ff7`d2c043d0 : impellerc+0x3107e4
00000041`a592f0d0 00007ff7`d2c0333e     : 00000000`00000000 00000000`00000002 000001fd`fd804388 00007ff7`d2f5f3e0 : impellerc+0x3bf0
00000041`a592f100 00007ff7`d2c41aee     : 000001fd`fd816fb0 00000000`0000001a 000001fd`fd816fb0 000001fd`fd7fc250 : impellerc+0x333e
00000041`a592f140 00007ff7`d2c41582     : 000001fd`fd7f02e8 000001fd`fd8ed420 000001fd`00000002 00000000`00000026 : impellerc+0x41aee
00000041`a592f250 00007ff7`d2c3fe92     : 00000041`a592f450 000001fd`fdabe770 000001fd`fd7f9ec0 00000000`00000000 : impellerc+0x41582
00000041`a592f310 00007ff7`d2c40115     : 00000041`a592f518 00000041`a592f8f8 000001fd`fd80e4e0 00007ffd`70f476e1 : impellerc+0x3fe92
00000041`a592f490 00007ff7`d2c01616     : 00000000`00000101 00000000`00000101 00000000`0000003a 00000000`00000068 : impellerc+0x40115
00000041`a592f550 00007ff7`d2c028b0     : 00000000`00000000 00007ff7`d2f27a0e 00000000`00000000 00000041`a592fc78 : impellerc+0x1616
00000041`a592fbd0 00007ff7`d2eecab0     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : impellerc+0x28b0
00000041`a592fd30 00007ffd`6f6354e0     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : impellerc+0x2ecab0
00000041`a592fd70 00007ffd`70f2485b     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : kernel32!BaseThreadInitThunk+0x10
00000041`a592fda0 00000000`00000000     : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!RtlUserThreadStart+0x2b

STACK_COMMAND:  ~0s ; .cxr ; kb

SYMBOL_NAME:  impellerc+3107e4

MODULE_NAME: impellerc

IMAGE_NAME:  impellerc.exe

FAILURE_BUCKET_ID:  FAIL_FAST_INVALID_ARG_c0000409_impellerc.exe!Unknown

OS_VERSION:  10.0.22000.1

BUILDLAB_STR:  co_release

OSPLATFORM_TYPE:  x64

OSNAME:  Windows 10

FAILURE_ID_HASH:  {4e7d1321-e2fa-5892-b323-77f8ddd6ea94}

Followup:     MachineOwner
---------

Need to figure out the symbols there.

People who are encountering this:

What is the full path of the directory of your flutter sdk installation?
What is the full path of the directory of your project?

I elevated the priority of https://github.com/flutter/flutter/issues/50053

We should try to stop using wstring_convert...
People who are encountering this:

What is the full path of the directory of your flutter sdk installation?

C:\flutter

What is the full path of the directory of your project?

C:\Users\loret\OneDrive\Área de Trabalho\fertplan
@dnfield found something that maybe will help:
I wasn't aware that my desktop was inside one drive folder. Migrating the project to C:\Users\loret\Desktop made everything compile again.
It can be only on my case, but if
@christopherfujino
@Jasguerrero
@jmscxnulleins
@progamax
@turtlepile
@MothooX
@hung573
or
@marroquinFernando
confirm the same 'fix' solves the problem maybe it can help the team to tackle the issue

@dnfield found something that maybe will help: I wasn't aware that my desktop was inside one drive folder. Migrating the project to C:\Users\loret\Desktop made everything compile again.

And now after days trying multiple ways to solve this, the partial solution seems so simple that i my feelings are a mix of happiness and unbelief 😅

I filed https://github.com/flutter/flutter/issues/111633 so that we catch this in the future.

Summing up: portuguese breaks impeller 😂

The work around is to move your Flutter SDK and any projects to a folder path that only contains ASCII characters. We'll fix this but for now that should stop the crashes.

Re-opening this until the fix rolls to the framework

This rolled to the framework in https://github.com/flutter/flutter/commit/932b9d6809608bee175e2cc8e55d0ad78a668cf3

Re-opening as it sounds like a more robust fix will be needed

I believe @jason-simmons found another place where the same fix is needed.
The efforts to update CI to test this more robustly have also resulted in some failures.

Command line argument processing in ImpellerC was also failing when handling non-ASCII characters on Windows.
Fixed by https://github.com/flutter/engine/pull/36335

What is the full path of the directory of your project?

Renaming my programming projects folder (from Russian) to English actually helped! Thanks!

@christopherfujino Looking at the tool crash numbers, would it be helpful to also CP https://github.com/flutter/engine/pull/36335?

@christopherfujino Looking at the tool crash numbers, would it be helpful to also CP flutter/engine#36335?

Yes, I think so. I'll open a CP request.


Codegen on iOS is failing in monorepo projects

Description
As mentioned in the partner sync, the current codegen scripts contain hardcoded paths which are incorrect in monorepo projects.
To demonstrate the issue, I updated my Expo monorepo example repository. You can see a failed build in this PR with the relevant xcode logging pointing to these hardcoded paths.

Note that Android does work fine in the example repo, but I don't think we are using it. I can also see other hard-coded paths from the template.

Core issue
In React Native's native files, we use quite some scripts to generate certain things. Paths to these scripts are often hard coded. These hardcoded paths are fine, but only within the react-native package.
When hardcoding paths to other packages, like react-native-codegen, you could easily break general monorepo support. Some monorepo tools allow people to mark certain packages as "do not hoist". While this works for some cases, it's often not the best usage of monorepos as this would duplicate installations in bigger repos and consume more disk space. With that in mind, we basically can't assume the location of a package, we have have to ask Node to resolve it.
Issue from the example repo
The linked example repository uses a relatively simple structure listed below. We hoist as many packages as possible to speed up installation and consume minimal disk space.
Expo monorepo
├── apps
│   └── mobile
│       └── node_modules
│           └──<EMAIL_ADDRESS>└── node_modules
    └──<EMAIL_ADDRESS>
In this case, the path to react native codegen is incorrect, as the monorepo tool (pnpm) is installing codegen in the root node_modules folder.
Looking to npm & future
We might run into more issues in the future when the npm isolation mode RFC is accepted. It's probably worth it to think of solutions before that.

From Expo SDK 43, we switched these hard-coded paths to node module resolution references to better accommodate monorepos and custom setups. (android example, ios example)

Using a similar but slightly different solution could even help make React Native compatible with Plug'n'Play modules. Instead of using hard-coded paths, and "expect files to be installed on disk", we could ask Node or the package manager to resolve the file locations. If all of these requests go through a Plug'n'Play manager, it could download those files on the fly, and return the location. The first run will be slow, but IMHO it's worth investigating.
Version
0.70.5
Output of npx react-native info
System:
    OS: macOS 12.6
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
    Memory: 880.21 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.18.0 - ~/.nvm/versions/node/v16.18.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.18.0/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v16.18.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
    Android SDK:
      API Levels: 21, 26, 28, 29, 30, 31
      Build Tools: 26.0.3, 28.0.0, 28.0.1, 28.0.2, 28.0.3, 29.0.0, 29.0.1, 29.0.2, 29.0.3, 30.0.0, 30.0.1, 30.0.2, 30.0.3, 31.0.0, 31.0.0
      System Images: android-21 | Google APIs ARM EABI v7a, android-22 | Intel x86 Atom_64, android-22 | Google APIs ARM EABI v7a, android-22 | Google APIs Intel x86 Atom_64, android-23 | Intel x86 Atom_64, android-26 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8815526
    Xcode: 14.1/14B47b - /usr/bin/xcodebuild
  Languages:
    Java: 18.0.2 - /usr/local/opt/openjdk/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: Not Found
    react-native: 0.70.5 => 0.70.5
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
To trigger the issue:

$ git clone git@github.com:byCedric/expo-monorepo-example.git ./example
$ cd ./example
$ git checkout 0c94b0aa06e95a3ac9dcb87aff3bf3e3f767d7ac (this is the latest on main without a patch)
$ pnpm install
$ cd apps/mobile
$ npx expo prebuild --platform ios
$ xed ios
Build the app, should fail

To test the fix from PR #73

$ git clone git@github.com:byCedric/expo-monorepo-example.git ./example
$ cd ./example
$ git checkout fix/codegen-monorepo-paths (this is the latest on main without a patch)
$ pnpm install
$ cd apps/mobile
$ npx expo prebuild --platform ios
$ xed ios
Build the app, should succeed

Snack, code example, screenshot, or link to a repository
https://github.com/byCedric/expo-monorepo-example

Great writeup 💯
FWIW also happens with yarn

As a follow up, I found this piece of code that re-implements Node module resolution in Android. It's nice, but I don't think this would work for isolated modules. Implemented by no other than @ide 😄
Unfortunately, it still requires an additional path for this monorepo. That shouldn't be necessary, since react-native-codegen is technically part of a workspace in this repository (and thus should have been detected by findNodeModulePath).

The reason why I stress the isolated modules part is because Metro seems to be working on supporting the default pnpm behavior. pnpm is one of the few packages that uses this isolated modules mode by default, unless using node-linker=hoisted (specifically mentioned for React Native projects in pnpm docs). But, in order to fully use this structure, the native layer must know how to locate these packages.
A short summary of isolated modules is that only the direct dependencies are installed in the node_modules where they are required.
Project #1 - with default node_modules
├── node_modules
│   ├──<EMAIL_ADDRESS>│   ├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>└── package.json
    ├──<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
---

Project #2 - with isolated modules
├── node_modules
│   ├──<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>│       └── node_modules
│           └──<EMAIL_ADDRESS>└── package.json
    ├──<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>
In the 1st example above, the project's direct dependencies are<EMAIL_ADDRESS>and<EMAIL_ADDRESS>But, because<EMAIL_ADDRESS>has a dependency on<EMAIL_ADDRESS>the package manager installs that module to the node_modules folder.
Now in the 2nd example, only the project's direct dependencies are installed in the project node_modules folder. And the<EMAIL_ADDRESS>dependency is installed in a node_modules folder inside<EMAIL_ADDRESS>This means that "just iterating from a nested folder, checking each parent folder for node_modules/<pkg> doesn't work anymore in isolated mode. Instead, we'd have to resolve react-native first, and use that location to resolve react-native-codegen.
Just adding this here to give you a good context on what kind of fix is required to make this "properly" work with cutting edge package managers.

@cortinico, that makes sense, thanks. Might be worth defaulting in the templates to non-hardcoded paths that work out of the box in most environments, though :)
I can confirm that PR #35430 does fix the issue in my monorepo templates, including the repo I linked - made a patch to apply this change.


Output name of file is incorrect in some cases (filenames with numbers?)

I used your tool to batch process a bunch of SVGs. A few of the SVGs were output with extra underscores in their filenames.
ki-a11y.svg was output as vector_drawable_ki_a__y.svg
ki-a11y-f.svg was output as vector_drawable_ki_a__y_f.svg
So, your tool definitely didn't like using 11 in the filename...

Please update the plugin to version 1.8.2, thanks for your feedback.


Can't call api of GraphQL HOC wrapped component

Steps to Reproduce
Describe how to reproduce this issue.

Wrap a component in the graphql HOC
When rendering the HOC component, define a ref
Use the ref to attempt to call a function on the wrapped component
Function not found, because ref refers to the HOC, not the wrapped component

Expected Behavior
I should be able to call methods of GraphQL wrapped components?
Version

<EMAIL_ADDRESS><EMAIL_ADDRESS>
Use case specific detail:

I have a user signup component (USC) that is designed as a wizard using http://www.material-ui.com/#/components/stepper.
USC controls the flow between steps.
Each step, renders a GQL wrapped component.
I need each step component to implement an api (i.e. isValid(), saveStep())
I need the USC to call this api, hence my issue.

Apologies, I've just found http://dev.apollodata.com/react/higher-order-components.html#with-ref

@dcworldwide Thanks for documenting the solution. I hope it's okay if I close the issue since there's nothing we can do about it. The issue will still be searchable by others who have the same problem.


AttributeError: 'PoseEvaluator' object has no attribute 'dataset'

It seems that there is a bug here.

Hulk/core/solvers/utils/pos_tester_dev.py", line 134, in evaluate
image_id = self.dataset.name2id[image_paths[i][len(self.dataset.img_prefix):]]

According line 53 self.dataset = config.evaluation.cfg.dataset, the initialization of self.dataset is based on the test YAML file, but no corresponding configuration was found in the YAML file.

My mistake, I overlooked the previous assignment when modifying the code.