HBASE-27693 Support for Hadoop's LDAP Authentication mechanism

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 19s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 30s
master passed

+1 :green_heart:
compile
4m 40s
master passed

+1 :green_heart:
checkstyle
1m  5s
master passed

+0 :ok:
refguide
2m 39s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 16s
the patch passed

+1 :green_heart:
compile
4m 38s
the patch passed

+1 :green_heart:
javac
4m 38s
the patch passed

-0 :warning:
checkstyle
1m  5s
root: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
2m 18s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
15m 40s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

-1 :x:
spotless
0m 19s
patch has 65 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
8m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

65m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile refguide

uname
Linux e03c10d46065 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 735fb43388

Default Java
Eclipse Adoptium-11.0.17+8

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/1/yetus-general-check/output/branch-site/book.html

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/1/yetus-general-check/output/patch-site/book.html

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
178 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 59s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
compile
2m 11s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 23s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 27s
the patch passed

+1 :green_heart:
compile
1m 53s
the patch passed

+1 :green_heart:
javac
1m 53s
the patch passed

+1 :green_heart:
shadedjars
4m 22s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
272m 39s
root in the patch passed.

306m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ff058199b4d2 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a6dad700db

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/testReport/

Max. process+thread count
4741 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 22s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
1m 54s
master passed

+1 :green_heart:
shadedjars
5m 27s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 44s
the patch passed

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
349m 54s
root in the patch failed.

383m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fc63efb2abf9 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / a6dad700db

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/testReport/

Max. process+thread count
2361 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 29s
master passed

+1 :green_heart:
compile
4m 41s
master passed

+1 :green_heart:
checkstyle
1m  1s
master passed

+0 :ok:
refguide
2m 42s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

-1 :x:
spotbugs
7m 13s
root in master has 4 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 18s
the patch passed

+1 :green_heart:
compile
4m 40s
the patch passed

-0 :warning:
javac
4m 40s
root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)

-0 :warning:
checkstyle
1m  3s
root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
2m 17s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m  4s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

-1 :x:
spotless
0m  8s
patch has 15 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
7m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

64m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide

uname
Linux 2e665f9bb57d 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e5620e26a2

Default Java
Eclipse Adoptium-11.0.17+8

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/branch-site/book.html

spotbugs
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/3/yetus-general-check/output/patch-site/book.html

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
177 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m  6s
master passed

+1 :green_heart:
compile
2m 37s
master passed

+1 :green_heart:
shadedjars
5m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 56s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  5s
the patch passed

+1 :green_heart:
compile
2m 29s
the patch passed

+1 :green_heart:
javac
2m 29s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 26s
the patch passed

_ Other Tests _

-1 :x:
unit
310m 36s
root in the patch failed.

350m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6950b50f468e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e5620e26a2

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/testReport/

Max. process+thread count
2605 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 54s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 19s
master passed

+1 :green_heart:
compile
4m 42s
master passed

+1 :green_heart:
checkstyle
1m  1s
master passed

+0 :ok:
refguide
2m 13s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 26s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
4m 45s
the patch passed

-0 :warning:
javac
4m 45s
root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)

-0 :warning:
checkstyle
1m  6s
root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
2m 10s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 55s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

60m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide

uname
Linux 8b115e85e78a 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 143e9b4ff6

Default Java
Eclipse Adoptium-11.0.17+8

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/branch-site/book.html

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/4/yetus-general-check/output/patch-site/book.html

Max. process+thread count
177 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 14s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  2s
master passed

+1 :green_heart:
compile
2m 19s
master passed

+1 :green_heart:
shadedjars
5m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 42s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 56s
the patch passed

+1 :green_heart:
compile
2m 33s
the patch passed

+1 :green_heart:
javac
2m 33s
the patch passed

+1 :green_heart:
shadedjars
5m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
283m 48s
root in the patch passed.

324m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux badbf42f615c 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 143e9b4ff6

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/

Max. process+thread count
4566 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m  2s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s
master passed

+1 :green_heart:
compile
1m 36s
master passed

+1 :green_heart:
shadedjars
4m 17s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 50s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
4m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
356m 38s
root in the patch passed.

389m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 135f2c31c0f5 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 143e9b4ff6

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/testReport/

Max. process+thread count
4434 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 21s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
1m 52s
master passed

+1 :green_heart:
shadedjars
4m 24s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  4s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s
the patch passed

+1 :green_heart:
compile
1m 55s
the patch passed

+1 :green_heart:
javac
1m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  4s
the patch passed

_ Other Tests _

-1 :x:
unit
230m 46s
root in the patch failed.

260m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 508565f94864 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 143e9b4ff6

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/testReport/

Max. process+thread count
2464 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 23s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
1m 32s
master passed

+1 :green_heart:
shadedjars
4m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 47s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

+1 :green_heart:
shadedjars
4m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
400m 30s
root in the patch failed.

429m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d5ce456a8e32 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 143e9b4ff6

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/testReport/

Max. process+thread count
4473 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Failures in pipeline are not relevant to this commit.

This is only for http?

This is only for http?

No, this was tested on a HBase UI running on HTTP/HTTPS.

I don't recall how the Hadoop's authentication filter works. But I assume it ultimately uses Hadoop's LdapAuthenticationHandler to implement the core functionality?

Yes, it will instantiate AuthenticationFilter which will further use LdapAuthenticationHandler to implement core functionality.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 23s
master passed

+1 :green_heart:
compile
4m 42s
master passed

+1 :green_heart:
checkstyle
1m  2s
master passed

+0 :ok:
refguide
2m 21s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotless
0m 40s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 29s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
4m 47s
the patch passed

-0 :warning:
javac
4m 47s
root generated 2 new + 908 unchanged - 0 fixed = 910 total (was 908)

-0 :warning:
checkstyle
1m  5s
root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
2m 16s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
12m  5s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
7m 45s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

60m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle refguide

uname
Linux 22442d061c42 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94a8f319bc

Default Java
Eclipse Adoptium-11.0.17+8

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/6/yetus-general-check/output/branch-site/book.html

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/diff-compile-javac-root.txt

checkstyle
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt

refguide
https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-5144/6/yetus-general-check/output/patch-site/book.html

Max. process+thread count
177 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Addressed all the review comments. Please let me know if this looks good. Thank you @Apache9 @jojochuang @NihalJain for the review.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
compile
1m 51s
master passed

+1 :green_heart:
shadedjars
4m 51s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 36s
the patch passed

+1 :green_heart:
compile
1m 51s
the patch passed

+1 :green_heart:
javac
1m 51s
the patch passed

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
281m 51s
root in the patch passed.

313m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bbebbe9f231a 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94a8f319bc

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/testReport/

Max. process+thread count
4679 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
1m 35s
master passed

+1 :green_heart:
shadedjars
4m 19s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
1m 38s
the patch passed

+1 :green_heart:
javac
1m 38s
the patch passed

+1 :green_heart:
shadedjars
4m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 35s
the patch passed

_ Other Tests _

-1 :x:
unit
399m  8s
root in the patch failed.

427m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5144

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b02cca29b610 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 94a8f319bc

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/testReport/

Max. process+thread count
4447 (vs. ulimit of 30000)

modules
C: hbase-http . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5144/6/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

This is only for http?

No, this was tested on different HBase UIs running on both HTTP/HTTPS. It is a layer for HBase UI only.

Sorry I did not make it clear. I mean this is only for http/https, not for rpc, right?
And you have already answered that this is for UI only.

This is only for http?

No, this was tested on different HBase UIs running on both HTTP/HTTPS. It is a layer for HBase UI only.

Sorry I did not make it clear. I mean this is only for http/https, not for rpc, right?
And you have already answered that this is for UI only.

Thank you for your response. Yes, it is not for RPC.
All the review comments are addressed, could we please merge this?

+1 (non-binding)

nit: we could update jira description to capture its for web ui to avoid any confusion. Also @ydodeja365 please update release note in jira, once changes are merged.

I'm not very familiar with this area...
Anyway, you've already gotten a +1 from a committer :)

@ydodeja365 if you'd like this feature in branch-2 (HBase 2.6.0) can you submit another PR against branch-2? This feature has dependency on Hadoop so I'd like to have it run through precommit to make sure it doesn't break with Hadoop 2 runtime.

@ydodeja365 if you'd like this feature in branch-2 (HBase 2.6.0) can you submit another PR against branch-2? This feature has dependency on Hadoop so I'd like to have it run through precommit to make sure it doesn't break with Hadoop 2 runtime.

@jojochuang Raised PR for the same, there were some conflicts with this exact commit, so raised with similar changes: https://github.com/apache/hbase/pull/5213


Unable to use code sample in README.md

I was following your example code on README.md. However when running babel with this presets: presets: ['es2015', 'react'], it gives me this error:

> 43 | onChange = (event, { newValue }) => {
     |          ^
  44 |     this.setState({
  45 |       value: newValue
  46 |     });

What did I do wrong? I am new to react and eager to learn :)

To use class properties, like I do in the README, you also need:
{
  "plugins": ["transform-class-properties"]
}

Alternatively, you could use the stage-0 preset (that's what I do).

Closing for now.

thank you 👍


Clarification needed with auto provisioning docs

The documentation for autoprovisioning of edge devices needs to be updated to clarify that a derived key is not required for individual enrollments. in this section of the docs, there's no notes indicating that you can just use the symmetric key that is auto-generated when you create the individual enrollment: https://docs.microsoft.com/en-us/azure/iot-edge/how-to-auto-provision-symmetric-keys#derive-a-device-key
So if a user follows the documentation as it is currently, they would derive the symmetric key and try to use that as part of the config.yaml file which will give errors as per the following github issue:
https://github.com/Azure/iotedge/issues/1499

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 900286b7-54b4-ae6a-33c4-b54be8dee6a4
Version Independent ID: 0b791e71-7998-ee00-50a8-7a3f36d58524
Content: Autoprovision devices with DPS using symmetric key attestation - Azure IoT Edge
Content Source: articles/iot-edge/how-to-auto-provision-symmetric-keys.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@ms-vincent Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@v-stadam Can you take a look at this?

@kgremban Yes, I'm working on it

An updated version of this article has been released: https://docs.microsoft.com/azure/iot-edge/how-to-auto-provision-symmetric-keys

@ms-vincent Can you confirm that your feedback has been addressed? Thank you!

Looks good. The one comment that I would make is under "Install Edge Runtime".
Within the line "Replace the placeholder values for {scope_id}, {registration_id}, and {symmetric_key} with the data you collected earlier."
I would also clarify what the symmetric_key is. For group enrolment, it's the derived key and for individual enrolment, it's the primary or secondary DPS key.

I'm not sure if you saw the beginning of that section, which seems sufficient to cover the points you raise (and mimics the format used in the other DPS articles):
You'll need the following information when provisioning your device:

The DPS **ID Scope** value

The device **Registration ID** you created

The **Primary Key** you copied from the DPS enrollment

Tip
For group enrollments, you need each device's derived key rather than the DPS enrollment key.


Add support for optional size threshold to archive log file on startup

With that feature it's possible to archive the old file on startup when a certain size threshold is reached.
By enabling this you can ensure that the current application session is always in the same file but still have some kind of size based archival. Could also be comined with other archival options.

Thanks!

Could this code:
var length = _fileAppenderCache.GetFileLength(fileName);
if (ArchiveOldFileOnStartup && length.HasValue && length.Value > ArchiveOldFileOnStartupAboveSize)
{
    // Do some stuff
}

Be changed into this code (Avoids using _fileAppenderCache unless necessary):
if (ArchiveOldFileOnStartup)
{
   if (ArchiveOldFileOnStartupAboveSize <= 0 || ArchiveOldFileOnStartupAboveSize < _fileAppenderCache.GetFileLength(fileName))
   {
        // Do some stuff
   }
}

Could you create an isolated unit-test instead of piggy-backing on an existing one? Let the unit-test-name include the setting ArchiveOldFileOnStartupAboveSize.

Be changed into this code (Avoids using _fileAppenderCache unless necessary):

Ok will do

Could you create an isolated unit-test instead of piggy-backing on an existing one? Let the new unit-test-name include the setting ArchiveOldFileOnStartupAboveSize.

That's what I initially wanted to do but I thought I'd conform to the existing style

Please extract the new condition logic into a method called ShouldArchiveOldFileOnStartup
There is a lot of technical debt in the NLog unit tests for the FileTarget. But it is hard work to cleanup. But will be easier if not piling more on top :)
Sent from my Sony Xperia
---- Sam13 wrote ----
Be changed into this code (Avoids using _fileAppenderCache unless necessary):
Ok will do
Could you create an isolated unit-test instead of piggy-backing on an existing one? Let the new unit-test-name include the setting ArchiveOldFileOnStartupAboveSize.
That's what I initially wanted to do but I thought I'd conform to the existing style
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HAYPNXI5HJ64KFGRWLQ43X5VA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIPWBWI#issuecomment-572481753, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HDFDWU2235DE4JY74DQ43X5VANCNFSM4KEIIGAA.

There is a lot of technical debt in the NLog unit tests for the FileTarget. But it is hard work to cleanup. But will be easier if not piling more on top :)

I fully agree - all findings addressed

https://travis-ci.org/NLog/NLog/builds/634731645?utm_source=github_status&utm_medium=notification
NLog.UnitTests.Targets.PlainFileTargetTests.DateArchive_SkipPeriod(timeKind: Local, archivePeriod: Hour, includeDateInLogFilePath: True, includeSequenceInArchive: True) [FAIL]
      Assert.Equal() Failure
                          ↓ (pos 10)
      Expected:<PHONE_NUMBER>10.0.txt
      Actual:<PHONE_NUMBER>09.0.txt
                          ↑ (pos 10)

seems to be a flaky unit test and not related to my changes

FYI Restarted Travis

You are right but I think every combination with two properties is not that complicated with proper documentation.
Another option I can think of is to leave ArchiveOldFileOnStartup away since this is basically the same than ArchiveOldFileOnStartupAboveSize = 0
Disabling ArchiveOldFileOnStartup then means to unset this option.
Since you are the maintainers please define on how it should behave and I'll try to implement that.

Oops this is still open. It still propose: https://github.com/NLog/NLog/pull/3755#issuecomment-576874258

Oops this is still open. It still propose: #3755 (comment)

You just said that the PR was fine as it is:

Well that was a refactor proposal and not a functional change?

Well that was a refactor proposal and not a functional change?

No it was a functional change, that implemented the proposed change

Was it the code for https://github.com/NLog/NLog/pull/3755#issuecomment-576874258? I don't see that.

Guess my proposal was too complex then :)

I changed it to https://github.com/NLog/NLog/pull/3755#issuecomment-576874258
Also I made the FIleApenderCache mockable (we should really do more mocking). But a bit afraid of the performance concequence. (interface call vs class class). What do you think @snakefoot ?

Think the introduction of _archiveOldFileOnStartup makes it even more confusing. Think my suggestion is better.

No opinion on the IFileApenderCache?

Think it is the wrong place to mock. Lots of action happening in the file appender cache. Maybe a IFileAppender interface and then inject a factory that returns a mock of the interface
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
No opinion on the IFileApenderCache?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HHN6WB4S3B4UOWNVE3RBOGO7A5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK54J2A#issuecomment-582730984, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HBWASWWFMMZRFKESVDRBOGO7ANCNFSM4KEIIGAA.

Think it is the wrong place to mock. Lots of action happening in the file appender cache.

I also checked that, but the appendar cache is doing File stuff (FileInfo) and that is exactly what needs to be "mocked out".

@snakefoot I you don't think we should performance test this, then I like to merge it. So please let me know if you're OK with that :)

I don't use any of the features. But I still think your latest change makes the code even more confusing. Anyway it will not hurt performance.
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
@snakefoothttps://github.com/snakefoot I you don't think we should performance test this, then I like to merge it. So please let me know if you're OK with that :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HAI25RW7EQOAKG7C6TRBSF4VA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBBFEA#issuecomment-583144080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HH4QKB5W43PINM6VILRBSF4VANCNFSM4KEIIGAA.

Now if having configured archive at startup and archive at startup when above size. Then it will always archive independent of size. This will be confusing. Again my propasal is better.
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
@snakefoothttps://github.com/snakefoot I you don't think we should performance test this, then I like to merge it. So please let me know if you're OK with that :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HAI25RW7EQOAKG7C6TRBSF4VA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBBFEA#issuecomment-583144080, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HH4QKB5W43PINM6VILRBSF4VANCNFSM4KEIIGAA.

I think there should be a IFileSystem interface that FileTarget should share with FileAppenderCache.
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Think it is the wrong place to mock. Lots of action happening in the file appender cache.
I also checked that, but the appendar cache is doing File stuff (FileInfo) and that is exactly what needs to be "mocked out".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HFXMWSE67YBYSTB6SDRBSFFNA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBAUWA#issuecomment-583141976, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HCGP5YVEDCPAUPWX6DRBSFFNANCNFSM4KEIIGAA.

But maybe this PR is not the right PR for rewriting FileTarget to support mocking.
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
Think it is the wrong place to mock. Lots of action happening in the file appender cache.
I also checked that, but the appendar cache is doing File stuff (FileInfo) and that is exactly what needs to be "mocked out".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HFXMWSE67YBYSTB6SDRBSFFNA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBAUWA#issuecomment-583141976, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HCGP5YVEDCPAUPWX6DRBSFFNANCNFSM4KEIIGAA.

But maybe this PR is not the right PR for rewriting FileTarget to support mocking.

Maybe, but we need tests.

Now if having configured archive at startup and archive at startup when above size. Then it will always archive independent of size. This will be confusing.

True, will fix that

Now if having configured archive at startup and archive at startup when above size. Then it will always archive independent of size. This will be confusing.

Fixed!

But maybe this PR is not the right PR for rewriting FileTarget to support mocking.

We could refactor this in another PR. It's all internal.

Find it strange to write mocking code that you know upfront needs to be rewritten right after.  The mock should cover all file-access and just half.
But yes now archive on startup when above size will work as expected.
Sent from my Sony Xperia
---- Julian Verdurmen wrote ----
But maybe this PR is not the right PR for rewriting FileTarget to support mocking.
Maybe, but we need tests.
Now if having configured archive at startup and archive at startup when above size. Then it will always archive independent of size. This will be confusing.
True, will fix that
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/3755?email_source=notifications&email_token=ACXZ7HD3UXNJLZWQUR36ZB3RB5D6DA5CNFSM4KEIIGAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELF7AQI#issuecomment-583790657, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HC3BNHCX2NUYVWI46DRB5D6DANCNFSM4KEIIGAA.

Any ETA when this gets merged and released?

Will try to merge this weekend and release next week. Release is a bit dependent of the docs (if it's up-to-date already)

Find it strange to write mocking code that you know upfront needs to be rewritten right after.

Well I have no time now to make it perfect.
So I will merge this for now.


Favorite project updates

Shift fetch projects to projectsdashboard
return favorited project, or return projects[0] if no favorite


Multi-version Support?

Hi Matt, awesome work and a very enjoyable write-up, thank you.
I've looked over the code briefly, and it's very neatly structured and compartmentalised. None of the dependencies look like no-gos for Python3, and the file-handling seems to be compartmentalised by PIL/Pillow.
So, I'm wondering why this is Python2 only? If it's merely personal preference and all it would take are some modernisations from __future__ and some print function calls (or six, if it came to that), would you accept pull requests to make this work on both?

Sure, happy to accept pull requests, especially if you tell me also how to test w/ Python 3 on my machine (I'm a Python 2 user, but it's probably past time to upgrade...)

Think we got this one settled in 0701e13724a7d7087d9eb711cc0be6e387620711

\o/ Great news, thanks!


Add type field to ReconciliationOperations

https://github.com/kyma-incubator/reconciler/issues/801

/retest

/retest

closing in favor of #908


Fix issue that caused the Reloading Package progress indicator to be stuck

If any method in reloadPacakge threw, the Reloading Package progress indicator was stuck.
Also, change the message of the indicator to SourceKit-LSP: Reloading Package to make it easier to differentiate from status generated by the VS Code extension.
Fixes #1050
rdar://122899093

@swift-ci Please test


Reorder travis targets to better parallelise

Changing parallelisation of targets to give unit tests more individual time. E.g. run that drove this –

/cc @robskillington @richardartoul @jskelcy

Coverage decreased (-0.08%) to 77.641% when pulling b4d3a253be379da9e15ae851dc23b6c58259cdfd on prateek/misc/better-parallelize-ci into a68d85cb2aa4526a6307badf1ed72fd3a32b3788 on master.


vpptrace.sh enhancements

Add netcat to the vswitch prod container so vpptrace.sh can be ran
inside it.
Allow vpptrace.sh to work on a unix socket without sudo.
Add proper variable quoting in vpptrace.sh.

Coverage increased (+0.3%) to 77.005% when pulling 4de096ef26a2e991842009a9dc46d0e42ed3cd14 on nbartos:vpptrace into 3f78ee4e33b35f9dc9e207de12aa7326698a0cb9 on contiv:master.


Add ex-/import of the database

It would be nice to have a ex-/import feature. Or at least the possibility to backup the app via Helium. This would help when setup a new ROM. I know this can be a security problem, but maybe make it optional and only available for a new database. Create a message which inform the user when first time run the app, that this feature can only get activated now or never.

I just backuped/restored my phone with oandbackup and was very surprised when I found that all my keys in otp-authenticator are gone, even when all of data/net.bierbaumer.otp_authenticator was restored. Please provide a ways of backup the data and show the key for the internal encryption.

I just attempted to backup with oandbackup as well. It never seems to finish for me. This would be really helpful.

This would be very helpful as I have no chance to get my keys out of an old phone in case of a device change. Is it planned to implement this feature soon?

+1 on this, especially in light of issue #8.

This repo seems to be unmaintained, but there is a active fork, which is also in F-Droid: https://github.com/kckrinke/onetimepad

@mueller-ma Thanks fella!

In case anyone comes across this thread, kckrinke OTP is no longer on Fdroid.
A maintained "fork" of this OTP app can be found here: https://github.com/andOTP/andOTP


Remove duplicated message when no upgrades

[x] Have you signed the Contributor License Agreement?
[ ] Are you working against an Issue?

This is kind of a follow up of https://github.com/microsoft/winget-cli/pull/1982, continuing the cleanup. But this is a bit different because it also changes one message.
This is how it was before:
➜ winget upgrade --all
No installed package found matching input criteria.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.
No applicable update found.

This is how it is now:
➜ winget upgrade --all
No applicable update found.
10 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

Please let me know what you think.
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


Associated Paper

Thanks for publishing your code. Can you also publish your submitted paper on arXiv or something? I am very interested in your work and would like to read more about it. Thanks a lot!

Thank you for your interest in my paper.
The paper has been submitted for review at IROS 2022. Therefore, we will consider whether to publish the paper after the review results are announced.
Thanks for the nice suggestion :)


Explain why "All" filter is disabled for some genes

For some long genes (ex. SYNE1), the variant filter is limited to Missense/LoF and/or LoF. However, no indication is given of why the filter(s) are disabled. This makes it look like there's a bug and the filter isn't working.
http://gnomad-beta.broadinstitute.org/gene/SYNE1

This button should have a tooltip explaining why it's disabled or at least a style indicating that it is disabled.
The code for determining which filter(s) are available is also split between the variant reducer and the settings UI.
https://github.com/macarthur-lab/gnomadjs/blob/3816f2be5f10e4d2ae6e8430ca19695f3637e614/packages/redux-variants/variants.js#L331-L339
https://github.com/macarthur-lab/gnomadjs/blob/3816f2be5f10e4d2ae6e8430ca19695f3637e614/projects/gnomad/src/Settings.js#L59-L112

After #129, the consequence filters are no longer disabled for large genes/regions.


Why minus 2.19 in ctnet_head?

Hi hustllz,
There is a 'minus 2.19' in ctnet_head and dynamic_mask_head, how to understand this operation?
Best regards,
Jiahua

https://github.com/xingyizhou/CenterNet/issues/826


ensembl-3875 Problem showing "Resequencing alignements

The code expects yes/no rather than on/off
We've got two tickets regarding this that came from Ensembl #467028, Ensembl #467306 and Ensembl #466232

In master everything is fine. Needs to be merged to .79 only

Master is fine and release/79 is fine, but release/80 has 'on' instead of 'yes'.

Can you please merge it to release/80 as well?

Done: d2c04741

Thank you!

Hi guys, the ticket has been reopened. I've just checked modules/EnsEMBL/Web/Component/Location/SequenceAlignment.pm on branch 80 and it has back 'on' instead of 'yes'.
Any ideas why it was changed? Can you please change it back?

This seems to have been reverted by Anne on 28th May (4fbbef7). There seems to be some confusion over this as we're all going round chasing our tail turning things to yes->on->yes. I've done the same with our Vega plugin (where some things broke). From her comment, Anne seems to have some info on what should be going on from her commit comment, but I'm not sure either way myself. I can't find tickets, etc, associated with that latter commit. Can this wait for Anne to come back and we can talk about getting this nailed down once and for all?

I'll apply a temporary fix then and we'll wait till Anne is back. Thanks.


Docs: new guides section isn't being linted

We lint the code snippets in the SDK guides, but the new Guides section uses a different path for the snippets that isn't being included in that linting. This is creating some inconsistency in code formatting.
With the playground embeds though, it's no longer a direct reference between the snippet file and what you see on the page. I assume the playground embeds are created from the snippets, @vikram-dagger please correct me if I'm wrong.

We lint the code snippets in the SDK guides,

Can you please point me to this code?

With the playground embeds though, it's no longer a direct reference between the snippet file and what you see on the page. I assume the playground embeds are created from the snippets, @vikram-dagger please correct me if I'm wrong.

Correct, documented at https://github.com/dagger/dagger/blob/main/docs/STYLE_GUIDE.md#api-playground-embeds

Can you please point me to this code?

Sure!
https://github.com/dagger/dagger/blob/b56aee2fe0875c1e3b5b47372e91afbee158c9ce/internal/mage/docs.go#L46-L61
In Python:
https://github.com/dagger/dagger/blob/b56aee2fe0875c1e3b5b47372e91afbee158c9ce/internal/mage/sdk/python.go#L50-L60
Where poe lint-docs is:
https://github.com/dagger/dagger/blob/b56aee2fe0875c1e3b5b47372e91afbee158c9ce/sdk/python/pyproject.toml#L82-L83
https://github.com/dagger/dagger/blob/b56aee2fe0875c1e3b5b47372e91afbee158c9ce/sdk/python/pyproject.toml#L107-L108
Note: I actually started to fix this locally but didn't finish, to deal with other priorities.
Go seems fine because the linting is done for all go files in the repo:
https://github.com/dagger/dagger/blob/b56aee2fe0875c1e3b5b47372e91afbee158c9ce/internal/mage/engine.go#L124-L131
Maybe we should do the same for the others. In Python, the linter has slightly different rules for docs, but that should be fine if their path is preserved.

With the playground embeds though, it's no longer a direct reference between the snippet file and what you see on the page. I assume the playground embeds are created from the snippets, @vikram-dagger please correct me if I'm wrong.

Correct, documented at https://github.com/dagger/dagger/blob/main/docs/STYLE_GUIDE.md#api-playground-embeds

From that guide:

Currently supported file extensions are .go, .ts, .js, .python.

First of all, the extension for python is wrong (.py). Secondly, snippets for nodejs have been using .mjs. Is that supported? Or even .mts?

With the playground embeds though, it's no longer a direct reference between the snippet file and what you see on the page. I assume the playground embeds are created from the snippets, @vikram-dagger please correct me if I'm wrong.

Correct, documented at https://github.com/dagger/dagger/blob/main/docs/STYLE_GUIDE.md#api-playground-embeds

Nice, I forgot about that. 🙂
From that guide:

Currently supported file extensions are .go, .ts, .js, .python.

First of all, the extension for python is wrong (.py). Secondly, snippets for nodejs have been using .mjs. Is that supported? Or even .mts?

.py and .mjs are both supported. .mts is not. I've updated the guide with this info - thanks for pointing it out! https://github.com/dagger/dagger/pull/4874

Is linting the snippets in docs sufficient to ensure that they run successfully?
Linting is the right way of catching programmatic and stylistic errors, but not testing that the code actually runs. Maybe linting is enough for now, but I am pretty sure that we want some type of integration tests that would show failures - maybe in GitHub Actions - when the code fails. Running these snippets and ensuring that they all exit with 0 would be sufficient.

I know that my comment is not on topic. I am mostly continuing a conversation that we started with @vikram-dagger on March 28th, 2023.

Yes, two separate things. Linting is fast and easy, brings more consistency to the examples and helps us follow good practices for users to copy.
As for tests, that was discussed but don't remember when or where. What I remember is that Andrea (I think) alluded that it was a burden on CI (time and cost continually increasing when adding more docs) and maintainability (keeping tests up to date with the code).
On maintainability, with CUE it was a bit easier since it's declarative, now it's a much harder problem with the multiple languages. As for simply running a script and checking exit code, it's not that simple. For example, many guides use external services that need to be set up with proper keys (GCR, AWS...).
So I believe consensus (at least for now) is that it's not worth to automatically test the documentation snippets.

@vikram-dagger can we close this issue?

It's not done.

This was fixed in https://github.com/dagger/dagger/pull/5351

I realized Node.js isn't fixed yet.


feat(notification): update width to fixed

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

:tada: This PR is included in version 2.0.0-alpha.13 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Command -> litgpt download openlm-research/open_llama_13b gives error: Unrecognized arguments: openlm-research/open_llama_13b

⚡ ~ litgpt download openlm-research/open_llama_13b
usage: litgpt [options] download [-h] [-c CONFIG] [--print_config[=flags]] [--repo_id REPO_ID] [--access_token ACCESS_TOKEN]
[--tokenizer_only {true,false}] [--convert_checkpoint {true,false}] [--dtype DTYPE]
[--checkpoint_dir CHECKPOINT_DIR] [--model_name MODEL_NAME]
error: Unrecognized arguments: openlm-research/open_llama_13b

We recently updated the CLI, and it looks like the LitGPT version you are using requires the old --checkpoint_dir. I can make a new version release today for PyPI to address that. In the meantime, please upgrade LitGPT by
pip install litgpt==0.4.0.dev0

Let me know if it works or doesn't work.

Yeah it is working , One more issue is when running this -> i# 3) Use the server (in a separate session) import requests, json response = requests.post(      "http://<IP_ADDRESS>:8000/predict",      json={"prompt": "Why people don't check cctv footage of all poling booths in INDIA to check if any malpractices occured? Is this not a big threat to democracy? "} ) print(response.json()) am getting output as "{'detail': 'Request timed out'}"

Please feel free to report back and reopen if the issue still persists.


Paket issue?: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

Hi,
I just updated (today 11/12/2019) to the latest Docker image, and I can't get paket to update/install or do seemingly anything...?
I've been using your BaGet for several months now, and I have updated my Docker image at least once before today -and I had no issues.

Here is what Paket is telling me:
C:\Testing123>.\.paket\paket.exe install
Paket version 5.196.2
Resolving packages for group Main:
Trial1 (NuGet.GetVersions) did not yield any results, trying again.
   http://<IP_ADDRESS>:9011/v3/packagemycompany.netutility/index.json?semVerLevel=2.0.0
Performance:
 - Resolver: 525 milliseconds (1 runs)
    - Runtime: 99 milliseconds
    - Blocked (retrieving package versions): 425 milliseconds (1 times)
 - Average Request Time: 7 milliseconds
 - Number of Requests: 3
 - Runtime: 1 second
Paket failed with
-> Unable to retrieve package versions for 'mycompany.netutility'
   -- CLOSED --

   -- OPEN ----
      mycompany.netutility  (from C:\Testing123\paket.dependencies)
-> Request 'http://<IP_ADDRESS>:9011/v3/packagemycompany.netutility/index.json?semVerLevel=2.0.0' finished with error
-> JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.

The packagemycompany.netutility does not look quite right -should it be:
package/mycompany.netutility
?
Thanks,
George H.
11/12/2019 5:47pm ET

Hi Loic,
sorry, my bad -it was a Paket issue.
I upgraded Paket, and the issue was resolved.

WAS:
Paket <IP_ADDRESS>
TO:
Paket <IP_ADDRESS>
Thanks,
George H.
11/13/2019 8:47am ET


pagination support

Does jdsl support classical spring pagination? Or is there any way how to achieve the result for pagination?

we are already support pageQuery for spring data jpa
you can use SpringDataQueryFactory.pageQuery method.


Web scrape UI

Here's the params we need in the UI:

Requires @jkmin3  to re-write the stay_on_baseurl_page in main.py and web-scrape.py thanks!

Baseurl is now good!

timeout 1-5, max depth 1-500, max urls 1-500

Maybe lower the max depth to around 50? There's no need for crazy depth and I think it might make it more confusing for users and go off on unrelated URLs. @KastanDay what do you think max should be for depth?

Certain users really need huge scrapes, like AIFARMS. So I think max 500 is okay for now.


Loop audio to allow for longer text crawl

You can barely do a paragraph before it cuts off

Was developed to have the same time as the movie have, and has the death star at the end. You need to write your intro in the same length as the movies intros.

Perhaps we should have an indicator for roughly how many lines are remaining until the speed of the text has to be increased?

@ama4tf @Simon-Tang I've tested on Firefox and Chrome, it works well for me. Can you test if it's improved for longer texts now?
Thanks


BaseNERRunner not calling superclass init

it should! the preprocessing breaks because self.increment is not defined (this is done in the superclass init).
https://github.com/machinalis/iepy/blob/develop/iepy/preprocess/ner/base.py#L13

you are right!


does buildkite store artifacts?

If I don't setup my own google cloud storage bucket or AWS bucket, does buildkite store artifacts for me? If so, what are the limits?

Yup, we sure do. Presently there aren't any limits, but we'll likely impose some this year.


chore(tests_integration): make it possible to create multiple sequencers in test

This change is

#2177  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Changing overcommitment on a host updates other hosts too

Bug Report
Version of OpenNebula

[ ] 5.2.2
[ ] 5.4.0
[ ] 5.4.1
[ ] 5.4.2
[ ] 5.4.3
[ ] 5.4.4
[ ] 5.4.5
[ ] 5.4.6
[ ] 5.4.7
[ ] 5.4.8
[ ] 5.4.9
[X] 5.4.10
[ ] Development build

Component

[ ] Authorization (LDAP, x509 certs...)
[ ] Command Line Interface (CLI)
[ ] Contextualization
[ ] Documentation
[ ] Federation and HA
[ ] Host, Clusters and Monitorization
[ ] KVM
[ ] Networking
[ ] Orchestration (OpenNebula Flow)
[ ] Packages
[ ] Scheduler
[ ] Storage & Images
[X] Sunstone
[ ] Upgrades
[ ] User, Groups, VDCs and ACL
[ ] vCenter

Description
Updating overcommitment on one host updates the value on other hosts too
Expected Behavior
Overcommitment changed only on the host
Actual Behavior
Overcommitment on the other hosts is updated wit same value
How to reproduce

OpenNebula with two active hosts
change the CPU overcommitment value on first host
hit the update button
check the CPU overcommitment on the other host

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

To clarify the observed behavior ( on 5.4.11)
Updating host A CPU reservation after a fresh login is working ok
Updating the CPU reservation on another host B is updating both host B and host A...


fix(ui): handle long text in BuilderSelect

The BuilderSelect trigger has overflow issues with long text containing breakable content. The trick was just a missing white-space: nowrap rule.
I also took the opportunity to add a tooltip to the BuilderSelect's trigger.

I add this issue 2 weeks ago. It would be awesome to have the popup on the list after 3 seconds to know what is the handler. do you think it would be possible ?

Good point @FabienArcellier . I thought about it, it's easy as adding an attribute data-writer-tooltip on each option. The issue is, the tooltip will be displayed every time.
I would like to display the tooltip only if the element overflow. Maybe adding a new prop data-writer-tooltip-strategy="overflow".
I can give a try, it should not be that hard to implement this logic here
https://github.com/writer/writer-framework/blob/4e956b15bf49c511c44936b4ddc359ea2d780759/src/ui/src/builder/BuilderTooltip.vue#L72-L76

@FabienArcellier , I implemented it https://github.com/writer/writer-framework/pull/706/commits/2a2f2d2e461188e721c6f7af93448402ecd8f392 . So we display the tooltip in BuilderSelect only if the element overflow
https://github.com/user-attachments/assets/5dc25e10-7cfc-4612-b4c5-044522290818


Added window fragment tools

planned to add GlassWindow fragment support when added

Please take care to make difference in vehicle glass name and generic glass name (we'll need to support object breakable glasses too in fragments)

Closed temporarily


Remove unused view

This seems a legacy file which has only been updated twice: https://github.com/git/git-scm.com/commits/master/app/views/doc/_example.html.erb
Introduced on https://github.com/git/git-scm.com/commit/6261265f543f426814d23ee4a5bb52ccf1d5ba6c#diff-bc27c53685d46b28ca24adc2d76024e4, referenced only on one file, that no longer references it: https://github.com/git/git-scm.com/blob/master/app/views/doc/man.html.erb
The reference seems to have been deleted here: https://github.com/git/git-scm.com/commit/8839ec5eedc8cf1790b77cf7c04029c69eab7e0d#diff-d1cc6f187ac98a7750fe996910ff00e8

Yeah, I couldn't find any other spots that try to render it. I think it really was just a placeholder that's long since been unused. Thanks for getting rid of it.


Adding a log that shows which scene is rendered

Basically the title.
This is useful when rendering several scenes at once (with -a)
Very easy PR! Feel free :D

Is something like this ok?

or should I put them in separate logger.info calls?

My idea was to put this also at the beginning of the rendering process. But like this is good to me :D

Ok I'll open a PR soon then.

Done in #236.


Added navigation tablets

ref #428
There is an issue related to the position of the navigation while resizing(>mobile) on all pages except Tips View.
Feedback would be appreciated.

I think we don't need to use isMobileNavigationHidden at all, also pixel-aspect-ratio is not very universal.


Fix Program Managers uploading pngs to events

When Program Managers attempt to upload png posters to events they are thrown a "system error". Investigate where it is coming from and fix.

 Fix Program Managers uploading pngs to events #786

This was a known bug when Ala and I were creating the file upload feature. I knew it would come back to bite us. Will work on it.


*1 *2 *3 support

(tests
  (bindI (fmapI submissions >needle) pureI)
  (capI *1) := [9 10 11])

this works at the REPL but not in test blocks. It is a contrived example but seems important when tests get messy

lets us avoid introducing needless defs
lets us avoid mixing logic with value-extraction (when testing higher order primitives)

(tests
  (def >>as (unsequenceI (pureI [9 10 11])))
  (map capI (capI >>as)) := [9 10 11]

  ; logic
  (->> >>as
    (fmapI (fn [>as]
             (->> >as
               (map (fn [>a]
                      (fmapI identity #_:dustingetz/email >a)
                      ))))))
  ; value extraction
  (capI *1)
  (mapv capI *1) := [9 10 11]
  )

Another example, testing a macro:
(tests
  (compile-hfql* '{(inc >needle) (inc %)})
  (eval *1)
  (capI *1) := 3)

Here is a multi-stage test – we want to test the compiler result, and then test that the result evaluates. (Note the expectation uses _ to avoid equality on higher order values)
  (compile-hfql* '[{:dustingetz/gender [{(shirt-size gender) [:db/id :db/ident]}]}])
  := '(let [% (fmapI (partial hf-nav :dustingetz/gender) %)
            gender %]
        {(quote :dustingetz/gender)
         (let [% (fmapI shirt-size gender) % %]
           {(quote (shirt-size gender))
            #:db{:id    (fmapI (partial hf-nav :db/id) %),
                 :ident (fmapI (partial hf-nav :db/ident) %)}})})
  (eval *1)
  := '#:dustingetz{:gender {(shirt-size gender) #:db{:id _, :ident _}}}

Fixed in https://github.com/TristeFigure/minitest/pull/3/commits/28c88c00e4386b68f7f750d1262072a8ad132b16

Fixed in https://github.com/TristeFigure/minitest/pull/3/commits/28c88c00e4386b68f7f750d1262072a8ad132b16


Use q with a float array ?

Hi, I am working on making a vst that performs some equalization tasks by reducing two frequency peaks and increasing two others.
I work in a run function that receives a const float **inputs and a const float **outputs and the uint32_t frame count, i'm not sure how i'm supposed to go about modifying this signal with q
I tried
cycfi::q::audio_channels<const float> inputChannels(inputs,sizeof(const float) * frames,frames);
cycfi::q::audio_channels<float> outputChannels(outputs,sizeof(float) * frames,frames);
cycfi::q::audio_stream stream;
stream.process(inputChannels,outputChannels);

which seems to compile but I am not sure yet if it is the right way to use these methods, I also am not sure about the way to go to do some EQ on the signal

It seems that you already got the answer to this question in Discord?
Generically, say you have a filter f instantiated in your class, you can mix it with the original signal s by adding to boost or subtracting to cut. The factor you apply g is your gain or cut:
   out = s + f(s) * g;

assume f to be to identity, meaning it simply returns the signal s passed to it. Then you can see that:
   out = s + s * g;

if for example, g is 1, then you get out = s + s * 1, hence s is doubled.
If for example g is -1, then you get out = s + s * -1, or 0 (full attenuation, s will cancel out).
Now, imagine that a bandpass filter is used, Then the same operation above applies, but only applied to the frequencies that the bandpass returns. Ditto for lowpass and highpass.
Makes sense?


cert-manager not auto renewing certificates

Describe the bug:
Noticed the cert-manager is not auto renewing certificates anymore. I constantly get emails from Let's Encrypt about "this and this domain certificate will expire in 10 days". Certificate example:
$ kc get certificates -n my-namespace subdomain -o yaml
apiVersion: cert-manager.io/v1
kind: Certificate
[...]
spec:
  commonName: subdomain.domain.tld
  dnsNames:
  - subdomain.domain.tld
  issuerRef:
    kind: ClusterIssuer
    name: letsencrypt-prod-route53
  secretName: subdomain
status:
  conditions:
  - lastTransitionTime: "2021-09-08T08:35:29Z"
    message: Certificate is up to date and has not expired
    observedGeneration: 1
    reason: Ready
    status: "True"
    type: Ready
  notAfter: "2021-11-08T20:28:59Z"
  notBefore: "2021-08-10T20:29:01Z"
  renewalTime: "2021-10-09T20:28:59Z"

As we can see it was due for renewal 2021-10-09 but that obviously did not happen.
The cert-manager pods:
$ kc get pods -n cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-5d7f97b46d-pxsgx              1/1     Running   0          78d
cert-manager-cainjector-69d885bf55-bkv8t   1/1     Running   0          78d
cert-manager-webhook-8d7495f4-m4bbm        1/1     Running   0          78d

and not a single mention about any attempt about this certificate renewal in the cert-manager pod log:
$ kc logs -n cert-manager cert-manager-5d7f97b46d-pxsgx | grep subdomain
I0908 08:35:29.540017       1 conditions.go:182] Setting lastTransitionTime for Certificate "subdomain" condition "Ready" to 2021-09-08 08:35:29.5400074 +0000 UTC m=+2260531.834473020

Expected behaviour:
Expect the certificates to get auto renewed bt cert-manager.
Environment details::

Kubernetes version: 1.20.7
Cloud-provider/provisioner: EKS v1.20.7-eks-d88609
cert-manager version:  quay.io/jetstack/cert-manager-controller:v1.4.0
Install method: kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.4.0/cert-manager.yaml

/kind bug

Hi @icicimov ,
There was a bug in renewal flow that was fixed in #4399, looking at your cert's renew after/renew before dates it probably would have been affected.
Try to upgrade to v1.4.4, v1.5.4 or v1.6.0, hopefully that will fix it.

Hi @irbekrm .
Thanks for the quick response. I upgraded to v1.5.4 and i can see the cert got renewed:
$ kc get secrets -n my-namespace subdomain -o jsonpath="{.data.tls\.crt}" | base64 -d | openssl x509 -noout -dates
notBefore=Oct 30 11:05:27 2021 GMT
notAfter=Jan 28 11:05:26 2022 GMT

Lets hope this is not just an effect of the upgrade and restart but looks good , fingers crossed :-)

Glad it's got renewed.

Lets hope this is not just an effect of the upgrade and restart

You're right in that it would have got renewed just because the pod got restarted, since at that point it syncs all certs and this one was already past the renewal time.
It does look like you were affected by the same renewal bug we fixed recently, so hopefully it will renew as normal from now on.


Satellite 1 D dimensions option

Have the option to load Satellite data with X and Y dimesions of 1 dimension . This is how the current nowcasting Satellite consumer is set up. The more upto date satelilte data used for training PP, has2 diminsion coordaite data. I.e the Image is a sqaure.
Perhaps this can be done in the Satellite consumer load bit, and the 1D coordates can be exapnded to 2D using
xx, yy = np.meshgrid(x, y, indexing='ij')

Do you mean for OSGB coordinates? Or the geostationary ones? Geostationary ones should be 1D, and I believe are? OSGB ones, if they are 1D, then are wrong, as the satellite pixels don't map to a regular OSGB grid, and have to already be 2D. If they are 1D, and we use meshgrid, then they will result in pixels being off by potentially a few hundred miles.

https://github.com/openclimatefix/ocf_datapipes/blob/main/ocf_datapipes/load/satellite.py#L79
Yea for the OSGB coordinates.
The current Satellite consumer as 1D OSGB coordinates.
Perhaps we need then to save both 1D and 2D OSGB coordinates in the satellite consumer, this would mean the current model doesnt break

Hmmm, okay, the ones in the consumer should also be 2D, they are set here: https://github.com/openclimatefix/Satip/blob/bc27f11849aa5f18c306cdbecffbd78f37e47438/satip/utils.py#L293-L306 as 2D coordinates, referencing the geostationary ones.

ah ok, then maybe i was thinking of the NWP ones, ok, ill adjust the pytest accordingly and close this issue


Add implementation to wrap ASP binaries.

Add wrappers for ASP stereo commands. The base Stereo class wraps the
'stereo' command itself, while the subclass StereoSGM is changed to use
'parallel_stereo'.

Do we always need to do parallel stereo with SGM/MGM ? If the image size fits computationally solvable corr-tile-size, then normal stereo should suffice and we will be able to avoid the blending operation. Maybe a flag can be added at some point, but good for now :)

Do we always need to do parallel stereo with SGM/MGM ? If the image size fits computationally solvable corr-tile-size, then normal stereo should suffice and we will be able to avoid the blending operation. Maybe a flag can be added at some point, but good for now :)

Are you mostly using non parallel stereo, when choosing SGM/MGM?

Do we always need to do parallel stereo with SGM/MGM ? If the image size fits computationally solvable corr-tile-size, then normal stereo should suffice and we will be able to avoid the blending operation. Maybe a flag can be added at some point, but good for now :)

Are you mostly using non parallel stereo, when choosing SGM/MGM?

Depending on use case. I use parallel when with DG, or other bigger image sizes. For Skysat, I just use stereo.

@ShashankBice - I made the change as you suggested. stereo is now the default for SGM and you can make it parallel by passing that option and specify the number of processes.


Add Bill Summary + Tags to Bill Details Page

Problem
Now that we have LLM-generated summaries and tags for bills, we want to make that information available in the bill details page so that users can be better informed about the contents of proposed legislation.
Success Criteria

Implement the design in the linked Figma, adding the following to the Bill Details Page:

The LLM-generated Smart Summary (if present)
All LLM-generated sub-tags (if any are present)

Likely a new re-usable UI component for displaying a tag

A warning that some content has been generated using AI

This new content should be toggleable by a new flag in FeatureFlags (something like showLLMFeatures) to control the rollout

Additional Links

Figma: https://www.figma.com/design/aDuao2uPLjk5FkYwyC5Yrw/Full---LLM-Summaries-%2B-Tags-(2024)?node-id=2853-2550&t=bMak8XSabhhyvHu6-4
Test bill with the new LLM-generated fields:

I'm interested in taking on this issue.  I'm currently looking for:

access to the Figma (request submitted)

a quick review of where I can locate the object or whatever return from the database that contains the LLM summary so I can figure out how to break that down and implement the design


Add support for AMD iGPUs, such as gfx1103.

What are you trying to do?
No response
How should we solve this?
No response
What is the impact of not solving this?
No response
Anything else?
No response

We're tracking iGPU support via #2637

@dhiltgen  the AMD iGPU780M could work on ROCm with extra settings in Linux. See my pull request https://github.com/ollama/ollama/pull/5426


components: Allow passing labels as HTML (but explicitly)

Fixes the sorting button labels in stream settings, which were regressed by commit f8fbae4d8ed16cceabc23806aa421e1481e14e8d (because the HTML was not marked as being HTML).

lgtm, feel free to merge once CI is happy.


Added pygame install on mac

Added instructions for installing pygame on mac via anaconda

Have you tested it on a fresh system?

this works on my mac!!! Thanks 👍

Awesome, ty @makokal and @EderSantana

Awesome, sorry I was late responding. Yes I did try it on y fresh system

No worries, thanks for the PR :)


Fix MAINTAINERS file existence rule

The regular expression used in maintainers-file-exists:file-existence
is not working. This changes the rule to using a list.
Signed-off-by: Arnaud J Le Hors<EMAIL_ADDRESS>

LGTM


Bump version in Changelog and pom.xml and qube.cfg

[X] This comment contains a description of changes (with reason)
[X] CHANGELOG.rst is updated

Description of changes
This PR updates the versioning from 1.0.0-alpha.4 to 1.0.0-alpha.5-SNAPSHOT in all pom.xml files. Additionally it introduces the new version section into the changelog and sets the internal qube version to 1.0.0-alpha.5-SNAPSHOT.
Technical details
I was not able to use QUBE to update the version since it doesn't recognize the alpha.X section of the version and fails with the following error:
Invalid version specified! Ensure your version number has the form of 0.0.0 or 15.100.239-SNAPSHOT

Is the release already in the development branch?

Yes it's already merged into development, this branch just bumps the version number
#408


SPIKE -> Attempt to deploy in AWS fargate

Google cloud's free tier was better suited to our needs and the ability to have multiple containers with an ingress proxy container was perfect for our needs.


Implement e2edev CI tooling for Anax

Based on chosen CI build option to replace Travis-CI, create a build pipeline that can compile Anax and run the e2edev tests
Should integrate with GitHub Pull Requests. So anytime a PR is created for Anax, it should trigger this build pipeline and serve as a gate to a PR merge. Once this is working in your own fork, you will need the help of an administrator to change the Anax GitHub repo settings.

Can you assign it to me?

I think this is done using GitHub actions.

This work is completed.


withSpan() doesn’t work as documented

The documentation comments clearly state:

DO NOT end() the passed in span manually. It will be ended automatically when the function returns.

However, there is no end() on the happy path, only if an error occurs.
Of course I could make a PR, but when I encountered this I convinced myself that such an obvious omission might be intentional. :-)

Thanks for spotting this! Bug indeed 🐞

Of course I could make a PR
@JensAyton

Thanks for the bug report! Would you like to take this on yourself?


feat: Precise return type inference for model() and config()

Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

Why do you need this?
Of course the current PHPDoc types for them are not perfect, but
I think all return types for them in this repository are now correct without this PR.
If we need this, it should be another package?
Because we can't use this feature with app starter easily.

@kenjis @MGatner my initial intention of putting it here is to try it out here to catch any bugs (which it did in https://github.com/codeigniter4/CodeIgniter4/pull/7568/commits/4e18871c123c4e7480265c455468d65e1d31635e). I can pull this up to a standalone package (even better as a phpstan extension package). Just wanted to show it here first to get some reactions on the behavior.

@paulbalandan that makes sense! I guess there is no real way to demonstrate it publicly otherwise. Yes, please proceed - I'm excited for this enhancement!

Yes, without this we can't detect bugs like that!

Okay. I'll start the phpstan extension this week. Would codeigniter/phpstan-codeigniter4 be okay as package name?

In coding-standard it was put in the codeigniter vendor name because it's intended to be used in v4 and up (to minimize need of setting up codeigniter5 org etc.), so I think this should also be the case here.

I have advocated to @lonnieezell that with version 5 we need to take over the generic "CodeIgniter" brand and v3 can start adding the number or finally retire.

Closing this for now.
I'll open codeigniter/phpstan-codeigniter package soon.

Since v3 is already almost unmaintained, it seems like a good idea to make codeigniter/framework v5.


REWARD (¥1000): Implement algorithm with Levenshtein Distance support.

Support for new algorithm using Levenshtein Distance.
Unfourtunately, this libraly does not have an interface which abstracts the search algorithm.
So, it may be difficult to try to implement it at the moment.
Reward
I am offering a ¥1000 reward for resolving this issue.
If you successfully implement it, I will send you a gift card via a method like DM.
Please note that this reward initiative is in a trial phase.
Requirements

[ ] Work with the existing search interface (Or implement new nice interface)
[ ] Implement unit tests
[ ] Provide clear documentation

So, it may be difficult to try to implement it at the moment.
Of course, you could try to resolve both issue.

#3

I refactor the architecture of this liblary today.
Please start working at /algorithm/levenshtein/.


Settings UI Revamp

The current settings UI feels a bit cluttered, it'd be nice to revamp those screens to feel more user friendly.

I think we should try seeing if we can fit the different settings views in a vertical list, like this:

that's a cool idea, maybe a few special exceptions like sizes/vectors/points being like
label [ x ] [ y ]

I can take some time later to create a mockup so we can chat about style as well

Exactly what I was thinking for vectors 😁 Awesome!

We'd also need some list views and text boxes for things but I think this is a move in the right direction
OH and some spacers 👍


Do not show 'Stay signed in?' every login

This issue is imported from pivotal
If the user chooses not to stay logged in, we should not ask the same question each login.

Store the 'no' choice, and don't ask again.

(Peter Havekes - Jun 13, 2022)

Never ask again? Or do we want to configure a threshold in days like we have done with the "Nudge eduID app"? For example every 30 days? (Okke Harsta - Jun 13, 2022)

Yes, lets ask every X days, Just like the nudge_eduid_app_days setting (Peter Havekes - Jun 13, 2022)

https://github.com/OpenConext/OpenConext-myconext/commit/6a86a18283cc32b10cbb176f8bd8bf74ebf1dcf7 (Okke Harsta - Jun 13, 2022)


Grouped ListView with Virtualization

I'm looking for a away to use a ListView to display a large data set with random access data virtualization, but I also want the ListView to be grouped.  Is there a recommended way to accomplish this?
My understanding is that CollectionViewSource's View does not impement IItemsRangeInfo, so data virtualization is not supported.  My research has led me to believe that my best bet is to source my ListView with a custom class that implements both IItemsRangeInfo and ICollectionView.  Will this accomplish what I want and is it the preferred (easiest) method?  Is ICollectionView the only mechanism for getting a ListView to group its items?
Thanks!

This is not an issue with a sample in this repo. You can open a support case with our Developer Support team. Please use these steps below for further help:

Visit http://aka.ms/storesupport and sign-in with your Microsoft account
Under the “App Development” section choose "Windows 10 universal app development", then choose the appropriate problem type and category to get engaged through a formal support channel.


fix: replace fontawesome component with iconify fontawesome

:tada: This PR is included in version 1.8.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add the fuzzy hashers into the testing framework and make some runs to try it out

Added and they work. Comparison needs some adjustments tho


may you please update fightcade

its outdated

The Flatpak lags a few hours behind upstream and needs to be manually merged; see https://github.com/flathub/com.fightcade.Fightcade/pull/17

By the way, in the future feel free to ping me on the #linux-version channel on the Fightcade Discord if you're in there if there's a dangling pull request open.

@Pobega you can enable auto-merge for the bot by the way :) it will only merge the PR if the build was successful

@bilelmoussaoui How do I go about setting it up to do that? I don't see it on https://github.com/flathub/flathub/wiki/App-Maintenance

@Pobega by adding "automerge-flathubbot-prs": true to flathub.json

Thanks, that's really helpful

@bilelmoussaoui Just a consideration that maybe that should be added to the App Maintenance page (or the Wiki in general, I couldn't find it in a quick search). I noticed very few Flathub applications use it (I searched the org and got 8 results)


*(ticdc): always print changefeed id in scheduler and etcd worker

What problem does this PR solve?

Issue Number: ref #10342
What is changed and how it works?
In hundreds of changefeed scenarios, the added log information is helpful.
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest

/retest


provide a way to exclude arbitrary folders for deploy command

In our current folder structure, deck declarative configs are placed in workspace folders.
While it is quite convenient to keep portal and deck configurations in one folder, portal-cli ends up uploading config files to the portal.
While it is innocent on its own, having a way to exclude folder would be really useful. And given the fact that there is already a mechanism of excluding /specs folder this shouldn't require too much of an effort.

@sanyer thanks for the suggestion. We will look into it. Any chance you'd be interested in submitting a PR?

@sanyer thanks for the suggestion. We will look into it. Any chance you'd be interested in submitting a PR?

@kinman I'm not working on that project anymore, so don't really have time for it.
I might come back at some point in future, though.

Hi @HenriPro
This should be good to close now that https://github.com/Kong/kong-portal-cli/pull/63 is merged 👍


Create API key page, drop down list of "user's email" is not sorted

This makes it difficult to find users, please sort the list alphabetically

You can search for a user, so we do have a workaround

Added sorting on master

Added sorting for 6.0