Retry failed FwpmTransactionBegin

Description
WFP allows only 1 active transaction at a time per WFP session.  This leads to errors in multi-threaded scenarios where threads simultaneously try to load and attach ebpf program types supported by the NetEbpfExt extension.  In certain timing sensitive instances, such multi-threaded scenarios cause NetEbpfExt to attempt to create a new WFP transaction while a previous transaction is still in progress.
This PR adds time-bounded retry logic to the call to FwpmTransactionBegin call to allow for an already-in-progress transaction (if any) to complete.
Testing
Fix verified locally (100% repro) as well as multiple, back-to-back CI/CD runs on private self-hosted runner.
Do any existing tests cover this change? Are new tests needed?
Issue uncovered by existing tests.  No new tests needed.
Documentation
No Documentation changes needed.
Installation
Is there any installer impact for this change?
No Installer impact.
Fixes #3602 #3607

Instead of retry logic, a different session must be used for a given program attach operation.

Did not work.  Will discuss offline.

Will this issue be amplified when we support multiple programs to be attached to the same hook?

Waiting on Shankar's comments to be addressed. Will review after that.

This is being abandoned as this not the right fix.


icarus crash on docker for windows - unhandled page fault expection

Is there an existing issue for this?

[X] I have searched the existing issues

Used image version
latest
Used docker compose file or docker command
  icarus:
    image: mornedhels/icarus-server:latest
    container_name: icarus
    hostname: icarus
    restart: unless-stopped
    stop_grace_period: 90s
    ports:
      - "17777:17777/udp"
      - "27015:27015/udp"
    volumes:
      - C:/docker/icarus/data:/home/icarus/drive_c/icarus
      - C:/docker/icarus/game:/opt/icarus
    environment:
      - SERVER_NAME=xxxx
      - SERVER_PASSWORD=xxxxx
      - SERVER_ADMIN_PASSWORD=xxxx
      - SERVER_PORT=17777
      - SERVER_QUERYPORT=27015
      - PUID=4711
      - PGID=4711

What you expected to see, versus what you actually saw
Expected server to launch
Logs from the container
2023-12-01 12:10:32 Dec  1 12:10:32 icarus supervisord: icarus-server 023c:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
2023-12-01 12:10:32 Dec  1 12:10:32 icarus supervisord: icarus-server 023c:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."
2023-12-01 12:10:32 2023-12-01 12:10:32,796 INFO reaped unknown pid 473 (exit status 1)
2023-12-01 12:10:32 Dec  1 12:10:32 icarus supervisord: icarus-server 0234:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
2023-12-01 12:10:32 Dec  1 12:10:32 icarus supervisord: icarus-server 0234:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."
2023-12-01 12:10:33 2023-12-01 12:10:33,797 INFO reaped unknown pid 460 (exit status 0)
2023-12-01 12:10:42 2023-12-01 12:10:42,807 INFO success: icarus-server entered RUNNING state, process has stayed up for > than 10 seconds (startsecs)
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server INFO - Releasing PID file /var/run/icarus/icarus-server.pid
2023-12-01 12:11:16 2023-12-01 12:11:16,654 INFO exited: icarus-server (exit status 0; expected)
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server INFO - Shutdown complete
2023-12-01 12:11:16 2023-12-01 12:11:16,655 INFO spawned: 'icarus-server' with pid 476
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server INFO - Running icarus-server
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server wine: Unhandled page fault on execute access to<PHONE_NUMBER>46A000 at address<PHONE_NUMBER>46A000 (thread 0248), starting debugger...
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server 0258:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server 0258:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."
2023-12-01 12:11:16 2023-12-01 12:11:16,810 INFO reaped unknown pid 484 (exit status 1)
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server 0250:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
2023-12-01 12:11:16 Dec  1 12:11:16 icarus supervisord: icarus-server 0250:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."
2023-12-01 12:11:17 2023-12-01 12:11:17,813 INFO reaped unknown pid 471 (exit status 0)
2023-12-01 12:11:26 2023-12-01 12:11:26,823 INFO success: icarus-server entered RUNNING state, process has stayed up for > than 10 seconds (startsecs)

So, I checked and I get the same error. Seems like 2 virtualizations are one to much. Unfortunately I don't think I can fix that besides waiting for RocketWerkz to publish a native linux version of the server itself.
https://github.com/RocketWerkz/IcarusDedicatedServer/issues/2
I think the best solution for you would be using the Icarus-Server-Manager for Windows from the community (Discord Channel).

No fix found. Added supported docker hosts to readme.


Feature/vcpkg support

Updates the CMake files so that it can be cleanly installed by vcpkg.
To use the library, client applications just need to add
find_package(FMI4cpp CONFIG REQUIRED)
target_link_libraries(main PRIVATE FMI4cpp::FMI4cpp)

Note: when building fmi4cpp on windows -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON needs to be passed to CMake (this is done by the vcpkg port)
@traversaro I basically had to rewrite the install code as I was following this example. Please have a look.

There might be an issue on linux. Will investigate and update the pull request later.

I tried this branch.

Note: when building fmi4cpp on windows -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON needs to be passed to CMake (this is done by the vcpkg port)

I suggest to move this to the main CMakeLists.txt, to simplify the process of building this  library with BUILD_SHARED_LIBS outside of vcpkg, for using ExternalProject (useful for CMake-based superbuilds) of for including this library inside of another project using FetchContent and  add_subdirectory.
On a empty build on Ubuntu 18.04, I have this error:
 CMake Error at CMakeLists.txt:18 (string):
   string sub-command COMPARE, mode EQUAL needs at least 5 arguments total to
   command.

this is because the line string(COMPARE EQUAL ${CMAKE_BUILD_TYPE} "Debug" DEBUG_MODE)  is equivalent to string(COMPARE EQUAL  "Debug" DEBUG_MODE) if CMAKE_BUILD_TYPE is empty (the default value). Substituting it with string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" "Debug" DEBUG_MODE) fixes this specific problem, but that logic is still broken for multiple-config generators such as Visual Studio.
You may be interested in substuting all that logic with a simple target_compile_definitions call once the ${FMI4CPP_LIB} library has been created:
target_compile_definitions(${FMI4CPP_LIB} PRIVATE $<$<CONFIG:Debug>:DEBUG_LOGGING_ENABLED>)

See https://cmake.org/cmake/help/v3.12/manual/cmake-generator-expressions.7.html for more info on the generator expressions.

this is because the line string(COMPARE EQUAL ${CMAKE_BUILD_TYPE} "Debug" DEBUG_MODE) is equivalent to string(COMPARE EQUAL "Debug" DEBUG_MODE) if CMAKE_BUILD_TYPE is empty (the default value). Substituting it with string(COMPARE EQUAL "${CMAKE_BUILD_TYPE}" "Debug" DEBUG_MODE) fixes this specific problem, but that logic is still broken for multiple-config generators such as Visual Studio.
You may be interested in substuting all that logic with a simple target_compile_definitions call once the ${FMI4CPP_LIB} library has been created:
target_compile_definitions(${FMI4CPP_LIB} PRIVATE $<$<CONFIG:Debug>:DEBUG_LOGGING_ENABLED>)

Thanks, tested the target_compile_definitionssolution. Seems more elegant, applying to dev directly.

Note: when building fmi4cpp on windows -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON needs to be passed to CMake (this is done by the vcpkg port)

I suggest to move this to the main CMakeLists.txt, to simplify the process of building this library with BUILD_SHARED_LIBS outside of vcpkg, for using ExternalProject (useful for CMake-based superbuilds) of for including this library inside of another project using FetchContent and add_subdirectory.

I'm adding this directly to the project's CMakeList.txt as suggested.


[Impeller] Blends render nothing when applied to a single path.

This test should render a blue rect, but renders nothing:
TEST_P(AiksTest, CanRenderColoredRectWithOverlay) {
  Canvas canvas;
  Paint paint;
  paint.color = Color::Blue();
  paint.blend_mode = BlendMode::kOverlay;
  canvas.DrawPath(PathBuilder{}
                      .AddRect(Rect::MakeXYWH(100.0, 100.0, 100.0, 100.0))
                      .TakePath(),
                  paint);
  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
}

And has similar problems with other blend modes.
Cause of https://github.com/dnfield/flutter_svg/issues/939

Compare:
void draw(SkCanvas* canvas) {
  SkBlendMode blendModes[] = {
    SkBlendMode::kDst,
    SkBlendMode::kSrc,
    SkBlendMode::kSrcOver,
    SkBlendMode::kDstOver,
    SkBlendMode::kSrcIn,
    SkBlendMode::kDstIn,
    SkBlendMode::kSrcOut,
    SkBlendMode::kDstOut,
    SkBlendMode::kSrcATop,
    SkBlendMode::kDstATop,
    SkBlendMode::kXor,
    SkBlendMode::kPlus,
    SkBlendMode::kModulate,
    SkBlendMode::kScreen,
    SkBlendMode::kOverlay,
    SkBlendMode::kDarken,
    SkBlendMode::kLighten,
  };

  int row = 0;
  for (auto blend_mode : blendModes) {
    if (row == 5) {
      canvas->translate(140, -140 * 5);
      row = 0;
    }
    row++;

    canvas->translate(0, 140);
    SkPaint paint;
    paint.setBlendMode(blend_mode);
    paint.setColor(SK_ColorBLUE);
    canvas->drawRect(SkRect::MakeXYWH(100, 100, 100, 100), paint);
  }
}
``` (https://fiddle.skia.org/c/9f743386db7dd748c677fb4b9034297a)

With the output of

```cpp
TEST_P(AiksTest, RectWithBlendModes) {
  auto modes = GetBlendModeSelection();

  Canvas canvas;
  int row = 0;
  for (auto blend_index : modes.blend_mode_values) {
    if (row == 5) {
      canvas.Translate({140, -140 * 5, 0});
      row = 0;
    }
    row++;

    canvas.Translate({0, 140, 0});
    Paint paint;
    paint.color = Color::Blue();
    paint.blend_mode = static_cast<BlendMode>(blend_index);
    canvas.DrawPath(PathBuilder{}
                        .AddRect(Rect::MakeXYWH(100.0, 100.0, 100.0, 100.0))
                        .TakePath(),
                    paint);
  }
  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
}

Skia and Impeller also behave differently if you add an explicit drawPaint with a white paint before drawing the rects.

Impeller case above with an extra DrawPaint with a white paint first:

Skia with or without a drawPaint:

ARGH. It's the same if you get the blend mode ordering right. But something is up.

@dnfield did we ever figure out what this was?

This seems fixed, the original example draws a blue rect. Can you confirm @dnfield ?

Closing this as fixed.


Logo missing whith 'logo_only': True

Problem
I have set a html_logo in conf.py. The logo is shown under the home icon/name in the sidebar, as expected.
However, as soon as I set the logo_only option to True, the logo disappears from the sidebar.
Reproducible Project
https://github.com/virtualritz/nsi-docs
https://nsi.readthedocs.io/
Environment Info

Python Version: 3.7.6
Sphinx Version: 2.3.1
RTD Theme Version: live version

Try setting next CSS content in your theme_overrides.css:
a img.logo {
  width: 100px;
}

Doesn't work for me. Logo is still amiss. But thanks for the suggestion.

We use an SVG logo without issue on our docs. I thin the issue is your SVG, the dimensions are way off:

You can also use CSS to resolve this on your docs, but your selector specificity is not high enough to override the default styles.
Closing this as it is not an issue with our theme


Sdk gen/confidentialledger net 5efd32b9 946f ed11 9562 000d3a5651e3/dpg confidentialledger azure.security.confidential ledger bug bash

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Security.ConfidentialLedgerBugBash

/azp run pare


Feat: Add support for Human Readable Abi

Description
This PR aims to add support for Human Readable Abis in ABIType.
The scope of this is just for ethers.
This can infer almost everything from the Human Readable Abi with the exception of nested named and array tuples.
More details of it working are shown in the readme and also on the habi.test-d.ts files.
I am creating this PR as draft to serve the purpose of discussion and general improvements to the code. As i though in having the code already would lead to a more productive discussion and wouldn't mind in case this gets rejected.
Additional Information

[x] I read the contributing docs (if this is your first contribution)

Your ENS/address: 0x75EF32C862b8fe2915D49b38a2AECc8744622864

Nested tuples current max without breaking inference is 10 deep. I think this is enough depth for pretty much all use cases

Pretty cool to see this work being done! I started going down a similar path here. Will check it out.

Oh i didn't notice it. Could have save me some time if i did.
In this version i tried to match ethersjs as much as possible. This could possible be extended to support  keywords like external, public, memory, storage and calldata to try and mimic solidity interfaces as much as possible but Structs kinda break this inference so i decided to opt out of these key words and since ethers already drops them internally if you add them i though it made sense in not adding them. But let me know your thoughts

Sweet! Been a busy week. Excited to dig in soon.

unless you want to add support to the things i pointed in the previous comment

Will think about this some more too.

No problem! Exciting week for wagmi. Great work on the cli tool!

I had tried the idea of isUnknown before the previous commit but I was taking the wrong approach. This works the same as the previous commit and doesn't require the change to eslint's banned types. Also was using Exclude instead of Extract and that's why my previous approaches weren't working as I hoped.


Disable the deposit contract tests.

test_deposit_contract CI job took the most of our CI execution time.
Since phase 0 has been launched, we can disable the deposit contract tests in CI now.
Only keep the build_deposit_contract CI job to verify the bytecode correctness.

The codespell and doctoc errors are fixed in #2144.

#2145

2145

#2145

rebased against dev with the CI fixes


How exactly do I add this to my browser script?

I'm confused by the README. Maybe someone here can help me.
It says that I can install it with npm (which I already did) but I don't understand how do I call Sortable.create() from a script added in the html.
I thought about broswerify but from what I have read I cannot call an object in bundle.js from another script and it says that I have to bundle my js with the module. Is this really the best way to add Sortable to my page? Or am I missing something.

You have to use a bundler like Webpack or just include the script from the CDN in a script tag


Mention scikit-learn API compatibility the readme

Thanks for this very nice package!
It would be nice to mention the scikit-learn API compatibility in the readme.
If you are interested in a user story in the interacting with the documentation.
I knew there was a package that produced embedding from text in a scikit-learn pipeline. Found it via github search, looked at the the readme and documentation couldn't find anything about it. Though I had the wrong package continued looking in other packages. Finally, double checked that this was indeed the package mentioned in the announcement tweet. After more carefully checking the documentation finally found the corresponding docs. The conclusions is that,

mentioning this feature in the readme can be useful, while a long description of related project might be more useful as a separate documentation page instead of being on the documentation home page.
one horizontal menu and one (and sometimes two) vertical sub-menu in the documentation is nice once one figures out how to use them, but they can be somewhat confusing for a fraction of users after a superficial glance at the docs

Thanks for reaching out! I'm happy to hear you find the feature useful.
The scikit-learn feature is certainly useful, but there's a reason why I prefer not putting it front and center. It works with Pipeline but breaks with GridSearchCV. This is a pretty big caveat. The goal of this library will always be closer to explaining and visualizing. We currently do not have the bandwidth to offer proper general support for scikit-learn. I'm not even 100% sure it is possible (not every language backend will pickle the way scikit-learn likes it). I suppose it cannot hurt to mention in the documentation but it is not the core goal of the package, rather mere a feature for now.
I'm interesting in redo-ing the readme file soon-ish though. Do you have an example of a readme file that contains a horizontal menu and/or vertical sub-menus?

The scikit-learn feature is certainly useful, but there's a reason why I prefer not putting it front and center.

Fair enough. I'm just saying it could be helpful for potential users if the readme/homepage provided a more complete summary of the supported features. For instance, for people looking to compute the embedding of multiple tokens with different embedding types (e.g. fasttext, transformers, etc).

Do you have an example of a readme file that contains a horizontal menu and/or vertical sub-menus?

I meant the documentation. Not saying that this needs fixing, I was likely distracted, but it might still give a data point on usability :)
Feel free to close this issue.

I've made a PR to update the readme. It now has a feature list and it lists the scikit-learn support at the bottom.
https://github.com/RasaHQ/whatlies/pull/185
Once this is reviewed/merged I'll close this issue.


add a new location for prayer information and add a hotkey for adding time based on stomps

I'll take a look at it.

thanks for the update was a bit worried you had disappeared 😅

any further update on this?

any further update on this?

Hi, thanks for your contribution. I have taken a look at your PR and have some feedback.
First of all I noticed some inconsistent code styling. My code had that as well, so I cleaned it up a bit. You can find some information on automated tools in the RuneLite docs. The codestyle files are in the main directory.
The keybinding for trampling now prevents using that key for other things such as typing text. I think this is fine during the fight, but it might get annoying in between fights. This could be fixed by checking the active state of the plugin to the handler of the key bind.
The overlay feature has a similair issue. The overlay still shows after stopping the timer. I think this should remove the overlay. Another suggestion is to remove the overlay after switching tabs away from the prayer book. The overlay currently shows on any other tab as well.
I'm also in doubt if the overlay feature would be allowed or if it is in conflict with the Jagex third party client statement. For now I'm willing to let the RuneLite team be the judge of that.

Thanks for the response again. I will implement RL checkstyle and update pr when I'm able. As for the rules I think its fine as they are currently being interpreted. My commits don't add any new info or tracking just a new location for information which I don't think should affect the legality.


Chef can't remove apt packages if they don't exist in a repo

Chef will fail to remove a package if it can't be found in apt-cache.  Unfortunately this is a completely valid use case for the remove action.  We had a repo for an inventory management package.  We stopped using it so we had chef remove the repo, then remove the package.  When doing that we received the following error (sanitized a bit)
  * package[crappy-inventory-agent] action remove
================================================================================
Error executing action `remove` on resource 'package[crappy-inventory-agent]'
================================================================================

Chef::Exceptions::Package
-------------------------
crappy-inventory-agent has no candidate in the apt-cache

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/common/recipes/debian.rb

 16:   package 'crappy-inventory-agent' do
 17:     action :remove
 18:   end
 19:

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/common/recipes/debian.rb:16:in `from_file'

package("crappy-inventory-agent") do
  action [:remove]
  retries 0
  retry_delay 2
  guard_interpreter :default
  package_name "crappy-inventory-agent"
  cookbook_name "common"
  recipe_name "debian"
end

Can somebody reproduce this bug? I was taking a look at this issue but I couldn't reproduce it.

@nomadium This just happened to me.
I download a remote .deb using remote_file.
installed it using package and provider Chef::Provider::Package::Dpkg
failed to remove it using package action :remove
dpkg_package action :remove does work as a workaround, Thanks.

#4888 should have fixed this, the apt_package provider will now return 'nil' for the candidate_version instead of raising an exception.

I encountered this problem on jessie. The suggested workaround dpkg_package was successful.


Incorrectly detected TextIO type

I am trying to use this code:
import type_enforced
from typing import TextIO
from io import StringIO

@type_enforced.Enforcer
def func(way) -> TextIO:
    string = "Hello\nworld"
    fh = None

    match way:
        case 1:
            fh = StringIO(string)
        case 2:
            fh = open("/etc/os-release", "r")
    return fh

func(1)  # Expected one of the following `[<class 'typing.TextIO'>]` but got `<class '_io.StringIO'>` instead.
func(2)  # Expected one of the following `[<class 'typing.TextIO'>]` but got `<class '_io.TextIOWrapper'>` instead

In both ways there is an exception.

Hey @Ashark, Instead of using the typing module (in this case, TextIO is not supported by type_enforced yet), try using the actual classes you plan to use.
EG:
import type_enforced
from io import StringIO, TextIOWrapper
from type_enforced.utils import WithSubclasses

@type_enforced.Enforcer
def func(way) -> StringIO | TextIOWrapper:
    string = "Hello\nworld"
    fh = None

    match way:
        case 1:
            fh = StringIO(string)
        case 2:
            fh = open("/etc/os-release", "r")
    return fh

func(1)
func(2)

Closing this as a wontfix.


⚠ Mobitopup has degraded performance

In e6f874d, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 12891 ms

Resolved: Mobitopup performance has improved in 14a69ab after 19 minutes.


New version: REALiX.HWiNFO version 8.16

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@SpecterShell can you please fix or abandon this PR? We have a couple other candidates blocked from merging.

@stephengillie https://github.com/microsoft/winget-pkgs/issues/157749

This package installs and launches normally in a Windows 10 VM.
(Automated response - build 923.)


Add rule to filter for null values at inner-joins

Assume the following query:
SELECT * FROM t1 INNER JOIN t2 ON t1.a = t2.b

The t2.b column does not allow null values but t1.a does. Rows in t1 where a is null can never match any row in t2.b for the inner join case with an equi-join condition t1.a = t2.b. Therefore, we can add a filter when reading t1 to filter out rows with null values before we perform the join to reduce the number of rows.
      Inner-Join(t1.a = t2.b)
      /        \
    t1.a       t2.b

becomes:
       Inner-Join(t1.a = t2.b)
          /                 \
      Filter(a is not null)  \
       /                      \
    t1.a                     t2.b

Reference:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/optimizer/src/filter_null_join_keys.rs

Hi
I am Chitrank, and I am currently pursuing MS in CS at UT Austin.
As part of my course project, I have to work on addressing a specific issue or bug within a defined timeframe, with the goal of creating a Pull Request (PR) to contribute to the project's development. Given the significance of this project, I am seeking assistance and guidance from experienced contributors such as yourself.
I have identified a set of issues that align with my project's objectives, and I believe that your expertise and insights would be immensely valuable in helping me understand and resolve these challenges effectively.
Kind regards,
Chitrank

Hi @theartpiece, thank you for the interest in contributing to CrateDB.
Please don't post your interest on a bunch of issues, but rather pick one that interests you, so that we can assign it to you and assist you. I can suggest for example a simple one like: https://github.com/crate/crate/issues/14714 and maybe you can take over something else after that.
Thank you!

@theartpiece An excellent first task to get started is https://github.com/crate/crate/issues/2036

@matriv, @mkleen  This will be part of a course project where we have to pick 3 issues from a repo and solve them before the end of the semester, and therefore we had selected 3 issues (1 hard, and 2 easy) to get started. We can get started with #2036 or #14714 and we will hopefully get assigned this issue after completing them. Thanks for the quick response.

Hi @mkleen
I'm following up on @decoder746 's message above. We were wondering if it's possible to meet developers for a small meeting (we will keep it under 30 min) so that we can unblock ourselves and also get your feedback.
Kind regards

@theartpiece We have a public channel where you can chat directly with the team. We can continue from there. https://app.gitter.im/#/room/#crate_crate:gitter.im

@mkleen Thanks so much for your constant help and support. My plan is to first to clone and install the repository. I'll contact you real soon as soon as I'm done with this step.

Hello @mkleen I have started to work on this and have build a rule that seems to do the right thing. The rule I came up with catches and a seemingly (to me) proper plan is created. The problem is that this rule hardly ever is invoked because joins turn out to be of three different types: NestedLoopJoin, HashJoin, JoinPlan.
Here is the test that I used to check if I can write a Rule<>:
    @Test
    public void test_push_filter_beyond_join() {
        // GIVEN
        var joinCondition1 = e.asSymbol("doc.t1.a = doc.t2.b");
        var join1 = new JoinPlan(t1, t2, JoinType.INNER, joinCondition1);
        // WHEN
        var rule = new AddNullFilterInnerJoin();
        Match<JoinPlan> match = rule.pattern().accept(join1, Captures.empty());
        // THEN
        assertThat(match.isPresent()).isTrue();
        // AND WHEN
        var result = rule.apply(match.value(),
                match.captures(),
                e.ruleContext());
        // THEN
        assertThat(result).hasOperators(
                "Join[INNER | (a = b)]",
                "  ├ Filter[(NOT (a IS NULL))]",
                "  │  └ Collect[doc.t1 | [a] | true]",
                "  └ Collect[doc.t2 | [b] | true]"
        );
    }

The rule catchphrase I came up with is
    private final Pattern<JoinPlan> pattern = typeOf(JoinPlan.class)
            .with(j ->
                    !j.isNullFilterJoinRuleApplied() &&
                            // only inner-equi-joins
                            j.joinType() == JoinType.INNER &&
                            j.joinCondition() != null &&
                            EquiJoinDetector.isEquiJoin(j.joinCondition()));

In io.crate.planner.optimizer.matcher.TypeOfPattern#accept this gets rejected because a join written as "select a, b from t1 join t2 on t1.a = t2.b" is sometimes a HashJoin, depending on config and other rules. Is there a way to write a rule that applies to all joins and then checks for an "abstract" Join?


Shouldn't blendMode.NORMAL be [gl.SRC_ALPHA, gl.ONE_MINUS_SRC_ALPHA]??

fragment shader:
color.a = vTextureCoord.x;
Fixed preview:
http://jsfiddle.net/fkuxvywa/

Is this really a bug? This seems to be the correct approach actually - http://blogs.msdn.com/b/shawnhar/archive/2009/11/06/premultiplied-alpha.aspx
You can modify your shader this way:
http://jsfiddle.net/gk8vs9a1/
    color.rgb = color.rgb / (color.a + 0.0000000001);
    color.a = vTextureCoord.x;
    color.rgb = color.rgb  * color.a;

Yes and no I think. The current one is more flexible but the blendmode "normal" should behave just like in Photoshop normal. Maybe use "none" for the current one and "normal" be the I suggested seems more appropriate.


Parse name of specialization constants

Parses names of specialization constants, also fixes parsing of spirv_id and constant_id (I think these were swapped when being parsed from the bytecode)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ci(auto-merge): change token

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.923%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
20

Relevant Lines:
26

💛  - Coveralls


License specification is not clear

Describe the bug
The repository mentions two different licenses: The "Eclipse Distribution License v. 1.0" and the "BSD  3-Clause" license. It is not really clear, which is applicable to the project, EDL, BSD or both.

pom.xml: Both in comment, EDL in metadata
LICENSE.md: BSD
NOTICE.md: both
Source code comments: both

Expected behavior
I should be able to see the correct licence in all those places. As far as I can see, the EDL has no official SPDX identifier, so if one wants to keep the SPDX-conformant headers and the license is, in fact, EDL, a new identifier should be requested

They're two different names for the same license.  EDL is here.


bugfix: priority to use openresty's cjson library

Openresty has a built-in cjson library, but users may also install another version of cjson via luarocks, in which case we should give priority to the former.

The current reasonable search path is: deps -> apisix-lua -> openresty built-in -> standard Lua built-in.
In order to find the correct cjson library, you cannot have a cjson library in the deps directory.

https://github.com/iresty/apisix/pull/165 not consider RPM users

https://github.com/iresty/apisix/pull/165#discussion_r298492706
we can close it now.


Replace argument FullPath with FileContent

Hi Max,
I tried to use this function in one of my solutions. However, current version cannot be used for Scheduled Refresh as Power BI can't determine data source.
I changed function - replaced argument FullPath with FileContent.
So, in query it look like
FullPath = "C:\Temp\File.xlsx"
file = File.Contents(FullPath)
Source = fGetNumberFormats( file , "SheetName", 1, true)
... and so one...
Scheduled refresh works fine with such structure.
BR,
Ivan

Hi Ivan!
Thank you for the comment. I never used PBI Scheduled Refresh with local files so never met this issue.
As far as I can see you talk about Excel.GetNumberFormats.pq function.
FullPath argument used in several places there, for example, there:
UnZipped = Table.Buffer(UnZip(File.Contents(FullPath)))

and there
SourceSheets =
	let
	    Source = Excel.Workbook(File.Contents(FullPath), null, true),

I think we could use a switch with the check for 1st argument - if it is text then use it as a full path (as intended), if it is binary then use it as a File.Contents
Using a File.Contents output by default as the 1st argument seems to be too complicated for users (although the function itself is also complex, but can be used as copy-paste solution).

Ivan, could you please make a PR to this project, so I could see the full stack of changes needed?

Good idea to make "any" argument

I think we could use a switch with the check for 1st argument - if it is text then use it as a full path (as intended), if it is binary then use it as a File.Contents

I'll change the code and make a PR.


Blocks button enabled by default

Overview
A user can enable block mode without zooming in. This makes it more clear that the block editing mode is available. Previously, when this button was disabled by default, it sent mixed signals—maybe this feature isn't built yet, or maybe I don't have access to it for a difficult-to-change reason. Depending on a tooltip to straighten that out wasn't enough.
Now a user can immediately click on the blocks button if they want. And they'll receive an appropriate warning to let them know the takeoffs of block editing.
Testing Instructions

Create a new project
In the new project, confirm that the "blocks" button visually appears enabled
Click on the "blocks" button; you should see the blocks modal; click cancel
Select a county on the map
Confirm that the "blocks" button looks disabled
Hover over the disabled "blocks" button; confirm that you see a tooltip that explains you need to resolve changes
Resolve changes (click cancel or accept)
Click on the "blocks" button and this time click "Start block editing"
You should see a message overlay on the map that says you need to zoom in to edit blocks
Zoom in; at some point, the message should disappear and you should see blocks!

Closes #407

@kshepard thanks for the review and code cleanup
@alexelash thanks for the review and for suggesting this change, I think it makes the block mode way more clear.


sonatanfv/sonata-fw-vnf image is broken

start_fw.sh#L20 inside Docker image assumes interface names to be (fwin, fwout), while during actual sonata-fw-service-emu project creation the interface names are listed as (input, output) (see fw-vnf-vnfd.yml#L44).
When I create sonata-fw-service-emu project, I can actually see could not open network device fwin (No such device) (resp. fwout) in ovs-vsctl show output.
$ son-package --project sonata-fw-service-emu -n sonata-fw-service
...
$ curl -i -X POST -F<EMAIL_ADDRESS>http://<IP_ADDRESS>:5000/packages
...
$ curl -X POST http://<IP_ADDRESS>:5000/instantiations -d "{}"
...
$ sudo docker exec -it mn.fw /bin/bash
$ root@fw:~# ovs-vsctl show
112e0b1d-d48c-4bcd-a304-af8495364b9b
    Bridge "ovs1"
        Controller "tcp:<IP_ADDRESS>:6633"
            is_connected: true
        fail_mode: secure
        Port "ovs1"
            Interface "ovs1"
                type: internal
        Port fwin
            Interface fwin
                error: "could not open network device fwin (No such device)"
        Port fwout
            Interface fwout
                error: "could not open network device fwout (No such device)"
    ovs_version: "2.5.0"

I tried this fix start_fw.sh#L20
- declare -a PORTS=("fwin" "fwout")
+ declare -a PORTS=("input" "output")

and things started working as expected, i.e., I don't see No such device error in ovs-vsctl show and when I deployed sonata-fw-service-emu project similar to Example-3 client <-> server ping works.

I would propose a fix the other way around and change https://github.com/sonata-nfv/son-examples/blob/master/service-projects/sonata-fw-service-emu/sources/vnf/fw-vnf/fw-vnf-vnfd.yml#L44 to:
virtual_links:
  - id: "mgmt"
    connectivity_type: "E-LAN"
    connection_points_reference:
      - "vdu01:eth0"
      - "mgmt"
  - id: "fwin"
    connectivity_type: "E-Line"
    connection_points_reference:
      - "vdu01:eth1"
      - "fwin"
  - id: "fwout"
    connectivity_type: "E-Line"
    connection_points_reference:
      - "vdu01:eth2"
      - "fwout"

I assume it will do the job as well. The reason for this is that I remember that there could be problems if we run multiple containers having the same interface names input and output ... at least if someone tries this vTC VNF with its strange kernel patch :-)
@stevenvanrossem what do you think?

I agree to change the interface names in the fw-vnf descriptor,
I definined a different interface name in:   https://github.com/sonata-nfv/son-examples/blob/master/service-projects/sonata-fw-service-emu/sources/vnf/fw-vnf/fw-vnf-vnfd.yml#L66
done by: https://github.com/sonata-nfv/son-examples/pull/82
the networking commands should then be:
son-emu-cli network add -b -src client:client-eth0 -dst fw:fwin
son-emu-cli network add -b -src fw:fwout -dst server:server-eth0
Also, I updated the examples in the wiki to not use the deprecated son-push tool. (instead using the dummy gatekeeper directly as default)
Additionally, I refer to this page to describe the use of son-access push
https://github.com/sonata-nfv/son-emu/wiki/Dummy-Gatekeeper-API
@dang03 can you quickly review this, to make sure this is the latest wow, or is this described already somewhere else?


Import custom theme not available

I've version: 2.79.5768.721 of PowerBI Desktop App in older versions it was possible to import a custom theme like described here but in this version there is no "switch theme" in the Home Ribbon and in the Visualization Ribbon the theme can be switched but not customized

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d9a8511-6ff9-78c6-5a8c-3f5ac68224d0
Version Independent ID: f4fd28c7-71fa-a776-7154-e76eb9bd3649
Content: Use report themes in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-report-themes.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @FThun89.
I've assigned this issue to the doc author for review.
In the meantime, you might find an answer in the Power BI Community.

Hi FThun,
see my comment above for a step by step of how to do it - the feature is still there, it has just changed to be in the 'View' Ribbon. Hope this helps.

Thanks for clarifying @Sil-L !


Change formatter to json

I've been looking at the code for a really long time now and I can't seem to find any decent way of turning the rails appender into a JSON formatted STDOUT.
If this isn't easily achievable I wanted to add a feature request for this. I don't like the initializer approach because I am trying to solve a problem once for all our projects which means I am wrapping SemanticLogger (and rails_semantic_logger) in a gem that we own and control that has (for us) sensible defaults.

Just added documentation for this scenario under the section titled "Disable default Rails file logging": http://rocketjob.github.io/semantic_logger/rails.html
Let us know if the updated docs properly address this use case, or if you have any other feedback.
To address the common defaults we have a "Common" Rails engine that includes all of our common gem dependencies, defaults, configs and initializers. The Common engine / gem is then added to all our Rails apps so that we are sure they are all consistent.


Better tests on Windows

For issues like https://github.com/chef-cookbooks/firewall/pull/100, it would be nice to be able to test if the rules applied successfully.

Fixed in https://github.com/chef-cookbooks/firewall/commit/76d8017d267fd903c4945b2855019611fa1be761.


Update cosmosdb list keys syntax

Update cosmosdb list keys syntax errors

Could you please explain why this change is needed?
Apparently both variants of the command work.
Based on https://github.com/Azure/azure-cli/issues/6094 , it seems the "keys list" form is more consistent.

Is it working for you? keys list command was giving syntax error when I tried yesterday.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Alexandre Gattiker<EMAIL_ADDRESS>Sent: Friday, October 4, 2019 9:17:44 PM
To: Azure-Samples/streaming-at-scale<EMAIL_ADDRESS>Cc: Chetan Gangwar<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Azure-Samples/streaming-at-scale] Update cosmosdb list keys syntax (#55)
Could you please explain why this change is needed?
Apparently both variants of the command work.
Based on Azure/azure-cli#6094https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli%2Fissues%2F6094&data=02|01|chetang%40microsoft.com|5b8794ae6b2d4ab0b0c308d7494af8fb|72f988bf86f141af91ab2d7cd011db47|1|0|637058458658905173&sdata=l27v9zw0oFdykOg8jBZcoteYs5H%2F1X8Ao76kRcVZHGQ%3D&reserved=0 , it seems the "keys list" form is more consistent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure-Samples%2Fstreaming-at-scale%2Fpull%2F55%3Femail_source%3Dnotifications%26email_token%3DADID7UUQEUTJJ2XQF2WUZP3QNAIORA5CNFSM4I5IGC2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANJYFY%23issuecomment-538614807&data=02|01|chetang%40microsoft.com|5b8794ae6b2d4ab0b0c308d7494af8fb|72f988bf86f141af91ab2d7cd011db47|1|0|637058458658915172&sdata=rnOc%2FmXXGyTgRiD7koIR7hukcYqFiHf%2F4JMFa0P3u28%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADID7UQDEOX5YQYF6763XV3QNAIORANCNFSM4I5IGC2A&data=02|01|chetang%40microsoft.com|5b8794ae6b2d4ab0b0c308d7494af8fb|72f988bf86f141af91ab2d7cd011db47|1|0|637058458658915172&sdata=U9OV7foiEsc2wQg1VbJ9MW0e4vYHHXF%2F9oVXh0keBXQ%3D&reserved=0.

It's certainly an AZ CLI version issue. I've added a check for AZ CLI version - can you pull and try again (before you update AZ CLI so we can check my implementation?)


reading and writing yolo files causes codec error

I uses python labelImg.py [IMAGE_PATH] [PRE-DEFINED CLASS FILE]
But it seems to save classes.txt by cp950 and reads by UTF-8.
This causes error on classes.txt and any yolo .txt annotations.
Personally, I changed labelImg.py line 1436 to a try...except UnicodeDecodeError block and so did line 100 in libs/yolo_io.py Things works fine now.

OS: Windows 10 (1909) x64
PyQt version: 5

By the way, I didn't type the labels in English since Yolo supports it.


config check: automatic updates are configured

App Store prefs should look like:

[ ] Automatically check for updates (required)

[ ] Download newly available updates in the background (recommended)
[ ] Install app updates (recommended)
[ ] Install OS X updates (required)
[ ] Install system data files and security updates (required)


Broken Link to K8s metrics-server Documentation

#255

Related patch already submitted. #235

Related patch already submitted. #235


Storage component - Added new method for addressbook to be saved in a fixed temporary location

Pull Request Test Coverage Report for Build 14

0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 91.589%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/storage/StorageManager.java
0
2
0.0%

src/main/java/seedu/address/storage/XmlAddressBookStorage.java
0
2
0.0%

Totals

Change from base Build 3:
-0.2%

Covered Lines:
1470

Relevant Lines:
1605

💛  - Coveralls


Use in LaTeX

This is most likely a noob question, but can this font be converted/installed for used in LaTeX, instead of XeTeX, LuaTeX, etc.?

Use lualatex or xelatex and load the fontspec package.


Update performance-tips.md

fixed mistyped tag.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Thank you for trying to fix that issue @osozero but that link format is actually correct. I'll have to investigate why that particular link is not working with our engineering team.

I'm seeing this same behavior on other topics. This is probably due to the engineering work we're doing for #4789. I've opened an internal ticket for this. Thanks for bringing this up @osozero!


Set the fallback app type and fixed config

Will work after v3.4.0 has been tagged on bugsnag-php.

Tests pass locally and the demo app behaves correctly.


Backport 2.1: Add various dependencies on ASN.1 parsing module

This is the backport to Mbed TLS 2.1 of #2101, fixing #1531.
A notable difference is that in Mbed TLS 2.1, the RSA module was still partially dependent on ASN.1 parsing, hence commit e577beb had to be added which is not present in #2101 or #2102.

Travis is failing:
The command "tests/scripts/check-names.sh" exited with 1.
0.66s$ tests/scripts/check-files.py

Therefore marking as 'needs work'.

@sbutcher-arm Thanks for noticing this. Fixed in b46e733.
@mpg @AndrzejKurek Please review.

retest

Jenkins CI failed because of doxygen.sh which is a known issue and has been fixed in the head of mbedtls-2.1. Therefore CI is a pass.


Matplotlib not working on lambda due to use of local kiwisolver instead of manylinux

Context
I have deployed my django app using zappa. During deploy it said  - matplotlib==2.2.2: Using locally cached manylinux wheel . But the problem is that when i import it on lambda it fails with
File "/var/task/matplotlib/_layoutbox.py", line 23, in <module>   import kiwisolver as kiwi ModuleNotFoundError: No module named 'kiwisolver'
I have checked uploaded zip file and i see that zappa bundled my local kiwisolver.cp36-win_amd64.pyd which obv wont work on lambda...
On pypi i see that manylinux wheel available for kiwisolver kiwisolver-1.0.1-cp36-cp36m-manylinux1_x86_64.whl  but zappa dont use it.
Expected Behavior
Use kiwisolver manylinux wheel
Actual Behavior
Use of local version of kiwisolver package that is build for local platform ( win64) kiwisolver.cp36-win_amd64.pyd
Your Environment
zappa 0.45.1
windows
python 3.6
Is there a workaround for this??

Sounds like it's related to: https://github.com/Miserlou/Zappa/issues/1356
The easiest workaround might be to deploy from docker: https://github.com/Miserlou/Zappa#using-zappa-with-docker

@scoates dont think its very releated. pyd is a basically dll for windows. As i understood zappa should be using manylinux wheel not a local version, but thats not happening for some reason

It should be, yeah.
#1356 is about avoiding packaging precompiled files for the wrong platform.
I agree that it's not the same problem exactly, but Zappa shouldn't be packaging those .pyd files, either, AFAIK.

@scoates i did some debug and found a reason.
Its in get_installed_packages function.
Specifically here
https://github.com/Miserlou/Zappa/blob/master/zappa/core.py#L765
package.location in [site_packages, site_packages_64]}
package.location  -> its lowercased e.g. c:\dev\pycharmprojects\hamachi_gql\venv\lib\site-packages
site_packages, site_packages_64 -> its not lowercased  e.g. C:\Dev\PycharmProjects\hamachi_gql\venv\Lib\site-packages
so  no match. Pretty serious bug. So it basically skipped half of my packages.
Something like [site_packages.lower(), site_packages_64.lower()] works and kiwisolver will be downloaded and included as wheel kiwisolver.cpython-36m-x86_64-linux-gnu.so ( although it doesnt stop *.pyd from beeing included but at least it works, including pyd is more for issue that you are linked).
Should i create a pr with the fix above?

Thanks for digging in. I'm not very familiar with that code, myself, but I'm sure if you create a PR, that's more progress than just sitting on it.
Unfortunately, we're all pretty busy with our real jobs these days. /-:

@scoates i submitted pr :)


Created image-classification project

Add a readme.md file also with the description of your project & raise another PR


[MINOR] Fix the description of README.md

What changes were proposed in this pull request?
We modify the structure of directory and we should modify the descrition
Why are the changes needed?
Modify the description of directory
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No

Codecov Report

Merging #801 (3f8baac) into master (cb83c1c) will increase coverage by 1.42%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #801      +/-   ##
============================================
+ Coverage     58.12%   59.55%   +1.42%
+ Complexity     2071     2061      -10
============================================
  Files           304      289      -15
  Lines         14816    12809    -2007
  Branches       1212     1206       -6
============================================
- Hits           8612     7628     -984
+ Misses         5712     4757     -955
+ Partials        492      424      -68

see 16 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM, would you mind update your PR title to:
[MINOR] fix: the description of spark patches in README.md

Updated. Merge master. thanks @advancedxy


Fix group history bug

Fixes #1269.
Changes in this pull request:

Added a default value unknown user when a user is no longer present in database.

Will this not work retroactively on the group already generating the error? I just tested it locally with a prod snapshot and it's still throwing a 500. I'll send more details on Slack

Will this not work retroactively on the group already generating the error? I just tested it locally with a prod snapshot and it's still throwing a 500. I'll send more details on Slack

The problem seems to be with a change in group description. Since group description is optional, they updated it to None which wasn't covered in the conditional before. Made the required change now and seems to work as expected. Please have a look.


[PE-D][Tester A] Name allows numeric inputs

Steps to reproduce
Add a customer with just numbers as his name, eg
/add-person ; name : 12345 ; phone : 98765435 ; address : Poochie Street 24 ; email<EMAIL_ADDRESS>Expected Behaviour
Expected to see an error as a name cannot have just numbers
Actual Behaviour
A customer is added with the name "12345".

Labels: type.FeatureFlaw severity.Low
original: belligerentbeagle/ped#4

duplicate isssue


Head of Personnel can create Captain level IDs

ID machine need checked to ensure only captain level ID can make other captain access level IDs.
HoP should be limited to command.

I'm pretty sure this is intended

I'm pretty sure this is intended

Fair enough, I guess HoP can promote a captain. I'll close this.


Missed tap improvements

Add a setting for tap duration/pressure if using minitouch
Update default / select button find granularity

Added in 7.4 #171


tmdb_lookup release dates

Initial WIP of adding release dates to the tmdb lookup plugin.
Few notes:

Added timed_lru_cache for lru_cache with cache expiration tho might be better to cache to disk or db to be more memory friendly
No estimator in this PR. As it doesn’t make a lot of sense because the est_movie_release is already looking at the primary release date of tmdb. The primary release date includes theatric releases. It would actually be helpfull to be able to define a type of release(s) for estimators.

Wow, sorry about my lack of response here. I'm thinking if we add this, we should store it directly in our db, rather than relying on a memory cache.


Implement bitfile reload functionality

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Adds the "Refresh Bitfile" functionality to the Custom device.
Why should this Pull Request be merged?
Currently, when a user loads an already configured bitfile which was recompiled, all the Scalar and DMA channels are automatically removed, even if these were not changed. This PR provides a solution for this problem by removing only the channels which were modified.
What testing has been done?
Built the CD locally and it passed.
Loaded the CD in VS and performed manual testing to make sure that everything is functional and the feature works as expected.

I do have the following feedback regarding the implementation:

Consider the following implementation for Get Invalid Scalar Data Channels - simpler and easier to read:

I assume you are checking here for invalid references. However, I believe that the check that is done here is not enough. The actual invalid reference value, equals "18446744073709551615" or "FFFFFFFFFFFFFFFF". "0" is the reference value for the root element in SE ... you can keep this check, but the actual validation of a valid reference has to be implemented as well.

In "Get Invalid DMA Configuration.vi" - I am not sure I understand what is the intended logic

a. If a DMA channel was already found in the old bitfile dma channels, then what is the point of creating another DMA channel with the same name ?
b. If the datatypes are different, what is the point of creating a DMA Channel with the same name, if it already exists ? The "Create Waveform Channel.vi would not do anything".
c. To be honest, I am not completely sure now, but at this point I think that the algorithm should be quite simple.  If the DMA channel was not found in SE, delete it. If it was found, then do not touch it - do not do anything. The bitfile registers will be overridden anyway with the new data, including the datatype.

There are a lot of modified files in the tests directory - I would suggest to look through those, identify the files the were modified unnintentionally and revert them.

I do have the following feedback regarding the implementation:

Consider the following implementation for Get Invalid Scalar Data Channels - simpler and easier to read:

I assume you are checking here for invalid references. However, I believe that the check that is done here is not enough. The actual invalid reference value, equals "18446744073709551615" or "FFFFFFFFFFFFFFFF". "0" is the reference value for the root element in SE ... you can keep this check, but the actual validation of a valid reference has to be implemented as well.

In "Get Invalid DMA Configuration.vi" - I am not sure I understand what is the intended logic

a. If a DMA channel was already found in the old bitfile dma channels, then what is the point of creating another DMA channel with the same name ?
b. If the datatypes are different, what is the point of creating a DMA Channel with the same name, if it already exists ? The "Create Waveform Channel.vi would not do anything".
c. To be honest, I am not completely sure now, but at this point I think that the algorithm should be quite simple.  If the DMA channel was not found in SE, delete it. If it was found, then do not touch it - do not do anything. The bitfile registers will be overridden anyway with the new data, including the datatype.

There are a lot of modified files in the tests directory - I would suggest to look through those, identify the files the were modified unnintentionally and revert them.

Looks good. I would probably recommend, after this PR is closed, to implement a unit test for the reloading functionality ... maybe a system test too.

Looks good. I would probably recommend, after this PR is closed, to implement a unit test for the reloading functionality ... maybe a system test too.

Please update this VI icon to refer to DMA:

Please update this VI icon to refer to DMA:

Get Active Section Scalars - please refactor this VI in a follow-up PR. You should break it up into manageable subVIs. As it is right now, this VI has way too many logic levels in it and it is very hard to comprehend what it does.

Get Active Section Scalars - please refactor this VI in a follow-up PR. You should break it up into manageable subVIs. As it is right now, this VI has way too many logic levels in it and it is very hard to comprehend what it does.


Handling of mixed tags + text

The currently policy, when creating marked content is to place ActualText entries in the parent StructElem. This makes the following
difficult to represent: <P>a link to <Link>google.com</Link><P>.
The ActualText entry for the entire would need to be placed in the P element, as ActualText entries don't nest. This doesn't allow google.com to be associated with the Link element.

PDF-32000 section 14.9.4 states that ActualText can be used as an attribute on /Span marked content sequences.
So maybe we need to start writing Span tags and store ActualText in the content stream.


Explore adding support for Spark DataSource V2

Just copying the discussion with @leletan on slack..
https://databricks.com/session/apache-spark-data-source-v2
https://docs.google.com/document/d/1n_vUVbF4KD3gxTmkNEon5qdQ-Z8qU5Frf6WMQZ6jJVM/edit#
https://docs.google.com/document/d/1DDXCTCrup4bKWByTalkXWgavcPdvur8a4eEu8x1BzPM/edit#
V2 Api does look much more thought out and general purpose. For Hoodie, the advantages still are a little unclear since

We have a much lighter weight integration with the spark parquet source by using path filters.. i,e we rely on spark's own parquet source for RO view anyway. iceberg implements its own IO reading, which I am not sure gets some spark improvements like vectorized reader..
The pushdown part could be useful to support incremental queries more nicely by making it part of the sql e.g where _hoodie_commit_time > 0001 is understood by the datasource and use it to filter the files to read. Today, this happens , but at the hoodie level by passing in read options.
Realtime  View is someplace where we can dig more and understand if this opens up some internal classes in spark for better performance for e.g see investigation here https://github.com/uber/hudi/issues/136
For writing, we have a commit protocol again implemented above already...

Nonetheless, we should see if we can move over to the new APIs, since v1 is so old ..

Moved over to https://issues.apache.org/jira/browse/HUDI-30


My bot isn't working it says that error no video formats found

Checklist

[ ] I'm asking a question
[ ] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
How do i fix it?

I have the same error message.
I suppose it's due to the redirection to https://consent.youtube.com as youtube-dl opens a new web session each time.

you need to provide some sort of logs (and make sure you are on the latest version)

Hi,
Well, with le last version there are no problems.
Thank you. The issue can be closed, I guess.


Execute Argo Workflow as CRON

Is this a BUG REPORT or FEATURE REQUEST?:
Feature Request
What happened:
Execute Workflows as Cron
What you expected to happen:
I would like to use Argo Workflow to create Database Backups in Kubernetes.
The process first generates a Backup of a Postgres DB, then it encrypts the Backup and in last step it uploads the backup. (This is maybe something were I don't need Argo, but...)
We also maintain Oracle Databases and there a backup is a bit more tricky:

I ask Oracle to create a backup and wait that it is finished
I download the Backup from Oracle File Storage
I encrypt the Backup
I upload the backup
I delete the Backup on Oracle File Storage

To make this continuous it would be nice to have a cron in a Workflow. Like the Kubernetes CronJob with a CRON Pattern.

Read first then write, sorry for this!

@DaspawnW or anyone else, can you post the link

i think @DaspawnW might be referring to either:

instructions, described here, for using a kubernetes cronjob which runs a container where argo submit is executed to kick off the workflow

or

using argo-events and a calendar gateway

i don't like the second option because it seems to require inlining my workflow into the sensor definition as a string -- not sure why i can't just specify it as data since i'm just putting a yaml file inside a yaml file.
maybe there's some other way to have a workflow run regularly, but i haven't found it by reading the docs and googling for the last hour or so

Following this, we ended creating a new project that simply fetches a Git repository and triggers the Argo Workflow using a K8s Cronjob.
Benefits are the control over the concurrency of workflows and that is quite simple to configure!
https://github.com/bitphy/argo-cron
How we can help in this community then!

@jessesuen @sarabala1979 Should we support this cron workflow native ?
apiVersion: argoproj.io/v1alpha1
kind: Workflow                  # new type of k8s spec
metadata:
  generateName: hello-world-    # name of the workflow spec
spec:
  schedule: "*/5 * * * *"
  entrypoint: whalesay          # invoke the whalesay template
  templates:
  - name: whalesay              # name of the template
    container:
      image: docker/whalesay
      command: [cowsay]
      args: ["hello world"]
      resources:                # limit the resources
        limits:
          memory: 32Mi
          cpu: 100m

I think I understand the reason for decouple the execution of a workflow using argo-events.
But I think scheduling is a concept that very basic in terms of workflows. It is not intuitive for users when you tell them that they need to define the scheduling somewhere else. Also, if you want to be able to schedule and also run it on demand, you will need to write it twice (inline/config-map in the sensor or a workflow file) which is not so good.
I think it will be very useful to define the scheduling as part of the workflow and allow to create a workflow from a scheduled workflow, similar to the way it is done in CronJob
kubectl create job --from=cronjob/<cronjob-name> <job-name>

@Shimi Yep, I agree.
I will try to implement this feature in the future.

apiVersion: argoproj.io/v1alpha1
kind: Workflow                  # new type of k8s spec
metadata:
  generateName: hello-world-    # name of the workflow spec
spec:
  schedule: "*/5 * * * *"

@xianlubird, I think a separate CronWorkflow CRD makes more sense than adding this functionality directly to Argo Workflows. It is a more a proper separation of concerns (following the same pattern of CronJob vs. Job). I also think feel this should be a separate controller and project.
Would you be interested in starting this off as an https://github.com/argoproj-labs project?

Yep, just like the CronJob vs Job, I think we should provide a separate CronWorkflow CRD makes sense.   But for the CronJob and Job, the controller is the same kube-controller-manager.
Can we just provide a new CronWorkflow CRD in the argo workflow project and use the same controller ?    In that case, we can reuse argo command, like argo cron list or argo cron submit, a sub command will much more convenience and we can reuse much more code. User can also just deploy argo once, and they can use cron or normal workflow in the same env.
@jessesuen    WDYT  ?

@xianlubird I'm happy to help to implement this feature. If you have started the implementation, let me know I'm ready to work on this.

@Sharathmk99   Will you implement this in argo-controller ?

@xianlubird yes sure with you guidance. I'll get started.

@xianlubird , @Sharathmk99 , when you implement this CronWorkflow, can you please include these features similar to k8s CronJob: successfulJobsHistoryLimit, failedJobsHistoryLimit and .spec.concurrencyPolicy. Thanks.

This was closed immediately after opening but has a lot of good discussion after. Can it be re-opened so it better reflects the current state?

I’m going to create a general crown resource which allows you to schedule any resource including Workflow. Maybe it can be helpful.

@dtaniwaki cool

@dtaniwaki Thanks. Waiting for this

@dtaniwaki I have something for this. Ping me next week.

@simster7 is working CRONWorkflow. He almost through.

@sarabala1979 I guess great minds think a like.

@llimon @dtaniwaki I've been working on this for the last couple of days internally. Feel free to ping me on the slack channel (@simon) if there's anything you guys want to discuss

@llimon @simster7 Thank you for implementing the feature. My progress is not so big because I was quite busy with other things. Please feel free to go ahead discussing about it between you guys.

My POC was demoed to the internally with good feedback.
This is what I have all working:
Workflow scheduler and orchestration engine for Kubernetes.
Is targeted to ETL, Batch Processing, ML and where work needs to be orchestrated.
In its basic mode It runs on a cronSpec, What makes a difference is Workflows are sourced from GitHub. Allowing to have a version, PR, etc. Keeping GitOps & infrastructure as code.
apiVersion: workflowscheduler.argoproj.io/v1alpha1
kind: WorkflowScheduler
metadata:
  name: example-foo
spec:
  cronSpec: "*/1 * * * *"
  workflow:
    sourceType: github
    scheme: https
    repo: https://github.com/llimon/workflowscheduler-examples.git
    branch: master
    path: "workflows/hello-world.yaml"

The more interesting mode adds "FileWatchers". This is the ability to monitor for file patterns in repositories. Once it is detected a workflow will be initiated, This allows us to "chain" workflows and create complex Execution patterns and combining workflows. It allows controlling how frequently to verify for trigger files.
kind: WorkflowScheduler
metadata:
  name: workflow-load-db
spec:
  workflow:
    sourceType: github
    scheme: https
    repo: https://github.com/llimon/workflowscheduler-examples.git
    branch: master
    path: "workflows/bye-world.yaml"
  fileWatcher:
    type: s3
    bucket: argoscheduler-sample
    region: us-east-1
    AWSKeys:
      secret: example-aws-s3-secret
      accessKeyID: accessKey
      secretKeyID: secretKey
    path: transformed-file.dat
    launchExt:  ready
    finishExt:  done
    processingExt: processing
    renameOnStart: true
    renameOnFinish: true
    frequency: "@every 1m"

PS. * I defined AWSKeys with different format than ArgoWorkflows, I think it makes a little more sence and Does not require to lookup for multiple k8s Secret objects.

I got feedback about possibly grouping launchExt, processingExt, finishExt and true false flags.

Current status: All POC features are functional, running locally. This week I'll be refactoring the resource name, work on travis and running inside k8s.

https://github.com/argoproj/argo/pull/1758 is now ready for community review and feedback

Argo version:
$ argo version

argo: v2.2.1
  BuildDate: 2018-10-11T16:26:28Z
  GitCommit: 3b52b26190163d1f72f3aef1a39f9f291378dafb
  GitTreeState: clean
  GitTag: v2.2.1
  GoVersion: go1.10.3
  Compiler: gc
  Platform: linux/amd64

I runned the command, but don't worked:
$ argo cron create template-argo.yaml

Error: unknown command "cron" for "argo"
Run 'argo --help' for usage.
unknown command "cron" for "argo"


Update all deps

Second attempt to fix this...

It passes locally for me now. I don't have the patience to wait for Travis and I just want this to fixed, so merging


SEO Metatags

The Story content type has SEO fields, but the data is not in the response now...well, it is but it isn't declared in the essential-cu app data layer.
They will need to be added to pages, but this can be done after Voltage's work is done.

This is derived from other fields.


Test local image

Describe your changes
Add local docker image test workflow
How best to test these changes
This change is the test.
Issue ticket number and link

Codecov Report
Base: 32.42% // Head: 32.42% // No change to project coverage :thumbsup:

Coverage data is based on head (ec3f8e5) compared to base (050d47a).
 Consider uploading reports for the commit 99738be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #726   +/-   ##
=======================================
  Coverage   32.42%   32.42%
=======================================
  Files         128      128
  Lines       14367    14367
=======================================
  Hits         4659     4659
  Misses       9277     9277
  Partials      431      431

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update main to use setup.File interfaces

This change updates main to use the new setup.File interfaces and completes unit test coverage.
Note: this is a breaking change with respect to the original handling of flags. The flag package is changed from github.com/spf13/pflag so that we can take advantage of flagx.ArgsFromEnv and flagx.StringArray. As well, the separate flags for metric '--type' and '--query' filename are combined as --guage-query. This change removes support for counter queries, but adds a TODO. Counters are a special use-case that make queries more expensive and might be suited to a different collector implementation.

This change is

Pull Request Test Coverage Report for Build 59

44 of 44 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 57:
0.0%

Covered Lines:
222

Relevant Lines:
222

💛  - Coveralls


Batches should be.... streams....and tested

It occurs to me now after converts to mocha testing that batches don't have test cases and should probably be a stream pattern.

Sounds good to me :)

Track here: https://github.com/ipfs/js-ipfs-merkle-dag/pull/25


Update Akka HTTP to 10.1.12

Not strictly important right now, but makes the delta of upgrading
Akka gRPC smaller later ;)

Thanks. LGTM.


New release?

It'd be great if a new release was issued so that homebrew can package it up. Thanks! ✨

thanks! PR sent to homebrew: https://github.com/Homebrew/homebrew-core/pull/2444


x/pkgsite: package removal request for https://pkg.go.dev/github.com/hbread00/swt

What is the path of the package that you would like to have removed?
https://pkg.go.dev/github.com/hbread00/swt

Are you the owner of this package?
Yes

What is the reason that you could not retract this package instead?
source code repository is no longer accessible

This is done.


OCI Artifacts to store signatures

Question

Hello everybody,
Now that also docker has introduced support for OCI artifacts, I would like to know if there is an ongoing effort to store signatures as such, using the latest changes deriving from the work done by the Reference Types Working Group, who introduced subject field and referrers api to properly implement artifacts that refers to other ones like signatures.
I am seeing that also go-containerregistry is working on something, so maybe cosign could use it when it's done
Thank you!

cc @jdolitsky @imjasonh
We should be able to switch to storing signatures as OCI artifacts whenever now that Dockerhub has added support.
We're also planning to switch to the new reference types API and are prototyping it now!

Duplicate of https://github.com/sigstore/cosign/issues/1397


BI-2328 and BI-2355 failed QA

BI-2328 Experimental observation file import removes periods from column headers
BI-2355 Non-informative error message: regression
If the user attempts to import an experiment with periods or square brackets in the observation headings.  The user will get an error.
Checklist:

[x] I have performed a self-review of my own code
[x] I have tested my code and ensured it meets the acceptance criteria of the story
[ ] I have tested that my code works with both the brapi-java-server and BreedBase
[ ] I have create/modified unit tests to cover this change
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to documentation
[ ] I have run TAF: <please include a link to TAF run>

@nickpalladino great point. @davedrp I checked against the production bidb database using the query below, and it appears that there are 43 ontology terms that currently have "." in the name. No square brackets.
SELECT *
FROM trait
WHERE observation_variable_name ~ '[.\[\]]';

@mlm483 @nickpalladino
As the code is, in production, the experiment could not reference an ontology term with a period, because the period would have been removed from the experiment observation heading (it would no longer match the ontology term).
With the new code, the user can edit any ontology term that contains a period.

it would no longer match the ontology term).

So just to make sure I understand, in the existing production code it's not possible to import experiment observations referencing an ontology term with periods or brackets so we won't have any existing observation to worry about. If that's the case I'll approve.

@nickpalladino Yes, we won't have any existing observation to worry about.


Update defineConfigurable.js

@hashplus thanks, I really appreciate it!
And I'll setup travis to not run sauce tests on PR branches.


Dsa website internal pages

@jtomeck
As we discussed, these are the things that needs to be fixed:

Logo not showing on internal pages (i think it was showing earlier, there must be something i did wrong here).
in ‘success-stories-list.html’ file, could you make the rows full with.
Fix story-id in success-story.html file. right now i am passing story-id via url and trying to load the story based on that. (i am not sure if this is right approach. i will explain this to you on chat)
And any other bugs fixes/design fixes/code optimization/ that you think needs to be done

3. Fix story-id in success-story.html file. right now i am passing story-id via url and trying to load the story based on that. (i am not sure if this is right approach. i will explain this to you on chat)

@jtomeck  this one is fixed.  (in commits 9e43e08 and c85065b)

@manthey
Papers and publications page: added all publications mentioned in the document. used 'chicago annotated bibliography' format. along with their PMID links.
Demo: for now i have just put one demo link that you provided in figma mockup comment. let us know when you have more content for this page.
Success stories this page shows two stories that were mentioned in the document. adding more stories will only require entering story data and image.

Just a note if you are viewing this on the Circle-CI artifacts: because Circle doesn't automatically resolve directories to the included index.html page, you have to manually navigate to the subpages, even though the links will work in the Github deployment.

Just a note if you are viewing this on the Circle-CI artifacts: because Circle doesn't automatically resolve directories to the included index.html page, you have to manually navigate to the subpages, even though the links will work in the Github deployment.

Thanks! i was trying to view it, wasn't working for me.
and thanks for your reviews. i will resolve those next week.

@faiza-a - I will be getting to reviewing this tomorrow. Just want to make sure you know I'm not ignoring it.

We had some buttons on the top bar that we removed since they would have linked to stories, demos, and publications (I think).  With this PR, those pages will exist.  Should we readd those top bar buttons?

We had some buttons on the top bar that we removed since they would have linked to stories, demos, and publications (I think). With this PR, those pages will exist. Should we readd those top bar buttons?

Yes ill add those. thanks for reminding.  i always forget about the header :D

We had some buttons on the top bar that we removed since they would have linked to stories, demos, and publications (I think). With this PR, those pages will exist. Should we readd those top bar buttons?

Yes ill add those. thanks for reminding. i always forget about the header :D

header links added in 30834c95569dff67f1c47e5a3c6f3fe3af212c82

@manthey we have made the changes you requested and have made some other changes. could you please review the pages again

I notice that the "Contact" menu (which, when hovered, opens to show Visit Contact Page and Show Email) is itself clickable but just goes to the page you are on.  I would expect that it wouldn't be a link by itself.

I notice that the "Contact" menu (which, when hovered, opens to show Visit Contact Page and Show Email) is itself clickable but just goes to the page you are on. I would expect that it wouldn't be a link by itself.

Fixed in f144c1a676e867e6fdcf90bfa73c44dbeb74e460


GUVNOR-2827: [Guided Decision Table] Not possible to create two conditions based on the same negated pattern

See https://issues.jboss.org/browse/GUVNOR-2827

@Rikkola @karreiro I've commented where the actual changes are.. otherwise it's all formatting.

Part of an ensemble:-

https://github.com/droolsjbpm/drools/pull/1105
https://github.com/droolsjbpm/drools-wb/pull/399

Would just like to check if the IllegalStateException is checked with a test.


Incorporate disk/bulge modeling into mock-production pipeline

PR #31 brought in new models for the disk-bulge decomposition. Calls to these functions need to be incorporated into the mock-production pipeline script.

PR #35 brings in disk/knot decomposition kernels that also need to be incorporated into mock-production pipeline.


feature: add a function to validate token transactions on the client

add a function like IsTokenVout in js

made validateTokensV2Many


As an industrial operator, I want to log in to the registration app so that I can register my operations (facilities)

Part of IAM Epic. Closing. User story map updated.


Major cleanup of the build system

Following the commit c7087eb that broke the distcheck it was supposed to
fix, many changes:

avoid repeating things without overdoing it

soft require of rst2man as it used to be

rely on the autotools test driver

create a PATH for the test suite
Instead of just resolving varnishtest and varnishd, the test suite
is run with the right path and can pick up any other varnish tool.

a varnishtest macro similar to the built-ins for std and directors
It hides the details of the build system away from the test cases and
now recommends a cleaner syntax: import ${vmod_example};

no need to rely on $(builddir) for make dependencies

Fixes #25 #26 #27

@lkarsten please take a look at this

@gquintard aka autotools authority: ping

If I'm not mistaken, "-Wall -Werror -Wextra" is wrong for CPPFLAGS.
$(VCC_FILES) $(DOC_FILES): vmod_example.vcc
is a bit wrong, that recipe may be executed multiples times, but as long as the files are created atomically, we're good.
Using vmod_example.vcc instead of vcc adds one extra occurrence of the name though.
Did you check that "make check" builds the vmod before testing it?

If I'm not mistaken, "-Wall -Werror -Wextra" is wrong for CPPFLAGS.

Where shoud I put them?

$(VCC_FILES) $(DOC_FILES): vmod_example.vcc
is a bit wrong, that recipe may be executed multiples times, but as long as the files are created atomically, we're good.

It can happen with parallel builds, but how can I express that a single source will build several target otherwise?
That being said, I've tried to break this numerous times but the files seem to be indeed created atomically, I couldn't fail a parallel build despite this situation.

Using vmod_example.vcc instead of vcc adds one extra occurrence of the name though.

I name it vmod.vcc for my own VMODs, but I wanted to focus on the build for this PR so I didn't touch this part.

Did you check that "make check" builds the vmod before testing it?

I did, I have a bunch of tests to make sure I didn't break anything else, and this is one of them.

Where shoud I put them?

*_CFLAGS, IMHO.

It can happen with parallel builds, but how can I express that a single source will build several target otherwise?

Usually, you'd use a pattern like:
file1 file2 file3: file4
file4: generator.py
Kind of like what was done with the vcc target
But, it really doesn't matter here is parallel build can't break the build.

I name it vmod.vcc for my own VMODs, but I wanted to focus on the build for this PR so I didn't touch this part.

My bad, I misread that part!

Usually, you'd use a pattern like:
file1 file2 file3: file4
file4: generator.py

Very hacky workaround :)

Kind of like what was done with the vcc target

The vcc target was my mistake, it leads to #27 because the target wouldn't map to a file, be it phony or not.

This seems to do the job without breaking the DRY attempt:
-$(VCC_FILES) $(DOC_FILES): vmod_example.vcc
+$(VCC_FILES) $(DOC_FILES): .vcc
+
+.vcc: vmod_example.vcc
        @echo vmodtool: @VMODTOOL@ $<
        @@VMODTOOL@ $<
+       @touch $@

If I'm not mistaken, "-Wall -Werror -Wextra" is wrong for CPPFLAGS.

Also forgot to mention that I only introduced the -Wextra flag to tighten the build a bit further. Looking at the automake manual it seems to belong in configure.ac in AM_INIT_AUTOMAKE.
I'll do more testing and push commits.

@gquintard: ping (see the new batch of commits above)

Looking good.
the --with-rstman=true is a bit weird, but hey, it's autotools!
I think bmake doesn't support the $< variable. But autotoosl are a GNU build system, so, I wouldn't worry about that either.
instead of systematically adding '@' in front of your command, you can use "$(AM_V_lt)", that will allow to show the command with make V=1

Rebased against current master because of conflicts with #31


Poly does not faithfully keep label names the same

Describe the bug
In puc19.gbkthe first primer is named /label="M13/pUC Reverse". If read through Poly, this gets changed to /label="M13pUC Reverse"
Expected behavior
The labels should be the same.

There was some annoying reason why this was hard to do when I first wrote the genbank parser. Would be happy if someone could fix this if it's still an issue.

I think it might be fixed in my newer version of the genbank parser #221

Is this fixed? I can't recreate this using the test functions


⚠ Bofrost.at has degraded performance

In de649f3, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 835 ms

Resolved: Bofrost.at performance has improved in 3f44bb7.


Ability to evaluate from Variable Explorer

When I look at the Datasets package:

I can't view any of them from Variable Explorer until I evaluate them in REPL, ie.
datasets::airmiles

Then I can use Variable Explorer to view that dataset.

I wish I could force that evaluation directly from Variable Explorer, because Show item details is not present on those lazyLoadDBFetch.

I suspect this is basically https://github.com/Microsoft/RTVS/issues/751. When you hover over the icon for the variable, the tooltip should give the type and the class - I expect it to be "active binding" for these. Is that right?

Tooltip for icon says <promise> (<promise>)

Ah, indeed, that makes more sense. But it's still #751. :)


Malin onboarding

Let's give Malin a nice and welcoming onboarding! 🥳

Onboarding

[ ] Let's get productive!

[ ] Add to slack channels
[ ] Prepare list of nice first issues
[ ] Setup and run code locally

[ ] Meet the team!

[ ] 20 min 1-1 call with @SvSven
[ ] 20 min 1-1 call with @fernandolucchesi
[ ] 20 min 1-1 call with @padms
[ ] 20 min 1-1 call with @nilsml
[ ] 20 min 1-1 call with @bhavi25

[ ] Overview of code practices and development flow

[ ] ZenHub
[ ] Agile methodology (Sprint / Meetings)
[ ] Prettier / Gitmoji
[ ] How we do code review
[ ] How we deploy to prod
[ ] Environments
[ ] Feature Flags

[ ] Overview of documentation and repositories

[ ] Wiki / Runbook
[ ] GitHub
[ ] Azure

[ ] Overview of tech stack

[ ] Architecture
[ ] Next
[ ] Sanity
[ ] Radix
[ ] Azure
[ ] Styled Components

[ ] Overview of Equinor process

[ ] Service now
[ ] AccessIT
[ ] Team structure

Topics suggestions for knowledge sharing

[ ] Satellites setup
[ ] Roles and permissions
[ ] CI/CD
[ ] Azure
[ ] Brandmaster /  Fotoware
[ ] Routing in Sanity
[ ] Search (Algolia)
[ ] Forms / FriendlyCaptcha
[ ] Webhook / Newsletter

This is a great list!


Standardize urn:problem-type:belgif:input-validation:referencedResourceNotFound

https://github.com/belgif/rest-guide/issues/126.

@pvdbosch wasn't there also some consensus in the workgroup around urn:problem-type:belgif:input-validation:invalidStructure?

@pvdbosch wasn't there also some consensus in the workgroup around urn:problem-type:belgif:input-validation:invalidStructure?

There was consensus that standardization is needed for this use case, but there are still some points to discuss:

the fine line between 'schemaViolation' and 'invalidStructure': is such a distinction useful for an API user; does the distinction depend too much on implementation of validation?
check if everyone is OK with the name of the issue type


Allow blurring on startup.

added package-lock, more info here: https://github.com/obsidianmd/obsidian-sample-plugin/pull/23
added blurring on startup
added blurring automatically after inactivity timeout
added possibility to disable blur on hover: https://github.com/jillalberts/privacy-glasses/issues/4

Incorporated into v0.6.0, which should be available now in the Community Plugins directory. Great work. Thank you!!!

Thank you for accepting!


Nrf5340 fix bord enable cpunet

Clarifying and correcting some thing in the usage of config BOARD_ENABLE_CPUNET option.
Fixes #24147

FYI @grochu


Circular definition causes variable editing issue

If you construct a variable with a circular definition you quite rightly get a warning. However, if you then hit the spacebar, the variable preview empties, and the regenerate / add a variable buttons no longer function, even on correcting the variable definition. (It can be resolved by refreshing the page).

There's a "maximum call stack size exceeded" error, which implies that some knockout computed observables have circular references to each other somewhere along the line. I can't see exactly where it happens, but I can probably pin it down.


valuable review from @marthjod

Coverage increased (+53.27%) to 91.67% when pulling 1cd7702356b280a23bfc233a7b4c79da8c92e333 on marthjod:master into 2e209fb4aa928e05745a5d1dbf0c64280a1ee612 on nmesstorff:master.

Coverage increased (+53.27%) to 91.67% when pulling 1cd7702356b280a23bfc233a7b4c79da8c92e333 on marthjod:master into 2e209fb4aa928e05745a5d1dbf0c64280a1ee612 on nmesstorff:master.


Add support for primitive data types in responses

Hi,
As far as I can see, grape-swagger supports object and file schema types grape-swagger#response-documentation but it does not support primitive data types (unless wrapped in a grape entity) as swagger 2.0 specification does Swagger 2.0#responsesDefinitionsObject.
This causes that the next response specification which is valid for swagger 2.0 cannot be generated using grape swagger:
{
  "description": "A simple string response",
  "schema": {
    "type": "string"
  }
}

So ideally I would like grape-swagger to support the schema type key to the responses, allowing us to specify responses using primitive data types like swagger 2.0 specifies.
As an example, adding the schema type key would allow us to describe primitive data type in responses:
success [
  { message: 'A simple string response' , type: String, as: :user_name },
]

which should generate the next specification:
{
  "description": "A simple string response",
  "schema": {
    "type": "string"
  }
}

Also the type schema should allow us to describe primitive data types directly into object schema types without the need to wrap them in a grape entity, as an example:
success [
  { model: API::V1::Entities::Roles::User, as: :users, is_array: true },
  { type: String, as: :page_token },
  { type: Integer, as: :count }
]

which should generate the next specification:
        "responses": {
          "200": {
            "description": "Return a list of users for given user role",
            "schema": {
              "type": "object",
              "properties": {
                "users": {
                  "type": "array",
                  "items": {
                    "$ref": "#/defs/API_V1_Entities_Roles_User"
                  }
                },
                "page_token": {
                  "type": "string"
                },
                "count": {
                  "type": "integer"
                }
              }
            }
          },

Would it be possible to add support for primitive data types as described in this issue? I can work on a PR if you agree. Thanks!

Hi @pablomg92z … in general I agree with a PR, but have one question.
For me the last example looks perfect, but the in the first and second one, there tha :as keyword exist, but will not used in the spec, is it wanted?

Hi LeFnord, thanks for your quick reply! and good catch, I should have not included the :as keyword in the first example since it adds no value when defining primitive data type schemas (which is why it was not present in the output spec), the :as keyword only makes sense for object type schemas.
I will proceed to create the PR then where I add support for the type keyword to describe primitive data types and arrays.
PS: What I can include in a future PR as well is the addition of the :format keyword as specified in Swagger 2.0#DataTypes which is an optional modifier property for primitives.

Is there any progress on introducing these primitive types into a successful response?
I have an endpoint that return a list of string and I would love the FE api to have the docs generated properly.
Or if there's a way to make this happen now I would love to know.... 🙏

@LeFnord @Sashasugar Hi, I also need this feature. Any update?

@LeFnord @Sashasugar Hi, I also need this feature. Any update?

@mopp I opened a PR to address that