Reproducible doc

Great extension of craigs work and thorough guide, thanks! Have you seen issue #199 ? Maybe something to add to the guide?!

@RequestPrivacy I do not know yet how to clone the submodule also with https, so can't test that.

@RequestPrivacy I do not know yet how to clone the submodule also with https, so can't test that.

Craig fixed the issue in https://github.com/sparrowwallet/sparrow/issues/199#issuecomment-922994595 and updated the README.md.  Maybe you want to reflect the new https cloning possibility in your REPRODUCIBLE.md file / pull request, so that once it potentially becomes merged is up to date.

superseded by https://github.com/sparrowwallet/sparrow/pull/675


Support of all events

why all events provided by original project is not implemented? Events like eventDragStart, eventDragStop is not there. If I am wrong please forgive me and give info about how to implement it.

Yes, it will be in the next release

Bump on this too, as I would like to use the eventAfterRender function.


Duplicate Refresh Token

Hi,
I'm having a problem with Refresh Token, my system has many users who are connecting to Google Calendar. I don't why some of them has duplicate refresh token. Here is an example
Does anybody encounter this one?

Have you been able to work out whether this is the server returning the same refresh token to multiple calls, or whether one user's refresh token is being used where another's should be? Are you able to provide any code to reproduce the issue?

The picture you are posting is unclear.   Refresh tokens are unique to each user + client project.   When your user authenticates your application a Refresh token is grated giving you access to their account two users will never have the same refresh token for a project (client id, client secrete) this would break an integral part of Oauth itself.
I would like to recommend that you post your code and your issue on stackoverflow tag your question with Google-api-dotnet-client and I will find it and try and help you debug your issue.

Closing as stale. Please re-open if this needs further investigation.


Support for React Native

I'm currently working on some apps that use React Native. Since this Flux lib really reflects my needs and taste for what I want to do, I would like Redux to be usable in React Native as well. Currently it has a hard dependency on React-web. I believe a similar approach to what's done with Flummox is possible here.
What do you think?

I'd be thrilled to accept a PR adding RN support.

Yeah, Flummox uses a factory to insert the correct version of React and it works well https://github.com/acdlite/flummox/blob/master/src/addons/react-native.js.

Cool! I'll dive into this then!


Small button ui update (suggestion)

I think buttons looks little nicer with transparent background.
I also changed border color to little darker variant of gray. It looks ok on every background (since background is now transparent).
It's up to you.

Look how easy I am. :D

You're awesome. :facepunch:


Fix filtering for duplicate imports

If a script contained multiple imports for the same
class (e.g. IntelliJ init scripts), our filter didn't
work as it relied on the instance
equality but looking up the import always yields the first
import node. This then fails as we try to compile the script
before resolving those dependencies.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.


add romaji2kana converter

Hi
I added a converter of latin alphabet (romaji) to Japanese hiragana/katakana syllabary. Could you merge?

Hi I added a converter of latin alphabet (romaji) to Japanese hiragana/katakana syllabary. Could you merge?
It was looking quite interesting so have I have merged it to the main branch.


MMS: Catalan "L·L" inferred sound wrongly

Context: Middle dot U+00B7 is used in Catalan language as inner word punctuation/diacritical mark just to difference pronunciation of "L·L" and "LL". "L·L" sounds a long el (cel·la, goril·la, excel·lent, paral·lel), and "LL" sounds like /ʎ/ (cella, lluna, allà).
TTS from MMS ignores Catalan middle dot. I've inferred some audios from texts in Catalan language, and there is an issue around Catalan L·L. TTS from MMS treats L·L like LL. It's wrong,
L·L must sound like a single el or, in a very formal context, like a long el. Example "goril·la" sounds like /ɡuˈɾi.ɫə/ or /ɡuˈɾiɫ.ɫə/ formal, but generated audios with MMS sound like  /ɡuˈɾiʎə/ (it's wrong)
I've tested with several words containing L·L and this issue always arises: "L·L" always sounds wrongly like /ʎ/.

It looks like middle dot was included as a punctuation in MMS - https://github.com/facebookresearch/fairseq/blob/main/examples/mms/data_prep/punctuations.lst#L94
So, we are indeed ignoring it in MMS. We will try to fix it in our next release.


[workers] add migration guide for v3

Adds instructions to help users update v2 to v3.

btw just tried again, no luck. Is there an unknown, undocumented system requirement that perhaps used to work in upgraded in the v2 world that wont work when going to v3?


Context cleanups

@JeffreyRichter We previously forced every context to belong to the application.  Cancelling the application, cancelled everything.  These updates, as agreed upon in the meeting, removes that behavior.
This was our previous statement
 @details The root node in the tree (ultimate parent) is #az_context_application which is a context for the entire application. Each new node is a child of some parent.

We previously forced every context to belong to the application. Cancelling the application, cancelled everything. These updates, as agreed upon in the meeting, removes that behavior.

How so? This PR (at least currently) is disallowing multiple roots, and we only have just one az_context_application. That is the only context with a null parent, and all other contexts must be created as children of it. There is no other way to create another context.
If we ever want to allow multiple roots in the  future, we can allow passing in NULL as a parent to the create methods, and  that's when we would get the behavior you are concerned with.

Another design question, @JeffreyRichter, should az_context_get_value(...) include expired contexts as part of its search?
I think when looking for a value using a key of an expired context, we should return AZ_ERROR_ITEM_NOT_FOUND, or return the value with an error, AZ_CONTEXT_EXPIRED. This would mean that az_context_get_value(...) needs a int64_t current_time parameter.

To support the precondition behavior we can no longer inline functions for the context.
cc @JeffreyRichter

We previously forced every context to belong to the application. Cancelling the application, cancelled everything. These updates, as agreed upon in the meeting, removes that behavior.

How does it remove that behavior? This PR (at least currently) is disallowing multiple roots, and we only have just one az_context_application. That is the only context with a null parent, and all other contexts must be created as children of it. There is no other way to create another context. We are still forcing every context to belong to the application, which means cancelling the application, cancels everything.
If we ever want to allow multiple roots in the future, we can allow passing in NULL as a parent to the create methods, and that's when we would get the behavior you are concerned with.

Keep in mind that the previous design didn't ensure everything was rooted to the application.  The statement was never true, but it was the statement the original author made.  I want to be clear that we are dropping that statement and not fixing it.

There is no other way to create another context.

az_context my_root_context = { 0 };

Here is the code to create a context that is not rooted as the application
   az_context my_root_context = { 0 };
   az_context context_with_null_parent = az_context_create_with_expiration(&my_root_context, 12345);
   az_context context_with_different_null_parent = az_context_create_with_expiration(&az_context_application, 12345);

If you look at the code you'll see that the parents are different, yet both are roots.

Here is the code to create a context that is not rooted as the application

Lol, not sure if that was sarcastic, but you got me there 😊
The customer can also do this too, doesn't mean it is what we expect or support them doing for defined behavior.
az_context i_am_the_application_now = { ._internal.parent = NULL, ._internal.expiration = 10 };
az_context_application._internal.expiration = -1;
az_context_application._internal.parent = &i_am_the_application_now;

Another design question, @JeffreyRichter, should az_context_get_value(...) include expired contexts as part of its search?
I think when looking for a value using a key of an expired context, maybe we should return AZ_ERROR_ITEM_NOT_FOUND, or return the value with an error, AZ_CONTEXT_EXPIRED. This would mean that az_context_get_value(...) needs a int64_t current_time parameter.

Yes

Another design question, @JeffreyRichter, should az_context_get_value(...) include expired contexts as part of its search?
I think when looking for a value using a key of an expired context, maybe we should return AZ_ERROR_ITEM_NOT_FOUND, or return the value with an error, AZ_CONTEXT_EXPIRED. This would mean that az_context_get_value(...) needs a int64_t current_time parameter.

The fact that expiration and key/value is on the context with the expiration is an implementation detail.  The are unrelated.  We merely keep them together as a convenient way to smuggle the data on the context.

@ahsonkhan I've addressed your feedback please remove your block so this PR can be commited.


how can I add this code to SDN in mininet for wireless sensor personal area network (PAN)

hello, how are you today?
code you please help me to add this part to mininet , I don't know how can I add this part to SDN simulate wireless sensor personal area network (PAN) .

I'm afraid I don't use Mininet, so I couldn't really tell you.  Perhaps the Mininet community can shed some light.


Create GitHub issue with GitHub API

This is an auto-generated issue due to PR#8
// Pseudo-code for creating a GitHub issue
var client = new HttpClient();
client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", "YOUR_ACCESS_TOKEN");

var issueData = new {
    title = "Issue Title",
    body = "Issue description"
};

var content = new StringContent(JsonConvert.SerializeObject(issueData), Encoding.UTF8, "application/json");

var response = await client.PostAsync("https://api.github.com/repos/owner/repo/issues", content);

if (response.IsSuccessStatusCode) {
    Console.WriteLine("Issue created successfully.");
} else {
    Console.WriteLine("Failed to create issue.");
}

Note: This is just a suggestion and pseudo-code

It is done


fix spelling typo

fix #14809

Thank you for your first contribution! Now the CI error is due to something wrong with the community upgrading the Zookeeper version, which has now been fixed, and you can start a new commit and run the CI test again.

LGTM

@heliang666s  hi, thanks for your review, but I have nothing to commit any more, is it necessory to run the CI test again?  if it is , how can I run it again without a new commit?

you can try Merge branch '3.3' into ‘3.3’ or push an empty commit. @wsliliang

@heliang666s thank you I tried but CI test still not success

Judging from the error logs, this may be because there are other PRs running CI tests as well, which is causing the port to be occupied. You can wait a little longer and try again. @wsliliang


Default Policy/TOS documents

Do we really need defaults? I have a feeling it may be a better idea to leave it up to the administrator to choose their own policy/TOS document(s) as appropriate. We're not in the legal business; we're just providing the means for letting users view this information.

I think the intent of this issue was just to have a default uri that points to placeholder docs in /public the Connect user can swap out for their own. A gentle reminder that they really should have these docs available.

This is in the spec, so it's here for completeness. It may be appropriate to just close the comment and leave it as is. We support the fields in the client schema and that's probably enough.
Let's leave it open a little while longer and see if anyone else has an opinion.


8.3.8

In order to take PR #4722 live, we need to bump the version number.

Do we have an update? Blocks from upgrading to react 17

Released in v8.3.8.


Embedding literal JSON without serializing as a string

My database generates some JSON and I'd like to embed it as literal JSON without escaping. Currently it gets serialized as a string. Is this possible?

Did you figure this out?

It seems Netflix has abandoned this project. The community created a new
fork to continue supporting this project. Please refer
https://github.com/fast-jsonapi/fast_jsonapi
On Sat, Oct 19, 2019 at 10:35 AM Vikas Yadav<EMAIL_ADDRESS>wrote:

Did you figure this out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/fast_jsonapi/issues/435?email_source=notifications&email_token=ACEAHZLIECXC3HY4KSYTTF3QPKISXA5CNFSM4IHIWSSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXFAQY#issuecomment-544100419,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACEAHZMVD7RI2AILFRFAKHDQPKISXANCNFSM4IHIWSSA
.


Hieradata, pdk, workflow update

Updating hieradata to version 5
Updating PDK to latest 2.1.1 version to clear warnings in workflows
Adding matrix tests to ensure that all major puppet versions are covered

Hi @LDaneliukas !
Thanks for this new contribution!
We will try to check on the proposed changes of this PR soon, they look pretty good.

Hi @LDaneliukas !
Thanks for this new contribution!
We will try to check on the proposed changes of this PR soon, they look pretty good.

Thanks. This is a simple pdk update for the most part, so not much for manually done changes apart from testing all Puppet versions. I've finished Windows support that I can submit after this PR is merged.


Update VMware Tanzu twitter and links

Signed-off-by: jonasrosland<EMAIL_ADDRESS>Pre-submission checklist:
Please check each of these after submitting your pull request:

[X] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[X] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[X] Have you picked the single best (existing) category for your project?
[X] Does it follow the other guidelines from the new entries section?
[X] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[X] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[X] Does your project/product name match the text on the logo?
[X] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[x] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Deploy preview for landscape ready!
Built with commit f086973a73b037a592618ade9b8f9aeb697b8db3
https://deploy-preview-1636--landscape.netlify.app

LGTM


IntegrationTestFailures - ReadFeedDocumentTests times out in cosmos live integration tests

Describe the bug
ReadFeedDocumentTests#readDocuments() times out in cosmos live integration tests.
Exception or Stack Trace
2020-07-25T17:51:09.5963080Z [ERROR] ReadFeedDocumentsTest::readDocumentsDirect Tcp with Session consistency  Time elapsed: 40.019 s  <<< FAILURE!
2020-07-25T17:51:09.5980099Z org.testng.internal.thread.ThreadTimeoutException: Method com.azure.cosmos.rx.ReadFeedDocumentsTest.readDocuments() didn't finish within the time-out 40000
To Reproduce
Run java cosmos tests - live integration tests
Expected behavior
Should pass :)

Fixed with : https://github.com/Azure/azure-sdk-for-java/pull/13576


[DS-3457] Address tomcat hang when multiple solr shards exist in DSpace 6

This PR addresses DS-3457 and DS-3458.
The service initialization logic in DSpace 6 introduces a fatal bug when multiple statistics shards are present.
In order to address this, this code defers the initialization of the solr shards until tomcat is processing requests.  On the first request to the server that is requesting statistics data, any existing shards will be started. Example /handle/XXX/YYY/statistics.
Unfortunately, this leaves the shard repos uninitialized until such a request has been made.
A better approach would be to trigger this initialization at the moment that the /solr service has started.  I attempted to add this to a ServletContextListener, but I was not able to get that listener to fire at the correct time.
I suspect that a better approach exists.  I am putting this PR forward to start a discussion.
This code may be easier to test if you also install https://github.com/DSpace/DSpace/pull/1624.
See the following page for an overview of the existing sharding issues. https://wiki.duraspace.org/display/~terrywbrady/Statistics+Import+Export+Issues

The moment we move to Solr 5+ we would lose the ability to trigger this at Solr startup, since it is packaged only to run with its integrated copy of Jetty and won't be running in Tomcat.  Any long-term approach to this problem should keep that in mind.

+1 by review


Adapt Amber test to PE 18.07

Status: module not available.

Now that the module is available the Amber tests pass.


[COE CLI] Exception when attempting to generate install file.

When I run the COE CLI to generate the install file it throws an exception that a file is missing (coe-cli\config\alm.schema.json).  Where do we get the file?
Here is the log generated by the coe cli for two attempts.
{"level":"info","message":"Generate Install start","timestamp":"2022-01-25 03:32:22 PM -0500"}
{"date":"Tue Jan 25 2022 15:41:14 GMT-0500 (Eastern Standard Time)","error":{"code":"ENOENT","errno":-4058,"path":"D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json","syscall":"open"},"exception":true,"level":"error","message":"uncaughtException: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'\nError: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'","os":{"loadavg":[0,0,0],"uptime":522173},"process":{"argv":["C:\Program Files\nodejs\node.exe","C:\Users\topsh\AppData\Roaming\npm\node_modules\coe\coe","alm","generate","install","-o","test.json"],"cwd":"D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli","execPath":"C:\Program Files\nodejs\node.exe","gid":null,"memoryUsage":{"arrayBuffers":41550,"external":969162,"heapTotal":51363840,"heapUsed":48486128,"rss":73998336},"pid":12708,"uid":null,"version":"v16.13.2"},"stack":"Error: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'","timestamp":"2022-01-25 03:41:15 PM -0500","trace":[]}
{"level":"info","message":"Generate Install start","timestamp":"2022-01-25 03:43:45 PM -0500"}
{"date":"Tue Jan 25 2022 15:44:56 GMT-0500 (Eastern Standard Time)","error":{"code":"ENOENT","errno":-4058,"path":"D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json","syscall":"open"},"exception":true,"level":"error","message":"uncaughtException: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'\nError: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'","os":{"loadavg":[0,0,0],"uptime":522395},"process":{"argv":["C:\Program Files\nodejs\node.exe","C:\Users\topsh\AppData\Roaming\npm\node_modules\coe\coe","alm","generate","install","-o","test2.json"],"cwd":"D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli","execPath":"C:\Program Files\nodejs\node.exe","gid":null,"memoryUsage":{"arrayBuffers":41613,"external":968771,"heapTotal":51888128,"heapUsed":48957344,"rss":74944512},"pid":28932,"uid":null,"version":"v16.13.2"},"stack":"Error: ENOENT: no such file or directory, open 'D:\coe-starter-kit-main\coe-starter-kit-main\coe-cli\config\alm.schema.json'","timestamp":"2022-01-25 03:44:56 PM -0500","trace":[]}
Even though the file was not generated, there are some questions I have about the settings.  Can you help me with them?  They are in the callouts in the attached screenshot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9e18449-730e-0332-bb2c-7b7a80a6f6cf
Version Independent ID: a9e18449-730e-0332-bb2c-7b7a80a6f6cf
Content: Set up ALM Accelerator for Power Platform - Power Platform
Content Source: power-platform/guidance/coe/cli/alm/admin-install.md
Service: power-platform
GitHub Login: @Grant-Archibald-MS
Microsoft Alias: grarchib

Hey @TBag, you may need to pull the latest of the coe-cli to fix this (https://docs.microsoft.com/en-us/power-platform/guidance/coe/cli/upgrade).
The file in question was missing when we first released last week but we've since added it back to the main branch. https://github.com/microsoft/coe-starter-kit/blob/main/coe-cli/alm.schema.json

@TBag since these aren't necessarily doc update related questions and more focused on the functionality of the cli. Would you mind taking this conversation over to the microsoft/coe-starter-kit repo for better visibility to others working with the cli and the accelerator. Unfortunately, I can't transfer this issue over from here.

Closing for now. Will reply on coe-starter-kit repo once moved over.

Awesome, this fixed the issue!  Thanks!
Here's a link to the new issue in the other repo where I put the open questions.
https://github.com/microsoft/coe-starter-kit/issues/1855


Unable to push, fail to read request body: unexpected EOF

Gogs version (or commit ref): v0.9.60 @ 2016-08-03
Git version: 2.7.0.windows.1
Operating system: Windows 7 SP 1
Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[X] No
[ ] Not relevant

Log gist:

Description
I am having an error during push command. Uncompressed size of files going in the push is about 23MBs. .
the logs in the console is as follows,
[Macaron] 2016-08-10 09:04:02: Started POST /mehmet6parmak/mdis/git-receive-pack for <IP_ADDRESS>
[Macaron] 2016-08-10 09:04:02: Completed /mehmet6parmak/mdis/git-receive-pack 500 Internal Server Error in 2m0.0573797s
2016/08/10 09:04:02 [D] Session ID: 87e9551ed2cbfb32
2016/08/10 09:04:02 [D] CSRF Token: ja6zhpOD-mdwFDT4dctKyEBKv9Q6MTQ3MDgwOTA0MjI4NzI4MzcwMA==
[Macaron] 2016-08-10 09:06:02: Completed /mehmet6parmak/mdis/git-receive-pack 500 Internal Server Error in 1m59.9975621
[Macaron] 2016-08-10 09:06:02: Started POST /mehmet6parmak/mdis/git-receive-pack for <IP_ADDRESS>
2016/08/10 09:06:02 [D] Session ID: e8ff524210796910
2016/08/10 09:06:02 [D] CSRF Token: VcS7Ys8Y4JO62WgsCX_1qwlmF3s6MTQ3MDgwOTE2MjUzNTg2MDEwMA==
[Macaron] 2016-08-10 09:06:02: Completed /mehmet6parmak/mdis/git-receive-pack 500 Internal Server Error in 236.0135ms
[Macaron] 2016-08-10 09:06:02: Started POST /mehmet6parmak/mdis/git-receive-pack for <IP_ADDRESS>
2016/08/10 09:06:02 [D] Session ID: a2c396ccc7a57942
2016/08/10 09:06:02 [D] CSRF Token: HmIvg_WgkWq2EeLj7pTwMrCaQ-06MTQ3MDgwOTE2Mjc4NDg3NDQwMA==
[Macaron] 2016-08-10 09:08:02: Started POST /mehmet6parmak/mdis/git-receive-pack for <IP_ADDRESS>
[Macaron] 2016-08-10 09:08:02: Completed /mehmet6parmak/mdis/git-receive-pack 500 Internal Server Error in 2m0.0441118s
2016/08/10 09:08:02 [D] Session ID: c76942b67004b65d
2016/08/10 09:08:02 [D] CSRF Token: admzWprYPn8mFm-rVatmPhN7rfA6MTQ3MDgwOTI4MjgyODk4NjEwMA==
[Macaron] 2016-08-10 09:10:02: Completed /mehmet6parmak/mdis/git-receive-pack 500 Internal Server Error in 2m0.0368658s
2016/08/10 09:13:23 [T] Doing: MirrorUpdate
2016/08/10 09:23:23 [T] Doing: MirrorUpdate

Logs from http.log:
2016/08/10 09:06:02 [...routers/repo/http.go:383 serviceRPC()] [E] fail to serve RPC(receive-pack): exit status 128
2016/08/10 09:08:02 [...routers/repo/http.go:368 serviceRPC()] [E] fail to read request body: unexpected EOF
2016/08/10 09:10:02 [...routers/repo/http.go:368 serviceRPC()] [E] fail to read request body: unexpected EOF

Git push command output,
Counting objects: 1873, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (1782/1782), done.
error: RPC failed; result=56, HTTP code = 0
fatal: WThe remote end hung up unexpectedly
Writing objects: 100% (1873/1873), 17.65 MiB | 33.00 KiB/s, done.
Total 1873 (delta 344), reused 0 (delta 0)
fatal: The remote end hung up unexpectedly
Everything up-to-date

Hi, just did a simple search of error: RPC failed; result=56, HTTP code = 0: http://stackoverflow.com/questions/22005259/git-push-error-rpc-failed-result-56-http-code-0


[compat][da-vinci][test] Global RT DIV improvement (part 1): RT and VT DIV se…

…paration
Problem
Data Integrity Validator (DIV) is used for validating and discovering data issues residing in the Kafka topics when consumed. However, without a shared global view of the RealTime (RT) topics among all leaders, DIV states for RT topics are scattered among all past leaders and without a way to pass RT DIV from leader to its successors, DIV results can be inaccurate especially during the leadership transitions.
At a high level, we proposes to replicate the leader DIV states into the local VT periodically or on-demand. Followers consume these leader DIV states and sync itself up to the leader state along the way.
As the first part of the implementation for global DIV improvement, this PR contains the following:

introduce a new flag for the global rt div feature.
introduce a new realtimeTopicProducerStates in PartitionState in the local rocksdb checkpoint.

avro diff:
    {
      "name": "realtimeTopicProducerStates",
      "doc": "A map that maps upstream Kafka bootstrap server url -> to a map of producer GUID -> producer state for real-time data.",
      "type": {
        "type": "map",
        "values": {
          "type": "map",
          "values": "com.linkedin.venice.kafka.protocol.state.ProducerPartitionState"
        },
        "java-key-class": "java.lang.String",
        "avro.java.string": "String"
      },
      "default": {}
   }

divide today's complete DIV into two groups: VT and RT DIV,  and RT DIV is further divided by its source fabric, so that each group can be updated separately based on which topic the Kafka records come from. (without feature enabled, only VT DIV is updated).
Adding test to verify the read/write of an OffsetRecord with new the new added field.

How was this PR tested?

CI (with or without feature enabled)
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

If the SIT is not ingesting the leader replica, will SIT load the RT DIV or not? Also when the replica transitions from leader replicas to follower replica, will SIT offload RT DIV from the memory and reload it when necessary?
Maybe this is not part of the scope of this PR, and some clarification will be hepful.

Will update the description part to address this comment.


fixed library build command

Fixes #
Fixes the issue with building the library when importing the module from anywhere but the module root.
I really should have seen that one coming, looking at the error in retrospect ...

busy 🐝 !


KOGITO-4229 - rename DMNResult to KogitoDMNResult

JIRA: https://issues.redhat.com/browse/KOGITO-4229
This PR aims to rename org.kie.kogito.dmn.rest.DMNResult so to avoid name conflict with org.kie.dmn.api.core.DMNResult.
Given that these classes have the same name, developers have to check always what is the DMNResult currently used and the code is more hard to read.
Related kogito-apps PR: https://github.com/kiegroup/kogito-apps/pull/611
Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: KOGITO-XYZ Subject
[x] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains link to any dependent or related Pull Request
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket

Can you please also rename any class ending with ...SQ to align with this new naming convention, please?
Can we please ensure Leads approval for the serialization form of this class, since we are touching it again? (i.e.: dmnContext and not dmn-context, etc).

Can you please also rename any class ending with ...SQ to align with this new naming convention, please?
Can we please ensure Leads approval for the serialization form of this class, since we are touching it again? (i.e.: dmnContext and not dmn-context, etc).

Jenkins retest this please

Jenkins retest this please

Can you please also rename any class ending with ...SQ to align with this new naming convention, please?
Can we please ensure Leads approval for the serialization form of this class, since we are touching it again? (i.e.: dmnContext and not dmn-context, etc).

Hi @evacchi @cristianonicolai, wdyt about this one?

Can you please also rename any class ending with ...SQ to align with this new naming convention, please?
Can we please ensure Leads approval for the serialization form of this class, since we are touching it again? (i.e.: dmnContext and not dmn-context, etc).

Hi @evacchi @cristianonicolai, wdyt about this one?


Open Script Crashes Engine

https://github.com/godotengine/godot/commit/39cbb992c3f84e9fcd06b5e991536b431c396fb6
I am trying to open an old project with GDScript Errors.
When I try to open the script by clicking on the Script Icon on the Node the engine crashes.
I am able to open the script with File -> Open but later on Project Open the engine crashes.
Maybe related to a Script that extends a non existent script.
extends "res://notavailable.gd"
[2] Reference::unreference() (??:0)
[3] Ref<Font>::unref() (??:0)
[4] Ref<Font>::~Ref() (??:0)
[5] RichTextLabel::ItemFont::~ItemFont() (??:0)
[6] Object::notification(int, bool) (??:0)
[7] Object::_predelete() (??:0)
[8] predelete_handler(Object*) (??:0)
[9] void memdelete<GDScript>(GDScript*) (??:0)
[10] Ref<GDScript>::unref() (??:0)
[11] Ref<GDScript>::~Ref() (??:0)
[12] ResourceFormatLoaderGDScript::load(String const&, String const&, Error*) (??:0)
[13] ResourceLoader::_load(String const&, String const&, String const&, bool, Error*) (??:0)
[14] ResourceLoader::load(String const&, String const&, bool, Error*) (??:0)
[15] GDScriptParser::_determine_inheritance(GDScriptParser::ClassNode*) (??:0)
[16] GDScriptParser::_parse(String const&) (??:0)
[17] GDScriptParser::parse(String const&, String const&, bool, String const&, bool, Set<int, Comparator<int>, DefaultAllocator>*) (??:0)
[18] GDScriptLanguage::validate(String const&, int&, int&, String&, String const&, List<String, DefaultAllocator>*, List<ScriptLanguage::Warning, DefaultAllocator>*, Set<int, Comparator<int>, DefaultAllocator>*) const (??:0)
[19] ScriptTextEditor::get_functions() (??:0)
[20] ScriptEditor::_update_members_overview() (??:0)
[21] ScriptEditor::_go_to_tab(int) (??:0)
[22] ScriptEditor::edit(Ref<Resource> const&, int, int, bool) (??:0)
[23] ScriptEditor::set_window_layout(Ref<ConfigFile>) (??:0)
[24] ScriptEditorPlugin::set_window_layout(Ref<ConfigFile>) (??:0)
[25] EditorData::set_plugin_window_layout(Ref<ConfigFile>) (??:0)
[26] EditorNode::_load_docks() (??:0)
[27] EditorNode::_notification(int) (??:0)
[28] EditorNode::_notificationv(int, bool) (??:0)
[29] Object::notification(int, bool) (??:0)
[30] Node::_propagate_ready() (??:0)
[31] Node::_propagate_ready() (??:0)
[32] Node::_set_tree(SceneTree*) (??:0)
[33] SceneTree::init() (??:0)
[34] OS_X11::run() (??:0)

On one crash it shows this
corrupted size vs. prev_size
and sometimes this
free(): invalid next size (fast)

Opening the project over and over again(~4times) lets it start and even run the game.
@vnen Any idea what it could be or do I have to break the project apart?
Edit: Looks like the fix dependency popup is broken I have a Scene where a .gd Script is missing and the engine crashes.
ERROR: load_source_code: Condition ' err ' is true. returned: err
   At: modules/gdscript/gdscript.cpp:799.
ERROR: load: Condition ' err != OK ' is true. returned: RES()
   At: modules/gdscript/gdscript.cpp:2126.
ERROR: _unref: Condition ' !_p ' is true.
   At: core/dictionary.cpp:171.
ERROR: _load: Failed loading resource: res://somescript.gd
   At: core/io/resource_loader.cpp:190.
ERROR: load_source_code: Condition ' err ' is true. returned: err
   At: modules/gdscript/gdscript.cpp:799.
ERROR: load: Condition ' err != OK ' is true. returned: RES()
   At: modules/gdscript/gdscript.cpp:2126.
ERROR: _unref: Condition ' !_p ' is true.
   At: core/dictionary.cpp:171.
double free or corruption (!prev)

I am currently getting this issue on 3.1.1 stable. I have uploaded my (very simple) project here: https://github.com/kjav/godot_bug_rome_in_space
When I open the project in the 3.1.1 editor, and open the script on the MeshInstance, the editor crashes and closes. I get the message "double free or corruption (out)".


Implement Help command #28

Context
-Added help explanations for each command to help command

Found and changed previous error in naming convention of address book to Task book in Clear Command

Links
#28

-Can only list all the help for all the commands.

Not able to list individual help for each commands. (Still working on it )


Added support for code analysis of Maven projects with multiple modules.

This commit also removes the code cross-reference feature, which did not work without the relevant files anyway.

Follow up to an offline discussion - the implementation of the tasklib.rmRF() and mkdirP() functions are synchronous.

LGTM


Thoughtspot release into the Production

@jordanrburger please, submit your review :-) Thank you.

@jordanrburger can you please approve this PR, but don't merge it yet please. We will release the templates on Monday. :-) Thank you!

@jordanrburger can you please approve and merge this PR? I added the trial link here as well. Thank you. :-)


Ethiopia shape file to JSON

@deldersveld ,
Would it be possible for you to create a JSON file of for Ethiopia. I have the link  four layers of shape files and I was wondering to get JSON file to use it PowerBI. Your help is highly appreciated.
Here is the link to download the shape files:
1.https://hub.arcgis.com/datasets/ethiopia::regions-level-1
2.https://hub.arcgis.com/datasets/ethiopia::zones-level-2
3. https://hub.arcgis.com/datasets/ethiopia::woredas-level-3
4.https://hub.arcgis.com/datasets/ethiopia::kebeles-level-4
Thank you!!

@ZenaKiya have you tried to use this tool to convert the SHP file to topojson
https://mygeodata.cloud/converter/shp-to-geojson

@agebeyaw  Thank you for sharing the link. I was able to use  https://mapshaper.org/ and create the json file.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/30 is merged into live branch.
Auto archive content to https://github.com/huangmin-ms/docs-archive-test-source-version-target.git

Docs Build status updates of commit a8cd452:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a8cd452:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


JBPM-5207 - process creation improvements in designer

enable svg save by default,
set packageName in process according to location in project so svg files are created in proper location

@tsurdilo @jlindop could you please review this?

+1

@jomarko PR updated, is that what you had in mind?

@mswiderski yes, my point was: not introduce next test class for DefaultDesignerAssetService and you accomplished it. Maybe it would be also worth to move test package "org.jbpm.designer.service" into "org.jbpm.designer.server.service" - that corresponds to package of DefaultDesignerAssetService.

moved the package, @jomarko please double check it

@mswiderski definitive +1, thanks

jenkins retest this


[TW#26402] UDP Client Connection

Hello,
i try to implement UDP Client and have a question.
I expect that the function connect () returns an error if no udp server with a assigned port is started
Code:
 .....
 S = socket (AF_INET, SOCK_DGRAM, IPPROTO_UDP);
 if(connect(S, (struct sockaddr *)&sa_udpclient, sizeof(sa_udpclient)) <0)
 {
        close(S);
 }
 ......
 if( write(S ,&Buffer[0] ,10) < 0)
 {
        close(S);
 }

This condition is evertimes false, so the esp32 send udp data. With wireshark i see that the esp32 transmit everytime new upd packets. This happens also if the Server ip is not available, in this case i use the terminal which shows also that data is transmitted, so both conditions are everytime false.
By using TCP Protocol this lines working finely and the connect() returns everytime an error.
Is this lines for check of error not needed for UDP Connections?
If yes, is their any way to see a valid connection?
Can you please tell me where i can find the specification for Connect() and Socket()?
Thanks for help.
Best regards

Same problem here

@MHANE @rinripper
The purpose of calling the connect()  function in the UDP is just to specify the  remote IP address and port where the UDP data will be sent to. It will not create a connection between the two targets as TCP does.
So it doesn't make sense for you to use the connect()  function to detect whether the remote udp port is open or closed.
Here is the udp_connect() in the lwip, you can use it as a reference:

udp_connect(struct udp_pcb *pcb, const ip_addr_t *ipaddr, u16_t port)
{
struct udp_pcb *ipcb;
if ((pcb == NULL) || (ipaddr == NULL)) {
return ERR_VAL;
}
if (pcb->local_port == 0) {
err_t err = udp_bind(pcb, &pcb->local_ip, pcb->local_port);
if (err != ERR_OK) {
return err;
}
}
ip_addr_set_ipaddr(&pcb->remote_ip, ipaddr);
pcb->remote_port = port;
pcb->flags |= UDP_FLAGS_CONNECTED;
for (ipcb = udp_pcbs; ipcb != NULL; ipcb = ipcb->next) {
if (pcb == ipcb) {
return ERR_OK;
}
}
pcb->next = udp_pcbs;
udp_pcbs = pcb;
return ERR_OK;
}

@MHANE Feel free to reopen this issue if your issue still exists. Thanks.


Clean up Deepforest modules

Embed keras_retinanet module imports in a try block

@bw4sz, I cannot access the build logs for the failing tests, Is there a way to add me to the permissions or change them?


aligning README.md and CONTRIBUTING.md to FINOS project blueprint language

aligning README.md and CONTRIBUTING.md to FINOS project blueprint language

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Codecov Report

Merging #157 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #157   +/-   ##
=======================================
  Coverage   88.06%   88.06%
=======================================
  Files         135      135
  Lines        2405     2405
  Branches      280      280
=======================================
  Hits         2118     2118
  Misses        176      176
  Partials      111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ab81b...9dda208. Read the comment docs.


Add SwannView Link <IP_ADDRESS>

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

Did you complete these steps?

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask install {{cask_file}} worked successfully.

 ==> Downloading http://assistly-production.s3.amazonaws.com/195635/kb_article_attachments/101292/SwannView_Link_<IP_ADDRESS>_original.dmg
curl: (22) The requested URL returned error: 403 Forbidden
audit for swannview-link: failed
 - download not possible: Download failed on Cask 'swannview-link' with message: Download failed: http://assistly-production.s3.amazonaws.com/195635/kb_article_attachments/101292/SwannView_Link_<IP_ADDRESS>_original.dmg
Error: audit failed for 1 cask: swannview-link

Apparently not, sorry. I thought I'd run them but looking at history I can see I'd run those commands against my previous homebrew-cask PR and not this one.
I have now amended the file and re-run all checks.

Thanks!


Implement endpoint to get the course creation request

Subtask for the user story defined at https://github.com/JamesPartsafas/ConcordiaCurriculumManager/issues/219
Create endpoint to get the current course creation request in order to edit it
[Story Points: 2]
[Priority: High]
[Risk: Medium]

demo


Debug retry logic

The runs in #54 were still breaking on various retry failures, and I got most of them working.
One last one keeps failing - the FERC1 run. There seems to be some issue with renaming the downloaded file, probably worth re-running with debug logging or maybe pulling that "let you SSH in" action in... https://github.com/marketplace/actions/debugging-with-ssh

I've seen a similar issue before as this one we're seeing for ferc1. This is stemming from arelle, which is the library we use for parsing XBRL taxonomies, and it seems to be an inconsistent webcache issue. From experience, trying to debug arelle issues is a huge pain. That being said, arelle has recently been acquired by a larger company that seems to be increasing the speed of development/responsiveness quite a bit, so perhaps a good approach could be to open an issue over there, and try and find a temporary solution for ourselves.
I just reran the ferc1 archiver, and it succeeded this time, so I'm also not sure how frequently this will crop up. Perhaps if it's infrequent enough, we could just rerun ferc archivers if they fail?

OK, so censusdp1tract succeeded on Refactor retry_async interface to be a little more pythonic. but not on Retry on ZenodoClientException - I think censusdp1tract is just flaky.

I think it feels better - @zschira what do you think
Yeah agreed, I feel like the passing args/kwargs pattern is a little more common in python.

OK, so censusdp1tract succeeded on Refactor retry_async interface to be a little more pythonic. but not on Retry on ZenodoClientException - I think censusdp1tract is just flaky.
I'd guess this is the case. There's only so much retries can do when you're dealing with flaky servers. Maybe we just need ultimate retry of rerunning the entire archiver run on failure, or we could try setting the number of retries higher

Although it seems to be failing in the same place. I wonder if something is wrong with zenodo deposition?


Review documentation regarding platform support

Its deprecated by GitHub actions, so we no longer test on it.

We're still testing on Ubuntu 18 using other methods.
However, we should review and update our platform support documentation taking into account that:

We now support ARM 64 Linux, although support is not tested in CI.
Building from source is not guaranteed to work on most platforms since their machine models may not be included in Kani.
We should add a disclaimer regarding Tier 2 targets, which come with less guarantees than Tier 1 platforms (both ARM64 platforms, M1 and Linux, fall into this category).


Ensure coverage of new IGC repository connector and event mapper

Issue to track on-going testing and extension of the new IGC repository connector and event mapper (initially committed under #523 ), specifically to ensure they have appropriate coverage of TypeDefs we expect from the Coco Pharmaceuticals sample metadata.
Initial test indicates the following are covered already (including events generated by load of sample metadata into a blank IGC environment):

Asset
AttributeForSchema
CategoryHierarchyLink
ComplexSchemaType
Confidentiality
Connection
ConnectionConnectorType
ConnectionToAsset
ConnectorType
Database
DataContentForDataSet
DataSet
DeployedDatabaseSchema
GlossaryCategory
GlossaryTerm
GovernancePolicy
GovernancePolicyLink
Referenceable
RelationalColumn
RelationalColumnType
RelationalDBSchemaType
RelationalTable
RelationalTableType
SchemaAttribute
SemanticAssignment
SpineObject
SubjectArea
TermCategorization
TermHASARelationship

Known gaps at the moment
These should be generating events already, but for some reason are not (top priority to investigate):

[ ] AssetSchemaType
[ ] ConnectionEndpoint
[ ] Endpoint
[ ] SchemaAttributeType

These are not generating events, but most likely because there currently isn't any sample metadata to cover them:

[ ] AttachedTag
[ ] DataClass (IGC is pre-populated with these, so no initial event to trigger OMRS)
[ ] DataClassAssignment (automated sample load does not (yet) do analysis to trigger these)
[ ] DataClassHierarchy (IGC is pre-populated with these, so no initial event to trigger OMRS)
[ ] ForeignKey
[ ] RelatedTerm
[ ] ReplacementTerm
[ ] Synonym
[ ] TermISATypeOFRelationship
[ ] Translation

@mstrelchuk @GuyAckermans @innerTide @planetf1 @bogdan-sava ^^ please add a comment if you see any other gaps that we need to address for demonstration purposes with Coco Pharmaceuticals (or if there are items in the second list that we need to add samples for within Coco Pharmaceuticals)?


Allow https:// for urls in \homepage

Up to now, the template always inserted a 'http://' in the url
for the \homepage{} attribute. Therefore, it was not possible
to specify 'https://example.com' as this would have resulted
in 'http://https://example.com'.
The new approach allows to specify the homepage-url in any of the
following ways (which will result in the specified strings)

url provided to \homepage
hyperlink
displayed url-text

http://example.com
http://example.com
example.com

https://example.com
https://example.com
example.com

example.com
http://example.com
example.com

Note that the third row is equivalent to the current behavior.

Good idea! I'll review and merge your PR ASAP. Thanks.

Just a quick thought I had in the morning: It might be more suitable if I'd do the string manipulation inside the \newcommand (line 288) instead of where I've included it right now.
The current approach would require the same if-else structure whenever we want to do something with \homepage. (so, e.g. if someone would like to include the information somewhere else in the cv again he'd need to copy the code). I think it would be cleaner to modify the command so that it takes one argument and provides two named arguments (e.g. \@homepageUrl and \@homepageText). I'm just not 100% sure if this will work as I expect.
However, I can try to do this in the afternoon?

Will this fix the bug where https:// is rewritten to https//? The colon is removed for some reason in the linked URL, which causes a DNS resolver issue.


Rotation Axis for Hand_Pose

Hello,
I am trying to understand the axis convention for the hand_pose prediction under pred_mano_params. This variable is meant to be a 3x3 rotation matrix wrist pose in the frame of reference of the camera. So, in a rotation matrix the first column indicates the direction of the x-axis, the second column the direction of the y-axis, and the third column the direction of the z-axis. How do each of these axis map onto the hand? For example, does the x-axis and y-axis lie on the plane of the wrist, and the z-axis points out of the wrist? I cannot find any information for this in this repository or anywhere else.

Unfortunately, this is not documented somewhere. You might want to visualize the predictions to get the intuition for that.


Copied over verdaccio changes as previously made in gnpm repo

????

Oh, whoops! Sorry for that. I was rushing to show someone changes from a fork containing old changes, and I must have accidentally drafted a pull request upstream. It's certainly not for merging upstream. Sorry for the confusion there. I'll need to be more careful next time.
I've closed the PR now


Display of synonyms in pop ups and on genotype pages  (was Mis19, standardize deletion allele names)

Mis19, standardize. Deletion allele names

eic1Δ,   kis1Δ,   mis19Δ

Do we display allele synonyms yet?

Not yet.

I think we should show allele synonyms here too

Would an extra column ("synonyms") be too much?  Another option is to add them after the name:
   mis19Δ (synonyms: mis19-zzz, mis19-yyy)

This will be really helpful if  the genotype in the paper doesn't match up - I sometrimes run into this.
I like your solution.

Would an extra column ("synonyms") be too much? Another option is to add them after the name:

I have a slight preference for a separate column, but it's not a big deal either way for me.

OK separate column would be good too.

That's done now.

great! Little niggle-  displays as eic1delta,   kis1delta not eic1Δ,   kis1Δ

displays as eic1delta, kis1delta not eic1Δ, kis1Δ

Good point.  That's fixed now if you reload or maybe shift-reload.


Dox for dark theme

Need documentation on when to use it as well as how to use it.

PR https://github.com/vmware/clarity/pull/1687 addresses this issue.


Added refreshed tokens to session storage

Issue #: https://github.com/bcgov/met-public/issues/
Description of changes:
Once token is refreshed , the new refreshed token is stored in the session storage
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #2308 (39ccc19) into main (3889415) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   68.58%   68.55%   -0.03%
==========================================
  Files         472      472
  Lines       15584    15590       +6
  Branches     1190     1193       +3
==========================================
  Hits        10688    10688
- Misses       4690     4693       +3
- Partials      206      209       +3

Flag
Coverage Δ

metweb
61.48% <0.00%> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

met-web/src/services/userService/index.ts
25.60% <0.00%> (-2.03%)
:arrow_down:


[FLOC-2484] Make padding top and bottom the same on headers

Fixes FLOC-2484

To confirm, this is because A is longer than B, right?

If so I can't tell, but then the rest of the theme hasn't been through such scrutiny - the code is fine and the header looks fine to me and I'll leave it to your judgement. If the issue is something else then resubmit.

Thanks @adamtheturtle, I think you're looking at the wrong part of the page. This is likely due to a poor description in JIRA.
http://i.imgur.com/pT5HyuT.png
On the left is the new version, the right is what we currently have.
The change is to increase the top padding for content headers.

Ok, same comment applies, thanks. Merging.


on hovering over a pointer, show character count of the pointer even if pointer is opened

feature suggestion by Erol; 5 people :heart-eyes: their suggestions

feature suggested again by Ratheka; had 7 likes
https://ought-inc.slack.com/archives/CMVHF5HJ8/p1567707723029300


📍 Generalize Range.eof to arbitrary positions

The idea is to generalize EOF (end of file) to an arbitrary position in a file. This includes the recognition of these special positions:

The EOF (end of file)
The EOL (end of line), BOL (beginning of line) and BOF (beginning of file)

The plan is to change the semantics of "empty ranges" (with the same starting and ending positions). Previously, an empty range is a no-op, highlighting nothing. With this proposal, an empty range will mark one single position.
To implement this, there will be several API changes:

Range.{eof,view} can/will be deprecated. Maybe Range.of_pos or Range.single (?) can replace Range.eof.
The terminal backend should be updated to handle all special cases EOL, BOL, and BOF. (It's unclear how to highlight positions in the middle.)
The flattening function needs to be rewritten to avoid the generation of spurious empty ranges. They were harmless earlier because they highlight nothing in the current semantics.

Design question: how to highlight a position in the terminal output? This may eventually lead to a solution to #131.
Tagging @mikeshulman for possible feedback.

@mikeshulman Mostly because we don't have to come up with a good name (e.g., EOL, BOL, ...). It's equally difficult at the technical level.

Haha, okay.  Maybe just POS.

@mikeshulman Question: is it important for your applications to display "EOF" as "EOF"? I realized it's far more easier to uniformly display these point markers as "POS1" or some generic names. However, I wonder if this will sacrifice usability.

I do think "EOF" is clearer.  In my case (and, I suspect, in others) EOF is the only zero-width position possible -- it indicates a parse failure when something was expected but nothing was found; whereas in any other situation something would be found, and if it's the wrong thing, the error would be reported on the something.  So simply marking it with "POS" would not indicate to the user what's actually going on.


Default to manylinux_2_28 for appimage builds.

As the Python-build-standalone support packages now depend on a recent clang, update the default template to use manylinux_2_28 for all builds.
Refs beeware/briefcase#1500
Refs beeware/briefcase-linux-appimage-template#38
PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Holding off in favor of https://github.com/beeware/briefcase-linux-appimage-template/pull/39 to simply use the previous Standalone Python version in hopes that clang dependency will be removed in the next release.

Closing on the basis that it appears the gcc incompatibility was unintentional, and will be fixed (at some point).


Expose bypass writer for uilive

Allow log output (for example) to be written without being overwritten by the next
progress bar refresh.
See gosuri/uilive#6 for more details

LGTM! Thank you.


Trace fails to match interface functions and events

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (85f69d9 2022-05-09T00:04:25.613861+00:00)
What command(s) is the bug in?
forge test -vvvv -f MAINNET_FORK
Operating System
macOS (M1)
Describe the bug
Expected a Forge trace to match against signatures and events contained in an interface.
On the current version the signatures fail to match and the bytes4 is printed instead.
[PASS] testExample() (gas: 7688)
Traces:
  [7688] ContractTest::testExample()
    ├─ [2480] 0xb4e1…c9dc::70a08231(000000000000000000000000b4c79dab8f259c7aee6e5b2aa729821864227e84) [staticcall]
    │   └─ ← 0x0000000000000000000000000000000000000000000000000000000000000000
    └─ ← ()

If instead this interface is converted to a stubbed contract, and that contract is deployed, then the signatures match as expected.
[PASS] testStub() (gas: 7666)
Traces:
  [7666] ContractStubTest::testStub()
    ├─ [2480] 0xb4e1…c9dc::balanceOf(ContractStubTest: [0xb4c79dab8f259c7aee6e5b2aa729821864227e84]) [staticcall]
    │   └─ ← 0
    └─ ← ()

Repro project can be found here: https://github.com/dekz/foundry-interface-match

We currently can't do this because we do the matching based on bytecode. To support this we would have to parse the test contract and determine it that way, but that would be way more complex (for imo, little gain), not cover all edge cases (e.g. if the interface uses an address in a storage variable) and even produce wrong guesses as well. Not sure what the best path forward is here.

Work around is to either:

Modify interface to a stubbed contract (and deploy in test) so it finds the match
Export an ETHERSCAN_API_KEY to use the EtherscanIdentifier in various places.

Sure, if these are forked tests then the recommended way is to set ETHERSCAN_API_KEY, but the repro you shared did not suggest it was forked tests :smile:

I'm running into this now and from a user perspective it definitely feels like a bug that should be fixed—it's confusing that my interface is defined and visible in the out folder but the trace doesn't decode it's methods, and the workarounds aren't ideal. This makes debugging harder when you have lots of interfaces, as traces become not very readable.

We currently can't do this because we do the matching based on bytecode. To support this we would have to parse the test contract and determine it that way, but that would be way more complex (for imo, little gain), not cover all edge cases (e.g. if the interface uses an address in a storage variable) and even produce wrong guesses as well. Not sure what the best path forward is here.

Could we add fallback to attempt decoding by ABI when bytecode matching fails? Something like this:

Take the ABIs from all artifacts and merge them into a single vector of functions. If there's duplicate sigs across ABIs, those can be safely ignored. If there's function selector collisions, just keep the first and log a warning so the user knows decoding may be inaccurate for some selectors. This is basically a mini 4byte.directory of all local, known signatures.
Attempt match by bytecode like we currently do
If no match is found, fallback to using the set of all functions to try decoding

@dekz There's been some changes to tracing and new identifiers have been added, is this still an issue for you?

Closing - let me know if this is still an issue for you :)

sorry mate just saw this, thanks so much, I'll give it a whirl today and report back if there are any issues.


Identify forbidden internal addresses

according to TreesBook page 43 lemma 5.4 we only have to check if a kneading sequence fails for numbers less than the period of the kneading sequence


Filled in 'play' and 'duration' iconography

Hi @rdunk -- I've noticed that the play and duration icons that overlay on video content, most noticeable on a banner element, has been filled in now? Just checking that this was deliberate? It seems new??

Not deliberate! Fixed in 56af51f94e5f60faf273983498237275303d7351.


i18n guidelines about plurals say "Always include %d in "one"

Here's the important part from https://developer.android.com/guide/topics/resources/string-resource.html#Plurals (first example for Plurals section)
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <plurals name="numberOfSongsAvailable">
        <!--
             As a developer, you should always supply "one" and "other"
             strings. Your translators will know which strings are actually
             needed for their language. Always include %d in "one" because
             translators will need to use %d for languages where "one"
             doesn't mean 1 (as explained above).
          -->
        <item quantity="one">%d song found.</item>
        <item quantity="other">%d songs found.</item>
    </plurals>
</resources>

Here's what this project's strings.xml has:
  <plurals name="uploads_pending_notification_indicator">
    <item quantity="one">1 file uploading</item>
    <item quantity="other">%d files uploading</item>
  </plurals>

I don't know much about android i18n, but this looks contrary to the guidelines.

I believe this was fixed in #544 -> 5639be077e943fd4bd7d0859ed10ee94531ecd7c
So this issue could probably be closed.

Agreed, thanks @akaita !


Regression: map_blocks converts large np arrays to strings

I work on stacks of images and noticed a somewhat awkward regression from dask version 0.19.2 to 1.0.0.
Consider the following code creating a stack of shifted copies of the same image:
import numpy as np
import dask.array as da
import dask

dE = 10

def shift_blocks(xshifts, image):
    result = np.stack([image] * dE)
    print("DEBUG:", image, type(image))
    # Normally go on to apply shifts by assigning to indexed np arrays
    return result

da_xshifts = da.arange(100, chunks=(dE,))

image = np.ones((354,354))
imagestack = da.map_blocks(shift_blocks, da_xshifts, image,
                          dtype=image.dtype,
                          new_axis=(1,2),
                          chunks=(dE,image.shape[0],image.shape[1]),
                         )
print(image.shape, image.dtype)
imagestack[0,...].compute()

This worked as expected for any size of image I checked under dask 0.19.2.
However, for dask 1.0.0 the image array gets converted to a string like "ndarray-46e175ad-8db4-412f-9e55-73ee0662adc2" for any size where the product of dimensions is larger than 125000, i.e. :
np.ones((353,353)) works, np.ones((354,354)) doesn't,
np.ones((1,125000)) does, np.ones((1,125001)) doesn't.
This is probably related to #3263 , but holds here for args as well as kwargs, and there is a regression since that bug was posted as this worked before. It is suggested there that the following code is probably to blame:
https://github.com/dask/dask/blob/69ea16e388c215b6c1a849d543a690334406d2e2/dask/delayed.py#L32-L37
But git blame shows this code has not been changed in quite some time.
For this particular case I can work around it by converting image to a dask array as well and using broadcasting to get the sizes I want and convert to numpy array in shift_blocks, but as I don't find this expected behaviour I thought let's make a bug report anyways.

I verified: it also works fine for me on #4229 .
For completeness: this triggers if the size of the array is larger than 1e6 bytes.

This has been resolved.  Closing.


PowerShell Advanced Delivery

Will the powershell exchange online module be updated to allow these settings/rules to be edited/created via powershell?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b17ce75e-79ba-0acd-066c-a0120a29d65d
Version Independent ID: 14673b1c-8489-0abc-90a0-42f35d516424
Content: Configure the delivery of third-party phishing simulations to users and unfiltered messages to SecOps mailboxes - Office 365
Content Source: microsoft-365/security/office-365-security/configure-advanced-delivery.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

Is there any update on this?

@rudischenck, the cmdlet reference topics published just yesterday 6/16/21:

https://docs.microsoft.com/powershell/module/exchange/get-phishsimoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/new-phishsimoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/remove-phishsimoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/set-phishsimoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/get-phishsimoverriderule

https://docs.microsoft.com/powershell/module/exchange/new-phishsimoverriderule

https://docs.microsoft.com/powershell/module/exchange/remove-phishsimoverriderule

https://docs.microsoft.com/powershell/module/exchange/set-phishsimoverriderule

https://docs.microsoft.com/powershell/module/exchange/get-secopsoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/new-secopsoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/remove-secopsoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/set-secopsoverridepolicy

https://docs.microsoft.com/powershell/module/exchange/get-secopsoverriderule

https://docs.microsoft.com/powershell/module/exchange/new-secopsoverriderule

https://docs.microsoft.com/powershell/module/exchange/remove-secopsoverriderule

https://docs.microsoft.com/powershell/module/exchange/set-secopsoverriderule

I'll get the PowerShell procedures in the topic as I'm able.

@rudischenck Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


UI-issue with hierarchical view in release/3.2

Current behaviour
With long names it prefers to push the document-icon and storyname onto a new line before breaking the storyname. If there's not enough room on the next line it breaks the storyname as expected.
Wanted/Expected behaviour
I would expect the opposite behaviour, e.g. start by breaking text and if its no longer possible pop it onto a new line (or just overflow).
Storybook-version: 3.2.0-alpha.7

I'll look into it. Thanks.

@nutgaard
BTW, do you think breaking the words is a good solution ?
Inspiring from the editor we all use and love (I think all of them do this):

WDYT ?

Here is the fix as you suggested.

But IMO the better way is to support horizontal scrolling starting from some minimum width.

I think both approaches are viable.
But its probably easier to get the "overflow: hidden"-solution to work consistently, and paired with a horizontal scrollbar it solves the issue imho.
Anyway huge 👍 for the quick response. :1st_place_medal:

Will be fixed with #1427


How would one use the $routeConfig within a Typescript controller?

This is how I solve it at the moment:
module app {
  'use strict';

  export class AppRoutes {
    static $inject = ['$router'];

    routes: Array<any> = [{ path: '/', component: 'app.home' }];

    constructor($router: any) {
      $router.config(this.routes);
    }

    canActivate() {
      return true;
    }
}

My question is how could I do it differently (without injecting the router service).
A static $routeConfig = [{...}] property on the controller get read, but it does not show up as child router within the rootRouter.

I'd the exact same issue using typescript, renaming the main application controller "AppController" works with static $routeConfig = [{...}]. As you can see in the code:
// line 1418 in router.es5.js
if (name === 'app') {
    name = '/';
}

Actually calling your controller "/Controller" has the same effect as name parameter passed will be "/" then.


Generic webhook provider

Discussed in https://github.com/external-secrets/external-secrets/discussions/544

Originally posted by willemm December 22, 2021
Hi,
Because our company has an in-house developed (quite simple) key store, I needed to add a provider for it.  Because this store is quite simple, I thought it would be more useful to create a generic provider that can call any webhook with a bit of templating, and use something like jsonpath to parse the results.
I already have a poc working, but I'm wondering if this would be a good addition to the project and I also have a number of feedback questions:

Would this be something that would be useful to add to this project?
Is 'webhook' a good name, or should it be something different?
What about the parameter naming?  (e.g. I stuck jsonPath under result to allow for future extensions like xPath)
Should this implement something involving serviceaccount auth or is that too involved with specific provider implementations ?

My fork is here: https://github.com/willemm/external-secrets/tree/feat/generic-webhook
But it's obviously very much a work in progress.
This is roughly how I currently envision this generic webhook store:
apiVersion: external-secrets.io/v1alpha1
kind: ClusterSecretStore
metadata:
  name: some-keystore-backend
spec:
  provider:
    webhook:
      url: "https://some-keystore.example/api/getpassword?userid={{ .remoteRef.key }}"
      result:
        jsonPath: "$.result.password"
      headers:
        Content-Type: application/json
        Authorization: Basic {{ print .auth.username ":" .auth.password | b64enc }}
      secrets:
      - name: auth
        secretRef:
          namespace: external-secrets
          name: some-keystore-credentials
      caBundle: "..."
```</div>

Hey, thanks for bringing this up!

Would this be something that would be useful to add to this project?

IMO this is useful, i support adding it! The design looks good, too. I suggest adding a HTTP method and body for the outgoing request to make it more generic. E.g. to be able to send POST requests with a json-serialized remoteRef.

Is 'webhook' a good name, or should it be something different? What about the parameter naming?

yeah, webhook is good. But these minor details can be changed when reviewing the PR.

Should this implement something involving serviceaccount auth or is that too involved with specific provider implementations ?

I think the provider should be generic and we shouldn't enforce SA authentication but rather offer it as an optional feature. If the webhook receiver runs inside the cluster and can validate the jwt via kube-apiserver then this is the preferred method for sure.
Do you have a use-case for that already? I don't think it's super important for the initial implementation - we can add that later if requested.
It would be great to have e2e tests for this provider (e.g. testing it with httpbin) :wink: .

https://github.com/external-secrets/external-secrets/pull/559
About your comments:
http method and body parameters have been added to the outgoing request, although there should probably be a 'happy' unit test with a body in there (atm there is only if it fails on a faulty template)
Our company doesn't have a use case for accessing an in-cluster endpoint with serviceaccount token, and I don't really know how to build that.  Perhaps some way to access serviceaccounts from the templating engine so you can use them in the authorization header?
(Although maybe specific auth code is needed anyway to support ntlm auth and the like)


WitAi doesn't work

Currently, speech recognition with witAi doesn't work.

Yep. Been trying to fiddle with it for some days. (TBH just trying random things since I'm not experienced with audio encoding)
Currently we can reach a point where wit.ai will accept the file but output an empty text response. However the same configuration works with discordSR v1


Request for addition of README.md file for Graph section.

Is your feature request related to a problem? Please describe.
Yes, as I believe no one can understand the code until and unless he/she understand the meaning and concept behind the topic.
What will you contribute?
I'll make an easy description about "What is Graph?", "Why we use it?", its different applications and different algorithm which is use to approach different algorithm.
How will you do this?
Okay, I'll make an easy, simple and understandable description about graph with proper jargon (along with their meanings). Also, I'll provide some sources like medium link or You Tube links where anyone can get the deep view about the graph. Of course, there will be visuals and demonstrative examples to show the respective topic .
ADDONS
I'll also provide some DSA based question on graph as well. (If you say)
Kindly, assign me this issue for my contribution in Ssoc'23.
Thank you

Please assign me!


Not an issue per-se, but an open question.

Hi all.
I'm doing a research and want to decide on a RESTful framework (with or without an ORM layer) to build on. However, this library's approach is very nice indeed and opens up a lot of possibilities for me.
So my question is: Is this library still in development? What's the roadmap?

Hello Noor.
This Mark Sawers the project lead. You can see from the release history on
restsql.org that there are about three releases
On Friday, July 17, 2015, Noor Dawod<EMAIL_ADDRESS>wrote:

Hi all.
I'm doing a research and want to decide on a RESTful framework (with or
without an ORM layer) to build on. However, this library's approach is very
nice indeed and opens up a lot of possibilities for me.
So my question is: Is this library still in development? What's the
roadmap?
—
Reply to this email directly or view it on GitHub
https://github.com/restsql/restsql/issues/68.

... a year. There are occasional contributions but I drive many of the enhancements. You're welcome to contribute or extend privately. The project uses the MIT license.
You can see the roadmap (a roughly ordered backlog) on restsql.org.
Mark

Many thanks, Mark. I'll try to contribute as much (and as needed) as possible once I start using the library.


error 403

When I run the command

twitter-dl<PHONE_NUMBER>256354304 test.mp4 --tweet

I get the error
ERROR   downloader: https://api.twitter.com/1.1/statuses/show.json error, code was 403 Traceback (most recent call last):   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main     return _run_code(code, main_globals, None,   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code     exec(code, run_globals)   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\Scripts\twitter-dl.exe\__main__.py", line 7, in <module>   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\lib\site-packages\twitter_dl\__main__.py", line 98, in main     downloader.download_media_of_tweet(args.resource_id, args.dest, args.size, args.video,   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\lib\site-packages\twitter_dl\downloader.py", line 63, in download_media_of_tweet     self.process_tweet(tweet, save_dest, size, include_video, include_photo)   File "C:\Users\mmh\AppData\Local\Programs\Python\Python310\lib\site-packages\twitter_dl\downloader.py", line 193, in process_tweet     if 'retweeted_status' in tweet: TypeError: argument of type 'NoneType' is not iterable
I've already added my key, secret, and bearer into my .twitter.json file, is there any way to avoid this 403 error?

same

Not working for me either. On a Ubuntu 22.04. Created a project on Twitter, added the data to .twitter.json. Are we doing something wrong in enabling permissions in Twitter Developer Portal?


memory related bugs of rocksdb implementation

Sponsors SeaweedFS via Patreon https://www.patreon.com/seaweedfs
Hi Chris,
I maintained my own rocksdb branch previously, happy to find out it's now offically supported.
Here's some small suggestions for the current implementation.

Option objects created from NewDefaultOptions NewDefaultReadOptions NewDefaultWriteOptions contain cgo pointers need to be released explicitly.
rocksdb_store.go#L96 entry.FullPath leads to nil pointer dereference.
Rocksdb iterator related keys & values will be freed automatically upon iterator's destruction, so iter.Close() ensures no memory leak without key.Free() or value.Free().

Other possible improvements:

Reuse default options when possible.
Use db.Get(and free by hand) instead of db.GetBytes to avoid memory copy when bytes are read only. Gorocksdb charToByte use reflect tricks by creating byte slice with underlying C char array to avoid char* to go []byte copy, while C.GoBytes performs memory copy.

This is great! Did you do any performance benchmarks between leveldb and rocksdb? I added a small test but not seeing any differences.

This is great! Did you do any performance benchmarks between leveldb and rocksdb? I added a small test but not seeing any differences.

There is no significant performance difference with my workloads.
but I'm mostly aim for

removing expired keys based on TTL by rocksdb compaction filter, like current redis, cassandra filer implementation.
more tuning options, mainly reduce write amplification or reduce write stall.

There is no significant performance difference with my workloads.
but I'm mostly aim for

removing expired keys based on TTL by rocksdb compaction filter, like current redis, cassandra filer implementation.
more tuning options, mainly reduce write amplification or reduce write stall.

I'll provide more patches if you're interested in features like TTL, but it's not tested yet.

I'll provide more patches if you're interested in features like TTL, but it's not tested yet.

Yes. TTL feature would be interesting.

Yes. TTL feature would be interesting.


Invalid content /en/programming-languages/marlowe/getting-started/using-the-marlowe-playground/

Where does the issue occur?
In the content, first paragraph.
Describe the issue
Broken links to the "Marlowe Playground" and "online tutorial"
Expected changes
Fix broken links
Additional context
Add any other context about the problem here.

links are working, so closing this issue


Dedicated asChild page

We have had a few reports that have been assumed to be an issue with the new asChild API but also will have been an issue with the as prop. It seems the explicitness of the asChild API has made some of these issues more apparent for people so it might be useful to provide some documentation on these pitfalls and the solutions to them.
The most recent report we had was here https://github.com/radix-ui/primitives/issues/953
It's not clear what props the child should accept (or that props need to be forwarded). For now we're saying it should always accept DOM props. Ideally we would improve the DX with TS but TS doesn't currently support the ability to type the props of the child React Element.

Yeah I agree a dedicated page would be good, we could flesh it out more than the tiny mention we have in the docs and point people to it at the very least.

Makes sense. Let me have a think and add it to my list.

I spent some hours today struggling with this as well, as I couldn’t find any hint on the documentation page that the React component supplied as the child has to forward a ref to its DOM element. Only after looking at some bug reports did I see that this is necessary. This doesn’t seem self-explanatory to me (though it makes sense, of course), so a documentation page on how to use asChild would be awesome.

@benoitgrelard go for it son

Wanna help? 🙂

Fully agree. This was a very insidious problem to figure out on my own—mention of this in the docs would have been really helpful.

👏


Adding global metadata

Docs Build status updates of commit a985bcd:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report as well as below information: One or more errors occurred..

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a985bcd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

DocsLegal/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


EDU-1127 Fix cut screens in media library and wikimedia

Closes https://educandu.atlassian.net/browse/EDU-1127
I have uncovered a few more styling issues with the screens, please see the ticket for all fixed cases.

Nice consolidations (and fixes) :heart_eyes:


Проблема с маркерами на яндекс карте.

Когда зумлю, все иконки будто расползаются/сползаются. На osm и google такого нет.

hi @er24scorpion sorry but i can only read french, english or spanish :\

Sorry.
When I do something zoom, then my markers spread out in different directions. And polylines too.

Hard to help without a link to your page or a jsfiddle...

http://jsfiddle.net/0bd5g1gc/1/
Bug when I zoom and drag map on Yandex tile.

Ok i see, this bug is a duplicate of #111 since yandex tiles are implemented like google tiles...
As i said in this comment https://github.com/shramov/leaflet-plugins/issues/97#issuecomment-114226868 :

This script may need a refactoring but i don't plan to do it, feel free to provide pull requests for it :)

Duplicate of #129


" CausedBy: "Type: mapper_parsing_exception Reason: "Root mapping definition has unsupported parameters:  [_size : {enabled=true}]"

Elasticsearch.Net.ElasticsearchClientException: Request failed to execute. Call: Status code 400 from: PUT /prod-e
vents-v1-2021.08.19. ServerError: Type: mapper_parsing_exception Reason: "Failed to parse mapping [_doc]: Root mapping d
efinition has unsupported parameters:  [_size : {enabled=true}]" CausedBy: "Type: mapper_parsing_exception Reason: "Root
mapping definition has unsupported parameters:  [_size : {enabled=true}]""
--- End of inner exception stack trace ---
at Foundatio.Repositories.Elasticsearch.Configuration.Index.CreateIndexAsync(String name, Func2 descriptor)    at Foundatio.Repositories.Elasticsearch.Configuration.DailyIndex.EnsureDateIndexAsync(DateTime utcDate)    at Foundatio.Repositories.Elasticsearch.ElasticRepositoryBase1.IndexDocumentsAsync(IReadOnlyCollection1 documents, Boolean isCreateOperation, ICommandOptions options)    at Foundatio.Repositories.Elasticsearch.ElasticRepositoryBase1.AddAsync(IEnumerable1 documents, ICommandOptions opt ions)    at Exceptionless.Core.Pipeline.SaveEventAction.ProcessBatchAsync(ICollection1 contexts) in C:\Users\88548\Desktop\Ex
ceptionless\Exceptionless.API\src\Exceptionless.Core\Pipeline\040_SaveEventAction.cs:line 23
When my client (using Nlog) submitted the log, I found that the data in es was not updated, so I started it with the console (originally using iis), and found that the put event could not be stored in es. I guess it was Foundatio.Repositories.AddAsync method does not support a certain grammar of es, because the ES version is 7.2.0 and no longer supports the creation of the specified type. The default type of the index is _doc. What are the official solutions?

UI.Verson:Exceptionless.UI-3.1.1
Api.Version:7.0.9
ElasticSearch.Version:7.10.0

Thanks for reaching out to us. This is a duplicate of #681. You need to ensure the mapper-size plugin is enabled or disable it via configuration as shown in #681
Also please note that we don't officially support IIS hosting.


Improve seeds

Description
This PR fixes some issues with our current seeds and adds a little extra supporting information to a couple of cases.
Before this PR, products were being created with very little data and linked to investigations in our seed data and we were creating duplicate products that were not linked to any investigations which was making the seed data very vague and unrealistic.
This PR also adds unexpected events (an accident and an incident) to a case, and a risk assessment to a case.
I tried to add collaborations to give examples of teams with different access levels to cases but while this did work in the development environment, it did not work in the review apps due to the team data being different between the two environments. Perhaps going forward this might be something we want to make uniform, along with any additional suggestions from the team.
Before:

After:

Checklist:

[ ] Have you documented your changes in the pull request description?
[ ] Does the change present any security considerations?
[ ] Is any gem functionality overloaded? Eg: Devise controller methods being overloaded.
[ ] Has acceptance criteria been tested by a peer?
[ ] Has the CHANGELOG been updated? (If change is worth telling users about.)

General testing (author)

[ ] Test without JavaScript
[ ] Test on small screen

Accessibility testing (author)

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable CSS - does content make sense and appear in a logical order?

Data looks much better with supporting info and realistic, however, we need further cases to look more like prod

TS cases (apart from OPSS cases)
Cases to be created by multiple teams such as the Operational Support team, Birmingham council, Southampton council(as per team data in seed), please do not use seed organisation or seed team as none users belong to this team hence can't edit
Some restricted cases
create all types of allegations including projects, enquiries etc
Need at least 25-30 cases to show pagination stuff too
Cases with collaborators ( multiple teams added to the case)
Create case and change owner to diff user
Create cases with case owner as a team
Create cases with supporting information accidents/incidents, corrective actions only
Create cases with test results only
Create cases with only correspondence
Add case validating role to users


Bootstrap for React/Vue

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Bootstrap is still the main CSS toolkit I use to build websites. It is great. However, recently I started thinking about how will it evolve in order to remain relevant in the context where JS libraries are more and more used by developers.
What is the best way to use Bootstrap with JS frameworks? Should I use Bootstrap as it is or do I need third-party libraries like Reacstrap? Wouldn't it be a good option to give developers the tools and documentation to build stuff in various environments?
Thanks in advance!

Wouldn't it be a good option to give developers the tools and documentation to build stuff in various environments?

what tools you mean? In programming, there is a principle of single responsibility: package should not contain anything superfluous

I don't mean to add something to the actual package, but to add support for JS libraries for example. Another library maybe?
This way we don't rely on third-party libraries that are not updated or depend on other developers that are not in the core team. Also, this ensures a more consistent codebase and syntax. Third-party libraries are great but they are created by different people with different visions.
Anyways, it's just something worth discussing, at least for me it's something that would be very helpful.
Out of the box, Bootstrap is great for back-end frameworks like Laravel, but when it comes to front-end libraries, it is not that easy.

@alexisenache what's you mean "add support for JS libraries"? can you show example?

This way we don't rely on third-party libraries that are not updated or depend on other developers that are not in the core team.

bs have only one optional dependency - popperjs
https://github.com/twbs/bootstrap/blob/63d38b19740eac25b8603dc9a9ae11e1df4667f7/package.json#L100

Anyways, it's just something worth discussing, at least for me it's something that would be very helpful.

I'm trying to understand what exactly you want

Out of the box, Bootstrap is great for back-end frameworks like Laravel, but when it comes to front-end libraries, it is not that easy.

why? use bs5 with vue3, mithril  without any problem

why? use bs5 with vue3, mithril without any problem

What about JS components: dropdowns, modals. I am referring more to those.

@alexisenache BS component use event's and work fine with dynamic content generated by vue/mithril

(As already mentioned) loading bootstrap is all you need to do to make your dropdowns, modals, etc work inside your react or vue project. So long as the framework you're using outputs html onto the page, bootstrap is completely capable of initializing any of its interactive components with your html. However, there are some caveats and headaches (including but not limited to)

properly disposing of bootstrap components when your framework removes dom nodes
accessing bootstraps dom events with frameworks that use virtual doms can be cumbersome
initializing bootstrap components on dom elements with frameworks that use virtual doms can be cumbersome (think tooltips & popovers that require manual initialization)

Solving these are possible, but could certainly be non-obvious unless you are very familiar with bootstrap and your javascript framework. Because of this, I do think there is utility in creating other (separate) bootstrap wrappers that solve these problems without the need for complete re-implementations like reactstrap that you mentioned.
For example, I've created a wrapper for react that does exactly this called bs5-react-elements. It provides a better developer experience to use bootstrap in react projects. It handles the framework and bootstrap specific caveats without the need for the developer to handle it themselves.
IMO while small wrapper libraries like this one certainly aren't necessarily, they make life much easier. Other wrappers for other frameworks (either community or twbs maintained) could help a lot as people look to use bootstrap on their projects. I'm not entirely sure how this would align with bootstraps goals, but I do think its worth considering.

This way we don't rely on third-party libraries that are not updated or depend on other developers that are not in the core team.

That's probably why it won't happen any time soon, sadly. The core team is a few people only, all volunteers, and trying to maintain and improve Bootstrap core. Handling yet another side project is improbable due to the lack of time and capabilities.

Third-party libraries are great but they are created by different people with different visions.

And for different needs, too. We cannot handle React, Angular, Vue, Svelte, etc. libraries on top of our core. Wrapper like your own exists, have maintainers, and anyone is free to contribute to it too.
FYI there're currently a few PR aiming at being more SSR-friendly, which covers a part of your request I guess?
In my opinion, if you're able to spot an issue on our side and provide a reduced test case, we'll consider working on a fix.


[FLINK-25895][table-planner] Splitted ExecNodeGraphJsonPlanGenerator

What is the purpose of the change
This PR reorganizes a bit the code that was previously in ExecNodeGraphJsonPlanGenerator. It introduces ExecNodeGraph ser/de to handle the intermediate JsonPlanGraph representation directly.
Brief change log

Reorg the code in ExecNodeGraphJsonPlanGenerator in:

Moved to the upper level the intermediate graph model (and made it package private)
Removed unnecessary intermediate methods
Isolated the validator in a separate class

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@matriv given your two comments, does it makes sense to just go ahead and remove this validator?

@matriv given your two comments, does it makes sense to just go ahead and remove this validator?

Yes, the @JsonCreator is tested statically when we build the lookupMap in the ExecNodeMetadataUtil, and the other is always checked for not null in the ctor, so go ahead and completely remove it.

I reverted the removal of ExecNodeGraphValidator, as it seems like because of legacy tables, TemporalTableSourceSpec can be initiated with empty DynamicTableSourceSpec.


Don't set the RG tag using read.getReadGroupId()

In practice these values have different semantics. In the Readstore API, the readGroupId is a server-generated ID which corresponds to a read group that the user imported. Every Read in the Readstore belongs to a read group, meaning that even if the original caller imported reads without a read group, we would allocate a new one for them.
This "RG" tag will already be set everywhere we would want to consume it downstream.

Coverage decreased (-0.04%) to 62.402% when pulling c291da93ed7eb3144841505ac6ec83af04ec98ae on calbach-patch-1 into 2429242cf4caa0edd8c63d561aeb9591f20b0c17 on master.

Coverage decreased (-0.04%) to 62.402% when pulling c291da93ed7eb3144841505ac6ec83af04ec98ae on calbach-patch-1 into 2429242cf4caa0edd8c63d561aeb9591f20b0c17 on master.