A conflict with Tabs Outliner

New Issue Checklist (tick off like this: [x])

[x] I checked existing issues (open and closed) for possible duplicates
[x] I can reproduce the problem on the latest stable version (not nightly!)

What is your browser?

[ ] Firefox
[x] Chrome

What is your operating system?

[ ] Linux
[ ] Mac
[x] Windows

Description (please include examples/screenshots where applicable)
Thank you for the extension.
The latest version conflicts with the Tabs Outliner extension (this is a tab/session manager). If you try to open a previously saved tab (b) (see the screen), which is a child of (a), and at the same time there's an open tab (c) below (b), and (c) is active, then (b) while being opened jumps down and opens below (c), and concurrently there is a "ghost" (b) in the old place, and this tab is "broken", when you try to activate it, new tabs open with an error. As a result, I have a broken tab hierarchy.
I assume that the reason for this behavior is the change in the method of moving a new tab to the currently open one. Can you please somehow adjust this move method so that it does not conflict with the Tabs Outliner, or please add an option to switch to the old method, because this problem did not occur on all previous versions.
I understand that solving this problem may be difficult, but maybe you'll like Tabs Outliner (for me it's an absolutely unique extension in its class) and you will want to fix the above error.

I don't see how my latest change could cause this kind of problem. If it worked before, it was probably by accident. How tabs are moved did not actually change, just the way the current tab is identified. There could be a problem in Tabs Outliner though caused by the latest Chrome version. I think in general you should probably not combine two extensions that are about tab positions. I am not interested in looking in Tabs Outliner.


Cookie preferences

The changes for cookie preferences has been implemented and ready to be merged to the development branch.

 Cookies preferences page and different banner text

The branch will be merged once PR #48 is merged to the master branch and released.
Thank you @johnbenjaminphe for the great work.

src/App.js should be deleted as this no longer exists with gatsby

@johnbenjaminphe Could you please look into @neb42's comment?

@neb42, @xenatisch
src/App.js file is now deleted.

@neb42 Are you satisfied with the change?

The update for cookie preferences is now done.


[Bug]: Hook examples should check that the caller is the poolManager and that the sender is the hook itself

Describe the bug
I think some hook examples like FullRange.sol do not call out to the onlyByManager modifier and also need to check that the original sender is itself.
Expected Behavior
Add onlyByManager modifier, check sender == address(this)
To Reproduce
No response
Additional context
No response

sender == address(this) isnt for hooks necessarily - its for contracts with a lockAcquired which shouldnt be all hooks

Hi! thanks for flagging -- going to close this issue because:

hook examples no longer live in the main branch

custom accounting will allow for a more v2-style curve with v2 interfaces. reference implementation https://github.com/hensha256/v2-on-v4


update the plugin

Hi Ilias,
I've yanked the gem on Rubygem.org. As I mentioned, may I open up a pull request to update to plugin to the newest version? There have been major changes in the plugin since the the last release of the gem.
Again, I apologize for my ignorance of the convention of the community.
Jason

Sure. Please open a pull request with your updates/fixes.

Hi Ilias,
@JasonMrX and I have opened a new pull request. Would you mind having a look at the updates. Thanks.
Rong


Simplified API for FFI

Inspired by this observation from @multimeric, I just realized that we do not really need a Field to read an array - the DataType is sufficient.
This PR leverages this observation to simplify the API a bit further. The updated examples show the idea.

Is the idea with this PR that the Schema isn't needed, and so a Chunk is therefore equivalent to a RecordBatch?

Yes, that is the core observation - exporting an Array does not require a schema nor fields, only its datatype. Because every array stores such a datatype in this implementation of Arrow, we can just expose the API for that.
This does not close #854 , they are related but independent :)

Also I don't understand how you can pass the data type into the C function that expects a schema pointer. How does that work at all? Are we not losing information stored in the Schema as well?

What is "the C function"? What is "Schema"?
There are two things supported by the C data interface:

A Field (Ffi_ArrowSchema)
An Array (Ffi_ArrowArray)


Edit title fix for Notebook and Paragraph

enable autofocus to input field (no need to click twice to edit title)
fix esc key handler on edit input to revert the change (edit and hit Esc to reset the title back to the old one)
save title on enter and blur

Before:

After:

@r-kamath since we are doing this, can you add animation to the input box like its here http://www.w3schools.com/bootstrap/bootstrap_forms_inputs.asp

@prabhjyotsingh adding transition requires too many other changes. Planning to do it in a different ticket/PR

I just checked that PR, a few comments:

When we have a new paragraph title untitled, the value is not inside the input on edit.
When the inputs appear, it makes the element height and vertical position change

@corneadoug fixed

And I still have the element height issue for the Notebook Title

Can you also update the license file?
https://github.com/apache/incubator-zeppelin/blob/b5e2e62f239d6b1b625add16405e3a302e8ff060/zeppelin-distribution/src/bin_license/LICENSE

CI seems to be failing for the same reason as my PR #324

@corneadoug try merging master on #324

@r-kamath Could you rebase? Seems there is some conflicts

Merging if there is no more discussions


Add bound checking in net_addr_pton()

In samples/net/rpl-mesh-qemu:
When I input : "net ping fe80::210:2030:9b:d48efe80::210:2030:9b:d48e " in the shell , the kernel panic.
I found there is an the issue in net_addr_pton() function.
Signed-off-by: walter-xie<EMAIL_ADDRESS>

Codecov Report

Merging #8688 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #8688      +/-   ##
==========================================
- Coverage   52.22%   52.22%   -0.01%
==========================================
  Files         195      195
  Lines       24662    24664       +2
  Branches     5125     5126       +1
==========================================
  Hits        12880    12880
- Misses       9716     9717       +1
- Partials     2066     2067       +1

Impacted Files
Coverage Δ

subsys/net/ip/utils.c
79.71% <0%> (-0.47%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e69e9a...23896f8. Read the comment docs.

嘿，老哥，不要总是关掉上一个PR然后在开一个新的。
如果你想改动代码的内容，或者更改commit的信息，使用git commit --amend修改之后，git push --force强推到你自己的git分支上就行了。
你提的这个PR会自动更新你强推的内容的。
 You should using `git rebase' to 'squash' them as one commit.  There has a Chinese version document about 'git rebase':  rebase.

The commit informations is unlovely and shippable reported two errors. Please check and fix it. shippable

1: UC2 Body does not contain a 'Signed-Off-By' line
1: UC3 Title does not follow [subsystem]: [subject]: "Update utils.c"
1: UC6 Body has no content, should at least have 1 line.
3: B6 Body message is missing

23896f8e6952d41a184af0061f2f309e4ad7915b: author email (walter-xie<EMAIL_ADDRESS>does not follow the syntax: First Last

How to modify the "UC2 Body" "UC3 Title" etc with web browse?
Like in this way: (You should change your commit informations like this, not in this PR's descripter)
Please using 'git commit --amend' and rewrite commit informations.

net: Add bound checking in net_addr_pton()

In samples/net/rpl-mesh-qemu:
When I input : "net ping fe80::210:2030:9b:d48efe80::210:2030:9b:d48e " in the shell , the kernel panic.
I found there is an the issue in net_addr_pton() function. Fix it.

Signed-off-by: Walter Xie<EMAIL_ADDRESS>

I have no perssion to push the commits:
You doesn't has the access push any branch to zephyrproject-rtos/zephyr, but you can push 'bug-fix' branch to your's branch.

I had noticed that 'git remote -v' doesn't list your's repo. You should add your's first.
git remote add origin https://github.com/walter-xie/zephyr.git

Then push 'bug-fix' branch to yours repo:
git push origin bug-fix --force

The commit message looks a bit weird, the subsys string is redundant there. The commit message could look something like this (adjust the text if needed):
net: Add bound checking to net_addr_pton()

The net_addr_pton() did not check the number of ":" characters properly.
For example with following net-shell input
net ping fe80::210:2030:9b:d48efe80::210:2030:9b:d48e
the kernel panics.

Signed-off-by: Walter Xie<EMAIL_ADDRESS>
So please squash the patches together, fix the commit message and force push the PR.

Please rebase your changes on top of master, instead of merging from master.

recheck

Please update your's config to fix Shippable Errors:

2eb1f7a08d82219f338adcf969c3a3a65adfca4e: author email (walter-xie<EMAIL_ADDRESS>does not follow the syntax: First Last .

Because you just changed the commit message's 'Signed-off-by' to yours new name and new email, and doesn't update the commit's author. Next is this commit's informations: (Please notice that the Author doesn't changed, so Shippable report error).
commit 2eb1f7a08d82219f338adcf969c3a3a65adfca4e
Author: walter-xie<EMAIL_ADDRESS>Date:   Tue Jul 3 10:27:29 2018 +0800

    net: Add bound checking in net_addr_pton()

    In samples/net/rpl-mesh-qemu:
    When I input : "net ping fe80::210:2030:9b:d48efe80::210:2030:9b:d48e "
    in the shell , the kernel panic.
    I found there is an the issue in net_addr_pton() function. Fix it.

    Signed-off-by: Walter Xie<EMAIL_ADDRESS>
'git config --list' can list which user name and user email you used. and 'git config --global' can change that.
git config --list | grep user
git config --global user.name "Walter Xie"
git config --global user.email<EMAIL_ADDRESS>
But 'git commit --amend' doesn't update 'Author' even if you had changed git global's config. So you need another step to rewrite the 'Author ' informations:
git commit --amend --author="Walter Xie<EMAIL_ADDRESS>
Now the 'Author' changed:
commit 02c41fb462186d80686953ade9020a9608f54f10
Author: Walter Xie<EMAIL_ADDRESS>Date:   Tue Jul 3 10:27:29 2018 +0800

    net: Add bound checking in net_addr_pton()

Don't forget push to your's repo:
git push origin bug-fix --force

Could you please update commit informations based on @jukkar request?


Fixed detail view of public devices

The detail view have now a container, breadcrumbs and a footer.
Do we want to have these buttons in the breadcrumbs?

Sorry for the late response.
I think showing buttons that don't work should definitely be avoided. It's just too confusing for anyone browsing the public list otherwise.

I changed the code so that we have no buttons at the top of the detail view.

Or do we want at least have some buttons?

Looks good, but the tests failed. Can you remove the reversion change again?

Changed it.


[bug] Running Tauri with external URL as devPath returns Unacceptable TLS certificate in Linux

Describe the bug
I'm setting my devPath to an external URL that is running my Vue application. However, even using a signed and valid SSL certificate, Tauri keeps returning me a blank screen with Unacceptable TLS certificate. It only occurs in Linux version (Ubuntu 22.04) and I cannot reproduce in Windows 10.
Besides that, If I change the devPath to use an HTTP port, it works properly.
Reproduction

Host an application anywhere with a valid and signed SSL certificate (HTTPS);
Set the devPath to the ip:port of the application;
Run yarn tauri dev;
Receive Unacceptable TLS certificate.

Expected behavior
To open the application that is running in a HTTPS port.
Platform and versions
yarn run v1.22.19
$ RUST_LOG='info' RUST_BACKTRACE='full' tauri info

[✔] Environment
    - OS: Ubuntu 22.04 X64
    ✔ webkit2gtk-4.1: 2.38.6
    ✔ rsvg2: 2.52.5
    ✔ rustc: 1.70.0 (90c541806 2023-05-31)
    ✔ Cargo: 1.70.0 (ec8a8a0ca 2023-04-25)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
    - node: 16.17.0
    - yarn: 1.22.19
    - npm: 8.15.0

[-] Packages
    - tauri [RUST]: 2.0.0-alpha.9
    - tauri-build [RUST]: 2.0.0-alpha.5
    - wry [RUST]: 0.28.3
    - tao [RUST]: 0.19.1
    - @tauri-apps/api [NPM]: not installed!
    - @tauri-apps/cli [NPM]: 2.0.0-alpha.9

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: https://my-private-ip:1445/
    - devPath: https://my-private-ip:1445/
Done in 12.32s.

Stack trace
Unacceptable TLS certificate

Additional context

The certificate was generated with let's encrypt.
Wasn't able to find/use the fix that is related at: https://github.com/tauri-apps/tauri/issues/4472

Any update?

Can you test if you see the same issue in Epiphany (also known as Gnome Web)? - sudo apt install epiphany-browser (Their flatpak version doesn't use the system libs so it wouldn't be the same in comparison)

No, it's a browser like firefox/chrome based on webkitgtk, which tauri uses for the webview on linux and i'd like you to try the same url in there to see if loads correctly.

Oh ok, sorry for the misunderstanding. When I open the URL using Epiphany, I get a blank screen without any error message or log. But there's a warning at the top saying, This website's digital identification is not trusted...

I had this problem and was able to fix it for myself. I tested my server on SSL Labs and found out my server's certifcate chain was incomplete. After I fixed that by including the ca-bundle in my server's .crt file, I didn't get this error anymore.

I had this problem and was able to fix it for myself. I tested my server on SSL Labs and found out my server's certifcate chain was incomplete. After I fixed that by including the ca-bundle in my server's .crt file, I didn't get this error anymore.

Thanks, @shamblesides!
Using the fullchain certificate seems to work.


No service-response-time metrics for Heroku

Grafana is not displaying any service-response-time metrics for the new Heroku servers (either staging or production environments).

I moved charts from https://metrics.shields.io/d/service-response-time/service-response-time?orgId=1 to https://metrics.shields.io/d/aESRBSjmz/services (info). I will remove service-response-time dashboard.


checker(dm): allow unsupported charset workaround

What problem does this PR solve?

Issue Number: ref #7333
What is changed and how it works?
user can create table with utf8mb4 in downstream to workaround the problem that upstream table has unsupported charset
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/run-dm-integration-test

/cc @GMHDBJD @okJiang

Codecov Report

Merging #7349 (3ebaf0a) into master (11dbe58) will decrease coverage by 0.0440%.
The diff coverage is 48.3957%.

Additional details and impacted files

Flag
Coverage Δ

cdc
67.5426% <42.2310%> (-0.2189%)
:arrow_down:

dm
52.0257% <60.9756%> (+0.0822%)
:arrow_up:

engine
60.8861% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7349        +/-   ##
================================================
- Coverage   59.8873%   59.8433%   -0.0441%
================================================
  Files           799        801         +2
  Lines         91637      91905       +268
================================================
+ Hits          54879      54999       +120
- Misses        31982      32126       +144
- Partials       4776       4780         +4

/cc @lichunzhu @buchuitoudegou

/merge

/run-engine-integration-test

/run-integration-test

/run-engine-integration-test

/run-integration-test


Grafana 7 removes error headers

This bug was found by LH on stack overflow, here.
I checked with the latest Warp 10 release, no problem with Grafana 6.
Then I checked with Grafana 7.0.0 and 7.3.6, something in the query processing is removing the headers from the error answers. So, the plugin is unable to display error and error line.
In the error handler, err do not contain anything usefull in Grafana 7, here in the code...

Closed by #84 , tested with Grafana 6.x and 7.x

Closed by #84 , tested with Grafana 6.x and 7.x


Some types do not resolve correctly

Really cool engine! I love the simplicity of the API.
When using the template, some types seem to not be loaded through the declarations, running tsc on the index.d.ts declaration gives a few errors,
>  tsc types/index.d.ts
types/index.d.ts:5:16 - error TS2304: Cannot find name 'LitecanvasOptions'.

5     settings?: LitecanvasOptions,
                 ~~~~~~~~~~~~~~~~~

types/index.d.ts:6:4 - error TS2304: Cannot find name 'LitecanvasInstance'.

6 ): LitecanvasInstance
     ~~~~~~~~~~~~~~~~~~

types/index.d.ts:9:36 - error TS2304: Cannot find name 'LitecanvasOptions'.

9     function litecanvas(settings?: LitecanvasOptions): LitecanvasInstance
                                     ~~~~~~~~~~~~~~~~~

types/index.d.ts:9:56 - error TS2304: Cannot find name 'LitecanvasInstance'.

9     function litecanvas(settings?: LitecanvasOptions): LitecanvasInstance
                                                         ~~~~~~~~~~~~~~~~~~

types/index.d.ts:419:26 - error TS2304: Cannot find name 'drawCallback'.

419         draw: string[] | drawCallback,
                             ~~~~~~~~~~~~

types/index.d.ts:622:28 - error TS2304: Cannot find name 'pluginCallback'.

622     function use(callback: pluginCallback): void
                               ~~~~~~~~~~~~~~

Found 6 errors in the same file, starting at: types/index.d.ts:5

Perhaps they need to be explicitly imported from types.d.ts?

I don't usually use TypeScript, but I'll try to solve that.

@rottencandy  can you take a look in PR #21 ?


Add CODE OF CONDUCT.md

The Code oof Conduct will defines standards for how to engage in a community.
File type markdown.

@thestarsahil Could you please assign this issue to me under GSSOC ' 23.
I would like to work on it.
Thank you!

Go ahead !

I'm a GSSoC contributor ..
I would like to work on this section...
would you please assign me to this task ??

This issue is already assigned.
You can work on other issues.

ok


fix: dns.Hostmapping in JSONv5 config treats ip as Base64 (#2107)

#2107

Codecov Report
Base: 39.19% // Head: 39.18% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (c605bfb) compared to base (42b1667).
Patch coverage: 0.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
- Coverage   39.19%   39.18%   -0.02%
==========================================
  Files         617      617
  Lines       36824    36833       +9
==========================================
- Hits        14434    14432       -2
- Misses      20797    20806       +9
- Partials     1593     1595       +2

Impacted Files
Coverage Δ

app/dns/config.pb.go
12.63% <0.00%> (ø)

app/dns/dns.go
63.66% <0.00%> (-2.05%)
:arrow_down:

transport/internet/websocket/connection.go
16.51% <0.00%> (-3.67%)
:arrow_down:

transport/internet/quic/hub.go
72.00% <0.00%> (-2.67%)
:arrow_down:

transport/internet/headers/http/http.go
83.54% <0.00%> (+2.53%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Crash in iOS

When I upgrade moka from version 0.11 to 0.12, my app crashed in iOS, but this issue not appears in others platforms.
I don't know the reason.
https://github.com/ShadowsocksR-Live/overtls/commit/6724ec408d7fe1d901c33efb2e245535fd296eeb

Thank you for reporting the issue.
The crash message "bad instruction" implies some of the processors used in the iOS devices do not support reading from the cntvct_el0 register. moka v0.11 and v0.12 depend on quanta v0.11 and v0.12 respectively. And quanta v0.12 tries to read from cntvct_el0 register on arm64 processors.
I will report this to quanta crate and see if they can workaround it.

I have reported. https://github.com/metrics-rs/quanta/issues/101

fixed


Distinct recognition might be borked by new QSU forms

subqueryGroupBy.test and possibly also unsupportedTests.test.  This appears to be an issue on both mimir and mongo, but maybe different causes.

We could also just add Distinct to qscript, either as an optional coproduct node, or as a required one (meaning we have to update each connector, but that might not be that hard).

I'm legit terrified about the scala compilation time implications of that though.

That's all too fair :(
Moving forward we can't have compile times preventing us from doing the right thing, but that's not something we're about to tackle pre-5.0. It might be worth adding the node unimplemented everywhere, and benchmarking the compile times, if someone has a computer with some CPU cycles to spare...

Yeah that might be worth doing.  It's a particularly interesting case in the above, since neither of the queries in question involve distinct!  It's just that the pattern is the same as what gets generated from a Distinct node.

Oh, that's actually really interesting. I wonder if there is a more general pattern we want to detect in qsu.

I was thinking about it. I'm not yet convinced that interpreting it as distinct is universally the right thing to do though.  And in this particular case, it only exists because we don't have join reassociation.  But maybe…
I'd venture a guess that most backends are going to have a primitive distinct that is more efficient than reduction.

I figured this out.  At least for mimir, it has nothing to do with distinct recognition.  Rather, it's the fact that we always used to get reduce buckets wrapped in an array.  Now, since we get them separated, we're hitting some code paths that were never checked before, and are in fact buggy.  I would venture to guess that mongo is having the same problem.  (@jsantos17 / @rintcius ?)

https://gist.github.com/rintcius/160625ed8181269ba39fd87449eee476 shows the same problem as subqueryGroupBy.test but is smaller. The problem is that the last operation in the pipeline is map-reduce. When this is the case the sorting is not done. We have a rewrite in place - mapBeforeSort - that avoids this in some cases, but not all.
unsupportedTests.test has another issue, it doesn't return any results. Haven't looked at it in detail, but here's the plan: https://gist.github.com/rintcius/8e33fab7ac11ea9bcf42aa22b295d619

@rintcius would performing mapBeforeSort at the workflow level instead of the QScript level help with subqueryGroupBy.test? Do we have an issue for that?

@jsantos17 Yes, there's this issue #3063 - needs further investigation with respect to how to fix this, I am not seeing a simple solution here.

On old mongo none of these queries worked either, so no regression compared to old mongo:
$ SELECT ceil(100 * SUM(pop) / (SELECT SUM(pop) FROM zips)), state FROM zips GROUP BY state ORDER BY state LIMIT 5
Quasar error: failed to merge

$ SELECT SUM(pop), (SELECT SUM(pop) FROM zips), state FROM zips GROUP BY state ORDER BY state LIMIT 5
Quasar error: failed to merge

$ select name from newTests where count(backends{_}) = 12 order by name limit 5
Quasar error: The function 'ShiftMap' is recognized but not supported by this back-end. (in workflow planner)


[stable/prometheus-operator] wrong pod cpu metrics, if you've sidecard

update: This only happens, when I ran istio1.5 in the cluster.
But the namespace doesn't have istio enabled

Describe the bug
A clear and concise description of what the bug is.
created a deployment with sidecar(both container with 1G ad 1vCpu limit), and gave load to 1st container. But Kubernetes / Compute Resources / Pod dashboard shows wrong data
Version of Helm and Kubernetes:
❮ helm version
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.14"}

❮ k version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0", GitCommit:"2bd9643cee5b3b3a5ecbd3af49d09018f0773c77", GitTreeState:"clean", BuildDate:"2019-09-18T14:36:53Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.7", GitCommit:"c83d931fb9bece427bc63a02349755e0f8696d3e", GitTreeState:"clean", BuildDate:"2020-01-31T20:09:49Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
NAME                            NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                                   APP VERSION

prometheus-operator             monitoring      1               2020-03-19 20:58:44.166518629 +0530 IST deployed        prometheus-operator-8.12.3              0.37.0

How to reproduce it (as minimally and precisely as possible):
apiVersion: apps/v1
kind: Deployment
metadata:
  name: nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      app: nginx
  template:
    metadata:
      labels:
        app: nginx
    spec:
      containers:
      - name: tcpdump
        image: corfr/tcpdump
        resources:
          limits:
            cpu: 1
            memory: 1Gi
          requests:
            cpu: 100m
            memory: 100Mi
        command:
          - /bin/sleep
          - infinity
      - name: name
        image: nginx
        imagePullPolicy: IfNotPresent
        resources:
          requests:
            cpu: 100m
            memory: 200Mi
          limits:
            cpu: 1
            memory: 1Gi
        ports:
        - containerPort: 80

kubectl exec -it nginx-5c8f869fd4-ghlhc -c name bash
# apt update
# apt install stress-ng
# stress-ng --cpu 4 --io 2 --vm 1 --vm-bytes 1G --timeout 10m

Actual metrics

Mertics from grafana

closing the issue.


Proxy any registry and do it automatically (using MutatingWebhookConfiguration)

Sorry for the size of this PR, I saw no other way to do this (and do it fast).
The goals of this PR:

Fix the helm chart
One click install of Trow with its admission webhooks through helm
Add a mutation admission webhook so images in pods are automatically routed through Trow => Fixes https://github.com/ContainerSolutions/trow/issues/322
Ability to proxy any registry (#250) -> handle multiple types of authentication methods (https://github.com/ContainerSolutions/trow/pull/279)

Other changes that happened:

replace the validation configuration: the old way of configuring validation was way too complicated for me. There were 6 CLI args + the logic regarding if the image is "local" or not. => replaced by a .yaml that only configures the webhook (no side effects)
move some logic from trow-server to modules: proxy_auth.rs, image.rs => it made writing tests so much easier
use kube and k8s-openapi instead of custom types for AdmissionReview

Deprecation of ./quick-install/ and ./install/:
I want to greatly simplify the deployment by only providing an easy to use helm chart. These folders push the user to run many manual steps/scripts and they duplicate deployment config. I did not outright delete these folders because this PR has already too many changes, but it's planned.
Notes:

I am running this Trow version in prod. Deployed via Helm, chart hosted at: https://github.com/awoimbee/helm-charts/releases/tag/trow-0.4.1
The helm_chart_validation test fails because it uses the old docker container, which takes different CLI args from the new one. This PR is already big enough as is so I'm not gonna fix that.
the webhook patch deployment thing is largely inspired by ingress-nginx

Hello folks, this is super useful! Probably what we need for #339. @awoimbee Why isn't it merged yet?

@amouat Please consider merging this PR, it would help us a lot.

@mysticaltech there's a few conflicts that need resolved, but they don't look difficult.
@awoimbee what's the outcome of this patch - does helm become the standard way to install Trow? I assume kustomize still works?

@amouat
Helm becomes the standard way, I have not touched kustomize, so it will likely fail due to the new validation webhook and the new CLI args.
The outcomes are listed in the PR description, but if I had to list them now (1 year later), it would be:

EZ install via helm, the required TLS certs are auto generated.
MutatingWebhook: I can deploy stuff to my cluster without making sure every image is pulled through Trow, Trow does it automagically with its MutatingWebhook.
EZ validating webhook config: one can easily set a blacklist, a whitelist and the default behavior.

My setup

The equivalent values.yaml to what I use would be:
image:
  tag: 22-06-2022-0
trow:
  domain: <IP_ADDRESS>:12345
  validation:
    enableWebhook: true
    config:
      default: Deny
      allow:
      - <IP_ADDRESS>:12345/
      -<PHONE_NUMBER>52.dkr.ecr
      - public.ecr.aws/
  proxyConfig:
    enableWebhook: true
    config:
    - { alias: docker, host: registry-1.docker.io }
    - { alias: quay, host: quay.io }
    - { alias: nvcr, host: nvcr.io }
    - { alias: ghcr, host: ghcr.io }
    - { alias: k8s, host: registry.k8s.io }
    - { alias: k8s-gcr, host: gcr.k8s.io }
    - { alias: gcr-k8s, host: k8s.gcr.io }
    - { alias: elastic, host: docker.elastic.co }
#   - [...]
    - { alias: ecr, host: xxxxxxxxxxxx.dkr.ecr.us-west-1.amazonaws.com, username: AWS }
service:
  type: NodePort
  nodePort: 12345
resources:
  requests:
    cpu: 100m
    memory: 128Mi
volumeClaim:
  resource:
    requests:
      storage: 30Gi

The final describe pods looks like (I have shortened and redacted it):
Name:                 trow-0
Priority Class Name:  system-cluster-critical
Status:               Running
Controlled By:  StatefulSet/trow
Init Containers:
  trow-webhook-cert-translate:
    Command:
      sh
      -c
      cp /etc/trow/webhook-cert-ecc/cert /etc/trow/webhook-cert && \
      openssl pkcs8 -topk8 -nocrypt -in /etc/trow/webhook-cert-ecc/key -out /etc/trow/webhook-cert/key
    Mounts:
      /etc/trow/webhook-cert from webhook-cert-translated (rw)
      /etc/trow/webhook-cert-ecc from webhook-cert-ecc (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-xxxxx (ro)
Containers:
  trow:
    Image:         awoimbee/trow:22-06-2022-0
    Args:
      --no-tls
      -n
      <IP_ADDRESS>:12345
      --proxy-registry-config-file=/etc/trow/proxy-registries.yaml
      --image-validation-config-file=/etc/trow/validation.yaml
    Mounts:
      /data from data-vol (rw)
      /etc/trow/proxy-registries.yaml from trow-proxy-cfg (ro,path="proxy-registries.yaml")
      /etc/trow/validation.yaml from trow-validation-cfg (ro,path="validation.yaml")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-xxxxx (ro)
  trow-webhook:
    Image:         awoimbee/trow:22-06-2022-0
    Args:
      --cert=/etc/trow/webhook-cert/cert
      --key=/etc/trow/webhook-cert/key
      -n
      <IP_ADDRESS>:12345
      --proxy-registry-config-file=/etc/trow/proxy-registries.yaml
      --image-validation-config-file=/etc/trow/validation.yaml
    Mounts:
      /data from data-vol (rw)
      /etc/trow/proxy-registries.yaml from trow-proxy-cfg (ro,path="proxy-registries.yaml")
      /etc/trow/validation.yaml from trow-validation-cfg (ro,path="validation.yaml")
      /etc/trow/webhook-cert from webhook-cert-translated (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-xxxxx (ro)
Volumes:
  data-vol:
  webhook-cert-ecc:
  webhook-cert-translated:
  trow-proxy-cfg:
  trow-validation-cfg:
  kube-api-access-xxxxx:

Basically I like this a lot, but I'd also like kustomize to keep working. If you're still using this and are able to maintain (the helm side of things) we should merge.
Unfortunately I don't have time to do much work on this any more since changing jobs.

Folks, our Kube-Hetzner project is growing fast, and many Hetzner Cloud nodes are blacklisted by gcr and everything that uses it underneath like registry.k8s.io, and ghcr.io. But in a single cluster, most nodes are ok, so this is an IDEAL solution.
So, we will recommend this, and even ship it as an add-on. So we will do our fair share to provide users!
I think it has amazing potential! If you folks combine forces it would be of great help to a lot of people.

@mysticaltech please drop me an e-mail to adrian.mouat at gmail and we can talk about options.

Basically I like this a lot, but I'd also like kustomize to keep working. If you're still using this and are able to maintain (the helm side of things) we should merge.

I can maintain the helm chart, but not the quick-install and kustomize.
Keeping only the helm deployment would free this repo from more than 1700 lines of yaml, docs and scripts.
The helm chart from this PR is available for testing @ https://awoimbee.github.io/helm-charts, I'm using v0.4.1.

@amouat Thanks, but please know that we are fully open-source and doing voluntary community work. It was a tool I originally created for myself, but it picked up some pace.
Personally, we will only need to helm option, so really appreciate you sharing this @awoimbee! Thanks.

If you're still using this and are able to maintain (the helm side of things) we should merge.

We should merge @amouat.

Wonderful!


Security release process

First cut at the security release process for Emissary. Feedback welcome -- nay, needed. 🙂
Signed-off-by: Flynn<EMAIL_ADDRESS>

Fixes #3516.


Update CI with explicit permissions for publishing images

Hi, after encountering a recent issue in VCX's CI with image publishing permissions, i checked acapy as well..
I believe something changed in the hyperledger organisation settings last week where the GITHUB_TOKEN default permissions dropped to read-only. As a result, our image-publishing jobs started getting denied..
e.g. it looks like nightly publishes of acapy have failed or skipped for the past week or so: https://github.com/hyperledger/aries-cloudagent-python/actions/workflows/nigthly.yml
last successful run: https://github.com/hyperledger/aries-cloudagent-python/actions/runs/10275685048

runs now: https://github.com/hyperledger/aries-cloudagent-python/actions/runs/10396422027/job/28790543901

(compare the github_token permissions)
For VCX, the fix appeared to be adding explicit permissions to the affected jobs:
    permissions:
      contents: read
      packages: write

Related fix in VCX: https://github.com/hyperledger/aries-vcx/pull/1283

Thanks — this was top of the agenda today.  @jamshale could you take a look?
I had a similar (but perhaps unrelated) experience with another repo that required adding this.

That sounds like the same issue. I had thought the token might have expired, but this would make sense.


606_read_query_data: Implement functions for creating queries dataset

@kabis-ops , thanks for your review and comments. I hope I have addressed all of them.
The lintr warnings should vanish once we have increased the threshold for the cyclomatic complexity. The failing R-CMD check for the latest R version is not related to this PR. It is a general problem we need to fix.

Yes, Thanks for adressing my comments


Documentation search doesn't work

hi sir in your live site documentation section search will stop working
please check it

Thanks for reporting this, @pcodedviral. @XhmikosR, do we need to index something to make this work?

I thought it would work. Something missing on the current implementation.

https://github.com/algolia/docsearch-configs/pull/683

This appears to be happening again...

Works fine here.


Benchmarker releases after 1.0.1 will not reuse available OpenStack Floating IPs

With PerfKit Benchmarker version 1.0.1, OpenStack Floating IPs that had been created but were currently unused were being reused by Benchmarker.  In later releases (1.1.0 and 1.2.0) Benchmarker will never reuse an existing (but currently unused) Floating IP, but will instead always attempt to create a new one.  In my tests, not reusing an existing Floating IP will result in a Benchmarker failure if no more Floating IPs can be created.
I believe I know what the problem is.  In the Bencharker version 1.0.1 code in providers/openstack/os_network.py, it looks for available existing Floating IPs with:
            floating_ips = self.__nclient.floating_ips.findall(
                fixed_ip=None,
                pool=self.ip_pool_name
            )

In the later releases, this code was changed to:
            floating_ips = self.__nclient.floating_ips.findall(
                fixed_ip=None,
                pool=self.ip_pool_name,
                status='Down'
            )

The problem is that Benchmarker is using the OpenStack v2.0 API which is documented at http://docs.clouda.ca/api/api-ref-compute-v2-ext.html.  In that API a 'status' value is not returned by the 'List Floating IPs' API call.  As an example, dumping the result of that API call on my OpenStack deployment, I see a result that looks like this (with the ip obscured):
{"floating_ips": [{"instance_id": null, "ip": "x.xx.xx.xxx", "fixed_ip": null, "id": "10efed9c-9881-47b6-aa03-bdbb39b7decc", "pool": "ext_net"}, ...
In the OpenStack v2.1 API which is documented at http://developer.openstack.org/api-ref-compute-v2.1.html, the same API call is not an extension any more, and it is named 'List Floating IP addresses'.  In the v2.1 API there is a 'status' value returned.

@cbhall Thanks for reporting this issue. I believe this should be fixed on master already. We pinned the version to v2.1 due to similar issues. See https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/829
Try the master branch with the latest commit, if it's still not working I'll take a look. Thanks!

+Carlos +Mateusz
On Mon, Feb 29, 2016 at 2:30 PM, Brian Hall<EMAIL_ADDRESS>wrote:

With PerfKit Benchmarker version 1.0.1, OpenStack Floating IPs that had
been created but were currently unused were being reused by Benchmarker. In
later releases (1.1.0 and 1.2.0) Benchmarker will never reuse an existing
(but currently unused) Floating IP, but will instead always attempt to
create a new one. In my tests, not reusing an existing Floating IP will
result in a Benchmarker failure if no more Floating IPs can be created.
I believe I know what the problem is. In the Bencharker versions 1.0.1
code in providers/openstack/os_network.py, it looks for available existing
Floating IPs with:
floating_ips = self.__nclient.floating_ips.findall(
fixed_ip=None,
pool=self.ip_pool_name
)
In the later releases, this code was changed to:
floating_ips = self.__nclient.floating_ips.findall(
fixed_ip=None,
pool=self.ip_pool_name,
status='Down'
)
The problem is that Benchmarker is using the OpenStack v2.0 API which is
documented at http://docs.clouda.ca/api/api-ref-compute-v2-ext.html. In
that API a 'status' value is not returned by the 'List Floating IPs' API
call. As an example, dumping the result of that API call on my OpenStack
deployment, I see a result that looks like this (with the ip obscured):
{"floating_ips": [{"instance_id": null, "ip": "x.xx.xx.xxx", "fixed_ip":
null, "id": "10efed9c-9881-47b6-aa03-bdbb39b7decc", "pool": "ext_net"}, ...
In the OpenStack v2.1 API which is documented at
http://developer.openstack.org/api-ref-compute-v2.1.html, the same API
call is not an extension any more, and it is named 'List Floating IP
addresses'. In the v2.1 API there is a 'status' value returned.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/issues/854.

--
Anthony F. Voellm (aka Tony)
Google Voice:<PHONE_NUMBER>
https://www.google.com/voice/b/0?pli=1#phones
Blog: http://perfguy.blogspot.com/
Benchmark like a pro... PerfKitBenchmarker
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker

@cbhall Also I forgot to add, make sure you run pip install -r requirements-openstack.txt so it pulls that version of python-novaclient.

I picked up the latest commit of the master branch, and I updated the Python packages to python-keystoneclient==2.1.1 and python-novaclient==2.35.0.  However, I still see the same problem.  Unfortunately, my OpenStack only supports the Nova v2.0 API:
nova version-list
+------+-----------+----------------------+-------------+---------+
| Id   | Status    | Updated              | Min Version | Version |
+------+-----------+----------------------+-------------+---------+
| v2.0 | SUPPORTED | 2011-01-21T11:33:21Z |             |         |
+------+-----------+----------------------+-------------+---------+
As such, my understanding is that PerfKit is still using the Nova v2.0 API and getting a response back conforming to that version of the API (and thus will never see/match a 'status' value in the result).

@cbhall I see. The reason we added the filter for status='Down' is that without it will try to re-use floating IPs that have been associated with an instance already and cause an error.
One solution to support both API version is to filter for those floating IPs that have a "instance_id": null instead of using status.

@meteorfox Sure, that sounds like a good alternative.

I was able to replicate this bug in my environment as well. I posted #862 to address the issue.

This fix is working just fine for me.  In addition, the new code is correctly deleting the floating IP after use, another issue I had noted in past.

Ready for review and to complete the integration?

Yes, PR #862 which addresses this issue is ready for review.

Closing since #862 has already been merged and has been confirmed to address this issue.
Please feel free to re-open if the issue is still present.


JavaScript

JavaScript
USER STORY
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
ACCEPTANCE CRITERIA
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Added JS code in script.js file with functions, for loops and conditional logic


Misc changes

Coverage increased (+0.009%) to 93.65% when pulling 11bf1dc9c0cb25119a84ee83d4bcf7d20044a74d on eatonphil:misc-changes into 65063ce634b72d62b561dabaded3b9f56580bb46 on linode:master.

Coverage decreased (-0.008%) to 93.632% when pulling 6da42384c8485a50a0ad805385ac7340a5b4db97 on eatonphil:misc-changes into 65063ce634b72d62b561dabaded3b9f56580bb46 on linode:master.

Coverage decreased (-0.008%) to 93.632% when pulling 5057d125e534eaccdc49edc40d1afb822b7eec91 on eatonphil:misc-changes into 65063ce634b72d62b561dabaded3b9f56580bb46 on linode:master.

Is that footer look what you are going for?

@na3d The footer as it is is temporary. I think there are more links to add to it and that will guide it's (re)structure. In the meantime, it needed something for the Developer link to stand out against the other things.

Coverage decreased (-0.008%) to 93.632% when pulling 12060a8100e5fcbf96b89e98005852b7f3d14291 on eatonphil:misc-changes into 65063ce634b72d62b561dabaded3b9f56580bb46 on linode:master.

Coverage increased (+0.01%) to 93.632% when pulling 53e18b05590cc4f5d5cf916997b69439801044dc on eatonphil:misc-changes into 657456d7ab2bae4ff41660ddc9e0e5126324a0a6 on linode:master.

Coverage decreased (-0.06%) to 93.56% when pulling 731d940b92e9fe350a9d5e889924eed0714e0bfd on eatonphil:misc-changes into 657456d7ab2bae4ff41660ddc9e0e5126324a0a6 on linode:master.

Coverage increased (+0.01%) to 93.632% when pulling 088d8e91a6462d9270fec3abded48abdfc434ce3 on eatonphil:misc-changes into 657456d7ab2bae4ff41660ddc9e0e5126324a0a6 on linode:master.

Coverage increased (+0.01%) to 93.632% when pulling 088d8e91a6462d9270fec3abded48abdfc434ce3 on eatonphil:misc-changes into 657456d7ab2bae4ff41660ddc9e0e5126324a0a6 on linode:master.

Realized I was being silly so I dropped the footer Developers link and put it back into the header as it used to be. But now the developer link in the header sends you to login/developer instead of developers.linode.com. This may certainly change in the future in light of the discussion in this thread.

Coverage increased (+0.02%) to 93.642% when pulling a7d4cbc02981a88742c354801d999cf95ba55c2b on eatonphil:misc-changes into 657456d7ab2bae4ff41660ddc9e0e5126324a0a6 on linode:master.

Coverage increased (+0.02%) to 93.642% when pulling 447fe194b31c43aa4e61e8ff379715abeabb8d36 on eatonphil:misc-changes into df82bf42d2db8f6e8ebb97f49e2d63facac124e4 on linode:master.

Thanks!


Context as a Field in HeaderSyncService and BlockSyncService

Finding 003 - Context as a Field in HeaderSyncService and BlockSyncService

ID
003

Finding
Context as a Field in HeaderSyncService and BlockSyncService

Severity
2 - Informational

Description
Both the HeaderSyncService and BlockSyncService types have a Context field as part of the type. Many methods on these types accept a Context argument from the caller, which is ideal. Not only does this make the internal Context field unnecessary, it’s also an indication of a codesmell and should be removed.

Recommendation
As most of the methods already accept Context as an argument, remove the Context field from both HeaderSyncService and BlockSyncService. For methods that do not accept a Context, update them to accept a Context from the caller in order to manage lifecycle events properly, e.g. Start.

Code References
https://github.com/rollkit/rollkit/blob/eccdd0f1793a5ac532011ef4d896de9e0d8bcb9d/block/header_sync.go#L44https://github.com/rollkit/rollkit/blob/eccdd0f1793a5ac532011ef4d896de9e0d8bcb9d/block/block_sync.go#L43

Need to make the change in https://github.com/celestiaorg/go-header/ since HeaderSyncService and BlockSyncService implement the go-header interface.

@Manav-Aggarwal Is this an issue that we can propose to the go-header project?
It'll be an interesting issue to tackle across repositories

HeaderSyncService and BlockSyncService implement the go-header interface.

These services do not implement any of the interfaces defined in go-header. Furthermore, interfaces can't enforce storing a ctx field on the struct, so I don't think this is related to go-header anyhow.


Multiple UI Issues in Publisher Portal when using Firefox in Ubuntu

Description

Steps to Reproduce

Login to Publisher UI (Make sure you don't have any APIs deployed in the corresponding tenant).

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
Ubuntu: 22.04.4 LTS
Browser: Mozilla Firefox 123.0
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

In Firefox the issue is not reproducing.
Ubuntu: 20.04 LTS
Browser: Mozilla Firefox 123.0
Getting the same issue in chrome when the zooming value is 200%. Working on fixing that issue.


Divide streaming into client/server/bidi

The motivation behind this change is that currently user need to decide
the streaming type by themselves based on the server implementation. We should
only provide one streaming type in the client for better user
experience.
Corresponding GAX PR: https://github.com/googleapis/gax-java/pull/350

Codecov Report

Merging #1479 into master will decrease coverage by <.01%.
The diff coverage is 86.56%.

@@             Coverage Diff              @@
##             master    #1479      +/-   ##
============================================
- Coverage        87%   86.99%   -0.01%
- Complexity     4061     4085      +24
============================================
  Files           391      391
  Lines         16379    16429      +50
  Branches       1787     1794       +7
============================================
+ Hits          14250    14293      +43
- Misses         1661     1665       +4
- Partials        468      471       +3

Impacted Files
Coverage Δ
Complexity Δ

...pi/codegen/viewmodel/CallableMethodDetailView.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...ansformer/csharp/CSharpGapicClientTransformer.java
98.78% <100%> (-0.01%)
37 <0> (-1)

...oogle/api/codegen/config/GapicInterfaceConfig.java
73.96% <100%> (+0.79%)
53 <4> (+4)
:arrow_up:

...api/codegen/transformer/java/JavaSurfaceNamer.java
87.65% <100%> (+0.98%)
44 <0> (+6)
:arrow_up:

...oogle/api/codegen/viewmodel/ServiceMethodType.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

...en/transformer/StaticLangApiMethodTransformer.java
95.73% <100%> (+0.08%)
75 <0> (+3)
:arrow_up:

...pi/codegen/transformer/ApiCallableTransformer.java
96.77% <100%> (+0.01%)
27 <0> (ø)
:arrow_down:

...nsformer/java/JavaGapicSurfaceTestTransformer.java
98.26% <55.55%> (-1.74%)
31 <0> (+1)

...gle/api/codegen/viewmodel/ApiCallableImplType.java
88.88% <75%> (-11.12%)
6 <3> (+3)

.../transformer/java/JavaGapicSurfaceTransformer.java
97.98% <81.25%> (-0.57%)
65 <0> (+4)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d78b27...5303e2a. Read the comment docs.


Can we get a "title" attribute on a cluster to show on hover?

The cluster marker shows the number of markers it represents, and we can get a polygon to display the coverage area on hover, but could we also get a "title" attribute on the cluster that appears on hover, like on normal markers?

https://github.com/Leaflet/Leaflet.markercluster#customising-the-clustered-markers
Default implementation:
https://github.com/Leaflet/Leaflet.markercluster/blob/master/src/MarkerClusterGroup.js#L760


Fatal error on fetch()

Is there any easy fix to this?
Fatal error: Call to a member function fetch() on string in /Users/kyle/Sites/koma/vendor/cmfcmf/openweathermap-php-api/Cmfcmf/OpenWeatherMap.php on line 551

Hi @KyleGoslan,
could you please give more details? Which version / tag do you use? How does your code look like?

Oh wait, I see. You are probably having the same issue as described here: https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/issues/69

Yeah, thats the one! Was following the master readme and convinced I was going mental. Just went through the class and worked it out.
Might be useful to note that somewhere obvious :)

I have now released version 2.1.0 which means you can now follow the master README and pass the API key as first parameter. :smile:
Sorry for the inconvenience though :confused:

Not at all, great looking api, appreciate the work!  :)
On 12 Apr 2016, at 18:39, Christian Flach<EMAIL_ADDRESS>wrote:

I have now released version 2.1.0 which means you can now follow the master README and pass the API key as first parameter.
Sorry for the inconvenience though
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub


The buttons on/off on the landing page and format of date

Describe the bug
1.The on/off button on the home page is not placed correctly
2. The date format is not correct.
@QAZIMAAZARSHAD Please assign this to me under LGM-SOC

Both issues are already open #109, #111.
Before opening any issue make sure that no other similar issue is open.


Please bump peer dependencies in your lib ngx-pass-code to v17

Hi @dineeek
I hope you're doing well! I'm using your library, ngx-pass-code, in my Angular side project, and I noticed that the peer dependencies for @angular/common and @angular/core haven't been updated to version 17.3.10 in the latest release.
Here's the link for reference:
https://github.com/dineeek/ngx-libs-workspace/blob/main/libs/ngx-pass-code/package.json
Would it be possible for you to bump these versions and publish a new version (1.1.3) when you get a chance? Thank you so much in advance!

Hello @bobbhy,
thanks for using this library. I did some migrations on repo but left a publishing to do it later. Thanks for reminder :)
New version has been published<EMAIL_ADDRESS>Thanks again!


Rename Razor.Evolution

We need to come up with an ahem professional-sounding name for Microsoft.AspNetCore.Razor.Evolution.
Suggestions from the previous discussion thread:
Microsoft.AspNetCore.Razor.Engine
Microsoft.AspNetCore.Razor.Parser
My cool suggestions:
Microsoft.AspNetCore.Razor.Compiler
Microsoft.AspNetCore.Razor.Language
I'm hoping to still park most of the important types in the Microsoft.AspNetCore.Razor namespace.

/cc @DamianEdwards

This deserves every label we can throw at it.

We decided on Microsoft.AspNetCore.Razor.Language

https://github.com/aspnet/Razor/commit/0618bae3bd856eeb31f2c7b40a7be56076b63183
https://github.com/aspnet/Mvc/commit/36e272fdc2486342c341746600615213d2d7fd2f
https://github.com/aspnet/MvcPrecompilation/commit/885792e16ba6f51bd9f9f61aedbbee70a451469c
https://github.com/aspnet/Scaffolding/commit/b2bc822b219e1f246cb182e9a2a15944b385e978
https://github.com/aspnet/Coherence/commit/f6431072b283f51bb531cfd0725f407d021a5793


Batch requests for paginated data

Hi,
Is there any way to have the table fetch data for each page as it displays? We have a data consisting of thousands of items and we would rather get them 10 or so at a time (configurable with the items-per-page dropdown). Ideally we could also send through any values in the column filters with the request
Many thanks

Sorry for lately reply, busy on this month, try to use remote mode, check https://github.com/AllenFang/react-bootstrap-table/blob/master/examples/js/remote/remote-store-paging.js and https://github.com/AllenFang/react-bootstrap-table/blob/master/examples/js/remote/remote-paging.js
here is all related with the remote functionality, let me know if you got any questions

Awesome, that's exactly what we're looking for. Thanks!


Allow dev to choose navbar color light/dark (class)

With the current state,
Navbar color is hard coded (navbar-light):
https://github.com/kevinpapst/TablerBundle/blob/e5a0366914b4682d734c89b0e62600612b7b1bbe/templates/layout.html.twig#L25
https://github.com/kevinpapst/TablerBundle/blob/e5a0366914b4682d734c89b0e62600612b7b1bbe/templates/layout.html.twig#L65
We need to allow dev to choose between navbar dark or light.
⚠ Changes must be done with layer vertical and horizontal ⚠
SEE https://github.com/kevinpapst/TablerBundle/pull/3

And in line https://github.com/kevinpapst/TablerBundle/blob/e5a0366914b4682d734c89b0e62600612b7b1bbe/templates/layout.html.twig#L65
When I set 'body class="theme-dark"then the navbar is dark, even if it has the classnavbar-light`.

theme-dark override every -light class configuration.
For me it is a normal behavior, do you see something wrong with that ?
What I want to do is:
Horizontal :

Dark: https://preview.tabler.io/layout-navbar-dark.html?theme=light
Light: https://preview.tabler.io/layout-horizontal.html?theme=light

Vertical:

Dark: https://preview.tabler.io/layout-vertical.html?theme=light
Light: https://preview.tabler.io/layout-vertical-transparent.html?theme=light

Vertical condensed:

Light: https://preview.tabler.io/layout-combo.html?theme=light
Dark: No demo from Tabler


Cleanup Transactions and Outputs Dialogs

Brent has made several suggestions for improvements which can be made to the Transactions and Outputs Dialogs. See the first item in his google doc at: https://docs.google.com/document/d/1p12FnhtsjQpOuHcYnmDVWwOceT5K-j1nre68hZz8tjU/edit#heading=h.1tefyviwglrn
The main issue is that fields which are read-only should not have outlines around them or change when the mouse hovers, or clicks on them.
I have also noticed a couple of other issues in these dialogs.

All fields can be tabbed through.
Transaction Kernel View button has a copy and paste error and refers to outputs instead of kernel.
In the Transactions Dialog, the Type field cuts off types which have been cancelled because the field isn't large enough.
In the Transactions Dialog, the tool tip for the Inputs/Outputs combo box refers to accounts. (Copy and paste error.)

Fixed:
I have verified the padding (although it is hard to tell), and the transactions screen.
Problems?:
The "All" button functionality on the send tab has not been updated according to the document, is that on purpose?
The air drop button has not been moved to the bottom of the tabs as suggested.
Not sure:
I can't tell if the small buttons have been updated according to the documents, but it doesn't look like it has.
I'm not sure what the explorer bar looked like before, it seems to match the picture from the design doc now.


Custom JSQMessagesLoadEarlierHeaderView crash

I needed a custom "load earlier" button (really custom) so I implemented a custom nib and the following method:
override func collectionView(collectionView: UICollectionView, viewForSupplementaryElementOfKind kind: String, atIndexPath indexPath: NSIndexPath) -> UICollectionReusableView {

        if (self.showLoadEarlierMessagesHeader && kind == UICollectionElementKindSectionHeader) {
            let headerView = self.collectionView.dequeueReusableSupplementaryViewOfKind(UICollectionElementKindSectionHeader, withReuseIdentifier: kLoadMoreHeaderReuseIdentifier, forIndexPath: indexPath) as! ACLoadMoreMessagesHeaderView
            headerView.setLoading(loadingEarlier)
            headerView.onTap = {
                [unowned self]
                (hv: ACLoadMoreMessagesHeaderView) in
                if !self.loadingEarlier {
                    self.loadMoreHeader = hv
                    self.loadingEarlier = true
                    hv.setLoading(self.loadingEarlier)
                    self.loadMoreMessages(true, updateFromServer: true)
                }
            }

            return headerView
        }

        return super.collectionView(collectionView, viewForSupplementaryElementOfKind: kind, atIndexPath: indexPath)
    }

The thing is, every now and then while scrolling the collection view I get a crash. It's actually quite easy to reproduce.
*** Assertion failure in -[UICollectionViewData validateLayoutInRect:], /SourceCache/UIKit/UIKit-3318.16.14/UICollectionViewData.m:426
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'layout attributes for supplementary item at index path (<NSIndexPath: 0x170fbc40> {length = 2, path = 0 - 0}) changed from <JSQMessagesCollectionViewLayoutAttributes: 0x1707ac80> index path: (<NSIndexPath: 0x17234790> {length = 2, path = 0 - 0}); element kind: (UICollectionElementKindSectionHeader); frame = (0 0; 320 120);  to <JSQMessagesCollectionViewLayoutAttributes: 0x1722d9d0> index path: (<NSIndexPath: 0x170fbc40> {length = 2, path = 0 - 0}); element kind: (UICollectionElementKindSectionHeader); frame = (0 0; 320 120); zIndex = -1;  without invalidating the layout'
Any ideas why this may happen? I see where zIndex is set to -1 in the code, I just don't understand why is it different (no zIndex in the first case)

Thanks @mrojas ! Please update the issues after reading the updated contribution guidelines! :smile:

@mrojas I recently had to develop a custom nib also. I subclassed JSQMessagesLoadEarlierHeaderView because at some point I (think) I saw that the library was expecting a custom view of type that type. After that, you have to let the collection view know about your nib in viewDidLoad()
[self.collectionView registerNib:[CustomHeaderView nib]
      forSupplementaryViewOfKind: UICollectionElementKindSectionHeader
             withReuseIdentifier:[CustomHeaderView headerReuseIdentifier]];

If you decide to subclass, don't forget to override headerReuseIdentifier
Then in your JSQMessagesViewController subclass, in the function override notice that I don't call super
-(UICollectionReusableView *)collectionView:(UICollectionView *)collectionView viewForSupplementaryElementOfKind:(NSString *)kind atIndexPath:(NSIndexPath *)indexPath{
  UICollectionReusableView *header = [collectionView dequeueReusableSupplementaryViewOfKind:kind withReuseIdentifier:[CustomHeaderView headerReuseIdentifier] forIndexPath:indexPath];
        ((CustomHeaderView *)header).customDelegate = self;
  return header;
}

In my case, I needed two different headers, the one provided by the library and my custom one, I had to keep track of the header reuse identifier and when to use which (so I had an if clause in that last function). If you need to use the one given by the library, then you must call super with the same parameters of the function header = [super collectionView:collectionView viewForSupplementaryElementOfKind:kind atIndexPath:indexPath];
Hope this helps

thanks @GianniCarlo !


Update matplotlibcpp.h

fixed the label when plotting. plt::plot(time_array, n1_I_s, ":",{{"label", "N1"}});

Reference manual here

I'm sorry but this PR is too big, with a +1500/-1800 lines diff I can't see what you're actually changing :/
That said, the manual looks quite pretty, how was it generated?

Hi @lava ,
The matplotlibcpp.h is the latest version available in here and so is the reference manual (generated with doxygen) and available here

I can also provide examples using the dictionary plt::plot(time_array, n1_I_s, ":",{{"label", "N1"}}); if you want.


✨ Make SophieBot work in France office

Cc: @jimmidier @adamcogan @ozdemir-mehmet @kikibianc @chrisschultzssw

Hi Team,
Pain

The France office is setting up the UniFi controller. To make the query "Who is in the France office now" work.
SophieBot needs the following information:

UniFi API endpoint for France
An account for SophieBot (username and password)

### Tasks
- [ ] ~Get required info from SysAdmins~
- [ ] Implement

Acceptance Criteria

[ ] Query works - "Who is in the France office now"

Thanks!

SophieBot doesn't support "who is in France now" because we only support sites in the UniFi.

Figure: Sites in UniFi


Can't see active debugging line - and can't find adjustment in syntax coloring

From<EMAIL_ADDRESS>on 2013-08-23T15:27:38Z
Spyder Version:  2.3.0dev6
Python Version:  3.3.2
Qt Version    :  4.8.4, PyQt4 (API v2) 4.9.6 on Windows
pyflakes 0.4.2  :  None (OK)
pep8 >=0.6      :  None (NOK)
IPython >=1.0   :  1.0.0 (OK)
rope >=0.9.2    :  0.9.4 (OK)
sphinx >=0.6.6  :  1.1.3 (OK)
matplotlib >=1.0:  1.3.0 (OK)
sympy >=0.7.0   :  0.7.3 (OK)
pylint >=0.25   :  0.28.0 (OK)
What steps will reproduce the problem?
1.Enter debugging mode
More like a feature request than a bug ;')
I can't find an adjustment for the active debugging line color in Syntax Coloring. I have old eyes and I have trouble seeing where I am in the stepthrough, especially if I go into a complex standard module.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1532

From<EMAIL_ADDRESS>on 2013-08-23T16:32:46Z
Oops, my mistake. I was looking at Custom for syntax coloring, rather than Spyder, which wasn't visible until I scrolled. Current line is now a hot pink. Great program. Thanks ;')

From pierre.raybaut on 2013-08-24T00:25:33Z
Status: Done


The 'kotlin-android-extensions' Gradle plugin is deprecated. Please use this migration guide (https://goo.gle/kotlin-android-extensions-deprecation) to start working with View Binding (https://developer.android.com/topic/libraries/view-binding) and the 'kotlin-parcelize' plugin.

I followed the ViewBindingSample but after inserting the line:

apply plugin: 'kotlin-android-extensions'

in the file build.gradle the sync says:

The 'kotlin-android-extensions' Gradle plugin is deprecated.
Please use this migration guide (https://goo.gle/kotlin-android-extensions-deprecation) to start working with View Binding (https://developer.android.com/topic/libraries/view-binding) and the 'kotlin-parcelize' plugin.

So either the warning or the sample is wrong and needs to be updated.

This error message is correct. The kotlin-android-extensions plugin is deprecated and will be removed, and you don't need to add it to use ViewBinding.


Refactor to enable in-source configuration

This patch adds suckless-style configuration to paleofetch, enabling the user to decide which aspects of their system are displayed.
The "config file" is just an array of structs whose components are a label and a function to be called to get the value for that label. It currently lives in main(), but this could be extracted to a header
file if deemed more appropriate.
In addition, the data is vertically centered to account for the user having fewer configured labels than there are lines in the logo. This "fails" in the event that the user has more labels than logo lines, but that would at present require having duplicates, which is really more a case of operator error.

Awesome! This is great for when other operating systems than Arch Linux will be added.

Oh wow I'm sorry I just saw this, since I just made a commit which would require a big rewrite of this. This is really good though, and pretty much exactly what I was imagining configuration for this project would look like.

Sorry about that. Accidentally pushed a different pull request to this one.

Should I close this request then? I saw the changes you made to get_terminal and I really like them. Since XOpenDisplay is now being called in get_terminal and get_resolution, I think you should move the display to be a global alongside uname_info and my_sysinfo, that way we only have to open and close (and do error checking) once.


Use flex positioning for SearchBar accessories to fix SSR glitches

Not sure why I originally implemented this using absolute positioning, honestly...
The current implementation causes weird glitches in SSR applications, because the dimension of accessory is not known on the server.

Using normal flex positioning removes the problem and is also way less less convoluted

Merging without a review since it seems trivial enough and I want to test it in an actual project


[release-1.12] Post-release actions checklist

[x] (final + patch release) Open a PR to cert-manager/website for master (final release) or release-next (patch release).
Then, generate release-notes.md (see release process) and for each release note entry, open the PR associated and edit the release-note block. The goal for each release note entry is to have from 1 to 3 sentences in proper english in which we explain how the end-user will be affected by this change. Here is an example of such edit:
Before:
```release-note
Adds missing comparisons for certain fields which were incorrectly skipped if a LiteralSubject was set
```

After:
```release-note
When using the `literalSubject` on a Certificate, the IPs, URIs, DNSNames, and EmailAddresses segments are now properly compared.
```

[x] Re-generate the file release-notes.md with the edited release notes, and write the section "Major themes" and "Community" by taking example on the previous release note pages.

[x] Open a PR to cert-manager/website for master (final release) or release-next (patch release). In that PR:

[x] (final release) Update the section "Supported releases" in the supported-releases page.

[x] (final release) Update the section "How we determine supported Kubernetes versions" on the supported-releases page.

[x] (final release) Bump the version that appears in scripts/gendocs/generate-new-import-path-docs. For example:
-LATEST_VERSION="v1.11-docs"
+LATEST_VERSION="v1.12-docs"

-genversionwithcli "release-1.11" "$LATEST_VERSION"
+genversionwithcli "release-1.12" "$LATEST_VERSION"

[x] (final + patch release) Bump all versions present in installation instructions. To find these versions:
find ./content/docs/installation -name '*.md' -not -path '*/upgrad**' -exec sed -i.bak 's/1.11../1.12.0/g' '{}' \;
rm -f **/*.bak

To check that all mentions of that versions are gone, run:
grep -R -n -F 'v1.11.' content/docs/installation

[x] (final release only) Freeze the docs/ folder by creating a copy and remove folders that aren't versionned:
cp -r content/docs content/v1.12-docs
rm -rf content/v1.12-docs/{installation/supported-releases,installation/upgrading,release-notes}

[x] (final + patch releases) Update the API docs and CLI docs:
# From the website repository, on the master branch.
./scripts/gendocs/generate

/close


Nspkg to sdk folder

(message created by the CI based on PR content)

Codecov Report

Merging #5202 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5202      +/-   ##
==========================================
- Coverage   48.69%   48.65%   -0.04%
==========================================
  Files        6536     6528       -8
  Lines      184777   184548     -229
==========================================
- Hits        89977    89794     -183
+ Misses      94800    94754      -46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c9458...3b698e1. Read the comment docs.

@scbedd I think you postpone the full problem actually, every packages can be in two spots, and every of them should be installable from the "sdk" folder. Being the installation could be:
pip install -e mypackage
or
pip install -e sdk/myservice/mypackage
The approach I would do would then not consider "azure-common" or anything as specific packages, but have a global strategy.
What I have done here:
https://github.com/Azure/azure-sdk-for-python/blob/27bed2b6296f95e219cef89f46f1238ce3c6cf48/azure-sdk-tools/packaging_tools/drop_tools.py#L55-L58
is using a regexp to keep a tuple (base_path, package_name). This tuple could be:
("." , mypackage)
or
("./sdk/myservice/, my package)
and then the installation code is simply:
pip install -e base_path/mypackage

Hi, @lmazuel
I just tried to build the sdk (using ./setup.py), but it fails with ValueError: list.remove(x): x not in list on https://github.com/Azure/azure-sdk-for-python/blob/f24fb53e547645809cf1f36c9688ae464cd232ec/setup.py#L32, presumably due to 25a80a9. Can you confirm that this is indeed an / the issue?

Hi @badeball
That's a little more subtle, declared here:
https://github.com/Azure/azure-sdk-for-python/issues/5291
Thanks

@badeball PR #5449 this should fix the problem.

Ah, I tried to look over most recent issues, but apparently didn't see that one. Thanks for looking into this!


Make active edits transactional

classes should be (to match our conventions)

ActiveEditRepository (no interface suffix)
MySQLActiveEditRepository
InMemoryActiveEditRepository (instead of cache since cache is not an implementation)

methods should be more precise (element can be confused with cf element for example).  ref or id would be more clear.
method setMetaUpdate is not entirely clear what that means.  maybe something less node specific as in updatedField or touched or updatedPropery.  also "setBlah" gets picked up by cf DI so there's sometimes a risk of that being injected with something unintentionally.

@oefada can youdo some code  review and testing.. thanks.

@gdbrown , lets review.

@oefada to prevent "owner" (original viewer) from seeing other users popup, you can add a small function to override the b_saveandcontinue click to pass a flag that will ignore the popup if other users where found

$('form#someForm').submit(function() {
  $(window).unbind('unload');

  //@todo pass hidden variable with form
});


refactor: Move transcripts.

As a a first step toward breaking up the barretenberg/honk submodule, which is gotten very large, I move the Honk transcript out of Honk. This will enable moving ZeroMorph and other hings in barretenberg/honk/pcs out of honk. it is now in barretenberg/transcript. Formerly barretenberg/transcript was the Plonk transcript. This goes into barretenberg/plonk.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit db67aa1e and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,912
867,416
3,449,408

l1_rollup_execution_gas
841,999
3,594,524
22,204,777

l2_block_processing_time_in_ms
1,952 (-3%)
7,490 (-1%)
29,635 (-1%)

note_successful_decrypting_time_in_ms
292 (+1%)
854
3,117 (-3%)

note_trial_decrypting_time_in_ms
93.0
62.0 (+2%)
135 (-1%)

l2_block_building_time_in_ms
13,098 (-1%)
52,040
208,291

l2_block_rollup_simulation_time_in_ms
11,781 (-1%)
46,808
187,319

l2_block_public_tx_process_time_in_ms
1,275
5,099
20,487

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
21,642
42,454 (+1%)

note_history_successful_decrypting_time_in_ms
2,014 (-1%)
3,991

note_history_trial_decrypting_time_in_ms
119 (-2%)
143 (-23%)

node_database_size_in_bytes
1,632,706
1,100,573

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
72.3
61,697
18,841

private-kernel-ordering
43.5
24,233
8,089

base-rollup
1,770
656,309
811

root-rollup
79.5 (+2%)
4,072
1,097

private-kernel-inner
53.4
81,504
18,841

public-kernel-private-input
41.4
41,455
18,841

public-kernel-non-first-iteration
26.4
41,497
18,841

merge-rollup
0.920 (+2%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,723
27,240


Build failed  : Command failed: dotnet build  projectname.csproj

Describe the bug
Not able to build the bot in the composer
Version
Version:  1.4.0-nightly.237101.f01cb52
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Open the Bot project (ex: Trigger)
Update new Bot composer version (Enable auto-restart option)
Open the Bot project (ex: Trigger)

Build the project …. The build has failed due to (Ref screenshots) reason
Just noticed while closing the Bot composer  (ex: Trigger.exe is running in the background) ….
And one more observation only one time I faced the same problem working with Visual Studio (custom action project) If I stop the bot using the “Local bot runtime manager” its stopped but the application is running in the background .
Expected behavior
Background process should be closed
Note : After killed background exe ... Build is working fine. 👍
Screenshots

Additional context

May be the same problem in  #7054

Seems to be a duplicate of #7054 but will keep open until we validate that assumption

This is a duplicate and the original issue has been resolved


fix memory leak issue in reource loader

shoule release texels before destory or reload
To Reproduce

start android sample-gltf-viewer
keep on double tabing the activity to reload the model
monitor the memory useage

Search this file for PixelBufferDescriptor and note that the texels pointer should be freed when the PixelBufferDescriptor callback is triggered.  If you're seeing a leak, can you determine why the PixelBufferDescriptor callback isn't being triggered?

A quick inspection of the code doesn't explain how the callback could not be called after setImage has been called. So we need to investigate this more.

okay more details about this -- the leak happens only when triggering a reload (double-tap) while a reload is already happening.  My guess is that there is a code path where malloc() is called and setImage is not.

It is because com.google.android.filament.utils.ModelViewer load the resource use asyncBeginLoad, it will not call  uploadPendingTextures in createTextures.
After ModelViewer call asyncUpdateLoad in render(), it will send image to gpu and set callback free the memory

please reivew https://github.com/google/filament/pull/3063/commits/fa1bbe5c36e428be834f4d3aff71242c2ed4c55b

I am back from vacation and will take a look at this soon.

Thanks for bringing this to our attention!  I have an alternative fix up (#3109) that handles this in addition to a couple other missing cancellation features (e.g. an assert in DependencyGraph, zombie decoder threads)


arch/arm/src/nrf52: add initial interface to work with on-chip radio

I know this PR will not pass nxstyle with warnings like this:
arch/arm/src/nrf52/hardware/nrf52_radio.h:115:68: warning: Wrong column position of comment right of code
arch/arm/src/nrf52/hardware/nrf52_radio.h:116:68: warning: Wrong column position of comment right of code

I'm not sure how to handle these warnings correctly.

I'm not sure how to handle these warnings correctly.

That would require shifting all the other comments to the same column.
I suggest we merge this as is.

@Ouss4 Merging as is, based on your recommendation.


temp file naming convention safe for third-party Sync applications (destination file locked by sync before yt-dlp is finished processing the request)

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Reporting an issue regarding the current temp filename handling:
issue:
error on download
symptom:
it appears some file sync software (icloud, onedrive, etc.) could lock an incomplete temporary instance of a file with the desired filename before yt-dlp can release after fully processing it.
handling ideas:
perhaps some level of step determination based on the combination of parameter/options being passed in as argument (or as determined necessary for each processed iteration of a batch).
or perhaps a filename function to handle some blanket tmp filename increment_append convention where the desired filename is set at request and written as the last remaining step in the operation.
(not sure if some degree of sleep and retry for failed steps of an operation could help, rotating off .temp. file and writing out to desired.)
example:
general output sample below:
`
PS C:\Users\myuser\iCloudDrive\Files> yt-dlp.exe -vU -f 140 --embed-thumbnail --add-metadata -i https://youtu.be/zvideo789nY
[debug] Command-line config: ['-vU', '-f', '140', '--embed-thumbnail', '--add-metadata', '-i', 'https://youtu.be/zvideo789nY']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [615a84447] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 6.1.1-full_build-www.gyan.dev (setts), ffprobe 6.1.1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1803 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[youtube] Extracting URL: https://youtu.be/zvideo789nY
[youtube] zvideo789nY: Downloading webpage
[youtube] zvideo789nY: Downloading ios player API JSON
[youtube] zvideo789nY: Downloading android player API JSON
[youtube] zvideo789nY: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[info] zvideo789nY: Downloading 1 format(s): 140
[info] Downloading video thumbnail 46 ...
[info] Writing video thumbnail 46 to: myExampleVideo (CC) [zvideo789nY].webp
[debug] Invoking http downloader on "https://redacted"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: myExampleVideo (CC) [zvideo789nY].m4a
[download] 100% of   28.89MiB in 00:00:01 at 16.73MiB/s
[FixupM4a] Correcting container of "myExampleVideo (CC) [zvideo789nY].m4a"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:myExampleVideo (CC) [zvideo789nY].m4a" -map 0 -dn -ignore_unknown -c copy -f mp4 -movflags "+faststart" "file:myExampleVideo (CC) [zvideo789nY].temp.m4a"
[Metadata] Adding metadata to "myExampleVideo (CC) [zvideo789nY].m4a"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:myExampleVideo (CC) [zvideo789nY].m4a" -map 0 -dn -ignore_unknown -vn -acodec copy -write_id3v1 1 -metadata "title=myExampleVideo (CC)" -metadata "date=20220404" -metadata "purl=https://www.youtube.com/watch?v=zvideo789nY" -metadata "comment=https://www.youtube.com/watch?v=zvideo789nY" -metadata "artist=medium artist name" "-metadata:s:0" "language=eng" -movflags "+faststart" "file:myExampleVideo (CC) [zvideo789nY].temp.m4a"
ERROR: [WinError 32] The process cannot access the file because it is being used by another process: 'myExampleVideo (CC) [zvideo789nY].temp.m4a' -> 'myExampleVideo (CC) [zvideo789nY].m4a'
Traceback (most recent call last):
File "yt_dlp\YoutubeDL.py", line 1594, in wrapper
File "yt_dlp\YoutubeDL.py", line 1750, in __extract_info
File "yt_dlp\YoutubeDL.py", line 1809, in process_ie_result
File "yt_dlp\YoutubeDL.py", line 2968, in process_video_result
File "yt_dlp\YoutubeDL.py", line 3512, in process_info
File "yt_dlp\YoutubeDL.py", line 3694, in post_process
File "yt_dlp\YoutubeDL.py", line 3676, in run_all_pps
File "yt_dlp\YoutubeDL.py", line 3654, in run_pp
File "yt_dlp\postprocessor\common.py", line 23, in run
File "yt_dlp\postprocessor\common.py", line 128, in wrapper
File "yt_dlp\postprocessor\ffmpeg.py", line 715, in run
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'myExampleVideo (CC) [zvideo789nY].temp.m4a' -> 'myExampleVideo (CC) [zvideo789nY].m4a'
PS C:\Users\myuser\iCloudDrive\Files> ls
Directory: C:\Users\myuser\iCloudDrive\Files

Mode                 LastWriteTime         Length Name

la---          10/08/2023  1:13 AM       30269747 myExampleVideo (CC) [zvideo789nY].m4a
la---          14/03/2024  1:15 AM       30269923 myExampleVideo (CC) [zvideo789nY].temp.m4a
la---          14/03/2024  1:15 AM          23154 myExampleVideo (CC) [zvideo789nY].webp
PS C:\Users\myuser\iCloudDrive\Files>`
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
PS C:\Users\myuser\iCloudDrive\Files> yt-dlp.exe -vU -f 140 --embed-thumbnail --add-metadata -i https://youtu.be/zvideo789nY
[debug] Command-line config: ['-vU', '-f', '140', '--embed-thumbnail', '--add-metadata', '-i', 'https://youtu.be/zvideo789nY']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [615a84447] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 6.1.1-full_build-www.gyan.dev (setts), ffprobe 6.1.1-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1803 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[youtube] Extracting URL: https://youtu.be/zvideo789nY
[youtube] zvideo789nY: Downloading webpage
[youtube] zvideo789nY: Downloading ios player API JSON
[youtube] zvideo789nY: Downloading android player API JSON
[youtube] zvideo789nY: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[info] zvideo789nY: Downloading 1 format(s): 140
[info] Downloading video thumbnail 46 ...
[info] Writing video thumbnail 46 to: myExampleVideo (CC) [zvideo789nY].webp
[debug] Invoking http downloader on "https://redacted"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: myExampleVideo (CC) [zvideo789nY].m4a
[download] 100% of   28.89MiB in 00:00:01 at 16.73MiB/s
[FixupM4a] Correcting container of "myExampleVideo (CC) [zvideo789nY].m4a"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:myExampleVideo (CC) [zvideo789nY].m4a" -map 0 -dn -ignore_unknown -c copy -f mp4 -movflags "+faststart" "file:myExampleVideo (CC) [zvideo789nY].temp.m4a"
[Metadata] Adding metadata to "myExampleVideo (CC) [zvideo789nY].m4a"
[debug] ffmpeg command line: ffmpeg -y -loglevel "repeat+info" -i "file:myExampleVideo (CC) [zvideo789nY].m4a" -map 0 -dn -ignore_unknown -vn -acodec copy -write_id3v1 1 -metadata "title=myExampleVideo (CC)" -metadata "date=20220404" -metadata "purl=https://www.youtube.com/watch?v=zvideo789nY" -metadata "comment=https://www.youtube.com/watch?v=zvideo789nY" -metadata "artist=medium artist name" "-metadata:s:0" "language=eng" -movflags "+faststart" "file:myExampleVideo (CC) [zvideo789nY].temp.m4a"
ERROR: [WinError 32] The process cannot access the file because it is being used by another process: 'myExampleVideo (CC) [zvideo789nY].temp.m4a' -> 'myExampleVideo (CC) [zvideo789nY].m4a'
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1594, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1750, in __extract_info
  File "yt_dlp\YoutubeDL.py", line 1809, in process_ie_result
  File "yt_dlp\YoutubeDL.py", line 2968, in process_video_result
  File "yt_dlp\YoutubeDL.py", line 3512, in process_info
  File "yt_dlp\YoutubeDL.py", line 3694, in post_process
  File "yt_dlp\YoutubeDL.py", line 3676, in run_all_pps
  File "yt_dlp\YoutubeDL.py", line 3654, in run_pp
  File "yt_dlp\postprocessor\common.py", line 23, in run
  File "yt_dlp\postprocessor\common.py", line 128, in wrapper
  File "yt_dlp\postprocessor\ffmpeg.py", line 715, in run
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'myExampleVideo (CC) [zvideo789nY].temp.m4a' -> 'myExampleVideo (CC) [zvideo789nY].m4a'

PS C:\Users\myuser\iCloudDrive\Files> ls

    Directory: C:\Users\myuser\iCloudDrive\Files

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
la---          10/08/2023  1:13 AM       30269747 myExampleVideo (CC) [zvideo789nY].m4a
la---          14/03/2024  1:15 AM       30269923 myExampleVideo (CC) [zvideo789nY].temp.m4a
la---          14/03/2024  1:15 AM          23154 myExampleVideo (CC) [zvideo789nY].webp

PS C:\Users\myuser\iCloudDrive\Files>

Is setting --path temp: insufficient for your usecase?

i appreciate the feedback on that, i'll put it into play 👍


Sudden validate issue

The validate check is failing for some reason. We need to check.

@squakez I will check it.

The source of the failed validate is the commit from this PR : https://github.com/apache/camel-k/pull/4405. What is it about @squakez ?

Ouch... could be. Great catch! I'll revert that commit to see if it brings back to normal condition. Thanks!


dependencies: Pin mbedtls to tagged version v3.1.0

Summary
What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[x] Build-related changes
[ ] Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature
[ ] Related documents have been updated (docs/docs/en)
[ ] Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

[ ] Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Ensures reproducible builds (see f.e. https://github.com/Mbed-TLS/mbedtls/issues/6124)

@tuxuser Would you mind to update dependencies/CMAKELIST too, please?
See https://github.com/hyperion-project/hyperion.ng/commit/6f0ccdbe25a7532f766b613430ef13838d9719c0 for reference.

Done.

Also pinned mbedtls version in dependencies/CMakeLists.txt
Added comment as seen in 6f0ccdb, with the opposite narrative though.

@tuxuser Thank you!


Add etch (setCode) cheatcode

depends on #146

Cherry-picked in https://github.com/gakonst/foundry/commit/46a3370e4890393414970277cf79cfb55cf63c1d


Add activity feed API

#1  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @namor and the rest of your teammates on  Graphite


Add geocoding for LY

Imported from Google Code issue #147 created by cfkoch on 2012-06-16T02:30:30.000Z:

Data does not exist.
Available at http://www.itu.int/oth/T020200007A/en

We've accepted this issue and will fix it in an upcoming release.

Fixed in v8.3.0


Make buildkite dependencies depend on success

This PR fixes an issue where a flake / infra error may lead to a job being triggered, even though its dependencies aren't actually ready. See e.g. this run trigger by the completion of the failed run here.

!ci-build-me

!approved-for-mainnet


Consider using overlay?

Maybe this is something to consider doing in the image?
http://sthbrx.github.io/blog/2015/10/30/docker-just-stop-using-aufs/

I personally still prefer AUFS over overlayFS, but you are free to switch from one to another by editing the /etc/default/docker file and restart docker
We will keep this issue opened, if more people do prefer OverlayFS over AUFS, we can change the default file backend

+1 for overlay

Related to https://github.com/scaleway-community/scaleway-docker/pull/46


Port/strings Typedef

This PR just moves StringType from File to String.
Right now, CharType is set to whcar_t, for a verification build for Linux, one can try to build when it is set to char16_t.
It is not intended to solve the circlular dependency in this PR but we may someday as suggested by @localcc seperate Unreal module into Unreal and UnrealDef.
Once this is sovled, CharType should be set to TCHAR for normal build.
I think it's safe to say TCHAR will be UTF-16 at this point, if we want to support cases that TCHAR can be say... utf8/utf32.. then might need to wrap it with to_string or to_wstring based on platform/env.. or pull back the to_system macro for those cases..
I have not tested this change but cherrypick it from my current working branch as suggest by @narknon to allow this part to be easily reviewed and merged. I think this should be mostly okay but please check if it compiles..
In theory, it should not break anything because I re-exported everything under the RC::File:: namespace.
It is based on the fmt PR although it may not actaully related. It is also possible to merge this before the fmt change.
These is nothing to document at this point, although future code should avoid use File::* for string/char type I think.
Also, please try to avoid the use of wstring unless needed.

This depends on #565

Requires
includes("String")

in deps\first\xmake.lua to build.

Also breaks anything referencing the old File ToString

And requires the Unreal FMT branch to be merged.

got it.. will steal some commits from another PR..

I merged fmt here and on uepseudo so these could be rebased onto main.

I think this should build ... at least on my local.

Both shipping and debug works on DRG with various tool functions, except debug crashes on UHT dump, but it also does in latest main commit, so it is not related to this PR and I will make a seperate issue for that.


Allow devDependencies to cause version bumps on dependent projects via configuration

Problem
Like in #921 we have dev dependencies for frontend code that directly affect our services and requires their release when changed. It should not get a runtime dependency because the module itself and its dependencies are only required at build time for webpack.
We added some prepush hook to make sure the developers do not forget to always add the frontend projects to the changesets in such cases, but it would be much easier if the behavior of changeset in such cases would be configurable per project.
Proposed solution
Allow specifying a list of project names in .changeset/config.json that should still cause version bumps on dependent projects even when being a devDependency.

How would you call this option and what shape would it have?

I don't know how other tools handle this. I would expect something like
{
  "bumpOnDevDependencies: ["@myscope/shared", "@myscope/frontend", "@myscope/react-components"]
}

The changelogs should then also contain these dependency updates and be able to be rewritten via a changelog generator.

@Andarist would you accept a PR for this?
We have a technical reason that we require this too:

Published packages depends on unpublished monorepo packages.
The unpublished packages are bundled (there are a few reasons for this), and are listed as devDependencies.

We have thought about using fixed or linked, but that would require overhead too, and adds a lot of repo noise.

@mrmckeb yes, a PR sounds good. I think that a good start would be adding a top-level option as suggested by @robaca . We could then bikeshed the name and the exact semantics at the code review stage.

Thanks! I've put this PR together as an MVP, with tests:
https://github.com/changesets/changesets/pull/1159

Hi. We would also be very interested in this change.
Do you have an ETA to have the PR reviewed ?
Thanks (special to @mrmckeb for the PR !)

I'm still waiting on feedback on that PR sorry, I'm not a member of this project and can't merge - just a first-time contributor! 🙂

I too need something like this. Scenario:
We generate an importmap that includes CDN paths to all the released artifacts (which is itself published). The importmap is just a json manifest, so obviously it doesn't have a runtime dependency on anything, but I want it to be patch-bumped when any of the referenced pkgs (identified via devDependencies[?]) is rev'd like is being proposed.
I don't love the idea (has potential to create cyclic dependencies) of using the [dev|optional]dependencies member to identify those "is related to, but doesn't really depend on" relationships. I thought maybe there's something in the docs like a hook or a configuration option or something, and I found this issue.

Is there any chance this can be reviewed and merged? We are always limited by #1011 or this. Merging one of those two PR would solve so many problems for us.


Issue new IAM_CLIENT_ID IAM_CLIENT_SECRET

create and use new ones for deployments

this should be solved by the new installer script. Closing and re-opening if not working


DSND-2998: Retry more error types

Refactored exception mapping and logging
Removed unused code from DisqualifiedOfficersDeltaProcessor
Fixed unit tests
Added exclusions to POM to fix CVEs

DSND-2998

CI: No security warnings found