SRIOV [test_id:3956]/[test_id:3957] Flaky due to cloud-init problem

/kind bug
What happened:
Tests are flaky, ping fails.
Please see the error about cloud-init below.
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4616/pull-kubevirt-e2e-kind-1.17-sriov/1334424614062788608
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4620/pull-kubevirt-e2e-kind-1.17-sriov/1334471293780627457
What you expected to happen:
Tests should be stable
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Please see this error during cloud-init
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4616/pull-kubevirt-e2e-kind-1.17-sriov/1334424614062788608#1:build-log.txt%3A7059
09:52:57: [   22.316909] cloud-init[645]: Cloud-init v. 19.4 running 'init-local' at Thu, 03 Dec 2020 09:52:06 +0000. Up 21.02 seconds.
09:52:57: [   22.320722] cloud-init[645]: 2020-12-03 09:52:07,757 - stages.py[WARNING]: Failed to rename devices: [unknown] Error performing rename('eth1', 'sriov-link-enabled') for 02:00:00:79:aa:b1, sriov-link-enabled: Unexpected error while running command.
09:52:57: [   22.326189] cloud-init[645]: Command: ['ip', 'link', 'set', 'eth1', 'name', 'sriov-link-enabled']
09:52:57: [   22.329553] cloud-init[645]: Exit code: 255
09:52:57: [   22.331617] cloud-init[645]: Reason: -
09:52:57: [   22.333165] cloud-init[645]: Stdout:
09:52:57: [   22.334622] cloud-init[645]: Stderr: Error: argument "sriov-link-enabled" is wrong: "name" not a valid ifname

Potentially a race?
Affect the two tests test_id:3956 / 3957
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

I have managed to recreate the problem using ip commands:
$ ip link add dummy99 type dummy
$ ip link set  dummy99 name sriov-link-enabled
Error: argument "sriov-link-enabled" is wrong: "name" not a valid ifname

Using a valid ifname solves this:
ip link set  dummy99 name sriov99

For completion, the reason it passes sometimes has been investigated here.
20:31:07: [   25.486072] cloud-init[654]: 2020-12-06 20:30:28,873 - stages.py[WARNING]: Failed to rename devices: [unknown] Error performing rename('eth0', 'sriov-link-enabled') for 02:00:00:ad:84:f7, sriov-link-enabled: Unexpected error while running command.
20:31:07: [   25.492191] cloud-init[654]: Command: ['ip', 'link', 'set', 'eth0', 'name', 'sriov-link-enabled']
20:31:07: [   25.495544] cloud-init[654]: Exit code: 255
20:31:07: [   25.497182] cloud-init[654]: Reason: -
20:31:07: [   25.498817] cloud-init[654]: Stdout:
20:31:07: [   25.500395] cloud-init[654]: Stderr: Error: argument "sriov-link-enabled" is wrong: "name" not a valid ifname
20:31:07: [  OK  ] Finished Initial cloud-init job (pre-networking).
20:31:07: [  OK  ] Reached target Network (Pre).
20:31:07:          Starting Network Manager...
20:31:07: [  OK  ] Started Network Manager.
20:31:07: [  OK  ] Reached target Network.
20:31:07:          Starting Network Manager Wait Online...
20:31:07:          Starting Initial cloud-ini… (metadata service crawler)...
20:31:07: [  OK  ] Listening on Load/Save RF …itch Status /dev/rfkill Watch.
20:31:07:          Starting Network Manager Script Dispatcher Service...
20:31:07: [  OK  ] Started Network Manager Script Dispatcher Service.
20:31:07: [   27.433433] mlx5_core 0000:02:01.0 eth0: Link up
20:31:07: [   27.436974] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
20:31:07: [   27.571824] cloud-init[700]: Cloud-init v. 19.4 running 'init' at Sun, 06 Dec 2020 20:30:30 +0000. Up 27.36 seconds.
20:31:07: [   27.575952] cloud-init[700]: ci-info: +++++++++++++++++++++++++++++++++++++++Net device info+++++++++++++++++++++++++++++++++++++++
20:31:07: [   27.580725] cloud-init[700]: ci-info: +--------+------+------------------------------+---------------+--------+-------------------+
20:31:07: [   27.585551] cloud-init[700]: ci-info: | Device |  Up  |           Address            |      Mask     | Scope  |     Hw-Address    |
20:31:07: [   27.590218] cloud-init[700]: ci-info: +--------+------+------------------------------+---------------+--------+-------------------+
20:31:07: [   27.594686] cloud-init[700]: ci-info: |  eth0  | True |         <IP_ADDRESS>          | <IP_ADDRESS> | global | 02:00:00:ad:84:f7 |
20:31:07: [   27.598106] cloud-init[700]: ci-info: |  eth0  | True |       fd10:0:2::2/120        |       .       | global | 02:00:00:ad:84:f7 |
20:31:07: [   27.601868] cloud-init[700]: ci-info: |  eth0  | True |    fe80::ff:fead:84f7/64     |       .       |  link  | 02:00:00:ad:84:f7 |
20:31:07: [   27.605993] cloud-init[700]: ci-info: |  eth1  | True |           <IP_ADDRESS>           | <IP_ADDRESS> | global | 02:00:00:af:76:0a |
20:31:07: [   27.610710] cloud-init[700]: ci-info: |  eth1  | True | fe80::11cd:3412:6b69:9113/64 |       .       |  link  | 02:00:00:af:76:0a |
20:31:07: [   27.614553] cloud-init[700]: ci-info: |   lo   | True |          <IP_ADDRESS>           |   <IP_ADDRESS>   |  host  |         .         |
20:31:07: [   27.619436] cloud-init[700]: ci-info: |   lo   | True |           ::1/128            |       .       |  host  |         .         |
20:31:07: [   27.624179] cloud-init[700]: ci-info: +--------+------+------------------------------+---------------+--------+-------------------+


extension: impl Encode for known extensions

This also splits the DestinationConstraints implementation in a subtype for ease and readability.

This blows the work I committed in #45 out of the water; looks great!

Looks good, please update on top of main and let's merge this :partying_face:

Ship it,  ship it! 🚀


Backslashes in string literals are weird

Describe the bug
When a string literal is rendered as a "Bare" in reflex, any backslashes which made it into the string are escaped a second time by javascript.
The question is, should reflex be escaping single backslashes when generating code? And should reflex be converting unrepresentable characters in string literals with their escaped equivalent?
To Reproduce
import reflex as rx

@rx.page(route="/")
def bug() -> rx.Component:
    return rx.vstack(
        rx.markdown(r"""
# Hello world

Lift($$L$$) can be determined by Lift Coefficient ($$C_L$$) like the following
equation.

$$
L = \\frac{1}{2} \\rho v^2 S C_L
$$

$$
R = \\sum_{i=1}n{w_ir_i}=\\sum_{i=1}^n{x_ig_i}.
$$
"""),
        rx.text(r"\u2342"),
    )

app = rx.App()

Produced
  <ReactMarkdown rehypePlugins={[rehypeKatex, rehypeRaw]} remarkPlugins={[remarkMath, remarkGfm, remarkUnwrapImages]} components={ComponentMap_4ffb469341e2b6627f60d58f709452af()}>
  {`
# Hello world

Lift($$L$$) can be determined by Lift Coefficient ($$C_L$$) like the following
equation.

$$
L = \\frac{1}{2} \\rho v^2 S C_L
$$

$$
R = \\sum_{i=1}n{w_ir_i}=\\sum_{i=1}^n{x_ig_i}.
$$
`}
</ReactMarkdown>
  <RadixThemesText as={`p`}>
  {`\u2342`}
</RadixThemesText>

Expected behavior
When a "raw" python string is used, the user does not expect needing to escape the backslashes again, but indeed this is necessary for the markdown math parser to correctly display the expression.
Specifics (please complete the following information):

Python Version: 3.12
Reflex Version: 0.5.10

for context on latest main, this is the output:
<ReactMarkdown
  components={ComponentMap_b05fc871f4c07d9afa8e52fc86215f3f()}
  rehypePlugins={[rehypeKatex, rehypeRaw]}
  remarkPlugins={[remarkMath, remarkGfm, remarkUnwrapImages]}
>
  {
    "\n# Hello world\n\nLift($$L$$) can be determined by Lift Coefficient ($$C_L$$) like the following\nequation.\n\n$$\nL = \\\\frac{1}{2} \\\\rho v^2 S C_L\n$$\n\n$$\nR = \\\\sum_{i=1}n{w_ir_i}=\\\\sum_{i=1}^n{x_ig_i}.\n$$\n"
  }
</ReactMarkdown>
<RadixThemesText as={"p"}>{"\\u2342"}</RadixThemesText>

The expected output in the first case would be correct if the developer uses one backslach. In the second example, changing the raw string into a normal string would display the correct character (otherwise, would just display the string).

Yeah i think this is working as expected in 0.6.x, so we can probably close it


Questions about number of anchors

The code is about class MultiGroupHead which is in Det3D/det3d/models/bbox_heads/mg_head.py
Original code
num_classes = [len(t["class_names"]) for t in tasks]
self.class_names = [t["class_names"] for t in tasks]
self.num_anchor_per_locs = [2 * n for n in num_classes]

for num_c, num_a, box_cs in zip(
            num_classes, self.num_anchor_per_locs, box_code_sizes
        ):
            if self.encode_background_as_zeros:
                num_cls = num_a * num_c
            else:
                num_cls = num_a * (num_c + 1)
            num_clss.append(num_cls)

For example, if task is like this:
dict(num_class=2, class_names=["Bus","Trailer"])

Then num_classes will be 2, and num_anchor_per_locs will be 4. Finally, num_cls will be 2*4=8. I am wondering what does this 8 represents? If we only consider 2 different orientations of anchor for one class, the total number of anchors should be same as num_anchor_per_locs, why do we still need to multiply num_anchor_per_locs by num_classes?

anchor size is agnostic to categories, so we need to predict probability of being any one of all categories in this head.

Hello in the same code what does num_dir = num_a * 2 mean? Aren't the 2 different orientations already encapsulated in self.num_anchor_per_locs = [2 * n for n in num_classes]?
So for 1 class why are 4 directions needed?


no prediction output

when it came to 80K steps, all the prediction generated audios were blank audio:

Please describe more info.

What kind of recipe (or dataset) did you use?
Which model did you train? (Attach your config)
How was the training curve?

Please describe more info.

What kind of recipe (or dataset) did you use?
Which model did you train? (Attach your config)
How was the training curve?

I use LJSpeech1.1（trim leading and tail silence and do volume normalization, this is what I used for training Tacotron2）to train mb-melgan.v2, copy from egs/ljspeech/conf/multi_band_melgan.v2.yaml and set the fmax 8000

training cure is weird

It seems loss value became NaN around 80k steps.
I'm not sure which loss became NaN.
Please paste your whole config here.

It seems loss value became NaN around 80k steps.
I'm not sure which loss became NaN.
I've never met loss = NaN so I'm wondering your data or config is something wrong.
Please paste your whole config here.

# This is the hyperparameter configuration file for MelGAN.
# Please make sure this is adjusted for the LJSpeech dataset. If you want to
# apply to the other dataset, you might need to carefully change some parameters.
# This configuration requires ~ 8GB memory and will finish within 5 days on Titan V.

# This configuration is based on multi-band MelGAN but the hop size and sampling
# rate is different from the paper (16kHz vs 22.05kHz). The number of iteraions
# is now shown in the paper so currently we train 1M iterations (not sure enough
# to converge). Compared to multi_band_melgan.v1 config, Adam optimizer without
# gradient norm is used, which is based on @dathudeptrai advice.
# https://github.com/kan-bayashi/ParallelWaveGAN/issues/143#issuecomment-632539906

# We found that the use of small batch_max_steps (e.g. 8192) has no bad effect for
# the quality, so if you want to accelerate the training, please reduce it.

###########################################################
#                FEATURE EXTRACTION SETTING               #
###########################################################
sampling_rate: 22050     # Sampling rate.
fft_size: 1024           # FFT size.
hop_size: 256            # Hop size.
win_length: null         # Window length.
                         # If set to null, it will be the same as fft_size.
window: "hann"           # Window function.
num_mels: 80             # Number of mel basis.
fmin: 80                 # Minimum freq in mel basis calculation.
# modify by yuanxi corresponding with NVIDIA-tacotron2
fmax: 8000               # Maximum frequency in mel basis calculation.
#fmax: 7800               # Maximum frequency in mel basis calculation.
global_gain_scale: 1.0   # Will be multiplied to all of waveform.
trim_silence: true       # Whether to trim the start and end of silence.
trim_threshold_in_db: 60 # Need to tune carefully if the recording is not good.
trim_frame_size: 2048    # Frame size in trimming.
trim_hop_size: 512       # Hop size in trimming.
format: "hdf5"           # Feature file format. "npy" or "hdf5" is supported.

###########################################################
#         GENERATOR NETWORK ARCHITECTURE SETTING          #
###########################################################
generator_type: "MelGANGenerator" # Generator type.
generator_params:
    in_channels: 80               # Number of input channels.
    out_channels: 4               # Number of output channels.
    kernel_size: 7                # Kernel size of initial and final conv layers.
    channels: 384                 # Initial number of channels for conv layers.
    upsample_scales: [8, 4, 2]    # List of Upsampling scales.
    stack_kernel_size: 3          # Kernel size of dilated conv layers in residual stack.
    stacks: 4                     # Number of stacks in a single residual stack module.
    use_weight_norm: True         # Whether to use weight normalization.
    use_causal_conv: False        # Whether to use causal convolution.

###########################################################
#       DISCRIMINATOR NETWORK ARCHITECTURE SETTING        #
###########################################################
discriminator_type: "MelGANMultiScaleDiscriminator" # Discriminator type.
discriminator_params:
    in_channels: 1                    # Number of input channels.
    out_channels: 1                   # Number of output channels.
    scales: 3                         # Number of multi-scales.
    downsample_pooling: "AvgPool1d"   # Pooling type for the input downsampling.
    downsample_pooling_params:        # Parameters of the above pooling function.
        kernel_size: 4
        stride: 2
        padding: 1
        count_include_pad: False
    kernel_sizes: [5, 3]              # List of kernel size.
    channels: 16                      # Number of channels of the initial conv layer.
    max_downsample_channels: 512      # Maximum number of channels of downsampling layers.
    downsample_scales: [4, 4, 4]      # List of downsampling scales.
    nonlinear_activation: "LeakyReLU" # Nonlinear activation function.
    nonlinear_activation_params:      # Parameters of nonlinear activation function.
        negative_slope: 0.2
    use_weight_norm: True             # Whether to use weight norm.

###########################################################
#                   STFT LOSS SETTING                     #
###########################################################
stft_loss_params:
    fft_sizes: [1024, 2048, 512]  # List of FFT size for STFT-based loss.
    hop_sizes: [120, 240, 50]     # List of hop size for STFT-based loss
    win_lengths: [600, 1200, 240] # List of window length for STFT-based loss.
    window: "hann_window"         # Window function for STFT-based loss
use_subband_stft_loss: true
subband_stft_loss_params:
    fft_sizes: [384, 683, 171]  # List of FFT size for STFT-based loss.
    hop_sizes: [30, 60, 10]     # List of hop size for STFT-based loss
    win_lengths: [150, 300, 60] # List of window length for STFT-based loss.
    window: "hann_window"       # Window function for STFT-based loss

###########################################################
#               ADVERSARIAL LOSS SETTING                  #
###########################################################
use_feat_match_loss: false # Whether to use feature matching loss.
lambda_adv: 2.5            # Loss balancing coefficient for adversarial loss.

###########################################################
#                  DATA LOADER SETTING                    #
###########################################################
batch_size: 64             # Batch size.
batch_max_steps: 16384     # Length of each audio in batch. Make sure dividable by hop_size.
pin_memory: true           # Whether to pin memory in Pytorch DataLoader.
num_workers: 4             # Number of workers in Pytorch DataLoader.
remove_short_samples: true # Whether to remove samples the length of which are less than batch_max_steps.
allow_cache: true          # Whether to allow cache in dataset. If true, it requires cpu memory.

###########################################################
#             OPTIMIZER & SCHEDULER SETTING               #
###########################################################
generator_optimizer_type: "Adam"       # Generator's optimizer type.
generator_optimizer_params:
    lr: 1.0e-3                          # Generator's learning rate.
    eps: 1.0e-7                         # Generator's epsilon.
    weight_decay: 0.0                   # Generator's weight decay coefficient.
    amsgrad: true
generator_grad_norm: -1                 # Generator's gradient norm.
generator_scheduler_type: "MultiStepLR" # Generator's scheduler type.
generator_scheduler_params:
    gamma: 0.5                          # Generator's scheduler gamma.
    milestones:                         # At each milestone, lr will be multiplied by gamma.
        - 100000
        - 200000
        - 300000
        - 400000
        - 500000
        - 600000
discriminator_optimizer_type: "Adam"        # Discriminator's optimizer type.
discriminator_optimizer_params:
    lr: 1.0e-3                              # Discriminator's learning rate.
    eps: 1.0e-7                             # Discriminator's epsilon.
    weight_decay: 0.0                       # Discriminator's weight decay coefficient.
    amsgrad: true
discriminator_grad_norm: -1                 # Discriminator's gradient norm.
discriminator_scheduler_type: "MultiStepLR" # Discriminator's scheduler type.
discriminator_scheduler_params:
    gamma: 0.5                              # Discriminator's scheduler gamma.
    milestones:                             # At each milestone, lr will be multiplied by gamma.
        - 100000
        - 200000
        - 300000
        - 400000
        - 500000
        - 600000

###########################################################
#                    INTERVAL SETTING                     #
###########################################################
discriminator_train_start_steps: 200000 # Number of steps to start to train discriminator.
train_max_steps: 1000000                # Number of training steps.
save_interval_steps: 50000              # Interval steps to save checkpoint.
eval_interval_steps: 1000               # Interval steps to evaluate the network.
log_interval_steps: 1000                # Interval steps to record the training log.

###########################################################
#                     OTHER SETTING                       #
###########################################################
num_save_intermediate_results: 4  # Number of results to be saved as intermediate results.

Config seems fine.
Maybe your data has some perfect silence part? (Not sure)
Following part is doubtful. Why don't you try to use clamp here?
https://github.com/kan-bayashi/ParallelWaveGAN/blob/88a829b5ef923657b4fb590e0614dec5e106a971/parallel_wavegan/losses/stft_loss.py#L52
https://github.com/kan-bayashi/ParallelWaveGAN/blob/88a829b5ef923657b4fb590e0614dec5e106a971/parallel_wavegan/losses/stft_loss.py#L73

Config seems fine.
Maybe your data has some perfect silence part? (Not sure)
Following part is doubtful. Why don't you try to use clamp here?
https://github.com/kan-bayashi/ParallelWaveGAN/blob/88a829b5ef923657b4fb590e0614dec5e106a971/parallel_wavegan/losses/stft_loss.py#L52
https://github.com/kan-bayashi/ParallelWaveGAN/blob/88a829b5ef923657b4fb590e0614dec5e106a971/parallel_wavegan/losses/stft_loss.py#L73

I didnt modift these code, I just modify run.sh and conf file

I mean, please modify these parts to avoid NaN errors by yourself and check how it works.

I checked the code but the following clamp should avoid NaN errors.
https://github.com/kan-bayashi/ParallelWaveGAN/blob/88a829b5ef923657b4fb590e0614dec5e106a971/parallel_wavegan/losses/stft_loss.py#L31
I do not have an idea of why NaN has happened in your training.


[Decompiler] Unsolvable Type Propagation

In rare cases, it may be impossible to solve type propagation. In particular this may happen if an object is constructed with a custom allocator, or iterating through a heap of objects, etc.  In the equivalent C, it would be when you cast a void* to a structure type.
Here is an example. The code above L267 finds some memory for a cpu-thread, and the code below L267 initializes it.
However, the type propagation algorithm cannot figure out what the type of v0 is.  There is an access to v0's vtable (after lwu v1, -4(v0)), but the type propagation system can't figure this out because it doesn't know what v0 is.
We could do the following approaches:

Have the decompiler cast everything to integers/pointers. The code works in this case, but is unreadable. If we were to call a method, this approach wouldn't work, as we don't support calling functions with an unknown number of arguments.
Add the ability to give the decompiler a "hint" about types. For example, could we say "at L267, make v0 a cpu-thread"?  This will give us the right answer, but may require some manual work to figure out. I am not too concerned that this would add too much work.
Realize this is a new method, know that a1 contains the type-to-make, which must be cpu-thread or more specific, and notice sw a1, -4(v0) is setting the type of the newly constructed object.  This is an automatic solution, and something that the new type propagation system supports. But it's possible that this could get "confused" on more complicated functions (the type-propagator is roughly as smart as the compiler's type checking, and it's possible to write safe code that appears unsafe to the type-checker, which corresponds to a subset of cases where this would fail).  Also, this will 100% fail on any non-boxed structure type, requiring one of the other two methods.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
; .function (method 0 cpu-thread)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
  ;stack: total 0x00, fp? 0 ra? 0 ep? 1
Warnings: Type prop attempted and failed.


Add account address calculator widget in the docs

I know this is not trivial but I would love to see here an embedded interactive address calculator widget 🤔
https://github.com/software-mansion/protostar/pull/1105#discussion_r1015183816

Maybe just add calculate_address command to CLI?

Maybe just add calculate_address command to CLI?

I didn't think about this in the first place


HDDS-1856. Make required changes for Non-HA to use new HA code in OM.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
734
trunk passed

+1
compile
361
trunk passed

+1
checkstyle
71
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
898
branch has no errors when building and testing our client artifacts.

+1
javadoc
167
trunk passed

0
spotbugs
434
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
632
trunk passed

_ Patch Compile Tests _

+1
mvninstall
574
the patch passed

+1
compile
376
the patch passed

+1
javac
376
the patch passed

-0
checkstyle
41
hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
726
patch has no errors when building and testing our client artifacts.

+1
javadoc
161
the patch passed

+1
findbugs
800
the patch passed

_ Other Tests _

-1
unit
331
hadoop-hdds in the patch failed.

-1
unit
2061
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

8252

Reason
Tests

Failed junit tests
hadoop.hdds.scm.block.TestBlockManager

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.web.client.TestBuckets

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1174

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux aeb69cfe5e59 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 2fe450c

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/diff-checkstyle-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/testReport/

Max. process+thread count
4080 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
2
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
623
trunk passed

+1
compile
368
trunk passed

+1
checkstyle
78
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
910
branch has no errors when building and testing our client artifacts.

+1
javadoc
220
trunk passed

0
spotbugs
899
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
1385
trunk passed

_ Patch Compile Tests _

+1
mvninstall
1024
the patch passed

+1
compile
350
the patch passed

+1
javac
350
the patch passed

+1
checkstyle
83
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
681
patch has no errors when building and testing our client artifacts.

+1
javadoc
162
the patch passed

+1
findbugs
638
the patch passed

_ Other Tests _

-1
unit
283
hadoop-hdds in the patch failed.

-1
unit
1640
hadoop-ozone in the patch failed.

+1
asflicense
48
The patch does not generate ASF License warnings.

8918

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestWatchForCommit

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1174

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3f257c0ebf60 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 611718f

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/2/testReport/

Max. process+thread count
4205 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Basically +1 from me. A few minor comments.
I thought about the potential synchronization issue @anuengineer pointed out offline and am not convinced it exists. Because we hold/release the lock when flushTransactions calls setReadyBuffer. So that is the synchronization point. All later access from the same thread should see the correct value of the futureQueue.
Couple of ways remove the ambiguity:

Make the queues volatile.
Return the queue from setReadyBuffer. Since the returned pointer was sampled with the lock held, the caller is guaranteed to see the correct value. This solution should also make findbugs happy.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
45
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
625
trunk passed

+1
compile
363
trunk passed

+1
checkstyle
83
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
848
branch has no errors when building and testing our client artifacts.

+1
javadoc
150
trunk passed

0
spotbugs
419
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
614
trunk passed

_ Patch Compile Tests _

+1
mvninstall
561
the patch passed

+1
compile
352
the patch passed

+1
javac
352
the patch passed

+1
checkstyle
71
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
617
patch has no errors when building and testing our client artifacts.

+1
javadoc
153
the patch passed

+1
findbugs
686
the patch passed

_ Other Tests _

-1
unit
194
hadoop-hdds in the patch failed.

-1
unit
1915
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

7473

Reason
Tests

Failed junit tests
hadoop.ozone.container.ozoneimpl.TestOzoneContainer

hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient

hadoop.ozone.client.rpc.TestContainerStateMachine

hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.client.rpc.TestCommitWatcher

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.om.TestOzoneManagerHA

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1174

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4bbc9ab239dc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0f2dad6

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/4/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/4/testReport/

Max. process+thread count
3749 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/4/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
2
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 25 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
717
trunk passed

+1
compile
374
trunk passed

+1
checkstyle
73
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
889
branch has no errors when building and testing our client artifacts.

+1
javadoc
161
trunk passed

0
spotbugs
413
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
603
trunk passed

_ Patch Compile Tests _

+1
mvninstall
559
the patch passed

+1
compile
364
the patch passed

+1
javac
364
the patch passed

+1
checkstyle
81
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
640
patch has no errors when building and testing our client artifacts.

+1
javadoc
152
the patch passed

+1
findbugs
631
the patch passed

_ Other Tests _

-1
unit
350
hadoop-hdds in the patch failed.

-1
unit
3430
hadoop-ozone in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

9290

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode

hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory

hadoop.ozone.client.rpc.Test2WayCommitInRatis

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion

hadoop.ozone.web.client.TestOzoneClient

hadoop.hdds.scm.pipeline.TestPipelineClose

hadoop.ozone.TestContainerStateMachineIdempotency

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1174

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ab84367207b3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0f2dad6

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/3/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/3/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/3/testReport/

Max. process+thread count
3684 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1174/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Opened a jira HDDS-1872 for failure related to TestS3MultipartUploadAbortResponse.
Rest of the test failures are not related to this patch.
Thank You @arp7 for the review. I will commit this to the trunk.


Preserves existing Markdown styles

Addresses #4

Change styling technique to one which introduces explicit SPAN elements. This avoids prior collisions with styling existing Markdown styles such as bold.
Change extension for file storing CSS to match its contents for maintainability's sake
Update example folder with new test

New example:

Bugs in this PR:

Style for removed needs strikethrough.
Style for added needs bold.

Fixed! I hope you like @jduckles

Oooh very nice catch, thanks for taking the time to contribute a fix!

FYI I used this change for https://github.com/raspy135/Qun-mk2/pull/17 to help describe changes I made to a Markdown for this synthesizer

Very nice @nrichards! I created it when I was working on membership contracts for The Carpentries which I managed in markdown and needed to send red-line edit versions of what changed as part of the membership contract negotiations. You can also get a similar effect by using Word or LibreOffice and merging a changed version of the document with "track changes" turned on. I like this approach in text land a lot more though. Happy to see it being useful.


add unit tests for all operators

This adds unit test infrastructure to easily add unit tests for all operators.

ideally the cost would be verified by those test cases as well


Update to 7.5.0 - and saver session flag

Describe the bug
Had some oddities moving over to this update (as seen in the discussions kept losing data, now found that out to be connection limits).
So this leaves me with odd one, the saver session flag is turned on, where in 7.4.5 is was off.
Not a big issue, but given I had automations linked to it to shutdown the house (thankfully I had remembered to disabled it!) it gave me a moment.
Reproduction steps
Install 7.5.0 add account, saver is turned on.
Reverting to 7.4.5 the flag turns off.
Expected behaviour
Saver should be Off
Tariff Code
No response
Integration Version
7.5.0
Home Assistant Version
2023.7.2
Fresh Install?
Not specified
Home Assistant Logs
No logs can provide if there is a specific one needed

I'm confused again (just going to be one of those weeks!!).  So just checked back, and now the flag is off.. looking at the sensor it took from 11:26 unyil 11.57 for the state to change to off.
So reconnected the test HA, it's still on? (and data is currently flowing).  Reloaded it on the production HA, and saver is on again.
By chance is this flag now set as default to on until the update from Octopus, which I'm guessing is on/close to the hour (11.57.45).  And as I was having connection issues and not getting data at that point with both HA's on, this is why it never turned off.
I'll shut off test and I'll see if it updates the saver session at 13:57 and report back.

It finally reset at 16.53.  needed to reboot for something else the same came back on 17.19 and turned off at 17.30
I've no idea what is going on but any reboot of HA OR just reload of the addon, forces saver on.
Anything I can test it log let me know.

I too am encountering this issue. I've a number of conditional cards on my dashboards that are based on the saving session binary sensor and it being stuck at 'on' for some reason is causing some oddities. All my light switch cards vanished for instance.

Looking at the code, it might be an issue in the restore state logic. I might remove that for this sensor as it might be trying to reload an old state when it was on.

This is very odd, as nothing has changed in the sensor in the last release. I am also not seeing this behaviour myself. It should only turn on if you're within a joined event's time. Is there anything in the joined_events attribute of the sensor that might give a clue as to why this is coming on?

In case that helps.

Looking at the code, it might be an issue in the restore state logic. I might remove that for this sensor as it might be trying to reload an old state when it was on.

I'm not sure why you can't reproduce it, that's even stranger.  I have it on two instances, which are even different hardware, the test has a minimal configuration.

Just tried it again, as it's been on all night, after a reload no change (while getting data from octopus).
So you want any log files, as I can pull that off my test instance, (as it's quieter but having the issue as well).

I'll have a proper look at states soon, but I would also point out a couple of oddities that might trigger some strangeness.  I just had an export tariff added, so I know strange stuff can show up when tariff changes are happening but it's generally settled down now.  Additionally, the other day when I reloaded the integration (I was already having issues at that point) to see if the export tariff was coming through yet, I gained a second Gas Meter device with no entities.  Very odd.  I'll be interested to see what happens when my gas meter is disconnected at the end of the month (I've now got a heatpump so no need for gas).

No next session added, but could you remind me where the list of previous sessions is?  I was certain there used to be an attribute on some entity with a list of joined sessions and I'm not seeing it now :/

Yes, here we are, this old card of mine I've got hidden behind one of the problem conditionals right now relies on a joined_events attribute that doesn't seem to be showing up anymore :/

Actually kind of curious as to how that state_attr function was ever working given it doesn't have the binary_sensor. domain specified :/ But that's off topic.

Sorry, I'm going blind.  That joined_events attribute is indeed there, but it seems to have been emptied out with no entries now.  It doesn't even have an empty [] but then, perhaps yaml doesn't normally show that.
But my guess is Octopus have purged my previous joined sessions array, possibly as part of the various tariff changes I've been through lately, and that's upset the state restore process.

I'll have a proper look at states soon, but I would also point out a couple of oddities that might trigger some strangeness.  I just had an export tariff added, so I know strange stuff can show up when tariff changes are happening but it's generally settled down now.  Additionally, the other day when I reloaded the integration (I was already having issues at that point) to see if the export tariff was coming through yet, I gained a second Gas Meter device with no entities.  Very odd.  I'll be interested to see what happens when my gas meter is disconnected at the end of the month (I've now got a heatpump so no need for gas).

Increasingly I also got a second gas meter with no entities (deleting and adding the account cleared that). I thought it was due to switching to tracker.

So the saver sessions is now off.  But the state of the entity has changed (not just on to off)

That's curious, so it looks like it is indeed that list that's the problem.  Yours had disappeared in your last screenshot too, but now it's back it's managing to figure out the state properly.  So I'd say that's definitely something the logic could be tweaked to handle because we can be sure that if the joined_events list is empty then we can't possibly be in a saving session now :)

I've released a fix that will should fix this issue. This can be found at https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/releases/tag/v7.5.1

I've released a fix that will should fix this issue. This can be found at https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/releases/tag/v7.5.1

That seems to have done the job for me, thank you muchly!
Did you figure out if it's a recent issue or just a coincidence that a couple of us encountered it at the same time?

I've released a fix that will should fix this issue. This can be found at https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/releases/tag/v7.5.1

Thanks for getting out a fix so quickly.  This and all your work is very much appreciated.

I believe this issue (among others) was related to a change I made to be more inline with HA docs. However, I should have taken the "if it aint broke, don't fix it" mentality with this one. The changes were made in a point release of v7.4, which you guys must have missed.

That is the oddity, going back to 7.45 everything was fine straight away, roll forward it failed, I tried this on two instances of HA, with identical results.  Didn't log this until I think 3rd cycle timing backwards and forwards on both instances to be sure it wasn't me.
All made worse when it did appear in 7.5,  the recovery time to clear the varied unpredictably.  I suspect there was/is other things in play at octopus.
Will monitor it, which is easy as I have a bright red conditional card on my dashboard that appears when an event is on. (Very hard to miss!)
Either way.  Thanks your help is appreciated.


refactor: migrate to react-intl v3

Description:
Migrate to react-intl v3. In our case main breaking changes were:
Removal of addLocaleData
Removal of intlShape
Removal of FormattedRelative

How Has This Been Tested?
Manually

Types of changes:
Refactor

Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage remained the same at ?% when pulling cef2cd16be3e33605804a175e7f01feffdacbef2 on korhaliv:refactor/migrate-react-intl-v3 into 6e4f8d0dd374af532cdc83a8acd260ba18622ca2 on LN-Zap:next.


addimageblobhook

Will the addimageblobhook event in hooks be triggered when I paste pictures when using the copy and paste function?

@AtroxEzerel
yes. it works. (link)

@jwlee1108 Thank you very much. The problem has been solved.


CorpusAnalysis: per_doc analysis not assigned to document IDs

When performing a per-doc-analysis on a corpus, like get_tokens_per_doc, the result is a list of a list of all tokens, without any indicator, to which document each result list belongs.
This should probably be changed to a list of dicts containing a celex and result key, to ensure each result is linked to its original doc.

With c5ddf80 all CELEX numbers are stored during the calculations and now can be accessed via _get_celex_numbers. Changing all functions to include a dict instead of a simple list might also be a possibility but further increases the memory footprint of the analysis part.


Support indexpacks in Docker release container [phab:D75]

Created by schroederc at 2015-02-20 16:55:13:

fromberger commented inline (context lost during migration) at 2015-02-20 17:23:18:
Please update the usage, too.

fromberger commented inline (context lost during migration) at 2015-02-20 17:23:18:
drive_indexer_kindex

fromberger wrote at 2015-02-20 17:23:18:
Just a couple little things.

fromberger accepted this revision at 2015-02-20 17:23:18

schroederc wrote at 2015-02-20 17:37:16:
Review changes

schroederc commented inline (context lost during migration) at 2015-02-20 17:38:46:
Done

schroederc commented inline (context lost during migration) at 2015-02-20 17:38:46:
Done

schroederc closed via commit c91541004e20372e2562c8e076ded45d7f9346a5 at 2015-02-20 17:42:44

schroederc closed via commit 081bfc46dd733244132728fdfe28559fadb3f4c9 at 2015-02-20 17:42:44


Locale language not changed

I have added
i18n:
  locale: fr

to the end of settings.yml and restarted the server but the locale languge is still English.
I also tried for other languages and saw no changes. Am I missing something? or it is a bug?
BTW, the wiki page about locales change missing a ':' after 'i18n'.

@k0fi thank you, it's been fixed
You can also now pass in an additional locales array in the yaml to allow visitors browser settings to determine the locale of their choosing.


💪 In built support for layouts

This feature request is for removing the usage of third-party lib: vite-plugin-vue-layouts
I raised a feature request there to add support for unplugin-vue-router but it looks like lib isn't maintained well.
Hence, here I am raising a feature request for adding layout support within unplugin-vue-router itself.

P.S. Even README suggests we can use vite-plugin-vue-layouts with unplugin-vue-router, I guess it won't according to my raised issue in that repo. WDYT 🤔

I don't want to remove the use of an existing lib. I think the author did a great job and it's great to be able to choose whether to use it or not. If the lib is not well maintained, you could try maintaining it yourself!
As for the workaround for vite-plugin-vue-layouts, you can find it in some discussions here. This is the relevant file: https://github.com/zynth17/unplugin-vue-router-bug-dynamic-path/blob/main/src/modules/router.ts
import {
  createRouter,
  createWebHistory,
  type RouteRecordRaw,
} from 'vue-router/auto'

import { setupLayouts } from 'virtual:generated-layouts'
import type { ViteSetupModule } from '@/types/ViteSetupModule'

function recursiveLayouts(route: RouteRecordRaw): RouteRecordRaw {
  if (route.children) {
    for (let i = 0; i < route.children.length; i++) {
      route.children[i] = recursiveLayouts(route.children[i])
    }

    return route
  }

  return setupLayouts([route])[0]
}

export const router = createRouter({
  extendRoutes(routes) {
    return routes.map((route) => {
      // My custom extendRoutes logic, that adds a meta field to force specific pages under
      // a given path to require auth.
      if (route.path.includes('auth')) {
        route = {
          ...route,
          meta: {
            auth: false,
            layout: 'auth-layout',
            ...route.meta,
          },
        }
      }

      // For each route, pass it to recursiveLayouts, which will apply layouts properly
      // (without duplicating or accidentally double-wrapping components).

      return recursiveLayouts(route)
    })
  },
  history: createWebHistory(),
})

Thanks for detailed response 😇


Add multiple devices

Hey everyone,
great code - but how do I add different speaker / devices?
Thanks and cheers

Did it, so if someone is interested. Just ignore the required parameters via optimist and add the devices directly in the file, e.g. play_stdin.js in /examples
host = "<IP_ADDRESS>"
var device = airtunes.add(host, {
port: 5000
volume: 100
});
var host2 = '<IP_ADDRESS>';
var device = airtunes.add(host2, {
port: 1024
volume: 100
});


Cropping exported images

Hi,
the exported images have page dimensions.
Is there anyway to cropping with the right original dimensions?
Thanks in advance
-j

I've resolved changing -C  option (export page area) to -D (export bounding box image)
Thanks.
-j

Now fixed thanks to the @hstefan PR #3


Honor REGISTER_MANUAL_CONFIRM when doing openid registration

REGISTER_MANUAL_CONFIRM is not honored when doing performing an openid registration. The new account is directly accessible.
With this patch, the manual confirm flag gets honored in the same way as a "normal" registration (as found in routers/user/auth.go).

:rocket:


Access sessionId

Problem Statement
I want to get and use sessionId for my own purposes (correlating your sessions with my server data). But, it's private. Could you make an accessor, or public?
private var sessionId: String?
Solution Brainstorm
Make an accessor function.

@colin-persona that is fine, would you like to open a PR and make a read-only getter?

Yes. Yes I would, thanks! Here it is: https://github.com/PostHog/posthog-ios/pull/165

I didn't add to change log or bump version... figured you should do that?

done by https://github.com/PostHog/posthog-ios/pull/170


registration request from device plugin failing with kubeadm + containerd

I'm trying to get a kubernetes cluster up to test kubevirt however I'm running into the same issue with CentOS8 and Ubuntu22.
For the kubelet this is what I see:
Sep 17 22:08:16 virt-node01 kubelet[1618]: I0917 22:08:16.940489    1618 server.go:142] "Got registration request from device plugin with resource" resourceName="devices.kubevirt.io/kvm"
Sep 17 22:08:16 virt-node01 kubelet[1618]: I0917 22:08:16.999311    1618 server.go:142] "Got registration request from device plugin with resource" resourceName="devices.kubevirt.io/tun"
Sep 17 22:08:17 virt-node01 kubelet[1618]: I0917 22:08:17.105519    1618 server.go:142] "Got registration request from device plugin with resource" resourceName="devices.kubevirt.io/vhost-net"
Sep 17 22:08:17 virt-node01 kubelet[1618]: I0917 22:08:17.105519    1618 server.go:142] "Got registration request from device plugin with resource" resourceName="devices.kubevirt.io/vhost-net"
Sep 17 22:08:26 virt-node01 kubelet[1618]: E0917 22:08:26.941467    1618 client.go:65] "Unable to connect to device plugin client with socket path" err="failed to dial device plugin: context deadline exceeded" path="/var/lib/kubelet/device-plugins/k>
Sep 17 22:08:26 virt-node01 kubelet[1618]: E0917 22:08:26.941520    1618 handler.go:73] "Failed to connect to new client" err="failed to dial device plugin: context deadline exceeded" resource="devices.kubevirt.io/kvm"
Sep 17 22:08:26 virt-node01 kubelet[1618]: I0917 22:08:26.941560    1618 server.go:158] "Error connecting to device plugin client" err="failed to dial device plugin: context deadline exceeded"
Sep 17 22:08:27 virt-node01 kubelet[1618]: E0917 22:08:26.999929    1618 client.go:65] "Unable to connect to device plugin client with socket path" err="failed to dial device plugin: context deadline exceeded" path="/var/lib/kubelet/device-plugins/k>
Sep 17 22:08:27 virt-node01 kubelet[1618]: E0917 22:08:26.999987    1618 handler.go:73] "Failed to connect to new client" err="failed to dial device plugin: context deadline exceeded" resource="devices.kubevirt.io/tun"
Sep 17 22:08:27 virt-node01 kubelet[1618]: I0917 22:08:27.000014    1618 server.go:158] "Error connecting to device plugin client" err="failed to dial device plugin: context deadline exceeded"
Sep 17 22:08:27 virt-node01 kubelet[1618]: E0917 22:08:27.106404    1618 client.go:65] "Unable to connect to device plugin client with socket path" err="failed to dial device plugin: context deadline exceeded" path="/var/lib/kubelet/device-plugins/k>
Sep 17 22:08:27 virt-node01 kubelet[1618]: E0917 22:08:27.106456    1618 handler.go:73] "Failed to connect to new client" err="failed to dial device plugin: context deadline exceeded" resource="devices.kubevirt.io/vhost-net"
Sep 17 22:08:27 virt-node01 kubelet[1618]: I0917 22:08:27.106472    1618 server.go:158] "Error connecting to device plugin client" err="failed to dial device plugin: context deadline exceeded"

I also see errors on virt-handler pod:
{"component":"virt-handler","level":"error","msg":"Error starting kvm device plugin","pos":"device_controller.go:69","reason":"error registering with device plugin manager: rpc error: code = Unknown desc = failed to dial device plugin: context deadline exceeded","timestamp":"2022-09-17T22:17:00.038220Z"}
{"component":"virt-handler","level":"error","msg":"Error starting tun device plugin","pos":"device_controller.go:69","reason":"error registering with device plugin manager: rpc error: code = Unknown desc = failed to dial device plugin: context deadline exceeded","timestamp":"2022-09-17T22:17:00.121864Z"}
{"component":"virt-handler","level":"error","msg":"Error starting vhost-net device plugin","pos":"device_controller.go:69","reason":"error registering with device plugin manager: rpc error: code = Unknown desc = failed to dial device plugin: context deadline exceeded","timestamp":"2022-09-17T22:17:00.388707Z"}

I've tested my system and it looks ok:
[root@virt-node01 centos]# virt-host-validate
  QEMU: Checking for hardware virtualization                                 : PASS
  QEMU: Checking if device /dev/kvm exists                                   : PASS
  QEMU: Checking if device /dev/kvm is accessible                            : PASS
  QEMU: Checking if device /dev/vhost-net exists                             : PASS
  QEMU: Checking if device /dev/net/tun exists                               : PASS
  QEMU: Checking for cgroup 'cpu' controller support                         : PASS
  QEMU: Checking for cgroup 'cpuacct' controller support                     : PASS
  QEMU: Checking for cgroup 'cpuset' controller support                      : PASS
  QEMU: Checking for cgroup 'memory' controller support                      : PASS
  QEMU: Checking for cgroup 'devices' controller support                     : PASS
  QEMU: Checking for cgroup 'blkio' controller support                       : PASS
  QEMU: Checking for device assignment IOMMU support                         : WARN (No ACPI DMAR table found, IOMMU either disabled in BIOS or not supported by this hardware platform)
  QEMU: Checking for secure guest support                                    : WARN (Unknown if this platform has Secure Guest support)
[root@virt-node01 centos]#

I see the files popping up on /var/lib/kubelet/device-plugins/, however they come and go...
I've also tried adding --feature-gates=DevicePlugins=true to my Kubelet.
This is my node info:
[root@virt-node01 centos]# kubectl describe node virt-node01
Name:               virt-node01
Roles:              control-plane
Labels:             beta.kubernetes.io/arch=amd64
                    beta.kubernetes.io/os=linux
                    cpu-feature.node.kubevirt.io/aes=true
                    cpu-feature.node.kubevirt.io/apic=true
                    cpu-feature.node.kubevirt.io/arat=true
                    cpu-feature.node.kubevirt.io/arch-capabilities=true
                    cpu-feature.node.kubevirt.io/avx=true
                    cpu-feature.node.kubevirt.io/clflush=true
                    cpu-feature.node.kubevirt.io/cmov=true
                    cpu-feature.node.kubevirt.io/cx16=true
                    cpu-feature.node.kubevirt.io/cx8=true
                    cpu-feature.node.kubevirt.io/de=true
                    cpu-feature.node.kubevirt.io/erms=true
                    cpu-feature.node.kubevirt.io/f16c=true
                    cpu-feature.node.kubevirt.io/fpu=true
                    cpu-feature.node.kubevirt.io/fsgsbase=true
                    cpu-feature.node.kubevirt.io/fxsr=true
                    cpu-feature.node.kubevirt.io/hypervisor=true
                    cpu-feature.node.kubevirt.io/lahf_lm=true
                    cpu-feature.node.kubevirt.io/lm=true
                    cpu-feature.node.kubevirt.io/mca=true
                    cpu-feature.node.kubevirt.io/mce=true
                    cpu-feature.node.kubevirt.io/mmx=true
                    cpu-feature.node.kubevirt.io/msr=true
                    cpu-feature.node.kubevirt.io/mtrr=true
                    cpu-feature.node.kubevirt.io/nx=true
                    cpu-feature.node.kubevirt.io/pae=true
                    cpu-feature.node.kubevirt.io/pat=true
                    cpu-feature.node.kubevirt.io/pcid=true
                    cpu-feature.node.kubevirt.io/pclmuldq=true
                    cpu-feature.node.kubevirt.io/pdcm=true
                    cpu-feature.node.kubevirt.io/pge=true
                    cpu-feature.node.kubevirt.io/pni=true
                    cpu-feature.node.kubevirt.io/popcnt=true
                    cpu-feature.node.kubevirt.io/pschange-mc-no=true
                    cpu-feature.node.kubevirt.io/pse=true
                    cpu-feature.node.kubevirt.io/pse36=true
                    cpu-feature.node.kubevirt.io/rdrand=true
                    cpu-feature.node.kubevirt.io/rdtscp=true
                    cpu-feature.node.kubevirt.io/sep=true
                    cpu-feature.node.kubevirt.io/skip-l1dfl-vmentry=true
                    cpu-feature.node.kubevirt.io/smep=true
                    cpu-feature.node.kubevirt.io/ss=true
                    cpu-feature.node.kubevirt.io/sse=true
                    cpu-feature.node.kubevirt.io/sse2=true
                    cpu-feature.node.kubevirt.io/sse4.1=true
                    cpu-feature.node.kubevirt.io/sse4.2=true
                    cpu-feature.node.kubevirt.io/ssse3=true
                    cpu-feature.node.kubevirt.io/syscall=true
                    cpu-feature.node.kubevirt.io/tsc=true
                    cpu-feature.node.kubevirt.io/tsc-deadline=true
                    cpu-feature.node.kubevirt.io/tsc_adjust=true
                    cpu-feature.node.kubevirt.io/umip=true
                    cpu-feature.node.kubevirt.io/vme=true
                    cpu-feature.node.kubevirt.io/vmx=true
                    cpu-feature.node.kubevirt.io/x2apic=true
                    cpu-feature.node.kubevirt.io/xsave=true
                    cpu-feature.node.kubevirt.io/xsaveopt=true
                    cpu-model-migration.node.kubevirt.io/IvyBridge=true
                    cpu-model-migration.node.kubevirt.io/Nehalem=true
                    cpu-model-migration.node.kubevirt.io/Opteron_G1=true
                    cpu-model-migration.node.kubevirt.io/Opteron_G2=true
                    cpu-model-migration.node.kubevirt.io/Penryn=true
                    cpu-model-migration.node.kubevirt.io/SandyBridge=true
                    cpu-model-migration.node.kubevirt.io/Westmere=true
                    cpu-model.node.kubevirt.io/IvyBridge=true
                    cpu-model.node.kubevirt.io/Nehalem=true
                    cpu-model.node.kubevirt.io/Opteron_G1=true
                    cpu-model.node.kubevirt.io/Opteron_G2=true
                    cpu-model.node.kubevirt.io/Penryn=true
                    cpu-model.node.kubevirt.io/SandyBridge=true
                    cpu-model.node.kubevirt.io/Westmere=true
                    cpu-vendor.node.kubevirt.io/Intel=true
                    cpumanager=false
                    host-model-cpu.node.kubevirt.io/IvyBridge=true
                    host-model-required-features.node.kubevirt.io/arat=true
                    host-model-required-features.node.kubevirt.io/arch-capabilities=true
                    host-model-required-features.node.kubevirt.io/hypervisor=true
                    host-model-required-features.node.kubevirt.io/pcid=true
                    host-model-required-features.node.kubevirt.io/pdcm=true
                    host-model-required-features.node.kubevirt.io/pschange-mc-no=true
                    host-model-required-features.node.kubevirt.io/skip-l1dfl-vmentry=true
                    host-model-required-features.node.kubevirt.io/ss=true
                    host-model-required-features.node.kubevirt.io/tsc_adjust=true
                    host-model-required-features.node.kubevirt.io/umip=true
                    host-model-required-features.node.kubevirt.io/vmx=true
                    host-model-required-features.node.kubevirt.io/xsaveopt=true
                    hyperv.node.kubevirt.io/base=true
                    hyperv.node.kubevirt.io/frequencies=true
                    hyperv.node.kubevirt.io/ipi=true
                    hyperv.node.kubevirt.io/reenlightenment=true
                    hyperv.node.kubevirt.io/reset=true
                    hyperv.node.kubevirt.io/runtime=true
                    hyperv.node.kubevirt.io/synic=true
                    hyperv.node.kubevirt.io/synic2=true
                    hyperv.node.kubevirt.io/synictimer=true
                    hyperv.node.kubevirt.io/time=true
                    hyperv.node.kubevirt.io/tlbflush=true
                    hyperv.node.kubevirt.io/vpindex=true
                    kubernetes.io/arch=amd64
                    kubernetes.io/hostname=virt-node01
                    kubernetes.io/os=linux
                    kubevirt.io/schedulable=false
                    node-role.kubernetes.io/control-plane=
                    node.kubernetes.io/exclude-from-external-load-balancers=
Annotations:        csi.volume.kubernetes.io/nodeid: {"csi.tigera.io":"virt-node01 "}
                    kubeadm.alpha.kubernetes.io/cri-socket: unix:///var/run/containerd/containerd.sock
                    kubevirt.io/heartbeat: 2022-09-17T22:20:43Z
                    node.alpha.kubernetes.io/ttl: 0
                    projectcalico.org/IPv4Address: <IP_ADDRESS>/24
                    projectcalico.org/IPv4VXLANTunnelAddr: <IP_ADDRESS>
                    volumes.kubernetes.io/controller-managed-attach-detach: true
CreationTimestamp:  Sat, 17 Sep 2022 21:42:25 +0000
Taints:             <none>
Unschedulable:      false
Lease:
  HolderIdentity:  virt-node01
  AcquireTime:     <unset>
  RenewTime:       Sat, 17 Sep 2022 22:21:18 +0000
Conditions:
  Type                 Status  LastHeartbeatTime                 LastTransitionTime                Reason                       Message
  ----                 ------  -----------------                 ------------------                ------                       -------
  NetworkUnavailable   False   Sat, 17 Sep 2022 22:07:22 +0000   Sat, 17 Sep 2022 22:07:22 +0000   CalicoIsUp                   Calico is running on this node
  MemoryPressure       False   Sat, 17 Sep 2022 22:16:55 +0000   Sat, 17 Sep 2022 21:42:25 +0000   KubeletHasSufficientMemory   kubelet has sufficient memory available
  DiskPressure         False   Sat, 17 Sep 2022 22:16:55 +0000   Sat, 17 Sep 2022 21:42:25 +0000   KubeletHasNoDiskPressure     kubelet has no disk pressure
  PIDPressure          False   Sat, 17 Sep 2022 22:16:55 +0000   Sat, 17 Sep 2022 21:42:25 +0000   KubeletHasSufficientPID      kubelet has sufficient PID available
  Ready                True    Sat, 17 Sep 2022 22:16:55 +0000   Sat, 17 Sep 2022 21:48:21 +0000   KubeletReady                 kubelet is posting ready status
Addresses:
  InternalIP:  <IP_ADDRESS>
  Hostname:    virt-node01
Capacity:
  cpu:                8
  ephemeral-storage:  157275116Ki
  hugepages-2Mi:      0
  memory:             14142284Ki
  pods:               110
Allocatable:
  cpu:                8
  ephemeral-storage:<PHONE_NUMBER>66
  hugepages-2Mi:      0
  memory:             14039884Ki
  pods:               110
System Info:
  Machine ID:                 4e10552abb674974b4778ed76a2c2b2e
  System UUID:                4e10552a-bb67-4974-b477-8ed76a2c2b2e
  Boot ID:                    0d1d8885-c569-44a2-be53-ecf00a94f839
  Kernel Version:             4.18.0-358.el8.x86_64
  OS Image:                   CentOS Stream 8
  Operating System:           linux
  Architecture:               amd64
  Container Runtime Version:  containerd://1.6.8
  Kubelet Version:            v1.25.1
  Kube-Proxy Version:         v1.25.1
PodCIDR:                      <IP_ADDRESS>/24
PodCIDRs:                     <IP_ADDRESS>/24
Non-terminated Pods:          (21 in total)
  Namespace                   Name                                                       CPU Requests  CPU Limits  Memory Requests  Memory Limits  Age
  ---------                   ----                                                       ------------  ----------  ---------------  -------------  ---
  calico-apiserver            calico-apiserver-7644b49445-2ttm5                          0 (0%)        0 (0%)      0 (0%)           0 (0%)         32m
  calico-apiserver            calico-apiserver-7644b49445-cv4dd                          0 (0%)        0 (0%)      0 (0%)           0 (0%)         32m
  calico-system               calico-kube-controllers-85666c5b94-v4xdp                   0 (0%)        0 (0%)      0 (0%)           0 (0%)         34m
  calico-system               calico-node-8nhx6                                          0 (0%)        0 (0%)      0 (0%)           0 (0%)         34m
  calico-system               calico-typha-7b4bc5cd58-hv55p                              0 (0%)        0 (0%)      0 (0%)           0 (0%)         34m
  calico-system               csi-node-driver-s2pkj                                      0 (0%)        0 (0%)      0 (0%)           0 (0%)         33m
  kube-system                 coredns-565d847f94-ghn76                                   100m (1%)     0 (0%)      70Mi (0%)        170Mi (1%)     38m
  kube-system                 coredns-565d847f94-mpv9s                                   100m (1%)     0 (0%)      70Mi (0%)        170Mi (1%)     38m
  kube-system                 etcd-virt-node01                        100m (1%)     0 (0%)      100Mi (0%)       0 (0%)         38m
  kube-system                 kube-apiserver-virt-node01              250m (3%)     0 (0%)      0 (0%)           0 (0%)         38m
  kube-system                 kube-controller-manager-virt-node01     200m (2%)     0 (0%)      0 (0%)           0 (0%)         38m
  kube-system                 kube-proxy-ngndc                                           0 (0%)        0 (0%)      0 (0%)           0 (0%)         38m
  kube-system                 kube-scheduler-virt-node01              100m (1%)     0 (0%)      0 (0%)           0 (0%)         38m
  kube-system                 metrics-server-696f4844bb-dshxd                            100m (1%)     0 (0%)      200Mi (1%)       0 (0%)         25m
  kubevirt                    virt-api-68d4b788f7-2fd5q                                  5m (0%)       0 (0%)      250Mi (1%)       0 (0%)         23m
  kubevirt                    virt-controller-887fd7878-8khwq                            10m (0%)      0 (0%)      250Mi (1%)       0 (0%)         22m
  kubevirt                    virt-controller-887fd7878-smd5x                            10m (0%)      0 (0%)      250Mi (1%)       0 (0%)         22m
  kubevirt                    virt-handler-lcf9v                                         10m (0%)      0 (0%)      230Mi (1%)       0 (0%)         22m
  kubevirt                    virt-operator-7bfd844447-8hd6g                             10m (0%)      0 (0%)      250Mi (1%)       0 (0%)         24m
  kubevirt                    virt-operator-7bfd844447-cgg5j                             10m (0%)      0 (0%)      250Mi (1%)       0 (0%)         24m
  tigera-operator             tigera-operator-6675dc47f4-k7fjn                           0 (0%)        0 (0%)      0 (0%)           0 (0%)         34m
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
  Resource           Requests      Limits
  --------           --------      ------
  cpu                1005m (12%)   0 (0%)
  memory             1920Mi (14%)  340Mi (2%)
  ephemeral-storage  0 (0%)        0 (0%)
  hugepages-2Mi      0 (0%)        0 (0%)
Events:
  Type     Reason                   Age                From             Message
  ----     ------                   ----               ----             -------
  Normal   Starting                 14m                kube-proxy
  Normal   Starting                 38m                kube-proxy
  Normal   NodeHasSufficientPID     39m (x7 over 39m)  kubelet          Node virt-node01 status is now: NodeHasSufficientPID
  Normal   NodeHasSufficientMemory  39m (x8 over 39m)  kubelet          Node virt-node01 status is now: NodeHasSufficientMemory
  Normal   NodeHasNoDiskPressure    39m (x7 over 39m)  kubelet          Node virt-node01 status is now: NodeHasNoDiskPressure
  Normal   NodeHasSufficientPID     38m                kubelet          Node virt-node01 status is now: NodeHasSufficientPID
  Normal   Starting                 38m                kubelet          Starting kubelet.

  Normal   NodeHasSufficientMemory  14m (x8 over 15m)  kubelet          Node virt-node01 status is now: NodeHasSufficientMemory
  Normal   NodeHasNoDiskPressure    14m (x7 over 15m)  kubelet          Node virt-node01 status is now: NodeHasNoDiskPressure
  Normal   NodeHasSufficientPID     14m (x7 over 15m)  kubelet          Node virt-node01 status is now: NodeHasSufficientPID
  Normal   NodeAllocatableEnforced  14m                kubelet          Updated Node Allocatable limit across pods
  Normal   RegisteredNode           13m                node-controller  Node virt-node01  event: Registered Node virt-node01 in Controller

and this is my cluster info
[root@virt-node01 centos]# kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.1", GitCommit:"e4d4e1ab7cf1bf15273ef97303551b279f0920a9", GitTreeState:"clean", BuildDate:"2022-09-14T19:49:27Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.7
Server Version: version.Info{Major:"1", Minor:"25", GitVersion:"v1.25.1", GitCommit:"e4d4e1ab7cf1bf15273ef97303551b279f0920a9", GitTreeState:"clean", BuildDate:"2022-09-14T19:42:30Z", GoVersion:"go1.19.1", Compiler:"gc", Platform:"linux/amd64"}
[root@virt-node01 centos]# kubectl cluster-info
Kubernetes control plane is running at https://<IP_ADDRESS>:6443
CoreDNS is running at https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.
[root@virt-node01 centos]#

Any help is much appreciated.

Same as in https://github.com/kubevirt/kubevirt/issues/8478
Hi @feitnomore, this is a known issue that currently KubeVirt does not work with Kubernetes 1.25 because of the device plugin registration failure. There is already a fix for that, but it is not yet released. You can try with Kubernetes 1.24, that should solve the problem

Hi @vasiliy-ul , just validated on 1.24... you're correct, I don't see the error anymore. I'll try to create a few VMs to make sure everything looks good. Thanks!

Same as in #8478
Hi @feitnomore, this is a known issue that currently KubeVirt does not work with Kubernetes 1.25 because of the device plugin registration failure. There is already a fix for that, but it is not yet released. You can try with Kubernetes 1.24, that should solve the problem

Hi @vasiliy-ul, can you please confirm if the kubevirt release 0.58 works with kubernetes 1.25 as this will be the release planned in October. Also, can you please confirm when will the fix be available for using kubevirt with kubernetes 1.25.
Thanks

@nvinnakota10, well, the fix for the device plugin issue is included in 0.58.0. AFAIK, KubeVirt is not yet tested against k8s 1.25 therefore its probably not 'officially' supported yet. But you can actually try it out as the new release is already available https://github.com/kubevirt/kubevirt/releases/tag/v0.58.0.

@nvinnakota10, well, the fix for the device plugin issue is included in 0.58.0. AFAIK, KubeVirt is not yet tested against k8s 1.25 therefore its probably not 'officially' supported yet. But you can actually try it out as the new release is already available https://github.com/kubevirt/kubevirt/releases/tag/v0.58.0.

@vasiliy-ul, Thanks for the reply. Form your previous comment, it is clear that 0.58 has no official support for k8s 1.25. If that is the case can you please confirm if there will be any other release that will provide official support for k8s 1.25. Can you please let us know when can we expect the release that supports k8s 1.25.

Can you please let us know when can we expect the release that supports k8s 1.25.

TBH, I do not know. Currently, the PRs are not tested against 1.25. Maybe, @dhiller, can comment on that?

Do we have any update on this one? I am planning to go from 1.24 to 1.25.
Thanks!

Do we have any update on this one? I am planning to go from 1.24 to 1.25.
Thanks!

Release 0.58 should contain the fix.

@xpivarc I've seen it was fixed, but according to @vasiliy-ul it was lacking testing. I've run this locally on my machine with: make cluster-up && make cluster-sync and it has worked on 1.25, but I am not sure it is enough to guarantee it'll work on my production cluster.

That's correct. The next release is going to be on 31st January and will be tested against 1.25&6.

@xpivarc , @vasiliy-ul , can you please provide any documentation which gives the information on which kubevirt version supports which K8s version.
We are confused if 0.58 supports k8s 1.25.
It will be really helpful if you can provide the documentation that specifies the compatibility matrix for various versions.
Thanks.

We are confused if 0.58 supports k8s 1.25.

v0.58.0 has not been tested against k8s 1.25. It should work though, but if you need 'official' support statement, you probably need to switch to the latest KubeVirt v0.59.0.

It will be really helpful if you can provide the documentation that specifies the compatibility matrix for various versions.

Yeah, that is now missing. Agree, it would be useful to have such a matrix.

We are confused if 0.58 supports k8s 1.25.

v0.58.0 has not been tested against k8s 1.25. It should work though, but if you need 'official' support statement, you probably need to switch to the latest KubeVirt v0.59.0.

It will be really helpful if you can provide the documentation that specifies the compatibility matrix for various versions.

Yeah, that is now missing. Agree, it would be useful to have such a matrix.

+1
fyi @fabiand @aburdenthehand


Is there a way to retrieve the regional settings of a SPO site?

Hello,
I am looking for a way to retrieve the regional settings assigned to an SPO site.
Is there a command that allows me to perform this operation?
Furthermore, is there a command that allows me to change these?
Thank you,
Patrick

I don't think we currently support that; the m365 spo site get -u "https://contoso.sharepoint.com/" -o json does not return it as it is not part of the REST API. You can use the m365 spo propertybag list -u "https://contoso.sharepoint.com/" to get the vti_defaultlanguage. That will tell you the language settings, but not other settings. Think you are looking at time zone settings as well?

I don't think we currently support that; the m365 spo site get -u "https://contoso.sharepoint.com/" -o json does not return it as it is not part of the REST API. You can use the m365 spo propertybag list -u "https://contoso.sharepoint.com/" to get the vti_defaultlanguage. That will tell you the language settings, but not other settings. Think you are looking at time zone settings as well?

Hi @appieschot,
getting the default language of the site is already something. On the other hand, it would be nice to see and modify the regional settings of the site.
br,
Patrick

Hi @appieschot,
getting the default language of the site is already something. On the other hand, it would be nice to see and modify the regional settings of the site.
br,
Patrick

Shall we investigate if it's possible to extend the current spo site get command to include the necessary information?
If we also want to update support updating these settings, then let's create a separate issue for easier tracing.

Shall we investigate if it's possible to extend the current spo site get command to include the necessary information?
If we also want to update support updating these settings, then let's create a separate issue for easier tracing.

Closing this issue as the discussion is concluded


Expose WiFiStationProvision methods in ESP32Utils

Problem
We need to expose wifi station provisioning methods in ESP32Utils
Summary of Changes
Move (and modify accordingly) methods from NetworkProvisionningServerImpl to ESP32Utils
fixes #1599

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@shana-apple needs restyle merge too


Consider using grey instead of black for the dark mode background to make the icons easier to see

Probably worth seeing what this looks like.

Done in 56329e12fc7cdaf107b072f1e9c185947d50a60d.


[Feature Request]: add another workflow to test the release docker

Describe the problem
it seems that all the workflow tests are run on the source and then the docker is built and pushed.
However, AFAIU according to https://github.com/chroma-core/chroma/issues/797 the installation problem exists in the docker image as well.
The reason is that  bin/docker_entrypoint.sh includes

echo "Rebuilding hnsw to ensure architecture compatibility"
pip install --force-reinstall --no-cache-dir chroma-hnswlib

but this pip install can fail and actually fail in release 0.3.29.
Describe the proposed solution
Adding a workflow to pull the image and test it as an image can detect such problems and avoid releasing a broken image.
Alternatives considered
Another option is to remove the pip install from the entry script, however, it seems that it was done to solve a problem of architecture compatibility according to the comment. Might be that there are other ways to resolve the architecture compatibility. However, given the need to run the pip at entry it might be good to test it.
Importance
would make my life easier
Additional Information
see https://github.com/chroma-core/chroma/issues/797

@ido777 great suggestion!

Thanks.
I am not sure what type of smoke test should approve the docker, however
IMO it should include some different docker versions not only Ubuntu latest
because people use many slimmer dockers such as python slim.
On Tue, 18 Jul 2023 at 7:45 Jeff Huber @.***> wrote:

@ido777 https://github.com/ido777 great suggestion!
—
Reply to this email directly, view it on GitHub
https://github.com/chroma-core/chroma/issues/830#issuecomment-1639447503,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABSAFJIMKUE7K25JWB6JYCLXQYIHLANCNFSM6AAAAAA2NQZRSE
.
You are receiving this because you were mentioned.Message ID:
@.***>

BTW the problem in https://github.com/chroma-core/chroma/issues/797 exists in 0.4.0 as well


Remove use of coerceSize following release of Cryptol 3.2.0

Addresses Issue #126
Removes use of coerceSize from ML-KEM/specification.cry, dependence on common::utils module, and comments pertaining to the above.
Re-tested on standard KATs all OK.

Oh... silly me... see this is a duplicate of PR#107.

Whoops, thanks for the contribution anyway! We had almost identical changes, I just updated #107 to clean up a tiny bit more documentation that you handled and I didn't. I'm hoping to push that through this week so unless this is quite urgent for you, I'm going to close this as a duplicate.

Thanks


Fix allSubclassOf test case

Apparently this has been fixed in https://github.com/phpstan/phpstan-src/commit/73f14dbf82cf054f9ef7f57ffe3a2794e0e659e9 / https://github.com/phpstan/phpstan-src/pull/1039

Thank you!


Prints [?6c at xonsh prompt, which breaks vi-mode

Alacritty seems to do something bizarre to Xonsh when running with 'vi-mode' navigation: after every command all but the last line is cleared (the last line now being at the top) and it then searches history (I-search backward) for the characters 6c.
The only occurrence of 6c in the source is here.
If I remove "VI_MODE": true (or set to false) from my $XDG_CONFIG_DIR/xonsh/config.json then I instead see [?6c at the prompt.
To reproduce characters at prompt, just install xonsh/xonsh and run it in alacritty.
To reproduce wild vi, find the automatically created config.json (either in $HOME/.xonsh, or XDG as above) and add "VI_MODE": true to the JSON object.

Oops, sorry, this is basically just a reproduction of #72 with a different shell.
I discovered more of what the problem was as I wrote the issue, but neglected to search again for similar issues after finding the [?6c aspect.

Closing in favour of #72.


Metrics

Closes:

What changed?

Why?

How did you test it?

Release notes

Documentation Changes

Interesting initial graphic to visualize time distribution executing integration tests. Blue means time spent in BeforeEach(setting up cluster), green means time spent in the integration test itself:


Add profile picture

Add an image to be used as the bot's profile. This is related to the changes being done in the main repo, in https://github.com/tldr-pages/tldr/pull/3619.

Note: I took the liberty to add a yellow circle behind the bot's image, to make it more distinctive and colorful, but I'm happy to remove it if the simpler version is preferred:

With background
No background

I prefer the one without the background. Keeps it neat and clean.

Gotcha. I'll update the files tonight.

Updated :)

Great one @waldyrious!

@agnivade don't forget to actually change the picture in the bot's profile :)
(I'm wondering if the PNG shouldn't be higher-resolution, btw. Let me know if I should make it bigger.)

I think slightly higher resolution will help.

I'll send a new PR asap (probably during the weekend).


Lag when implementing the sliding menu library with fragments

Hey, I have been trying to find the most effective way to implement a list based fly in menu using this library similar to fb and youtube apps . I keep the main view in fragments and when the user presses an item in the side list , I simply replace the fragment with a new fragment depending the selection. Then I call the toggle function to close the sliding menu. But this method produces some noticeable lag when the sliding menu closes and the fragments gets replaced with a new fragment. Is there a better way to replicate the behaviour of youtube and google+ . I am a bit of a newbie android developer so any help is appreciated. Thanks in advance.
Tom

how did you solve this using asynctask?
Can you please describe? It will help a lot :))

@brodarnikola
The elegant solution is to use a loader or async task to load the list.
A good discussion:
http://www.androiddesignpatterns.com/2012/07/loaders-and-loadermanager-background.html
Another good example:
http://www.grokkingandroid.com/using-loaders-in-android/


move folks to alumni listing

Small tweaks to roster

Tested locally in SW meeting and changes look good. Going to merge


appearance dont save when rejoining

i create my character but it does not save.

This is not issue with script and possibly issue with script installation.


Validation fails to build instance

In the example here:
https://cuetorials.com/go-api/loading/#loading-and-printing-cue-code
it says:
// to cause a load error, remove the '&'
// to cause a build error, change '#A' to '#B'
// to cause a validation error, change foo to '1'

However, the third case actually produces a build error. I'm not sure it's possible to reach this line
fmt.Println("Error during validation:", err)

Am I missing something?

Probably not, things have changed since that was written.  I've learned a lot about how all this stuff works while adding def, eval, export, vet commands and flags to hof and making outputs match. I plan to rework the go-api section this month.
Feel free to nag if you don't see it updating!


Feature/bi 5889 implement security headers

Description
Implement recommended security HTTP headers
Jira Ticket
https://companieshouse.atlassian.net/browse/BI-5889
Coding Standards
Code Style Guide: https://github.com/companieshouse/dissolution-web/wiki/Code-Style-Guide
Checklist

[ ] 3 Amigos
[x] Acceptance Criteria met
[x] Branch named {feature|hotfix|task}/{S4-*}
[x] Commit messages are meaningful
[x] Manually tested
[x] All unit tests passing
[x] WAVE accessibility testing tool ran on new or updated pages
[ ] All UI Tests Passing
[ ] Pulled latest master into feature branch
[ ] Sonar Analysis
[x] New Docker environment variables are consistent with those on the Rebel1 environment
[ ] If your pull request depends on any other, please link them in the description

https://github.com/companieshouse/docker-chs-development/pull/83
Screenshots of new or updated views

Console in chrome.

Console in Firefox

@mateuszc-kainos @sapphireduffy Are the above screenshots before and afters? Also, can you attach a screenshot of the actual response headers on a given request to verify that the other ACs are met?

@mateuszc-kainos AC1 outlines the following headers should be present but the above screenshot doesn't show them in the response headers:
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
Cache-control: no-store, no-cache
X-XSS-Protection: 1; mode=block

Please ensure that these are set correctly using helmet


Values cannot be read if keys are emojis

Input
---
😴: YAML Emoji
A: YAML Text
---

🧠:: "Body Emoji"
B:: Body Text

[🦷:: Bracket Emoji]
[C:: Bracket Text]

- 😜:: Bullet Emoji
- D:: Bullet Text

- [🔥:: Bullet Bracket Emoji]
- [E:: Bullet Bracket Text]

#emojiTagTesting

/``` dataview
TABLE A, B, C, D, E, 😴, 🧠, 🦷, 😜, 🔥
FROM #emojiTagTesting
/```

Result

Dataview Version: 0.5.41
Obsidian Version: 0.15.9
OS: Windows, macOS

This is legacy behavior for inline fields since some people do this:
🧠 Thing:: Value

And wanted the emoji to be purely cosmetic (so they could query by "Thing" and not "🧠 Thing").

I see. But then why does it still work in YAML?
Why do they don't want to query with 🧠 Thing? This doesn't add much work, and it doesn't seem to add any fluff

IMO typing emojis is not as fun on desktop as it is on mobile, which is probably why blacksmithgu went with that idea.

On Windows you can open it with windows button+. Not sure about Linux or Mac
On Sat, Aug 20, 2022, 14:28 AB1908 @.***> wrote:

IMO typing emojis is not as fun on desktop as it is on mobile, which is
probably why blacksmithgu went with that idea.
—
Reply to this email directly, view it on GitHub
https://github.com/blacksmithgu/obsidian-dataview/issues/1346#issuecomment-1221250185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTCUXKV4LKJO2QRXM7N3GTV2CCKDANCNFSM567VT34Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

This is legacy behavior for inline fields since some people do this:
🧠 Thing:: Value

And wanted the emoji to be purely cosmetic (so they could query by "Thing" and not "🧠 Thing").

So if it was a conscious decision to make it like this, than it also should be possible to make it so it includes emoji?
Should this issue be changed to a FR? Apparently there are people who want emoji's in their inline fields.
This one is from me.
https://github.com/mdelobelle/metadatamenu/issues/300

This is legacy behavior for inline fields since some people do this:
🧠 Thing:: Value

And wanted the emoji to be purely cosmetic (so they could query by "Thing" and not "🧠 Thing").

So if it was a conscious decision to make it like this, than it also should be possible to make it so it includes emoji? Should this issue be changed to a FR as an optional thing so that both possibilities are covered. Apparently there are people who want emoji's in their inline fields. Me included mdelobelle/metadatamenu#300

any chance this can be transformed into a FR?


ClientModel: Review Azure.Core 2.0 PR prior to final ClientModel release

We should review the implementation of the Azure.Core integration before releasing APIs in ClientModel that we can no longer change.

In the Core v-team meeting on 02/15/2024, we agreed that nothing in the Azure.Core 2.0 integration PR (https://github.com/Azure/azure-sdk-for-net/pull/41773) should affect the public System.ClientModel API surface.  As such, the purpose of the early review has been achieved, and closing this issue.


Profile docs refer to broken bot function

The profile docs mention prof-m command but it seems to be busted and gives a 404 URL

Would be nice if prof-m got fixed instead of having to remove the section.

... But we can only control our end. Removing…


How to write unit test for image resizer using Azure BlobTrigger function

I want to cover unit testing by xUnit test project for the Azure Blob storage output binding for Azure Functions
. The mentioned below code should cover unit test. I search a lot to achieve BlobTrigger unit testing for Azure Functions. Most of the articles are having HttpTrigger functions not for BlobTrigger azure functions.
`using System.Collections.Generic;
using System.IO;
using Microsoft.Azure.WebJobs;
using SixLabors.ImageSharp;
using SixLabors.ImageSharp.Formats;
using SixLabors.ImageSharp.PixelFormats;
using SixLabors.ImageSharp.Processing;
public class ResizeImages
{
[FunctionName("ResizeImage")]
public static void Run([BlobTrigger("sample-images/{name}")] Stream image,
[Blob("sample-images-sm/{name}", FileAccess.Write)] Stream imageSmall,
[Blob("sample-images-md/{name}", FileAccess.Write)] Stream imageMedium)
{
IImageFormat format;
    using (Image<Rgba32> input = Image.Load<Rgba32>(image, out format))
    {
        ResizeImage(input, imageSmall, ImageSize.Small, format);
    }

    image.Position = 0;
    using (Image<Rgba32> input = Image.Load<Rgba32>(image, out format))
    {
        ResizeImage(input, imageMedium, ImageSize.Medium, format);
    }
}

public static void ResizeImage(Image<Rgba32> input, Stream output, ImageSize size, IImageFormat format)
{
    var dimensions = imageDimensionsTable[size];

    input.Mutate(x => x.Resize(dimensions.Item1, dimensions.Item2));
    input.Save(output, format);
}

public enum ImageSize { ExtraSmall, Small, Medium }

private static Dictionary<ImageSize, (int, int)> imageDimensionsTable = new Dictionary<ImageSize, (int, int)>() {
    { ImageSize.ExtraSmall, (320, 200) },
    { ImageSize.Small,      (640, 400) },
    { ImageSize.Medium,     (800, 600) }
};

}`
I'm expecting to cover unit testing for image resizer as well.
Is there any other sample code to achieve this? Please let me know.
Kind regards,
Parthiban

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 910d4732-bb08-d16a-a932-19c6bd1628c2
Version Independent ID: af4358c7-cb5c-bdc7-6433-289f47dc186b
Content: Azure Blob storage output binding for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-blob-output.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @ParthiKarnan This channel is for driving improvements towards MS Docs, If you have any other question specific to product , it would be best if you can create the product issue to the official Azure Functions Repo for better clarity. Once you post your issue on forums, it will have visibility across the community which is a better suited audience for such types of issues.

Understood @DixitArora-MSFT , thanks for your information 🙂!


[BUG] Some placeholders don't work

What is the bug?
Placeholders used when the player is not on any team do not work.
I need help please

Expected Behaviour
.
How to Reproduce
.
Error message
.
Output of /teama version
.
Additional Information
.

using Spanish translations. File appears to be reset when server restarts. Likely an issue with translation files.

there is also a case sensitivity issue with this placeholder

I have fixed the issue with placeholder.notInTeam, the fix will be in the next update.  I cannot reproduce the resetting file issues, they are likely an issue with your server configuration. Try modifying and saving the files while the server is stopped then starting the server.


V3 send message attachments

It's kind of unfortunate that we have to read the file in to memory to get its length only to wrap the bytes in a reader again to do the upload, but I think accepting a Reader is the right thing to do from an API perspective, so a necessary evil?

Yes, probably. It's the same thing I've had to do on the Android side. It's unfortunate, but necessary.
In reality, it's pretty unlikely that we're going to be handed a true streaming reader.


Enhancement:  piping output into retina

This is an enhancement request.  I'm not sure if it is account for in the tree of tasks under the section server support -->
I/O modes --> async-std
The Raspberry Pi project libcamera has an example of running an rtsp server by running their program libcamera-vid and piping it into cVLC to handle the rtsp server portion.  (The rtsp server for cVLC may be LIVE555, but I'm not sure.)
Following instructions at https://www.raspberrypi.com/documentation/accessories/camera.html#libcamera-and-libcamera-apps
which states to run a server, use this command line:
libcamera-vid -t 0 --inline -o - | cvlc stream:///dev/stdin --sout '#rtp{sdp=rtsp://:8554/stream1}' :demux=h264

Instead, I used this modified version which includes the IP address of the Pi server running this command:
libcamera-vid -t 0 --inline -o - | cvlc stream:///dev/stdin --sout '#rtp{sdp=rtsp://<IP_ADDRESS>:8554/stream1}' :demux=h264

I'm having problems with Moonfire-nvr running Retina and shaking hands with the Raspberry Pi Zero 2's instance of the above command line, See Moonfire-nvr Issue #192.
The above consists of two parts: 1) libcamera-vid getting the data from the attached camera then piping it int 2) cVLC.  I'm wondering if Retina could easily be enhancement to accept piped input the way cVLC does so I could accomplishing something like:
  libcamera-vid -t 0 --inline -o - | retina.....

Either accepting STDIN, or some file descriptor one could configure.

Yeah, that sounds like something we can do when adding server support.