Clarify applicability of moderation to unofficial venues

We were discussing this in #rust-community: A lot of Rust projects use the Rust CoC,
however the current CoC contains section about moderation/enforcement which
doesn't apply to these projects. This clarifies that section to avoid confusions
as to who to contact for enforcement.
cc @jdm @rust-lang/core @rust-lang/moderation @rust-lang/community

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

er, cc @bstrie @erickt @skade  since the community ping doesn't work.

general :+1:

Feel free to contact the Rust moderation team if the need arises, however.

So, the reason I put this in here was as an escape hatch for when the CoC violation is from a maintainer. However, you're right, this is a rather strange way of wording it. I'm not sure how to word it otherwise; any suggestions?

@Manishearth Can you lay out the scenario you envision in more detail? You seem to be saying that, if some external project's maintainer is violating the CoC within their own project, the Rust moderation team has a role to play there -- but I don't see what that role is.

(This last issue aside, the overall clarification here is very good.)

Seems like a worthwhile clarification to me as well, I agree with @bstrie and @aturon that the part about contacting the Rust moderation team if this is in use elsewhere can probably be elided for now.

Removed that bit.
So the current wording encourages "contact the rust mod team for any issue on any project"  (for someone unfamiliar with the larger community who reads conduct.html after following a link in a README in an unofficial project). The primary clarification in this PR fixes that; since we don't want situations where someone contacts the mod team for something outside their hands (and we reply  "sorry, can't do anything" -- it's an overall bad user experience). However, in that process we lose the ability to be notified of cases when a maintainer of a project adopting the CoC makes an egregious violation. In such a case it's very likely that the project adopted the CoC just to tick a box, and it would be nice to see if we can provide an alternate venue for this to be handled. Not that we can enforce things on random projects, but we can perhaps open a dialogue with the maintainer or something.
Anyway, it's an unlikely edge case, which we probably don't need to worry about.

Yeah, I'd hope that if another project copies this updated text, they'd also change the list of applicable venues and contact point for moderation.

Added to core team meeting agenda for next week, though if everybody gives a +1 before that we can potentially merge earlier.

+1 from me.

Yeah, I'd hope that if another project copies this updated text, they'd also change the list of applicable venues and contact point for moderation.

The reason I originally brought this up is that many projects have text like "We follow the Rust Code of Conduct" and link directly to the original text. This is easy to do (while feeling like you're making a smart choice) and should really be an anti-pattern, in my opinion.

@jdm Ahha, I didn't think about that (and see that I read @Manishearth's earlier comment too quickly). Tricky!
While I understand @Manishearth's point that the mod team might be able to help with trouble in an external repo, if the premise is that the project maintainer of that repo is not enforcing -- or is perhaps violating -- the CoC, it's hard to see that ending well. I guess my feeling is, as much as I'd like our CoC to be a standard for the whole community (and not just our venues), it's not realistic for us to actually enforce it elsewhere in any real sense, and I think we should avoid offering to get involved.
For the case where the CoC is just linked: I wonder if we can add some text at the bottom, where we currently give attribution, and explicitly ask that other projects who wish to adopt this CoC actually copy it and adjust venues/contact points appropriately, rather than linking. We can also point out that our CoC is updated from time to time, and downstream projects should adopt such changes consciously, rather than just by virtue of linking to ours.

The reason I originally brought this up is that many projects have text like "We follow the Rust Code of Conduct" and link directly to the original text. This is easy to do (while feeling like you're making a smart choice) and should really be an anti-pattern, in my opinion.

IMO one of the reasons for doing this is that you get any improvements to the core CoC for free.
But yeah, perhaps we should put a note at the bottom. How about this?

If you wish to adapt this code of conduct for your own project, consider explicitly mentioning your moderation policy or making a copy with your own moderation policy so as to avoid confusion

IMO one of the reasons for doing this is that you get any improvements to the core CoC for free.

I have mixed feelings about this -- it's sort of akin to one of those agreements where one clause is "and the other party can change the agreement at any time without notification."
I do realize that not every project feels qualified to judge CoC changes themselves -- and indeed, we recently pulled in some "best practice" changes from another source. But I'm not sure that the Rust project is really the right place to centralize these concerns -- better to link to a standalone CoC designed for that purpose, I'd think.

Done.

This shouldn't hold back this issue, but I've got a couple of comments on this: I think adopting a "foreign" Code of Conduct instead of writing your own is a good and a bad thing. Good: you benefit from the work of others. You should still spend time to understand and interpret that work, but writing CoCs yourself without being fully aware on how they work is problematic.  Also, you might adopt something which doesn't quite fit your use case.
For example, I usually recommend user groups to be run "in the faith of the Rust Code of Conduct and using the $you_favourite_coc". I obviously usually recommend http://berlincodeofconduct.org/, but I'm obviously biased.
Maybe adding a statement about how to (not) adopt the CoC would help there.

I'm happy with this generally, except that I do not like that there are 3 italicized paragraphs in this section, which reduces their impact.

Procedural note: the core team discussed this PR today, and everyone is on board with the basic change, modulo a few minor textual edits (which have been left in comments).

Addressed. I moved that paragraph to the bottom, merging it with the other one, and removed italics (unnecessary now that it's at the bottom)

Thanks @Manishearth!


Feature request(s)

Hello Mike,
I don't know the official way to request a small addition to an existing core feature in Home Assistant, I only see a Bug report, or the forum but i can't tag a integration and i don't know if you look there.

Battery Voltage Sensor
Can you also add the "battery_voltage" sensor to the integration?
My door closes heavily and for that I need to make sure the battery voltage is around 9.5v+, however the percentage is not always reliable enough.
I tried it myself through the custom_components folder but i get an error that the instance is already created from __init__.py where i didn't change anything.
sensor.py
from homeassistant.const import (
    PERCENTAGE,
    SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
    EntityCategory,
    VOLTAGE,
)

...

    SensorEntityDescription(
        key="battery_voltage",
        device_class=SensorDeviceClass.VOLTAGE,
        state_class=SensorStateClass.MEASUREMENT,
        entity_category=EntityCategory.DIAGNOSTIC,
        native_unit_of_measurement=VOLT,
    ),

Open house mode
Another small question, is it possible to activate the “open house mode” (Touwtje uit de brievenbus) feature through the API?
I don't think so considering I can't find much about it in the documentation.

Activate Bridge relay
Soon I want to add my porch door to Loqed via the relay contact on the bridge.
Documentation:
https://support.loqed.com/nl/articles/6235933-elektronische-deuren-openen-met-de-loqed-bridge-beta
Can you add the “Bridge relay (BETA)” as a switch/button?

Thanks in advance.
Kind regards,
Robbert van den Berg

I'm not from Loqed or Shelly!
I requested the same function for touwtje a long time ago and they answered me that they wouldn't implement that function.
I also wanted "touwtje" to turn off when the door state turned to Locked.
Also not sure if the same people are still working for loqed.

Hey there! Unfortunately neither am I. With the transfer of  the Loqed IP to Shelly I longer have a direct connection with the company and am waiting what the future holds for our locks. This is the repository I use for testing the integration when I want to add new features to the mainline, so I guess this is as good a place as any. I'll have a look at the battery voltage sensor. Seems straightforward enough.
Open house mode can only be manipulated via the cloud API. It cannot be configured via the local API. SInce  I haven't got a clue whether this API will remain or change I'd rather not tie it to the cloud. Also, I prefer it to work locally without the cloud as much as possible.
The relay functionality also seems to be cloud only. So I can't add that as well :(


[BUG] Jellyfin configuration stopped working - 11/11 update

Describe the bug
Configration of jellyfin with URL and API key does not return unique identifier.
In addition error message if URL format is incorrect is missing from latest release. Rollback to [master-20231109-197d1cf] solves the issue.
To Reproduce
console config:add Jellyfin
add jellyfin configuration:
Server Unique Identifier: Empty string received
Expected behavior
Return unique identifier

@IdefixRC Thanks for the bug report. It's fixed in dev branch, and will be pushed to master in few mins


s4refsimtool web interface

@keskitalo @jdborrill
I have created a first version of the web interface:
http://132-249-238-90.compute.cloud.sdsc.edu/

To exercise the interface, for now only generates the TOML, doesn't actually run the tool
It is automatically generated from a standard notebook using ipywidgets, https://github.com/CMB-S4/s4refsimtool/blob/master/05_ui.ipynb
It is deployed on a Virtual Machine at SDSC, will deploy on Spin for production

TODO next:

implement moving telescopes from Pole to Chile
actually run the tool and give the user a link to download the maps

Please take a look and send feedback.

@zonca, the interface looks fine (any idea why the load time was slow?).  How are you launching the notebook?  Directly with jupyter?  If so, then I have everything needed to work on the docker compose file.

you run voila --port 80 --no-browser  05_ui.ipynb, requirements are toml voila ipywidgets, do not install toml with conda but pip

@zonca when I try to follow the link I get an error: "132-249-238-90.compute.cloud.sdsc.edu unexpectedly closed the connection." Is the interface still working for you?

Yes, it is working now, can you try again? Maybe test in incognito mode?

Also make sure you are not being redirected to https by your browser

It worked the second time around. Looks really neat! Why are the field names truncated like this:

yes, I noticed that, those are default layout settings, I will fix later on
On Thu, Mar 12, 2020 at 11:47 AM Reijo Keskitalo<EMAIL_ADDRESS>wrote:

It worked the second time around. Looks really neat! Why are the field
names truncated like this:
[image: Screen Shot 2020-03-12 at 11 45 05]
https://user-images.githubusercontent.com/596250/76556625-23932680-6457-11ea-84cf-0c38191e905b.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CMB-S4/s4refsimtool/issues/4#issuecomment-598358414,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC5Q4RI2ME6PNLNNOCMMILRHEU4BANCNFSM4LGDW2RQ
.

@jdborrill @keskitalo @tskisner ok, I have a first version of the simulation web interface:
https://132-249-238-90.compute.cloud.sdsc.edu/
sometimes it hangs and I have to restart the process, not sure what is going on.
It is only running 1 SAT band at Pole for now, I will add the rest once the input maps are all available.

focusing on the reference design release first, will get back to work on the web interface later on.


use tab instead of soft tab

Hi @prasmussen, this is related to https://github.com/prasmussen/glot/issues/5. I propose this change to make tabs tabs, instead of 4 spaces, but it is up to you. Hard tabs makes it easier to write makefiles.

Give me a couple of days to deploy this to glot.io.

Thank you!

I had to revert this change after doing some testing (5f98d855c277c31cb6017f76eeccee60751269c2).
Languages like Elm won't compile when tabs are used in the source code and Haskell gives a compiler warning by default when tabs are used.
One way to solve this would be to enable tabs per language or have a setting in the editor to enable  tabs. I might look into this at a later time.


Add support for the delimiter parameter to the List Objects API

Description
Add support for delimiter parameter to the ListObjects and ListObjectsV2 APIs
Related Issue
#89
Tasks

[x] I have signed the CLA.
[x] I have written tests and verified that they fail without my change.

Looks good! Interesting feature!
Thanks for controbuting it right away 👍
I see you‘re still working on it, let us know when you want us to start a review...

I see you‘re still working on it, let us know when you want us to start a review...
I didn't find the test cases right away, since the test class is named AmazonClientUploadIT but it also contains tests unrelated to uploads. So, now there's a test case as well. And checkstyle is happy, too.
I think we're good to go.

Thanks for the quick feedback!
Rebase/squash is done. In addition, I got rid of two spurious diffs that were due to my overzealous eclipse cleanup actions.

Unfortunately, the semantics of the prefix and delimiter parameters - especially if used in conjunction - are not described thoroughly in the AWS specicifation. I therefore mapped them systematically, and doing so, I noticed that there is still some drastic discrepancies between AWS and the the mock implementation.
Please refrain from merging this PR to give me some more time to improve the mock's fidelity.

As promised, I've updated the PR with a few more changes to bring the mocked behaviour in line with AWS.
I moved the relevant test case into a separate class, ListObjectID, which allows me to easily cover many cases using a parameterized test.

I have updated my PR with the changes as per your review. Please let me know if you like them.

Alright, thanks a lot!


spm static deps

Proposes static dependencies in SPM package manifest.

@tanner0101 Can this pull request be closed now?


Reduce the cyclomatic complexity

What would you like to be enhanced
: I would like to reduce the cyclomatic complexity of the overall functions.
Why is this needed
: It is needed for code readability. In fact, golangci-lint has generated the cyclomatic complexity error because of the function, watchHostNetworkInformation().
Proposed solution
: I'm trying to turn code blocks into functions.

An error by golangci-lint
Command
ubuntu@DESKTOP-L3ETGKI:/mnt/d/Dev/Cloud-Barista/cb-larva$ $GOPATH/bin/golangci-lint run

An error about cyclomatic complexity
poc-cb-net/cmd/controller/controller.go:469:1: cyclomatic complexity 16 of func `watchHostNetworkInformation` is high (> 15) (gocyclo)
func watchHostNetworkInformation(wg *sync.WaitGroup, etcdClient *clientv3.Client) {
^

From now on, this issue could be resolved by modularizing the cb-network controller, especially watchHostNetworkInfromation().
Please, refer to controller.go in develop branch.

Resolved.

This issue appeared once again.


caddy: support multi-disk

Another thing I'm not sure is about fedora/linux. Please take a look :(

LGTM


Circle drawing behaviour at small sizes

System specs
gdspy version: 1.6
Python version: 3.7.4
OS: MacOS 10.13.6
CPU: Intel(R) Core(TM) i5-5350U
Current behavior
This issue contains two, likely related, bugs concerned with drawing circular polygons.
When drawing circles where the radius is close to the library precision, there seems to be some (unexpected?) behavior in terms of rounding.
Here is a simple program that draws an array of circular polygons:
import gdspy

lib = gdspy.GdsLibrary(unit=1e-6,  precision=1e-6)
main = lib.new_cell("circle_radius_sweep")

# generate circles with radii near the library precision
r_max = 50 # maximum circle radius (exclusive)
radii = range(1, r_max)
for i, radius in enumerate(radii):
  cell = lib.new_cell('cir_r_%02d' % radius)
  cell.add(
    # parameters use length units defined when library was initialized
    gdspy.Round((0, 0), radius, tolerance=0.01)
  )
  main.add(gdspy.CellReference(cell, (2*r_max*i, 0)))

lib.write_gds("out.gds")

Program output

Circular polygon (radius: 3 library precision units, tolerance: 0.01):

This asymmetry is noticeable with several other small radii, but most are symmetric. Should circular polygons always be x and y symmetric regardless of radius and tolerance? While is behavior is a nuance of this tool, I'm not convinced that this is a bug. I just want to make sure that it is documented here so the author can make that decision.
Edit: After using another GDSII editor and checking the coordinates, the second issues seems to be an issue with the rendering of my GDSII editor (Layout Editor), not this library.
I decided to try some different values for the tolerance parameter and it looks like I found an actual bug here though.
I tried a tolerance value of 0.001.
This seems to have made the circles x and y symmetric for small radii, but there are some artifacts that creep up at the larger radii.

I assume that the splitting of the circular polygons into sub-polygons is necessary to keep the number of points per a polygon within the GDSII specification. However, there are gaps where the polygons meet for some circles.
Impact
For the non-symmetric drawing of circles issue, users can just create their own circular polygon generation tools using the polygon method in this library if it is important to them. Overall, not a significant issue in my opinion.
For the drawing of circles with small tolerances where gaps emerge between the segments, this could be a significant issue.

@JamesWhitehead5 Thank you for your report. Indeed, the issue you find with the small circles in you code sample is expected and it is because of vertex rounding to the closest integer (considering the unit and precision).
Vertex rounding uses numpy.round(vertex * precision / unit). The choice of unit == precision is definitely not usual: it will round all vertices to integer values, so writing any shape of (close to) unit length will result in strong deformations.
If you change precision to 1e-9 in your example, the shapes go back to what you would expect from a circle, because they will retain 3 decimal places of precision after rounding.
You can read a more comprehensive explanation about the significance of unit and precision, take a look at this section of the tutorial.


[machine translation]Incomplete highlighting of the latest version of the code

Thank you to the developer for creating this extension :)
The code highlighting is complete in the first version you released

But in the latest version, it will become as shown in the following picture

And there will also be this pop-up window

Sorry, my English is very plastic and I am a beginner :.(

The Language server protocol run in a different process (and has a window that you posted above), that window hides itself directly after the process is created, but when it observes an error, it show itself again. Given that you could make a screenshot of it, I assume the error message is somewhere at the bottom of this screen. The warnings you see in the screenshot are not important, I just didn't have time to look at them. Could you give me a screenshot of the message that starts with ERROR?

info: AsmDude2LS.Worker[0]
Worker created at: 10/11/2023 21:02:47 +08:00
info: Microsoft.Hosting.Lifetime[0]
Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
Hosting environment: Production
info: Microsoft.Hosting.Lifetime[0]
Content root path: c:\users\29269\appdata\local\microsoft\visualstudio\17.0_d5512606\extensions\tl15c0ek.fpz\Server
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CLAC; doc =Clear the AC flag in the EFLAGS register.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CLWB; doc =Writes back modified cache line containing m8, and may retain the line in cache hierarchy in non-modified state.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG; doc =Compare AL with r/m8. If equal, ZF is set and r8 is loaded into r/m8. Else, clear ZF and load r/m8 into AL.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG; doc =Compare AL with r/m8. If equal, ZF is set and r8 is loaded into r/m8. Else, clear ZF and load r/m8 into AL.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG; doc =Compare AX with r/m16. If equal, ZF is set and r16 is loaded into r/m16. Else, clear ZF and load r/m16 into AX.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG; doc =Compare EAX with r/m32. If equal, ZF is set and r32 is loaded into r/m32. Else, clear ZF and load r/m32 into EAX.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG; doc =Compare RAX with r/m64. If equal, ZF is set and r64 is loaded into r/m64. Else, clear ZF and load r/m64 into RAX.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG8B; doc =Compare EDX:EAX with m64. If equal, set ZF and load ECX:EBX into m64. Else, clear ZF and load m64 into EDX:EAX.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CMPXCHG16B; doc =Compare RDX:RAX with m128. If equal, set ZF and load RCX:RBX into m128. Else, clear ZF and load m128 into RDX:RAX.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m8.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m8.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m16.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m32.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m8.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CRC32; doc =Accumulate CRC32 on r/m64.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTPD2PI; doc =Convert two packed DP FP values from xmm/m128 to two packed signed doubleword integers in mm.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTPI2PD; doc =Convert two packed signed doubleword integers from mm/mem64 to two packed DP FP values in xmm.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTPI2PS; doc =Convert two signed doubleword integers from mm/m64 to two SP FP values in xmm.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTPS2PI; doc =Convert two packed SP FP values from xmm/m64 to two packed signed doubleword integers in mm.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTTPD2PI; doc =Convert two packer DP FP values from xmm/m128 to two packed signed doubleword integers in mm using truncation.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=CVTTPS2PI; doc =Convert two SP FP values from xmm/m64 to two signed doubleword signed integers in mm using truncation.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=EDECVIRTCHILD; doc =This leaf function decrements the SECS VIRTCHILDCNT field.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=EINCVIRTCHILD; doc =This leaf function increments the SECS VIRTCHILDCNT field.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ELDBC; doc =This leaf function behaves lie ELDB but with improved conflict handling for oversubscription.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ELDBC; doc =This leaf function behaves like ELDU but with improved conflict handling for oversubscription.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ENCLS; doc =This instruction is used to execute privileged Intel SGX leaf functions that are used for managing and debugging the enclaves.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ENCLU; doc =This instruction is used to execute non-privileged Intel SGX leaf functions.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ENCLV; doc =This instruction is used to execute privileged SGX leaf functions that are reserved for VMM use. They are used for managing the enclaves.
AsmSignatureTools:parseOperandTypeEnum: unknown content 64
AsmSignatureTools:parseOperandTypeEnum: unknown content 64
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ERDINFO; doc =This leaf function returns type and status information about an EPC page.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ESETCONTEXT; doc =This leaf function sets the ENCLAVECONTEXT field in SECS.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=ETRACKC; doc =This leaf function activates EBLOCK checks.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=FXRSTOR; doc =Restore the x87 FPU, MMX, XMM, and MXCSR register state from m512byte.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=FXRSTOR64; doc =Restore the x87 FPU, MMX, XMM, and MXCSR register state from m512byte.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=FXSAVE; doc =Save the x87 FPU, MMX, XMM, and MXCSR register state to m512byte.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=FXSAVE64; doc =Save the x87 FPU, MMX, XMM, and MXCSR register state to m512byte.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=MASKMOVQ; doc =Selectively write bytes from mm1 to memory location using the byte mask in mm2. The default memory location is specified by DS:DI/EDI/RDI.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=PSHUFW; doc =Shuffle the words in mm2/m64 based on the encoding in imm8 and store the result in mm1.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=RDGSBASE; doc =FSGSBASE
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=STAC; doc =Set the AC flag in the EFLAGS register.
WARNING: parseArch: no arch for str ""
MnemonicStore: CreateAsmSignatureElement: arch is "": mnemonic=WBNOINVD; doc =Write back and do not flush internal caches; initiate writing-back without flushing of external caches.
（I thought it was a setting problem, so I turned on all the options in the plugin settings）。。。。

EMMM，I solved this problem by overwriting the latest version with the original version of the file other than the server, so that the code color is correct and there is code completion


WMTS Imagery Prodiver drops query parameters with subdomains

This was found on this forum thread. I believe this is happening because of the behavior in the requestImage function of WebMapTileServiceImageryProvider.js. If the WMTS imagery provider's _useKvp is false, the templateValues object does not look like it includes the relevant parameters. In my testing it looks like this flag is set to false with subdomains but true without them.
Sandcastle example: link

query URL with parameters (no subdomains): https://maptest.ixstack.net/default_config/service?tilematrix=3&layer=default_layer&style=default&tilerow=3&tilecol=3&tilematrixset=default_grid&format=image%2Fpng&service=WMTS&version=1.0.0&request=GetTile
query URL without parameters (with subdomains): https://maptest2.ixstack.net/default_config/service

In my testing it looks like this flag is set to false with subdomains but true without them.

Can you tell if this is intentional or an oversight? Also, if the fix is simple enough this could be marked as good first issue.


More test improvements

Rewrite CodeGenerationIntegrationTests to use IntegrationTestFact.

Add some new baselines for tests that didn't have a matching Runtime/DesignTime pair

Use overriden GetFileName function instead of static filename property
Remove InitializeTestFileAttribute as no longer needed

Before:

After:

@dotnet/razor-compiler for review please

Remove InitializeTestFileAttribute as no longer needed

Your previous PR inspired me to do this on the tooling side too, in our semantic tokens tests. Very glad to be seeing the back of this :)

Part of https://github.com/dotnet/razor/issues/9535

Close/reopen to kick CI


Massmint price on ahp being multiplied

https://github.com/kodadot/nft-gallery/assets/36627808/fe0296cf-c483-4cdd-86c6-5e3623e88f2f

👋


Fixed compdb, tested with autocomplete-clang

Hello Kev. I agree that compdb is in general a better solution than clang_complete. However, I think a full switch to compdb will not be an easy task. Other packages that use project-wide flags will introduce complications. In the meantime, I believe the clang-flags package should support reading include directories from both clang_complete and compile_commands.json files. I changed the compdb portion of the code to do that. It basically parses the compiler flags in the compile_commands.json file, and appends the include directives to the argument list. With this change, both compdb and clang_complete work for the purposes of setting include directories. With this improvement, you can make a new release without commenting out anything -- and everything should work fine.

Thanks for another patch. It's not clear to me how ignoring all the non-include flags will help matters - certainly on a good chunk of the code I work on it's necessary to have the right defines in place to get sensible completion and linting. If it's the source filename being included in the compdb results that we're trying to avoid, wouldn't it make more sense to explicitly filter this out, and leave all other flags in?

I ignore the non-include flags because client packages (e.g. autocomplete-clang) use project-wide non-include flags. In their current state, they use clang-flags to fetch include flags. When the client packages move to per-file flags, we can easily change clang-flags to filter "-c" and "-o" flags and keep the rest. I made the patch this way so that client packages work fine in their current state.

Thanks.
I've merged it because it's no worse than what was there already. However, I think the point about breaking autocomplete-clang isn't right. A user with clang-flags compatible stuff can simply not set any project-wide flags, and use what clang-flags supplies. This was at least the case for autocomplete-clang and atom-lint when I last looked at them.


Create Consumers page

Create a new consumers page that will live in the main menu. It will contain the 'consumers table' that already exists and add the gateways information.

nathalia will share via teams for some feedback!

Along with PO it's been decided to leave this on a longer hold, so it's going back to backlog. Right now the team will focus on the Gateways work and consumers page will be taken as a separate task in the near future. We would need to do more research on what can be improved from the user's perspective, what is working, what is not, what users expect to do and hace in this screen. Depending on those results, the Consumers page could be modified or re constructed. The design work that has been done regard this page will remain in the figma file for future consultation.


Add support for custom serializer and custom router state type

The current ngrx router-store supports provofing a custom state serializer and working with a custom state type. router-component-store should support this too.

Thank you for your feature request. What's a use case for this?

Currently the used serializer is always MinimalRouterStateSerializer. Sometimes you wish to provide your own serializer as seen in the official router store. Mostly for custom route data aggregations.

I'm not very familiar with @ngrx/router-store but from what I can read, a router state serializer is used to extract more slices of state from RouterStateSnapshot, correct?

Indeed. It's used to allow the user to add more or less state slices to the router state. It can be used to aggreagte data across the route tree and omit unwnated data.

I'm not sure how adding this is better than subscribing through the Router and mapping using observable operators. That seems to be a lot easier than implementing a router serializer. In NgRx RouterStore this functionality was added to support Redux Dev Tools. Currently, NgRx ComponentStore doesn't have native support for Redux Dev Tools.

Even if we were to add it, I worry it would increase the bundle size significantly even for the xx% of applications never using this feature.


M1 staging tests fail with code signing error

Part of https://github.com/flutter/flutter/issues/87508
These builders are newly enabled on M1 bots, but hit code signing error (though no ios device is needed):
Mac_arm64_staging flutter_gallery_ios__compile
Mac_arm64_staging hello_world_ios__compile
Mac_arm64_staging native_ui_tests_ios
Mac_arm64_staging module_test_ios
Mac_arm64_staging ios_content_validation_test
Mac_arm64_staging ios_app_with_extensions_test
Example:
[flutter_gallery_ios__compile] [STDOUT] stderr: Or run on an iOS simulator without code signing
[flutter_gallery_ios__compile] [STDOUT] stderr: ════════════════════════════════════════════════════════════════════════════════
[flutter_gallery_ios__compile] [STDOUT] stderr: No development certificates available to code sign app for device deployment

All these are host only tests, and are not expected for code signing. Shall we skip code signing for all of them @jmagman

It's still signing the apps even though it's not deploying them to any devices.  Can we enable code-signing on these machines to test that it successfully works on M1?

Five of those tests (intel prod) are running against a devicelab bot which support code-signing. Here they are running in host-only mode, and these bots are controlled by chromium team. I am not sure if there is an easy way to enable code-signing there. /cc @godofredoc
As for Mac_arm64_staging module_test_ios, it runs in host only mode now in intel prod bot, which does not support codesigning neither. However it passes: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac module_test_ios/5530/overview. Here is the error message from M1 bot side:
[module_test_ios] [STDOUT] stdout: Failed to build iOS app
[module_test_ios] [STDOUT] stdout: Error output from Xcode build:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     2022-03-24 12:31:33.043 xcodebuild[7531:62156] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk; its version (10.15.6) is below required minimum (11.0) for the macosx platform.
[module_test_ios] [STDOUT] stdout:     2022-03-24 12:31:33.043 xcodebuild[7531:62156] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.6.sdk; its version (13.6) is below required minimum (15.0) for the iphonesimulator platform.
[module_test_ios] [STDOUT] stdout:     2022-03-24 12:31:33.044 xcodebuild[7531:62156] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.0.sdk; its version (14.0) is below required minimum (15.0) for the iphonesimulator platform.
[module_test_ios] [STDOUT] stdout:     2022-03-24 12:31:33.044 xcodebuild[7531:62156] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.6.sdk; its version (13.6) is below required minimum (15.0) for the iphoneos platform.
[module_test_ios] [STDOUT] stdout:     2022-03-24 12:31:33.044 xcodebuild[7531:62156] [MT] DVTSDK: Skipped SDK /opt/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.0.sdk; its version (14.0) is below required minimum (15.0) for the iphoneos platform.
[module_test_ios] [STDOUT] stdout:     ** BUILD FAILED **
[module_test_ios] [STDOUT] stdout:
[module_test_ios] [STDOUT] stdout:
[module_test_ios] [STDOUT] stdout: Xcode's output:
[module_test_ios] [STDOUT] stdout: ↳
[module_test_ios] [STDOUT] stdout:     Writing result bundle at path:
[module_test_ios] [STDOUT] stdout:     	/opt/s/w/ir/x/t/flutter_tools.OjcuTv/flutter_ios_build_temp_dir7nGsIp/temporary_xcresult_bundle
[module_test_ios] [STDOUT] stdout:
[module_test_ios] [STDOUT] stdout:
[module_test_ios] [STDOUT] stdout:     Failed to package /opt/s/w/ir/x/t/flutter_module_test.pOgjhl/hello.
[module_test_ios] [STDOUT] stdout:     Command PhaseScriptExecution failed with a nonzero exit code
[module_test_ios] [STDOUT] stdout:     note: Using new build system
[module_test_ios] [STDOUT] stdout:     note: Planning
[module_test_ios] [STDOUT] stdout:     note: Build preparation complete
[module_test_ios] [STDOUT] stdout:     note: Building targets in parallel
[module_test_ios] [STDOUT] stdout:
[module_test_ios] [STDOUT] stdout:     Result bundle written to path:
[module_test_ios] [STDOUT] stdout:     	/opt/s/w/ir/x/t/flutter_tools.OjcuTv/flutter_ios_build_temp_dir7nGsIp/temporary_xcresult_bundle

The compilation error isn't actually printing.  Filed https://github.com/flutter/flutter/issues/100723.

Run test verbosely to see what the compilation error actually is: https://github.com/flutter/flutter/pull/100724

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8818774660845700801/+/u/run_flutter_gallery_ios__compile/test_stdout
flutter build --release definitely needs a cert unless there's a --no-codesign flag.  For example flutter_gallery_ios__compile  does seem to be successfully codesigning on the intel machine:
[flutter_gallery_ios__compile] [STDOUT] Executing "/opt/s/w/ir/x/w/recipe_cleanup/tmp9s548q47/flutter sdk/bin/flutter build ios --release --tree-shake-icons --split-debug-info=infos/" in "/opt/s/w/ir/x/w/recipe_cleanup/tmp9s548q47/flutter sdk/dev/integration_tests/flutter_gallery" with environment {BOT: true, LANG: en_US.UTF-8}
...
[flutter_gallery_ios__compile] [STDOUT] stdout: Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8818774660845700801/+/u/run_flutter_gallery_ios__compile/test_stdout

Ran these tests in devicelab M1 bots with code signing, here are the brief summary:
Succeeded!
Mac_arm64_staging ios_app_with_extensions_test
Hit same issue as module_test_ios above:
Mac_arm64_staging flutter_gallery_ios__compile
Mac_arm64_staging hello_world_ios__compile
Mac_arm64_staging ios_content_validation_test
Testing failure:
Mac_arm64_staging native_ui_tests_ios
 *** If you believe this error represents a bug, please attach the result bundle at /opt/s/w/ir/x/t/flutter_xcresult
[native_ui_tests_macos] [STDOUT] stdout:
[native_ui_tests_macos] [STDOUT] stderr: 2022-03-24 18:04:23.590 xcodebuild[7114:32508] [MT] IDETestOperationsObserverDebug: 0.011 elapsed -- Testing started completed.
[native_ui_tests_macos] [STDOUT] stderr: 2022-03-24 18:04:23.590 xcodebuild[7114:32508] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
[native_ui_tests_macos] [STDOUT] stderr: 2022-03-24 18:04:23.590 xcodebuild[7114:32508] [MT] IDETestOperationsObserverDebug: 0.011 sec, +0.011 sec -- end
[native_ui_tests_macos] [STDOUT] stdout:
[native_ui_tests_macos] [STDOUT] stdout: Test session results, code coverage, and logs:
[native_ui_tests_macos] [STDOUT] stdout: 	/opt/s/w/ir/x/t/flutter_xcresult.ahYCyn/result
[native_ui_tests_macos] [STDOUT] stdout:
[native_ui_tests_macos] [STDOUT] stderr: Testing failed:
[native_ui_tests_macos] [STDOUT] stderr: 	RunnerTests:
[native_ui_tests_macos] [STDOUT] stderr: 		The test runner encountered an error (Failed to establish communication with the test runner. If you believe this error represents a bug, please attach the result bundle at /opt/s/w/ir/x/t/flutter_xcresult. (Underlying Error: Couldn’t communicate with a helper application. Try your operation again. If that fails, quit and relaunch the application and try again. The connection to service named com.apple.testmanagerd.control was invalidated: failed at lookup with error 3 - No such process.))
[native_ui_tests_macos] [STDOUT] stderr:
[native_ui_tests_macos] [STDOUT] stderr: ** TEST FAILED **
[native_ui_tests_macos] [STDOUT] stderr:
[native_ui_tests_macos] [STDOUT] stdout: Testing started

Run test verbosely to see what the compilation error actually is: #100724

Target aot_assembly_release failed: ProcessException: Bad CPU type in executable

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8818412221879492849/+/u/run_module_test_ios/test_stdout
Looks the same as https://github.com/flutter/flutter/issues/100637

@keyonghan I think you already fixed this by installing Rosetta, can this be closed?


Implementation of the the Wigner thermal conductivity formula

Implemented the thermal conductivity formula derived from the Wigner formulation of thermal transport in solids  [Simoncelli, Marzari, Mauri, Nature Physics, 15 (8), 809 (2019); Simoncelli, Marzari, Mauri arXiv:2112.06897 (2021)].

Thanks @MSimoncelli. I will need to understand how it works, and may not be able to do it very quickly.
Could you write tests and documentations? The documentation would be good to be written as an independent page such as http://phonopy.github.io/phono3py/direct-solution.html. Please ask freely how to do them if you have any questions.

Thanks @atztogo for the prompt reply. I will write the documentation as an independent page. Also, I would need more information about tests. I am available to discuss via zoom if needed. Thank you very much.

Manual merging process can be seen at PR #83.

I close this PR because the code is merged into develop branch. See PR #83.


Autocompletion broken

This was reported at #29 by @k4nar . I'm facing the same issue so here is a proper issue for it.
Autocompletion for files, git etc is not working with this plugin loaded. Unloading the plugin fixes the problem.
I'm using antigen.
Will add more info when I have time to take a deeper look at the problem.

+1

PR?

@faceleg  I will try fix it more robust, when I will  understand root of the problem.
Thanks

:dancer:

I think I have the same problem, the "tab" completion doesn't work.
I am using Antigen & OhMyZsh.
I use @maksimr fix as a workaround.
Here is my .zshrc:
source ~/.zsh/antigen/antigen.zsh

# Load the oh-my-zsh's library.
antigen use oh-my-zsh

# Bundles from the default repo (robbyrussell's oh-my-zsh).
antigen bundle git
antigen bundle command-not-found

# Syntax highlighting bundle.
antigen bundle zsh-users/zsh-syntax-highlighting
unset COMPLETION_WAITING_DOTS

# Fish-like suggestions bundle
antigen bundle tarruda/zsh-autosuggestions

# Right arrow to the entire suggestion
AUTOSUGGESTION_ACCEPT_RIGHT_ARROW=1

# Enable autosuggestions automatically
zle-line-init() {
	zle autosuggest-start
}
zle -N zle-line-init

# Load the theme.
antigen theme fishy

# Tell antigen that you're done.
antigen apply

# use ctrl+t to toggle autosuggestions(hopefully this wont be needed as
# zsh-autosuggestions is designed to be unobtrusive
bindkey '^T' autosuggest-toggle

# Use vim or gvim with v
if [[ -n $DISPLAY ]]; then
	alias v='gvim'
else
	alias v='vim'
fi

There's a rewrite underway in PR #91. It's available on branch v0.1.x. Please try using that branch, and let me know if it solves your problem.

It seems i doesn't, and doesn't change anything but the syntax of .zshrc file I had to change, I just followed the instructions you gave me, I still have not standard completion.
I also stopped using this fish-like completion some time ago.

I'm having no tab autocompletion either, even on the v0.1.x branch

@Minizarbi @bermanmaxim Can you specify exactly what is not working for you?
Does this fail for you?

I typed cd /A then pressed tab to autocomplete to cd /Applications/.

Then deleted back to cd / and pressed tab again. This brought up the list below of suggestions. Pressing tab then cycles through the suggestions.

It would also be helpful to know which version of zsh you're running, which os, other plugins you have configured, other .zshrc configurations.
A recorded gif of the specific problem would be awesome as well.
Thanks

Ok, I am able to reproduce this by adding compinit to my .zshrc.
autoload -Uz compinit && compinit
Looking in to it.

Should be fixed with cd705a0. There are still minor issues with the buffer displaying incorrectly while inside menu selection, but it should work for the most part. Please pull and try again.

My zsh version: zsh 5.2 (x86_64-unknown-linux-gnu)
System: ArchLinux 4.3.3-3
The problem:
Just the tab key does nothing.
I start typing cd /, some fish-like suggestions appears (in gray) but I just press tab, and nothing happens, the fish suggestion is still there.
I can accept the fish suggestion pressing →, but tab is still not working.
It works when I don't use zsh-autosuggestions.
My .zshrc:
source ~/.zsh/antigen/antigen.zsh

# Load the oh-my-zsh's library.
antigen use oh-my-zsh

# Bundles from the default repo (robbyrussell's oh-my-zsh).
antigen bundle git
antigen bundle command-not-found

# Syntax highlighting bundle.
antigen bundle zsh-users/zsh-syntax-highlighting
unset COMPLETION_WAITING_DOTS

# Fish-like suggestions bundle
antigen bundle tarruda/zsh-autosuggestions --branch=v0.1.x zsh-autosuggestions.zsh

# Enable autosuggestions automatically
zle-line-init() {
#	zle autosuggest-start
	autosuggest_start
}
zle -N zle-line-init

# Load the theme.
antigen theme fishy

# Tell antigen that you're done.
antigen apply

Thanks for the details. I'll take a look at this tonight.
Are you positive you're running the most recent version of the 0.1.x branch? This sounds a lot like the behavior pre-cd705a0.

I just removed my antigen repos about zsh-autosugg, and installed it again from your branch with antigen bundle tarruda/zsh-autosuggestions --branch=v0.1.x zsh-autosuggestions.zsh and now it (the tab completion) seems to work, thank you, so I guess now it has to be accepted as a PR or something like this?


checkout: apply: use onerror instead of allow_missing

This gives better control to the user.

Codecov Report
Patch coverage has no change and project coverage change: +0.01 :tada:

Comparison is base (ea75d92) 61.01% compared to head (9b137c9) 61.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   61.01%   61.03%   +0.01%
==========================================
  Files          56       56
  Lines        3804     3798       -6
  Branches      675      560     -115
==========================================
- Hits         2321     2318       -3
- Misses       1345     1348       +3
+ Partials      138      132       -6

Impacted Files
Coverage Δ

src/dvc_data/index/checkout.py
40.97% <ø> (-0.26%)
:arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


version file does not correspond to anything

Hello,
The version file in the root of this repo appears to be very old. Can we delete it or keep it up to date with the release version?
Thanks!

Thank you for pointing this out @jbooherl! We've removed this version file to avoid confusion: b2a3f9c5b01d2914eafa2038561715b4c803e326


github/workflows: add static library

To enable https://github.com/xlsynth/xlsynth-crate/issues/1

Those look suspiciously smalls :)

turns out it's a currently limitation of bazel https://github.com/bazelbuild/bazel/issues/1920 being fixed in https://github.com/bazelbuild/bazel/pull/16954


Clarify sim results saving and retrieving, comparing results

The wireframe and documents do not have story for saving and retrieving, comparing results
We need to discuss how to implement this, currently shiny offers below persistent storage options (server side)
for simplicity, we may just use local file system, but may also need client side storage to save users' history (what names they chose)
https://github.com/trestletech/shinyStore was used in the demo to store  which seems promising but further experimenting on how they work with modules need to be done.
In this ticket, we need to clarify each button's story:

some example questions:

Whart are the summary plot pdf, should this be produced by PACE package?
What are the files included in the storage (one csv for each scenarios or all in one csv,  and cross scenario comparison plots?)
What does comparison look like, how many can be selected to compare?

PACE-HRH UI Wireframe Option C v2.pdf
Response to VW re MVP design.docx
PACE-HRH UI paper prototype v1 itemized adjustments.docx

Update:

Remove "save results for later comparision" button and use "Select previous results" to redirect to the result view page

We have discussed and decided to implement in the following ways:
1.) Sample result plots using summary stats are currently printed to pdf, can be changed based on user feedback.
2.) Files for each run are collected and zipped into one folder named after the run. Csv files for config used, by-run simulation results, and summary stats are included in the folder. And user can choose downloading location by changing the download setting in browser. (We will try to control this when deploying from Chrome browser)
3.) Sample result plots are displayed using facets, allowing comparison for up to 4 different runs.


dlfydev/markdown is deprecated

Should link to michelf/php-markdown instead.
$ composer require dflydev/markdown >=1.0.3
Using version ^1.0 for dflydev/markdown
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
  - Installing dflydev/markdown (v1.0.3)
    Downloading: 100%

Package dflydev/markdown is abandoned, you should avoid using it. Use michelf/php-markdown instead.

Cool, thanks for letting me know. I've removed it.


Invalid expression term on nullable property

For a reason, I have some string properties on my document type, as these have a Label as their editor. The values of these properties are imported (and should not be editable in Umbraco). I'm using ModelsBuilder but when I define the following on my model, the ModelBuilder fails with the message below.
[IgnorePropertyType("purchasePrice")]
[IgnorePropertyType("resalePrice")]
public partial class ProductVariantContentModel
{
    [ImplementPropertyType("purchasePrice")]
    public decimal? PurchasePrice
    {
        get
        {
            if (this.HasValue("purchasePrice") == false)
                return null;

            var value = this.GetPropertyValue<string>("purchasePrice");
            if (decimal.TryParse(value, NumberStyles.Any, CultureInfo.InvariantCulture, out decimal result))
                return result;

            return null;
        }
    }

    [ImplementPropertyType("resalePrice")]
    public decimal? ResalePrice
    {
        get
        {
            if (this.HasValue("resalePrice") == false)
                return null;

            var value = this.GetPropertyValue<string>("resalePrice");
            if (decimal.TryParse(value, NumberStyles.Any, CultureInfo.InvariantCulture, out decimal result))
                return result;

            return null;
        }
    }
}

This results in the following message:
UmbracoModelsBuilder: UmbracoModelsBuilder failed to generate code: Exception: Response status code does not indicate success (InternalServerError)
{"Message":"An error has occurred.","ExceptionMessage":"Invalid expression term 'decimal'","ExceptionType":"Umbraco.ModelsBuilder.Building.CompilerException","StackTrace":"   at Umbraco.ModelsBuilder.Building.Compiler.ThrowExceptionFromDiagnostic(String path, String code, Diagnostic diagnostic) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder\\Building\\Compiler.cs:line 161\r\n   at Umbraco.ModelsBuilder.Building.Compiler.<>c__DisplayClass12_0.<GetCompilation>b__0(KeyValuePair`2 x) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder\\Building\\Compiler.cs:line 48\r\n   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()\r\n   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)\r\n   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)\r\n   at Umbraco.ModelsBuilder.Building.Compiler.GetCompilation(String assemblyName, IDictionary`2 files, SyntaxTree[]& trees) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder\\Building\\Compiler.cs:line 46\r\n   at Umbraco.ModelsBuilder.Building.CodeParser.Parse(IDictionary`2 files, IEnumerable`1 references) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder\\Building\\CodeParser.cs:line 38\r\n   at Umbraco.ModelsBuilder.Api.ApiHelper.GetModels(String modelsNamespace, IDictionary`2 files) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder\\Api\\ApiHelper.cs:line 16\r\n   at Umbraco.ModelsBuilder.Api.ModelsBuilderApiController.GetModels(GetModelsData data) in D:\\d\\Zbu ModelsBuilder-7\\Umbraco.ModelsBuilder.Api\\ModelsBuilderApiController.cs:line 65\r\n   at lambda_method(Closure , Object , Object[] )\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass10.<GetExecutor>b__9(Object instance, Object[] methodParameters)\r\n   at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ExecuteAsync(HttpControllerContext controllerContext, IDictionary`2 arguments, CancellationToken cancellationToken)\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Filters.AuthorizationFilterAttribute.<ExecuteAuthorizationFilterAsyncCore>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()"}
UmbracoModelsBuilder:    at Umbraco.ModelsBuilder.Api.ApiClient.EnsureSuccess(HttpResponseMessage result)
   at Umbraco.ModelsBuilder.Api.ApiClient.GetModels(Dictionary`2 ourFiles, String modelsNamespace)
   at Umbraco.ModelsBuilder.CustomTool.CustomTool.UmbracoModelsBuilder.GenerateRaw(String wszInputFilePath, String wszDefaultNamespace, IntPtr[] rgbOutputFileContents, UInt32& pcbOutput, String& errMsg)

Commenting out the properties resolves the issue, and having them as nullable too. But that's not really an option...

going to guess here... what happens if you replace the lines
if (decimal.TryParse(value, NumberStyles.Any, CultureInfo.InvariantCulture, out decimal result))
  return result;

with
decimal result;
if (decimal.TryParse(value, NumberStyles.Any, CultureInfo.InvariantCulture, out result))
  return result;

?
The error we're seeing is, we fail to parse your code. And yet, your code is valid. But the syntax you used was introduced in C# version I-cannot-remember. In order for your syntax to be supported, you may want to experiment with the Umbraco.ModelsBuilder.LanguageVersion configuration setting (see Install And Configure) and use something like CSharp7.
Does this help?

Yup, that helps! I was under the impression that it was due to the nullable return type, but indeed it was the usage of the so-called Out variables introduced in C# 7.
We have ModelsBuilder 3.0.10 installed but changing the Umbraco.ModelsBuilder.LanguageVersion value to CSharp7 throws an "Invalid language version 'CSharp7'" ConfigurationErrorsException. In what version of ModelsBuilder is support for C# 7 introduced? Or am I missing another setting somewhere?
[ConfigurationErrorsException: Invalid language version "CSharp7".]
   Umbraco.ModelsBuilder.Configuration.Config..ctor() in D:\d\Zbu ModelsBuilder-7\Umbraco.ModelsBuilder\Configuration\Config.cs:126
   Umbraco.ModelsBuilder.Configuration.<>c.<ModelsBuilder>b__1_0() in D:\d\Zbu ModelsBuilder-7\Umbraco.ModelsBuilder\Configuration\UmbracoConfigExtensions.cs:24
   System.Threading.LazyInitializer.EnsureInitializedCore(T& target, Func`1 valueFactory) +21
   Umbraco.ModelsBuilder.Configuration.UmbracoConfigExtensions.ModelsBuilder(UmbracoConfig umbracoConfig) in D:\d\Zbu ModelsBuilder-7\Umbraco.ModelsBuilder\Configuration\UmbracoConfigExtensions.cs:25
   Umbraco.ModelsBuilder.Umbraco.LiveModelsProvider.get_IsEnabled() in D:\d\Zbu ModelsBuilder-7\Umbraco.ModelsBuilder\Umbraco\LiveModelsProvider.cs:26
   Umbraco.ModelsBuilder.Umbraco.LiveModelsProviderModule.Install() in D:\d\Zbu ModelsBuilder-7\Umbraco.ModelsBuilder\Umbraco\LiveModelsProvider.cs:132

[InvalidOperationException: The pre-application start initialization method Install on type Umbraco.ModelsBuilder.Umbraco.LiveModelsProviderModule threw an exception with the following error message: Invalid language version "CSharp7"..]
   System.Web.Compilation.BuildManager.InvokePreStartInitMethodsCore(ICollection`1 methods, Func`1 setHostingEnvironmentCultures) +850
   System.Web.Compilation.BuildManager.InvokePreStartInitMethods(ICollection`1 methods) +162
   System.Web.Compilation.BuildManager.CallPreStartInitMethods(String preStartInitListPath, Boolean& isRefAssemblyLoaded) +128
   System.Web.Compilation.BuildManager.ExecutePreAppStart() +170
   System.Web.Hosting.HostingEnvironment.Initialize(ApplicationManager appManager, IApplicationHost appHost, IConfigMapPathFactory configMapPathFactory, HostingEnvironmentParameters hostingParameters, PolicyLevel policyLevel, Exception appDomainCreationException) +820

[HttpException (0x80004005): The pre-application start initialization method Install on type Umbraco.ModelsBuilder.Umbraco.LiveModelsProviderModule threw an exception with the following error message: Invalid language version "CSharp7"..]
   System.Web.HttpRuntime.FirstRequestInit(HttpContext context) +523
   System.Web.HttpRuntime.EnsureFirstRequestInit(HttpContext context) +107
   System.Web.HttpRuntime.ProcessRequestNotificationPrivate(IIS7WorkerRequest wr, HttpContext context) +688

Roslyn as shipped with ModelsBuilder for v7 stops at CSharp6 and does not support C# 7 indeed.
And... there is no plan to change this for v7.

Allright, then this issue can be closed ;-)
And I think one should update the documentation on ModelsBuilder with this limitation.


OSGI metadata

jib-core (the library) will eventually need OSGI metadata to be used in Eclipse and other OSGI environments.

MANIFEST.MF with OSGi metadata draft:
Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Version: <version>
Bundle-Name: Jib
Bundle-Vendor: Google
Bundle-SymbolicName: com.google.cloud.tools.jib; singleton:=true
Export-Package: com.google.cloud.tools.jib
Bundle-Description: Build containers

We will use the Gradle OSGi plugin (which uses Bnd) to generate most of these automatically.

The Gradle-provided osgi plugin does most of what we need, but the packages are exported with a .SNAPSHOT qualifier:
Export-Package: com.google.cloud.tools.jib;version="0.1.0.SNAPSHOT";uses:="…",
  com.google.cloud.tools.jib.async;version="0.1.0.SNAPSHOT";uses:="…",
  com.google.cloud.tools.jib.blob;version="0.1.0.SNAPSHOT";uses:="…",

Which in OSGi terms meants that these packages sort after 0.1.0.  What's odd is the maven-bundle-plugin also uses bnd under the hood, but strips off the qualifier.
I'm investigating the use of the bnd plugin instead.

Using the bnd plugin looks to Do The Right Thing.

I think it's Google LLC: https://github.com/GoogleCloudPlatform/appengine-plugins-core/issues/685


Add "overrides" variable option to RunJobRequest

The problem:

I would like to utilize the overrides variable available in the RunJobRequest: https://cloud.google.com/run/docs/reference/rpc/google.cloud.run.v2#google.cloud.run.v2.RunJobRequest
It is available in the underlying Google API library, but hasn't been placed into this one.
More specifically, I would like to add the "overrides" variable to the apache/airflow CloudRunExecuteJobOperator, but cannot do so until this library has been updated: https://github.com/apache/airflow/pull/34874

The solution:

Allow for the run_job function in the Job client to accept an overrides variable as a parameter and send it to RunJobRequest.

Alternatives:

I believe this is the only way to override the command used in a Cloud Run Job outside of using an HTTP request. I would like to utilize more libraries, but currently cannot do so as I am limited to HTTP.

I was mistaken, this work has been completed and will be released in v0.10.0.


Code cleanup

Propagate @deprecated annotation to implementations
Remove redundant "static final" definition from interface
Use Collections.emptyMap instead of Collections.EMPTY_MAP to preserve type

@pavolloffay - The latest in the saga.  Reduced to just the items that everyone immediately agrees upon and targeting the new v0.31.0 branch.

Coverage remained the same at 78.598% when pulling 86395cd0431900dd7b6fff40d4e2602727532e53 on mcumings:v0.31.0-nits into fb86feecc4852f8c65304667ca0f6660da98391c on opentracing:v0.31.0.

hmm.. surprising that it pulled in those other commits when I based the code on the HEAD of 0.31.0.

Fixed by re-pushing the branch.  Much better...

Coverage remained the same at 78.598% when pulling a774afb2bafe7d6e435552791340b7a526e68b25 on mcumings:v0.31.0-nits into 27327e91ba30b2280ed86afe9f65583c5c3db95f on opentracing:v0.31.0.

LGTM,
but why to 0.31.0 branch? I would prefer merge it to the master as these changes are not based on 0.31.0.

I'm splitting this out of the work previously committed under https://github.com/opentracing/opentracing-java/pull/181 to make the changes distinct rather than rolling them in with the other conceptual change.

It would be great if we could get this merged and move on to timestamps. I think its fine to make another PR to cherry-pick this commit onto master as well, since it's valid in both 0.31 and 0.30.

Okay, sure.  I'm not sure what branching model you folks are operating under so I'll just do as I'm told. :)
I've raised https://github.com/opentracing/opentracing-java/pull/199 for master.

@mcumings thanks, I think we could just close and merge #199. The next release will be rebased with the master.

Okay, like I said, I don't know what the branching strategy is here.  Closing this issue in favor of #199.


add getDistance(..) to VehicleRoutingTransportCosts?

As distance is and will be more and more important (electric vehicles), I think it makes sense to add a getDistance(..) (TransportDistance) method to one of the most important interfaces VehicleRoutingTransportCosts. It would break your code, but it would make many things much simpler.
Any thoughts on this?

It's probably not a big fix to make in the code that will break (at least it's not a big fix in my code). Why do electric vehicles need distance though as opposed to a cost (which could use distance internally in the getCost method)?

You are correct, internally distance is usually used anyway. But often one needs the distance from A to B, not only when analysing the solution, but also for specific constraints. For example, I want to add a vehicle dependent max-distance constraint here (which is very important for electric vehicles). If this should be part of the core, we need to make sure that we can get the distance. If it is part of VehicleRoutingTranportCosts, it is ensured.
The other possibility is to let the user add the (a ready to use) max distance constraint. The user then needs to provide the distances from A to B as well as the max distances for each vehicle. Then I actually do not need to change anything. Would you prefer the second option?

You make a good point that its handy to have distance available if you're creating constraints that use distance...
If its only going to be used on specific constraints, then you could add a default getDistance method to the VehicleRoutingTransportCosts interface (assuming you're using java 8, I think default interface methods only exist in 8) that throws an java.lang.UnsupportedOperationException ? This way you don't break existing code and you only hit the exception if you use a constraint that requires distance. The exception then lets the user know they need to implement the distance method to use that constraint...?

Good to know that you would find it handy as well :). I am thinking about the default method, but maybe I just add it to the VehicleRoutingTransportCost interface. I am still not sure yet ... I could also add a way to the VehicleRoutingProblem to set a distance matrix, thus beside .setRoutingCost(..), .setActivityCosts and would be setDistanceMatrix(..). However, distance is somehow related to TransporTime and Costs and would thus fit into VehicleRoutingTransportCost ... hmm

related to https://github.com/graphhopper/jsprit/commit/f8ea447cb9f6934c41650760c47e07fdbb1d62c9
This way you can add a maxDistance constraint. However, it is currently loosely coupled rather than tightly integrated (which might makes sense as well and might require the getDistance(..) interface as well).

+1 for adding getDistance to VehicleRoutingTransportCosts.


Revert "Render math with MathJax (#12028)"

This reverts commit 6dec6a6eab208e0cc62128b86c29af83b43c5975 due to https://sentry.io/share/issue/0d4ebb26d3c648eb97987f96a05c0047/
(cc @miketheman)

Well, that was certainly not intended.
I'll read more about the cache busting approach, but this makes me think that it might be preferable to use the CDN approach, and scope it very narrowly to specific MathJax resources and hashes.

Static file hosting in Warehouse doesn't work unless you send it through the static asset pipeline to generate a manifest file.


Conflict in 3.7 and Nvidia platform

After updating to the latest ROCm version (3.7), we encounter the following compilation errors when trying to compile hipCUB on an Nvidia platform (CUDA 10.2)
/usr/local/cuda/include/cuda_fp16.h(1430): error: inline specifier allowed on function declarations only
/usr/local/cuda/include/cuda_fp16.h(1430): error: declaration is incompatible with overloaded function "__shfl_sync"
/usr/local/cuda/include/sm_30_intrinsics.h(133): here
/usr/local/cuda/include/cuda_fp16.h(1430): error: incomplete type is not allowed
/usr/local/cuda/include/cuda_fp16.h(1430): error: expected a ")"
/usr/local/cuda/include/cuda_fp16.h(1431): error: inline specifier allowed on function declarations only
/usr/local/cuda/include/cuda_fp16.h(1431): error: declaration is incompatible with overloaded function "__shfl_up_sync"
/usr/local/cuda/include/sm_30_intrinsics.h(135): here
...

We've tested the same code on previous ROCm versions (3.5 and below), and the same problem isn't apparent. We'll try to provide a log file soon, but can you try to reproduce this on your end?

@AJcodes Sorry for the lack of response. Please try latest ROCm 6.0.2 (HIP 6.0.32831) to see if your issue still exists? If resolved, please close the ticket. Thanks.


Cannot build sk4d DLLs

I would like to contribute to the skia4delphi project, but am unable to build the sk4d DLLs (for Windows) so I cannot test my contributions.
I tried on both my production machine, and a bare Windows 10 virtual machine with just Delphi and Git installed.
On the virtual machine, I created the following setup (as recommended by the sk4d-build.bat file):

Installed Python 3.11.4
Installed LLVM 16.0.6 (and added it to the path)
Installed Build Tools for Visual Studio 2022 (C++ part only, with standard options)

Error 1
Running sk4d-build --targets win32 generated the following output:
c:\skia4delphi\Externals\skia>sk4d-build --targets win32
INFO: Building for Win32.
ERROR: Unable to generate build files for Win32 target: ERROR at //gn/BUILDCONFIG.gn:161:23: Script returned non-zero exit code.
  clang_win_version = exec_script("//gn/highest_version_dir.py",
                      ^----------
Current dir: c:/skia4delphi/Externals/skia/temp/Win32/Release/
Command: C:/Users/erik/AppData/Local/Programs/Python/Python311/python.exe c:/skia4delphi/Externals/skia/gn/highest_version_dir.py "C:\Program Files\LLVM/lib/clang" "[0-9]+\.[0-9]+\.[0-9]+"
Returned 1.

Reason: the script expects the LLVM/lib/clang directory to contain a subdirectory with a version number in x.y.z format, but it contains a subdirectory called 16
Resolution: I renamed this subdirectory to 16.0.6

Error 2
Now I get the following compilation error:
FAILED: obj/src/ports/fontmgr_win.SkScalerContext_win_dw.obj
"C:\Program Files\LLVM/bin/clang.exe" --driver-mode=cl /nologo /showIncludes /FC -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -DWIN32_LEAN_AND_MEAN -DNOMINMAX -DNDEBUG -DSK_ENABLE_SKSL -DSK_ENABLE_PRECOMPILE -DSK_GAMMA_APPLY_TO_A8 -DSK_USE_VMA -DSKIA_IMPLEMENTATION=1 -I../../.. /MT /wd4244 -Wno-attributes /bigobj /utf-8 -imsvc "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/shared" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/ucrt" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/um" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/winrt" /O2 /Zc:inline -m32 /std:c++17 /GR- /c ../../../src/ports/SkScalerContext_win_dw.cpp /Foobj/src/ports/fontmgr_win.SkScalerContext_win_dw.obj /Fd"obj/fontmgr_win_c.pdb"
In file included from ../../../src/ports/SkScalerContext_win_dw.cpp:36:
In file included from ../../..\src/sfnt/SkOTTable_EBLC.h:13:
In file included from ../../..\src/sfnt/SkOTTable_EBDT.h:13:
../../..\src/sfnt/SkOTTable_head.h(143,15): error: static assertion expression is not an integral constant expression
static_assert(offsetof(SkOTTableHead, glyphDataFormat) == 52, "SkOTTableHead_glyphDataFormat_not_at_52");
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/ucrt\stddef.h(47,31): note: expanded from macro 'offsetof'
        #define offsetof(s,m) ((::size_t)&reinterpret_cast<char const volatile&>((((s*)0)->m)))
                              ^
../../..\src/sfnt/SkOTTable_head.h(143,15): note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression

Reason: the offsetof macro in the stddef.h file of the Windows 10 Kit does not result in an integral constant expression
Resolution: in skia4delphi/Externals/skia/gn/skia/BUILD.gn, I added the define _CRT_USE_BUILTIN_OFFSETOF to the list of defines that also contains _CRT_SECURE_NO_WARNINGS

Warnings
Now I get a lot of warnings like this:
[33/1785] compile ../../../src/gpu/ganesh/ClipStack.cpp
In file included from ../../../src/gpu/ganesh/ClipStack.cpp:29:
In file included from ../../..\src/gpu/ganesh/effects/GrTextureEffect.h:15:
In file included from ../../..\src/gpu/ganesh/glsl/GrGLSLFragmentShaderBuilder.h:14:
../../..\src/gpu/ganesh/glsl/GrGLSLShaderBuilder.h(107,8): warning: sizeof on array function parameter will return size of 'const char *' instead of 'const char[]' [-Wsizeof-array-argument]
       va_start(args, format);
       ^
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include\stdarg.h(20,18): note: expanded from macro 'va_start'
#define va_start __crt_va_start
                 ^
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include\vadefs.h(199,99): note: expanded from macro '__crt_va_start'
    #define __crt_va_start(ap, x) ((void)(__vcrt_assert_va_start_is_not_reference<decltype(x)>(), __crt_va_start_a(ap, x)))
                                                                                ^
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include\vadefs.h(109,75): note: expanded from macro '__crt_va_start_a'
    #define __crt_va_start_a(ap, v) ((void)(ap = (va_list)_ADDRESSOF(v) + _INTSIZEOF(v)))
                                                                          ^
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include\vadefs.h(107,44): note: expanded from macro '_INTSIZEOF'
    #define _INTSIZEOF(n)          ((sizeof(n) + sizeof(int) - 1) & ~(sizeof(int) - 1))

Error 3
Ignoring these warnings, I get the following error:
[318/1785] compile ../../../src/opts/SkOpts_hsw.cpp
FAILED: obj/src/opts/hsw.SkOpts_hsw.obj
"C:\Program Files\LLVM/bin/clang.exe" --driver-mode=cl /nologo /showIncludes /FC -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -DWIN32_LEAN_AND_MEAN -D_CRT_USE_BUILTIN_OFFSETOF -DNOMINMAX -DNDEBUG -DSK_ENABLE_SKSL -DSK_ENABLE_PRECOMPILE -DSK_GAMMA_APPLY_TO_A8 -DSK_USE_VMA -DSKIA_IMPLEMENTATION=1 -I../../.. /arch:AVX2 /MT /wd4244 -Wno-attributes /bigobj /utf-8 -imsvc "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/shared" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/ucrt" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/um" -imsvc "C:\Program Files (x86)\Windows Kits\10/Include/10.0.22621.0/winrt" /O2 /Zc:inline -m32 /std:c++17 /GR- /c ../../../src/opts/SkOpts_hsw.cpp /Foobj/src/opts/hsw.SkOpts_hsw.obj /Fd"obj/hsw_c.pdb"
In file included from ../../../src/opts/SkOpts_hsw.cpp:14:
../../..\src/opts/SkRasterPipeline_opts.h(356,16): error: no matching function for call to '_mm256_fmadd_ps'
        return _mm256_fmadd_ps(f,m,a);
               ^~~~~~~~~~~~~~~
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC/Tools/MSVC/14.37.32822/include\immintrin.h(1382,24): note: candidate function not viable: no known conversion from 'F' (aka 'V<float>') to '__m256' for 1st argument
extern __m256  __cdecl _mm256_fmadd_ps(__m256, __m256, __m256);
                       ^
In file included from ../../../src/opts/SkOpts_hsw.cpp:14:
../../..\src/opts/SkRasterPipeline_opts.h(356,16): error: no viable conversion from returned value of type '__m256' to function return type 'F' (aka 'V<float>')
        return _mm256_fmadd_ps(f,m,a);
               ^~~~~~~~~~~~~~~~~~~~~~
../../..\src/opts/SkRasterPipeline_opts.h(362,35): error: no matching function for call to '_mm256_min_ps'
    SI F   min(F a, F b) { return _mm256_min_ps(a,b);    }
                                  ^~~~~~~~~~~~~

And a lot of similar intrinsic errors.
At this point I'm at a loss. I tried various things, liking disabling the HSW modules and tinkering with the source files, but that all resulted in other errors.
Are you familiar with these errors? Did I do something wrong with my setup? Maybe I need a different version of LLVM, the VS Build tools, or the Windows 10 Kit? What versions are you using?
I know you are very busy now with support for the next Delphi version, but if you could assist here, then I would be able to contribute.
Thanks you again for this great project!

Erik, my apologies for the delay in response. We will investigate the issues with the latest version of Windows SDK/MSVC and aim to do so within the next one to two weeks at most. Any assistance you can provide would be greatly appreciated. For reference, our current build utilizes VC++ Build Tools 2022 (14.33.31629) and Windows SDK 10 (10.0.19041.0).
Best regards,
Vinícius Felipe.

@neslib,
We've updated the build script to allow compilation from Windows ARM to x64 and x86. However, we didn't encounter the issues you mentioned; we was able to compile with the script for Win32 and Win64 without any problems.
For testing, we used the recently updated tools: LLVM 16, Windows SDK 10.0.22621.0, and MSVC BuildTools 2022 14.37.32822.
You can find the build instructions on the page: https://github.com/skia4delphi/skia4delphi/blob/main/Documents/BUILD.md
If you're still experiencing issues, please reopen this issue and provide more details so we can replicate on our end.
Best regards.


Respect package.readme in Cargo.toml

Fixes #1215 by honoring how package.readme is authored in Cargo.toml, if authored. This could be a path or a boolean to disable searching for the path.
Also fixes the existing it_copies_a_readme_provided_path test which was an exact copy - just with fewer empty lines - of it_copies_a_readme_default_path and wasn't honoring any authored path since there was no way to get the authored path.

Thanks! Looks good to me! Can you rebase latest master into your branch perhaps?

Unfortunately, because #1185 took a dependency on a new crate, the problem needs to fix there as well. It has the same problem as this crate did where it expects a readme to be a path only (present or absent) so I can't tell the difference between explicitly disabled or just not specified.

Ready. I misunderstood that cargo_metadata was consuming from the command cargo metadata, which results in null in this case so we can still detect when readme = false was specified.

Looks like the test failures started in or around 3073db8f18fcd452404929d22762389b50d2cfe7

Ready. I misunderstood that cargo_metadata was consuming from the command cargo metadata, which results in null in this case so we can still detect when readme = false was specified.

Great, thanks a lot! Appreceite you fixing it!

Looks like the test failures started in or around 3073db8

Yeah, I will look into the failures. Thanks

Sorry @heaths. I had to revert this PR since we got some actual test failures after this was merged. Both locally and in Github actions. Could you perhaps take a look at that and submit a new PR? Sorry for the inconvenience...

Understood. Will take a look.

To note, the two failing log_level tests started earlier in 3073db8f18fcd452404929d22762389b50d2cfe7 - sometime around when the deserialization of the manifest was removed from this crate in lieu of running a tool.

@drager please see https://github.com/rustwasm/wasm-pack/pull/1298

Thank you for taking the time to investigate and fix it! Appreciate it!


Added end_of_line & some more info about this file

It is acceptable and often preferred to leave certain EditorConfig properties unspecified. For example [...] if a property is not standardized in your project (end_of_line for example), it may be best to leave it blank.

http://editorconfig.org/#file-format-details
I added end_of_line nonetheless, as I think there is an agreement to always use lf.
I did not include the *.yml section from https://github.com/thephpleague/skeleton/pull/24#issuecomment-101760015
As I was not sure if there is  a consent about  the indent size in yml files.
[*.yml]
indent_style = space
indent_size = 2

The indent_style would be  redundant anyway...

Perfect, thank you.


split some of the deployment and daemonset config to make things more…

… flexible

[x] Chart version not bumped (the versions are all bumped and released at the same time)
[x] README.md updated with any new values or changes
[x] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Looking at #446 realized we may want to split daemonset/deployment config in some places. This is kind of a big change to the values file though, so not sure if theres a better way to transition. Consider this as a proposal :)

Can this PR be merged in? We are still having issues with the resources being the same on all pods even though the daemonset pods use much less compared to the deployment pod.

Hey @pbecotte,
Thanks for your PR, however, this is a breaking change and we'd like to ensure user with old values can still use the chart after splitting config, so I started a rework in #572, which should allow re-using old values if they are still used.

Closed by #572
Thanks for your work @pbecotte


Update data loader to split videos into 5 second segments,

Added logic to break videos into 5 second segments, and downsample to a standard size.
Segments are constrained to be non-overlapping to avoid data leakage.
This both increases our training set size, and gives us more batchable data.

builds on #6, adding further support and tuneability; overall goal is #2


Enable Clipper to run with multiple query frontend replicas

Allowing Clipper to run with multiple query frontend replicas is desirable to provide high availability and to provide horizontal scaling to higher throughputs. There are a few blockers to implementing this currently, the biggest blocker has to with Kubernetes load-balancing (quoting from the docs)

Kubernetes makes it simple to horizontally scale a service by increasing or decreasing the number of replicas of a pod. Clipper uses precisely this mechanism to scale the number of replicas of a model container. However, scaling the query frontend service to multiple replicas (e.g. to make it highly available), is significantly more complicated. The complication arises primarily from the fact that model containers connect to the query frontend with long-lived RPC connections (over TCP). These connections last until either the query frontend or the model container dies and kills the connection. As a result, these long-lived connections must be correctly re-balanced when query frontend replicas are created or destroyed. Without a re-balancing mechanism, the query frontend and model container deployments cannot scale independently.
Clipper does not currently provide any support for this re-balancing. The query frontend is stateless, and so there is no architectural reason why it cannot be replicated, but you will need to manage this re-balancing yourself. We are currently investigating the best way to support this use case.

This issue is meant to be a blanket issue to track the current state of the feature. Individual issues to add the functionality needed to enable query frontend scaleout will be filed as they come up.

@dcrankshaw In addition to the issue mentioned above , the Query Frontend is pseudo-stateless because of the cache.I guess it would be hard to scale out with this kind of approach.Do you think moving to Redis as a distributed cache would be an option?

Yeah we would consider this. I think that long-term, it makes sense to move the cache outside of Clipper entirely. You don't want the cache in front of Clipper because it needs to be aware of model versions, but it makes sense to have a single shared cache among all query frontends rather than rolling our own. @santi81, can you file an issue requesting this feature?

Any update here?

This is in progress. @rbala19 can you give a brief summary of what we tried and what you're working on now?

Over the past two weeks, we've been looking into a more fault tolerant implementation of the query-frontend to model interaction. Currently, we have a system in place that allows the user to specify how many query-frontend replicas they want to deploy. Once these replicas are deployed, any model that is subsequently deployed will be deployed to each replica frontend.
In addition to increasing fault tolerance through model replication, we aim to increase resilience in the event of a query frontend crash. Kubernetes restarts crashed containers automatically when using a ReplicaSet deployment; however, deployments often restart with differing IPs, implying that the restarted query frontend will lose its connection its models. Unfortunately, there is no method of preventing a crashed query frontend from automatically restarting, since Kubernetes forcibly asserts a certain number of pods to be running within the ReplicaSet deployment type. To remedy this, we have several tasks in progress:

Place a listener that periodically checks for a crashed frontend; collect the IP of the newly deployed query-frontend.
Replicate all deployed models from one of the deployed query frontends into the restarted query frontend.
Place this actor within a pod of its own that deploys whenever clipper deploys. This pod will function as an overseer to which we will deploy future changes to fault tolerance and replica scaling.

@dcrankshaw
Is it true?

Currently, we have a system in place that allows the user to specify how many query-frontend replicas they want to deploy. Once these replicas are deployed, any model that is subsequently deployed will be deployed to each replica frontend.

@rbala19 @dcrankshaw
Instead of making changes on existing solution, I am thinking is it possible to ask query processor to connect to model containers ? (models can be deployed as kubernetes service)

Everytime end user deploys a model, write <model, k8s-service-lb> in meta store.
For every prediction request, query processor get model endpoint from meta store.
Query processor send rpc request to model container service

In this case, I know it will hurt performance a little bit. (without benchmark, I don't know how much). But from scalability and maintenance perspective, architecture looks  easier. Have your team considered this way? If so, please let me know the reason you didn't move on.

no need to keep long-alive connection.
no heartbeat. K8s will guarantee replicas always alive.

You're right that it simplifies the architecture. However, that approach has two big drawbacks.

Initiating a new connection for each request adds a significant amount of overhead, and will substantially impact our ability to meet latency SLOs.
The query frontend has a single request queue that dispatches to all replicas of a model. We carefully load-balance and dispatch these requests in batches to replicas as they become available for work. In particular, when a given replica finishes processing a batch, it requests more work from the queue, rather than having Clipper push a batch to it (when it might not be ready). Furthermore, while we haven't added this yet, we are designing a more sophisticated batching algorithm that will automatically learn the latency characteristics of each model container individually and tailor the batch size to be used based on the container the batch will be sent to. Taking the approach you describe would make this feature very hard (if not impossible) to implement.

@dcrankshaw
For container orchestration I use Docker Swarm, not Kubernetes. In this case, if I increase the replicas of Query-Frontend, Clipper gave me so slow replies about some requests. Through inspecting Clipper codes, I found that current Clipper architecture does not support Docker Swarm, in which multiple replicas of a Swarm service have the same IP and port. So I modified Clipper architecture like this,

[model container - rpc.py - RPCService]
Retrieve the own hostname(hn_M).
[model container - rpc.py - send_container_metadata()]
Send hn_M with other information to Query-Frontend.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Receive hn_M and other information from upper model container.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Retrive the own hostname(hn_Q) and set hn_M as model_replica_id and hn_Q as qf_replica_id.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Add hn_M and hn_Q with other information to Redis by calling redis::add_container().

<
  (model_name, model_version, model_replica_id, qf_replica_id),
  model_id, model_name, model_version, model_replica_id, qf_replica_id, zmq_connection_id, batch_size, input_type
>

[query-frontend - task_executor.hpp - callback of subscribe_to_container_changes()]

Extract a qf_replica_id(hn_Q) from the changed container information.
Retrive the own hostname
Ignore the callback if hn_Q is different from the own hostname.

Currently, our modified Clipper having multiple query-frontend replicas is working well. :)

@withsmilo Oh very cool. Glad to hear you got this working for your use case. And thanks for sharing here! This should help future users who have similar use cases to yours.

@dcrankshaw
For container orchestration I use Docker Swarm, not Kubernetes. In this case, if I increase the replicas of Query-Frontend, Clipper gave me so slow replies about some requests. Through inspecting Clipper codes, I found that current Clipper architecture does not support Docker Swarm, in which multiple replicas of a Swarm service have the same IP and port. So I modified Clipper architecture like this,

[model container - rpc.py - RPCService]
Retrieve the own hostname(hn_M).
[model container - rpc.py - send_container_metadata()]
Send hn_M with other information to Query-Frontend.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Receive hn_M and other information from upper model container.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Retrive the own hostname(hn_Q) and set hn_M as model_replica_id and hn_Q as qf_replica_id.
[query-frontend - rpc_service.cpp - RPCService::receive_message()]
Add hn_M and hn_Q with other information to Redis by calling redis::add_container().

<
  (model_name, model_version, model_replica_id, qf_replica_id),
  model_id, model_name, model_version, model_replica_id, qf_replica_id, zmq_connection_id, batch_size, input_type
>

[query-frontend - task_executor.hpp - callback of subscribe_to_container_changes()]

Extract a qf_replica_id(hn_Q) from the changed container information.
Retrive the own hostname
Ignore the callback if hn_Q is different from the own hostname.

Currently, our modified Clipper having multiple query-frontend replicas is working well. :)

Your method is very good. I have the same problem and resolve it throug your method。Thanks


hide columns from listing

How can I hide certain fields from listing table?

Hi @kolep8 ,
you can hide it from your controller, you'll see looks like :
ex :    public $listing_cols = ['id', 'name'];
hide : public $listing_cols = ['id'];
Just remove the field name you want to hide.

thanks


Add version subcommand to show version information

Inspired by<EMAIL_ADDRESS>added a version subcommand to help developers with version information when they use the tool or contribute to it.
Changes:

pkg: add version
cmd: add version subcommand to show version information
hack: add Makefile and a install script to install maintainers

LGTM. thanks!


File for Windows

May I know why you not build one file exe for Windows .Some people do not smart .

What? Have you missed "Compiled" directory?


Add role update upon supporting

This PR adds a session update when a member completes their signup process.
This removes the need for logging out and back in. Note: We still need to downgrade the role automatically when their supporting membership ends.

Did a self-review and it worked 👍


chore(deps): bump https://github.com/jenkins-x/jx-git-operator to 0.0.79

Update jenkins-x/jx-git-operator to 0.0.79
Command run was jx step create pr regex --regex version: (.*) --version 0.0.79 --files charts/jx-labs/jx-git-operator.yml --repo https://github.com/jenkins-x/jxr-versions.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ccojocar
You can assign the PR to them by writing /assign @ccojocar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
48a89ef05e48d807594863b208f2fcc7b7e5011e
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
1c7215eb224587fc2a76aa0b87e8adc78c0da5a0
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Added new 'sshauthsock' option

This patch allows me to authenticate without password:
docker volume create -d h0tbird/sshfs:next -o sshcmd=${RUSER}@localhost:${RMOUNT} -o port=2222 -o workaround=rename -o sshauthsock=${SSH_AUTH_SOCK} data-${RUSER}

This is very useful, why not merged yet?

This is very useful, why not merged yet?

Closing (no activity)


Put a space after the @ name

https://www.loom.com/share/7425be7ba56a46049206c0c1fe0aab9c
bug _t

Fixed by #192.


Some images Path does not work with TabrisJs 3.3.0

Problem description
tabris 3.3.0 ImageView() can't load the picture with this path
content://media/external/images/media
Expected behavior
ImageView() load images from content
Environment
Tabris 3.3.0
A workaround is to use the cordova-plugin-filepath to resolve the content path to  file path

Could you provide a snippet showing how to create and consume such a path in tabris.js?

This kind of path? content://media/external/images/media
i get this kind of path from an intent to open a gallery
i use this plugin for the intent darryncampbell-cordova-plugin-intent

A snippet code would explain the problem better.

Do you see any security exceptions in the Android adb log?

In general it also works in the Tabris.js android client. i am for example able to display an image with a content uri such as content://com.android.providers.media.documents/document/image%3A37. (Note that the : colon char is html escaped). It is important to note that the file can only be read once after beieng picked from the intent ui.

yes in some cases i was not able to display the image, in some others cases i was.
I didn't have to check the logs what I did when I got an error in the console about image not being able to load is to install the cordova plugin cordova-plugin-filepath.
you want which code snippet exactly? the one where I get the path to the image via the intent plugin

would be interesting to see.

That and logcat.  If there is an exception on the native side they won't log to the developer console

When an image wasn't able to load into the console I had a message like the image... could not be loaded

@ishigo1987 would you like to share your snippet you use for loading the image?

for loading the images a use another plugin, a plugin for intent
module.exports = ()=>{
    return new Promise((resolve)=>{
        require("./plugins/intentStartActivityForResult.js")({ action: window.plugins.intentShim.ACTION_GET_CONTENT, type: "image/*"}).then((responseIntent)=>{
            if (responseIntent.Message === "Activity response"){
                resolve({ Message: "Picture available", Data:{imagePath:responseIntent.Data.data}})
            }
        });
    });
};

Maybe the image is loaded twice. Please do check the adb logs for any exception.

ok

Closing this issue for now. Please reopen if you have any more related issues or create a new issue with a more specific topic.