Adding plugin to custom config throws compilation error

Within .storybook/webpack.config.js:
  config.plugins.push(new webpack.EnvironmentPlugin([
    "API_URL",
    "NODE_ENV",
    "MIXPANEL_TOKEN",
  ]));

TypeError: callback is not a function at NullFactory.create

TypeError: callback is not a function
    at NullFactory.create (/Users/Eric/Projects/HigherEducation/platform/node_modules/webpack/lib/NullFactory.js:9:9)
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:214:11
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/async/lib/async.js:181:20
    at Object.async.forEachOf.async.eachOf (/Users/Eric/Projects/HigherEducation/platform/node_modules/async/lib/async.js:233:13)
    at Object.async.forEach.async.each (/Users/Eric/Projects/HigherEducation/platform/node_modules/async/lib/async.js:209:22)
    at Compilation.addModuleDependencies (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:185:8)
    at Compilation.processModuleDependencies (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:170:7)
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:320:12
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:123:4
    at Array.forEach (native)
    at callback (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:122:12)
    at Compilation. (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/Compilation.js:140:10)
    at DependenciesBlock. (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/webpack/lib/NormalModule.js:115:10)
    at DependenciesBlock.onModuleBuild (/Users/Eric/Projects/HigherEducation/platform/node_modules/webpack-core/lib/NormalModuleMixin.js:310:10)
    at nextLoader (/Users/Eric/Projects/HigherEducation/platform/node_modules/webpack-core/lib/NormalModuleMixin.js:275:25)
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/webpack-core/lib/NormalModuleMixin.js:259:5
    at Storage.finished (/Users/Eric/Projects/HigherEducation/platform/node_modules/@kadira/storybook/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:38:16)
    at /Users/Eric/Projects/HigherEducation/platform/node_modules/graceful-fs/graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:445:3)

I'm using:
"@kadira/storybook": "2.35.3",
"webpack": "2.1.0-beta.22",

It's been an hour and I can't figure out why webpack would mess up because I'm simply adding another plugin...

Ahah!   I didn't realize that @kadira/storybook was using it's own webpack instead of the project one!.
#651 would be the correct solution.
In the meantime, anyone else with this problem can tell Storybook to use the webpack1 modules this way:
const webpack = require("@kadira/storybook/node_modules/webpack");


Page with ads from prebid.js is not loading through testcafe

I need to test page with ads from the prebid.js, here is my working test page:
http://dev.testcommon.insideall.com/gmc/test-marieclaire.html?pbjs_debug=true -> you should see blue ads.
When I use testcafe the page is loading very slow, and finally not all ads are displayed.
test
.page('http://dev.testcommon.insideall.com/gmc/test-marieclaire.html?pbjs_debug=true')
The important thing is to have a different host for the testcafe server (ads cannot be served from localhost), e.g. I am using
createTestCafe('example.com', 1337, 1338)
in my runner.js file
The problem is partially explained here:
https://stackoverflow.com/questions/52745697/requestlogger-not-intercepting-all-http-requests
Are you able to fix it?

Hello,
Could you specify your TestCafe version? I tried to run the test below and everything works as expected.
fixture `Page with ads from prebid.js is not loading through testcafe`
    .page `http://dev.testcommon.insideall.com/gmc/test-marieclaire.html?pbjs_debug=true`;

test('Load ads', async t => {
    await t.debug();
});

testcafe version: v1.8.2
node.js version: v12.4.0
command-line arguments: testcafe chrome test.js
browser name and version: Chrome 79
platform and version: Windows 10

Would you please provide more information about this issue?

Hi Artem,
Thanks for your feedback. I have almost the same configuration as you. Seems there was an issue on my computer side - I rebuilt again the project by yarn (before I used npm) and it started to work as expected.
Sorry for the mess - this ticket can be closed.

@darekodz,
Thank you for the update. I'm happy to hear that you have figured out how to resolve the issue.


Fix CI

I noticed that the CI is failing. It is perhaps due to the incorrect specification the test dependency space, which is named as tests in pyproject.toml:
https://github.com/TillRS/SUN_TopicModel/blob/a8dcc8a130574c14fc967b4b3536c1b7174f4e0a/pyproject.toml#L34
but referenced as test in .github/workflows/ci.yml:
https://github.com/TillRS/SUN_TopicModel/blob/761fe21ec5c91b03a041aae075e98cf1a515ea34/.github/workflows/ci.yml#L30
You can change either to make both identical.

thanks! I just found/fixed this through some trial and error.

Yeah, I just saw it - I could have waited!

 :)


Refine px demo delete logic for more complex demo applications

Summary: We are working on adding the px-k8ssandra demo in our demo apps. However, this demo app is more complex. It requires cluster-scoped resources such as mutating webhooks, and proper cleanup requires the K8ssandraCluster to be deleted first or else things will hang.
We can control the delete process through labels. Adding labels to the demo resources allow us to target cluster-scoped resources that wouldn't be deleted from just deleting the namespace. We can use an additional label for resources that need to be cleaned up first.
Relevant Issues: #680
Type of change: /kind cleanup
Test Plan: Deploy px-k8ssandra demo app and delete. Make sure resources all get cleaned up and delete runs without error. Also make sure delete still works on existing demo-apps, such as px-sock-shop.

This doesn't delete cert-manager right? Since we don't track if it's installed by pixie or not?

That is correct, we error at px demo deploy time if they don't have cert-manager installed already. So users are required to install cert-manager themselves, and remove it themselves.


Decide title for "Detailed Results" page

Barrie notes: "Detailed results page" but my point was that the name was appropriate for those projects but not for FreeBMD. One could have a debate about balancing consistency against meaningfulness, but that is a debate that is lacking.W Barrie suggests "Information".  Currently FreeBMD1 has "Entry Information".

@PatReynolds What's the current status on this?

No decision yet.  'Detailed Results' may not be right for FreeBMD - UX to test if this builds expeection of more details being following the link / disappointment when it is more properly 'More information about this entry'.

Original BMD says 'Info' and then 'click for more information' and then title is 'entry information'. Agreed to go with that.

@Vino-S to implement @PatReynolds  to check that all references are changed in documentaiton

The help page needs a thorough re-write which will pick this up, so have added to 'Help page for MVP' epic.

Closing as now a duplicate.


Safe mode is not enough to be really safe

It currently allows users to "escape" the place they are supposed to be at with for example the following HTML template:

 This contains the text:

${mdContent}

One can then create Markdown content such as:
In the box

 Outside the box, looks like part of the site now
 go there to reset your password please

I need a way to escape every unescaped < character from the input.

Added a panicMode, fixed with 00fa65a963e18370569ddc73423511b85e01e0aa

Thanks! I'll try it out!

Yes, works, thanks!


fix(kibbeh/src/ui/profiletabs.tsx): about button in profileTab spacin…

tab button adjustment

please follow the proper pattern for commit messages (💡TIP: you can use yarn commit or yarn commit:signed and answer the questions asked to generate a properly formatted one for you!)
to fix your most recent commit you can run the command git commit --amend -m "properly formatted commit message here"
to fix your older/multiple commits please take a look at this article

Oh my god that commit message pains me.

@amitojsingh366 i did use yarn commit and answered the questions asked.

@amitojsingh366 i did use yarn commit and answered the questions asked.

the scope you gave is wrong, you current scope is kibbeh/src/ui/profiletabs.tsx change that to kibbeh by running the following command and pushing git commit --amend -m 'fix(kibbeh): about button in profileTab spacing adjustment'

@amitojsingh366 yeah the commit message, sorry about that, will amend in a bit

why'd you close it?

why


adding PitchShift example

This pull request adds an example for the PitchShift effect. I initially created it to answer a StackOverflow question and thought it might be worth to add it to the official docs.
I tried to follow the style of the other examples. Please let me know if there is anything I need to change.

thank you for this PR!! very much appreciated


Changing styles doesn't work in some Windows installations

@3ullShark (Win10) and finezig (Win7 ultimate) noticed that changing the style does nothing on Windows. I tried a local build on my Windows 10 and it worked like a charm.
Their "Apply" button doesn't enable when changing style sheets while it does for me. It's like the wallet doesn't detect the switch.

@skcin This could be because the Windows wallet is using Qt4. Hold your horses on this one.

Closing this for now as it seems to work fine in Qt5 locally. Reopen if it still doesn't work when we officially update Qt.


i need tutorial about content-script on this repo

recently just try this repo for creating random extension for chrome (just learn new thing)
while some page I already tried, like popup, newtab, background script, but just look up the content-script that use original console log is not even running (checked on edge dev tool), the console log not even write anything...
what I already do:
npm i
npm run build <--- to build data
load unpackaged extension on my edge
// i dont get any console log
npm run build <-- i build again to make sure
npm run start <-- this even build with hot reload
load package again
// still not getting console log
i've already check, the code is not hot reloaded on webpack config
then I tried to reload package, and remove then re-add the package to browser but still no luck
this extension I intend to use on a production website (thru https, should i change the config use https ?), though I don't have any experience with webpack, then, just final one... can you explain me how the content-script can executed as expected ?

hmm... i think because I still learning, the code is able to run now... because it need to run when not using npm run start
but let me change the question then:
why node module like web3 or else is cause errors, i think other module can cause error to extension... teach me how to add module so i able to create better extension...

I ran into a similar issue and found an error in the console suggesting the issue was caused by socketJS opening an unsafe connection on a page that uses SSL. I flipped https to true in the webserver.js file in the utils folder and everything seems to be working now. Perhaps give that a try if you are still stuck with this issue.

Thanks @BlakeHastings! Worked for me.


[Enhancement]: Postgres, ChromaDB, etc. in Dockerfile

What would you like to be added?
It would be nice to have a "maximal" Dockerfile that sets up all the dependencies, such as Postgres, Chroma, etc.
Why is this needed?
Most of the friction in writing a caching layer like this is running the external DBs.
I have a hand-rolled version of GPTCache that uses sqlite and faiss, purely because these are so easy to install. I would love to adopt GPTCache if it gave me smooth one-liner access to a Postgres instance, Chroma instance, etc.
Anything else?
No response

The necessary dependencies will be automatically downloaded and installed prior to use, including within Docker.


Update fs2-io to 3.9.3

About this PR
📦 Updates co.fs2:fs2-io from 3.4.0 to 3.9.3
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-io" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "co.fs2", artifactId = "fs2-io" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Codecov Report

Merging #463 (0982309) into master (806f830) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   84.75%   84.75%
=======================================
  Files          35       35
  Lines         223      223
  Branches       17       17
=======================================
  Hits          189      189
  Misses         34       34

Flag
Coverage Δ

unittests
84.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Superseded by #469.


Bug: V4 -- Ctrl + Click on a link in Codeblocks View opens the link in two tabs

Describe the bug
Ctrl + Click on a link in Codeblocks view opens the link in two different new tabs instead of just one.
To Reproduce

Ctrl + Click a link in Codeblocks view

Expected behavior
The link should open only once in a new tab.
Desktop:

OS: Windows 11
Version: 4.0.65-beta

Additional context
Interestingly, middle click works properly in Codeblocks View and opens only one new tab.

Thanks Abi.
All these issues are related. For reference, here's the discussion on Discord: https://discord.com/channels/686053708261228577/840286264964022302/1223576343044948028
I believe there is an issue with Obsidian where using openLinkText from a view not inside a Markdown editor crashes Obsidian on mobile
And here's the repo where I'm trying to minimally recreate the issue so the Obsidian devs can take a look: https://github.com/SkepticMystic/obsidian-openLinkText-mobile-bug

Fixed as of 4.0.73-beta!


[devtools] Breakpoints disappeared after refreshing tab

I'm using Sources of develop tools to debug my codes.
I set breakpoints at specific lines, however, breakpoints labels would disappear when I refresh the tab.
Breakpoints would work but I couldn't manually toggle those breakpoints labels.
Only if I close current tab and enter my dev site again, those lovely blue labels would  appear again, or breakpoints would still be there and I couldn't exit my 'debug mode',
How could I make breakpoints labels always be there?

Hi! Sorry, our Git repo is meant for issues with content on the site. Check out https://developer.chrome.com/devtools/docs/contributing for how to ask questions or file issues on DevTools.


Support for hdfs:///

hdfs:/// is a valid way of specifying hdfs URL. Especially when fs.defaultFS is set. The current implementation, however, doesn't really allow that and we get URL must contain a host.

Hmm didn't know that was a thing. What happens if you specify hdfs:/// but your fs.defaultFS is viewfs://myfs?

Haven't encountered the situation but technically it should not work unless you have ViewFsOverloadScheme configured to hdfs.


Add missing fields to Sendgrid webhook schema

Resolves https://github.com/ascoderu/opwen-cloudserver/issues/251

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   98.72%   98.72%
=======================================
  Files          14       14
  Lines        1098     1098
=======================================
  Hits         1084     1084
  Misses         14       14

Impacted Files
Coverage Δ

opwen_email_server/actions.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89fc35a...800e1f9. Read the comment docs.


refactoring changes & additions

hi @oblomov-dev
i see that alot of changes are being made,
is it possible if you got time, to explain whats been changed, or added to the framework ?

yes of course! But nothing new added so far, just try to clean up everything to make the codebase easier to maintain.
(1)
Splitting up the logic into smaller classes, for example this folder is new:
https://github.com/abap2UI5/abap2UI5/tree/main/src/01/02/01
Before the logic of these classes was contained in other ones and the classes had mixed tasks. try now to have single classes for every task, eg. creating the json, searching for class attributes, binding logic...
(2)
Changed the payloads of requests and responses, they are smaller now and reduced only to the needed information (eg. deleted new lines in the xml, shorted the event notation...)
(3)
Try to clean up some redundant code which was added from time to time.
(4)
Added more unit tests and static code checks. For example:
https://github.com/abap2UI5/abap2UI5/blob/main/src/01/02/z2ui5_cl_core_http_get.clas.testclasses.abap
And some renaming etc.
Hope it breaks nothing! Still work in progress...

Besides that, added just now the source code view for the debugger tools:

lets continue in the more specific issues now...


Custom Prefix

Add custom prefix Command so that people can change prefix without changing it in code and for multi-serving. ( $ _ $ )

closing this. because of conflict, and we don't really need this feature to be merged.


Syntax Error near unexpected token `newline'

Using a acer chromebook r11  (model N15Q8).
firmware-util.sh: line 3: syntax error near unexpected token `newline'
firmware-util.sh: line 3: `<!DOCTYPE HTML PUBLIC "-//W3C??DTD HTML 4.01//EN" "http:// www.w3.org/TR/html4/strict.dtd">'

It prevents me running the script
Any help would be appreciated.
Thanks,

looks like the file simply failed to download and you got a html doc instead, I'd just retry as there's nothing wrong on the server side best I can tell


OnVRSurfaceCreated event for image effects

One possible solution for: https://github.com/OSVR/OSVR-Unity/issues/75
This PR adds an event to VREye that fires when a VRSurface is created. Another object in the scene can subscribe to this event, and provide game-specific code in a callback function. This would be for adding image effects and other components that need to be copied to each camera in the scene. Example script and scene added, although there is not an included image effect demonstrated, just comments where that code would go.

Regarding image effects, this would require the user to add them manually wouldn't it? Unity doesn't provide an easy way to copy components. I was just sitting down to work on it when I saw this. Components can be copied via reflection, so I figured the easiest way to go about it was to loop through all of the components and copy them that way, excluding the display controller, of course. This would also replace the current camera copy code, since the camera is a component. The current code doesn't seem to copy over my HDR or color settings anyhow. I reckon that is a bug in Unity, since the current camera copy is simply a built in Unity function.
I'm using a version of Unity one patch release newer than the one the project was built with. I don't know what effect that will have on Git, so it may be best for me to make the changes to my main project and then copy them over to my repository.

Yes, this still requires a manual process.
Reflection will work but I think @rpavlik had a good reason not to use it in this project.
Should be fine in Git if its a Unity 4 project.

If avoiding reflection is desired then the other idea I had was to instantiate a copy of VRDisplayTracked, since that it where the camera is and instantiating it would create an exact copy. Of course, that is also where the Display Controller is, and we wouldn't want that running again so it would need to be disable before the instantiation, deleted form the new instance, and then reenabled on VRDisplayTracked proper.
I'm using Unity 5.2.2p1, when I tried to open the project it said it was created with 5.2.2f1.  I'm not sure how many changes Git will register that I'll have to sort through. I'm gonna give it a try and see though I just haven't had a chance to yet.

I've got image effects working using the instantiate method I mentioned above. It is slightly messy because by the time CreateSurface is called there have already been two gameobjects added as children to the tracker object that get duplicated as well (VRViewer and VREye). So those, along with the display controller need to be removed. I don't see a way around this since camera and its image effects need to be duplicated multiple times, so creating it before everything is setup would require passing that object through VRViewer to VREye, duplicating it, and then deleting that original after all the surfaces are created. That would be even messier. Another alternative would be to separate the display controller into its own gameobject and create the camera gameobject as a child of it. VRViewer and VREye would no longer be a child of the camera gameobject that needs to be duplicated. That would take a bit of reworking, would make the hierarchy view messier, and I'm not sure what other ramifications it may have.
There is a bit of a performance hit compared to TrinusVR when the image effects are added. That performance hit exists without them though, so I see no reason I shouldn't submit the changes once we decide the best way. It occurs because the image effects on the main camera are still processed. They don't take as much time as they normally would, but my project loses about 1ms to them. There are other areas where the time is lost rendering that camera as well. I'll have to do a deep profile to figure out what is going on.

Closed. This feature was implemented in #111


installation has failed

nosincroniza 0/0

could you please post your log?

close your firewall or antivirus software, and reinstall


Variable Width + Infinite

When using variable width there is an amount of white space generated at either end.
When scrolling right as you approach the last slide more and more whitespace opens up until you hit the very last slide, at which point the white space is replaced by previous slides in infinite mode.
Similarly, if you move left through the slider, content disappears and is replaced by white space.
I would think that the expected results would be the white space be occupied by slides as the end comes into view, rather than as the last slide hits the left edge.
http://jsfiddle.net/memvovkz/

+1 to this issue

+1

+1

+1

+1
Very true...feelsbuggy. This should really be an option/setting.

+1

Don't ask me why, but if it's not interfering with your slider in other ways, consider setting slidesToShow to at least half of your number of slides, which would be 6 for your fiddle. It's a hack, but it solved my problem for now.
http://jsfiddle.net/memvovkz/1/

@evalunamain Interesting. Will have to try and see if this will work with dynamic content as well, where the number of objects is unknown.

@picard102 it appears if you use @evalunamain 's method and just use jQuery to get the number of slides before the slider initializes, you should be able to pass in that number divided by 2. Haven't fully tested by it worked when I changed the JS in the fiddle you shared in the initial post.

Maybe someone can help?
What if I need to style an active slide?
And if slider has more than 1 in slidesToShow, for example, 6 slides.
All of them have an slick-active class, and I am using a centerMode: true, so only one slider in the middle has to be active.

I think I've dealt with that before @makseo , if you use the beforeChange event, you can figure out which slide is the next slide and then apply a style directly to it.

+1

+1

+1

Hey guys.... had the same problem with a carousel of variable width of items....got a solution for this....
Have tried the solution of evalunamain, and set the slidesToShow option to half of my items, but this way slide controls (arrows) didn't work as expected...
So I go to the code of slick core....and found the lines where infinite is being initialized...here is the code down here:
Slick.prototype.setupInfinite = function() {
    var _ = this,
        i, slideIndex, infiniteCount;

    if (_.options.fade === true) {
        _.options.centerMode = false;
    }

    if (_.options.infinite === true && _.options.fade === false) {

        slideIndex = null;

        if (_.slideCount > _.options.slidesToShow) {

            if (_.options.centerMode === true) {
                infiniteCount = _.options.slidesToShow + 1;
            } else {
                infiniteCount = _.options.slidesToShow;
            }

            for (i = _.slideCount; i > (_.slideCount -
                    infiniteCount); i -= 1) {
                slideIndex = i - 1;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex - _.slideCount)
                    .prependTo(_.$slideTrack).addClass('slick-cloned');

// added this code here
$(.$slides[slideIndex + 1]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex - .slideCount)
.prependTo(.$slideTrack).addClass('slick-cloned');
$(.$slides[slideIndex + 2]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex - .slideCount)
.prependTo(.$slideTrack).addClass('slick-cloned');
//
}
for (i = 0; i < infiniteCount; i += 1) {
slideIndex = i;
$(.$slides[slideIndex]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex + .slideCount)
.appendTo(.$slideTrack).addClass('slick-cloned');
// and this code here
$(.$slides[slideIndex + 1]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex + .slideCount)
.appendTo(.$slideTrack).addClass('slick-cloned');
$(_.$slides[slideIndex + 2]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex + .slideCount)
.appendTo(.$slideTrack).addClass('slick-cloned');
//
}
_.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
$(this).attr('id', '');
});
        }

    }

};

so it creates some more clones...... and I suggest to make an option, which can manipulate the number of clones on this position....
Hope this helps....thanks guys.

+1

+1

@prod1992 Gr8. Thanks mate.

+1

Hi prod1992, I tested your solution and didn't work for me case.
Finding the solution I found one trick: use unFilter function when the init event is fired.

Thanks, can you provide a snippet for better understanding?
On Monday, 21 December 2015, Rafa Aguilar<EMAIL_ADDRESS>wrote:

Hi prod1992, I tested your solution and didn't work for me case.
Finding the solution I found one trick: use unFilter function when the
init event is fired.
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-166279797.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

I use with angular directive https://github.com/devmark/angular-slick-carousel, if you want to check my issue test the demo of this repo.

+1

You can see the error in the next screencast: https://www.dropbox.com/s/rte1569yb7z167t/angular-slick.mov?dl=0

+1

+1

I'm off next week so I'll try to get this sorted out folks

that would be great 👌
On Fri, Dec 25, 2015 at 8:26 AM, Ken Wheeler<EMAIL_ADDRESS>wrote:

I'm off next week so I'll try to get this sorted out folks
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-167191108.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

+1, same problem here.

Are we all in agreement that the last slide should stick to the right edge?

Yes, I agree with that.
On Saturday, 9 January 2016, Ken Wheeler<EMAIL_ADDRESS>wrote:

Are we all in agreement that the last slide should stick to the right edge?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-170242120.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

@prod1992 so if its variable width, the last navigable/selectable index should be the one that sticks the last one to the right edge?

When width is variable + infinite option is enabled. When there are about
3-4 slides, near the edges slider blinks when you change slides.
On Saturday, 9 January 2016, Ken Wheeler<EMAIL_ADDRESS>wrote:

@prod1992 https://github.com/prod1992 so if its variable width, the
last navigable/selectable index should be the one that sticks the last one
to the right edge?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-170252730.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

Well aware, but I'm trying to figure out how to fix this issue, but not create issues for other modes/settings

Ken, I think its more about infinite option, but variable width.
On Saturday, 9 January 2016, Levon Grigoryan<EMAIL_ADDRESS>wrote:

When width is variable + infinite option is enabled. When there are about
3-4 slides, near the edges slider blinks when you change slides.
On Saturday, 9 January 2016, Ken Wheeler<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

@prod1992 https://github.com/prod1992 so if its variable width, the
last navigable/selectable index should be the one that sticks the last one
to the right edge?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-170252730.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

+1

+1

+1

We actually just removed Slick in a project for a different carousel partially because of this issue. It would go a long way towards us considering it again for future projects. Are you taking PRs for this issue, or is someone already working on it?

+1
On Wed, Feb 3, 2016 at 8:10 PM, Mike Behnke<EMAIL_ADDRESS>wrote:

We actually just removed Slick in a project for a different carousel
partially because of this issue. It would go a long way towards us
considering it again for future projects. Are you taking PRs for this
issue, or is someone already working on it?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-179316942.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

@localpcguy if you have any ideas, i'm all ears.

@kenwheeler an option of how many slides to clone ahead while on infinite might work well?

I think yes. try to make twice more clones...
On Thu, Feb 4, 2016 at 4:39 PM, Rory Koehler<EMAIL_ADDRESS>wrote:

@kenwheeler https://github.com/kenwheeler an option of how many slides
to clone ahead while on infinite might work well?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-179809789.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

this is dirty, but have no any idea.
On Thu, Feb 4, 2016 at 4:40 PM, Levon Grigoryan<EMAIL_ADDRESS>wrote:

I think yes. try to make twice more clones...
On Thu, Feb 4, 2016 at 4:39 PM, Rory Koehler<EMAIL_ADDRESS>wrote:

@kenwheeler https://github.com/kenwheeler an option of how many slides
to clone ahead while on infinite might work well?
—
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-179809789.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

--
*Best wishes and have a nice day! *
Levon Grigoryan.

Is there at least a solution for using infinite: false?

Hi!
Although i know it's not a good practice, i've made a little change in the core that it's working for me.
In slick.js, line 1131, i've added after "targetLeft = targetSlide[0] ? targetSlide[0].offsetLeft * -1 : 0;" the next piece of code:
if(.$slideTrack.children('.slick-slide').eq(.slideCount - 1).hasClass("slick-active")){
targetSlide = .$slideTrack.children('.slick-slide').eq(.slideCount - 1);
targetLeft = $(targetSlide[0]).closest(".slick-slider").width() - (targetSlide[0].offsetLeft + targetSlide[0].offsetWidth);
}
I'm sure there has to be a better way to solve that, meanwhile it could help someone

+1

@Carlospineiro  if you have more than one item visible but slidesToShow set to 1 this will first slide the last item to the left then snap it to the right (http://postimg.org/image/gji1tvmwd/)

FOR WHITE SPACE IN CASE YOU DEFINE A SLIDE TO SLIDE WITH CASE OF INFINITE FALSE DO NEED DO SOMETHING LIKE THA IN SLICK.JS CODE  ADD THIS LINE IN PLACE
positionOffset=0; IT'S BEST SOLUTION FOR THE SLDIE
if (.options.infinite === false) {
if ((.currentSlide === 0 && swipeDirection === 'right') || (_.currentSlide >= _.getDotCount() && swipeDirection === 'left')) {
swipeLength = _.touchObject.swipeLength * _.options.edgeFriction;
_.touchObject.edgeHit = true;
positionOffset=0;
}
}

Just started with slick for a project this week. I need to display cutoff slides so I'm using variableWidth: true and infinite: false. However the slider not sticking on the right (and displaying whitespace) is a major problem and I'll have to scrap slick if I can't figure it out.

+1

+1

+1

My solutions.

Add clones options to  _.defaults = {.
clones: 5 for example.
Find stroke with _.slideCount > _.options.slidesToShow) and replace by

`if (_.slideCount > _.options.slidesToShow) {
            if (_.options.centerMode === true) {
                infiniteCount = _.options.slidesToShow + 1;
            } else {
                infiniteCount = _.options.slidesToShow;
            }

            for (i = _.slideCount; i > (_.slideCount -
                    infiniteCount - _.options.clones); i -= 1) {
                slideIndex = i - 1;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex - _.slideCount)
                    .prependTo(_.$slideTrack).addClass('slick-cloned');
            }
            for (i = 0; i < (infiniteCount + _.options.clones); i += 1) {
                slideIndex = i;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex + _.slideCount)
                    .appendTo(_.$slideTrack).addClass('slick-cloned');
            }
            _.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
                $(this).attr('id', '');
            });

        }`

+1

+1

+1  This issue is over a year old.... surely something can be done for this as its stopped me using it on a project as well once I discovered this.

+1 after this issue I am always using owl carousel...(
On Saturday, 30 April 2016, arkid<EMAIL_ADDRESS>wrote:

+1 This issue is over a year old.... surely something can be done for this
as its stopped me using it on a project as well once I discovered this.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-215960719

--
*Best wishes and have a nice day! *
Levon Grigoryan.

+1

This is driving me nuts.
I have 13 slides. Tested infinite:true, variableWidth: true, slidesToScroll: 3.
So if I delete 1 slide and that makes last transition smooth and there's no jumping between last and first slide (in next round).
Now I can either delete 13th slide or add 2 to make it work with slidesToScroll: 3.
Or add 1 to make it work with slidesToScroll: 2.

+1

+1

This worked for me..
infinite: true,
slidesToShow: 2,
centerMode: false,
variableWidth: true,
speed: 400,
cssEase: 'ease-in-out',
adaptiveHeight: true
Been trying for weeks!

+1

+1

+1

+1

any update ?

+1, especially for infinite set to false

I'm also having to switch to another slider plugin because of this issue. I love Slick but for my current project, this kills it.

is there any useful way fixed this problem?

@evalunamain solution worked for me, I don't know why this happens, but if you set the slides to show half of the current slides, then it wont make that jump:
$('.slickSlider').slick({
prevArrow: $('.prev'),
nextArrow: $('.next'),
infinite: true,
speed: 300,
slidesToShow: 2,
centerMode: true,
variableWidth: true
});

Looks like it depends on how many slides you want to show on the screen. For example, if you set "slidesToShow: 1", white space will occur until 1 slide lefts on the screen and just after this slider will show other slides from the begining. If you set "slidesToShow: 6" white space will dissapear when 6 slides left.

The issue that I was facing was not on small viewport but on full screen viewports over 1440px where blank slides came at the end before infinite loop could begin. The number of blank slides at the end were equal to the number of slides that had to be shown per view.
I have been able to get this working across all viewports and multiple tiles with the following configuration:
                    centerMode: true,
                    infinite: true,
                    centerPadding: '150px',
                    adaptiveHeight: false,
                    slidesToShow: 2,
                    variableWidth: true,
                    autoplay: true,
                    autoplaySpeed: 2000

I used parts of previously added solutions from @keep4r  and @Carlospineiro . I added the following stuff:

clones: 5 in default options.
2    Updating Infinite generating Loops:
for (i = _.slideCount; i > (_.slideCount - infiniteCount - _.options.clones); i -= 1)
for (i = 0; i < infiniteCount + _.options.clones; i += 1)
Add this to ensure that you always have a next/prev slide to show

if(_.$slideTrack.children('.slick-slide').eq(_.slideCount - 1).hasClass("slick-active")){
      targetSlide = _.$slideTrack.children('.slick-slide').eq(_.slideCount - 1);
      targetLeft = $(targetSlide[0]).closest(".slick-slider").width() - (targetSlide[0].offsetLeft + targetSlide[0].offsetWidth);
}

Hope that helps. Thanks

+1

+1 to this issue

+1
critical bug exist 1.5 years

What solved it for me was setting slidesToShow N-1, where N is the total number of slides. The number has to be at least the amount of slides that can be visible in the slider at the same time. Setting it to an x >= N prevented autoplay.

$('.variable-width').slick({
dots: true,
infinite: true,
speed: 300,
rtl: true,
autoplay: true,
slidesToShow: 6,
variableWidth: true
});
then slider will show blank, Have any solution?

+1

hello guys,
I got solution,
set slider div dir="rtl"
and
$('#slick-slider').slick({
dots: false,
infinite: true,
speed: 800,
autoplaySpeed: 10000,
rtl: true,
slidesToShow: 5,
draggable: false,
autoplay: true,
slidesToScroll: 1
});

@m-sarkar That simply hides all my slide items.

@rmartins90  check this markup

Got it. But didn't solve the original issue as well.

+1

+1

+1

+1

+1

+1

+1

Following the suggestion from @PiotrKalachyn above fixed things for me! Here's a simplified version of what I ended up using:
// Setup Slick w/count to side-step empty space (issue #1207)
$('.slider).each(function() {
  var count = $(this).find('.slider__item').length;

  $(this).slick({
    infinite: true,
    slidesToShow: count - 1,
    variableWidth: true
  });
});

For those, who have problems with the infinite slider.
search for
for (i = 0; i < infiniteCount; i += 1) {                     slideIndex = i;                     $(_.$slides[slideIndex]).clone(true).attr('id', '')                         .attr('data-slick-index', slideIndex + _.slideCount)                         .appendTo(_.$slideTrack).addClass('slick-cloned');                 }                 _.$slideTrack.find('.slick-cloned').find('[id]').each(function () {                     $(this).attr('id', '');                 });
and change it to
 for (i = 0; i < infiniteCount + _.slideCount; i += 1) {                     slideIndex = i;                     $(_.$slides[slideIndex]).clone(true).attr('id', '')                         .attr('data-slick-index', slideIndex + _.slideCount)                         .appendTo(_.$slideTrack).addClass('slick-cloned');                 }                 _.$slideTrack.find('.slick-cloned').find('[id]').each(function () {                     $(this).attr('id', '');                 });

@xXanth0s
Just tried your suggestion, it did not solve the problem for me.

I am having this same issue. I have some breakpoints setup, and I've noticed that this only happens when the slider is first initialized. When it reloads at a breakpoint, the infinite slider works as expected. Only when I refresh the page does it sorta break again.

+1

+1

+1

Same issue for me. I tried the for (i = 0; i < infiniteCount + _.slideCount; i += 1) fix above but that didn't seem to fix anything.

+1

+1

this style works for me
.slick-track {     overflow-x: scroll; }

+1
I have an infinite auto scrolling carousel, when looping back to the first slide, the image was always blank until the slide finished animating, this JS solved this issue for me:
`
$carousel.slick({
infinite: true,
autoplay: autoplay,
speed: 1000,
slidesToShow: 1
});
$carousel.on('beforeChange', function(e, slick, currentSlide, nextSlide){
    var $this = $(e.currentTarget);
    var $nextBanner = $this.find('[data-slick-index="'+nextSlide+'"] .component-carousel-slide');
    $(".slick-cloned").find(".component-carousel-slide").css("background", $nextBanner.css("background"))
});

`

+1
Until this bug is fixed, I've to use Owl...

Spent a long time looking for something that would achieve this, finally found this slider which did exactly what I needed:
http://richardscarrott.github.io/jquery-ui-carousel/

I found that setting infinite to false and draggable to false solves this issue.

Setting up "arrows: false" helped to me.

+1

+1 please! :pray:

+1

@PiotrKalachyn's hack works perfect for me. Thanks!

+1

+1

@xXanth0s Thanks, fixed the problem for me. To explain for the other: the problem was that when in infinite mode, first slide is cloned to the end of the carousel to allow fluent transition, but until this cloned slide reaches left margin of the screen to "connect" to the start again, white space is shown on the right. xXanth0s's solution clones multiple slides to the end, so the empty space is covered until the first clonned slides gets to the left age and slider can connect to the beginning for new loop.

@xXanth0s solution works like a charm! Many thanks!!!

@PiotrKalachyn 's solution fixed the issue for me as well.

hello, because the https://github.com/kenwheeler/slick/issues/1207#issuecomment-263908723 proposed by @xXanth0s touch the slick script, maybe can we consider the issue closed only if and after a patch will be committed?

xXanth0s commented on Nov 30, 2016
https://github.com/kenwheeler/slick/issues/1207#issuecomment-263908723
patching using xXanthOs work works.
+1

Any news about this issue?!?

@jmharveys like skaught states in the above comment, I can confirm #1207 (comment) xXanth0s' patch works.

@tourtools The bug is still happening for me when i'm using ' variableWidth' inside a breakpoint!

We would love to use slick-carousel (wrapped within a react component) for the new backend we are currently creating for our CMS (www.neos.io). Any chance this bug might be fixed soonish?

+1

So this was the most aggravating bug but I finally figured it out. I scoured the other solutions but it just didn't pan out for me. This works though and as far as I can tell works 100% of the time, even if you resize. I'm going to fork the project and clean up a lot of the code but for now....
Go to the Slick.prototype.slideHandler and find this code at the bottom
if (dontAnimate !== true) {
  _.animateSlide(targetLeft, function() {
  _.postSlide(animSlide);

Then add this **BEFORE ** it.
slickWidth = $('.slick-list').width()
var allSlides = _.$slideTrack.children('.slick-slide')
var cumulativeSize = 0;

for(var i = _.currentSlide; i < _.slideCount; i++) {
  cumulativeSize += $(allSlides[i]).width()
}

if(cumulativeSize < slickWidth) {
  for(var i = _.currentSlide; i > 0; i--) {
    cumulativeSize += $(allSlides[i]).width()
    if(cumulativeSize >= slickWidth) {
      targetLeft = _.getLeft(i)
      animSlide = _.getLeft(i)
      _.currentSlide = i
      break;
    }
  }
}

Basically we are saying "Go through all remaining slides and find out their width and add that together. If it's not big enough then walk backwards through the slides and add another slide until we have enough to fit.  Hope this saves someone some time.

@MattStopa This is great news! Feel free to ping me as soon as the pull request is ready for testing. Thanks a lot for looking into this important issue!

@gerhard-boden I'm probably not going to open a PR since there are 116 PR's that haven't been merged on this project yet. I may fork my own version though. Feel free to use this code and add it in if you want to.

There are still PRs being merged and this one is definitely an important fix I'd say. Would be great to have it in an official release as well 😃

@gerhard-boden Alright let me fork it

@MattStopa Awesome, thanks a lot! Will test and review on the upcoming weekend!
Hope everyone who responded here lately will take notice of the PR and "upvote" it by approving.

@xXanth0s patch worked for me, @MattStopa's didn't.

Must be for a different sett8ng
On Jul 26, 2017 6:01 PM, "Corey Tenold"<EMAIL_ADDRESS>wrote:

@xXanth0s https://github.com/xxanth0s patch worked for me, @MattStopa
https://github.com/mattstopa's didn't.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-318195979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALqUVteBpS4jn2kcRSWDwi8EfcfHXRIks5sR7c_gaJpZM4D6_WK
.

The following worked for me:

specifically setting the width of each slide
not setting the "slidesToShow" prop
infinite = true

Its not a beauty solution but i resolved cloning the code on version 1.7.1
`                for (i = 0; i < infiniteCount  + .slideCount; i += 1) {
slideIndex = i;
$(.$slides[slideIndex]).clone(true).attr('id', '')
.attr('data-slick-index', slideIndex + .slideCount)
.appendTo(.$slideTrack).addClass('slick-cloned');
}
            _.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
                $(this).attr('id', '');
            });

            for (i = 0; i < infiniteCount  + _.slideCount; i += 1) {
                slideIndex = i;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex + _.slideCount)
                    .appendTo(_.$slideTrack).addClass('slick-cloned');
            }

            _.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
                $(this).attr('id', '');
            });`

Its not a beauty solution but i resolved cloning the code on version 1.7.1
            for (i = 0; i < infiniteCount  + _.slideCount; i += 1) {
                slideIndex = i;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex + _.slideCount)
                    .appendTo(_.$slideTrack).addClass('slick-cloned');
            }

            _.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
                $(this).attr('id', '');
            });

            for (i = 0; i < infiniteCount  + _.slideCount; i += 1) {
                slideIndex = i;
                $(_.$slides[slideIndex]).clone(true).attr('id', '')
                    .attr('data-slick-index', slideIndex + _.slideCount)
                    .appendTo(_.$slideTrack).addClass('slick-cloned');
            }

            _.$slideTrack.find('.slick-cloned').find('[id]').each(function() {
                $(this).attr('id', '');
            });

@MattStopa's fix worked for me! Glad I don't have to bin off this slider - the "center" option is super handy.

This quick fix help me for my project. This solved my blank space problem perfectly. Willing to share with all of you - https://codepen.io/foysalremon/pen/KoWjLg

Any general solution to this problem in sight?

I'm using version 1.9.0.
Tried all the proposed fixes here, but none worked.
Any update on this issue?
It's really been a headache

Guys
For the white space issue I have found a solution.
In the current version @1.9.0
My slick options were below
 $('.your-class').slick({
            dots: true,
            variableWidth: true,
            centerMode: true,
            infinite: true,
            responsive: [
                {
                    breakpoint: 767,
                    settings: {
                        slidesToShow: 1,
                        slidesToScroll: 1,
                        infinite: true,
                        dots: true,
                        variableWidth: true
                    }
                }
            ]
        });

Step1:
line number 1177
replace the below
targetSlide = _.$slideTrack.children('.slick-slide').eq(slideIndex + _.options.slidesToShow + 1);
with
targetSlide = _.$slideTrack.find('[data-slick-index="'+slideIndex+'"]');
The above one centers the our actual first slide. Previously slick was taking the targetslide as first clone which is having data-slick-index = -2.
Step 2:
The next step is in the slick setupInfinite method
change the first for loop
for (i = _.slideCount; i > (_.slideCount - infiniteCount); i -= 1)
to the below
for (i = _.slideCount; i > 0; i -= 1)
The above for loop adds more clones to the left. Previously it was adding only 2 clnes to the left

What's up about fix ? I don't be a fan about touching the standard behavior of the lib, I won't add regresison and causing breaking just for one specific case.

@ShakurOo  In my case it didn't break any other functionality.

Hi guys. I had the same issue - my slider was 35k pixel in length  and this code
*{ min-height: 0; min-width: 0; })
didn't work for me unfortunately.
So  i found a simple fix:
add.carousel {     overflow: hidden;     min-width: 100%;     width: 0; } this styles to ur slider.
That solve my problem and enormous length disappeared.

3 years later and I'm also getting this problem

Actually I solved my issue and it was slightly different.
My infinite carousel would load my slides fine (~3 shown, moving one increment) but when it wrapped the first slide did not show its background. The text loaded fine but the BG was empty. Incrementing again the second slide had this issue and the last slide (now in position 1) was the only to show its BG. Incrementing again to make a full cycle would make slides 1, 2, and 3s background pop in and the carousel would load images fine until it reached the end where this behavior happens again. Going backwards from slide 1 would cause the same problem -- the last slide would have no BG, the second to last slide would have no BG, then BAM all 3 pop in.
My solution (after trying all of them here) was to change all of my IDs on my slides to classes. And it works! It was that easy. I realized this after removing my ID BGs and noticing that setting my slides .class with a generic BG would not reproduce the error and worked from there.
Hopefully this will help someone with this issue or leads to it being patched.

I had the same problem, I have managed to resolve it for my issue.
I had a CSRF within the slide class e.g.
<input type="hidden" id="token" value="{{ csrf_token() }}"> as soon as I moved that hidden input out of the div with a class name of slide this got rid of the empty slide for me.
I hope this might help some of you.

+1
@kenwheeler over 3 years later this is still a problem

i had to make a list of the bugs that occur with the settings for my colleagues.

"additionalFiles" is yes when images are added to the slider after initialisaton
size big and size small is when the slider is in a responsive div and its either big or small (no dimensions written down)

this is what i came up with:

An example when inifinite, centerMode & variableWidth are true + images are added after init.
The 3 images you see (actually 4 loaded) are added AFTER the initialisation. they appear as the first images. once you drag or click on the arrow, it will jump 5 images because the images added after inititalisation do not change the index. The index that should be active is 1 but its pushed far to the right.

+1 please fix this

+1

+1

Any updates here?

November 2018 still got bug.

I disabled infinite scroll. It is too buggy

As good workaround I suggest to calculate slidesToShow setting e.g.
var slidesToShow = Math.round(slickContainerWidth / slideWidth);

$('.slick').slick({
...
slidesToShow: slidesToShow
});

+1

+1

Hi guys, I solve this problem by editing into the library at un-minified version line number  2131 where code should say this:
} else if (_.options.variableWidth === true) {
    _.$slideTrack.width(5000 * _.slideCount);
}

Replace this:
_.$slideTrack.width(5000 * _.slideCount);

by:
var calc = 0;
_.$slides.each(function(element) {
    var styles = window.getComputedStyle(element);
    var marginLeftRight = parseInt(styles.marginLeft, 10) + parseInt(styles.marginRight, 10);
    calc = calc + element.offsetWidth + marginLeftRight + 1; // +1 for decimal values caught by browser.
});
_.$slideTrack.width(calc);

My slider settings follows like this:
$('.mySelector').slick({
    autoplay: false,
    infinite: false,
    slidesToShow: 8,
    variableWidth: true,
    arrows: true
});

Good Luck 👍

Hi guys, I solve this problem by editing into the library at un-minified version line number 2131 where code should say this:
} else if (_.options.variableWidth === true) {
    _.$slideTrack.width(5000 * _.slideCount);
}

Replace this:
_.$slideTrack.width(5000 * _.slideCount);

by:
var calc = 0;
_.$slides.each(function(index, element) {
    var styles = window.getComputedStyle(element);
    var marginLeftRight = parseInt(styles.marginLeft, 10) + parseInt(styles.marginRight, 10);
    calc = calc + element.offsetWidth + marginLeftRight + 1; // +1 for decimal values caught by browser.
});

My slider settings follows like this:
$('.mySelector').slick({
    autoplay: false,
    infinite: false,
    slidesToShow: 8,
    variableWidth: true,
    arrows: true
});

Good Luck

Work fine!

For those, who have problems with the infinite slider.
search for
for (i = 0; i < infiniteCount; i += 1) { slideIndex = i; $(_.$slides[slideIndex]).clone(true).attr('id', '') .attr('data-slick-index', slideIndex + _.slideCount) .appendTo(_.$slideTrack).addClass('slick-cloned'); } _.$slideTrack.find('.slick-cloned').find('[id]').each(function () { $(this).attr('id', ''); });
and change it to
 for (i = 0; i < infiniteCount + _.slideCount; i += 1) { slideIndex = i; $(_.$slides[slideIndex]).clone(true).attr('id', '') .attr('data-slick-index', slideIndex + _.slideCount) .appendTo(_.$slideTrack).addClass('slick-cloned'); } _.$slideTrack.find('.slick-cloned').find('[id]').each(function () { $(this).attr('id', ''); });

This should honestly be PR'd into the current branch. Absolutely fixed my issue. Not to mention, I've had this issue on 3 seperate projects now. It seems like EVERY time I use slick, there's some sort of library ruining bug.  The bugs in this thing are brutal, and the fact that this fix hasn't been even looked at or included in current versions is beyond me.
Good job finding this man. Saves me hours of wasted time searching for the solution.

@pablo67340 The only thing that is brutal is you talking like this about someone who "wasted" hundreds of hours to build a free slider that makes thousands of people happy. Try to build this on your own. You'll either fail or "waste" the next years perfecting this thing to please EVERYONE in the world FOR FREE and still constantly get hate from people like you, because there is always a better way to do it.

@pablo67340 The only thing that is brutal is you talking like this about someone who "wasted" hundreds of hours to build a free slider that makes thousands of people happy. Try to build this on your own. You'll either fail or "waste" the next years perfecting this thing to please EVERYONE in the world FOR FREE and still constantly get hate from people like you, because there is always a better way to do it.

Free or not, this issue was opened LAST YEAR. There are over 150 comments, and its still sitting doing nothing. I understand its something free, and people have better things to be doing, making a living, etc. But when absolutely 0 shits are given about established issues like this, that's when I have a problem. Not to mention, the guy practically shits on people who gives ideas for enhancements and fixes.
https://cdn.discordapp.com/attachments/510627683449962510/559904888700534805/unknown.png
Hop off buddy

You wanna take over maintenance of the lib bud?
On Thu, Mar 28, 2019 at 10:13 AM Bryce Wilkinson<EMAIL_ADDRESS>wrote:

@pablo67340 https://github.com/pablo67340 The only thing that is brutal
is you talking like this about someone who "wasted" hundreds of hours to
build a free slider that makes thousands of people happy. Try to build this
on your own. You'll either fail or "waste" the next years perfecting this
thing to please EVERYONE in the world FOR FREE and still constantly get
hate from people like you, because there is always a better way to do it.
Free or not, this issue was opened LAST YEAR. There are over 150 comments,
and its still sitting doing nothing. I understand its something free, and
people have better things to be doing, making a living, etc. But when
absolutely 0 shits are given about established issues like this, that's
when I have a problem. Not to mention, the guy practically shits on people
who gives ideas for enhancements and fixes.
https://cdn.discordapp.com/attachments/510627683449962510/559904888700534805/unknown.png
Hop off buddy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477612324,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARfmOinX69pXHzv1Vik-lF32gTySZoCks5vbM34gaJpZM4D6_WK
.

You wanna take over maintenance of the lib bud?
…
On Thu, Mar 28, 2019 at 10:13 AM Bryce Wilkinson @.***> wrote: @pablo67340 https://github.com/pablo67340 The only thing that is brutal is you talking like this about someone who "wasted" hundreds of hours to build a free slider that makes thousands of people happy. Try to build this on your own. You'll either fail or "waste" the next years perfecting this thing to please EVERYONE in the world FOR FREE and still constantly get hate from people like you, because there is always a better way to do it. Free or not, this issue was opened LAST YEAR. There are over 150 comments, and its still sitting doing nothing. I understand its something free, and people have better things to be doing, making a living, etc. But when absolutely 0 shits are given about established issues like this, that's when I have a problem. Not to mention, the guy practically shits on people who gives ideas for enhancements and fixes. https://cdn.discordapp.com/attachments/510627683449962510/559904888700534805/unknown.png Hop off buddy — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1207 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AARfmOinX69pXHzv1Vik-lF32gTySZoCks5vbM34gaJpZM4D6_WK .

Wouldn't take 3 years to implement a fix someone else had to find. Can tell you that much.

No I’m literally asking.
On Thu, Mar 28, 2019 at 10:15 AM Bryce Wilkinson<EMAIL_ADDRESS>wrote:

You wanna take over maintenance of the lib bud?
… <#m_-4857339202042287895_>
On Thu, Mar 28, 2019 at 10:13 AM Bryce Wilkinson @.***> wrote:
@pablo67340 https://github.com/pablo67340 https://github.com/pablo67340
The only thing that is brutal is you talking like this about someone who
"wasted" hundreds of hours to build a free slider that makes thousands of
people happy. Try to build this on your own. You'll either fail or "waste"
the next years perfecting this thing to please EVERYONE in the world FOR
FREE and still constantly get hate from people like you, because there is
always a better way to do it. Free or not, this issue was opened LAST YEAR.
There are over 150 comments, and its still sitting doing nothing. I
understand its something free, and people have better things to be doing,
making a living, etc. But when absolutely 0 shits are given about
established issues like this, that's when I have a problem. Not to mention,
the guy practically shits on people who gives ideas for enhancements and
fixes.
https://cdn.discordapp.com/attachments/510627683449962510/559904888700534805/unknown.png
Hop off buddy — You are receiving this because you were mentioned. Reply to
this email directly, view it on GitHub <#1207 (comment)
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477612324>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARfmOinX69pXHzv1Vik-lF32gTySZoCks5vbM34gaJpZM4D6_WK
.
Wouldn't take 3 years to implement a fix someone else had to find. Can
tell you that much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477613383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARfmJgCUgv6Mr_VfD88_oC4L2Lb7bB2ks5vbM6XgaJpZM4D6_WK
.

If I were to make a PR, be honest and tell me how long it would take for you to press merge.

I’ll eventually rewrite it in regular JS, when the need for legacy browser
support disappears, but right now i have two kids and I work in finance
tech and haven’t needed a carousel in 4 years. So if you’d like to maintain
it, I’d be happy that someone is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477613909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARfmL1X-khHEn1-g051rbCvRNaxysKiks5vbM7qgaJpZM4D6_WK
.

You're absolutely correct. I apologize for shitting on your work. I've just been getting very annoyed at chasing slick bugs on almost every website I use it in. Not sure if its my custom styling or whats up, but its very consistent, and the same issues across all sites. Ill fork, commit and make a PR to actually contribute for the greater good rather than shitting on you and your hard work.
Again I apologize for how I approached things here.

Hey, Ken, you've done a great job.
This project has enabled the impossible for many of us, I don't know any
other script that comes close to doing what yours does.
People usually don't like to fork someones work and start promoting the new
one unless the author is no longer maintaining it, or a new core group is
formed to maintain the work.
Several years ago I was using this project in a large financial project and
I had made a number of modifications to the script to suit that projects
purposes.  At the time the code was written so that we could submit a PR
back to the original project.  ( but it never happened for corporate
reasons )
This was actually one of the issues that we had resolved, and I made a
number of augmentations so that I could connect the list to a number of
datasource type objects.  We got it working with Angular 1, knockout,
backbone and I think react.  I wonder if I could find that old code and
rewrite it and contribute it back.
I know it came off as a bit gruff, and I have a 2 year old now so I know
now much work little ones are, but are you serious about supporting a fork
or supporting a new core community to maintain the script?  I wouldn't want
to be the only one supporting it, but I would be interested in helping.
I think one of the core challenges in opening up the maintenance of the
script would be to put some minimal best practices like testing, linting,
etc.  You mention pure JS, did you mean ES5, ES6, or later?
If you don't want to do this alone, I think many hands may make the load
lighter.  Is that of interest to you?
Otherwise, I'm patient and thankful for your work.
On Thu, Mar 28, 2019 at 9:08 AM Bryce Wilkinson<EMAIL_ADDRESS>wrote:

You wanna take over maintenance of the lib bud?
… <#m_-2046794364187891135_>
On Thu, Mar 28, 2019 at 10:13 AM Bryce Wilkinson @.***> wrote:
@pablo67340 https://github.com/pablo67340 https://github.com/pablo67340
The only thing that is brutal is you talking like this about someone who
"wasted" hundreds of hours to build a free slider that makes thousands of
people happy. Try to build this on your own. You'll either fail or "waste"
the next years perfecting this thing to please EVERYONE in the world FOR
FREE and still constantly get hate from people like you, because there is
always a better way to do it. Free or not, this issue was opened LAST YEAR.
There are over 150 comments, and its still sitting doing nothing. I
understand its something free, and people have better things to be doing,
making a living, etc. But when absolutely 0 shits are given about
established issues like this, that's when I have a problem. Not to mention,
the guy practically shits on people who gives ideas for enhancements and
fixes.
https://cdn.discordapp.com/attachments/510627683449962510/559904888700534805/unknown.png
Hop off buddy — You are receiving this because you were mentioned. Reply to
this email directly, view it on GitHub <#1207 (comment)
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477612324>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AARfmOinX69pXHzv1Vik-lF32gTySZoCks5vbM34gaJpZM4D6_WK
.
Wouldn't take 3 years to implement a fix someone else had to find. Can
tell you that much.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-477613383,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPRFh35XkPe2Dcrefwpl4nQFguFRvzwks5vbM6ygaJpZM4D6_WK
.

--
--
Justin Kruger
Social Media Software Engineer -
San Francisco, CA
--
http://jDavid.net
http://twitter.com/jdavid
http://www.linkedin.com/in/jdavid
--
<EMAIL_ADDRESS>

At the end of getLeft method
I add this
            if (_.options.variableWidth === true && targetLeft < 0) {
                var elTotalWidth = 0;
                this.$slides.each(function () { elTotalWidth += $(this).outerWidth(); });
                var endOfSlider = window.innerWidth - elTotalWidth;
                if (targetLeft < endOfSlider) {
                    targetLeft = endOfSlider;
                }
            }

At the end of getLeft method
I add this
 if (_.options.variableWidth === true && targetLeft < 0) {
     var elTotalWidth = 0;
     this.$slides.each(function () { elTotalWidth += $(this).outerWidth(); }
     var endOfSlider = window.innerWidth - elTotalWidth;
     if (targetLeft < endOfSlider) {
        targetLeft = endOfSlider;
    }
}

Maybe this will help someone

Looks good and works for me @Ivan1234, though you're missing some markup which breaks slick if pasted straight into the end of getLeft
this.$slides.each(function () { elTotalWidth += $(this).outerWidth(); }  this line needs ); at the end of it. so the whole thing now looks like
if (_.options.variableWidth === true && targetLeft < 0) {
    var elTotalWidth = 0;
    this.$slides.each(function () {
        elTotalWidth += $(this).outerWidth();
    });
    var endOfSlider = window.innerWidth - elTotalWidth;
    if (targetLeft < endOfSlider) {
        targetLeft = endOfSlider;
    }
}

This is a bit of a hacky way of filling the whitespace but it works for my case if anyone else finds it useful. You may have to tweak it for your situation.
Add it BEFORE you initialise your slider and it will add 3 slides to the end to fill the whitespace and give the illusion of infinite scroll.
    $('.slider-container').on('init', function(event, slick, currentSlide, nextSlide){
      $('.slick-current').next().clone().appendTo( ".slick-track" );
      $('.slick-current').next().next().clone().appendTo( ".slick-track" );
      $('.slick-current').next().next().next().clone().appendTo( ".slick-track" );
    });

I have however noticed that it doesn't seem to work again after resizing from a responsive breakpoint.

Who's from 2020?

I am also facing the same issue.

Have same issue when I use:
variableWidth: thrue,
centerMode: true,
infinite: true.
Then if I want to move from first slide back, last slide has about 1 seconds delay before it stay visible.

I see this issue for infinite scroll jump been there since 2015, still no fix.

I see this issue for infinite scroll jump been there since 2015, still no fix.

Looks like this is an abandoned issue? Emcountering this with React-Slick
I absolutely love using Slick Carousel, but this looks like one of the edge-cases where we will need to switch to a different implementation - looking at Swiper now.

Update: 6 years and counting. Lovin it

+1

+1 lol
On Tue, Jun 1, 2021 at 1:28 PM nelsonthekat @.***>
wrote:

+1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-852424185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACH7NMKCZYPMQ7YYAAFXB3TQU7HJANCNFSM4A7L6WFA
.

--
Jacob Morgan |<PHONE_NUMBER> | jjmorga at gmail dot com
https://www.linkedin.com/in/jacobmorgan/
https://www.instagram.com/carbon8sf/ https://github.com/jjmorga/
https://open.spotify.com/user/yakfang

was a fix ever made for this @kenwheeler

+1

+1, still need it in 2022

I forgot what the issues was back then :D

@kenwheeler pls make pablo the owner

still need this fix

+1

For everyone still using SlickSlider, it didn't receive updates for the past 5 years. Here is your alternative -> https://swiperjs.com/ it does everthing SlickSlider does but then better and a lot more. Also it is maintained 😄

Or another good alternative: https://github.com/metafizzy/flickity

2023 checking in: Please make Pablo the owner in lue of your absence @kenwheeler

Pov: I'm waiting on @kenwheeler to release pr access to Pablo

⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⣀⣠⡤⢤⣤⣀⣀⡀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡀⠀⣀
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⡴⠞⠉⠁⠀⠀⠀⠀⠀⠀⠀⠉⠙⠲⢤⡀⠀⠀⣠⡴⠒⠋⠉⠉⠉⠉⠉⠛⠲⢤⡀
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⠞⠉⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠙⢶⡋⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠉⠳⡄
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⡞⠁⠀⠀⠀⠀⠀⠀⠀⠀⣀⣀⣀⣀⣀⣀⣀⡀⠀⠀⠀⢻⡄⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠹⡆
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣰⠏⠀⠀⠀⠀⠀⣀⣤⠶⠚⠉⠁⠀⠀⠀⠀⠀⠀⠉⠙⠲⢤⣀⣻⣀⣀⣀⣀⣤⣤⠤⠤⠤⠤⠤⣤⣄⣀⣹⡀
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣰⠃⠀⠀⠀⠀⠀⠘⠋⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠉⠻⣍⡀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠉⠉⠓⢤⡀
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⡏⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣀⡤⠤⠶⠒⠒⠒⠒⠒⠒⠚⠻⠦⣄⠀⠀⣀⣠⠤⠶⠖⠒⠒⠒⢚⣛⣓⠶⠤⠽⣦⣀
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣠⣾⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⡤⠶⠛⠉⢀⣀⣠⠤⠶⠖⠒⠛⠛⠛⠓⠶⠤⣼⣟⣫⡥⠶⠖⠛⠉⠉⠉⠉⠉⠉⠉⠉⠛⠳⠶⣽⣧
⠀⠀⠀⠀⠀⠀⠀⠀⣠⠞⠉⢰⡇⠀⠀⠀⠀⠀⠀⠀⣀⣴⣶⣯⡥⠶⠒⠛⠉⠁⠀⠀⠀⠀⠀⣀⣀⣤⣤⡤⠤⠤⠭⢿⠁⠀⠀⣀⣤⡤⠶⠒⠒⢺⣯⣭⣉⠙⠓⠒⠦⣽⣷⡄
⠀⠀⠀⠀⠀⠀⠀⡼⠃⠀⠀⢸⣧⠀⠀⠀⠀⠀⠀⠈⣯⡍⠁⠀⠀⢀⣀⣀⣀⣠⠤⠴⢒⣿⠿⣿⣾⣿⣦⣄⠀⠀⠀⢘⡗⠚⠉⠁⠀⠀⢀⣴⣟⠙⣿⣿⣿⣿⣦⠀⠀⠀⠹⡄
⠀⠀⠀⠀⠀⠀⣸⠃⠀⠀⠀⠙⠉⠀⠀⠀⠀⠀⠀⠀⠈⠙⠛⠛⡿⣍⡉⠀⠀⠀⠀⣰⣿⣿⣦⣾⡿⠛⢿⣿⣧⠀⢀⣼⠁⠀⠀⠀⠀⢀⣿⣿⡿⣿⣿⡁⢈⣿⣿⡆⣀⣠⡼
⠀⠀⠀⠀⠀⣰⠃⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠐⢧⣀⡉⠲⠦⣀⡀⣿⣿⣿⣯⣿⣷⣶⣾⡿⠿⠓⢋⡽⠓⠶⠦⢤⣀⣼⠿⠿⠿⠿⠿⠿⠟⠛⠛⢉⣿⠟
⠀⠀⠀⠀⣰⠋⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠉⠙⠒⠲⠯⠿⠯⣯⣯⣭⣭⣤⢤⣦⠶⠖⠋⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⡴⠋
⠀⠀⠀⣰⠏⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣠⣤⠾⠛⠀⠀⠀⠀⠰⣦⣀⠀⠀⠀⠀⠀⠀⢀⣀⣤⠶⠋
⠀⠀⣰⠏⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⡤⠶⠋⠉⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠙⠻⣿⠛⠉⠉⠉⠁⠙⢦⡀
⠀⣰⠏⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠉⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠀⠀⠀⠀⠀⠀⠀⠹⡄
⢰⡏⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢹⡄
⣼⠁⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣷
⢻⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⡴⠞⠋⠉⠉⠉⠉⠙⠛⠒⠲⠶⠦⣤⣀⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣀⣠⠴⠞⠙⣧
⠸⣇⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡟⠀⠀⣤⠤⠤⠤⠤⠤⠤⠤⣄⣀⣀⠀⠀⠈⠉⠉⠛⠒⠒⠒⠲⠶⠶⠶⠶⠶⠶⠒⠒⠚⠋⠉⠁⠀⠀⢀⣴⠟
⠀⠹⣆⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢠⡀⠀⠀⣷⡀⠀⠁⠀⠀⠀⠀⠀⠀⠀⠀⠉⠉⠙⠓⠒⠶⠦⠤⠤⣤⣤⣀⣤⣀⣀⣀⣀⣀⣠⣤⠤⠤⠤⠤⠖⠒⡟⠁
⠀⠀⠹⣆⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⢷⡀⠀⠈⠛⠙⠛⠛⠓⠒⠶⠶⠦⠤⣤⣀⣀⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣰⠇
⠀⠀⠀⠈⠳⣄⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠛⢦⣤⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠉⠉⠉⠉⠛⠒⠒⠒⠒⠒⠒⠶⠦⠤⠶⠶⠶⢶⡶⠤⠖⠚⠉
⠀⠀⠀⠀⠀⠈⠓⠦⣄⡀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀⣠⠴⠋
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠉⠛⠶⠤⣄⣀⣀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⣀⡤⠖⠋⠁
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠈⠉⠉⠓⠒⠶⠶⠦⠤⣤⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⣀⡤⠴⠶⠖⠋⠉
⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⢀

+1

+1
On Fri, Sep 1, 2023 at 4:02 AM Ефим Быстров @.***>
wrote:

+1
—
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/issues/1207#issuecomment-1702571351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACH7NKC6DXDOV6WYLMJMETXYG6F7ANCNFSM4A7L6WFA
.
You are receiving this because you commented.Message ID:
@.***>

--
Jacob Morgan |<PHONE_NUMBER> | jjmorga at gmail dot com
https://www.linkedin.com/in/jacobmorgan/
https://www.instagram.com/carbon8sf/ https://github.com/jjmorga/
https://open.spotify.com/user/yakfang

slick is dead.
swiper to stand

Another one, just checking in here in 2024...

I’m here... after digging through the endless issue reports in hopes of getting a fix, I’ve finally hit a dead end.


Control register grouping

Hi, would it be possible to add intrinsics akin to vuint8m8_t __riscv_vreinterprete_8xu8m1(vuint8m1_t a, vuint8m1_t b, vuint8m1_t c, vuint8m1_t d, vuint8m1_t e, vuint8m1_t f, vuint8m1_t g, vuint8m1_t h).
This above would force the compiler to allocate the LMUL=1 registers a to h in a single LMUL=8 register. E.g. a=v0, b=v1, ..., h=v7.

You can currently do this with a sequence of calls to the "vector insertion intrinsics", e.g.,  __riscv_vset_v_i8m1_i8m8. Although this is more verbose than the single instruction you request, it is also more flexible.

Ah, true. This works, thanks.


SharedTree: External Delta PathVisitor API

Description
Incremental SharedTree enhancement providing support to a future DataBinder API.
This PR adopts newly released emit & collect eventing  functionality in the context of AnchorSet and AnchorEvents.
Provides for review the basis of an alternative Delta PathVisitor API drawing from @DLehenbauer proposal.
Breaking Changes
This change is backward compatible.

@CraigMacomber Appears that both DeltaVisitor.onSetValue as well as PathVisitor.onSetValue APIs may benefit from pursuing symmetry, eg propagate the current index in visitDelta. I am not sure whether not properly understanding the initial motivation for the current asymmetry. DeltaVisitor API evolution intentionally left out as creates  ripple effects and also unclear whether best addressed in these set of PRs.

@CraigMacomber Appears that both DeltaVisitor.onSetValue as well as PathVisitor.onSetValue APIs may benefit from pursuing symmetry, eg propagate the current index in visitDelta. Not properly understanding the initial motivation for the current asymmetry. DeltaVisitor API evolution intentionally left out as creates ripple effects and also unclear whether best addressed in these PRs.

Set value sets the value stored in a node. There is no "index" for that unless you mean the location of that node within its parent field, but thats encoded by the location of the node who's value is being set.


update requestContext for PUT and DELETE

We should have the legacy requestContext for ProcessorResult since we
parse each requestContext individually. Also, i’ve update default
entity headers and made the same approach to DELETE requests.

Looks good to me.

Looks okay, lets merge


drawing tool brokes panning/zooming

Once I draw an element, only way to "release" the drawing tool is to select another tool (eg. zoom) then go back to pan.
Workflow:

choose a drawing tool
draw a point/line/polygon and edit or not attributes
panning and zooming doesn't work anymore with mouse (ie. slider zoom/pan does work)

PS I'am using Google chrome on linux

I found the bug.
The pan tool was being disabled when the editing starts, which is the correct behaviour.  However, the pan button was not being "unchecked."  I've fixed the work flow. If you click the Pan button after editing, panning functionality will be restored.

Seems to work for me w/ build 97b9ce2.

Hmm, actually on further testing, I think Zooming is working fine after drawing, but Panning is still broken. Others should test and confirm...

OK figured ou the problem. The bug is technically fixed, however, when edit tools are enabled the mouse icon is a somewhat deceptive "hand" icon which can fool the user into thinking they have the pan tool active.
I suggest that a friendlier mouse icon for editing would be a pencil of even better, some sort of cross-hair symbol, to indicate where you are placing points / vertices.

I think that the icon is the previous/most recent icon.  Agree that pencil or cross-hair would be a better icon for editing.

Ah, I see, so there is a logic!

Maybe this is now a new issue that is an enhancement?

Closing and will address in #125


Add tests for atomic-server CLI

I tried doing this with assert_cmd, but for some reason my builds were failing.
I added these tests to server/src/tests.rs:
#[test]
fn wrong_command() {
    let mut cmd = assert_cmd::Command::cargo_bin("atomic-server").unwrap();
    cmd.args(&["non-existent-command"]).assert().failure();
}

#[test]
fn help() {
    let mut cmd = assert_cmd::Command::cargo_bin("atomic-server").unwrap();
    cmd.args(&["help"]).assert().success();
}

But while running in CI I got this:
thread 'tests::help' panicked at 'called `Result::unwrap()` on an `Err` value: CargoError { cause: Some(NotFoundError { path: "/home/runner/work/atomic-data-rust/atomic-data-rust/target/debug/atomic-server" }) }', server/src/tests.rs:175:65

I can reproduce this by removing the debug build locally rm target/debug/atomic-server, and then fix it with cargo build
So maybe simply adding a cargo build to all relevant CI runners should fix this too?

Problem was that integration tests should live in the tests directory instead of src


Master

I will check out the changes asap. Thank you.

Great work. I don't hear any clipping anymore. Having the thruster audio tied to the user input was a good idea.


Update LXD to latest stable

Description
Builds are failing because 5.13 doesn't exist anymore. This updates to the latest stable release of LXD.
Checklist

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that validate the behaviour of the software.
[ ] I validated that new and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I have bumped the version of any required library.

@gruyaume Can you re-review? I had to change the ordering of the CI build to get CI to succeed. Admittedly, I'm not sure why.


Hack first page behavior with aastex61

@drphilmarshall this should be an easy one.

We've always been using my hacked version. I have a few issues and pull requests filed with AASTeX (AASJournals/AASTeX60#38 and AASJournals/AASTeX60#42). I think renaming would cause more confusion.

@drphilmarshall @abmantz does someone have write access to resolve conflicts and merge this into the master?

Not sure. Github says the conflicts are "too complex to resolve in the editor", so that could be the reason that the button is grayed out. But whatever this patch was supposed to fix should now be pushed onto desc-tex, shouldn't it?

Yeah, that makes sense why it is grayed out (should have been merged long, long ago). I'll submit a PR to desc-tex.


feat: new methods to check enabled log level

Adding 6 methods on exported, logger and entry:

IsDebugEnabled() bool
IsInfoEnabled() bool
IsWarnEnabled() bool
IsErrorEnabled() bool
IsFatalEnabled() bool
IsPanicEnabled() bool

Replace duplicated if logger.level() >= XxxxLevel by a call to the new corresponding methods in logger and in entry
Closes #761

up ?

@lhauspie thanks for your contribution, I have requested a few changes.


Refactor V2 transforms

Clean up old V2 transforms as much as possible.

Will get to this start of next week. Manic week so far. Helpfully with existing v2 tests now, my comparison should be nice and easy thanks @CharliePoole :+1:


Implement np.unique

First thank you for the amazing work on JAX. It has made my life much easier!
I am currently working on a project where I need to use ˋnp.uniqueˋ and as a result I need to use both JAX and Numba in the same project. Which works fine but is not ideal.
It is my understanding that the shape of the output value of the function depends on the values of the input, and that’s something not easy to do in JAX. Thus Numpy’s implementation cannot be naively followed. I was maybe going to give it a shot, but I would first like to have your opinion about

Whether it seems doable;
How hard it would be

See #2760

My bad, closing.


chore: fresh package-lock with proper public npm registry

Impact: minor
Type: chore
Issue
Alternate npm registry URLs got into our package-lock.json files by mistake.
Solution
Generate fresh ones with the public npm registry
Breaking changes
None

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Runs listed as "Finished" in the WandB portal while still running

Hey—thanks for the super-helpful tool!
I have question—and maybe I've just overlooked something—but is there a way to make runs that are still ongoing to be listed as "Running" in the portal with using this tool? The default is for the runs to be "Finished" (see image) even though they're currently running...
I'm running an asynchronous evaluation tool that automatically picks up "Finished" runs, so these half-trained models are currently evaluated prematurely.

Thank you—best,
Lars

Thanks for the question @ankile. Basically wandb-osh doesn't do much other than triggering the wandb sync calls. So it sounds like if you call wandb sync /path/to/my/run, it will always mark the run as Finished. That would be another bug in the wandb CLI then. It might be good to bring this up to their attention (there's a lot not working well with the offline runs and syncing them multiple times).

Closing this because of inactivity. Feel free to reopen with comment though :)

Thank you, that's good to know. I will, at some point, try and verify that that is indeed the case. I will also try and bring this to their attention. Thanks again!


Generating Call Graph. And doubts.

@vitsalis @StefanosChaliasos
Dear Vitalis and Stefanos,
I am helping @amphioxis Martin to understand how to implement the fasten PyPI plugin (D2.7).
Following his reasonings, it comes a doubt regarding the call graphs creation when they are not present in the database.
So, Martin integrates into the createCallGraph.py the call creation using the function CallGraphGenerator imported from the pycg package.
My question is, are we proceeding correctly?
My doubt is this one:
" If there are call graphs in the database, is there any fasten-plugin able to create it, or should it be implemented now?"
Thank you in advance for your time and consideration,
Michele

Hi Michele,
From a quick check it looks like you're correctly using the CallGraphGenerator class. In the case that a call graph is not present in the database, one should create it manually using the process that you're following in the script.

Thank you, Vitalis.
Sorry for the late reply.
I am trying to help out Martin day by day, but this last week has been a little busy.
I am sure @amphioxis Martin is going to open an issue to understand better the call graph format provide by the
/mvn/packages/{pkg}/{pkg_ver}/callgraph endpoint.
Thank you for your constant help.
Sincerely,
Michele


Removing special character

Seems to be causing #5

Please see my comment in #5 for explanation on why this was closed.


[BUG]:Failed to retrieve the Cloudflare request context

What version of drizzle-orm are you using?
^0.30.4
What version of drizzle-kit are you using?
^0.20.14
Describe the Bug
I'm using next.js 14 with cloudflare D1. I have everything running locally running drizzle queries fine no problem. However when building the project to push to Cloudflare pages:build, I get
Failed to retrieve the Cloudflare request context
If I use cloudflare api instead of drizzle it works. Cloudflare has same tables as local.
/api/projects/routes.ts
export async function POST(request: NextRequest) {
  const clerkUser = getAuth(request);
  const result = await getPostSchema().safeParseAsync(await request.json());

  if(!clerkUser){
    return NextResponse.json("Unauthorized", { status: 401 });
  }

  // validate the form data
  if (!result.success) {
    return NextResponse.json({ message: result.error.issues[0].message, error: result.error.issues }, {status: 400});
  }

  const { title } = result.data

  try {
    const projectId = await db.insert(projects).values({ title: title }).returning({ id: projects.id });
    return NextResponse.json(projectId[0], { status: 200 });
  } catch (error) {
    console.error('Error inserting project', error);
    return NextResponse.json("Error inserting project.", { status: 500 });
  }
}

drizzle.ts
import * as users from './schema/users';
import * as projects from './schema/projects';
import * as userOnProjects from './schema/userOnProjects';
import { drizzle } from 'drizzle-orm/d1';
import { getRequestContext } from '@cloudflare/next-on-pages'

const db = drizzle(getRequestContext().env.DB, { schema: { ...users, ...projects, ...userOnProjects } });

export default db;

wrangler.toml
[[d1_databases]]
binding = "DB" # i.e. available in your Worker on env.DB
database_name = "split-sonic-prod"
database_id = "d57bbc32-b607-4c39-81ff-e82d6b43cb0c"
preview_database_id = "DB"

[env.preview]
name = "preview"
[[env.preview.d1_databases]]
binding = "DB" # i.e. available in your Worker on env.DB
database_name = "split-sonic-preview"
database_id = "e91bfc73-92c6-4551-b2c2-576a0eb4d50b"

Expected behavior
Cloudflare D1 to work with Drizzle on Cloudflare workers.
Environment & setup
Cloudflare pages:build

Managed to solve it with this


Support for Storage Volumes (partial)

We are adding support for the endpoints:

GET /rest/storage-volumes
POST/rest/storage-volumes
GET/rest/storage-volumes/{id}
DELETE/rest/storage-volumes/{id}

@balestrinc I've changed the description of the return of the methods get_all and get_by.
However, we could review and change it for all resources later. There are a lot of them like that.

@danielreed
Done. I have made all the suggested changes :smile:
Please, can you review again?

:+1:


refactor of the repo and the docker build

@mikethicke @tzouris @monotasker
OK, so I made a pretty aggressive refactor on the repo to hopefully make deployment/build a little less obfuscated (totally realize these were defaults from invenio).
Major points:

Invenio modules as git submodules: All the modules are now git submodules so they have a specified version (building the same commit in this repo will result in the same image built)
Move files for each container (kcworks, kcworks-frontend) into their own directory and structure the directories to better match the final resting place of the files in the container (make it easier to understand what to expect where inside the running container)
Nginx config refactored to be a little more dry.
Add traefik to proxy/terminate services in development
Removed any local / development customizations from the nginx config (and replicated in traefik)
Simplify the local mounts for docker compose development using the rearranged structure.
Remove SSL config for kcworks-frontend as the loadbalancer will terminate SSL
Update readme to reflect (most) of the changes
Created an "init-container" to handle copying static assets to the static assets volume.
Renamed the .dev docker compose to just docker-compose.yml for DX.

Remaining:

Fix an error in the ui container.. I'm guessing I didn't bootstrap something correctly
Add section to readme for how to trust / persist development certificates
Make sure local development of invenio modlues is still possible... the directory structure for invenio is not ideal, but it should be certainly doable.
Add Github actions build process for tagged commits to publish to ECR.
Do we need an init container to run migrations or anything like that... i.e. what would an "update" require be manually done?

I /think/ in my extremely humble opinion that most of these are improvements and not just preferences, BUT I've not been the ones in the weeds, so please know I won't take offence if something needs tweaks.

Thanks Brian, this all makes sense.
My main concern is getting the images pushed to ECR so Dimitris can use them for the production deployment. How close are we on that?

@mikethicke very. The frontend container should be good to go and when I can chat with Ian about the app container error on Monday I'm sure it'll be a quick fix.  (If not, the container itself isn't really any different from the original so we should be able to orchestrate and stand everything up one way or another by tomorrow) (bold proclamations, aside)


Check if rust-src contains a vendor dir, and patch it in

This is the cargo side of https://github.com/rust-lang/wg-cargo-std-aware/issues/23
Note that this design naively assumes there is only one version of each package. It does not robustly verify this, and will presumably just cryptically fail to resolve dependencies.

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

Note that these two PRs do not need to be synchronized at all.

The old cargo has no idea the vendor dir exists and won't notice it.
The new cargo will gracefully fall back to the current behaviour if a vendor dir isn't found.

This adds ~10MB to the rust-src component.

Yeah I verified this locally by:

building my new version of x.py dist
copying the rust-src vendor dir it produced to my rustup nightly toolchain
running -Zbuild-std on a local vendored project

I'm pretty confident it works because this method caught several mistakes I made while writing this! (like needing to copy the lockfile for vendor after all).

Ok great! I'm realizing now though that we can probably test this locally since we have basically a mock of the rust-std component and I think it should be possible to add a dependency only present in the vendor directory?
Also could you add some tests where test has its own dependency (like getopts) but then std doesn't use it? (to make sure no warnings are generated)

Can you point me to a test I can use as a template for this kind of thing?

I believe all those tests are housed here

@alexcrichton it occurs to me that I can tweak the vendored version to not have any hardcoded rustc-std-workspace crates and instead derive everything from the vendor. In theory this would let rust add new rustc-std-workspace crates without changing cargo. Is that desirable?

That'd be awesome yeah! Less hardcoded stuff in Cargo always sounds good to me

(test being a member would still be hardcoded)

New version that derives the existence of the std packages from the vendor pushed up.

Here's my first crack at testing the vendor logic.

One test I think that'd be good to add is to publish a version of the crates.io crate which would break the compilation if used.

This is a good idea, I've added it to the default environment every test uses to ensure all tests incidentally check this.

I'm a bit confused by the CI failure that happened on ubuntu-latest, nightly, i686-unknown-linux-gnu. It doesn't show up locally (even with deny-warnings). I don't have a linux box setup to test it either. Any ideas?

Are you sure you're testing with a nightly toolchain? Those tests only run on nightly and they're failing locally for me on mac with cargo +nightly test

I'll go dig out my macbook and see it it repro's there.

Ah, cut one too many corners and forgot that git won't add empty directories by default. Worked locally because the dirs still existed.

Looks great to me, thanks! @ehuss did you want to take a look or shall I r+?

Squashed

I'm not sure what the policy is in trying to keep cargo working with
different versions of rustc, but it seems worthwhile to keep this logic
active in case some future version of Rust can't/doesn't generate a vendor?
If you don't care, then sure I can delete it.
On Mon, Nov 9, 2020 at 5:05 PM Eric Huss<EMAIL_ADDRESS>wrote:

@ehuss commented on this pull request.
In src/cargo/core/compiler/standard_lib.rs
https://github.com/rust-lang/cargo/pull/8834#discussion_r520150516:

               .map_err(|_| anyhow::anyhow!("package name wasn't utf8"))?;

           // Remap the rustc-std-workspace crates to the actual rust-src libraries

           let path = if let Some(real_name) = name.strip_prefix(special_std_prefix) {

               // Record this crate as something to build in the workspace

               members.push(format!("{}{}", libs_prefix, real_name));

               libs_path.join(&name)

           } else {

               entry.path()

           };

           let source_path = SourceId::for_path(&path)?;

           let dep = Dependency::parse_no_deprecated(&name, None, source_path)?;

           Ok(dep)

       })

       .collect::<CargoResult<Vec<_>>>()?

} else {

Would it be possible to completely remove this else clause (assuming
rust-lang/rust#78790 https://github.com/rust-lang/rust/pull/78790 is
merged)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/cargo/pull/8834#pullrequestreview-526692807,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIVRYEPSADIXR33DWQ5VWLSPBRULANCNFSM4TL6DPPQ
.

Generally Cargo is only guaranteed to work with the rustc that it's paired with, so I agree with @ehuss that it's probably fine to delete the second clause.

Yea, just to elaborate, the tests for unstable features (like build-std) only run against the latest nightly, and only in this repository (not rust-lang/rust), so generally Cargo only needs to support the latest nightly.  If we decide to make more changes to rust-src, it's a fairly simple matter of updating Cargo afterwards.  Hopefully 78790 will land today, there was a bit of a CI outage yesterday.
The policy is briefly mentioned in the last paragraph of the section https://doc.crates.io/contrib/design.html?highlight=choice#backwards-compatibility and sort of in https://doc.crates.io/contrib/process/release.html.

Ok, removed the fallback mode

(this change of course means build_std won't compile until the other rust changes make it into nightly)

I pushed a small change to add some error context.
@bors r+

:pushpin: Commit 85b5b180f49d0892d79fbd21c4cd37b634eee4ff has been approved by ehuss

:hourglass: Testing commit 85b5b180f49d0892d79fbd21c4cd37b634eee4ff with merge 8662ab427a8d6ad8047811cc4d78dbd20dd07699...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 8662ab427a8d6ad8047811cc4d78dbd20dd07699 to master...


Backport: Error while getting agent config: invalid response 500: Failed to validate cluster: Hostname_override [xxx-xxx-KUB02] for host

Backport: https://github.com/rancher/rancher/issues/16294
https://github.com/rancher/rke/pull/1027

Fix is available in rancher/rancher:2.1.2-rc11

Reproduction
Rancher version: 2.1.1
Installation option: single
Step: Added a cluster from an existing node which hostname is uppercased, put all roles on one node
Result:
get the following error:
Failed to validate cluster: Hostname_override [xxx-xxx-KUB02] for host (1) is not valid: [a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(\.a-z0-9?)')]"

Validation
Rancher version: master, 11/13/2018
Installation option: single
Step: Added a cluster from an existing node which hostname is uppercased, put all roles on one node
Result:
Successfully added the cluster.
Conclusion
Back port verified.


next-auth.d.ts overwrites wrongly

Describe the bug
next-auth.d.ts that was used in the newest version of T3 overwrites the import, which causes import error.
import { DefaultSession } from "next-auth";

declare module "next-auth" {
  /**
   * Returned by `useSession`, `getSession` and received as a prop on the `SessionProvider` React Context
   */
  interface Session {
    user?: {
      id?: string;
    } & DefaultSession["user"];
  }
}

To Reproduce
Steps to reproduce the behavior:
This issue has surfaced in my ongoing project however not shown on the newly created project, I used vscode to open both files.
Expected behavior
I was expecting to import next-auth while the above code overwrite even
import { DefaultSession } from "next-auth";

do you set baseUrl in your tsconfig?
if so, this might be related to https://github.com/nextauthjs/next-auth/issues/4598
the workaround would be to move next-auth.d.ts from root to src/types

Ah, yes I did set baseUrl. Thank you.


docs(readme): fix typo and formatting

[Current coverage][cc-pull] is 100%

Merging [#84][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #84   diff @@
===================================
  Files           2     2
  Lines          76    76
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           76    76
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [999b910...de09e55][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ta2edchimp/opt-cli/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ta2edchimp/opt-cli/compare/999b91061e9cefa39c240cff7f0d39cbea87ebff...de09e55de282cbd98cf1648866bf62e28b60f0b0
[cc-pull]: https://codecov.io/gh/ta2edchimp/opt-cli/pull/84?src=pr


Low Performance on Mobile Devices

I used this effect on an android project, the result was perfect Functionality but very low performance, is there any option to make this effect works well on mobile devices?

#43 should have increased performance significantly, could you try again and see if the issue persists?

Hi,
I try your outline today on a project for the oculus quest and it do exactly what we need, but it affects the performance of the game.
Do you have any advice on how to reduce the impact of the outline on the performance?

There's still some shader optimizations to do but I'm not sure how far I can take performance since it's a post-processing effect.
If performance is a big concern (like mobile devices and VR), I would suggest using another asset like this one:
https://assetstore.unity.com/packages/tools/particles-effects/quick-outline-115488
This one is really good

Thanks for your answer.
I already try this asset, but there is some issues on oculus quest ^^'