tifig can't converting heif files from https://github.com/nokiatech/heif_conformance/tree/master/conformance_files to jpeg files

Hi monostream,,
The following are log messages about converting heif files from https://github.com/nokiatech/heif_conformance/tree/master/conformance_files to jpeg files..

https://github.com/nokiatech/heif_conformance/tree/master/conformance_files
build/tifig -i conformance_files/C020.heic -o conformance_files/C020.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C017.heic -o conformance_files/C017.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C033.heic -o conformance_files/C033.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C026.heic -o conformance_files/C026.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C002.heic -o conformance_files/C002.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C004.heic -o conformance_files/C004.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C019.heic -o conformance_files/C019.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C009.heic -o conformance_files/C009.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C031.heic -o conformance_files/C031.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C011.heic -o conformance_files/C011.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C023.heic -o conformance_files/C023.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/C032.heic -o conformance_files/C032.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C003.heic -o conformance_files/C003.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C024.heic -o conformance_files/C024.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/multilayer005.heic -o conformance_files/multilayer005.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C005.heic -o conformance_files/C005.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C027.heic -o conformance_files/C027.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/multilayer004.heic -o conformance_files/multilayer004.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C021.heic -o conformance_files/C021.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C008.heic -o conformance_files/C008.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C025.heic -o conformance_files/C025.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/C038.heic -o conformance_files/C038.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C028.heic -o conformance_files/C028.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C013.heic -o conformance_files/C013.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C029.heic -o conformance_files/C029.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/multilayer003.heic -o conformance_files/multilayer003.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C036.heic -o conformance_files/C036.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C037.heic -o conformance_files/C037.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C040.heic -o conformance_files/C040.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C042.heic -o conformance_files/C042.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C022.heic -o conformance_files/C022.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/C001.heic -o conformance_files/C001.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C039.heic -o conformance_files/C039.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C041.heic -o conformance_files/C041.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C012.heic -o conformance_files/C012.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C007.heic -o conformance_files/C007.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/C018.heic -o conformance_files/C018.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C030.heic -o conformance_files/C030.jpg
Could not read HEIF image: Invalid context ID parameter.
build/tifig -i conformance_files/C006.heic -o conformance_files/C006.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C010.heic -o conformance_files/C010.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C014.heic -o conformance_files/C014.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/multilayer002.heic -o conformance_files/multilayer002.jpg
Exif Data ID (cdsc) not found!
build/tifig -i conformance_files/C034.heic -o conformance_files/C034.jpg
Could not read HEIF image: No compatible brands in file
build/tifig -i conformance_files/C016.heic -o conformance_files/C016.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/multilayer001.heic -o conformance_files/multilayer001.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
build/tifig -i conformance_files/C015.heic -o conformance_files/C015.jpg
Grid configuration not found! tifig currently only supports .heic images created on iOS 11 devices.
If you are certain this image was created on iOS 11, please open an issue here:
https://github.com/monostream/tifig/issues/new
Do you have plan to support files from https://github.com/nokiatech/heif_conformance/tree/master/conformance_files?
snowuyl

Hey @snowuyl
As already mentioned in the readme, this library is optimised for photos taken with an iOS device.
There is quite a big difference in the handling of apple heic (generic grid) and the reference heics from nokia (no grid at all).
Cheers

Thanks for your response.


Include coremark and speccpu2006 tarballs in gitignore.

These files require separate download for licensing reasons,
and they must not be republished. Adding them to the ignore list
to help avoid accidentally uploading them into the repository.

Was already marked LGTM... looks fine to me.


System.AccessViolationException at SNIOpenSyncExWrapper

Description
When connecting to a SQL instance in Azure App Services if the connection fails we don't get a graceful connection error but we recieve the following exception.
This code is .NET Framework 4.8
Deployed to Azure App Services
Application: w3wp.exe
Framework Version: v4.0.30319
Description: System.AccessViolationException
Exception message: The process was terminated due to an unhandled exception.
Stack trace:

Exception Info: System.AccessViolationException
   at <Module>.SNIOpenSyncExWrapper(SNI_CLIENT_CONSUMER_INFO*, SNI_ConnWrapper**)
   at SNINativeMethodWrapper.SNIOpenSyncEx(ConsumerInfo, System.String, IntPtr ByRef, Byte[], Byte[], Boolean, Boolean, Int32, Boolean, Int32, Int32, Boolean)
   at System.Data.SqlClient.SNIHandle..ctor(ConsumerInfo, System.String, Byte[], Boolean, Int32, Byte[] ByRef, Boolean, Boolean, Boolean, System.Data.SqlClient.TransparentNetworkResolutionState, Int32)
   at System.Data.SqlClient.TdsParserStateObject.CreatePhysicalSNIHandle(System.String, Boolean, Int64, Byte[] ByRef, Byte[], Boolean, Boolean, Boolean, System.Data.SqlClient.TransparentNetworkResolutionState, Int32)
   at System.Data.SqlClient.TdsParser.Connect(System.Data.SqlClient.ServerInfo, System.Data.SqlClient.SqlInternalConnectionTds, Boolean, Int64, Boolean, Boolean, Boolean, Boolean, Boolean, System.Data.SqlClient.SqlAuthenticationMethod, Boolean, System.Data.SqlClient.SqlAuthenticationProviderManager)
   at System.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(System.Data.SqlClient.ServerInfo, System.String, System.Security.SecureString, Boolean, System.Data.ProviderBase.TimeoutTimer, Boolean, Boolean, Boolean)
   at System.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(System.Data.SqlClient.ServerInfo, System.String, System.Security.SecureString, Boolean, System.Data.SqlClient.SqlConnectionString, System.Data.SqlClient.SqlCredential, System.Data.ProviderBase.TimeoutTimer)
   at System.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(System.Data.ProviderBase.TimeoutTimer, System.Data.SqlClient.SqlConnectionString, System.Data.SqlClient.SqlCredential, System.String, System.Security.SecureString, Boolean)
   at System.Data.SqlClient.SqlInternalConnectionTds..ctor(System.Data.ProviderBase.DbConnectionPoolIdentity, System.Data.SqlClient.SqlConnectionString, System.Data.SqlClient.SqlCredential, System.Object, System.String, System.Security.SecureString, Boolean, System.Data.SqlClient.SqlConnectionString, System.Data.SqlClient.SessionData, System.Data.ProviderBase.DbConnectionPool, System.String, Boolean, System.Data.SqlClient.SqlAuthenticationProviderManager)
   at System.Data.SqlClient.SqlConnectionFactory.CreateConnection(System.Data.Common.DbConnectionOptions, System.Data.Common.DbConnectionPoolKey, System.Object, System.Data.ProviderBase.DbConnectionPool, System.Data.Common.DbConnection, System.Data.Common.DbConnectionOptions)
   at System.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(System.Data.ProviderBase.DbConnectionPool, System.Data.Common.DbConnection, System.Data.Common.DbConnectionOptions, System.Data.Common.DbConnectionPoolKey, System.Data.Common.DbConnectionOptions)
   at System.Data.ProviderBase.DbConnectionPool.CreateObject(System.Data.Common.DbConnection, System.Data.Common.DbConnectionOptions, System.Data.ProviderBase.DbConnectionInternal)
   at System.Data.ProviderBase.DbConnectionPool.UserCreateRequest(System.Data.Common.DbConnection, System.Data.Common.DbConnectionOptions, System.Data.ProviderBase.DbConnectionInternal)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, UInt32, Boolean, Boolean, System.Data.Common.DbConnectionOptions, System.Data.ProviderBase.DbConnectionInternal ByRef)
   at System.Data.ProviderBase.DbConnectionPool.TryGetConnection(System.Data.Common.DbConnection, System.Threading.Tasks.TaskCompletionSource`1<System.Data.ProviderBase.DbConnectionInternal>, System.Data.Common.DbConnectionOptions, System.Data.ProviderBase.DbConnectionInternal ByRef)
   at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection(System.Data.Common.DbConnection, System.Threading.Tasks.TaskCompletionSource`1<System.Data.ProviderBase.DbConnectionInternal>, System.Data.Common.DbConnectionOptions, System.Data.ProviderBase.DbConnectionInternal, System.Data.ProviderBase.DbConnectionInternal ByRef)
   at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(System.Data.Common.DbConnection, System.Data.ProviderBase.DbConnectionFactory, System.Threading.Tasks.TaskCompletionSource`1<System.Data.ProviderBase.DbConnectionInternal>, System.Data.Common.DbConnectionOptions)
   at System.Data.SqlClient.SqlConnection.TryOpenInner(System.Threading.Tasks.TaskCompletionSource`1<System.Data.ProviderBase.DbConnectionInternal>)
   at System.Data.SqlClient.SqlConnection.TryOpen(System.Threading.Tasks.TaskCompletionSource`1<System.Data.ProviderBase.DbConnectionInternal>)
   at System.Data.SqlClient.SqlConnection.Open()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.TimerQueueTimer.CallCallback()
   at System.Threading.TimerQueueTimer.Fire()
   at System.Threading.TimerQueue.FireNextTimers()

To reproduce
Include a complete code listing (or project/solution) that we can run to reproduce the issue.
Partial code listings, or multiple fragments of code, will slow down our response or cause us to push the issue back to you to provide code to reproduce the issue.
private static bool TestConnection(string connectionString)
{
    const string SqlQuery = "SELECT TOP 1 message_id FROM sys.messages";

    try
    {
        using (var connection = new SqlConnection(connectionString))
        {
            connection.Open();

            using (var sqlCommand = new SqlCommand(SqlQuery, connection) {CommandType = CommandType.Text})
            {
                return sqlCommand.ExecuteReader().HasRows;
            }
        }
    }
    catch (Exception ex)
    {
        _logger.LogError(ex);
        throw;
    }
}

Expected behavior
I'd expect if we're having issues connecting to a SQL instance that a sensible error is returned. As the System.AccessViolationException bypasses the try { } catch { } due to behaviour changes in .NET Framework 4  we don't want to set legacyCorruptedStateExceptionsPolicy due to the impact it would have on other exceptions.
Correct handling of the connection error and appropriate SQL exception raised back to the caller.
Further technical details
Microsoft.Data.SqlClient version: (found on the nuget or Microsoft.Data.SqlClient.dll)
.NET target: Framework 4.8
SQL Server version: SQL Server 2017 (Distributed Availability Group)
Operating system: App Services Windows

Also receiving a similar AccessViolation exception connecting to Local SQL 2019 Developer Edition installation. .NET Framework 4.7.2 using nuget package version 2.1.4. SNI package version 4.0.0
   at Microsoft.Data.SqlClient.SNINativeManagedWrapperX64.SNIOpenSyncExWrapper(SNI_CLIENT_CONSUMER_INFO& pClientConsumerInfo, IntPtr& ppConn)
   at Microsoft.Data.SqlClient.SNINativeMethodWrapper.SNIOpenSyncEx(ConsumerInfo consumerInfo, String constring, IntPtr& pConn, Byte[] spnBuffer, Byte[] instanceName, Boolean fOverrideCache, Boolean fSync, Int32 timeout, Boolean fParallel, Int32 transparentNetworkResolutionStateNo, Int32 totalTimeout, Boolean isAzureSqlServerEndpoint, SQLDNSInfo cachedDNSInfo)
   at Microsoft.Data.SqlClient.SNIHandle..ctor(ConsumerInfo myInfo, String serverName, Byte[] spnBuffer, Boolean ignoreSniOpenTimeout, Int32 timeout, Byte[]& instanceName, Boolean flushCache, Boolean fSync, Boolean fParallel, TransparentNetworkResolutionState transparentNetworkResolutionState, Int32 totalTimeout, SQLDNSInfo cachedDNSInfo)
   at Microsoft.Data.SqlClient.TdsParserStateObject.CreatePhysicalSNIHandle(String serverName, Boolean ignoreSniOpenTimeout, Int64 timerExpire, Byte[]& instanceName, Byte[] spnBuffer, Boolean flushCache, Boolean async, Boolean fParallel, TransparentNetworkResolutionState transparentNetworkResolutionState, Int32 totalTimeout, String cachedFQDN)
   at Microsoft.Data.SqlClient.TdsParser.Connect(ServerInfo serverInfo, SqlInternalConnectionTds connHandler, Boolean ignoreSniOpenTimeout, Int64 timerExpire, Boolean encrypt, Boolean trustServerCert, Boolean integratedSecurity, Boolean withFailover, Boolean isFirstTransparentAttempt, SqlAuthenticationMethod authType, String certificate, ServerCertificateValidationCallback serverCallback, ClientCertificateRetrievalCallback clientCallback, Boolean useOriginalAddressInfo, Boolean disableTnir)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover, Boolean isFirstTransparentAttempt, Boolean disableTnir)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, ServerCertificateValidationCallback serverCallback, ClientCertificateRetrievalCallback clientCallback, DbConnectionPool pool, String accessToken, SqlClientOriginalNetworkAddressInfo originalNetworkAddressInfo, Boolean applyTransientFaultHandling)
   at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.WaitForPendingOpen()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

This looks to be an issue when I use a DNS instead of an IP address. For example when I connect to a random IP address and port combination (e.g. <IP_ADDRESS>,5122) I get the anticipated exception of
System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections.
However if I use a DNS (e.g. "mylistener.someaddress.local") address instead of an IP address I would expect the following exception:
System.Data.SqlClient.SqlException (0x80131904): A network-related or instance-specific error occurred while establishing a connection to SQL Server. The server was not found or was not accessible. Verify that the instance name is correct and that SQL Server is configured to allow remote connections. (provider: TCP Provider, error: 0 - No such host is known.) ---> System.ComponentModel.Win32Exception (0x80004005)
Instead in Azure App Services I get a crash with
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException
   at <Module>.SNIOpenSyncExWrapper(SNI_CLIENT_CONSUMER_INFO*, SNI_ConnWrapper**)

@joe-green-uk this error as @lcheunglci mentioned is usually based on a mismatching between SNI library and M.D.S versions, in other words you are using a Microsoft.Data.SqlClient.SNI library which is not built for the in-use version of Microsoft.Data.SqlClient.
Can you delete all M.D.S from your code (probably uninstall, clean your code) and reinstall M.D.S and let it decide about SNI version?

@joe-green-uk this error as @lcheunglci mentioned is usually based on a mismatching between SNI library and M.D.S versions, in other words you are using a Microsoft.Data.SqlClient.SNI library which is not built for the in-use version of Microsoft.Data.SqlClient. Can you delete all M.D.S from your code (probably uninstall, clean your code) and reinstall M.D.S and let it decide about SNI version?

Thank uoi @JRahnama and @lcheunglci for your replies. Can we update the dependency information and setting a max version of Microsoft.Data.SqlClient.SNI to prevent this issue from coming up? Currently the dependency requires >= 2.1.1 and specifies no maximum version.

Nuget will never pick a major Dependency version afaik

@ThreeSevenths Correct M.D.S 2.1.4 requires >= 2.1.1 for SNI, but SNI packages are not to be consumed by the users. Driver decides on the dependency.  If you look into our 2.1 servicing branch for SNI version it will look for SNI v2.1.1 to build the driver and also in nuspec for sni version which specifies the nuget's requirements it has a dependency on SNI v2.1.1. Any alteration to SNI version manually by users may/will cause access violation exception.
Was my suggested solution able to solve the issue for you?

@ThreeSevenths Correct M.D.S 2.1.4 requires >= 2.1.1 for SNI, but SNI packages are not to be consumed by the users. Driver decides on the dependency. If you look into our 2.1 servicing branch for SNI version it will look for SNI v2.1.1 to build the driver and also in nuspec for sni version which specifies the nuget's requirements it has a dependency on SNI v2.1.1. Any alteration to SNI version manually by users may/will cause access violation exception.
Was my suggested solution able to solve the issue for you?

This is what I did try initially, removing it and adding it again which is when I found myself on 4.0.0. I was not able to repro it and as everyone has mentioned, nuget picked the correct SNI dependency version for me on the second installation. I do not know why it chose 4.0.0 the first time.
Thank you all for your time and attention, I appreciate it!

@ThreeSevenths @joe-green-uk Are you using package.config - if so, strongly recommend switching to PackageReference

@ThreeSevenths @joe-green-uk Are you using package.config - if so, strongly recommend switching to PackageReference

I am, unfortunately 🙁 and it's not something I can switch at the moment without opening a can of worms.

@ThreeSevenths Why not - you can also use PackageReference with the old .csproj format....

@ErikEJ next week is my last week in my current position and with my current company. Switching a key aspect of the project I am working on is not something I think is a good idea since I won't be around to support it. 🙂

@ThreeSevenths seems like there is not much we can do here. If the issue is resolved/answered feel free to close it.

@ThreeSevenths seems like there is not much we can do here. If the issue is resolved/answered feel free to close it.

Nothing to do, it's working as intended and the problem was somewhere between the keyboard and the chair. I did not open the issue in the first place; unfortunately, I cannot close it.

@joe-green-uk any update on the issue?

Closing the issue due to inactivity. Feel free to comment or open a new issue if the the problem still exists.


Unpublished workflows tab sometimes lags or doesn't load at all

Describe the bug
Sometimes #5272 gets a little bit weird and the contents of the unpublished workflow tab does not load.

To Reproduce
I haven't nailed down a 100% consistent trigger for the two cases (slow load vs not-at-all) but this seems close:

Have 51 unpublished workflows on one GitHub namespace (your personal username or an organization)
Go to my-workflows
Click the unpublished tab
Refresh the page
If the contents of the unpublished tab disappears, clear browser cache and refresh again to see it appear after some lagging
Refresh the page to see it disappear again
Switch to published, then back to unpublished, and see the unpublished workflows come back

Expected behavior
Either:

Our UI is able to load a large page of unpublished workflows quickly and consistently
Implementing https://github.com/dockstore/dockstore/issues/1201

Desktop (please complete the following information):

OS: Mac OS Catalina
Browser: Chrome 107.0.5304.110

┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-2298
┆Sprint: Backlog
┆Issue Type: Story

Closing in favor #5274

In favor of closing this -- I cannot reproduce this issue after fixing my circular imports.


Images returned from the API loose port number

Currently running on <IP_ADDRESS>:7000. Everything works except images are returned back from the API missing the port number.
Request to http://<IP_ADDRESS>:7000/api/v1/recipe/recipes/my-special-recipe/ returns:
{
   "id":32,
   "photo":"http://<IP_ADDRESS>/site-media/upload/recipe_photos/Jellyfish.jpg",
   "photo_thumbnail":"http://<IP_ADDRESS>/site-media/CACHE/images/upload/recipe_photos/Jellyfish/5e38bb78b88ef055166d34337a5bc488.jpg",
   "ingredient_groups":[
      {
         "id":5,
         "title":"",
         "ingredients":[
            {
               "id":15,
               "quantity":1.0,
               "measurement":"mouthful",
               "title":"of chilli"
            }
         ]
      }
   ],
   "tags":[

   ],
   "subrecipes":[

   ],
   "pub_date":"2018-03-24",
   "update_date":"2018-03-24",
   "username":"test",
   "title":"My special recipe",
   "slug":"my-special-recipe",
   "info":"It's a recipe ooooooh",
   "directions":"Put chill in mouth\nHave fun",
   "source":"",
   "prep_time":10,
   "cook_time":30,
   "servings":1,
   "rating":0,
   "public":true,
   "author":3,
   "cuisine":1,
   "course":1
}

# Database config
MYSQL_DATABASE=openeats
MYSQL_ROOT_PASSWORD=root

# Django config
API_URL=<IP_ADDRESS>:8000
API_PORT=8000
DJANGO_SECRET_KEY=sdfsadfas32e98zsdvhhsnz6udvbksjdhfi4galshjfg
DJANGO_SETTINGS_MODULE=base.settings
DJANGO_DEBUG=False
ALLOWED_HOST=<IP_ADDRESS>
HTTP_X_FORWARDED_PROTO=true

# Node config
NODE_ENV=production
NODE_URL=localhost:8080
NODE_PORT=8080
NODE_API_URL=http://<IP_ADDRESS>:7000
NODE_LOCALE=en

version: '2.3'
services:
  nginx:
    ports:
      - "7000:80"

Also http://<IP_ADDRESS>:7000/admin redirects to http://<IP_ADDRESS>/admin/ (minor issue as http://<IP_ADDRESS>:7000/admin/ works fine)

This looks like an nginx issue. I'll take a look with a local setup and see what I can find. The admin redirect is normal but since it doesn't know what port you're running on, it doesn't add it.

I put in a fix for this on the nginx proxy server. The docker build generally take <10mins. After that go ahead and try the latest. If this works for you I will tag the image and do a release.

Yep that's fixed it, thanks! :)


merge from template-node-app

.github/workflows/update_readme_api.yml

chore: (on.push)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.161%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
54

Relevant Lines:
56

💛  - Coveralls


feat: QR code scanner

This feature is being implemented at #32
This feature aims at creating a button for scanning QR Codes and returning the Ethereum address (if deteced) in the right format.
The main problem right now is finding a lib that works with Next.js. We tried injecting HTML into the useEffect but the function to stop the camera didn't work either. But looking back, using HTML looked like a better move than working with an unfinished lib. You can find more people with the same problem in the reference section in this issue.
What was done so far

[x] Button to open scanner
[x] Reading QR code
[x] Ethereum address matches regex ^0x[a-fA-F0-9]{40}$

What are the problems atm
The lib for react doesn't have a way of stopping the camera from being used, the application will keep the camera open consuming memory and forever returning success after the first call, resulting in random glitches when using the dApp.
What is missing

[ ] Read the Ethereum addresses contained within the QR Code (might have the chain as a prefix i.e.: eth:0xaabbcc....)
[ ] Close the camera after finding an address

Reference
https://github.com/scanapp-org/html5-qrcode-react
https://github.com/mebjas/html5-qrcode
https://github.com/mebjas/html5-qrcode/issues/839
https://github.com/mebjas/html5-qrcode/issues/796

fixed by #70 after we decided using another approach


Missing migrations for detect_spines app?

Hi, I apologize in advance if I'm doing something silly but I can't seem to run (or find) the migrations for this app.
Running makemigrate and migrate only installs migrations for the admin, auth, contenttypes, sessions packages but none related to the detect_spines app. All of the api calls fail because the database tables don't exist.

Internal Server Error: /api/create-bookshelf/
Traceback (most recent call last):
File "/Users/natitessema/workspace/Bookshelf-Reader-API-master/venv/lib/python3.10/site-packages/django/db/backends/utils.py", line 89, in _execute
return self.cursor.execute(sql, params)
File "/Users/natitessema/workspace/Bookshelf-Reader-API-master/venv/lib/python3.10/site-packages/django/db/backends/sqlite3/base.py", line 477, in execute
return Database.Cursor.execute(self, query, params)
sqlite3.OperationalError: no such table: detect_spines_bookshelf

Is there a missing migrations/ directory for the detect_spines app or am I doing something wrong? Thanks in advance and thanks for making this project @LakshyaKhatri 🙂

Thanks mate! 😄
I think you are right. It's been a long time since I worked on this project, just checked the code and I couldn't find any migrations either. Did you find a fix though? From what I see, we need to write migrations manually 🤦🏽♂
I would love a solution to be proposed ❤

Ah! I see. The models defines the fields in django:
https://github.com/LakshyaKhatri/Bookshelf-Reader-API/blob/master/detect_spines/models.py#L94-L105
In that case, I don't think we need any migrations here


Use jQuery 2.x

Before working on transition to jQuery 3.xx, which will presumably require additional refactoring work and testing, let's make an easy transition to jQuery 2.xx - actually, the last 2.xx version - the 2.2.4.
Here are some highlights of the changes that jQuery 2.0 brings:

No more support for IE 6/7/8

Reduced size: The final 2.0.0 file is 12 percent smaller than the 1.9.1 file, thanks to the elimination of patches that were only needed for IE 6, 7, and 8.

jQuery 1.9 API equivalence: jQuery 2.0 is API-compatible with 1.9

Looks fine to me. Have you done any manual testing?

Sure, I've tested it on my local environment of http://florsan.md


Feature/create new account on hive keychain 1w46d7n

As requested all changes made. Placing as a draft for another review.


Fix log messages and var names in integr test

It says "pods" where the things are actually "containers".

@erictune did you make a new push I didn't see?

pushed for reals.
On Thu, Mar 12, 2015 at 3:16 PM, Victor Marmol<EMAIL_ADDRESS>wrote:

@erictune https://github.com/erictune did you make a new push I didn't
see?
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/5338#issuecomment-78652205
.

LGTM. Thanks for fixing the nits :)


Added if statement to check if space in email as well as added test a…

…round it this is a fix to #449 worked with @malhariri92. This was done as part of the CSCC Haackathon.

Sorry, but the PR is not accepted for the following reasons:

spaces are allowed in the local part of an email address, provided that they are escaped or part of a quoted string.
the PR contains a spurious file (.iml)


Improve add a session variable to make scan run serial

Proposed changes
Parallel scanning can result in some read amplification, for example, select * from xx where limit 1 actually requires only one row of data. However, due to parallel scanning of multiple tablets, read amplification occurs, leading to performance bottlenecks in high-concurrency scenarios. This PR Adding a SessionVariable to enforce serial scanning can help mitigate this issue.
Issue Number: close #xxx
<--Describe your changes.-->
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Fix#2629

Fixes https://github.com/apache/incubator-shardingsphere/issues/2629.
Changes proposed in this pull request:

add not null judge for ShardingDataSourceNames's constructor and unit test
add not null judge for ShardingRule's constructor and unit test

Pull Request Test Coverage Report for Build 8743

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 61.523%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java
3
76.0%

Totals

Change from base Build 80:
-0.002%

Covered Lines:
8444

Relevant Lines:
13725

💛  - Coveralls

@kezhenxu94 @sunbufu  Thanks, after all the checks are ok, i will merge it.

Good job, merged @sunbufu


Decomp assert and debug-h

Pull Request Test Coverage Report for Build 598235217

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.827%

Totals

Change from base Build 597795430:
0.0%

Covered Lines:
30209

Relevant Lines:
43891

💛  - Coveralls


License ?

What the license for this open source code?
Can I take the source, modify it, and sell it? It needs a clear license attached at the root.
Thanks

The license has been added. Thank you for noticing and providing suggestion.


Update to JDK 12 EA16 when running CI jobs against JDK 12.

Motivation:
A new EA release was done, we should always run against the latest.
Modifications:
Update to EA 16.
Result:
CI runs with latest EA release for JDK12.

@netty-bot test this please


[Documentation Update]: Job satisfaction analysis model update

Is there an existing issue for this?

[X] I have searched the existing issues

Issue Description
The Job satisfaction analysis only uses one model i.e. the RandomForest to predict the output. The main python notebook itself, has more detailed models listed.
Suggested Change
I wish to add other models and also include the comparison in accuracy amongst those models so as to give a better picture along with a more accurate data prediction. My aim would be mainly to add SVM and Logistic Regression to the testing and try other models as experimentation if time permits along with hyper-parameter tuning suited for the current computational capacity.
Rationale
People visiting the job satisfactory survey analysis might think that the file is not that well worked on. ALong with that the predictions that file offers is not tested, which it would be if the above issue is implemented.
Urgency
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

This should be the integration to existing streamlit not a new one,


Elixir.tmLanguage works in Sublime but fails in VSCode

When using the official Elixir.tmLanguage file found here, lines that begin with a whitespace character or an arbitrary unhighlighted token (e.g. foo) are not highlighted (see screenshot below).

The Elixir.tmLanguage file does—of course—work perfectly fine in TextMate and Sublime.
https://github.com/elixir-lang/elixir-tmbundle/blob/master/Syntaxes/Elixir.tmLanguage

VSCode Version: 1.10.2
OS Version: macOS 10.12.3 (Sierra)

This issue was moved to Microsoft/vscode-textmate#37


Feature request: channel prefrence when there are parallel channels

It would be useful for managing liquidity if there was a way to prefer a certain channel when routing payments to a peer with 2 or more in parallel. There are times we would like to deplete a smaller one prior to closing it when replacing with a larger channel, or when using private channels in order to avoid channel churn with nodes that tend to drain liquidity.

This is already possible when sending payments outbound (--outgoing_chan_id).

Reading some of the htlcswitch code, the simplest way to add this may be to add a prefer-private/public option and a prefer-smaller/larger option, instead of picking a random link. destination := destinations[rand.Intn(len(destinations))] in switch.go.

I'd love to see this feature. Right now I have six channels to bfx-lnd0. While I think some of this is caused by imperfect channel management on my side, in general I see the need to have (and, eventually, close) parallel channels.
For a routing node I think that channels either are long-lived (and we don't need to think about balance distribution because it doesn't really matter), or that channels need to be closed once they are drained (so that the peer at the other side gets on-chain access to the funds).
Based on these thoughts I see at least three options:

prefer sending through private channels so that these can be opened/closed without anyone noticing, benefiting from the age and public gossip knowledge of the (single) public channel
prefer sending through younger channels (similar to above: keep old channels around because they are well known)
prefer sending through channel with lowest local liquidity (so that closing channels can be done faster)

This is somewhat related to #5972 as it touches the same part of the code.

Another option could be to allow for reallocating liquidity between channels in a negotiation with your peer

Oh that would be absolutely perfect. However, I believe some kind of protocol extension would be necessary for this. I'll raise an issue in the spec repository, so that we approach this issue from two sides. Thank you a lot for the suggestion!


java-tools fails silently on apt-fast ANT install

Description
The everyfs project action runner using the virtual installers here to facilitate building a runner image, in the porcess of using this I discovered that if apt-fast is not installed then the java-tools.sh fails at the Ant install step with no error or log and the rest of the script fails to execute.
It would make sense to me to not use apt-fast in these installers unless absolutely necessary.
Additionally it would make sense to either break out the java tools script or have it be tolerant to failure of a step.
Virtual environments affected

[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
N/A
Is it regression?
No
Expected behavior
No response
Actual behavior
No response
Repro steps
Run java-tools.sh without apt-fast installed

@tonywildey-valstro Hello!
Thanks, we will take a look at it.

The fix will be rolled out after January 9th.

Thanks for the quick turnaround - agree on the fact theres no need to use apt-fast :)

The fix has been deployed this week.


SQL import Foreign Key problem

In the sql import file you alter the table pageviews and reference to the pages table before it is created, that will result in an error during the import. Create the table pages first, then alter pageviews.

Hey @dalliard,
So awesome to see that you're already spinning up an Ana instance. I feel obliged to say that you will most likely run into more issues like these as it's all in a very early stage right now and I'd hate for you to waste your time. I expect things to stabilise in a few more months.
That said, thanks a ton for the heads up. Should be fixed in 0289ba8cfedb50205a436f963f12529cce90605a.
Have a good Christmas!


autopep8 -i -r -v .

Signed-off-by: Christian Clauss<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 42.81%

Merging [#73][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.25%

@@             master        #73   diff @@
==========================================
  Files            29         29
  Lines          3687       3667    -20
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           1588       1570    -18
+ Misses         2099       2097     -2
  Partials          0          0

Powered by Codecov. Last updated by [f690053...0b2b7c8][cc-compare]
[cc-base-branch]: https://codecov.io/gh/cloudviz/agentless-system-crawler/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/cloudviz/agentless-system-crawler/compare/f690053b2f5712dc67384372a934783aee3c96ec...0b2b7c8090d5b907b90433651c7a1ee2b1096e84?src=pr
[cc-pull]: https://codecov.io/gh/cloudviz/agentless-system-crawler/pull/73?src=pr

what's up with the merge commit? Can you rebase directly instead?

@MHBauer I will close this PR and let someone else do:

pip install --upgrade autopep8
autopep8 -d -r -v .  # to show a diff but not modify the files
autopep8 -i -r -v . # to actually modify the files
submit as a pull request is a way that satisfies validateDCO


Raylib 5.0?

Should work without any changes. If you submit a PR with the update, I'd be happy to merge.

By the way, thanks for the awesome header.

Thanks for checking it out! And most of the credit should go towards cute_aseprite :wink: ... Would love to actually target raylib 5 tho, so would apppreciate any help there

It has been working so far, no issues for now, the only thing missing is a mirror/flip method. I'm gonna try to do that by myself.


[BANKING] Add Bank Accounts

The following features should be added to support Bank Accounts:

[ ] Create a specific Bank Account
[ ] Update a specific Bank Account
[ ] Delete a specific Bank Account
[ ] Show a specific Bank Account
[ ] List All Bank Accounts

You can find the official documentation here!

Implementation Tips:
You can draw inspiration from this PR. Don't forget to write good tests, and to document it on our README

Hi Joao please confirm that these issues has been completed
https://documentao-moip.readme.io/v2.0/reference#criar-conta-bancária

Hi @ecordoba24. The docs link you sent is our API reference, but our PHP SDK doesn't have those functions yet (to comunicate with our API). So, no, they haven't been completed yet :)

Issue solved in PR #195.

#195


appear support

I'm very happy you made this component with nice, clean code, which can also be used with vue 3. However I would like to have a prop for the transition of the initial render in case the element is not collapsed. Like <transition appear>. Can that be added? Thanks a lot.

Hello,
Just so we're on the same page: you want a prop to automatically collapse a div (with transition) on initial render?
I'll see if I can get that to work.

Hi, I mean a prop to automatically appear a div with transition on initial render (if v-show is trueish of course).
Thanks a lot.


Feedback from urmyfaith

dfdsfasfa

?

just test CAN send Feedback from simultor  or not.
sorry.

I know, it's all right.


CTest succedd locally but fail  on actions

Description
I am working on a C project with CMake and added Single Platform workflow but now
Tests are working locally but fails on workflow
Latest Run link
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[X] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
latest run link: https://github.com/BhJaipal/libaloo/actions/runs/10882290942
Is it regression?
Maybe no
Expected behavior
Locally
Test project /home/jaipal001/Desktop/files/c-use/libaloo/build
Start 1: IntegerTest
1/2 Test #1: IntegerTest ......................   Passed    0.02 sec
Start 2: WidgetTest
2/2 Test #2: WidgetTest .......................   Passed    0.24 sec
100% tests passed, 0 tests failed out of 2
Total Test time (real) =   0.26 sec
Actual behavior
On actions
Run cd /home/runner/work/libaloo/libaloo/build
Test project /home/runner/work/libaloo/libaloo/build
Start 1: IntegerTest
1/2 Test #1: IntegerTest ......................   Passed    0.01 sec
Start 2: WidgetTest
2/2 Test #2: WidgetTest .......................***Failed    0.01 sec
50% tests passed, 1 tests failed out of 2
Total Test time (real) =   0.07 sec
Errors while running CTest
Output from these tests are in: /home/runner/work/libaloo/libaloo/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
The following tests FAILED:
2 - WidgetTest (Failed)
Error: Process completed with exit code 8.
Repro steps
Run commands in cmake-single-platform.yml

Hi @BhJaipal , Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.

Hi @BhJaipal , Thank you for bringing this issue to us. We are looking into this issue and will update you on this issue after investigating.

Problem possibly occurs here


Mr. Striker, items in the crafting pad don't feel so good.

Vanilla Tweaks Version:
1.4.7
MinecraftForge Version:
<IP_ADDRESS>25
Minecraft Version:
1.12.2
(Optional) Just Enough Items (JEI) Version:
<IP_ADDRESS>5
(Optional) Baubles Version:
Client or Server?:

[X] Client
[?] Server

Crash Report (via. Hastebin):
N/A
What happens / happened?:
When closing the GUI of the crafting pad any items left in will be deleted.
How can the issue be reproduced?:
Open crafting pad, put items in, close GUI, reopen GUI.
** Mod List**:
I'll post my mod list if you can't reproduce this bug.

Nor do i feel so good mr.sdaddy. I dont have access to my PC for half a week but i will look into it as soon as i can

Hmm i can't seem to reproduce this bug. If you can post the mod list i will reopen then issue again.

I am playing the Life in the village modpack and I have the same issue

@Erdi2608 can you tell me the version of VanillaTweaks you are using and if its old can you update it?

I am also playing Life in the Village, and I also have this issue. The version listed in my mod list is Vanilla Tweaks 1.12.2-1.5.4
Sounds like it might be a cross-mod conflict, since you can't reproduce it locally.

Can you create a new issue? I can't fix it in this week due to exams thus it would serve as a reminder.

Sure, but I'll see if I can narrow it down a bit first.

For anybody finding this issue in the future, the new issue is #66. It was a conflict with RealBench, and affected other hand-held crafting tables too.


⚠ Samsung has degraded performance

In 674fd85, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2589 ms

Resolved: Samsung performance has improved in d1683e0.


Request of configuration options.

Hello!
I'm glad you did this one. Using: ProjectExpansion-1.18.2-1.0.12.jar
Previously I've used the old ProjectEX to tone down greatly power-flower and collector input, so encourage more clever solutions by hidden loops and such. The old config is here: https://pastebin.com/W9HEahDJ
Together with ProjectE set to 1/5 value and rounding down, that removed huge cobblestone makers, made the player think rather crafting than simply getting an item out from EMC, and a general building material helper.
Looking at the config here I'd be grateful if I'be able to set these multipliers to a fraction number, like "0.2":
collectorMultiplier = 1
emcLinkItemLimitMultiplier = 1
emcLinkFluidLimitMultiplier = 1
emcLinkEMCLimitMultiplier = 1
powerflowerMultiplier = 1
relayBonusMultiplier = 1
relayTransferMultiplier = 1
Plus if there'd be a switch which disables crafting the old collectors and relays, the game would be lesss laggy as EMC would be added by seconds and not by ticks.
These changes would raise this mod again to the sorrow of all EMC users, and as you know, the success of a server needs player-tears.
(also make EMC an useful tool instead breaking most other mods depending on resources)
Thank you kindly, and have a fun weekend!
(ps: do you know a mod which connests EMC to the Building Gadget for 1.18.2?
https://www.curseforge.com/minecraft/mc-mods/emcgadgets )

Implementing this now, this will definitely result in some values being zeroed out, but I'm going to leave people may want that
Original Values:

0.2:

It's rounded down as fractional emc isn't a thing, and I'm not about to handle decimals
Included Options:

collectorMultiplier
emcLinkItemLimitMultiplier
emcLinkFluidLimitMultiplier
emcLinkEMCLimitMultiplier
powerflowerMultiplier
relayBonusMultiplier
relayTransferMultiplier

Added in latest versions
1.15: 1.0.32
1.16: 1.0.33
1.18: 1.0.13
1.19.2: 1.0.1


Improve experience with DOI fetches

Changes to doi.org have caused headaches with resolving DOIs - particularly, rate-limiting 429 responses prevent parallel requests. Once we start getting 429s, we also see these as failures and do more requests (handle.net, different content-type, etc).
So far, we've added limiting to outgoing requests at a per-page level. This helps with small projects, but doesn't apply to multiple page builds in parallel.
We need to:

[x] remove requests to handle.net
[x] limit outgoing requests at a site-build level, rather than page level
[ ] stop unnecessary requests, e.g. based on a specific failure response from bibtex request, can we decide not to try csl json?

From my experience, handling the first two bullets here resolved the slow DOI fetches; the third is not necessary. These were released with v1.2.9
We can always re-open or create a new issue if more problems with DOIs arise...


Inconsistent result

Hi. Thanks for share the code.
When I change nfluids = 1 to nfluids = 2 in code/chapter9/shanchen.cpp I get an inconsistent result.
Here the first three outputs:
Running time step 0
  Densities: rho_g = 0.1, rho_l = 0.5
  Pressure difference: dp = -0.134382
  Droplet radius: r = 32.75
  Surface tension: gamma = -4.40102

Running time step 100
  Densities: rho_g = nan, rho_l = nan
  Pressure difference: dp = -nan
  Droplet radius: r = 6.93964e-310
  Surface tension: gamma = -nan

Running time step 200
  Densities: rho_g = nan, rho_l = nan
  Pressure difference: dp = -nan
  Droplet radius: r = 6.93964e-310
  Surface tension: gamma = -nan

I am going to be thankful for the correction. Thanks

Unfortunately the parameters given in the code result in an unstable calculation when you change the number of components from 1 to 2. Try disabling the self-interaction of component A by setting gA = 0 to get a stable result with two components.


Expected delta and delta don't match

I'm using your API to connect to my budget and just add a transaction.
I'm creating it myself like this
class YNAB(object):
    def __init__(self, username, password, budget_name):

        self.username = username
        self.password = password
        self.budget_name = budget_name

        self.client = self.get_client()

    def get_client(self):
        conn = nYnabConnection(self.username, self.password)
        try:
            client = nYnabClient(nynabconnection=conn, budgetname=self.budget_name)
            client.sync()
            return client
        except BudgetNotFound:
            raise InvalidYnabSettings("No Budged with that name")

Then I create and add a transaction like this:
    def create_transaction(self, account_id, payee_id, date, amount, memo, imported_payee):
        transactions = []
        transaction = Transaction(
            entities_account_id=account_id,
            amount=amount,
            date=date,
            entities_payee_id=payee_id,
            imported_date=datetime.now().date(),
            imported_payee=imported_payee,
            memo=memo,
            source="Imported"
        )
        transactions.append(transaction)
        return transactions

    def add_transactions(self, transactions):
        for transaction in transactions:
            self.client.add_transaction(transaction)

This is raising an exception in Client.py here:
        if delta != expected_delta:
            raise WrongPushException(expected_delta, delta)

From the value of delta, it seems that it thinks that everything is new. What am I doing wrong?

Hi Goncalo.
I think it works as expected. The safeguard probably prevented from
modifying and overwriting all your nYnab data at once.
Do you see where to look at the changed_entities that it tries to push and
compare it to the one it fetched from the server in the sync?
On Feb 12, 2017 02:25, "Gonçalo Silva Santos"<EMAIL_ADDRESS>wrote:
I'm using your API to connect to my budget and just add a transaction.
I'm creating it myself like this
class YNAB(object):
def init(self, username, password, budget_name):
    self.username = username
    self.password = password
    self.budget_name = budget_name

    self.client = self.get_client()

def get_client(self):
    conn = nYnabConnection(self.username, self.password)
    try:
        client = nYnabClient(nynabconnection=conn,

budgetname=self.budget_name)
client.sync()
return client
except BudgetNotFound:
raise InvalidYnabSettings("No Budged with that name")
Then I create and add a transaction like this:
def create_transaction(self, account_id, payee_id, date, amount,

memo, imported_payee):
transactions = []
transaction = Transaction(
entities_account_id=account_id,
amount=amount,
date=date,
entities_payee_id=payee_id,
imported_date=datetime.now().date(),
imported_payee=imported_payee,
memo=memo,
source="Imported"
)
transactions.append(transaction)
return transactions
def add_transactions(self, transactions):
    for transaction in transactions:
        self.client.add_transaction(transaction)

This is raising an exception in Client.py here:
    if delta != expected_delta:
        raise WrongPushException(expected_delta, delta)

From the value of delta, it seems that it thinks that everything is new.
What am I doing wrong?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rienafairefr/nYNABapi/issues/30, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuS9ZwemO3O3T1D6_TJZ9nk5t6o6ejVks5rbl92gaJpZM4L-W5u
.

I've pushed new code for testing stuff, commit c83ff5ef23e3550bac3b10796347468cb84f962c
can you try running the test_live thing with your login and maybe a dummy budget without your important data in it ? If the test_roundtrip doesnt pass, it's a problem with my code, if test_add_delete_transation fails, it's a problem with our assumption of the API data messages format.
With my login all tests passes, but you might be part of a subset of users with a new feature.

Hi rienafairefr,
Just hit the same exception: WrongPushException(expected_delta, delta) while trying to create an account:
client = clientfromargs(args)

account = Account(
    account_name="Some account name",
    account_type=AccountTypes.Cash,
    on_budget=True,
    sortable_index=random.randint(-50000, 50000),
)
client.add_account(account, 20, datetime.now())

I have commented out WrongPushException line and the account was created as expected. What to do? :+1:

Well, if you're commenting out the safeguard please be advised that you're risking your data. WrongPush means that the client tries to modify more than what it should modify in theory.

The safeguard is OK, my issue is that my only operation since the initial sync was adding an account. How is it possible to have multiple changes uncommitted if I only changed three to add an account.

This python client is experimental based on reverse engineering, it's an unofficial client, so it's very prone to breaking anytime the nYnab team changes something in their API, the implementation is not perfectly equal to what the javascript on app.youneedabudget.com does anyway. Sorry about that, I'm alway trying to work the kinks out. You can try stepping into the problem to see what the client wants to push, to understand why the modification "add an account" does not generate the right changed_entities, if you get more info don't hesitate to share so we can fix this

I have just started debugging this, though my Python expertise is not that great at the moment and I struggle following parts of the algorithm. It will take some time before I can really contribute to this.
You could extend your technical documentation with the exact comments that you have on this issue. I found this discussion to be very valuable in better understanding what the library does.
Thank you for taking the time to write this library.

I'm running into the same issue. After looking at  catalog.get_changed_apidict() and budget.get_changed_apidict() it appears that it's treating stuff downloaded as changes (I had 100's of items in both, when all I had done is add 1 transaction).
I'm going to try and dive into the code, but python is pretty new to me!

Ok, I created a new budget and account to test this.
After creating a client the delta calculates as 0,
After a sync it's 179
After adding a transaction it's 180.
so there is 1 difference which is correct. But the code checks for a delta of 1, not 180.

Hi Ross, thanks for the feedback.
I don't have as much time as I would like to work on this project, really sorry.
You could check the differences between the received dictionary
( changed_entities parameter to method update_from_api_changed_entities )
and what the app wants to push to the server
( the result of the method get_changed_apidict )
that way we could see if it's something that changed in nynab or if it's a bug my library

I'm using this code to test how I think it should work:-
    catalog_changed_entities = ynab_client.catalog.get_changed_apidict()
    budget_changed_entities = ynab_client.budget.get_changed_apidict()

    delta = sum(len(l) for k, l in catalog_changed_entities.items()) + \
        sum(len(l) for k, l in budget_changed_entities.items())

    log.debug(delta)

    ynab_client.catalog.clear_changed_entities()
    ynab_client.budget.clear_changed_entities()

    catalog_changed_entities = ynab_client.catalog.get_changed_apidict()
    budget_changed_entities = ynab_client.budget.get_changed_apidict()

    delta = sum(len(l) for k, l in catalog_changed_entities.items()) + \
        sum(len(l) for k, l in budget_changed_entities.items())

    log.debug(delta)

The debug prints 179 for both.
I believe the call to clear_changed_entities should cause the second output to be 0, but it doesn't.
I need to sort out a new machine for developing this as currently I'm modifying my file, and recreating a docker image so it's just so slow, but I'm not a python dev so I'm way out of my depth!
If that doesn't help you I'll see about finding a python IDE so I can help properly!

Ok. My issue is because I was getting pynYNAB via "pynYNAB" in the requirements.txt file. Changing it to -e git://github.com/rossdargan/pynYNAB.git@a07fb0ec38337b335680fb8f9901b956a76a0597#egg=pynYNAB fixed it for me (note I'm using my fork but that has no changes).
I'm totally new to python, but where ever pip gets it from when I don't specify it that way obviously has a far older version with bugs!

Note however I am still getting this error, but now my calculations show a delta of 1. So I have no idea why WrongPushException is still getting thrown!

Yeah I guess the pypi version is not up to date with master :-/ Sorry about that, I'll update it.
I really need to change the handling of this changed_entities thing, right now it's resource intensive it's saving a snapshot of the data before, then making a diff of the data after modifications, reading all of it, it would be better to handle the changes as they happen and save them.
There are some unit tests in the app, did you try running them ?

test.py and test2.py ran fine.
I'm not sure how to debug code in python yet, so I'm going to try and come up with a really simple example showing the issue and paste that - hopefully it will show something obvious :/

Fairly sure the issue is to do with adding a payee, then a transaction. If I add the new payee, then the transaction I get the error 'WrongPushException'.
If I add a payee, then do a sync, then add the transaction I get this error now:
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/Client.py", line 46, in wrapped
self.push(expected_delta)
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/Client.py", line 163, in push
self.push_budget()
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/Client.py", line 139, in push_budget
self.budgetClient.push(extra=self.extra_budget)
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/ObjClient.py", line 88, in push
sync_data = self.connection.dorequest(request_data, self.opname)
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/utils.py", line 20, in rateLimitedFunction
ret = func(*args, **kargs)
File "/usr/local/lib/python2.7/dist-packages/pynYNAB-dev-py2.7.egg/pynYNAB/connection.py", line 75, in dorequest
raise NYnabConnectionError('Uunrecoverable server error, sorry YNAB')
pynYNAB.connection.NYnabConnectionError: Uunrecoverable server error, sorry YNAB
After adding a new payee what should I be doing?

I've added documentation in the wiki, hopefully all questions should be answered.
Don't hesitate to open new issue if you still have problems. A 0.5.2 version should be incoming soon if tests pass


Callback does not work as documented

What were you expecting to happen?
I expected the watch cb() to be called once a .js file was added to the ./dist folder.
As documented here;
gulp watch cb(event)
What actually happened?
File added events do not trigger a callback, only file changed events work.
gulp.watch('./dist/*.js', (e) => {
  console.log('Watch event type', e.type); // Does not work for 'Added' events, only 'Changed' events.
  // do stuff...
});

What version of gulp are you using?
CLI version 1.2.2
Local version 3.9.1
What versions of npm and node are you using?
NPM version 3.10.10
Node version 7.2.1

Further to this, I have found that the dependency on Gaze may actually be the problem here...

See this: https://github.com/gulpjs/gulp/issues/651

Also, gulp-watch might help you accomplish what you want.

Thanks, I did have a brief look at that module, but in the end, have gone with a workaround for now.
FYI, I tried using Gaze directly (with different GLOB patterns just in case), but the 'added' event type is never triggered.
My current workaround is to ensure there is a file there, before running the watch task;
// Workaround for Gaze bug ('added' events are not triggered, only 'changed' events)
fs.closeSync(fs.openSync('./dist/myfile.min.js', 'w'));

Not ideal, but it looks like the issue is with Gaze, and not gulp.watch.

If you're using a separated watcher, I'd recommend you to use chokidar - which is what's going to be used in gulp4.

@ericmdantas The fs.openSync workaround didn't work on my build server, so I went with gulp-watch after all (which depends on chokidar, which you also recommended)


Allow running private docker images

Right now we only support running public docker images.
We need to think of some way to provide credentials to the nerd run command to handle private docker repo's.

this is tackled together with secrets feature


[ci] Add -x to all CI scripts

Fixes #10316
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @Mousius @areusch

@tvm-bot merge


Sending user to wrong url link

I believe the link in the section (below) sends the user to the wrong location.
https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/developer-guidance-for-integrating-applications#suppress-user-consent
It sends the user to this link:
https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-register-app
Rather than one of these links:
https://docs.microsoft.com/en-us/azure/active-directory/develop/application-consent-experience
https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/configure-user-consent?tabs=azure-portal
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18bf18dd-016d-1949-06e7-b06d8240dd50
Version Independent ID: 5e32e1e0-9686-5a4d-f4b7-61c4a8a19afc
Content: Register your application to use Azure Active Directory
Content Source: articles/active-directory/manage-apps/developer-guidance-for-integrating-applications.md
Service: active-directory
Sub-service: app-mgmt
GitHub Login: @kenwith
Microsoft Alias: kenwith

@moehoward Thank you for pointing that out . We will investigate and update the thread.

@moehoward Thank you for pointing that out . We will investigate and update the thread.

@moehoward We have update the document and the changes should be live in the next 48 hours.

@moehoward We have update the document and the changes should be live in the next 48 hours.


How to preserve date format when export dataset to Excel file

I've written a python script that creates a new Excel file from an existing one by copying some columns only. For this, I've used tablib library, but I'm facing an error with columns that have dates as values.
In the original file the format is like this 11/23/2007, but in the output file is like this 39409.
I'm saving the excel file like this:
with open('output-2.xls', 'wb') as f:
    new_dataset.headers = headers
    f.write(new_dataset.export('xls'))

When I print the new_dataset the column has datetime.datetime(11, 23, 2007, 0, 0) object as values
So, how can I preserve the dates format in the output file?

Are you really working with xls, not xlsx? I guess that you'd have more chances of a correct output with the xlsx format.

Closing for non-activity.


add 1inch promos

This PR adds 3 things:

1inch header linking to blog announcement and a link to install (for existing users)
1inch as a default application
Re-orders default applications

Annoyingly, it reorders some tailwind classes, which I think is a linter extension in my VSCode?

LGTM


deprecate then remove *Changed listeners

 Issue by jmesserly
Originally opened as dart-lang/sdk#16993

"Changed" is a magic method suffix:
http://www.polymer-project.org/docs/polymer/polymer.html#change-watchers
it's happened quite a few times that people get errors because of this feature... they expect to use *Changed as an event listener and not have it be magic.
I think we should remove this feature from the Dart port, as it is largely replaced by another feature that is more explicit and IMHO more obvious (@ObserveProperty -- currently in our under development 0.10.0-dev pkg, inspired by this polymer.js feature: http://www.polymer-project.org/docs/polymer/polymer.html#observeblock), and fits the polymer.dart pattern of using metadata for things recognized by the base class.

 Comment by sigmundch

also - if for some reason we want to keep the feature (compat with polymer.js), then we could be more careful about fooChanged and only doing something special if there is a correspoing observable property named foo.
I also lean towards removing the feature.

 Comment by jmesserly

Removed Type-Defect label.
Added Type-Enhancement label.

 Comment by ussuri

As a user of the feature, I can attest that it's always seemed "too magical" to me. It's seemed to be in a stark contrast with the explicitness of, say, @CustomTag('my-element') class MyElement. So yes, making it more explicit would be more user-friendly and less error-prone.

 Comment by sigmundch

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

 Comment by sigmundch

Added PolymerMilestone-Next label.

 Comment by jmesserly

Removed Library-Polymer label.

 Comment by jmesserly

Removed Area-Polymer label.
Added area-pkg, Pkg-Polymer labels.

 Comment by sigmundch

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

 Comment by sigmundch

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

 Comment by jakemac53

Yes in the new polymer these methods will no longer exist

 Comment by sigmundch

Removed Polymer-Milestone-Next label.

 Comment by jmesserly

@jakemac53 is this fixed in new polymer?

 Comment by jakemac53

Closing this because I will forget later


Make project begin and end date enterable

Instead of deriving the project begin and end date from the included tasks and supplies, we should let the organizer set them specifically as project properties.

Start date: required, date picker prompt, start cannot be in past
End date: optional, date picker, end cannot be before start
possible validations: warn if due date of any task or supply is outside of project range (i.e. before start).

Really small one to do but requested by users...

@phillipoertel This is a frequent request by early Lale users. I updated the requirements above for your review. Let me know what you think.

This doesn't look too bad, I can work on this one if you're busy with other stuff @phillipoertel

@NolanChan Coolio, give it a whirl.

@ralf Mostly done, although I'm not sure if the validation for "start cannot be in past" is implemented anywhere else in Lale. It seems that in the calendar pop-up, all past dates are greyed out and cannot be chosen. The user can still manually enter a past date though. Is this enough protection, or do you want a real validation?

@nolanchan if possible we need the validation as outlined above:

Start not in the past
end not before start
all tasks and supplies as part of project should have a due date between start and end of project. Warn when saving task/supply.

Does this make sense?

As for the Start not in the past, the normal greying out in the date picker is enough.


Reproducibility Brainstorm

@shntnu @jccaicedo @MarziehHaghighi
I was thinking about our recent discussion on github reproducibility a bit more. I am wondering about different potential workflows and can think of some additional potentially helpful setups.
First Setup
The first setup is as I described on Friday:

All code and discussion (experiments, tasks, etc.) live in the repo
The code includes a numbered folder (e.g. 0.generate-profiles) that stores code, QC, and profile results.
The remaining repository is structured into various other modules that represent other experiments and/or common themes (e.g. Correlation of the present dataset with alternatives for MOA discovery). Basically any downstream analysis that uses the profiles generated in 0.generate-profiles.

Potential Alternative?
Perhaps a second setup could separate the processing code and downstream analysis into two distinct repositories. This setup could work well for a couple of reasons.

Can easily separate generating profiles from the profile analysis (we would add a link to the README in each repo cross-referencing the other).
This frees up the naming convention of the analysis repos (no more dates in the name 😉)
This could potentially aid in automation. Based on my, albeit limited, experience it seems like a lot of the profile generation is relatively consistent, and the differences are mainly nuance. I wonder if we could setup something that would create a profiling template (much like the handbook), but that is ready to run once initiated. The workflow could be something like "New Repo" --> git clone  --> profiling init (and then bash scripts would be auto populated).

Of course, every project is different, and individual decisions are required. (The same goes for storing the profiles in the actual repo! and public/private repo debate too)

note that I transferred this issue over from https://github.com/broadinstitute/profiling-resistance-mechanisms
This repo currently has the closest workflow to what is described above


cdhit dagly webs cleanup

Post-deployment cleanup for the CD-HIT-DUP work.   Pre-requisite to https://github.com/chanzuckerberg/idseq-dag/pull/268.   Based on Greg's initial draft PR.
It does two things:

Emit orrect DAG

Tolerate additional attributes in [refined_]taxon_counts_with_dcr.json

Please see comments below for test plan and post-deployment.

Copying from the older PR the comment of Charles De Bourcy which is a very helpful suggestion for testing this:
Let's get this change ready for deployment by doing the testing already. You can do the end-to-end testing change by submitting a sample from your local environment (and scaling up staging alignment machines). You can upload the sample from localhost:3000/samples/new (legacy interface) and specify a branch of idseq-dag to be used for processing, which should essentially be https://github.com/chanzuckerberg/idseq-dag/pull/252/files minus the hacks you're seeking to remove.

Please test as follows, using the local env test instructions from Charles De Bourcy's comment above.  You will not need to make any changes to idseq-dag for the initial test.

The currently deployed idseq-dag was designed to work equally well with or without this PR.

If that isn't true, change this PR or the deployed idseq-dag or both as needed --- but without deploying anything to idseq-web, yet
Only then proceed to step 2.

Test this PR with idseq-dag branch that sets count.DAG_SURGERY_HACKS_FOR_READ_COUNTING=False.   If that works, merge this PR into master, and deploy it at will.  Don't make any changes to idseq-dag as part of step 2.

After this PR is deployed, and a few days of happyness have elapsed, remove from idseq-dag all the code that becomes dead when count.DAG_SURGERY_HACKS_FOR_READ_COUNTING=False.

Here is the idseq-dag PR that you can merge after this idseq-web PR has been happily deployed to production:  https://github.com/chanzuckerberg/idseq-dag/pull/268

In testing this please consider 3 different test cases:

A tiny sample with human host.
A tiny mosquito sample.
A small sample with unpaired reads.

If it works for all 3, it's good.

Test this PR with idseq-dag branch that sets count.DAG_SURGERY_HACKS_FOR_READ_COUNTING=False.

I did that for all of

A tiny sample with human host.
A tiny mosquito sample.
A small sample with unpaired reads.

And with idseq-dag master branch for good measure.
I'm going to merge now and proceed to

After this PR is deployed, and a few days of happyness have elapsed, remove from idseq-dag all the code that becomes dead when count.DAG_SURGERY_HACKS_FOR_READ_COUNTING=False.


[cleanup] Sort imports using isort

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Sort all the imports using isort. This increases the code readability (in my opinion), but may also create merge conflicts. As such, I am neutral about whether this should get merged, but imo the updated extractors.py should get merged.
NOTE: I haven't looked at all 852 modified files, for obvious reasons

isort's defaults are terrible! All non-extractor files are already sorted with isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .. Extractors are intentionally left untouched to avoid upstream merge conflicts. If you can limit the PR to only extractors that are either new to yt-dlp (Eg: Moviepilot), or significantly modified (Eg: youtube), then I can merge it.
Otherwise I suggest making a PR to upstream instead

All non-extractor files are already sorted with isort -m VERTICAL_HANGING_INDENT --py 36 -l 80 --rr -n --tc .

Fair point, I didn't realise that. However, extractors.py isn't sorted, and hence it's hardly in alphabetical order at this stage (which happens to be the reason why I created this PR in the first place). I'm guessing that that was probably an oversight, since it's in the yt_dlp\extractor folder. However, this PR isn't going to help with that, because this PR was sorted using isort .

If you can limit the PR to only extractors that are either new to yt-dlp (Eg: Moviepilot), or significantly modified (Eg: youtube), then I can merge it.

I don't have anywhere near enough time for that. Maybe at a later stage

Otherwise I suggest making a PR to upstream instead

Okay, I'll do that when I get a chance

I'm guessing that that was probably an oversight, since it's in the yt_dlp\extractor folder.

No, it is merged frequently from upstream


Feat: Add Animation for Tab Changes

Describe the feature
Currently, when changing tabs within the application, there is no animation effect, resulting in a somewhat abrupt transition. Adding a smooth animation during tab changes would enhance the user experience by making the interface feel more responsive and polished.
Add ScreenShots
https://github.com/andoriyaprashant/OpSo/assets/98540540/5dfd3319-2dc3-482e-a53a-239d9428473e
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would like to work on this enhancement
I am interested in working on this feature and contributing to the project by implementing the proposed solution. Please assign this issue to me so I can start working on it.
Thank you!


Zoom and autoScaleYaxis issues

Hello,
I have some problems with zoom & autoScaleYaxis, when having two series that share the same yAxis. I'm using react-apexcharts, but it seems that this is a bug from apexcharts.
Codepen: https://codepen.io/alin13/pen/GRgLYVx?editors=0010
- What is the behavior you expect?
The zoom feature should work as expected and the y axis should scale based on zoom values / level.
- What is happening instead?
Y axis doesn't scale correctly.
- What error message are you getting?
No errors / warnings displayed.
Any ways to fix this problem ?
Thank you for your time! :)

autoScaleYaxis have some issues in an irregular multi-series chart.
So, the workaround is to disable autoScaleYaxis
 chart: {
    zoom: {
      enabled: true,
      autoScaleYaxis: false
    }
  }

are there any plans to fix this any time soon?

Yes, it will be addressed in the future.
The original contributor who worked on the autoScaleYaxis couldn't fix this. But, I will re-visit it after fixing high priority bugs.
Thank you!

thank you! should we keep this issue open to track it?

btw, I can work on that also, but I'll need some guidance from you on where to start

Sure, the function autoScaleY() for this is located at https://github.com/apexcharts/apexcharts.js/blob/master/src/modules/Scales.js#L452
There is a console.warn at the beginning which says the functionality is unavailable in a multi-series chart. So, currently, the function deals with the single y-axis. When you work on it, make sure to test mixed/combo charts with multiple y-axes.
Thanks for your contribution.

Hi,
I have been trying to get the autoScaleYaxis to work in react (time-series line chart)  using the same option with only one series and still the auto scale does not work and seems to have 0 as the min value always on the chart even when I didn't assign any minimum value.
Looking forward to the solution.
Thanks

Any progress on this issue?

Hi,
Have the same problem with a candlestickchart, yaxis dosen't scale right on xaxis zoom.
chart: {
zoom: {
enabled: true,
type: "x",
autoScaleYaxis: true,
},
},
xaxis: {
type: "datetime",
},
Is there any plan to fix this issue?
Thak you.

I have also noticed that autoScaleYaxis doesn't work when you have 2 synchronized charts. Is that expected?
Thanks a lot! 👍

Hi, any updates?
The bug is driving me crazy in combination with synchronized charts.

Hi, any update on this issue ?
It's really frustrated


nm: Add support of routing rule

Wait PR #603

Coverage increased (+15.6%) to 86.309% when pulling d690e7726e77d561db9d8d8b9d887431d068f0d6 on cathay4t:nm_route_rule into 42b5423a6aebff87ffc493e7f3bcdcef7be08ab6 on nmstate:master.

New patch uploaded.
Changes:

Added integration test case.
Moved ip address related function to iplib and benefit from ipaddress module:

iplib.to_ip_address_full()
iplib.ip_address_full_to_tuple()

@EdDev
New patch uploaded.
Changes:

The integration test will actually apply route rule into OS and then use ip rule command to verify that.

@cathay4t , if I understand correctly, NM is not able to provide running kernel state, just the profile config. Is this the case?

@cathay4t , if I understand correctly, NM is not able to provide running kernel state, just the profile config. Is this the case?

Yes.


fetch instead of XMLHttpRequest

This PR will not be merged, but it shows that there is a bug in how XMLHttpRequest loads a
video stream. Instead of uploading the video, it uploads the first frame (as an image).
This is the code that currently does not work:
<MediaPicker groupTypes={'All'} batchSize={25} maximum={15} assetType={'Videos'}           imagesPerRow={3} imageMargin={0} callback={(f)=> this.uploadFile(f[0])}  />

uploadFile(f) {
const file = { uri: f, name: "test.mp4", type: "video/mp4" }
const options = {
  keyPrefix: "uploads/",
  bucket: "xxxxxx",
  region: "eu-west-1",
  accessKey: "xxxxx",
  secretKey: "xxxxx",
  successActionStatus: 201
}

RNS3.put(file, options).then(response => {
  if (response.status !== 201)
    throw new Error("Failed to upload image to S3");
});
}

My implementation uses react-native-fetch-blob and works fine.

RNS3.putWithFetch(file, options).then(response => {
  if (response.status !== 201)
    throw new Error("Failed to upload image to S3");
});
}

Hi @rickevry , can you confirm that this PR will result in this library working with video upload as well? I've been using this library for months and had given up on being able to upload videos with it but if this PR fixes that then this is a godsend. Thanks!

It does work and it uploads the file to s3, but there is no promise returned out of it and you have no way to know if it happened, and the details of the item.


List events hosted in other places

As long as we're compiling lists of events & information on them, we could also add those events into Dancerfly, making it an easy place to go to search for events.

This could also function as advertising. If we got enough events in there and a good enough quality of content...

But it would also be a PITA to keep updated. But it might be beneficial to us anyway, while we're chasing down leads.

Duplicate of #288?

HAH. Whoops.

Oh, I guess you're talking about maintaining a calendar ourselves, so not really a duplicate. I'm -1 on that idea. Or maybe, like, -0.5. I'd be willing to do it, but only with the goal that eventually it would be self-maintained by event organizers.


Set status to failed when a PR has no labels

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.27%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
996

Relevant Lines:
1030

💛  - Coveralls


Google Drive Mount shows no modified date of folders

I am using Subsonic/Madsonic MP3 Server with a mounted Google Drive on Debian Jessie,
and all the folders on the mounted drive have the modification date == creation date.
But for Subsonic to scan again the folder for new files,
it searches for the modtime on the folders - which are not changed, even if you upload files ( i am not using rclone to upload files! I am using the google drive interface on another pc)
So, could you add a flag for the startup mount process which pulls and refreshes the modtime on folders?

What is your rclone version (eg output from rclone -V)
latest beta
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Debian Linux Jessie
Which cloud storage system are you using? (eg Google Drive)
Google Drive
The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone mount --allow---config /root/.rclone.conf g:/my google drive/ /home/mount/

Okay, I guess its not rclone's fault here... did some more research and came up that the folder date on Google Drive itself gets not updated.
So for a workaround I wrote a script which renames the parent-folders to a temporary name and back,
which gets the modified date updated.

Rclone doesn't currently support syncing the dates on folders.  It will at some point, probably as part of #100

Here's another workaround idea: you can simply chmod the folders on the rclone mount. It is stored locally in memory, so it will be lost once you restart rclone. This would be just one API call though, and probably less prone to race conditions.

Did you find an easy solution to this? I'm also trying to use Subsonic with gdrive mounted with rclone.


Upgrade ubuntu and JDK in CP dockerfiles

Purpose
Upgrade ubuntu and JDK in CP dockerfiles

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (8432b94) 25.98% compared to head (af356a7) 57.72%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1807       +/-   ##
===========================================
+ Coverage   25.98%   57.72%   +31.73%
===========================================
  Files         250       11      -239
  Lines       29544     1223    -28321
  Branches     4894      736     -4158
===========================================
- Hits         7678      706     -6972
+ Misses      21604      517    -21087
+ Partials      262        0      -262

Flag
Coverage Δ

adapter
?

backoffice-domain-service
57.72% <ø> (?)

common-controller
?

config-deployer-service
?

idp-domain-service
?

router
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 261 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


style: tweak more lint rules, addwords script, fix PR check

Description of changes

Fixes issue with PR lint script so it fails if any command in the pipe fails
Relax function line length and nested-statements rules
Create an addwords script for quickly adding words to the dictionary
Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10015 (19f2bb2) into master (7f9f072) will not change coverage.
The diff coverage is 62.50%.

@@           Coverage Diff           @@
##           master   #10015   +/-   ##
=======================================
  Coverage   54.08%   54.08%
=======================================
  Files         837      837
  Lines       46340    46340
  Branches     9885     9885
=======================================
  Hits        25065    25065
  Misses      19281    19281
  Partials     1994     1994

Impacted Files
Coverage Δ

packages/amplify-cli-core/src/index.ts
100.00% <ø> (ø)

...ify-cli/src/extensions/amplify-helpers/get-tags.ts
82.35% <62.50%> (+1.10%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


feat(linter): unicorn/no-anonymous-default-export

Refer to eslint-plugin-unicorn/no-anonymous-default-export
link: #684

You should use just new-unicorn-rule no-anonymous-default-export to create a new rule. The rule file will contain these tests. In general, you don't need to add these tests manually

I'll fix the conflict with the main branch.


The menu is slowly when the company has many jobs

URL: https://admin.peviitor.ro/
Browser: Chrome
Device: Laptop
OS: Windows 11
STEPS TO REPRODUCE:

Open the URL in the browser.
Search for "Prohuman" company.
Click on "Vizualizeaza joburi".
Observe how the menu is working

EXPECTED RESULTS:
The menu should run without issues and lag.
ACTUAL RESULTS:
The menu has lag.
https://github.com/user-attachments/assets/12ea3ae3-4ef0-4414-8811-41e135bb3a5f

Fixed

Fixed


Dart analyzer doesn't show error on Platform.isAndroid in const, which will be thrown when build app

This tracker is for issues related to:

Analyzer

Environemt

Dart SDK Version (dart --version)
Dart SDK version: 2.12.0-133.2.beta (beta) (Tue Dec 15 09:55:09 2020 +0100) on "windows_x64"
Flutter
Flutter 1.25.0-8.2.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision b0a2299859 (19 hours ago) • 2021-01-05 12:34:13 -0800
Engine • revision 92ae191c17
Tools • Dart 2.12.0 (build 2.12.0-133.2.beta)

Issue
I have this code:
FirebaseFirestore.instance.settings = const Settings(
          host: !kIsWeb && Platform.isAndroid
              ? '<IP_ADDRESS>:9001'
              : 'localhost:9001',
          sslEnabled: false,
          persistenceEnabled: false,
        );

Dart analyzer doesn't show any error, but when I build the app to run on android emulator, I get this error:
Context: The invocation of 'isAndroid' is not allowed in a constant expression.
Web build still works.

This appears to have been fixed, maybe last year with @kallentu's work. I cannot reproduce it, and there are many test cases in evaluation_test that seem to cover this.


websocket endpoint is only accessible from localhost

at the moment it seems that the websocket endpoint is listening on <IP_ADDRESS> which makes it impossible to connect remotely from a different docker container for example.
obviously this introduces a security risk and therefore the default should stay as is, but it would be nice to allow passing bind address to the launch method
EXAMPLE
puppeteer.launch({bindAddress: '<IP_ADDRESS>'})

You should be able to provide --remote-debugging-address as an argument option. Does that not work?
For example:
puppeteer.launch({
  args: [
    '--remote-debugging-address=<IP_ADDRESS>',
  ]
});

I am facing the same issue in a linux machine, but my issue is that chrome is opening at <IP_ADDRESS> where karma is looking for localhost. Any idea how can I force chrome to open on localhost? I used
--remote-debugging-address=<IP_ADDRESS>
but this give an error
headless_shell.cc(705)] Invalid devtools server address


Combine Filter and Search Buttons on All Services Page

Search and filter work separately, combine them to show all results in advanced search.

Search bar and category filter are working in combination as required.


Improve the code quality of the schema.column_type.ColumnType

No documentation at all. Does the name include the size and precision? God knows.
If the name is not the full name then the full_name property would be very helpful.
Consider implementing the __eq__ method for type comparison.

See linked ticket in IntRef for details


Add support for link_tokens

Allows public_key to be optional if a token is provided
Recreates the link handler if the token is updated
Use the new link handler .destroy() method instead of the one-off implementation here

@pbernasconi PTAL whenever you have some time :)

PLEASE MERGE

Would you guys mind prioritizing this? The token not updating bug largely makes the hooks implementation worthless.

I'm working with this branch and got this error

Hey @atomkirk, do you mind posting steps on how you got this error?

does prod reject a forked widget? I forked the widget to fix this and it works locally but not in production