listener not working for android

react-native :0.47.2
android device OS: marshmallow, nougat,
device manufacturer: Moto
inside  package.json   "react-native-android-sms-listener": "^0.5.0",
//code inside
let subscription = SmsListener.addListener(message => {
let verificationCodeRegex = /Your verification code: ([\d]{7})/
if (verificationCodeRegex.test(message.body)) {
let verificationCode = message.body.match(verificationCodeRegex)[1]
newThis.setState({ verificationCode: verificationCode })
}
alert(message)
console.log('message', message)
})
I have followed all installation steps and i have used alert  inside listener, even added log for message but listener not working

same problem

same  issue listener not working

have you tried everything I have mentioned in my comment.

yes tried all it is not listening

does your app asks for the Read SMS permission ?

yes it asked and i gave the permission to access sms related

tried with background task running also to wait and listen.but not listening too
const myJobKey = 'TF';
BackgroundJob.register({
jobKey: myJobKey,
job: () => {
SmsListener.addListener(message => {
this.setState({ lastMessage: message.body });
console.log(message.body);
});
}
});
BackgroundJob.schedule({
jobKey: myJobKey,
period: 1000,
timeout: 1000,
alwaysRunning: true,
persist: false
});

Seems like after an update in play service or gradle has caused this issue.
Can't run it now, earlier was working

It worked for me - @yashojha19 It saved a day for me

@yasoza , Wohooo!, Thanks.

@yasoza for me also not working , help is appreciated

@venkatesh-appoids looks like now you have to submit a request for Google to allow you to use this permission.


Build: Exclude OC-Agent exporter from this release for now.

Related to https://github.com/census-instrumentation/opencensus-java/issues/1578.

Codecov Report

Merging #1579 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1579   +/-   ##
=========================================
  Coverage     82.13%   82.13%
  Complexity     1742     1742
=========================================
  Files           260      260
  Lines          8077     8077
  Branches        770      770
=========================================
  Hits           6634     6634
  Misses         1209     1209
  Partials        234      234

Impacted Files
Coverage Δ
Complexity Δ

...ace/ocagent/OcAgentTraceExporterConfiguration.java
100% <ø> (ø)
2 <0> (ø)
:arrow_down:

...s/exporter/trace/ocagent/OcAgentTraceExporter.java
22.58% <ø> (ø)
3 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644f466...e87c12a. Read the comment docs.

Let's hold on this until we have the mesures defined.

SGTM

PTAL - will merge this PR after https://github.com/census-instrumentation/opencensus-java/pull/1563 is submitted.


Upgrade to NPM v8

Summary

Closes #
Deployment Link

https://terra-core-deployed-pr-#.herokuapp.com/
Testing

Additional Details

Thank you for contributing to Terra.
@cerner/terra

Test PR that is no longer needed.


[Suggestion] Automated dependency updates

Current Behavior
It seems like dependencies are updated manually.
Desired Behavior
In order to avoid risk of bugs or security holes, it could be a great if we can be noticed by third party modules updates like rollup, babel, etc.
Suggested Solution
RenovateBot: https://renovatebot.com/
Who does this impact? Who is this for?
All users
Describe alternatives you've considered
Open to any other alternatives

implemtend

Thanks ;)


Touch event on PC should open on-screen keyboard

The convention on a Windows computer with a touch-screen is:

A click event in a user-input field should not display an on-screen keyboard, but
A touch event in a user-input field should display an on-screen keyboard.

We should probably follow this convention when choosing whether to display (for example) our number pad.

@rachel-fenichel Btw I was curious if you tested this?

Currently touch events on edge on windows are fairly broken--edge and IE don't implement the touch events API, only pointer events.  I need to go back and test it again but I'm not optimistic right now.

@rachel-fenichel - How long until every company/organisation quits using IE/Edge and Microsoft gives up hope in making a browser?

@chexbox Please keep your comments constructive.

This is working now on a surface tablet.


Consider Art Mode as "Off" or "Standby"

Hi,
thank you very much for this plugin.
While having the option is_frame_tv is possible to power off the tv completely, I rather do not use this option. The art mode turns off automatically when I leave the room or with the light sensor on the TV. I use the normale "power off" switch in everyday usage.
But: The art mode is a third state. Along with on and off, we do have the mode art. This must be considered either as off or if that is possible with its own state art, which is considered as off. The screenshot below shows the state of three Samsung TVs.

Is a normal Samsung smart TV, everything works fine, even app list gets updated without any parameter
This is a Frame TV. It is currently in art mode. It is here considered powered ON (it uses the "arte" logo, which is a channel, but that's wrong).
Is a Frame TV completely OFF (the motion sensor turns it off after 15 minutes).

If is_frame_tv is set, then I cannot turn the TV "really" on. Pressing on the power button in HA does not do anything then. Is the TV is ON, then pressing turns it OFF completely, like documented.
If is_frame_tv is not set, then I can turn on the TV from art mode. (it switches in HA shortly to off, because it thinks it was already ON, but eventually recognises the correct state after some seconds). If it was completely OFF, it switches first to art mode with a power button pressed in HA and then after a second press to ON.
In my opinion, it could be possibly to support Frame TVs without this parameter, if it is possible to recognise all three modes correctly. The TV emits "art" in this case.

Thanks for the detailed feedback, that really helps!
We should improve the behavior around this - I do not own a frame TV and nor does @jaruba so we cannot witness ourselves which makes this tricky... the simplest we should do is ignore 'art' while looking for a logo (or develop a special logo).
I would consider the following:

'art' should be spelled 'Art' and could be a mode the TV is in. We could develop a special logo for this mode or just have no logo at all. I believe we could make it show this, while HA thinks it is in either 'off' state or 'on' state. It would be quite an ordeal to have a third state 'art', but we could think about it... need more info first.
Since we have no special code that defines 'art' I suspect the 'art' is a feedback from smartthings as a 'channelName' or even an 'inputSource' in which the TV is... it would help to have this confirmed.
When is_frame_tv is enabled all the component does extra right now is on turn_off hold the power button for 3 seconds instead of a single push. Nothing more at the moment - we could look to expand this, but again - really hard to do without owning such a tv.

The following questions:

Do you have smartthings enabled? I.e. api_key and device_id are filled in?
Can you show the output of your living room tv in https://graph-eu01-euwest1.api.smartthings.com/device/show/<device_id> while your TV is in this art mode? Should show something like this - I like to particularly see 'switch', 'inputSource' and 'channelName':

If above does not show any states for you try and edit your device in smartthings into a 'Samsung OCF TV' and see if then it starts showing some states.

Is there any control you can do while the TV is in art mode? I assume you can change painting/scene it shows somehow? Can you explain if/how this can be done? If done via certain keys on your remote while in art mode, can you try doing the same with a service call via the component to see if it also responds to this while in art mode? E.g.:

If you press a key to go to a channel or source while in art mode, does the TV immediately respond to this? Or do you have to specifically hit the 'power on' key to make it fully turn on?

Your answers could really help us improve, without further info it's hard for us to do anything but ignore keyword 'art' while looking for a matching logo.

Hi, thanks for the fast response.
First, here is the TV in the Bedroom (The Frame 2017/2018 model; Living room is newer and has along with the art mode also an ambient mode). but first things first:
inputSource: digitalTv
supportedInputSources:
[
    "digitalTv"
]
data:
icv: core.1.1.0
mndt: 2018-01-01
n: [TV] Samsung Frame Series (43)
mnsl: http://www.samsung.com/sec/tv/overview/
dmv: res.1.1.0,sh.1.1.0
di: bcdd11f9-8694-4c7c-b502-9a402cd4792a
mnmo: UE43LS03N
mnmn: Samsung Electronics
mnos: 4.1.10
mnpv: Tizen 4.0
st: 2020-12-20T10:17:48Z
mnfv: T-KTM2DEUC-1310.4
mnml: http://www.samsung.com
pi: bcdd11f9-8694-4c7c-b502-9a402cd4792a
vid: VD-STV_2018_K
mnhw: 0-0
firmwareVersion: 2.4.0
error:
volume: 7
supportedPictureModes:
[
    "Dynamisch",
    "Standard",
    "Nat\u00fcrlich",
    "Film"
]
supportedPictureModesMap:
[
    {
        "id": "modeDynamic",
        "name": "Dynamisch"
    },
    {
        "id": "modeStandard",
        "name": "Standard"
    },
    {
        "id": "modeNatural",
        "name": "Nat\u00fcrlich"
    },
    {
        "id": "modeMovie",
        "name": "Film"
    }
]
pictureMode:
switch: on
supportedTrackControlCommands:
playbackStatus:
supportedPlaybackCommands:
[
    "play",
    "pause",
    "stop",
    "fastForward",
    "rewind",
    "next",
    "previous"
]
mute: unmute
tvChannel:
tvChannelName: art
soundMode: Verstärken
supportedSoundModesMap:
[
    {
        "id": "modeStandard",
        "name": "Standard"
    },
    {
        "id": "modeSmart",
        "name": "Optimiert"
    },
    {
        "id": "modeAmplify",
        "name": "Verst\u00e4rken"
    }
]
supportedSoundModes:
[
    "Standard",
    "Optimiert",
    "Verst\u00e4rken"
]
supportsPowerOnByOcf: false
onsupport: false
_supportedPictureModes: [{"x.com.samsung.tv.name":"Dynamisch","x.com.samsung.tv.id":"modeDynamic"},{"x.com.samsung.tv.name":"Standard","x.com.samsung.tv.id":"modeStandard"},{"x.com.samsung.tv.name":"Natürlich","x.com.samsung.tv.id":"modeNatural"},{"x.com.samsung.tv.name":"Film","x.com.samsung.tv.id":"modeMovie"}]
_supportedSoundModes: [{"x.com.samsung.tv.name":"Standard","x.com.samsung.tv.id":"modeStandard"},{"x.com.samsung.tv.name":"Optimiert","x.com.samsung.tv.id":"modeSmart"},{"x.com.samsung.tv.name":"Verstärken","x.com.samsung.tv.id":"modeAmplify"}]
cloudSupported: true

The icon for power on/off on the remote looks like the following

It seems to send the same signal to an ordinary Samsung TV, as I can switch the remotes between all models. Here the normal power switch:

While in the art mode, if I press the "back" key, the circle itself or left/right/up/down, I get in an options menu, where I can make several settings in the art mode.
If I press the power or home or app button (Netflix, prime, Rakuten), the tv is immediately "on", or in the app.
Where can I find the Service section to do the calls?

Very helpful these answers, thanks!
The services section is in 'Developer tools' in the sidebar:

From the smartthings output it is considered 'on' with channelName: 'art' which could be a nice way of distinguishing art mode vs. it being on in an app or showing a tv channel. Sadly I believe that people that do not use smartthings do not have this luxury and we will not be able to distinguish...
From watching some youtube video's on the TV it seems to auto turn on into art mode and auto turns off if you leave the room? When it really turns off fully, does it show correctly as off in HA after a while?
What update_method do you have defined in your configuration?

Correct, if those options are set, it goes to an OFF state. Also HA shows then OFF.
Where can I found the update_method? I am new to HA. Nothing found in configuration.yaml.

Where can I found the update_method? I am new to HA. Nothing found in configuration.yaml.

That is ok, that means you did not make changes and use the default method (ping). Thanks for providing all this info, I will need to have a think through what we could do about this.
If you can tell me more about the TV with ambient mode that could be great as well, like:

A smartthings state dump for when the TV is in ambient mode
Behavior description of ambient mode (is it same as art?)
Same button possibilities?

Ambient mode:
switch: on
tvChannel:
tvChannelName: ambient

If the TV is completely off, the channel name keeps art or ambient, but switch is off.
Complete output:
inputSource: digitalTv
supportedInputSources:
[
    "digitalTv"
]
data:
icv: core.1.1.0
mndt: 2020-01-01
n: [TV] Samsung The Frame (55)
mnsl:
dmv: res.1.1.0,sh.1.1.0
di: 51b8d61d-4328-e6d6-5523-30c1caad1a6c
mnmo: GQ55LS03TAUXZG
mnmn: Samsung Electronics
mnos: Tizen
mnpv: 5.5
st: 2020-12-20T09:24:27Z
mnfv: T-NKMDEUC-1403.1
mnml:
pi: 51b8d61d-4328-e6d6-5523-30c1caad1a6c
vid: VD-STV_2018_K
mnhw:
firmwareVersion: 3.4.0
error:
volume: 8 %
supportedPictureModes:
[
    "Dynamisch",
    "FILMMAKER MODE",
    "Standard",
    "Film",
    "Nat\u00fcrlich"
]
supportedPictureModesMap:
[
    {
        "id": "modeDynamic",
        "name": "Dynamisch"
    },
    {
        "id": "modeFilmmakerMode",
        "name": "FILMMAKER MODE"
    },
    {
        "id": "modeStandard",
        "name": "Standard"
    },
    {
        "id": "modeMovie",
        "name": "Film"
    },
    {
        "id": "modeNatural",
        "name": "Nat\u00fcrlich"
    }
]
pictureMode: Standard
switch: on
supportedTrackControlCommands:
playbackStatus:
supportedPlaybackCommands:
[
    "play",
    "pause",
    "stop",
    "fastForward",
    "rewind",
    "next",
    "previous"
]
mute: unmuted
tvChannel:
tvChannelName: ambient
soundMode: Verstärken
supportedSoundModesMap:
[
    {
        "id": "modeStandard",
        "name": "Standard"
    },
    {
        "id": "modeAmplify",
        "name": "Verst\u00e4rken"
    }
]
supportedSoundModes:
[
    "Standard",
    "Verst\u00e4rken"
]
supportsPowerOnByOcf: true
onsupport: true
_supportedPictureModes: [{"x.com.samsung.tv.name":"Dynamisch","x.com.samsung.tv.id":"modeDynamic"},{"x.com.samsung.tv.name":"FILMMAKER MODE","x.com.samsung.tv.id":"modeFilmmakerMode"},{"x.com.samsung.tv.name":"Standard","x.com.samsung.tv.id":"modeStandard"},{"x.com.samsung.tv.name":"Film","x.com.samsung.tv.id":"modeMovie"},{"x.com.samsung.tv.name":"Natürlich","x.com.samsung.tv.id":"modeNatural"}]
_supportedSoundModes: [{"x.com.samsung.tv.name":"Standard","x.com.samsung.tv.id":"modeStandard"},{"x.com.samsung.tv.name":"Verstärken","x.com.samsung.tv.id":"modeAmplify"}]
cloudSupported: true

All buttons, including volume seems to work (ambient also plays some background noise). If I press on "on" or "home" TV turn on. Here a small gif

This is awesome feedback, thanks so much. It looks from Samsung documentation that ambient mode does not automatically turn on when you enter the space (at least on non-frame TVs). While for frame TVs that does seem to be a feature, at least for art mode. Can you confirm if you can set it to auto turn on into ambient mode instead of art too?
It does also seem like the button behaviour is different thanks to the special ambient button. I'd expect for non-frame TVs that the power button always puts the tv into tv mode. Only if you press ambient mode button or navigate to app it turns into ambient mode.
Is there a way for you to configure your frame tv to completely disable art or ambient mode in your poweron and poweroff sequence?

@Screwdgeh
Ollo69 did some work on detecting Art Mode from Frame TVs in his fork of this component, see here:

https://github.com/ollo69/ha-samsungtv-smart/blob/master/custom_components/samsungtv_smart/api/samsungws.py#L71-L75
https://github.com/ollo69/ha-samsungtv-smart/blob/master/custom_components/samsungtv_smart/media_player.py#L900-L908

We should be able to use his smasungws.py in our component too, the same file is called websockets.py in our repo.

any news to manage art mode of Frame TV? I have 2020 model...I can help in any way?

Trying to wrap my head around the code in Ollo69's component... it seems very elaborate! He sets up a separate websocket connection for checking the status of the art app.
I really wonder if we include the art app into our normal applist it would probably fetch the status of it correctly and sets it as the current running app. Then based on the fact that the art app is the running app we can do our decision making on what to do with turn on/turn off actions in this case.
I see that Ollo69 has another way of checking which app is running. He does that also always using websocket instead of our rest call. @ollo69: do you think that calling http://{host}:8001/api/v2/applications/com.samsung.art-app will also give a response that includes 'visible' like in below function? Our component uses this currently to understand what is the currently running app.
def _get_running_app(self):
    if self._app_list is not None:
        if hasattr(self, '_cloud_state') and self._cloud_channel_name != "":
            for attr, value in self._app_list_ST.items():
                if value == self._cloud_channel_name:
                    self._running_app = attr
                    return
        if self._scan_app_http:
            for app in self._app_list:
                r = None
                try:
                    r = requests.get('http://{host}:8001/api/v2/applications/{value}'.format(host=self._host, value=self._app_list[app]), timeout=0.5)
                except requests.exceptions.RequestException as e:
                    pass
                try:
                  if r is not None:
                      data = r.text
                      if data is not None:
                          root = json.loads(data.encode('UTF-8'))
                          if 'visible' in root:
                              if root['visible']:
                                  self._running_app = app
                                  return
                except Exception as ex:
                       _LOGGER.debug("Samsung TV %s, _get_running_app Failed - %s......",self._name,ex)
    self._running_app = 'TV/HDMI'

I did some test on my Frame TV (2020 model).
Art Mode indeed seems to be nothing more then a App. If I define it in my app_list its correctly detected:
    app_list: >-
      {
        "Netflix": "org.tizen.netflix-app",
        "Prime Video": "org.tizen.primevideo",
        "Disney+": "MCmYXNxgcu.DisneyPlus",
        "Art Mode": "art"
      }

With is_frame_tv set to false the behavior of pressing the media player power button is as follows:

When Art Mode (app) is active the TV returns to its state from before Art Mode was enabled and the menu is shown. In HA the TV is shown as off but will recovers automatically to correct state.
When watching TV or another app then Art Mode is active the TV switches to Art Mode. In HA the TV is shown as off but it recovers automatically to Art Mode.
When the TV is Off it turns on to its previous state which could be Art Mode and in this case you need to press power again to start watching TV. This is the same behavior as the remote.

With is_frame_tv set to true the behavior of pressing the media player power button is as follows:

When Art Mode (app) is active the TV turns off and the state in HA matches.
When watching TV or another app then Art Mode is active the TV turns off and the state in HA matches.
When the TV is Off it turns on to its previous state which could be Art Mode and in this case you need to switch source in order to exit Art Mode and start watching TV.

Both cases don't really work as expected is_frame_tv set to false is closes to the users expected behavior and the remote with the exception that you can't turn off the TV manually (Art Mode the motion and light sensor could handle this automatically).  The main issue in HA is that it thinks the TV is turned off when switching from Art Mode to TV or vice versa which prevents you to control the TV until it recovers.
With is_frame_tv set to false you can't switch to art mode trough the power buttons as intended for a Frame TV, it always turns off completely. You need to launch Art Mode as an app and similar exit Art Mode by switching to another source. This does prevent HA from thinking the TV is off but the behavior of the media player does not matches the users expectations and the remote.  From HA Art Mode can only controlled as an app which is not ideal for interactive use from HA.

I did some test on my Frame TV (2020 model).
Art Mode indeed seems to be nothing more then a App. If I define it in my app_list its correctly detected:
    app_list: >-
      {
        "Netflix": "org.tizen.netflix-app",
        "Prime Video": "org.tizen.primevideo",
        "Disney+": "MCmYXNxgcu.DisneyPlus",
        "Art Mode": "art"
      }

With is_frame_tv set to false the behavior of pressing the media player power button is as follows:

When Art Mode (app) is active the TV returns to its state from before Art Mode was enabled and the menu is shown. In HA the TV is shown as off but will recovers automatically to correct state.
When watching TV or another app then Art Mode is active the TV switches to Art Mode. In HA the TV is shown as off but it recovers automatically to Art Mode.
When the TV is Off it turns on to its previous state which could be Art Mode and in this case you need to press power again to start watching TV. This is the same behavior as the remote.

With is_frame_tv set to true the behavior of pressing the media player power button is as follows:

When Art Mode (app) is active the TV turns off and the state in HA matches.
When watching TV or another app then Art Mode is active the TV turns off and the state in HA matches.
When the TV is Off it turns on to its previous state which could be Art Mode and in this case you need to switch source in order to exit Art Mode and start watching TV.

Both cases don't really work as expected is_frame_tv set to false is closes to the users expected behavior and the remote with the exception that you can't turn off the TV manually (Art Mode the motion and light sensor could handle this automatically).  The main issue in HA is that it thinks the TV is turned off when switching from Art Mode to TV or vice versa which prevents you to control the TV until it recovers.
With is_frame_tv set to false you can't switch to art mode trough the power buttons as intended for a Frame TV, it always turns off completely. You need to launch Art Mode as an app and similar exit Art Mode by switching to another source. This does prevent HA from thinking the TV is off but the behavior of the media player does not matches the users expectations and the remote.  From HA Art Mode can only controlled as an app which is not ideal for interactive use from HA.

Honestly I don't have a Frame TV, I implemented the dedicated WS channel but the test are only based on users feed-back.
Make sense that Art Mode is managed as an app, but the advantage of using the dedicated channel is because is possible to have a more immediate feed-back of the TV state (is the TV the provide the new state and not the result of a polling). I suppose that Samsung implement the channel for this reason.
Generally speaking I implemented the communication using the WS channels always active because this is the way that a WS protocol should work. Continuously open the WS require to perform every time authentication, this obviously cause delay and potential failure of the command sent. And if you call rest API when the WS channel is closed (for timeout), you could receive a popup requesting authentication on the TV, because you are open a new connection with a different name,

Honestly I don't have a Frame TV, I implemented the dedicated WS channel but the test are only based on users feed-back.
Make sense that Art Mode is managed as an app, but the advantage of using the dedicated channel is because is possible to have a more immediate feed-back of the TV state (is the TV the provide the new state and not the result of a polling). I suppose that Samsung implement the channel for this reason.
Generally speaking I implemented the communication using the WS channels always active because this is the way that a WS protocol should work. Continuously open the WS require to perform every time authentication, this obviously cause delay and potential failure of the command sent. And if you call rest API when the WS channel is closed (for timeout), you could receive a popup requesting authentication on the TV, because you are open a new connection with a different name,


Value: zero-size array to reduction operation maximum which has no identity

Hello,
I'm clicking around after having downloaded a demo tsv file, and it looks great.
However, I got stuck very often with the error message:

And I can't get rid of it, unless if I close the window and restart regexport.
Isn't there an error to catch ? Or what am I doing wrong ?
Thanks!
Nicolas

Hi Nicolas, many apologies for the slow reply.  Agreed, this error message is very annoying, it doesn't help much.  It appears when a brain region is currently selected that contains zero cells (in the screenshot here, I would guess that there are no cells in the "fiber tract" category of brain regions).  To get around it, just hit "ok" and click a different brain region.
This would be a valuable bug to fix.  I'll pin the issue here as a reminder.


Discarding cookies in client session

It looks like there is no good way to discard cookies after each request.
In previous versions of aiohttp I've just used aiohttp.request(connector=...) for requests, but it's deprecated now. And it looks like the only way to do connections is to make ClientSession.
But ClientSession has hardcoded cookie processing which I don't need at all. I supply Cookie header value to the client_session.request(). And it gots replaced as soon as first response returns Set-Cookie (I mean CookieJar replaces the header on the all following requests), as far as I can observe.
Currently, I can fix it by:
session._cookie_jar._cookies.clear()
session.request(...)

But it looks like too ugly and wrong.
The overall use case is similar to a simple proxy: I maintain multiple server connections and send requests to the backends using a single ClientSession (to maintain a single connection pool for all incoming connections). So CookieJar's implementation handling is just wrong for it.
Any good ideas how to achieve this using aiohttp?

You can replace session._cookie_jar._cookies.clear() with just session.cookies.clear().
As an option we may add new flag to ClientSession for disabling cookie processing.

You can replace session._cookie_jar._cookies.clear() with just session.cookies.clear().

Sorry missed that property.

As an option we may add new flag to ClientSession for disabling cookie processing.

Would be nice. Because I don't want to pay for call_later used for cookie tracking.
Alternatively, there might be an option to replace CookieJar class with some no-op class. But I'm not sure if there are any other use cases for that. Maybe storing cookies on disk/across processes?

Fixed by #963

Looks great. Thanks!


Refresh apt metadata

The metadata for apt is over a year old.   Time to update and let apt update get fresh metadata

Pull request:

https://github.com/Senzing/docker-apt/pull/22


Join multiple pictures

Sometimes I need to join multiple photos together in a single photo, vertical and horizontal
And i think it is a good feature to be shown in image toolbox app

Possible duplicate of #364

I will add this, but firstly i'll drop 2.3.0 with new background remover and other fixes

Thank you so much

I will close it in favor of #364 (I don't have much time right now, but I hope to be able to tackle this request in the near future)


[NEWGAME] : Pig game

Description
I want to add pig game using HTML CSS javascript
Can you please assign me this task under GSSOC'23 contribution @panwar8279 @ra
Screenshots
No response
Additional information
No response

Hi @Kalivarapubindusree , I have assigned this task to you. Kindly complete your work within a week. Make sure you will make your game in react because it's react based repository. Good luck!

https://github.com/ssitvit/Games-and-Go/pull/635
Please merge this pr or else if I do this game pr all files together confusion @panwar8279
Thanku


Add support to rollup to multiselect picklists

Currently, Rollup will just produce one string of comma-delineated values as multiselect picklist value.
Repro steps:

Create a record triggered flow (after create) for child object
Add a Get Element for Parent object
Add a Get Element for the correct children of the Parent
Rollup Invocable with the following variables:

Calcitemrollupfield of a String
Lookup Field on Calc Item is a Lookup to Parent
Lookup field on Rollup Object is Id of Parent
Rollup Context is update
Rollup object field is a multiselect picklist field
Rollup op is CONCAT_DISTINCT
Rollup target's SObject name is Opportunity
Records to rollup is variable from Step 3

Envrionment Variables:
Spring 21/api 51

@ssk42 first of all - it's an honor hosting an issue for you here. I can commit to getting this fixed in the near future; if not tonight, by end of tomorrow certainly.

@ssk42 - you should be all set with the latest release - enjoy!

This gets closer but doesn't quite fix it. The first two items/strings/whathaveyou for some reason aren't comma delineated and so they still come across together as one item. After that though every other item rolls up great into a multiselect picklist. Thanks for getting work into this so quick!

@ssk42 iiiiiinteresting. Can you share a screenshot (or even just text) of what the text values for the first few items are? It should be simply adding “;” between values, so I want to ensure I understand the input so I can reproduce the output.

Same repro steps as above.  It's mostly just that the rollupField__c value is now testAccount1testAccount2;testAccount3, etc.

Officially closed with @ssk42 's blessing as part of #55


Production deployment failed

We are investigating why the deployment of core failed, Alexey pointed it out an error related to a warn message that shouldn't crash the deployment.
{"err":"user: unknown userid<PHONE_NUMBER>","file":"/tmp/go/src/github.com/fabric8-services/fabric8-wit/main.go","func":"main.printUserInfo","level":"warning","msg":"failed to get current user","pkg":"main","time":"2017-07-26 05:22:45"} in the log

The logs of the pods for the deployment 33 are a bit weird, I cannot find an error or panic kubernetes.pod_name: "core-33-ivez5" and kubernetes.pod_name: "core-33-agu4k".

I am able to reproduce the issue without seeing any error in the logs of the pod. Maybe it is related to the healthchecks being faster than the migration

{"err":"user: unknown userid<PHONE_NUMBER>","file":"/tmp/go/src/github.com/fabric8-services/fabric8-wit/main.go","func":"main.printUserInfo","level":"warning","msg":"failed to get current user","pkg":"main","time":"2017-07-26 10:16:07"}
--
  | {"level":"info","msg":"Configured connection pool max idle 90","time":"2017-07-26 10:16:07"}
  | {"level":"info","msg":"Configured connection pool max open 90","time":"2017-07-26 10:16:07"}
  | {"current_version":63,"level":"info","msg":"Attempt to update DB to version 64","next_version":64,"pkg":"migration","time":"2017-07-26 10:16:07"}
  | {"current_version":63,"level":"info","msg":"Successfully updated DB to version 64","next_version":64,"pkg":"migration","time":"2017-07-26 10:16:07"}
  | {"current_version":64,"level":"info","msg":"Attempt to update DB to version 65","next_version":65,"pkg":"migration","time":"2017-07-26 10:16:07"}

That's odd, prod is at 69:
2017-07-16 13:45:05.227708+00 |      68

@aslakknutsen I reproduced in a different cluster :). I disabled the healthchecks so I was able to finally get the real error which was https://gist.github.com/hectorj2f/bf4507fbfbfc21ad5d14f0412d90b1a4


[hotfix][docs] Fix HTML formatting in ops/metrics.md

What is the purpose of the change
Fix HTML in ops/metrics.md (Rendering of HTML was broken due to misplaced newline)
Brief change log
Fix 'Note' paragraph and adapt to style to other 'Note' paragraphs of the rest of the document.
Verifying this change
Verified locally with IDE-integrated markdown renderer
Does this pull request potentially affect one of the following parts:
Only docs affected
Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the fix @smattheis . Have you checked locally that this is now working fine?
Can you explain what was the problem before? Empty line was prematurely terminating the table?

Yes, exactly the new line was breaking the HTML rendering. I have checked locally via IntelliJ markdown rendering that it should be fixed now.

By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.

By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.

No, I wasn't aware of that. Will check it.

By locally I meant building the docs locally (described in the readme I think: https://github.com/apache/flink/tree/master/docs ), just to be sure it's working fine.

@pnowojski Checked it. It's fine.

@pnowojski backport to any previous version not required as watermarkAlignmentDrift is new in 1.15


Private parameters are reported as unused

Before submitting a bug report:

Make sure you are able to repro it on the latest released version
Perform a quick search for existing issues to check if this bug has already been reported

Steps to reproduce
Run the analyzer against this script.
Param (
    [String] $private:var1
)

function Test-Second
{
    # $var1 is not accessible because it was private to the script.
    Write-Information -InformationAction "continue" "From script: $var1"

    # $var2 is not private to the calling function so we can access it.
    Write-Information -InformationAction "continue" "From caller: $var2"
}

function Test-NotGlobal
{
    Param (
        [String] $var2
    )
    $a = $var1 + " " + $var2
    Write-Information -InformationAction "continue" "Concatenation: $a"
    Test-Second
}

Test-NotGlobal $var1

Expected behavior
Expect no errors because $private:var1 and the use in the last line of $var1 are the same variable and $var1 is private to the script, as required.

Actual behavior
PS C:\Users\pauldsmith> Invoke-ScriptAnalyzer c:\temp\gvar.ps1

RuleName                            Severity     ScriptName Line  Message
--------                            --------     ---------- ----  -------
PSReviewUnusedParameter             Warning      gvar.ps1   2     The parameter 'private:var1' has been declared but not
                                                                  used.

PS C:\Users\pauldsmith>

If an unexpected error was thrown then please report the full error details using e.g. $error[0] | Select-Object *
Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.22621.963
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.963
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }

1.21.0

This doesn't seem to happen with
$private:aa='sdf'
get-childitem $aa

So might be an easy improvement if you want to make that. But as the rule generally can result in lots of false positives due to it being limited to current scope, effort to such enhancements will be limited by the maintainers.

I get the same violation in this script for the $Summary, $Description, and $Type parameters, despite them being used the CreateIssue function. Is this the same issue, or a different one with the same output?
param
(
    $Summary,
    $Description,
    $Type,
    $IssueComponent,
    $LinkUrl,
    $LinkTitle
)

function CreateIssue
{
    $body = @{
        fields = @{
            project = @{
                key = $Env:JIRA_PROJECT_KEY
            }
            summary = $Summary
            description = $Description
            issuetype = @{
                name = $Type
            }
            labels = @('created-from-github')
        }
    }

    if (-not [string]::IsNullOrWhiteSpace($IssueComponent))
    {
        $body.fields += @{
            components = @(@{
                name = $IssueComponent
            })
        }
    }

    $bodyJson = $body | ConvertTo-Json -Depth 9

    $response = Invoke-JiraApiPost 'issue' $bodyJson

    Write-Information "Jira issue created with the key $($response.key)." -InformationAction Continue

    $response.key
}

function AddLink
{
    param($issueKey)

    $bodyJson =  @{
        object = @{
            url = $LinkUrl
            title = $LinkTitle
        }
    } | ConvertTo-Json -Depth 3

    Invoke-JiraApiPost "issue/$issueKey/remotelink" $bodyJson
}

$issueKey = CreateIssue
AddLink $issueKey
Set-GitHubOutput 'issue-key' $issueKey
Set-GitHubOutput 'issue-url' "$($Env:JIRA_BASE_URL )/browse/$issueKey"


C++ client producer sendAsync() timeout check method seems too arbitrary

C++ client producer sendAsync() timeout check method seems too arbitrary
Analysis
In general, the c++ client producer timeout check was implemented in pulsar/pulsar-client-cpp/lib/ProducerImpl.cc, ProducerImpl::handleSendTimeout(...), which is registered as a handler of ProducerImpl::sendTimer_;
In any performing phase of ProducerImpl::sendTimer_, the very first pulsar::OpSendMsg element inside ProducerImpl::pendingMessagesQueue_ will be picked up and compare the  OpSendMsg::timeout_ with current tick. If the time diff is less than 0, there is a sending timeout happens.
So far so good.
But then, it invokes the method ProducerImpl::failPendingMessages(...) for dealing the message failure stuff. Definitely, it works, but not only on the message it already checked as we hoped, but just all the messages inside ProducerImpl::pendingMessagesQueue_.
Result: Inside a sending timeout check, if the very oldest message inside the pending queue timeout, will lead all the messages inside the pending queue to be processed as a timeout
Expected behavior
A more specifical check on every message timeout.
Desktop (please complete the following information):

OS: centOS

About the performance
As there are much more performing of check and compare than it was, the performance will downgrade undoubtedly. We may have a discussion of it, and make a decision then.

But then, it invokes the method ProducerImpl::failPendingMessages(...) for dealing the message failure stuff. Definitely, it works, but not only on the message it already checked as we hoped, but just all the messages inside ProducerImpl::pendingMessagesQueue_.

The reason for erroring out all the messages in the queue after the 1st message times out is to give chance to the application to preserve ordering.
If you're publishing m1, m2 and m3. If m2 times out, a consumer might see m1 followed by m3. By clearing the queue, application can decides to resend m2 & m3 in same order (or just failed both upstream operations).
Another consideration, is that typically the timeout is set to a value which is order of magnitudes bigger than the normal publish latency (eg: 30sec vs 5millis). This means that when one message times out, it will be very likely that some bigger issue is involved and that most of the messages will anyway hit the timeout threshold.

@merlimat  Yes, your word sounds reasonable. Thanks for the response.
I will close this issue then.


[fix] fix svace issue

Delete duplicated unittest
Added try catch statement to catch exception

Signed-off-by: hyeonseok lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #1939. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.


Divide design form into sections

The design form is currently very long, and expected to grow. Design/research some possible solutions for making the form shorter, e.g. a multi-step wizard or collapsible sections. Make changes to the form structure based on the design decision and possibilities for the autogenerated form.

b406c9620ed8c6702eedae1958f511c08022be6f (in branch ui1) splits up the different major sections of the schema and splits them into separate views.

ui1 was merged into master, so this issue is resolved.


I don't know if you seen my reply in the other issue, still not working on ACS

I get a tracer but silent aim isn't working

Duplicate of #11


Git submodule update recursively broken

Command failed: "C:\\Users\\BobbyGetka\\AppData\\Local\\Atlassian\\SourceTree\\git_local\\mingw32\\bin\\git.exe" submodule update --init --recursive -- .
fatal: 'submodule' appears to be a git command, but we were not
able to execute it. Maybe git-submodule is broken?

This was fixed at some point


update link in README for MarkerClusterer docs

The READMEs currently link to a seemingly outdated set of docs that don't include a list of what the options are that you can use with the MarkerClusterer constructor.

@rossjs Can you sign the CLA so that I can merge? Thanks for the PR and apologies for the really slow response on this.

@amuramoto No problem at all. Just submitted the CLA.

Thanks for the PR!


Issue ED-4770 SCSS support for angular Migration While migrating Sunbird ED-Portal from Angular v14 to v15 -- Form Fields


Import fossil areas of significance

Need to determine where to obtain this data

Complete. Pulled the layer as a shapefile into the private repo in pkg/business_data/gis_data/FOSS_IMPORTANT_FOSSIL_AREAS_SP and created a script to generate the mapping file and clean the file for import. Not generating UUIDs before the import into Arches.


Add experimental graphql support

Included README.md describes initial features.
This patch includes a simple graphiql ui which is preconfigured to explore a noms/graphql endpoint
towards #3120

cc @aboodman

Codecov Report

Merging #3146 into master will increase coverage by -0.14%.

Impacted Files
Coverage Δ

go/datas/database_server.go
0% <ø> (ø)
:white_check_mark:

go/ngql/query.go
100% <100%> (ø)

go/datas/remote_database_handlers.go
70% <3.57%> (-8.48%)
:x:

go/ngql/types.go
83.62% <83.62%> (ø)

js/noms/src/set-test.js
100% <ø> (+0.23%)
:white_check_mark:

go/datas/http_batch_store.go
88.05% <ø> (+0.62%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e40ee4...04812f3. Read the comment docs.

On Sun, Feb 5, 2017 at 9:44 PM, Rafael Weinstein<EMAIL_ADDRESS>wrote:

@rafael-atticlabs commented on this pull request.
In go/ngql/README.md https://github.com/attic-labs/noms/pull/3146:

@@ -0,0 +1,39 @@
+# Noms GraphQL

+An experimental bridge between noms and GraphQL
+
+# Status
+

All Noms types are supported except

It's kind of a grab bag. I'm not aware of any fundamental issues.
Just unimplemented:
-Type (a few ways to do this: use graphql types or define our own)
-Blob (presumably, we'd just define Blob scalar type and just use base64)

Hm. Blob is pretty fundamental to our current applications.

graphql-go impl issue:
-Nested collections. JS appears to allow this. Option 1) add support,
Option 2) just get more verbose and require all collections to have a
containing struct. can kind of see whether its in our way.

We use nested collections all over the place because Noms lacks multimaps.
Everyplace we want to represent an index we use Map<Key, Set>. Sorry
:-/.

unsure:
-Unions with non-struct component types. Don't see any reason why this
wouldn't work, but again go impl doesn't support
Mutations:
-multiple ways to do this. my idea right now is to basically support a
single update mutation which takes a collection of arguments which sort
of logically are the changes we'd encode in the graph-mutator.
Set intersection:
-requires doing some refactoring in noms so that datas can use paths
(right now creates cyclic package references).
Perf: I suspect there would be decent gains (in relative terms) to be had
optimizing the graphql-go and our chunk fetching strategy, but my guess is
that perf won't be in our way. the whole idea here is to fetch relatively
small amounts of data.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/attic-labs/noms/pull/3146, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE6BC6bu2qYKtGt6cOABV7mbkAtpdq1ks5rZrNOgaJpZM4L3ydR
.

Landing patch with comments adressed.
@arv , please TBR last few commits

You also didn't fix the xTyp vs xType variable naming confusion.


ASP .NET MVC Core 2.2 - ViewComponent's Invoke() oddly genarates an InvalidOperationException after upgrading from Core 2.0

Describe the bug
I am develeping an online store where I've got a ViewComponent that is used to render a shopping cart html in the website's navigation bar.
I render the view component in the shared _Layout.cshtml by doing this:
@await Component.InvokeAsync("NavbarShoppingCart")
It used to work fine under MVC Core 2.0 but since I upgraded to 2.2 the same code throws an InvalidOperationException:

InvalidOperationException: Method 'Invoke' of view component 'ProjectName.Web.Views.Shared.NavbarShoppingCartViewComponent ' cannot return a Task.

Here is the ViewComponent class:
public class NavbarShoppingCartViewComponent : ViewComponent
    {
        private readonly IShoppingCartManager shoppingCartManager;

        public NavbarShoppingCartViewComponent(IShoppingCartManager shoppingCartManager)
        {
            this.shoppingCartManager = shoppingCartManager;
        }

        public IViewComponentResult Invoke()
        {
            var shoppingCartId = this.HttpContext.Session.GetShoppingCartId();
            var items = this.shoppingCartManager.GetCartItems(shoppingCartId);

            return View("NavbarShoppingCart", items.Count());
        }
    }

The Invoke() method clearly returns a View, not a Task. I don't get it why this throws an error now.
I have not changed any code, only upgraded the .net core version from 2.0 to 2.2. Any ideas for the source of the problem?
To Reproduce
Steps to reproduce the behavior:

Upgrade from Core 2.0 to 2.2

Additional context
.NET Core SDK (reflecting any global.json):
Version:   2.2.104
Commit:    73f036d4ac
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.17134
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\2.2.104\
Host (useful for support):
Version: 2.2.2
Commit:  a4fd7b2c84

@Slupov could you share an application that reproduces the issue? I'm unable to duplicate it.

Feel free to reopen once you've an repro application to share.


TS-3978: Allow empty document caching to follow normal logic

Hmm..the requirement in the jira certainly seems reasonable, but, the current state of this is mainly to ensure ATS is not caching broken responses (connection failure in the middle of download).
Allowing to cache the empty docs only when Content-Length=0 indirectly ensures that the response was not broken. So, the patch must somehow ensure that the response is not broken, otherwise, there's a danger of caching invalid responses.

Can one of the admins verify this patch?

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

I'm not sure that we're comfortable with this change, since it's been known to cause problems with empty docs in other areas (e.g. clustering). We'll have to take a close look at this, and decide if we should get this in for 7.0.0.
Also, the branch has now diverged, can you please rebase against current master?

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

Can one of the admins verify this patch? Only approve PRs which have been reviewed.

.

I'm going to close this for now, please open a new PR after we discuss this more?


add details

change case of hello in uppercase

i will update

I have update the Hello World in capital , closing the issue


Remove a hack only necessary on our stable branches

Remove a hack from #5715 that made the fix work on databases
created prior to the fix.

Seems like it's still needed?

Yeah, ugh. The hack was not intended to ever be necessary for operating on a freshly created database, but I think I added the second test after I added the hack, so I didn't catch that in the initial PR


[Website] Platform-specific props

We are annotating platform-specific props with a special @platform tag in the docblocks. This pull request adds a little [ios] tag before the name and sorts the props such as generic ones are before platform-specific ones.

Looks awesome, ship it!

:+1: nice


LG 38GL950G has partial range support, highest volume mutes

Checklist

[x] I have searched for existing issues
[x] I have looked through the Monitor Troubleshooting wiki
[x] I have updated MonitorControl to the latest version

Describe the issue
LG 38GL950G connected via USB-C to HDMI adaptor to 2019 Macbook Pro 15" can control volume and brightness, but has several quirks
Volume settings behave incorrectly at both ends of the scale:

OSD shows 5/100 at level 1 brightness on OSX overlay, but goes to 25/100 at level 0 on OSX overlay
Highest volume setting on OSX overlay turns off sound completely I: VCP control #98 (0x62) = current: 255, max: 255

Brightness settings behave incorrectly for much of the scale:

OSD turns off entirely and doesn't show changes made by OSX, just shows / character when brightness set by OSX
OSX overlay brightness levels 0-4 show no change in brightness. I: VCP control #16 (0x10) = current: 60, max: 194 values stick at 60 even when settings change lower than 4.
Highest OSX overlay brightness setting is approximately 50% of the monitors max brightness. I: VCP control #16 (0x10) = current: 194, max: 194

Not sure if these are just quirks of my monitor that can't be fixed, since in some cases the range reports correctly. If so, maybe I can help implement quirks support to handle these?
Expected behavior
Brightness and volume control same full range possible via OSD.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Environment Information (please complete the following information):

macOS version: 10.15.7
MonitorControl version: 2.1.0 Build 721
Monitor(s): LG 38GL950G
Mac model: Macbook Pro 15" Late 2019
Monitor Cable(s)/Connection(s): HDMI via USB-C

Noticed for brightness that setting /ddcctl -d 1 -b 255 does result in a brighter image than full brightness via MonitorControl, which I'm guessing is stopping at the reported 194 max.

It would be great to have an advanced preferences option where DDC min. and max. values could be overridden. I will assign this task to myself, but I don't know when will I be able to actually implement it. :)

Hi, since this is a duplicate of the issue below, I'll close this issue now - please follow developments here:
https://github.com/MonitorControl/MonitorControl/issues/310


Nextcloud backup: allow subdir

Fixes #3988

@fabianfrz do you have time to spin this for a test?

@AdSchellevis crashes immediately:
Fatal error: Uncaught Error: Call to undefined function OPNsense\Backup\basedir() in /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php:147 Stack trace: #0 /usr/local/www/diag_backup.php(286): OPNsense\Backup\Nextcloud->backup() #1 {main} thrown in /usr/local/opnsense/mvc/app/library/OPNsense/Backup/Nextcloud.php on line 147

log after fixing the issue by replacing it by basename(), opnsense/backup as file name:
config[60397]: Error while fetching filelist from Nextcloud
{
  "url":"https:\/\/nextcloud.test\/remote.php\/dav\/files\/opnsensebkp\/Backup",
  "content_type":"text\/html; charset=UTF-8",
  "http_code":404,
  "header_size":1220,
  "request_size":205,
  "filetime":-1,
  "ssl_verify_result":0,
  ...
}

Tested on OPNsense 20.1.r_12 (amd64/LibreSSL) - I don't think somebody changed the nextcloud code inbetween

Hi @fabianfrz thanks for the feedback.
About the last issue, one question: does opnsensebkp directory exist on your Nextcloud? Because indeed the plugin doesn't create all the path to the backup dir, I left the original behaviour that will create just the last one (Backup in your example). Is it expected differently?

I'm sorry for the misspelled function name, I meant to use dirname but accidentally copied the wrong file to git :(

now the php error is gone but the backup still fails.

Does the parent directory exist?

nope, but that is what the code is expected to do, create the full directory hierarchy if missing.

Ok, I will implement that. I asked two comments ago but got not answer...

Sorry I forgot the answer but if you read the source, there is already MKCOL implemented which is doing this so yes, it is the current behaviour.

I've updated the patch and merge against current master, I hope it's fine now

Any chance to get another review?

Hii,

Any chance to get another review?
@fabianfrz could you please review this merge?

Thanks in advance

Tested now successfully:

Tested now successfully:

@maxxer @fabianfrz thanks! I will merge it to master

@maxxer @fabianfrz thanks! I will merge it to master


New version of TinyMCE inserts  HTML elements as linebreaks

Describe the Bug with repro steps
The new version of TinyMCE inserts
HTML elements as linebreaks within post-action content. This causes the XML to become invalid and downstream consumers (e.g. logic apps) to fail.
What type of Logic App Is this happening in?
Consumption (Portal)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
$('#textbox_xml').val()

Screenshots or Videos

Browser
Chrome Version 128.0.6613.138 (Official Build) (64-bit)
Additional context
No response

Hi @adamhutcheon, thanks for reporting this issue, which action are you using? We do plan to do a mini rewrite for our WYSIWYG editor in a few weeks, so I'd like to collect any user's input on this


optimize: tri protocol prompt

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Could you give a brief explain?

Could you give a brief explain?

I don't think it is appropriate for me to do this
ConfigManager uniqueConfigTypes Is it more appropriate to add tri's ApplicationConfig by default, so that more users can easily upgrade to tri protocol

Could you give a brief explain?

I don't think it is appropriate for me to do this
ConfigManager uniqueConfigTypes Is it more appropriate to add tri's ApplicationConfig by default, so that more users can easily upgrade to tri protocol

Aggreed that is better to upgrade from dubbo2 to triple senselessly, but protocol config is important and should not be set by framework automatically.

Aggreed that is better to upgrade from dubbo2 to triple senselessly, but protocol config is important and should not be set by framework automatically.

Got it, thank you


Feature/rework filters init

Short description and why it's useful
Reworked filters to init by module
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

@filrak Can You please review this mechanism?

Closed because it doesn't comply to our current architecture


bug:  kcp bind compute does not work as expected for locations on a different workspace

Describe the bug
I created a new workspace inventory under the home workspace (e.g. kvdk2spgmbix), and generate a syncer yaml from there and deploy the syncer on a pCluster.  At this point I check the path for the workspace where my location is:
$ kubectl ws .
Current workspace is "kvdk2spgmbix:inventory".

Then, I create a new workspace under the home workspace, for example ws1 and enter there:
kubectl ws
kubectl ws create ws1 --enter

Finally, I try to bind to the workspace containing the location:
kubectl kcp bind compute kvdk2spgmbix:inventory

But I get this error:
Binding APIExport "root:compute:kubernetes".
placement placement-1syj10fy created.
error: placement "placement-1syj10fy" not ready: placement is not scheduled: No selected location is scheduled

I found that in order to make this work, I have to use the cluster name, not the name in the form kvdk2spgmbix:inventory.
So I had to look up the cluster name in the yaml of the inventory workspace - e.g.
$ kubectl ws
$ kubectl get workspace inventory -o yaml | grep " cluster:"
cluster: 36jjanpr01gl8d45

then I can bind with this cluster name and placement becomes healthy:
$ kubectl kcp bind compute 36jjanpr01gl8d45
Binding APIExport "root:compute:kubernetes".
placement placement-i152ylce created.
Placement "placement-i152ylce" is ready.

Steps To Reproduce

create fresh kind cluster

kind delete cluster --name control && kind create cluster --name control

fetch & merge latest main, run build

make build
export PATH=$(pwd)/bin:$PATH

Build locally the syncer image

brew install ko
ko build --local --push=false -B ./cmd/syncer -t $(git rev-parse --short HEAD)

(add --platform linux/amd64,linux/arm64 if building on a MBP M1)
4. Load image on kind
kind load docker-image ko.local/syncer:$(git rev-parse --short HEAD) --name control

Cleanup previous kcp state (if any) &  start kcp

rm -rf .kcp
kcp start

Open another terminal, and enter:

export KUBECONFIG=$(pwd)/.kcp/admin.kubeconfig
kubectl ws
kubectl ws create inventory --enter
kubectl kcp workload sync control --syncer-image ko.local/syncer:$(git rev-parse --short HEAD) -o ${HOME}/syncer-control.yaml

start the syncer

$ KUBECONFIG=</path/to/kind/kubeconfig> kubectl apply -f  ${HOME}/syncer-control.yaml

check the path for the workspace where my location is:

$ kubectl ws .
Current workspace is "kvdk2spgmbix:inventory".

create a new workspace under the home workspace, for example ws1 and enter there:

kubectl ws
kubectl ws create ws1 --enter

bind to the workspace containing the location:

kubectl kcp bind compute kvdk2spgmbix:inventory

Verify error:

Binding APIExport "root:compute:kubernetes".
placement placement-1syj10fy created.
error: placement "placement-1syj10fy" not ready: placement is not scheduled: No selected location is scheduled

Expected Behaviour
I would expect to be able to use the workspace path+name I can get when inside that workspace with kubectl ws . when running the kcp bind compute command instead of the cluster name (that requires me to look inside the yaml of a workspace).
Additional Context
No response

FYI, I managed to reproduce it.

@qiujian16 @sttts Any idea ?

I also hit the same issue with main branch, referred to the steps from https://github.com/kcp-dev/kcp,
$ k kcp --version
kcp version v1.24.3+kcp-v0.10.0-683-gca871c150f440b

$ k get ws ws1 -oyaml
apiVersion: tenancy.kcp.io/v1alpha1
kind: Workspace
metadata:
  annotations:
    experimental.tenancy.kcp.io/owner: '{"username":"kcp-admin"}'
    internal.tenancy.kcp.io/cluster: 1c5c5cykgh93ho8v
    internal.tenancy.kcp.io/shard: 1pfxsevk
    kcp.io/cluster: kvdk2spgmbix
  creationTimestamp: "2023-02-03T11:24:32Z"
  finalizers:
  - core.kcp.io/logicalcluster
  generation: 2
  labels:
    tenancy.kcp.io/phase: Ready
  name: ws1
  resourceVersion: "835"
  uid: 195ca3ba-efec-47b4-8761-55e9241551db
spec:
  URL: https://<IP_ADDRESS>:6443/clusters/1c5c5cykgh93ho8v
  cluster: 1c5c5cykgh93ho8v
  type:
    name: universal
    path: root
...

$ kubectl kcp bind compute 1c5c5cykgh93ho8v
placement placement-2i0nt46r created.
error: placement "placement-2i0nt46r" not ready: placement is not scheduled: No selected location is scheduled

$ oc get placement placement-2i0nt46r -o yaml
apiVersion: scheduling.kcp.io/v1alpha1
kind: Placement
metadata:
  annotations:
    kcp.io/cluster: kvdk2spgmbix
  creationTimestamp: "2023-02-03T11:26:39Z"
  generation: 1
  name: placement-2i0nt46r
  resourceVersion: "860"
  uid: b8cfccfa-d21d-412b-aca8-d604407281f5
spec:
  locationResource:
    group: workload.kcp.io
    resource: synctargets
    version: v1alpha1
  locationSelectors:
  - {}
  locationWorkspace: 1c5c5cykgh93ho8v
  namespaceSelector: {}
status:
  conditions:
  - lastTransitionTime: "2023-02-03T11:26:39Z"
    message: No valid location is found
    reason: LocationNoMatch
    severity: Error
    status: "False"
    type: Ready
  - lastTransitionTime: "2023-02-03T11:26:39Z"
    message: No selected location is scheduled
    reason: ScheduleLocationNotFound
    severity: Warning
    status: "False"
    type: Scheduled
  phase: Pending

need to confirm with this issue. When we run bind, I think we can use either cluster name 36jjanpr01gl8d45 or a logical cluster name e.g. root:inventory, I do not think we can use a mixed path. Is this the case?

I don't think we need "mixed". From a UX perspective logical cluster name (e.g. root:inventory)  it is way simpler to use, and it is what users normally interact with when for example creating a new workspace. There are additional steps required for a user to find what the cluster name is.

I see, thanks. I think the root cause is still that location update (when synctarget is added into the location) does not trigger the placement, which should be fixed with linked PR.

@qiujian16 I have tested with the latest that includes the fix and I still see the issue. I have followed the steps in "Steps To Reproduce" and I still get the same issue:
git log
commit 90f961b33b4416d5f2a85e21e882a1bf47103b5e (HEAD -> main, upstream/main)
Merge: 9640af10 f9ce14dd
Author: OpenShift Merge Robot<EMAIL_ADDRESS>Date:   Tue Feb 21 16:50:09 2023 +0100

then I run make build and follow steps in "Steps To Reproduce" . Then I verify I am running the correct build:
kubectl version
....
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.3+kcp-v0.11.0-alpha.1-85-g90f961b33b4416", GitCommit:"90f961b3", GitTreeState:"clean", BuildDate:"2023-02-21T16:21:55Z", GoVersion:"go1.19.2", Compiler:"gc", Platform:"darwin/arm64"}

I still get:
$ kubectl kcp bind compute kvdk2spgmbix:inventory
Binding APIExport "root:compute:kubernetes".
placement placement-1syj10fy created.
error: placement "placement-1syj10fy" not ready: placement is not scheduled: No selected location is scheduled

/milestone clear

After a discussion on Slack we found the root issue is that kubectl ws . displays the current workspace when working with workspaces created starting from the home workspace. This is currently being addressed by #2830

I tested #2830 and verified that it resolves this issue.


PLANNER-741: Workbench: Display warning message when score type is changed in a Planning Solution and scoreHolder is referenced

Add DeleteValidator
Add Imports to data objects

Part of:

https://github.com/droolsjbpm/kie-wb-common/pull/693
https://github.com/droolsjbpm/optaplanner-wb/pull/135

Imports are used in the optaplanner-wb PR, as type parameter in superclass definition of a data object sometimes uses only simple class name (fqn is necessary). This way the fqn can be derived using ClassTypeResolver, which accepts a collection of import strings.
I also noticed renamedClasses and deletedClasses of UpdateInfo are not used, perhaps it's a good time to get rid of the class completely?
@wmedvede As this affects the data modeller, would you mind having a look? Thank you in advance.

There is HasImports and Import in drools/drools-workbench-models IIRC. I'll review better tomorrow when at PC.. I also think Paulo has written "delete validator" type interfaces and service already (also for renaming). I'll need to find them...

https://github.com/droolsjbpm/drools/tree/master/drools-workbench-models/drools-workbench-models-datamodel-api/src/main/java/org/drools/workbench/models/datamodel/imports

https://github.com/uberfire/uberfire/blob/master/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-api/src/main/java/org/uberfire/ext/editor/commons/service/restrictor/DeleteRestrictor.java

I'll review when refactored then

OK, lets me pragmatic about this.. there are plenty of Command interfaces kicking around (even in KIE land) and we don't to force use of a single one (I'm sure there are plenty more examples of identical interfaces kicking around in other packages, libraries etc). So.. let's agree we can live with the duplication.
As for DeleteValidator @mcimbora version returns messages as to why a deletion cannot occur; whereas @paulovmr version just prevents it from happening with no feedback. Perhaps we could agree to simply raise a JIRA suggesting DeleteValidator and DeleteRestriction (plus the other similar interfaces for copy and rename) can one day be combined; and @paulovmr implementation simply vetos the operation if the messages collection is not empty... then we can all be happy and move on :-)

Jenkins please retest this.

@manstis Right, the behavior is a little bit different, as you explained. The restrictions are "hard constraints", whereas the validation should be seen as a "soft constraint", i.e. user should be still permitted to perform the action if they know what they're doing.  I'm happy to refactor & move the whole "validation UI" (incl. validation popup) to uberfire, will create issue for this.

Jenkins please retest this.

Hello @manstis @mcimbora no more comments from my side.
Thanks


Task: #39: PA Facet Issue

With this PR I want to:

fix facets to let show only the PA with associated layer
Fix Ui to show the counters and highlight the PA selected:

Counters:

When selected:

@etj the facet should be visible for all resources (Layer, Maps, Documents) or only for the Layers?


Fixing ui changes

Rebased on a different repo and reopened as https://github.com/project-chip/zap/pull/444


failed in processing atkey zip file Error in the onboarding widget version 2.0.0

Describe the bug
When I try to pick my atkey zip file from my android phone it gives me the error in the wavi app. I also faced the same error when I used onboarding widget 2.0.0 in  demo apps
To Reproduce
Steps to reproduce the behavior:

First I '...'

Then I '...'

And then '...'

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Smartphone (please complete the following information):

Device: [e.g. iPhone11]
OS: [e.g. iOS14.1]
Browser [e.g. stock browser, safari]
Version [e.g. 59]

Were you using an @application when the bug was found?
Additional context
Add any other context about the problem here.

[e.g. @buzz, @tmosphere]

Please stop mentioning me in this repo. Thank you

[e.g. @buzz, @tmosphere]

Please stop mentioning me in this repo. Thank you

Hi @Intiserahmed I'm going to send you a video showing you how to put a space separator between @ and buzz.

@ksanty Please stop mentioning my username in this repository. Thank you very much

Same issue:
I/flutter ( 8361): SEVERE|2021-07-06 14:16:04.419833|QR Scan|Uploading backup zip file throws type 'Future<FilePickerResult?>' is not a subtype of type 'FutureOr<FilePickerResult>' in type cast

It appears to start at /lib/screens/pair_atsign.dart line 272-274
FilePickerResult result = await (FilePicker.platform.pickFiles(
    type: FileType.any,
    allowMultiple: true) as FutureOr<FilePickerResult>);

Removing the typecast and changing result's type to FilePickerResult? allows the project to build, however I'm still unable to onboard. I get sent back to the upload screen.

Both ".zip" and ".atKeys" extension files seem to be working fine with at_onboarding_flutter v2.1.0
@Intiserahmed Can you please check with this version?

@sarika01 checked giving the future file picker error as @XavierChanth mentioned.

Could it be from the flutter sdk version I'm using?
#/example/pubspec.yaml
environment:
  sdk: ">=2.7.0 <3.0.0"

I suppose that my issues come from using sdk 2.12 in pubspec.yaml:
#/my_app/pubspec.yaml
environment:
  sdk: ">=2.12.0 <3.0.0"

@XavierChanth 2.12 is for null safety... I'm afraid 2.7 doesn't support null safety.

I'm using 2.12, example is using 2.7, I get major issues when trying to use 2.7, since all the code is written to use null safety in the app.

Both ".zip" and ".atKeys" extension files seem to be working fine with at_onboarding_flutter v2.1.0
@Intiserahmed Can you please check with this version?

@Intiserahmed does the issue exist with at_onboarding_flutter v2.1.0?

@murali-shris Yeap It's working like a charm

Closing this on your behalf @Intiserahmed


Update aws-java-sdk-core to 1.12.550

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.12.550
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #617.


Add source verb information to go SDK Call

We'll need this for tracking metrics as they flow through the system.

Fixed in #62


Swiper doesn't work properly unless called after DOM node is attached

I tried to dynamically create a Swiper slideshow using elements created by document.createElement. Some aspects of Swiper worked (such as scrolling) while others did not (such as snapping). These issues were resolved when I used new Swiper after attaching the elements to the DOM instead of before.
I think this behavior is reasonable, but Swiper should issue a warning or error if called on an unattached DOM node, and it should be noted in the documentation.

You should expect that something what is heavily rely on styles/sizes and visuals in general may not work correctly when it is detached from DOM. There is no errors and warnings because Swiper actually works in this case, just call swiper.update(true) after you add it to DOM

@nolimits4web Thanks! Didn't realize swiper.update(true) would fix it.


Backport "HBASE-28687 BackupSystemTable#checkSystemTable should ensure system tables are enabled (#6018)" to branch-2.6

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
4m 17s

branch-2.6 passed

+1 :green_heart:
compile
0m 41s

branch-2.6 passed

+1 :green_heart:
checkstyle
0m 13s

branch-2.6 passed

+1 :green_heart:
spotbugs
0m 41s

branch-2.6 passed

+1 :green_heart:
spotless
0m 53s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
spotbugs
0m 57s

the patch passed

+1 :green_heart:
hadoopcheck
11m 50s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.

+1 :green_heart:
spotless
1m  0s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

28m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6030

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux ba95c44d551a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / a2f7ebc5a53000b074d282baa9d040d179d9f957

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
2m 33s

branch-2.6 passed

+1 :green_heart:
compile
0m 17s

branch-2.6 passed

+1 :green_heart:
javadoc
0m 15s

branch-2.6 passed

+1 :green_heart:
shadedjars
4m 46s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 23s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
javadoc
0m 14s

the patch passed

+1 :green_heart:
shadedjars
4m 47s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
11m 43s

hbase-backup in the patch passed.

29m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6030

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux bd896ecc60ee 5.4.0-177-generic #197-Ubuntu SMP Thu Mar 28 22:45:47 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / a2f7ebc5a53000b074d282baa9d040d179d9f957

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/1/testReport/

Max. process+thread count
2767 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
2m 51s

branch-2.6 passed

+1 :green_heart:
compile
0m 16s

branch-2.6 passed

+1 :green_heart:
javadoc
0m 15s

branch-2.6 passed

+1 :green_heart:
shadedjars
6m  8s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

the patch passed

+1 :green_heart:
compile
0m 17s

the patch passed

+1 :green_heart:
javac
0m 17s

the patch passed

+1 :green_heart:
javadoc
0m 14s

the patch passed

+1 :green_heart:
shadedjars
4m 48s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
10m 37s

hbase-backup in the patch passed.

29m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6030

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 56f422e507f3 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / a2f7ebc5a53000b074d282baa9d040d179d9f957

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/testReport/

Max. process+thread count
3490 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  4s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
3m 30s

branch-2.6 passed

+1 :green_heart:
compile
0m 17s

branch-2.6 passed

+1 :green_heart:
javadoc
0m 14s

branch-2.6 passed

+1 :green_heart:
shadedjars
6m  8s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  3s

the patch passed

+1 :green_heart:
compile
0m 18s

the patch passed

+1 :green_heart:
javac
0m 18s

the patch passed

+1 :green_heart:
javadoc
0m 13s

the patch passed

+1 :green_heart:
shadedjars
6m  8s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
11m 28s

hbase-backup in the patch passed.

33m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6030

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 198fd545bb1d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / a2f7ebc5a53000b074d282baa9d040d179d9f957

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/testReport/

Max. process+thread count
3836 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 24s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2.6 Compile Tests _

+1 :green_heart:
mvninstall
4m 12s

branch-2.6 passed

+1 :green_heart:
compile
0m 24s

branch-2.6 passed

+1 :green_heart:
javadoc
0m 17s

branch-2.6 passed

+1 :green_heart:
shadedjars
8m 10s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed

+1 :green_heart:
javac
0m 23s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed

+1 :green_heart:
shadedjars
7m  1s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
12m 26s

hbase-backup in the patch passed.

38m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6030

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 6c041c121d04 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.6 / a2f7ebc5a53000b074d282baa9d040d179d9f957

Default Java
Eclipse Adoptium-17.0.10+7

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/testReport/

Max. process+thread count
3178 (vs. ulimit of 30000)

modules
C: hbase-backup U: hbase-backup

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6030/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


[Event Request] Table 36 - Sales Header - OnBeforeLookupAppliesToDocNo

Hi AL-Team,
can you please add the following Publisher to Applies-to Doc. No. OnLookup?
trigger OnLookup()
            var
                GenJnlLine: Record "Gen. Journal Line";
                GenJnlApply: Codeunit "Gen. Jnl.-Apply";
                ApplyCustEntries: Page "Apply Customer Entries";
                Handled: Boolean;
            begin
                // NEW >>>>
                OnBeforeLookupAppliesToDocNo(Rec, CustLedgEntry, ApplyCustEntries, Handled);
                if Handled then
                    exit;
                // NEW <<<<
                TestField("Bal. Account No.", '');
                CustLedgEntry.SetApplyToFilters("Bill-to Customer No.", "Applies-to Doc. Type", "Applies-to Doc. No.", Amount);

    [IntegrationEvent(false, false)]
    local procedure OnBeforeLookupAppliesToDocNo(var Rec: Record "Sales Header"; var CustLedgerEntry: Record "Cust. Ledger Entry"; var ApplyCustEntries: Page "Apply Customer Entries"; var Handled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Connect to Indico API

Connection established with Indico API
Style correction and tests are still needed, so a new commit is expected around next week

@fanimator12 thanks for the PR, I will add this functionality to harvest https://github.com/cern-sis/cern-academic-training/blob/master/harvest/harvest/pipelines.py#L13

I create another branch for a new PR. Please use https://github.com/cern-sis/cern-academic-training/pull/22 instead.


refine detail about what "old behavior" of as is.

refine detail about what "old behavior" of as is.

Looks good to me!

Seems that this doesn't cover the case when integer is casted to float.

cc https://github.com/rust-lang/rust/issues/10185

I think it was left implicit in the RFC text that when it spoke on the semantics of as, it was referring solely to the semantics of as with respect to int-type -> int-type conversions.  It does not address using as to-or-from references, nor floats, nor unsafe pointers, etc.
I don't think this RFC text would be the right place to try to document the full semantics of as.   The detail here was solely about int-type -> int-type casts, and that was just because the RFC as originally accepted had mandated that as would start dynamically checking the behavior of as, which was then rejected based on discussion here: http://internals.rust-lang.org/t/on-casts-and-checked-overflow/1710/


Require(...) is not a function

When (as documented) running ./node_modules/.bin/snippet-enricher-cli --input=.... there is an error:
require('./../index.js')();                         ^ TypeError: require(...) is not a function
Removing the () from the require fixed this issue.

@RolphH can you please open a PR for this?

I have the same problem, to solve it i tried to use any of the older versions (0.3 - 0.5) and it didn't work.
I guess has something to do with my node version v14.3.0 but i am not really sure.
I solved it with a script in my project repo, containing the following code, to solve the problem without modifying the code in node_modules
#!/usr/bin/env node
require('../node_modules/snippet-enricher-cli/index');


Master -> Live #1760

Docs Build status updates of commit 26676a6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-looking-through-holes-in-your-reality.md
:white_check_mark:Succeeded
View

mixed-reality-docs/design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-host.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-player.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-custom-data-channels.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-secure-connection.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-troubleshooting.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-version-history.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-sharing(photon)-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/news.md
:white_check_mark:Succeeded
View

mixed-reality-docs/sf-academy-events.md
:white_check_mark:Succeeded
View

mixed-reality-docs/unity-development-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 26676a6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-looking-through-holes-in-your-reality.md
:white_check_mark:Succeeded
View

mixed-reality-docs/design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-host.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-player.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-custom-data-channels.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-player.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-secure-connection.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-troubleshooting.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-version-history.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-sharing(photon)-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/news.md
:white_check_mark:Succeeded
View

mixed-reality-docs/sf-academy-events.md
:white_check_mark:Succeeded
View

mixed-reality-docs/unity-development-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 5e21099:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/case-study-looking-through-holes-in-your-reality.md
:white_check_mark:Succeeded
View

mixed-reality-docs/design.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-host.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-create-player.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-custom-data-channels.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-player.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-secure-connection.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-troubleshooting.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holographic-remoting-version-history.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-sharing(photon)-ch5.md
:white_check_mark:Succeeded
View

mixed-reality-docs/mrlearning-speechSDK-ch2.md
:white_check_mark:Succeeded
View

mixed-reality-docs/news.md
:white_check_mark:Succeeded
View

mixed-reality-docs/sf-academy-events.md
:white_check_mark:Succeeded
View

mixed-reality-docs/unity-development-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to use custom wmts as basemap ?

How to use custom wmts as basemap ?

How to use custom wmts as basemap ?

WMTS is one of the OGC services which we don't natively support. You could try loading the layer with REST API.
You can submit sample issues or creating a sample PR here. If you have general plugin questions, they'll get quicker response in our unreal user forum


'random' POI selected when clicking on background map layer

Don't really know how to call this; but what seems to happen:

Have a POI layer active (an OSM one in the screenshot). Background layer doesn't seem to matter; both online and mbtiles behave the same
Click somewhere on the background
A little blue square appear where clicked - with the tagging corresponding to a 'selected' POI somewhere offscreen

I'm putting random in quotes because there does seem to be some logic to it. I can't discover what logic that would be though. It's definitely not the closest one, can be miles away. But it is often the same one

Could you send me a link to the exact OSM dataset you have loaded here? I'd like to reproduce this.

Hi Nick, I get this with any dataset we've tried; different base layer, different POI data, even no POI data present at all but a couple of forms/points already surveyed. But for example, try https://drive.google.com/open?id=0Bx3_hrMYdNwLY3VGaXZrOVRwUDQ

Occurs with the same data as #121: one form, no osm data, one mbtiles for background.
Form: https://drive.google.com/open?id=0Bx3_hrMYdNwLUV9RZXF6U0pKb1U
Mbtiles: https://drive.google.com/open?id=0Bx3_hrMYdNwLN0taTUJUbXZWdTg

Start a new form, just click on the background layer. The blue box will appear.
Add one POI ('+', '+ add node'). Immediately add another one ('+', '+ add node')
Close the tags window (down arrow next to 'Tags')
Click on the background map somewhere. Blue box, one of the POIs will be selected.

With two, which one gets selected still seems somewhat logical. However, that quickly diminishes when you get more (like the screenshot above).

@hallahan , any news on this one? It's biting us quite a lot.

I'll take a look. This is a map renderer issue, and we will be replacing the legacy renderer, most likely soon.
This may be a quick fix, however.

Note to self - this would require some sort of buffer around POIs with an intersection check. If this is high priority, pinpoint where that buffer would be put in and figure out LOE (probably higher than we'd like).


Extension Management API implementation

PR Summary
This is a basic Extension Management API implementation
PR Checklist

[x] Write Help
[X] Write Unit Test
[X] Update VSTeam.psd1
[ ] Update CHANGELOG.md

I have a concern regarding the API response. I see on other API already implemented that types are defined, and that the types are applied to the responses. How are defined those types ?

The types are created by just reviewing the repsonses from the API.  The files are then added and the types applied.  If these types are are going to be used in the provider you can skip the type files and just created classes.  The classes are then used in the provider.

I am making all the suggested changes.  Let me know if you see anything wrong with my suggestions.


Update train.py

I modified two points, the one is that prints loss before optimization because to print loss after optimization and to re-calculate loss needs overhead, another one is changed the way to index value in variables(variables.item() instead of [0]), error occurs when I run train.py before modification.

Thank you for sharing great works!
What do you think of this pr?


Path configuration is not supported

hardhat-zksync-solc is compiled according to ./contracts by default, and does not support path configuration

Please note that the folder is named "contracts", it cannot be "contract", otherwise zksync-solc cannot find the contract file

hardhat-zksync-solc also has a lot of incompatibilities with hardhat, which means there is a lot of work to be done, please let me know if you need help

Hi @hedgezhu thanks for the feedback!
The plugin works fine with non-default paths for me, could you please confirm you have the latest version, re-check and then send us some more info about your setup? A gist link to a minimal reproducible example will also be appreciated.

hardhat-zksync-solc also has a lot of incompatibilities with hardhat

Please let us know what other features we're lacking. Feel free to submit a pull request as well.

could you please confirm you have the latest version, re-check and then send us some more info about your setup?

Here is my package.json, I think this is the latest version
    "@matterlabs/hardhat-zksync-deploy": "^0.1.5",
    "@matterlabs/hardhat-zksync-solc": "^0.3.0",
    "hardhat": "^2.9.3",
    "zksync-web3": "^0.4.0"

Please let us know what other features we're lacking. Feel free to submit a pull request as well.

I'm looking the source code of hardhat-zksync-solc/depoloy, If I find something I can help, I'll submit a PR. Also I'm excited about zksync v2 and looking forward to reading your zkEVM source code


Add unit tests

This PR along has way more lines of codes than the entire code base:

I do not feel like necessary to mock such amount of data to mimic 1:1 SCE response. If logic works for 2-3 entries, it must work for a response containing 10k entries as well. Therefore, I implemented most of test within 655b928 using a lightweight approach.
JSONStorage#save() testing is still missing tho but I'll keep working on it soon.
Untill them, let's keep this PR open as it is still useful to check and compare possible solutions for missing tests.
Thanks for your colaboration!

Finally, fully covered by commits 655b928 and 69c1931.
Kindly check memfs module usage during JSONStorage.js testing to generate an in-memory filesystem.