Added support for new Dropbox short lived tokens through Refresh Tokens

Added suuport for Dropbox Short Lived Tokens as described in this article
https://dropbox.tech/developers/migrating-app-permissions-and-access-tokens

DropboxAuthHelper has a new method called setAccessTokenType where you can choose access token DropboxAuthHelper::TOKEN_ACCESS_TYPE_OFFLINE (default) or DropboxAuthHelper::TOKEN_ACCESS_TYPE_OFFLINE.

When access token type is set to OFFLINE, calling getAuthUrl will request access token for offline use.

When AuthHelper method getAccessToken is called, two new fields are returned in AccessToken object: $refreshToken and $tokenExpiresIn

DropboxAuthHelper method getAccessToken has a new parameter grantType which receive either a DropboxAuthHelper::GRANT_TYPE_AUTHORIZATION_CODE (default for regular tokens) or DropboxAuthHelper::GRANT_TYPE_REFRESH_TOKEN (for tokens based on refresh token).

If grant type is GRANT_TYPE_REFRESH_TOKEN and valid refresh token given in code parameter, the result is an newly and valid token that can be used.

Examples:
Getting auth URL with access token for OFFLINE use
        $authHelper = $dropboxClient->getAuthHelper();
        $authHelper->setAccessTokenType(Dropbox\Authentication\DropboxAuthHelper::TOKEN_ACCESS_TYPE_OFFLINE);
        echo $authHelper->getAuthUrl();

After that, getting access token is performed regularly:
        $authHelper = $dropboxClient->getAuthHelper();

        var_dump($authHelper->getAccessToken($key));

The result AccessToken object will contain $refreshToken and $tokenExpiresIn properties.
Getting a new token based on refresh token:
    /**
     * @param string $refreshToken   The refresh token received by AuthHelper->getAccessToken
     * @return Dropbox\Models\AccessToken
     */
    public function refreshAccessToken($refreshToken) {
        $authHelper = $dropboxClient->getAuthHelper();

        return $authHelper->getAccessToken($refreshToken, null, null, Dropbox\Authentication\DropboxAuthHelper::GRANT_TYPE_REFRESH_TOKEN);
    }

The result AccessToken object will include $token property with a newly access token to be used.

Thanks for you email.
Sorry but I am not available until Monday 28th June.
For any hosting support issues please submit a ticket via https://my.slightlydifferent.co.nz/submitticket.php or to @.***
For all other matters please raise a ticket only if urgent. Otherwise I will get back to you as soon as possible on my return.
Kind regards
Steve

Hi
Dropbox will only support refresh_tokens from September 2021,
Its required to integrate either this or any other update to the SDK to prevent it from stop working.

Thanks de5car7es your additions worked for me ;-)

To use this version, you can add to this to Composer.json:
"require": {
    "kunalvarma05/dropbox-php-sdk": "dev-refresh_tokens_support",
}

@de5car7es

Thank you.
For others who want to use it using Composer, just update this line in the Composer.json :
"require": {
    "kunalvarma05/dropbox-php-sdk": "dev-refresh_tokens_support",
}

It does not work for me 😕
Composer Output;
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires kunalvarma05/dropbox-php-sdk dev-refresh_tokens_support, found kunalvarma05/dropbox-php-sdk[dev-master, dev-develop, v0.1.0, ..., v0.2.1] but it does not match the constraint.

@de5car7es thanks for this. Can you please fix the conflicts and the style issues?

I'm sorry, I got lost trying to implement this branch. Thank you for implementing the new auth method, but I would need a more clear guide on how to implement it.
Once invoking the $app = new DropboxApp("client_id", "client_secret", "access_token", "refresh_token");
How to check when the "refresh_token" is expired and then regenerate it? Or it is not needed, it is automatically performed by the library?

Thanks for you email.
We are shutdown for Christmas from Friday 17th December until Monday 10th January.
For urgent only issues please raise a ticket at https://my.slightlydifferent.co.nz/submitticket.php. Otherwise I will get back to you as soon as possible on my return.
Have a great Christmas and New Year!
Kind regards
Steve

Is there any updates on generating new tokens server side (without needing to click links etc) - had all the code working with the temporary token, only to realise they expire. I got tokens generating using the example _callback.php code - but don't need/want users doing this, as the file copy would be server side only.

You can use the update I committed, it works flawlessly on our servers, automatically requesting new tokens once old one expires.
We update the new tokens in the database when they expired and it works perfectly.

You can use the update I committed, it works flawlessly on our servers, automatically requesting new tokens once old one expires. We update the new tokens in the database when they expired and it works perfectly.

Any chance of some very simple example from connection to file upload, as I have everything working if using the self generated token, but running: $authHelper->getAccessToken($key)) I get:
400 Bad Request` response: {"error": "invalid_grant", "error_description": "code doesn't exist or has expired"
I presume $key is the 'App Key'

You can use the update I committed, it works flawlessly on our servers, automatically requesting new tokens once old one expires. We update the new tokens in the database when they expired and it works perfectly.

Any chance of some very simple example from connection to file upload, as I have everything working if using the self generated token, but running: $authHelper->getAccessToken($key)) I get:
400 Bad Request` response: {"error": "invalid_grant", "error_description": "code doesn't exist or has expired"
I presume $key is the 'App Key'

Could it be that you are mixing between the tokens ?
I think your questions is more general about using the Dropbox API, let me try to provide an answer with elements related to refresh tokens.
If you start everything from scratch, the steps are as follow:

Get auth URL for the initial authentication. Something like:
// Replace DropboxConfig::DROPBOX_APP_KEY_SECRET
$dboxCredentials = json_decode(DropboxConfig::DROPBOX_APP_KEY_SECRET);
 $dropboxApp = new \Kunnu\Dropbox\DropboxApp($dboxCredentials->key, $dboxCredentials->secret);
 $dropboxClient = new Kunnu\Dropbox\Dropbox($dropboxApp);

 //Fetch the Authorization/Login URL
 $authHelper = $dropboxClient->getAuthHelper();
 $authHelper->setAccessTokenType(\Kunnu\Dropbox\Authentication\DropboxAuthHelper::TOKEN_ACCESS_TYPE_OFFLINE);
 $authUrl = $authHelper->getAuthUrl();

Browse the auth URL, login and get the code
Please note, the code is not an access token.

Use the code to get the first valid access token. Something like:
$authHelper = $dropboxClient->getAuthHelper();
$authHelper->setAccessTokenType(\Kunnu\Dropbox\Authentication\DropboxAuthHelper::TOKEN_ACCESS_TYPE_OFFLINE);
$accessToken = $authHelper->getAccessToken($key);

Now you received an access token valid for 4 hours. Store these values:
$selectedAccountKey = $accessToken->getToken();
$refreshToken = $accessToken->getRefreshToken();
$tokenExpiresIn = $accessToken->getExpiresIn();

When its time to refresh the token, refresh it like this:
         $authHelper = $dropboxClient->getAuthHelper();
         $accessToken = $authHelper->getAccessToken($refreshToken, null, null, \Kunnu\Dropbox\Authentication\DropboxAuthHelper::GRANT_TYPE_REFRESH_TOKEN);

Please note that the $refreshToken value is the one you received in step 5.

Thanks for the update,
So it appears for background dropbox actions (hourly dropping of files for example on the server) if running as a schedule task - I'm unable to do so without some user interaction to obtain a valid token by visiting the URL?

You need user interaction only for a single time, to obtain the initial
code.
Afterwards you use the code to obtain a valid token+a refresh token.
You use the valid token for 4 hours and before it expires, use the refresh
token to get a new one.
On Thu, Apr 7, 2022, 12:34 richardwait @.***> wrote:

Thanks for the update,
So it appears for background dropbox actions (hourly dropping of files for
example on the server) if running as a schedule task - I'm unable to do so
without some user interaction to obtain a valid token by visiting the URL?
—
Reply to this email directly, view it on GitHub
https://github.com/kunalvarma05/dropbox-php-sdk/pull/184#issuecomment-1091428482,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG4A2YNYP362ZK5QLVXKQULVD2TZ3ANCNFSM4675VBTA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey :wave:,
thanks for your work :heart:. We use this in https://github.com/owncloud/files_external_dropbox . Can we help somehow to get this merged and released? @vishalmarakana

This code is working on our production system as well for months now. Its fully stable.
I dont have access to perform the merge and I think its a shame that it doesnt get merged.

Support for short lived tokens through Refresh Tokens was added here: #196


Assign T&R as owners for tests/

Right now this falls back to the top level owners which is probably not the correct choice
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test integ-pilot-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test integ-pilot-local-tests

e2e-simpleTestsMinProfile_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test integ-pilot-local-tests

e2e-simpleTestsMinProfile_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test e2e-simpleTestsMinProfile

integ-security-k8s-tests_istio
df52eadd4653af59029ec36a8cd74a5c262ca383
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Update command word

LGTM! Mark commands are now clearer and are standardized with the other class management commands such as those for recording class participation and setting assignment grades.


How to add new media item?

how to add new media item to jsqmessages

checkout this
https://github.com/relatedcode/EncryptedChat

Hey @KhaledAld :smile:
The best way to learn this is to look at the provided media items and follow that pattern, for example JSQPhotoMediaItem. The demo project is also a good reference.

@jessesquires
Ok Thx ^_^


Drum Icons

Icon Request

Icon name: Kick Drum, Snare Drum, Open Hi-Hat, Closed Hi-Hat
Tags of this icon: music, daw, sequencer, drum
Use case: Music Software like DAWs, sequencers, drum machines

I will hold this request first, mainly because RemixIcon is not very suitable for such a complex scenario.


Feedback for Samsung page

Just FYI, on my device galaxy M51, just updated to 11, it kind works opposite from what's written on the page: if I disable all battery optimization and all battery saving features from the device care section, apps will still get killed (segmentation warnings from accubattery and inability to change tracks from smartband due to app getting killed).
However, if I enable optimization for all apps and add the specific apps I need to the "never sleep" section in the device battery care, everything works fine, and battery also lasts much longer.

Hello @Patryz big thanks for the udpate. We are still investigating this and at the moment it is not clear what is Samsung intended behavior and what may be bugs in Samsung Android 11 implementation.. We are keen on any feedback on this.. please also see https://github.com/urbandroid-team/dont-kill-my-app/issues/307#issuecomment-827649020

I really don't understand why Samsung is #1.  Samsung is exactly the oposite. Yes. It kill the apps, but it notify user that it happen and user had possibility to react and whitelist every app.

I really don't understand why Samsung is #1. Samsung is exactly the oposite. Yes. It kill the apps, but it notify user that it happen and user had possibility to react and whitelist every app.

How can I do it?

Hello @tprochazka, many thanks for your feedback. The score for Samsung is based on several observations:

After the Pie update the number of background processing issues reported skyrocketed for Samsung. Before most problems were reported from 1+, Huawei, Xiaomi etc.. But now it is Samsung, I know they have the biggest market share, but we simply do not have the data to abstract from that. And the fact is that most issues nowadays simply come from Samsung.
We have reports that Samsung is killing foreground services on their Android 10 update. See https://issuetracker.google.com/issues/179644471 and https://github.com/urbandroid-team/dont-kill-my-app/issues/307.. We are now investigating the latest update that this has been fixed and if it holds we will consider a lower score for Samsung, but for now we keep it to keep cautious about Samsung.
We have many reports that even when you whitelist an app Samsung can put it to the restricted lists again later on based on various criteria. One of them could be crashes in the app.. We have seen this massively in the recent WebView issue introduced by Google. Suddenly whitelisted apps become restricted again. So even the WebView issue was fixed by Google promptly, the effect of it is long lasting thanks to Samsung policies.
At the moment we have no evidence Samsung notifies users of app killing (or moving the apps to their restricted lists). Could you please post some evidence? Ideally a screenshot? Is this a notification? Anyway whatever Samsung does it is not sufficient. So many users simply don't have the slightest clue of what is Samsung doing and blames the developers of misbehavior.
5.Putting apps to restricted mode based days of no usage - we have reports that Samsung can put apps on the list of sleeping apps after 3 days of not being used - is IMHO hideous.. it is a caricature of Google intended with Adaptive battery
6.The market share may also be seen as the reason to give Samsung 5 crap score because it is simply so important what policies Samsung implements. At the moment IMHO Samsung has one of the worst app killing implementation on the market. It may not be the #1 top worst, but Samung's market share makes it simply the one with the most negative impact in the ecosystem.

Hope that explains it a little big more. Any evidence about point 4. is very much appreciated..

BTW @tprochazka to demonstrate the issue from a more practical side..
We are maintaining a smart alarm clock app.. We are getting some 5-20 complains every single day very similar to the one I just resolved, here:
"I've used this app for nearly 10 years. It no longer works after the last few updates. The alarm doesn't go off anymore, which made me late to work a few times. I've stopped using it and switched to Alexa since I can't trust it....Very sad, because I always loved the app and trusted it completely. No more."
Of course most people do not write, they just uninstall straight away..
We reply with the guide at https://dontkillmyapp.com/samsung and in 99% cases users resolve the issue and everything is working at least for some time before Samsung decides it's time to put the app back to the sleeping apps list of disabled apps list or whatever..
But those Samsung users have ABSOLUTELY NO IDEA why their favorite alarm clock app just stopped working out of the blue. They are late for work and blame the dev of course.
For ~20 Samsung issues we get some ~4 issues from 1+ devices and ~2 from Huawei and Xiaomi each every day...

I understand. I have a TV Guide app and luckily almost zero complaints from Samsung, just Huawei and Xiaomi.
But it is obvious why. Samsung put the app to sleep (or deep sleep) when you did not use them (not open from launcher)
An alarm clock is a good example of an app that you set once and then do not open for a long time.
Samsung shows a notification when he put apps to sleep, so the user has the ability to easily react to this and prevent it.
This is why I think that Samsung is not so bad.
For example Huawei, according to your description is the only way to uninstall some app via ADB in developer mode.  Which is a completely different level of complexity for normal users.

Correct me if im wrong tho, but it seems like there has been some improvements here lately? It seems that on a S10 Plus, that it actually works putting the apps to:
Unrestricted (in app settings on phone)
And in special permissions going in from the hamburger-menu.

@godzillamesel reports from our users are still indecisive. It seems Smasung is testing different approaches and every device is behaving differently. On some devices putting to unrestricted lists will help, on thers users have no control and Chimera policy manager just stops any foreground service running. Recently I saw reports from S22 and a52 users that they need to use "don't optimize this app" on the standard battery settings to prevent Samsung's non-standard app killing. This is a bad news as this setting is regulated by the Play Store and promoiting users to set it can lead to removing the app from the Play Store..

BTW look at this thread https://github.com/urbandroid-team/dont-kill-my-app/issues/307#issuecomment-1094125524


Make responsive

Make index page responsive

Hey @mohsin-sh, yes you can.

sorry I thought it is a plain vanilla js

Please assign this to me I can work on making the project responsive

Please assign this to me

Hey, you can work.

I didn't see this was assigned...

I didn't see this was assigned...

Not problem, @PranavTrip already removed his assignment.


App invite calling deep link activity two times

i have added appinvite in my app and handling deeplink activity manually whenever user click on install button from the mail then deeplink activity is launched now when i exit the application and again launch the app from app icon then alongwith main activity deep link activity is also launched.
Means i am getting values in Result callback
onResult(AppInviteInvitationResult result)
How i can clear the result intent once i have used it ?

If you are calling getInvitation in onCreate of your main Activity, you may want to guard it like this so it only happens once:
@Override
public void onCreate(Bundle savedInstanceState) {
   // ...

   if (savedInstanceState == null) {
     AppInvite.AppInviteApi.getInvitation(...);
   }
}

during app launch it will call first, but my scenario is when app is lanched from mail box then its gives intent values now i close the app from back button and again launch the app from app icon then i get same intent.
i have refer google service app invite sample, also this sample also has same problem.
from your answer first time i will get null so it looks for app invite invitation and once i will close the app, then will again launch from app icon in that case we will again get saveInstanceState to null  then we will again get invitation.

@varunbadgujar we have confirmed this is a bug, thanks for reporting!
Since it appears this occurs exactly twice (in my testing), you could call getInvitation a second time with no callback (null or empty) to work around the bug.

This bug was already fixed?

@felipe-silvestre-movile a few releases ago there was a bug where this would happen for other reasons.  The current release is working as intended, and app developers should follow the steps above.

I'm still seeing this (or something similar), on 9.0.2.
Had to do a second call with AppInvite.AppInviteApi.getInvitation(googleApiClient, null, false); after the one with the callback to prevent it from being captured a second time.


Replaces nonexisting system_namespace variable

As the system_namespace is removed since sometime but was still present in the commented registry_namespace and local_volume_provisioner_namespace
I could not find a suitable replacement variable so replaced it with a hardcoded kube-system.
If there is a suitable variable which I overlooked, let me know!

ci check this

/lgtm

/approve


Can not compile

/usr/local/cuda-7.0/bin/nvcc -I"/root/work/CudaHoG" -I/usr/local/include/ImageMagick-6 -I/usr/include/ImageMagick -I"/root/work/CudaHoG/include" -G -g -lineinfo -O0 --compile --relocatable-device-code=true -gencode arch=compute_20,code=compute_20 -gencode arch=compute_20,code=sm_21 -m64  -x cu -o  "include/codefull/ImageUtils.o" "../include/codefull/ImageUtils.cu" -std=c++11
../include/codefull/ImageUtils.cu(60): error: no instance of overloaded function "codefull::FloatImage::convolve" matches the argument list
argument types are: (std::vector<Npp32f, std::allocator>, NppiSize)
object type is: codefull::FloatImage
../include/codefull/ImageUtils.cu(61): error: no instance of overloaded function "codefull::FloatImage::convolve" matches the argument list
argument types are: (std::vector<Npp32f, std::allocator>, NppiSize)
object type is: codefull::FloatImage

You did try to compile using Nsight Eclipse, correct?

Yes, I am on CentOS 7 and with CUDA 7 + Nsight Eclipse

OK I will look into it and will get back to you.
Sorry about that

OK it seems that the latest commit was a bad commit. The issue should be fixed now.
Please check and report back any problems. Thank you for reporting the issue.


properly update workflow tasks instead of pushing new results

[ ] I have added the tests to cover my changes.
[x] I have updated the documentation and CHANGELOG accordingly.
[x] I have read the CONTRIBUTING document.

Resolves #409

@FyzHsn is there an issue open to re-enable the skipped tests?


Using io.TextIOWrapper on S3File crashes on Python 2.7

S3File cannot be fully used with io.TextIOWrapper on Python 2.7 because it doesn't provide all of the methods needed by readline(). This is a problem because files are always opened in binary mode, and if we need to access the file as text, this is the simplest way to do it without downloading the entire file.
Minimal example:
from __future__ import print_function

import io

import moto
import s3fs

with moto.mock_s3():
    fs = s3fs.S3FileSystem()
    fs.mkdir('bucket')
    with fs.open('bucket/file.txt', 'wb') as fd:
        fd.write(u'\u00af\\_(\u30c4)_/\u00af'.encode('utf-16-le'))
    with fs.open('bucket/file.txt', 'rb') as fd:
        with io.TextIOWrapper(fd, 'utf-16-le') as stream:
            print(stream.readline())    # crashes here

The above code crashes with this:
AttributeError: 'S3File' object has no attribute 'read1'

Fixed in #131

Fixed in #131 .


A few feed readers

Mozilla/5.0 (compatible; inoreader.com; 1 subscribers)
Mozilla/5.0 (compatible; theoldreader.com)
Mozilla/5.0 (compatible; theoldreader.com; 1 subscribers; feed-id=*some-unique-hash*)
BTWebClient/355S(45724)

Merged. Thank you!


"RequestAuthentication" doesnt get applied to ingressgateway in istio 1.6.2

@itsmurugappan
"RequestAuthentication" doesnt get applied to ingressgateway in istio 1.6.2. Same policy works when applied to service pod with side car enabled.
apiVersion: "security.istio.io/v1beta1"
kind: "RequestAuthentication"
metadata:
name: "jwt-example"
namespace: istio-system
spec:
selector:
matchLabels:
istio: ingressgateway
jwtRules:

issuer: "https://authserver.com:443/oauth2"
jwksUri: "http://authserver.com/oauth2/rest/security"

apiVersion: "security.istio.io/v1beta1"
kind: "RequestAuthentication"
metadata:
name: "jwt-example"
namespace: default
spec:
selector:
matchLabels:
app: bookinfo
jwtRules:

issuer: "https://authserver.com:443/oauth2"
jwksUri: "http://authserver.com/oauth2/rest/security"

[ ] Security
Expected behavior
RequestAuthentication when applied to ingressgateway wont validate the  jwt token.
Same apolicy when applied to service pod with side car works fine. validate jwt token.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istio 1.6.2
How was Istio installed?
istioctl
Environment where bug was observed (cloud vendor, OS, etc)

RequestAuthentication needs to be accompanied by a AuthorizationPolicy. https://istio.io/latest/docs/reference/config/security/request_authentication/

RequestAuthentication needs to be accompanied by a AuthorizationPolicy. https://istio.io/latest/docs/reference/config/security/request_authentication/

@itsmurugappan itsmurugappan
thanks for the reply.
Heres the complete  policy applied. authentication and authorization policy.
apiVersion: "security.istio.io/v1beta1"
kind: "RequestAuthentication"
metadata:
name: reqauthn-ingress-policy
namespace: istio-system
spec:
selector:
matchLabels:
istio: ingressgateway
jwtRules:

issuer: "https://oauthserverhost/oauth2"
jwksUri: http://oauthserverhost/oauth2/rest/security

apiVersion: "security.istio.io/v1beta1"
kind: "AuthorizationPolicy"
metadata:
name: reqauthz-ingress-policy
namespace: istio-system
spec:
selector:
matchLabels:
istio: ingressgateway
action: DENY
rules:

to:

operation:
methods: ["GET"]
hosts: ["example.com"]
paths: ["/productpage"]
when:
key: request.auth.claims[SSO_GROUPS]
notValues: ["GRP_SP_SF",":GRP_SP_SF",":GRP_SP_SF:","GRP_SP_SF:"]

Above policy works as expected in istio 1.5.8 when applied to ingress gateway.
Works as expected istio 1.6.2 when applied at applicaton pod level, however it shows deny for all users including one who has GRP_SP_SF in claim SSO_GROUPS

thanks for the report, so from what you're seeing it looks like the RequestAuthN is not working correctly on ingress gateway, I will update once I reproduced this.

thanks for the report, so from what you're seeing it looks like the RequestAuthN is not working correctly on ingress gateway, I will update once I reproduced this.

@yangminzhu
Yes, you are correct. thanks

thanks for the report, so from what you're seeing it looks like the RequestAuthN is not working correctly on ingress gateway, I will update once I reproduced this.
@yangminzhu
Is there an update on this?

Maybe it is related to bug 25578 ?

Sorry for the late update, @r-kotagudem , I tested this in 1.6.5 and it just works as expected for me (I used a different token and issuer but the similar policies)
Would you mind to try again? Also a note for the value "*:GRP_SP_SF:*", you may expect it to match a string that contains the :GRP_SP_SF: but actually it will not work as you expected (instead the behavior is undefined, it could be doing a suffix matching of :GRP_SP_SF:*). Currently we only support prefix, suffix or existence matching with the wildcard character (*).

Closing given the in above, we didn't see unexpected behavior.
Anyone runing into again feel free to comment and reopen.

My header would be like x-auth-request-groups : 'CN=EMSUDEMY,OU=Groups,O=cco.xxx.com, CN=all-xxxx-people,OU=xxxx Groups,O=cco.xxxx.com, CN=xxxxxxxxx,OU=xxxx Groups,O=cco.xxxx.com' now I would like match * all-xxxx-people*


Major Frames issues after a while flying around

Describe the bug
I'm not sure why, but I'm having major FPS and TPS drops, both in single and multiplayer, after flying around for a while. I did some testing with a completely vanilla client and it doesn't happen. I'm not sure what is happening, as the log doesn't show anything weird as the game is running, although it gives some erros when closing the world and then crashes the client.
Here are some screenshots I took while flying around. It starts perfectly, with over 500fps sometimes, and then it starts going down. Eventually, it becomes unplayable until I close the client and open again.
I did notice this before, but I though was some combination of other mods I installed later. Today I decide to do the testing without any mods besides what is included in the modpack and the problem persists.
Please, let me know if there's any other information I can provide to help you figure it out! :)

Modpack version
3.8.3 for 1.18.2 (MultiMC)
Launcher
MultiMC
Other things

[ ] I updated FO to a newer version (mention, what version to what version)
[ ] I removed or added some mods (mention, which ones)

Additional context

[20:57:25] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[20:57:25] [Render thread/WARN]: Ambiguity between arguments [teleport, location] and [teleport, targets] with inputs: [0.1 -0.5 .9, 0 0 0]
[20:57:25] [Render thread/WARN]: Ambiguity between arguments [teleport, destination] and [teleport, targets] with inputs: [Player, 0123, @e, dd12be42-52a9-4a91-a8a1-11c01849e498]
[20:57:25] [Render thread/WARN]: Ambiguity between arguments [teleport, targets] and [teleport, destination] with inputs: [Player, 0123, dd12be42-52a9-4a91-a8a1-11c01849e498]
[20:57:25] [Render thread/WARN]: Ambiguity between arguments [teleport, targets, location] and [teleport, targets, destination] with inputs: [0.1 -0.5 .9, 0 0 0]
[20:57:25] [Render thread/INFO]: Loaded 7 recipes
[20:57:25] [Render thread/INFO]: Loaded 1141 advancements
[20:57:25] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[20:57:25] [Render thread/INFO]: Applied 0 biome modifications to 0 of 61 new biomes in 247.9 ?s
[20:57:25] [Server thread/INFO]: Starting integrated minecraft server version 1.18.2
[20:57:25] [
[2022-06-01-1.log.gz](https://github.com/Fabulously-Optimized/fabulously-optimized/files/8819501/2022-06-01-1.log.gz)
[latest.log](https://github.com/Fabulously-Optimized/fabulously-optimized/files/8819502/latest.log)
Server thread/INFO]: Generating keypair
[20:57:29] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[20:57:29] [Render thread/INFO]: Preparing spawn area: 0%
[20:57:30] [Render thread/INFO]: Preparing spawn area: 0%
[20:57:30] [Render thread/INFO]: Preparing spawn area: 3%
[20:57:31] [Render thread/INFO]: Preparing spawn area: 8%
[20:57:31] [Render thread/INFO]: Preparing spawn area: 12%
[20:57:32] [Render thread/INFO]: Preparing spawn area: 18%
[20:57:32] [Render thread/INFO]: Preparing spawn area: 23%
[20:57:33] [Render thread/INFO]: Preparing spawn area: 30%
[20:57:33] [Render thread/INFO]: Preparing spawn area: 35%
[20:57:34] [Render thread/INFO]: Preparing spawn area: 36%
[20:57:34] [Render thread/INFO]: Preparing spawn area: 42%
[20:57:35] [Render thread/INFO]: Preparing spawn area: 47%
[20:57:35] [Render thread/INFO]: Preparing spawn area: 54%
[20:57:36] [Render thread/INFO]: Preparing spawn area: 60%
[20:57:36] [Render thread/INFO]: Preparing spawn area: 68%
[20:57:37] [Render thread/INFO]: Preparing spawn area: 73%
[20:57:37] [Render thread/INFO]: Preparing spawn area: 79%
[20:57:38] [Render thread/INFO]: Preparing spawn area: 86%
[20:57:38] [Render thread/INFO]: Preparing spawn area: 92%
[20:57:38] [Server thread/INFO]: Changing view distance to 20, from 10
[20:57:38] [Server thread/INFO]: Changing simulation distance to 6, from 0
[20:57:38] [Render thread/INFO]: Time elapsed: 9360 ms
[20:57:38] [Server thread/INFO]: Yumatan[local:E:336653c0] logged in with entity id 809 at (-17.5, 80.0, 15.5)
[20:57:38] [Server thread/INFO]: Yumatan joined the game
[20:57:39] [Render thread/INFO]: Started 10 worker threads
[20:57:39] [Render thread/INFO]: Loaded 0 advancements
[20:57:43] [Server thread/INFO]: [Yumatan: Set own game mode to Spectator Mode]
[20:57:43] [Render thread/INFO]: [CHAT] Set own game mode to Spectator Mode
[20:58:13] [Server thread/INFO]: Saving and pausing game...
[20:58:13] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[20:58:13] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[20:58:13] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[20:58:20] [Render thread/INFO]: Flushed changes to Minecraft configuration
[20:58:25] [Render thread/WARN]: Reclaimed 3264 bytes at address<PHONE_NUMBER>568 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 21760 bytes at address<PHONE_NUMBER>944 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 8892 bytes at address<PHONE_NUMBER>056 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 59280 bytes at address<PHONE_NUMBER>224 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 432 bytes at address<PHONE_NUMBER>464 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 2880 bytes at address<PHONE_NUMBER>040 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 6048 bytes at address<PHONE_NUMBER>456 that were leaked from an unknown location (logging is disabled)
[20:58:25] [Render thread/WARN]: Reclaimed 20960 bytes at address<PHONE_NUMBER>016 that were leaked from an unknown location (logging is disabled)
[20:58:36] [Render thread/INFO]: [CHAT] Saved screenshot as 2022-06-01_20.58.36.png
[21:00:36] [Server thread/INFO]: Saving and pausing game...
[21:00:36] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[21:00:36] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[21:00:36] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[21:00:38] [Server thread/INFO]: [Yumatan: Set own game mode to Creative Mode]
[21:00:38] [Render thread/INFO]: [CHAT] Set own game mode to Creative Mode
[21:00:43] [Server thread/INFO]: Yumatan has reached the goal [Sky's the Limit]
[21:00:43] [Render thread/INFO]: [CHAT] Yumatan has reached the goal [Sky's the Limit]
[21:00:43] [Render thread/INFO]: Loaded 5 advancements
[21:01:07] [Render thread/WARN]: Reclaimed 2544 bytes at address<PHONE_NUMBER>664 that were leaked from an unknown location (logging is disabled)
[21:01:07] [Render thread/WARN]: Reclaimed 134880 bytes at address<PHONE_NUMBER>864 that were leaked from an unknown location (logging is disabled)
[21:01:07] [Render thread/WARN]: Reclaimed 864 bytes at address<PHONE_NUMBER>632 that were leaked from an unknown location (logging is disabled)
[21:01:07] [Render thread/WARN]: Reclaimed 5760 bytes at address<PHONE_NUMBER>088 that were leaked from an unknown location (logging is disabled)
[21:01:07] [Render thread/WARN]: Reclaimed 20232 bytes at address<PHONE_NUMBER>336 that were leaked from an unknown location (logging is disabled)
[21:01:07] [Render thread/WARN]: Reclaimed 16960 bytes at address<PHONE_NUMBER>312 that were leaked from an unknown location (logging is disabled)
[21:01:48] [Server thread/INFO]: [Yumatan: Set own game mode to Spectator Mode]
[21:01:48] [Render thread/INFO]: [CHAT] Set own game mode to Spectator Mode
[21:01:59] [Server thread/INFO]: [Yumatan: Set own game mode to Creative Mode]
[21:01:59] [Render thread/INFO]: [CHAT] Set own game mode to Creative Mode
[21:02:53] [Render thread/INFO]: [CHAT] Saved screenshot as 2022-06-01_21.02.53.png
[21:03:04] [Render thread/INFO]: [CHAT] Saved screenshot as 2022-06-01_21.03.04.png
[21:03:09] [Render thread/INFO]: [CHAT] Saved screenshot as 2022-06-01_21.03.08.png
[21:03:23] [Server thread/INFO]: Saving and pausing game...
[21:03:23] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[21:03:23] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[21:03:23] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[21:03:24] [Server thread/INFO]: Yumatan lost connection: Disconnected
[21:03:24] [Server thread/INFO]: Yumatan left the game
[21:03:24] [Server thread/INFO]: Stopping singleplayer server as player logged out
[21:03:24] [Server thread/INFO]: Stopping server
[21:03:24] [Server thread/INFO]: Saving players
[21:03:24] [Server thread/INFO]: Saving worlds

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Server thread"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Thread-1"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "IO-Worker-18"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Worker-Main-13"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Render thread"

Exception: java.lang.OutOfMemoryError thrown from the UncaughtExceptionHandler in thread "Worker-Main-3"
AL lib: (EE) alc_cleanup: 1 device not closed
Process exited with code 1.
Clipboard copy at: 01 Jun 2022 21:07:19 -0300

Edit by Madis0: formatted and collapsed logs

Reclaimed 3264 bytes at address<PHONE_NUMBER>568 that were leaked from an unknown location (logging is disabled)

These lines are interesting, though I'm not sure what they really refer to.
Could you disable the JVM flags that are added by this modpack in instance settings? You could also try disabling the RAM limits.

These lines are interesting, though I'm not sure what they really refer to. Could you disable the JVM flags that are added by this modpack in instance settings? You could also try disabling the RAM limits.

I'm not sure how to do this... Would you mind helping me? I'm using MultiMC launcher, where should I go to change those configs?

Ok, I'm not sure if it that what you meant, but I disabled Java Arguments and Memory on the Settings tab in MultiMC (I just unticked the boxes) and it made it better. I still have some spikes in TPS and FPS but they are not happening that often and are sparse, not compromising gameplay at all. I'll do some more testing later today. Thanks for the insight.

Yes, that is what I meant. When you test today, please confirm whether you actually needed to uncheck both boxes or just one of them (I am assuming memory is the culprit).

Got it, then I'll probably remove both in the next version.

Aren't the JVMs flags in FO Just the vanilla ones ?

Aren't the JVMs flags in FO Just the vanilla ones ?

They are from the Fabric Loader installer -> vanilla launcher. But I guess there may still be differences in launchers which cause this, e.g. LWGJL and Java versions.

Isn't that a memory leak from some mod?

CaffeineMC/sodium-fabric#1024 - I wouldn't touch memory settings and just wait for this to be fixed.

Well, that update can take time so I would assume it's better to workaround it on FO side...

so this'll be getting a fix? LETS GOOOO

literally the only reason my performance sucks so much

the drops are usually way lower with pregenerated chunks, so this is mostly a slow chunk loading issue

though it could also be mipmaps

there is usually less drops with pregenerated chunks, so this is mostly a slow chunk loading issue

In that case you could try #305

sure, is there a fix for this on serverside though? elytra users use a lot of ram

the only solution i know is pregenerating chunks, but its a bad idea to do this before new 1.19 update because deep dark

oh right i can just loot the elytras in a 5k-10k radius

sure, is there a fix for this on serverside though? elytra users use a lot of ram

FO has never been supported on the server. See the wiki for more info and what can you use on the server.

Presumably fixed in 3.9.0


Question: including additional attributes in predictions

In the example for recommending a course it looks at users who have taken the course tags, and topics.  What is the recommended way to use additional information about the users who have taken a course to recommend related courses?  Eg,  a user from north america takes one course and a user in south africa takes a different course.  I'd like future users in north america to be recommended the first course.

Hmm, you could add a matrix to courses for locations the course has been taken in (essentially locations of the users that have completed the course) and a matrix to users for location(s) they're in. That'll at least factor the location into the algorithm.
Additionally, if your location dataset is as small as one based on continent, you could have a different Redis dataset per continent using the redis_prefix. This would probably be a better route if you required location to exist and did not want courses from one location to be recommended to users who were not in that location. But if that's the case, you might be better querying against the database after you fetch the courses with Predictor. That's probably as good as it gets with the way Predictor is currently built though.
If you have any ideas to better handle this, PRs are very welcome :)


It would be great to see GSTouchesShowingWindow converted to Swift, some of us are trying to go 100% Swift!  :-)

It would be great to see GSTouchesShowingWindow converted to Swift, some of us are trying to go 100% Swift!  :-)

You're right, it would be good to convert it to Swift, but unfortunately I haven't started with Swift yet, so it would be quite difficult for me. But if you know at least basics of Obj-C, you could convert it yourself. I think it shouldn't be that difficult ;-).

problem is with integration within AppDelegate (override window etc)

@curveddesign I know I'm way too late, but I have good news: In my efforts to finally start with Swift, I've created a new version of this code which is entirely in Swift (here: GSTouchesShowingWindow-Swift). It also supports App Extensions and shows a short tap indicator.


support compilation with Gopherjs

We hit a problem trying to compile this decimal library to Javascript and this little additional build tag fixes it.
Thank you!

We are using it for a compiled to JS version of our custom LISP
interpreter.
Thanks for your library!
On Fri, May 11, 2018 at 6:21 AM Eric Lagergren<EMAIL_ADDRESS>wrote:

Neat! Sorry it took a couple days to get to this.
If you don't mind me asking, what're you using this library for? It's been
pretty cool to see what people use it for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ericlagergren/decimal/pull/93#issuecomment-388255628,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAE0D9Orve5BCoh64JKsNdrBejJVyH6ks5txRHMgaJpZM4T4KSi
.

--
Roman Heinrich
Email<EMAIL_ADDRESS>Resume devopsbox.es/resume/resume.html
Github github.com/mindreframer
Twitter @mindreframer
Blog devopsbox.es
Xing xing.to/mindreframer
Linkedin de.linkedin.com/in/mindreframer
Delicious delicious.com/mindreframer
Skype mindreframer


read config files episode 2

Codecov Report

Merging #28 (acf6640) into main (d8e251f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          135       144    +9
  Branches        18        19    +1
=========================================
+ Hits           135       144    +9

Impacted Files
Coverage Δ

src/magic_tiler/utils/configs.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e251f...acf6640. Read the comment docs.


fix: resize breaks DnD

Description
Resizing a widget trigger canvas selection which breaks DnD.
Fixes #7138

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@marks0351 Tested on Deploy Preview and working fine.


🐛 [BUG]: Outline show wrong nesting in pug

The generated oultine does not follow the source

there is also a .. before content

Will all those seemingly minimal changes, if feels a bit like magic what you do @johnsoncodehk


Error when trying to delete vdisk image

[Mon23 12:56] - Job.py              :70  :j.core.jobcontroller.job.a2c75f1b660ef141158422248670a5c0 - ERROR    - job: vdisk_image!676abd759b (delete) failed:
Traceback (most recent call last):
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/tmp/actions/vdisk_image/d31ae033343138630087e5bd8f6236bb.py", line 61, in delete
    clusterconfig = get_cluster_config(job)
NameError: name 'get_cluster_config' is not defined
2017-10-23 12:56:33 - (network)[INFO][<IP_ADDRESS>:48420]: GET http://<IP_ADDRESS>:5000/ays/repository/orchestrator-server/aysrun/5bedcae2ace40b962ccebcfdd7a0dc6a  200 585
INFO:network:
2017-10-23 12:56:33 - (network)[INFO][<IP_ADDRESS>:48418]: GET http://<IP_ADDRESS>:5000/ays/repository/orchestrator-server/aysrun/6920de2294b60061a707d84d95806989  200 4192
INFO:network:
[Mon23 12:56] - RunStep.py          :84  :j.atyourservice.server         - ERROR    - job: vdisk_image!676abd759b (delete) failed:
name 'get_cluster_config' is not defined
[Mon23 12:56] - RunStep.py          :87  :j.atyourservice.server         - INFO     - runstep 3: error
[Mon23 12:56] - Run.py              :162 :j.atyourservice.server         - ERROR    - error during execution of step 3 in run 75cb08a89d9f4dd11c882f372e3629af
Error of job: vdisk_image!676abd759b (delete):
*TRACEBACK*********************************************************************************
NameError: name 'get_cluster_config' is not defined

******************************************************************************************

Version
master: 7c79c260605c451d8bc51b97ce56781ff781fba3

issue still exists
ays log
[Sun12 07:55] - RunStep.py          :87  :j.atyourservice.server         - INFO     - runstep 3: error
[Sun12 07:55] - Run.py              :162 :j.atyourservice.server         - ERROR    - error during execution of step 3 in run 40c569ac614efd15d98aaecc0a8522b8
Error of job: vdisk_image!9a5ef196c0 (delete):
*TRACEBACK*********************************************************************************
JumpScale9.errorhandling.JSExceptions.RuntimeError: ERROR: Failed to run zeroctl delete  Error: unknown flag: --config
Usage:
  zeroctl delete [command]

Available Commands:
  vdisk       Delete a vdisk

Flags:
  -h, --help   help for delete

Global Flags:
  -v, --verbose   log available information

Use "zeroctl delete [command] --help" for more information about a command.

unknown flag: --config
 ((type:runtime.error)

******************************************************************************************

software version
master : 851d41f

fixed in https://github.com/zero-os/0-orchestrator/commit/74aa7a7955ff34ddb01ff4e60ecd418591b78bc2


feat(consensus): TypedTransaction

Motivation
There is no proper concrete type which contains all ethereum transaction types implemented (legacy/eip2930/eip1559), which can be used by a alloy-providers or alloy-contract for remote/local signing and sending txs to the network. We have TransactionRequest/CallRequest, but it is an RPC type, and does not support encoding / signing.
Solution
Adds TypedTransaction to alloy-consensus—an enum which represents the unsigned version of TxEnvelope, which can contain any of the ethereum transaction types.
The rationale behind this type is for it to be the built-in concrete type used in providers to either use for remote account signing (send_transaction), or for signing locally and sending through the network (send_raw_transaction).
In the case of send_raw_transaction, it is expected for the TypedTransaction to be signed, and to then be converted into a TxEnvelope through to_enveloped, which can then be encoded and sent through the network. Decoding is not implemented, as this type is not meant be used in this manner.
With #178, we should also be able to implement a conversion from TransactionRequest -> TypedTransaction, which currently exists in ethers with into_typed_tx.
The enum implements Transaction, meaning it is signable by the alloy signers.
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

Hmm, I don't think this should be an RPC type? How I see it is that:

TransactionRequest, the one being deduped on #178, is the corresponding RPC type.
TransactionRequest does not implement any encoding functionality for signing. We don't have any concrete type we can pass to the provider to sign, other than passing specifically a TxLegacy/TxEip2930/TxEip1559. This enum is the equivalent of https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/types/transaction/eip2718.rs#L19-L47, which can be signed.
The idea is that TransactionRequest can be transformed into this type by doing into_typed_request, which we'd need to implement on TransactionRequest.

I'm not sure we're on the same page on how we'd sign transactions on the provider without this type—could you please elaborate @onbjerg ?

I think we could also follow reth's approach, and keep this TypedTransaction as an RPC type, but be able to convert it into an alloy-consensus transaction, like so: https://github.com/paradigmxyz/reth/blob/main/crates/rpc/rpc-types-compat/src/transaction/typed.rs#L7-L58. wdyt @mattsse ?

this is an intermediary step that might no longer be required, need to revisit this again
but @onbjerg the general idea is
you start out with a general purpose CallRequest, convert that into a signable TypeTransaction but setting all the required fields and then this type is signable

This is a typed transaction request, meaning: it has disambiguated which type of tx this is, with the fields assigned, and we want to sign this type.

This is the sticking point. We don't sign TransactionRequest. We sign specific types T: Transaction. TransactionRequest is submitted to the server via RPC. We need to provide a TransactionBuilder that can be built into either TransactionRequest or some set of T: Transaction that can be signed and be put in a TransactionEnvelope
basically
trait TxBuilder<N> {
    fn gas(mut self, gas: U256) -> Self;
    fn data(mut self, data: Bytes) -> Self;

    // etc

    fn build_req(self) -> N::TransactionRequest;
    fn sign<S>(self, signer: S) -> Result<N::TransactionEnvelope>;
}

Sounds Good to meDen 5. feb. 2024 kl. 21.00 skrev James Prestwich @.***>:
and our signing needs to be flexible enough to all non-secp256k1 sigs :)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

This is the sticking point. We don't sign TransactionRequest. We sign specific types T: Transaction.

Agreed, and here's how I view this:

We have TransactionRequest. See https://github.com/alloy-rs/alloy/pull/178.
TypedTransaction by itself is not signable, but rather delegates signing to its contained variants (TxLegacy/TxEip1559/TxEip2930). I agree TypedTransaction itself implementing Transaction looks weird, but we can always just do TypedTransaction.tx() and get the concrete tx type to sign if that looks better.

Here's how I'm thinking about the full interaction:
An user uses alloy-contract to build a tx (or manually with TransactionRequest). Alloy contract will return TransactionRequest. A signer cannot accept TransactionRequest, as it needs an specific type T: Transaction. Therefore, before signing, we need to disambiguate what we're signing. TypedTransaction serves as this type, as TransactionRequest will be able to go from TransactionRequest -> TypedTransaction. For signing, then we take the contained tx in TypedTransaction, and sign that, put it in a TxEnvelope, and finally send it over the network with a provider.
Therefore, the interaction would look like:

alloy-contract builds a TransactionRequest

Convert that TransactionRequest into a TypedTransaction

Extract the concrete tx to sign with TypedTransaction.tx(), sign the bytes.

Send the raw tx over the network

We need to provide a TransactionBuilder that can be built into either TransactionRequest or some set of T: Transaction

This is what alloy-contract would be for—the tx can also be built manually with the TransactionRequest type. We can discuss more call builders but I think this is also something users can implement on their own.

This is the sticking point. We don't sign TransactionRequest. We sign specific types T: Transaction. TransactionRequest is submitted to the server via RPC. We need to provide a TransactionBuilder that can be built into either TransactionRequest or some set of T: Transaction that can be signed and be put in a TransactionEnvelope

fn build_req(self) -> N::TransactionRequest;

yeah so the main (unresolved) question is what's the TransactionRequest here

TransactionRequest is submitted to the server via RPC.

this applies to all endpoints besides eth_sendRawtransaction for which we need the TransactionEnvelope
The distinction between TransactionRequest and T: Transaction is important:

TransactionRequest is just the RPC type
T: Transaction is a signable representation of a (typed) transaction

A TransactionRequest can be converted into T: Transaction by setting all required fields
what this PR adds is the T: Transaction for ethereum (minus EIP-4844)
This trait:
trait TxBuilder<N> {
    fn gas(mut self, gas: U256) -> Self;
    fn data(mut self, data: Bytes) -> Self;

    // etc

    fn build_req(self) -> N::TransactionRequest;
    fn sign<S>(self, signer: S) -> Result<N::TransactionEnvelope>;
}

could be implemented on TransactionRequest (== N::TransactionRequest), although for ergonomic reasons perhaps we need a different builder type
but the conversion from TransactionRequest -> TypedTransaction is relevant in sign

. TypedTransaction doesn't make sense as a type. It's the unhappy middle between consensus format TransactionEnvelope and RPC format.

I think it's necessary because we want a clean way to get the signature hash we're signing. This step is just easier if we have a typed representation of the transaction

what this PR adds is the T: Transaction for ethereum (minus EIP-4844)

note that when i rebase i'll add eip-4844 too

The distinction between TransactionRequest and T: Transaction is important:
TransactionRequest is just the RPC type
T: Transaction is a signable representation of a (typed) transaction

We don't want a signable representation of a typed transaction. We want a builder that coordinates signing and constructs a tx envelope. The builder should not impl Transaction, as it is not a transaction

yeah, my point is that this step

coordinates signing and constructs a tx envelope

is easier if you have the actual transaction types, which will happen inside sign or before that (hidden,internally) in some builder function

yeah, my point is that this step
coordinates signing and constructs a tx envelope
is easier if you have the actual transaction types, which will happen inside sign or before that (hidden,internally) in some builder function

The builder needs type knowledge of the inner transactions so it can convert itself into them, but almost all other parts of the API should never have that. They should operate only on builders and envelopes. It is a mistake to make a pub enum TypedTransaction

I'd like to agree on a direction soon—this is blocking for further foundry work.

The builder needs type knowledge of the inner transactions so it can convert itself into them during the envelope instantiation process

how would this look? and in the case of sending an unsigned transaction, how would we disambiguate between the different transaction types properly? I'm struggling to look how this would work without this TypedTransaction type that coordinates signing and constructing the envelope.

ping @mattsse / @prestwich

This is possibly also blocking https://github.com/paradigmxyz/reth/pull/6364 since a typed tx repr is used in reth, and that PR is a prerequisite for https://github.com/alloy-rs/alloy/pull/178 getting merged which is a prerequisite for me being able to rename the provider and add a network generic for both the provider and CallBuilder in alloy-contract 🥵

then we should really make sure we get this right before it gets into the internals of everything 😅
what would you think about having the builder be RPC request format? I.e. reth desers a builder

@Evalir i'm gonna noodle around with this today and try to get things unblocked

Closing in favor of #190 per telegram discussion.


Updating a model issue

Description:
While calling save on a model with a json attribute that not updated, it's considered as dirty and it triggers an update even though no update is needed...
I found that the issue is in originalIsEquivalent function in HasAttributes trait within the check hasCast. When casting original and current to Object, they will be always different instances therefore strict comparison will always return false even if the values are equal.
Steps To Reproduce:

Add an attribute in casts array with value object.
Run save on a model with the same values of object.
It will trigger an update and affect updated_at

Can you please fill out the issue template?

What do you mean? it's with all versions!

Please fill out the template with the versions you're using.

it's not relevant to a particular version!

It's vital to know in which version you're experiencing the problem because code can differ between each version.

I have checked it with versions 5.5 - 5.8, it's the same no difference.

#27946 discusses a related issue and #28029 proposed a fix for it and your issue but got rejected.


[Power Support] Add blobs that need updated config.guess file to S3 blobstore.

Hey, all.
I work on porting BOSH to Power microprocessor architectures. The most common problem here is that some components that are compiled during deployment don’t have correct build configuration support for Power.
This problem is solved easily by updating config.guess files to such packages. You can find out how I generated this blobs using this script (this script uses this helpers script for some functions), inputs for this scripts you can find in this yaml file.
Following this answer in cf-dev I need to put this blobs to S3 blobstore and post output of bosh blobs to this PR. I tried to run bosh blobs command and it shows No blobs to upload now. But I guess that contents of release/config/blobs.yml can demonstrate you updated blobs.
Thank you,
Alex L.

I've got an answer from Matthew Sykes in cf-dev mailing list that suggested to make a patches in a build phase. I consider that solution with patching is a better choice. Will make PR soon.


Help greenkeeper to update ember-cli-template-lint

Have a look at the #1446. The build is failed because apparently some new rules were introduced.
Goal: where applicable and clear - fix templates; where requires much effort - disable rules.

I will give this one a try. Will post updates as I go.

Update: almost all errors resolved. 9 items left. Will fix those tomorrow.


feat: move add example components to a more visible space and change behavior

Previously the button was displayed every time the table was empty. This event happened during filtering, causing the layout to switch around. Now we check if the catalog is completely empty instead. If no example locations are configured, it is completely hidden.
In addition the button is now at the top of the page and not part of the table. I'm not sure if there was a reason for this quite hidden place.
If catalog is empty and examples configured:

If catalog is not empty or no examples configured:

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[x] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Looks like there way a discussion about the location of the button in https://github.com/spotify/backstage/pull/1883
The current locations is in my opinion hard to discover and the plus icon doesn't really tell what behavior lies behind it. An explicit button text seems to be more useful?
But I can keep the layout and just integrate the behavior changes if desired.

This is something I suggested before, so 👍


[Bug]: Logger Duplicate Handlers

Bug Description
In bench.ipynb, will see the same output repeated many times. At first, I thought it was the logger needing to be flushed, but I think it has to do with the way I use getLogger() inside set of classes all being imported.
https://stackoverflow.com/questions/7173033/duplicate-log-output-when-using-python-logging-module
Version
No response

Fixed by importing the logger from a separate file. Could be improved using some sort of singleton pattern(?)


Fixes #2784 - testGrid reports error yet it still passes CircleCI

Fixes #2764
This draft PR partially address #2764; it replaces an exact floating point compare (which should not have been used) with an approximate floating point compare. This prevents the 'testGrid' from reporting an error. However, there is still a problem with the python script that calls testGrid, failing to detect the non-zero exit code.

@clyne the non-zero exit code is being tested on line 125 in smokeTests.py.  I'm not able to reproduce what you're reporting.  Could you provide instructions on how to reproduce the failure you're seeing?

You'll need to ask @shaomeng for clarification. He was the one that reported the problem.  But make sure testGrid is actually generated a non-zero exit code.

Hi Scott, when you manually execute the test command reported in issue #2764 , do you see the reported output?

@shaomeng The smoke tests are passing on circleCI because we only test the grids listed below.  We can't test every permutation, so your 80x80x80 example indicates a new bug in the DataMgr.
2x2x2 4x2x2 8x2x2 7x7x7 8x8x8

@clyne EXIT_SUCCESS and EXIT_FAILURE are correctly being reported by testGrid, so I don't think there's another problem to fix here.

@clyne EXIT_SUCCESS and EXIT_FAILURE are correctly being reported by testGrid, so I don't think there's another problem to fix here.

OK. I think I see the disconnect here. @shaomeng thought that CircleCI was failing to report an error condition. However, @shaomeng was testing a configuration (-dims 80x80x80) that was not being tested by the test driver running on CircleCI. As @sgpearse points out, it's not practical to run all permutations of grid sizes. I do not believe that there is "another problem to fix here", only miscommunication. @shaomeng can you verify that I've summarized the events correctly? I think we can review this PR, which fixes the 80x80x80 grid problem, and move on.

You guys were right.  We were not exiting -1 on failed grid tests.  This is fixed in the above commit.


method with keyword name highlighted as keyword if dot is on previous line

TS and JS Grammar Extension version:  0.0.43 / latest
From https://github.com/Microsoft/vscode/issues/56975
Code
foo().
    bar().
    catch();

The catch method name is highlighted as a keyword instead of as an variable

This is by design because of design limitation of the tmLanguage syntax being able to lookup only single line.

Need to improve tmLanguage


Server mode: Add support for serving API over HTTP

Currently, the server can only be accessed via HTTPS. This makes it cumbersome to work with during dev and test.
Add support for accessing the API via HTTP. This should be disabled by default.

Closed via #986


feat(Alert): Add Alert component with close button

This PR adds an Alert component with 4 types (info, error, warning & success) and a closable X icon button.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade to actix-web 3.0

https://github.com/actix/actix-web/blob/master/CHANGES.md

Done in bf9d09d32134afb0e9575c4524dce6c79544889f


SCSS support

I'd love some scss syntax highlighting, I'm assuming that's what's meant by support but wanted to clarify incase that wasn't clear.

We hope that CSS and SCSS will be supported.

CSS support will land in Zed v0.59. I'm just going to change the title of this issue to focus on SCSS, so folks who are waiting on SCSS can continue to subscribe here.

I am using 0.8.x v and css seems to be available on the level of treesitter not langserver what is sort of show stopper.

I implemented most of this, but killed the PR since the tree-sitter grammar is filled with errors. Either we or someone else will need to work through updating the grammar before we can ship this.
https://github.com/serenadeai/tree-sitter-scss
I only got about 1/8th of the way through testing the examples in the SCSS docs before it was obvious upstream changes to the grammar will be needed.
If anyone wants to pick that up here were my notes so far.
Fix:
- The sibling selector `~` causes an ERROR
- Can't interpolate property names with `-`/`-#{$prefix}` (ERROR)
- Custom property names aren't marked with `function_name` or similar to allow correct styling.

Nice to have:
- support doc comments (///) (should be `doc_comment`

Otherwise I'll pick this back up after a few of the ones with accurate grammars are finished.


[communication] disable smoke tests

The sample is failing in smoke test runs. Tracking issue: #14820

Adding @lsundaralingam who is investigating the failures as part of OCE duty

#14823 should fix the failure.


put messages on queue even when paused to handle failovers

Failing FailoverIT in platform passes with this change. Merging the PR and triggering a release.


local block adapter doesn't work with storage namespaces

local.go Adapter.Put completely ignores the namespace of the passed-in object.  So if a repo is created on some adapter, all files are actually stored in the same local directory regardless of the namespace.
Meanwhile export is unaware of this, and cannot find the file.
Apart from fixing export, we should either refuse to namespace on adapters that do not support it, or fix them to support it.  (The latter may have backwards compatibility issues!)

@guy-har fixed this in #938.


Defer does not work when navigating between child routes

Reproduction
I was able to reproduce it here: https://stackblitz.com/edit/remix-run-remix-fxk98l?file=app%2Froutes%2F%24id.tsx

Navigate from / to /a. Notice that the deferred loader data is streamed and the fallback is shown (correct behavior).
Navigate from /a to /b. Notice that the navigation only happens after the deferred data is resolved (incorrect behavior).

System Info
Tried and reproduced it on Remix v2.0.0 and v2.3.1.

Used Package Manager
npm
Expected Behavior
Let's say we have an $id route, when navigating between different id parameters, (/a -> /b) then it should navigate to the new page once all non-deferred data has been loaded. The deferred loader data should be streamed, and the fallback be shown until resolved.
Actual Behavior
When navigating between id parameters (/a -> /b), defer doesn't seem to work. It shows the old page (/a) until both the loader and deferred loader data are fetched.

This is a common hiccup!  Remix is actually deferring properly here, but React's is re-using the Suspense boundary and not re-triggering the fallback since you're using the same component structure on /a and /b.  You can work around this by adding a key to the boundary to force react to render a fresh boundary and thus let the fallback re-appear:
<Suspense fallback="Loading deferred loader data..." key={useParams().id}>

Awesome, thanks for the explanation, @brophdawg11! Closing the ticket.
@ryanflorence, I think this could be worth documenting even though it's technically a React thing. Feels relevant to defer in Remix.

https://remix.run/docs/en/main/guides/streaming
https://remix.run/docs/en/main/guides/gotchas


mfellows/win2012r2 v1.0.0 missing box on Atlas

Appears to have been externally hosted and Atlas can no longer resolve the box address.

I think I have the box on my work machine - i'll try to upload today.

Box has been uploaded (finally). I haven't pulled the thing all the way back down, but running vagrant init mfellows/windows2012r2; vagrant up --provider virtualbox starts the download process.
Let me know how you go, closing for now.

The actual error I get when trying to download this version 1.0.0 "by hand" is that the Amazon bucket it was associated with no longer exists.
https://s3-ap-southeast-2.amazonaws.com/onegeekau/packer/windows2012r2.box

NoSuchBucket
The specified bucket does not exist
onegeekau
76E3BE65047B08BB

L0mmy3P8Zds+yZYB4VTMBmVQG3UcTvyMm0GQrNd0kbuih6sWtThnTzXf/O/pL1qO4c8gwtK+pIo=

Yep I removed it in a cleanup a while ago. The 1.0.1 is the correct version (there were issues with that box). I'll see if I can remove/deprecate it.


[Bug Summary] Not recognized from a subshell

I think this is related to #12.
BurntToast does not work from a subshell:
Steps to reproduce
1. Install BurntToast.
2. Open a PowerShell.
3. Run `New-BurntToastNotification` -> it works as expected
4. Run `powershell.exe "New-BurntToastNotification"` -> it does not work:
New-BurntToastNotification : The term 'New-BurntToastNotification' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ New-BurntToastNotification
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (New-BurntToastNotification:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Expected behavior
Calling BurntToast from a subshell summons a notification
Actual behavior
PowerShell can't find the command:
New-BurntToastNotification : The term 'New-BurntToastNotification' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ New-BurntToastNotification
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (New-BurntToastNotification:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Environment data
Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Microsoft Windows 10.0.19041
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}

Thanks for any help in advance!

It looks like you're calling Windows PowerShell 5.1 (powershell.exe) from
PowerShell 7.1 (pwsh.exe)
If you installed the module in pwsh it'll only be available in pwsh
(powershell.exe doesn't look in the pwsh.exe specific directories).
Can you confirm? Try 'Get-Module BurntToast -ListAvailable' in both
versions of PowerShell.
On Sun, Sep 13, 2020, 8:34 PM scrouthtv<EMAIL_ADDRESS>wrote:

Assigned #114 https://github.com/Windos/BurntToast/issues/114 to @Windos
https://github.com/Windos.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Windos/BurntToast/issues/114#event-3760228203, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVCGCUSYMOG6KCAGJXFRFTSFR7ZPANCNFSM4RKQ625A
.

Yes:
PowerShell Legacy:
PS C:\Users\x> echo $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

PS C:\Users\x> New-BurntToastNotification
New-BurntToastNotification : The term 'New-BurntToastNotification' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ New-BurntToastNotification
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (New-BurntToastNotification:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

PS C:\Users\x>

PowerShell Core:
PS C:\Users\lenni> echo $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Microsoft Windows 10.0.19041
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
PS C:\Users\lenni> New-BurntToastNotification
PS C:\Users\lenni>

And back to my previous problem:
PS C:\Users\lenni> pwsh.exe -Command "New-BurntToastNotification"

works as supposed.
Looks like this is a bug in PowerShell, thank you!


Update more translation

@lizaifang Can you re-generate the php file, I found some words or phrase are missing.


TINKERPOP-1307: NPE with OLTP nested group() in an OLAP group() traversal

https://issues.apache.org/jira/browse/TINKERPOP-1307
When an OLAP traversal has a group() that contains, nested another group(), the latter group() is OLTP, but due to transient declarations, a null pointer can arise. To rectify this, GroupStep.GroupBiOperator no longer passes around Traversal and instead, 4 types: Traverser, TraverserSet, Pair<TraverserSet,Object, Object, where Object is the current barrier of an internal Barrier. Two complex nested group tests were added to demonstrate that things function as expected and there are no longer NPEs.
This change made group() a bit slower, but not by much and now the code is safer. For a play test I have, the OLTP speed (which is the important one) went from 436ms to 456ms. Again, no biggie.
CHANGELOG
* Fixed a `NullPointerException` bug around nested `group()`-steps in OLAP.

mvn clean install and integration tests pass.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop .................................. SUCCESS [4.643s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................ SUCCESS [2.240s]
[INFO] Apache TinkerPop :: Gremlin Core .................. SUCCESS [36.764s]
[INFO] Apache TinkerPop :: Gremlin Test .................. SUCCESS [11.672s]
[INFO] Apache TinkerPop :: Gremlin Groovy ................ SUCCESS [39.749s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test ........... SUCCESS [7.219s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ........... SUCCESS [3:24.052s]
[INFO] Apache TinkerPop :: Gremlin Benchmark ............. SUCCESS [4.156s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................ SUCCESS [10:46.080s]
[INFO] Apache TinkerPop :: Spark Gremlin ................. SUCCESS [6:40.139s]
[INFO] Apache TinkerPop :: Giraph Gremlin ................ SUCCESS [2:48:03.627s]
[INFO] Apache TinkerPop :: Neo4j Gremlin ................. SUCCESS [1:08:44.849s]
[INFO] Apache TinkerPop :: Gremlin Driver ................ SUCCESS [10.102s]
[INFO] Apache TinkerPop :: Gremlin Server ................ SUCCESS [13:20.898s]
[INFO] Apache TinkerPop :: Gremlin Console ............... SUCCESS [1:24.523s]
[INFO] Apache TinkerPop :: Gremlin Archetype ............. SUCCESS [0.133s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ....... SUCCESS [5.907s]
[INFO] Apache TinkerPop :: Archetype - Server ............ SUCCESS [10.589s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4:34:37.829s
[INFO] Finished at: Mon May 23 22:03:45 MDT 2016
[INFO] Final Memory: 99M/680M
[INFO] ------------------------------------------------------------------------

VOTE +1

Did some more benchmarking of master/ vs. this branch The times are "the same."
// result: {cover=368579, =160968, original=771317}
// old vs. new

// STANDARD

Big Values -- by(songType)
group: 432.720949 vs.<PHONE_NUMBER>999999
group:<PHONE_NUMBER>9999997 vs.<PHONE_NUMBER>

Big Keys -- by(name)
group: 426.047715 vs.<PHONE_NUMBER>9999995
group:<PHONE_NUMBER> vs.<PHONE_NUMBER>

// COMPUTER

Big Values -- by(songType)
group: 54.3288408 vs. 61.9877934
group: 90.81696539999999 vs. 84.366255

Big Keys -- by(name)
group: 31.852916 vs. 31.7736176
group: 53.63283839999999 vs. 60.662042799999995

Full test suite passed, query times look good ...
VOTE: +1

All tests pass with docker/build.sh -t -n -i
VOTE +1


pe-parse: init at 1.2.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107506 1

1 package built:

pe-parse

pe-parse is a library, the dump-pe program is rather an extra thing

pe-parse is a library, the dump-pe program is rather an extra thing


Updates to regional support

According to email from Bogdan -

On the public cloud, the regional authority was “region.login.microsoft.com”. However, due to DNS issues, we must go back to “microsoftonline.com”. The authority will be “region.r.login.microsoftonline.com”.
On sovereign, the rule remains “region.sovereign_authority” but try to use the preferred authority value, as hardcoded in MSAL (i.e. don’t do instance discovery just for this)
Avoid doing instance discovery when regional is used and the authority is known (hardcoded) to MSAL.

This was addressed in https://github.com/AzureAD/microsoft-authentication-library-for-java/pull/504, and should be fixed as of the recent 1.12.0 release.
If anyone is still running into issues with regions or if there are any related issues feel free to re-open this thread or open a new one.


Fix issue #73: Deadlock when using finish and async_await

This fixes the issue #73 considering that root finish can run in core_work_loop so all the workers cannot  get out of the loop by 'hclib_signal_join'

@sbak5 thanks for taking a look at this -- I'm sure this has been a tough one to think through.
Before opening pull requests, it's always a good idea to run all of the c and cpp tests we have to verify no regressions have been introduced. I just tried that, and it looks like there's now a failing assertion in cpp/finish0. There may be other failing tests, I only took a quick look. I believe the c/memory/allocate test is now hanging as well (see the Travis builds, which hit that error). We'll need those issues resolved before merging (as well as any other failing tests), as both of those tests pass on the master branch.
You should be able to simply use the test_all.sh scripts under the test/c/ and test/cpp/ directories to run all of the tests.
Thanks!
Max

Hello, Max,
Yeah, my patch doesn't consider the example where future is used.
I'll push a patch to resolve the case to resolve the issue.
Thanks,
Seonmyeong Bak

I've pushed a fix to resolve the build errors.
The main issue was that the termination of runtime was not synchronized.
I added a task which is dependent on the root task so that the task signals other workers the root task is completed (now the counter vale of the root finish is final). After this signal, we can use the counter value of the root finish as our termination condition.

@sbak5 looks good, all the tests are passing on my laptop as well.
one final step: could you add Sriraj's original deadlock example as a test in the appropriate directory (I can't remember if it was c or cpp)? That way, we prevent against future regressions.
Thanks for working on this!

I just added. The name of the test is nested_finish_async_await.cpp in test/cpp

@sbak5 looks like the build failed/hung? could you try rerunning the Travis tests?
https://travis-ci.org/habanero-rice/hclib/jobs/545539336

How can I rerun the travis test? Do I need to recommit?

@agrippa The build of this commit is OK this time.


Fix ko/ go weirdness

This PR does the following:

provides both the dir and main options to ko and gorelease
disabling Go workfiles
adds a lot of extra validation on the dir and main options

This fixes the following issues for me:

builds would not work for go submodules
ko was ignoring the config in the generated ko_config.yaml
the build would behave differently with or without a go.work file present

/approve


Why use PyTorch for simple machine learning models (linear regression, logistic regression, ...) instead of scikit-learn ?

Hello,
I was curious to know why you implement all the machine learning models in PyTorch instead of another library like scikit-learn ? Is it because it's easier to have all the models implemented in the same way ? Do you have plan to be compatible with other machine library in the future ?
Thanks,
Mohamed Amine

Hi @MohamedLEGH, the main reason for implementing all of them in pytorch is convenience! In particular, the TorchModelHandler class can handle torch models regardless of the architecture. Clearly, if the merge or the update are not the standard ones they have to be changed (see AdaLine and Pegasos). I have no plans in making gossipy compatible with sklearn (or other libraries), however feel free to contribute to gossipy, if you like :)


zivid.Frame() Function and versioning

Hi,
I want to use the "zivid.Frame(path_dir).point_cloud()" Function but I always get the error "RuntimeError: Failed to load .zdf file. To load this file you may need to update to a newer version of Zivid SDK.".
I am working on Ubuntu 18.04
Initially I had the 2.6.1 SDK and <IP_ADDRESS>.6.0. zivid version. Then I upgraded the zivid version to <IP_ADDRESS>.6.1. (python 3.7.3) which didn't help.
Then i downgraded zivid back to <IP_ADDRESS>.6.0 (python 3.6) and downgraded the SDK to 2.6.0 which also didn't help.
Thank you!

Hi,
Since you have closed the issue I suppose you have resolved it?

Hi :) I accidentally posted from the wrong account, sorry about that. I reposted it here: https://github.com/zivid/zivid-python/issues/166 as I think it is a more general question.


Install PostgreSQL on arm64 device

I was trying to run your todo app tutorial on a Pinebook Pro (aarch64, arm64 device) but unfortunately the official postgresql helm chart only supports pc architecture.
Expected Behaviour
PostgreSQL Arm64 is used
Current Behaviour
Arkade exits with an error
Possible Solution
On https://hub.docker.com/r/arm64v8/postgres there seems to exist an arm64 postgresql version - this would be great if it would be supported somehow (new helm chart using this repo)
Steps to Reproduce (for bugs)

Use arm64 device
arkade install postgresql

Node architecture: "arm64"
Error: only Intel, i.e. PC architecture is supported for this app

Context
Doing the Todo App Golang tutorial with k3d on a Pinebook Pro
Your Environment
k3d
kubectl version 1.17

Operating System and version (e.g. Linux, Windows, MacOS):

Linux pine 5.6.0-0.42-MANJARO-ARM #1 SMP Sat Mar 14 21:19:14 CET 2020 aarch64 GNU/Linux

NAME="Manjaro-ARM"
ID=manjaro-arm
PRETTY_NAME="Manjaro ARM"
ANSI_COLOR="1;32"
HOME_URL="https://www.manjaro.org/"
SUPPORT_URL="https://forum.manjaro.org/c/manjaro-arm/"

What arkade version is this?

0.2.2

Hi thank you for using my blog post and for your interest in this project. The company (Bitnami) that maintains docker images and helm charts for Kubernetes as far as I am aware is not providing support for ARM.
The error you are seeing is because we are aware of this fact and are trying to help you avoid any confusion by installing incorrect charts to your computer.
You can get managed SQL on digitalocean, the rest of the tutorial should work the same.
Does that make sense?
Alex

#942 Bitnami postgresql chart now supports arm64

#942 Bitnami postgresql chart now supports arm64

Hey Joe,
How do I get that install on my MAC?

#942 Bitnami postgresql chart now supports arm64

Hey Joe, How do I get that install on my MAC?

The following command installed the bitnami chart in my Rancher Desktop cluster on Apple M1
ark install postgresql
For the client install, I followed instructions at https://postgresapp.com/


Increment Service Bus versions after October 2022 hotfix release

API change check
API changes are not detected in this pull request.


Data Dictionary Profiles - NHS England Testing

NHS England to test the Profiles created by James W. and feedback.

Document 1 - DataDictionaryProfile_comments.xlsx
Document 2 - DataDictionaryProfile_comments_MC_commented.xlsx

10/12/21 - James demonstrated Mauro on 7th December, which included a brief look at the properties. These will be tested as part of the testing plan.

Profiles are working, new ones have been introduced since the project was paused, including key Attributes. Profiles for all items types will be tested.


Debug Flag does not print debug logs

What happened?
devspace deploy --debug does not change the log level and I still only see info or higher messages.
What did you expect to happen instead?
devspace deploy --debug shows actual debug level log entries.
How can we reproduce the bug? (as minimally and precisely as possible)
My devspace.yaml:
Just use the project in examples/quickstart.
Local Environment:

DevSpace Version:  6.3.3
Operating System: mac
ARCH of the OS: AMD64
Kubernetes Cluster:
Cloud Provider: aws
Kubernetes Version: Client Version: v1.24.2, Kustomize Version: v4.5.4, Server Version: v1.25.12-eks-2d98532

Anything else we need to know?
It also doesn't seem that an actual stacktrace is printed out on an error, is it limited to specific errors?

Hello! Thanks for reporting this issue. I can't seem to reproduce it with 6.3.3 or on the main branch. Here's a copy of the output I got, perhaps you could provide your log output as well?
> cd examples/quickstart
> devspace deploy --debug
16:49:10 info Using namespace 'loft'
16:49:10 info Using kube context 'kind-kind'
16:49:10 debug Use config:
version: v2beta1
name: quickstart
deployments:
    quickstart:
        name: quickstart
        helm:
            values:
                containers:
                    - image: loftsh/javascript:latest
dev:
    my-dev:
        name: my-dev
        imageSelector: loftsh/javascript:latest
        sync:
            - path: ./
              excludeFile: .gitignore
        terminal:
            command: ./devspace_start.sh
        ssh: {}
        ports:
            - port: "3000"
        open:
            - url: http://localhost:3000

16:49:10 debug Run pipeline:
name: deploy
run: |-
    run_dependencies --all
    ensure_pull_secrets --all
    build_images --all
    create_deployments --all

16:49:10 run_dependencies --all
16:49:10 Marked project excluded: quickstart
16:49:10 ensure_pull_secrets --all
16:49:10 build_images --all
16:49:10 create_deployments --all
16:49:10 Deploying 1 deployments concurrently...
16:49:10 deploy:quickstart Skipping deployment quickstart
16:49:10 Deploying 0 deployments concurrently
16:49:10 debug Wait for dev to finish


Customize Windows 10 Start and taskbar

NO!  We will not become coders so we can customize an enterprise Taskbar.  This should be a simple task for creating consistency.  What we WILL do is find registry hacks to just remove and restrict features.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 061157dc-8fc8-3f9d-c01f-37f22fbdf1c7
Version Independent ID: 0b0b6797-9367-eb7c-22ef-5f2b8bbfe592
Content: Start layout XML for desktop editions of Windows 10 (Windows 10)
Content Source: windows/configuration/start-layout-xml-desktop.md
Product: w10
GitHub Login: @jdeckerMS
Microsoft Alias: jdecker

@cannonwill It would be helpful if you submitted how you think it ~should~ work through the Feedback Hub so your input goes directly to the engineering team for that feature, thanks.


Vet clinic database: add join table for visits

In this project Milestone -:

Created vets, specializations and visits tables.
Inserted data into vets, specializations and visits table.
Many to many relationship created by created Join-table(Link tables).
Queries for answering analytical question.

Screen shots for queries attached below:

Thanks @emmanuellekamwa :)


Implements numpy.linalg.cond().

This patch adds an implementation of numpy.linalg.cond.
It also:

Refactors the code to pull out a function for computing
singular values as these are used in multiple places.
Adds tests for numpy.linalg.cond.

Current coverage is 86.97% (diff: 65.21%)

No coverage report found for master at 024b8dc.

Powered by Codecov. Last update 024b8dc...f771616

This is good, I'm merging. Thank you!


Network Version 21 upgrade (mainnet)

Issue summary
NV21 Watermelon upgrade for mainnet is scheduled for 2023-11-28. Once the actors' bundle is released and a specific epoch is scheduled, add the bundle to assets and the upgrade to the mainnet schedule
Other information and links
Calibnet upgrade: https://github.com/ChainSafe/forest/issues/3422
Schedule tracking: https://github.com/filecoin-project/community/discussions/74#discussioncomment-7274188

Mainnet epoch and date: 3431940 , 2023-11-29T13:30:00Z.


Typo in method name

SecurityKit.swift has a typo in the name of the method:
isRevereseEngineeringToolsExecuted
it should be:
isReverseEngineeringToolsExecuted
Some places in the code have ReverseEngineering written the correct way though.

Hi, thank you so much for informing me. I have fixed the typo.


YouTube videos crash when rotating iPhone screen

Open a post with an embedded YouTube video. Play video and go full screen. Rotating the screen stops the video and returns to post view.
I’m using NNW 6.0.2.

Duplicate of https://github.com/Ranchero-Software/NetNewsWire/issues/2369.


WFLY-12777 Stateful bean with @StatefulTimeout value -1 should not ti…

…meout or removed
Fixed org.jboss.as.ejb3.cache.simple.SimpleCache class to properly handle stateful-timeout value -1 (never timeout).
JIRA: https://issues.jboss.org/browse/WFLY-12777

@pferraro could you please review this change also.

Frankly, this particular detail in the spec is a bit illogical...
@StatefulTimeout(value=-24, unit=TimeUnit.HOURS), is invalid, but
@StatefulTimeout(value=-1, unit=TimeUnit.DAYS), while logically equivalent to the above, is valid and means the bean never times out.
iMO, we ought to clean this up in future versions of the EJB spec.  Really, any negative value should to be interpreted in the same way.

@pferraro thanks.  I'll update DistributableCache, and loosen the condition to allow for all negative numbers.

I've updated the PR based on the review comments.  Please review again.


Building sds-server binary in container

I found that our previous build method may encounter libc incompatibility problems in systems other than ubuntu20.04 (Sinece we build on the host and run in the container). So transfer all the compilation to the docker build process to avoid such problems.

LGTM


Localizable string

Hello
I have these errors when not using my request API correctly
"Localizable string "Request failed: unacceptable content-type: %@" not found in strings table "AFNetworking"
I would like to catch this in french, spanish, etc ....
How/Where can I do this ?
Have a nice day
Francois

I think the best way would be to catch AFNetworking's errors and create a user-friendly localised error and show that to the user instead.


Fix binding bindables potentially transfers values while it's disabled

Resolves #3218
This fixes the issue by transferring the values directly via Set... methods, which bypass the disabled check.

Did those failing tests somehow pass for you locally?

The tests are failing because this is actually a breaking change in terms of semantics of BindTo(). Before, BindTo() would adhere to the general bindable rule of "if binding to the other bindable doesn't change the current value, don't trigger value change events", which is no longer the case when using Set{Value,DefaultValue,Disabled}, which propagates unconditionally. As seen by the test results breaks the interactions of BindTo() and bindable leasing, among other things.

Yep, that's precisely it. I'm just horribly confused how this made it to PR state without that being realised, since bindables are one of the areas we have pretty flawless test coverage.

The tests are failing because this is actually a breaking change in terms of semantics of BindTo(). Before, BindTo() would adhere to the general bindable rule of "if binding to the other bindable doesn't change the current value, don't trigger value change events", which is no longer the case when using Set{Value,DefaultValue,Disabled}, which propagates unconditionally. As seen by the test results that breaks the interactions of BindTo() and bindable leasing, among other things.

Ah, my bad on this one, pushed things blindly.
Should be good now, one thing to note though is that the equality comparer inside Set...() methods uses the current value instead of previousValue for checking (eg: this.value instead of previousValue), having 2 things that should logically be the same but are coming from different members doesn't sound good to have.
Not quite sure what to do with it, I still don't get why previousValue exists in the set methods, bindables should never be desynchronised unless I overlooked something.

Tests disagree, the newest version still apparently breaks leasing. Did you run them all before pushing?

Yeah... I haven't, looking into it.

Closing this as I think it's better to resolve this with the BindableProperty refactor rather than touching on the existing value propagation logic.


changing the website's resources API call to call one of our netlify functions

Currently the website asks an API endpoint on Nate Spilman's personal django server ask for the resources data. We'll build the resource get call in Node via a Netlify function and then move the api end point on the resources page to the netlify function.

Closing issue for larger overall "we need a data store" issue.

Just for ease/cross referencing that's #30 (I believe)


Removed (most) QR code scanning related processes

Just something to note, I'd recommend that rather than creating a new branch called 2025-restructure you can just rename main to 2024 and then create a new branch called main that you can push the 2025 restructure code to. This makes it easier for change tracking in my opinion and is just a better flow.


Bluetooth: controller: Fix controller address check

Fix controllers address check in cases of controller-based privacy.
When controller has been instructed by the host to use privacy
the controller should look up the peer identity address and generate
an address based on the local IRK. In the case where no match
is found or the local IRK is all zeroes the controller shall use
the fallback address. If the fallback address is not valid the
controller shall return invalid params.
This commit fixes these issues:

Starting a private advertiser without valid random address set
but a valid local IRK exists. In this case the advertiser should
be able to advertise using the RPA regardless of a valid random
or public address.
Starting a private advertiser with a fallback to the public
address type or an adveriser using public address  does not
check if a valid public address exists. The host cannot
advertise with an all-zero public address.

Signed-off-by: Joakim Andersson<EMAIL_ADDRESS>

This is related to: https://github.com/zephyrproject-rtos/zephyr/pull/21525

Sorry for the delay, I had a problem with my image/target yesterday, so this morning I tried this in HCI/DDI/BI-06/06 and they both pass. Thanks @joerchan

Thank you for the update @erbr-ot