RFC: drop mutation of IncomingMessage owned fields, write only to new, augmented fields

Problem
express mutates req.url, and saves the un-mutated version onto originalUrl, making URL driven generic middleware hard to design.
Ref: https://github.com/chimurai/http-proxy-middleware/pull/723
Apologies if this topic has already been discussed, I did execute a cursory search and didn't see it, but I miss things time to time.
Context
http.IncomingMessage is the http module's owned memory, and thus could be considered memory not open for writing. The writing to this memory prevents me from fixing problematic typescript issues in http-proxy-middleware. To make http-proxy-middleware generic is to decouple it from all frameworks that it supports--express, connect, raw http, koa, fastify, ...the works!
However, because express mutates req.url, I cannot trust http.IncomingMessage::url, and either have to:

burden users with passing to HPM the same prefix they  use in app.use(prefix, ...), then additionally track that prefix internally to the HPM lib, or
have express conditionals within HPM that sniff specifically for indicators of this framework, and use alternate logic.

this is the current state of http-proxy-middleware, but to make it play nicely with other server providers, we're now trying to avoid this

Solutions

write to new, owned memory only:

// GET /api/foo/bar
req.url // untouched, /api/foo/bar

app.use('/api', ...)
req.express.url // /foo/bar
req.express.base // /api

don't mutate URL ever, at all

over functions for users to derive relative path

offer a .relativePathname, yielding req.url - sum(...nestedPrefixes)

Hello, and sorry you are having trouble. This has been discussed prior and it is a very core feature of express and won't be changing as it is a critical feature for how middleware works.
If you are trying to solve a specific problem, we are happy to help. I suggest perhaps opening a new issue describing the exact issue you are trying to solve so we can assist and perhaps help guide on if there is a feature or bug in express from there.

I'll also add that the argument to "do not mutate properties that are part of http.IncomingMessage" are likely mute, as this is a hugely breaking change to middlewares out there that will likely need a phased migration, and Express itself will by that time not even be using http.IncomingMesage in order to support http/2, meaning req.url would acrually belong to express proper anyway, and not http.IncomingMesaage :)

If you are trying to solve a specific problem, we are happy to help. I suggest perhaps opening a new issue

I am. I'd be happy to add greater details as requested. Please kindly ack that I did describe the problem in the # Problem + # Context sections. A new issue will look much like the current one, so to best serve you, please let me know where you'd like to me expand on.

not the appropriate starting place for such a conversation.

Respectfully, why not? I described a problem, then provided ideas & possible fixes to the problem. Your replies do not address the merits of the issue, which is fine. You owe me nothing (a random dude on the internet). I get that. But as a daily participant across OSS projects, GitHub issues are precisely the place for such conversation, in my experience.

Asking to remove a core feature thay would break the entire ecosystem is unfortunately

I understand migrations can be tedious. Nonetheless, SemVer, versioning at large, hedge this.  I read this remark as "we can't do breaking changes", and wasn't clear if that's what you really meant, or ...something else perhaps.

to support http/2, meaning req.url would acrually belong to express proper anyway, and not http.IncomingMesaage :)

I'll trust your judgement here, but perhaps you'd be willing to help me understand further? Using the below as context,
const http2 = require("http2");
const fs = require("fs");
const server = http2.createSecureServer({ /* snip */ });
server.on("request", (req) => {
  req.url; // Http2ServerRequest::url
});

I'd assume that a req reference may be still be captured and exposed by express in the future? For instance, ATM express gives us (req, res, next) => .... unsure what the http2 intfc looks like, but is req now hidden?

Hi @cdaringe I took a look at your referenced issue, and it seems to me that the issue you are running in to is working against the Express mounting API (app.use), rather than integrating it. For example, a proxy module like app.use('/api', proxy('http://localhost')) would be expected to proxy http://localhost/api/foo to http://localhost/foo in the Express API. It seems that the middleware is re-inventing a lot of the path removal and such Express API already provides, which is what seems to be at odd with the req.url alteration that app.use provides. What is the specific reasoning for doing that? It seems that if the module worked with the Express API rather than against it, there would be no need to ever reference req.originalUrl in that middleware as far as I can tell.

I'd assume that a req reference may be still be captured and exposed by express in the future? For instance, ATM express gives us (req, res, next) => .... unsure what the http2 intfc looks like, but is req now hidden?

That is correct, or perhaps as req.raw like other frameworks, but the actual Node.js request/response will no longer be the object that is actually passed around; at best it is a reference to one.
If you really want to focus on breaking the existing req.url in order to support your use-case, my point is that with the migration for http/2 + beyond uplift would likely already solve your use-case of getting an unmodified original object from the Express API in the same time frame, but would not require breaking the ecosystem of existing middlewares.

Hey Doug, great points. I was maintaining existing functionality, but in retro I think the existing functionality is exactly as you describe. Will take it up off yonder


Install / Set Up Instructions?

I'm not too familiar with docker & node... mind jotting down some quick set up / install instructions?

I've added some setup instructions to the readme, let me know if you need more information.


How to get new deposit address ?

How to get new deposit address ?

Could you clarify if you need assistance with getting an existing deposit address or generating a new one?
To retrieve your existing deposit address, you will need to use the depositAddress function, as shown in the following example: https://github.com/binance/binance-connector-node/blob/master/examples/spot/wallet/depositAddress.js
Please note that generating a new deposit address can only be done through the User Interface.


docs(project): add initial setup for docs publishing

added initial configuration for documentation static-site generator
added index file based on the repo's README

Awesome start to standardizing the documentation in this project. Thank you! I'm not sure you are aware, but there is a site published on the gh-pages branch. How do you think this framework and that page should work together?

there is a site published on the gh-pages branch. How do you think this framework and that page should work together?

@SyntaxRules Yes, I've already inspected it a bit, and, as I understood, you're using a custom-written framework with mustache and bootstrap. That's OK for a small presentation-like website. If you are thinking about visual or functional updates (or even change framework completely), I don't mind. I will help with both activities. Documentation can also be integrated into this framework.
My question is - how html files are getting generated? I checked source files, but I didn't find any script related to building docs or deploying html to gh-pages. Or these files were pushed to the branch manually?
My base idea is to create CI/CD process for documentation to automatically build it on each commit/pull request (we can further configure CI/CD to update docs on specific commits). In this scenario, we can build docs using a static-site generator and then deploy html files under the /docs route (for example) as a part of the website framework files.
As a result, we will have website files hosted on the / route and documentation files hosted on the /docs route (physically, the docs sub-folder). The documentation section on the website will no longer be necessary.

For the website, I wrote a small blog-like custom framework, using moustache, bootstrap and showdown. I would prefer not to change the framework of the website for now since it's super optimized for SEO. (it can be improved, though. The mobile presentation, for instance, is not very neat). Also, there are a few third party tools that pull directly from the website to generate pub in facebook and other social platforms (which are important for our social network manager person, @Sophie-OS ).
The HTML is written and uploaded manually. All blog posts are markdown files which get loaded and parsed on the fly.
Ideally the same system should be used for documentation. Since mkdocs and "showdown site framework" use markdown to generate html, they can share the same source files.
And then you would have a docs directory in the base repo, with the static generated documentation html files. On the website, the md source files would be dynamically loaded and parsed.
Does it make sense?

@tivie

it can be improved, though. The mobile presentation, for instance, is not very neat

Currently, I finished the same activity within my own project, so I can help with that.

The HTML is written and uploaded manually

I believe we should think on making the process of building the website along with the documentation automatically. This will dramatically reduce the time taken to review and deploy new website/documentation changes. Furthermore, we can set up docs preview (for example, for pull requests) to see how changes look like before deploying them to production.

they can share the same source files

They definitely can, but I think the website doesn't have to use documentation source files. If I understood you correctly, in this scenario, we would need to write custom build logic to convert and manage documentation files. This looks like reinvention of a wheel. Instead, we can incorporate mkdocs into the framework to build docs html files and then point the router to the index file inside the docs folder.
Hope this makes sense.

I believe we should think on making the process of building the website along with the documentation automatically. This will dramatically reduce the time taken to review and deploy new website/documentation changes. Furthermore, we can set up docs preview (for example, for pull requests) to see how changes look like before deploying them to production.

I think I didn't do a very good job explaining. Only the static assets are uploaded manually (the template written in HTML). Everything else is updated automatically, through http requests to the github api. For instance:

website main page, the version in the download button is updated automatically, according to the latest version in the repository.
releases page, it fetches the changelog and is updated automatically. As soon as you tag and create a new release in the github repo, the webpage updates.
blog page, there's a directory in the ghpages branch called blog with a bunch of md. The page fetches those files and shows them. If you push a new md file to that directory, the page will show it.

This means you don't even need to build anything. When you release a new release, the website will fetch directly from the github API.

They definitely can, but I think the website doesn't have to use documentation source files. If I understood you correctly, in this scenario, we would need to write custom build logic to convert and manage documentation files.

Not really. That framework already parses markdown files using showdown. We might need to implement some type of navigation, which could be obtained from the mkdocs config file.

My base idea is to create CI/CD process for documentation to automatically build it on each commit/pull request (we can further configure CI/CD to update docs on specific commits). In this scenario, we can build docs using a static-site generator and then deploy html files under the /docs route (for example) as a part of the website framework files.

Btw, how would this be implemented? Would we need to add a python dev dependency? As far as I can tell, there's no native javascript port of mkdocs

@tivie Thanks for the explanation regarding the website.
Regarding navigation, I believe it's not worth implementing something custom - it's better to use already existing solutions. Furthermore, mkdocs has everything we need out-of-the-box. It is a mature and actively developing solution that should fit our needs pretty well.
You can check the home page of the project, it uses a custom template for the home page, so it is possible to combine "showdown framework" to handle routing and use mkdocs to generate documentation exclusively.

Btw, how would this be implemented?

To better understand how documentation deployment works, you can check the actions YAML file of my own project.
In terms of actions, to generate the documentation for showdown, we can use the Docker image. I would definitely try to combine the "showdown framework" with mkdocs. I've never done something like this before, it is an interesting approach.

@tivie @SyntaxRules I've successfully combined showdown website with mkdocs documentation. Please check the proof of concept in my fork: http://mister-gold.pro/showdown/

Good job! Thank you! Seems fine to me.
So, if I understand correctly, the workflow works like this:

the documentation sources files (in markdown) are located in master:/doc/*
when a new release is created, it triggers the workflow
it grabs those sources files and generates the html documentation in ghpages:/doc/*

right?
Btw, in your repo there's a website directory that seems to be a copy of the ghpages. What is that?

the documentation sources files (in markdown) are located in master:/doc/*

Yes. master:/docs/ to be accurate

when a new release is created, it triggers the workflow

Yes, this is one of the possible cases. Here is a list of all events that trigger workflows.

it grabs those sources files and generates the html documentation in ghpages:/doc/*

Not quite. The generator takes the files defined in docs configuration from the input folder and creates html documentation in the output directory. Deployment to GitHub Pages is a separate action.

Btw, in your repo there's a website directory that seems to be a copy of the ghpages. What is that?

You said that those website files are uploaded manually. So I decided to automate this step by including the website folder into the repo. During the Actions workflow, the website folder is copied into the same folder where html docs are generated (public). The public folder is then deployed to GitHub Pages.
Furthermore, as docs generation is automated via actions, if you try to deploy them, these files will override the existing files in the gh-pages branch. It means that website static files should be deployed along with the documentation files. So, the proposed workflow is a way on how to do it.

You said that those website files are uploaded manually. So I decided to automate this step by including the website folder into the repo. During the Actions workflow, the website folder is copied into the same folder where html docs are generated (public). The public folder is then deployed to GitHub Pages.
Furthermore, as docs generation is automated via actions, if you try to deploy them, these files will override the existing files in the gh-pages branch. It means that website static files should be deployed along with the documentation files. So, the proposed workflow is a way on how to do it.

I see... I'm not a big fan of mixing code and presentation. Having the website files in the master branch means changes to the website would create a commit in master branch, and that might clog the commit history, specially when testing stuff in the website. It will also make merges from develop branch to master more clunky.
@bandantonio @SyntaxRules @Sophie-OS What do you think about moving the website and documentation to another repository, namely showdownjs/showdownjs ? Works nice with gihub pages. https://pages.github.com/
Also, it might be possible to keep docs source files in the main repo and trigger an event that pushes to showdowjs/showdowjs
I think this way we can implement the awesome  @bandantonio doc system and keep the main repo clean. What do you guys think?

@bandantonio @SyntaxRules @Sophie-OS What do you think about moving the website and documentation to another repository, namely showdownjs/showdownjs ? Works nice with gihub pages. https://pages.github.com/

I think that is the best idea. Currently I don't have permission to change or merge to master (and I don't want to), so it would be a pain to maintain the website. Having a new repo would make things easier.

I see... I'm not a big fan of mixing code and presentation.

I don't like it either. However, it is totally acceptable to have a couple of website assets and documentation source files next to the code.

Having the website files in the master branch means changes to the website would create a commit in master branch, and that might clog the commit history, specially when testing stuff in the website.

I don't see a problem here. You can checkout to a separate branch and do your cool things there. When you're done, you can squash all your commits and create a clean pull request. Basically, the same flow applies to the docs as well.
As an alternative, we can set up a separate branch for the website (for example, website, website-master, or gh-website) and keep all the stuff there. I think it would be possible to set up a workflow when the website files will be taken from that branch, whereas documentation source files will be taken from the master branch.
Having a separate repository to keep the website and html docs is also great, but this would require an extra effort to set up the proper workflow (an external event to trigger website and docs publishing).

Having a separate repository to keep the website and html docs is also great, but this would require an extra effort to set up the proper workflow (an external event to trigger website and docs publishing).

I think that is the cleaner solution. I will create a new repo, and give you the appropriate permissions

@bandantonio https://github.com/showdownjs/showdownjs.github.io
I've deployed the website just for testing purposes and it's working correctly. You have admin access and green light to implement your solution.
I've also added @Sophie-OS as admin.
And thank you very much for your help!


32 character limit for side bar CRD size, large objects (long CRD names ) get cut off

Preamble
Thank you so much for this wonderful project :) it saved my life today when navigating a sea of CRDs.. Here's the first issue i found ... im sure more to come.  Happy to contribute a fix but time is limited for me as im commited to other things for my day job.
what was expected
Assuming arbitrarily long CRDs would be viewable/copyable from the octant sidebar.
what was observed
CRDs w longer then 32 characters are not viewable in octant's sidebar, making exploring a complex cluster w/ lots of CRDs a little tricky
Deets
In the UI, If you have long CRDs, like .
bgpconfigurations.crd.projectcalico.org                   2020-01-13T22:26:38Z
bgppeers.crd.projectcalico.org                            2020-01-13T22:26:37Z
blockaffinities.crd.projectcalico.org                     2020-01-13T22:26:37Z
clusterinformations.crd.projectcalico.org                 2020-01-13T22:26:38Z
clusters.cluster.x-k8s.io                                 2020-01-13T22:26:42Z
felixconfigurations.crd.projectcalico.org                 2020-01-13T22:26:37Z
globalnetworkpolicies.crd.projectcalico.org               2020-01-13T22:26:39Z
globalnetworksets.crd.projectcalico.org                   2020-01-13T22:26:39Z
hostendpoints.crd.projectcalico.org                       2020-01-13T22:26:38Z
ipamblocks.crd.projectcalico.org                          2020-01-13T22:26:37Z
ipamconfigs.crd.projectcalico.org                         2020-01-13T22:26:37Z
ipamhandles.crd.projectcalico.org                         2020-01-13T22:26:37Z
kubeadmconfigs.bootstrap.cluster.x-k8s.io                 2020-01-13T22:26:43Z
kubeadmconfigtemplates.bootstrap.cluster.x-k8s.io         2020-01-13T22:26:43Z
machinedeployments.cluster.x-k8s.io                       2020-01-13T22:26:43Z
machines.cluster.x-k8s.io                                 2020-01-13T22:26:44Z
networkpolicies.crd.projectcalico.org                     2020-01-13T22:26:39Z
vsphereclusters.infrastructure.cluster.x-k8s.io           2020-01-13T22:26:44Z
vspheremachines.infrastructure.cluster.x-k8s.io           2020-01-13T22:26:44Z
vspheremachinetemplates.infrastructure.cluster.x-k8s.io   2020-01-13T22:26:45Z

Then you can't see them in the side bar.  It looks like 32 characters is the limit for the sidebar.  Can we make it resizable ?
Examples of CRD's that work ok
ippools.crd.projectcalico.org  (31 chars)                           2020-01-13T22:26:38Z
machinesets.cluster.x-k8s.io (32 chars)                              2020-01-13T22:26:44Z

Our new navigation (which will be in the next release), shows the entire name of the CRD even when they are very log.

closing this as fixed by #812


Update to Rails 5.2

Coverage remained the same at 91.667% when pulling 2aff050bea99e41180674d69f575065d759a64f3 on rails52 into 7de2ae846b46cf8b5619157111b2d97cb091dd61 on master.

Coverage remained the same at 91.667% when pulling 2aff050bea99e41180674d69f575065d759a64f3 on rails52 into 7de2ae846b46cf8b5619157111b2d97cb091dd61 on master.


backing error on cond-> if transform

only seems to occur in this case; guessing syntax error in transform is causing info loss

fixed in 62c9a6c0a7f92cfb63df7a669541be7b1edbdfee


Fix unreachable code from test_tag_and_push_plugin

Signed-off-by: Chenxiong Qi<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[x] JSON/YAML configuration changes are updated in the relevant schema
[x] Changes to metadata also update the documentation for the metadata
[x] Pull request has a link to an osbs-docs PR for user documentation updates
[x] New feature can be disabled from a configuration file

/packit copr-build

No release notes, minor tests change


[issue-306] Upgrade to Next.js 9.4

This PR upgrades to Next.js 9.4 with support for preact fast refresh (instant hot reloading component updates during development 🎉 ). I'm pretty sure it also fixes the epoch loading issue (because I fixed another error relating to the epochs loading logic)
fixes #306
fixes #312

@DominikGuzei is this ready for review? You've left a WIP label on it, but everything else LGTM. I suggest we remove that label from the system, and just use the native draft feature, as this is more obvious when preparing the PR.

@rhyslbw I was fixing issues with the tests and was waiting for the tests to run for the latest commit before i left, that's why i added the WIP flag 😉 it seems like one of the test runs failed btw.

@rhyslbw I re-added WIP flag because I just found some UX issues when browsing epochs/blocks. The loading UX is not the same as before (check out https://deploy-preview-314--cardano-explorer-mainnet.netlify.app/de/browse-epochs?page=14&perPage=10 and navigate between pages to see what I mean)

@rhyslbw this PR is ready for final release 👍

Great work @DominikGuzei and @rhyslbw. Best of luck with everything!


Broken Homebrew

I noticed today that if I build nx-ovlloader with switch-tools 13.X the resulting build does not work on Atmosphere 1.7.1 or older, only on the current pre-release 1.8.0 version.
It does not produce any errors, I simply cannot open the Tesla menu. If I downgrade switch-tools to 12.1.0, the resulting build works on 1.7.1.

I don't think that's a bug, that seems correct. Nintendo made a breaking change in NPDM representation.

I would (obviously) just recommend using Atmosphere 1.8.0.

I am now, however I still think it's a bug.
My Switch is on 18.1.0 so I should be able to build for AMS 1.7.1. If the intention is to drop support for older versions of HOS in these libraries then I think it should probably be noted somewhere.

Atmosphere 1.8.0 supports older versions of HOS. This was, as I said, a breaking change in NPDMs.
If you want your homebrew to run on atmosphere 1.7.1, change "force_debug":"true" in your sysmodule's configuration json to "force_debug_prod":"true", and it will work.

This is decidedly not a bug, and you can always edit your configuration to make your homebrew work with older versions of atmosphere -- it will just then not work properly with atmosphere 1.8.0.

(Note that force_debug/force_debug_prod/allow_debug are all mutually exclusive. "force_debug" must be false in configurations built with newer tools for the homebrew to function on atmosphere 1.7.1, and if you want the functionality it grants you set force_debug as true.)

This is decidedly not a bug, and you can always edit your configuration to make your homebrew work with older versions of atmosphere -- it will just then not work properly with atmosphere 1.8.0.

I understand, but that's not documented anywhere at all. I quite literally spent all evening figuring it out myself tonight because there is no mention that there was breaking changes.
I mean yah, the answer is to just go to 1.8.0 but I originally was holding off because it's still pre-release.

These are details that are only relevant to the developers of system modules, and system modules already need to take care to stay synchronized with new atmosphere versions. This is far from the first breaking change we've had, where recompiles were needed. Nintendo frequently changes stuff like this, and if you are making a system module (as opposed to a normal userland homebrew), it's just part of how the ecosystem works.
I think this issue should be closed given a) it's not a bug, b) there is a workaround which allows you to use the newer tools to build something compatible with older atmosphere revisions anyway.


Nice way of having cloud_provider and ipip:false - Feature request

FEATURE REQUEST
Cloud provider : Openstack
OS: Host ArchLinux, k8s on top of Ubuntu 16.04
Ansible: 2.3
Kargo: d323501
Network: Calico
The combination of Calico and IPIP: false works in our Openstack config and gives a way much better network performance.
The current code dictates (at least according to me) that the combination of having a cloud_provider:openstack (or any cloud) and ipip: false is impossible. For example

roles/network_plugin/calico/tasks/main.yml:109

- name: Calico (old) | Define ipip pool argument
  run_once: true
  set_fact:
    ipip_arg: "--ipip"
  when: (legacy_calicoctl and
         cloud_provider is defined or ipip)
  tags: facts

roles/network_plugin/calico/tasks/main.yml:93

- name: Calico | Configure calico network pool
  shell: >
    echo '{
    "kind": "ipPool",
    "spec": {"disabled": false, "ipip": {"enabled": {{ cloud_provider is defined or ipip }}},
             "nat-outgoing": {{ nat_outgoing|default(false) and not peer_with_router|default(false) }}},
    "apiVersion": "v1",
    "metadata": {"cidr": "{{ kube_pods_subnet }}"}
    }'
    | {{ bin_dir }}/calicoctl create -f -
  environment:
    NO_DEFAULT_POOLS: true
  run_once: true
  when: not legacy_calicoctl and
         ("Key not found" in calico_conf.stdout or "nodes" not in calico_conf.stdout)

I think a enduser should be able to set ipip. Can this be implemented?

IPIP is the default implementation for kargo.
    roles/network_plugin/calico/tasks/main.yml:109 is to support a legacy calico implementation ( not typically used )
    roles/network_plugin/calico/tasks/main.yml:93 sets ipip enabled if cloud provider is defined or ipip is explicitly set.

Yes, so to be more clear, i would like to have IPIP disabled in combination with a cloud provider.

Hi,
Actually we have the same case. We use Openstack with Calico ipip: false. It works well for us.
But we need to modify kargo ansible manually to achieve it. If this feature request is approved, it would benefit other people like us.
Thanks!

Maybe we should introduce a new variable
cloud_provider_ipip: true (default)

and change the if statement to
"spec": {"disabled": false, "ipip": {"enabled": {{ ( cloud_provider is defined  and cloud_provider_ipip) or ipip }}},

In the case of cloud_provider_ipip: true and cloud_provider is defined then ipip is enabled. If cloud_provider_ipip: false and cloud_provider is defiend then ipip is disabled.

Hi, guys,
Defining cloud_provider without ipip sounds good to me, too. My proposal is, more simply:

Define ipip: true as the default value in roles/network_plugin/calico/defaults/main.yml
Introduce ipip configuration in group_vars/k8s-cluster.yml
Change the conditionals from or to and

Then you can control the setting more flexible, I guess.

Yes, thought about that to, but having ipip: true in case of cloudprovider makes sense, so this pattern should be kept i think.

@AtzeDeVries Yap, thus the default should be ipip: true, additionally you can disable it manually.

@y-taka-23, a yes, but then i think you are not able to set ipip: true if cloud_provider is undefined.

Hmm, that's truth.

Anotherway, to solve this problem is to introduce a variable
calico_ipip:

which is undefined by default (commented)
Then in
roles/network_plugin/calico/defaults/main.yml

have a algorithm
if calcio_ipip is defined
then
    ipip: calio_ipip
else
   ipip: (if cloud_provider is defined)

then have
"spec": {"disabled": false, "ipip": {"enabled": {{ ipip }}},

This will follow the default behaviour as it is now and the abillity to overwrite ipip

I can confirm it is working in my setup (github.com/AtzeDeVries/kubespray). Let's hope de PR is accepted

Merged #1365, closing issue


Remove skype

@kellygerritz suggested removing skype
I'm ok with this change. Anyone object?

I agree.


Automatically build embedded resources with CMake

Currently to rebuild boot.lua (and other embedded resources), you have to manually cd into a directly and run xxd.  It would be nice if CMake did this.  We could probably have CMake invoke the xxd command (if it's available).
I also found this SO answer that suggests it could maybe be done from CMake directly without invoking xxd, which would make it more cross platform.

Fixed in d228dc95


Update to 1.21 Please

https://github.com/architectury/architectury-loom/pull/219 Blocked by this

Good to know, thanks 😊

Thanks!


Vogel612: Watch beyondcorner.com

Vogel612 requests the watch of the watch_keyword beyondcorner\.com. See the Metasmoke search here and the Stack Exchange search here.

beyondcorner\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Coverage remained the same at 65.537% when pulling 0180c56d9c6d48d9d178e7a1901cf225be72476d on auto-blacklist-1526890527.1651163 into 7df2bad6d4706a197af33632400f6e9c690ea3fa on master.

!!/approve


document .spydata files and define public API for usage in scripts

From<EMAIL_ADDRESS>on 2014-01-11T13:04:57Z
As a user notes on the mailing list ( https://groups.google.com/forum/#!topic/spyderlib/8qlZPmo8uZA ), there doesn't seem to be any clear documentation on the .spydata files or how it can be loaded from a script. Saving workspaces can be a nice feature for some, and maybe a simple load command callable from scripts could make this even better. However, one should keep in mind that pickled files are probably not the most robust and scalable solution for sharing data affectively with others.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1693

From<EMAIL_ADDRESS>on 2014-01-11T10:10:38Z
In my opinion this kind of fits in the grand scheme of easily loading workspaces in memory like they do in Matlab with "load myData.mat". Note that Steven has done similar nice work for this within the context of the python wrapper for Octave (oct2py: https://github.com/blink1073/oct2py ). Maybe we could draw some inspiration from there?

From ccordoba12 on 2014-01-13T08:58:44Z
Labels: MS-v2.3

From<EMAIL_ADDRESS>on 2014-01-11T10:13:43Z
Which already might be available in Stevens PR here: https://bitbucket.org/spyder-ide/spyderlib/pull-request/4/improved-drag-and-drop-behavior-in-editor/diff

From ccordoba12 on 2014-05-04T14:49:43Z
Labels: -MS-v2.3 MS-v2.3.1

From ccordoba12 on 2014-08-17T18:44:34Z
Labels: -MS-v2.3.1 MS-v2.4


Issue #291 solved

the home page is working @mansiruhil13

i opened the deployed website , the homepage and animations are working right.

https://github.com/user-attachments/assets/d8a906e6-dd47-4abd-bbac-6f8fd6b12803

@mansiruhil13  is it reflecting now?


Chrome audio only working in one channel

From the forum:

So I have a headset and I only hear sound out of one headphone. I can not find a setting to change it from mono or stereo. It's not my headset because it works just fine with other sites. Did I miss where to change my settings at or is this a bug?

and

I had the same problem. My headphones are quality ones and 100% fine with every other program/music software. Only at codecombat the left channel was deaf completely, even at the "codecombat"-jingle. I guess i used Firefox, but since Firefox isn't really cared about and the sound was messed up before causing extreme performance issues...whatever. I didn't try with chrome i think.
edit: ok surprise: it actually works with FF but not with chrome! lol

and

In my case it happened after updating Chrome to Version 44.0.2403.155 m
BTW, the hero's and enemies' voices (on click) and battle sounds are ok.
PS. That new Chrome update not only corrupted the music and sounds in CodeCombat, but also added really bad performance issues frowning

but

I've tried different headphones on Chrome for Windows and OS X, they are working fine for me.

When I tested it in Chrome 45, all the interface sounds and music played from the right, whereas the directional audio was working. So probably just something with our audio playback code is making sounds which don't have a direction specified just play from the right.

This might be a bug in SoundJS.

Even on demo page http://www.createjs.com/getting-started/soundjs in Chrome with headset only right side is playing, on Firefox both. So this issue is not in CC, but in SoundJS

Still, some sounds play from both channels, so we might be able to just call SoundJS in a different way to get it working.

I am also on Chrome and I noticed CodeCombat's sounds only play through the right speaker of my headphones.
This does seem to be a SoundJS bug, since their demo page has the same issue.
Could it be a Windows 10 issue? I doubt something as big as this would have gone unnoticed for long, and I recently updated to Windows 10.

I think SoundJS  have fixed this problem, but should be released in the next version,
please visit this webpage:
https://github.com/CreateJS/SoundJS/commit/70a812a564641e2f49b6edcb567efd75243b0e6c

Any news on that sound issue?
PS. Previous release of SoundJS was in December 2014. And before that it was May 2014.

It should be possible to build from the SoundJS's master branch, in case this issue is urgent enough that it can't wait for a new SoundJS release.

Accroding to: https://github.com/CreateJS/SoundJS/commit/70a812a564641e2f49b6edcb567efd75243b0e6c
It should be workable if add one statement to:
codecombat/vendor/scripts/soundjs-NEXT.combined.js
5965		this.panNode = s.context.createPanner();
5966		this.panNode.panningModel = s._panningModel;
5967		this.panNode.connect(this.gainNode);
+		this._updatePan();


BUGFIX: Don't catch all exceptions in projection CLI

a try/catch block catching any \Exception is dangerous because
it disables exception logging and can disguise nested exceptions.

I'm actually not sure if I agree … because, from a user's or robot's point of view, I'd like to have proper exit codes and clean messages instead of an uncaught exception.


Shader graph version not working

Hi please could you add more explanative information about how to make the shader graph version work?
There is quite a lack of information about how to use the shader, and I am not well versed in coding.
I've actually baked an animation from a character into a texture and it works, with the generated shader, which is not a shader graph. As I'm not versed in coding, I'm interested on using the shader graph, but I tried with the shader graph you provided, changing the textures, but it is not working for me, the animation is there, but the mesh vertices are messed up.
You mention in the doc, that for the shader graph "Need to edit the mesh at runtime..
Vertex index data is being copied to mesh.uv1 by script".
I don't know what it means exactly. I tried adding the script VertIdxToUv.cs to the gameobject of the character with the baked texture, but it's not working. I don't know if that is the right method..
This is the character with the shader once baked:

And this is the character with the shader graph you provided, changing the textures to the ones baked from the character:

I don't know, what am I missing here?

upgrade to shader graph v14 to get access to vertex-id node

Hi thanks! Precisely now I'm thinking on using it in my project, but I'm working with Amplify Shader Editor, do you think it would work with Amplify?

http://wiki.amplify.pt/index.php?title=Unity_Products:Amplify_Shader_Editor/Vertex_ID

Hi thanks for the help. It was a bit difficult to understand but I got it working in Amplify Shader Editor. Curiously I cannot get it in shader graph.
In Amplify it's not perfect, perhaps is that I'm not using the tangent, but I don't know where to connect the tangent texture.

Another curious thing is that I have to reescale down the model untill the minimum posible, because when the shader is applied the size of the model is more than the original, I don't know why:

Same thing in shader graph , the tangent texture is not connected anywhere , from the looks of it - it's not being used , similar case for the hlsl shader ( TextureAnimPlayer.shader ) it is not using the tangents. I think he generated the tangent textures just in case. Also some of the shaders don't even use the baked normal textures and only rely on color and position inputs.

Hoping anyone's still around here -
I'm trying to use baked animations in vfx graph, but my shader graph version just isn't working. I already implemented the vertex id node, but the model just disappears (scaling up/down to absurd values doesn't help either).
Here's my shader graph, any help is welcome!


Unit test request for thresholds

@lukestegeman Please make:

a unit test for a json with only a peak_intensity field.
a second test using the same json, but adding in an all_clear block that forgets to include the threshold field.

"all_clear":{"all_clear_boolean":true,"threshold":10,"threshold_units":"pfu"}
}
These tests will test a bug fix that allows peak_intensity only forecasts to go through.
I am concerned that if there is a bad json that forgets to put a threshold in a block where there should be one (e.g. all clear, probability, etc), then this fix might somehow allow that forecasted quantity to get evaluated when it really shouldn't be.

Fixed by #130 via #131.


chore: reconciling for validUntil option changed

This patch makes sure validuntil option of managed role changing
can reflect to the role in database.
Closes #1840

/test

/test


Update NanoVDB Merge Candidate from Master

This updates the feature/nanovdb_merge_candidate to use v9 and with support for OpenEXR v3.

Looks like the feature/nanovdb_merge_candidate branch is now passing all the Houdini CI checks (due to the OpenEXR 3 changes coming in on this branch), but is failing the white-space and trailing space CI checks.

Closing in favor of #1213


Introduce cfg_sorted_by

As requested in https://github.com/AleoHQ/snarkOS/issues/3251, and it works in the related scenario (preview branch).
Note: there is also par_sorted_unstable_by, which would likely be faster; happy to add/substitute if desirable.

Can you include any perf improvements for code changes from https://github.com/AleoHQ/snarkOS/pull/3247/files?


[Dilato]: [Core]: URL name is displayed from somewhere in between omitting the protocol as well as some initial characters on opening a remote file with long URL.

Problem: URL name is displayed from somewhere in between omitting the protocol as well as some initial characters on opening a remote file with long URL.
Test device: Mac 10.13, win 7, Ubuntu 18.04
Test build: <IP_ADDRESS>79
Method:

Launch Brackets 1.13.
Press ctrl+shift+O for win/linux and cmd+shift+O for mac.
Quick open modal bar will open.
Input a URL which is long, such as “http://www.baidu.com/s?ie=utf-8&f=3&rsv_bp=0&rsv_idx=1&tn=baidu&wd=首都博物馆&rsv_pq=8a880d180000121c&rsv_t=5a5au2RiMw4aK8tEHK4Jdd%2B7FTrkeY4MubGOJcyFhYc9mevwSNATfJX39YE&rqlang=cn&rsv_enter=1&rsv_sug3=2&rsv_sug1=2&rsv_sug7=100&rsv_sug2=1&prefixsug=shoudu&rsp=3&inputT=2078&rsv_sug4=2079”
Press enter and the code for this page is displayed in brackets.

CASE1:
Observe the file name in the file tree.
Result:
The URL name is displayed from somewhere in between omitting the protocol as well as some initial characters of the URL.
The problem here is there is no tool tip even to show the complete URL.
CASE2:
Go to File -> open recent. Observe the file name.
Result:
The URL name is displayed from somewhere in between omitting the protocol as well as some initial characters of the URL.
The problem here can be lived with since tooltip is available to show the complete file name.
Expected:
Fir both cases, the URL name should be displayed from the beginning instead of from somewhere in between.

Closing the bug as the behavior is as designed.
If the URL just has domain name, then that will be displayed in the UI.
Else the path post the last / is displayed in the UI


bug: ion-nav inherits from the last ion-nav-view event if there are no specifications there

Type: bug
Platform: all
I have a slide box with ion-nav-view(s) inside of it. The templates for the sub views do not specify view-title or ion-nav-buttons. The title is blank and the left buttons (see below) from the parent state are not getting shown
ion-view(view-title="{{ pet.name }} test", hide-back-button="true")

  ion-nav-buttons(side="left")
    button.button.button-icon.icon.ion-ios-home-outline(ng-click="$state.go('app.main')")

  ion-content(ng-class="{'has-notification': ErrorService.errorMessage}", scroll='false')

    //- Sub-pages
    tab-slide-box(tab="0")
      .tsb-icons
        .tsb-ic-wrp
          a.ion-ios-paw(href="javascript:;")
          a.ion-ios-home(href="javascript:;")
          a.ion-ios-people(href="javascript:;")
          a.ion-medkit(href="javascript:;")

      ion-slide-box(show-pager="false", on-slide-changed="slideHasChanged($index)")
        ion-slide
          .slide-title profile
          ion-nav-view.left-text(name='profile')
        ion-slide
          .slide-title timeline
          //- ion-nav-view.left-text(name='timeline')
        ion-slide
          .slide-title friends
          ion-nav-view.left-text(name='friends')
        ion-slide
          .slide-title medical
          ion-nav-view.left-text(name='medical')
```

Greetings @emiidee!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Greetings @emiidee!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


@alloy => Fixes iPad Sharing

Fixes #367 with a technique discussed on that issue.
Remaining work:

[ ] Write tests.
[ ] Get the share sheet to be present properly (see screenshot below).

It's soooo tiny right at the bottom.

Oh dang, sounds like you’ll have to evaluate some JS that finds the anchor element for that URL and then uses JS to determine the relative location in the viewport (getBoundingClientRect).
We’ll have to think to see if we can find a better way to pass along this info when we work on #433, possibly evaluate location onClick and pass it along then.

Nah, I'm pretty sure it's that we're presenting the sharing view controller from a context that makes sense on the phone but not the iPad. Gonna investigate.

The popover on iPad will have to point to the location where the sharing was initiated from, so I don't see how you'll get away with not determining the location?

Well, under the hood we are presenting UIActivityViewController in the context of a popover. We could just have it present modally in the centre of the screen.

We could, but the HIG says the following, which I take it to mean that on the iPad (environment) it should be a popover.

Can appear in an action sheet or a popover, depending on the environment

– https://developer.apple.com/library/ios/documentation/UserExperience/Conceptual/MobileHIG/ContentViews.html#//apple_ref/doc/uid/TP40006556-CH13-SW121

Having said that, unless presenting it modally takes a lot of changes as well, I’m open to deferring this popover work to the next sprint.

Presenting it modally would only be removing code. I'll take a proper look tomorrow :smile:

Looks like UIActivityViewController must be presented from within a popover.

So yeah. Gonna have to use Javascript as far as I can tell.

Suggestions?

What does the presentation logic look like? Are we just using a presentVC thing? The popover it probably only on a default of ArrowDown, whereas we want it to support both ArrowUp | ArrowDown. Seems crazy that apple would have missed this.

document.evaluate("//a[@class='article-share-item'][@href='https://www.facebook.com/sharer/sharer.php?u=https://m.artsy.net/article/artsy-editorial-8-galleries-you-should-know-beyond-the-art']", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE , null).singleNodeValue.getBoundingClientRect();

NSString *query = [NSString stringWithFormat:@"var rect = document.evaluate(\"//a[@class='article-share-item'][@href='%@']\", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE , null).singleNodeValue.getBoundingClientRect(); '{{'+rect.left+','+rect.top+'},{'+rect.width+','+rect.height+'}}';", request.URL];
CGRect anchorFrame = CGRectFromString([webView stringByEvaluatingJavaScriptFromString:query]);

Untested objc code

xpath, you're such an old man @alloy

Cool thanks @alloy.
To answer your questions @orta, the arrow direction never seemed to matter. I also tried changes to bounds/frames, etc but to no avail.

Just noticed that the web view on the iPad isn't displaying martsy content – it's normal desktop content. That's OK?

Yeah, we will never show martsy content in the ipad, given that's the only time you'll see the popover, should be fine

Which is a problem since martsy share anchor classes are different from desktop classes.
Additionally, when we get the response.URL, it's all %20'd, but the original link is not – it has actual spaces in it. That pretty much destroy's XPath's ability to find the anchor tag (I tried in Safari's debug console).
url = 'https://twitter.com/intent/tweet?original_referer=https://www.artsy.net/article/artsy-editorial-rob-suss-of-the-franks-suss-collection-chooses&text=Rob Suss, of the Franks-Suss Collection, Chooses His Top 6 Works at Art15&url=https://www.artsy.net/article/artsy-editorial-rob-suss-of-the-franks-suss-collection-chooses&via=artsy'
document.evaluate("//a[@href=url]", document, null, XPathResult.FIRST_ORDERED_NODE_TYPE , null).singleNodeValue

This returns null.
I've tried looking for ways to query for the current active/focused link, but can't find anything.
I'm thinking an easier and less brittle approach could be to somehow keep track of the last user tap at the iOS level, then refer to it in the sharing case. Thoughts?

@ashfurrow That example works fine for me, but your code isn’t actually using the url variable. Also remember that the url value in the XPath has to be single quoted.

rage.gif

Thanks.

Hrm. Now the problem is that the coordinates aren't accurate.

I've accounted for the screen scaling, though it's possible that the web view is scaling content to fit without zooming, and this is affecting the returned bounding frame. Looking into other functions to retrieve with the zoom taken into account.

Probably gonna use jQuery.

@ashfurrow What for?

It had some methods that looked promising to account for zooming, but no joy.

I have a solution that works using a UIWindow subclass and convertPoint:toView:.

First I'm going to test the technique (checking to make sure all orientations work, etc), then I'll push with tests.
However...

The web mouseover popover thingy presents when you tap.

One solution would be to change the site to not show on eigen. We could also hide it by injecting some CSS, but that's prone to breaking with site changes. Thoughts, @craigspaeth?

Smart. Although it does sound like it get hairy around re-positioning after orientation changes, hope not, though!

OK, so this is ready for review.
Don't know why tests are :red_circle: . This is happening for me on master as well.
Also hoping to hear back about the black tooltip thing. We can always merge this and open a new issue for that after.

@alloy thanks! UIWindow takes care of the orientation changes – checked and it looks :+1: Just working on tests now.

Yay! :green_apple:

Sweet. Let’s merge so I (and others) can have a look and then discuss options.


Privacy concerns with Datadog RUM.

Hello, I noticed that Datadog RUM is being used for application telemetry.
I didn't see any disclosures about that (including what's being tracked, how it's being used, how that data is secured). Not in the console (during installation and runtime), webUI, or in the README.md.
Additionally; IMO, it would be good to make this telemetry require an explicit opt-in. Some people, if they're comfortable, might be glad to provide telemetry. Others might conclude that your plugin is spyware. Some orgs may have strong objections to the values of the name and namespace query parameters being exposed as they may contain sensitive data.
I assume that you have good intentions and just want to ship performant and reliable software. 👍
Even though I don't see any calls to startSessionReplayRecording(), It is good that you have  defaultPrivacyLevel as mask. It still would be courteous to see an explicit set of sessionReplaySampleRate to 0 as a failback safety mechanism.
off-topic: I do like the plugin! It's extremely useful.
Thanks!

Thank you for reporting this concern and understanding what is important for the community.
It will be addressed in #59


[html-to-structured-text] Consider supporting 'br' structured element

Hello!
I tried to create a multiline blockquote in the markdown editor like so:
> You have brains in your head.
> You have feet in your shoes.
> You can steer yourself in any direction you choose.

However, the text above is rendered in a single line:

You have brains in your head.You have feet in your shoes.You can steer yourself in any direction you choose.

I tracked the issue through remark steps (adding a plugin to ensure
 is generated in the hast) and then through the parse5 steps. A node is being passed to parse5ToStructuredText:
{
    "type": "element",
    "tagName": "br",
    "properties": {},
    "children": []
}

However, the object seems to be ignored as it is not in the schema as far as I can tell. Instead, we get
{
    "children": [
        {
            "children": [
                {
                    "value": "You have brains in your head. ",
                    "type": "span"
                },
                {
                    "value": "You have feet in your shoes.",
                    "type": "span"
                },
                {
                    "value": "You can steer yourself in any direction you choose.",
                    "type": "span"
                }
            ],
            "type": "paragraph"
        }
    ],
    "type": "blockquote"
}

This tree will not be rendered on separate lines, nor does it seem correct to write a custom renderRule since the Array format of children is also used for adding marks.
This happens when trying to add trailing whitespace (2x spaces) or
 at the end of a plain line (I have rehype-raw set up to render HTML tags in the markdown).
Would it be possible to consider including the br element in your schema please, or do you have any advice on how I might overcome it some other way?
Thank you!

This is a bug, br should be supported inside blockquotes! Thanks for reporting, we'll get this fixed! /cc @giuseppeg

v1.0.12 should solve this!


TerraFirmaCraft water support

The Archimedes Screw can pick up the TFC water, but the Boiler does not use it. This has been reported on the MCF thread. Perhaps we could simply convert TFC water into normal water when input into the boiler? That seems to be the easiest way to do it
@xbony2 Do you want to deal with this?

TFC support is awfully low priority. TFC and pretty much all other mods don't really mesh together...

I was looking at the TFC forums earlier today, and it seemed like a lot of the TFC players also play FSP.

TerraFirmaCraft does not exist past Minecraft 1.7. Furthermore, the 1.10 version of EI actually allows for a nice bridge mod to set the water value we use as of a1e117826f2d2fc8c00298cd0e77432c1118fcf4


Added an additional JSON diff output to the ApiXmlDocReader

The original TXT diff format is very hard to work with if you are trying to programmatically use the output to generate documentation.  Previously, @pdion891 spent a lot of time trying to manually reformat this output in order for it to be represented in the Release Notes.
This pull request adds JSON as an output format as well as the existing TXT to simplify the ability for parsers and generators to use the output.
This new JSON format was used to generate the 4.9.0 release notes (that code will be contributed separately).
Old manually formatted output:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.7.0/api-changes.html
New auto-formatted output using this new JSON output:
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.9.0/api-changes.html
I have included the output of the diff.txt as well as the diff.json to this PR so you can see the resulting output of both file formats (diff between 4.8 and 4.9).
diff.txt.zip
diff.json.zip

Great idea, LGTM (based on the api-changes urls). @swill can we also sort the list of new APIs by name.

I don't think this implementation should change.  This simply outputs the results to a JSON object (which is unordered by definition).  The generation of the documentation is separate and that code will have its own pull request as a helper script against the cloudstack-docs-rn repo.  I can add the ordering logic to the generation script if we would like it.
This PR is the foundation for being able to use scripting to generate the API change docs, so this is a dependency for the other PR (not yet opened).

Can we get another code review of this PR so we can get this merged so I can submit PRs to include the doc generation scripts to the docs repos which depend on this functionality?

lgtm, that's usefull

@jburwell can we merge this?  Not sure what process you have in place right now.  Thx...

@swill any committer may merge so long as there is at least 1 code review LGTM, 1 test LGTM, and no -1s.  I see 2 code review LGTMS.  Since this PR is for docs, is there a way to test it?   If not, LGTM.

Well, it is to help generate the docs.  I have included the txt and the new json output produced by this addition to the original post (OP).  I have also used this code to create the release notes linked in the OP, so I would consider the code tested.
I have your blessing to merge this then?

I rebased against the current master.  I will merge this as soon as the status comes back green...

@jburwell we didnt conclude on that discussion. Its not the policy as of now.

@jburwell & @karuturi please advise.  This PR should be ready to be merged...

@swill sorry to hijack. This is not a -1 for you to commit. Please go ahead. I just want to make it clear that we as a community never concluded on that discussion. But, given how things are going in the project, I guess I dont mind either way.

@karuturi no worries, I know the comment was not related to this specific PR and is related to the larger topic of how we are currently handling merge policy.
I have been a bit MIA for the last few weeks, so I have not kept up on this conversation.  I am currently unclear on what our merge policy is right now, which is why I am asking.  I know that as a CloudStack committer, I have the right to commit, but the free-for-all commit policy is also what made master unstable until 4.6.  I am not sure what checks and balances we have in place to guarantee the stability of master right now.  I hope we are not counting only on Travis since there were many cases when I was RM where Travis showed green, but bubble would catch problems...
I don't mind holding off on merging this if we would like to discuss a bit more in this issue...

@karuturi there is no discussion to be had.  According to our bylaws, committers have the right to commit to any branch.  Period.  Full stop.  If you would like to change it, propose a change to the bylaws.

@jburwell we have not been operating that way since 4.6 for a reason.  I understand it is that way in the bylaws, but the bylaws are not currently written to protect the stability of master.  How are we protecting the stability of master right now???  If we are not protecting the stability of master, then a free-for-all is a liability to the project, regardless of what the bylaws say.

@swill we never had a policy that only release managers could merge.  Remi was active that he typically merged PRs before anyone else had a chance.  The [release principles|https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up] to which we agreed only said that a PR needed 1 code review LGTM, 1 test LGTM, and no -1s.  It also lays out how it should be done.  Nowhere in that document does it restrict who can perform a PR merge.  To take away that privilege requires a change to the bylaws.  Personally, I don't recall a vote where I gave my rights as a committer.

@jburwell since 4.6 we have effectively had the RM merge everything.  I am not saying that is required, or even specified anywhere, but the reason we have been doing that was because the RM was actively maintaining the stability of master.  Regardless of who is merging what, my question stands.  How are we validating the stability of master right now?  All the other details are basically irrelevant, this is the single most important question...

@swill the RM is still maintaining the stability of master.  I check that all non-security merges meet the criteria we have laid out.  If/when I find one that does not, I will roll it back, and work with the contributors to address the deficiencies.  The value of the process to which we have agreed is not who performs the merge operation, but the 2 LGTM threshold.
By definition, committers co-equals in the community.  What makes @karuturi or myself any more capable/qualified committers to assess a PR and merge it?  We simply volunteered to do help marshall releases.  We have PRs that have languished simply waiting for one of us to have time to run a script when any other committer could have done it.  If there are committers that you (or anyone else) feels have not fulfilled the trust they have been imparted, there are mechanisms for addressing those issues via PMC.  Rather than restricting the flow of work, let's address those types of issues individually as the Apache Way is designed.

@jburwell I feel like we are not discussing the same thing.  I understand where you are coming from regarding the operational merging of PRs and I don't disagree with you.  2 LGTM with a 1 test and it gets merged (by someone)...
What I am trying to understand is how we are maintaining the stability of master.  Just because two people give it a LGTM and Travis is green does not mean that it does not break something.  There were a lot of PRs in 4.9 where Travis was green and CI still caught problems.  I am trying to understand how we are currently ensuring the master branch stays stable...

@swill other than verifying that the proper review has been done and a reasonable set of Marvin test cases have been run on the appropriate platforms, what else are you expecting?

@jburwell ok cool.  I didn't realize that we had Marvin tests running against hardware to validate the PRs.  Is it just Travis using the simulator or do we have real hardware CI being run?  Is this being done with Trillian?

@swill where hardware are being varies by PR.  In some cases, we have people running them in their labs and reporting results.  Other cases, it's blueorangatan going through ShapeBlue Jenkins + trillian.  But yes, PRs are getting tested on hardware.
(Sadly, we are still recovering from a dead storage array, so blueorangatan has been out of commission for a little bit),

@jburwell ok cool.  I will try to start getting my CI run against master every week to help make sure that master is happy.  Hopefully that will help as well.  :)
Alright, I think we have side barred this PR enough.  I am going to merge it...

@jburwell Thanks for the info on bylaws. Its not the first time we are discussing on how we are operating since 4.6. I understood that this is never going to conclude in any other way and I gave up(http://sethgodin.typepad.com/seths_blog/2016/08/putting-falsifiability-to-work.html)
Since 4.6, we are operating in a certain way and I do believe we should atleast conclude that discussion that anyone can commit(Thats my opinion and I am not looking for an argument here).
regarding the CI and @blueorangatan, the last time I checked, there is no proof there for me to believe what it says is right.  I cant access the system(atleast the logs). The success rate(of it starting) is also very low for the PRs I tried. I understand its your internal CI and I appreciate the efforts. But, its not reliable yet.
signing off

@karuturi the point is that there is no discussion about who can commit.  It is in black and white in Section 2.3 of our bylaws and the Apache Way.  As I said in my previous comment, no one ever agreed that only RMs could commit to release branches.  We agreed to the criteria for a PR to be merged.  By nature of his deep involvement, Remi ended up merging all PRs because he was so active.  However, that activity did not imply that committers had relinquished their rights under our bylaws.
blueorganatan was under development until we had a hardware failure in the lab.  Before development was interrupted, blueorganatan was posted detailed results to PRs with public exposure of the logs/results from the environment as the next item to address.  When we resume development in the next week or so, exposing logs/results will be first item implemented.


Add more scrolling dartdocs

Also, add a few other random dartdocs that I encountered along the way.

@Hixie @HansMuller


Forks/jacob/mongo shard configure fix

I don't see where the version numbers are being updated. Does that need to be done?

Yes i've up'd them now. thanks for catching that! 👍

I don't see where the version numbers are being updated. Does that need to be done?

Yes i've up'd them now. thanks for catching that! 👍


Remove render parts

As dicussed remove the render portions as we already have a gfx-render repository in the organization, the current code is more or less unmaintained and focus on the low level API only for the gfx, separating it from higher level wrappers.
PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[ ] tested examples with the following backends:

Looks green.
bors r+

CI failure is unrelated:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

bors retry

CI Failure again seems unrelated...?
Packages
  404  Not Found
Err:80 http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu trusty/main i386 Packages
  404  Not Found
Ign:81 http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu trusty/main all Packages
Fetched 7,623 kB in 22s (344 kB/s)
Reading package lists...
W: The repository 'http://apt.llvm.org/precise llvm-toolchain-precise-3.8 Release' is not signed.
W: http://ppa.launchpad.net/couchdb/stable/ubuntu/dists/trusty/Release.gpg: Signature by key 15866BAFD9BCC4F3C1E0DFC7D69548E1C17EAB57 uses weak digest algorithm (SHA1)
W: The repository 'http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu trusty Release' does not have a Release file.
E: Failed to fetch http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu/dists/trusty/main/binary-amd64/Packages  404  Not Found
E: Failed to fetch http://ppa.launchpad.net/george-edison55/precise-backports/ubuntu/dists/trusty/main/binary-i386/Packages  404  Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead.
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends --force-yes install xdotool cmake cmake-data libxxf86vm-dev libxinerama-dev libxinerama1 libxcursor-dev libxcursor1 libglfw-dev libosmesa6-dev libxi-dev libxrandr-dev g++-5 gcc" failed and exited with 100 during .

bors retry

bors r=kvark


[fix][admin] Fix check on create function class name

Motivation
The check was done for PYTHON or JAVA runtime but the runtime is not inferred in the admin CLI.
The fix is to do the check if a jar or py is provided instead.
Modifications
trivial, see diff
Verifying this change

[x] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
Before the change, create a Java function not providing the classname, the error will come from the broker (Function classname cannot be null).
After the change, the error will come from the admin CLI and will be No Function Classname specified
Does this pull request potentially affect one of the following parts:
No
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly.
Need to update docs?

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] no-need-doc
it's a fix

[ ] doc
(Your PR contains doc changes)

[ ] doc-added
(Docs have been already added)

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


Errors parsing $(call ...) with string arguments that include spaces

Consider the Makefile docs
$(call variable,param,param,…) should be legitimate, right?
If your Makefile looks like this:
# Makefile
define logger
	echo $1
endef

a:
	$(call logger, '(string_param_with_parentheses)')
	$(call logger, '(spaces are OK)')
	$(call logger, "(double quotes are fine)")

Then running make will work fine:
$ make
echo  '(string_param_with_parentheses)'
(string_param_with_parentheses)
echo  '(spaces are OK)'
(spaces are OK)
echo  "(double quotes are fine)"
(double quotes are fine)

However, parsing it will get you an error:
repro = b"""
define logger
	echo $1
endef

a:
	$(call logger, '(string_param_with_parentheses)')
	$(call logger, '(spaces are OK)')
	$(call logger, "(double quotes are fine)")
"""

parsed = parser.parse(repro).walk().node.children
print(parsed[1].children[-1].children[0].children[0].children[0].children[2])
print(parsed[1].children[-1].children[1].children[0].children[0].children[2])
print(parsed[1].children[-1].children[2].children[0].children[0].children[2])

The printout indicates parsing errors:
<Node kind=ERROR, start_point=(6, 3), end_point=(6, 18)>
<Node kind=ERROR, start_point=(7, 3), end_point=(7, 18)>
<Node kind=ERROR, start_point=(8, 3), end_point=(8, 18)>

This works with the grammar on the master branch. The parsing of arguments was one of the reasons I made the rewrite.

And, even if param doesn't contain space, the arguments isn't be split:
all:
	$(call f,test)

>>> tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2]
<Node type=arguments, start_point=(1, 8), end_point=(1, 14)>
>>> tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2].children
[<Node type=text, start_point=(1, 8), end_point=(1, 14)>]
>>> tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2].children[0]
<Node type=text, start_point=(1, 8), end_point=(1, 14)>
>>> tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2].children[0].text
>>> tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2].children[0].children
[]

However, tree.root_node.children[0].children[2].children[0].children[0].children[0].children[-2].children[0].children should be a list containing three elements: f, ,, test


Adding support for $ref and items.$ref in the definition object

Also had to fix a minor typo/error in src/version/version.controller.ts so I could get tests and the build/package step working.
I didn't see any tests for any other definition object properties, but let me know if there are some I missed or you'd like me to make some.

It was forgotten on my part. I propose to set up "model" and "isArray" instead of $ ref and $ items.


Can i Add Test  automation ?

Is it alright if I integrate Cypress to test the End-to-End part? I want to enhance my automation skills by contributing to your repository.

Go Ahead


Compat with Ubuntu 22.04+ / libfluidsynth3

This PR makes MIDI audio work in recent linux distros -- in particular, the latest Ubuntu 22.10 (but also looks like this was probably broken in 22.04LTS)
On Ubuntu 22.04+, the package is now libfluidsynth3 with the older libfluidsynth2 no longer being available.    (Note filename has changed to be so.3 instead of so.2)
The main change is NFluidsynth/Native/LibFluidsynth.cs to have it check for and use libfluidsynth.so.3 if it's installed.
I also made some other changes to help compat with recent linux in general:

Removed EOL'ed net versions and replaced with net7 to make warnings go away
The sound bank file has changed on linux, so point to the new one for sample + test (or fallback to old one)
Update some dependency versions
Could not get the tests to run at all without NUnit3TestAdapter, so added that (must be the beta version, stable version doesn't work)

Notes / caveats:

While most of the tests work again (yay!), two of the tests still fail.  The file comment indicates they were specifically written for ubuntu 14 (!), so probably more work is needed to get those tests fully up to date.  But I wasn't too sure about how to fix this, and the basics were working so I'll leave this for now.

There is a bug I noticed:  in-game, at the end of a song (or when pressing stop), the system plays the last note again after the song is complete.  It happens when these messages are displayed:

[DEBG] midi: 00005442:            SystemReset chan:00 key:00000 bank:00 ctrl:00000 dur:00000 pitch:00000 prog:000 val:00000 vel:00000
[DEBG] clyde.oal: Cleaning out buffered source 2 which finalized in another thread.
[DEBG] midi: 00001818:            SystemReset chan:00 key:00000 bank:00 ctrl:00000 dur:00000 pitch:00000 prog:000 val:00000 vel:00000
[DEBG] clyde.oal: Cleaning out buffered source 4 which finalized in another thread.

This particular bug may not be linux related at all.  This didn't happen with the standalone sample which just plays a single note, so I think it's a game-specific issue as opposed to something with libfluidsynth.  Further testing would be needed, but given it's relatively minor compared to having no MIDI at all, I figured it was worth pressing ahead.

Fluidsynth had some ABI breaks that warranted this mess in the first place. They're extremely tiny but need to be addressed: https://abi-laboratory.pro/index.php?view=timeline&l=fluidsynth

For reference here's the changelog for the breaking changes: https://www.fluidsynth.org/api/RecentChanges.html#NewIn2_2_0
Also sorry for creating conflicts, didn't realize this PR touched that. It's probably fine to remove all those old TFMs.

Quite fair, always good to be careful when dealing with unsafe/native calls.
Per the links, I updated the code to match the ABI changes, including updating the relevant fluid_event_ functions 'value' to use short->int and fluid_file_callbacks_t file offset now using 64bit int instead of 32bit int.
DLL-wise, I've made it so this should be backwards compatible, so this should still work regardless of whether the user is using ABI2 or ABI3.  For now, it assumes ABI2 unless it specifically finds the ABI3 on linux (I don't think Windows file names makes it easy to do this same logic, but as that DLL is shipped instead of system-provided, it's not such a big deal).  Whenever you're ready to update the windows dll to ABI3 that should be as easy as changing out the DLL and updating the default version number @ LibFluidsynth.cs:24
Notes/caveats:

I did not make any changes to fluid_synth_sysex or fluid_sequencer_add_midi_event_to_buffer -- they both appear to already be correct function signature...?
Did not tackle added symbols as we're not using them yet -- will leave this for someone else to do if needed
Removing AnyControlChange (it went away in ABI3) to ensure it is not called, as current versions don't support it and I want to make it obvious so it's not accidentally called (we don't appear to be using it anyway)
As some of the types have changed, it will require engine update: https://github.com/space-wizards/RobustToolbox/pull/3850

For what it's worth: I was planning to update Fluidsynth on Windows and maybe include it out-of-the-box on Linux if I can figure out compiling it (shudder).

cool cool :)
The linux bundle is likely possible, though yeah would be a bit of an undertaking making sure you've compiled in all dependent libs staticly so it's still widely compatible...  what with it touching the sound system, I don't know how deep that goes (or also licensing implications)

Fluidsynth loads audio drivers dynamically at runtime so linking against those isn't a big deal. I think on Linux we'll be fine just shipping libfluidsynth.so.3 and assuming glib etc at present on the system.

Slightly annoying though because I'd prefer to compile natives with vcpkg, but vcpkg's fluidsynth port will try to build its own glib etc which would result in many compat issues. Maybe for fluidsynth doing a direct cmake build is best.

Ah, alright!  Well, I do like the idea of not having a system dependency on fluidsynth since it's not commonly installed.  Then people would be good to go without further install steps needed.

Alright didn't violently explode on Windows, 👍

Yay!


combine the tablesaw demos

put the jvm-repr code first, so that it applies the the rest of the main demo notebook.

Yes, the TableDisplayer demo will be tiny after https://github.com/twosigma/beakerx/issues/6228 is addressed so agree we should combine them after that


Test prow CICD

Signed-off-by: Mike Ng<EMAIL_ADDRESS>/hold
wait for
https://github.com/openshift/release/pull/24568
https://github.com/open-cluster-management-io/multicloud-operators-channel/pull/22
https://github.com/open-cluster-management/multicloud-operators-channel/pull/193

to merge first

/lgtm

Not needed


allow use as CommonJS

jQuery and window.jQuery are equal in context of simple page include.
Its impossible to use this plugin in context of CommonJS/WebPack because the shim requires to set jQuery dependancy outside the module and setting it global (window.jQuery) is just wrong, so usually you just set argument 'jQuery' in your shim to jquery like this
require('imports?jQuery=jquery!is-in-viewport');

More on this http://webpack.github.io/docs/shimming-modules.html

LGTM. Thanks.


load_image indirectly uses uninitialised value

Running a short image file through load_image() makes the program use unitialized values, which is undefined behaviour.
I happened to see this in the source, and verified it.
The problem is that the buffer https://github.com/davisking/dlib/blob/48b9bf3f93f47f6173e101bc81343d55eedf242d/dlib/image_loader/load_image.h#L37 is filled with 0 to 8 bytes by the file reading, then the elements are referenced a bit further down.
To reproduce:

build in debug mode
create a short file, for instance with echo -e B >short.bin or cat /dev/null >empty.bin
-invoke load_image("short.bin") through valgrind

The following is output by valgrind:
paul@tonfisk:~/code/delaktig/dlib/dlib/test/build_normal$ valgrind ./dtest -d  --test_image_load short.bin
==22027== Memcheck, a memory error detector
==22027== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==22027== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==22027== Command: ./dtest -d --test_image_load short.bin
==22027==
Running test_image_load / ==22027== Conditional jump or move depends on uninitialised value(s)
==22027==    at 0x1C5EFC: dlib::image_file_type::read_type(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (load_image.h:48)
==22027==    by 0x1C6E63: void dlib::load_image<dlib::array2d<dlib::rgb_pixel, dlib::memory_manager_stateless_kernel_1<char> > >(dlib::array2d<dlib::rgb_pixel, dlib::memory_manager_stateless_kernel_1<char> >&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (load_image.h:74)
==22027==    by 0x1C4464: (anonymous namespace)::image_load_tester::invoke_on_file(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (image_load.cpp:58)
==22027==    by 0x1C424C: (anonymous namespace)::image_load_tester::invoke_on_file_or_dir(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (image_load.cpp:44)
==22027==    by 0x1C41BF: (anonymous namespace)::image_load_tester::perform_test(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (image_load.cpp:39)
==22027==    by 0x1B2385: main (main.cpp:142)
==22027==

Proposed fix: either memset, or use std::array

Good find.  I think the right thing to do is to say char buffer[9] = {0}.  Nothing fancy needed. :)
You want to submit the PR? :)

Yes, good old C to the rescue! Not even the {0} is necessary, only the {}.
I will add it together with the handicapped fuzz pull request :)

Right, but {0} is a bit more readable and suggestive of what happens.  Most
importantly to people who are unsure what {} does, which I'm sure is a
non-empty set of people.
On Fri, Jul 26, 2019 at 8:11 AM Paul Dreik<EMAIL_ADDRESS>wrote:

Yes, good old C to the rescue! Not even the {0} is necessary, only the {}.
I will add it together with the handicapped fuzz pull request :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/1840?email_source=notifications&email_token=ABPYFR2P7QYHMC4M347DMZDQBLSXFA5CNFSM4IHDE3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24MU6A#issuecomment-515426936,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPYFR5JL64BOABUYS7ZYRDQBLSXFANCNFSM4IHDE3MQ
.

Yeah and that sounds awesome.  More generally, feel free to submit a whole bunch of PRs that fix whatever you think needs fixing.  No need to post issues first (but you are welcome to do that as well if you are so inclined) :)

Right, but {0} is a bit more readable and suggestive of what happens.  Most

I don't agree, because that zero tricks people into thinking that the 0 is broadcasted! See here https://cppinsights.io/lnk?code=dm9pZCBmKCkKewogICAgIGludCB3aXRob3V0emVyb1s5XT17fTsKICAgICBpbnQgd2l0aHplcm9bOV09ezB9OwogICAgIGludCB3aXRob25lWzldPXsxfTsKfQo=&insightsOptions=cpp17&std=cpp17&rev=1.0

No need to post issues first

The good thing with an issue is that it gives something to point and link to, if it would be needed. I prefer when bugs are visible, not hidden in a pull request. Glad you don't mind!

But the 0 is assigned everywhere.  But yes, if you put {1} thinking it
would broadcast that is bad.  But I see your point.  It may suggest to
people that {1} will broadcast and they will learn the wrong thing.
On Fri, Jul 26, 2019 at 8:22 AM Paul Dreik<EMAIL_ADDRESS>wrote:

Right, but {0} is a bit more readable and suggestive of what happens. Most
I don't agree, because that zero tricks people into thinking that the 0 is
broadcasted! See here
https://cppinsights.io/lnk?code=dm9pZCBmKCkKewogICAgIGludCB3aXRob3V0emVyb1s5XT17fTsKICAgICBpbnQgd2l0aHplcm9bOV09ezB9OwogICAgIGludCB3aXRob25lWzldPXsxfTsKfQo=&insightsOptions=cpp17&std=cpp17&rev=1.0
No need to post issues first
The good thing with an issue is that it gives something to point and link
to, if it would be needed. I prefer when bugs are visible, not hidden in a
pull request. Glad you don't mind!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/1840?email_source=notifications&email_token=ABPYFRYCHFVC64FJV4FZQN3QBLT7BA5CNFSM4IHDE3M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD24NJ4I#issuecomment-515429617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPYFR7SUHUOBZHOGUMKQMLQBLT7BANCNFSM4IHDE3MQ
.

prevent auto close


Upgrade React Native webpack config

Issue: #1061 React Native is using the old webpack config format
What I did
I have upgraded the default webpack config, following the changes made in #1062 by @danielduan (see the diff here.
This is the first time I have used webpack directly, so my changes could be very wrong. Feel free to close this and do it a better way if it's more useful. This is, however, allowing Storybook to work correctly with my React Native project.
How to test

Create a React Native project (react-native init StorybookTest).
Run getstorybook.
Run yarn run storybook.
Run the app (react-native run-ios) and open http://localhost:7007/ to see the preview working.

I've updated the code to fix the lint issue that bitHound found (missing comma), but CodeFactor is going to fail due to duplicate code as @danielduan mention in his comment (https://github.com/storybooks/storybook/pull/1097#discussion_r117847244).

The code validation tools are here to help us, not to block us!

@danielduan if you think is good to go, just merge!

That was amazingly speedy! Thanks @ndelangen and @danielduan!


did not recognize object of type true on createNamedImport

Use method createNamedImport failed with error "did not recognize object of type true" when attempt to create new name import when targeted import does not exist on file.
work fine only if targeted import already exist on file.
trace:
Error: did not recognize object of type true
at Object.getFieldNames (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/types.js:660:19)
at visitChildren (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:184:36)
at PVp.visitWithoutReset (/projectnode_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:166:20)
at NodePath.each (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path.js:87:26)
at visitChildren (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:178:18)
at PVp.visitWithoutReset (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:166:20)
at visitChildren (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:203:25)
at Context.traverse (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:317:20)
at Context.visitNode (file:///project/node_modules/vue-metamorph/dist/main.js:446:21)
at Context.invokeVisitorMethod (/project/node_modules/vue-metamorph/node_modules/ast-types/lib/path-visitor.js:282:51)

I'm not able to repro this error with basic test cases - can you share your codemod code?

You can close the issue, it's work fine after re-install the lib. I can not reproduce the error now.


[AVM Module Issue]: Search service publicNetworkAccess value casing is inconsistent with other modules

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
Module Name
avm/res/search/search-service
(Optional) Module Version
No response
Description
The key publicNetworkAccess is used on many Azure services and most other AVM modules are standardizing around CamelCase values Enabled or Disabled, but this module is inconsistent and requires enabled or disabled.
(Optional) Correlation Id
No response

Hi @stewartadam, after consultation with the core team, we will align this with the other modules.


docs: Update README.md

Made slight changes to the README.md.

Actually, lemme ask ChatGPT to make a better README.md incorporating my changes as well!

IIRC the dev starts on port 5173

I'll fix later

IIRC the dev starts on port 5173

oh, that doesn't really matter and it's a slight change!


plot continuation using scatterlines and NaNs

this makes it more efficient as well, coincidentally. Not that it matters because it is unikely that we plot millions of points during the continuation.

Looks good I think:


Add more rules to weaken linter in dev mode

This pull request weakens more eslint rules when using dev-mode:

space-before-blocks
space-before-function-paren
object-curly-spacing

This helps to be more productive while making prototypes in Wegue. But of course, this does not affect the proper checking of rules when running npm run build.

@fschmenger your suggestions sounds reasonable as well


Export statement may only appear at top level in file...

Hi ad.
I use immer version 5.3.4, and my project base on version 0.61.5
From 11/1/2022, I regularly cannot build app. Even if i upgrade immer to the latest version, this issue still occurs.
The following error occurs: "error libs/immer/dist/immer.module.js: Export statement may only appear at top level in file libs/immer/dist/immer.module.js at 1729:2".
Please help me solve this issue.

Please provide a minimal reproduction as this probably relates to build set
up and we cant debug screenshots
On Wed, 12 Jan 2022, 09:16 John Pham, @.***> wrote:

Hi ad.
I use immer version 5.3.4, and my project base on version 0.61.5
From 11/1/2022, I regularly cannot build app. Even if i upgrade immer to
the latest version, this issue still occurs.
The following error occurs: "error libs/immer/dist/immer.module.js: Export
statement may only appear at top level in file
libs/immer/dist/immer.module.js at 1729:2".
Please help me solve this issue.
[image: Screen Shot 2022-01-12 at 16 12 42]
https://user-images.githubusercontent.com/49853430/149098432-fc1de88c-dfc7-4e0a-819f-e8f4e53507e0.png
—
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/892, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBFM3A3DSKTSW7JA5DDUVVBGPANCNFSM5LYN7Y7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I'm having the same issue when building my react-native android app.
I'm using dimmer version 5.3.6

Closing for the lack of a reproduction and opening an issue on 4 major versions back :).

@thanhlk123 am also facing the same issue, any solutions?


Save state on rotation in Hotels Screen

In almost every screen there is a problem when the screen rotates. One such example is given below
Steps to reproduce

Select Travel -> Hotel Booking
Select City -> Any City eg) Kolkata -> Let the results load
Rotate the screen
Again have to select a city ( in short it is a very bad UX)

Expected behaviour

The app should retain the state i.e selected city should stay as it is on rotating the device

Apply the fix in all screens of the app

Can we just restrict our application to portrait mode for now? This will happen in almost every screen (and not just hotels)

@Swati4star Can I pick this up?

Sure @nitinnatural 👍