[FEATURE REQUEST] Not working in canvas

Hi your plugin is working fine in notes but not working canvas cards. If possible please update it because I write most of my notes in canvas cards and then later convert it into notes if required.

I checked why it doesn't work. The reason is that Canvas Card has no file and therefore the code which should create a new note in the same folder doesn't work ... and there is a check which skips whole link feature because of that. I am trying to detect the file path of the parent canvas file, but I failed till now. In worst case I will hack it and the new files linked from canvas Card will be created in the root folder of the vault.

The feature was implemented in release 1.0.7


Add jQuery v3.1.1 (latest, compatible with Bootstrap)

This PR adds jQuery to the Bootstrap files to make sure we're shipping everything needed to get started with Twitter Bootstrap. The README demonstrates how to integrate jQuery along with Bootstrap (which can be omitted when the project already integrates jQuery in some other way).

Adds jQuery (compressed, uncompressed and map) distribution files to the bootstrap module
Updates usage instructions (README)
Adds instructions on contributing (updating) Bootstrap, jQuery and Font Awesome (README)
Moves badges below the title (make them show up on PyPI), and add version numbers to ALT-text (fallback in case of service outage, as currently)

Closes #27.
Notes

I've refrained from adding a new module, jquery, mainly for aesthetic reasons ("belongs to bootstrap", script-tag symmetry in template). Downside of this approach is that the clean separation in the directory tree is now compromised; it should still be sufficiently self-explanatory, though.
The jquery-<version>.min.(js|map) files are renamed (and instructed to be renamed) to jquery.min.(js|map) to facilitate an easy upgrade path.

This looks good.  I could go either way on adding a new jquery module.  Since this library really is only about shipping the parts necessary for bootstrap, I think what you've done here works well.

Thank you! I'm thrilled to make my first pip install of the new version, yay! :tada:

I don't have the correct laptop with me right now to make a release, should be able to do that this evening.


Regardless if I use the gui game editor or not, can materials still be rendered into the game scene?

I understand that rusty-editor currently only supports textures, however, I was wondering if the core of the game engine supports materials as well or is this something that is being worked on?
If it is something that is being worked on, is there an issue tracker or something where I can track the progress?

@mrDIMAS

currently rg3d's FBX importer is not able to fully map FBX material to engine's material.

I believe the support for materials is currently being worked on, is there some issue I can track or something?

FBX importer now supports diffuse color (fixed in #164), so I think this issues can be closed too.

@mrDIMAS That is awesome mate =D

@mrDIMAS Can it support emissions and glossy properties or is it being worked on?


android: Upgrade jni to 0.21

CC @rib
Note that I could not run the tests locally as they are behind a macros flag? Yes, the emulator machine runs macos but is there any intention to withhold running it on a non-mac development machine (with emulator or physically attached phone)?

@amodm tackled in #66!

Thanks @MarijnS95. I'll target a release for this in 2 weeks from now, unless a more urgent fix comes up, in which case this will get rolled out alongside.

This is now released as v0.8.8. No other changes in this release.


Add support for divisible by test

This deprecates divisibleby and updates references in the docs.
This resolves #804.

@RobLoach can you review this so we can get it merged?

Nice work on the deprecation notice.


WIP Emscripten build

Can it be minimized in terms of repository code somehow? We need this builds in 2 more places

@NikVolf you mean make it more universal?

yes, some way to avoid pushing all this code in every repository


Menu item out of date on extension start

Since it only listen on tab changes, if the extension loads and the user doesn't change the tab, the menu item is not up to date.
This happens for example when the browser starts.

I think that browser startup is covered by the tab update listeners:
https://github.com/bfred-it/webext-domain-permission-toggle/blob/9f9e40cd8910f737fe8b924584b075e1f7a7a7fc/index.ts#L244-L248
So this only applies when all these apply:

the extension was already installed beforehand
the user already granted permissions to the host
that host is the active tab (in any window)
the extension was disable and is now re-enabled
the user goes to right-click on the action item and actually cares to read that menu item

Quite a long list of coincidences that basically only happen when testing the extension.
Not sure I care right this moment.


Swift 5 with Alamorfire Beta 7 and Object Mapper 3.5.1

Hi @RomanPodymov, when I started with it, Beta 7 was the latest one.
Closing this pull request in favor of  https://github.com/tristanhimmelman/AlamofireObjectMapper/pull/288
Link: https://github.com/ozgur/AlamofireObjectMapper


[Bug] Themes appear in the themes tab, but they do not apply themselves when toggled.

Describe the Bug
Whenever I try to enable a theme from the menu, nothing happens besides getting a notification that it has loaded. Multiple restarts and installs have not fixed it.
To Reproduce
I don't know how to reproduce it, it just started happening
Screenshots

Discord Version
Stable

Nevermind, my themes folder was just corrupted


Katharsis v2.1.3 and up supports Java 7

See https://github.com/katharsis-project/katharsis-core/issues/48

Thanks!


source/StoryMenuState.hx:323: characters 12-14 : Expected )

Describe your problem here.
i just downloaded the source code and it gave me the error "source/StoryMenuState.hx:323: characters 12-14 : Expected )"
what do i do
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

i found out


Open Source Section Added #77

Fixes #77

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

@kanak22 pls review my pr.


Create container for lldap

lldap uses gosu and doesn't follow best practices
https://github.com/lldap/lldap/issues/230

They have released their own rootless image. Closing.


Remove usr/local from entrypoint path.

This was flagging our linters. The upstream images do place the binaries in usr/local, but the entrypoint doesn't contain that path: https://github.com/crossplane-contrib/provider-aws/blob/master/cluster/images/provider-aws/Dockerfile
Chainguard Images Pull Request Template

This needs https://github.com/wolfi-dev/os/pull/6060 and https://github.com/wolfi-dev/os/pull/6057


Fails to login after restarting Emacs

After copilot-login, then quitting and restarting Emacs, and doing copilot-login again, I get the error:
copilot-login: No catch for tag: --cl-block-copilot-login--, nil
Doing copilot-logout and then copilot-login again seems to resolve the issue.

Fixed.


chore(main): release 1.6.0

:robot: I have created a release beep boop
1.6.0 (2023-09-18)
Features

parallel updates (#60) (a9f593b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aidanaden/canvas-sync/releases/tag/v1.6.0 :sunflower:


x/website: go.dev/wiki page has wrong link to InstallTroubleShooting page

The https://go.dev/wiki/ page has a line that says

Having installation problems? InstallTroubleShooting

The InstallTroubleShooting link 404s, the correct link should be https://go.dev/wiki/InstallTroubleshooting (lowercase "s")

This line:

Managing your dependencies - An overview of the tools you can use to manage

also has a dead link.

These links and others are fixed in this CL which is waiting for review
https://go-review.googlesource.com/c/wiki/+/550195

Thanks @yansal The change was merged.


Lazy kernel symbols

Lazy kernel symbols is a slower but more memory efficient of the
KernelSymbolsTable (which is now an interface).
It works by storing a copy of the kallsyms file and querying it's content,
instead of preparsing the whole file at construction time.
Also fix a small leak in the SymbolToOffset helper where a file Close() was missing.

@yanivagman tests are failing because they need root/syslog caps to run, otherwise reading kallsyms yields the results with all addresses set to 0.


NewV4: non-random uuid

I'm running this on my macbook pro.
I'm using uuid.Must(uuid.NewV4()).String() to generate random identifiers. I'm generating theses identifiers at a very low rate of a few dozen per days
Here are some non-random UUID that I got in the last weeks:
02524e6f-65a7-4cf5-8000-0000000000002
6e3ef1c8-0000-4000-8000-0000000000001
fa07f1e9-a8a0-427f-8103-e34e000000000
2cfa392b-71d5-4000-8000-000000000000
5f16db16-56ce-4000-8000-000000000000
bac73b37-aab3-498b-8000-000000000000
da5bd82d-4f98-4b51-8000-000000000000
eb245e52-535f-4274-8350-3a7200000000
f7510000-0000-4000-8000-000000000000
5936f955-286e-47ac-8000-000000000000
0a14da92-0000-4000-8000-000000000000
80730000-0000-4000-8000-000000000000
cd2b88a5-0000-4000-8000-000000000000

I think I shouldn't have theses.

Hmm, the docs say that rand.Read() uses io.ReadFull(): https://golang.org/pkg/crypto/rand/#Read

So it looks like this commit introduced the bug: https://github.com/satori/go.uuid/commit/0ef6afb2f6cdd6cdaeee3885a95099c63f18fc8c
Prior to that commit, rand.Read() was used, which is a wrapper that uses io.ReadFull(): https://golang.org/pkg/crypto/rand/#Read

How is a critical bug like this still unresolved? Especially given that someone already did the work to fix it.

With BigQuery I tried to find github projects using the vulnerable version of this library and opened an issue on each of theses projects. At least the word is out and projects can act accordingly. I unfortunately don't have time to patch them all.

I used theses query:
SELECT *
FROM [go.uuid]
WHERE REGEXP_MATCH(content, r'Must\(\w+\.NewV4')

uuid.Must(uuid.NewV4()) has been introduced with the vulnerability so matching this expression should be correct.
SELECT id
FROM [go.uuid]
WHERE REGEXP_MATCH(content, r'err := uuid\.NewV4')

Same thing, NewV4() that returns an error has been introduced with the vulnerability, matching this expression should be correct as well.

Here is the projects list: https://gist.github.com/josselin-c/c1bda90ba538c65a5b8062aa2db0c386

Thanks, I think this will get a lot of the people who upgraded, but some folks caught and handled the error without using Must. Not a huge deal though.

My second query is there to match the cases where Must wasn't used. In this case I assume they used the 'standard' convention for error variable naming & package name.

Thank you for opening the issues that you did. This combined with the versioning issue that was opened months ago has pushed me into transitioning over to the google uuid repo.

@yamamushi I checked that google/uuid repo and it's kind of lacking and has some code smells. I would advise against moving there long term.

ping @monkeydioude, @kevinburke, @markbates saw that you guys have some forks that other people were directed to for appropriate tagging and such. Thought you might want to be aware

Thanks - my fork doesn't contain that commit, and still uses the crypto/rand reader. I'll add a note to the docs. I'm still committed to maintaining my fork.

A few people in the Go community have banded together to adopt this package. We've just cut a v2.0.0 release of our fork: https://github.com/gofrs/uuid/releases/tag/v2.0.0
This is a GitHub organization with a few community members in it, so this package isn't being maintained by one individual. We're also available on the Gophers slack in #gofrs.

Awesome! Should I rebase my PR against this so it can be considered for
merging? It's been sitting for well over a year...
https://github.com/satori/go.uuid/pull/50
On Wed, Jul 18, 2018 at 12:58 PM Tim Heckman<EMAIL_ADDRESS>wrote:

A few people in the Go community have banded together to adopt this
package. We've just cut a v2.0.0 release of our fork:
https://github.com/gofrs/uuid/releases/tag/v2.0.0
This is a GitHub organization with a few community members in it, so this
package isn't being maintained by one individual. We're also available on
the Gophers slack in #gofrs https://gophers.slack.com/messages/CBP4N9BEU
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/satori/go.uuid/issues/73#issuecomment-406055068, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADC47O5rRxwr4XoRiROyRP6lZJDGFmifks5uH5NcgaJpZM4S5XdY
.

@rkuris gofrs being an activists collaboration is open for any suggestions, as soon as we all can agree it adds value to the project
A required note: this is not an official position, just my personal understanding of the aim of the organisation.

@josselin-c could you update the issue description and link to the new https://github.com/gofrs/uuid project?

This bug is a serious security issue, definitely a CVE should be assigned to this vulnerability.
Everyone should be aware about this vulnerability.
Additionally it would be good to release new version, because the last 1.2.0 is before the g.rand.Read function introduction.
@satori - can you request a CVE ID for this issue and release new version to make it visible that problem has been addressed?
If you need assistance with CVE ID please let me know (I can help and assign CVE ID from Red Hat side).

@p-rog I've been trying to contact @satori for years with no success. Please see https://github.com/satori/go.uuid/issues/103

@p-rog The sad thing is given the amount of time this issue has existed, anybody using this repo is creating a self-inflicted problem. I fully realize that this is largely on @satori  for not doing the bare minimum to tag the release, but there are multiple issues about this on the backlog and I've been personally going in and responding periodically to PRs and new issues telling people to stop using the repo. What we're fighting is people who don't do the due diligence to read anything about the dependencies they're pulling in, or will double down  on using a dependency because they don't want to migrate.
It'd be nice if there was some way we could get github to intervene, at least in requesting an archival of a dangerous repo.

Migrating to this currently maintened fork would be a fair option.

@theckman @CameronAckermanSEL I fully agree with your comments.
That's why I think assigning an official CVE could be a good option to make more people aware that this repo shouldn't be use anymore and instead of this everyone should start using github.com/gofrs/uuid.

@p-rog You can try reaching @satori through LinkedIn, he is active there. Considering this one has gone ignored for so many years I think that's your best bet for getting in contact.

@p-rog If you have the ability to file a CVE, that sounds great. Synk already has a "CVE" on their system so it's popping up there. If there's any help you need I would be willing to give a hand but I'm guessing you're quite savvy in this area :)
PS. Sorry for the rename timing hope it isnt confusing

@cameracker no worries, I caught the name change
I've requested new CVE id for this security bug. Once the CVE id will be issued I will post it here.

The CVE-2021-3538 has been assigned to this issue.

For those who end up here, this fork is maintained any includes the fix to this issue: https://github.com/gofrs/uuid

Am I missing something or tag 1.2 seem to be ok?

@vaiojarsad the commit where the issue was fixed is here: https://github.com/satori/go.uuid/commit/75cca531ea763666bc46e531da3b4c3b95f64557 (April 4, 2018)
The v1.2.0 tag is here: https://github.com/satori/go.uuid/releases/tag/v1.2.0 (Jan 10, 2018) based on commit https://github.com/satori/go.uuid/commit/f58768cc1a7a7e77a3bd49e98cdd21419399b6a3 (Jan 3, 2018)

Hi @theckman ! I'd already seen what you are saying but I took a look at  https://github.com/satori/go.uuid/archive/refs/tags/v1.2.0.zip, more specifically at the generator.go file inside the zip, and it seems like the bug hasn't been introduced there.
Kind regards!

`// NewV4 returns random generated UUID.
func (g *generator) NewV4() UUID {
u := UUID{}
g.safeRandom(u[:])
u.SetVersion(V4)
u.SetVariant(VariantRFC4122)
return u

}
.......
func (g *generator) safeRandom(dest []byte) {
if _, err := rand.Read(dest); err != nil {
panic(err)
}
}`
And rand is crypto/rand (uses ReadFull)

@vaiojarsad The issue was introduced by this commit:
https://github.com/satori/go.uuid/commit/0ef6afb2f6cdd6cdaeee3885a95099c63f18fc8c#diff-0d0495ad16c6f603876bbf484c43b549f53d0b33d4cd74c908b0ee95a94369ea
When owner of that repo decided to change the return (UUID, error) instead of UUID.
That commit was after the 1.2.0 release.
In the 1.2.0 release the g.rand.Read function is not used.
Later with this commit owner changed the introduced g.rand.Read function to ReadFull:
https://github.com/satori/go.uuid/commit/d91630c8510268e75203009fe7daf2b8e1d60c45
@vaiojarsad please only keep in mind that this repo is not maintained any more, it's much better and safer to start using this fork: https://github.com/gofrs/uuid

I am mistaken; apologies for the noise.

What's the fix here? :)
Searching for upgrade option for CVE-2021-3538

What's the fix here? :)
Searching for upgrade option for CVE-2021-3538

Switch from unmaintained github.com/satori/go.uuid to github.com/gofrs/uuid

Thanks! @rkuris

@ah-eng https://github.com/google/uuid use google made

So it looks like this commit introduced the bug: 0ef6afb
Prior to that commit, rand.Read() was used, which is a wrapper that uses io.ReadFull(): https://golang.org/pkg/crypto/rand/#Read

The code was already vulnerable in the released version 1.2.0, as the same calls was made in the safeRandom call. See https://github.com/satori/go.uuid/commit/0ef6afb2f6cdd6cdaeee3885a95099c63f18fc8c#diff-0d0495ad16c6f603876bbf484c43b549f53d0b33d4cd74c908b0ee95a94369eaL200
I think this has incorrectly led some people to believe that 1.2.0 was not affected. This issue was created in March, and the latest release was in January same year, so unless @josselin-c used the code off the master branch and not 1.2.0, he would have experienced this issue on 1.2.0.
Currently, NIST lists 1.2.0 as excluded in the vulnerability scope of this project, which is causing us some compliance problems at the moment as the package is being used in a managed service we use at AWS. See https://nvd.nist.gov/vuln/detail/CVE-2021-3538

Version 1.2.0 of this package is no longer listed as vulnerable. NIST have revised their publication.


Object.path doesn't handle nullable and optional values correctly at last hop.

🐞 Bug Report
Describe the bug
Object.path doesn't handle nullable and optional values correctly at last hop.
Reproduce the bug
Object.Path<{nullable: number | null | undefined}, ['nullable']>

Expected behavior
Expected code above to return number | null | undefined, since this is the value at the path. Returns number in v6.3.0

I've tried swapping the order of operations between NonNullable and At, which I believe solves this problem, but it causes tests for O.MergeUp and O.Nullable to fail and I'm not sure I understand why.
type __Path<O, Path extends List<Key>, strict extends Boolean, I extends Iteration = IterationOf<'0'>> = {
-    0: __Path<NonNullable<At<O & {}, Path[Pos<I>], strict>>, Path, strict, Next<I>>
+    0: __Path<At<NonNullable<O> & {}, Path[Pos<I>], strict>, Path, strict, Next<I>>
    1: O // Use of `NonNullable` otherwise path cannot be followed #`undefined`
}[Extends<Pos<I>, Length<Path>>]

Hi @smoogly, thanks for reporting this. There's a strict option that is supposed to handle that:
type test = Path<{nullable: number | null | undefined}, ['nullable'], 0>

But it does not behave like you said. So I'm going to fix this.


K8SPG-487: add global annotations and labels for cr.yaml

https://perconadev.atlassian.net/browse/K8SPG-487
DESCRIPTION
Problem:
It’s not possible to set annotations / labels at a global level for all resources created by operator.
Solution:
Add .spec.metadata.labels and .spec.metadata.annotations fields to the cr.yaml.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[x] Is an E2E test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are all needed new/changed options added to the Helm Chart?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PG version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
failure

sidecars
passed

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/956/commits/c6358110fa2ccc36752374d423717ba8794d9212
image: perconalab/percona-postgresql-operator:PR-956-c6358110f

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/956/commits/bbcf318a8fe30ae8622e6422c6ab518240879925
image: perconalab/percona-postgresql-operator:PR-956-bbcf318a8

Test name
Status

custom-extensions
passed

custom-tls
passed

demand-backup
passed

finalizers
passed

init-deploy
passed

monitoring
passed

one-pod
passed

operator-self-healing
passed

pitr
passed

scaling
passed

scheduled-backup
passed

self-healing
passed

sidecars
passed

start-from-backup
passed

tablespaces
passed

telemetry-transfer
passed

upgrade-consistency
passed

upgrade-minor
passed

users
passed

We run 19 out of 19

commit: https://github.com/percona/percona-postgresql-operator/pull/956/commits/cad7c9859b22461a4d3417e4e261a43923be23b3
image: perconalab/percona-postgresql-operator:PR-956-cad7c9859


make build - failed

Hi dear,
I've just updated the release on my test environment, I got this problem:
[root@logbook /logbook]# make build
Cleaning...
Cleaned!
Building...
# modernc.org/sqlite
/root/go/pkg/mod/modernc.org/sqlite@v1.32.0/fcntl.go:27:16: undefined: runtime.Pinner
note: module requires Go 1.20
*** Error code 2

Stop.
make: stopped in /logbook

I'm operating it in FreeBSD 13.1-RELEASE-p9 amd64.
Let me know if you need something to test.

which go version do you have?

which go version do you have?

I was using an older version, so I have updated to: go version go1.21.12 freebsd/amd64 previously it was something like: 1.19
But now seems to arise a different problem, and I'm pretty sure is related to the Go version:
[root@logbook /logbook]# ./dist/web-logbook -port 80
INFO	2024/08/28 15:50:45 Web Logbook v2.41.0 is ready on http://localhost:80
ERROR	2024/08/28 15:50:48 handlers_logbook.go:25: SQL logic error: no such column: update_time (1)

From your commit seems that the version used is 1.21.13 but the package manager show that this is the latest version available.

Any 1.21.x version is ok. The error is related to the missing column in the database view. And you somehow still have an older version of the view without this column. I will prepare a fix, which will recreate the view.
As a temporary solution, you can drop the view logbook_view in the database and then restart the app - it will create a new one.


feat: add typescript

In this first PR, I added a typescript to make it easier to find bugs during development.
This PR should have included all the relevant things for us to apply type safety in it, such as pages, components, and data.
I also added pre-push hooks so that we can take out errors that occur during the build before we push it to the repository.
Resolver for #9

Hi @alfanjauhari, thank you for your contribution! Could you use type instead of interface? And let's follow the previous rules to use a single quote.

Hi @alfanjauhari, thank you for your contribution! Could you use type instead of interface? And let's follow the previous rules to use a single quote.

Hi, @nauvalazhar thanks for your feedback. I already change the interface keyword to type in typescript and use the single quote as a prettier config says.
But, i have some resources that give me the decision to choose interface instead type. https://stackoverflow.com/questions/37233735/interfaces-vs-types-in-typescript. But i think for now we don't need to argue about which are the best practice for that, bcz they have each pros and cons.

Thank you for your hard work on this, @alfanjauhari! I found type is easier to type and does not extend automatically. For now, I will merge this PR, and let's improve the rest gradually.

@all-contributors please add @alfanjauhari as code


Create a Signup Page

Use your creativity and make a Signup page for the Forum project.
The signup page should have a graphics or a vector on one side and the signup form on the other side. And, since it is only an IIITA students' discussion forum, so no need to add other signup options like google, etc.
It should require User's full name, email-id and password only.
You can use tailwind CSS for styling.

You will have to edit in this file: pages > signup > index.js
For using image/vector, make an assets folder inside src folder and place the required image there only, and then import that from there.

Make sure you follow the given template before making the pull request.

Claim

Claim

Claim 💯

@yashg-116  Can we use Bootstrap for css

@bhumi-cka what's the status?
Are you still working on it?

@Kali-Decoder yeah! you can but wait till we assign you the task..

@yashg-116 Can we use Bootstrap for css

No, you may use tailwind for it.

Task is Assigned by you or we can choose it and work on it ?? @yashg-116

It is already assigned to @bhumi-cka for now.
You can claim it again if it will be reopened. We will assign on first come basis.

No response from @bhumi-cka , so this issue is open to claim again!

Ycan i take this

Go for it @Kali-Decoder

How much time i have for this ??

It will be better for you to complete it ASAP as there is an overall limit for taking only a particular number of issues at a time per user ;)
Though the normal deadline will be 48 hours from now.

great work @Kali-Decoder 🙌


Security: Remote code execution vulnerability

Running tinker allows arbitrary code to be executed. This is very dangerous.
Any executed php code will have the same access as the running php instance. This means that the running application may be altered, and if run with root privileges, one can get complete control of the machine.
This can be solved by:

Notifying users of this in a readme file.
Only allowing tinker to be run locally - env is set to local

You can do that on NovaServiceProvider:
    public function tools()
    {
        return [
            (new \Beyondcode\TinkerTool\Tinker)->canSee(function ($request) {
                env('APP_ENV') == 'local';
            })
        ];
    }


Algorithms(DP)-Dorsey Thief

Problem Link: https://www.hackerrank.com/challenges/dorsey-thief/problem
Do it in C++, Python and Java.
Please assign it to me for doing the problem C++.
Proposed Label: Hard/Advanced

Can you assign me this issue??

@avinash14022002 can you provide the code in Java or Python?

@stormfireuttam
yes, in java

This problem has merged twice in Algorithm section

@abhay313 Where?

in algorithm section first row and 16th row, there are two dorsey thief in README

Resolved, thanks for pointing out!

Can I work on the Python solution?


Client Binding, bug

I use client binding on my servers. I noticed it's not working on this version of 1.6.1 but it works on the previous version of 1.6.1
If enabled I can't connect, but once I rem the line with # I can connect.
I have this:
clientBind = "http://www.gkclan.me - http://gkclan.servegame.com -  http://agar.io"

I noticed serverRestart not working either on this update 1.6.1 version. I'm going to revert back to the previous 1.6.1. I'll try to fix what I can for these two bugs. Anyone else seeing these?

It happens the same to me too with the clientBind

It happens to me too :(

it is kind of weird but i'm able to get it to work if the link does not have a / at the end of it.
for example: http://mywebsite.com
if I have a / in the end it won't bind. so don't do this http://mywebsite.com/
give it a try.

and only one site can be bound, on the previous version I had more than 3.


created code for strongly connected components in a graph- kosaraju algorithm

created a code for getting strongly connected components in a graph by using dfs that is kosaraju algorithm...

Please merged this for hactoberfest...


Merge 0.18.1 into dev

resolves #2838
Description
Merge 0.18.1 commits into dev/kiyoshi-kuromiya. Git automatic merge did not handle the merge well, because contradictory isolated commits had been made in the Manifest updates, particularly the 'generated_at' field that was moved out of the base manifest into the manifest metadata.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot check

@cla-bot check

@cla-bot check


Allow regex in blacklist

like if i want to filter out every walking sound, i just enter minecraft:*.step into the blacklist.

This would be very helpful.


Update locale handling

Content have requested that the default submit buttons should lower case the model names.
This PR adds an I18n extension that allows us to lower case models within the YML file, instead of having to manually set the text on every submit button on every form.

Go ahead.


Add linting/type checking (and some code structure)

Checking with mypy . yields a lot of warnings:
hosakaii:FFXIVPPSCalculator king$ mypy .
Jobs/Tank/Tank_Spell.py:1: error: Cannot find implementation or library stub for module named "Jobs.Base_Spell"
Jobs/Tank/Tank_Spell.py:2: error: Cannot find implementation or library stub for module named "Jobs.Melee.Melee_Spell"
Jobs/Tank/Tank_Player.py:1: error: Cannot find implementation or library stub for module named "Jobs.Base_Player"
Jobs/Tank/Warrior/Warrior_Spell.py:5: error: Cannot find implementation or library stub for module named "Jobs.Base_Spell"
[---->8----]
SimulationInput.py:58: error: Cannot find implementation or library stub for module named "Jobs.Melee.Dragoon.Dragoon_Player"
SimulationInput.py:59: error: Cannot find implementation or library stub for module named "Jobs.Melee.Reaper.Reaper_Player"
SimulationInput.py:60: error: Cannot find implementation or library stub for module named "Jobs.Melee.Monk.Monk_Player"
Found 274 errors in 54 files (checked 57 source files)

Some of this can be fixed by restructuring the code to look more like a module; other parts can be fixed by adding typing to it. Typing isn't the end-all be-all solution, but being able to have autocomplete in tools that suggest it (along with immediate feedback like "this is the wrong type") can speed development time and reduce errors.

That seems like a good idea, I just looked into mypy and I'm down to make this more structured.


Vendoring: prevent from reading hidden (starting with "_") dirs and vendor + upgrade to vendor go 1.7

This PR is focused on Vendoring.

Add flag "vendoringPath" to specify if the vendor directory is in a different directory (documented too)
Ensure the tool is not looking into hidden directories when their names start with "_" and vendor dir when inspecting for imports
Go 1.7 has native support for vendoring, now it will always be looked. and remove functionality of GO15VENDOREXPERIMENT env var.

@leoswaldo @markdryan Thank you for contribution!


introduce winafl-cmin.py

This PR introduces the first version of winafl-cmin.py which can be used to generate minset of corpuses based on the instrumentation generated by winafl. It plays nicely with WinAFL, and tries to use the same option names, etc. so that users already using afl-fuzz.exe can pick up this one very easily.
The script is currently not fully feature complete, it at least doesn't support passing testcases via stdin - I've only used it on target that takes filename so far.
Here is what looks like the help section:
$ python winafl-cmin.py -h
corpus minimization tool for WinAFL by<EMAIL_ADDRESS>Based on WinAFL by<EMAIL_ADDRESS>Based on AFL by<EMAIL_ADDRESS>usage: winafl-cmin.py [-h] -i dir -o dir [-n] [--working-dir dir] [-v]
                      [-covtype {edge,bb}]
                      [-call_convention {stdcall,fastcall,thiscall,ms64}]
                      -coverage_module module -target_module module -nargs
                      nargs -D dir
                      (-target_method method | -target_offset rva offset)
                      [-t msec] [-f file] [-C] [-e] [-w n]
                      ...

positional arguments:
  target_cmdline        target command line

optional arguments:
  -h, --help            show this help message and exit

basic parameters:
  -i dir, --input dir   input directory with the starting corpus.Multiples
                        input directories are supported
  -o dir, --output dir  output directory for minimized files
  -n, --dry-run         do not really populate the output directory
  --working-dir dir     directory containing afl-showmap.exe,winafl.dll, the
                        target binary, etc.
  -v, --verbose

instrumentation settings:
  -covtype {edge,bb}    the type of coverage being recorded (defaults to bb)
  -call_convention {stdcall,fastcall,thiscall,ms64}
                        the calling convention of the target_method
  -coverage_module module
                        module for which to record coverage. Multiple module
                        flags are supported
  -target_module module
                        module which contains the target function to be fuzzed
  -nargs nargs          number of arguments the fuzzed method takes. This is
                        used to save/restorethe arguments between runs
  -D dir, --dynamorio_dir dir
                        directory containing DynamoRIO binaries (drrun,
                        drconfig)
  -target_method method
                        name of the method to fuzz in persistent mode. A
                        symbol for themethod needs to be exported for this to
                        work
  -target_offset rva offset
                        offset of the method to fuzz from the start of the
                        module

execution control settings:
  -t msec, --time-limit msec
                        timeout for each run (none)
  -f file, --file-read file
                        location read by the fuzzed program. Usage of @@ is
                        encouraged to keep parallelization possible

minimization settings:
  -C, --crash-only      keep crashing inputs, reject everything else
  -e, --edges-only      solve for edge coverage only, ignore hit counts
  -w n, --workers n     The number of worker processes (default: cpu count)

Examples of use:
 * Typical use
  afl-cmin-win.py -D D:\DRIO\bin32 -t 100000 -i in -o minset
-covtype edge -coverage_module m.dll -target_module test.exe -target_method fuzz -nargs 2 --
test.exe @@

 * Dry-run, keep crashes only with 4 workers with a working directory:
  afl-cmin-
win.py -C --dry-run -w 4 --working-dir D:\dir -D D:\DRIO\bin32 -t 10000 -i in -i C:\fuzz\in -o
out_mini -covtype edge -coverage_module m.dll -target_module test.exe -target_method fuzz -nargs 2
-- test.exe @@

 * Read from specific file
  afl-cmin-win.py -D D:\DRIO\bin32 -t 100000 -i in -o
minset -f foo.ext -covtype edge -coverage_module m.dll -target_module test.exe -target_method fuzz
-nargs 2 -- test.exe @@

 * Read from specific file with pattern
  afl-cmin-win.py -D D:\DRIO\bin32
-t 100000 -i in -o minset -f prefix-@@-foo.ext -covtype edge -coverage_module m.dll -target_module
test.exe -target_method fuzz -nargs 2 -- test.exe @@

Here is an output example:
D:\Codes\winafl>python winafl-cmin.py --dry-run -w 4 --working-dir D:\Downloads\winafl.x86.release -D D:\codes\DynamoRIO-Windows-6.2.0-2\bin32 -t 10000 -i in -i C:\fuzz\in -o minset -covtype edge -coverage_module x.dll -target_module x.exe -target_method fuzz -nargs 2 -- x.exe @@
corpus minimization tool for WinAFL by<EMAIL_ADDRESS>Based on WinAFL by<EMAIL_ADDRESS>Based on AFL by<EMAIL_ADDRESS>[+] CWD changed to D:\Downloads\winafl.x86.release.
[*] Testing the target binary...
[+] OK, 4446 tuples recorded.
[+] Found 267 test cases across: in, C:\fuzz\in.
[*] Instantiating 4 worker processes.
Processing file 266/267...1 processes nudged
Processing file 267/267...
[+] Found 12861 unique tuples across 265 files
  - 1 files triggered a hang
  - 1 files triggered a crash
[*] Finding best candidates for each tuple...
Processing tuple 12861/12861...
[+] Original set was composed of 267 files
[+] Effective set was composed of 265 files (total size 9 MB).
[+] Narrowed down to 85 files (total size 3 MB).
[+] Time elapsed: 52 seconds

Cheers!

Awesome! I tested it and it worked great.

Hi @ivanfratric @0vercl0k, great work you're doing here!
I have a question about winafl-cmin vs "total paths" found by WinAFL. Let's say that WinAFL shows me a "total paths" number of 2000 (meaning that I have 2000 files in the queue). Does that mean that WinAFL has found 2000 different paths? If that's the case, why is that when I'm running winafl-cmin I end up with just about 10% of the files?

Hi @rgerman,
I don't know the specifics of your target, but it is possible to end up with smaller set after minimization. Consider the following example:
File 1 has coverage A. It is added to the queue.
File 2 is discovered with coverage AB. It is added to the queue.
File 3 is discovered with coverage ABC. It is added to the queue.
Now after running minimization you end up only with file 3 as it also contains the coverage from 1 and 2.

Actually, that makes a lot of sense. I don't know why I didn't think of it!
Thank you very much!


Validate password in Devise::Models::Recoverable#reset_password

Related:
https://github.com/plataformatec/devise/pull/4456
https://github.com/plataformatec/devise/compare/v4.2.0...v4.2.1#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR7
I think that definition of validation should write on validate clause in model. and, Password validation is defined in the following code.
https://github.com/plataformatec/devise/blob/88724e10adaf9ffd1d8dbfbaadda2b9d40de756a/lib/devise/models/validatable.rb#L33
Why need a password validation in Devise::Models::Recoverable#reset_password?
I think don't need password validation in Devise::Models::Recoverable#reset_password.

The password is not validated when it's nil, as you can see in password_required?. This means that if no password is provided within the reset password request, the request would succeed without actually performing the password change, and we want it to fail - because you're resetting your password.
Please check #4397 for more information. If you have more thoughts on why it should be different, we'll be happy to reopen and discuss. Thanks!


liblemon does not include header files

Describe the bug
fatal error: 'lemon/list_graph.h' file not found
seems liblemon headers are not included
but if add another library, it can be used, because other lib include correct vcpkg fiels
Environment

OS: Mac Intel
Compiler: clang16

To Reproduce
Steps to reproduce the behavior:

./vcpkg install liblemon

add_executable(test_lemon "src/test_lemon.cc")
target_link_libraries(test_lemon PRIVATE unofficial::lemon::lemon)
Expected behavior
headers should be included

@Vincent-bin
Please try #33130 to see if it works or not.

You can use following commands to get and apply patches and then install it.
curl -Ls https://github.com/microsoft/vcpkg/pull/33130.patch | git apply
vcpkg install libphonenumber

After this pr got merged, you may want to drop your local changes via
git checkout .
git clean -fd

@Vincent-bin Please try #33130 to see if it works or not.
You can use following commands to get and apply patches and then install it.
curl -Ls https://github.com/microsoft/vcpkg/pull/33130.patch | git apply
vcpkg install liblemon

After this pr got merged, you may want to drop your local changes via
git checkout .
git clean -fd

I add target include files explicitly, it works now still thank you  very much

@Vincent-bin

I add target include files explicitly, it works now still thank you very much

Glad to hear you work it out.
But there is stiil a bug in this port. And #33130 will fix it.
I would appreciate it if you could test this pr and give feedback.

https://github.com/microsoft/vcpkg/pull/33130 will fix this issue.


Add Snack Chats to the Video App

This pull requests demonstrates how to add "Snack Chats" to the video app using DataTracks. Follow along in our tutorial here: https://www.twilio.com/blog/open-source-video-app-reactjs-datatrack-snack-chat

Good news! Real-time chat has been added to this Video App with the Twilio Conversations SDK. More information can be found in this blog post: https://www.twilio.com/blog/open-source-video-chat-app-reactjs-conversations-api


Update T000274.md

Fix stale reference to Counterexamples.

Completely unrelated to this PR, but just a question I have.  What is a "slug"?  What does that do?

https://en.wikipedia.org/wiki/Slug_(publishing) For example, counting is the slug for my blog post here https://clontz.org/blog/2022/03/31/counting/
Basically for us, it's a pattern in software to have an alternative semantic unique identifier (e.g. t_0) to use in place of a numerical ID (e.g. P000001). I don't think we actually use this on the viewer in its current form though, so maybe it's vestigial.


Cant find the Downloaded files after the download

I downloaded 201 files from a playlist. The data was consumed from the ISP but I couldn't find the videos in the destination folder.
Errors.txt
I have attached the errors.txt file for reference and I have tried running as an administrator.
please help me find the videos

Never seen this error before, can you show me what playlist you were trying to download, and what settings you were using?

https://www.youtube.com/playlist?list=PLd3UqWTnYXOmx_J1774ukG_rvrpyWczm0

I tried downloading it and it works, I stopped after a few videos were downloaded successfully.
I'm sorry but I can't reproduce the issue and the log does not help me solve the problem. You can try downloading it again, maybe it will work. If the files are not showing the in the output directory its either because of insufficient permissions (which wouldn't make sense because you ran it as administrator) or because the ffmpeg process throws an error, which shouldn't happen either.
You can try reinstalling if the problem isn't solved and if that doesn't work then I'm not sure what would be causing it

okay, Thanks for the quick response
Is there a temp folder where I can find the video dumped?
because the data to download the videos was used from my ISP

If you didn't exit the program or restarted your computer, it should be at %temp%/YoutubePlaylistDownloader.


Hackage

This port actually went a lot smoother than I thought. I'll keep polishing it and see if we get any more issues but I'll plan on first public release on Hackage end of February. I'll be giving a bunch of talks in Europe so would be nice to have all the software publically downloadable.

Sorry for the lack of response on my part! I’ve somehow managed to miss this issue. Feel free to make a release when you think it’s ready. I’m generally in favor of release early, release often so I don’t think there is anything stopping a release.

indeed, I just closed the issue because I realized it was far past February. :wink:

Any continued plans for putting it up on Hackage these days? Chers


Can you split project into high/low-level and infrastructure modules?

Hi! I think you have done a lot of work. But the design of the project does not look simple and friendly. Because of this, we need to apply a lot of effort to understand this project.
Maybe if you decompose project into base/high/low-level logic and helpers/utils, it gets more friendly?
I think many users need only a thin wrapper for binance api. Caching, rate limiting, asset/symbol list is good features but I rather want to do it myself and for every exchange.

Hi. Thanks for the feedback. It has been a challenge trying to keep this project complete and easy to use (for both experienced and inexperienced developers) ...I'm not sure if I have succeeded either.
From what perspective, specifically, does this project not look simple and friendly? The documentation (on my todo list), the code (can't help that much), the examples (I don't know if this can be simpler), the interface (and comments, which could be better), other? Basically what was your approach and when did you find difficulty (not simple)?
To help more advanced users understand the project I created the architecture diagram with shows where the high and low-level classes exist and their relationship. I don't think separation into separate modules would help much since high-level uses low-level. They are already separated by namespaces, so, I assume this is really a documentation issue (which I know needs work). I did consider separating API and WebSocket into separate libraries due to dependencies, but for no other reason. Also, the thin wrapper is (low-level) BinanceHttpClient, which returns JSON responses.

I changed the description to hopefully curb some expectations (including your own). I considered removing the "easy of use" part for some time. Long before this issue, it became apparent that easy is relative/subjective and makes for an impossible requirement, like trying to please everyone all the time. Having that as part of the description makes it seem like a requirement. I still, of course, will try to make this library easy to use regardless.

I will look into adding some boundaries to the architecture diagram. I think I wanted to make the diagram as small as possible at the time. I did add color to highlight which classes are top-level. Regardless, this and the associated text was meant for those getting deep into the code, not really as a starting point.

I know there are many classes in the root namespace. That was intentional to simplify namespace usage. Because some of the simplest examples required including several namespaces and it also seemed at times people were having difficulty finding methods (not easy to use), not knowing what namespace to include. I also, had extensions/helpers behind Binance.Extensions, but that seemed unnecessary. Keeping in mind, from a user's perspective, they shouldn't care what methods are direct and what are helpers.
Perhaps I took namespace simplification too far, at least in your case; I will look at namespace separations again. However, for me, this seems like just another aspect of trying to please everyone all the time... when I respond to issues like this I also have to make assumptions for all those that haven't said anything and I tend to ping-pong back and forth until hopefully I reach a least painful middle-ground 😄. It would be great if I could ask my entire user base and have them vote on some of the changes, but that doesn't seem feasible.

I agree the root Extensions folder has too many classes. So, I moved them to their respective namespace Extensions folders (new folders created, but no namespace changes).

So, I've read the majority of Clean Architecture by Robert C. Martin now, and it hasn't changed my thinking.
Getting back to your original comment/question... I don't plan to separate this library. I consider the use of partial boundaries with recent changes enough. Also, some of the "helper" functionality will eventually be applied to "every exchange" ...as I've mentioned to others, that will be part of the next evolution of this API.


Unepic [PCSB00841]

App summary

App name: Unepic
App serial: PCSB00841

Vita3K summary

Version: v0.1.5
Build number: 2619
Commit hash: https://github.com/Vita3K/Vita3K/commit/37c9be4625e996e93fda5e4c6a438b21a8251c4e
CPU backend: Dynamic

Test environment summary

Tested by: GamingDucking/Forenzik
OS: Windows 10
CPU: Intel
GPU: Intel Graphics 520
RAM: 4 GB

Issues
Only problem is that if you selected "Start new game", the graphics doesn't appear.
However, if you selected "Start new game skipping tutorial", the graphics will appear.
Screenshots

Log
vita3k.log
Recommended labels

Ingame +
Audio Quality

All above issues are fixed and the game plays without issues

I tried adding the game as a zip file and it's stuck at 69%.


chore: clang format based on coding conventions

Co-Authored-By: Leonardo Di Donato<EMAIL_ADDRESS>Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Clang format based out to our coding conventions.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

@fntlnz: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

Co-Authored-By: Leonardo Di Donato<EMAIL_ADDRESS>Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Clang format based out to our coding conventions.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fntlnz: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: e52600eba0bbfa57e47b2f2e33841d88fd8c478b

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leodido, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leodido,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


JIRA issues get created twice

Bug description
FYI @Apipia
On a production system with no changes, and after updating to the latest dev today, my JIRAs get created twice.
We can see in the trace at the bottom that Trying to create a new JIRA issue appears twice.
The most blatant log is when it tries to create the second jira and the unique key constraint fails on the DB:
celeryworker_1  | [2020-04-24 09:52:09,709: ERROR/MainProcess] Task add_issue_task[71fe9c12-0d1d-4ad4-8d4f-61dc9c7a6dce] raised unexpected: IntegrityError(1062, "Duplicate entry '62002' for key 'finding_id'")
celeryworker_1  | Traceback (most recent call last):
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django_prometheus/db/common.py", line 68, in execute
celeryworker_1  |     return super(CursorWrapper, self).execute(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/mysql/base.py", line 71, in execute
celeryworker_1  |     return self.cursor.execute(query, args)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 209, in execute
celeryworker_1  |     res = self._query(query)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 315, in _query
celeryworker_1  |     db.query(q)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/connections.py", line 239, in query
celeryworker_1  |     _mysql.connection.query(self, query)
celeryworker_1  | MySQLdb._exceptions.IntegrityError: (1062, "Duplicate entry '62002' for key 'finding_id'")
celeryworker_1  |
celeryworker_1  | The above exception was the direct cause of the following exception:
celeryworker_1  |
celeryworker_1  | Traceback (most recent call last):
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 385, in trace_task
celeryworker_1  |     R = retval = fun(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 650, in __protected_call__
celeryworker_1  |     return self.run(*args, **kwargs)
celeryworker_1  |   File "/app/dojo/tasks.py", line 269, in add_issue_task
celeryworker_1  |     add_issue(find, push_to_jira)
celeryworker_1  |   File "/app/dojo/utils.py", line 1379, in add_issue
celeryworker_1  |     j_issue.save()
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 741, in save
celeryworker_1  |     force_update=force_update, update_fields=update_fields)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 779, in save_base
celeryworker_1  |     force_update, using, update_fields,
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 870, in _save_table
celeryworker_1  |     result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 908, in _do_insert
celeryworker_1  |     using=using, raw=raw)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/manager.py", line 82, in manager_method
celeryworker_1  |     return getattr(self.get_queryset(), name)(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py", line 1186, in _insert
celeryworker_1  |     return query.get_compiler(using=using).execute_sql(return_id)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/sql/compiler.py", line 1375, in execute_sql
celeryworker_1  |     cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 67, in execute
celeryworker_1  |     return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 76, in _execute_with_wrappers
celeryworker_1  |     return executor(sql, params, many, context)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/utils.py", line 89, in __exit__
celeryworker_1  |     raise dj_exc_value.with_traceback(traceback) from exc_value
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django_prometheus/db/common.py", line 68, in execute
celeryworker_1  |     return super(CursorWrapper, self).execute(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/mysql/base.py", line 71, in execute
celeryworker_1  |     return self.cursor.execute(query, args)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 209, in execute
celeryworker_1  |     res = self._query(query)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 315, in _query
celeryworker_1  |     db.query(q)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/connections.py", line 239, in query
celeryworker_1  |     _mysql.connection.query(self, query)
celeryworker_1  | django.db.utils.IntegrityError: (1062, "Duplicate entry '62002' for key 'finding_id'")

Steps to reproduce
Steps to reproduce the behavior:

Product is setup for JIRA. No checkboxes tick (issues are manually pushed)
Go to a finding and edit it
Click the "push to jira" button to create the issue in JIRA
2 issues get created in JIRA, but the first one is the one that sticks, given the stacktrace above.

Expected behavior
Only one issue gets created.
Deployment method (select with an X)

[ ] Kubernetes
[x] Docker
[ ] setup.bash / legacy-setup.bash

Environment information

DefectDojo Commit Message: [use git show -s --format="%h: %s [%ci]"]

064908cf: Merge remote-tracking branch 'refs/remotes/origin/dev' into dev [2020-04-24 08:06:22 +0000]
Raw output from my docker-compose logs during the problem:
celeryworker_1  | Trying to create a new JIRA issue
uwsgi_1         | applying rules
uwsgi_1         | [pid: 18|app: 0|req: 1811/2252] <IP_ADDRESS> () {64 vars in 1980 bytes} [Fri Apr 24 09:52:00 2020] POST /finding/62002/edit => generated 0 bytes in 162 msecs (HTTP/1.1 302) 8 headers in 404 bytes (1 switches on core 1)
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:00 +0000] "POST /finding/62002/edit HTTP/1.1" 302 0 "https://defectdojo.cloudbees.com/finding/62002/edit" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36" "-"
uwsgi_1         | [pid: 18|app: 0|req: 1813/2253] <IP_ADDRESS> () {54 vars in 1767 bytes} [Fri Apr 24 09:52:01 2020] GET /alerts/count => generated 14 bytes in 35 msecs (HTTP/1.1 200) 6 headers in 180 bytes (1 switches on core 1)
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:01 +0000] "GET /alerts/count HTTP/1.1" 200 14 "https://defectdojo.cloudbees.com/finding/62002/edit" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36" "-"
uwsgi_1         | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1         | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1         | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1         | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1         | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1         | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1         | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1         | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1         | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1         | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1         | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1         | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1         | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1         | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1         | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1         | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1         | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1         | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1         | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.nl2br".
uwsgi_1         | Successfully loaded extension "markdown.extensions.nl2br.Nl2BrExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.sane_lists".
uwsgi_1         | Successfully loaded extension "markdown.extensions.sane_lists.SaneListExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.codehilite".
uwsgi_1         | Successfully loaded extension "markdown.extensions.codehilite.CodeHiliteExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.fenced_code".
uwsgi_1         | Successfully loaded extension "markdown.extensions.fenced_code.FencedCodeExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.toc".
uwsgi_1         | Successfully loaded extension "markdown.extensions.toc.TocExtension".
uwsgi_1         | Successfully imported extension module "markdown.extensions.tables".
uwsgi_1         | Successfully loaded extension "markdown.extensions.tables.TableExtension".
uwsgi_1         | Popen(['git', 'cat-file', '--batch-check'], cwd=/app, universal_newlines=False, shell=None, istream=<valid stream>)
uwsgi_1         | [pid: 18|app: 0|req: 1813/2254] <IP_ADDRESS> () {58 vars in 1949 bytes} [Fri Apr 24 09:52:00 2020] GET /finding/62002 => generated 74571 bytes in 1521 msecs (HTTP/1.1 200) 8 headers in 453 bytes (1 switches on core 0)
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:02 +0000] "GET /finding/62002 HTTP/1.1" 200 74571 "https://defectdojo.cloudbees.com/finding/62002/edit" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36" "-"
uwsgi_1         | [pid: 18|app: 0|req: 1814/2255] <IP_ADDRESS> () {54 vars in 1619 bytes} [Fri Apr 24 09:52:05 2020] GET /alerts/count => generated 14 bytes in 18 msecs (HTTP/1.1 200) 6 headers in 180 bytes (1 switches on core 1)
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:05 +0000] "GET /alerts/count HTTP/1.1" 200 14 "https://defectdojo.cloudbees.com/finding/62002" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36" "-"
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:05 +0000] "GET / HTTP/1.1" 302 0 "-" "Datadog Agent/0.0.0" "-"
uwsgi_1         | [pid: 15|app: 0|req: 442/2256] <IP_ADDRESS> () {40 vars in 533 bytes} [Fri Apr 24 09:52:05 2020] GET / => generated 0 bytes in 2 msecs (HTTP/1.1 302) 7 headers in 215 bytes (1 switches on core 1)
celeryworker_1  | [2020-04-24 09:52:07,840: INFO/MainProcess] Task add_issue_task[4133ed17-3289-44ee-9507-e67361fd41f8] succeeded in 7.508165678940713s: None
celeryworker_1  | [2020-04-24 09:52:07,844: INFO/MainProcess] Received task: async_dedupe[1a03fd55-8c2b-46c9-8ff7-27a7799d76bb]
celeryworker_1  | [2020-04-24 09:52:07,934: INFO/MainProcess] Task async_dedupe[1a03fd55-8c2b-46c9-8ff7-27a7799d76bb] succeeded in 0.08920459891669452s: None
celeryworker_1  | [2020-04-24 09:52:07,938: INFO/MainProcess] Received task: add_issue_task[71fe9c12-0d1d-4ad4-8d4f-61dc9c7a6dce]
celeryworker_1  | [2020-04-24 09:52:07,939: INFO/MainProcess] add_issue_task[71fe9c12-0d1d-4ad4-8d4f-61dc9c7a6dce]: add issue task
celeryworker_1  | Trying to create a new JIRA issue
uwsgi_1         | [pid: 15|app: 0|req: 443/2257] <IP_ADDRESS> () {54 vars in 1628 bytes} [Fri Apr 24 09:52:08 2020] GET /alerts/count => generated 14 bytes in 37 msecs (HTTP/1.1 200) 6 headers in 180 bytes (1 switches on core 0)
nginx_1         | <IP_ADDRESS> - - [24/Apr/2020:09:52:08 +0000] "GET /alerts/count HTTP/1.1" 200 14 "https://defectdojo.cloudbees.com/product/19/engagements" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.92 Safari/537.36" "-"
celeryworker_1  | [2020-04-24 09:52:09,709: ERROR/MainProcess] Task add_issue_task[71fe9c12-0d1d-4ad4-8d4f-61dc9c7a6dce] raised unexpected: IntegrityError(1062, "Duplicate entry '62002' for key 'finding_id'")
celeryworker_1  | Traceback (most recent call last):
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django_prometheus/db/common.py", line 68, in execute
celeryworker_1  |     return super(CursorWrapper, self).execute(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/mysql/base.py", line 71, in execute
celeryworker_1  |     return self.cursor.execute(query, args)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 209, in execute
celeryworker_1  |     res = self._query(query)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 315, in _query
celeryworker_1  |     db.query(q)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/connections.py", line 239, in query
celeryworker_1  |     _mysql.connection.query(self, query)
celeryworker_1  | MySQLdb._exceptions.IntegrityError: (1062, "Duplicate entry '62002' for key 'finding_id'")
celeryworker_1  |
celeryworker_1  | The above exception was the direct cause of the following exception:
celeryworker_1  |
celeryworker_1  | Traceback (most recent call last):
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 385, in trace_task
celeryworker_1  |     R = retval = fun(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 650, in __protected_call__
celeryworker_1  |     return self.run(*args, **kwargs)
celeryworker_1  |   File "/app/dojo/tasks.py", line 269, in add_issue_task
celeryworker_1  |     add_issue(find, push_to_jira)
celeryworker_1  |   File "/app/dojo/utils.py", line 1379, in add_issue
celeryworker_1  |     j_issue.save()
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 741, in save
celeryworker_1  |     force_update=force_update, update_fields=update_fields)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 779, in save_base
celeryworker_1  |     force_update, using, update_fields,
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 870, in _save_table
celeryworker_1  |     result = self._do_insert(cls._base_manager, using, fields, update_pk, raw)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/base.py", line 908, in _do_insert
celeryworker_1  |     using=using, raw=raw)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/manager.py", line 82, in manager_method
celeryworker_1  |     return getattr(self.get_queryset(), name)(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/query.py", line 1186, in _insert
celeryworker_1  |     return query.get_compiler(using=using).execute_sql(return_id)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/models/sql/compiler.py", line 1375, in execute_sql
celeryworker_1  |     cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 67, in execute
celeryworker_1  |     return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 76, in _execute_with_wrappers
celeryworker_1  |     return executor(sql, params, many, context)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/utils.py", line 89, in __exit__
celeryworker_1  |     raise dj_exc_value.with_traceback(traceback) from exc_value
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/utils.py", line 84, in _execute
celeryworker_1  |     return self.cursor.execute(sql, params)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django_prometheus/db/common.py", line 68, in execute
celeryworker_1  |     return super(CursorWrapper, self).execute(*args, **kwargs)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/backends/mysql/base.py", line 71, in execute
celeryworker_1  |     return self.cursor.execute(query, args)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 209, in execute
celeryworker_1  |     res = self._query(query)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/cursors.py", line 315, in _query
celeryworker_1  |     db.query(q)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/MySQLdb/connections.py", line 239, in query
celeryworker_1  |     _mysql.connection.query(self, query)
celeryworker_1  | django.db.utils.IntegrityError: (1062, "Duplicate entry '62002' for key 'finding_id'")

And along the way got another one, weird. Surely unrelated.
0-5bb1-4e90-88c6-d5429c054cf4] raised unexpected: TypeError("Can't convert 'NoneType' object to str implicitly",)
celeryworker_1  | 2020-04-24T10:28:46.789614525Z Traceback (most recent call last):
celeryworker_1  | 2020-04-24T10:28:46.789618441Z   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 385, in trace_task
celeryworker_1  | 2020-04-24T10:28:46.789621840Z     R = retval = fun(*args, **kwargs)
celeryworker_1  | 2020-04-24T10:28:46.789624693Z   File "/usr/local/lib/python3.5/site-packages/celery/app/trace.py", line 650, in __protected_call__
celeryworker_1  | 2020-04-24T10:28:46.789627685Z     return self.run(*args, **kwargs)
celeryworker_1  | 2020-04-24T10:28:46.789630404Z   File "/app/dojo/tasks.py", line 269, in add_issue_task
celeryworker_1  | 2020-04-24T10:28:46.789633695Z     add_issue(find, push_to_jira)
celeryworker_1  | 2020-04-24T10:28:46.789640900Z   File "/app/dojo/utils.py", line 1372, in add_issue
celeryworker_1  | 2020-04-24T10:28:46.789646471Z     jira_conf.finding_text),
celeryworker_1  | 2020-04-24T10:28:46.789651504Z   File "/app/dojo/utils.py", line 1288, in jira_long_description
celeryworker_1  | 2020-04-24T10:28:46.789654437Z     find_id) + "\n\n" + jira_conf_finding_text

So, it happens a first time at
https://github.com/DefectDojo/django-DefectDojo/blob/dev/dojo/finding/views.py#L1135
then right after that at
https://github.com/DefectDojo/django-DefectDojo/blob/dev/dojo/models.py#L1861

Unsure what to do here @Apipia .
Maybe until we decide to fully clean the implementation of "issue tracker", we should just remove the models.py if statement and let is be in the views.py. I will create a PR in that sense to apply immediately on my prod instance.


update file ScreenCapturerAndroid.java from official commit https://w…

update file ScreenCapturerAndroid.java from official commit
this can slove #82

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

Thank you for the recognition. I'm eager to hear @kanat's thoughts on the changes.

Hi @gongluck,
Thank you for the contribution ❤
Would you mind moving this fix to our main WebRTC repo:

https://github.com/GetStream/webrtc/blob/main/sdk/android/api/org/webrtc/ScreenCapturerAndroid.java

Cheers!

Hi @gongluck,
Thank you for the contribution ❤
Would you mind moving this fix to our main WebRTC repo:

https://github.com/GetStream/webrtc/blob/main/sdk/android/api/org/webrtc/ScreenCapturerAndroid.java

Cheers!

Oh, I didn't notice. GetStream's main webrtc repository has updated the ScreenCapturerAndroid source file, so it should be fine. But the current webrtc-android repository is not updated together?


Collapse/Hide at different breakpoints?

Can grid-styled support collapsing/hidding an element (Box) at different breakpoints? I need this along w flex order to build a responsive layout. Thanks

I put together this library for such things https://github.com/jxnblk/hidden-styled – but don't think this sort of functionality belongs in grid-styled. You can also extend any grid-styled component with styled-components to suite your needs, e.g. styled(Box)


Use only a single ray query for whole triangles

Must ensure we have a triangle intersect function that will not allow rays to slip through gaps, though.
Related to #99, as well, since we can use this for clipped triangles, as well, if we know already that triangles are intersecting in a coplanar way.

Potentially a savings of almost ~10% for the geometry example


Change balances to Gwei

See discussion here https://github.com/ethereum/eth2.0-specs/issues/34

I think this is a good call. I know prysmatic has been seeking a suitable bigint library but this will remove that requirement outside of the context of the WASM implementation


Fixes #14 and #18

Replaced javascript dependencies by CDN urls instead of the webjars that appeared to be unstable.

Awesome, thanks!  I'll release this to central once I take a look at some other bugs tomorrow.

Great, thanks!

This is released in 3.5.0, syncing to central now.


Simplify access to the Windows file system

╭─root@XS-WanFengDesktop in /mnt/d/.repos/.github/xs-fork/dubbo on jdk19 ✔ (origin/jdk19)
╰$

As above:
When I need a long path to access files in D drive, can the prefix / mnt/ d be simplified to, such as/ d /?
Or provide built-in commands to directly access Windows common directories.
For example:
C Driver: wdc.
D Driver: wdd.
E Driver:wde.
User Profile Home:wup.
User Home Download:wud

It can be changed with automount.root option in wsl.conf file. See https://learn.microsoft.com/en-us/windows/wsl/wsl-config#wslconf

Put the following in /etc/wsl.conf:
[automount]
root = /

There are more interesting options (like metadata), please have a look at the documentation @Biswa96 linked.

@oldium @Biswa96
It is still not convenient enough
root = /
It only solves the simplification of drive access, but it is like the access of common directories in Windows.
I think some need to provide environment variables, so that there are relevant standards for the adaptation of multiple environments for the development of some projects.
For example, compile the directory to get Windows UserProfile under WSL.
These environment variables should also exist in WSL2 Linux.

For example, compile the directory to get Windows UserProfile under WSL.

Set the WSLENV variable like this in Command Prompt set WSLENV=USERPROFILE/p and then run wsl.exe. The user profile environment variable will be passed to wsl. See https://devblogs.microsoft.com/commandline/share-environment-vars-between-wsl-and-windows/

For example, compile the directory to get Windows UserProfile under WSL.

Set the WSLENV variable like this in Command Prompt set WSLENV=USERPROFILE/p and then run wsl.exe. The user profile environment variable will be passed to wsl. See https://devblogs.microsoft.com/commandline/share-environment-vars-between-wsl-and-windows/

Yes, why not bring these commonly used ones directly to WSL2?
We still need to set it separately!

If you need a better access, create links in WSL to your Windows folders you need.

Yes, why not bring these commonly used ones directly to WSL2?

Because someone may use the USERPROFILE variable in WSL2 with different value irrespective of what the value is in Windows side.


lfn check failed for existing logical_file_name

Below existing logical_file_name cannot pass Lexicon.py and these are valid lfns.
/store/Generators/2008/3/12/RelVal-tt3j-madgraph-1205358838/0000/069E0626-C9F0-DC11-8041-003048561854.root
/store/Generators/2008/3/29/RelVal-tt3j-madgraph-1206775163/0009/B87DC6FB-D5FD-DC11-8FDE-000423DD2F34.root

another group of valid lfns cannot pass Lexicon:
/store/data/h2tb2007/testbeam_HCalEcalCombined/RAW/default_v1/h2.00015635.0008.edm.storageManager.0.0000.root

Tier0 LFNs don't work either anymore. Probably all related to #5905

@yuyiguo, Hi Yuyi which call is failing? could you point me the error message.

Tier0 is slightly cases, I had a bug in #5905 but not the lexicon problem.
I looked that https://twiki.cern.ch/twiki/bin/viewauth/CMS/DMWMPG_Namespace
and the format provided for generator file is a little different. I guess we can support both but twiki page need to be updated as well.
@belforte, Stefano, are you maintaining that twiki? Could you confirm the formats supported for generator file?
Thanks,

Also if some one can confirm what each part maps in
https://github.com/dmwm/WMCore/blob/master/src/python/WMCore/Lexicon.py#L24
/store/Generators/2008/3/12/RelVal-tt3j-madgraph-1205358838/0000/069E0626-C9F0-DC11-8041-003048561854.root
I guess '/2008/3/12/' date.
Is this some old style tier0?
/store/data/h2tb2007/testbeam_HCalEcalCombined/RAW/default_v1/h2.00015635.0008.edm.storageManager.0.0000.root
I can change the lexicon to pass these specific lfns but if some one can give a general rules. I will appreciate that. @ericvaandering, Eric?

Why would we modify our current definition of what could be put into DBS to satisfy something put in in 2007 or 2008? Surely today we would have the first example go under /store/generator and the latter go into /store/group?
If needed, maybe we can have a "legacy" regex so we don't cause problems with data existing in DBS, but we don't actually want new data coming in with those patterns.

Aren't there already different checks for input validation and output validation ? We just need this to be a valif LFN for the former, not the latter.

I think it is reading from dbs not putting to dbs? Yuyi, is dbs using the same lfn check for reading and writing as Dirk said? (FIY, We don't have validation /store/generator in lexicon currently - at least we can add that).

DBS GET and POST are using different validation functions. However, for the POST calls that actually search the DB because one wants to supply DBS with a long list of lfns, lumis, or runs. We have no way to know it is a select or insert in validation level with current code.
I  found another set of lfns that cannot pass lexicon.py.
'/store/data/h2tb2007/testbeam_HCalEcalCombined/RAW/default_v1/h2.00014493.0000.edm.storageManager.0.0000.root', '/store/data/h2tb2007/testbeam_HCalEcalCombined/RAW/default_v1/h2.00014494.0002.edm.storageManager.0.0000.root', '/store/data/h2tb2007/testbeam_HCalEcalCombined/RAW/default_v1/h2.00015535.0035.edm.storageManager.0.0000.root'

I think we have to maintain 2 different validation for the post call as well (one for insert and one for select). Changing validation for 'insert' to read legacy data will cause wrong format to get inserted.
Yuyi, could you point me the code where the validation occur for the POST call? If not possible to distinguish at the time of the validation occurs, can we revalidate before the insert call happens?

This is where DBS call happends
https://github.com/dmwm/DBS/blob/master/Server/Python/src/dbs/utils/DBSInputValidation.py#L289
As I said that DBS has generic validation for POST and GET. But when POST is used for searching we have to use the POST validation.
I found there are a lot of existing lfns that could not past current Lexicon.lfn test.

I was more talking about how the post calls the validation function not the validation function it self. Anyway, looking at the code, it doesn't seem to validate the same way for all post calls. (I might be wrong though)
i.e. for this post call instead of using the same validation you can use relaxed validation since it is reader option, isn't it?
https://github.com/dmwm/DBS/blob/master/Server/Python/src/dbs/web/DBSReaderModel.py#L470

what exactly breaks if you do not change anything ? @yuyiguo  how did you find the LFN's in your initial posting ? Where they tripping something ?

I was testing the limit on some of the DBS APIs to see what is the maximum lnfs I can have in a list and the API can be finished in reasonable time. So I just got random lfns in DBS, but when I used them for query, they could not pass input validation if the call was POST. This is because DBS POST call are using Lexicon.py. I will have to rewrite some part of the validation code not to use the Lexicon.py for searching the DBS. So far no one  compliainted so I guess these datasets I found was not popular ones.

indeed simulated datasets from 2008, or data imported from pre-Run1 test beam are very likely not to
be searched for by anyone, especially not starting with a LFN fragment !
Anyhow using a relaxed regexp check when searching should be the best solution, IIRC we have this
for dataset names already. Simply do not put too much effort into this and it is not worth any
ad-hoc patching. By the way, user searches will start in DAS, usually, so need to make sure that if
Lexicon has two regexp checks there, DAS uses the "correct" one.

I discussed with Yuyi yesterday. We (WMCore side) won't change or maintain Lexicon for relaxed validation. DBS will handle for the search validation. Thanks, created the new issue https://github.com/dmwm/DBS/issues/475 Thanks


"Contract code size exceeds 24576 bytes" during coverage

In #288  we've seen a warning during the coverage phase in CI. This is not urgent but deserves a look at.
/home/travis/build/HQ20/contracts/.coverage_contracts/examples/dao/VentureEth.sol:26:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract VentureEth is
^ (Relevant source part starts here and spans across multiple lines).
,/home/travis/build/HQ20/contracts/.coverage_contracts/examples/dao/DAO.sol:22:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract DAO is VentureEth, Democratic {
^ (Relevant source part starts here and spans across multiple lines).
,/home/travis/build/HQ20/contracts/.coverage_contracts/exchange/UniswapFactory.sol:49:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract UniswapFactory is IUniswapFactory {
^ (Relevant source part starts here and spans across multiple lines).
,/home/travis/build/HQ20/contracts/.coverage_contracts/test/exchange/TestUniswapExchange.sol:5:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract TestUniswapExchange is UniswapExchange {
^ (Relevant source part starts here and spans across multiple lines).
,/home/travis/build/HQ20/contracts/.coverage_contracts/test/exchange/TestUniswapFactory.sol:6:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract TestUniswapFactory is UniswapFactory {
^ (Relevant source part starts here and spans across multiple lines).

Background for this. I can't believe they thought that choosing a hard coded limit was a good idea.
https://github.com/ethereum/EIPs/issues/170
On the bright side, this is a good opportunity to explore some techniques to make contracts lighter.

Reading this thread makes me sad. Mostly because the amount of people impacted by this and how little concern is there for them.
Not to mention that the workarounds being proposed sound complex as hell.

please help me.

please help me.

hi LuckyStar0831 ,i modified the hardhat.config and i added this.hopw its works for u!

please help me.

please help me.

hi LuckyStar0831 ,i modified the hardhat.config or the truffle instead. and i added this.hopw its works for u!
module.exports = {
  solidity: {
    version: "0.8.3",
    settings: {
      optimizer: {
        enabled: true,
        runs: 1000,
      },
    },
  },
};

Thank you for your  interest.
But it's not working on my side.


Don't fail if nltk downloads don't work

hi @csurfer, thanks for your work here!
I found I had to make this change in order to be able to be able to install the package as part of a serverless app to deploy on AWS lambda. In that context it doesn't really make sense to force download the NLTK data as part of the install of your package. In fact, the install failed because it didn't have access to nlltk at build time.

hey @csurfer did you get the chance to take a look at this?


More info added to README

Closes #4 #5 #6 #7
Note: Sorry for the incorrect branch name
Changelog

Create GitHub account added to TODO list
Fork repo step added to TODO list
Updated SheCanCode Project list repo step add to TODO list
Added links to documentation where relevant

Thanks for this PR.
Not sure I like the uppercase titles, but that's just a detail.

Not sure I like the uppercase titles, but that's just a detail.

I will change this back. See #10


sqlite3.OperationalError: database is locked

Hi,
I am testing out Scoary-2 on some data I have previously used Scoary with, and I am getting the following error while it is running (but it does keep going)
Process Process-12: Traceback (most recent call last):   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap     self.run()   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/multiprocessing/process.py", line 108, in run     self._target(*self._args, **self._kwargs)   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/site-packages/scoary/analyze_trait.py", line 48, in worker     local_result_container[trait] = analyze_trait_fn(trait, new_ns, proc_id)   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/site-packages/scoary/analyze_trait.py", line 165, in analyze_trait_step_2_pairpicking     result_df['empirical_p'] = permute_picking(   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/site-packages/scoary/permutations.py", line 97, in permute_picking     CONFINT_CACHE.set(unique_topology, n_pos_assoc, n_permut, permuted_estimators)   File "/home/ubuntu/scratch/software/miniforge3/envs/scoary2/lib/python3.10/site-packages/scoary/permutations.py", line 36, in set     self.cur.execute( sqlite3.OperationalError: database is locked
This appears multiple times for different processes while running pair picking

Hm, try setting the environment variable CONFINT_DB to somewhere you have write permission. E.g.:
CONFINT_DB=/tmp/CONFINT_DB

Did it solve your issue?

I assume this solved the issue.


comp-lzo deprecated

Deprecated, not planned for removal (at this time), will be ignored with a printed warning.
Replacement, one of:
--compress
--compress lzo
--compress lz4
See: https://community.openvpn.net/openvpn/wiki/DeprecatedOptions

Thanks. I'll update


disallow filtering by encrypted_fields

Raise a PermissionDenied exception when attempting to get encrypted fields via ansible_base.rest_filters.utils::get_field_from_path, so such requests get handled in the same way that attempting to filter by a password field does.
No-Issue

Personally, I think having utils.py accept an allow-list of fields (rather than blocking attempts to filter over marked sensitive data) would be a better long term solution, but this should address the issue with our rest filters leaking sensitive data for now, assuming everyone marks their encrypted fields properly.

Rebased on devel.


Translations

Add a guide about adding new translations

Added a translations page but needs fleshing out https://github.com/NebraLtd/Helium-Guides/commit/d20fbfc6a71b89644f1b0743bf600b26d3a39a03


Universal SQL: Handle sparse source tables

Steps To Reproduce
Running @usql
Querying a bigquery table w/ a column containing only nulls, or mostly nulls, throws complaining of a mismatch to expected schema. This doesn't happen in cases where a single value is null, so my suspicion is a whole pagination block includes nulls.
Expected Behaviour
Nulls returned matching source table.

Confirmed all good


third_party headers shall be excluded from rerun_cpp_sdk

Describe the bug
The headers contains third_party folder with cxxopt.hpp which shan't be a part the SDK as it is external dependency and apparently isn't even needed in SDK. Could be added. If really needed, it could be added via CMake similarly to Arrow.
To Reproduce
Steps to reproduce the behavior:
Just check: https://github.com/rerun-io/rerun/tree/main/rerun_cpp/src/rerun/third_party
Expected behavior
No third_party folder
Rerun version
0.12.1

Mainly, it makes difficult license and copyright management. It just messes up the things when 3rdparty libraries (even header only) are distributed along with your own library. Rerun is distributed with Apache-2.0 and MIT licenses but cxxopt is redistributed as part of your library and has MIT license, this if one uses Rerun with Apache-2.0 then need to keep in mind that it also contains piece of code with MIT license.

btw, local workaround for us would be just to drop third_party folder at our side.


Don't add a newline after an arrow function expression (codegen)

Description:
emit_block_stmt_or_expr was adding a newline after expressions if cfg.minify was false.  Modifying this function to never add a trailing new line improves the codegen output for arrow function expressions by avoiding unecessary newlines.
As an example, (a, b) => a + b; was being emitted as:
(a + b) => a + b
;

After this change output will look like (a, b) => a + b;.
Test Plan:
cargo test -p swc_ecma_codegen --all-features

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

There are some test failures I need to fix.


Develop

Codecov Report

Merging #42 into main will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   97.30%   96.99%   -0.32%
==========================================
  Files          16       16
  Lines         483      499      +16
==========================================
+ Hits          470      484      +14
- Misses         13       15       +2

Impacted Files
Coverage Δ

euchrecli/abstract/human.py
100.00% <100.00%> (ø)

euchrecli/command/play.py
95.17% <100.00%> (-0.48%)
:arrow_down:

euchrecli/util/player_util.py
100.00% <100.00%> (ø)

euchrecli/abstract/computer.py
98.73% <0.00%> (-1.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edd018...515c9fc. Read the comment docs.


doc: update faulty links in build document

A few links in doc/build.md corrected on reading the docs to get a better understanding of the codebase

I would also like to note that I am unable to build on my pc with these features turned on, either with nix-shell or docker.
PC specs: Ubuntu 20.04, 8GB i5 7th Gen

I am unsure why, but nix shell doesn't seem to work. I have another update, let me push that as well.

We have updated all nix packages on behalf of commit dfccad1179ef747aa261c3c64b9a440b1d21bbba, though that does not explain your failure. But it might not be a bad idea to exit all nix-shell's, run nix-collect-garbage -d and try to enter nix-shell again. That will refetch/rebuild all dependencies of mayastor again. Let us know if that helped.  Would be good to discuss the issue on slack (kubernetes.slack.com #openebs) if you can join.

bors merge

bors retry


fix: temporarily remove heavy dependency in verb request code editor

Related to #2147
It was taking some time go patch the dependency, so I put this out in the mean time to reduce build times.

Oh shoot! I responded on the issue instead of here 🤦 https://github.com/TBD54566975/ftl/issues/2147

Going to pause this change for now since it doesn't seem to affect CI that much and we have other plans like tree shaking. Plus it's a very useful feature to just take away!