gnum4 is broken on staging

Describe the bug
The build of gnum4 is broken on staging. Probably broken in 9af75b49ecb672ee64a69ada43360dab89d08e59.
Steps To Reproduce
nix-build -A gnum4 on staging (c64a09f1eeea5a57849e74ca718a4dc9df1bc167)
Expected behavior
Build succeeds.
Additional context
Bisect log
git bisect start
# bad: [c64a09f1eeea5a57849e74ca718a4dc9df1bc167] Merge staging-next into staging
git bisect bad c64a09f1eeea5a57849e74ca718a4dc9df1bc167
# good: [da036efe0dd01d924d5c1532d4cec941b3fa023b] Merge pull request #135871 from abdelq/kmod-29
git bisect good da036efe0dd01d924d5c1532d4cec941b3fa023b
# good: [78503c4085759871735e77609eebe9aa9d3ef6bc] python3Packages.commoncode: 21.7.23 -> 21.8.27
git bisect good 78503c4085759871735e77609eebe9aa9d3ef6bc
# good: [2f5ea43e02a3ce3844fc28be2216cf92e26ae103] Merge master into staging-next
git bisect good 2f5ea43e02a3ce3844fc28be2216cf92e26ae103
# good: [2be182ab81d7cac34e01ad8858658b571bbb7e16] Merge pull request #136829 from r-ryantm/auto-update/bibletime
git bisect good 2be182ab81d7cac34e01ad8858658b571bbb7e16
# good: [42155910a0a499e9cc937ae89f022fcd5b551cf6] pkgsStatic.curl: fix build
git bisect good 42155910a0a499e9cc937ae89f022fcd5b551cf6
# good: [00f361a84625c1db9b3f4ed91ee9f35465133474] Merge pull request #129074 from bobby285271/pr11
git bisect good 00f361a84625c1db9b3f4ed91ee9f35465133474
# good: [5c0a3345a8001e9112404332920fad6caeea19e3] Merge pull request #136720 from alerque/vcsh
git bisect good 5c0a3345a8001e9112404332920fad6caeea19e3
# good: [4755c306472dbecb9422332fb5d77a3000e26594] Merge pull request #136915 from ncfavier/manualPages
git bisect good 4755c306472dbecb9422332fb5d77a3000e26594
# bad: [9af75b49ecb672ee64a69ada43360dab89d08e59] Merge remote-tracking branch 'upstream/staging-next' into staging
git bisect bad 9af75b49ecb672ee64a69ada43360dab89d08e59
# good: [745cf36f95eab6f8a50bb5d41470000f431f51d7] Merge branch 'staging-next-fix' into staging-next
git bisect good 745cf36f95eab6f8a50bb5d41470000f431f51d7
# good: [f238a66a7cd9a875ce72c9e2f56a5ed2abfe865f] Merge #136970: nixos/doc: resolve conflicts
git bisect good f238a66a7cd9a875ce72c9e2f56a5ed2abfe865f
# first bad commit: [9af75b49ecb672ee64a69ada43360dab89d08e59] Merge remote-tracking branch 'upstream/staging-next' into staging

Notify maintainers
cc @lukegb which did the merge that seems to be the culprit.
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.13.12, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210802_47e96bb`
 - channels(root): `"nixos-21.11pre312125.21c937f8cb1, nixpkgs-21.11pre303315.16105403bdd"`
 - channels(rick): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
attribute: gnum4

Yeah, this merge seems broken in a number of respects; it rolls a bunch of things back because it merged in 9af75b49ecb672ee64a69ada43360dab89d08e59...

OK, this should build again: I get /nix/store/f3y52hqby0m4pxx4fwp3kia32lc0h8lm-gnum4-1.4.19, which is what we were at at da036efe0dd01d924d5c1532d4cec941b3fa023b.


request help: Could not resolve host:

Issue description
When I install ingress-controller I start creating the route  ,  unable to synchronize configuration.
this is my ingress-log:
2021-03-29T10:35:41+08:00       error   apisix/upstream.go:119  failed to get upstream from APISIX      {"fullname": "default_web-huido_80", "url": "http://apisix-admin:9180/apisix/admin/upstreams/450a096f", "cluster": "", "error": "Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}
2021-03-29T10:35:41+08:00       error   state/builder.go:176    failed to find upstream default_web-huido_80: Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
2021-03-29T10:36:44+08:00       error   apisix/upstream.go:119  failed to get upstream from APISIX      {"fullname": "default_web-huido_80", "url": "http://apisix-admin:9180/apisix/admin/upstreams/450a096f", "cluster": "", "error": "Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}
2021-03-29T10:36:44+08:00       error   controller/endpoint.go:146      failed to get upstream  {"upstream": "default_web-huido_80", "cluster": "name=; base_url=http://apisix-admin:9180/apisix/admin", "error": "Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)"}

this is  Request inside the container :
curl http://apisix-admin:9180/apisix/admin/upstreams/450a096f
curl: (6) Could not resolve host: apisix-admin; Unknown error

Environment

your apisix-ingress-controller version (output of apisix-ingress-controller version --long);
The packaged image of the current master version
your Kubernetes cluster version (output of kubectl version);
v 1.17.8
if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a).

@pioneer-hash I have re-organized the description so that it can be more clear. BTW, please add the environment information in the text.

This is because I changed the name generic type of the Charts.yaml file.  The Apisix address domain name in the Ingress-Controller should be consistent with the Charts name installed


[XGBoost4J-Spark] Early stopping and best iteration

This has been asked before (e.g https://github.com/dmlc/xgboost/issues/3140#issuecomment-369417119) but no answer was ever given.
In XGBoost4J-Spark we can use early stopping by using setNumEarlyStoppingRounds.

When I call transform(), does it use by default the best iteration (the best number of trees) or the best iteration + num_early_stopping_rounds?
If it uses the best iteration + num_early_stopping_rounds, how can I extract the value of the best iteration so I can set treeLimit to the best iteration?

Thanks

@wbo4958 probably has some insight.

@CodingCat

@hcho3

@candalfigomoro According to the code https://github.com/dmlc/xgboost/blob/master/jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/XGBoost.java#L253. Looks like "it uses the best iteration + num_early_stopping_rounds". And I have no idea how to get the values of the best iteration, Seems we need to support this.

@wbo4958 If you are interested in the feature, you can use the SetAttr function in XGBoost to store these attributes inside the model.  Also, we support model slicing to slice up trees for retuning the best model.  Feel free to ping me if you have any questions.

Hi @wbo4958 - I too wanted to use this feature in spark. Just wanted to know if you were able to work on it ? If not I can give it a try.

Hi @wbo4958 - I too wanted to use this feature in spark. Just wanted to know if you were able to work on it ? If not I can give it a try.

Sry, @naveenkb, I am busy with other things recently, pls help to add it . Thx very much

XGBoostClassificationModel object has a method called getVersion(). Not much info in the documentation. Based on the experimentation I did, booster.getVersion() / 2 always returns the latest iteration even with early stopping. So  ( (booster.getVersion() / 2) - earlyStoppingRound ) gives the bestIteration. Can anyone confirm this or if there are any cases when this won't work ?
@trivialfis or @wbo4958  or @CodingCat ?

@naveenkb
Suppose that you set max iterations=100, num_early_stopping_rounds=10 and the best iteration is iteration 95. If you take the number of iterations - num_early_stopping_rounds you get iteration 90 instead of iteration 95. So it doesn't work when num_early_stopping_rounds > max iterations - best iteration. The clean solution would be to expose bestScore and bestIteration.

@wbo4958 If you are interested in the feature, you can use the SetAttr function in XGBoost to store these attributes inside the model. Also, we support model slicing to slice up trees for retuning the best model. Feel free to ping me if you have any questions.

I have added bestIteration using SetAttr function. Regarding model slicing, I wanted to confirm that it is not implemented in Java yet right ? Please let me know if I am missing something

@wbo4958 If you are interested in the feature, you can use the SetAttr function in XGBoost to store these attributes inside the model. Also, we support model slicing to slice up trees for retuning the best model. Feel free to ping me if you have any questions.

I have added bestIteration using SetAttr function. Regarding model slicing, I wanted to confirm that it is not implemented in Java yet right ? Please let me know if I am missing something

There's a treeLimit parameter (see https://xgboost.readthedocs.io/en/latest/jvm/scaladocs/xgboost4j-spark/ml/dmlc/xgboost4j/scala/spark/XGBoostClassificationModel.html#setTreeLimit(value:Int):XGBoostClassificationModel.this.type), but I've never tried it.

We are in the process of replacing that parameter with more robust iteratiom_range.  Python and R have already made the transition, and JVM is the next.

@naveenkb
Are you going to submit a Pull Request to expose bestIteration and bestScore?

@candalfigomoro Sure. Sorry for the delay. I will raise a PR in few days.

Hello,
I was going through the parameters of the XGBoost 4J spark mentioned in .
I have two questions namely,

The definition of numEarlyStoppingRounds: is as follows:
If non-zero, the training will be stopped after a specified number of consecutive increases in any evaluation metric.
But shouldn't it be "the training will be stopped after a specified number of consecutive non-increase (same or decrease) in any evaluation metric"

Is there any parameter through which I can set a threshold for early stopping rounds? If the evaluation metric doesn't improve by at-least the threshold within early stopping rounds, the training stops.
Thanks,
Akshay

But shouldn't it be "the training will be stopped after a specified number of consecutive non-increase (same or decrease) in any evaluation metric"

This is tricky because some metrics need to be minimized (e.g. MSE) while other metrics need to be maximized (e.g. accuracy). See also the setMaximizeEvaluationMetrics() method.

@candalfigomoro  @naveenkb
How do you expose the bestIteration and bestScore attained during training?
Is it implemented in the package?

How do you expose the bestIteration and bestScore attained during training?
Is it implemented in the package?

`
.
.
.
val xgbClassificationModel = xgbClassifier.fit(train)
val bestScore = xgbClassificationModel.nativeBooster.getAttr("bestScore")
val bestIteration = xgbClassificationModel.nativeBooster.getAttr("bestIteration")
`

TODO: Follow up with documents.

This feature would very much be appreciated for XGBoost4J (non-spark) library as well. We have a situation where the evaluation function does not necessarily decrease as the loss decreases. In fact, in our situation the evaluation function can increase when the loss decreases too far. This is deliberate: we use a quantile loss function and a custom evaluation metric to ensure that the loss function does not decrease to zero (in which case the predictions are no longer quantiles).
The current implementation means that the model that is returned after early stopping rounds is far from optimal for many of our models, while a good performance was reached at earlier iterations.


wowza HLS urls for Roku

Coverage decreased (-0.05%) to 90.35% when pulling 1b7e888bf7d75669245cd48ecc890d6b2f35507a on peterbe:wowza-hls-urls-for-roku into 72742e9182fefed26ced92b4d8a4db79b1beff6b on mozilla:master.


Update template files and dependencies

This PR just updates the template files and dependencies to their latest versions in preparation of a 1.0.0 release.
The DI refactoring and update to Pydantic v2 already happened before.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.216%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
455

Relevant Lines:
510

💛  - Coveralls


Promisified create/save dont fail when overwritting same key

Minimal example:
const testSchema = new dynamoose.Schema({
  id: {
    type: String,
    required: true,
    hashKey: true,
  },
  name: {
    type: String,
    required: true,
  },
});

const TestModel = dynamoose.model('test', testSchema);

const item1 = {
  key: "0000",
  name: "Item 1"
};

Device.create(item1, { overwrite: false })
   .then((item) => console.log(item))
   .catch((err) => console.log(err));

Device.create(item1, { overwrite: false })
   .then((item) => console.log(item))
   .catch((err) => console.log(err));

Behaviour:
NewModel { id: '0000', name: 'Item 1' }
undefined

Expected behaviour:
NewModel { id: '0000', name: 'Item 1' }
<Some Error>

I do not know if this is the expected behaviour, but I would prefer to tackle a failed overwrite by using catch as it is easy to return a failed response in my API.
This might be related to #186, but I can confirm that I'm getting other exceptions such as 'Required value'.

@jacintoArias I think this may be corrected in #200.   I just merged it into the master branch.  Could you try updating dynamoose to the current master and let me know if you still have the issue?

The updated package now trows the expected exception and returns the following error:
NewModel { id: '0000', name: 'Item 1' }
The conditional request failed

thanks!


⚠ SceneTime has degraded performance

In da5ad4e, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 9897 ms

Resolved: SceneTime performance has improved in 63765e2 after 8 minutes.


[RUNTIME] Fix the function lookup problem for CUDA 11 driver

There was a function pointer lookup missing in the previous patch. https://github.com/triton-lang/triton/commit/f9f2960deef376da4ebc1ff8b1546051c66894a4

@atalman

Thank you for the followup fix. We'll try to automate testing for those going forward

Looks like we past the original error however still failing down the line:
root@08fe3942a639:/builder/test/smoke_test# python smoke_test.py --package torchonly --runtime-error-check disabled
torch: 2.4.0+cu118
ATen/Parallel:
	at::get_num_threads() : 8
	at::get_num_interop_threads() : 16
OpenMP 201511 (a.k.a. OpenMP 4.5)
	omp_get_max_threads() : 8
Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
	mkl_get_max_threads() : 8
Intel(R) MKL-DNN v3.4.2 (Git Hash 1137e04ec0b5251ca2b4400a4fd3c667ce843d67)
std::thread::hardware_concurrency() : 16
Environment variables:
	OMP_NUM_THREADS : [not set]
	MKL_NUM_THREADS : [not set]
ATen parallel backend: OpenMP

Skip version check for channel None as stable version is None
Testing smoke_test_conv2d
Testing smoke_test_linalg on cpu
Testing smoke_test_compile for cuda and torch.float16
Traceback (most recent call last):
  File "/builder/test/smoke_test/smoke_test.py", line 335, in <module>
    main()
  File "/builder/test/smoke_test/smoke_test.py", line 331, in main
    smoke_test_cuda(options.package, options.runtime_error_check, options.torch_compile_check)
  File "/builder/test/smoke_test/smoke_test.py", line 168, in smoke_test_cuda
    smoke_test_compile("cuda" if torch.cuda.is_available() else "cpu")
  File "/builder/test/smoke_test/smoke_test.py", line 252, in smoke_test_compile
    x_pt2 = torch.compile(foo)(x)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/eval_frame.py", line 433, in _fn
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 1116, in __call__
    return self._torchdynamo_orig_callable(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 948, in __call__
    result = self._inner_convert(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 472, in __call__
    return _compile(
  File "/usr/local/lib/python3.10/site-packages/torch/_utils_internal.py", line 84, in wrapper_function
    return StrobelightCompileTimeProfiler.profile_compile_time(
  File "/usr/local/lib/python3.10/site-packages/torch/_strobelight/compile_time_profiler.py", line 129, in profile_compile_time
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 817, in _compile
    guarded_code = compile_inner(code, one_graph, hooks, transform)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 636, in compile_inner
    out_code = transform_code_object(code, transform)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/bytecode_transformation.py", line 1185, in transform_code_object
    transformations(instructions, code_options)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 178, in _fn
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/convert_frame.py", line 582, in transform
    tracer.run()
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/symbolic_convert.py", line 2451, in run
    super().run()
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/symbolic_convert.py", line 893, in run
    while self.step():
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/symbolic_convert.py", line 805, in step
    self.dispatch_table[inst.opcode](self, inst)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/symbolic_convert.py", line 2642, in RETURN_VALUE
    self._return(inst)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/symbolic_convert.py", line 2627, in _return
    self.output.compile_subgraph(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/output_graph.py", line 1098, in compile_subgraph
    self.compile_and_call_fx_graph(tx, list(reversed(stack_values)), root)
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/output_graph.py", line 1318, in compile_and_call_fx_graph
    compiled_fn = self.call_user_compiler(gm)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/output_graph.py", line 1409, in call_user_compiler
    raise BackendCompilerFailed(self.compiler_fn, e).with_traceback(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/output_graph.py", line 1390, in call_user_compiler
    compiled_fn = compiler_fn(gm, self.example_inputs())
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/repro/after_dynamo.py", line 129, in __call__
    compiled_gm = compiler_fn(gm, example_inputs)
  File "/usr/local/lib/python3.10/site-packages/torch/__init__.py", line 1951, in __call__
    return compile_fx(model_, inputs_, config_patches=self.config)
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 1505, in compile_fx
    return aot_autograd(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/backends/common.py", line 69, in __call__
    cg = aot_module_simplified(gm, example_inputs, **self.kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 954, in aot_module_simplified
    compiled_fn, _ = create_aot_dispatcher_function(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_functorch/aot_autograd.py", line 687, in create_aot_dispatcher_function
    compiled_fn, fw_metadata = compiler_fn(
  File "/usr/local/lib/python3.10/site-packages/torch/_functorch/_aot_autograd/jit_compile_runtime_wrappers.py", line 168, in aot_dispatch_base
    compiled_fw = compiler(fw_module, updated_flat_args)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 1410, in fw_compiler_base
    return inner_compile(
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/repro/after_aot.py", line 84, in debug_wrapper
    inner_compiled_fn = compiler_fn(gm, example_inputs)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/debug.py", line 304, in inner
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 527, in compile_fx_inner
    compiled_graph = fx_codegen_and_compile(
  File "/usr/local/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/compile_fx.py", line 831, in fx_codegen_and_compile
    compiled_fn = graph.compile_to_fn()
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/graph.py", line 1749, in compile_to_fn
    return self.compile_to_module().call
  File "/usr/local/lib/python3.10/site-packages/torch/_dynamo/utils.py", line 231, in time_wrapper
    r = func(*args, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/graph.py", line 1699, in compile_to_module
    mod = PyCodeCache.load_by_key_path(
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/codecache.py", line 3062, in load_by_key_path
    mod = _reload_python_module(key, path)
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/runtime/compile_tasks.py", line 45, in _reload_python_module
    exec(code, mod.__dict__, mod.__dict__)
  File "/tmp/torchinductor_root/oq/coq63wn5k6yhq2rx3scb4s3emokvlh4jebbs3t7gdncmhpqgv56z.py", line 71, in <module>
    async_compile.wait(globals())
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/async_compile.py", line 247, in wait
    scope[key] = result.result()
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/codecache.py", line 3424, in result
    self.kernel.precompile()
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/runtime/triton_heuristics.py", line 232, in precompile
    compiled_binary, launcher = self._precompile_config(
  File "/usr/local/lib/python3.10/site-packages/torch/_inductor/runtime/triton_heuristics.py", line 440, in _precompile_config
    binary._init_handles()
  File "/triton/python/triton/compiler/compiler.py", line 386, in _init_handles
    self.module, self.function, self.n_regs, self.n_spills = driver.active.utils.load_binary(
torch._dynamo.exc.BackendCompilerFailed: backend='inductor' raised:
RuntimeError: Triton Error [CUDA]: device kernel image is invalid

@atalman one is expected to set TRITON_PTXAS_PATH to workaround this issue, and torch should do it automatically, see https://github.com/pytorch/pytorch/blob/7c45476d38176c8d5b19fb379fc073dc21beba64/torch/_inductor/runtime/compile_tasks.py#L51 (and PTXAS supposed to be packaged into the torch + cuda-11.8 wheel see https://github.com/pytorch/pytorch/pull/119750 )


update to "webpack-cli": "^3.1.1"

replaced using VS Code regex search
"webpack-cli": "^\S+"
"webpack-cli": "^3.1.1"
Every example was failing on an error like this:
> @ serve /Users/cameron/rs/wasm-bindgen/examples/hello_world
> webpack-dev-server

/Users/cameron/rs/wasm-bindgen/examples/hello_world/node_modules/webpack-cli/bin/config-yargs.js:89
				describe: optionsSchema.definitions.output.properties.path.description,
				                                           ^

TypeError: Cannot read property 'properties' of undefined
    at module.exports (/Users/cameron/rs/wasm-bindgen/examples/hello_world/node_modules/webpack-cli/bin/config-yargs.js:89:48)
    at Object.<anonymous> (/Users/cameron/rs/wasm-bindgen/examples/hello_world/node_modules/webpack-dev-server/bin/webpack-dev-server.js:84:40)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:279:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:752:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ serve: `webpack-dev-server`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ serve script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/cameron/.npm/_logs/2018-09-26T01_15_40_142Z-debug.log

Awesome, thanks!


Endless widget loading in Insiders

I'm currently seeing this in insiders bits. I'd assumed that this was due to my renderer API changes that hit monday (build ending with 7776) but I just rolled back to version ending with 888, which should still be supported and which doesn't have my renderer changes, and it exhibited the same issue.

I'm having something similar where my code cells are endlessly running.

@ryanbrownnetworking777 Do you have a code sample that repros this? That (along with the version of VS Code / Jupyter extension that you have) and I could help look into this.

Issues labeled with "Info needed" are closed if we do not receive more information from the issue author in 2 weeks. If you are the issue author and you still are running into this problem, please reactivate with additional information.


Include check for bytes in extract_value, fixes #72

@ChillFish8 I'm attempting to fix #72, would appreciate your eyes to check if I'm wildly off or not. I'm still quite new to the tantivy codebase.


Change not being merged causes ADA to be burned in fees

Take a look at the following transaction built using Lucid:
https://cardanoscan.io/transaction/dd41eb6bdce01088f9219c4a202582a598d3d928ac2f0d28e7c27abe200d98e5?tab=utxo
They paid 187ADA in fees. My guess is that the remaining change wasn't merged into any of the outputs. This may be a quite serious issue.

An additional output would have likely exceeded the transaction size, so the rest was added to fees. Not sure if it's an issue, just a preference. I don't understand how there is an output with 187 ADA. Did you decide to split the change in a custom way and then use lucid for adding the remaining change? The way out the assets are split into small batches doesn't look familiar.

I have played around a bit with Lucid and can confirm this issue. Change is not being merged into my outputs in some cases, leading to much higher fees than necessary. I have to manually make sure that I pay enough, because any change left is some times burned up completely as fees.

Change is not being merged into my outputs in some cases

Can you give me some examples so I can reproduce this?


Add raw code to generated file

Sometimes you want to add some generic code, but only after the generator ran. E.g. when you want to have a variable that has an initialized converter impl.
var Converter Converter = &ConverterImpl{}

Having this inside the conversion interface will cause compile errors. This issue proposes a new setting called goverter:output:raw where you can define raw code that will be added to the generation file.
Example:
// goverter:converter
// goverter:output:file ./output.gen.go
// goverter:output:raw func init() {
// goverter:output:raw     converter = &converterImpl{}
// goverter:output:raw }
type Converter interface {}

Please :+1: this issue if you like this functionality. If you have a specific use-case in mind, feel free to comment it.

Fixed with v1.6.0. See output:raw


Allows users to configure nodeAffinity in zookeeper chart

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/signed-cla

@lachie83 @kow3ns adding nodeAffinity because I want run zookeeper backed by Portworx volumes, and Portworx only runs on a subset of my nodes.

Closing in favor of #2907.


Add a Iff helper

I ran into some situation where I want to conditionally render a node if some variable is not nil and obviously I got a panic
// package viewmodels
type SomePage struct {
	s *string
}

// package views
func SomePage (vm viewmodels.SomePage) g,Node {
	return Div(
		If(vm.s == nil, Text("s is nil"),
		If(vm.s !- nil, Text("s is " + vm.s), // this will panic when `s` is nil
	)
}

In this situation, go will interpret the code of the second if regardless of the condition because the code itself is not in a condition.
This PR introduces a new Iff helper that accepts a callback. The callback content is only interpreted when it's called, making the code safe:
// package viewmodels
type SomePage struct {
	s *string
}

// package views
func SomePage (vm viewmodels.SomePage) g,Node {
	return Div(
		Iff(vm.s == nil, func () g.Node { return Text("s is nil") },
		Iff(vm.s !- nil, func () g.Node { return Text("s is " + vm.s) },
	)
}

I'm aware of the Lazy effort on the side, but I guess this is no a breaking change and can still exist in addition to the Lazy effort.

Hi @JulienTant , thank you for the PR! I've done something very similar in #99, and actually attempted to resolve this in #101 and #156 as well. I've never reached a solution I really like, essentially because I think it's confusing to have two different conditional functions from a user perspective.
I really would have liked the foresight to just implement If this way, because you're definitely not the first to hit this… I don't know what to call it, "curiosity". But maybe this very straightforward solution is just the simplest way.
Between your solution here and the Lazy approach, which would you prefer?

I think I like having two separate options because not all the Ifs need a callback, amd callback just ain't pretty in go. It's not like we can have
If(things == nil, () => P(g.Text("No things"))

Looking at the stdlib's slices for example, most functions also have a *Func equivalent so this is not shocking.
As an alternative, we could promote a new callback type and it works natively with If:
type NodeCallback func() g.Node

func (f NodeCallback) Render(w io.Writer) error {
    return f().Render(w)
}

func TestIfWithNodeFunc(t *testing.T) {
    t.Run("return the nil case without panicking", func(t *testing.T) {
        var nilable *string
        n := g.El("div",
            g.If(nilable != nil, NodeCallback(func() g.Node {
                return g.El("span", g.Text(*nilable))
            })),
            g.If(nilable == nil, NodeCallback(func() g.Node {
                return g.El("span", g.Text("No messages."))
            })),
        )
        assert.Equal(t, "
No messages.
", n)
    })

    t.Run("returns the non nil case", func(t *testing.T) {
        var notNil *string = new(string)
        *notNil = "You lost your hat!"
        n := g.El("div",
            g.If(notNil != nil, NodeCallback(func() g.Node {
                return g.El("span", g.Text(*notNil))
            })),
            g.If(notNil == nil, NodeCallback(func() g.Node {
                return g.El("span", g.Text("No messages."))
            })),
        )
        assert.Equal(t, "
You lost your hat!
", n)
    })
}

@JulienTant I've been thinking about this.
Your NodeCallback is essentially the Lazy type I've been implementing in #156, and although it's fine, it's a bit awkward to make it support both elements and attributes (like I did with Lazy).
What if we instead adopted a pattern of a function that is immediately evaluated? Something like this: https://go.dev/play/p/mlByJAc-Upp
package main

import (
	"os"

	g "github.com/maragudk/gomponents"
)

func main() {
	_ = g.If(true, func() g.Node {
		return g.El("div")
	}()).Render(os.Stdout)
}

I'm not sure how to make that work with the nil pointer panics without having another if statement in the function though…
Otherwise, I'm leaning towards adding your Iff. I think it's simple and elegant.

Sidenote: I like the conciseness of Iff (and the reference to math's if-and-only-if, right?), but the consistency and obviousness of IfFunc. Which would you prefer?

As you mentioned, having a self-executing function here would result in the same problem when trying to deal with nil's
var n *string
_ = g.If(n != nil, func() g.Node {
	return g.Text(n)  // will panic
}()).Render(os.Stdout)

I prefer Iff and its if and only if association, mostly because IfFunc makes me believe that the if gets the func:
func IfFunc(f func() bool, n g.Node) g.Node {
	if (f()) {
		return n
	}
	return nil
})

I think the big advantage of this solution is that it does not require any overhead for devs compared to the Lazy approach where you have to specify if it's an element or an attribute

@JulienTant I think I'm convinced about going with Iff. Thank you so much for discussing this with me, it's been a "gotcha" pretty much since the project started gaining traction. :D
I'll merge this and update some docs and readmes, and then release it sometime soon.


Error after add router

Hello,
First of all, thank you for your amazing work. I've just started to read the book and have enjoyed it so far.
I'm at chapter 2, section Adding a router. After adding to the router like this, in file routers.py:
router.register(r'user', UserViewSet, basename='user') urlpatterns = [ *router.urls, ]
Then I ran the server
python manage.py runserver
After that, made a GET request
http://<IP_ADDRESS>:8000/api/user/
then the following error occurred:

Using the URLconf defined in CoreRoot.urls, Django tried these URL patterns, in this order:
admin/
The current path, api/user/, didn’t match any of these.

So I tried to figure the cause, and modified the urls.py file like this (the book does not mention to modify this file)
urlpatterns = [ path("admin/", admin.site.urls),     path("api/", include(("core.routers"))), ]
And I tried to request again, another error happened:

TypeError at /api/user/
'str' object is not callable

I've wondered has someone else encountered this issue like I did?

@chinne thank you for the solution.
@thangduong3010  That is a missing part in the book actually. We will update it accordingly.


BYOC Basics Article

This PR adds a basic documentation article about BYOC. It should be the entry point for customers interested in BYOC, regardless of which provider and UI they use.
For https://github.com/giantswarm/giantswarm/issues/3987

PTAL

PTAL @JosephSalisbury

Thank you very much @JosephSalisbury ! 💐


Automatic room assignment does not work for arbitrary admission and discharge dates

Describe the Bug
Since the patient-to-room assignment algorithm uses days as the smallest time unit, it may assign two patients to the same room if the first patients' discharge time is after the second patients' admission time (but both times are on the same day).
Expected Behavior
The algorithm recognizes that the room is occupied until the discharge time of the first patient and therefore does not assign another patient with an admission time earlier than the discharge time of the first patient to the same room.
Additional Information
Solving this issue probably includes modifying the patient-to-room assignment algorithm available at TabeaBrandt/patient-to-room_assignment to use a more granular time unit like hours instead of days. Additionally, the last time unit (which may not completely be covered by the corresponding patients' stay) should be blocked for other patients such that no overlap (even for a few minutes) is possible.
After changing the algorithm to use hours instead of days, the code in this repository has to be adopted accordingly.

I just noticed that the algorithm seems to crash if any room in the ward has more than two beds.
Traceback (most recent call last):
  File "/bed-management/patient-to-room_assignment/call_from_django.py", line 34, in <module>
    call_from_django(f"instances/{file}", last_day)
  File "/bed-management/patient-to-room_assignment/call_from_django.py", line 24, in call_from_django
    result = assign_patients(patients, 0, last_day, rooms, current_assignment)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/patient-to-room_assignment/Dynamic.py", line 94, in assign_patients
    newResult = IP(
                ^^^
  File "/bed-management/patient-to-room_assignment/Ipr.py", line 296, in IP
    c(m, modelVars, useVarMrt, patients, rooms, firstDay, lastDay)
  File "/bed-management/patient-to-room_assignment/Iprt.py", line 10, in fix_smax
    assert all(
           ^^^^
AssertionError: upper bound on single rooms for private patients is only valid for rooms with at most two beds
Internal Server Error: /timeline/2/suggest/
Traceback (most recent call last):
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/utils/decorators.py", line 46, in _wrapper
    return bound_method(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/contrib/auth/decorators.py", line 23, in _wrapper_view
    return view_func(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/views/generic/base.py", line 143, in dispatch
    return handler(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/views/generic/base.py", line 226, in get
    context = self.get_context_data(**kwargs)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/ycms/cms/views/timeline/timeline_view.py", line 46, in get_context_data
    call_command("call_solver_api", pk, stdout=out)
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/core/management/__init__.py", line 194, in call_command
    return command.execute(*args, **defaults)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/.venv/lib/python3.12/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/bed-management/ycms/ycms/core/management/commands/call_solver_api.py", line 108, in handle
    with open(settings.PRA_OUTPUT_PATH, "r", encoding="utf-8") as file:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/bed-management/patient-to-room_assignment/Results/instances/generated_out.json'
[02/Dec/2024 21:50:18] "GET /timeline/2/suggest/ HTTP/1.1" 500 108087


xterm functionality of terminal-light doesn't work in urxvt after version 9.25

I use a light terminal and noticed broot applies its dark theme instead of the light theme (I use urxvt 9.30 writing black on white).
going down the rabbit hole, cargo run from the terminal-light crate prints Error: Unsupported for me. I think I traced it down by now to the release notes http://lists.schmorp.de/pipermail/rxvt-unicode/2021q2/002606.html which say

ESC G (query rxvt graphics mode) has been disabled due to security
implications. The rxvt graphics mode was removed in rxvt-unicode 1.5,
and no programs relying on being able to query the mode are known.

i reverted to urxvt 9.22 (ubuntu 20.04 and debian stable) and there terminal-light works (afaiu thanks to the query_bg_color function in xterm.rs)
On top of that, the COLORFGBG detection fails for me because of its value COLORFGBG=0;default;15 the default can't be parsed to u8. (Not sure yet if that's something I should change anyway and where that gets set…)

On top of that, the COLORFGBG detection fails for me because of its value COLORFGBG=0;default;15 the default can't be parsed to u8. (Not sure yet if that's something I should change anyway and where that gets set…)

What is supposed to be that "default" ? A problem is I never found any authoritative definition of that variable. If you'd find some it would be helpful.

Found this code which parses de ;default part. That doesn't really make it a standard...

Hi, I also haven't figured out what default is meant to be / where I set it (not to mention why i chose to set it that way).
Your PR works for me. terminal-light does not report an error anymore and broot picks the correct theme now.

FYI broot 1.20 has just been released with terminal-light updated


Cannot subclass Client

I will send a pull request, but just like events.EventEmitter exports its constructor function, so should Client.  It allows for subclassing.  I'd like to be able to do:
util.inherits(MyClient, solr.Client);

Closed by #15


Use .lhs for temp files when necessary to match the current buffer

This addresses #311, in which .hs was wrongly used unconditionally.

Good call with the conditional. Thanks @purcell!

Happy to help. If you want to add me as a collaborator for the ease of making occasional little fixes like this to the elisp side of things, that might work.

@purcell Done!

Cool, thanks.


Add the Kakoune editor

Modal editor with first class support for multiple-selections and inverted subject-verb grammar.
http://kakoune.org/

Thanks!
But I think keeping the links closer to *Vim made more sense, since this is a modal editor.


Wrong SC size calculation

This is wrong
https://github.com/positivemuon/musConv/blob/52d4ab2af172970ee3b25ac6e613aed414be416e/musConv/supcgen.py#L53
the volume (the determinant) should be used.

See also
https://github.com/positivemuon/musConv/blob/52d4ab2af172970ee3b25ac6e613aed414be416e/musConv/supcgen.py#L53

Generally may not really correct, in this context it is correct, the length of the lattice vector is an input in this situation.
We can check with a situation where it fails.?

It is only correct if alpha, beta and gamma are always exactly 90 deg. I don't think this is generally the case.
It's easy to make an example.

I check in a number of cases where alpha, beta and gamma are not 90 deg and  it is completely fine, the length of the lattice vector was used as an input, moreover the size of the supercell as it is seems sufficient for what it is needed for.
To do it using the volume (the determinant) and accesing the transformation matrix will require more lines of code and perhaps a function of its own, but  the need of the code is  fine with a line.
I have been trying to see where it fails but not yet.  Perhaps finding one will help to understand why it does fail.

I don't see how this can work when the transformation matrix is not diagonal. By definition basis vectors are "mixed". I think it's likely to happen when you have, for example, hexagonal lattices.

I think it works because the function with its inputs settings (not user defined) return a supercell with same alpha,beta and gamma as the input structure, and thus the magnitude of the lattice vectors of the new supercell are integer multiples of the input structure.   I think like this it flows with other alogrithm of the classes. If it doesn't work like this some of other parts have to be altered too.
It works with basically all the cifs I have checked , hexagonal, orthohombic, monoclinic, etc.
So it is important to find a case where it doesn't work, so we can figure out why it doesn't work.

return a supercell with same alpha,beta and gamma as the input structure

Yes, if this is by definition is fine, but should be mentioned in the comments of the code line mentioned above.
Anyway, the algorithm isn't that smart if it does not convert an hexagonal cell into its orthorombic equivalent one.

Here's an example:
Si, FCC lattice vectors:
           a(1) = (  -5.137000   0.000000   5.137000 )
           a(2) = (   0.000000   5.137000   5.137000 )
           a(3) = (  -5.137000   5.137000   0.000000 )

Si, Simple Cubic (conventional) lattice vectors:
           a(1) = (   10.274000   0.000000   0.000000 )
           a(2) = (   0.000000   10.274000   0.000000 )
           a(3) = (   0.000000   0.000000   10.274000 )

I get, you can represent Si with FCC with 1 basis,  or SC with 4 basis.
But not sure I understand  the example in relation to the class. Does the code actually do this?
Like when an input of Si of FCC lattice vector is given as an input in the code,  it returns a supercell  with a simple cubic lattice vector?  If this is the case then  there is  a fundamental problem with the pymatgen nearcubic supercell generator and we should report the bug.
I tried  and this is what I get.
primitive cell
input
-2.690500 -2.690500 0.000000
-2.690500 0.000000 -2.690500
0.000000 -2.690500 -2.690500
output
-5.381000 -5.381000 0.000000
-5.381000 0.000000 -5.381000
0.000000 -5.381000 -5.381000
#----------------------------------
Conventional unitcell
input
5.381000 0.000000 0.000000
0.000000 5.381000 0.000000
0.000000 0.000000 5.381000
output
10.762000 0.000000 0.000000
0.000000 10.762000 0.000000
0.000000 0.000000 10.762000

Ok, so pymatgen code is kind of crap.

I tried with MnO, pymatgen works great, it finds the cubic cell and indeed
> np.divide(res.lattice.abc,AseAtomsAdaptor.get_structure(atoms).lattice.abc)
array([1.6508869, 1.6508869, 1.6508869])


Cannot build when anything is added to vesktop.settings

Trying to configure settings.json like this:
programs.nixcord.vesktop.settings = {
  hardwareAcceleration = true;
  # or anything else
};

Results in:
error:
       … while calling the 'head' builtin

         at /nix/store/fpivx4sjcp2vk4rp9nhliln5cwcp3kc6-source/lib/attrsets.nix:1575:11:

         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'

         at /nix/store/fpivx4sjcp2vk4rp9nhliln5cwcp3kc6-source/lib/modules.nix:821:9:

          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: cannot convert a function to JSON

       at /nix/store/bx5hkjqmjjy416lw2z51192hs7nk48pz-source/lib.nix:120:18:

          119|
          120|   mkVencordCfg = cfg:
             |                  ^
          121|   let

actually this looks like the same issue as https://github.com/KaylorBen/nixcord/issues/18

Ye I'll close this so discussion is moved to #18


Bump to C++17

Description
Bumps the C++ version to 17. Those that are effected by this should test compilation on their specific platforms.
Fixes #454
General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[ ] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

Further investigations revealed: the spdlog with std::string_view. For C++17, vulkan.hpp provides a cast-operator from vk::ArrayWrapper1D to std::string_view.
Maybe updating that spdlog (which seems to be pretty old) might help as well, and be the better approach.

Hey @asuessenbach, those changes worked. I havent tested locally after the rebase so the CI may still fail. Ill revisit this in an hour


In processAllUnacks, change it so only the unacks from the past get reset

This is a solution for Issue #1859. Tasks that were popped had their popped status set to false before they were acked so a future poll could get the same task. This PR only resets the popped flag for tasks that were popped in the past by a minute, not in the future by a minute.

Let me vote "Merge" on this one...
Its being used in our test env for the past 3 days without issues.

Please fix the build failure :
com.netflix.conductor.dao.mysql.MySQLQueueDAOTest > processUnacksTest FAILED
    java.lang.AssertionError at MySQLQueueDAOTest.java:304

@apanicker-nflx I fixed the build error but I did it by converting the test case so that it would work with the new code. I am not completely sure whether the old test case was constructed to conform to the old code or if it was a legitimate test case that I should have left alone. I would like someone else to review it if possible.

@mactaggart @mashurex Could you please help with reviewing this pull request? Thanks


Some plugins not installing in plugin list

vim-plug seems to be ignoring some plugins on my plugin list when I try to install them. Specifically the plugins are UltiSnips and vim-snippets.
The screenshot below shows the output when I try to :PlugInstall. You can see that ultisnipps and vim-snippets did not get installed, however they are in the plugin list to be installed. I tried to keep the plugins in the list and manually install them, but when I ran :PlugClean they came up as directories to be deleted.

Thanks for the help.

VIM - Vi IMproved 8.1 (2018 May 18, compiled Oct 29 2018 06:55:58)
macOS version
Included patches: 1-500
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl               +extra_search      +mouse_netterm     +tag_old_static
+arabic            +farsi             +mouse_sgr         -tag_any_white
+autocmd           +file_in_path      -mouse_sysmouse    -tcl
+autochdir         +find_in_path      +mouse_urxvt       +termguicolors
-autoservername    +float             +mouse_xterm       +terminal
-balloon_eval      +folding           +multi_byte        +terminfo
+balloon_eval_term -footer            +multi_lang        +termresponse
-browse            +fork()            -mzscheme          +textobjects
++builtin_terms    -gettext           +netbeans_intg     +timers
+byte_offset       -hangul_input      +num64             +title
+channel           +iconv             +packages          -toolbar
+cindent           +insert_expand     +path_extra        +user_commands
-clientserver      +job               +perl              +vartabs
+clipboard         +jumplist          +persistent_undo   +vertsplit
+cmdline_compl     +keymap            +postscript        +virtualedit
+cmdline_hist      +lambda            +printer           +visual
+cmdline_info      +langmap           +profile           +visualextra
+comments          +libcall           -python            +viminfo
+conceal           +linebreak         +python3           +vreplace
+cryptv            +lispindent        +quickfix          +wildignore
+cscope            +listcmds          +reltime           +wildmenu
+cursorbind        +localmap          +rightleft         +windows
+cursorshape       -lua               +ruby              +writebackup
+dialog_con        +menu              +scrollbind        -X11
+diff              +mksession         +signs             -xfontset
+digraphs          +modify_fname      +smartindent       -xim
-dnd               +mouse             +startuptime       -xpm
-ebcdic            -mouseshape        +statusline        -xsmp
+emacs_tags        +mouse_dec         -sun_workshop      -xterm_clipboard
+eval              -mouse_gpm         +syntax            -xterm_save
+ex_extra          -mouse_jsbterm     +tag_binary
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework AppKit   -mmacosx-version-min=10.14 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.28.0/lib/perl5/5.28.0/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc  -L/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/config-3.7m-darwin -lpython3.7m -framework CoreFoundation  -lruby.2.5.3 -lobjc

Type:

[x] Bug
[ ] Enhancement
[ ] Feature Request
[ ] Question

OS:

[ ] All/Other
[ ] Linux
[x] OS X
[ ] Windows

Vim:

[x] Terminal Vim
[ ] GVim
[ ] Neovim

Have you tried restarting Vim so that vimrc is reloaded?

Yeah, I did several times. Weirdly enough I tried again today and they both installed. Still baffled why it just didn't seem to work when I tried yesterday! Anyway, thanks for you help.


Add Support For More Request/Response Headers

Adding support for language, timezone, role, transaction-id headers.
Adding support for set-role, started-transaction-id and clear-transaction-id response headers.
Removed warning.

Please also reference the issue that this PR is addressing, with fixes #XXX if it addresses it completely.  If partially, just note that without the fixes keyword.

This looks great. One tiny comment on formatting -- if you could run cargo fmt and if it changes, resubmit by doing a git push -f.
Once that's done (or you tell me that it didn't result in a change), I'll merge this. I'm going to merge it manually, because I like the cleaner commit history from rebasing.

Thanks for the review! I've updated the formatting. Please merge it when you get a chance.

Thanks!


installing the image on raspberry pi 3 b+

I am trying to install the docker image on my rpi 3b+ running raspbian stretch but it is giving this error in the logs:
standard_init_linux.go:207: exec user process caused "exec format error"
Can you let me know what needs to be modified for it to run.

That's because there are a lot of x86 binaries in there(not meant to be run on ARM). I tried too...

If I had access a rpi (I dont anymore) I'd be more than happy to start building an arm variant.

In theory you could do it on an Odroid, from one of the odroids provided for Hardkernel for testing:
https://forum.odroid.com/viewtopic.php?f=29&t=32257

Docker can easily cross-compile images, see this blog post or these commands:
docker run --privileged --rm docker/binfmt:a7996909642ee92942dcd6cff44b9b95f08dad64
export DOCKER_CLI_EXPERIMENTAL=enabled
docker buildx build --platform linux/arm/v7 -t image-tag .

Indeed, I cross built my version:
https://github.com/crazyquark/freepbx-docker (fork of this repo)
I diverged a bit from the original.


Fix turbo issues : Declaring an environment variable in "dependsOn" is deprecated

Our CI/CD system is throwing these errors:
2022/12/07 16:10:43 [DEPRECATED] Declaring an environment variable in "dependsOn" is deprecated, found $COMMERCE_PROVIDER. Use the "env" key or use `npx @turbo/codemod migrate-env-var-dependencies`.
2022/12/07 16:10:43 [DEPRECATED] Declaring an environment variable in "dependsOn" is deprecated, found $BIGCOMMERCE_STOREFRONT_API_URL. Use the "env" key or use `npx @turbo/codemod migrate-env-var-dependencies`.
2022/12/07 16:10:43 [DEPRECATED] Declaring an environment variable in "dependsOn" is deprecated, found $NEXT_PUBLIC_SHOPIFY_STORE_DOMAIN. Use the "env" key or use `npx @turbo/codemod migrate-env-var-dependencies`.
2022/12/07 16:10:43 [DEPRECATED] Declaring an environment variable in "dependsOn" is deprecated, found $NEXT_PUBLIC_SWELL_STORE_ID. Use the "env" key or use `npx @turbo/codemod migrate-env-var-dependencies`.

Looking at the Turbo Documentation it shows this warning:

ℹ Using $ to declare environment variables in the dependsOn config is deprecated. Use the env key instead.

This PR is attempting to address this change in turbo by updating turbo.json in this repo.

Nuts! Folks at Vercel couldn't debug issues for their product (sad day in America). Anyway, if anyone else if having this issue, just run npx @turbo/codemod migrate-env-var-dependencies --force


Problem Inserting and retrieving ID in Postgres

There is a problem with the primary key ID when inserting into a Postgresql table with Fluent.
The sequence does not increment and the ID remains at zero, but if the query is done manually and "RETURNING ID" is added, it does so without problems.
Has anyone found a solution to this problem?

That is a bit tricky, RepoDB understand the identity generation if it is GENERATED ALWAYS AS IDENTITY as seen here.
The insert operation make a 2nd call to get the new generated ID if the default generated SQL statement for Fluent operation does not return a value, see here.
I would suggest if you can override the IDbHelper.GetScopeIdentity() method by creating your own `IDbHelper

I only used CP and accidentally closed the ticket. Here, I reopened it for you.


Installing Dart (1.24.3) on Mac is not possible - homebrew has still 1.24.2

IntelliJ shows already that 1.24.3 is available...
brew info dart
dart-lang/dart/dart: stable 1.24.2, devel 2.0.0-dev.12.0
The Dart SDK
https://www.dartlang.org/
/usr/local/Cellar/dart/1.23.0 (2,373 files, 588.8MB)
  Built from source on 2017-04-21 at 18:53:53 with: --with-content-shell --with-dartium
/usr/local/Cellar/dart/1.24.0 (3,039 files, 656.4MB)
  Built from source on 2017-06-13 at 08:18:13 with: --with-content-shell --with-dartium
/usr/local/Cellar/dart/1.24.1 (3,041 files, 656.5MB)
  Built from source on 2017-06-16 at 08:10:07 with: --with-content-shell --with-dartium
/usr/local/Cellar/dart/1.24.2 (3,041 files, 656.4MB) *
  Built from source on 2017-06-23 at 14:26:49 with: --with-content-shell --with-dartium
From: https://github.com/dart-lang/homebrew-dart/blob/master/dart.rb
==> Options
--with-content-shell
	Download and install content_shell -- headless Dartium for testing
--with-dartium
	Download and install Dartium -- Chromium with Dart
--devel
	Install development version 2.0.0-dev.12.0
==> Caveats
Please note the path to the Dart SDK:
  /usr/local/opt/dart/libexec

--with-dartium:
  To use with IntelliJ, set the Dartium execute home to:
    /usr/local/opt/dart/Chromium.app

OS ---------------------------------------------------------------------------
ProductName:	Mac OS X
ProductVersion:	10.11.6
BuildVersion:	15G18013
Darwin Kernel Version 15.6.0: Mon Nov 13 21:58:35 PST 2017; root:xnu-3248.72.11~1/RELEASE_X86_64
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
Copyright (C) 2007 Free Software Foundation, Inc.
Software installed -----------------------------------------------------------
java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)
Dart VM version: 1.24.2 (Thu Jun 22 08:42:17 2017) on "macos_x64"
Pub 1.24.2
NPM: 5.6.0

This should probably be brought up at: https://github.com/dart-lang/homebrew-dart


[PE-D][Tester A] List panel is removed on the UI when list is empty

The list panel seems to be removed and replaced with a black area when the list is empty.
Non-empty list:

Empty list:

Labels: severity.VeryLow type.FunctionalityBug
original: LeongWZ/ped#12

This is considered as a feature so we can't change it. Hence, we need a 'Known Bug' section and write this in

Added this in known enhancement for now,
Will decide later whether to cover it in known issues or not in UG


Icon Request: Add new Tag

I'm submitting a...

[ ] Bug report
[ x] Feature request
[ ] Documentation issue or request

Current behavior
 None
Expected behavior
Add a tag with plus icon which tells user that they can add new tags.
https://thenounproject.com/icon/add-tag-147065/

Agreed, will be integrated with next release.

https://agileworld.siemens.cloud/jira/browse/IX-90

Will be done with #20

@issue can be closed, I cannot do this.


Incorrect answer for isEqual when decimals are attached to variables

Incorrect answer for isEqual when decimals are attached to variables.
Steps to Reproduce
let expr1 = engine.parse("2(13.1x+1)");
let expr2 = engine.parse("26.2x+2");
console.log("expr1 is equal to expr2: ", expr1.isEqual(expr2));
Actual Behavior
The result is "expr1 is equal to expr2: false"
Expected Behavior
"expr1 is equal to expr2: true"

Works now.


feat: Add reload button in openWebView

/claim #73

Hey @riderx
Thank you for your feedback! I apologize for the misunderstanding regarding the initial task,
I'm glad you like the feature Please review the changes.

Hello @riderx, it seems like the issue has been closed. What about the feature I added that is callable from JS?

Can you fix your conflict, I will tips you then

Hi @riderx, I have resolved some conflicts.
Please take a look at it and let me know if there are any further requirements.
Thank you.

Hi @riderx, Just checking in with you since it has been a while. Please revert back to this whenever you find it suitable, I will be looking forward to your reply.

i'm not sure to understand what revert you talk about ^^
i saw you added in pakcage json a peer dep of the package itself, I think that a mistake, can you update it ?

hii @riderx I have made some changes

@ayusham001 thanks it only miss the typescript definition now :)

@riderx Check it out :)

Can you run build command, fmt, and verify ?

@riderx I have done changes which I found to be done.

Hi @riderx, Hopefully, you have looked into my recent changes to the PR. Please provide me with the necessary feedback.

/tip 50

Thanks a lot !

Thank you @riderx for your support and consideration.

Hey @ayusham001 seems you got the tip plus the reward as well.
I know it could look nice for you.
But this was not supposed to happen.
I'm happy about your work, and I was comfortable to tip you, but right now it feels a bit unfair to the original one PR.
So I have ask Algora team to take a look on this

Hello @riderx,  yes I noticed the update right now. Of course, it was a little sad to see the reward get refunded since I worked hard for the PR, but I also understand your point. Besides, I trust your judgment of the same.
I am grateful for the tip and my PR getting merged.
Thank you.


COD-36 support for high resolution graphics

COD-64 add graphicsConstraints in ait and xml ait

parse graphicsConstraints in ait and xml ait
update app
update scenario file

COD-65 update graphics info in application manager and browserView

send graphics info to the callback of application manager
graphics info is only active when OrbHbbTVVersion >= 204
scale the browserView based on the highest supported resolution

Testing:

manual checking with mit-xpert
https://github.com/OceanBlueSoftware/mitxp-testsuite/pull/3
when OrbHbbTVVersion >= 204, scaling browserView based on the supported resolution;
in other cases, scaling to default app size (1280x720)

I had to apply those fixes to get the HbbTV 2.0.4 org.hbbtv_GRAPHICS00X0 to pass.

Let's go with this. We need the feature.


EVP SKEY implementation

Checklist

[x] documentation is added or updated
[x] tests are added or updated

Thanks a lot for this PR! Maybe you know that the s390 platform provides acceleration for crypto operatation for clear-keys (which is already available via the default provider) and encrypted-keys (called proteced keys in the s390-documentation). There is already a library supporting these encrypted-keys [1], but having this support also in OpenSSL would be much better (from a customer point of view).
The s390 protected keys are hardware-backed keys. Each instance (logical partition or a guest) provides the possibility to wrap keys with the instance-specific master key. The result is a so-called protected key. Wrapping is supported for clear-keys and - more interesting - for secure keys of an HSM. Unwrapping of protected keys is not supported. The s390 CPU has crypto instructions which operates on these protected keys without any IO between the CPU and the HSM. Other architectures, like the imx-Family of NXP/freescale, have similar capabilities, so I'm sure, their concepts are also mappable to your EVP_SKEY approach.
We appreciate your proposal and I'll try to map it to our needs. Again, thank you so much!
[1] https://github.com/opencryptoki/libzpc

A question to @openssl/committers
The natural pattern is using he EVP_KEYMGMT for the EVP_SKEY. Currently I use it only for freeing the structure but it definitely would bee increased.
I see 2 options there:

fetching based on propquery when fetching the EVP_CIPHER (or some other struct that can rely on an opaque key)
fetching based on an artifical "provider=prov_name" propquery: I strongly doubt the EVP_SKEYs will be passable between providers

Taking out of draft (code style and make update to be resolved)
What I really want to understand is how do I reduce the testing boilerplate and what is a proper way to refactor the  evp_cipher_init_skey_internal function and combine it with  evp_cipher_init_internal- they are quite different because of lack of engine references inevp_cipher_init_skey_internal`

I think this is ready for review.
The check-style failure is irrelevant - I reused a part of already existing function and now it complains that the function I've changed is too long. I can try to refactor it a bit and cut some small pieces, but it's out of scope of this PR.
The EVP_SKEY_dup function can be added if necessary.
@holger-dengler If you could try whether this approach fits your limitations and give feedback, it would be great.

The EVP_SKEY_dup function is added.

My original expectation was that an application using
int EVP_CipherInit_skey(EVP_CIPHER_CTX *ctx, const EVP_CIPHER *cipher,
                        const EVP_SKEY *skey, const unsigned char *iv,
                        int enc, const OSSL_PARAM params[]);

int EVP_MAC_init_skey(EVP_MAC_CTX *ctx, const EVP_SKEY *skey,
                      const OSSL_PARAM params[]);

(and others)
can keep working with older providers that do not know anything about EVP_SKEY.
This should be doable for example providing a fallback on libcrypto side, that caches the bunch of bytes and calls the pre-skey APIs.

OTC discussed this proposal.
We would like to see a way to make the APIs with old providers that do not support the new API calls.
An EVP_SKEY object should have the option of holding a "bunch of bytes" in the libcrypto side structure. In this way applications can use the new EVP_SKEY APIs and yet still work with old providers that have not been modified explicitly to work with them.

I would assume that the default provider will have its own internal skey keydata structure (and you MUST have a structure, because you need both a pointer to a bunch of bytes and a length), then the default provider routines can be used to export the key to a bunch of bytes before calling an older provider with the older APIs.

For example if an application creates an EVP_SKEY by passing a bunch of bytes, those bytes will be cached in the EVP_SKEY structure. In a later call to EVP_CipherInit_skey(), passing the EVP_SKEY and an EVP_CIPHER implementation from a provider that does not explicit support EVP_SKEY, the libcrypto implementation will use the old cipher_init() function on the provider passing the bunch of bytes.

It is unclear how you would support encoding which provider should be used, in any case the keymgmt pointer should be that of the default provider to indicate that the key is in the default provider structure type.

I am copying my comment from inside the review comment discussion so it is not lost:
In a first iteration I'd like to see a bunch of bytes import and export functions - of course they might be optional and not implemented either if the given provider does not support exporting raw secret keys. So the "bunch of bytes" representation will be optional as well.
The lifecycle of an SKEY would be:

generation by a KDF or KEX or KEM or initialization from an application-provided bunch of bytes or by getting a reference as a result of a lookup by OSSL_STORE.
usage of the key in various new APIs which would allow passing an SKEY - this might trigger an import or export + import of the bunch of bytes data, which might of course fail for keys that are not exportable or if the provider selected for the operation does not allow importing keys - it would be useful to keep the references in a cache to avoid doing the import again for another operation with the SKEY in the same provider
release of the SKEY - with key being deleted from the provider if that key was not a permanent key (or was just imported there for an operation)

I realize it might be needed to have a type associated with the SKEY but that could be just an additional OSSL_PARAM.

@t8m I will implement the raw bytes stuff but I'm pretty sure I don't like the concept of having multiple representations for multiple providers in the same EVP_SKEY object. It causes extra complexity and extra efforts to keep these representations in sync.

@t8m I will implement the raw bytes stuff but I'm pretty sure I don't like the concept of having multiple representations for multiple providers in the same EVP_SKEY object. It causes extra complexity and extra efforts to keep these representations in sync.

Given the SKEY should be immutable apart from these caches, I do not think it should be a problem. All this is already implemented for PKEYs.

@t8m @levitte @simo5 - could you please check the current implementation? I will write some more tests for it later this week

@kroeckx I can - but what is the rationale beyond your request? It's up to the EVP_KEYMGMT to provide the dup callback

See above? From the top of my head:

There is no actual use case. The only case where a dup function makes sense is if you want to mutate it, which we don't.
The up_ref is what you want to use
It's unclear what a provider should actually do with it. Should it just call up_ref internally?

I only see problems with it.

@kroeckx I'd better wait for @holger-dengler feedback to check whether they really need it. Yes, I strongly prefer up_ref but _dup may make sense in case of multi-thread application.
The provider may choose not to implement the dup callback and this case the operation would just fail.
If nobody else insist, I will keep the _dup API for now and will reconsider dropping it before the merge.

Having the dup function fail because it's optional is something I really consider problematic.

@kroeckx I'd better wait for @holger-dengler feedback to check whether they really need it. Yes, I strongly prefer up_ref but _dup may make sense in case of multi-thread application.

@beldmit after the discussion with Kurt, I agree with him, that all our use cases should be covered by up_ref(). I'm ok with both options, leave dup() as is or removing dup() as long as we do not have a real use case.

The EVP_SKEY_dup API removed, saved here for the record
EVP_SKEY_dup.txt

Any feedback please?

Added the missing provider-level documentation of the new callbacks.

Ping @openssl/committers for the review

OTC: We discussed the empty key creation pattern and we will discuss again this next week when everybody had opportunity to review the comments here.

All tests are passed, feel free to review

Done a read through...  and am noticing that keybytes and keybyteslen are less used than I had expected.  Not sure what to make of that.  I'll have another read tomorrow to see if I understand better then.

Well, currently they are used only as a way to work with the SKEYs with the existing ciphers/MACs

@levitte may I ask you to make the next read?

OTC: We agree that avoiding initial empty state in the API is desirable. The keys should be directly created when they are imported, generated, etc.

OTC: We agree that avoiding initial empty state in the API is desirable. The keys should be directly created when they are imported, generated, etc.

At what level?  Application facing API or provider API?  They are not the same...

Application API

Application API

That is not what we said in the OTC meeting. We actually said both.

But the provider API is reusing the current EVP_KEYMGMT API which has these 2 calls separate

But the provider API is reusing the current EVP_KEYMGMT API which has these 2 calls separate

IMO we should NOT reuse EVP_KEYMGMT API for SKEYs. For example there is no need for set_params().

But the provider API is reusing the current EVP_KEYMGMT API which has these 2 calls separate

IMO we should NOT reuse EVP_KEYMGMT API for SKEYs. For example there is no need for set_params().

How do you manipulate keys w/o some form of key mgmt? Or are you proposing to add a new EVP_SKEY_MGMT ?

IMO we should NOT reuse EVP_KEYMGMT API for SKEYs. For example there is no need for set_params().

How do you manipulate keys w/o some form of key mgmt? Or are you proposing to add a new EVP_SKEY_MGMT ?

Yes, there would be a separate skey management API.
An alternative could be to add new functions to the existing keymgmt API that would support creating keys without the empty state and not use and implement the blank key new function. However I am not sure this won't be too confusing.

@t8m sorry I don't get the reasons. I understand why the EVP_SKEY has to be a separate struct comparing to EVP_PKEY - but cloning also EVP_KEYMGMT seems weird.

@t8m it works with raw opaque pointers that can be stored both in EVP_PKEY and EVP_SKEY

I know it works. That does not necessarily mean it is good idea to reuse it.

An alternative could be to add new functions to the existing keymgmt API that would support creating keys without the empty state and not use and implement the blank key new function. However I am not sure this won't be too confusing.

It sounds like your motivation here is to fix a design flaw in the existing keymgmt, and not impose that design flaw on skeys too. The cost of doing so is duplicating what is essentially the same API.

Mixing interfaces for fairly unrelated types of data just because the function API signature is the same for many of the functions is IMO a very bad idea. Also the match of the interfaces is not so precise as it could seem at first sight. For example the selection argument does not make much (any) sense for SKEYs.
So no, I do not think the API is or should be the same.

@t8m let me disagree.
For selection we have parameters (metadata of the key) and secret key itself (raw bytes representation). On the other hand I didn't reuse private key selection flag for this purpose but it seems the only distinction

For selection we have parameters (metadata of the key) and secret key itself (raw bytes representation). On the other hand I didn't reuse private key selection flag for this purpose but it seems the only distinction

To me this sounds like an artificial separation of things that should always go together. So no, I disagree.

OK. Looks like @simo5 also shares your opinion so I will work in this direction
@t8m one more question is about the STORE API - should it also be extended for EVP_SKEY?

OK. Looks like @simo5 also shares your opinion so I will work in this direction
@t8m one more question is about the STORE API - should it also be extended for EVP_SKEY?

As soon as you would like to support loading SKEYs from an URI then we will need it. Not sure it must be present in this first iteration.

Be nice to have for testing, but not a strict requirement, no


Cannot open audio results with keyboard navigation on all results grid

Description

It is not possible to open the audio results with keyboard on all results grid.
Reproduction

 Go to https://search.openverse.engineering/search?q=birds

 Tab to the first audio result

 Hit enter

Expected Results
The link should open the audio results
Actual result
The audio plays
Resolution

[x] 🙋 I would be interested in resolving this bug.

Oh no! This was working previously—thanks for noticing it.


Hi @gkunz I thought I was on a branch.


[SAC-40] kafka topic fail to get

Update KafkaHarvester get output topic method
Before this patch:

After this patch:

@weiqingy @dongjoon-hyun  please review this.

@merlintang . Could you be more specific on the title? The current one can get src topic.

Yes, I think weiqing is testing on the provided cluster.
On Tue, May 1, 2018 at 10:11 AM, Dongjoon Hyun<EMAIL_ADDRESS>wrote:

@dongjoon-hyun commented on this pull request.
In spark-atlas-connector/src/main/scala/org/apache/spark/
sql/kafka010/atlas/KafkaHarvester.scala
https://github.com/hortonworks-spark/spark-atlas-connector/pull/41#discussion_r185275440
:

@@ -50,11 +50,16 @@ object KafkaHarvester extends AtlasEntityUtils with Logging {
// destination topic
var destTopic = None: Option[String]
try {

 destTopic = node.getClass.getMethod("topic").invoke(node).asInstanceOf[Option[String]]

 val topicField = node.getClass.getDeclaredField("topic")

 topicField.setAccessible(true)

@merlintang https://github.com/merlintang , did you share the cluster
to @weiqingy https://github.com/weiqingy ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hortonworks-spark/spark-atlas-connector/pull/41#discussion_r185275440,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXY-Q6d5Yf-kuZbTiT9U4aOLOVsyKgAks5tuJdAgaJpZM4TkmuV
.


Correct refreshing logic of pre-signed urls for delta sharing streaming

Correct refreshing logic of pre-signed urls for delta sharing streaming:

refresh immediately if it already expired.
set the correct expiration time for a CachedTable

Tested with a integration test from a notebook.

Tested again with the flag, will merge once all pre-merge tests are done.


Code for normalizing variables

Hi,
I am trying to reproduce refine task on my data. I see that dataset for refine has abstracted the types and variables eg
private void METHOD_1 ( java.lang.Class VAR_1 )...

Is the code to do this provided in utils.py? If not, how to go about this?

Looks like the tool used is src2abs

Hi, sorry for the slow reply.  For this dataset, we directly employ the version from the CodeBERT repo here.


Enhance: Ui of the Contact Us section

I would like to change the existing ui of the contact us section to make it more attractive.

So, please assign this issue to me under GSSOC' 23.

Yes sure @Pragati-3003 , Open a PR with required screenshots. We wil review and would be happy to merge it!
Thanks for your interest in contributing to our repo:)

Yes sure @Pragati-3003 , Open a PR with required screenshots. We wil review and would be happy to merge it! Thanks for your interest in contributing to our repo:)

Thanku for assigning this to me :)

Please add level no.  to this issue.
Thanking you.


Replace crioctl with crictl

- What I did
replace crioctl with crictl in e2e
- How I did it
vim
- How to verify it
make verify
make integration
- Description for the changelog

replace crioctl with crictl in e2e

/ok-to-test

This LGTM, but I am no expert in crictl.
@mrunalp @runcom PTAL
/test all

LGTM, better if the test pass, fingers crossed.  Thanks @weiwei04!

/retest

/test all

Both the integration_fedora & integration_rhel are failed at ctr.bats, line 812 to check OOMKilled
I'll look into it, no need to retest.

/test all

Fixed OOMKill test, address @TomSweeneyRedHat's comments to remove commented checks, PTAL :)

LGTM, thanks again @weiwei04.  Tests are all green!

LGTM
I will let @runcom or @mrunalp decide to merge?

Let's get this in, this isn't breaking anything and we always follow up if we missed something :)
LGTM


Added option to provide specific redis username when initialising the adapter

We need to provide the redis username when instantiating the adapter.
I added a new constructor which takes the username as an additional parameter, no change to the existing behaviour

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MPCM catalog fails to load

Open SMK Editor and click through the different type of layers.  When "Manage DataBC Layers" is selected there is a failure.
Possibly related to infrastructure changes relating to apps.gov.bc.ca which is the host for MPCM.
2021-04-21T18:03:46.041Z GET /config
Reading config from C:\apps\smk-fap-fcb\smk-config.json
2021-04-21T18:03:57.561Z GET /catalog/local
Reading catalog from C:\apps\smk-fap-fcb\layers-smk-catalog.json
Success!
2021-04-21T18:04:05.325Z GET /catalog/wms/https%3A%2F%2Fopenmaps.gov.bc.ca%2Fgeo%2Fpub%2Fwms
Loading WMS Catalog from https://openmaps.gov.bc.ca/geo/pub/wms?version=1.3.0&service=wms&request=GetCapabilities
Success!
**2021-04-21T18:04:14.523Z GET /catalog/mpcm
Loading MPCM Catalog from https://apps.gov.bc.ca/pub/mpcm/services/catalog/PROD
undefined:1
SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at IncomingMessage. (C:\Users\ndegreef\AppData\Roaming\npm\node_modules\smk-cli\smk-edit\controllers\catalogs.js:78:29)
at IncomingMessage.emit (events.js:194:15)
at endReadableNT (_stream_readable.js:1103:12)
at process._tickCallback (internal/process/next_tick.js:63:19)**

https://github.com/bcgov/smk-cli/pull/62

The problem was trying to make a HTTPS request on port 80 uses the http module. Solution was to use the https module which defaults to port 443.

New package has been published to npm - v1.0.1

npm install --global @bcgov/smk-cli
v1.0.1 installed
test site created and used SMK Editor to access MPCM layers and add them


prevent crypto markets in sportsbook

fixes bug for now, prob want a better solution long term

closing this we have a better approach

closing this needs more work


Painkiller Black Edition (the original, not the HD remaster) doesn't size it's game window properly

This is fixable with PROTON_USE_WINED3D=1 %command% but the problem is that it uses direct3d to opengl, it doesn't use dxvk anymore this way, so all the dxvk.conf options are inaccessible. OpenGL is "fine" but can have severe frame pacing and input latency issues with Vsync on (even when there's no action, GPU and CPU underutilized), and SteamOS forces Vsync ON even when "allow tearing" is enabled (it does nothing).
Would be great to have good support for this game, as it's one of the best shooters ever made :)

You should post more details like a screenshot since it isn't very clear what is meant. Also remember logs.
The issue presents itself like below when you start the game

Screenshot

It can be worked around by forcing a aspect ratio e.g. d3d9.forceAspectRatio = 16:9 for my monitor.
Log without config (quite spammy)
Painkiller_d3d9-no-config.log
Log with config
Painkiller_d3d9-yes-config.log

Thank you for the answer! I should have precised that I'm on the Steam Deck, but I was able to reproduce this issue in desktop mode as well.
Switching back to DXVK (WINED3D=0), unfortunately force aspect ratio 16:9 doens't help, both in desktop an deck ui, unless the lowest resolution is selected. it's working because only 16:9 resolutions are available

I can also confirm the same issue on my oled deck too, plus it's not just Painkiller Black Edition that's effected, but the majority of the Painkiller games save for hell and damnation, found the same issue with the game's below.

I had to force aspect ratio with the dxvk option to have access to my native resolution for some reason though.

I can confirm that the behaviour of Painkiller Black edition is still the same as the one shown by the screenshot from @Blisto91.
I'm using the latest Proton-GE with dxvk commit e6f89062f5a5af96c4ae28d2ac441e54fbe94068.
System:
  Host: fedora Kernel: 6.10.12-200.fc40.x86_64 arch: x86_64 bits: 64
    compiler: gcc v: 2.41-37.fc40
  Desktop: KDE Plasma v: 6.1.5 tk: Qt v: N/A wm: kwin_wayland dm: SDDM
    Distro: Fedora Linux 40 (KDE Plasma)
CPU:
  Info: 16-core model: AMD Ryzen 9 5950X bits: 64 type: MT MCP arch: Zen 3+
    rev: 0 cache: L1: 1024 KiB L2: 8 MiB L3: 64 MiB
  Speed (MHz): avg: 1418 high: 4116 min/max: 550/5084 cores: 1: 550 2: 3599
    3: 3599 4: 550 5: 550 6: 550 7: 550 8: 550 9: 4116 10: 550 11: 3600 12: 3453
    13: 550 14: 550 15: 550 16: 3602 17: 3600 18: 550 19: 550 20: 550 21: 3596
    22: 550 23: 550 24: 550 25: 550 26: 550 27: 550 28: 550 29: 550 30: 550
    31: 550 32: 3586 bogomips: 217614
  Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3
Graphics:
  Device-1: AMD Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT]
    vendor: XFX driver: amdgpu v: kernel arch: RDNA-2 pcie: speed: 16 GT/s
    lanes: 16 ports: active: DP-1 empty: DP-2, DP-3, HDMI-A-1, Writeback-1
    bus-ID: 0a:00.0 chip-ID: 1002:73df
  Display: wayland server: X.org v: 1.20.14 with: Xwayland v: 24.1.3
    compositor: kwin_wayland driver: X: loaded: amdgpu
    unloaded: fbdev,modesetting,radeon,vesa dri: radeonsi gpu: amdgpu
    display-ID: 0
  Monitor-1: DP-1 res: 2560x1440 size: N/A
  API: EGL v: 1.5 platforms: device: 0 drv: radeonsi device: 1 drv: swrast
    gbm: drv: kms_swrast surfaceless: drv: radeonsi wayland: drv: radeonsi x11:
    drv: radeonsi
  API: OpenGL v: 4.6 compat-v: 4.5 vendor: amd mesa v: 24.1.7 glx-v: 1.4
    direct-render: yes renderer: AMD Radeon RX 6750 XT (radeonsi navi22 LLVM
    18.1.6 DRM 3.57 6.10.12-200.fc40.x86_64) device-ID: 1002:73df
    display-ID: :0.0
  API: Vulkan v: 1.3.290 surfaces: xcb,xlib,wayland device: 0
    type: discrete-gpu driver: N/A device-ID: 1002:73df device: 1 type: cpu
    driver: N/A device-ID: 10005:0000

Both Painkiller games seem fine here on latest master.

Painkiller: Black Edition

Painkiller: Overdose

I am on X11 however, so maybe it's an issue with Gamescope?

@WinterSnowfall on Fedora 41 KDE Plasma (Wayland session - Mesa 24.2.5) with the latest release of Proton-GE 9.18 (today), the game loads on a small windows with only a quarter of the menu visible.


Patch main release workflow

Reality Collective - Reality Toolkit Pull Request
Overview

Patch main release workflow

DO NOT MERGE


Move tuple implementation to separate module

Based on PR #1375. This creates a numba.targets.tupleobj module (numba.targets.builtins is already too large).

Looks like this PR needs a remerge.


graphql.AssertException: Internal error: should never happen: cannot build value of null from EnumValue{name='PRIMARY_KEY_ASC'}

Version and Environment Details
Operation system: Mac OS X Mojave 10.14.5
IDE name and version: PhpStorm 2019.1.3
Plugin version: 2.2.0
Expected Behaviour
The plugin should successfully parse my schema, that's generated from Postgraphile which contains quite some ORDER_BY enums.
Actual Behaviour
It crashes with the following error:
graphql.AssertException: Internal error: should never happen: cannot build value of null from EnumValue{name='PRIMARY_KEY_ASC'}
Steps to Reproduce / Link to Repo with Reproduction and Instructions
Try and parse the attached schema.
schema.graphqls.zip

Hi Wessel.
Thanks for using the plugin.
The schema has a number of default values for orderby that are set to PRIMARY_KEY_ASC but the type of the argument expect a list of order by, e.g. [PRIMARY_KEY_ASC].
Here's an example of the invalid default value which should be a list:
playerDefinitionsAbilityFactorEdge(
        """The method to use when ordering `PlayerDefinitionsAbilityFactor`."""
        orderBy: [PlayerDefinitionsAbilityFactorsOrderBy!] = PRIMARY_KEY_ASC
    ): PlayerDefinitionsAbilityFactorsEdge

I did a quick replace in your schema file of = PRIMARY_KEY_ASC to = [PRIMARY_KEY_ASC] and that causes the schema to validate.
Best regards,
Jim.

Thanks, I had the same error message and it was caused by the exact same mistake in my project's GraphQL schema!


Make RefreshEnvironmentAsync faster?

RefreshEnvironmentAsync which is similar to azd env show is currently >30s long. Investigate the current bottlenecks and how we can make this faster.

Fixed via PR

https://github.com/Azure/azure-dev/pull/3420/


Error in Proxy generator?

Hi,
I stumbled on a similar error message as reported in #11 and I had to make the following fix to prevent an invalid error from being reported.
class MyClass
{
    /** @var \Magento\Customer\Model\Session\Proxy */
    protected $customerSession;

    public function __construct(
        \Magento\Customer\Model\Session\Proxy $customerSession
    ) {
        $this->customerSession = $customerSession;
    }
}

Without the patch:
 ------ --------------------------------------------------------------------------------
  Line   MyClass.php
 ------ --------------------------------------------------------------------------------
  xx     Class Magento\Customer\Model\Session\Magento\Customer\Model\Session not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ --------------------------------------------------------------------------------

The patch:
--- /src/bitExpert/PHPStan/Magento/Autoload/ProxyAutoloader.php	(date<PHONE_NUMBER>613)
+++ /src/bitExpert/PHPStan/Magento/Autoload/ProxyAutoloader.php	(date<PHONE_NUMBER>613)
@@ -105,7 +105,7 @@
                     $returnType . " {}\n\n";
             }
         } else {
-            $proxyBaseClass = ' extends ' . $originalClassname;
+            $proxyBaseClass = ' extends \\' . $originalClassname;
         }

         $template = "<?php\n";

Do you think it's really a fix or it could lead to some unexpected behavior in some cases?

Thank you @xi-ao for opening your first issue! Good catch, looks like I missed this part back when I refactored this. Mind submitting a PR for this?

Sure! I'll do this asap. :+1:

PR #48 :heavy_check_mark:


[RDBMS] Fix private DNS zone suffix bug

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

RDBMS

@yonzhan  Can this be included in the Nov 2021 (2021-12-07) milestone? This is relatively small change (4lines) but something failing some database server provisioning.


add rule for descriptive link text

Based on https://redhat-documentation.github.io/supplementary-style-guide/?topic=grammar-capitalization#cloud-services-links-hypertext
I added a rule that I hope flags empty link text and link text that only contains "click here" in a case insensitive way.
I also added pages for link text and images.

Great work @neal-timpe ! This is a very useful.
I wonder should could we add this to the existing rule about alt text in images and create a more generic accessibility rule?
So the regex would look like this: https://studio.vale.sh/s/e3d3e8259c271514938272107e51d1f4
You could rename the rule something more generic and update the rule and the test fixtures. WDYT?
cc @aireilly

Great work @neal-timpe ! This is a very useful.
I wonder should could we add this to the existing rule about alt text in images and create a more generic accessibility rule? So the regex would look like this: https://studio.vale.sh/s/e3d3e8259c271514938272107e51d1f4 You could rename the rule something more generic and update the rule and the test fixtures. WDYT? cc @aireilly
FYI - there seems to be something weird with using tokens for this rule. I've opened an issue on the Vale repo.

Sounds good to me! A generic AltText rule would be good.

https://github.com/errata-ai/vale/issues/643#issuecomment-1585131513 - Just needed to add nonword: true for the rule  to work with tokens. So part an AltText rule might look like this: https://studio.vale.sh/s/bfecfefeab7169a4cd15aa9f999fec5c

@rohennes @aireilly Thanks for the feedback! I hear what you're saying about combining them. However, I have a plan for a couple more accessibility rules. I figured this was containable and I wanted to make sure I could write one coherent one before I tried to write more than one. :)
What do you think? Should we still combine them if there are going to be a couple others?
I'll address these other comments and squash while we discuss.

@rohennes @aireilly Thanks for the feedback! I hear what you're saying about combining them. However, I have a plan for a couple more accessibility rules. I figured this was containable and I wanted to make sure I could write one coherent rule before I tried to write more than one. :)
What do you think? Should we still combine them if there are going to be a couple others?
I'll address these other comments while we discuss.

Are the planned rules for alt text for various elements? I think that a single alt text rule makes sense tbh. But I can be convinced otherwise :)

@aireilly No, the rules I have in mind are non-alt text. For example, one idea is a warning for direction words and colors.
From my perspective, I think that the link text and the image alt text are different enough to have their own rules. Link text is there to provide context. Image alt text must be equivalent to the image's purpose. I think in my next PR, I might make a stab at updating the image alt text message to make that more specific guidance in a short a space as possible.

@rohennes @aireilly Thanks for the feedback! I hear what you're saying about combining them. However, I have a plan for a couple more accessibility rules. I figured this was containable and I wanted to make sure I could write one coherent rule before I tried to write more than one. :)
What do you think? Should we still combine them if there are going to be a couple others?
I'll address these other comments while we discuss.

Understood and I'm good with your suggestion for multiple rules. These will be great contributions!!

Looking pretty good @neal-timpe Can we squash the commits before merge?

@aireilly Squashed. :)


Create more consistent checks for venv

Fixes #3468

@sinwar Can you revert the changes to tools/diagnose?  For that script we want to identify errors and report things even before a user has necessarily set up their venv correctly.

Merged as eab355b0cd7e8ca6344af6ab58c40c8bdd18a197, thanks @sinwar!


Burst point

Is it possible to improve the design of the balloon burst point? The current one is unclear. Thank you

By this do you mean how it's not that visible? Maybe we could add a darker
shadow effect so it has more contrast...
On Wed, 13 Dec 2023, 11:04 Mauri740, @.***> wrote:

Is it possible to improve the design of the balloon burst point? The
current one is unclear. Thank you
—
Reply to this email directly, view it on GitHub
https://github.com/projecthorus/sondehub-tracker/issues/307, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH57E3GECC3B5XNKM7AWH3YJDZYXAVCNFSM6AAAAABASKFTBSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTQNZUHA4TSNQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

a darker effect would be great. Thank you

hello, still very little visible the bursting point, we must think of people with vision difficulties, thank you

I haven't had time to work on this yes, sorry.
The burst icon is here: https://github.com/projecthorus/sondehub-tracker/blob/master/img/markers/balloon-pop.png
If you can figure out a way to make it a bit more opaque, or with some kind of shadow, I'd be happy to test it.

could it be something like this?

mauri740's version is more visible, that would be perfect

This doesn't look like a transparent PNG to me? It must have transparency enabled.

A quick bit of color-to-alpha in Krita, and things are looking better:
Old Icon:

New Icon:

This is now live on https://testing.v2.sondehub.org/ (noting that your browser cache might hold the old marker).
Let me know what you think.

It's perfect, excellent visibility. Thank you

This has been rolled out to sondehub.org and amateur.sondehub.org


Material Select Field value not display properly

I have facing this problem in react js material theme.

Your issue has been closed because it does not conform to our issue requirements.
Please provide a reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!