Basic InputHandler Gamepad Buttons are wrong!

Up and down are switched!
Also, do we really need a basic input handler???

Fixed! But also i removed it lol


[UI] Throttle Policy deletion dialog box shows two No buttons when trying to delete twice continously

Description:

Try deleting any throttle policy.
Click No
Try deleting the same again

Delete dialog ui will be as follows

API-M 2.0 WUM,  Firefox 77.0.1

Happens same with custom policy deletion in API-3.1 WUM


Elisp highlight: escaped quotes are not detected properly

There is a bug in processing escaped code in Elisp. Consider the following code:
    (setq electric-pair-pairs '(
                                (?\{ . ?\})
                                (?\" . ?\")
                                (?\[ . ?\])))

As you can see the escaped quote is detected as a beginning of the string, which is wrong in this case. The rest of the highlight gets broken because of this effect.

@BasicWolf Linguist only selects the grammar to use for highlighting. textmate/lisp.tmbundle is used to highlight Elisp code on GitHub. You should open an issue there ;)

Thanks @pchaigno, I'll open an issue there.


Allow external scripts to take control of input text field, history and completion

Make it plug and play?

Tab completion can now be configured by running scripts. Alternative history is implement for scripts.


Move flags to package options

To clean up the document preamble, move wip, nofigures, and nodrawings to the package options

Done in 2024-alpha


loadMorePosts action gets triggered more than necessary

loadMorePosts gets called more than twice on the userfeed

should be good now


markdown-it-mermaid: support async

Does markdown-it-mermaid support asynchronous rendering using mermaid.render instead of just rendering on first page load?

@oeyoews I will check is it possible to use Mermaid async rendering soon!


UI bug - the plus sign acts as 'clear the conversation' instead of copying

deployed a web app directly from Azure AI Studio on Monday 29-Jan-2024 and the "+" is doing the same thing as the "broom" icon.

this is with the conversation history enabled and a cosmosdb instance in place.

Hi @gw37 , the "broom" will clear all of the messages from the current conversation entry, while keeping the conversation entry in the DB. The "+" will start a new conversation entry, keeping all of the previous messages in the previous conversation entry. Hope that clears it up!


[7.x] Improve Route class doc-blocks

This PR improves the doc blocks of the Illuminate/Routing/Route class.

I think everything is fine here already.

I'm just being nosy and want to understand why a change this simple was rejected. Why? It improves the documentation of the code and is simple. The author probably experienced an issue with the doc blocks with some editor to feel the need to improve the documentation. So why is that need not important?


Bump aws eksa packages to latest

Description of changes:
Bumping aws/eks-anywhere-packages to latest tag v0.4.2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.19

/lgtm
/approve


fix: keep mermaid theme consistent with the app theme

Thank you for pointing out the theming issues; I hadn't noticed them. Given this, I believe we should develop our own Mermaid parser. It's better not to rely on an old and partially unsupported third-party library. I've already written a parser that works better and respects the app theming for Beaver Pocket, so I'll port it to Beaver Notes if that’s okay with you. This approach will give us more control over our code. Due to this change, I will close the pull request.


Graceful fail when executing transactions using cheatcode vm.transact("txn_hash")

Component
Forge
Describe the feature you would like
I have a list of transaction hashes in a Solidity test. I want to execute them using vm.transact() cheatcode. It is possible that some of the transaction fail. When transactions fail, I want to use try and catch block in the solidity test to continue execution. Unfortunately, there are transactions that make the execution fail even inside of the try and catch block, the execution of forge test fails and does not proceed further.
To overcome this issue I have added a Graceful fail on transaction execution, where failed transaction execution is logges in the console, but the execution of the test continues. https://github.com/dsalv/foundry/pull/1
I have to run cargo run --bin forge --manifest-path "path of the file" to execute the test using my fork. I am not familiar with the whole Foundry code base. I have two questions:

Is there any serious violation of the test execution workflow with this change?
If this change makes sense, it would be useful to have a flag that lets you execute tests with a graceful fail option

This is not a clear feature request, but more of a discussion before the feature request. Let me know what you think.
Additional context
No response

could you perhaps provide a repro for this case

there are transactions that make the execution fail even inside of the try and catch block, the execution of forge test fails and does not proceed further.

Fork_Simulate.sol.json
Here is the solidity test I was running.
Please, replace the ETH_RPC with your RPC for local runs.

Fork_Simulate.sol.json Here is the solidity test I was running. Please, replace the ETH_RPC with your RPC for local runs.

could you perhaps provide a repro for this case

there are transactions that make the execution fail even inside of the try and catch block, the execution of forge test fails and does not proceed further.

Fork_Simulate.sol.json
Here is the solidity test I was running.
Please, replace the ETH_RPC with your RPC for local runs.


Update custom formatter docs[Image field]

Category

[X] Content fix

Related issues

fixes #9411

What's in this Pull Request?
There were some changes in the way image fields are stored on the server. They don't have the properties serverUrl, id etc anymore. Only the filename is present. Updating the custom formatter documentation to reflect the same.

@VesaJuvonen Can you please take a look?

@thechriskent Can you take a look at this submission for suggested changes to the image field in declarative formatting? You're more experienced on JSON formatting than me...

Gentle ping for this @thechriskent and @@VesaJuvonen

thx @arkogupta for the adjustments - publishing right now - should be out within 15 min or so

Thanks @VesaJuvonen!


Cannot set mainfont and sansfont for xelatex

OS: Archlinux
pandoc 2.11

Installed texlive-most, texlive-core, adobe sans font
mainfont: "Source Sans Pro"
sansfont: "Source Sans Pro"

> kpsewhich sourcesanspro.sty
/usr/share/texmf-dist/tex/latex/sourcesanspro/sourcesanspro.sty

Howerver, if I use default engine with
fontfamily: "sourcesanspro"

It changed the body font but not the tittle and header

Related Issue #69

you can use
mainfont: "NewComputerModern"
sansfont: "NewComputerModern"
monofont: "JetBrains Mono"

Update 21/7/2022
On ubuntu, you can install fonts-cmu which has latin modern fonts
and in the yml
mainfont: "Latin Modern Roman"
sansfont: "Latin Modern Roman"
monofont: "JetBrains Mono"


clean up warnings in tests

deprecation warnings are artifacts from doing version updates, its best to fix these before they stop being warnings and become errors.  the current warnings output is:
=============================== warnings summary ===============================
repos/delphi/delphi-epidata/integrations/acquisition/covidcast/test_csv_uploading.py::CsvUploadingTests::test_uploading
  /usr/local/lib/python3.8/site-packages/pandas/core/indexing.py:1637: SettingWithCopyWarning:
  A value is trying to be set on a copy of a slice from a DataFrame

  See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
    self._setitem_single_block(indexer, value, name)

repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_duplicate_row
repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_duplicate_row
repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_uploading
  /usr/local/lib/python3.8/site-packages/pandas/io/sql.py:1429: SADeprecationWarning: The Engine.run_callable() method is deprecated and will be removed in a future release.  Use the Engine.begin() context manager instead. (deprecated since: 1.4)
    return self.connectable.run_callable(

Bumping to pandas==1.2.4 removes these warnings.


Need admin approval

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

azd env set AZURE_USE_AUTHENTICATION true
azd env set AZURE_AUTH_TENANT_ID
azd up

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
Windows 11,

azd version?

run azd version and copy paste here.
azd version 1.5.0 (commit 012ae734904e0c376ce5074605a6d0d3f05789ee)

Versions

Mention any other details that might be useful
I have tried many times the deployment but I can't make it work with Azure Active Directory enabled. I do get the consent window for the admin to approve. My app is only visible for the admin (owner role) but other users get the below error message:

Even the user that I managed to do the deployment, without any errors, can't access the application.
Any hint what could be the issue? Many thanks.

Hi @pope-llamas0g ,
Thanks for reporting this. If you are seeing this issue, then an admin must manually grant consent to the app created by the scripts. You can do this in the Entra portal
https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/grant-admin-consent?pivots=portal

Hi Matt, thanks for your reply. I don't understand why I have to do it manually. I have given the access with the another Owner account and clicked on grant when trying to use the website for the first time. I have tried this with another tenant and it works fine. But currently with this another tenant I can't make it work.
I am also trying to follow your link but I don't see any Enterprise Application listed to grant access on Entra ID, just some all old apps, not the chatbot.
Thanks

Hi @pope-llamas0g ,
The reason this works in some tenants and not others is due to a policy set by the tenant admin. When this policy is set, there's no way around this besides granting admin approval to the app itself.
https://learn.microsoft.com/en-us/entra/identity/enterprise-apps/configure-user-consent?source=recommendations&pivots=portal
If you cannot see the application, you might be in the wrong tenant. If you cannot grant admin approval or cannot see this option, you might not be a tenant admin.
Please let me know if you have any more questions,
Mat

oh thanks, I had access to an owner account, but yes it is not a Global Admin Account. I will try it out again with another account.
Thank you!

I'm running into the same problem. @mattgotteiner, could you please explain why "tenant wide" rights are needed? This seems like a "scary" level of access. As explained in the link above:

Granting admin consent on behalf of an organization is a sensitive operation, potentially allowing the application's publisher access to significant portions of your organization's data, or the permission to do highly privileged operations.

Why is this required just for authentication? Is there a workaround with less application privileges?


fix(db): fix issue with removing old blks/trxs

Our DB size was huge because we did not clean dag blocks and trxs properly, so we had everything 2x

prnet cleaned-up successfully


Update client3:akka-http-backend, ... to 3.7.0

Updates

com.softwaremill.sttp.client3:akka-http-backend
com.softwaremill.sttp.client3:core

from 3.5.2 to 3.7.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.softwaremill.sttp.client3" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #401.


Does not work with dotnet 1.1.1

Are there plans to support this feature for ASP.NET Core 1.1.1 projects built in VS 2017?

Can you be more specific about what doesn't work? There are multiple packages in this GitHub repo.

Sorry for the vague message - I was referring to the DotNetTools watcher. The ability to run dotnet watch run

Please use 1.0.0. The 1.1.0-preview4-final version should not be used. It was a build to support project.json tools, but is not longer supported. We'll be unlisting it from NuGet so it won't appear in search results.
See https://github.com/aspnet/DotNetTools#how-to-install for instructions on how to install.

Thanks for removing that from NuGet.
I tried installing 1.0.0 via nuget and received the same error.

Are we only able to install this via updating the csproj file?

You must edit the csproj file directly. This is something NuGet didn't implement in VS 2017. Please use https://github.com/NuGet/Home/issues/4190 for feedback on this.

Thanks for your help, @natemcmaster


History DLQ implementation

Coverage decreased (-0.2%) to 66.616% when pulling 7210e7cafe785950db986446365995b458ec86f9 on history-dlq into ac9069349846e8ab8502ac05a44abe4fbb8297ab on master.


404 cannot load file browser.js with fastify plugin

What happens?
the ui doesn't load
What did you expect to happen?
The UI should load
How can we reproduce the issue?
Create a fastify instance like this
const app = Fastify()
  .register(fastifySwagger, {
    transformObject: () => openApiDocument,

  })
  .register(ScalarUi, {
    prefix: '/docs'
  });

And run with bun
Swagger/OpenAPI Example
No response

Would you mind to try routePrefix instead of prefix?

I think it’s routePrefix instead of prefix. I followed this guide: https://github.com/scalar/scalar/blob/main/documentation/fastify.md and everything seems to work just fine.
I’m closing this for now, let me know if I missed something. :)


feed_times never increment

the feed_times variable never increment.
Is there some limitations from the API or should it work?

Same problem here.
Feed_time and feed_amount  not working.

Checking the result of API request, it seems that times and realAmountTotal are not in the JSON return.


⚠ T:Riza Docs has degraded performance

In 5cb749a, T:Riza Docs (https://docs.triza.dev) experienced degraded performance:

HTTP code: 500
Response time: 16807 ms

Resolved: T:Riza Docs performance has improved in d219510.


Address feedback on SSLv2 ClientHello processing

Feedback on the previous SSLv2 ClientHello processing fix was that it
breaks layering by reading init_num in the record layer. It also does not
detect if there was a previous non-fatal warning.
This is an alternative approach that directly tracks in the record layer
whether this is the first record.
GitHub Issue #1298

Ping @davidben. Thoughts?

No tests? ;-)

I've added three new commits to this:

One addresses the feedback received so far
One implements a set of tests for V2ClientHello processing
One fixes a bug where we didn't send an alert if we received a non-initial record with the wrong version discovered as a result of the above tests.

Needs a team member review.

(Non-team-member lgtm. But I don't really know perl, so I just glossed over those bits.)

Another non-team-member lgtm, modulo the commented duplicate line, and I only sort-of looked at the perl.

Duplicate line removed. So two non-team member reviews done - still need another team review!

Ping any team member!!

Rebased this.

+1 - code looks much clearer to me at least

Merged. Thanks @t-j-h.


nuxt-bridge nitro preset 'aws-lambda' fails to launch

Environment
This seems to be the case in multiple environments, including the code sandbox template:
Code Sandbox:

Operating System: Linux
Node Version:     v14.18.1
Nuxt Version:     2.16.0-27358576.777a4b7f
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      nitro, bridge, buildModules
Runtime Modules:  -
Build Modules<EMAIL_ADDRESS>
macOS:

Operating System: Darwin
Node Version:     v14.18.1
Nuxt Version:     2.16.0-27358576.777a4b7f
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      ssr, nitro, target, head, publicRuntimeConfig, css, styleResources, plugins, components, buildModules, modules, build, bridge
Runtime Modules:  -
Build Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>
Reproduction
https://codesandbox.io/s/nuxt-bridge-aws-lambda-preset-8r065h
Describe the bug
When starting the Nuxt Bridge dev server, the following error occurs:
 ERROR  [worker reload] [worker] exited                               15:39:42

  at Worker.<anonymous> (node_modules/nitropack/dist/chunks/prerender.mjs:2039:14)
  at Object.onceWrapper (events.js:520:26)
  at Worker.emit (events.js:400:28)
  at Worker.emit (domain.js:475:12)
  at Worker.[kOnExit] (internal/worker.js:278:10)
  at Worker.<computed>.onexit (internal/worker.js:203:20)

In the browser, a 503 error code is given showing the same error from the terminal
Additional context
This appears to affect Nuxt Bridge only. Nuxt 3 launches without errors using the aws-lambda nitro preset
Logs
No response

This has been resolved upstream in nitropack, and will be fixed when we upgrade it in Bridge. For now, you can work around by setting your preset conditionally:
import { defineNuxtConfig } from '@nuxt/bridge'

export default defineNuxtConfig({
  nitro: {
    preset: process.env.NODE_ENV === 'production' ? 'aws-lambda' : 'nitro-dev',
  },
})

In addition to the above, I am experiencing:
"[worker reload] [worker init] Cannot find module '/xxx/.nuxt/views/document.template.mjs' imported from /xxx/.nuxt/dev/index.mjs"
This is when running nuxi dev with either the preset ('nitro-dev') hard coded in the example above or not set at all.
Context:
Upgraded from 3.0.0-27468803.23e7afb to 3.0.0-27498038.f18e68b
Using webpack instead of vite
Since installing nuxt bridge HMR requests have failed the vast majority of the time (but weirdly occasionally working).
Any help to resolve this or a way to configure nitro to be aws-lambda compatible with an earlier version of bridge would be much appreciated!


Support for Hijri or Jalali or other international calendar in datepicker

I think making dateUtil.js injectable, would provide calendar support functionality for Hijri or Jalali or other international calendars in datepicker. Adding fromGregorian and toGregorian date functions to $mdDateLocale service may provide more abstract solution. These functions could be consequently used in dateUtil.js to provide localized date calculation. Currently $mdDateLocale just provide messages, formatters, and parsers for date internationalization but not date conversion.
I volunteer to produce dateUtil or $mdDateLocale for Hijri or Jalali. Please help me how.

There's no datepicker in material2. $mdDateLocale sounds like material. You are probably in a wrong repo.

I just saw datepicker on material2 feature status: https://github.com/angular/material2#feature-status
thought that it would inherit the same functionality from material. Hope you take internationalization date conversion into account for new datepicker. We all love material(2) and your great project.

The problem with datepicker, as mentioned in its issue, is that there are no specs(for desktop version anyway) in material design for it.. so until google designers create those, there won't be no official date/timepicker implementation. Sadly.
But I'm pretty sure that once the spec is done, internationalization  will be taken into account.

Internationalization date conversion may not affect visual design of datepicker. It just refer to how cells arrange according to the native calendar rules, mainly the same functions as currently exist in dateUtil material datepicker, but with native alternative principals. About the visual customization, task already done gracefully in $mdDateLocale.

We're designing the datepicker now. We likely will only be able to support the Gregorian calendar in the initial version, but it's worth thinking about in the design.

At the moment it is not important to support any special native calendar. The only important point about this feature is to make the logic of date conversion 'injectable'. Then every folk will know how to implement their native conversion logic providers. Although I had some suggestions above, but as a designer, you know better how to construct the structure. Thanks Jeremy, for taking it into account and for your grate project.

I'll have a design doc to share shortly, it would be great if you could take a look and let me know if you think the design is flexible enough to support this.

of course, it would be my pleasure.

@araselahi design doc is now available: https://docs.google.com/document/d/1RwPFESCbSSLMSDqxWo7jg4UUpGJTrXX6p5wYlb9pmNc/preview

I have just seen the notification in my email. I will get back to you soon.

@mmalerba 'CalendarLocale injectable' and 'Internationalization' sections currently include the definition only about the word translation and visual parsing and formatting but not other nationality date conversion logic. In other calendars, days calculation completely different from Gregorian. So I guess we need all the logic in dateUtil.js such as getFirstDateOfMonth, getNumberOfDaysInMonth and so on could be replaceable according to the other international calendar to determine how the days to be rendered on the date picker. I think with this suggested feature, it would be a magic date picker for other folks. B.S I am not sure the new SimpleDate data type could support other international calendar dates because it is still subset of Gregorian calendar date. Oh, bingo! what about inventing a HijriSimpleDate or JalaliSimpleDate to be used instead of standard Gregorian SimpleDate?

@araselahi I'd like to find some way to allow using moment.js objects instead of SimpleDate when the library is loaded. moment.js already has plugins for working with other languages. I still need to find the best way to do this though

As @araselahi mentioned, it is not a matter of translation from English to another language.
In Persian calendar for example the whole logic of the date system is different.
2017-April-15 may be translated into 2017 آپریل 15 which has nothing to do with Persian calendar for our daily usage which is 1396-1-26 yyyy-MM-dd.
It is 26th day of the first month of the year 1396, but in Gregorian calendar it is 15th of the forth month of the year 2017.

@peymanebrahimi it completely depends on how to implement Moment.js. If the output of configured Moment.js object was rendered on the final date picker surface as @mmalerba designed for, that would be great. Please check it out:
https://momentjs.com/docs/#/plugins/jalaali/

@mmalerba does what we have now actually support different calendars, or are there assumptions about the Gregorian calendar baked in?

I think we still have some assumptions baked in, but it should be easy enough to change them to settings in the DateAdapter going to mark this one as good for community contribution. It would be nice to have someone who knows more about other calendars help with it.

@mmalerba with DateAdapter implementation, currently you have done the critical task for calendar logic internationalization. thank you so much for your consideration. I am here to contribute for implementing JalaliDateAdapter. is there any sample like: How to implement a new DateAdapter ?

@peymanebrahimi has been working on a Jalali adapter https://github.com/angular/material2/issues/5972#issuecomment-329956087, you may want to consider collaborating with him.
Currently the best documentation is just the JSDoc on the DateAdapter https://github.com/angular/material2/blob/master/src/lib/core/datetime/date-adapter.ts
You can also use the NativeDateAdapter and MomentDateAdapter as example implementations:
https://github.com/angular/material2/blob/master/src/lib/core/datetime/native-date-adapter.ts
https://github.com/angular/material2/blob/master/src/material-moment-adapter/adapter/moment-date-adapter.ts
Sorry it doesn't have better documentation yet... I need to work on that @araselahi

Have you thought of supporting Julian Day Numbers for internal conversions from one calendar format to another? There are already JS libraries around that could possibly be used for the conversions (e.g., http://npmjs.com/package/moonbeams).
I am interested in developing the following features:

BCE dates for Gregorian and Julian calendar
different precisions: day, month, year

@tobiasschweizer choosing a different precision is tracked by https://github.com/angular/material2/issues/4853, this is something we plan to add
BCE dates and a Julian calendar are not features we plan to add to Angular Material, but they are features that we want enable via a custom DateAdapter. If you're interested in working on these we would love for you to share it with the community. If you encounter any limitations of the DateAdapter that prevent you from accomplishing this, feel free to open issues and we will look into it.

@mmalerba Thank you very much for the explanation!
Let me have a look at DateApapter first. I guess I find some relevant information here https://material.angular.io/components/datepicker/overview#choosing-a-date-implementation-and-date-format-settings
As far as I understood, DateAdpater is an interface/abstract class (https://github.com/angular/material2/blob/dfe8091d959f1bb54cc33a8d942cbe7ea4e3fe56/src/lib/core/datetime/date-adapter.ts#L21) making use of generics that currently has two implementations: Native Date Adapter (https://github.com/angular/material2/blob/ea54edb7ef1c5338120c3991acbe325ad7c27764/src/lib/core/datetime/native-date-adapter.ts#L60) and the Moment Date Adapter (https://github.com/angular/material2/blob/9fa075e001188f1a346dbc260606e871bc653e1a/src/material-moment-adapter/adapter/moment-date-adapter.ts#L34).

@tobiasschweizer Yep, that's correct. I've been meaning to write a guide on creating a custom DateAdapter but haven't gotten the time. Those two concrete classes should serve as good examples though.

@mmalerba Thats' fine. Let me look at it in detail. I will come up with some suggestions of how to integrate the request features, so we can discuss them.

@mmalerba This is a primitive first sketch of how I think this could work (I do not address the BCE problem yet, divide et impera ...). I hope I got the basic idea of the design and this contribution is useful.
The DateAdapter would have two new abstract methods getSupportedCalendars(): string[] and convertCalendar(cal: D, toFormat: string): D. The DatePicker UI component could display a list of available calendars to the user. If the user chooses another calendar than the one currently given, a conversion would happen from the current calendar to the chosen one.
JDNCalendar  is an abstract class that would have to be implemented/subclassed for all supported calendar types (here only Gregorian and Julian). The clue would be that every implementation or subclass of  JDNCalendar can be created from a Julian Day Number and convert itself to a Julian Day Number. Like this, a Gregorian calendar date can be converted to a Julian calendar date etc., preserving the currently selected date.
We have implemented that earlier, but the code base is a mess: https://github.com/dhlab-basel/Knora/blob/develop/salsah/src/public/js/datehelpers.js, https://github.com/dhlab-basel/Knora/blob/develop/salsah/src/public/js/jquery.dateobj.js
However, the new abstract methods for DateAdapter do not make sense for the existing implementations since there is no conversion between calendars that could happen. In this case, the datePicker should show them (if getSupportedCalendars() returns an array of length 1).
const Gregorian = 'Gregorian';
const Julian = 'Julian';

/**
 * Represents a calendar conversion error.
 */
class CalendarConversionError extends Error {

    constructor(readonly message: string) {
        super(message)
    }

}

/**
 * Abstract class representing a calendar format
 * that can be converted from and to a Julian Day Number (JDN).
 */
abstract class JDNCalendar {

    // type of calendar
    calendarType: string;

    // supported calendars
    readonly supportedCalendars = [Gregorian, Julian];

    /**
     * Convert an instance of JDNCalendar to a JDN.
     *
     * @returns {number}
     */
    abstract toJDN(): number;

    /**
     * Converts from one calendar format into another.
     *
     * @param {"Gregorian" | "Julian"} toCalendarType
     * @returns {JDNCalendar}
     */
    convertCalendar(toCalendarType: string): JDNCalendar {

        if (this.supportedCalendars.indexOf(toCalendarType) == -1) throw new CalendarConversionError("Calendar not supported: " + toCalendarType);

        if (this.calendarType == toCalendarType) return this; // no conversion needed

        const jdn = this.toJDN();

        switch (toCalendarType) {
            case Gregorian:
                return new GregorianCalendar(jdn);

            case Julian:
                return new JulianCalendar(jdn);
        }

    }

}

/**
 * Represents a Gregorian calendar date.
 */
class GregorianCalendar extends JDNCalendar {

    /**
     * @param {number} jdn Julian Day Number
     */
    constructor(jdn: number) {
        super();

        // create a Gregorian calendar date from jdn

    }

    readonly calendarType = Gregorian;

    toJDN(): number {
        return 1; // for testing only
    }

}

/**
 * Represents a Julian calendar date.
 */
class JulianCalendar extends JDNCalendar {

    /**
     *
     * @param {number} jdn Julian Day Number
     */
    constructor(jdn: number) {
        super();

        // create a Julian calendar date from jdn

    }

    readonly calendarType = Julian;

    toJDN(): number {
        return 2; // for testing only
    }

}

/*
 new abstract methods for DateAdapter:
  - getSupportedCalendars(): string[]
  - convertCalendar(fromCal: D, toFormat: string)
*/

/**
 * DateAdapter for JDNCalendar
 */
class JDNCalendarAdapter extends DateAdapter<JDNCalendar> {

    // TODO: implement all abstract methods of DateAdapter and override non abstract methods of DateAdapter if necessary

    getSupportedCalendars(cal: JDNCalendar): string[] {
        return cal.supportedCalendars;
    }

    convertCalendar(cal: JDNCalendar, toFormat: string): JDNCalendar {

        return cal.convertCalendar(toFormat);

    }

}

I don't think we want to add calendar conversion APIs to the DateAdapter (since as you said, it doesn't make sense in a lot of cases). Rather I would make a JulianCalendarDateAdapter that handles things like parsing and formatting Julian dates, and getting the julian year, month, and day.
If you then wanted to be able to dynamically toggle between the two calendars you could make a wrapper DateAdapter that delegates to one of the two depending on the mode its in:
class CombinedAdapter extends DateAdapter {
  private gregorianAdapter = new NativeDateAdapter();
  private julianAdapter = new JulianCalendarDateAdapter();
  private currentAdapter = this._gregorianAdapter;

  setCalendar(cal: 'Gregorian' | 'Julian') {
    this.currentAdapter = cal === 'Gregorian' ? this.gregorianAdapter : this.julianAdapter;
  }

  // Implement all methods to delegate to currentAdapter:

  parse(value) {
    return this.currentAdapter.parse(value);
  }

  ...
}

The one thing we might need to change to make this work is to add some way to flag the datepicker that the DateAdapter has changed modes and that the datepicker should update its view.

I understand that the calendar conversion method in DateAdapter does not make sense for implementations where only one calendar is available.
However, the JDNCalendar I proposed is not the same as the Julian calendar date.
A JDN (Julian Day Number) is an integer (no fractions unlike the Julian Day Count JDC) that represents the number of days since an astronomical event (JDN 0) of November 24, 4714 BC, in the Gregorian calendar or Monday, January 1, 4713 BC, Julian calendar (https://en.wikipedia.org/wiki/Julian_day).
Both Gregorian and Julian calendar dates (as well as others) can be created from a JDN and converted to a JDN. Using JDN, one can thus do calendar conversions (see https://www.fourmilab.ch/documents/calendar/).
So my idea is to create an implementation of DateAdapter for JDNCalendar (maybe I have to think of a better name for the latter) that could convert any calendar format to any other calendar format for which an implementation for JDNCalendar exists, preserving the currently selected date.
Subclasses or implementations of JDCalendar can be constructed from a given JDN and converted to a JDN, from which others can be constructed again. So the JDN is like the common denominator for different calendar formats.
If I understood you correctly, you proposed a specific implementation of DateAdapter for Julian calendar dates. This would mean that we would have to make a specific implementation for each calendar we want to support. Instead, I propose to make use of one abstract class (JDNCalendar) for which only one implementation of DateAdapter has to exists and which can also be implemented for other calendar formats if they can be converted from at to JDN , e.g., Hebrew calendar.

Ah I see, I had not heard about Julian Day Number before. In that case I think your proposal sounds reasonable. Would the JDNCalendar then be responsible for reporting things like what the months are in its particular calendar system?
Another thing to consider is the parse and display formats. We allow the user to provide mappings for the formats needed by the datepicker via the MAT_DATE_FORMATS token. It sounds like for your idea you would need to come up with a way to represent the format independent of the calendar system. It's kind of the same problem I was trying to solve when I made these mappings in the first place, you could just map each key to a string of the same name and have each concrete JDNCalendar decide how to represent it itself. If we added more formats to the datepicker at some point you would need to just add those to your implementations as well.

I really like your design that separates the UI-component (datepicker) from a concrete implementation of a calendar (currently JS Date object and MomentJS) using DateAdapter as the interface through which communication between the UI and the calendar is established.
This abstraction greatly enhances the re-usability of the UI component. However, I also see things that are actually calendar specific like the distinction between BCE and CE dates and only make sense for the Gregorian and the Julian calendar.

Would the JDNCalendar then be responsible for reporting things like what the months are in its particular calendar system?

Yes, JDNCalendar would have to have methods that tell the UI-component everything it needs to know to make the date selection possible for the given calendar (e.g., the Hebrew calendar's months are called differently than the months of the Gregorian and Julian calendar). But this would mean that DateApater would have to be extended for that purpose so that the UI component can ask the implementation of DateApter about it. But there are already methods for that in DateAdapter:

getMonthNames()
getDayOfWeekNames()

Although we aim to be as generic as possible, the UI component might be limited to calendars that work with a concept of years, months, and days.

Another thing to consider is the parse and display formats.

I think localization and format information has to be provided for each implementation of JDNCalendar.
How shall we proceed? I would like to work on JDNCalendar and support implementations for the Gregorian and Julian calendar for now. Of course, implementations for other calendars may be added too.
I think JDNCalendar can be developed outside Angular Material 2 repo, but we need to decide on the additional methods for DateAdapter, and that will affect existing implementations for Date object and Moment JS.
See my sketch:

Another thing to keep in mind is the precision. A precision can by expressed using two JDNs (see http://www.knora.org/documentation/manual/rst/knora-ontologies/knora-base.html#datevalue, https://github.com/dhlab-basel/Knora/blob/cc53ef8cd072b7c9c53c7e5b3ab3a92c497b3038/webapi/src/main/scala/org/knora/webapi/util/DateUtilV1.scala). If the two numbers are equal the precision is day. Month precison would be from the first day of the month to the last and the same logic applies to the year. Periods may be expressed by simply having two datepickers, i.e. two dates that migh have different precisions.

I am having a look at the abstract methods of DateAdapter and the ones that are overridden by its subclasses.
I am quite sure I forgot some of the methods or misunderstood some of them, please feel free to correct me ;-)
With date: D as parameter (get information from or modify a date instance):

getYear(date: D): number: returns the given date's year as a number (e.g., 2017).
getMonth(date: D): number: returns the given date's month, starting with index 0 for January.
getDate(date: D): number: returns the index for the day of the month for the given date, starting with 1. Wouldn't it be clearer to use the term "day"?
getDayOfWeek(date: D): number returns the index for the day of the week for the given date, starting with 0 for Sunday
getYearName(date: D): string: returns the given date's year as a string Isn't that somehow redundant? -> getYear(date: D): number
getNumDaysInMonth(date: D): number: returns the number of days for the given date's month.
addCalendarYears(date: D, years: number): D: increases the given date by the given amount of years
addCalendarMonths(date: D, months: number): D increases the given date by the given amount of months
addCalendarDays(date: D, days: number): D: increases the given date by the given amount of days
isValid(date: D): boolean: returns true if the given date is valid
isDateInstance(obj: any): returns true if obj is of type D (the type of date supported by the implementation of DateAdapter)

Methods needed by the UI component for the given calendar format D (no instance of D required though):

getMonthNames(style: 'long' | 'short' | 'narrow'): string[]: returns the names of the months as an ordered list
getDateNames(): string[]: returns an ordered list of strings "1" to "31" (regardless of how many days the current date's month has) Wouldn't it be clearer to use the term "day"?
getDayOfWeekNames(style: 'long' | 'short'): string[]: returns an ordered list of the names of all days of the week, starting with Sunday
getFirstDayOfWeek(): number: returns the index of the first day of the week, i.e. 0 (Sunday)

Methods to construct an instance of a date:

clone(date: D): returns a copy of the given date.
createDate(year: number, month: number, date: number): D constructs a date Wouldn't it be clearer to use the term "day" for the last parameter?
today(): D: returns a date representing today's date
parse(value: any, parseFormat: any): D | null: constructs a date from a user provided value, taking into account locales if possible (e.g., for Moment JS)
deserialize(value: any): D | null: attempts to construct a date from the provided value
invalid(): constructs an invalid date instance

Methods to serialize a date:

format(date: D, displayFormat: any): serializes the given date to a string, using the given format
toIso8601(date: D): serializes the given date to a ISO date string

I think each implementation or subclass of JDNCalendar has to provide an own implementation of the methods in group 2 since these are specific to the calendar format.
For createDate, parse and deserialize in  group 3 an indication of the calendar format is needed. Gregorian could be made the default, so existing implementations wouldn't break.
When serializing the date, the calendar information has to go somewhere (group 4).

Apologies for the slow response. I agree with what you've outlined above. I think this is a cool idea, it would be great for people who need a more robust solution for dealing with multiple calendars.
Here's some thoughts & rationale for some of the decisions:

But there are already methods for that in DateAdapter:

getMonthNames()
getDayOfWeekNames()

Although we aim to be as generic as possible, the UI component might be limited to calendars that work with a concept of years, months, and days.

Yes this does limit us to calendars that use years, months, and days. Though I think that should cover the vast majority of calendars people would want to use with the datepicker. Though one of the things I don't like about these various get*Name[s] methods is that they kind of mix date format stuff into the logic. Another idea would be to have method like getNumMonthsInYear(date: D) and getNumDaysInMonth(date: D) we could then get the names of the months by creating a date for the month and doing something like format(date, formats.LONG_MONTH_NAME). Changing the API to this would also allow us to support calendars that have a variable number of months depending on the year .

Wouldn't it be clearer to use the term "day"?

I used "date" to stay consistent with what javascript does and avoid confusion with days of the week. Though I agree its confusing in its own way. I would be ok replacing the "date" APIs with "dayOfMonth".

Isn't that somehow redundant? -> getYear(date: D): number

The idea was that the name variant could be used in situations where the string representation was more than just the number. For example in Japanese maybe someone would want to include the year kanji: "2017年". Though as I mentioned above I don't like how these "-name" APIs mix in formatting logic. It might be better to move to something like format(date, formats.YEAR_NAME).
Do you want to start a repo for it? If you run into flexibility issues with the DateAdapter API as you go let me know and I'll consider making changes. I'd also be happy to review code if you need an extra set of eyes on anything.

@mmalerba No worries! Thank you very much for your detailed response.
I have started implementing JDNConvertibleCalendar here: https://github.com/dhlab-basel/JDNConvertibleCalendar. I still need to figure out how to structure it because I want it to become an npm module.
I also still need to figure out how date manipulations work (increasing and decreasing year, month, and day). I have already added some simple conversion tests. The current implementation will still change a lot, but I hope that there will be a proof of concept soon.
I did not bother with precision yet (every date has an exact start and end so far: day precision), also I did not care about string formats yet. I think a lot of this should be handled in the implementation of DateAdapter for JDNConvertibleCalendar. JDNConvertibleCalendar should only handle the conversion logic and the math used for manipulations (jump to the next month or year when increasing days etc.). Since I work at a university, I will get all the scientific support I need.
In which repo would the implementation of DateAdapter have to go for JDNConvertibleCalendar?

Hmm I think its up to you how you want to structure it. You could put it in the same repo but make a separate npm package from the core calendar logic if you want to make the calendar logic available to people who aren't using Angular. The angular specific stuff would probably consist of the date adapter, a set of formats, and a module or 2 that people can import to easily set up the providers.
This is similar to what we do for the MomentDateAdapter it lives in the same repo as the rest of material, but we publish it as its own npm package since it has additional dependencies.

I think it would make sense to put the JDNConvertibleCalendarDateAdapter in the Angular Material 2 repo. https://github.com/dhlab-basel/JDNConvertibleCalendar could still be used without Angular Material 2. Also if DateAdapter is going to be changed in the future, this would make things easier to coordinate.
I forked the Angular Material 2 repo. Shall I implement JDNConvertibleCalendarDateAdapter there and create a PR? I might have some questions how to include it in app-module.ts in our Angular app https://github.com/dhlab-basel/Salsah.
How shall I deal with the DateAdapter interface? Shall I just add what I think is needed as proposed in https://github.com/angular/material2/issues/2519#issuecomment-349264844?
Maybe it would make things easier if we could talk briefly. However, I suppose your are located in the US and I am here in Europe (time diff.).

@mmalerba I created a new branch on my forked repo from angular/material2: https://github.com/dhlab-basel/material2/tree/datepicker-datadapter-jdnconvcal
I am struggling with package.json and the basic structure (index.ts, tsconfig). I would be glad if you could give me a hand here. I guess once I have the basic setup similar to src/material-moment-adapter I should be fine and can implement it by myself.

@tobiasschweizer I can set up some time to do a Hangouts conversation if you like. Shoot me an email<EMAIL_ADDRESS>

@mmalerba As soon as a build with our merged PR https://github.com/angular/material2/pull/9639 is available, I will make a proof of concept in my repo https://github.com/dhlab-basel/JDNConvertibleCalendarDateAdapter with a custom header so that the user can switch between Gregorian and Julian calendar formats. https://github.com/dhlab-basel/JDNConvertibleCalendar will have to be extended too so that more calendar formats are supported in the future.

I think it is already there d6e71c9c9ee0d54683ee4aa338be634a319fa770

@mmalerba @araselahi
We added support for the Islamic calendar.
See https://stackblitz.com/edit/angular-qapxhn
I set the locale to 'ar', 'en' is used as a fallback for the names of weekdays and months. I think there is still a RTL issue:

Also abbreviations would be nice for transliterations of the Arabic names, see https://github.com/dhlab-basel/JDNConvertibleCalendar/blob/master/src/names.json
Could you give me a hand here?

btw: all the available calendars can also be used individually. In the date adapter, I still have to figure out a way to set the initial calendar correctly, see https://github.com/dhlab-basel/JDNConvertibleCalendarDateAdapter/pull/9

(revisiting old feature requests)
Closing this issue since I don't realistically ever see us prioritizing adding support for non-Gregorian calendars. With the current state of our backlog, it would be years before we would even consider this, and I don't foresee it ever getting near the top of the queue.

(revisiting old feature requests)
Closing this issue since I don't realistically ever see us prioritizing adding support for non-Gregorian calendars. With the current state of our backlog, it would be years before we would even consider this, and I don't foresee it ever getting near the top of the queue.

(revisiting old feature requests)
Closing this issue since I don't realistically ever see us prioritizing adding support for non-Gregorian calendars. With the current state of our backlog, it would be years before we would even consider this, and I don't foresee it ever getting near the top of the queue.

I understand.
Could you tell me anything about the priority of the precision task (year or month selection)? At the moment, the date and range pickers only allow for day selection.

(revisiting old feature requests)
Closing this issue since I don't realistically ever see us prioritizing adding support for non-Gregorian calendars. With the current state of our backlog, it would be years before we would even consider this, and I don't foresee it ever getting near the top of the queue.

I understand.
Could you tell me anything about the priority of the precision task (year or month selection)? At the moment, the date and range pickers only allow for day selection.

@tobiasschweizer it's something I'd like to explore eventually, but I don't see us dedicating any time to it in 2021

@tobiasschweizer it's something I'd like to explore eventually, but I don't see us dedicating any time to it in 2021


add topic quantum-chemistry

I suggest adding the topic quantum-chemistry in the About section.

Quantum chemistry related keywords have been added.


RuntimeError: All supplied parameter names or regex patterns not found.

Hi,
I get prunable layers by
for (name, layer) in get_prunable_layers(model):
    print(f"{name}")

Put them into recipe.
Then I run
manager = ScheduledModifierManager.from_yaml("sparsify_recipe.yaml")

And finally
optimizer = manager.modify(model, optim, steps_per_epoch=len(dataLoader))

After which I get following error:
RuntimeError: All supplied parameter names or regex patterns not found.No match for features.0.0 in found parameters [].
Supplied ['features.0.0', 'features.1.0.block.0.0', 'features.1.1.block.0.0', ......]

Moreover when I run the manager.modify(..) cell in jupyter notebook second time(same session) it does not produce error, but might not be connected to sparseml, but to vscode or jupyter.
How come found parameters list is empty? What is wrong and how to fix it?
Thank you!

Got it, I had to put .weight after every param name in the recipe. This is kinda impractical, would be pain to do this for some huge models. Regex can help a bit, but still not really foolproof if layers/params are named haphazardly.


Tweak 2 validation error messages on Health: Learning difficulties page

Tweak 2 validation error messages on Health: Learning difficulties page
See Trello 375
Changes in this PR
This PR tweaks the text of 2 of the validation error messages shown when follow-on questions are not answered.
Screenshots of UI changes

 Health subsection - Learning difficulties and Neurodiversity


Getting stuck on signinRedirectCallback

I'm working on angular 10, implemented the auth service  which works most of the time but occasionally getting stuck on login screen:
Error - > error: "invalid_grant"
error_description: "The specified authorization code is invalid."
Not sure why it works and suddently it stops working.
// config
const stsSettings = {
authority: ${this.ssoissuer}/auth,
client_id: environment.ssoclientid,
redirect_uri: ${this.host}/signin-callback,
scope: 'openid email profile offline_access',
response_type: 'code',
post_logout_redirect_uri: ${this.host}/signout-callback,
revokeAccessTokenOnSignout: true,
automaticSilentRenew: false,
silent_redirect_uri: ${this.host}/assets/silent-callback.html
};
// AuthService complete login which seems to have a problem from time to time
public completeLogin(): Promise {
return this.userManager.signinRedirectCallback().then(user => {
this.user = user;
this.loginChangedSubject.next(!!user && !user.expired);
return user;
});
}

It looks like the code gets trimmed for some reason.
Please check the Code on the URL:
http://localhost:4200/signin-callback?
code=CfDJ8Jx_1V6EPfVPgt__3-zVrP5Ko1qpp7LDFw38HQx5R1POtqHe98kPWod1UoinCn1rc-YIucn8ys7hBdQSHzEZHcIcOCBSr9Np02UU6Jv9L8jDx_
gZiNtyic5smJ9O6EGaYMBokJlXVkx_lQHLr3LnuEr4p11Dd6gG-P1HeH3XafhGI4BM1Y7RGFtmTmdHpaMSELplo38sNOAApKH6wPXlV6HGRCj_
9Z9QBhENp0p9epwAse6Th03zPG9bmx9-Qc3aoUxhGiS03EmBiZ6OuNakq83H0-nR76-mwgpEwZDusdFaoHb93tGXz-jtYqFgRLYXODnO3tX8bNOCktidmOLT0jBUMw_
gUq3uhq-pcJOg-FeG_Xj2XEXF_3pEgtBrBGDlrU_FjPGsXdYbOkQgQZ8RF4k9zncMGPyOnCXempNpWsj_eSyzulwuaqNqTb53PEWJeMAqinW3Bfao-Lf5NhO3V2GEg-in_
KQ-CUvOU_ncGpf_byqYauXgtH-Rx4YT0s3LIXES2WwyRDJzSRjjPZuECVfky4-9uI81Mi9iq8pgnyy45OR18TkmoTAawxmbR4o3LOiW_BZESithhEdomMjvCqxX_
5wKj6vPnRvmbhkI-wQAx04taFD-aEbMMzgKapN_X1olhZxpQ0Fdzfp_dZViLyWoMwE6JWkiVLDCYlDajayQmsiPVY2u_U17dhNG39GrpNkHZddsxAf52RvaWDSQfUkv9dabkx6vSuU0ZBkz19-
p0hq_AhR6I5Jn-TMAU-wNoA7RnrbWXDp-NrB5DpAoSjju9GEor4qikAn0PJQ0x6ykqUMIGYVJ5KpZ7t04miJvWeeQHD5ijD-WVG6uuxVtNmmcrLzSUhIp00NHC_
b79rVXF6AhU6T7UBiULnjVDGiRJ7YUWPRqu65zCEHt_lNT29pLv9LS2_UmdA0e3Iq4NCsjdsAn1TVwF-MJnEShsYEuUWoGY__8y0Ak8Wmkjw_
cqo0PaG4HegQqX8LXO-yKx-BK2kWREXKR6V4nUm3j9ywMhvZe2hLnJxpeVa66GKov8HEaRN83jkB3dOzTp6lfpjmmxi2P-TRvcpyX3XTVSx4OzhYUz7sSZFOrcv79c1-
kioH1h1Xwgt_JNeKENjC3tB760EqrzXBdIKdXA1B-rDETRQMSxNngcsmpbOCImEoQ1Z2qMhh1gIi8rAvDNxNxwWZShXuTdFEgdg5WmL_pg0CD4vi4hhZdWGhs84WgcRyp7-
kmno9-OW18wXumAIcLHuMzqs9GI0D-OQCmdRDZEl8DcRbQ77qdZHvWqJ4BhB1WL8hzAm5PS1R1KOOGaI85DU46eVOJeVnxWcIlcSAU95qS1eoI6N3xO5Q4y1n5mI0tr-
FbNOxh7plJ-3FzR47WLUwKUVIGbAgd1yWyCVQQ7WvLsxp0K2O65IUGFvfinkVb_xpZWndtNrNm5o-
sErbmQt8ayXAkUCJYXiv2gCkeKOeKosHrWkOR9PSxAGZCn3bu85IU9KsJ48cNGcUGN9gK1g9BtqkeOvAYQEqN96os4gp8hAGrB6gxZxjfX1j5PRBvSbuDCBviY7FBRZwUppf6SmB-
spWxL291196EAyBXs8KWE7Id4k7Cs5KeUgpHBnWzesJrvAOi3zLK7WACnR_Rr93wkSuTINBM8SNiaAAXWKoxeRSr5KjkWMgUnAku2Vtucd-qQh9W2gVxZsDq9hFj61d98_zyb9_
78AxnNzkvueZCr3YxcSj5QvhFk_QBra7K00GqJFibKuJ7Jo5aq7wwQ48XWj2-T6Vmwg9VoudqPig_AyctcZskLy0v4_5X6R6BYibU0Z79JhsCjW1Lodsz8H7qMWpRqQH-XoTMIgjRIYakWGLGeIHvs4dY8JkqSUjPzKycLiq9Dx_
l78EgHJnJB5DGpCeUBEu1EgDd3IfrsLAmG2L6_hbkuXO81h7JuiQEILPVdFMTHRb0TcuWnA-OCKXHA_SHPYQXlogaXUVOodrlm5iiyymwa8mbywxYbbYEAFnDICf7a1773Eb3RpDHMpf2Jp5klt2c1371cziUQpC2tme1I30GaxL_
XxW1a8Zhcy6XP6_Pq5sawskKfOiwbY1jmGnZ7XbghyKj9LkPyAmqc8CMb6bUF66vA8XpQgk_9rlATy7mj_Is45ZX5CwrA_bhRXZ7OwKyyGdmu1937Yn5ECwyZtdoqf9rwzF_Genfkto&state=d7d08f6d3d2445bdae783bb4a05ccd1e
VS  the code that is sent to the client:
client_id: *****
code: CfDJ8Jx_1V6EPfVPgt__3-zVrP5Ko1qpp7LDFw38HQx5R1POtqHe98kPWod1UoinCn1rc-YIucn8ys7hBdQSHzEZHcIcOCBSr9Np02UU6Jv9L8jDx_
gZiNtyic5smJ9O6EGaYMBokJlXVkx_lQHLr3LnuEr4p11Dd6gG-P1HeH3XafhGI4BM1Y7RGFtmTmdHpaMSELplo38sNOAApKH6wPXlV6HGRCj_
9Z9QBhENp0p9epwAse6Th03zPG9bmx9-Qc3aoUxhGiS03EmBiZ6OuNakq83H0-nR76-mwgpEwZDusdFaoHb93tGXz-jtYqFgRLYXODnO3tX8bNOCktidmOLT0jBUMw_
gUq3uhq-pcJOg-FeG_Xj2XEXF_3pEgtBrBGDlrU_FjPGsXdYbOkQgQZ8RF4k9zncMGPyOnCXempNpWsj_eSyzulwuaqNqTb53PEWJeMAqinW3Bfao-Lf5NhO3V2GEg-in_
KQ-CUvOU_ncGpf_byqYauXgtH-Rx4YT0s3LIXES2WwyRDJzSRjjPZuECVfky4-9uI81Mi9iq8pgnyy45OR18TkmoTAawxmbR4o3LOiW_BZESithhEdomMjvCqxX_
5wKj6vPnRvmbhkI-wQAx04taFD-aEbMMzgKapN_X1olhZxpQ0Fdzfp_dZViLyWoMwE6JWkiVLDCYlDajayQmsiPVY2u_U17dhNG39GrpNkHZddsxAf52RvaWDSQfUkv9dabkx6vSuU0ZBkz19-
p0hq_AhR6I5Jn-TMAU-wNoA7RnrbWXDp-NrB5DpAoSjju9GEor4qikAn0PJQ0x6ykqUMIGYVJ5KpZ7t04miJvWeeQHD5ijD-WVG6uuxVtNmmcrLzSUhIp00NHC_
b79rVXF6AhU6T7UBiULnjVDGiRJ7YUWPRqu65zCEHt_lNT29pLv9LS2_UmdA0e3Iq4NCsjdsAn1TVwF-MJnEShsYEuUWoGY__8y0Ak8Wmkjw_
cqo0PaG4HegQqX8LXO-yKx-BK2kWREXKR6V4nUm3j9ywMhvZe2hLnJxpeVa66GKov8HEaRN83jkB3dOzTp6lfpjmmxi2P-TRvcpyX3XTVSx4OzhYUz7sSZFOrcv79c1-
kioH1h1Xwgt_JNeKENjC3tB760EqrzXBdIKdXA1B-rDETRQMSxNngcsmpbOCImEoQ1Z2qMhh1gIi8rAvDNxNxwWZShXuTdFEgdg5WmL_pg0CD4vi4hhZdWGhs84WgcRyp7-
kmno9-OW18wXumAIcLHuMzqs9GI0D-OQCmdRDZEl8DcRbQ77qdZHvWqJ4BhB1WL8hzAm5PS1R1KOOGaI85DU46eVOJeVnxWcIlcSAU95qS1eoI6N3xO5Q4y1n5mI0tr-
FbNOxh7plJ-3FzR47WLUwKUVIGbAgd1yWyCVQQ7WvLsxp0K2O65IUGFvfinkVb_xpZWndtNrNm5o-
sErbmQt8ayXAkUCJYXiv2gCkeKOeKosHrWkOR9PSxAGZCn3bu85IU9KsJ48cNGcUGN9gK1g9BtqkeOvAYQEqN96os4gp8hAGrB6gxZxjfX1j5PRBvSbuDCBviY7FBRZwUppf6SmB-
spWxL291196EAyBXs8KWE7Id4k7Cs5KeUgpHBnWzesJrvAOi3zLK7WACnR_Rr93wkSuTINBM8SNiaAAXWKoxeRSr5KjkWMgUnAku2Vtucd-qQh9W2gVxZsDq9hFj61d98_zyb9_
78AxnNzkvueZCr3YxcSj5QvhFk_QBra7K00GqJFibKuJ7Jo5aq7wwQ48XWj2-T6Vmwg9VoudqPig_AyctcZskLy0v4_5X6R6BYibU0Z79JhsCjW1Lodsz8H7qMWpRqQH-XoTMIgjRIYakWGLGeIHvs4dY8JkqSUjPzKycLiq9Dx_
l78EgHJnJB5DGpCeUBEu1EgDd3IfrsLAmG2L6_hbkuXO81h7JuiQEILPVdFMTHRb0TcuWnA-OCKXHA_SHPYQXlogaXUVOodrlm5iiyymwa8mbywxYbbYEAFnDICf7a1773Eb3RpDHMpf2Jp5klt2c1371cziUQpC2tme1I30GaxL_
XxW1a8Zhcy6XP6_Pq5sawskKfOiwbY1jmGnZ7XbghyKj9LkPyAmqc8CMb6bUF66vA8XpQgk_9rlATy7mj_Is45ZX5CwrA_bhRXZ7OwKyyGdmu1937Yn5ECwyZtdoqf9rwzF_Genfkto
redirect_uri: http://localhost:4200/signin-callback
code_verifier:*******
grant_type: authorization_code

Yea, URLs or proxies sometimes limit URL length. Nothing this library can do about that.

Is there a way to set the code expiration time? I think the code expired hence it throws that error

How did you fix this issue?

I have closed the issue because of the this comment: "Yea, URLs or proxies sometimes limit URL length. Nothing this library can do about that."
Actually I found out that the issue is not because the code is getting discarded, the library removes the state when sending back to the server which works fine on localhost but as soon as I point to https on the test server then thats when it works and sometimes it does not work.
My solution:
I ended up implementing the token flow which I'm not happy with because is not as secured as code flow

Thank you for responding!

Actually I found out that the issue is not because the code is getting discarded, the library removes the state when sending back to the server which works fine on localhost but as soon as I point to https on the test server then thats when it works and sometimes it does not work.

Well, there must be a reason the state is not being accessed properly. Is it possible that user starts on http but ends up on https on the callback? That's a common mistake.

Do you know where I could specifically check for this in the related question https://github.com/IdentityModel/oidc-client-js/issues/1325?

@benitazz Can you share the configuration on the IDP and client for the token flow? With "Token Flow" do you mean implicit flow?

Yes, I mean the implicit flow. Below is my configuration for Implicit flow:
const stsSettings = {
authority: ${this.ssoissuer}/auth,
client_id: environment.ssoclientid,
redirect_uri: ${this.host}/signin-callback,
scope: 'oidc account email profile offline_access api',
response_type: 'token',
post_logout_redirect_uri: ${this.host}/signout-callback,
oidc: true,
};
But this does not work if I put the openid on the scope, its start asking about nonce and error after error.

This is the IDP that is working and sometimes it does not work:
const stsSettings = {
authority: ${this.ssoissuer}/auth,
client_id: environment.ssoclientid,
redirect_uri: ${this.host}/signin-callback,
scope: 'openid email profile offline_access api',
response_type: 'code',
post_logout_redirect_uri: ${this.host}/signout-callback,
oidc: true,
};

I have same issue. I have a 50% signinRedirectCallback success and 50% failed.

error on server


move autobind and debouncePromise to common/utils

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>This is a good bit of moving of code because currently it is not possible to use either of those from either common or main since it brings in an implicit import of navigator which is a renderer only variable.
These also feel like they should be in common since there is nothing renderer specific in their details.

because currently it is not possible to use either of those from either common or main since it brings in an implicit import of navigator which is a renderer only variable.

Actually it is possible to import required file directly (common <-> renderer)
// e.g.: from base-store.ts
import { autobind } from "../renderer/utils/autobind"

We should avoid importing stuff from renderer on main process.


Chaper4 (WebApp)Should I copy these files inside the Ubuntu distro?

in order to run the Web-App Chapter-4, should I copy these files inside Ubuntu? or it's unnecessary.

Hi @jhorgint,
The .ps1 file is example PowerShell commands from the chapter and designed to be run from PowerShell in Windows. The web-app folder is intended to be run from WSL.
Hope that helps!
Stuart

Hi @jhorgint,
The .ps1 file is example PowerShell commands from the chapter and designed to be run from PowerShell in Windows. The web-app folder is intended to be run from WSL.
Hope that helps!
Stuart

Thanks Stuart. I have finally gotten it running.
using PowerShell and this command "Bash run.sh"
PS C:\web-app> Bash run.sh


Support for viewportCategory option

Add to all viewports a category to group them by device type, for example "tablet" for tablets, "smartphone" for smartphones and so on and add an option to the script for choosing to capture all viewports by category name.
This can be really useful since there are a ton of devices and manually do all mobile, let say, it will take time to find all the viewport key names.

https://github.com/mozilla/simulated-devices/blob/master/devices.json

For now this option is available only in the cli mode.


TH_STORAGE_VIEW undeclared

I just did a fresh install on a fresh EC2 instance (Ubuntu 14.04) of Torch and cutorch.  I used luarocks to install cutorch, but got this error during build:
Building C object CMakeFiles/cutorch.dir/TensorOperator.c.o
In file included from /vol/cutorch/Storage.c:32:0:
/vol/cutorch/torch/generic/Storage.c: In function ‘torch_CudaStorage_new’:
/vol/cutorch/torch/generic/Storage.c:46:45: error: ‘TH_STORAGE_VIEW’ undeclared (first use in this function)
     storage->flag = TH_STORAGE_REFCOUNTED | TH_STORAGE_VIEW;
                                             ^
/vol/cutorch/torch/generic/Storage.c:46:45: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [CMakeFiles/cutorch.dir/Storage.c.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/cutorch.dir/all] Error 2
make: *** [all] Error 2

It looks like the line throwing that error is new, appearing in this commit not too long ago: https://github.com/torch/cutorch/commit/a15d6be4eca74492b628c2ba3a65c4016f729c69#diff-b021d3ea3c9c9ad4df92e6421010ca1bR46
Probably an untested merge, unless I made a mistake during installation.
After working around the issue by changing TH_STORAGE_VIEW to 8, build passes and seems to work, so that appears to be the only bug introduced.

hey @fpgaminer , the cutorch commit required an updated torch as well.
if you do:
luarocks install torch
luarocks install cutorch
you'll be all set.

the default torch distro install installs last known stable commits. however when you did "luarocks install cutorch", you installed the latest HEAD of cutorch, rather than the last stable commit that was recorded in distro: https://github.com/torch/distro/tree/master/extra

Okay, good to know it was an issue on my end.  Is there a better way of installing torch + cutorch, etc. to bring a fresh machine up?  I, naturally, just followed the instructions given by Torch to install torch, and then assumed luarocks install cutorch was the next sensible step.

the default torch install comes with cutorch and all other essential cuda packages. https://github.com/torch/distro/blob/master/install.sh#L84

Okay, thank you for the help, and sorry for the false issue.


Writing mistake in the title in rating (UA language)

In Ukrainian "Ющенка" should be here.

https://github.com/opengs/uashield/blob/18301f3750c0f11c5a63e68d6ba0eeb3a29dbc8c/src/i18n/ua-ua/index.ts#L128
Send a PR? 🤔
I dont know the language....

https://github.com/opengs/uashield/blob/18301f3750c0f11c5a63e68d6ba0eeb3a29dbc8c/src/i18n/ua-ua/index.ts#L128
It should be:
5: 'Бджоли Ющенка',
Just the very last letter is 'а'

cool issue :D I will fix this in next release

Fixed in 1.0.10


StringField.cs  IIdField NotImplementedException

IIdField.this[Row row] throws a NotImplementedException in StringField.cs file. What will be the future implementation of this property?. For now, I know IIdField supports Int16, Int32 and Int64 but there is an issue with JavaScript and big numbers. In my case I was able to use string as PrimaryKey (to handle long values)   but I had to change the property as follow:
from:
     long? IIdField.this[Row row]
        {
            get
            {
                throw new NotImplementedException();
            }

            set
            {
                 throw new NotImplementedException();
            }
        }

to this
long? IIdField.this[Row row]
        {
            get
            {
                CheckUnassignedRead(row);
                string numString = _getValue(row);
                long longToBeReturned = 0;
                bool canConvert = long.TryParse(numString, out longToBeReturned);
                if (canConvert == true)
                    return longToBeReturned;
                else
                    throw new InvalidCastException($"value {numString} is not numeric!.");
            }
            set
            {
                _setValue(row, value.ToString());
                if (row.tracking)
                    row.FieldAssignedValue(this);

            }
        }

Don't change anything, it's just a backward compatibility placeholder and many use non integer fields as ID.

Thank you. I created my own "FieldType" inheriting from StringField while implementin IIdfield interface and created my own SaveRequestHandler. Now my primary key is a string holding this big numbers that are computed server side. I am just pointing out that when you have a primary key Int64? once you get to certain point it will stop working. You can try that in your Serene application reseeding the identity value of any table to very large number still valid for and int64 while Serenity is returning the correct value in the response object from the repository/Service the value will be rounded/truncated to the significant digits of JavaScript "number" datatype.

Thanks, as i said in another issue using StringEditor for those id fields should help.


docs: add Traditional Chinese language docs

Description
Add Traditional Chinese language documents
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[ ] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[ ] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Thank you @ninthday !


feat(module:anchor): url fragment change on click - nzReplace

PR Checklist
Please check if your PR fulfills the following requirements:

[✔] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[✔] Tests for the changes have been added (for bug fixes / features)
[✔] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Unlike Ant's Anchor, click on an anchor's link does'nt update the fragment of the current URL.
We lack the replace option that Ant provides.

What is the new behavior?

In contrast to the Ant's Anchor, the URL fragment now updates accordingly when an anchor link is activated.
The addition of nzReplace provides an option that, when enabled, replaces the current history state without adding a new state to the browser's history stack.

Does this PR introduce a breaking change?
[ ] Yes
[✔] No

Other information

unit tests failed with error, please solve this issue first @ParsaArvanehPA
anchor property (nzChange) should emit nzChange when scrolling to the anchor

unit tests failed with error, please solve this issue first @ParsaArvanehPA
anchor property (nzChange) should emit nzChange when scrolling to the anchor

@ParsaArvanehPA  I had tried to fix this CI issue, but all my efforts didn't work.
Your previous workaround which is to multiply the throttleTime by 20 FAILs.
We should make it passed in a right way. Please take a look.

unit tests failed with error, please solve this issue first @ParsaArvanehPA
anchor property (nzChange) should emit nzChange when scrolling to the anchor

@ParsaArvanehPA I had tried to fix this CI issue, but all my efforts didn't work.
Your previous workaround which is to multiply the throttleTime by 20 FAILs. We should make it passed in a right way. Please take a look.

Thanks @Laffery
I'm on it 👍


"tagged template literals" link in docs is broken

Issue Type

[X ] Bug (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#bug-reports)
[ ] Feature (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description
The "tagged template literals" link directs to https://github.com/styled-components/styled-components/blob/master/docs/tagged-template-literals.md, but that page says that the documentation has been moved to styled-components.com
Steps to reproduce

Go to the docs page (https://github.com/react-boilerplate/react-boilerplate/tree/master/docs)
Click the link that says "tagged template literals"

Versions
N/A

@joncass Could you send a PR?

@KarandikarMihir I submitted a PR (#1824). I'm very new to this, so if I did something wrong please let me know and I can try to fix it. Thanks!

@joncass Thank you for your contribution!! Great job if this was your first PR 😃 Merged #1824. Hence closing.


Footer changes

Requirements
As we are migrating our www site to Ember.js we need to sync our migrated site with the current version that is running on prod to be able to migrate it to Ember.js.
In this ticket we have to make the UI of footer same as in production(vanilla site).
Screenshots
In vanilla site

In beta site(ember migrated site)

Important links
https://beta.realdevsquad.com/ (This one is made with Ember js)
https://www.realdevsquad.com/ (This one is the production site)
Additional Notes

Design should be same as in prod.
Take reference from the prod site wherever needed.
It should be responsive.
Code quality should be maintained.

I will complete this task.
ETA: 23rd Oct

Design Doc: Google Docs Link

closed via #713


Update code blocks in Chapter 6 of the tutorial to fix error

For the types in args there was schema.<type> in all the blocks of code which raises an error. However it should be stringArg and intArg rather than schema.stringArg and schema.intArg

Thanks!


Design issue: the text "Filters" and the selected filters are not aligned

The "filters" label is a h3. H3 now have a global style of @apply mb-2; If you remove this the global styles are correct.


Architecture Typo in Python Environment Manager

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.63.0
OS Version: Xubuntu 20.04.3

Steps to Reproduce:

Typo in architecture. Its currently Archictecture.

/extPython


get_account_history doesn't include upvotes anymore

Expected behavior
Until yesterday, the api call get_account_history() returned the latest rewards and upvotes an account has received.
Actual behavior
The upvotes are no longer returned by this api call
How to reproduce
https://api.steemjs.com/get_account_history?account=penguinpablo&from=-1&limit=10
Using this URL only my latest curation rewards and author rewards are returned. My upvotes are not listed anymore.

This issue has been fixed.


Fix Select behavior when multi is false

This commit addresses @tschaub's comment in #3402.

Looks great @elemoine.  Thanks for the work on this.


Chrome/Chromium failing launch periodically when using --no-sandbox

Puppeteer version: 1.19.0
Platform / OS version: ubuntu:latest running within Google Cloud k8s
URLs (if applicable):
Node.js version: 10.15.3

We are running puppeteer within a kubernetes cluster on google cloud (100 node daemonset so its equivalent to 100 instances). We are periodically seeing errors in the logs where puppeteer is not able to start chrome. Note, this is happening both with Chrome & Chromium that is bundled with puppeteer.
The error returned reads:

[0727/185924.644612:ERROR:nacl_helper_linux.cc(310)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly

Here is a snippet that launches the browser:
        executablePath: 'google-chrome',
        args: [
            '--no-first-run',
            '--no-sandbox',
            '--disable-setuid-sandbox',
            '--disable-dev-shm-usage',
            '--ignore-certificate-errors',
            '--ignore-urlfetcher-cert-requests',
            '--proxy-server=http://our-proxy'],
        ignoreHTTPSErrors: true,
        headless: false,
        userDataDir: process.env.TMP_PROFILE_DIR,
        defaultViewport: null
    });

    const page = await browser.newPage();
    page.setDefaultTimeout(120000);
    page.setDefaultNavigationTimeout(120000);

Our containers entry point looks like:
#!/bin/bash

/etc/init.d/dbus start
sleep 1s

export DISPLAY=:1
export TMP_PROFILE_DIR=$(mktemp -d -t puppeteer.XXXXXXXXXX)

Xvfb :1 -screen 0 1440x900x24 &
sleep 3s

node app.js

Anyone have any debugging tips to figure out what is going on? Why would only some requests fail to start the browser?

Scratch that, going to close and discuss at stackoverlow

@jredl-va please did you get a solution to this?
Maybe you could share a link to the Stackoverflow discussion.
Thanks


Scheduling OBPS research/testing sessions

####Goal of Ticket
Plan logistics of OBPS reporting research and registration usability sessions.
Describe the task
Have a plan to manage logistics for OBPS research/testing.
Acceptance Criteria

[ ] Create tracking spreadsheet
[ ] Contact identified operator staff to recruit
[ ] Schedule & track sessions as they are booked

Additional context

Add any other context about the task here.
Definition of Ready
Note: If any of the points are not applicable: delete or mark N/A
[ ] Topic is clearly Defined.
[ ] Task Description is Clear.
[ ] People to speak to are identified (if applicable).
[ ] Acceptance Criteria is Clear.
[ ] Ticket Title is Clear.
[ ] Ticket is reasonably Split up/sized.
[ ] Value/Pain is Clear.
[ ] Relevant Team Members are assigned.
[ ] Ticket Estimated.

Definition of Done.
Note: If any of the points are not applicable: delete or mark N/A

[ ] Rough User Stories Proposed.
[ ] Follow-up Tickets created (if necessary).
[ ] Findings are documented (if necessary).
[ ] Reference docs/spreadsheets identified and indexed.
[ ] Value Proposition Canvas (if required)

Hey team! Please add your planning poker estimate with Zenhub @jaimiebutton @nanyangpro @NicoleGovvy


removed version changes descriptions in method docstrings

removed version changes for each method in the docstrings for clarity and readability.

This is a good idea to improve readability of the code and in general make the code easier to understand for a beginner, but it is a rather huge compromise for long time developers of the code. I would suggest making a designated area in the file either at the beginning or at the end to include the version history and a summary of the changes made.

@dharvpat @umichAxelintheloop In that case do I just keep it as is and reject the new changes? I am not sure about placing them in the beginning or the end of the python file because each version change comment that I removed was placed on top of the function that was affected by the change. Do I just reject it ?


add onion protocol

from @arj03

question, @arj03 the "port is not optional" port is the remote port?

This looks pretty right, but it means to create a server I have to manually update the tor config for my hidden service, right? I think that's fine for now, but needs some documentation, at least so that I can test it.

merged into 1.3.0, so we can get going, but we should probably not hardcode the tor port.

oh, just realized this isn't right at all.
tor uses a socks5 proxy, and tproxy is not that.
https://github.com/AjayMT/tproxy/blob/master/index.js
try this module instead https://github.com/sequoiar/socks5
I don't think we need a server adapter for this protocol yet,
because if you configure tor to proxy your local sbot port,
then the net server will just expose over tor.
later, we can set up a separate server, that say, rejects connections that didn't come through tor.
then if you wish to run ssb over tor only you can do that.

sorry, that module only implements the server,
this one implements the client:
https://github.com/JoshGlazebrook/socks

Alright. I'll whip up a new patch.
Again can't thank you enough for helping me scratch my itch. The next pull request won't be done before I have a connection working ;)


Test: Fix part visible

I hereby agree to the terms of the CLA available at: [placeholder]
Changelog category (leave one):

New Feature
Bug Fix
Improvement
Performance Improvement
Backward Incompatible Change
Build/Testing/Packaging Improvement
Documentation (changelog entry is not required)
Other
Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
...
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ByConity Documentation guide first.

Close first, need to think more about this changes


Stream Enrich: support private Kinesis endpoints

Project:  Stream Enrich
Version: 0.21.0
Error: Received error response: com.amazonaws.services.kinesis.model.AmazonKinesisException: Credential should be scoped to a valid region, not ‘vpce’ (Service: AmazonKinesis; Status Code: 400; Error Code: InvalidSignatureException.
Debug logs shows that credentialscope for AWS4 Canonical Request coming as 20190611/vpce/kinesis/aws4_request.  This is coming for only enricher not for collector.
Steps to reproduce:
Providing customendpoint as private kinesis endpoint
customEndpoint = vpce-XXXXXXXXXXX-XXXXXXXXXXX.kinesis.eu-west-1.vpce.amazonaws.com
More Info.
https://discourse.snowplowanalytics.com/t/snowplow-enrcihment-not-working-for-private-kinesis-endpoints/2923

Migrated to https://github.com/snowplow/enrich/issues/39


Remove deprecated rbenv-gem-rehash

The formula for rbenv-gem-rehash has been deprecated and removed from brew. This functionality is now baked into rbenv core and the plugin is no longer necessary.
The repository
The pull request removing it from brew

Haha, duplicate of #83. Closing.


Conflict with Symfony\var-dumper

Due to changed function naming from the original in this updated fork I'm getting the following error:
PHP Fatal error:  Cannot redeclare dump() (previously declared in vendor\symfony\var-dumper\Resources\functions\dump.php:18) in vendor\horizom\var-dumper\src\helpers.php on line 11

Good ! Any suggestions for function naming are welcome.

Personally I had trouble with the original functions r()and rt().

Perhaps dv / dvt?

Why not dumper() / dumper_text()  or debug() / debug_text()
In order not to procrastinate too much, we will remember the choice you will make.

rt() was ok

rt() was ok

Is this still going to be changed?

Is this another abandoned fork? lol
Problem 1
    - codeception/codeception[5.0.8, ..., 5.0.11] require symfony/var-dumper >=4.4.24 < 7.0 -> satisfiable by symfony/var-dumper[v4.4.25, ..., v4.4.47, v5.0.0, ..., v5.4.28, v6.0.0, ..., v6.3.4].
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v6.3.4.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v6.3.2.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v6.2.10.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v6.0.19.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v5.4.28.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v5.4.23.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v5.3.3.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v4.4.47.
    - horizom/var-dumper 3.1.3 conflicts with symfony/var-dumper v4.4.26.
    - codeception/codeception[5.0.0, ..., 5.0.6] require phpunit/phpunit ^9.5 -> found phpunit/phpunit[9.5.0, ..., 9.6.13] but it conflicts with your root composer.json require (^10).
    - codeception/codeception 5.0.7 requires phpunit/phpunit ^9.5.20 -> found phpunit/phpunit[9.5.20, ..., 9.6.13] but it conflicts with your root composer.json require (^10).
    - symfony/var-dumper[v5.0.0, ..., v5.0.8] require php ^7.2.5 -> your php version (8.2.10) does not satisfy that requirement.
    - Root composer.json requires horizom/var-dumper ^3.1.3 -> satisfiable by horizom/var-dumper[3.1.3].
    - Root composer.json requires codeception/codeception ^5.0 -> satisfiable by codeception/codeception[5.0.0, ..., 5.0.11].


Update README and test Code from different Directiorys

Maybe do this before or after fixing #21 Issue.
The Goal is: Making the Code available for other groups
Subgoal: Writing an easy to understand README on "How to move an object". Writing a code Snipped which will just work.

Test this with a main.py located under the PythonScripts-Folder. Should work with only around ~5 lines of code.
Then Test the main.py in subdirectorys like PythonScripts/Perception.
Make this snippet available in the readme

There might occure import problems and such. -> Write a new issue on GitHub accordingly
For example:
https://github.com/alpakadev/robot-ludens/blob/c9d43fdf4dfb0b65ef0a4ad008bbf74195e35577/PythonScripts/Movement/robot_movement.py#L1-L2
The import of constants.py might need to be changed to a relative path so that import problems are prevented. (Read up on this in Pyhon Project Tutorials)
Might look like this: (notice the dot)
from .constants import DELTA_GRIP_OBJ, DELTA_ABOVE_OBJ

Alternativly this will also work
from . import constants


Feature Request - Explicitly overwrite existing files

Greetings,
I have been enjoying the extension very much. Thank you. After about a week of using it I think it satisfies almost all my development needs. I just have a feature request around overwriting existing files.
Currently, the control flow identifies if a file already exists and omits from creating it (again). It then notifies the user of said file not being generated. This is all great and I'm sure has saved a ton of trouble by accidentally overwriting something. But may I propose some alternates to give some flexibility to end-users here?

Add an option to allow only overwriting if the file is tracked (the workspace has an active git init and the file is not ignored)
Add an option to allow overwrite in specific globs (i.e., **/tests/**) [I would recommend something like node-glob]
Add an option to allow overwrite for a specific filename or extension
Add an option to allow overwrite based on language specific configurations reference
Or possibly consider 'merging files' - this would be complicated, but if you keep the scope of what can be merged it may relieve a lot of technical debt.

It might be beneficial to consider adding this functionality to ftsettings.json files so it's project scoped, but I think, or I'm assuming, these would really be one-time configurations yeah? I think people would just add it to user-settings, but that's just food for thought.
I wouldn't recommend an option to always overwrite, but that's your call obviously. I think the key here is just flexibility being sufficient. And I think the proposed options are future proof that wouldn't require much maintenance in the future, but I would love to see what others contribute in that regard.
My use-case is that I have an extension that automatically generates a project-based .vscode/settings.json file every folder that is opened, for other reasons beyond the scope of this extension (like setting up envs).
Using this extension in tandem sort of complicates that pattern. For example, if you were to create a folder structure specifically targeting typescript and you include a .vscode/settings.json file in that template with language-specific settings or a setting to exclude javascript files from search and the explorer, it wouldn't be applied with the template if it already exists. These aren't settings I need in every project, obviously if I'm doing something in python,  just for example.
This would work great, but since I have another extension that automatically creates a settings file at launch for other reasons, this extension identifies it as existing and omits it. And as far as I know, you can't alter the order of loading extensions.
FYI, I understand having more settings than you need doesn't hurt you, I just share a lot of my settings with projects with other people or when I upload something to github, so they have what I have. Easier for troubleshooting etc, so keeping them relative just makes it easier to find, clutter-free and respective.
Any thoughts on this?

Moin,
I think making the overwriting of files customizable is a very good idea.
But I'm thinking more along the lines of a simple new property in the settings of a structure.
"overwriteExistingFiles":  "never" | "always" | "prompt"

where never (default) would not overwrite existing files. always would overwrite them.
If the value is prompt the extension would show a list of files that would potentially be overwritten. You would then check or uncheck every file in the list to mark it to be overwritten or not.
I think that should satisfy all usecases. There might be structures where you're sure you want to overwrite all files. Sometimes you might want to choose if you want to overwrite any. And with most structures you don't want to overwrite any files.
I personally think this is overkill but one could take it up a notch and even go with something like this
overwriteExistingFiles: {
".json": "always",
".jsx": "prompt"
}

But I'd really not like to go so indepth with this. It's overcomplicating things. At least in my personal opinion.

But I'm thinking more along the lines of a simple new property in the settings of a structure.
"overwriteExistingFiles":  "never" | "always" | "prompt"

where never (default) would not overwrite existing files. always would overwrite them.

That's a great approach I think!
Although I think node-globs idea can come in handy personally! It's very lightweight and that package is super simple to incorporate. Maybe consider it, but overall I think what you have mentioned will help a ton! I didn't know you could prompt for a user-defined list of choices. I just learned something, though to be fair I don't read through the API too often! I am just a fan of not using my mouse unless I absolutely need to, but I understand the world can't revolve around me!
I think in your approach, it would make sense to add it to ftsettings files too, since users may want a template structure that automatically overwrites in one scenario but not another.
Thanks for the discussion on this! Sounds great

Thanks @Huuums can't wait to use this bad boy! This may be my fault for not reviewing, but the schema validation files can't be found. I didn't think to check your vscodeginore file but it appears it's being ignored from the deployment package: https://github.com/Huuums/vscode-folder-templates/blob/43a2d44fdbd64a2d441e801eada80aa8ddd1573d/.vscodeignore#L4
since they reside in src/schemas
easy fix though! just filling you in. Thanks for the quick turn around on this. I appreciate it

Thanks for the pointer. Fixed it just now


Exclude unused Dependencies in Lambda Layer

Hi Team, since introducing the optional dependencies for some packages eg pyarrow etc. , when using the lambda layer, is it possible to exclude them from the unzipped lambda size check? Or will they always be included?

Most dependencies are included in the lambda layer. Removing dependencies that are now optional would be a breaking change for users who upgrade to a new version of the layer. We also wouldn't know which dependencies to remove as each user considers some of them optional but not others


allow use of dynamic custom classes on tags

This should resolve #273 in a more generic way. Allowing more then just the colors to be changed.

Coverage remained the same at 100.0% when pulling e8795e0005e745ee7300a3dae82443be3ce889eb on stijnbe:custom-tag-class into 5ecd0d4d7146428699f5cacec1f614b4995663b2 on mbenford:master.

Coverage remained the same at 100.0% when pulling 8dc86513e8ad923e11d79326bee6de7fb5af997e on stijnbe:custom-tag-class into 5ecd0d4d7146428699f5cacec1f614b4995663b2 on mbenford:master.

+1 this would be awesome

Any estimated date when this will be included in the release?

@mbenford Can you please have a look at this merge request.


Fix zip file download when using an external storage service

Instead of accessing the file directly (which works locally) the attachments get downloaded from the external service (currently Azure) to a temp file and then added to the zip file.
Context

Changes proposed in this pull request

Guidance to review

Link to Trello card
https://trello.com/c/9LhoQTjO/1162-bug-zip-file-file-export-on-azure
Checklist

[ ] Attach to Trello card
[ ] Rebased main
[ ] Cleaned commit history
[ ] Tested by running locally

 [BUG] Zip file file export on Azure


fix(ionic-framework-training): Apply minor fixes to Step 5

Minor readability updates and spelling checks
Added a link to the ionic cordova resources command doc

I see you have picked up on the subject convention for the commits. Just in case you were wondering, that comes from here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit


Edits to the README, for clarity

Some minor edits to the README, made as I read through the information for the first time.

Thanks for the PR! 👍

Thanks @gemmakbarlow 👍