isPurchased with subscriptions

Hi,
I wanted to ask/suggest what happens to the function isPurchased when dealing with a subscription that may be cancelled or/and expired. The desirable behaviour is that isPurchased would return true when the subscription is autorenewing normally, or when it has been cancelled but still hasn't reached it's expiration date. And false otherwise, that is to say, when the subscribed content should be no longer available to the user. I haven't seen any status confirmation in the function, so I assume it returns true if it has been purchased at any time, even if it has been cancelled and expired.
Am I correct? If I am, what would be an optimal way to check this circumstance? The idea is to have a function that returns true if the user should have access to that premium content and false otherwise.
Thank you.

Hi,
Sorry for the delay in getting back to you. I just ran a few tests to check that StoreHelper behaves in the way you suggest, which I agree is the correct behaviour.
Using the StoreHelperDemo app I did the following (I set the renewal rate in Xcode to be 5 minutes):

With no products subscribed to
isPurchased = false for all subscription products

Subscribed to the "Silver" product
isPurchased = true for the "Silver" product

Cancelled the subscription to the "Silver" product
isPurchased = true for the "Silver" product

Repeated step 3 while the subscription was still valid (before it expired)
isPurchased = true for the "Silver" product

When the subscription for the "Silver" product had expired
isPurchased = false for the "Silver" product

So, it looks like everything is working as expected from my (limited) testing.
Hope this helps. If anything's unclear let me know!

Great! That's nice and very comfortable. I guess StoreKit removes the transaction when it expires or revokes the verification. Good to know! Thanks!


getZoom() after passing zoom options in panTo not working fix

map.panTo([50, 30], {zoom: 15});
map.getZoom();

The output was NaN.
It will result in 15 as of now.
Hope this PR helps.

The panTo options do not include zoom. This is documented. Users setting the map center and zoom at the same time should be using the setView method already.


VCC to GSR hack

Connect the VCC to the GSR input directly in the template and remove the
ability to use these pips for routing.
Signed-off-by: YRabbit<EMAIL_ADDRESS>

So far I have only checked for the GW1N-9C.


Memory percent not calculated : Unknown

Hi,
just running a fresh install of HA and monitor_docker. All sensors are well returned except memory pct which has a value of unknown.
I'm running hass version 0.118.3
Monitor_docker : 1.5
Docker version 19.03.13, build 4484c46
Don't hesitate to request more info if you can't reproduce from your side.

Does "docker stats" show the right information?

you're right, docker stats display 0b / 0b and 0.0% Mem
so I think it's more a docker problem than a plug-in problem !

ok so as you point me to a way to debug, I've been able to debug and resolve the issue.
So for other people in my situation. If you're running docker on a Rasperry Pi 3 ou 4 and memory stats are not displayed, first check this command :
docker info.
you should have the following line : WARNING: No memory limit support
cat /proc/cgroups | column -t
you should get something like this :
#subsys_name  hierarchy  num_cgroups  enabled cpuset        10         10           1 cpu           6          45           1 cpuacct       6          45           1 blkio         4          45           1 memory        8          87          0 devices       9          45           1 freezer       3          10           1 net_cls       5          10           1 perf_event    2          10           1 net_prio      5          10           1 pids          7          49           1
If Memory is 0 enabled you should apply this patch to your /boot/cmdline.txt by adding :
cgroup_memory=1 cgroup_enable=memory
after rebooting you should have memory usage in docker stats


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/104111

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/104371

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/108031

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/112353


[FR] Board JSON to contain BB version it was built with

Essentially for being able to handle compatibility and breaking changes in the future

effectively resolved by https://github.com/breadboard-ai/breadboard/pull/567


Chinese document on "How to: Pad a Number with Leading Zeros"

Hi teams, above captue is chinese explanation for "To display the integer as a hexadecimal value", but now both statement is talking about "Decimal value". It makes people confuse, and I realized this mistake once I switch to English website, then I know the second one is talking about hexadecimal value, not decimal value, please fix.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff5f139b-5e94-9793-5cd1-048a395d026c
Version Independent ID: 474649e3-7f9b-be7b-5e0c-58046c76ee24
Content: How to: Pad a Number with Leading Zeros
Content Source: docs/standard/base-types/how-to-pad-a-number-with-leading-zeros.md
Product: dotnet-fundamentals
GitHub Login: @adegeo
Microsoft Alias: adegeo

Hi @khoiph1 I see you mentioned on issues similar to this, is this something you can handle?

@dankodima1 You should open a new issue. However, I don't understand what you're saying. The documentation for this "how to" is already short.

This issue appears to be fixed: https://learn.microsoft.com/zh-cn/dotnet/standard/base-types/how-to-pad-a-number-with-leading-zeros


Dotty support

This PR includes work from @odersky and @biboudis as well as additional stuff to support cross compilation for both Scala 2.12 and Dotty.
I still have execution errors when running the tests:
Test strawman.collection.test.StrawmanTest.mainTest failed: java.lang.IncompatibleClassChangeError: Conflicting default methods: strawman/collection/SeqLike.coll strawman/collection/Iterable.coll

I updated the build according to @smarter review. Has anyone an idea of what does this error mean?

Probably a bug in dotty


Tablet Ratio Renders Poorly

This should be fixed as the new design has removed the large footer altogether and added a small footer instead.


TPH Inheritance duplicate relationship error

The logical relationship is that one vehicle can have multiple estimates and invoices. Some estimates are converted as invoice while others aren't.
This is my Code First Classes.
    public class Vehicle
    {
        public string Id { get; set; }
        public string Variant { get; set; }
        public DateTime LastServiced { get; set; }
        public virtual List<Estimate> Estimates { get; set; }
        public virtual List<Invoice> Invoices { get; set; }
    }

    internal static partial class UserDbContextBuilder
    {
        internal static void ConfigureTable(EntityTypeBuilder<Vehicle> entity)
        {
            entity.ToTable("Vehicles");

            entity.HasKey(vehicle => vehicle.Id);

            entity.Property(vehicle => vehicle.Id)
                .HasMaxLength(IdMaxLength);

            entity.Property(vehicle => vehicle.Variant)
                .HasMaxLength(DefaultStringMaxLength);
        }

        internal static void ConfigureForeignKeys(EntityTypeBuilder<Vehicle> entity)
        {

        }
    }

    public class Estimate
    {
        public string Id { get; set; }
        public string ReferenceNo { get; set; }
        public DateTime CreatedDate { get; set; }
        public DateTime LastUpdated { get; set; }
        public string VehicleId { get; set; }
        public virtual Vehicle Vehicle { get; set; }
    }

    internal static partial class UserDbContextBuilder
    {
        internal static void ConfigureTable(EntityTypeBuilder<Estimate> entity)
        {
            entity.ToTable("Estimates");

            entity.HasKey(estimate => estimate.Id);

            entity.Property(estimate => estimate.Id)
                .HasMaxLength(IdMaxLength);

            entity.Property(estimate => estimate.VehicleId)
                .IsRequired()
                .HasMaxLength(IdMaxLength);

            entity.Property(estimate => estimate.ReferenceNo)
                .HasMaxLength(DefaultStringMaxLength);
        }

        internal static void ConfigureForeignKeys(EntityTypeBuilder<Estimate> entity)
        {
            entity.HasOne(estimate => estimate.Vehicle)
                .WithMany(vehicle => vehicle.Estimates)
                .HasForeignKey(estimate => estimate.VehicleId)
                .OnDelete(DeleteBehavior.Cascade)
                .HasConstraintName("FK_Estimates_Vehicles");
        }
    }

    public class Invoice : Estimate
    {
        public DateTime InvoiceDate { get; set; }
        public DateTime DueDate { get; set; }

    }

    internal static partial class UserDbContextBuilder
    {
        internal static void ConfigureTable(EntityTypeBuilder<Invoice> entity)
        {
        }

        internal static void ConfigureForeignKeys(EntityTypeBuilder<Invoice> entity)
        {
        }
    }

When I generate the Migration script, I seem to get two references to the table Vehicles. And the script adds a new reference column also. However, when I do a

database update

command, it throws an error stating that the table is referencing the same table twice. I can't execute the script successfully. Can you please help and look at it?
System.InvalidOperationException: Cannot create a relationship between 'Vehicle.Invoices' and 'Estimate.Vehicle', because there already is a relationship between 'Vehicle.Estimates' and 'Estimate.Vehicle'. Navigation properties can only participate in a single relationship.

The migration script it generated shows as follows.
            migrationBuilder.CreateTable(
                name: "Vehicles",
                columns: table => new
                {
                    Id = table.Column<string>(maxLength: 40, nullable: false),
                    LastServiced = table.Column<DateTime>(nullable: false),
                    Variant = table.Column<string>(maxLength: 50, nullable: true)
                },
                constraints: table =>
                {
                    table.PrimaryKey("PK_Vehicles", x => x.Id);
                });

            migrationBuilder.CreateTable(
                name: "Estimates",
                columns: table => new
                {
                    Id = table.Column<string>(maxLength: 40, nullable: false),
                    CreatedDate = table.Column<DateTime>(nullable: false),
                    Discriminator = table.Column<string>(nullable: false),
                    LastUpdated = table.Column<DateTime>(nullable: false),
                    ReferenceNo = table.Column<string>(maxLength: 50, nullable: true),
                    VehicleId = table.Column<string>(maxLength: 40, nullable: false),
                    DueDate = table.Column<DateTime>(nullable: true),
                    InvoiceDate = table.Column<DateTime>(nullable: true),
                    VehicleId1 = table.Column<string>(nullable: true)
                },
                constraints: table =>
                {
                    table.PrimaryKey("PK_Estimates", x => x.Id);
                    table.ForeignKey(
                        name: "FK_Estimates_Vehicles",
                        column: x => x.VehicleId,
                        principalTable: "Vehicles",
                        principalColumn: "Id",
                        onDelete: ReferentialAction.Cascade);
                    table.ForeignKey(
                        name: "FK_Estimates_Vehicles_VehicleId1",
                        column: x => x.VehicleId1,
                        principalTable: "Vehicles",
                        principalColumn: "Id",
                        onDelete: ReferentialAction.Restrict);
                });

Why is it creating a second relationship to the same table instead of filtering the records using the Discriminator column?
Further technical details
"Microsoft.AspNetCore.Identity": "1.1.0",
"Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.1.0",
"Microsoft.EntityFrameworkCore": "1.1.0",
"Microsoft.EntityFrameworkCore.Design": "1.1.0",
"Microsoft.EntityFrameworkCore.SqlServer": "1.1.0",
"NETStandard.Library": "1.6.1"
"Microsoft.EntityFrameworkCore.Tools.DotNet": "1.0.0-preview3-final"

(Total side note, which you can feel free to ignore, but inheritance should be a "is-a" relationship, not a "has-a" relationship. In my mind just because an invoice contains information from an estimate doesn't mean that an invoice is an estimate.)

@jnm2 Could you also share the DbContext? I tried with this one and didn't get any errors:

    public class ServicingContext : DbContext
    {
        public DbSet<Vehicle> Vehicles { get; set; }
        public DbSet<Invoice> Invoices { get; set; }
        public DbSet<Estimate> Estimates { get; set; }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            UserDbContextBuilder.ConfigureTable(modelBuilder.Entity<Estimate>());
            UserDbContextBuilder.ConfigureTable(modelBuilder.Entity<Vehicle>());

            UserDbContextBuilder.ConfigureForeignKeys(modelBuilder.Entity<Estimate>());
        }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer(
                "Data Source=(localdb)\\MSSQLLocalDB;Database=Servicing;Integrated Security=True;Connect Timeout=30");
        }
    }

@AndriySvyryd sorry for interjecting, I think you want @prindacerk

@jnm2 Oops, you are correct.

@jnm2 I know and on actual implementation, both Estimate and Invoice have a base class which they inherit from. However, I noticed this problem when implementing the classes and I wanted to bring it to attention that if the base class has a relationship, then the inheriting class also creates a separate relationship by default which causes conflict.
@AndriySvyryd I assume you were asking me. The project compiles and it even creates a migration. But when you try to implement it into the database, it throws the error I have highlighted above. I have given the migration script it generated in the initial post. Can you compare if yours generated the same way?
Anyway, my DBContext is as follows.
    public class UserDbContext : IdentityDbContext<ApplicationUser>
    {
        public DbSet<Estimate> Estimates { get; set; }
        public DbSet<Invoice> Invoices { get; set; }

        /// <summary>
        /// This constructor is required to pass the connection details to the base class
        /// </summary>
        /// <param name="options">options containing the context connection details</param>
        public UserDbContext(DbContextOptions<UserDbContext> options) : base(options) { }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            base.OnModelCreating(modelBuilder);

            UserDbContextBuilder.ConfigureTable(modelBuilder.Entity<Vehicle>());
            UserDbContextBuilder.ConfigureTable(modelBuilder.Entity<Estimate>());
            UserDbContextBuilder.ConfigureTable(modelBuilder.Entity<Invoice>());

            UserDbContextBuilder.ConfigureForeignKeys(modelBuilder.Entity<Vehicle>());
            UserDbContextBuilder.ConfigureForeignKeys(modelBuilder.Entity<Estimate>());
            UserDbContextBuilder.ConfigureForeignKeys(modelBuilder.Entity<Invoice>());
        }
    }

@prindacerk Even with the provided context I don't see the error. The migration fragment you supplied is the same that I get.
try adding the verbose parameter to see if it gives some useful information:
dotnet ef database update --verbose

Also even though it's unlikely to be cause this issue, update Microsoft.EntityFrameworkCore.Tools.DotNet to 1.1.0-preview4-final

@AndriySvyryd Sorry I missed a step in the error messages I was getting. My bad. I just recreated a new project and added the classes. I get the first error message from the script. Included the verbose and this is the output.
C:\Users\Developer\Documents\Visual Studio 2015\Projects\EntityCoreTest\src\Autolibrary.Domain.User>dotnet ef database update --verb
ose
Project Autolibrary.Domain.User (.NETFramework,Version=v4.5.1) was previously compiled. Skipping compilation.
Setting app base path C:\Users\Developer\Documents\Visual Studio 2015\Projects\EntityCoreTest\src\Autolibrary.Domain.User\bin\Debug\
net451\win7-x64
Finding DbContext classes...
Using context 'UserDbContext'.
Using database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Executed DbCommand (15ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT OBJECT_ID(N'__EFMigrationsHistory');
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT OBJECT_ID(N'__EFMigrationsHistory');
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Executed DbCommand (0ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT [MigrationId], [ProductVersion]
FROM [__EFMigrationsHistory]
ORDER BY [MigrationId];
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Applying migration '20161121225055_AddVehicle'.
Opening connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
Beginning transaction with isolation level 'Unspecified'.
Executed DbCommand (1ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
CREATE TABLE [Vehicles] (
    [Id] nvarchar(40) NOT NULL,
    [LastServiced] datetime2 NOT NULL,
    [Variant] nvarchar(50),
    CONSTRAINT [PK_Vehicles] PRIMARY KEY ([Id])
);
Executed DbCommand (2ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
CREATE TABLE [Estimates] (
    [Id] nvarchar(40) NOT NULL,
    [CreatedDate] datetime2 NOT NULL,
    [Discriminator] nvarchar(max) NOT NULL,
    [LastUpdated] datetime2 NOT NULL,
    [ReferenceNo] nvarchar(50),
    [VehicleId] nvarchar(40) NOT NULL,
    [DueDate] datetime2,
    [InvoiceDate] datetime2,
    [VehicleId1] nvarchar(450),
    CONSTRAINT [PK_Estimates] PRIMARY KEY ([Id]),
    CONSTRAINT [FK_Estimates_Vehicles] FOREIGN KEY ([VehicleId]) REFERENCES [Vehicles] ([Id]) ON DELETE CASCADE,
    CONSTRAINT [FK_Estimates_Vehicles_VehicleId1] FOREIGN KEY ([VehicleId1]) REFERENCES [Vehicles] ([Id]) ON DELETE NO ACTION
);
Closing connection to database 'EntityCoreTest' on server 'DEV\SQLEXPRESS'.
System.Data.SqlClient.SqlException (0x80131904): Column 'Vehicles.Id' is not the same length or scale as referencing column 'Estimat
es.VehicleId1' in foreign key 'FK_Estimates_Vehicles_VehicleId1'. Columns participating in a foreign key relationship must be define
d with the same length and scale.
Could not create constraint. See previous errors.
   at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boole
an asyncClose)
   at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpl
eResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at System.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean async, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToP
ipe, Int32 timeout, Boolean asyncWrite)
   at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, String executeMetho
d, IReadOnlyDictionary`2 parameterValues, Boolean openConnection, Boolean closeConnection)
   at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDi
ctionary`2 parameterValues, Boolean manageConnection)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationCommandExecutor.ExecuteNonQuery(IEnumerable`1 migrationCommands, IR
elationalConnection connection)
   at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
ClientConnectionId:a46a9c25-6e32-40ca-a2e1-d966ccc21bbd
Error Number:1753,State:0,Class:16
Column 'Vehicles.Id' is not the same length or scale as referencing column 'Estimates.VehicleId1' in foreign key 'FK_Estimates_Vehicles_VehicleId1'. Columns participating in a foreign key relationship must be defined with the same length and scale.
Could not create constraint. See previous errors.

Then I decided to manually redeclare the VehicleId in Invoice class which is what caused the above error I mentioned in the OP.
As for 1.1.0-preview4-final, I upgraded the project but then I kept getting the error
Unrecognized option '--config'
So I downgraded it back to the version I know that worked.

I see, for this error to be fixed you would need to update to 1.1.0-preview4-final. the --config issue is tracked by https://github.com/aspnet/EntityFramework/issues/7071
As a workaround you can edit the migrations file and add maxLength:
VehicleId1 = table.Column<string>(maxLength: 40, nullable: true)

@AndriySvyryd ok thanks. I was hoping not to mess with the migration file because then any other person who may remove and add a new migration may not realize the patch work I did. And since I can't use 1.1.0-preview4-final at the moment, I am left with no choice.
Anyway, I am going with a base class approach so both Estimate and Invoice inherit from that and the link to Vehicle is handled in Estimate & Invoice classes. So this avoids the problem faced here. However, hopefully in the future when I have to inherit a class that has a relationship like I mentioned before, the 1.1.0-preview4-final would have a fix.


MD018: do not check # in HTML blocks

Fix #1268.
Side Effect: MD013 will treat html code (including embedded markdownlint-configure-file) as code blocks, which will emit errors in these cases:
https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/test/long-lines-short-code.md?plain=1#L27-L32
https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/test/long-lines-short-code.md?plain=1#L27-L32
https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/test/long-lines-strict.md?plain=1#L33-L39

"Code" in the case of getLineMetadata is meant to refer to one of the two Markdown code block types (indented or fenced). The proposed change could have more side effects beyond what you have already identified. I had been thinking that a fix specific to MD018 would be best here. Did you try that first?

By the way, could you please update the test file to include scenarios that would trigger rules 18, 19, 20, and 21? If 18 is broken, then I suspect 20 is also. 19 and 21 are already migrated to micromark in the next branch, so should be OK as-is. But I would like the new test file to verify the HTML scenario for all four of these similar rules. Thank you!

I'm unsure if we should investigate this violation, as the current implementation will simply ignore it.
##Title text {MD018} {MD033}

What you show above seems like correct behavior, or am I missing something?

FYI, there will be a failure in TeatRepos because that is failing in next branch. I will fix that shortly, so please ignore for now.

What you show above seems like correct behavior, or am I missing something?

Currently, only MD033 is emitted; MD018 is ignored due to the HTML block in this line. I think emitting both MD033 and MD018 will be more reasonable.

I agree. But the above is an HTML span, not a block. I would not expect it to be affected by the new code?

I agree. But the above is an HTML span, not a block. I would not expect it to be affected by the new code?

You are right, I made an mistake.

Please rebase PR to latest next branch commit to fix "sh: 1: ava: not found". This is a bug in latest Node/npm which I have worked around.

I can't easily view the snapshot diff on my phone, but all the other code changes look good, thank you!

I had a look at the differences, and there is way more going on than there needs to be. After you re-base (see comment above), please run "npm run update-snapshots" to regenerate that file. The diff at that point should be ONLY the errors and corrections for the new test file you added. After that, we make sure checks pass and I'll approve. :)

I reran "npm run update-snapshots", but the snapshot didn't change, and I enabled GitHub action in my own repository and the CI looks good. I think the tests' order is changed, but I do not know what to do.

I wonder if this is a locale issue that sorts differently for you? I will give it a try in a day or two and either push a commit to your branch with the "right" order or approve your changes as-is. Thanks again!


Failed to run exporter on OpenShift 4.x

Describe the bug
When run kor in cluster with exporter flag
kor -exporter --resources secret,configmap,pvc -n kor-test-namespace
We got an error:
Failed to retrieve namespaces: namespaces is forbidden: User "system:serviceaccount:kor-test-namespace:dev-kor" cannot list resource "namespaces" in API group "" at the cluster scope
We faced similiar issue when run kor v0.3.5 without exporter flag, see
https://github.com/yonahd/kor/issues/213
To Reproduce
Run kor in cluster with options:
-exporter --resources secret,configmap,pvc -n <namespace_name>
Expected behavior
Namespace will be scanned and result provided without get access to list of namespaces, get only unused resources in provided namespace
OS version, architecture and kor version
OpenShift 4.12
Kor version: 0.3.8
Additional context
For example:
kubectl get ns will return
Error from server (Forbidden): namespaces is forbidden: User "kor-test-user" cannot list resource "namespaces" in API group "" at the cluster scope
but when you run:
kubectl get project
you will get result:
NAME DISPLAY NAME STATUS
...
kor-test-namespace
...
This issue also might be connected to:
https://github.com/yonahd/kor/issues/218

Strange that this came back
Looking what changed

@hrytsai this worked fine in 0.3.7?

@hrytsai this worked fine in 0.3.7?

Nope, the same problem

Very strange I cannot seem to replicate this error.
There are 2 places in the code that call the list namespaces api and your command hits neither of them.
Let me see if anyone else can replicate

The issue results from the retrieveUsedClusterRoles() function that is called in pkg/kor/clusrterroles.go.
func retrieveUsedClusterRoles(clientset kubernetes.Interface, filterOpts *filters.Options) ([]string, error) {

	//Get a list of all namespaces
	namespaceList, err := clientset.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
	if err != nil {
		fmt.Fprintf(os.Stderr, "Failed to retrieve namespaces: %v\n", err)
		os.Exit(1)
	}
	roleBindingsAllNameSpaces := make([]v1.RoleBinding, 0)

	...

When either command kor all or kor exporter is used, GetUnusedAll() function is invoked under pkg/kor/all.go.
In kor versions up to v0.3.8 including, there was an issue with this function, it also scanned the cluster for non-namespaced resources (i.e. CRD, PV, ClusterRole). It was reported in #178.
As getting unused ClusterRoles requires access to all namespaces, the following error raised:
Failed to retrieve namespaces: namespaces is forbidden: User "system:serviceaccount:kor-test-namespace:dev-kor" cannot list resource "namespaces" in API group "" at the cluster scope

This issue was fixed in #258, with the following function correction:
func GetUnusedAll(filterOpts *filters.Options, clientset kubernetes.Interface, apiExtClient apiextensionsclientset.Interface, dynamicClient dynamic.Interface, outputFormat string, opts Opts) (string, error) {
	unusedAllNamespaced, err := GetUnusedAllNamespaced(filterOpts, clientset, outputFormat, opts)
	if err != nil {
		fmt.Printf("err: %v\n", err)
	}

	// Skip getting non-namespaced resources if --include-namespaces flag is used
	if len(filterOpts.IncludeNamespaces) > 0 {
		return unusedAllNamespaced, nil
	}

	...

@yonahd as this fix was merged to main, let's bump v0.3.9, it should resolve the issue mentioned in this case.

The issue results from the retrieveUsedClusterRoles() function that is called in pkg/kor/clusrterroles.go.
func retrieveUsedClusterRoles(clientset kubernetes.Interface, filterOpts *filters.Options) ([]string, error) {

	//Get a list of all namespaces
	namespaceList, err := clientset.CoreV1().Namespaces().List(context.TODO(), metav1.ListOptions{})
	if err != nil {
		fmt.Fprintf(os.Stderr, "Failed to retrieve namespaces: %v\n", err)
		os.Exit(1)
	}
	roleBindingsAllNameSpaces := make([]v1.RoleBinding, 0)

	...

When either command kor all or kor exporter is used, GetUnusedAll() function is invoked under pkg/kor/all.go. In kor versions up to v0.3.8 including, there was an issue with this function, it also scanned the cluster for non-namespaced resources (i.e. CRD, PV, ClusterRole). It was reported in #178.
As getting unused ClusterRoles requires access to all namespaces, the following error raised:
Failed to retrieve namespaces: namespaces is forbidden: User "system:serviceaccount:kor-test-namespace:dev-kor" cannot list resource "namespaces" in API group "" at the cluster scope

This issue was fixed in #258, with the following function correction:
func GetUnusedAll(filterOpts *filters.Options, clientset kubernetes.Interface, apiExtClient apiextensionsclientset.Interface, dynamicClient dynamic.Interface, outputFormat string, opts Opts) (string, error) {
	unusedAllNamespaced, err := GetUnusedAllNamespaced(filterOpts, clientset, outputFormat, opts)
	if err != nil {
		fmt.Printf("err: %v\n", err)
	}

	// Skip getting non-namespaced resources if --include-namespaces flag is used
	if len(filterOpts.IncludeNamespaces) > 0 {
		return unusedAllNamespaced, nil
	}

	...

@yonahd as this fix was merged to main, let's bump v0.3.9, it should resolve the issue mentioned in this case.

@doronkg the all function should not be called in the above case. This is using the --resources flag which triggers multi
https://github.com/yonahd/kor/blob/v0.3.8/pkg/kor/exporter.go#L86

@hrytsai this worked fine in 0.3.7?

Nope, the same problem

Let's split it into two cases:
1) The --resources flag was only introduced in v0.3.8, so it couldn't be reproduced in v0.3.7 with that flag.
If it failed for you in v0.3.7, then that's the case mentioned in this comment, that's been worked around in v0.3.8 (only if --resources flag is used). I've been able to reproduce it.
Without the flag, not only the error message will still be displayed, the pod will enter a CrashLoopBackOff state.

Example A - All
$ oc get pods -n kor
NAME                            READY   STATUS             RESTARTS      AGE
kor-exporter-85d5d69cc6-vwbz5   0/1     CrashLoopBackOff   5 (64s ago)   4m30s

$ oc logs kor-exporter-85d5d69cc6-vwbz5 -n kor
Server listening on :8080
collecting unused resources
Failed to retrieve namespaces: namespaces is forbidden: User "system:serviceaccount:kor:test" cannot list resource "namespaces" in API group "" at the cluster scope

$ oc get pod kor-exporter-85d5d69cc6-vwbz5 -n kor -o yaml
apiVersion: v1
kind: Pod
metadata:
  name: kor-exporter-85d5d69cc6-vwbz5
  namespace: kor
spec:
  containers:
  - args:
    - exporter
    command:
    - kor
    image: yonahdissen/kor:latest
    imagePullPolicy: Always
    name: kor-exporter-container
...

Example B - Resources by Namespace
$ oc get pods -n kor
NAME                            READY   STATUS             RESTARTS      AGE
kor-exporter-6b9fdc9f4f-svdgb   1/1     Running   0          28s

$ oc logs kor-6b9fdc9f4f-svdgb -n kor
Server listening on :8080
collecting unused resources

$ oc get pod kor-exporter-6b9fdc9f4f-svdgb -n kor -o yaml
apiVersion: v1
kind: Pod
metadata:
  name: kor-exporter-6b9fdc9f4f-svdgb
  namespace: kor
 spec:
    containers:
    - args:
      - exporter
      - --resources
      - pvc,secret
      - -n
      - kor
      command:
      - kor
      image: yonahdissen/kor:latest
      imagePullPolicy: Always
      name: kor-exporter-container
...

2) In v0.3.8, as said, this error message shouldn't be displayed (see comment) if the flag is used, but if the used ServiceAccount doesn't have get permissions to the requested namespaces it should query, this would be displayed in the container:
NOTE: That depends whether the ClusterRoleBinding from the Helm chart was applied (allows to get/list/watch all namespaces by default) or rather the used ServiceAccount is binded with custom RBAC.
$ oc logs kor-exporter-56d6696cf7-zqdn6 -n kor
Server listening on :8080
collecting unused resources
namespace [kor-test-namespace] not found

That behavior results from Namespaces() function in options.go that handles the --include-namespaces / -n flag.
func (o *Options) Namespaces(clientset kubernetes.Interface) []string {
	...

	for _, ns := range includeNamespaces {

		_, err := clientset.CoreV1().Namespaces().Get(context.TODO(), ns, metav1.GetOptions{})
		if err == nil {
			namespacesMap[ns] = true
		} else {
			fmt.Fprintf(os.Stderr, "namespace [%s] not found\n", ns)
		}
	}

@hrytsai if you encounter case (1), make sure to upgrade to v0.3.8 and have the pod restarted.
If you've upgraded and the error message is still displayed, let us know here.
If you've upgraded and case (2) is displayed, follow these steps:
$ oc auth can-i get ns/kor-test-namespace --as=system:serviceaccount:kor-test-namespace:dev-kor
Warning: resource 'namespaces' is not namespace scoped
no

This could be easily resolved by manually granting the following permissions to the ServiceAccount (if not using the Helm chart), with designated ClusterRole & ClusterRoleBinding:
rules:
  - apiGroups: [""]
    resources:
      - namespaces
    verbs:
      - get
      - list
      - watch

Once you've made the change, run the following command that should display:
$ oc auth can-i get ns/kor-test-namespace --as=system:kor-test-namespace:dev-kor
Warning: resource 'namespaces' is not namespace scoped
yes

Restart the pod, and validate that the warning no longer displays.
Please let me know how it went.

Hi
Thanks for explanation, we have case 2.
But problem is that we cannot provide SA\User for get, list, watch namespaces permission in multi tenancy cluster for security requirements.
We operate concept "Project" in OpenShift that is tightly connected to "Namespace" and SA\Users can get necessary  permission.
Is it possible to add option like:
isOpenShift and use "Project" instead  of "Namespaces" in this case in application ?

Hi
Thanks for explanation, we have case 2.
But problem is that we cannot provide SA\User for get, list, watch namespaces permission in multi tenancy cluster for security requirements.
We operate concept "Project" in OpenShift that is tightly connected to "Namespace" and SA\Users can get necessary  permission.
Is it possible to add option like:
isOpenShift and use "Project" instead  of "Namespaces" in this case in application ?

I'm glad we've got to the bottom of this. We'll look into an OpenShift Project-compatible solution and update you.
If you have additional feedbacks regarding kor on OpenShift, we'd be happy to hear.


Stucking still works

"Fix stucking on curbs/steps" did not help. You freeze in the air and can not move.

Strange, It works perfectly in all my gamemodes now, will do some more testing today

Just retested a few maps, no issues found. Make sure you are not overwriting any crucial PlayerController code, will close for now.


⚠ ClamAV has degraded performance

In f3e3184, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 552 ms

Resolved: ClamAV performance has improved in 96a0375.


render.py

Hello, timmh, a single .exr file I got after running render.py contains the color, depth, and motion vectors, but how can I store them separately, like color.png, depth.exr and vector.exr?

You can do so, for example, using the OpenEXR package, refer to here for an example.

Thank you very much for your reply！


This is only used while developing

Yeah but people should then also realize they can't just add it to the list of providers, otherwise it will crash.

Yea this change is meaningless - most of us already have thought this through.

Well, you could also do the following in your config/app.php:
if (getenv('APP_ENV') == 'local') {
    $conf['providers'][] = 'Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider';
}

You can submit a PR to the readme if you want :)


Custom explanation for banned functions

Hi! Big fan of hlint!
As part of making this list: https://github.com/NorfairKing/haskell-dangerous-functions I wrote up the issues with each of the dangerous functions.
It would be nice if I could make the error message refer to the list or even just have the entire explanation in there.

Have you seen the note field? You can write any arbitrary note that appears at the end of the hint. Often it's used to give warnings of corner cases (e.g. changes strictness, requires associative Eq etc), but you can use it for any purpose. E.g. https://github.com/ndmitchell/hlint/blob/93132bb66c03d975f7a975f756e4e5414b5493e2/data/hlint.yaml#L93

Doh, that's exactly what I want!

I just tried it out, and that doesn't seem to work:
functions:
  - {name: fromJust, within: [], note: 'Partial'} # Partial

on
main = fromJust Nothing

with this output:
hlint test.hs  --hint=hlint.yaml
hlint: user error (Failed to read YAML configuration file hlint.yaml
  Aeson exception:
Error in $: Error when decoding YAML, Not allowed keys: note
Along path: root 1 functions 56
When at: Object
note: Partial
name: fromJust
within: []
)

A quick look at the code (but not running any experiences since I don't have Haskell installed on this machine) suggests that culprit is https://github.com/ndmitchell/hlint/blob/93132bb66c03d975f7a975f756e4e5414b5493e2/src/Config/Yaml.hs#L301 and it's called "message" for restriction hints. That seems crazy to have message in one place and note in another...

@ndmitchell Yes it looks like that is what I was looking for.
It gets even more confusing, because the output looks like this:
test.hs:1:8-15: Warning: Avoid restricted function
Found:
  fromJust
Note: Partial

Even here it's called a Note and not a message..

OK, so I think the fact it accepts message is a bug, but probably the best thing to do is support both message and note and encourage the use of note in future.


Package not found

I'm trying to delete old package versions in a GitHub Actions workflow on private repository. Packages are under the same repository where GitHub Actions run. I can see them in the repository home page and by making API call with GH CLI.
I'm using the autogenerated GITHUB_TOKEN.
When I run the step with this action i get the following:
Run actions/delete-package-versions@v2
  with:
    package-name: sylius-project.php
    min-versions-to-keep: 5
    ignore-versions: latest
    num-old-versions-to-delete: 1
    delete-only-pre-release-versions: false
    token: ***

(node:35689) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
package: sylius-project.php not found for owner: webgriffe in repo: sylius-project
no package version ids found, no versions will be deleted

As you can see I get a deprecation warning but what is worst is that it says that the package syliu-project.php cannot be found for that repository.
I cannot understand why. Anyone could help me?

Maybe it's related to https://github.community/t/github-token-cannot-access-private-packages/16621/45?page=2

@NamrataJha @trent-j do you have any idea? It could be possible that it's because I'm using the GITHUB_TOKEN? I don't want to use a PAT. It's an organization repository, with a PAT I'll give access to all my repositories to other members of the same organization.

The strange thing is that using the same GITHUB_TOKEN to authenticate on ghcr.io registry, in the same workflow, I'm able to publish/upload the package and then to download it.
But I'm not able to see it when I do the REST API request to Get all package versions for a package owned by an organization...

@mmenozzi can you specify which package registry are you using?
Assuming that it is ghcr.io registry, I am sorry to say that you won't be able to use this action there as container registry packages are not mapped to any repository by default.

Hi @NamrataJha, yes I'm using ghcr.io which is the container registry of GitHub Packages.
I thought that I could use this action because its README states in the first line:

This action deletes versions of a package from GitHub Packages.

So is it not possible to delete versions of Docker images on GitHub Packages at all? Or only if using GITHUB_TOKEN? Would it work if I use a PAT? Haven't tried it yet.

Hi @mmenozzi @NamrataJha were you able to make it work?
I'm having the same issue when I try to delete a Package version on a Private Package which is mapped to my repo.

I've also hit this and would love to know what the recommended way is to expire old containers from GHCR. I originally found this action via https://github.community/t/deleting-images-from-github-package-registry/2758/6 which is talking specifically about docker images and this was a suggested solution. Perhaps one of the scripts there might help, but they mostly seem to use PATs.

I'd also like to see a solution to this that I can run in my GitHub workflows. If we can't prune old Container images, our storage costs are going to expand at an unsustainable rate. Lack of this functionality is leading me to conclude that ECR would be a better container storage solution for us.

As the delete-package-versions action runs on graphql, currently this can not be used for cleaning up old containers from GHCR.
The recommended way would be to delete old container images via REST API. This won't work with GITHUB_TOKEN but can be used in a workflow with a PAT with delete:packages scope.
Here is one sample workflow that can be used for cleaning up untagged images.

@Jcambass can this be closed now as ghcr.io packages can be deleted by using package-type: 'container'?

Closing as deleting ghcr.io containers is supported since a while now.


No anchor for release calendar

There's no way to form a link to the release calendar:

Duplicate of #951

@vinniefalco anchor tag for schedule added to the homepage, which you can preview here: https://www.stage.boost.cppalliance.org/#schedule


Vectorize light curve functions

This PR updates the interface introduced by #129 to remove the requirement that light curves always be manually vmapped. But, it still allows the logic within the light curve computation to assume that it only needs to operate on a scalar time. I think this is the best of both worlds because it makes the implementation of light curves a little more straightforward while keeping a nice user interface that can operate on arrays of times.
To do this, I added a light_curves.utils.vectorize decorator which handles the vmapping and units. We can't use jnp.vectorize (which would have been my preference) because we need to support Quantity input and output.

Looks nice! Once merged I'll try to use that for the starry light curves functions too.

I'm going to merge this for now so that we can keep rolling with some other PRs, but I'd love to hear your thoughts later when you have a chance @soichiro-hattori!

@dfm: This all looks great!


Composer is not synced with repository

Please sync composer package with this repo. it's not synced and web hook is not configured. now the latest version is not available in composer package.

Sorry @jafaripur. I was busy. It's up-to-date now. # #


org/arangodb/request should process body regardless of status

Currently, the response's body is only returned if the status is 2xx. I think the body should be returned no matter what the status is.
I need to call an api which can return status 500 and then has a more detailed error message in the body. Using org/arangodb/request I have no idea what the reason for the 500 is. When using https://github.com/request/request with node.js, I get access to the body (and found out that the reason for the 500 was an invalid api key).

I see that internal.download() at https://github.com/arangodb/arangodb/blob/devel/lib/V8/v8-utils.cpp#L583 already supports returnBodyOnError as an option. So wouldn't we just have to expose this option through request() by adding
  if (is.existy(req.returnBodyOnError)) {
    options.returnBodyOnError = req.returnBodyOnError;
  }

before https://github.com/arangodb/arangodb/blob/devel/js/common/modules/org/arangodb/request.js#L160

@pluma has this been fixed in 2.7?

This change will land in 2.8 as it makes sense to change the default behaviour rather than simply expose the option.

Thanks


[ENH] Sort cv_results_ values by rank in BaseGridSearch / evaluate

Output DataFrame of attribute cv_results_  should be sorted by rank

KWF


feat(service): Add lark service

Describe the missing service. Please provide useful links.

https://www.larksuite.com/
Describe the solution you'd like

Add a new service that
Potential libraries to use

https://github.com/go-lark/lark
https://github.com/chyroc/lark

...

Closed in #300


fix the panic caused by resizing a starting exec

If resize an exec that is not fully started, the daemon will panic with the following info:
2015/07/22 19:44:14 http: panic serving @: runtime error: invalid memory address or nil pointer dereference^M
goroutine 12502 [running]:^M
net/http.func·011()^M
  /usr/local/go/src/net/http/server.go:1130 +0xbb^M
github.com/docker/docker/daemon.(*execConfig).Resize(0xc208191600, 0x27, 0x93, 0x0, 0x0)^M
  /go/src/github.com/docker/docker/daemon/exec.go:70 +0x67^M
github.com/docker/docker/daemon.(*Daemon).ContainerExecResize(0xc20806b180, 0xc20815b041, 0x40, 0x27, 0x93, 0x0, 0x0)^M
  /go/src/github.com/docker/docker/daemon/resize.go:18 +0x99^M
github.com/docker/docker/api/server.(*Server).postContainerExecResize(0xc2080b1100, 0xc20815b037, 0x4, 0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0, 0xc208dab5f0, 0x0, 0x0)^M
  /go/src/github.com/docker/docker/api/server/server.go:1422 +0x2ca^M
github.com/docker/docker/api/server.*Server.(github.com/docker/docker/api/server.postContainerExecResize)·fm(0xc20815b037, 0x4, 0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0, 0xc208dab5f0, 0x0, 0x0)^M
  /go/src/github.com/docker/docker/api/server/server.go:1546 +0x7b^M
github.com/docker/docker/api/server.func·008(0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0)^M
  /go/src/github.com/docker/docker/api/server/server.go:1489 +0x91d^M
net/http.HandlerFunc.ServeHTTP(0xc20814f800, 0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0)^M
  /usr/local/go/src/net/http/server.go:1265 +0x41^M
github.com/gorilla/mux.(*Router).ServeHTTP(0xc2080f51d0, 0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0)^M
  /go/src/github.com/docker/docker/vendor/src/github.com/gorilla/mux/mux.go:98 +0x297^M
net/http.serverHandler.ServeHTTP(0xc2080518c0, 0x7f103863d9f8, 0xc2080c6500, 0xc2089031e0)^M
  /usr/local/go/src/net/http/server.go:1703 +0x19a^M
net/http.(*conn).serve(0xc2081575e0)^M
  /usr/local/go/src/net/http/server.go:1204 +0xb57^M
created by net/http.(*Server).Serve^M
  /usr/local/go/src/net/http/server.go:1751 +0x35e^M

The execConfig.ProcessConfig.Terminal is assigned by setupPipes in daemon/execdriver/native/driver.go. Before the call to setupPipes it's a nil pointer, which caused the panic.
This PR fixes part of #14845. But I've no idea why it panicked during daemon shutdown.
Signed-off-by: Shijiang Wei<EMAIL_ADDRESS>

The experimental test failed due to the same reason as #14738

I've also seen this panic stack yesterday, thanks for the PR.

LGTM

LGTM

thankks for the fix and the test ;)


Remove native bindings

This PR removes entirely any intended support for maintaining use of native libpq bindings. The dependency is removed from the build. It updates the makefile to remove test-native and test-missing-native targets which cuts the testing runtime down by a good amount. This also updates parts of tests that have execution paths specific for using native bindings and removes a few tests that exclusively tested this way. This should have no impact on the success of any running unit or integration tests

Updated to fix remaining tests and allow for accurate CI reporting


Allow option to disable service monitor

Thanks @mihaelabalas84 . I will release this later today.

Your change is live in 1.12.0


A simple GUI for gnewsclient

A nice GUI with filters on edition, topic, location and language can be created.

The newsfeed should be displayed with image, topic and hyperlink of each story.
Tkinter can be used to make it as it should be simple and minimal.

I can work on this.
@nikhilkumarsingh

@utkarshkvs1 I am working on it.

@aditodkar @nikhilkumarsingh @utkarshkvs1  I tried making a GUI using tkinter, but I had difficulties with displaying a JPG image from its link. Can you help me out?


Namespace 'NodeJS' has no exported member 'Global'.

Getting this error with both node 16 and node 20. Maybe it's due to the TypeScript version?
npm run build

><EMAIL_ADDRESS>build
> npm run clean && tsc

><EMAIL_ADDRESS>clean
> rm -rf dist/

node_modules/@noeldemartin/utils/dist/noeldemartin-utils.d.ts:212:78 - error TS2694: Namespace 'NodeJS' has no exported member 'Global'.

It still happens after npm install<EMAIL_ADDRESS>


Tileset with margin & spacing bug

Hi,
When Tileset has margin & spacing between tiles, phaser-tiled doesn't calculate well the numTiles attribute. Changing "this.numTiles" in Tileset constructor works well for me.
In Tileset.js :
this.numTiles = this.multiImage ? tileTextures.length : new Phaser.Point(
Phaser.Math.floorTo((this.baseTexture.width - this.margin) / (this.tileWidth - this.spacing)),
Phaser.Math.floorTo((this.baseTexture.height - this.margin) / (this.tileHeight - this.spacing))
);
Thanks!

Use:
this.numTiles = this.multiImage ? tileTextures.length : new Phaser.Point(
Phaser.Math.floorTo((this.baseTexture.width - this.margin) / (this.tileWidth + this.spacing)),
Phaser.Math.floorTo((this.baseTexture.height - this.margin) / (this.tileHeight + this.spacing))
);

This was fixed a while ago in the v2 branch:
https://github.com/englercj/phaser-tiled/blob/thin-tiles/src/tiled/Tileset.js#L149-L152


Compile PHP 7.2.2 with openssl on macOS

macOS 10.13.2
LibreSSL 2.2.7
When I try to compile PHP 7.2.2 with openssl, I get these errors.
configure: error: Cannot find OpenSSL's <evp.h>

The following command solves the first problem.
$ cd /usr/local/include
$ ln -s ../opt/openssl/include/openssl

Now I get this error, can someone help me?
Undefined symbols for architecture x86_64:
  "_X509_get_signature_nid", referenced from:
      _zif_openssl_x509_parse in openssl.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [sapi/cli/php] Error 1

OpenSSL != LibreSSL, even though the latter is a fork of the former.
I think you should get in touch with the LibreSSL folks.

$ openssl version
LibreSSL 2.2.7

Then I do not understand why LibreSSL is installed. I would like to use openssl and did it with brew install openssl.
My wish is simply to use the latest version of PHP with openssl, so I'm in the right place.


Cached blocks should be stored per request

The cached blocks object should be specific to each request, rather than a singleton shared by all requests. After a request has completed, the object can then be removed from memory, ensuring no memory leaks are created. In addition it would prevent conflicts between simultaneous page loads that are using async helpers.
This would resolve issues #99 and #100

@penx This might be hard with the current design of the API. Express doesn't give us the req or res object when render is called. Express render was not really designed with async in mind as it expects all user data to come into the render. I wonder if this library should have never excited with async and forced the programmer to first fetch all data first before calling render but with that said this is what I found looking at this issue.
Maybe a better way to solve the memory leak is to use a smarter cache with TTLs.
As for the async wrong content are you sure? The library does generate a new ID for each async content request. Let me see if I can create a test that causes this issue.


sort mx records by priority (lowest first)

Taken from https://en.wikipedia.org/wiki/MX_record#Priority

Mail is delivered to the mail exchange server with the lowest preference number (highest priority), so the MX record you use for mail routing should have the lowest preference number, typically 0.

Description
Currently the mail is sent by using the MX record with the highest priority. This PR changes it to use the record with the lowest priority first.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@seasick thank you for the pr - anything else you see that needs work ?

@GreenPioneer, you are welcome. Noticed it, though it is an easy fix. Even without that fix, it works like a charm :)

No news from this?

@GreenPioneer : This PR is really important. As-is, you will always send to the wrong SMTP server, if there are backup fallback servers.

@seasick thanks again and my bad on it taking so dang long to get it in
I don't know how I wasn't notified by @luisesn message but I was with @benbucksch message
Will be publishing to NPM momentarily

https://www.npmjs.com/package/sendmail/v/1.5.0

@GreenPioneer : Thanks!

Thanks!


Integrate CardFlip

I was getting the AccessbilityInfo not found errors (like #16 or #12) as well.
This is due to this library not specifying a react-native version in its dependencies, so it falls back to the react native version specified in react-native-card-flip (sth quite old like 0.49.1).
As react-native-card-flip is not maintained anymore and this library relying quite strongly on this, i moved the relevant part (CardFlip.js) into this code base.
These changes made the library work again for me without the errors and essentially fixes #16 and some of the comments from #12 (not the typescript definitions, but the comments hinting at the accessibilityInfo error)

Seems good to start with.. I appreciate your support


Synchronize

Suljia and I tested with multiple synchronize pokemon, and it seems that none of them are setting the nature of wild pokemon during battle. I caught around 20 pokemon with a Kadabra as the lead, and not a single one had the nature. Suljia tested more with her ralts and had a similar result.

Not exactly a bug just a feature the team has disregarded for now. Might be added in the future.

This was discussed and the nature of the Pixelmon is generated on spawning, not on battle start

Been implemented so can be closed

Still having this issue on version 2.5.1 of Pixelmon Generations Modpack

Still having this issue on version 2.5.1 of Pixelmon Generations Modpack

Pixelmon Generations has been using outdated code stolen from Pixelmon Reforged. I'm not surprised that they have issues with implementation. I'm afraid that we are unable to provide any support regarding a Generations modpack. If you would like to switch to the maintained Pixelmon Reforged, there is a discord available at https://discord.gg/Aadchbk. Mod information can be found at reforged.gg

Thanks for the response, was considering switching but wasn't sure how it would affect the save file.On Feb 21, 2019 3:05 PM, Vohras2<EMAIL_ADDRESS>wrote:
Still having this issue on version 2.5.1 of Pixelmon Generations Modpack
Pixelmon Generations has been using outdated code stolen from Pixelmon Reforged. I'm not surprised that they have issues with implementation. I'm afraid that we are unable to provide any support regarding a Generations modpack. If you would like to switch to the maintained Pixelmon Reforged, there is a discord available at https://discord.gg/Aadchbk. Mod information can be found at reforged.gg
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions

It took a fair amount of stupid on my part. My friends and I wanted to play some pixelmon after not having played it since before the split. They immediately identified that reforged was the better mod but we didn't get around to playing at the time. About a week later I decided to impulse buy a server, and forgot which mod we had decided on.I couldn't really find indication of the difference between the mods from surface-level googling so I just went with generations, and then didn't realize that the host also supported reforged until recently, after we had all put 20+ hours into the world. After playing reforged for 5 minutes I can see that it's clearly the far better mod and I wish I could switch at this point. I appreciate your time even though this issue has really nothing to do with reforged.On Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the threadOn Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

 My friends and I wanted to play some pixelmon after not having played it since before the split. They immediately identified that reforged was the better mod but we didn't get around to playing at the time. About a week later I decided to impulse buy a server, and forgot which mod we had decided on.I couldn't really find indication of the difference between the mods from surface-level googling so I just went with generations, and then didn't realize that the host also supported reforged until recently, after we had all put 20+ hours into the world. After playing reforged for 5 minutes I can see that it's clearly the far better mod and I wish I could switch at this point. I appreciate your time even though this issue has really nothing to do with reforged.On Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the threadOn Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

I'm like 99% sure that reforged supports swapping from Generations. I'd recommend going to the Reforged Discord and asking exactly how to.

I tried briefly but got a chunk error crash and world corruption after playing reforged for about a half hour. But thanks, I'll check out the discord. I appreciate the help!On Feb 22, 2019 7:56 AM, Vohras2<EMAIL_ADDRESS>wrote:
It took a fair amount of stupid on my part. My friends and I wanted to play some pixelmon after not having played it since before the split. They immediately identified that reforged was the better mod but we didn't get around to playing at the time. About a week later I decided to impulse buy a server, and forgot which mod we had decided on.I couldn't really find indication of the difference between the mods from surface-level googling so I just went with generations, and then didn't realize that the host also supported reforged until recently, after we had all put 20+ hours into the world. After playing reforged for 5 minutes I can see that it's clearly the far better mod and I wish I could switch at this point. I appreciate your time even though this issue has really nothing to do with reforged.On Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the threadOn Feb 22, 2019 4:17 AM, Hiroku<EMAIL_ADDRESS>wrote:How did you even find this bug tracker if you use Generations? I admire your reach but I have so many questions —You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
I'm like 99% sure that reforged supports swapping from Generations. I'd recommend going to the Reforged Discord and asking exactly how to.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.

If you need any help, join reforged.gg/discord


Java wrapper usage documentation

Could you please add documentation to the README on how to use the Java wrapper? I see build.xml in the java subfolder. Is this wrapped intended to be used by the Ant build system?
For context, I'm trying to use the Java wrapper from a Gradle-based Android project. @terryburton Reading through #4, it sounds like publishing a multi-architecture JAR on Maven is/was being considered. Is that still on the cards? I wasn't able to find this library on Maven Central.

My intent so far has been to release a Java library package consisting of a single multi-architecture JAR published on Maven Central

This is mainly to show that art of the possible, and it is for developers to determine what's necessary to integrate with their project's build system. The lack of documentation is acknowledged.

The Java wrapper build system has been amended to create a JNI library that statically links the GS1 Syntax Engine by default, which simplifies (manual) distribution. It is no longer necessary to install the Syntax Engine as a separate shared library in order for a project to use the wrapper.
To build the Java JNI library:
make -C src/c-lib -j `nproc`
cd src/java
ant -f src/java/build.xml test

Then use the resulting src/java/libgs1encoders.{jar,so} files into your project as local dependencies, as you would with any other JNI library, remembering to set your classpath to include the .jar file and java.library.path to find the .so file.
Also ensure that there is an instance of the Syntax Dictionary (gs1-syntax-dictionary.txt) in your project's runtime working directory, otherwise the library will fall back to the compiled in default.
Brief information is provided here: https://github.com/gs1/gs1-syntax-engine/blob/main/src/java/build.xml#L19-L45


Button label visibility: set on/off in DomainDefault, not by editing psgeolang.js

Hence, keep site specific configuration site specific. Don't mess with psgeolanǵ.js
A few non-urgent internationalization issues need to be addressed sometime in the future though.

#120


The Scala minimal reader doesn't honor offsets (ox, oy)

It also doesn't do anything with centroids, which it needs to do if centroids are allowed to stand in for offsets.

Resolved by https://github.com/openworm/tracker-commons/pull/42


Please require/support newer illuminate/console

I am facing difficulties to resolve the following dependency conflicts:
"require" :
    {
        "php": ">=5.3",
        "robmorgan/phinx": "^0.5.4"
    },

    "require-dev" :
    {
        "anahkiasen/rocketeer": "^2.2"
    }

Is it possible to require "illuminate/console": "~5.2" instead of "illuminate/console": "~4.2"

This is supposed to be resolved by v3.0 but it looks like project died. Check https://github.com/rocketeers/rocketeer/issues/542

Should be good on develop – Rocketeer 3 does not use illuminate/console anymore (it uses symfony/console directly). It also is not made anymore to be required within your project and is instead meant to be used globally (through the PHAR or composer global require) like other deployments tools


upgrade jquery to 3.3.1

Simply drop in the newest jquery in place of the older version.
Basic testing works out.
I can get a pin number, I can get the console to work when raising an exception.

This refers to https://github.com/pallets/werkzeug/issues/1181


Add SimpleAvroMessageDecoder which allows passing in Avro schema directly

For cases where users have avro encoded msg in kafka but not yet setup a schema service to fetch schema on the fly.
Contributor: fx19880617

Codecov Report

Merging #4197 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #4197      +/-   ##
============================================
- Coverage     67.16%   67.12%   -0.05%
  Complexity       20       20
============================================
  Files          1034     1035       +1
  Lines         51491    51508      +17
  Branches       7214     7214
============================================
- Hits          34585    34575      -10
- Misses        14520    14562      +42
+ Partials       2386     2371      -15

Impacted Files
Coverage Δ
Complexity Δ

.../realtime/impl/kafka/SimpleAvroMessageDecoder.java
0% <0%> (ø)
0 <0> (?)

...a/manager/realtime/RealtimeSegmentDataManager.java
50% <0%> (-50%)
0% <0%> (ø)

...r/validation/RealtimeSegmentValidationManager.java
43.33% <0%> (-38.34%)
0% <0%> (ø)

...he/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

...apache/pinot/common/metrics/ValidationMetrics.java
20.28% <0%> (-23.19%)
0% <0%> (ø)

...e/impl/dictionary/LongOnHeapMutableDictionary.java
82.22% <0%> (-6.67%)
0% <0%> (ø)

.../impl/dictionary/FloatOnHeapMutableDictionary.java
86.66% <0%> (-6.67%)
0% <0%> (ø)

...e/operator/dociditerators/MVScanDocIdIterator.java
63.63% <0%> (-3.04%)
0% <0%> (ø)

...der/HighLevelConsumerBasedRoutingTableBuilder.java
90.9% <0%> (-3.04%)
0% <0%> (ø)

...org/apache/pinot/common/metrics/MetricsHelper.java
72.5% <0%> (-2.5%)
0% <0%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d628b...578fbda. Read the comment docs.

A few thoughts on this:

Have we considered updating KafkaAvroMessageDecoder to work with this case? I do see that class being tied up quite a bit with schema registry, but I don't see why that can't be made cleaner and able to handle the case this class tries to.
This is more of a comment on KafkaAvroMessageDecoder, but I guess we could reuse the GenericDatumReader there unless the schema has changed (which should be rare and we can avoid the extra object allocation on each decode)
Depending on how important this particular implementation is, it will be good to add a test to guard against regressions.

@sunithabeeram This is a significantly simplified version of Avro decoder where schema is directly provided (not tight to kafka as well), so I would rather put it separate from the heavy used KafkaAvroMessageDecoder with all the complex schema registry logic.


(schematics documentation) Add more sources

From @MonsieurMan on January 21, 2018 19:47
Hello, I looked over the project because it seemed to me like I could use it for a project I have in mind and couldn't really find a simple dive in introduction.
Until I found the meetup presentation introducing it.
I think it should be added to the head of the readme to help people understand the package as of now, it really helped me understand quickly and I know we're going to use it for at least two projects.
If you know of any information sources you produced like this one I think you should point them out in the head of the readme or something.
Anyway, keep up the good job, I feel like front end development is getting healthier thanks to the trust you and the react community are creating !
Copied from original issue: angular/devkit#402

From @filipesilva on January 25, 2018 14:9
@hansl I think you were working on some more Schematics docs, are they available yet?

From @Toxicable on February 12, 2018 20:10
There's this here
https://blog.angular.io/schematics-an-introduction-dc1dfbc2a2b2
and the source code here is well commented on how to use schematics programtically
https://github.com/angular/devkit/blob/master/packages/angular_devkit/schematics_cli/bin/schematics.ts

@alexeagle

and the source code here is well commented on how to use schematics programtically

The link is broken on master, it's available on 6.0 though:
https://github.com/angular/devkit/blob/6.1.x/packages/angular_devkit/schematics_cli/bin/schematics.ts
As for the documentation maybe they could be written in the open ?
A lot of projects are already using schematics now anyway, so even an unfinished or unpolished documentation would be great !

Hrm. So much has changed lately... Note that I am trying to use only the Schematics CLI (not Angular CLI). schematics @schematics/angular:application tmp gives me:
Error: Could not find (undefined)
    at Object.getWorkspace (/Users/splaktar/.nvm/versions/node/v8.11.3/lib/node_modules/@schematics/angular/utility/config.js:22:15)

But https://blog.angular.io/schematics-an-introduction-dc1dfbc2a2b2 doesn't cover or mention workspaces at all. The Angular CLI has a wiki entry for workspaces, but it doesn't indicate the schematics command to create one.
Even running schematics blank my-project doesn't create a "workspace" since it creates a project for writing schematics which doesn't create an angular.json file.
schematics @schematics/angular:workspace --name=tmp gives
Error: Schematic input does not validate against the Schema: {"name":"tmp","skipInstall":false,"linkCli":false,"skipGit":false,"commit":null}
Errors:

  Data path "" should have required property 'version'.
    at MapSubscriber.registry.compile.pipe.operators_1.map.result [as project] (/Users/splaktar/.nvm/versions/node/v8.11.3/lib/node_modules/@angular-devkit/schematics-cli/node_modules/@angular-devkit/schematics/tools/schema-option-transform.js:30:27)

It's not at all clear what the version should be... but https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/workspace/schema.json#L69-L77 seems to indicate that this would be the version of the Angular CLI to use.
schematics @schematics/angular:workspace --name=tmp --version=6.2.1 finally gives me
CREATE /README.md (1020 bytes)
CREATE /angular.json (127 bytes)
CREATE /package.json (1262 bytes)
CREATE /tsconfig.json (408 bytes)
CREATE /tslint.json (2837 bytes)
CREATE /.editorconfig (245 bytes)
CREATE /.gitignore (503 bytes)

Of course this created the "workspace" in my CWD and not in tmp/ as I would have expected. So I then need to mkdir tmp && cd tmp/ and then run it again...
And finally I can run schematics @schematics/angular:application --name=tmp to create the app.

The best docs that I have found are Manfred Steyer's eBook: https://leanpub.com/angular-schematics/
It covers using the Schematics CLI (and the included schematics in @schematics/schematics) but it does not cover the details of using the schematics in an external collection like @schematics/angular (i.e. workspace, application, component, etc).

This older schematics documentation issue also has some links to resources (most are likely out of date): https://github.com/angular/angular-cli/issues/7627

Work is in progress on the official schematics documentation. I will try to post here when it is up on next.angular.io.

The first draft of the official schematics docs is about to land in Angular master: PR https://github.com/angular/angular/pull/28343 🎉

And it's available for preview here: https://next.angular.io/guide/schematics

Closing as the initial set of schematic docs is now present on AIO (https://angular.io/guide/schematics).  Further updates and improvements may be best tracked separately.  The original issue is now over 2 years old.

Additional Schematics docs improvements are being tracked in https://github.com/angular/angular/issues/29241


Review how we are displaying 'page last updated' on Social media page

Some pages on the site have a 'page last updated' note on the page. e.g.

Social media page does this by including, in just one block, which feels odd. Not least it means the numbers are not aligned appropriately.

Does this mean the other blocks might have different dates?
Related to this, Claire has asked that we make it very clear what the start date is, so that we're not just saying 'as of', but also picking up 'since when'.
I don't have a strong view on what the the best approach is - the updated date in the headline box looks good, but might look too much if it were in all blocks - and is unlikely to also work if we add a 'since when' number.

@gilesdring Like the other ticket I just tagged you in, I know you were looking at page updates yesterday, so thought I would flag this ticket to you.

[ ] Remove date from the block

Waiting to review #71 and changes across whole site so we can review how we proceed with this.

Blocked by #137


Can't resize icon in separator

When trying to make the icon bigger in a separator it just movies down on the bubble card, keeping the same size.
Phone OS: Android 14
OS in HA: 12.3
Version of bubble card: 2.0.4

Hi!
Indeed this is not working, I've just tried. I will take a look at this.
But here is a workaround:
.bubble-icon {
  --mdc-icon-size: 50px !important;
  height: 50px !important;
  width: 50px !important;
}

This issue is fixed in the new betas, you can now just add:
.bubble-icon {
  --mdc-icon-size: 50px !important;
}


Create project symlink to installed directory

@harithaIBM to test with lz4/xxHash

@IgorTodorovskiIBM does this still need to be merged?


strict: false - headers lost after row with wrong number of columns

Operating System: MacOS 10.14.6
Node Version: v12.11.1
NPM Version: 6.11.3
csv-parser Version: 2.3.1

Expected Behavior
headers created with "mapHeaders" should be used for all valid records, even for records with to many or to less columns
Actual Behavior

when a line contains more columns than headers the broken record is returned with indexed keys.
any valid line following the broken line is returned with indexed key and not with the headers

How Do We Reproduce?
https://github.com/aheissenberger/csv-parser?organization=aheissenberger&organization=aheissenberger
1 test failed

  strictNo › strictNo

  /Users/ah/SVN-Checkouts/DEV/csv-parser/test/strictNo.test.js:9

   8:     const headersLastLine = Object.keys(lines[2])
   9:     t.deepEqual(headersFirstLine, headersLastLine)
   10:     t.false(err, 'no err')

  Difference:

    [
  -   'a',
  +   '0',
  -   'b',
  +   '1',
  -   'c',
  +   '2',
    ]

Any updates on the fix for this issue?  I'm stuck trying to parse a large file and I encounter this error about 2/3 of the way through.  All the data after this error only includes the indexed keys.
Is there a workaround in the meantime?  Thanks!

It appears that when this happens and the headers are replaced by column indexes, the 'end' event is never generated.  I wrote a function to re-apply the headers once this problem is encountered, but now my code hangs when the end of the file is reached.  It never enters the code block for the .on('end') event.

I am seeing this too

Has this bug been fixed in the version of CSV parser: 2.3.3
When using the version of CSV parser: 2.3.3, this problem still occurs


sequelize-typescript 2.0.0-beta.0 + sequelize 6.3.4 associations bug

Versions

sequelize: 6.3.4
sequelize-typescript: 2.0.0-beta.0
typescript: 3.9.7

I'm submitting a ...

[x] bug report
[ ] feature request
Actual behavior:

Using the relations does not seem to work with that version, getting the error on all relations
node_modules/sequelize-typescript/dist/model/shared/model-class-getter.d.ts:2:40
2 export declare type ModelClassGetter = (returns?: void) => typeof Model;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expected behavior:

The same code is perfectly working on the version 1~ and sequelize 5~
Steps to reproduce:

You can try with the https://github.com/RobinBuschmann/sequelize-typescript-example with configuring both versions
Related code:

insert short code snippets here

already reported https://github.com/RobinBuschmann/sequelize-typescript/issues/813

Duplicate of #813.

Duplicate of #813.


Migrate code repos to Git & GitHub

Follow on from #391.
At present, the Mercurial repos are hosted at BitBucket.

v1.x has been imported as the 1x branch.

Repo migrated into master.


project count updated

Have you read the Contributing Guidelines ?
Yes
Description
Project count updated
Fixes #278

Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.

i hope this fixes the issue

i hope this fixes the issue

No project count flase it's more than 76 projects please check carefully

i rechecked again and even counted latest commit, it still goes to a total of 80

@Kushal997-das i rechecked again and even counted latest commit, it still goes to a total of 80

Then changes to recent update .

@Kushal997-das project count updated to it's latest


Fan modes don't seem to correlate to real fan mode

Right now there are 4 fan modes: Low, Medium, High, Auto
But the remote (SKR-ZSX at least) has 5 fan modes: Ultra-low, Low, Medium, High, Auto
Right now it seems that
(ESP = AC)
Low=Ultra-low
Medium=Low
High=Medium
Auto= High
So, Auto doesn't work (and i don't know if that is possible) and is actually putting the AC at the High fan mode.
It seems that Ultra-low should be added if possible and Auto should be renamed to High.
I'd love to have Auto or 3D Auto as options, but i don't know if that is actually possible and i'm definitely not a programmer.

So, Auto doesn't work (and i don't know if that is possible) and is actually putting the AC at the High fan mode.

"Fan auto is not supported via the SPI":
https://github.com/absalom-muc/MHI-AC-Ctrl/blob/master/SW-Configuration.md

I'd love to have Auto or 3D Auto as options, but i don't know if that is actually possible

not possible (unless someone discover proprietary undocumented  SPI commands for this)

If you use Home Assistant, you can rename it in Lovelace card.
https://github.com/absalom-muc/MHI-AC-Ctrl/issues/97#issuecomment-1167506725

I've set it up to use Diffuse, Low, Medium, High and Auto. This way HA and the remote will show the same mode and I get control of all 4+Auto fan speeds from HA
I just add CLIMATE_FAN_DIFFUSE in the fan speed and status sections and reshuffle the numbers and add CLIMATE_FAN_DIFFUSE to the traits.set_supported_fan_modes
I've been using this setup in an older release for over a year and it seems to work well.

I think this is great! Bit I'm not 100÷ sure how to do this too. Is this all done in the ESPHome yaml? Could you please put this in a pull request so we can all benefit from this please 🙏

should now be fixed in master :)

should now be fixed in master :)

Looking good, but I had it ordered like this so that Diffuse was slowest, which makes sense in my brain.
        case 0:
            this->fan_mode = climate::CLIMATE_FAN_DIFFUSE;
            break;
        case 1:
            this->fan_mode = climate::CLIMATE_FAN_LOW;
            break;
        case 2:
            this->fan_mode = climate::CLIMATE_FAN_MEDIUM;
            break;
        case 6:
            this->fan_mode = climate::CLIMATE_FAN_HIGH;
            break;
        case 7:
            this->fan_mode = climate::CLIMATE_FAN_AUTO;
            break;

Bonjour tout le monde.
J'ai installé l' ESP D1 mini et téléchargé le fichier yaml, placé les dossier dans le dossier ESPHOME......
connecté l'appareil dans le climatiseur, les commandes apparaissent dasn Home Assistant, mais aucune commande ne se fait.
voici le log du fichier, si quelqu'un peut m'expliquer ce qu'il se passe ..... ce serait très sympatique.
logs_lr_mhi_ac_ctrl_logs.txt

should now be fixed in master :)

Looking good, but I had it ordered like this so that Diffuse was slowest, which makes sense in my brain.
        case 0:
            this->fan_mode = climate::CLIMATE_FAN_DIFFUSE;
            break;
        case 1:
            this->fan_mode = climate::CLIMATE_FAN_LOW;
            break;
        case 2:
            this->fan_mode = climate::CLIMATE_FAN_MEDIUM;
            break;
        case 6:
            this->fan_mode = climate::CLIMATE_FAN_HIGH;
            break;
        case 7:
            this->fan_mode = climate::CLIMATE_FAN_AUTO;
            break;

I don;t know how this order is achieved to be honest, i would realy like it to be like this but the cases are not the order it is displayed I think.


Release v1.10.1

#41  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bg451 and the rest of your teammates on  Graphite


Assertion Failed in IED\SkeletonCache

This error happens when the "Sync first person gear nodes", under Settings, is toggled.
https://i.imgur.com/9jMEGjI
Skyrim Version 1.6.353. latest preview version.
No crash logs.

Should be handled now, grab RC12.
How is it performing with the background loader? Noticed anything weird?

Not that I noticed, but I didn't have much time to play the game.
Though I did notice that the stutters where gone, I had some when loading new meshes with the presets or through the script functions. Now it's running pretty smooth.
Will do some more gameplays later.

Another thing I wasn't happy with was having to load texture swaps from the main thread, RC13 should take care of that. Options are in the ini, ObjectManager section.

Alright, will test that too. Is it for items with same models but different texture sets or something else?

Yeah, that's it. Texture loads are very expensive, having to block the main loop while they load isn't great.

I noticed that, at random, the displays take some time to load, between 0.5 to 1 second. Via scripts or the UI.
I haven't noticed this in previous version. But I might be wrong, I have a kind of a budget pc. Will do more tests later.

As long as it doesn't lock the game up while it's doing it, that's fine. It could any amount of time to load and process the mesh, depending on the quality, your pc, whether the game is loading in any other assets (ied tasks are set to low priority so loads have to wait in such cases), etc...

Another possible reason why loads might take longer is if item evals wouldn't fire promptly after load/clone operations, RC14 addresses some possible issues there. If you do still find long loads seemingly without reason, it's probably something with background cloning (confirm by turning it off in the ini).

Yeah, did some tests without the cloning enabled and the displays were created immediately.
I will keep it available since it's not really an issue and it's more performance friendly.

0.5-1 sec is a bit high though, the background processor queue would shouldn't get that clogged. What settings were you testing with? "1" (default for player) bg clones only if there's a swap texture which is rare for non-armors. Asking for more info since there could actually be a problem somewhere.
On April 20, 2023 5:27:13 AM GMT+02:00, GiraPomba @.***> wrote:

Yeah, did some tests without the cloning enabled and the displays were created immediately.
I will keep it available since it's not really an issue and it's more performance friendly.
--
Reply to this email directly or view it on GitHub:
https://github.com/SlavicPotato/ied-dev/issues/41#issuecomment-1515660742
You are receiving this because you commented.
Message ID: @.***>

I don't think it was taking a full second to load a mesh. I created some displays to be enabled when some weapons were equipped and then kept cycling the weapons. The displays were enabled shortly after, some times a bit longer, some times almost immediately.
I was using default settings. I will do more tests later but I don't think it's an issue.


About modifying the skin weapon classification

I want to classify the unique skin of each weapon. Which aspect should I start from?

wat?

Try again but in english XD

I think he is asking if there is any way to have skins be on their own section, such as all the AK skins be separated from the rest such as the AWP skins, when selecting skins under the AK drop box.

oh okay that makes alot more sense and yeah there is but you would have to add them each time there is a new update