#16 add fragment

Add fragment support to client
Summary
This commit only considered the client runtime as a jumping off point. I'm hoping to get feedback on general direction since I want to make sure it fits stylistically and within the vision for the package.
Changes

Add Fragment to the Element type

This could potentially be modeled as an Element instead of its own type perhaps?
I used an opaque identifier to guarantee that a fragment can be handled easily later, but it does create some duplication

Maybe remove and just check to see if it has elements instead?

Add logic to:

Generate json
Generate string
Generate diff

Recognize Fragment within client-runtime

If the Fragment is the root, it creates a root div, but is that actually the best behavior?

Tested this in React which I though did not allow top-level fragments, but it just places children within the root element, which is kind of what creating a root div does

TODO

Integrate feedback!
Needs more testing

Additional client-runtime cases
server-runtime, components completely

Testing App
import gleam/int
import lustre
import lustre/attribute
import lustre/element.{type Element}
import lustre/element/html
import lustre/event
import lustre/ui

// MAIN ------------------------------------------------------------------------

pub fn main() {
let app = lustre.simple(init, update, view)
let assert Ok(_) = lustre.start(app, "#app", 0)
}

// MODEL -----------------------------------------------------------------------

type Model =
Int

fn init(initial_count: Int) -> Model {
case initial_count < 0 {
  True -> 0
  False -> initial_count
}
}

// UPDATE ----------------------------------------------------------------------

pub opaque type Msg {
Incr
Decr
}

fn update(model: Model, msg: Msg) -> Model {
case msg {
  Incr -> model + 1
  Decr -> model - 1
}
}

// VIEW ------------------------------------------------------------------------

fn count_fragment(model: Model) -> Element(Msg) {
let count = int.to_string(model)
let count_1 = int.to_string(model + 1)
let count_2 = int.to_string(model + 2)

element.fragment([
  html.p([attribute.style([#("text-align", "center")])], [element.text(count)]),
  html.p([attribute.style([#("text-align", "center")])], [
    element.text(count_1),
  ]),
  html.p([attribute.style([#("text-align", "center")])], [
    element.text(count_2),
  ]),
])
}

fn view(model: Model) -> Element(Msg) {
let styles = [#("width", "100vw"), #("height", "100vh"), #("padding", "1rem")]
let count = int.to_string(model)

element.fragment([
  ui.centre(
    [attribute.style(styles)],
    ui.stack([], [
      ui.button([event.on_click(Incr)], [element.text("+")]),
      count_fragment(model),
      element.fragment([
        element.fragment([html.p([], [element.text("immediate fragment")])]),
        html.p([attribute.style([#("text-align", "center")])], [
          element.text("nest fragment next"),
        ]),
        element.fragment([
          html.p([], [element.text("nest count")]),
          html.p([], [element.text(count)]),
          html.p([attribute.style([#("text-align", "center")])], [
            element.text("nest nest fragment"),
          ]),
          element.fragment([
            html.p([], [element.text("nest nest count")]),
            html.p([], [element.text(count)]),
          ]),
        ]),
      ]),
      ui.button([event.on_click(Decr)], [element.text("-")]),
      html.p([attribute.style([#("text-align", "center")])], [
        element.text("sibling fragment"),
      ]),
      element.fragment([
        html.p([], [element.text("sibling fragment")]),
        html.p([], [element.text(count)]),
      ]),
      html.p([], [element.text("Empty fragment next")]),
      element.fragment([]),
    ]),
  ),
])
}

Testing App render screenshot

Oh no! I think you might be in for some work refactoring this: it looks like you had a slightly stale fork 😅 I think you should not have too much trouble moving things but pretty much Everything changed/moved so it won't be a smooth rebase.
Using a DocumentFragment is a clever idea, I didn't even know that was a real thing!
Instead of the unique identifier I think we can just check at runtime if curr.elements !== undefined.
I'm not sure how this is going to play with keyed elements (which are new and you don't have yet), might end up being a bit of a sticking point.

Yeah, I cloned yesterday just to look and made the mistake of not pulling latest before starting 😅
Honestly, sick refactor. I actually think it simplifies things for Fragment - I think it won't need the DocumentFragment anymore. Looking at the latest now though!

Spoke too soon I think 😬 tried a couple different approaches with slightly different issues - gonna think on it and try again. Though I'll open a different PR - this one might confuse things since it's a bit outdated

Ah no! 😭 thank you for taking a look anyway! 💕


Improve error handling in Pooler and Auth classes

[ ]  Add more errors to error class to be raised
[ ]  Update Auth class to raise errors instead of just returning nil if something goes wrong
[ ]  Handle raised errors in command class

@johnmccabe sorry to make some additional changes on you...but I'm planning on making the Pooler and Auth class raise error specific messages when things go wrong instead of just returning nil. This should hopefully make things a lot easier to handle as a consumer when something goes wrong.

An example of what that's going to look like will be here: https://github.com/briancain/vmfloaty/commit/05e9d5a0cccfc4b4639b9a08e2578f3a256a8572
And then consumers of those classes can use the rescue methods in ruby for all the various vmfloaty/errors that I'll add.

Sounds good, I'll add handling later this evening.

@johnmccabe - I'll let you know when the gem is released, probably later today :)


Introduce linter config

Tsk, tsk, tsk. We are missing a good linter config.

@Skarlso  https://cuelang.org/docs/integrations/go/ ❓

I'm not following your question Robert I'm afraid.

Applying it to the other controllers as well.

Linter for product controller will be added after https://github.com/open-component-model/mpas-product-controller/pull/66 is merged.


Types missing in 6.7.3

Describe the bug
Types folder is missing in 6.7.3
Expected behavior
im able to import types
Additional context
6.7.2 is okay

@Inoir thanks for reporting this; it's due to CI changes that we made this week. I reverted the CI changes to further review them first. 6.7.4 should be fine now


Clean up the English language phrasing

Fixed spelling and awkward phrasing to make it read better.

Thanks :)


add router example

Pull Request Test Coverage Report for Build 1173

0 of 0   changed or added relevant lines in 0 files are covered.
29 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.2%) to 63.114%

Files with Coverage Reduction
New Missed Lines
%

core/options.go
2
76.79%

core/loadbalancer/session_stickiness_strategy.go
2
86.44%

core/handler/transport_handler.go
3
21.95%

core/config/key_generator.go
3
28.85%

core/registry/index.go
4
78.75%

core/lager/logrotate.go
15
33.94%

Totals

Change from base Build 1172:
-0.2%

Covered Lines:
4998

Relevant Lines:
7919

💛  - Coveralls

README.md to show how to use


feat: use AWS IAM role instead of IAM user

Non-blocking question: Do we need a role-duration-seconds value, per the original article that captures this work?

Non-blocking question: Do we need a role-duration-seconds value, per the original article that captures this work?

Looking at build-push-ecr, my guess is "no"


Import-Excel:Use value instead of Text when reading cells to preserve types.

Thanks, nice update.


Support modules and npm

It would be great if this library were wrapped in a module.  Examples in numerous JS libraries show how to support global, CommonJS and AMD in the same file.  This is a good read:
http://ifandelse.com/its-not-hard-making-your-library-support-amd-and-commonjs/
Also would be nice to have a package.json to support npm.  Don't have to publish on npm registry anymore as npm supports referencing a git repo.  I would be happy to provide a pull request.

+1

:+1:

:+1:


Inability to Canister Hydrogen and Compressed Hydrogen

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[X] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?
Hydrogen and compressed hydrogen cannot be canned in canisters, and compressed hydrogen even cannot be put in barrels.
Steps to reproduce
No response
Additional context
No response
Log file
No response

Not having hydrogen canisters is intended. Not going to change this.

I fixed the missing barreling recipe though, thanks for the report.


Error: "if seg_pair_slice['gt'] is not None and isinstance(seg_pair_slice['gt'][0], list): IndexError: list index out of range"

Issue description
I tried segmenting an image and received the following error:
>>> nii_lst, target_lst = imed_inference.segment_volume(path_model, input_filenames, options=options)
2021-07-23 19:57:12.815 | INFO     | ivadomed.config_manager:_display_differing_keys:150 - Adding the following keys to the configuration file
2021-07-23 19:57:12.815 | INFO     | ivadomed.config_manager:_display_differing_keys:152 -

2021-07-23 19:57:12.816 | WARNING  | ivadomed.inference:segment_volume:384 - fname_roi has not been specified, then the entire volume is processed.
2021-07-23 19:57:12.954 | INFO     | ivadomed.inference:segment_volume:423 - Loaded 6 axial patches of shape [512, 512].
 Please describe the device and system you're working on, including the OS type and its version (e.g. Windows, macOS, Linux).
-->

### Installed packages

 Output of pip freeze

Thank you @mathieuboudreau for reporting this.
I ran some tests and found a bug in ivadomed related to the config of the model. In the example test model I provided you, there are no pre-processing transforms (ex: crop, resample). This is unusual enough that it cause the error you described.
For the time being, I'm going to re-train a test model with pre-processing so you can continue your implementation. I'll let you know when it's ready.
Now for the error, here is what I found:

The error happens when running the command segment or when calling directly the segment_volume function.
The error happens when there are no pre-processing transforms in the model config like crop and resample (my test model only included NormalizeInstance which is applied later in the pipeline)
Normally with pre-processing transforms, seg_pair_slice['gt'] = [] before the apply_preprocessing_transforms in the loader, but seg_pair_slice['gt'] = None after the function.
In the case where self.prepro_transforms = None (like with my model), seg_pair_slice['gt'] = [] is returned "as-is" by the function here.
Because the seg_pair_slice['gt'] is an empty list [] instead of None, seg_pair_slice['gt'][0]  is out of range causing the error in the if condition here.

I suggest we change the if condition from:
if seg_pair_slice['gt'] is not None and isinstance(seg_pair_slice['gt'][0], list):
to:
if seg_pair_slice['gt'] and isinstance(seg_pair_slice['gt'][0], list):
where if seg_pair_slice['gt'] will return False for both seg_pair_slice['gt'] = None and seg_pair_slice['gt'] = [].
We should also add a test in test_segment_volume.py to cover this usecase (all current tests include pre-processing).

thank you for catching this bug @mariehbourget and for testing @mathieuboudreau 🙏


Hook up deletion for MIAA

Hooking up the deletion button for MIAA and updating PG and MIAA to use the same deletion request prompt.

Also improved the error message when an HttpError occurs since the default message wasn't very useful (would just say HTTP request failed)

Coverage remained the same at 35.077% when pulling a7ed5c86f9f1bb615c7b933852f8041027cd2932 on chgagnon/promptForDeletion into 95107f1f611df05f85e1cc7122f088f4d9cc6aec on main.


[BUG] 'Address already in use' when restart after SocketIOClient.disconnect() and SocketIOServer.stop()

start server and a client
socket IO connected
call SocketIOClient.disconnect() and SocketIOServer.stop(), then close server
start server again, then get the following issue:

Exception in thread "main" io.netty.channel.unix.Errors$NativeIoException: bind(..) failed: Address already in use

wait for around 1 minute, restart again successfully

The issue happens from 1.x to latest 2.0.11.
Thanks

the issue happens from 1.x to latest 2.0.11

Does the solution from the issue help?

REUSE_PORT solves your problem, try this code when you start server
  val config = Configuration()
  config.setPort(port)
  val sockConfig = SocketConfig()
  sockConfig.setReuseAddress(true)
  config.setSocketConfig(sockConfig)
  val server = SocketIOServer(config)

it works, thank you!


PowerToys Run info buttom not showing tool tip

Hey!
Just wanted to let you guys know, that the small button that you can hover over for a tooltip, is not displaying anything,
Running newest version.
If I click it the right way (takes 5ish tries) I can get it to show it.

Hi @ZhanToO - could you take a screenshot of the button? Do you mean one of the command buttons that appear on hover?

@ZhanToO we need the actual version number.  A screenshot would be helpful as well where you're trying to hover, i just tried and worked so we need more detail here.
Secondary question, what graphic card are you using?  nVidia?


Loader keeps loading

Getting please wait loader continuously nothing happens payu_checkoutpro_flutter: ^1.0.0 . Also not getting any error logs.

same issue

Did you find a solution? @secanonm @san-sitesurface

@san-sitesurface @secanonm @chrisbinsunny Please share steps to repro and screenshot to<EMAIL_ADDRESS>

@san-sitesurface @secanonm @chrisbinsunny Please share steps to repro and screenshot to<EMAIL_ADDRESS>
just copy your example and debug it
its never be load payment page
Logs :
Flutter : 3.3.5
payu_checkoutpro_flutter: 1.0.0
Android Version : 11

@san-sitesurface @secanonm @chrisbinsunny Please share steps to repro and screenshot to<EMAIL_ADDRESS>
@umangarya336 I tried the same code from the example app.
The same parameters when passed in Postman, shows a webpage saying "Redirecting to a new page". When passed on the app it shows nothing but a spinning loader. No error logs are being shown also. Even though it showed an error when I used the wrong hash.
I tested by setting the environment to test.

I will fixed it for payu if you @umangarya336 guys ready ??

@chrisbinsunny, @secanonm , @san-sitesurface
Kindly add the HashService class to your project. Inside the HashService class, you need to set your salt value on this variable "merchantSalt".
Add the below line of code inside the generateHash() method :-
  @override
  generateHash(Map response) {
    // Pass response param to your backend server
    // Backend will generate the hash which you need to pass to SDK
    // hashResponse: is the response which you get from your server
    Map hashResponse = HashService.generateHash(response);
    _checkoutPro.hashGenerated(hash: hashResponse);
  }
PFA :- HashService.dart class
//Add flutter pub add crypto plugin to use following class in your app.
//Remove this plugin when you implement the salt at your server..
import 'package:crypto/crypto.dart';
import 'dart:convert';
class HashService {
static const merchantSalt = "1b1b0";//TODO: Add Salt
static const merchantSecretKey = "";//TODO: Add Merchant Secrete Key - Optional
static Map generateHash(Map response) {
var hashName = response[PayUHashConstantsKeys.hashName];
var hashStringWithoutSalt = response[PayUHashConstantsKeys.hashString];
var hashType = response[PayUHashConstantsKeys.hashType];
var postSalt = response[PayUHashConstantsKeys.postSalt];

var hash = "";

if (hashType == PayUHashConstantsKeys.hashVersionV2) {
  hash = getHmacSHA256Hash(hashStringWithoutSalt, merchantSalt);
} else if (hashName == PayUHashConstantsKeys.mcpLookup) {
  hash = getHmacSHA1Hash(hashStringWithoutSalt, merchantSecretKey);
} else {
  var hashDataWithSalt = hashStringWithoutSalt + merchantSalt;
  if (postSalt != null) {
    hashDataWithSalt = hashDataWithSalt + postSalt;
  }
  hash = getSHA512Hash(hashDataWithSalt);
}
//Don't use this method, get the hash from your backend.
var finalHash = {hashName: hash};
return finalHash;

}
//Don't use this method get the hash from your backend.
static String getSHA512Hash(String hashData) {
var bytes = utf8.encode(hashData); // data being hashed
var hash = sha512.convert(bytes);
return hash.toString();
}
//Don't use this method get the hash from your backend.
static String getHmacSHA256Hash(String hashData, String salt) {
var key = utf8.encode(salt);
var bytes = utf8.encode(hashData);
final hmacSha256 = Hmac(sha256, key)
.convert(bytes)
.bytes;
final hmacBase64 = base64Encode(hmacSha256);
return hmacBase64;
}
static String getHmacSHA1Hash(String hashData, String salt) {
var key = utf8.encode(salt);
var bytes = utf8.encode(hashData);
var hmacSha1 = Hmac(sha1, key); // HMAC-SHA1
var hash = hmacSha1.convert(bytes);
return hash.toString();
}
}
Note:- For static hash generation purposes, you should need to use the HashService class. Once you can move to production then you should need to create the dynamic hashes from the server. Inside the generate hash already written the steps.
  // Pass response param to your backend server
  // Backend will generate the hash which you need to pass to SDK
  // hashResponse: is the response which you get from your server
// To generate local Hash use following code in your app,
[2:07 pm] Rishabh Jaiswal
Kindly add the HashService class to your project. Inside the HashService class, you need to set your salt value on this variable "merchantSalt".
PFA :- HashService.dart class
Add the below line of code inside the generateHash() method :-
  @override
  generateHash(Map response) {
    // Pass response param to your backend server
    // Backend will generate the hash which you need to pass to SDK
    // hashResponse: is the response which you get from your server
    Map hashResponse = HashService.generateHash(response);
    _checkoutPro.hashGenerated(hash: hashResponse);
  }
Note:- For static hash generation purposes, you should need to use the HashService class. Once you can move to production then you should need to create the dynamic hashes from the server. Inside the generate hash already written the steps.
  // Pass response param to your backend server
    // Backend will generate the hash which you need to pass to SDK
    // hashResponse: is the response which you get from your server
Please feel free to reach out if you have any questions to<EMAIL_ADDRESS>

Why you make this so complicated for beginners,
You can predefined all class in your package so it takes less time to configure

It's better we use unofficial package who provide better support

@rajansh09 @umangarya336 I get the payment screen when using the test HashService class. But the thing is, I already have a hash returned from the backend server. How to use this hash in the app? Can you provide some example code for production apps? I really need this to complete the project.

Local hash service added in the sample app for testing only. Don't use it for production.

Hi! my screen is also stuck on please wait message!
The generateHash(Map response) method is called 3 times when checkoutPro.openCheckoutScreen is being called, and all of the 3 times the response is different hashNames hashName: get_sdk_configuration, hashName: payment_related_details_for_mobile_sdk, hashName: signature, hashType: V2 .
which hash should be generated on backend? and even if I use all hashes hashGenerated() function it is still stuck on loading screen.
I have also tried this locally(used your eg. code), the hashes are same as from the backend, but result is still the same. I do not know what is going wrong here.

not work with PHP dynamic hash still stuck on the loading page
my hash
 {
payment_hash: d2477d29f674bb3f01ffc01a384a31105699a867e75c22af1a..........,
get_merchant_ibibo_codes_hash: 1dc4618d0546295cc5830dff8adeeeb9626......,
vas_for_mobile_sdk_hash: 3c6755e5c4779b94cef.....,
emi_hash: 8fde98b3e38996261e5920941caa16fed9e6cfc1390bb9ff75fc4a.......,
payment_related_details_for_mobile_sdk_hash: 8ce23914ef0a499a4fcc5aa201da8b1790a49c8f8b76e2......, verify_payment_hash: cb7484701fd47d470c328b2ed3c20......,
send_sms_hash: 0609032e904b6b540617b3521546.........
}

<?PHP

$output = HashService::generateHash($_POST['hash']); // pass your response map here
echo header('content-type: application/json');
echo json_encode($output);

class HashService {
  const merchantSalt = ""; // Add your merchantSalt here
  const merchantSecretKey = ""; //optional

  public static function generateHash($response) {
    $hashName = $response["hashName"];
    $hashStringWithoutSalt = $response["hashString"];
    $hashType = $response["hashType"] ?? null;
    $postSalt = $response["postSalt"] ?? null;

    $hash = "";

    if ($hashType == "V2") {
      $hash = self::getHmacSHA256Hash($hashStringWithoutSalt, self::merchantSalt);
    } else if ($hashName == "mcpLookup") {
      $hash = self::getHmacSHA1Hash($hashStringWithoutSalt, self::merchantSecretKey);
    } else {
      $hashDataWithSalt = $hashStringWithoutSalt . self::merchantSalt;
      if ($postSalt != null) {
        $hashDataWithSalt = $hashDataWithSalt . $postSalt;
      }
      $hash = self::getSHA512Hash($hashDataWithSalt);
    }
    $finalHash = [$hashName => $hash];
    return $finalHash;
  }

  public static function getSHA512Hash($hashData) {
    $bytes = utf8_encode($hashData); // data being hashed
    $hash = hash("sha512", $bytes);
    return $hash;
  }

  public static function getHmacSHA256Hash($hashData, $salt) {
    $key = utf8_encode($salt);
    $bytes = utf8_encode($hashData);
    $hmacSha256 = hash_hmac("sha256", $bytes, $key);
    $hmacBase64 = base64_encode($hmacSha256);
    return $hmacBase64;
  }

  public static function getHmacSHA1Hash($hashData, $salt) {
    $key = utf8_encode($salt);
    $bytes = utf8_encode($hashData);
    $hmacSha1 = hash_hmac("sha1", $bytes, $key); // HMAC-SHA1
    $hash = $hmacSha1;
    return $hash;
  }
}

?>

please add this code to your flutter pub documentation
Thank You

Hi! my screen is also stuck on please wait message! The generateHash(Map response) method is called 3 times when checkoutPro.openCheckoutScreen is being called, and all of the 3 times the response is different hashNames hashName: get_sdk_configuration, hashName: payment_related_details_for_mobile_sdk, hashName: signature, hashType: V2 .
which hash should be generated on backend? and even if I use all hashes hashGenerated() function it is still stuck on loading screen.
I have also tried this locally(used your eg. code), the hashes are same as from the backend, but result is still the same. I do not know what is going wrong here.

I am also facing the same issue. I get payment page while using HashService.generateHash(response), but the hash is not same even if the passed parameters are same. Hash works in Postman.
And as @aarvyhimanshu01 said, generateHash(Map response) method is called 3 times returning 3 different responses and hashNames.
I am really confused here. It'll so much better if can show a full code example.

Here is a comprehensive guide on how to seamlessly integrate PayU's payment gateway into your Flutter app, which you can explore and benefit from: https://sudhanshupatil.medium.com/integrating-payu-payment-gateway-in-your-flutter-app-c3849433b32e

@ravitejaavv @chrisbinsunny @sidhu-patil   were you able to fix this? Facing same issue. was using native android earlier and we have a backend service in place to generate hash but that returns string instead of a object that is expected in _checkoutPro.hashGenerated method. generate hash method is getting called twice and on second instance it is returning invalid hash. working perfectly on native android.

https://sudhanshupatil.medium.com/integrating-payu-payment-gateway-in-your-flutter-app-c3849433b32e
You can read this article

@sidhu-patil  followed everything but getting {errorCode: 5019, errorMsg: Invalid Hash.} for payment_related_details_for_mobile_sdk

@sidhu-patil  also generateHash is getting called multiple times does that mean i'll have to generate multiple hashes?

can you please share your code/ github repo link


Upload remote paths during index creation or full cluster upload

Description
This is one of the tasks to achieve https://github.com/opensearch-project/OpenSearch/issues/12589 as part of the feature request https://github.com/opensearch-project/OpenSearch/issues/12567. This is only an increment step to conclude the optimised prefix path work proposed in the feature request.
In this PR, we are getting following things done -

Upload index remote path during index creation as json file.
Upload index remote path if the previous cluster uuid is not known as json file. This is specifically required for the migration case from document to segment (with remote store) replication type.
Calling out that the index path file is uploaded with no header or footer, and also is saved as json text.
UTs and ITs is in the process of being added.

Related Issues
Resolves #12661

Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
[x] Commits are signed per the DCO using --signoff
~[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)~
~[ ] Public documentation issue/PR created~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report
Attention: Patch coverage is 53.29670% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 71.51%. Comparing base (b15cb0c) to head (723ead9).
Report is 161 commits behind head on main.

Files	Patch %	Lines
.../remote/RemoteUploadPathIndexCreationListener.java	18.75%	63 Missing and 2 partials ⚠
...a/org/opensearch/index/remote/RemoteIndexPath.java	79.59%	3 Missing and 7 partials ⚠
...arch/gateway/remote/RemoteClusterStateService.java	87.87%	1 Missing and 3 partials ⚠
server/src/main/java/org/opensearch/node/Node.java	50.00%	2 Missing and 1 partial ⚠
...epositories/blobstore/ChecksumBlobStoreFormat.java	78.57%	1 Missing and 2 partials ⚠
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

In the process of adding more UTs and ITs.

❌ Gradle check result for 4d26b59: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - https://github.com/opensearch-project/OpenSearch/issues/13046

@vikasvb90 for reviewing commit relating to changes in RemoteTransferContainer and BlobStoreFormat ->  https://github.com/opensearch-project/OpenSearch/pull/13150/commits/9d8073f21e467f121342518b495e341651f45f6f.

@sachinpkale for reviewing the changes done from remote store index path context.

@ashking94 Changes to avoid data integrity when expected checksum is null look good to me.

❌ Gradle check result for 7ef0d1a: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - https://github.com/opensearch-project/OpenSearch/issues/13240. It has been fixed recently. I will this branch rebase from main.

UNSTABLE

❕ Gradle check result for 5f28f61: UNSTABLE

TEST FAILURES:

      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test - https://github.com/opensearch-project/OpenSearch/issues/13307

❕ Gradle check result for a58d712: UNSTABLE

TEST FAILURES:

      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test

Auto backport failed, raising manual backport.


After tab close, tabs width does not restore automatically unless hovered by mouse

Windows Terminal version
1.14.1861.0
Windows build number
10.0.22000.795
Other Software
No response
Steps to reproduce

Set tab width mode to equal.
Open a number of tabs so that tab width starts to shrink.
Start closing tabs without using a mouse, for example, with Ctrl+D or by typing "exit". Close tabs so that only a few tabs left.

Expected Behavior
Tab width restores to the default.
Actual Behavior
Tabs stay small. If you hover a mouse over the tab bar, tab width restores.

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #9822 for more discussion.
/dup #9822


Per-response RSpec metadata

Is it possible to define per-response RSpec metadata, e.g. for using VCR? It's possible by wrapping each response into its own describe block, but that creates an unnecessary level of nesting:
require 'swagger_helper'

RSpec.describe 'My API' do
  path '/v1/{x}' do
    get 'Resolve an X' do
      tags 'X'
      produces 'application/json'
      parameter name: :x, in: :path, schema: {
        type: :string
      }

      describe "Success", vcr: { cassette_name: "rswag_resolve_x_success" } do
        response '200', 'Successful result' do
          schema type: :object,
                 properties: {
                   x: { type: :string }
                 }
          let(:x) { "xxx" }

          run_test!
        end
      end

      describe "Fails", vcr: { cassette_name: "rswag_resolve_x_all_fails" } do
        response '503', 'Service unavailable' do
          let(:x) { "xxx" }
          run_test!
        end
      end
    end
  end
end

@hannesstruss - please checkout #82 and let me know if this will resolve your issue? Thanks

@domaindrivendev yes, looks great, thanks!

@domaindrivendev @hannesstruss how can I use it? with a response? Is there an example you can share?

I am looking for an example like that too

This here worked for us:
require 'swagger_helper'

RSpec.describe 'My API' do
  path '/v1/{x}' do
    get 'Resolve an X' do
      tags 'X'
      produces 'application/json'
      parameter name: :x, in: :path, schema: { type: :string }

      response '200', 'Successful result', vcr: { cassette_name: 'success' } do
        schema type: :object, properties: { x: { type: :string } }
        let(:x) { 'xxx' }

        run_test!
      end

      response '503', 'Service unavailable', vcr: { cassette_name: 'fails' } do
        let(:x) { 'xxx' }

        run_test!
      end
    end
  end
end

Be sure to configure VCR with configure_rspec_metadata!, see https://relishapp.com/vcr/vcr/v/2-2-5/docs/test-frameworks/usage-with-rspec-metadata for more on this.

Is it possible to call VCR like this? I've tried the same way you guys did and it just don't use vcr
`require 'swagger_helper'
RSpec.describe 'Orchestration API', type: :request, swagger_doc: 'v1/swagger.json' do
let(:operation_attributes) do
{
workflow_key: 'process',
id: '11',
decision_variables: { score: { value: 400 } }
}
end
path '/api/v1/orchestration/operations/start' do
post 'Start a new process' do
tags 'Operations'
consumes 'application/json'
parameter name: :operation_attributes, in: :body, type: :object
VCR.use_cassette 'api/v1/orchestration/operations/start/ok' do
response '200', 'OK' do
schema  type: 'orchestration/operation',
properties: {
data: {
type: :object,
items: {
'reference-id': { type: :string },
'process-instance-id': { type: :string },
'workflow-id': { type: :string },
'workflow-name': { type: :string },
'discarded': { type: :boolean },
'status': { type: :string },
'delete-reason': { type: :string },
'start-at': { type: :string },
'end-at': { type: :string },
'parent-operation-id': { type: :string }
},
relationships: {
activities: {
data: []
}
}
}
}
run_test!
end
end
end
end
end`


4.0.0 was published with development dependencies in dependencies

4.0.0 was released with the following dependencies:
{
  "dependencies": {
    "@vitejs/plugin-react": "^2.0.1",
    "typescript": "^4.7.4",
    "vite": "^3.0.9",
    "vite-plugin-dts": "^1.4.1"
  }
}

All of these are development dependencies for building the package for publishing, and are not used in the production code - severely bloating node_modules for React users who haven't made the switch to Vite yet.

Oh nice catch! I'm actually dealing with a power outage funny enough, tentative power restore is today or tomorrow... so I will get this fixed this weekend at the latest,
I would 100% accept a PR if you're able to do it prior.


Fix issues showing UnhandledPromiseRejectionWarning in tests

See https://travis-ci.org/studentinsights/studentinsights/builds/350053666#L2445
These tests maybe should be failing?  Or we should setup/teardown in a way that makes these not show in the test output if these aren't actual problems.

stale


String_Split issue

I'm currently using version 0.2.4 of the provider and I encounter issues creating multiple users for the same database.
The error message is the following :
Error: unable to create user USER: mssql: There is already an object named 'String_Split' in the database
Looking at the previous issues and PRs, I saw that race condition can occurs if trying to create multiple users & login on the same database and it was supposedly fixed with #24.
Rolling back to 0.2.3 solved the problem

May I ask on which compatibility level for the SQL database you are? You can find that out by running select name, compatibility_level FROM sys.databases on your database.


Add missing changed line highlighting

At end of https://go.dev/doc/tutorial/random-greeting , we had message, err := greetings.Hello("Gladys")
This step of tutorial changes that line to messages, err := greetings.Hellos(names) but this line is not highlighted on the website right now

signed cla

Hi there,
I fixed it already in https://github.com/golang/website/pull/98. I'm waiting for getting reviewed though.


add/move prometheus routes to default http port

What type of enhancement is this?
User experience
What does the enhancement do?
The simulated prometheus http endpoint occupies a dedicated port (default to 4004). To reduce exported ports we can consider add a route rule for 4004 on our default http port (default to 4000) or just merge these two ports.
Implementation challenges
No response

hi, i would like to help with it, plz assign

hi, i would like to help with it, plz assign

Thx


[Feature request] np.random.choice analogue

TF has no analogue to np.random.choice function that chooses random element from tensor (optionally according to provided probabilities). It's especially useful in RL problems when you use epsilon-greedy exploration strategy.
What related GitHub issues or StackOverflow threads have you found by searching the web for your problem?
These two solve the problem using tf.multinomial, but maybe it will be convenient to include tf.random_choice in TF API?
It could be implemented through tf.multinomial , for example.

Ah, actually there is also no way to generate random samples for length of batch_size when it's not specified until runtime.
Btw, using RandomStreams in theano allows to do that.

I'm not aware of anyone working on this.  We'd happily take a contribution!  (It likely should go into contrib as the first cut.)

@concretevitamin I will prepare pull request. Is it okay to implement this using tf.multinomial or should I implement new op for this?

I think implementing in terms of existing ops is fine.
@aselle - do you have a suggestion on where to put such the numpy counterparts in contrib?  If not, I'm tempted to say it's okay to go into random_ops.py.

(Also /cc @ebrevdo to see if tf.contrib.distribution has any files that could host this.)

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

Here's an implementation for uniform sampling with replacement along a specific axis (untested).
def random_choice(a, axis, samples_shape=None):
    """

    :param a: tf.Tensor
    :param axis: int axis to sample along
    :param samples_shape: (optional) shape of samples to produce. if not provided, will sample once.
    :returns: tf.Tensor of shape a.shape[:axis] + samples_shape + a.shape[axis + 1:]
    :rtype:

    Examples:
    >>> a = tf.placeholder(shape=(10, 20, 30), dtype=tf.float32)
    >>> random_choice(a, axis=0)
    <tf.Tensor 'GatherV2:0' shape=(1, 20, 30) dtype=float32>
    >>> random_choice(a, axis=1)
    <tf.Tensor 'GatherV2_1:0' shape=(10, 1, 30) dtype=float32>
    >>> random_choice(a, axis=1, samples_shape=(2, 3))
    <tf.Tensor 'GatherV2_2:0' shape=(10, 2, 3, 30) dtype=float32
    >>> random_choice(a, axis=0, samples_shape=(100,))
    <tf.Tensor 'GatherV2_3:0' shape=(100, 20, 30) dtype=float32>
    """

    if samples_shape is None:
        samples_shape = (1,)
    shape = tuple(a.get_shape().as_list())
    dim = shape[axis]
    choice_indices = tf.random_uniform(samples_shape, minval=0, maxval=dim, dtype=tf.int32)
    samples = tf.gather(a, choice_indices, axis=axis)
    return samples

This worked for me. It returns both the sampled values and their indices in the original tensor:
def random_choice(x, size, axis=0, unique=True):
    dim_x = tf.cast(tf.shape(x)[axis], tf.int64)
    indices = tf.range(0, dim_x, dtype=tf.int64)
    sample_index = tf.random.shuffle(indices)[:size]
    sample = tf.gather(x, sample_index, axis=axis)

    return sample, sample_index

    def random_choice(a, size):
        """Random choice from 'a' based on size without duplicates
        Args:
            a: Tensor
            size: int or shape as tuple of ints e.g., (m, n, k).
        Returns: Tensor of the shape specified with 'size' arg.

        Examples:
            X = tf.constant([[1,2,3],[4,5,6]])
            random_choice(X, (2,1,2)).numpy()
            -----
            [
              [
                [5 4]
              ],
              [
                [1 2]
              ]
            ]
        """
        if isinstance(size, int) or np.issubdtype(type(a), np.integer) or (tf.is_tensor(a) and a.shape == () and a.dtype.is_integer):
            shape = (size,)
        elif isinstance(size, tuple) and len(size) > 0:
            shape = size
        else:
            raise AssertionError(f"Unexpected size arg {size}")

        sample_size = tf.math.reduce_prod(size, axis=None)
        assert sample_size > 0

        # --------------------------------------------------------------------------------
        # Select elements from a flat array
        # --------------------------------------------------------------------------------
        a = tf.reshape(a, (-1))
        length = tf.size(a)
        assert sample_size <= length

        # --------------------------------------------------------------------------------
        # Shuffle a sequential numbers (0, ..., length-1) and take size.
        # To select 'sample_size' elements from a 1D array of shape (length,),
        # TF Indices needs to have the shape (sample_size,1) where each index
        # has shape (1,),
        # --------------------------------------------------------------------------------
        indices = tf.reshape(
            tensor=tf.random.shuffle(tf.range(0, length, dtype=tf.int32))[:sample_size],
            shape=(-1, 1)   # Convert to the shape:(sample_size,1)
        )
        return tf.reshape(tensor=tf.gather_nd(a, indices), shape=shape)

X = tf.constant([[1,2,3,4,5,6]])
print(random_choice(X, 2).numpy())
-----
[2 5]

X = tf.constant([[1,2,3],[4,5,6]])
print(random_choice(X, (2,2,1)).numpy())
-----
[[[5]
  [4]]

 [[1]
  [2]]]

tf.random.uniform_candidate_sampler

This worked for me. It returns both the sampled values and their indices in the original tensor:
def random_choice(x, size, axis=0, unique=True):
    dim_x = tf.cast(tf.shape(x)[axis], tf.int64)
    indices = tf.range(0, dim_x, dtype=tf.int64)
    sample_index = tf.random.shuffle(indices)[:size]
    sample = tf.gather(x, sample_index, axis=axis)

    return sample, sample_index

This is very useful, thank you, but note that the unique parameter s not used.


feat: add url to triggers

Affected Components

[ ] New Features
[ ] Bug Fixing
[x] Types
[ ] Tests
[ ] Docs
[ ] Other

Style

[x] Go code is formatted with go fmt

Notes for the Reviewer

Add run URL to check and group triggers

@danielpaulus when you have a minute could you review this 🙏 ?


Team Meeting - January 29 2024 @ 7:00 PM

Revied work to be done by the demo. Added/assigned related issues


[Request] Diminish based on loot taken previously

I don't like the idea of being punished with diminished scrap even if I die before I can get anything to the ship

Duplicate of #3


Bring master changes on image_v2.6.0

Codecov Report

Merging #1140 into image_v2.6.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           image_v2.6.0    #1140   +/-   ##
=============================================
  Coverage         48.02%   48.02%
=============================================
  Files                25       25
  Lines              4548     4548
  Branches            758      758
=============================================
  Hits               2184     2184
  Misses             2308     2308
  Partials             56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec2a6a...c604217. Read the comment docs.


Simulating Self Driving Cars

Hi,
I want to contribute to the ML capsule through a project I have been working on that revolves around cars to detect lanes to travel and other existing traffic regulations by using Deep Learning and Computer Vision respectively. I am truly excited to bring about this new project to your existing set of ML marvels.
Regards,
Aditi Chauhan

go for it @comrade-buck

Assign this issue to me

Hi @Rutikab12
I’m interested in taking on the Simulating Self-Driving Cars task. I plan to utilize reinforcement learning and computer vision techniques to create a robust simulation environment. This will help in understanding the vehicle's decision-making process and improving its navigation capabilities.


Add benchmarks for schema generation with custom validators

Change Summary
This PR expands the benchmark suite by adding "schema generation" benchmarks in the following cases:

Models with custom field validators (before, wrap, after, and plain modes).  Every mode has it's own benchmark
Models with custom model validators (before, wrap and after modes). Every mode has it's own benchmark

I am open to suggestions. A benchmark mixing both model and field custom validators might be valuable.
Related issue number
fix #9711
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@sydney-runkle Hi! I submitted a new PR.
I split the benchmarks into one for each field/model validation mode.
Let me know is I'm missing something! Thanks

I've opened https://github.com/pydantic/pydantic/pull/10276 which consolidates things some with parametrized tests, as well as clarifying which tests use decorated functions vs annotations for validators.
We can probably use similar patterns for serialization, if you're interested in submitting another PR!

I've opened #10276 which consolidates things some with parametrized tests, as well as clarifying which tests use decorated functions vs annotations for validators.
We can probably use similar patterns for serialization, if you're interested in submitting another PR!

Coool, nice enhancements in #10276!
I will be indeed adding more benchmarks. As you said, applying the same patterns for serialization should be straightforward. Thanks!


[WIP] Add toppra plugin

First iteration on the toppra plugin. Implements the plugin + adds conversation functions between drake and moveit classes. At the moment toppra is not able to solve the problems given by the demo. I'd like to fix that in a follow-up PR  and maybe you spot something in your review that might cause the issue

@kamiradi I cannot tag you as a reviewer but do you mind reviewing this PR?


Everything wrong after upgrade

Ive run the upgrade to Almalinux8 for several times now and the last time ive been succesfull i thought. Turns out every service that makes it a server had been disabled. So HTTPD, NGINX, MYSQL everything. Even when i try to start the services up i get errors on starting the services up because of configs not working while it worked before the upgrade. Examples below.
DB query failed: SQLSTATE[HY000] [2002] No such file or directory

-- Unit httpd.service has begun starting up.
aug 31 12:03:14 host.SERVERNAME.nl httpd[35133]: httpd: Syntax error on line 353 of /etc/httpd/conf/httpd.conf: Syntax error on line 6 of /etc/httpd/conf.d/zz010_psa_httpd.conf: Syntax error on line 26 of /etc/httpd/conf/plesk.conf.d/webmails/gh49.nl_webmail.conf: Could not>
aug 31 12:03:14 SERVERNAMEsystemd[1]: httpd.service: Main process exited, code=exited, status=1/FAILURE
aug 31 12:03:14 host.SERVERNAME.nl systemd[1]: httpd.service: Failed with result 'exit-code'.
-- Subject: Unit failed
-- Defined-By: systemd
-- Support: https://access.redhat.com/support
--
-- The unit httpd.service has entered the 'failed' state with result 'exit-code'.
aug 31 12:03:14 host.SERVERNAME.nl systemd[1]: Failed to start The Apache HTTP Server.
-- Subject: Unit httpd.service has failed
-- Defined-By: systemd
-- Support: https://access.redhat.com/support
--
-- Unit httpd.service has failed.
--
-- The result is failed.
aug 31 12:03:14 host.SERVERNAME.nl plesk_saslauthd[26778]: No such user<EMAIL_ADDRESS>in mail authorization database
aug 31 12:03:14 host.SERVERNAME.nl plesk_saslauthd[26778]: failed mail authentication attempt for user<EMAIL_ADDRESS>(password len=8)
aug 31 12:03:14 host.SERVERNAME.nl postfix/smtpd[26976]: warning: unknown[<IP_ADDRESS>]: SASL LOGIN authentication failed: authentication failure

2023-08-31 11:54:41 0 [ERROR] Plugin 'gssapi' init function returned error.
2023-08-31 11:54:41 0 [Note] Recovering after a crash using tc.log
2023-08-31 11:54:41 0 [Note] Starting crash recovery...
2023-08-31 11:54:41 0 [Note] Crash recovery finished.
2023-08-31 11:54:41 0 [Note] Server socket created on IP: '::'.
2023-08-31 11:54:41 0 [ERROR] Fatal error: Can't open and lock privilege tables: 'mysql.user' is not of type 'TABLE'

Im really wondering of there are any people that succesfully upgraded without jumping in and out from the loop and just by running the script. We have several Plesk servers on CentOS but for me the script never worked properly and had to revert to a snapshot because it just took too long.

Could you please provide a feedback archive. It could be retrieved by calling ./centos2alma --prepare-feedback

Ive reverted to a snapshot so cant get that information. I would have to do the upgrade again.

I would have to do the upgrade again.
You can generate a feedback archive even if you haven't started the upgrade. Maybe I will be able to find something specific in it that cause the problem.

ill try to do that asap thanks

Let me close the issue for now. Feel free to reopen it if you have any new information.


"Persona>Photos" does not work

Here is the console error. Could you take a look at it?
10/24/16 11:59:22.685 AM Neutral (Sketch Plugin)[1435]: TypeError: null is not an object (evaluating 'imagesFileNames. count')
line: 153
sourceURL: /Users/---/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Content Generator Sketch Plugin/CG.sketchplugin/Contents/Sketch/Persona/Photos/Neutral.js
column: 35

This is not working for me either. Male, Female or Neutral, all of them do nothing when selected.

I got the problem too.

You are using old plugin. Please update


[BUG][WEBJS] - Internal server error when trying to send video using sendVideo endpoint.

Describe the bug
We are getting internal server error when trying to send video using sendVideo endpoint.
Version
Get the WAHA version by calling GET /api/version
{
  "version": "2024.11.2",
  "engine": "WEBJS",
  "tier": "PLUS",
  "browser": "/usr/bin/google-chrome-stable"
}

Steps
To Reproduce Steps to reproduce the behavior:

Open swagger url: /#/:outbox_tray:%20Chatting/ChattingController_sendVideo
Change session and chatId, and send the example json.
See error

Expected behavior
Should send video to the given chatId.
Requests - Responses
Request:
You can use example json.
Response:
{
  "statusCode": 500,
  "timestamp": "2024-11-06T18:06:36.360Z",
  "exception": {
    "stack": "TargetCloseError: Protocol error (Runtime.callFunctionOn): Target closed\n    at CallbackRegistry.clear (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/common/CallbackRegistry.js:73:36)\n    at CdpCDPSession._onClosed (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/CDPSession.js:101:25)\n    at #onClose (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Connection.js:167:21)\n    at WebSocket.<anonymous> (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/node/NodeWebSocketTransport.js:49:30)\n    at callListener (/app/node_modules/ws/lib/event-target.js:290:14)\n    at WebSocket.onClose (/app/node_modules/ws/lib/event-target.js:220:9)\n    at WebSocket.emit (node:events:520:28)\n    at WebSocket.emitClose (/app/node_modules/ws/lib/websocket.js:272:10)\n    at Socket.socketOnClose (/app/node_modules/ws/lib/websocket.js:1341:15)\n    at Socket.emit (node:events:520:28)\n    at TCP.<anonymous> (node:net:338:12)\n    at TCP.callbackTrampoline (node:internal/async_hooks:130:17)",
    "message": "Protocol error (Runtime.callFunctionOn): Target closed",
    "name": "TargetCloseError",
    "cause": {
      "stack": "ProtocolError\n    at <instance_members_initializer> (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/common/CallbackRegistry.js:94:14)\n    at new Callback (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/common/CallbackRegistry.js:98:16)\n    at CallbackRegistry.create (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/common/CallbackRegistry.js:23:26)\n    at Connection._rawSend (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/Connection.js:90:26)\n    at CdpCDPSession.send (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/CDPSession.js:66:33)\n    at #evaluate (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:360:50)\n    at ExecutionContext.evaluate (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/ExecutionContext.js:275:36)\n    at IsolatedWorld.evaluate (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/cdp/IsolatedWorld.js:100:30)\n    at CdpFrame.evaluate (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Frame.js:341:43)\n    at CdpFrame.<anonymous> (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/util/decorators.js:104:27)\n    at CdpPage.evaluate (/app/node_modules/puppeteer-core/lib/cjs/puppeteer/api/Page.js:807:43)\n    at WebjsClient.sendMessage (/app/node_modules/whatsapp-web.js/src/Client.js:956:44)\n    at WhatsappSessionWebJSPlus.sendVideo (/app/dist/plus/engines/webjs/session.webjs.plus.js:56:30)\n    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)",
      "message": "",
      "name": "ProtocolError"
    }
  },
  "request": {
    "path": "/api/sendVideo",
    "method": "POST",
    "body": {
      "chatId"<EMAIL_ADDRESS>      "file": {
        "mimetype": "video/mp4",
        "filename": "video.mp4",
        "url": "https://github.com/devlikeapro/waha/raw/core/examples/video.mp4"
      },
      "reply_to": null,
      "asNote": false,
      "caption": "Just watch at this!",
      "session": "dev"
    },
    "query": {}
  },
  "version": {
    "version": "2024.11.2",
    "engine": "WEBJS",
    "tier": "PLUS",
    "browser": "/usr/bin/google-chrome-stable"
  }
}

working on the fix

Fix in 2024.11.3!


1.10.x : User with blog permissions can't manage a blog

User with blogs pernissions can't manage a blog.The blog menu item is missing on admin menu

I haven't looked into this in detail but I think that https://github.com/OrchardCMS/Orchard/pull/6994 fixes this. It changes the BuildMenu to check Permissions.MetaListOwnBlogs and also makes some other permissions based improvements.

On which branch this is issue already fixed? I did not checked on the dev branch. For now the dev branch does not works with sql server. There is error during a setup.

Its an active PR, it hasn't been accepted yet.


Traitor HUD/Progress bars persist above people's heads and are visible through walls

This effect remains until the person is viewed again.
Video: https://www.youtube.com/watch?v=lWcVB27qrPY

(Extra info: This happened in raspberry station with PVS disabled)

Traitor HUD was with PVS enabled.

superseded by #2825 and  #2824


Log messages not showing in logs in vercel

Bug Report
Current Behavior
I am trying to use the app.info.log with a Vercel serverless function, but the message is not showing up in Vercel.
export default (app) => {
   ...

   if (!config?.perform) {
        app.log.info('issue.opened: config.perform is false');
        return;
    }

    ...
};

Expected behavior/code
I would expect that the log message shows up in the logs.
Environment

Probot version(s): 13.0.1
Node/npm version: Node v21.6.2 / npm 10.2.4

How exactly does vercel get the logging? Do they provide a custom logging function?
Or do they simply read from stdput and stderr

Hi @eddysims,
Can you check if #2011 fixes your issue?


Help with Vonk.Facade.Relational, R4, .Net 8.0 Parameter Detection Not Working

Discussed in https://github.com/FirelyTeam/firely-net-sdk/discussions/2745

Originally posted by charlejc March 26, 2024
I'm trying to update to .Net 8.0 and Vonk.Facade.Relation 4.7.1 and other Vonk 4.7.1 packages. I've implemented the QueryFactory patern and inherited code like the example below.
My problem is that the parameter detection does not seem to be working and the only override function that is being called is the one:
`
public class ObservationQueryFactory : RelationalQueryFactory<myObservation, myRelationalQuery>, IResourceSpecificQueryFactory
{
public override myRelationalQuery AddValueFilter(string parameterName, TokenValue value)
{
// This code is not being called....
if(String.Compare(parameterName, VonkConstants.ParameterNames.Id, StringComparison.OrdinalIgnoreCase) == 0
|| String.Compare(parameterName, "identifier", StringComparison.OrdinalIgnoreCase) == 0)
{
return PredicateQuery(observation => observation.Id == value.Code);
}
....
}
	public override myRelationalQuery<myObservation> AddValueFilter(string parameterName, RawValue value)
	{

// This code is called instead :-( ....
throw new NotImplementedException();
}
}
`
An error is being swallowed that complains that:
System.Security.Cryptography.XmlSerializers, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL cannot be found.
I'm not sure if that is the cause of the problem. I'm assuming the webhost is trying to read the specification.zip file that is present in the output directory and process monitor shows it being read, but not many parameters are found when reading the xsd files present in the zip.
Any help or pointers would be greatly appreciated.
Thanks!

Hi @charlejc, happy to help here. Could you indicate if you are currently have a Firely Server license or if you are trying out Firely Server as part of a trial version?
In Version 4.7.1, .NET 8 is not supported. Firely Server v4.x only runs on .NET 6. We are currently migrating to .NET 8. This explains the underlying exception that you are seeing. Could you run it on .NET 6 and see if you are having the same issues?
Thanks!

I do have a Firely Server license.
Same problem with .net 6.0
Here's where the issue is deriving from:

What I haven't figured out yet is how the IEnumerable enumerable is populated. Something is not configured correctly and it isn't obvious to me, yet, what needs to be done to fix it.
I also got two new swallowed errors with .net 6.0:

and
System.IO.FileNotFoundException
HResult=0x80070002
Message=Could not load file or assembly '...\bin\Debug\net6.0\System.Security.Cryptography.Algorithms.XmlSerializers.dll'. The system cannot find the file specified.
Source=
StackTrace:

@charlejc Thank you, do you have access to the support desk via our JIRA system? Or support can then figure step by step out what's going wrong here. If you don't have access to Firely Server ticket system, would you mind sending an email to<EMAIL_ADDRESS>Could you also share any startup logs from Firely Server and a copy of your appsettings?

I sent an email requesting access to the support desk.
Attached is the appsettings and a copy of the console output that was generated during web host start up.
I've replaced any sensitive text with an ellipsis ( ... )
appsettings.json
console output.txt

Yes, please!


Add API for registering a custom format generator

Since the OpenAPI Specification allows you to use any format you want, we should add a top-level API for registering custom format generators like we do for custom validators.
Originally requested in #98.

What is the ETA for this?

Like most of json-refs and sway, I work on it in my free time and I've not had much of that lately.  I am desperately trying to get them released ASAP but no guarantees on an ETA.  Contributions welcome.


fix: add proper tabindex when filterable

Currently, when a Select is filterable you cannot reach the filter via tab control. This PR will add a proper tabindex to the inputs.

You can open select by pressing enter if it's focused.
I make lazy focus intentionally. Is the behavior problematic?

Can you rebase it? I want to see vercel preview.

@07akioni here you go 😊

Preview

Normal select's tab focusing is broken.

Hm, what's not working for you? I can still focus the tab and press enter to open it.

Tab focus this

@07akioni sorry for the issue I missed that before. I think now it works fine and whenever a select is filterable you can tab properly and can start immediately typing.

After esc is pressed in filterable select, the select box should still be focused.

I think maybe provide a prop to let user choose whether to focus input immediately is better.

Okay, sure. Any suggestion for the name of the prop? 😊

Okay, sure. Any suggestion for the name of the prop? 😊

Maybe focus-input-when-filterable? Not quite sure.


Hash logs inside Noir

Currently we inject the logs hashes and lengths in TS here. This was a hack to get the logs working when Noir was too buggy.
Blocked by https://github.com/noir-lang/noir/issues/1889.

Details: We currently can't use slices (or the wrapper Vec) because of https://github.com/noir-lang/noir/issues/1889. Since we need to accumulate the logs preimages in Context before hashing them all at the end the only other alternative is preallocating a large array and then when calling Context.finish copy the populated part of array to a new array of exact size and hash that copy. To achieve this we would need to use generics to set the size of the target array and this would mean that whoever would call finish would have to manually set this size. This seems impractical to me so I decided to postpone addressing this issue for when we can use the Vec type.

Not blocked anymore :)

Not blocked anymore :)

Cool, cool.
Anyway, it makes sense to wait for this issue  to be resolved before tackling this.

Closing as it's tackled


Update Gradle and a couple of plugin versions

Just to stay up to date

Test coverage reduction is #828


Exclude params in a test

Thanks for this gem, it's been a huge help to us!
We can't test a lot of our 400-status use cases because we're testing the case of a missing parameter. If we don't define the parameter, we get a NoMethodError trying to run the test.
We have in some cases worked around it by setting the parameter to nil, but that's not testing the case that we're looking for.
Is there a way to do this? Or would this be something you might add in the future?

We have in some cases worked around it by setting the parameter to nil, but that's not testing the case that we're looking for.

It is fine, you should be happy with this solution


Should be staticfiles_storage and not default_storage

default_storage can actually be completely different to staticfiles_storage method (for example use s3 for default but local on the static files). Its and easy fix, I will add a pull request.

0.1.12 has been released


Create best-practices / requirements for shell scripts

In order to have a reliable CI and easy-to-use test infrastructure, we need to install best-practices / requirements for scripts. We can create a document that should be referred to during code reviews and used to fix up existing scripts. For instance we can take from (and credit, of course), the following:

http://www.davidpashley.com/articles/writing-robust-shell-scripts/
https://google.github.io/styleguide/shell.xml

+1 would also be nice if this was enforced by tools so contributors don't need to read separate documents to add new tests effectively.

Closing as we have moved away from Bash scripts for tests.


Remove Jyaasa

Jyaasa is rebranded to Gurzu

@PradipCodes Not sure why you closed the PR but I have removed Jyaasa. Thanks!


Move luminance effect into its own class and use new buffers system

This PR moves the luminance effect code out of effect.h/cpp and into it's own class and in doing so uses the new custom data system and uniform/framebuffer caching.

Thanks!


Exception generating Class code

Exception:

v_class = GLE_IF_ECS_CONSTANTS
Note: Requires draft code off pull #20 although issue is caused in original code.

DEPRECATED
use https://github.com/abaplint/abaplint-abap-backend instead

can you point me to the dependency generator of backend? I did not find it

class https://github.com/abaplint/abaplint-abap-backend/blob/master/src/deps/zcl_abaplint_deps_find.clas.abap finds the dependencies

The finding is not the problem. Generating to sources is what i am missing and committing them like in the deps abap.

Found the program ... issue is the same. Will close this one and create a new in the other repo.


Question spring cloud gateway RPS so small

Question
spring cloud gateway RPS are small, not as large as the RPS of a single application. I've optimized a lot of parameters, but RPS is always around 170, and the RPS of a single application is around 2000. How can I optimize it

There is not much to say based on the little information you have provided.  It might be good to provide us the 2 apps you were using for your test as well as a way to execute them as you have so we can replicate what you are seeing.

There is not much to say based on the little information you have provided. It might be good to provide us the 2 apps you were using for your test as well as a way to execute them as you have so we can replicate what you are seeing.

I use a simple program and then use zuul to invoke it. I use spring-cloud-starter-netflix-zuul, version 2.0.1. RELEASE. The container uses undertow. The parameters are as follows:

but i find it no work No matter how I adjust parameters.


cli vault creation is added to dendron.yml but not dendron.code-workspace

Please select the area your Bug applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Describe the bug
Creating a vault via CLI is added to dendron.yml but not dendron.code-workspace. This means that the vault won't show up in the VSCode workspace/editor unless added properly.
This looks like some changes would need to happen potentially in:

packages/dendron-cli/src/commands/vaultCLICommand.ts
packages/engine-server/src/workspace/service.ts: async createVault
packages/engine-server/src/workspace/service.ts: async addVault

To Reproduce
Steps to reproduce the behavior:
# Create vault via CLI
# npx dendron-cli vault --vault my-new-vault --vaultPath 'repos/my-new-vault'
dendron-cli vault --vault my-new-vault --vaultPath 'repos/my-new-vault'

The above command creates a vault, and adds it properly to dendron.yml, but does not add it to dendron.code-workspace as a listed vault. Opening the workspace in VSCode will now show the vault, unless manually adding it to dendron.code-workspace.
Expected behavior
The new vault should be added also to the dendron.code-workspace file:
Example before creating vault
...
  "folders": [
      {
          "path": "repos/my-old-vault",
          "name": "my-old-vault"
      }
  ],
...

Example after creating vault
...
  "folders": [
      {
          "path": "repos/my-new-vault",
          "name": "my-new-vault"
      },
      {
          "path": "repos/my-old-vault",
          "name": "my-old-vault"
      }
  ],
...

Desktop (please complete the following information)

OS: Pop!_OS 21.04
IDE: Codium v1.56.0
Dendron VSCode extension version: 0.52.0
dendron-cli version: 0.52.1

Thank you for the detailed bug report. We'll investigate and come up with a fix!

this should be fixed in v54 of Dendron. please post here if not, otherwise this issue will auto close in 3 days


Development: Create example parachains build on substrate

ref: https://github.com/paritytech/polkadot/issues/5

Yeah. There is also the following issues which is basically the same thing. ;-)
https://github.com/w3f/Web3-collaboration/issues/11

closed in favour of #11


Low AP_unseen in 65/15 setting

Hi, I ran the below code to reproduce following README without any modification except errors regarding the file path.
./tools/dist_train.sh configs/zsi/65_15/train/zero-shot-mask-rcnn-BARPN-bbox_mask_sync_bg_65_15_decoder_notanh.py 4

./tools/dist_test.sh configs/zsi/65_15/test/gzsi/zero-shot-mask-rcnn-BARPN-bbox_mask_sync_bg_65_15_decoder_notanh_gzsi.py work_dirs/zsi/baseline/65_15/latest.pth 4 --json_out results/gzsi_65_15.json

python tools/gzsi_coco_eval.py results/gzsi_65_15.segm.json --ann data/coco/annotations/instances_val2014_gzsi_65_15.json --gzsi --num-seen-classes 65 --types segm

However, AP_unseen is 10.11 while the reported performance is 13.60.
Should I need to modify some parts to achieve the performance?
Average Precision  (AP) @[ IoU=0.40      | area=   all | maxDets=100 ] = 0.349
Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.322
Average Precision  (AP) @[ IoU=0.60      | area=   all | maxDets=100 ] = 0.282
Average Recall     (AR) @[ IoU=0.40      | area=   all | maxDets=100 ] = 0.663
Average Recall     (AR) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.615
Average Recall     (AR) @[ IoU=0.60      | area=   all | maxDets=100 ] = 0.543
seen ap:  37.383471000890715
unseen ap:  10.107219674297248
seen recall:  63.77426534005841
unseen recall:  51.7247463728316
seen unseen HM ap:  15.91229557716799
seen unseen HM recall:  57.12096841188887

Thank you.

Hi, there is a mistake in Table 4 of our CVPR version paper and we have corrected it in our arxiv version (https://arxiv.org/abs/2104.06601).
13.6 ap is for GZSD ( see Table 3), and 10.11 unseen ap and 51.72 unseen recall in your results if for GZSI, which is close to our results (see Table4 in our arxiv version).
Sorry that the previous version misled you.

Thanks a lot!


fix: properly define the subpath ./types in exports

Should fix
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './types' is not defined by "exports"

This PQ made me remember what is going on. Thanks!
We should only allow type imports via /types. This PQ is not going in the right direction.
Instead, the plugin needs to be fixed. It crashes because it uses export * from while it should only use export type * from. https://github.com/grammyjs/hydrate/pull/25 Fixes that.


IAP Metadata Watcher: Poll instead of watch

Poll Metadata instead of watching it
Fetch keys hourly, instead of once every 12 hours
Fix bug that caused the request loop to run only once

Yes, of course:
Watching only detects changes in the Metadata, and the previous implementation only updated the file on changes. Thus there'd be no way to detect if e.g. the Metadata watcher stopped working while IAP was on, which could lead to spurious 403s if IAP were then turned off before the watcher started working again. The fail open mechanism I implemented in #68 ensures the Metadata watcher is still working by checking the modification time of the state file. This polling-based implementation updates the file with enough frequency to keep the fail-open mechanism from activating. Now, you could implement this by watching with a short timeout, then in the timeout handler calling the Metadata and updating the file if IAP  were still on; but at that point, just polling seems preferable to me for it's simplicity, though you potentially pick up a few seconds of delay for changes to propagate to application behavior (which are probably actually negligible unless the nginx module is configured to be checking the state very frequently).
Lmk if you want to have a quick meeting to discuss in more detail.

Thanks for the clarification..


chore: bdd-gh-1588561145 to 0.0.1

chore: Promote bdd-gh-1588561145 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[BUG] TAlEdit is not correct initialize VISIBLE on open form

Hi,
i have a FMX application con any forms, i'm trying converting frm FMX To new Skia / Alicinoe ( TALEdit ),
i have found a bug with TAlEdit it is not correct initialize VISIBLE when form is opened.
My easy example:
Form FMX -> 1 Tab Control , 3 Tab Item inside,
on the TAB n.1 Empty
on the TAB n.2 insert a TALRectangle WITH  VISIBLE FALSE and inside a TALEDIT with Background color and TExt = 'AAAAA'
on the TAB n.3 insert a TALEDIT WITH VISIBLE FALSE and Background color and TExt = 'BBB'
At runtine, when open form ( TAB Page n.1 ) you can see the n. 2 edit ( Bug ) text AAAAA     BBBBBB.
Target OS Compile: "Windows 32" and "Android 64"
Device: Samsung S24 U Android 14
Delphi 12.2
Mauro

Corrected in the last release. please update the repository


Updated code with portworx spec file

Signed-off-by: indirakalagara<EMAIL_ADDRESS>Updated code to take inputs from portworx spec file / base64 encoding of spec file.

@seansund @rich-ehrhardt @triceam  Need access to create secrets for AWS Cluster variables AWS_CLUSTER_USERNAME / AWS_CLUSTER_PASSWORD and PORTWORX_SPEC


Add an 3D image preview of the currently printing file

For those of us without a camera, it would be nice to see a 3d preview of the file that is currently printing and maybe an image of the current layer being printed etc?

The Thumbnail should provide an image of the thing you will print.
Do you see it?

I realized that for the thumbnail to work I had to change the port in the integration settings - it defaulted to port 80.

but adding 3D model, I am not sure how we would do this in Home Assistant.
It's a cool feature, but unless someone codes it, I won't try to implement it in the sort term

The Thumbnail should provide an image of the thing you will print.
Do you see it?

no, I do not see a thumbnail.

@wifiuk can you send me a copy of your logs
https://moonraker-home-assistant.readthedocs.io/en/latest/support/logs.html#go-full-debug-log

@marcolivierarsenault did you ever resolve wifiuk's thumbnail? I am having the same issue with no thumbnail. I changed the port in the integration to 7125 and 80 and neither work. Also, my current layer is always off by like 3 or 4. Seems to start in the negatives.


refactor: github actions

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behaviour?
You can also link to an open issue here.
What is the new behaviour?
...
Does this PR introduce a breaking change?
What changes might users need to make in their application due to this PR?
Other information:
Please check if the PR fulfills these requirements:

[ ] Tests for the changes have been added
[ ] Docs have been added / updated
[ ] Relevant Changeset has been added

Changes unknown
when pulling fba3052c4e629ade827b472c97bc7fd14a89e7d9 on refactor-actions
into ** on master**.


Add new topic: Reusing devcontainers within pipelines

Pull Request Template
What are you trying to address
This is an addition of a new sections "Pros and cons of dev containers within pipelines" that has been a topic of discussion for a number of crews (Alpine, Zenith, Team Curie), so we thought it could be valuable for all of ISE to document all of our previous experiences into this one document.
Before making this PR, I ran this propsoal by @TessFerrandez.
Co-contributors: @tomconte @vjrantal

LGTM 😄


[Enhancement] Link Utilities: Remove [Missing Link] tags when link added

Is your feature request related to a problem? Please describe.
If a user runs 'Tag Missing Links' and then uses bookmarklet/paste from clipboard (or possibly add link; have not tested) to add the links, they then have to take an extra step of opening the game details to delete the tag.
Describe the solution you'd like
When adding a link from bookmarklet or clipboard (or 'add link' if it's affected), the extension should check for matching 'missing link' rules. If there are any, remove the tag from the game.
Describe alternatives you've considered
Simply deleting the tag in Library Manager afterwards kind of works, but it makes it harder when adding links in multiple batches.
Additional context
n/a

That's strange! It should already do that. I'll look into it!

For replication:
Name Pattern is IGDB and URL Pattern is https://www.igdb.com/*

I just had the chance to test it and it works for me. But there is a known bug, that the tags aren't refreshed in the detail view after the action, but they actually have changed in the background. When you switch to another game and back you should see the change and the Missing-link-tag should be gone. Can you please check if that works for you, too?
Unfortunately it seems I can't do much about that. It seems to be a bug in Playnite itself. I added a new FAQ page to the wiki for that bug.

I think figured out the issue: I had the 'tag missing links on metadata update' option turned off so it wouldn't keep re-tagging the rare game that isn't on IGDB.


correct my name

dev db dump is years old, screenshots using my user account are painful

Also tests do not rely on this DB dump, they build a clean DB?

That will still generate another ~60MB file in the git-tree :/

Brings up an interesting question on whether we should try to restore from a DB Dump, or use Factory Boy to generate known seed data for development purposes, since the test suite does generate its own data.
If this is desirable for better developer experience, that's something we could pursue, but it does continue the drift between the "real" database schema in prod vs what we create in dev/test.

Brings up an interesting question on whether we should try to restore from a DB Dump, or use Factory Boy to generate known seed data for development purposes, since the test suite does generate its own data.
If this is desirable for better developer experience, that's something we could pursue, but it does continue the drift between the "real" database schema in prod vs what we create in dev/test.


Better error handling for the frontend

Currently a lot of errors just dump the Python stack trace in HTML to the user. We should make some more specific error types, and prettier error pages for them.

We are no longer dumping the stack trace on the user, but our error pages remain opaque, generic, and ugly.


143 edit page link

link has been moved to layout.js so any type of doc can show link
logic changed so the default frontmatter bool value for showing link is the same value as in siteconfig

@PhilippeduPreez I guess PR #158 is now redundant?

Can you also link your PRs to relevant issues, so that they can be closed automatically after merge ? :) Here is a short info on that:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@PhilippeduPreez you can find out why checks are failing by clicking at Details on the right-hand side. You basically have to look at error logs and try to figure out what went wrong and why. Let me know if you don't find answers there. I'll be happy to help.


The command autoscale deployment should provide a flag for providing the maximum, average memory utilization

What would you like to be added:
At this time, an end user can only provide the maximum, average CPU utilization using the --cpu-percent. The API version autoscaling/v2 allows for define a memory resource metric for memory as well. The ask is to introduce a flag for this metric, e.g. --memory-value. For example, the --memory-value=500Mi would generate the following manifest representation:
spec:
  metrics:
  - type: Resource
    resource:
      name: memory
      target:
        type: AverageValue
        averageValue: 500Mi

Why is this needed:
Align the imperative capabilities for creating a Horizontal Pod Autoscaler with the declarative capabilities. As a user, I am somewhat confused why I don't have the option to provide memory thresholds.

Since you can do this using yaml and kubectl apply, we'd like to hold off on adding any new flags for particular settings.
A kubectl plugin might be be a good place to start, if you want to implement this, and if it is something generally helpful as a plugin, then we can see about implementing it in kubectl.

Thanks for the info! Sounds good to me. Maybe it would be good idea to deprecate the autoscale command completely and force users into the declarative approach.

Thanks for the info! Sounds good to me. Maybe it would be good idea to deprecate the autoscale command completely and force users into the declarative approach.

You make a good point though.  Something like autoscale is a pretty niche command, and if it doesn't support enough use cases, should it even exist as a command and be deprecated instead?
In the past, we have seen commands like kubectl run explode with a large number of flags, making it difficult to maintain and ultimately difficult for users to understand and use effectively.  It also causes problems when you consider version skew because some flags may refer to functionality that is either too old or too new for the server you are talking to, again adding complexity.  So for these reasons, our go-to answer has been to use kubectl apply as much as possible.
For something like this command though, perhaps the reasoning would be different, since it has a very particular use.  I can add it to the agenda for the next sig-cli meeting for group discussion.

@bmuschko We talked about it at the meeting today, and decided this would be a useful flag to add.
As I mentioned before, our "default" answer for new flags is no, in order to avoid adding too many flags, but in this case, being able to autoscale based on memory is consistent with the type of functionality already provided by --cpu-percent, so it makes sense for this new flag to be added.
I'm not too familiar with HPA, but it looks like it supports both "value" and "percent" for both CPU and memory.
Do you need to scale based on the memory value or percent?  I'm thinking for consistency, the new flag should be --memory-percent, since the command currently operates on CPU percent.
Do you need to be able to scale based on memory value?  If so, then I'm guessing that would mean adding a --memory flag and then also a --cpu flag (to keep them consistent)  :sweat_smile:

/triage accepted

Looking at the API documentation, you can have the following permutations.
Average utilization in percentage (cpu or memory):
type: Resource
    resource:
      name: cpu
      target:
        type: Utilization
        averageUtilization: 80

Average utilization as fixed-point representation of a number (cpu or memory):
type: Resource
    resource:
      name: cpu
      target:
        type: AverageValue
        averageValue: 1.5

Value as fixed-point representation of a number (cpu or memory):
type: Resource
    resource:
      name: cpu
      target:
        type: Value
        value: 1

If you wanted to cover all options by CLI flag, you'd have to introduce 6 of them overall. You'd probably also want to rename (plus deprecate) the existing one e.g. from --cpu-percent to --cpu-utilization-percent.
--cpu-percent
--memory-percent
--cpu-average-value
--memory-average-value
--cpu-value
--memory-value

You think it would be worth it maintaining all of those flags? After thinking this through, I still think it may be better to deprecate the autoscale command altogether.

can I work on it?

SIG cli meeting details can be found on the community page
Also you can assign the issue to yourself after the author's reply using /assign

ok /assign

/assign


Help wanted

Hi looking at this its reallygood I wouldlike some help on a couple of pieces. A little background I have a clone pcb an with it being a lottery on wether you get genuine parts or even a working one I decided for a little knowledge and a personal project to make a fresh pcb with genuine parts or better, I'm not a professional so I've been taking my time  I've seen another schematic that seems much more populated but I can't trust it as pin 23 on the PIC18F458 doesn't go to pain 1 on MCP2551. The 3 LED's in your schematic layout are missing LED connections red for 5v power? 1 on pin 25 of the mcu? The last would be K-line connection? Is this correct? There's no connection with the voltage regulator what capacitors Should I use? Would I be correct in assuming its 12V from the OBD plug and converts down to 4.5v?  on my china clone 1 of the capacitors are one of the electrolytic capacitors is this correct? Could you help me with connecting the relays correctly I'm a little confused.
Thank you for your help

fake pic and also fake fw

And also dont use this schematic is wrong!!


Polymer app not loading on iOS 8

I have a Polymer app that is refusing to load properly on iOS 8 Safari. It works on all other browsers/devices including iOS 8 Chrome and iOS 7 Safari. I have produced a much smaller app which exhibits the same problem, although this one does seem to load OK sometimes.
On startup, the static parts of the page are displayed but none of the Polymer elements appear and the app remains non-functional. It seems to be something to do with the call to initPolymer. My main function looks like this:
void main()
{
   window.alert("Inside main");
   var dirtycheckingzone = initPolymer();
   window.alert("initPolymer called: dirtycheckingzone = $dirtycheckingzone");
   // Run the whole app in the dirty checking zone so that observables are always updated in the DOM
   dirtycheckingzone.run(() {
      window.alert("Inside dirtycheckingzone.run");
      Polymer.onReady.then((e){
         window.alert("Polymer Ready");
      });
   });
}
On iOS 8 Safari, only the first alert ever gets displayed. Therefore it seems the problem must be somewhere in initPolymer. However, I have no idea how to debug this. I have tried remote debugging to iOS Safari from the Mac version of Safari. However, I can't seem to get this to break early enough and refreshing the page generally causes the Web Inspector to hang, There is nothing however in the Console that looks suspicious.
You can seem to get this smaller app to run by clicking "Refresh". However, if you close the tab and browse to the page again in a new one, it fails again.
You can try the page at:
http://www.autograph-maths.com/deepquerytest/deepquerytest.html
The project is attached. Ignore the functionality of the app. It was primarily created for another test.

Attachment:
DeepQueryTest2.zip (1.62 MB)

This issue has been moved to dart-lang/polymer-dart#343.


Creator 2023 03 01 preview conversion

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

@mikekistler Creator as a service has many APIs. Conversion is one of those features with a set of APIs, so if we make this change , to make it consistent across all the other Creator APIs, we should handle it was a bigger change for all Creator services. That's not something that we have capacity to do right now.

I think the path at line 129 should be "/conversions:create" to comply with our action operations pattern.
https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#performing-an-action
All the other changes look good.

@yuqi2 It looks to me like Creator is already using the actions path pattern, e.g.
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/maps/data-plane/Creator/preview/2023-03-01-preview/tileset.json#L275

@heaths Could you give this a quick review and if all looks good approve and merge?


Adds packager configuration to support windows platform

This pull request is a prerequisite to enabling the react-native-windows platform extension.
In the Resolver component, we need to add 'windows' to the list of platforms that are allowed in the DependencyGraph.  We also need to add 'react-native-windows' (the name of the Windows platform extension NPM module) to the providesModuleNodeModules option. This allows the node_module folder check in the DependencyGraphHelper from node-haste to be bypassed for *.windows.js files in the Windows NPM package.
For good measure, I also included a change to blacklist.js to ensure .windows.js files are ignored when the packager is parameterized on a platform.

By analyzing the blame information on this pull request, we identified @davidaurelio and @cpojer to be potential reviewers.

Looks reasonable

Really looking forward to try that on my Surface Pro 👍

Mostly looks good to me. Generally we don't want to add entries to providesModuleNodeModules but it probably makes sense to make an exception solely for RN Windows. The thing we don't want is for this array to grow into "RN for ". cc @vjeux

I'm also open to any re-architecture suggestions @ide.  I think it would be great to see a configuration based approach, where the end user specifies which platforms are enabled (both here and in my node-haste PR: https://github.com/facebook/node-haste/pull/70) and which node_modules directories are allowed in haste.  Eliminating as much of this static config as possible.

Yep I think that's the plan. But RN Windows is the one project that we might want to make a temporary exception for.

Tests passed, let's shipit :)
@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

providesModuleNodeModules is going away.

but it probably makes sense to make an exception solely for RN Windows.

and every other platform coming along? Can we come up with better ideas, please?

Just talked to @davidaurelio - we should eventually remove providesModuleNodeModules but for now we can keep this PR.

Ok, I tried to come up with something that might scale better:
what if the packager reads react-native-<platform>/package.json, and we read a mapping from there? "react-native" is already taken. Let’s assume "react-native-override".
It could look like this:
{ "name": "react-native-windows",
  "react-native-override": {
    "View": "lib/View.js",
    "Text": "lib/Text.js" } }

I presume there is some implied convention here that the DependencyGraph would use the  part of react-native- as the module map platform key?  What if a particular package contained multiple platform implementations for whatever reason?  Maybe it just needs to be more verbose...
{
  "name" : "react-native-windows",
  "react-native-overrides" : {
    "windows" : {
      "Text": "lib/Text.windows.js"
    },
    "foo" : {
      "Text": "lib/Text.foo.js"
    }
  }
}

What if a particular package contained multiple platform implementations for whatever reason?

Do you have a specific scenario in mind? I’d like to keep it simple/separated, but maybe that’s to simplistic?

and every other platform coming along?

No, only Microsoft. We've rejected at least one other PR of this nature in the past. I just think that with the effort behind RN Windows and the fact that it's the primary focus of a couple engineers, it's the one time we should make a (temporary) exception.

I just have mixed feelings, because making this exceptions means it’s going to stay. I wanted to kill that feature in the next weeks, but that’s not going to happen now.

@davidaurelio, totally agree that this is not the cleanest approach, and I'd also like to see something better.  It would be great for someone with much more experience with the packager to put a PR together, this was just the quickest way to unblock publishing a windows package for now, and it didn't seem much different from the 'web' platform stuff that's sprinkled throughout the packager but doesn't have any local backing code.
I think this change can and should definitely be temporary.


Auto-flag Partial Disclosure

As an IAO analyst
I want a page to be automatically flagged as 'Partial Disclosure' when I redact part of the page
so that I can save time when redacting a package

Assumptions & Scope
What are the assumptions for this story?
In AXIS when an analyst does a redaction, the 'Partial Disclosure' flag is automatically added to the page.
In FOI Mod, when an analyst makes a redaction, the 'Partial Disclosure' flag will be automatically added.
What is IN scope?
Auto flag 'Partial Disclosure' when a page is partially redacted.
What is NOT in scope?
The 'Withheld in Full' auto-flag is covered in #3487.
The "In Progress' auto-flag is covered in #
Acceptance Criteria
Scenario 1: Automatically add 'Partial Disclosre' flag when analyst makes a redaction on a page

GIVEN the IAO analyst has drawn a red redaction around text
AND the IAO analyst has selected any section of the Act in the FOIPPA modal (i.e., not the Blank Code)
WHEN the analyst clicks
AND clicks the 'Select Code(s)' button
THEN the 'Partial Disclosure' page flag will automatically be added to the page
AND the 'Partial Disclosure' icon will be displayed beside the page in the 'Organize By' pane

Scenario 2: Automatically remove 'Partial Disclosure' flag when analyst removes ALL redactions from a page

GIVEN an IAO analyst is on a page that is flagged Partial Disclosure
WHEN the analyst removes ALL the redactions on the page (e.g., with the eraser or by clicking the X in the Marked for Redaction)
THEN the 'Partial Disclosure' page flag will automatically be removed from the page
AND the 'Partial Disclosure' icon will no longer be displayed beside the page in the 'Organize By' pane

Scenario 3: 'Partial Disclosure' flag perists when analyst does NOT removes ALL redactions from a page

GIVEN an IAO analyst is on a page that is flagged Partial Disclosure
WHEN the analyst removes some but NOT ALL the redactions on the page (e.g., with the eraser or by clicking the X in the Marked for Redaction)
THEN the 'Partial Disclosure' page flag will remain on the page
AND the 'Partial Disclosure' icon will be displayed beside the page in the 'Organize By' pane

Scenario 4: Click on 'Partial Disclosure' flag in left panel

GIVEN an IAO analyst in the Records Review app
WHEN the analyst clicks the 'Partial Disclosure' page flag in the Organize by pane next to a page
THEN the FOIPPA modal with sections will open

Scenario 5: Save FOIPPA section

GIVEN an IAO analyst is on the FOIPPA modal
WHEN the analyst saves sections of the Act to apply
THEN the FOIPPA modal close
AND the 'Partial Disclosure' icon will be displayed beside the page in the 'Organize By' pane

Scenario 5: Manually Change Flag

GIVEN an IAO analyst has applied a redaction
AND the application has auto-flagged the page as 'Partial Disclosure'
WHEN the IAO user has activated the page flag menu, when right-clicking on the page
THEN the user will be able to manually change the flag to any other flag
AND the redaction will persist

Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team?s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

@m-prodan, this follows the same pattern as #3487.

@KyEggleston currently select any code (including "Blank Code") in FOIPPA modal will mark page as Partial Disclosure. We'll handle "Blank Code" when working on #3579 (Auto-flag In Progress when Blank selected).


Generalization to more than 1 confounding factor

Hello,
Thank you very much for tackling this issue of confounders, which seems very recurrent in clinical ML problems.
I have some questions about the project/paper:

I am wondering why only the test set needs to be Deconfounded?  Why not build also a train set which is Deconfounded and a Deconfounded test set (with no data leakage of course)?
I tried to make a generalization of your methodology with k multiple confounders

I still used most of your codebase and I used a pseudo generalization of the mutual information of multiple variables.
The probability to be sampled m_i which was

is now:

The quantity
 can still be estimated with kernel density estimation.
I made some quick toy examples, it seems to approximately work on simple additive toy examples and when the number of example is sufficient:
For instance with 1000 sample and 10 confounding factors i got:

For instance with 100 sample and 3 confounding factors i got:

It would be also interesting to study the required N to be sure at a certain level the deconfounding capability for k factors considering the type of link.
Do you think this is a correct approach and generalization?
Thank you
Best regards

Oops, after some thinking maybe I should look at the goodness of fit with the multiple variable and not only individual correlations, to test

I added the R^2 when I do a Ordinary Least Squares with stats model 'y ~ z0 + z1 + z2'


Enabling CORS for HTTP Interface

Hi,
Is there a configuration setting where we can enable cross domain sharing for HTTP interface?
Right now when I query using jQuery I get the following error:
"No 'Access-Control-Allow-Origin' header is present on the requested resource"
Thanks!

No settings right now.
Seems to be easy change...
Worth to do.

+1 vote

i think is close issue, in https://github.com/yandex/ClickHouse/pull/83

Yes.
Release build with this feature is not ready. Maybe on thursday or after 12 sept.