Intermittent report of dropped logs from hubble.

Hello,
we’ve been noticing some unusual behavior with cilium/hubble and we’re curious if anyone else has seen anything similar. Essentially, we’ve written network policies that allow traffic to a particular CIDR block/port, but we’re seeing intermittent drop logs from hubble with the log code 133 (policy interruption) where we know the traffic should be allowed (and usually is allowed). However, we haven’t actually actually noticed any service interruption due to those drops, so we’re unsure about whether these are real intermittent cilium drops or if hubble might be falsely reporting drops. Has anyone seen anything similar, whether the cause might be false reporting by hubble or real intermittent drops by cilium? We’re running cilium v1.8.6 on kubernetes 1.18.
here’s an example of a drop:
"attributes": {
    "source": {
        "namespace": "studio-live",
        "identity": 42150,
        "ID": 37,
        "labels": [
            "k8s:app.kubernetes.io/managed-by=spinnaker",
            "k8s:app.kubernetes.io/name=baas",
            "k8s:app=baas-config",
            "k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-v9rth",
            "k8s:io.cilium.k8s.policy.cluster=default",
            "k8s:io.cilium.k8s.policy.serviceaccount=default",
            "k8s:io.kubernetes.pod.namespace=studio-live",
            "k8s:studio-context=live"
        ],
        "pod_name": "baas-config-d84bc885f-8s564"
    },
    "IP": {
        "ipVersion": "IPv4",
        "destination": "<IP_ADDRESS>",
        "source": "<IP_ADDRESS>"
    },
    "l4": {
        "TCP": {
            "destination_port": 26257,
            "source_port": 48794,
            "flags": {
                "PSH": true,
                "ACK": true
            }
        }
    },
    "destination": {
        "identity": 2,
        "labels": [
            "reserved:world"
        ]
    },
    "node_name": "ip-10-8-1-11.us-east-2.compute.internal",
    "traffic_direction": "EGRESS",
    "ethernet": {
        "destination": "2e:cf:00:b3:44:3c",
        "source": "86:4f:19:2d:9b:ef"
    },
    "Type": "L3_L4",
    "event_type": {
        "sub_type": 133,
        "type": 1
    },
    "verdict": "DROPPED",
    "Summary": "TCP Flags: ACK, PSH",
    "time": "2021-03-19T18:08:08.011207109Z",
    "drop_reason": 133
}

policy:
apiVersion: cilium.io/v2
kind: CiliumNetworkPolicy
metadata:
  annotations:
    artifact.spinnaker.io/location: studio-live
    artifact.spinnaker.io/name: network-config
    artifact.spinnaker.io/type: kubernetes/CiliumNetworkPolicy.cilium.io
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"cilium.io/v2","kind":"CiliumNetworkPolicy", [...]}
    moniker.spinnaker.io/application: baas
    moniker.spinnaker.io/cluster: CiliumNetworkPolicy.cilium.io network-config
  creationTimestamp: "2021-01-24T15:04:42Z"
  generation: 4
  labels:
    app.kubernetes.io/managed-by: spinnaker
    app.kubernetes.io/name: baas
  managedFields:
  - apiVersion: cilium.io/v2
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:artifact.spinnaker.io/location: {}
          f:artifact.spinnaker.io/name: {}
          f:artifact.spinnaker.io/type: {}
          f:kubectl.kubernetes.io/last-applied-configuration: {}
          f:moniker.spinnaker.io/application: {}
          f:moniker.spinnaker.io/cluster: {}
        f:labels:
          .: {}
          f:app.kubernetes.io/managed-by: {}
          f:app.kubernetes.io/name: {}
      f:spec:
        .: {}
        f:egress: {}
        f:endpointSelector:
          .: {}
          f:matchLabels:
            .: {}
            f:app: {}
    manager: kubectl
    operation: Update
    time: "2021-03-06T23:00:22Z"
  name: network-config
  namespace: studio-live
  resourceVersion: "64708762"
  selfLink: /apis/cilium.io/v2/namespaces/studio-live/ciliumnetworkpolicies/network-config
  uid: af4b7347-921f-436d-ab8f-102933da6bf7
spec:
  egress:
  - toCIDRSet:
    - cidr: <IP_ADDRESS>/8
  - toCIDR:
    - <IP_ADDRESS>/32
    - <IP_ADDRESS>/16
  - toFQDNs:
    - matchName: bondtech-docker-local.jfrog.io
    - matchPattern: baas-*.*.*.rds.amazonaws.com
[...]
  - toPorts:
    - ports:
      - port: "53"
        protocol: ANY
      rules:
        dns:
        - matchPattern: '*'
    - ports:
      - port: "8125"
        protocol: UDP
    - ports:
      - port: "6000"
        protocol: TCP
      - port: "7000"
        protocol: TCP
  - toEndpoints:
    - matchLabels:
        app: baas-auth
    - matchLabels:
        k8s:app: cockroachdb
        k8s:io.kubernetes.pod.namespace: crdb-dev3
[...]
  endpointSelector:
    matchLabels:
      app: baas-config

How to reproduce the issue

Intermittent. This seems to happen randomly so we do not have a concrete way to reproduce at will. We have asked in the slack and after initially triaging with @pchaigno  and @aditighag  the recommendation was to gather a dump and post a bug report for further review.
cilium-sysdump-prod2-20210324-012008.zip
cilium-sysdump-prod3-20210324-012151.zip

What is the second sysdump (prod3)?
Was <IP_ADDRESS> associated to a pod at any point? In the FQDN cache, I see that cockroachdb.crdb-prod2.svc.cluster.local. resolved to <IP_ADDRESS>. If it was associated to a pod, was that pod matched by:
      - matchLabels:
          k8s:app: cockroachdb
          k8s:io.kubernetes.pod.namespace: crdb-prod2

Were the policy drops happening when the sysdump was taken?

Hey @pchaigno
Sorry for the confusion. We have two clusters running cilium and we were/are seeing the drops across both. So where we are seeing the drops logged are mainly to cockroach db, rds db and an external fdns. <IP_ADDRESS> was assigned to one of our cockroach pods, but I believe it was since been cycled/replaced. the cockroach pod should have matched that label. If there is any additional clarification/information that we need to provide, please let me know.
Regards.

<IP_ADDRESS> was assigned to one of our cockroach pods, but I believe it was since been cycled/replaced.

When was the sysdump collected? In the following series of events correct?

Drops are happening.
Pod <IP_ADDRESS> is deleted.
Sysdump is collected.

It would be nice to get a sysdump before the pod is deleted, ideally while the drops are still happening.

Hey @pchaigno,
I believe that sequence is correct. That just happened to be the initial request that we opened our slack conversation with. We can attempt to capture a more recent failure and dump as we see these frequently enough. I'll post an update with updated information.
Regards.

@gtsjamesbond Just to confirm, there are no actual drops for the policy, but only Hubble reported drops, correct? I think this context was missing in the Slack conversation. I'm not sure if we need the sig-policy label in this PR if that's the case.

@aditighag so this is one thing that we were unsure of, we are getting the hubble reports of drops, BUT the application is behaving as expected (like there are no drops), so this is leading us to believe something is not correct, or we are misinterpreting the meaning of the drop reports. This is one of the things we wanted to verify, namely if the drop reports that we are seeing are infact accurate, or false reports. If false reports, then we would like to determine why to see if there is any way to "tune these out", so that we arent alerted if we dont need to be.
Regards.

@pchaigno @aditighag
Below is a recent drop
`
{
destination { |
ID549identity20476labels [k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | ID | 549 | identity | 20476 | labels [ |   | k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | k8s:app.kubernetes.io/managed-by=spinnaker, | k8s:app.kubernetes.io/name=baas, | k8s:app=baas-auth, | k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9, | k8s:io.cilium.k8s.policy.cluster=default, | k8s:io.cilium.k8s.policy.serviceaccount=default, | k8s:io.kubernetes.pod.namespace=studio-sandbox, | k8s:studio-context=sandbox
ID | 549
identity | 20476
labels [ |
k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | k8s:app.kubernetes.io/managed-by=spinnaker, | k8s:app.kubernetes.io/name=baas, | k8s:app=baas-auth, | k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9, | k8s:io.cilium.k8s.policy.cluster=default, | k8s:io.cilium.k8s.policy.serviceaccount=default, | k8s:io.kubernetes.pod.namespace=studio-sandbox, | k8s:studio-context=sandbox
k8s:app.kubernetes.io/managed-by=spinnaker,k8s:app.kubernetes.io/name=baas,k8s:app=baas-auth,k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,k8s:io.cilium.k8s.policy.cluster=default,k8s:io.cilium.k8s.policy.serviceaccount=default,k8s:io.kubernetes.pod.namespace=studio-sandbox,k8s:studio-context=sandbox | k8s:app.kubernetes.io/managed-by=spinnaker, | k8s:app.kubernetes.io/name=baas, | k8s:app=baas-auth, | k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9, | k8s:io.cilium.k8s.policy.cluster=default, | k8s:io.cilium.k8s.policy.serviceaccount=default, | k8s:io.kubernetes.pod.namespace=studio-sandbox, | k8s:studio-context=sandbox
k8s:app.kubernetes.io/managed-by=spinnaker,
k8s:app.kubernetes.io/name=baas,
k8s:app=baas-auth,
k8s:io.cilium.k8s.namespace.labels.field.cattle.io/projectId=p-f78q9,
k8s:io.cilium.k8s.policy.cluster=default,
k8s:io.cilium.k8s.policy.serviceaccount=default,
k8s:io.kubernetes.pod.namespace=studio-sandbox,
k8s:studio-context=sandbox
`
$ kubectl get pods -A -o wide | grep -i "<IP_ADDRESS>" studio-sandbox   baas-auth-58db55c49-tb2x6
I have attached a current sysdump.
cilium-sysdump-20210324-135815.zip
Regards.

we are getting the hubble reports of drops, BUT the application is behaving as expected (like there are no drops)

So if pod1 on node1 is talking to pod2 on node2, you see Hubble reported drops on node1, but the packets reach node2/pod2?

we are getting the hubble reports of drops, BUT the application is behaving as expected (like there are no drops), so this is leading us to believe something is not correct

If the drops are intermittent, they might not cause connectivity issues. That seems more likely than Hubble getting packet drop notifications out of nowhere :slightly_smiling_face:

@pchaigno I see your point. What is of more interest to our team, is why we would get the drop to begin with if the target IP should be covered by one of the rules? We also see this intermittently with a target we have identified using FQDN.  Any ideas there?
Regards.

why we would get the drop to begin with if the target IP should be covered by one of the rules? Is what we are seeing an artifact of a network issue manifesting? or CNP actually causing a drop?

My guess would be that the drops are caused by some transient issue in the resolution of the security identity. The destination identity reported by Hubble is reserved:world, which is sort of a default for when we can't associate another identity.

We can attempt to capture a more recent failure and dump as we see these frequently enough.

I think that would help understand why the identity resolution failed.

@pchaigno here are two drops logged in the last hour to different destinations, and also the sysdump
`
{
destination { |
identity2labels [reserved:world | identity | 2 | labels [ |   | reserved:world | reserved:world | reserved:world
identity | 2
labels [ |
reserved:world | reserved:world | reserved:world
reserved:world | reserved:world
reserved:world
`
`
{
destination { |
identity2labels [reserved:world | identity | 2 | labels [ |   | reserved:world | reserved:world | reserved:world
identity | 2
labels [ |
reserved:world | reserved:world | reserved:world
reserved:world | reserved:world
reserved:world
cilium-sysdump-20210325-114456.zip
`

@gtsjamesbond I think you forgot to attach the sysdump. The Hubble log is also ill-formatted.

@pchaigno Attaching dump again.
cilium-sysdump-20210325-114456.zip

@pchaigno @aditighag , were you able to gain any insight from the latest attached logs uploaded on March 25?
Regards.

@pchaigno @aditighag , were you able to gain any insight from the latest attached logs uploaded on March 25?
Regards.

Busy with the 1.10 release, I'll try to take a look (most likely) after the release unless someone else beats me to it.

Busy with the 1.10 release, I'll try to take a look (most likely) after the release unless someone else beats me to it.

@aditighag as you showed some interest, I've assigned this to you :)

I am experiencing something very similar to this. In my case, the drops reported by Hubble are real (see tests below).
Running Cilium 1.10.3 on EKS 1.20.
For context, we use Traefik (as a DaemonSet) to forward traffic to some-service Pods/Endpoints and from time to time, our metrics show an increasing number of HTTP 504's for ingresses.
When these 504's are happening, Traefik logs show messages such as:
'504 Gateway Timeout' caused by: dial tcp <IP_ADDRESS>:3000: i/o timeout
We then confirm that the IP is assigned to a Pod:
$ kubectl get pods -o wide | grep some-service
some-service-6ccccf645d-222k9                     1/1     Running   0          3h12m   <IP_ADDRESS>   ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-5t9qk                     1/1     Running   0          3h12m   <IP_ADDRESS>    ip-10-210-117-158.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-6l4k6                     1/1     Running   0          137m    <IP_ADDRESS>   ip-10-210-128-32.eu-west-1.compute.internal    <none>           <none>
some-service-6ccccf645d-9snjn                     1/1     Running   2          3h12m   <IP_ADDRESS>   ip-10-210-147-20.eu-west-1.compute.internal    <none>           <none> <---- curling this from another pod results in DROPPED
some-service-6ccccf645d-bgpk6                     1/1     Running   0          156m    <IP_ADDRESS>   ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-btr8l                     1/1     Running   0          3h12m   <IP_ADDRESS>   ip-10-210-117-158.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-c9mdv                     1/1     Running   0          154m    <IP_ADDRESS>   ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-gtlpj                     1/1     Running   0          125m    <IP_ADDRESS>   ip-10-210-128-32.eu-west-1.compute.internal    <none>           <none>
some-service-6ccccf645d-kqvxb                     1/1     Running   0          3h12m   <IP_ADDRESS>    ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-ln4v5                     1/1     Running   0          125m    <IP_ADDRESS>   ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-rfmf4                     1/1     Running   0          142m    <IP_ADDRESS>   ip-10-210-117-158.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-wvc7s                     1/1     Running   2          3h11m   <IP_ADDRESS>    ip-10-210-147-20.eu-west-1.compute.internal    <none>           <none>
some-service-6ccccf645d-xfbtp                     1/1     Running   0          3h12m   <IP_ADDRESS>    ip-10-210-117-158.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-xfmdq                     1/1     Running   0          136m    <IP_ADDRESS>   ip-10-210-128-32.eu-west-1.compute.internal    <none>           <none>
some-service-6ccccf645d-z7gf7                     1/1     Running   0          154m    <IP_ADDRESS>   ip-10-210-184-168.eu-west-1.compute.internal   <none>           <none>
some-service-6ccccf645d-ztm87                     1/1     Running   0          143m    <IP_ADDRESS>   ip-10-210-117-158.eu-west-1.compute.internal   <none>           <none>

Making a HTTP request to <IP_ADDRESS>:3000 from any Traefik Pod fails with Cilium dropping the packet. hubble observe shows
Mar  9 14:09:02.709: traefik/traefik-dhzrk:45498 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)
Mar  9 14:09:02.709: traefik/traefik-dhzrk:45498 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)
Mar  9 14:09:04.484: traefik/traefik-dhzrk:46534 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)
Mar  9 14:09:04.484: traefik/traefik-dhzrk:46534 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)
Mar  9 14:09:05.493: traefik/traefik-dhzrk:46534 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)
Mar  9 14:09:05.493: traefik/traefik-dhzrk:46534 <> <IP_ADDRESS>:3000 Policy denied DROPPED (TCP Flags: SYN)

However a request to another some-service Pod IP (e.g. <IP_ADDRESS>) succeeds.
The relevant Cilium Endpoint
  {
    "id": 1114,
    "spec": {
      "label-configuration": {},
      "options": {
        "Conntrack": "Enabled",
        "ConntrackAccounting": "Enabled",
        "ConntrackLocal": "Disabled",
        "Debug": "Disabled",
        "DebugLB": "Disabled",
        "DebugPolicy": "Disabled",
        "DropNotification": "Enabled",
        "MonitorAggregationLevel": "Medium",
        "NAT46": "Disabled",
        "PolicyAuditMode": "Disabled",
        "PolicyVerdictNotification": "Enabled",
        "TraceNotification": "Enabled"
      }
    },
    "status": {
      "controllers": [
        {
          "configuration": {
            "error-retry": true,
            "error-retry-base": "2s"
          },
          "name": "endpoint-1114-regeneration-recovery",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "0001-01-01T00:00:00.000Z"
          },
          "uuid": "95f459bf-b865-4323-af63-1566bedabadc"
        },
        {
          "configuration": {
            "error-retry": true,
            "interval": "5m0s"
          },
          "name": "resolve-identity-1114",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "2022-03-09T12:16:18.025Z",
            "success-count": 40
          },
          "uuid": "1c4fa874-3084-47c3-9f78-682d2b2f08fa"
        },
        {
          "configuration": {
            "error-retry": true,
            "interval": "1m0s"
          },
          "name": "sync-policymap-1114",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "2022-03-09T12:18:17.522Z",
            "success-count": 1062
          },
          "uuid": "9c7beb4f-0854-4d85-bce0-64679702ff01"
        },
        {
          "configuration": {
            "error-retry": true,
            "interval": "10s"
          },
          "name": "sync-to-k8s-ciliumendpoint (1114)",
          "status": {
            "last-failure-timestamp": "0001-01-01T00:00:00.000Z",
            "last-success-timestamp": "2022-03-09T12:18:38.699Z",
            "success-count": 1186
          },
          "uuid": "67de00c4-ba2b-4cc8-9c22-a576f26a9353"
        }
      ],
      "external-identifiers": {
        "container-id": "9723d07a45d0b8891c64eb3d715d1f17c4defaef00995ddfe4df4d3e74f58fd3",
        "k8s-namespace": "some-namespace",
        "k8s-pod-name": "some-service-6ccccf645d-9snjn",
        "pod-name": "some-namespace/some-service-6ccccf645d-9snjn"
      },
      "health": {
        "bpf": "OK",
        "connected": true,
        "overallHealth": "OK",
        "policy": "OK"
      },
      "identity": {
        "id": 38850,
        "labels": [
          "k8s:serviceSelector=some-service-selector",
          "k8s:app.kubernetes.io/name=some-service",
          "k8s:io.cilium.k8s.namespace.labels.functional_area=engineering",
          "k8s:io.kubernetes.pod.namespace=some-namespace",
          "k8s:io.cilium.k8s.policy.cluster=default",
          "k8s:io.cilium.k8s.namespace.labels.team=some-namespace",
          "k8s:app.kubernetes.io/managed-by=spinnaker",
          "k8s:io.cilium.k8s.policy.serviceaccount=some-service",
          "k8s:app.kubernetes.io/instance=some-service",
          "k8s:frontedBy=some-service-svc"
        ],
        "labelsSHA256": "3613c13e2efceb441c618ffc4c04ce3044f7737db2ffe6b932d897511ddc58a1"
      },
      "labels": {
        "derived": [
          "k8s:pod-template-hash=6ccccf645d"
        ],
        "realized": {},
        "security-relevant": [
          "k8s:app.kubernetes.io/instance=some-service",
          "k8s:app.kubernetes.io/managed-by=spinnaker",
          "k8s:app.kubernetes.io/name=some-service",
          "k8s:frontedBy=some-service-svc",
          "k8s:io.cilium.k8s.namespace.labels.functional_area=engineering",
          "k8s:io.cilium.k8s.namespace.labels.team=some-namespace",
          "k8s:io.cilium.k8s.policy.cluster=default",
          "k8s:io.cilium.k8s.policy.serviceaccount=some-service",
          "k8s:io.kubernetes.pod.namespace=some-namespace",
          "k8s:serviceSelector=some-service-selector"
        ]
      },
      "log": [
        {
          "code": "OK",
          "message": "Successfully regenerated endpoint program (Reason: one or more identities created or deleted)",
          "state": "ready",
          "timestamp": "2022-03-09T12:17:17Z"
        }
      ],
      "namedPorts": [
        {
          "name": "http",
          "port": 3000,
          "protocol": "TCP"
        }
      ],
      "networking": {
        "addressing": [
          {
            "ipv4": "<IP_ADDRESS>"
          }
        ],
        "host-mac": "d2:83:14:7e:b8:5d",
        "interface-index": 483,
        "interface-name": "lxc96c6117f9e34",
        "mac": "6a:66:e9:05:5d:c0"
      },
      "policy": {
        "proxy-statistics": [],
        "realized": {
          "allowed-egress-identities": [
            0
          ],
          "allowed-ingress-identities": [
            0,
            1
          ],
          "build": 28,
          "cidr-policy": {
            "egress": [],
            "ingress": []
          },
          "denied-egress-identities": null,
          "denied-ingress-identities": null,
          "id": 38850,
          "l4": {
            "egress": [],
            "ingress": []
          },
          "policy-enabled": "none",
          "policy-revision": 28
        },
        "spec": {
          "allowed-egress-identities": [
            0
          ],
          "allowed-ingress-identities": [
            1,
            0
          ],
          "build": 28,
          "cidr-policy": {
            "egress": [],
            "ingress": []
          },
          "denied-egress-identities": null,
          "denied-ingress-identities": null,
          "id": 38850,
          "l4": {
            "egress": [],
            "ingress": []
          },
          "policy-enabled": "none",
          "policy-revision": 28
        }
      },
      "realized": {
        "label-configuration": {},
        "options": {
          "Conntrack": "Enabled",
          "ConntrackAccounting": "Enabled",
          "ConntrackLocal": "Disabled",
          "Debug": "Disabled",
          "DebugLB": "Disabled",
          "DebugPolicy": "Disabled",
          "DropNotification": "Enabled",
          "MonitorAggregationLevel": "Medium",
          "NAT46": "Disabled",
          "PolicyAuditMode": "Disabled",
          "PolicyVerdictNotification": "Enabled",
          "TraceNotification": "Enabled"
        }
      },
      "state": "ready"
    }
  }
]

CiliumNetworkPolicy applied to Traefik
apiVersion: cilium.io/v2
kind: CiliumNetworkPolicy
metadata:
  name: traefik
  namespace: traefik
spec:
  egress:
  - toEntities:
    - cluster
  - toPorts:
    - ports:
      - port: "443"
    toServices:
    - k8sService:
        namespace: default
        serviceName: kubernetes
  - toPorts:
    - ports:
      - port: "8126"
        protocol: TCP
      - port: "8125"
        protocol: UDP
    toServices:
    - k8sServiceSelector:
        namespace: datadog
        selector:
          matchLabels:
            agent.datadoghq.com/name: datadog
            app.kubernetes.io/instance: agent
  - toFQDNs:
    - matchName: update.traefik.io
    toPorts:
    - ports:
      - port: "443"
  - toEndpoints:
    - matchLabels:
        io.kubernetes.pod.namespace: kube-system
        k8s-app: kube-dns
    toPorts:
    - ports:
      - port: "53"
        protocol: UDP
      rules:
        dns:
        - matchPattern: '*'
  - toEndpoints:
    - matchLabels:
        io.kubernetes.pod.namespace: engineering
    toPorts:
    - ports:
      - port: "8080"
        protocol: TCP
  endpointSelector:
    matchLabels:
      app.kubernetes.io/name: traefik
  ingress:
  - fromEntities:
    - host
    - remote-node
    toPorts:
    - ports:
      - port: "8082"
        protocol: TCP
      - port: "8443"
      - port: "8445"
  - fromEntities:
    - world
    toPorts:
    - ports:
      - port: "8082"
      - port: "8443"
      - port: "8444"
      - port: "8445"

Any assistance on how to further troubleshoot is very welcomed.
Thank you

@joaoubaldo Could you please open a new issue with the same information as above plus a full dump of those Hubble drops (-o jsonpb)? A Cilium sysdump of the cluster would also help.

I have the same issue, it was random, not repeating, and the TCP flag is always not SYN. My version:
root@xxx:/home/cilium# cilium version
Client: 1.12.2 c7516b9 2022-09-14T15:25:06+02:00 go version go1.18.6 linux/amd64
Daemon: 1.12.2 c7516b9 2022-09-14T15:25:06+02:00 go version go1.18.6 linux/amd64

Anybody knows how I can have the same drop traffic log as the author? What to enable please?

Anybody knows how I can have the same drop traffic log as the author? What to enable please?

@smeeklai you can get that info with something like hubble observe -t drop --output jsonpb


Show pre-processing parameters information

Currently, the interface is not showing the parameters used for pre-process a raw data. This information should be included in the PreProcessed data tab. The information is already available in the DB using the preprocessed_params_table and preprocessed_params_id from the PreprocessedData table.

I think https://github.com/biocore/qiita/issues/1985 is basically the same issue than this, @josenavas could you close this one if that's the case and if not could you explain the differences?

Ok to close - this was referring to the old interface so now it has been (or going to be) fixed in the other issue


Replace panels with breakout task forces

Having participated in numerous Solid Panels since 2019 I think it is time for a retrospective and reorganization.
2019 - 2022
Panels were most active, incubating proposals and advancing them into dedicated repositories.
There was a special case of the Editors Team which I understood was an invite-only meeting.
2022 - 2023
Many panels stop their activity:

Authentication Panel - practically no activity
Authorization Panel - practically no activity
Data Interoperability Panel - some irregular activity
Notifications - very active in 2022, falling off in 2023

At the same time, there is a varying degree of work happening on the dedicated repositories and implementations!
2023 -
I think we should anticipate that Solid WG will be established and will be organized independently of CG while keeping coordinated. Based on CG charter and conversations around deliverables (protocol + dependencies) solid/solid-wg-charter#37 I would expect it to cover the following areas:

Solid Storage
Authorization and Authentication
Notifications (maybe)

There are still various areas, like discovery (which can depend on AuthZ) and other app interop-related concerns which the CG should continue its work on. I think the following might be one of the simpler and more effective approaches for the CG:

Single regular weekly meeting Solid-CG, which we should consider extending to 2 hours and always have open PR or Issue (at least gh Discussion) for each topic on the agenda.
If a certain area regularly starts taking up a significant part of that meeting, and we regularly need to push topics to next week, we should call a breakout Task Force which has additional meetings and to process the workload.
We don't create a repo for the Task Forces, only specifications have their repositories, and CG with TF work on those spec-focused repositories.
Instead of having incubating documents in the panel repo and creating new repo later on, the initial draft gets created in the personal repository of the person who is proposing it, they can always invite collaborators! As soon as the proposal gets accepted as CG draft it gets transferred to @solid github org.

I think we should do some retrospective first and after that discuss what I propose and what others will be interested in proposing. BTW Solid Panels document is pretty outdated, it links to a Zoom call and W3C wiki for minutes.

Let's focus on

#323

As I understand now it should include addressing the above.

Reopening since #323 is practically done

@woutermont created a set of PRs to update panel's meeting information:

https://github.com/solid/authentication-panel/pull/238
https://github.com/solid/authorization-panel/pull/330
https://github.com/solid/data-interoperability-panel/pull/318
https://github.com/solid/solid-oidc/pull/223
https://github.com/solid/webid-profile/pull/106
https://github.com/solid/notifications-panel/pull/102

Context: awaiting confirmation of the idea to obsolete panels, a number of people (possible popping their heads up after summer slumber) were confused when no one turned up in some panel meetings that were still scheduled in the agenda.

Right. So, this is aligned with the initial suggestion in https://github.com/solid/specification/pull/458#issue-1390870735 to transition from panels to task forces. We needed to iron out a bunch of stuff along the way. Here we are.
I've updated the status of data-interoperability-panel, test-suite-panel, notifications-panel, webid-profile in the CG calendar to "tentative" for the time being.
BTW, webid-profile isn't and wasn't intended to be a panel. It is intended as the first task force (before literally calling it as such).

PRs references in https://github.com/solid/process/issues/324#issuecomment-1719720918 are now resolved.
Pavlik, everyone:
I suggest closing this issue. Solid Process needs to be updated any way. Discussion pertaining to CG task force can carry out in solid/specification.


Automatically refresh dist files on Dependabot PRs

When upgrading @mdn/browser-compat-data, it'd be nice if Dependabot PRs automatically refreshed the dist files. Then it'd be easier to review the effects of the upgrade.
Here's one possible approach for this. When Dependabot upgrades BCD (as in https://github.com/web-platform-dx/web-features/pull/894), a GitHub Actions workflow ought to to do something like this:

If the PR branch matches the pattern dependabot/npm_and_yarn/mdn/browser-compat-data-, run npm run dist:refresh. The command must do what npm run dist does for every file with an existing .dist.yml file.
Commit and changes to .dist.yml files that result.
Push the changes back to the Dependabot PR branch.

dist.ts probably needs an option flag to just automatically find the applicable files, for this to work.

This sounds like a good idea. As a side effect, Dependabot would stop updating the PR. In order to make @dependabot recreate work, the GitHub Actions workflow could check the number of commits on the branch and push an update if it's exactly 1.


Can't send tokens

truffle exec scripts/issue-tokens.js

Using network 'development'.

Error: ENOENT: no such file or directory, open '/home/eth/DAPPS/defi_yield_farming/scripts/issue-tokens.js'
    at Object.openSync (fs.js:498:3)
    at Object.readFileSync (fs.js:394:35)
    at Object.file (/usr/local/lib/node_modules/truffle/build/webpack:/packages/require/require.js:28:1)
    at Object.exec (/usr/local/lib/node_modules/truffle/build/webpack:/packages/require/require.js:121:1)
    at internal/util.js:308:30
    at new Promise (<anonymous>)
    at bound exec (internal/util.js:307:12)
    at Object.run (/usr/local/lib/node_modules/truffle/build/webpack:/packages/core/lib/commands/exec.js:75:1)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Command.run (/usr/local/lib/node_modules/truffle/build/webpack:/packages/core/lib/command.js:172:1)
Truffle v5.4.3 (core: 5.4.3)
Node v14.17.0

Fixed, please try again.


📃: proposal to add the Random Quote Generator project

📃: Proposal to Add a Random Quote Generator
🔴 Title: QuoteMaster
🔴 Tech Stack: React, CSS, Quote API (e.g., Quotable API or any public Quote API)
🔴 Objective: To create a simple, interactive platform where users can get random quotes from famous personalities, books, or other sources. The application will also allow users to copy and share quotes on social media or save their favorite quotes.
🔴 Summary:
QuoteMaster is a React-based web application designed to generate and display random inspirational, humorous, or philosophical quotes. By leveraging a quote API, the application provides users with a new quote at the click of a button. The design is minimalistic and user-friendly, with features like social media sharing and quote favoriting.
📸 Screenshots

✅ Details to Include When Taking the Issue:
Name : Hamza Mubin
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.): GSSOC-EXTD, Hacktoberfest, Level 3

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

Sorry, someone is already working on this. Do not be demotivated and raise a new issue.

No problem🙂


TMO_SHELL: DFU: library creation

First checkin of the code for a dfu gecko module
Signed-off-by: Kim Mansfield<EMAIL_ADDRESS>

dfu_gecko/prj.conf seems to include unnecessary configs. @kimmansfield can you please remove the ones that aren't needed?

In the previous applications and including our samples we had use this definition
int dfu_mcu_get_oldest_slot(); Is this function not needed anymore. In the proposal we talked about exposing this as a API as its needed for FW updates.


fix: early close of span with graphql execute

Which problem is this PR solving?
Fixes #750
Short description of the changes
Await promise resolution before calling endSpan

Cheers, I'll take a look tomorrow at getting a unit test written and also rebasing it with the latest main branch

I've fixed the failing tests - it was due to a change in the execution order changing. I've added a test for the span timings, let me know if there are any changes you'd like - eg duplicating the test in to the different cases eg when depth is set to 0.

@samriley could you rebase your PR please ? it should be fix the lint


Cannot install script

Hi Community,
Following system:
Ubuntu 18,04
Openhabian
Pyhton3
i have following error:
`
Collecting git+https://github.com/NickWaterton/Roomba980-Python.git
Cloning https://github.com/NickWaterton/Roomba980-Python.git to /tmp/pip-CwsDqk-build
Requirement already satisfied: numpy in /usr/lib/python2.7/dist-packages (from Roomba980-Python==1.2.3)
Collecting opencv-python (from Roomba980-Python==1.2.3)
Using cached https://files.pythonhosted.org/packages/a1/d6/8422797e35f8814b1d9842530566a949d9b5850a466321a6c1d5a99055ee/opencv-python-<IP_ADDRESS>.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-build-S370Ko/opencv-python/setup.py", line 448, in
main()
File "/tmp/pip-build-S370Ko/opencv-python/setup.py", line 99, in main
% {"ext": re.escape(sysconfig.get_config_var("EXT_SUFFIX"))}
File "/usr/lib/python2.7/re.py", line 210, in escape
s = list(pattern)
TypeError: 'NoneType' object is not iterable
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-S370Ko/opencv-python/
root@APP02:~#
`

You have some sort of problem installing opencv-python. you may need to install as su using sudo.

Try pip2 install opencv-python==<IP_ADDRESS>

You actually need opencv-contrib-python==<IP_ADDRESS>
Version 4 of opencv leaves out some important commands.


[Feature] _set_model_kwargs_torch_dtype in _load_model will overide the torch_dtype in the config.json of any given huggingface models by default

Describe the feature
https://github.com/open-compass/opencompass/blob/52eccc4f0efd3ca6f272ae19efb2d7f6cc9c9dec/opencompass/models/huggingface_above_v4_33.py#L213

In most cases people who import any huggingface model by the argument --hf-path might think the "torch_dtype" in the config.json will take effect, but the "_load_model" function will always overide it with float16 by calling "_set_model_kwargs_torch_dtype" if not any line like "--model-kwargs torch_dtype='xxx'" is added to your command lines.
It would be better to check the "torch_dtype" in the config.json first.
Will you implement it?

[ ] I would like to implement this feature and create a PR!

Thanks, we will fix this bug recently.


When the bot creates new manifests it should add the schema comment

Description of the new feature/enhancement
In PR #13650 the bot is deleting the:
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json

When not only should that be preserved, the proper schema should added to any changes made by the bot.
Proposed technical implementation details (optional)

Before this gets to the releases stage i want it to be normalized like this
# Automatically updated by the winget bot at 2021/Jul/21
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json

PackageIdentifier: Ubisoft.Connect

instead of this
# Automatically updated by the winget bot at 2021/Jul/21
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json
PackageIdentifier: Ubisoft.Connect

https://github.com/microsoft/winget-pkgs/pull/21922/files#

I forgot to close this one.


[uWebSockets]

Hi,
@BillyONeal  Kindly update the vcpkg port of uWebSockets.
The repo is on version 18.6.0 but vcpkg still shows and installs 0.15.7. Kindly see screenshot below.

Thanks.

I found a solution.
I ran git pull in the vcpkg directory to update the "portfiles".
This will provide the latest (or near latest depending on the vcpkg team) version of the desired library.


Test for channel/branch name seems too specific

See https://travis-ci.org/flutter/flutter/builds/156907663#L3999
Looks like the unit test is hard-coded to master, but maybe should be more flexible to allow for PR's that come in from other branches?
cc @danrubel

Thanks Dan. :)


"Failed building wheel for secp256k1" upon installation

Checklist

[x] installed pyethapp inside a virtualenv

System/environment

OS: OS X 10.11.6
python version: 2.7
pyethapp version: FIXME
installation method (pip & pypi/git & setup.py): git
pyethapp branch (if applicable): FIXME

Expected behaviour
$ pyethapp
Usage: pyethapp [OPTIONS] COMMAND [ARGS]...
Welcome to ethapp version:pyethapp/v0.9.18/linux2/py2.7.9
Options:
Observed behaviour
I can't install pyethapp. It's failing at the secp256k1.
This is the output I get when I try to install it:

Failed building wheel for secp256k1
[...]
checking for gcc... gcc
checking whether the C compiler works... no
configure: error: in /private/var/folders/qw/cwkm1m4s41z0l1trrv74s2c00000gn/T/pip-build-KxLQvu/secp256k1/build/temp.macosx-10.11-x86_64-2.7':     configure: error: C compiler cannot create executables     See config.log' for more details
Traceback (most recent call last):
File "", line 1, in
File "/private/var/folders/qw/cwkm1m4s41z0l1trrv74s2c00000gn/T/pip-build-KxLQvu/secp256k1/setup.py", line 274, in
"Topic :: Security :: Cryptography"
[...]
----------------------------------------

Command "/Users/deerdear/Documents/Ethereum/pyethapp/bin/python2.7 -u -c "import setuptools, tokenize;file='/private/var/folders/qw/cwkm1m4s41z0l1trrv74s2c00000gn/T/pip-build-KxLQvu/secp256k1/setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" install --record /var/folders/qw/cwkm1m4s41z0l1trrv74s2c00000gn/T/pip-qX1P2u-record/install-record.txt --single-version-externally-managed --compile --install-headers /Users/deerdear/Documents/Ethereum/pyethapp/bin/../include/site/python2.7/secp256k1" failed with error code 1 in /private/var/folders/qw/cwkm1m4s41z0l1trrv74s2c00000gn/T/pip-build-KxLQvu/secp256k1/`
Steps to reproduce
Followed the guide: https://github.com/ethereum/pyethapp/wiki/Getting-Started

The important part is this:

configure: error: C compiler cannot create executables See config.log

This is most likely caused by an outdated installation of Xcode. Please see https://github.com/ethereum/pyethapp/blob/develop/docs/installation_os_x.rst for detailed instructions on how to set your Mac.

Thanks! I suspected it might be that. I updated and reinstalled command line tools and now it worked!

Thanks it worked!


[close #16] Replace Parser with Ripper

Ripper is the built in parsing library from Ruby. It is much faster than Parser and it has everything we need.
This PR replaces the parser gem with ripper.

This PR actually decreases test time noticeably:
Before: Finished in 2.4 seconds (files took 0.29151 seconds to load)
After: Finished in 1.6 seconds (files took 0.14218 seconds to load)


fix - broken link

Fix for broken link at admission-conrollers page.
https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#runtimeclass
See RuntimeClass link.

/assign @kbarnard10

Page preview:
https://deploy-preview-17530--kubernetes-io-master-staging.netlify.com/docs/reference/access-authn-authz/admission-controllers/
/lgtm

/approve


Short URL not handled in dynamicLinks

I have defined a dynamic link on my firebase project :
The application is correctly configured and the link open the application:
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray *restorableObjects))restorationHandler rootViewController:(UIViewController*)rootVC {

           BOOL handled = [[FIRDynamicLinks dynamicLinks] handleUniversalLink:userActivity.webpageURL
                                                                  completion:^(FIRDynamicLink * _Nullable dynamicLink,
                                                                               NSError * _Nullable error) {
            NSLog(@"[dynamic Links] - link %@", dynamicLink);
            NSLog(@"[dynamic Links] - erro %@", error);

          }];

    return handled;
}

When I use long dynamicLink url everything is OK, I can access the URL defined as parameter.
When I use short dynamicLink url,  handleUniversalLink return true but the dynamicLink created has not url.
As indicated in documentation:
https://firebase.google.com/docs/dynamic-links/debug
I have added ?d=1 at the end of url but I didn't find any différence between the short and long URL.
Possible associated bug:
https://github.com/firebase/quickstart-ios/issues/105

Are you able to reproduce this using the dynamic links quickstart in this repository?

Hello thanks for your answer.
As you recommended I use the dynamic links quick start project du reproduce my problem.
I followed this video to configure the demo as I did for my project:
https://www.youtube.com/watch?v=KLBjAg6HvG0&t=686s
When I use the dynamic link :
Short:
https://app.xxxmy-domainexxx.fr/test
Long:
https://app.xxxmy-domainexxx.fr/?link=https://www.xxxmy-domainexxx.fr/samplePath&apn=com.reversBundleID&isi=123456789&ibi=fr.reversebundleID&ius=urlScheme&efr=1
With my App :
On click both link open the app.
Long : Handled by handleUniversalLink
short : NOT Handled by handleUniversalLink
With demo App :
On click both link open the app.
Long : NOT Handled by handleUniversalLink
short : NOT Handled by handleUniversalLink
With the demo App I have more logs , that com from analytics
On Long Link:
[Firebase/Analytics][I-ACS023001] Deep Link does not contain valid required params. URL params: {
    apn = "com.reversBundleID";
    efr = 1;
    ibi = "fr.reversBundleID";
    isi = 123456789;
    ius = urlScheme;
    link = "https://www.xxxmy-domainexxx.fr/samplePath";
}

On short Link:
[Firebase/Analytics][I-ACS023000] Deep Link Web URL query is empty
For information when I open :
https://app.xxxmy-domainexxx.fr/test?d=1
I can see the correct graph and click the link from the phone open the application.
I also tried :
[FIRDynamicLinks performDiagnosticsWithCompletion:nil];
Result :
---- Firebase Dynamic Links diagnostic output start ----
Firebase Dynamic Links framework version 4.0.6
System information: OS iOS, OS version 12.3.1, model iPhone
Current date 2020-02-04 10:11:35 +0000
Device locale en-FR (raw en_FR), timezone Europe/Paris
	Specified custom URL scheme is fr.reverseBundle.id and Info.plist contains such scheme in CFBundleURLTypes key.
	AppID Prefix: XXXXXXXXX, Team ID: XXXXXXXXX, AppId Prefix equal to Team ID: YES
performDiagnostic completed successfully! No errors found.
---- Firebase Dynamic Links diagnostic output end ----

If you resolve the short link with this method and then pass the resulting URL to handleUniversalLink, is the URL handled successfully?

After the use resolveShortLink the result is still the same:
The result of the method return no error, but this url:
fr.reversebundleID://google/link/?match_type=unique

We are having the same issue over here. It used to work properly. Somehow, it stopped.

Deep Link Web URL query is empty

But the performDiagnostics is:

---- Firebase Dynamic Links diagnostic output start ----
Firebase Dynamic Links framework version 2.3.2
System information: OS iOS, OS version 13.3.1, model iPhone
Current date 2020-02-17 17:10:32 +0000
Device locale en-GB (raw en_GB), timezone Europe/Lisbon
Specified custom URL scheme is com.edp.edpx.smaapp.pre and Info.plist contains such scheme in CFBundleURLTypes key.
AppID Prefix: XXXXXXXXXX, Team ID: XXXXXXXXXX, AppId Prefix equal to Team ID: YES
performDiagnostic completed successfully! No errors found.
---- Firebase Dynamic Links diagnostic output end ----

On Android, it's working fine. We are happing this issue only on IOS.

Hello Team,
We are also facing same issue, short url is not working, and for long link no method is trigged in Appdelegate. How we can process the long link in out iOS application.

Same issue here

@hiko-prod can you file a support case? They'll be able to look at your project directly and help you debug more effectively.
For other people running into this issue, make sure that your link shows no issues when opening it in a browser with ?d=1 appended to the parameters and [FIRDynamicLinks performDiagnosticsWithCompletion:nil] shows no errors.


KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster

Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-4895
Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

When testing this patch, I encountered the following error in the first step of the build job:

Detect Resource only support spark.master=local, at this time, spark.submit.deployMode cannot be set to cluster.

Codecov Report

:exclamation: No coverage uploaded for pull request base (kylin-on-parquet-v2@c943745). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             kylin-on-parquet-v2    #1568   +/-   ##
======================================================
  Coverage                       ?   24.01%
  Complexity                     ?     4649
======================================================
  Files                          ?     1158
  Lines                          ?    66424
  Branches                       ?     9735
======================================================
  Hits                           ?    15951
  Misses                         ?    48795
  Partials                       ?     1678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c943745...0f6456c. Read the comment docs.

LGTM


Paper submission

There are at least two options where we could submit this paper, and we have a clear preference:

[ ] JPhys Complexity: deadline not until May, we can submit before then: https://iopscience.iop.org/collections/jpcomplex-231012-387

There's also this special issue call, as a plan B (deadline: 29th Feb): https://platial.science/si2023/

I've got two candidate tweaks. I'll PR them now


Middleware + Home Links

issue: #83

remove links in header
set 'home' in footer to target=_blank & href=https://www.bcregistry.gov.bc.ca
add middleware to handle redirect for filing and account state
add loading spinner to app.vue (instead of using it per page) and use pinia store to handle loading state
had to wrap several page elements in ClientOnly to prevent prerender styling errors

temp url environment variables still need to be fixed


Support customisation of the DataTable toolbar?

For example, I would like to place a filter icon here to open some filter options.
To be fair, I'm wrestling a bit with the toolbar, and wondering if I should just be creating my own widget area above the datatable?

Can I ask, what is the reason for flipping the overflow:visible|hidden on the bx--table-toolbar ? Trying to drop in my own OverflowMenu but this wiring is missing.

Assuming you're referring to this line: https://github.com/IBM/carbon-components-svelte/blob/master/src/DataTable/Toolbar.svelte#L19
It's needed for the ToolbarMenu to appear above the DataTable. This is because tooltips/overflow menus are implemented differently in this implementation compared to Carbon react. For example, the React implementation uses JavaScript to elevate and manage the position of the overflow menu.
Related #426 , #386

It's needed for the ToolbarMenu to appear above the DataTable.

Not 100% sure I understand.
I've forced it to be visible always without apparent issue atm. Do you mean to prevent it clashing with other tooltips / overflow menu's?

To clarify: it's needed for an opened ToolbarMenu to appear above the DataTable.
This is what happens when overflow is not set to visible:

Yes, but what is wrong with it always being set to visible?

🤔 In the initial implementation of the Toolbar, flipping between visible|inherit prevented some unexpected behavior, although it may have inadvertently been resolved by this commit: https://github.com/IBM/carbon-components-svelte/commit/425a259e65eb9e516466205a081df16f881ba5b2#diff-ada43f4000e193570970675e50b25e4f025feb49f0d0623e5629720f0ca991a8
I'm happy as long as it can be refactored without causing regressions, while supporting your custom OverflowMenu use case.

Not sure what you mean by this:

I'm happy as long as it can be refactored without causing regressions, while supporting your custom OverflowMenu use case.

If it's true that overflow:visible at all times has no unwanted side effects, then we can just leave the style active, and in that case,
wouldn't that now make ToolbarMenu redundant in favour of promoting regular use of OverflowMenu in its place ?

The ToolbarMenu contains specific business logic and class names: https://github.com/IBM/carbon-components-svelte/blob/master/src/DataTable/ToolbarMenu.svelte#L20

Without wanting to labour this too much - my POV was the business logic appeared only to be managing CSS which now appears to be redundant. The class - also nearly all redundant (in compact mode no additional CSS required, in standard mode only minor positional adjustments are required to place the icon more evenly?
I can accomodate my requirements very easily with a couple of style props on the existing OverflowMenu and ToolBar components and I don't want to press through some changes just to patch that.
The bigger question for me is if the existing ToolBarMenu is packing reduntant code and once stripped of this code, is it really necessary to ship it as another component when an existing component can drop in (with a wider range of features - icon at least).
I guess if your trying to hook into exsting carbon css code that does this you need to wrap with the class - but I'm wondering if a better alternative would be to provide 'native' support for the standard OverflowMenu?

The bigger question for me is if the existing ToolBarMenu is packing reduntant code and once stripped of this code, is it really necessary to ship it as another component when an existing component can drop in (with a wider range of features - icon at least).

We're definitely on the same page here. I strive to minimize the API surface area of this library; the more that can be done with less, the more maintainable it is.
You're right in pointing out that many of the Toolbar components wrap and re-export existing ones. I decided to keep them separate both for the case where they do have custom CSS (i.e., ToolbarMenu).

but I'm wondering if a better alternative would be to provide 'native' support for the standard OverflowMenu

This is the bigger issue that would resolve many of the current workarounds and unexpected behaviors for tooltip menus.

Your not setup to augment / add CSS to the base carbon?
.bx--toolbar-action then being replaceable by .bx--table-toolbar .bx--overflow-menu

Your not setup to augment / add CSS to the base carbon?

Currently, the library is decoupled from carbon-components. Yes – we pre-compile theme stylesheets but don't extend them in any way. Any custom CSS would have to be shipped directly with the Svelte code in style blocks.


Travis: migrate to container-based infrastructure

Oh... I seem doesn't work with rabbitmq service.


📝 Documentation for gated email notifications

Context: https://github.com/huggingface/moon-landing/pull/6820

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


feat: Migrate table component to design system

Description
Replaced table component imports to design system package and deleted table component from ads folder.
Fixes #17328
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested in local

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=dbcae80

/ok-to-test sha=ed37387

/ok-to-test sha=ab2d51e


feat(ui): allow to filter nodes in mesh graph

Fixes #2228
Fixes #2242

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 27.069%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3636

Relevant Lines:
14163

💛  - Coveralls


Custom Ringtones and autorun

Hi, i've searched but i have not found an answer.
I'm trying to use a raspberry to register multiple account, set a different ringtone for every account and connect to a speaker as a Loud ringer for a pbx.
I have 2 problems:

don't know how to start at boot

can't figure how to set a custom ringtone on account setting.

Thanks

Solution 1:
Create a simple systemd service to run baresip.

/etc/systemd/system/baresip.service
`[Unit]
Description=baresip
After=syslog.target network.target ntpdate.service
[Service]
Type=simple
User=pi
Group=pi
ExecStart=/usr/local/bin/baresip -f /home/pi/.baresip
[Install]
WantedBy=multi-user.target`
sudo servicectl enable baresip sudo service baresip start

Thanks! any hints on custom ringtone?

currently it is not supported to set different ringtones per account.
you can emulate the custom ringtones by replacing the content
of the WAV files in:
l share/*.wav
-rw-r--r--  1 alfredh  staff  64320 Oct 18  2018 share/busy.wav
-rw-r--r--  1 alfredh  staff  80418 Oct 18  2018 share/callwaiting.wav
-rw-r--r--  1 alfredh  staff  16776 Oct 18  2018 share/error.wav
-rw-r--r--  1 alfredh  staff   6356 Oct 18  2018 share/message.wav
-rw-r--r--  1 alfredh  staff  16568 Oct 18  2018 share/notfound.wav
-rw-r--r--  1 alfredh  staff  12180 Oct 18  2018 share/ring.wav
-rw-r--r--  1 alfredh  staff  68084 Oct 18  2018 share/ringback.wav


Tenant pointing to System database for password_reset

Hi,
I have installed and configured version 5.2, and it is working well up to logging in to a tenant website.
However, when I test the "Reset Password" bit, I get the following error:
SQLSTATE[42S02]: Base table or view not found: 1146 Table '**devjd_tenancy**.password_resets' doesn't exist (SQL: delete from `password_resets` where `email` =<EMAIL_ADDRESS>
"devjd_tenancy" is the system database, not the tenant database.
I have modified config/auth.php as follows:
'passwords' => [
        'users' => [
            'provider' => 'users',
            'table' => 'password_resets',
            'expire' => 60,
            **'connection' => 'tenant',**
        ],
    ],

This was suggested elsewhere.
The "User" model is using "UsesTenantConnection".
Any help would be appreciated.

Updating the configuration did not help, you still run into the same error? If so make sure you haven't cached your config php artisan config:clear

That was it, thank you. Working like a charm.

@NettSite Thank you for providing the password > users > connection configuration info! That fixed my problem like a charm. :)


Display all the friends (and avoid and other)

something I missed for https://github.com/beyond-all-reason/teiserver/pull/408 is that the default user query has a limit of 50. So for people like Lexon with a ton of friends, that page would only show up to 50 users total.

Great, thanks


Improve T35 testcase to avoid errors over ROSA cluster

After testing the T35 over a ROSA cluster the test case fails because the container inside the pod fails the first readiness probe, So I include an improvement to check when the container is n of n ready
https://issues.redhat.com/browse/OSSM-3023

Adding more improvement based of @jewertow review

@jewertow @yxun Ready to review again


Lightbox to header, add tooltip to buttons and small styling adjustments (Meta #119)

Blocked by https://github.com/araise-dev/CrudBundle/pull/75


SSN Mask

@RobinHerbots I have something that is similar to this issue. Since it is open, I thought this would be the appropriate place to put the question in. If we take the example above, https://jsfiddle.net/cecey8Ly/3/ and let's say, we have ssn value which consists of 9 digits and we want to be able to mask the numbers starting with zero as valid SSN, how would we do that?
Right now, if we add the mask alias as numeric and specify the integer digits as 9, we cannot enter SSN values without a zero because the mask removes the leading 0 from the number.
Sample test case
Actual Value: 012345678.
Masked Value: 12345678
Originally posted by @awalakaushik in https://github.com/RobinHerbots/Inputmask/issues/1883#issuecomment-562227157

https://github.com/RobinHerbots/Inputmask/pull/2240#issuecomment-562587347

@awalakaushik,
We need to see if the validation is all possible in one regex.

@RobinHerbots Sure. I agree. I'll try to do that over the weekend and see if I can create another pull request for the same with an example to it. Please let me know if you have any suggestions on how you want to do it.

http://rion.io/2013/09/10/validating-social-security-numbers-through-regular-expressions-2/

@awalakaushik,
I updated your version of the ssn mask.  Can you have a try.

Sure. I can do that. Thanks.


Make FeatureInfoWindow working again

FeatureInfoWindow.vue seems to be somewhat "disconnected" from the current Wegue configuration and initialization.
Even if configured, only one Layer (layerId) can be used within a Wegue App because of modules config-(keys)-convention.
This issue is to have at least the basics working again:

enable to be configured
enable to be initialized
have some demo data (with info and image URL attributes)
possibly enable for more than just one Layer (layerId)

Some first results:


Fix #5590 QueryStringDecoder#path should decode the path info

@ngocdaothanh LGTM... can you please adjust the commit message to match our template:
http://netty.io/wiki/writing-a-commit-message.html

Thanks for the instruction. I've improved the commit message.

Cherry-picked into 4.1 (835f901d5f30fb125672cfd8ae32061e55c5b58f) and 4.0 (b548579a3d72da91df7be7fdc73263c28196517d)


AttributeError: 'Linear' object has no attribute 'set_lora_layer'

Whether I uninstall peft or not, I am still facing this bug, can someone tell me the solution.

This repository hasn't been updated with the new diffusers version. In version 0.25.0, where, i.e. peft was introduced, the train_dreambooth_lora_sdxl.py file was entirely updated, and there is no set_lora_layer used there anymore.
I managed to run these older scripts (the ones in this repo) for both LoRA and ZipLoRA fine-tuning by downgrading most of the modules. Here is my requirements.txt file that enables me to run LoRA training in this repo; I hope it helps:
accelerate==0.29.3
diffusers==0.24.0
ftfy==6.2.0
huggingface-hub==0.22.2
Jinja2==3.1.3
numpy==1.26.4
pillow==10.3.0
pytorch-cuda==12.1
safetensors==0.4.3
tensorboard==2.16.2
torch==2.2.2
torchvision==0.17.2
tqdm==4.66.2
transformers==4.40.1
triton==2.2.0
wandb==0.16.6
xformers==0.0.25.post1


RDPDR crashes on windows

When I try to use redirected drive on the remote desktop, the following exception occurs:
Unhandled exception at 0x779AE41B (ntdll.dll) in wfreerdp.exe: 0xC0000005: Access violation writing location 0x00000000.

The funny thing that this is not the constant behavior. After a few crashes redirection starts to work normally. But when I try to use another build of freerdp(I have four), crashes appear again, and again they disappear after a while.
Also crashes are guaranteed if I try to use "dir \tsclient\drive". But read and copy of one file doesn't always fail.
I'm trying to connect to windows server 2012. My command line is:
wfreerdp /v:address /u:user /p:pass -wallpaper /drive:drive,C:\folder

I'm using latest version of FreeRDP, downloaded it today. My operating system is Windows 7 x64. Compiled FreeRDP in Visual Studio 2015(and 2013 for one of the builds).

@melanholy can you try to verify if this behavior is also reproducible with our nightly build from https://ci.freerdp.com/job/freerdp-nightly-windows/arch=win64,label=windows/lastSuccessfulBuild/artifact/build/wfreerdp.exe

Doesn't crash with this build. Is this build stable? Can I use for my work?

@melanholy those builds are built nightly if a commit happened during the day. It's based on the master branch if a build works for you you can use it for work.


Automate regression test checking

This is related to #269 issue

if you execute run.py this would be the result so now we need to have more structured way to handle tests

This looks awesome!
Do the bash and python do the same thing? I'd rather only maintain one if so, and python seems much better for the task.
I do think we'll need to be able to output the results to YAML/JSON for any post processing (e.g. failing CI/CD)

the result that you see was built using python, the bash script was just the first version I will try to remove it after trying to make an architecture for the regression framework

Closing this one in favor of the more recent one @dorbanianas put together


Cannot create a container with the specific alias "tasks"

Required information

Distribution: Ubuntu
Distribution version: 15.10
The output of "lxc info" or if that fails:

Kernel version: 4.2.0-38-generic
LXC version: 2.0.1
LXD version: 2.0.2
Storage backend in use: zfs

Issue description
When trying to launch a container with the specific alias "tasks", it fails to launch.
Steps to reproduce

Run  "lxc launch ubuntu:x tasks"
The output is
Creating tasks
Starting tasks
error: Error calling 'lxd forkstart tasks /var/lib/lxd/containers /var/log/lxd/tasks/lxc.conf': err='exit status 1'
Try lxc info --show-log tasks for more info
Exit 1

Explanation
The reason is that in /sys/fs/cgroup/systemd/lxc/ there is already a sysfs file called "tasks". In that directory, any new container is created as a new directory that has their alias as their name.
Since "tasks" is reserved", lxc fails to create the directory and fails to continue.
Here are the contents of the directory
$ ls -l /sys/fs/cgroup/systemd/lxc/
total 0
drwxrwxr-x 5 root 165536 0 Ιούν 10 12:32 c1
-rw-r--r-- 1 root root 0 Ιούν 10 12:53 cgroup.clone_children
-rw-r--r-- 1 root root 0 Ιούν 10 12:53 cgroup.procs
-rw-r--r-- 1 root root 0 Ιούν 10 12:53 notify_on_release
-rw-r--r-- 1 root root 0 Ιούν 10 12:53 tasks
Currently, there is only potential conflict with "tasks" as the other filenames are invalid hostnames (contain dots or underscores).
Presumably in the future there might be more such files.
Among the solutions,

the container directories in /sys/fs/cgroup/systemd/lxc/ should have something like ".lxd" appended to them so that there is no future conflict.

Can you file this against github.com/lxc/lxc instead?
LXD doesn't pick the cgroup name, it's done by the LXC library (and github doesn't let us move issues between repos...).

Done, it's at https://github.com/lxc/lxc/issues/1046


TensorFlow installation with Coach failed

Hi,
Tried follow installation instructions. But after very long, more than half an hour installation process I found TensorFlow not working when I tried an example script:
python coach.py -r -p Pendulum_ClippedPPO -n 8
Traceback (most recent call last):
  File "coach.py", line 23, in <module>
    from architectures import *
  File "/home/viktor/DeepRL/coach/architectures/__init__.py", line 20, in <module>
    from architectures.tensorflow_components.general_network import *
  File "/home/viktor/DeepRL/coach/architectures/tensorflow_components/general_network.py", line 17, in <module>
    from architectures.tensorflow_components.embedders import *
  File "/home/viktor/DeepRL/coach/architectures/tensorflow_components/embedders.py", line 20, in <module>
    class InputEmbedder:
  File "/home/viktor/DeepRL/coach/architectures/tensorflow_components/embedders.py", line 21, in InputEmbedder
    def __init__(self, input_size, activation_function=tf.nn.relu, name="embedder"):
AttributeError: module 'tensorflow' has no attribute 'nn'

Also I supposed from the description that it'll install in the virtual env, but instead this installation also has broken my default TensorFlow-GPU installation. So:

Why installation is so long? Installtion of the OpenAI baselines with just "pip install -e ." takes less than a minute for example, the same as rllab.
How this TF installation bug can be fixed?

Hi Viktor,

Coach's installer installs all the dependencies needed for ramping up Coach & Gym (at the bare minimum) over TensorFlow. It makes no assumption on your installed dependencies, and so can be used to install on a vanilla Ubuntu 16.04 image. If one of the dependencies is already installed on your system it will not be installed again (apt-get and pip take care of that).

Unless installed with the --no_virtual_environment flag, Coach should install in a virtualenv.
a. Are you running Coach from within the virtualenv ("source activate coach_env")?
b. From within the virtualenv, could you please check what is the tensorflow version installed (python -c "import tensorflow; print(tensorflow.version)")?

About the installation time - it highly depends on your machine, internet connection and if some the packages are already installed. This is an approximate breakdown of the installation time on a clean machine:

1:20 mins - initial dependencies (pip, virtualenv etc.)
1:40 mins - coach dependencies
07:00 mins - dashboard dependencies (mainly due to wxPython)
0:45 mins - openai gym
04:45 mins - neon, ngraph and mkl-dnn
02:00 mins - tensorflow

If your are short on time, you can choose to install a subset of the requirements in the installation script

Thanks for the reply, was able to perform clean installation from scratch. Everything is working.

Hi, I have a similar problem, but cannot do a clean installation from scratch. I installed everything, but when I put python -c "import tensorflow; print(tensorflow.__version__)" from within the virtual environment, I get the following:
(coach_env) linda@linda:~$ python -c "import tensorflow; print(tensorflow.__version__)"
Traceback (most recent call last):
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
  File "/home/linda/coach_env/lib/python3.5/imp.py", line 242, in load_module
    return load_dynamic(name, filename, file)
  File "/home/linda/coach_env/lib/python3.5/imp.py", line 342, in load_dynamic
    return _load(spec)
ImportError: libcublas.so.10.0: cannot open shared object file: No such file or directory

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/__init__.py", line 24, in <module>
    from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/__init__.py", line 49, in <module>
    from tensorflow.python import pywrap_tensorflow
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow.py", line 74, in <module>
    raise ImportError(msg)
ImportError: Traceback (most recent call last):
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in <module>
    from tensorflow.python.pywrap_tensorflow_internal import *
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in <module>
    _pywrap_tensorflow_internal = swig_import_helper()
  File "/home/linda/coach_env/lib/python3.5/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
    _mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
  File "/home/linda/coach_env/lib/python3.5/imp.py", line 242, in load_module
    return load_dynamic(name, filename, file)
  File "/home/linda/coach_env/lib/python3.5/imp.py", line 342, in load_dynamic
    return _load(spec)
ImportError: libcublas.so.10.0: cannot open shared object file: No such file or directory

Failed to load the native TensorFlow runtime.

See https://www.tensorflow.org/install/errors

for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.


Add .gitignore to scaffolding process

I'm not sure if this is an oversight, or intentional, but I'd love to have the discussion documented. There is currently no .gitignore boilerplate, which adds a little extra work after starting the project. I'm proposing adding this, and potentially also adding the git init step to the scaffolding process.
I think it is fair to assume (or just provide an option) that someone would be using git for these projects, so could be a tiny win to go from running the create apollo-app command to writing code straight away.
I'm happy to contribute this if maintainers approve of this idea?

@CodeSpent I'm fine with this idea, but we should ignore git init errors, so that if use do not have git installed it won't fail

@CodeSpent I'm fine with this idea, but we should ignore git init errors, so that if use do not have git installed it won't fail

@larixer great, I can handle that. Do you think it'd make more sense to add a second option after the initial menu selection asking the user if they want to initialize git? Can still fail silently, but this would also let them opt out of a .gitignore if for any reason they don't want one.

@larixer great, I can handle that. Do you think it'd make more sense to add a second option after the initial menu selection asking the user if they want to initialize git? Can still fail silently, but this would also let them opt out of a .gitignore if for any reason they don't want one.

@CodeSpent I think pretty much everyone uses git these days, so just failing silently is fine, IMO, no need to complicate the task for yourself

@CodeSpent I think pretty much everyone uses git these days, so just failing silently is fine, IMO, no need to complicate the task for yourself


Form Dialogs Parity

This issue should aggregate and take precedence over any disparate Form Dialog parity issues. Let's keep a single issue open and reference the old ones.

Reviewed by the SDK team. Closing as Not Needed.


iOS: Can flutter release build be built using xcode or something else than "flutter build ios"?

Does anyone know if flutter release build can be built using xcode only? Unfortunately my mac is to old for upgrading to the latest xcode 10.2, When trying to build with flutter build ios I get "Found "Xcode 10.1, Build version 10B61". Xcode 10.2 or greater is required to develop for iOS.
Encountered error while building for device."
I've tried to build the app using xcode and it succeeds, however I get this message from apple after failed upload:
ITMS-90338: Non-public API usage - The app references non-public symbols in Frameworks/Flutter.framework/Flutter: _ptrace. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/
Any help or input is highly appreciated, thanks!

@matte5031 I have an old MacBook Pro, I upgraded it by doing a hackintosh, and was able to get Catalina on this laptop to get Xcode, and so far so good. check out DosDude1.com
Might save you some cash.

@stickypages Thanks for reaching out. It's fine I've managed to upgrade to catalina a few months ago aswell so it's all working fine now!

Code on!


How to stub current_user in decorator method with rspec?

I have a decorator(active_decorator) which refers current_user.
event_decorator.rb
module EventDecorator
  def applied?
    user_applied(current_user.id).exists?
  end
end

Included devise test controller but raises an error.
rails_helper.rb
config.include Devise::Test::ControllerHelpers, type: :decorator

event_decorator_spec.rb
describe 'applied?' do
  let(:current_user) { create(:user) }
  let(:event) { create(:event, user: create(:user)) }

  before do
    decorate event
    allow(event).to receive_message_chain(:current_user, :id) { 1 }
    allow(event).to receive_message_chain(:user_applied, :exists?) { true }
  end

  it { expect( event.applied?).to be_truthy }
end

Error message
 NoMethodError:
       undefined method `env' for nil:NilClass
       Did you mean?  end

This message may come from
https://github.com/heartcombo/devise/blob/eed641d2bea11839ab13e943660da41cad14314d/lib/devise/test/controller_helpers.rb#L43-L45
Environment

Ruby [2.7.1]
Rails [<IP_ADDRESS>]
Devise [4.7.2]

ControllerHelpers are meant to be included in the context of a controller, they'll expect things to be there that only a controller can provide.
Since it's a module there, it looks like you can just stub current_user on self (or event in that case), and assume that's the contract you need/have.
allow(event).to receive(:current_user) { my_user }

I don't really know how event would have a "current_user" though in your context (please provide a full example if you need further help), but it should be something along the lines above to get it working.

Thanks for your comment but it doesn't work and raise the same error. (updated rspec code).
The event is a model that belongs to a  user,  but the current_user in event_decorator does not refer to the association but the current_user in session.  The EventDecorator method applied? is used only in views.
class Event < ApplicationRecord
   belongs_to :user # applied? method does not refer to this association
end

When deleting including Devise::Test::Controller cause MissingWarden error (below).
Devise::MissingWarden:
       Devise could not find the `Warden::Proxy` instance on your request environment.
       Make sure that your application is loading Devise and Warden as expected and that the `Warden::Manager` middleware is present in your middleware stack.
       If you are seeing this on one of your tests, ensure that your tests are either executing the Rails middleware stack or that your tests are using the `Devise::Test::ControllerHelpers` module to inject the `request.env['warden']` object for you.

Sorry I probably misunderstood your original comment/question. What does decorate event do? I'm assuming it's something like extending the given object with the decorator module?
I tried reproducing your scenario with a quick script, just not including Devise (because I think what you're hitting is not Devise specific), and this passes:
require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem 'rspec'
end

class User
  attr_reader :id

  def initialize(id:)
    @id = id
  end
end

class Event
  attr_reader :user

  def initialize(user:)
    @user = user
  end
end

module EventDecorator
  def applied?
    user_applied(current_user.id).exists?
  end
end

require "rspec/autorun"

RSpec.describe 'applied?' do
  let(:current_user) { User.new(id: 1) }
  let(:event) { Event.new(user: User.new(id: 2)) }

  before do
    decorate event
    allow(event).to receive_message_chain(:current_user, :id) { 1 }
    allow(event).to receive_message_chain(:user_applied, :exists?) { true }
  end

  def decorate(object)
    object.extend(EventDecorator)
  end

  it { expect(event).to be_applied }
end

Like I mentioned earlier, Devise::Test::ControllerHelpers are meant to be included in Controller specs only. If you're testing something in isolation that only needs a current_user, generally its best to just assume one is there by providing it.

Sorry to bother you. I agree with you on the point that just provides current_user.
This is not a Devise issue but a decorator.
I've defined current_user in the test because the normal stubbing way doesn't work in this decorator.
I know it's not a smart way but works somehow
Thanks for your help 🙏
describe 'applied?' do
  let(:event) { create(:event, user: create(:user)) }

  before do
   module EventDecorator
      def current_user; end
    en
    decorate event
    allow(event).to receive_message_chain(:user_applied, :exists?) { true }
  end

  it { expect( event.applied?).to be_truthy }
end


Mod Engine don't work for cracked games

Hi please make it work for cracked games please thank you

yep

Buy the game and support the developers or don't use mods.

I want To

its working just edit .bat file to this
.\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "D:\Games\ELDEN RING\Game\eldenring.exe"
change your game path folder

@mrsilas666  i just modified the .bat for launchmod_eldenring.bat but the result is the same. (i even have EXACTLY the same path as you do lol)

Tried that, I have the same exact path as well. The ModEngine window pops up for a split second then closes. :-(

Tried that, I have the same exact path as well. The ModEngine window pops up for a split second then closes. :-(

Same here, modengine2 don't start!!

Tried that, I have the same exact path as well. The ModEngine window pops up for a split second then closes. :-(

Make sure your folder structure looks like "D:\folder\folder\folder\ARMORED CORE VI FIRES OF RUBICON\Game\armoredcore6.exe" You have to have the exe and game contents inside a folder called "game" that is inside the Elden Ring folder or AC6 folder etc. I also used this method with AC6 https://www.reddit.com/r/CrackSupport/comments/169dli3/armored_core_6_cracked_mod_engine_2_help/ idk if it was actually necessary but it works now after using the above advice

Tried that, I have the same exact path as well. The ModEngine window pops up for a split second then closes. :-(

With the help of the friend mrsilas666 above it worked correctly. On mine it looked like this in the .bat file: .\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "E:\Games\Elden Ring - Deluxe Edition [Steam-Rip] by Ksenia\ELDEN RING\Game\eldenring.exe"
And it worked as intended.

Launching the Convergence: Elden Ring.
[2024-06-14 15:39:08.122] [stderr] [error] Couldn't create process: 2e4
Convergence: Elden Ring has failed to launch.
Please follow the Troubleshooting Checklist guide found in #troubleshooting in our Discord.
that is what im getting after lunch mod loader
any help?

I would suggest that you guys replace the default code of launchmod_eldenring.bat with below lines of the code
@echo off chcp 65001 cd /d "%~dp0" .\modengine2_launcher.exe -t er -c .\config_eldenring.toml --game-path "C:\detroit\ELDEN RING\Game\eldenring.exe" pause
Please make sure you replace that game path with your own eldenring.exe path.
Now run your this .bat file as an Administrator and you'll be good to go.


Webpack: Move the styles consumed by 5xx.html to webpack.

This commit removes the need for portico.css to be generated
by the Django pipeline and makes the error page use the css
file compiled by webpack instead.

Testing Plan:
Tested the 500 page is styled correctly.
GIFs or Screenshots:

(That's the only obvious problem with this other than maybe a missing comment, so I'm going to just fix that and test-deploy to chat.zulip.org).

Merged, thanks @armaanahluwalia!


Add ability to respond to speaker and the chatroom at the same time

Bugs

[x] #17
[x] #16

Replaced by #20


Refactor components to pass down editable argument to SummaryList

Context
I added a whole bunch of duplication when adding editable argument for components.
Changes proposed in this pull request
This PR refactors component to pass down editable to SummaryListComponent so it handles whether or not editing links should be shown so we can remove the if @editable for each key and value pair for each row in each review component. 😅
Guidance to review
Does this make sense? Is this a better solution?
Link to Trello card
N/A

Rather than passing a flag onwards to SummaryListComponent, can we instead massage the input in the SummaryCardComponent?
eg If not editable, maps the rows passed in to remove action, change_path and action_path keys?
This will keep SummaryListComponent simpler, aligned with design system component, and as it's intended for wider use (eg in provider UI).

Following a conversation with @fofr, it is unnecessary to have a deletable parameter. As if a section is editable, all things can be changes (or deleted).


Fix broken types

What is the motivation?
Types are currently broken resulting .status and .result to be unavailable when library is used when using TypeScript 5.3.2.

What does this change do?
Fixes the types.
What is your testing strategy?
Verifying with TypeScript.
Is this related to any issues?

https://github.com/sebastianwessel/surrealdb-client-generator/issues/3

Have you read the Contributing Guidelines?

[x] I have read the Contributing Guidelines

@kearfy could you please check this PR?

Hey @alexgorbatchev, I tried to see if I get the same error as you with a couple of typescript versions, but I'm unable to reproduce this issue. Could you try to update your typescript version, possibly to a nightly or beta to see if the issue still presents itself? The type is intended to be inferred, and we really should not need to set a return type for that method. Thank you!

@kearfy i'm using TS 5.3.3. I don't think being on nightly should be a requirement for this package to work. Your users probably won't be running on nightly during regular development.
Getting this module to work without deno is somewhat painful tbh... my tsconfig.json
{
  "compilerOptions": {
    "lib": ["DOM", "ESNext"],
    "outDir": "./dist",
    "experimentalDecorators": true,
    "noEmit": true,
    "allowImportingTsExtensions": true,
    "paths": {
<EMAIL_ADDRESS>["./node_modules/zod"],
      "npm:unws": ["./node_modules/unws"]
    }
  },
  "include": ["./src/**/*"]
}

❯ npm ls typescript
surrealdb.js@ /home/alex/development/github/surrealdb.js
└──<EMAIL_ADDRESS>
❯ npm exec tsc --project=./tsconfig.json` produces
node_modules/unws/src/index.d.ts:1:10 - error TS2661: Cannot export 'WebSocket'. Only local declarations can be exported from a module.

1 export { WebSocket, type MessageEvent }
           ~~~~~~~~~

node_modules/unws/src/index.d.ts:1:26 - error TS2661: Cannot export 'MessageEvent'. Only local declarations can be exported from a module.

1 export { WebSocket, type MessageEvent }
                           ~~~~~~~~~~~~

src/strategies/http.ts:204:21 - error TS2347: Untyped function calls may not accept type arguments.

204   const res = await this.request<InvalidSQL | MapQueryResult<T>>("/sql", {
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
205    body: query,
    ~~~~~~~~~~~~~~~
...
216     ),
    ~~~~~~
217   });
    ~~~~

src/strategies/http.ts:230:23 - error TS2347: Untyped function calls may not accept type arguments.

230   const [res] = await this.request<[QueryResult<ActionResult<T>[]>]>(
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
231    url,
    ~~~~~~~
...
234    },
    ~~~~~
235   );
    ~~~

src/strategies/http.ts:252:23 - error TS2347: Untyped function calls may not accept type arguments.

252   const [res] = await this.request<[QueryResult<ActionResult<T, U>[]>]>(
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
253    url,
    ~~~~~~~
...
257    },
    ~~~~~
258   );
    ~~~

src/strategies/http.ts:277:23 - error TS2347: Untyped function calls may not accept type arguments.

277   const [res] = await this.request<[QueryResult<ActionResult<T, U>[]>]>(
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
278    url,
    ~~~~~~~
...
282    },
    ~~~~~
283   );
    ~~~

src/strategies/http.ts:302:23 - error TS2347: Untyped function calls may not accept type arguments.

302   const [res] = await this.request<[QueryResult<ActionResult<T, U>[]>]>(
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
303    url,
    ~~~~~~~
...
307    },
    ~~~~~
308   );
    ~~~

src/strategies/http.ts:323:23 - error TS2347: Untyped function calls may not accept type arguments.

323   const [res] = await this.request<[QueryResult<ActionResult<T>[]>]>(
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
324    url,
    ~~~~~~~
...
327    },
    ~~~~~
328   );
    ~~~

Found 8 errors in 2 files.

Errors  Files
     2  node_modules/unws/src/index.d.ts:1
     6  src/strategies/http.ts:204

Ignoring errors in node_modules, the other errors are in src/strategies/http.ts, which is what I'm trying to fix with this PR.

Update on this, since deno can simply import packages from NPM we'll likely convert this back to a normal NodeJS project. I've found that Deno can sometimes act flaky, where types resolve in one place but not in the other, which could also be the reason that this was an issue for you but not for me!

It would be useful to merge this in the meanwhile, it's been 2 months.

Hey @alexgorbatchev, I've been unable to reproduce this issue in the old library, and we've since revamped the library. If you can still reproduce this issue somehow, feel free to let me know. I will be closing your PR however in the meantime


[script] unknown field [source], parser not found

[x] elastic.v5 (for Elasticsearch 5.1.1)
Im using v5 for build some queries and actually is returning this error:
elastic: Error 400 (Bad Request): [script] unknown field [source], parser not found [type=illegal_argument_exception]
Is there any change to affect this? In new builds, this began to happen ... in old builds, no errors occur.

@aymone Hmm... there was a script-related change recently. But that should've been a fix for 5.x and not break something.
Can you post a reproducible example where this happens?

I think the problem is this line:
https://github.com/olivere/elastic/commit/3c424ca8458cd544edee9e16f798d99fcb61e373#diff-dfc827036953b6615f2165f673c4d874R91
I will create a fork before this commit to work with elastic 5.1.1 (AWS version).

Yes. That's what triggered the change mentioned above (see #627). However, using source there instead of inline is correct according to the documentation and the Java source.

... and this integration test proves that it actually works with source.

Yes, but only for ES >5.6...
https://www.elastic.co/guide/en/elasticsearch/reference/5.1/modules-scripting-using.html

Oh well. So the guys from Elastic did a breaking change in a minor version.

5.6
5.5
5.4
5.3
5.2
5.1
5.0

Okay. That definitely needs a workaround...

Im really disapointted too...

I've never seen that. I will create 5.0.56 with a fix tomorrow (it's 11p.m. here).

thanks @olivere , once more time, u are helping me.

I'll release 5.0.56 soon which reverts the scripting changes back to using inline instead of source for 5.x.

Hi,
I am using ES High Level Rest Client 5.6.2 and ES on AWS version 5.5; I get the same error. Should I use client 5.5 instead?
Thank you

We started with client 5.6 and when we deployed ES on AWS, it was supporting 5.5;
Although it is supporting 5.6 now, but it would be lots of work to upgrade all environments to new version. So either we should downgrade our client to 5.5 or do a workaround for 5.6

Just to understand: What do you mean with „client 5.6“? The latest version of Elastic for Elasticsearch 5.x is 5.0.65.


support subdomain

test.com
a.test.com

example and usage: https://github.com/tonny-zhang/cotton-example/blob/master/domain/main.go


removing cached metadata when the server returns an error

Description
Don't cache metadata errors
GitHub Issues

#166

Coverage increased (+0.01%) to 92.573% when pulling 17bd8baccf70ebab8fc725986cdb0483f371a70a on mcrowson:no_cache_errors into c65b6b3fa1ea7b0483b364ddcca01390a2a6ef32 on refindlyllc:master.


Prolific stage1 get weird color with large steps?

using prolificdreamer-patch.yaml to launch the program with 25000 total steps. and before step 5600 it's fine. but after 8000, the result color breaks. And It seems happen is the latter steps no matter how many total steps it is (e.g. total 10000, then break in 4000 maybe)
I guess it's maybe the hyperparameter? I lower the  lambda_sparsity and the break show up a bit latter.
Example are here:

This problem does exist in some cases, mostly due to the annealing strategy (t~[0.02,0.98] -> [0.02, 0.5]). This may be a point for improvement, such as a better annealing strategy. You can try to increase the lower bound. I am not sure whether some recent works can improve it, e.g. TP-SDS.

The time step range of [0.02, 0.5] may produce strange colors in some cases.


Camera / Streaming Control window isn't rotatable

The Camera / Streaming control window appears to rotation locked in the orientation it gets spawned in. All the other userspace windows I have tried appear to be able to rotate freely.

FIXED: Restored VR behaviour of the camera controls UI - can be moved same as dash in freeform mode - UI always faces user, can be slided around user and moved further or closer in relation to user. If normal, non slider UI is the request, please split off into separate issue.


make website layout

As a customer, I want to be able to see the vilnaCRM website
this task is for the main website page
design
Technical requirements

[ ] react (https://reactjs.org/)
[ ] nextjs (https://nextjs.org/)
[ ] nextjs routes (https://nextjs.org/docs/routing/introduction)
[ ] typescript (https://www.typescriptlang.org/)
[ ] MUI (https://mui.com/)
[ ] Cypress (https://www.cypress.io/)
[ ] jest (https://jestjs.io/ru/)
[ ] react testing library (https://testing-library.com/docs/react-testing-library/intro)
[ ] Storybook (https://storybook.js.org/)

Tasks

[ ] features: landing, login, signup, docs
[x] make the user use higher Node.js version (20.0.0+)
[x]  update obsolete packages' dependencies to the latest ones
[x] implement the sticky menu, add the supporting to responsive design for statcounter

[x] button "try it out" must scroll to the section with registration which must be at the bottom
[x] for mobile version menu must open like a drop-down list

[ ] use for all texts i18n (for example t('text_1')) react-i18next
[x] implement header, add block header according to design
[x] implement block "why we", add slider for mobile
[x] implement block "for who", add button "try it out"
[x] implement block "unlimited possibilities of integrations", add a slider for the mobile version
[ ] implement registration block

[ ] add a registration form
[ ] add validation for form (initial, password, email)
[ ] add registration button and add mock for registration
[ ] add the possibility of registration registration accounGoogleHub, Facebook, or Twitter

[ ] implement footer

[ ] icons after click must open our Instagram. facebook, GitHub, LinkedIn
[ ] email must have mailto links

[ ] add e2e tests

[ ] if set mobile width and click menu, must open the menu and be visible
[ ] after click "try it out", website must scroll to the bottom where the registration block
[ ] check registration inputs, they must validate data in the input

[ ] add unit tests
[ ] add google analitycs

Acceptance criteria

[ ] pixel perfect
[ ] the whole website according to the design
[ ] the whole website has responsive design
[ ] self-review
[ ] login and register buttons need to work as expected
[ ] the slider needs to exist in the mobile version
[ ] sign in through the social buttons need to work
[ ] registration form needs to work as expected
[ ] menu needs to work as expected for the mobile view
[ ] all CI checks need to be passed

The Password must not contain any Whitespaces.
The Password must contain at least one Uppercase character.
The Password must contain at least one Lowercase character.
The Password must contain at least one digit.
The Password must have at least one Special Symbol.
The Password must be 8-32 characters long.

on design form registration have incorrect centered elements, form is not centered correctly, divider not centered correctly, buttons for social media not centered correctly


Support Cross-Account CodeCommit repos

I would like to be able to create an Amplify Console app in a deployment account (dev, qa, prod) which is deployed from a CodeCommit repository stored in another account (shared-services)

Looks like similar to this https://github.com/aws-amplify/amplify-console/issues/64

Looks like similar to this https://github.com/aws-amplify/amplify-console/issues/64

Do you know if there's any update about this issue?