Add support for adding intervals to dates

Re #527.
Rationale for this change
Support for adding scalar intervals to scalar dates was added in datafusion, but in order to support adding columns to columns, we need to move that logic down into an arrow kernel.
What changes are included in this PR?

Support for adding interval types to date types
A change to add_dyn to allow it to accept lambda functions with two differing parameter types

Are there any user-facing changes?
Adding intervals to dates should work now.

Looks like there is a minor clippy error: https://github.com/apache/arrow-rs/runs/7256871633?check_suite_focus=true

Looks like there is a minor clippy error: https://github.com/apache/arrow-rs/runs/7256871633?check_suite_focus=true

I had to re-install ubuntu to get clippy to work, but the next iteration should pass.

Codecov Report

Merging #2031 (2068071) into master (ca1bfb8) will increase coverage by 0.07%.
The diff coverage is 98.75%.

@@            Coverage Diff             @@
##           master    #2031      +/-   ##
==========================================
+ Coverage   83.54%   83.61%   +0.07%
==========================================
  Files         222      223       +1
  Lines       58178    58467     +289
==========================================
+ Hits        48604    48887     +283
- Misses       9574     9580       +6

Impacted Files
Coverage Δ

arrow/src/datatypes/mod.rs
99.24% <ø> (ø)

arrow/src/compute/kernels/arithmetic.rs
93.97% <97.53%> (+0.35%)
:arrow_up:

arrow/src/datatypes/types.rs
97.46% <98.57%> (+8.57%)
:arrow_up:

arrow/src/datatypes/delta.rs
100.00% <100.00%> (ø)

parquet/src/arrow/record_reader/mod.rs
89.17% <0.00%> (-0.19%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.98% <0.00%> (+0.22%)
:arrow_up:

parquet/src/arrow/arrow_reader.rs
92.67% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1bfb8...2068071. Read the comment docs.

Could anyone help me with reproducing this locally, or understanding what went wrong?
==========================================================
Testing file duration
==========================================================
Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/runner.py", line 246, in _run_ipc_test_case
    run_binaries(producer, consumer, test_case)
  File "/arrow/dev/archery/archery/integration/runner.py", line 286, in _produce_consume
    consumer.stream_to_file(producer_stream_path, consumer_file_path)
  File "/arrow/dev/archery/archery/integration/tester_csharp.py", line 63, in stream_to_file
    self.run_shell_command(cmd)
  File "/arrow/dev/archery/archery/integration/tester.py", line 49, in run_shell_command
    subprocess.check_call(cmd, shell=True)
  File "/opt/conda/envs/arrow/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/arrow/csharp/artifacts/Apache.Arrow.IntegrationTest/Debug/net6.0/Apache.Arrow.IntegrationTest --mode stream-to-file -a /tmp/tmpzg7b26id/29338ab4_generated_datetime.consumer_stream_as_file < /tmp/tmpzg7b26id/29338ab4_generated_datetime.producer_file_as_stream' returned non-zero exit status 1.
################# FAILURES #################
Traceback (most recent call last):
FAILED TEST: datetime Java producing,  C# consuming
  File "/arrow/dev/archery/archery/integration/runner.py", line 246, in _run_ipc_test_case
    run_binaries(producer, consumer, test_case)
  File "/arrow/dev/archery/archery/integration/runner.py", line 286, in _produce_consume
    consumer.stream_to_file(producer_stream_path, consumer_file_path)
  File "/arrow/dev/archery/archery/integration/tester_csharp.py", line 63, in stream_to_file
    self.run_shell_command(cmd)
  File "/arrow/dev/archery/archery/integration/tester.py", line 49, in run_shell_command
    subprocess.check_call(cmd, shell=True)
  File "/opt/conda/envs/arrow/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/arrow/csharp/artifacts/Apache.Arrow.IntegrationTest/Debug/net6.0/Apache.Arrow.IntegrationTest --mode stream-to-file -a /tmp/tmpzg7b26id/4b457ee3_generated_datetime.consumer_stream_as_file < /tmp/tmpzg7b26id/4b457ee3_generated_datetime.producer_file_as_stream' returned non-zero exit status 1.
FAILED TEST: datetime Rust producing,  C# consuming

Thanks!

@avantgardnerio It's a flaky test #1931 that should have now been fixed https://github.com/apache/arrow/pull/13573. I'll rerun the CI job and it should clear

@avantgardnerio It's a flaky test #1931 that should have now been fixed apache/arrow#13573. I'll rerun the CI job and it should clear

Looks great, thanks!

🎉

@avantgardnerio  I wonder if you are tracking the "add support for adding interval columns to dates/timestamps" in datafusion somewhere?
I ask because https://github.com/apache/arrow-datafusion/pull/3110 by @JasonLi-cn is starting to add support for timestamps

if you are tracking

I was not, but am now, ty!


Unable to receive channel message without mentioning bot

I followed the documentation where I added the webApplicationInfo inside manifest.json to include RSC permissions. However, I still do not receive any message activity when the bot is not mentioned in the message.
"webApplicationInfo": {
    "id": "<i have updated app id here>",
    "resource": "https://AnyString",
    "applicationPermissions": [
      "ChannelMessage.Read.Group"
    ]
  }

Below is my code to echo the message:
protected override async Task OnMessageActivityAsync(ITurnContext<IMessageActivity> turnContext, CancellationToken cancellationToken)
        {
            await turnContext.SendActivityAsync(MessageFactory.Text($"Echo: {turnContext.Activity.Text}"), cancellationToken);
        }

I have checked against permissionGrant restful API (https://graph.microsoft.com/v1.0/groups/{groupid}/permissionGrants) and it includes "ChannelMessage.Read.Group"
{
<EMAIL_ADDRESS>"https://graph.microsoft.com/v1.0/$metadata#permissionGrants",
    "value": [
        {
            "id": "<id ....>",
            "deletedDateTime": null,
            "clientId": "<client id ...>",
            "clientAppId": "<client app id ...>",
            "resourceAppId": "<resource app id ...>",
            "permissionType": "Application",
            "permission": "ChannelMessage.Read.Group"
        }
    ]
}

Here is a screenshot of the current situation (bot still only receives the message when bot is @mentioned.)

Thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e0acfd2-0965-65f4-2200-ca06424a3976
Version Independent ID: fd7f72fe-5dba-369a-c436-6140d232ad44
Content: Receive all channel messages with RSC - Teams
Content Source: msteams-platform/bots/how-to/conversations/channel-messages-with-rsc.md
Product: msteams
GitHub Login: @surbhigupta12
Microsoft Alias: lajanuar

Hi @chialiyun, we are working on it, will we update you soon.


Nonsusceptible in AMR page

It looks like we have a number of differences.  What does non-susceptible mean?  Is it resistant?  Is it intermediate?  If not, we need to define it because no one will know exactly what we are saying.

https://www.patricbrc.org/view/Taxonomy/1301#view_tab=amr&filter=and(eq(antibiotic,Beta-lactam),eq(resistant_phenotype,Susceptible))

Non-suceptible is perfectly valid. There are few organisms, like Niesseria, that do not
have clearly defined break points in CLSI or EUCAST. They are published with designation
of susceptible and non-suceltible. Both Jim and I have discussed this and decided to leave
it as non-susceptible, since it is accepted by the organism community.
-Maulik

On Apr 18, 2017, at 11:13 AM, hyoo<EMAIL_ADDRESS>wrote:
Assigned #1457 https://github.com/PATRIC3/patric3_website/issues/1457 to @mshukla1 https://github.com/mshukla1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/1457#event-1046976002, or mute the thread https://github.com/notifications/unsubscribe-auth/ABLd71kXDRd7_zfXTzQA9cjnNjbaGJ2nks5rxOElgaJpZM4Mvrrz.


Should "Publish Value" transactions carry a description?

As title.
The original intention was for transactions to allow a 'memo' or 'note' to be attached (sneds, grants etc) but this is rarely used currently.
In the "Publish Value" model I'm currently prototyping there is no need to "setup" a feed, you just publish a value (and feed ref) from an address, and the latest value published is the 'current' value of the feed.
This means descriptions would be per transaction - this provides the flexibility that new information can be provided in the description with each new published value (such as metadata) but also provides the mechanism to add non-consensus data to the blockchain.
Should we include a description field in the Publish Value transaction?

Could you provide an explicit use case this would be used for?

Could you provide an explicit use case this would be used for?

This is tough because I'm not fully understanding of the entire futures process that we'll be implementing.  I put the field in so that publishers of the feed could include a string value but as to whether that's required I don't know.
One example that was in my mind when prototyping was prior discussions about where a contract would be settled once a certain secret was published - that could be one use case, another would be metadata (eg this value applies to X range or Y date or whatever).
More than happy to remove it if it's not needed :)

More than happy to remove it if it's not needed :)

Well, there might be some use for it, but until then I'd rather go the route of adding it, if it's really needed, not the other way around. :)

I think it's better to keep track of the specification or feature proposals in the spec repository:
https://github.com/OmniLayer/spec
Please feel free to open a new issue over there.


Roadmap

This file https://github.com/Pfern/OSODOS/blob/master/docs/ROADMAP/README.md needs to be written out to indicate the "need to know" sections for the different stakeholders.

(see #6)

@Pfern, can you review if the roadmap prose is sufficient for Milestone 1.0? Please re-open this ticket if it needs more work.


ADR0005: Decide on python code style guide

Fixes #1128
Description of the changes being introduced by the pull request:
Document why we chose to henceforth use the Google Python style guide with minimal refinements.
Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Good idea. Could we also use pylint, flake8, and black?

Thanks for the comments, you two! No need to apologize,  @joshuagl, I do appreciate language corrections, and our style guide actually encourages them.

@joshuagl, I squashed your suggestions into my commit. @trishankatdatadog, I added another commit to mention linters and formatters and general style guide usage/transition instructions. Would either of you mind taking another look? Thanks!

Hmm, I do have some reservations regarding hanging vs aligned indents in function arguments, but whatever, I can live with it.

Hmm, I do have some reservations regarding hanging vs aligned indents in function arguments, but whatever, I can live with it.

What do you mean? Our new guide specifically favors aligned indent, which is what you seemed very passionate above.

What do you mean? Our new guide specifically favors aligned indent, which is what you seemed very passionate above.

My bad, I missed the tweak to the Google guide. Keep calm and carry on 💯 💯


domain problem

I facing error with my domain to se with my lcz file, what to do to correct this?
--> Set data, arguments and files

Using layer 0 of the LCZ GeoTIFF. Can be changed with -l (--lcz-band)
--> Check LCZ integrity, in terms of class labels, projection and extent
LCZ labels as expected (1 to 17)
LCZ provided as WGS84 (EPSG:4326)
ERROR: LCZ domain should be larger than WRF domain in all directions.
LCZ bounds (xmin, ymin, xmax, ymax): (-17.7210656098258, 13.83764863657711, -16.1840481586973, 15.46988750782228)
WRF bounds (xmin, ymin, xmax, ymax): (-17.990726470947266, 13.280853271484375, -15.958621978759766, 15.464736938476562)

It looks like your domain is larger than the area covered by the LCZ image.
ERROR: LCZ domain should be larger than WRF domain in all directions.
Please, try to use a larger LCZ and see if that solves the problem.

I ll try to adjust the wrf domain because creating lcz for Africa cities is complicated

Hi Mathias, thank you for the nice work. The file (lcz) I was trying is the one you gave me during BUCS2018 for Dakar.
I'll look at the global map and will see how to extract a domain that fits the wrf one.

I don't understand why lcz domain should be larger than the wrf domain, not in the sample data if I understand well

after another extraction I am getting a different error:
Dataset has no geotransform, gcps, or rpcs. The identity matrix will be returned

I don't understand why lcz domain should be larger than the wrf domain, not in the sample data if I understand well

The LCZ map is being regridded / resampled to the WRF domain and its resolution. For that to work it is essential that both the LCZ and WRF domains overlap, to make sure the information is complete.

Dataset has no geotransform, gcps, or rpcs. The identity matrix will be returned

Your issue might be related to this one. This was solved by using a clean python environment before installing / running the W2W tool.
For future issues: please provide a more complete bug report, as explained here. Otherwise we just have to guess what is happening.

OK, that make sense, and issue is solved using the link guidance


Import operations failing in distributed mode

OrientDB Version: 3.0.25
Java Version: 11.0.5+10-LTS
OS: CentOS Linux 7.7.1908
Expected behavior
When running a 3 node distributed cluster with one master node and two replicas, everything should work fine.
Actual behavior
Import operations fail with
Code: 500, Content: com.orientechnologies.orient.server.distributed.ODistributedException: Quorum (1) cannot be reached on server 'odb-staging0' database 'TestDB' because it is major than available nodes (0)
Some other operations such as ALTER CLASS also randomly fail, and succeed every time in single node mode.
The server status is:
Nov 25 07:07:37 odb-staging0 server.sh[24944]: +-----+------+------------------+----------------+----------------+-------------------+--------------------+-------------------------+
Nov 25 07:07:37 odb-staging0 server.sh[24944]: |Conns|Status|Name              |Binary          |HTTP            |StartedOn          |UsedMemory          |Databases                |
Nov 25 07:07:37 odb-staging0 server.sh[24944]: +-----+------+------------------+----------------+----------------+-------------------+--------------------+-------------------------+
Nov 25 07:07:37 odb-staging0 server.sh[24944]: |4    |ONLINE|odb-staging1      |<IP_ADDRESS>...|<IP_ADDRESS>...|2019-11-24 19:38...|720.09MB/22.00GB ...|TestDB=ONLINE (REPLICA)  |
Nov 25 07:07:37 odb-staging0 server.sh[24944]: |4    |ONLINE|odb-staging2      |<IP_ADDRESS>...|<IP_ADDRESS>...|2019-11-24 19:40...|3.56GB/22.00GB (1...|TestDB=ONLINE (REPLICA)  |
Nov 25 07:07:37 odb-staging0 server.sh[24944]: |5    |ONLINE|odb-staging0(*)(@)|<IP_ADDRESS>...|<IP_ADDRESS>...|2019-11-24 19:31...|2.81GB/22.00GB (1...|TestDB=ONLINE (MASTER)   |
Nov 25 07:07:37 odb-staging0 server.sh[24944]: +-----+------+----------------+----------------+----------------+-------------------+--------------------+---------------------------+

Steps to reproduce
[root@odb-staging0 config]# cat default-distributed-db-config.json
{
  "autoDeploy": true,
  "readQuorum": 1,
  "writeQuorum": 1, // Also tried with "majority"
  "executionMode": "undefined",
  "readYourWrites": true,
  "newNodeStrategy": "static", // Also tried with "dynamic"
  "servers": {
    "odb-staging0": "master",
    "odb-staging1": "replica",
    "odb-staging2": "replica"
  },
  "clusters": {
    "internal": {
    },
    "*": {
      "servers": ["<NEW_NODE>"]
    }
  }
}
[root@odb-staging0 config]#

       <handler class="com.orientechnologies.orient.server.hazelcast.OHazelcastPlugin">
            <parameters>
                <parameter value="odb-staging0" name="nodeName"/>
                <parameter value="true" name="enabled"/>
                <parameter value="${ORIENTDB_HOME}/config/default-distributed-db-config.json" name="configuration.db.default"/>
                <parameter value="${ORIENTDB_HOME}/config/hazelcast.xml" name="configuration.hazelcast"/>
            </parameters>
        </handler>

		<port auto-increment="false">2434</port>
		<join>
			<multicast enabled="false">
			</multicast>
			<tcp-ip enabled="true">
				<member><IP_ADDRESS></member>
				<member><IP_ADDRESS></member>
				<member><IP_ADDRESS></member>
			</tcp-ip>
		</join>

Hi @tacho,
Do you have any error in the server log when you run the import ? can you share with us the sever log, as well if you have a specific import that reproduce the problem that you can share will be cool.
For the alter table problem can you open a separate issue where you specify the kind of alter you are trying to do (the SQL query would be good).
This current info are good but i can just identify the environment not the problem.
Regards

Hello,
I'll have to reprovision the test cluster that I had in order to give you server logs, but if I recall correctly there weren't any messages relating to this there, just the client error that I pasted above.
Any database import was failing, but I'll try to prepare a small one as a test case.

odb-gh-9073.tar.gz
Here's an archive with the server logs, a sample DB and all three nodes' configurations.
The password hashes inside are with obviously insecure passwords, as this is a disposable test cluster.
As you'll see there wasn't any error in the server w.r.t the database import, and console.sh gave me this:
Connecting to database [remote:<IP_ADDRESS>/testdb1] with user 'admin'...OK
orientdb {db=testdb1}> import database /Users/tacho/Downloads/testdb1.gz

Importing database database /Users/tacho/Downloads/testdb1.gz...
Error: com.orientechnologies.orient.core.exception.OStorageException: Error sending import request
	DB name="testdb1"

Error: com.orientechnologies.orient.core.db.tool.ODatabaseExportException: Error on importing database 'testdb1' from file: /tmp/import15340545639861068269testdb1.gz

Error: com.orientechnologies.orient.server.distributed.ODistributedException: Quorum (1) cannot be reached on server 'odb-rpltest0' database 'testdb1' because it is major than available nodes (0)

orientdb {db=testdb1}>

For the record, the logs are from 3.0.25, but I just upgraded the test "cluster" to 3.0.26 and same error occurs.

Hi @tacho,
Thank you for the details, I could reproduce and fix it, it will be released in the next hotfix 3.0.25.
bye


Add github CI checks for linting

Context (Problem, Motivation, Solution)
This PR add a github CI workflow which will run make check
Closes #119
Describe Your Changes
Checklist

[ ] I have performed a self-review of my code
[ ] I ran make check and fixed resulting issues
[ ] I ran the relevant tests and they all pass
[ ] I wrote tests for my new features, or added regression tests for the bug I fixed

Testing
I have tested using https://github.com/nektos/act

Fantastic, let's merge it!

Ayoo, it fails: https://github.com/0xFableOrg/0xFable/actions/runs/8000911253

Type error: Cannot find module 'contracts/out/deployment.json' or its corresponding type declarations.

This makes perfect sense. We either need to commit a dummy deployment file to the repo, or run Anvil and deploy in the action itself.
Actually, I suggest adding a command to the github action that simply creates an empty JSON (file containing {}) at  contracts/out/deployment.json. That seems like the easiest way out of this.
We're also getting this (unrelated) warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We need to update the foundry-toolchain action to the latest version.
Finally, I suggest testing the action in a github fork, as clearly local testing is not perfect ;)

I forced-pushed the merge away, so as not to bother the other PRs with failed CI runs.

Type error: Cannot find module 'contracts/out/deployment.json' or its corresponding type declarations.

This makes perfect sense. We either need to commit a dummy deployment file to the repo, or run Anvil and deploy in the action itself.
Actually, I suggest adding a command to the github action that simply creates an empty JSON (file containing {}) at contracts/out/deployment.json. That seems like the easiest way out of this.

I have fixed this issue with adding the following step:
      - name: Fake contract deploymment
        run: mkdir -p packages/contracts/out && echo "{}" > packages/contracts/out/deployment.json

We're also getting this (unrelated) warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We need to update the foundry-toolchain action to the latest version.

We are already using the latest foundry-toolchain action, I have updated actions/checkout to fix this warning:
https://github.com/ptisserand/0xFable/actions/runs/8013673319

Finally, I suggest testing the action in a github fork, as clearly local testing is not perfect ;)
Sure, sorry for this mistake.

@norswap Should I create a new PR ?

We are already using the latest foundry-toolchain action

Are you sure? This specifies v1 but latest version is v1.1.1, and v1.1 moves version to Node 16 to Node 20.
Not sure if these versions are wildcards.

@norswap Should I create a new PR ?

Yes please :)

We are already using the latest foundry-toolchain action

Are you sure? This specifies v1 but latest version is v1.1.1, and v1.1 moves version to Node 16 to Node 20. Not sure if these versions are wildcards.

v1 is a "moving tag", it's the same changeset as v1.1.1

@norswap Should I create a new PR ?

Yes please :)

Here is link to the new PR: https://github.com/0xFableOrg/0xFable/pull/127


Image moved to media folder is removed after deployment

Nautobot version: 2.2.9
Python 3.10
We are using the most resent helm chart (2.2.0) to deploy Nautobot. In the Docker build step, we copy our custom PNG logo to the /opt/nautobot/media directory, however it seems later in the process nautobot overwrites this directory with the folders devicetype-images, health_check_storage_test, and image-attchments.
Is there a workaround for this? The behavior started happening after several helm chart upgrades (most likely due to this PR)
Thanks.

Never though of this use case tbh. I would try to create a PVC by enabling it and copy (kubectl cp) the logo to /opt/nautobot/media as a workaround.
In order to fix this though, changing the chart to only create a volumeMount in the deployment if persistenceMediaFiles is enabled will probably do the trick.


Error when running this official tutorial for tensorflow 2.0beta1

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source 2.0 beta 1
Python version: 3.6
ROCm/MIOpen version: 2.5
GPU model and memory: radeon vii

Describe the current behavior
when I run this official tutorial (https://www.tensorflow.org/beta/tutorials/text/text_classification_rnn) for tf2beta1 i get "E tensorflow/core/grappler/optimizers/meta_optimizer.cc:502] constant folding failed: Invalid argument: Unsupported type: 21" when training the model. The training progresses but it's increadibly slow:
"5/Unknown - 446s 89s/step - loss: 0.6935 - acc: 0.5219"
The expected speed is 200ms/step (not 90s/step).
Describe the expected behavior
No error. The expected speed of training is 200ms/step (not 90s/step).
Code to reproduce the issue
In the tutorial: https://www.tensorflow.org/beta/tutorials/text/text_classification_rnn

Hi @witeko , did you use our official docker image or built TF2.0-Beta1 from source? Can you try the following docker image if not yet?
rocm/tensorflow:rocm2.5-tf2.0-beta1-config-v2

@sunway513 Ive built it from source. Theres a whole bunch of examples that work perfectly fine - this one is an exemption.
OK, I can try to use the official docker image in my free time. Do You think this would change the result? :)

@witeko , thanks. Just FYI, there're two options to build the TF-2.0Beta1 source; if you don't specify "--config=v2" to bazel build command, you won't get TF2.0 feature enabled. You can refer to the following two build scripts we've included in the release branch:
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/r2.0-rocm/build_rocm_python3
https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/r2.0-rocm/build_rocm_v2

@sunway513 I check again and this time I built the TF2 with the v2 option. There are no more error, but this time I have warnings:
"W tensorflow/core/grappler/optimizers/implementation_selector.cc:199] Skipping optimization due to error while loading function libraries: Invalid argument: Functions '__inference___backward_cudnn_lstm_1069_1247_specialized_for_Adam_gradients_bidirectional_StatefulPartitionedCall_1_grad_StatefulPartitionedCall_at___inference_keras_scratch_graph_3646' and '__inference___backward_standard_lstm_2111_2613' both implement 'lstm_b69b5a0f-2942-4e5d-892b-2bf1f341b279' but their signatures do not match.
"
Time per step is now 5s (improvement from 90s, but still slower than 200ms).
I can check the docker image in my free time.

@witeko , do you still have questions on this issue?

@sunway513 I just created this issue so that You know that sth works incorrectly. :)

Thanks @witeko , may I know the source of the expected 200ms/step speed? Have you tried with the docker image?
It looks like the workload can run on GPU right now instead of CPU in the initial situation.

@sunway513 the source is: https://www.tensorflow.org/beta/tutorials/text/text_classification_rnn
Ive done many of the tutorials and always the speed between my computer and in the examples was consistent (its not a scientific proof but a strong argument).

I'm having a hard job running that tutorial in Google Callaboratory too. I'm getting about 2s/step, instead of the 141ms/step in the saved output within notebook of the tutorial.
Like @witeko, I generally get comparable performance to the saved output in the tutorial, so this stands out as doing something odd.
Epoch 1/10
391/391 [==============================] - 952s 2s/step - loss: 0.6384 - accuracy: 0.6134 - val_loss: 0.5606 - val_accuracy: 0.7036

I've partially figured this out: in my case, I'm running on a Colab notebook with a TPU, but there's something about the model or dataset that means it cannot run on TPU, so it falls back to CPU.
When I switch the notebook to GPU, I get the documented speeds.
This is even easier to see when training the with/without CudNN example here:
https://www.tensorflow.org/guide/keras/rnn
If the notebook is setup to use TPU, there's no speed difference.


Allow Supplying a filesystem map fsMap via .executeWithFs({ ... })

This will allow us to supply relative imports, for example you might supply:
evalWebWorker.executeWithFs({
  fsMap: {
    "main.tsx": `import manualEdits from "./manual-edits.json"\n//....`,
    "manual-edits.json": "{ ... }"
  },
  entrypoint: "main.tsx"
})

/bounty $20

/attempt #11

fixed in #13


Second model not showing after updating to v0.3.7-preview1

Description
It looks like from v0.3.6 to v0.3.7-preview.1, something unexpected has changed! In my project, I am displaying two Spider objects. My intention was to make the Spider class encapsulated so each one has it's own StereoKit.Model and state.
When using v0.3.6, I can display two spider objects like so:

But when I run the same code in v0.3.7-preview.1, one of spiders doesn't show up!

The code looks like:
		Spider mySpider;
		Spider mySpider2;

		public void Init()
		{
			mySpider = new Spider();

			mySpider2 = new Spider();
			mySpider2.setLevel(2);
			mySpider2.setPosition(1, -1.45f, -1);
		}

		public void Step()
		{
			mySpider.Step();
			mySpider2.Step();
		}

Where setLevel() is controlling which model to use. Here is the Spider class if you'd like to inspect that: Spider.zip
Platform / Environment
I am using the flatscreen simulator. I used the StereoKit Universal template to begin the project. My graphics card is NVIDIA GeForce GTX 1650 Ti with Max-Q Design My drivers are up to date.
Logs or exception details
[SK diagnostic] Initializing StereoKit v0.3.7-preview.1 Win32 x64...
 [XR_ERROR_FORM_FACTOR_UNAVAILABLE]
[SK info] MixedReality display mode failed, falling back to Flatscreen
[SK diagnostic] Starting flatscreen mode
[SK diagnostic] Created swapchain: 1280x720 color:rgba32_linear depth:depth32
[SK diagnostic] Initializing Audio
[SK diagnostic] ISAC audio backend not available, falling back to miniaudio! It's likely the device doesn't have Windows Sonic enabled, which can be found under Settings->Sound->Device Properties->Spatial Sound.
[SK info] Using audio backend: WASAPI
[SK diagnostic] Initializing Defaults
[SK diagnostic] Initializing World
[SK diagnostic] Initializing Sprites
[SK diagnostic] Initializing Lines
[SK diagnostic] Initializing UI
[SK diagnostic] Initializing Renderer
[SK diagnostic] Initializing Physics
[SK diagnostic] Initializing Input
[SK info] Initialization successful
[SK warning] [spider/scene.gltf] Too many texture coordinate channels! Only one supported, the rest will be ignored.
[SK info] Session Performance Report:
[SK info] ______________________________________________________
[SK info] |         System | Initialize |   Update |  Shutdown |
[SK info] |________________|____________|__________|___________|
[SK info] |       Defaults |    42.17ms |          |    0.01ms |
[SK info] |     FrameBegin |            |  1.312ms |           |
[SK info] |          Input |     1.63ms |  0.012ms |           |
[SK info] |        Physics |     0.14ms |  0.043ms |    0.00ms |
[SK info] |       Renderer |     0.97ms |  0.002ms |           |
[SK info] |             UI |     1.16ms |  0.005ms |   22.87ms |
[SK info] |       Platform |   525.30ms |          |   10.90ms |
[SK info] |            App |    46.52ms |  0.098ms |           |
[SK info] |      Animation |            |  0.165ms |    0.08ms |
[SK info] |          Lines |     0.06ms |  0.010ms |    0.01ms |
[SK info] |        Sprites |     0.48ms |  0.000ms |    0.01ms |
[SK info] |           Text |            |  0.002ms |    0.01ms |
[SK info] |         UILate |            |  0.001ms |    0.00ms |
[SK info] |          World |     0.20ms |  0.001ms |    0.07ms |
[SK info] |    FrameRender |            |  0.116ms |    0.04ms |
[SK info] |         Assets |     0.06ms |  0.001ms |    0.02ms |
[SK info] |          Audio |   196.08ms |  0.001ms |    0.08ms |
[SK info] |________________|____________|__________|___________|

I'm not sure why it's vanishing, that's kinda odd! I'm not immediately able to repro it, but I'll see if I can set up something using your Spider code. If you have any additional information about the context in which it's doing this, that could be nice :)

One thing to note for Model is that the animation playing actually modifies the Model itself! Also, Model.FromFile will return the same asset if it's been loaded before.
So the pattern you have where the Spider loads the Model in the constructor may not work all that well, as the Model will be a shared by all spiders, and the animations will stomp on each-other. Instead, each Spider will likely want a Copy() of the original model! If you're planning on having a lot of spiders, it may also be of interest to have some pool of animated Models, as that may get costly.
One pattern that can work well for sharing assets, is to have a common static Asset class with your shared assets in it.
public static class Asset {
    public static Model ModelSpider;
    public static Model ModelHelmet;
    // ...

    public static void Initialize() {
        ModelSpider = Model.FromFile("Spider.gltf");
        ModelHelmet = Model.FromFile("helmet.gltf");
        // ...
    }
}

And then later in your Spider, you can say Model animatedModel = Asset.ModelSpider.Copy() and then animate it as you wish.

You anticipated my next question about why my animations were stomping each other :) Thanks for the suggested pattern! I'll take it and run with it. I'm thinking there will be like 10 or less spiders, so I will try without a pool for now and see how it runs.
As for additional information about the context of this bug, I just tried recreating it and it looks like I can't consistently reproduce it - it only happens about 50% of the time! I also tried recreating the bug using version v0.3.6, and the bug exists there too! It just seems less likely to occur in v0.3.6 which is probably why I didn't notice it before.
I also see similar behavior when I load 2 of the same spider models at once. About 50% of the time both spiders render and 50% of the time neither spider renders. This happens right at the start of the application. Here's a demo:

And here is the source code if you'd like to try running it. Let me know if any other information would be helpful!
SK 401.zip

So after I switched over to the shared assets pattern you described above, I haven't seen the bug again! I've run the app like 30 times, and every time the spiders rendered on the screen as expected. So maybe the issue was related to making multiple calls to Model.FromFile("spider/scene.gltf");? Maybe some kind on concurrency issue? Not sure... but I'll let you know if I see the issue again while using this new pattern.

Ok, I'm glad to hear it's starting to behave! I was able to repro the problem with your project once though, so it's definitely still around, and I can tackle that now :D I'll poke at it and see what comes up!


CTRL+C does not work on Linux

It was noted in https://github.com/cs01/create-python-package/pull/9#issuecomment-468029054 by @florimondmanca that

Bullet seems to not listen to Ctrl+C events. This means the user can't cancel while in a list prompt.

I am working on a fix and should have a PR shortly.

FYI, I tried Ctrl+C on macOS High Sierra, so it's possible that this issue is not specific to Linux.

Oh interesting. Does the pull request fix your issue on mac?

I'll look into it soon. :eyes:

Since this problem is solved by PR#20, I will close this issue.

Is this on pip yet?


CI: add upstream master test

1.5 regressions hit us pretty seriously. to become a better k8s citizens and avoid issues, we'd better help test k8s head to catch any potential regression early.
idea: add k8s master test. that cluster will be rebuilt every night automatically.
it wont block our pr, but we can see if it fails.
/cc @hongchaodeng @philips

cc @ethernetdan

@xiang90 do you have specific suites you want to have run?

@ethernetdan https://github.com/coreos/etcd-operator/blob/master/test/e2e/main_test.go
this is the test entrance. @hasbro17 is working on this. the plan is to use pluton + bootkube to setup a k8s master built cluster nightly. then run this test against it.

done


Support For Color Profiles

Is there any kind of support for color profiles. I'm using Glide successfully in my project and all is working as expected except for one thing and that is it's changing certain colors during conversions. For example I have a client who's primary important color is red and any type of conversion I do converts the red to pink! I need some way to pass in the -colorspace during a conversion like you can when using the command line imagemagick convert command. I don't know if this is possible or not. If someone could point me in the right direction I will definitely see what I can do in writing this code myself.
Thanks for any help
Josh

As noted in your PR, this is not possible with Glide at this time, and I'm not sure it's a feature that's needed in the core. Thanks either way! :+1:

@joshrhykerd Did you find a good solution for this? It's an issue with intervention. I am still doing my research on the issue but I partially have terrible results, even with imagick as driver. Any pointers would be greatly appreciated. Thanks.


About documentation and examples

Awesome work! Would you provide some more documentation or other examples for us to explore? Since I am more familiar with python than C++, so I prefer to use this package for future development. Also, do you have a plan for simulation in gazebo or other simulation platforms?

Hi, thanks for the interest! We'll be adding more examples and Isaac-sim (Orbit) simulation support in the future. Regarding documentation, we will be adding some explanation to the provided notebook soon. But do you have any suggestions on any specific aspect you'd like to be documented better?

Thank you for reply. I'm especially curious to know how, as a beginner, I can use your library to develop and simulate some actions for  GO2. I've studied your provided examples and they are quite comprehensible, yet I haven't managed to put together a full functional workflow. I would greatly appreciate any guidance you could offer.


⚠ ClamAV has degraded performance

In 8be0f93, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 71 ms

Resolved: ClamAV performance has improved in bfc7c8e.


Add files via upload

@Strelix First stage of verification passed, official domain is utcoxfordshire.org.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Help I want you to help me adding my university
Tecnologico Universitario Argos
Argos University Technological
Guayaquil - Ecuador
www.tecnologicoargos.edu.ec/
add to
https://github.com/JetBrains/swot/tree/master/lib/domains/ec/edu
tecnologicoargos.txt
file.zip

@Strelix Pull request merged. Thank you.
@jmejiapluas I added your university email domain, too.


remove unused address handling in account and rely on lucid to resolve either used or unused address

This is implemented now. Unfortunatley, we could not re-use lucid code, since the hook wasn't playing nicely. Instead we are mirrorring the implementation, using the walletApi directly. See #22


Feature Request: Enable exporting of .stl files to Gcode from Depot

The transition from STL to GCode requires slicing, so this would mean slicing in the app.  A planned feature was to send an STL directly to a slicer of the user's choice for this, but totally open to ideas here!

That would be a good alternative to having slicing baked in. Either would be a welcomed improvement, for sure!

What slicers do you use?

@destari I've been using Ultimaker Cura, but I've been interested in maybe a web-based slicer. If I can find one I can run from the browser, that'd be epic. Out of curiosity, what do you use?


Support shorter subscription syntax

This PR allows you to return an array from the subscribe method (this was already supported) that has a shorter syntax for methods that exist on the subscriber itself:
<?php

namespace App\Listeners;

use App\Events\SomeEvent;

class SomeEventSubscriber
{
    /**
     * Handle an event.
     */
    public function handleSomeEvent($event)
    {
        info('Handling some event...');
    }

    /**
     * Register the listeners for the subscriber.
     *
     * @param  \Illuminate\Events\Dispatcher  $events
     * @return void
     */
    public function subscribe($events)
    {
        return [
            SomeEvent::class => [
                'handleSomeEvent',
            ],
        ];

        // Or...

        return [
            SomeEvent::class => 'handleSomeEvent',
        ];
    }
}

I am not sure if I am on right path (correct me please if I am missing something). I was managing the other way around. Having listeners of an event be on itself. Did that for code management purpose so that by looking at an event I would know what are it's listeners 🤔
Doing something this in EventServiceProvider.php


Can't open lib 'ODBC Driver 17 for SQL Server' : file not found in Heroku

In Heroku, it seems not to find the Driver.

runtime.txt
python-3.7.3

Aptfile (I added the apt build pack to add apt dependencies)
unixodbc
unixodbc-dev
python-pyodbc
libsqliteodbc

requirements.txt
Django==3.0.4
djangorestframework==3.10.3
django-environ==0.4.5
pre-commit==2.1.1
black==19.10b0
flake8==3.7.9
pre-commit-hooks==2.5.0
pyodbc==4.0.30
django-mssql-backend==2.8.0
serpy==0.3.1
gunicorn==20.0.4

settings.py:DATABASES
NAME_DRIVER = "ODBC Driver 17 for SQL Server"
DATABASES = {
    "default": {
        "ENGINE": "sql_server.pyodbc",
        "NAME": "",
        "USER": "",
        "PASSWORD": "",
        "HOST": "",
        "PORT": 9876,
        "OPTIONS": {
            "driver": NAME_DRIVER,
            # "host_is_server": True,
            "unicode_results": True,
        },
    }
}

UPDATE: Similar problem
https://stackoverflow.com/questions/54625929/cannot-connect-to-sql-server-from-django-on-heroku

SOLVED: with the help of @leonellima

Using the Heroku Apt buildpack I'm installing Microsoft provided library, so my Aptfile looks like this:

unixodbc
unixodbc-dev
unixodbc-bin
python-pyodbc
libsqliteodbc
python3-pyodbc
libmyodbc
tdsodbc
https://packages.microsoft.com/ubuntu/18.04/prod/pool/main/m/msodbcsql17/msodbcsql17_<IP_ADDRESS>-1_amd64.deb

Log in into your heroku dyno, to find the absolute path of the driver:

find / -name *odbcsql*
In my case was:
/app/.apt/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.5.so.2.1

Use this path as the driver key in the OPTIONS key of the Database configuration:

settings.py ...
NAME_DRIVER = "/app/.apt/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.5.so.2.1"
DATABASES = {
    "default": {
        "ENGINE": "sql_server.pyodbc",
        "NAME": "",
        "USER": "",
        "PASSWORD": "",
        "HOST": "",
        "PORT": 134,
        "OPTIONS": {
            "driver": NAME_DRIVER,
            "host_is_server": True,
            "unicode_results": True,
        },
    }
}

DONE!


New version: jsdelivr.Globalping version 1.1.5

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="jsDelivr"]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree


setup-deployment.sh: fails when namespace is missing

$ make start
...
$ test/setup-deployment.sh
INFO: deploying from /nvme/gopath/src/github.com/intel/pmem-csi/deploy/kubernetes-1.19/lvm/testing
Error from server (NotFound): error when creating "STDIN": namespaces "pmem-csi" not found
Error from server (NotFound): error when creating "STDIN": namespaces "pmem-csi" not found

Where is the namespace supposed to be created?

I'm testing with my own branch ATM, so it could be that I broke something.

I think it's creating the secrets that fails, because the namespace only gets created later via the .yaml file.
But how does that work in our CI?

But how does that work in our CI?

It works because tests like direct-testing E2E [Testpattern: Dynamic PV (ext4)] dax should support MAP_SYNC still use "default" as namespace.

The instructions in install.md are also broken: users are told to create secrets first, which can't work because the namespace does not exist yet. If they create the namespace first, then kubectl create -f deploy/kubernetes-1.19/pmem-csi-lvm.yaml fails with Error from server (AlreadyExists): error when creating "deploy/kubernetes-1.19/pmem-csi-lvm.yaml": namespaces "pmem-csi" already exists.

I'm testing with my own branch ATM, so it could be that I broke something.

Also occurs with current "devel".

@avalluri : my conclusion is that we can't create the namespace via the deployment YAML files. Do you agree?
I'm working on reverting that.

I think it's creating the secrets that fails, because the namespace only gets created later via the .yaml file.
But how does that work in our CI?

All driver tests runs in default namespaces as earlier, That was the reason it didn't reveal, My initial script changes were creating the namespace. But later I moved that to YAMLs as I was thinking that this script is supposed to used by only tests but not by the end user.  That resulted in this issue.

@avalluri : my conclusion is that we can't create the namespace via the deployment YAML files. Do you agree?

I couldn't decide which is the right approach, I referred the other existing YEMLs, for example cert-manager it creates the namespace from its deployment YAMLs. So I leaned towards creating the namespace. But you are right  this might not work for us because of the secret creation, else we need to move the secret creation part to post driver deployment.

But you are right this might not work for us because of the secret creation, else we need to move the secret creation part to post driver deployment.

That's indeed the key difference compared to cert-manager: in our case, the namespace is shared between different entities which get created and destroyed independently. That implies that there is no single entity which can own that namespace.
The same problem may exist for the operator, see https://github.com/intel/pmem-csi/issues/835


Matches in literature data disappear at ETL

Describe the bug
There are 200M more matches in the raw data than in the normalized and failed datasets combined.

Failed matches count: 247_332_452
Grounded matches count: 444_674_668
All matches count in raw data: 935_616_523
Lost matches count: 243_609_403

Generating count
fmc =  spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/failedMatches/').count()
mc = spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/literature/matches').count()
tmc = spark.read.parquet('gs://ot-team/dsuveges/empc_match_cooc_counts').select(f.sum(f.col('match_count')).alias('sum')).collect()[0]['sum']

print(f'Failed matches count: {fmc}')
print(f'Grounded matches count: {mc}')
print(f'All matches count in raw data: {tmc}')
print(f'Lost matches count: {tmc - fmc - mc}')

Some of this can be explained by the fact that some of the matches from abstracts might be counted twice in the raw data counts (if full texts were available), but there are examples (eg 33369735) when an entire publication with 60 matches disappear completely.
Investigating example
# Looking up publication in failed matches:
(
    spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/failedMatches/')
    .filter(f.col('pmid') == pmid)
    .select('pmid','type','kind','section','label')
    .show()
) # returns empty

# Looking up publication in matches:
(
    spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/literature/matches')
    .filter(f.col('pmid') == pmid)
    .select('pmid','type','kind','section','label')
    .show()
) # Returns empty

# Looking up publication in the raw dataset:
(
    spark.read.parquet('gs://ot-team/dsuveges/empc_match_cooc_counts')
    .filter(f.col('pmid') == pmid)
    .show() # Returns one entry.
)

Raw dataset:
+--------+-----+----------+-----------+----------+
|    pmid|pmcid|   pubdate|match_count|cooc_count|
+--------+-----+----------+-----------+----------+
|33369735| null|2021-01-09|         60|        27|
+--------+-----+----------+-----------+----------+

Location of the raw data: gs://otar025-epmc/ml02/abstract/2022_06_01/NMP_patch-31-05-2022-0.jsonl
Extracted examples with matches and cooccurrences: link

A desired behaviour of the literature etl would be that all matches/cooccurrences that come in were represented in any of the output generated by the pipelines.

Is there any obscure, less obvious filter applied at publication level in the ETL that we are not aware of?

There are 2.3M unique pmids that were found in the input data with non-zero matches, but the pmid could not be found in the post etl matches or failed matches dataset.
Code
publication_w_matches = (
    spark.read.parquet('gs://ot-team/dsuveges/empc_match_cooc_counts')
    .filter(
        # Filter for publication with pmid only:
        f.col('pmid').isNotNull() &
        # Filter for publication with at least one match
        (f.col('match_count') > 0)
    )
    .select('pmid',f.concat_ws('/', f.col('input')).alias('rawFile'))
    .groupBy('pmid')
    .agg(f.collect_set(f.col('rawFile')).alias('rawFiles'))
)

etl_output = (
    spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/failedMatches/')
    .filter(f.col('pmid').isNotNull())
    .select('pmid', f.lit(True).alias('failed'))
    .distinct()
    .join(
        (
            spark.read.parquet('gs://open-targets-pre-data-releases/23.06.littest/output/etl/parquet/literature/matches')
            .filter(f.col('pmid').isNotNull())
            .select('pmid', f.lit(True).alias('matches'))
            .distinct()
        ),
        on='pmid', how='outer'
    )
    .select(
        'pmid',
        f.when(
            f.col('matches').isNull(), 'failed',
        ).when(
            f.col('failed').isNull(), 'matches',
        ).otherwise('both').alias('source')
    )
)

joined = (
    etl_output
    .join(publication_w_matches, on='pmid', how='outer')
    .persist()
)

joined.filter(f.col('source').isNull()).show(truncate=False)

Examples:
+--------+------+--------------------------------------------------------------------------+
|pmid    |in etl|rawFiles                                                                  |
+--------+------+--------------------------------------------------------------------------+
|1000888 |null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-695.jsonl]    |
|10023464|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-494.jsonl]    |
|10024167|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-102.jsonl]    |
|10028210|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-457.jsonl]    |
|10037815|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-584.jsonl]    |
|10051645|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-770.jsonl]    |
|10063669|null  |[gs://otar025-epmc/ml02/abstract/2023_01_31/NMP_patch-30-01-2023-24.jsonl]|
|10069807|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-115.jsonl]    |
|10069813|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-376.jsonl]    |
|10074101|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-450.jsonl]    |
|10074198|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-457.jsonl]    |
|10075916|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-456.jsonl]    |
|100768  |null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-557.jsonl]    |
|10084526|null  |[gs://otar025-epmc/ml02/abstract/2023_01_31/NMP_patch-30-01-2023-12.jsonl]|
|10084986|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-346.jsonl]    |
|10085228|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-159.jsonl]    |
|10091655|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-633.jsonl]    |
|10097392|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-35.jsonl]     |
|10101196|null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-482.jsonl]    |
|1011171 |null  |[gs://otar025-epmc/ml02/abstract/2022_05_27/NMP_patch-total-731.jsonl]    |
+--------+------+--------------------------------------------------------------------------+

Exploring disappearing publications in the old releases
I was wondering if the lost matches were present in the ETL output of previous releases. If so, that would imply a stochastic effect, if there same publications were missing that would imply some sort of a rule bases effect. The analysis was difficult, because we don't have failed matches from previous releases, so I had to rely on the successfully grounded entities of the matches dataset.
 Code
# Reading matches dataset from the previous release:
etl_output_old = (
    spark.read.parquet('gs://open-targets-data-releases/23.02/output/etl/parquet/literature/matches/')
    .filter(f.col('pmid').isNotNull())
    .select('pmid', f.lit('matches').alias('source'))
    .distinct()
)

joined_old = (
    # Extract missing publications:
    joined.filter(f.col('source').isNull())
    .select('pmid', f.lit('missing').alias('new_release'))
    .join(etl_output_old, on='pmid', how='left')
    .persist()
)

joined_old.filter(f.col('source').isNotNull()).show()
joined_old.filter(f.col('source').isNotNull()).count()

+--------+-----------+-----------+
|    pmid|new_release|old_release|
+--------+-----------+-----------+
| 1018100|    missing|      found|
|10395270|    missing|      found|
|10624003|    missing|      found|
|11150631|    missing|      found|
|11235943|    missing|      found|
| 1157038|    missing|      found|
|11666000|    missing|      found|
|12010164|    missing|      found|
|12062199|    missing|      found|
| 1209214|    missing|      found|
|12236686|    missing|      found|
|12684197|    missing|      found|
|12962678|    missing|      found|
|14675585|    missing|      found|
|15359638|    missing|      found|
|16110478|    missing|      found|
|16279325|    missing|      found|
|16329786|    missing|      found|
|16524394|    missing|      found|
|17209885|    missing|      found|
+--------+-----------+-----------+

The test shows 34k of the currently missing publications had matches that were successfully grounded and can be found in the matches dataset. Compared to the 2.3M this is only a small fraction (~1%), however the list of failed matches are missing and also the problem most likely persisted across past releases.

@remo87 , would you mind checking with @DSuveges on the latest metrics for this?
Thanks!

Probably related to #3285 Once that issues is closed a thorough QC will show if there are other problem with the data.


Add support for onCreateOptionsMenu, onPrepareOptionsMenu

There's a way to handle menu item clicks, but no way to inflate or modify menu items in the activity controller.

@INRIX-Iurii-Okhmat Currently this is being discussed in API v2.0 planning. pleaser refer to https://github.com/soundcloud/lightcycle/issues/48


C23's std::embed

https://compiler-explorer.com/z/3qx87hhso

Updated example: https://compiler-explorer.com/z/eMhz9hn5c

Notes: https://thephd.dev/finally-embed-in-c23
https://en.cppreference.com/w/c/preprocessor/error

Coming in episode 368


Why it don't use http instead of dio ?

Why it don't use http instead of dio ?

Any concern?
dio provides extra features like interceptors

I love Dio!


Question: Works with private repositories?

Hey
Great action!
Is it suppose to work with private repositories?
so far I've been getting:
fatal: couldn't find remote ref xx/merge

** xx marks the pr number of course.

That's curious. 🤔  That ref should be ignored. It should only look at head refs.
https://github.com/13rac1/block-fixup-merge-action/blob/6521b8e62ce59799891a2cdbcbcc75b7319b0b35/entrypoint.sh#L8-L11
Do are you using v1.1.2?

Thank you for responding.
I've used version 1.1.1:
- name: Block autosquash commits
  uses<EMAIL_ADDRESS>
As far as the log goes, in the workflow log I see:
Run<EMAIL_ADDRESS>/usr/bin/docker run ... ...
...
Current ref: refs/pull/245/merge
Current branch: 45/merge
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
From https://github.com/my-org-name/my-repo-name
 * branch            master     -> FETCH_HEAD
fatal: couldn't find remote ref 45/merge

The branch name was better-ci-cd but I've also tried a couple of other test/temp branch names.
I should point out that I've only tried this with a private repository in my company's organization.
I don't know if it's related but I can try this again using a private repo in my own profile and not withing an organization.

Ah! This issue was fixed in 1.1.2. Please upgrade https://github.com/13rac1/block-fixup-merge-action/releases/tag/v1.1.2


DBZ-7838 Support for MySQL 8.4

https://issues.redhat.com/browse/DBZ-7838

Test failure cause by https://github.com/osheroff/mysql-binlog-connector-java/pull/146
@Naros Would it be possible to cut a release with the fix?


在多任务时，配置同一执行器，同一任务模板情况下，似乎没能控制同步执行任务数量，都是同一时间触发任务，最终会导致数据库压力非常大，甚至数据库崩溃[Feature]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

--

确实，我也出现这个问题了，同时启动一百个任务，好像就会崩溃


【RCINT-3801】Cannot auto-search immediately after clicking to SMS

Coverage decreased (-0.008%) to 1.121% when pulling 69cc25efc59296d60c301990630512a445bc82ed on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage decreased (-0.008%) to 1.121% when pulling 69cc25efc59296d60c301990630512a445bc82ed on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage increased (+0.01%) to 1.14% when pulling f7b65e17acf0d54fc6510567746fb20e2518ab1d on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage increased (+0.009%) to 1.137% when pulling b9f71a5e1c746a17ab01778c16f297e52eecfe20 on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage decreased (-0.01%) to 1.118% when pulling 8803bd92c8934a1a840e04712a8ab36ca4fbdfd6 on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage decreased (-0.01%) to 1.118% when pulling 8803bd92c8934a1a840e04712a8ab36ca4fbdfd6 on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage decreased (-0.01%) to 1.118% when pulling 8803bd92c8934a1a840e04712a8ab36ca4fbdfd6 on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.

Coverage increased (+0.008%) to 1.136% when pulling 3538e15f1d0c3f52be6da836a28380398b10074b on caffffe:bugfix-autosearch into 179568cdc4d51bb655e6c1736e82ca1c4ce17fdb on ringcentral:master.


How to setup in Google cloud VM?

I have the manager running with port 80 and 443 open in my firewall.
I have added a proxy host for a duckdns.org subdomain and i'm trying to get a certificate for my self hosted bitwardenrs site.
I can't seem to figure out the proper configuration for the proxy host. The error I get is:
Failed authorization procedure. bwcloud.duckdns.org (http-01): urn:ietf:params:acme:error:connection :: The server  could not connect to the client to verify the domain :: Fetching http://*******.duckdns.org/.well-known/acme-challe nge/c8Ero5fXAJ-D2vV-NzfxpSptjG7MWITxVg9oq0gVIe0: Connection refused
I'm using the manager from my home assistant server and it works great. Thought I would try it in a cloud VM but I'm just a newb...

So the error you got is when NPM is running in the cloud ?
The error message indicate that NPM can't be reached through port 80 from the internet...

Thanks, it was a firewall issue.


Check for dependencies and peerDependencies before calling Object.keys

Got this error when trying to run the examples on your input-autosize component:
var dependencies = Object.keys(pkg.dependencies);
	                          ^
TypeError: Object.keys called on non-object

This PR simply check for the existence of deps and peerDeps. Maybe we should also check for its type? Or just try/catch? :dancer:
Cheers!

:+1: thanks @daviferreira

Published as v0.7.3


[4.3.0] Integration Control Plane - Userstore

Description
Need to add a new page for the $subject.
Draft document: https://docs.google.com/document/d/1aBGrNiAgUp5VnTG_CqTVptSI2-D-miveZ28Gi1umqYQ/edit#

This page is live and can be accessed from here.


Revert fmt.sh and update make format to use fmt.sh

consolidate style using fmt.sh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
Assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
As a followup we should ensure that linter uses the same mechanism for enforcement.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linter seems fine.

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
08a7c780d77292a10443adb718d4429f1a5d5015
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiaolanz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
08a7c780d77292a10443adb718d4429f1a5d5015
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-v1alpha3.sh
08a7c780d77292a10443adb718d4429f1a5d5015
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [costinm,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

It seems like this could be done in the Makefile using something like:

GOIMPORTS := $(shell which goimports 2>/dev/null || echo "${ISTIO_BIN}/goimports" )
${ISTIO_BIN}/goimports: | ${ISTIO_BIN}
	unset GOOS && unset GOARCH && go get golang.org/x/tools/cmd/goimports

GO_FILES_CMD := find . -type f -name '*.go' ! -name '*.gen.go' ! -name '*.pb.go' ! -name '*mock*.go' | grep -v .vendor

ifeq ($(shell uname),Darwin)
   SED_OPT := ''
endif

# eval is used to compute file list on demand (rather than on every invocation of make)
format: | $(GOIMPORTS)
	$(eval GO_FILES:=$(shell $(GO_FILES_CMD)))
	for fl in $(GO_FILES); do sed -i $(SED_OPT) -e "/^import[[:space:]]*(/,/)/{ /^\s*$$/d;}" $$fl; done && \
	gofmt -s -w $(GO_FILES) && \
	$(GOIMPORTS) -w -local istio.io $(GO_FILES)

Otherwise, the existing GO_FILES_CMD variable and 2 adjoining variables in the Makefile can probably be removed since afaict they'd no longer be used anywhere.

moved to https://github.com/istio/istio/pull/4785


fix(schematics): set current directory as default project name

defaultProject was removed from the cli in angular 14
this sets current working directory as default if --project argument is not specified

as recommended here : https://github.com/angular/angular-cli/issues/23470#issuecomment-1172240384
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
When using the ng add @ngneat/transloco schematics with a newly created angular 14 project, it fails with the following error :
Cannot read properties of undefined (reading 'projectType')
Issue Number: #580
What is the new behavior?
The command without --project argument won't fail, and project arg is pre-filled with root directory name.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
n/a

@b-legrand Hey man thanks for the PR.
Did you test this in both applications using Angular <14 and Angular 14/15?

@b-legrand Hey man thanks for the PR. Did you test this in both applications using Angular <14 and Angular 14/15?

I tested the ng add with a local linked version, but it was before v15 was released, on a v14 project. I'll try again on v15 and v13

@shaharkazaz here is what I have done to test, I'm not sure if there is a better way :

build transloco on this branch with npm run build:transloco
cd into dist/libs/transloco-utils and ran npm link to have it available globally.
cd into dist/libs/transloco and ran npm link + npm link @ngneat/transloco-utils otherwise linked package could'nt found it.
created a new angular 15 project with ng new transloco-ng-add-v15, installed transloco into it with npm link @ngneat/transloco @ngneat/transloco-utils, checked node_modules contained my locally linked packages and then ran npx ng add @ngneat/transloco : add was successful.
same thing with a newly created angular 13 project (npx -p<EMAIL_ADDRESS>ng new transloco-ng-add-v13) and it also works fine.

I did not try v12 yet as it forces me to downgrade node.js version to 14... (and not sure if it is currently supported by transloco ?) but I can if needed

@b-legrand Thanks for the quick response!
Seems like you did cover what I would have tested. I think that maybe it's a good thing to validate v12 as well (it's supported) just to make sure, but I wouldn't go any further.
WDYT about the docs? should we recommend explicitly saying the name of the project anyways?

Can you also update your branch with the latest master branch?

Done :checkmark
I just tested on an angular 12 project with node 14.x and it also works fine.
I'm not sure about the docs, i expect the ng add command to not need the --project argument by default, except when explicitly using multi-projects apps (angular libs or nx). But I have no strong opinion on this 🤷🏼♂

@b-legrand Thanks for being super responsive!
I think I agree with you, it should work OOTB, I'll add a note though that you can pass the project so people might find it useful.

@b-legrand Great work on this!


[sil-ownership] Fix some cases in SILValue::getOwnershipKind().

[sil-ownership] Fix some cases in SILValue::getOwnershipKind().
I fixed a few things. Now I am finally hitting cases where we have
guaranteed/owned arguments, so I really need to do the SILGen work. But this was
a good first step.
rdar://29671437

@swift-ci Please smoke test and merge

@swift-ci Please smoke test

@swift-ci Please smoke test os x platform


[Snyk] Security upgrade python from 3.9-slim to 3.13.0b3-slim

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 5 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

cmd/suggestion/optuna/v1beta1/Dockerfile

We recommend upgrading to python:3.13.0b3-slim, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Integer Overflow or Wraparound SNYK-DEBIAN12-ZLIB-6008963
  500

Improper Verification of Cryptographic Signature SNYK-DEBIAN12-APT-1541449
  150

CVE-2023-4039 SNYK-DEBIAN12-GCC12-5901316
  150

CVE-2023-50495 SNYK-DEBIAN12-NCURSES-6123823
  150

CVE-2023-45918 SNYK-DEBIAN12-NCURSES-6252773
  150

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.998%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3117

Relevant Lines:
4270

💛  - Coveralls


Added JIRA priorities

Adds the option to set issue priority. This corresponds to the index of the different priority choices.

Sans the CI failure, lgtm


Scaling the map

Can you please add a scaling for the map() function? Thanks.

added scale param to map api
map [x=0 y=0] [w=30 h=17] [sx=0 sy=0] [colorkey=-1] [scale=1] [remap=nil]
done on .24


Added lerp for smooth transition of walk speed

Hey, sorry for the super late reply.
While playing with your changes on my (very choppy) Mac I found the hardcoded 1.0 lerp step to cause a little bit of jerkiness. 10.0 * delta worked much more smoothly, so can you please use that instead?
Also, I've added a Contribution Guide to the repository (feel free to check it out!), mainly to maintain the consistency in the coding style, so can you please change the indentation of the affected lines from tabs to spaces? You can do that by selecting the two affected lines and hitting Ctrl+i or Cmd+i
Thanks!


Usage behind HTTP proxy

So I just installed Pufferpanel and want to add a template, but it seems like the software can not reach the template repository.
How can I configure it to use my HTTP Proxy?
~Jens

PufferPanel doesn't have any proxy handling that I'm aware of, so if system settings don't work I don't see any way to make the integrated import mechanism work without code changes, however you can still manually copy and paste template JSONs from the template repo into the template editor in JSON mode, as long as you only need a few templates that shouldn't be too bad of a workaround, though I do see how that would get annoying if you need to get a lot of templates


PHP: put channel args and creds in persistent list

fix 21321 folk subprocess crash.
use malloc (instead of emalloc) for args.args, and not free it after channel created, also hard copy creds as a grpc object. So that, when forked(child) process restart_channels, these two are safe to use.

@jiangtaoli2016 Hi, can you please review the grpc_channel_credentials_copy function we propose to add to src/core/lib/security/credentials/credentials.cc? We left a comment describing why we need that function in the code. There are a few similar functions in c-core so we chose this naming and implementation. In short, we PHP need to increment the ref count to a channel credentials object.
Thanks for the review.

@yihuazhang @ZhenLian I have limited availability these two weeks. Can you review the credentials change?

Superceded by #22774


About the success ratio for Automatic View Planning

Dear Amir Alansary,
May I ask what success ratio did you achieve in training? Since after training for more than 48h (2,875,000 steps) I could only reach a success ratio of about 0.1 and the mean distance between plane params were more than 10. In your paper I noticed that you trained the model for 12-24 hours, so I really want to know about your success ratio in training. May I ask for your help?
Thank you very much.
Best,
Keyu

Hi Keyu,
The success ratio is defined as the ratio of cases that the distance between the predicted and target plane is less than specific value, e.g. 1mm. The increase of the success ratio with training is a sign that the model is learning. I suspect in your case the model has not learned for some reason.
Best, Amir

Hi Keyu,
The success ratio is defined as the ratio of cases that the distance between the predicted and target plane is less than specific value, e.g. 1mm. The increase of the success ratio with training is a sign that the model is learning. I suspect in your case the model has not learned for some reason.
Best, Amir


config: Update Python version used in CI jobs to 3.8.10

Changelog:

3.8.10 (2021-05-03):
https://docs.python.org/release/3.8.10/whatsnew/changelog.html#python-3-8-10-final

Codecov Report

Merging #228 (df66b5d) into develop (a9eca10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #228   +/-   ##
========================================
  Coverage    81.02%   81.02%
========================================
  Files           32       32
  Lines         2525     2525
  Branches       375      375
========================================
  Hits          2046     2046
  Misses         306      306
  Partials       173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9eca10...df66b5d. Read the comment docs.


Add a favicon

It's too hard to add a favicon to the Datasette pages, and having a favicon on only the templated pages seems a bit inconsistent... Closing.


Update main.lua

Added the hand tool, and changed a menu label from "Eraser tool" to "Text too" .

Good, just a few things, I prefer not to add the hand because I configured it to be right click + drag to be hand as that's an available setting option. However, this does not seem totally unnecessary, so maybe there is a good idea behind this. I am willing to discuss your thoughts though.
Also, good catch on the eraser! I just copied and pasted it, and forgot to change the tool name. Thanks!

Actually i have the same setting for right click and drag to switch to hand tool, but when i need to use the hand too much, pressing the right click again and again seems like too much.. although i think i did a mistake in the code... The hand tool probably shouldn't work with the 'h' key as it's already assigned for scrolling in xournal++.  Sorry I didn't mention that before, i was pretty busy with other stuff.
And for the menu, well, i noticed it through the menu itself, when i attempted to customize xournal++.
Thanks for reviewing my changes though:)
And i really like your plugin, its pretty small and does exactly what i want. Your plugin is the first that i am trying(except for the inbuilt plugins), and i love it!


windows: Use GetFinalPathNameByHandle for ResolveSymbolicLink

This change splits the definition of pkg/cri/os.ResolveSymbolicLink by
platform (windows/!windows), and switches to an alternate implementation
for Windows. This aims to fix the issue described in #5405.
The previous implementation which just called filepath.EvalSymlinks has
historically had issues on Windows. One of these issues we were able to
fix in Go, but EvalSymlinks's behavior is not well specified on
Windows, and there could easily be more issues in the future, so it
seems prudent to move to a separate implementation for Windows.
The new implementation uses the Windows GetFinalPathNameByHandle API,
which takes a handle to an open file or directory and some flags, and
returns the "real" name for the object. See comments in the code for
details on the implementation.
I have tested this change with a variety of mounts and everything seems
to work as expected. Functions that make incorrect assumptions on what a
Windows path can look like may have some trouble with the \\?\ path
syntax. For instance EvalSymlinks fails when given a \\?\UNC\ path. For
this reason, the resolvePath implementation modifies the returned path
to translate to the more common form (\\?\UNC\server\share ->
\\server\share).
Signed-off-by: Kevin Parsons<EMAIL_ADDRESS>

LGTM!

I've fixed up some logic, expanded the comments to explain better why we are doing it this way, and added some unit tests. However, I'm having trouble getting some of the more interesting tests to work currently, as they require creating/mounting VHDs. I initially used the Hyper-V PowerShell cmdlets, but those are not present on the CI machines, and my attempt to install them was not successful.
I'm looking into if there's another way I can do the VHD setup that is needed. Otherwise I'll probably need to take out some of the test cases, or find a way to put them behind a feature flag.
The implementation of resolvePath and intent behind what we are testing should still be suitable for review. @AkihiroSuda if you can take a look again that would be appreciated. :)

Okay! Finally got the tests to run properly. Everything passes now except for pull-containerd-node-e2e, which looks unrelated.
The only issue I see is that to properly implement VHD formatting I had to detect the Windows OS version we are running on, which brings in the github.com/Microsoft/hcsshim/test module as a new dependency. I'm not sure if pulling this in to the main containerd module is desired, but this test doesn't look like it would make sense under integration/client, either.
I could remove the version detection given the CI only runs on WS2019, but that's not ideal since someone might need to run it locally, and we don't want to prevent the CI machines from being upgraded.
I could also move the github.com/Microsoft/hcsshim/test/functional/manifest package out of the test module, but that will require a new hcsshim release to update to, and that might complicate backporting this to v1.4.

Thanks for your effort, @kevpar .
Thanks, @AkihiroSuda for sharing so many valuable inputs in this PR, could you please take another look?
cc @estesp

@estesp looks like this is properly signed off. Could you please help merge?

@kevpar Is there a plan to get this cherry-picked into 1.4.x as well ? Or the only path will be into 1.5.1 ?
We currently facing issues with our csi driver on 1.4.4, so wants to see if we can get this backported.

@kevpar Is there a plan to get this cherry-picked into 1.4.x as well ? Or the only path will be into 1.5.1 ?
We currently facing issues with our csi driver on 1.4.4, so wants to see if we can get this backported.

@ibabou yes, I have a PR out to backport to containerd/cri for 1.4 here: https://github.com/containerd/cri/pull/1636

@kevpar Is there a plan to get this cherry-picked into 1.4.x as well ? Or the only path will be into 1.5.1 ?
We currently facing issues with our csi driver on 1.4.4, so wants to see if we can get this backported.

@ibabou yes, I have a PR out to backport to containerd/cri for 1.4 here: containerd/cri#1636

That's awesome, thanks Kevin!

@kevpar I don't see the change in release/1.5. Is there a pending thing related to it ? Seems both 1.5.1 and 1.5.2 got published without it ?

@kevpar I don't see the change in release/1.5. Is there a pending thing related to it ? Seems both 1.5.1 and 1.5.2 got published without it ?

It looks like the backport PR (#5454) for 1.5 accidentally went into master instead of release/1.5. I'll send a new PR to get this in. :)

@kevpar I don't see the change in release/1.5. Is there a pending thing related to it ? Seems both 1.5.1 and 1.5.2 got published without it ?

It looks like the backport PR (#5454) for 1.5 accidentally went into master instead of release/1.5. I'll send a new PR to get this in. :)

PR: #5537

@kevpar I don't see the change in release/1.5. Is there a pending thing related to it ? Seems both 1.5.1 and 1.5.2 got published without it ?

It looks like the backport PR (#5454) for 1.5 accidentally went into master instead of release/1.5. I'll send a new PR to get this in. :)

PR: #5537

Yeah, I noticed too that the PR of the cherry-pick did seem to not have gone in release/1.5 :). Thanks a lot Kevin!


attempting to fix gh deploy

Closes #505
Tested out in my own account, seems ok?

Codecov Report

Merging #507 (c2fa5aa) into main (22599db) will decrease coverage by 6.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   90.93%   84.80%   -6.13%
==========================================
  Files          77       77
  Lines        4358     4358
  Branches      816      816
==========================================
- Hits         3963     3696     -267
- Misses        219      480     +261
- Partials      176      182       +6

Flag
Coverage Δ

unittests
84.80% <ø> (-5.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ummingbird/ml/containers/sklearn/tvm_containers.py
17.24% <0.00%> (-75.87%)
:arrow_down:

...mmingbird/ml/operator_converters/sparkml/linear.py
42.85% <0.00%> (-57.15%)
:arrow_down:

...bird/ml/operator_converters/sparkml/discretizer.py
52.94% <0.00%> (-35.30%)
:arrow_down:

.../ml/operator_converters/_linear_implementations.py
75.55% <0.00%> (-22.23%)
:arrow_down:

...ird/ml/operator_converters/onnx/one_hot_encoder.py
62.50% <0.00%> (-18.75%)
:arrow_down:

hummingbird/ml/_topology.py
67.38% <0.00%> (-17.60%)
:arrow_down:

hummingbird/ml/convert.py
66.82% <0.00%> (-16.83%)
:arrow_down:

hummingbird/ml/containers/_input_containers.py
87.50% <0.00%> (-12.50%)
:arrow_down:

...ml/operator_converters/sparkml/vector_assembler.py
90.00% <0.00%> (-10.00%)
:arrow_down:

...perator_converters/_discretizer_implementations.py
90.32% <0.00%> (-9.68%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22599db...c2fa5aa. Read the comment docs.

@interesaaat I think this should work but we can't fully test until we merge into main.  So i guess merge it, and then if it still fails we can revert.


Corrected minor language errors in glossary.md.

Description of changes:

smoother language,
clearer explanations,
improved grammar.

_ I, Vivek kumar, agree to have this contribution published under Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation._

Hey @stevepiercy,
Thanks for your feedback. Next time, I'll be sure to do more research before sending a pull request. I've addressed all the changes you suggested in a new commit: @Vivek-04022001 8cf011f.

Thank you @stevepiercy for your quick review! I'm glad it looks good. Appreciate your guidance!


Add methods reflection

To be able to use Sourcery to generate code for such things like test doubles or dependency injection container it's vital to be able to access information about methods defined in class (or even on a protocol?).
To start method can be modeled like this:
class Method: NSObject {
  typealias MethodParameter = (argumentLabel: String, parameterName: String, type: String) //or external/internal
  var parameters: [MethodParameter]
  var shortName: String //does not include external parameters names
  var fullName: String
  var returnType: String
  var accessLevel: AccessLevel
  var isStatic: Bool
  var isClass: Bool
}

Then in template it might be used something like this (taking Dobby as an example):
{% for type in types.classes %}
  class {{ type.name }}Mock: {{ type.name }} {
    {% for method in type.methods %}
    override func {{ method.shortName }}({% for parameter in method.parameters %}{% if parameter.argumentLabel %}{{ parameter. argumentLabel }} {% endif %}{{ parameter.parameterName}}: {{ parameter.type }}{% endfor %}) -> {{ method.returnType }} {
      /* record a method call */
    }
  }
{% endfor %}

Another good idea, we should avoid using tuple as that might not be accessible via reflection. We'll just create an inner type for the MethodParameter.
I wonder if I should add something to readme/contributing doc about why the code here is more of an objective-c rather than how you'd write real swift code, due to the fact it's using it allows us to leverage the runtime in templates.

#72 closes this


Under current weather, remove 'degrees', add % to humidity, add precipitation

% added to humidity


compiler.js:466 Uncaught Error: Unexpected value 'Ng2ImgToolsModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

when i used

"dependencies": {
"@ angular/animations": "^5.0.0",
"@ angular/cdk": "^2.0.0-beta.8",
"@ angular/cli": "^1.5.0",
"@ angular/common": "^5.0.0",
"@ angular/compiler": "^5.0.0",
"@ angular/compiler-cli": "^5.0.0",
"@ angular/core": "^5.0.0",
"@ angular/forms": "^5.0.0",
"@ angular/http": "^5.0.0",
"@ angular/material": "^2.0.0-beta.12",
"@ angular/platform-browser": "^5.0.0",
"@ angular/platform-browser-dynamic": "^5.0.0",
"@ angular/platform-server": "^5.0.0",
"@ angular/router": "^5.0.0",
"@ ng-bootstrap/ng-bootstrap": "^1.0.0-beta.4",
"@ types/mathjax": "0.0.31",
"chart.js": "^2.6.0",
"core-js": "^2.4.1",
"markdown-it": "^8.4.0",
"markdown-it-katex": "^2.0.3",
"mathjax": "^2.7.1",
"ng2-charts": "^1.6.0",
"ng2-cookies": "^1.0.11",
"ng2-file-upload": "^1.2.1",
"ng2-img-tools": "^1.0.4",
"ngx-chips": "^1.5.3",
"rxjs": "^5.5.2",
"typescript": "^2.4.2",
"zone.js": "^0.8.4"
},

this error will happen,how to fix this problem?

Hey @kaxu, unfortunately I was unable to identify the reason for this in my spare time today...
I can check it out on Saturday or more likely Sunday in further depth.

ok,thx

+1

+1 in Angular 5.1.0, a few days ago this worked...

If you want to continue developing you can try ng serve --aot
I'm busy this week, but I'll try to help with the error.

The error was reported in angular: https://github.com/angular/angular/issues/20375

How can i fix this error temporarily to let the project work?

Hi guys, thanks for your patience. I just fixed this in 1.1.2.
Turns out you have to set typescript to version 2.4.2 in package.json, as never versions of TS don't work with ngc yet.


Citation ?

Great job folks. I believe a citation of my review https://arxiv.org/abs/2112.03202 is well deserving in the following part:
We do not review methods that aim to extract collective variables from simulations. See instead [1–3] for recent reviews of the topic.

Thank you for your suggestion. After discussing it, we have decided to only include final, peer-reviewed versions of reviewed articles.

The article is online and peer-reviewed. Please see the link: https://pubs.rsc.org/en/content/articlehtml/2022/RA/D2RA03660F

Ah, I see that it was accepted just after the revision for this was re-submitted, that's too bad. Since this is a live review though, there will be updates in the future where we get chances to include more references.


Compare tags with SGID trailhead attributes

Determine the

[ ] attribute mapping to existing
[ ]  any new or suggested tags and
[ ]  what attributes we want to keep in the SGID only with a link back

do we want to suggest that the osm community (wiki) officially add the 'source' tag to trailheads?


fixed sample

@JamesMBallard can you please review and merge?

Review done. Please see comments.

:+1:


External patch support

Hi,
It would be nice if Lux was able to handle external patch and automaticallly apply to kernel' sources before compiling them.
I'm thinking to patch to reduce kernel log-level for example.

Sorry for not replying sooner, got busy with schoolwork and overlooked this in my notifications.
I'd say that external patching is out of scope for the most part. In fact, patching is the one of the reasons I allow for overriding functions with lux.conf.
In my lux.conf, I have a redefinition of kernel_patch that is something like this... (don't have the exact definition as I'm away from my Linux machine right now)
kernel_patch() {
    default_kernel_patch
    curl -#L "https://raw.githubusercontent.com/graysky2/kernel_gcc_patch/master/enable_additional_cpu_optimizations_for_gcc_v4.9%2B_kernel_v3.15%2B.patch" | patch -p1
}


Finishes #3909 Access favourite games with one like

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #3909

Mark the task you have completed ✅

[x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[ x] I have performed a self-review of my own code or work.
[ x] I have commented my code, particularly in hard-to-understand areas.
[x ] My changes generates no new warnings.
[ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ x] I have added working video of the game in README.md (optional)

Add your screenshots(Optional) 📸
Screencast from 2024-05-31 23-57-41.webm

Thank you soo much for contributing to our repository 💗

Thank you @patelkiran185 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hey @patelkiran185,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

Thank you  @patelkiran185 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit do i have create a new issue and then pull request?


Cargo install issue: const extern fn definitions are unstable

I am on OSX M1, Monterey 12.6, Rust nightly.

I'm poking around at compiling main, but FYI, the install instructions aren't working for me and not sure how to fix.

cargo build on the repo directly works fine. and then I have ./target/debug/rpc-server for the gateway, and ./target/debug/sui for the main bin. so that's good

Thanks for reporting @nathanleclaire - this issue has likely been fixed since last year, so I will close the issue for now.


Add flipping for proper visualization on wandb

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[ ] I've applied the relevant labels to this PR
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

As mentioned in #1272, the image slices plotted on WandB (or, Tensorboard) appear flipped by default, even without using any data augmentation. This leads to incorrect understanding of what we think the model is seeing as its input and therefore, forcing us to change our training strategies when it is not required.
This PR brings a minor change in the code snippet used for visualization, particularly, the images are now flipped in the [2,3] axes in order for them to appear correctly on WandB.
Linked issues

Resolves #1272

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.151%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4630

Relevant Lines:
6244

💛  - Coveralls

Thank you for reviewing it @hermancollin ! Yes, it was 3D MRI data but trained using a 2D model. I thought that it would be the same for just 2D images as well.
The option for checking if 2D data is being used is a good suggestion. Would you please be able to update the code in my branch?

@hermancollin Thank you making the changes! However, I am still seeing inverted images for a 2D model I'm training. Here's the figure of inverted sagittal images

Is there any other way we could not use flipping only for microscopy images? Because as far as MRI data is concerned flipping has to be applied for both 2D and 3D models.

@hermancollin I reverted back to the initial version of this fix in commit https://github.com/ivadomed/ivadomed/pull/1273/commits/b4229309beae62331634640185d8e32dd92d878d. Feel free to take a look if required, but, if not would you please approve it so that I can merge? Thanks!