hasOne incorrectly results in many child relations

If you configure a hasOne <-> belongsTo relationship with a parent & child, the expectation is that there is only ever one child per parent. During edits, if the child is edited, the existing child fields should get overwritten.
Instead, currently, a new child is created each time the fields change.
You can see this in action here: https://github.com/ErisDS/Ghost/tree/post-table-split-spike
I'm assuming that this is a problem with bookshelf-relations. It could also be a config issue I've not understood, or a bookshelf problem, but my understanding is that bookshelf-relations is exactly designed to manage saving nested resources.
Also we know that saving hasMany <-> belongsToMany relationships works properly, without creating constant new children.

Ooooooooooh I've totally understood what's going on here.
My reproduction case is this:
{
  id: 35,
  parent_field: 'hello child',
  child: {
     child_field: 'hello parent'
  }
}

Bookshelf-relations (somewhat correctly) assumes that when you edit you'll send this:
{
  id: 35,
  parent_field: 'hello child',
  child: {
      id: 52,
      child_field: 'hello parent'
  }
}

In my case, where we don't know the child's ID, bookshelf-relations protects against new children being created by relying on the MySQL unique constraint error. I'm testing locally using sqlite3 which doesn't have this constraint.
So this isn't so much a bug, as a necessary improvement.
For 1:1 relations, if the nested relation doesn't exist, it should get created, if it does exist it should be located and updated. It shouldn't have any requirement on the ids always being provided - it's totally legitimate that they might not.


The inplace argument has been removed from xarray.

Hi everyone,
I had to install XORCA on a new machine and with that installed the newest version of xarray and it turns out that it produces an error when using load_xorca_dataset. This seems to be due to the fact that the 'inplace' argument has been removed from xarray in the new version. I removed the argument in the ds.set_coords function in lib.py, which seems to fix the problem. So maybe this should be updated in the XORCA code. I added the error message below for completeness:
`
ds_xorca = load_xorca_dataset(data_files=data_files, aux_files=aux_files)
CPU times: user 5 µs, sys: 3 µs, total: 8 µs
Wall time: 16.5 µs

TypeError                                 Traceback (most recent call last)
 in
1 get_ipython().run_line_magic('time', '')
2 #%memit
----> 3 ds_xorca = load_xorca_dataset(data_files=data_files, aux_files=aux_files)
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xorca/lib.py in load_xorca_dataset(data_files, aux_files, decode_cf, **kwargs)
405                     **kwargs),
406                     data_files, _data_files_chunks)),
--> 407             key=_get_first_time_step_if_any))
408
409     # Add info from aux files
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xorca/lib.py in (ds)
400         sorted(
401             map(
--> 402                 lambda ds: preprocess_orca(aux_ds, ds, **kwargs),
403                 map(lambda df, chunks: rename_dims(
404                     xr.open_dataset(df, chunks=chunks, decode_cf=decode_cf),
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xorca/lib.py in preprocess_orca(mesh_mask, ds, **kwargs)
321
322     # make everything that does not depend on time a coord
--> 323     return_ds = set_time_independent_vars_to_coords(return_ds)
324
325     return return_ds
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xorca/lib.py in set_time_independent_vars_to_coords(ds)
264     return ds.set_coords([v for v in ds.data_vars.keys()
265                           if 't' not in ds[v].dims],
--> 266                          inplace=False)
267
268
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xarray/core/dataset.py in set_coords(self, names, inplace)
1384         # nb. check in self._variables, not self.data_vars to insure that the
1385         # operation is idempotent
-> 1386         _check_inplace(inplace)
1387         if isinstance(names, str) or not isinstance(names, Iterable):
1388             names = [names]
~/miniconda3/envs/xorca_env/lib/python3.7/site-packages/xarray/core/utils.py in _check_inplace(inplace)
38     if inplace is not None:
39         raise TypeError(
---> 40             "The inplace argument has been removed from xarray. "
41             "You can achieve an identical effect with python's standard assignment."
42         )
TypeError: The inplace argument has been removed from xarray. You can achieve an identical effect with python's standard assignment.
`

This is also #14
I'll fix this.

Fixed with #29.


Issue with k8s.io/docs/concepts/workloads/controllers/cron-jobs/

This is a Documentation Request
This is a documentation request.
It is not clear to me from that page what concurrencyPolicy means.
I have a feeling it's something like this:
concurrencyPolicy determines what to do in the event that when the next job is scheduled, the previous job is still running.
If concurrencyPolicy is set to Replace, the current running job will be deleted before the next one is scheduled.
If concurrencyPolicy is set to Always, the next job will run alongside the previous.
If concurrencyPolicy is set to forbid, then the next job will not be scheduled, and will be counted as missed.
These are my words. Can someone please add this?
I think you'll have much better wording. Please elaborate if I missed an extra term.
If you need me to do anything/submit this as PR let me know, thanks!

If you're willing to put this in as a pull request, @jrmlhermitte, please do.
I think the wording you've got looks fine. If / when you're not confident about the technical accuracy of changes, mention it in the PR description, and possibly ask for tech review.

Actually, I found it here:

The .spec.concurrencyPolicy field is also optional. It specifies how to treat concurrent executions of a job that is created by this cron job. The spec may specify only one of the following concurrency policies:

Allow (default): The cron job allows concurrently running jobs
Forbid: The cron job does not allow concurrent runs; if it is time for a new job run and the previous job run hasn’t finished yet, the cron job skips the new job run
Replace: If it is time for a new job run and the previous job run hasn’t finished yet, the cron job replaces the currently running job run with a new job run
Note that concurrency policy only applies to the jobs created by the same cron job. If there are multiple cron jobs, their respective jobs are always allowed to run concurrently.
It would be nice either to copy that text or link to it in that document. Sure, I can make a PR tomorrow. I think I will just link this page (and we can discuss).
Do I have to fill out some copyright form if I do so? If so, I think it might be simpler to leave it to someone else. Thanks!

To submit a PR you would need to sign the contributor license agreement.
Thanks for the pointers!

I took a look and I think the page looks fine to me. There is a clear link to the detailed cronjob documentation on this line:

For instructions on creating and working with cron jobs, and for an example of a spec file for a cron job, see Running automated tasks with cron jobs

So I'm going to close this without submitting a PR. Thanks for the feedback!


unable to load script from assets index.android.bundle - React Native

🐛 Bug Report

I am trying to create the native react app by learning some tutorials and using react-native-cli. I am getting this error while running the application on android platform using react-native run-androidscript. The error I am getting is unable to load script from assets index.android.bundle. Make sure your build is packaged correctly and you are running a packager server. I tried setting port for TCP. After reading a lot of articles here I found this solution by running the command
react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res && react-native run-android
So I added this command in my package.json. Now every time I have to run this command for the changes in code, live refreshing is not working and as I have seen in many tutorial that a development server will start but nothing is starting.
I still didn't understand why this error occurs and why not a JS development server is starting ?
Here is the info of react version - react-native-cli: 2.0.1 react-native: 0.58.6
To Reproduce

Create a native app using react-native-cli
Expected Behavior

Should run app and development server
Code Example

https://stackoverflow.com/questions/54975709/unable-to-load-script-from-assets-index-android-bundle-react-native
Environment

Can you post the link to the tutorial you are following?

React version - react-native-cli: 2.0.1 react-native: 0.57.1
I'm running into the same issue also. When building a release variant for android I can see the bundleReleaseJsAndAssets task completing successfully but I noticed that the bundle is being generated in
/projectNameHere/android/app/build/generated/assets/react/release/index.android.bundle
I've fixed the "Unable to load script from assets" error by moving the generated bundle to android/app/src/main/assets/ but I'm not sure if this is the correct way to fix this or if this is just something you have to do when testing a release build on android? I also see that you can make adjustments to the bundle location in build.gradle so I figure I can just change the location that the js bundle will be generated at to android/app/src/main/assets/ so that the bundle doesn't have to be generated manually every time a change is made. Would this be an acceptable fix or should the release bundle be kept in /projectNameHere/android/app/build/generated/assets/react/release/?
Any help is much appreciated!

Turns out I should pay more attention and read the release notes! 😂 😅 I was able to fix my issue by using gradle 3.1 as recommended in the react native release notes for 0.57.
In my project I modified /android/build.gradle and changed
classpath 'com.android.tools.build:gradle:3.3.2'
to
classpath 'com.android.tools.build:gradle:3.1.4'
Once that was done I tried building my app on a device again and everything worked as expected!

@sumittiwari87 can you please LMK if what @joseph-perez wrote works for you too?

@kelset The solution @joseph-perez provided worked for me!

Great, closing.

Hi, @joseph-perez solution will give me another error where the solution to resolve this error is by using at least
classpath 'com.android.tools.build:gradle:3.3.0'
Using either 3.3.0 or 3.3.2 will keep giving me the error "unable to load script" as discussed here.
Below are some of the details. Let me know if you need more info.
package.json
{
  "name": "Dummy",
  "version": "1.0.0",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "ac-qrcode-rn": "^0.2.1",
    "react": "16.6.1",
    "react-native": "0.59.4",
    "react-native-camera": "^2.0.2",
    "react-native-device-detection": "^0.2.0",
    "react-native-extended-stylesheet": "^0.10.0",
    "react-native-firebase": "^5.3.1",
    "react-native-gesture-handler": "^1.0.10",
    "react-native-image-picker": "^0.28.0",
    "react-native-immersive": "^1.1.2",
    "react-native-webview": "^2.14.0",
    "react-navigation": "^3.0.5",
    "react-redux": "^6.0.0",
    "redux": "^4.0.1",
    "redux-logger": "^3.0.6",
    "redux-saga": "^0.16.2"
  },
  "devDependencies": {
    "babel-jest": "23.6.0",
    "jest": "23.6.0",
    "metro-react-native-babel-preset": "0.50.0",
    "react-test-renderer": "16.6.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

android/build.gradle
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext {
        buildToolsVersion = "28.0.3"
        minSdkVersion = 16
        compileSdkVersion = 28
        targetSdkVersion = 28
        supportLibVersion = "28.0.0"
        supportVersion = "28.0.0"
        reactNativeVersion = "+"
    }
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.3.2'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenLocal()
        google()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

task wrapper(type: Wrapper) {
    gradleVersion = '4.4'
    distributionUrl = distributionUrl.replace("bin", "all")
}

subprojects {
    project -> if (project.name.contains('react-native-webview')) {
        buildscript {
            dependencies {
                classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.11"
            }
        }
    }
}

android/app/build.gradle
apply plugin: "com.android.application"

import com.android.build.OutputFile

project.ext.react = [
    entryFile: "index.js",
    jsBundleDirRelease: "$buildDir/intermediates/merged_assets/release/mergeReleaseAssets/out"
]

apply from: "../../node_modules/react-native/react.gradle"

def enableSeparateBuildPerCPUArchitecture = false

def enableProguardInReleaseBuilds = false

android {
    compileSdkVersion rootProject.ext.compileSdkVersion
    buildToolsVersion rootProject.ext.buildToolsVersion

    defaultConfig {
        applicationId "com.dudu_react_native"
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion
        versionCode 1
        versionName "1.0"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
        missingDimensionStrategy 'react-native-camera', 'general'
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86"
        }
    }
    buildTypes {
        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
        }
    }
    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
            def versionCodes = ["armeabi-v7a":1, "x86":2]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }
}

dependencies {
    implementation project(':react-native-image-picker')
    implementation project(':react-native-camera')
    implementation project(':react-native-webview')
    implementation project(':react-native-gesture-handler')
    implementation project(':react-native-immersive')
    implementation fileTree(dir: "libs", include: ["*.jar"])
    implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
    implementation "com.facebook.react:react-native:+"  // From node_modules
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

@kelset Any update? Do you need more info from me?

I was not able to reproduce the bug by creating a brand new project. So I just ditched the old project. Sorry for not trying more before asking here.

This fixed the issue for me https://stackoverflow.com/questions/44446523/unable-to-load-script-from-assets-index-android-bundle-on-windows/44476757#44476757

Highly recommend to take account this answer - https://stackoverflow.com/a/53326616: for 28 api-level (Starting with Android 9.0 (API level 28), cleartext support is disabled by default.)

Highly recommend to take account this answer - https://stackoverflow.com/a/53326616: for 28 api-level (Starting with Android 9.0 (API level 28), cleartext support is disabled by default.)

Thank @Hesowcharov, you save my day :)

After all these scenarios, the only solution that worked for me was to create the index.android.bundle file in the /src/assets folder using cli. I followed this Stack answer and my app loaded with no issue:

After all these scenarios, the only solution that worked for me was to create the index.android.bundle file in the /src/assets folder using cli. I followed this Stack answer and my app loaded with no issue: https://stackoverflow.com/a/51865052/1417671

but after ./gradlew assembleRelease I have error dulicate resouce in raw? You have solution for it?


Remove default tokens to prevent credential leaks

Does not touch unit tests, which would not be included in a compiled package and thus are not susceptible to credential leak in the same way.
However, it might be worth updating those to pull from process.env as well, and removing all credentials from the repo.

@chrisvanpatten thank you, I will check your pr nowl.

@chrisvanpatten you're right, the credentials should not be included within a public repo. I will merge your pr with some modifications to notice developers when they use Facebook Graph without client key/secret.


parser: factor some functions to make use of line parser

In particular, this has the nice side effect of slightly simplifying
parse_git_header_name to not have a dead check for the git header.
We are also able to remove LineParser::end() and LineParser::current()
with these changes.
Finally, this allows us to get rid of the substr with magic number
checks when parsing file names.

Codecov Report
Patch coverage: 98.00% and project coverage change: +0.23 :tada:

Comparison is base (828debd) 89.80% compared to head (103819d) 90.03%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   89.80%   90.03%   +0.23%
==========================================
  Files          17       17
  Lines        2030     2028       -2
  Branches      874      874
==========================================
+ Hits         1823     1826       +3
+ Misses         79       78       -1
+ Partials      128      124       -4

Impacted Files
Coverage Δ

src/parser.cpp
91.30% <97.94%> (+0.74%)
:arrow_up:

include/patch/parser.h
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision)

https://github.com/flutter/engine/compare/40110ec82d4b...1ac3ce3b4729
2024-04-20<EMAIL_ADDRESS>[Impeller] compute UVs in vertex stage. (flutter/engine#52106)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Change pattern from main-1-light to main-light-1 and main-dark-1

https://github.com/designervoid/ton-design-system/pull/18


New cookie flags and add go.mod

Add missing cookie options and modernize with a proper go.mod file

doxbot codereview


Use Display for Block in errors, logs, and spans

We have a Display for Block impl that shows the block height and hash.
We should change our error enums, error messages, tracing logs, and spans so they use Display, rather than separate block heights or hashes.
TODO
Replace height and hash with block, and debug with display, in:

[ ] error enums
[ ] error messages
[ ] tracing logs
[ ] tracing spans

Once these changes are done, we should also:

[ ] eliminate any duplicate fields, logs, or spans

For example, the ChainVerifier has a height span, and the BlockVerifier has a hash span. After this change, the BlockVerifier's span will be redundant.
Context
https://github.com/ZcashFoundation/zebra/pull/1153#discussion_r504320596

I'm not sure this is a good idea -- the tracing output is supposed to be a trace of execution, so I don't think we should be omitting data from it.  If there are spans where the full contents of the block are not relevant, a better solution would be to change the span fields, rather than to change the formatting.  (In fact, I think that we probably should not have a Display impl for Block, because it represents a user-facing representation of an entire block, and I don't think that that makes sense).

I don't have a strong opinion about this, it was a change suggested by @yaahc.
I also don't know if I wrote up her suggestion accurately.
So I'll let you both decide if you want to close or modify this ticket.

I just worry that we're inconsistently identifying blocks based on random subsets of their fields across the codebase, and that we need some short, consistent format for identifying blocks in our logs. I'd go so far as to say the full context of the block is never relevant in logs, because that would be pages and pages of information. Changing the span fields doesn't really solve the issue of inconsistency across the code base.
The problem as I see it is that we are inconsistently using height / hash as a proxy for the block itself, because we cannot format the block and we don't want to include all the information from the block. Maybe we should introduce a new BlockID type that just wraps the block and has the short form format as its display impl, and in spans where we just want to indicate that a specific block was encountered we'd add block.id() to the span, rather than grabbing the height and hash and having to remember how they were formatted in the logs everywhere else to maintain any sort of consistency.

The problem as I see it is that we are inconsistently using height / hash as a proxy for the block itself, because we cannot format the block and we don't want to include all the information from the block.

hash is a proxy for the block, because block hashes are unique.
height is useful information, but ambiguous by itself, because there can be multiple blocks at the same height. And height is always ambiguous if the logs don't show the current network.

Maybe we should introduce a new BlockID type that just wraps the block and has the short form format as its display impl,

Which block fields are in the short form format?

I think height+hash are the fields I'd want most of the time in logs, so that's what I'd put in it.

After working more with the spans, I think that my original concern is misplaced and that this is a good idea.

This is a gradual cleanup that is mostly done.


feat: allow hljs to be run from command line

This allows the ability for hljs's build script to be run from
the command line.
This is useful for sofware that requires hljs as part of a build
chain.
It disables generation of docs and demo by default.
The patch adds the following options to "tools/build.js":

--output: path to write build files to. Defaults to "build".
--docs: tells builder to include the docs and demo.

Build just for Web, don't include docs:
hljs --output "some/path xml" javascript

Build for Web, include docs:
hljs --docs --output "some/path" xml javascript

Build for NodeJS:
hljs -t node --output "some/path" xml javascript

Build for everything:
hljs -t all --output "some/path" xml javascript

I'm now using a fork of this in production for ReSpec, a tool that is used at the W3C for creating specifications.
Here is our setup (via package.json) if people want to see what it looks like to use in practice:
https://github.com/w3c/respec/blob/develop/package.json#L63

Rebased.


[test_core.py::test_convert2d] fails to run correctly on PVC

To reproduce, remove:
    if is_xpu() and M == 128 and N == 128 and interm_layout and (dst_layout.sz_per_thread == [1, 8]
                                                                 or dst_layout.sz_per_thread == [4, 4]):
        pytest.skip("FIXME: out of resource: shared memory")

and run:
python3 -m pytest --verbose --device xpu python/test/unit/language/test_core.py::test_convert2d

Most of the failures are related to the wrong compilation pipeline (additional optimizations increase shared memory consumption). But there is also one case that fails even with the correct pipeline. Working on it.


Load lrf data in test database

Detailed information:

Loads LRF data when setting up the test database, so that we can test functionality that relies on it.
Refactored common sqlalchemy engine setup into app/common/db_utils.py
Tests marked lrf_data are not run by default
lrf_data tests are included in CI

Closing issues:
List all issues the pull request solve:

Closes #466

Test plan (required)

[x] The PR contains new PyTest unit/integration tests for any function or functional added.
[x] The PR changes existing PyTest unit/integration tests to keep all tests up to date.
[x] The PR does not lead to degradation in unit test coverage.
[x] Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:

Ran all pytests

Codecov Report
Base: 66.60% // Head: 66.71% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (bbaece8) compared to base (821b36c).
Patch coverage: 94.73% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #467      +/-   ##
===========================================
+ Coverage    66.60%   66.71%   +0.11%
===========================================
  Files           80       81       +1
  Lines         2566     2569       +3
  Branches       313      313
===========================================
+ Hits          1709     1714       +5
+ Misses         830      828       -2
  Partials        27       27

Impacted Files
Coverage Δ

app/scoring/build_localised_acyclic_graph.py
17.72% <50.00%> (-1.56%)
:arrow_down:

app/common/db_utils.py
100.00% <100.00%> (ø)

conftest.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add compatible provider

This PR:

adds/changes/removes etc

Testing
Description on how {APP-NAME} can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for {APP-NAME} installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Do we have any link on how this is used?

AFAIU this is used to establish apps compatibility with providers.
https://docs.giantswarm.io/use-the-api/management-api/crd/appcatalogentries.application.giantswarm.io/#v1alpha1-.spec.restrictions.compatibleProviders


Update documentation to Kilo

WIP

This needs IFCA/keystone-voms/pull/36 merged first.

Change rebased for #36


What is "foo.conf?"

It appears that the script wants me to create the file foo.conf before anything else, otherwise this error happens:
sed: can't read /etc/openvpn/client/foo.conf: No such file or directory
/bin/openvpn-unroot: line 168: `sed -nr "s/^\s*${key}\s+(\S+)\s*.*/\1/p" "${opt[old_config_file]}"' returned 2
/bin/openvpn-unroot: line 150: `first_line() {' returned 1
/bin/openvpn-unroot: line 204: `} | first_line' returned 1
/bin/openvpn-unroot: line 473: `dev_type="$(get_dev_type)"' returned 1

...And making a empty foo.conf file didn't help:

/sbin/openvpn-unroot: line 150: `first_line() {' returned 1
/sbin/openvpn-unroot: line 204: `} | first_line' returned 1
/sbin/openvpn-unroot: line 473: `dev_type="$(get_dev_type)"' returned 1

I have the same error on Arch Linux too...


Misleading error message

Too big threshold stat_corr parameter can lead to misleading error message.

This error is not related to stat_corr,  similar message will be produced with the following code snippet:
from lets_plot import *
LetsPlot.setup_html()
data = { 'x': [] }
(ggplot(data) +
geom_point( mapping=aes(x='x', y = 'x', color='x')) +
scale_color_gradient2(breaks =  [-1.0, 0.0, 1.0], limits =[-1.0, 1.0]))

The error-message for the second code snipper id currently

Can't create mapper for discrete domain: '-1.0', '0.0', '1.0'
Which also doesn't seem right.


Create SECURITY.md

Hey there!
I belong to an open source security research community, and a member (@oivrip) has found an issue, but doesn’t know the best way to disclose it.
If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.
Thank you for your consideration, and I look forward to hearing from you!
(cc @huntr-helper)

Thanks for reaching out @JamieSlome. Please have a look at https://www.playframework.com/security/vulnerability: Please report the security issue to<EMAIL_ADDRESS>And I agree we should add a SECURITY.md

@mkurz - thanks for the response!
We just sent an e-mail to that address with more information ❤
For reference, the report can be found here. It is private and only accessible to maintainers with repository write permissions.

@JamieSlome Thanks, addressed here: #152

Fixed, finally: https://github.com/playframework/.github/pull/21


docs: Fix typo in file path in remote files documentation

Description
Fix typo in file path in remote files documentation
QC

[x] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[x] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Thanks a lot!


Karbon is suggested to open everything

Describe the bug
Karbon is suggested to open everything: .apk files, videos, music, photos and everything else
To Reproduce
For example: try to install .apk file
Expected behavior
Karbon will be suggested only for files with text/* MIME types (and maybe application/*), not for everything
complete the following information):

Device: Tecno Camon 20 Pro 5G
OS: HiOS 14.0.0
Android 14

Describe the bug
Karbon is suggested to open everything: .apk files, videos, music, photos and everything else
To Reproduce
For example: try to install .apk file
Expected behavior
Karbon will be suggested only for files with text/* MIME types (and maybe application/*), not for everything
complete the following information):

Device: Tecno Camon 20 Pro 5G
OS: HiOS 14.0.0
Android 14

It's not a bug, it's a feature.
Sometimes, a text file has an odd extension or no extension at all, making it frustrating when no text editor appears for editing.

If file has wrong extension, that means you should do either:

Rename file, so its extension matches its contents.
Open file directly from Karbon, as there is no limits.
Use file explorer with support for "Open as" functionality, like X-Plore.
If this somehow is not possible (e.g. readonly access via SAF, opening files in Karbon is broken, good file explorer is not installed), at least you can save it somewhere, rename and then open.

There is always a way to open files with strange extensions.
Anyway, can you make this functionality disableable?
Because if app wants to open everything, then app will try to open even what should not be opened in it (for example - .exe files)
This is even worse when there is only 1 such app in system - it will open such files automatically


SciPy LowLevelCallable from Lambdify

cc @BlackTeaAndCoffee
This creates a LowLevelCallable that can be used by scipy integrate functions without the overhead of python.

This is really exciting and impressive (as always). I haven't used scipy's LowLevelCallable myself yet (I have been meaning to look into it). Right now I'm quite busy, but I can take a closer look at this PR this weekend.

Looks good to me. Too bad the LowLevelCallable isn't used much in scipy at the moment (that might change though).

Thanks for the review

Very impressive. Thanks @isuruf !

Hi i get the following error, when i run your simple code above.
Traceback (most recent call last):
  File "foo.py", line 6, in <module>
    lmb = se.lambdify(args, [se.exp(-x*t)/t**5], as_scipy=True)
TypeError: lambdify() got an unexpected keyword argument 'as_scipy'

i have
>>> import symengine
>>> symengine__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'symengine__version__' is not defined
>>> symengine.__version__
'0.3.0'
>>>

Best wishes Mustafa

@BlackTeaAndCoffee, you'll have to use the latest version of symengine.py and symengine for this


DIALOG INPUT

Implemented a new dialog section "input" - Provides input processing before button triggers. This section can be utilized to check if the input is valid (obj in range, line of sight, etc..). This should reduce amount of code in each button trigger.

Added example in changelog

Nice feature!

I'd change the INPUT keyword to something more "meaningful" like PREBUTTON or something like that. Any thoughts?

Perfect boss


[jvm-packages] Bump spark to 2.1

Codecov Report

Merging #2046 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage    30.7%   30.74%   +0.03%
==========================================
  Files          72       72
  Lines        5823     5823
  Branches      580      580
==========================================
+ Hits         1788     1790       +2
  Misses       3957     3957
+ Partials       78       76       -2

Impacted Files
Coverage Δ

src/objective/regression_obj.cc
90.39% <ø> (+0.56%)
:white_check_mark:

src/data/simple_dmatrix.cc
58.66% <ø> (+0.66%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185fe1d...a42ad7d. Read the comment docs.

Is xgboost4j-spark using any new features in Spark 2.1?
If not, I assume that I can still compile xgboost4j-spark with Spark 2.0?

no, just to ensure that it compiles with Spark 2.1, you can compile with 2.0 by pass -Dspark.version = 2.0.x


Cannot create property 'tag' on string

Hi, i want to try fre in js-framework-benchmark, but I get error - "Cannot create property 'tag' on string ..."
version:
"fre": 2.0.1
import { render  }  from "fre";

render(

React Optimized

,
    document.getElementById("main")
);

babel:
{
    presets: ['@babel/preset-env'],
    plugins: [[
        '@babel/plugin-transform-react-jsx',
        {
            runtime: 'automatic',
            importSource: 'fre',
        },
    ]]
}

First text node throw this error
(error throw on this line - https://github.com/yisar/fre/blob/master/src/reconciler.ts#L142)

It seems that the H function is not suitable for Babel's jsx2 parsing. Before adjusting the H function, you can use the jsx1:
{
  "plugins": [
    [
      "@babel/plugin-transform-react-jsx",
      {
        "pragma": "h",
        "pragmaFrag": "Fragment"
      }
    ]
  ]
}

Here is a benchmark example
https://github.com/yisar/fre/blob/master/demo/src/benchmark.tsx

Thanks, with pragma it's work. But i get some other errors (and also performance was terrible). I will try your benchmark code

and also performance was terrible.

For this test, create 10000 rows will broken. This is because I used recursion in the commit phase, and other cases are not bad.
I plan to give up recursion in the future and go back to linked list again. Do you have any good ideas?

@yisar Sorry, I don't know how it works, but i check source code and see you use some array methods like forEach some and other, may be i am wrong, but i think for loop works faster. You also call functions like same, isFn and other, but if you call this functions body directly it may increase performance.

@oleggrishechkin The details you mentioned will be what fre2 will do next.
However, we have to say that fre is a little slower than other frameworks in performance testing. There is another important reason:
https://github.com/yisar/fre/blob/master/src/reconciler.ts#L49
Fre's rendering is asynchronous, it will be interrupted every 16 ms(Time slicing), so the overall rendering time will be more
But in exchange for better response performance, the browser won't block during rendering.
So in general, we can do two things in the future to improve performance:

Optimize JS details, make good use of VM, and improve JS execution speed.
Find an heuristic slicing algorithm, better time slicing, for example, when the CPU is not tight, do not slice.

This is what fre2 needs to do.

I refactor the algorithm again, and then used a new technique called centralized paints
This is a technology similar to DocumentFragment. It operates DOM in memory and finally paints to the screen at final time.
Now fre is super fast, even faster than vanilla js.

It seems that the problem here has been solved, I will close it first


react-py loads pyodide multiple times with one PythonProvider

Hey there! I've been using multiple codeBlocks with react-py and noticed that pyodide is also being loaded multiple times. This is a bit surprising to me because I'm only using one PythonProvider. Unfortunately, this is causing my page to load a bit slower.

Hi, can you please provide some more details about where you see Pyodide being loaded multiple times?
I think there's a bug currently where the version number is printed twice in the browser console, but you should only have one web worker loaded for each instance of the usePython hook:

https://elilambnz.github.io/react-py/docs/examples/basic-example

You can take a look at:
python-doc.netlify.app/chapter/05-funktionen-definieren
Many multiple requests to the same resource appear in the Network tab.

I've taken a look at your example. Each usage of the usePython hook will spawn a new worker, each with their own Pyodide instance. However, once the Pyodide bundle has been fetched, subsequent fetches are cached by the browser. You should be able to see this in your network tab as request size shows (disk cache). The response time should for cached resources should be very fast (within a few ms).
Loading many instances in a page can cause slowness, especially on less powerful devices such as mobile phones. If you need to use the hook many times on one page, I'd recommend experimenting with passing these 2 props to the <PythonProvider> to only spawn a new worker as required:

Prop
Required
Type
Default
Description

lazy
No
boolean
false
If true, prevents the web worker from spawning until runPython is called for the first time.

terminateOnCompletion
No
boolean
false
If true, the web worker will terminate on completion.

Ok, the Lazy-Prop did the job! Thank you for your support!


Default literature folder

Hi
I was wondering if it is possible to create a 'default' location where semantra looks for the files if no argument is give on startup? I would like to just run semantra instead of specifying semantra ~/literature/* every time.
Thanks!

Or the ability to specify a folder and it os.walks through all the files within?  (Or does it do that already?)

Not a bad idea! I think the specifying a directory and automatically recursively trawling it is a good idea too. Maybe v0.2 can have default directory as a configurable option (or there can be a default folder it chooses)

+1 for this feature.
Temporarily, the command below did the job of indexing my Zotero library. Now I wonder whether there is a way to save/export the embeddings so I don't need to recalculate them every time I run semantra.
mapfile -d $'\0' files < <(find ~/Zotero/storage -type f -iname "*.pdf" -print0) && semantra "${files[@]}"


Create wiki-link with label field defined in a more easy way

Please Select if your Request is Either something new or an Enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[ ] Create. Note creation, lookup, snippets and templates
[x] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe
When you write a blob of text and then you start reading it to fill any missing gap, you may find that some wiki link is missing and you want to add that on top of the existing text. Right now, I need to add the wiki link and right after that I need to edit the same wiki link to include a label, that is already written in the text. I find this behaviour far from being ideal considering the user experience side as well as a bit time-consuming, in particular, if you need to add 3-4 words in the labeling field.
Many times these words are the words that are already defined in the title of the note that we are inserting as a wiki link.
Although there are many situations where we just want to use text that is already written in the labeling field without worrying at all about what is written in the tilte of that given note.
All the above text is considering the use case where the note referenced in the wiki link, already exists.
I should mention that a workaround exists that was shared in discord channel, with the following procedure. This is just valid when we want to insert the title of the note.

"you can look it up (the note) and use  the copy note link button in the Lookup which copys the note title as label for the link"

Describe the solution you'd like
Maybe considering the following workflow:

Select the text we want to add as label
Insert [[
On the backend, dendron would copy the selected text
Type the name of the wiki link and click enter
After clicking the enter, dendron would add the "copied-text|" to the beggining of the wiki-link.

This is just an idea, the important would be to allow the possibility to inserting a wiki link with the label field fulfil with existing text or the note's title.

This has been shipped with v56 🎉
Please check out the new alias modes for Insert Note Link command and let us know if this resolves your concerns.
Otherwise, this issue will be automatically closed in 4 days.

This has been shipped with v57 🎉
Please check out the new alias modes for Insert Note Link command and let us know if this resolves your concerns.
Otherwise, this issue will be automatically closed in 4 days.


Reorganise sporks.json for easier querying

Changes sporks.json structure to
a) indicate is spork is live
b) add seed nodes with keys for live sporks
c) add multiple ANs
d) change structure so it can be queried easily (no need to search arrays for items).

Hey @m4ksio, do you have a tool you use to generate the sporks.json? If you do, I think it would definitely be good to have that in version control somewhere, and if not, we should create a tool because with such a large file like this it's extremely easy to make manual errors.

We don't have tools. I would imagine this will follow once we establish some standard.

Secondly, should we have a separate file per spork to retain the history of sporks instead of replacing the file every time?

This is still an open question really, so far I figured its easier to have one file which you can check for content and new sporks rather than check a files which may or may not exist.

@m4ksio great, thanks :)
Created an issue just to make sure we track this: https://github.com/onflow/flow/issues/814


Remove etd_ms support

At some point support for etd-ms was added to pyuntl but not finished/perfected and never put into use in our system. Rather than fix it, since we aren't using it, we are going to cut it out of pyuntl.

After the Python2to3 PR gets merged into py3 branch, this can also be something for merging into py3 branch.

To remove etd_ms support from pyuntl, I think, We can get rid of etd_ms_structure.py, etd_test.py totally, and in untldoc.py - untlpy2etd_ms, generate_etd_ms_xml, etd_ms_dict2xmlfile, add_empty_etd_ms_fields  and in metadata_generator.py - etd_ms_py2dict and elif part for ordering for degree children on etd_ms in create_dict_subelement and their corresponding tests.


[X11] Fix incorrect keycodes from non-QWERTY layouts.

Fixes https://github.com/godotengine/godot/issues/72026

Thanks!


Add output with the number of deleted package versions

Use this output also to improve tests

@mering
Is fail in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6785873604
I fix in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/commit/22e65b443e7bec4eef242319005018e2fdcf198f
still fails in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6786034181

Sorry, rebase error after I had to make changes in #33 (I only tested it with the original version of it). Should be fixed now.

Could you please have another look?

Could you please have another look?
is fail
https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6810990584/job/18520406549

It seems that it is not possible to use this action to clean up in the beginning as it fails when there are no packages (which is the usual step).
I tested it on my repo and the latest version works there.

You can add param ignore pkg not exist
And ignore this error  in the code

You can add param ignore pkg not exist And ignore this error in the code

Let's do this in a separate PR. The functionality of this PR in itself is valuable as is.

@mering
is not a bug in your code
https://github.com/orgs/community/discussions/75302

@mering
merged in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/pull/36


MAGIC WP7 RainFARM stochastic downscaling

Recipe ported to V2 and up to date with current version2_development.
See issue 312

Input file changed to EC-EARTH and r1i1p1 and pushed to github.

File name changed and pushed to github for both. I am in strong support of
keeping case-sensitivity active! Thanks and regards :-)
On Mon, 1 Oct 2018 at 15:32, Mattia Righi<EMAIL_ADDRESS>wrote:

@mattiarighi commented on this pull request.
In esmvaltool/recipes/recipe_rainfarm.yml
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r221609443
:

description: |

Recipe for performing stochastic downscaling of precipitation fields
calling the RainFARM package by J. von Hardenberg (ISAC-CNR)
authors:

arno_en

hard_jo

references:

donofrio14jh

rebora06jhm

projects:

c3s-magic

+datasets:

{dataset: EC-Earth,       project: CMIP5, exp: historical, ensemble: r8i1p1, start_year: 1997, end_year: 1997}

OK, let's forget about it. 👍
@earnone https://github.com/earnone if you could change the case in
your recipes that would be great (also note my identical comment in #620
https://github.com/ESMValGroup/ESMValTool/pull/620).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r221609443,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AblrsezxRecrvfbKUoKwec3O-sluh2i1ks5ughmAgaJpZM4W6sAR
.

The way to get the path to routines is the following (already included in the example diagnostic in r):
get path to script and source subroutines (if needed)
diag_scripts_dir <- Sys.getenv("diag_scripts")
source paste0(diag_scripts_dir,"/subroutine.r")
print(paste0("source ",diag_scripts_dir,"/subroutine.r"))
See r_exampl
Sorry and thanks to all for the feedbacks.

New version with above changes uploaded:

area selection and regridding moved to pre-proc
all parameters settings merged into recipe
use of the external dataset was switched off for now

Climatology files will have a permanent home very soon on Jasmin, I have
the directory but am waiting to become admin, could you pls tell me where
to retrieve them from in the meantime?
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Thu, 11 Oct 2018, 12:59 Enrico Arnone<EMAIL_ADDRESS>wrote:

@earnone commented on this pull request.
In esmvaltool/diag_scripts/rainfarm/rainfarm_parameters.r
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202
:

+#####################################################################
+#
+#  RainFARM advanced configuration file
+#
+#  About: configuration file with advanced settings for ESMValTool RainFARM namelist.
+#
+#####################################################################

+force_processing = T # TRUE to rewrite existing output file
+
+# RainFARM options
+# Note - RainFARM usage:  rfarm [-s SLOPE] [-e NENS] [-n NF] [-r REGION] [-w WEIGHTS]
+#                               [-o OUTFILE] [-v VARNAME] [-g] [-c]
+# set FALSE to void argument
+weights_climo =     # climatology file to be used to calculate weights (calling rfweights)

     "/work/datasets/obs/unsorted/WORLDCLIM/prec/prec_06_16_central_europe.nc"

@bouweandela https://github.com/bouweandela I switched this option off
for now and will activate it with due referencing after we decide where to
place the external datasets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo9206N6A7O_gVUsn7l0-DxQ1UZmEks5ujySvgaJpZM4W6sAR
.

We use the 30 sec precipitation climatology from http://worldclim.org
There is now a new version2 and we should move to that. Data can be freely
downloaded, however they are in geotiff format and need a conversion to
netcdf. I guess we should discuss in a separate issue all dataset that are
needed with their formats and access?
Il Gio 11 Ott 2018, 13:03 Valeriu Predoi<EMAIL_ADDRESS>ha
scritto:

Climatology files will have a permanent home very soon on Jasmin, I have
the directory but am waiting to become admin, could you pls tell me where
to retrieve them from in the meantime?
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Thu, 11 Oct 2018, 12:59 Enrico Arnone<EMAIL_ADDRESS>wrote:

@earnone commented on this pull request.
In esmvaltool/diag_scripts/rainfarm/rainfarm_parameters.r
<
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202>
:

+#####################################################################
+#
+# RainFARM advanced configuration file
+#
+# About: configuration file with advanced settings for ESMValTool
RainFARM namelist.
+#
+#####################################################################

+force_processing = T # TRUE to rewrite existing output file
+
+# RainFARM options
+# Note - RainFARM usage: rfarm [-s SLOPE] [-e NENS] [-n NF] [-r REGION]
[-w WEIGHTS]
+# [-o OUTFILE] [-v VARNAME] [-g] [-c]
+# set FALSE to void argument
+weights_climo = # climatology file to be used to calculate weights
(calling rfweights)

"/work/datasets/obs/unsorted/WORLDCLIM/prec/
prec_06_16_central_europe.nc"

@bouweandela https://github.com/bouweandela I switched this option off
for now and will activate it with due referencing after we decide where
to
place the external datasets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202>,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AbpCo9206N6A7O_gVUsn7l0-DxQ1UZmEks5ujySvgaJpZM4W6sAR
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/619#issuecomment-428913595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ablrse9r49c4xbb5Sko1mLU8dOecjhsKks5ujyVvgaJpZM4W6sAR
.

Yes, that would be great - am travelling today but I will be back in work
tomorrow and pick it up from there, conversion to netCDF will be the
preferred for storage in the Jasmin location
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Thu, 11 Oct 2018, 15:08 Enrico Arnone<EMAIL_ADDRESS>wrote:

We use the 30 sec precipitation climatology from http://worldclim.org
There is now a new version2 and we should move to that. Data can be freely
downloaded, however they are in geotiff format and need a conversion to
netcdf. I guess we should discuss in a separate issue all dataset that are
needed with their formats and access?
Il Gio 11 Ott 2018, 13:03 Valeriu Predoi<EMAIL_ADDRESS>ha
scritto:

Climatology files will have a permanent home very soon on Jasmin, I have
the directory but am waiting to become admin, could you pls tell me where
to retrieve them from in the meantime?
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
On Thu, 11 Oct 2018, 12:59 Enrico Arnone<EMAIL_ADDRESS>wrote:

@earnone commented on this pull request.
In esmvaltool/diag_scripts/rainfarm/rainfarm_parameters.r
<
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202

:

+#####################################################################

+#
+# RainFARM advanced configuration file
+#
+# About: configuration file with advanced settings for ESMValTool
RainFARM namelist.
+#
+#####################################################################
+
+force_processing = T # TRUE to rewrite existing output file
+
+# RainFARM options
+# Note - RainFARM usage: rfarm [-s SLOPE] [-e NENS] [-n NF] [-r
REGION]
[-w WEIGHTS]
+# [-o OUTFILE] [-v VARNAME] [-g] [-c]
+# set FALSE to void argument
+weights_climo = # climatology file to be used to calculate weights
(calling rfweights)

"/work/datasets/obs/unsorted/WORLDCLIM/prec/
prec_06_16_central_europe.nc"

@bouweandela https://github.com/bouweandela I switched this option
off
for now and will activate it with due referencing after we decide where
to
place the external datasets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/ESMValGroup/ESMValTool/pull/619#discussion_r224404202
,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/AbpCo9206N6A7O_gVUsn7l0-DxQ1UZmEks5ujySvgaJpZM4W6sAR

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/ESMValGroup/ESMValTool/pull/619#issuecomment-428913595
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/Ablrse9r49c4xbb5Sko1mLU8dOecjhsKks5ujyVvgaJpZM4W6sAR
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/619#issuecomment-428948457,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo1g607k0q6aQOkQ3V_G-QOGCFRlrks5uj0LVgaJpZM4W6sAR
.

This PR depends on julia support, which will be added in #654

The diagnostic has now been rewritten to avoid direct system calls. Instead it now uses the JuliaCall library to call the RainFARM Julia library from R.
The default recipe is set up not to use orographic weights for the downscaling, which would require providing an external file containing a precipitation climatology. A good example of such a file can be freely downloaded from worldclim v2.0 but the accompanying license explicitly prohibits redistribution. The file can be downloaded, merged, converted to netcdf and  cut out for Europe as follows:
wget http://biogeo.ucdavis.edu/data/worldclim/v2.0/tif/base/wc2.0_30s_prec.zip
unzip wc2.0_30s_prec.zip
gdal_merge.py -of netCDF -o wc2.0_30s_prec.nc *tif
cdo sellonlatbox,-25,40,30,70 wc2.0_30s_prec.nc wc2.0_30s_prec_eu.nc

(this works on ubuntu after installing GDAL with sudo apt install python-gdal )
The branch contains what is needed from the version2_development_Julia_support branch, with a modification in setup.jl allowing to install also non-registered Julia packages from github for now (see my reply https://github.com/ESMValGroup/ESMValTool/pull/654#issuecomment-445249550)
This should do for now for the purposes of MAGIC, I will have the Julia RainFARM package registered (I am the author) in the next weeks.

As far as I understand, the only remaining issues for this PR are related to the environment and having Julia on the system, dealt with also in #654
Is there anything I could do to help solving this?

Ok, I realigned the environment to the current simple environment of version2_development and adopted @bouweandela  's solution for #654, namely external julia provided by the user (installed by circleci from apt) and lintr installed from conda directly by circleci. Trying to have also julia in the environment does not seem to work due to a problem in the conda-forge version of julia >1.0.0. Trying to add an older julia 0.6 instead leads to other strange problems when updating the environment.
I tested this version on jasmin and looks fine.

@jhardenberg we expect to switch back to conda-forge in the near future (when all the packages on it will have had proper support for gcc7), let's just wait until then and see what the inter-deps issues will be then, hopefully things will be straightforward (likely not, but hey, one has to hope). If things wok with a manual user install of julia then this should be a good starting point

Ok, good to know. My only problem though is that we need to get RainFARM merged into version2_development for MAGIC rather soon (possibly by end of this month). Since only environment issues seems to be the problem and the current setup with external julia seems to work,  if everything else is deemed ok, maybe we could proceed anyway with merging?

I have tested this and everything works fine.
Great, thanks!

Can you please add the description of how to obtain the climatology file to the documentation?
Yes, I added a description of the file, of its expected its contentnts and where to get one in the docs.

Can you please fix the formatting of the R script? The indentation is wrong in many places.
Done.

Testing again the use of an external weights file, I noticed that it would not work unless the preprocessed spatial subset is square. This is now fixed.

Hi, what is the status of this PR? Could we merge?

The status is that I'm trying to test this, but facing installation issues again.

The problem is that julia creates it's own conda environment in ~/.julia and in my case installs hdf5 1.10.4 there. It uses this environment when installing/compiling julia dependencies. However, when I execute julia in the esmvaltool environment, which has hdf5 1.10.3 installed, it will dynamically link against that version and then exit with a message like this:
Warning! ***HDF5 library version mismatched error***
The HDF5 header files used to compile this application do not match
the version used by the HDF5 library to which this application is linked.
Data corruption or segmentation faults may occur if the application continues.
This can happen when an application was compiled by one version of HDF5 but
linked with a different version of static or shared HDF5 library.
You should recompile the application or check your shared library related
settings such as 'LD_LIBRARY_PATH'.
You can, at your own risk, disable this warning by setting the environment
variable 'HDF5_DISABLE_VERSION_CHECK' to a value of '1'.
Setting it to 2 or higher will suppress the warning messages totally.
Headers are 1.10.4, library is 1.10.3
...

I managed to test this by disabling the hdf5 version check. I think this can be merged now and we can try to tackle Julia installation issues later.

Just as a note for future Julia diagnostics: it is preferred to write Julia diagnostics in Julia, calling Julia functions from an R script adds unnecessary complication and should be avoided. However, I think it is too late to fix that for this pull request.

Just as a note for future Julia diagnostics: it is preferred to write Julia diagnostics in Julia, calling Julia functions from an R script adds unnecessary complication and should be avoided. However, I think it is too late to fix that for this pull request.

Yes, I totally agree. The problem was that the full julia support in ESMValTool only came later on and it was too risky to change things at that point due to the MAGIC schedule. It would indeed be cleaner to have a full julia driver and I may write such an improvement at a later stage. Thank you all for your help and for merging this!


fix: use conditional chaining for page.error.message

The types for the page.error allow it to be null, which causes ESLint warnings if conditional chaining is not used. (My SvelteKit project uses JavaScript with JSDoc comments.) I updated all instances to use conditional chaining where required.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

While ESLint might be right, we know that on +error.svelte that error.message will be defined - we only get there when an error happens. Therefore I'd like to keep the docs void of the optional chaining for better readability and less possibility of confusion ("huh, shouldn't this exist?"). I'm therefore closing this PR - thank you.


Misuse issue in (X)ChaCha20 and (X)ChaCha20-Poly1305 APIs

During a review of parts of the codebase, I've come across a rather unfortunate misuse possibility in ChaCha20, which also affects ChaCha20-Poly1305, but much more limited therein.
(X)ChaCha20
In orion::hazardous::stream::chacha20::encrypt() we allow the user to specify the initial_counter, that the ChaCha20 state should be initialized with (also known as the block counter). If this initial_counter is too large, meaning would overflow when adding 1, then we return an error.
https://github.com/orion-rs/orion/blob/1ee15eb806dd78dc1b10dece4112b2cf68d7494e/src/hazardous/stream/chacha20.rs#L303
The problem is, that before this error is returned, we have already copied the plaintext to the output destination dst_out (in order to later XOR it with the keystream).
https://github.com/orion-rs/orion/blob/1ee15eb806dd78dc1b10dece4112b2cf68d7494e/src/hazardous/stream/chacha20.rs#L347
If the initial_counter.checked_add(1) returns Err() the plaintext bytes that were supposed to be XORed with the next keystream bytes, remain in plaintext in the output buffer.
    let k = SecretKey::generate();
    let n = Nonce::from_slice(&[0u8; 12]).unwrap();
    let ic: u32 = u32::MAX - 1;

    let text = [b'x'; 128 + 4];
    let mut dst_out = [0u8; 128 + 4];

    let err = encrypt(&k, &n, ic, &text, &mut dst_out).unwrap_err();

    assert_eq!(&[b'x'; 4], &dst_out[dst_out.len() - 4..]);

While we do return an error, and a user should not use the output of encrypt() if it returns an error, they might reasonably expect that dst_out not contain a copy of some plaintext bytes.
This issue also applies to XChaCha20, as it uses chacha20::encrypt().
(X)ChaCha20-Poly1305
The impact on (X)ChaCha20-Poly1305 is more limited, as the user cannot specify the initial_counter. However, the plaintext is encrypted with an initial block counter of 1, because the first is used for the Poly1305 key generation. Thus, plaintext bytes may be left in the output buffer if the length of the plaintext is one block less than the maximum (max is 2^32-1 * 64 bytes), which is very unlikely to happen in real-world use.
For the streaming implementation, one block less than the required amount for (X)ChaCha20-Poly1305, is required to hit this, as the initial counter there used internally starts with 2, for plaintext bytes.
Solution
The obvious solution here seems to be, to only copy anything to the output buffer that is ciphertext. Thus, we change the underlying XOR macro usage in ChaCha20 and can take the same approach when processing plaintext bytes in AEAD. In AEAD, we could maybe even get a bit of speedup as we could then encrypt and authenticate the ciphertext block individually, instead of making two passes over the plaintext and ciphertext bytes (first encrypt, then authenticate).
We could also discuss removing the option to set initial_counter for (X)ChaCha20, in a future major release, as there seems to be no real use for it.
cc @vlmutolo

A third option would be to check all the error conditions before any output is written. But I think you're right that we shouldn't ever write plaintext to the output buffer, even if we immediately overwrite it.
One particularly bad situation is if the user sets up the output buffer to be memory-mapped to a file. In that case, there's a chance the plaintext is written to disk and is then far more observable.


Benchmark methodology

I am currently benchmarking the RBM and compare it with the benchmarks reported in the master branch table. I know that @yueguoguo has been working on a new benchmark table, but I will refer to the one in the master branch in what follows.
I think it would be important to specify how the numbers in the benchmark table have been obtained, maybe in a notebook if not directly in the Readme file. I understand that the hyper parameters are not optimal, in the sense that they have not been obtained through an extensive search. Nevertheless, my first question as a user would be: how to interpret and compare those numbers?
Are the reported metrics referring to maximum efficiency (given a set of parameters)?
Let me be more explicit with an example: consider the movielens 1m dataset. All the 3 SAR algos achieve the same metrics but in different times. Are those values the best achievable metrics? Let's say that instead of running SAR CPU for 5 s I run it for 10, will the accuracy be the same or will it increase?
Usually, when I need to compare different Neural network topologies, this will be my main criteria.
This issue becomes more important the moment I want to compare SAR and ALS, or any other algo.
I would like to know which one is more precise. From the table it looks like SAR is better, but it is not clear a priori if running ALS longer will lead to a better result.
Also, I find strange that the evaluation metrics seems to get worst with increasing system size. This is a bit counterintuitive and I am currently looking into this.
It would be nice to know your thoughts :)

this was already discussed, we are working at the moment on adding in the benchmark the new algos: #464. Closing for now, feel free to open in case it is needed


Add bookmark directly from recent searches

Delete is the only option when swipe left on recent search results. Add a bookmark option would be really convenient.
Sent with GitHawk

I have an idea to totally redesign cells. I’d like to remove all the swipes and just have action buttons (ala Twitter.app).
Sent with GitHawk


spyder internal console attribute error

Hi everybody,
when starting Spyder i get the following error:
AttributeError: 'module' object has no attribute 'phymen_usage'
even if i close the console, the message keeps popping up.
Despite that, Spyder seems to work, but of course i cannot proprerly work with this message popping up again and again.
The problem has come out after I tried to install some python package (graph-tool, that i even tried to remove without any change in the spyder error). But I really don't see how it could be related.
thank you

I don't know why that error appears on Spyder, but you can deactivate internal errors reporting errors by going to
Tools > Preferences > General > Debugging

and unchecking the option called
Pop up internal console when internal errors appear


REQUEST: New membership for @jigargandhi

GitHub Username
@jigargandhi
Requirements

[x] I have reviewed the community membership guidelines (https://github.com/dapr/community/blob/master/community-membership.md)
[x] I have enabled 2FA on my GitHub account. See https://github.com/settings/security
[x] I have subscribed to the Dapr community Gitter channel
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more Dapr repositories

List of contributions to the Dapr project

PRs reviewed / authored
I have contributed to 7 PRs and one is in progress in, see my PRs

I support this request.

@youngbupark as additional approver

Your membership has been approved, looks out for a GitHub invite to join the members team on the Dapr org.

Your membership has been approved, looks out for a GitHub invite to join the members team on the Dapr org.

Added


The Message count is not updating with Clearing message for partition

Describe the bug
Message count stays the same after clearing message for partition in Topic's overview page.
Needs refreshing the page.
Set up
https://www.kafka-ui.provectus.io/
Steps to Reproduce

Navigate to Topic's overview
Open the menu for partition
Press Clear Messages

Expected behavior
Messages count should be updated immediately
Screenshots
https://user-images.githubusercontent.com/104780608/196624761-0847ba39-4c30-4562-8890-31af9ec985c8.mov
Additional context

@Drex72 any luck?

@Haarolean this can be checked by QA

Bug still exists on master, let's make status ready after merging.


more verbose exception messages and more logging

Add more details about SQLite error to exception messages and duplicate some of them to the log.
Refs #135.

The backgroound for this job is that we have to remove global SQLITE3 error callback in https://github.com/MerginMaps/geodiff/commit/cf32f8a910cb6b2b9cb7f9b2f9a535d0ebeb5927#diff-c3f0a98c8eb094582d66cbade703fa59bed6879496ae9f9402574b8e73864fb7L77

and therefore we have to check (every) sqlite3 call to the lib and see if in case of failure we can extract the error manually and log it.


Add campaign FAQs to Contact Us modal on action page

User Story
As a user, when I go to submit a question through the Contact Us modal, I want to see the FAQs before submitting my question to see if it can be answered without waiting for a response from a campaign lead.
Additional Information (optional)
In my mind the approach is to:

Edit the copy here https://www.dosomething.org/admin/config/dosomething/dosomething_zendesk so that we acknowledge the FAQs
Add the FAQs between ^ intro text and the submission form.

However this might look wonky so I'm open to other ideas and would be happy to talk through options.
Also this shouldn't matter, but FAQs are updated throughout the campaign so these would need to update accordingly as well.
Why This Matters
It would allow the user to get her question answered more quickly than having to wait for a campaign lead to respond.
Also, currently about 10% of campaign leads' time is spent answering Zendesk questions. About 80% of these questions are covered in the FAQs.

@mikefantini faqs are often pretty long, do you see them getting pulled into the question modal? or just a link to them?

Yeah I worried about that. Simply linking to the FAQs could be a quick fix, although I worry it might not drop the number of questions that dramatically. We could try to be pretty persuasive with copy though - something like "Get your question answered right away by first checking our FAQs which are updated regularly." And at the very least it'd be an incremental improvement over what we have right now and we could monitor how much of a reduction in tickets we get.
Another option would be to have an interaction like we have for sources where the questions are exposed, the answers are hidden, and you can expand/collapse them. Not sure if we love or hate that idea though, especially @DFurnes @lkpttn, but it could be an option. This option might also be out of scope for this.
So I guess I'm saying I'd be down with linking to them as a first iteration and let's monitor how much of a reduction in zendesk tickets we get. And then I'd also love to know people's thoughts on the interaction idea and if that's an enhancement we'd like to explore in the future.

all bold READ THE FAQs
Just in lookin at the TFJ one, it's like three scrolls down to see them all

@angaither yeah which is why the expand/collapse might not be the worst idea anyways.
But again, in the sake of small incremental improvements I'm down with linking for now.
Maybe add it below the current text in that modal as a new paragraph:
"Or get your question answered right away by first checking our FAQs which are updated regularly."


Action build-registry-server failing

https://github.com/apigee/registry/actions/runs/5273705838/jobs/9537430024

This issue is created by an incompatibility between our build and release container images.
We use golang:1.20 as our builder image as our builder - that label is tied to the latest 1.20 go build.
As of go1.20.5 (released a few days ago), this image is being built from the newly released Debian 12 image.
We use gcr.io/distroless/base:latest as our release image, which is still being built on Debian 11. Note: There is an issue to upgrade this to Debian 12.
We copy binaries from the build to the release container, but these are incompatible which causes the command chmod to fail to execute in the distroless container.
A quick fix for now would be to tie our build to go 1.20.4 - which was built on Debian 11.
Note: As distroless intentionally excludes all the binaries for security, if possible we should rethink copying them from the build container.

Note: As distroless intentionally excludes all the binaries for security, if possible we should rethink copying them from the build container.

Do you have a recommendation for what we might do if we didn't copy binaries from the build container?

If we simply remove the extraneous binaries from our release, the build works but leaves us with a binary that gets the following errors when running in the container:
/registry-server: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /registry-server)
/registry-server: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /registry-server)
/registry-server: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /registry-server)

This is because we build with CGO_ENABLED=1, which ties us to the libraries. So, I suggest we do both for now:

Remove the extraneous binaries
Peg the builder at golang:1.20.4

Then when distroless/base is updated, we should be able to unpeg the go version.

Another option is to use the distroless images from Chainguard here: cgr.dev/chainguard/glibc-dynamic.
These work correctly with the updated glibc in bookworm, and are more flexible than original distroless images.
I'd be happy to help! I wouldn't recommend staying on go 1.20.4 - there are several severe CVEs patched in 1.20.5: https://go.dev/doc/devel/release#go1.20

Thanks, @dlorenc, good point on the issues. Another option is mentioned on distroless here: https://github.com/GoogleContainerTools/distroless/issues/1342. I've verified that both your suggestion and using golang:1.20-bullseye as our builder would work. I'm leaning toward switching to bullseye for now as it is the smallest delta. @timburks ?

Sounds good! Let me know if we can help at all.


Can not import Audio file

Describe the bug
When I tired to import a .wav or .mp3 audio file, it said that [7e74ffb4-a210-4a96-bd4c-1ca2eb99b3bd]Validation error(undefined)
To Reproduce
Steps to reproduce the behavior:

Import Data
Select audio file
See error

Screenshots

Environment (please complete the following information):

OS: macOS 10.15.7
Label Studio Version: 1.0.1

Please, send us logs from console

from the above logs, it seems that the size of my audio file is too large. However, I can use the older version (0.9.0) to upload the same file to label.

 On storage settings page? (Sorry, don't remember the exact name of the toggle)

No, I did not enable the toggle. And I did not find the toggle or the storage settings page.

I mean
Project => Settings => Storages => edit your Local files storage

I can not find Storages under the Settings.
The below is my Settings page. (my current project is named test)

And I can not find the Settings under the Projects page. I can only find the Settings when I select a specific project.

Cloud storage = Storages, I was wrong

I have successfully import the audio file. However, I meet with  a new problem that it said Error while processing audio. Check media format and availability.. And I can not set the Target Storage as the local file.

Hi, @ChasingZch ! Could you check whether you include LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true variable in your local environment? It is mentioned here https://labelstud.io/guide/storage.html#Set-up-connection-in-the-Label-Studio-UI-4 .
And yes, target local files storage is not supported yet. Interesting why it should be the case to store something outside the database?

Hi, I encounter the same issue with the same logging info. I assumed my json file was too large (1GB). Spliting the file to fit the maximum size limitation works but is cumbersome. Any idea how to bypass that limitation?

@ChasingZch

I think there is a bug in local storage import: I could discover files and create tasks in project from local directory but then when audio files were loaded to be played, the path gets corrupted. What happens is that only filenames are kept and no folder structure is maintained. In other words, you need to import files from the main directory where the audio files are located. That directory cannot have audio files in subdirectories cause these will not be properly played.
Regarding local file import, you dont need to set up local storage. You can just import file info from the json. Here is a sample that works for me:

[
  {
    "annotations": [],
    "predictions": [
      {
        "id": "prediction_1",
        "model_version": "some_model",
        "score": 6.0,
        "result": [
          {
            "value": {
              "text": [
                "ale \u017cycie to nie jest p\u00f3\u0142g"
              ]
            },
            "from_name": "transcription",
            "to_name": "audio",
            "type": "textarea"
          }
        ]
      }
    ],
    "data": {
      "audio": "/data/local-files/?d=home/toucan/Datasets/audio/Septagon04.wav"
    }
  }
]

Note the missing initial slash in /home/[...]

Hi, @ChasingZch ! Could you check whether you include LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true variable in your local environment? It is mentioned here https://labelstud.io/guide/storage.html#Set-up-connection-in-the-Label-Studio-UI-4 .
And yes, target local files storage is not supported yet. Interesting why it should be the case to store something outside the database?

Hello @niklub , it's not clear what the sentence set LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true in your environment setup means.
Is it a command line argument? But  I encounter the error message label-studio: error: unrecognized arguments: --LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true
Is it a setting in a project template? But I cannot find any.

Hi, @ChasingZch ! Could you check whether you include LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true variable in your local environment? It is mentioned here https://labelstud.io/guide/storage.html#Set-up-connection-in-the-Label-Studio-UI-4 .
And yes, target local files storage is not supported yet. Interesting why it should be the case to store something outside the database?

Hello @niklub , it's not clear what the sentence set LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true in your environment setup means. I don't know what environment setup specifically is.
Is it a command line argument? But I encounter an error message label-studio: error: unrecognized arguments: --LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true
Is it a setting in a project template? But I cannot find any.

This is a env variable that you can either set using (depending on your OS)
export LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true
# now run
label-studio

or you can do it in single command like so:
LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true label-studio

@tingjhenjiang on *nix systems, just use
export LABEL_STUDIO_LOCAL_FILES_SERVING_ENABLED=true

before starting the app

Looks like it's fixed already.


GH Pages: update list of data types, add info about versions

This is the same as https://github.com/concretecms/doctrine-xml/pull/11 but for the GitHub Pages.


Investigate bulk-listing for Seaport (if possible, others too) Protocol

@Aqrare
30m

We think if this is possible in Seaport, if it is really not possible, we will do this in Kagura contract

This is future implemented, so close it for now.

change to implement task


Ultimate Boss Loot Pool

I defeated an ultimate boss scizor and it dropped its normal drops +An Air.
Likely whatever the ultimate loot was has been deleted and instead now drops air.
Screenies:

(The other drop not pictured was a razor claw I had already clicked before thinking to gather evidence.)

IGN: Deathnight7976
Server: Orion

This is likely a leftover Ranch Upgrade loot I missed, it will be fixed in the coming days. Sorry for the inconvenience, and thanks for your report! Keep an eye on #changelog


Ft add summary file output data flags

Update Phonopy user interface flags/settings to output extra data to phonopy.yaml, including: force constants, force sets, dielectric tensor, born effective charges, displacements.
Flags (store_true)/settings (set to .TRUE.): --include-fc/INCLUDE_FC, --include-fs/INCLUDE_FS, --include-eps/INCLUDE_EPS, --include-bec/INCLUDE_BEC, --include-disp/INCLUDE_DISP, --include-all/INCLUDE_ALL.
I have also fixed a few parts that caused bugs in class PhonopyConfParser, and slightly changed how output options are sent through finalize_phonopy to PhonopyYaml, but the change is relatively transparent.

Thanks. Merged to develop branch.

I close this PR.


refactoring and lint fix

説明 / Description
リファクタリングと Lint に対する修正など
チェックリスト / Checklist

MUST

[ ] npm test passed
[ ] npm run lint was applied without warnings
[ ] changes of /docs/webapp not included (except release branch)
[ ] console.log not included (except script file)

RECOMMENDED (it depends on what you change)

[ ] unit test added/updated
[ ] i18n

Codecov Report
Patch coverage: 80.00% and project coverage change: +0.01 :tada:

Comparison is base (f380616) 70.41% compared to head (939e0c9) 70.42%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   70.41%   70.42%   +0.01%
==========================================
  Files          75       75
  Lines       15362    15358       -4
  Branches     1961     1961
==========================================
- Hits        10817    10816       -1
+ Misses       2611     2608       -3
  Partials     1934     1934

Impacted Files
Coverage Δ

src/background/settings.ts
39.22% <ø> (+0.24%)
:arrow_up:

src/renderer/ipc/api.ts
82.72% <75.00%> (ø)

src/renderer/ipc/web.ts
55.67% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Animation glitching when changing scale min and max

Expected behavior
I am using the min max scale for the time axis chart: https://www.chartjs.org/docs/latest/axes/cartesian/time.html#min-max-configuration
Because I need to 'change page' because I have too much data and I use the scale to get from one point of the graph to the next.
my project is really starting to look good and work very well, but unfortunately for me I stumbled across that small visual 'glitch'
I have no cue of what could be causing that, really I tried a lot of things, even checked if my dates were ordered properly, but the only thing that resolve the issue is using different min max values or using less data in the chart
Current behavior
The chart have a blue line created across it while it animate(visual glitch)
Reproducible sample
https://codepen.io/djaeofkao/pen/dyevQLv
Optional extra steps/info to reproduce
You may need to click on the preceding page button a couple time, but the bug always reappear.
I quickly took a screenshot of the behavior: https://photos.app.goo.gl/N7JJQvaVu6qSnGUB8
Possible solution
I would still consider myself a newbie, so unfortunately I really don't have a solution. But as always I have a huge respect for everyone contributing to the chart.js library, it serve my project really well!
Context
I have a 'paging system' because I have a lot of data so I use the scale min max property to move across the chart
chart.js version
3.9.1
Browser name and version
Chrome 103.0.5060.114
Link to your project
No response

I think this could be fixed by scales animating their range change.

I think this could be fixed by scales animating their range change.

Hi kurkle! It's not the first time you help me or answer one of my post. Thanks a lot for your answer, but I didn't really understood your answer, can you clarify a little? I really want to fix this tiny glitch. Thanks again!

I think this could be fixed by scales animating their range change.

Hi kurkle! It's not the first time you help me or resolve one of my post. Thanks a lot for your answer, but I don't understand your answer really well, can you clarify a little? I really want to fix this tiny glitch. Thanks again! By the way I really appreciate your work on this charting library

Its something not supported currently :)

If only I had your knowledge I'd love to contribute to that, but I saw the word 'currently' :) so I guess it will be available in the future. As soon as this work I'll be really happy about that. Have a nice day

Do whatever you please. That'd be neat if you are smarter than me and can even consider fixing it. Good luck! That would be nice

Hi @heavyStuff3000 can I work on this issue

Also if in the end you can redirect me to the code changes required to fix the bug it would be very kind, I'm very curious if I could comprehend this

I solved this with a small workaround:

set the chart options.
postpone the dataset to few milliseconds with a simple setTimeout( )

that solved my issue. it was specifically for a time scale with different min max values.


Including new algorithm

Hi, i wanna know how to include one file generate from Build? Because i'm interested in include other metric learning algorithm. I'm suffering to include in the project

I'm not exactly sure what you're asking, but if you'd like to open a Pull Request with your changes I'll be happy to take a look.

Example, i wanna put the k-stochastic-neighbor (kNCA) from https://github.com/kswersky/k-stochastic-neighbor, but they included one lib file generated from code c++, called "knca_alg.A.dylib". So i dont know how to add :) if you can help me in this case.

The first issue is that the k-stochastic-neighbor repo doesn't have a clear license, so you'll probably want to ask @kswersky for permission before copying that code here. (For reference, this repo is MIT-licensed.)
The second issue is the technical problem of including compiled code. So far, none of the methods here require compilation, so there isn't a build mechanism in place yet, but the idea is to commit the C/C++/Cython sources and configure setup.py to build the native code and place the resulting shared library in the correct location. I don't want to make native compilation a hard dependency, though, so there should be a pure-Python fallback implementation as well (like we have for LMNN).

For an example of conditionally building native code, see: https://github.com/perimosocordiae/sparray/blob/e13fb0948b0f3b38813f072031d97dcf2dcd57e3/setup.py#L4


cant handle utf8 chartacters

Traceback (most recent call last):
File "ExportToAbris.py", line 89, in
File "ExportToAbris.py", line 76, in exportToAbris
File "exportabris.py", line 89, in Export
File "exportabris.py", line 14, in save
File "encodings\cp1252.py", line 19, in encode
UnicodeEncodeError: 'charmap' codec can't encode character '\u25ed' in position 22784: character maps to
[8588] Failed to execute script 'ExportToAbris' due to unhandled exception!
    {
        "geometry": {
            "coordinates": [
                37.180584486445,
                33.808557073502
            ],
            "type": "Point"
        },
        "properties": {
            "description": "CSAR: A-10C_2-Jackal 3C [◭] AJsarge
33 48' 30.805\"N  37 10' 50.104\"E
",
            "icon": "csar"
        },
        "type": "Feature"
    },

I think this just needs the encoding specified in the save function


Backport HSEARCH-4910 to branch 6.2 - Investigate slow startup of Elasticsearch container in integration tests

https://hibernate.atlassian.net/browse/HSEARCH-4910
Backport of #3654 to branch 6.2

Hm yeah, forgot to rebase. Will try again.

Oops, only 190 commits 😃 🙈


Sqlite support

Hello! I would just like to know if you plan to support SQlite at some point? This crate looks really nice and I would like to use it, but my project should support both PostgreSQL and SQlite.
Thanks!

No, SQLite support isn't something that is planned. Swirl specifically uses row locking features only present in PostgreSQL in order to work. It's certainly possible to have a more general implementation like delayed_job in Ruby, but that would be a fundamentally different project than this is trying to be


Add support for vix.com

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2021.05.16
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://www.vix.com/tv/watch/telenovelas/baby-sister/1/1
Single video: https://www.vix.com/tv/watch/telenovelas/baby-sister/1/1
Playlist: No playlists option

Description

WRITE DESCRIPTION HERE
No account needed, all videos are free to watch.

Pero:

Este contenido es protegido por DRM ...

Apparently the linked video is "protected" by "Fairplay" which yt-dl can't decode.

Pero:

Este contenido es protegido por DRM ...

Apparently the linked video is "protected" by "Fairplay" which yt-dl can't decode.

Videos are DRM-free. I managed to get the m3u8 file and use youtube-dl to get the pieces. Works great.

Steps to Cracking Vix
Series
Show
Using https://www.vix.com/tv/serie/telenovelas/baby-sister:

Save everything after /serie/ (telenovelas/baby-sister)

two parts: genre and show slug

genre: series, telenovelas
show slug: baby-sister

Make a GET request to https://catalog.pongalo.com/<genre>/<slug>/<slug>.json
Grab useful youtube-dl playlist metadata

"title", "title_EN", "title_PT"
"summary_EN", "summary_ES", "summary_PT"
"companyDisplayCredit"
"mediaKey" (slug)

iterate over each item in seasons

iterate over each item in episodes

use number, season, and title to create a URL result

InfoExtractor.url_result("https://www.vix.com/tv/watch/{genre}/{slug}/{season}/{number}", video_title=title)

Episode
Using https://www.vix.com/tv/watch/telenovelas/baby-sister/1/1:

Save everything after /watch/ (telenovelas/baby-sister/1/1)

Formatting: <genre>/<slug>/<season>/<number>+

Generate thumbnail URL with https://imgs3.pongalo.com/cdn-cgi/image/w=/<slug>/<slug>_landscape.jpg
Make a GET request to https://catalog.pongalo.com/<genre>/<slug>/<slug>-<number>.json
Grab useful youtube-dl metadata:

"title", "title_EN", "title_PT", "originalTitle"
"summary_EN", "summary_ES", "summary_PT"
"mediaKey" (slug)
"season"
"number"
"runningTimeSeconds"

Get an authentication token

make a POST request to https://prod.pongalo.com/api/members/login-guest with the JSON body: {"guestId": "<random UUID>"}
get the token from root["meta"]["jwt"]

Get the HLS playlist

make a GET request to https://prod.pongalo.com/api/catalog/watch/<slug>/<season>/<number>

Make sure to include an Authorization header: Bearer <token>

get our HLS playlist with root['data']['playKey']

Movie
Using https://www.vix.com/tv/movie/movies/the-healer:

Save everything after /movie/ (movies/the-healer)

two parts: genre and show slug

genre: movies
movie slug: the-healer
OR
Using https://www.vix.com/tv/watch/movies/the-healer/1/1:

Save everything after /watch/ and before /1 (movies/the-healer)

Parse the remaining piece the same way

Make a GET request to https://catalog.pongalo.com/<genre>/<slug>/<slug>.json

Grab useful youtube-dl metadata:

"title", "title_EN", "title_PT", "originalTitle"
"summary_EN", "summary_ES", "summary_PT"
"year"
"createdDate"
"runningTimeSeconds"
"genre", "genre_EN", "originalTitle"
"owner"

Get an authentication token

Get the HLS playlist:

make a GET request to https://prod.pongalo.com/api/catalog/watch/<slug>/1/1

Make sure to include an Authorization header: Bearer <token>

get our HLS playlist with root['data']['playKey']

Probably won't write the extractor myself, but hope this is helpful to anyone that does.

Steps to Cracking Vix

Probably won't write the extractor myself, but hopefully this is helpful to anyone that does.

Thank you hope someone does. :)

@spirulin Thanks!

Issue should be closed, URL is dead


Apply for Discord Open Source

https://discord.com/open-source
We can get a vanity link, such as discord.gg/nodefetch or discord.gg/fetch.
It can benefit the server also.
The server also need some cleaning up btw.

What cleanup do you suggest? Also, how do we get verified?

Over here. https://github.com/discord/discord-open-source
For the server, we can add more roles, post-release on Discord stuff like that
a help channel.
a feature request channel and stuff like that.

@NotMoni We already have a help channel and the main chat is used for feature requests. As for roles, what do you suggest?

As far as I can tell node-fetch qualifies with all the acceptance criteria. Shall I make a PR to add us to the list?
If so, I would need a logo with the correct dimensions (cc @Richienb, I think you made the current one :smile:).

Logo looks awesome.

@NotMoni We already have a help channel and the main chat is used for feature requests. As for roles, what do you suggest?

Oh ok then. I think we can close this once we get verified.

I know for a fact discord would approve, because they use node-fetch as one of the dependencies.

Discord icon svg:
<svg width="72" height="72" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg"><defs><clipPath id="b"><use xlink:href="#a" clip-rule="evenodd"/></clipPath><path id="a" d="M0 0h72v72H0z"/></defs><g clip-path="url(#b)" fill="#FFF"><use xlink:href="#a" fill-opacity="0"/><path d="M37.075 53.805h-.7l-17.15-16.1c-1.7-1.6-4.05-4.65-4.05-4.65s.5 3.75.5 6.2v14.25h-6.55v-34.3h.7l17.15 16.1c1.65 1.55 4 4.65 4 4.65s-.45-3.85-.45-6.2v-14.25h6.55v34.3zm14.1-.3h-7v-34h21.9v6.15h-14.9v11.25h13.55v6.25h-13.55v10.35z"/></g></svg>

Invite code: Zxbndcm

https://github.com/discord/discord-open-source/pull/240

Just want to note that getting added to the list of open source projects on Discord doesn't grant the vanity link benefits.
You need to contact discord via this email address to become a Verified server<EMAIL_ADDRESS>


jshint: why using "esversion": 6? (and below "esnext": false).

Why do you have "esversion": 6 in jshint config? I guess usually we use Angular 1 with es5? If someone wants es6 he can easily change that, but I was coding in es5 and didn't expect that jshint had esversion: 6 in the config I copied from here.
On the following lines of jshint config there is also "esnext": false, which makes things even more confusing, since this option is supposed to disallow es6 features?

I have disabled the "esnext" option and everything is working fine for me, no errors.


rust-cssparser wrong branch

Hi, I got firefox master branch yesterday. One of the patches is wrong, in firefox_125.0.2.bb:
 git://github.com/servo/rust-cssparser;protocol=https;branch=master;name=cssparser;destsuffix=cssparser \
...that must be "branch=main"

Thank you very much for reporting this. It should be fixed corrected in the head of master branch.