Integers are real numbers

In https://github.com/mnvr/mrmr.io/blob/47f06c540fa7f4938ce1b4f06446a9abc77e75d6/pages/num/index.mdx#L148 and the following paragraphs you stated that integers are not real numbers; that they are "comparable" but not "equatable". This is incorrect. Every integer is a rational number, and every rational number is a real number. Mathematically speaking 1.0 and 1 are exactly the same number. You are correct that the integers make up an infinitesimal portion of the real numbers (the random selection example) but this could be said of most subsets of the real numbers. For example, the odds of randomly selecting a number where no digit is 7 (in your choice of base ≥ 8) from the set of real numbers is zero; it will never happen. Yet there are infinitely many numbers meeting that criteria, and your inability to randomly select them from the set of real numbers does not mean they are not real numbers.
Floating point numbers are an extended subset of the rational numbers (they cannot represent non-rational real numbers) with power-of-two denominators within a fixed range, augmented with negative zero, positive and negative infinity, and various forms of NaN. Because they are a subset many operations on rational numbers can only give approximate results, but double-precision floating point math can at least give exact answers for addition, subtraction, and multiplication of all 32-bit integer operands for which the corresponding integer operation would not overflow as the significand is more than 32 bits. This is how Lua and JavaScript can get by with using only floating point numbers. (The same does not hold for 64 bit integers, however.)

Hey, thank you for the comment!
There are multiple things going on here, so I'll try to split them off and give me thoughts on them separately. That said, I am not going to insist that my conclusion, that integers are not real numbers, is correct. I posted this article on /r/haskell too, and many other commenters also pointed out that that's an incorrect conclusion.
I still feel that not integers are not real numbers. I am unable to give a clear exposition why. Or maybe it is just that thinking of them as distinct, disjoint, sets that has helped me understand why the Haskell types (which are sets) to represent them also need to be distinct. i.e. they're distinct only in a programming context (or in my own head), but they still are mathematically the same thing.

...inability to randomly select them from the set of real numbers does not mean they are not real numbers.

Agreed, and I also mention this is the post that was my first, but ultimately flawed, realization. I can see that this line of thinking is not mathematically justifiable.
However, for me this line of reasoning points out that the nature of the infinity that we're dealing with when dealing with real numbers is different from the more comprehensible infinity that we deal with when we deal with integers. Calling both of them infinity is maybe a mistake too, there is something more monstrous about the infinity of real numbers. And now I'm a bit more apprehensive when drawing conclusions, both for or against integers == or != real, using these lines of thought.
So the selection argument is not my primary premise, it is just something that lead me to see how integers and reals behave differently.

Floating point numbers are an extended subset of the rational numbers (they cannot represent non-rational real numbers)...

I agreed with this paragraph, I never said otherwise. The issues of floating point representation vs the underlying numbers (real or integral) is a different concern, not related to the my main concern: are integers real (sic). Though interestingly, we can create bigint types that can be arbitrary precision representations of integers, but we don't have types that can provide arbitrary precision representation of reals.

So coming back to the core issue. I have actually trouble formulating what is the core issue:

Is it that, as you said, "mathematically speaking 1.0 and 1 are exactly the same number."?

Is it that integers are a subset of reals?

Is it that something else that I'm trying to (and failing to) express?

For (1), I think your line of thought (Every integer is a rational number, and every rational number is a real number.) is correct. In the reddit comments also, some people pointed out that we can construct homomorphisms from the ZF sets that represent 1 (the integer) to ZF sets that represent 1.0 (the real) and so mathematically, these are equivalent. So this isn't the sticking point.
For (2), the arguments for (1) can be just extended to show that all ZF sets that represent an arbitrary integer i are homomorphic to an set in the set of reals. And thus, integers can be thought of as a subset of reals.
I sort of agree with this. The line of reasoning is correct. What I'm having trouble with is that I think it fails to capture the infinity that hides behind each real number. A real number is an potentiality, not a thing. There is a thing called 𝜋, but I think it is not a thing, it is an asymptotic perfection that cannot be reached. On the other hand, 22 is a perfectly reachable thing.
So maybe the issue is just (3) - I'm maybe mixing mathematics and philosophy, and mixing them in ways that I don't fully understand.
BTW, I put a disclaimer in the article ("I’m sure I still have some, maybe all, of the technicalities wrong."), but if you feel the article is coming off as misleading, let me know, I'll put in a stronger disclaimer.

Thanks for commenting, really. I feel these are fascinating topics, numbers. And by having such conversations I get to improve my understanding of them.

Just to be on the safer side, so as to not even unintentionally mislead, I've gone ahead and added a stronger disclaimer to the post - https://github.com/mnvr/mrmr.io/commit/e01acd7e37c854307cadfc1356927d9479bc2f2d

However, for me this line of reasoning points out that the nature of the infinity that we're dealing with when dealing with real numbers is different from the more comprehensible infinity that we deal with when we deal with integers. Calling both of them infinity is maybe a mistake too, there is something more monstrous about the infinity of real numbers.

Yes, this is the interesting difference. While integers are a subset of the real numbers, the integers are countably infinite, meaning that a one-to-one mapping can be established between the natural numbers and the integers (0, -1, 1, -2, 2, -3, 3, ...), while the real numbers are uncountably infinite. Rational numbers, interestingly, are countably infinite like the integers (via diagonalization) despite being  densely ordered (between any two distinct rational numbers there exists at least one other rational number—their average—and thus an infinite set of rational numbers).

There is a thing called 𝜋, but I think it is not a thing, it is an asymptotic perfection that cannot be reached. On the other hand, 22 is a perfectly reachable thing.

I think I would have to disagree with you there. The irrational, transcendental number number π is one of the more "real" numbers to exist. As the ratio between the circumference of a circle and its diameter it appears everywhere in nature. On the other hand, when it comes to measurements 22 inches and 7π inches are equally approximations, limited by the precision of our tools. Even in simple counting there is always some uncertainty. Objects move around, their classification as members of the set may be questioned, and even their existence may be in question to a degree. For example while counting electrons in a given space an electron-positron pair may come into existence briefly from the quantum vacuum, meaning that over any given time period the average count may not be exactly 22, or even an integer. Improved measuring technique—faster samples, better signal-to-noise ratio—can reduce the uncertainty, but in a sense we only get an exact answer like "22" by ignoring these minor variations and rounding to the nearest integer.

Though interestingly, we can create bigint types that can be arbitrary precision representations of integers, but we don't have types that can provide arbitrary precision representation of reals.

We can have types that provide arbitrary precision representations of some kinds of irrational reals. For example, we can trivially define a type data Root = Root Word Integer which can precisely encode √2; more generally we can represent known/named irrational numbers symbolically as strings or parse trees. More usefully, many irrational numbers can also be represented exactly as continued fractions with regular patterns, including √2, e, and Φ. The number π does not have a known pattern in its simple continued fraction, but it does have several generalized continued fraction forms which can be represented concisely.
Unfortunately the irrational and transcendental numbers are mostly defined by what they aren't (not rational, not algebraic) which does not readily lead to a common standardized representation distinct from their individual derivations, and the encodings which are available are not necessarily suited for common arithmetic operations like addition, subtraction, or multiplication. In general it's easier to work with approximations such as floating point.
Thanks for pointing out the r/haskell post. There were some good comments there. I found your article via Planet Haskell rather than Reddit, and as there was no obvious way to respond on the page itself I followed the GitHub link and ended up here.


PORTALS-3062: add cancer complexity help text content, and also fix t…

…he size of the help popover icon in this context


Added totalPayments uint on PullPayments contract

Addition of totalPayments variable to keep tracking of the total amount of ethers owned to other addresses via pull payments. Fix #189

LGTM

As I was discussing on slack with @frangio, we don't like the name, but we couldn't think of anything better :P


Dotless error when query string is supplied

I'm having the issue explained here:
.less compilation error when query string is supplied
Also, the following is also happening (it is described in one of the comments of the question):

If it is the first hit into the application after compilation or redeploy (so the application is JIT compiling) then the above occurs. This is when the .less is compiled. Subsequent calls to this endpoint after the JITing then no issues occur because the .less has been compiled.

What could be the problem? I'm available to help in the debugging process so if you have some question, you can ask.

I just solved the problem by updating dotless and dotless adapterfor System.Web.Optimization to their last available versions:

dotless: 1.5.0
dotless adapterfor System.Web.Optimization: 1.3.3

This is a duplicate of #418, fixed in release 1.4.3. :)


Implement logic to let developers release their own themes

Closes #12
There's still a decent amount of things to do here, but as of now, running the task will replace the necessary files and rename them accordingly. I'll remove the WIP tag when I finish up.
Next I'll have to actually change the strings inside the files which aren't ejected into the main app. For example:
module BulletTrain
  module Themes
    module Light # ← This guy
      # Code here...
    end
  end
end

Changed the original theme name to the developer's new theme name in files specific to the gem like .gemspec. Next is pushing the content to GitHub and publishing the gem.

@andrewculver There's just a little bit more to do, but as of now we can do the following:
Make a new gem

Add this branch to the gem file and bundle install:

gem "bullet_train-themes-light", git: "git@github.com:bullet-train-co/bullet_train-themes-light.git", branch: "features/release-theme-task"

rake bullet_train:themes:light:eject[custom_theme]
Make edits to the theme in the main application.
rake bullet_train:themes:light:release[custom_theme] ← This will push to GitHub

Use the theme in a fresh Bullet Train app

After the gem is published, add the new gem to the Gemfile and bundle install.
rake bullet_train:themes:custom_theme:install
↑
Currently, we can't actually run this install task because the repository we're cloning from (naturally) doesn't have the task. For now, we have to manually write custom_theme in Procfile.dev, app/helpers/application_helper.rb, and package.json.

At this point, you can run bin/dev and try the theme.
Side note
To currently try out the installation task, you can reinstall the light theme by running rake bullet_train:themes:light:install after you've ejected a custom theme since the installation task exists on this PR's branch.
Other things to handle

The next step is just making sure our tests work on a fresh, main application. They're currently not passing after including a newly published gem, and it says this specific file isn't in the pipeline (after making bullet_train-themes-custom): application.custom.js.
We delete all the custom theme files from the main app after moving them to the new gem, so we should add git add . and commit.

I want to put out a finished product, but there's a decent amount of code here and I figured it would be better to give partial updates like this instead.

Linking #18 here, since the application.custom.js error I mentioned in the last comment is related to it.

@gazayas This is totally crazy! Thanks so much for this!

@andrewculver I definitely underestimated the scope of the task when I started so it took some time, but I'm glad it got merged!


change navigation when trying to return after creating a PM

How to produce it
Go to the page where you can create the new PM -> try to search users whom you want to PM -> click on the intended profile -> press the "previous page" icon
expected behaviour
it should return back to screen where all the users are present , but it navigates to the PM page which contains our PMs
video demonstration
https://github.com/zulip/zulip-mobile/assets/72563697/cf4a538e-7996-4c68-95de-b605c79ce647

This is intended behavior. You can think of the "New PM" screen as an interstitial where you select which PM thread you want to navigate to. Once you've done that, the interstitial has served its purpose and doesn't remain in the history stack.


CARDS-683: As an admin I can use the questionnaire wizard to specify the condition or conditions when a questionnaire section should be displayed

Includes:

CARDS-683 - As an admin I can use the questionnaire wizard to specify the condition or conditions when a questionnaire section should be displayed
CARDS-1764 - Questionnaire wizard: the variable name / entry identifiers should be visible in the edit mode
CARDS-1765 - Better display of the expression property of computed fields, as a formatted code block
CARDS-1766 - When deleting an item, reload only its parent instead of the whole questionnaire
Some refactoring and console warning fixes

To test:

The entire functionality of the questionnaire wizard in general
Creating / updating section conditions in the questionnaire wizard
In forms, the behavior of sections with conditions created/updated in the questionnaire wizard

Reviewing:

This is a large PR that adresses several related issues and affecting multiple files. A couple of refactoring iterations were done prior to the implementation of the actual new feature. Reviewing commit by commit rather than file by file is recommended.

Bug: In the admin questionnaire editor, adding new items with the blue (+) floating action button correctly adds the item but does not update the view to display them, requiring a refresh to view the newly added item.
Bug found, but fixed by rebasing onto dev: Conditional ranges aren't working properly, should work fine once merged

Rebased on the latest dev which includes Material UI 5 upgrade, and updated the new component to Material UI 5 in f99e55a.


More twist tests

Added more twist cases for tests generated in Sage

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c9981f0) 94.58% compared to head (012fdfd) 94.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #777      +/-   ##
==========================================
- Coverage   94.58%   94.58%   -0.01%
==========================================
  Files         144      144
  Lines       33773    33838      +65
==========================================
+ Hits        31943    32004      +61
- Misses       1830     1834       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Correct plugin tags

Remove incorrect tags:  "microservice", "docker", "containers"
Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 98.315%. Remained the same when pulling 08b847c32e67dcae0569b3deaf9106c6625f8e26 on correct_tags into 1797c7d2091842179d3d6f88e80a4a2989eb24f7 on main.


Range operator

This PR adds support for the range operator ("branchA..branchB") to the log and rev-list commands.
It also refactors revision specifier processing into a "pipeline" model, to make it easier to support new kinds of specifiers.
See #561

Awesome work @eatdrinksleepcode! 🎉


add licenses for AbstractBoundedNodeQueue.java

see #425 and #426
neither the Andriy Plokhotnyuk or Dmitriy Vyukov links contain notice files.
https://www.1024cores.net/home/lock-free-algorithms/queues/non-intrusive-mpsc-node-based-queue
https://github.com/plokhotnyuk/actors/blob/master/LICENSE
https://github.com/plokhotnyuk/actors/blob/2e65abb7ce4cbfcb1b29c98ee99303d6ced6b01f/src/test/scala/akka/dispatch/Mailboxes.scala does not contain a source code header

closing in favour of https://github.com/apache/incubator-pekko/pull/433


Signer bonds Uniswap v2 strategy

Depends on: #53 (system tests are required for this pull request)
This pull request introduces the implementation of the SignerBondsUniswapV2 contract. This contract provides an implementation of the ISignerBondsSwapStrategy interface and allows the following flow to take place:

Risk manager purchases signer bonds and deposits them on the SignerBondsUniswapV2 contract
An interested third party (or the governance itself) swaps an arbitrary amount of bonds (within governance parameters boundaries) on UniswapV2 and sends acquired collateral tokens to the asset pool.
Acquired tokens increase the asset pool collateral balance without minting any underwriter tokens.

Several governance parameters can be set by the contract owner to keep swap transactions reasonable. These parameters are:

maxAllowedPriceImpact: determines the maximum allowed price impact for swap transactions. Price impact depends on the transaction volume and acquired token reserve. Transactions whose impact exceeds the limit are reverted. This parameter forces transaction volumes to be reasonable and helps to avoid poor execution prices which are unacceptable from the business point of view.
slippageTolerance: determines the slippage level which is tolerated by swap transactions. Slippage may occur in the time window between the moment when the swap transaction is submitted and eventually mined. Transactions whose slippage level exceeds the tolerance limit are reverted.
swapDeadline: determines the validity time of a swap transaction. If the transaction is not mined before the deadline it is reverted.

This pull request also contains unit and system tests of the provided strategy. It also provides a test case that asserts that an arbitrary collateral token transfer doesn't break asset pool wthdrawals.

Rest looks good to me. Nice example on how to use Uniswap in our project, might be useful for other issues.

Everything addressed @dimpar


Option to create ticket on Github when something being search is not found!

When a user searches for some documentation, and we dont have any content related to that, we should show a message something like.
Counld't Find What You are looking for? Create an Issue on Github
With a clickable link to forward to https://github.com/gofr-dev/gofr issues page

Sure @leidorf - Assigning this to you!


lakefs import with create repository as import branch as parent

Codecov Report

Merging #810 into master will increase coverage by 0.31%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   41.88%   42.19%   +0.31%
==========================================
  Files         133      134       +1
  Lines       10422    10402      -20
==========================================
+ Hits         4365     4389      +24
+ Misses       5477     5430      -47
- Partials      580      583       +3

Impacted Files
Coverage Δ

catalog/cataloger.go
68.14% <ø> (ø)

catalog/cataloger_set_default_branch.go
55.55% <55.55%> (ø)

catalog/cataloger_create_repository.go
62.16% <86.66%> (+5.01%)
:arrow_up:

api/api_controller.go
37.47% <100.00%> (+1.34%)
:arrow_up:

onboard/import.go
62.74% <0.00%> (-2.57%)
:arrow_down:

onboard/catalog_actions.go
67.85% <0.00%> (-2.28%)
:arrow_down:

block/s3/inventory_iterator.go
85.50% <0.00%> (+0.89%)
:arrow_up:

catalog/cataloger_create_entry.go
100.00% <0.00%> (+5.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee09a87...f57d637. Read the comment docs.


FIX don't kill execution when errors are detected

Instead we should log the error, then re-throw them. This will be useful for debugging purposes, while maintaining existing functionality (while also keeping things functional).

Approved, and tests green.
Merging.


Avoid highly specific matches on general terms

This is a question and not a feature request or bug report, so let me know if I should put it elsewhere.
Does anyone have any general techniques to prevent a general concept from matching to a highly specific concept? As an example, "high-risk" is matched to the UMLS record for "unsafe sex".

Other examples:

'business combinations': ['Short-acting sulfonamide combinations', 'Salt solution combinations', 'topical antibiotic combinations', 'lung surfactant combinations']
'derivatives': ['Amine and/or amine derivative', 'Caranes', 'Pinanes']

Additionally, any ideas about filtering out generic term matches, even if accurate? I can filter on "types", e.g. to say I am only interested in T121 (Pharmacologic Substance), but it will still match a bunch of terms to "Pharmaceutical Preparations" and the like. I can do this in post-processing, perhaps with some tfidf approach or some "specificity score" based on where the entity sits in the UMLS tree. But I figured I'd ask if anyone has a better way.

The approaches you described are exactly what I would try first. Using tfidf or something similar, and using the umls type tree. Filtering to a higher score threshold can also be helpful. Lastly, you could try training a further entity linking model to distinguish.

Cool thank you @dakinggg. I will go ahead and close this!


Support for nested jobs

Using the MultiJob is handy; however, when it comes to templates, it's be nice to just see applicable builds of the parent job.

Gets really tricky ... as a possible work-around, why not just continue to use multi-job since there's a downstream dependency, it pretty much does that.


nrf52840 skeleton for BLE telemetry

Exactly as the title says.

Moved to separate nRF52 repo because of conflict with the bare-metal config needed for LPC1549 + SD card but mutually exclusive with BLE.


Refactoring CMakeList

NOTE: This is just my personal opinion. You don't have to accept all this. If you don't like this, please close.
This is a very interesting project. 👍
I think you should refactor CMakeList to be easy used by many developer.
I made your CMakeList more simple. I confirmed that it works on Windows. (It has not been tested on Linux.)
cmake_minimum_required(VERSION 3.1)

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

project(Kinect_Alignment_Cuda VERSION 1.0.0)

if(WIN32)
    # For Azure Kinect Sensor SDK Installer
    # find_package(k4a) is search library using cmake/Findk4a.cmake.
    set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake" ${CMAKE_MODULE_PATH})
endif()

find_package(k4a REQUIRED)
find_package(CUDA REQUIRED)
find_package(OpenCV REQUIRED)

if(k4a_FOUND AND CUDA_FOUND AND OpenCV_FOUND)
    cuda_add_executable(cuda_alignment main.cpp cuda_k4a_align.cu)
    target_link_libraries(cuda_alignment k4a::k4a)
    target_link_libraries(cuda_alignment ${OpenCV_LIBS})
    target_link_libraries(cuda_alignment ${CUDA_LIBRARIES})
endif()

I don't recommend that copy dll files.
The current implementation depends on pre-built Azure Kinect Sensor SDK and pre-built OpenCV.
In most cases, I think set the path in environment variable PATH.
It's more versatile except when distributing application to users.
Therefore, the following lines should be removed.
- add_custom_target(generate_dll
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/k4a.dll ${CMAKE_BINARY_DIR}/Debug
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/k4a.dll ${CMAKE_BINARY_DIR}/Release
-
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/depthengine_2_0.dll ${CMAKE_BINARY_DIR}/Debug
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/depthengine_2_0.dll ${CMAKE_BINARY_DIR}/Release
-
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/k4arecord.dll ${CMAKE_BINARY_DIR}/Debug
- COMMAND ${CMAKE_COMMAND} -E copy ${K4A_BIN_DIRS}/k4arecord.dll ${CMAKE_BINARY_DIR}/Release
-
- COMMAND ${CMAKE_COMMAND} -E copy ${OpenCV_DIR}/${OpenCV_ARCH}/${OpenCV_RUNTIME}/bin/opencv_world${OpenCV_VERSION_MAJOR}${OpenCV_VERSION_MINOR}${OpenCV_VERSION_PATCH}d.dll ${CMAKE_BINARY_DIR}/Debug
- COMMAND ${CMAKE_COMMAND} -E copy ${OpenCV_DIR}/${OpenCV_ARCH}/${OpenCV_RUNTIME}/bin/opencv_world${OpenCV_VERSION_MAJOR}${OpenCV_VERSION_MINOR}${OpenCV_VERSION_PATCH}.dll ${CMAKE_BINARY_DIR}/Release
- )

I don't know if these are necessary lines.
At least in my environment, it was unnecessary.
set(CUDA_ARCH "-arch=sm_50" CACHE STRING "Value of the NVCC -arch option.")
if(${CMAKE_VERSION} VERSION_EQUAL 3.7 OR ${CMAKE_VERSION} VERSION_GREATER 3.7)
    option(AUTO_DETECT_ARCH "Detect local GPU compute arch automatically" ON)
endif()

if(DEFINED AUTO_DETECT_ARCH AND "${AUTO_DETECT_ARCH}")
    CUDA_SELECT_NVCC_ARCH_FLAGS(ARCH_FLAGS "Auto")
    set(CUDA_ARCH "${ARCH_FLAGS}" CACHE STRING "Value of the NVCC -arch option." FORCE)
endif()
message(STATUS "CUDA_ARCH: \"${CUDA_ARCH}\"")

SET(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} ${CUDA_ARCH}")

if (CMAKE_COMPILER_IS_GNUCXX)
    set(CMAKE_CXX_FLAGS "-O3 -Wall")
    set(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} -std=c++11")
endif()

SET(CUDA_NVCC_FLAGS "${CUDA_NVCC_FLAGS} ${CUDA_ARCH}")

Thank you for your comment :)
I agree with your opinion!
I think It(generate_dll module) should be removed. I'll change it!
Thank you  👍


fix: typo in documentation

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 00f3616a4c414cba4265d8073093d598b11185f9
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

Commit: 861e7b71750aa53e90e83b4a91a440498b8da374
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md

This message was auto-generated by https://gitcop.com

@afck a valid commit message would be docs(mainpage): fix typo

Ah, sorry! I changed it.

Thanks!


unify TreeMapper and ShallowMapper via template parameters

Motivation

We shouldn't have to duplicate hundreds of lines of code just because one member of one kind of tree is treated differently.
Test plan

See included automated tests.

Have you checked whether this affects compile times?

I didn't notice anything radically different when I wrote the patch.
My experience is that templates are not the place to go hunting for compile-time wins. There are certainly cases where particular template techniques can do terrible things to compile times, of course, but this technique is not one of them.


ENH/VIZ: display .nave by default in plot_evoked

I was thinking repeatedly for months that having the .nave output by default in the title or so of plot_evoked would be so useful. What do you think?
cc @jona-sassenhagen @mmagnuski

A parenthetical after the condition name would be nice

Probably better than what we have right now :)

A parenthetical after the condition name would be nice

yes

Probably better than what we have right now :)

and yes.
Great, so it seems some people like it. Let's do it! Marking as easy.

@massich maybe something you could like to look into, relaxing from pytests.

I like that too :)

I like that too :)

great!

Hi,
Can I get some reference to the problem and what sort of script is required to be written.
And this is related to which objective.

Or if I can get some doc to look into

Hi @thesujitroy have a look at some of the basic tutorials that compute evoked responses and call evoked.plot(). You will notices that no information on the number of averages (nave) is present. The idea is to find a way to show the evoked.nave attribute when plotting. mne.viz.plot_evoked needs to be updated for that. I hope this helps.

Alright. Thank you

I  am taking this issue.

Great! Don't hesitate moving in small steps. It is bettet to start
somewhere and communicate early. Perfection comes in iterations.
On Fri, Mar 2, 2018 at 11:01 AM thesujitroy<EMAIL_ADDRESS>wrote:

I am taking this issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/issues/4484#issuecomment-369877887,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB0fig7oCncjbSvAY4wFb5n7zyGuN7t1ks5taRhmgaJpZM4O2apD
.

Hi,
I was going through the code and it seems that nave is declared to be 1.
However, in plot_evoked the attribute needs to be added. But I cant understand the attributes we are trying to show is evoked.nave, this needs to show in plot in what form.
Can the Number of averages be more than 1, and are trying to put it in butterfly plot?

But I cant understand the attributes we are trying to show is evoked.nave, this needs to show in plot in what form.

See comment from above

Can the Number of averages be more than 1, and are trying to put it in butterfly plot?

It's the number of trials used in the average for the evoked, i.e., evoked.nave

@thesujitroy any progress?


Support update all parameters as once.

Issue #, if available:
update-parameter-group API has a maximum limitation to parameters update. Only 20 parameters are allowed to update at once.
Description of changes:
Call update-parameter-group API twice to handle the case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/retest


translate-it ?

Is there somebody to translate this ? (in french would be great for me)

ok, i didn't see https://github.com/ncase/covid-19#how-to-translate


sysinfo crate doesn't get its documentation generated

Linked to #511. Since it's being recognized as a binary, no documentation is generated, which is a big issue.

Duplicate of https://github.com/rust-lang/docs.rs/issues/511.


Relative Dependency of a Git Dependency Fails to Resolve

Steps to Reproduce

Create a new Flutter project: flutter create git_package
Create a folder in the project's root directory as custom_libs/my_relative_package and run flutter create . inside my_relative_package folder from terminal
Go to project's pubspec.yaml and add the other project as a relative dependency:

dependencies:
  ...
  my_relative_package:
    path: custom_libs/my_relative_package

Upload project to github
Create any other project that adds git_package as a dependency:

dependencies:
  ...
  git_package:
    git:
      url: https://github.com/yourUserName/git_package.git
      ref: main

run flutter pub get in your newly created project that depends on git package

Expected results:
Relative import at git_package to be resolved automatically
Actual results:
Invalid description in the "git_package" pubspec on the "my_relative" dependency: "custom_libs/my_relative_package" is a relative path, but this isn't a local pubspec.
   ╷
37 │     path: custom_libs/my_relative_package

I'm pretty sure I am missing something essential regarding resolving package dependencies. My best guess is that I can't have a local package as a dependency in a remote URL. Could anybody shed a light to this matter if possible? Thanks in advance.

I'm pretty sure I am missing something essential regarding resolving package dependencies. My best guess is that I can't have a local package as a dependency in a remote URL. Could anybody shed a light to this matter if possible? Thanks in advance.

Per https://dart.dev/tools/pub/dependencies#path-packages, it sounds like a path dependency only works in the project you're working on, not a project's dependency. Closing this as unrelated to the Flutter SDK (this is a limitation of https://github.com/dart-lang/pub/issues), although it also sounds like this is working as intended. If you have a feature request, the pub issue tracker would be the place to track. Thanks!


Web UI based on GoSlice

Hi! I have created a Web GUI for GoSlice to be used in my cloud system called "SlicerA". That is why I am sharing it with you using this "issue" (as you don't seems to leave any email or threads specially for sharing downstream projects). You can check it out over here: https://github.com/tobychui/SlicerA

The SlicerA is also open sourced and licensed under AGPL. As this is my first time integrating an open source software based on AGPL, please let me know if there are any problems in my way of crediting the author under the AGPL requirements.
Have a nice day :)

Hi, very cool!
AGPL:
Basically as long as you publish the source as AGPL everything is fine. The only thing which is different from GPL is that you cannot Host any altered GoSlice version without providing the sourcecode. ->  Network use is distribution
And that's basically what I want to achive with AGPL: If you host it somewhere (cormmercial or not) I want the sourcecode back if it was altered, and I want to  know that GoSlice is "in" it. ->  License and copyright notice
So for your project this basically means: For the binaries you provide in the repo, I think your notice https://github.com/tobychui/SlicerA/blob/main/goslice/README.md here is sufficient (if you didn't alter the source. In that case just provide the source for the changes).
Also it is a good idea that you ship it as a separate module because of the copyleft.
-> so everything fine :+1:
About your project:
I also wanted to create a web gui, but couldn't get to it yet because of many other (mostly unfinished) projects.
Its very cool that you started one :-)
The only thing I did was experimenting with running GoSlice as webassembly https://aligator.dev which works, somehow, but is not very fast and blocks the browser js thread most of the time. (Just type goslice gopher.stl or any direct link to another stl file e.g. from thingiverse)
As I modified GoSlice since our last discussion to be better usable as Go lib, maybe it would be an idea to leverage that instead of shipping a GoSlice binary. https://github.com/aligator/GoSlice#use-as-lib
I also used that for the webassembly version https://github.com/aligator/dev/tree/main/go/goslice
In the end it would be nice if SlicerA would be also runnable without ArozOS (very cool project by the way :-) as standalone web-app. But that may be an extra project which just shares some common code with SlicerA. What do you think?
Thanks for sharing :+1:

Nice to know my crediting in the SlicerA is complying the AGPL 👍

In the end it would be nice if SlicerA would be also runnable without ArozOS

Sure, making SlicerA run-able in standalone mode will be good for those who don't know how to use ArozOS and just want a simple web slicer. I guess I will need to schedule some free time next week and try to trim out something in standalone mode as AGPL license is a bit complex to deal with.

I also started experimenting with threejs https://github.com/aligator/dev/blob/gcode-viewer/src/gcode/gcode.ts Maybe this will be a working gcode viewer lib some day :-)
Some thoughts to AGPL: I am also not that experienced with it. Initially I chose it because I rewrote the initial commit of Cura as starting point and therefore "used" Cura code which is AGPL. Also I think it fits to what I want: open source everything what anyone does with GoSlice, even if it is just hosting a (modified) version.
As far as I understand it, you could create a GoSlice server using GoSlice as lib in an extra Project as AGPL which exposes for example a REST api.
Then you could call this server from any frontend and the license of the frontend doesn't matter, as it doesn't include any GoSlice source.
If you host such a server you would need to provide the source of the GoSlice Server (as AGPL) and give credits that the frontend uses it. But the Frontend can be whatever License you want, as it just calls the api.
As I am not a lawyer, this may be wrong ;-) It's really not the easiest topic...

I do not think rewriting Cura's code by hand fitted the "used" definition in license term. In my opinion, as soon as it is not machine translated or parts that are copied directly from the upstream (Cura) source, you can claim it as yours even the logic are similar or identical.
I have find an alternative STL viewer that is MIT Licensed and integrated with the new SlicerA "standalone mode". Feel free to have a look at it when you have the time to do so :)

yeah maybe
Anyway I still like the prinziple of GPL + Network use is distribution :-)
Very cool, thanks, I will check it out 👍

Maybe I will be closing this issue now. If you find any bugs or feature wanted on SlicerA, feel free to open an issue on the SlicerA repo. Thanks!


[EVENT PUBLISHER CHANGE] in event "OnInsertJobExtTextRetLastOnBeforeToJobPlanningLineInsert" in codeunit 378 "Transfer Extended Text"

Describe the request
The current event signature look like this:
[IntegrationEvent(false, false)]     local procedure OnInsertJobExtTextRetLastOnBeforeToJobPlanningLineInsert(var ToJobPlanningLine: Record "Job Planning Line"; JobPlanningLine: Record "Job Planning Line"; TempExtendedTextLine: Record "Extended Text Line" temporary; var NextLineNo: Integer; LineSpacing: Integer; var IsHandled: Boolean)
Compared to the same event for the sales line there is a var parameter missing for the JobPlanningLine Record.
So it should look like this:
[IntegrationEvent(false, false)]     local procedure OnInsertJobExtTextRetLastOnBeforeToJobPlanningLineInsert(var ToJobPlanningLine: Record "Job Planning Line"; var JobPlanningLine: Record "Job Planning Line"; TempExtendedTextLine: Record "Extended Text Line" temporary; var NextLineNo: Integer; LineSpacing: Integer; var IsHandled: Boolean)
Thanks in advance,
Tobi
Additional context
We need the var parameter, because we want to skip the description line of standard texts and just insert the extended text lines.
Internal work item: AB#554763

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 25639.


Error runtime

When generate_ligands.py was running, I got an error.
Cloud you please help me to solve this problem?

I got the same error too.
I deleted the .cpu() in lines 809-810 of lightning_modules.py and the errors disappeared.
    # Build mol objects
    x = xh_lig[:, :self.x_dims].detach().cpu()
    atom_type = xh_lig[:, self.x_dims:].argmax(1).detach().cpu()

I changed the above as follows
    # Build mol objects
    x = xh_lig[:, :self.x_dims].detach()
    atom_type = xh_lig[:, self.x_dims:].argmax(1).detach()

I changed it as follows.

Thank you @msako82. I changed the line in Jupyter Notebook
from
'device = 'cuda' if torch.cuda.is_available() else 'cpu''
to
'device = torch.device("cpu")'.
It worked for me.

Hello, thanks for your answers!
Interestingly, this error didn't occur in my environment but this commit should fix the issue for everyone.


Images not captured

In file France / FRA_A27_Unit.html 3 images are provided after the table for the BottomLayer, through their top values cosmetically put them before the table:

But, they don't get picked up at all by the parser:

Fixed in #553.


Shell Script

Is your feature request related to a problem? Please describe.
I am finding it difficult to demo a container running with the container command as configured, first.
Second, I am finding it difficult running a container command with a shell script.
Third, I am finding it difficult to run a generic container with a command line entrypoint.
Describe the solution you'd like
Ideally I would submit a container with a CLI command or entrypoint to Fission, and invoke it via fission fn test, and then via http GET with a body that is passed to the command line command on STDIN, as a start.
This will be an enormous help for two reasons:

I am not standing up an API to service any kind of optimization
I may be sending data to a command line tool for processing via either CLI (dev), or API (prod), but I don't want to have devs standing up APIs for the sole purpose of fitting into a tool.  All things are actually leveraged on the command line during dev and in operation.

If I can simply have an example that works, that would be a major help.  I don't see any way to do it with the binary-env. While it does exist and is supported, there are no available examples.
Once I can prove I can:

run a shell script
provide my own image

Then I know anything is possible with, more or less, minimal extra work.

To supplement this, I've figured out how to deploy a shell script, but it'll be running on a bare apk image, which I am happy to stick somewhere:
CODE?=hello.sh
IMAGE?=fission/binary-env
ENV?=$(notdir $(IMAGE))
FN=$(shell basename -s .sh $(CODE))-$(ENV)

hello.sh:
  echo "#!/bin/bash" >> $@
  echo "echo 'hello, from BASH'" >> $@

create: $(CODE)
  fission env create --name $(ENV) --image $(IMAGE) || echo "env '$(ENV):$(IMAGE)' already exists"
  fission function create --name $(FN) --env $(ENV) --code $<
  fission route create --function $(FN) --url /$(FN) --name $(FN) --method GET

delete:
  fission function list  | awk '{print $$1}' | tail -n +2 | grep -w '$(FN)' | xargs -n1 fission function delete --name
  fission route list | awk '{print $$1}' | tail -n +2 | grep -w '$(FN)' | xargs -n1 fission route delete --name
  fission env list | awk '{print $$1}' | tail -n +2 | grep -w '$(ENV)' | xargs -n1 fission env delete --name

test:
  fission function test --name $(FN)

get:
  curl -G http://<IP_ADDRESS>:8080/$(FN)

full-test: test get

But now I am working on getting a custom image running.  I have tried using the "container function" method, but that looks like it requires some kind of REST api.  I've also duplicated the binary-env image definition I see in Fission's source but I've had no luck,
# FROM golang:1.23.0-bookworm AS server-builder
FROM golang:1.16-alpine AS server-builder

ARG FISSION_SERVER_URL="https://raw.githubusercontent.com/fission/environments/master/binary/server.go"
ARG FISSION_SERVER_ENV_URL="https://raw.githubusercontent.com/fission/environments/master/binary/env.go"

WORKDIR /binary

RUN apk add curl

RUN curl -L $FISSION_SERVER_URL -o /binary/server.go
RUN curl -L $FISSION_SERVER_ENV_URL -o /binary/env.go

RUN go mod init github.com/fission/environments/binary
RUN go mod tidy

RUN go build -o server .

FROM alpine:3.14
# FROM python:3.12-alpine3.19
# FROM python:3.11-slim-bookworm

WORKDIR /mlapp

# RUN apt-get update
# RUN apt-get install -y --no-install-recommends coreutils binutils findutils grep
RUN apk add --no-cache coreutils binutils findutils grep

COPY --from=server-builder /binary/server /mlapp/server

EXPOSE 8888/tcp
ENTRYPOINT [ "./server" ]

Obviously, I am trying to get to a point where I have python in there with normal dependencies and control surfaces, and a normal entrypoint.  That entrypoint will be a CLI early, often, and potentially forever; it'll be an API only far downstream in the lifecycle of whatever we're building, strictly if necessary.
There is probably a better way, but I'd like to adopt this tool as a NO-OPS solution immediately.  So to get there now, I'd like to use the binary server (plan A) or the python env with a shim to the cli (plan B).  I am pretty certain I can get plan B basically working, except I'll have to create a custom container there somehow as well.
How do I properly construct a python container with the binary server in place for CLI interfacing?  Is that an example you could add?


Update myconfig

Thanks for notice!
No need to change that in my repo. You should change yourself as you wish.


Global gitignore

Plan to update the OS specific and editor specific gitignore from github global directory

[x] fetch! https://github.com/github/gitignore/tree/master/Global

Solved! b2c5f64


Idiots' guide

Hello, I'd love to get this working in HA and have the add-on installed and running. However, I'm not using (nor have used) MQTT before and am hoping that there's some sort of walk-through in how to set up the sensors.
Can anyone point me in the direction of something which will help me navigate this?
TIA

I have no good guide to point you to, but if you install version 0.3.0 (or newer) it will use auto discovery, which will setup the sensors automatically (i.e. you don't have to mess with MQTT).

I have no good guide to point you to, but if you install version 0.3.0 (or newer) it will use auto discovery, which will setup the sensors automatically (i.e. you don't have to mess with MQTT).
When that is done, a new device (MG [model] [vin]) will show upp under /config/devices/dashboard, that will contain all the sensors

My sincere apologies for having missed this before. I will try to get that working. Thank you
One other question: if I set this up, will it stop the iSmart app from working (I know it can only be connected from one mobile) or will this run in parallel?
Thank you once again

One other question: if I set this up, will it stop the iSmart app from working (I know it can only be connected from one mobile) or will this run in parallel?
Thank you once again
Surpringing myself I actually succeed to set this up.
I installed the  "Mosquitto broker" Add-On in HA, then the MQTT integration

Then I was logged out from MG iSmart app so it seems that the connection/user thing only can be logged in at one place :-(
IIt seems to only work from

I just want to THANK YOU for your great work! I migrated from OpenHab to Homeassistant - and one reason was the (easier) integration of my MG4. After hours of catching up to get to the status, where I have allready been in OH, one of the most satisfying integrations in HA - without any troubles -  was this one! GREAT WORK!! This takes my HA-App to the next level. WOW.

Hi all. I have been trying to set up this integration for a while, but am new to both HA and MQTT. I have the python version 0.5, but the auto discovery isn't working. This must be related to the fact that whenever i start the addon, it shuts down about 15 seconds later, but I'm struggling to be able to tell from the logs what's broken. I've got the mosquito broker intalled and tested it sucessfully.
Anyone know how to help?


Rocket Linux Support

As you told me yourself, Sven.. Unturned server works on lubix, but not rocket. Planning on a fix?

Yep true, but Unturned also doesn't work on linux x64, tested on Ubuntu 14.04, forcing steamcmd to download x86 & install rocket on that works tho!


Adding gzip codec

To use with ADAM, run
ADAM_OPTS="--conf spark.io.compression.codec=org.bdgenomics.adam.codec.GzipCompressionCodec" adam-submit ...

Can one of the admins verify this patch?

Jenkins, add to whitelist and test this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/668/Build result: FAILUREGitHub pull request #643 of commit 3cb058ec3ab882141bdfb2430a45a4098bb7aeda automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/643/merge^{commit} # timeout=10 > git branch -a --contains b930d144f58661a5348978241545e39ebedb343a # timeout=10 > git rev-parse remotes/origin/pr/643/merge^{commit} # timeout=10Checking out Revision b930d144f58661a5348978241545e39ebedb343a (origin/pr/643/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b930d144f58661a5348978241545e39ebedb343aFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@hannes-ucsc Thanks for pushing this! I'm going to close this and reopen against bdg-utils.


Move "no such module: VirtualSpatialIndex" code elsewhere

We currently show a useful warning (from #331) when the user tries to open a spatialite database without first loading the module:
https://github.com/simonw/datasette/blob/c692cd291111050483a32bea1ee08e994a0b781b/datasette/app.py#L547-L554
This code is part of .inspect() which is going away - see #462 - so I need to find somewhere else for it to live.

This is a little bit tricky. This SQL looks like it may detect Spatialite tables:
select * from sqlite_master where type = "table"
and sql like "%CREATE VIRTUAL TABLE%"
and sql like "%USING VirtualSpatialIndex%"

But where to put it? I think this should go in a new "checks" mechanism, where we run checks against every connected database on SQLite startup.

To build a unit test for this I'm going to have to ship a small spatialite.db binary database as part of the git repo.
This is because I need the tests to run even when the spatialite module is not available - but you cannot create a spatialite database without having access to that module.
I'll include a build script in the repo for constructing that database.


Fix mongodb5 links in README.md

@sabrina-yee @cameronbosnic Please merge this PR.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Naveen Bajjuri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Adds (unoptimized) functions to MerkleTrie.sol

Description
Helloooo. This PR adds two new (unoptimized) methods to MerkleTrie.sol, verifyExclusionProof and update. I managed to refactor verifyInclusionProof so most of the logic is shared between the three methods.
Unfortunately, the trie protocol is somewhat complex and, as a result, the code is too. I've also had to execute everything in an iterative manner because recursion tends to eat gas. Apologies in advance for the heavily nested conditionals :-/. I've added comments at the top level of each function and at various points within the most complicated functions.
Questions

Does anyone see any obvious optimizations we can make without significantly reducing code quality?

Metadata
Fixes

Fixes YAS-380, YAS-417, YAS-442

Contributing Agreement

[x] I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

Merging!


Added --color to runCommand

Thanks @Stefano1990! I have some thoughts about building commands and making the options configurable, but I agree that making --color a default is good for now.
I'll merge this and publish a new version later today.


Detect shift command

Hi
thanks for your library, as we have barcodes with both lower as uppercase, I just wanted to say: in the chunk[0] you can detect if it is a SHIFT press or not.
if(chunk[0] === 2 )
    key = "shift_" + chunk[2]
} else {
    key = chunk[2]
}

and by passing a HID map that differentiates between them it works :)

Glad it works for you!
The HID map as a config was to help with these kinds of issues.
Closing.


FZF breaks down when terminal column width more than 181 chars.

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[x] Linux
[ ] Mac OS X
[] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[ ] fish

I am using Cmder with bash configuration and I realized after ssh to Linux server (CentOS) that after invoking fzf and searching each line is sort of interlaced with empty line and after few key strokes the search breaks apart.
Comparing to other terminal utilities which worked fine I found that the issue is with setting terminal width which was originally 188 columns. After changing it to 181 or less (stty cols 181) it worked. Also changing this option in other terminals broke it apart.
So is there any hardcoded limit? Could it be fixed?
BTW I love this utility :)

Hi @mpes, could you let us know if this is still an issue?

Hi @LuRsT
unfortunately it is still an issue.
I was able to reproduce it just now.

So is there any hard-coded limit? Could it be fixed?

No, I don't have any problem running fzf on wider terminals over an ssh connection.

the issue is with setting terminal width

Do you mean that you manually set the width with stty cols command?


Plastic Simulation cone example is broken

We need to replace LinearizeCore Potential by .linearize_core in make_system

WIP in https://github.com/ContactEngineering/Adhesion/tree/bug/fix_adhesion_examples

It doesn't look like changing to .linearize_core in make_system solves the issue -

What was this suggested modification based on? Is there anything else that we can try? I can do the necessary changes and submit a PR.

Sorry repaired it here:
https://github.com/ContactEngineering/Adhesion/pull/69

Fixed


Require golang 1.18

go mod edit -go=1.18
go mod tidy
This was done on the main branch in #365.
ACM's tracking issue says this should be backported to 2.5 and 2.4.
Relates-to: stolostron/backlog#22428
Signed-off-by: Daniel Farrell<EMAIL_ADDRESS>

/cc @skitt @tpantelis

Are the 1.18 builders set up on the 2.4 and 2.5 branches for the Submariner addon? (In https://github.com/openshift/release.)

/approve


Generate public classes instead

Currently we annotate a public class and the backing to/from json classes are generated.
@JsonSerializable()
class Task {
  final String id;
  final String name;
  final String avatar;
  final String createdAt;

  Task(this.id, this.name, this.avatar, this.createdAt);

  factory Task.fromJson(Map<String, dynamic> json) => _$TaskFromJson(json);
  Map<String, dynamic> toJson() => _$TaskToJson(this);
}

Is there any reason why we cannot annotate a private class and have json_serializable generate the public class? This private class would generate the above public class. The benefit would be less boilerplate. The private class would implemented by the public class.
 Going through having to manually type a toJson and fromJson method for all of my redux actions is really annoying when the generator could just as easily be generating them for me!
If there was an extra parameter in the annotation like generatePublicMethods:bool that'd be awesome

We likely won't do any work here – and wait for partial class support https://github.com/dart-lang/language/issues/252


Feedback for: engine/admin/puppet.md

Hello,
I am currently seeking statements about extra parameters and redirection of ports.
Here is my puppet code:
node default {
include docker
docker::image { 'fusengine/owncloud':
ensure => 'absent',
}
docker::run { 'owncloud':
image   => 'fusengine/owncloud',
ports   => ['8080:80'],
}
}
The problem I am facing is that on the puppet node, an ipv6 socket is opened by default.
tcp6       0      0 :::8080                 :::*                    LISTEN
So the consequence of this issue is that the docker owncloud cannot be reached from the outside.
So if you can add documentation explaining this usecase it will be very usefull.
Regards,
File: engine/admin/puppet.md

I don't think we can troubleshoot specific solution problems for you, sorry. In general the bug isn't making intuitive sense to me, since the port is open it would follow that its reachable.


saved_tensors_list might contain Nones

saved_tensors is implemented to store only tensors and nothing else is allowed by torch.autograd.Function's ctx.save_for_backward method.

Originally posted by @IvanYashchuk in https://github.com/Lightning-AI/lightning-thunder/pull/607#discussion_r1643082936
As per title. https://github.com/Lightning-AI/lightning-thunder/pull/616 shows that this assumption is not true, and fails in our notebooks.

I was under the impression that ctx.save_for_backward doesn't allow non-Tensor objects but it seems it does allow None:
import torch

class Test(torch.autograd.Function):
    @staticmethod
    def forward(ctx, x):
        ctx.save_for_backward(None, x, None)
        return x

    @staticmethod
    def backward(ctx, g):
        print(ctx.saved_tensors)
        return g

a = torch.Tensor([1.0]).requires_grad_(True)
aa = Test.apply(a)
aa.backward(aa) # prints (None, tensor([1.], requires_grad=True), None)

However, if we put a float then we'd hit
TypeError: save_for_backward can only save variables, but argument 2 is of type float

Thank you for checking this with #616! I guess we have a discrepancy between the trace-time types and runtime types because we try to generate a trace that puts only TensorProxies into "saved tensors" list/tuple:
https://github.com/Lightning-AI/lightning-thunder/blob/0dc9807c00bae6076c15a5fdc32a2653fc00e225/thunder/core/transforms.py#L3471-L3484
We need to accept that "saved_tensors" is actually "saved_tensors_and_nones" and whatever code that uses saved_tensors needs to check for Nones.


Feature: Supplier part pack size

Adds the concept of "pack size" for the supplier part

e.g. buy a single "bag" which contains 10 parts
e.g. buy a single "tube" which contains 30mL vs a larger tube which contains 100mL

Closes https://github.com/inventree/InvenTree/issues/1435
TODO

[x] Add documentation for new feature - https://github.com/inventree/inventree-docs/issues/365
[x] Add extra unit testing for 'on_order' quantity
[x] Add unit testing for receiving items with pack_size != 1
[x] Update demo dataset with supplier parts which have larger pack size - https://github.com/inventree/demo-dataset/pull/32
[x] Update queryset annotation for on_order quantity (must include calculation of pack_size)
[x] Update 'on_order' method for Part model
[x] Update "on order" display for particular part page
[x] Display pack size when adding lines to order via normal "Add Line Item" form
[x] Display pack size when adding lines to order via "auto calculate" form
[x] Ensure "units" are displayed appropriately for part quantity values in HTML views and forms

@eeintech @matmair do you think that "pack_size" is the right nomenclature here?

@eeintech @matmair do you think that "pack_size" is the right nomenclature here?

I think package_unit would be better.

Looks good. Am I right that the new field is only as a data point but without buisne3ss logic for splitting?

There will have to be some business logic added. Thinking about it, it becomes quite complex but should be attainable. For example, (and the use case I am trying to implement specifically for) say you have a part "thermal adhesive" which your units are "cc". You can buy it from one supplier in a tube of 30cc, and another in a tub of 500cc. The supplierpart quantity is "1" in each case, but the amount of "part" you are getting is markedly different.
So there needs to be logic in place to convert the incoming stock quantity from "supplier part units" to "part units". And then update every place where the "on order" quantity is reported to take this new pack quantity into account...

@SchrodingersGat sounds a lot like https://github.com/inventree/InvenTree/issues/1435

This is nice -- can you add this as a context variable to reports?  Would be nice to show total quantity and total packs/sets on purchase orders.

@derekwolfson the PR is merged half a year. Please open new feature requests for new requests.


.Site.RSSLink is a dead link if defaultContentLanguageInSubdir = true

The title basically describes the problem well enough. When you have RSS enabled and defaultContentLanguageInSubdir = true, then the index.xml files are placed in /en/index.xml, /eo/index.xml, etc. But .Site.RSSLink refers to {{ .Site.BaseURL }}/index.xml, which does not exist.

Will be fixed in #4427

Ah, thank you very much for your swift response!


Specialization for Map(::Type) etc.

Codecov Report

Merging #56 into master will decrease coverage by 1.98%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   86.96%   84.97%   -1.99%
==========================================
  Files          15       15
  Lines         997      985      -12
==========================================
- Hits          867      837      -30
- Misses        130      148      +18

Impacted Files
Coverage Δ

src/library.jl
92.46% <0%> (-0.49%)
:arrow_down:

src/reduce.jl
67.85% <0%> (-27.06%)
:arrow_down:

src/simd.jl
75% <0%> (-9.38%)
:arrow_down:

src/processes.jl
91.11% <0%> (-1.49%)
:arrow_down:

src/core.jl
68.24% <0%> (-0.15%)
:arrow_down:

src/show.jl
94.87% <0%> (-0.05%)
:arrow_down:

src/comprehensions.jl
90% <0%> (+13.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd6463...7a41573. Read the comment docs.


fix: add more workflow fixes

Summary by CodeRabbit

New Features

Enhanced automation for updating the Unity package URL with version checks.
Introduced error handling for critical operations to ensure smooth workflow execution.

Bug Fixes

Improved logic for detecting changes between the latest and current version.

Chores

Updated workflow to include new steps for committing changes and creating pull requests.

:tada: This PR is included in version 1.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TraversedJSONPathBuilder.$castTo and .$notNull should return TraversedJSONPathBuilder instead of JSONPathBuilder?

Hi,
TraversedJSONPathBuilder.as typechecks correctly:
eb
  .ref("healthScaleStepJson.healthScaleStepJson", "->>")
  .key("id")
  .as("formComponentId"),

TraversedJSONPathBuilder.$castTo typechecks correctly:
eb
  .ref("healthScaleStepJson.healthScaleStepJson", "->>")
  .key("id")
  .$castTo<FormComponentId>()

But when .$castTo and .as is combined it's a type error
eb
  .ref("healthScaleStepJson.healthScaleStepJson", "->>")
  .key("id")
  .$castTo<FormComponentId>()
  .as("formComponentId"), // <--- Property 'as' does not exist on type 'JSONPathBuilder

My guess is that this could be fixed if TraversedJSONPathBuilder.$castTo (and .$notNull which is very similar) returned TraversedJSONPathBuilder instead of JSONPathBuilder.

Hey 👋
Yeah, your assumption seems correct.


Add Aishwarya Pradhan to Contributors list

learned to make a contribution to open source projects.
#hacktoberfest

@aishwaryapradhan, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

The major thing I learned from this journey is that we always see a project as a single huge chunk and don't know how to start while we just have to work at parts of it. Also, fear of messing things up stops us. After this pull request, I am feeling more confident about this whole process and the best part is that it is fun contributing to projects. The exciting part is when we see that our pull request is merged that's like getting a girlfriend.
Thanks for creating such a project.

@aishwaryapradhan, I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

Sure, Would love to. I am a python coder, Please help me find a project to contribute. Just tell me what things I should see in it and I am ON. Joined the Slack community too.


Add Serum Market ID + Some socials

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I tried to not push commit where I replace things, does it help for automerge?
CC @siong1987 @kobak @oboxodo @vladdu

Hey @leoluk do you have news about new automerging system?


remix grunge stack aws

Have you experienced this bug with the latest version of the template?
npx create-remix@latest --template remix-run/grunge-stack
Steps to Reproduce
HP-ProBook-450-G3:~$ npx create-remix@latest --template remix-run/grunge-stack
(node:24084) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)
remix   v2.4.0 💿 Let's build a better website...
dir   Where should we create your new project?
./remixawstest
Expected Behavior
Setup finishes without errors. Go ahead..
Actual Behavior
  ◼  Template: Using remix-run/grunge-stack...
  ✔  Template copied

git   Initialize a new git repository?
Yes
deps   Install dependencies with npm?
Yes
init   This template has a remix.init script. Do you want to run it?
Yes
██████  Dependencies installing with npm...
  ▲  Oh no! Failed to install dependencies.

I have a pull request submitted that will fix this but meanwhile you can update your package.json to use vite: ^5.0.0 instead of ^4.5.0

yes i edited the vite verion to 5.0.0 before running npm install and it worked fine with all test passed. This have fixed all github action workflow error and failed to deployment reason too. I am getting another one after deploying in aws that is ... INTERNAL SERVER ERROR ..

I have a pull request submitted that will fix this but meanwhile you can update your package.json to use vite: ^5.0.0 instead of ^4.5.0

if any help about internal server error after deploying in aws, on hitting the url got from deployment work flow.

I evetually deployed grunge stack in aws. I constantly got  "Internal server error" .
The steps are:
Before running the :
npx arc env --add --env staging ARC_APP_SECRET $(openssl rand -hex 32)
npx arc env --add --env staging SESSION_SECRET $(openssl rand -hex 32)
npx arc env --add --env production ARC_APP_SECRET $(openssl rand -hex 32)
npx arc env --add --env production SESSION_SECRET $(openssl rand -hex 32)
Did this:
make sure your secret variaabls (AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY) are same both in your CLI ["aws configure" command will ask for those keys and you have to get it from aws IAM user first.. ] , github and aws then run the 4 line command and commit it to github. Deploy.yml will work and make cloud formation. I got the link in deploy workflow https://t1hu92wtqh.execute-api.us-west-2.amazonaws.com/


Install failure when not building docs

I tried building within a Homebrew build context and it failed for being unable to find the manual PDF:
==> cmake -S . -B build -DBUILD_DOCS=NO<EMAIL_ADDRESS>==> cmake --build build
==> cmake --install build
...
-- Install configuration: "Release"
CMake Error at build/doc/cmake_install.cmake:41 (file):
  file INSTALL cannot find
  "/tmp/ngscopeclient-20240210-40013-tg2ilb/build/doc/ngscopeclient-manual.pdf":
  No such file or directory.
Call Stack (most recent call first):
  build/cmake_install.cmake:42 (include)

As expected with -DBUILD_DOCS=NO, the build/doc directory is empty.
I suspect how the target is disabled in CMakeLists.txt:
https://github.com/ngscopeclient/scopehal-apps/blob/6d432152e6e75f38fb58343ac35c4b4f5c3129ad/CMakeLists.txt#L192-L196
https://github.com/ngscopeclient/scopehal-docs/blob/4ecb75522297410495cf0c0204bedcdf956e2c73/CMakeLists.txt#L83-L84
The doc/CMakeLists.txt is always included, and it always mandates the installation of the PDF file. Either this install should be OPTIONAL or the doc/CMakeLists.txt should be conditionally included as BUILD_TESTING is.

Fixed in https://github.com/ngscopeclient/scopehal-docs/pull/82.


Unsorted includes

According to the LLVM/Clang style guide, the #includes should be sorted alphabetically. Currently, this is not always the case, for example here.

Fixed: 2b81c40828613d70fd177dc359c202c654559305


Some clarification in the -h documentation.

updated documentation for --config_file
updated documentation for --seed

Hopefully solving #352
@qubixes can you review?
I needed >1 line for the updates, not sure if that's allowed and whether my use of """ is correct.

You can also use single quotes on multiple lines; it should merge them into a single string (since they are enclosed).

Ik bedoelde eigenlijk dit (voor voorbeelden):
https://github.com/qubixes/asreview-pro/blob/master/asreviewcontrib/pro/entrypoint.py

Thanks!!


undefined reference to impala_udf FunctionContext GetConstantArg

build/libudfsample.so：对‘impala_udf::FunctionContext::GetConstantArg(int) const’未定义的引用

it is OK now.
OS: centos 6.2 with Virtualbox CDH4.

Certainly, there is an issue.
I downloaded Cloudera Quickstart VM for 5.3.0 (Centos), there is impala-udf-devel package installed. I only installed cmake and got the same problem:
Linking CXX executable build/udf-sample-test
build/libudfsample.so: undefined reference to `impala_udf::FunctionContext::GetConstantArg(int) const'
collect2: ld returned 1 exit status
make[2]: *** [build/udf-sample-test] Error 1
make[1]: *** [CMakeFiles/udf-sample-test.dir/all] Error 2
make: *** [all] Error 2

I am seeing this as well on the latest CDH 5.3 VM


Prometheus metrics

Closes #93

Coverage decreased (-0.5%) to 91.751% when pulling db51a6123879c781f8fcec097fbe71d977245d27 on feature/prometheus into cfa763cf64bd9b4ea784404a5e9fc85c5f0d5b1e on main.


added info about new sonatype repository server url

added the new server url warning near the config parameter and also added a FAQ question regarding the 403: Forbidden, which on of the cause might be a wrong server URL.

Thanks!


[1.10.2] Slurry Split Between Crystallizers

With the way that ore quintupling currently works, chemical crystallizers are extremely slow compared to all of the other machines ahead of it in the ore processing chain, necessitating multiple crystallizers per chain. However, what ends up happening is that a batch of clean slurry (2000mb if I remember correctly) will get split between two or more crystallizers, preventing them from processing anything and freezing up the whole chain until you manually remove the slurry using a dropper. Perhaps there could be a way to make crystallizers not do this?

You'd really need some sort of liquid router that can move specific amounts of liquid between the machines. I'm not aware off the top of my head of anything that can do that. You would need to figure out how much clean slurry is needed to make a single crystal and use that value as a round-robin distro between all connected crystallizers.
I've often wanted to do the same thing for those last three machines in the chain but the logistics proved problematic. Could probably do it in 1.7.10 with AE2 and Extra Cells but I'd have to test. I'm not sure you can feed slurry into liquid storage or not... which would be another issue. Refined Storage [AE2-clone] in 1.10 has fluid storage now [I think?] but that mod is buggy as hell.
TBH I just usually 4x all the general stuff and run batches of 5x stuff if I really need specific things [usually iron if we don't have digi miner enabled].


cp -a flag is not portable

at least it's not on OpenBSD. probably somewhere else as well.

I'm going to close this, subsumed by https://codereview.chromium.org/1483473002/.
Until it's fixed in upstream gyp, see https://github.com/nodejs/node-gyp/issues/571#issuecomment-149000420 for a workaround.


[rust question] How do I load a track?

Hi,
I'm playing a little bit with rust at the moment.
Here I'm trying to load the name of a track, given some track id:
fn main() {
    let mut core = Core::new().unwrap();
    let handle = core.handle();
    let session_config = SessionConfig::default();
    let player_config = PlayerConfig::default();

    let args : Vec<_> = env::args().collect();
    if args.len() != 4 {
        println!("Usage: {} USERNAME PASSWORD TRACK", args[0]);
    }
    let username = args[1].to_owned();
    let password = args[2].to_owned();
    let credentials = Credentials::with_password(username, password);

    let track = SpotifyId::from_base62(&args[3]);

    println!("Connecting ..");
    let session = core.run(Session::connect(session_config, credentials, None, handle)).unwrap();
    println!("session ok");

    let track = Track::get(&session, track).wait().unwrap();
    println!("{}", track.name);

    println!("Done");
}

However, when I run this code, Track::get() blocks infinitely.
Is there some kind of event loop I have to run before I can use Track::get?

Most of librespot's API returns futures. Whenever you get one of these you should run it through core.run rather than calling wait, just like you do for Session::connect.
For example :
let track = core.run(Track::get(&session, track)).unwrap();
println!("{}", track.name);

Note that this will block the current thread until the track information has been retrieved.
If you want to perform other work you can combine the returned future using the future-rs library.
See https://tokio.rs/docs/getting-started/futures/#adding-a-timeout for an example of a timeout associated with a future.

Thank you very much :)

How does "player.rs" run this future?
Where is the thread spawned that completes Track::get(&session, track).wait()?
Is this happening inside the internal.run() loop?

I started explaining the architecture, but this ended up quite lengthy, sorry.
Here's the TLDR of futures/threads in librespot.

In order to make any progress you must have a thread running core.run somewhere.
You can use core.run to run a future you got from librespot or anything else, including an empty future.
Most futures returned by librespot (probably all other than Session::connect) should be safe to .wait(), as long as the core is running on another thread.
The AudioFile API is synchronous (it uses .wait() internally). It must therefore only be used if another thread is running the core.

Session::connect returns a future which will asynchronously set up the connection (AP resolve, authentication). This future must be run through Core::run.
While completing that future, Session::connect uses Session::create to create the  Session object (which is the result of the future) and create the "packet handling" future. This future is registered with tokio to run in the background (using handle.spawn). Note that it does not return any useful value (It's type is BoxFuture<(), io::Error>, ie return ())). It actually doesn't return as long as the connection is open.
However note that (despite its name), spawn only registered the packet handling future with tokio's event loop (I use core and event loop interchangeably). This means that it will not run if the core is not running, and packets will not be sent nor received. That means that after core.run(Session::connect(...)) returns the Session object you should run the core with something else in order to keep processing packets. The packet handling future will be scheduled by the event loop when it has work to do.
At this point, when you make a request on a "low level" API (like AudioKeyManager, MercuryManager or ChannelManager), it sends the corresponding packets to an in process channel (these have nothing to do with the ChannelManager, which deals with Spotify channels. The naming is confusing sorry), and the packet handling future will forward them to the socket  (that's the Session::send_packet function). They also create a channel specific to that request, store the tx side somewhere and return the receiver end. If you want to look into it AudioKeyManager is definitely the simplest one. The others have a lot more parsing and state involved.
When a response comes back from Spotify, the packet handling future will pick it up and call the appropriate function (that's the Session::dispatch function). That function will parse the response, find the channel associated with that request and send the response on there.
"Higher level" APIs like metadata and keymaster are just wrappers around these which prepare the request and parse the response.
Asynchronous requests can be made at any time, from any thread, even if the core isn't running. It will just enqueue packets onto the shared packet sending channel and return a future back. At this point there are three ways to receive data from the channel (future) that the request returned.

You can use core.run to execute the future directly (eg core.run(Track::get(...))). This will block the thread until you get a response.
You can run it as a background future, using handle.spawn / Session::spawn. The result will be lost, but you can use .map or .and_then (or some other combinators) to add some processing to the future. Just like packet processing, futures which are "spawned" only make process if you run core.run.
You can call .wait on it. This only works if another thread is running the core.

Because the OGG decoder expects reads from files to be synchronous, the AudioFile::read function uses .wait() to block on data. The entire player is therefore run on a separate process, and uses .wait() in a couple of other places. This is fine because the main thread is running the core.
When doing the second or third option you may not have anything useful to give to core.run. In this case you can make an empty future which never completes and pass it. That way the core will run forever.
See for example python-librespot. It creates a thread just for the event loop but runs an empty future on it. When some python code makes a request which returns a future, that future is combined using then such that the result is communicated back to Python when the result is available, and is spawned to run in the background


Marking text with unicodes

I'm using markjs in my project. This is basically used to highlight text. It works fine except for some text with unicode characters in it. For example text with characters "\xA0"
Here is the jsfiddle link for testing https://jsfiddle.net/trupti11/4zh3w0a8/2/
Here is the code sample
$(function() {
  alert($('.txtHolder').text())
//this shows the extra characters in the text '\xA0'
  alert($('.txtHolder').text().toSource());
//this does not work
   $('.txtHolder1').mark($('.txtHolder1').text());
//this works
   $('.txtHolder2').mark($('.txtHolder2').text());
});

Environment

Browser FireFox 51
mark.js

Hi @pravid!
What are you trying to accomplish?
The txtHolder1 class doesn't exist. And \xA0 is unicode for a non-breaking whitespace. This is ignored when you set the separateWordSearch option to true (default setting) because each key word is targeted separately.

@Mottie Many thanks for having a look at this! @pravid I'm sorry, but I'm confused too, what is your question or problem?

@pravid I'm closing this issue since you haven't replied yet. Feel free to reopen if you can clarify your question or problem.

Sorry for the late reply
And sorry for the typo. I have updated the fiddle. https://jsfiddle.net/4zh3w0a8/4/
I can not keep 'separateWordSearch' option to true since I need to mark the whole sentence and the the individual words.

@pravid

I can not keep 'separateWordSearch' option to true since I need to mark the whole sentence and the the individual words.

Ok, so you disable separateWordSearch. But, what's your question or problem?

Okay, sorry, I thought looking at fiddle code my question will be clear to you. But looks like it doesn't.
My question is,
As you can see the fiddle,
The normal text,

"This text gets marked."

gets highlighted properly.
But the text,

"Technical Editor: Editor One English Editor: Editor Two This doesn't get marked."

it not getting highlighted completely, since there is this unicode character "\xA0",
Is there any workaround to skip such kind of unicode characters?
I hope I'm clear now. :)

@pravid I've tested with your recent fiddle. You've specified "lect" instead of the default "mark" as element. This isn't valid! If you change it to "mark" the entire text gets highlighted, see the updated fiddle.
If this still didn't solve your problem, please let me know why can't I find any "\xA0" in the fiddle?

Is there anything specific to tag 'mark'? I need to wrap highlighted text within this custom 'lect' tag.
This anyways works for me in normal texts with 'lect' tag.
I will try to create more detail fiddle to test this.
Thanks!

Hello,
I have created another fiddle
https://jsfiddle.net/trupti11/4zh3w0a8/11/
Can you please check why it is not working for 'textHolder1' text?

I've noticed that if you reverse the order that the markText function is called, it works (demo)
$(function() {
  markText($('.txtHolder1').text());
  markText($('.txtHolder2').text());
});

@pravid You've now shown us your third JSFiddle, still with invalid HTML and invalid mark.js options. "lect" and "sen" are no valid HTML elements! I don't like to debug your application to get something that can be used for tests.
Anyway, it didn't work because you're calling .mark() two times, with different strings, but with space at the end and the beginning in each of them. So, what happens is that if you mark the first sentence (that has multiple spaces at the end), it also wraps all blanks until .txtHolder2. And if you then try to mark the second keyword which also requires blanks at the beginning, then there are no blanks that can be wrapped, thus there is no match for the second keyword. If you pass blanks to mark.js they will be merged, but it's still necessary to have at least one blank otherwise no match is found (introduced in #97). To solve this, just trim the keyword before you pass it along to mark.js, using string.trim().
This is you working fiddle.
In future, please provide one simple fiddle with valid HTML and a clear question. Thank you!


No values with 75/10 (updated config.h)

I have a 75/10 that is apparently running a newer firmware and is sending 18 variables now. I was able to pull the data down on my Mac using a FTDI cable. Pretty sure my voltage divider is working (verified with voltmeter). I updated the config.h to include the changes, but while I get keywords printed out on the serial monitor, there are no values being shown.
Ideas?
output from FTDI
PID     0xA054 FW      159 SER#    HQ21052GGUP V       13130 I       0 VPV     10 PPV     0 CS      0 MPPT    0 OR      0x00000001 ERR     0 LOAD    ON IL      0 H19     0 H20     0 H21     0 H22     0 H23     0 HSDS    0 Checksum        G
updated config.h
`#ifdef MPPT_75_10
const byte buffsize = 32;
const byte value_bytes = 33;
const byte label_bytes = 9;
const byte num_keywords = 20;
char keywords[num_keywords][label_bytes] = {
"PID",
"FW",
"SER#",
"V",
"I",
"VPV",
"PPV",
"CS",
"MPPT",
"OR",
"ERR",
"LOAD",
"IL",
"H19",
"H20",
"H21",
"H22",
"H23",
"HSDS",
"Checksum"
};
#define PID 0
#define FW 1
#define SER 2 // Offically SER# but # does not play that well as macro
#define V 3     // ScV
#define I 4     // ScI
#define VPV 5   // PVV
#define PPV 6   // PVI = PVV / VPV
#define CS 7    // ScS
#define MPPT 8  // MPPT
#define OR 9    // OR
#define ERR 10   // ScERR
#define LOAD 11  // SLs
#define IL 12   // SLI
#define H19 13
#define H20 14
#define H21 15
#define H22 16
#define H23 17
#define HSDS 18
#define CHECKSUM 19
#endif`

Turns out that Wemos D1 Mini doesn't like serial input. Switched out to a NodeMCU 0.9 (or an ESP32) and works like a charm.


Tutorials/Examples

I really appreciate all the work you're doing on this. I'm currently deeply in neuroimaging research and trying to add EEG to my repertoire for my current lab. This package is looking very promising and I'm hoping to start using it in the coming months, but I personally would need some more tutorials and examples. Are there any currently available tutorials or notebooks available?

Good idea. Should do as part of #42

@rob-luke Could you make a workflow or something based on your original logic of the package design, so that we can test  the functions designed in the package?

@rob-luke Could you make a workflow or something based on your original logic of the package design, so that we can test the functions designed in the package?

Thats clearly why this issue is here. Please be patient, you are aware that I am actively working towards this goal. I have made over 1000s of lines of code changes in the last weeks towards this goal. You can view the order in which things are being addressed at https://github.com/rob-luke/Neuroimaging.jl/projects/1 and you will see this issue is close to the top of the list in the backlog.
There is an efficient order in which things must be done. Before I could write an example I first needed to update the CIs #38, update the code to Julia 1 #36, then get the documentation building #80, add the ability to fetch data #99, get real data working in the examples  #93. Now I need to add a real dataset to the downloader #100, then finally I can address this.
You can see I was aware of this issue because I commented on it 3 days ago and its in the project timeline.

I have created an example at https://rob-luke.github.io/Neuroimaging.jl/dev/assr/examples/
However, I will not close this issue as I would like to add more examples to demonstrate how to achieve different types of analysis with this package. So stay tuned for more!


Authorization code  - Invalid Authentification

Hi guys, i've been truggling with this issue for few days now and really appreciate your help.
Once I get the authorization code from https://magic-mirror-avs.github.io/Alexa-Web-Helper/authresponse?code=xxxxxxxxxxx
I get this code as follow: At the bottom you can see trying tGestting response from Amazon in LOOP
I don't know what I'm doing wrong:
Welcome to the Config Helper tool!
This tool will help you get the Refresh Token needed to run MMM-awesome-alexa.
It will optionally generate your config for you, if you wish. If not, you can still create it manually after.
Go to https://developer.amazon.com/alexa/console/avs/products to get the details.
? Enter your Client ID from Alexa Voice Service (AVS): xxxxxxxxxxxxxxxxxxxxxxxxxxx
? Enter your Client Secret from Alexa Voice Service (AVS): xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
? Enter your Product ID from Alexa Voice Service (AVS): xxxxx
? Enter your Redirect URI (allowed return URL) from Alexa Voice Service (AVS): https://magic-mirror-a
vs.github.io/Alexa-Web-Helper/authresponse
Hooray! Link is generated. Part 1 is done. Please go on the link below.
Please be aware that at the end, THERE WILL BE AN ERROR! This is normal.
https://www.amazon.com/ap/oa?client_id=amzn1.application-oReplacingMyAuthCodeWithThis&scope=alexa:all&scope_data={"alexa:all":{"productID":"M1","productInstanceAttributes":{"deviceSerialNumber":123}}}&response_type=code&redirect_uri=https://magic-mirror-avs.github.io/Alexa-Web-Helper/authresponse
^^^ Copy and paste the above in your Browser ^^^, follow the instructions.
The authorization code you want is in the address bar in the final screen: https://imgur.com/a/6DbYlKD
? Enter your Authorization code (from previous step): xxxxxxxxxxxx (I get this code from auto response URL)
â¡ Getting response from Amazon...(node:11412) UnhandledPromiseRejectionWarning: StatusCodeError: 400 - {"error":"invalid_grant","error_description":"The request has an invalid grant parameter : code"}
at new StatusCodeError (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request-promise-core/lib/errors.js:32:15)
at Request.plumbing.callback (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request-promise-core/lib/plumbing.js:104:33)
at Request.RP$callback [as _callback] (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request-promise-core/lib/plumbing.js:46:31)
at Request.self.callback (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request/request.js:186:22)
at Request.emit (events.js:198:13)
at Request.<anonymous> (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request/request.js:1081:10)
at Request.emit (events.js:198:13)
at IncomingMessage.<anonymous> (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/request/request.js:1001:12)
at Object.onceWrapper (events.js:286:20)
at IncomingMessage.emit (events.js:203:15)
at endReadableNT (_stream_readable.js:1145:12)
at process._tickCallback (internal/process/next_tick.js:63:19)

(node:11412) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:11412) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
âGetting response from Amazon...^C

I’d recommend using Assistant Mk2. I had the same issue and couldn’t get it resolved no matter what I did
Sent with GitHawk

Did you add  https://magic-mirror-avs.github.io/Alexa-Web-Helper/authresponse to the AVS allowed return url on Amazon Developer site?

Hello, Same issue for me, what I have to fill on URI and return URL?
Thanks for your help
Philippe


Already defined null (Suggestion)

I think this could be removed
https://github.com/aspnet/EntityFrameworkCore/blob/dev/src/EFCore/DbContext.cs#L544

@ralmsdeveloper Send a PR? 😄

Yes I'll do it!

@ralmsdeveloper Thanks for including in that PR. We will close this once that PR is merged.


Allow to override default weight of HTML elements in config

I would like the possibility to set custom weight values for elements. Is it possible to add something like this in config instead of using the data-pagefind-weight attribute.
Maybe something like :
autoWeights:
  h1: 10
  h2: 9
  p: 1
  ...

Good idea! I'm overdue to rework the configuration internally to allow richer config files (currently it unifies the config file and the CLI arguments, which is blocking complex config structures).
I recently landed a similar config pattern in Flatlake, so once I bring that code back over to Pagefind I can address this (and features like multiple globs) 🙂


Added ccTLDs for each country, fixed some ISO 3361 Short Names, and included some countries with flags not originally listed

Awesome updates, thank you!


Problem flagging: how can we identify excessive amounts of scheduling?

Ideas for a heuristic Bubbleprof can use to decide whether to alert the user that they might have a problem with too much scheduling.
Is scheduling:everything else ratio enough or do we need to look at what is being scheduled?
If not, what ratio(s) suggest a problem?

The key problem is not scheduling ratio but too much scheduling of purely synchronous tasks. "Fake asynchronous"


CM-158: WIP: E2E test cases

E2E tests related

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/cc @arkadeepsen @thejasn

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test alpha-e2e-operator

/test all

/retest

/lgtm

/hold
for e2e tests to pass

/cc @xingxingxia
for qe-approved label
self adding docs-approved, px-approved since changes in these PR are e2e tests functionality for which have already been added in former releases, doc is also covered.
/label docs-approved
/label px-approved

/test e2e-operator

/retest-required

/label tide/merge-method-squash

/remove-label tide/merge-method-squash

/lgtm

/remove-hold


Arnold Denoiser Noice issues

Having an issue installing 7.0
# ERROR : 2229 - Traceback (most recent call last):
#   File "<Script Block 2>", line 41, in XSILoadPlugin
#     Application.LoadPlugin(XSIUtils.BuildPath(in_reg.OriginPath, 'ArnoldTools.js'))
#   File "<COMObject Application>", line 2, in LoadPlugin
# COM Error: Invalid argument.  UI Items should be specified as a 1D array of String/Value pairs. - [line 40 in C:\Users\xxx\Autodesk\Softimage_2015_R2-SP2\Addons\SItoA\Application\Plugins\ArnoldDenoiser.py]

The denoiser doesn't load and I cannot seem to be able to select another denoiser.

So you get this issue when you install SItoA?
Have you followed the update guide: https://docs.arnoldrenderer.com/display/A5SItoAUG/Updating+SItoA

Thanks @JenusL , that solved it, I had to remove the preference file as well and that solved the issue.
One other question, I cannot seem to find any of the new imagers for denoising (oidn, optix, or even the tonemap ones) How can I add those? The menu item DLL shaders doesn't include them.
Thanks again

@IRONIC3D Imagers are added as a Lens Shader to the Camera or Pass. First connect the node named imager and then plug any imager_* in to that.
If you add it to the Pass you also need to enable Lens Shaders on the Pass. (default is to only use Camera Lens Shaders).

Thanks @JenusL , that solved the issue. Appreciate your help.

No problem.
@sjannuz Could you close this ticket please?


Web UI Help Leads to Broken Link at https://argoproj.io/

What did you do? (how to reproduce)
When clicking the link Argo Project under documentation it sends you to a broken link.

What did you see? (include logs and screenshots as appropriate)

What did you expect?
To be taken to the online documentation, most likely here https://applatix.com/open-source/argo/docs.

Thank you for catching it @bobhenkel !

This is argo v1, in argo v2 this issue is fixed.

Fixed

This is broken in master and tags v2.1.0-alpha1, v2.2.0.  http://argoproj.io/ does not appear to be active and should probably link to the README at the deeper path https://argoproj.github.io/docs/argo/readme.html.


Bf/zenko 314 max keys zero

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.