fix(extra): fix lost ensured_installed issue after release

I found an issue after the 12.5.0 release where lists were not being merged in the type(opts.ensure_installed) == “table” condition.

Are you sure it's not something on your end? Because I tried with default LazyVim starter template and tested Python and clangd Extras and both Mason and nvim-treesitter ensure_installed got installed correctly.

@dpetka2001
You're right, in my personal treesitter parser I explicitly added it to ensured_install and it didn't work.
I'll close this PR, thanks.


Deposit pages and reports missing from web client

Deposit pages and reports are available in Windows Client, bur are missing from web client. I'm using image version:
bcinsider.azurecr.io/bcsandbox-master:13.0.23638.0-ca

Windows Client:

Web Client:

I tried to add UsageCategory and Application Area from c/side for Pages but that also didn't fix the issue.

We were missing the updated UsageCategory property in the NA version of the codebase. This has been fixed since, could you please check on the latest docker image.


fuzz: limits the number of transactions

as Suricata does
Follow up on #423 to close https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=69412&q=label%3AProj-libhtp

An alternative fix would be that htp_config_create sets max_tx to a default limit of 512 or so

Information:
ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
ERROR: QA failed on SURI_TLPR1_suri_time.

field
baseline
test
%

SURI_TLPW2_autofp_stats_chk

.uptime
137
146
106.57%

SURI_TLPR1_stats_chk

.uptime
642
698
108.72%

Pipeline 20981

Information: QA ran without warnings.
Pipeline 20989

@victorjulien when will you be merging this ?

Merged in #428, thanks!


Encrypt sensitive data in the event table

I rule and have completed some work on Case Manager that's ready for review!
This PR encrypts sensitive event data at-rest.
This pull request makes the following changes:

Encrypts sensitive event columns
Adds post-deploy rake task to encrypt existing event data

run rails event:encrypt_sensitive_columns after you deploy this branch
if you run a select query on the events table in production, you should see both cm_name and patient_name are encrypted

Removes note encryption task that has already been run in production (this is just some clean up)

(If there are changes to the views, please include a screenshot so we know what to look for!)
It relates to the following issue #s:

Bumps #413

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

Encrypting number fields would require some non-trivial custom logic, so we've updated the requirements to encrypt the sensitive string fields on the Event model


add Text Speech

add text speech button

Thanks for completing the challenge! Fill out this form so we can send you the swag! https://aka.ms/cog-svcs-swag


Support Kubernetes

This relies on several unreleased changes to ondemand.  The changes to support staged_root inside the submit template. To make things work like HPC I made memory request be 4GB * number of cores, but adding a field just for Kubernetes to select memory can be done too.

Also would need adjustments to mount GPFS, which is just additional mount definitions. Is there any way inside the submit template to know if we are running on dev or test or production OnDemand? Because dev Kubernetes doesn't have GPFS mounted so would need a way to not mount GPFS on dev or just never use this app in dev environment for Kubernetes.

Pushed a commit so that the Owens Kubernetes node selection will have Owens CUDA rather than previous which just allowed Kubernetes to use CUDA where it was present on both Owens and Pitzer.  This pattern will be especially necessary for the conversion of RStudio server app.

I know this is on my plate to work out, I just need to carve out time to do so. It's just got to be well tested as it'll affect classrooms (whether they use k8s or not) and our regular jupyter users.

@johrstrom If it helps, I posted links to my usr versions of these in OSC Kubernetes slack channel which is how I've been testing these.  I had never used the traditional HPC versions so we might have to lean on others at OSC to test those aspects, since I don't know what previous behavior was like.  In theory this pull request won't change the traditional HPC experience.

While I think this is probably OK - I'm just focused on RStudio at the moment so it may not get pulled in for a bit.


test SolverName and implement is_empty

This is as far as I got before being blocked by https://github.com/ERGO-Code/HiGHS/issues/223.
Should we move this repo to JuMP-dev for easier collaboration?

Thanks. Yes agreed to move the repo to JuMP-dev, my next step is to build it using the latest BinaryBuilder

@mlubin I just invited you to the repo, you should be able to transfer it, otherwise I'll need the ability to create a public repo on JuMP-dev


Exclude go-bindata generated files

From user bbrazil on Reddit:

On https://goreportcard.com/report/github.com/prometheus/prometheus there's a lot of complaints about https://github.com/prometheus/prometheus/blob/master/web/ui/bindata.go which is file generated by go-bindata.
Maybe any files starting with "Code generated by go-bindata." should be excluded?

Sounds good to me.

I've used this tool before as well and I believe it always outputs a bindata.go, so let's just skip those files for now

So should we consider this fixed now?

@hermanschaaf yeah I think so, I'll close


externalise mongodb configuration

I can't comment on the java bits too much, I'm not a java developer.
Otherwise I'll give it a LGTM.
@lbennett-hod do you need a java developer to code review it or should I merge it as it is ?

go ahead and merge


HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

JIRA: HDFS-17091. Blocks on DECOMMISSIONING DNs should be sorted properly in LocatedBlocks.

Good Catch! @tomscut Can you help to review this pr? Thank you very much!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m  3s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
36m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
37m 20s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
217m  5s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

363m 29s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5849

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a0e41270ffe2 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3ae36fa765a2751d64d5448f488aea768f113640

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/1/testReport/

Max. process+thread count
3131 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 18s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
36m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 24s

the patch passed

+1 :green_heart:
shadedclient
37m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
218m 55s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

363m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5849

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bf4021a9d282 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 34c0000bebde120bb2d4eb09d81b87fdf614b67e

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/2/testReport/

Max. process+thread count
3088 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5849/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang @slfan1989 @ayushtkn Thank you for your review~!


dotenv env expansion fails for envs names with underscores and no curly-braces

# just --version
just 1.30.1

I have a dotenv file .env:
ENV1=myval1
ENV_2=myval2

MYENV1=$ENV1
MYENV_2=$ENV_2
MYENV3=${ENV1}
MYENV_4=${ENV_2}

and a Justfile:
set dotenv-required
set dotenv-path := '.env'

echo:
    echo $MYENV1
    echo $MYENV_2
    echo ${MYENV3}
    echo ${MYENV_4}

When I run just echo, I would expect the output:
# just echo
myval1
myval2
myval1
myval2

Instead I get:
# just echo
myval1
_2
myval1
myval2

Yah, looks like this is by design. Seems unfortunate, since shells, which .env syntax is supposed to mimic, don't require curly brackets around $FOO_BAR.

If the doenvy was part of just, I would actually change this, since I think it's so unexpected that it's almost bug-like, even though it would technically be backwards incompatible. However, since it's not, unless upstream is interested in changing it, I think we've just gotta let it stand.


Create a fnew facility lcos::split_all

Several people have been asking for a facility which allows to convert a future storing a tuple of values into a tuple of futures, each storing one of the elements of the original tuple:
tuple<future<T>...> split_all(future<tuple<T...>> &&);

Other possible names discussed were unfuse() or split_unfused().

@ltroska @biddisco is this what you were looking for?

A related facility would be:
vector<future<T>...> split_all(future<vector<T...>> &&);

Is the usecase more like this:
future<T> f= ...;
auto ff = f.then(
    [](...){
        future<U> f1 = ...;
        future<R> f2 = ...;
        return XXX(move(f1), move(f2));
});
ff = f.then(...);
dataflow(..., get<0>(ff));
dataflow(..., get<1>(ff));

?

In any case, the usecase as sketched above should be already supported out of the by the split_all functionality.

@hkaiser yes. This is what I was asking for. @rasolca has a use case where matrix sub-blocks are processed and when a task completes, it returns a future which is consumed by two new tasks. One task needs the matrix data, the other task only needs to be triggered when the operation completes. In the larger DAG, each task is using a future from the upper-left and upper-right - taking the matrix from one, and synchronization only from the other. As this pattern repeats, one finds that one needs a shared_future for each task since two other tasks are always using each future. It turns out that it messes the code up because the shared_future returns a const ref which makes the code more complicated than it needs to be. The solution would be for each task to return a pair<matrix,void> and to turn that into future, future using the new split_all feature - then the future can be passed to the left sub-task and the future to the right- and each can take a left/right pair from their other neighbours etc etc. Making the code simpler, more readable and generally better.
Allowing async functions to return more than one future is essntially what we want, but providing an split_future<> utility would work as well.

PS. I like the name split_future<> as it does what it says on the tin.

PS. I like the name  split_future<>  as it does what it says on the tin.

I like that!

A related facility would be:
vector<future<T>...> split_all(future<vector<T...>> &&);

Unfortunately, it isn't possible to implement this without calling get on the argument. @sithhell  however suggested to add this:
array<N, future<T>> split_future(future<array<N, T>> &&);


Which language file should be downloaded?

Should I download the file in Script directory? or in the root? and if it is the one in Script dir, should I rename it? because all of them have the full name of the language, yet tesseract uses a 3 character input (eng instead of English). Finally, do I have to download the PDF and osd files too or just the training data?
Thank you.

idk, if I should reply now but only trainingdata or .traineddata

You can download language or script .traineddata files as you need. And you are free to rename your downloaded files or not.
Please use the Tesseract user forum for additional questions.


unsupported_api

when shellcode calls "KERNEL32.FindResourceExW", it throws this Error...
        "error": {
            "type": "unsupported_api",
            "pc": "0xfeedf00c",
            "address": "0xfeedf00c",
            "instr": "disasm_failed",

then i build a program which calls "KERNEL32.FindResourceExW", it happens again, so it is proved: yes,unsupported_api.
maybe  there are much more Apis do not be supported...how can i fix such issues? my big brother,

Hi @leibso , please read this blog to learn how to create API hooks and API handlers in Speakeasy: https://www.fireeye.com/blog/threat-research/2020/12/using-speakeasy-emulation-framework-programmatically-to-unpack-malware.html

oh well ，thanks a lot


If supplying pDynamicState, dynamicStateCount must be > 0

Running dEQP-VK.api.smoke.triangle, the call to vkCreateGraphicsPipelines supplies a pDynamicState, and the dynamicStateCount is 0, and pDynamicStates pointer is NULL.  Technically, the way to specify no dynamic state is to pass a NULL pDynamicState pointer  in VkGraphicsPipelineCreateInfo. This happens in other tests as well, especially dEQP-VK.api.object_management.max_concurrent.graphics_pipeline

This has been resolved in vulkan-cts-1.0-dev branch.


Support of multi-machine training

Does detrex support multi-machine training(not single machine multiple GPU)? If not , are you planning to support it? Thanks!

Does detrex support multi-machine training(not single machine multiple GPU)? If not , are you planning to support it? Thanks!

We directly build detrex based on detectron2, and detectron2 has already supported multi-node and multi-gpus training I think, but we did not test it in detrex now, we will test it later, maybe you can also refer to detectron2 lazyconfig_train_net for more details, and after our testing, we will provide a tutorial about this
I thinks more details can be found in their launch wrapper for multi-node and multi-gpus training

Thanks, I will try to figure it out by myself first and I'm looking forward to your tutorial and test performance report.

Thanks, I will try to figure it out by myself first and I'm looking forward to your tutorial and test performance report.

Thanks, we will try to build a better docs for users~ thanks for your nice issue @Artificial-Inability


Integer/Float URL Parameters, Maintain Type

Consider a state which has url: '/example/{exampleId:[0-9]}' and that we navigate our application to /example/5.
Inspecting $stateParams the result is {exampleId: "0"} and thus exampleId is a string. If we later use this result to perform ajax queries or other operations we may run into a few issues and have to convert the string at the client or server side.
Perhaps $stateParams could check if the value is an integer/float and store it as such, else store as string? Or have a an additional option within the url:{} param to determine if it is to be stored as a string or not?

FYI - Using Int params type with "offlimit number"
Becareful using int as parameter type with than kind of number<PHONE_NUMBER>02753064.
If you pass<PHONE_NUMBER>02753064 into Number/String like uirouter int params does.
Number(116410000002753064) // output:<PHONE_NUMBER>02753060
Number(116410000002753064123123912) // output:<PHONE_NUMBER>02753060000000000

Same using String()
I had to put [0-9]+ pattern on my param to make it work as expected.


Fix get deployment status issues

Fix getting deployment status timeout wording
Extend deploy status pending time to 180s

Codecov Report

Merging #840 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #840   +/-   ##
==========================================
  Coverage      45.04%   45.04%
  Complexity       766      766
==========================================
  Files            133      133
  Lines           5110     5110
  Branches         729      729
==========================================
  Hits            2302     2302
  Misses          2638     2638
  Partials         170      170

Impacted Files
Coverage Δ
Complexity Δ

...a/com/microsoft/azure/maven/spring/DeployMojo.java
5.42% <ø> (ø)
4 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622abbe...fd5dbb0. Read the comment docs.


How to search only in certain page?

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: N/A
Operating system and its version: N/A
PDF.js version: 2.0
Is a browser extension: No

Steps to reproduce the problem:
I'm looking to enforce the web viewer to search the input text on specific page we give them.
So for example, if I give text and a page number, pdfjs should only search within that page and no other pages.
I'm trying to speed up the search when pdf file has lots of pages.
Thanks

This is not something that PDF.js supports, so you'll have to implement this yourself. What might work (untested) is setting the pageIdx as offset.


support for netflix?

Does this simple piece of code support proxy for youtube or netflix stream?

I'm not sure, I guess not


Test on Python 3.12

Our pandas dependency is broken on Python 3.12.

This should be fixed now we don't work around the pandas pickle issues anymore.

Confirmed + updated CircleCI config in 1bf86bf.


Color cast when fullscreen on chromeos and window.titleBarStyle custom

Issue Type: Bug
When a VSCode window is maximized on a ChromeOS Pixelbook's internal display, the entire application surface gains a blue tint, making yellows look sickly and greenish.
Photos here
I'm not 100% sure that this is a VSCode bug or something at the intersection of VSCode and ChromeOS, but
Steps to reproduce:

Set "window.titleBarStyle": "custom" and restart VSCode as needed
Note that yellows appear saturated and natural
Maximize or Fullscreen the VSCode app (these are separate states in ChromeOS)
Note that yellows appear greenish

Additional Detective Work

This is VSCode running inside the default linux (crostini, Debian Stretch) container on a Google Pixelbook with the latest stable channel patches and GPU acceleration enabled.
This only affects VSCode, and does not seem to affect other apps (tested in Terminal and Tilix).
It only affects VSCode if the "window.titleBarStyle": "custom" setting is chosen. With a native titlebar, this artifact does not happen.
This effect does not happen on external displays at all.
This does not happen on the built-in display if there are any displayed notifications. As soon as the notifications are dismissed and VSCode is the only rendered surface on the screen, the blue cast returns. This leads me to suspect some funky interaction with GPU acceleration.

VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:33:40.634Z)
OS version: Linux x64 4.19.60-06185-g54aa50936831

System Info

Item
Value

CPUs
06/8e (4 x 1607)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
4.84GB (2.99GB free)

Process Argv
--unity-launch

Screen Reader
no

VM
100%

Extensions (10)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.9.1

gitlens
eam
10.1.1

prettier-vscode
esb
2.3.0

beautify
Hoo
1.5.0

theme-monokai-pro-vscode
mon
1.1.14

remote-ssh
ms-
0.47.1

remote-ssh-edit
ms-
0.47.1

vsliveshare
ms-
1.0.988

fish-vscode
sky
0.2.1

vscodeintellicode
Vis
1.1.9

(1 theme extensions excluded)

I'll add a note that this is definitely not caused by "Night Shift" or any other blue-light-modulating function. I tested this during the daytime and doublechecked by disabling night shift entirely.

OK, seems like this has to do with adaptive backlighting on Pixelbooks! Happens even with VS Online in fullscreen mode.

https://www.reddit.com/r/PixelBook/comments/8pvzws/loving_my_pixelbook_but_theres_an_odd_graphical/


addind Dockerfile and exposing the port

[Current coverage][cc-pull] is 54.08%

Merging [#10][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #10   diff @@
==========================================
  Files            10         10
  Lines           601        601
  Methods           0          0
  Messages          0          0
  Branches         81         81
==========================================
  Hits            325        325
  Misses          242        242
  Partials         34         34

Powered by Codecov. Last updated by [fc6d37c...a003bba][cc-compare]
[cc-base-branch]: https://codecov.io/gh/TeamHG-Memex/autologin/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/TeamHG-Memex/autologin/compare/fc6d37c5c8bdfec322875078601b7236b3eb3553...a003bba9560adc281a71f2abd3c9b08da40fa92a
[cc-pull]: https://codecov.io/gh/TeamHG-Memex/autologin/pull/10?src=pr

@fornarat @lukemaxwell I've updated the docker file a tiny bit, to start the autologin-http-api and use python 3.5 by default - it seems to build and run fine.
The only issue is that the keychain sqlite db is inside the image right now - do we want to move it to a volume? I'm really new to docker, not sure which is the best way to set it up.

+1 to moving sqlite DB out of a docker image; users should be able to persist their keychains between Docker image rebuilds.

I think I fixed all the issues now: current source is used when building the docker container, and the database lives in /var/autologin which is made a volume by docker-compose, so the data persists between the ``docker-compose up calls.
The only issue is that docker-compose has incomplete support for .dockerignore files (https://github.com/docker/compose/issues/1607). This does not seem to cause any visible issues, just that pyc and __pycache__ files appear in the container. I tried to work around it by failed so far.

I'd not worry about pyc and __pycache__ files - the overhead is tiny.

Thanks everyone! 👍


Make code folding work on mobile layout

This is just a tiny modification to make code folding work on mobile GH layout. Since it detects that layout only when the script otherwise wouldn't activate, it "shouldn't" break existing functionality.
I've tested it on mobile chrome (Android) and regression-tested on desktop FF.

Hi @zb3!
Thanks for the contribution! I really appreciate it!


VM IPaddress doesnt change

VM doesnt change IPaddress (re-connect VPN) after the instance is finished.

Fixed the bug


.data section cannot contain semicolons

I think that the way cleanup trims out comments will make programs with semicolons in the data section fail to assemble, or assemble incorrectly.

Ah yes I see. The current method would prohibit you to use a semicolon in a text string.
Without testing it, I believe that splitting comments on a (?!\\;);. regular expression would fix this, as long as semicolons are escaped in the string. Any better fix is going to require writing a much more complex parser which is a bit out of my scope for this project at the moment.
Ill give it a go this evening and see if it works.

Ah yes I see. The current method would prohibit you to use a semicolon in a text string.
Without testing it, I believe that splitting comments on a (?!\;);. regular expression would fix this, as long as semicolons are escaped in the string. Any better fix is going to require writing a much more complex parser which is a bit out of my scope for this project at the moment.
Ill give it a go this evening and see if it works.

So with a little added complexity to the comment stripping functionality, https://github.com/francisrstokes/16bitjs/pull/20 should solve the issue.
Semicolons in data section need to be escaped in order to not be recognised as comments.


Add a flag to services for wrapping them with rr

Sister issue to https://github.com/NixOS/nixpkgs/issues/99535
What if you could enable a flag on systemd services to get rr to record them?

I'm not sure if it might be a bit awkward needing to rebuild (or at least use extra-container) to enable or disable the recording wrapper, maybe another approach to include would be to generate both a wrapped and unwrapped service and then start the appropriate one with systemctl?


Doskey $B/$b is equivalent to |, not to ( nor *

Looks like there was probably some weirdness when converting the docs to Markdown because pipe is a special character. Escaping the pipe inside a code block seems iffy but it worked in the preview.

@louiswins : Thanks for your contribution! The author(s) have been notified to review your proposed change.


fix: prevent calender render panic when terminal height is small

Fixes: #1379

Thanks for the fix


Correction of a spelling mistake

Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[ ] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @tharindukumarasiri,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Not a spelling mistake. hass is short for Home Assistant.


pool.start(); never return on MacOS

      var pool = IsolatePool(4);
      await pool.start();

pool.start(); never return on MacOS
Do I do something wrong?

Any detail? I just tried it on macOS, all tests pass (and there're plenty of pool.start() )

I don't see anything special in my code...
var pool = IsolatePool(4);
await pool.start();

happens when clicking a button
Have you tried with the MacOS sandbox enabled?
The test environment doesn't have these constraints, does your integrations test work?
I'm not sure what is relevant here...

00:00 +0: loading /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart
00:01 +0: loading /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart
00:01 +0: loading /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart
00:01 +0: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawning isolates works
00:01 +0: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawning isolates works
Creating a pool of 8 running isolates

00:01 +0: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce is put to pool and responds
Creating a pool of 2 running isolates

00:01 +0: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance succeeds
Creating a pool of 4 running isolates
Shell: Isolate #0 started (12857 microseconds)
Shell: Isolate #1 started (637 microseconds)
Shell: Isolate #2 started (484 microseconds)
Shell: Isolate #3 started (399 microseconds)
Shell: Isolate #4 started (563 microseconds)
Shell: Isolate #5 started (429 microseconds)
Shell: Isolate #6 started (449 microseconds)
Shell: Isolate #7 started (405 microseconds)
Shell: Isolate #0 started (12236 microseconds)
Shell: Isolate #1 started (1329 microseconds)

00:01 +0: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce is put to pool and responds
spawn() called on 2 isolates(16324 microseconds)
Avg time to complete starting an isolate is 6782.5 microseconds

00:01 +0: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawning isolates works
spawn() called on 8 isolates(21493 microseconds)
Avg time to complete starting an isolate is 2027.875 microseconds
Shell: Isolate #0 started (15493 microseconds)
Shell: Isolate #1 started (760 microseconds)
Shell: Isolate #2 started (540 microseconds)
Shell: Isolate #3 started (433 microseconds)

00:01 +1: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce is put to pool and responds
00:01 +1: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance succeeds
spawn() called on 4 isolates(20863 microseconds)
Avg time to complete starting an isolate is 4306.5 microseconds

00:01 +1: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawned pool isolates are killed
Creating a pool of 8 running isolates
Shell: Isolate #0 started (538 microseconds)
Shell: Isolate #1 started (483 microseconds)
Shell: Isolate #2 started (394 microseconds)
Shell: Isolate #3 started (422 microseconds)

00:01 +2: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance succeeds                                                                                Shell: Isolate #4 started (440 microseconds)
Shell: Isolate #5 started (487 microseconds)
Shell: Isolate #6 started (538 microseconds)
Shell: Isolate #7 started (433 microseconds)

00:01 +2: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawned pool isolates are killed
spawn() called on 8 isolates(6417 microseconds)
Avg time to complete starting an isolate is 466.875 microseconds

00:01 +3: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Spawned pool isolates are killed
00:01 +3: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce throws when receving unknown action
Creating a pool of 3 running isolates
Shell: Isolate #0 started (351 microseconds)
Shell: Isolate #1 started (438 microseconds)
Shell: Isolate #2 started (374 microseconds)
spawn() called on 3 isolates(1636 microseconds)

00:01 +4: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce throws when receving unknown action
00:01 +4: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce throws when receving unknown action
Avg time to complete starting an isolate is<PHONE_NUMBER>666667 microseconds

00:01 +4: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating multiple pooled instance succeeds
Creating a pool of 4 running isolates
Shell: Isolate #0 started (398 microseconds)
Shell: Isolate #1 started (452 microseconds)
Shell: Isolate #2 started (384 microseconds)
Shell: Isolate #3 started (499 microseconds)
spawn() called on 4 isolates(2502 microseconds)

00:01 +4: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Awaiting "start" completer
Creating a pool of 8 running isolates

00:01 +4: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating multiple pooled instance succeeds
Avg time to complete starting an isolate is 433.25 microseconds
Shell: Isolate #0 started (584 microseconds)
Shell: Isolate #1 started (365 microseconds)
Shell: Isolate #2 started (427 microseconds)
Shell: Isolate #3 started (357 microseconds)
Shell: Isolate #4 started (348 microseconds)
Shell: Isolate #5 started (339 microseconds)
Shell: Isolate #6 started (341 microseconds)
Shell: Isolate #7 started (351 microseconds)

00:01 +4: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Awaiting "start" completer
spawn() called on 8 isolates(4531 microseconds)
Avg time to complete starting an isolate is 389.0 microseconds

00:01 +5: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce throws when receving unknown action
00:01 +6: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce throws when receving unknown action
00:01 +6: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Awaiting completed "start" completer
Creating a pool of 8 running isolates
Shell: Isolate #0 started (358 microseconds)
Shell: Isolate #1 started (448 microseconds)
Shell: Isolate #2 started (390 microseconds)
Shell: Isolate #3 started (364 microseconds)
Shell: Isolate #4 started (354 microseconds)

00:01 +6: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating different type pooled instance succeeds
Creating a pool of 4 running isolates
Shell: Isolate #5 started (323 microseconds)
Shell: Isolate #0 started (394 microseconds)

00:01 +7: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Awaiting completed "start" completer                                                                                Shell: Isolate #6 started (365 microseconds)
Shell: Isolate #7 started (349 microseconds)
Shell: Isolate #1 started (363 microseconds)
Shell: Isolate #2 started (379 microseconds)
Shell: Isolate #3 started (374 microseconds)

00:01 +7: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Awaiting completed "start" completer
spawn() called on 8 isolates(4522 microseconds)
Avg time to complete starting an isolate is 368.875 microseconds

00:01 +7: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating different type pooled instance succeeds
spawn() called on 4 isolates(2409 microseconds)
Avg time to complete starting an isolate is 377.5 microseconds

00:01 +8: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating different type pooled instance succeeds
00:01 +8: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce can be destroyed
Creating a pool of 3 running isolates
Shell: Isolate #0 started (410 microseconds)
Shell: Isolate #1 started (384 microseconds)
Shell: Isolate #2 started (400 microseconds)
spawn() called on 3 isolates(1720 microseconds)
Avg time to complete starting an isolate is 398.0 microseconds

00:01 +8: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Runing simple job in the pool
Creating a pool of 4 running isolates
Shell: Isolate #0 started (386 microseconds)
Shell: Isolate #1 started (346 microseconds)
Shell: Isolate #2 started (392 microseconds)
Shell: Isolate #3 started (327 microseconds)
spawn() called on 4 isolates(2150 microseconds)

00:01 +9: /Users/fractale/isolate_pool_2/test/pooled_instance_test.dart: Pooled isnatce can be destroyed
00:01 +9: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Runing simple job in the pool
Avg time to complete starting an isolate is 362.75 microseconds

00:01 +10: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Runing simple job in the pool                                                                                Shell: Number 103Number 104
Shell:
Shell: Number 101
Shell: Number 102
Shell: Number 105
Shell: Number 106
Shell: Number 107
Shell: Number 108
Shell: Number 109
Shell: Number 110
Shell: Number 111
Shell: Number 112
Shell: Number 113
Shell: Number 114
Shell: Number 115

00:01 +10: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Runing simple job in the pool
[101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115]

00:01 +11: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Instances are created in different isolates
00:01 +11: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Instances are created in different isolates
Creating a pool of 4 running isolates
spawn() called on 4 isolates(1900 microseconds)
Avg time to complete starting an isolate is 323.0 microseconds

00:01 +12: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Instances are created in different isolates
00:01 +12: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Simple job returns correct result                                                                                Shell: Isolate #0 started (300 microseconds)
Shell: Isolate #1 started (306 microseconds)
Shell: Isolate #2 started (373 microseconds)
Shell: Isolate #3 started (313 microseconds)

00:01 +12: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Simple job returns correct result
Creating a pool of 4 running isolates
Shell: Isolate #0 started (403 microseconds)
Shell: Isolate #1 started (424 microseconds)
Shell: Isolate #2 started (339 microseconds)
Shell: Isolate #3 started (333 microseconds)

00:01 +12: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can destroy pooled instances
Creating a pool of 4 running isolates

00:01 +12: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Simple job returns correct result
spawn() called on 4 isolates(2247 microseconds)
Avg time to complete starting an isolate is 374.75 microseconds
Shell: Isolate #0 started (454 microseconds)
Shell: Isolate #1 started (423 microseconds)
Shell: Isolate #2 started (439 microseconds)
Shell: Number 1
Shell: Number 2
Shell: Number 3
Shell: Isolate #3 started (578 microseconds)

00:01 +12: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can destroy pooled instances
spawn() called on 4 isolates(2674 microseconds)

00:01 +13: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can destroy pooled instances
00:01 +13: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can destroy pooled instances
Avg time to complete starting an isolate is 473.5 microseconds

00:01 +13: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Nothing horrible happens if pool is killed while there're running jobs
Creating a pool of 4 running isolates
Shell: Isolate #0 started (361 microseconds)
Shell: Isolate #1 started (472 microseconds)
Shell: Isolate #2 started (407 microseconds)
Shell: Isolate #3 started (344 microseconds)
spawn() called on 4 isolates(2486 microseconds)
Avg time to complete starting an isolate is 396.0 microseconds
Shell: Number 101
Shell: Number 102
Shell: Number 103

00:01 +14: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Nothing horrible happens if pool is killed while there're running jobs                                             Shell: Number 104
Shell: Number 105

00:01 +14: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Calling method with pool stopped is handled
Creating a pool of 4 running isolates
Shell: Isolate #0 started (425 microseconds)
Shell: Isolate #1 started (366 microseconds)
Shell: Isolate #2 started (334 microseconds)
Shell: Isolate #3 started (397 microseconds)
spawn() called on 4 isolates(2509 microseconds)
Avg time to complete starting an isolate is 380.5 microseconds

00:01 +15: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Calling method with pool stopped is handled
00:01 +15: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Running pool job that fails is properly handled
Creating a pool of 3 running isolates
Shell: Isolate #0 started (368 microseconds)
Shell: Isolate #1 started (280 microseconds)
Shell: Isolate #2 started (310 microseconds)
spawn() called on 3 isolates(1622 microseconds)
Avg time to complete starting an isolate is<PHONE_NUMBER>333333 microseconds
Shell: Number 105Number 103
Shell: Number 101
Shell:
Shell: Number 107

00:01 +16: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Running pool job that fails is properly handled
00:01 +17: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Isolate pool Running pool job that fails is properly handled
00:01 +17: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're instances being created
00:01 +17: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're instances being created
Creating a pool of 5 running isolates
Shell: Isolate #0 started (400 microseconds)
Shell: Isolate #1 started (290 microseconds)
Shell: Isolate #2 started (327 microseconds)
Shell: Isolate #3 started (332 microseconds)
Shell: Isolate #4 started (394 microseconds)
spawn() called on 5 isolates(2843 microseconds)
Avg time to complete starting an isolate is 348.6 microseconds

00:01 +18: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're instances being created
00:01 +19: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're instances being created
00:01 +20: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Callback isolate Async job reports progress
00:02 +20: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're requests pending
Creating a pool of 5 running isolates
Shell: Isolate #0 started (358 microseconds)
Shell: Isolate #1 started (317 microseconds)
Shell: Isolate #2 started (417 microseconds)
Shell: Isolate #3 started (347 microseconds)
Shell: Isolate #4 started (348 microseconds)
spawn() called on 5 isolates(2803 microseconds)
Avg time to complete starting an isolate is 357.4 microseconds

00:02 +21: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Can stop while there're requests pending
00:02 +22: /Users/fractale/isolate_pool_2/test/isolate_pool_test.dart: Callback isolate Async job re-throws exception
00:02 +23: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance with error
00:02 +23: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance with error
Creating a pool of 4 running isolates
Shell: Isolate #0 started (371 microseconds)
Shell: Isolate #1 started (331 microseconds)
Shell: Isolate #2 started (304 microseconds)
Shell: Isolate #3 started (356 microseconds)
spawn() called on 4 isolates(2202 microseconds)
Avg time to complete starting an isolate is 340.5 microseconds

00:02 +24: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: Creating pooled instance with error
00:02 +24: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA (setUpAll)
00:02 +24: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA (setUpAll)
Creating a pool of 4 running isolates
Shell: Isolate #0 started (424 microseconds)
Shell: Isolate #1 started (427 microseconds)
Shell: Isolate #2 started (262 microseconds)
Shell: Isolate #3 started (233 microseconds)
spawn() called on 4 isolates(2461 microseconds)
Avg time to complete starting an isolate is 336.5 microseconds

00:02 +24: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Simple action returns result
00:02 +25: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Simple action returns result
00:02 +25: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Call callback from pooled instance
00:02 +26: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Call callback from pooled instance
00:02 +26: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Call null callback from pooled instance
00:02 +27: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Call null callback from pooled instance
00:02 +27: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Async action returns result
00:02 +28: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Async action returns result
00:02 +28: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Reqeusts number grows and declines
00:02 +29: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Reqeusts number grows and declines
00:02 +29: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Failed action returns error
00:02 +29: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA (setUpAll)
Isolate pool received request to instance 118 which doesnt have callback intialized

00:02 +30: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Failed action returns error
00:02 +30: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Sending second request before the first completes
00:02 +31: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA Sending second request before the first completes
00:02 +31: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerA (tearDownAll)
00:02 +31: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB (setUpAll)
00:02 +31: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB (setUpAll)
Creating a pool of 4 running isolates
Shell: Isolate #0 started (399 microseconds)
Shell: Isolate #1 started (375 microseconds)
Shell: Isolate #2 started (315 microseconds)
Shell: Isolate #3 started (330 microseconds)
spawn() called on 4 isolates(2092 microseconds)
Avg time to complete starting an isolate is 354.75 microseconds

00:02 +31: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Simple action returns result
00:02 +32: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Simple action returns result
00:02 +32: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Calling unknown action when wroker is supposed to throw
00:02 +33: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Calling unknown action when wroker is supposed to throw
00:02 +33: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Calling action with unexpected params when wroker is supposed to throw
00:02 +34: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Calling action with unexpected params when wroker is supposed to throw
00:02 +34: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Sending second request before the first completes
00:02 +35: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB Sending second request before the first completes
00:02 +35: /Users/fractale/isolate_pool_2/test/pooled_instance_more_test.dart: WorkerB (tearDownAll)
00:02 +35: All tests passed!

All tests pass...
Please share the full file where you start the pool. happens when clicking a button sounds suspicious, I never tried starting the pool in event handler, I usually did that upon app initatilization and than used global var to access the pool

class _MyHomePageState extends State<MyHomePage> {

  @override
  Widget build(BuildContext context) {
    return DropTarget(
      onDragDone: _processDroppedFiles,
      child: Text("Hello world"),);
    }

  Future<void> _processDroppedFiles(DropDoneDetails dropDoneDetails) async {
    var pool = IsolatePool(4);
    await pool.start(); // never returns
    ... try to use the pool to work in parallel on the files
    }
}

I'd suggest you to create the pool in main() and keep the reference to it in a global var

@maxim-saplin have you been able to reproduce the issue with this code? I will try to put this code in the main function


MIT_5K pretrained weight does not match the results from the paper

Hi!
From the pretrained weight provided here: https://drive.google.com/file/d/1ErcewI9mTWzJXOm14iWYNaM8qC6srCoK/view,
and the MIT_5K dataset provided here: https://drive.google.com/drive/folders/18bTBJX34I3CjAb9qBDxvHWRPQLYSQcld
The metrics, PSNR and SSIM, are far worse than the results recorded in the paper.
I assume there might be some misupload of the dataset or the pretrained weight,
would you might take a look at the result from your pretrained weight of MIT_5K?

Hello, can you provide the screenshot for bad PSNR and SSIM results?
Because I reran the process and the results were the same.
Do you follow the readme instruction using evaluate.py to calculate PSNR, SSIM along with the Y-axis?


ctest script simplified

added some description about the library in README.

Looks good! I will now merge the pull request


optional takes_value

hello!
is there a way to make takes_value optional? if you think it's fairly easy and you'd like to include this as a feature, I could look into that myself.
in my little script I imagined the following syntax:
# enforce a value for key
command --key something

# user is prompted to select a value for key (via its index) from a longer list of possible values
command --key

# assume a default value for key
command

I know about the empty_vals flag but I was just wondering if there would be a way to not pass the empty string every time.
thanks! :cake:

@lipanski Thanks for suggesting this! I think this isn't a bad idea with a few changes to your proposal.

I'd be ok implementing allowing options to use 0 or more values (via Arg::min_values), although one it would have to be caveated that it could lead to poor CLI design if you're not careful. i.e. if you have an option which allows 0 values, and you have positional values the following could lead to confusing errors for the user

$ program --option pos
  is pos a value for --option, or a positional value?
$ program --option -- pos
  now pos is clearly a positional argument, but users may not think to use --

If the user simply provides the option without a value --key I don't believe it should be a function of clap to ask for a value, that should be more on the consumer of library. Because those requirements could be incredibly different from program to program. And this should be trivial to do, i.e. check if a value was provided or not

if matches.value_of("key").is_none() {
    // ask for a value or assume default
}

Leaving the option off entirely and defaulting to some sane value can already be accomplished

let key = matches.value_of("key").unwrap_or("default_key");

So I'll place it on the map to add 0 or more values, because this does seem to be something people ask about from time to time. Thanks again for taking the time to file this! :+1:

if you have an option which allows 0 values, and you have positional values the following could lead to confusing errors for the user

didn't really think about that :\ would positional arguments take precedence over key arguments in that case?

If the user simply provides the option without a value --key I don't believe it should be a function of clap to ask for a value, that should be more on the consumer of library.

I totally agree - that was just an example / my own use case.

Leaving the option off entirely and defaulting to some sane value can already be accomplished

Under which conditions would this evaluate to None / the default? Given:
Arg::with_name("hello").long("hello").takes_value(true)

# The argument '--hello <hello>' requires a value but none was supplied
cargo run -- command --hello

# Works, but matches.value_of("hello") produces Some("")
cargo run -- command --hello ""

And given:
Arg::with_name("hello").long("hello").takes_value(false)

# Found argument 'something', but command wasn't expecting any
cargo run -- command --hello "something"

thanks for your quick reply and for considering this!

Ah ok, you're talking about with required arguments having default values. That in particular isn't possible yet, and I have mixed feelings on if it'd be a good idea or not.
I would say it'd probably be better idea to to not make the argument required if you want it to have a default value. Because if the user leaves it off, it uses the default value, but if the user uses it, it still has a value. So there's not really a circumstance where it doesn't have a value (making the requirement piece less needed).

didn't really think about that :\ would positional arguments take precedence over key arguments in that case?

The way clap works now, if you specify something takes a value, it looks for the next argument unless that next argument starts with a - character. So clap has no way of knowing whether the argument provided after an option is either a positional argument, or the value for an option.
What would happen in that case is the positional argument would end up being stored as a value to that option. This can be mitigated by designing the CLI so that there either are no positional arguments, or all options take at least one value (even if it's empty). This is why I'm ok with implementing this feature, because the default will still be 1 or more values, but if the consumer of the library knows that they either have no positional values, or isn't concerned about the possible confusion, they can opt out by specifying a min_values of 0.

Closed with #386

:dancer: thx


Debian packages for Kong depend on zlib1g-dev instead of zlib1g

Hello, I am not sure if this is a bug but I noticed that installing Kong debian packages has requirement on zlib1g-dev which is the development headers for zlib1g. I think for runtime you do not need the development package but should instead depend on zlib1g, right?
We already install zlib1g which is pretty standard but we need to install now zlib1g-dev separately just for Kong and we would like to not to have to :)
Thank you!

Oh well, I guess  libz.so is just poorly packaged :)
#0 0.922 ERROR: /usr/local/share/lua/5.1/ffi-zlib.lua:98: libz.so: cannot open shared object file: No such file or directory
#0 0.922 stack traceback:
#0 0.922 	/usr/local/share/lua/5.1/ffi-zlib.lua:98: in main chunk
#0 0.922 	[C]: in function 'require'
#0 0.922 	/usr/local/share/lua/5.1/kong/tools/utils.lua:17: in main chunk
#0 0.922 	[C]: in function 'require'
#0 0.922 	/usr/local/share/lua/5.1/kong/globalpatches.lua:271: in function </usr/local/share/lua/5.1/kong/globalpatches.lua:4>
#0 0.922 	/usr/local/share/lua/5.1/kong/cmd/init.lua:1: in main chunk
#0 0.922 	[C]: in function 'require'
#0 0.922 	/usr/local/bin/kong:9: in function 'file_gen'
#0 0.922 	init_worker_by_lua:46: in function <init_worker_by_lua:44>
#0 0.922 	[C]: in function 'xpcall'
#0 0.922 	init_worker_by_lua:53: in function <init_worker_by_lua:51>


Installation instructions are missing important steps for Android

#16# Expected Behaviour
When I follow the installation instructions in the readme file, I expect it to run in iOS and Android without crashing
Actual Behaviour
Android installation is missing steps, so it crashes. To fix, I had to dig into sample app code and find the missing info.
Steps to Reproduce
Follow your installation instructions and try to add a call to ACPCore.trackState() in the app. App will crash at this point with an error that says "cannot call trackState() on undefined"
Resolution
Add steps to installation instructions for Android:
in MainApplication.java, add the following imports:
import com.adobe.marketing.mobile.reactnative.analytics.RCTACPAnalyticsPackage;
import com.adobe.marketing.mobile.reactnative.RCTACPCorePackage;
also in MAinApplication.java, add the packages to the app:
protected List getPackages() {
// Add additional packages you require here
// No need to add RnnPackage and MainReactPackage
return Arrays.asList(
new RCTACPAnalyticsPackage(),
new RCTACPCorePackage()
);
}
This correctly links the libraries in Android so that the project runs without crashing.

Hi @awatt-cox 👋
Did you run react-native link @adobe/react-native-acpcore and react-native link @adobe/react-native-acpanalytics? Those two commands should add this Java code to your project so you don't have to manually.
What version of React Native are you running?

Hi Nick,
We are using RN 0.61.2, which uses autolinking. After installing ACPCore and ACPAnalytics, I ran a script that we have which:

deletes all node modules
deletes pods and Podfile.lock
clears all caches and build folders
runs npm i
runs pod install.
Runs npm start
It auto-linked the pods correctly, but did not install the modules into MainApplication.java. None of our other modules auto-install the package code into MainApplication.java – we always manually add them. This was not spelled out in your instructions, so I had to find it in the sample project.

Thanks,
Andy
From: Nick Porter<EMAIL_ADDRESS>Reply-To: adobe/react-native-acpcore<EMAIL_ADDRESS>Date: Wednesday, December 11, 2019 at 3:23 PM
To: adobe/react-native-acpcore<EMAIL_ADDRESS>Cc: "Watt, Andy (CAI - Atlanta)"<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [adobe/react-native-acpcore] Installation instructions are missing important steps for Android (#54)
Hi @awatt-coxhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_awatt-2Dcox&d=DwMFaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=Xb3JEn5aFJwN-vqzgAM--zbHyskwYI5OyPxqOYbyCwU&s=Dq4y8Y9Gv6sNPs9FKrh7gdM3-NNWFU9RXBWYBYJVVfU&e= 👋
Did you run react-native link @adobe/react-native-acpcore and react-native link @adobe/react-native-acpanalytics? Those two commands should add this Java code to your project so you don't have to manually.
What version of React Native are you running?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_adobe_react-2Dnative-2Dacpcore_issues_54-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAM6QASBEOUPYTF5KCAABQD3QYFD3HA5CNFSM4JZUGDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUOJ3Y-23issuecomment-2D564716783&d=DwMFaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=Xb3JEn5aFJwN-vqzgAM--zbHyskwYI5OyPxqOYbyCwU&s=cMkCeYhkGF7XWvcQRR6K_vcdTSfBFNYLrjEKW_1RLLs&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM6QASFATKAYU2Z7W7T66ODQYFD3HANCNFSM4JZUGDJQ&d=DwMFaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=Xb3JEn5aFJwN-vqzgAM--zbHyskwYI5OyPxqOYbyCwU&s=zM1dokYj3BtHytEvlxO5Zvr6tousXKsKtNX_RAx1bk4&e=.

@awatt-cox Thanks for the info. From our testing with react native applications running 0.6x.x our package is automatically linked without needing to manually add the package. We'll investigate this with RN 0.61.2 and see if we need to make changes to our install instructions.
Thanks for bringing this to our attention.

Hi Nick,
Thanks for looking into this so quickly. We’re adding this to a mature existing project, so it’s possible that:

It isn’t automatically adding because of some peculiarity in our project.
We already have about 15 other packages installed in Android, so maybe your script isn’t able to auto-add them to what we already have.

Thanks again!
Andy
From: Nick Porter<EMAIL_ADDRESS>Reply-To: adobe/react-native-acpcore<EMAIL_ADDRESS>Date: Wednesday, December 11, 2019 at 4:21 PM
To: adobe/react-native-acpcore<EMAIL_ADDRESS>Cc: "Watt, Andy (CAI - Atlanta)"<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [adobe/react-native-acpcore] Installation instructions are missing important steps for Android (#54)
@awatt-coxhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_awatt-2Dcox&d=DwMCaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=SPc09s6euQL_2v4dbtq16DlDeIqjW1k0At0tK3MwYQg&s=iJ1tEbDHckIbYTRM1XJ4ZmDITaTIKJ6IcF8HKGQSdSQ&e= Thanks for the info. From our testing with react native applications running 0.6x.x our package is automatically linked without needing to manually add the package. We'll investigate this with RN 0.61.2 and see if we need to make changes to our install instructions.
Thanks for bringing this to our attention.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_adobe_react-2Dnative-2Dacpcore_issues_54-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAM6QASD7KCQ34HIHWR3Z66LQYFKU7A5CNFSM4JZUGDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGUTQSA-23issuecomment-2D564738120&d=DwMCaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=SPc09s6euQL_2v4dbtq16DlDeIqjW1k0At0tK3MwYQg&s=nHDW8ZKixtp1KX_q2uCXsxZlOscs2SommJopmvi7gaY&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AM6QASEJ6DDWQUPYR553Y3LQYFKU7ANCNFSM4JZUGDJQ&d=DwMCaQ&c=hrETxhO8sRCXAcJITi-bu62jJ43QQVS6-BatTNT-3bs&r=XohlwYHkV2j09EA4lSSxWXCaAQLRiCfdt4b9SesGMXE&m=SPc09s6euQL_2v4dbtq16DlDeIqjW1k0At0tK3MwYQg&s=NRc3Sp-TGCfyMo4wqqs0N3fz-wMUVxf5wgTiZYwHXgc&e=.

@awatt-cox I took some time to look into this and I wasn't able to reproduce this issue with RN 0.61.2. I'm guessing there may be some compatibility issues with your mature project and the auto linking feature for Android. I've linked a repo with an app that I tried to reproduce the issue in.
It may be helpful to take a look at the auto-generated getPackages() implementation in the new app.
https://github.com/nporter-adbe/gitissue54/blob/master/android/app/src/main/java/com/gitissue54/MainApplication.java#L30
Thanks for opening this issue, maybe we should add these steps into our trouble shooting section in the README.
Repo: https://github.com/nporter-adbe/gitissue54


Form validation errors on Sign Up and Login pages

I found a bug where the frontend errors out when you press the submit button on empty fields for the login and sign up pages.
Here is a gif of the error for the sign up page. The same error occurred with login page as well.

Yep, thanks for reporting and you're right that this should be fixed.  Will accept a PR as long as the frontend code is "Prettified".

Here is a prettified fix: #101


allow changing the owner via the canvas

would like to use the canvas ui to change the owner instead of using the json. easier when the json file is large.

That's a neat idea, but I'm not looking to make the Canvas interactive in any way (other than tooltips). Data goes in as JSON and gets displayed in the Canvas only.
(Feel free to fork and add the behavior you're describing though!)


[191] Update rust to v1.70.0 to fix tokenizers build

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Fixes # (issue).
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

No longer Needed


fixes caching issue causing IB error No security definition has been …

…found for the request
Cause: Caching is set up in the InteractiveBrokersBroker.cs for symbon contract details. When the caching was queried it was only using the IB Symbol String eg "AAPL" rather than an identifier that considers if the contract that is being looked up is an equity, option etc. PR uses contract.ToString() rather than contract.Symbol. contract.ToString() has additional data such as "OPT AAPL USD Smart"
Fixes issue in https://trello.com/c/P8ef0zoD/2016-live-ib-paper-no-security-definition-has-been-found-for-the-request

Thank you for the PR;
Potentially the ToString() its generating still isn't sufficiently unique and it could cause other latent bugs; could you update it to generate a unique string/hash from the contract data? Maybe something like:
private string GetUniqueKey(Contract contract) {
   return string.Format("{0} {1} {2}", contract.ToString(), contract.Strike, contract.Expiration);
}

Welcome other suggestions

Added Expiration, Right and Strike to unique key


add pcap-http-extractor to ironbank

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/unzip:<IP_ADDRESS>94
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/unzip/tags
Get started by pulling the image:
docker pull devdemisto/unzip:<IP_ADDRESS>94

Docker Metadata

Image Size: 26.47 MB

Image ID: sha256:e42c2007c93ad23a958db7a234d67acc9766707bfb53e13c7fa689cd17b2f485

Created: 2021-12-30T09:35:30.923649745Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.9.7
PYTHON_PIP_VERSION=21.2.4
PYTHON_SETUPTOOLS_VERSION=57.5.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/c20b0cfd643cd4a19246ccf204e2997af70f6b21/public/get-pip.py
PYTHON_GET_PIP_SHA256=fa6f3fb93cce234cd4e8dd2beb54a51ab9c247653b52855a48dd44e6b21ff28b
DOCKER_IMAGE=devdemisto/unzip:<IP_ADDRESS>94

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:d1b76fe2faa3735a432711afe3e97015ded5da13
org.opencontainers.image.version:<IP_ADDRESS>94

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/pcap-http-extractor:<IP_ADDRESS>95
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/pcap-http-extractor/tags
Get started by pulling the image:
docker pull devdemisto/pcap-http-extractor:<IP_ADDRESS>95

Docker Metadata

Image Size: 96.88 MB

Image ID: sha256:276b13396649509b020e67ac139df21235d04f000b46cbd51f6aa5a3d634a522

Created: 2021-12-30T09:38:35.69249344Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.9.7
PYTHON_PIP_VERSION=21.2.4
PYTHON_SETUPTOOLS_VERSION=57.5.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/c20b0cfd643cd4a19246ccf204e2997af70f6b21/public/get-pip.py
PYTHON_GET_PIP_SHA256=fa6f3fb93cce234cd4e8dd2beb54a51ab9c247653b52855a48dd44e6b21ff28b
DOCKER_IMAGE=devdemisto/pcap-http-extractor:<IP_ADDRESS>95

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:90d973c476ccf876033e48d6d41fdf2e1e5ca526
org.opencontainers.image.version:<IP_ADDRESS>95

pcap-http-extractor: https://repo1.dso.mil/dsop/opensource/palo-alto-networks/demisto/pcap-http-extractor/-/pipelines/626970

Docker Image Ready - Dev
Docker automatic build at CircleCI has deployed your docker image: devdemisto/pcap-http-extractor:<IP_ADDRESS>96
It is available now on docker hub at: https://hub.docker.com/r/devdemisto/pcap-http-extractor/tags
Get started by pulling the image:
docker pull devdemisto/pcap-http-extractor:<IP_ADDRESS>96

Docker Metadata

Image Size: 96.88 MB

Image ID: sha256:6141ee41293b16526df0afa3bdcae3a5327b7bfabee22dec1c2053f87261861e

Created: 2021-12-30T09:54:18.826049292Z

Arch: linux/amd64

Command: ["python3"]

Environment:

PATH=/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
LANG=C.UTF-8
GPG_KEY=E3FF2839C048B25C084DEBE9B26995E310250568
PYTHON_VERSION=3.9.7
PYTHON_PIP_VERSION=21.2.4
PYTHON_SETUPTOOLS_VERSION=57.5.0
PYTHON_GET_PIP_URL=https://github.com/pypa/get-pip/raw/c20b0cfd643cd4a19246ccf204e2997af70f6b21/public/get-pip.py
PYTHON_GET_PIP_SHA256=fa6f3fb93cce234cd4e8dd2beb54a51ab9c247653b52855a48dd44e6b21ff28b
DOCKER_IMAGE=devdemisto/pcap-http-extractor:<IP_ADDRESS>96

Labels:

org.opencontainers.image.authors:Demisto<EMAIL_ADDRESS>org.opencontainers.image.revision:7d78e97ad17c0ad610e9186e9412384401612d4a
org.opencontainers.image.version:<IP_ADDRESS>96

pcap-http-extractor: https://repo1.dso.mil/dsop/opensource/palo-alto-networks/demisto/pcap-http-extractor/-/pipelines/626972


Space in folder name prevents tests from running

The used Test Adapter version
1.2.0 (Pre Release/Master branch)
The used Godot version
v4.2.1.stable.mono.official [b09f793f5]
Operating System
Windows 11
Describe the bug
I expected the test runner to run the tests regardless of the folder path and give me results back. Instead the runner fails to run any tests and just opens the Godot editor with a modal window on top that is shown below

Steps to Reproduce
Download this repo to a folder path with no spaces in it, I downloaded it to C:\Temp\gdUnit4Net-master. Open the example scene in the Godot editor (I believe this was required?), then build the whole solution either from the command line or IDE. Add the GODOT_BIN to the .runsettings file and run the tests from commandline or IDE. Example shown below

PS C:\Temp\gdUnit4Net-master\example> dotnet test -s ..runsettings
Determining projects to restore...
All projects are up-to-date for restore.
exampleProject -> C:\Temp\gdUnit4Net-master\example.godot\mono\temp\bin\Debug\exampleProject.dll
Test run for C:\Temp\gdUnit4Net-master\example.godot\mono\temp\bin\Debug\exampleProject.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Failed failed [12 ms]
Error Message:
Expecting: 'True' but is 'False'
Stack Trace:
at Examples.ExampleTest.failed() in C:\Temp\gdUnit4Net-master\example\test\ExampleTest.cs:line 19
Html test results file : C:\Temp\gdUnit4Net-master\example\TestResults\test-result.html
WARNING: Overwriting results file: C:\Temp\gdUnit4Net-master\example\TestResults\test-result.trx
Results File: C:\Temp\gdUnit4Net-master\example\TestResults\test-result.trx
Failed!  - Failed:     1, Passed:     1, Skipped:     0, Total:     2, Duration: 15 ms - exampleProject.dll (net8.0)

Change the folder path to contain a space and the test run fails with the modal window shown previously

PS C:\Temp\gdUnit4Net-master space\example> dotnet test -s ..runsettings
Determining projects to restore...
All projects are up-to-date for restore.
exampleProject -> C:\Temp\gdUnit4Net-master space\example.godot\mono\temp\bin\Debug\exampleProject.dll
Test run for C:\Temp\gdUnit4Net-master space\example.godot\mono\temp\bin\Debug\exampleProject.dll (.NETCoreApp,Version=v8.0)
Microsoft (R) Test Execution Command Line Tool Version 17.9.0 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
No test is available in C:\Temp\gdUnit4Net-master space\example.godot\mono\temp\bin\Debug\exampleProject.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.
Html test results file : C:\Temp\gdUnit4Net-master space\example\TestResults\test-result.html
WARNING: Overwriting results file: C:\Temp\gdUnit4Net-master space\example\TestResults\test-result.trx
Results File: C:\Temp\gdUnit4Net-master space\example\TestResults\test-result.trx

Minimal reproduction project
No response

Thanks for reporting, I will take tomorrow a look what goes wrong here.


Cycle error using for_each with multiple providers example

Description
Hi,
I am experiencing a cycle error as reported in three other issues (https://github.com/terraform-aws-modules/terraform-aws-acm/issues/138, https://github.com/terraform-aws-modules/terraform-aws-acm/issues/131, https://github.com/terraform-aws-modules/terraform-aws-acm/issues/121) but all conversations have been locked and closed without resolution. What has been glanced over is the fact that this module is being used in for_each which is a standard feature in terraform for modules, but when implementing the example for two providers, a cycle error is produced.
I understand why it's cycling (because both modules are dependent on the output from the other) but I'm wondering if there is a way to support this multi-provider use-case in the module itself so we don't need to use two separate ones which introduce this issue. Given there's been multiple issues about this, I feel that using separate DNS provider from the ACM provider is a common enough use-case.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 4.5.0

Terraform version: 1.5.6

Provider version(s):

provider registry.terraform.io/hashicorp/aws v5.34.0

Reproduction Code [Required]
Format for additional_wildcard_cert_domains
additional_wildcard_cert_domains = {
  "domain1" = "zone_id1"
  "domain2" = "zone_id2"
}

module "additional_legacy_acm" {
  source   = "terraform-aws-modules/acm/aws"
  version  = "~> 4.0"
  for_each = var.additional_wildcard_cert_domains

  providers = {
    aws = aws.acm
  }

  domain_name = each.key
  zone_id     = each.value

  # Hardcode wildcard
  subject_alternative_names = [
    "*.${each.key}"
  ]

  validation_method       = "DNS"
  create_route53_records  = false
  validation_record_fqdns = module.route53_records[each.key].validation_route53_record_fqdns

  tags = {
    Name = each.key
  }
}

module "route53_records" {
  source   = "terraform-aws-modules/acm/aws"
  version  = "~> 4.0"
  for_each = var.additional_wildcard_cert_domains

  providers = {
    aws = aws.legacy_dns
  }

  create_certificate          = false
  create_route53_records_only = true

  validation_method = "DNS"
  distinct_domain_names = module.additional_legacy_acm[each.key].distinct_domain_names
  zone_id               = each.value

  acm_certificate_domain_validation_options = module.additional_legacy_acm[each.key].acm_certificate_domain_validation_options
}

Expected behavior
I would expect to be able to use the example in a for_each or for the module to support multiple providers somehow. The use-case of passing in multiple domains is quite common, so not being able to use for_each is quite a burden.
Actual behavior
Error: Cycle: module.route53.module.route53_records.output.validation_domains (expand), module.route53.module.route53_records.output.distinct_domain_names (expand), module.route53.module.route53_records.aws_acm_certificate_validation.this, module.route53.module.route53_records.output.acm_certificate_arn (expand), module.route53.module.additional_legacy_acm.aws_acm_certificate_validation.this, module.route53.module.additional_legacy_acm.output.acm_certificate_arn (expand), module.route53.module.route53_records.var.acm_certificate_domain_validation_options (expand), module.route53.module.route53_records.local.validation_domains (expand), module.route53.module.route53_records.aws_route53_record.validation, module.route53.module.route53_records.output.validation_route53_record_fqdns (expand), module.route53.module.route53_records (close), module.route53.module.additional_legacy_acm.var.validation_record_fqdns (expand), module.route53.module.additional_legacy_acm (close), module.route53.module.route53_records.var.distinct_domain_names (expand), module.route53.module.route53_records.local.distinct_domain_names (expand)

I ended up just cloning this module to support multi provider, which involved setting an aws.acm provider alias for the acm resources and an aws.dns provider for the dns resource. Additionally adding a configuration_aliases block in the aws provider configuration in versions.tf, then I can instantiate the module like this:
locals {
  domains_zones = {
    "domain1"   = "zone1_id",
    "domain2" = "zone2_id"
  }
}

module "acm" {
  source   = "../../modules/acm"
  for_each = local.domains_zones

  providers = {
    aws.acm = aws.primary
    aws.dns = aws.legacy_dns
  }

  domain_name = each.key
  zone_id     = each.value

  subject_alternative_names = [
    "*.${each.key}",
  ]

  validation_method   = "DNS"
  wait_for_validation = true

  tags = {
    Name = each.key
  }
}

It is great that you have found the solution. I don't think that we need to bring providers configuration settings into the module itself, but we can have it added as example 3 here - https://github.com/terraform-aws-modules/terraform-aws-acm/blob/master/examples/complete-dns-validation/main.tf#L56-L60
Would you be able to open a PR there?

It is great that you have found the solution. I don't think that we need to bring providers configuration settings into the module itself, but we can have it added as example 3 here - https://github.com/terraform-aws-modules/terraform-aws-acm/blob/master/examples/complete-dns-validation/main.tf#L56-L60
Would you be able to open a PR there?

Sure I'll open a PR, thanks!

Another workaround we are using is to use validation resource outside of the module:
additional_wildcard_cert_domains = {
  "domain1" = "zone_id1"
  "domain2" = "zone_id2"
}

module "additional_legacy_acm" {
  source   = "terraform-aws-modules/acm/aws"
  version  = "~> 4.0"
  for_each = var.additional_wildcard_cert_domains

  providers = {
    aws = aws.acm
  }

  domain_name = each.key
  zone_id     = each.value

  # Hardcode wildcard
  subject_alternative_names = [
    "*.${each.key}"
  ]

  validation_method       = "DNS"
  create_route53_records  = false

  # Validate outside of the module
  wait_for_validation = false

  tags = {
    Name = each.key
  }
}

module "route53_records" {
  source   = "terraform-aws-modules/acm/aws"
  version  = "~> 4.0"
  for_each = var.additional_wildcard_cert_domains

  providers = {
    aws = aws.legacy_dns
  }

  create_certificate          = false
  create_route53_records_only = true

  validation_method = "DNS"
  distinct_domain_names = module.additional_legacy_acm[each.key].distinct_domain_names
  zone_id               = each.value

  acm_certificate_domain_validation_options = module.additional_legacy_acm[each.key].acm_certificate_domain_validation_options
}

resource "aws_acm_certificate_validation" "additional_legacy_acm" {
  for_each = local.additional_wildcard_cert_domains

  providers = {
    aws = aws.acm
  }

  certificate_arn         = module.additional_legacy_acm[each.key].acm_certificate_arn
  validation_record_fqdns = module.route53_records[each.key].validation_route53_record_fqdns
}


Fixed #35667 -- Improved deprecation warning handling by replacing stacklevel with skip_file_prefixes.

Trac ticket number

ticket-35667
Branch description
Improved the handling of deprecation warnings by replacing the use of stacklevel with skip_file_prefixes. This change ensures that deprecation warnings accurately reference the offending call site, enhancing clarity and maintainability. The update leverages the new warnings.warn(skip_file_prefixes: tuple[str] | None) feature introduced in Python 3.12, and includes a fallback mechanism for compatibility with Python 3.11.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[x] I have checked the "Has patch" ticket flag in the Trac system.
[x] I have added or updated relevant tests.
[ ] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

I'm opening a new PR to split the commits for review. https://github.com/django/django/pull/18683


Automatically add IDComponent to entities parsed via TiledMap.

Automatically add IDComponent to entities parsed via TiledMap.

Codecov Report

Merging #753 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                dev     #753      +/-   ##
============================================
+ Coverage     55.54%   55.55%   +<.01%
  Complexity     1894     1894
============================================
  Files           206      206
  Lines          9779     9780       +1
  Branches        856      856
============================================
+ Hits           5432     5433       +1
  Misses         4141     4141
  Partials        206      206

Impacted Files
Coverage Δ
Complexity Δ

...m/almasb/fxgl/entity/level/tiled/TMXLevelLoader.kt
82.06% <100%> (+0.09%)
39 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a887c1...c55709c. Read the comment docs.


the chat box should grow if the user types more than 1 line

Right now if you type in more than one line it starts scrolling

(will need to be handled in https://github.com/papercups-io/chat-window)


removing the keys from passport-js

@rvjain0510 make it work with .env.

@rvjain0510 any updates?


Registry management pages load slowly when misconfigured private repositories

Bug description
Registry management pages load slowly when misconfigured private repositories.
For example <IP_ADDRESS>:5000  private repositories that doesn't exist，See the log below，the page loads slowly because of timeout。

2018/10/30 10:37:21 http: proxy error: dial tcp <IP_ADDRESS>:5000: i/o timeout

Expected behavior
1.Configuration of incorrect private repositories is not allowed。
2.Even if the private repositories connection is abnormal, the registry management page load should not be affected.
Technical details:

Portainer version:1.19.2
Docker version (managed by Portainer):17.05.0-ce
Platform (windows/linux):linux

@xcbeyond what registry management features are you talking about?

@deviantony Registry management features is management features for private registries from feat56-private-registry-management 。#2215

This was simply a POC, please open issues only for the stable version (releases) of Portainer.


Update stable version in repo from 1.5.1 to 1.6.3

Think about update stable version to 1.6.3
Version: stable=1.5.1 (85 days old) => latest=1.6.3 (16 days old)
Installs: stable=517 (69.21%), latest=79 (10.58%), total=747
Click to use developer portal
Click to edit
Note: This is an automatically generated message and not personally authored by bluefox!
Do not close this issue manually as a new issue will be created if condition for update still exists
@mcm1957 for evidence

Just for Info - everything OK from your side. Nightly update seems to have failed so checker created a new issue. Will beclosed automatically as soon as update is public.

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 1.6.3 but the current stable version is already 1.6.3.
So this issue should be closed.
@mcm1957 for evidence


Incorrection compilation for target es2017 when compiling swc

Describe the bug
When compiling the file with swc and tsc, the program ouput is different.
The output is different than the file compiled by<EMAIL_ADDRESS>with the following tsconfig:
{
  "compilerOptions": {
    "module": "commonjs",
    "lib": ["dom",  "es2017" ],
    "target": "es2017",
  },
}

Input code
class Test {
  a
}
const x = new Test()
Object.defineProperty(x, 'a', {
  get: function () {
    console.log('get a')
  },
  set: function () {
    console.log('set a')
  },
})

console.log(Object.values(x))

Config
{
  "module": { "type": "commonjs" },
  "jsc": {
    "target": "es2017",
    "parser": {
      "syntax": "typescript",
    },
  }
}

Playground link (or link to the minimal reproduction)
https://play.swc.rs/?version=1.4.9-nightly-20240316.1&code=H4sIAAAAAAAAA42OQQrCMBBF93OKv0sCoQcQPIMuvECM01IJiXRSTZHc3RhcdOlm4M%2Bb9xkfnAguLBlvAhxV8im2VHBE5FdH2tDpemefhxuPc%2BTzkh685E0XC%2BWU7erE%2BYBxjT7PKUKbvgS%2BbSnwENKkVbuBU6aBatuQPxTZK9UQ7envq6cLK4suxtAHMkg6L9AAAAA%3D&config=H4sIAAAAAAAAA1VPSQ7DIAy88wrkcw9tL5X6hz4CUSciYhN2pKIofw%2BkkDY3exbPeBFSwkQannIpY1miSoTp2AtC2bP6FAQ4RySdTGS4dJapUoOyhDu0fhlglUbk6kK6X2%2BP5gAbAmF3NMwZb4b8n6mDiwmJzsIqVX60eE4ULRVceM872X6pfWuDcs0FPxH8lD3xuA6GXt3OaUaxbpEWNA8cAQAA
SWC Info output
No response
Expected behavior
The expected output for this program should be
[]

Actual behavior
get a
[ undefined ]

Version
1.4.8
Additional context
Oddly enough, when running with the latest ts-node (10.9.2), the output is identical to when compiling with tsc, while<EMAIL_ADDRESS>has the wrong output

https://swc.rs/docs/migrating-from-tsc#usedefineforclassfields


import-order request: order by default import name

At my workplace we use default exports extensively and prefer to order my imports by the name we assign to the default exports. Example:
// Incorrect
import foo from "bar";
import baz from "biz";

// Correct
import baz from "biz";
import foo from "bar";

Currently, there is no way to enforce this (as far as I can see). I believe an addition to the options given for ordered-imports would be useful for handling this case.

🤔 i find ordering by paths to be the most reliable order because it's deterministic, whereas your suggestion above is not (you can name default exports whatever you want).
i am not keen on this suggestions, but if you submit a PR then i will review it 👍

tech-wise, this should be an option on ordered-imports as you suggested.

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


server: Remove SSH dependencies

There are some Cargo.lock files that still use SSH to pull in dependencies
One example of it is server/inference-server/network/sgx/rpc/Cargo.lock
We should change them to use HTTPS

Noted, thanks for the report. Will be fixed ASAP

Fixed in commit 106a857ed52a20a62b879147b0440279ac8fa32f.


Some of the json files have floats not ints and structse need ints

To address this error. Cause the images contain floats.
Traceback (most recent call last):
File "..\scripts\convert-animation.py", line 48, in
f.write(struct.pack('B', 255*column[color]))
struct.error: required argument is not an integer

Merged, thanks for the fix!

I'm trying to get it running on a NodeMCU 0.9 but running into memory issues. I'm keen to build this out and you've done a LOT of the leg work already. Any advice around my memory issues. Maybe I've done something wrong


Modeling Heterogeneous Vehicle Link Characteristics in VRPSolver Easy Interface ?

Hi developers,
I have a question regarding the VRPSolver Easy Interface. Can we model heterogeneous fleets, like ground and air vehicles, with different characteristics for each link? For instance, the distance between two points for a ground vehicle (measured in road distance) may differ from that of an air vehicle (measured in Euclidian distance). This implies that each vehicle type has its unique link characterization. Is it possible to model such a scenario using the VRPSolverEasy Interface?

For the moment, we have incompatibilities only between vehicles and points. So, you need to duplicate not only arcs, but also points (still assigning them to a same client). Then you define incompatibilities between "ground" points and air vehicles, and between "air" point and ground vehicles.
In the future, we may add incompatibilities between vehicles and arcs to simplify modelling.


Pasting from excel creates a blank space in the last cell of the last row

Hi Paul,
I've noticed a strange behaviour: in pasting data from excel it creates an additional space in the last cell of the last column in the last row, it doesn't matter how many columns are pasted, the last one is affected with this additional space, even if it's only one cell.
Here a photo of the data I'm pasting from excel: data without spaces
And here a photo of the data pasted to a jexcel table: data with a unwanted space
If this can be solved, it could be amazing. By the way, great work man, very helpful!
PS: The capture is from one of the latest examples from your site https://bossanova.uk/jexcel/examples/table-with-fixed-headers
In local development I have the same issue.

It has been fixed. It is updated on the master repo.


Package updated with workbook(PR-5461)-Arista Awake Security

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@v-spadarthi  please see if we can close this PR.

Closing this PR as we have already raised new PR : https://github.com/Azure/Azure-Sentinel/pull/5651 and merged.


Library causing app to crash because of styles.xml file

The file app/src/main/res/values-v21/styles.xml is causing my app to crash because it's creating a style named "AppTheme" and setting it to a value that isn't working with my app. "AppTheme" is the default name for a style, so I had to rename everything in my project to get this to work. I shouldn't have to do this. I just don't think this file needs to be a part of your library project in the first place. I think it may be a relic of an earlier stage of development, before the UI part of the example app was pulled out into a separate module from the module that serves as the M2X library.
Can you delete this file, rebuild your library, and add a new release to the Maven repo, please? That way updating my app should be as simple as incrementing the version number of your library in my build file.
Thanks!

Hi @lillialexis, thanks for raising this issue.  As you posited, it looks like this is a relic from earlier development.  We will work on pulling this out and deploying a new release.  Thanks!