pilot upload failure undefined method `builds' for nil:NilClass

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Upload to testflight is failing
Complete output when running fastlane, including the stack trace and command used
undefined method `builds' for nil:NilClass
Successfully uploaded the new binary to iTunes Connect
INFO [2016-09-23 14:14:09.23]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
INFO [2016-09-23 14:14:09.23]: Waiting for iTunes Connect to process the new build
INFO [2016-09-23 14:14:41.48]: Waiting for iTunes Connect to finish processing the new build (0.0.24 - 0.0.24)
INFO [2016-09-23 14:15:13.21]: Waiting for iTunes Connect to finish processing the new build (0.0.24 - 0.0.24)
WARN [2016-09-23 14:15:46.33]: Variable Dump:
INFO [2016-09-23 14:15:46.33]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios deploy", :CORDOVA_APP_ID=>"my.app.id", :SIGH_PROFILE_TYPE=>"app-store", :CORDOVA_APP_NAME=>"app", :IPA_OUTPUT_PATH=>"app.ipa", :DSYM_OUTPUT_PATH=>"path.app.app.dSYM.zip", :XCODEBUILD_ARCHIVE=>"app 2016-09-23 14.13.15.xcarchive"}
ERROR [2016-09-23 14:15:46.33]: undefined method `builds' for nil:NilClass
INFO [2016-09-23 14:15:46.33]:

/usr/local/lib/ruby/gems/2.3.0/gems/pilot-1.10.0/lib/pilot/build_manager.rb:142:in `wait_for_processing_build': [!] undefined method `builds' for nil:NilClass (NoMethodError)
       	from /usr/local/lib/ruby/gems/2.3.0/gems/pilot-1.10.0/lib/pilot/build_manager.rb:34:in `upload'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/actions/pilot.rb:18:in `run'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:202:in `block (2 levels) in execute_action'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:187:in `block in execute_action'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:186:in `chdir'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:186:in `execute_action'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:112:in `trigger_action_by_name'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/fast_file.rb:140:in `method_missing'
       	from Fastfile:191:in `block (2 levels) in parsing_binding'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/lane.rb:33:in `call'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:165:in `try_switch_to_lane'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:120:in `trigger_action_by_name'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/fast_file.rb:140:in `method_missing'
       	from Fastfile:142:in `block (2 levels) in parsing_binding'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/lane.rb:33:in `call'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:49:in `block in execute'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:45:in `chdir'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/runner.rb:45:in `execute'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/command_line_handler.rb:30:in `handle'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/commands_generator.rb:49:in `block (2 levels) in run'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/command.rb:178:in `call'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/command.rb:153:in `run'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/runner.rb:444:in `run_active_command'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane_core-0.52.0/lib/fastlane_core/ui/fastlane_runner.rb:36:in `run!'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.4.0/lib/commander/delegates.rb:15:in `run!'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/commands_generator.rb:246:in `run'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/commands_generator.rb:20:in `start'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/lib/fastlane/cli_tools_distributor.rb:58:in `take_off'
       	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-1.104.0/bin/fastlane:5:in `<top (required)>'
       	from /usr/local/bin/fastlane:22:in `load'
       	from /usr/local/bin/fastlane:22:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
require 'yaml'
require 'ostruct'

fastlane_version "1.68.0"

default_platform :ios

# Load configuration
config_file = File.expand_path("config.yml")
begin
  config = YAML.load(open(config_file))
rescue
  Helper.log.error "Config file not found"
  Helper.log.error "Please add a config.yml file in your fastlane directory"
  Helper.log.error "Check http://github.com/platanus/fastlane-base for information"
  Helper.log.error "about the structure of the config file"
  exit 1
end

config = OpenStruct.new(config)
if config.stages.nil?
  Helper.log.error "Required key missing (stages)"
  Helper.log.error "Please add a stages key with the stages you want to define"
  exit 1
end

# Public methods

def cordova_project_path
  "platforms/ios/#{app_name_sanitized}.xcodeproj"
end

# http://stackoverflow.com/questions/1939333/how-to-make-a-ruby-string-safe-for-a-filesystem
def app_name_sanitized
  cordova_get_app_name.gsub(/[^0-9A-Za-z.\-]/, '_')
end

def cordova_plist_path
  "#{app_name_sanitized}/#{app_name_sanitized}-Info.plist"
end

def app_name_for(environment)
  if environment == "production"
    cordova_get_app_name
  else
    "#{cordova_get_app_name} - #{environment.capitalize}"
  end
end

def app_id_for(environment)
  if environment == "production"
    cordova_get_app_id
  else
    "#{cordova_get_app_id}.#{environment}"
  end
end

# Lanes
platform :ios do
  before_all do
    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."

    # increment_build_number

    # xctool # run the tests of your app
  end

  desc "Create app ids for each of the stages"
  lane :create do |options|
    config.stages.each_key do |stage|
      stage_config = config.stages[stage]
      app_name = app_name_for(stage)
      app_id = app_id_for(stage)
      produce(
        username: stage_config["apple_id"],
        team_id: stage_config["team_id"],
        app_identifier: app_id,
        app_name: app_name
      )
    end
  end

  desc "Create necessary profiles and certificates"
  lane :certs do
    config.stages.each_key do |stage|
      app_id = app_id_for(stage)
      stage_config = config.stages[stage]

      %w(appstore development).each do |sign_type|
        match(
          username: stage_config["apple_id"],
          team_id: stage_config["team_id"],
          app_identifier: app_id,
          git_url: stage_config["certificates_url"],
          type: sign_type
        )
      end
    end
  end

  desc "READ necessary profiles and certificates"
    lane :certsRead do
      config.stages.each_key do |stage|
        app_id = app_id_for(stage)
        stage_config = config.stages[stage]

        %w(appstore development).each do |sign_type|
          match(
            username: stage_config["apple_id"],
            team_id: stage_config["team_id"],
            app_identifier: app_id,
            git_url: stage_config["certificates_url"],
            type: sign_type,
            readonly: true
          )
        end
      end
    end

  desc "Enable app services services"
  desc "Params:"
  desc "[enable|disable]:[services,...] to enable or disable a service"
  lane :service do |options|
    config.stages.each_key do |stage|
      options[:stage] = stage
      update_services(options)

      services_to_enable = options[:enable];

      if services_to_enable
        push_certs(options) if options[:enable].match /push/
      end
    end
  end

  desc "Upload only app to testflight or appstore"
  desc "Params:"
  desc "to: [apstore, testflight] Deployment destination"
  desc "stage: Application build environment"
  lane :deploy do |options|
    if options[:to] == 'testflight'
      do_testflight(options)
    elsif options[:to] == 'appstore'
      do_appstore(options)
    end
  end

  desc "Deploy as well to testflight or appstore"
    desc "Params:"
    desc "to: [apstore, testflight] Deployment destination"
    desc "stage: Application build environment"
    lane :deployToTesters do |options|
      if options[:to] == 'testflight'
        do_testflightDeploy(options)
      elsif options[:to] == 'appstore'
        do_appstore(options)
      end
    end

  private_lane :build do |options|

    stage = options[:stage]
    stage_config = config.stages[stage]
    app_id = app_id_for(stage)

    match(
      username: stage_config["apple_id"],
      team_id: stage_config["team_id"],
      app_identifier: app_id,
      git_url: stage_config["certificates_url"],
      type: "appstore",
      readonly: true
    )

    sh "cordova prepare --env=#{stage}"

    update_app_identifier(
      xcodeproj: cordova_project_path,
      plist_path: cordova_plist_path,
      app_identifier: app_id
    )

    recreate_schemes(
      project: cordova_project_path
    )

    gym(
      verbose: true,
      project: cordova_project_path,
      scheme: app_name_sanitized,
      xcconfig: "platforms/ios/cordova/build-release.xcconfig"
    )
  end

  desc "Upload to testflight"
  private_lane :do_testflight do |options|
    stage = options[:stage]
    stage_config = config.stages[stage]
    app_id = app_id_for(stage)

    build(options)

    pilot(
      username: stage_config["apple_id"],
      team_id: stage_config["team_id"],
      app_identifier: app_id,
      skip_submission: true
    )
  end

  desc "Upload to testflight and deploy to testers"
    private_lane :do_testflightDeploy do |options|
      stage = options[:stage]
      stage_config = config.stages[stage]
      app_id = app_id_for(stage)

      build(options)

      pilot(
        username: stage_config["apple_id"],
        team_id: stage_config["team_id"],
        app_identifier: app_id,
        skip_submission: false
      )
    end

  desc "Upload the appstore"
  private_lane :do_appstore do |options|
    stage = options[:stage]
    stage_config = config.stages[stage]
    app_id = app_id_for(stage)

    build(options)

    deliver(
      username: stage_config["apple_id"],
      team_id: stage_config["team_id"],
      app_identifier: app_id,
      force: true,
      submit_for_review: false,
      skip_metadata: true,
      skip_screenshots: true
    )
  end

  desc "Update services using produce"
  private_lane :update_services do |options|
    stage = options[:stage]
    stage_config = config.stages[stage]
    app_id = app_id_for(stage)

    %w(enable disable).each do |state|
      next unless services = options[state.to_sym]

      produce_service(
        action: state,
        app_identifier: app_id,
        username: stage_config['apple_id'],
        team_id: stage_config['team_id'],
        services: services.split(",")
      )
    end
  end

  desc "Runs produce cli services to enable and disable"
  private_lane :produce_service do |options|
    command = []
    command << "produce #{options[:action]}_services"
    command << "--app_identifier #{options[:app_identifier]}"
    command << "--username #{options[:username]}"
    command << "--team_id #{options[:team_id]}"
    options[:services].each do |service|
      command << "--#{service}"
    end
    sh command.join(' ')
  end

  desc "Create and upload the push certificates"
  private_lane :push_certs do |options|
    stage = options[:stage]
    stage_config = config.stages[stage]
    app_id = app_id_for(stage)
    sandbox = stage != 'production'
    development = (stage =~ /staging|production/).nil?

    pem(
      app_identifier: app_id,
      username: stage_config['apple_id'],
      team_id: stage_config['team_id'],
      development: development,
      generate_p12: false,
      save_private_key: false,
      output_path: "./fastlane",
      new_profile: proc do |profile_path|
        require 'openssl'
        require 'aws-sdk'

        pem = File.read(profile_path)
        pkey = OpenSSL::PKey::RSA.new(pem)
        cert = OpenSSL::X509::Certificate.new(pem)

        Aws.config[:region] = 'us-east-1'
        sns = Aws::SNS::Client.new

        resp = sns.create_platform_application({
          name: app_id,
          platform: sandbox ? 'APNS_SANDBOX' : 'APNS',
          attributes: { # required
            'PlatformCredential' => pkey.to_s,
            'PlatformPrincipal' => cert.to_s
          }
        })

        puts "------------------ A new Application was created in AWS SNS ------------------ ".yellow
        puts "Application Name: #{app_id}".yellow
        puts "Application ARN: #{resp.platform_application_arn}".yellow
      end
    )
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

platform :android do
  before_all do
    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
  end

  desc "Runs all the tests"
  lane :test do
    gradle(task: "test")
  end

  desc "Submit a new Beta Build to Crashlytics Beta"
  lane :beta do
    gradle(task: "assembleRelease")
    crashlytics

    # sh "your_script.sh"
    # You can also use other beta testing services here
  end

  desc "Deploy a new version to the Google Play"
  lane :deploy do
    gradle(task: "assembleRelease")
    supply
  end

  desc "Deploy a beta to the Google Play"
  lane :deployBeta do
    # TODO make this nice and dynamic + load as well from config.yml
    #config.json_key_file
    #config.package_name

    sh 'supply -p at.faktorzehn.eule -a alpha --json_key googlePlay_e93f68bb7e4c.json --verbose -b ../Eule.apk'
    --apk
    supply -p
  end

  # You can define as many lanes as you want

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

# More information about multiple platforms in fastlane: https://github.com/KrauseFx/fastlane/blob/master/docs/Platforms.md
# All available actions: https://github.com/KrauseFx/fastlane/blob/master/docs/Actions.md

Environment
fastlane version (run fastlane -v):
1.104.0
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)?
no
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)?
no

Hi @geoHeil Thanks for reaching out. Does the build appear on iTunes connect after this? Thanks!

@geoHeil  catch same issue, after receive mail from apple

This app attempts to access privacy-sensitive data without a usage description. The app's Info.plist must contain an NSPhotoLibraryUsageDescription key with a string value explaining to the user how the app uses this data.

add this key, and all work done.

Hi, I was getting the same error but also got an email from Apple but mine was related to NSCalendarsUsageDescription in the plist. I've added this and successfully submitted to TestFlight.

@geoHeil Did you get up and running? Thanks!

@TKBurner unfortunately it did not show up. I got an E-Mail from Apple only when submitting via XCode

I think I found the cause - cannot finally confirm it yet:
CAMERA_USAGE_DESCRIPTION in cordova.xml is not correctly / not at all transferred to the info.plist

somehow the web view is not updated from the GitHub e-mails.
regarding the strange / long string: according to https://github.com/apache/cordova-plugin-camera NSCameraUsageDescription is correct.
The problem for me was some caching issues -> I still got the old plugin.

Yes. But not on all computers see the other issue with the wwdr
certificate.
Todd Burner<EMAIL_ADDRESS>schrieb am Di. 27. Sep. 2016 um
22:42:

@geoHeil https://github.com/geoHeil Did you get up and running? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fastlane/fastlane/issues/6267#issuecomment-249991955,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnc9FbQ29H0Vx0p0BVlwIjNfRB2b3yQks5quX-agaJpZM4KE6qE
.

@geoHeil Glad to hear you got up and running!Let me know if you run into any more issues.


429 errors are returning an empty set of headers

Describe the bug
A clear and concise description of what the bug is.
Your code
Share a complete minimal working example.
Expected behavior
A clear and concise description of what you expected to happen.
Output
Paste and format errors (with complete stacktrace) or logs. Make sure to remove sensitive information.
Environment:

OS: [e.g. Windows, Mac]
Python version [e.g. 3.7.0]
spotipy version [e.g. 2.12.0]
your IDE (if using any) [e.g. PyCharm, Jupyter Notebook IDE, Google Colab]

Additional context
Add any other context about the problem here.

Please do not leave the placeholder text in the post. Delete it, if necessary.


APT whitelist request for cucumber

I have tried getting Cucumber to run on containers, but are having problems.


Fix index out of bound bug and standardise naming of index across item command

Codecov Report

Merging #282 (62d5418) into master (556a75a) will not change coverage.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage     69.48%   69.48%
  Complexity      596      596
=========================================
  Files           117      117
  Lines          2078     2078
  Branches        220      220
=========================================
  Hits           1444     1444
  Misses          550      550
  Partials         84       84

Impacted Files
Coverage Δ

...odrem/logic/commands/itemcommands/ViewCommand.java
9.09% <0.00%> (ø)

...rem/logic/commands/itemcommands/DeleteCommand.java
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Tenant qualify URLs of the Authentication Endpoint JSP web app

Description:
The current inbound/outbound paths of the Authentication Endpoint webapps do not have the tenant domain as a path parameter. This task will tenant-qualify the inbound and outbound paths by appending the tenant domain as follows,
eg: localhost:9443/t/{tenant.domain}/authenticationendpoint/...
The implementation of this feature consists of the following tasks,

[x] Allow webapps to be accessed in normal tenant context: https://github.com/wso2/product-is/issues/7998
[x] Tenant qualifying inbound paths to the Authentication endpoint: https://github.com/wso2/product-is/issues/8031
[x] Tenant qualifying outbound paths from the Authentication endpoint: https://github.com/wso2/product-is/issues/8027
[x]  Rewriting URLs with tenant contexts for internal processing: https://github.com/wso2/product-is/issues/8026
[x] Enabling the webapp to capture and apply filters to dispatcher forwards made internally: https://github.com/wso2/product-is/issues/8001

Done


Update RevisionSpec and duck apis to v1 for Knative 0.9 vendor

What this PR does / why we need it:
This is an api migration pr for the Knative 0.9 vendor #543
Special notes for your reviewer:

@animeshsingh @jinchihe I did some initial changes to migrate the necessary apis from v1beta1 to v1. However, I would like to get some help on some of the nil pointer errors since I'm not very familiar with the new apis. Thank you very much in advance.

Below are the list of errors I got from my unit tests.
(py3) Tommys-MacBook-Pro:kfserving tommyli$ make test
go generate ./pkg/... ./cmd/...
hack/update-codegen.sh
Generating deepcopy funcs
Generating clientset for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/clientset
Generating listers for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/listers
Generating informers for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/informers
hack/update-openapigen.sh
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
hack/verify-golint.sh
Congratulations!  All Go source files have been linted.
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd --output-dir=config/default/crds
CRD files generated, files can be found under path config/default/crds.
kustomize build config/default/crds -o config/default/crds/serving_v1alpha2_inferenceservice.yaml
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go rbac --output-dir=config/default/rbac
RBAC manifests generated under 'config/default/rbac' directory
go test ./pkg/... ./cmd/... -coverprofile cover.out
?   	github.com/kubeflow/kfserving/pkg/apis	[no test files]
?   	github.com/kubeflow/kfserving/pkg/apis/serving	[no test files]
F1114 16:21:24.233090    2511 v1alpha2_suite_test.go:61] failed to start the controlplane. retried 5 times
FAIL	github.com/kubeflow/kfserving/pkg/apis/serving/v1alpha2	0.862s
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/typed/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/typed/serving/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/serving	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/listers/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/constants	[no test files]
?   	github.com/kubeflow/kfserving/pkg/controller	[no test files]
F1114 16:21:25.283692    2515 suite_test.go:37] failed to start the controlplane. retried 5 times
FAIL	github.com/kubeflow/kfserving/pkg/controller/inferenceservice	1.471s
?   	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/reconcilers/istio	[no test files]
F1114 16:21:24.969130    2513 suite_test.go:34] failed to start the controlplane. retried 5 times
FAIL	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/reconcilers/knative	1.329s
--- FAIL: TestS3CredentialBuilder (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1e49003]

goroutine 58 [running]:
testing.tRunner.func1(0xc000752400)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:874 +0x3a3
panic(0x1f9bc20, 0x2f52ad0)
	/usr/local/Cellar/go/1.13.4/libexec/src/runtime/panic.go:679 +0x1b2
github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials.TestS3CredentialBuilder(0xc000752400)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/service_account_credentials_test.go:151 +0x743
testing.tRunner(0xc000752400, 0x21da208)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:960 +0x350
FAIL	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials	1.154s
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/azure	0.267s	coverage: 100.0% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/gcs	0.345s	coverage: 100.0% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/s3	0.607s	coverage: 96.3% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/istio	0.494s	coverage: 81.6% of statements
E1114 16:21:25.848751    2525 suite_test.go:37] failed to start the controlplane. retried 5 timesFailed to start testing panel
E1114 16:21:25.848863    2525 suite_test.go:41] must provide non-nil rest.Config to client.NewFailed to start client
--- FAIL: TestInferenceServiceToKnativeService (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1d154f6]

goroutine 105 [running]:
testing.tRunner.func1(0xc000478400)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:874 +0x3a3
panic(0x1f9e820, 0x2f57d80)
	/usr/local/Cellar/go/1.13.4/libexec/src/runtime/panic.go:679 +0x1b2
github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials.(*CredentialBuilder).CreateSecretVolumeAndEnv(0xc0000b53e0, 0x21484b7, 0x7, 0x214c9de, 0xa, 0xc00038f180, 0xc00011ace8, 0x0, 0x0)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/service_account_credentials.go:80 +0x96
github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative.(*ServiceBuilder).CreatePredictorService(0xc0003fc480, 0xc0005ba560, 0x17, 0x2145ef1, 0x5, 0x0, 0x0, 0x21484b7, 0x7, 0x0, ...)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative/service.go:147 +0x431
github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative.TestInferenceServiceToKnativeService(0xc000478400)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative/service_test.go:477 +0x1ddb
testing.tRunner(0xc000478400, 0x21dcb78)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:960 +0x350
FAIL	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative	1.276s
ok  	github.com/kubeflow/kfserving/pkg/logger	0.994s	coverage: 38.8% of statements
?   	github.com/kubeflow/kfserving/pkg/testing	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/utils	0.141s	coverage: 100.0% of statements
?   	github.com/kubeflow/kfserving/pkg/webhook	[no test files]
?   	github.com/kubeflow/kfserving/pkg/webhook/admission/inferenceservice	[no test files]
E1114 16:21:26.140392    2536 suite_test.go:37] failed to start the controlplane. retried 5 timesFailed to start testing panel
E1114 16:21:26.140498    2536 suite_test.go:41] must provide non-nil rest.Config to client.NewFailed to start client
--- FAIL: TestStorageInitializerInjector (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1b49e36]

goroutine 66 [running]:
testing.tRunner.func1(0xc0003c4600)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:874 +0x3a3
panic(0x1fa2c20, 0x2f61e30)
	/usr/local/Cellar/go/1.13.4/libexec/src/runtime/panic.go:679 +0x1b2
github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials.(*CredentialBuilder).CreateSecretVolumeAndEnv(0xc00018f680, 0x0, 0x0, 0x0, 0x0, 0xc0007b5608, 0xc00036bd08, 0x1, 0x8)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/service_account_credentials.go:80 +0x96
github.com/kubeflow/kfserving/pkg/webhook/admission/pod.(*StorageInitializerInjector).InjectStorageInitializer(0xc0007b5b38, 0xc00036bc00, 0xc0007abe48, 0xc00018f680)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/webhook/admission/pod/storage_initializer_injector.go:203 +0xd52
github.com/kubeflow/kfserving/pkg/webhook/admission/pod.TestStorageInitializerInjector(0xc0003c4600)
	/Users/tommyli/go/src/github.com/kubeflow/kfserving/pkg/webhook/admission/pod/storage_initializer_injector_test.go:278 +0x116c
testing.tRunner(0xc0003c4600, 0x21e2280)
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/Cellar/go/1.13.4/libexec/src/testing/testing.go:960 +0x350
FAIL	github.com/kubeflow/kfserving/pkg/webhook/admission/pod	1.167s
?   	github.com/kubeflow/kfserving/pkg/webhook/third_party	[no test files]
?   	github.com/kubeflow/kfserving/cmd/logger	[no test files]
?   	github.com/kubeflow/kfserving/cmd/manager	[no test files]
?   	github.com/kubeflow/kfserving/cmd/spec-gen	[no test files]
FAIL
make: *** [test] Error 1

Release note:

This change is

/assign @animeshsingh

@yuzisun anyone who can shed a light on knative duck-type (https://github.com/knative/pkg/tree/master/apis/duck) and the context its used in kfserving? It moved from beta in mature in knative0.9, but seems its breaking a lot of our tests like TestStorageInitializerInjector... etc.

@yuzisun anyone who can shed a light on knative duck-type (https://github.com/knative/pkg/tree/master/apis/duck) and the context its used in kfserving? It moved from beta in mature in knative0.9, but seems its breaking a lot of our tests like TestStorageInitializerInjector... etc.

this has nothing to do with knative 0.9, it is due to local mock apiserver/etcd not coming up.
E1114 16:21:26.140392    2536 suite_test.go:37] failed to start the controlplane. retried 5 timesFailed to start testing panel

thanks - that helps cc @Tomcli

@Tomcli did you install kubebuilder locally ?
https://github.com/kubeflow/kfserving/tree/master/test#prerequisite

Thanks @yuzisun, looks like I did not set up my kubebuilder under my PATH. So somehow it was not able to call the mock apis and etcd. After I set up my kubebuilder correctly, all my local tests have passed. Thank you!
New test outputs:
(py3) Tommys-MacBook-Pro:kfserving tommyli$ make test
go generate ./pkg/... ./cmd/...
hack/update-codegen.sh
Generating deepcopy funcs
Generating clientset for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/clientset
Generating listers for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/listers
Generating informers for serving:v1alpha2 at github.com/kubeflow/kfserving/pkg/client/informers
hack/update-openapigen.sh
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
hack/verify-golint.sh
Congratulations!  All Go source files have been linted.
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd --output-dir=config/default/crds
CRD files generated, files can be found under path config/default/crds.
kustomize build config/default/crds -o config/default/crds/serving_v1alpha2_inferenceservice.yaml
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go rbac --output-dir=config/default/rbac
RBAC manifests generated under 'config/default/rbac' directory
go test ./pkg/... ./cmd/... -coverprofile cover.out
?   	github.com/kubeflow/kfserving/pkg/apis	[no test files]
?   	github.com/kubeflow/kfserving/pkg/apis/serving	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/apis/serving/v1alpha2	27.577s	coverage: 53.7% of statements
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/typed/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/clientset/versioned/typed/serving/v1alpha2/fake	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/serving	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/informers/externalversions/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/client/listers/serving/v1alpha2	[no test files]
?   	github.com/kubeflow/kfserving/pkg/constants	[no test files]
?   	github.com/kubeflow/kfserving/pkg/controller	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice	14.026s	coverage: 62.2% of statements
?   	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/reconcilers/istio	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/reconcilers/knative	11.371s	coverage: 66.7% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials	11.787s	coverage: 83.3% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/azure	0.375s	coverage: 100.0% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/gcs	0.660s	coverage: 100.0% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/credentials/s3	0.424s	coverage: 96.3% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/istio	0.550s	coverage: 81.6% of statements
ok  	github.com/kubeflow/kfserving/pkg/controller/inferenceservice/resources/knative	10.895s	coverage: 53.0% of statements
ok  	github.com/kubeflow/kfserving/pkg/logger	1.563s	coverage: 38.8% of statements
?   	github.com/kubeflow/kfserving/pkg/testing	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/utils	0.201s	coverage: 100.0% of statements
?   	github.com/kubeflow/kfserving/pkg/webhook	[no test files]
?   	github.com/kubeflow/kfserving/pkg/webhook/admission/inferenceservice	[no test files]
ok  	github.com/kubeflow/kfserving/pkg/webhook/admission/pod	9.784s	coverage: 52.7% of statements
?   	github.com/kubeflow/kfserving/pkg/webhook/third_party	[no test files]
?   	github.com/kubeflow/kfserving/cmd/logger	[no test files]
?   	github.com/kubeflow/kfserving/cmd/manager	[no test files]
?   	github.com/kubeflow/kfserving/cmd/spec-gen	[no test files]

@animeshsingh Is there any other CI tests we want to run over with the new api changes?

@Tomcli keep this in WIP until we are ready to move both together.  Can you figure out how to run e2e here  out of the CI and see if any issues pop up

@animeshsingh The e2e test will fail on this PR because this PR didn't include the knative 0.9 vendor from #543. Should I add the #543 vender code here to do the e2e test and revert those 0.9 vendor changes once it's passed?

The e2e will fail anyway - given its for knative0.8. What I mean is please figure it running out of the PR, rather than depending on the PR to run it.

move this PR to #543


Fix typo as without the hyphen the command would not work

Clearly, you can see there is a typo here.
Documentation reference -> https://learn.microsoft.com/en-us/powershell/module/hyper-v/set-vmhost?view=windowsserver2022-ps#-virtualmachinemigrationperformanceoption
This is a parameter so it needs a hyphen.

Learn Build status updates of commit cae4ae5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azure-stack/hci/concepts/host-network-requirements.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Many thanks as always, @cblackuk

Thanks for such a quick turnaround :-) really appreciate it :-)


arm: NXP MPU does not report faulting address for Stacking Errors

This makes these kinds of faults very hard to debug as we have no idea where in the code the fault happened. I often observe either NULL or some nonsense memory address. Example:
***** BUS FAULT *****
  Executing thread ID (thread): 0x20003038
  Faulting instruction address:  0x0
  Stacking error
Fatal fault in thread 0x20003038! Aborting.
***** BUS FAULT *****
  Executing thread ID (thread): 0x200030c4
  Faulting instruction address:  0x0
  Stacking error
Fatal fault in thread 0x200030c4! Aborting.
***** BUS FAULT *****
  Executing thread ID (thread): 0x20003150
  Faulting instruction address:  0x0
  Stacking error
Fatal fault in thread 0x20003150! Aborting.
***** BUS FAULT *****
  Executing thread ID (thread): 0x200031dc
  Faulting instruction address:  0x0
  Stacking error
Fatal fault in thread 0x200031dc! Aborting.
***** BUS FAULT *****
  Executing thread ID (thread): 0x20002f20
  Faulting instruction address:  0x0
  Stacking error

This isn't unique to the NXP MPU and can also occur with the ARM MPU. A stacking error occurs when the processor fails to save context, thus we pass an invalid stack frame to the fault dump routine. The processor also doesn't update the BusFault Address or MemManage Address registers.
@ioannisg Any ideas on how we could improve this?


Standardize the behavior of ~ (without slash) paths

Seems like a general problem: Url.Content resolves ~Text.css as /Text.css.
However this doesn't work with url resolution in Views: e.g.
<link href="~Text.css" /> gets printed as is. This also seems to be the behavior in Mvc 5
There are other places in the application (for instance view resolution) where we specifically look for ~/ rather than just ~.

Sounds like a minor issue with Url.Content. Using ~/ is the supported pattern

Using ~ is also the supported pattern per https://github.com/aspnet/Mvc/issues/2896 - it just doesn't work everywhere.

Can we just special case "~" as being "app path"? Doing "~foo" seems esoteric and odd... and wrong...

Can we just special case "~" as being "app path"

:+1:


exceptions must derive from BaseException

ComfyUI Error Report
Error Details

Node Type: InstantIR_Loader
Exception Type: TypeError
Exception Message: exceptions must derive from BaseException

Stack Trace
  File "D:\ComfyUI\execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "D:\ComfyUI\execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "D:\ComfyUI\execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)

  File "D:\ComfyUI\execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))

  File "D:\ComfyUI\custom_nodes\ComfyUI_InstantIR_Wrapper\InstantIR_node.py", line 91, in main_
    raise "need chocie a lora checkpoint"

System Information

ComfyUI Version: v0.2.7-13-g8a52810
Arguments: D:\ComfyUI\main.py --auto-launch --preview-method auto --disable-cuda-malloc --fast
OS: nt
Python Version: 3.10.11 (tags/v3.10.11:7d4cc5a, Apr  5 2023, 00:38:17) [MSC v.1929 64 bit (AMD64)]
Embedded Python: false
PyTorch Version: 2.5.1+cu124

Devices

Name: cuda:0 NVIDIA GeForce RTX 4070 Ti : cudaMallocAsync

Type: cuda
VRAM Total:<PHONE_NUMBER>4
VRAM Free:<PHONE_NUMBER>
Torch VRAM Total:<PHONE_NUMBER>
Torch VRAM Free: 60278496

Why are the results of image generation so blurry?

more step and turn off  use_clip_encoder

more step and turn off use_clip_encoder
The result based on your suggestion is still blurry.

any SDXL checkpoint── sdxl_lightning_8step.safetensors
├── ComfyUI/models/InstantIR/models
|     ├── adapter.pt
|     ├── aggregator.pt
|     ├── previewer_lora_weights.bin
├── ComfyUI\models\InstantIR\dino
|     ├── config.json
|     ├── model.safetensors
|     ├── preprocessor_config.json
├── ComfyUI\models\loras
|     ├── lcm-lora-sdxl.safetensors

yeah, it's correct. you can try add ' a man image' in prompt

yeah, it's correct. you can try add ' a man image' in prompt

Following your suggestion, but the result is still blurry. I‘m downloading SDXL base 1.0, it might be an issue with the lighting model.

I doubt whether it is really effective. If that's the case, it can't compare to the Flux ControlNet upscaler at all.

Yes, this image restoration method does have a problem of sometimes good and sometimes bad

Yes, this image restoration method does have a problem of sometimes good and sometimes bad

Thank you. Thank you for your efforts.


Newly installed yesiscan on Linux was unable to download and use "configs"

This was a fun one. Long story short, the newly added auto config code was downloading the first config, and then since we told it not to check again for N seconds, didn't proceed with the additional configs that some custom config files suggest.
This is all fixed in version v0.0.11 (as tagged.
Thank you for reporting!
PS: The fix in the code is super fun too if you're curious and want to check.


fix(client): properly wait for start to be done

My previous PR broke the start function. session.startTunnel returns immediately. It tells the extension to start. We still need to wait for the start process to be completed.

@jyyi1 I ran into that issue too. I think an IPC to get the last error is ok.


pass options strictSSL to config

somehow it is used here https://github.com/centrifugal/jscent/blob/master/lib/requests.js#L10 but not passed from config

Thanks!

0.2.1 maybe?)

Sure, I am currently away from computer - can do this on Monday.


issue with webdriver upgrade in Protractor 3.0 -- (undefined:1190     vlog(2, () => this + ' scheduling notifications', this);)

Upgraded to Protractor 3.0 and now I receive the below error every time the tests try to run.

$ protractor

[launcher] Process exited with error code 1
undefined:1190
vlog(2, () => this + ' scheduling notifications', this);
^
SyntaxError: Unexpected token )
at goog.loadModuleFromSource_ (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1123:19)
at Object.goog.loadModule (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:1085:46)
at /Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/lib/webdriver/promise.js:1:6
at Object.exports.runInContext (vm.js:64:17)
at Object.Context.closure.goog.retrieveAndExecModule_ (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/base.js:135:8)
at :1:6
at Object.exports.runInContext (vm.js:64:17)
at Context.closure.closure.vm.createContext.CLOSURE_IMPORT_SCRIPT (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/base.js:104:12)
at Object.goog.importScript (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:879:9)
at Object.goog.importModule (/Users/christraynor/Documents/BitBucket/Angular2-seed/node_modules/protractor/node_modules/selenium-webdriver/lib/goog/base.js:900:14)
npm ERR! Test failed.  See above for more details.

Protractor 3.0 is only compatible with node 4.0+

Good to know. Thanks!


Latest version not available on pypi

Version 1.5.0 is not on pypi.

Sorry about that - I've made a new 0.1.6 release with a bumped patch level and uploaded it to PyPI.


Fix# 143 - EPERM error in Windows

This is just a simple kludge to remove the error when demeteorizing on Windows with an older node version. Seems to work in my testing.

This doesn't exactly do what you want it to... Just replace the comment block
and the unlink call with
Fs.chmodSync(packagePath, '0644');
You'll have to update the tests to reflect this change as well. This is a much
better solution to the file permissions. :smile:

Well -- it does do exactly what I want .. but maybe it's not the cleanest. :)  I was trying to minimize the code flow and only for the case where we failed on Windows.  Are you saying you'd rather always just do the chmod .. and no unlink is even needed?  Well that's cool.
Also, being new to this -- how do I run the tests "locally" before I commit to make sure they pass?
Cheers

Yeah, there's no need to remove the file if the permissions are changed. :+1:
Run npm test to run the tests locally. You'll need to replace the unlinkSync
mock in the unit test with a chmodSync mock. That should do it for the tests.

Thanks -- did exactly that and now everything seems to be working fine.

Just a couple of things, convert your tabs to spaces, change your quotes to
single quotes, and remove the extra space around those calls.

OK -- but I rather LIKE the spaces around the calls .. IMHO -- easier to read.. but that's me.. :)
I know I should have used Sublime to make the changes and not vi!  LOL ..

One more thing, the second call to chmodSync isn't necessary since the file
isn't being overwritten. Also, that call happens after the done callback is
passed off.

Well that was easy!  HA!  :)

:+1: Thanks for the contribution!

Thanks for walking me through it -- obviously once you saw the original code you could have had it all done in about 2 minutes and not 3 more commits!  :)


clr-tab-content not taking 'height' into consideration

Hi all,
Since switching to Clarity 1.0 I've noticed a bug in the functionality of clr-tab-content.
For some reason, if you specify a 'height' or any style in the 'clr-tab-content', it is not considered in the resulting HTML.
This causes problems because if you use other Angular components inside the tab content, which rely on relative height (for instance height: 40%), it no longer knows relative to what this should be calculated.
For example if I have the following code:

<clr-tabs>
		<clr-tab>
			<button clrTabLink>Some Tab</button>
			<clr-tab-content style="height: 100%;">
				<as-split>
					<as-split-area [size]="50">

					</as-split-area>
					<as-split-area [size]="50">

					</as-split-area>
				</as-split>
			</clr-tab-content>
		</clr-tab>
	</clr-tabs>

Only the orange part will show up, because the [size] passed to  is relative

Update:
Here is a link to stackblitz reproducing the issue:
https://stackblitz.com/edit/clarity-u95irx?file=app%2Fapp.component.html

Hi @Jinnie
One more thing which could be relevant. Prior to bumping Clarity to 1.1, the version where everything worked fine was 0.13.
Cheers,
Alek

I guess you closed this by mistake with your last comment. Reopening, as it is a valid issue and I'll be submitting a fix soon.


Don't load or run simplecov unnecessarily

This will only load/run simplecov when USE_SIMPLECOV is exported.
Nobody cares about coverage locally and it slows the test suite down (a
little, but it's discernible no less)

Closing in favour of #166


x/blog: Recursive link on Developer Survey Results 2020

What version of Go are you using (go version)?

$ go version
go version go1.15.10 darwin/amd64

Does this issue reproduce with the latest release?
Not Applicable
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
...
GOARCH="amd64"
GOOS="darwin"
...

What did you do?

Opened the link https://blog.golang.org/survey2020-results. Reached out to line after Thank you line.

In 2020, we had another great turnout with 9,648 responses, about as many as 2019. Thank you for putting in the time to provide the community with these insights on your experiences using Go!

The link claims to compare with 2019 Results but the link instead leads to the same URL.
What did you expect to see?
The link should be https://blog.golang.org/survey2019-results.
What did you see instead?
The link is https://blog.golang.org/survey2020-results.

This has already been fixed in https://github.com/golang/blog/commit/67340572e3cf3e14f1eb1015d219b79598567143 but still not deployed.

Oh sorry, didn't see it there.

Thanks @dtchanpura and @qmuntal. The latest x/blog commit has been deployed now, so I'll close this.


Exclude .env from docker builds

This fixes an issue where environment variables could be ignored by start.sh when running in Docker.
Before this change .env would be copied into the docker image if it exists in the repository. Because start.sh gives precedence to the .env file over actual environment variables, if you then changed the environment variables in .env they wouldn't be picked up by go-ssb-room.

@HendrikPetertje Could you review this PR?

Thank you @decentral1se, that should be a sufficient review for a 1 line change.


net/ipv6: Set the right protocol when finalizing MLD packet

IPv6 next header might be something else (here NET_IPV6_NEXTHDR_HBHO)
but when finalizing it is mandatory to give the actual last header
protocol type. In this case IPPROTO_ICMPV6, so the checksum can be
computed properly then by net_icmpv6_finalize() called from
net_ipv6_finalize().
Fixes #14663
Signed-off-by: Tomasz Bursztyka<EMAIL_ADDRESS>

Codecov Report

Merging #14673 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14673      +/-   ##
==========================================
- Coverage   51.98%   51.97%   -0.01%
==========================================
  Files         309      309
  Lines       45584    45584
  Branches    10555    10555
==========================================
- Hits        23695    23694       -1
- Misses      17080    17082       +2
+ Partials     4809     4808       -1

Impacted Files
Coverage Δ

subsys/net/ip/ipv6_mld.c
52.75% <100%> (ø)
:arrow_up:

subsys/net/ip/icmpv6.c
28.74% <0%> (-1.2%)
:arrow_down:

arch/posix/core/posix_core.c
91.91% <0%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b1227f...0ec1d48. Read the comment docs.


Unable to sync N1 to a local sync-engine

I have recently noticed a problem using N1 connected to a locally run sync-engine. I have set up my sync-engine using the recommended vagrant setup process and authorised a gmail account. Querying localhost:5555/accounts I get the expected:
[
{
"account_id": "{account_id}",
"email_address"<EMAIL_ADDRESS>"id": "{account_id}",
"name": "My Name",
"object": "account",
"organization_unit": "label",
"provider": "gmail",
"sync_state": "running"
}
]
When I run "N1.sh --dev" I click the new "Hosting your own sync engine?" option. I then put in localhost and 5555 as my server and port. When N1 loads it says it's syncing my mailbox but nothing happens despite waiting over 10 minutes.
On the console I see "APIError: Identity is present but identity token is missing." messages in a few places. I noticed there is no *.nylas.accountTokens in my config.json file any longer either. When I manually enter that option as per previous setup instruction I don't get the APIError message anymore but the mailbox still doesn't sync. It just waits forever.
I think this is an N1 error rather than sync-engine because I can visit localhost:5555/threads from my browser and see all the appropriate emails.
I suspect this has something to do with commit  #98e351ebeb4857a77d256034fb96b5665dc45b48 but I'm not sure.
Are there any related issues?

No
What operating system are you using?
Arch Linux
What version of N1 are you using?
Latest version of the code from git master

Bug?
Do you have any third-party plugins installed?
No
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
No
Is the issue reproducible with a particular attachment, message, signature, etc?

N/A

I've been playing about with this a little. I've found a few steps you can do to bypass this bug for now and maybe it'll give some clues as to what the problem is.
Firstly to start with I removed ~/.nylas/ to give myself a clean slate. When I run N1 I get the Welcome page that just says "Welcome to Nylas." After selecting run a local sync-engine and setting it to localhost:5555 I get the bug described above where mailbox won't sync.
I then edit config.json to add an appropriate *.nylas.accountTokens entry and remove the *.nylas.identity. When I restart Nylas, the welcome page says "Welcome back to Nylas. Some things have changed since etc. etc." Again I select to run a local sync-engine with localhost:5555 and this time I can see my current emails though new emails don't get synced as they come in.
Interestingly when I look at config.json after this, *.nylas.identity is the same as what it was previously and *.nylas.accountTokens is gone.
If I now replace *.nylas.accountTokens again (and leave *.nylas.identity as it is), and then restart N1 everything works correctly. I can see my emails and new mail arrives as expected. config.json now includes *.nylas.accountTokens and from now on, every time I open N1 everything seems to work as expected.
Hope this helps track down the source of the problem.

Interesting... you shouldn't need the `accountTokens

Yes, just double checked now. Latest version of both N1 and sync-engine from git. Still same problem with same workaround as described above. I noticed that there are two different welcome screens (initial welcome and the welcome back). Is there some logic in the welcome back situation that is not being done on the initial welcome?

Nope, that shouldn't make a difference! But APIError: Identity is present but identity token is missing. indicates that the token wasn't correctly added to your system keychain the first time, which makes it odd that it would work a second time. Same with accountTokens—I think we check the config.json for them as a fallback if they can't be found in the keychain. Do you have Gnome Keyring installed correctly and everything?

I'm using KDE so I don't have gnome keyring installed. Does this work with kwallet also or is it gnome-keyring only?

It's Gnome Keyring only! That'll be the issue, unfortunately, since it's a dependency for N1—going to close this issue for now.

I'm having the same issue sometimes.
This time everything began because one of my GMail acccounts was switched to 2-factor auth and this broke the Nylas sync for this particular account.
I read that some people had success by removing and readding the account again so I wanted to give it a try as well.
It looked good in the beginning (the syncing note appeared for the readded account) but at some point the token is is missing message came up:

I closed the modal message and the Create a Nylas ID screen came up:

What is important here as well: this screen makes absolutely no sense for anybody who uses a self hosted sync engine. (Should I create another issue for that?)
Please note as well: It's not the first time that the Identity is present but identity token is missing issue appeared for me.
I'm running Ubuntu 16.10 (but this issue appeared for my for any Ubuntu version before as well and I'm running it against a self hosted sync engine.
A working config (~/config.json) contained
…
     "nylas": {
      "identity": {
        "firstname": "",
        "lastname": "",
        "valid_until": null,
        "email": "",
        "id": 1,
        "seen_welcome_page": true
      },

which should avoid the Create a Nylas ID screen. But the Identity is present but identity token is missing issue will remove this entry again.
So, for now, if this issue happens I don't know any solution except from removing everything in ~/.nylas/ and readding, syncing and waiting again. 😿


[FEATURE] Support substituting Accelerator values into existing Fortinet FW config to bootstrap FWs

Required Basic Info
To properly assess the enhancement request, we require information on the version of the Accelerator you based this request upon:

Accelerator Version:  1.3.6

Is your feature request related to a problem? Please describe.
Customer would like an automated FW re-deployment for DR purposes.  Firewalls  would be bootstrapped with custom FW config that ASEA has updated new values within if ASEA is re-deployed.
Describe the solution you'd like
Customer would like to use an existing FW config.  The config encapsulates a complex custom FW setup.  They would prefer not to have to diff changes in the event of a DR.  They would like to have a mechanism for ASEA to perform substitutions inside an existing FW config (dumped from FW) of new values from an Accelerator re-deployment.  This document subjected to aforementioned substitutions would be used to bootstrap the FWs.
https://github.com/aws-samples/aws-secure-environment-accelerator/blob/c3ed6e05a0f2c159455d7a303245ee11120abc15/reference-artifacts/SAMPLE_CONFIGS/firewall_file_available_variables.md
Describe alternatives you've considered
Diff explained and considered.  Customer prefers an automated solution.
Additional context
Add any other context or screenshots about the feature request here.

Thank you James for creating the issue.
Yes, this is a feature we think would make a lot of sense in a disaster recovery scenario; being able to run the Accelerator using a firewall configuration backup that contains all our customizations (i.e. customized interfaces, tunnels, policies, etc.) and therefore have a fully configured/functional firewall once the Accelerator completes.
As described by James, what we though could potentially work would be to use our most recent firewall configuration backup and patch the actual IP addresses with the variables that are expected by the Accelerator. These variables would then be replaced with the new values that resulted for the Accelerator network deployment, as it is currently the case when running the Accelerator with the basic firewall configuration.
We do not know if this actually requires any modifications on the Accelerator side as it already performs this variable to value replacement during deployment. Or in other words, if the Accelerator performs a pure search and replace for the variables, it could perhaps already support this. But our full firewall configuration backups currently have about 5K lines and perhaps we could be placing some of the variables here they are not expected or are ignored. Or perhaps there are some additional sections in our firewall backups that would not be expected by the Accelerator and cause other issues.
We may be experimenting with this in the near future; looking if we can automate the task of replacing actual values in a full configuration backup with the variables that are expected by the Accelerator and feed that as an input in a full Accelerator run.
So please let us know if there is movement on this request or if you can think of reasons this has no chance of working. And we will also post any additional observations or suggestions we may have here.
Thank you,
Charles Auger
<EMAIL_ADDRESS>

For others reference: One way you could potentially do this is to use Cloudwatch event scheduler kick off a Lambda say once a day to SSH to the Fortigates, dump the FW config to an s3 bucket that will trigger a second Lambda to regexp it to insert the variables then place it in the ASEA s3 config bucket.  That way if you were to re-deploy ASEA it would use a current FW config.

Hi,
I believe this is a request for Fortinet.  Unfortunately, Fortinet does not allow one to load a Fortinet backup file using the Fortinet bootstrap process which leverages AWS userdata (a Fortigate thing, not an AWS thing).  AWS is simply feeding a Fortinet Fortigate config file into Fortinet's bootstrap process (and these are just the exact commands in the exact order you'd need to type them if you entered them on the Fortigate command line).  (i.e. one challenge - you need to have the same Fortigate 'sections' multiple times, as you may not have everything defined before you get to the first occurrence of a section - I don't think the restore load process works this way and allows everything in a single section as it validates the entire config file at once, at the end.).
Yes - we perform a pure search/replace on ${VARIABLE} in the supplied "firewall.txt" config file.  They can be the auto-generate (dynamic) values described here, or variables defined by you in the replacements section of the main accelerator config file.
Whatever file you provide, we will jam it into the firewall, after we replace any variables (if they exist) :-).  We have no control as to whether Fortinet accepts or rejects the file.  The current example was developed with extensive assistance and support from Fortinet, and is ultimately just a Fortigate config file.
Multiple options exist:

take all your customizations and work them back into a new sample input file

this is easy if you backup the config immediately after a clean install, make all your changes, take another backup and use a text comparison tool to compare the two files.  Take the new items, and merge them into the appropriate spots of a new input config file (ignoring gui placement fields).  If you save that backup, you can use it to compare to the latest backup in a DR scenario, such that you can recover to latest backup.

record the values of all your variables after deployment, in a DR scenario, reload with the sample config, record all the values and create a mapping table, search and replace the backup for each value from before and replace it with the new value, load the backup on top of the "oob sample deployment".
I'm sure other options exist...

Unfortunately, this is all 3rd party and extremely vendor specific functionality that is outside the scope of work AWS is able to undertake.

Hi Brian, James,
Thank you for your assistance and understood that there is a fine line here between what AWS/Accelerator can do based on what is supported by Fortinet.
Brian, I’m not sure I understood all of what is in the first paragraph of your post. We started working with Fortigate when adopting the AWS SEA (have always used something else in the past) and are therefore still learning. But I think the bottom line is that in terms of using a configuration file, the Fortigate bootstrap process is different to it’s restore process; unlike the restore process, the bootstrap process cannot ingest a full configuration file backup. And therefore, the suggestion of feeding a full configuration file (even with the appropriate variables in place instead if actual IP addresses) during Accelerator deployment/Fortigate bootstrap is a no go. If you can please confirm.
We did perform a manual restore a few months ago. We had to do a clean run of the Accelerator and this was after a significant amount of changes had been made to the firewall configuration. As you suggested, we did a manual diff/merge of the fresh firewall configuration after the Accelerator completion and a backup taken previously. Although this worked, we did find it quite error prone, hence why we were looking for other options.
Charles

Hi,

"the Fortigate bootstrap process is different to it’s restore process; unlike the restore process, the bootstrap process cannot ingest a full configuration file backup."  {in the format output by the Fortigate backup process}

Correct, this is my understanding.  But, it's not an AWS product, I defer to Fortinet and their experts.

And therefore, the suggestion of feeding a full configuration file (even with the appropriate variables in place instead if actual IP addresses) during Accelerator deployment/Fortigate bootstrap is a no go.

you can craft / create a file that contains your entire firewall configuration, but, you cannot simply use the Fortigate backup file, it needs to be reconstructed.

I could be wrong, this is my experience/understanding.  James can connect you with someone at Fortinet who may be able to help you in this area.
BTW: I forgot to mention, if you do come up with something, we'd love if you contributed back.

Thank you Brian. We do have a contact at Fortinet and may probe that way now that I have a better understanding of the issues.
Yes, we’ll let you guys know if there are other developments on this. Please do the same, perhaps there are other government departments deploying Fortigate via the Accelerator that will look into making the disaster recovery scenario more “elegant”!


jsonpath wildcard with collection returns a string

Hello 👋
I am trying to reference the request to build out the body of my response using jsonpath. I want the response to have the same collection as the one sent in the request. The issue is that I am getting back a string instead of a collection. Is there something I am doing wrong or is there not a way to reference the request body with jsonpath without getting back a string?
Response Section of Contract
response:
  status: 201
  body:
    id: "4ADD5DD9-8290-4B9D-861F-66E16B96AEA4"
    name: "{{{ jsonpath this '$.name' }}}"
    myCollection: "{{{ jsonpath this '$.myCollection.*' }}}"

Request
{
  "name": "Joe",
  "myCollection": [
    {
      "foo": "12345",
      "bar": true
    },
    {
      "foo": "54321",
      "bar": false
    }
  ]
}

Response
{
  "id": "4ADD5DD9-8290-4B9D-861F-66E16B96AEA4"
  "name": "Joe",
  "myCollection": "[{"foo": "12345","bar": true},{"foo": "54321","bar": false}]"
}

myCollection is a string not a collection ☝
YAML DSL version: 2.2.2.RELEASE

The jsonpath reference was never intended to work with complex structures. You should reference a primitive.


Integration of the application via the WSL

Describe the bug
All required directories are not created when using the WSL.
The system does not differentiate between Linux and WSL, and the folders are not created.
Please complete the following information:

OS: Windows  11
OS version: 23H2
Program version: v.0.5.3.beta

Fixing the problem with checking and reworking some functions.
Also add a revised header for set_main_dir_with_wsl in the windows version.


How to show map in a fragment.

Issue Type
[* ] Question
[ ] Bug
[ ] Improvement
[ ] Build system related
[ ] Performance
[* ] Documentation
Description and/or steps/code to reproduce the problem
This is my code.
public class FirstFragment extends Fragment {

    MapView mMapView;

    @Override
    public View onCreateView(
            LayoutInflater inflater, ViewGroup container,
            Bundle savedInstanceState
    ) {
        mMapView = new MapView(inflater.getContext());
        return mMapView;
    }

    @Override
    public void onResume() {
        super.onResume();
        mMapView.onResume();
    }
}

This is my output.

How do I set the map to this fragment? Kindly requesting an example code.
Version of osmdroid the issue relates to:
6.1.2

Check out the sample app on the playstore, then find an example you like, then dig up the source for it and poke around. Adding it in a fragment is no different than in an activity layout, only the lifecycle is a bit different.

mMapView.setDestroyMode(false);
This appears to be the most effective solution at present.
from: #1848


Separate document text and memory.

Text is now a substring of memory, starting at index 0.
We now realloc memory when needed and only copy the existing data around, instead of allocating a new string, copying all the data and freeing the old string.
This leads to less allocation calls and less copying.
We also now check duplicate open calls, free the memory of the previously open text document if they happen and log it.

How much does this improve memory usage? I just want to make sure this pull request's complexity is a fair trade off to its improvements.

@SuperAuguste
This mainly reduces the time for executing changes, especially small ones, at the cost of a bit of extra memory (how much memory we preallocate can be tuned).
By preallocating more memory when a change needs a bigger buffer, subsequent range changes do not need to allocate at all and only need to do 2 copies (as opposed to 1 allocation, 3 copies and 1 deallocation each time for every range change like before).
I think this is worth it since changes are usually typing or small copy pastes which would cause a lot of allocation calls in a row, as opposed to a bigger upfront allocation followed by "just" copying and less than in master.

OK, sounds good! Merging!


MHD_053: assuring query results are all the same human patient

MHD_053: Note that there is an emerging issue that FHIR has not addressed and that is how distributed systems behave, and how Patient links affect recorded data. Thus, it is difficult to determine today that the response Bundle content all will be pointing at the exact same Patient, although they should all be referring to the same human.

Not clear there is anything that can be done with this. Also not sure anything should be done with this. it is up to the server to assure, to the best of the servers ability, that the results are about the same patient. And it is equally true that the client must presume this to be the case. This is the way it is done in XCA. In MHDS and XDS this is driven to be true thru unified patient identity that is centrally managed (XDS Affinity Domain, PMIR golden identity).

Is there a thread on Zulip that could be referenced, here? It may be helpful to see how this emerging issue has been characterized... and what has been the discussion so far.

move to closed issue,


Cannot find the root_distance column in the head_graph_object table

I run the command ./trace_processor -e java_heap.sqlite trace and get a SQLite database, but I can't find the root_distance column in the head_graph_object table

root_distance is a hidden column of the heap_graph_object table.
I believe it's hidden because it's an implementation detail of the algorithm that builds the flamegraph, so we might change its semantics or remove it.
The algorithm that builds the flamegraph doesn't even run by default (you have to acutally query the flamegraph table for that), so the column will not even be populated most of the times.
Also, I'm told that the -e mode for trace_processor is supported on a best-effort basis. I wouldn't be surprised if something else doesn't fully work.


How to create PoseArray

Hey !
The general question here is regarding the PoseArray.
I am not completely comfortable with using pure C, and am looking for some assistance in create a PoseArray object.
There are some examples available for the normal Cpp ROS implementation, but I am unsure how to do this with micro-ROS.
Any advice is appreciated!

This does not work :cry:

You have the whole description of how to handle message memory here: https://micro.ros.org/docs/tutorials/advanced/handling_type_memory/
Manually it looks like:
    geometry_msgs__msg__PoseArray m = {};
    m.header.stamp.sec = 0;
    m.header.stamp.nsec = 0;

    char frame_name[] = "base_link";
    m.header.frame_id.data = frame_name;
    m.header.frame_id.size = sizeof(frame_name);
    m.header.frame_id.capacity = sizeof(frame_name);

    geometry_msgs__msg__Pose pose_array[10];
    m.poses.data = pose_array;
    m.poses.size = 10;
    m.poses.capacity = 10;

    for(int i = 0; i < 10; i++){
        pose_array[i].position.x = 0;
        pose_array[i].position.y = 0;
        pose_array[i].position.z = 0;
        pose_array[i].orientation.x = 0;
        pose_array[i].orientation.y = 0;
        pose_array[i].orientation.z = 0;
        pose_array[i].orientation.w = 0;
    }

You also can use micro_ros_utils for doing this, the whole info in the link above.


Adding PID controller Chapter.

I am sorry it's taking me so long to get to this. It's mostly there. I'll look over the text once more and check out the code next.

I, Gathros, the copyright holder of this work, irrevocably grant anyone the right to use this work, including derivatives created during the review process, under the Creative Commons Attribution ShareAlike 4.0 license (legal code).
(Anyone may use, share or remix this work, as long as they credit me and share any derivative work under this license.)

[lang: c]

@Gathros It's been years. I really dropped the ball on chapter reviews, but I am making it a priority now and I promised you that your chapter would be the first one in, so would you mind either:

Continuing with the PR
Allowing me to either push to this branch or create a separate PR from this one with my own changes. Obviously, if I need to create a second PR, you will still be in the git history.

If I don't get a response, I will go ahead and start with 2


Validationpackage

📥 Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
☑ Submission checklist

[ ] I have read the CONTRIBUTING doc
[ ] yarn build works locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

💬 Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc...

Er konflikt mot master, ser gjerne at det gjøres en rebase hvor det squases ned til en pen commit.

Oops! Klarte å rebase med gammel versjon av master 😭 Skal fikse!


Grid x without 100% width

What should happen?
The grid-x doesn't occupy the entire available space from the parent element.
The
What happens instead?
This styles are missing from the xy-grid/_classes.scss file:
.grid-x {
margin: 0;
padding: 0;
width: 100%;
}
Test Case and/or Steps to Reproduce (for bugs)
How to reproduce:

Install foundation sites
Use the class grid-x
Check that the element doesn't occupy the entire space of the parent element

Context

Your Environment

Foundation version(s) used: 6.5.3
Browser(s) name and version(s): Chrome Version 75.0.3770.142 (Official Build) (64-bit)
Device, Operating System and version: Windows 10
Tech Stack: Angular 8.1.2

Hi @jgomesmv,
I'm unable to reproduce the issue – please provide a codepen

I guess it needs the grid frame / container.

You have created a small example with foundation on top of a angular app:
https://stackblitz.com/github/jgomesmv/foundation-sites-demo?file=src%2Fstyles%2Fglobal%2F_imports.scss
I have created this stackblitz example because I think the problem it's about how angular loads foundation-sites. It's the second time I'm using foundation-sites, and none of this issues happen before.
Event stackblitz has a problem running the solution it really doesn't care about how I have configured the angular.json file and the npm dependencies. Probably you will need to install the angular cli and run it locally

I can also not reproduce.
See https://codepen.io/DanielRuf/pen/wvwJLaV
Please use this codepen and fork it.
Closing as we can not reproduce it so far.


Prioritize completion suggestions for "is X" using type information

If we complete:
foo(Statement statement) {
  if (statement is ReS^) {
  }
}
There are are items: RefactoringStatus and ReturnStatement.
Then ReturnStatement proposal should be before RefactoringStatus, because ReturnStatement is subclass of Statement and RefactoringStatus not - so ReturnStatement is a reasonable type to check, and RefactoringStatus isn't.

https://codereview.chromium.org/1871073003/

Landed, should be fixed in Dart SDK 1.16 when it is rolled.

https://codereview.chromium.org/1876603002/


Changes blocking the CI

          We're in trouble:

Any recent change in github's flutter version?
Originally posted by @monsieurtanuki in https://github.com/openfoodfacts/smooth-app/issues/5343#issuecomment-2155046316

If it could be avoided to merge code that fails that would be appreciated, cf #5332:

I'm sorry, I merged during the weekly call, without making the verifications I should have

I'm sorry, I merged during the weekly call, without making the verifications I should have

I guess you have special powers that enable you to merge even faulty PRs.
With great power comes great responsibility. I guess weekly calls are your kryptonite 😉


Do you have plans to implement Schnorr signatures?

I know it is a bit of a Pandora's box with 2 incompatible implementations, but there are projects using Schnorr signatures with secp256k1 private keys, and there are some privacy advantages of it in multi-signature use-cases over the legacy script-based BTC multi-signature.
Do you have it on the roadmap or are you willing to accept a PR if I start on an implementation?

Well, not yet, but soon I will have to implement something for ARK AIP-11 compatibility, and binding to a C library is something we would like to avoid for a crypto library.

Hi all, is this implemented? If not, are PRs still welcomed today?


Unable to extract uploader id

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[ ] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE

Unable to extract uploader id

A verbose log showing the same problem:
~/bin/youtube-dl --verbose https://www.youtube.com/watch?v=BaW_jenozKc
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.youtube.com/watch?v=BaW_jenozKc']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.10.6 (CPython) - Linux-5.15.0-60-generic-x86_64-with-glibc2.35
[debug] exe versions: ffmpeg 4.4.2, ffprobe 4.4.2
[debug] Proxy map: {}
[youtube] BaW_jenozKc: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/home/user/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
File "/home/user/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
File "/home/user/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
File "/home/user/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
File "/home/user/bin/youtube-dl/youtube_dl/extractor/common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Getting the same issue on macOS BigSir 11.6 with homebrew install of youtube-dl.
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.youtube.com/watch?v=8k0LgdtnOvc']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.12.17
[debug] Python version 3.11.2 (CPython) - macOS-11.6-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] 8k0LgdtnOvc: Downloading webpage
ERROR: Unable to extract uploader id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 815, in wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/YoutubeDL.py", line 836, in __extract_info
ie_result = ie.extract(url)
^^^^^^^^^^^^^^^
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 534, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/youtube.py", line 1794, in _real_extract
'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/Cellar/youtube-dl/2021.12.17/libexec/lib/python3.11/site-packages/youtube_dl/extractor/common.py", line 1012, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract uploader id;

@fradooo :
You haven't followed the recommended procedure on submitting a new issue, now a PINNED issue in the main repo:

i.e. #30839 ; to add insult to injury, you lied by ticking

[x] I've searched the bugtracker for similar bug reports including closed ones

Had you done that (or heed the steps outlined in #30839 ), you'd have discovered ca. 100 duplicate issues with the same error message, plus links to the originating issue (now a megathread), with content and info on how to remedy your predicament...
To ALL the rest: The same applies 😞 ...

Since there isn't much information here, I also had this issue.
I get this issue using pipe-viewer, downloading from youtube, the full output is here:
[debug] Command-line config: ['-vvv', 'https://www.youtube.com/watch?v=-j8th_nXyIE']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.06.29 [9d339c4]
[debug] Python 3.10.6 (CPython 64bit) - Linux-5.15.0-60-generic-x86_64-with-glibc2.35 (glibc 2.35)
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.09.14, mutagen-1.45.1, secretstorage-3.3.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=-j8th_nXyIE
[youtube] -j8th_nXyIE: Downloading webpage
[youtube] -j8th_nXyIE: Downloading android player API JSON
[debug] Loading youtube-nsig.11e3a4ec from cache
WARNING: [youtube] nsig extraction failed: You may experience throttling for some formats
n = G5S9F6ZcgJY5PGCQ ; player = https://www.youtube.com/s/player/11e3a4ec/player_ias.vflset/en_US/base.js
[debug] [youtube] -j8th_nXyIE: Traceback (most recent call last):
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/extractor/youtube.py", line 2580, in _decrypt_nsig
    self._player_cache[sig_id] = func(s)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/extractor/youtube.py", line 2612, in <lambda>
    return lambda s: jsi.extract_function_from_code(*func_code)([s])
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 505, in resf
    ret, should_abort = self.interpret_statement(stmt, var_stack)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 120, in interpret_statement
    return self.interpret_expression(expr, local_vars, allow_recursion), should_abort
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 156, in interpret_expression
    ret, should_abort = self.interpret_statement(try_expr, local_vars, allow_recursion - 1)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 120, in interpret_statement
    return self.interpret_expression(expr, local_vars, allow_recursion), should_abort
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 156, in interpret_expression
    ret, should_abort = self.interpret_statement(try_expr, local_vars, allow_recursion - 1)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 120, in interpret_statement
    return self.interpret_expression(expr, local_vars, allow_recursion), should_abort
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 227, in interpret_expression
    self.interpret_expression(sub_expr, local_vars, allow_recursion)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 303, in interpret_expression
    left_val, should_abort = self.interpret_statement(
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 120, in interpret_statement
    return self.interpret_expression(expr, local_vars, allow_recursion), should_abort
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 303, in interpret_expression
    left_val, should_abort = self.interpret_statement(
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 120, in interpret_statement
    return self.interpret_expression(expr, local_vars, allow_recursion), should_abort
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/jsinterp.py", line 433, in interpret_expression
    raise ExtractorError(f'Unsupported JS expression {expr!r}')
yt_dlp.utils.ExtractorError: Unsupported JS expression '0<=c[49]'; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
 (caused by ExtractorError("Unsupported JS expression '0<=c[49]'; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U")); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, codec:vp9.2, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
ERROR: [youtube] -j8th_nXyIE: Unable to extract uploader id; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 640, in extract
    ie_result = self._real_extract(url)
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/extractor/youtube.py", line 3563, in _real_extract
    'uploader_id': self._search_regex(r'/(?:channel|user)/([^/?&#]+)', owner_profile_url, 'uploader id') if owner_profile_url else None,
  File "/home/a/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 1192, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)

The error can be reproduced by running something like this:
yt-dlp -vvv https://www.youtube.com/watch?v=-j8th_nXyIE

I get this with every video.


Text wrapping for code cells

Text in codecells beyond screen width are not rendered, need to wrap

Fixed in a6d543367172e8be9af3e2a89ec12418dd96260d


Back Navigation to previous tab instead of home

Hey guys,
Is it possible to navigate to previous tab instead of navigating back to home screen every time we backPress ?
example : Tab A -> Tab B -> Tab C    back will take us back to Tab A not Tab B
Thank you

You can checkout: https://github.com/vipulasri/Multiple-Backstack-Navigation


[feature request] disallow-multiple-spaces

It would be great if we could have a rule to disallow multiple spaces, such as:
var x  = 3;

instead of
var x = 3;

I saw the help-wanted tag for this issue in the 1.12 milestone. I have a working proof of concept based on tokens. I should be formalizing it into a PR shortly.

@twolfson Great news ;-) Thanks!

It would be appreciated if this option could have an exception for single line comment, e.g
var obj = {
     foo: "f",            // abbreviation for foo
     long_bar: "b",       // abbrevition for bar
}

@ItsCosmo According to the CONTRIBUTING.md, you should open a new issue for that functionality =/
https://github.com/jscs-dev/node-jscs/blob/v1.13.1/CONTRIBUTING.md#proposing-features

Or search. #1360


stack operations  by array

this is the code for stack operations using array.

Great work @Pragya0115 please give this repo a star if it really helped you to complete your PR.
Also follow me for follow back if you want to get connected with me for any such open source contribution program. Thank you 😊


fix: handle failures of kept alive processes

If the underlying process crashes during the first run, the worker still thinks it can re-use its channel for the next request with the assumption that our 'agent's are highly unlikely to crash. Although it is not very true, since even the most simple OOM or loading a c library (e.g. it segfaults / something is broken) will completely kill our agent process and all the upcoming connections will try to use the same machine.
The current solution here uses the native gRPC callbacks to watch the status of the channel (not the service). If the underlying channel goes bad (basically an HTTP connection to the gRPC server running inside the agent) for any reason, we can determine that agent is not useful / bad and spawn a new one. From what I understand, this behavior relies on keepalives although I was not able to reproduce it even without any keepalives enabled locally. If we start observing channels go bad for no reason (if we don't have health checking available by then) we probably should adjust keep-alive to ensure the server on the other side is still responsive.
Ideally we want this + health checking on the agents, but since this a very high priority issue and the current partial fix here would cover majority of the use cases I think we should go with it and add the health checking afterwards.

ATL: I thought the whole 10s keep alive was on koldstart and here it seems to be present too? Sorry if this is an obvious question.

The isolate one just ensures that the worker server is alive. But each worker also can have agents which are processes that actually keep your code fresh (e.g. imports / setup functions / etc.). There are different overheads with both (e.g. just keeping the worker with keep_alive on the cloud side would let us save the overhead of re-scheduling + booting up the worker server, but it wouldn't allow us to cache setup functions or imports).

Not immediately, but as a follow-up, yes!


Fix RFC6750 link

This was already fixed by f5fee67e1615c062dc765771f504899e0f66086b which was merged into dev, but hasn't made it into master yet.


char const

I get this error when compiling
rx5808oled.cpp.o: In function setup': /Users/chaz762/rx5808oled.ino:232: undefined reference to screens::begin(char const*)'
rx5808oled.cpp.o: In function loop': /Users/chaz762/rx5808oled.ino:434: undefined reference to screens::bandScanMode(unsigned char)'
/Users/chaz762/rx5808oled.ino:449: undefined reference to screens::seekMode(unsigned char)' /Users/chaz762/rx5808oled.ino:477: undefined reference to screens::save(unsigned char, unsigned char, unsigned int, char const*)'
/Users/chaz762/rx5808oled.ino:499: undefined reference to screens::screenSaver(unsigned char, unsigned char, unsigned int, char const*)' /Users/chaz762/rx5808oled.ino:506: undefined reference to screens::updateScreenSaver(char, unsigned char, unsigned char, unsigned char)'
/Users/chaz762/rx5808oled.ino:526: undefined reference to screens::diversity(unsigned char)' /Users/chaz762/rx5808oled.ino:531: undefined reference to screens::updateDiversity(char, unsigned char, unsigned char)'
/Users/chaz762/rx5808oled.ino:671: undefined reference to screens::updateSeekMode(unsigned char, unsigned char, unsigned char, unsigned char, unsigned int, unsigned char, bool)' /Users/chaz762/rx5808oled.ino:704: undefined reference to screens::updateBandScanMode(bool, unsigned char, unsigned char, unsigned char, unsigned int, unsigned int, unsigned int)'
/Users/chaz762/rx5808oled.ino:764: undefined reference to screens::setupMenu()' /Users/chaz762/rx5808oled.ino:768: undefined reference to screens::updateSetupMenu(unsigned char, bool, bool, char const*, char)'
/Users/chaz762/rx5808oled.ino:329: undefined reference to screens::mainMenu(unsigned char)' rx5808oled.cpp.o: In function __static_initialization_and_destruction_0':
/Users/chaz762/rx5808oled.ino:52: undefined reference to `screens::screens()'
collect2: error: ld returned 1 exit status
Error compiling.
I'm a novice but it look like it has to do with the "call_sign" should that be define in setting.h?

Looks like you have modified the original project and i won't be able to help.
rx5808oled.ino <-- does not exist in the project.
Please checkout the latest master and try compiling again.