Tutorial 6: Question to CrossEntropyLoss

Hey, thanks for your great tutorial on transformers!
In Code Section [24] you have written the following:
output = output.contiguous().view(-1, output_dim)
trg = trg[:,1:].contiguous().view(-1)

#output = [batch size * trg len - 1, output dim]
#trg = [batch size * trg len - 1]

loss = criterion(output, trg)

which does not work for me. I don't know if the torch API to nn.CrossEntropyLoss has changed or not, but for me it expects for the target the shape [batch size, output dim].
I think this is weird, becouse how can the loss of the whole transformer be calculated if it only checks the last bit? Should i use another loss function now?


Failed to load model class "Anymodel"

I'm trying to run vitessce in jupyter notebooks. Tried running mine and the tutorial example (both on a mac and pc) but everytime I try to run vc.widget() it gives error saying Failed to load model class 'AnyModel' from module 'anywidget' /n Error: Script error for "anywidget"

Hi, thanks for the issue. Can you please try the solutions mentioned in this comment https://github.com/higlass/higlass-python/issues/133#issuecomment-1692079494 and in the troubleshooting section here https://github.com/vitessce/vitessce-python#troubleshooting
In particular, can you share the version of python that you are using and the output of conda list or pip list for the environment?

The first link provided solved the issue. Looks like anywidget was installed in my working environment but not the base environment I used to open jupyter notebooks. Thanks!


"Commonly Used" list in the first-time-opened Command Palette

In user research Command Center (#149445) we found that the Command Palette on first opening is overwhelming, which might keep users from finding its value.
One core problem is that it is sorted A-Z, the top-most commands mostly not making sense in an environment that might not even have a file open:

One idea would be to curate ~5 commonly used commands that have high usage (format) and make make sense in a workspace-less state (split editor, toggle sidebars). It would be only shown when the user doesn't have past command history (which will then show the recently used).
cc @daviddossett @jrieken

fyi @lramos15 @bpasero

I think that makes sense, similar to the settings editor:

I am just not sure how to present this, should it be another group below the recently used commands? And how do we pick the commands to add there, based on usage numbers?

@sbatten and I were thinking:

last command at the top
list of pinned commands (that default to some list we come up with)
rest of recently used
other commands

It might be a bit busy, but it does:

still keep the command you spam at the top
but makes the pinned commands reachable from the keyboard

Here's what a relatively basic version of this could look like:

"commonly used" section initially shows at the top for new installs
After commands have been run, "recently used" pushes "commonly used" down
Users can remove commonly used command individually, eventually removing the section

https://user-images.githubusercontent.com/25163139/207692539-4e96ac15-5789-4da9-8f6c-2521543b9c31.mp4
I'm interested in the idea of mixing in default items to "recently used" as a way to cut down the number of sections. However neither title really captures what the section is in that case. It would be strange to open the command palette for the first time and see "recently used" commands. It would also feel weird to have run a bunch of commands and see them under "commonly used".

+1 for the idea of renaming "recently used" to "commonly used" and simply seeding that list with some defaults based on telemetry so that first time users get this. We could also think about filling the set up with the commonly used ones even for those users that only have a few commands that they had invoked.
In other words, I would not introduce a third group for this.

We can't use the term quick access but it reminds me of this feature in Windows File Explorer. You get a default set of pinned folders and you can unpin and add more.

For our initial attempt at implementing this, we will rename recently used to suggested (or something else) and follow this pattern:
For a new user
They will see 5 pre-seeded items underneath suggested, these items will have a certain weight to them and will be 5 commands we recommend for new users.
When they run a command, that command will show at the very top, under the suggested section, but above the 5 pre-seeded commands... it now has a weight, or frequency, of 1. If it's run again, that number bumps to 2, etc.
Eventually
The first 5 items in the suggested section will be the last 5 run commands. This is to not mess with muscle memory, and allow folks an easy way to re-run the last command or last few commands they just ran.
The next 5 items will be the top 5 unique commands by weight/frequency. These may include pre-seeded ones or ones that that user just runs a lot.
The next X items will be the rest of the recently used commands as it works today. This is to allow searching for a command to still be sorted by recently used.
Then the other commands section remains as is.
@digitarald will be getting me a nice list of pre-seeded commands based on our telemetry and other things.
Interesting details
Since commands showing up in the command palette is context driven (you can't git: commit if you don't have a repo open) we should handle the case for when there isn't a resolvable top 5. This would happen if the pre-seeded commands are run recently and are showing in the first 5 recently run section... the next 5, which should be the next unique top 5 commands by weight/frequency might not have anything to pull from... or the next highest frequency is like... 0 or 1. In this case, we can just only as many as we have.

I have playing around with this proposal, and frankly, I don't like it. It might be helpful for new users to see the 5 recommended commands, but for experienced users, it makes no difference and it doesn't feel any different than the current solution.
So I have a different proposal.
For new users, they will see a new section called commonly used:

This is a list that we come up with based on telemetry.
As they start to run commands, recently used slowly pushes that list down below the fold and if a command inside of it is run, it will jump up to the recently used section:

Eventually, an experienced user will either:

no longer see the list
have run all the commands in the list causing them to go up to recently used

This behavior is to help new users become experienced users. But experienced users should have some benefit of this work, which is why I propose that New Windows swap the commonly used list and the recently used list:

As the screenshot says, after the first command is run in a window, the commonly used and recently used swap going back to the normal experience above.
This proposal, I feel, enables new users to learn the ropes of the command palette while also making the Command Palette a useful launching pad for new windows.
Thoughts?

I think I partially get it and like the things I get:

first time users: get to see commonly used commands
existing users: will not see commonly used commands unless there is a commonly used command they have not run yet
recently used commands are always on top of commonly used commands (for muscle memory)

The part I do not get is the swapping thing? I am worried that changing the order of "commonly used" and "recently used" will break muscle memory. Think about users that blindly accept the first command from the picker.

@bpasero yeah the swapping thing is a little tricky. My motivation for doing it is to ensure that that last command you ran is on top. Once the user runs any command, we expect that command to be on top. However, without the swapping idea, if in new windows we show commonly used at the top always, then the recently run command will be below it.

The list of recently run commands is global though, so why would the new window show anything different?

The thought was that a new window (ex. one without a workspace), the command palette could be used as a launcher in the same idea that the welcome view of the explorer is:

or the Remote Indicator is:

The launcher idea came out of standup. I thought it was interesting... esp since a new window doesn't have anything open, and the first text you see is "Show All Commands":

This sounds to me like it could confuse users quickly as to why sometimes "recently used" is there and sometimes "commonly used".  I do not think that users (even experienced ones) could make the connection to the fact that its only for new (empty?) windows.

Perhaps the Command Center could be the difference instead of the "New Window" idea.

Command Center always shows "commonly used" on top since it's mostly mouse driven.
Command Palette always shows "recently used" on top for consistency

To make the "commonly used" a little bit smarter, we were wanting the list to be updated over time based on the commands that the user actually used. So in the Command Center, that "commonly used" section that showed at the top would show the top 5 commands that the user uses, rather than 5 hard coded suggestions.

So I played around with the Command Freqency idea and ultimately, I don't think it provides a ton of value. My top 5 commands were like:

Reload Window
GitHub Copy Permalink
Show Running Extensions
Configure Display Language

I might be a bit bias because I work on VS Code but idk to me these aren't so useful and frankly I'm not about to open the Command Center, click "Show and Run Commands", then click on one of my top 5. That's too many clicks.
To simplify this change, and put focus on the users we are focusing on in this issue, new users, I have simplified the proposal above to everything but the "New Window/Command Center" proposal.
In other words:
We show a suggested list initially and over time that list either:

gets buried underneath all of the "recently opened" items that the user actually uses
gets replaced by the item going into "recently opened"

Perhaps one day, we allow users to pin commands (https://github.com/microsoft/vscode/issues/163509) and have that experience be tied to the Command Center.

@TylerLeonhardt to clarify, even for existing users, we now always show "commonly used" commands section in commands quick access? And if so, is that section below or above "recently used"?

@bpasero yes correct. And it is always below recently used


Plugin for MacOS

I managed to compile and run the plugin on MacOS with X-Plane 11.
I tried to keep the code in a state that it would still compile on Linux, but I cannot test it myself at the moment.

Fixes https://github.com/RomanLut/INAV-X-Plane-HITL/issues/8

Thank you very much for help!
PR is merged to master via https://github.com/RomanLut/INAV-X-Plane-HITL/pull/29
and will be part of the next release soon.


Finally, how can customize the templates?

I'm totally lost already. :D The docs on the support/templates/customization only says "if you wanna cutomize more that single file, use scaffolds" where "scaffolds" is link to support/templates/.
Anyway. What you use currently with latest updates? How should override templates used by generate-project for example? Should I set them in ~/generate/project/templates or ~/generate/templates, or to ~/templates how it is said on generate-projects docs folder (i believe? it was before few minutes but..)?
I wanna start update everything this night and wanna start using verb, generate and update completely.  I have much things to push, and start working on and am exited to do it; and i dont have the time and willing to deal with such stuff. And actually that's the reason why I didn't have contribs recently - from 4900 to 3200... Nevermind.
You know, i'm The Unlucky guy :D that always have some fails using your libs ahahha, jk (some sort).

I don't even know what this issue is about. It sounds like you found a broken link in the docs, but you didn't even link to it, which creates even more work just to ask for it. Feel free to create an issue about a specific thing without ranting, or just don't use generate, verb or assemble until the docs for all of them are complete. We don't have the bandwidth to write documentation as issue responses.

I don't even know what this issue is about.

It's strictly about how to customize the templates of no matter what generator i use.

How should override templates used by generate-project for example? Should I set them in ~/generate/project/templates or ~/generate/templates, or to ~/templates how it is said on generate-projects docs folder (i believe? it was before few minutes but..)?

For the last 2-3 moths I've seen all of these directories in the couple of readmes and in the docs, so finally, i don't know which one to use.

Then please just focus the issue on what it is, a simple broken link in unpublished, draft documentation.
The folder for custom templates is ~/templates.
if you want to see the code, 100% of the logic for this feature is right here.

@tunnckoCore you pointed to a support template that is used when building docs and it has the draft flag set. Those aren't completed docs and the feature might not exist.

couple of readmes and in the docs

If you see information that is incorrect in the readmes, please open an issue that points to that readme. I only recall discussions in issues about how to configure customizable templates, the only one that has been implemented is ~/templates.

ooooohhhh, see what you did? You know you're in deep doodoo when @doowb steps in. no more shenanigans, no more tomfoolery, no more ballyhoo.
Sincerely though, my apologies. Here is an updated link with the docs for customizing templates.

lol, don't... click... that... link

Unless you want a good laugh

Not sure what @doowb's referring to.

I remember when someone rick-rolled me with that a few years ago. but I forgot how bad it was so I remove it lol. it's just weird


Add hooks in base validator, remove moment dependency, default options

Add buildOptions and processOptions hooks
Default options for validators (#38)
All options can be functions that are called right before validate
via processOptions
Removed moment dependency (#30)

@stefanpenner ready for review :rocket:

SGTM


Can't get semantic completion in c++ file.

I rebuild ycmd with option --clang-completer and found llvm 4.0.1 will be downloaded to be used. But I have llvm.5.0 in my machine instead of llvm 4.0.1. Is this the reason?

You'll need to ask the ycmd project.

@abingham By the reply from here, It's said that to update the ycmd dependency would be helpful.

We don't have ycmd as submodule in our repository. So you have to update ycmd.


VSCode built-in Source Control does not support commit trailers

Type: Bug
For our projects, we are using Gitlab Changelog feature to automatically generate changelogs based on commit titles and trailers.
https://docs.gitlab.com/ee/user/project/changelogs.html
In order for the Gitlab Changelog feature to detect a commit, it needs to have a trailer. When commiting a message using VSCode Source Control I cannot seem to add a commit trailer that could be recognized by Gitlab Changelog API.
for example, I can commit my change using CLI:
git commit -m "commiting with trailer" --trailer "Changelog: added"

I have also managed to succesfully add a commit trailer using Fork by simply filling the commit description field and adding Changelog: added

I have initially thought that a trailer is just part of the commit so I have tried the following in the VSCode source control:

When checking this on the repository, everything looks ok:

But when trying to generate a changelog, it does not seem to detect the commits that were performed using Source Control but it can detect commits that were performed using Fork or CLI.
PS C:\Users\petrikas.lu\Desktop\WORK\gitchangelog-test\my_project> glab changelog generate
## 3.5.0-19-g5a89eda
 (2023-12-20)

### added

- [Another commit using fork](embeded-programmers/gitchangelog-test@9889ae912d162ca546813aea108a531c4ebfa2c5) ()

- [Added feature using Fork Changelog: added](embeded-programmers/gitchangelog-test@faa951e4f07ef31d0a4abb419406f4c9aaed5a40) ()

- [Commit with trailer using command line](embeded-programmers/gitchangelog-test@d2bc0ad1d9ed32620de239e93170f426b251cfde) ()

I would appreciate if someone could shed some light on Source Control feature on VSCode and whether there is a possibility to add a trailer so the Gitlab Changelog API can detect it. Thanks in advance.
 Are there any updates regarding this?

this would be a handy feature
I’ll add on my own that it would be convenient if you could add pre-filled trailer templates as an optional setting

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Improve compatibility for extension again.

Fix #30 again.

Uh... I guess your Travis is not configured properly. Otherwise here must be a comment from Travis.

Thanks again, we can use it in today extension now.


Lower annotation pollution on PRs

Description
I propose to update the annotation for codecoverage to error docs, because warning inserts to many annotation making unreadable the PRs
Changes Made

Updated golang.yaml workflow

Related Issues

Checklist

[X] I have used a PR title that is descriptive enough for a release note.
[ ] I have tested these changes locally.
[ ] I have added appropriate tests or updated existing tests.
[ ] I have tested these changes on a dedicated VM or a customer VM [name of the VM]
[ ] I have added appropriate documentation or updated existing documentation.

Seems there is a problem related to markdown workflow @cosimomeli :disappointed:


Remove *.cmake from .gitignore

I'm not sure how this crept in.  This could've caused issues with lost changes to .cmake files under the CMakeModules folder if the developer wasn't careful.

Change Description
Remove *.cmake from .gitignore.

Consensus Changes

API Changes

Documentation Additions

This was there for people doing in-tree builds. The file contains a boat load of other paths for in-tree builds, should those be removed too?

https://stackoverflow.com/questions/3637660/how-to-exclude-file-only-from-root-folder-in-git
Maybe something like:
.cmake
!CMakeModules/.cmake


Easier Download for server core

When working on a server core env, it is not that easy to download the installer from the web or copy it from my pc to the server core. Adding information like aka.ms/WACDownload to the installation instructions would be very helpful!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 49b4fd75-78b8-2a23-f908-9b048f04d831
Version Independent ID: ff42b689-4845-e9f0-d124-292b614fd016
Content: Install Windows Admin Center
Content Source: WindowsServerDocs/manage/windows-admin-center/deploy/install.md
Product: windows-server
Technology: manage
GitHub Login: @jwwool
Microsoft Alias: jeffrew

Yes! it most certainly is. Thank you.

You can use the Powershell command Invoke-WebRequest to download the file to the currently logged on users profile folder on core as follows.
Invoke-WebRequest https://aka.ms/WACDownload -OutFile $env:USERPROFILE\windowsadmincenter.msi -Use
BasicParsing

Yeah, thanks.
I know that in the meantime :).
But this instructions should be added to the official documentation, right?

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Generated USDZ files don't work anymore on VisionOS 1.2 beta

Description
External issue with VisionOS 1.2 beta, I think worth tracking here as well.
This has been broken before, see https://github.com/google/model-viewer/issues/4354, now it's just broken in a different way.
Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=272575
cc @elalish @grorg
Live Demo

https://modelviewer.dev, click on the AR icon at the bottom right
https://engine.needle.tools/samples/musical-instrument/
(not using model-viewer but a similar USDZExporter approach as in model-viewer, to show it's not just a model-viewer issue)

Browser Affected

[ ] Chrome, version: xx.x.xxxx.xx
[ ] Edge
[ ] Firefox
[ ] IE
[X] Safari

OS

[ ] Android
[ ] iOS
[ ] Linux
[ ] MacOS
[ ] Windows
[X] VisionOS

AR

[ ] WebXR
[ ] SceneViewer
[X] QuickLook

@hybridherbst - Out of curiosity... have you tried with an untextured model? Either a GLB that has no textures. Or using a ThreeJS primitive with no texture? Wondering what your experience is on VisionOS.

What do you mean? Usually that works too but here but the USDZ rendering is broken, instead the data handling is broken do QuickLook doesn’t even receive the data.
Generally untextured works too; and on visionOS even vertex colors do

Not sure. But per my findings for iOS here https://github.com/google/model-viewer/issues/4746#issuecomment-2061692755 I have textured models that were smaller in blob size and quicker to generate but failed to open in ARQL compared to some untextured models that were bigger in blob size and took longer to generate but did open in ARQL.

@hybridherbst - the related issue in iOS has just been fixed in 17.5 beta 4.


”Cucerdea”, ”Bord”, ”Șeulia de Mureș” are listed in the drop-down menu

Description:
When user writes ”Cucerdea”, ”Bord”, ”Șeulia de Mureș” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cucerdea"

Expected results
The location appears in the drop-down menu as "Sat Cucerdea, MUREȘ (Cucerdea)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Șeulia de Mureș"

Expected results
The location appears in the drop-down menu as "Sat Șeulia de Mureș, MUREȘ (Cucerdea)".


Ignore dependency order for injected implementations

When using a gradle plugin (internal or external such as detekt) it can sometimes inject implementations at the top of the list. These can 1) have a version and 2) aren't injected in the correct order so the version checking and order checking features of the analysis plugins don't really work.
Is there a way when doing the filtering (https://github.com/jjohannes/gradle-project-setup-howto/blob/87c42549a63e13933e35db960132eda869f632b9/gradle/plugins/dependency-analysis-plugins/src/main/kotlin/org.example.dependency-analysis.gradle.kts#L12-L19) to ignore injected depedencies?

Yes - you already found the right place to handle such 'special cases'. There is no way, as far as I know, to identify such dependencies automatically. The plugins use the same Gradle API as the build scripts when adding a dependency. You would have to explicitly ignore those dependencies. For example by adding a condition like this:
&& !(it is ExternalModuleDependency && it.group == "org.jetbrains.kotlin" && it.name == "kotlin-stdlib")


Better error message for missing Python function arguments

Python 3.3 has improved its error messages for missing arguments in function calls:
Python 3.3.0a0 (default:fe0497bd7354, Sep  3 2011, 10:14:20)
[4.4.5](GCC) on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> def f(a,b,c,d=None): pass
...
>>> f(1,2,d=4)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: f() missing 1 required positional argument: 'c'

This is a helpful improvement, Cython should follow.
Migrated from http://trac.cython.org/ticket/726

I just ran into this as well. If the function f is defined in cython, you get:
>>> f(1,2,d=4)
...
TypeError: f() takes at least 3 positional arguments (2 given)

which is indeed confusing / less useful than what a pure python function gives.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-26-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3670

Questions ?
Please refer to the Backport tool documentation


FSI hangs if illformed string is inserted

FSI hangs if an illformed string is inserted.
Repro steps

Open FSI in VS or via command prompt
Type in let test = """\"""";;
See that FSI hangs

Expected behavior
FSI doesn't hang up and show some error.
Actual behavior
FSI hangs up without error.
Known workarounds
Don't type in illformed strings.
Related information
Microsoft Visual Studio Community 2017
Version 15.8.0
VisualStudio.15.Release/15.8.0+28010.0
Microsoft .NET Framework
Version 4.7.03056
Installierte Version: Community
Visual F# Tools 10.2 für F# 4.5   <IP_ADDRESS>.  Commit Hash: c55dd2c3d618eb93a8d16e503947342b1fa93556.
Microsoft Visual F# Tools 10.2 für F# 4.5

Note that it doesn't hang, it is waiting for more input and the string to be completed.
I'm not sure there is a more graceful way to handle this, do you know any REPL that handle this better that we could draw inspiration from?

Good to see others are stunned by this too. This is a duplicate of #4802.

Perhaps an improvement is to show a message hint on enter, since that usually executes what's already there: "Quoted string detected that wasn't properly closed, expected a quote character."

thanks

Oh, there was even an older one! :D


All keybindings ignored when iTerm2 is focused

I've tried most key bindings provided in the sample config file, and all of them are ignored when iTerm is focused.
Everything works fine when another app is focused.

Randomly disabled "Secure Keyboard Entry" from the settings, then looked for that in the opened issues for Chunkwm and found the following:

You have most likely activated Secure keyboard entry in iTerm. There is usually an entry to enable / disable this in the menubar.

🤦♂
Sorry for the noise..
I would suggest adding this to ChunkWM's FAQ.

This is already mentioned in the readme for skhd. I don't think it belongs in the chunkwm repo because these are two completely separate programs that are not necessarily bundled together.

Oh right I missed that.
But I guess I did not know Secure Keyboard Entry was the cause of my issue, so I couldn't really search for it.
Maybe it's just me, but I spent a lot of time on {google, stackoverflow, github issues} trying to find the cause of my issue, and really solved it by pure luck.
I think I accidentally activated Secure Keyboard Entry while I was trying key bindings for chunkwm (via skhd).
Thanks for your hard work on all of this !

Hey, maybe the following line should be changed to specify that it's referring to the terminal apps?

Secure Keyboard Entry must be disabled for skhd to receive key-events.

to

Secure Keyboard Entry in your terminal app (e.g. iTerm) must be disabled for skhd to receive key-events.

I had accidentally turned it on and couldn't find out why for a while

Secure Keyboard Entry is not a feature that is exclusive to terminal applications.


Mobile Firefox doesn`t search in selects

only on mobile version Firefox
and only on letters - select doesn`t search items.
it can be reproduced on Choices demo page.

I’m experiencing the same. If it helps for solving the issue: For me the filtering works when I insert two spaces after a word.

Any solution?

Same issue on Firefox 68.1.1., android 9. Works as expected on everything else I've tested, mobile or desktop.
Like with space, adding chars like / | - * after the text will also trigger the search.

Any one have a solution?

I'm also still getting this. The FF nightly doesn't have this issue tho.


sails not finding/binding routes (in config/routes.js)

Sails version: 0.12.14
Node version: 8.6.0
NPM version: 5+
DB adapter name: N/A
DB adapter version: N/A
Operating system: Linux

I have a sails app where that we deploy to production inside of a docker container. Somehow the deployed app is not binding any of the routes (however, the app run locally binds all of the routes just fine). I enabled silly logging so that I could follow which routes were bound and confirmed that the routes are not bind bound inside of the docker container. Additionally, I am not seeing any message like 'that controller doesn't exist' so I am assuming that for whatever reason, sails is simply not finding the route config.
I have opened a shell into the running docker container and confirmed that the app structure is ok and that all files are where I expect them to be.
To deploy we first run a babel transpilation:
babel . -d dist --copy-files --ignore node_modules
which basically transpiles all the files (in api and config) and copies them into dist.
Then, we run the following Dockerfile:

FROM node:8.6.0-alpine

##Make Sure You run 'npm transpile' before building the docker image.

# Create app directory
RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app

# Install app dependencies
COPY dist /usr/src/app
COPY .sailsrc /usr/src/app/.sailsrc
RUN npm install --production

EXPOSE 80

CMD PORT=80 NODE_ENV=$NODE_ENV STELLAR_ENV=$STELLAR_ENV node /usr/src/app/app.js

As you can see it is very simple. I just copies the dist and .sailsrc into /usr/src/app, installs dependencies (package.json is in dist as well) and then just runs the app with a few environment variables.
Thanks in advance. Please let me know if I can provide any more helpful info.

Here is the output when I run the app locally:
Successfully created core model associations.

Successfully created horizon model associations.
verbose: verbose: logger hook loaded successfully.
verbose: verbose: request hook loaded successfully.
verbose: verbose: Overriding ejs engine config with ejslocals to implement layout support...
verbose: verbose: views hook loaded successfully.
verbose: verbose: responses hook loaded successfully.
verbose: verbose: controllers hook loaded successfully.
verbose: verbose: Loading policy modules from app...
verbose: verbose: Finished loading policy middleware logic.
verbose: verbose: policies hook loaded successfully.
verbose: verbose: services hook loaded successfully.
verbose: verbose: csrf hook loaded successfully.
verbose: verbose: cors hook loaded successfully.
verbose: verbose: i18n hook loaded successfully.
verbose: verbose: Setting default Express view engine to ejs...
verbose: verbose: http hook loaded successfully.
verbose: verbose: Preparing socket.io...
silly: silly: ad hoc redis client ready (pub) (80)
silly: silly: ad hoc redis client ready (sub) (80)
verbose: verbose: sockets hook loaded successfully.
verbose: verbose: Built-in hooks are ready.
verbose: verbose: Instantiating registry...
verbose: verbose: Loading router...
silly: silly: Binding route ::  all /* (REQUEST HOOK: addMixins)
silly: silly: Binding route ::  all /* (RESPONSES HOOK: addResponseMethods)
silly: silly: Binding route ::  all /* (I18N HOOK: addLocalizationMethod)
silly: silly: Binding route ::  all /* (VIEWS HOOK: addResViewMethod)
verbose: verbose: Policy-controller bindings complete!
silly: silly: Binding route ::   /* (CSRF HOOK: CSRF)
silly: silly: Binding route ::  all /* (CORS HOOK: sendHeaders)
silly: silly: Binding route ::   /csrfToken (CORS HOOK: sendHeaders)
silly: silly: Binding route ::  options /csrftoken (CORS HOOK: preflight)
silly: silly: Binding route ::   /csrfToken (FUNCTION: csrfToken)
silly: silly: Binding route ::  get /__getcookie (SOCKETS HOOK: GET /__getcookie)
silly: silly: Binding route ::  get /csrfToken (FUNCTION: csrfToken)
verbose: verbose: All hooks were loaded successfully.
verbose: verbose: Starting app at /usr/src/app...
verbose: verbose: Running the setup logic in `sails.config.bootstrap(cb)`...
info: info:
info: info:                .-..-.
info: info:
info: info:    Sails              <|    .-..-.
info: info:    v0.12.14            |\
info: info:                       /|.\
info: info:                      / || \
info: info:                    ,'  |'  \
info: info:                 .-'.-==|/_--'
info: info:                 `--'-------'
info: info:    __---___--___---___--___---___--___
info: info:  ____---___--___---___--___---___--___-__
info: info:
info: info: Server lifted in `/usr/src/app`
info: info: To see your app, visit http://localhost:80
info: info: To shut down Sails, press <CTRL> + C at any time.
debug: debug: -------------------------------------------------------
debug: debug: :: Tue Oct 10 2017 14:47:42 GMT+0000 (UTC)
debug: debug: Environment : development
debug: debug: Port        : 80
debug: debug: -------------------------------------------------------

I have even tried running the application directly from the dist directory (on my local machine) by imitating the commands run inside the Dockerfile (i.e. npm install --production and the startup command) and it found and bound the routes just fine...

Ok, after more research, it looks like sails is for whatever reason getting to this line for all our routes:
https://github.com/balderdashy/sails/blob/master/lib/router/bind.js#L84

After more research:
Looks like the above is expected behavior.
I believe the problem is that the controllers are not getting loaded.

Ok, I have solved the issue. Looks like the directory Controllers vs controllers causes OS dependent behavior even with the same version of node (i.e. it works on windows but fails on linux).

@istrau2 that makes sense-- the filesystem on Windows is case-insensitive, so naming your directory api/Controllers/ technically works, since it gets interpreted the same way as api/controllers/.
I think the solution here is a better error message to help avoid confusion about this.  Tracked in https://trello.com/c/idpOIypE

 AASU, I don't want modules to be seemingly loaded successfully, but then not actually work on different filesystems and operating systems. In other words, I want to see a better error if any of the configured sails.config.paths don't actually exist on disk verbatim, with the exact same capitalization.

@mikermcneil Makes sense. Thanks.

Case sensitive paths are standard production-deploy trap.
I suggest doing 2 things:

In PROD mode - display errors on missing system paths
In DEV mode - also display warnings, when file is loaded, but path has case-sensitive issue


Fix path resolution in Pages esbuild

fix: the pathing for the template was resolving using __dirname into the esbuild file which then used a relative path back from pages. When ran inside a test would get a resolved absolute path to the template from "pages/pages/functions/template-workers.ts

Oh interesting...
https://github.com/cloudflare/wrangler2/runs/5892721660?check_suite_focus=true#step:6:942
This implies that the original pathing is correct, at least for how that e2e test is setup.

Tests are failing too, expected?

So the problem is that esbuild does not rewrite __dirname when bundling. So it refers to the directory containing the bundle, rather than the directory containing the original source file.
This is problematic since you do not necessarily know where the final bundle will be run compared to the file that is being loaded.
Apparently there there is an esbuild plugin to solve this.

So the problem is that esbuild does not rewrite __dirname when bundling. So it refers to the directory containing the bundle, rather than the directory containing the original source file. This is problematic since you do not necessarily know where the final bundle will be run compared to the file that is being loaded. Apparently there there is an esbuild plugin to solve this.

I will take a look into implementing the plugin in this PR then we can discuss adding it to ESBuild for the Wrangler side as well.

I'm curious too bout what @GregBrimble asked; could you explain exactly what this fixes? I don't think I understand

https://github.com/evanw/esbuild/issues/859

Any update on this @JacobMGEvans ?

Any update on this @JacobMGEvans ?

Not at the moment.

Closing due to work in #860


Adding Greek and Slovenian translations.

Thanks for your contribution to Select2, @rogercoder.
We have another pull request that is open which adds translations for the Greek language at https://github.com/select2/select2/pull/4139. I, unfortunately, am not familiar enough with the Greek language to be able to properly judge which pull request should be accepted, so I'm not sure which one I should look into merging.
Most of the translations have minor differences (I'm not sure which one is more accepted) and it appears that your translations do not actually handle pluralization.

it appears that your translations do not actually handle pluralization.

Yep, in the process we typically use with our translation service we just
get things translated as "item(s)" rather than trying to satisfy the
sometimes tricky logic of plurality used in different languages.
If it makes things easier for you I can submit a different pull request
with only the Slovenian translations.
-Roger
On Wed, Feb 3, 2016 at 3:58 PM, Kevin Brown<EMAIL_ADDRESS>wrote:

Thanks for your contribution to Select2, @rogercoder
https://github.com/rogercoder.
We have another pull request that is open which adds translations for the
Greek language at #4139 https://github.com/select2/select2/pull/4139.
I, unfortunately, am not familiar enough with the Greek language to be able
to properly judge which pull request should be accepted, so I'm not sure
which one I should look into merging.
Most of the translations have minor differences (I'm not sure which one is
more accepted) and it appears that your translations do not actually handle
pluralization.
—
Reply to this email directly or view it on GitHub
https://github.com/select2/select2/pull/4146#issuecomment-179540209.


Automatically convert a RouterTarget into a Route (and back)

Hey there :wave:. First of all thanks for all the efforts on 0.6.0. The new macro looks amazing!
In the old yew router implementation I had some conversion from Route to RouterTarget (and back), like here:
https://github.com/saschagrunert/yew-router/blob/5a641a0cf700c50fb63250404e3a5aa1a8b37d49/src/lib.rs#L18-L43
Do you think we can add this here as well? Because then I could change the route a bit simpler like here: https://github.com/saschagrunert/webapp.rs/pull/579/files#diff-666c67171bd81a247b854ba2bea31b18R61

I believe there exists a function to convert a type that implements Switch into a Route, but calling it in that position would be annoying.
I think that doing a blanket impl of impl From<SW> for Route<T> where SW: Switch might be possible. The extra T type parameter on Route may throw a wrench in things, but I'll look into it.

I'm dumb, I had a function to convert SW: Switch to Route<T>, and had it public, but neglected to reexport it from the lib module. I've made it permanently private and now have implemented From to convert switches back into routes.

Hey, do you think that we can also implement the conversion back from the derived target to yew_router::route::Route? This does not seem to be supported for 0.6.1 but would be handy in this place:
https://github.com/saschagrunert/webapp.rs/blob/453dc9bb0670999fbc6c0b98fbbbca80036a96b3/frontend/src/component/root.rs#L86
This currently results in the error:
error[E0277]: the trait bound `route::RouterTarget: std::convert::From<yew_router::route::Route<()>>` is not satisfied
  --> frontend/src/component/root.rs:86:67
   |
86 |             Message::Route(route) => self.child_component = route.into(),
   |                                                                   ^^^^ the trait `std::convert::From<yew_router::route::Route<()>>` is not implemented for `route::RouterTarget`
   |
   = note: required because of the requirements on the impl of `std::convert::Into<route::RouterTarget>` for `yew_router::route::Route<()>`

I don't think From will ever work here, because the operation of converting from the route string to a pre-defined implementer of Switch is fallible as the route may not match one of the provided matcher strings.
When addressing this PR, the compiler complained about implementing TryFrom for T: Switch, although I don't recall the exact reason. I'll try to re-investigate that though.
In the meantime, calling RouterTarget::switch(route) should give you an Option<RouterTarget>. There are patterns for "redirecting" that I haven't adequately documented for calls to switch() that return None.


Options in bottom sheet menu are executed for previously selected row layout and not for current.

When the more option for a particular row is selected (course or module) the bottom sheet fragment opens up. If this bottom sheet is dismissed without selecting any of the options and more option for another row is clicked, selecting the options from this list will perform selected operation like "mark as read" for the previously selected row.
Consider there are three courses in My Courses fragment A, B and C. Click on the more option ellipses for course B and dismiss the bottom sheet without selecting any option. Now click on more options ellipses for course A and select "mark all as read". On selecting the option the contents of course B will be marked as read an not of A. If no option is selected from the bottom sheet that appears for A and it is dismissed too, selecting "mark all as read" from bottom sheet for course C after that will mark contents of course B as read.
Similar problem is seen in case of modules in Course Section Fragment. The following is also noticed in case of two modules with different download status.

For the given course "General Biology Course Calendar" is not downloaded hence the above options are displayed on clicking on more ellipses. Now, if the bottom sheet is dismissed and more options for another module "Revised Handout" (downloaded) is clicked...

... the above list of options is displayed but if the second option in the list "Re-download" (with option id 1) is selected, the previously selected module (General Biology Course Calender) is shared. (The option id for "share" was 1 for the previous options list)
The getLayoutPosition() function returns the layout position of the currently selected layout when the more option is clicked (the header of the bottom sheet and the options list is correctly displayed). But once any of the options from the bottom sheet is selected, the function returns the position of the layout that was first selected (and the bottom sheet was dismissed without selecting any option).

I think issue #268 was a duplicate of this. That issue was fixed in 60cb1ac9ab99bacbf7589e53450e89fd24204568.  Further more, I couldn't reproduce this issue on MyCoursesFragment or in CourseContentFraagment. Please try reproducing the bug on development and report back. If not reproducible, close the issue as well.

This issue seems to be fixed in '60cb1ac9ab99bacbf7589e53450e89fd24204568'.


Improve tls certificate documentation

Rereading this I'm actually not so sure what value this does bring.
Maybe we could add a generic warning, which really isn't specific to TLS imho, that if you want to do sweeping changes to your Cloudconfiguration, e.g. when testing things, building an evaluation lab etc. you are way better off always to reprovision from scratch your complete cloud.
E.g. if you decide in the middle of the cloud install to switch to let's encrypt, or change your cinder backend I wouldn't bet my life on it that everything is properly cleaned up by neither kolla, nor osism.
These are - at it's core - configuration management tools, which have trouble tracking current state. These are not infrastructure as code tools such as Terraform, which do track state.
So there is always the need in ansible to write dedicated cleanup tasks, if you want to purge/remove something. This also assumes that you can just reconfigure any deployed openstack service on the fly, when these store some settings also persisted in databases, which also might not be as easily available to outside changes, even if you would use something like terraform.
The result of all these constraints is, that you usually figure out a working deployment setup, with all your tested settings in git, and then deploy that once.
It's relatively smooth to upgrade this then, and with care, you also can introduce changes, but sometimes you need to do manual cleanups, given the above constraints.
So in general I would put this up as a warning.
A Cloud Infrastructure isn't something where you can easily rip out parts and just replace them with something else.
That's even the case if you run everything inside k8s openstack-operators instead of ansible, as these are usually also full of assumptions on what a "supported" configuration looks like.
In practice, this often means only one or two knobs are actually configurable by the end user and the rest is enforced via the operators code, which can't be easily changed as well.

I don't think a detailed warning in the loadbalancer guide makes sense. This is a rather global feature about how cloud provisioning works in general.
So we could add a global warning to make large changes with care and that they might require manual cleanup.
Thanks

I agree with you in general. Actually, it would be better to bundle such things in a kind of “pre-installation checklist” and provide information on this topic.
As a result of a small pilot project that I have with a prospective scs-user of the public sector, I recently started writing something like this. However, it is still in a very very early and very immature stage and I am very happy to receive ideas and contributions.
Nevertheless, I also think it is important to describe this here, because there are specific references to the configuration of domains and certificates (we don't always know which path a user takes or whether the user is aware that information is provided elsewhere).


Add a routine to update pip

Add python -m pip install --upgrade pip somewhere in the script

Added in bced4d386e18ec321a93a3e1e6d9475a8e46effa


kf_setImageWithResource isn't tolerant to nil NSURL

The programmer must be sure that NSURL in kf_setImageWithURL isn't nil.
If kf_setImageWithURL accepted optional NSURL and select placeholder image in the case of nil, it would be handy.
I will try to send a pull request If you think it's a  good idea.

Hi, @kostapappas
Thanks for the idea. A pull request on this will be welcomed!

I am having this same issue. I have to make a network query to get a URL of an image before I then download the image. What would be cool is if I can check if an image is already cached based on a resource cache key and if not then I'd run my two network calls (get the URL, then get image from the URL).

As I workaround I used the code below. Is this okay?
            if let image:Image = KingfisherManager.sharedManager.cache.retrieveImageInDiskCacheForKey("112312321") {
                cell.imageViewAvatar?.image = image
            }


Entry form checkbox

What does this change?
This should fix the bug with the form not filling in correctly. My previous changes with the defaultFormState were causing issues with the existing dirtyField reconciliation on the edit page. This now computes the default state depending on whether the toilet data is populating the form.
How was this tested?
Local tests for now but plan to test against the E2E using the tags we discussed.
Documentation
If applicable to your changes, have you:

[ ] Added/edited the appropriate documentation
[ ] Added any component(s) to Storybook

Closing to re-open from this repository


QE : Access Control - Pod role binding + Service Account

Includes :

Pod role bindings
Pod service account

Some tests are dependant on the bug fixes in CNF test implementation. Once the fix goes into the master, all QE tests here should be green.
Dependant on this PR

Presently one test case with no service account would fail as the test implementation in CNF contains bug which needs to be fixed.

Service account check has been fixed and merged.

@theemj Please retest. All are green with new changes now. So, it is ready to be merged.


aggregate-images: Unexpected results

When processing images with only natural numbers in mode/majority mode, aggregate-images generates images containing non-natural numbers. Expected result is for all voxel values in the output to be members of the set of voxel values in the input images. Sample session (where the result agg.nii.gz is expected to be identical to the input seg95.nii.gz):
$ info seg95.nii.gz | grep type
Voxel type is unsigned char
$ calculate-element-wise seg95.nii.gz
Mean = 9.9747
Standard deviation = 20.819
Extrema = [0, 95]
Range = 95
$ aggregate-images mode seg95.nii.gz seg95.nii.gz seg95.nii.gz -output agg.nii.gz
$ info agg.nii.gz | grep type
Voxel type is float
$ calculate-element-wise agg.nii.gz
Mean = 10.542
Standard deviation = 20.553
Extrema = [0.74219, 94.258]
Range = 93.516
$

@soundray Could you check the linked PR #692 to see if that fixes the issue? Thanks!

Also please feel free to review the changes and comment if anything seems odd. Given the lack of testing, this would be very good to have a second pair of eyes check the validity of the change.

Thank you for the PR. Here are the updated test results:
$ info seg95.nii.gz | grep type
Voxel type is unsigned char
$ calculate-element-wise seg95.nii.gz
Mean = 9.9747
Standard deviation = 20.819
Extrema = [0, 95]
Range = 95
$ aggregate-images mode seg95.nii.gz seg95.nii.gz seg95.nii.gz -output agg.nii.gz
$ info agg.nii.gz | grep type
Voxel type is float
$ calculate-element-wise agg.nii.gz
Mean = 9.9728
Standard deviation = 20.796
Extrema = [0, 95]
Range = 95
$ convert-image agg.nii.gz agg-char.nii.gz -char
$ info agg-char.nii.gz | grep type
Voxel type is char
$ calculate-element-wise agg-char.nii.gz
Mean = 9.9866
Standard deviation = 20.766
Extrema = [0, 95]
Range = 95

It is still strange that the output from aggregating three identical input images is not identical to these inputs. So I break out seg_stats from NiftySeg to get a count of each label (does MIRTK have a tool for this?):
$ seg_stats seg95.nii.gz -Nl temp.csv ; cat temp.csv ; printf '\n'
4.2417e+06,2411,1875,1517,1514,7144,9791,4384,4173,5485,5697,16245,16785,21066,14997,4056,4861,68092,69993,25288,3091,3480,44426,52010,6844,5954,8160,8572,55722,52882,54776,52119,17504,12999,3839,3936,312,267,5041,4812,8067,8091,1103,1104,20371,5966,8978,677,347,894,36815,37495,3785,4425,7102,7429,20247,18707,59516,61095,31407,33339,47643,49308,13118,12389,12009,12236,6312,5944,3655,4011,5617,5747,338,328,1617,1313,281,215,875,432,4108,4443,32989,28377,2895,2371,820,1058,1851,2224,2447,2556,2484,2884
rahec@cx1-103-7-1 [stp:1] { ...ild/seg95-compare }$ seg_stats agg-char.nii.gz -Nl temp.csv ; cat temp.csv ; printf '\n'
4.2417e+06,0,4286,1517,0,8658,9791,0,8557,5485,0,21942,16785,0,36063,4056,0,72953,69993,0,28379,3480,0,96436,6844,0,14114,8572,0,108604,54776,0,69623,12999,0,7775,312,0,5308,4812,0,16158,1103,0,21475,5966,0,9655,1241,0,36815,41280,0,4425,14531,0,20247,78223,0,61095,64746,0,47643,62426,0,12389,24245,0,6312,9599,0,4011,11364,0,338,1945,0,1313,496,0,875,4540,0,4443,61366,0,2895,3191,0,1058,4075,0,2447,5040,0,2884

Pardon the long lines, but the essence is that every third label is as expected (those divisible by 3), and the other two are 0 or otherwise non-matching.
seg95.nii.gz

Hm, one step closer. Thanks for checking and sharing your input file. I will have to add proper tests for these applications, starting with this one...

PS: I thought there was a command similar to IRTK's labelStats, but apparently I didn't migrate it.

There is evaluate-overlap but it gives me strange results, too. I'll investigate and report.

Sorry about that, blame it on my PhD! :-)


Required imports not available with default dependencies

Describe the bug
Importing https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/main/src/aind_codeocean_pipeline_monitor/job.py with the default project dependencies errors:
aind_alert_utils and aind_data_schema_models are imported, but not available.
https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/e3c16abd11ed330230985c6b036384caf88f3b9b/src/aind_codeocean_pipeline_monitor/job.py#L12-L13
To Reproduce
Steps to reproduce the behavior:

Follow the steps in the current readme with the default project dependencies installed (not full)

Looks like aind_data_schema_models is actually required and should be moved to default project dependencies.
aind_alert_utils is optional and could be imported with ... except ModuleNotFoundError:, or imported when used in _send_alert_to_teams().

https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/e3c16abd11ed330230985c6b036384caf88f3b9b/src/aind_codeocean_pipeline_monitor/job.py#L211
This also results in an error (on Windows) due to tzdata not being installed.


Add "Ding" to prompt timeouts

Flash background or similar to say the next question comes up.

Ding when a new prompt appears?
When a new question (with bubbles) appears?
Add a flag to the file "dingOnDisplay"?
Make a ding as an independent component?

complete in https://github.com/Watts-Lab/deliberation-empirica/pull/363

Ding happens on every change - we want it to depend on the startDing parameter of the topic file.


[FIX] Aplicom protocol does not ignore Alive messages

Frame decoder skips ascii digits. All defined protocols start with a letter (e.g. 'D', 'E', etc.)
FrameDecoder unit tests provided
Tested with real device!

fixes issue #3305

Merged, thanks.


Dev mode multi module - 'r' to restart causes incorrect loose app to be redeployed on Linux

On Linux, using liberty-maven-plugin 3.4 or 3.5, run mvn liberty:dev on this sample multi module project: https://github.com/turkeylurkey/lmp-multimodules/tree/main/testCases/typeA
Notice the loose app ear xml initially has war and jar contents:

Press 'r' and Enter to restart the server. This causes the loose app to be redeployed.
Notice the loose app ear xml is missing war and jar contents:

Notice the following errors in the console output:

[INFO] (org.codehaus.mojo.pluginsupport.ant.AntHelper) [ERROR   ] CWWKZ0117E: Application guide-maven-multimodules-ear failed to locate module /guide-maven-multimodules-war-1.0-SNAPSHOT.war of type web
[INFO] (org.codehaus.mojo.pluginsupport.ant.AntHelper) [ERROR   ] CWWKZ0124E: Application guide-maven-multimodules-ear does not contain any modules.

The same issue occurs with both dev and devc
Debug output is attached:
devmode_debug_output.txt

This seems to be due to the same root cause as https://github.com/OpenLiberty/ci.maven/issues/1255, which is caused by this issue in Maven 3.8.2 and 3.8.3 https://issues.apache.org/jira/browse/MNG-7285
If running with Maven 3.8.2:

On dev mode startup, the debug log shows [DEBUG] Number of compile dependencies for guide-maven-multimodules-ear : 10
After using 'r' to restart, debug log shows [DEBUG] Number of compile dependencies for guide-maven-multimodules-ear : 0

This message comes from https://github.com/OpenLiberty/ci.maven/blob/main/liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/applications/DeployMojoSupport.java#L174 which uses MavenProject.getArtifacts()
As a workaround, use Maven 3.8.1 until a fix is available in a new Maven release.


Does not pass given size when overriding message for lessThanOrEqual(int)

I have just started using YAVI, and are trying to write custom messages. The documentation says that I should get the given size of the collection I am validating as arg {2}, but it seems that the collection itself is passed as {2} when I am overriding the message.
This test shows the issue:
var validator = ValidatorBuilder.<List<String>>of()
    .constraint((List<String> l) -> l, "list",
            l -> l.lessThanOrEqual(2).message("{0} had {2} elements, max allowed is {1}"))
    .build();

var violation = validator.validate(List.of("x", "y", "z")).get(0);
assertThat(violation.message(), is("list had 3 elements, max allowed is 2"));

And I get the following assertion failure:
java.lang.AssertionError:
Expected: is "list had 3 elements, max allowed is 2"
     but: was "list had [x, y, z] elements, max allowed is 2"

If I look at the ConstraintViolation, I see this:
ConstraintViolation{name='list', messageKey='container.lessThanOrEqual', defaultMessageFormat='{0} had {2} elements, max allowed is {1}', args=[list, 2, [x, y, z]]}

but removing the overridden .message(..) gives an expected ConstraintViolation with the size as the third ({2}) argument:
ConstraintViolation{name='list', messageKey='container.lessThanOrEqual', defaultMessageFormat='The size of "{0}" must be less than or equal to {1}. The given size is {2}', args=[list, 2, 3]}

@runeflobakk Thanks for your report and investigation! That was quite helpful.
This fix should be included in 0.11.2

Nice! Thank you for lightning fast fix! 🚀


:chore: upgrade node version

Basic Checks
Have you run rush change for this change?

[ ] Yes
[ ] No

If No, please run rush change before, this is necessary.
If adding a new feature, the PR's description includes:

[ ] Reason for adding this feature
[ ] How to use
[ ] A basic example

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
Summary
Detail
How to test it

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support Gemma2 in torchtitan

Are there any plans to support Gemma2 in the torchtitan? I tried to use torchtitan to finetune Gemma2 model, but stuck on the following problem: how to parallelize tied layer in Gemma2 model? Maybe somebody kwon the solution for this problem 😄

If you apply fully_shard to each transformer block and then to the root module, this should work for tied embedding and final linear. The root module will manage both.

I want to shard output embedding layer - I use same strategy as in Llama, but training stacked after first butch
ColwiseParallel(                 input_layouts=Shard(1),                 output_layouts=Shard(-1) if loss_parallel else Replicate(),                 use_local_output=not loss_parallel, )

Do you want to train with 2D parallelism (FSDP + TP)? With TP only?


Error message "Keyboard shortcut conflicts with existing shortcut"

After I re-enable the plugin as described in #67, I get another error:

Steps to reproduce:

Go to the plugins page and disable logseq-automatic-linker
Enable it again.
The error messages show up.

I have exactly the same issue upon update for the plugin; by re-enabling the plugin as described above reproduced the error as well. I am on 1.5.5, which seems to be the latest version.

I just installed this plugin and got the same error message. I solved it by changing the shortcut keybinding from "mod+p" to "mod+alt+p". You can change the keybinding by going to plugins and selecting "open settings".

The error disappeared after I upgraded Logseq to 0.10.3.
But auto-parse links also stopped working, so maybe something changed upstream.

This also applies to Windows for "Ctrl+P" which conflicts with "Move cursor up / Select up" so there needs to be a way out of this


[AutoPR mediaservices/resource-manager] typo: mediaservices/resource-manager/Microsoft.Media/StreamingPoliciesAndStreamingLocators

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4543

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3872


Please add an example showing how to download File data using OrganizationService

As the title suggests.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 85c3eac9-b083-b974-0938-3e8fd19bbb58
Version Independent ID: 2c6dfac6-25b8-876c-2b94-fa9d466007df
Content: File attributes (Common Data Service) - Power Apps
Content Source: powerapps-docs/developer/common-data-service/file-attributes.md
Service: powerapps
GitHub Login: @phecke
Microsoft Alias: pehecke

@fberasategui The File column topics have been updated with new content. Please take a look again.
File columns


[vuln] possible vulnerability

Hi Guys, a friend of mine have recently start using this lib and he's getting something that looks like a possible vulnerability to us.
package main

import (
   "github.com/sirupsen/logrus"
   "github.com/davecgh/go-spew/spew"
)

func main() {
  log       := logrus.New()
  spew.Dump(log)
}

SPEW LOG:
(*logrus.Logger)(0xc000100850)({
 Out: (*os.File)(0xc00000e020)({
  file: (*os.file)(0xc000058120)({
   pfd: (poll.FD) {
    fdmu: (poll.fdMutex) {
     state: (uint64) 0,
     rsema: (uint32) 0,
     wsema: (uint32) 0
    },
    Sysfd: (int) 2,
    pd: (poll.pollDesc) {
     runtimeCtx: (uintptr) <nil>
    },
    iovecs: (*[]syscall.Iovec)(<nil>),
    csema: (uint32) 0,
    isBlocking: (uint32) 1,
    IsStream: (bool) true,
    ZeroReadIsEOF: (bool) true,
    isFile: (bool) true
   },
   name: (string) (len=11) "/dev/stderr",
   dirinfo: (*os.dirInfo)(<nil>),
   nonblock: (bool) false,
   stdoutOrErr: (bool) true,
   appendMode: (bool) false
  })
 }),
 Hooks: (logrus.LevelHooks) {
 },
 Formatter: (*logrus.TextFormatter)(0xc000058300)({
  ForceColors: (bool) false,
  DisableColors: (bool) false,
  ForceQuote: (bool) false,
  DisableQuote: (bool) false,
  EnvironmentOverrideColors: (bool) false,
  DisableTimestamp: (bool) false,
  FullTimestamp: (bool) false,
  TimestampFormat: (string) "",
  DisableSorting: (bool) false,
  SortingFunc: (func([]string)) <nil>,
  DisableLevelTruncation: (bool) false,
  PadLevelText: (bool) false,
  QuoteEmptyFields: (bool) false,
  isTerminal: (bool) false,
  FieldMap: (logrus.FieldMap) <nil>,
  CallerPrettyfier: (func(*runtime.Frame) (string, string)) <nil>,
  terminalInitOnce: (sync.Once) {
   done: (uint32) 0,
   m: (sync.Mutex) {
    state: (int32) 0,
    sema: (uint32) 0
   }
  },
  levelTextMaxLength: (int) 0
 }),
 ReportCaller: (bool) false,
 Level: (logrus.Level) info,
 mu: (logrus.MutexWrap) {
  lock: (sync.Mutex) {
   state: (int32) 0,
   sema: (uint32) 0
  },
  disabled: (bool) false
 },
 entryPool: (sync.Pool) {
  noCopy: (sync.noCopy) {
  },
  local: (unsafe.Pointer) <nil>,                 <<< is this block correct?
  localSize: (uintptr) <nil>,
  victim: (unsafe.Pointer) <nil>,              <<< is "victim" and "victimSize" correct?
  victimSize: (uintptr) <nil>,
  New: (func() interface {}) <nil>
 },
 ExitFunc: (logrus.exitFunc) 0x4a5380
})

The last part seems a bit suspicious, is this normal ? , is "victim" and "victimSize" part of the library?
Looking forward to hearing from you!
Regards,
Julio

If it's the words "victim" and "victimSize", then I think those come from https://github.com/golang/go/blob/master/src/sync/pool.go#L51; see https://github.com/golang/go/commit/2dcbf8b3691e72d1b04e9376488cef3b6f93b286

oh my mistake, please ignore this, you got to admit name convention is a bit confusing hehe.

Yes, the naming is definitely confusing; I also had to do a quick search to be sure (https://grep.app can be useful for that: https://grep.app/search?q=victimSize&filter[lang][0]=Go)

oh that's very useful, we couldn't find it in the lib that's why we came across with the idea of a vuln. Thank you for your help!


[Feature Request]: Add solution to LC Problem 1108

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Defanging an IP Address
Use Case
Defanging an IP Address
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Ajay-Dhangar assign me this issue under GSSOC'24

@Ajay-Dhangar assign me this issue


Update example command to use non-deprecated flags

Based on https://github.com/istio/istio/pull/24567
Grafana is now available as an addon and can be set using the samples/addons/grafana.yaml deployments.

@douglas-reid  PTAL?

In response to a cherrypick label: new pull request created: #27124


Add a new font constructor

Not very exiting on its own... Takes an array like this:
 "FONT" (4 bytes)
number of characters (1 byte)
fixed character width (1 byte)
character height (1 byte)
vertical spacing (1 byte)

variable character widths (1 byte per character)

character data (fixed w * ((height + 7) / 8) bytes per character)

Sometimes the not exciting things are the most important! Thank you.

The exciting bit is in the other repo :smile:


Wrong sentence processing when printing

Occasionally, the api assign the wrong stack of data of the tag sentences received, making the index of the response being assign to 1, while the index 0 being a wrong sentence that should be part of the last packet processed.
This problem breaks when trying to print data, but it doesn't manifest very often.

Increased the channel id used with the ".tag", possibly fixing this issue, which could be repeating tags due to the small size of the tag (2-3 chars).
Will leave the issue open for while before confirming the bug is gone.

Been using for quite some time and haven't encountered the issue since. Closing for now.


Using sentence-style capitalization to fit PatternFly 4 standards

https://www.patternfly.org/v4/design-guidelines/content/grammar-and-terminology#sentence-style
rg "[A-Z][a-z]+\s[A-Z]" --type-add 'tsx:*.tsx' -t tsx

@newswangerd Please, take a look if the changes are OK.


[SOLVED] CAT working on 10.3.3

I have successfully got CAT to work on macOS High Sierra.
I am using a MacBook Pro 15' Late 2011, with the upgraded CAX card, from the 2012 model.
It should be noted that it was a fresh install of High Sierra on a Samsung 850 Evo.
Initially I ran the tool, and it did not do anything, except add the "Allow Handoff between this Mac and your iCloud devices" checkbox.
I then -

Signed out of iCloud
Rebooted
Signed into iCloud
Clicked the "Allow Handoff between this Mac and your iCloud devices" a couple of times to make sure it was actually on
Signed out and closed FaceTime.
Opened, and signed back in to FaceTime.
Then magically all Continuity features, with the exception of Auto-Unlock, began to work.

Thanks to the developers for continually supporting this amazing tool.

Same setup with Late 2011 Macbook High Sierra 10.13.3 and iPhone 7s plus. Worked wonders! thanks.

OS 10.3.3 is not High Sierra.   Perhaps you mean 10.13.3 ?

Can't speak for Rushil-Kisoon, but I'm now on High Sierra 10.13.4 and everything works fine still.

can someone confirm if CAT is working on 10.13.5?

I'm just coming across this and wondering if my MacBookAir4,1 running 10.13.5 will run this without any problems

On 10.13.5 CAT installation runs smoothly but MBP crashed on reboot. Could be because of Hackintosh though..

I have successfully got CAT to work on macOS High Sierra.
I am using a MacBook Pro 15' Late 2011, with the upgraded CAX card, from the 2012 model.
It should be noted that it was a fresh install of High Sierra on a Samsung 850 Evo.
Initially I ran the tool, and it did not do anything, except add the "Allow Handoff between this Mac and your iCloud devices" checkbox.
I then -

Signed out of iCloud
Rebooted
Signed into iCloud
Clicked the "Allow Handoff between this Mac and your iCloud devices" a couple of times to make sure it was actually on
Signed out and closed FaceTime.
Opened, and signed back in to FaceTime.
Then magically all Continuity features, with the exception of Auto-Unlock, began to work.

Thanks to the developers for continually supporting this amazing tool.

This worked for me in a Mid 2011 Mac Mini (Server) and 10.13.6
Thanks!


Add documentation about rubocop-daemon

I added documentation to the Integrations documenation page. Please let me know if I should add a note elsewhere as well.
Closes #10172.

Nice 👍


not working nowadays

Hi.
you have tested your playbook in 2018?

@Nurlan199206 Yes, I am still using it, but only for Ubuntu 16.04. What is the problem?

testing on ubuntu 18.04, trying to run dkim.yml
---
- hosts: myserver
  user: root
  sudo: False
  roles:
    - role: sunfoxcz.dkim
      dkim_selector: mail
      dkim_domains:
       - domain1.tld
       - domain2.tld

ansible-playbook /home/nurlan/ansible-dkim/dkim.yml
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'
[DEPRECATION WARNING]: Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' (default). This feature will be removed in version 2.6. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.
ERROR! the role 'sunfoxcz.dkim' was not found in /home/nurlan/ansible-dkim/roles:/root/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:/home/nurlanizimbetov/ansible-dkim
The error appears to have been in '/home/nurlan/ansible-dkim/dkim.yml': line 6, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
roles:
- role: sunfoxcz.dkim

You have problem in your system.

Ansible can't find role. Put it for example to /etc/ansible/roles or update roles_path directive in /etc/ansible/ansible.cfg file.
First warning is related to hosts file, which you probably don't have or your host is missing there. See inventory directive in /etc/ansible/ansible.cfg file.
Second warning is because you are using deprecated sudo directive in you playbook (I know it's in my example :)

My /etc/ansible/ansible.cfg:
[defaults]
inventory     = ~/ansible/hosts
roles_path    = ~/ansible/roles:/etc/ansible/roles

My hosts file:
[ubuntu-18]
host1 ansible_host=host1.domain.tld

[ubuntu-18:vars]
ansible_user=root
ansible_python_interpreter=/usr/bin/python3

My playbook:
- hosts: ubuntu-18
  remote_user: root # not needed when you have it in hosts file
  roles:
   - role: sunfoxcz.dkim
     dkim_selector: mail
     dkim_domains:
      - domain1.tld
      - domain2.tld

Let me know if it works.


Update: EuSoft.Eudic version <IP_ADDRESS> (13.6.3)

Created by 🥟 Dumplings in workflow run #5670.

Log
Updated: 13.6.2 → 13.6.3
Submitting WinGet manifests
Found existing pull requests:
Update: EuSoft.Eudic version <IP_ADDRESS> (13.6.2) - https://github.com/microsoft/winget-pkgs/pull/150095
This task is configured to ignore existing pull requests
Creating manifests
Uploading manifests and making commits
The manifests for the last version <IP_ADDRESS> will be overrided. Reason: No installer URL is changed compared with the last state while the version is updated
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installer Verification Analysis Context Information:
Specified hash doesn't match.
Actual hash:   5EC4B68699E104A806F0BFCC26FB639B1C9B3063083B9165397D76DAC29B8C94
Expected hash: 8405d41dc04698e1504a12161326d251c9fbe9313fab9b1b014d146779ec7538

6/6/2024 11:18:57 AM

Installer Validation

(Automated response - build 883.)

Automatic Validation ended with:

Installer Verification Analysis Context Information:
Specified hash doesn't match.
Actual hash:   8405D41DC04698E1504A12161326D251C9FBE9313FAB9B1B014D146779EC7538
Expected hash: 8a81456a55d8e258430f6d99f5f7f6b299ffc4c8d4a66b5fdd966d21dedeede4

6/7/2024 5:13:57 AM

Installer Validation

(Automated response - build 883.)


python310Packages.prance: update openapi-spec-validator

Description of changes
Pulls in https://github.com/RonnyPfannschmidt/prance/pull/132. I see that one of the commits changes the validator to use "auto-detection", and I don't know the implication of this, but the tests pass. Needed by https://github.com/NixOS/nixpkgs/pull/191339.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

We could do the proper release bump on master; If this is building, I think we should just take it now.


[CS2103T-W15-3] JJIMY

JJIMY is a restaurant management app for managing food orders, ingredient inventory, etc via Command Line Interface (CLI).

Codecov Report

Merging #24 (24b1461) into master (c36220c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36220c...24b1461. Read the comment docs.


Profiler indicates initialisation is slow

So according to Chrome the first call into anything scalatags results in a hefty penalty (and this is on a fast i7 laptop):

I love this library and don't want to try doing everything with the raw DOM API, but 320ms (probably less outside of the profiler, but still substantial) is a huge cost.  Any suggestions?  I'm thinking about forking the code and ripping out everything I'm not actually using.

320ms seems like a lot. do you know where all that time is going? I wonder if we can solve this by making all the vals into def or lazy val`s to avoid initializing them all at the same time. That may have some ongoing perf hit, but perhaps that matters less than this monster 320ms lag at the start

@grahampople could you try forking it, replacing all the vals with defs and lazy vals, and seeing if it makes the perf problem go away?

Well I probably only use 5-10% of all these tags, so I think lazy vals will sort it out nicely for me - good plan.  I'll try a fork tomorrow, and if that doesn't work I'll drill down in Chrome and try to find out where the performance is dragging.

  It's fine on my laptop, this is actually testing over chrome://inspect on my entry-level Android phone (an Asus Zenfone 5).

How did it go? These are my load times on my Macbook Pro:
JS Dom delta 12
JS Text delta 4
JVM delta 139

Just doing something like println(scalatags.Text.all.div.render). Not sure why it's so much slower on JVM, but I suspect on JVM someone (either scala-js or google-closure) is eliminating things. Here is my code:
package scalatags.text

/**
  * Created by haoyi on 1/17/16.
  */
object Main {
  def main(args: Array[String]): Unit = {
    val start = System.currentTimeMillis()
    scalatags.Text.all.div
    val end = System.currentTimeMillis()
    println("JVM delta " + (end - start))
  }
}

package scalatags.jsdom

/**
  * Created by haoyi on 1/17/16.
  */
object Main extends scala.scalajs.js.JSApp{
  def main(): Unit = {
    timeDom()
    timeText()
  }
  def timeText() = {
    val start = System.currentTimeMillis()
    println(scalatags.Text.all.div.render)
    val end = System.currentTimeMillis()
    println("JS Text delta " + (end - start))
  }
  def timeDom() = {
    val start = System.currentTimeMillis()
    println(scalatags.JsDom.all.div.render)
    val end = System.currentTimeMillis()
    println("JS Dom delta " + (end - start))
  }
}

When you try out the perf using lazy vals, can you also run the unit tests and post their perf numbers with and without lazy vals? There are benchmarks for both scala-js and scala-jvm and I'm curious to know how much lazy vals slow down steady-state performance

Here's something interesting: the startup time depends on whether you're using fullOpt or fastOpt or nothing at all:
scalaJSStage in Compile := FullOptStage,
[info] Running scalatags.Main
[object HTMLDivElement]
JS Dom delta 15

JS Text delta 5

scalaJSStage in Compile := FastOptStage
[info] Running scalatags.Main
[object HTMLDivElement]
JS Dom delta 85

JS Text delta 31

scalaJSStage in Compile := PreLinkStage
[info] Running scalatags.Main
[object HTMLDivElement]
JS Dom delta 1367

JS Text delta 823

With the status quo, here is the JVM startup times
53
176
177

And here are the startup times with everything made lazy val
JVM
38
133
161

scalaJSStage in Compile := FullOptStage,
[object HTMLDivElement]
JS Dom delta 6

JS Text delta 3

scalaJSStage in Compile := FastOptStage
JVM delta 192
[info] Running scalatags.Main
[object HTMLDivElement]
JS Dom delta 9

JS Text delta 2

scalaJSStage in Compile := PreLinkStage
JVM delta 192
[info] Running scalatags.Main

[object HTMLDivElement]
JS Dom delta 374

JS Text delta 216

And here is the steady-state performance benchmarks for
Status Quo
JVM
[info] scalatags.text.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       859857 in 10000
JS
[info] scalatags.jsdom.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       101095 in 10000
[info] scalatags.text.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       140901 in 10000

Lazy Vals
JVM
[info] scalatags.text.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       807387 in 10000
JS
[info] scalatags.text.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       143288 in 10000
[info] scalatags.jsdom.ScalatagsPerf		Success
[info]     correctness		Success
[info]         performance		Success
[info]                    ScalatagsPerf       106080 in 10000

As far as I can tell, there isn't any real difference in steady-state perf for using lazy vals. I'll just do this

@grahampople I published 0.5.4 with lazy-val-everything, can you try it out?

Hey, thanks for the indepth work on this.  I tried a fork but I confess I couldn't get it to build and gave up.  I don't completely understand all your profiling results above, but I'll give 0.5.4 a try and report back.  Thanks again!


Suggestion - drone polish

Since I have no idea how hard any of this is, feel free to do none, some, or all of these.
I really think the first 2 (if possible) would really polish it off and make it look like an official part of the game.

Have drones shoot sparks like the mecha does when harvesting
Have drones show harvesting progress like mecha
Add in-game options for drones (really just need ones you may want to change several times, like drone range)

That's all I can think of right now.  I can't even think of new features to suggest because that would take it out of the scope of the mod.   Side note, I've run into zero issues since the latest update.  Thanks again for all the hard work.
EDIT ---
Actually the last thing I can think of is to make the drone clearing have it's own research item.  Low level, maybe blue research.

@cdeath-zz Harvesting progress like Icarus has just been added in v1.2.9.

I won't be adding a research requirement because that would need to be added to the save file, and I don't want to do that.  The initial release of this mod saved the drone clearing state in the save file, and that became a problem if the mod was ever uninstalled.  It's not worth it.  Nice thought though.

That's cool you were able to do that, I understand the research thing, and yeah that makes sense.  Something I had not considered is now that the drones have a progress indicator, it makes them easy to spot while they are harvesting.  Maybe when official mod support is added things that modify the save can be revisited if it doesn't break the game by removing it.
Funny enough, this is the exact reason I picked the mods I'm running right now.  Most of them do not modify the game in a way that needs to be saved so if an update breaks the mods, I can keep playing without worry.

@cdeath-zz The Drone Clearing mod is compatible with BepInEx.ConfigurationManager.  So I don't consider it worthwhile to spend the time adding my own GUI.  I'll add a note about compatibility with BepInEx.ConfigurationManager to the README in the next release.

v1.2.14 improved this mod's compatible with BepInEx.ConfigurationManager.

Yeah that's cool, since I don't know how hard it is to do stuff like that I figure I just suggest a bunch of things and see what sticks =)  I've actually modified the configuration using the mod manager and it is easy enough to do, just takes a bit more time, but undoubtedly less time than writing code / testing for in-game options.  I had noticed another mod had them so thought I would suggest is all.

@cdeath-zz Drone torches and sparks have been released in v1.4.0.

That's so neat!  Sorry it took so long for you to do!  It really makes the drones look more like they are working.  Also I noticed one of the updates adds the circle when the drones are flying to the target, love it!


Add note about required file naming convention

I had some head-scratching before I realised that my file had to start with mock_

It doesn't specify that this is a required naming convention.
if it wasn't obvious to me then it might not be obvious to the next person

If you have a suggestion to improve this section, I will be happy if you create a PR on this.

Oh, the the file must be named mock_test.go and nothing else
ok, yea, I will create a PR


Setup UI and admin extension

Adds a setup UI/admin extension bool to .env, which if true transposes all .env variables into db and creates a UI experience for installing and managing the LNbits install

Added setup UI from https://github.com/lnbits/lnbits-legend/pull/94#issuecomment-693266418
Added admin extension from https://github.com/lnbits/lnbits-legend/pull/259
Both need refactoring and converting

Once we have this working, this would be great to add https://github.com/lnbits/lnbits-legend/pull/522

@motorina0 , i fixed some of the comments from your review, i set them as resolved! Not sure this is how it's done...

Bug:

go to Admin UI
add new admin user
expected result: user from text-input added
actual result: current user added

DB connection info should be hidden by default (password field), and only displayed in clear text if the admin user chooses to do so
it is easy for a eavesdropper to steal this info

class Settings in lnbits/settings.py and class UpdateSettings in lnbits/extensions/admin/models.py have most of fields in common.
can a common base (parent) class be extracted?

LFG!


Binary Tree Implementation and Display in Java

I'd like to add a Java program which constructs a binary tree in memory and displays it on the console.
I'm a GSSOC'21 participant. Please assign this issue to me. @anubhavitis

I would like to contribute on this issue . Please assign this issue to me.


Feature add indexed recursive inscriptions endpoint

Fixes #3923

[x] Added tests
[x] Lint

@casey @raphjaph can someone review it?

Upon further review I don't think there is any benefit of limiting ourself to using the Struct ChildInscriptionRecursive this is from the newer child endpoint which is a more optmized child endpoint that uses less onchain data. This struct was made for tons of pagination at the cost of data for speed. Considering we are only returning the info of a single inscription we can afford to return everything about that inscription and use the InscriptionRecursive struct from /r/inscription

Upon further review I don't think there is any benefit of limiting ourself to using the Struct ChildInscriptionRecursive

On second thought I think we should only return the ID.
@casey @raphjaph do you agree?
This is redundant data from /r/inscription.  Its useful on /r/children/:inscription_id/inscriptions because it returns 100 inscriptions with data. However this is only returning info about one inscription.

@raphjaph can you have a look once?

@casey @raphjaph: still waiting for the review.

Upon further review I don't think there is any benefit of limiting ourself to using the Struct ChildInscriptionRecursive

On second thought I think we should only return the ID. @casey @raphjaph do you agree? This is redundant data from /r/inscription. Its useful on /r/children/:inscription_id/inscriptions because it returns 100 inscriptions with data. However this is only returning info about one inscription.

I'm a bit confused with the lack of hype for address info in general. Considering it's the 1st thing listed right after the ID, on any inscription page...
I'd vote for the whole data in the 100 children.
My current case as example:  4 inscriptions with 100 children each. But instead of 4 queries, it necessitates 400 queries, to compare addresses.

@raphjaph @casey can you have a look once and also what do you think about comments by @elocremarc? would like your inputs too before going ahead make those changes, makes sense too me.
The PR has been open since more than a month, would appreicate your reviews.


Ignore certain members - how?

Hi,
I tried to find some way of comparing two data structures without certain specific members.
I thought maybe the .Config.MembersToIgnore could be used for that, but I cannot find any examples on how to use it for this purpose. Just adding a name of ignored property to that list doesn't seem to work (e.g. when I have a property called Span, then adding "Span" to MembersToIgnore doesn't seem to make it ignored).
Is there such functionality? If so, how to use it?

Please see the help file and all the unit tests.


Youtube nocookie domain not working

Expected behaviour
Use the YouTube iframe embed with youtube-nocookie.com domain. Expecting a styled Plyr player
Actual behaviour
The small non-responsive youtube video is displayed instead
Environment

Browser: Chrome
Version: 67
Operating System: OSX
Version: 10.13.5
Using fastly CDN Plyr 3.3.20 version

Steps to reproduce
https://jsfiddle.net/074q3k8c/1/

Ah ok, so it's not possible?
Maybe I'm not getting it right but isn't it possible to change the URL to youtube-nocookie.com based on either a Plyr setting (data-attribute for example) or simply the original url submitted by the developer in the player?
https://jsfiddle.net/074q3k8c/13/
Seems like the API is working just fine with the nocookie domain. Or is "the YouTube SDK" something other than this? https://developers.google.com/youtube/iframe_api_reference Did a Google search but the only thing popping up was the API.

Plyr needs it's methods (like play()), and the Plyr controls using them to be able to trigger the iframe's method. Otherwise we could just use the iframe embed url without any SDK.
You can't pass a url to new YT.Player(). new YT.Player() creates the URL, so unless there is some magic way it's just not possible.

Ok, too bad :)
I was checking because I'm located in the EU and with the new GDPR (and older cookie laws, but now everybody woke up) I'd like to only have functional cookies and anonymous analytics cookies on my sites so I won't have to display an annoying cookie consent banner type of thing. Unless the client wants marketing cookies ofcourse.
With this not being possible at the moment, shall we close this ticket?

@friday
I get it able to work with youtube-nocookie
can I make a PR ?


refactor: gcds-radio to gcds-radio-group

Summary | Résumé
Refactor gcds-radio into gcds-radio-group to allow native browser controls over radio buttons.
Changes
Removed a variety of properties and moved them into an object to pass to the new options attribute.
Example
<gcds-radio
  name=""
  options='[{
    "id": "",
    "label": "",
    "required": "",
    "disabled": "",
    "value": "",
    "checked": "",
    "hint": "",
  }]'
>
</gcds-radio>

Code looks good - 1 idea/question though: can we include the fieldset directly into this component to save the user from having to add it in?

I was thinking of do that but didn't end up doing it since I wanted the gcds-fieldset's use to be consistent with other form components. But with that being said I could bring this to dev/design sync and see what people think about this idea.

Code looks good - 1 idea/question though: can we include the fieldset directly into this component to save the user from having to add it in?

I was thinking of do that but didn't end up doing it since I wanted the gcds-fieldset's use to be consistent with other form components. But with that being said I could bring this to dev/design sync and see what people think about this idea.

That makes sense! Good idea to bring it to dev-design sync to see how the majority feels about it from a UX experience. :)


fix - small formatting issue on gateway install

Addressing a small formatting issue where the gateway install was not formatted.

merging this bc it is just formatting


Add space below each expanded transcript feature in genoverse - V2

A simple solution to add spacing between the transcript features.
Only problem is that it adds some spacing above first line of feature like shown in the image below.

Related PR:
https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-6334
Sandbox URL:
http://wp-np2-1d.ebi.ac.uk:42229/Homo_sapiens/Location/View?db=core;g=ENSG00000139618;r=13:52315086-52400268;t=ENST00000544455

Can you update your sandbox to use this and we'll see how it looks ?
BTW the PR should be against master

Can you update your sandbox to use this and we'll see how it looks ? BTW the PR should be against master

@ens-st3  - Thanks for spotting that.
I've updated my sandbox here:
http://wp-np2-1d.ebi.ac.uk:42229/Homo_sapiens/Location/View?db=core;g=ENSG00000139618;r=13:52315086-52400268;t=ENST00000544455

Sorry, still can't see it.
Can you also add the transcript stable ID code ?

@ens-st3  - I've added the transcript stable ID code.
Can you clear the cache and try again? The JS files might be cached.
Also, are you looking at the dynamic image?

This looks fine to me, and given that it's a much simpler solution than #504 I'd suggest going with this


[FEATURE]: Expand DLP to Support Additional Default Datasets for Enhanced Testing and Training

Feature Name
Support Additional Default Datasets for Enhanced Testing and Training
Your Name
Surya Subramanian
Description
To enhance the versatility and applicability of the Deep Learning Playground (DLP), we propose to add support for more default datasets. These datasets will provide users with a wider range of options for testing and training their machine learning models. Each dataset comes with unique characteristics and challenges, making them ideal for various research and application purposes.
Here are some proposed datasets you can try to integrate:
CIFAR100: Offers 100 classes, each with 600 images (500 for training and 100 for testing). A more complex version of CIFAR10.
SVHN (Street View House Numbers): A real-world image dataset for developing machine learning and object recognition algorithms, requiring minimal data preprocessing.
ImageNet: A large and complex visual database designed for visual object recognition software research.
CelebA (Celebrity Faces Attributes): A large-scale face attributes dataset with over 200,000 celebrity images, each with 40 attribute annotations.
COIL100 (Columbia Object Image Library 100): Consists of 7200 images of 100 objects, each photographed from various angles.
Omniglot: A dataset designed for one-shot learning, containing 1623 different handwritten characters from 50 different alphabets.
STL10: Inspired by CIFAR-10, this dataset is meant for developing unsupervised feature learning, deep learning, and self-taught learning algorithms.
EMNIST (Extended MNIST): Expands the original MNIST dataset to include handwritten letters.
Task Breakdown
Integration of Datasets: Implement the integration of these datasets into the DLP system, ensuring they are easily accessible and usable for users.
Architecture Optimization: For each dataset, research and determine the most effective neural network architectures that are suitable for testing. This involves understanding the specific characteristics and challenges posed by each dataset.
Documentation and Examples: Provide detailed documentation and example use cases for each dataset, guiding users on how to leverage these datasets effectively.
Testing and Validation: Conduct thorough testing (through POSTMAN + default dataset) to ensure the seamless integration of these datasets into the DLP. Validate the performance of suggested architectures for each dataset. More info on how to do this is in Notion.

Found a small bug in tabularConstants.ts where there was a typographical error for the california housing data set leading to incorrect referencing. Just adding an underscore between "california" and "housing" fixed the problem.

Another small bug. The DIGITS data set was not working when selected. This data set had just not been loaded in from sci-kit learn. I loaded it in and added it in dataset.py and that seems to have fixed the problem.

Hey @LuHG18 ETA on the PR?


Update defs enzyme_v2.3.x for flow 0.53.x

I'm not sure what's up with the tests.
It works with flow.org/try

Now build is failing unrelated to this PR.


[TW#28507] UDP Broadcast Performance is Worse in AP mode than STA Mode

Environment

Module or chip used:  ESP32-WROVER and ESP32-WROVER-I

IDF version V3.1.2

Build System:         Make

Compiler version V5.2.0

Operating System:     Linux

Power Supply:         external 3.3V

Problem Description
We have a relatively simple ESP32 application ESP-IDF (FreeRTOS) that converts Serial Data in to TCP or UDP Packets. By default we are using the ESP32 in AP mode but also allow the user to select STA mode.
A TCP connection works perfectly in AP and STA mode but we have found that there are a large number of UDP packets that are not transmitted in AP mode (25%) and a limited number perhaps 1-2% not transmitted in STA mode.
We have just one Mac connected to the ESP32 in AP Mode, we are using a Baud rate of 38400 and we are sending a burst of messages each with a counter and then a UDP client program, running on the Mac, uses the counter number to record which packets are not transmitted. We have also confirmed that the packets are not getting out by running Wireshark on the Mac.
We are using the SDK configuration settings that you used for the IPerf Example in which you recorded 30Mbit UDP throughput, which would be great if we can ensure all packets are transmitted.
We are using a UDP broadcast address of <IP_ADDRESS>
This might be related to issue #1865 which was never resolved

@sumps It has nothing to do with SSID transmission, Beacon, Mesh, etc. Could you please provide a demo code to us to reproduce the issue? Thus we can find the root cause soon.

@sumps Thanks. If you could provide a demo code, we can investigate it these two days before holiday.

@TimXia do you need the sources or will a binary file be enough? How can I get this to you privately?

@sumps Please provide the source code and attach it here.

@TimXia I have emailed you directly

Same issue

@akshar001 IDF V3.3 has solved this issue, you can update IDF version to V3.3 and do the test again, thanks.

@sumps Thanks for reporting. @akshar001 Thanks for the updates. Did you have any chance to try IDF v3.3 and help share updates? Thanks.