Creating a new user

Dear sir,
Thankyou for your Authentication software CI4-Auth I have started to use it and it is very helpful.
It would be great if when I create a new user through the website itself as an administrator could force a reset password when the new user logs in the first time.

Hi @stezam ,
thanks for the flowers.
A good idea to send a password reset mail to a freshly created user. I added a config option "sendPasswordResetUponCreate". If set to true such a mail is sent when a new user is created.
Thanks for the idea. Best regards,
George

Thank you
much appreciated

Tried but not working I am afraid. Sorry ):

Did you update all files? Especially the Auth.php config file and the UserController. I tested locally and the mail send is triggered.

Dear Sir
I am sorry for the inconvenience but it was my fault.  Fixed the issue and it works perfect.  Well Done. Thank you once again.

Hi @stezam ,
I have slightly changed the implementation of this feature. I found that it might not be covering individual uses cases when the setting is global and cannot be chosen per user creation.
I now added a checkbox to the user creation form. When checked, the mail is sent. Otherwise it is not.
Best regards,
George

Thank you Sir will try later on and give you my feed back if I may.
Is it ok if in the future I can suggest more in my opinion improvements please as I do not want to sound demandig.
Thank you

Sure. Go ahead if you have ideas. Open a new issue though then.


Feature/bdi co  pgt field mapping object hierarchy

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

**lurch: attach W-032261

Tracking W-032261


dex pkg upgrade

:nut_and_bolt: Description: What code changed, and why?
https://chefio.atlassian.net/browse/CHEF-6950

:chains: Related Resources
:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

@iamazzeez Please check the pipelines


Add line break on character limit for Title column on table

When the terminal window is of minimal length, the table gets jumbled up.  Sometimes it's due to the long length of title on GitHub issues. Can it be solved by adding a check for character limit on issue title column and adding a line break?
If you have been using this tool, let's discuss if you have faced this issue or have any solutions in your mind including the one mentioned above.
Image for reference:

@yankeexe I would like to work on this , could you assign this to me ?

Hey @kra-tosss sure. Do you have any suggestions on how much should we set the character limit?

hey @yankeexe about this issue, I think the character limit can be 50 characters then we can add a line break then again the character limit for the second line and at last a line break.
what do you think?

hey @yankeexe about this issue, I think the character limit can be 50 characters then we can add a line break then again the character limit for the second line and at last a line break.
what do you think?

yeah that sounds great. Do you want to work on it? @akshitagupta20

Just one doubt, what if a 50 character limit is reached when we are in the middle of a string? What I was thinking is that we can add the line break there with a hyphen showing that the word is continued in the next line. Can I work on this?

Just one doubt, what if a 50 character limit is reached when we are in the middle of a string? What I was thinking is that we can add the line break there with a hyphen showing that the word is continued in the next line. Can I work on this? @yankeexe

Yeah that works, but I think you can add a line break before the word if a word crosses the limit on the middle.
You can work on this @bhatt01tapasvi  👌

Sure. Thanks.

I am done with the code. I am confused with which file to make changes to. Can you please tell me which file is it? @yankeexe

Hey @bhatt01tapasvi  you can look into these lines
https://github.com/yankeexe/good-first-issues/blob/dab3c3adbc3a4170af17eaa36fa788bf02fe9bdf/good_first_issues/graphql/commands.py#L92-L99
Issues contains the List of issues with their URL as a tuple:
issues = [(issue title, url), (issue title, url)]
You can extract the Issue title and work on them.

hey, I have just started coding and would love to contribute here. But I am a bit confused about how to and where to start. Can someone brief me, pls

Hi , I see it's still in open state, can I work on this if it is not resolved yet?

Can i work on this issue?

@anubhav1206 sure! Go for it ⚡

You can Set a Character Limit and Add Line Breaks to solve this issue .
you can use function when working on CLI Application
like ,
SELECT
CASE
WHEN LENGTH(title) > 50 THEN
CONCAT(SUBSTRING(title, 1, 50), '\n', SUBSTRING(title, 51))
ELSE title
END AS formatted_title
FROM issues_table;


Fix logic to use ${BUILD_TYPE}_FLAGS

Fix logic where else should be used.  Allows -DRELEASE_FLAGS to be used on command line.

Thanks! I forgot about this bug when importing the build system from BabelStream!


Hashing Functions - Misleading Explanation

In the hashing functions introduction, it is stated

Hashing functions are one way functions which theoretically provide a unique output for every input. MD5, SHA-1, and other hashes which were considered secure are now found to have collisions or two different pieces of data which produce the same supposed unique output.

This statement is not true. They don't theoretically provide a unique output for every input. Simple proof of this is that the space it maps the input to - the output space - is smaller than the input space itself (the hashed output is almost always shorter/smaller in size than the input), so there cannot be a mapping without collisions. This is however not a problem, as long as it is not computationally feasible to find those collisions (one of the desired properties of a good hashing algorithm).
Hashing algorithms that were "broken due to collisions", were just algorithms where someone figured out how to reliably find collisions, enabling certain attacks.
The first paragraph on wikipedia explains this in other words: https://en.wikipedia.org/wiki/Collision_resistance

Link to the specific page: https://ctf101.org/cryptography/what-are-hashing-functions/

I got an email for this so I looked into it for a few minutes. I think the sentence suffices for it's intended purpose but you can PR better language.
https://en.wikipedia.org/wiki/Perfect_hash_function


JSX parsing bugs

children props are overridden
<Foo children='bar' />

Children prop is empty because the ast children attribute is used.
unnecessary p tags
<Foo>
  Bar
</Foo>

Results in

Bar

complex jsx is borked
<Foo>
  <Bar
    children={props.bar.map(b =>
      <Baz key={b}>{b}</Baz>
    )}
  />
</Foo>

Perhaps stuff like this is where we introduce the .jsx code block back?
Expression based props error
<Foo color={'pink'} />

Errors with (in next example):
Error
Error
    at tokens.reduce.type (http://localhost:3000/_next/-/page/index.js:2090:19)
    at Array.reduce (<anonymous>)
    at parse (http://localhost:3000/_next/-/page/index.js:2084:23)
    at Of.parser (http://localhost:3000/_next/-/page/index.js:823:18)
    at Of.tokenize [as tokenizeBlock] (http://localhost:3000/_next/-/page/index.js:72636:18)
    at Of.parse (http://localhost:3000/_next/-/page/index.js:68441:20)
    at Function.parse (http://localhost:3000/_next/-/page/index.js:80537:45)
    at pipelineParse (http://localhost:3000/_next/-/page/index.js:80284:16)
    at wrapped (http://localhost:3000/_next/-/page/index.js:80139:19)
    at next (http://localhost:3000/_next/-/page/index.js:80102:24)

Related, but seems like expression values in props aren't working for me – e.g. <Box width={0.5} />

Confirmed and added to list.

This list of bugs can be tracked by these new issues:

fazouane-marouane/remark-jsx#16
fazouane-marouane/remark-jsx#20
fazouane-marouane/remark-jsx#19


After zlib 1.2.12 upgrade, rustc spams '-zlib-1.2.12/lib/libz.so.1: no version information available'

Describe the bug
The zlib upgrade to 1.2.12 seems to cause some sort of issue that causes rustup-downloaded rustc to output "libz.so.1: no version information available" messages when compiling.
Steps To Reproduce
# rm -rf ~/.rustup
# rustup install nightly-2022-03-22 --force
# rustup default nightly-2022-03-22
# cargo new --bin delete
     Created binary (application) `delete` package
# cd delete
# cargo build
   Compiling delete v0.1.0 (/home/at/trash/delete)
/home/at/.rustup/toolchains/nightly-2022-03-22-x86_64-unknown-linux-gnu/bin/rustc: /nix/store/9vdc8d0gfmjzb0bqp7xyzjba69azqs9b-zlib-1.2.12/lib/libz.so.1: no version information available (required by /home/at/.rustup/toolchains/nightly-2022-03-22-x86_64-unknown-linux-gnu/lib/libLLVM-14-rust-1.61.0-nightly.so)
    Finished dev [unoptimized + debuginfo] target(s) in 0.57s

(nightly-2022-04-02 does this too.)
Expected behavior
lack of "no version information available" messages as before
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.109, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5.0pre20211206_d1aaa7e`

The warning come from here,
The warning come from here,

$ ldd /home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/libLLVM-13-rust-1.59.0-stable.so                                                                                Sun 10:35
ldd: warning: you do not have execution permission for `/home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/libLLVM-13-rust-1.59.0-stable.so'
/home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/libLLVM-13-rust-1.59.0-stable.so: /nix/store/9vdc8d0gfmjzb0bqp7xyzjba69azqs9b-zlib-1.2.12/lib/libz.so.1: no version information available (required by /home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/libLLVM-13-rust-1.59.0-stable.so)
linux-vdso.so.1 (0x00007ffcce9e6000)
librt.so.1 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/librt.so.1 (0x00007f62deac4000)
libdl.so.2 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/libdl.so.2 (0x00007f62deabf000)
libpthread.so.0 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/libpthread.so.0 (0x00007f62dea9f000)
libm.so.6 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/libm.so.6 (0x00007f62de95e000)
libz.so.1 => /nix/store/9vdc8d0gfmjzb0bqp7xyzjba69azqs9b-zlib-1.2.12/lib/libz.so.1 (0x00007f62de945000)
libgcc_s.so.1 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/libgcc_s.so.1 (0x00007f62de929000)
libc.so.6 => /nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib/libc.so.6 (0x00007f62de754000)
/nix/store/rxjh6jxg7ksisbcxl0cjwcff5iprpdfz-glibc-2.33-123/lib64/ld-linux-x86-64.so.2 (0x00007f62e3b23000)

It looks like the underlying issue is https://github.com/madler/zlib/issues/617
Applying https://github.com/madler/zlib/commit/05796d3d8d5546cf1b4dfe2cd72ab746afae505d as a patch to zlib seems to resolve the problem.

It appears that https://github.com/NixOS/nixpkgs/pull/167395 should fix this once it's merged in.

This issue went away for me, but only for x86_64-unknown-linux-gnu targets, for embedded targets (thumbv7em-none-eabi) rustc still has this message.
/home/alex/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/rustc: /nix/store/ilfqlmd6npxh3zaszdj7dj7zy6w96gmi-zlib-1.2.12/lib/libz.so.1: no version information available (required by /home/alex/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/libLLVM-14-rust-1.60.0-stable.so)

$ readelf -d /nix/store/ilfqlmd6npxh3zaszdj7dj7zy6w96gmi-zlib-1.2.12/lib/libz.so.1

Dynamic section at offset 0x16bd0 contains 28 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/hbvq1160w7k0k0cfpmpd1hn3gf6apika-glibc-2.34-115/lib]
 0x000000000000000c (INIT)               0x3000
 0x000000000000000d (FINI)               0xfd00
 0x0000000000000019 (INIT_ARRAY)         0x17a70
 0x000000000000001b (INIT_ARRAYSZ)       8 (bytes)
 0x000000000000001a (FINI_ARRAY)         0x17a78
 0x000000000000001c (FINI_ARRAYSZ)       8 (bytes)
 0x0000000000000004 (HASH)               0x200
 0x000000006ffffef5 (GNU_HASH)           0x588
 0x0000000000000005 (STRTAB)             0x1510
 0x0000000000000006 (SYMTAB)             0x940
 0x000000000000000a (STRSZ)              1746 (bytes)
 0x000000000000000b (SYMENT)             24 (bytes)
 0x0000000000000003 (PLTGOT)             0x17dd0
 0x0000000000000002 (PLTRELSZ)           1320 (bytes)
 0x0000000000000014 (PLTREL)             RELA
 0x0000000000000017 (JMPREL)             0x20a8
 0x0000000000000007 (RELA)               0x1d30
 0x0000000000000008 (RELASZ)             888 (bytes)
 0x0000000000000009 (RELAENT)            24 (bytes)
 0x000000000000001e (FLAGS)              BIND_NOW
 0x000000006ffffffb (FLAGS_1)            Flags: NOW
 0x000000006ffffffe (VERNEED)            0x1ce0
 0x000000006fffffff (VERNEEDNUM)         1
 0x000000006ffffff0 (VERSYM)             0x1be2
 0x000000006ffffff9 (RELACOUNT)          28
 0x0000000000000000 (NULL)               0x0

Missing SONAME.
Any got ideas?

Ack, never-mind, I found a straggler in ~/.rustup that I didn't delete, it went away after cleaning that up.


Make Windy Modular

It would be really cool if Windy was modular so you only imported the things you really use.
import windy/clipboard

It would also help to make the documentation shorter and easier to read.

I have made a couple of attempts at this and concluded it is actually a deceivingly complex request and not something I'm going to do in in the near future.
For context, the current Windy is not done. I've only done Win32 and macOS first-pass so far, planning to look at Linux next (current Linux was contributed which is great but has shortcomings I need to address). Given I haven't even done all 3 platforms, taking on something that adds a lot of complication is sadly not a good idea at this point.
Some reasoning in addition to that:

import windy/clipboard should work regardless of platform I assume? And it would give you maybe a setClipboard and getClipboard for example.

Well, on Windows, setClipboard requires an HWND (window handle). So either the proc signature cannot match across platforms (needs that HWND paramter on Windows), or windy/clipboard needs to know about eg windy/windows in order to have a little helper internal HWND.  And that internal helper HWND brings further concerns. It cannot be created at global scope due to potentially using windy in a DLL (DLLs must not call out to other DLLs in DllMain which is when the global scope code is run, so calling out to the Windows DLLs to create a window is a no-go). So, either windy needs a global init proc that must be called first, or windy can do a if not initialized: init() internally like it does now,. Then either the explicit init call or the call that triggers the check + initialization (like setClipboard) must be called on the main thread. This is because windows event loops are tied to the thread that created it on Windows. There is even more to this but that's enough for now.
So this big long blob above that probably didn't make sense is just the tip of the iceberg, literally just for setClipboard. When you start adding in notifications, windowing, platform http, tray icon, it gets really really tricky. The platforms themselves are made as a monolithic API all focused around a single event loop, so breaking bits of it off just ends up falling apart when at the bottom of it all, only one bit of code can be in control of the platform event loop.
I could maybe create the needed little helper window just for clipboard and have other ones for each other module, but it does not seem great to have like 5 hidden windows just to enable the use of import windy/clipboard instead of import windy. And I am very sure there are further painful realizations that would stop this approach too.
In the end, Windy isn't mature yet so while the suggestion of refactoring it into modules is reasonable, in reality it is complicated and quite for ahead of where the library is today. Perhaps someday, because the idea itself is good, but for now I am going to close this.

Thanks for the answer.
I agree and hope Windy matures quickly, it is such a useful library :heart:.


Question: Is there any DirectX surface ?

I would like to use DirectX, or any other solution to draw custom video renderer. Is there any solution for that on WinUI ?

@Austin-Lamb can you help?

Hi @ZeBobo5 are you asking about WinUI 2 or the WinUI 3 Alpha?

For the WinUI 3 Alpha, unfortunately DirectX swap chain interop isn't available yet: you can find the list of missing features we're still working on for WinUI 3 here (including SwapChainPanel):
https://docs.microsoft.com/uwp/toolkits/winui3/#controls-and-features

If you need to ship an app before WinUI 3 is ready then we recommend continuing to use system Xaml + WinUI 2, which should be easy to update to WinUI 3 in the future.
With system Xaml you can use any of the DirectX interop types documented here to render DirectX surfaces:
https://docs.microsoft.com/windows/uwp/gaming/directx-and-xaml-interop
For custom media, the best options are usually to either:

Use a MediaPlayer rendered in a Xaml MediaPlayerElement. MediaPlayer supports custom streams and video effects

Render a fully custom DirectX swap chain using SwapChainPanel


WIP: Implement Running Wasp-Companion in the background

To run parts of Wasp-Companion in the background (for example: playback controls through wasp-os' music app), I have switched it to use GtkApplication. This allows hold()ing and release()ing the app. Now, when the "x" button is clicked, the app merely destroys the window while other threads continue running. When the app is then started again, the window is simply created again instead of creating a new instance of the app.
I marked the pull request as WIP though, because I still have to find a way to keep the window state (e.g. if the time is synced) when the window is created again. Simply hiding the window won't work, as the app will just crash for some reason.

Hi, I'm glad you're picking up this code and running with it. I only got to 80 lines before getting distracted =)
If you wanna make this a real functional app feel free to rename the app id (com.arteeh.Companion) and just work in your own repo. I'm not working on this code so PR's would be a waste of your time.

Alright, I'll close this then. Thank you!


Prepare rust-webpack example

Another one :)
This time based on https://github.com/rustwasm/rust-webpack-template.
This one should actually be more useful than wasm-app in the short term, since we want to focus on pure Rust applications first (wasm-app includes yage as a single .wasm file and would require a proper Javascript interface).

... like wasm-app this also depends on https://github.com/rustwasm/wasm-bindgen/issues/1267 to work at all.


Xaml game object

Adjusting Post-build command to account for folders with spaces in them.

Egads.  Merged into the wrong repo.  Sorry!


Latents not exist error

Hi, I have updated my nerfstudio version based on this PR:
https://github.com/OPEN-AIR-SUN/mars/commit/4139c60a52ab554d7a75c73a44cce2978d9a886e
and I now see:
camera_utils.py:462: UserWarning: Using torch.cross without specifying the dim arg is deprecated.
Please either pass the dim explicitly or simply use torch.linalg.cross.
The default value of dim will change to agree with that of linalg.cross in a future release. (Triggered internally at C:\actions-runner_work\pytorch\pytorch\builder\windows\pytorch\aten\src\ATen\native\Cross.cpp:67.)
v = torch.cross(a, b)
[09:14:56] [array([2.]), array([3.]), array([7.]), array([8.]), array([4.]), array([9.]),   mars_kitti_dataparser.py:843
array([5.]), array([12.]), array([6.]), array([10.])] in this scene.
Error: latents not exist
Why might this be happening?

Have you downloaded the latents and changed the path in the configs and set it to True ?

Ah, that sounds like the issue! I can't see this in the readme, can you please point me to the instructions for this?

Found the download link, but it is not obvious where to set the path.  Where is the config file? Thanks!

Check the cicai_configs.py file and change the paths for the respective parser(KITTI or VKITTI). I changed the .vscode/launch.json file as well, not sure if it's necessary. You can keep your latents in any directory, don't have to follow their path, just make sure you pass the right path.

Hi! @antithing
You can specify the latent path in mars\cicai_config.py. You need to install our repo locally using pip install -e . instead of pip install mars-nerfstudio to ensure the local modification take effects.

could we make this a config entry?

Hi! @antithing
You can specify the latent path in mars\cicai_config.py. You need to install our repo locally using pip install -e . instead of pip install mars-nerfstudio to ensure the local modification take effects.

could we make this a config entry

Hi! @antithing, am closing this issue for inactivity, but feel free to reopen :)


spell checker checks spelling on git version of files

Hi,
I'm not sure what exactly happens but it seems that every file I work on (which has spell errors that are locally ignored by workspace dictionary) also displays spell errors in some form of git version. Best thing I can do is attach a screenshot, please check the name of the file where errors are indicated (ends with go.git) and path of file (starts with git:/Users/...
Not even sure what info to provide in order to help debug this error. Please let me know what info you need and I'll gladly provide it.

Thank you. I'll take a look.
Which git extensions do you use?
Whenever an extension opens a file (even in the background) the spell checker gets notified and will check the spelling. The spell checker should ignore files of the wrong type.

Wow, that was fast 😃, The git related extensions I have are:

Git History (0.4.0)
Git History Diff (1.1.3)
GitLens (8.2.3)
Run git difftool (0.0.5)

Thank you very much. Please let me know if you need anything else.

I found this issue. If you update the extension to version 1.6.9. the issue should be fixed.

Wow that was fast 😃 , Thanks.

It was a regression introduced in the last update.


Firing while crawling using gsit

Description
Dont know if this would be more appropriate as a bug report or feature request but I noticed that I am unable to fire a gun while crawling using gsit. Would be nice if this can somehow be fixed since it would allow my playerbase more positioning options in combat.
Configuration
N/A
Payment (optional)

[ ] I'm willing to pay for this feature

Can you try changing your trigger conditions? It is possible that a trigger condition is blocking you from firing.

little update on this, apparently its related to setting swimming to deny. Removing this will allow you to fire when crawling via gsit. Dunno if this will be a separate check in the future but currently this is the fix.


Add string formatting to binaries during export

There is a "String" format option available for binary columns while viewing in the editor.
When choosing to export a result set "String" is not available in the binary encoding options list.

In results viewer "String" means to show raw binary data in character representation.
What do you expect to get in case of data export? Isn't it the same as "Binary" encoding?

Sorry. Got some things mixed around.


Allow TextureAnimation's FrameTime to be changed at runtime

I stumbled upon a roadblock while developing a PR for osu!lazer, the current code doesn't allow the frames to change their delays (without creating a new TextureAnimation). I would appreciate it, if the current design could be changed and merged by someone.

Would you mind providing context as to what the usage is so that we can either begin to fix it or provide alternatives? A pushed branch would be enough.

I'm trying to re-implement the taiko don from stable, got pretty far but trying to add back that the don animates corresponding to the BPM (therefore also changes while playing a beatmap) can't be done at the moment.
Here's my branch:
https://github.com/Craftplacer/osu/tree/taiko-don
Notable files are:

osu.Game.Rulesets.Taiko\UI\DefaultTaikoDonTextureAnimation.cs
osu.Game.Rulesets.Taiko\UI\DrawableTaikoCharacter.cs
osu.Game.Rulesets.Taiko\UI\TaikoPlayfield.cs

Have you tried changing the clock rate of the animation, I believe that's what you're looking for.

Have you tried changing the clock rate of the animation, I believe that's what you're looking for.

No, I haven't.

I'll close this issue as the Clock property seems the solution to this.

Not so sure using a clock is correct here. It's the kind of case where it may be lower overhead to be able to adjust the time per frame.


Create basic board functionality

Create basic board functionality:

Create empty board
Getter/setter functions
Display the board

Resolved with dec3d1bd594e412afcc5068afb378d3f65671aee.


Remove 'and' semantic.

Hi there, I'm fully expecting this PR to be closed, but it's more of a question.
I've recently brought in Masonry into a project that needs to support iOS7 (thus couldn't use SnapKit, which I have used extensively over the last year and love to bits) and after I brought it into the project, the 'and' semantic was causing a build failure.
I know a lot of people who have used Masonry have likely relied on this API, so I'm not suggesting it's complete removal. It's more of a question of why do you think it's causing my build to fail?
I get a very helpful build error along the lines of:
"*/Pods/Headers/Public/Masonry/MASConstraint.h:113:20: Expected selector for Objective-C method"
Any help would be greatly appreciated.

@jameshartt I've not heard anyone else bring this issue up yet, I'll wait a little longer and see if anyone else does.
Does it happen to you on a brand new fresh project?

@jameshartt I believe this was in relation to another issue. Are you using Objective-C++? I'm hesitant to merge this because I know first hand a lot of projects using the and semantic.

As soon as you said that I face palmed. Of course it's Obj-C++. That'll be enough for me to fix it :-)

Thank you very much for your help :-)

Hi @jameshartt , can you explain how did you correct that error ? :)


Exceptions when writing the result stream are swallowed on asynchronous requests

Actual behavior (the bug)
If an exception is triggered in JavalinResponseWrapper.write on an asynchronous request, that exception is swallowed. That causes the request to hang until the timeout (if there's no timeout configured, it hangs indefinitely).
Expected behavior
The exception should trigger a 500 error.
To Reproduce
Reproduce #1170 on an asynchronous request (Javalin release 3.13.4)
Additional context
The issue happens due to the snippet below, from JavalinServlet:
val asyncContext = wrappedReq.startAsync().apply { timeout = config.asyncRequestTimeout }
ctx.resultFuture()!!.exceptionally { throwable ->
  // ...
}.thenAccept {
  // ...
    JavalinResponseWrapper(asyncRes, rwc).write(ctx.resultStream()) // #1170 throws an IOException here
  // ...
}

The thenAccept block runs asynchronously and returns a CompletableFuture, so exceptions thrown inside of that block are not thrown - a new exceptionally block should probably be added.

I could create a PR with an exceptionally block to cover this, but I'm not sure how to test this case after #1170 is backported. @tipsy  any ideas?

@wilerson make a subclass of InputStream that throws when you read from it?

@tipsy I'm not sure I should have created 2 PRs for the two release branches, sorry if that was not the proper way to do it.

That's completely fine, thank you :)


Fixes ticket #2251. Implemented is_multipart on EditHandler

A form's enctype attribute was not set to "multipart/form-data" when an InlinePanel contained a FileInput field. This fix solves the issue.

It seems that this was reported independently as #3435, and fixed in the django-modelcluster library in https://github.com/wagtail/django-modelcluster/pull/73 ... Probably no harm in having the fix on the Wagtail side too, though.

Merged in a6bb67f75d588416f34d2884b9cb0ecb0f96e36d - thanks @helmantel!

@gasman Attempting to make use of the new is_multipart() method in contrib.modeladmin too, for consistency. But the test_create() test on line 159 of /wagtail/contrib/modeladmin/tests/test_simple_modeladmin.py is now erroring with:
AttributeError: 'PublisherModelAdminForm' object has no attribute 'formsets'
Any ideas?

@ababic Is PublishedModelAdminForm a subclass of modelcluster.forms.ClusterForm?

@gasman It's not no, it's just a straight subclass of forms.ModelForm. Is that a requirement for edit_handler.is_multipart()? I thought it would've been nice to use that method consistently throughout, no matter the base form class.

@ababic Hmm, that's a fair point - edit_handler shouldn't be making the assumption that it's working with a ClusterForm. In fact, I'm now questioning whether edit handlers should really be involved in form logic to the point of knowing whether it's multipart or not. Given that we're only doing so here to work around a modelcluster bug (one that will become moot when Wagtail 1.10 is released, since we'll be releasing a new version of modelcluster at the same time) I think it's sensible to sidestep that decision, and roll this change back.
(Incidentally, is it a routine thing for modeladmin to use non-ClusterForm model forms, or does that only happen if you specifically pass a custom form in? If it's the former, we should look into that - as far as I'm aware, InlinePanels rely on ClusterForm to work correctly.)

Hi @gasman. In answer to your question, modeladmin relies on the edit_handler to find the right form to use for the model - which I think is the behaviour used elsewhere?
It's currently not documented anywhere, but at the moment, if a developer wants to use InlinePanel for non-page models, they have to subclass ClusterableModel in order for it to work. I've always wondered whether it would be possible to make InlinePanel work whether being used in a ClusterForm or not?

FYI The above is also true of wagtailsnippets

@ababic If you leave it to the edit_handler to provide the form, it will build it from WagtailAdminModelForm, which subclasses ClusterForm.
To make InlinePanel work without ClusterForm, we'd need some other mechanism to ensure that the associated formsets are also saved when we call form.save(). That's not so hard in itself, but in the case of the page editor, we also need it to happen on form.save(commit=False) in order for preview to work - and that definitely does require modelcluster trickery. So, any non-modelcluster handling of formsets would still have to live alongside the modelcluster logic.

@gasman Oh, I didn't realise that was the case regarding WagtailAdminModelForm. I'm pretty sure you still get an error on the create/edit views if you register a non-ClusterableModel  model with InlinePanel instances in the panel definitions (in  wagtailsnippets or modeladmin).


[WIP] Add support for non-blocking visualization of streaming data in Jupyter and Colab

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Still WIP.


Remove package-collection and package-registry from top-level command help

This help should include top-level commands–these should be treated as sub-commands of swift package.
rdar://104603198

@swift-ci Please test


Revert "test: bsim: bt: fix test scripts"

This reverts commit 18119e8f6e3d735f5fbe09f443b02ef8fdb285f5.
Audio tests are enabled back, but change to random number seed is retained for the multiple identity test.

FYI new AC tests commented out in #82217 with this commit

@cvinayak this PR is doing a lot more than reverting a specific commit now. Can you update the PR title and description?

LGTM assuming that it uses the newest version of the commit from #80840 :)

Did a local fetch, rebase and diff of the commit -> appears same. #80840 can be rebase after this PR gets merged so that #80840 will appear as "merged" in github.


WrongDefaultValue message

Hello,
since your last update I have the message:
WrongDefaultValue
Class Name: GameStatusEffect
Property: duration
Value: 1
;)
   Robert

Thanks for reporting. This has been fixed in v0.08a_r3.


UnitInput: Fix unit change for zero values

It looks like UnitInput is unable to handle unit changes for values like 0px -> 0vh

Why should it handle them? Changing units when the value is 0 doesn't really change anything... 0px is the same as 0% and 0em :thinking:

Great question! The rendered value doesn't change (CSS wise). However, I think the UI feels broken if I (the user) manually typed a change from 0px or 0vh. Or worse... used the unit selector to change from 0px to 0vh.
Neither methods work at the moment 🙈
https://g2-components.xyz/iframe.html?id=components-unitinput--default&viewMode=story


Marked sub-workflows by a prefix

to distinguish them from main workflows.
Using local action defintions (as discussed offline) is not possible due to the extensive use of matrix strategies which makes most of the sub-workflow code, logic and reason for existence...
What do you think is better as prefix "subworkflow" or just and one or two underlines "__"?

Sorry! I wanted to give this a try:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-an-action-in-the-same-repository-as-the-workflow
I don't like this:

You must check out your repository before using the action.

I didn't change to a branch, however, damaged master, and had to fix it there:
I'm using the prefix "actions-" to resemble the actions/ directory.

No problem.
What do you think? Should we go with your "actions-" prefix or with mine "-subworkflow" prefix?
I guess, in fact it is a subworkflow, not an action, what we have.
But would not insist. Not so important at the end...

What do you think? Should we go with your "actions-" prefix or with mine "subworkflow-" prefix? I guess, in fact it is a sub-workflow, not an action, what we have.

Hm: "subworkflow" is quite long. And even GitHub describes "uses" as:

Selects an action to run as part of a step in your job. An action is a reusable unit of code.

(It's confusing, however, that GitHiub Actions runs workflows.)

Let's stay with your "actions-" prefix. It is not that important at the end.
And your changes are already incorporated and working.
So, I'm going to close this PR.


UserScenario: Transaction sent to FullNode would only broacasted to connected BP node

Description
Currently transaction sent to FullNode, only connected BP node can accepted transaction. And those transactions not broadcasted to other BP node.
So only connected BP node can execute those transactions when it turns generate block.

This issues is also reproducable with a "BP only" setup (like 3 BPs): if you remove one of the connections and make the network graph look like this: BP1 <-> BP2 <-> BP3 and send transactions to BP3, the problem is also visible - transactions are not relayed to BP1. The event that was supposed to be launched was removed by accident. This is fixed with #549.


UI lists Google Generative AI Embeddings as Custom Component

Bug Description
Google Generative AI Component doesn't
Likely just need to change   display_name = "Custom Component"
Reproduction

In LFv1.0.17, click Embeddings.
View component.

Expected behavior
Display name should be Google Generative AI Embeddings
Who can help?
No response
Operating System
M1 Mac
Langflow Version
1.0.17
Python Version
None
Screenshot

Flow File
No response

@mendonk
Seems to be correct. I'm on the main branch.


[Feature Req] Add QR code to the Donation page

Subject of the issue
Can a UPI payment QR code be added alongside the table where bank details of CMRF is provided? That's a good call for action. Donors can quickly scan and pay.
Your environment
Feature.
Expected behaviour

It's being worked on! on  #510


Global namespace pollution when using rollupOptions.output.format umd

Describe the bug
I'm building a bundle with umd format as a target. When doing so I expect the result bundle to be wrapped in an iife function. The configuration looks like this :
  build: {
    rollupOptions: {
      output: {
        format: "umd",
        entryFileNames: "bundle.js",
      },
    },
  },

Instead, I have variables declared outside the iife :

This is a problem because the variables' declaration might override previous variables with the same name. This is how I encountered the issue.
Workaround :
So far, I have used a homemade plugin to wrap my final code in a iife :
import { defineConfig } from "vite";

// https://vitejs.dev/config/
export default defineConfig({
  build: {
    rollupOptions: {
      output: {
        format: "umd",
        entryFileNames: "bundle.js",
      },
    },
  },
  plugins: [viteWrapCodeInIIFE({ files: ["bundle.js"] })],
});

function viteWrapCodeInIIFE(options = {}) {
  return {
    name: "vite-wrap-code-in-iife",
    apply: "build",
    enforce: "post",
    generateBundle(outputOptions, bundle) {
      for (const [fileName, chunkOrAsset] of Object.entries(bundle)) {
        if (
          chunkOrAsset.type === "chunk" &&
          options.files &&
          options.files.includes(fileName)
        ) {
          chunkOrAsset.code = `(function () {${chunkOrAsset.code}})();`;
        }
      }
    },
  };
}

I'm willing to work on a PR. I believe the fix would be an extension of the https://github.com/vitejs/vite/pull/7948 so that is also applies when rollupOptions.output.format is umd or iife.
Reproduction
See steps
Steps to reproduce

Bootstrap a vite project

npm init vite@latest test -- --template vanilla && cd test && npm install

Install the "react-query" package that causes the build to have variables defined outside the iife

npm install @tanstack/react-query

Create a vite.config.js with the umd format as a target

cat <<EOF > vite.config.js
import { defineConfig } from "vite";

// https://vitejs.dev/config/
export default defineConfig({
  build: {
    rollupOptions: {
      output: {
        format: "umd",
        entryFileNames: "bundle.js",
      },
    },
  },
});
EOF

Change the main.js

cat <<EOF > main.js
import { QueryClient } from "@tanstack/react-query";

const queryClient = new QueryClient();
EOF

Build the bundle

npm run build

See the result in dist/bundle.js

System Info
System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 330.16 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 3.5.1 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.0.14 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 126.0.6478.127
    Firefox Nightly: 121.0a1
    Safari: 16.5.2
  npmPackages:
    vite: ^5.3.1 => 5.3.3

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I haven't checked deeply but I guess we should use opts.format === 'iife' || opts.format === 'umd' instead of config.build.lib for people using IIFE/UMD format without turning lib mode on.
https://github.com/vitejs/vite/blob/22b299429599834bf1855b53264a28ae5ff8f888/packages/vite/src/node/plugins/esbuild.ts#L320

I haven't checked deeply but I guess we should use opts.format === 'iife' || opts.format === 'umd' instead of config.build.lib for people using IIFE/UMD format without turning lib mode on.
https://github.com/vitejs/vite/blob/22b299429599834bf1855b53264a28ae5ff8f888/packages/vite/src/node/plugins/esbuild.ts#L320

This is what I was thinking too 👍 . I can work on a PR as soon as this is confirmed as a bug

Yeah, I think it's a bug.


User detail page not using correct template

User detail page contents incorrect and navbar missing

The contents point to it using template:  reprohack_site/reprohack_hub/templates/users/user_detail.html https://github.com/reprohack/reprohack_site/blob/dev/reprohack_hub/templates/users/user_detail.html
but from the template specification in:
https://github.com/reprohack/reprohack_site/blob/12df82d9b7790bf4e410d0e8181895e28434b943/reprohack_hub/reprohack/views.py#L267-L269
and the URL specification in urls.py:
https://github.com/reprohack/reprohack_site/blob/12df82d9b7790bf4e410d0e8181895e28434b943/reprohack_hub/reprohack/urls.py#L22
it should be using template reprohack_site/reprohack_hub/reprohack/templates/registration/user_detail.html https://github.com/reprohack/reprohack_site/blob/dev/reprohack_hub/reprohack/templates/registration/user_detail.html
🤷♀

There's another UserDetailView specification here:
https://github.com/reprohack/reprohack_site/blob/12df82d9b7790bf4e410d0e8181895e28434b943/reprohack_hub/users/views.py#L11-L18
I wonder if it's overriding the one above?

Indeed it looks like that's what's happening as adding template_name = "registration/user_detail.html to the UserDetailView specification in reprohack_site/reprohack_hub/users/views.py brought up the right page.
Now we have a front-end issue with how successful login notification is interacting with navbar:

Resolved by #71


Add included_field for whitelisting

Problem Statement
#165 is about blacklisting fields. I want to whitelist them.
Describe the solution you'd like
I would like a new included_fields which is mutually exclusive with excluded_fields.
Describe alternatives you've considered
My current solution is inelegant and is basically blacklisting everything except the fields I want, then writing a test to prevent any developers from accidentally adding new fields without blacklisting them.

Any news on this topic?

This would be useful for us too. @rossmechanic would a PR for this still be welcome?

I could take a pass at this, if a PR would be considered. It looks like it would be pretty straightforward on the implementation side and the existing PollWithExcludeFields model and test cases should be simple enough to riff on.

I started working on this feature here.
The feature is in a POC state but, as expected, it does seem to work. My use case involves FKs, so that's what I need to address next. Any initial feedback would be most welcome.


Develop

coverage: 92.124% (-2.4%) from 94.567%
when pulling 20abb7158f47e676cecdd838db6f21539aaedf1a on jasonwaters:develop
into d53a1aec292a498b6111dd98d3e4f9c3116577fd on adobe:master.


Switch the signature for the pure callback

This PR does not touch the callbacks related to the CrsGraphWrapper.

Rebased on master so that we don't constantly trigger container rebuild. First three commits are the same as prior to the review.

Any chance to get some more tests with a distinct Value type?

Should do that. But maybe as a separate PR?

No difference in performance benchmark (here).

I am ok with PR pending Daniel's approval (hence comment instead of formal approve)

I would prefer if we could document some more what these changes actually mean in practice either with an example or a pull request to https://github.com/arborx/Wiki but I didn't mind if that's done in a follow-up.

Please squash merge

I would prefer to have at least 3 commits here (like the first 3). I can rebase to integrate the reviews (last 2 commits) into them if you prefer that.

I would prefer if we could document some more what these changes actually mean in practice either with an example or a pull request to arborx/Wiki but I didn't mind if that's done in a follow-up.

We'll do that. My first priority is getting everything in. I think I've scoped everything and know the path, but there may be some corner cases I still haven't considered. So I'm hesitant to put work into documentation right now until we get everything in, are happy with the final result, and made sure all our use cases work fine with it.

Please squash merge

I would prefer to have at least 3 commits here (like the first 3). I can rebase to integrate the reviews (last 2 commits) into them if you prefer that.

ok with cleanup

Everything passes except HIP which did not run.


gccgo: cmd/internal/obj/x86 takes a long time to compile

Fedora on amd64 uses gccgo as the default Go implementation installed to /usr, and using this to bootstrap the gc implementation takes a very long time due to compiling cmd/internal/obj/x86:
matthew@bento:~/wd/go/pkg/bootstrap/src/bootstrap/cmd/internal/obj/x86$ time /usr/bin/gccgo -c -O2 -g -m64 -fdebug-prefix-map=$WORK=/tmp/go-build -gno-record-gcc-switches -fgo-pkgpath=bootstrap/cmd/internal/obj/x86 -o $WORK/b072/_go_.o -I $WORK/b072/_importcfgroot_ ./a.out.go ./aenum.go ./anames.go ./asm6.go ./avx_optabs.go ./evex.go ./list6.go ./obj6.go ./ytab.go

real	7m0.867s
user	6m59.107s
sys	0m0.377s

matthew@bento:~/wd/go/pkg/bootstrap/src/bootstrap/cmd/internal/obj/x86$ /usr/bin/gccgo -v
Using built-in specs.
COLLECT_GCC=/usr/bin/gccgo
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/11/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap --enable-languages=c,c++,fortran,objc,obj-c++,ada,go,d,lto --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-shared --enable-threads=posix --enable-checking=release --enable-multilib --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions --enable-gnu-unique-object --enable-linker-build-id --with-gcc-major-version-only --with-linker-hash-style=gnu --enable-plugin --enable-initfini-array --with-isl=/builddir/build/BUILD/gcc-11.1.1-20210428/obj-x86_64-redhat-linux/isl-install --enable-offload-targets=nvptx-none --without-cuda-driver --enable-gnu-indirect-function --enable-cet --with-tune=generic --with-arch_32=i686 --build=x86_64-redhat-linux
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.1.1 20210428 (Red Hat 11.1.1-1) (GCC)

/cc @ianlancetaylor

Compiling cmd/compile/internal/ssa also takes about 90 seconds. More understandable since ssa is a large package with a lot of code, but mentioning in case there's anything to do about it too.

I can reproduce this on tip, more or less.
On my machine the "bootstrap/cmd/internal/obj/x86" build takes about 257 seconds at "-O2" and 450 seconds at "-O1".
The offending pass appears to be variable_tracking; looks like the time is being spent in alias analysis / memory disambiguation.
Attaching a couple of profiles.

tree.txt
top10.txt

As an experiment, I carved off the file avx_optabs.go from the package and put it into its own stand-alone module.   The new package takes about 3 minutes to compile at -O1 and 1.5 minutes at -O2.
I also did a bit of experimenting with GCC to see if this is a regression or whether the problem has been around for a while. Turns out that this behavior has been there for a good long while. I tested (using release branches) gcc-8, gcc-9, gcc-10, and gcc-11, and I'm seeing long compile times for all of them (gcc-11 is maybe 5 or 10 percent faster, but that's it).  So I don't think this is a situation where we can bisect it to a specific GCC commit.

I filed an upstream GCC bug for this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101064

@thanm Thanks for investigating and filing the GCC issue. Do you see any non-invasive tweaks we could make to the cmd/internal/obj/x86 sources to mitigate this issue and get better compile times under gccgo? E.g., could we break up the variable initializers into explicit initialization functions or something?

Do you see any non-invasive tweaks we could make to the cmd/internal/obj/x86 sources to mitigate this issue and get better compile times under gccgo?

I was going to suggest breaking out avx_optabs into a separate package (I prototyped that to see if if would work), which would help reduce the critical path. Looks like Ian has sent a gofrontend change however.

I've committed GCC patches to make this significantly faster on GCC mainline and GCC 11 branch.  However, it will of course take a while for these fixes to move through the GCC release process and the distro release process.
I don't know that we really want to change the generated code merely to make gccgo builds faster.  But if we do, I think that compile time would be shorter if we avoid a large composite literal and instead set each element separately, as in
	avxOptab[0] = Optab{as: AANDNL, ytab: _yandnl, prefix: Pavx, op: opBytes{
		avxEscape | vex128 | vex0F38 | vexW0, 0xF2,
	}}
	avxOptab[1] = Optab{{as: AANDNQ, ytab: _yandnl, prefix: Pavx, op: opBytes{
		avxEscape | vex128 | vex0F38 | vexW1, 0xF2,
	}}
 	...

(but I haven't actually tried it).

I've committed GCC patches to make this significantly faster on GCC mainline and GCC 11 branch.

Thanks!

I think that compile time would be shorter if we avoid a large composite literal and instead set each element separately

Yeah, that seems too invasive to be worth the trouble. I assume the issue will go away in ~6 months when I upgrade to Fedora 35 and get the new GCC.
I'm happy to consider this issue fixed, unless you have more gccgo changes in mind.

Nothing else planned, so closing.


Branch 1.5

Current coverage is 76.46%

Merging #269 into branch-1.5 will increase coverage by +1.27% as of 232dc80

@@            branch-1.5    #269   diff @@
==========================================
  Files               40      40
  Stmts             3930    3930
  Branches           342     340     -2
  Methods
==========================================
+ Hit               2955    3005    +50
+ Partial            143     142     -1
+ Missed             832     783    -49

Review entire Coverage Diff as of 232dc80

Powered by Codecov. Updated on successful CI builds.


[BUG] client.calculate returns ConnectionResultsData only for one loadcase, not for all

Describe the bug
If you have multiple loadcases, the results are not returned
client.Calculate(con.Identifier) returns results only for one loadcase (first one?)
Expected behavior
Result object shall have information for all loadcases
Screenshots
Two loadcases in the model

the result contains 16 entries for 16 bolts, but only for loadcaseId=0

Desktop (please complete the following information):

OS: [Windows 23H2]
IdeaStaticaPlugin [<IP_ADDRESS>8]
IdeaStatiCa Version [e.g. 24.0]

Hi @ZTThomasOberthanner, I believe it outputs results for the extreme load case. You cannot currently get results for individual load cases.

please consider adding all loadcases. shoud be fairly easy, because the LoadCaseID is already there for all entries, so it easy to distinguish...

HI @ZTThomasOberthanner, yes we are considering improving this. I will change this from a bug to possible improvement. Thanks for all your suggestions.

hi @nathanlukeIDEA. Piggy backing on two open issues.
I need to get fatigue results for multiple load cases. Currently, the Idea Connection application does not let you choose the load case for the report, and does not give results for extreme but for one selected load case.
So i tried to access the results using the api but :

400
"Request failed Fatigues analysis is not supported."
and as @ZTThomasOberthanner said there might not be results for all load cases anyway in the response.
Could you please take a look ?

Hi @lionelclotcamus, the first step is to look at least get some results for fatigue analysis (for the extreme calculations) through the API. We are working on this right now and it should be available soon. We are looking at a full approach to getting results as you require, although it is likely a little bit away.


Bitstamp missing currency_pair property

When calling:
https://www.bitstamp.net/api/v2/open_orders/all/
BitstampOrder class is missing:
currency_pair (if all currency pairs) | Currency Pair.
https://www.bitstamp.net/api/

thanks for reporting
feel free to submit a pull request

PR created: https://github.com/knowm/XChange/pull/3305


Create a process to download and import location & review data

Overview
Create a process to fetch locations and reviews from the Yelp API, and then process that data to import it as models in Django.
Context
Blocked by #8, but can be branched off of #21
Suggested solution (optional)
Once the process is figured out, add a script to automate this and add to the work being done on #5

Could I take this one on?

Yeah! I was going to ask for your help on this since you have done the most poking at the Yelp API, but yeah, go for it!


libgit: add a git browser that doesn't require a checkout

Browser uses the gogit Tree instance to navigate directories and read files directly from a dotgit directory, without requiring an explicit checkout.
This will be used in future commits as the basis for the new .kbfs_autogit directory.
The test provided is pretty simple but covers the basics.  I'm happy to add more stuff to the test if there are specific things you think would be good to add.
Issue: KBFS-3421

Thanks @songgao, please review the new commits, especially the ReadAt one since it contains non-trivial new logic.


misc: improve asset.py typing

Summary
blocked by https://github.com/DisnakeDev/disnake/pull/889
Improves asset.py typing (soon member.py, I need this PR first), the only errors I have are this:

My suggestion is to do os.PathLike[str] and os.PathLike[bytes].
See this and this.

I don't think we can do anything with this, let's just ignore it?

Checklist

[ ] If code changes were made, then they have been tested

[ ] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running task lint
[x] I have type-checked the code by running task pyright

[x] This PR fixes an issue
[ ] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Could this PR be unlinked from #889? I don't see anything in there that would be blocking this PR, perhaps they can be merged the other way around? I'm assuming the apidocs PR for avatar decorations won't be merged any time soon.

perhaps they can be merged the other way around? I'm assuming the apidocs PR for avatar decorations won't be merged any time soon.

sounds good for me 👍


When the AppFlowData changes, every page in the stack is rebuilt (can I get around it?)

Describe the bug
This is probably more of a question than an actual bug. Every change I make to the AppFlowData causes every page that is in the stack to rebuild itself. The problem is that I need for a particular page (the homepage) to show some animations and perform an API call when it first loads, however, when the home page adds another page to the stack or the page added is popped, for example, the homepage is rebuilt, showing the animation again and calling the API once more.
This is not the same behavior as if you are using named routes in the MaterialApp. I want to know if this is the expected behavior and how (if possible) I can get around it.
To Reproduce
Steps to reproduce the behavior:

Create two pages and a FlowBuilder that starts only with one of them
On a button click on the first page, change the FlowData to add the other page to the stack
When you click the button (or pop the second page for that matter) you will realize that the first page was rebuilt.

I made an example in this repository.
Expected behavior
I believe the expected behavior should be the same as if you were using Flutter's regular routes system (MaterialRoute with routes property): when a page is added or removed from the stack, the other pages are not rebuilt.

Ran into the same issue with your reproduction sample. Upon further testing, it seems that when there are multiple pages in the navigation stack, whenever context.flow<FlowState>().update() is called with a change to FlowState all the pages provided in onGeneratePages get rebuilt.
A workaround could be to modify your flow state so that the home page is not included in onGeneratePages after you navigate to a new page. For example, in your flow_navigation reproduction sample you can modify routes.dart accordingly:
onGeneratePages: (state, pages) => [
  if (!state.subpage)
    MaterialPage<void>(
      child: Home(),
    ),
  if (state.subpage)
    MaterialPage<void>(
      child: Subpage(),
    ),
],

This way, once context.flow<AppFlowData>().update((data) => data.copyWith(subpage: true)) is called Home will not be included in the onGeneratePages list and won't get rebuilt.

I'm able to reproduce this on the onboarding example of this repo @felangel


[CHALLENGE SUBMISSION]  Challenge 3

Please provide the following information for your submission:
What is your name? (First, Last)
Agata Krauzewicz
Where is your GitHub Repo ?(With your challenge solution)
https://github.com/ExpressionSigh/25DaysOfServerless/tree/master/Challenge3
What Challenge is this for? (Challenge number between 1 and 25)
3
(Optional) Anything else we should know? e.g., language used, location, blog post?
Location: Poland
Azure Functions v2
Language: C#
Database CosmosDB

The unthinkable has happened: after weeks of community members all over the globe chipping in to help solve people's problems with serverless technology, the evil grinch's heart is starting to soften! He's still not quite ready to give up his server-stealing plot, but our whole Azure Cloud Advocacy team is flying up to the grinch's lair to help convince him to change his ways.
As such, the team behind 25 Days of Serverless is OOF (Out Of Facility/Office) between Dec 24, 2019 and January 1, 2020. We'll not review Issues in this period of time, but encourage you to catch up on any challenges you haven't had the time to work on yet. 😄 Our Discord Server is a perfect place to reach out to for community support during this time. After our return, we'll add contributors who submitted a working solution as an Issue to CONTRIBUTORS.md file until January 15, 2020.


Message on empty queue

I think the "Can't toggle song" message should not be shown if the queue is empty.

I think that some message should be shown when your keyboard shortcuts
don't have an effect. There's no UI open to convey the fact that it's not
just buffering or something, so..?
On Thu, Jan 15, 2015 at 10:13 AM, Christian Swan<EMAIL_ADDRESS>wrote:

I think the "Can't toggle song" message should not be shown if the queue
is empty.
—
Reply to this email directly or view it on GitHub
https://github.com/MeoMix/StreamusChromeExtension/issues/334.

Yea sure, if something is in the queue you are absolutly right, but what if there is nothing in the queue?  So we do not need the message right?

Err... I mean, if you cleared your queue, went and did some things,
forgot that you cleared your queue, come back to your pc, and use a
keyboard shortcut to tell Streamus to start playing again... and
nothing happens and no music comes out... that would be weird, right?
You'd only ever see the "Can't toggle song" message when the queue is empty.
On 1/15/15, Christian Swan<EMAIL_ADDRESS>wrote:

Yea sure, if something is in the queue you are absolutly right, but what if
there is nothing in the queue?  So we do not need the message right?

Reply to this email directly or view it on GitHub:
https://github.com/MeoMix/StreamusChromeExtension/issues/334#issuecomment-70162611

I understand your idea there. But i guess you to not need to move every responsibilty away from the user. I mean, if you cleared the queue you should know that you've done it. Take a look at every other media player.
Another thing is, when you've mapped the same shortcut e.g. the media play key to another player you always get this message, which could be very annoying.

Is the same keyboard shortcut able to be mapped to multiple players? I
figured Chrome would consume the shortcut, but maybe not! Hadn't tried that.
On Fri, Jan 16, 2015 at 2:44 AM, Christian Swan<EMAIL_ADDRESS>wrote:

I understand your idea there. But i guess you to not need to move every
responsibilty away from the user. I mean, if you cleared the queue you
should know that you've done it. Take a look at every other media player.
Another thing is, when you've mapped the same shortcut e.g. the media play
key to another player you always get this message, which could be very
annoying.
—
Reply to this email directly or view it on GitHub
https://github.com/MeoMix/StreamusChromeExtension/issues/334#issuecomment-70236822
.

It is possible to map an key to multiple players.
Also I use for example Google play music and Pandora with an plugin called
streamkeys. So pausing / starting in song in one of these with the same
keyboard shortcut toggles the message.
Am 16.01.2015 18:37 schrieb "Sean Anderson"<EMAIL_ADDRESS>
Is the same keyboard shortcut able to be mapped to multiple players? I
figured Chrome would consume the shortcut, but maybe not! Hadn't tried
that.
On Fri, Jan 16, 2015 at 2:44 AM, Christian Swan<EMAIL_ADDRESS>wrote:

I understand your idea there. But i guess you to not need to move every
responsibilty away from the user. I mean, if you cleared the queue you
should know that you've done it. Take a look at every other media
player.
Another thing is, when you've mapped the same shortcut e.g. the media
play
key to another player you always get this message, which could be very
annoying.
—
Reply to this email directly or view it on GitHub
<
https://github.com/MeoMix/StreamusChromeExtension/issues/334#issuecomment-70236822>

.

—
Reply to this email directly or view it on GitHub
https://github.com/MeoMix/StreamusChromeExtension/issues/334#issuecomment-70290574
.

Eh, I guess I just disagree. There's a lot of odd problems that will happen if you map the same key to multiple programs. If I hit 'play' and nothing plays then I want a warning. You can disable notifications entirely if they're interfering with your workflow and I think that's sufficient.


Change own password

User should be able to change their own password through the 'My Account' link in the upper right profile menu - as documented here - https://docs.google.com/document/d/1rDXmdlB3lfqAb7uAhR1u96LbyNaUyl3_2t2O_C0kI_E/edit?pli=1#bookmark=id.fm2m7txszq6 and designed here - https://mongodb.invisionapp.com/share/VJXLVXNPGW4#/screens/422332164 (click the 'change password' button)

@brittanylau this would be a great one to take if you have some time!

@Sheeri sounds good, I'll check it out tomorrow! :)

Ok. Just FYI this involves realm so let me know if you don’t have a build environment set up, I can get you access to my test env.

@Sheeri it seems that changing Realm user passwords can only be done through a password reset. Realm's password reset function requires we pass in a token and tokenId, which can only be retrieved from an email sent to the user.
I could be misunderstanding the docs, so let me know if any Realm experts have other ideas! :)
Here's what would be needed:

Send an email to the user to confirm their identity (valid for 30 mins)

User clicks on a password reset link provided in the email (Realm appends the token and tokenId as query parameters)

URL and email subject are customizable

User enters a new password on the page

Where should we integrate these extra steps in the flow?

Nevermind! I misunderstood the docs after all :) PR coming in shortly!


Review Ticket

Expected
.1 - Frontend UI demo.   UI takes inputs and passes them to an API and returns data from the backend to frontend.
.1 - Postman API Demo.  JSON Raw/Body formatted API passes inputs to backend and updates persistent table.
.1 - Java Demo - Object Creation.  Tester method that shows creation of Objects and outputs to Terminal, illustrate printing objects (hopefully using toString().
Extra for now, required at end of project
.1 - Java Demo - Model Init.   Delete database and show the creation and population of tables.   Expected in this step is the use of CommandLineRunner and the use of a tool like SQLite Viewer
.1 - Java Demo with Postman or UI - All CRUD methods.   Above was focused on Create and Read, this is focused on Update and Delete.
.1 - JWT Demo - Show UI receiving and setting cookie and backend providing cookie through /authenticate like method reivew ticket

Final Score = 2.4 + 0.5 = 2.9/3
Expected
.1 - Frontend UI demo. -  UI is very user-friendly, and well constructed for market place. Added filters as well.  +0.1
.1 - Postman API Demo. - Postman working well with deployed version. +0.1
.1 - Java Demo - Tester method in the class file for POJO +0.1
Extra for now, required at end of project
.1 - Java Demo - Model Init.  - Contains local initializing data. +0.1
.1 - Java Demo with Postman or UI - Can perform all the CRUD functions, with the initialized data. +0.1
.1 - JWT Demo - Create user is working, and users can authenticate. Endpoint security done as well. However, it works through postman, and isn't completely connected to the frontend. -0.1


Fix supershell blowing away lines on windows

In 85d17889b6ff39c4d93f516fc247b91be73514f0, I attempted to fix
supershell messages getting interlaced with log lines. It turned out
that that approach didn't work with windows and was causing all of the
output to bet blown away. A better approach is to check if the bytes
we're writing contain one or more line separators. If so, we can wrap
the bytes in a string and split the string into lines. Then we can
append a ClearScreenAfterCursor before every newline.
I think the problem with windows was that the ClearScreenAfterCursor was
coming between the carraige return and the newline.

I forgot to actually test #6112 on windows and it caused problems. This time I could not reproduce interlacing on windows or mac.


Wrong range for Observer.parallactic_angle

Astroplan 0.4 (in use with astropy 2.0.9 in case that matters) is having a problem with Observer.parallactic_angle() .
This wraps the angle into the -90..+90 range, whereas the parallactic angle should be in the -180..+180 range.
See e.g. https://en.wikipedia.org/wiki/Position_angle. The error is obviously that the np.arctan() function was used where the 2-argument np.arctan2() is in order.

Fixed in #386.


feat(0.18): version 0.18.0

Upgrade to version 0.18.0

Thanks @guggero! Tested locally and it works fine. Docker Cloud is building the new images but may take a couple of hours to get everything finished.

Thank you!


Whisper stt api

Whisper is working.

Works great! Thank you for implementing it, this is one of the most asked for features.
It's late here but I will merge this tomorrow. I'll do a quick review to note down any tweaks I want to make.

Works great! Thank you for implementing it, this is one of the most asked for features.
It's late here but I will merge this tomorrow. I'll do a quick review to note down any tweaks I want to make.

Improvements can be many : https://github.com/saharmor/whisper-playground/tree/main/interface/src, we can learn from this , because it does incremental transcribing which would be vastly better than chunking.


Error on adding Other signers

Was trying to create Vault 2 of 3 Mobile key, seed key and Others signers Pre-Live : 1.2.6 (348)
While adding others signers this was the bug

[x] Got both Success and error Toast message
[x] Errors message stays on screen forever ultimately killed the app to use again
[ ] Crash on health check

https://github.com/bithyve/bitcoin-keeper/assets/107177634/9cccb7a3-54e5-4c6d-aab5-4f4f29e6c1b8

@PraneethGunas 1 and 2nd worked, 3 still do not works


Use Helium API Circulating Supply

Currently the circulating supply tile on https://explorer.helium.com/market seems to imply it's being fetched from Coingecko.
Can we get this fixed to use our API and have some indication that the Coingecko link is just a reference to another place to go check out for market data?

Hello! I would love to work on this one. In addition to changing to use Helium API, do you have any preference for an indication that the link is to another place? My first ideas are using "Other sources" or "More data" instead of "View more"?

@MattCarlos96  great! I've assigned it to you 😄
I think "View external source" sounds good to me, maybe @cokes518  could chime in if she could think of something else in terms of wording, or other things that could be changed on that page


feat: Update ESLint dependencies

Follow-up of #9251

Closes #9590
Fixes #9583

@ianschmitz @iansu This one can be merged 🙂

I think they are out of date already here, might want to update to 4.1.0.

Hey @MichaelDeBoey, thanks for the PR.  💯
Is there any news or update on when should we expect this?

@silver-snoopy I've updated the @typescript-eslint/eslint-plugin & @typescript-eslint/parser dependencies, so this one is good to be merged 🙂

Thanks @MichaelDeBoey, I'll wait for another approval and we can merge this in!

@ianschmitz @mrmckeb could we have a release to publish these changes? Currently<EMAIL_ADDRESS>has very old peer dependencies specified:
<EMAIL_ADDRESS>

A new release would also close #8998

That would be super if these changes could be released!

There was a next / alpha version of this published last week.
https://www.npmjs.com/package/eslint-config-react-app/v/6.0.0-next.98
Hopefully that will help until we get this released.


PRACK send with an undefined rseq value in RAck header

In some scenarios I see that SIP.js sends a PRACK, but the RAck header  contains "undefined" as rseq number.
The an resq does not exist in in the responses before.
Those are the relevant sip headers for an outgoing call from SIP.js 0.13.5, I removed the headers which are not relevant:
->
INVITE sip:123456789@null SIP/2.0
CSeq: 2641 INVITE
Allow: ACK,CANCEL,INVITE,MESSAGE,BYE,OPTIONS,INFO,NOTIFY,REFER
Supported: outbound
Contact: <sip:123@g2rohmtp9vaq.invalid;transport=wss;ob>

<-
SIP/2.0 183 Session Progress
CSeq: 2641 INVITE
Supported: replaces
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Contact: <sip:456@<IP_ADDRESS>:5060;transport=udp>

(with SDP)

<-
SIP/2.0 180 Ringing
CSeq: 2641 INVITE
Supported: replaces
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE
Contact: <sip:456@<IP_ADDRESS>:5060;transport=udp>

->
PRACK sip:456@<IP_ADDRESS>:5060;transport=udp SIP/2.0
CSeq: 2642 PRACK
Supported: outbound
RAck: undefined 2641 INVITE

<-
SIP/2.0 400 Bad Request
Warning: 399 sip "Syntax error in RAck"

To Reproduce (if possible)
Make a outbound call to a destination which first answers with 183 Session progress and than with 180 Ringing.
Not sure if this is timing related.
The issue does not happen if there is a 180 Ringing and then an 183 SDP (no PRACK is send as all)
Expected behavior
The PRACK should not be send at all, because the other side does not Indicate 100rel as Supported  or as Required.
Observed behavior
A PRACK is send even it the rseq is unknown
Environment Information
Chrome 73 on MAC OS.
Additional context
As a quick fix the could should check if the presense of the rseq before sending any PRACK.
In SIP.js 0.13.7:
22690             extraHeaders.push("RAck: " + response.getHeader("rseq") + " " + response.getHeader("cseq"));
22691             this.earlyDialogs[id].pracked.push(response.getHeader("rseq"));
22692             this.earlyDialogs[id].sendRequest(this, Constants_1.C.PRACK, {

The sendRequest should be only send if  response.getHeader("rseq") returns something.

We believe that this should be resolved in 0.14.1. Can you please test and let us know?

Closing this due to inactivity. Feel free to re-open or open a new issue if the issue persists, but we believe the issue has been resolved since 0.14.0 (suggested version is currently 0.14.2).


[Bug] Set rotation duplicate trigger event "CAMERA MODIFIED"?

Descreva o bug
Set rotation duplicate trigger event "CAMERA MODIFIED"? it's normal?
Steps to Reproduce
var viewport = cornerstone.getRenderingEngines()[0].getViewports()[0];
viewport.element.addEventListener(cornerstone.Enums.Events.CAMERA_MODIFIED, function(e) {
   console.log(e);
});

test: ohif viewer using magnify tool

I don't know if it's normal or not?
I created an overlay that needs a "camera modified" event to update the data, I noticed it fires twice but there could be more.

I don't use react or others, I use pure javascript

Thanks for the report, we will investigate

Here are the results of my investigation...

I believe the multiple events for rotation was introduced (by me 🙁) in this PR https://github.com/cornerstonejs/cornerstone3D/pull/388, but can be easily fixed by not firing an event in the StackVeiewport.setRotationGPU method.
from what I can best tell, for zoom and pan there are NOT multiple camera modified events fired; what was reported here, I believe is each of the events fired when dragging the mouse during zoom
I was not able to reproduce the exception during zoom that was reported; perhaps it is fixed in the latest OHIF/Cornerstone3D?


Update pydantic to v2.7.3

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Changelog entries must be created for modifications to shipped code
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

https://datadoghq.atlassian.net/browse/DBMON-4147 Oracle test failure is not due to this PR change, it happens in master too

Will be taken care with https://github.com/DataDog/integrations-core/pull/17802


Consolidate repositories

Code is currently spread across DevCamp and DevCampSharedDotNetAPI
Finish combining the two into the DevCamp repo.

All dependencies on DevCampSharedDotNetAPI have been removed. Ready to consolidate, but will wait a few weeks before deleting the redundant DVSDNA repo.

Deleted


corrected errors in sample code in README.md

Description
Corrected the three code snippets to be easier for new users to use.  Fixed broken sample code that used non-existent methods.  Made "rya_" prefix consistent between code snippets.  Greatly simplified the sample code which writes to Rya by removing many lines of unneeded code while retaining the same capability.
Links
Jira

asfbot build

asfbot build


can't get attachment from RpcContext.getContext().getAttachment(""), althougth I've set some values into attachment in my custom filter

dubbo version: 2.7.8
jdk version: 1.8.1
all details had been descibed in title.

it seems influenced by the param "order" of annotation "Activate", when it been set with a low integer, this will hapened.


Fix sed-issue with google earth patch

The code is currently :
     sed -i 's/drawRockTree = false/drawRockTree = true/g' /gemib/drivers.ini
And it should be modifying this entry in drivers.ini, but I currently don't understand why it's causing an error:

How can you use Google Eath. It is disabled since 2017....

No it's not 😁

No it's not 😁

Any chance you could point us to what to do/search for to get the Google Earth functionality back? I'm suspecting that first I need to at least remove my car from the car-net subscription as I don't get a licence for GE from the VW servers and functionality is disabled. There must be some way to bypass this licence check completely so GE will work? With Audi MMI system I've seen some coding to get GE working without MyAudi, is it similar to this?
Anyway, thanks for the great work you've done! I'm really loving getting into and modding my MIB2 with your tools 👍

The code is currently :
 sed -i 's/drawRockTree = false/drawRockTree = true/g' /gemib/drivers.ini
And it should be modifying this entry in drivers.ini, but I currently don't understand why it's causing an error:

Hi, if I add this manually is google earth then working?
Thx

Hi, I have modified manually
/gemib/gemib.cfg
and
/gemib/drivers.ini
But I cannot regonize any changes in my navi. Google earth view is still not here.
Am I missing something?
Thx

This feature will only enable the 3d view for Google Earth. It will not enable Google Earth itself. You need the licenses for that, which you can get through carnet.
Also see the following from the readme :-)

Hi, is it possible to puchase such a licence?
Is it possible to get Google Earth on Mib2.5 on a 2019 car?
I can't find something... :/
Thank you!
BR
Chillout<EMAIL_ADDRESS>schrieb am Mi., 25. Nov. 2020, 18:18:

This feature will only enable the 3d view for Google Earth. It will not
enable Google Earth itself. You need the licenses for that, which you can
get through carnet.
Also see the following from the readme :-)
[image: image]
https://user-images.githubusercontent.com/8352494/100261066-81ff2700-2f4a-11eb-9ed9-f063d5a6cacb.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jilleb/mib2-toolbox/issues/31#issuecomment-733840735,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARZZF2QSWBJEEIK6LRAKYF3SRU373ANCNFSM4KKVUPUA
.

Not through the officials ways, but if you decide to create your own back-end, it should be possible.

Hello.
How to create your own back-end? need a server to answer to mib? what need to modify in mib? what kind of parameters do you need in your own server?
Very interested into this!!!


Resolve: enhancing editorial pkg loader

We've upgraded the loader in several ways:

The timeline now includes a VFX data JSON string with Load and Publish metadata.
Each timeline is randomly assigned one of the available clip colors.
The update function ensures that the newest version is loaded into the media pool.
Timelines are organized into hierarchical bins, each with a dedicated version bin.
Manager Tool can easily list timelines within containers.

Testing steps

Use Traypublisher and publish couple times Editorial Package folder here is testing of ynput internal files (sensitive data) https://drive.google.com/open?id=1XbYdnblAuYuCYPaEBd48iSHhbcfjiOPm&usp=drive_fs
Open Resolve and Loader
Load the editorial_pkg product in lower version so you can version manage via Manager
After it is loaded and version updated notice there are multiple version folders and each of timeline is having different clip color assigned.

Could you provide testing instruction (or link me to a docs page) on how to generate an Editorial Pkg? And what to test for in this PR when loading?

@BigRoy have you had a chance to test it?

I have followed the testing steps and I have succesfully created that editorial package from the provided data (link) and tried to Load inside Resolve.

This seems to be doing what it should - judging from the screenshot, but the issue with offline clips is the version of Resolve. I will try to include the case.

Just to flag, if I understand correctly these PR #11 et #12 will introduce changes based on the legacy creator/publisher API. How do you forsee the merge ? This stuff firstly then the new creator or the other way around ?
(I totally don't mind doing the diff btw)

Apologies if this is a bit confusing. This needs to be merged first, and then the target of PR #12 will automatically change to develop. The dependency is mentioned in the description of #12. I hope I understood your question correctly.


take_while variant that eventually returns the original stream?

Does it make sense to add a way or alternative to TakeWhile that consumes self and returns the original stream once the predicate returns false?
My use case is fairly complicated, but here goes:
I'm in a situation where I have two separate codecs (for layering reasons), and I want to have a single stream which could return values from either codec by performing a "codec upgrade" dynamically. (Let's assume for now that I'm only interested in the decode side of the codec.)
Concretely, I have a base codec and one or more upgrade codecs. The base codec returns an enum of Header, PayloadStart, Payload and PayloadEnd. Payload contains a Vec<u8>.
Let's call the result of applying the base codec on an Io object the base stream, and the result of applying an upgrade codec onto a payload

Header should be passed through unconditionally.
PayloadStart should cause future values to be passed via the appropriate upgrade codec until the next PayloadEnd.
Payloads should cause the inner Vec<u8> to be extracted and run through the upgrade codec, and whatever comes out of there should be returned.
PayloadEnds should cause a downgrade back to values from the base codec.

The best way to do that seems to be to have a wrapper stream with the notion of a "current stream".
From the base stream:

Headers get passed through.
PayloadStart should cause a new stream to be created which consumes the base stream and layers the upgrade codec on top of future Payload objects.
PayloadEnd should cause the upgrade codec to no longer be applied and for us to switch back to the original stream.

Seems like I can do the first two using take_while, but not the third one.

Thinking about it a bit more, we may want to have a general notion of "stream that wraps a stream and transforms it temporarily", returning the original stream at the end. The TakeWhile variant could use this, and so could my upgrade stuff.

Note that in general we've considered adding get_ref/get_mut/into_inner to almost all the combinators to handle use cases like this, would that solve your use case here?

Yeah, it would! :)
I've implemented my own combinators with those methods for now.

One thing I wanted to flag is that since I was using dynamic dispatch across streams produced by a variety of codecs (all with the same In), this ended up being quite complicated. I defined a couple of traits:
/// A stream that wraps another stream. into_inner consumes this stream and
/// returns the original stream.
pub trait StreamWrapper<S: Stream> {
    fn into_inner(self) -> S;
}

/// A stream that wraps another stream. into_inner consumes this stream and
/// returns the original stream.
///
/// This is a boxed version of StreamWrapper, meant to be used for trait
/// objects.
pub trait BoxStreamWrapper<S: Stream> {
    fn into_inner(self: Box<Self>) -> S;
}

Then I defined a trait for trait objects that implemented both Stream and BoxStreamWrapper:
type MappedStream<T> = Map<TakeWhile<PartStream<T>, fn(&Part) -> BoolFuture, BoolFuture>, fn(Part) -> Vec<u8>>;

pub trait InnerStream<T>: Stream<Item=InnerPart, Error=io::Error> + BoxStreamWrapper<MappedStream<T>> where T: Read + 'static {
}

impl<T, U> InnerStream<T> for U where U: Stream<Item=InnerPart, Error=io::Error> + BoxStreamWrapper<MappedStream<T>>, T: Read + 'static {
}

pub type BoxInnerStream<T> = Box<InnerStream<T, Item=InnerPart, Error=io::Error>>;

At that point I could use Box<InnerStream<T>> effectively.
There might be a simpler way to do this -- not sure.

Ah yeah dynamic dispatch would throw a number of wrenches into this most likely, unfortunately

I had the same problem, for the same reason (parsing an inner stream), and became convinced that you need to box the original stream to make it work, because you need to return two new objects, each of which will hold a reference to the original. You can avoid most contention by having the inner stream "switch" modes exactly once.
I coded this up with tests, but ended up not using it because I could handle it better with an enhanced version of StreamGenerator:
https://github.com/robey/lib4bottle-rs/blob/master/src/stream_split.rs

Thanks for the update @robey!


'Export to csv' not working in Adminbro

When I choose export filter to csv in the Admin bro it doesnt apply the filter.
Here was my filter:

Here is the data i received:
https://docs.google.com/spreadsheets/d/1uqw40RxtxhhsVBq5_QwnBJ1V40z6I8Pfe2q8nxdHejM/edit#gid=975693035
I renamed the sheet to "Ashley Issue Sheet" so that you can easily find it.

Shall I move it to test column @CarlosQ96 ?


Log crashlytics output

When the Crashlytics action fails, it does not print sufficient error information to the console. This makes it difficult for users to diagnose their issues, as it just prints this unhelpful message:
Shell command exited with exit status 1 instead of 0.
This manifests in the following issues:
https://github.com/fastlane/fastlane/issues/4407
https://github.com/fastlane/fastlane/issues/4222
When the crashlytics output is shown in the console, it often becomes obvious what's going wrong. This PR specifies log: true when the Crashlytics submit command is executed so that helpful error information is printed.
With this change, here is some example failure output when I specify a group that doesn't exist:
[14:59:10]: fastlane finished with errors

[!] Exit status of command './Pods/Crashlytics/iOS/Crashlytics.framework/submit <redacted> <redacted> -ipaPath <redacted> -groupAliases 'this-group-does-not-exist' -notifications
 NO -debug NO' was 1 instead of 0.
2016-05-05 14:58:56.162 submit Crashlytics: Crashlytics.framework/submit 1.3.5 (17)
2016-05-05 14:59:10.652 submit Crashlytics: Unable to add testers: Could not find a group for one or more of: ["this-group-does-not-exist"]
2016-05-05 14:59:10.652 submit Crashlytics: Failed to add testers/groups to the release

Woah!  We must be on the same page @sweetmandm! I just merged https://github.com/fastlane/fastlane/pull/4526 a few minutes ago that does the same thing and it went out with fastlane 1.86.0. 👍  Please give that a try and let me know if it works for you.  I'm going to close this PR in favor of that one.

Excellent, good call on hiding the api keys in the output. I'll drop a note on those two issues I saw that were affected.

Awesome, thanks @sweetmandm 👍 !!


Updated webpack dependency

Updated webpack dependency. I've looked over the release changes (https://github.com/webpack/webpack/releases) nothing stands out and I've smoke tested the app locally.

:tada: This PR is included in version 1.477.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[DO-128] Download and test a big SW package

Test and time the package scanning with different -n values.
From SyncLinear.com | DO-128

DOS project scanned with n=1-8 as an example of small project (148 files and dirs). Results show 277% speed increase from 1 to 8 parallel processes used.

X-Road project scanned with n=1-8 as an example of a bigger project (6301 files and dirs). Results show 555% speed increase from 1 to 8 parallel processes used.


Library Detail Backend Changes

[ ] Gather Github stats necessary for new graphs
[ ] Render library.adoc in the root of the repository to HTML and save it into the database in a TextField which will be rendered below the graphs and other header/link elements.
[ ] Periodically pull and re-render these in a cron. Probably more frequently than we ware pulling maintainers and authors

Items Accomplished:

[x] Various small data points
[x] Author/maintainer info
[x] Loaded all the versions of each library, along with their GitHub data and author/maintainer data
[x] Loaded the date of the first GitHub tag for all libraries
[x] Made the details page version-specific

Remaining items:

[ ] Render the asciidoc in the body of the details page -- @vinniefalco where do I get that content?
[ ] Get number of commits per month going back to when the library was added and make that available to the template
[ ] Make the links version-sensitive when possible (links to docs, links to github, etc.)

Render the asciidoc in the body of the details page -- @vinniefalco where do I get that content?

I was thinking of having it come out of a directory in the library repository. for example
doc/library-detail.adoc

or if that file is not present, then it could come from the root:
README.adoc

alternatively, we can just show nothing if "doc/library-detail.adoc" is missing, and if it is present and is also a symbolic link to another file in the repo then we can resolve the link and use that file. This will allow the repository owner to create README.adoc in the root of the repository for GitHub to preview on the repository landing page, and also allow the repository owner to link doc/library-detail.adoc to README.md so that the same content appears on the corresponding library detail page.
This would have to use the right commit or branch. If the user has selected an older version then it needs to use the git tag corresponding to that version. The user can select "latest version" which is just the highest semantically valued tag. But there are also the "develop" and "master" choices which correspond to the library repository's commit-id in the superproject.

@vinniefalco @alandefreitas Thanks for your explanations. So for the library documentation --

Render the asciidoc in the body of the details page -- @vinniefalco where do I get that content?

I was thinking of having it come out of a directory in the library repository. for example

Do the asciidoc files for the library descriptions not exist in the library repos yet? Or if they do, can you point me to the one I should be using for asio, just as an example? https://github.com/boostorg/asio

The files do not exist yet :) Alan could you please copy README.md to library-detail.adoc (and convert to Asciidoc) for URL, JSON, and Beast? And ask the Boost.Redis and Boost.MySQL authors do to the same (and merge to develop)?

@williln library-detail.adoc is in boostorg/json/doc and boostorg/url/doc. I'll still do the other libs.

@alandefreitas Thank you! I'll use those as test cases when working on the asciidoc conversion.

@alandefreitas @vinniefalco The code to convert and cache asciidoc content is now in place, so I'm circling back around to load the doc/library-details.adoc content into the body of the Library Details page for the pages that have it.
For versions of the library that predate when that file was added or that otherwise don't have it, what should we show for the library description?
Local example of a library with that file:

And without that file:


./result/bin/copy-to-podman results in duplicated content

I'm not sure if it's a bug in your image for with the nix:// feature or in upstream Skopeo, but if I build an image (with like 5 layers) and then do copy-to-podman and then look in  ${HOME}/.local/share/containers/storage/vfs/dir (doesn't need Podman on the system) I see files inside there duplicated for each layer.
This inflates the image in my case from ~500MB docker image ls <my image name> to 2.4GB.
Can be reproduced by doing:
# 3 Layers image
nix build .\#examples.layered.copyToPodman
HOME=/tmp/ ./result/bin/copy-to-podman
nix run nixpkgs\#jdupes -- -r "/tmp/.local/share/containers/storage/vfs/dir" | grep libunistring.so
# file duplicated once for each layer
# libunistring-1.0/lib/libunistring.so.2.2.0
# libunistring-1.0/lib/libunistring.so.2.2.0
# libunistring-1.0/lib/libunistring.so.2.2.0
sudo rm -rf "/tmp/.local"

Issue doesn't appear to happen for docker images.

Nevermind. Same happens with Skopeo and actually also with just Podman alone.
HOME=/tmp/ podman pull docker.io/postgres:12.5-alpine
ncdu /tmp/.local

will show you the docker image ls reported 158MB to be come occupied 806MB with Podman, which might be depending on when Podman has no other storage drivers than basic filesystem available - but that's still pretty bad/unusable to me then.


feat: multiple sourcebuffer

feat: multiple sourcebuffer
Description
use two sourcebuffer to manage audio and video track
see https://github.com/zhihu/griffith/issues/14
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #49 into master will increase coverage by <.01%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   52.98%   52.99%   +<.01%
==========================================
  Files         123      123
  Lines        1659     1672      +13
==========================================
+ Hits          879      886       +7
- Misses        780      786       +6

Impacted Files
Coverage Δ

packages/griffith-mp4/src/fmp4/boxes/moov.js
100% <ø> (ø)
:arrow_up:

packages/griffith-mp4/src/mse/controller.js
0% <0%> (ø)
:arrow_up:

packages/griffith-mp4/src/mp4/utils/findBox.js
100% <100%> (ø)
:arrow_up:

...s/griffith-mp4/src/mp4/utils/getSamplesInterval.js
95.08% <100%> (+0.16%)
:arrow_up:

packages/griffith-mp4/src/fmp4/fmp4Generator.js
100% <100%> (ø)
:arrow_up:

packages/griffith-mp4/src/mp4/boxes/elst.js
93.33% <66.66%> (-6.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9415b63...c4dd339. Read the comment docs.


Large display issue

On very large screens the blue doesn't go all the way:

Screen 2560x1600.

If you mean that it doesnt go all the way down, that is an intentional style I think?
You can change it in the CSS though

@drewdotpro the blue background is only supposed to be filled 50%. The login block needs to be aligned center vertically. Should be fixed now.

the login and register pages are now modified in the new version and do not have two different colors on the page so, closing this.


In wip it only colours one item not all.

https://github.com/lefthandedgoat/canopy/blob/master/src/canopy/canopy.fs#L107

Closed for no activity.


Relocate RoaringBitmap in shaded jar

This fixes compatibility with older spark versions like 3.0.1. We already had an exclusion for RoaringBitmap from spark dependency with this comment:

Druid library needs a newer version than what spark 3.0.1 brings

But we were missing to relocate it in the shaded jar.

👍