Compile error on BSD

When compiling mbed TLS (for Hiawatha webserver) on BSD, I get an error for the -Wlogical-op flag, as used in CMakeLists.txt at line 24.

Can you be a bit more specific? We regularly build on FreeBSD with cmake and GCC 4.8, as well as on Darwin with the latest version of GCC and didn't notice a problem so far.

I tested this on FreeBSD 9.0 and OpenBSD 5.5 (both in VirtualBox). For testing, please download https://www.hiawatha-webserver.org/files/hiawatha-9.14-beta.tar.gz. For compile instructions, see https://www.hiawatha-webserver.org/howto/compilation_and_installation.
The compile error I get is:

When I remove the -Wlogical-op flag, all compiles fine.

What's the compiler found by CMake and its version? I'd like to see this part of the cmake output:
-- The C compiler identification is GNU 4.8.3
-- Check for working C compiler: /usr/local/bin/gcc48
-- Check for working C compiler: /usr/local/bin/gcc48 -- works

According to the GCC 4.5 release notes, -Wlogical-op has been supported since at least GCC 4.5, and according to the OpenBSD 5.5 release notes, it includes GCC 4.6.4 and 4.8.2, so I'm a bit surprised here.
Overall, I think we'll want to check the GCC version in CMake to only include this warning for versions that support it, but for that we need to be sure which versions to exclude.

Both FreeBSD 9.0 and OpenBSD 5.5 have GCC 4.2.1.

This should be fixed by this commit: https://github.com/ARMmbed/mbedtls/commit/bcb0460224ee4651fa5ecf77b2c3a784e10616c4 However, I'd appreciate if you could confirm that the fix works for you.

This fixes my issue. Thanks!

Cool, thanks for testing (and reporting in the first place)!


Allow distinct Quest vs Experimental panel config

This changes the logic about which panels to show in experimental mode.
Previously "experimental" overrode "standalone vr" so desktop panels were shown on Quest etc when in experimental mode.
This adds another flag to the panel map and sets it so (currently) standalone headsets get the same panels as they do in non-experimental mode aside from showing the experimental panel itself.
Once #544 is merged we can add the camera path button to the Quest/standalone "extras" panel.
I also plan to get rid of the experimental panel and merge the bits we want to keep into other panels but this is a good interim step.

Please could we use a non-quest specific variable name?

It was a case of consistency vs accuracy. Existing vars are:
    public bool m_ModeVr;
    public bool m_ModeVrExperimental;
    public bool m_ModeQuest;

I didn't want to introduce a new convention for a minor PR.


Please add a -NoProgress switch for Update-DbaInstance

Hi everyone,
Can you please add a -NoProgress switch for Update-DbaInstance so I can run it in a Windows Scheduled task? See Import-DbaCsv that has this switch.
Thanks for the tip, @wsuhoey!
Mike Petrak

We don't control that via a switch in the command. You would control this at the session level for PowerShell using $ProgressPreference.
More information on this can be found in the docs: about_Preference_Variables

Thanks, @wsmelton . I was considering that too from https://thinkpowershell.com/hide-powershell-progress-bars/ .

There is one command that has -NoProgress via switch in our commands:
https://github.com/sqlcollaborative/dbatools/blob/development/functions/Import-DbaCsv.ps1
See lines 123-124 which shows the parameter in CBH.
See line 276 which identifies it as a switch.
See lines 618-625 which tells the code how to suppress it.
.PARAMETER NoProgress
The progress bar is pretty but can slow down imports. Use this parameter to quietly import.
...
[switch]$NoProgress,
...
                    # Add rowcount output
                    $bulkCopy.Add_SqlRowsCopied( {
                            $script:totalrows = $args[1].RowsCopied
                            if (-not $NoProgress) {
                                $timetaken = [math]::Round($elapsed.Elapsed.TotalSeconds, 2)
                                Write-ProgressHelper -StepNumber 1 -TotalSteps 2 -Activity "Importing from $file" -Message ([System.String]::Format("Progress: {0} rows in {2} seconds", $script:totalrows, $percent, $timetaken)) -ExcludePercent
                            }
                        })

Since the code in Update-DbaInstance does use Write-ProgressHelper, similar logic could be incorporated.

Whether the import command uses it or not is irrelevant, and that command will be fixed to remove the parameter as well.

I don't understand, why remove the parameter -NoProgress from Import-DbaCsv? @potatoqualitee added it to the command with the command's re-work. I don't understand why you are so against it?

Why add additional overhead for code testing and management when the proper mechanism for managing progress output is built into every version of PowerShell?

@mikepetrak confirmed that he was able to get Update-DbaInstance to work in a scheduled task by using $ProgressPreference. So I concede about both adding and removing the -NoProgress parameter.


Vickel: Watch mygs.store

Vickel requests the watch of the watch_keyword mygs\.store. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

mygs\.store has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


ERROR: knife encountered an unexpected error

I got
ERROR: knife encountered an unexpected error
This may be a bug in the 'ec2 server create' knife command or plugin
Please collect the output of this command with the -VV option before filing a bug report.
Exception: NoMethodError: undefined method `empty?' for nil:NilClass
log attached as
http://pastie.org/pastes/10703066/text?key=6i6mph7rsmfxaqqq6sv3gq

I also encountered this error when not specifying a run_list.  Providing a run_list seems to resolve the issue.  If you have no run_list to provide, a workaround currently appears to be to provide a blank run_list (e.g. knife ec2 server create [settings] -r '')

Hello,
I've came across that information yesterday and thought it would help you, read more here please http://githerdycra.anitaspottery.com/oivmpssb
Sincerely<EMAIL_ADDRESS>

This is a dupe of https://github.com/chef/knife-ec2/issues/370, which is fixed in knife-ec2 0.13.0, released on 8/8/16.


Chore: Add a spacing a test

Since I did officially find out the root cause of the issue, this should ensure the problem never comes back unnoticed.

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)
[X] If applicable, I’ve added docs and tests

Description of changes
This is to formally check for #10. Even though it has been resolved, I believe double checking for old issues is extremely important.

I believe double checking for old issues is extremely important.

I agree with you! But, this was an issue somewhere else. It was fixed and tested somewhere else: https://github.com/wooorm/parse-latin/commit/ebf6961ab3b961699c498e9416169b5e4d698e27.
Thanks though :)


Movies DB ReactApp

Prerequisites

[X] I am a GSSoC-22 Participant
[X] I checked to make sure that this issue has not already been filed

Description
Want to Add Movies DB ReactApp. An Application where you can see every favourite movies
Tech Stack
React

@abhijeet007rocks8 Please Assign this task to me

@manisha-27 please assign this task to me


Rubidium[Addition]

Checklist

[X] I've checked that my mod suggestion hasn't already been added to one of the lists.
[X] I've checked the latest issues to make sure that this mod hasn't already been suggested.

What is your mod's name?
Rubidium
What is your mod's main version?
1.18.X (Forge)
Input a link to your suggested mod. Make sure it isn't hosted on a site listed on StopModReposts.
https://www.curseforge.com/minecraft/mc-mods/rubidium
What is your reasoning for including this mod?
Forge port of sodium thats actually being maintained, unlike magnesium
also magnesium doesnt work on 1.18.1
(OPTIONAL) Give some extra information about the mod.
No response

Magnesium has 1.18 builds listed.


Operation Profiler

This is an idea prompted by some stuff done by @itsthejb in his fork.
The aim is to provide a way to extract performance metrics from Operation instances in a way which is amenable to feeding into analytics and tooling. The purpose for this might be to provide end-to-end integration metrics or for full system diagnostics, or even just to set some idea of the performance of a particular Operation.
Now, I hasten to add, that there is a strong argument that shipping apps should not include any kind of performance metrics code. The flip side of the coin, especially if you have an app which is getting 10k-100k or more DAUs is that it is very tricky to diagnose performance problems across all of your user's environments. From different devices, to networks, carriers and countless others. The reality is that performance tests in your unit test bundle will not help diagnose or report the real world performance of your application.
So, here is the idea. We have OperationProfiler which itself is just an OperationObserverType. It's job is simply to record the timing split between all the events the Operation encounters, so it's a little bit like the deprecated OperationLogger.
However, it will be initialized (or is type constrained) so that when the operation finishes, it will report the metrics to a logger. For example, the profiling could just be sent onto the console. More likely however, framework consumers would have their own logger for this information, to e.g. store it and then send it into their analytics systems. The framework will not provide these, just the profiler, and a specialized logger.

I like the sound of plugging into metrics, but I get what you about profiling in the wild. Still, will be great to get a convenient idea of the relative demand of various operations

Things to consider... currently the profiler has the lifespan of an Observer - it is attached to the Operation. Therefore, if the operation produces another Operation, the profiler needs to produce another profiler, yet, it cannot own or in anyway retain it.
Therefore, each profiler, will need to have it's own unique identifier which gets generated when created. If the attached operation produces another operation, that should get logged in the metrics as a event, with a reference to the produced profiler's identifier.
More than likely, in addition to profilers & reporters we will actually want to have a ProfileManager which will collect the profilers to correctly tie together produced and/or group operations.

So, if an operation, which is being profiled produces another operation using produceOperation. This now also gets profiled. This works as a sort of daisy chain, where the child profiler, actually must hold onto its parent profiler (which acts as its reporter). This way, the first operation can finish (and get deallocated) before the produced operation finishes. In which case, the first profiler (or parent) would be deallocated (as it's owned by the operation instance). However, because the child/spawned operation is running, with its own profiler, which owns the first profiler, it doesn't get deallocated until all the operations finish.
So, when this finally reports at the first profiler, it looks like this:
The log output for this looks a bit like this:
One #0AED6596-5998-4716-B8D2-CD2F67937489: finished with perfomance metrics:
+0.000547945499420166 Attached
+0.00269895792007446 Started
+0.00420397520065308 Produced Two #EFB859E8-AA35-4C78-AD2F-DB44EF7FA65D
  +2.30073928833008e-05 Attached
  +0.000799000263214111 Started
  +0.00531101226806641 Produced Three #E88AFB71-7F48-4854-A952-3B26E24F143E
    +2.10404396057129e-05 Attached
    +0.000181019306182861 Started
    +0.326790034770966 Finished
  +0.298131048679352 Finished
+0.192564964294434 Finished

The above scenario is with the first operation One which finishes after 0.1 seconds, produces a 2nd operation, Two which finishes after 0.2 seconds, which produces a 3rd operation, Three which finishes after 0.3 seconds.
So, looking at the log, you can see the nested timings of each operation as it moves through its states.
Still to work on:

[ ] Unit tests
[ ] Special handling for GroupOperation.

@itsthejb - thoughts?

Coverage increased (+0.8%) to 74.366% when pulling c3eff5cd9c0a01c1ebe85ab34e51af3b156e4c02 on feature/OPR-235_profiler into 3c0faa7becb7c90694e191a52cbbbc5d31aef369 on development.

Coverage decreased (-3.8%) to 69.783% when pulling 9a39e3ccacbbd43d650b65ff0c58b978c1468eed on feature/OPR-235_profiler into 3c0faa7becb7c90694e191a52cbbbc5d31aef369 on development.

Coverage decreased (-3.3%) to 70.29% when pulling af3f51b5f4539f6d5161059b6cdcf14f6d78272d on feature/OPR-235_profiler into 3c0faa7becb7c90694e191a52cbbbc5d31aef369 on development.

Well this certainly looks great! Glad to have given some inspiration! Can't contribute much more right now, but I'll definitely be keen to try it out at a later date. :+1:

Coverage decreased (-3.3%) to 70.474% when pulling 094cada977cab8a723a549bffd8ea6c29141ada0 on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage decreased (-2.8%) to 70.95% when pulling dc4f41838dc8b849140060b043263b35935498cf on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage decreased (-0.8%) to 72.923% when pulling 669c148a34c723243197746d586c5855e104a2ef on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage increased (+0.4%) to 74.145% when pulling dbcc9f8b864c6b60c2eff92f03b8da9225bbd48e on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage decreased (-40.9%) to 32.843% when pulling c767a3837e0f805de960a85d5f36cd6729322af6 on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage increased (+0.6%) to 74.305% when pulling c767a3837e0f805de960a85d5f36cd6729322af6 on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.

Coverage increased (+1.2%) to 74.907% when pulling 6217ee89d2fb4818ce589d74f23e3ef543fdd0bc on feature/OPR-235_profiler into d98983a905cf2c92a7e4e542de1446a08188f1e1 on development.


fix locking of socket pool

Current implementation doesn't behave as expected. Could have
Thread 1 : call Get()
Thread 2: call Get()
Thread 1: ReadLock. Sees p.pool[id] is empty. ReadUnlock
Thread 2: ReadLock. Sees p.pool[id] is empty. ReadUnlock
Thread 1: Lock. Assigns to p.pool[id]. Unlock
Thread 2: Lock. Assigns to p.pool[id]. Unlock
Adding double checked locking removes the possibility of overwriting.

looks fine


Azure Functions + .NET 6

Hello! Based on this documentation:

The Azure Functions app must either be in Node.js 12, .NET Core 3.1, or Python 3.8.

I am aware that Azure Functions 4.0 is in Preview and it supports .NET 6. Do you know if Static Web Apps will support Azure Functions 4.0 (and thus .NET 6) when .NET 6 is released on November 9th?
Thank you!

You can now deploy .NET 6 function apps (in-process or isolated) to Azure Static Web Apps! See blog post for more information.


[RFC][LSP] Pluggable schema loading

Hi all,
Here at FB we have some schema extensions that live in a separate file and are applied during the build. While this is not particularly relevant for GraphiQL, we really want to have this as part of the LSP. Therefore I propose the following:

In the configuration of the LSP (.graphqlrc), the user can specify the following:

(required) a package that provides two functions: async init() and async getSchema(). The latter returns the latest GraphQLSchema. Hopefully this can work in a similar way to babel plugins or webpack loaders.
(optional) arguments that are provided to the init function, before the getSchema function is called for the first time.
(optional) a glob relative to the .graphqlrc that triggers the schema to be reloaded on file change.

With this, I believe we can provide a very flexible schema loading experience. The first schema loaders we implement should probably be: a file schema loader to provide the current LSP experience and an introspection query schema loader to make it work with GraphiQL.

I love the sound of all of this. Moving the introspection query schema loader down to the LSP sounds excellent, and is similar to how vscode-json-languageservice loads JSONSchema definitions in a pluggable fashion.

Also, I wouldn't rule out alternative schema loading patterns, even alternative protocols being more readily supported for graphiql-1.0.0-alpha. for example, using wss to locally (or over the wire?) transmit json-rpc from a language server.
https://github.com/TypeFox/monaco-languageclient/blob/master/example/src/client.ts

The interface that the typescript language service uses for adding LSP plugins is interesting, and is designed to work in browsers, vscode, monaco, etc
https://github.com/microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin
We could do something similar with -interface, or possibly a layer on top of it designed for greater parity with existing vscode--languageservice implementations

@Neitsch there are two ways we can go about this for graphiql - we can do something provisional, where GraphiQL has a prop for this and we can do that very soon, but then we would have to migrate to the new monaco implementation, ideally keeping parity from the GraphiQL side of things. the other would be of course just waiting for the new monaco implementation, which means defining the loader in the LS itself, as with monaco-vscode.

we have a way to do this with graphql-config@3 now, using commonjs for sync operations at least. that said, its very flexible, and by specifying a URL with a .graphql extension it will just do a get instead of an introspection request. with a remote .json extension it will detect whether its document node or introspection.
if you still find that schema loader restrictive, we are thinking of rolling our own schema loader. the language server also allows specifying custom extensions for, amongst other things, overriding the schema loaders

we have a way to do this with graphql-config@3 now, using commonjs for sync operations at least. that said, its very flexible, and by specifying a URL with a .graphql extension it will just do a get instead of an introspection request. with a remote .json extension it will detect whether its document node or introspection.
if you still find that schema loader restrictive, we are thinking of rolling our own schema loader. the language server also allows specifying custom extensions for, amongst other things, overriding the schema loaders


Releasing Ctrl when Ctrl-N in Quick Open no longer works

@ithinkihaveacat says

I think #7316 caused a regression from 1.3.
In 1.3, with ctrl+n bound to workbench.action.quickOpenNavigateNext, then in Quick Open, holding down ctrl and then tapping n moved the selection down a line (as it does now). However, after releasing ctrl, the selected file was automatically opened, eliminating the need to press the return key.
It took a few goes to get used to this behavior, but eventually I found it preferable. It doesn't work anymore in 1.4. If this change was intentional, is there a way to get the old behavior back?

@joaomoreno the issue is in https://github.com/Microsoft/vscode/blob/master/src/vs/base/parts/quickopen/browser/quickOpenWidget.ts#L159 you are changing the actual key that was pressed and this will result in the event getting canceled in https://github.com/Microsoft/vscode/blob/master/src/vs/base/parts/quickopen/browser/quickOpenWidget.ts#L174 and thus it will never reach the keybinding service.
I am not sure how to get this working again, I find the current code in quick open widget weird because the tree is not even focussed and we still support Ctrl+N and Ctrl+P. I would rather maybe introduce real commands that are active when quick open is visible (we already have this key) and do the navigation in quick open (we could add methods for that).
Moving back to you.

I ended up reverting the changes from #7316 related to quick open.


mongodb-compass-community.rb

After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

This is the same as https://github.com/caskroom/homebrew-cask/pull/46104


Update Docs

[x] Update Docs

@hienerd and I can work on updating the docs

We currently have an issue with readthedocs where the other pages are not being linked

Yeah I saw this I have a fix I haven't pushed but Ill make a PR tonight

Hey, I think the contributing page needs to be updated since the precommit hooks have been removed. I'm just pointing this out here rather then submitting another issue because it is another piece of documentation.

Thanks this reminded me about the docs PR.. things got a bit crazy since this post. I'll address them both at once.

Done


Only enable jit_release on Android debug shard

Since the value defaults to True, it was being built on all shards

Do I need to do anything to publish this, or does it get picked up automagically?

Magically - follow along at https://luci-config.appspot.com/#/projects/flutter
The change hasn't replicated yet to GoB though


promise: Replace go routine with context.AfterFunc

Drive-by cleanup to remove a unnecessary Go routine and instead use context.AfterFunc to wake up the cond var when the context is cancelled.

/test

Need to look into EKS, the failure looks legitimate


Rename bichard and remote-supervision environments

User Story
These were set up in the early days and have hyphens in the environment names, this causes issues in some of our automation which looks for -environment and we have to add exceptions for them.  We should rename these and introduce validation for environment names, then remove any workarounds we have in code.
Problem environments
bichard7:
dev-current
dev-next
test-current
test-next
sandbox-a
sandbox-b
sandbox-c
sandbox-shared
remote-supervision:
non-production
Value
Consistency in environment names and no workarounds in code
Questions / Assumptions

Definition of done

[ ] change the environment names
[ ] add validation for environment names
[ ] remove any code hacks / workarounds
[ ] readme has been updated
[ ] user docs have been updated
[ ] another team member has reviewed
[ ] tests are green

Reference
How to write good user stories

Closing, we will not do this, these accounts will be eventually closed and moved to the main platform


⚠ Bofrost.be has degraded performance

In 1bcd945, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 870 ms

Resolved: Bofrost.be performance has improved in 2ef4454.


Add methods to read out axis values on device

There is currently no way to read out the axis values on a device.
auto/device.rs has a method stub for fn get_axis(&self, axes: &[f64], use_: AxisUse) -> Option<f64>, which it is commented out and the field GdkDevice.axes is not accessible.

This is implemented since a while


[WFLY-13386] Hung process instances and associated server.log WARN "Failed to reinstate timer"

upstream
https://issues.redhat.com/browse/WFLY-13386

@chengfang or @tadamski Please review

added some comments for clarification.

retest this please

Customer still found another problem. I will throw another PR for this.


Are the compatibility settings for certificate templates in the object returned by Get-CertificateTemplate?

Is the Private Key Flag (msPKI-Private-Key-Flag) attribute available in the object returned by the Get-CertificateTemplate cmdlet in the PSPKI module?

What I'm aiming to understand is the process of reconstructing a certificate template's original configuration using the object returned by the Get-CertificateTemplate cmdlet. Specifically, I'm interested in identifying the necessary attributes that would allow me to determine the original settings through a Bitwise OR operation. Could you provide some insights or guidance on which attributes are crucial for this task and how they might be used to achieve the desired outcome?

You may need to reverse the DS attribute decomposition back from properties to DS attributes.

Thank you for your guidance on reversing the DS attribute decomposition from properties back to DS attributes. To follow up on that, I'm trying to understand how to extract and reconstruct the original values of specific flags, such as the msPKI-Private-Key-Flag, from the output of the Get-CertificateTemplate cmdlet.
For example, the msPKI-Private-Key-Flag for a template is set to 101056768, which encompasses various flags like TEMPLATE_CLIENT_VER_THRESHOLD, TEMPLATE_SERVER_VER_THRESHOLD, CTPRIVATEKEY_FLAG_USE_LEGACY_PROVIDER, and CTPRIVATEKEY_FLAG_ATTEST_NONE.
Could you advise on how to interpret the cmdlet's output, to derive these flag values? Are there specific attributes in the cmdlet's output that correspond to these flags, and if so, how can they be used to reconstruct the original msPKI-Private-Key-Flag value?


List server extension on clean script make install

Currently we only list notebook server extensions, we should also list jupyter server extensions since elyra is one now
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Does the command need to be also added to https://elyra.readthedocs.io/en/latest/getting_started/installation.html#verify-installation  and https://github.com/elyra-ai/elyra#verify-installation?

@ptitzler yes, I forgot to check for the line in doc files. Do you mind making that update, my branch is in the middle of other work


Dashboard: Alert UI Component

Summary
Adds Alert component to UI, modeled from: https://material-ui.com/components/alert/#filled

Relevant Technical Choices

Opted to have alert/index return an object with the elements necessary to build a toast system of alerts since that's what this is for - so that's why we have a Wrapper and a Container instead of just an Alert. I
Container can be used outside of a wrapper should a need arise.

To-do
(Separate PRs, this was getting big)

Wire the UI up to a new context hook for a toast view that is on all dashboard views
Finish connecting errors in reducers for templates and stories
Get icons to make it clearer what severity levels alerts are (for now we're focusing on errors and Sam is super busy so I decided to wait on including icons)

User-facing changes
None
Testing Instructions
Go to storybook Dashboard/Components/Alert

Addresses #2262

This looks good. Is there ever an instance where we might want this to self-dismiss after x seconds? Perhaps it's not needed now, but I wonder if displaying the close button should be a prop.

i like the idea of making the close button a prop! I'll go ahead and make that a thing in the next pr if that's ok with you?
Self dismiss is incoming with the context hook for toasting alerts.


Added iOS Pose Landmarker to CocoaPods build

@schmidt-sebastian Could you take a look at this PR ?

Is Pose Landmarker fully available for iOS? Will there be an example of how to set it up eventually? Thank you.

Yes - it is available. We don't have an example yet but will add one soon.

I don't see any files related to pose landmarker in the MediaPipeTasksVision pod library.
Is it possible for me to build up a xcode project with pose landmarker currently?


respect pip configuration at Pipfile creation

Respect pip index configuration (pip.conf or environment variable) when
creating a new Pipfile.
I'm really not sure about this implementation but I wanted to start the conversation, I've made some choices that I think have a minimal impact.
I couldn't find a convenient method in the pip project that would just hand me out the best option and respect the configuration precedence so I implemented it by hand.
Change mentioned in #856

I feel like I should add some tests here

Hey @hrbonz thanks for putting this together. Unfortunately altering which source is added to the Pipfile doesn’t quite respect pip.conf because of the way pip already generates its repository index list (which already should respect pip.conf) and because of the way the piptools resolver works (which isn’t affected by the Pipfile).

@techalchemy unfotunately, pip.conf is not respected because of the configuration precedence and the use of sources as indexes on the command line with -i/--index-url or --extra-index-url.
That is the base of the issue I described in #856

@hrbonz I see what you're saying, but I'm not actually sure this is the right approach here.  It's not clear that we actually want to always fall back to the default indexes in the host pip config, since I'm not sure that provides sufficient portability.  I do think we would want to respect environment settings, however, but I think there is some discussion to have here (e.g. in #988 this came up)
We have broader design questions to answer but for now, I would be much more prepared to accept something that prioritizes environment level settings (e.g. PIP_INDEX_URL followed by an iterative list over PIP_EXTRA_INDEX_URL) -- this approach will probably need to take into account verify_ssl from the PIP_TRUSTED_HOST environment variable

And before you rework, /cc @nateprewitt would you be willing to approve a PR to use PIP_INDEX_URL from the environment if it exists as the primary pip index (i.e. first entry in [[sources]] in the Pipfile?  This seems like something that might impact existing users so I would want a second set of eyes on it

We should honor the environment variable instead.

not today, but thank you

There must be something I don't get, why force users to set an environment variable when there is already a configuration for a standard tool that gives you this information? This is, moreover, the tool you use under the hood.
Environment variables are useful in some situations but really not ideal most of the time.


Setting pixels to transparent

Is there a possibility to remove all pixeldata from an image and set them to transparent?
For Example we have an image with the dimensions 200x200 and I want to remove all pixels of the top left corner and set them to transparent.
The draw method doesn't work:
$image->rectangle(0, 0, 100, 100, function ($draw) { $draw->background([0,0,0,0]); });
Neither does the fill method:
$image->fill([0,0,0,0], 100, 100);

This is currently not possible. All colors applied to the image are calculated on all color channels relative to the existing values. Unfortunately, it is currently not possible to change a color channel directly.
The only way I can see is to use the mask() function of version 2 if Intervention Image and apply the alpha channel information to the image.


[refactoring] angular cli migration

Angular Cli alleviates the pain of manual webpack configuration, in addition to providing support for AOT compilation, lazy loading modules, ng generate support for creating Angular objects, and well you'll just have to check out the code and the docs to learn everything!
To test

rm -rf node_modules/
npm install
npm start

And navigate to localhost:4200 and confirm the site loads! I am currently trying to hack the images to work again, and testing to make sure no functionality has been lost.
Once this is merged, I will work on tests: configuring and fixing.
Please ask questions or offer comments.

Images are actually tightly coupled with the backend migration..


Incorrect connection string

The section that displays the JSON on how to use sql server authentication is incorrect. The below connection string does not work using ARM templates.
{
"name": "AzureSqlDbLinkedService",
"properties": {
"type": "AzureSqlDatabase",
"typeProperties": {
"connectionString": "Server=tcp:< servername >.database.windows.net,1433;Database=< databasename >;User ID=< username >@< servername >;Password=< password >;Trusted_Connection=False;Encrypt=True;Connection Timeout=30"
},
"connectVia": {
"referenceName": "< name of Integration Runtime >",
"type": "IntegrationRuntimeReference"
}
}
}
The below connectionString works:
"connectionString": "Data Source=tcp:< servername >.database.windows.net,1433;Initial Catalog=< databasename >;User ID=< username >@< servername >;Password=< password >;Trusted_Connection=False;Encrypt=True;Connection Timeout=30"
Server should be replaced with "Data Source"
Database should be replaced with "Initial Catalog"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 09dd1d03-ae28-c5a2-7c64-2f51675f6b09
Version Independent ID: dac74d68-2105-a029-1f49-d444c0a252f4
Content: Copy and transform data in Azure SQL Database - Azure Data Factory
Content Source: articles/data-factory/connector-azure-sql-database.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@jessedavidsmit
Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.

@jessedavidsmit The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.
Thank you!


Performance unclear

We should make sure that the library is sufficiently efficient for day-to-day use. I'm not sure how to evaluate this. Do the regular graphics 2D and 3D benchmarks (such as gtkperf, perhaps glxgears) give any useful information?

weston-simple-dmabuf-v4l and weston-simple-egl run smoothly, so there is probably no immediate cause for concern.


add stdoutEncoding option

Added control over stdout encoding for spawned process

@danunafig why commenting your testmethod ? ^^

@danunafig why commenting your testmethod ? ^^

fixed

a typo remaining ^^

Codecov Report
Base: 86.54% // Head: 86.66% // Increases project coverage by +0.11% :tada:

Coverage data is based on head (54000b6) compared to base (ed9d717).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   86.54%   86.66%   +0.11%
==========================================
  Files           3        3
  Lines         223      225       +2
==========================================
+ Hits          193      195       +2
  Misses         30       30

Impacted Files
Coverage Δ

lib/java-caller.js
85.43% <100.00%> (+0.14%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Audit log links don't work and UI is missing the previously exists "selected line" indication

Environment info

NooBaa Version: 5.2.0-d6fd801
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

Audit log links don't work

Expected behavior

links in the entity columns should link to the entity and links to accounts were not required

Steps to reproduce

See audit log

More information - Screenshots / Logs / Other output

@nb-ohad @nimrod-becker Not a blocker but it's still missing the "selected line" indication. (If the user clicks on the log entry line and the description is shown, we used to show which line is selected as well by highlighting it with a different color)


[BUG] ZAP bootstrap is failing due to old version of Node in PW.

Reproduction steps
1. Clone connectedhomeip on macOS
2. source ./scripts/activate.sh
3. ./scripts/tools/zap/zap_bootstrap.sh
...

Bug prevalence
Whenever I do this
GitHub hash of the SDK that was being used
bd5956dc76adca4285c5380462ad249501a3b6d8
Platform
darwin
Platform Version(s)
No response
Anything else?
NodeJs in PW is obsolete and needs to be updated since October 4th.
2022-10-19T16_33_50_481Z-debug-0.log

@krypton36 - what does which node and which npm say before/after each step? I don't think pigweed has anything to do with node in general (it handles python and c++ as far as I am aware)

which node:
/Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/node
which npm:
/Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/npm

± /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/node --version
v18.4.0
± /Users/Josh_MacPro/Documents/MatterRepos/connectedhomeip/.environment/cipd/packages/pigweed/bin/npm --version
8.12.1
○ /usr/local/bin/node --version
v16.18.0

Temporary Workaround: Run scripts/tools/zap/zap_bootstrap.sh outside of source ./scripts/activate.sh environment. Then, during ZAP code gen use system env and switch to compile.

Having a side conversation with pigweed about handling optionality in things.
Now that I went down this rabbit hole, it seems we bring in other things like cmake and doxygen (both of which we install in our images anyway and generally do not use).
It seems that if we get things optional, we may be able to speed up bootstrap, which would be a nice win.


crash on fluxux

its crashing on uwp version of roblox

Error in Fluxus console?
Try reinstalling roblox and fluxus if it persists

Error in Fluxus console? Try reinstalling roblox and fluxus if it persists

nope, it's just the window turns white and crashes after a few seconds


Fix MSI upgrade and shortcut issues

Fixes #11995 and fixes #12011 based on changes described in https://github.com/PowerShell/PowerShell/issues/12011#issuecomment-596105112.

@heaths Please look CI fail.

@heaths take a look at https://dev.azure.com/powershell/PowerShell/_build/results?buildId=53706&view=logs&j=1057fe42-c88b-5deb-88ad-59245c714665&t=1888043b-254d-5761-80ec-47d0d8adc59a, the test detected some file changes, if this is expected, just follow the instructions in the output

I updated the wxs for you and filed:  https://github.com/PowerShell/PowerShell/issues/12799

@TravisEz13, thanks. I was going to get to this tonight.
Were these actually removed, though? I'm not clear on whether their presence or not is actually a bug. They aren't needed except for ARPPRODUCTICON which must reference a row in the Icon table but, unless you're advertising your product (almost no one does that anymore - Office stopped over a decade ago), shouldn't be used for shortcuts.

Were these actually removed, though?

I wonder too how WiX works - wxs file still contains references to the icons.

@iSazonov, what exactly do you mean? As a long-time developer on WiX (I designed and implemented many features in it, most notably package ref-counting that other installers use as well), I could probably explain if you can clarify what you meant.
When the <Icon> is used, the binding (during linking, which is light.exe) knows to stream in a file reference; otherwise, when just a normal <File> is process the binder puts it in a cabinet that is later left external or streamed into the MSI based on <Media> entries (<MediaTemplate> provides default behavior and is often easier for most packages).
My main change here was to remove most GUIDs. They aren't needed, except for the UpgradeCode property (you normally want that fixed) and shared components without a single key path resource. In fact, just being a shared component - if it always resolves to the same key path - will get the same GUID. This change is mainly about letting WiX create a durable GUID based on the key path at build time, which is far more reliable and easier than people having to maintain it, which wasn't being done here and the main problem with files and registry values not getting cleaned up (they were ref-counted). See https://heaths.dev/setup/2020/05/13/simple-wix-project.html for more explanation and links to many of my old blog posts on what is now the VS Setup team blog (used to be my professional blog - which I used mostly for team purposes - up until a year or so ago).

what exactly do you mean?

I mean @TravisEz13 's commit and your question "Were these actually removed, though?".

Last I updated the file via git rebase they were still there.

Yes, they are on file system. My concern is that it seems wxs file contains references to the files.

They shouldn't anymore. It's possible when I generated my repo wasn't entirely clean. It was a bit behind before I rebased on upstream/master this past weekend since I've been swamped with work stuff.

@heaths

Were these actually removed, though? I'm not clear on whether their presence or not is actually a bug.

in CI we generate multiple packages at at time.  There is probably a bug where one of the package generations deletes the icons.  There is code in the packaging to create a staging folder.  We need to make sure all types of packages that add/or remove files from the build use a staging directory.
I filed a bug to investigate.

I updated the wxs for you and filed: #12799

https://github.com/PowerShell/PowerShell/issues/12799 was an existing bug.   We can merge this PR.

Thanks. If I can find time, there's some more clean-up I'd like to do (you can do almost everything in the .wxs itself, which makes it easier to maintain since it's not spread all over), but wasn't necessary for now. I also recommend passing parameters instead of setting environment variables, as the scope is smaller (though, at least you scope them to the current and child processes).

@heaths Thanks for great contribution!

Thanks for your contribution


Built-in "sls" alias for Select-String has nonstandard name, should be "scs"

From the quibbles department:
According to Approved Verbs for PowerShell Commands, the official alias prefix for Select-* cmdlets is sc, not sl (the latter is for Split-* cmdlets).
Therefore, the naming-convention-compliant alias for Select-String should be scs, not sls.
It's probably too late to remove sls, but we could add scs.
Either way, a note in the documentation would be helpful.
Environment data
PowerShell Core v6.0.0

The documentation link is now dead, this looks like the new location: https://docs.microsoft.com/en-us/powershell/developer/cmdlet/approved-verbs-for-windows-powershell-commands

Thanks, @HumanEquivalentUnit  - I've updated the OP.

@mklement0 you're right this is too late to change, but agree the docs should be updated for this exception.  cc @sdwheeler


chore(admission) remove GWAPI types from webhook

What this PR does / why we need it:
Remove GWAPI types from the webhook. We plan to remove these in the controller (https://github.com/Kong/kubernetes-ingress-controller/issues/5197) and there's no clear need to continue using them. Since they currently cause a version compatibility issue (https://github.com/Kong/charts/pull/954) I'd like to just remove them preemptively. KIC hasn't changed yet, but those changes aren't a hard prereq to removing the webhook config.
Held pending confirmation that we don't need these.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

For HTTPRoute regexes are validated with webhook see

https://github.com/Kong/kubernetes-ingress-controller/pull/4608

Forgot to close this after merging #954.


Let's add a new function

Hello Ivan!
Let's add a new function.
Here's the thing. I needed my web interface to be set to display in another language. More specifically when I did dnd I needed to localize the strings like '2 nodes', '3 nodes' etc. I know about the core.strings option but the thing is that you use the 'get_string' function passing the string only. For me it's not enough since in my native language I need to know the number also that goes before the string. So I needed a function which would take 2 parameters like '3' & 'nodes' for example.
Therefore I added the function 'get_noun_form' and the option 'noun_forms' to let a programmer change forms of nouns depending on the number that goes before the noun.
Thank you for such a great library!

Looks great - thank you. But at this time I will not add new functionality in v.3 I will keep this in mind for v.4 though. Thank you again.

How do I solve my problem then? I mean I need the web interface to be in my native language but jsTree can't do this. I've changed the code myself but how do I update now? Thank you.

You could update your fork, or you could do this:
https://jsfiddle.net/6wkymtfn/


After building packages, trigger CI to install and test

Currently, packages are built on travis/linux, then tested in various ways/environments, then uploaded to pyviz/label/dev and testpypi (for dev packages) and pyviz/label/main and pypi (for release packages).
Because we're using universal wheel/python:noarch, all platforms install the same packages. After building the packages on travis/linux, we should trigger travis/mac and appveyor/win to test the built packages (i.e. the packages users will be installing). (An alternative is travis/mac and appveyor/win building and testing the packages themselves - but then they wouldn't be testing the packages actually installed by users.)
Packages built on travis/linux could be stored on s3 and fully tested before ever uploading to pypi/anaconda.org, but it's probably simpler just to upload to pyviz/label/dev and testpypi, and learn that the packages are bad after that's happened. The same process could be used for releases, because a release should be "guaranteed to work" if it's just re-building the same commit that's already been through the dev packaging/testing (with a release tag rather than a dev tag this time).
This is separate from having appveyor/win and travis/mac test "develop install" - they can separately do that or not, depending what's best for a project.

Sounds reasonable.


TransMix for CIFAR10

Dear @kevin-ssy
How we can utilize TransMix for CIFAR-10 dataset? I have to conduct some experiments on CIFAR-10 dataset

We did not test on CIFAR-10 but if you want to then you should first follow the instructions of timm to run Vision Transformer on CIFAR-10.
Then you can apply TransMix on top of the baseline there.

Thanks @kevin-ssy  Are sure deit_small_patch16_224_return_attn exist in timm models? I have seen deit_small_patch16_224 in timm models


Build fails: error: cast from pointer to smaller type 'unsigned int' loses information

clang-60 on FreeBSD defines NULL as nullptr, based on the C++ standard, see https://en.cppreference.com/w/cpp/types/NULL. The build fails:
/usr/ports/devel/renderdoc/work/renderdoc-1.2/renderdoc/driver/vulkan/vk_resources.h:1007:20: error: cast from pointer to smaller type 'unsigned int' loses information
    NullResource = (unsigned int)NULL
                   ^~~~~~~~~~~~~~~~~~

The use of NULL was a holdover from D3D anyway, it should have been VK_NULL_HANDLE which is just defined to 0 which works fine in an enum.


Add JS validator

Please, can you create test rails app to see how it works? Can you also add info to README how to use it?
Thank you :thumbsup:


Multithreaded download for rclone

Rclone has all the parts for doing multithreaded downloads - every remote can read a chunk out of the middle of a file.
It would be a great idea if operations.Copy could optionally do multipart downloads.
In order to fit in the streaming architecture of rclone the destination remote would have to support uploading a file in parts.
This could possibly co-ordinate with the multipart upload of existing remotes

make a Multipart upload interface
this could return an object to control the upload, give info about the chunks, etc
it would need to be able to support uploads in parallel

This might be an opportunity for the multipart uploads to be co-ordinated at a higher level also.
This could be supported by the local remote and any which supported out of order multipart uploads.
Any upload which was going to be multipart could use multipart download (if capable of out of order?  or maybe have an in-order mode).
This would also help with #87

Somewhat similar to how there's workers grabbing chunks for the cache simultaneously?

@ncw We recently came up with an issue where we tried downloading a large file(700 GB+) from S3 locally and it would time out. Supporting multi thread downloads would be a great feature add. Is it something that is planned soon?

@ncw Just to follow up, I see it is planned for v1.48? Do we think we will get it done by v1.48? Also if I want to contribute, do you think we can start with support for S3 and then expand to other services or do you think we need to have a generic solution which supports all the providers?

OK I had a good think about this and decided that we can only sensibly make this work for the local backend for the moment which makes the implementation easier.
Here is a test to try:
https://beta.rclone.org/branch/v1.47.0-024-g770c9624-fix-2252-multipart-download-beta/ (uploaded in 15-30 mins)
This has two flags to control it
  --multi-thread-cutoff SizeSuffix   Use multi-thread downloads for files above this size. (default 100M)
  --multi-thread-streams int         Max number of streams to use for multi-thread downloads. (default 4)

rclone will use more threads the more multiples of the --multi-thread-cutoff the file size is, up to --multi-thread-streams
So questions I'd like some input on

does it work?
is the interface OK (the two command line variables)
what should the defaults be?

if you use -vv you'll see debugging for the multithreaded downloads which will look like this
rclone copyto 10M 10M.copy -vv --bwlimit 1M -P --multi-thread-cutoff 1M --multi-thread-streams 4
2019/04/24 20:46:24 DEBUG : rclone: Version "v1.47.0-DEV" starting with parameters ["rclone" "copyto" "10M" "10M.copy" "-vv" "--bwlimit" "1M" "-P" "--multi-thread-cutoff" "1M" "--multi-thread-streams" "4"]
2019/04/24 20:46:24 DEBUG : Using config file from "/home/ncw/.rclone.conf"
2019/04/24 20:46:24 INFO  : Starting bandwidth limiter at 1MBytes/s
2019-04-24 20:46:24 DEBUG : 10M: Couldn't find file - need to transfer
2019-04-24 20:46:24 DEBUG : 10M: Starting multi-thread copy with 4 parts of size 2.500M
2019-04-24 20:46:24 DEBUG : 10M: multi-thread copy: stream 4/4 (8060928-10485766) size 2.313M starting
2019-04-24 20:46:24 DEBUG : 10M: multi-thread copy: stream 2/4 (2686976-5373952) size 2.562M starting
2019-04-24 20:46:24 DEBUG : 10M: multi-thread copy: stream 1/4 (0-2686976) size 2.562M starting
2019-04-24 20:46:24 DEBUG : 10M: multi-thread copy: stream 3/4 (5373952-8060928) size 2.562M starting
2019-04-24 20:46:34 DEBUG : 10M: multi-thread copy: stream 4/4 (8060928-10485766) size 2.313M finished
2019-04-24 20:46:34 DEBUG : 10M: multi-thread copy: stream 3/4 (5373952-8060928) size 2.562M finished
2019-04-24 20:46:34 DEBUG : 10M: multi-thread copy: stream 2/4 (2686976-5373952) size 2.562M finished
2019-04-24 20:46:34 DEBUG : 10M: multi-thread copy: stream 1/4 (0-2686976) size 2.562M finished
2019-04-24 20:46:34 DEBUG : 10M: Finished multi-thread copy with 4 parts of size 2.500M
2019-04-24 20:46:35 INFO  : 10M: Multi-thread Copied (new)

does this also work with mount?

Hello @ncw,

Here is a test to try:
https://beta.rclone.org/branch/v1.47.0-024-g770c9624-fix-2252-multipart-download-beta/ (uploaded in 15-30 mins)

The above link is returning error 404... so either your 15-30 mins got stretched quite a bit, or something is wrong ;-)
Cheers,
-- Durval.

Ah, that one failed the tests...
Here is a new one
https://beta.rclone.org/branch/v1.47.0-028-g1de11062-fix-2252-multipart-download-beta/ (uploaded in 15-30 mins)
Cross fingers!

Just tested it, and it's working great here! full(er) report at https://forum.rclone.org/t/multi-threaded-downloads-comments-and-testers-needed/9721/24?u=durval

@ncw, one question: I tested it with a single-file download from an SFTP remote, but it seems to have simply ignored --multi-thread-cutoff=1 --multi-thread-streams=4 and proceeded to copy the file in the "normal" single-threaded way. Doesn't the SFTP remote support multithreading operation? By looking at the SFTP "API" (as exposed by golang's  sftp package), it seems to support reading from/writing to arbitrary offsets:  https://godoc.org/github.com/pkg/sftp#File.Seek
Is anything else required for multithreaded operation?

@DurvalMenezes
are you sure that the problem isn't in --multi-thread-cutoff=1 without suffix ? as i understand without suffix default kBytes
@ncw
i tested new function with OneDrive, Team GDrive and mega.nz. looks like it's working pretty good, but mega.nz for stable transfer with full bandwith require around 20 streams. otherwise speed jumping from 40-60  to 100 Mb (channel - 100 Mb, 1 stream download - 8.7 Mb)
Really looking forward to multistream uploading implementation, cause usually uploading speed much lower than downloading.
Thank you for great software!

@AndShy, @ncw:

I'm pretty sure it was not. But I will pay attention to that on my next tests, in order to discard this hypothesis completely.

As expected, the problem does not seem to be connected with using a prefix; please see my post in the forum.

I wrote in the forum what I think is the explanation:
Multi thread copy will only work to the local backend for the time being. It could in theory work for some other backends but it is really complicated and I haven’t got my head round how to do it!

@ncw
better concentrate on multi-thread uploading. it's more important :)
file transfering between remote backends primarily must be their own problem or must be carried out by third side server / service (like multcloud.com)

As I said above I don't think google drive can do multi-thread uploading.
However to double check my understanding I asked a question on stack overflow: https://stackoverflow.com/q/56076208/164234
Mega definitely could, but I haven't implemented it. I'm not sure about onedrive.

looks like need do this "manualy" by somehow split large file on local side and check for splited files on remote side.

Howdy @ncw, @AndShy:

Multi thread copy will only work to the local backend for the time being. It could in theory work for some other backends but it is really complicated and I haven’t got my head round how to do it!

I may have found a way around that, via a separate rclone mount (see here for complete details)

As I said above I don't think google drive can do multi-thread uploading.

looks like need do this "manualy" by somehow split large file on local side and check for splited files on remote side.

The same trick may perhaps (more dubiously) be used to work around that; again, see my post in the forum linked above.
Cheers,
-- Durval.

I've merged this to master now which means it will be in the latest beta in 15-30 mins and released in v1.48.
Thank you all for testing.


Release builds for ARM32 + arm64 linux distributions

Would it be possible to get builds for Linux on ARM32 and ARM64? I've recently discovered that Omnisharp VIM functions on Termux in mono mode on Android devices, but I want to be developing using dotnet core, not mono.... and as there are no dotnet core builds for Termux, I've moved on to running a proot Debian install inside Termux, but I now require a Linux ARM64 build of Omnisharp in order to get Omnisharp VIM working.
It would also be cool to get it working on 32 bit phones and Android TVs.

@shaunawins relevant PR (on hold): https://github.com/OmniSharp/omnisharp-roslyn/pull/1706

Thank you! I'm sad that it's on hold... kinda tempted to try building it on my own, but I have basically 0 faith in my ability to successfully do so.

Definitely needs more priority with the Pi400 being a thing now, it'd be nice to be able to work with .NET on them.

Definitely needs more priority with the Pi400 being a thing now, it'd be nice to be able to work with .NET on them.

Could you maybe update issue #1706 with this same comment so they know there's some demand for such a build?

It is probably not the definite solution in place of an arm build but in most cases you can run this server on arm/raspberry PIs by side-loading mono from distro packages.
This comment by @lafleurh says that it works for him

It works but you have to create your own "run" shell script. See my comment on 2124

It works but you have to create your own "run" shell script. See my comment on 2124

Maybe I'm missing something as I haven't had my normal coffee dose, but your comment appears to apply to mono, not dotnet core... did you manage to get it working for dotnet core on android?

Yes, mono. I haven't tried it since .Net 6. .Net core 3.1 did not run on Android (or at least I couldn't figure out how, even tried compiling)

We now have arm64 Mono builds and arm64 .NET 6 builds.


Remove jenkinsfile for automatic repos snapshot

Now that we have it in prow and it's working properly, no need to keep this jenkinsfile.
/cc @eliorerz

/cc @mkowalski


Better error handling for missing profile

AWS cli does let you know but jq throws an error still
aws-cli-mfa -p profile-dne $AWS_MFA_ARN 123456

The config profile (profile-dne) could not be found
aws sts get-session-token --profile profile-dne --serial-number arn:aws:iam::####:mfa/XYZ --token-code 123456
jq: error (at <stdin>:1): null (null) has no keys

Resolved by #2


Integration tests cleanup

What this PR does / why we need it:
The integration tests are still flaky and are hard to debug. This PR makes the tests use the correct context everywhere. The logic for adding cert-manager CRDs on startup has been updated also: now, no restart of the api-server is required.
BONUS: changed bazel to have build dependencies linked to the right files.
BONUS 2: the test-duration improved significantly by doing this cleanup:
before:
//test/integration/acme:go_default_test                                  PASSED in 31.5s
//test/integration/certificates:go_default_test                          PASSED in 149.5s
//test/integration/conversion:go_default_test                            PASSED in 126.1s
//test/integration/ctl:go_default_test                                   PASSED in 156.0s
//test/integration/validation:go_default_test                            PASSED in 153.3s
//test/integration/webhook:go_default_test                               PASSED in 100.0s

after:
//test/integration/acme:go_default_test                                  PASSED in 19.9s
//test/integration/certificates:go_default_test                          PASSED in 88.0s
//test/integration/conversion:go_default_test                            PASSED in 70.3s
//test/integration/ctl:go_default_test                                   PASSED in 104.5s
//test/integration/validation:go_default_test                            PASSED in 87.5s
//test/integration/webhook:go_default_test                               PASSED in 56.7s

Release note:

/kind cleanup

/release-note-none

/ok-to-test

Tim, we're seeing integration test flakiness in #4341. Do you think these changes will fix that?
Also I think we should followup with a PR to upgrade to latest controller-runtime which has some envtest speedups: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.9.6

I think the v1.5 release caused my kubectl cert-manager x install test to fail, because it waits for the Job on a fake kube-api server.

I

Let's figure out how to either ensure that the goroutine with Run has been called before calling Port or alter Port to return a public ErrNotListening error and keep going if that is returned.

The logic you describe is already implemented (see: https://github.com/jetstack/cert-manager/blob/720ffaf6ac908ea2f96b9823d3dc91cc15b68c3c/cmd/webhook/app/testing/testwebhook.go#L109-L117)
The error is caused by a timeout, in the WaitForCRDs function; I'm not sure what the root-cause is.

The logic you describe is already implemented (see:

Ah, sorry. My mistake. I misread the code.

The error is caused by a timeout, in the WaitForCRDs function; I'm not sure what the root-cause is.

Maybe increase the timeout? 4s > 10s


[gnss_poser] switch broadcaster to full member...

In porting sensing_launch, I started a node with the gnss_poser and ran into
[INFO] [ublox_gps_node-1]: process started with pid [31684]
[ublox_gps_node-1] terminate called after throwing an instance of 'std::runtime_error'
[ublox_gps_node-1]   what():  U-Blox: Could not open serial port :/dev/ttyACM0 open: No such file or directory
[ERROR] [ublox_gps_node-1]: process has died [pid 31684, exit code -6, cmd '/home/frederik.beaujean/AutowareArchitectureProposal/install/ublox_gps/lib/ublox_gps/ublox_gps_node --ros-args -r __node:=ublox -r ublox/fix:=ublox/nav_sat_fix -r __ns:=/sensing/gnss'].

This PR avoids this problem by using a proper member instead of a shared pointer because shared_from_this() must not be called in the constructor of this. It looked like a shared_ptr was unnecessary here anyways.
@esteve @mitsudome-r
@jilaada do you remember if you ever started this node when you ported the package?

@fred-apex-ai Yes, I did start the node, but I guess this was before I had made the change to shared_from_this().

@fred-apex-ai Yes, I did start the node, but I guess this was before I had made the seemingly minor change to shared_from_this(). I also gave instructions in the PR description for gnss_poser for reviewers to also test the node as well to make sure it wasn't just my system or if I had made any mistakes in building or in my environment for consistency.

@jilaada Thanks for merging!

and the nodes launch properly without crashing.

That's the nature of undefined behavior "works on my machine"
Did you use the same compiler g++9.3.0  inside ADE as I do? cppreference mentions that only from C++17 on, an exception is thrown but my g++ already does with C++14
https://en.cppreference.com/w/cpp/memory/enable_shared_from_this

@jilaada Thanks for merging!

and the nodes launch properly without crashing.

That's the nature of undefined behavior "works on my machine"
Did you use the same compiler g++9.3.0 inside ADE as I do? cppreference mentions that only from C++17 on, an exception is thrown but my g++ already does with C++14
https://en.cppreference.com/w/cpp/memory/enable_shared_from_this

I had no idea @fred-apex-ai, thanks for the explanation! I think at this point i may have been using an environment outside of ADE as this was the first package I ported. Definitely something to take note of for next time!


adds form config with initialModel and middleware

What's this PR do?
adds a config parameter to connectForm
Related issues
#6
Where should the reviewer start?
FormContainer.tsx
How should this be manually tested?
connect a form and provide initialModel and middleware in the config object

Codecov Report

Merging #7 into master will decrease coverage by 0.55%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   59.04%   58.49%   -0.56%
==========================================
  Files           6        6
  Lines         105      106       +1
  Branches       17       18       +1
==========================================
  Hits           62       62
  Misses         32       32
- Partials       11       12       +1

Impacted Files
Coverage Δ

src/interfaces.ts
0% <ø> (ø)
:arrow_up:

src/FormContainer.tsx
65.07% <0%> (-1.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b934843...0fd615c. Read the comment docs.

Coverage increased (+0.1%) to 59.615% when pulling 0fd615c4603fd774d1976233944c56023759e814 on feature/issue-6-form-config into b93484306db7a860fb08c3bc5a67354c27974ab3 on master.

Coverage increased (+0.1%) to 59.615% when pulling a48df6f49e5bc494b37d51382ae04695f22c3c6d on feature/issue-6-form-config into b93484306db7a860fb08c3bc5a67354c27974ab3 on master.


1.8.0-rc1 cherry-pick request: some fixes for boosted_trees

After the fixes:

Stopping training at the right moment, without extra layers.
BoostedTreesClassifier and BoostedTreesRegressors work well with batched Dataset now.
Dependency between resource serialization and prediction is set properly.

@annarev This is the list of cherrypicks that I wish to merge. Please let me know if I need to do anything else. Thanks!

Thanks @yk5! Could you take a look at the build failure?

Looks like the build failure is irrelevant.

Hmm. Let me look at it. What's the timeline for Cherrypicks for RC1?
On Mon, Apr 16, 2018 at 10:51 AM Yifei Feng<EMAIL_ADDRESS>wrote:

Thanks @yk5 https://github.com/yk5! Could you take a look at the build
failure?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/18510#issuecomment-381689571,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXihKivmuCaWwbh5gWQOGd5MsJowPnv1ks5tpNoRgaJpZM4TUto1
.

By EOD Tuesday 04/17. I will start building the binaries on Wednesday.

Thanks!
On Tue, Apr 17, 2018 at 10:45 AM Yifei Feng<EMAIL_ADDRESS>wrote:

Merged #18510 https://github.com/tensorflow/tensorflow/pull/18510.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/18510#event-1579460244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXihKqc2nfxDPVD85krSPS_qmV7I86g9ks5tpiowgaJpZM4TUto1
.


Onnx function translation

(1) Extend the ONNX-to-MLIR frontend translator to handle ONNX functions.
(2) Add a test-case to illustrate and test its use.
An ONNX function is an op foo whose semantics is defined in terms of other (more primitive) ONNX ops. Thus, any call y = foo(x) can be effectively replaced by another sequence of ONNX-op calls (nodes). This allows for an alternative way to translate such a call into ONNX-MLIR.
This PR adds such functionality. Currently, it is invoked only when there is no standard-translation available. This provides one way to translate "custom ops" whose semantics can be defined via ONNX functions.

@caoimhinuibrian @tjingrant @chentong319 please have a look at this patch.

@jenkins-droid test this please

@jenkins-droid test this please

I am looking into fixing the circleci failure. I am somewhat unclear about the dependencies between the libraries: e.g., it looks like code in Dialect/ONNX has dependencies on "Krnl"; is that correct? Ideally the ONNX dialect itself should not have dependencies on the Krnl dialect.

Ideally the ONNX dialect itself should not have dependencies on the Krnl dialect.

Looking at the problematic code, it looks like there's a helper function that is shared between shape inference and lowering because we recently unified shape inference and aspects of code-generation related to output memory allocation, they are now a bit tied together.
@AlexandreEichenberger I feels like you probably know what's the best way to avoid a dependency from ONNX dialect to Krnl dialect. It occurs to me that the function extracting dense attribute values from constant ops introduces a dependency to Krnl Dialect, i.e., as you lower, constants become krnl.global ops, and we extract constants from krnl.global during lowering whereas during shape inference, we extract them from onnx.Constant ops.

On a slightly different note: I still don't understand why the build fails in CI. I am including OMLibs, which seems to contain all relevant libraries. Is there some other Krnl-related library that is not included in OMLibs? Thanks for any suggestions.

Ideally the ONNX dialect itself should not have dependencies on the Krnl dialect.

@AlexandreEichenberger I feels like you probably know what's the best way to avoid a dependency from ONNX dialect to Krnl dialect. It occurs to me that the function extracting dense attribute values from constant ops introduces a dependency to Krnl Dialect, i.e., as you lower, constants become krnl.global ops, and we extract constants from krnl.global during lowering whereas during shape inference, we extract them from onnx.Constant ops.

@tjingrant This indeed was a cause of grief. The ONNXShapeHelper is a single piece of code that needs to read constants, and these constants are stored differently in shape inference and ONNX to Krnl lowering. I did not like this, but I did not know how to avoid this problem. If there was a way to keep operands that are literal tensors in the same format, that would be great. I believe I asked you about the "stuffing the constant tensor into the operation parameters" and you mentioned that it was not really used; maybe it would be a use case? What do you think?
I see it used for gather (indices tensor), slice (start/end/step/axis)... and I am sure there are other places where the constant have to be read in order to define the shape and lowering to Krnl.
Looking forward to your suggestions.

We are looking into the failure of "Build x86 onnx-mlir on macOS / build-x86-onnx-mlir-macOS (pull_request)". It might be due to a mismatch of python levels. We are seeing this error in all of our PR, so its unlikely linked with your code change.

@jenkins-droid test this please.

Great. Glad it is passing all tests now. Please let me know if you have any more questions about this PR or if it needs something more.
A question about the signoff: are the instructions shown in DCO valid? I think there could be some complications, since changes from master were merged into the PR. I don't want to confuse issues by signing off other merged commits.

@jenkins-droid test this please.

Thanks. The DCO issue has been resolved. Please let me know if you have any questions or if this can be merged in.

@jenkins-droid test this please.

@jenkins-droid test this please.

Sorry for the delay, just confirmed with @gongsu832 that the s390x-docker issue is expected for the time being.


enable build System.Private.Interop project

verify the fix for build issue

@shrah , @MichalStrehovsky PTAL

Can you confirm these two projects no longer place their build outputs in the same directory? We had build races in the official build because of that (not the CI build; the build that does signing and produces NuGet packages).
I'm still missing the broader context on these though. Are we going to ship NuGet packages of these from this repo? Or why do these project files need to build here? The build is not really set up for this - e.g. right now these libraries are going to be placed in the CoreRT SDK even though they're unused because they don't actually target CoreRT.
I'm not opposed to making changes to enable these scenarios, but it might need some broader build changes, not just hacking up OutputPath to something else.

@MichalStrehovsky resolve two projects' build outputs in the same directory issue-- the problem is related to import a project file instead of target file.

Are we going to ship NuGet packages of these from this repo?
// Yes, some of our customers require to use NuGet packages

why do these project files need to build here?
// Customer want to use open-source System.Private.Interop. To open source System.Private.Interop, there isn't many options for us.

in GitHub CoreRT repro
Pro:
it takes less time to add/build/sign/publish/test these projects into CoreRT repro.
Con:
These projects doesn't 'really' belong to CoreRT.
in GitHub 'new' repro
Pro:
These projects fits better in  the 'new' repro, such as Interop Repro
Con:
It take much longer time to add/build/sign/publish/test these projects.

In future, We will consider Option #2.

Customer want to use open-source System.Private.Interop

@luqunl There are many ways how to achieve that. E.g. the mono repo already uses the CoreRT repo as a submodule and they pick and choose files they would like to use. What's the intended consumption model here?

@MichalStrehovsky The consumption mode is that customers can just use nuget package generated from CoreRT branch and can submit PR for fixing S.P.Interop issues

OK, so we need official builds and NuGet packaging.
This will require some broader thinking on your part. If these projects are just hooked up into whatever build configurations CoreRT repo defines, there will be issues with build matrix. Mono's and CoreCLR's build matrix is different from CoreRT. The way we have the alternate S.P.Interop projects hooked up into build.cmd right now means that you can't produce a e.g. x86 build of the S.P.Interop library without making all of CoreRT compile on x86 first (see #4589 - not even x86 is supported right now in CoreRT). Especially Mono's support matrix is huge and spans architectures and operating systems.

System.Private.Interop for mono only works on Windows. so its matrix for using System.Private.Interop should be similar as CoreRT.

in my mind, x86/amd64/arm build configurations for System.Private.Interop should be enough

@luqunl As we have discussed during our phone call with Mono team, they are not going to consume NuGet packages from CoreRT repo. They are going to build their own binaries from CoreRT sources.

@jkotas, Azure Service Fabric and VS Debugger team want to consume from Nuget package

Right, they are different from Mono. I would expect we will build one platform-neutral build for them.
As @MichalStrehovsky said, it will require some build plumbing

@jkotas, some of interop code are architecture dependent. so neutral doesn't work for them.
such as

Then you will need to choose between making this platform neutral, e.g. by using if (sizeof(int) == sizeof(IntPtr)) instead of ifdef in this case, or even more build infrastructure plumbing.

For build infrastructure plumbing, beside support build neutral assembly, anything else specific for these two projects?
In short team, In my mind, it isn't critical to enable support build neural assembly.

If you do not have platform neutral build, you will pay for it in the packaging and build leg complexity. Up to you where you want to pay the cost...
Either way, you may want to have separate build.cmd for the official build of the interop bits so that you do not have to build the whole corert repo just to build the interop bits.

Thanks for your explanation.  if these two(neutral/build.cmd) becomes problem, then we can fix them one by one.

@luqun We prefer to use squash&merge option to merge regular PRs.

Next time, I will follow this.


typo

nice! i missed this. could you just click on the details link by the failing DCO check and follow those instructions? then we'll merge away


Fix "seastar::aio_general_context::flush(): Assertion `clock::now() < retry_until'"

There is a potential crash in the seastar::aio_general_context. For more background see https://github.com/scylladb/seastar/issues/1784
We have now hit this in production so we should cherry pick the suggested fix from https://github.com/scylladb/seastar/pull/1788

I guess this is the new variation of:
https://github.com/redpanda-data/redpanda/issues/5184
Where the assert has changed because the logic has changed but the underlying thing is similar: can't make forward progress and/or the condition on forward progress is a bit too strict.

Just reposting a few things discussed elsewhere:

As discussed in https://github.com/scylladb/seastar/issues/1784 aio_general_context doesn't have the same "iocb management" that aio_storage_context has. Hence from our understanding it's not a surprise that one can run into this assert
This PR will improve the situation as EAGAIN is handled
This then still leaves https://github.com/redpanda-data/redpanda/issues/5184 and possibly makes that more likely to happen instead. Nevertheless this patch should help with the deadlocks/asserts if there is only very short lived backpressure.

I have added another commit now which addresses the last < end assert.

Changed as discussed yesterday.


26861 clarify insecure cn example

Describe the proposed changes
Changed the CN example in the section 'Test an Insecure Registry' to provide clarity around the CN prompt. Docs in the past instructed people to use a specific CN (which potentially already exists) rather than a CN of their choice.
Unreleased project version

Related issue

Related issue or PR in another project
https://github.com/docker/docker/issues/26861
Please take a look

Deploy preview ready!
 Pretty sure they don't need to be here. :) It's also causing a merge conflict.

@nwright-nz it looks like you changed the Dockerfile file by accident. Can you remove that change from this PR?

Oof - sorry everyone. Still learning. will get this sorted ASAP

It seems that you've closed this PR :( Are you opening a new one, or do you need any help?


Issue with AVD host performance workbook

There is an issue with the WorkspaceId parameter in the Host Performance.workbook on line 156, linked below.
It is looking for a specific resource group 'WVDSelfhost' that does not exist in our environment and I was not able to find reference to it being used anywhere else.  Can this filter please be removed as it is preventing our Host Insights from pulling in host performance data.
https://github.com/microsoft/Application-Insights-Workbooks/blob/3e4d3a79c0be1294f9b4fa59da82ad2ee10218fc/Workbooks/Windows Virtual Desktop/Host Performance/Host Performance.workbook#L156C36-L156C80

@mpbastos can you look at this?


[FEATURE REQUEST] Any plan to make it work with webworker

It's an interesting idea technology wise, though I haven't encountered too many projects that use time-based web workers. Is there a specific site or use case that you have in mind?


fix: remove square brackets in long contexts correctly

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bugfixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolve #113
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Removed some notifications because I felt like there were too many of them

Codecov Report
Patch and project coverage have no change.

Comparison is base (8407a25) 97.50% compared to head (bac69c9) 97.50%.

:exclamation: Current head bac69c9 differs from pull request most recent head 0322c84. Consider uploading reports for the commit 0322c84 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   97.50%   97.50%
=======================================
  Files          11       11
  Lines         160      160
  Branches       19       19
=======================================
  Hits          156      156
  Misses          4        4

Impacted Files
Coverage Δ

src/ObsidianRegex.ts
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Refactor text output

Discussed in https://github.com/pnp/cli-microsoft365/discussions/2453

Originally posted by waldekmastykarz May 27, 2021
I'd like to propose that in v4 we refactor the text output mode:

We rename it to table so that it's clearer what it does. Since in the terminal everything is text, text isn't pretty descriptive. Using table instead would be clearer and we'd align with the Azure CLI
We change it so that you always get to see a table. Right now, if you get just one result, we transpose the output so that you get a key-value pair output where each pair is printed in a new line. Originally we introduced it for readability but I'm not sure if it's worth the effort and if consistency wouldn't be preferable.

Hi,
agree by keeping the output format always the same.
It is easier when writing automations that expect always one type of format.
Cheers

We change it so that you always get to see a table. Right now, if you get just one result, we transpose the output so that you get a key-value pair output where each pair is printed in a new line. Originally we introduced it for readability but I'm not sure if it's worth the effort and if consistency wouldn't be preferable.

So there is one problem with that. Our list commands are optimized to only show a few selected properties so that we can fit the output in the terminal's width. Our get commands on the other hand, up until now used the key-value pair output which made it fine to output all properties one under the other. If we always use the table output, we'd need to update all get commands to only include the few selected properties rather than all, which I think would make the table output useless for get commands as you'd likely want to see all properties. So with that, shall we keep the current functionality intact?
@pnp/cli-for-microsoft-365-maintainers

So with that, shall we keep the current functionality intact?
Agree with you on that Waldek. My opinion is, weighing the dependency factor involved in the change, it does not add much value to the dependency it may bring to the table since updating all the get commands would be a herculean change.
Yes, output looks good in the table, just a good to have feature rather than a must to have I would say.
Plus, we are planning to make the output as JSON as per #2599 , that being the case the usage of default text for the end users may come down again which will reduce the value of this change in my opinion.

In that case, let's close this issue as something we won't be changing at this time. Thanks!


Create API Endpoints for MP Unit Capacity Data

Create API Endpoints for MP Unit Control Data under Facilities API:
Add:
GET in public view
GET, POST, PUT in the Workspace

Test Case: TC440

Test Passed

Test Case: TC440
Test Passed


Stats calculations going up but not coming back down again.

Two parts to this:

When you add a talent it adds to your stats, when you take away a talent it does not in turn remove the stats added.
When you change your profile picture it adds the stats again based on what talents you have selected, so when you flick through them with multiple talents, the stats blow out rather quickly

Otherwise, this is really rather delicious - have some cake. :cake:

Thanks so much for the bug report (and cake)!
I'm shocked that we haven't noticed or heard about this issue before since it's so obvious once you know what to look for.  I appreciate you taking the time to report it.  I believe #4 will merge soon and fix the issue.

My fix has merged so the stats should now calculate correctly.  I don't see the issue on dungeonsanddevelopers.com (which doesn't have my fix) so I think the problem was specific to the version on GitHub.  Thanks again for reporting the issues!


test: Events API integration test - Success Case

Added 'Events' API integration test.
Added one CMS file and one Data file
Passed test screen shot

@dricazenck - Done the suggested changes. Thanks !


message-box: Show zoom-in cursor on hovering over images.

This PR adds a zoom-in cursor to all the images in the message-box container. This makes the UX of clicking on images better and intuitive.

Testing Plan:
GIFs or Screenshots:
Before:

After:

Merged, thanks @akashnimare!


Clarify behaviour in summary of CopyDirectory method alias

Simple clarification of wording to resolve issue #769

@UnbelievablyRitchie LGTM :+1: I'll merge once CI's finished.

Hope I've done this correctly; my first git hub commit. I'm hoping to run through issue #750 and tidy up the remainder of the missing examples.

@UnbelievablyRitchie to be picky would've liked a feature branch(feature/GH769) :wink: But issue created& referenced so that's good. I'll just wait for Travis to complete.

@UnbelievablyRitchie merged, thanks for you contribution:+1:

Cool; will do for next one. Thanks for the feedback.

@UnbelievablyRitchie excellent :+1:


Make Managed's new reservation capability more first class

Managed has a new methods of specifying allocation and disposal of a resource: namely, it's new constructor:
case class ZManaged[R, E, A](reserve: ZIO[R, E, ZManaged.Reservation[R, E, A]])

This provides "interruptible acquisition", unlike bracket. It's also safe, in that it has no possibility of leaking resources when properly utilized.
Unfortunately, people aren't discovering it there. To make it more discoverable, we should make the following changes:

First, pull out Reservation to the top level, as a class inside the scalaz.zio package.
Second, add a new ZManaged.reserve method, which accepts a Reservation.
Third, add a method to ZIOFunctions inside ZIO.scala, which has this signature:def reserve[R, E, A, B](reservation: ZIO[R, E, Reservation[R, E, A]])(use: A => ZIO[R, E, B]): ZIO[R, E, B]

This function will merely call ZManaged.reserve on the reservation, followed by use with the specified function.
Add Scaladoc for everything.
Ideally, update the microsite with a short notice.

/cc @mvv

Related to #580

I can take this one.

@jdegoes I'll try and finish the microsite bit this weekend but I was thinking of picking up #687 anyway. Perhaps I should start that sooner rather than later.

@Cereopsis Sure, whichever you prefer, I'm grateful for either. 😄

@jdegoes Perhaps I won't make a meal of the code examples now, rather wait until mdoc for that. Right now I'll tweak a few words. I'm thinking that now it's enough to say that Reservation encapsulates the acquisition/release and ZManaged controls the usage of it.

Isn't Reservation enough to provide a conversion between Resource from catz and Managed?
Something like https://github.com/mschuwalow/zio-todo-backend/blob/develop/app/src/main/scala/com/schuwalow/zio/todo/config.scala#L52-L56. Or is this something unsafe to do.
If its safe to do it might be interesting to provide something like this in interop

Resource can be safely converted to Managed, but not visa versa without losing interruptibility (it would be "safe" to do that, but in some situations, having interruptible acquisition is necessary for preventing "temporal" leaks).

@jdegoes
Resource's Suspend is interruptible,  so I think it should be possible to preserve interruption in Managed - https://github.com/typelevel/cats-effect/blob/c38156e7396988d3160480665f022ec42966c487/core/shared/src/main/scala/cats/effect/Resource.scala#L127


Changing the list of commonmarker extensions with custom renderer is broken

Hey,
A while back @gjtorikian assisted in allowing us to choose a custom renderer for the MarkdownFilter. He also explained how to remove extensions (in our case, tagfilter).
I just discovered that when using these features together, tagfilter is not properly removed.
I added a working and a broken test for this in my branch https://github.com/hannesfostie/html-pipeline/tree/hf/extensions-issue
I'll spend a bit longer to try and figure this out but wanted to create the issue since you're much more familiar with the code, just in case you immediately knew where to look. If I find a solution I'll share it here and create a proper PR for it.

My mistake here--I forgot to pass unsafe as an option along with the renderer, too 🤦♂  4e997bfa7975d917c445bd99cd1949a108604423

Aha! That makes perfect sense. Thank you!


Compiler warnings

While building on Ubuntu 22.04:
pyedflib/_extensions/c/edflib.c:39: warning: ignoring ‘#pragma warning ’ [-Wunknown-pragmas]
   39 | #pragma warning( disable : 4996 ) // ignore unsafe strncpy
      |
pyedflib/_extensions/c/edflib.c:40: warning: ignoring ‘#pragma warning ’ [-Wunknown-pragmas]
   40 | #pragma warning( disable : 4244 ) // ignore precision loss
      |
pyedflib/_extensions/c/edflib.c: In function ‘edflib_check_edf_file’:
pyedflib/_extensions/c/edflib.c:2629:35: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘__off64_t’ {aka ‘long int’} [-Wformat=]
 2629 |                 printf("filesize %d != %d*%d+%d ",ftello(inputfile),edfhdr->recordsize, edfhdr->datarecords, edfhdr->hdrsize);
      |                                  ~^
      |                                   |
      |                                   int
      |                                  %ld
pyedflib/_extensions/c/edflib.c:2629:44: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘long long int’ [-Wformat=]
 2629 |                 printf("filesize %d != %d*%d+%d ",ftello(inputfile),edfhdr->recordsize, edfhdr->datarecords, edfhdr->hdrsize);
      |                                           ~^                                            ~~~~~~~~~~~~~~~~~~~
      |                                            |                                                  |
      |                                            int                                                long long int
      |                                           %lld

/usr/lib/python3/dist-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^~~~~~~
pyedflib/_extensions/_pyedflib.c:9231:27: warning: ‘__pyx_f_8pyedflib_11_extensions_9_pyedflib__chars’ defined but not used [-Wunused-function]
 9231 | static __Pyx_memviewslice __pyx_f_8pyedflib_11_extensions_9_pyedflib__chars(PyObject *__pyx_v_s) {
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I would be great to rely on a recent version of EDFlib. Not sure how to extract the patches that need to be re-applied onto a new version.

I agree. In the optimal scenario, we rewrite the code base such that the original C code remains untouched and all additions/changes are in external files.
Unfortunately, I do not have the resources to this right now :-/ it's probably a bit of work but less than expected. I updated the C library once.

It's even less than I thought: https://www.diffchecker.com/iE3iuUXR/
It's not actually much, to the point that we might just be able to replace the C file as is. I think there are more changes in the header file, but it's a small file.

Modifying the functionality of a C function does require to modify its source code. Perhaps I can write an additional C function that runs extra code before/after calling the original EDFlib function. However, the existing and new functionality might be inextricably interlinked, enough to prevent splitting it into two functions.


Fix Dependabot config

Are you able to force the dependabot check to run?

Are you able to force the dependabot check to run?

I don't think so, why do you ask?

To see if it fixes the problem

To see if it fixes the problem

Oh, I think we're good. Turns out I did have a linter running in VSCode and it was pointing out problems, but I missed it. It's not reporting any problems any more.


chore(weave): Document feedback feature with call UUID examples

Summary
Adds documentation for the feedback feature.
Includes examples for retrieving call UUIDs in code

I have read the CLA Document and I hereby sign the CLA

recheck

CLA check isn't working, will close this in favor of copy at https://github.com/wandb/weave/pull/2178 as a workaround.


Audit with Sandbox

At times people would like to develop things for a subscription, which resided e.g. underneath corp.
However, the policies keep them for getting their things done.
To circumvent that you could have

all policy assignment with effect deny on the landing zones management group should have a matching policy assignemnet with
all management groups underneath landing zone, would have a matching management group underneath sandbox
as before, the policy assignment with effect deny underneath landing zone would have the effect audit underneath the management group sandbox.

This way landing zone and sandbox would be well separated. And you would be able to verify which policies you are violating for your final landing zone .

Hey @mw8er,
We are actually working on documenting an approach very similar and making it available in our implementations that @brsteph has been putting some thought into.

Is this aligned to your suggestions?


Add two PR for making it easy to review

How can I do this

Ok, I got it. I filled it

Good. Excellent