drop the check of  monai.utils.get_torch_version_tuple() >= (1, 6)

Describe the bug
because the core codebase now requires at least torch 1.6

As in lines like amp=True if monai.utils.get_torch_version_tuple() >= (1, 6) else False where we choosing to use AMP only if available? If Pytorch 1.6 is assumed to always be used then yes we should. So far these are the only places get_torch_version_tuple is used.

Yes, it's mainly for the amp flag.

I've removed the checks and created a PR for it.


Error: "Cannot redefine property: Shopify" when run Hydrogen on local

What is the location of your example repository?
No response
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
2024.7.7
What version of Remix are you using?
No response
Steps to Reproduce
I added the PUBLIC_CHECKOUT_DOMAIN equal to STORE_NAME.myshopify.com (by following this post from Shopify Community: https://community.shopify.com/c/hydrogen-headless-and-storefront/issues-setting-up-hydrogen-locally/m-p/2615078)
and run the command npm run dev. The site localhost:3000 reloaded continuously and I saw an error on console log:

Expected Behavior
n/a
Actual Behavior
n/a

Updated: It does not happen on version 2024.7.3 of Hydrogen

No, I do not.
I just create a Hydrogen project and add environment variables

I can't reproduce this at all. Please provide detail instruction to reproduce this error, including your npm version, nodejs version, operating system you are using


Update common, move service provider initialization to common

Implementation of SpongePowered/SpongeCommon#25
Implementation of SpongePowered/SpongeAPI#650
This is not much, just bumping the command and adjusting service registration so it is all done in common.

Merged in https://github.com/SpongePowered/Sponge/commit/439b6b5157c8e619577d9f1ee304a8afcc8dd36b


Add GPT-NeoX model

Implement the GPT-NeoX model from https://huggingface.co/docs/transformers/en/model_doc/gpt_neox
On M2 Ultra (non quantized):
==========
Prompt: what
 is the best way to do this?

A:

You can use the following code:
$('#my_div').html(function(i, html) {
    return html.replace(/<br\s*\/
==========
Prompt: 0.943 tokens-per-sec
Generation: 15.146 tokens-per-sec

Closes https://github.com/ml-explore/mlx-examples/issues/847

Thanks for the port @nicolov ! Would also be good to add the model type (and possibly default key names) to the Lora training utility.

Thanks for the port @nicolov ! Would also be good to add the model type (and possibly default key names) to the Lora training utility.

Done and added a smoke test for LoRA.


Expose functions like onFail, onNotFound

Hello, would be of great benefit to expose the functions
onFail and onNotFound as it's an edge case that needs to be handled.
We can see the functions and there are few pull requests as far as I can see.
Please let us know why its not exposed , I can create a PR if needed be.

@FaridSafi could you please provide feedback or give us the green light to code it

@nikolajordanovski  what do you mean by exposing the functions?
I use onFail in this snack with no problems.
PRs always welcome

@bell-steven Thank you for the feedback, will look into it, tho based on the code I believe the onFail is never triggered


dynamic tv apps

Problem

tv-app does not support dynamic endpoints
tv-app does not provide examples of app-assisted user-directed-commissioning

Change overview

Enable dynamic endpoints in tv-app
Add ContentApp and ContentAppPlatform abstract classes in app/util. These require platform-specific implementations.
Add dummy Linux ContentApp and ContentAppPlatform which maintain a set of ContentApp objects (vids 1, 2, 9050)
ContentApp with matching vendor id can be used during user directed commissioning to obtain the pin-code
Hooked up AppPlatform to apps for AppBasic cluster attribute reads and writes

Testing
From the tv-app shell, to set a pin for a given app:

app setpin [vid] [pincode]

From the tv-app shell, to initiate commissioning for UDC table index 0 using app with matching vid to get the pin:

app commission [udc-entry]

Here is the complete test:

start tv-app:
tv-app shell>./out/host/chip-tv-app --secured-device-port 5640

start tv-casting-app:
tv-casting-app shell>./out/host/chip-tv-casting-app

trigger UDC from tv-casting-app
tv-casting-app shell>0

commission from tv-app using pin code obtained from app corresponding to tv-casting-app vid (usually 9050)
tv-casting-app shell>app commission 0

TODOs for next PR:

add more clusters to the tv-apps

Fast tracking, given this has had enough time for review.
@chrisdecenzo Can you take a look at restyle please?

Fast tracking this, given it's been in review for a while.


Can't install the latest version from release page

When I try to install it Firefox says it's broken. I'm running 112.0.1 64-bit.

Is it v1.0.7? I can install it on my side.

I can't install it on Firefox either. It installs as a temporary extension if you do it through "Debug Add-ons" (as shown in the screenshot), but if you try to install it as a regular add-on using "Install add-on from file", then it fails and says it's corrupt.
The temporary extension works fine on the Bing website, but as soon as you restart your browser, it's gone.

Hmm, I do not have any expertise on this; I don't think the changes made for v1.0.7 suddenly made the code corrupted. Does it seem like there are some signatures missing? Does anyone know the recommended steps to resolve this?


Add GH action for automatically markdown formatting + commit

As mention @lowkeypriority in #26. It will be nice to have pretty well formatted README. To keep high quality level without effort to contributor works I want to:

[x] Add workflow: Quality Assistance
[x] On ~pull_request~ push events format all *.md inside repo,
[x] Detected changes commit into PR ref branch with message "[QA] Markdown formatted automatically"
[x] If any of rules cannot be resolve automatically then fail workflow

As starting set of rules we may use proposed by @lowkeypriority in #26:

I'm suggesting to format README with markdown rules from markdownlint repo

On pull_request I had problem with checkouting and later commiting into fork so I decide to run workflow on push.`
So it is required to turn on Actions in forks.

This workflow will works for:

all forks with enabled Actions (may enable on Actions tab)
main repository

In other case, some unformatted changes may be merge, however it isn't a catastrophe - someone's workflow earlier or later fix it. I do not want spend more time for that low important issue.
I close it as resolved


Host documentation on GitHub

https://github.com/dwdyer/uncommons.org/tree/master/reportng
I think GitHub page with a custom host (http://reportng.testng.org) should be enough

Done, but the documentation should be updated (link, date, ...)
http://testng-team.github.io/reportng

@juherr : Just curious to know, how did you manage to do this?

It's a github feature. Follow the link I provided.
Here, I choose to use the docs folder but you have some other possibilities.

@juherr - Before putting in the documentation into README.md I tried to fiddle around with the gh-pages part.. but for some reason the end-point that Github was generating was always routing me to testng.org/reportng and i was hitting a page not found error. How did you fix that part ?

How did you fix that part?

https://github.com/testng-team/testng-team.github.io/commit/31b6860f55b6d68e8bdcc3a6e040807fcb20e1b0
;)


Error Installation on M1 Air: yabai: scripting-addition failed to inject payload into Dock.app!

Hi, I followed the Mac thread and have tried everything! But can't seem to get it working. Everything works except the spaces.
Anyone have any ideas?
I'm still having issues, even after following @Tweoss  steps
I get this error:
$ sudo yabai --load-sa
could not spawn remote thread: (os/kern) invalid argument
yabai: scripting-addition failed to inject payload into Dock.app!

MacBook Air (M1, 2020) 12.2.1

File Commands:
$ file $(which yabai)
/usr/local/bin/yabai: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
/usr/local/bin/yabai (for architecture x86_64):	Mach-O 64-bit executable x86_64
/usr/local/bin/yabai (for architecture arm64):	Mach-O 64-bit executable arm64

jordan at MacBook-Air in ~
$ cat /Library/ScriptingAdditions/yabai.osax/Contents/Info.plist | grep -A 1 CFBundleVersion
<key>CFBundleVersion</key>
<string>2.0.4</string>

jordan at MacBook-Air in ~
$ file /Library/ScriptingAdditions/yabai.osax/Contents/Resources/payload.bundle/Contents/MacOS/payload
/Library/ScriptingAdditions/yabai.osax/Contents/Resources/payload.bundle/Contents/MacOS/payload: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64e:Mach-O 64-bit dynamically linked shared library arm64e]
/Library/ScriptingAdditions/yabai.osax/Contents/Resources/payload.bundle/Contents/MacOS/payload (for architecture x86_64):	Mach-O 64-bit dynamically linked shared library x86_64
/Library/ScriptingAdditions/yabai.osax/Contents/Resources/payload.bundle/Contents/MacOS/payload (for architecture arm64e):	Mach-O 64-bit dynamically linked shared library arm64e

jordan at MacBook-Air in ~
$ file /Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader
/Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader (for architecture x86_64):	Mach-O 64-bit executable x86_64
/Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader (for architecture arm64e):	Mach-O 64-bit executable arm64e

Console.app logs:
default	16:39:16.581952-0400	runningboardd	Acquiring assertion targeting [daemon<com.apple.Dock.agent(501)>:2470] from originator [daemon<com.apple.WindowServer(88)>:394] with description <RBSAssertionDescriptor| "AppVisible" ID:414-394-1294 target:2470 attributes:[
	<RBSDomainAttribute| domain:"com.apple.appnap" name:"AppVisible" sourceEnvironment:"(null)">,
	<RBSAcquisitionCompletionAttribute| policy:AfterApplication>
	]>
default	16:39:16.582912-0400	runningboardd	Assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) will be created as active
default	16:39:16.592556-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:16.592758-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:16.592863-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:16.593048-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:17.105830-0400	runningboardd	Invalidating assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) from originator [daemon<com.apple.WindowServer(88)>:394]
default	16:39:17.227613-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:17.228876-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:17.228997-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:17.229378-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:19.145541-0400	Dock	LSExceptions shared instance invalidated for timeout.
default	16:39:19.644987-0400	runningboardd	Acquiring assertion targeting [daemon<com.apple.Dock.agent(501)>:2470] from originator [daemon<com.apple.WindowServer(88)>:394] with description <RBSAssertionDescriptor| "AppVisible" ID:414-394-1322 target:2470 attributes:[
	<RBSDomainAttribute| domain:"com.apple.appnap" name:"AppVisible" sourceEnvironment:"(null)">,
	<RBSAcquisitionCompletionAttribute| policy:AfterApplication>
	]>
default	16:39:19.645126-0400	runningboardd	Assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) will be created as active
default	16:39:19.645662-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:19.645699-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:19.645735-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:19.645939-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:19.705178-0400	runningboardd	Invalidating assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) from originator [daemon<com.apple.WindowServer(88)>:394]
default	16:39:19.823085-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:19.823123-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:19.824892-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:19.825126-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:33.451859-0400	runningboardd	Acquiring assertion targeting [daemon<com.apple.Dock.agent(501)>:2470] from originator [daemon<com.apple.WindowServer(88)>:394] with description <RBSAssertionDescriptor| "AppVisible" ID:414-394-1344 target:2470 attributes:[
	<RBSDomainAttribute| domain:"com.apple.appnap" name:"AppVisible" sourceEnvironment:"(null)">,
	<RBSAcquisitionCompletionAttribute| policy:AfterApplication>
	]>
default	16:39:33.451905-0400	runningboardd	Assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) will be created as active
default	16:39:33.452455-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:33.452486-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:33.452512-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:33.452568-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:33.941010-0400	runningboardd	Invalidating assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) from originator [daemon<com.apple.WindowServer(88)>:394]
default	16:39:34.052510-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:34.052726-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:34.052944-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:34.053616-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:37.828255-0400	runningboardd	Acquiring assertion targeting [daemon<com.apple.Dock.agent(501)>:2470] from originator [daemon<com.apple.WindowServer(88)>:394] with description <RBSAssertionDescriptor| "AppVisible" ID:414-394-1385 target:2470 attributes:[
	<RBSDomainAttribute| domain:"com.apple.appnap" name:"AppVisible" sourceEnvironment:"(null)">,
	<RBSAcquisitionCompletionAttribute| policy:AfterApplication>
	]>
default	16:39:37.828433-0400	runningboardd	Assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) will be created as active
default	16:39:37.829545-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:37.829580-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:37.829613-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:37.829679-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed
default	16:39:37.907046-0400	runningboardd	Invalidating assertion<PHONE_NUMBER> (target:[daemon<com.apple.Dock.agent(501)>:2470]) from originator [daemon<com.apple.WindowServer(88)>:394]
default	16:39:38.024341-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring jetsam update because this process is not memory-managed
default	16:39:38.024780-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring suspend because this process is not lifecycle managed
default	16:39:38.025316-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Ignoring GPU update because this process is not GPU managed
default	16:39:38.026043-0400	runningboardd	[daemon<com.apple.Dock.agent(501)>:2470] Skipping AppNap state - not lifecycle managed

Any ideas?

facing the same issue on
mac os 12.3.1.

Make sure that the terminal/shell you are running is an arm binary, and not an x86-64 binary running through Rosetta 2.

$ sudo yabai --load-sa
could not spawn remote thread: (os/kern) invalid argument
yabai: scripting-addition failed to inject payload into Dock.app!

I am not sure which specific error it is in your case, but this message is either caused by an architecture mismatch, or because the following flag (on Apple Silicon) has not been set properly :
# Open a terminal and run the below command, then reboot
sudo nvram boot-args=-arm64e_preview_abi

My bad, I don' t have exactly the same issue:
sudo yabai --load-sa
could not retrieve task port for pid: 6658
yabai: scripting-addition failed to inject payload into Dock.app!

The process is Dock.app:
ps ax | grep 6658
 6658   ??  S      0:00.31 /System/Library/CoreServices/Dock.app/Contents/MacOS/Dock

SIP is disabled:
csrutil status
System Integrity Protection status: disabled.

Are you running from a sandboxed environment, like Nix or something? I have never gotten that error message myself as long as SIP is disabled.

I'm running from a M1 macbook pro with filevault activated.

solved it using sudo defaults write /Library/Preferences/com.apple.security.libraryvalidation.plist DisableLibraryValidation -bool true

Hm I don't remember ever having to turn off library validation. Will need to check my system if it for some reason it is disabled??

I use Xtrafinder and during the installation it is asked to do so to enable loading script-additions. Just after doing that, I had no issue loading the SA for yabai.

I'm also having the same issue and have confirmed boot-args are set properly and that the terminal is an arm binary. Could anything else be causing this error:
$ sudo yabai --load-sa could not spawn remote thread: (os/kern) invalid argument yabai: scripting-addition failed to inject payload into Dock.app!

I'm getting the following:
~ ❯ sudo yabai --load-sa
sh: /Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader: No such file or directory
yabai: scripting-addition failed to inject payload into Dock.app!

I had issues on 11.3 (didn't check the error message but had the same problems) and 12.3.

I'm getting the following:
~ ❯ sudo yabai --load-sa
sh: /Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader: No such file or directory
yabai: scripting-addition failed to inject payload into Dock.app!

I had issues on 11.3 (didn't check the error message but had the same problems) and 12.3.

I see the same error.

I'm getting the following:
~ ❯ sudo yabai --load-sa
sh: /Library/ScriptingAdditions/yabai.osax/Contents/MacOS/mach_loader: No such file or directory
yabai: scripting-addition failed to inject payload into Dock.app!

I had issues on 11.3 (didn't check the error message but had the same problems) and 12.3.

I see the same error:

fixed by sudo nvram boot-args=-arm64e_preview_abi

i has a similar issue and the problem was that the yabai service in homebrew was not started. once i started it with ```bash
brew services start yabai
sudo yabai --load-sa


Review polyfill approach to writing progressively-enhanced, x-browser Javascript

I heard the project is considering a polyfill approach to JavaScript cross-browser support.
I spoke to Nick Colley on Slack about the disadvantages of polyfills and how we might want to consider a more robust approach moving forwards.
The approach is discussed in (my article) Progressively Enhanced JavaScript, but I learnt this from Peter Michaux’s Cross Browser Widgets article (don’t let the date put you off; the best techniques usually stand the test of time).
I’m happy to discuss/help further with this, but just getting this down as an issue for now.

We're currently in a halfway place between this approach and a strict polyfilling approach.
You can see the details component uses the approach described here: https://github.com/alphagov/govuk-frontend/blob/master/src/details/details.js#L11
Whereas the Checkbox component uses the (if we continue) the new approach:
https://github.com/alphagov/govuk-frontend/blob/master/src/checkboxes/checkboxes.js

It seems you've got a lot of the code necessary written to create a wrapper interface as opposed to polyfills. So with a little bit of work, you could avoid the polyfill problem.

They augmenting host objects

This is a valid point but seems to be being made mainly on the basis of extending functionality that is not part of the stable ECMAScript specification. Which is not what we're doing.

Feature detection is not enough

Well reasoned and makes sense, however the detections used by the Financial Times account for this. Where necessary they do more than check the prototype of a global feature.

They intertwine browser and application logic

This argument seems to be made without considering polyfills, I agree that it's a bad idea to expose your application logic to complexities with different browser but both utilities and polyfilling achieves the same goal here?

We rarely need need the full API

This makes sense.

They come with caveats

This is definitely a risk.

Another risk is that we cannot be sure our polyfills do not break third party code.
I think the biggest positive with polyfilling is we are writing JavaScript that does not require developers to understand our abstractions. If you understand addEventListener it'll just work.

Thanks @nickcolley

This is a valid point but seems to be being made mainly on the basis of extending functionality that is not part of the stable ECMAScript specification. Which is not what we're doing.

What do you mean by stable here? Every host object API is subject to the pitfalls of augmentation.

the detections used by the Financial Times account for this. Where necessary they do more than check the prototype of a global feature.

Agreed—I should amend my article. It's not a fault of polyfills per se. Thanks

This argument seems to be made without considering polyfills, I agree that it's a bad idea to expose your application logic to complexities with different browser but both utilities and polyfilling achieves the same goal here?

Agreed.

What do you mean by stable here? Every host object API is subject to the pitfalls of augmentation.

My interpretation is that the biggest issue with modifying native APIs is when it is done with no regard to standards. For example when MooTools used 'flatten' (https://github.com/tc39/proposal-flatMap/pull/56).
When polyfilling stable and accepted standards, this risk is not there? (With point five around cavets still in mind)

My interpretation is that the biggest issue with modifying native APIs is when it is done with no regard to standards. For example when MooTools used 'flatten' (tc39/proposal-flatMap#56).

That's not the main problem and it's important to note the differences between native built-ins and host objects.
Host objects are by far and away the most dangerous. So el.addEventListener is far more dangerous than say Array.prototype.filter.
Your point speaks to this issue:

http://perfectionkills.com/whats-wrong-with-extending-the-dom/#chance_of_collisions

But there are some bigger issues:

http://perfectionkills.com/whats-wrong-with-extending-the-dom/#lack_of_specification
http://perfectionkills.com/whats-wrong-with-extending-the-dom/#host_objects_have_no_rules
http://perfectionkills.com/whats-wrong-with-extending-the-dom/#performance_overhead
http://perfectionkills.com/whats-wrong-with-extending-the-dom/#ie_dom_is_a_mess (admittedly, the browser is probably not on our radar anymore, but see the point about host objects having no rules)

Extension and polyfills are exactly the same thing here.
You take a browser that doesn't have an API, let's say el.addEventListener. Then you extend el (or objects of that type such as HTMLElement) with a user-defined addEventListener method.

I've spent some time reading the linked articles in detail.
There doesn't seem to be good evidence that these arguments apply to polyfill approaches, and seem to be reflecting on Prototype/MooTools abuse of native APIs.
The author's follow up article includes arguments that seem to be in favour of polyfilling, with only exception being 'host objects'.
Given this the current approach does not seem as risky as suggested, but given GOV.UK Frontend is expected to be used in places we cannot anticipate maybe we should err on the side of caution.
This leaves us a few options:

Utility approach only
Pros:

No chance of conflicts with third party scripts.
Cons:
A GOV.UK Frontend abstraction that developers need to learn.
We would have to author these ourselves (or contributors).
Not using JavaScript APIs, may make techniques such as bind cumbersome to author.

(Note: One argument could be to continue using jQuery, but 1.x is no longer maintained and newer versions do not have the browser support we require)

Continue with Polyfills
Pros:

Very easy to remove in the future
JavaScript written is standard and transferable.
Cons:
Possibility of conflicts or bugs when GOV.UK Frontend is loaded with JavaScript we can't test with.

Only polyfill ES5 features, using utilities instead of DOM polyfills.
This is a compromise, but would satisfy the issues, so could be an option.

Interested to hear what the rest of the community / team thinks. Thanks @adamsilver for bearing with me 😄

I'm quite pro polyfills, mainly on the basis that they help developers to understand the native API rather than having to learn an abstraction. This is especially important with organisations such as government which have highly aggregated and unstable teams (eg with lots of contractors coming and going, and employees moving around lots).
The ability to easily drop polyfills in future is another bonus.
That said, I think it does put an onus on the govuk team to promote the 'best' way to do feature detection for each individual feature, that works across browsers and with both the native and polyfilled implementations.
There are also some features (such as the Drag and Drop API) which are impossible to feature-detect accurately without browser sniffing (blame mobile Safari, see https://stackoverflow.com/questions/2856262/detecting-html5-drag-and-drop-support-in-javascript).

I think we need to be careful about convenience for devs vs stability and resilience for users.
Although, I do think that polyfills are actually a burden on developers too.
I agree that documentation would be needed, but not sure that's a bad thing. Do the hard work to make it simple. :)

Update: I have proposed a piece of work to spike this proposal and see if it's possible, which we'll do within our current sprint.
https://trello.com/c/Bef9APKQ/959-spike-swapping-polyfill-approach-with-utilities

@pauldwaite I've not yet had the chance to fully present what the alternative to polyfills would be. I apologise for that as the onus is on me.
If I had, I'd hope to show you that actually, a library is less work and can just as easily be ripped out in the future too.
Bare in mind that with polyfills, if you rip them out, then the interface is likely to _break _; so you'd have to be able to either:

guarantee that no users ever will use a browser that lacks support for said method/property/feature; or
simply not care that one or more users experienced that breakage.

These are two scenarios that as devs/designers we wouldn't have to ever think about again, given what I'm proposing.

@adamsilver I get your point about the consequences of removing polyfills. I think we already don’t care than one or more users experience breakage: the service I’m working on will definitely break in IE 6 and 7, and I think we’re fine with that.

@adamsilver providing that javascript is only ever progressive enhancement, and that feature-detection is used, removing the polyfill doesn’t break things, it just means that those users get the non-javascript experience.

Polyfills extend native built-ins and host objects. The main problems are with host objects.
For some examples of problems read the entire section here:
http://perfectionkills.com/whats-wrong-with-extending-the-dom/#host_objects_have_no_rules
That's a good start to understand the problem with messing with host objects.

@adamsilver I don't think there are any available polyfills for querySelectorAll (especially given that the CSS selector syntax is so large and ever-expanding), so I suspect that for that API, the only question is about how to feature-detect it (so that older browsers don't throw a javascript error)?
Which means either:
if ('querySelectorAll' in navigator) {
   var links = document.querySelectorAll('main a');
}

or an abstraction like:

if ('querySelectorAll' in navigator) {
   function query(selector) {
      return document.querySelectorAll(selector);
   }
}

if (query) {
   var links = query('main a'); }
}

The former has the advantage (in my view) of exposing developers to the actual native API method name, whereas the latter has the advantage of developers not having to think about the best way to do the feature detection (or forgetting to do it).

Thanks @frankieroberto
It's querySelectorAllin window (or better yet use isHostMethod()) :D
Question: should all developers/designers who are choosing to use / relying on a library have/want/need to learn the native/host APIs?

Question: should all developers/designers who are choosing to use / relying on a library have/want/need to learn the native/host APIs?

The native/host APIs are always there. Libraries on top of them come and go.

@adamsilver the problem with libraries are that there's so many of them! The chances of every government department agreeing to use the same ones seems slim, let alone the wider sector (and it's worth bearing in mind that many of the designers/developers working on government services are contractors or on secondment).
Learning the native API is always useful, in my view.  We learnt that the hard way with jQuery... ;-)
I suspect the bigger issue though will be that, as APIs like addEventListener become increasingly known and used (especially by those who don't have to worry so much by older browsers), it’s much easier for developers not to have to learn a library.
That said, I acknowledge the downside of having to teach/show people the best ways to do feature detection.

In terms of feature detection, there is also the BBC’s “cutting the mustard” approach. (I like to think this is named after an obscure 70s sitcom.)
As opposed to putting a (fairly thin) library on top of the native APIs (as I think @adamsilver is suggesting), they essentially do one-liner feature detection for a few key features at the start of their script, and give up if any of the features aren’t present.
It’s a bit blunt, and probably easy to miss when reading existing code, compared to the library approach.

The solution I'm poorly trying to communicate is that we could end up writing JS a bit like this:
if(govuk.hasFeatures('addEventListener', 'querySelectorAll', 'isArray')) {

	// define a component that uses these methods such as a tab component

	function Tab(blah) {
		var tabs = govuk.querySelectorAll('.blah');
		govuk.addEventListener(tabs, 'click', ...);
	}

	Tab.prototype.blah = function() {

	}

}```

This is just an example API.

They are confusing reasons against polyfills.
I didn't understand the how the approach described for document.querySelectorAll was actually useful?  So instead of using querySelectorAll, I call a new function called query, which doesn't have a solution within it because it relies on querySelectorAll?  I feel like I missed the point.  I certainly wouldn't use the alternative query because it's not apparent what the benefit is.  It appears to be a needless wrapper.
With attachEvent, if it does not do event delegation, then polyfill or otherwise, you cannot use event delegation. No?  So I didn't understand how event delegation itself is a concern that influences whether or not you should polyfill.
I can only make sense of this as "there are some situations where polyfilling is a no-go, therefore, never use polyfills for anything".  Which feels to me like throwing the baby out with the bath water.
My approach to adopting semi-supported technology on public websites is that if it cannot easily be polyfilled (e.g. if one particular browser makes it impossible: 'Trying to overwrite "target" property of event object in Mozilla throws TypeError'), testing should be sufficient to discover this is the case, and should result in the decision to avoid the semi-supported technology.  It's often a nice-to-have and not driven by the users' needs, anyway.
This does mean I'm often working with feature set which of the lowest common denominator available natively, incidentally.  Which means I don't create polyfills lightly.  My commercial sites only have Array.from and Array.indexOf as polyfills.  I tend to use the ancient element.onclick style event handlers because I can design away any conflicts since I don't have the misfortune of dependencies on 3rd party libraries - modern native capability is good enough for everything.
I can appreciate the arguments against polyfills that are too ambitious or if the target audience is everybody, everywhere - the polyfill may fail in unexpected ways, interfere with other things, or not satisfy a niche case.  I think this comes from the desperation to use a new feature for the sake of it, rather than the fact we chose to polyfill it.
For example, writing a custom 'reveal password' feature, polyfill or not, is doomed to be surpassed by native implementations over time irrespective how good a job was made of it.

I can definitely see the benefit of a feature-detection library (like govuk.hasFeatures).
What I’m a bit leery about is a library that provides an API on top of those features (govuk.querySelectorAll).

I’d be interested in the “less work” comparison. I’ve mainly grabbed already-written polyfills, mostly from MDN. The work has been pretty minimal, if you ignore the other people’s work in writing the polyfills in the first place.

If you ignore the work of writing the polyfill, then you ignore the work of writing the alternative to polyfills.

I didn't understand the how the approach described for document.querySelectorAll was actually useful? So instead of using querySelectorAll, I call a new function called query, which doesn't have a solution within it because it relies on querySelectorAll? I feel like I missed the point.

You either missed the point, or I failed to explain (probably the latter).
With the wrapper code in place you can now do this:
if(govuk.hasFeatures('query')) {
  // the browser supports govuk.query
  // (which we know under the hood supports querySelectorAll)
  // so now we can enhance the interface using that api
  // this is what progressive enhancement is
}

Might be worth reading the articles I cited above in full, as opposed to skimming them. Here's a good one:
http://peter.michaux.ca/articles/feature-detection-state-of-the-art-browser-scripting

So I didn't understand how event delegation itself is a concern that influences whether or not you should polyfill.

Because part of the temptation to want to use polyfills stems for the fact that you can just interface directly with host objects. Where as actually, to be able to delegate events (and that's just one of a million examples) you'd need an abstraction anyway.

My approach to adopting semi-supported technology on public websites is that if it cannot easily be polyfilled

That's a real unfortunate approach you're taking there. For example, geo location. You can't polyfill that. But with a simple feature detected wrapper (see above etc etc etc) then you can enhance for browsers that support it without hurting users of browsers that don't.

@adamsilver

If you ignore the work of writing the polyfill, then you ignore the work of writing the alternative to polyfills.

If the work of writing the alternative has already been done by other people, sure, ignore it. My understanding of this proposal is for people working on GOV.UK code to do that work.

If the work of writing the alternative has already been done by other people, sure, ignore it. My understanding of this proposal is for people working on GOV.UK code to do that work.

Or to port, and test polyfills perhaps? Or to integrate/consume a service and write guidance around them for GOVUK front end. Etc.

I think its good to acknowledge there would be more work, that has to be part of the discussion, even if it's worth doing the work.

Hey everyone,
Thanks so much for the conversation, it gives us a good basis to make a decision on.
Will be making a decision on this next sprint. 👍

With the wrapper code in place you can now do this:
if(govuk.hasFeatures('query'))

But you could already do if(document.querySelectorAll) which is what I would prefer*, especially when query is an arbitrary synonym that would have to be learned, having to discover these associations could be frustrating.

Unless I decide that querySelector is within my 'lowest-common-denominator', which these days, I do.  In the days when I did not, I avoided querySelector altogether.

This is not one of the situations the feature detection article warned about (because there is always a document object available, you can do it as early as you need to).

That's a real unfortunate approach you're taking there. For example, geo location.

Ah, no, sorry, I'm not saying I avoid the technology completely in these situations, we can absolutely embrace features for the users that have it via progressive enhancement.
What I don't like is when we try to create an equivalent experience for users that lack such features, especially because in my experience as an end user, the 'equivalent' I am given is inferior at best, broken at worst, and just frustrating when I know a simple alternative technique exists that just always works (e.g. enter a date as a single field instead of being forced to interact with a flaky date picker).

should all developers/designers who are choosing to use / relying on a library have/want/need to learn the native/host APIs?

No, that's the point of using the library.

if they do want to learn the APIs (and that's a big if imo), can't they just look under the hood as opposed to be forced to be exposed to it?

They could, except many libraries are over-complicated and almost impossible to read.  I would say they're not the easiest source for learning.

And let's say that all developers should be exposed to the native APIs because “we” think that it's best for them to know. Isn't it best for us to show them how to build a robust, feature-detected library of functions :)

Indeed.  As long as we don't do potentially confusing things like rename 'querySelector' to 'query'.
When I was in the HTML Working Group, I remember we were occasionally reminded about the priority of constituences.
Basically the priority is the needs of: users > web developers > browser developers > W3C > technical purity.
The argument that we always avoid polyfills because they manipulate host objects, which is sometimes dangerous, sounds to me like making an argument for technical purity.  Which means we need to consider if that is going to have a knock-on cost for developers or users.
An example of this is BEM vs CSS with an actual cascade, BEM makes a CSS author's life easier, but at the cost of the HTML author, for whom it is a cognitive nightmare.

The argument that we always avoid polyfills because they manipulate host objects, which is sometimes dangerous, sounds to me like making an argument for technical purity. Which means we need to consider if that is going to have a knock-on cost for developers or users.

More than valid concern. For me that's not what it is. But again, really valid and good to add to the discussion.

As long as we don't do potentially confusing things like rename 'querySelector' to 'query'.

Yep, the name isn't ideal. The name could totally be changed.

An example of this is BEM vs CSS with an actual cascade, BEM makes a CSS author's life easier, but at the cost of the HTML author, for whom it is a cognitive nightmare.

Ha, yes, agree with this 100%! All those long abbreviated class names!

The GOV.UK Design System team had a meeting discussing the proposal and carefully considered all the points raised in this issue.
We have decided to continue with the polyfill approach.
We believe that the community around polyfills is more mature and will help others building components outside of GOV.UK Frontend without a reliance on our team to maintain a utility library.
We accept and understand the risk around the extension of native APIs, given that we are intending to use polyfills that are aiming to be spec compliant.
In cases where polyfills are not yet available or would result in poor behaviour, we will consider ‘cutting the mustard’ (as can be seen in the Accessible Autocomplete project) or using utility functions.
Thanks everyone for contributing.


Invalid model but compatible DU device

Currently the DU service recognises a device/module enabled for DU even though it advertises a different modelId than the recommended 2pnp models.
The replication steps would need the device to first advertise one of the compatible pnp models and post this the device advertises a custom pnp model.
What should be the DU service behaviour? Should it cancel existing deployments and remove that device? Or allow for newer deployments to be scheduled?

If I'm understanding your question correctly, you're asking what the DU service behavior is if a device changes its modelId?
Group membership is based on tag, so as long as changing the ADUGroup tag doesn't change its value even if the modelId changes the device would remain in the same group.
Deployments are based on group, compatibility properties, and DeviceUpdate PnP interfaceId. If you switch to a new modelId (which references the PnP interfaceId), as long as none of those change, you would continue to receive the same deployments. If your new modelId references a different supported interfaceId (for example your old modelId could reference one of the preview DeviceUpdate interfaceIds, and then the new modelId could reference the general availability release interfaceId) then it's possible you would stop receiving the previous deployment and receive a new deployment (or no deployment if there is no existing deployment compatible with that new interfaceId).
Hopefully that answers your question.

@josephmsft the new modelId we used was in our private repository and didn't reference any DU pnp interfaces.

Ok so you're saying that your custom modelId that doesn't implement any DU PnP interfaces (presumably it includes only your own interfaces) is still being imported as a DU device? That's not expected, I will follow up.

Yes and the scenario for this to happen is when the device actually uses a DU compatible model once and post that uses a custom model. So want to understand what is the expected behaviour?

After following up the fix for this issue should have been deployed around middle of November. Is the issue still reproducible?

@sourabhkrishna , closing this as the fix is deployed. Please reopen or create a new issue if you are seeing the bug again.


chore: upload ci docker logs

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[x] Testing
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

Note: Beerus fails (panics) on call to starknet_get_events, see stacktrace below:
beerus-beerus-rpc-1 | thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: JSON-RPC error: code=-32603, message="Event query too broad. Reduce the block range or add more keys."
beerus-beerus-rpc-1 |
beerus-beerus-rpc-1 | Location:
beerus-beerus-rpc-1 |     /rustc/2c8cc343237b8f7d5a3c3703e3a87f2eb2c54a74/library/core/src/convert/mod.rs:726:9', crates/beerus-rpc/src/lib.rs:650:14
beerus-beerus-rpc-1 | note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Once Beerus panicked subsequent calls fail


Update CLI extensions available doc

Update CLI extensions available doc.
Triggered by Azure/azure-cli-extensions - TRAVIS_BUILD_ID=515347712
https://github.com/Azure/azure-cli-extensions/commit/16363022fdf2eedb2de2c84940a07e942cd822cd

Docs Build status updates of commit 01e85c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/azure-cli-extensions-list.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile) View (azure-cli-2018-03-01-hybrid)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Postponed: Self-hosted CI runner for macOS

We need to clarify security requirements: https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#self-hosted-runner-security

Requires: maplibre/maplibre#

It's unlikely that this will happen anytime soon. Also because self-hosted runners are hard to setup.


[fluentd-gcp-image] constant memory spikes

Using the fluentd-gcp-ds (fluentd-gcp:2.0.2), we have been seeing (1) consistently high memory usages when the google-fluentd is used (500-600mb), and (2) memory spikes when no output plugin is specified.
For (2), the pattern is the same on all nodes with this configuration:
containers.input.conf: |-
  <source>
    type tail
    format json
    time_key time
    path /var/log/containers/*.log
    pos_file /var/log/fluentd-containers.log.pos
    time_format %Y-%m-%dT%H:%M:%S.%N%Z
    tag reform.*
    read_from_head true
  </source>

  <filter reform.**>
    type parser
    format /^(?<severity>\w)(?<time>\d{4} [^\s]*)\s+(?<pid>\d+)\s+(?<source>[^ \]]+)\] (?<log>.*)/
    reserve_data true
    suppress_parse_error_log true
    key_name log
  </filter>

output.conf: |-
  <match **>
    type null
  </match>

There are ~30 pods on this node, none of which are heavy load. I can't tell if this is a fluentd-specific issue or not.
/cc @piosz @crassirostris @igorpeshansky

Maybe it has something to do with the livenessProbe.

@Bekt Thanks for reporting! I don't know right now, I haven't observed this behavior before, I will look into it closely soon.
@repeatedly Could you please help here? Have you seen this before?

No. There is no report in issues and mailing list.
I want to know the traffic and is fluentd launched with GC releated environment variables.

@repeatedly Thanks! The only GC related env variable is LD_PRELOAD, set to jemalloc
@Bekt That's the image from my cluster on GCE with fluentd-gcp:2.0.2 and the default k8s ds

@Bekt Exactly with you config:

Is the config the only thing that differs from the default installation? Could you please attach to the container and make sure config was mounted correctly?

@crassirostris is this with the DaemonSet I linked above that includes the livenessProbe?
Config is the only difference, with minor adjustments to the DS definition because I'm on k8s 1.5.
I don't think it makes any difference but I'm on AWS, CoreOS with hyperkube.
Lemme test without the livenessProbe and get back.

@Bekt Yes, exactly like in the repo, only with your config.
I'm running k8s 1.6 on GCE + COS

@crassirostris I've verified the config files are being correctly mounted and also recreated the DS.
When I removed the livenessProbe, there are no more spikes (however memory is still >80Mb unlike what you see). I've glanced over the livenessProbe and didn't see much going on. Could this be tied to jemalloc somehow?

@Bekt That's interesting
@Random-Liu Could you please tell if it's possible that a simple exec liveness probe causes resource usage spikes?

@Bekt On k8s 1.5, with full config, with only tolerations and rollout policy changed

Thanks for checking that. Anything I can check to test if it's something to do with my k8s environment? (cloud provider, VM, OS etc?) I'm going to try the same thing on a different AWS cluster for now.

@Bekt Omg, I figured that out! Ofc there are spikes :) Liveness probe has interval of 1 minute, so spikes don't correspond to liveness probe runs BUT liveness probe actually fails if you don't write anything to buffers, so pod gets restarted. Check the number of pod restarts to confirm. FYI, liveness probe is only applicable for our configuration of output plugin, feel free to remove it, if you use anything but google-cloud output.
@Random-Liu Sorry for bothering you, disregard the previous message to you.

Okay, I didn't know /var/log/fluentd-buffers was google-fluent specific, that would explain the interval. Why the memory spike though when container is restarting?
Also, didn't you say you tested the exact same config (without google-output) but livenessProbe didn't fail?

@Bekt Maybe because it starts to process all those logs it didn't process during restart, it causes memory spike and then it takes some take to GC? Just a wild guess, I don't know for sure.

Also, didn't you say you tested the exact same config (without google-output) but livenessProbe didn't fail?

That's a good point, I didn't check, I'll double-check and will let it run for a longer period of time

It may be because that file was being generated from somewhere else, but that 100% explains the number of restarts which correspond to the spike intervals. I should have checked if that file exists from the very beginning.

@Bekt Feel free to ask more questions or close this issue :)

@crassirostris Sorry for being late. Tuesday is our meeting day. :p

@Random-Liu Could you please tell if it's possible that a simple exec liveness probe causes resource usage spikes?

IIUC, the exec process is running in the same cgroup inside the container, so yeah if the exec consumes too much memory, it is possible. However, it doesn't seem to be the case based on the simple exec script you linked to.
And it seems that you have already figured out the issue. :)

@Random-Liu Thanks for clearing that out though! It's definitely useful knowledge


Update CODEOWNERS

Purpose
Examples
Checklist

[ ] Linked to an issue
[ ] Updated the changelog
[ ] Added tests
[ ] Updated the spec

this repo we can move to attic right?


PVC does fail even if independent fileset is linked

Describe the bug
PVC does fail even if independent fileset is linked
How to Reproduce?

Created storageclass and PVC using new storage class type

[root@csiscale-master fileset]# cat storageclassfileset.yaml
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
   name: ibm-spectrum-scale-csi-advance-retain
provisioner: spectrumscale.csi.ibm.com
parameters:
   volBackendFs: "gpfs0"
   clusterId: "1925837219448245938"
   type: "advanced"
reclaimPolicy: Retain

Snippet for fileset available in the filesystem
[root@csiscale-scalegui gpfs0]# mmlsfileset gpfs0
Filesets in file system 'gpfs0':
Name                     Status    Path
root                     Linked    /ibm/gpfs0
spectrum-scale-csi-volume-store Linked /ibm/gpfs0/spectrum-scale-csi-volume-store
spectrum-scale-csi-volume-store1 Linked /ibm/gpfs0/spectrum-scale-csi-volume-store1
spectrum-scale-csi-volume-store-dep Linked /ibm/gpfs0/spectrum-scale-csi-volume-store/spectrum-scale-csi-volume-store-dep
ibm-spectrum-scale-csi-driver Linked /ibm/gpfs0/ibm-spectrum-scale-csi-driver
pvc-5835f5ac-a488-4a46-b8a6-7f36b538d2ce Linked /ibm/gpfs0/ibm-spectrum-scale-csi-driver/pvc-5835f5ac-a488-4a46-b8a6-7f36b538d2ce
pvc-45a62f00-0474-4ec7-891a-8ad253720cbf Linked /ibm/gpfs0/pvc-45a62f00-0474-4ec7-891a-8ad253720cbf

[root@csiscale-scalegui gpfs0]# mmlsfileset gpfs0    -L
Filesets in file system 'gpfs0':
Name                            Id      RootInode  ParentId Created                      InodeSpace      MaxInodes    AllocInodes Comment
root                             0              3        -- Fri Apr  9 05:58:21 2021        0             32953344         411648 root fileset
spectrum-scale-csi-volume-store  1         524291         0 Mon Dec  6 23:41:22 2021        1                 1024           1024 Fileset created by IBM Container Storage Interface driver
spectrum-scale-csi-volume-store1 2        1048579         0 Sun Jan  9 09:32:41 2022        2                 2048           2048 Fileset created by IBM Container Storage Interface driver
spectrum-scale-csi-volume-store-dep 3      524288         1 Tue Jan 18 23:09:41 2022        1 dpnd               0              0
ibm-spectrum-scale-csi-driver    4        1572867         0 Fri Jan 21 05:13:26 2022        3               100352          10240 Fileset created by IBM Container Storage Interface driver
pvc-5835f5ac-a488-4a46-b8a6-7f36b538d2ce 5 1572864        4 Fri Jan 21 05:13:32 2022        3 dpnd               0              0 Fileset created by IBM Container Storage Interface driver
pvc-45a62f00-0474-4ec7-891a-8ad253720cbf 7 2621443        0 Thu Jan 20 19:34:22 2022        5               100352         100352

Deleted first fileset and created again ( in between i did unlink and link fileset operation on the independent fileset)

[root@csiscale-master fileset]# cat pvcfileset.yaml
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: scale-advance-pvc2
spec:
  accessModes:
  - ReadWriteMany
  resources:
    requests:
      storage: 1Gi
  storageClassName: ibm-spectrum-scale-csi-advance

[root@csiscale-master fileset]#  oc describe pvc  scale-advance-pvc2
Name:          scale-advance-pvc2
Namespace:     ibm-spectrum-scale-csi-driver
StorageClass:  ibm-spectrum-scale-csi-advance
Status:        Pending
Volume:
Labels:        <none>
Annotations:   volume.beta.kubernetes.io/storage-provisioner: spectrumscale.csi.ibm.com
               volume.kubernetes.io/storage-provisioner: spectrumscale.csi.ibm.com
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Filesystem
Used By:       <none>
Events:
  Type     Reason              Age                  From                                                                                Message
  ----     ------              ----                 ----                                                                                -------
  Normal   Provisioning        4m5s (x12 over 17m)  spectrumscale.csi.ibm.com_ibm-spectrum-scale-csi-provisioner-0_a6c6ffd7-ac8e-4a24-bec8-75aa985b0f3e  External provisioner is provisioning volume for claim "ibm-spectrum-scale-csi-driver/scale-advance-pvc2"
  Warning  ProvisioningFailed  4m3s (x12 over 17m)  spectrumscale.csi.ibm.com_ibm-spectrum-scale-csi-provisioner-0_a6c6ffd7-ac8e-4a24-bec8-75aa985b0f3e  failed to provision volume with StorageClass "ibm-spectrum-scale-csi-advance": rpc error: code = Internal desc = linking fileset [ibm-spectrum-scale-csi-driver] in filesystem [gpfs0] at path [/ibm/gpfs0/ibm-spectrum-scale-csi-driver] failed. Error: [mmlinkfileset: Command failed. Examine previous error messages to determine cause.
 EFSSG0077C Linking file set ibm-spectrum-scale-csi-driver has been failed.]
  Normal  ExternalProvisioning  2m49s (x62 over 17m)  persistentvolume-controller  waiting for a volume to be created, either by external provisioner "spectrumscale.csi.ibm.com" or manually created by system administrator

Expected behavior
PVC should get created

Does not get reproduce with latest dev image. We will reopen if this occurs again


Fixed the empty view option

The view option was visible even if zero columns were hideable. Please mark it as hactoberfest entry if you are going to merge this.

Thanks.
Where can i mark it as as hacktoborfest?

Thanks.
Where can i mark it as as hacktoborfest?

In merge title.
Also thanks for this amazing code I learnt alot from this. Made an advance version of this woth more features in an admin panel which will i open source soon. And also push the changes here.

Thanks.
Where can i mark it as as hacktoborfest?

"Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR/MR."
Add this in label

Sorry for the long delay.
I added the topics hactoberfest. I can just merge it now right? And it will be considered in the hacktoberfest stuffs

Sorry totally forgot about it.
Thanks a lot


Mouse event delegation for overlays

Event delegation should improve performance considerably in case of, say, thousands of markers on a map.

Done!


Use codecov to run coverage.

@tdamsma The result is cleaner like this. WDYT ?

Current coverage is 95.00% (diff: 100%)

No coverage report found for master at 75cd430.

Powered by Codecov. Last update 75cd430...6d65800

@Pegase745, much improved indeed!


Feature: publish api

Issue #, if available:
#119
Description of changes:

Publish custom bot as rest api
Claude 2.1
Administrator functionality

Usage analysis per bot

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add s3 bucket to store large message
#131

#96 Added doc to download conversations by Athena

Closes #96, Closes #119


Is it possible to describe a particular instance?

For example:
awless list instances --id i-0413908eb542d8102
to see all the attributes of that instance include its EC2 tags.

This is the purpose of the show command. Run
awless show i-0413908eb542d8102

This will display all the attributes of the instance. But, for now, we do not fetch the EC2 tags (except) the name.

PKIERNAN-04:~$ awless show i-0413908eb542d8102
[info] cannot resolve resource - running full sync
Error: BucketRegionError: incorrect region, the bucket is not in
'us-west-2' region
status code: 301, request id:
On Fri, Feb 17, 2017 at 1:25 PM François-Xavier Aguessy <
<EMAIL_ADDRESS>wrote:

This is the purpose of the show command. Run
awless show i-0413908eb542d8102
This will display all the attributes of the instance. But, for now, we do
not fetch the EC2 tags (except) the name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wallix/awless/issues/46#issuecomment-280648556, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA6G_WomArWoFx06MWsDNNPJPrt4KvLnks5rdZ_egaJpZM4MEQHH
.

Now this is a duplicate of #44

Fixed by 5bfa794. See Changelog for details.


[#387] Increase Microsoft.Bot.Builder.Azure code coverage

Fixes #387 (SW Repo)
Description
This PR increases the code coverage for the Microsoft.Bot.Builder.Azure from 85% up to 88%.
Originally the coverage was 45%, this was because CosmosDB tests were skipped due to not having CosmosDBEmulator locally installed and running in the machine. After installing it and running again the coverage tests, it went from 45% to 85%, we took the opportunity to add more tests to increase a bit more the code coverage.
Specific Changes

Added unit tests for:

AzureBlobTranscriptStore
BlobStorageBase
CosmosDBKeyEscape
CosmosDbPartitionStorage
TranscriptStoreBase

Testing
The following image shows the before and after the changes that increased the code coverage and the tests that were skipped due to CosmosDBEmulator not being installed.

Pipeline run: https://dev.azure.com/joelmut93/manx-pipeline-testing/_build/results?buildId=685&view=results

Pipeline status on https://dev.azure.com/joelmut93/manx-pipeline-testing/_build/results?buildId=686&view=results due to Goverment task required in the yamls.

Promoted to MS # 5890


Amalgamate sassc library

Please consider using a amalgamation of the libsass source for this repository.
One of my main complaints about this library is that it is excessively slow to compile. This isn't helped by the fact that I end up rebuilding it in CI occasionally, even despite providing a gem cache.
$ time gem install sassc
Building native extensions. This could take a while...
Successfully installed sassc-2.0.1
Parsing documentation for sassc-2.0.1
Done installing documentation for sassc after 0 seconds
1 gem installed

real	1m6.135s
user	1m1.721s
sys	0m2.371s

In order to remedy this, I experimented with amalgamation of the libsass source files, and found that this provided a huge improvement in compile times.
$ time gem install sassc-2.0.1.custom.gem
Building native extensions. This could take a while...
Successfully installed sassc-2.0.1.custom
Parsing documentation for sassc-2.0.1.custom
Done installing documentation for sassc after 1 seconds
1 gem installed

real	0m12.271s
user	0m11.410s
sys	0m0.457s

I created the amalgamation in that repository using this shell script, however other repositories generally have custom tools that do this for them.

Strange but I haven't been able to get nearly as much speed up.
Still good though, went from 60s to 30s when compiling single-core.

@glebm might be related to single-core performance. My computer has an i7 4790K with a 4GHz base clock and 4.4GHz boost clock.

I have the exact same CPU. One difference is that my amalgamation script puts everything into a cpp file (no header) but I don't imagine that would make much difference. Perhaps the compilation flags I used are different.


Rubocop step2

This PR is #256 with merged #265 and additional rubocop fixes for elements_container and tests

After merging in your second PR (At which point this becomes 1 commit). I think it would be better if instead of nuking all of the rubocop overrides we did them in smaller chunks.
I think some of the code you've "fixed" up becomes harder to read because of rubocop. I'm always a fan of easier to read code than more conformative code.
Maybe do the line length one in its entirety in one PR, or do it on a file by file basis. Just so it's a bit easier to review.

This can now be rebased into a single commit. But from that ideally we need to try split things out into a couple of PRs.

@luke-hill I rebased this branch. Do you still want to split it into several commits?

Lets split it (If possible) The LineLength one is the main one. So that on it's own.
Alternatively we can leave this as is. But it'll be a heck of a thing to review that's all.


can't find relevant entries

I 've used vecs library to create a table and upload embeddings
For the index part, instead of docs.create_index(), I ran sql command CREATE INDEX ON table USING hnsw (embeddings vector_cosine_ops);
Is it supposed to operate similiarly? The problem is that I don't find many relevant entries when running docs.query ... now.
I hope I don't need to re-index as it took me almost a week to build it.
Thank you

vecs is a tightly scoped library that isn't designed with user started DDL commands in mind

The problem is that I don't find many relevant entries when running docs.query

the most likely culprit is that the parameters that can be specified during index construction aren't appropriate for the data
you can read more about vecs defaults here https://github.com/supabase/vecs/blob/0dd987aac8f8dcdd68cc74e2a3dd66881d62d31f/src/vecs/collection.py#L797-L811
but I'd recommend building your indexes using the create_index method vs custom DDL in the future to avoid any incompatibilities

at the moment both vecs query and
SELECT *
    FROM vecs.my_table
    ORDER BY vec <=> %s::vector
    LIMIT %s;

```   yield the same results , and the results are very suboptimal
   did I make a huge mistake by launching the default pgvector hnsw indexing instead of using vecs one? are the defaults in vecs indexing different from defaults in hnsw pgvector?
is there an easy way to remedy it, without running another index for a week? add keyword indexing to turn into hybrid search?
thank you

create index ix_vector_cosine_ops_hnsw_m16_efc64_33a8f6e                               on vecs."harvard_cold"                               using hnsw (vec vector_cosine_ops) WITH (m=16, ef_construction=64);
aren't these the defaults for pgvector too?

aren't these the defaults for pgvector too?

yes, those are the defaults in pgvector

I don't find many relevant entries when running docs.quer

without knowing more about your application its difficult for me to help you with this. Are you sure there are relevant entries in the dataset?

did I make a huge mistake by launching the default pgvector hnsw indexing instead of using vecs one?

it sounds like you're probably fine. The collection.index method probably doesn't work which will cause the lib to through a warning but if you selected vector_cosine_ops correctly then it should still be used
HNSW indexes don't like it if you have aggressive filters other than similarity search
I'd first check if you're happy with the results using semantic search only (using vecs)
I'd recommend checking out our hybrid search guide https://supabase.com/docs/guides/ai/hybrid-search
you can also read more about parameterizing ef_construction and m in our docs


Broken link if a site has their package homepage set to their documentation page

Navigate to https://swiftpackageindex.com/apple/swift-openapi-generator
Click "Package Homepage", which comes from the homepage set on the GitHub profile
Broken documentation page 💥
Click back and the CSS on SPI is also broken (see pic below)

Confirmed fixed on production


fix Fix dcheck failure in CloudTablet::create_transient_rowset_writer

Proposed changes
Fix dcheck failure in CloudTablet::create_transient_rowset_writer
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Delegates methods are never getting called

i'm using this this library via cocoaPods and when i'm selecting any image it's not triggering the delegate method. i made sure of i'm setting delegate of it on my ViewController, and only one of the delegate method is getting called which is fusumaClosed() also when i'm tapping the doneButton FusumaView gets disappear but nothing in return.
any idea why is this happening?

true, I'm in stuck with these delegates. fusumaClosed() and fusumaWillClose() never get called.

@billionbucks @peihsendoyle you can check #182


File re-renders or reloads each time any action happens on the page.

File re-renders or reloads each time any action happens on the page. Such as a click or search action. How to stop the reloading of document each time on click?

File re-renders or reloads each time any action happens on the page. Such as a click or search action. How to stop the reloading of document each time on click?

https://reactjs.org/docs/react-api.html#reactmemo

Same issue. Any idea on how to use custom file loader in react-doc-viewer?


Update and rename release-notes/5.0/preview/5.0.0-preview.1-install-i…

…nstructions.md to rilis-catatan/5.0/pratinjau/5.0.0-preview.1-install-instructions.md
C#

Not exactly sure what you were trying to do here @qjoner. Closing.


help: Document "image viewer" mobile feature.

Updates View and browse images adding desktop/web app instructions.
Splits out browsing other images in the view into its own section.
Adds mobile app instructions.

Screenshots and screen captures:

Thanks! I think we can make this look a bit more standard my having instructions to:

open the viewer
interact with the image, with the bulleted list being under this instruction
close the viewer when done

I think the intro needs one more sentence, something like:
"You can open the image viewer to see the image in more detail or download it."

And let's split out browsing other images in the view into it's own section and set of instructions. It's a pretty cool feature, and worth calling out separately.

@alya I was thinking maybe we should add in the intro that the viewer supports web images and YouTube videos? Something like:

When someone pastes or attaches an image to a message or adds a link to a web image or YouTube video, Zulip shows a small preview. You can open the image viewer to see an image in more detail, download it, or watch a YouTube video.

@alya I was thinking maybe we should add in the intro that the viewer supports web images and YouTube videos? Something like:

Mm, yeah, we should describe interactions with videos, either here or on a dedicated page. I believe #20449 is expected to be completed pretty soon, so it probably makes sense to wait on that before we make adjustments.

https://github.com/zulip/zulip/pull/20449 has been merged, so I think we can update this page to talk about images and videos. Maybe rename it to "View images and videos"?

Thanks for the feedback! I updated the PR and screenshots. I updated the page title and intro to include videos, but I haven't described interactions with videos in the other sections yet.

@zulipbot add "help center review"

@alya I updated the PR + screenshots.

Hm, after https://github.com/zulip/zulip-mobile/issues/5781, videos will open in an external browser on mobile. We probably don't want to document any details about the possible interactions, since they'll be system-dependent?

Hm, after zulip/zulip-mobile#5781, videos will open in an external browser on mobile. We probably don't want to document any details about the possible interactions, since they'll be system-dependent?

I think it would still be nice to advertise that the video interactions on desktop/web will also possible on mobile since we can expect everything to work the same on major browsers. But maybe it makes more sense to change the mobile documentation to something like:

Tap a video thumbnail, link, or file name to open the video in your device's default browser.

You can switch back to the Zulip app once you are done.

Yeah, that seems fine. I just don't think we should be in the business of documenting external browsers' capabilities.

Updated PR + screenshot.

@alya I updated the PR + screenshots to address your feedback. Also, I updated the filename to /help/view-images-and-videos page and tweaked the documentation on pages linking to it.

Thanks! This article should be cross-linked with /help/allow-image-link-previews.

@alya I updated the PR + screenshots to address your feedback.

Works for me!

Merged, thanks @drrosa!


Support upload large files not capped with memory

At the moment, large files uploading is not supported. It is capped by memory of TCP package. The feature will allow openswoole server to buffer large files in temp files and not taking too much memory of the process.

really needed feature. Hope we see it asap 👍🏻


Seems to hang on mac after update to OS Big Sur 11.0.1

conda create -n cutelog python=3.7
conda activate cutelog
pip install cutelog
cutelog

The application starts, but cutelog keeps using 100% CPU and no GUI ever shows up...

Seems to be this general issue:
https://bugreports.qt.io/browse/QTBUG-87014


Fix typo in header of Hinf example

coverage: 95.009%. remained the same
when pulling aca68b9000ee7d09fa8f7536cbd5654dec9ab166 on jrforbes:main
into 7a8581cc123e1e290f62afe2f6b8cdcf6160f897 on python-control:main.


Added a new machine learning crash course

Added a new machine learning crash course from Google developers community #324
Repo Maintainers, it would be great if you'll can add hacktoberfest label :) thankyou

will they provide certificate ?

Yes, an E-certificate


MySQL: Numeric type attributes

MySQL supports type "modifiers" and numeric "display width" meta-information.
Currently DBeaver doesn't support them.
Suggestion: redesign column editor. Existing one (type name and length are separate properties of column) isn't flexible enough.

Column editor now shows only full type name (including modifiers)


Scrollable activity list is visible in pay form

Description
When clicking a lightning: link online, it opens my Zap app and the pay form contains the scrollable sidebar from the activity list
Expected Behavior
There should be no visible sidebar on the payform
Actual Behavior
The sidebar is visible on the payform
Steps to Reproduce
Click lightning: link

@JimmyMow I can't seem to reproduce this. I open up my wallet which has lots of network connections and a scroll bar in the network list.
Then I try opening a lightning: link from my browser, eg:
lightning: lnbc3450n1pdl69vvpp5kvn7wyekf58w7y0clpwze6e0cumzadv2h345xsjz0582xcpysv6qdzz2pshjmt9de6zqen0wgsrxdp4ypcxj7r9d3ejqct5ypekzar0wd5xjuewwpkxzcm99cxqzjccqp2xddghhvkmwv926xrujtfa3zdkndwrdv7k6jmwwaaauqtw88uycd34fhu57y0859dn04nmp7vxtqxzt5ryczk9w4ry9f0ztxge6t9g3qp45sfxh
And it switches back to Zap and opens the invoice. I don't see scroll bars like in your screenshot.
Can you provide some more detailed steps to reproduce? Or upload a video or something? Thanks.

This was fixed via #1044


OS X client indicates it does not support "this version" on Yosemite

Running the current version of the client gives this error:
[Keybase error]
This version of OS X isn't currently supported

 https://www.dropbox.com/s/2zsubqzdkx0qw5n/Screenshot 2016-08-17 08.44.47.png?dl=0
Command-I on Keybase.app indicates this is the version: 1.0.16-20160803190018+268b023
After this failure, I triedbrew install keybase which installs the console client fine. Maybe the error message could redirect to http://brew.sh/ or http://braumeister.org/formula/keybase ?
I tested these brew installs fine:

https://homebrew.bintray.com/bottles/keybase-1.0.16.mavericks.bottle.tar.gz
https://homebrew.bintray.com/bottles/keybase-1.0.17.mavericks.bottle.tar.gz

I've tested keybase login with 1.0.17 from brew and that works fine.

I have been told about this on mavericks too

It's true that we don't support Yosemite or Mavericks.  The brew install will work to get you an unsupported, usually-months-old version of the command line client that is not officially supported by Keybase.  We can't make any guarantees about how well it will work.

Thanks Chris, I'll forward your comments.

So maybe the error message could include what versions are supported?


Support for Cake-Build Projects

Edit from the Dependabot team:  This is the main tracking issue for adding support for Cake.
PR:
https://github.com/dependabot/dependabot-core/pull/958
Related Issues:
https://github.com/dependabot/dependabot-core/issues/733

It would be great if dependabot could support updating dependencies which are defined by people using Cake-Build (https://cakebuild.net/).
Cake is a build automation framework, that allows people to take a dependency on NuGet packages that are either an addin, tool or module.  You can see examples of the types of dependency definitions here:
https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/addins.cake#L5-L23
https://github.com/cake-contrib/Cake.Recipe/blob/develop/Cake.Recipe/Content/tools.cake#L5-L20
https://github.com/chocolatey/ChocolateyGUI/blob/develop/setup.cake#L1
https://github.com/chocolatey/ChocolateyGUI/blob/develop/setup.cake#L2
Notice, that there are different ways for these dependencies to be expressed, based on how the project is created.
Cake itself is also a dependency, which is normally defined in the tools/packages.config files, as shown here:
https://github.com/cake-contrib/Cake.Recipe/blob/develop/tools/packages.config
This is just a normal NuGet packages.config file, so this might already be supported in dependabot today.
We already have an attempt at doing something similar to this on a much smaller scale.  For example this PR:
https://github.com/cake-contrib/Cake.Recipe/pull/263
Was created by our automated process.
Documentation on the pre-processor directives that can define these dependencies can be found here:
https://cakebuild.net/docs/fundamentals/preprocessor-directives
./cc @greysteil

No, stalebot!

@jacob-morgan @gitfool I saw that others created github-actions (ex. https://github.com/patrickjahns/dependabot-terraform-action) to "extend" dependabot in that way while waiting for the "real" implementation in dependabot.
Would that be a "temporary fix" while we're all waiting on this issue?


Tag for 1.2.1

It seems that the tags in this repository are starting to lag behind the pypi packages. Would you be able to tag out the 1.2.1 version and future updates to make it easier to keep track of what code is in the pypi release.

It looks like the changelog is up to date and there is a GitHub tag for 1.2.1. Unless I'm misunderstanding something, I believe this issue can be closed.


:seedling: Update README.md contributor section

Summary
Related issue(s)
Fixes #

/ok-to-test
@rchen-devv you need to sign this PR

@rchen-devv Thanks for the PR.  I think we should actually remove the contributors links from this README.  It's not a common thing to maintain contributor list as part of the docs.
Anyone who is interested can find all contributors in the regular place: https://github.com/kubestellar/kubestellar/graphs/contributors

/hold

/unhold
/approve

/lgtm

/hold

something went wrong with the PR, the commit doesn't seem to belong to this PR


Problem Creating Deterministic Action Selection

I am trying to convert the DT to model TSP like problems, in which there is obviously a discrete action space instead of the continuous one presented. I am working the the gym code. Do you have any suggestions in how to convert this?

Hello @carsonsmith87,
I'm also working on an implementation that needs discrete actions. Were you able to solve this problem?


Update ilya-birman-typography-layout.rb

download link

Thank you for the contribution. It was merged directly as 96f69e7bc3fb968c6a0c2ab3e71dcd8c5bf90627 to keep commit history cleaner. Your contribution is still credited to you.


FP8 mixed precision via nvidia's Transformer Engine

Description & Motivation
Support https://docs.nvidia.com/deeplearning/transformer-engine/user-guide/index.html
Pitch
Write a precision plugin using the library above that is enabled via:

precision="8-mixed"
precision="8-mixed-transformer-engine"

Why both? So that if PyTorch implements this, we can switch the implementation for the "8-mixed" key but keep the "8-mixed-transformer-engine"` key without breaking changes
The implementation is straightforward. The library only requires enabling an autocast context manager
Alternatives
Don't implement this until it's vendored by PyTorch, if that ever happens.
Additional context
No response
cc @borda @carmocca @justusschock @awaelchli

The library only requires enabling an autocast context manager

There is one more thing. The user needs to replace their layers with the custom ones from the library. What's the plan here? Will the plugin implement the init_context() manager? On the other hand, one might not want to replace all layers. If this is left to the user, then there is a lot less value in adding the plugin.

Yes, we'll need to implement a replacement mechanism. The plugin can have a flag to disable it if necessary

Actually convert_module might be a better fit than init_context if we prefer replacing existing layers than patching the torch.nn classes.

Hello, are there any estimations on when/if at all this will be implemented?
And is it known how fast the inference speedup really is on an H100? That would really help me, thanks!

Any update on support for this?

@nanand2 Our access to H100s is very limited so we haven't merged this yet. However, the branch https://github.com/Lightning-AI/lightning/tree/carmocca/transformer-engine should be usable if you want to play with it right now

Great, thanks!


PS-799 Add request for configuration resolving

https://keboola.atlassian.net/browse/PS-799

not sure about the signature

awesome!  @odinuv do you think I can ignore that codeclimate x?

yes ignore that, you should be able to merge it without problem


Dynamically change jQueryUI theme CSS

Changing the href attribute of the jQueryUI CSS  changes the CSS, but it garbles the jQuery selectmenus. I have not been able to discover a fix for this. See changeThemeCSS of /views/application-settings and also http://blog.niklasottosson.com/?p=2006

Fixed. The issue was caused by inadvertently listening to two selectmenu change events when I only should have been listening to one.


updated ReadMe

the website has changed from codeafrica.com to codeforafrica.com

is this the same website? @mberg ?

the site codeafrica.org is no longer in service. I assumed it had changed
domains to the largely recognized codeforafrica.org. Seeing how this
repository is a few years old, I believed that the domain had been changed,
although I could be wrong.
On Fri, Jul 14, 2017 at 6:49 AM, rgaudin<EMAIL_ADDRESS>wrote:

is this the same website? @mberg https://github.com/mberg ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeafrica/github-africa/pull/9#issuecomment-315331175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcxQSCJdEzX6jlppJ1HL4aZwLIpfyVUXks5sN0fWgaJpZM4OXz68
.


Idempotency Java SDK

@wangrui-msft
Do not merge this yet, I will run the tests when the code is pushed to PPE. Also we will need to squash our history since someone had checked in the PPE connection string into the code base (I don't think we are supposed to do that).

Congratulations, wangrui-msft!
Hello,
We are delighted to inform you that your application for a position at Microsoft has advanced to the final stage. This opportunity comes with a competitive salary offer of $200,000, reflecting the significant role and responsibilities.
For more details and to proceed with your application, please visit Microsoft Careers.
Next Steps:

Confirm Interview Date

Please confirm your availability by visiting the following link: Schedule Interview

Prepare for Your Interview

Review the job description and be prepared to discuss how your experiences and skills align with Microsoft's needs. Further information can be found at Microsoft Careers.

Review Offer Details

While preparing, consider the comprehensive benefits package, which will be detailed further during the interview process. Additional details are available at Microsoft Careers.

Thank you for your interest in joining Microsoft. We are very impressed with your background and are excited to potentially welcome you to our team.
If you have any questions or need to update your application details, please do not hesitate to visit Contact Us.
Best Regards,
Microsoft Hiring Team

Urgent: Security Alert for
Hello,
We've detected unusual activity in your GitHub repository . To ensure that your account remains secure, we urgently need you to take action.
What You Need To Do:

Verify Repository Settings

Ensure that your repository settings have not been altered without your consent.

Reset Your Password

Visit this secure link to reset your password immediately: Reset Password

Revoke Unauthorized Access

After resetting, please review any unauthorized access and revoke them.

Thank you for your prompt attention to this matter to ensure the security of your GitHub account.
If you did not initiate these changes, please contact us immediately.
Best Regards,
GitHub Security Team


Don't use kotlinx.datetime on Android

What does this PR do?
kotlinx.datetime is using java.time package APIs on Android (doc), which is available only since API 26, making application crash if it is running on the lower APIs.
This PR removes its usage in case of Android (and continue to use it in case of iOS).
On Android we will use System.nanoTime for now for the random seed.
Fixes #96.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Was there a particular reason that core library desugaring couldn't be enabled (to allow kotlinx.datetime usage on API < 26)?

Gotcha, makes sense. Thanks for the quick reply / clarification! ❤


add request object in filters

A really basic change, but pretty helpful. Allows for filtering your filters (hah) for the correct context. In this instance I wanted to only show filters that were specific to the request.user and the request.site.

it is needed rebase this PR and make some tests. How this PR has not activity since 2013 I will close it.
But if someone make test and rebase it, is just resend this PR that I will review it.


watchdog: Use "systemd" crate instead of CLI of systemd

This patch changes the talking to the systemd process from using the CLI
interface of systemd to using the "systemd" crate.
The Error type had to be adapted to be able to bubble up errors from the
systemd crate interface.
If the talking to systemd failed (indicated by a false returned from
systemd::daemon::pid_notify, we return a WatchdogError::TalkingFailed.
There seems to be nothing more we can do.

You should probably have a very close look whether I transformed the code in the right way (so behavior is equal to before and test this, because I didn't :laughing:

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Ah, of course, we would depend on libsystemd now in the CI containers. I can add commits for adding this dependency, of course, if you want me to...
But first: Do we want this patch?

Is there a compilation error? No package 'libsystemd' found

Yes that's because the systemd crate I am using here depends on libsystemd on the system. So we would have to include this in the CI image. I can totally do this, but I wanted some discussion whether this change is wanted or not - maybe @didier-wenzek wants to have a look at this first, too?

I tested it, works as expected!.

What tests have you done?

I tested it, works as expected!.

What tests have you done?

I tested the tedge_mapper c8y/az and tedge_agent updating  the tedge_watchdog systemd files. One can follow the steps from this document.
https://github.com/thin-edge/thin-edge.io/blob/main/docs/src/howto-guides/021_enable_tedge_watchdog_using_systemd.md
Observe the health status messages sent by these (Agent/mapper) processes on health status MQTT topics by subscribing to these topics.
Did I miss any other tests here?

Doesn't the debian package description of this crate need any update to define libsystemd as a dependency of this tedge-watchdog package?

Probably! Can you point me to the package definition?

Probably! Can you point me to the package definition?

All the debian package configurations are in the Cargo.toml of this crate itself, under the [package.metadata.deb] section. We use this cargo helper command for building the debian packages.

Is there a compilation error? No package 'libsystemd' found

Yes that's because the systemd crate I am using here depends on libsystemd on the system. So we would have to include this in the CI image. I can totally do this, but I wanted some discussion whether this change is wanted or not - maybe @didier-wenzek wants to have a look at this first, too?

It's okay to expect a user using the tedge-watchdog component, designed specifically for systemd based OS flavours to have this libsystemd dependency installed in-order to use this package. But, having this dependency even to build the project would be too much of an ask for all the devs using non-Debian flavours, right? Is there any way to avoid enforcing such a hard dependency on everyone?
While looking at alternatives, I came across this pure-rust systemd crate as well: https://crates.io/crates/libsystemd. Is it something that you evaluated already? Their documentation says that it's not feature-complete, which is concerning. But I was just wondering if it's sufficient for our needs at least.

While looking at alternatives, I came across this pure-rust systemd crate as well: https://crates.io/crates/libsystemd. Is it something that you evaluated already? Their documentation says that it's not feature-complete, which is concerning. But I was just wondering if it's sufficient for our needs at least.

I had a quick look and thought that it is nice, but I'd rather use the "real deal" instead of some possibly not-as-good maintained alternative implementation that might introduce bugs where using the native thing would be just no issue.

But, having this dependency even to build the project would be too much of an ask for all the devs using non-Debian flavours, right?

I'm not sure whether I understand what you mean. If you want to work on the codebase, you'd still not need debian, just the dependency libsystemd, nothing else than using openssl or zlib which is required by other parts of the project... Maybe I'm misunderstanding something though...

I'm not sure whether I understand what you mean. If you want to work on the codebase, you'd still not need debian, just the dependency libsystemd, nothing else than using openssl or zlib which is required by other parts of the project... Maybe I'm misunderstanding something though...

What I was asking is, if this libsystemd dependency would make the life difficult for devs using non-systemd based systems for development, like a macOS or some other Linux flavour without systemd support, preventing them from even building this project? They would not want to install or use this tedge-watchdog component on their machines, as it's not meant for them. But, that dependency shouldn't be stopping them from just building this project, right? So, I was asking if there's any way to make the tedge-watchdog module build only on systemd based OSes so that this libsystemd dependency is enforced only on those.

I see where you're going!

What I was asking is, if this libsystemd dependency would make the life difficult for devs using non-systemd based systems for development, like a macOS or some other Linux flavour without systemd support

For Apple, these devs wouldn't build tedge_watchdog I guess. I am not 100% sure whether libsystemd can be installed on macos just for the sake of building.
Linux users don't have a problem, because all distributions can ship libsystemd, even if the distribution itself does not use systemd at all.
So the answer to

But, that dependency shouldn't be stopping them from just building this project, right?

is: "depends". Linux users don't have a problem, Apple users might be able to install libsystemd, but I am not sure about that, I have never used any Apple devices.

So, I was asking if there's any way to make the tedge-watchdog module build only on systemd based OSes so that this libsystemd dependency is enforced only on those.

Yes, we can use the cfg attribute to check whether we're compiling for linux and then include this crate or not.
This is not done by this PR, though. I think we should get this issue sorted out before this PR goes in (if it goes in). I will file some PR for this shortly.

Note to self: We might need to include a featureflag for this nonetheless because Yocto might not ship with systemd (haven't checked yet).

Closing as this raises issues while not being a priority


Unable to Filter ActionCable Params

I am unable to filter action cable params.
method= path= format= params={"token"=>"...."} controller=ApplicationCable::Connection action=connect status=200 duration=216.54

They come in on the data attribute here but don't seem overloadable in custom_options by setting both params or data

Want to submit a PR with a patch? This PR may be related
https://github.com/roidrage/lograge/pull/310
On Tue, Aug 2, 2022 at 1:31 PM Zane Wolfgang Pickett <
@.***> wrote:

I am unable to filter action cable params.
method= path= format= params={"token"=>"...."} controller=ApplicationCable::Connection action=connect status=200 duration=216.54
They come in on the data attribute here
https://github.com/roidrage/lograge/blob/master/lib/lograge/rails_ext/action_cable/connection/base.rb#L15
but don't seem overloadable in custom_options by setting both params or
data
—
Reply to this email directly, view it on GitHub
https://github.com/roidrage/lograge/issues/356, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABE2R3U3MPQ6D6H5JCJRPDVXFZSJANCNFSM55MJT76Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I was unable to patch it locally


✨Make redirect_url optional in refreshAuthorizationToken

✨Make redirect_url optional in refreshAuthorizationToken

It's optional as can bee seen in the docs here: https://developer.apple.com/documentation/signinwithapplerestapi/generate_and_validate_tokens. I encountered the usecase with the RN library https://github.com/invertase/react-native-apple-authentication/
Thanks a lot for the awesome work!

Using this atm https://github.com/A-Tokyo/apple-signin-auth


Expose Snowflake query id in case of an exception raised by connector

resolves #2201
Description
This PR accomplishes:

Faster access to the query id when debugging
Allows to search for the query id inside the Snowflake query history
Allows for better communication with snowflake support through query ids

Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot check

hey @ChristianKohlberg are you able to make the changes Jake requested? We'd love to ship this in the next dbt release if we can, so it would be great to get this PR merged by the end of the week :)

Sorry for the low responsiveness. Will finish it up tonight and include the feedback from Jake. Many thanks for the patience in the meantime!

@beckjake hope that this is now solved as anticipated. Once again sorry for the delay!

Thanks for your contribution @ChristianKohlberg! We'll squeeze this into 0.17.0.


Cursor Resets to Beginning on ContentEditable Div/Span During Inline Editing with Dispatch Replace Action

Please refer to the closed issue here: https://github.com/measuredco/puck/issues/351
Problem
When implementing inline editing functionality using a contentEditable div or span within a React component, I've encountered a persistent issue where the cursor unexpectedly jumps to the beginning of the text after dispatching a replace action to update the component's props.
Main part of code
        const onChange = (e: any) => {
            e.preventDefault();
            const { ui } = appState;
            const { itemSelector } = ui;

            dispatch({
                type: "replace",
                destinationIndex: itemSelector.index,
                destinationZone: itemSelector.zone,
                data: { props: { color, align, size, maxWidth, text: e.target.textContent }, type: "Text" },
            });

        }

The editable div looks like this.

Workaround

Dispatching replace action after blurring the div.
Manually handling the cursor.

What could be better?

An onChange function for props just like in field.

This is a userland problem - I'm not sure how we would solve this in Puck.
For example you will have the same problem with:
  const [text, setText] = useState("Some text");

  return (
    <div
      suppressContentEditableWarning
      contentEditable={true}
      onInput={(e: any) => {
        setText(e.target.textContent);
      }}
    >
      {text}
    </div>
  );

You could see https://www.npmjs.com/package/react-contenteditable for further reading.

Closing due to inactivity.


6.1 Catalogue helm chart creation

Create helm charts for catalogue servers following best practices. Refer #issue45
Add some test cases to see end-to-end working.
Helm chart should bundle ingress, deployment, environment vars,  HPA autoscaling, sealed secrets too!

Please find the current catalogue K8s orchestration in K8s branch https://github.com/datakaveri/iudx-deployment/tree/K8s/K8s-deployment/catalogue

closed by https://github.com/datakaveri/iudx-deployment/pull/74


Change log level from warn to debug for unauthrorized exception

This PR is to remove some unused log for unauthrorized exception, some unauthrorized access such as lvs probe request may cause connection exception which we should ignore.

for #2997


Choosing database [RFC]

To decide the database for various usecases.

To store user data (if its stored already we can use that)
To store user preferences
To store the notifications sent to user.

We are preferring NoSql let's see which database would be better.

For storing notications.

I feel it would be read less & write heavy.

For user table

It should be the source of truth for all user data like phone no, email.

For users we can use the users model https://github.com/Real-Dev-Squad/website-data-models/tree/main/users