Using EditorSyntaxHighlighter in TextEdit crashes the project.

Godot version
Godot v4.2.rc (ad72de508)
System information
Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 (NVIDIA; <IP_ADDRESS>98) - Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 Threads)
Issue description
The running project crashes without error message if a TextEdit (or CodeEdit) has EditorSyntaxHighlighter set for its syntax_highlighter.
Attaching a debugger to the running project says:
ERROR: Class 'EditorSyntaxHighlighter' can only be instantiated by editor.
   at: ClassDB::instantiate (core\object\class_db.cpp:364)
core\object\class_db.cpp:364 - Class 'EditorSyntaxHighlighter' can only be instantiated by editor.
ERROR: res://addons/eval_command/run_script.tscn:5 - Parse Error: Can't create sub resource of type: EditorSyntaxHighlighter
   at: ResourceLoaderText::load (scene\resources\resource_format_text.cpp:551)
scene\resources\resource_format_text.cpp:551 - res://addons/eval_command/run_script.tscn:5 - Parse Error: Can't create sub resource of type: EditorSyntaxHighlighter
ERROR: Failed loading resource: res://addons/eval_command/run_script.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core\io\resource_loader.cpp:275)
Failed loading resource: res://addons/eval_command/run_script.tscn. Make sure resources have been imported by opening the project in the editor at least once.
ERROR: Failed loading scene: res://addons/eval_command/run_script.tscn.
   at: (main\main.cpp:3433)
Failed loading scene: res://addons/eval_command/run_script.tscn.

EditorSyntaxHighlighter should probably not be available to select.
Or if EditorSyntaxHighlighter is useful for plugins or something, there should be an error printed when attempting to use it when not in the editor.
Steps to reproduce
Add a TextEdit or a CodeEdit.
Set Highlighting > syntax_highlighter to a new EditorSyntaxHighlighter.
Run the current Scene.
The Scene tries to load and immediately closes.
Minimal reproduction project
N/A

Yes comfirmed. The error message is pretty clear, what should we do about this, at least it shouldn't crash.

This doesn't crash, it fails to load the main scene, which is unrecoverable, it happens when you can't load other classes as well, I'd say it's to be expected, how would we gracefully recover from this otherwise?

It makes sense that it doesn't work, but I think there should be an error message in the Output so it is obvious why.

There is? It says it can't instance the scene

Only when there is a console on the running project, nothing is shown in the editor.

That's unrelated to this, that's because the debugger hasn't had a chance to connect yet, that's tracked elsewhere, can't remember the actual issue right now


Mapnik Grid format support

Hi Guys.
I've implemented a Provider for UTFGrid via mapnik grid_renderer.
http://trac.mapnik.org/wiki/MapnikRenderers#grid_renderer
https://github.com/mapbox/mbtiles-spec/blob/master/1.1/utfgrid.md
This allows you to use TileStache to serve up grid json for consumption by wax, like on http://mapbox.github.com/wax/interaction-leaf.html
Hopefully everything is up to scratch :-)

is this merge still planned?

I would like to merge this, yes. For some reason Github's not been notifying me of pull requests so I didn't see this!

As per my comment above - sorry, I never got around to fixing up the grid rendering api in mapnik 2.0.0 release, so nothing yet to update, and nothing to wait for here on that issue. I need to clean it up eventually but at this point it won't be until 2.1 release.

I needed to change this:
grid_utf = grid.encode('utf',resolution=self.scale,add_features=True)
to this:
grid_utf = grid.encode('utf', resolution=self.scale,features=True)
to make this work

@migurski - was this branch merged in yet? if not, which branch is it?


[Bug]: Timer Lap Button Causes Page Scroll Lock on Homepage

🐞 Bug Report
📋 Description
When using the lap button on the timer in the homepage, the page scrolls down automatically, and the user is unable to scroll back up. This prevents access to the stop, reset, and further lap functionalities.
⚙ Steps to Reproduce
Steps to reproduce the behavior:
Go to the homepage.
Start the timer.
Click the "Lap" button.
The page scrolls down and gets stuck, it basically freezes to a certain popint, preventing access to the timer controls (stop, reset, lap).
✔ Expected Behavior
After using the lap button, the page should remain in place, allowing the user to continue interacting with the timer controls (stop, reset, lap).
❌ Actual Behavior
The page scrolls down automatically when the lap button is clicked, and the user cannot scroll back up to access the timer controls.
🔧 Additional Information
This issue occurs consistently when the lap button is clicked, making it impossible to control the timer further.

@param-code  Please assign the issue to to me with the tags of gssoc, hacktober fest and the level which you see fit for the bug.

🐞 Bug Report
📋 Description
When using the lap button on the timer in the homepage, the page scrolls down automatically, and the user is unable to scroll back up. This prevents access to the stop, reset, and further lap functionalities.
⚙ Steps to Reproduce
Steps to reproduce the behavior:
Go to the homepage. Start the timer. Click the "Lap" button.
The page scrolls down and gets stuck, it basically freezes to a certain popint, preventing access to the timer controls (stop, reset, lap).
✔ Expected Behavior
After using the lap button, the page should remain in place, allowing the user to continue interacting with the timer controls (stop, reset, lap).
❌ Actual Behavior
The page scrolls down automatically when the lap button is clicked, and the user cannot scroll back up to access the timer controls.
🔧 Additional Information
This issue occurs consistently when the lap button is clicked, making it impossible to control the timer further.

I am assigning this issue to you.All the Best @pranusri1903 .

Hy, I see this issue has already been resolved by someone although I was the one asssigned to it.
I found another bug with the same
I have raised the issue for it
Issue number : #226


PEP8 for Calibration

Please ensure your pull request adheres to the following guidelines:

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Updated documentation of features that add new functionality.
[x] Update CHANGELOG.md with major/minor changes.

Thanks @Mv77  !


Migrate to flexmark-java

Since pegdown has been deprecated and flexmark-java seems to have a simple migration path, the underlying parser should be changed.

Implemented in #53


Text police is too small

Experiensa.com> Landing Page > in all sections except in 4rth section: pictures grid and in Catalan Case > Dell Latitude E7440 Win 7 Chrome Version 51.0.2704.84 m  and also in Browser IE Explorer 11> User Public > text police is too small > small text is difficult to read > Priority Medium
Text is too small to be read.

How much bigger?


iOS caller Id and notifications

What version of React Native are you running? 0.49
What version of react-native-twilio-programmable-voice are you running? ^3.2.0
What device are you using? (e.g iOS9 simulator, Android 6 device)? iOS 11 device
Hey, I'm currently able to make and receive a call with CallKit configured. However digging the docs and even the code I was not able to understand how can I change the received caller name. FE: I receive a call from twilio by the user "Rui", however to receive this callerId as a string I have to prepend "client:" to the string, or the caller Id will treat it like a number and convert the name "Rui" to  "784".
The thing is, with "client:Rui" on the twilio server as callerId the iOS call screen will display: "client:Rui", my question is, how can I trim this "client:"?
Also, can't I just display a call notification instead of the popup caller screen? So when I press the notification it'll open the app with my custom screen.
P.S: I have limited understanding of ObjC / Java, I'm kinda struggling atm
Thanks for the great package! Also, your app deserves way more downloads.

Hi Rui, sorry for my delayed answer.
[...] how can I change the received caller name => that is the call callerId right?
Could you try this TwiML and tell me how it goes?
<Response>
	<Dial callerId="Rui" [...]>// callerId must be a valid number of a client identifier
		<Client [...]>Rui</Client> // this Rui is the client identifier to call, the part after the `client:`
	</Dial>
</Response>

From the docs: The client identifier currently may only contain alpha-numeric and underscore characters.
https://www.twilio.com/docs/api/twiml/dial
https://www.twilio.com/docs/api/twiml/client
In regard to your second question about letting your app take control over incoming calls and preventing callkit to handle them I was not able to do it so far. Please let me know if you find a way.

The callerId on that Dial verb cannot be whatever, it must be a valid number or a client id.
What needs to happen is we need to somehow be able to change the localizedCallerName on the CXCallUpdate object when the call comes in. However, it would be ideal if this can be invoked on the javascript side because that's probably where the data needed to set it is.
It would be nice if that reportNewIncomingCallWithUUID was controlled on the JS side like this other CallKit library does it https://github.com/ianlin/react-native-callkit#displayincomingcall

Hi @rclai & @RUIFERNANDE5
I am having the exact same issue, did you ever find a solution?

The original issue duplicates #89 and is fixed in #137
I agree with @rclai, but as it's a separate issue and we need to find a solution for Android I have opened a separate issue specific for this #139

I'm closing this issue in favor of #89.
Read our repository update in #158. I invite you to reopen this issue when you still have problems so we can debug the problems together.


[wayland_client] Cannot get WlSurface from pointer (Arc downcasting)

Hello,
I am trying to get the WlSurface used by the slint process I am using (which just returns a pointer). However, when I try remove the WlSurface object from the Arc that Connection::get_object_data returns, it throws an error (the trait bound WlSurface: ObjectData is not satisfied (the trait ObjectData is not implemented for WlSurface). This appears to me to be a bug, any advice?
Relevant Code:
match ui
    .window()   // slint::Window
    .window_handle()
    .window_handle()
    .unwrap()
    .as_raw()
{
    raw_window_handle::RawWindowHandle::Wayland(wayland_window) => {
        let nn_surface = wayland_window.surface;    // NotNull<c_void>
        let mut wl_surface_obj_id: wayland_client::backend::ObjectId;
        unsafe {
            wl_surface_obj_id = wayland_client::backend::ObjectId::from_ptr(
                wl_surface::WlSurface::interface(),
                nn_surface.as_ptr().cast(),
            )
            .unwrap();
        }
        let wl_surface: wl_surface::WlSurface = Arc::<wl_surface::WlSurface>::try_unwrap(
            conn.get_object_data(wl_surface_obj_id)
                .unwrap()
                .downcast_arc()   // the trait bound `WlSurface: ObjectData` is not satisfied (the trait `ObjectData` is not implemented for `WlSurface`)
                .unwrap(),
        )
        .unwrap();

        appdata.clone().lock().unwrap().surface = Some(wl_surface);
    }
    _ => {}
}

Update: I should've done
let wl_surface: wl_surface::WlSurface =
                                wl_surface::WlSurface::from_id(&conn, wl_surface_obj_id).unwrap()

instead. (Thanks Elinor)


Continue installing recipes if cleanup recipe failed

If the script is running for the first time or if any of the recipe is manually deleted then the recipe.sh will fail to install the recipes.

@simonellistonball can you please merge this

Could you de-conflict @MohanDV

Sure Simon , Thanks !!
From: Simon Elliston Ball<EMAIL_ADDRESS>Reply-To: simonellistonball/cloudbreak-hcp<EMAIL_ADDRESS>Date: Monday, October 22, 2018 at 7:16 PM
To: simonellistonball/cloudbreak-hcp<EMAIL_ADDRESS>Cc: Mohan Venkateshaiah<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [simonellistonball/cloudbreak-hcp] Continue installing recipes if cleanup recipe failed (#1)
Could you de-conflict @MohanDVhttps://github.com/MohanDV
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/simonellistonball/cloudbreak-hcp/pull/1#issuecomment-431840415, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMVeJeilCbDUg6nTwhcPjdULyDKq805zks5uncw7gaJpZM4W4bGV.

Could you de-conflict @MohanDV

done @simonellistonball


Been a While

I think you need to bump .nvmrc to 18 (its 14 right now)

Actually looks like we need to update the node version here
https://github.com/canontech/txintegration/blob/97fd6c7a62b0f715f013d518ab602044b8ec6a21/.github/workflows/ci.yml#L16


Accounts declared in the flow.json are not created when emulator is launched

Instructions
flow accounts create adds and account to the flow.json file.
When relaunching the emulator the accounts defined in the flow.json are not recreated.
There should be a command to recreate the accounts defined in the flow.json file.
Problem
Accounts defined in flow.json not present in emulator.
Steps to Reproduce
{
	"accounts": {
		"AccountA": {
			"address": "01cf0e2f2f715450",
			"key": "some_private_key"
		},
		"AccountB": {
			"address": "179b6b1cb6755e31",
			"key": "some_private_key"
		},
		"AccountC": {
			"address": "f3fcd2c1a78f5eee",
			"key": "some_private_key"
		},
		"default": {
			"address": "01cf0e2f2f715450",
			"key": "some_private_key"
		},
		"emulator-account": {
			"address": "f8d6e0586b0a20c7",
			"key": "some_private_key"
		}
	},
	"deployments": {
		"emulator": {
			"default": [],
			"emulator-account": []
		}
	}
}

Acceptance Criteria
There should be a command to recreate the accounts defined in the flow.json file.
Context
<what are you currently working on that this is blocking?>

This is a bit tricky subject, it falls to flow-cli's responsibility as we don't read flow json.
We experimented on this many times, but no solution was good enough. flow dev decided to move on to account agnostic side, same with testing frameworks. I think for now best option is to use snapshot feature ( with persist ) and then load your initial state from the snapshot.

@janezpodhostnik I don't have permission but this seems like flow-cli issue, can you transfer to there to track better ?


12 critical code smells fixed

In this pull request, I've made several changes across multiple files in the codebase. Here's a summary of my contributions:
SerializationUtils.java
Here I added a comment in which I specified the purpose of an empty method
StringEscapeUtils.java
Since the class is deprecated, I won't fix the code smell
StringUtils.java
Here I fixed 5 smells, of which 4 were too complex method and in that case I used the treatment called Extract Method; 1 was a Duplicated line of code and here I declared a new Exception and throwed it.
Diff.java
Here I added transient keyword to a class field.
ExceptionUtils.java
Here there were 3 code smells:
For the first one and the second one I used the Extract Method in order to reduce the cognitive complexity of a method;
for the third one I added a nested comment to an empty method.

I've just checked SonarCloud, and you introduced 3 code smells. Fix them and reopen the PR. Aside from that, good work!


Update index.md

Business continuity is a key driver for many business as we experience in this pandemic.

@kichiu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@BrianBlanchard @JanetCThomas - Could you review the proposed update? I made a few small edits, in the event that it's approved.

@BrianBlanchard : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@BrianBlanchard : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


HW1:  Create project files and link them in scb2197.md

Update: implemented relative links according to professor feedback

you can reuse the existing PRs

lgtm


Update feat_extract.py

forcing asfortranarray to address the librosa ParameterError "Audio buffer is not Fortran-contiguous.... "

Thank you!


How to get current position of dragend?

Please only use GitHub issues for bug reports and feature requests.

[ ] Read the contributing guidelines
[ ] Bug reports containing repro steps are likely to be fixed faster
[ ] Feature requests should be multi-purpose, describe use cases
[ ] For support requests or questions, please refer to our Slack channel

dragulaService.dragend.subscribe((value) => {
let [el, target, source] = value.slice(1);
var rect = el.getBoundingClientRect().top;
console.log(rect.top);
console.log(el);
console.log(target);
console.log(source);
});
the log is the original position of el,I need get current position when dragend occurred,anyone can help me ,thx in advance!

  let dragEl = value[1];
  let list = Array.prototype.filter.call(value[1].parentNode.childNodes, (node) => {
    return node.tagName === 'TR';
  });
  this.newIndex = list.findIndex((node) => {
    return node === dragEl;
  });


Unbound 1.19.2 is released

Unbound 1.19.2
This security release fixes CVE-2024-1931.
NLnet Labs Unbound version 1.18.0 up to and including version 1.19.1
contain a vulnerability that can cause denial of service by a certain
code path that can lead to an infinite loop.
Unbound 1.18.0 introduced a feature that removes EDE records from
responses with size higher than the client's advertised buffer size.
Before removing all the EDE records however, it would try to see if
trimming the extra text fields on those records would result in an
acceptable size while still retaining the EDE codes.
Due to an unchecked condition, the code that trims the text of the EDE
records could loop indefinitely.
This happens when Unbound would reply with attached EDE information on a
positive reply and the client's buffer size is smaller than the needed
space to include EDE records.
The vulnerability can only be triggered when the 'ede: yes' option is
used; non default configuration.
From version 1.19.2 on, the code is fixed to avoid looping indefinitely.
We would like to thank Fredrik Pettai and Patrik Lundin from SUNET for
notifying us about the issue and working with us to identify the
vulnerability.
Bug Fixes:
Fix CVE-2024-1931, Denial of service when trimming EDE text on
positive replies.
@klutchell : I tried to fork and make a PR on my own (based on what you did for 1.19.1) but didn't manage to find the SHA256 hash for the new tar, apologies...)

Nervermind, I should have looked better.
Will prepare a PR.

Created pr #369 to address.


docs: Add TypeScriptEditor to aid type demos

Motivation

Playing > viewing
Solution

We extract the core editor part of our playground to be shared with the full react playground usage and the typescript standalone.
By avoiding actual typescript transpilation, we greatly reduce overhead for just the type editor. That said, it should still only be loaded for desktop clients.
<TypeScriptEditor>

\```ts
const rpc = new RestEndpoint({
  path: '/:id',
  method: 'PUT',
  body: undefined,
});
\```

</TypeScriptEditor>

Also snuck in

fixed some redirect configs
Minor title updates on pages

Codecov Report

Merging #2355 (aa50c9a) into master (95c9653) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2355   +/-   ##
=======================================
  Coverage   98.22%   98.22%
=======================================
  Files         128      128
  Lines        2030     2030
  Branches      310      310
=======================================
  Hits         1994     1994
  Misses         19       19
  Partials       17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Sidebar Resize Bugs

VM Section:
1) Action box button goes off the screen when compressing the sidebar
Steps:

Go to VM sidebar
Reduce to the end sidebar size

Actual result: The button of action box is missing from the sidebar
Expected result: The button of action box is present on the sidebar and is aligned to the right

2) The tooltips of the "Details" area are below and to the left when the sidebar is expanded
Steps:

Go to VM sidebar on "Virtual machine" tab
Maximum expand the sidebar
Hover over the value of "VM host name" or "Zone" fields

Actual result: The tooltip is lower and to the left than necessary
Expected result: The tooltip is immediately below the value

3) The tooltip values for the "Disk offering" field are above and to the left
Steps:

Go to VM sidebar on "Storage" tab
Maximum expand the sidebar
Open advanced options for a disk that has disk offering data
Hover over the value of "Disk offering" field

Actual result: The tooltip is higher and to the left than necessary
Expected result: The tooltip is immediately below the value

4) The "Eye" icon is shifted to the left when the sidebar is expanded
Steps:

Go to VM sidebar on "Network" tab
Maximum expand the sidebar

Actual result: The "Eye" icon of SG is shifted to the left in "Firewall rules" area
Expected result: The "Eye" icon of SG is aligned to the right in "Firewall rules" area

Images section:
1) The button of action box moves to the left when expanding the sidebar
Steps:

Go to ISO or Templates sidebar, that has action box button
Maximum expand the sidebar

Actual result: Action box button moves to the left
Expected result: Action box button is aligned to the right

Firewall section:
1) Tabs do not stretch along the entire length when expanding the sidebar
Steps:

Go to Firewall Template, Shared SG or Private SG sidebar
Maximum expand the sidebar

Actual result: Tabs are aligned to the left.
Expected result: The tabs are evenly stretched along the entire length of the sidebar, as well as in the sidebars of other sections.

Accounts section:
1) Values and icons of fields "Secret key" and "API key" are shifted to the left when expanding the sidebar
Steps:

Go to Account sidebar on "Users" tab
Expand information for a user with Secret and API keys

Actual result: Values and icons of keys are shifted to the left
Expected result: Values and icons of keys are aligned to the right

Additional:
1) The resize feature does not work at the bottom of the sidebar
Make sure that you can correct this error and it is necessary. If necessary, discuss with the PM or PO.
Steps:

Open any sidebar that has a lot of data in the tab (for example VM "Virtual machine" tab or Account "General" tab)
Scroll down to the bottom of the tab

Actual result: Unable to resize sidebar at the bottom
Expected result: You can change the size of the sidebar in any of its parts
Environment

Browser:
- [ ] Chrome version XX
- [ ] Firefox version XX
- [ ] Safari version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

Connected REQ ID
REQ_GEN_007

To test:
REQ_GEN_007
Regression:
Text formatting in sidebar in all places

@rennervo the last additional fail is the fail of the used library. Not fixed.


rename repo

station 919 from Eindhoven Vliegbasis has duplicate RD measurements. I made a fix to remove the duplicates.

I renamed the repository to 'hydropandas' according to #28


Allow deep cloning

[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

**Current behavior**
If you try to merge an object with deep keys, the Object.assign is replacing since the second level, this indeed is the expected behavior of that method, you can check the MDN documentation about Object.assign

**Expected/desired behavior**
Allow deep cloning

**What is the expected behavior?**
I solved my problem using jQuery.extend in recursive mode, however it could be nice that this library will handle it by it's own, and not use Object.assign or maybe add other parameter for recursive mode

+1 Experienced the same, and it was kind of tricky to debug. Would be nice to support deep merge, since we're talking about plain JSON and not complex JS objects.

This looks nice and tiny enough to be embed, IMHO:
https://github.com/KyleAMathews/deepmerge

Yes, you are right @unsafecode the problem is that it seems that @ocombe is far of this project for a time

aye, sorry guys, got a lot of stuff on my plate while working for the core team :)

@ocombe could you please add this feature, i already made the PR actually i'm stuck because of this

Yeah I'll try to work on this tonight after my work :)

wow excellent thanks, i really appreciate it


Implement atomic GetOrAdd/AddOrUpdate equivalency from ConcurrentDictionary<>

Hello,
Firstable, a huge thanks for this amazing library.
I have a question: I'm using the SpanByteFunctions and I'd like to know if it would be possible to implement a behavior to mimic the atomic operations GetOrAdd and AddOrUpdate.
Would it be feasible, and if so, would you mind sharing a code to override the default implementation from SpanByteFunctions?
Many thanks.

You can implement any of these using RMW in FASTER. For example, TryAdd is discussed here: https://github.com/microsoft/FASTER/pull/345#issuecomment-701617849


BAEL-16637

[retest this please]
Note: This comment is for Jenkins CI build. No action required from the author.

[retest this please]


STYLE: Remove protected static helper functions from ByteSwapper

These nine ByteSwapper member functions were only for internal use. They are replaced now with private member functions SwapBytes and SwapWriteRange, by:

pull request https://github.com/InsightSoftwareConsortium/ITK/pull/4855 commit 3b04ad1b377c6d5d77a2c1f454c363eab8197340, and
pull request https://github.com/InsightSoftwareConsortium/ITK/pull/4862 commit 9413dc4aa06e8bea734c589b107d2e11d782206f

Actually this pull request is still a "spin off" from Bradley's (@blowekamp) suggestion to reduce code duplication in the ByteSwapper implementation, at https://github.com/InsightSoftwareConsortium/ITK/pull/4841/files#r1751777344


OSCAR-2109 huggingface datasets are misaligned and truncated

Copied from: https://github.com/huggingface/datasets/issues/3704
As mentioned in the comments, potentially related to: #15
The only way that I got a simple wc -w on the raw texts from git-lfs in the repo at https://huggingface.co/datasets/oscar-corpus/OSCAR-2109 to exactly match wc -w on all the texts exported from the loaded dataset was to fix all three issues mentioned below, plus not stripping all trailing whitespace. Just pairing the text/meta filenames was not sufficient.
Describe the bug
The oscar-corpus/OSCAR-2109 data appears to be misaligned and truncated by the dataset builder for subsets that contain more than one part and for cases where the texts contain non-unix newlines.
Steps to reproduce the bug
A few examples, although I'm not sure how deterministic the particular (mis)alignment is in various configurations:
from datasets import load_dataset
dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_fi", split="train", use_auth_token=True)
entry = dataset[0]
# entry["text"] is from fi_part_3.txt.gz
# entry["meta"] is from fi_meta_part_2.jsonl.gz

dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_no", split="train", use_auth_token=True)
entry = dataset[900000]
# entry["text"] is from no_part_3.txt.gz and contains a blank line
# entry["meta"] is from no_meta_part_1.jsonl.gz

dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_mk", split="train", streaming=True, use_auth_token=True)
# 9088 texts in the dataset are empty

For deduplicated_fi, all exported raw texts from the dataset are 17GB rather than 20GB as reported in the data splits overview table. The token count with wc -w for the raw texts is 2,067,556,874 rather than the expected 2,357,264,196 from the data splits table.
For deduplicated_no all exported raw texts contain 624,040,887 rather than the expected 776,354,517 tokens.
For deduplicated_mk it is 122,236,936 rather than 134,544,934 tokens.
I'm not expecting the wc -w counts to line up exactly with the data splits table, but for comparison the wc -w count for deduplicated_mk on the raw texts is 134,545,424.
Issues

The meta / text files are not paired correctly when loading, so the extracted texts do not have the right offsets, the metadata is not associated with the correct text, and the text files may not be processed to the end or may be processed beyond the end (empty texts).
The line count offset is not reset per file so the texts aren't aligned to the right offsets in any parts beyond the first part, leading to truncation when in effect blank lines are not skipped.
Non-unix newline characters are treated as newlines when reading the text files while the metadata only counts unix newlines for its line offsets, leading to further misalignments between the metadata and the extracted texts, and which also results in truncation.

Expected results
All texts from the OSCAR release are extracted according to the metadata and aligned with the correct metadata.
Fixes
Not necessarily the exact fixes/checks you may want to use (I didn't test all languages or do any cross-platform testing, I'm not sure all the details are compatible with streaming), however to highlight the issues:
diff --git a/OSCAR-2109.py b/OSCAR-2109.py
index bbac1076..5eee8de7 100644
--- a/OSCAR-2109.py
+++ b/OSCAR-2109.py
@@ -20,6 +20,7 @@
 import collections
 import gzip
 import json
+import os

 import datasets

@@ -387,9 +388,20 @@ class Oscar2109(datasets.GeneratorBasedBuilder):
         with open(checksum_file, encoding="utf-8") as f:
             data_filenames = [line.split()[1] for line in f if line]
             data_urls = [self.config.base_data_path + data_filename for data_filename in data_filenames]
-        text_files = dl_manager.download([url for url in data_urls if url.endswith(".txt.gz")])
-        metadata_files = dl_manager.download([url for url in data_urls if url.endswith(".jsonl.gz")])
+        # sort filenames so corresponding parts are aligned
+        text_files = sorted(dl_manager.download([url for url in data_urls if url.endswith(".txt.gz")]))
+        metadata_files = sorted(dl_manager.download([url for url in data_urls if url.endswith(".jsonl.gz")]))
+        assert len(text_files) == len(metadata_files)
         metadata_and_text_files = list(zip(metadata_files, text_files))
+        for meta_path, text_path in metadata_and_text_files:
+            # check that meta/text part numbers are the same
+            if "part" in os.path.basename(text_path):
+                assert (
+                    os.path.basename(text_path).replace(".txt.gz", "").split("_")[-1]
+                    == os.path.basename(meta_path).replace(".jsonl.gz", "").split("_")[-1]
+                )
+            else:
+                assert len(metadata_and_text_files) == 1
         return [
             datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs={"metadata_and_text_files": metadata_and_text_files}),
         ]
@@ -397,10 +409,14 @@ class Oscar2109(datasets.GeneratorBasedBuilder):
     def _generate_examples(self, metadata_and_text_files):
         """This function returns the examples in the raw (text) form by iterating on all the files."""
         id_ = 0
-        offset = 0
         for meta_path, text_path in metadata_and_text_files:
+            # line offsets are per text file
+            offset = 0
             logger.info("generating examples from = %s", text_path)
-            with gzip.open(open(text_path, "rb"), "rt", encoding="utf-8") as text_f:
+            # some texts contain non-Unix newlines that should not be
+            # interpreted as line breaks for the line counts in the metadata
+            # with readline()
+            with gzip.open(open(text_path, "rb"), "rt", encoding="utf-8", newline="\n") as text_f:
                 with gzip.open(open(meta_path, "rb"), "rt", encoding="utf-8") as meta_f:
                     for line in meta_f:
                         # read meta
@@ -411,7 +427,12 @@ class Oscar2109(datasets.GeneratorBasedBuilder):
                             offset += 1
                             text_f.readline()
                         # read text
-                        text = "".join([text_f.readline() for _ in range(meta["nb_sentences"])]).rstrip()
+                        text_lines = [text_f.readline() for _ in range(meta["nb_sentences"])]
+                        # all lines contain text (no blank lines or EOF)
+                        assert all(text_lines)
+                        assert "\n" not in text_lines
                         offset += meta["nb_sentences"]
+                        # only strip the trailing newline
+                        text = "".join(text_lines).rstrip("\n")
                         yield id_, {"id": id_, "text": text, "meta": meta}
                         id_ += 1

I've tested this with a number of smaller deduplicated languages with 1-20 parts and the resulting datasets looked correct in terms of word count and size when compared to the data splits table and raw texts, and the text/metadata alignments were correct in all my spot checks. However, there are many many languages I didn't test and I'm not sure that there aren't any texts containing blank lines in the corpus, for instance. For the cases I tested, the assertions related to blank lines and EOF made it easier to verify that the text and metadata were aligned as intended, since there would be little chance of spurious alignments of variable-length texts across so much data.

Hi @Uinelj, I am still dealing with alignment issues between metadata and text>
I run:
from datasets import load_dataset cache_dir = './OSCAR2109' dataset = load_dataset("oscar-corpus/OSCAR-2109", "deduplicated_en", use_auth_token=True, cache_dir=cache_dir)
For example  sample id=3834  has warc-target-uri='https://www.bbc.com/sport/football/14359800' which does not match the text.

I'll look into it today.

Running the whole process again (with removing ~/.cache/huggingface/datasets/*, installing latest version on a new virtualenv) with the difference on using streaming=True since I can't hold the whole corpus on my computer, gives me a different record for id=3834, that matches its content (warc-target-uri: https://finalscape.com/category/incroyables-talents/). I tested with streaming=False on smaller corpora and conducted a similar test (checking if text and url matches, both in streaming=True and streaming=False), and found that records were matching.
I'm looking for ways of using a local loading script in order to compare matches and find eventual mismatches.

Thanks a lot @Uinelj, I might have had a problem with caching then. I will try again! I'll update you on my results.

@adrianeboyd, thanks! The problem is that I cannot use git lfs as the server I use does not support this. So I guess I will try to patch the script locally and see if I can use the remote repo. @Uinelj are you going to incorporate this patch on your end as well?

The first patch (that is: sorting text and metadata files so that they are in sync) has already been merged into the current OSCAR-2109.py file.
The second one, suggested by @adrianeboyd is not yet merged because I've been trying to:

Find a way of pulling a multipart corpus and load it using the current OSCAR-2109.py script
Replicate the issue

Once I have a rapid way of debugging the issue and check the fix proposed by @adrianeboyd , I'll happily merge the code.

@Uinelj, so sorry to bug you about this again but do you have an approximate timeline when this will be done? I unfortunately have a deadline on my project and might need to think about alternative if there is no chance of having a correctly aligned version of OSCAR available via the HF API.

I'll allocate more time on this matter in the following week.
Would it be ok for your deadline if I updated you on Tuesday?
This way you could decide to go for an alternative if I still can't figure out a way of fixing this.

Hello @norakassner , @albertvillanova has pushed a fix in https://github.com/huggingface/datasets/pull/3910. When the PR is merged, the issue should be fixed! 🎉

I haven't tested the newlines fix (I don't think it will because the dataset script is calling gzip.open directly?), but even if it does fix it, the offset bug will still need to be fixed:
diff --git a/OSCAR-2109.py b/OSCAR-2109.py
index c2c94595..53e66dc3 100644
--- a/OSCAR-2109.py
+++ b/OSCAR-2109.py
@@ -397,8 +397,8 @@ class Oscar2109(datasets.GeneratorBasedBuilder):
     def _generate_examples(self, metadata_and_text_files):
         """This function returns the examples in the raw (text) form by iterating on all the files."""
         id_ = 0
-        offset = 0
         for meta_path, text_path in metadata_and_text_files:
+            offset = 0
             logger.info("generating examples from = %s", text_path)
             with gzip.open(open(text_path, "rb"), "rt", encoding="utf-8") as text_f:
                 with gzip.open(open(meta_path, "rb"), "rt", encoding="utf-8") as meta_f:

I will try to test the newlines fix in the next day or two.

Hi,
In relation with the bugs:

the offset initialization is clearly a bug: currently it is initialized only once per language, whereas it should be done for each file (some languages have multiple files); you can easily check this by inspecting the first row of some meta files for a specific language with multiple files:

the first row of packaged/ca/ca_meta_part_1.jsonl.gz has "offset":0
the first row of packaged/ca/ca_meta_part_2.jsonl.gz has also "offset":0

the newlines issue:

by default, Python translates universal newlines (\n, \r\n and \r) to \n; and then split lines on this \n line break
if the script generating the meta files did not the same translation, then the nb_sentences in meta will not align with the sentences generated by the Python script if the text contain some "\r" endline.
in this case, we should pass newline="\n" (as suggested by @adrianeboyd) to align the number of sentences
On the other hand, I have checked that the oscar Python script does not have any issue with Unicode breaklines (contrary to the case in huggingface/datasets#3910) because oscar script does not use str.splilines

CC: @Uinelj @pjox @norakassner

@albertvillanova Thank you! I removed the cache and downloaded the dataset again. Somehow, I still have the exact same misalignment as reported earlier: https://github.com/oscar-corpus/corpus/issues/18#issuecomment-1058916842. Maybe I missed to remove some important cache? I check whether it is using the newest OSCAR-2109.py version. This is the case. It also accessed the most recent download. I am not sure what is going on. Any idea?


PoS for Deye

Add PoS for Deye

start with the following:
5kw deye low voltage hybrid : SUN-5K-SG03LP1-EU
10kw deye low voltage hybrid: SUN-10K-SG04LP3-EU
12KW deye low voltage hybrid: SUN-12K-SG04LP3-EU

This register document seems to be working...
Deye.MODBUS.RTU.V104.1.pdf

Deye.MODBUS.RTU.V104.1.pdf

Seems like the logger sticks for Deye uses Solarman V5 protocol
https://pysolarmanv5.readthedocs.io/en/stable/solarmanv5_protocol.html#request-frame-format
Confirmed readings from SUN-10K-SG04LP3-EU


Style tag should not html encode entities in JRuby

This is a fix for: https://github.com/sparklemotion/nokogiri/issues/1315
If you run the following code in JRuby it will result in the > in the style element being HTML entity encoded >, this does not occur with MRI.
html = '<!DOCTYPE html>
Mr. Belvedere Fan > Club
'
html_doc = Nokogiri::HTML(html)
puts html_doc.to_html

<!DOCTYPE html >

Mr. Belvedere Fan > Club

With this fix the style matches MRI
<!DOCTYPE html >

Mr. Belvedere Fan > Club

Thanks for submitting this! I'll take a look once I've cut 1.6.7.

Merged! Thank you so much (and thank you for your patience!). Will be in 1.6.8 final.


Website - Whats News v0.13 left nav does not expand out

Describe the bug
Instead it appears to expand out the v1.0 left nav section. Simple fix?
How to reproduce
Please provide a link to a reproduction scenario using one of the Clarity Stackblitz templates. Reports without a clear reproduction may not be prioritized until one is provided.
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Versions
App

Angular: [e.g. 6]
Node: [e.g. 8.10.0]
Clarity: [e.g. 0.12.5]

Device:

Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional notes
Add any other notes about the problem here.

Thanks for the report, it is fixed now.


[SPARK-50058][SQL] Factor out plan normalization functions to later use those in single-pass Analyzer testing

What changes were proposed in this pull request?
Factor out plan normalization functions to later use those in single-pass Analyzer testing.
Why are the changes needed?
In the single-pass Analyzer proposal we discussed one of the ways to test the single-pass Analyzer - to run tests in dual mode (both single-pass and fixed-point Analyzers) and compare the logical plans. To do that we need to perform plan normalization.
Context: https://issues.apache.org/jira/browse/SPARK-49834
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.

thanks, merging to master!


Cop idea: numbered variable names (user_1 vs user1)

We've got a lot of places in our code where we use a couple of records, something like:
user_1 = blah
user_2 = bloo

Sometimes people number them instead, user1 and user2. Would be nice to have a rule to enforce consistent numbering of variable names, so always with _ or always without.

Would it also be useful to have a configuration option to disallow numbered variables? I can see how some teams might want this to encourage better design (i.e. using a data structure like Array) and naming conventions.

I can't say that it would be something that we would use. We do a lot of testing around things like one-off scripts and database scopes to ensure that only specific records are returned or modified. So something like:
user_1 = create(:user, ...)
user_2 = create(:user, ...)
expect do
  SomeThing.call
end.to change { user_1.reload.some_attribute }
  .and not_change { user_2.reload.some_attribute }

I agree with both of you. I think this new cop would have some value and disallowing numbered variables might be the best default config.

There is, of course, a small chance for false positives. Consider, for example, a method call base64 within a class, which would get flagged.

What if the cop specifically looked for more than one local variable with incrementing suffix numbers? Perhaps even starting at 0 or 1?
I think that would catch the problem and not miss any violations.

It almost sounds like there are multiple rules being discussed here:

(my suggestion) variable names with a number should all be consistently name_1 or name1
variable names should not be named with a number
variable names with numbers should be sequential starting from 1 (or 0)
(another I just thought of) variable names shouldn't have a number if there's only one of them

@mockdeep: These would almost certainly go in the same cop (with configuration options), which is why we're discussing them all in the same thread. 😀 Checking adjacent variables is a bit more involved, but might be possible if the rules are well defined.


Roblox Textures not loading when forcing the Anti-Alias to any value

Weirdly the textures that are bigger than a tiny square don't load, the material textures load fine except for minor things like Profile Icons, Icons bigger than squares and some specific icons too (Affects all games)

Weirdly it also affects some specific icons too, and I am sure my internet is fine since it runs at 600 mbps.

Weirdly the textures that are bigger than a tiny square don't load, the material textures load fine except for minor things like Profile Icons, Icons bigger than squares and some specific icons too (Affects all games)

Keep it on Automatic. There are some known issues with it right now.


Add support to create grid styles also in figma

Is your feature request related to a problem? Please describe.
Currently figma plugin supports only creating text and color styles.
But grid styles are also required to work with material design V3.
Describe the solution you'd like
Plugin should ask to generate grid styles also, and which should optional also.
So user can create grid styles as per their requirement.
Describe alternatives you've considered
Currently grid styles are available in M3 Figma kit file only but not supported in plugin.
Additional context
Add any other context or screenshots about the feature request here.

What kind of grid styles would you want?
Could you provide some examples?

@rodydavis Add support in plugin to generate grid styles also supported by M3 specs & it's also there in material design kit please check here https://www.figma.com/community/file/1035203688168086460
Thank You

Thanks! We'll add this as a feature request, but the M3 Design Kit should be used for grid styles as they are not a theme attribute.


[MNOE-155] - Staff invite workflow

Fixed bugs:

Staff did not received a confirmation email
Reloading the staff page was not working

Improvments:

Redirect an "admin" user when he changes its details to "staff" to avoid accessing the staff page
Stop the last admin user to change its status or delete himself (frontend check)
Exit button logout staff without organizations and redirect to the dashboard otherwise.

@ouranos @alexnoox Can you review this? :)

Thanks @alexnoox  for your comments! Let me know if I need to change anything else

LGTM
@ouranos Could you review this one too? Cheers

@ouranos what do you think of this one?

@ouranos This should fix Malcom's questions about adding admins

@ouranos @alexnoox can we merge this before I add the rewrite of the frontend?

I splitted this PR in two seperate ones:

https://github.com/maestrano/mnoe-admin-panel/pull/6 for the frontend
https://github.com/maestrano/mno-enterprise/pull/232 for the backend

@alexnoox this is the PR for the frontend-admin


Improve --watch performance and fix jest -o.

We now limit the default number of CPUs to cpus - 1. This doesn't have a very noticeable impact on performance because of all the caching we are now doing in workers
For --watch, we are now using floor(cpus / 2) so that people can comfortably keep using their editors.
When jest -o was invoked with no changed files, it would hang. Fixed that and added a descriptive message.
Removed some outdated and unused config options for TestRunner.
Bumped the timeout for the jsdom test because travis sometimes takes too long.

The long term plan is to split the TestRunner code into a simple TestRunner and a class that finds matching tests. That should clean everything up quite a bit :)

@facebook-github-bot import


bugg

I cant procesing this music whyy pls fix it

Go
README -> Issue Reporting

Please be as detailed as possible when posting a new issue.


Revert "Get changed task files for git resolvers"

Reverts redhat-appstudio/build-definitions#888
This change broke the acceptable bundle push, so reverting it until a fix can be tested.

/retest

/retest

/retest

/retest

/retest

/retest

/retest


Bulk application deployment

The domain administrator should have the possibility to trigger a deployment of several application instances within a particular domain with a single call.
Specification of the list of application instances to be deployed should be provided in a csv file (exact schema to be designed).
The platform should expose additional API endpoint to trigger the deployment.
A comprehensive validation of the request needs to be performed (parsing of the csv content and validation against the content of the internal database like application names, subscriptions and so on) and meaningful information should be returned if any validation errors occur.

@korvoj could be please propose the csv format

I propose to go through several iterations/discussions so that we can make the schema as versatile as possible, applicable to different scenarios.
Core Principles
I propose the following core principles when dealing with the schema:

define required and optional fields. Optional fields if not specified, take some default value (to be determined on a case-by-case basis)
accept CSV files which include fields that have not been defined, and ignore them on purpose. Perhaps a warning message can be shown to the user, but this is optional. The idea is to allow users to deploy applications in bulk by creating CSV dumps from different systems. It will be easier if only the necessary columns are added/renamed instead of tailoring the CSV export to the same exact format that NMaaS requires.
we should evaluate how hard it would be (from a technical perspective) to implement dynamic mapping of fields. This is something that Moodle does, a screenshot is available below, to get a better idea. The main concept is that CSV upload is done in two steps. The first step is the upload of the file itself, while the second steps allows the user to specify what fields in the CSV file correspond to what expected values. A dropdown field is available for each field detected in the CSV file, allowing it to be mapped, if needed (there is also a possibility to simply ignore its value). This is just an idea, we might conclude that the extra effort is not worth it...

Initial CSV Schema
Regarding the initial version of the proposal, I suggest the following fields to be parseable from the CSV file:

domain name [Required] - the name of the domain where the application needs to be deployed
application name [Required] - the name of the application (as visible from the catalog) to be deployed
application version [Optional] - the version of the application to be deployed. If not specified, the latest version available in the catalog is deployed.
...parameters [Optional] - list of extra (Helm) parameters, relevant to the application that needs to be deployed. This would allow for example to set the size of the volumes, enable/disable features, etc... Each parameter would be passed as a separate column in the CSV file, perhaps with some uniform prefix, which is to be defined.

Notifications
We should also think about the notifications which are sent to the users once the application is deployed. Currently the user is sent an email message containing the name of the application which was deployed, the domain in which it was deployed and an URL to access it (screenshot available below).

It would be beneficial if this notification message is extended with extra information:

customizable parameters used during the deployment process (passed via the CSV file or used with default values)
access information (username, password, IP addresses...)

The idea is to be provide all the necessary information for accessing the application directly in the email.

Few questions that come to my mind:

do we need some application instance name column?
do we plan to allow for deployment of multiple different applications via a single csv? This would make things more complex, mainly thinking about the custom deployment parameters to be passed in dedicated columns
do you think that dynamic domain creation for users via the "application deployment csv" brings much value for the user requesting the deployments? Splitting this into two steps (allowing domain creation from a different "csv") might make it a bit less complex

do we need some application instance name column?

You are right. I was thinking that the user deploying the applications would only need to pass in the ingress hostname as a custom parameter, but I guess it will be good to include both as optional parameters (both the app instance name and the ingress hostname). If the application name is not passed it can be generated automatically (perhaps reuse the existing mechanism for naming deployments - $app_name-$id, I leave this up to you but please keep it descriptive and not completely random such as an UUID). I will update my initial comment with this info, as to have everything in one place.

do we plan to allow for deployment of multiple different applications via a single csv? This would make things more complex, mainly thinking about the custom deployment parameters to be passed in dedicated columns

No, let's limit this feature to bulk deployment of application instances for a single application per CSV file and see if we need something more advanced in the future.

do you think that dynamic domain creation for users via the "application deployment csv" brings much value for the user requesting the deployments? Splitting this into two steps (allowing domain creation from a different "csv") might make it a bit less complex

If the implementation process would be simpler in case these are separated into two different processes, then by all means to it that way. Perhaps there would be another GitHub issue for describing this "bulk user creation" feature, but for now I would just like to suggest that we think about how we can implement it to fail gracefully in certain edge cases. It would be very nice if the behavior is something like this:

a list of users is uploaded with a set of required fields (to be determined) including the domain group(s) in which they should join
the missing domain groups are created (what would be some sane defaults here, e.g. for the initial list of allowed applications?)
the missing users are created, along with a corresponding domain to which they are assigned as domain managers. Each domain is joined to the respective domain groups as specified in the CSV file.
in case a user already exists with the same ID (e.g. username), the user creation and domain creation processes are skipped, but we still assign their existing domain to the specified domain groups (UNION with existing domain groups which they are already part of).

@korvoj having in mind that we agreed on simplified approach of having instances of only a single application deployed with a single CSV, could we remove the application name column from the file and pass it separately? This would slightly simplify the CSV but not sure if it might break the foreseen user process for preparing the CSV and triggering the deployment.

@llopat, yes, I think this is fine. So there would a separate (independent from the CSV) input field in the wizard where the user doing the deployment can choose the desired application?

@korvoj yes, I was indeed thinking about such dedicated field or even selector apart from the CSV upload form

@korvoj not sure if it was officially agreed already, I suppose we should allow for multiple instances of given application to be deployed in a single domain by adding multiple entries with given domain name in the CSV, correct?

@llopat, from the perspective of the virtual lab use-case, I think this is not required. However, it might be beneficial in some other scenarios, so as to allow as much flexibility as possible, it would be nice if it is implemented that way.

Topic to be further explored in the scope of v1.7.0


[NoQA] Attempt to fix the checklists including already released PRs

Details

I believe using ... is incorrect in this case, using the three dot operator, we also get the ancestor commits of the commits made in the range meaning that if some of the PRs has merge commits from the past before the left range, the git log includes them too and then as we parse the PRs from the git log output, we also include PRs which already been deployed.
Using the two dot operator however only includes the commits which are in between the tags, which is what we want in this case.
I have tested this manually on the latest tags and the output seems to be correct to me based on manually checking the repo.
I had to update the tests to include the cherry picked PRs in the output of the method. This is not the outcome we want eventually, as we would like to omit the Cherry picked prs from the list, but this is a bug we already had before and its better than what we have currently.
See the tests section for more details
Fixed Issues

$ https://github.com/Expensify/App/issues/27123
Tests

I have tested the flow by simulating the methods locally, run
git log --pretty=format:'{"commit": "%H", "authorName": "%an", "subject": "%s"},' 1.3.76-6..1.3.77-0 > commit_history.txt

to get the commits between the 1.3.76-6 and 1.3.77-0.
This is the output: commit_history.txt
Then I have used this code which is used in the createOrGetStagingChecklist to parse this output in same way as we do when creating checklist officially
const replacer = (str) =>
    ({
        '\\': '\\\\',
        '\t': '\\t',
        '\n': '\\n',
        '\r': '\\r',
        '\f': '\\f',
        '"': '\\"',
    }[str]);

function getValidMergedPRs(commits) {
    const mergedPRs = new Set();
    commits.forEach(commit => {
        const author = commit.authorName;
        if (author === "OSBotify") {
            return;
        }

        const match = commit.subject.match(/Merge pull request #(\d+) from (?!Expensify\/.*-cherry-pick-staging)/);
        if (!Array.isArray(match) || match.length < 2) {
            return;
        }

        const pr = Number.parseInt(match[1], 10);
        if (mergedPRs.has(pr)) {
            // If a PR shows up in the log twice, that means that the PR was deployed in the previous checklist.
            // That also means that we don't want to include it in the current checklist, so we remove it now.
            mergedPRs.delete(pr);
            return;
        }

        mergedPRs.add(pr);
    });

    return Array.from(mergedPRs);
}

const stdout = `commit_history.text content`;

const sanitizedOutput = stdout.replace(/(?<="subject": ").*?(?="})/g, (subject) => subject.replace(/\\|\t|\n|\r|\f|"/g, replacer));

// Then remove newlines, format as JSON and convert to a proper JS object
const json = JSON.parse(`[${sanitizedOutput}]`.replace(/(\r\n|\n|\r)/gm, '').replace('},]', '}]'));

console.log(getValidMergedPRs(json));

The chain is:

getPullRequestsMergedBetween

getcommitHistoryAsJSON

which calls the important git log here

Sanitizes and parses the output here

getValidMergePRs

which matches for specific text of the merge commit message

This is the line which includes the incorrect PRs currently because out git log with three dot operator includes also ancestor commits which might have some older merge commits included

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

N/A

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I agree this is not ideal, I have been under assumption it was failing consistently as the bunch of checklists I saw then were aall wrong, but its flakey
This change however seems to fix it reliably and adds the CPs so I think that is bigger timesave for QA and deployer than to de-dupe the huge checklists potentially missing some pr which might get to prod not QAed. Then we could find a follow up fix to remove the CPs


incorrect exported types

The following code :
<script lang="ts">
	import {Nav} from 'sveltestrap';

</script>
<Nav navbar class="ms-auto" />

raises the following error:
Error: Type '{ navbar: true; class: string; }' is not assignable to type 'IntrinsicAttributes & INavProps'.
  Property 'class' does not exist on type 'IntrinsicAttributes & INavProps'. (ts)

The same with Tooltip :
<Tooltip target="xxx">xxx</Tooltip>

Hi @lovasoa ,
Can you confirm which Sveltestrap version you are using?  We improved this quite a bit with v5, and haven't back ported to v4 yet.

Okay, I just updated sveltestrap, but I do still have the error :
		"node_modules/sveltestrap": {
			"version": "5.1.1",
			"resolved": "https://registry.npmjs.org/sveltestrap/-/sveltestrap-5.1.1.tgz",
			"integrity": "sha512-al8ZdC/hx4gbkpGF9vWc6JxpBuDc0Ckj6xC6buly7/fCsxvR4rxAn3mm6/mt6XJYZEXAUZVvmGGPBbTEP4aBLg==",
			"dependencies": {
				"@popperjs/core": "^2.6.0"
			},
			"peerDependencies": {
				"svelte": "^3.29.0"
			}
		},

The error you show mentions 'IToastHeader' code removed in older releases: https://github.com/bestguy/sveltestrap/commit/a18695bd3d89c15a98d2df5219594570abde955c#diff-619cc2239a7eb4ef05041767e6ab0e4fb069e98ee9d2c83c2d8e1865c475e141
I don't think this is a lib issue. Try restarting VS Code and then npm ci to clear any cached files.  Please close if that clears.

Indeed, this fixed the issue. Thank you and sorry for the inconvenience !


Mobile authentication

Dear author. Please add these two methods. for authentication and code generation.
enable2fa and finalize2fa
Your library uses 90% of developers. Help us.
Your library is the best, but I need a shared secret
Please, see
https://github.com/GaletskyIvan/steamcommunity-mobile-confirmations/issues/1#issuecomment-161651774

I can't add them because enabling 2fa is done through Steam Community, not through Steam client. You can use for example node-steamcommunity for that.

Dear Nikolai! Would you like to provide a 2fa functionality? A lot of websites using your module. The only problem is that your steam client is no more actual, because there 2fa is not provided...
Personally I(and I'm not alone here) dont want use node-steamcommunity instead of node-steam, simply because we have some clients that have some applications that already working on your code.

@seishun Unified messages actually support two factor btw.

I can not give up your library. because there Sentry files

@Jallvar You can still use node-steam. What's the problem?

I need to automate the process.
Authorisation and sending the exchange offers.
Innovations that did not prevent it.
steam-community supports the generation of codes (there are desired methods).
node-steam supports Sentry-files

node-steam supports Sentry-files

node-steam supports anything related to Steam network protocol, including logging in with 2FA code.

me need to generate 2fa code.
node-steam not allow it.

node-steam not allow it.

I have generated the codes using node-steam. Magic? Why do you even keep arguing is beyond me, i'm out.


Mark onChain payments as "paid" (only in the frontend) once in mempool for Satspay plugin

This feature request is pertinent only for onChain payments when using the Satspay plugin.
In a manner similar to BTCPayserver, it would be beneficial to allow merchants to mark a payment as "paid" in the frontend as soon as the transaction enters the mempool. This enhancement would improve user experience for onChain payments. As a safeguard, merchants could still perform an additional payment verification in the backend before confirming and processing the order.
This feature should only be optional. However, it is best practice among merchants to handle onChain payments in this manner.

tnx, one suggestion if I may:
awesome experience would be when the green tick appears quick and that will by itself trigger the order confirmation (let's say to the merchant) w/o the customer need to do anything. On card payments normally customer waits to be sent back to the merchant page (hence my re-direct suggestion above), with a banner saying ~"do not leave this page".
But customers cannot be trusted not to hit back on the browser or put the browser in the background in the app and forget about it.

Just to clarify, when you say "optional," do you mean the merchant can choose whether or not they want the "pseudo" zero-conf behavior? Would they, for instance, have a toggle for this? And to be clear, this would only affect the UI on the client side, and the charge would only be marked as paid after one confirmation, correct?

Yes, that seems like a sensible approach.

In my opinion, making it optional might be confusing. Wouldn't it be clearer for the end user's UI if "zero-conf" were the default setting?

That's an excellent point. However, enabling "zero-conf" by default might lead to more confusion. Inexperienced Lnbits operators might also be more susceptible to deception by malicious customers with this setup. The approach taken by BTCPayserver, where it's optional, seems to be a good one in my view.

Great, "zero conf" is up and running!

Impressive, that was incredibly fast!

Now, regarding another issue: when a webhook is triggered, it's dispatched once the charge is paid. This webhook also includes a button allowing the user/customer to confirm the order. Considering @jr21M's issue (https://github.com/lnbits/satspay/issues/12), which I plan to incorporate into this PR, what should the flow look like?

My suggestion is to display the confirmation button as soon as the order is marked as "Paid" (be it an LN invoice that's settled or a pending transaction on-chain).
It might also be worth considering a "pending" flag for the webhook, especially in relation to on-chain payments.

I need to make it optional still...
About your last point, this needs to be backwards compatible (i think), as so, if some merchant has an endpoint that gets hit by the webhook to trigger something, for example a download, or a shipping, whatever, they could get in trouble if not aware of this pending flag! the webhook is only triggered when the payment is confirmed!
Guess it can be avoided with being optional and "zero-conf" is opt-in instead of default, like you suggested! It needs more in depth changes. I'll get it done soon.

It makes sense to keep everything backwards compatible. However:

the webhook is only triggered when the payment is confirmed!

I understand. However, this poses a problem in my view. I use Lnbits solely as my backend Lightning infrastructure and handle all the frontend tasks independently. Hence, I rely exclusively on the API. If the webhook is triggered only when the payment is confirmed, then the new optional feature won't benefit my application. I believe many others primarily utilize the Lnbits API for their applications.


Update view-reservations.md

Hello, I'm making this change to provide a guide for customers to get User Access Administrator role/rights at the tenant level as the information is missing from this page. Please reach out to<EMAIL_ADDRESS>if you have questions with this change request.

@vrviriya : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bandersmsft
Can you review this PR?
at a glance, I noticed the  non-repo graphic added. all images must be from files in the repo.
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Jak-MS I don't see a non-repo graphic. I only see the text change shown on the Files changed tab and in the commit details.
The text change is good.
#sign-off

@bandersmsft - sorry for the confusion. copy/paste error on my part.


How to add tinymce or quilleditor as a type of field

I am developing a blog feature and I would like to integrate an editor.
How can I add TinyMCE or quill editor as a type of field

Good question to ask in the discord!
https://discord.gg/Vhu97pAC76


undefined reference to `__atomic_load_8'  while  building SampleApp on raspberryPi

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

What is the expected behavior?

What behavior are you observing?

Provide the steps to reproduce the issue, if applicable:

Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hello Vaishnavikumara,
It looks very likely that this is a duplicate of issue 380.  The fix reported there is to add:
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")
...to CMakelists.txt.
best regards,
-SWH

@scotthea-amazon  I tried the fix you gave here. It still did not work. I am using rpi4 with debian 10.

@Chiggy-Playz me too

@Chiggy-Playz me too

you can solve the issue by going to the avs-sdk.../CMakeTextList.txt and then paste
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")
done for the atomic base error.

@Chiggy-Playz me too

you can solve the issue by going to the avs-sdk.../CMakeTextList.txt and then paste
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")
done for the atomic base error.

How do you get to this line? thanks

Same problem, where in the file do you need to add this line? Thanks

@coriolan-cs  you edited the wrong file. you had to edit the file in source/avs-sdk-device/CMakeTextList.txt and then add the file in the end @angus390 follow the same

Oh sorry about the confusion, I had this problem when building for Intel Realsense, not Alexa (I google the problem and arrived here)
Although I replaced source/avs-sdk-device/ by /librealsense/

i got a same error.
/usr/bin/ld: CMakeFiles/SampleApp.dir/SampleApplication.cpp.o: en la función `std::__atomic_base<unsigned long long>::operator=(unsigned long long)':
/usr/include/c++/8/bits/atomic_base.h:374: referencia a `__atomic_store_8' sin definir
/usr/bin/ld: CMakeFiles/SampleApp.dir/PortAudioMicrophoneWrapper.cpp.o: en la función `alexaClientSDK::avsCommon::utils::sds::SharedDataStream<alexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits>::Writer::write(void const*, unsigned int, std::chrono::duration<long long, std::ratio<1ll, 1000ll> >)':
/usr/include/c++/8/bits/atomic_base.h:396: referencia a `__atomic_load_8' sin definir
/usr/bin/ld: CMakeFiles/SampleApp.dir/PortAudioMicrophoneWrapper.cpp.o: en la función `alexaClientSDK::avsCommon::utils::sds::SharedDataStream<alexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits>::Writer::Writer(alexaClientSDK::avsCommon::utils::sds::WriterPolicy, std::shared_ptr<alexaClientSDK::avsCommon::utils::sds::SharedDataStream<alexaClientSDK::avsCommon::utils::sds::InProcessSDSTraits>::BufferLayout>)':
/usr/include/c++/8/bits/atomic_base.h:396: referencia a `__atomic_load_8' sin definir
/usr/bin/ld: CMakeFiles/SampleApp.dir/PortAudioMicrophoneWrapper.cpp.o: en la función `std::__atomic_base<unsigned long long>::operator unsigned long long() const':
/usr/include/c++/8/bits/atomic_base.h:396: referencia a `__atomic_load_8' sin definir
/usr/bin/ld: ../../ACL/src/libACL.so: referencia a `__atomic_fetch_add_8' sin definir
collect2: error: ld returned 1 exit status
make[3]: *** [SampleApp/src/CMakeFiles/SampleApp.dir/build.make:288: SampleApp/src/SampleApp] Error 1
make[2]: *** [CMakeFiles/Makefile2:10227: SampleApp/src/CMakeFiles/SampleApp.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:10239: SampleApp/src/CMakeFiles/SampleApp.dir/rule] Error 2

My system:
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"`

I try with
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")
at end of ~/avs-device-sdk/CMakeLists.txt
But not works for me

@djcors try putting it on the 9th line. That is just after the endif()

This issue is fixed in v1.15 of the SDK.

I have the latest SDK version but still faced the same issue.

Yeeeehaaaa! It works. For newbies like me, you have to:
cd avs-device-sdk
then:
nano CMakeLists.txt
go to the bottom and add in the file:
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")

sudo update-alternatives --set gcc "/usr/bin/gcc-5"

https://solarianprogrammer.com/2017/12/08/raspberry-pi-raspbian-install-gcc-compile-cpp-17-programs/
for Raspian 10 or above

maybe you need use target_link_libraries(target atomic)

Hello Vaishnavikumara,
It looks very likely that this is a duplicate of issue 380. The fix reported there is to add:
set(CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS} -latomic")
...to CMakelists.txt.
best regards, -SWH

hello, this is not working


Fix android warnings 1 3

@onabiull : sorry, I thought I reviewed it yesterday.

@onabiull , re base done


[Bug]: Data repair issue - seemingly crashing dataNode

Contact Details
<EMAIL_ADDRESS>Is there an existing issue for this?

[X] I have searched all the existing issues

Priority
fatal
Environment
- CubeFS version: v3.3.1 w/AuthNode patches
- Deployment mode(docker or standalone or cluster): Standalone
- Dependent components: Datanode
- OS kernel version(Ubuntu or CentOS): Debian 12
- CPU/Memory: 6 cores 12GiB RAM minimum
- Others:

Current Behavior
I noticed my datanode hosts dropping in and out of service. Checking the logs we see this:
2024/02/18 18:56:54.047175 [ERROR] data_partition_repair.go:153: buildDataPartitionRepairTask PartitionID(40) on (<IP_ADDRESS>:17310) err([data_partition_repair.go 223] getRemoteExtentInfo DataPartition(40) unmarshal json(X?
[... lots of unprintable garbage ...]
 from host(<IP_ADDRESS>:17310) :: invalid character 'X' looking for beginning of value)

This seems to occasionally knock machines offline entirely, requiring a restart of cubefs-datanode (cfs-server -c /etc/cubefs/datanode.json)
Expected Behavior
Nodes do not go offline
Steps To Reproduce
Not sure, but it seems to have happened when my storage cluster filled up (or rather the underlying disks backing the cluster)

CubeFS Log
No response
Anything else? (Additional Context)
No response

I deleted the "bad" replica:
wings:~/ $ cfs-cli datapartition del-replica <IP_ADDRESS>:17310 40                                                                                [11:13:04]
Error: action[canOffLine],partitionID:40  RocksDBHost:[<IP_ADDRESS>:17310 <IP_ADDRESS>:17310 <IP_ADDRESS>:17310]  offLine:<IP_ADDRESS>:17310  err:cannot take the data replica offline  liveReplicas:2
wings:~/ $ cfs-cli datapartition del-replica <IP_ADDRESS>:17310 40                                                                                [11:13:06]
Delete replication successfully


Cannot read property 'getValue' of null when changing themes

Issue Type: Bug
In the latest Insiders change the theme using the Preferences: Color Theme command. For each change, you will see the below error in the console

VS Code version: Code - Insiders 1.26.0-insider (afc3d77e7cfc6534ba05c52f5e1289cbecd58b3d, 2018-07-19T05:18:41.292Z)
OS version: Windows_NT x64 10.0.17134

@ramya-rao-a I'm not able to reproduce in 26e5a55cd8452477bfb7a472ea9475761600adf0
Date: 2018-07-20T05:18:52.551Z.
Can you get more information from the dev tools as where this is happening? There haven't been any changes in the theme service lately.

I dont see it the latest Insiders from last night either.
Closing.


[New game]: Surviving elements

🎮 Game Request
CONTROLS
Arrows for move
Mouse to aim the target
Click left to shot with selected element
Click rigth to change element selected
The world was destroyed by the natural elements and you are the unique survivor.
Try to survive to the attack of the elements, using them!!!
You can change your weapon ( Water , Fire , Earth and Wind) using right click.
Point down the features
Kill all element as you can and Survive!!!
But be careful if you make a mistake and attack a element with the same element, this will be stronger and faster, if two enemy elements collide between they these will have more power too.
Water kills fire
Fire kills earth
Earth kills wind
Wind kills water
Enjoy it!!!
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @S-ishita !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hello Sister 👋🏻

Hope you're doing well, Yesterday we both just spammed this whole repository by adding multiple issues and PR's
So i have received warning from respected PA and Moderator also, and they told me to close all issues are pr's
If we don't clear the spam we done then we will be blacklisted on the GSSOC's Contributors list
Then our hardwork will be wasted in adding these games to this repository, I can understand we both invested so much of time to contribute here
But this is an Do or Die situation, I hope you can understand
I'm writing this here because there's no platform we can connect privately to send this text to you
And I'm already closing the Issues and PR's so that i can't be blacklisted and banned, I thought to tell this to you because we both are spammed this repository.
I would like both of us in GSSOC's Leaderboard, i don't want authorities to blacklist us.

Thank You!


CI?

Maybe you could set up a CI to automatically call the script and push it nack but to another branch, and make the pull requests and pushs of extensions directly to the other branch watched by the CI?

Yes I could, for now it's simple enough so that it was not too much of a problem but using Travis-CI/CircleCI/Semaphore or even GitHub actions to automate this will be welcome at some point :)
There is already extensive CI running for GDevelop for each commit and pull request.

There is Github Actions for this :)

Closing this as I think it is better to keep the issues tab for actual extensions submissions and nobody seems to be interested in working on that.


Add-On does not start

I'm submitting a ...

[ ] bug report
[ ] feature request
[x] support request

General infomration
Prerequisites

[x] Are you running the latest version?
yes. I've installed Kodi nightly via the Ubuntu PPA and I've installed this add-on by using the repository

Description
I am trying to install the Netflix-Add-On for Kodi. I am running Ubuntu 18.04 LTS and I've installed the Kodi 18 nightly build via the PPA ( ppa:team-xbmc/xbmc-nightly )
First I got an error and according to the debug log, python was missing the cryptodome module. After installing it (and rebooting) I was at least able to enter my username and password. But after entering it, it also threw an error (not in the log, not reproducible for me)
Now everytime I run the add-on it directly throws an error. (Error 111 Connection refused in the debug log)
Steps to Reproduce

Install addon and dependencies
run the add-on

Expected behavior: [What you expected to happen]
Prompt for credentials and then successfully run the add-on
Actual behavior: [What actually happened]
After starting the add-on, an error message pops up, no netflix for me
Context (Environment)
Installation

[ ] I installed the plugin via zip from the Releases page
[x] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[x] Linux (x86/x64)
[ ] OSX (x86/x64)
[ ] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Additional informatin on the environment
I am using Ubuntu 18.04 LTS, Kodi Nightly is installed via PPA
Debug log
https://paste.ubuntu.com/p/zjPV9Vg9HM/

@fionnlagh I am not sure that this is your issue specifically, but Netflix changed the spelling of something on their website which appears to have made 0.13.8 and older stop working.  I would suggest starting with updating to the latest release, which is now 0.13.10:
https://github.com/asciidisco/plugin.video.netflix/archive/0.13.10.zip
Also, if you're interested in more information on the wrong credentials issues others have had, see:
https://github.com/asciidisco/plugin.video.netflix/issues/402
https://github.com/asciidisco/plugin.video.netflix/issues/398

@knappster1 thank you for your reply.
I have removed the old version of the addon and then installed the version 0.3.10 you have linked.
Unfortunately the add-on still does not start (In debug log:  Error 111 Connection refused)
Full debug log: https://paste.ubuntu.com/p/WNRHVtz2bh/

Okay, that's quite funny now.
I had installed the cryptodome module via apt-get install python-pycryptodome, not via pip2. That was not enough, I also had to install python-pip. Installing this also installed several other python modules as dependencies:
libexpat1-dev libpython-all-dev libpython-dev libpython2.7-dev python-all
python-all-dev python-asn1crypto python-cffi-backend python-crypto
python-cryptography python-dbus python-dev python-enum34 python-gi
python-idna python-ipaddress python-keyring python-keyrings.alt python-pip
python-pip-whl python-pkg-resources python-secretstorage python-setuptools
python-six python-wheel python-xdg python2.7-dev
obviously they are needed aswell.
Now I was at least able to login and browse around, but playing any movies does not work (I will maybe create another issue when I can't fix this)
thanks @knappster1 for your help


Vue-cli compile image src via dynamic property

When i reference the image source via the assets directory it works as expected and compile the image path to static one like this /static/img/img.1e7c8df.jpg
but when i use a dynamic property and pass the value of the property via the parent component,
the image path doesn't compile to /static/img/img.1e7c8df.jpg path

you have to actually import the image in JS. then webpack knows about it as a depenency and can manage the path.
import Image from './assets/image.jpg'
// `Image` will not be a string, pointing to  '/static/img/img.1e7c8df.jpg'

does this seem logical or even easy to reason about ? Let me explain :
Assuming i have a team page on my web app, i have 50 teammates, it would be anoying to write 50 times a  div + h2 + img + some description.
So i would use a loop, my image would go from 1 to 50 so i would dynamically use :src with the index of the loop.
BUT those images would be in my assets, so are you expecting someone to write 50 times and import for his images ?
Knowing that we can't loop over an import

here's a fiddle of what i mean : https://jsfiddle.net/76sythpu/
i think we need to fin another solution, importing the asset isn't a good idea if you have many dynamic assets.
Copying a folder of assets to the dist folder maybe the only solution for now...

Well, that's how webpack works for dynamic assets. You still have options, though.

use the /static folder as explained here.
Use a dynamic require to make webpack require all images in one call, as explained here

I won't go into much detail (for that we have forum.vuejs.org).

I hope that I get a answere here, though its closed.
I can‘t understand that I can load an image from the laravel /public/ images directory, but not from /storage/app/public!
If image file name and subfolder is dynamic. Could anybody explain it to me? Please!?

Please use the forum, as I mentioned in my last reply.
This is a closed isssue.

I did already
https://forum.vuejs.org/t/get-path-from-storage-directory-inside-vue-component-in-laravel-5-5/21646

🥇

Hi @kaankucukx ,
What if I want to add it to the style tag like

How should I go about this?

@david-saint Hey,
Go with this.. ;)
<div class="left" :style="`backgroundImage: require(assets/img/${image}.png)`">

Check this by Addy. https://developers.google.com/web/updates/2015/01/ES6-Template-Strings

Thanks @kakahikari
this worked
<div class="left" :style="{backgroundImage: `url(${require(`../assets/img/${image}.png`)})`}">

@kaankucukx may I ask what the $ sign means here? This also worked with my Vue app and I don't know what's happening.

@nicobaguio

Template Strings can contain placeholders for string substitution using the ${ }

you can get more info on link as kaankucukx mentioned: https://developers.google.com/web/updates/2015/01/ES6-Template-Strings

same
<img<EMAIL_ADDRESS>/>
but shorter
Also worth to look at assetsDir option.

@kaankucukx you saved my morning 🚀

hey! i need some help
here is the json object passed to component slides.vue

and props were passed when i wanted to retrieve text it worked but for image retrieval this.image.url (used images[0 ] for tesing) it just displaying nothing 😭😭 but when i log this.image.url it displays

../assets/img1.jpg

but when i pass actual path  it works .

i dont know why it does not passing this computed return  value to the template

I keep getting the Cannot find module error, even though the path is correct.

Note that you can also use the following syntax to avoid needing to remember the relative paths...

...where @ signifies your src folder and image is the full filename.

thank you @kaankucukx, your suggestion is to work with charm, but your code is not beautiful with vue framework
thank you @LinusBorg, your advice is to work very beautiful
import Image from "../../assets/img/services/s1.png";
export default {
   data () {
     return {
       myPic: Image;
     }
   }
}

tested on vue cli 3

@aacassandra Thank you!
And you mean importing all images is fine? :)
So good luck with that. I believe that is uglier :(

thank you @kaankucukx, you remind me. I just found out that the way it loads all the images.

I did something like

@fralonra you are missing quotes on @/assets/logo.png.
Your :src attribute should looks like this :src="require('@/assets/logo.png')".

@TotomInc Thanks for your reply!
That's just a typo.I tried :src="require('@/assets/logo.png')"

file.html

file.js
image:require('@/assets/tutorial/onWhite.jpg'),

@routbiplab
It was my fault not pointing out what I want to do.
I want to load image dynamically, by setting image path in props or data.

the alt attribute is working fine but src attrib. is not working. Can anybody explain?????? PLZ!!!
<food-items itemPrice= 239 itemName="Desert"  image="./assets/images/desert.jpg"  altText="image here from app"></food-items>// App.vue
  //component food-item

@baagi-rebel
See here. https://github.com/vuejs-templates/webpack/issues/126.
In short, you should use require or import to tell webpack that this path is a module.

Hi, I can display image

but it just diplay after rendered

Do you know why it return [object Module]? please help me to resolve it :(

Hi, I can't display image, this is my code.

but it just diplay after rendered

Do you know why it return [object Module]? please help me to resolve it :(

Oh, I found the solutiton. just install url-loader :( OMG, thank you guys so much.

This works for me!! thanks