ethernet: stm32h7: fix tx semaphore timeout bug

Incomplete memory write causes issues with ethernet
transmission on stm32h747_disco_m7 board.
TxCpltCallback is never called, causing waiting for
tx_int_sem to timeout, and occationally hangs
ethernet communication.

Fixes issue https://github.com/zephyrproject-rtos/zephyr/issues/29915

I was continuing development on this change now and found out there is still problems when building with CONFIG_NO_OPTIMIZATIONS which we are doing in our project since CONFIG_DEBUG causes inconsistent debugging. As mentioned in https://github.com/zephyrproject-rtos/zephyr/pull/29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

I was continuing development on this change now and found out there is still problems when building with CONFIG_NO_OPTIMIZATIONS which we are doing in our project since CONFIG_DEBUG causes inconsistent debugging. As mentioned in https://github.com/zephyrproject-rtos/zephyr/pull/29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

Then I would wait with merge. Does dame semaphore timeout happens?

I was continuing development on this change now and found out there is still problems when building with CONFIG_NO_OPTIMIZATIONS which we are doing in our project since CONFIG_DEBUG causes inconsistent debugging. As mentioned in #29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

Then I would wait with merge. Does dame semaphore timeout happens?

Yes it is the same timeout. Should we put it in the HAL or can you suggest another way forward?

I was continuing development on this change now and found out there is still problems when building with CONFIG_NO_OPTIMIZATIONS which we are doing in our project since CONFIG_DEBUG causes inconsistent debugging. As mentioned in #29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

Then I would wait with merge. Does dame semaphore timeout happens?

Yes it is the same timeout. Should we put it in the HAL or can you suggest another way forward?

I was continuing development on this change now and found out there is still problems when building with CONFIG_NO_OPTIMIZATIONS which we are doing in our project since CONFIG_DEBUG causes inconsistent debugging. As mentioned in #29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

Then I would wait with merge. Does dame semaphore timeout happens?

Yes it is the same timeout. Should we put it in the HAL or can you suggest another way forward?

My opinion then, there is no need to put it in HAL. I think @erwango would agree.

As mentioned in #29944 the fix in HAL is the only solution that appears to work in all cases. We can still merge this, but I don't think it's good enough.

Then I would wait with merge. Does dame semaphore timeout happens?

Yes it is the same timeout. Should we put it in the HAL or can you suggest another way forward?

My opinion then, there is no need to put it in HAL. I think @erwango would agree.

As mentioned here yesterday, if it happens to be a real issue in HAL and the only good fix should be done in the HAL, it has to be fixed in the HAL.
Issues and PR could be submitted directly here: https://github.com/STMicroelectronics/STM32CubeH7.
If issue is acknowledged, we can live with a temp patch in hal_stm32 module waiting the official fix to be delivered.

Alright I've tried https://github.com/zephyrproject-rtos/zephyr/pull/29944#discussion_r522327392 but still no luck. However, as it turns out, enabling CONFIG_NO_OPTIMIZATIONS gives all different kinds of errors when starting to use more of Zephyr's features, most stack overflows as most of the default values are set based on CONFIG_DEBUG. So this is the least of somebody's problem who is trying to use CONFIG_NO_OPTIMIZATIONS. In our project we have decided to just use CONFIG_DEBUG.
So as the issue is resolved for CONFIG_DEBUG, I think it's okay to merge it. Looking at most other merge requests and default values, very few are even tested with CONFIG_NO_OPTIMIZATIONS. What is the general consensus about this?
And also, unfortunately, I don't have time to dig further into investigating and creating an issue at STM32CubeH7.

So as the issue is resolved for CONFIG_DEBUG, I think it's okay to merge it. Looking at most other merge requests and default values, very few are even tested with CONFIG_NO_OPTIMIZATIONS. What is the general consensus about this?

Maybe @jukkar would be the best to answer this (for current subsystem)

very few are even tested with CONFIG_NO_OPTIMIZATIONS. What is the general consensus about this?

It looks like if you disable optimizations, the stack usage increases and various network tests/samples start to fail. The stack usage in net would need to be fixed but probably not in this PR as it is a separate issue. @emillindq, could you create a GH issue for this so it is not lost.

very few are even tested with CONFIG_NO_OPTIMIZATIONS. What is the general consensus about this?

It looks like if you disable optimizations, the stack usage increases and various network tests/samples start to fail. The stack usage in net would need to be fixed but probably not in this PR as it is a separate issue. @emillindq, could you create a GH issue for this so it is not lost.

This phenomenon is actually mentioned in several issues, for instance https://github.com/zephyrproject-rtos/zephyr/issues/19340#issue-497527773 and https://github.com/zephyrproject-rtos/zephyr/issues/30028. Sadly the first one has been marked as low-priority. In reality, I've had horrible debugging experience with CONFIG_DEBUG; just today pc was jumping around like a frog when stepping making debugging impossible. I don't know if it's like that on other boards, but for stm32h747i_disco CONFIG_NO_OPTIMIZATIONS is required for debugging. I'll see if I can create a separate issue about that.
Honestly I feel like this shouldn't be merged. I'm generally not in favor of ghetto solutions that works in some of the cases with obscure connection to the issue at hand. I don't know why this fix works. I think it's better to keep the codebase clean and address the source of the issue instead (which obviously this PR doesn't do). I'll see if I can port some sample ST ethernet code from H743 to H747 and create an issue/PR in STM32 HAL repo instead.
But should I create a PR involving the __DSB() in the zephyrproject-rtos/hal_stm32 in the meantime? That fix appears to go to the root of the problem as it works for all cases. It seems like a much better choice than merging this. What do you think @Nukersson @erwango @lochej ?

@emillindq Can you try __DSB() approach in with this PR #29676?

@emillindq

I think it's better to keep the codebase clean and address the source of the issue instead (which obviously this PR doesn't do). I'll see if I can port some sample ST ethernet code from H743 to H747 and create an issue/PR in STM32 HAL repo instead.

Being able to reproduce on ST Ethernet code is a good thing but not a prerequisite to raise issues on STM32 HAL repo.
ST ethernet code is proposed as one working example. As long as the bug you're facing is visible while you're using the HAL correctly, it is valid.

But should I create a PR involving the __DSB() in the zephyrproject-rtos/hal_stm32 in the meantime? That fix appears to go to the root of the problem as it works for all cases. It seems like a much better choice than merging this. What do you think @Nukersson @erwango @lochej ?

Yes, you can create this PR on hal_stm32. Though, it won't be merged before we have a first feedback on the HAL issue.

@emillindq

I think it's better to keep the codebase clean and address the source of the issue instead (which obviously this PR doesn't do). I'll see if I can port some sample ST ethernet code from H743 to H747 and create an issue/PR in STM32 HAL repo instead.

Being able to reproduce on ST Ethernet code is a good thing but not a prerequisite to raise issues on STM32 HAL repo.
ST ethernet code is proposed as one working example. As long as the bug you're facing is visible while you're using the HAL correctly, it is valid.

But should I create a PR involving the __DSB() in the zephyrproject-rtos/hal_stm32 in the meantime? That fix appears to go to the root of the problem as it works for all cases. It seems like a much better choice than merging this. What do you think @Nukersson @erwango @lochej ?

Yes, you can create this PR on hal_stm32. Though, it won't be merged before we have a first feedback on the HAL issue.

https://github.com/STMicroelectronics/STM32CubeH7/issues/95
Thanks!

Moving to D2 domain SRAM:

/* System data RAM accessible over AHB bus: SRAM1 in D2 domain */
sram1: memory@30000000 {
reg = <0x30000000 DT_SIZE_K(288)>;
compatible = "mmio-sram";
};

and compiling with:

CONFIG_NET_L2_ETHERNET=y
CONFIG_ETH_STM32_HAL=y
CONFIG_DEBUG=y

and running:

ab -n 1000 -c 1 http://<IP_ADDRESS>:8080/

without __DSB() approach (this PR) produces:

Connection #502 from <IP_ADDRESS>
Connection from <IP_ADDRESS> closed
[00:00:25.773,000]  eth_stm32_hal: HAL_ETH_TransmitIT tx_int_sem take timeout
[00:00:25.773,000]  eth_stm32_hal: eth packet timeout
a8 a1 59 2a 76 b6 02 80  e1 5e 68 0a 08 00 45 00 |..Y*v... .^h...E.
00 28 00 00 00 00 40 06  f6 a8 c0 00 02 01 c0 00<EMAIL_ADDRESS>........
02 26 1f 90 c3 88 b0 86  2e 2f b5 5c 68 97 50 11 |.&...... ./.\h.P.
05 00 46 e9 00 00

any update on this?

any update on this?

I think this is the most feasible solution https://github.com/zephyrproject-rtos/zephyr/pull/30403
I'm closing this pull request. As I said before, this solution is quite ghetto and doesn't go to the root of the problem so I feel like it shouldn't be merged anyways.
I'm acting as a tech lead in my company, and we have simply cloned the HAL, made the HAL change mentioned and then moved on.


#22731 update varchar max length syntax for non-sql server databases

I checked Synapse and Babelfish documentation. Looks like the support varchar(max). So, I've added this type of condition (because Sybase has an SQLServerGenericDatasource class).

So, please check:

[x] Case from the ticket (with string ~ 8000 symbols)
[x] Import in SQL Server (still varchar(max))

verified


UTC vs Local Time

Nudge uses UTC time which can make timing of things challenging when there are multiple offices across different time zones.
You either have to set the time when it isn't convenient for some or multiple profiles have to be set.

Is there a way to use local time?
What was the reasoning behind UTC?
Any interest in a PR for the ability to use local time?

https://github.com/macadmins/nudge/issues/437
https://github.com/macadmins/nudge/issues/386

I fully endorse the lazy when dealing with dates and times and zones and nonsense and copying munkis method is also good.
Slack good place?

We can do it here if you don't mind.

So I was thinking a config option under optionalFeatures like useLocalTime so people can opt in.
I see the line
let dateFormat = "yyyy-MM-dd HH:mm:ss Z"
and
dateFormatterISO8601.timeZone = TimeZone(identifier: "UTC")
in 2 places in Util.swift
I'm guessing those are the key. It may be as simple as throwing an if statement around that area, and if you want to use local time have system determine the local time zone and use that in the date format.
Thoughts?

Not sure how difficult it would be to port to Nudge, but I think these are the relevant bits for how Munki handles things:
https://github.com/munki/munki/blob/4e35f56b9c19d3dff3dc1bd85c634cbc1b507938/code/apps/Managed Software Center/Managed Software Center/MunkiItems.swift#L958-L959
https://github.com/munki/munki/blob/4e35f56b9c19d3dff3dc1bd85c634cbc1b507938/code/apps/Managed Software Center/Managed Software Center/munki.swift#L300-L308

What's unclear to me is what is the expected date an admin puts in? They can't put UTC now, so it needs to be a new date format.
Or are we saying continue to use the UTC date format but if an admin says 08:00:00 it means 8am locally and 20:00:00 means 8pm locally? If so that makes sense to me but may be confusing to others.

Yes! Completely that exactly.

I’m not sure how to not be confusing though.  But if the admin enables the setting useLocalTime then they kind of should know what they’re getting into?
A thought could be change the default to always have the Z at the end and really stress it’s UTC.  So the admin doesn’t have to enter it.
Or go the opposite, local time becomes the default and UTC is a choice.

I believe, based the Munki code I posted above, that Munki just chops the z off the end, and then assumes local time. It's still in the XML, but the Munki documentation says local time is used.

I think keeping the time format identically as it is now and then have an optional key makes the most sense. It will be the least amount of code changes.

That’s probably very true. I’ll see if I can whip something together this weekend.

Multinational companies might want to give their users the same deadline in their own local time, to be fair to all.  We have employees that wrap the globe from Hawaii to Sydney.  If we send an email announcing that users have "until 5pm Friday to apply this update," then the statement should be true for anyone.

Yes that's what he's proposing. I'm just trying to ensure we don't add a ton of complexity because time is used in other locations.

Well that was unexpected. Since a date in a configuration profile is an NSDate, it requires something like a Z at the end to be valid. Unless that's changed to a string, this idea may be dead.

Technically it accepts strings in the mobileconfig because JAMF does some really silly things but I've never been too public with that.
That said, why can't we keep the format and just convert to the local timezone?

I figured it would probably accept a string.
So if useLocalTime is set, it ignores the Z?

Another stumbling point. Swift only includes these TimeZone abbreviations. And well...there's quite a few more.
"BST": "Europe/London",
"UTC": "UTC",
"CAT": "Africa/Harare",
"WIT": "Asia/Jakarta",
"IST": "Asia/Kolkata",
"PET": "America/Lima",
"NZST": "Pacific/Auckland",
"AKST": "America/Juneau",
"MDT": "America/Denver",
"CST": "America/Chicago",
"ICT": "Asia/Bangkok",
"PST": "America/Los_Angeles",
"BRST": "America/Sao_Paulo",
"EAT": "Africa/Addis_Ababa",
"CEST": "Europe/Paris",
"NST": "America/St_Johns",
"WEST": "Europe/Lisbon",
"NDT": "America/St_Johns",
"PHT": "Asia/Manila",
"COT": "America/Bogota",
"EET": "Europe/Athens",
"MSK": "Europe/Moscow",
"JST": "Asia/Tokyo",
"ADT": "America/Halifax",
"TRT": "Europe/Istanbul",
"GST": "Asia/Dubai",
"NZDT": "Pacific/Auckland",
"CLT": "America/Santiago",
"CDT": "America/Chicago",
"CET": "Europe/Paris",
"BRT": "America/Sao_Paulo",
"EDT": "America/New_York",
"SGT": "Asia/Singapore",
"HST": "Pacific/Honolulu",
"EST": "America/New_York",
"WAT": "Africa/Lagos",
"HKT": "Asia/Hong_Kong",
"KST": "Asia/Seoul",
"CLST": "America/Santiago",
"GMT": "GMT",
"PDT": "America/Los_Angeles",
"BDT": "Asia/Dhaka",
"AKDT": "America/Juneau",
"MST": "America/Phoenix",
"IRST": "Asia/Tehran",
"WET": "Europe/Lisbon",
"AST": "America/Halifax",
"MSD": "Europe/Moscow",
"PKT": "Asia/Karachi",
"ART": "America/Argentina/Buenos_Aires",
"EEST": "Europe/Athens"

This would cover most major areas I believe, but using my obscure test..the country of Nauru is Pacific/Nauru and the abbreviation is NRT but swift doesn't include it. When I set my location to that in System Settings, it identifies as that timezone(Pacific/Nauru). And it looks like the abbreviation is needed for some ISO 8601 conversions.

Yay swift lol. This is why I hate dealing with dates and times.

So if useLocalTime is set, it ignores the Z?

That's what I would do to reduce code complexity. It then becomes a literal time to the local time in 24 hour time format.

How does this affect your deferrals?  It's still adding +launchdinterval, +3600, or +86400 to the last time the button was clicked, regardless of local time, correct?
And the requiredInstallationDate should not care about the UTC vs local time, it just needs to know "what time is this due."
Is that right?

Yes. IMO all this should impact is how the requiredInstallDate is processed and normalized to the local time zone. All other logic should stay intact so as not to break everything else.

@erikng trying to figure out either a way to query some random thing like even Wikipedia to get that list live or even just get that actual list and make an include file of the couple hundred time zone abbreviations

Neither sound ideal. I don't want nudge calling out to endpoints outside of our control and a hardcoded list seems non ideal to me. Perhaps you are overthinking this.
Take the UTC time as a literal time and compare it against the local time in a 24 hour format. I'm not sure why you want to convert the UTC at all but perhaps I'm missing something you've discovered.

So Swift doesn't check the definitions at /usr/local/timezone?
I realize not having Nauru is kind of an edge case, but does Swift fallback to another nearby location / time zone if you are in Nauru?  Can you spoof your location?  Or change it in System Preferences to simulate it?

@bradtchapman If you do a swift playground, change your location to Nauru in System Settings
let timeZone = TimeZone.current.identifier

print("Current: \(timeZone)")
let TZAD = TimeZone.abbreviationDictionary
let timeZoneIdentifiers = TimeZone.knownTimeZoneIdentifiers
print(timeZoneIdentifiers)

This prints out Current: Pacific/Nauru - you'll see Pacific/Nauru isnt listed. Nauru might be an edge case, but I'm sure there's less edgy cases not covered. Maybe UTC is the choice for them.
/var/db/timezone/tz/ and /usr/share/zoneinfo seem to have useful info, but it maybe looks more like the UTC offset - I'll have to dig deeper.
@erikng in order to convert UTC to local, you gotta do a dateFormatter.timeZone = TimeZone.current - but maybe I'm over complicating by converting back using ISO8601DateFormatter()
More keyboard banging will commence later on.

import Cocoa

let timeZone = TimeZone.current.identifier
print("Current: \(timeZone)")
let local = TimeZone.current.identifier
let localDate = Date()
print("UTC Time--",localDate)
let dateFormatter = DateFormatter()
dateFormatter.dateFormat = "yyyy-MM-dd HH:mm:ss Z"
dateFormatter.timeZone = TimeZone(abbreviation: "UTC")

var myDate = dateFormatter.string(from: localDate)
var convertedLocalTime = ""

if let dt = dateFormatter.date(from: myDate) {
    dateFormatter.timeZone = TimeZone.current
    dateFormatter.dateFormat = "yyyy-MM-dd H:mm:ss Z"
    convertedLocalTime = dateFormatter.string(from: dt)
} else {
    print("There was an error decoding the string")
}

print("convertedLocalTime String--",convertedLocalTime)
let isodateFormatter = ISO8601DateFormatter()
isodateFormatter.timeZone = TimeZone(identifier: local)
isodateFormatter.formatOptions = [.withFullDate, .withDashSeparatorInDate,.withSpaceBetweenDateAndTime,.withFullTime,.withColonSeparatorInTime]
let date = isodateFormatter.date(from:convertedLocalTime)
print("convertedLocalTime ISO--",date!)

Doing this in a playground with my local time results in
Current: America/New_York
UTC Time-- 2023-03-19 01:53:45 +0000
convertedLocalTime String-- 2023-03-18 21:53:45 -0400
convertedLocalTime ISO-- 2023-03-19 01:53:45 +0000

I believe things need to go back to an ISO formatted date.
According to https://developer.apple.com/documentation/foundation/dateformatter - Apple recommends

In macOS 10.12 and later or iOS 10 and later, use the ISO8601DateFormatter class when working with ISO 8601 date representations.

But as you can see convertedLocalTime ISO is not correct. I'm guessing it's due to the wrong format somehow.

Now try using different calendars other than Gregorian and watch the world blow up. :)

"The requiredInstallationDate field supports digits and dashes only, and all deadlines must conform to the Gregorian calendar.  Dates expressed using the Hebrew, Indian, Muslim, Chinese, or other lunar or quasi-lunar calendars will not be processedx and Nudge will not launch."
You can't accommodate everyone. You'll make yourself nuts.
—Sent from my iPhone

On Mar 18, 2023, at 7:11 PM, Erik Gomez @.***> wrote:

Now try using different calendars other than Gregorian and watch the world blow up. :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

Maybe this is dead until people much smarter than me can figure it out
import Cocoa

let localISOFormatter = ISO8601DateFormatter()
localISOFormatter.timeZone = TimeZone.current
let ISOstring = localISOFormatter.string(from: Date())
print("ISO String--",ISOstring)
let ISODate = localISOFormatter.date(from: ISOstring)
print("ISO Date--",ISODate!)

Outputs
ISO String-- 2023-03-19T14:41:42-04:00
ISO Date-- 2023-03-19 18:41:42 +0000

So maybe Date type is always UTC? 🤷🏻🤷🏻

I think I was going down the wrong path.  I was trying to convert in Utils() the getCurrentDate and the other to nonUTC
But another of the problem is after doing research and talking to some people.  Date type is really a double that’s EPOCH.
So unless the config profile was changed to a String (which you said it does accept) you can’t have a Date type in a configuration profile that’s not UTC. It’s just how it is.
I’m wondering if this may sort of already work in a way to use local time since you’ve done the hard work to allow it to accept a string that gets converted to a date.
More testing to occur tomorrow.
Apologies for the rambling in the Issue ticket, it’s been helpful as sort of notes. And it may be helpful for others to see how confusing a “simple” change could actually be.

OK! I have an answer @erikng. And the answer is...Nudge already does it!
When you use a String, it has to convert to a Date. And it by default uses the local time zone.
without Z in the date string
Desired 2023-03-19T14:40:00
PST UTC Required Installation Date: 2023-03-19 21:40:00 +0000
PST UTC Required Installation Date: 2023-03-19 18:40:00 +0000

with Z in the date string
Desired 2023-03-19T14:40:00
PST UTC Required Installation Date: 2023-03-19 21:40:00 +0000
EST UTC Required Installation Date: 2023-03-19 18:40:00 +0000

If I use a Date in the config profile
Desired 2023-03-19T14:40:00
PST UTC Required Installation Date: 2023-03-19 14:40:00 +0000
EST UTC Required Installation Date: 2023-03-19 14:40:00 +0000

So no pull request needed. Just maybe something added to the wiki, if you want to use local time, use a string.

Amazing lol. Good job old Erik!

@boberito: can you update the wiki to explain what you found?  Thanks!

@bradtchapman I'll knock that out today.

Wiki is updated: https://github.com/macadmins/nudge/wiki/osVersionRequirements#requiredinstallationdate---type-string-for-json-string-or-date-for-profile-default-value--required-yes

Could the logic be updated to make JSON configs work the same? Yes, the JSON var is always going to be a string, but we could deal with that by making it such that Nudge accepts a timestamp with or without the Z. If it has a Z, deadline is in UTC time (i.e. same as the <date>); without it's in local time (i.e. same as <string>).

I'm going to leave this open until we can figure out local time on JSON.

Didn't @boberito figure this out by dropping the "Z" off the end of the time stamp?

Bump @erikng @boberito : I think this issue can be satisfied by users not adding "Z" to the end of the requiredInstallationDate.  This has worked well for us.  Thoughts?

Closing since I fixed the bug reported here: https://github.com/macadmins/nudge/issues/567
I've tested both types of configs and they are working as expected.


Add information about '--directory' in Examples README.md

Goal is to add sections about encrypting and decrypting whole directories. Append in this file:  https://github.com/Veinar/envcloak/blob/develop/examples/cli/README.md
Basically copy paste section about encryption and decryption but edit it to show --directory rather than --input usage. Plus mention --force as it is done in section about single files.
Remember that envcloak process files in batch one by one if it encrypts/decrypts whole directories.

@Veinar can I work on this issue?


UI Issue : dropdown popup positioning in contents page

Describe the bug
https://demo.plone.org/contents on this page when we click on 3 dots dropdown a dropdown popup appears . Due to that dropdown popup unnecessary extra space is there below footer due to the position of dropdown popup .

Go to 'https://demo.plone.org/contents'
Click on '3 dots dropdown in actions'
scroll bar appears at right scroll it
at bottom you will find extra space

Video for better understanding:
https://github.com/plone/volto/assets/92856810/e6287494-f50e-4c19-98f5-2d622bdecd86

Hello, I think I can solve this issue. I am new to Plone and want to start contributing by resolving this.

Cool 👍

The video does not demonstrate the issue, but this screenshot does.

I think that when anything extends the height of the canvas, then either the height of the doormat or the main content container should be extended.
Extend height of doormat
Note that the padding leaves an unattractive empty space below the grey.

Extend the height of the page
This example looks cleaner.

The following CSS might not work for non-webkit browsers, so a more comprehensive solution may be needed.
#main > div.ui.basic.segment.content-area {
  height: -webkit-fill-available;
}

is this issue open

@whoisgautxm what about the GitHub interface is not clear?

Also please read and follow Contributing to Plone and First-time contributors.

Per https://github.com/plone/volto/pull/5571#issuecomment-1868891037:

All menus in Volto must use PopperJS as in
https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/BlockChooser/BlockChooserButton.jsx#L84-L104

https://popper.js.org/ for demos.

Hey, I can I start working on this issue?

@AdityaBhate please read and follow Contributing to Plone and First-time contributors. It's your responsibility to see if there are open pull requests that have a viable solution to avoid duplicating effort.

I am willing to work on this issue, but before than can I please get a guide for the installation.

@AritraLeo hint: for every open source software project, there is usually a file at the root of the repository called README.md with links to documentation and how to install it for development. Now you know. But for convenience, Develop Volto core.
Additionally most projects have a CONTRIBUTING.md that you should follow.
Finally before doing any work, please read and follow Contributing to Plone and First-time contributors.

@nimishmedatwal try vertical scrolling of the affected page, in addition to horizontal resizing. Popper.js should accommodate the browser window size and relative positioning when scrolling, as shown in its demos. IMO the right-center positioning is a weird choice, and I would stick with the default option, allowing Popper.js to work its magic.

I am working on this issue

@stevepiercy I think this issue is fixed , can you please confirm this ? Thanks

@shubham-200315 sorry, but nope, that is your job as a developer. And why are you asking me when you can confirm it yourself? See Item 4 in https://6.docs.plone.org/contributing/first-time.html#things-not-to-do.
Also please read and follow Contributing to Plone and First-time contributors.

@stevepiercy , I'm sorry bout that Absolutely it was not intended that way and infact I have already read whole v6 doc . I just recreated this issue in my local and also on demo one and it's was working fine , so it was just a concern that you can close this issue if it's okay from your end.

/assign


Enhance maintainability and performance

This PR aims to improve code readability, efficiency, and maintainability. In particular:

Introduces a registry for managing calls to integrators, improving overall readability and maintainability
Increases memory efficiency in high_level.Model.valid() with generators
Improves readability in dictionaries iterations
Removes calls to dict() for better performance (see Performance Analysis of Python’s dict() and {})
Implements set comprehension instead of using list comprehension and the convert them to sets
Cleans up the codebase by removing unnecessary imports.

📚 Documentation preview 📚: https://jaxsim--78.org.readthedocs.build//78/

A comment. I'm not really sure if the performance analysis that usually apply to plain Python code is valid also here with jitted code. For example, one way to check e.g. the dict construction is to create two simple functions and check the resulting IR with jax.make_jaxpr. I suspect that it outputs same expression regardless to the construction. However, perhaps it runs more efficiently during the creation of the expression, so it may not be entirely useless.

You were right, the jaxpr is the same:
In [3]: jax.make_jaxpr(lambda k,v: dict(k=v))(k,v)
Out[3]: { lambda ; a:i32[] b:i32[]. let  in (b,) }

In [4]: jax.make_jaxpr(lambda k,v: {k:v})(k,v)
Out[4]: { lambda ; a:i32[] b:i32[]. let  in (b,) }

It does run slightly faster, but I'm pretty sure it won't make a huge difference when the code is compiled
In [3]: %timeit dict(k=v)
63.3 ns ± 4.07 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

In [4]: %timeit {k:v}
52.8 ns ± 3.91 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

In [5]: %timeit jax.make_jaxpr(lambda k,v: dict(k=v))(k,v)
186 µs ± 6.1 µs per loop (mean ± std. dev. of 7 runs, 10,000 loops each)

In [6]: %timeit jax.make_jaxpr(lambda k,v: {k:v})(k,v):
179 µs ± 2.36 µs per loop (mean ± std. dev. of 7 runs, 10,000 loops each)


Specify default image

Is your feature request related to a problem? Please describe.
I'm dragging and dropping notebooks to the canvas and always need to select the same container image to pass validation, although the large majority of notebooks are happy with the same image
Describe the solution you'd like
In the metadata editor for the images add an option where one image can be set as default image. Then, when dragging notebooks to the canvas, this one is automatically selected
Describe alternatives you've considered
Doing it by hand which is a little teadious

Functionality is already available. Refer to https://elyra.readthedocs.io/en/latest/user_guide/pipelines.html#runtime-image


[BUG] Action with arrayed input parameter containing string enum yields to failed typer compilation

Is there an existing issue for this?

[X] I have searched the existing issues

Nature of Your Project
TypeScript
Current Behavior
Given an action such as:
    action   test( @mandatory array : array of {
        @mandatory testInput : String not null enum {
            anEntry;
        };
    } not null)

Yields to a failed compilation with the error message:
CDSError: Could not (re)generate types for model. Could not read file content of *: Failed<EMAIL_ADDRESS>"*" --outputDirectory "/[...]/@cds-models"
<exit code:>
1
<stderr:>
/[...]/node_modules/@cap-js/cds-typer/lib/util.js:69
        n = n.match(last)[0]
              ^

TypeError: n.match is not a function
    at Object.singular4 (/[...]/node_modules/@cap-js/cds-typer/lib/util.js:69:15)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:376:46)
    at Resolver.resolveAndRequire (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:220:31)
    at StructuredInlineDeclarationResolver.visitElement (/[...]/node_modules/@cap-js/cds-typer/lib/components/inline.js:70:44)
    at Visitor.visitElement (/[...]/node_modules/@cap-js/cds-typer/lib/visitor.js:459:47)
    at StructuredInlineDeclarationResolver.resolveInlineDeclaration (/[...]/node_modules/@cap-js/cds-typer/lib/components/inline.js:43:57)
    at #resolveInlineDeclarationType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:425:55)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:396:47)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:392:18)
    at Resolver.resolveAndRequire (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:220:31)

Node.js v20.10.0
CDSError: Could not (re)generate types for model. Could not read file content of *: Failed<EMAIL_ADDRESS>"*" --outputDirectory "/[...]/@cds-models"
<exit code:>
1
<stderr:>
/[...]/node_modules/@cap-js/cds-typer/lib/util.js:69
        n = n.match(last)[0]
              ^

TypeError: n.match is not a function
    at Object.singular4 (/[...]/node_modules/@cap-js/cds-typer/lib/util.js:69:15)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:376:46)
    at Resolver.resolveAndRequire (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:220:31)
    at StructuredInlineDeclarationResolver.visitElement (/[...]/node_modules/@cap-js/cds-typer/lib/components/inline.js:70:44)
    at Visitor.visitElement (/[...]/node_modules/@cap-js/cds-typer/lib/visitor.js:459:47)
    at StructuredInlineDeclarationResolver.resolveInlineDeclaration (/[...]/node_modules/@cap-js/cds-typer/lib/components/inline.js:43:57)
    at #resolveInlineDeclarationType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:425:55)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:396:47)
    at Resolver.resolveType (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:392:18)
    at Resolver.resolveAndRequire (/[...]/node_modules/@cap-js/cds-typer/lib/components/resolver.js:220:31)

Node.js v20.10.0

Expected Behavior
I'd expect the compilation to work.
Steps To Reproduce
No response
Environment
- **OS**: MacOs
- **Node**: v20.10.0.
- **npm**:
- **cds-typer**: 0.13.0
- **cds**:7.4.2

Repository Containing a Minimal Reproducible Example
No response
Anything else?
No response

Hi Tobias,
this one is surprisingly less benign than scalar enum types for action parameters. I have opted to instead use the encapsulating type for now. I.e. instead of a fully type-safe parameter type 'A' | 'B' | 'C' you'll get string. But it should at least compile now. Feel free to try it out before I merge.
Best,
Daniel


Igonchar/tdi 44153 disable components

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-44153
What is the new behavior?
Please check if the PR fulfills these requirements

[ ] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

The build was ok. Sonar failed


Improve Miniflare Magic Proxy

What this PR solves / how to test
This fixes a number of issues with the Miniflare magic proxy, including:

Fixes #5575
Fixes #5577 (partial support, not including calling returned functions)

Author has addressed the following

Tests

[ ] TODO (before merge)
[x] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[x] TODO (before merge)
[ ] Included
[ ] Not necessary because:

Public documentation

[ ] TODO (before merge)
[ ] Cloudflare docs PR(s): https://github.com/cloudflare/cloudflare-docs/pull/...
[x] Not necessary because: bugfixes

With the correct env variables the wrangler AI e2e passes locally:

on Github I think we need to set:
WRANGLER_IMPORT (to: packages/wrangler/wrangler-dist/cli.js)
and make sure that the CLOUDFLARE_API_TOKEN grants access to Workers AI (I've tested with this with my own Cloudflare account id and api token)
I don't think I have permissions to do the above, maybe someone could help me? 🙂 @petebacondarwin? 🙏

[!NOTE]
The wrappedBindings support is not perfect, it seems to break in some cases: https://github.com/dario-piotrowicz/miniflare-wrappedBindings-getBindings-function-stringification-error-repro
but it is good enough for the AI binding, so if it'd be acceptable I'd like to proceed with the current solution
(to enable AI binding proxies as soon as we can) and address the above issue as a follow up


Slice.h can't take negative step value

Need to change DIMENSION to long, this will break many things!
Step value can be negative, that will start printing element from the end, and stop at start.

Fixed in last checkin https://github.com/ai-techsystems/dnnCompiler/commit/fe49e51fcf87314aa212f9c7e793ba2e953ac628


Redirect all routes to a single page with some exception

In a SPA settings, I'm prerendering the some landing pages for SEO and perf. But I can't figure out the corresponding rewrites rules.
So far, I've tried:
{
	"rewrites": [
		{ "source": "", "destination": "prerender/landing.html" },
		{
			"source": "/landing-2",
			"destination": "prerender/landing-2.html"
		},
		{ "source": "**", "destination": "index.html" }
	],
...
}

This doesn't work because apparently, all the rewrites rules are applied to the path (instead of stopping after the first match).
The problem is that I can't seem to find a way to negate the two prerendered path in the last rule, using minimatch.
What would be the proper way to handle this use case ? Is it even possible ?
Thanks!

For anyone else finding this issue - I had some success for my use case for making apple-app-site-association accessible (rewrites all routes for a react page using serve-handler, except for specified routes):
{
      rewrites: [
            {
                source: "/**!(apple-app-site-association)", destination: "/index.html"
            },
            {
                source: "/**/**", destination: "/index.html"
            },
            {
                source: "/apple-app-site-association",
                destination: "/apple-app-site-association.json"
            },

       ]
}

First entry rewrites all route endpoints except /apple-app-site-association to /index.html
Second rewrites everything in nested routes to /index.html
(Third one rewrites apple-app-site-association to a json file of the same name)

Hope this helps someone!

shameless self-promotion alert:this feature is available in my @warren-bank/serve fork of serve
both redirects and rewrites support an optional boolean terminal attribute, which will prevent any additional rules from being processed.


Make the kwok chart support hostNetwork to avoid the issue #819

What type of PR is this?
/kind feature

What this PR does / why we need it:
I use the helm chart to deploy kwok on the kind cluster. To avoid the kindnet pods crash(#819 ), I need to set the hostNetwork of the kwok deployment as true
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/approve
/lgtm

/release-note-none


feat: label generated code

small  PR for issue #42 . I believe this is what the request feature was intended to do. It's a bit unclear if you wanted something a bit more involved or a different approach. lmk what you think

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Zane Starr seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@zcstarr Thank you very much for the contrib. Much appreciated.
Looks like we have to sort out CI for forks sooner than I thought!! haha thank you!
Give me a day or so to get CI running against this branch, and then LGTM!
🎉

@zcstarr created #102 to track getting it fixed

Should be all set now.
Just need you to sign your commit.

@shanejonas commit signed PTAL when you get a chance, also I signed the contributor license agreement as well, as an fyi. Thanks!

@zcstarr just need to upload your public key to github to verify it:

@shanejonas thanks I'm finally verified \o/ gpg'd up.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add user contribution events API

Fixes : #250
https://docs.gitlab.com/ce/api/events.html

I moved things around, added a second commit for the renaming of the files. I felt it was awkward without that first commit.

LGTM! 🎉 💯 👍
Thanks!


Direct Response Route incorrectly being configured

Description:
Since upgrading to v1.2.1, we have noticed one of our HTTPRoutes behaving in an odd way. It appears that some HTTPRoutes are being translated into EG routes with a direct response of 500.
Rolling back to v1.1.0 fixes this.
Repro steps:
We have a HTTPRoute that looks something like:
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: account-mapping
spec:
  hostnames:
  - account.dev.web.io
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: dev
    namespace: envoy-gateway
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /

I would expect this to produce a route that looks something like this:
{
    "match": {
        "prefix": "/"
    },
    "metadata": {
        "filterMetadata": {
            "envoy-gateway": {
                "resources": [
                    {
                        "kind": "HTTPRoute",
                        "name": "account-mapping",
                        "namespace": "dev"
                    }
                ]
            }
        }
    },
    "name": "httproute/dev/account-mapping/rule/0/match/0/account_dev_web_io",
    "route": {
        "cluster": "httproute/dev/account-mapping/rule/0",
        "upgradeConfigs": [
            {
                "upgradeType": "websocket"
            }
        ]
    }
}

However, we are ending up with a translated route that looks like this:
{
    "directResponse": {
        "status": 500
    },
    "match": {
        "prefix": "/"
    },
    "metadata": {
        "filterMetadata": {
            "envoy-gateway": {
                "resources": [
                    {
                        "kind": "HTTPRoute",
                        "name": "account-mapping",
                        "namespace": "dev"
                    }
                ]
            }
        }
    },
    "name": "httproute/dev/account-mapping/rule/0/match/0/account_dev_web_io"
}

Note: If there are privacy concerns, sanitize the data prior to
sharing.

Environment:
Envoy Gateway v1.2.1
Logs:
{
    "bytes_received": 0,
    "x-forwarded-for": "xxxxx",
    "protocol": "HTTP/1.1",
    "response_code": 500,
    "route_name": "httproute/dev/account-mapping/rule/0/match/0/account_dev_web_io",
    "downstream_remote_address": "xxxx",
    "response_flags": "-",
    "start_time": "2024-11-11T15:36:09.995Z",
    "authority": "account.dev.web.io",
    "x-request-id": "8503f06f-60a6-4fe7-90ac-36c970aaa6c1",
    "bytes_sent": 0,
    "response_code_details": "direct_response",
    "downstream_local_address": "xxxxx",
    "method": "GET",
    "x-envoy-origin-path": "/",
    "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36",
    "duration": 0
}

@alexandermarston If there's no valid backend, the route will response a 500. Can you check if the account service exists with kubectl -n envoy-gateway get service account

@alexandermarston If there's no valid backend, the route will response a 500. Can you check if the account service exists with kubectl -n envoy-gateway get service account

The service definitely exists.
I've updated the main Issue to also reflect that we have another HTTPRoute (for the same domain) with two rules, which evaluate fine and we are able to access them.

@alexandermarston The failed HTTPRoute and the succeeded one are referencing account service in diffrenent namespaces.
Failed one: default/account
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: account-mapping
spec:
  hostnames:
  - account.dev.web.io
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: dev
    namespace: envoy-gateway
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /

Succeeded one: dev/account
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: account-mapping-unauthenticated-0
  namespace: dev
spec:
  hostnames:
  - account.dev.web.io
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: dev
    namespace: envoy-gateway
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: Exact
        value: /countries

@zhaohuabing sorry, I missed the namespace from the account-mapping HTTPRoute. It is there

Or on any of the policies ( backendtrafficpolicies )

Looks like a bug, I reproduced it in my test env.

For the HTTPRoute
status:
  parents:
  - conditions:
    - lastTransitionTime: "2024-11-11T15:31:20Z"
      message: Route is accepted
      observedGeneration: 14
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-11-11T15:31:20Z"
      message: Resolved all the Object references for the Route
      observedGeneration: 14
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs
    controllerName: gateway.envoyproxy.io/gatewayclass-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: dev
      namespace: envoy-gateway

There are no BackendTrafficPolicies attatched.

@alexandermarston could you please share the result of these command?
kubectl -n envoy-gateway get Gateway dev -oyaml
kubectl -n dev get HTTPRoute account-mapping -oyaml
kubectl -n dev get svc account
kubectl -n dev get endpoints account

➜  ~ kubectl -n envoy-gateway get Gateway dev -oyaml
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  creationTimestamp: "2024-05-14T10:59:53Z"
  generation: 5
  labels:
    kustomize.toolkit.fluxcd.io/name: infrastructure
    kustomize.toolkit.fluxcd.io/namespace: flux-system
  name: dev
  namespace: envoy-gateway
  resourceVersion: "1276133463"
  uid: c73dfc89-48c6-4aea-892a-52598f65b51d
spec:
  gatewayClassName: dev
  listeners:
  - allowedRoutes:
      kinds:
      - group: gateway.networking.k8s.io
        kind: HTTPRoute
      namespaces:
        from: Selector
        selector:
          matchExpressions:
          - key: kubernetes.io/metadata.name
            operator: In
            values:
            - dev
    name: http
    port: 443
    protocol: HTTP
status:
  addresses:
  - type: Hostname
    value: xxxx.elb.eu-west-1.amazonaws.com
  conditions:
  - lastTransitionTime: "2024-11-11T15:33:25Z"
    message: The Gateway has been scheduled by Envoy Gateway
    observedGeneration: 5
    reason: Accepted
    status: "True"
    type: Accepted
  - lastTransitionTime: "2024-11-11T17:16:12Z"
    message: Address assigned to the Gateway, 3/3 envoy replicas available
    observedGeneration: 5
    reason: Programmed
    status: "True"
    type: Programmed
  listeners:
  - attachedRoutes: 105
    conditions:
    - lastTransitionTime: "2024-11-11T15:33:25Z"
      message: Sending translated listener configuration to the data plane
      observedGeneration: 5
      reason: Programmed
      status: "True"
      type: Programmed
    - lastTransitionTime: "2024-11-11T15:33:25Z"
      message: Listener has been successfully translated
      observedGeneration: 5
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-11-11T15:33:25Z"
      message: Listener references have been resolved
      observedGeneration: 5
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs
    name: http
    supportedKinds:
    - group: gateway.networking.k8s.io
      kind: HTTPRoute

➜  ~ kubectl -n dev get httproute account-mapping -oyaml
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: account-mapping
  namespace: dev
spec:
  hostnames:
  - account.dev.web.io
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: dev
    namespace: envoy-gateway
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /
status:
  parents:
  - conditions:
    - lastTransitionTime: "2024-11-11T15:31:20Z"
      message: Route is accepted
      observedGeneration: 14
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-11-11T15:31:20Z"
      message: Resolved all the Object references for the Route
      observedGeneration: 14
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs
    controllerName: gateway.envoyproxy.io/gatewayclass-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: dev
      namespace: envoy-gateway

➜  ~ kubectl -n dev get httproute account-mapping-unauthenticated-0 -oyaml
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: account-mapping-unauthenticated-0
  namespace: dev
spec:
  hostnames:
  - account.dev.web.io
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: dev
    namespace: envoy-gateway
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: Exact
        value: /countries
  - backendRefs:
    - group: ""
      kind: Service
      name: account
      port: 80
      weight: 1
    matches:
    - path:
        type: RegularExpression
        value: /webhooks/[^/]+$
status:
  parents:
  - conditions:
    - lastTransitionTime: "2024-11-11T15:33:25Z"
      message: Route is accepted
      observedGeneration: 1
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-11-11T15:33:25Z"
      message: Resolved all the Object references for the Route
      observedGeneration: 1
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs
    controllerName: gateway.envoyproxy.io/gatewayclass-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: dev
      namespace: envoy-gateway

➜  ~ kubectl -n dev get svc account -o yaml
apiVersion: v1
kind: Service
metadata:
  name: account
  namespace: dev
spec:
  clusterIP: <IP_ADDRESS>
  clusterIPs:
  - <IP_ADDRESS>
  internalTrafficPolicy: Cluster
  ipFamilies:
  - IPv4
  ipFamilyPolicy: SingleStack
  ports:
  - name: grpc
    port: 50051
    protocol: TCP
    targetPort: 50051
  - name: http-port
    port: 80
    protocol: TCP
    targetPort: 8080
  - name: metrics
    port: 8082
    protocol: TCP
    targetPort: 8082
  selector:
    app: account
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

➜  ~ kubectl -n dev get endpoints account
NAME                    ENDPOINTS                                             AGE
account                 <IP_ADDRESS>:50051,<IP_ADDRESS>:8082,<IP_ADDRESS>:8080   474d

➜  ~ kubectl -n dev get securitypolicies.gateway.envoyproxy.io account-http-policy -o yaml
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: SecurityPolicy
metadata:
  name: account-http-policy
  namespace: dev
spec:
  extAuth:
    failOpen: false
    headersToExtAuth:
    - authorization
    http:
      backendRef:
        group: ""
        kind: Service
        name: auth-verification
        port: 80
      headersToBackend:
      - authorization
      - X-Token-String
  targetRef:
    group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: account-mapping
status:
  ancestors:
  - ancestorRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: dev
      namespace: envoy-gateway
    conditions:
    - lastTransitionTime: "2024-05-14T12:47:56Z"
      message: Policy has been accepted.
      reason: Accepted
      status: "True"
      type: Accepted
    controllerName: gateway.envoyproxy.io/gatewayclass-controller

OK - well as it happens I now see the issue. I'm using a deprecated field.
2024-11-11T17:25:02.455Z  ERROR provider  kubernetes/status_updater.go:112  unable to update status {"runner": "provider", "name": "account-http-policy", "namespace": "dev", "error": "SecurityPolicy.gateway.envoyproxy.io \"account-http-policy\" is invalid: spec.extAuth.http: Invalid value: \"object\": BackendRefs must be used, backendRef is not supported."}

Updating to use backendRefs fixes the problem. Sorry!

OK - well as it happens I now see the issue. I'm using a deprecated field.
2024-11-11T17:25:02.455Z  ERROR provider  kubernetes/status_updater.go:112  unable to update status {"runner": "provider", "name": "account-http-policy", "namespace": "dev", "error": "SecurityPolicy.gateway.envoyproxy.io \"account-http-policy\" is invalid: spec.extAuth.http: Invalid value: \"object\": BackendRefs must be used, backendRef is not supported."}

Updating to use backendRefs fixes the problem. Sorry!

Thanks for looking into this .
This field is deprecated, not removed so shouldn't cause this breaking change, re opening to fix this


refactor(background-worker): now background worker leaves error message if it was failed

this PR resolves #46

:tada: This PR is included in version 1.0.0-dev.2 :tada:
The release is available on:

v1.0.0-dev.2
GitHub release
v1.0.0-dev.2

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


fix(arcgis): fixing the Rank property to be a float instead of an int

Closes #108

@rfchmu, this should fix your issue. Hoping to get it in soon.


CT accessibleNameBehavior should work for empty string

scenery : top-level-unit-tests : unbuilt
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/scenery/scenery-tests.html
387 out of 388 tests passed. 1 failed.
ParallelDOMTests: accessibleName option failed:
accessibleNameBehavior should work for empty string
at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/chipper/dist/js/scenery/js/accessibility/pdom/ParallelDOMTests.js:1680:10)

id: Bayes Puppeteer
Snapshot from 8/8/2022, 6:32:39 AM

----------------------------------

scenery : top-level-unit-tests : unbuilt?brand=phet-io
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/scenery/scenery-tests.html?brand=phet-io
390 out of 391 tests passed. 1 failed.
ParallelDOMTests: accessibleName option failed:
accessibleNameBehavior should work for empty string
at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/chipper/dist/js/scenery/js/accessibility/pdom/ParallelDOMTests.js:1680:10)

id: Bayes Puppeteer
Snapshot from 8/8/2022, 6:32:39 AM

----------------------------------

scenery : top-level-unit-tests : unbuilt?ea
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/scenery/scenery-tests.html?ea
387 out of 388 tests passed. 1 failed.
ParallelDOMTests: accessibleName option failed:
accessibleNameBehavior should work for empty string
at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/chipper/dist/js/scenery/js/accessibility/pdom/ParallelDOMTests.js:1680:10)

id: Bayes Puppeteer
Snapshot from 8/8/2022, 6:32:39 AM

----------------------------------

scenery : top-level-unit-tests : unbuilt?ea&brand=phet-io
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/scenery/scenery-tests.html?ea&brand=phet-io
390 out of 391 tests passed. 1 failed.
ParallelDOMTests: accessibleName option failed:
accessibleNameBehavior should work for empty string
at Object.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1659961959255/chipper/dist/js/scenery/js/accessibility/pdom/ParallelDOMTests.js:1680:10)

id: Bayes Puppeteer
Snapshot from 8/8/2022, 6:32:39 AM

This is probably related to https://github.com/phetsims/scenery/issues/1436.

A fix has been proposed in #1436, closing.


[NL] Re-fix Crime ranking

A redo of ranking fixes after last night's reverts
This helps improve the logic for crime related statvars.
Ex:
"Cities with worst crime" -> should show cities with highest crime
"Best cities by crime" -> should show cities with lowest crime.

needs a lint fix


CMake 2.8 For Ubuntu 14.04

Is it possible to adjust the CMake file to support Ubuntu 14.04 which runs CMake 2.8. The only major API change you're enforcing is target_include_directories which can easily be replaced with target_properties(target PROPERTIES COMPILE_FLAGS ${INCLUDE_DIRS}) or just include_directories (which is understandably forceful.)

Actually, your cmake file is supported by 2.8.11 and 14.04 has 2.8.12, could you lower the cmake requirement to 2.8.11? I would like to use the project as a submodule with an automated cmake build.

Hi, per https://hsf-training.github.io/hsf-training-cmake-webpage/07-commonproblems/index.html we raised the CMake minimum version to 3.4 now.


Compatibility with pathlib

First of all, thank you for this.
As an advocate of pathlib, I'd like to be able to run
send2trash(path)

where path is a pathlib.Path object.
From what I gather this isn't implemented, because I get:
TypeError: Must be bytes, not PosixPath

but it works fine if I do:
send2trash(str(path))

It might be as simple as wrapping the input in str(), I haven't checked how other libraries are handling it.

Should be fixed with changes from 94e1ec007a6db5538b170ff27da9a310a8ef7961

1.8.0 is now available, closing


What are the keras3 operations to replace those in tf.linalg?

I am looking for a replacement to tf.linalg.eigh, etc.
There doesn't seem to be equivalent functionality in keras.ops or keras.utils.

Hi @tsjain ,
This Op seems not yet implemented in Keras3. But if you are using tensorflow as backend you can still use Tensorflow API itself.

The major promise of keras 3 was to seamlessly switch backends, so it would be good if this functionality was abstracted into the API as well.

Looks like a wide variety of tf.linalg.* operations are not supported, even though the migration guide https://keras.io/guides/migrating_to_keras_3/#transitioning-to-backendagnostic-keras-3 says they should be

Hi @tsjain, this sounds like a good idea! Would you be interested in contributing a PR for making these linalg ops backend-agnostic for Keras 3?

If I had the knowledge for this, I would. But I am a mostly an end-user of keras.

Hi @nkovela1 I'd be interested in contributing on that, with some guidance. For instance, should we implement this as a separate ops.linalg namespace? Would it be okay to start with a PR that implements only a small subset of the most common linear algebra operations (thinking about stuff like cholesky, inv, solve, maybe linear operators)?


Consider adding test?

Hi @seedlit,
I think if you will add tests to package, it will help in people understanding the use case easily. Also, it would help track the development of the package in the future. Here is a good line:

... other developers want to see tests in your software before they take it seriously is yet another reason for you to start writing tests.
-https://docs.djangoproject.com/en/3.2/intro/tutorial05/#tests-make-your-code-more-attractive

Just a small suggestion from my side!

Sure. I will add the tests and some checks as well to ensure the input DSM is in correct format.

@R1j1t I have added the tests. Though, I also intend to create a makefile for automated testing, I will close this issue for now.
Thanks!


[WFLY-6409]:  Update default domain configuration to use http-remoting

Updating default domain configurations.
Jira: https://issues.jboss.org/browse/WFLY-6409
JBEAP: https://issues.jboss.org/browse/JBEAP-9093
Supersede: https://github.com/wildfly/wildfly/pull/8798

@simkam @mjurc please take a look into this PR

Retest this please

I am deferring this to WF15 - there is too much other stuff going on now for 14 :)

@jamezp @jmesnil Removing the 15.x label. It should be ok if you guys are ok with it

@ehsavoie The elytron job has failed a few times with similar errors, so I presume it is caused by this PR
https://ci.wildfly.org/viewType.html?buildTypeId=WF_PullRequest_LinuxElytro&tab=buildTypeHistoryList&branch_WF_PullRequest=pull%2F11351

@kabir the problem lies in the fact that there is no native management interface so the cli script fails in domain mode


Module '"@nestjs/common"' has no exported member 'ConsoleLogger'.

Hi,
I am very new to the nestjs and trying to integrate sentry for my project. I followed the exact instructions.
Upon adding SentryModule.forRoot(... configuration,
I see the following errors appearing:

https://githubmemory.com/repo/ntegral/nestjs-sentry/issues People have reported similar issues, no solutions though.
Any help would be appreciated.

@Shivam-Pathak1 @abhimanusharma This is related to a mismatch between your nestjs version and the version of this package you are using. In nestjs version 8.X.X ConsoleLogger was added so I'm guessing you're using nestjs version 7.x.x. Which versions are you on?
See the breaking changes in the migration guide https://docs.nestjs.com/migration-guide#logger-breaking-changes


Moves In-process stuff to UseIISIntegration, removes Server.IIS namespace

Fix for https://github.com/aspnet/IISIntegration/issues/429. This will make using the inprocess mode a single switch (hostingModel="inprocess").
cc @muratg

@jkotalik,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

🆙 📅


Cache images, css, etc.

Google Lighthouse audit of staging.dockstore.org flags "Serve static assets with an efficient cache policy" under the Performance category. Performance scores close to 100 with no throttling but very badly using applied/simulated 4G, so this could be a problem for slower connections.
The audit shows that javascript, css, and images are not being cached. See https://developers.google.com/web/tools/lighthouse/audits/cache-policy?utm_source=lighthouse&utm_medium=devtools
┆Issue is synchronized with this Jira Story
┆Fix Versions: Open-ended research tasks
┆Issue Number: DOCK-1006
┆Sprint: Backlog
┆Issue Type: Story

I think we need to set the Object Caching TTL in CloudFront.

Doesn't Ryan's PR take care of some of this?

Doesn't Ryan's PR take care of some of this?

Maybe to a degree, but not sure we'll be able to merge that until Cypress/web-worker issues are sorted out. And even with that, we should still be doing this.

Probably could use another look
https://whatdoesmysitecost.com/test/210708_BiDcRN_6d35b281c40f1a246b9f04df962a1473
Particularly "Leverage browser caching of static assets" in the underlying dataset


StateMachine prototyping

StateMachine is abstract class having Index Key and Indexed Component.

You can set which transition is valid. and time, etc. Index Key will have enum, user shouldn’t directly modify this

Condition and parameters can be set, transition time can be set, but they are not part of key. Key should only have current state and next state.


Update antlr4_tool_runner.py

Add a system property for jre, so that System.out always uses UTF-8 encoding.

I met an error about encoding as decsribed in #antlr4/a. In short, system.out in org.antlr.v4.gui.Interpreter may use other encoding such as GBK if not explicitly specified.
I thought it should be solved in java side, but later I found just a “-Dfile.encoding=UTF-8” is enough.
By the way, after adding this, an encoding can be added to arguments passed to subprocess.Popen in interp().


adding grid services link

Description
Adding a link for Grid Services in the Other Services section.
Changes

Related Issues
#1199
Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstrings
[x] Screenshots/Video attached (needed for UI changes)

drafted until a new icon is provided

Update:
The new icon was added and the pr is ready for review.


M8 - Nadia request CPSC key

You have registered your application with CPSC's Web API. Web API can be accessed using following URL: http://www.saferproducts.gov/WebApi/Cpsc.Cpsrms.Web.Api.svc/ Below is the requested information:
Application Key: ddcde1b6-ebca-4bdd-bdb8-d8a2d9f40f17.
Number of Allowed requests per second: 100. This number represents the number of requests that your application is allowed to make per second. When the limit is reached, the requests will be queued until the next time interval.
As your application is developed to access the Web API, please ensure to include the application key in the request as well as an authorization record, with the request header containing the username (application key) and a blank password.
To request increase in the number of requests per second, please feel free to email the system administrator at<EMAIL_ADDRESS>or call<PHONE_NUMBER>
Thank you,
U.S. Consumer Product Safety Commission
This is an automated message.  Do not reply to this e-mail address.
*****!!! Unless otherwise stated, any views or opinions expressed in this e-mail (and any attachments) are solely those of the author and do not necessarily represent those of the U.S. Consumer Product Safety Commission. Copies of product recall and product safety information can be sent to you automatically via Internet e-mail, as they are released by CPSC. To subscribe or unsubscribe to this service go to the following web page: http://www.cpsc.gov/en/Newsroom/Subscribe *****!!!


regeneratorRuntime is not defined

So my application starts up fine (using Webpack dev server with hot reload) but on reload I keep getting this error. I have the import polyfill at the top of my index.js but i'm not sure from the examples, specifically the 'real-world' one, what I am supposed to include in my webpack configuration for this to work.
Thanks

If you're using ES6 on the server you may want to import the polyfill on the server as well. also running on the server requires node --require babel-register server.js in packae.json https://github.com/yelouafi/redux-saga/blob/master/examples/real-world/package.json#L6

I found out that I had to include it in my webpack config like so
entry: {
    js: ['babel-polyfill', './index.js'],
    vendor: ['react']
  },

For those who don't want to use babel-polyfill. Just
import "regenerator-runtime/runtime";

and that's it! Because babel-runtime depends on regenerator-runtime already.

@vinogradov I stuck that in my saga file and it worked great! Thanks 🥇

@vinogradov thanks!  Quick note to those who come after.  It didn't work until I put it at the top of the file.
this worked:
import 'regenerator-runtime/runtime' import { applyMiddleware, createStore, compose, combineReducers } from "redux" import {createLogger} from "redux-logger" import createSagaMiddleware from 'redux-saga' import { helloSaga } from './sagas' import tenants from './tenantsReducer'
this didn't:
import { applyMiddleware, createStore, compose, combineReducers } from "redux" import {createLogger} from "redux-logger" import createSagaMiddleware from 'redux-saga' import { helloSaga } from './sagas' import tenants from './tenantsReducer' import 'regenerator-runtime/runtime'

thanks @jasontenbrink! It is very important point. I edited my original post according to your comment.

I had the same problem and none of the solutions above worked. So then I moved the async function from the saga to a separate module and now everything works fine

The following does not work for me:
import 'regenerator-runtime/runtime'
However, the following solution works:
import regeneratorRuntime from 'regenerator-runtime/runtime'
Any idea why I am getting different results from the rest of the thread?

It depends on your babel config, so hard to tell without looking at it.

if you use babel, try this:
npm install --save-dev @babel/plugin-transform-runtime
add add in your .babelrc file
"plugins": [
    "@babel/plugin-transform-runtime"
]

it works for me

For those who don't want to use babel-polyfill. Put this BEFORE ALL IMPORTS (at the top of the file):
import "regenerator-runtime/runtime";

and that's it! No need to add any dependencies because babel-runtime depends on regenerator-runtime already.

Alternatively, just import import "babel-polyfill";  at top of your entry file, such as index.js or index.jsx


ObjectSequenceAbstract.java not found

in the reladomo-sample-simple project, there is code like below
public class ObjectSequence extends ObjectSequenceAbstract implements MithraSequence
{
where is the java class ObjectSequenceAbstract  come from?
I do not see it in master branch?

The abstract classes are code generated during the build.

ObjectSequenceAbstract is a custom class that is built during the project development process. It serves as an abstract class, providing a blueprint or set of rules that other classes can follow when extending it. In the case of ObjectSequence, it extends ObjectSequenceAbstract, indicating that ObjectSequence is a subclass that inherits and extends the functionality and structure defined in ObjectSequenceAbstract.
In Java, an abstract class serves as a partial implementation, allowing common functionality to be shared among its subclasses while enforcing certain rules and guidelines for their construction. By extending the abstract class, ObjectSequence adheres to these rules and inherits any shared behavior or characteristics defined in ObjectSequenceAbstract. This promotes code reusability and helps maintain consistency across different classes that utilize the abstract class as their base.


probe: cmsis-dap: set retry count to max value by default

This patch sets the retry count for DAP transfers to the highest value by default.
This is needed since flash erase will stall a read operation for a long time on the nRF9160.

I think it should be no problem to have a very high retry value. Since the target still has to send ACK_WAIT responses, we still return failure on broken connections.

👋🏽 Thanks for the patch!
Do you happen to know the number of retries that are required on average? Mostly just curious, but it would also be good to know how close it is to the maximum. If it's too close, then pyocd should probably be performing its own retries in addition to the probe (that just hasn't been necessary in any other cases).

/azp run

Yes, I agree that it shouldn't be a problem. But actually, the retry count should be configurable by the user and target. (Hmm, I'll add a "minimum required retry count" to my [Open-]CMSIS-Pack todo list.)

👋🏽 Thanks for the patch!
Do you happen to know the number of retries that are required on average? Mostly just curious, but it would also be good to know how close it is to the maximum. If it's too close, then pyocd should probably be performing its own retries in addition to the probe (that just hasn't been necessary in any other cases).

That of course depends on the bus speed, but I saw 6232 retries on a 1MHz SWD connection and that was not even the slowest operation.

Ok, thanks. So with 6232 at 1 MHz, it should be safe to go up to somewhat faster than 10 MHz using a retry count of 64k. Probably alright for now. And one can always use a slower SWD clock if a chip erase is needed.


[Feature Request] Preselect?

Existing Component
Yes
Component Name
Select
Description
Hi,
first of all: thank you for this amazing lib!
Question: When using the select component with the multiselect option. Is there way that all items are preselected? Thanks!

https://jsfiddle.net/z0kdptjs/


(meta-aws/recipes-crt/aws-crt-cpp/aws-crt-cpp_0.8.3.bb:do_compile) failed with exit code '1'

Hi,
After installing the aws-iot-device-sdk-cpp the dependence package aws-crt-cpp do_compile failed. Here is the log below.
| ninja: build stopped: subcommand failed.
| WARNING: /home/rity/bsp/tmp/work/aarch64-poky-linux/aws-crt-cpp/0.8.3-r0/temp/run.do_compile.1622:1 exit 1 from 'eval ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '/home/bl-docker/rity/bsp/tmp/work/aarch64-poky-linux/aws-crt-cpp/0.8.3-r0/build' "$@" -- ${EXTRA_OECMAKE_BUILD}'
|
ERROR: Task (/home/rity/src/meta-aws/recipes-crt/aws-crt-cpp/aws-crt-cpp_0.8.3.bb:do_compile) failed with exit code '1'
Summary: 1 task failed:
/home/bl-docker/rity/src/meta-aws/recipes-crt/aws-crt-cpp/aws-crt-cpp_0.8.3.bb:do_compile
Thanks & Regards,
VR

@rpcme Kindly please look into the issue. Thank you!

Hello @vijayrakesh13  - There is no more dependency between the two packages.  Due to complexities that the repo maintainer but on the build environment, the two recipes are separate and the device sdk already includes CRT.  I am trying to make the CRT recipes palatable on their own but since the higher level recipes already include the CRT it is of lesser priority.
I do still need to propagate the fixes to branches so you could be getting an old error on dunfell branch?

@rpcme Sorry for the late reply. Yes, there is no dependency between two packages, but I was saying CRT is dependence package to run basic subpub example.
Yes, I'm getting an error on dunfell branch, thank you.

Sorry for the late reply, I will try to get the changes propagated to dunfell (and others) tomorrow morning.  I am unfortunately running out of runway today.

@rpcme Thank you! Is there any recipe for aws-iot-device-sdk-embedded-C also? If yes, Please share me the link.

@rpcme I'm waiting for your response. Kindly please update the changes at the earliest.

@vijayrakesh13 it is planned but it hasn't happened yet. the new v4 is now ready and we should be able to pick it up.  The last time I checked it doesn't produce a shared library, so this would be provided as a demo recipe and eSDK provider.  I would have to cross check this but this is my understanding right now.

Hi @vijayrakesh13 @rpcme
aws-iot-device-sdk-embedded-C now supports installation.
Documentation can be found in the README.


⚠ Bofrost.lu has degraded performance

In 44f7844, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2896 ms

Resolved: Bofrost.lu performance has improved in c36f7d1 after 6 minutes.


Undefined function is_integer_type is used in definition of min/max functions

Here are two calls to is_integer_type:

https://github.com/intel/intel-xpu-backend-for-triton/blob/llvm-target/python/triton/language/standard.py#L196
https://github.com/intel/intel-xpu-backend-for-triton/blob/llvm-target/python/triton/language/standard.py#L248

Normally this call is ignored because it is used inside of assert operator that is ignored by default. But when TRITON_DEBUG=1 is used or assertions are enabled in another way, these statements are actually compiled and is_integer_type cannot be found.

Issue also existed on OpenAI/triton. Has been resolved now and waiting on merge in OpenAI/triton https://github.com/openai/triton/pull/3358


podspec update to reflect compatibility

The podspec specifies iOS 8.1, whereas the readme mentions 8.3. You should tag and create a new podspec and version to avoid incompatibilities. Thanks!

Done! Thanks for letting me know.


Notification controls not working with Exoplayer

The notification controls are not working with the exoplayer implementation.
I tried to write a custom notification manager implementation but I'm probably doing something wrong since OnReceive is never called on the BroadcastReceiver.
Any help is highly appreciated.
Thanks and great work so far !

Seems the same problem happens on ios 11, the controls don't do anything. (using the default player)

The MediaManager currently uses V1 of ExoPlayer, we are working on a V1 update that will use ExoPlayer2.
I have no problem with the controls working on Android using MediaPlayer or on iOS using AVPlayer.

Then I must me doing something wrong on my iOS project...

I found the issue:
I am using CrossmediaManager.Current.Audioplayer.Play to start the audio. When using the PlaybackController to pause or stop, it does nothing in either AVMediaPlayer or Exoplayer.
I've overriden the RemoteControlReceived method and used Audioplayer.Stop or Pause and it is working.

Is this issue in IOS or Android?  You a mixing the two in the comments.
Have you reviewed the sample app for the appropriate platform?

It happens on both platforms.

As we've discussed, exoplayer is not a complete implementation and therefore the notification controls don't work, disable exoplayer, use MediaPlayer and the controls work properly on android.
As for IOS, the sample app works, I am augmenting the forms app to work as well.
Did you override the RemoteControlReceived call as per the documentation?
If you want to enable RemoteControl features, you will have to override UIApplication.RemoteControlReceived(UIEvent) and forward the event to the MediaManagerImplementation.MediaRemoteControl.RemoteControlReceived(UIEvent) method. See the sample application for more details.

@mike-rowley

As we've discussed, exoplayer is not a complete implementation and therefore the notification controls don't work, disable exoplayer, use MediaPlayer and the controls work properly on android.

How you make this one works for android. Its not working in my application


Issue running tagged tests with cypress-tags

Description
I am testing the cypress-tags run -e TAGS='not @foo and (@bar or @zap)' feature in my project but I've found a problem when trying it out.
When I run cypress-tags run -e TAGS='@login' it works as expected, running only the scenarios tagged as login but when trying the opposite cypress-tags run -e TAGS='not @login' I get this errors:
$ cypress-tags run -e TAGS='not @login'
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack
Error parsing tags: 'not'. Message: empty stack

So what it does is it tries to run all the scenarios but since not one matches the criteria all of them are set to passed without running them.
My versions are:
"cypress-cucumber-preprocessor": "^1.16.2"
"cypress": "3.6.1"

Ubuntu 18.04.3 LTS

would you be able to create a simple demonstration/reproduction? Maybe based on a fork of one of our example repos? That will increase the chance that one of us will find the time to investigate and fix :)
Thanks!

When trying to create the reproducible version for you to try, I've seen that it was because I have more than one command in my npm script:
"test:bug": "secrets-env-script cypress-tags run -e TAGS='not @login'"
secrets-env-script is a script used to read some private data right before running cypress-tags. Removing that or even setting && in between the two commands caused the feature to work well.
With that info, let me know if you want me to close this issues or you'd like to get deeper on that.
Thanks

Hi @lgandecki,
I was able to create a reproduction of the error, you can find it here: https://github.com/davidzambrana/test-cypress
Just install the dependencies with npm or yarn and see the error running yarn test:error
The only difference that makes it to fail is running another command right beforehand. As I commented I can avoid the error by setting && between the commands, but that arose a different problem on my setup.
Let me know if I can help with anything else.

I have similar issues with "cypress-cucumber-preprocessor": "^4.0.0",
I have pre and post steps in my scripts and the tests marked with @ignore are not actually ignored. They are shown as skipped in test results. I was using v1.19.0 of cypress-cucumber-preprocessor before and it all worked like a charm.
"pretest:ci": "rm -fr report",
"test:ci": "NO_COLOR=1 cypress run --spec \"cypress/integration/tests/**/*.feature\"  -e TAGS='not @ignore and not @wip'",
"posttest:ci": "node cypress/plugins/reporter.js",

I have the same issue

npx cypress-tags run -e TAGS="@setup"   OK (1 scenario found & executed)
npx cypress-tags run -e TAGS="not @setup"    KO (Error parsing tags: 'not'. Message: empty stack)
Funny thing is, if I put that as ENV variables in cypress.json (like 'not @ignored' is documented) then it works. So it's solely when through CLI.

I got the same results in powershell, cmd and git bash (so it is not powershell interpreting issue or something like that).
And it's not 'No matching tags found' so there's definitively a bug behing that.
Once fixed, I guess an additional test for the framework should be added so that this doesn't regress again.
"cypress": "^6.5.0",
"cypress-cucumber-preprocessor": "^4.0.0",

They are shown as pending in test results.

"Pending" is how skipped tests are shown in the results.
https://glebbahmutov.com/blog/cypress-test-statuses/

@davidzambrana, your script yarn test:error would work if you quoted correctly, a
{
  "test:error": "./scripts/run-local-task.sh cypress-tags run -e TAGS=\\'not @skip\\'"
}

.. alternatively, you can replace eval with exec and leave the quoting as is. You probably don't want a subshell to begin with anyway.

@sandra-ouadghiri, your problem is certainly related to argument interpretation and has likely nothing to do with the preprocessor. You're example, npx cypress-tags run -e TAGS="not @setup", works totally fine in bash.

Closing, as this likely doesn't pertain preprocessing at all. I realize that escaping quotes and knowing when to do it can seem daunting at first, and it is, especially when you're propagating arguments between multiple layers of abstraction. The clue here is to familiarize yourself with exactly what is being propagated throughout and verifying it. It's also a type of issue you're likely going to keep encountering in the future no matter what tools you use.
However, this isn't an issue with the processor. The preprocessor can only process what it is handed and in all your cases it has been handed "not", which isn't a valid tag filter, and this is due to some error in argument interpretation in your environment.
If you run eg. cypress open -e TAGS="foo bar", go to "settings", expand "configuration" and expand "env", you can observe what Cypress actually resolves for you. You should hopefully see TAGS: "foo bar" in that case.

I faced similar issue

I have faced similar issue. Resolved it by removing quotes around tag in the script in package.json eg @smoke instead of '@smoke'
should work
{
"test:error": "./scripts/run-local-task.sh cypress-tags run -e TAGS=@skip"
}


Chapter 3 replication failure

Hi there--even after checking out a clean Chapter3.ipynb from master, the model consistently fails to learn appropriate cluster0 std and p (frequency of assignment to cluster0).
Expected behavior, 1:

Actual behavior, 1:

Expected behavior, 2:

Actual behavior, 2:

Any idea what could be causing that?

Hmmm….
This is interesting...

On Jan 25, 2015, at 6:23 PM, khgitting<EMAIL_ADDRESS>wrote:
Hi there--even after checking out a clean Chapter3.ipynb from master, the model consistently fails to learn appropriate cluster0 std and p (frequency of assignment to cluster0).
Expected behavior, 1:
https://cloud.githubusercontent.com/assets/1838992/5894541/5751811e-a4d7-11e4-8890-309b2dabd0ee.png
Actual behavior, 1:
https://cloud.githubusercontent.com/assets/1838992/5894545/65f34b6c-a4d7-11e4-92c4-bddd31177151.png
Expected behavior, 2:
https://cloud.githubusercontent.com/assets/1838992/5894590/95a1544e-a4d7-11e4-9041-729ccf869697.png
Actual behavior, 2:
https://cloud.githubusercontent.com/assets/1838992/5894592/a352c244-a4d7-11e4-9c0a-4af9dcc0a1a8.png
Any idea what could be causing that?
—
Reply to this email directly or view it on GitHub https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/issues/245.

hey @khgitting, I've noticed this too as well - I can replicate your behaviour as well. To confirm, can you post your version of PyMC?
import pymc as mc
mc.__version__

I'm on version 2.3.4

I also failed to replicate with PyMC version 2.3.4 (with same results as charted above).  Reverting PyMC to version 2.2 works as intended.

You can also get sensible results (still with 2.3.4) by switching the prior of p (probability of assignment to cluster 1) from a noninformative Uniform prior to a Beta(x,x) for x >= 20 or so, representing some belief (the higher x, the stronger that belief) that p is somewhat near .5.

+1 I also face this problem.

+1, Same issue here. Python 3.4, PyMC version 2.3.4.
It would be interesting to know what has chaned from 2.2 to 2.3.4, but I'm not well versed enough into PyMC to figure this out on my own...

:+1:  Same here. Problems with both pymc2 and pymc3 :(

+1 for the same issue.

Yes, getting back to pymc @2.2 would solve the issue as @erdman suggested. But we want to know use the new version for other improvements, don't we @QuentinAndre?
I submitted a issue in pymc in the hope of getting some fix soon:
https://github.com/pymc-devs/pymc/issues/46

Does this work with a build of the current master?

@fonnesbeck Yes. I just build of the current master and found the version to be pymc @ 2.3.5. It's the version 2.3.4 that I installed from macPort that is causing the issue.

Ok, then it's probably time for a 2.3.5 bug fix release for PyMC.

When I run the code which is produced the sample, the python will stop run it. why?

I find the code (step2 = pm.ElemwiseCategorical(vars=[assignment])) will take place wrong through I checked. but I don't know how to deal with it.


fix parameter overwrite in _generate_symbol_function_code

Description
fix bug of parameter overwrited by function local variable in code generate by _generate_symbol_function_code, can be reduce with define k in mx.sym.topk
Checklist
Essentials

[x] Passed code style checking (make lint)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[] fix bug of parameter overwrited by function local variable in code generate by _generate_symbol_function_code

Could you provide an example that reproduces the bug?

@szha @eric-haibin-lin

@szha @eric-haibin-lin

@szha
below is how to reproduce this bug:
import mxnet as mx

def network():
    data = mx.sym.Variable(name="data")
    topk = mx.sym.topk(data, ret_typ='both', k=3, bug_cause='abc')

    return topk

ctx = mx.Context(mx.gpu(0))
net = network()

ex = net.bind(ctx, args={"data":mx.nd.array([1,2,3,4,5], ctx=ctx)})
res = ex.forward()
print(res)

here is rutime error:
Traceback (most recent call last):
  File "./test.py", line 16, in <module>
    net = network()
  File "./test.py", line 11, in network
    topk = mx.sym.topk(data, ret_typ='both', k=3, bug_cause='abc')
  File "<string>", line 85, in topk
  File "/mnt/lustre/aifs/fgfs/users/wxm71/tools/apps/mxnet/debug/lib/python3.6/site-packages/mxnet-1.0.1-py3.6.egg/mxnet/_ctypes/symbol.py", line 125, in _symbol_creator
    ctypes.byref(sym_handle)))
  File "/mnt/lustre/aifs/fgfs/users/wxm71/tools/apps/mxnet/debug/lib/python3.6/site-packages/mxnet-1.0.1-py3.6.egg/mxnet/base.py", line 146, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: Invalid Parameter format for k expect int but value='bug_cause', in operator topk(name="", ret_typ="both", k="bug_cause", bug_cause="abc")

just add any kwargs to mx.sym.topk, this bug will trigged
blow are the details:
if print the code generate by _generate_symbol_function_code, we can find sth like this:
def topk(data=None, axis=_Null, k=_Null, ret_typ=_Null, is_ascend=_Null, name=None, attr=None, out=None, **kwargs):
    r"""Returns the top *k* elements in an input array along the given axis.

    ....    # many documents line

        Returns
    -------
    Symbol
        The result symbol.
    """
    kwargs.update(AttrScope.current.get(attr))
    sym_kwargs = dict()

    keys = []
    vals = []

    for k, v in kwargs.items():
        if isinstance(v, SymbolBase):
            sym_kwargs[k] = v
        else:
            keys.append(k)
            vals.append(v)

    if data is not None:
        assert isinstance(data, SymbolBase), \
            "Argument data must be Symbol instances, but got %s"%str(data)
        sym_kwargs['data'] = data

    if axis is not _Null:
        keys.append('axis')
        vals.append(axis)

    if k is not _Null:
        keys.append('k')
        vals.append(k)

    if ret_typ is not _Null:
        keys.append('ret_typ')
        vals.append(ret_typ)

    if is_ascend is not _Null:
        keys.append('is_ascend')
        vals.append(is_ascend)

    name = NameManager.current.get(name, 'topk')
    return _symbol_creator(17208384, None, sym_kwargs, keys, vals, name)

k is a argument of function call, but is also appear in for loop. so, is the for loop have been execute, it will generate a new value, overwrite the value passed from caller, and cause the problem above.
if keys, vals appear in argument, it will also overwrited by local version

Thanks for reporting. Could you fix the error and add a test for the bug?


fix bug for pandas auto categorical_feature

#215

Hi @wxchan, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

still one bug, pandas feature names can be int, how to distinguish between feature names (if it's int) and feature index when set categorical features?

@wxchan How about using pandas.get_dummies ?
cf. http://pandas.pydata.org/pandas-docs/stable/generated/pandas.get_dummies.html

@henry0312 isn't that one-hot encoding? it's not how to deal with categorical feature in lightgbm

hum, I'll check carefully.

@guolinke this pr is finished too, I am not sure about all the logic, it may need some review.


Removes macro implementation

This PR fixes #8 by removing the current macro. There are some reasons for that:

The macro is not compatible with scalameta
It's using a blocking call here
It's hard to maintain

@raulraja what do you think? Could you please review? Thanks

Codecov Report

Merging #13 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
- Coverage    84.9%   84.31%   -0.6%
=========================================
  Files           4        2      -2
  Lines          53       51      -2
=========================================
- Hits           45       43      -2
  Misses          8        8

Impacted Files
Coverage Δ

...in/scala/freestyle/cassandra/api/LowLevelAPI.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7fc45...ca2e16c. Read the comment docs.


More Sharing option

Current codebase only copies the link on clipboard while sharing, I would like to add option for sharing the blog on twitter, WhatsApp and other social media handles.
I am GSSOC'23 contributor, kindly assign this issue to me.

Hi, @khushigupta123 , you can work on this and please refer to the Contribution guidelines on the readme once.
All the best!

Hi, @khushigupta123 , you can work on this and please refer to the Contribution guidelines on the readme once. All the best!

Sure, I will check out readme before working.
Thank you!

Closing this because of no response or pr from your side.


Eagerly emit getters at Onone.

Force SILGen to also eagerly emit getters when compiling at Onone. The reason for this is that getters (even not user-written ones, generated by result builders) can, and are often called by users debugging swift programs, and should be available for that reason.
rdar://133329303

@swift-ci smoke test

@swift-ci smoke test


[2.0.x] Argument rematerialization not implemented when running 05-layer-norm tutorial

I just tried this on the release/2.0.x branch (commit: d54c04abe2c3e67b2139c68cdbda87b59e8dd01b)
$ python 05-layer-norm.py
Argument rematerialization not implemented
UNREACHABLE executed at /scratch/bertrand/testing/triton_3aa3_llvm_14/triton/lib/Dialect/TritonGPU/Transforms/TritonGPUConversion.cpp:45!
Aborted (core dumped)

Can you cherry-pick https://github.com/openai/triton/pull/1196 ?

Sure, I just tried it, and the error still repro's.

that's weird, it doesn't happen on main, so it must have been fixed some time soon

f21e76affeeccca4f5075395254535facff99053 also works

Unfortunately the issue seems fixed by 2aba985, which IIRC was the commit that broke some of the torch-inductor CI. We're working on cleaning things up so that torch-2.0 can be on top of main, but it will probably take at least a few days

Ah, that's too bad.  All things equal I'd rather have inductor working though :-D

Hey Phil, are there any updates on this? Failing for me right now on main.

I don't think that's true. Couldn't repro this error on main. There were some typos, but that was unrelated. Closing.


Old inter mac version support

request to support old inter mac: 10.15.6

Duplicate of #71.

Not feasible. None of the virtualization APIs used by OrbStack exist in Catalina.
I'd recommend using OpenCore Legacy Patcher (at your own risk) if you can't upgrade to a newer version of macOS.


Parsing functions without parenthesis fails

When parsing this function:
function (m) { return m.test === true; }
I get the following exception:
Uncaught Error: Line 1: Unexpected token (
But when I put it around parenthesis
(function (m) { return m.test === true; })
it works fine.

This is the correct behavior and it has nothing to do with Esprima. The first example is an invalid function declaration because it does not have a name. The second one is a function expression, and it's valid as is. For more details, please explore e.g. http://kangax.github.io/nfe/.

Ok yeah I figured as much, I recall having similar issues putting functions in an eval with similar results.


Clean up WorkspaceLocation type

Description
Clean up WorkspaceLocation type.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Code quality improvements

How to test
Nothing should change.

Pull Request Test Coverage Report for Build 5798

38 of 42 (90.48%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 35.309%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/commons/sagas/WorkspaceSaga.ts
34
38
89.47%

Files with Coverage Reduction
New Missed Lines
%

src/commons/sagas/WorkspaceSaga.ts
1
77.99%

Totals

Change from base Build 5785:
-0.05%

Covered Lines:
1839

Relevant Lines:
4813

💛  - Coveralls


Can you drop "www."

Hi all,
Currently the main website is https://www.freerdp.com/
Can you drop the "www." to have https://freerdp.com/
More informations: https://dropwww.com/why
Of course, redirections:

http://freerdp.com/ -> https://freerdp.com/
http://www.freerdp.com/ -> https://freerdp.com/
https://www.freerdp.com/ -> https://freerdp.com/

Thanks in advance.

Related to #6037

.

Dear @FreeRDP team,
Have you progressed on it?

The bot is not good...

.