[Event Request] page 6032 "Service Shipment Statistics" - OnBeforeCalculateTotals

We would like to add a new event OnBeforeCalculateTotals in the following trigger:
trigger OnAfterGetRecord()
var
    IsHandled: Boolean;
begin
    ClearAll;
    //A108F0080.Event.ns
    IsHandled := false;
    OnBeforeCalculateTotals(Rec, LineQty, TotalNetWeight, TotalGrossWeight, TotalVolume, TotalParcels, IsHandled);
    if IsHandled then
        exit;
    //A108F0080.Event.ne

    ServShptLine.SetRange("Document No.", "No.");

    if ServShptLine.Find('-') then
        repeat
            LineQty := LineQty + ServShptLine.Quantity;
            TotalNetWeight := TotalNetWeight + (ServShptLine.Quantity * ServShptLine."Net Weight");
            TotalGrossWeight := TotalGrossWeight + (ServShptLine.Quantity * ServShptLine."Gross Weight");
            TotalVolume := TotalVolume + (ServShptLine.Quantity * ServShptLine."Unit Volume");
            if ServShptLine."Units per Parcel" > 0 then
                TotalParcels := TotalParcels + Round(ServShptLine.Quantity / ServShptLine."Units per Parcel", 1, '>');
            OnCalculateTotalsOnAfterAddLineTotals(Rec, ServShptLine, LineQty, TotalNetWeight, TotalGrossWeight, TotalVolume, TotalParcels); //A108F0080.Event
        until ServShptLine.Next() = 0;
end;

Event Signature:
[IntegrationEvent(false, false)]
local procedure OnBeforeCalculateTotals(ServiceShipmentHeader: Record "Service Shipment Header"; var LineQty: Decimal; var TotalNetWeight: Decimal; var TotalGrossWeight: Decimal; var TotalVolume: Decimal; var TotalParcels: Decimal; var IsHandled: Boolean)
begin
    //A108F0080.Event
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Limitation of allowed selected characters per query

If I try to translate a longer section, the translation doesn't go through and following message appears:
"Please try again with a shorter text"
As far as I understand the free version of the DeepL API key allows for 500000 chars/month. Is there an additional limit per query, or this is a limitation of obsidian or the plugin?

I'm not the developer of this Plugin. I just contribute a small part. I had a look at the code.
The message "Please try again with a shorter text" is implemented by the Obsidian DeepL Plugin: https://github.com/friebetill/obsidian-deepl/blob/7c7f5b2c0248f5db3a8a8156e4de7977c7b90231/src/deepl/deeplException.ts#L24
This message corresponds to the error code 413:
https://github.com/friebetill/obsidian-deepl/blob/7c7f5b2c0248f5db3a8a8156e4de7977c7b90231/src/deepl/deeplErrorCodes.ts#L6
Error code 413 is returned from DeepL API:
https://support.deepl.com/hc/en-us/articles/9773964275868-DeepL-API-error-messages:

Error 413
The request size exceeds the limit
This error occurs when the request size reaches the supported limit.
Please consult the API documentation for detailed information about size limits, particularly for document translations.
If you are trying to translate a large text in a single translation request, consider splitting it up into multiple requests, e.g., split it by paragraph.

To answer your question:
Based on the error code, the limit comes from the DeepL API. I have not seen any additional limitations from the plugin. Obsidian itself has nothing to do with this.


⚠ Bofrost.at has degraded performance

In d49876e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1235 ms

Resolved: Bofrost.at performance has improved in 0747d31 after 6 minutes.


problems with special characters

There seems to be a problem with some apostrophes

seems to be fixed -CN, 10/14
Also, commas inside gesture glosses seems to throw off the export to the English words spreadsheet.  Not sure if it's creating problems elsewhere.

Problem with œ

seems to be fixed -CN, 10/14

The main entry for these two lines should be the same, but the top one is missing.

Not sure that this has anything to do with special characters, but this sign is listed twice, for some reason, in the English words spreadsheet.

first and third lines should presumably be the same ?

another problem - should be "

same as above

another example with ' and ""

one more:

Some examples of special character problems in the DAI
There should not be any question marks displayed.  The problems involve especially ' and "

see also #127

These have been fixed on dev1.cs

THE ONE REMAINING ITEM seems to be the "whoa" case above.  Thanks.

I believe this has been resolved on dev1.  Can you please confirm?

yes!  thank you !!

There are still issues with special characters in the DAI,  e.g. these question marks:

still needs to be fixed

Still a problem also with special characters in the Sign Bank gestures

These are mostly fixed, but here is one example of a problem that remains on the DAI

This has been resolved on dev1.cs and dai.cs


Issue Writing Tests

I'm having a hell of a time getting tests written for the library that will past the most of my org at work. I end up with this ungodly multi-page mess of code to test even the most simple programs.
Here I've just written a function to test flag parsing.
`
func FlagTest() {
testArgs := []string{"foo", "--debug", "list", "--username", "foo"}
app := &cli.App{Writer: ioutil.Discard}
app.Commands = []*cli.Command{
	&CmdList,
}
app.Flags = []cli.Flag {
	FlagDebug,
}

set := flag.NewFlagSet("test", 0)
FlagDebug.Apply(set)
FlagUsername.Apply(set)

err := set.Parse(testArgs)
if err != nil {
	log.Fatal(err)
}

ctx := cli.NewContext(app, set, nil)
log.Infof("FLAGNAMES=%v", ctx.FlagNames())

err = app.Run(testArgs)
if err != nil {
	log.Fatal(err)
}

log.Infof("DEBUG=%v", ctx.Bool("debug"))
log.Infof("USERNAME=%s", ctx.String("username"))

}
`

% ./bin/foo.bin list
time="2021-09-10T11:52:13.212141-05:00" level=info file=cli.go line=100 msg="FLAGNAMES=[]"
COMMAND BEFORE
COMMAND ACTION
COMMAND AFTER
time="2021-09-10T11:52:13.212331-05:00" level=info file=cli.go line=107 msg="DEBUG=false"
time="2021-09-10T11:52:13.21234-05:00" level=info file=cli.go line=108 msg="USERNAME="

Why on earth is debug false and username "" here?
Sorry for the formatting, I have no idea why this is garbling it. I put my code in between two `` like always.

Closing issue, moving to different library. This one is just too difficult to right tests for.

@rhugga did you mean to close this issue?


samplerParameter is not available, android

On Android,  a Material.Builder using the samplerParameter with following line
.samplerParameter(MaterialBuilder.SamplerType.SAMPLER_2D, MaterialBuilder.SamplerFormat.FLOAT, MaterialBuilder.SamplerPrecision.DEFAULT, "albedo")
does not generate the parameter "materialParams_albedo".  The  created  instance contains the other uniforms, but not the sampler one, when I look in the debugger, and I am unable to set it, so the texture cannot be rendered.
To Reproduce
Steps to reproduce the behavior:

Create a material in Android Studio (kotlin/java) using the Material.Builder and use the samplerParameter method
Try to assigne a texture with the setParameter to the sampler
Run it on Android 10 emulator

Expected behavior
It should be possible to call setParameter and assign texture for the samplerParameter method.
Screenshots
N/A
Desktop (please complete the following information):

OS: Android 10 Emulator
GPU: Quadio P1000
Backend: [OpenGL/Vulkan]

Interesting.  What do you see in logcat when you try to call setParameter?  We use filamat in gltfio (which is C++) so this might be a Java-specific issue.  At first glance the JNI bindings for MaterialBuilder look okay to me.  @bejado might have ideas.

I'm unable to reproduce on both emulator and device. Can you show the rest of the calls toMaterialBuilder? What happens when you call setParameter?

My wrong, I looked on wrong material.


persuasive messages

Tester Eline:
5/8 I got no persuasive message in the general activity dialog when I rated questions 2 and 3 very low, is that correct? I think so as I think I remember that we would do the persuasion only in half of the cases but not sure. See screenshot

@nelealbers I think that the flow is correct, right?

@wbaccinelli @aversluis1 I have not yet implemented the randomization for the persuasive messages (i.e., sending the optimal persuasive message only in 80% of the cases). This is low priority right now.
But even in the non-randomized case, the optimal persuasion in some situations is to not persuade (i.e., to not send a persuasive message). See the variable OPT_POLICY here: https://github.com/PerfectFit-project/virtual-coach-rasa/blob/main/Rasa_Bot/actions/definitions.py.


Allow removing options that EntityType can't accept

Q
A

Bug fix?
no

New feature?
yes

Tickets
Fix #420

License
MIT

If you implement a custom Autocompleter class as described in the docs and happen to require some non-standard options for your custom field, the Autocompleter (currently) tries to pass your custom option to the internal EntityType field.
This PR adds the ability to list the options that should NOT be passed to that EntityType.

A side note: if I knew how to get a list of options of that EntityType field's instance, we wouldn't need to list them manually. It would be enough to just take the current $options and remove any unsupported values from it before passing it on.
If there is a way to do that, please let me know, I'm happy to tweak things!

@janklan we should avoid words like "blacklist" and "whitelist", and prefer words that are more inclusive and convey real meanings.
Here are some good alternatives:

deny list
avoid list
block list
exclude list

@garak I think we don't need to get into politics of offensive language before this gets any real indication of whether or not it is even viable. Thanks for the feedback though.

Using the word "blacklist" shouldn't be seen as "being not nice". The official definition in the Oxford Dictionary is: "a list of people or things that are regarded as unacceptable or untrustworthy and should be excluded or avoided.".
In the current context, it contains a list of options we wish to exclude from passing to the FormEntity. and as such, I think the name conveys the meaning perfectly.
With that said, let's please go back to the technical aspects of this PR.

Thanks for your understanding
Just a final word to point out the false dichotomy of nice and not nice. The dictionary entry you mentioned is neutral.

@garak correct; neutral does not mean "not nice". I think neutral is great, especially in software. It's not a poem. It's code. It should be precise above all. autocomplete_excluded_options is more precise than autocomplete_blacklist, so that makes it better. Not the absence of the word blacklist.
Anyway, I have an opinion on these things that you would probably disagree with, and that's OK. Consider my opinion suppressed in favour of your opinion :)

The problem is that if you're neutral in an unbalanced situation, you're on the same side as the "not nice" ones.
And software is used by people, so it can't be neutral, not as long as you want to try to be nice.

Let's agree to disagree and let's get back to focusing on the subject of this PR. Thanks.

@janklan I like the idea behind this. It's not automatic, but it makes something work that doesn't currently work. If I'm understanding the use-case, it would be this:
A) I create an "entity autocomplete field" - like https://github.com/symfony/ux/blob/2.x/ux.symfony.com/src/Form/FoodAutocompleteField.php - but I add a custom option - e.g. hideJunkFood. Perhaps I use this to customize the query_builder option I'm using.
B) When using the field - like https://github.com/symfony/ux/blob/922a422899b45e972ff70119e245d9d7bf4610c3/ux.symfony.com/src/Form/TimeForAMealForm.php#L14 - I would pass that as a custom option:
->add('foods', FoodAutocompleteField::class, ['hideJunkFood' => true])

Am I thinking about this correctly? If so, then when the Ajax request is made to the autocomplete endpoint, won't we recreate the FoodCompleteField there but without this option? And so hideJunkFood would be true and we may return the wrong autocomplete options? If that is all true, then we should tackle the other half of this problem now: allowing some options (like hideJunkFood) to be passed as a query parameter on the autocomplete Ajax URL and passed back into the form type there.
Cheers!

I think this can be closed as there are no nested form type now, and you can provide everything same as with other form types

Yup & yay! Let us know if you have any issues with the new system


Slack link in README is no longer active

The link https://join.slack.com/t/openram/shared_invite/enQtNDgxMjc3NzU5NTI1LTE4ODMyM2I0Mzk2ZmFiMjgwYTYyMTQ4NTgwMmUwMDhiM2E1MDViNDRjYzU1NjJhZTQxNWZjMzE3M2FlODBmZjA which is in the README.md fails with the following error;
This invite link is no longer active.
If you have an @ucsc.edu email address, you can still create an account.

If not, please check with the person who shared the invite link with you to ask for an invitation.

Fixed in dev branch 76ad2e6


Fix typo in README

Fixes a typo I spotted while reading through the README ('incredibly support' -> 'incredibly supportive').
Thanks for including this README in the repo. I learned a lot about the project just by reading through it, including what was already tried and why the current implementation was chosen. I think it's very helpful to potential contributors to know about the issues with libnvim and that it could be used one day.

Thanks for reviewing and correcting the typo, @sghill ! Glad to hear this was useful.


additional gateway tests for v2/v1alpha3

If the test is implemented properly, this should allow us to test
if we have implemented ADS properly.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chxchx
Assign the PR to them by writing /assign @chxchx in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
696074fce79de9f65a8cfad0fffacbcbfe77b178
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
d610e9352ac6a5653e25aaaae6c642f8f79f9e62
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
Assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1e757bd65f661112bc6a35a8ec827db3ef246512
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
1e757bd65f661112bc6a35a8ec827db3ef246512
link
/test istio-unit-tests

prow/istio-presubmit.sh
1e757bd65f661112bc6a35a8ec827db3ef246512
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
1e757bd65f661112bc6a35a8ec827db3ef246512
link
/test istio-presubmit

prow/istio-unit-tests.sh
23ab3e9b898cf73472a3b119a443982d719c1631
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
23ab3e9b898cf73472a3b119a443982d719c1631
link
/test istio-unit-tests

prow/istio-presubmit.sh
23ab3e9b898cf73472a3b119a443982d719c1631
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS
pilot/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73be17206ae36ada23dceabaaf06490ff47decf9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
73be17206ae36ada23dceabaaf06490ff47decf9
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
73be17206ae36ada23dceabaaf06490ff47decf9
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
73be17206ae36ada23dceabaaf06490ff47decf9
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e46e782300549f4004b90636fb9b030b457418e2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fa9625a01e408cbe9d68fbd333e4f31734bd69c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
2fa9625a01e408cbe9d68fbd333e4f31734bd69c
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
ed9cb690b28cafb947215608507ee94736a3e6f2
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
a5bc2a53d0aabe3698afa24f858a5a806ca5e7bc
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
773e900cd47e028d99d95d3b1462f5ab95ec4d20
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
773e900cd47e028d99d95d3b1462f5ab95ec4d20
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
773e900cd47e028d99d95d3b1462f5ab95ec4d20
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


cmake: Make client simulator a subdir instead of a subproject

Add opt-out option to disable client simulator build.
@mgaio I reused the patch you previously submitted.

This pull request is now managed with CodeReviewHub. Refresh.


(js/ts) JSX/TSX support master thread

This is a master thread created to track the overall discussion of our JSX/TSX support.

https://github.com/highlightjs/highlight.js/issues/1625 (comment highlighting)
https://github.com/highlightjs/highlight.js/issues/2324 (inline code)
https://github.com/highlightjs/highlight.js/issues/2721 (JSX inside inline code, ad infinitum)

Support for JSX/TSX is not a single thing.  We already include "basic" support for embedded XML/HTML fragments using the xml sublanguage.  We do not support comments or embedded JS.
This has all been attempted several times and is a very hard problem.  This thread exists to talk about the high level problem instead of the individual mini-problems.

Pulling this form discussion on https://github.com/highlightjs/highlight.js/pull/2412.

I'm pretty sure I became persuaded sublanguage is NOT the correct way to handle this.  JSX is NOT simply XML embedded inside Javascript (as it's handled now).  It's literally an extension to the JS language that also allows JS line comments, inline code, etc... this means the proper way to do it is to treat it as HTML tags within the JS language/grammar.
The problem then becomes you need an actual syntax parser to track the state, count tags (so you know when you leave the JSX fragment and are back in JS land - also accounting for comments, inline JS, JSX inside inline JS, etc)... and full blown parsing is not what we do.
 Plus TSX is also a thing as well.  So a proper solution here has to be able to distinguish between type annotations/casting Array<number> and embedded JSX. Hence the current hasClosingTag logic...


[WIP] Add new ?output_type and ?existing_only query param filter to /v1/api/executions//output API endpoint

This pull request adds new ?output_type=[raw|event_source] and ?existing_only=[true|false] query parameter filters to the /v1/api/executions/<id>/output API endpoint.
With this query parameters, user can control two things:

What type of output to receive

raw for raw output data produced by the execution (default). This works well when user just wants to curl this endpoint, embed the output directly in a webpage or similar.
event_source - for event source compatible format (new line delimited JSON). This comes handy when user is also interested in metadata such as timestamp and output type.

NOTE: event_source format can result in a slow response for actions which produced a lot of data because it means we need to format and JSON serialize every ActionExecutionOutputDB object. Sadly there is no easy way around it.

If they want the API endpoint to block or not.

It defaults to ?existing_only=false which means the API endpoint will block until the execution finishes and write any new data when it arrives to the open connection.
Keep in mind that this only applies to executions which are still in running state.
This functionality was added to allow for a better integration with WebUI. Before this change, there was no way to retrieve output which execution produced so far if user wasn't listening to the stream API endpoint from the beginning when the execution started.
TODO

[ ] Tests

@enykeev Here you go - this should solve both of the issues / deficiencies you were heaving.
Having said that, I'm not a big fan of the event_source format - it will be very slow for executions which produce(d) a lot of data (we need to call json_encode on each output line...).
Sadly there is no easy way around that if we follow "event_source" specification.
That's why I suggest approach I already suggested on Slack - only support raw format which means we don't need to do any serialization and include timestamp of the last output object in the response headers or similar.
The reason why we need to include timestamp or similar is to allow client to avoid a race initially when retrieving running execution output - first client needs to request the existing output and then listen to any new output on the event stream API endpoint. Without having an access to a timestamp or similar this means the same output line could either be printed twice or zero time depending on the race time window.

To add some hard data to my comment above.
Here is an example timing info for execution which produces 3200 short lines:

raw - real	0m0.845s
event_source - real	0m2.527s

So the overhead isn't all that large for relatively small executions, but it could probably get problematic with execution which produce more longer lines.

Having said that, I'm not a big fan of the event_source format - it will be very slow for executions which produce(d) a lot of data (we need to call json_encode on each output line...).

We can aggregate existing data into a single message.
We can continue output the data as plain strings that are just wrapped with eventsource package and avoid json formatting altogether.

event: eventname
data: <plainstring>
[\n]

This also fixes separation of concern and moves streaming behavior from st2api to st2stream service. This way we are not mixing short running and long running connections in a single service (st2api).

That sounds really good :100:

The problem with this approach I myself did not anticipate is the fact that according to the spec, when event source endpoint "completes loading (i.e. the entire HTTP response body is received or the connection itself closes), the user agent must reset the connection." In other words, as soon as all the data from /stream/executions/{id}/output is loaded and server closes the connection, the client is required to reestablish the connection anew and in our case will receive entire result again.
There's multiple ways we can approach that one, but it seems to me that the best one would be to just emit another event at the end that would tell the stream is over successfully and no more data is ever coming via this channel again. Something like ```
event: st2.execution.output__close
data: ''

While working on this and testing it under Python 3 I encountered an issue with message bus message deserialization failing under Python 3 if message contained non-ascii data with the following error:
2018-08-02 09:45:42,044 ERROR [-] Can't decode message body: DecodeError(UnicodeDecodeError('ascii', b'[b\xd2\xb4\x96-tuu\xb6\x87\xbf', 2, 3, 'ordinal not in range(128)'),) (type:'application/x-python-serialize' encoding:'binary' raw:'b\'\\x80\\x02cst2common.models.db.execution\\nActionExecutionDB\\nq\\x01)\\x81q\\x02}q\\x03(U\\x0f_changed_fieldsq\\x04]q\\x05U\\x0f_fields_orderedq\\x06(U\\x02idq\\x07U\\x07triggerq\\x08U\\x0ctrigger_typeq\\tU\\x10trigger_instanceq\\nU\\x04ruleq\\x0bU\\x06actionq\\x0cU\\x06runnerq\\rU\\nliveactionq\\x0eU\\x12workflow_executionq\\x0fU\\x0etask_executionq\\x10U\\x06statusq\\x11U\\x0fstart_timestampq\\x12U\\rend_timestampq\\x13U\\nparametersq\\x14U\\x06resultq\\x15U\\x07contextq\\x16U\\x06parentq\\x17U\\x08childrenq\\x18U\\x03logq\\x19U\\x07web_urlq\\x1atq\\x1bU\\x0c_initialisedq\\x1c\\x88U\\x0f_dynamic_fieldsq\\x1dcbson.son\\nSON\\nq\\x1e)\\x81q\\x1f}q U\\n_SON__keysq!]sbU\\x08_createdq"\\x89U\\x05_dataq#h\\x1e)\\x81q$(U\\x03_idq%cbson.objectid\\nObjectId\\nq&)\\x81q\\\'U\\x0c[b\\xd2\\xb4\\x96-tuu\\xb6\\x87\\xbfq(bh\\x08}q)h\\t}q*h\\n}q+h\\x0b}q,h\\x0c}q-(X\\x0b\\x00\\x00\\x00runner_typeq.X\\x0f\\x00\\x00\\x00local-shell-cmdq/X\\x0b\\x00\\x00\\x00descriptionq0XA\\x00\\x00\\x00Action that executes an arbitrary Linux command on the localhost.q1X\\n\\x00\\x00\\x00parametersq2}q3(X\\x03\\x00\\x00\\x00cmdq4}q5(X\\x08\\x00\\x00\\x00requiredq6\\x88X\\x04\\x00\\x00\\x00typeq7X\\x06\\x00\\x00\\x00stringq8X\\x0b\\x00\\x00\\x00descriptionq9X9\\x00\\x00\\x00Arbitrary Linux command to be executed on the

The issue is related to str_to_bytes function in kombu (https://github.com/celery/kombu/blob/3.0/kombu/utils/encoding.py#L47) not passing encoding argument to encode() method which means it defaults to ascii and fails.
I've pushed a workaround for that in 35823e1c65d4133e31393dd2663bb85e8b89b656 (we now explicitly pass utf-8 encoding to encode()).
Moving from pickle to JSON is on our road map and I already started to work on it in the past, but it's sadly a lot more involved because our code relies on actual object instances being passed around :/

Docs changes in https://github.com/StackStorm/st2docs/pull/779.


[GSSoC'23] Adding a Project: Recipe Finder

Recipe Finder: An application that allows users to search for recipes based on or cuisine types. Display the search results with recipe details and instructions.

assigned to u and In PR include deploy link or screenshot to assess your work. Dont forget to follow contributing.md guidelines after reviewing PR by mentor


Implement usage of Strict Mode in resources

I think we should add Set-StrictMode with either version 1 or 2 to resources.  This will make it easier to discover usage of uninitialized variables, references to non-existent properties of an object, function calls that use the syntax for calling methods, and variable without a name.
I have seen issues in some of the resources that possibly would have been discovered by setting strict mode.
Strict Mode will help increase the quality of the scripts.
Here is some more information: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/set-strictmode
https://blogs.technet.microsoft.com/heyscriptingguy/2014/12/03/enforce-better-script-practices-by-using-set-strictmode/

The impact of adding this can be quite big, since this might reveal issues in the code which was no problem before and after enabling this will start throwing errors. So this needs to get tested thoroughly.
Unused variables are indeed covered by the PSScriptAnalyzer, but I believe StrictMode does more.
@NikCharlebois What is your opinion in this?

One thing that strict mode does is that each variable must be declared before being used. That is probably the biggest thing (that I can think of) that will add to the technical debt and need to be resolved in all of the code.  :thinking:

Just a thought:
Isn't the Utils module a good place to add the StrictMode cmdlet. Since that is automatically loaded when importing the module, it is automatically loaded for all resources. Am I right?

I don't think that will work as strict mode only works on the current scope and any child scopes.

But if the helper functions in "Util" are tested in unit tests then it should apply? If Strict mode is applied, will the unit tests start to fail (so we see it makes a difference)? 🤔

@ykuijs to me it is just common sense for us to use StrictMode v2.0. We are trying to encourage contributors to follow best practices, and want to make our code as clean as possible. Anything additional quality gates we can have in there the better if you ask me. Now, we would need to do a quick test run to see what the impact would be on all existing resources, but I am all in favor of using it.
I believe that all would be required for this to be checked upon running the tests in AppVeyor is to modify the YAML build definition to include the Set-StrictMode clause:

ps: |
Set-StrictMode -Version 2.0
$moduleName = 'SharePointDsc'
$mainModuleFolder = "Modules$moduleName"
Import-Module -Name "$env:APPVEYOR_BUILD_FOLDER\DscResource.Tests\AppVeyor.psm1"
Invoke-AppveyorInstallTask

I think it would be better to enable strict mode in the test framework (the function that is run in each test, see test template in DscResource repo). Or, add it to a separate row in each test or/and code script file.
Otherwise the script mode would not be enabled when running the tests locally.

I managed to get the StrictMode set by adding Set-StrictMode -Version 2.0 as the first line in initScript in UnitTestHelper.ps1. This way all tests will run the resources with strict mode set. It should probably also be added to other supporting script files too. In addition all unit tests should also have this set in each file. I don't see how that could be added elsewhere for local test runs.
I get errors from all resources I've tested (I just tested a few) when I set strict mode to version 2, so there seems to be a lot of work to do to be able to actually implement this.

I've implemented strict mode version 1 in #999 The use of strict mode uncovered a few bugs in some of the resources. At first I think we should just implement strict mode version 1 as using version 2 generated a lot more issues, and it will take time to fix all of them. Version 1 will still uncover many potential code issues.


Add mina-status-monitor

mina-status-monitor A tool on Docker for monitoring your node, restart automatically your node when it stuck in old blocks, and the snark stopper

Thank you for your submission! 🚀


VSCode extension doesn't work with Handlebars (.hbs)

UnoCSS version
0.55.0
Describe the bug
I'm using Handlebars templates (.hbs extension) and UnoCSS VSCode extension doesn't detect it - no class highlights, no autocompletion.
I've tried adding Handlebars to config but no luck.
    "unocss.languageIds": [
        "handlebars",
    ],

I think it's supposed to work out of the box since hbs is in the default language list: https://github.com/unocss/unocss/blob/401510f3fc154f99ccaad7c3d71e03640abb37f9/packages/vscode/src/autocomplete.ts#L15
Note: as soon as change file extension to .html UnoCSS instantly "loads" - highlights and autocompletion works, but I can't rename files all the time...
Reproduction

Create a file with .hbs extension.
Copy some minimal code into it:

Hello World

UnoCSS autocompletion and class highlight should work.

System Info

Windows 11
VSCode 1.81.1
UnoCSS 0.55.0

Validations

[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Also having this issue with .liquid files.
The ContextLoader class is using createContext from packages/shared-integration, which only passes defaultPipelineInclude to Rollup's createFilter, so the filter used to check files doesn't include any configured languages, just the default ones. I haven't had time to look at this in depth, but just from a quick debug, this looks like the cause to me.
Relevant lines:
https://github.com/unocss/unocss/blob/main/packages/vscode/src/contextLoader.ts#L113
https://github.com/unocss/unocss/blob/main/packages/shared-integration/src/context.ts#L21
https://github.com/unocss/unocss/blob/main/packages/shared-integration/src/defaults.ts#L5
https://github.com/unocss/unocss/blob/main/packages/vscode/src/annotation.ts#L91
https://github.com/unocss/unocss/blob/main/packages/vscode/src/autocomplete.ts#L117


38 feature: create new post via template

Check it out:
Create new blog-skeletons with the script in the R/ folder: "create_blogpost.R"

@pharmaverse/commswg
We have to discuss the front images and corresponding tags.
The function I created here copies default images for specific tags / image parameter.
We should also discuss the tags we want to use.
In my opinion, writers should use as many of the predefined tags as possible.
Should they be able to create their own?

@pharmaverse/commswg
We have to discuss the front images and corresponding tags. The function I created here copies default images for specific tags / image parameter. We should also discuss the tags we want to use. In my opinion, writers should use as many of the predefined tags as possible. Should they be able to create their own?

No I don't think people should make their own tags - we should provide a set and create news one if needed.

Should be done now, @pharmaverse/commswg
please try it out, see if it works as expected and adjust the readme files if needed.


chore: import repository https://github.com/keerthana4008/keerthana4008.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jxbotaccount: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
04edc35317bc40ee4616b733330e98005aec63ee
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


[POC] Select with text filter

https://issues.redhat.com/browse/AAH-2374
Previous select with text filter allowed only for filtering items that are already loaded. This PR enables to load items based on actual text filter entered by user.
PR adds callback onSearchTextChange in IToolbarSelectFilter that fires any time search text is changed, so loading of new filtered items can be done and passed back as options of select.
PR also adds example implemented in collections list using repository filter.  Note that collection list will be updated in next PR to match new repository management changes in Hub, so this example is only for proof of concept.

This is the wrong search type.
We need a typehead search for AAH-2374,
but it should look more like this...

Specifically, no checkboxes, no multiselect. (I guess the search popup is fine if we have to.)

This is the wrong search type.
We need a typehead search for AAH-2374, but it should look more like this...

Specifically no checkboxes & no multiselect. (I guess the search popup is fine if we have to.) ToolbarTypeaheadFilter?

I was building this upon existing framework functionality. We need to consult this in our meeting, so we dont have 2 different approaches.

Yes, the repositories in this PR should be different than in main. In main, repositories are hand coded, because in time, when James wrote this page, we had them defined in database by default. In current version, user may define their own repositories, so they must be loaded from database.


Taking recorded wav as input makes the odas_web extremely slow

Hi
When I take a recorded 8-channel wav file as input of odas and want to look at the potential and tracking information graphically, it makes odas_web run extremely slow, taking several seconds for each frame refreshing and the connection quickly got closed.  The CPU usage is very high (> 90%) while running.
I wonder whether odas_web supports taking wav file as input signals, or is there any way to make odas_web run as normal as taking soundcard signal as input

When ODAS processes from a raw file, it runs as fast as possible, not in real time. Doing so, it outputs the data at a really fast rate and the interface can’t follow. It also quits once the file is over.
I know there was once a function in ODAS to run at « real » speed from a raw file, but I think it’s been refactored away.
You could check with François in the ODAS repo.

OK, Thanks for reply, I have used other plot toolkit to roughly get it done.  Making the interface work is obviously more convenient and clear, though.  Maybe I can figure it out later.
Thanks again


Silent requires device to be set

When installing using the kernel arguemnt k30s.install.silent=true I was running into where it would display the help text of the install script. I realized it was not setting a device, so I used a kernel argument to explicitly set the device which worked fine.
If I remove silent, the install script intuits the correct device automatically, but then I have to interact :(.

The documentation could be better for silent installations.

Yeah, could totally just be a documentation solve! Happy to open that PR if thats the route you'd like to go!

Hit this today, had a rough half an hour.
At least for the time being it'd be nice to have a note in k3os.install.silent's description documenting this kind of behaviour..


Generate the private key file and generate the public key file

It is very inconvenient to only generate the private key file during use, so it is more reasonable to increase the generation of the public key file

Thank you for your interest in Mbed TLS. Could you explain more the motivation of this PR? What does it bring to the project? You mentioned that it is "very inconvenient to only generate the private key file". Could you elaborate on that? In which use cases have you experienced this inconvenience.
Otherwise: each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.

Thank you for your interest in Mbed TLS. Could you explain more the motivation of this PR? What does it bring to the project? You mentioned that it is "very inconvenient to only generate the private key file". Could you elaborate on that? In which use cases have you experienced this inconvenience.
Otherwise: each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.

Thanks ronald for reply.
When some embedded devices use rsa encryption and decryption scenarios, in order to save processor processing time as much as possible, they usually define N, E, D and other parameters directly, and then use them directly, avoiding encoding conversion, extracting related parameters and other operations . However, the standard PKCS-related format is usually used in the scenario of interacting with the server, and the relevant parameters such as N, E, and D are not directly used. Therefore, in order to ensure convenient communication with the server, it is only necessary to generate RSA N, E,  D related parameters, generate the public key and provide it to the server.

Thank you for your interest in Mbed TLS. Could you explain more the motivation of this PR? What does it bring to the project? You mentioned that it is "very inconvenient to only generate the private key file". Could you elaborate on that? In which use cases have you experienced this inconvenience.
Otherwise: each commit must have at least one Signed-off-by: line from the committer to certify that the contribution is made under the terms of the Developer Certificate of Origin.

Thanks ronald for reply.
When some embedded devices use rsa encryption and decryption scenarios, in order to save processor processing time as much as possible, they usually define N, E, D and other parameters directly, and then use them directly, avoiding encoding conversion, extracting related parameters and other operations . However, the standard PKCS-related format is usually used in the scenario of interacting with the server, and the relevant parameters such as N, E, and D are not directly used. Therefore, in order to ensure convenient communication with the server, it is only necessary to generate RSA N, E, D related parameters, generate the public key and provide it to the server.

I can understand that in certain applications you only need to provide a public key file instead of a private key file however it seems quite limited in it's applications.

It's not very common to need a public key file: often the key is certified by a PKI and the first step for that is a certificate signing request, which embeds the public key, and which you can generate with the sample program cert_req.

Remember that this is an example program which users can then customise to their own needs

But conversely, it's good to have an example program demonstrating how to write a public key. However, this already exists in key_app_writer.

It will also take (marginally) more processing time to generate the extra file and extra storage to store it afterwards.

Completely irrelevant for a sample program.

I do think that this could be turned into a command line option however which could provide the flexibility for users and also demonstrate in the code how to generate public keys.

It is a command line option. But I'd suggest making the public key file generation optional: don't write a public key file by default, but do write one if the option public_filename is specified.

Closing. I think this is covered, as @gilles-peskine-arm comments above, by the existing example programs.


Gh/improvements

@geneh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Add ESTIA university files via upload

Adding ESTIA to university license support

@boomiin Pull request merged. Thank you!


IE11 - Suspense broken

Hi,
I'm having trouble making my app work correctly on IE11.
On initial load the page displays correctly but on route change, it seems that Suspense never resolves and keeps my page with a display: none style, even though the page is correctly loaded (it exists in the DOM).
I have babel-polyfill as my entry point in my webpack config.
No errors are logged in the console in IE so I'm kinda clueless here...
Anybody experiencing the same issue?
Thanks!

Given https://github.com/facebook/react/issues/14583 and https://github.com/facebook/react/issues/14570, I think this is an upstream issue. They have been closed and solved using specific polyfills there.


feature(cli): graceful shutdown with grace period

Reason for This PR
closes https://github.com/spiral/roadrunner/issues/555
Description of Changes

Add configurable grace period. The default is 30s.
Add endure configuration section:

endure:
  # default 30s to finish, possible values 10s,100m,5h
  grace_period: 30s
  # default false, print graph in the graphviz format to the stdout (paste here to visualize https://dreampuf.github.io)
  print_graph: false
  # default debug
  log_level: debug

First signal (SIGINT, SIGTERM) activates grace period to finish plugins. The second signal (SIGINT, SIGTERM) forces the application to exit with a non-zero error code.

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

Can it be the default config for endure (not people know or will know about it) and infinite grace period?

Can it be the default config for endure (not people know or will know about it) and infinite grace period?

An infinite grace period is not a common practice. I'm not sure, that I see any reason to leave endure waiting for the plugin to stop infinitely. Because this is related also to the errors during the stop, an infinite grace period will lead to unexpected freezes. I would be glad if you describe the reasons to have this by default.

To avoid confusion, where are the plugins and do not mix plugins declaration with the root.go all plugins moved to the cli/plugins.go. A commentary explaining where is the plugins added to the main.go.


[Service Bus] Change from static factory method to constructor for copying received message

Closes #11633
I was assuming no obsolete is necessary due to the client being in preview

Can one of the admins verify this patch?

@danielmarbach:  Once again, thank you for your contribution!

/azp run net - servicebus - tests


Adding Support For Mobile Presence

Changes
Let's users use a mobile presence, using the gateway identify
Check off the following

[x] I have tested my changes with the current requirements
[x] My Code follows the pep8 code style.

I believe this breaks the rules of the discord API https://discord.com/developers/docs/topics/gateway#identifying-example-gateway-identify

I believe this breaks the rules of the discord API https://discord.com/developers/docs/topics/gateway#identifying-example-gateway-identify https://discord.com/developers/docs/topics/gateway#identify-identify-connection-properties

i wouldn't really know why, i know it's been a thing since at least 2019 if this was a bug it would've been fixed by now


incorrect conversion of controller.cpp

https://jrl-umi3218.github.io/mc_rtc/tutorials/introduction/sources/multi-robot-controller.html
is generated from doc/_includes/tutorials/introduction/multi-robot-controller/controller.cpp but it is partically converted incorrectly.
For instance:
doorPosture->target({{"door", {0.5}}}); (66th line) is converted into doorPosture->target(door);

Thanks for the report.
It would seem that it got parsed as a Liquid tags {{ ... }} of the jekyll template. I'll look into it tomorrow, along with finalizing the missing tutorial/sample controller as reported in #65 (almost done).


example missing in 2022/19

Nice notebooks this year, Martijn! I noticed the assert in Day 19.ipynb part 2 is bogus:
assert reduce(mul, largest_number_geodes(example))

It should be
assert reduce(mul, largest_number_geodes(example)) == 3472

Or even better
assert math.prod(largest_number_geodes(example)) == 3472

Ah, well spotted! I've fixed it in the simplest way possible; I wasn't yet aware of math.prod at the time.


Bump nokogiri from 1.11.4 to 1.12.5

Bumps nokogiri from 1.11.4 to 1.12.5.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: nokogiri
dependency-type: indirect
...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>

dependabot/bundler/nokogiri-1.12.5.patch

Bump nokogiri from 1.11.4 to 1.12.5


Acess to value on watch callback when available

Describe the feature
I find it weird that watch method doesn't actually provide me k:v pair for example.
Is there any specific reasoning why watcher strictly returns only event and key and can't be customized further?
Building a browser storage driver is not quite good this way. I'd expect in watcher to receive a key and value on update and only key on delete, for example.
With current implementation, I'd need to get the value from the storage, using the key it provides me with, which seem like overhead?
Additional information

[x] Would you be willing to help implement this feature?

Hello,
played arround with unstorage and it should take over and replace some of my features code parts out of the box!
Thanks for that awesome project 🥇 👍
watch could much more powerful with callback arguments changed to (key, value, oldValue, event) => {}.

value: Because value should be available during save data and trigger event a get overhead can be avoided?
oldValue: Would be cool for some use cases and helps to have more precise event type (added, updated or deleted) and more flexibility?
event filtering: Ok, just optional if easy to implement because it could be done by a wrapper arround the watch callback... filtering events by key match or regexp / wildcard based filter functions to listen to specific changes

I would love to see value and oldValue for my needs :)


Fix arguments parsing with " inside

Hello Nicolas 👋
This PR partially fix issue with parsing quoted arguments.
For instance,
ssh "user name"@localhost
produced [ssh, user name, localhost] argv.
With this PR it will produce [ssh, \"user name\"@localhost] argv.
Not ideal, but a least we can handle that inside command.
Ideal fix would be to also fix unquoteArgument function https://github.com/holzschu/ios_system/blob/6a83eb1c6c383a562fbe33a7e97677e88d305b51/ios_system.m#L2442-L2447
But fix require new allocations, so I decided that this PR is good for the start.

Hi Yury,
thanks a lot. It makes a lot of sense. I'm merging.


Updated the swedish lang files

I hope this is what you ment :)

@Hambern Perfect! Thank you very much, just in time for the next release.
I'll close the previous two pull requests. Thanks again!


Route parameters not passed to router

Consider this app
let express = require('express');

let router = express.Router();
function handler(req, res) {
  res.send({
    url: req.url,
    params: req.params
  });
}

router.get('/about', handler);

let app = express();
app.use('/:prefix', router);

let port = process.env.PORT || 8000;
app.listen(port);
console.log('Listening on port %d', port);

Then start and request it
$ curl http://localhost:8000/hk3/about
{"url":"/about","params":{}}

Notice that params is empty, meaning that path parameters are not passed to the router.
If you change app.use('/:prefix', router); to app.use('/:prefix', handler);, you will get:
$ curl http://localhost:8000/hk3/about
{"url":"/about","params":{"prefix":"hk3"}}

Is this intentional or a bug?

There's some documentation on this. Check out https://expressjs.com/en/4x/api.html#express.router, specifically mergeParams is what you're looking for.


cmake: bump minimum version of OpenSSL to 1.1.1

We should update the readme, too: https://github.com/baresip/re#supported-versions-of-openssl

I am also wondering if we should use pre-compiled OpenSSL for the CI.
It takes a long time to compile OpenSSL for each commit ...

We use already cached builds like here: https://github.com/baresip/re/blob/main/.github/workflows/mingw.yml#L41-L47

aha, that is great.
So we can also do the same for e.g. Android build ?


Is it possible to run rustpad on redox-os?

Hi!
I like the redox-os operating system and the rustpad project, and I would like to know if it is possible to run rustpad on redox-os.

A question does rustpad work on redox-os?
Is it possible to run rustpad on redox-os?

Technical issue and not feature request.

I'm not familiar with Redox OS and wouldn't be able to answer this question, unfortunately.


Something wrong with updating

When downloading the plugin it says there is an available update. Upon running the update it says that there is already a plugin with that version. I'm guessing maybe the version wasn't updated in whatever file holds the plugin info (like plugin.yml or something)? I am still getting the error described in #1 and I think maybe it just hasn't updated?
It says it is on version 1.02 which is the latest one.

But here is says 1.0.0

In the plugin.json it says it is on version 1.0.0. That is likely the problem. Although I am not suer if that is related to me running into #1


Reentrancy

When needed typically we should use Shared clone (override methods). Exceptions would be, eg, things running in parallel in Lock-In demodulation, and they should use pre-allocated clones.
This task is to evaluate existing clones In Instrument Framework and choose an appropriate method. For example, Open and Close in RemoteControl should be shared, but at the moment I think they are pre-allocated

"Shared clones and stateful VIs don't play well together."
https://forums.ni.com/t5/LabVIEW/Notifiers-and-Shared-Clone-Re-entrancy/td-p/3856781/page/3

"
There are two situations where I have use "Re-entrant Execution".  One is the situation you describe -- I want to have multiple (parallel) instances of a processing routine running simultaneously.  The other is when I want a recursive routine -- "List all of the Files in this Folder and all of its sub-Folders" -- which you code by making the routine call itself (if you think about the "List all Files" problem, you can solve it by listing all of the files in the folder, then pass each Folder to "List all Files" to list all of the files in the folder, which calls "List all Files" to list all the files in its sub-folders, etc.)
Recursion I usually use Shared Reentrancy, as I don't need VI to be called multiple times.  When I've used parallel instances, I've almost always used Pre-allocated Reentrancy.
But what about your question, namely about the VIs that these Reentrant VIs call?  The answer is "It depends".  If the sub-VI is not reentrant, then all four parallel Instances may try to call the single copy simultaneously.  If it does something "fast" (I can't think of a good example right off-hand), then it probably won't make much difference, and will be one less thing to worry about.  Perhaps more important, does the sub-VI need to "remember" anything about the VI that called it, such as storing anything in a Shift Register?  Then you definitely want a Pre-Allocated clone, so Clone A always calls sub-Clone A, saving A's stuff in sub-Clone A's Shift Register.
I just looked at one of my older "Clone" Projects (I went crazy -- each Clone, up to 24 of them, had three parallel routines, so we could have 96 clones running simultaneously).  Most of the sub-VIs at the top level of each Clone were also re-entrant.  The exceptions were routines which did simple computations once (like computing the number of buffers I needed, takes little time and is done once/clone) and routines that (quickly) returned a program-updated Global Value (like how many milliseconds had the program been running).
If you want further recommendations, post the relevant code (no pictures, please -- a .zip file representing the compressed folder containing the entire Project is best) so we can better understand your situation.
Bob Schor
"
https://forums.ni.com/t5/LabVIEW/best-practices-with-quot-shared-clone-reentrant-execution-quot/td-p/4079115

@ciozi137 check SMO and MQT. process.vi in an SMO is shared clone; this might be because it calls itself (call parent method) AND because it is called dynamically (multiple copies): the question is how should methods like open, connect, send, receive, close be: are they reentrant at all?

Shared mainly...

https://www.ni.com/docs/en-US/bundle/labview/page/reentrancy-allowing-simultaneous-calls-to-the-same-subvi.html

https://labviewwiki.org/wiki/Reentrant_VI

RemoteControl v1.1.1 implemented these changes


d3d11: samplerstate hashing fix

there's a case where you can request two different sampler states and they end up resolving down to the same sampler state in d3d11 internally, causing DX_CHECK_REFCOUNT(sampler, 1); to trigger.
Namely if you do
BGFX_SAMPLER_MIN_ANISOTROPIC | BGFX_SAMPLER_MAG_ANISOTROPIC
and
BGFX_SAMPLER_MIN_ANISOTROPIC | BGFX_SAMPLER_MAG_ANISOTROPIC | BGFX_SAMPLER_MIP_POINT
it'll trigger that assert.
you can repro the assert with this patch to bump.cpp example
diff --git a/examples/06-bump/bump.cpp b/examples/06-bump/bump.cpp
index 31afa7200..d99022568 100644
--- a/examples/06-bump/bump.cpp
+++ b/examples/06-bump/bump.cpp
@@ -282,8 +282,11 @@ public:
                                                bgfx::setIndexBuffer(m_ibh);

                                                // Bind textures.
-                                               bgfx::setTexture(0, s_texColor,  m_textureColor);
-                                               bgfx::setTexture(1, s_texNormal, m_textureNormal);
+                                               const uint32_t samplerFlagsA = BGFX_SAMPLER_MIN_ANISOTROPIC | BGFX_SAMPLER_MAG_ANISOTROPIC;
+                                               const uint32_t samplerFlagsB = BGFX_SAMPLER_MIN_ANISOTROPIC | BGFX_SAMPLER_MAG_ANISOTROPIC | BGFX_SAMPLER_MIP_POINT;
+
+                                               bgfx::setTexture(0, s_texColor,  m_textureColor, samplerFlagsA);
+                                               bgfx::setTexture(1, s_texNormal, m_textureNormal, samplerFlagsB);

this PR fixes things so these two requests do end up hashing to the same value. I'm hashing more memory than before, there's probably a way to compact the D3D11_TEXTURE_ADDRESS_MODE's better I didn't explore it much.

sorry the git history is all weird I am super weak git-foo. If you have a quick tip on how to fix it I'll do it otherwise feel free to just yoink this and paste it

Ok, I looked into your PR, but doesn't make sense why passing just addressing modes would fix this. I'll need to investigate.

sorry the git history is all weird I am super weak git-foo.

Btw, if you syncing branches with latest, use rebase instead of merge.

I'm trying to repro this but it's not triggering the error you have.

I just repro'd the assert on another machine with that patch against latest. Here's all the debug output up to hitting the assert if that gives any hints
bump_example_debug_output.txt

genie command
..\bx\tools\bin\windows\genie --with-windows="10.0" --with-examples --with-tools vs2019
no command-line args to bump.exe


Fix Installer

Based on this issue https://github.com/zweiler2/HoloISO_Tweaked/issues/36#issuecomment-2243737716

Related https://github.com/zweiler2/HoloISO_Tweaked/issues/36#issuecomment-2243737716

I may add calamares but i need to test ir

Similar : https://github.com/LukeShortCloud/winesapOS/pull/853#issuecomment-2244160929

Remaking the installer will take a long time and i do not want GuestSneezeOS to be the gentoo linux of SteamOS

Calamares can be used in the GuestSneezeOS 7

The last iso cannot be install on Internal disk on my desktop

Make a guide how to install in disk i choose

I will see what i can do

https://github.com/GuestSneezeOS/GuestSneezeOS-winesap/issues/1 Related

@Labsdj type these command
sudo passwd root
su
cd newbackup
./install.sh

@nyxiereal would you like to help?

@Labsdj have you tried pacman-key --init && pacman-key --populate archlinux

Not try yet @GuestSneezeOSDev but the OS need to be easy to install for a initiate person like me or others

I think the command get a error https://aur.archlinux.org/packages/calamares-git this

Nah vro im good

@Labsdj I think it was not that package https://aur.archlinux.org/calamares might be the package also to use it you should NOT be in root

Development will now be focused on https://github.com/GuestSneezeOS/GuestSneezeOS-winesap since i forgot to add some important code


OpenTSDB Metrics Turn On - Nagle's algorithm

OpenTSDB Metrics - publish bug fix.
Some time ignored metrics.

👍  Thanks @thinker0!


load_vi_mode() takes an excessive amount of time, even when vi mode isn't used.

Hi @jonathanslenders et al., I just wanted to let you know that after profiling xonsh startup times a bit, I have found that one of the major culprits is the load_vi_mode() function.  This figure shows the breakdown for the shell initialization function, which calls the KeyManager initializer:
http://vmprof.com/#/56e022bb8e1d53cffec42ff1b8d230b6?id=2,0,0&view=flames
Worst of all, there doesn't seem to be a way to turn this off selectively in the event that vi mode won't be used.  Even weirder is that the emacs mode loading doesn't take nearly as long.
This was on v1.0
A fix would be great, because we'd like to keep our startup times as low as possible.

Thanks for pointing out! I was aware that loading the Vi bindings took a bit more time, but didn't realize that it was this much. I'm sure it should not be hard to optimize, I'll have a look during the coming days.

Thanks @jonathanslenders!

Note that this was made using vmprof, and so it might not be an exact representation of execution time.

It's probably quite accurate. The slowness seems to come mostly from the generation of key bindings for the named registers. That on itself is fine, but the I think the many layers of functions wrapping function in key_binding/bindings/utils.py is too much and not necessary. I'll try to simplify it.

Hi @scopatz,
Could you try and measure again with the latest commit of prompt-toolkit?
I did a rewrite of the input processor. So, now it's possible to have key bindings, consisting of several keys, with Keys.Any anywhere in the sequence. Because of this, we have only one key binding for operations on named register, instead of for each possible register.
See this commit: https://github.com/jonathanslenders/python-prompt-toolkit/commit/c65b9e387ece4d0a781724208906e8dc5a0395c1
The unit tests became twice as fast, because of this.

Hi @jonathanslenders - this is looking much better thanks!  You can see the latest profile here: http://vmprof.com/#/1ac6191b0c3283c2315b38529aee5193?id=2,0,0&view=flames  (note that the original link was for 41.47% of the total runtime, while this one is for only 23.2%)
This seems to cut xonsh's ptk startup time to be within 5% - 10% larger than when using readline.
Interestingly though, load_vi_bindings() is still responsible for about half of the remaining startup time. I am happy to close this issue, but this function may still be worth investigating. Thanks for the promptness!

Don't close it yet. I will see whether it's feasible to improve this even more. I think it should be possible.

One more fix: https://github.com/jonathanslenders/python-prompt-toolkit/commit/e2bb3434a51c1b70e87ccff9284198efdd944f9e
Could you please measure again? After this, I have probably have one more improvement.

Hi @jonathanslenders - sorry about the delay. Here are the results I am seeing now:
e2bb343: http://vmprof.com/#/ad493ed7c30eeee8cf1e5facba871625?id=2,0,1&view=flames
f827949: http://vmprof.com/#/60ff6b401a5973eaf12356327c2fffe4?id=2,0,1&view=flames
It looks like f827949 is better than the other.  I would recommend keeping both since every microsecond counts here :)

Closing this. Many optimizations have been done. Let's open a new issue if there are still some performance issues in the code.


ESP Rainmaker HomeKit Switch Example Please set HOMEKIT_PATH to esp-homekit-sdk repo (MEGH-3399)

I get this error when trying out the ESP Rainmaker HomeKit sample.
However; when I try to declare the HOMEKIT_PATH I get the following error:

Any ideas on how to resolve this please. I have try different methods but none seems to work out.  It only happens when I try the ESP Homekit SDK.
Thanks

@maialbe2823 how exactly are you setting the HOMEKIT_PATH? As per the example README, you need to set it using
$ export HOMEKIT_PATH=/path/to/esp-homekit-sdk/

This works atleast on MacOS and Linux when used from the terminal.

Yeah , but how and where do I set that path?

On Apr 18, 2022, at 10:26 AM, Piyush Shah @.***> wrote:

@maialbe2823 how exactly are you setting the HOMEKIT_PATH? As per the example README, you need to set it using
$ export HOMEKIT_PATH=/path/to/esp-homekit-sdk/
This works atleast on MacOS and Linux when used from the terminal.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@maialbe2823 , as mentioned above, if you are using macOS or Linux terminal, export HOMEKIT_PATH=/path/to/esp-homekit-sdk/ is what you should execute on the terminal (basically, from the same place where you execute idf.py build). In your earlier comment, you mentioned "However; when I try to declare the HOMEKIT_PATH ...". Where did you declare this?

I declared it in the CmakeLists of the project since I saw it in one of the examples. So, I’m other words that’s only for Mac or Linux. But I’m doing this in Windows, and it still doesn’t run and it gives me those errors. How can I fix it on windows?

On Apr 22, 2022, at 6:10 AM, Piyush Shah @.***> wrote:

@maialbe2823 , as mentioned above, if you are using macOS or Linux terminal, export HOMEKIT_PATH=/path/to/esp-homekit-sdk/ is what you should execute on the terminal (basically, from the same place where you execute idf.py build). In your earlier comment, you mentioned "However; when I try to declare the HOMEKIT_PATH ...". Where did you declare this?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@maialbe2823 , you should set HomeKit_PATH at the same place where you have set your IDF_PATH. I believe the steps here may work, just by replacing IDF_PATH with HOMEKIT_PATH. Meanwhile, setting it in CMakeLists.txt may also work, but you may require to give the complete absolute path like set(HOMEKIT_PATH "C:/path/to/esp-homekit-sdk"). Have you tried that?

I did both ways but got this error instead:
for bothCMake Error:
Running
'C:/Users/.../.espressif/tools/ninja/1.10.2/ninja.exe' '-C' 'C:/Users/maial/OneDrive/Desktop/test/esp-rainmaker/examples/homekit_switch/build' '-t' 'recompact'
failed with:
ninja: error: build.ninja:21102: lexing error

Even I am facing the same issue.
I have modified the Cmakelists.txt file to add path and extra component directories of HomeKit SDK.
`# The following lines of boilerplate have to be in your project's CMakeLists
in this exact order for cmake to work correctly
cmake_minimum_required(VERSION 3.5)
if(NOT DEFINED $ENV{HOMEKIT_PATH})
message(FATAL_ERROR "Please set HOMEKIT_PATH to esp-homekit-sdk repo")
endif(NOT DEFINED ENV{HOMEKIT_PATH})
if(DEFINED ENV{HOMEKIT_PATH})
set(HOMEKIT_PATH $ENV{HOMEKIT_PATH})
else()
set(HOMEKIT_PATH ${/Volumes/SanDisk_Extreme/ESP32/esp-homekit-sdk})
endif(DEFINED ENV{HOMEKIT_PATH})
if(DEFINED ENV{RMAKER_PATH})
set(RMAKER_PATH $ENV{RMAKER_PATH})
else()
set(RMAKER_PATH ${CMAKE_CURRENT_LIST_DIR}/../..)
endif(DEFINED ENV{RMAKER_PATH})
Add RainMaker components and other common application components
set(EXTRA_COMPONENT_DIRS $ENV{HOMEKIT_PATH}/components/homekit ${RMAKER_PATH}/components/esp-insights/components ${RMAKER_PATH}/components ${RMAKER_PATH}/examples/common components)
set(EXTRA_COMPONENT_DIRS ${HOMEKIT_PATH}/components ${HOMEKIT_PATH}/components/homekit ${HOMEKIT_PATH}/examples/common ${RMAKER_PATH}/components/esp-insights/components ${RMAKER_PATH}/components ${RMAKER_PATH}/examples/common)
set(PROJECT_VER "1.0")
include($ENV{IDF_PATH}/tools/cmake/project.cmake)
project(homekit_switch)`

Even I am facing the same issue.
I have modified the Cmakelists.txt file to add path and extra component directories of HomeKit SDK.
cmake_minimum_required(VERSION 3.5)
if(DEFINED ENV{HOMEKIT_PATH})
  set(HOMEKIT_PATH $ENV{HOMEKIT_PATH})
else()
  set(HOMEKIT_PATH ${/Volumes/SanDisk_Extreme/ESP32/esp-homekit-sdk})
endif(DEFINED ENV{HOMEKIT_PATH})

if(DEFINED ENV{RMAKER_PATH})
  set(RMAKER_PATH $ENV{RMAKER_PATH})
else()
  set(RMAKER_PATH ${CMAKE_CURRENT_LIST_DIR}/../..)
endif(DEFINED ENV{RMAKER_PATH})set(EXTRA_COMPONENT_DIRS ${HOMEKIT_PATH}/components ${HOMEKIT_PATH}/components/homekit ${HOMEKIT_PATH}/examples/common ${RMAKER_PATH}/components/esp-insights/components ${RMAKER_PATH}/components ${RMAKER_PATH}/examples/common)

set(PROJECT_VER "1.0")
include($ENV{IDF_PATH}/tools/cmake/project.cmake)
project(homekit_switch)


Begin Implementing the Design!!!!!!

User Story: , I want clear guidance on the initial steps and requirements to commence the implementation process smoothly.
Actions: Begin the initial implementation of design components, focusing on foundational elements such as layout structure and basic styling.
Results: Effective collaboration between the development and design teams to address any questions or uncertainties.

Developer can now begin implementing this design!


Warning Error - Methods with invalid locals information

Describe the bug
I have build using cmd "ant all" see this?
' [java] com.google.appinventor.buildserver.util.Execution execute
 [java] INFO: ____Executing java @C:\Users\Admin\AppData\Local\Temp\1729521789533_1547858475231097856-0\youngandroidproject\..\build\tmp\d8arguments.txt
 [java] Info: Stripped invalid locals information from 5 methods.
 [java] Info in C:\Users\Admin\AppData\Local\Temp\1729521789533_1547858475231097856-0\youngandroidproject\..\build\classes\com\google\youngandroid\runtime.class:
 [java] Methods with invalid locals information:
 [java]   java.lang.Object com.google.youngandroid.runtime.isYailEqual(java.lang.Object, java.lang.Object)
 [java]   Attempt to define local of type int as x:java.lang.Object
 [java]   java.lang.Object com.google.youngandroid.runtime.isYailAtomicEqual(java.lang.Object, java.lang.Object)
 [java]   Attempt to define local of type reference as x:boolean
 [java]   java.lang.Object com.google.youngandroid.runtime.mode(java.lang.Object)
 [java]   Attempt to define local of type int as element:java.lang.Object
 [java]   java.lang.Object com.google.youngandroid.runtime.yailForRangeWithNumericCheckedArgs(java.lang.Object, java.lang.Object, java.lang.Object, java.lang.Object)
 [java]   Type information in locals-table is inconsistent. Cannot constrain type: INT for value: v44 by constraint OBJECT.
 [java]   java.lang.Object com.google.youngandroid.runtime.textDeobfuscate(java.lang.Object, java.lang.Object)
 [java]   Attempt to define local of type reference as c:int
 [java] Info: Some warnings are typically a sign of using an outdated Java toolchain. To fix, recompile the source with an updated toolchain.
 [java] [RunD8] Task succeeded in 41.647 seconds'

Build machine

Windows OS
JDK 11
Cmd via Powershell

This is fine as it's just due to the version of Kawa we use. It arranges the class file content differently than what D8 expects but things work just fine.


Legends are broken in latest Obsidian

Using Obsidian v0.14.6 and Tracker 1.10.9, loading the examples from the repo, the legends for line charts all say "untitledX"

Thanks for the report. Will check it.


Request to add DR-HCF001

Model - DR-HCF001
Number of speeds the fan supports 12
Does the fan support oscillating - no
What preset modes are supported
Fan: normal,  sleep, natural,  auto
Light: Dimmer, color temperature 2700 - 6700
Is temperature supported? No

Duplicate of #86


add new red black tree

I think you want to push your changes to the master branch. You accidentally chose add-contributing branch which is now not needed. Please open another PR and be sure to merge with the master branch.

I also see that your fork is some commits behind the original. @shanyuk see this link to update your fork if you need help https://stackoverflow.com/questions/7244321/how-do-i-update-a-github-forked-repository

Closing this PR for now.

refer to #155


diagnose creates samples.csv file

[ ] remove output of samples.csv file for diagnose mode

Not sure if this should be an issue, but there was no response on stan-dev, so I'm recording it here

Can this be closed?


fix: add pool_options to options()

The pool_options field is missing in the options() type.
timeout is a valid pool_option(), see https://github.com/erleans/pgo/blob/master/src/pgo.erl#L95.

Hm, it looks like CI isn't running.

Hm, it looks like CI isn't running.

Have you enabled your ci workflow to run on forked PRs? It's not enabled by default, see https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories.

Just merged a PR that fixed this. Thanks!


wip: template component support

Simple support for rendering component.
Implementation can be better, still work in progress.

I don't know why but I cannot re-open the PR. It will be closed immediately. I have no idea about this.

It seems I can't specify core-vapor from the branch I created before.
I'll try creating a sub-branch directly under core-vapor :D

Actually, @Ubugeeei has write access to this repo and can push your branch directly without a fork.

Yes, that method worked well :D


Correction for raw affiliation AGIR Research Unit, UR UPJV 4294, Jules Verne University of Picardie, Amiens, France; Department of Infectious Diseases, Amiens University Hospital, Amiens, France

Correction needed for raw affiliation AGIR Research Unit, UR UPJV 4294, Jules Verne University of Picardie, Amiens, France; Department of Infectious Diseases, Amiens University Hospital, Amiens, France
raw_affiliation_name: AGIR Research Unit, UR UPJV 4294, Jules Verne University of Picardie, Amiens, France; Department of Infectious Diseases, Amiens University Hospital, Amiens, France
new_rors: 01gyxrk03;010567a58
previous_rors: 01sjmsj73;01gyxrk03;010567a58
works_examples: W4200488354
contact: f9c9c8718573afc8da9673018660d624:bf43b79e4cc0fa17f8568d6bfe8fffdc @ u-picardie.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Eliminate Animations.

What's the Problem?
I've said it before and I'll say it again because I keep coming back on this app and I just can't stick to it because of some issues that make it feel really slow. One of the reasons is the animations. There are animation everywhere, but the worst one is when you click a tab, it takes a full second till it changes tab. All these rollover animations and on press, are really not worth it IMO.
I want files to be as responsive as possible since the main reason I am using it is to de-clutter my desktop when I work that I usually have like 10 windows open at the same time.
Solution/Idea
The idea here is simple in though, but not sure if it's simple in coding terms.
An option to remove or make the animations faster kinda like Android developer mode options.
Alternatives
The alternative here, is that I'm always end up going back to the default file explorer because even though I LOVE files, these "issues" are making it not worth it to use in daily basis, it feels fragile sometimes.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
No response
Windows Version
No response
Comments
No response

There are very little animations and many slow downs are proberly from the app iteself witch is beeing improved with #4180 but is limited currently. You can go to Windows settings > ease of access/Acssesability > turn off windows animations, then restart files and see if it improved for you.

Thanks for your reply.
Animations are turned off but that doesn't change anything in Files app. There's still noticeable lag when changing from one tab to another and the animations when clicking a folder/file are still there and for me, it makes the experience way slower than it should be.

I suppose you're on windows 10? Animations when clicking the list are system-made and can't be removed (without degrading performance). Good news is that they are not present anymore on windows 11.


Improve java OOP topics

I have updated the Java OOP topics that were previously added with improved examples and information.

I have updated the Java OOP topics that were previously added with improved examples and information.

LGTM


[Bug] Focus dialog after using a shortcut to stop recording

Currently, when using a shortcut to stop recording, the "Discard Project" dialog won't be focused, although the "No" button seems to be focused, in fact, it's not, therefore using arrow keys to switch option is not available:

Meanwhile, clicking the "stop recording" button will focus the "Discard Project" dialog:

For accessibility, it'd be great to unify this behavior and to generalize this issue, all dialogs might be checked.

Thanks.
Looks like something is stealing the focus when the dialog is opening (or perhaps the dialog needs a force focus to activate properly).

@NickeManarin If you haven't started working on this, I can have a look at this one.

It looks like the issue is that the Window is shown but not Activated. When done the same by mouse click - activates it. Did some initial testing and calling Activate not always works. What works is showing the editor before showing the dialog. I'll test this solution more to see if there aren't any unwanted behavior.

@NickeManarin @pawlos Just tried v2.33.1, still reproducible, could you please consider reopening this issue?

I can't but @NickeManarin can reopen.

It's working normally for me.
Pressing F8 to stop the recording still gives the focus to the dialog that asks about discarding the previous project.
Can you record your screen to show to us?
Or can you give us a step-by-step guide on how to get the same issue?

@NickeManarin @pawlos
https://user-images.githubusercontent.com/28700378/127501006-fd7f506b-5b34-463f-a16f-7527ad7073e8.mp4

@NickeManarin @pawlos
Steps:

Click "Record".
Click the screen being recorded (important, otherwise will return focus to the dialog).
Hit F8.

@wenfangdu thx for the steps. I'll get back to this issue.


Does not work with Picture element ie11

Maybe am doing something wrong, but it doesn't seem to work with the html5 picture element in IE11. However it does work with the standard polyfill Picturefill https://cdn.rawgit.com/scottjehl/picturefill/3.0.2/dist/picturefill.min.js
Here is my sample https://codepen.io/rgfx/pen/GQLgNP

@rgfx Same problem here. Do you also get an error in the JavaScript console of Internet Explorer 11?

I just hope this is resolved soon... Thanks!


[Chore] Publish releases

Hi Frank - love the package. In working on a PR, it was difficult to determine what the current release was, since it doesn't appear they've been made "releases" in the GitHub UI since 1.0.0. Could you publish them as such to make the current release (and release history) appear consistently? Thanks.

@frankdejonge Friendly ping on this... the front page still shows 1.0.0 as the "release"? I think the only thing required here is for tags to have a label?

I've configured auto-releases, that should help, starting from the next release: https://github.com/EventSaucePHP/ObjectHydrator/commit/366af189cd45d8474f08e3d55e0c932508c5a80a

Sweet!


Update sbt-ci-release to 1.5.6

Updates com.geirsson:sbt-ci-release from 1.5.5 to 1.5.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.5.5).
You might want to review and update them manually.
scripts/broker-00.xml

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.geirsson", artifactId = "sbt-ci-release" } ]

labels: sbt-plugin-update, semver-patch, old-version-remains

Superseded by #142.


tour step-trigger with controller scope

How do you trigger $tour.start with a controller scope? I need to do something like the following coffeescript:
if !$scope.is_setup
    $tour.start

I've tried several variations including:
$scope.start = $tour.start
if !$scope.is_setup
    $scope.start = true

and setting a step-trigger on the element
<div ....step-trigger="start">hello</div>

if !$scope.is_setup
    $scope.start = true

But nothing seems to work. It only works by manually clicking a button:
<button ng-click="start()">Button</button>
$scope.start = $tour.start

For some reason calling $tour.start in the controller doesn't work. I had to extend the setCurrentStep function to trigger $tour in the controller:
this.startTour = function (step) {
    currentIndex = step;
    storeCurrentStep();
}

controller:
if !$scope.is_setup
    $tour.startTour(1)


failed to make payment, bitcoins dissapeard

Background
Yesterday I tried to make a payment over the lighting network. I have made successful payments before. I will enter what I did below.
lncli channelbalance
{
"balance": "414323",
"pending_open_balance": "0"
}
lncli decodepayreq lnbc2357510n1pd3kpdfpp54meuf89hwgqsxde2u37v77z4gp6ll7w20uw0hx4gmly233adhggqdzdxysv89eqgf5hgcm0d9hzqnrfva58gmnfdenjqnn9w3mk7untyp2z65mgd9e8ggpdyp8xzane9ssyccqzysk0d2ks4fxem0svyq03vah9syex7duhm8us4pfdhlrc8fghfef5yr968hpxf538pgve9c2tqrtpgm9dt6k326nur94wgullu9pg9ftuqqq4s5vs
{
"destination": "039376f846cb4e137f3474baa7fbe74ec627745c7d5c54935b99fbb1b60a62c9b3",
"payment_hash": "aef3c49cb7720103372ae47ccf78554075fff9ca7f1cfb9aa8dfc8a8c7adba10",
"num_satoshis": "235751",
"timestamp": "1528497577",
"expiry": "3600",
"description": "1 × Bitcoin Lightning Network T-Shirt - Navy, L",
"description_hash": "",
"fallback_addr": "",
"cltv_expiry": "144",
"route_hints": [
]
}
lncli payinvoice lnbc2357510n1pd3kpdfpp54meuf89hwgqsxde2u37v77z4gp6ll7w20uw0hx4gmly233adhggqdzdxysv89eqgf5hgcm0d9hzqnrfva58gmnfdenjqnn9w3mk7untyp2z65mgd9e8ggpdyp8xzane9ssyccqzysk0d2ks4fxem0svyq03vah9syex7duhm8us4pfdhlrc8fghfef5yr968hpxf538pgve9c2tqrtpgm9dt6k326nur94wgullu9pg9ftuqqq4s5vs
--at this point it seemed to hang no response was given. I went over to a new tab to check my channel balance
lncli channelbalance
{
"balance": "178354",
"pending_open_balance": "0"
}
-- You can see my amount of satoshis came out of the channel but the payment did not clear from the recipient. I have tried restarting my node and lnd and everything seems to be working fine other than the btc from the failed payment never came back. I was given this error message below after restarting node & lnd
lncli channelbalance
{
"payment_error": "htlc switch have been stopped while waiting for payment result",
"payment_preimage": "",
"payment_route": null
}
Virtualbox running linuxmint

version of lnd
lncli version 0.4.1 commit=524291dadaf39bfbd99efb6654beb6030b3e285e
which operating system (uname -a on *Nix)
linux mint 18.3 cinnamon  running on virtualbox 5.2.6
version of btcd, bitcoind, or other backend
0.16.0
any other relevant environment details

Steps to reproduce
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
--let me know if you need anything else, thanks in advance :)

I believe I had similar issue few days ago. lncli payinvoice would stuck for hours, doing nothing. I needed to kill it eventually. I do not actually know if my coins dissapeard tho.

Your coins aren't gone, there may be some nodes on the network that are running a newer version of lnd where some regressions have popped up that can introduce a deadlock at times. If you look at listchannels, the HTLC will be pending if it somehow targeted a node in this state. If you restarted and the node then cancelled back this payment, then the coins are still pending.

Ok, but what about lncli payinvoice being stuck for hours? At least in my case.
@Cryptoknut Did your lncli payinvoice eventually finished, or you did cancel it by Ctrl-C or something?


Gate parameter types depend on transpiler

Information

Qiskit Terra version: master
Python version:
Operating system:

What is the current behavior?
Consider the following circuit:

def qft(n):
    """Creates an n-qubit QFT circuit"""
    circuit = QuantumCircuit(n)
    def swap_registers(circuit, n):
        for qubit in range(n//2):
            circuit.swap(qubit, n-qubit-1)
        return circuit
    def qft_rotations(circuit, n):
        """Performs qft on the first n qubits in circuit (without swaps)"""
        if n == 0:
            return circuit
        n -= 1
        circuit.h(n)
        for qubit in range(n):
            circuit.cu1(np.pi/2**(n-qubit), qubit, n)
        qft_rotations(circuit, n)

    qft_rotations(circuit, n)
    swap_registers(circuit, n)
    return circuit

phi_true, t = -5/16, 4
#phi_true, t = 11/16, 4

# building a circuit
qpe_circ = QuantumCircuit(t+1,t)
qpe_circ.h(range(t))
qpe_circ.x(t)
for idx in range(t):
    qpe_circ.cp(2*np.pi*(phi_true*2**idx), idx, t)

qft_dag = qft(t).to_gate().inverse()
qft_dag.label = 'QFT+'

qpe_circ.append(qft_dag, range(t))
qpe_circ.measure(range(t), range(t))

Upon transpiling it gives some parameters that are of type ParameterExpression, e.g.
[ParameterExpression(-0.981747704246810)]

However, taking this transpiled circuit, converting it to a QASM string, and then making a new circuit yields a standard float type:
[-0.9817477042468103]

Therefore the exact same circuit can have different types depending on whether it is directly output from the transpiler.  This seems wrong to me and when dealing with circuit data means that one must type check every parameter.
Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

I was not able to observe this. Perhaps it's been resolved. Closing. Please feel free to reopen if you notice it again.

I was not able to observe this. Perhaps it's been resolved. Closing. Please feel free to reopen if you notice it again.


Sample points from meshes keeping node labels

❓ Questions & Help
Hi, I am working on a custom InMemoryDataset which I based on the FAUST example for meshes. However, in my dataset each vertex in the mesh has a class label for segmentation.
When transforming the mesh to point cloud by using the SamplePoints, I was not able to retain the label information corresponding to the sampled points anymore.
I ended up just inserting one line in the SamplePoints transformation to retain these labels:
if self.remove_faces:
        data.face = None

# all pos of a face have the same label (we take the first vertex of all faces here)
data.y = data.y[face[0]]

return data

This seems to work, but is there a better way of doing this?

I think we could optionally return the face_index for each sampled point. What do you think? You could then do data.y = data.y[data.face_index[data.face[0]] to map any vertex feature to a point feature.

That's okay, in my case the vertices of a face have the same label as that face. I want to "propagate" these face labels to the sampled points from that face.
For a general solution, having access to the face_index of each sampled point would probably be a good idea.


can you provide a sample jekyll site with lunr search integrated?

Can you create a sample jekyll site with a plain integration of lunr search using the pre-built plugin method rather than the rubygem installation method? I had a hard time following the instructions but feel if i had example code, I could figure it out. If I could download the sample site, that would be perfect.

I saved my integration here. Hope this helps.

Awesome! Thanks. This was really helpful. I plugged it into a vanilla jekyll site, added the search.min.js file, the plugin files, and it worked. Here's a sample working jekyll site in case anyone wants to download a working sample: sample jekyll site with lunr integrated.

For some reason I'm getting a warning about the version when I build jekyll: "warning: already initialized constant Jekyll::LunrJsSearch::VERSION." Here's the full context of the error:
johnson-mbpr13:resolvev3 tjohnson$ jekyll serve

Configuration file: /Users/tjohnson/projects/resolvev3/_config.yml
/Users/tjohnson/projects/resolvev3/_plugins/jekyll_lunr_js_search/version.rb:3: warning: already initialized constant Jekyll::LunrJsSearch::VERSION
/Users/tjohnson/.rvm/gems/ruby-2.0.0-p481/gems/jekyll-lunr-js-search-0.2.1/lib/jekyll_lunr_js_search/version.rb:3: warning: previous definition of VERSION was here
Source: /Users/tjohnson/projects/resolvev3
Destination: /Users/tjohnson/projects/resolvev3/_site
Generating...
Lunr: Creating search index...
Lunr: Index ready (lunr.js v0.4.5)
done.
Auto-regeneration: enabled for '/Users/tjohnson/projects/resolvev3'
Configuration file: /Users/tjohnson/projects/resolvev3/_config.yml
Server address: http://<IP_ADDRESS>:4000/
Server running... press ctrl-c to stop.
The site still builds, but I'd like to resolve this error. Can you help?

I found it only worked locally. when I upload the code to github. It can't work on github server

@samuel1208 Jekyll plugins don't work in Github so you cannot use this plugin for GitHub pages, unless you also push up the locally generated search index.

@slashdotdash  where should I push the search index to?  Could you tell me how to config it ?

@slashdotdash Thanks for your advice. I push the search.index to github.page . It works now


[github-actions] limit some workflows to upstream repo

This limits the following workflows to the upstream repo as the workflows are not useful for forks of this repo

CLA Assistant
GitlabSync
doxygen-publish

This change also modifies the windows workflow so that only the required submodules are initialized

I have read the CLA Document and I hereby sign the CLA

recheck

recheck

recheck

@WAvdBeek Please take a look at this when you get a chance. Thanks!