Makefile: Add an install target for runtime binary

We were missing an install target, add this.
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

Coverage remained the same at 34.96% when pulling fce1055f92468ba4c349d86c174adffd18d23b89 on amshinde:add-install-target into 938ef631c7dfbc3f3df8c46ff9133cd891c2a8d6 on clearcontainers:master.

@amshinde @dlespiau This patch is already part of this PR https://github.com/clearcontainers/runtime/pull/89

@sboeuf  I'll close this then.


Exit button disappears from gallery mode

The exit button in gallery mode does not reappear when coming back from the comments. There’s then no way to get out of it.

Good catch.

Fixed!


Feature/grab bag

Tackle a grab-bag of documentation issues.

[x] Check that you pass the basic compilation and unit tests by running grunt

Coverage decreased (-0.02%) to 8.111% when pulling e314752fec78b1781775014de76057321362162a on feature/grab-bag into 64b4633f1aefd342c47a6f1201facbb9a6caabeb on develop.


Google IO Extended Port Harcourt 2023

Event Details: here
Registration link: here (login to rsvp)

@kaf-lamed-beyt  I'm picking this up, kindly assign it to me

Ayy! I'm assigning you now.


Make our own AssetLib host/proxy that provides v-sekai addons as well.

Proposal for "path string" to "path string".
Addons "packed store" + Processing pipeline

This is still relevant.

Duplicate of https://github.com/V-Sekai/V-Sekai.github.io/issues/356.


Add New button visible for users without permissions

The "Add New" buttom appears when user has no permissions.
Superset shows the "Add New" button for users without permissions.
Expected results
Visible if the user has permissions on one or more options
Actual results
User clicks and gets back to main page
Screenshots

How to reproduce the bug

Create a user without any permissions
Log in superset

Environment
(please complete the following information):

superset version: Superset 0.999.0dev
python version: Python 3.7.2
node.js version: v10.15.0
npm version: 6.4.1

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[*] I have reproduced the issue with at least the latest released version of superset.
[*] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I think this feature is really needed


Add .indexIntervals(), .mode(), .variance(), and .stdDev() methods.

The former-most is for the Iterable extension, whereas the latter three are for the Iterable<num> extension. Tests have been provided for all three. I've adhered to the formatting guidelines from analysis_options.yaml, but you're welcome to reformat/tweak my code as necessary.

I have absolutely no idea why dartfmt failed. It looks like all the checks aside from that passed.

I have absolutely no idea why dartfmt failed. It looks like all the checks aside from that passed.

@leisim Have you checked this?

@leisim Have you checked this?

I actually forgot I filed this. The other maintainer is @passsy, if one of you could review it that would be great.

I actually forgot I filed this. The other maintainer is @passsy, if one of you could review it that would be great.


LILYGO T-Beam 1.2 with new PMU AXP2101

I bought a T-Beam 1.2 with AXP2101. When compiling with VisualStudioCode, however, I get the warning that firmware.map is not found and therefore the error message:
“collect2.exe: error: ld returned 1 exit status
*** [.pio\build\ttgo-t-beam-v1_2\firmware.elf] Error 1”.
The board is in the list of supported devices. What could I have done wrong? I can flash other FW without errors.

Please let me know which OS do you have? which version of platformio do you have? have you imported it or just opened it?
did you try just flashing with the webflasher?

Thanks for pointing out the Webflasher. I found it and was able to install the firmware with it.
But it does not work with VisualStudioCode. I have Windows 11 and the PlatformIO IDE v3.3.3. I have tried both options. It does not work with import and also not with open folder.

Thanks for pointing out the Webflasher. I found it and was able to install the firmware with it. But it does not work with VisualStudioCode. I have Windows 11 and the PlatformIO IDE v3.3.3. I have tried both options. It does not work with import and also not with open folder.

I guess this is a local issue with the opening or importing projects. Here it runs good ;)
glad you could install it with webflasher


Add timezone support for API and web app

I added the timezone support to facilitated CI implementation of your API.
By providing the TZ query parameter you can easily override the timezone.
If there is no parameter, I choose to use UTC, as the default timezone.
I also added to your UI, a small timezone selector. :)

Great! I will assign some hours this week to review this
Thanks!

Any news on validating this PR ?

Looking good! Can you rebase your branch? I will add some small tweaks on the UI later today after merging


chore(deps): update dependencies

Update the following dependencies:

wasmtime
wasmtime-provider (used by wapc)
policy-sdk-rust
chrono: no update, but disable default features. This avoids the usage of the old and vulnerable time 0.1 crate

I prefer to wait a little before tagging a new version of policy-evaluator. I see the time 0.1 being pulled in, I still have to figure out who is doing that :angry:


Some chat updates

Added a rate limiter of 6 messages every 60s to help prevent spam
Fixed some scrolling issues

Haven't seen this until now, will likely merge this in soon


Update codecov version in GH Actions

This PR updates the codecov upload action to the current version of the action.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@28639af). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             develop      #74   +/-   ##
==========================================
  Coverage           ?   56.10%
==========================================
  Files              ?       21
  Lines              ?     3251
  Branches           ?      615
==========================================
  Hits               ?     1824
  Misses             ?     1339
  Partials           ?       88

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Multi bench

There is still some endpoint validation to do when using multi-benchmark (making sure clients & servers match), but I think that can wait for another PR

This appears to be spewing a lot of errors/warnings where it did not before:
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.
Use of uninitialized value $benchmark in string eq at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 271.

Sourcing container image for userenv 'alma8'; this may take a few minutes
Use of uninitialized value $real_path in string ne at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 405.
Use of uninitialized value $real_path in sprintf at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 406.
Use of uninitialized value $dumped_file in -f at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 410.
Use of uninitialized value $dumped_file in -d at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 412.
Use of uninitialized value $real_path in string ne at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 405.
Use of uninitialized value $real_path in sprintf at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 406.
Use of uninitialized value $dumped_file in -f at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 410.
Use of uninitialized value $dumped_file in -d at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 412.

Processing stage 8 (3adf576747454c4d7cb3cbb049d8db20)...
Use of uninitialized value $real_path in string ne at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 405.
Use of uninitialized value $real_path in sprintf at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 406.
Use of uninitialized value $dumped_file in -f at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 410.
Use of uninitialized value $dumped_file in -d at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 412.
Use of uninitialized value $real_path in string ne at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 405.
Use of uninitialized value $real_path in sprintf at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 406.
Use of uninitialized value $dumped_file in -f at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 410.
Use of uninitialized value $dumped_file in -d at /opt/crucible/subprojects/core/rickshaw/rickshaw-run line 412.

And then just flat breaking:
Workshop build failed: rc=37
Workshop build command: /opt/crucible/subprojects/core/workshop/workshop.pl --log-level verbose  --config /var/lib/crucible/run/trafficgen--2022-09-14_21:43:25_UTC--45060943-4b89-47f1-b044-1752e99716fc/config
/cs-conf.json --param %engine-dir%=/opt/crucible/repos/https:github.com:perftool-incubator/rickshaw/engine/ --param %rickshaw-dir%=/opt/crucible/repos/https:github.com:perftool-incubator/rickshaw --reg-tls-verify=true 2>&1 --skip-update true
 --userenv /var/lib/crucible/run/trafficgen--2022-09-14_21:43:25_UTC--45060943-4b89-47f1-b044-1752e99716fc/config/userenv-493de27385fa6670a696c2e5f12aa517.json --requirement /opt/crucible/subprojects/benchmarks/trafficgen/workshop.json --proj
 quay.io/crucible --label client-server --tag 3adf576747454c4d7cb3cbb049d8db20
Workshop build output:
...
[ERROR] ################################################################################
[ERROR] COMMAND:         buildah add quay.io/crucible/client-server:3adf576747454c4d7cb3cbb049d8db20 %bench-dir%/trafficgen/install-trex.sh /usr/bin 2>&1
[ERROR] RETURN CODE:     125
[ERROR] COMMAND OUTPUT:
[ERROR]
[ERROR] error adding content to container "quay.io/crucible/client-server:3adf576747454c4d7cb3cbb049d8db20": checking on sources under "/": copier: stat: "/root/mv-params/trafficgen/%bench-dir%/trafficgen/ins
tall-trex.sh": no such file or directory
[ERROR]
[ERROR] ********************************************************************************
[ERROR] Failed to copy '%bench-dir%/trafficgen/install-trex.sh' to the temporary container!

I suspect you might see some similar errors in the oslat CI jobs because it has this:
https://github.com/perftool-incubator/bench-oslat/blob/master/workshop.json#L49-L73


Update Gimmer (GMR) icon

Hi Delta team,
Please update our icon for Gimmer (GMR) on Delta App please.
You can find it attached, thanks!
gimmer-icon-delta.zip

Hi there,
Just checking, any issue with this update? Do we need to do something?
Just wondering if there's an ETA for this update?
Thanks!

I managed to extract a vectorized version of their logo from their whitepaper: gimmer-icon.svg.zip


Windows + non ascii symbols in filename path: not possible to open fits file

Fits error: FitsError { status: 104, message: "could not open the named file" }
Any ideas how to fix it?

Hi, thanks for the report. Do you have an example filename?
Because we use a c library to do the heavy lifting, we may struggle. I'm not at my computer right now but I'll check when I can.
There might be a way to open a file from a.file descriptor that we can use.

I thought the issue might've been because the specified filename isn't valid UTF-8, and (to my knowledge) the only way to convert an AsRef<Path> to a CString is with a valid UTF-8 filename.
https://github.com/simonrw/rust-fitsio/blob/1a2c4589ac223581a89663bfb0c15ba99b56cd77/fitsio/src/fitsfile.rs#L52-L59
... but that would've triggered the except in that code block.  @art-den can you give the file name you tried to use?  These error messages are pretty poor but the issue may be as simple as what's said on the tin.

Examples:
D:\test\Путь\HA_dzX2_KS_D_eco.fits
D:\test\Path\Имя_файла.fits

So it's not the non-ascii characters in the filenames - I've tested with Имя_файла.fits and it opens just fine in cfitsio and this crate. I suspect it's something to do with windows absolute paths, but I have recently deleted my windows VM so it might be a while before I can test.
@art-den can you try using relative paths (e.g. ..\Имя_файла.fits) to see if that still works?

Right: my windows VM still exists, and it cfitsio (the c library) struggles to open Имя_файла.fits after all. cfitsio expects the filename to be a char* (equivalent to rust u8) and does not seem to be doing any sort of unicode handling. In fact there's no mention of the word "unicode" in the cfitsio source code at all.
Windows unicode is utf-16 which is not what Rust or C expect at all. I will bow to someone with more windows experience than me but a workaround is to save files with ascii filenames for now.

Astrophotography software saves fits files into user's folders like C:\Users\<user name>\Desktop\SharpCap Captures (or something else) by default. And  can contains not only ascii characters ((
I will try to set default folder to C:\Users\<user name>\Desktop\SharpCap Captures and to open fits file by short file name (without full path). It will not solve problem with non-ascii in short file name but I think this is very rare situation.

I can't immediately think of a way around this. I recognise that the software has no control over the username of the user, but I think there would be a problem with cfitsio as well so we're not adding any problems here.
It's not ideal, but I don't understand enough about windows paths and non-ascii characters. Is this something that you can live with? Also: could you map the  path to e.g. Z:\ so it does not contain the username?

My heavyweight solution to the problem ))
#[cfg(target_os = "windows")]
mod win_fits_open {
    use std::{sync::Mutex, path::PathBuf};

    pub static OPEN_FITS_MUTEX: Mutex<()> = Mutex::new(());

    pub struct CurDirRestore {
        cur_dir: PathBuf,
    }

    impl CurDirRestore {
        pub fn new() -> anyhow::Result<Self> {
            Ok(Self {
                cur_dir: std::env::current_dir()?,
            })
        }
    }

    impl Drop for CurDirRestore {
        fn drop(&mut self) {
            _ = std::env::set_current_dir(&self.cur_dir);
        }
    }
}

#[cfg(target_os = "windows")]
fn fits_file_open_helper<F>(file_name: &Path, fun: F) -> anyhow::Result<FitsFile>
where F: Fn(&Path) -> anyhow::Result<FitsFile> {
    use win_fits_open::*;
    let result = match (file_name.parent(), file_name.file_name()) {
        (Some(file_dir), Some(rel_name)) => {
            let change_dir_locker = OPEN_FITS_MUTEX.lock();
            let cur_dir_restore = CurDirRestore::new()?;
            std::env::set_current_dir(file_dir)?;
            let rel_name = rel_name.to_str().unwrap_or("");
            let fits = fun(&Path::new(rel_name))?;
            drop(cur_dir_restore);
            drop(change_dir_locker);
            fits
        },
        _ =>
            fun(file_name)?,
    };
    Ok(result)
}

#[cfg(not(target_os = "windows"))]
fn fits_file_open_helper<F>(file_name: &Path, fun: F) -> anyhow::Result<FitsFile>
where F: Fn(&Path) -> anyhow::Result<FitsFile> {
    fun(file_name)
}

//////////////////////////////////////////////////

// using this

let mut fptr = fits_file_open_helper(
    file_name,
    |file_name| Ok(FitsFile::open(file_name)?)
)?;

// or

let mut fptr = fits_file_open_helper(
    file_name,
    |file_name| {
        Ok(FitsFile::create(file_name)
            .with_custom_primary(&image_description)
            .open()?)
    }
)?;

I'm sorry you have to work around this in this way, but that seems reasonable since cfitsio doesn't support non-ascii filenames :facepalm:
In general - are you happy that this fixes your problem going forwards? If so I will close this issue (and it will remain forever as documentation for others), otherwise I'll leave this open and we can consider a "proper" fix

It looks like this is issue of msys2 (and libfitsio also). My workaround fixes most common problem. So i'm happy ))


x/build/cmd/gomote: install builder dependencies by default

The gomote instances should have all the dependencies installed by default upon creation. This will increase the amount of time a gomote creation takes. The resulting machine will match the environment where tests are executed.
@golang/release

This is resolved as of CL 569875. (It didn't get closed automatically because the Fixes line didn't specify the golang/go repo quite right.)


name unicode not defined

One of the joys of writing a package that works for python2 and python3 is handling the different string / binary types... fixed in 41a9c85e77dd59cbf0a22dee252e10ba55ecfe25.

yeah; just drop P2 support and/or have people pay you for it; at this stage everyone using P2 does it because they can't be bothered to port their legacy code base to P3, so they might as well pay for the privilege of having up to date libraries...

I'll support python2 until it's EOL, only a couple more months, after that releases will be only python3 compatible.


Queue management from 1.0.0 to 1.1.0 versions

Good morning!
I noticed you have changed (in rest server) , queue request  management from 1.0.0 to 1.1.0, adding in the last one python queues. I would like to know how is the request management within rest server in version 1.0.0. As I could have look is the operative system in charge of this task ? Could you explain more in detail ?
Thanks in advance.

Hey @alvarorsant ,
Just to make sure I understand, are you referring to the queue used to feed requests into the parallel worker pool?
If that's the case, previously we were using the ProcessPoolExecutor, which is part of the standard library. However, under the hood, it also uses regular Python queues (you can check the actual implementation here: https://github.com/python/cpython/blob/3.10/Lib/concurrent/futures/process.py).
In MLServer 1.1.0, we got rid of the ProcessPoolExecutor and instead created our own management layer. Main reason for this change was that we wanted to move from having a separate pool per model, to having a shared pool where all models are loaded. Since we then had a shared pool, we also needed to take care of loading / unload the right models dynamically on those workers, therefore ProcessPoolExecutor just wasn't enough for our needs.
The overall mechanics of both ProcessPoolExecutor and our new InferencePool implementation should be quite similar when it comes to request management though. As in, on both cases you have a Queue object used to communicate request payloads between the main and children processes.
Also, for full context, the main motivation to move to a shared pool was to reduce the memory overhead that each pool was introducing. Previously we were seeing massive increases on memory usage each time a new model was loaded. This was mainly due to the overhead caused by initialising that model's own pool (through ProcessPoolExecutor). After moving to a single shared pool, this extra memory usage has massively reduced.


Self in function body error message

def foo() -> void:
    x = self
    return

Expected result: error saying 'self' cannot be used here
Actual result: compiler error in file "asd.jou", line 2: no variable named 'self'
Even though self can be thought of as just a variable, the error message for using it in the wrong place should be very clear.

Related: #246


CLI issues on windows

CLI commands that are interactive (ex. prelude build create-variant) just hang instead of showing the expected prompts (what platform do you want, etc)
Was on windows_x86-64

Cannot reproduce on my Windows 11 box. Were you using a VM?

Which version of windows is it running?

ooh actually it works in cmd and powershell. It only hangs in Powershell ISE, which is weird, but probably not important for us to figure out
Closing


Improve AWS AlarmControllerRecover template

The template and params generated by kube-aws assumes the use of the aws partition.  aws is not the only legal partition.  For example, government cloud is aws-us-gov.
The template would be more flexible if kube-aws made the partition configurable.
The only place the existing template encounters this issue is in the configuration for AlarmControllerRecover.
This hard-coded use of aws,
arn:aws:automate: ...
for gov cloud users, needs to be,
arn:aws-us-gov:automate: ...
"AlarmControllerRecover": {
            "Properties": {
                "AlarmActions": ["arn:aws:automate:us-gov-west-1:ec2:recover"],
                "AlarmDescription": "Trigger a recovery when system check fails for 5 consecutive minutes.",
                "ComparisonOperator": "GreaterThanThreshold",
                "Dimensions": [
                    {
                        "Name": "InstanceId",
                        "Value": {
                            "Ref": "InstanceController"
                        }
                    }
                ],
                "EvaluationPeriods": "5",
                "MetricName": "StatusCheckFailed_System",
                "Namespace": "AWS/EC2",
                "Period": "60",
                "Statistic": "Minimum",
                "Threshold": "0"
            },
            "Type": "AWS::CloudWatch::Alarm"
        },

So I got it to work.
Turns out that the hard coded arn:aws:... is the problem.
The required arn expression is
"arn:aws-us-gov:automate:us-gov-west-1:ec2:recover"
So it looks like element 1 of the arn needs to be a templated value. so users can choose aws or aws-us-gov

@kastork would you be willing to do a PR for this?

@colhom I'm very new to using CloudFormation, so it might take me a while, but yes I'm willing.

The kube-aws tool has been moved to its own top-level directory @ https://github.com/coreos/kube-aws
If this issue still needs to be addressed, please re-open the issue under the new repository.


Initial Java support added

Added SWIG target for Java and a simplest example. To build, set JAVA_HOME to the java root path and cmake -D BUILDSWIGJAVA=ON

You need to sign off all your commits - not just the first one :)


Help us be assured that our idea of "up" is the same as iD's, and not opposite

Here we are editing an incline,

And no matter if we choose "up" or "down", nothing changes about the road display to help us be assured that our idea of "up" is the same as iD's, and not opposite.
For instance, the little triangles on the road could switch direction or something.
OK, maybe we are supposed to look at the direction of the triangle arrows, and report if they are going in the downward direction, as here.

The little triangles show the editing direction of the line. To show incline we would need another element, I am not sure if we really need that.

OK, checking
https://wiki.openstreetmap.org/wiki/Key:incline
and
https://wiki.openstreetmap.org/wiki/Forward_%26_backward,_left_%26_right
I am able to determine if indeed I want to say "up" or "down".
However with
https://wiki.openstreetmap.org/wiki/Tag:barrier%3Dretaining_wall
iD adds some helpful bonus slope arrows.
So maybe the same could be done when editing an Incline.

This is a duplicate of #6991.


Interesting research into your "disparity circle" formula along with a new, smoother one

I was chatting in my Discord with Aphitorite on GitHub, and they actually dug into your "disparity curve" formula a bit. Some interesting stuff was discovered, and we wanted to share it with you!
So first of all, we were talking about my modified version of your formula from my fork that's able to handle arbitrary array lengths, which is the following:
double len = ((ArrayVisualizer.getCurrentLength() / 2d) - Math.min(Math.min(Math.abs(i - array[i]), Math.abs(i - array[i] + ArrayVisualizer.getCurrentLength())), Math.abs(i - array[i] - ArrayVisualizer.getCurrentLength()))) / (ArrayVisualizer.getCurrentLength() / 2d);

Yeah, I know... I didn't refactor it after changing it around, and the line of code it takes up is an absolute mess. But it turns out that you had written up a partial triangle wave function (without using trig functions)!
https://cdn.discordapp.com/attachments/592103638034415647/733325936417570926/SharedScreenshot.jpg
That's why the peaks of the disparity circle visual are always jagged! You can especially see that here:
Your original formula:
https://cdn.discordapp.com/attachments/592103638034415647/733197874434932807/Screenshot_516.png
versus Aphitorite's new sine wave formula:
https://cdn.discordapp.com/attachments/592103638034415647/733197892264656946/Screenshot_515.png
Their new sine wave formula is as follows:
double len = 2 * Math.abs(Math.abs(array[i] - i) - ArrayVisualizer.getCurrentLength() * 0.5) / ArrayVisualizer.getCurrentLength();

I personally found this super fascinating; hope this was interesting for you too!

Update: Aphitorite cleaned up the original formula (triangle wave) as well...
double len = 2 * Math.abs(Math.abs(array[i] - i) - ArrayVisualizer.getCurrentLength() * 0.5) / ArrayVisualizer.getCurrentLength();


Compatibility with Python 3.6

Best library of this kind, but had a hell of a time setting it up in a virtual environment.
Why ?

Ubuntu 16 and 18 comes by default with Python 3.6 installed.
Docker tensorflow/tensorflow images come with Python 3.6.

Workaround ?

Unfortunately, no. I tried ignoring Python version error at installation but resulted in the library stopping altogether. It crashed when called time.perf_counter_ns() as this is present from python 3.7 and above.

Tried using a custom built docker image* and even building one from scratch but resulted in other massive overhead on my end.

Contribution
At the moment I am unable to highlight exactly what needs to be changed besides what I mentioned earlier but if needed I can help find a solution.
Benefits
Greater compatibility with older and more stable versions of python and also with other environments such as the one I'm trying to use.

Hey @dariemihai95, i have tested this library in MacOS and Windows on Python3.7 & Python3.8, although yet to try out for the older versions of Python as you mentioned. Will be fixed by the next release most probably. Can you please elaborate on what did you mean in your second comment in the Workaround, regarding Tried using a custom built tensorflow...

@ag-ds-bubble had a mistake there, what I meant was a custom docker image. Corrected it. Thank you for pointing out.
Tested it on Ubuntu 20.04 with python 3.8 and in docker with an image based on ubuntu 18 with python 3.6 as mentioned above. If you need any pr tested on those environments I can help out.

Hello @dariemihai95, Support for Python 3.6 is now live. Check it out!
I have tested v<IP_ADDRESS> on Windows and Mac on Pip and Conda venv, although unsure about Ubuntu. Cheers.

Hello @dariemihai95, Support for Python 3.6 is now live. Check it out!
I have tested v<IP_ADDRESS> on Windows and Mac on Pip and Conda venv, although unsure about Ubuntu. Cheers.

I have successfully tested it in Ubuntu 18 with python 3.6 and it works without issues. I have yet to test it in a docker container but I don't see why it would have any issues. One thing I noticed though but I may be wrong is that it takes a while longer to process files with this new version. I will test this out and if I have some conclusive results I will let you know. Thank you and great job so far !

I have successfully tested it in Ubuntu 18 with python 3.6 and it works without issues. I have yet to test it in a docker container but I don't see why it would have any issues. One thing I noticed though but I may be wrong is that it takes a while longer to process files with this new version. I will test this out and if I have some conclusive results I will let you know. Thank you and great job so far !

Closing this issue for now then.

Closing this issue for now then.


Eventloop is not longuer Send

Following last rust changes, EventLoop is not longer considered Send by the compiler. It effectively prevents initialising an EventLoop and then spawing a new thread to make it run.
The fix might be as simple as adding
unsafe impl<T: 'static, M: Send> Send for EventLoop<T, M> {}

but it can probably be handled better on the various subtypes of the library.

Yeah, there is probably a single subtype that has an unsafe pointer that needs to be marked Send. It might even be the vendored mpmc queue.

The exact error I have, on rust alpha is:
error: the trait `core::marker::Send` is not implemented for the type `*mut mio::util::slab::Entry<mio::timer::Entry<()>>`


:help ale* not working

Information
VIM version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Dec  7 2017 16:07:42)
macOS version
Operating System: Mac 10.10.5, CentOS 6
:ALEInfo
Current Filetype:
Available Linters: []
Enabled Linters: []
Linter Variables:
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = v:null
let g:ale_command_wrapper = v:null
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%code: %%s'
let g:ale_echo_msg_info_str = 'Info'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = v:null
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = v:null
let g:ale_list_vertical = v:null
let g:ale_loclist_msg_format = v:null
let g:ale_max_buffer_history_size = v:null
let g:ale_max_signs = v:null
let g:ale_maximum_file_size = v:null
let g:ale_open_list = v:null
let g:ale_pattern_options = {}
let g:ale_pattern_options_enabled = 0
let g:ale_set_balloons = 1
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = v:null
let g:ale_sign_error = v:null
let g:ale_sign_info = v:null
let g:ale_sign_offset = v:null
let g:ale_sign_style_error = v:null
let g:ale_sign_style_warning = v:null
let g:ale_sign_warning = v:null
let g:ale_statusline_format = v:null
let g:ale_type_map = {}
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:
What went wrong
The help isn't working. I can't get any ale help files working in VIM when I type :help ale-options or any other ale-*. I checked the vim general help by pushing F1, scrolled all the way down to 'LOCAL ADDITIONS', but I didn't see ale. I know ale is working because I can configure eslint, but the help isn't working.
On my CentOS box, I do see "ale.txt  For Vim version 8.0." in the LOCAL ADDITIONS section, but when I ctrl+] to jump to it, I see an error: "E149: Sorry, no help for ale.txt"
Reproducing the bug
Install ALE with pathogen.
 cd ~/.vim/bundle
 git clone https://github.com/w0rp/ale.git

Try to access the ALE help docs within VIM.
 :help ale-options  # doesn't work...

My fault:
https://stackoverflow.com/questions/6970334/vim-pathogen-not-loading-help-docs#9391768
I needed to run :Helptags.

I had the same issue but with standard vim package install.  I also wanted ':h ale' to load the TOC so I added symlink.  I ran these commands and it worked.
jbenninghoff@jb-mbpro 1: cd ~/.vim/pack/gitplugins/start/ale/doc
jbenninghoff@jb-mbpro 1: ln -s ale.txt ale
jbenninghoff@jb-mbpro 1: vim -u NONE -c "helptags ~/.vim/pack/gitplugins/start/ale/doc" -c q

I have a recommendation for this in the README. https://github.com/w0rp/ale#generating-vim-help-files


support Radiant Earth MLHub

I get an http error when trying to add https://api.radiant.earth/mlhub/v1/
Would be great to make sure that works.

@cholmes  I can start checking the issues as per the draft and order. Thanks(Davince)

Same problem as https://github.com/kbgg/qgis-stac-browser/issues/85
Once the URL is correctly entered without the triling slash, the connection works fine and the list of collections is shown. However, searching does not work, since the server seems to require auth and returns a 401 Unauthorized response


Adding support for Dual Virpil VPC WarBRD DELTA joysticks.

Looks clean.
Note to self: merge into dev not master. Have set dev as the default branch going forward.

Manually merged into dev.


[incubator/sentry-kubernetes] Add release/environment values

This allows you to customize settings here: https://github.com/getsentry/sentry-kubernetes/blob/master/sentry-kubernetes.py#L27-#L28

What this PR does / why we need it:
This add environment variable configurations for the sentry-kubernetes docker image. This allows you to customize settings here: https://github.com/getsentry/sentry-kubernetes/blob/master/sentry-kubernetes.py#L27-#L28
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

Hey @gianrubio let me know if you'd like me to squash the commits or do anything further.
Thanks for the review!

/ok-to-test
/lgtm

I tried to run this change and got an error when deploying with helm Error: release sentry-kubernetes failed: Deployment.apps "sentry-kubernetes" is invalid: spec.template.spec.containers[0].env[2].valueFrom.resourceFieldRef.resource: Unsupported value: "image": supported values: "limits.cpu", "limits.ephemeral-storage", "limits.memory", "requests.cpu", "requests.ephemeral-storage", "requests.memory" What version on kubernetes does this need to run on? I am running "v1.9.6" but I cant find anything about this in the docs

Hey @robdefeo, yea the release value was added to the or with out proper testing, there is a PR to revert the change (#6002).

@hobochild Perfect, thanks for the information, I'll watch that PR


Ra/salt levi

Moved back to #26253
Internal review URL
Public review  of the doc build:

download the HTML files
unzip
view HTML file in a browser. It best to view the doc with the widest window that has no left or right TOC (Table  of contents)
For links outside the doc, remove the review. from URL.

Moved from #26253

@andrewlock please review.

@andrewlock sorry, moved back to #26253


Unable to get a connection pool of a PoolingDataSource

We are occasionally encountering a problem where we can't get a connection from the pool after the network connection was dropped and recovered.
java.sql.SQLException: unable to get a connection from pool of a PoolingDataSource containing an XAPool of resource feebase with 0 connection(s) (0 still available)
at bitronix.tm.resource.jdbc.PoolingDataSource.getConnection(PoolingDataSource.java:262)
...
Caused by: java.sql.SQLException: unable to connect to non-XA resource oracle.jdbc.OracleDriver
....
Caused by: java.sql.SQLRecoverableException: IO Error: Connection reset
....
Caused by: java.net.SocketException: Connection reset
What can we do to 'reboot' PoolingDataSource, or is there a configuration we should set to get it to auto-recover?
We are using btm 2.1.1, and I have found a similar problem reported for btm 2.1.4 on StackOverflow similar problem reported for 2.1.4 so I'm not confident that upgrading versions will fix the problem.
We are running on a linux server, and we're using Spring 3.1.2.

Did you enable some form of connection testing on your pool, like enableJdbc4ConnectionTest or testQuery?

Yes we do. It is selecting the sysdate from dual.
I just cloned the source code today, and searched for the lines in the stacktrace, and it looks like we are actually using the btm-2.1.3.jar. Also, we are using com.oracle:ojdbc7:<IP_ADDRESS>.0.
We are able to run the application a couple times, each time it takes longer to run, and then it fails.
I have attached a log for a working instance, and a failing instance.
works.txt
fails.txt

We found the cause and solution for our
exception.txt
problem. I don't know if
exception.txt
there is anything Bitronix could do for it.
We are using encrypted passwords on a linux box, and the oracle driver was having a problem. The clue to the problem is at the very end of the stacktrace. The StackOverflow item Oracle JDBC Intermittent Connection Issue explains what we ran into. Adding -Djava.security.edg=file:///dev/urandom fixed the problem.

Is this issue similar to the issue described here?
If not, how do they differ? Also, in the linked issue, the stack trace he provides is much longer and more informative than mine. I only see the top most layer of the stack trace. How can I see a more verbose version?


feat(ErrorSummary): ✨ Make the component

Resolves #1320

@mimarz We should have a look at #1400 before we merge this, since this component uses the List component


Add Google Analytics?

Could we set a goal for actual usage?

Talked with Nils: not an immediate need.


carstore.CarStore is an interface, carstore.FileCarStore implements it

more refactor. can merge into https://github.com/bluesky-social/indigo/pull/757 or make it a follow-on

done elsewhere