Spacing in publications list  is uneven and mobile view doesn't look great

I tried looking at this issue a lot to fix the spacing between the <li> tags and the content but couldn't come up with a solution. In my opinion, the code is a bit ugly for this and needs fixing. The buttons seem to be aligned but not the text.
The list number is not generated by the <li> (which I think it should be that way) and instead, the content lies inside a nested <span> and <div> tag. Please inspect the element to see it while fixing this issue.

@jfkeller You worked on this for a while, right? Should we just close this, or should someone else give it a try?

I fixed the issue related to the @phdthesis but not the general spacing issue which causes things to be misaligned when there are long titles or author lists. Also the alignment of the text is effected by the number of digits in the citation number. Fixing this would require modifying whatever is generating the html, instead of just modifying the input to the generator which is what I did to fix the phdthesis issue. I guess its not too noticeable, so maybe we could close it unless someone wants to write a new generator or figure out how to modify the current one.


mavlink: 2016.6.24-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mavlink to 2016.6.24-0:

upstream repository: https://github.com/mavlink/mavlink.git
release repository: https://github.com/mavlink/mavlink-gbp-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.21
previous version for package: 2016.6.22-1

Hotfix for mavros.


[WIP] Add a default editor animation and play that animation to first frame…

… of that track.
Gltf2's editor view is broken unless you go to any animation's first frame. This patch creates the concept of an editor default animation and plays the first frame of it.
Edited:
May help #1333 @slapin Can you check?
May also help #21092 part 1.

Would you please write a few words when closing PR seen by some people,
this looks quite awkward otherwise. Thanks!

I need this too, but I wonder if the engine can possibly do this automatically for us, because it's needed in FBX in some instances.
Just so we don't duplicate code


Add Mizar and Arktos v0.7 Release Blogs

Doc: Added Mizar and Arktos v0.7 release blogs.md

/approve

/lgtm


[Feature request] Add a version option (-v)

So everybody can see if his version is up to date or not.

Feature added in commit 7016b94.
Thanks for your contribution!


[nrf noup] arch: arm: aarch32: workaround pop lr after wfi crash

On nRF5340 net core it was observed that when wfi instruction was followed by pop {r0, lr} in the arch_cpu_idle function, the value of lr sometimes got read as 0 from memory despite having correct value stored in the memory.
This commit inserts additional nop instruction after waking up to delay access to the memory.

Please use a hook or introduce one if not present. We cannot have this downstream in the core arch code, especially now that it is being refactored in Zephyr.

@carlocaione perhaps could suggest how to have a hook like this.

Without using a real function hook that would impact too much on the idle thread I would suggest to inject a macro carrying the few assembly instructions, like we do for example on RISC-V here: https://github.com/zephyrproject-rtos/zephyr/blob/8560fb319249e3fad3122f8541df4c4beef6e5e2/arch/riscv/core/isr.S#L146-L148 so that the NOPs would be introduced by the preprocessor at compile time.
Somewher soc-specific:
#define WAIT_ON_WFI \
    nop \
    nop \
    nop \
    nop

In cpu_idle.S (upstream-able with a good justification):
...
#if defined(CONFIG_WAIT_ON_WFI)
    WAIT_ON_WFI
#endif
...

@carlescufi I agree with you, I am preparing upstreamable patch, but it takes time, can we go with this for 2.4.1 ?

Content of this PR will be likely superseded by cherry-pick of commit in https://github.com/nrfconnect/sdk-zephyr/pull/1231 which is hopefully an upstreamable solution. It gives exactly the same assembly code.

For some reason twister status on GH was not updated, but the latest run passed:
https://jenkins-ncs.nordicsemi.no/job/latest/job/sdk-zephyr/job/PR-1228/3/

ooh, this patch is beautiful. Just came across this from somewhere else.


STOP is now not working any more

Back in February the STOP command was stopping the playing of songs (youtube-music-skill) or radio music (tunein-skill). But it worked not properly (see issue #110). Since 2 or 3 weeks the STOP command is completely not working. There is no reaction on STOP. Other commands like "PAUSE" or "RESUME" are still working.

maybe works with the new pipeline https://openvoiceos.github.io/ovos-technical-manual/OCP_pipeline/ + #112

maybe works with the new pipeline https://openvoiceos.github.io/ovos-technical-manual/OCP_pipeline/ + #112

I'm not sure, if I understand right. I have added this to my mycroft.conf, but there was no change. STOP is still not working.
   // Intent Pipeline / plugins config
  "intents" : {

    "pipeline": [
        "stop_high",
        "converse",
        "ocp_high",
        "padatious_high",
        "adapt_high",
        "fallback_high",
        "stop_medium",
        "adapt_medium",
        "padatious_medium",
        "adapt_low",
        "common_qa",
        "ocp_medium",
        "fallback_medium",
        "ocp_fallback",
        "fallback_low"
    ]
  },

In the audio logs I can see this error message, when I use "STOP".

2024-05-11 20:58:11.921 - audio - ovos_plugin_common_play.ocp.player:resume:568 - DEBUG - Resuming playback: 3

exception calling callback for <Future at 0x71f4dff70ed0 state=finished raised TypeError>

Traceback (most recent call last):

  File "/usr/lib/python3.11/concurrent/futures/_base.py", line 340, in _invoke_callbacks

    callback(self)

  File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_executor.py", line 57, in _callback

    self.emit("error", exc)

  File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 118, in emit

    self._emit_handle_potential_error(event, args[0] if args else None)

  File "/home/ovos/.venv/lib/python3.11/site-packages/pyee/_base.py", line 88, in _emit_handle_potential_error

    raise error

  File "/usr/lib/python3.11/concurrent/futures/thread.py", line 58, in run

    result = self.fn(*self.args, **self.kwargs)

             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: AudioService._restore_volume_after_record.<locals>.restore_volume() takes 0 positional arguments but 1 was given

2024-05-11 20:58:11.942 - audio - ovos_plugin_vlc:track_start:67 - DEBUG - VLC playback start

NLP moved to ovos-core directly, uncoupled from the OCP plugin
you are missing  "experimental_ocp_pipeline": true,  to enable it, we are testing to see if it should be made a default on release 0.0.8 or if it needs more time and should only be enabled in 0.1.0, so for now that flag needs to be set for those who want to experiment

Okay. I tried with the following. Still no change. STOP is not working. Same error message.
The link with the test case I don't understand. That is too much "code" for me. Sorry, I'm only a "user".
  "intents" : {
    "experimental_ocp_pipeline": true,
    "pipeline": [
        "stop_high",
        "converse",
        "ocp_high",
        "padatious_high",
        "adapt_high",
        "fallback_high",
        "stop_medium",
        "adapt_medium",
        "padatious_medium",
        "adapt_low",
        "common_qa",
        "ocp_medium",
        "fallback_medium",
        "ocp_fallback",
        "fallback_low"
    ]
  },

please share core logs to see what ovos is trying to do when it hears stop
and also try having ocp_high before stop_high
        "converse",
        "ocp_high",
        "stop_high",

I tried now with this version. No change. In ovos-core there is no log-reaction at all, when I use STOP.  And I already use log-level DEBUG.
// Intent Pipeline / plugins config
  "intents" : {
    "experimental_ocp_pipeline": true,
    "pipeline": [
        "ocp_high",
        "stop_high",
        "converse",
        "padatious_high",
        "adapt_high",
        "fallback_high",
        "stop_medium",
        "adapt_medium",
        "padatious_medium",
        "adapt_low",
        "common_qa",
        "ocp_medium",
        "fallback_medium",
        "ocp_fallback",
        "fallback_low"
    ]
  },

It's strange. When I give the STOP command via voice, then there is no reaction in core log. But when I give the command via ovos-cli-client, then there is the following log, but music is still playing.

2024-05-11 21:48:42.822 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-cancel: {}

2024-05-11 21:48:42.822 - skills - ovos_core.transformers:transform:63 - WARNING - ovos-utterance-corrections transform exception: list index out of range

2024-05-11 21:48:42.823 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'lang': 'de-de'}

2024-05-11 21:48:42.825 - skills - ovos_core.intent_services:get_pipeline:263 - DEBUG - Session pipeline: ['ocp_high', 'stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'ocp_medium', 'fallback_medium', 'ocp_fallback', 'fallback_low']

2024-05-11 21:48:42.826 - skills - padacioso:calc_intent:240 - INFO - No match

2024-05-11 21:48:42.827 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method OCPPipelineMatcher.match_high of <ovos_core.intent_services.ocp_service.OCPPipelineMatcher object at 0x75a90aea6e10>>

2024-05-11 21:48:42.827 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x75a90aeab590>>

2024-05-11 21:48:42.874 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x75a90ae467d0>>

2024-05-11 21:48:42.874 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95

2024-05-11 21:48:42.876 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - intent matching took: 0.05149340629577637

ovos.common_play stopped: None

skill-ovos-youtube-music.openvoiceos stopped: None

skill-ovos-boot-finished.openvoiceos stopped: None

skill-ovos-news.openvoiceos stopped: None

skill-openhab stopped: None

Here is the listener log. It seems there is nothing transcribed. But other commands like "What time is it" or "PAUSE" the listener transcribes correct???
2024-05-11 21:58:03.319 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_detect_ww:471 - DEBUG - Wake word detected=hey_mycroft

2024-05-11 21:58:03.320 - voice - ovos_dinkum_listener.service:_hotword_audio:618 - DEBUG - Handling listen sound: snd/start_listening.wav

2024-05-11 21:58:03.321 - voice - ovos_dinkum_listener.service:_hotword_audio:642 - DEBUG - Emitting hotword event: recognizer_loop:wakeword

2024-05-11 21:58:03.321 - voice - ovos_dinkum_listener.service:_record_begin:501 - DEBUG - Record begin

2024-05-11 21:58:03.324 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:225 - INFO - Wakeword detected

2024-05-11 21:58:03.830 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:252 - DEBUG - STATE: ListeningState.BEFORE_COMMAND

2024-05-11 21:58:03.914 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.086 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.171 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.342 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.426 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.598 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.683 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 21:58:04.684 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_before_cmd:585 - DEBUG - STATE: ListeningState.IN_COMMAND

2024-05-11 21:58:04.854 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:04.939 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:05.110 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:05.195 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:05.366 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:05.451 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 21:58:05.452 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_in_cmd:624 - DEBUG - STATE: ListeningState.AFTER_COMMAND

2024-05-11 21:58:05.622 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:261 - INFO - speech finished

2024-05-11 21:58:05.641 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:703 - DEBUG - removed silence from utterance

2024-05-11 21:58:05.642 - voice - ovos_stt_plugin_server:execute:40 - DEBUG - Using user defined urls ['http://<IP_ADDRESS>:8082/stt', 'http://<IP_ADDRESS>:8083/stt']

2024-05-11 21:58:05.643 - voice - ovos_stt_plugin_server:execute:47 - DEBUG - chosen url http://<IP_ADDRESS>:8082/stt

2024-05-11 21:58:05.911 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:712 - INFO - nothing transcribed

2024-05-11 21:58:05.912 - voice - ovos_dinkum_listener.service:_record_end_signal:651 - DEBUG - Record end

2024-05-11 21:58:05.913 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:733 - DEBUG - STATE: ListeningState.DETECT_WAKEWORD

2024-05-11 21:58:05.913 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:744 - DEBUG - reset VAD

you seem to be running into https://github.com/OpenVoiceOS/ovos-dinkum-listener/issues/110

from your core logs, seems like OCPPipeline is not detecting the player is active?  (So doesnt match stop)
does it match pause/resume?

the first error log you shared is unrelated to stop, fixed https://github.com/OpenVoiceOS/ovos-audio/issues/65

pause and resume are trancribed correct and there is a correct reaction.
Here is an log example with pause

2024-05-11 22:11:23.072 - voice - ovos_dinkum_listener.voice_loop.hotwords:found:259 - DEBUG - Detected wake_word: hey_mycroft

2024-05-11 22:11:23.073 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_detect_ww:471 - DEBUG - Wake word detected=hey_mycroft

2024-05-11 22:11:23.074 - voice - ovos_dinkum_listener.service:_hotword_audio:618 - DEBUG - Handling listen sound: snd/start_listening.wav

2024-05-11 22:11:23.075 - voice - ovos_dinkum_listener.service:_hotword_audio:642 - DEBUG - Emitting hotword event: recognizer_loop:wakeword

2024-05-11 22:11:23.075 - voice - ovos_dinkum_listener.service:_record_begin:501 - DEBUG - Record begin

2024-05-11 22:11:23.083 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:225 - INFO - Wakeword detected

2024-05-11 22:11:23.583 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:252 - DEBUG - STATE: ListeningState.BEFORE_COMMAND

2024-05-11 22:11:23.669 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:23.839 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:23.925 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:24.096 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:24.181 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:24.351 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:24.437 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:255 - DEBUG - waiting for speech

2024-05-11 22:11:24.439 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_before_cmd:585 - DEBUG - STATE: ListeningState.IN_COMMAND

2024-05-11 22:11:24.608 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:24.693 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:24.864 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:24.949 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:25.119 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:25.205 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:25.375 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:258 - DEBUG - recording speech

2024-05-11 22:11:25.377 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_in_cmd:624 - DEBUG - STATE: ListeningState.AFTER_COMMAND

2024-05-11 22:11:25.461 - voice - ovos_dinkum_listener.voice_loop.voice_loop:run:261 - INFO - speech finished

2024-05-11 22:11:25.487 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:703 - DEBUG - removed silence from utterance

2024-05-11 22:11:25.488 - voice - ovos_stt_plugin_server:execute:40 - DEBUG - Using user defined urls ['http://<IP_ADDRESS>:8082/stt', 'http://<IP_ADDRESS>:8083/stt']

2024-05-11 22:11:25.489 - voice - ovos_stt_plugin_server:execute:47 - DEBUG - chosen url http://<IP_ADDRESS>:8082/stt

2024-05-11 22:11:25.804 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:709 - DEBUG - transformers metadata: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcription': 'Pause'}

2024-05-11 22:11:25.805 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:710 - INFO - transcribed: Pause

2024-05-11 22:11:25.806 - voice - ovos_dinkum_listener.service:_record_end_signal:651 - DEBUG - Record end

2024-05-11 22:11:25.806 - voice - ovos_dinkum_listener.service:_stt_text:669 - DEBUG - STT: Pause

2024-05-11 22:11:25.807 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:733 - DEBUG - STATE: ListeningState.DETECT_WAKEWORD

2024-05-11 22:11:25.810 - voice - ovos_dinkum_listener.voice_loop.voice_loop:_after_cmd:744 - DEBUG - reset VAD

2024-05-11 22:11:25.824 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-cancel: {}

2024-05-11 22:11:25.824 - skills - ovos_core.transformers:transform:63 - WARNING - ovos-utterance-corrections transform exception: list index out of range

2024-05-11 22:11:25.825 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcription': 'Pause', 'lang': 'de-de'}

2024-05-11 22:11:25.827 - skills - ovos_core.intent_services:get_pipeline:263 - DEBUG - Session pipeline: ['ocp_high', 'stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'ocp_medium', 'fallback_medium', 'ocp_fallback', 'fallback_low']

2024-05-11 22:11:25.836 - skills - padacioso:calc_intent:240 - INFO - No match

2024-05-11 22:11:25.837 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method OCPPipelineMatcher.match_high of <ovos_core.intent_services.ocp_service.OCPPipelineMatcher object at 0x7c261358a210>>

2024-05-11 22:11:25.837 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x7c2613fa0250>>

2024-05-11 22:11:25.901 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x7c2613f3ead0>>

2024-05-11 22:11:25.902 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95

2024-05-11 22:11:25.907 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - intent matching took: 0.07561469078063965

2024-05-11 22:11:25.833 - audio - ovos_plugin_vlc:track_start:67 - DEBUG - VLC playback start
2024-05-11 22:11:25.834 - audio - ovos_audio.audio:track_start:163 - DEBUG - New track coming up!
2024-05-11 22:11:25.923 - audio - ovos_plugin_common_play.ocp.player:pause:547 - DEBUG - Pausing playback: 3

no match from <bound method OCPPipelineMatcher.match_high  <- OCP is not matching for you
I also see your lang is de-de , so you need to translate a bunch of OCP files before it will work https://github.com/OpenVoiceOS/ovos-core/tree/dev/ovos_core/intent_services/locale/en-us
but it seems padatious is, which indicates you are using the old OCP intents.... are you missing this PR? https://github.com/OpenVoiceOS/ovos-ocp-audio-plugin/pull/112
for all intents and purposes you are running the old OCP and skipping the Pipeline

You were right. Even I did an update of all my ovos docker containers this evening, I was still on version 0.0.7a2. I now updated manually via audio.list to 0.0.7a3.
I see now this in audio log:
2024-05-11 23:08:22.846 - audio - ovos_plugin_common_play.ocp:register_media_intents:124 - INFO - Using Classic OCP with experimental OCP pipeline

2024-05-11 23:08:22.847 - audio - ovos_plugin_common_play.ocp:register_media_intents:125 - DEBUG - skipping Classic OCP intent registering

But still no change in results. No reaction on stop via voice. Stop via ovos-cli-client results in the following log:
2024-05-11 23:17:15.216 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-cancel: {}

2024-05-11 23:17:15.216 - skills - ovos_core.transformers:transform:63 - WARNING - ovos-utterance-corrections transform exception: list index out of range

2024-05-11 23:17:15.218 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'ovos_dinkum_listener', 'source': 'audio', 'destination': ['skills'], 'transcription': 'Spiele weiter', 'lang': 'de-de'}

2024-05-11 23:17:15.220 - skills - ovos_core.intent_services:get_pipeline:263 - DEBUG - Session pipeline: ['ocp_high', 'stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'ocp_medium', 'fallback_medium', 'ocp_fallback', 'fallback_low']

2024-05-11 23:17:15.221 - skills - padacioso:calc_intent:240 - INFO - No match

2024-05-11 23:17:15.222 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method OCPPipelineMatcher.match_high of <ovos_core.intent_services.ocp_service.OCPPipelineMatcher object at 0x75cbe0370190>>

2024-05-11 23:17:15.223 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x75cbe0597090>>

2024-05-11 23:17:15.237 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x75cbe0536910>>

2024-05-11 23:17:15.238 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95

2024-05-11 23:17:15.239 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - intent matching took: 0.019217729568481445

2024-05-11 23:17:15.286 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session

2024-05-11 23:17:15.350 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session

2024-05-11 23:17:48.851 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-cancel: {}

2024-05-11 23:17:48.851 - skills - ovos_core.transformers:transform:63 - WARNING - ovos-utterance-corrections transform exception: list index out of range

2024-05-11 23:17:48.852 - skills - ovos_core.transformers:transform:60 - DEBUG - ovos-utterance-normalizer: {'client_name': 'mycroft_cli', 'source': 'debug_cli', 'destination': ['skills'], 'lang': 'de-de'}

2024-05-11 23:17:48.854 - skills - ovos_core.intent_services:get_pipeline:263 - DEBUG - Session pipeline: ['ocp_high', 'stop_high', 'converse', 'padatious_high', 'adapt_high', 'fallback_high', 'stop_medium', 'adapt_medium', 'padatious_medium', 'adapt_low', 'common_qa', 'ocp_medium', 'fallback_medium', 'ocp_fallback', 'fallback_low']

2024-05-11 23:17:48.855 - skills - padacioso:calc_intent:240 - INFO - No match

2024-05-11 23:17:48.856 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method OCPPipelineMatcher.match_high of <ovos_core.intent_services.ocp_service.OCPPipelineMatcher object at 0x75cbe0370190>>

2024-05-11 23:17:48.858 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method StopService.match_stop_high of <ovos_core.intent_services.stop_service.StopService object at 0x75cbe0597090>>

2024-05-11 23:17:48.874 - skills - ovos_core.intent_services:handle_utterance:376 - DEBUG - no match from <bound method ConverseService.converse_with_skills of <ovos_core.intent_services.converse_service.ConverseService object at 0x75cbe0536910>>

2024-05-11 23:17:48.875 - skills - ovos_core.intent_services.padatious_service:_match_level:50 - DEBUG - Padatious Matching confidence > 0.95

2024-05-11 23:17:48.880 - skills - ovos_core.intent_services:handle_utterance:382 - DEBUG - intent matching took: 0.02547287940979004

2024-05-11 23:17:48.933 - skills - ovos_bus_client.client.client:on_default_session_update:161 - DEBUG - synced default_session

skill-ovos-news.openvoiceos stopped: None

skill-ovos-youtube-music.openvoiceos stopped: None

skill-ovos-boot-finished.openvoiceos stopped: None

skill-openhab stopped: None

ovos.common_play stopped: None

I now tried in English. And there it's working!
I find that strange. When I look to https://github.com/OpenVoiceOS/ovos-core/tree/dev/ovos_core/intent_services/locale/de-de there is a German stop.intent file and it looks fine....And why are the German versions of "pause" and "resume" working, even there are no German pause.intent and resume.intent files in that directory?


Distribute non-code files

Is there a way to distribute non-code files (data files, JSON files, image files) along with Python modules with flit?
I want these files to be copied at install time to the package's folder inside site-packages. I believe I can achieve this with setuptools with include_package_data=True and MANIFEST.in files.

"question" label would be a good fit here

Yup, that's one of my favourite features. Anything inside the package folder is automatically included; there's no need to specify them anywhere. This is more than just a convenience; I've found it's easy to forget to add them to lists like MANIFEST.in, and then ship a broken package.
E.g. Flit includes license templates as data files within its own package.

Yes, I see. Thanks for the quick response!


How to use in Junit or TestNg test framework

Dear Sir,
Thanks for your demostration on Appium Grid in parallel Android device.
Could you introduce more the Appium grid in Junit or TestNg?

Hi Sameer,
Please let me know how this can be done using TestNG and also i need to run some test cases on one device and some test cases on another device.


remove C subgrammar for emit

For some reason this is buggy, using {.emit: [a, b, c].} completely removes highlighting of some files on github.
Keeping these commented as they may be reused for something like cLang"""..."""

We need this patch though, on some files the highlighting is unusable when you use something like .emit: [x, " = ", b]


Two-Factor Authentication Problem

Apparently Alarm.com has a new requirement where if you are a customer who has not setup two-factor authentication; when you logon with a new session; you are redirected to a "Set up your System" page that will allow you to skip or setup two-factor authentication. The code in this app mimics the same behavior a browser would, but the code does not respond to skipping the "Set up your System" page therefore the logon process within this app no longer works.

Fixed the two factor authentication.

In application "Alarm.com Manager", function "mainPage()" added new input
section {
input "twoFactorAuthenticationId", "twoFactorAuthenticationId", title: "twoFactorAuthenticationId from browser", required: false
}

In application "Alarm.com Manager", function "getSystemAuthID()", added a fourth header to "params=":
"Cookie": "twoFactorAuthenticationId=${twoFactorAuthenticationId}"

Logged into the alarm.com web site and enabled for 2-factor authentication

Retrieved from the browser value of cookie "twoFactorAuthenticationId" and assigned it the the field created in step 1 above

That's it.  It works.


Bulk edit fixes

This PR implements a couple fixes related to bulk edit page:

The interaction of checkboxes selection and "select all" checkbox is now fixed
Fixed edge case of daylight savings or timezone when parsing dates
Properly validating regulation on validity period popup

 To end date the Measure, we need to have a justification regulation should be available on the Edit measure screen. (4)

 [DIT] Bulk Edit Of Measures: JS issue on frontend with check / uncheck items in 'Work with selected measures' screen

 [DIT] Bulk Edit Of Measures: JS issue on frontend with check / uncheck items in 'Work with selected measures' screen


Correct Z orientation

Gravity is a downward (negative) force so faceup is negative Z

Yes, unfortunately seems the accelerometer I based that on was mounted on the underside of the board so its reading was opposite of what it should be


Update to latest Q# and Roslyn compilers

The samples are already 2 years old.

done in https://github.com/filipw/Strathweb.Samples.QSharpCompiler/commit/52ac8a841d235a7fa6b1fd738d28fdf245d084bc


Installer Guidance on Compatible Versions of Spark and Scala

As a new user to PixieDust, I want the PixieDust installer to tell me which versions of Spark and Scala are compatible with each other so that I can install PixieDust using versions of Spark and Scala already installed on my machine (and know which versions of these I should install).
Expected behavior
Tell me which version of Scala I need for the version of Apache Spark installed.
$ jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /Users/bradleydholt/pixiedust
    Keep y/n [y]? y
Step 2: SPARK_HOME: /usr/local/Cellar/apache-spark/2.1.0/libexec
    Keep y/n [y]? y
Step 3: SCALA_HOME: /usr/local/opt/scala
    Keep y/n [y]? y
A different version of Scala (2, 12) is already installed in this directory.
You are using Apache Spark v2.1, which requires Scala v2.11.

Actual behavior
$ jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /Users/bradleydholt/pixiedust
    Keep y/n [y]? y
Step 2: SPARK_HOME: /usr/local/Cellar/apache-spark/2.1.0/libexec
    Keep y/n [y]? y
Step 3: SCALA_HOME: /usr/local/opt/scala
    Keep y/n [y]? y
A different version of Scala (2, 12) is already installed in this directory.

Steps to reproduce the behavior
Using Homebrew on OS X:
$ xcode-select --install
$ brew cask install java
$ brew install scala
$ brew install apache-spark
$ export SPARK_HOME=/usr/local/Cellar/apache-spark/2.1.0/libexe
$ export SCALA_HOME=/usr/local/opt/scala
$ jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /Users/bradleydholt/pixiedust
    Keep y/n [y]? y
Step 2: SPARK_HOME: /usr/local/Cellar/apache-spark/2.1.0/libexec
    Keep y/n [y]? y
Step 3: SCALA_HOME: /usr/local/opt/scala
    Keep y/n [y]? y
A different version of Scala (2, 12) is already installed in this directory.

We should consider displaying prerequisite details before the user is prompted to enter information. Using this information a user should be able to make the right input decision in these scenarios:

User has prerequisite not installed
User has an unsupported version of a prerequisite installed
User has multiple version of a prerequisite installed


THRIFT-2522 TypeScript extension for Thrift Compiler

Adds the possibility to generate TypeScript Definition Files in addition to the generated JavaScript code (new parameter 'ts').
Supports JQuery, NodeJS support will come soon.

NodeJS support will come soon

Any update on NodeJS support?

I was wondering the same thing.
For now I'm writting the libdefs myself, but it would be a nice addition for sure.

We have a ts target?

Apparently :p
It generates definition files that matches the js target, but it looks like there is no equivalent for js:node.


create CheckBox annotation

create CheckBox annotation
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Alternate Designs

Why Should This Be In Core?

Benefits

Possible Drawbacks

Applicable Issues

Coverage remained the same at 0.0% when pulling a1a35da43f6b6c37abf62c4df0b19dcc3fe78b04 on Fakhreddine10:patch-11 into 6b9f73a3982e26b166a4a86e84bc5cc65e10036c on JsonSchema-JavaUI:master.


Fix for issue #19 - Added missing property 'url' to SocialConnections

Hi @Grestorn, thanks for the PR.  I'm going to do the same, but also do some paperwork (changelog, etc.) and make sure that future schema mismatches are safely ignored, so I'm going to close this.


"Flow sensitive" keywords

These are the features I discussed at PI. I renamed it to context in order to not change the older functionality of #:mode that I know @stchang was using.
There is #:ctx/#:sub-ctx for parameterizing a single clause:
[⊢ [e ≫ e- ⇒ τ] #:ctx co]

And #:context/#:sub-context for parameterizing multiple clauses:
#:context co
  ([⊢ e1 ≫ e1- ⇒ τ]
   #:fail-unless xyz ...
   [⊢ [e2 ≫ e2- ⇒ σ] #:sub-ctx get-sub-context])

The module turnstile/context defines the context struct, the current-context parameter, a macro with-context for parameterizing outside of turnstile, and a helper function make-param-context for converting parameters + a value into contexts.
I'm working on integrating this into the linear language in another branch.
UPDATE: context renamed to mode, replacing old #:mode keyword.
UPDATE: Wrote documentation.

Making a new PR that is cleaned up


feature: Series.format

I am using this library, and found there is no support for line series colors, I have three series and for one of line series, it's showing in white color which is not visible because the background is white.
So it will be good if we have some method to change color, just like we have in BarSeries.

+1

+1 also telling the series what kind of line it is (solid, dashed, etc)

Series.format, which provides access to both .line and .fill, is forthcoming in the next release, probably in the next couple days. LineFormat includes width, but not line style yet, so @jredd you might want to +1 that separate feature request or add it if it's not in the list yet.

This was added in v0.6.0, just uploaded to PyPI.

Is there any documentation on using this new feature?

nvm I figured it out through some experimenting...

Indeed documentation would be great to have...


Scientific_Calculator - Mridul Vasudeva

My program uses OOP , stack , functions , switch-cases , do-while and few other things.
Please have a look at it...
Shows a Overall Menu to the User

Shows User Input specific menu

Takes required input from the user, computes the output and displays it

User has an option to preview its previously calculated result
This option utilizes stack data structure where calculations are stored and displayed when required.

Looks good to me Mridul. Can you attach some screenshots?

Looks good to me Mridul! Just Add some screenshots.

Okay, I have updated it with a few screenshots.


Add gfycat.com

gfycat is already a dark site (dark purple towards navy blue), however its footer is white.
Add the whole body to exclusion zone so footer gets inverted, also add rule to not invert the video frame

This site is displayed white for me

@opssemnik Can you visit gfycat again?
It's white by default for me and now also can be perfectly inverted by new Dynamic theme (from "More" tab).

gfycat's homepage and detail pages are all white themed, but the individual "gif" pages have a dark background. This should be a CSS selector fix and not domain level.
Example page: https://gfycat.com/damploathsomecow

The config file format has changed. If you are not using Dynamic mode, but using Filter mode, please, submit changes to inversion-fixes.config.


File in plutus-core-execlib not committed

This is like #5376, but with a missing file in the internal library plutus-core-execlib.

This time plutus-core/executables/src/PlutusCore/Executable/NOSUCHFILE.hs is missing:
module PlutusCore.Executable.NOSUCHFILE (nosuchconstant)
where

nosuchconstant ::Integer
nosuchconstant = 44

This again fails with
Preprocessing library 'plutus-core-execlib' for plutus-core-<IP_ADDRESS>..
Error: Setup: can't find source for PlutusCore/Executable/NOSUCHFILE in
executables/src, dist/build/plutus-core-execlib/autogen,
dist/build/global-autogen

The problem is correctly detected here, so I'm closing this.


Notes_on_write-you-a-tic-tac-toe

You know more haskell then me, a lot of my comments are just about style and pedagogy

Thanks a bunch! Implemented most of the comments.


RetrieveFile get bytes or reader

I just want to load the file in memory and not store it on disk. Is it possible to get just bytes array or reader?

Currently this is not supported, but it wouldn't be much work to implement it.
RetrieveFile calls requestDataConn which returns a net.Conn which implements the Reader interface.
I have currently not the time to implement and especially test this, but I'm open for pull requests.

Thank you, I have merged your pull request and added some error checking for buf.ReadFrom()


add sent_at when sending locally

close #371

@LostKobrakai what do you think about this? need some js to convert it to locale string (local timezone)?

Looks good. For local time it could probably use https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Date/toLocaleDateString to keep it simple.

Maybe something like that:
  <time datetime="2019-03-21T13:15:22.500704Z">2019-03-21T13:15:22.500704Z</time>
  …
  <script>
    var times = document.getElementsByTagName("time");
    for(var i = 0; i < times.length; i++){
      var t = times[i];
      var date = new Date(t.getAttribute("datetime"));
      t.innerHTML = date.toLocaleString();
    }
  </script>


Gitlab as an OIDC provider fails due to differing /oauth/ endpoints

Describe the bug
Using Gitlab as an OIDC provider only works in a very limited fashion because the OIDC endpoints are different than what flux assumes.
Currently, Gitlab's OIDC endpoints all start with /oauth/ such as https://gitlab.com/oauth/authorize but flux assumes these endpoints would fall under /oauth2/ and so it fails.
I did not see a way to change the endpoints for weave-gitops to match gitlab either.
Environment

Weave-Gitops - v0.31.2
Flux Version - v2.1.0
Kubernetes - v1.27.4

To Reproduce
Steps to reproduce the behavior:
Create a Gitlab App inside gitlab with OIDC access and use the credentials in your oidc-auth secret. Try to login with gitlab as an oidc in weave-gitops
Expected behavior
OIDC authorizes and pulls user info
Actual Behavior
errors like this:
2023-09-08T18:18:12.130Z	INFO	gitops.auth-server	auth/server.go:462	failed to get ID Token from request
2023-09-08T18:18:12.130Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 400}
2023-09-08T18:18:12.239Z	INFO	gitops.auth-server	auth/server.go:462	failed to get ID Token from request
2023-09-08T18:18:12.239Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 400}

Hello @pspurlock07 can you confirm what you are setting your Issuer URL to?

@pspurlock07 Can you confirm that going to https://<whatever you put in as your issuer URL/.well-known/openid-configuration gets a JSON response?

It does, and it matches what is at https://gitlab.com/.well-known/openid-configuration (sans the differing hostname)

@pspurlock07 this...
errors like this:
2023-09-08T18:18:12.130Z	INFO	gitops.auth-server	auth/server.go:462	failed to get ID Token from request
2023-09-08T18:18:12.130Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 400}
2023-09-08T18:18:12.239Z	INFO	gitops.auth-server	auth/server.go:462	failed to get ID Token from request
2023-09-08T18:18:12.239Z	INFO	gitops	middleware/middleware.go:61	request error	{"uri": "/oauth2/userinfo", "status": 400}

Just means that you aren't logged in, the page is attempting to poll data.
I've just tested this against a GitLab installation, and it seems to work fine.
Some things to check...

Your "GitLab application" has the openid scope.
Your OIDC secret is in the right place, it will log out that it has parsed the OIDC secret when debug logging is turned on.

2023-09-13T15:42:00.844Z	DEBUG	gitops	auth/init.go:77	OIDC config	{"IssuerURL": "https://gitlab.example.com", "ClientID": "<redacted>", "ClientSecretLength": 64, "RedirectURL": "http://localhost:9001/oauth2/callback", "TokenDuration": "1h0m0s"}

I'm not quite sure what part of Flux you're running into here when you say:

Currently, Gitlab's OIDC endpoints all start with /oauth/ such as https://gitlab.com/oauth/authorize but flux assumes these endpoints would fall under /oauth2/ and so it fails.

But the URLs will likely have oauth2, and this doesn't mean that we can't access them, we use the "discovery" mechanism which will ask for that /.well-known/openid-configuration URL and then talk to the URLs that it provides, they are served by the GitLab instance, so they are almost always going to be correct (even if they include oauth2).

okay, I think I see now. Here's how I went down the apparently wrong rabbit hole.
When I login with gitlab, I am not redirected to the weave-gitops ui, I am directed to a page on gitlab with an error The requested scope is invalid, unknown, or malformed.
In order to fix this, I added the option --from-literal=customScopes=email to oidc-auth after I saw that gitlab says it only presents group info in the /userinfo/ endpoint, and correlating that with the error I was seeing above {"uri": "/oauth2/userinfo", "status": 400}
At that point, I thought that was erroring because gitlab's endpoints are /oauth/ and that error says /oauth2/
However, I only realized after your last comment that my error above is presented at the start before I even attempt a login so it wasn't correlated.
Thanks for your quick response on this by the way.

Ahh..thanks for updating, I would recommend Dex for solving the "groups" problem (either that or use direct_groups as a scope and groups claim)
https://dexidp.io/docs/connectors/gitlab/
Dex does a supplemental query to inject the groups into the ID Token that they serve to the downstream OIDC Client (i.e. weave-gitops).

Perfect, I will look into that.  Thanks again @bigkevmcd I will go ahead and close this.


print explicit errors in the console (gorename)

https://github.com/liuhewei/gotools-sublime/issues/3

Thanks alvarolm. I just prefer a more normal code style, could you merge the two lines into one, such as:
print("GoTools: Rename error: %s" % err)

done


Fix typo

Please provide us with the following information:

This issue is for a: (mark with an x)
- [x] bug report -> please search issues before submitting
- [x] feature request
- [o] documentation issue or request
- [x] regression (a behavior that used to work and stopped in a new release)

Mention any other details that might be useful
IN Step 5: Import API Schema into API Management
Change 'Under API, click + Add API and select OpenAI' -> 'Under API, click + Add API and select OpenAPI'
I wasted a lot of time because of this.

Thanks! We'll be in touch soon.

PR #30 opened to fix the typo


PP-6763 Remove Direct Debit smoke tests

Description:

Removing Direct Debit smoke tests, so snitches aren't fired for Graphite

Missed the E2E section in the Jenkins file which are also calling tests.


Is there a way to manage configData completely via ARM template?

If you're using ARM templates for your entire IaC you can generate dsc configurations but you can only pass in limited configData via the parameters with a hashtable. Sticking a large hashtable for each dsc role in the .json file is not practical. It would be great if there is way to call a psd1 as a hashtable in the parameters of a compilationjob. The only suggestion on this page lists datum which seems interesting, but isn't even at v1.0 yet. Are there other options for managing configData available that can be used in production?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ff48a88-d1a2-3dcb-953d-6bc57b101549
Version Independent ID: 65fe5e0a-2090-b331-710a-54ec78f1fb53
Content: Configuration data at scale - Azure Automation
Content Source: articles/automation/automation-dsc-config-data-at-scale.md
Service: automation
Sub-service: dsc
GitHub Login: @mgreenegit
Microsoft Alias: migreene

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.

So I actually talked to someone at Microsoft about this and they mentioned they usually tell people to compile their mofs in a local environment before uploading them to an automation account.
We'll likely go that route and build the mofs locally with powershell scripts before upload, since compilation jobs in automation seem to have limitations currently. Would love to see more robust functionality here that is fully available via ARM template in the future.


Remove wait_for_ice_gathering_complete

We are waiting for ice gathering completion before we start ice trickling. In theory, this should not be needed, and it's probably slowing down connection times on wasm, especially if the socket is configured with multiple stun servers. However, last I checked, if we removed the wait, nat hole punching started failing.
Solve the todo here: https://github.com/johanhelsing/matchbox/blob/d7696ad2e5f548d34c85f5c7f24efcf353b4c53b/matchbox_socket/src/webrtc_socket/wasm.rs#L130
Care should be taken to make sure that nat hole punching still works after.

(I originally wrote this as a comment on #35 before I realized there was a separate issue for it here - I've edited my comment to move the relevant text from there into a new comment here.)
From poking around at https://github.com/johanhelsing/matchbox/issues/35, I suspect the NAT traversal issue when removing the wait might be because ICE gathering starts with the host interface as the first candidate, but the STUN-based candidates take a while to appear: if we send the first offer we can as soon as we can, then the STUN-based ICE candidates probably haven't had a chance to appear yet.
But I also see we construct an offer to send before we finish waiting for ICE gathering to complete, so I'm unsure how to square that with this theory.. unless NAT traversal is currently unreliable on high latency connections - I haven't tested that yet.


Minor fixes to project.json docs

Fix keyFile section and backslashes in file paths

cc @aL3891

LGTM


Update space page details

New space location : InnovationHQ, Banjara Hills
Map link : https://www.google.co.in/maps/place/Innovationhq+Co-Working+Space/@17.4258988,78.4430299,17z/data=!4m5!3m4!1s0x3bcb916257963565:0x32cd366cd5981112!8m2!3d17.4258937!4d78.4452186
Pricing :
50 Rs / hour < 3 hours
30 Rs / hour > 3 hours
Application form :  http://bit.ly/cpx-space-apply
Will share more details soon

After changes:

@duttakapil, please can you verify if the UI is looking as expected. I'll raise PR with my changes.

 Need help!


probably a bug

cant attach :

send help !!!

Right now I'm writing a test game for another addon prototype that is standing on stronger legs than this one did.
I'll take a peak at it when that is done. I'm still not completely satisfied with how this ended up working, and it may also become redundant with Godot 4's tilemap editor update.

a ok. will wait and see =]

I'm seeing some of that error popping up in the other project when everything is still working fine.


util(ticdc): Remove role from context

What problem does this PR solve?

Issue Number: close #9149
What is changed and how it works?
Remove role from context
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/merge

/retest-required


Feature/common

general clean up to the maven structure: commented monitor module, among other fixes, as not used
add common module where the seaclouds app and the policies to install data collectors are defined
I will move brooklyn-modaclouds entities to common there as soon as this gets merged

@MicheleGuerriero could you please take a look, particularly to the mechanism that installs the data collector for sigar?

Changes Unknown when pulling 87999b384f8c1b3f439bd25354bb6d4092b5e0aa on feature/common into ** on master**.

Changes Unknown when pulling 5bc7f1744eb977fd74b207ac0a445276fa612884 on feature/common into ** on master**.

Even though I couldn't run the live tests completely it looks good to me.

thanks @mbarrientos


FIrst PR

:star: PR built and available in a preview environment hack19-hub-hackathon-demo-2019-pr-1


EventGrid Event raise on binary type

Fixes https://github.com/Azure/azure-sdk-for-python/issues/13581

/azp run python - eventgrid - tests


Support parallel build for nvcc in CUDA 11.2 to make CuPy build faster

https://developer.nvidia.com/blog/boosting-productivity-and-performance-with-the-nvidia-cuda-11-2-c-compiler/

To mitigate the increase in build time arising from these multiple compilation passes, starting with the CUDA 11.2 release, the CUDA C++ compiler supports a new —threads  command-line option (-t for short) to spawn separate threads to perform independent compilation passes in parallel. If multiple files are compiled in a single nvcc command, -t compiles the files in parallel. The argument determines the number of independent helper threads that the NVCC compiler spawns to perform independent compilation steps in parallel.

Implemented via #4908


"Go back to recent messages" background is still normal discord background.

the message that desplays that you are viewing older messages and allows you to go back to the recent messages it's background is still the normal discord background even though you said you fixed it.

I want it to be visible, but i can blacken that aswell i guess


How to do ArgoCDAppUpdate when environment is separated by clusters

It seems that ArgoCDAppUpdate assumes that the ArgoCD application is running in the same cluster. However, in my case the for ArgoCD which controls production and test are running on separate clusters.
How would it work when this is the case?
Would I need to create one Stage in the cluster and another Stage in the production cluster? In this case the UI would become useless as it would not visualize all the environments.
Any ideas how to solve this problem?

I understand! Would be awesome to have better support of this in the future as it is a hard security requirement to have separate cluster for test and production.


fix for freetype glyph loading

With nanovg as renderer for @rxi's excellent lite code editor, I noticed the following undesirable glyph wonkiness when using FreeType:

The s glyph is particularly egregious.
Adding FT_LOAD_TARGET_LIGHT to the FT_Load_Glyph flags (see docs) did the trick:

Thanks for the fix!


Update .env.development

Update $USDC contract address on Optimism Mainnet

$USDC contract address = 0x7F5c764cBc14f9669B88837ca1490cCa17c31607,
Decimals = 6,
chainID = 10


Support mandatory parameters

Summary of the new feature / enhancement
As a PowerShell scripter
I'd like to make sure that required parameters is present
that otherwise would render an error if running the original command without them being present
Proposed technical implementation details (optional)
Add a switch that would mark a specific parameter as Mandatory.

Is that option part of the 2022-06 pre-release XML schema?

Yes - it has been since the early beta


Quick question about \n characters.

I'm trying to get "coordinates": output to NOT be on new lines.  Putting each long/lat pair on a new line makes the output with polygons/polylines really verbose and hard to copy/paste to use in other applications.
For instance:
[[
long,
lat
],
[
long,
lat
],]
makes a much smaller file if its [[long,lat],[long,lat]]
Anyone know where in the site.js file this behavior is dictated?  I'd love to be able to change, it... if only just on my own personal version.

@lance-weaver If I'm not mistaken (I'm not the author, only semi-maintainer), the implementation is here: https://github.com/mapbox/geojson.io/blob/0b7338d929a29897e747e1411c17861bcb28015c/src/panel/json.js#L50. It's JSON.stringify() with a space parameter of 2, which forces coordinate values onto new lines. Good luck!


[3.0 Alpha] Camera doesn't Work/Render when parenting in a Rigidbody.

Operating system or device - Godot version:
Godot 3.0 Alpha, Windows 10, Wacom Cintiq Companion 2
Issue description:

When I was attempting to make a 3D racetrack demo using PBR, I parented the camera into a 3D rigidbody node to allow the camera to follow the rigidbody vehicle, but when I started to test out the level by playing the scene, the camera doesn't render the scene correctly or does not show anything at all. I have no idea on how this is happening but unfortunately the camera immediately breaks when parenting in a rigidbody. It also generates errors in the debug area:
0:00:10:0919 - Condition ' determinant() == 0 ' is true
0:00:10:0919 - Condition ' p_axis.is_normalized() ==  false ' is true
and
0:00:11:0022 - Condition ' det == 0' is true
Steps to reproduce:
Try parenting by click and dragging the camera node to the rigidbody node to see if the results are the same or not based on what I've encountered so far.

I can't reproduce, can you make a small example with the error?

I'm currently rendering out an example using a screen capture.

Here is an unlisted youtube link showing what is happening, for some reason when I do make the camera a child of a normal rigidbody with a normal mesh, it works fine. Where it breaks is when I imported the model from Blender using the Better Collada Exporter:
https://youtu.be/6sTjxIb7_uA

One time it just wouldn't render at all, but now it just causes the camera to zoom in even when I havent changed any camera settings. Somehow when exported from Blender, the rigidbody parenting setup is causing the camera not to work right.
Bottom line: Not all nodes are capable of making the camera node work right. There should be a way to preserve the camera setting and rendering to make sure nothing like what is shown in the video link happens.

A bit of confussion in my poor english xD
But check the scales of imported elements, the ' det == 0' usually refers to a problem with a Transform matrix determinant, look at the scales while running (remote inspector) too.

Ok, I'll check it out.

i cant really say there is enough information on this report to make an idea of what is going on. A short example project would be great.

closing unless an example project is submitted, I just cant figure it out from the information provided


coverity fixes for SSKDF + mac_app

Checklist

[ ] documentation is added or updated
[x] tests are added or updated

ping

Pushed. Thanks.


Plan for NHWC optimization for NEON

I noticed the NHWC implementation of convolution, and it's extremely fast on AVX2.
But it seems Neon version is not implemented, I didn't find source file named SimdNeonConvolution.cpp.
Do you have any plan for that?

Yes. I have such plans. Now I'm waiting for ARM dev board (it is arriving 1-2 weeks) to start NEON optimizations.

That's great! I am looking foward to that.


Add a wrapper for jdbc contexts that returns scala Futures

Fixes #issue_number
Problem
Unfortunately I have to integrate with a rather old codebase using Scala Futures and the tests require writing and reading from an actual db. To make sure that tests are isolated the suites create their own postgres schemas and then also prepare the connection with a savepoint, to which they roll back after the test has run.
We would like to use the postgres-jasync backend for quill but of course need a drop in replacement for tests that is type compatible and also returns a Future.
Solution
The simplest solution to that would be to simply provide a wrapper around one of the jdbc contexts that proxies all calls but returns Futures and implements ScalaFutureIOMonad.
Unfortunately I am running into an error in the simple test I set up and I'm not sure if it is maybe an artifact of the way I alias the types:

Can't tokenize a non-scalar lifting. value.v12

Obviously I am open to renaming/moving everything. This was just meant to be a proof of concept.
Checklist

[ ] Unit test all changes
[ ] Update README.md if applicable
[ ] Add [WIP] to the pull request title if it's work in progress
[ ] Squash commits that aren't meaningful changes
[ ] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@soro I had something a little different in mind. Give me a couple weeks to put this together.

@soro I had something a little different in mind. Give me a couple weeks to put this together.

Let me know when you have something or if you want any feedback


Fix 22tracks.com and Subsonic/Madsonic bindings

Why did you removed "all_frames" : true? Works without it? I tested this player, with is works fine. Didn't tested without it.

Oh whoops, didn't mean to remove that line!


Audit logging does not work for multiple workers

Probably because the main workflow task is "copied" for each worker, because of how the python multiprocessing module works (forking the main python process).
Hope to find a solution to having a common place to store audit info.

Have asked a question about this in the luigi mailinglist:
https://groups.google.com/forum/#!topic/luigi-user/9J_s3UaQQEQ

As stated in the mailing list, I think I have a solution to this now:

Well, thinking about this now, I think I can solve it quite easily by using the normal way of passing luigi file targets between tasks, in the background. Will probably be a lot more robust as well. Will try it out.


Update providers

Closes #292
Closes #299
Closes #300
Closes #301
Closes #302

CI failed from chains unrelated to this PR and not in production. So I'm merging.

CI failed from chains unrelated to this PR and not in production. So I'm merging.

Re-running should solve it


Custom recipes broken

When I attempt to make wrought iron or glass in the campfire, it will not place, and the recipe would not show in JEI. If I look on how to get sulfur, it is impossible to make in ULV. How can I fix this?

Campfire recipes are working as intended

You can get tiny pile of sulfur from sieving or regular one from processing ores in kinetic ore factory


allowing dot before extension

allowing dot before extension as github markdown
    ```.ext
        some code
    ```

Didn't realize this one. Thanks.


bump to 1.31 and carry 126557: Stop requiring meta.Object for clientsets

this carry is required to fix client generationfor non meta types in https://github.com/openshift/client-go/pull/291

closing in favor of https://github.com/openshift/api/pull/1983


leanify: init at unstable-2022-12-04

Description of changes

Add Leanify package. Using git hash, as v0.4.3 wouldn't compile and progress seems slow anyway.
To add me as a maintainer, I had to first add a line to maintainers/maintainer-list.nix (in a separate commit).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 223300 run on aarch64-darwin 1

1 package failed to build:

leanify

Undefined symbols for architecture arm64:
  "_CPU_IsSupported_NEON", referenced from:
    _LzFindPrepare in LzFind.o

Looks like the object file containing CPU_IsSupported_NEON is not linked. This could be resolved by fixing the Makefile, but is there any chance of getting the fix upstream?

@ofborg build leanify


Use run_tests_matrix.py for running internal_ci master tests

Run more tests than just C on master (and use docker)
(we need to switch to dedicated pool before merging this)

Known failures:
https://github.com/grpc/grpc/pull/10911


Weird, inexplicable crashes when paired with a mutator called "Old School Zeds"

Hello there!
So, the reason why I call these crashes "weird" and "inexplicable" is because they don't really make any sense. They happen at random, they can't be reliably recreated, and they seem to happen whenever they please. You could be playing five matches in a row and never experience it, or have it happen to you on wave 1 mid-game while killing a ZED (or even during tradertime!)
Also, the mutator causes the server to crash during mapvote, either during the mapvoting itself or during map transitions. Thankfully, I have a script to bring the server back online, but still... it's very annoying.
I am running the latest version of ScrN. I am also running the latest version of this mutator (Old School Zeds), which can be found in the workshop. I already made a server from scratch to rule out any corrupted files, but the crashes are still happening. Here I am leaving several pastelinks with the logfiles. You can usually find the exact lines of the crash occuring at the end of each log. Worth noting is that I am running this server from my very own PC.
Pastebing logs:
https://pastebin.com/JPjqSVi9
https://pastebin.com/PZFnV6gn
https://pastebin.com/4QHBdf4Z
https://pastebin.com/rhQTF6gr
https://pastebin.com/RzBr3KXw
https://pastebin.com/ubVWT8C9
https://pastebin.com/7teutbGm
https://pastebin.com/ejs1qUBZ
https://pastebin.com/00YtnHaP
https://pastebin.com/bteuJvK1
https://pastebin.com/mVeGTCP1
https://pastebin.com/khxp9k7e
https://pastebin.com/yb5eu7Fb
https://pastebin.com/Jf6WSY64
https://pastebin.com/nxPicr79
https://pastebin.com/NaQ2KD7x
https://pastebin.com/MMNwYY4W
https://pastebin.com/3eHwXUy5
https://pastebin.com/rup6Xbp0
https://pastebin.com/M9413H4w
That's 20 logs, and I have many more but I can't paste them all due to Pastebin preventing me from posting more than 20 logs a day. Worth mentioning is that ScrN itself hasn't crashed a SINGLE time on me. Not even once (without the "Old School Zeds" mutator, that is). The moment I use the mutator... the problems start. I stopped using this mutator for a while because I got quite pissed at the crashes. I started a new server not too long ago, vanilla, without a single crash (so far), but the moment I try bringing in ScrN... the crashes started again. I am attaching the log from this "new" server with ScrN and OldSchoolZeds.
tl;dr: HELP!
KFMOD-vie.011-11-2022_15.59.log

Does the server crash only when using ScrN + Old School Zeds? Have you tried running the stock ScrN Bundle without custom mutators?
Also, I'm unsure if KFNoDramaMut is compatible with ScrN Balance. Try disabling KFNoDramaMut and see if that helps.

Alright, I will do all those tests as soon as I get home. Thanks, PooSH.
On Sat, Nov 12, 2022, 5:24 AM poosh @.***> wrote:

Does the server crash only when using ScrN + Old School Zeds? Have you
tried running the stock ScrN Bundle without custom mutators?
Also, I'm unsure if KFNoDramaMut is compatible with ScrN Balance. Try
disabling KFNoDramaMut and see if that helps.
—
Reply to this email directly, view it on GitHub
https://github.com/poosh/KF-ScrnBalance/issues/22#issuecomment-1312410819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKG54M4C7SYM3A5TU4RQFVTWH5H3RANCNFSM6AAAAAAR54UCXY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Alright, I left the server running (I am away for the time being) and I did exactly as you asked me: no NoDramaMut, no other mutators except for base Scrn Bundle... and it still crashed in the same way.
I don't really have access to my logs right now, but users have told me they experienced a crash on wave 6 while playing in the same way as all those other crashes have occurred.

Sorry for the THIRD POST in a row, but I just got home. Here's the .log file of when the server crashed while only running ScrN with the OldSchoolZeds mutator, no extra mutators or anything save for "Country Tags".
KFMOD-sáb.012-11-2022_14.50.log

Yeah, it never crashes. Just running ScrN + all those mods from before (and even the NoDramaMut) causes no crashes at all and I haven't experienced a single crash using JUST ScrN. OldSchoolZeds is causing the crashes.

Closed because the issue is not inside ScrN Balance


Add out of bound error for wasm array access in interpreter

@Cellule Can you please take a look ?

Can you rebase this change on top of master and also run ch spec.js -args testsuite-bin\address.json -endargs -on:wasm in test\wasmspec.
You will have to edit spec.js to
         case 'assert_trap':
            assertTrap(m, command);
            break;

I tried real quick and it crashes in interpreter and doesn't throw with -maic:0 (aka -forcenative for asm.js code)

I also found a case in WasmByteCodeGenerator.cpp where we emit a trap by default if there is no memory in the module
    // todo:: check for imported memory
    if (m_module->GetMemory() == nullptr)
    {
        // todo:: make that an out of bounds trap
        m_writer.EmptyAsm(Js::OpCodeAsmJs::Unreachable_Void);
    }

You should fix that as part of this change.

Updated the commit to handle the case when index + sizeof the memop exceeds the heapsize. There are pending failures that need to be handled for the spec.

Right now JIT is deadstoring an operator like ( drop ( load *)), but the baseline expects a trap on this load.
The bytecode is generated such a way that when index + offset overflows, the load sees a wrapped around index and there is no trap

Reviewed 3 of 9 files at r2, 4 of 6 files at r3, 4 of 4 files at r4.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

lib/Backend/LowerMDShared.cpp, line 291 at r4 (raw file):

    {
        Lowerer::InsertAdd(true, IR::RegOpnd::New(TyMachReg, m_func), indexOpnd, IR::IntConstOpnd::New(addrOpnd->GetSize() - 1, TyMachReg, m_func), helperLabel);
        Lowerer::InsertBranch(Js::OpCode::JO, helperLabel, helperLabel);

On x64, since the index opnd is 32 bits and TyMachReg is 64bits is impossible to overflow this addition.
You could do the following check
        if (indexOpnd->GetSize() >= TySize[TyMachReg])
        {
            // Check if the addition overflowed
            Lowerer::InsertBranch(Js::OpCode::JO, helperLabel, helperLabel);
        }

lib/Backend/LowerMDShared.cpp, line 293 at r4 (raw file):

        Lowerer::InsertBranch(Js::OpCode::JO, helperLabel, helperLabel);
    }
    m_lowerer->InsertCompareBranch(indexOpnd, arrayLenOpnd, Js::OpCode::BrGe_A, true, helperLabel, helperLabel);

You have to use the result of the addition here

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8291 at r4 (raw file):

            BYTE* buffer = arr->GetBuffer();
            *(ArrayType*)(buffer + index) = (ArrayType)GetRegRaw<RegType>(regSlot);
            return;

remove this return

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8365 at r4 (raw file):

        const uint32 index = (uint32)GetRegRawInt(playout->SlotIndex);
        JavascriptArrayBuffer* arr = *(JavascriptArrayBuffer**)GetNonVarReg(AsmJsFunctionMemory::ArrayBufferRegister);
        if (index >= arr->GetByteLength() || index + TypeToSizeMap[playout->ViewType] > arr->GetByteLength())

@MikeHolman Do you think there is a better way to check this case.
We need to trap if you are trying to access mem[65533] for a int32 with the max length being 65536.
However, I would really to find a way to avoid 2 checks.
The only thing I can think of is
if (index > arr->GetByteLength() - TypeToSizeMap[playout->ViewType])
Since we should trap on every memory access if there is no memory, then arr->GetByteLength() > 0 in here.

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8369 at r4 (raw file):

            JavascriptError::ThrowRangeError(scriptContext, JSERR_InvalidTypedArrayIndex);
        }
        (this->*LdArrFunc[playout->ViewType])(index, playout->Value);

The call to this function will do an additional check. If you can find a clean way to avoid the additional check it would be nice.
Otherwise we'll leave it as a todo for perf optimizations

test/wasm/array.js, line 9 at r4 (raw file):

const moduleBytesView = new Uint8Array(blob);
var a = Wasm.instantiateModule(moduleBytesView, {}).exports;
print(a["goodload"](0));

Could you please test the following cases
a.goodload(65535) == 0
a.goodload(65536) => trap
// Add gootstore method
a.goodstore(0) == 0
a.goodstore(65535) == 0
a.goodstore(65536) => trap
Could you also add a few cases with 32bits load/store

Comments from Reviewable

    // any access below 0x10000 is safe

this is not true in wasm. WebAssembly memory can be any number of pages.

Refers to: lib/Backend/Lower.cpp:8847 in e15956a. [](commit_id = e15956ad0da1db58e97d95d55155bdf31bae42fe, deletion_comment = False)

I think we should make AsmJsJITInfo::AccessNeedsBoundCheck return return true for WebAssembly so we don't fall in that case

Reviewed 3 of 3 files at r5.
Review status: all files reviewed at latest revision, 7 unresolved discussions, some commit checks failed.

lib/WasmReader/WasmByteCodeGenerator.cpp, line 1129 at r5 (raw file):

    {
        // todo:: make that an out of bounds trap
        m_writer.EmptyAsm(Js::OpCodeAsmJs::Unreachable_Void);

We should add Js::OpCodeAsmJs::MemOutOfBoundsAccess and emit this instead.

lib/WasmReader/WasmByteCodeGenerator.cpp, line 1146 at r5 (raw file):

    if (offset >= m_module->GetMemory()->maxSize)
    {
        throw WasmCompilationException(_u("Index is out of bounds"));

I don't think this is by spec. If the previous instruction have side effect we should still trap only when we reach this load/store.
Additionally, maxSize is a page count, thus if you want to add this, you need to multiply by PAGE_SIZE.
Be careful with overflow if you do multiply by page size however .
Put this check with if (m_module->GetMemory()->minSize == 0) above

Comments from Reviewable

Reviewed 3 of 3 files at r6.
Review status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

lib/WasmReader/WasmByteCodeGenerator.cpp, line 1128 at r6 (raw file):

    if (m_module->GetMemory()->minSize == 0)
    {
        throw WasmCompilationException(_u("Index is out of bounds"));

This is wrong, the function is not invalid, but we need to trap accordingly if this happens.
This check is an optimization so we should emit an opcode that will trap instead.

Comments from Reviewable

Review status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8365 at r4 (raw file):
Previously, Cellule (Michael Ferris) wrote…
> @MikeHolman Do you think there is a better way to check this case.
> We need to trap if you are trying to access `mem[65533]` for a int32 with the max length being `65536`.
> However, I would really to find a way to avoid 2 checks.
>
> The only thing I can think of is
> `if (index > arr->GetByteLength() - TypeToSizeMap[playout->ViewType])`
> Since we should trap on every memory access if there is no memory, then `arr->GetByteLength() > 0` in here.
>

Should just be able to do check `if(index + TypeToSizeMap[playout->ViewType] > arr->GetByteLength())`, right?

Comments from Reviewable

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8365 at r4 (raw file):
Previously, MikeHolman (Michael Holman) wrote…
> Should just be able to do check `if(index + TypeToSizeMap[playout->ViewType] > arr->GetByteLength())`, right?

Eh, maybe I'm wrong. I guess we need to consider case where that overflows uint32. (existing code doesn't work for that either though). as for length 0, we will have to check at runtime, as you can start with no memory or memory of size 0 and using grow memory or have a memory import. therefore, this needs to be a runtime check and cannot be assumed from time of bytecode gen

Comments from Reviewable

Review status: all files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.

lib/Runtime/Language/InterpreterStackFrame.cpp, line 8365 at r4 (raw file):
Previously, MikeHolman (Michael Holman) wrote…
> Eh, maybe I'm wrong. I guess we need to consider case where that overflows uint32. (existing code doesn't work for that either though). as for length 0, we will have to check at runtime, as you can start with no memory or memory of size 0 and using grow memory or have a memory import. therefore, this needs to be a runtime check and cannot be assumed from time of bytecode gen

yeah you're right for length 0.
the current check is correct since we check first if the index >= buffer length. We know the buffer cannot reach max uint32 (we would throw out of memory way before that) so it is safe to add a small value for the second check.
I was just hoping to avoid having 2 checks.

Comments from Reviewable

LGTM after minor fixes and rebase on master

Done. Thanks @Cellule  and @MikeHolman.


Stubs of __stack_chk_guard and __stack_chk_fail are not required for NIOS2

In libspdm/unit_test/test_size/intrinsiclib/compiler_stub.c, __stack_chk_guard and __stack_chk_fail are stubbed and in its CMakeLists.txt, compiler_stub.c is compiled for all toolchains. I believe that the purpose of stub is to bypass the actual function due to some compiler limitations but we shouldn't include that to all compliers.
When the stub functions are compiled with NIOS2, compilation error below are observed:
_warning: unable to reach __stack_chk_guard (at 0xa6b68) from the global pointer (at 0xb7458) because the offset (-67824) is out of the allowed range, -32678 to 32767
collect2: error: ld returned 1 exit status
make[1]: *** [lcd_build.mk:113: out/lcd_firmware.elf] Error 1
make[1]: Leaving directory '/nfs/site/disks/swuser_work_tzeyeeng/LCD/git_dev_lcd_fw/p4/applications.fpga.configuration.firmware.top/ssm/lcd/lcd_firmware'
make: *** [Makefile:102: out/lcd_firmware.elf] Error 2_
From the error, it seems like the stub functions cause the stack overflow happen. If we exclude compiler_stub.c from NIOS2 compilation, -fstack-protect-strong is working and the compiler is able to generate the binary with the correct stack guard. If we stub it out, it seems like bypass the stack check guard and keep using the memory until it overflow.
Please create an if condition in intrinsiclib/CMakeLists.txt to exclude compiler_stub.c from NIOS2 compilation.

@tzeyeeng libspdm/unit_test/test_size/ is just unit test for size testing. Please don't include it directly in your production code.
You may create your own version for NIOS2 environment.

@jyao1 I consulted with Longlong, this intrinsiclib is included in RPB production code. He advised us to adhere precisely to the same list of libraries in LCD production FW. So we just follow RPB FW to include intrinsiclib in spdm-device/CMakeLists.txt.
https://github.com/intel-innersource/firmware.security.tdx.rpb.rpbspdm/blob/e281463b16131d89cf17408843fbe2443a61d9fa/spdm-device/CMakeLists.txt#L307C5-L307C91
To minimize the delta between RPB and LCD, we would like to remain the library list in spdm-device/CMakeLists.txt, but only exclude intrinsiclib/compiler_stub.c from intrinsiclib compilation if toolchain = NIOS2.


Ignore Readline screen size detection when no TTY is present

Describe the change
Ignore Readline screen size detection when no TTY is present.
Why are we doing this?
To fix issue https://github.com/piotrmurach/tty-screen/issues/15. It's causes failures when running fastlane on Windows, see this fix.
Benefits
Method size will return sane defaults instead of [1,1] when called without TTY on Windows.
Drawbacks
Risk of breaking functionality for users that rely on existing behavior.
Requirements

[X] Tests written & passing locally?
[X] Code style checked?
[X] Rebased with master branch?
[ ] Documentation updated?
[ ] Changelog updated?

Thank you for this PR!
I decided to approach this slightly differently and added a few tests to cover all the edge cases in https://github.com/piotrmurach/tty-screen/commit/e342f8ff7535867d0630e393578131e1b946d8c4


Project: Determine schema for relational database

We need to determine a schema for our relational database before moving forward with it. I propose the following tables:
project
This is the table that will maintain most of the information on the project

Column Name
Type
Nullable?
Misc

project_id
INTEGER
No
PK

name
TEXT
No
Unique Index

description
TEXT
No

channel_id
INTEGER
No
Unique Index

role_id
INTEGER
No
Unique Index

approved_by_id
INTEGER
No
Discord ID of project approver

announcement_msg_id
INTEGER
No
Discord ID of the message in the announcement channel

submitted_timestamp
INTEGER
No
Unix Timestamp

approved_timestamp
INTEGER
No
Unix Timestamp

last_modified_timestamp
INTEGER
No
Unix Timestamp

project_state
This table will maintain the state of the project i.e. if it's in IC, GB, or Completed, and when those state changes were made. It will have a one-to-many relationship with the project table

Column Name
Type
Nullable?
Misc

state_id
INTEGER
No
PK

project_id
INTEGER
No
FK(project.project_id)

state
TEXT
No
IC/GB/Completed - maybe store as an int and use an enum in code?

timestamp
INTEGER
No
Unix Timestamp

user
The main purpose of this table would be to allow a many-to-many relationship with the project table. I'm not sure what else we'd want to store here, so I'm open to ideas.

Column Name
Type
Nullable?
Misc

user_id
INTEGER
No
PK

discord_id
INTEGER
No
Unique Index. Discord ID of the user

project_user_link
This is the link table to allow for the many-to-many relationship between users and projects. My thought process behind this is to allow for multiple project runners per project, rather than one, which is what we currently support.

Column Name
Type
Nullable?
Misc

project_user_link_id
INTEGER
No
PK

project_id
INTEGER
No
FK(project.project_id)

user_id
INTEGER
No
FK(user.user_id)

Perhaps we want some field in the project table for how many people have the role? To do this we would need to change how we assign roles.

Perhaps we have a table for project updates as well? We could store updates and return them with project info, and only allow runners to submit updates for a project via slash commands.
project_update

Column Name
Type
Nullable?
Misc

project_update_id
INTEGER
No
PK

user_id
INTEGER
No
FK(user.user_id)

project_id
INTEGER
No
FK(project.project_id)

description
TEXT
No

timestamp
INTEGER
No
Unix Timestamp


Server Side Subscription dropping invocations (suspected parallelism issue)

 Issue by mattfysh
Saturday Aug 26, 2017 at 08:17 GMT
Originally opened as https://github.com/graphcool/api-bugs/issues/243

What is the current behavior?
An SSS Function has dropped an invocation when 3 applicable mutations occurred within quick succession of one another. The SSS Function was invoked only twice.
A similar SSS Function which also triggers when the same object type is updated successfully triggered three times.
The average duration for the Function which dropped an invocation is ~2000ms
And the average duration for the Function which was successfully invoked all 3 times is ~500ms
Please share the relevant part of your GraphQL schema and all functions, permissions or other project settings for easier reproduction
This does not appear to be a project-related issue.
If applicable, share the query, mutation or subscription for reproduction
For the SSS Function that only triggered twice:
subscription {
  MyType(filter: {
    mutation_in: [UPDATED]
    node:{
      status:NEWVALUE
    }
  }) {
    node {
      id
    }
  }
}

For the SSS Function that triggered three times:
subscription {
  MyType(filter: {
    mutation_in: [CREATED, UPDATED, DELETED]
  }) {
    node {
      id
    }
  }
}

What is the expected behavior?
The SSS Function should have been invoked once per mutation

 Comment by marktani
Saturday Aug 26, 2017 at 09:59 GMT

Thanks for the bug report! Can you show the according mutation?

 Comment by mattfysh
Saturday Aug 26, 2017 at 10:01 GMT

mutation UpdateStatus($id: ID!) {
  updateMyType(id: $id, status: NEWVALUE) {
    id
  }
}

@mattfysh To help narrow down the issue - how did you verify that the function had been triggered only 2 times instead of 3?

By inspecting the logs in the Graphcool console
By observing calls to an external system

Hey @sorenbs - by inspecting the logs (this is also how I noticed the other function had triggered 3 times)

In addition, the function creates a conversation on Intercom. Only 2 conversations were created instead of 3

I was not able to reproduce this @mattfysh, do you still experience this issue?

Since it's a suspected race condition, I don't expect this will be 100% reproducible. Is it possible to have an engineer do a bottom-up investigation into this? I am happy to give them access to my account where this happened


User Admin - Filter by role

In applications with a lot of different user roles, it would be useful to have the option to filter users by user role.

There is now a filter input in the admin view which filters out user where either the email address or some role includes the search term. https://github.com/GEOLYTIX/xyz/commit/f6132a3ddcae554a5f87355deb8b991535db0064


Update 11-heartrate.py

Added callbacks for channel search time-out and channel closed.
Wrapped most of the ANT setup in exception block.
Replaced old string variable substitution with "f" strings.

The code in here works, but there's an additional change needed in order for it to be fully correct.  Specifically, in the last couple of lines of 11-heartrate.py, you need to change hr.close() to heartRateMonitor.close() since you renamed the variable.

Thanks! I knew I'd forget something :)

Looks good, I'll find my ant adaptor tonight and merge it as soon as I can test it.


CrossSecureStorage not working in iOS

after resent  update  CrossSecureStorage is not able to save value  through CrossSecureStorage plugin

Can you please post an issue at the github repo: https://github.com/sameerkapps/SecureStorage/tree/master/SecureStorage


[Bug] DIC not descrambling data found in pregap of track 1

Version
20211101
Describe the bug
DIC is not descrambling data found in the pregap of track 1. There are data sectors (as seen in the mainInfo log), but DIC doesn't descramble them, only moves the SCM to IMG. Line 759 of https://github.com/saramibreak/DiscImageCreator/blob/master/DiscImageCreator/execScsiCmdforCD.cpp seems to indicate that CD's with data in their first track pregap should be descrambled in this case.
Disc title
Any disc with data in the track 1 pregap should exhibit this, but my specific disc is "Star Wars: Shadows of the Empire"
Disc ringcode
All the string that is written the inner of the disc (IFPI etc.)
URL
Tell me the link to get the disc.
Amazon:
eBay: https://www.ebay.com/itm/203591334664
discogs:
Log file
Star Wars - Shadows of the Empire Soundtrack Logs.zip

I did a little digging into this as I was trying to understand the issue. I found the following:

In https://github.com/saramibreak/DiscImageCreator/blob/7686bc1718ac6daa84362f2d6599f1ac08bd69f8/DiscImageCreator/set.cpp#L271 (Line 271), discs that aren't CD-i are processed.
In that block, it does check for pregap data, as would be expected
However, the if block following seems to make an assumption: if trkType == TRACK_TYPE::dataExist then trkType = TRACK_TYPE::pregapDataIn1stTrack and for everything else trkType = TRACK_TYPE::pregapAudioIn1stTrack
The above assumption would work for the majority of discs. However, the disc above has Track 1 marked as "Audio", so it ends up setting trkType = TRACK_TYPE::pregapAudioIn1stTrack erroneously

All of this combined leads to the logic in https://github.com/saramibreak/DiscImageCreator/blob/6451ff92b402baf4cd674d4b891246c488567570/DiscImageCreator/execScsiCmdforCD.cpp#L759 to skip over descrambling the pregap entirely.

I did a little digging into this as I was trying to understand the issue. I found the following:

In https://github.com/saramibreak/DiscImageCreator/blob/7686bc1718ac6daa84362f2d6599f1ac08bd69f8/DiscImageCreator/set.cpp#L271 (Line 271), discs that aren't CD-i are processed.
In that block, it does check for pregap data, as would be expected
However, the if block following seems to make an assumption: if trkType == TRACK_TYPE::dataExist then trkType = TRACK_TYPE::pregapDataIn1stTrack and for everything else trkType = TRACK_TYPE::pregapAudioIn1stTrack
The above assumption would work for the majority of discs. However, the disc above has Track 1 marked as "Audio", so it ends up setting trkType = TRACK_TYPE::pregapAudioIn1stTrack erroneously

All of this combined leads to the logic in https://github.com/saramibreak/DiscImageCreator/blob/6451ff92b402baf4cd674d4b891246c488567570/DiscImageCreator/execScsiCmdforCD.cpp#L759 to skip over descrambling the pregap entirely.

@SilasLaspada
Is this not CD-i Ready? What is the platform of disc?

@SilasLaspada
Is this not CD-i Ready? What is the platform of disc?

This disc is not CD-i Ready. This disc is an audio CD that has an ISO9660 partition in the pregap of track 1.

This disc is not CD-i Ready. This disc is an audio CD that has an ISO9660 partition in the pregap of track 1.

Test, plz.
DiscImageCreator_test.zip

No change in the dump, the image hash is the same as when dumping with the "normal" version of DIC.

Is there logs?

Here:
Test build logs.zip

Fixed
DiscImageCreator_test.zip

Interesting results this time, it seems to descramble the sectors, but it says "[ERROR] Number of sector(s) where user data doesn't match the expected ECC/EDC: 57396". Logs:
Test build logs 2.zip

Uploaded
DiscImageCreator_test.zip

The image dumped again has the same hashes, but this time I see that DIC attempted and failed to descramble the image. From the command window:
Copying .scm to .img
LBA[-1947749405, 0x8be7b3e3]: Failed to read [F:DescrambleMainChannelAll][L:1794]

The command window also has the text:
LBA[066562, 0x10402]: [F:ReadVolumeDescriptor][L:538]
        Opcode: 0xa8
        ScsiStatus: 0x02 = CHECK_CONDITION
        SenseData Key-Asc-Ascq: 05-64-00 = ILLEGAL_REQUEST - ILLEGAL MODE FOR THIS TRACK
lpCmd: a8, 00, 00, 01, 04, 02, 00, 00, 00, 01, 00, 00
dwBufSize: 2048
Reading Partition Map 2/2

It didn't have this text in previous dumps. Also, I recently discovered that this disc has both an ISO9660 and an HFS partition. Logs: Test build logs 3.zip

Some fixed.
DiscImageCreator_test.zip

Newest build makes identical dump, this time seemingly with no attempt to descramble. This time, it says
Reading DirectoryRecord    3/   3

Instead of the partition map message. Logs:
Test build logs 4.zip

Fixed again (incl partition map message)
DiscImageCreator_test.zip

This dump seems better! The partition map message doesn't show up, but the dump does actual descramble, with no errors present! Logs:
Test build logs 5.zip

The partition map message doesn't show up

Sorry and thanks all testing.
DiscImageCreator_test.zip

Alright, both the "Reading directories" and partition map messages show up, and the data seems to be descrambled! One last thing I'm wondering, is everything write offset wise accounted for since the data on the disc isn't immediately visible? Logs:
Test build logs 6.zip

is everything write offset wise accounted for since the data on the disc isn't immediately visible?

What do you mean?

Well since a normal audio CD can't have its write offset known, but a CD with data on it can. I just wanted to be sure DIC takes into account the write offset using the data in the pregap.

DIC takes into account the write offset using the data in the pregap.

Yes. Data sector has an address called by MSF. Your disc has it.
04F0 : C3 5A D1 FB 1C 43 49 F1  F6 C4 CD 43 B9 5F A5 24   .Z...CI....C._.$
0500 : 00 FF FF FF FF FF FF FF  FF FF FF 00 01 82 00 61   ...............a
0510 : 45 7A 02 1E 80 0B 1E 74  A8 02 FE 81 80 60 60 28   Ez.....t.....``(

01 82 00 is descrambled to 00 02 00. This indicates the 1st sector of the data. Combined offset is 0500h and it's 1280 bytes.
	 Combined Offset(Byte)   1280, (Samples)   320
	-   Drive Offset(Byte)    392, (Samples)    98
	----------------------------------------------
	       CD Offset(Byte)    888, (Samples)   222

As the result, your disc offset is 222.


Export of all moldev resources

Export  all moldev resources  with required fields

Hi @mhaack
Here is the export sheet for the resources including extra fields.  I have excluded Citations from this list as data already provided for these and no pending information is there.
franklin-resources-full-export.xlsx


Build(deps-dev): Bump lint-staged from 12.4.2 to 12.4.3 (#3561)

Pull request opened by the merge tool on behalf of #3561

Merged in cefc4328aab210b747b0def10b066249766f2a0e


Guest Executable  Ctrl + C not being fired by SF

Thankyou for pointing me to the location of the exit codes directly.    And so onto the next issue.
Given a guest executable what actions instigate an exit code  of 7147 (Graceful exit)
I want to use this to help signal shutdown and then manage gracefully cleaning up resources.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f541a9f9-4be2-9537-5f94-bbfa02cf72ca
Version Independent ID: c44b249f-243f-6a2d-fd34-9a8497102076
Content: Diagnose common code package errors by using Service Fabric
Content Source: articles/service-fabric/service-fabric-diagnostics-code-package-errors.md
Service: service-fabric
GitHub Login: @grzuber
Microsoft Alias: grzuber

^^ To add as Ctrl-C DOES not work....

@colindooley11 Thanks for your question.
You can gracefully shutdown or run some cleanup tasks when a service is being shutdown in service fabric.
You need to hook your cleanup or any other functions by adding them on the calling sequence.
Please go through this document which speaks about the list of functions which are called when a service is shutting down.
There is a similar MSDN thread  in which i asked asked the internal teams ans answered it.
Please let me know if you need more information

Thanks for getting back.
This specifically relates to apps which are not guest executables and rely on the Service Fabric SDK.
I need to know if graceful shutdown is supported for Guest executables specifically.
To be more clear this is for a console app based guest executable which has NO references to any Service Fabric typesAnd therefore we can not use them.
Sent from Yahoo Mail on Android
On Fri, 23 Aug 2019 at 13:26<EMAIL_ADDRESS>wrote:
@colindooley11 Thanks for your question.
You can gracefully shutdown or run some cleanup tasks when a service is being shutdown in service fabric.
You need to hook your cleanup or any other functions by adding them on the calling sequence.
Please go through this document which speaks about the list of functions which are called when a service is shutting down.
There is a similar MSDN thread in which i asked asked the internal teams ans answered it.
Please let me know if you need more information
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@MicahMcKittrick-MSFT
Hi All,
I upgraded the Service Fabric SDK and Runtime last week and this has solved the issue.  Everything seemed to work just fine once I had done this.
I can't say for sure but my colleagues have been running different versions and didn't experience the issues I had, so I can only put it down to some kind of mis-configuration locally.

Below is what I am running locally now (I didn't check the previous version)
Service Fabric SDK and Tools 3.4.664
Service Fabric runtime 6.5.664
Visual Studio 2017 15.9 includes Service Fabric Tools for Visual Studio 2.4.11024.1

Thanks @colindooley11 for sharing the update. I am glad that your issue is resolved. Please let us know here if you see the same behavior again. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.