Fix URL scheme for code actions

Neovim client raise an error because server does not return an URI scheme file:///
Error executing vim.schedule lua callback: /usr/share/nvim/runtime/lua/vim/uri.lua:107: URI must contain a scheme: /home/pedro/Desktop/learning-rescript/src/let_binding.res
stack traceback:
        [C]: in function 'assert'
        /usr/share/nvim/runtime/lua/vim/uri.lua:107: in function 'uri_to_fname'
        /usr/share/nvim/runtime/lua/vim/uri.lua:128: in function 'uri_to_bufnr'
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:570: in function 'apply_text_document_edit'
        /usr/share/nvim/runtime/lua/vim/lsp/util.lua:828: in function 'apply_workspace_edit'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:803: in function 'apply_action'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:857: in function 'on_choice'
        /usr/share/nvim/runtime/lua/vim/ui.lua:54: in function 'select'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:868: in function 'on_code_action_results'
        /usr/share/nvim/runtime/lua/vim/lsp/buf.lua:886: in function 'callback'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1952: in function 'handler'
        /usr/share/nvim/runtime/lua/vim/lsp.lua:1383: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

@aspeddro did you test this in VSCode as well?

Yes, everything working.

Looks like there's still conflicts. Happy to merge after they're fixed.

Conflicts resolved.


New patch version release

The EdDSA library that was updated in #6 includes the encoding and decoding of EdDSA keys, so releasing a new version of this library would pull in that functionality.

I'll try to find some time over the weekend!

Any assistance needed to complete this?

I released version 1.0.2. Please give it a try and let me know if everything works as expected.
I'm sorry for the long delay!


Add support for Browserify

It's not possible to include the library using require('angular-applicationinsights'); in combination with Browserify and Gulp.
Returns error: "Error: Cannot find module 'angular-applicationinsights'".

All you need is a main entry point in the package.json, or perhaps use the browser field.
Like this:
"main": "build/angular-applicationinsights.min.js",

Have verified this loads the file correctly, but not verified if it actually works when embedded like this.
Could you also please include both minified and unminfied files with the npm package?

Made a pull request for this change: https://github.com/khaines/angular-applicationinsights/pull/29

Thank you for that submission. It has been merged into the master branch.


GroupChoiceModal uses thunk for saving to trellis

Closes #1051
This is a refactor;  no functionality change expected.
Please review carefully;  I'm pretty sure I got it right but it's my first thunk.
Also wondering if GroupChoiceModal component tests adequately assert the appropriate plumbing methods are called

@jcoyne @jermnelson the changes I just pushed up should address both of your concerns.

Note that if PR #1111 is merged first, there should be one more update.

@jcoyne @justinlittman more changes ... are we done yet?  :-)


undeclared EVP_CTRL_GET_IVLEN

When building with Ubuntu 18.04 OpenSSL (libssl-dev Version: 1.1.1-1ubuntu2.1~18.04.6), an error is triggered
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.tools -I/usr/lib/x86_64-linux-gnu/include -I/quickassist/include -I/quickassist/include/lac -I/quickassist/lookaside/access_layer/include -I/usr/local/include -I//usr/include -fPIC -Wall -Wformat -Wformat-security -O2 -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-strict-overflow -fno-delete-null-pointer-checks -fwrapv -DOPENSSL_ENABLE_QAT_UPSTREAM_DRIVER -DOPENSSL_MULTIBUFF_OFFLOAD -DOPENSSL_IPSEC_OFFLOAD -DOPENSSL_DISABLE_QAT_RSA -DOPENSSL_DISABLE_QAT_CIPHERS -DOPENSSL_DISABLE_QAT_ECDH -DOPENSSL_DISABLE_QAT_ECDSA -DOPENSSL_DISABLE_QAT_DSA -DOPENSSL_DISABLE_QAT_DH -DOPENSSL_DISABLE_QAT_PRF -DOPENSSL_DISABLE_QAT_HKDF -DOPENSSL_DISABLE_QAT_ECX -DOPENSSL_ENABLE_VAES_GCM -DOPENSSL_ENABLE_MULTIBUFF_RSA -g -O2 -MT vaes_gcm.lo -MD -MP -MF .deps/vaes_gcm.Tpo -c vaes_gcm.c  -fPIC -DPIC -o .libs/vaes_gcm.o
vaes_gcm.c: In function 'vaesgcm_ciphers_ctrl':
vaes_gcm.c:711:14: error: 'EVP_CTRL_GET_IVLEN' undeclared (first use in this function); did you mean 'EVP_CTRL_GCM_IV_GEN'?
         case EVP_CTRL_GET_IVLEN: {
              ^~~~~~~~~~~~~~~~~~
              EVP_CTRL_GCM_IV_GEN
vaes_gcm.c:711:14: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [vaes_gcm.lo] Error 1

It looks EVP_CTRL_GET_IVLEN  is not available in all OpenSSL 1.1.1 versions. Perhaps add a note or a configure check for it?
/cc @spoussa

@mythi  Yes the EVP_CTRL_GET_IVLEN  changes are introduced from OpenSSL 1.1.1d . And yes as you suggested we will check and add note or configure check for the same .

Notes added in the README Software requirement section in v0.6.5 release


minor fixes to java backend to improve correctness of #KSequence

Fixes an issue where KSequences inside a KApply inside a KSequence were not converted correctly, and a case where KSequences were incorrectly computed as sort KItem.

lgtm


Update wrt to latest keras version

Import errors fixed
initializations and layer_from_config from keras

See recurrentshop-1 branch.

I'm using the recurrentshop-1 branch and I still get the Import Error (but mine is worded slightly differently: ImportError: cannot import name 'initializers').  I'm using keras 1.2.2 .  Thanks for your help.

Update to Keras-2.


Code for perl output safety can be removed

There are file input blocks which contain exception handling for bad character encoding produced by the old Perl scripts. These scripts are no longer used so the handling can be changed to an assertion of non-occurrence.
ContextSource.java:
 public Int2DoubleMap readAll() throws IOException {
        Int2DoubleMap contextFrequenciesMap = new Int2DoubleOpenHashMap();
        while (this.hasNext()) {
            ContextEntry entry = this.read();
            if (contextFrequenciesMap.containsKey(entry.getId())) {
                // XXX: This shouldn't happen any-more, becaue perl is no longer used.
                //
                // If we encounter the same context more than once, it means
                // the previous stage has decided two strings are not-equal,
                // but the corrent stage thinks are equals
                // ... so we need to merge the records:

                final int id = entry.getId();
                final double oldFreq = contextFrequenciesMap.get(id);
                final double newFreq = oldFreq + entry.getWeight();

                LOG.log(Level.WARNING,
                        "Found duplicate context \"{0}\" (id={1}) in tailsdb "
                        + "file. Merging records. Old frequency = {2}, new "
                        + "frequency = {3}.",
                        new Object[]{stringIndex.get(id),
                        id, oldFreq, newFreq});

                contextFrequenciesMap.put(id, newFreq);
            }
            contextFrequenciesMap.put(entry.getId(), entry.getWeight());

        }
        return contextFrequenciesMap;
    }

Actually there is no good reason to remove this. It's a sensible resolution to a problem that could occur a number of ways. Note however that the above code contains an error, which has been resolved as of 85caf41a3dbf926d2d5b677c97e9ddb65d1057f5


Move cursor footnotes/references

Add new reference and footnote move caret to start of the new generated element in bottom page
Refer to already existent reference move caret after the generated reference anchor

Reference done.
Moving "update content" functions outside from the adding methods, is now possible moving caret where we want to, using:
tinymce.activeEditor.selection.select(tinymce.activeEditor.dom.select(CSS3_SELECTOR)[0])
tinymce.activeEditor.selection.collapse(false)


weird behavior in fish shell

minimal config
local actions = require("fzf-lua").actions
require("fzf-lua").setup({
    winopts = {
        split = 'belowright new',
        fullscreen = false,
        preview = {
            default = 'bat_native',
            horizontal = 'right:50%',
            vertical = 'down:50%',
            layout = 'horizontal'
        },
        on_create = function()
            vim.opt_local.buflisted = false
        end
    },
    keymap = {
        fzf = {
            ['ctrl-a'] = 'select-all',
            ['ctrl-d'] = 'deselect-all'
        }
    },
    fzf_opts = { ['--layout'] = 'default' },
    files = {
        cmd = 'rg --files --follow --smart-case --hidden --no-ignore -g "!{.DS_Store,.cache,venv,.git,.clangd,.ccls-cache}" 2> /dev/null',
        actions = {
            ['default'] = actions.file_edit,
            ['ctrl-x'] = actions.file_split,
            ['ctrl-v'] = actions.file_vsplit,
            ['ctrl-q'] = require('utils').qf_populate
        }
    },
    buffers = {
        actions = {
            ['default'] = actions.buf_edit,
            ['ctrl-x'] = actions.buf_split,
            ['ctrl-v'] = actions.buf_vsplit
        }
    }
})

files and buffers commands work perfectly (most of the time), there is some launch lag but Im satisfied with it for now. Sometimes after a fresh launch, I trigger the files keymap, and fish shell freezes. This freeze can be seen even in new terminal windows, and doesnt go away till you exit/wait.
live_grep, live_grep_native, grep all show weird lag most of the time, which I presume is caused by the same fish-freeze issue. Results dont show up and the screen freezes. When you do something like ctrl-c or :q on that grep split/window, command exits, but leaves a terminal buffer open. And any calls you make after that to fzf-lua, dont follow window configs, and even crash vim sometimes

Investigation:

the lag is better in zsh, but still there

Related feature-requests:

the split/windows should be nobuflisted and bufhidden="wipe". We can achieve this currently using the on_create config. This would solve the bug where you can jump back into the closed terminal buffer using o (ie fzf-lua windows end up in the jump list right now)

https://github.com/ibhagwan/fzf-lua/commit/62937db2dbfb34639d8da61c595c7d33bf7c8769
The above commit orces fzf to run within the confines of sh -c, it's very possible this can solve the issue - can you try and let me know?
Before pushing this change I did install fish and tried on my machine with vim.opt.shell = "/sbin/fish" with your exact setup, weirdly enough everything works fine.
Hopefully the above commit solves your issue but just in case, I have a few questions that may help get to the bottom of this:

What is your nvim --version?
What is your fish --version?
Are you on Linux/Mac?

Is it possible this issue is related to something in your config? would you be willing to try with this minimal init.lua?
Even better if you can try with the official 0.5.1 release appimage.

FYI to anyone reading, this turned out to be a different issue, myself and @ViRu-ThE-ViRuS tried to run a simple shell script that does almost exactly what live_grep (in the shell, not in neovim) and the fzf reload command was failing and printing "pyenv: cannot rehash: {HOME DIR}/.pyenv/shims/.pyenv-shim exists" after a huge delay.
After uninstalling pyenv fzf change:reload started working properly and fzf-lua started working as well.
I'll leave it for @ViRu-ThE-ViRuS  to add any commentary after he investigates what was happening on his machine :-)

Like commented above,
it turned out that FZF was stuck processing shim folders inside $HOME/.pyenv which caused it to stall and often exit with weird exit codes. Solution includes fixing pyenv installs, adding the dir to FZF ignore rules, or just uninstalling pyenv.
Huge thanks to @ibhagwan, this man is a beast!


Resizing or zooming sankey diagram

What problem does this feature solve?
Hello I have a sankey diagrams with 200 nodes coming from a graph database.
The properties for most of the nodes are unreadable in the chart.
I wanted to know if possible there is something to do around the chart layout size or if it is possible to add a feature to zoom the chart (with the mouse)
Thanks
What does the proposed API look like?
It could be a feature added in the options

@lbois sankey chart doesn't support zooming. What do you expect from zooming?

Adding to this, I would expect the zooming to work similarly to the existing dataZoom functionality.
In the example above, you would be able to only show part of the horizontal axis, say 10 nodes, and then move left or right to traverse the data.
Personally, it would be useful for me to understand the flow of something that is quite long.

zooming would mean:

zoom-in --> double-click on a node --> the graph now displays only the node and all its children
zoom-out --> double-click outside a node --> the graph now displays the complete sankey tree again

this would be quite helpful indeed. is there any quick way to implement this ?


Add libmad debian patches, fixing memory overflow issues.

Added md_size.patch length-check.patch
They are uses in the debian package to fix This bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=287519
See also https://github.com/mixxxdj/mixxx/pull/11528

@JoergAtGithub I have added the Debian patches to the 2.3 build environment. They apply cleanly, so there should be no risk.

I tested the identical patch in the 2.4 PR #66. There it solved the the issue from https://github.com/mixxxdj/mixxx/issues/11521.

It seems upstream contains these patches now and we no longer need this overlay: https://github.com/microsoft/vcpkg/pull/35898


Bluetooth: host: Only reserve EATT header bytes for EATT enabled channels

Don't reserve extra EATT header bytes for non EATT enabled channels.
2 bytes of the net_buf were reserved for no reason in un-enhanced ATT channels. Effectively allowing it to carry two less bytes in unenhanced ATT.

Could you add a test for this somehow?
Demonstrating that you can in fact add two more bytes when sending over UATT.

I believe this change will introduce an ATT_MTU violation.
Reverse engineering reveals a complicated reason for the reservation of the two bytes. My reasoning follows in the bullet points below. I think it may take more effort to fix this issue without introducing bugs or worse behavior. Please take this comment as lighthearted. Reverse engineering legacy code requires some humor.
I'm not disagreeing with your intention, but we need to strut up the house-of-cards in a few more places to be structurally sound.

The local ATT_MTU is set to values that differ by 2 for UATT and EATT. This is to be much optimal, since an UATT PDU has 2 bytes less overhead than EATT, and we use the same MPS size for both because they all allocate the same global buffers.

bt_att_create_pdu uses bt_att_chan_create_pdu with a specific bearer, but then just forgets about which bearer was selected and the PDU actually ends up on a connection-global queue.

When allocating an outgoing request or notification sized to just barely fit the UATT MTU, bt_att_create_pdu provides always the UATT bearer as argument to bt_att_chan_create_pdu.

With the change in this PR, it would then always fail to make the 2 byte reservation.

Linked lists encourage pre-pending. The att->chans list is thus in reverse order of bearer creation. And UATT bearers are always created first (because they are created when the ACL connection is established). Because the list of bearers list is iterated over for each attempt to send from the connection-global queue, the EATT bearers always are preferred.

The effect of bt_l2cap_chan_send_cb is complicated. If the buffer it's given has headroom for headers, it will zero-copy forward it to controller. But if the headroom is too small, it silently does something that should not be silent: It will helpfully allocate buffers and copy the data (leaving room for headers), and it will segment the SDU if needed, helpfully using even more global buffers. (BTW, don't take this as an exhaustive list of complicated things about bt_l2cap_chan_send_cb.)
does not symbolically equal

ATT_MTU is weird. It is not necessarily equal to the L2CAP TX MTU. So bt_l2cap_chan_send_cb does not enforce the ATT_MTU.

The end result is that bt_l2cap_chan_send_cb will happily send a SDU and split into two PDUs with the seconds PDU containing a measly two useful bytes. And  ATT_MTU for that channel is violated, if the wimpy PDU and two extra allocations were not enough.
I don't have a test for this yet. I hope I'm not wrong. I have seen the weird split SDUs before though. I can write a test tomorrow.

Thank you @alwa-nordic for taking the time to describe some of the finer details regarding this. Much appreciated!
As you probably gather my understanding here is not very complete and surely I had not realized that there was some sort of entanglement between EATT/UATT vs PDU creation and queueing.

Having looked a bit further into this I wonder:

Is it not such that bt_att_create_pdu iterates and finds the first channel that fits the payload, and passes this and info re. channel, thus actually ensuring that the PDU is handled on an EATT or UATT channel respectively?
Will process_queue() not ensure (because of get_first_buf_matching_chan()) that a given buf is handled by EATT or UATT channel?

Is it not such that bt_att_create_pdu iterates and finds the first channel that fits the payload, and passes this and info re. channel, thus actually ensuring that the PDU is handled on an EATT or UATT channel respectively?

I'm not seeing anything like this in the code. Was there some particular clue?

Will process_queue() not ensure (because of get_first_buf_matching_chan()) that a given buf is handled by EATT or UATT channel?

process_queue() will indeed select a specific channel. But it may choose a channel with an inappropriate ATT_MTU. This sounds to me like it could be fixed here by skipping channels if the ATT_MTU is too small. We just have to make sure we handle EATT channels disconnecting and leaving the stack with no channels big enough for the request.

Is it not such that bt_att_create_pdu iterates and finds the first channel that fits the payload, and passes this and info re. channel, thus actually ensuring that the PDU is handled on an EATT or UATT channel respectively?

I'm not seeing anything like this in the code. Was there some particular clue?
Isn't that what this does:

	/* This allocator should _not_ be used for RSPs. */
	SYS_SLIST_FOR_EACH_CONTAINER_SAFE(&att->chans, chan, tmp, node) {
		if (len + sizeof(op) > bt_att_mtu(chan)) {
			continue;
		}

		return bt_att_chan_create_pdu(chan, op, len);
	}

Will process_queue() not ensure (because of get_first_buf_matching_chan()) that a given buf is handled by EATT or UATT channel?

process_queue() will indeed select a specific channel. But it may choose a channel with an inappropriate ATT_MTU. This sounds to me like it could be fixed here by skipping channels if the ATT_MTU is too small. We just have to make sure we handle EATT channels disconnecting and leaving the stack with no channels big enough for the request.
Don't understand how it could choose a chan with wrong MTU? Will the channel not by 'create_pdu' be ok re. MTU?

#AutoPTS run zephyr GATT

Scheduled PR #https://github.com/zephyrproject-rtos/zephyr/pull/63865#issuecomment-1764440795 after 15:04:04.

AutoPTS Bot results:
Failed testsGATT    GATT/CL/GAR/BV-10-C             UNKNOWN VERDICT: Timeout. Adjust TSPX_time_guard value if user need more time.GATT    GATT/CL/GAR/BV-11-C             UNKNOWN VERDICT: Timeout.


chore: pin deps to minor

I wanna get less PRs from Greenkeeper.
Pinning to minor gives less stability, but probably results in less PRs from Greenkeeper. It's not really recommended but I'm doing it anyways 😎

:tada: This PR is included in version 4.2.2 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


when cscope not found, escaped ANSI control sequences in error message

Steps to reproduce
I'm doing something a bit weird, so this is possibly a PEBKAC. But here are steps to repro:

Open a C file in Vim
set csprg=/nonexistent/file
cs add blah.txt

Then you get an error message (correct), but the error contains fragments of ANSI escape sequences:

Text says E609: Cscope error: [?1002h[?25l[97m[41mcs_create_connection exec failed: No such file or directory.
vim --clean reverts the color scheme/style to default, but the ANSI sequences remain output.
Expected behaviour
Obviously this is non-critical, but I think the ANSI sequences are either (1) never meant to be appended to the message to begin with or (2) stripped before displaying it in the status bar.
Version of Vim
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 01 2022 00:00:00) Included patches: 1-348
Environment
OS: Fedora 36, uname -rms Linux 5.19.8-200.fc36.x86_64 x86_64
Shell: Zsh
Terminal: Gnome Terminal 3.44.1
$TERM: tmux-256color
Logs and stack traces
No response

I cannot reproduce this, to not get any error.  Did you start with "vim --clean"?

I could have sworn I did, but now that I try to follow the same steps I too cannot reproduce with --clean. Apologies for the noise.


.well-known folder headache

By default in Apache, all files, and folders who's names are preceded with a . are inherently NOT served.
This is for security reasons.. you know, because .htaccess, .htpassword etc should NEVER be reachable by outside web requests..
Forcing users to use folder names that are preceded by a [dot] would force them to open their server up, and expose these files, and folders.
I really think people need to rethink this, it's a terrible approach.

This is enforced by Let's Encrypt, so make sure to head over to their community to voice your concerns: https://community.letsencrypt.org/latest

This is enforced by Let's Encrypt, so make sure to head over to their community to voice your concerns: https://community.letsencrypt.org/latest

Please do a search of the community forum first and add to an existing thread. This has come up lots of times before. It's enforced by the baseline requirements that all browser trusted CAs must adhere to for HTTP-based domain validation. The use of .well-known is standardized in RFC5785 and many protocols (not just ACME) will be placing resources in this location.
I apologize about the difficulty but the decision stems from higher powers than Let's Encrypt or this client.

Thanks, I couldn't directly find anything on this subject! In any case, with the correct configuration this should not be a concern for anyone.

Thanks, I couldn't directly find anything on this subject! In any case, with the correct configuration this should not be a concern for anyone.

What is this correct configuration you speak of?


chat discord -> minecraft desen't work

so I inputted everything correctly I double checked and even regenerated the bot's token but it still doesn't wanna go online but the rest of stuff works fine

do you have a log for this?


Dropwizard reporting incorrectly enabled HTTPS protocols

The deafult Dropwizard behaviour seems to enable TLSv1.1 (despite the documentation stating that TLSv1.1 is in the excludedProtocols by default). It does also not match what is bieng logged by Dropwizard.
Steps to reproduce (using Dropwizard v.2.0.13):

Create a simple Dropwizard application. Add HTTPs configuration (do not set any values for supportedProtocols and excludedProtocols)
Start up server. Server logs indicate:
io.dropwizard.jersey.HttpsConnectorFactory: Enabled protocols: [TLSv1.2, TLSv1.3] io.dropwizard.jersey.HttpsConnectorFactory: Disabled protocols: [SSLv2Hello, SSLv3, TLSv1, TLSv1.1]
curl --tlsv1.1 https://localhost - this actually works (using curl version: libcurl/7.29.0, NSS/3.44)

Further proof:

Add a ServerLifecycleListener with the serverStarted method as: server -> LOGGER.info(Arrays.asList(server.getBean(SslContextFactory.class).getSelectedProtocols()))
This will print TLSv1.1, TLSv1.2 and TLSv1.3

Notes:

If I explicitly set excludedProtocols with TLSv1.1, it gets disabled.
TLS 1.1 may still fail due to the default cipher suites prevent an algorithm agreement - but that is besides the point - the protocol is still enabled.

@shahr Thank you very much for reporting this!
That's an interesting find. We do indeed add TLSv1.1 to the list of excluded protocols:
https://github.com/dropwizard/dropwizard/blob/v2.0.14/dropwizard-jetty/src/main/java/io/dropwizard/jetty/HttpsConnectorFactory.java#L289-L290
This list of excluded protocols is then set on the SslContextFactory when it's being created:
https://github.com/dropwizard/dropwizard/blob/v2.0.14/dropwizard-jetty/src/main/java/io/dropwizard/jetty/HttpsConnectorFactory.java#L811-L813
A test like the following also dumps the correct selection of included and excluded protocols:
@Test
public void testDefaultExcludedProtocols() throws Exception {
  HttpsConnectorFactory factory = new HttpsConnectorFactory();
  factory.setKeyStorePassword("password"); // necessary to avoid a prompt for a password

  SslContextFactory sslContextFactory = factory.configureSslContextFactory(new SslContextFactory.Server());
  sslContextFactory.dump(System.out, "");
}

Output:
Server@13526e59[provider=null,keyStore=null,trustStore=null] - STOPPED
+> trustAll=false
+> Protocol Selections
|  +> Enabled size=2
|  |  +> TLSv1.2
|  |  +> TLSv1.3
|  +> Disabled size=4
|     +> SSLv2Hello - ConfigExcluded:'SSL.*'
|     +> SSLv3 - ConfigExcluded:'SSL.*' JVM:disabled
|     +> TLSv1 - ConfigExcluded:'TLSv1'
|     +> TLSv1.1 - ConfigExcluded:'TLSv1\.1'

And yet, any SslEngine created by this SslContextFactory will show TLSv1.1 in SslEngine#getEnabledProtocols(). 🤔

Yes, thank you for verifying - I was surprised by this because a cursory look at the code seemed like everything was configured correctly. For context, I was creating a verification that ensured servers were only using TLSv1.2 and when testing this I oddly discovered that the 1.1 protocol was still enabled.
I'm a bit time bound at the moment, but will try take a look into this a bit deeper to try understand where TLS 1.1 is bieng re-enabled.

As a side note - is it worth changing the logging to use SslEngine#getEnabledProtocols() (including cipher suites) to represent the  real SSLEngine configuration?

This seems to be rooted in an inconsistency between SslContextFactory#dump() and which protocols are really selected in the built SSLContext and SSLEngine instances.
I've filed a bug report with the Jetty project for this:
https://github.com/eclipse/jetty.project/issues/5531

This explains why it seemed to be behaving correctly when I explicitly set the excludedProtocol list without using the regexp.
Thank you.


When build aws-sdk-cpp, got "Unknown CMake command "aws_use_package"

Confirm by changing [ ] to [x] below to ensure that it's a bug:
I've gone though Developer Guide and API reference
I've searched for previous similar issues and didn't find any solution

The same problem as #1770, but I have Linux, and now Windows.
That's how I build it:
cmake ../ \
    -DCMAKE_INSTALL_PREFIX=$PREFIX \
    -DCMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES=$PREFIX/include \
    -DCMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES=$PREFIX/include \
    -DCMAKE_BUILD_TYPE=Release \
    -DCUSTOM_MEMORY_MANAGEMENT=OFF \
    -DBUILD_ONLY="s3"

I use this: github.com/aws/aws-sdk-cpp/archive/1.9.144.tar.gz as the source code.
I've read the comment about the submodule, but I wuld like to build it from the source code archive

@chubin,
So, because of the way we are consuming our dependencies with github submodules, the recommended way is to use git clone --recursive to get the SDK and it's dependencies.
Not being able to build directly from the zip file is a known issue for us and something we are working on fixing, but on the mean time we do have a sort of workaround in the form of a building script: prefetch_crt_dependency.sh , try running it before building the SDK, and let me know if it works for you.

In my environment, I don't have Internet access during the build time, and so it is not really an option to me.
In general, it is a good approach to have everything in the "input" archive/directory/whatever, just to be able
to reproduce the build anytime. Maybe you have some other archive, where you have all the submodules inside?

Do not use prefetch_crt_dependency.sh to fetch the dependencies!
This script seems to fetch outdated dependencies, and the whole project does not compile.
If you fetch the actual dependencies with git clone --recurive, everything works

@chubin, can you specify which dependencies you had a problem with? Like what error did you get when running the prefetch_crt_dependency.sh script?

When I use the script, I have exactly the problems as in #1795.
When I don't use the script, and checkout with git --recursive, everything just works.

@chubin , and are you using gcc 11 as well?

Yes, I am using GCC 11.2

oh then yea the script is probably out of date, I'll see about getting that fixed, thanks.

Please have a look for updated prefetch_crt_dependency.sh at PR https://github.com/aws/aws-sdk-cpp/pull/1814


Changes to better reflect Java Calendar API

Changed to 24h API → use HOUR_OF_DAY
Changed DATE (DAY_OF_MONTH) to start at 1 (not zero based like month)
Fixed tests to reflect new api

This is an opinionated better usage of the api which adresses https://github.com/hotchemi/khronos/issues/13

Seems there must be some locale specific configuration be done. I will investigate it further...

Thx! Let me check later.


add org-ids to elasticsearch mapping #13

Adds an array of org-id formatted (i.e. prefixed) strings for present charity numbers and company numbers.
Also displays this in the site with a link to http://org-id.guide/about.
#13

Fixed some problems I had inevitably created with the previous commit.


undefined method `+' for nil:NilClass

Following this: http://apionrails.icalialabs.com/book/chapter_three
After login I get this:

NoMethodError in SabisuRails::ExplorerController#index
undefined method `+' for nil:NilClass

 Extracted source (around line #1532):
        address() + (port == HTTP.https_default_port ? '' : ":#{port()}")
      else
        address() + (port == HTTP.http_default_port ? '' : ":#{port()}")
      end
    end

I added the 'config.base_api_uri = "api.marketplaceapi.dev" to the config file. Not sure where to even begin/:

I think this is related to devise new IPaddress attribute for users...

I forgot I posted this. It was a silly mistake on my end. My b


os/sdk: document using cork as an option

cc @crawford

Might be good to document that cork create and cork enter want to sudo.

Addressed comments.


Change cookie cutter variable name: aws_devops_profile

I feel that this variable: aws_devops_profile is not explanatory, as it is an IAM user name from aws, so I propose that we change the variable to reflect it's actual value (unless I am mistaken on it's purpose):
aws_iam_username

@danielfrojd I'll just start with adding some clarification on what aws_devops_profile actually does, it's a special IAM that has access both to prod and stage buckets, which allows it to sync replication data between environments on AWS. I see it as some sort of enhanced user where you, in the future, might add more capabilities that you dont want to add to the regular users, devops reflects this, kind of.
Regarding the name, I think aws_iam_username is a little bit confusing, since this is not the only IAM we keep around in a django project, besides the devops profile we use one IAM for each server environment (stage/prod). The only difference is that the credentials for devops is that it's credentials are stored locally to be used by the developer through awscli.
How about aws_devops_iam or aws_devops_user? Lets discuss tomorrow!

We'll go with aws_devops_iam_username


Terminating app due to uncaught exception 'CNPropertyNotFetchedException', reason: 'A property was not requested when contact was fetched.'

When I put
let contactPickerScene = EPContactsPicker(delegate: self, multiSelection:true, subtitleCellType: SubtitleCellValue.phoneNumber)         let navigationController = UINavigationController(rootViewController: contactPickerScene)         self.present(navigationController, animated: true, completion: nil)
I got this
Terminating app due to uncaught exception 'CNPropertyNotFetchedException', reason: 'A property was not requested when contact was fetched.'
How to fix this?

You can only access keys specified in keysToFetch, so you need to add CNContactPhoneNumbersKey in the array of keysToFetch of your get contacts method


Change the redirect to 307 status code

@auyer, I think the permanent redirect status code can be dangerous to the clients because they may understand they must use the new address in the future requests. When I red about the difference between the redirection codes (301, 302, 307, 308), this issue was confirmed:

A browser redirects to this page and search engines update their links to the resource 1

More readings:

https://stackoverflow.com/questions/42136829/whats-difference-between-http-301-and-308-status-codes
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/302
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/308

Agreed. Thanks for the info.


xGroup: Get-DscConfiguration fails

I'm working on a fairly complex DSC configuration which contains several partial configurations. One of them contains two xGroup resources.
After I publish and run the configuration (successfully), running Get-DscConfiguration fails with:
Get-DscConfiguration : GetConfiguration did not succeed.
At line:1 char:1
+ Get-DscConfiguration
+ ~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (MSFT_DSCLocalConfigurationManager:root/Microsoft/...gurationManager) [Get
   -DscConfiguration], CimException
    + FullyQualifiedErrorId : MI RESULT 1,Get-DscConfiguration

DSC event log shows three error entries:
Job {5386BEF3-3C1A-11E7-80C3-3E1DBB675B2A} :
Message Unable to cast object of type 'System.Management.Automation.PSObject' to type 'System.Object[]'.
HResult -2147467262
StackTrack    at System.Management.Automation.LanguagePrimitives.ConvertTo[T](Object valueToConvert)
   at Microsoft.PowerShell.DesiredStateConfiguration.Internal.ResourceProviderAdapter.GetPSObjectArrayValue(CimType cimType, Object propertyValue)
   at Microsoft.PowerShell.DesiredStateConfiguration.Internal.ResourceProviderAdapter.GetTargetResource(IntPtr resourceConfigurationInstanceHandle, IntPtr nonResourcePropetiesHandle, IntPtr metaConfigHandle, IntPtr regInstanceHandle, IStreamsHandler plugInStreamsHandler, IntPtr& outputInstanceHandle, IntPtr& errorInstanceHandle)
   at Microsoft.PowerShell.DesiredStateConfiguration.Internal.DscPluginManagedEntryWrapper.Get(IntPtr provContext, IntPtr instance, IntPtr nonResourcePropeties, IntPtr metaConfig, IntPtr regInstance, IntPtr outputInstance, IntPtr extendedError)

Job {5386BEF3-3C1A-11E7-80C3-3E1DBB675B2A} :
This event indicates that failure happens when LCM is processing the configuration. Error Id is 0x1. Error Detail is The SendConfigurationApply function did not succeed.. Resource Id is [xGroup]Elements_Instances and Source Info is ::48::3::xGroup. Error Message is NULL.

Job {5386BEF3-3C1A-11E7-80C3-3E1DBB675B2A} :
MIResult: 1
Error Message: GetConfiguration did not succeed.
Message ID: MI RESULT 1
Error Category: 0
Error Code: 1
Error Type: MI

The error occurs when either one or both xGroup resources are present.
If I manually import MSFT_xGroupResource.psm1 in a powershell window and run Get-TargetResource, it runs fine.
I don't have a minimal example for now, but if I could get some guidance on debugging the configuration as it is now, I'd be more than happy to take a look.
OS:
Windows Server 2012R2

$PSVersionTable:
Name                           Value
----                           -----
PSVersion                      5.1.14409.1005
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1005
CLRVersion                     4.0.30319.36366
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

xPSDesiredStateConfiguration:
<IP_ADDRESS>

I'm having the same problem with the 1.1 version of PSDesiredStateConfiguration which ships bundled with WMF 5.1
Name                           Value
----                           -----
PSVersion                      5.1.14409.1005
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1005
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Message Unable to cast object of type 'System.String' to type 'System.Collections.IList'.
Parameter name: value
HResult -2147024809
StackTrack    at Microsoft.Management.Infrastructure.Internal.Data.CimPropertyOfInstance.set_Value(Object value)
   at Microsoft.PowerShell.DesiredStateConfiguration.Internal.ResourceProviderAdapter.GetTargetResource(IntPtr resourceConfigurationInstanceHandle, IntPtr nonResourcePropetiesHandle, IntPtr metaConfigHandle, IntPtr regInstanceHandle, IStreamsHandler plugInStreamsHandler, IntPtr& outputInstanceHandle, IntPtr& errorInstanceHandle)
   at Microsoft.PowerShell.DesiredStateConfiguration.Internal.DscPluginManagedEntryWrapper.Get(IntPtr provContext, IntPtr instance, IntPtr nonResourcePropeties, IntPtr metaConfig, IntPtr regInstance, IntPtr outputInstance, IntPtr extendedError)

This event indicates that failure happens when LCM is processing the configuration. Error Id is 0x1. Error Detail is The SendConfigurationApply function did not succeed.. Resource Id is [xVMHyperV]TestVM1 and Source Info is C:\Users\fakename\Documents\WindowsPowerShell\Modules\DSCToolkit\ConfigPrimitives\ClientVM.ps1::77::7::xVMHyperV. Error Message is NULL.

Faced the same issue myself when xGroup contains only one member. Changing next line in function Get-TargetResourceOnFullSKU
$members = Get-MembersOnFullSKU -Group $group -PrincipalContextCache $principalContextCache `-Credential $Credential -Disposables $disposables
to
[array] $members = Get-MembersOnFullSKU -Group $group -PrincipalContextCache $principalContextCache `                 -Credential $Credential -Disposables $disposables
fixes the issue.


elvish: add shellPath passthru

Motivation for this change
elvish is a shell package but is not recognized as such.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

oh I see why this is currently the case. Login will source /etc/profile which is not valid elvish and there's also  /nix/store/*-set-environment. hmm maybe wrap login-elvish in something like:
/bin/sh
source /etc/profile
exec elvish

I need to up my nix skills, closing for now.


capability: accept unknown capabilities, fixes #450

GitHub has started using a non-standard capability early-capabilities
with agent=git/github-g3daa19f21. This is breaking all go-git operations
on GitHub.
This commit removes validation for known capabilities, so that we can
use non-standard capabilities safely.

They have updated their server again and they do not advertise this capability anymore. So this PR is not urgent anymore.


Export is not available

Python: Traceback (most recent call last):
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2_init_.py", line 651, in execute
return gltf2_blender_export.save(context, export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 46, in save
json, buffer = __export(export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 63, in __export
__gather_gltf(exporter, export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 77, in __gather_gltf
active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 39, in gather_gltf2
animations += __gather_animations(blender_scene, export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 83, in _gather_animations
animations, merged_tracks = gltf2_blender_gather_animations.gather_animations(_blender_object, merged_tracks, len(animations), export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 77, in gather_animations
animation = __gather_animation(blender_action, blender_object, export_settings)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 115, in __gather_animation
channels=__gather_channels(blender_action, blender_object, export_settings),
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 152, in __gather_channels
return gltf2_blender_gather_animation_channels.gather_animation_channels(
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached
result = func(*args)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 139, in gather_animation_channels
channel = __gather_animation_channel(
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 230, in __gather_animation_channel
sampler = __gather_sampler(channels, blender_object, export_settings, bake_bone, bake_channel, bake_range_start, bake_range_end, force_range, action_name, driver_obj, node_channel_is_animated)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 294, in __gather_sampler
return gltf2_blender_gather_animation_samplers.gather_animation_sampler(
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached
result = func(*args)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_samplers.py", line 66, in gather_animation_sampler
input = __gather_input(channels, blender_object_if_armature, non_keyed_values,
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached
result = func(*args)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_samplers.py", line 247, in __gather_input
keyframes = gltf2_blender_gather_animation_sampler_keyframes.gather_keyframes(blender_object_if_armature,
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached
result = func(*args)
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_sampler_keyframes.py", line 238, in gather_keyframes
mat = get_bone_matrix(
File "C:\Users*\Documents\blender-3.1.0-windows-x64\3.1\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 94, in wrapper_bonecache
return result[args[7]][pose_bone_if_armature.name]
KeyError: 1.0
location: :-1

Hello,
Can you please test with a recent build of 3.2 alpha?

I still get an error
Python: Traceback (most recent call last):
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2_init_.py", line 628, in execute
return gltf2_blender_export.save(context, export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 35, in save
json, buffer = __export(export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 52, in __export
__gather_gltf(exporter, export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 66, in __gather_gltf
active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 34, in gather_gltf2
animations += __gather_animations(blender_scene, export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 91, in _gather_animations
animations, merged_tracks = gltf2_blender_gather_animations.gather_animations(obj_uuid, merged_tracks, len(animations), export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 126, in gather_animations
animation = __gather_animation(obj_uuid, blender_action, export_settings)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 169, in __gather_animation
channels=__gather_channels(obj_uuid, blender_action, export_settings),
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 206, in __gather_channels
return gltf2_blender_gather_animation_channels.gather_animation_channels(
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
result = func(*args, kwargs)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 128, in gather_animation_channels
channel = gather_animation_channel(
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 268, in gather_animation_channel
sampler = __gather_sampler(channels, obj_uuid, export_settings, bake_bone, bake_channel, bake_range_start, bake_range_end, force_range, action_name, driver_obj_uuid, node_channel_is_animated)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 336, in __gather_sampler
return gltf2_blender_gather_animation_samplers.gather_animation_sampler(
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
result = func(*args, kwargs)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_samplers.py", line 59, in gather_animation_sampler
input = __gather_input(channels, obj_uuid, is_armature, non_keyed_values,
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
result = func(*args, kwargs)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_samplers.py", line 243, in __gather_input
keyframes, is_baked = gltf2_blender_gather_animation_sampler_keyframes.gather_keyframes(blender_obj_uuid,
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
result = func(*args, kwargs)
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_sampler_keyframes.py", line 318, in gather_keyframes
mat = get_bone_matrix(
File "C:\Users*\Documents\blender-3.2.0-alpha+master.c486da0238bd-windows.amd64-release\3.2\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 134, in wrapper_bonecache
return result[cache_key_args[7]][pose_bone_if_armature.name]
KeyError: 1.0

Hello,
Can you please share the blend you are trying to export?
Thanks,

Confirmed.
But I don't have the same issue on my side.
Error come from using at the same time:

export selection only
always sampled is OFF

(Note that in your case, sampled with be forced in most cases, because channels don't have same number of keyframes)

What does it mean?
export selection only is ON/OFF
always sampled is ON/OFF
I have also tried copying and exporting to a new Blender, etc
But I can't export

Your problem occurs only when both export selection only is ON and always sampled is OFF.
Any other combination of these 2 parameters export are fine.
This will be fixed by #1638

Export errors even if "export selection only" is turned off
Python: Traceback (most recent call last):
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2_init_.py", line 651, in execute
return gltf2_blender_export.save(context, export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 46, in save
json, buffer = __export(export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 63, in __export
__gather_gltf(exporter, export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 77, in __gather_gltf
active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 39, in gather_gltf2
animations += __gather_animations(blender_scene, export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 83, in _gather_animations
animations, merged_tracks = gltf2_blender_gather_animations.gather_animations(_blender_object, merged_tracks, len(animations), export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 77, in gather_animations
animation = __gather_animation(blender_action, blender_object, export_settings)
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 115, in __gather_animation
channels=__gather_channels(blender_action, blender_object, export_settings),
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animations.py", line 152, in __gather_channels
return gltf2_blender_gather_animation_channels.gather_animation_channels(
File "C:\Users*\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 65, in wrapper_cached
result = func(*args)
File "C:\Users***\Documents\blender-3.0.0-windows-x64\3.0\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_animation_channels.py", line 45, in gather_animation_channels
if blender_action.use_frame_range is True:
AttributeError: 'Action' object has no attribute 'use_frame_range'
location: :-1


First attempt Homework5 for marking

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1

Complexity increasing per file
==============================
- Src/BootCamp.Chapter1/ArrayOperations.cs  2

See the complete overview on Codacy

Please fix the broken tests. You cannot just reuse the function of InsertAt as is, there are edge conditions for length 0, null, etc.

Expired


release 3.0.2358

azure-functions-core-tools  3.0.2358 was released on Mar 8, but the brew formula hasn't been bumped.

Cleaning up some out of date issues


Create Common Configurations

What
Align on our common configurations for eslint prettier and vscode so that we all use the same linting settings, and ideally our code lints on save.
Todo

Scaffold from nx recommended eslint and prettier configurations
Share .vscode setup with format on save for linting
Make sure everyone is able to use these instead of any global settings

@alexkeating -- I'm happy to help with the documentation piece if we want to add this in the root README

@jonathanprozzi is there any additional details required to get this one ready for dev?

I think this is no longer relevant

eslint prettier and vscode are already set up in the monorepo


AQAvit meeting - Feb 5, 2020 Agenda and Minutes

AQA vit Meeting
Wednesday, Feb 5, 2020 11:30 am | 30 minutes | (UTC-05:00) Eastern Time (US & Canada)
https://ibm.webex.com/ibm/j.php?MTID=mca68b43b418dd3280165279b4c800c14
Join by phone
1-844-531-0958 United States Toll Free
Access code: 927 236 656
If asked for a password: Password: adoptQA! (23678720 from phones)
Agenda topics:

https://github.com/AdoptOpenJDK/openjdk-tests/pull/1594 framework for test docker file generation - @james-crowley
'Run AQA' GitHub action - @sophia-guo
recent / current work in TRSS - @llxia
review of FOSDEM day - @smlambert

Any other verification business?

Recording link: https://youtu.be/XVMGNuwCHl8

Minutes:

PR https://github.com/AdoptOpenJDK/openjdk-tests/pull/1594 has been delivered, next steps plug into build.xml/playlist.xml file (@smlambert  and @james-crowley  to meet on Monday to ensure this happens)
some additional cleanup to come, including pulling in system-test/functional-test/elasticsearch
@sophia-guo gave update on initial work to enable RunAQA GitHub action (which will be put into the 'marketplace' for people to be able to use
quick view of the 3-part test automation story (to explain why TKG / CI layer / TRSS exist and fit together)
@llxia showed the git button added to TRSS (to help people triaging releases auto-fill and create GitHub issues).
Lan also previewed the new dashboard banner that will show at the top of the Grid view in TRSS, 1st cut will give you pass % of all test targets run (later we will try to include more granular stats)
brief talk of the experience at the FOSDEM table, and conversations around testing.  Thanks to all who have contributed to this effort, AdoptOpenJDK was extremely well-received.


Typo fix

Fixes typo

@wast  Stjepan
Your feature branch is too old! It has 70 commits behind develop!!!
I'm going to close the PR!
Please, create new feature branch and new PR.


lacking many component

the semantic vue integration is lacking so many component compared to the real semantic ui..some which include a navbar and appropriate card component audio component, and image component ..you should check out vuetify also how do i contribute

We are quite aware of that.
Please understand the maintainers of this project (and most of the projects you find on Github) don't get paid and have already a full-time job. The developer of Vuetify is doing an amazing job
Unfortunately, these issues don't help us developing components, but make us more frustrated instead. Please, consider contributing instead of complaining.

We are quite aware of that.
Please understand the maintainers of this project (and most of the projects you find on Github) don't get paid and have already a full-time job.
Unfortunately, these issues don't help us developing components, but make us more frustrated instead. Please, consider contributing instead of complaining. You will find a CONTRIBUTING file containing all the info just for that.

i am so sorry about that..to be honest you are doing a great Job..i love  semantic ui ...i love you guys , you have done a great job to bring it to vue js

i also want to know to how i  can contribute... i am new vue js developer


Update network_problem.sh

Fixes #340

@andyxning can you give it the ok-to-test? this pr just adds '2' spaces for the identation :-)

/ok-to-test
/lgtm


Support for compressed metadata

Relevant discussion: https://github.com/theupdateframework/tuf/issues/105
This would require crossplatform, rust-only support for the chosen compression algorithm. Additionally, it would be nice if TUF supported some way of sending the hashes of the compressed data so that there is less processing of untrusted data. Even without that provision, the steps would be

Download role.extension.compression up to size N bytes where N is the size of role.extension + some fixed offset to catch the edge case where the compressed data is larger than the original
Decompress to role.extension up to size N
If 1/2 fails, download role.extension
Parse
Do the usual

This assumes that the root metadata has a flag of what types of compressed metadata it has available (possibly none).

I open this ticket, and like... 30 minutes later it looks like the spec might go the other direction: https://github.com/theupdateframework/tuf/issues/471#issuecomment-316403412

Additional upstream discussion: https://github.com/theupdateframework/taps/issues/52

This was removed from the spec. Closing for simplicity's sake.


Using pdfView with flutter 2.10.1 causes an error "Looking up a deactivated widget's ancestor is unsafe."

Once you navigate out of the view you see this error..
using pdfx: ^2.0.1+1.  and flutter 2.10.1
it was working fine before flutter upgrade..
here is my widget code..
PhotoViewGalleryPageOptions _pageBuilder(
          BuildContext context,
          Future<PdfPageImage> pageImage,
          int index,
          PdfDocument document,
        ) =>
            PhotoViewGalleryPageOptions(
              imageProvider: PdfPageImageProvider(
                pageImage,
                index,
                document.id,
              ),
              minScale: PhotoViewComputedScale.contained * 1,
              maxScale: PhotoViewComputedScale.contained * model.getMaxScale(),
              initialScale: PhotoViewComputedScale.contained * 1.0,
              heroAttributes:
                  PhotoViewHeroAttributes(tag: '${document.id}-$index'),
            );

// here is the pdf view

 PdfView(
                backgroundDecoration: const BoxDecoration(color: Colors.black),
                controller: model.pdfController!,
                renderer: (page) {
                  model.setPageSize(
                      page.height.toDouble(),
                      page.width.toDouble(),
                      MediaQuery.of(context).size,
                      Scaffold.of(context).appBarMaxHeight!.toDouble());

                  return page.render(
                    backgroundColor: '#FFFFFF',
                    width: page.width * 2,
                    height: page.height * 2,
                  );
                },
                onDocumentLoaded: (document) {
                  model.setLoaded(document);
                },
                onPageChanged: (page) {
                  model.setPageIndex(page);
                },
                builders: PdfViewBuilders<DefaultBuilderOptions>(
                  // All from `PdfViewPinch` and:
                  pageBuilder: _pageBuilder,
                  options: const DefaultBuilderOptions(
                    loaderSwitchDuration: const Duration(seconds: 1),
                  ),
                ),
              )

when navigate out of the view it shows. the error basically caused by photo_view_core.dart,, the following is a part of the stack trace:
#0      Element._debugCheckStateIsActiveForAncestorLookup.<anonymous closure>
package:flutter/…/widgets/framework.dart:4153
#1      Element._debugCheckStateIsActiveForAncestorLookup
package:flutter/…/widgets/framework.dart:4167
#2      Element.getElementForInheritedWidgetOfExactType
package:flutter/…/widgets/framework.dart:4193
#3      TickerMode.getNotifier
package:flutter/…/widgets/ticker_provider.dart:96
#4      TickerProviderStateMixin._updateTickerModeNotifier
package:flutter/…/widgets/ticker_provider.dart:327
#5      TickerProviderStateMixin.createTicker
package:flutter/…/widgets/ticker_provider.dart:291
#6      new AnimationController
package:flutter/…/animation/animation_controller.dart:246
#7      PhotoViewCoreState._scaleAnimationController
package:photo_view/…/core/photo_view_core.dart:112 ------- here
#8      PhotoViewCoreState._scaleAnimationController (package:photo_view[/src/core/photo_view_core.dart]()) // here
package:photo_view/…/core/photo_view_core.dart:1
#9      PhotoViewCoreState.dispose
package:photo_view/…/core/photo_view_core.dart:274
#10     StatefulElement.unmount
package:flutter/…/widgets/framework.dart:4983
#11     _InactiveElements._unmount
package:flutter/…/widgets/framework.dart:1926
#12     _InactiveElements._unmount.<anonymous closure>
package:flutter/…/widgets/framework.dart:1924
#13     ComponentE

@bdairy same issue for photo_view: https://github.com/bluefireteam/photo_view/issues/502
It is flutter v2.10.0 compatibility non critical error
for temporary solution you can try add to pubspec:
dependency_overrides
    photo_view:
      git: https://github.com/bluefireteam/photo_view.git

@SergeShkurko  thanks for the reply,, this does not work,, I had to create a fork over pdfx and change the dependecy of photo_view ,,, then import my fork in pubspec...and the issue causes red screen in big projects,, also it affects all other navigation happens after it.. so it is kinda big deal..

Same problem here @SergeShkurko any workarounds?

Here is a temporary fix https://stackoverflow.com/questions/70404718/error-with-photoview-looking-up-a-deactivated-widgets-ancestor-is-unsafe/71010204#71010204
Its working with external packages and dependency version problems.

Works normally, i rechecked
Temporary solution, wait new release
dependency_overrides:
  photo_view:
    git:
      url: https://github.com/bluefireteam/photo_view
      ref: master


[IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app

[IotCentral] Update C# sdk, Change error to be CloudException, and remove regex check for IOTC app

Please remove file sdk/iotcentral/Microsoft.Azure.Management.IotCentral/src/Generated/code-model-v1 and put the link of related swagger review PR in the comments. Thanks!

Please wait until March 19th to merge it when all the other sdks are published, Thanks

Here is the related swagger change: https://github.com/Azure/azure-rest-api-specs/pull/8395, it's ok to merge now, the sdk have been published, thanks


QEMU harddisk fail

windows  | ❯ Extracting Windows 10 bootdisk...
windows  | ❯ Extracting Windows 10 environment...
windows  | ❯ Extracting Windows 10 setup...
windows  | ❯ Extracting Windows 10 image...
windows  | ❯ Adding XML file for automatic installation...
windows  | ❯ Building Windows 10 image...
windows  | ❯ Creating a 64G growable disk image in raw format...
windows  | ❯ Booting Windows using QEMU emulator version 8.2.1 ...
windows  |
BdsDxe: failed to load Boot0002 "UEFI QEMU QEMU HARDDISK " from PciRoot(0x0)/Pci(0xA,0x0)/Scsi(0x0,0x0): Not Found
windows  | BdsDxe: loading Boot0001 "UEFI QEMU QEMU CD-ROM " from PciRoot(0x0)/Pci(0x5,0x0)/Scsi(0x0,0x0)
windows  | BdsDxe: starting Boot0001 "UEFI QEMU QEMU CD-ROM " from PciRoot(0x0)/Pci(0x5,0x0)/Scsi(0x0,0x0)
windows  | ❯ ERROR: Forcefully terminating Windows, reason: 0...
windows  |
❯ Shutdown completed!
Trying to start the container on M1, this is my YAML:
version: "3"
services:
windows:
image: dockurr/windows
container_name: windows
cap_add:
- NET_ADMIN
ports:
- 8006:8006
- 3389:3389/tcp
- 3389:3389/udp
stop_grace_period: 2m
restart: on-failure
environment:
VERSION: "win10"

@kroese sorry, was trying to respond between meetings.  I am running on an x86 chip with Ubuntu running on a VM.  I did set up the storage on an external volume (which could be the problem), so I'll try running without that before commenting more.

The new release fixed it!!!!!!!  Thank you!!!!


MODEXPW-346: Upgrade vulnerable dependencies for Orchid

Upgrade spring-boot-starter-parent from 2.7.3 to 2.7.6.
The spring-boot-starter-parent upgrade indirectly removes the<EMAIL_ADDRESS>dependency that has Denial of Service (DoS) and Stack-based Buffer Overflow vulnerabilities: https://nvd.nist.gov/vuln/detail/CVE-2022-45685 https://nvd.nist.gov/vuln/detail/CVE-2022-40150 https://nvd.nist.gov/vuln/detail/CVE-2022-40149
The spring-boot-starter-parent upgrade indirectly upgrades tomcat-embed-core from 9.0.65 to 9.0.69 fixing HTTP Request Smuggling: https://nvd.nist.gov/vuln/detail/CVE-2022-42252
Upgrade folio-spring-base from 5.0.1 to 5.0.3.
The folio-spring-base upgrade indirectly upgrades commons-text from 1.9 to 1.10.0 fixing Arbitrary Code Execution: https://nvd.nist.gov/vuln/detail/CVE-2022-42889
The folio-spring-base upgrade indirectly upgrades postgresql from 42.3.6 to 42.5.1 fixing SQL Injection and Information Exposure: https://nvd.nist.gov/vuln/detail/CVE-2022-31197 https://nvd.nist.gov/vuln/detail/CVE-2022-41946
The folio-spring base upgrade indirectly upgrades snakeyaml from 1.30 to 1.33 fixing Denial of Service (DoS), Arbitrary Code Execution, and Stack-based Buffer Overflow: https://nvd.nist.gov/vuln/detail/CVE-2022-25857 https://nvd.nist.gov/vuln/detail/CVE-2022-38749 https://nvd.nist.gov/vuln/detail/CVE-2022-1471 https://nvd.nist.gov/vuln/detail/CVE-2022-38751 https://nvd.nist.gov/vuln/detail/CVE-2022-38752 https://nvd.nist.gov/vuln/detail/CVE-2022-41854 https://nvd.nist.gov/vuln/detail/CVE-2022-38750
The folio-spring-base upgrade indirectly upgrades jackson-databind from 2.13.3 to <IP_ADDRESS> fixing Denial of Service (DoS): https://nvd.nist.gov/vuln/detail/CVE-2022-42003 https://nvd.nist.gov/vuln/detail/CVE-2022-42004
Upgrade aws-sdk-java from 2.17.267 to 2.19.0.
Upgrade netty from 4.1.79.Final to 4.1.86.Final fixing HTTP Response Splitting: https://nvd.nist.gov/vuln/detail/CVE-2022-41915
Upgrade sshd-sftp and sshd-spring-sftp from 2.8.0 to 2.9.2 fixing Deserialization of Untrusted Data: https://nvd.nist.gov/vuln/detail/CVE-2022-45047
Upgrade commons-net from 3.6 to 3.9.0 fixing Information Exposure: https://nvd.nist.gov/vuln/detail/CVE-2021-37533

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Checkbox styling in live preview

When using Reading-view, checkboxes with this style are shown as completed (ticked):
[-]
However, when using live-preview they show as empty (not ticked).
Would it be possible for these checkboxes to show as completed also in live-preview?

I will look into it

Sorry for getting so late back to you, but I was really swamped with private life and work..
Checkboxes which are filled with - are now also considered "checked" in Live Preview mode, which is now consistent with the "normal" Preview Mode.

I absolutely understand and have no expectations :-) Thank you!


Target and prediction are not excluded from the data drift report

According to the evidently documentation, if target and prediction are specified, they should be excluded from the data drift report. This is fine with evidently v0.1.49.dev0. However, when I upgraded evidently to v0.1.53.dev0, target and prediction are shown in the data drift report.
I created a notebook to reproduce this bug: https://github.com/yumoL/evidently_bug_reproduction

Hi @yumoL ,
you are right.
We have change the behaviour of DataDriftTab()in the 0.1.51 release: https://github.com/evidentlyai/evidently/releases/tag/v0.1.51.dev0
The idea behind that was that some users wanted to obtain drift score for target and predictions together with all the rest features, but did not want to add an additional tab to the report like tabs=[DataDriftTab(), NumTargetDriftTab()]
What are you thoughts on the topic? Do you think that target and prediction should not be there?
Sorry for the mess with the docs, we will update it shortly.

Hi @emeli-dral , thanks for your quick reply. Should have read the release notes more carefully... I don't have a strong opinion on whether the target and prediction should be included in the data drift report or not, so it's fine to me that the target and prediction are included in the latest version :)

@yumoL thank you!
Fixed in the docs.


Will2

Started building loging in several places

This does cause livechat page to be down, but let it stay down until we get some oruting and seed data


[RFC]: Initial support for RBLN NPU

Motivation.
The RBLN SDK provides a solution for innovative deep learning inference on Rebellion's NPUs, such as ATOM and REBEL, including support for large language models (LLMs). This project aims to develop the RBLN backend for vLLM, initially prioritizing the ATOM device, with future plans to enable REBEL support.
In alignment with Rebellion's Optimum Huggingface extension documentation, RBLN backend will support a wide range of models available in the Rebellion's Model Zoo.
The project currently incorporates continuous batching feature and will soon integrate additional techniques, such as PagedAttention, to enhance performance further.
Proposed Change.
Introduce the RBLN vLLM backend, which will:

Load models via the optimum-rbln extension for Hugging Face (documentation)
Implement custom RBLN model loader, model runner, model executor, and model worker classes that integrate seamlessly with the vLLM architecture.
Provide a new requirements.txt for the RBLN environment.

Target  Models
We will start by ensuring vLLM works with the Llama architecture and expand to other architectures. The full list of LLMs supported by RBLN can be viewed here.
Design
We will introduce several custom classes that align with the vLLM architecture for heterogeneous accelerators (such as Neuron, XPU, TPU...). See the diagram below for details.

Implementation Details
Initalize model
def init_model(self) -> None:
    config = self.model_config.hf_config
    model_name_or_path = self.model_config.model
    model_name, model_cls_name = get_rbln_model_info(config)

    # huggingface model class
    model_cls = getattr(optimum.rbln, model_cls_name)
    assert model_cls is not None
    # load RBLN compiler binary model
    model = model_cls.from_pretrained(model_name_or_path, export=False)
    self.model = model

Model-specific (e.g. llama specific) forward functions
class RBLNOptimumRBLNLlamaForCausalLM(RBLNBaseLlamaForCausalLM):
    def forward(
        self,
        input_ids: torch.Tensor,
        attn_mask: torch.Tensor,
        positions: torch.Tensor,
        seq_group_metadata_list: List[SequenceGroupMetadata],
        use_cache: Optional[bool] = None,
        output_attentions: Optional[bool] = None,
        output_hidden_states: Optional[bool] = None,
        return_dict: Optional[bool] = None,
    ) -> torch.Tensor:
        is_prefill = seq_group_metadata_list[0].is_prompt
        if not is_prefill:
            input_ids, positions = self.preprocess_decode(
                input_ids, positions, seq_group_metadata_list)
        batch_indices = self.get_batch_indices(seq_group_metadata_list)
        batch_idx = batch_indices[0] if is_prefill else None
        # optimum.rbln RBLNLlamaForCausalLM.forward()
        logits = self.model.forward(input_ids=input_ids.to(torch.int64),
                                    cache_position=positions.to(torch.int32),
                                    batch_idx=batch_idx)
        if not is_prefill:
            logits = self.postprocess_decode(logits, seq_group_metadata_list)
        return logits

References

About rebellions: https://rebellions.ai/
Developer page: https://docs.rbln.ai/
Model zoo: https://rebellions.ai/developers/model-zoo/
Model zoo (github) : https://github.com/rebellions-sw/rbln-model-zoo

Feedback Period.
1w
CC List.
@WoosukKwon , @rebel-shshin, @rebel-hekim, @rebel-hongseok
Any Other Things.

In the near future, we plan to support

distributed inference with Ray for the RBLN backend. This will include implementing a custom distributed executor.
PagedAttention with custom operator implementation.

Hello @WoosukKwon @zhuohan123 @simon-mo,
I understand that you may have a lot on your plate, but I would greatly appreciate any feedback or thoughts you might have on this proposal when you have a moment. Your input would be invaluable in helping to refine and move this project forward. :)

Gentle reminder about this RFC - any feedback would be greatly appreciated.


[mysql][improvement] Support binlog reader merge

In current implementation, there're multiple binlog reader even in pure binlog read phase, we can merge it to one to decrease the db pressure.

Implemented by<PHONE_NUMBER>7a8f2ad3524cd236ea20f772c25035


Merge next into master

Proposed Changes
Replace all the usage of npm with pnpm in the repository. Lerna is still used to bump the version in all the packages, but that's it. pnpm takes care of running the scripts
The code was already reviewed in #1939 and #1940
Potential Breaking Changes
No breaking changes in the code but the setup is a bit different. You'll have to install npm install -g pnpm and then pnpm reconstruct. pnpm build, pnpm test and pnpm start are also available
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Each time someone merges something on master and Jenkins build I will have conflict on the CHANGELOGs, package-lock.json, lerna.json and package.json. I'll fix the conflicts at the end

Do you think you should modify the readme with this merge ?

I updated the readme


export options types and interfaces

Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @trevor-gullstad - this pull request already looks great to me 👍 After waiting for other maintainers' response, we can merge this PR shortly.

Thanks @seratch and @stevengill when can I expect to see these changes reflected in a new release?

@trevor-gullstad We are still working on a few other tasks for the next release: https://github.com/slackapi/bolt-js/issues?q=is%3Aissue+is%3Aopen+milestone%3A3.4.0
We haven't decided the date for the next release yet but it won't take long.


Provide a way to create a non-JS site

Provide a way to configure webpack, possibly with 'manual overrides' beyond the 'extract css' (which extracts all CSS, which I don't want); which lets you handle other static assets; images, fonts, vector graphics, other html pages (can they be entry points themselves?).
This feature would be a great fallback when the dependencies inevitably fail, like JS projects do, like node-sass or csso. By having a feature like this, I could instruct webpack to simply ignore the failed asset, or I could provide the dependency analysis myself, through the configuration file.
I'll open this issue as a way to track such an implementation, because it's a very real pain-point for users.

It's not really clear to me what's your use case...

which extracts all CSS, which I don't want

It only extract CSS which has the extract-text-plugin loader applied. You can provide an alternative test.

The feature requested is to expand webpack from being just a compiler with entry points to being able to create sites that are not all JS. Currently the project is centered around these entry points and everything goes from there, but sometimes you bump into bugs which fail the compilation. Having the option to explicitly specify what file gets put where in the final output folder would make it possible to move forward.
If I were you I'd say: we are more interested in removing the bugs from the project than making infrastructure for workaround, even if those workarounds can be used as features in their own right and for other purposes than workarounds.
As such, closing.


Documented example for custom scalar

Looking for an example of how to implement a custom scalar handler.
I've tried a few different methods to provide this Date custom scalar:
scalar Date

Such as:
@Configuration
class DateScalarConfiguration {
    @Bean
    fun dateScalar(): GraphQLScalarType {
        return GraphQLScalarType.newScalar()
            .name("Date")
            .description("Java 8 LocalDate as scalar.")
            .coercing(object : Coercing<LocalDate, String> {
                override fun serialize(dataFetcherResult: Any): String {
                    return (dataFetcherResult as?  LocalDate)?.toString()
                        ?: throw CoercingSerializeException("Expected a LocalDate object.")
                }

                override fun parseValue(input: Any): LocalDate {
                    return try {
                        if (input is String) {
                            LocalDate.parse(input)
                        } else {
                            throw CoercingParseValueException("Expected a String")
                        }
                    } catch (e: DateTimeParseException) {
                        throw CoercingParseValueException("Not a valid date: '$input'.", e)
                    }
                }

                override fun parseLiteral(input: Any): LocalDate {
                    return if (input is String) {
                        try {
                            LocalDate.parse(input)
                        } catch (e: DateTimeParseException) {
                            throw CoercingParseLiteralException(e)
                        }
                    } else {
                        throw CoercingParseLiteralException("Expected a StringValue.")
                    }
                }
            })
            .build()
    }
}

I keep getting this error:
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'graphQlSource' defined in class path resource [org/springframework/graphql/boot/GraphQlAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springframework.graphql.execution.GraphQlSource]: Factory method 'graphQlSource' threw exception; nested exception is SchemaProblem{errors=[There is no scalar implementation for the named  'Date' scalar type]}

You need:
	@Bean
	RuntimeWiringConfigurer configurer() {
		GraphQLScalarType scalarType = ...;
		return (builder) -> builder.scalar(scalarType);
	}

We'll add something to the documentation.

You need:
@Bean
RuntimeWiringConfigurer configurer() {
    GraphQLScalarType scalarType = ...;
    return (builder) -> builder.scalar(scalarType);
}

We'll add something to the documentation.

Thank you for this.
If I might make a suggestion, the documentation here is confusing, it says:

"You can add a RuntimeWiringConfigurer to GraphQlSource.Builder to register: Custom scalar types."

Only after I found the above, did it make sense.
The excerpt from the document implies that you need to get/create an instance of GraphQlSource.Builder so that you can add a RuntimeWiringConfigurer instance to it, only then can you register your custom scalars etc...
Should this not instead say:

"You can create a RuntimeWiringConfigurer bean to register the below with the GraphQlSource.Builder:
Custom scalar types."

Possibly even provide a sample like:
@Bean
RuntimeWiringConfigurer configurer() {
    GraphQLScalarType scalarType = ...;
    return (builder) -> builder.scalar(scalarType);
}

@NeilAttewell thanks for the comment. I've created #249 to follow up.

rstoyanchev

@rstoyanchev  I'm trying to make two custom scalers, I'm guessing its a builder so I should be able to use builder.scalar(scalarType).scalar(scalarType2). but its not working, its only working for the first scalarType, what a way out that I can try


Alternative block sources

We should support an option to use Esplora / Electrum as block sources. This will help us deploy our early "dogfooding" federations more quickly.

[x] electrum support https://github.com/fedimint/fedimint/pull/1363
[ ] esplora support

Dev call: we already have a trait for this, easy to implement. All we need to look up is block height, block hash, and fee levels.
@dpc in dev call: maybe we should have a mode for "unsafe / non-production" that fills in some defaults to get people to play with it easier.

@justinmoon I was taking a look at this one and got interested, is the esplora support a pressing issue?
I can take a look at this one but it might take some time 😁

is the esplora support a pressing issue?

Esplora support would be very helpful. Also pretty straightforward to implement because it doesn't require a lot of familiarity with the overall system which takes time to learn.
Look at this PR for inspiration. Create a new EsploraClient struct. Implement IBitcoindRpc for it. Add a new entry to BitcoindRpcBackend. Send reqwest::get(<url>) to urls like /api/tx/<txid>/merkleblock-proof. This one gets the "txoutproof". You can use blockstream's public Esplora server at https://blockstream.info/api/.... Here is the Esplora API documentation. If you have any questions, post them in discord. And feel free to open a "draft" pull request once you've made progress and want feedback.
In terms of testing, you could just test that it fetches the same values as the electrum implementation. Eventually we should probably run Electrum / Esplora servers inside our test environment, but that requires editing flake.nix which isn't easy. Maybe @dpc can help but he'll be pretty busy for the next 10 days.

Related to https://github.com/fedimint/fedimint/issues/1383


remove unary operators

[x] unary ! → integer.not() – https://github.com/core-lang/core/pull/23
[x] unary ! → bool.not() – https://github.com/core-lang/core/pull/23

Further removals moved to https://github.com/core-lang/core/issues/81.


Fix path not filled when file is selected

Checklist for this pull request

[x] I have read the guidelines for contributing.
[x] I have checked that my code additions did not fail tests.

Description
Currently if one presses any folder button on the dock to the right, nothing happens. This is because the popup first emits popup_hide and then file_selected, causing the signal connection to break before file_selected is fired.
To solve this I propose adding an enum that will change depending on the button is pressed. It'll be redundant to use 4 identical EditorFileDialog, we can still use one and change it's parameters. A new variable will hold the enum of the button pressed, and file_selected will execute _on_file_selected method that'll do a match on the selected enum and perform the correct action. If the FileDialog is canceled then file_selected0 is not fired and the enum continues holding the past value. This value is overriden when a new button is pressed.
If for some reason we end up with UNKNOWN that means this function was called from somewhere else other than the 4 buttons, which is not expected.

This fixes #36.

Thanks for the PR @videlanicolas! I'll try to have a look tomorrow.

Thanks!

Great improvement!


docs: add docs for kms

The main question here is: what is the goal of this doc? There is a mention of "you'll learn how to make a basic usage of SNS", but no SNS is in the subsequent text. Maybe it is a leftover from an SNS documentation that was used as a template, but since KMS is used in other services, it might look like a tutorial on integrating SNS with KMS, so not sure.
Also the doc lists a lot of operations for KMS. If that is the goal - to list possibilities - maybe it is better to just point customers to AWS docs, as they are more complete and we do not have to worry about maintaining them.
The mention of our web interface is not justified, unfortunately. At least for KMS, that Resource page is not great. An example - it has a checkbox for multi-region keys. Had the mention before we even implemented multi-region keys in LocalStack. So the page requires an update before we can recommend it to people.
There are also some small things

It not exactly clear from the tutorial, where the key ID comes from, it is just being used everywhere. So might be confusing to new people.
We do not actually key key materiel rotation in LocalStack, even if we allow people to execute operations to enable/disable those rotations. So that is not the most useful functionality to teach to people - due to its absence.
The tem " Customer Master Keys" is outdated according to AWS docs, so its mention is confusing as well.

So what I propose is:

Avoid mentioning the web app and Resources on pages for individual services. Simply because that app is not specific to certain services, rather a general tool, so might be better to have a page for it somewhere at the beginning of the documentation.
Link the official AWS KMS docs from the page for the service. Less trouble for us with basics.
Write instead a small tutorial that focuses on something, that might be considered to be a core of a service. In KMS it might be encoding/decoding of data using a key.
Make our documentation as small as possible - to avoid confusing and intimidating readers. Might be better to not list all the possibilities than to scaring people away from using even simplest things.

If you are fine with that - I will write that tutorial beginning of next week.
And in generally - it might be better to delegate such things to service owners - simply because otherwise you are going to be too busy writing everything yourself. Also for KMS I know what works and what is not there. Wouldn't be fair to force you to figure that out for KMS or other services.

There is a mention of "you'll learn how to make a basic usage of SNS", but no SNS is in the subsequent text. Maybe it is a leftover from an SNS documentation that was used as a template, but since KMS is used in other services, it might look like a tutorial on integrating SNS with KMS, so not sure.

Yes, I used a portion of the SNS doc and I missed out on removing those parts. They should be fixed now 👍

Also the doc lists a lot of operations for KMS. If that is the goal - to list possibilities - maybe it is better to just point customers to AWS docs, as they are more complete and we do not have to worry about maintaining them.

Unfortunately, most users don't refer to AWS docs. They try to look out for some basic commands and samples to try out first before moving to more complex use-cases.

It not exactly clear from the tutorial, where the key ID comes from, it is just being used everywhere. So might be confusing to new people.

My bad! I had a note to remove them out before sending the PR. Will fix them now.

We do not actually key key materiel rotation in LocalStack, even if we allow people to execute operations to enable/disable those rotations. So that is not the most useful functionality to teach to people - due to its absence.

Will remove those parts.

Link the official AWS KMS docs from the page for the service. Less trouble for us with basics.

Will do.

Write instead a small tutorial that focuses on something, that might be considered to be a core of a service. In KMS it might be encoding/decoding of data using a key.

That should be the purpose of a separate Tutorials section, and not service page which should just serve as a template for folks to start in a simplistic manner.

The mention of our web interface is not justified, unfortunately. At least for KMS, that Resource page is not great.

I guess that should come up with the Web/Platform team. /cc: @whummer

Make our documentation as small as possible - to avoid confusing and intimidating readers. Might be better to not list all the possibilities than to scaring people away from using even simplest things.

I still don't see how the existing documentation is scaring people. Its purposefully geared towards first-time users to acquaint them with some basic commands before proceeding ahead with their more-complex use-cases (which a tutorial that you have proposed should cover).

If you are fine with that - I will write that tutorial beginning of next week.

It would be better if that goes in the beta branch of the docs to accumulate service-focussed tutorials in one single place.

Superseded by: https://github.com/localstack/docs/pull/295


ANCHOR-227: Fix incorrect asset (#805)

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Release 1.2.10
Why
Release 1.2.10
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr807.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr807.previews.kube001.services.stellar-ops.com/


Allow me to right click plugins "Open in new tab"

Is your feature request related to a problem?
Viewing the plugins, it's not possible to middleclick to open in a new tab.
Describe the solution you'd like.
Idk, something to do with html or css. Opening items from a list in the same tab is so 2018
Describe alternatives you've considered.
None
Other
No response

This is basically #1276, so can be merged into one. I have adjusted my issue to include middle click.

https://github.com/HangarMC/Hangar/commit/3f3022f2fe46ac80e6b68eb0fe7d8d623fbe8ca2


Field attribute for combining default and skip_serializing_if

I like to make sure that the serialized versions of my data structures hold the minimum amount of data possible and that missing fields get set to sensible defaults during deserialization. In general, if a field is equal to some default value, I like to skip serializing it. I use this same default value as the default for deserializing. I find that the solution to this problem that makes the most sense using the currently available serde_derive attributes looks something like the following:
use serde_derive::{Serialize, Deserialize};

#[derive(Serialize, Deserialize)]
struct Foo {
    #[serde(default = "default_bar", skip_serializing_if = "is_default_bar")]
    bar: u32
}

fn default_bar() -> u32 {
    5
}

fn is_default_bar(bar: &u32) -> bool {
    bar == &default_bar()
}

This works perfectly fine, but it is cumbersome to have to create two other functions just for this purpose. It would be nice if I could do something like this:
use serde_derive::{Serialize, Deserialize};

#[derive(Serialize, Deserialize)]
struct Foo {
    #[serde(skip_default = 5)]
    bar: u32
}

Is this reasonable?

This is totally reasonable, and I'd like that. But it assumes Copy types of given expressions.
Personally, I found this issue because I was looking for skipping defaults too. I'd start with something as specific as #[serde(skip_serializing_if_default)] which would check for equality with the type's Default::default() value. It would not be bounded to Copy, so should work on empty vectors, maps, strings etc.

I think this isn't a widespread enough use case that it would be worthwhile to build dedicated shorthand for this into serde_derive. However someone could provide a different Deserialize derive macro in a different crate which could be more fully featured and handle this case more concisely.


Unable to assert stubs were called with references to self using : syntax.

I think the easiest way to explain this is with an example:
Let us assume I have the following object.
local MyObject = { name = 'default' }
-- A method that will be stubbed.
function MyObject:mock_method( arg1 ) end

Now we add a method to MyObject that will first make a call to the stub, then change the value of the 'name' field.
function MyObject:do_something_to_change_state()

  -- First call the mocked method which will store a deep
  -- copy of "self" when self.name == 'default'
  self:mock_method( "hello" )
  self.mock_method( self, 'hello')

  -- Then change self.name to a new value.
  self.name = "Hey! I'm Different"
end

Later in a test we stub out mock_method and attempt to assert that it was called on the table referenced by MyObject.
stub( MyObject, 'mock_method')

MyObject:do_something_to_change_state()

-- This assertion fails because the first argument's name field still equals 'default'
-- and MyObject.name == "Hey! I'm Different" instead of 'default'
assert.stub( MyObject.mock_method ).was.called_with( MyObject )

The assertion will fail because the call history made a deep copy of MyObject when MyObject was in a different state.
I don't really have any ideas how to work around this. I feel like in every other case I would absolutely want the state to be copied for deep comparison.
I could always just say "I don't care" about the first argument but that solution feels unsatisfactory.  Do you have any ideas on how I could go about dealing with this case?

You can use a matcher to match against your object. You'll probably have to create your own custom matcher for this though.  Actually, I think the latest master branch already does not perform a deepcopy for spies/stubs.  Have you tried with the latest master?

I am running on the latest master. The issue isn't that it deep copies spies and stubs, but that it actually deep copies the table I am trying to compare against. I would effectively have to make an object instance ID that could be copied so that I could compare those item ID values to see if it is the same object.  I wish there was some way to tell the stub/spy that I am spying on a member function so don't deep copy the first argument.  something like:
spy.on.member( object, 'member' )
-- or
stub.member( object, 'methodName' )

Then we could call a utils.match_member_args( ... ) or something to take into account the 'self' operator.

Sorry, I was thinking that MyObject was also a spy/stub.   What about something like this?
spy.on(object, 'member').no_deepcopy_arg(1)
-- or
stub(object, 'member').no_deepcopy_arg(1)

This is a relatively easy change to make and it provides a general solution to prevent any arbitrary argument from being deep copied by the spy/stub.  And you can always undo the operation with something like (in case you change your mind later):
s.deep_copy_arg(1) - -  where s is a stub or spy

Actually, maybe a better interface would be something like
local match = require 'luassert.match'
assert.stub(s).was.called_with(match.is_ref(object))

Then you could also do
stub(object, 'member').on_call_with(match.is_ref(object))

I think this would be more flexible and intuitive to use.

I'll try to get a pull request sometime today or tomorrow.

@jimmyharris I submitted PR #124, which should resolve this.  Can you give it a try and let me know what you think?  It uses match.is_ref to match against the object reference.

That sounds good actually.

That is actually a perfect solution.


Add WIP ServiceStatus resource lifecycle test

[] mock ticket: #
[ ] issue created: XX
[ ] PR created: XX
[ ] Promotion Created: XX

This PR seems to update the mock-template. Can we update it to create ServiceStatus.org or similar @BobyMCbobs ?