redmine #8477

https://redmine.pfsense.org/issues/8477

use ms for latency measurements in logs
add small helper function usec_to_ms()
bump version to 3.1.1

@dennypage I have never coded in C before, please forgive me! Did the best I could to save you the trouble of working on redmine #8477.
I compiled and tested this on my Mac (had to compile with the DISABLE_ACCEPT4 flag you mentioned in #30) and ran it through some tests, which worked fine. But there could be problems with the code.
Thank you

@luckman212 no, this is the proper repo to be forked.

@dennypage Have you had a chance to peek at this yet?

Hey Luke,
Sorry for the delay in responding. It takes a longer to explain a "no" than a "yes."
This type of change isn't something we want to do. A few reasons for this...
Dpinger is written to microseconds as it's standard. Everything internally is calculated in microseconds, and all operational outputs are based on microseconds. While dpinger accepts variants on input, it does not produce variants on output. As a general rule, output variants are a bad idea other than in a GUI, and many UX design experts question them there as well. Use of variants invariably (pardon the pun) results in added complexity, not only in the component itself but in everything that uses the component as well.
It's important to remember that while dpinger is used in pfSense, dpinger itself is a generic tool with a number of use cases. In some of these cases, system logs are fed into processing systems such as ELK or Splunk. Introducing variants in the dpinger output would break backward compatibility in these cases. In addition to the immediate backward compatibility issue, introducing variants in the output would require all future programs/scripts that use the output to include code to handle the output variants produced by dpinger. A small change with significant downstream impact.
Dpinger uses integer arithmetic. Floating point is generally something to be avoided where possible, particularly in a low level components such as dpinger. Introducing floating point would not be worth it just to make the scale of a syslog entry match the scale of a GUI entry. And what if another GUI uses seconds instead of milliseconds?
I'm sorry if this seems harsh. I really don't intend it to be.
FWIW, the use cases in which microseconds are a more natural fit for latency monitoring have grown significantly over the past several years. Ten years ago, 50-100 milliseconds to the ISP used to be common, but not any more. Now it's fairly common these days to be under 10 milliseconds. Looking at pfSense, It may be time to reevaluate the X.Xms and X.XXXms formats. XXXus and X,XXXus may be a better choice. I know, it's not going to happen any time soon, simply because It's always been the way it is.

Thanny Denny. I understand about not breaking compat with other systems. I wasn't really thinking about dpinger being used outside of pfSense.
What about if I create another PR, leaving the default behavior as-is so nothing breaks, but adding a commandline argument -m: log latency values in milliseconds.  And a corresponding PR on the pfSense side to call dpinger using that arg.
There are always what ifs. But this would close a small loop and make everything consistent on pfSense as it exists right now.

As a side note... this would also break compatibility for folk processing pfSense logs with ELK and the like.
A run time conditional, let alone floating point, is not worth it to allow arbitrary scale for a syslog entry. It adds complexity and doesn't solve an actual real-world problem. Also known as an "I prefer it this way" feature. Outside of a UI, it's rarely an appropriate thing to do. If you want to see how this kind of thing devolves, have a look through the history of apinger.
It would be better to allow configurable scale in the UI, allowing the user to select microseconds, milliseconds, or seconds (for the sat folk). And if you wanted to be really spiffy, you could even support auto-scale, but most UX people will tell you that auto-scale is a Bad Idea™.

Ok, well, if the -m flag was added, then it would be trivial to add a knob in pfSense's UI to configure it... would also be straightforward to allow -m to accept a param such as {us, ms, s} for those sat folk.
Again, omitting the option could default to μsec as before so as not to break anything...

At the core of this: That the UI and the system log may have information in different scales is not a problem. You can find examples of different scale all over the place with time, bytes, bandwidth, etc. It's common and not a problem.

Ok, guess we'll close this out then.


cgroup memory: Enchance stats support of memory

Signed-off-by: Ma Shimiao<EMAIL_ADDRESS>

LGTM, ping @rjnagal @mrunalp @crosbymichael for the second LGTM

LGTM, new stats look fine.

LGTM

@Mashimiao Thanks so much for your work !


SONAME for 0.3.0 includes dev

When building the 0.3.0 release, noted that the SONAME of the libraries seems to include dev. For example, on Linux this is libopenblasp-r0.3.0.dev.so (we are building the pthreads version). Typically the .dev is not present.
Edit: Appears this line is the cause.

Meh. Somehow I knew I was going to miss something (that would only be found out after the release), sorry. Opinions please - should 0.3.0 be re-released without the .dev, or should we aim for a 0.3.1 within the next two weeks with everything that gets found&fixed in between ?

Plain make builds will have the same issue, as I did not change https://github.com/xianyi/OpenBLAS/blob/v0.3.0/Makefile.rule#L6 either

I think this is a minor issue. Would just try to fix it in 0.3.1. Mostly was trying to raise awareness.

Yes, best to release 0.3.1.

Set a "due date" of June 30 on the 0.3.1 milestone now.

@martin-frbg Any updates on 0.3.1? Is it still the plan to release 0.3.1 on June 30th? Is there an overview of changes that would be included somewhere?

I have been tagging the more important things with the 0.3.1 milestone here: https://github.com/xianyi/OpenBLAS/milestone/20 - release date depends a bit on how well the new kids on the block behave with their  work on threading and AVX512

@martin-frbg Do you think it makes sense to also tag merged PRs that will be included in 0.3.1 with the 0.3.1 milestone, so people have an auto-updating changelog to look at?

Did not realize that with the branching to 0.3.0 (initiated by xianyi) we lost the convenient "x commits to develop since this release" on the releases pages (or rather, it keeps tracking from 0.2.20). My idea so far is to just merge all changes from develop into the 0.3.0 branch and release from there.

@martin-frbg You can still tag the already merged PRs that are relevant for 0.3.1 (relative to 0.3.0), that would be quite useful imho...
Shouldn't be too much work for you via https://github.com/xianyi/OpenBLAS/pulls?q=is%3Apr+is%3Aclosed+sort%3Aupdated-desc, I assume...

Great way to inflate the list of achievements with duplicates...

@martin-frbg Any delay expected for the planned 0.3.1 release?

I am worried about #1641 of course - the avx512 dgemm issue from #1463 can be easily solved by just removing that new kernel again, but the speedup gained from the new thread setup code would be nice to have in 0.3.1

@martin-frbg As always, we are happy to test the new release before tagging. Please let us know which commit to test.
cc @andreasnoack

#1625 seems to have caused grief for gonum (cannot create as many threads as they used to, but the circumstances are unclear as it is only known that their tests fail, but not exactly what they do internally)

Fixed through #1657 and subsequent release of 0.3.1


The sensitive required input is missing while importing resource

What happened?
Cannot import Tunnel with input secret
while importing Tunnel via pulumi import the warning message show
warning: cloudflare:index/tunnel:Tunnel resource 'cf-tunnel-01' has a problem: Missing required argument: The argument "secret" is required, but no definition was found.. Examine values at 'Tunnel.Secret'

or via import resource option
warning: inputs to import do not match the existing resource; importing this resource will fail

and secret value after perform import action is "", but we cannot modify this because plan replace was failed and document say
Modifying this attribute will force creation of a new resource.

Expected Behavior
User should able to import Cloudflare Tunnel with inputs values which are required and sensitive data
Steps to reproduce

case 1:
** step 1:  run pulumi import cloudflare:index/tunnel:Tunnel example <account_id>/<tunnel_id>
** step 2: select action yes
** step 3: notice that generated code show secret : ""

case 2:
** step 1: create file resources.json
** step 2: add json block below into file

{
	"resources": [{
			"type": "cloudflare:index/tunnel:Tunnel",
			"name": "cf-tunnel-01",
			"id": "<account_id>/<tunnel_id>",
                         "secret": "<secret_base64_value>"
		}
}

** step 3: run  pulumi import -f resources.json
** step 4: notice that the option secret was ignored
*case 3:
** step 1: create code block
example = cloudflare.Tunnel("example",
    account_id="<account_id>",
    name="cf-tunnel-01",
    secret="<secret_base64_value>=",
    opts=pulumi.ResourceOptions(import_=<tunnel_id>)

** step 2: run pulumi up
** step 3: notice that warning message warning: inputs to import do not match the existing resource; importing this resource will fail
** step 4: select actiondetails

*step 5: notice that there is have green line with

+ secret = [secret]

Output of pulumi about
CLI
Version      3.59.1
Go Version   go1.20.2
Go Compiler  gc

Plugins
NAME        VERSION
cloudflare  5.0.0
python      unknown
sentry      0.0.8
vault       5.8.0

Host
OS       darwin
Version  13.2.1
Arch     x86_64

This project is written in python: executable='/Users/<redacted>/venv/bin/python3' version='3.10.6
'

Current Stack: <redacted>
TYPE                                                  URN
<redacted>

Found no pending operations associated with <redacted>

Backend
Name           <redacted>
URL            s3://system-pulumi/<redacted>?endpoint=<redacted>&s3ForcePathStyle=true
User           <redacted>
Organizations

Dependencies:
NAME                 VERSION
json-duplicate-keys  23.2.7
pip                  23.0.1
pulumi-cloudflare    5.0.0
pulumi-vault         5.8.0
pulumiverse-sentry   0.0.8
setuptools           67.0.0
wheel                0.38.4

Pulumi locates its logs in /var/folders/lz/tbk01xsn2x1ckrc3nqtgvw3h0000gn/T/ by default

Additional context
we have a Slack discussion at https://pulumi-community.slack.com/archives/C84L4E3N1/p1679644388599699 with @Frassle
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @bds-congnguyen - as Fraser mentioned, this may be due to the Cloudflare API not exposing access to sensitive data.
We'll take a look into a workaround when we can.


A smaller navbar

Description
The navbar display for pc monitors seems a bit big.
Expected Behavior
I'd like to tone it down a tad and also add some other hover features to the items.

Thanks, this is an issue i was going to open, Do you want to work on this ?

Yes I am working on it


[Epic][Improvement] Testing overhaul

This repo itself only has basic smoketests. In instructlab/instructlab, there are workflow tests that consume this library and confirm that training isn't outright broken, which is a good start.
There are multiple levels of testing that we should aspire to cover.

Unit testing. These ought to prove that our utility functions (e.g. calculating packed batches with FFD) work, that our assertions (e.g. blocking unsupported model architectures) are obeyed, and that our organizational logic (e.g. loading checkpoints and restarting from a given epoch) function correctly.
Correctness and performance testing. If we're making changes to the core training loop, we ought to be able to quickly invoke a test that checks indicators like (a) the behavior of the loss curve, (b) iteration and epoch training time.
Hardware-stack testing: We now support five hardware runtime categories: CPU, MPS, Nvidia, AMD, Intel. We should be able to run appropriate tests on appropriate hardware without having to manually access machines and invoke tests ourselves.

Child issues:

[ ] #377


python311Packages.pypykatz: 0.6.6 -> 0.6.8

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 235069 run on x86_64-linux 1

46 packages built:

crackmapexec
crackmapexec.dist
python310Packages.aardwolf
python310Packages.aardwolf.dist
python310Packages.aesedb
python310Packages.aesedb.dist
python310Packages.aiosmb
python310Packages.aiosmb.dist
python310Packages.aiowinreg
python310Packages.aiowinreg.dist
python310Packages.asyauth
python310Packages.asyauth.dist
python310Packages.asysocks
python310Packages.asysocks.dist
python310Packages.lsassy
python310Packages.lsassy.dist
python310Packages.minikerberos
python310Packages.minikerberos.dist
python310Packages.msldap
python310Packages.msldap.dist
python310Packages.pypykatz
python310Packages.pypykatz.dist
python310Packages.winsspi
python310Packages.winsspi.dist
python311Packages.aardwolf
python311Packages.aardwolf.dist
python311Packages.aesedb
python311Packages.aesedb.dist
python311Packages.aiosmb
python311Packages.aiosmb.dist
python311Packages.aiowinreg
python311Packages.aiowinreg.dist
python311Packages.asyauth
python311Packages.asyauth.dist
python311Packages.asysocks
python311Packages.asysocks.dist
python311Packages.lsassy
python311Packages.lsassy.dist
python311Packages.minikerberos
python311Packages.minikerberos.dist
python311Packages.msldap
python311Packages.msldap.dist
python311Packages.pypykatz
python311Packages.pypykatz.dist
python311Packages.winsspi
python311Packages.winsspi.dist


S3 client for Asia Pacific (Mumbai) cannot connect to buckets in  Asia Pacific (Mumbai)

I checked with US-East(Viginia) region bucket, the code works fine, but same code does not work with Mumbai region bucket
s3 = boto3.client('s3')
filename = 'C:\\IMG_5350.jpg'
bucket_name = 'deletebucket007'
# Uploads the given file using a managed uploader, which will split up large
# files automatically and upload parts in parallel.
s3.upload_file(filename, bucket_name, filename)

error is
botocore.exceptions.ClientError: An error occurred (InvalidRequest) when calling the PutObject operation: The authorization mechanism you have provided is not supported. Please use AWS4-HMAC-SHA256.

You will need to use signature version 4 (s3v4) in that region, as signature version 2 is not supported.

ok and is this the only way to do it
client = boto3.client('s3', config=Config(signature_version='s3v4'))

You can also set the configuration in your config file (aws configure set s3.signature_version s3v4)


Hook beforeDropFile is not working

I have the issue detailed in the filepond-vue repository. Please read that first: https://github.com/pqina/vue-filepond/issues/176
I'm creating this one as well, cause I looked into the Vue component file in that package as well, and there is nothing that is happening differently for beforeAddFile. Then still the beforeAddFile is working and beforeDropFile is not.
Which got me thinking that, it might be some kind of issue with the source repository as well.
Here is the example again for quick reference: https://jsfiddle.net/9vb3cf75/

Please don't double post. I've moved your other issue here.


aarch64 support?

Hello, is it possible to also add an aarch64 build with the releases?

Needs https://github.com/actions/runner/issues/805

looking forward this support ...


Sign in - Error message is not specific if password is not entered

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Lunch the app
Put user name or email
On Password page click on Sign in

Expected Result:
Expected message - Error message should be specific as "Please fill out password field"
Actual Result:
Message is displayed as Please fill out all the fields
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web ✔
iOS ✔
Android ✔
Desktop App ✔
Mobile Web ✔

Version Number:
1.0.88-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on GitHub

The proposal looks coherent. Will tag a CM.

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Issue reproducible during KI retests

Triggered auto assignment to @jamesdeanexpensify (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

@jamesdeanexpensify added the waiting for copy label as we need some copy for the specific error messages described here. I believe we'll actually need this in Spanish as well.
@thesahindia your proposal seems good to me. You'll also need to add the new copy that @jamesdeanexpensify provides here and here.
Here's the Upwork job: https://www.upwork.com/jobs/~0148e14c6f52be895f.

Actually it looks like the spanish translations for existing messages are being handled here, right @Jag96? In which case we just need spanish versions of the new messages.

Thanks @puneetlath
I've applied to the job. Will wait for the translations.

Great! Feel free to start on the PR with some placeholder copy until the final copy is provided by @jamesdeanexpensify.

Got it, so if I'm understanding correctly, we need three pieces of copy:

When both fields are empty, we can say: Please fill out all fields.
When the password field is empty, we can say: Please enter your password.
When the two-factor auth field is empty, we can say: Please enter your two-factor code.

1. When both fields are empty, we can say: Please fill out all fields.

2. When the password field is empty, we can say: Please enter your password.

3. When the two-factor auth field is empty, we can say: Please enter your two-factor code.

Seems good to me!

@jamesdeanexpensify it looks like we don't use a dash in two-factor here. We should probably be consistent yeah?

Ah, I didn't see that screenshot before. I actually think we should update it to the hyphenated version because that's how it's spelled almost everywhere online. Is that possible?

Actually it looks like the spanish translations for existing messages are being handled here, right @Jag96? In which case we just need spanish versions of the new messages.

Yes, https://github.com/Expensify/App/pull/4880 is to ensure that the error message translations happen when switching languages on the sign in form, so now anytime we set formError we'll set the translation key (this.setState({formError: 'passwordForm.pleaseFillOutAllFields'});) rather than setting the translated text (this.setState({formError: this.props.translate('passwordForm.pleaseFillOutAllFields')});)

@jamesdeanexpensify it is possible, but everywhere in our product (.com and .cash) we use the non-hyphenated version. So if we want to change that, let's do it in a separate issue.

Yep, I can take that to a new issue soon. Thanks!

Ok @jamesdeanexpensify @thesahindia I edited both your comments to remove the dash.

We still need spanish translations for these two messages:

Please enter your password. (might be "Por favor, introduce tu contraseña." taken out from here)
Please enter your two factor code.

Hey @thesahindia, for those two sentences:

Por favor, introduce tu contraseña.
Por favor, introduce tu código 2 Factores.

@saracouto should Factores be lower case like the rest of the words?

lower case works I think!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

PR merged. Will be paid 7 days after production deploy if no regressions. Thanks @thesahindia!

🚀 Deployed to staging by @puneetlath in version: 1.0.92-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Paid!


Incorrect character or font?

environment

vim: 9.0 (2022 Jun 28, compiled Sep 30 2023 05:45:56)
vim-airline: 0.11
OS: macos 14.1
What is your airline configuration: default
if you are using terminal:
terminal: alacritty 0.12.3 (5efb069)
$TERM variable: xterm-256color
terminal font: JetBrainsMono Nerd Font

actual behavior

expected behavior

It's not incorrect. That the column number symbol

It's not incorrect. That the column number symbol

How can I set a space after the symbol?

try any of those: https://github.com/vim-airline/vim-airline/blob/master/doc/airline.txt#L374-L375
or perhaps try to explicitly iclude a space after the symbol there.


Cannot add to gradle

Hey, thanks for the library.
Could you please provide clearer instructions on how to add to gradle? With the given instructions it fails to find it.
This is my project-level gradle file:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    repositories {
        google()
        jcenter()

    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.4.0'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

And this is what I've added to my app-level gradle file:
dependencies {
    /** here I've ommited some non issue-related stuff **/
    implementation 'com.lapism.search:search: ASAP'
}

Looking forward to try and use this library in an upcoming project of mine.

Hi. It is not released on Bintray yet because I found some bugs. ASAP is shortcut for As soon as possible :-).

When do you think this will be released?

Probably until Christmas

Probably until Christmas

Eagerly waiting for it :)

waiting

also a wait from here :)


Server connection Error message should provide more context

On trying to connect to the server through the app, error message should provide more context instead of just saying "Failed to fetch backends"

I think we should make this say something like "Unable to connect to server %s; did you spell it correctly?", filling in the server name they typed.

In case of typos in the name yes! Do we have a different message just in case actual server is unreachable?

We can show custom messages when

Not connected to internet
Server doesn't exists on that URL
Text written there is not a valid URL

@timabbott @kunall17 Can i fix this issue?

@saketkumar95 :+1:


added about.html

issue #2
resolved issue 2 by adding about.html

hey I added but do I need to create another pull request

hey I added but do I need to create another pull request

No @tejaswini22199 , you don't have to create another pull request. Also, have you registered as a student at NWoC'20?

hey I added but do I need to create another pull request

No @tejaswini22199 , you don't have to create another pull request. Also, have you registered as a student at NWoC'20?

yes I have registered.

hey I added but do I need to create another pull request

No @tejaswini22199 , you don't have to create another pull request. Also, have you registered as a student at NWoC'20?

yes I have registered.

Okay @tejaswini22199 , I'll merge your pull request after 1st December, so that it's counted for NWoC'20.


Recommend radian in README

Adds a line to the start of the README recommending radian.
This is taking the advice of this comment: https://github.com/Ikuyadeu/vscode-R/issues/415#issuecomment-702347406. I think we pretty much recommend every user of this extension also use radian, so I thought the point about emphasising it in the README made sense.
This PR changes some of the most valuable real estate in the README. If it seems like bad use of that space, feel free to disagree/discuss.

LGTM. Feel free to merge if you have nothing to add.

@renkun-ken Thanks for the review! I will merge.


Auto Updater not working

Cannot check for updates. Might be an issue with getting the current version when compiled as release build.

yup
[*] Please go away Edge!
[*] Hooked into process via IFEO successfully.
[*] Command line args:

--update

System.ArgumentException: The path is empty. (Parameter 'path')
   at System.IO.Path.GetFullPath(String path)
   at System.Diagnostics.FileVersionInfo.GetVersionInfo(String fileName)
   at GoAwayEdge.Common.Updater.CheckForAppUpdate() in C:\Users\jonas\source\repos\GoAwayEdge_v1\GoAwayEdge\Common\Updater.cs:line 154


Manage some tables in database in Wagtail admin interface

If I want some tables in DB to be manageable in Wagtail, Could I do that?
maybe the same way that you can manage data by Form Builder that auto appear in admin interface when you have more than one form?

Hi @KhumpuW
Please use the support group for help with using Wagtail.
But to answer you question, you can use wagtailmodeladmin for that (and this will be merged into Wagtail core soon).

Yes, or you can use django-admin instead.


Is there a way to confirm submit?

Hello! I need to provide to user confirmation dialog on some of my forms, so i wonder if there's confirmation feature?

Hi! You need to interrupt the click event without special parameter, and to show a confirmation dialog. When you click on 'OK' in dialog trigger click event with parameter. For example, my code with using bootbox.js:
$(document).on('click', '[data-sure]', function (e, isPassed) {
        if (!isPassed) {
            e.stopImmediatePropagation();
            e.preventDefault();
            var that = this;
            var data = $(this).data('sure');
            var options = {
                "size":      "small",
                "message":   data,
                "callback":  function (result) {
                    if (result) {
                        $(this).one('hidden.bs.modal', function () {
                            $(that).focus();
                            document.activeElement = that;
                            $(that).trigger('click', [true]);
                        });
                    }
                }
            };
            bootbox.confirm(options);
        }
    });

<button type="submit" data-sure="Are you sure?">Submit</button>

Thanks a lot! I think you should add this example and part of bootbox lib to your project! Awesome! )


@computed does not call update when observed value changes to zero

I have a post on stack overflow trying to figure out how to work around this:  https://stackoverflow.com/questions/49701237/mobx-not-rerendering-react-component-as-used-computed-is-changed
The very comment to look at:  https://stackoverflow.com/questions/49701237/mobx-not-rerendering-react-component-as-used-computed-is-changed#comment86427374_49707046
Sorry about the non-detailed issue.  But this is better than the zero links I was able to find for it, so to whoever it is that finds this, I hope it helps.

please close your issues if they are answered on SO


Automatic Lowpass Filter When Creating Raw Object from Scratch

Hello,
I am creating an mne.io.raw object from a numpy.array (in this case, a variable called 'channels') using the following code:
channel_data, info = create_mne_data_and_metadata(channels, 4000.0)
raw = mne.io.RawArray(channel_data, info)

where
def create_mne_data_and_metadata(channels, sampling_frequency):

    # instantiate metadata for mne
    channel_names = []
    channel_data = []

    # instantiate channel data
    for channel in channels:
        channel_names.append(channel.channel_name)
        channel_data.append(channel.readings)

    # create mne data and metadata objects
    info = mne.create_info(channel_names, sampling_frequency, 'EEG')
    info['sfreq'] = sampling_frequency

    return channel_data, info

However, I am running into a curious thing in which an automatic low-pass filter that is half sampling frequency is automatically applied to my data. This can be seen by inspecting raw.info which returns
<Info | 10 non-empty values
 bads: []
 ch_names: A11, A21, C31, C41, Cz1, E11, E21, F31, F41, Fz1, LAHC1, LAHC2, ...
 chs: 15 EEG, 58 SEEG
 custom_ref_applied: False
 description: ''
 file_id: 4 items (dict)
 highpass: 0.0 Hz
 lowpass: 2000.0 Hz
 meas_date: unspecified
 meas_id: 4 items (dict)
 nchan: 73
 projs: []
 sfreq: 4000.0 Hz
>

This is also the case in the official MNE tutorial, in which creating a raw object with sfreq=200 returns an object with `lowpass=100'.
How might I fix this?

What you are seeing is just the Nyquist frequency, which acts as a "natural" lowpass filter - sampled signals can only contain frequencies up to half the sampling frequency.
It can of course be misleading if you undersample a signal that originally contained higher frequencies. This will result in frequencies above the Nyquist aliased to lower frequencies. So strictly speaking, MNE should probably not automatically assume a lowpass filter if no other information is available. WDYT @larsoner @agramfort?

Correctly sampling a band-passed signal with frequencies above Nyquist is in expert-level signal processing tutorial. I've never seen anyone do in practice in neuroscience. I think if anyone is actually doing this (and I doubt this is actually such a case) then we can just tell the person to ignore that entry -- and I'd expect them to understand why it was put there. Let's just update the docs to say that it's automatically set to half the sampling rate if there is otherwise no low-pass applied to the data.
In much more common/normal cases, our having that entry might correctly imply/teach users that they can't hope to correctly have signals above half their sampling rate (unless they have been very careful as above).

I wasn't even referring to special cases where such sampling might work, but to users forgetting to apply an anti-aliasing filter before downsampling (outside of MNE). Then technically, the lowpass filter at the new Nyquist frequency would be incorrect.
But this is really a very constructed detail, I agree that updating the docs to clarify this is sufficient!

I can try to update this. :)


feat: add cloud deployments docs

Checklist

[ ] run make test
[ ] PR title must follow conventional-commit-standard
[ ] tests and/or benchmarks are included
[x] documentation is changed or added
[ ] commit message and code follows the Code of conduct

@StarpTech build_test got stuck for me a few times now in different PR's. Any idea?

No idea, need to investigate.


Orion Class and Functional API

Resolve #79 : Implement the Orion class
Resolve #80 : Implement the new functional interface
Also setup Github Actions and update the README/docs

Codecov Report

Merging #81 into master will increase coverage by 20.26%.
The diff coverage is 99.33%.

@@             Coverage Diff             @@
##           master      #81       +/-   ##
===========================================
+ Coverage    9.64%   29.90%   +20.26%
===========================================
  Files          15       17        +2
  Lines         954     1100      +146
===========================================
+ Hits           92      329      +237
+ Misses        862      771       -91

Impacted Files
Coverage Δ

orion/core.py
98.87% <98.87%> (ø)

orion/__init__.py
100.00% <100.00%> (+11.11%)
:arrow_up:

orion/evaluation.py
32.39% <100.00%> (-0.94%)
:arrow_down:

orion/functional.py
100.00% <100.00%> (ø)

orion/metrics.py
100.00% <100.00%> (+81.25%)
:arrow_up:

orion/primitives/intervals.py
78.12% <0.00%> (+78.12%)
:arrow_up:

orion/primitives/detectors.py
90.00% <0.00%> (+90.00%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e3154...848b5cd. Read the comment docs.


Error getting image from database

logs
Compiler message:
lib/HomePage.dart:53:42: Error: Place positional arguments before named arguments.
Try moving the positional argument before the named arguments, or add a name to the argument.
      backgroundColor: Color(0xff21254a),,
                                         ^
lib/HomePage.dart:53:42: Error: Expected an identifier, but got ','.
      backgroundColor: Color(0xff21254a),,
                                         ^
lib/HomePage.dart:53:42: Error: Expected named argument.
      backgroundColor: Color(0xff21254a),,
                                         ^
lib/HomePage.dart:52:24: Error: No named parameter with the name '#1'.
    return new Scaffold(
                       ^^...
/F:/Android/flutter/packages/flutter/lib/src/material/scaffold.dart:979:9: Context: Found this candidate, but the arguments don't match.
  const Scaffold({
        ^^^^^^^^
Restarted application in 417ms.
Reloaded 4 of 508 libraries in 1,049ms.
Reloaded 4 of 508 libraries in 901ms.
Reloaded 4 of 508 libraries in 806ms.
I/SurfaceView(19804): updateSystemUiVisibility, blackBackground = false, viewVisibility = 0, appBounds = Rect(0, 0 - 720, 1440), mScreenRect = Rect(0, 0 - 720, 1356), surface = io.flutter.embedding.android.FlutterSurfaceView{ff4c83e V.E...... ......I. 0,0-720,1356}
D/FlutterView(19804): Detaching from a FlutterEngine: io.flutter.embedding.engine.FlutterEngine@daebe54
I/OpenGLRenderer(19804): Initialized EGL, version 1.4
D/OpenGLRenderer(19804): Swap behavior 1
W/RenderThread(19804): type=1400 audit(0.0:22544): avc: denied { search } for name="kgsl-3d0" dev="sysfs" ino=22816 scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:sysfs_kgsl:s0 tclass=dir permissive=0
W/Adreno-ES20(19804): <get_gpu_clk:229>: open failed: errno 13
W/Adreno-EGL(19804): <qeglDrvAPI_eglGetConfigAttrib:612>: EGL_BAD_ATTRIBUTE
W/Adreno-EGL(19804): <qeglDrvAPI_eglGetConfigAttrib:612>: EGL_BAD_ATTRIBUTE
I/SurfaceView(19804): updateSystemUiVisibility, blackBackground = false, viewVisibility = 0, appBounds = Rect(0, 0 - 720, 1440), mScreenRect = Rect(0, 0 - 720, 1356), surface = io.flutter.embedding.android.FlutterSurfaceView{ff4c83e V.E...... ......ID 0,0-720,1356}
D/FlutterView(19804): Attaching to a FlutterEngine: io.flutter.embedding.engine.FlutterEngine@daebe54
W/1.gpu   (19804): type=1400 audit(0.0:22545): avc: denied { search } for name="kgsl-3d0" dev="sysfs" ino=22816 scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:sysfs_kgsl:s0 tclass=dir permissive=0
W/Adreno-ES20(19804): <get_gpu_clk:229>: open failed: errno 13
W/Adreno-EGL(19804): <qeglDrvAPI_eglGetConfigAttrib:612>: EGL_BAD_ATTRIBUTE
W/Adreno-EGL(19804): <qeglDrvAPI_eglGetConfigAttrib:612>: EGL_BAD_ATTRIBUTE
I/flutter (19804): Image Url: https://firebasestorage.googleapis.com/v0/b/blog-8c8f3.appspot.com/o/Post%20Image%2F2019-12-31%2003%3A09%3A37.024688.jpg?alt=media&token=0cf6ac7c-a2cd-4e7b-b85c-da21d8f3488c
I/flutter (19804): Length: [Instance of 'Posts'].length

════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building:
'package:flutter/src/painting/_network_image_io.dart': Failed assertion: line 22 pos 14: 'url != null': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=BUG.md

When the exception was thrown, this was the stack
#2      new NetworkImage
#3      new Image.network
#4      _HomePageState.postsUI
#5      _HomePageState.build.<anonymous closure>
#6      SliverChildBuilderDelegate.build
...
════════════════════════════════════════════════════════════════════════════════

════════ Exception caught by widgets library ═══════════════════════════════════
The following assertion was thrown building:
'package:flutter/src/painting/_network_image_io.dart': Failed assertion: line 22 pos 14: 'url != null': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=BUG.md

When the exception was thrown, this was the stack
#2      new NetworkImage
#3      new Image.network
#4      _HomePageState.postsUI
#5      _HomePageState.build.<anonymous closure>
#6      SliverChildBuilderDelegate.build
...
════════════════════════════════════════════════════════════════════════════════

here is my code link blog

Hi @sadsouler
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you

I check that it's not personal assistance whenever I run or debug the app then it tells me to contact flutter dev.

Hi @mrfoxie
can you please provide your flutter doctor -v,
your flutter run --verbose and a reproducible minimal code sample
(the link you provided doesn't seem to work)
Thank you

i just closed that project


Update Lodash due to vulnerabilities

Q
A

Bug fix?
[x]

New feature?
[ ]

New sample?
[ ]

What's in this Pull Request?
A number of vulnerabilities exist in the currently included version of
Lodash:
CVE-2018-16487
CVE-2019-10744
CVE-2018-3721
CVE-2019-1010266
This updates Lodash to 4.17.15, the current latest version. All of the
listed vulnerabilities are fixed in this version.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JakeStanger sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   73.31%   73.31%
=======================================
  Files          18       18
  Lines         802      802
  Branches      164      164
=======================================
  Hits          588      588
  Misses        164      164
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3baf5...971f5e6. Read the comment docs.

Closing this in favour of dependabot #440


Adopt clearcase-ucm-plugin

This is a follow up to https://github.com/jenkins-infra/repository-permissions-updater/pull/2494#discussion_r851732566, apparently I grep'ed the wrong file 🤦🏻
https://github.com/jenkinsci/clearcase-ucm-plugin
Permission is granted here: https://github.com/jenkins-infra/repository-permissions-updater/pull/2494#issuecomment-1100819398
Description

Submitter checklist for adding or changing permissions

Always

[X] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[X] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

I don't have write permissions on the repository 👀

done


Extract macro to new crate

Closes https://github.com/idanarye/rust-typed-builder/issues/31#issue-552916434
Updated the edition to 2021 and removed extern crate proc_macro; because it did not help at the end: https://github.com/idanarye/rust-typed-builder/issues/57#issuecomment-930505830

@idanarye I am not sure about what to do with the bottom types for repeated and required fields: https://github.com/idanarye/rust-typed-builder/issues/31#issuecomment-578324069
You said that you would like to remove the one for required fields and keep the one for repeated fields, but on the other hand, the error for repeated fields points to the method with the name of the field. Therefore, we could just replace both bottom types with Missing_Required_Fields and Repeated_Field_Assignment.

This is weird, but now that I check again the repeated value error does not show the type in the rust-analyzer virtual text diagnostics and missing value does:

This is the opposite of what I've observed in #31. But it's actually better, because repeated value is easy to figure out even without the type name as the hint.
This means that I no longer mind having a Repeated_Field_Assignment, but I still want to generate Missing_Required_Field_*. Maybe when we get a const generic string we can use that instead.

@idanarye Thanks for merging!
We might need to adjust the CI if we add tests to the macro crate. I think we should use a workspace and add --workspace to the cargo test command. Should I submit a PR?

Why? All the tests are still main crate, not the proc-macro crate. They still run with a regular cargo test.

I just thought about the scenario of adding a test to subcrates that would not be run in the CI.
Aslong as we keep all tests there, there is no problem.

All the tests go in the tests directory at the project's root. I don't see why there should ever be a need to add some to the macro subcrate.


Implement Login/Signup System

👋 Hi there!
I'm excited to contribute to the WildGuard project! I’d like to propose adding a Login/Signup System for user authentication.
Why This Is Important:
User Personalization: Users can save preferences and track activities.
Security: Protects user data and builds trust.
Proposed Implementation:
Login/Signup Buttons: Add buttons to the navigation bar for easy access.
User Authentication: Implement a secure backend to manage user credentials.

Thanks for creating the issue in WildGuard! The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

Don't forget to follow @anuragverma108 – Project Admin & @PriyaGhosal-Project Collaborator  – for more updates!
We're excited to see your contribution as part of Hacktoberfest 2024! 🎉
Happy open-source contributing!


docs: generate Java data models that overwrite GetHashCode method

Description
Added example on how to generate a model to overwrite the GetHashCode method
https://github.com/mahakporwal02/modelina/tree/issue/422/examples/java-generate-hashcode
Updated documentation.
https://github.com/mahakporwal02/modelina/blob/issue/422/examples/java-generate-hashcode/README.md
https://github.com/mahakporwal02/modelina/blob/issue/422/examples/README.md
https://github.com/mahakporwal02/modelina/blob/issue/422/docs/languages/Java.md
Related issue(s)
fixes #422

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.575%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2368

Relevant Lines:
2414

💛  - Coveralls


fix(cookie): Use different cookies when using Xavante

Coverage decreased (-3.5%) to 79.465% when pulling a0aa48e64cba9f153256f4a0e069bd75bd15c337 on xavante-cookies into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on master.


Update request: swayimg 2.3 → 3.1

Package name: swayimg
Latest released version: 3.1

Current version on the unstable channel: 2.3
Current version on the stable/release channel: 2.2

[X] Checked the nixpkgs pull requests

Notify maintainers

@MatthewCroughan
Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Can be closed by #337114


uniform handling of implicitly declared (aka mandated) and synthetic parameters

Resolves #45

Draft for now, because this PR is a bit inefficient in how methods are serialized. Most of the time, both parameter arrays (signature-based and descriptor-based) are identical, in which case, we really should only serialize one. Need to work on that.

Actually my comment above is wrong. Type arrays are interned and the intern pool is serialized once. When serializing a method, we only write down an index into the intern pool.
We could still check whether the 2 parameter arrays are different, and if they are identical, we'd just write down a boolean flag. If they are different, we'd write down a boolean flag and the index into the intern pool. That makes a difference of roughly 50 kB when indexing OpenJDK 8 rt.jar, which is IMHO negligible (the entire index has roughly 6 MB).


Do we need validMin/validMax?

Currently, a range object may include validMin/validMax properties, but it is unclear what purpose these have since in JSON there is no need for a missing-value number encoding (=null). So the only purpose could be to give clients a hint about the possible value range and use that for legends, but since legends depend on context and user preference this is not that useful information in the end.
I therefore propose to either remove those properties or redefine them as actualMin/actualMax or something like that which would reflect the precise min/max value occuring in the data.

I tend to agree. actualMin/Max should be optional, with a “health warning” that data providers should make sure that these are accurate. Maybe for v1 we could omit actualMin/Max and see if we need it?
The only reason for keeping validMin/Max is if we want to have several different kinds of missing values, which could be encoded as different out-of-range values. But this is probably much better handled as a mask field of some kind.

Ok, I will remove validMin/max then. About missing values, I agree it's better to use a regular parameter for that since then we have everything we need for free, like reason categories etc. Also I would not introduce a sparse (or other) range encoding for now for those masks, for simplicity. If we really come across a dataset which would benefit from it we can reevaluate it.


Scan only running parseDynamo on the first item

Things had been going swimmingly using serverless.com, lambda, api gateway, dynamodb and dynamoose. Between 3am and 10am PDT on the 30th of August my scan responses started to send back raw dynamodb JSON for all but the first item.  When I use the serverless invoke local functionality it parses all the items but the deployed functions on AWS Lambda only parse the first "Item".
I turned on debug on the lambda function and here is the relevant part of the output:
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:scan scan response { Items:
[ { updatedAt: [Object],
createdAt: [Object],
group: [Object],
order: [Object],
id: [Object],
name: [Object],
type: [Object] },

...

{ updatedAt: [Object],
createdAt: [Object],
group: [Object],
order: [Object],
id: [Object],
name: [Object],
type: [Object] },
{ updatedAt: [Object],
createdAt: [Object],
group: [Object],
order: [Object],
id: [Object],
name: [Object],
type: [Object] },
{ createdAt: [Object],
order: [Object],
id: [Object],
name: [Object],
updatedAt: [Object],
type: [Object] } ],
Count: 45,
ScannedCount: 45 }
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:model applying virtuals
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parsing date from<PHONE_NUMBER>097
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: updatedAt : "date" : "2017-08-30T08:26:21.097Z"
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parsing date from<PHONE_NUMBER>097
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: createdAt : "date" : "2017-08-30T08:26:21.097Z"
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: group : "string" : "Movement"
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: order : "number" : 30000
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: id : "number" : 4200
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: name : "string" : "Smooth"
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:attribute parseDynamo: type : "string" : "Camera"
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:schema parseDynamo:
{
    "updatedAt": "2017-08-30T08:26:21.097Z",
    "createdAt": "2017-08-30T08:26:21.097Z",
    "group": "Movement",
    "order": 30000,
    "id": 4200,
    "name": "Smooth",
    "type": "Camera"
}

Wed, 30 Aug 2017 17:43:22 GMT dynamoose:scan scan parsed model NewModel {
updatedAt: 2017-08-30T08:26:21.097Z,
createdAt: 2017-08-30T08:26:21.097Z,
group: 'Movement',
order: 30000,
id: 4200,
name: 'Smooth',
type: 'Camera' }
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:model applying virtuals
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:scan scan parsed model NewModel {
updatedAt: { N: '1504081581097' },
createdAt: { N: '1504081581097' },
group: { S: 'Framing' },
order: { N: '20000' },
id: { N: '3700' },
name: { S: 'Medium' },
type: { S: 'Camera' } }
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:model applying virtuals
Wed, 30 Aug 2017 17:43:22 GMT dynamoose:scan scan parsed model NewModel {
createdAt: { N: '1504081581097' },
order: { N: '50000' },
id: { N: '2200' },
name: { S: 'Dark' },
updatedAt: { N: '1504081581097' },
type: { S: 'Emotion' } }

...

END RequestId: b6ede485-8daa-11e7-8f68-57777830a467

As you can see the debug calls to dynamoose:attribute parseDynamo dynamoose:schema do not happen for Items 1 - N.
Here was my scan code:
  Tag.scan()
    .all()
    .exec()
    .then(result => callback(null, success(result)))
    .catch(err => callback(null, failure(err, { status: false })));

I mangled it to do the conversion manually and got the response I expected. All JSON converted to normal objects. Here is that code:
  Tag.scan()
    .all()
    .exec()
    .then(result => {
      result = result.map(item => {
        const t = new Tag();
        t.$__.schema.parseDynamo(t, item);
        return t;
      });
      callback(null, success(result));
    })
    .catch(err => callback(null, failure(err, { status: false })));

I'm at a loss as to why this is happening, the code makes sense (both mine and yours). I think I'm going to have to hack in my parsing for now and move on. Hope we can find a solution.
-Trevor

Ok, so I rolled my API code back 2 revisions and tried it. Still the same issue. Here is a network request from my app in Chrome.
[
  0: {
  createdAt: "2017-08-30T08:26:21.097Z"
  id: 4200
  name: "Smooth"
  updatedAt: "2017-08-30T08:26:21.097Z"
  }
  1: {
  createdAt: {N: "1504081581097"}
  group: {S: "Framing"}
  id: {N: "3700"}
  name: {S: "Medium"}
  order: {N: "20000"}
  type: {S: "Camera"}
  updatedAt: {N: "1504081581097" }
  }
  ...
]

As you can see, the second item has attributes that I added at a later date like group, and order. If you look in the DynamoDB table the first item (id: 4200) has those attributes as well but because it's been parsed by the schema they were filtered out.

I'm also seeing this in 0.8.4 but works properly in 0.8.3.

I'm on 0.8.3.  So frustrating. I've spent the last 6 hours trying to figure out why.

Even worse is that it worked when I went to bed and didn't work when I woke up. I'm pretty sure I didn't change anything while I was asleep which leads me to think something was updated on the DynomoDB end but there's no info about it.

Solved.
I had "dynamoose": "^0.8.3", in my package.json. So many nasty things in my head right now. That @#$% little *&%$# ^ symbol. During the serverless deploy it must grab the latest versions of everything it can because I just checked and the compiled package being sent to AWS Lambda was 0.8.4. Locally I'm still on 0.8.3 so when I invoke locally everything works just fine.
😡 6 F-ing hours over this.... no words.

Hmm, it is definitely working for us on 0.8.3. Try making sure you're definitely using 0.8.3. I realized I had "^0.8.3" in my package.json and 0.8.4 was getting installed. Changed package.json to "0.8.3".

Yes, sorry, still getting over my frustration. I have since removed the ^ from my package.json file and all is well now.

I can confirm this is bug in version 0.8.4

Moral of the story is to NEVER EVER allow your package manager to pick the version. Lock it down 100% and only make changes when you decide to. I have just finished doing that with this project and will remember to do so for the rest of my days.

My apologies to @brandongoode for cluttering up this bug report my rants.

@tsdorsey Sorry about the bug -- no need to apologize.  Let me see if I can figure out what broke.

@brandongoode I would also suggest taking down the 0.8.4 release on npm.

unpublish was the first thing I did -- About to push 0.8.5 without the map error

Hi guys you can solve your issue using AWS-SDK... dynamoose does not have deep parse for your json...
{
payload: {
     type: Map,
     required: false,
     toDynamo: AWS.DynamoDB.Converter.input,
     fromDynamo: AWS.DynamoDB.Converter.output,
 }
}

@dmitrirussu I'm very confused about your question or problem. One thing that recently I figured out. If you are using Map or List. You have to pass in a map or list property. I also believe the types, map and list have to be strings.
See https://github.com/dynamoosejs/dynamoose/issues/230#issuecomment-361412970, for more information.
Also see #445, and #446.
Overall this is an area where the documentation is VERY poor. I'm still trying to wrap my head around it a bit more, then will work on updating the documentation.
Finally, you shouldn't need to set toDynamo and fromDynamo to the AWS.DynamoDB.Converter. Dynamoose handles that for you.


[Enhancement] optimize count distinct

Fixes #issue
Main work

For scenarios where pre-aggregation needs to be forced in the distinct local and local stages, using stream agg operator with force_streaming mode instead of setting them to blocking agg operator.
According the test result, redesign the strategy about how to choose two-stage, three-stage or four-stage agg.

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 42 / 42 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/SplitAggregateRule.java
21
21
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/implementation/HashAggImplementationRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/planner/AggregationNode.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PruneAggregateNodeRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/physical/PhysicalHashAggregateOperator.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/AddDecodeNodeForDictStringRule.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 42 / 42 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/SplitAggregateRule.java
21
21
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/implementation/HashAggImplementationRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/planner/AggregationNode.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/PruneAggregateNodeRule.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/operator/physical/PhysicalHashAggregateOperator.java
11
11
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/tree/AddDecodeNodeForDictStringRule.java
2
2
100.00%
[]


Don't care fetch

Introduces the DontCare component that can be used to create queries dont care if the entity have or not some component;
I run in these two main uses cases:

Query if an entity still exists or not:

fn sys(query: Query<DontCare>) {
    if query.get(entity).is_ok() {
        // Entity exists
    } else {
        // Entity doesn't exists
    }
}

Check if some component had been removed:

fn sys(query: Query<DontCare, Without<Parent>>) {
    if query.get(entity).is_ok() {
        // Parent got removed from entity
    }
}

It's very situacional but also might be useful.
Now that I'm thinking on it maybe this could be easly replaced by simple using Entity, oh well ...

Yeah, just doing a Query<Entity> and then calling .get on that query would work smoothly :)


Broken test data in valid-compositions-1.x.json

Hi,
working on cyclonedx-rust-cargo, I'm experiencing failed integration tests when verifying against valid-compositions test data.
In valid-compositions-1.[3-5].json and valid-compositions-1.[3-5].textproto, there is an assembly<EMAIL_ADDRESS>However, in the BOM there is no component with this string as a bom-ref. In fact the corresponding component is missing the bom-ref attribute, see code snippet below.
This breaks the integration tests at cyclonedx-rust-cargo.
The XML files are not affected: bom-ref is defined at the component correctly.
Broken definition in JSON:
"components": [
    [...]
    {
      "type": "library",
      "name": "Acme Library",
      "version": "3.0",
      "purl"<EMAIL_ADDRESS>    }
  ]

Fixed definition in JSON:
"components": [
    [...]
    {
      "bom-ref"<EMAIL_ADDRESS>      "type": "library",
      "name": "Acme Library",
      "version": "3.0",
      "purl"<EMAIL_ADDRESS>    }
  ]

Thank you for the report, @tokcum . Again 👍
Could you pullrequest the fixed version that worked for you?
Having the diff as a working "expected input" would help analyze the issue and possibly forward-port it to 1.6-dev.


Update cheatsheet.md

"List all pods in the namespace, with more details" command corrected by adding --all-namespaces

/check-cla

/assign @gochist

/lgtm
/approve


Cannot edit displayed speed unit "m/s"

I'm trying to change the velocity units in add_velocity but it seems that any change in the display_options dictionary is ineffective. My main goal is to be able to display a different string rather than "m/s", as I can do the math conversion for the numbers before feeding them to the add_velocity module.

This is an ipyleaflet issue. I have submitted a PR https://github.com/jupyter-widgets/ipyleaflet/pull/1199 to fix it.


Finetuning fp32 model in fp16 mode can lead to (many) dropped batches even with --fp16-scale-tolerance=0

🐛 Bug

To Reproduce
Steps to reproduce the behavior (always include the command you ran):
I don't have a small enough MWE...

Run any finetuning command on a model originally trained in fp32 mode but include:

--fp16
--fp16-scale-tolerance 0

You should be dropping batches.
To debug, include a print or debug hook in the else branch here:
https://github.com/pytorch/fairseq/blob/5e82514d687289a73a6dec33b555217acd97cb0d/fairseq_cli/train.py#L210-L219
With some luck, you'll drop all batches in an epoch and fail training cause of an undefined variable (that is first declared in a never-taken path in the loop.

Code sample

:(
Expected behavior

Overflow failures that drop entire batches shouldn't be silently ignored.
Better handling of model conversion from fp32 to fp16.

Environment

fairseq Version (e.g., 1.0 or master): 0.9
PyTorch Version (e.g., 1.0): 1.6
OS (e.g., Linux): Ubuntu 18.04
How you installed fairseq (pip, source): git tag 0.9.0 with debugging changes added
Build command you used (if compiling from source):

python setup.py build_ext --inplace
pip install --user .

Python version: 3.6.9
CUDA/cuDNN version: 10.2/
GPU models and configuration: 1x V100 SXM2
Any other relevant information: N/A

Additional context

Can you try using fairseq master instead of 0.9.0?
Anyway, this is most likely model/dataset dependent, but I will try this a bit later and see what’s going on.
To confirm, what kind of task/model is this?

I'll check.
It does seem to depend on model/dataset. But is the batch-skipping behavior actually intentional? Why? Why not repeat with updated loss scale until it's correct?
Translation with pre-trained transformer_vaswani_wmt_en_de_big (transformer.wmt14.en-fr) from here (https://github.com/pytorch/fairseq/tree/master/examples/translation#pre-trained-models).

This still occurs with the latest master :/

This still occurs with the latest master :/


Generate a managed plugin that uses instrumented vDVS plugin binary

since docker 1.13 vDVS is installed as managed plugin, there should be a way to generate managed plugin that consumes instrumented vDVS test-coverage plugin binary.

This is required for reporting plugin code coverage.

@shuklanirdesh82  to add details of the investigation so far.

Reference https://github.com/vmware/docker-volume-vsphere/pull/1633#issue-245526969 for more information.
Following steps were performed to test out generated binary

1. make clean build-all
2. copying build/vdvs-instrumented to docker host
3. run instrumented binary instead of installing plugin
./vdvs-instrumented -test.coverprofile=e2e.cov &
4. Run some basic test make test-e2e -test.run "*Basic*" (locally changed the tag to pick up basic test only)
5. hit ctrl+c to end the program (on the docker host where step#2 is performed)
6. look for e2e.cov is generated into the current directory
7. later e2e.cov would be passed to go tool cover to analyze further.


Task notifications

When a counselor assigns a task to a student, the notification that pops up will reappear everytime the page is refreshed, even after closing it.

I haven't fixed the timestamp difference yet, but the notifications now disappear when the page is refreshed!


Prevent controller from changing spec

This PR is split from https://github.com/hellofresh/kangal/pull/44.
Currently loadtests have some empty or hardcoded spec (master/worker image details) when created by the proxy, and the controller later mutates this value. This behavior is not ideal; the spec should be immutable once the resource is created.
This PR:

Removes SetDefault in the controller which mutates loadtest spec.
Updates the proxy to consume backends.Config environment variables and use this when creating a new loadtest.

This is done so the spec will never have empty spec fields

Adds 4 environment variables (JMETER_MASTER_IMAGE_NAME, JMETER_MASTER_IMAGE_TAG, and the same for worker) to specify default images.

This is done to allow users to specify custom images used for the loadtest backend.
It was already available in locust, this PR simply adds the same capability for JMeter.

+1


MAINT: review process document

Currently we have a notebook_review_process, but it is not included in the rendered pages.
@jkrick - please advise where would you like to see it in https://nasa-fornax.github.io/fornax-demo-notebooks/? Maybe a new, Contributor Documentation below the currently existing User Documentation?

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

I am still waiting on input on the document from other team members, so for now, it should not be included anywhere.  But, once it gets a review, I'd take your recommendation on where to put it.


dotfiles should be ignored

This was entirely puzzling to me when I first saw it. I would edit a file in vi, and once I opened it I could no longer start my application.

SyntaxError: Unexpected token ILLEGAL
at Object.parse (native)
at [object Object]._load (/..../node_modules/backbone-stash/node_modules/stash/stash.js:102:32)

The issue appears to be that backbone-stash is trying to load up vi's swp files. We should at stronger checks for what files we load and always ignore dotfiles.

@miccolis - this needs to be fixed upstream - care to move issue there?

Ah, yep https://github.com/developmentseed/stash/issues/4


[Proposal] New Building Block: Centralized Cache Store

In what area(s)?
/area runtime
Describe the proposal
This is a working proposal mentioned during a recent conversation on Discord about my proposal for a new and specialized key/value store and how there are a number of providers though to be key/value implementations that wouldn't clear my bar for inclusion because of lack of support for core functionalities. Enter this proposal then that seeks to offer a lower bar for key/value store-like functionality but, as it's another of my specialized store proposals, it features an API specific to a distinct type of key/value store: the centralized cache.
This proposal rethinks the existing state store to imagine a world in which the store API can be free of ill-fated design decisions and from which a fresh start can be enjoyed that favors a concise, simple API that provides a cache capability and nothing more. Should a developer want something more from the API such as a mechanism to do prefix key queries or query the values for some constraint, they're encouraged to turn to specialized stores for that functionality, such as the proposed Key/Value Store and Document Store, respectively.
What's the purpose of a cache?
A cache should temporarily store some data (typically something not too large) alongside a key for some specified amount of time. While there are variations of the concept that distribute the cache across multiple points of failure (introducing the CAP theorem trade-off of limiting consistency in favor of availability) or even just implement a local in-memory cache accessible to perhaps even just a single class, this proposal seeks to implement a cache offering using a centralized provider and not trying to implement the sidecar as some sort of distributed cache provider (though this could just as easily be the focus of another specialized state store proposal).
What does this proposal involve and how does it differ from the key/value store proposal?
We're looking to target an ever-so-slightly different piece of the key/value store pie with this proposal in that it targets those developers who expect to have small chunks of data that expire over time, who know the keys they'll be engaging with and who need increment/decrement support for in-place updates.
As caches are often designed for rapid retrieval, they're often hosted in-memory which means that developers aren't intended to necessarily store enormous values alongside their keys. As such, this proposal will not support streaming operations, but will instead set and return whole values. Perhaps the API should enforce a maximum size for operations so as not to overwhelm the sidecar?
The providers for this proposal will differ from the Key/Value Store proposal as memcached might be a good fit here where it's not there since it doesn't support key prefix queries. But it does support TTL and has increment/decrement support, so it'd be a better fit in this space.
This proposal might support ETag (or at least a consistency value) pending further research into just how many providers support it natively. TBD.
What will this proposal not cover?
We're looking to build a very specialized state building block here that emphasizes temporary reads and occasional writes and updates of small chunks of data that can be manipulated in minute ways, but this will not cover the following supported by today's state management building block:

Any sort of query against keys
Transactions
Consistency operations
Won't be compatible with actors (and thus workflows) because of lack of ETag and transaction support

Interface
The Centralized Cache components should be able to implement all of the following capabilities using asynchronous methods that minimize back and forth operations with the sidecar. While the key should be represented as a string, the value should also be stored as a string. How it does this is an implementation detail left to the SDK, but it should be uniformly done so that values set by a C# client can be read back out by a JavaScript client.
No additional metadata should be collected regarding the various types of data stored or other operations performed based on the type being operated on - this store is simply an abstraction for storing strings as keys and value to and from the provider.
If the user desires more elaborate provider-specific functionality, they should be advised to use the SDK for that provider rather than this abstraction.
The naming in the following tables matches the naming used in the Key/Value store proposal for consistency.

Name
Description
Notes

TryAdd
Adds the specified key and value to the store along with a floating (3 days from now) timespan, returns true if successfully added or false if the key already exists.
In other words, this doesn't seek to overwrite an existing key.

Set
Adds the specified key/value to the store and updates with the given value even if the key already exists.
This one will always overwrite even if the key is already used.

TryGet
Attempts to get the value for a given key.
Returns true and the value if the result is retrievable and returns false if not.

TryRemove
Tries to remove the value with the specified key from the store

TryIncrement
Tries to increment a value stored as the string representation of an unsigned int64 by the provided value
Will return true if the operation is successful or false if not (e.g. the key does not exist).

TryDecrement
Tries to decrement a value stored as the string representation of an unsigned int64 by the provided value
Will return true if the operation is successful or false if not (e.g. the key does not exist).

Thoughts about the SDKs
I'm generally going to speak about the .NET SDK here as it's the only one I'm personally familiar with, but I'd urge the same principals to be applied to the other language SDKs as make sense.
I propose that the SDKs take advantage of the clean split to similarly break out specific support for the functionality from a single unified DaprClient with an increasingly dense method space and instead implement a specific DaprCentralizedCachedClient suited specifically for this purpose.
Today, there's a Dapr.Client and Dapr.Client.AspNetCore NuGet package wherein the latter primarily just includes dependency injection registration support with Microsoft.Extensions.DependencyInjection. I would bundle these into a single Dapr.State.CentralizedCache NuGet package that includes the DI extension methods for anyone that wants to use them while also keeping the DaprCentralizedCacheClient public and accessible if not.
In other words, after installing the Dapr.State.CentralizedCache package to their project, they can call builder.Services.AddDaprClient().AddCentralizedCacheStateStore() or builder.Services.AddDaprCentralizedCacheStateStore() to register the DaprKeyValueClient which is a narrow SDK implementation of only those functionalities necessary to facilitate interaction with this new cache state store via Dapr.

Makes it easier for developers to call the right methods pertaining to what they're doing (e.g. Intellisense doesn't overwhelm them with every possible action as only the narrow few available to their specific SDK are available).
Makes ongoing maintenance and testing easier since the all the code not directly shared between pieces is sectioned off to wholly separate directories (e.g. you don't have a single file with umpteen tests in it since all the methods it calls are in the one file).
Speaks to developer concern about bloated installs containing 90% more code than the limited functionality they were seeking to use (I don't know to what degree the Dapr .NET or other SDKs are trimmable/tree-shakable/whatever other languages do)
We're already doing this with Workflow, one of the newest building blocks in that in the .NET SDK, it is implemented via its own dependency injection extension and workflow-specific client from the same package.

Final Thoughts
This seeks to provide a narrow and purpose-driven API specific to developers looking to augment their applications with cache support for the standard features they want to abstract across a collection of providers.
Thank you for the consideration!

@WhitWaldo I wonder about the notion of not having some sort of "list keys" operation, even if perhaps optional (for those backing stores that truly cannot support it) or well understood to be potentially inefficient and therefore not recommended for use in production.  One of the significant limitations of providing tooling for Dapr is the lack of observability of its stores.  While I wouldn't want to try to create a "one size fits all" query API, providing no ability to understand what's in a store feels like repeating a past mistake.

@philliphoff, I had a conversation with @berndverst this last week in Discord regarding my other proposal for a key/value store and my larger approach to more specialized state stores, and they were quite adamant about not supporting optional interfaces any longer. Given the great many specialization opportunities, I'm inclined to agree. And precisely not all stores support some sort of key-list operation, I'm inclined to not make it a part of the proposal.
If developers need some key observability, turn to my proposal at #7338 where I suggest there be key-prefix filtering (beats a full key dump) and precious little else. And in lieu of that, there's no reason why one couldn't build a pluggable component that combines both the cache store and the key/value store and makes their own key index complete with any sort of non-native filtering they want.
Here though, I'm targeting a use case where the key is derived through something else (e.g. shopping cart ID or some time-dependent hash with an identifier) and a lookup isn't really necessarily since the values aren't long-lived enough for them to accumulate much. There's TTL support and tentatively ETag as well as inc/dec single-trip operations, but that's about it.

/assign

/nostale


Add proposal for features contributing lifecycle scripts

ref: https://github.com/devcontainers/spec/issues/60, https://github.com/devcontainers/spec/issues/181

Hi @Cindys82, could you let us know what you're trying to get working (i.e. which app), and if you have any specific issues you can share? Thanks so much!

https://apps.apple.com/tw/app/星城online-星幣爭霸戰搶億萬彩金/id919043762


New-NetworkControllerLoadBalancingRule - Example 1 is literally missing half its content

It appears that whomever made this page didn't copy/paste the Example code correctly. The last line is cutoff mid-cmdlet and the entire block of code that should be referencing the actual cmdlet being documented is missing. Without the bottom of this Example, this is effectively worthless.
I believe the example was trying to mimic some of what was here:
https://docs.microsoft.com/en-us/windows-server/networking/sdn/manage/configure-slb-and-nat

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2baf5bb7-2171-2449-fd6b-8f750ffab45f
Version Independent ID: 56432f1f-822c-fcc3-34e8-b837882f7893
Content: New-NetworkControllerLoadBalancingRule (NetworkController)
Content Source: docset/windows/networkcontroller/New-NetworkControllerLoadBalancingRule.md
Product: w10
Technology: ****
GitHub Login: @Kateyanne
Microsoft Alias: v-kaunu

Hello @eponerine This issue is being taken care of under the duplicate issue #2287. Thank you.

@BronsonMagnan is just too fast for me :P


Help with use of the docker image

Dear all, I was able to create the image of the docker, but when runing the container, i cannot see the nvidia card from the docker image. I cannot run the tensor flow since none of the nvida controlers are present in the docker.
Do you have a tutorial about how to use the docker with ubuntu 18.04?

Are you using nvidia-docker?

Setup instructions added in 79f3879


Release network-resources-injector v1.3

There are few fixes since the last release. It would be good to make a new release to use it in SR-IOV Network Operator

network-resources-injector v1.3 has been released !
Thanks all for your contributions !


Chore tests

php-cs-fixer does not support multiple input paths without config. So I added a separate script for code and tests.

Thanks!


rename /index.webmanifest to /site.webmanifest

Similar to #1277, this will rename index.webmanifest to site.webmanifest.
Also, this will introduce a theme specific config.toml to define internals like media types and output formats (which may still be overruled be the user's config.toml file).

What's the purpose of refactoring the manifest in a more complex way?

How is it more complex?
The purpose is to stick away from using generic file names like index for stuff that has nothing do do with index, start file, home page, or content.
Referring to PR again #1277, it will be much more logical to harmonize such file names.

Elon musk - Simplicity is key !


Change the default of the enable_names option to false in the create_model function

Description
We create the model with names for debugging purposes. However, this can increase the model creation by 30% (see https://github.com/TulipaEnergy/TulipaEnergyModel.jl/pull/936). So, it will be better to have this option as false by default, but we need to update the docs and provide an example to show users how to enable the names for debugging.
Actions:

[ ] Change the default value in the function
[ ] Create a how-to in the docs showing how to enable the names and the implications of the time creation

Stealing Jody's logic when discussing SpineOpt, I think it makes more sense to have enable_names = true as the default (but disable it in the tests) so that new users don't have to go digging to figure out what's happening. We can teach about disabling it for speed in our docs, and include it in the tutorials.
But open for discussion!


Line marked as conditional breakpoint cannot be remarked as regular breakpoint

From<EMAIL_ADDRESS>on 2012-04-07T11:58:41Z
What steps will reproduce the problem?

Mark any line of code as a conditional breakpoint
Remove the breakpoint from the same line
Try to remark the same line as a regular breakpoint What is the expected output? What do you see instead? The breakpoint gets remarked as a conditional breakpoint. I guess in theory this could be the designed behavior, but I can't imagine that would be the case. Please use labels and text to provide additional information. Once a line has been marked as a conditional breakpoint, the userData field breakpoint_condition never gets cleared. The attached patch fixes the problem. Here are details on the version and platform, although this bug will be platform independent.

Spyder 2.2.0dev, Revision 466e2f7679e9 Python 2.7.2 on Windows 7
Attachment: breakpoint_fix.patch
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=988

From pierre.raybaut on 2012-04-12T05:09:17Z
This issue was updated by revision 379ac1b5389f .
Status: Fixed

From<EMAIL_ADDRESS>on 2012-04-12T07:40:08Z
Status: Verified


RELEASE: Final steps for VIC.5.0.0 release

We don’t have any code changes to go into the final release of 5.0.0 but there is a bit to do still in terms of testing and documentation. Of course there may be a few code changes as a result of bugs we may uncover.
A list of all issues with the 5.0 milestone:
https://github.com/UW-Hydro/VIC/issues?q=is%3Aopen+is%3Aissue+milestone%3A5.0
Once this list is empty, we should be ready to release. I changed the target date for the release to September 1. Let's see if we can make that.
General discussion about release 5.0.0 can be captured under this issue.

Here's my checklist for tomorrow's release:

[x] Identification of features and fixes to be included in the release. This is coordinated through the VIC github page. Done: see 5.0 Milestone
[x] Features and fixes are added to the appropriate branch (develop or hotfix) via Github pull requests.  Done: see list of closed issues and changelog
[ ] The model is tested using the VIC test framework. Each of the following tests should be run and verified for any release.
- [ ] Unit tests
- [ ] System tests
- [ ] Example tests
- [ ] Science tests
- [ ] Release tests
[x] Once all tests have been run and the release is ready, a few minor changes need to be made to the source code prior to a release (see https://github.com/UW-Hydro/VIC/pull/624):

[x] Update the version string for classic and image drivers (vic_version.h)
[x] Update the version string for the python driver (setup.py)
[x] Update the documentation. At a minimum this means updating ReleaseNotes.md.

[ ] Make the release!

[ ] Merge the release branch into the master branch.
[ ] Create the tag. This is best done on the command line as git tag -f -a VIC.5.1.2 -m 'release tag of VIC 5.1.2, bug fix update for this example.
[ ] Publish the release on Github.
[ ] Update the VIC documentation and Readme files with the releases Zenodo DOI (e.g. DOI).
[ ] Update the develop branch with the changes from the master branch.
[ ] Reset the version strings in the develop branch.


Add conda installation option for flowtorch

Adding a conda installation option for flowtorch could be very helpful. I have added flowtorch to conda-forge channel. The :bulb: PR was just merged.
conda install -c conda-forge flowtorch

:zap: I will push a PR to update the readme-installation section.

https://github.com/conda-forge/staged-recipes/pull/17175

:rocket: A screenshot is all you need!

@sugatoray fantastic work! I really appreciate your doing this - it will be super useful to be able to install from Conda as well :)
Just a few questions about how it works: do you have to update the Conda recipe with a PR for each FlowTorch release, or it is connected to PyPI (i.e. when PyPI updates will Conda update too)?
Are you able to install it from Conda yet? I get a PackagesNotFoundError with conda install -c conda-forge flowtorch although maybe the changes take a while to propagate to the package metadata file?

@sugatoray fantastic work! I really appreciate your doing this - it will be super useful to be able to install from Conda as well :)

Glad I could help!

Just a few questions about how it works: do you have to update the Conda recipe with a PR for each FlowTorch release, or it is connected to PyPI (i.e. when PyPI updates will Conda update too)?

Typically, you need the maintainer(s) of conda-forge/flowtorch-feedstock to make a minor modification to a yaml file and push to the feedstock. Currently, I am the sole maintainer of this feedstock.

Are you able to install it from Conda yet? I get a PackagesNotFoundError with conda install -c conda-forge flowtorch although maybe the changes take a while to propagate to the package metadata file?

Yes, it typically takes some time to propagate. But I just installed it. So, it should work now.

Fantastic, I'll add you to https://flowtorch.ai/dev/about#contributors when I update the website next! :) The conda install is working for me now as well


Update Wasm modules to be compatible with Spin v0.4

@technosophos — the license in this repo is Creative Commons, and the gitignore file suggests we want to avoid publishing the Wasm binaries because of the license:
https://github.com/fermyon/bartholomew-site-template/blob/00bdd8090c598785ca059e38d3c4f81094bebd57/.gitignore#L1
Should I remove them altogether for now?
I know we are considering referencing them by URL from a public endpoint, and that would solve the issue, wondering what approach we should have for now.
Signed-off-by: Radu Matei<EMAIL_ADDRESS>

I think if we copy in licenses for those modules (e.g. modules/LICENSE.bartholomew) it should make it clear that they are licensed separately.


feature/icon - added icon-navbar

Description
Added icon in the navbar.
Fixed #190
Type of change
Please check options that are relevant to your PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[ ] I have pulled the latest changes in the repository
[ ] I have squashed my commits
[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

@Manvityagi please review this

The icon in navbar is looking a little off to me
Cc: @DeepanshiD

The icon in navbar is looking a little off to me
Cc: @DeepanshiD

yeah, it doesn't look good to me as well.

hey @Spring-dot, although you contributed meaningful stuff, the maintainers didn't find it suitable for the time being. So, I am going to close it for now.


Add unit tests

Currently we have 56 tests and 9 of them are being ignored. We need to implement those tests and maybe try to add some more tests

I can take this issue, @abdelski I think I may need your help with that one

Sounds good to me, assigned to both of us.


transformer.py 中的forword方法调用的SublayerConnection类。实现残差链接和标准化的实现

sublayerout =  layerNorm(x +sublayer(x))
首先是残差链接然后是层标准化
在你代码中：sublayer.py中 应该是
def forward(self, x, sublayer):
"Apply residual connection to any sublayer with the same size."
# return x + self.dropout(sublayer(self.norm(x)))
return self.norm( x + self.dropout(sublayer(x)))
tranformer.py中：
def forward(self, x, mask):
x = self.input_sublayer(x, lambda _x: self.attention.forward(_x, _x, _x, mask=mask))
x = self.output_sublayer(x, lambda _x: self.feed_forward.forward(_x))
return self.dropout(x)
此处我对论文立即额和你不一样，有错误的地方请指教

The transformer implementation is the same as The Annotated Transformer.
In sublayer.py, there is a comment Note for code simplicity the norm is first as opposed to last.


stoploss, entry and targets have to many decimal places

Your PR welcome

fix https://github.com/dalirnet/tvsignal/pull/2


Fix iOS minimum deployment annotation and fix compilation error on iOS from plugin changes

Fix iOS minimum deployment annotation and fix compilation error on iOS from plugin changes.
Motivation:
Fixes a build break on iOS.
Modifications:

set the iOS deployment target to 13.4 to match the macOS 10.15.4 set earlier — this provides access to Swift-friendly Foundation.FileHandle APIs
conditionalize use of Process APIs that aren't available on iOS, watchOS, tvOS

Result:
Be able to build on iOS again.

@swift-ci please smoke test


Test linting via bad commit

Summary by CodeRabbit

Bug Fixes

Improved error handling for directory reading in the disk cleaner functionality.
Enhanced error messages for certificate loading failures.

New Features

Updated function to accept a string parameter, improving flexibility for future enhancements.

Linting check seems to work as expected, closing.


fix circleci errors via update to rubocop dependencies

Sets reek and rubocop to latest versions.
"required_ruby_version" and "TargetRubyVersion" have been set based on
info here:
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Gemspec/RequiredRubyVersion
Resolves #83

@jumanjiman Please take a look at this fix for errors currently occurring in other PRs. We here at the Linux Foundation would love to see the shellcheck hook get the fix it needs for pre-commit 2.10.0 (currently both #80 and #81 are open for the same fix, though 81 looks a bit more complete), and since I figure you may not want to merge anything that has failing CircleCI checks, I've gone ahead and made the necessary updates to get the rubocop tests back to a passing configuration.

@MightyNerdEric TYVM!

@jumanjiman Can we get a new release/tag out please, we are still using the additional_dependencies workaround with 2.1.4. TIA

@jumanjiman Can we get a new release/tag out please, we are still using the additional_dependencies workaround with 2.1.4. TIA

oops, done!
ty for the reminder!
2.1.5 is up


Fix calculation of downstream caret location at the end of a string

@Hixie

wow, that affected remarkably few tests, that's alarming!


VS crash after clicking on Excel button in Variable Explorer

pkgs.matrix <- installed.packages(fields = c('Title', 'Author', 'Description'))
pkgs.list <- apply(pkgs.matrix, 1, function(x) as.list(x))

Click on Excel button for pkgs.list

Works for me, no crashes. Can you get a call stack?

I just installed the latest build and it works for me now.


streaming proposal redirections

ideally follower should help the leader to parse the request, encode the requests and then stream the requests to the leader.

part of #1988

@yichengq This is kind of solved, right?

yes. further optimization may include batching them until 1ms passes.


C + + client supports class programming

At present, the client and producer of C + + client do not support defining variables as class members, so they cannot be defined in the following form:
ca.h
class ca
{
public:
Client client;
Producer producer;
}
ca.cpp
ca::init(string topic )
{
client = client(address);
result= client.createProducer(string("persistent://public/default/ ")+topic,
producerConf, producer);
}
ca::push_ data(string data)
{
Message msg = MessageBuilder().setContent(data).build();
producer.sendAsync(msg, std::bind(callback,std::placeholders::_1, std::placeholders::_2, data));
}

the client and producer of C + + client do not support defining variables as class members

Why not? Please paste the compilation error. I guess it's because Client doesn't have a default constructor. Since when a Client is constructed, it doesn't start any network connection. So you can pass an empty string.
Here is an example.
#include <atomic>
#include <chrono>
#include <iostream>
#include <stdexcept>
#include <thread>

#include <pulsar/Client.h>

using namespace pulsar;

class Demo {
   public:
    void init(const std::string& service_url, const std::string& topic) {
        client_ = Client(service_url);
        const auto result = client_.createProducer(topic, producer_);
        if (result != ResultOk) {
            throw std::runtime_error("Failed to create producer: " + std::string(strResult(result)));
        }
    }

    void send(const std::string& data) {
        const auto msg = MessageBuilder().setContent(data).build();
        pending_messages_++;
        producer_.sendAsync(msg, [this, data](Result result, const MessageId& id) {
            pending_messages_--;
            if (result == ResultOk) {
                std::cout << "Send " << data << " to " << id << std::endl;
            } else {
                std::cerr << "Failed to send " << data << ": " << result << std::endl;
            }
        });
    }

    void wait() {
        while (pending_messages_ > 0) {
            std::this_thread::sleep_for(std::chrono::milliseconds(1));
        }
    }

   private:
    Client client_{""};
    Producer producer_;
    std::atomic_int pending_messages_{0};
};

int main(int argc, char* argv[]) {
    Demo demo;
    demo.init("pulsar://localhost:6650", "my-topic");
    for (int i = 0; i < 10; i++) {
        demo.send("msg-" + std::to_string(i));
    }
    demo.wait();
    return 0;
}

And the output is:
2021-11-02 10:39:12.018 INFO  [0x10aceee00] ClientConnection:181 | [<none> -> pulsar://localhost:6650] Create ClientConnection, timeout=10000
2021-11-02 10:39:12.018 INFO  [0x10aceee00] ConnectionPool:96 | Created connection for pulsar://localhost:6650
2021-11-02 10:39:12.020 WARN  [0x70000bbc2000] ClientConnection:428 | [<none> -> pulsar://localhost:6650] Failed to establish connection: Connection refused
2021-11-02 10:39:12.020 INFO  [0x70000bbc2000] ClientConnection:367 | [<IP_ADDRESS>:64484 -> <IP_ADDRESS>:6650] Connected to broker
2021-11-02 10:39:12.023 INFO  [0x70000bbc2000] HandlerBase:64 | [persistent://public/default/my-topic, ] Getting connection from pool
2021-11-02 10:39:12.032 INFO  [0x70000bbc2000] ProducerImpl:188 | [persistent://public/default/my-topic, ] Created producer on broker [<IP_ADDRESS>:64484 -> <IP_ADDRESS>:6650]
Send msg-0 to (11,0,-1,0)
Send msg-1 to (11,0,-1,1)
Send msg-2 to (11,0,-1,2)
Send msg-3 to (11,0,-1,3)
Send msg-4 to (11,0,-1,4)
Send msg-5 to (11,0,-1,5)
Send msg-6 to (11,0,-1,6)
Send msg-7 to (11,0,-1,7)
Send msg-8 to (11,0,-1,8)
Send msg-9 to (11,0,-1,9)
2021-11-02 10:39:12.047 INFO  [0x10aceee00] ClientConnection:1542 | [<IP_ADDRESS>:64484 -> <IP_ADDRESS>:6650] Connection closed
2021-11-02 10:39:12.047 INFO  [0x70000bbc2000] ProducerImpl:588 | Producer - [persistent://public/default/my-topic, standalone-0-1] , [batchMessageContainer = { BatchMessageContainer [size = 0] [bytes = 0] [maxSize = 1000] [maxBytes = 131072] [topicName = persistent://public/default/my-topic] [numberOfBatchesSent_ = 1] [averageBatchSize_ = 10] }]
2021-11-02 10:39:12.047 INFO  [0x70000bbc2000] ClientConnection:255 | [<IP_ADDRESS>:64484 -> <IP_ADDRESS>:6650] Destroyed connection

thank u！


Rename DecodeZeroX and EncodeZeroX to include hex

Is your feature request related to a problem? Please describe.
Its not clear what encoding method DecodeZeroX and EncodeZeroX use
Describe the solution you'd like

[ ] rename EncodeZeroX to EncodeHexZeroX
[ ] update docs for EncodeHexZeroX
[ ] rename DecodeZeroX to DecodeHexZeroX
[ ] update docs for DecodeHexZeroX
[ ] update all function usage references
[ ] rename tests

https://github.com/mailchain/mailchain/pull/430 done


Basic example for execution test on host machine

Execution tests can be tricky to run on build bots, but it might be useful to have them in order to check that obfuscations produce valid executables. As a first step, this patch shows how to implement a primitive execution test that runs on the host machine. In the future we probably want to run execution in emulated environments like QEMU. There are a few open TODOs as well, but it should be good enough to see if the basics work and get a better understanding of potential issues.

FYI in order to avoid churn in the upstream repo, I checked that the execution test passes in the GitHub action before merging this: https://github.com/build38/o-mvll/actions/runs/5153519285 And it does:
PASS: O-MVLL Tests :: passes/flattening/basic-native.c (4 of 6)


Event for when element is inserted into the DOM

I find myself doing this pattern quite often so knowing when an element has been inserted into the DOM would be useful:
var div = bel`<div>testing</div>`
// ... later ...
div.update(bel`<div>changed</div>`, function (element) {
  // element is div and in the dom
})

This is a better pattern:
var div = bel`
menu
`

and use the onBeforeMorphEl hook in morphdom.

The morphdom hooks work when .update() is called but we don't have a solution for when document.body.appendChild(element) is called on an element.
There are some CSS animation hacks for onload but that won't work for onunload.
Another option is a MutationObserver but I think that should become it's own library so one could do:
var onload = require('some-lib/onload')
var onunload = require('some-lib/onunload')

var menu = bel`<div>testing</div>`

onload(menu, function () {
  document.addEventListener('mousedown', hideMenu)
})
onunload(menu, function () {
  document.removeEventListener('mousedown', hideMenu)
})

Created a library for it here: https://github.com/shama/on-load


Portfolio Setup and Mobile first - pull request

This is the simple first two sections of the portfolio website. No extra functionality or dropdowns are created.

Hi @PrangonGhose ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that  does not passes the linters checks, in particular your stylelint is failing , pplease fix this and make sure all linter checks are passing before submitting a PR for code review :pray:
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.