List of minor findings

[X] bug report
[ ] feature request

Findings
Enforce ownership renouncement
Contract(s) affected: OutputGuardHandlerRegistry.sol, SpendingConditionRegistry.sol
Severity: Low
Description: Both OutputGuardHandlerRegistry and SpendingConditionRegistry are expected to have their ownership renounced before injecting the registries to the ExitGame contracts. Although stated in the documentation, this requirement is not enforced programmatically. Hence, there is nothing requiring the owner to actually renounce the ownership. As such, the owner could register new output guard handlers and spending conditions to perform malicious operations on the Plasma chain.
Recommendation: We recommend enforcing the ownership renouncement programmatically. For example, the vaults may reject any deposits as long as OutputGuardHandlerRegistry and SpendingConditionRegistry have owners.
Maintainer may register a malicious game
Contract(s) affected: ExitGameRegistry.sol
Severity: Undetermined
Description: Maintainer has the privilege of adding new exit games. Each new exit game is quarantined for three exit periods -- that's the period in which the community of Plasma chain users may audit the newly added exit game. In case they realize that the game is malicious, they may decide to exit the chain. Given that it may take two exit periods to perform an exit, is it realistic that the community discovers a problematic exit game within a single exit period?
Recommendation: Currently we have no recommendation.
Adherence to Specification
The functions EthDepositVerifier.verify(), Erc20DepositVerifier.verify(), and PaymentOutputModel.decode() don't check decodedTx.outputs[0].outputType. Should they?
Adherence to Best Practices
Although the code uses the experimental feature ABIEncoderV2, overall, it conforms to best practices and it makes good use of modularization. We provide further ideas for improvements below:

in FailFastReentrancyGuard.sol there is no need to import PlasmaFramework.sol. We recommend importing ExitGameController.sol instead.
in Erc20DepositVerifier.sol#46 there is a strict equality requiring user to approve an exact amount of tokens. Such a design prohibits the user from making a single approval for multiple deposits. To facilitate flexibility and to reduce gas usage, we recommend using >= instead of equality. Furthermore, the comment in line Erc20Vault.sol#32 would hint on the recommended approach.
in PaymentInFlightExitModelUtils.isFirstPiggybackOfTheToken() there is an unused variable isPiggybackInput which is write-only. We recommend removing it.
in WireTransaction.sol following the line 32, we recommend checking the length of output, e.g.,  require(4 == output.length, "Invalid output encoding").
in VaultRegistry.sol the function registerVault() takes uint256 _vaultId as an argument. We recommend simplifying the code by introducing a unique internal counter that could then be used to generate _vaultId and return it from the function.
utxoPos has inconsistent definitions; for example, it is defined as uint192 in PaymentExitDataModel.StandardExit and PaymentStandardExitRouterArgs.StartStandardExitArgs, whereas it is defined as uint256 in ExitChallenged.PaymentStandardExitRouter and UtxoPosLib.UtxoPos.
similarly, exitId is defined as uint160 in ExitId.getStandardExitId(), whereas is it defined as uint192 in PaymentExitDataModel.StandardExitMap.
unlocked pragma in RLPReader.sol. Since it's a clone-and-owned library, we recommend locking pragma as in other contracts.
unlocked pragma in TxFinalizationModel.sol We recommend locking the pragma.
since the max number of outputs and inputs associated with a UTXO is 4, the data type for indices could be uint8 instead of uint16 (e.g., the return value of UtxoPosLib.outputIndex(), or input of PaymentOutputToPaymentTxCondition.verify()).
it is unclear why the function PaymentExitGame.processExit() takes a second unnamed argument (presumably vault Id). If it is not used, we recommend removing it.
it is unclear why OutputId.computeDepositOutputId()takes _outputIndex as an argument. If deposit's output UTXO is always zero, we recommend removing it.
in PaymentInFlightExitModelUtils.sol, it is unclear why there are both clearOutputPiggyback() and clearOutputPiggybacked(). The former appears wrong since it does not shift the index. However, is not used anywhere in the code base; we recommend removing it.
typos: in EthVault.sol: "unucessful"  -> "unsuccessful", and ExitId.sol: "depost" -> "deposit".
constants MAX_INPUT_NUM and MAX_OUTPUT_NUM are re-defined in multiple different places (e.g., PaymentInFlightExitModelUtils.sol, PaymentExitDataModel.sol, PaymentPiggybackInFlightExit.sol, PaymentTransactionModel.sol, PaymentEip712Lib.sol). We recommend extracting them to some shared  contract/library.
the field EthVault.withdrawEntryCounter is not used anywhere in the code. We recommend removing it.
in PaymentOutputModel.sol#28 and PaymentOutputGuardHandler.sol#15, the statement AddressPayable.convert() appears to be redundant.
in PaymentStandardExitRouter.solthe events Exit* on lines 49-64 are redefined by the corresponding controller libraries, and these local definitions do not appear to be used.  Similar comment applies to PaymentStandardExitRouter.sol and events from lines 58-106. We recommend removing the redundant events.
in PaymentStandardExitRouterArgs.sol#8, there is the comment outputGuardPreimage (Optional) Output guard preimage data, however, PaymentOutputGuardHandler.isValid() seems to suggest that this field must have length 0. The field does not appear to be "optional", but rather "disallowed".

in PaymentStandardExitRouter.solthe events Exit* on lines 49-64 are redefined by the corresponding controller libraries, and these local definitions do not appear to be used. Similar comment applies to PaymentStandardExitRouter.sol and events from lines 58-106. We recommend removing the redundant events.

We did this for this reason: https://ethereum.stackexchange.com/questions/11137/watching-events-defined-in-libraries
I think the last time I check I was not able to filter with pastEvents using web3. Though it is possible for clients not relying on abi to get the event out. Not sure is there better solution then duplicate the event declaration though? @kbak do you have any input on this one?

I see. We didn't know about this limitation, so don't really have a better proposal. Please disregard it and thanks for the explanation.


HOP-2404: Wrap Canvas in ScrolledComposite at HopGuiPipelineGraph/HopGuiWorkflowGraph

This PR wraps Canvas in ScrolledComposite at HopGuiPipelineGraph/HopGuiWorkflowGraph like #531 .
Following this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [HOP-XXX] - Fixes bug in SessionManager,
where you replace HOP-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.
If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[ ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[ ] In any other case, please file an Apache Individual Contributor License Agreement.

@mattcasters Thanks for your check.
Yeah, it is still work-in-progress. For WIP PRs like this, I keep them as "Draft".
Please let me know if it is better to put "WIP" at the beginning of the PR title or something like that.

@mattcasters Thanks for your check.
Yeah, it is still work-in-progress. For WIP PRs like this, I keep them as "Draft".
Please let me know if it is better to put "WIP" at the beginning of the PR title or something like that.

I see it now.  LOL, I didn't even know it was possible to mark a PR as WIP :-)
But yeah I was doing some reviews across a number of PR so it was no bother.
Let me know if you want me to look into this one.

I see it now.  LOL, I didn't even know it was possible to mark a PR as WIP :-)
But yeah I was doing some reviews across a number of PR so it was no bother.
Let me know if you want me to look into this one.


Include decorators in Class and FunctionDef range

This PR changes the ClassDef and FunctionDef definitions to include the range of their decorators.
Example
@test
def f():
	pass

Before: The functions' range was from line 2, column 0 to line 3, column 9
New: The functions' range spans from line 1, column 0 to line 3, column 9 (includes the @test decorator)

Motivation
This change is because these are the only nodes for where the property parent.range.includes(child.range) does not hold. The fact that this property is not respected means it is e.g. impossible to use a binary search over the AST to find a node by its range.
Downsides
The main downside that I'm aware of is that diagnostics using range.start to compute the line index for functions and classes may now incorrectly point to the line of the function's decorator instead of the function definition. I don't know if this is a problem for RustPython. Ruff already uses custom infrastructure to extract the range of the function name only to limit the diagnostic range (and e.g. avoid highlighting the whole function or class including the body)
Ruff
https://github.com/charliermarsh/ruff/pull/4467

Oh.. this is a Python spec omg.
Python 3.11.2 (main, Feb 16 2023, 02:55:59) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> ast.parse("""
... @decorator
... def x(): pass
... """)
<ast.Module object at 0x100738be0>
>>> a = _
>>> f = a.body[0]
>>> f.lineno
3
>>> f.decorator_list[0].lineno
2

We will really need a feature flag for ruff.

I'd better to understand it better if this is also related to symbol table or SyntaxError.
If not, it can be handled in ast module.

@MichaReiser Do you want to make it work different only for more-attributes feature right now? That has no blocker.

@MichaReiser Do you want to make it has different value only for more-attributes feature right now? That has no blocker.

In my view, this stretches feature flags to the limit, or even over the limit. We would need to rename it at least. I also plan to make other range changes:
def a():
	pass

	# comment

The range of the function should include the #comment, which it does not today.
I think maintaining this change in a fork is straightforward enough and probably easier than dealing with even more conditional code that has very limited test coverage.

Reusing ast crate but making a fork of parser crate makes sense to me.

We can make a new crate like rustpython-parser-util to share fundamental parser utilities except for the details.

We can make a new crate like rustpython-parser-util to share fundamental parser utilities except for the details.

I don't think that this is necessary. I still plan to pull in upstream changes. I don't expect to many conflicts since the grammar shouldn't change frequently


Create 0000-01-02-i-ssu.md

SECOND PULL REQUEST
This is just to notify myself that I feel amazingly happy rn that I was able to commit a second pull request ALL BY MYSELF!!! Heheh I'm on cloud 9999999. Thus the second pull request from the My first Branch to my slide show
##Requested from
###From: My-First-Branch
###To: my-slide

WOHOOOOO!!!
Just encourage this dump
@i-ssu lols<3
_HAHAHAA!_

https://user-images.githubusercontent.com/68648156/144718970-8592c1bf-2a46-4a8e-84e6-7f1114bbb45f.mp4

### WELL DONE Sese!

It is indeed beautiful.


Gif in readme example

Hello! I was trying out the example from the readme and the output was always a white gif.
I think it might be due to Operation.linear!/4 taking floats in the [0.0, 1.0] range instead of [0, 255] because I changed
 # create images with different grayscale
 frames = Enum.map(1..255//10, fn n ->
   Operation.linear!(black, [1], [n,n,n])
 end)

to
 # create images with different grayscale
 frames = Enum.map(1..255//10, fn n ->
   Operation.linear!(black, [1], [n/255,n/255,n/255])
 end)

and showed the expected animation.

Hi @mFragaBA, thank you for pointing out. corrected


Trnsnt/dict

Coverage increased (+0.006%) to 94.528% when pulling e9f3c2c7a7e1db80c13310460211f6c72583f163 on trnsnt:trnsnt/dict into c1fd7d486213477c7171b75903b733d8adc27d33 on Tygs:master.

Coverage increased (+0.006%) to 94.528% when pulling e9f3c2c7a7e1db80c13310460211f6c72583f163 on trnsnt:trnsnt/dict into c1fd7d486213477c7171b75903b733d8adc27d33 on Tygs:master.

Coverage decreased (-0.002%) to 94.521% when pulling cb4f8d11ee5690280b054a39824954972dcec2d9 on trnsnt:trnsnt/dict into c1fd7d486213477c7171b75903b733d8adc27d33 on Tygs:master.


Feature request: enable YouTube channel-specific (or even video-specific) comments section blocking

Continuing with on with the goal of the this project:

Fed up with the vitriol left in comments, many sites are dumping their comment systems completely. It's just too costly to monitor them, so they tend to devolve into a cess pool. Personally, I just want the content most of the time. YouTube anyone?
To help with my own sanity (and maybe yours?), I wrote an extension that hides many comment systems - identifying them is somewhat predictable. It's available for Chrome and Firefox, or you can read more about it here too.

I suggest adding channel-specific blocking of comments, to not block out all channels' comments section, sometimes a person might want to see coments of a specific channel - or participate in them. In my case, for example, I'm subscribed to various technology reviewing channels. One of which promotes positivity and is also a small community. Unlike most of the ones whose contents I like to consume, but dislike their comments section, in this one I sometimes like to read the comments. Another reason to have the ability to make it channel-specific: write coments in channels you want to be able to comment on videos of.
I think it would be even better to have the ability to toggle for a specific video. That would be useful for various situations, for example a disucssion of contents of a video you're interested in discussioning (and don't care about commenting on other videos - even if they're from the same channel), and in competitions and challenges presented in videos answered are asked for (e.g educational videos). I personally am subscribed to channels who've made various videos of both of the scenarios I mentioned.

That's a great idea, but it goes beyond what I want to do with this extension. It'd involve a lot of customization for just a single site, and I'm not even sure how someone would tackle it, since the URLs for videos have nothing connecting them to a specific channel. I think someone would need to write a separate addon that uses the YouTube API.

Closing this out. I do think it's a nice idea, but it's just not feasible for this addon.


Polish commit distribution build

Add a build scan tag to that build.
Clearly log no matter commit distribution build fails or succeeds.

@bot-gradle test and merge

OK, I've already triggered a build for you.


[WizardInline]: No Padding in header

There is a padding issue with the header used for WzardInline Component

:tada: This issue has been resolved in version 2.15.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BEAM-59] Swap IOChannel to FileSystems finishing touches

All these are small.
After this, all I have left is BigQuery.
R: @vikkyrk

Coverage decreased (-0.3%) to 70.299% when pulling e5387b6de7e24a3f9a0ed1a3ae69cf1b6125a30f on dhalperi:iocf-die-die-die into ff6bb353002610169a8079d1164118606bebb21e on apache:master.

Coverage decreased (-0.3%) to 70.299% when pulling e5387b6de7e24a3f9a0ed1a3ae69cf1b6125a30f on dhalperi:iocf-die-die-die into ff6bb353002610169a8079d1164118606bebb21e on apache:master.

LGTM

Coverage increased (+0.004%) to 70.557% when pulling 2f312f80adf0eab3b889317a7f7fb77a20787b22 on dhalperi:iocf-die-die-die into ff6bb353002610169a8079d1164118606bebb21e on apache:master.

Coverage decreased (-0.002%) to 70.525% when pulling ac183c0ec46dc3b961379955c4fe404ab4230799 on dhalperi:iocf-die-die-die into 93020941a251bb62fc26f5e123a12df4f8e4ab1e on apache:master.


used splitargs to slipt commands args group by quatoes

fixes the following user case
<IP_ADDRESS>:6379> set a "aa aa"
(error) ERR syntax error

LGTM.
But I suppose you should also update package-lock.json?


feat: user profile dropdown

PR Fixes:

1 Added a profile dropdown
2 Made bookmark global

Resolves #307
P.S. Sorry for recording it in light mode
Added the theme toggle button after logging out, had removed it by mistake while recording this:
Screencast from 2024-04-02 17-52-15.webm
Screencast from 2024-04-02 17-50-01.webm
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I assure there is no similar/duplicate pull request regarding same issue

/bounty $75


Support for transitive dependency removal

With security alerts on transitive dependencies we sometimes see that an update to the parent actually ends up removing the vulnerable dependency from the tree. That's a valid way to resolve an alert but removing dependencies is not a feature Dependabot currently supports. This adds limited support for dependency removal (transitive dependencies removed as part of parent upgrade).
The approach is:

UpdateChecker will return removed transitive dependencies in the list of dependencies to update but they'll be flagged as removed
FileUpdater will ignore dependencies flagged as removed since there's nothing to be done
The PR description will indicate the dependency was removed
When validating that the update fixes the vulnerability we'll consider removal of the dependency as fixed
I've also removed the restriction on removing dependencies from the VulnerabilityAuditor but it's feature flagged

One complication is that we serialize the dependency information to other internal systems and perform validations in those places as well. Before this can be merged enabled I'll need to make corresponding updates to those systems to handle a removed dependency. We'll also need to maintain this feature flag for awhile to prevent errors if this code is used on an older version of GHES which wouldn't have the necessary support for removed dependencies.
I'd also considering using a blank target version as a signal of a removed dependency in https://github.com/dependabot/dependabot-core/pull/5487. However, after I discovered we also use this in other systems I felt a more explicit signal would be easier to understand.

dry-run and PR example
[dependabot-core-dev] ~/dependabot-core $ SECURITY_ADVISORIES='[{"dependency-name":"@dependabot-fixtures/npm-transitive-dependency","affected-versions":["<1.0.1"]}]' bin/dry-run.rb npm_and_yarn dependabot-fixtures/npm-locked-transitive-dependency-removed --security-updates-only --dep @dependabot-fixtures/npm-transitive-dependency --cache files --updater-options=npm_transitive_security_updates,npm_transitive_dependency_removal --pull-request
=> reading dependency files from cache manifest: ./dry-run/dependabot-fixtures/npm-locked-transitive-dependency-removed/cache-manifest-npm_and_yarn.json
=> parsing dependency files
=> updating 1 dependencies: @dependabot-fixtures/npm-transitive-dependency

=== @dependabot-fixtures/npm-transitive-dependency (1.0.0) (vulnerable 🚨)
 => checking for updates 1/1
 => latest available version is 1.0.1
 => earliest available non-vulnerable version is 1.0.1
 => latest allowed version is 1.0.0
 => requirements to unlock: all
 => requirements update strategy: bump_versions
 => updating @dependabot-fixtures/npm-remove-dependency from 10.0.0 to 10.0.1

    ± package.json
    ~~~
    13c13
    <     "@dependabot-fixtures/npm-remove-dependency": "10.0.0"
    ---
    >     "@dependabot-fixtures/npm-remove-dependency": "10.0.1"
    ~~~

    ± package-lock.json
    ~~~
    12c12
    <         "@dependabot-fixtures/npm-remove-dependency": "10.0.0"
    ---
    >         "@dependabot-fixtures/npm-remove-dependency": "10.0.1"
    16,26c16,18
    <       "version": "10.0.0",
    <       "resolved"<EMAIL_ADDRESS>    <       "integrity": "sha512-QMgb6isjtNCnql6Nn+/h2v759qIW4f1ZDER8IbUJaIuyppDq3BqABbiwTFNenynu39yQZ1YAUFbWuNGeECNLyw==",
    <       "dependencies": {
    <         "@dependabot-fixtures/npm-transitive-dependency": "1.0.0"
    <       }
    <     },
    <     "node_modules/@dependabot-fixtures/npm-transitive-dependency": {
    <       "version": "1.0.0",
    <       "resolved"<EMAIL_ADDRESS>    <       "integrity": "sha512-nFbzQH0TRgdzSA2/FH6MPnxZDpD+5Bgz00aD5Edgbc1wY/k8VC9s7lnk22dBTgJLwoY7MgbrnAf9rAvN08hHVg=="
    ---
    >       "version": "10.0.1",
    >       "resolved"<EMAIL_ADDRESS>    >       "integrity": "sha512-acz1nPaB5TR8A5FBmOyZcYE8YQVs5TwrSGtqCyT0hbKJPtDYBt8yxRdbgC36fPrP/4JZn++bvaohG7IQq6NrPA=="
    31,41c23,25
    <       "version": "10.0.0",
    <       "resolved"<EMAIL_ADDRESS>    <       "integrity": "sha512-QMgb6isjtNCnql6Nn+/h2v759qIW4f1ZDER8IbUJaIuyppDq3BqABbiwTFNenynu39yQZ1YAUFbWuNGeECNLyw==",
    <       "requires": {
    <         "@dependabot-fixtures/npm-transitive-dependency": "1.0.0"
    <       }
    <     },
    <     "@dependabot-fixtures/npm-transitive-dependency": {
    <       "version": "1.0.0",
    <       "resolved"<EMAIL_ADDRESS>    <       "integrity": "sha512-nFbzQH0TRgdzSA2/FH6MPnxZDpD+5Bgz00aD5Edgbc1wY/k8VC9s7lnk22dBTgJLwoY7MgbrnAf9rAvN08hHVg=="
    ---
    >       "version": "10.0.1",
    >       "resolved"<EMAIL_ADDRESS>    >       "integrity": "sha512-acz1nPaB5TR8A5FBmOyZcYE8YQVs5TwrSGtqCyT0hbKJPtDYBt8yxRdbgC36fPrP/4JZn++bvaohG7IQq6NrPA=="
    ~~~
Pull Request Title: Bump @dependabot-fixtures/npm-transitive-dependency and @dependabot-fixtures/npm-remove-dependency
--description--
Bumps [@dependabot-fixtures/npm-transitive-dependency](https://github.com/dependabot-fixtures/npm-transitive-dependency) and [@dependabot-fixtures/npm-remove-dependency](https://github.com/dependabot-fixtures/npm-remove-dependency). These dependencies needed to be updated together.
Removes `@dependabot-fixtures/npm-transitive-dependency`
Updates `@dependabot-fixtures/npm-remove-dependency` from 10.0.0 to 10.0.1

Commits

84218f3 Remove dependencies

See full diff in compare view

--/description--
--commit--
Bump @dependabot-fixtures/npm-transitive-dependency and @dependabot-fixtures/npm-remove-dependency

Bumps [@dependabot-fixtures/npm-transitive-dependency](https://github.com/dependabot-fixtures/npm-transitive-dependency) and [@dependabot-fixtures/npm-remove-dependency](https://github.com/dependabot-fixtures/npm-remove-dependency). These dependencies needed to be updated together.

Removes `@dependabot-fixtures/npm-transitive-dependency`

Updates `@dependabot-fixtures/npm-remove-dependency` from 10.0.0 to 10.0.1
- [Release notes](https://github.com/dependabot-fixtures/npm-remove-dependency/releases)
- [Commits](https://github.com/dependabot-fixtures/npm-remove-dependency/compare/v10.0.0...v10.0.1)
--/commit--

Before this can be ~merged~ enabled I'll need to make corresponding updates to those systems to handle a removed dependency.

On further review, it's going to be easier to merge this first so I can make use of the updated code elsewhere. This change won't cause any downstream issues as long as the feature flag is not enabled.


ConvertSDK connection fails due to CORS Header Policy for 'content-type'

The Problem
When the sdk object is constructed, it experiences a CORS error. I am not sure if I am missing some SDK configuration setting, or some setting needs to be established in the Convert Project Portal.
Additionally, in an effort to find a working example of this code for react, I cloned this repo and attempted to run the project in packages/demo-react, however the app will not build due to a webpack error:
Failed to compile.
Module not found: Error: Can't resolve '@convertcom/js-sdk' in 'C:\Users\chericks\source\repos\javascript-sdk\packages\demo-react\src'
ERROR in ./src/App.js 14:0-44
Module not found: Error: Can't resolve '@convertcom/js-sdk' in 'C:\Users\chericks\source\repos\javascript-sdk\packages\demo-react\src'
Environment Information
I am adding the Convert SDK to an existing React application.
Browser: Edge & Chrome
SDK Version: 4.0.1 (also tried 3.0.0 and 2.4.1)
hosts file domain mapping: <IP_ADDRESS> obx-local.sonobelloapps.com
Convert Project Domains: 'http://obx-local.sonobelloapps.com:3000', 'http://obx-local.sonobelloapps.com'
Problem Details
Console Log Error:
Access to fetch at 'https://cdn-4.convertexperiments.com/api/v1/config/10042568-10049187' from origin 'http://obx-local.sonobelloapps.com:3000' has been blocked by CORS policy: Request header field content-type is not allowed by Access-Control-Allow-Headers in preflight response.
Screenshots:

My React Code:
const convertSDK: ConvertInterface = new ConvertSDK({
  sdkKey: EnvironmentConfiguration.convertDotCom.sdkKey
});

const useConvertDotComExperience = () => {
  const [userContext, setUserContext] = useState<ContextInterface | null>(null);
  const [experience, setExperience] = useState<BucketedVariation | null>(null);

  useEffect(() => {
    async function initializeConvertSdk() {
      await convertSDK.onReady();
      const userContext: ContextInterface = convertSDK.createContext(generateGUID(), { country: "US", language: "en" });
      const variation: BucketedVariation = userContext.runExperience(
        EnvironmentConfiguration.convertDotCom.experienceId
      );
      setUserContext(userContext);
      setExperience(variation);
      console.log(userContext, variation);
    }
    initializeConvertSdk();
  }, []);

  return { userContext, experience };
};

I was able to solve this with some assistance from the convert helpdesk team.
The api key I was using was the incorrect format ${accountId}-${projectId}.
The correct key format is ${accountId}/${projectId}. This is important because the api key is actually used as a part of the authentication endpoint path, and without the / you hit a different endpoint than is intended and receive an erroneous response.
I was unable to find the documentation for what the API key should be anywhere, and the helpdesk similarly could not point me to any location where it is documented. I originally arrived at my incorrect format by attempting to copy the code from one of the demos.
To the development team, I strongly recommend you add the information to the documentation about how the key is formed to avoid this problem in the future. Additionally, I'd recommend that you reconsider the design choice of allowing the key value to directly control the API path for numerous reasons. Accepting 2 discrete values for the project id and account id, and then combining them within the SDK is the much more straightforward and secure way to do this.

@sb-chericks good that you have this issue resolved with the help of our support team. You stand correct, we should add information about the API key format. The good news is that you won't have to very soon, as we're working on migrating the format of our API keys, so that you do not have to worry about following a specific format anymore.


chore(storage-monitor): improve free_space calculation and cli default value

I changed all MB to MiB.

Please update docs/comments: MB -> MiB

Where? I do not know the docs.

bot merge


Computed property is misleading

Hi, the project is amazing! Love it!
A note on the computed (https://component-party.dev/#computed-state) example.
The correct equivalent is using useMemo because in svelte the computed value only depends on the variables that are read in the statement, while in react it's recomputed on each rendern, no matter what. So I think the example should use useMemo, maybe add a second variable to show this, or a note.

You are totally right !
It's exactly what I did in the first place using useMemo.
But since it takes less character for the same result, some React devs wanted to remove useMemo haha
I was thinking creating Computed state with memoization.
Well I think we can't replicate the exact same behavior for each framework.
Component Party is not meant to be perfect because it's near impossible.

Nice that we are on the same page ❤
Adding Computed state with memoization directly after the computed state sounds like the way to go.
That way the react one-liner fanboys are happy, but we also get the "truth" out there 😉
I can do a PR next week if you like to :)


Xenos don't have their deathgasp

Description
Accidentally posted this to upstream repo, whoops.

Can you be more specific? Some of the xenos appear to have death sounds so I'm not sure what you're referring to

Based on playtest recordings, xenos have the default deathgasp of "(XX-121) seizes up and falls limp, its eyes dead and lifeless..." instead of cm13's "(XX-121) lets out a waning gluttural screech, green blood bubbling from its maw..."

Thanks


Fix exclusive cast of HashSet to IReadOnlyCollection to

allow tests to succeed in machines with only 4.5.1.

This might resolve one class of issues that prevents AppVeyor from building.

:shipit:
Too bad ReadOnlyCollection<T> only works with IList<T>


Tagged release without e2e tests/siwa update

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (tagged-release-without-e2e-tests/siwa-update@28c2069). Click here to learn what that means.
The diff coverage is n/a.

@@                               Coverage Diff                               @@
##             tagged-release-without-e2e-tests/siwa-update    #7968   +/-   ##
===============================================================================
  Coverage                                                ?   53.69%
===============================================================================
  Files                                                   ?      563
  Lines                                                   ?    28558
  Branches                                                ?     5541
===============================================================================
  Hits                                                    ?    15334
  Misses                                                  ?    12226
  Partials                                                ?      998

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c2069...0fd2238. Read the comment docs.


Add Apple mobile meta tags for standalone mode

Close https://github.com/jkk/shinkgs/issues/89

Thanks!


Cannot add components to container element?

I am attempting to add a custom button component inside the containerElement. However it is not rendered when I add it as a child.
containerElement={
  <div style={{ height: `100%`, position: 'relative' }}>

{refreshButtonComponent}

}

I can add the component in the inspector and it seems to work fine:

Am I doing this correctly or is there another way of adding these components?

Try:
`const ContainerElement = ({ children }) => (

      {children}

);
<MyMapComponent
containerElement={}
/>
`


Spellcasting Refactor

Refactors the entire spellcasting system per #182

Currently working on re-writing the entire spellbook organization system, this will replace both calls in the organizeSpellbook method:
organizeSpellbooks(spells) {
    this.data.spellbook = this.sheet._prepareSpellbook(this.data, spells);
    this.data.innateSpellbook = new InnateSpellbookPrep(this.data.spellbook, this.sheet).prepare();
}

The InnateSpellbookPrep class will be dropped, and reliance on the system-level _prepareSepllbook method will be dropped.
Currently, if you open a sheet the new spellbook data structures will be logged to the console, but the displayed info on the sheet is still unchanged.

I've started working on the new templates to handle the new spellcasting format, so far I just have really basic stuff in place so that something prints out using the new spellbook organization.

Alright, I've got it to the point where spellcasting features show up again, and they have descriptions and spell lists that work. Pretty close to parity with old features.
I don't think resources are working correctly yet, and I still need to implement some of the new complicated sorting logic. But the basics are now working.


Implement persistent data storage for ciao-image

Implement the ciao-image datastore interface to store data persistently.

May not complete this Sprint

@kaccardi, @obedmr  Is this a duplicate of #632?

@kaccardi @markdryan I'd say yes, it's duplicated.

Implemented on #632


Keep track of path when parsing route URL

When parsing the route URL here the path is not kept while it could be useful for some adapters.
For instance, we've developed https://github.com/kalisio/logspout-slack and we need to provide the path part of the webhook (
of the form https://hooks.slack.com/services/xxx) as a configuration option.

i'd definitely accept a PR addressing this

alternatively, could you use Route.Options to pass the path around?

If it seems useful to the community I can try. However, I'm really new to Go and it could take time before I write decent code ;-)

@michaelshobbs Do you mean add the path as a query parameter and get it back as an option in the route?

Apologies it's been awhile since I've been in this codebase. I assumed you already had a way to get the path into the system and we were just dropping it. Is that true?

I am not sure to get you but what I would like to be able to do is for instance:
docker run --name="logspout" \
	--volume=/var/run/docker.sock:/var/run/docker.sock \
	...
	logspout:v3.2.11 \
	slack://hooks.slack.com/services/xxx

But in my adapter when I'd like to get back the route info I can't get the path back:
func NewSlackAdapter(route *router.Route) (router.LogAdapter, error) {
	// Here route.Address is "hooks.slack.com", the path part "/services/xxx" has been lost
        ...
}

Maybe I am wrong but it appears to me neither the type to the parsing take care of it.
Maybe as you suggest there is another way to get the path back as well.

Maybe I am wrong but it appears to me neither the type to the parsing take care of it.

that is correct. however it does exist in the variable u (type URL) defined on L91
https://github.com/gliderlabs/logspout/blob/4e88b84bf163775801b935e0afc9396c6c0dbed4/router/routes.go#L91
golang net/url docs: https://golang.org/pkg/net/url/#URL
So we could store u.Path in Route.Options OR we could add another field to the type. I'm fine with either.

I think that adding a new field is more in line with the existing base.


New LogsSpy module

extracted from spring-boot-core module, with improved features:

The JUnit5 extension now has its own class (LogsSpyExtension) and thus LogsSpy only exposes assertions methods.
LogsSpy can now be injected by annotating a field with @Logs

Adding a bounty, as it's a lot of work, with the other PR

Bounty claimed: https://opencollective.com/generator-jhipster/expenses/162851


[Documentation]: Recommend a separation for openai related installations to avoid unintentional use of openai related packages

Documentation Issue Description
when somebody uses pip install llama-index-core it will automatically installs openai related dpendencies automatically.for example i have created a new environment named index_env and tried pip install llama-index-core,not only installed llama-index-core==0.10.60 but also openai==1.38.0 ;So when a user uses open source llms by keeping openai key in his .env had no direct idea about this because there is another installation recommended in your github page " pip install llama-index-llms-openai " to install openai related dependencies seperately!!. if i use pip install llama-index-core and separately deletes openai,after that when i installs pip install llama-index-llms-openai then also i get both the openai==1.38.0 and llama-index-llms-openai==0.1.27 ;so i request you to separate openai installation from pip install llama-index-core otherwise user can directly istall openai separately.Remember this is just a suggestion to overcome to avoid unintentional use or installation of openai that sometimes user may not aware it exists or not while trying with open source llms while keeping OPENAI_API_KEY in there .env files.But identified that if we pass path to such .env files some of the llamindex tool such as SubQuestionQuery Engine will utilizes openai without user permission,eventhoug opensource llms details specified in variables and in Setting.llm=llm as opensource.Its a serious matter of concern an dpossiblity for conflicts that may lead to affect confidentiality if somebody use openai that lead to confidential data leakage
Another thing i have noticed that if just try pip install llama-index it will install several openai related dependencies including llama-index-embeddings-openai==0.1.11,llama-index-llms-openai==0.1.27,llama-index-multi-modal-llms-openai==0.1.8,llama-index-program-openai==0.1.7,llama-index-question-gen-openai==0.1.3,openai==1.38.0
i recommend openai related dependncies must be separated and must have a separate installation otherwise if user forgot to check by pip freeze,everything will be up to you.
Documentation Link
https://github.com/run-llama/llama_index

llama-index is a starter package around several sub-packages. You can always install core and whatever else you need.
There is a Settings object that controls global defaults. If you don't want to use openai, set these to something else.


1.19.2 Forge Conflict with serene-seasons and krypton-reforged

Is it a mod compatibility issue?
Yes
If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)
https://www.curseforge.com/minecraft/mc-mods/serene-seasons, https://www.curseforge.com/minecraft/mc-mods/krypton-reforged
Minecraft version
1.19.2
Describe the issue
When starting server or single on world generation gives an error, attaching logs.
crash-2023-12-08_03.13.26-server.txt

same

After disabling Serene Seasons in my modpack to fix the crash, I can confirm that this crash DOES occur on 1.19.2 when Serene Seasons and Immersive Portals are enabled at the same time, in the same pack, with the same:
Caused by: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: PRIVATE @Overwrite method m_183760_ in imm_ptl.mixins.json:common.chunk_sync.MixinChunkMap_C cannot reduce visibiliy of PUBLIC target method
Please fix!

See #76. I have zero interest in fixing this, however I do accept pull request.


Change state class of JciHitachiMonthlyPowerConsumptionSensorEntity t…

Fix #46

Thank you. Have you checked that it works on your local with the state class None?

Yeah, it works without warning.


Quickstart -> Running LocalAI with All-in-One-> Couldn't get working.

LocalAI version:

localai/localai:latest-aio-cpu  (as on April 7th,2024)
Environment, CPU architecture, OS, and Version:

Linux 5.15.0-101-generic #111~20.04.1-Ubuntu SMP Mon Mar 11 15:44:43 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
"Ubuntu 20.04.6 LTS (Focal Fossa)"
Describe the bug

Well, I followed the quick start and ran:
docker run -p 8080:8080 --name local-ai -ti localai/localai:latest-aio-cpu

and things seemed good... downloaded and started running, I only saw this one error...
5:32AM ERR error downloading models: failed to download file "/build/models/c231ac8305a82f0293c2ba25e1549620": Get "https://huggingface.co/mudler/all-MiniLM-L6-v2/resolve/main/ggml-model-q4_0.bin": dial tcp: lookup huggingface.co: i/o timeout

http://<IP_ADDRESS>:8080/models returns {"object":"list","data":[{"id":"gpt-4","object":"model"},{"id":"text-embedding-ada-002","object":"model"},{"id":"whisper-1","object":"model"},{"id":"stablediffusion","object":"model"},{"id":"gpt-4-vision-preview","object":"model"},{"id":"tts-1","object":"model"}]}
So I tried this as I'd seen in another issue:
curl http://localhost:8080/v1/chat/completions -H "Content-Type: application/json" -d '{
          "model": "gpt-4",
          "messages": [{"role": "user", "content": "How are you doing?", "temperature": 0.1}]
      }'

and just lots of fails in return:
{"error":{"code":500,"message":"could not load model - all backends returned error: 23 errors occurred:\n\t* could not load model: rpc error: code = Canceled desc = \n\t* could not load model: rpc error: code = Unknown desc = failed loading model\n\t* could not load model: rpc error: code = Unknown desc = failed loading model\n\t* could not load model: rpc error: code = Unknown desc = failed loading model\n\t* could not load model: rpc error: code = Unavailable desc = error reading from server: EOF\n\t* could not load model: rpc error: code = Unknown desc = stat /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf: no such file or directory\n\t* could not load model: rpc error: code = Unknown desc = stat /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf: no such file or directory\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/tinydream. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* could not load model: rpc error: code = Unknown desc = unsupported model type /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf (should end with .onnx)\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/autogptq/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/vall-e-x/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/sentencetransformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/exllama/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/transformers-musicgen/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/petals/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/vllm/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/transformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/bark/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/diffusers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/sentencetransformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/mamba/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/exllama2/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\t* grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/coqui/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS\n\n","type":""}}

I look inside the container...
root@43f55d3c5491:/build/models# ls -la
total 24
drwxr-xr-x 1 root root  444 Apr  7 04:24 .
drwxr-xr-x 1 root root   12 Mar 26 17:54 ..
-rwxr-xr-x 1 root root  431 Apr  7 05:29 01ef9266c178bdcf654bb8730bf1d55f.yaml
-rwxr-xr-x 1 root root  679 Apr  7 05:31 112ee7db86acb6c32ff0ad9e1d651094.yaml
-rwxr-xr-x 1 root root 3743 Apr  7 05:30 1bea8ef81b66dd63fcf3b68e5b959925.yaml
-rwxr-xr-x 1 root root 1230 Apr  7 05:32 23edd98fb1aee8a2cc1d8b07f2a8adec.yaml
-rwxr-xr-x 1 root root  457 Apr  7 05:30 4e8bce301ebed58b98689146c493d8c4.yaml
-rwxr-xr-x 1 root root  739 Apr  7 05:31 f3cb558f560f3efdeadc6b36d9064998.yaml

But I don't really know what I am looking for, and a bit lost at this point.  I saw the "If you are experiencing issues with the pre-compiled builds, try setting REBUILD=true" message, but where is that supposed to go?
To Reproduce

Expected behavior

Logs

hip@dragon:~$ docker start -i local-ai
===> LocalAI All-in-One (AIO) container starting...
Intel GPU detected
Intel GPU detected, but Intel GPU drivers are not installed. GPU acceleration will not be available.
GPU acceleration is not enabled or supported. Defaulting to CPU.
Starting LocalAI with the following models: /aio/cpu/embeddings.yaml,/aio/cpu/text-to-speech.yaml,/aio/cpu/image-gen.yaml,/aio/cpu/text-to-text.yaml,/aio/cpu/speech-to-text.yaml,/aio/cpu/vision.yaml
@@@@@
Skipping rebuild
@@@@@
If you are experiencing issues with the pre-compiled builds, try setting REBUILD=true
If you are still experiencing issues with the build, try setting CMAKE_ARGS and disable the instructions set as needed:
CMAKE_ARGS="-DLLAMA_F16C=OFF -DLLAMA_AVX512=OFF -DLLAMA_AVX2=OFF -DLLAMA_FMA=OFF"
see the documentation at: https://localai.io/basics/build/index.html
Note: See also https://github.com/go-skynet/LocalAI/issues/288
@@@@@
CPU info:
model name	: Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid mpx rdseed adx smap clflushopt intel_pt xsaveopt xsavec xgetbv1 xsaves dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp pku ospke md_clear flush_l1d arch_capabilities
CPU:    AVX    found OK
CPU:    AVX2   found OK
CPU: no AVX512 found
@@@@@
5:29AM INF Starting LocalAI using 4 threads, with models path: /build/models
5:29AM INF LocalAI version: v2.11.0 (1395e505cd8f1cc90ce575602c7eb21706da6067)
5:32AM INF Preloading models from /build/models
5:32AM INF Downloading "https://huggingface.co/mudler/all-MiniLM-L6-v2/resolve/main/ggml-model-q4_0.bin"
5:32AM ERR error downloading models: failed to download file "/build/models/c231ac8305a82f0293c2ba25e1549620": Get "https://huggingface.co/mudler/all-MiniLM-L6-v2/resolve/main/ggml-model-q4_0.bin": dial tcp: lookup huggingface.co: i/o timeout
5:32AM INF core/startup process completed!

 ┌───────────────────────────────────────────────────┐
 │                   Fiber v2.50.0                   │
 │               http://<IP_ADDRESS>:8080               │
 │       (bound on host <IP_ADDRESS> and port 8080)       │
 │                                                   │
 │ Handlers ........... 117  Processes ........... 1 │
 │ Prefork ....... Disabled  PID ................ 25 │
 └───────────────────────────────────────────────────┘

5:38AM INF Trying to load the model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with all the available backends: llama-cpp, llama-ggml, gpt4all, bert-embeddings, rwkv, whisper, stablediffusion, tinydream, piper, /build/backend/python/autogptq/run.sh, /build/backend/python/vall-e-x/run.sh, /build/backend/python/sentencetransformers/run.sh, /build/backend/python/exllama/run.sh, /build/backend/python/transformers-musicgen/run.sh, /build/backend/python/petals/run.sh, /build/backend/python/vllm/run.sh, /build/backend/python/transformers/run.sh, /build/backend/python/bark/run.sh, /build/backend/python/diffusers/run.sh, /build/backend/python/sentencetransformers/run.sh, /build/backend/python/mamba/run.sh, /build/backend/python/exllama2/run.sh, /build/backend/python/coqui/run.sh
5:38AM INF [llama-cpp] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend llama-cpp
5:38AM INF [llama-cpp] Fails: could not load model: rpc error: code = Canceled desc =
5:38AM INF [llama-ggml] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend llama-ggml
5:38AM INF [llama-ggml] Fails: could not load model: rpc error: code = Unknown desc = failed loading model
5:38AM INF [gpt4all] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend gpt4all
5:38AM INF [gpt4all] Fails: could not load model: rpc error: code = Unknown desc = failed loading model
5:38AM INF [bert-embeddings] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend bert-embeddings
5:38AM INF [bert-embeddings] Fails: could not load model: rpc error: code = Unknown desc = failed loading model
5:38AM INF [rwkv] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend rwkv
5:38AM INF [rwkv] Fails: could not load model: rpc error: code = Unavailable desc = error reading from server: EOF
5:38AM INF [whisper] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend whisper
5:38AM INF [whisper] Fails: could not load model: rpc error: code = Unknown desc = stat /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf: no such file or directory
5:38AM INF [stablediffusion] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend stablediffusion
5:38AM INF [stablediffusion] Fails: could not load model: rpc error: code = Unknown desc = stat /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf: no such file or directory
5:38AM INF [tinydream] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend tinydream
5:38AM INF [tinydream] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/tinydream. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [piper] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend piper
5:38AM INF [piper] Fails: could not load model: rpc error: code = Unknown desc = unsupported model type /build/models/huggingface:/l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf (should end with .onnx)
5:38AM INF [/build/backend/python/autogptq/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/autogptq/run.sh
5:38AM INF [/build/backend/python/autogptq/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/autogptq/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/vall-e-x/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/vall-e-x/run.sh
5:38AM INF [/build/backend/python/vall-e-x/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/vall-e-x/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/sentencetransformers/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/sentencetransformers/run.sh
5:38AM INF [/build/backend/python/sentencetransformers/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/sentencetransformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/exllama/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/exllama/run.sh
5:38AM INF [/build/backend/python/exllama/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/exllama/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/transformers-musicgen/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/transformers-musicgen/run.sh
5:38AM INF [/build/backend/python/transformers-musicgen/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/transformers-musicgen/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/petals/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/petals/run.sh
5:38AM INF [/build/backend/python/petals/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/petals/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/vllm/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/vllm/run.sh
5:38AM INF [/build/backend/python/vllm/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/vllm/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/transformers/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/transformers/run.sh
5:38AM INF [/build/backend/python/transformers/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/transformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/bark/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/bark/run.sh
5:38AM INF [/build/backend/python/bark/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/bark/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/diffusers/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/diffusers/run.sh
5:38AM INF [/build/backend/python/diffusers/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/diffusers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/sentencetransformers/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/sentencetransformers/run.sh
5:38AM INF [/build/backend/python/sentencetransformers/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/sentencetransformers/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/mamba/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/mamba/run.sh
5:38AM INF [/build/backend/python/mamba/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/mamba/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/exllama2/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/exllama2/run.sh
5:38AM INF [/build/backend/python/exllama2/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/exllama2/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS
5:38AM INF [/build/backend/python/coqui/run.sh] Attempting to load
5:38AM INF Loading model 'huggingface://l3utterfly/phi-2-layla-v1-chatml-gguf/phi-2-layla-v1-chatml-Q8_0.gguf' with backend /build/backend/python/coqui/run.sh
5:38AM INF [/build/backend/python/coqui/run.sh] Fails: grpc process not found: /tmp/localai/backend_data/backend-assets/grpc/build/backend/python/coqui/run.sh. some backends(stablediffusion, tts) require LocalAI compiled with GO_TAGS

Additional context

@hippyau that looks a connection error while trying to download the models. The AIO images are pre-configured to download initially all the models in the models volume if not present already, is that a temporary error, or you can reproduce it regularly?
maybe could also be something going wrong on huggingface's end.

Oh right, so it has downloaded nothing.   Okay thanks I'll look into connection issues 👍

OMG my docker couldn't get to the internet... first it couldn't resolve IP's and then it couldn't get outside my LAN...
nothing to do with LocalAI :1st_place_medal:
docker run -p 8080:8080 --net=host --name local-ai -ti localai/localai:latest-aio-cpu
added --net=host  and models are downloading now.


Apply golangci-lint to config-mgmt-service and secrets-service

These are 2 of the 3 services that don't seem to be using the linter
currently. This applies the linter to those projects which will
hopefully make it a bit easier to transition to having
go_component_static_tests run the linter.
ingest-service is, I believe, likely the last service that needs to
have the linter applied to it. I have not done it here because there
are a large number of errcheck violations that need to be looked at
carefully.
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

https://github.com/chef/a2/issues/4979


otel-cli span background needs to be able to background itself

I'm adding otel-cli to some production shell scripts and want to do this:
local otelcarrier=$(mktemp)

otel-cli span background \
	--name "$0" \
	--service "osie" \
	--tp-carrier "$otelcarrier" \
	--timeout 1800 &

source "$otelcarrier" # load the new traceparent

But this has a race condition, most of the time, otel-cli will not have started up and written to $otelcarrier for a few ms and the sourcing fails.
Proposal: add otel-cli span background --fork (or something like that) that will have otel-cli fork itself into the background so it can block at startup for all the plumbing stuff. It already does this as early as possible so most of the challenge here is figuring out the right way to make a Go process go in the background on its own.
It's not clear the best way to do this in Go. Some folks seem to re-exec the otel-cli binary. That seems like the most sanctioned approach. Another way might be to syscall directly to fork() which should be okay since we're immediately exiting the parent after fork().

this seems reasonable enough https://gist.github.com/tobert/cecd89f669dca5012dda9cc965ce30b7

Digging into the example more, the re-exec approach works fine to separate the process but has a side-effect in that I can't find a way to continue monitoring ppid with os.Getppid() like we do now. Looking at the process table doesn't seem right and Linux tricks aren't portable.
If there's not a good way to fix these race conditions e.g. on events to the background socket or --tp-carrier, I feel like maybe span background should be removed entirely since it's not really safe to use as it is.

Taken care of in #73 but I still need to add it to the README so I'll leave this open so I don't forget.


Fixes help text formatting

Problem
While viewing validator --help, I noticed a few help strings that needed formatting.
Summary of Changes
I've made each change its own commit. In each commit message—for a specific arg—there is how the help text is currently displayed.

fix help for --incremental-snapshots
fix help for --no-wait-for-vote-to-start-leader
fix help for --wen-restart
removes double spaces (for consistency, since we do not use double spaces elsewhere in help text)
fix alignment

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (8b66a67) to head (24a64ce).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         838      838
  Lines      227363   227363
=======================================
+ Hits       186187   186204   +17
+ Misses      41176    41159   -17


Support for i18n

I've been looking at hyperapp for my project and I really like this library, although I am only getting used to pure functional approach.
I think the doc is missing important point of what would be 'the framework' way to add support for internationalisation?

@kenota I've dealt with supporting internationalization (i18n) in large apps before, and there's not really "one right way" to do it.
Part of the problem is localizing your dates and numbers per national conventions. For this we have the Intl API (And polyfills thereof).
Another part of i18n is translating user-visible text into different languages. This one comes with lots of options depending on your use case and design constraints. If you are going to have multiple deployments for supporting different locales then you could pull in the correct content during your build/bundle step, assuming you have one. If, however, you have requirement to support dynamically changing the language at runtime then the next question is where does your content live? Are you requesting each new language from some API/CDN or does your bundle have all the languages already baked into it? For some folks it makes sense to keep their language strings static, but in other cases they need to be more dynamic.
Once you have answers the previous questions, we get to what I think is the heart of your original question: how do we render different language strings in our UI? If we want to support using a component to do this (a la React Intl) then the next problem to solve is the need to pass the available language strings around as props to each component that needs them for rendering localized output (React Intl uses context for this purpose, see here for a discussion about how you might pre-wire components in Hyperapp, and some of the drawbacks).
Another approach might be deciding to write a (or use an existing) text wrapper function that will handle this formatting for you as an external dependency to your components. FormatJS has some building blocks that would help with just such a thing. And if you want to minimize the boilerplate there could be work added to your build step to automate any of the tedious parts of this.

@okwolf thank you for your reply. Very good decomposition of my question 👍
You are totally right, I was thinking about problem: how to render different language strings in the UI in hyperapp way. Since my app is very simple, I was thinking about having a global key-value map which is populated once on app load based on user locale, something like:
function Greeting (state, actions) => {
    return (
 {GlobalLang['WELCOME_MSG']}, {state.username}!
);
}

to avoid passing it in state.
Thank you for FormatJS link, looks interesting. I think I might settle on global object + FormatJS because I am not planning to allow change of language once application is rendered. The only thing which bothers me, that it no more 'purely functional' since it is relying on something else to render, apart from state and actions.
Would be really great to have options you listed having in the doc for other developers getting their head around hypeapp.

Since the i18n needs are most likely to be felt in the view, you can easily use components to create your own easy to use translation logic.
This is a kinda stupid example, but I think you will understand what I am trying to do here.
const Translate = ({data, locale}, [message]) => {
  const msg = new IntlMessageFormat(message, locale)
  return ({msg.format(data)})
}

And you will use it that way.
const INTL = {
  'en-US': {
    messages: {
      photos: `{name} took {numPhotos, plural,
          =0 {no photos}
          =1 {one photo}
          other {# photos}
        } on {takenDate, date, long}.`
    }
  }
}

app({
  state: {
    photos: {
      name: 'Annie',
      numPhotos: 1000,
      takenDate: Date.now()
    }
  },
  view(state) {
    return (

        <Translate locale="en-US" data={state.photos}>
          {INTL['en-US'].messages.photos}
        </Translate>

    )
  }
})

@Swizz thank you for the example, this is very useful.

Does this close your issue ?

Yep! Thank you.

Hey guys, @Swizz @kenota!
What was the lesson learned here? Sorry, I didn't have much time to address this issue, but would love to know what were your conclusions.
👋

Is it worth to use, even plan to integrate, the i18next library? It supports a lot of 'big' frameworks from react to vue.

@jorgebucaran i have write a i18n plugin, pls help me to transfer to hyperapp org and publish to npm. thx.
Transfer ownership:
 You don’t have the permission to create repositories on hyperapp

https://github.com/willin/i18n

Thank you, @willin. Before we can do there are a few things we need to work on. For starters, you can use
this template to document the project.
You'll also need tests, coverage, and examples. I'd also like to discuss the API with you and other members as well, so would you be able to join our Slack? 👋

http://hyperappjs.herokuapp.com/

@jorgebucaran done


Proposed use case: Readonly Store

Background of this use case, see: #1878.

Maybe there is an easier way to support this use case.

Yeah, I hope so too. Right now, I am not sure whether there's simpler option. If we consider this as a configurable thing, then I think no matter what name it is, readonly, offline, or whatever else, it is essentially a way to control the writes and autosync-on-writes behavior conditionally. Also, it seems that has to be a per-store config, because practically, to make the local store completely readonly is not a good idea as people may have both private and sharable stuff stored on local.
On the other side, if we can consider it as a non-configurable thing, maybe a better idea, since people can explicitly turn off the readonly config for a team sharing store which will bring back the painful things again. With that, it looks to declare a store to be readonly during the init phase would make much more sense. However, the store owners or privileged users still need write access to the store. This makes the idea slip to some kind of RBAC model which is also something I may want to avoid since it may also be complex or even more complex than a config option.

I'd still want to merge this and eventually support the use case but I don't like to proposed configuration section, yet.
So either @morningspace changes this or we merge it as is and update it afterwards.

@dominikschulz I think you can edit it by sending extra commits directly on the branch morningspace/gopass, and it will accept commits from the original repo maintainers.


Config

How do I use configs

Hi @ThatQne!
You can use all types of v2ray configs by importing them as File or Link.
After opening the app, click on Manage server configuration. In the opened window, click on the Plus button.
Now, you see two options for importing your config.

If you have a v2ray json file, you should choose Import config file and then import your file.
But if you have v2ray link (Like vmess://, vless://, ss:// or trojan://), you should choose Import from link and paste your link.


uuid is not properly detected resulting in a infinite task

Hello, thanks for your plugin!
Unfortunately, I've encountered bug:

Write - [ ] Test
TWSyncTasks
uuid is appended to the task: - [ ] Test $id{...}
TWSyncTasks
uuid is appended once again: - [ ] Test $id{...} $id{...}
... and so on...

In the taskwarrior I see that each task is considered a new one. So uuid is not detected and after it's appended by this plugin a new one created as many times as we run TWSyncTasks.
105 1min  Test                                                                                0
106 40s   Test {54c8ed14-7163-448b-a0be-5c8b34188944}                                                                                0
107 31s   Test {54c8ed14-7163-448b-a0be-5c8b34188944} {3d97278a-0eef-4fca-82cb-e6aa703afb5d}                                           0
108 26s   Test {54c8ed14-7163-448b-a0be-5c8b34188944} {3d97278a-0eef-4fca-82cb-e6aa703afb5d} {6d3adc35-248f-44b8-a4fe-b60b431de688}    0

I tried to dig into source code to fix this problem. As for me, problem lies in id_part_pattern and how it accounts comment strings (that IMHO also doesn't work correctly - I don't see a comment string added to the id part).
I placed print statement in a add_or_sync_task function:
  local _, uuid = string.match(line, M.id_part_pattern.lua)
  print(uuid, M.id_part_pattern.lua)
  if uuid == nil then

And got following results (during TWSyncTasks on a second and fourth steps):
nil (<!%-%- (%$id{(%x*-%x*-%x*-%x*-%x*)}) %-%-%>)
nil (<!%-%- (%$id{(%x*-%x*-%x*-%x*-%x*)}) %-%-%>)

As you can see uuid is always nil. And pattern has comment strings while I didn't pass it to the config.
It seems they're not inserted properly when I run the command.
I tried commenting id part manually (- [ ] Test5 <!-- $id{...} -->) and got proper id:
$id{6ba95418-c21a-4c58-a0d5-870c14f42bc3} (<!%-%- (%$id{(%x*-%x*-%x*-%x*-%x*)}) %-%-%>)

but it was immediately overwritten by plugin and I was left with the task without comment (- [ ] Test5 $id{...}). On next run it of course yielded the same error:
nil (<!%-%- (%$id{(%x*-%x*-%x*-%x*-%x*)}) %-%-%>)

I tried setting an empty comment string but got the same buggy behaviour. The pattern seemed incorrect too (notice the space between ():
nil ( (%$id{(%x*-%x*-%x*-%x*-%x*)}) )
nil ( (%$id{(%x*-%x*-%x*-%x*-%x*)}) )

Hope you help resolve this issue! I have just installed this plugin so I'm still not 100% sure I understand how everything should work ideally and I'm confused why this bug wasn't noticed yet - what if it's mistake on my part... Anyway, I'll try to assist as much as possible!

Hey @DeadlySquad13, thanks for raising an issue (and being early adapter). Yes, definitely a bug. Apology for the issue, I was eager to release this version with comments support. I will likely to release a fix for this ASAP

A bonus if you want to remove the duplicated entries, you can try task modified.after:today-[number of hours]h done or delete

@huantrinh1802, thanks for the quick response! The bug is fixed on newer version. But the comment is still not added - you have to add it manually after first sync. After that comment works fine. Is it intended behaviour? As for me, comment should be inserted after first TWSyncTasks along with uuid. For example, if you run:

- [ ] Test
TWSyncTasks

You get a - [ ] Test $id{...}. Of course, if you run TWSyncTasks again, it will not detect uuid properly (because it lacks comments) and add a one more uuid. So I think the result should be - [ ] Test <!-- $id{...} --> instead if the comment_prefix and comment_suffix are set.

Yup, good catch. I totally missed that.


torch.log10() computes torch.log()

torch.log10(torch.tensor(new float[] {10, 20, 30}))

[3], type = Float32, device = cpu
 2.3026 2.9957 3.4012

Expected:
1.0000, 1.3010, 1.4771

src\TorchSharp\Tensor\Tensor.Math.cs
        /// <summary>
        /// Returns a new tensorwith the logarithm to the base 10 of the elements of input.
        /// </summary>
        /// <param name="input">The input tensor.</param>
        public static Tensor log10(Tensor input) => input.log();

I wish all bugs were this easy to fix. Please use Tensor.log10() for now. This will be addressed in the next release.


Salsa duplicate literal properties cause should be flagged only when in strict mode

Testing #2218
The duplicate here is not a problem because the code is not in strict mode (also tried running it and node runs it just fine):
// "use strict";
var o = { p: 1, p: 2};
console.log(o);

But in ES6 this is not an error anymore?
I have also found the following interesting note at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode:

The same is true regarding other flagged errors that should only be errors in strict mode:

This issue was moved to Microsoft/TypeScript#6650


Storage pool not found error

Hello, this is the error I tried but failed to avoid, when creating VM def for the bootstrap node, I got below about no storage pool with matching name 'default'. Appreciate your input!
TASK [../../roles/kubeinit_libvirt : Create VM definition for the bootstrap nodes] *******************************************************************************
skipping: [hypervisor-01] => (item=okd-master-01)  => {"ansible_loop_var": "item", "changed": false, "item": "okd-master-01", "skip_reason": "Conditional result was False"}
skipping: [hypervisor-01] => (item=okd-worker-01)  => {"ansible_loop_var": "item", "changed": false, "item": "okd-worker-01", "skip_reason": "Conditional result was False"}
failed: [hypervisor-01] (item=okd-bootstrap-01) => {"ansible_loop_var": "item", "changed": false, "cmd": "# If you use the kernel args to deploy the machine\n# Is not possible to render the template as --print-xml > vm.xml\n# If so then is good to have it like 'virsh define vm.xml'\nkernel_args='ip=dhcp rd.neednet=1 console=tty0 console=ttyS0 coreos.inst.stream=stable coreos.inst.install_dev=/dev/vda coreos.inst.image_url=http://<IP_ADDRESS>:8080/okd4/fedora-coreos-32.20200715.3.0-metal.x86_64.raw.xz coreos.inst.ignition_url=http://<IP_ADDRESS>:8080/okd4/bootstrap.ign'\nvirt-install    --connect qemu:///system    --name=okd-bootstrap-01    --memory memory=16384    --cpuset=auto    --vcpus=8,maxvcpus=16    --os-type=linux    --os-variant=fedora29    --autostart                    --network network=kimgtnet0,mac=52:54:00:6e:4d:a3,model=virtio              --disk size=20,readonly=false    --location /var/lib/libvirt/images/    --extra-args "${kernel_args}"\n", "delta": "0:00:00.572963", "end": "2020-09-29 15:19:56.091830", "item": "okd-bootstrap-01", "msg": "non-zero return code", "rc": 1, "start": "2020-09-29 15:19:55.518867", "stderr": "ERROR    Error: --disk size=20,readonly=false: Storage pool not found: no storage pool with matching name 'default'", "stderr_lines": ["ERROR    Error: --disk size=20,readonly=false: Storage pool not found: no storage pool with matching name 'default'"], "stdout": "", "stdout_lines": []}

solvedthnx

@git4liluo can you share what you did here to solve your issue?

I am new, tried some ways suggested here and there. I am not sure if this is the right way, seems working for me:

virsh pool-list, I don't see default, I see images from the output;
virsh pool-destroy images
virsh pool-undefine images
then restart the deployment
virsh pool-define /dev/stdin << EOF

default

/var/lib/libvirt/images

EOF
virsh pool-start default
virsh pool-autostart default
Many thanks for your created tool!


notebook/kernelSource commands don't have notebook context and don't pass in the related editor as an argument

We've been playing around more with these notebook/kernelSource commands and I'm seeing some issues (I believe) that are going to start causing issue with them the more we use them.
In package.json it would be really nice to be able to define a when: notebookType == 'jupyter-notebook' but this doesn't seem to currently work. Right now the Server Switching commands from the experiment showing up in .dib files (I'm fixing this now). Also when these commands are called I believe that they don't have the current editor as an argument. That would be really helpful with the kernel picking experiments that I'm working on.

Fixed via https://github.com/microsoft/vscode/pull/163693 and https://github.com/microsoft/vscode/pull/163701

Makes all the kernel source command scenarios much better. Thanks much!


Embedded array of struct issues. Resolves mono/CppSharp#1598

See issue #1598 for description.

Thanks for the fixes, it looks good.
The Windows CI with some Nuget issues, I've re-run all jobs in the meanwhile to see if it was just some temporary thing.

Thanks, I have no idea why the restores (NUnit, etc.) are failing on the windows side. I didn’t change anything there and they obviously worked locally.
From: João Matos @.***
Sent: Monday, April 12, 2021 10:21 AM
To: mono/CppSharp @.>
Cc: Joe Hull @.>; Author @.***>
Subject: Re: [mono/CppSharp] Embedded array of struct issues. Resolves mono/CppSharp#1598 (#1599)
Thanks for the fixes, it looks good.
The Windows CI with some Nuget issues, I've re-run all jobs in the meanwhile to see if it was just some temporary thing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mono/CppSharp/pull/1599#issuecomment-817986319 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFAFLYXE66TTIRMQRCAFG3TIMTWBANCNFSM42ZWJGWA .  https://github.com/notifications/beacon/AEFAFL6ES2EC37VHIGUH2STTIMTWBA5CNFSM42ZWJGWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGDAXWDY.gif

Even though the PR CI was fully green, master is now complaining: https://github.com/mono/CppSharp/runs/2350856410#step:6:11
I am not sure why and don't really have time to check this right now.
If you got time to check this, it would be appreciated.

I don't understand it either. The message(s) indicate some sort of CI-time SDK configuration error.
I tried pulling the newly merged main branch and (of course) had no trouble restoring / building locally.
The projects that are failing are all C++/CLI projects which seems to match the docs pointed to by the URL in the error message. I haven't yet found where Visual Studio / MS Build establishes the expected AppHost version. However, if I'm interepreting the error message correctly, the version it found is (3.1.14). That version is included in the latest VS2019 version, v16.9.4. The previous Visual Studio version (v16.9.3) uses 3.1.13. The doc that the URL in the message refers you to suggests that scenario might be the issue:

"This is typically caused by having a newer SDK than the one included in Visual Studio for C++/CLI projects. "

I can't see any version info for Visual Studio in the logs. Could this be the problem? Is it possible to update Visual Studio on the CI server?


Disable unaligned access of > 4 bytes on 32-bit arm

Fix #624
I'm not a fan of CMake, so, hopefully I haven't mangled that too much ;).

Looks good. I think you are safe to squash/combine those commits into one.

Looks good to me.

(Rebased w/ ppc64le handling, where I assume this ought to be enabled ;)).


getBuildNumber "git" and "svn" check: != instead of ==. Fixes #1414.

If I'm understanding the old logic (from before the #1410 pull request was merged) correctly, this doesn't seem like the correct solution either, even if it stops the exception. I reverted the commit from #1410 for now, since it is preventing people from getting work done. Hopefully, the correct solution can be found.


Problem with < and >

Everytime i tried to flash > or < to a button it gave me error.
If that's not possible maybe write this to readme.

You encode keys, not characters (because keyboard emits keys and what characters are produced depends on your layout). Use shift-comma and shift-dot.


Update README.md

I added the item to readme.md.
Please contribute to my project if you can:
https://github.com/MinoruIshihara/AttractingContributors-Ramen

Thank you for your contribution, MinoruIshihara-san! I'll also contribute you.


WIP Suppport multiple dev stacks / simplify development

This PR is not ready for review. Closing for now.


Use Instant for time tracking instead of SystemTime

This MR introduces Instant for time tracking in the timer, replacing the before used SystemTime.
Closes #42.

merged into actors.rs


Struggling to run on bgnn or google colab or anacondas

Hi, any suggestions on how to run bgnn on anacondas or colabs?

@skravoof you can run jupyterlab on colab using this notebook
https://colab.research.google.com/github/cyyeh/tokyo-stock-exchange-prediction/blob/main/run_jupyterlab.ipynb#scrollTo=1HEhHNDNeG-a


How to select menu position when using popBackStack?

Hi, newbie here.
Let say I have 3 menus (Menu 1, Menu 2, Menu 3)
Then in onNavigationDrawerItemSelected I use addToBackStack for each menu.
After run the app, I select the Menu 2, then I hit the back button, it will show Menu 1 but drawer still highlighting Menu 2.
How to change the drawer highlight?
I know by using selectPosition, but how to get the position?

You can do that on your fragment's onAttach method. This method will get called when the fragment gets attached on the view. In order to retrieve the position you will need to statically set it on each fragment. I'm afraid there is no way to retrieve the position in a simpler way.
Here is a snippet of a fragments onAttach
@Override
public void onAttach(Activity activity) {
    super.onAttach(activity);
   NavigationDrawerFragment drawer= (NavigationDrawerFragment) activity.getFragmentManager().findFragmentById(R.id.fragment_drawer);
    if(drawer!=null && drawer.getView()!=null){
        RecyclerView recyclerView = (RecyclerView) drawer.getView().findViewById(R.id.drawerList);
        if(recyclerView.getAdapter()!=null){
            ((NavigationDrawerAdapter)recyclerView.getAdapter()).selectPosition(0);
        }
    }
}

Notice the selectPosition(0). You will need to change this position to the position your fragment is taking on the menu. Hope this helps.

hi,
but the onAttach method won't be called when the fragment is coming from the backstack... wouldn't it be better to have it in the onCreateView method?

Yes you're correct. It's better to call it on onCreateView.


Websocket events and fixing the api_streams sensor.

Description:
PR #22150 was going to remove the api_streams sensor, but I thought this could do with a rethink.
I've added events to be raised by the the websocket api when a websocket connects, disconnects, and receives a message.
The api_streams sensor now listens for these events, instead of parsing a log message like it used to.
I haven't implemented this for the old api component, but this is deprecated anyhow. It would be pretty easy to add the same events however.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

If it's just limited to websocket API, we should make this sensor a part of the websocket API.

Downside of making the sensor a part of the websocket API is that you lose backwards compatibility with old configs. OFC it's really not being used a lot.

@balloob All fixed.


This is not supported in browser version of superagent

I got this error when i use React Native with superagent to access https api, the code like is:
      Request
        .post('xxxx')
	.ca(HXYConst.CABuf)
        .send({ username:opt.username, password:opt.password})
        .set('Accept', 'application/json')
        .end(function(err, res){...}

any suggestion?

Like the message says, you're using web-browser-only version of superagent and you're trying to use .ca() feature which can only work in node.js environment.
Remove .ca() or run it in Node.js.

v5.0.0 was released and should fix this issue


Add support for different environments when linking to BYOF

Is your feature request related to a problem? Please describe.
When using Azure Functions that are not part of the SWA repository (ie. Bring Your Own Function -- BYOF), it is possible to link the SWA to the Functions App, such that "/api/..." paths resolve to the Functions App without having to do any extra configuration or coding.
However, this only appears to be supported in the Production environment. 😞
If I create a Pull Request for my repository in GitHub, this invokes a GitHub action that creates a new SWA environment on Azure for testing the changes, but as the environment is not linked to the Functions App, all of the API calls fail with a 404 error.
To be honest, I'm not entirely sure how I would go about testing API calls in any non-Production environment, which makes them basically useless for BYOF. I'm sure they're great if the API/Functions are part of the same repository, but unfortunately I can't do that because I'm using Azure storage, which is causing its own set of problems (see  #631).
Describe the solution you'd like
The Azure portal should allow linking to a BYOF Function App from SWA environments other than Production.

Hi! Support for this is coming in the next month! I'll update this thread when this support has been released.

That's great news, thanks!

Hi @TheMightyBorkon, we have launched support for Branch and Named Preview Environments ! These are non-production environments that can be linked to another BYOF. Just follow the existing tutorial on BYOF and select your stable preview environment from the drop-down instead of your production environment. We still have to update these docs, but the feature is live and ready to use.
Let us know if it works for you, and thank you for using Static Web Apps! 😄

@mishapos This is great news. Are there any plans in the near future to support pull request preview environments and update az staticwebapp functions link to support environments?

I was able to link PR-preview environments to function apps using the python azure sdk, see https://github.com/JabRef/JabRefOnline/tree/main/.github/scripts.

You can now link your backend to each environment in the Portal and the Az CLI 🎉 Closing this issue, feel free to re-open if needed


404 at https://docs.korge.org/korge/setup

https://docs.korge.org/korge/setup

Thanks for creating/maintaining this project! Just wanted to play around with it a bit.
I'm looking at https://github.com/korlibs/docs.korge.org/blob/master/%40old/korge/setup/index.md for now.

New link should be this one: https://docs.korge.org/korge/gettingstarted/setup/
In order to fix it: where did you found the broken link?

Right here under tools: https://docs.korge.org/korge/


Branch binary_framework does not solve warning about binary compatibility.

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation or CocoaDocs
[x] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
iOS

Platform Version
13.4

CocoaLumberjack Version
3.6.1

Integration Method
Swift Package Manager

Xcode Version
Xcode 11.4.1

Repro rate
All the time (100%)

Issue Description and Steps
My project integrates CocoaLumberjack using Swift Package Manager and compiler generates the warning below:

Module 'CocoaLumberjackSwift' was not compiled with library evolution support; using it means binary compatibility for 'MyTarget' can't be guaranteed.

I am currently using the branch binary_framework, which supposedly solved the issue but the problem persists.

Duplicate. See https://github.com/CocoaLumberjack/CocoaLumberjack/pull/1110

@rodmaz Actually, your case is a little different here. You stated that you use Swift Package Manager as integration method. SPM and library evolution don't work together since SPM is (currently) based on an approach where the sources will always be re-built. So the changes we currently provide on the binary_framework branch will not affect SPM.
In your case, you seem to use CocoaLumberjack in a framework that has library evolution enabled. In this case, you'd have to integrate with e.g. submodules and use the Xcode project provided in this repository. Then your warning will go away. However, the issues described in #1110 will still persist.

@ffried Correct, it is a framework with BUILD_LIBRARY_FOR_DISTRIBUTION enabled.
Would you mind to elaborate a bite more on "you'd have to integrate with e.g. submodules"? So the files in folder Configs under SPM are not actually used during compilation?
The file Module-Shared.xcconfig has it also turned on:
// !!!: EXPERIMENTAL
// Ensures that your libraries are built for distribution. For Swift, this enables support for library evolution and generation of a module interface file.
BUILD_LIBRARY_FOR_DISTRIBUTION = YES

@rodmaz Correct. SPM has its completely own build process. It does not need any Xcode projects and thus also does not use any xcconfigs.
I you want a version of CocoaLumberjack with library evolution enabled, you would need to use an integration method that uses the Xcode project we provide (and thus also uses our xcconfigs). Git submodules would be one option that does so. Carthage does so, too.


Add labels to banner

This PR improved the localize-ability of Preference Window Banner

[x] Replace built-in-image text with 2 labels (#46)
[x] Optimized Chinese Simplified Localization

@p-z-l Please follow git-flow by create a branch: feature/Improve_Localization instead of working directly on your develop branch. We will add Git Flow guidance and code convention to README  later. Thanks for your help and understanding.


[Fixed] Getting Raw Query

Hello @pdphilip ,
Is there a way to log the raw query sent to OpenSearch? The ToSQL() outputs the sql version of the query passed, is there a way to output the OpenSearch query that has been passed to the cluster

Hey @karthikv29, I'll add this in the next release 👍

Hi @karthikv29 , if you update to the latest release (v2.0.2) then you'll gave the toDsl()/toSql() method available to you.
Docs: https://opensearch.pdphilip.com/os-specific#to-dsl
All the best

Thanks a lot
On Fri, Aug 2, 2024 at 7:50 AM David Philip @.***>
wrote:

Hi @karthikv29 https://github.com/karthikv29 , if you update to the
latest release (v2.0.2) then you'll gave the toDsl()/toSql() method
available to you.
Docs: https://opensearch.pdphilip.com/os-specific#to-dsl
All the best
—
Reply to this email directly, view it on GitHub
https://github.com/pdphilip/laravel-opensearch/issues/2#issuecomment-2265189194,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFHZTU4XHKFIN6XMSLTY4ALZPNW6RAVCNFSM6AAAAABKQRHYYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGE4DSMJZGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


I would like to see v1.9.0 released to crates.io as well.

Hello!
As the title says, any plans to release v1.9.0 on crates.io?
I am eagerly waiting for it!
I love mdbook-admonish because it makes the site look great 😆
Thanks!

Hey, thanks for the ping. I didn't realise this hadn't happened automatically - will work on fixing CI so it does next time.
In the meantime, I've just done the release manually, sorry for the delay!

Thank you so much for your quick response!
I will use it as soon as possible! 🤗


Add event before hiding

Hi,
I'm using easyZoom for a special case where the zoom is enabled until a button is clicked, and disabled when another button is clicked. One way of implementing it would be with a PermaZoom option.
Another way, which I'm currently testing, is to add an event "beforeHide" before the zoom is hidden. Something like this:
// Callback function to execute before the flyout is removed.
onBeforeHide: $.noop,

// ...

/**
 * Hide
 */
EasyZoom.prototype.hide = function() {
    if (!this.isOpen) return;
    **if (!this.opts.onBeforeHide.call(this)) return;**

     this.$flyout.detach();
     this.isOpen = false;

     this.opts.onHide.call(this);
 };

The custom event would then keep track of the current "open/closed" setting, and prevent the zoom from hiding if the setting is set to open.
Would this be something you would consider adding to the core library? I think it can be a useful feature.

Thanks for your feedback @leoquijano. Has this been a useful feature?
I so, I think it would make sense to include the accompanying onBeforeShow callback. If you wish to submit a PR for the feature I'll be happy to include it.

I'm actively using it. PR is in #87. I added an additional beforeShow event, and also changed the naming a bit so it's only beforeShow and beforeHide

released 36890d75e66bbd34868aedc319179a82b03f7b70


Installed and ran nfldb-update. Data Missing for 2017 and 2018

Hi,
I installed and ran nfldb-update. Data Missing for 2017 and 2018 .
Seems like 2017 and 2018 are missing data. 2019 works fine.

Hi OP,
I’ve found the solution here https://github.com/BurntSushi/nfldb/issues/314
This should help you bulk insert for 2017,2018,&2019.
Best,
SPD

That helped thanks


Clarification of where the value in CSIP86 comes from

Added where the value is collectecd from.
Closes #453

The text is good now. I only added a typo fix and a capitalisation of "MUST."


Firewall ACLs: Add readonly actions to "Aliases" permission

Add readonly actions to page-firewall-aliases permission:

api/firewall/alias/export
api/firewall/alias/getAliasUUID
api/firewall/alias/getGeoIP

@8191 nice catch, thanks!

@8191 nice catch, thanks!

@AdSchellevis Wow! That was super-fast! ;-)
Thanks

@AdSchellevis Wow! That was super-fast! ;-)
Thanks


main.cpp:120:40: error: invalid initialization of reference of type ‘std::vectorcv::String&’ from expression of type ‘std::vector<std::__cxx11::basic_string >’    glob(images_path, filenames_in_folder);

hitting this on linux
[ 50%] Building CXX object CMakeFiles/yolo_mark.dir/main.cpp.o
/home/jeremy/projects/Yolo_mark/main.cpp: In function ‘int main(int, char**)’:
/home/jeremy/projects/Yolo_mark/main.cpp:120:40: error: invalid initialization of reference of type ‘std::vector<cv::String>&’ from expression of type ‘std::vector<std::__cxx11::basic_string<char> >’
   glob(images_path, filenames_in_folder); // void glob(String pattern, std::vec
                                        ^
In file included from /usr/local/include/opencv2/core.hpp:3165:0,
                 from /usr/local/include/opencv2/core/core.hpp:48,
                 from /home/jeremy/projects/Yolo_mark/main.cpp:18:
/usr/local/include/opencv2/core/utility.hpp:184:17: note: in passing argument 2 of ‘void cv::glob(cv::String, std::vector<cv::String>&, bool)’
 CV_EXPORTS void glob(String pattern, std::vector<String>& result, bool recursiv
                 ^
CMakeFiles/yolo_mark.dir/build.make:62: recipe for target 'CMakeFiles/yolo_mark.dir/main.cpp.o' failed
make[2]: *** [CMakeFiles/yolo_mark.dir/main.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/yolo_mark.dir/all' failed
make[1]: *** [CMakeFiles/yolo_mark.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

@jeremy-rutman I fixed it. Try to update from Github and re-compile.