Upgrade to Python 3

ATM should now be compatible with both Python 2.7 and Python 3.5+ (haven't tested with 3.4 or below).

Codecov Report

Merging #81 into master will increase coverage by 0.37%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   73.93%   74.31%   +0.37%
==========================================
  Files          12       12
  Lines        1224     1234      +10
==========================================
+ Hits          905      917      +12
+ Misses        319      317       -2

Impacted Files
Coverage Δ

atm/tests/unit_tests/test_method.py
100% <100%> (ø)
:arrow_up:

atm/encoder.py
81.96% <100%> (+0.93%)
:arrow_up:

atm/constants.py
100% <100%> (ø)
:arrow_up:

atm/method.py
97.69% <100%> (ø)
:arrow_up:

atm/database.py
73.77% <100%> (+0.08%)
:arrow_up:

atm/model.py
67.97% <100%> (+0.42%)
:arrow_up:

atm/config.py
23.95% <25%> (+0.45%)
:arrow_up:

atm/metrics.py
52.12% <80%> (+1.04%)
:arrow_up:

atm/tests/unit_tests/test_enter_data.py
100% <0%> (+2.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b201ec...d0e9b40. Read the comment docs.


add which_dsl extension: use which{ } method as query DSL for accessing where()

add a simple query DSL for accessing where(), inspired by gem "squeel"
e.g.:
df.which{ `FamilySize` == `FamilySize`.max }`

equals
df.where( df['FamilySize'].eq( df['FamilySize'].max ) )

e.g.:
df.which{ (`NameTitle` == 'Dr') & (`Sex` == 'female') }

equals
df.where( df['NameTitle'].eq('Dr') & df['Sex'].eq('female') )

btw, repeating df variable is NOT DRY at all to me.

Pretty smart! TBH, I am not totally sure about backtick trick... Maybe method_missing/const_missing would be more predictable?.. (Sequel does this for its block DSL) It has its own drawbacks also, of course.

btw, repeating df variable is NOT DRY at all to me.

 It is an ancestry of copying Python's libraries, which I personally hate.

some column names(from csv) may containing space or special characters like ' or '-' etc， for these cases backtick is better then method_missing, and it's really recognizable compared to a normal method.

@rainchen Yep, makes sense for me.
I'm willing to happily accept this, but it needs some tweaks for docs and specs:

for docs: we should be sure to hide WhichQuery from YARD (and probably add a bit more explanations to which... But not sure it is necessary)
for specs: we are (slowly) trying to move to moder RSpec, as per betterspecs.org (with subjects, lets, contexts and stuff), for new features/modules they should be written this way.

Are you willing to make those changes? If not, I'll merge your PR, as it is a valuable contribution, and then update the style of specs/docs myself.

@zverok
I implemented this feature as an "extension", requiring to use require 'daru/extensions/which_dsl' to enable this feature (took example from rserve extension)
I'm glad you can work on the docs and code origination parts.
Here are some actually use cases that I'm using this which method:
# getting oldest passengers
passengers.which { `Age` == `Age`.max }

# getting youngest passengers
passengers.which { `Age` == `Age`.min }

# getting female Dr
passengers.which { (`NameTitle` == 'Dr') & (`Sex` == 'female') }

# getting passengers had the same name
same_name = passengers.which { `Name`.frequencies > 1 } ["Name"].to_a
# => ["Connolly, Miss. Kate", "Kelly, Mr. James"]
passengers.which { `Name` =~ same_name }

hope these helpful for you or others be interested.

Thank you! :hugs:

Thank you all!


We are expecting a reply

Good afternoon, sir. Is there a tutorial for this software? Can windows be used?

Hey mate,
You can use android studio to build this project. And for tutorial you can refer to - Build this project

For video tutorial you have to wait till Sep-2021
Thanks


How do I apply a font file?

What are you trying to achieve?
I would like to generate a png image by reading the font data provided.
However, font data does not appear to be loaded properly.
When you searched for similar issues, what did you find that might be related?
I have read this issue. https://github.com/lovell/sharp/issues/3479
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this question
//create and save
void sharp({
  text: {
    text: "てすとtest",
    font: "MyTextFile",
    fontfile: path.resolve("src/resource/MyTextFile.ttf"),
    rgba: true,
    width: 600,
    height: 100,
  },
}).toFile("src/resource/test.png")

test.png

Please provide sample image(s) that help explain this question
The same operation with the "TextToSVG" library yields the following results.
//load font file
const textToSVG = TextToSVG.loadSync("src/resource/MyTextFile.ttf")
// create text svg data
const svg = textToSVG.getSVG("てすとtest", {
  fontSize: 100,
  anchor: "left top",
  attributes: {
    fill: "red",
  },
})
//save svg to png
void sharp(Buffer.from(svg)).toFile("src/resource/test_textToSVG.png")

test_textToSVG.png

Have you tried setting PANGOCAIRO_BACKEND=fontconfig?
https://sharp.pixelplumbing.com/install#fonts

https://sharp.pixelplumbing.com/install#fonts

I tried a global installation of the font files for my Windows environment.
As a result, I succeeded in loading the font files.
Also, I had set the "font" option to the filename of the ttf file.
However, I had to set the correct font name, which was set in the font file.
I noticed this problem when I did a global install.
Thank you very much for your help.

Ah yes, font has to be the name of the font, which is not always the same as the filename. Glad you got it working.


Add text box element & improve text parsing

Add text box element
A text box can contain headings and paragraphs, in the future they should also support lists.
Ignore empty nodes when extracting text

Coverage remained the same at 100.0% when pulling 0615ac6f6d4d84f9c35ed9eeb981929308f39ac6 on dsager:text-box-element into caf2cca9346c485dce8ce923508e9414e1c25224 on Devex:master.

+1

+1


IDS Documentation / StarterKit4.0

Hi @Brandstaedter and @hosseinzadeha,
as discussed please find here the document that we would like to enrich until the IDSA Summit (June 22 and 23).
Feel free to add any content that may help others in developing / implementing components at any stage.
Thank you!

As the names of the chapters (and the URLs) are changed for the Knowledge Base, this issue will be closed.


(no data) for prices recently

Starting a couple days ago I can't get pricing data "in-game":

This is accompanied by "2022-11-16 13:55:22.9066|ERROR|NewWorldCompanion.Services.HttpClientHandler|MoveNext" in the logs. There is updated data for Olympus in nwmarketprices, not sure what the disconnect is here. Adding the uri of the "failed" call to the log could help me debug more here.

Thanks for the report. There is currently a problem with the nwmarketprices API.
The developer of nwmarketprices is already working on the problem.
Afterwards I'll have to make some changes as well for it to work correctly with the new API call.

Ah, I just found this myself:

LMK if I can help.

Will let you know, thanks for the offer.
Currently there is nothing we can do, we will just have to wait for the new nwmarketprices API call.

New API is ready.

recent_lowest_price is still working.
timestamp is broken, only requires a small format change.
avg price data is broken completely, requires some more work.

Current api example:
https://nwmarketprices.com/0/11/?cn_id=rawhidet1
Old api as reference
oldapi.txt

Fixed with the v<IP_ADDRESS> update.


Add easy way to compare yourself to friends

Create links at the /profile page to easly load the /result page showing the comparison between the current user and their friends

Implemented on d1d3195


Make HoloToolkit feature folders more modular

Scenarios:

Gina is a developer. She wants to add a script related to Cursors.
She should be able to add the script file, prefabs, tests, related materials etc. all into the Assets\HoloToolkit\Input folder aka feature folder. This makes the folder more compartmentalized while contributing.
David is a designer and he only wants to keep specific feature folders from the HoloToolkit.
The folder structure should be modular enough so users can delete not needed ones easily.

Dependencies between folders will be documented.

https://github.com/Microsoft/HoloToolkit-Unity/commit/afb09bd663dac4166b8543817fdaed0603185aba
Merged from the refactor branch.


fromRequest().body() returns invalid JSON

Say you have a contract with response body:
"keywords" : fromRequest().body('$.meta.keywords')

And in a request to the wiremock server the client sends something like:
 { "meta": { "keywords" : ["keyword1", "keyword2"] }

I would expect that to just be echoed back to client but instead get invalid JSON. I.e. "["keyword1", "keyword2"]"
I haven't added meta.keywords to the request part of contract at all, so I decide to add something:
body("meta":["keywords" : [anyOf("keyword1","keyword2")]])

This does return a valid JSON array of strings (and say "keyword3" if it was sent). (Now I'm sure there's a better way to say "keywords" is an array of non-empty strings but I digress).
Adding 'keywords' to the request part of the contract seems to fix the issue. Should it be required though? It seems to work fine without for simple strings, just when you're using anything else it's adding " to each side of the field, which can result in invalid JSON.
Anyway, as I added more fields to the request, I noticed something wrong with the response.
Say in my request part of the contract, meta gets a bit more complicated, like it has three layers of nesting in the request body of the contract, like:
"meta": [
                        "a"            : "A",
                        "b"               : [
                                "c"      : [
                                        "A",
                                        "B"
                                ],
                                "d"       : "C"
                        ]
                ]

Here I've just used static values in the request here, so it's easier to follow. Then I send some JSON body on which matches it. In this case making sure I have this in it:
"meta" : {"a" : "A", "b" : {"c" : ["A", "B"], "d": "C"}}}}
In the response body of the request, wiremock matches but I see invalid JSON being returned for this, namely things like:
{a=A, b={c=["A","B"], d=C}}
Which is strange. Again, I use fromRequest() to return the object to the client. Specifically fromRequest().body('$.meta') in this test example.
I tried this on the latest 1.2.0.BUILD-SNAPSHOT today. All requests are with: method 'POST', I haven't added any stubMatchers for the meta field, as I'm using other fields to match. And the url is just hardcoded.
Happy to send on any more information you need.
Best Regards,
Blain

Adding 'keywords' to the request part of the contract seems to fix the issue. Should it be required though? It seems to work fine without for simple strings, just when you're using anything else it's adding " to each side of the field, which can result in invalid JSON.

I don't understand this part at all. Can you elaborate on what the problem is?
Can you paste the full contract and the generated WireMock stubs?
As I understand the tests are generated correctly but the stubs don't work as they should?

Tests are generated without any issue, it's just when I'm testing it myself through wiremock I noticed the problem.
Something like:
request {
  body("a" : "1")
}
response {
  body("meta" : fromRequest().body("$.meta")
}

Works fine, if the client sends "meta" : "mystring", but deciding to send: "mystring" : 42, results in "42", and likewise ["1", "2"] becomes "["1", "2"]" for some reason.
Then adding in "meta" into request{ } seems to get around that, but should it be required?
Lastly, I noticed some weirdness when I started to make it a more complicated object, even if I include it in the request part of  the contract.
I hope this is clearer.

What you wrote makes no sense. There's no $.meta in the request. Response requires meta to be there but you don't set it in the request. I don't think that it's related to Contract at all.
I asked you to paste the wiremock stubs. Could you please do it?

Also can you paste the generated tests?

Full contract:
org.springframework.cloud.contract.spec.Contract.make {
    request {
        method 'POST'
        url '/api/payment/v1/payments'
        headers {
            header 'Content-Type', 'application/json'
        }
        body('data': ['test': 1
        ],
                "meta": [
                        "a"            : "A",
                        "b"               : [
                                "c"      : [
                                        "A",
                                        "B"
                                ],
                                "d"       : "C"
                        ]
                ])
    }
    response {
        status 201
        headers {
            header(
                    'Content-Type', value(consumer('application/json'), producer(regex('application/json.*')))
            )
        }
        body("Data": [
                "status"          : "Pending",

                "test"      :       fromRequest().body('$.data.test'),
                "info"            : fromRequest().body('$.meta'),
                "links"           : ["self": fromRequest().path()],
        ]
        )

    }
    priority 1
}

Wiremock JSON:
{
  "id" : "9608c170-de32-4253-a084-1d6e3513972b",
  "request" : {
    "url" : "/api/payment/v1/payments",
    "method" : "POST",
    "headers" : {
      "Content-Type" : {
        "equalTo" : "application/json"
      }
    },
    "bodyPatterns" : [ {
      "matchesJsonPath"<EMAIL_ADDRESS>== 1)]"
    }, {
      "matchesJsonPath"<EMAIL_ADDRESS>== 'A')]"
    }, {
      "matchesJsonPath" : "$.['meta'].['b'].['c'][?(@ == 'B')]"
    }, {
      "matchesJsonPath" : "$.['meta'].['b'].['c'][?(@ == 'A')]"
    }, {
      "matchesJsonPath"<EMAIL_ADDRESS>== 'C')]"
    } ]
  },
  "response" : {
    "status" : 201,
    "body" : "{\"Data\":{\"test\":{{{jsonpath this '$.data.test'}}} ,\"links\":{\"self\":\"{{{request.path}}}\"},\"status\":\"Pending\",\"info\":{{{jsonpath this '$.meta'}}} }}",
    "headers" : {
      "Content-Type" : "application/json"
    },
    "transformers" : [ "response-template" ]
  },
  "uuid" : "9608c170-de32-4253-a084-1d6e3513972b",
  "priority" : 1
}

And generated tests:
package ie.aib.msf.apigee.contracts;

import com.jayway.jsonpath.DocumentContext;
import com.jayway.jsonpath.JsonPath;
import ie.aib.msf.apigee.contracts.Payment_initiation_clientBase;
import io.restassured.module.mockmvc.specification.MockMvcRequestSpecification;
import io.restassured.response.ResponseOptions;
import org.junit.Test;

import static com.toomuchcoding.jsonassert.JsonAssertion.assertThatJson;
import static io.restassured.module.mockmvc.RestAssuredMockMvc.*;
import static org.springframework.cloud.contract.verifier.assertion.SpringCloudContractAssertions.assertThat;

public class Payment_initiation_clientTest extends Payment_initiation_clientBase {

	@Test
	public void validate_post-payments-initation-success() throws Exception {
		// given:
			MockMvcRequestSpecification request = given()
					.header("Content-Type", "application/json")
					.body("{\"data\":{\"test\":1},\"meta\":{\"a\":\"A\",\"b\":{\"c\":[\"A\",\"B\"],\"d\":\"C\"}}}");

		// when:
			ResponseOptions response = given().spec(request)
					.post("/api/payment/v1/payments");

		// then:
			assertThat(response.statusCode()).isEqualTo(201);
			assertThat(response.header("Content-Type")).matches("application/json.*");
		// and:
			DocumentContext parsedJson = JsonPath.parse(response.getBody().asString());
			assertThatJson(parsedJson).field("['Data']").field("['links']").field("['self']").isEqualTo("/api/payment/v1/payments");
			assertThatJson(parsedJson).field("['Data']").field("['status']").isEqualTo("Pending");
			assertThatJson(parsedJson).field("['Data']").field("['info']").isEqualTo({a=A, b={c=["A","B"], d=C}});
			assertThatJson(parsedJson).field("['Data']").field("['test']").isEqualTo(1);
	}

}

Curl command:
curl -X POST  http://localhost:8083/api/payment/v1/payments -d '{"data": {'test' : 1},"meta":{"a" : "A", "b" : {"c" : ["A", "B"], "d": "C"}}}}' -H "Content-Type: application/json"
Result:
Response:
HTTP/1.1 201
Content-Type: [application/json]
{"Data":{"test":1 ,"links":{"self":"/api/payment/v1/payments"},"status":"Pending","info":{a=A, b={c=["A","B"], d=C}} }}

I think this is a duplicate of https://github.com/spring-cloud/spring-cloud-contract/issues/363 . Can you confirm it?

So yeah, I can confirm for really simple values for meta, like 1, [1] and ["1"], they seem to be fine at least. It's only when I start to add objects into what I send that I get those '=' in the wiremock response. So it looks like a duplicate.
For checking for the existence of such objects (like meta) in the request, what's the best way to do that in the contract? My leaving it out entirely made sense initially since the server wasn't echoing it back. Thanks!

Closing this in favour of https://github.com/spring-cloud/spring-cloud-contract/issues/363


ping command

we are so ping pong

turn the Objects.requireNonNull check you removed and CodeClient.MC.player != null to a if (CodeClient.MC.player == null || X) return; so its cleaner and doesnt throw an error in some weird state where they are null

waiting for any feedback from @GeorgeRNG


Version bump: v17.2.0

Changes in this PR:
Release search highlighting functionality!

 SEARCH: Highlight term within a judgment


#trace directive not working

Hi, it seems like the #trace directive hasn't been implemented in the kernel. Running #trace f yields an unknown directive exception. The directive works perfectly fine on the default OCaml toplevel.

I got the same error, and it appears on my Ocaml 4.13.1 version kernel, but not in my Ocaml 4.08.1 version kernel.

Of course

#182 solves the problem.


Log

Hello, thank you for this great work. I am customizing this repo with my own dataset and I am wondering if you can provide the log file for the training. Thanks you ahead!

Hi! Thank you for the message!
Unfortunately, I don't have access to the log anymore as I left my lab.
Sorry about that!


Diffusion bundle support monai service

Add validate in train_autoencoder.json
Use brats18 as data
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:

[x] Codeformat tests passed locally by running ./runtests.sh --codeformat.
[ ] In-line docstrings updated.
[ ] Update version and changelog in metadata.json if changing an existing bundle.
[ ] Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
[ ] Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
[ ] Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
[ ] Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
[ ] Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

Hi @Can-Zhao , could you update the version and change log for the bundle? https://github.com/Project-MONAI/model-zoo/actions/runs/7217242764/job/19664741489?pr=541#step:7:631


[Feature Request]: Adding an Alert whenever Copy Button is clicked

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Adding an Alert whenever Copy Button is clicked
This feature enhancement involves triggering an alert or notification whenever the "Copy" button is clicked. Upon activation, users receive a confirmation message, improving UX by ensuring that the intended action (copying text) was successfully executed. This helps users confirm that their content was copied to the clipboard without having to manually verify it, making the interface more intuitive and responsive. The alert could be implemented through JavaScript's alert() method or by displaying a custom notification UI.

Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

go ahead, keep the alert in line with the website styling.

Hey I want to Contribute in this Can you please assign it to me.

I want to work on that,  please will you assign it to me.

@JayShukla8 assign this issue under hacktoberfest2024.

@AnkitLuhar in the issues its showing the labels but in the PR its not showing i dont know why.

@AnkitLuhar i have two branches in my forked repo and i have implemented in the 2nd branch and i raised PR by contribute option and its not showing the labels, what should I do?

@harshit69x push code into the main branch,after that your PR NO. will be shown in this issue and both your issue and PR will be connected to each other.

Okay so first i push the 2nd branch into the main branch of my repo then from there i raise PR for the issue?

@harshit69x here is sample of output you get after succesfully opening the PR,

@AnkitLuhar thanks alot:)

@harshit69x welcome brother, OPEN Your PR Successful..

Hello Sir,  I want to Contribute in this Can you please assign it to me.

issue resolved. Button turns to tick when copied.


v2.3.0-rc8 storageclass/persistentvolume some items are dissapeared in webUI

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Just want to create storage class for openstack cinder volume then I found there was no option.
But I can create it by API
Result:

@freeloop914  - To view all the drivers including the unsupported ones, you have to set the unsupported-storage-drivers setting to true.  To do this go to ...v3/features/unsupported-storage-drivers and edit, change the value to true.  Then you will see openstack and all the other drivers again.


Support for specifying S3 partition size and HDFS block size and readable error messages for assertion failures.

Resolves Issue #1 by giving users the ability to specify the size of S3 partitions and HDFS blocks. The parameters are "--s3-part-size" and "--hdfs-block-size". Default values for both are 64 Mb. Part size must be a multiple of block size.
Also resolves Issue #2 by adding human-readable error messages for assertion failures.

This last commit to the PR should resolve your comments.

Looks great. Could you rebase your branch to the latest master? I made a minor change to the README a while ago that conflicts with your change to the README. This might look pedantic since I could easily resolve that single conflict myself in less time it takes to write this comment but bear with me. This way you get to learn how to rebase a branch for a PR.


error compiling

hi when i try to build the project it gives me this error
Severity	Code	Description	Project	File	Line	Suppression State
Error		The "RGiesecke.DllExport.MSBuild.DllExportAppDomainIsolatedTask" task could not be loaded from the assembly C:\Users\AlienGamer\Desktop\CPLResourceRunner-master\CPLResourceRunner\packages\UnmanagedExports.1.2.7\tools\RGiesecke.DllExport.MSBuild.dll. Could not load file or assembly 'Microsoft.Build.Utilities, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.	CPLResourceRunner

same issue

got build fix. had to remap path

Remap which path? I couldn't reproduce the error.

re add a reference in visual studio i think is what i did


E_UNSUPPORTED: Unsupported {"feature": "year pattern u"}

I'm receiving the following error when I try to format a date
<FormattedDate
            value={new Date()}
            skeleton="dMy"
            />

skeleton="yMd" works fine

Skeletons need to be specified in largest to smallest order so skeleton="yMd" would be the correct skeleton in this case. The date formatting is then carried out based on norms for that particular language/locale, NOT based on the order of your skeleton.
You can see examples of some formatting options in the documentation for the Globalize library: https://github.com/jquery/globalize/blob/master/doc/api/date/date-formatter.md

thanks for the explanation
yMD -> 11/30/2010
what if I want to display year using only 2 digits instead of 4?
is that possible?

Based on the CLDR documentation, skeleton="yyMd" should work. However, not all skeletons work as expected: https://github.com/jquery/globalize/issues/271
If not, this will work: <FormattedDate value={new Date()} date="short" />. The "presets" on the date formatter page all work just fine.

thanks I'll try that

thanks I'll try that

thanks I'll try that

thanks I'll try that


How to use X11 from remote-connected vscode?

The following works:
a) remote workspace
b) opening [remote] terminal
c) starting DISPLAY=localip:1234 xterm -ls from the terminal
Does not work:
1: do b and c with a command defined in the code workspace - I always get

/usr/bin/xterm: Xt error: Can't open display: localip:1234

2: "automatically" setup DISPLAY variable and local port forwarding (it seems that this is the case with the MS remote ssh extension , maybe depending on ssh config file
3: using manual port forwarding with the "Ports" view  (did with both 1234 and 7234 (x11 base port 6000 + display number), then used DISPLAY=1234 xterm -ls/DISPLAY=:1234 xterm -ls/DISPLAY=localhost:1234 xterm -ls, both on the [remote] terminal and via vscode commands)
How should this work?

friendly ping

I don't see nothing on the code that implies X11 support (also looking on how to do this). It might be possible given that the ssh2 library used to connect provides X11 forwarding support, but support for it needs to be added to open-remote-ssh.


Pending fixes for cl2k (Cl2000, c2000)

We discussed these before. This is for documentation, rather than integration......

If memory serves me, sizeof(char) == 1, sizeof(short) = 1, sizeof(long) == 2 etc. In other words, sizeof() returns multiples of the smallest unit, which is a 16 bit word. I really can't think of any other way of dealing with this than the crazy macro above.

And, I'd like to support platforms such as these. They keep the code more portable and thus will make porting to other platforms easier.
Exactly because of this kind of problems :)

If we want to do this for the sake of portability, then in my book, getting rid of the magical number "8" is the way to go :)

GCC has CHAR_BIT which "you should not use directly".

The cl2000 has CHAR_BIT. Gcc does, too, in '<limits.h`. So next week, I'll change the code to use CHAR_BIT.

Why CHAR_BIT ?

You ask me?  We can, of course, define our own CPPU_TEST_... , based on the above.

#if sizeof(char) == 8 ?

Doesn't sizeof(char) always return 1?  Also, I think sizeof is a compiler operation, so preprocessor logic based on it wouldn't work I think.

@Andne  is right. That's why I propose to use CHAR_BIT, because it is defined to 8 normally and to 16 for the TMS320 & friends.
(@basvodde sorry I got you wrong, I thought you were asking why it is called CHAR_BIT)

Ok, but please avoid using features that are said not to be used :)

I suggest I make a new pull request from the part we can (hopefully!) agree on, and keep the function pointer stuff in this one for now.
Also, because running all test on the simulator takes forever, that will probably only happen on Wednesday....

Oops. The function pointer stuff somehow fell out of this one. So I'll do it the other way round :P

Excellent. Can I merge it?

Yes, you can merge this one. Unfortunately, there is still the other one before all will compile again ;-)


Feature/improve readme

Minor updates because I got an email from someone who needed more detailed installation instructions.

Refresh my memory - why did you remove the strict mode reference?

I believe the bug affected us even when using an angular with strict mode removed; therefore it was more likely JIT / Object.create related than it was strict mode.

Yea, my memory was a little hazy too, but that's generally what I recollected.


Use builder pattern

Trying to read your example code without comments or the documentation handy in a browser window is a pretty puzzling experience. Lots of numeric values without a hint as to what that value might be. Many developers who do not comment their code all that well will leave an unreadable mess when using Fido.
For instance, give this to someone who might have heard about the basics of machine learning but can't remember all the details (let alone the order of parameters in the Fido API):
net::NeuralNet neuralNetwork = net::NeuralNet(1, 1, 2, 4, "sigmoid");
net::Backpropagation backprop = net::Backpropagation(0.1, 0.001, 0.001, 10000);

Nobody knows what this means without looking up the docs. Now imagine if the code looked like this:
net::NeuralNet neuralNetwork = net::NeuralNet::Builder()
    .numInputs(1).numOutputs(1)
    .numHiddenLayers(2).numNeuronsPerHiddenLayer(4)
    .activationFunction("sigmoid")
    .build();

net::Backpropagation backprop = net::Backpropagation::Builder()
    .learningRate(.0.1)
    .momentumTerm(0.001)
    .acceptableErrorLevel(0.001)
    .maxTrainingIterations(10000))
    .build();

Not only does the coder get autocompletion and can initialize the object without double-checking the docs, but the reader now also has a clue what's going on. It's not even much longer than the current version with comment, but now everyone will write readable code and not just those that take the time to write a helpful comment.
This is called the builder pattern, Wikipedia has an article on it too. I think it would make a great match for many of the classes in your API.

Thank you for the feedback!

I do agree that the initializers do need to be more self documenting, but is the builder design pattern common in C++. I have mostly seen it used with Java.

Qt uses it in a number of places. The GoF Design Patterns book and Wikipedia both include if, and provide a C++ implementation. It was definitely meant for C++ as well, although the Java community took the whole design patterns thing to a bit closer to heart.
It might not be the most common one, but it's fairly easy to grasp and not overly hard to implement. It's a solution to a well-defined provlem, and as far as I'm aware there's not much competition to that in C++ land.
The most common alternative, I guess, would be to make everything a setter of an already-initialized object, rather than building a valid object before initialization. This has other trade-offs (i.e. necessity to check object validity before performing an action) and is best suited for a slightly different use case.
I would also say that because it's easy enough to come up with almost-good-enough alternatives, the builder pattern hasn't seen as much popularity as it deserves. In my opinion, that's not a reason to avoid using it :)

@jpetso. Yes, but if we went with the "making everything a setter design scheme," I believe that all current models would be valid with preset constants, which removes the need to check object validity.

If that's not a problem then regular setters might work just fine. The main thing that a builder does for you is force the user to supply all the necessary values so they can be passed to the (private) constructor at once.

I like the builder pattern because, especially for me, being new to machine learning, it makes it easier to understand the class and its members.

While initially I found the builder pattern (or a similiar design scheme) verbose, it's grown on me and I recognize it's practicality.  I especially would agree with @FlyingGraysons that making the switch would certainly make the library more accessible to beginners.

@joshuagruenstein @FlyingGraysons. A getter and setter design scheme would look like this:
net::NeuralNet neuralNetwork;
neuralNetwork.setNumInputs(1);
neuralNetwork.setNumOutputs(1);
neuralNetwork.setNumHiddenLayers(2);
neuralNetwork.setNumNeuronsPerHiddenLayer(4);
neuralNetwork.setActivationFunction("sigmoid");

Or we could have each setter return the object, allowing for one liners.

I actually think the builder pattern is clearer and less verbose than a setter system, but that's just me. I also dislike how you could create a neural network without specifying the number of inputs and outputs, that just seems wrong to me.


Adding descriptions for params

Related Issue: https://github.com/MicrosoftDocs/office-docs-powershell/issues/5537
Source: https://docs.microsoft.com/en-us/sharepoint/dev/declarative-customization/site-theming/sharepoint-site-theming-csom

Docs Build status updates of commit 2a65327:
:clock10: Full build: the average full build time is 17 min(s) 10 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 2a65327:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Add-SPOTheme.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ffb6cc8:
:clock10: Full build: the average full build time is 17 min(s) 10 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ffb6cc8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Add-SPOTheme.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


New component, FuroUi5Combobox

Support of the ui5-combobox with FURO bindings.

This issue has been moved to https://github.com/theNorstroem/furo-ui5/issues/3


Add query user functions note

In some cases, users may want to know the created udf. It can help them.

Hi @aseaday ,
The CN document is translated from the EN version. Could you please add the EN content to: https://github.com/databendlabs/databend-docs/blob/main/docs/en/guides/54-query/03-udf.md
Once the PR is merged, the CI will automatically update the CN version.
Thank you!

LGTM


To do app

To Do App From scratch
functionality

[ ] you can add your daily task
[ ] you can remove your daily task
[ ] you can mark completed
[ ] it will be store in your local storage

future functionality

[ ] clear all completed task

happy coding mate

thanks for the review buddy
😁�

�


[protobuf] update to 3.21.9

Fix #27493
Update protobuf to the latest version 3.21.9
Feature zlib tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Would you please merge it into master?

@JonLiu1993 Thank you. Unfortunately it won't be merged.

I don't wish to urge, but is there any chance of fixing this pr? Thanks!

Duplicate of #28710


Better version that reads the object properties and makes into a table with headers:

          Better version that reads the object properties and makes into a table with headers:

Option Explicit

Public Sub IterateOverACollection()

    Dim jsonString As String
    jsonString = "[{""row"":1, ""a"":""0007"", ""b"":""Blue"", ""c"":""2008""}, {""row"":2, ""a"":null, ""b"":"""", ""c"":""1709""}]"

    Dim myCollection As Collection
    Set myCollection = ParseJson(jsonString)

    Dim myDictionary As Dictionary
    Dim i As Long, j As Long

    Dim StartCell As Range
    Set StartCell = ActiveSheet.Range("A1")

    Set myDictionary = myCollection(1)
    For j = 1 To myDictionary.Count
        StartCell.Offset(0, j - 1) = myDictionary.Keys(j - 1)
        StartCell.Offset(0, j - 1).Font.Bold = True
    Next j

    For i = 1 To myCollection.Count
        Set myDictionary = myCollection(i)
        For j = 1 To myDictionary.Count
           StartCell.Offset(i, j - 1) = myDictionary.Items(j - 1)
        Next j
    Next i

End Sub

Originally posted by @zgrose in https://github.com/VBA-tools/VBA-Web/issues/329#issuecomment-375824464

Hi, I have tried the routine with this Json but I get error in "line":5 I think it is because of the array "failure_reason":{"type": "validation", "fields":["email"]},
could you help me on this?
thank you very much in advance
{"line":5, "email": "institutcastelldelquer @gmail. com", "sms_phone":null, "result": "failure", "failure_reason":{"type": "validation", "fields":["email"]} the full json is this[{"line":1, "email":"", "sms_phone":null, "result": "failure", "failure_reason": "header", "created_at": "2024-02-13T11:01:19:000Z"},
Json complete
[{"line":1,"email":"","sms_phone":null,"result":"failure","failure_reason":"header","created_at":"2024-02-13T11:01:19.000Z"},{"line":2,"email":"insvoltrera@xtec.cat","sms_phone":"","result":"success","failure_reason":null,"created_at":"2024-02-13T11:01:19.000Z"},{"line":3,"email":"amateo@presentarenys.net","sms_phone":"","result":"success","failure_reason":null,"created_at":"2024-02-13T11:01:19.000Z"},{"line":4,"email":"a8034187@xtec.cat","sms_phone":"","result":"success","failure_reason":null,"created_at":"2024-02-13T11:01:19.000Z"},{"line":5,"email":"institutcastelldelquer @gmail.com","sms_phone":null,"result":"failure","failure_reason":{"type":"validation","fields":["email"]},"created_at":"2024-02-13T11:01:23.000Z"},{"line":6,"email":"a8030224@xtec.cat","sms_phone":"","result":"success","failure_reason":null,"created_at":"2024-02-13T11:01:26.000Z"},{"line":7,"email":"veronica.cardenas@pereviver.cat","sms_phone":"","result":"success","failure_reason":null,"created_at":"2024-02-13T11:01:26.000Z"}]


ZeroDivisionError

tried using the solution one has already posted here, nothing fixed it. anyone help?
python train.py --dataset C:\Users\blank\Desktop\vocal-remover-v4.0.0\Training --reduction_rate 5 --mixup_rate 5 --gpu 0
0it [00:00, ?it/s]
0it [00:00, ?it/s]
0it [00:00, ?it/s]
# epoch 0
  * inner epoch 0
Traceback (most recent call last):
  File "train.py", line 224, in <module>
    main()
  File "train.py", line 195, in main
    train_loss = train_inner_epoch(
  File "train.py", line 48, in train_inner_epoch
    return sum_loss / len(X)
ZeroDivisionError: division by zero

Is the dataset correctly placed and are there at least a few tens of pairs?
In addition, --reduction_rate and --mixup_rate should be more than 0 and less than 1.


Rename metric detail files

Some metrics had confusing names. For example, the metric lines-of-code-changed was defined in a file called pull-requests-lines-of-code-changed.md, despite the fact the number lines of code changed is not directly related to pull requests. I have updated these metrics to be reflect such inconsistencies.
In addition, other files were slightly renamed duplicates - in the interest of keeping things tidy, I went ahead and deleted the duplicates.
I also tried to standardize the format of metric names as well as make them easier to understand without reading the detail file.

This is some house keeping. Everything code related had a "pull requests" preface, which made no sense in a number of cases. Also got rid of some metrics that obviously duplicated each other.

I have nothing against the changes, but I don't understand its rationale. Some of the files I don't find them in the goals files. For example, I cannot find pull-requests-review.md in the Code Development goal. Maybe I'm missing something?

I saw some of those too, but I wasn't sure if they were a metrics that still needed a home, or if someone else was perhaps working on them, so I elected to leave them alone and tried to mostly clean up cruft and rename metrics that I thought could benefit from a renaming. Sorry for the confusion @jgbarah! Please let me know if there's anything else!


Edit page for table row

Allow users to edit a row via a traditional web form. Only project_editor and above can access.

Think this is done, but check the access controls


Re-set cross attention forward parameter for T5

It looks like this parameter may have been lost around https://github.com/THUDM/SwissArmyTransformer/commit/d5f676c92e76877251bb9078dc6a510e6b95d526#diff-d58d208b2028dd40c3372abcc9b104b11fc81284fc8489e495b31404d967475cL233-L236 , but it is still used in a couple models: https://github.com/THUDM/SwissArmyTransformer/blob/main/SwissArmyTransformer/model/official/t5_model.py#L116-L119

thank you for your debugging! we are recently re-activating this project!


Edge TPU devices not seen

Description
I'm running the multithreaded example on my Ubuntu x86_64 system, however it's not seeing the 8 TPUs that are present on the PCIe card in the system. I can do a lspci and see them as below. However, the code that enumerates them does not see them through either method below. The card is (https://github.com/kkohtaka/edgetpu-device-plugin). Is there some persmissions or something that's preventing it from being seen? Thanks!

$ lspci|grep -i tpu
b1:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
b3:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
b5:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
b7:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
b9:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
bb:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
bd:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU
bf:00.0 System peripheral: Global Unichip Corp. Coral Edge TPU

const auto& available_tpus =
edgetpu::EdgeTpuManager::GetSingleton()->EnumerateEdgeTpu();
printf("num TPUs found %d\n",available_tpus.size());
// Find TPU device.
size_t num_devices;
std::unique_ptr<edgetpu_device, decltype(&edgetpu_free_devices)> devices(
edgetpu_list_devices(&num_devices), &edgetpu_free_devices);
if (num_devices == 0) {
std::cerr << "No connected TPU found" << std::endl;
return 1;
}

Click to expand!
Issue Type
Support
Operating System
Ubuntu
Coral Device
Accelerator Module
Other Devices
No response
Programming Language
C++
Relevant Log Output
No response

Please let us know which version of ubuntu are you trying to use and do the examples working fine without the card?

It is Ubuntu 22.04 LTS (GNU/Linux 5.15.0-52-generic x86_64)
The example two_models_two_tpus_threaded does not see the TPUs either.

Is it a native operating system or is it on the virtual box? Also please let me know the python version if its installed on Ubuntu 22.04.

It is native, not virtual.
Python is  3.10.6 (main, Nov  2 2022, 18:53:38) [GCC 11.3.0] on linux

Please install the pycoral and tflite runtime with the below command and try the demo at: https://coral.ai/docs/accelerator/get-started/#3-run-a-model-on-the-edge-tpu
pip install https://github.com/hjonnala/snippets/raw/main/wheels/python3.10/tflite_runtime-2.5.0.post1-cp310-cp310-linux_x86_64.whl
pip install https://github.com/hjonnala/snippets/raw/main/wheels/python3.10/pycoral-2.0.0-cp310-cp310-linux_x86_64.whl

After running this I see the edge tpu library does not appear to be there

$ python3 examples/classify_image.py
--model test_data/mobilenet_v2_1.0_224_inat_bird_quant_edgetpu.tflite
--labels test_data/inat_bird_labels.txt
--input test_data/parrot.jpg
Traceback (most recent call last):
File "/home/gsosnow/coral/pycoral/examples/classify_image.py", line 40, in
from pycoral.utils.edgetpu import make_interpreter
File "/home/gsosnow/.local/lib/python3.10/site-packages/pycoral/utils/edgetpu.py", line 24, in
from pycoral.pybind._pywrap_coral import GetRuntimeVersion as get_runtime_version
ImportError: libedgetpu.so.1: cannot open shared object file: No such file or directory

Please install the runtime with the instructions at: https://coral.ai/docs/accelerator/get-started/#1-install-the-edge-tpu-runtime

I have installed and tried to run again but getting the below error:

$ python3 examples/classify_image.py --model test_data/mobilenet_v2_1.0_224_inat_bird_quant_edgetpu.tflite --labels test_data/inat_bird_labels.txt --input test_data/parrot.jpg
Traceback (most recent call last):
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 160, in load_delegate
delegate = Delegate(library, options)
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 119, in init
raise ValueError(capture.message)
ValueError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/gsosnow/coral/pycoral/examples/classify_image.py", line 121, in
main()
File "/home/gsosnow/coral/pycoral/examples/classify_image.py", line 71, in main
interpreter = make_interpreter(*args.model.split('@'))
File "/home/gsosnow/.local/lib/python3.10/site-packages/pycoral/utils/edgetpu.py", line 87, in make_interpreter
delegates = [load_edgetpu_delegate({'device': device} if device else {})]
File "/home/gsosnow/.local/lib/python3.10/site-packages/pycoral/utils/edgetpu.py", line 52, in load_edgetpu_delegate
return tflite.load_delegate(_EDGETPU_SHARED_LIB, options or {})
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 162, in load_delegate
raise ValueError('Failed to load delegate from {}\n{}'.format(
ValueError: Failed to load delegate from libedgetpu.so.1

please try the demo with the  below lines here and share the logs..
from pycoral.pybind._pywrap_coral import SetVerbosity as set_verbosity
set_verbosity(10)

Here is the output after adding the 2 lines:

$ python3 examples/classify_image.py --model test_data/mobilenet_v2_1.0_224_inat_bird_quant_edgetpu.tflite --labels test_data/inat_bird_labels.txt --input test_data/parrot.jpg
I tflite/edgetpu_manager_direct.cc:453] No matching device is already opened for shared ownership.

I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (USB) is available.
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (Reference) is available.
I tflite/edgetpu_manager_direct.cc:502] Failed allocating Edge TPU device for shared ownership.
Traceback (most recent call last):
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 160, in load_delegate
delegate = Delegate(library, options)
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 119, in init
raise ValueError(capture.message)
ValueError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/gsosnow/coral/pycoral/examples/classify_image.py", line 122, in
main()
File "/home/gsosnow/coral/pycoral/examples/classify_image.py", line 72, in main
interpreter = make_interpreter(*args.model.split('@'))
File "/home/gsosnow/.local/lib/python3.10/site-packages/pycoral/utils/edgetpu.py", line 87, in make_interpreter
delegates = [load_edgetpu_delegate({'device': device} if device else {})]
File "/home/gsosnow/.local/lib/python3.10/site-packages/pycoral/utils/edgetpu.py", line 52, in load_edgetpu_delegate
return tflite.load_delegate(_EDGETPU_SHARED_LIB, options or {})
File "/home/gsosnow/.local/lib/python3.10/site-packages/tflite_runtime/interpreter.py", line 162, in load_delegate
raise ValueError('Failed to load delegate from {}\n{}'.format(
ValueError: Failed to load delegate from libedgetpu.so.1

I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (PCIe) is available.
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (USB) is available.
I tflite/edgetpu_manager_direct.cc:471] No device of type Apex (Reference) is available.

Wondering if you have any USB accelerator device with you. Please try installing the pcie drivers  and save the installation logs for reference.

Thank you!! After installing the pcie drivers, it works!! The C++ example two_models_two_tpus_threaded is able to see the tpus now.


[RESTEASY-2254]

Should you backmerge your fix to the rx provider to 3.8?

This is just @patriot1burke's PR for 3.8, right?

Should you backmerge your fix to the rx provider to 3.8?

I don't think so, that the CompletionStage rx invoker is different on 3.8.

This is just @patriot1burke's PR for 3.8, right?

Yep, basically, it keeps master and 3.8 aligned

Not much to say here :) TCK tests (1.2.1) passed, no regression found in the CI jobs.
@patriot1burke thanks for the update
There is https://github.com/eclipse/microprofile-rest-client/releases/tag/1.3.1 release.
What are plans around it ?
First in https://github.com/smallrye/smallrye-rest-client/ and later backport to RESTEasy ?

AFAIK the work for upgrading to 1.3 is in progress. See https://github.com/resteasy/Resteasy/pull/2047 for example.


[BUG] get_features does not apply to SQLFeatureDerivedFunctions

Willingness to contribute
No. I cannot contribute a bug fix at this time.
Feathr version
0.9
System information

OS Platform and Distribution (e.g., Linux Ubuntu 20.0):
Python version:
Spark version, if reporting runtime issue:

Describe the problem

Tracking information
No response
Code to reproduce bug
No response
What component(s) does this bug affect?

[ ] Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
[ ] Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
[ ] Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
[ ] Feature Registry Web UI: The Web UI for feature registry. Written in React

I had the same issue and it got resolved by going to the .yaml config file and commenting out the following line since it points to an outdated .jar package:
feathr_runtime_location<EMAIL_ADDRESS>Thanks to @Yuqing-cat for resolving the issue.


file created too early in TTFont.save()

If an exception occurs during compilation, an empty file remains. This isn't so bad per se, but when overwriting the original file this destroys the original, which is rather nasty. It can probably be fixed by moving the file creation block to after the SFNTWriter is done.

Or maybe create the output in a tmp file and only rename it if compilation was successful, and remove it otherwise.
In general the case of output and input filenames being equal is dangerous, so I wouldn't mind if we disallow that.


Analyzer settings are not (yet) wired up at the moment.

It is not yet possible to set up the analyzer. The configuration settings do offer a possibility for this, but it has not yet been implemented.

@mcl-sz do you mean examine configuration for index?

@bielu, yes, that's what I mean indeed. The IndexConfiguration has an Analyzer option but it is not set anywhere (it's always null). I tried to link this to ElasticSearchBaseIndex but it's difficult to do this in a nice way because it's not actually part of IndexState.

@mcl-sz I will have a look into it, as we might need inject it into state service

Similarly to other ticket changes are on same branch.
btw I didnt use Examine cofiguration I used analyzer field from Bielu Examine provider, let me know if that works for you!

@bielu I made a small adjustment and added it to the same pull request as TransformingIndexValues.

Hey @mcl-sz I am starting having little more time now again,
Wanted to check if you encounter any other issues on this as will be preparing to release another beta!

Hi @bielu ,
Apologies for my late response! I will be doing extensive testing again in the coming days.
One of the things I've run into is that child nodes are not removed from the index when the parent node is removed. Apologies for my late response! I will be doing extensive testing again in the coming days. I'll just create a new issue for this.

@mcl-sz I guess we can close this ticket now, if not ping me and will reopen it


[WIP] Add basic support for CSS Module IntelliSense

Changes
This PR adds basic intellisense for CSS modules. I'm not super satisfied with how the CSS classes are extracted, PostCSS isn't necessarily heavy but it's still a big process. Volar uses a regex to do this, but it doesn't seems to work perfectly either, so not sure if there's a perfect lightweight solution or not

Testing
WIP
Docs
N/A

Hey,
Here some randoms observations on CSS modules support in Astro extension.
With clinyong.vscode-css-modules we can get CSS peeking:

In their demo  below, we can see very briefly an hint overlay with the class,
strange that we only have the CSS peek now (see above), no overlays anymore, this demo must be outdated:

I suppose VS Code support hint / peeking works in a different way.
If I had to choose between the two (like the CSS Modules shows), I think the CSS peeking is the most UX friendly, while it would be very neat to have both 😄
Anyway, regardless of Astro idiomatic CSS or CSS Modules choice, I think the click / peek to class is the most looked after feature, DX-wise, but I might be wrong.
Thx again for your work 👍.

Hey @JulianCataldo
Not sure why it doesn't work in their case, but go to definition and peak definition uses the same information.
You (normally) can't support only one of those. The implementation in this PR supports this (though the mapping are currently a bit wonky)
As for hover information, this PR currently does not have it, however it'd be possible to support fairly easily, I think

Closing since this will need to be implemented differently after https://github.com/withastro/language-tools/pull/502 (hopefully easier!)


sast: initial task for Coverity Buildless

Initial version of the Coverity Buildless task. The code will be scanned using coverity buildless mode, then the results are processuing using csgrep and the results are later filtered using csfilter-kfp.
This is a draft request and this can not be merged in this repository. It will be merged in a newly created repository.
Things pending to do:

[x] Move this MR to a new and private repo - Not needed anymore
[x] Remove installation of csdiff package once the container image is updated
[x] Speak on how to store license in a secure place
[x] Show results on UI
[x] Enhanced Readme with private information - Not needed anymore

Apart from that, the MR can be reviewed as the funcionality will remain the same

Results are parsed and shown in the UI:

Thanks for the thorough review @kdudka !

Solved all comments and added new changes. I will also apply the changes (the record excluded and update the upload task) to the snyk code task

Hey! @kdudka I just did a new MR with all the discussed changes:

2 different tasks. If the coverity-availability-check finishes successfully, the coverity scan is executed. If not, it will be skipped.
Added standarized parameters.
Example pipeline: https://konflux.apps.stone-prod-p02.hjvn.p1.openshiftapps.com/application-pipeline/workspaces/jperezde/applications/test-coverity/pipelineruns/osh-cli-container-konflux-test-2-on-pull-request-v6tcv

I did the changes and I am testing now. The tasks are not being scheduled as I guess no powerful machines are available now

Could you generate the result like this to follow the style in integration-service-api-contracts?
make_result_json is defined here
Thanks!

@hongweiliu17 Hey! Following this comment: https://github.com/konflux-ci/build-definitions/pull/1411#issuecomment-2413253701 , I updated the result in the sast-coverity-check task. This task is only executed if the coverity-availability-check task has a success as results.TEST_OUTPUT. If we format it using the make_result_json file, would it be possible to achieve the same workflow?

/verify-owners

/ok-to-test

@hongweiliu17 @14rcole Could you please check what failed at https://github.com/konflux-ci/build-definitions/pull/1411/checks?check_run_id=32513757072?  I do not have permissions to access the logs myself.

@hongweiliu17 @14rcole Could you please check what failed at https://github.com/konflux-ci/build-definitions/pull/1411/checks?check_run_id=32513757072? I do not have permissions to access the logs myself.

I can see error message on https://console.redhat.com/application-pipeline/ns/konflux-ci/pipelinerun/build-definitions-pull-request-hvsz9/logs/ec-task-checks, it looks I need permission too.
Unable to load pipeline run build-definitions-pull-request-hvsz9
Invalid token. Are you working with Prod SSO token?

/ok-to-test

@kdudka I just rebased the branch. Would you mind retesting?

/ok-to-test

It seems that ec-task-checks failed again with:

result: RPMS_DATA
task: rpms-signature-scan
success: false

I am not able to access the task log myself: https://console.redhat.com/application-pipeline/ns/konflux-ci/pipelinerun/build-definitions-pull-request-6xts4/logs/ec-task-checks

@tnevrlka Thanks for the resteting. This PR should be failing by something out of our control as we are not allow to see those tasks/logs. Would you mind adding some guidance so we can fix this?

@14rcole @ralphbean The MR has been updated and it already contains needed changes. With the two tasks coverity-availability-check and sast-coverity-check users should be able to scan the code using the documentation that I already created.
The previous code was already approved but I added changes to the template-build.yaml file that should be reviewed as that would affect all future automatically generated pipelines.
Regarding the failed MR, after applying the script, no file is generated/updated so not really sure how to act there:
/usr/bin/python3 /Users/jperezde/Documents/Red_Hat/Dev/Repos/mine/build-definitions/hack/generate-pipelines-readme.py
Subprocess: oc kustomize --output /var/folders/5j/42ytb9_91f3350drn6_blcfw0000gn/T/tmp_hk7cz7h ./pipelines/
oc failed:
STDOUT:

STDERR:
error: accumulating resources: accumulation err='accumulating resources from 'docker-build-oci-ta': '/Users/jperezde/Documents/Red_Hat/Dev/Repos/mine/build-definitions/pipelines/docker-build-oci-ta' must resolve to a file': recursed accumulation of path '/Users/jperezde/Documents/Red_Hat/Dev/Repos/mine/build-definitions/pipelines/docker-build-oci-ta': remove operation does not apply: doc is missing path: "/spec/tasks/12/workspaces/0": missing value

Apart from that, no other work from our side is needed
cc/ @kdudka

@jperezdealgaba The script behaves unexpectedly.  I am able to reproduce the failure locally.  If I move the addition of sast-coverity-check and coverity-availability-check after clamav-scan, the failure goes away and the README.md files are updated.

@kdudka That was... an unexpected fix. Thank you very much! The problem has been resolved!

@14rcole @ralphbean Any update on this please?

@tnevrlka Hey Tomas! Would you mind triggering the pipelines? I modified the pipelines to avoid facing the same problems we had on https://github.com/konflux-ci/build-definitions/pull/1661

/ok-to-test

@tnevrlka Would you mind retriggering the tests? This was just merged: https://github.com/release-engineering/rhtap-ec-policy/pull/85#event-15511726609

/ok-to-test

/ok-to-test

/retest

/retest

The Run Task Tests check was introduced yesterday by merging https://github.com/konflux-ci/build-definitions/pull/1644 and is currently failing due to missing tests.
The README says When updating tasks, if the tasks doesn't have tests, try to add a few tests. Currently it is not mandatory, but is recommended. Would you be okay with merging this @tisutisu?

The Run Task Tests check was introduced yesterday by merging #1644 and is currently failing due to missing tests.
The README says When updating tasks, if the tasks doesn't have tests, try to add a few tests. Currently it is not mandatory, but is recommended. Would you be okay with merging this @tisutisu?

I think we also need a fix tor the Task Tests workflow then, tests should really be optional at the moment

The Run Task Tests check was introduced yesterday by merging #1644 and is currently failing due to missing tests.
The README says When updating tasks, if the tasks doesn't have tests, try to add a few tests. Currently it is not mandatory, but is recommended. Would you be okay with merging this @tisutisu?

I think we also need a fix tor the Task Tests workflow then, tests should really be optional at the moment

I have skipped task tests workflow with this PR till it is fixed.

Hey! Although I appreaciate your comments (and agree with you about skipping the tests). @tisutisu @chmeliik Could this be merged?
Thank you!

/ok-to-test


Experiment with ESRI

Look into Esri as well as ArcGIS to understand the platform more thoroughly.

Platform well learned by the team.


s3.amazonaws.com erroneously recognised as a domain suffix

I want to enable certificate pinning against multiple Amazon S3 buckets, I've configured TrustKit in the AppDelegate, sample Xcode project attached: TrustKitWithAmazonS3.zip
On launching the app an exception is raised: Terminating app due to uncaught exception 'TrustKit configuration invalid', reason: 'TrustKit was initialized with includeSubdomains for a domain suffix s3.amazonaws.com'
Why is it considered a domain suffix (if it's not a bug), and what is the correct way to configure certificate pinning for subdomains of s3.amazonaws.com?
What I've tried so far:

setting the pinned domain to s3.amazonaws.com: raises exception
setting the pinned domain to *.s3.amazonaws.com: doesn't raise exception but certificate pinning fails on subdomains
setting the public key hash from the server certificate with CN=s3.amazonaws.com: no effect
setting the public key hash from the server certificate with CN=*.s3.amazonaws.com: no effect

Certificates obtained using openssl s_client -showcerts -connect s3.amazonaws.com:443
Output from the get_pin_from_certificate.py script to obtain the Public Key Hashes:
$ ./get_pin_from_certificate.py s3-amazonaws.pem

CERTIFICATE INFO
----------------
subject= /C=US/ST=Washington/L=Seattle/O=Amazon.com Inc./CN=s3.amazonaws.com
issuer= /C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert Baltimore CA-2 G2
SHA1 Fingerprint=65:B0:62:58:C9:E6:5C:07:A5:6A:39:DB:88:7A:EA:0F:3F:14:42:75

TRUSTKIT CONFIGURATION
----------------------
kTSKPublicKeyHashes: @[@"tfR4WIM3cjezQdf3yh/px0abP/kN6KbYruem43CT1t8="] // You will also need to configure a backup pin
kTSKPublicKeyAlgorithms: @[@"TSKAlgorithmRsa2048"]

$ ./get_pin_from_certificate.py star-s3-amazonaws.pem

CERTIFICATE INFO
----------------
subject= /C=US/ST=Washington/L=Seattle/O=Amazon.com Inc./CN=*.s3.amazonaws.com
issuer= /C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert Baltimore CA-2 G2
SHA1 Fingerprint=3B:E4:04:74:1F:F3:01:E3:03:0D:B7:7F:C7:79:60:84:16:D6:56:B9

TRUSTKIT CONFIGURATION
----------------------
kTSKPublicKeyHashes: @[@"tzsid6cLOVtz0NnqTUDQU/CmN/bSC5vUQRUj6p7JBF0="] // You will also need to configure a backup pin
kTSKPublicKeyAlgorithms: @[@"TSKAlgorithmRsa2048"]

$ ./get_pin_from_certificate.py s3-amazonaws_intermediate_ca.pem

CERTIFICATE INFO
----------------
subject= /C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert Baltimore CA-2 G2
issuer= /C=IE/O=Baltimore/OU=CyberTrust/CN=Baltimore CyberTrust Root
SHA1 Fingerprint=A9:D5:30:02:E9:7E:00:E0:43:24:4F:3D:17:0D:6F:4C:41:41:04:FD

TRUSTKIT CONFIGURATION
----------------------
kTSKPublicKeyHashes: @[@"56higu/MFWb/c2b0avLE5oN2ECS2C43RvzSUgx/2xIE="] // You will also need to configure a backup pin
kTSKPublicKeyAlgorithms: @[@"TSKAlgorithmRsa2048"]

Hello,
First of all you should not pin an Amazon domain, unless you work at Amazon. Pinning a domain you do not own means that the certificate/key could change at any time and there is no way for you to manage that in your App, meaning your App will break. You should only pin the domains you control.
As for s3.amazonaws.com, we use Google's library in order to determine whether a string is a domain suffix ( https://github.com/pagespeed/domain-registry-provider ), which uses the public TLD list ( https://publicsuffix.org/list/effective_tld_names.dat ). It is not a bug and there's a discussion about it here: https://github.com/pagespeed/domain-registry-provider .
If you go to the publicsuffix.org page, it also states that "[a domain on the TLD list] represents the part of a domain name which is not under the control of the individual registrant.", which is the case here; TrustKit preventing you from pinning this domain is the expected behavior.
Hope this helps!


Bumped upper version bound for base

GHC 8.4.1-alpha1 was announced. While testing Agda with this version of GHC, I got the following error:
$ cabal install
Resolving dependencies...
cabal: Could not resolve dependencies:
trying: hashable-<IP_ADDRESS> (user goal)
next goal: base (dependency of hashable-<IP_ADDRESS>)
rejecting: base-<IP_ADDRESS>/installed-4.1... (conflict: hashable => base>=4.4 &&
<4.11)
...

This PR fix the above issue.
Blocking https://github.com/agda/agda/issues/2878.

GHC 8.4.1-alpha3 was announced. Could someone merge this PR please?

Bump, it builds with ghc-8.4.1-rc1.

@tibbe any chance to get it merged soon?

Would love if this can be merged soon. My package isn't building in ghc-8.4 because of this.

@psibi fwiw, you don't have to wait for hashable to revise its base bound, you can use --allow-newer=hashable:base (or the equivalent in your cabal.project or cabal.config file);  you'll also likely need something like https://github.com/hvr/head.hackage currently (if you use my Travis CI script generator, it allows you to enable head.hackage for GHC 8.4.1 easily)  as there's quite a few other packages that aren't GHC 8.4.1 ready yet (you may want to track https://github.com/haskell-infra/hackage-trustees/issues/135).

I believe the same thing has been accomplished in https://github.com/tibbe/hashable/pull/154 (which was just merged).

Indeed, this was subsumed by #154


refactor HttpUtils to pinot-common

Description
create HttpUtils out of ControllerTestUtils that are generically useful.
Release Notes
TBA
Documentation
TBA

Codecov Report

Merging #8293 (297c619) into master (46ed731) will decrease coverage by 1.41%.
The diff coverage is 10.00%.

@@             Coverage Diff              @@
##             master    #8293      +/-   ##
============================================
- Coverage     70.83%   69.41%   -1.42%
+ Complexity     4245     4244       -1
============================================
  Files          1631     1633       +2
  Lines         85462    85552      +90
  Branches      12877    12884       +7
============================================
- Hits          60539    59390    -1149
- Misses        20746    22020    +1274
+ Partials       4177     4142      -35

Flag
Coverage Δ

integration1
?

integration2
27.54% <0.00%> (-0.07%)
:arrow_down:

unittests1
66.90% <0.00%> (-0.06%)
:arrow_down:

unittests2
14.14% <10.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pinot/common/utils/http/HttpUtils.java
0.00% <0.00%> (ø)

...pinot/controller/helix/ControllerRequestUtils.java
31.03% <31.03%> (ø)

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nverttorawindex/ConvertToRawIndexTaskExecutor.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...e/pinot/common/minion/MergeRollupTaskMetadata.java
0.00% <0.00%> (-94.74%)
:arrow_down:

...plugin/segmentuploader/SegmentUploaderDefault.java
0.00% <0.00%> (-87.10%)
:arrow_down:

.../transform/function/MapValueTransformFunction.java
0.00% <0.00%> (-85.30%)
:arrow_down:

...ot/common/messages/RoutingTableRebuildMessage.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...data/manager/realtime/DefaultSegmentCommitter.java
0.00% <0.00%> (-80.00%)
:arrow_down:

...verttorawindex/ConvertToRawIndexTaskGenerator.java
5.45% <0.00%> (-80.00%)
:arrow_down:

... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ed731...297c619. Read the comment docs.

URLConnections have a much longer iterative lifecycle and it seems like it doesn't support http 2.0 based on this article: https://www.mocklab.io/blog/which-java-http-client-should-i-use-in-2020/. let's go with httpclient solution instead.


Access Code Table - Add infinite scroll to fetch more items

We don't want to fetch all the items at once, so we'll implement infinite scrolling to fetch more codes.
Figma

[ ] Implement inf. scroll
[ ] Show message at end of list

Notes

Possibly abstract out behavior as inf. scroll will likely be used by other lists as well, such as in the device table.
Could use useInfiniteQuery from react-query

@seveibar I don't think I see pagination set up in seam-connect, do we want to create a separate GH issue somewhere for that?


Any way to get expert demos for each task?

Hi,
Thanks for open-sourcing this brilliant benchmark! I was wondering that is there any quick way to get expert demos for each task in Simpler? Like a script oracle policy, or a RL policy trained on each env?
I didn't find anything like these in the codebase. But I was wondering if the authors may have run some relevant experiments before and could help share some insights on this? Like how good can a RL policy perform in each env? Thanks!

The "expert demos" are from the open-x-embodiment dataset.

Sorry for the confusion. I mean expert demos for each Simpler env in simulation. I guess directly running a open-x-embodiment action sequence in simpler would just fail due to dynamics mismatch?

Open-loop unrolling demo trajectories will most likely succeed since simpler-env already performs sysid to match the dynamics gap between sim & real.

Thanks for your reply! If I want to run a OXE expert trajectory in a open-loop way in the corresponding simpler environment, how should I setup and reset the environment to match with those in the expert trajectory? Thanks!

For existing environments in Simpler, you just need to take the trajectories with the same language instruction from the demo dataset and adjust the object pose to match the real eval
For environments not already present in this repo, you need to create new environment, which means you need the assets, a proxy simulation env, and a frame from demos to overlay the sim observation (with robot arm removed); you can generate assets via https://www.sudo.ai/

I see. Thanks! I wanted to run demos for existing simpler environments. I'll try with the first approach you suggest. Thanks!

Hi @xuanlinli17 , thanks a lot for your help!
About "adjust the initial object pose to match the demo's first frame" in your previous reply, I was wondering that how can I achieve this adjustment? I checked the OXE data and there seems to be no information about the demo's initial pose. Or should I do this manually by checking their visual appearance by myself? Could you help provide a simple example code of how to do the adjustment here? Thanks!

You have to manually tune the object pose. You can use the nvdiffrast utilities in https://github.com/Jiayuan-Gu/GeTex (except baking texture).


Switch to WildFly 12, #131

Pull request that bumps the versions for WildFly full to <IP_ADDRESS>.Final and WildFly core to 4.0.0.Final. As the workaround for WFLY-6201 is not necessary anymore, this change has been reverted.

I'm closing this for now as I'd like to keep testing against WildFly 10 for now. Thanks for the contribution though!


URL Protocol opens existing window instead of launching a new one

When we open vscode using the URL protocol (vscode://file/some-folder) it utilizes an existing window and overwrites it with the new folder. It was expected that a new window would be launched if the URL we are trying to open via vscode:// does not match any open window.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.63.2
OS Version: Windows 10

Steps to Reproduce:

Start a vscode instance in any folder e.g. D:/folder-a
Use the URL Protocol to open vscode on a second folder e.g. start vscode://file/D:/folder-b or using the explorer/browser URL input
Check that the vscode window that was open on the first folder D:/folder-a was overwritten with the new folder D:/folder-b

I think changing this for everyone just now is a bad idea, and besides this is also a user setting to control this. But maybe there could be a parameter in the URL to control this.

We now handle a windowId=_blank query param. If you set this in a URI and give it to be handled by Code, it will always do it in a brand new window.

Reminder: release notes

Oh wow good catch @joyceerhl! I can definitely repro, but not on URIs meant for extensions. There might be another code path I didn't see.

Bad copy paste. This is already in main since yesterday: https://github.com/microsoft/vscode/commit/bcc2da636987ca8b173820b53c9a4a16b06064fa

Works great. Adopted this in my logseq plugin, good timing :)


pymycobot on windows

Hi, Thanks for very nice tutorials.
I would like to use myCobot python on my Windows system.
In your tutorial, declaring the usb device which is connected to myCobot as shown below.
The following tutorial is based on linux system.
`
from pymycobot.mycobot import MyCobot
from pymycobot.genre import Angle
mycobot = MyCobot('/dev/ttyUSB0')
mycobot.send_angle(Angle.J2.value, 10, 50)
`
My question is that what argument I should input in as a device name in Windows system.
mycobot = MyCobot('[device name]')
Thanks for very much.

You can use the following code to find the port.
import serial.tools.list_ports

port_list = list(serial.tools.list_ports.comports())
for item in port_list:
    print(item[0])

In windows, the port character is usually COM*.

You can use the following code to find the port.
import serial.tools.list_ports

port_list = list(serial.tools.list_ports.comports())
for item in port_list:
    print(item[0])

In windows, the port character is usually COM*.


tests: keyify Config

Ref #41

Coverage remained the same at 98.874% when pulling 8dbf90aba2b617de51d70f6b5a0a678ecdea4eff on flisky:keyify into b6bd76ad0f792508efc589a2790e2aee1d0f240d on allegro:master.

@flisky Thanks!


Zero Downtime Deployments with Dapr

/area runtime
What is the correct configuration to implement zero downtime for stateless services?
We are testing the following scenario:
External Client => Ingress Controller => API
We first ran a test without Dapr. When deploying the API, we found the Kubernetes networking issue, which we addressed adding a delay to shutdown our PODs. However, when we added Dapr for the communication between the Ingress Controller and the API, Dapr creates a Headless service. The communication between the Ingress Controller and the API fails during deployment. After a lot of googling, we have added the following parameters:
dapr.io/block-shutdown-duration: 10s
dapr.io/graceful-shutdown-seconds: 10s
This makes it much better, but we still get failures around 25% of the time (we also tested multiple combinations of these parameters). We believe this is an issue with DNS while the PODs are terminating. Considering how headless service works, the ingress controller still has the DNS pointing to the terminating PODs. If we increase these times to 35 (which is over the TTL for the cluster DNS), then we can achieve zero downtime. We were very surprised to face these issues, so we believe there might be a standard way to ensure zero downtime without having such a long delay. We have considered the following solutions:

Retry on the ingress: We could not find a way to retry only this specific error. The retry policy would affect all requests, which we think it would not be good for our solution.
Change the service to be a regular service instead of headless: Unfortunately Dapr does not support this capability.

Retry on the ingress: We could not find a way to retry only this specific error. The retry policy would affect all requests, which we think it would not be good for our solution.

The ability to retry on a specific status code is being added to v1.15

Change the service to be a regular service instead of headless: Unfortunately Dapr does not support this capability

Dapr doesn't support this today, however - we did change the way to get a list of endpoints for an underlying Kubernetes Service, so it might just be that we can go back to a non-headless service. We'll need to look into that

+1 agree with using a standard service which will likely (maybe) improve things- I’d still preface that this issue will always fundamentally exist so your workaround/fix will likely always need to be there in some capacity. The problem fundamentally lies in DNS caching and the way Kubernetes works which we both don’t control.

Theoretically, when using Dapr app health checks, if the application health check is failing, Dapr's health check should return non 200 to the Kubelet which should remove the instance from the headless service's endpoint list

I am trying to understand the recommendation here. The DNS still resolves to the address of a service that is no longer available. How is health check helping with the problem? Is there an example of Dapr deployment that is zero downtime?

I am trying to understand the recommendation here. The DNS still resolves to the address of a service that is no longer available. How is health check helping with the problem? Is there an example of Dapr deployment that is zero downtime?

When Dapr identified the app isn't ready to serve requests, it will fail it's own health check which will cause that instance to be removed from the list of addresses for the service endpoint


admin app for CI/CD

Should accept requests from GitHub actions
Should build to fly.io
Should run tests and push the status to Engage

This is being done by https://github.com/pipalacademy/boring-serverless


Has any benchmark result with mace

Hi, all!
Has any benchmark result for nnlib with mace, ncnn or etc? Besides, I wanna ask which performance is better between nnlib and SNPE?
Thanks in advance.

duplicated with https://github.com/XiaoMi/mobile-ai-bench/issues/24


Create Bankzrowez

Please ensure that your pull request meets the following requirements - thanks !

Follows our existing codestyle.
Does not break any unit tests.
Contains a reference to the issue that it fixes.
For cosmetic changes add one or multiple images, if possible.

Bugged for 2.518 years

If you believe this is a useful way to provide feedback, you're wrong.


RTL_TCP buffers are not fully cleared on channel change/stop action

When connected to an RTL_TCP instance, there may be a brief set of data decoded from the previously tuned channel instead of the current channel.  This can cause the Channel Settings FFT to skew the initial set of power averages and also can cause the "PVR Info" information ("O" during playback) to show the wrong MUX name and skewed/inaccurate quality metrics.
The problem could be solved in either the addon by dumping some initial data, or I feel more appropriately, by a change to RTL_TCP to dump any local/device buffers on a client disconnect.
Sadly OSMOCOM completely ignored my other requests for simple changes to RTL_TCP so I think any improvement will be limited to the "RTL-SDR Toolkit" built as part of this project.

This turned out to be less of a concern than I thought, but I did update rtl_tcp to flush the device buffers before any new stream is opened.  The Kodi UI doesn't implicitly clear/update the MUX name during a channel change; this explains the lag there.  I did note and correct a defect in the addon that would constantly recalculate the RBDS callsign information if the Program Information (PI) code fell into a "special case" category of 0xAxxx ...


Issue 5097 fix

Will fix https://github.com/duckdb/duckdb/issues/5097

Opened against duckdbmaster here https://github.com/duckdb/duckdb/pull/5620


New version: IntegerTriangles v0.2.1

Registering package: IntegerTriangles
Repository: https://github.com/OpenLibMathSeq/IntegerTriangles.jl
Created by: @PeterLuschny
Version: v0.2.1
Commit: 4b9a2fb9456f7f5c2afcaad1b0ee50ea726a58bc
Reviewed by: @PeterLuschny
Reference: https://github.com/OpenLibMathSeq/IntegerTriangles.jl/issues/6#issuecomment-824006422

@JuliaRegistrator register()

@PeterLuschny please read the message above.  Once you fix the automerge issues you can register again the new revision without changing the version number as you did before (i.e., not commenting here) and this pull request will be automatically updated.
[noblock]


Implement operations DB processor

While working on this please make sure to use BatchInsertBuilder. Without it processing will be too slow for large ledger (we experience this in the old ingestion).

Fixed in #2043


Panic on query x -> y

What happened?
Rust panic on SQL query.
Source from ClickHouse fuzzer (the query might not even be a valid SQL query, let alone valid PRQL)
Tested 0.9.5 (CH version), 0.11.3 and the playground and both fail with the query:
SELECT id FROM distributed_test_table GROUP BY x -> concat(concat(materialize(toNullable(NULL)))) LIMIT 3

Seems like the lambda makes panic.
PRQL input
x -> y

SQL output
A compiler bug was encountered

Expected SQL output
An error

MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
No response

Thanks, I can take a look at this.

Source from ClickHouse fuzzer

Interesting — do you have any context on this? We've been considering fuzzing ourselves.

OK that's great!

If you happen to know — how painful is a panic from PRQL for ClickHouse?  If it does, we should be much more careful about panics. We treat them all as bugs, but don't fuzz the compiler, and there will be ways of getting them, as this example shows...
(FWIW this is something I asked a while ago on the ClickHouse issue tracker in the early days, since I think it used to be bad, but there was some discussion of isolating rust extensions)

We have a similar practice - some exceptions (of type "logical error") turn into assertions in debug builds. So they terminate the process in CI. But in release builds, they are just exceptions - thrown, then caught, and reported to the user.

We have a similar practice - some exceptions (of type "logical error") turn into assertions in debug builds. So they terminate the process in CI. But in release builds, they are just exceptions - thrown, then caught, and reported to the user.

OK great.
I'll work on this regardless

Right now panics crash CH. We tried to avoid it (see https://github.com/ClickHouse/ClickHouse/blob/65cfbaaa4b6194937478e98c773ed6ed56a6d70f/rust/prql/src/lib.rs#L60-L62) but apparently it does not work.
If you have any suggestion about how  to translate panics into errors it'd be really appreciated, as it would lower the impact of PRQL bugs a lot.

Right now panics crash CH. We tried to avoid it (see https://github.com/ClickHouse/ClickHouse/blob/65cfbaaa4b6194937478e98c773ed6ed56a6d70f/rust/prql/src/lib.rs#L60-L62) but apparently it does not work.

That looks reasonable. There are some corner cases where a panic could happen in string conversions, but that doesn't seem to be the issue.
I'm looking through your list at the top of the issue to try and find the traceback in CH for the x -> y issue, as a case for panic::catch_unwind failing to work. I can't find after a few min of looking. I'll look more but if it's obvious please lmk...

It’s here: https://s3.amazonaws.com/clickhouse-test-reports/0/d93d5c2a0028944e8f17f8fa5257bb1e0de44e1f/ast_fuzzer__asan_/fatal.log
if you go the CH issue, click in the report linked there and then fatal.log has the backtrace. The index has other files like the server or the fuzzer logs.


Allow binding global hotkeys without modifier

from @fullzero87  in https://github.com/geovens/gInk/issues/152

I want to use usles but handy F1 key without any modifiers to enable/disable glnk.

Here a beta test version removing limitation on global hotkey.
ppInk64_Hk24a.zip
note that hotkeys using prtscr or win can not be used (early captured by windows)
waiting for test reports

Here a beta test version removing limitation on global hotkey. ppInk64_Hk24a.zip note that hotkeys using prtscr or win can not be used (early captured by windows)
waiting for test reports

Tested this version. Hotkeys without modifiers working as expected. Can be assigned and used.
But there are some issues in program behavior and settings. I personally prefer behavior of glink where I can use same key for toggle drawing without need to exit with different key binding.
Best experience of using hotkeys I had with gromit-mpx linux program. Very simple, useful, can configure multiple global hotkeys (F1 for toggle drawing, shift + F1 for clear). Also gromit-mpx supports wacom pen pressure value for line width and eraser.

hi @fullzero87

But there are some issues in program behavior and settings. I personally prefer behavior of glink where I can use same key for toggle drawing without need to exit with different key binding.

Can you please clarify with an example

Best experience of using hotkeys I had with gromit-mpx linux program. Very simple, useful, can configure multiple global hotkeys (F1 for toggle drawing, shift + F1 for clear).

With the mod proposed You can set up something quite similiar. F1 to start inking then it will enter/exit cursor mode
and set shift+F1 to clear.

Also gromit-mpx supports wacom pen pressure value for line width and eraser.
I have done some test  (have a look on https://github.com/pubpub-zz/ppInk  , there is some demonstration)  and all works for me. so far from I remember, wacom should be correctly set up (sorry I do not have my tablet with me to capture the setup)


[BUG] Excel.Table does not expose correct properties

🐛 Bug Report
Excel.TableProperties does define a propertie columns and with that does Excel.Table as it's an extension of Excel.TableProperties.
But this propertie doesn't actually exist on Excel.Table. In reality this propertie is on table.table.columns
There are many other examples like "table.ref" not working but table.table.tableRef is working.
Same with rows and style.
Lib version: 4.3.0
Steps To Reproduce
This should be valid code by how the interface is currently written. (columns propertie beeing present on Excel.Table via. the extension of Excel.TableProperties which defines columns as a propertie)
const wb = await new Excel.Workbook().xlsx.readFile("MyExcel.xlsx");
const ws = wb.getWorksheet("MyWorksheet");
const table = ws.getTable('MyTable');
console.log(table.columns);

But table.columns doesn't exist. To access it, you have to use the following code
const wb = await new Excel.Workbook().xlsx.readFile("MyExcel.xlsx");
const ws = wb.getWorksheet("MyWorksheet");
const table = ws.getTable('MyTable');
console.log(table.table.columns);

or if you don't want a linter error:
const wb = await new Excel.Workbook().xlsx.readFile("MyExcel.xlsx");
const ws = wb.getWorksheet("MyWorksheet");
const table = ws.getTable('MyTable');
console.log((table as any).table.columns);

The expected behaviour:
Either the columns propertie should return the correct value directly on the table or an addiontal propertie table which contains columns should be defined.

@DPWalther
Can you provide a sample excel file and sample file?

I have the same issue.

That prob explains why I get a corrupted XLSX if I try and use sheet.addTable(...).getColumns(1).width = 15 also.

Yes, it seems like addTable returns an object containing the worksheet and table, instead of just the table:
  const table = sheet.addTable({
    name: st('entities.components'),
    ref: 'A2',
    columns: [
      { name: 'Label', filterButton: true },
      { name: nameColumnKey, filterButton: true },
    ],
    rows: [],
    headerRow: true,
    style: { theme: 'TableStyleLight1' },
  });

  console.log(table);

Yes, it seems like addTable returns an object containing the worksheet and table, instead of just the table

https://github.com/exceljs/exceljs/blob/5bed18b45e824f409b08456b59b87430ded023ab/lib/doc/worksheet.js#L794-L810
https://github.com/exceljs/exceljs/blob/5bed18b45e824f409b08456b59b87430ded023ab/lib/doc/table.js#L69-L79
It seems to me that the getTable and removeTable are also broken because of this issue.
Possible fix:
addTable(model) {
  const instance = new Table(this, model);
  const { table ) = instance;
  this.tables[model.name] = table;
  return table;
}


[Things] ... search task

Extension
https://www.raycast.com/loris/things
Description
Thank you for your work. I have a little request that it would be great to have.
It would be possible to search a things task through the extension?
Thank you so much.
Who will benefit from this feature?
Everyone who uses the extension.
Anything else?
No response

It's already possible somehow, if you type something in any lists (today, etc) and hit ⌘+⏎ it will open trigger that search into Things:

However, what you probably meant was getting the search results inside Raycast, but unfortunately this is not currently supported by Things AppleScript integration (https://culturedcode.com/things/support/articles/2803573/#search)