Payments - Default tag is not given to newly selected default payment after deleting previous

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to expensifail account that has 2 bank accounts and Pay.me listed in payment methods
Delete bank account with "default" tag
Select 2nd bank account and select "Make default payment method"

Expected Result:
"Default" tag is given to 2nd bank account
Actual Result:
No default tag is given to 2nd bank account after selecting "Make default payment method"
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Ys
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/96129efb-94c1-408f-b6ba-66811497b28f
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Deleting a payment method with the default tag leaves the remaining payment methods without a default.
What is the root cause of that problem?
Users are allowed to delete the default payment method.
What changes do you think we should make in order to solve the problem?
Ideally, when dealing with payment methods, users should be prevented from deleting their default payment method. This behaviour can be observed on several platforms like Amazon Shopping, Google Payments, the Apple App Store among others. For Expensify, if a user has two or more payment methods, we can add code to prevent the user from deleting the default payment method, and allow deletion only after the default has been reassigned.
What alternative solutions did you explore? (Optional)
None.


Usage of util functions

Hi again!
I have a problem with using utils.py functions like "calculate_label_distribution". When I used magpie.calculate_label_distribution(data_dir, filtered_by=None) it's giving out this error: AttributeError: 'Magpie' object has no attribute 'calculate_label_distribution'. How can I use the functions?
Thanks in advance and have a nice day!

well, they're utils functions, so not part of the Magpie object. You need to import them from their directory and use them directly, not as a method of magpie.

Okay got it worked with:
from magpie import utils
and
utils.calculate_label_distribution('data', filtered_by=None)
Thank you for your time!


Darktrace workbook and sample data update

Fixes #
Proposed Changes

renaming connector from Darktrace to AI Analyst Darktrace
renaming files to reflect above
updated workbook & preview workbook photo

@SunRift  Could you please remove the notebook changes it will corrupt the system. Else every thing in the PR looks good.
It is just a suggestion you can create a fresh PR in which there is no changes for the notebook.
Thanks,
Aditi Maheshwari

Thanks for the feedback, I will open a new branch as suggested, have discarded the automatic notebook update this time so the files should be unchanged in the new branch and PR (https://github.com/Azure/Azure-Sentinel/pull/1731).


[21.05] exempi: disable tests for i686

Motivation for this change
Unable to find boost unittest framework.
Tests are still ran on the x86_64 platform
(cherry picked from commit 266f6ee63a562016b28d9a155fc4d84006d746d0)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/124338

@GrahamcOfBorg build pkgsi686Linux.exempi


pkgsMusl.zfs: fix build

Description of changes
Backport of https://github.com/openzfs/zfs/pull/14327.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@OfBorg test zfs

@OfBorg build zfsUnstable


General: Loader plugin define its own compatibility

Brief description
This is "idea", how to give loaders more power to decide if can be shown in UI by adding is_compatible method on it.
Description
Add is_compatible class method to loader plugin which by default does what is_compatible function did but loader can override the method and be more precise in the decision.
Additional information
There are also SubsetLoaders which didn't use is_compatible at all but probably should have that option too. In future we could add objects that would represent items in loader menu so loader does not have to calculate that on it's own. That is missing few more things (like unique identifier of loader plugins, etc.) -> doable, but more complicated.
I didn't test it...
Testing notes:

Loader plugins should be filtered as they were before in Loader and LibraryLoader

I like it! :) I haven't tested the code but the concept and logic appear sound.

Yep, I like it too. Need to test it before merging but the code looks good. First step for the better loaders, yay!


Subdirectories breaking breaks root page

When I try to navigate to gemini://gem.sdf.org/hbag , or any other page hosted on gem.sdf.org, it doesn't load, which I've just attributed to their server not being the best. However, when I then try to just navigate to gem.sdf.org, that doesn't work either, despite working perfectly fine before I tried to navigate to one of the directories.
I originally thought this was also a problem with their server, but it seems nobody else is having this problem on different clients when I asked around.

This looks like a server-side issue with resumed TLS sessions. You should be able to work around this by disabling Lagrange's "Resume TLS session" setting on gem.sdf.org. To find this setting, open any page on gem.sdf.org, click on the lock icon in the URL bar, and then click Settings in the info popup.
This is only the second server I've heard of having an issue with TLS session resuming. The issue with the first one was fixed by upgrading the server software. You may want to contact the gem.sdf.org admin(s) and let them know about this problem.

When I do that, I just get "Connection refused", so...
I have made a post about it on the SDF bboard, however, but I don't remember the last time someone on there actually responded to one of my threads.

Try again now? It was giving me connection refused errors a minute ago, too.

Oh! It seems to be working now, thanks. I'll leave that TLS setting off.


fix(site): update site color values to fix build

It is so weird to me that these are still cropping up.  I feel like I did this weeks ago.


Cluster sync across AWS EKS clusters

I'm running into an issue where I have 2 clusters on AWS EKS (AWS' managed Kubernetes service) and I cannot sync secrets from cluster A to cluster B. I'm able to successfully pass in my kubeconfig file via config.kubeconfigContent. Looking at the logs of the kubed pod, it's saying that the aws CLI is not found. The way that kubectl authenticates with AWS EKS is via AWS IAM roles and aws-iam-authenticator which I believe "under-the-hood" is using the aws CLI to authenticate kubectl with the cluster with the user's AWS creds that are stored locally.
Is there any workaround for this on the kubed side? This makes it seem as if kubed doesn't work with AWS EKS clusters because the kubeconfig file can't properly authenticate with them.

You need to have either aws-iam-authenticator or aws cli tool installed locally into the same container that is running kubed in order to properly authenticate to the EKS clusters; which means you will need to build your own custom kubed image to add the authentication tools.

Closed this issue. We made our own custom image with the AWS CLI installed which allowed us to be able to auth to our EKS clusters. Thanks for the tip!

Closed this issue. We made our own custom image with the AWS CLI installed which allowed us to be able to auth to our EKS clusters. Thanks for the tip!


Add notes on using clients with Azure SignalR Service serverless mode

Add note that SignalR clients cannot call hub methods if used with SignalR Service in serverless mode.

Thanks much for the PR, @anthonychu!


Debugging Embedded Resources - causes App abort

i notices a strange behaviour when calling the method from:
System.Reflection.Assembly assembly = IntrospectionExtensions.GetTypeInfo(typeof(App)).Assembly;
var resourceList = assembly.GetManifestResourceNames();
this method is located in the overriden OnStart method of the App class.
1.) when i debug the application from a emulator everything works just fine. and "assembly" is of type "System.Reflection.MonoAssembly".
2.) when i debug via the xamarin live app the app aborts without throwning a exception and the type of "assembly" is "NInterpret.InterpretedClrAssembly".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8fb68890-cda3-6b2a-deba-55a171963da5
Version Independent ID: 675d1663-d7ea-3e47-dbdd-772944acce5a
Content: File Handling in Xamarin.Forms - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/files.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

I have also noticed that the assembly version is version "<IP_ADDRESS>" when using the camarin live app and when using the emulator the assembly version is "<IP_ADDRESS>".
i ave never changed the version.

this can be closed. i found the reason here: https://docs.microsoft.com/en-us/xamarin/tools/live-player/limitations
-> The Xamarin life player does not support embeded resources
the team could maybe add this to the repo. this would save some troubleshooting time.
im still bit curiouse if only embeded resources are not available or if reflection in general is unavailable, because of the return types of "assembly".

Hi @BrayanKhosravian
As you've identified, embedded resources aren't supported in Live Player. In addition, there's only limited support for reflection in Live Player. Live Player runs app in a sandboxed environment, and is only really designed for people getting started with Xamarin.Forms. It's really recommended that you use an emulator/device during app development.


Updated deployment templates

Added links to templates. Added registry name validation. Updated
environment URL to access other resources. Added a markdown spec.

/cc @DavidObando @SajayAntony @sivagms

:shipit:


move reco_utils/nni to reco_utils/tuning/nni

Description

move reco_utils/nni to reco_utils/tuning/nni to have only general concepts in reco_utils
Related Issues

https://github.com/microsoft/recommenders/issues/689
Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.

Since we do not have unit tests for the tuning notebooks, could you perform the integration tests before merging this PR?

These are not the only changes needed, because svd_training.py has now also moved. The locations of this script inside the NNI notebook should also be modified.

mmm I know what you mean, let me take a deeper look

Another note is that we have the tuning scripts for AzureML under the azureml folder. Should we move those under the tuning folder too or keep them where they are?

Another note is that we have the tuning scripts for AzureML under the azureml folder. Should we move those under the tuning folder too or keep them where they are?

We can do it. Maybe we should do it in a different PR

there's also the evaluation/parameter_sweep module, which seems like it would fit better under tuning

LGTM


[$1000] Native - Contact method - "It's not here" error page flashes when deleting contact method

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the App
Login with any account
Go to Settings -> Profile -> Contact methods
Add any contact method
Delete the contact method

Expected Result:
Contact method deleted without error
Actual Result:
"It's not here" error page appears
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Notes/Photos/Videos:
https://user-images.githubusercontent.com/93399543/234342981-6b658580-92ed-46f3-a1ca-1d0455dae3a1.mp4
Issue reported by: Applause - Internal Team
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c7eb83ef69b108bc
Upwork Job ID:<PHONE_NUMBER>503098880
Last Price Increase: 2023-05-16

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Contact method - "It's not here" error page appears when deleting contact method
What is the root cause of that problem?
When deleting a Contact Method, we are deleting the contact methods in Onyx first then go to previous screen.
https://github.com/Expensify/App/blob/930352d64958603e50a51e32d834c34dbf1ad946/src/libs/actions/User.js#L195-L197
We also check if there's no contact method or invalid login we will show the Not found screen, so that why we see this screen while deleting contact method.
https://github.com/Expensify/App/blob/930352d64958603e50a51e32d834c34dbf1ad946/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L166-L168
What changes do you think we should make in order to solve the problem?
To prevent this issue, we can navigate user to previous page first then update it in Onyx.
So the delete contact method will look like this:
function deleteContactMethod(contactMethod, loginList) {
    const oldLoginData = loginList[contactMethod];

    // If the contact method failed to be added to the account, then it should only be deleted locally.
    if (lodashGet(oldLoginData, 'errorFields.addedLogin', null)) {
      // navigate to previous screen first then delete the contact method in Onyx
        Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS);
        Onyx.merge(ONYXKEYS.LOGIN_LIST, {[contactMethod]: null});
        return;
    }

What alternative solutions did you explore? (Optional)
None

Looks like something related to react-navigation may have been mentioned in this issue discussion.
As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.
Feel free to drop a note in #expensify-open-source with any questions.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Android - Contact method - "It's not here" error page appears when deleting contact method
What is the root cause of that problem?
When deleting a Contact Method, we are deleting the contact methods in Onyx first then go to previous screen.
https://github.com/Expensify/App/blob/930352d64958603e50a51e32d834c34dbf1ad946/src/libs/actions/User.js#L195-L197
We also check if there's no contact method or invalid login we will show the Not found screen, so that why we see this screen while deleting contact method.
https://github.com/Expensify/App/blob/930352d64958603e50a51e32d834c34dbf1ad946/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js#L166-L168
What changes do you think we should make in order to solve the problem?
To prevent this issue, we can navigate user to previous page first then update it in Onyx.
So the delete contact method will look like this:
    deleteContactMethod() {
        if (!_.isEmpty(lodashGet(this.props.loginList, [this.getContactMethod(), 'errorFields'], {}))) {
            Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS);
            InteractionManager.runAfterInteractions(() => {
                User.deleteContactMethod(this.getContactMethod(), this.props.loginList);

            })
            return;
        }
        this.toggleDeleteModal(true);
    }

Also remove the Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS); inside deleteContactMethod, since we already use it outside.
What alternative solutions did you explore? (Optional)
None

I just tested on a Pixel 7 and I'm unable to reproduce this one.

The best I could get was an additional step not mentioned in the reproduction steps, which was trying to delete the contact method immediately after creation. For that case, I got this error, though it's not the same result as this issue.

Adding a needs reproduction label for now.

@JmillsExpensify if you can test it on ios simulator,you can try to turn on the slow animation, you will see this issue easier

Unfortunately I'm not able to test on the simulator. Only real devices.

Following up on that last comment, are you able to reproduce on a real iOS device as well?

@JmillsExpensify I do. Just tested on latest version
https://user-images.githubusercontent.com/16502320/235835440-56baf1d9-747f-4b03-aba4-853648bdaf6a.MOV

I'm still unable to reproduce using the reproduction steps above. Not trying to be difficult but are you doing anything in the reproduction steps that aren't above?

Also the error is specific to not having a correct Expensify password, which to me points to an artifact of our passwordless rollout not being yet complete.

Let me try to reproduce again 😀

@JmillsExpensify I can still reproduce with ios version 1.3.10-4.
Here's the reproduce step:

Add an invalid contact method.
Wait for a while, you will see it has red dot.
Click on that contact method and press Delete.

https://user-images.githubusercontent.com/16502320/236380276-3043983a-b88a-4239-857d-7f5eee6d328d.MP4

Interesting. To keep this one moving, I'm going to go ahead and open it up to the community.

@hungvu193

So the delete contact method will look like this:
Also remove the Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS); inside deleteContactMethod, since we already use it outside.

What about the rest of the function with the onyx data and the api call?
And the current parameters being passed to the function?
It looks like your proposed code still has a call to that, so which one is being removed?

If I'm understanding correctly, can you update the proposal to reflect the change more closely with respect to the current code?

Waiting for contributor to update proposal, or for new proposals to be added for review.

@hungvu193

So the delete contact method will look like this:
Also remove the Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS); inside deleteContactMethod, since we already use it outside.

What about the rest of the function with the onyx data and the api call?
And the current parameters being passed to the function?
It looks like your proposed code still has a call to that, so which one is being removed?

If I'm understanding correctly, can you update the proposal to reflect the change more closely with respect to the current code?

@hungvu193

So the delete contact method will look like this:
Also remove the Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHODS); inside deleteContactMethod, since we already use it outside.

What about the rest of the function with the onyx data and the api call?
And the current parameters being passed to the function?
It looks like your proposed code still has a call to that, so which one is being removed?

If I'm understanding correctly, can you update the proposal to reflect the change more closely with respect to the current code?

Thanks for your feedback, I updated my proposal https://github.com/Expensify/App/issues/17975#issuecomment-1522866076

Thank you. The proposal look solid to me, but would it be better for the navigation part to be in the action file src/libs/actions/User.js, instead of in the src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js? The functionality would be equivalent, but I'm wondering where the code makes more sense semantically.

We have similar issue here. I think we should solve both the issue similarly.

Yes, @cead22. We should hold this for now.

Updated issue title to reflect held status

On hold so not overdue

Looks like https://github.com/Expensify/App/issues/16249 will be completed tomorrow, which means we can remove the hold on https://github.com/Expensify/App/issues/18076, which is what this issue is held on

The PR for https://github.com/Expensify/App/issues/16249 is in production so I bumped https://github.com/Expensify/App/issues/18076 to remove the hold. This is still on HOLD for that

Still on hold

Still on hold

Still on hold

On hold and not overdue

Still on hold

Hold

Still on hold since https://github.com/Expensify/App/issues/18076 is still on hold

Ditto ^

Ditto ^, https://github.com/Expensify/App/issues/18076 is still on hold and the PR it's being held on is still being worked on

Same same

Linked issue still on hold.

Not a priority still while we're waiting.

Same

Off hold, the issue this was being held on is closed, and the PR to update RN is merged.
@kbecciv is this issue still reproducible? cc @sobitneupane

This issue isn't reproducible.
Note: Unlike before, the sample phone number (+3806744404444) used in the video for the bug description is currently considered invalid.

Unable to reproduce it
https://github.com/Expensify/App/assets/93399543/98067722-0ee5-43be-9916-ca22decd2ad0


Could you please add dida365.com to this project?

Could you please add dida365.com to this project? Thank you.

you can try replace all "ticktick.com" to "dida365.com" in python files then it will work


Ehcache was reporting MappingCount as a counter instead of a gauge

If someone can merge this m&m bugfix.
Thanks :-)

@mathieucarbou this was found because after eviction it kept going up, right ? Can you please add a test that shows you fixed the behavior of MappingCount ?
Also I thought you or @henri-tremblay woudl add an issue for that as well ?

But I agree with @anthonydahanne that a test would be nice. And you need to rebase.

wow guys ;-) this PR has nothing to do with the other opened defect;-) this is just a PR fixing the statistic types ;-)

I know. But it still have no tests :-)

There are 2 tests in my PR @henri-tremblay !

I meant a test that is showing the number going up and down instead of ever increasing.

@henri-tremblay : the PR does not modify the behaviour of the stat. It modifies how the stat is described in M&M (stats descriptors) and this is tested in 2 tests, that you see in the PR.

@henri-tremblay  : @mathieucarbou  and I just discussed that : he explained to me the tagging as GAUGE of the stats is only for MnM and has no incidence on ehcache3 stat. That's why he's only testing the tagging.

Cool


Unable to retrieve child resources.

Unable to retrieve child resources.
Details:
{
"name": "Error",
"message": "Hub Controller process exited prematurely with signal 'SIGABRT'.",
"__zone_symbol__error": {
"originalStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)",
"zoneAwareStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)"
},
"stack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)\nFrom previous event:\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at defer (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/node_modules/q/q.js:582:19)\n    at Promise.then (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/node_modules/q/q.js:828:20)\n    at ControllerConnection.connectImpl (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:48:14)\n    at Function.ControllerConnection.connect (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:31:27)\n    at HubLookup.getLocationService (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubLookup.js:20:80)\n    at HubClient.requestServiceWithRetries (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubClient.js:74:21)\n    at HubClient.requestService (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubClient.js:62:21)\n    at ElectronAadAccountProviderClient. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:57:74)\n    at Generator.next ()\n    at /Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:10:71\n    at new ZoneAwarePromise (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:551:29)\n    at __awaiter (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:6:12)\n    at /Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:56:27",
"originalStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)",
"zoneAwareStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)",
"__zone_symbol__stack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)\nFrom previous event:\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at defer (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/node_modules/q/q.js:582:19)\n    at Promise.then (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/node_modules/q/q.js:828:20)\n    at ControllerConnection.connectImpl (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:48:14)\n    at Function.ControllerConnection.connect (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:31:27)\n    at HubLookup.getLocationService (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubLookup.js:20:80)\n    at HubClient.requestServiceWithRetries (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubClient.js:74:21)\n    at HubClient.requestService (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/hubClient.js:62:21)\n    at ElectronAadAccountProviderClient. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:57:74)\n    at Generator.next ()\n    at /Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:10:71\n    at new ZoneAwarePromise (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:551:29)\n    at __awaiter (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:6:12)\n    at /Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/identity-client/dist/AadAccountProviderClient.js:56:27",
"__zone_symbol__name": "Error",
"__zone_symbol__message": "Hub Controller process exited prematurely with signal 'SIGABRT'.",
"__zone_symbol__originalStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)",
"__zone_symbol__zoneAwareStack": "Error: Hub Controller process exited prematurely with signal 'SIGABRT'.\n    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:811:33)\n    at new AppInsightsAsyncCorrelatedErrorWrapper (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/applicationinsights/out/AutoCollection/CorrelationContextManager.js:193:18)\n    at ControllerConnection.onControllerProcessExited (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:135:21)\n    at ChildProcess. (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/microsoft-servicehub/controllerConnection.js:96:93)\n    at Object.onceWrapper (events.js:300:26)\n    at ZoneDelegate.invokeTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:275:35)\n    at Zone.runTask (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:151:47)\n    at ChildProcess.ZoneTask.invoke (/Applications/Microsoft Azure Storage Explorer.app/Contents/Resources/app/node_modules/zone.js/dist/zone-node.js:345:33)\n    at ChildProcess.emit (events.js:215:7)\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)",
"signal": "SIGABRT"
}

In Storage Explorer settings, turn on Verbose Authentication Logging under, Application -> Sign-in
Close Storage Explorer
Delete the contents of C://AppData/Local/temp/servicehub/logs/
Start Storage Explorer
Do everything you do to reproduce this problem

After it reproduces, zip up C://AppData/Local/temp/servicehub/logs/, and attach it here
Thanks.

Can you try upgrading to at least version 1.19.0, try signing in, and then we can troubleshooting if you're still having issues with that version?

Can you try upgrading to at least version 1.19.0, try signing in, and then we can troubleshooting if you're still having issues with that version?

Signing in? That's almost impossible in Storage Explorer.

MS authentication is a fuckin mess.

v1.19.0 uses a different authentication library which we hope to give you a better sign-in experience. Please consider giving it a try and let us know your experience. We'll be happy to help you out if this new library still doesn't address your situation. We understand your frustration and appreciate your patience.  We love to hear our customer feedback and we work hard to address the issues as quickly as we could.  We'd also appreciate it when you report issues or communicate with us if you could consider using only appropriate language.  This is a professional form.  There is no place for profanity.

That issue is something that we have addressed in version 1.19.

That issue is something that we have addressed in version 1.19. There were many other people with that issue(#460) and for all of them the update has made using Storage Explore much easier.

As I said, now it is impossible to authenticate, except using the deprecated authentication mode. When that is removed, I will just be forced to use only web Azure portal. So, no, the fix won't fix a thing!


Division by zero when total_n_ignore = 0

🐛 Describe the bug
When the input sample does not contain non-ignore labels, a division-by-zero error will be raised.
[rank1]:   File "/data/conda3/lib/python3.11/site-packages/liger_kernel/ops/fused_linear_cross_entropy.py", line 114, in forward
[rank1]:     n_non_ignore / total_n_non_ignore
[rank1]:     ~^~~~~~~~
[rank1]: ZeroDivisionError: division by zero
Reproduce
No response
Versions
latest

cc @shivam15s can fix this in the refactoring change

The issue is fixed


Still WIP. Using azure common deployment for multi region. Also adding keyvault.

#225 and #283
Work in progress still. Need to figure out the unit test components still, but a quick lookover now would be appreciated, @jmspring @sarath-p

Closing for #352 and another followup for multicluster keyvault


[SDL 0141] Supporting simultaneous multiple transports

Note that separate discussions will need to take place to confirm proxy implementation details for this proposal.
Proposal: Supporting simultaneous multiple transports

This proposal aims to support multiple transports between Core and Proxy.

Review: https://github.com/smartdevicelink/sdl_evolution/issues/405
Steering Committee Decision:

The Steering Committee has voted to accept this proposal with revisions. The revisions are as follows:

Introduce a new Control Frame, RegisterSecondaryTransport, which will be used once a Secondary Transport is connected to notify Core that the Proxy has established a connection and tell Core which session is registering.
Rename Transport Config Update to TransportEventUpdate. The original parameters will be refactored to a flat structure.
StartServiceACK for the RPC service will contain a Secondary Transport param that will contain an array of potential secondary transports instead of a single value. The service to transport priority parameters will become flat instead of document style; each service param will contain an ordered array in terms of priority of potential transports.
Proxy connection retry strategy will include the new TransportEventUpdate Control Frame. When a connection is interrupted/ended, a TransportEventUpdate control frame will be sent to the proxy on the primary transport. If the proxy is to retry (in case of WiFi), it will include the IP address and Port. If the proxy is not to retry, the frame will contain either empty strings for IP address and port or not include the parameters at all.
Will recommend, but not require, using 5GHz
Proxy implementations will be discussed outside of this proposal.

The proposal .md was updated on March 16, 2018 to include the agreed upon revisions.

Fixed with #768


Squid Report Table

Almost there!

let's make the columns better fit the width of the content especially when all entries are zeroes
make the blue for selection of a line lighter or more transparent - also synchronize the color (selected row) with the Fractions column
problem: if user open Squid3 report while it is already open, it becomes miniaturized.  Solution - either fix the scaling or make it a singleton - just show current report
looks like squidReportTable.utilities.StringComparer is dead code - get rid of it
ditto CSVExtractor
ditto FileHandler
check all squidReportTable files for unused imports
TextArrayManager constructor: move the code from line 47 onward into one or more private helper methods called from the constructor
run findBugs on squidReportTable package and make any important changes suggested
10 ) why do we need separate controllers and fxml files for ref mats and unknowns? ALSO, currently the choice of reference material report shows the unknowns!!
left-justify Category Labels in header

I updated this branch to resolve conflicts with master.  Note the old Squid files will not work now.  One good example squid file (Z626611PKPERM1.squid) exists in the resources of squidCore under projects.
Problem: Opening reference materials report shows entry numbers in orange bar.

a couple tweaks:

enum entity is misspelled: 'Uknowns'

actually you have two enums doing the same thing:

 public enum ReportTableTab {
        refMat, unknown
    }

and
 public enum TypeOfController {
        ReferenceMaterials, Uknowns
    }

this seems redundant?

    rtHbar.visibleProperty().addListener((obVal, oldVal, newVal) -> {
            if (newVal) {
                AnchorPane.setBottomAnchor(boundCol, 29.0);
            } else {
                AnchorPane.setBottomAnchor(boundCol, 5.0);
            }
        });
        if (rtHbar.isVisible()) {
            AnchorPane.setBottomAnchor(boundCol, 29.0);
        } else {
            AnchorPane.setBottomAnchor(boundCol, 5.0);
        }

we need to detect if a report is open and close it first before re-rendering it.

almost there !

two minor issues:

right-hand scroll bar overlays last column
selected row text colors vary black and white between first column and balance of columns

updated again - reports columns should look good now.

Excellent!
Am making issue out of scrollbar overlay.


First  Pull-request

created a branch, created a file and made a commit, and opened a pull request


Audio Mode Toggler

Description:

Implemented a toggle button to switch between Single and Multiple Audio Modes.
In Single Mode, only one audio card can play at a time; starting a new card pauses the previously playing one.
In Multiple Mode, multiple audio cards can play simultaneously; clicking on the same card toggles play/pause.
Refactored state management to track the currently playing card in Single Mode.
Ensured volume control functionality works as expected in both modes.

Please resolve merge conflicts @GnautSpace

Please resolve merge conflicts @GnautSpace

Closing this PR due to merge conflicts to avoid confusion. I appreciate your time and effort in reviewing it, and I’ll submit a new PR with the necessary updates shortly!


New version: pavlobu.deskreen version 2.0.3

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


(maint) Simplify boltdir and config loading

Previously, the config class had functionality whereby defaults could be
set by passing a hash to the initialize method. This was only used for
tests, and complicated the config class by adding another level to the
"hierarchy". It also interacted in confusing ways with settings whose
defaults were already somewhat dynamic (anything depending on boltdir).
We also previously built the config object up incrementally, instantiating
it with optional default overrides, and then later parsing a config file,
and then overriding CLI options. This meant several intermediate steps
before getting to the final value of the config.
The config object now takes a config data hash (which is the result of
loading the config file) as well as an optional hash of overrides (which
are the result of processing the CLI arguments). This allows the entire
final state of config to be computed immediately, and it also provides a
way for tests to override settings by the same mechanism that users do.
This also introduces a Boltdir class that captures the particular behavior of
the Boltdir, separate from the config class. The config takes a Boltdir during
initialization and uses the Boltdir to determine some of its defaults.
We now accept only one of --configfile or --boltdir. If --boltdir is used,
then the config file will be read from /bolt.yaml. If
--configfile is specified, then boltdir will be set to the parent dir of
the config file. The default behavior when neither is specified remains the
same: boltdir will be found in the current directory hierarchy, or it will
fall back to ~/.puppetlabs/bolt.

CLA signed by all contributors.

Pushed a commit to replace all the Boltdir.new('') with Boltdir.new('.') for consistency.

👍 other than wanting a ticket for the bug fix.


Which license does this project use?

I wanted to ask which license your project has.

i have made it MIT

Thank you very much for your fast reply.


[fixes #22980] Migrate BeamFnLoggingClient to the new execution state sampler.

This fixes the logging issue to include the transform id.
There is now a public unit test that will prevent a similar regression in the future.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


Remove stray mapping

An issue was created regarding a stray mapping. I don't think there's a good reason to keep this around. If we wanted to keep around an entrypoint to calling that test method a better option might be to define an EX command. I just created this PR real quick if @tjdevries @rockerBOO or @glepnir want to just merge it.

@PatOConnor43  merged.


pip install after a new release installs the previous version

E.g. I have 1.0.1 installed and 1.0.2 is released on PyPi. If I then do a new pip install I won't get 1.0.2.
To get 1.0.2 I have to either do ==1.0.2 on the install or uninstall first.
Should:
Install newest version from PyPi.
Note: Any fix done here is also relevant for fmu-sumo-explorer

It works as expected if you do
pip install --upgrade sumo-wrapper-python
--- not sure if that's any help.

It works as expected if you do
pip install --upgrade sumo-wrapper-python
--- not sure if that's any help.

Better than having to specify version at least 👍
Though I usually expect an install without the --upgrade flag to also get the newest, so think it still is worth to investigate a bit.

I just checked, and if I do
pip install sumo-wrapper-python==1.0.2
followed by
pip install sumo-wrapper-python
I end up with 1.0.2. I think that if you specify a version, then that is going to stick… not sure what would happen if you specified
sumo-wrapper-python>=1.0.3
and then did a
pip install sumo-wrapper-python
after a newer version was released.

On 27 Oct 2023, at 10:54, Runar Ask Johannessen @.***> wrote:
It works as expected if you do
pip install --upgrade sumo-wrapper-python
--- not sure if that's any help.
Better than having to specify version at least 👍
Though I usually expect an install without the --upgrade flag to also get the newest, so think it still is worth to investigate a bit.
—
Reply to this email directly, view it on GitHub https://github.com/equinor/sumo-wrapper-python/issues/164#issuecomment-1782548347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDQORECQX2UZN6XYROHE3YBNZGHAVCNFSM6AAAAAA6Q76XSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBSGU2DQMZUG4.
You are receiving this because you commented.

I just checked, and if I do pip install sumo-wrapper-python==1.0.2 followed by pip install sumo-wrapper-python I end up with 1.0.2. I think that if you specify a version, then that is going to stick… not sure what would happen if you specified sumo-wrapper-python>=1.0.3 and then did a pip install sumo-wrapper-python after a newer version was released.

Specifying version seems not ideal then...
But what I remember to have happened is that I installed using pip install sumo-wrapper-python and got a version e.g. 1.0.2.
Then we released a version 1.0.3 I still got 1.0.2 when doing a new pip install sumo-wrapper-python.
But adding the --upgrade flag might actually be a more correct way of doing it?


Update version: CologneCodeCompany.XYplorer version 26.20.0300

Pull request has been created with komac v2.6.0 :rocket:

Resolves #186075

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


consul-template watcher for updating variables.

Use the consul-template watch code to actually listen for changes to Consul code instead of polling every so often.
Closes #18

@thrawn @twoism

@abhiyerra can we get some tests on this please?

LGTM after you address @rodaine's comments.

Most all of this code was taken from the consul-template codebase. So just an fyi on why it looks like what it is.


Resulticks-OpenZiti Project

o	Project Name - Resulticks
o	Link to the project site - https://www.resulticks.com/
o	Description of project - Resulticks Zero Trust API delivery network which forms the core of Resulticks' omnichannel marketing automation platform is built on OpenZiti to form a private dark mesh network.
o	Link to logo - https://www.resulticks.com/assets/platform/logos/resulticks-logo-blue.svg

Thanks @ResulticksInc, I'll put up a pr for the adopters.md page and we'll get that merged

Thank you @ResulticksInc for being part of the journey with Ziti. More to come!

when merged, it will appear like this:


ITS-3618 | Handle API1694 optional fields required by our journey

Stubs PR: https://github.com/hmrc/sca-nino-stubs/pull/65

Note: This will require Welsh translations.


support reading yaml openapi files

it would be great if yaml formatted openapi files was natively supported instead of having to convert them.

I support that issue, as I think using yaml became the leading format für OpenAPI.

+1 on this


Test Coverage is Gud

I was planning to cover Zoloto in this PR also, but in lieu of #402, I'm not going to bother for now.


Fixing Nancy.Viewengines.Razor NuGet package support for Mono on Linux

I ran into issue #1082 and I couldn't get the PostBuildEvent and CustomCommands to play nicely and consistently across all platforms.
Replacing the PostBuildEvent with an AfterBuild target seems to work everywhere (tested on VS 2012, Xamarin on Windows 8 and xbuild on Debian), but of course there are minor issues.
The solution consists of a targets file, which upon installation will automatically be added to the project file by NuGet.
To have the BuildProvider immediately available, there is a small addition to the installation script. Install.ps1 gets the active configuration, checks if it is a debug config and copies the files to the output dir.
Unfortunately this doesn't work when building with package restore. When the build starts the targets file is not available for import and so even after the package is installed the AfterBuild target is not executed.
NuGet also doesn't clean up the project file when uninstalling, which is covered by the Exists condition but still isn't very neat.
Maybe some additional tweaks are possible to get the PostBuild event to work only within visual studio, perhaps using the VisualStudioVersion property as a condition.
Any thoughts?

Nuget 3.x will deprecate install.ps1/uninstall.ps1 so we will revisit this to support the new infrastructure http://blog.nuget.org/20150729/Introducing-nuget-uwp.html


buildGoModule: alias vendorSha256 to vendorHash

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

cc @NixOS/golang @ajs124

Maybe a dumb question, but what's the advantage of doing this over a blanket change to vendorHash? Is it to avoid issues with stuff in the wild?

Yeah, to outright remove it is kind of a hassle and really needs to be done with a deprecation over a release cycle.

@ShamrockLee I'd like to merge this first as it'll make the subsequent PRs simpler if we don't need to handle _unset and only need vendorSha256 in a couple of places.


Define process for the "proposals" directory

Currently there is an open PR (#3369) adding a new proposal to the /proposals directory.  There is also an issue (#3372) which at first glance is just the proposal pasted into an issue after the PR stalled.  And there is also a discussion (#3371) with minimal information linking back to the PR (but not the issue).
Setting aside the contents and merit of that specific proposal, what is supposed to happen here?  Should this currently be a discussion, an issue, or a PR?  The question of what should be an issue or discussion is also part of OAI/OpenAPI-Specification#3518, but the proposals directory makes it look like you can just file a PR to make a proposal.  Is that what we want, or do we only want PRs for proposals that gain a certain amount of traction?
As it is, I think both the person making this proposal and those of us who have tried to figure out what to do with the PR are too confused to do anything with it.

I like the idea of a proposal as a pull request, because it needs an owner/champion to drive it forward, rather than just make suggestions and then ask us why we haven't done it yet. There's a bit about the process in https://github.com/OAI/OpenAPI-Specification/blob/main/DEVELOPMENT.md but I thought there was a template and that sort of thing for the proposal document and I can't immediately find that.

See also:

#1905

Looking more into how the proposal process actually works, it looks like the webhooks proposal might be the only feature to have made the whole journey (and the proposal status is still "Draft", oops!) so I dug through the history of that change to get some idea of how this could work.

#2103  is the pull request that introduced the actual changes to the spec.
#1974 is the pull request that added the proposal to the spec, looks like that was discussed, updated, and then merged before the feature was actually added to the specification itself.

I note that there were minimal changes between what was in the proposal and what we actually opened as a pull request to the spec - so the proposal was a ready-to-use idea, that was merged and then the specification modifications were made at that point.
In the meeting today we discussed the proposal for experimental fields to be added: #2386. In my opinion, the proposal is in good enough shape to be accepted as a proposal in the proposals directory and discussed further. What isn't clear is whether the discussion happens at this stage where the proposal pull request is open (which actually does make sense even though that's not what I said we should do earlier!), or if the proposal should be merged, and then iterated on before it gets a green light for implementation. And since nobody knows, we can decide all over again how this should work and one of us will write it down!

@lornajane Thanks for looking into this - that all makes sense.
I'm generally of the opinion that PRs should be reserved for things where we already have agreement, so that the only discussion in a PR is "does this correctly implement the agreement?"
My rationale is that a long PR list makes it look like a project is not very active.  Our PR list as of late last year gave that impression – correctly!  So PRs that end up in long debates add way more conceptual clutter than an issue or discussion held open for the same amount of time.
I'd prefer to see a low bar for accepting a proposal into the repo with an initial PR, and follow-up PRs as we discuss and make changes.  It's also possible that we could replace the proposals directory with discussions if we:

make discussions only about open-ended proposals and large topics
make issues only about relatively actionable things
make PRs only about doing things that are already agreed-to
move community Q&A to other places

This is essentially what we're doing in OAI/sig-moonwalk (except there isn't any community Q&A), and it's much easier to see what is happening.
I don't think GitHub discussions existed when we started the proposals process, so we needed a better place to put bigger discussions.  It might be that we don't really need that now.

Copying @lornajane 's comment from https://github.com/OAI/OpenAPI-Specification/issues/3614#issuecomment-1984137500:

We should start new ideas off as discussions on this repository, once general agreement is reached, those ideas can become a proposal in a pull request. The proposal has a formalised format, which means we can then use it to make changes to the specification, so it's a good outcome. The idea is to have something that just needs polishing once it's in proposal format.

I feel like we're converging on a process, but given that we have some cleanup to do on our process documentation, where can I put a document about proposals? Maybe I can add it to the DEVELOPMENT doc for now but shout if that seems like a terrible solution to anyone.

I think #1862  is also relevant


Investigate transient invalid state in map and array vectors

A recent change (#3078) attempted to add validity checks for map and array vectors which checked that the values inside offset and size buffers pointed to valid locations in the elements/keys/values vectors.
This resulted in a lot (~180) of test failures where this check was violated.
Therefore, filing this issue to investigate the nature of these violations and fix them.

cc: @Yuhta @oerling

I ran all the tests on my local and tried to narrow down the root cause for each.
TLDR: the issue is that the API for array and maps allows mutable access to the inner keys/values and this culminated to a pattern where the vector is created first in an invalid state and later the right values and sizes are populated into its child vectors. Some of the failures have easy fixes and some don't, but even after we fix all of them, there is no guarantee that the vector will never get into an invalid state since those underlying vectors or buffers can still be manipulated after construction.
Suggestion: This might a necessary evil since direct access to underlying state is necessary for manipulation used across the code base. What we can perhaps do it use this consistency check (mentioned in the top post) as a utility method that we can use as a DCHECK() in places where we want to be sure they make sense before we operate on a vector.
Details on some of the failed tests:

velox_vector_test
Reason:
Looks like it uses BaseVector::create() to create a fixed size array that has pre-filled offsets and sizes but an empty values vector. This values vector is then filled later on by copying values from another array.

[  FAILED  ]  VectorTest, fixedSizeArray

velox_dwio_dwrf_column_reader_test
Reason:
creating an array then manipulating the values later. In MapColumnReader::next() and ListColumnReader::next() at the end it checks for Children the recursively fills it

    115: [  FAILED  ] 24 tests, listed below:
    115: [  FAILED  ] TestColumnReaderNoReuse/TestColumnReader.testList/0, where GetParam() = 2-byte object <00-00> => creating an array then manipulating the values later
    115: [  FAILED  ] TestColumnReaderNoReuse/TestColumnReader.testMap/0, where GetParam() = 2-byte object <00-00>
    115: [  FAILED  ] TestColumnReaderNoReuse/TestColumnReader.testLargeSkip/0, where GetParam() = 2-byte object <00-00>
    115: [  FAILED  ] TestColumnReaderNoReuse/TestColumnReader.testListVectorTypeChange/0, where GetParam() = 2-byte object <00-00>
    115: [  FAILED  ] TestColumnReaderNoReuse/TestColumnReader.testMapVectorTypeChange/0, where GetParam() = 2-byte object <00-00>
    115: [  FAILED  ] TestColumnReaderReuse/TestColumnReader.testList/0, where GetParam() = 2-byte object <00-01>
    115: [  FAILED  ] TestColumnReaderReuse/TestColumnReader.testMap/0, where GetParam() = 2-byte object <00-01>
    115: [  FAILED  ] TestColumnReaderReuse/TestColumnReader.testLargeSkip/0, where GetParam() = 2-byte object <00-01>
    115: [  FAILED  ] TestColumnReaderReuse/TestColumnReader.testListVectorTypeChange/0, where GetParam() = 2-byte object <00-01>
    115: [  FAILED  ] TestColumnReaderReuse/TestColumnReader.testMapVectorTypeChange/0, where GetParam() = 2-byte object <00-01>
    115: [  FAILED  ] TestSelectiveColumnReader/TestColumnReader.testListVectorTypeChange/0, where GetParam() = 2-byte object <01-00>
    115: [  FAILED  ] TestSelectiveColumnReader/TestColumnReader.testMapVectorTypeChange/0, where GetParam() = 2-byte object <01-00>
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testListWithNulls/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testListSkipWithNulls/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testListSkipWithNullsNoData/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testMapWithNulls/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testMapSkipWithNulls/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderNoReuse/TestNonSelectiveColumnReader.testMapSkipWithNullsNoData/0, where GetParam() = false
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testListWithNulls/0, where GetParam() = true
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testListSkipWithNulls/0, where GetParam() = true
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testListSkipWithNullsNoData/0, where GetParam() = true
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testMapWithNulls/0, where GetParam() = true
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testMapSkipWithNulls/0, where GetParam() = true
    115: [  FAILED  ] TestNonSelectiveColumnReaderReuse/TestNonSelectiveColumnReader.testMapSkipWithNullsNoData/0, where GetParam() = true

Velox_dwrf_column_writer_test
Reason is same as before:
creating an array then manipulating the values later. In MapColumnReader::next() and ListColumnReader::next() at the end it checks for Children the recursively fills it

velox_dwrf_e2e_writer_test
Reason is same as before:
creating an array then manipulating the values later. In MapColumnReader::next() and ListColumnReader::next() at the end it checks for Children the recursively fills it

    122: [  FAILED  ] E2EWriterTests.E2E
    122: [  FAILED  ] E2EWriterTests.FlatMapDictionaryEncoding
    122: [  FAILED  ] E2EWriterTests.fuzzComplex
    122: [  FAILED  ] E2EWriterTests.fuzzFlatmap
    122: [  FAILED  ] E2EEncryptionTest.EncryptSelectedFields

velox_aggregates_test
Reason:
Wrong size of values vector create, the offset is 0 and size 3 but the values vector is a dict of size 1

        132: [  FAILED  ] ApproxPercentileTest.invalidEncoding

Velox_exec_Test
Reason:
PrestoSerializer::readMapVector creates a map vector then manipulates the offsets and sizes later on.

    139: [  PASSED  ] 471 tests.
    139: [  FAILED  ] 22 tests, listed below:
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilFew/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilFew/1, where GetParam() = 8-byte object <00-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilFew/2, where GetParam() = 8-byte object <03-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilFew/3, where GetParam() = 8-byte object <03-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilMost/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilMost/1, where GetParam() = 8-byte object <00-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilMost/2, where GetParam() = 8-byte object <03-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spilMost/3, where GetParam() = 8-byte object <03-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spillAll/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spillAll/1, where GetParam() = 8-byte object <00-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spillAll/2, where GetParam() = 8-byte object <03-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.spillAll/3, where GetParam() = 8-byte object <03-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.error/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.error/1, where GetParam() = 8-byte object <00-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.error/2, where GetParam() = 8-byte object <03-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/NoHashJoin.error/3, where GetParam() = 8-byte object <03-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/0, where GetParam() = 8-byte object <00-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/1, where GetParam() = 8-byte object <00-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/2, where GetParam() = 8-byte object <01-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/3, where GetParam() = 8-byte object <01-00 00-00 08-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/6, where GetParam() = 8-byte object <03-00 00-00 00-00 00-00>
    139: [  FAILED  ] SpillerTest/AllTypes.nonSortedSpillFunctions/7, where GetParam() = 8-byte object <03-00 00-00 08-00 00-00>

ApproxPercentileTest.invalidEncoding this is a typo, I can fix it


Edited texture.glsl to work properly with textures...

Describe the issue (if no issue has been made)
This is a pull for the latest game-engine-series video, which changes the shader in order to properly show textures that aren't the standard white!
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve: None

Impact
Issue/PR

Issues this solves
None or #number(s)

Other PRs this solves
None or #number(s)

Proposed fix (Make sure you've read on how to contribute to Hazel)
A short description of what this fix is and how it fixed the issue you described.
Additional context
Add any other context about the solution here. Did you test the solution on all (relevant) platforms?
If not, create a task list here.

Sorry @TheCherno  i had to fight this commit in order to make the changes only show the Texture.glsl and not the changes you last made with your last commit.


Scatter plot support

Feature Request
Scatter plot is available and fully featured.
Spectrum scatter plot design guidelines
Scatter Plot Anatomy
https://spectrum.corp.adobe.com/page/scatter-plot/#Anatomy

API
Need to add a SymbolSize type. This should be similar to the line width type and should have a utility type that will return the number value for any symbolSize value (see getLineWidthPixelsFromLineWidth() for example).
Symbol sizes are the area of the symbol in square pixels. So the default 100 = 10px x 10px. 256 = 16px x 16px.
XS = 36
S = 64
M = 100 (DEFAULT_SYMBOL_SIZE)
L = 144
XL = 256
/**
 * Symbol sizes represent the area of the symbol in square pixels.
 * 100 = 10px x 10px.
 * {@link https://vega.github.io/vega/docs/marks/symbol/}
 */
export type SymbolSize = 'XS' | 'S' | 'M' | 'L' | 'XL' | number;

export type SymbolSizeFacet = FacetRef<SymbolSize>;

Should add the Scatter component with the following props API.
export interface ScatterProps extends Omit<MarkProps, 'color'> {
	/**
	 * point fill and stroke color
	 * uses a key in the data that will map to the color scale or a static color value
	 */
	color?: ColorFacet;
	/**
	 * type of color scale that should be used for the points
	 * use ordinal if the key used for `color` maps to string values ('UT', 'CA', 'NY', etc.)
	 * use linear if the key used for `color` maps to numeric values (0, 1, 2, etc.)
	 */
	colorScaleType?: 'linear' | 'ordinal';
	/** data key for the x-axis */
	dimension?: string;
	/** line width around each point */
	lineWidth?: LineWidth;
	/** point fill and stroke opacity */
	opacity?: number;
	/**
	 * point size
	 * uses a key in the data that will map to the size scale (linear) or a static size value
	 */
	size?: SymbolSizeFacet;
}

Expected Behavior

metric is always the y-axis
dimension is always the x-axis
Hovering the chart should highlight the nearest point by lowering the opacity of all other points by 1/5th (1/HIGHLIGHT_CONTRAST_RATIO) (if tooltip exists)
Selecting an arc should add a blue selection ring around the selected point (if popover exists)
Selecting a point should display a popover above the point (if popover exists)
Selecting a point should lower the opacity of all other points by 1/5th (1/HIGHLIGHT_CONTRAST_RATIO) (if popover exists)
Overlapping points should use should use the multiply blend mode

blend: {value: 'multiply'}

Should not display null values

Implementation
Start by identifying how to build out the vega spec for a spectrum scatter plot (I'll attach a good starting point in the comments below). There are multiple scatter plot examples in the vega example gallery as well.
Once the spec is in a good place and you are ready to implement, do the following:
Note: For each of the following, follow the patterns established by Bar, Line and Area.

Add a Scatter component to the components/ folder.
Create a Scatter.stories file in the stories/ folder and add stories demonstrating each prop.
Setup the scatter/scatterSpecBuilder.ts in the specBuilder/ folder.
Follow all the coding patterns that have been established.
Add the addScatter function to the reduce in chartSpecBuilder.ts.

Here is a good starting point for the scatter plot spec. This is created from the scatter example in the vega examples gallery.
This does not use the spectrum text or color theming but you get those for free with the specBuilder.
Try copying and pasting the full spec into the vega editor and make sure that the type of spec is set to Vega in the top left.

{
  "$schema": "https://vega.github.io/schema/vega/v5.json",
  "description": "A basic scatter plot example depicting automobile statistics.",
  "width": 200,
  "height": 200,
  "padding": 5,

  "data": [
    {
      "name": "source",
      "url": "data/cars.json",
      "transform": [
        {
          "type": "filter",
          "expr": "datum['Horsepower'] != null && datum['Miles_per_Gallon'] != null && datum['Acceleration'] != null"
        }
      ]
    }
  ],

  "scales": [
    {
      "name": "x",
      "type": "linear",
      "round": true,
      "nice": true,
      "zero": true,
      "domain": {"data": "source", "field": "Horsepower"},
      "range": "width"
    },
    {
      "name": "y",
      "type": "linear",
      "round": true,
      "nice": true,
      "zero": true,
      "domain": {"data": "source", "field": "Miles_per_Gallon"},
      "range": "height"
    },
    {
      "name": "color",
      "type": "linear",
      "round": true,
      "nice": false,
      "zero": true,
      "domain": {"data": "source", "field": "Acceleration"},
      "range": ["red", "blue"]
    }
  ],

  "axes": [
    {
      "scale": "x",
      "grid": true,
      "domain": false,
      "orient": "bottom",
      "tickCount": 5,
      "title": "Horsepower"
    },
    {
      "scale": "y",
      "grid": true,
      "domain": false,
      "orient": "left",
      "titlePadding": 5,
      "title": "Miles_per_Gallon"
    }
  ],

  "legends": [
    {
      "fill": "color",
      "title": "Acceleration",
      "format": "s",
      "symbolStrokeColor": "#4682b4",
      "symbolStrokeWidth": 2,
      "symbolOpacity": 0.5,
      "symbolType": "circle"
    }
  ],

  "marks": [
    {
      "name": "marks",
      "type": "symbol",
      "from": {"data": "source"},
      "encode": {
        "update": {
          "x": {"scale": "x", "field": "Horsepower"},
          "y": {"scale": "y", "field": "Miles_per_Gallon"},
          "fill": {"scale": "color", "field": "Acceleration"},
          "shape": {"value": "circle"},
          "strokeWidth": {"value": 2},
          "opacity": {"value": 0.6},
          "blend": {"value": "multiply"}
        }
      }
    }
  ]
}


Update README.md due to typo

typo in chain
The Problem

The Solution

Checklist

[ ] Test manually on test-ui using remote chains.
[ ] Run load tests.
[ ] Update documentation if needed.
[ ] Update CHANGELOG.md.

Thanks for catching this!


Adding multipart copy

Fixes #106

As per the copy part request factory  the last byte is defined offset + size - 1 /cc @jystic factories to the rescue

initial perf ~ 5-6 x aws-cli/1.9.7

Will probably push this throw then do another pass to ensure all the error types are accurate

Surface :+1:


Cannot navigate to invalid URL is unclear, should also print the URL itself

Bug report

Node Version: v9.4.0
Protractor Version: 5.3.0
Angular Version: 1.5.11
Browser(s): Chrome
Operating System and Version MacOS 10.13.3
Your protractor configuration file
https://gist.github.com/benjaminapetersen/584f011d6ba8f9f4b37b67f11ba3ab11
A relevant example test

const env = require('../environment');
const doLogin = require('../helpers/doLogin');
const CatalogPage = require('../pageobjects/catalog');
const LocalStorage = require('../pageobjects/localStorage');
const timing = require('../helpers/timing');

beforeEach(() => {
  browser.ignoreSynchronization = true;
});

describe('Openshift login page', () => {
  describe('bypass OAuth with service account token', () => {
    it('should bypass the login flow by injecting a service account token into localStorage', () => {
      // an image or css file load initially won't trigger the oauth redirect.
      // this should let us inject a token if we already have it.
      // useful for systems that support multiple oauth flows
      // where testing each form is unnecessary
      browser.get('/path/to/favicon.png');
      storage.setItem('storageKeys.token', tokenString);
      // now, load a page
      browser.get('path/to/catalog');
      const catalogHeading = element(by.css('h1'));
      expect(catalogHeading.getText()).toBe('Browse Catalog');
    });
  });
});

Output from running the test

      ✗ should bypass the login flow by injecting a service account token into localStorage
        - Failed: unknown error: unhandled inspector error: {"code":-32000,"message":"Cannot navigate to invalid URL"}
          (Session info: chrome=65.0.3325.181)
          (Driver info: chromedriver=2.37.544337 (8c0344a12e552148c185f7d5117db1f28d6c9e85),platform=Mac OS X 10.13.3 x86_64)

Steps to reproduce the bug
$(yarn bin)/protractor protractor.conf.js
The URL you are running your tests against (if relevant)
n/a

Feature Request
The error output simply says Cannot navigate to invalid URL.  But for a system that visits a number of urls, having an error this generic is not helpful.  At this point, the URL itself should also be logged, to give users the ability to track down & isolate the problem in code.
Thanks for considering!

IMHO this should be implemented in the test itself something like
browser.get(<someURL>).then(() =>{
console.log(
}).catch(err) => {
console.error(`Failed to navigate to ${browser.getCurrentUrl}`)
})

So a .catch() on every navigate?  I don't necessarily have a problem with that, however, I do think the error could/should be still improved.

What we do in our framework is we have defined a Base PageObject which has the navigate method and we have implemented navigate there and also other PageObject extends the Baseclass this way you need not implement catch in every PageObject
class BasePage {

loadUrl(url) {
browser.get(<someUrl>).then(() =>{
console.log(`Loaded ${someUrl}`)
}).catch(err) => {
console.error(`Failed to navigate to ${browser.getCurrentUrl}`)
});

 }

}

module.exports = BasePage;

Now a new PageObect let's say LoginPage will extend the base class
class LoginPage extends BasePage {
constructor() {
}

loadLoginPage(){
const self = this;

self.loadUrl(loginUrl);
}

}
module.exports = LoginPage;


Extend current graphite and Zabbix monitoring framework to support non-jmx data

Currently, the graphite data is grouped in logical groups for Hadoop. The graphite queries  which fetch data, do it considering these logical groups and send aggregate data for all hosts in that group to Zabbix. In Zabbix, hosts are the logical groups which encompass individual hosts of same type; for e.g.: hbase_master represents all hbase masters. All this was designed to work with JMX data for hadoop components.
Now, if one wants to monitor and alarm on data collected by other means (say diamond) and wishes to trigger for individual hosts, the current framework does not work. Changes need to be made so arbitrary hosts can be monitored using graphite and Zabbix.

PR #187 has been closed. Resolving this.


Add new gpg key use to sign Jenkins package

The gpg key used to sign Jenkins packages was updated on 16th of April 2020, therefore you need to reimport it if you imported before this date.
I have left the old key import as well in case it used elsewhere.
See: https://pkg.jenkins.io/debian/

Ping

@gavinfish - are you still an owner on this repo?

@gavinfish - are you still an owner on this repo?

@xuzhang3 may take a look.


Update example.cc to fix error

error: missing initializer for member 'Satsuma::BiMDFSolverConfig::double_cover' [-Werror=missing-field-initializers]

modules/bimdf/bimdf.cpp:65:3: error: ISO C++ requires field designators to be specified in declaration order; field 'matching_solver' will be initialized after field 'double_cover' [-Werror,-Wreorder-init-list]
                .double_cover = Satsuma::BiMDFDoubleCoverConfig(),
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
modules/bimdf/bimdf.cpp:64:22: note: previous initialization for field 'matching_solver' is here
                .matching_solver = Satsuma::MatchingSolver::Lemon,
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Still working on it.


[Log] Mixin config Error - 1.20.1

When starting up the game, you will get the following error message in the logs(latest.log).
"Mixin config azurelib.mixins.json does not specify "minVersion" property"
and also this message
"Mixin config azurelib.forge.mixins.json does not specify "minVersion" property"

That's a non issue and doesn't affect anything, can be disregarded


how much gpu memory is required to train the model?

We train the model using H800 80G GPUs. A100 40G should also be enough for training.


//tests/e2e/tests/simple:go_default_test is flaky

I keep on having to rerun the test.
Here is an example
https://storage.googleapis.com/istio-prow/pull/istio_istio/1225/e2e-suite-rbac-no_auth/1366/build-log.txt
@ldemailly  originally wrote the test but is out. @ijsnellf Could you take a look at it since you are on call.

It wasn't flacky before - what changed ?

Could just be that the network got a little flaky, or things started taking longer to spin up. The issue is that the tests fail if any of the kubectl commands fail, which means one random getsockopt will cause everything to fail. I think we just need to have some retry logic.

I'm back. is it still happening ?
for kubectl retries if needed - I think the retry logic should be in the e2e framework so it's done once for all tests

Hi @ldemailly can we close this if no one is looking into it and it is not happening right now ?

or reduce the priority to p2 or something.

I haven't seen the flackyness - sadly I don't know if those important tests are still running


BUG: Cannot parse a specific Android Vector Drawable

Hello, I was trying to parse this simple vector drawable:
<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="108dip" android:width="108dip" android:viewportWidth="432" android:viewportHeight="432">
    <path android:fillColor="#ff1877f2" android:pathData="M231.7,129.6c-14,3.4 -26.2,12.8 -31.7,24.6 -5.3,11.4 -6,16.1 -6,40l0,21.8 -18.5,-0 -18.5,-0 0,21 0,21 18.5,-0 18.5,-0 0,87 0,87 22,-0 22,-0 0,-87 0,-87 17.3,-0 17.3,-0 2.8,-19.2c1.6,-10.6 3.1,-20.1 3.4,-21 0.4,-1.7 -1,-1.8 -20.3,-1.8l-20.7,-0 0.4,-16.3c0.3,-12.4 0.9,-17.1 2.2,-20.2 4.2,-9.7 10,-12.5 27.3,-13.3l12.3,-0.5 -0.2,-17.6 -0.3,-17.6 -9,-1.2c-12.3,-1.6 -31.7,-1.5 -38.8,0.3z"/>
</vector>

This is how it should look like (rendered in Android Studio):

But the library instead renders an empty icon without failing or printing any error; I have no idea why... could you look into this?

Thanks.  The issue is that jovial_svg should have been ignoring the width and height attribute of the AVD file.  They don't specify the width and height of the AVD.  I think they probably specify a default rendering width and height for the user agent, which is irrelevant to this library.
The AVD file syntax is well-specified by Google, but the rendering semantics aren't.
Anyway, for now you can just nuke the width and height attributes in your AVD file.  I'll spin a jovial_svg release relatively soon with this fix in it.

Thanks.  The issue is that jovial_svg should have been ignoring the width and height attribute of the AVD file.  They don't specify the width and height of the AVD.  I think they probably specify a default rendering width and height for the user agent, which is irrelevant to this library.
The AVD file syntax is well-specified by Google, but the rendering semantics aren't.
Anyway, for now you can just nuke the width and height attributes in your AVD file.  I'll spin a jovial_svg release relatively soon with this fix in it.

@zathras Thanks, I think the width/height aspect ratio is probably all that matters

^ Icon on android studio with width = (1/2) * height

^ Icon on android studio with height = (1/2) * width

Good point.  A 100% complete implementation of android vector drawables would need to do that.
I looked into it, and it would be pretty tricky to pull off.  But more to the point, I don't think this is a very important thing to support for AVDs - AFAIK AVDs are mostly useful for the little icons that come with the Android environment, and other, similar things that would never use scaling in this way.  I could be wrong, and I'd be happy to reconsider if you or someone else could show me someone actually using this parameter in this way, for something non-contrived...  But if someone is authoring assets, the under-specified, hacky AVD format would be an odd choice, given how much more capable, specified and well-supported SVG is.
Changing the aspect ratio like that is a weird, limited subset of what one can do with a proper transform matrix.  In SVG, for example, you could just put a group with a transform at the top of the tree, and do scaling and translation (and shear, for that matter).  Just doing scale without the ability to do translation is... of limited value.
About it being tricky:  The thing is, AFAIK AVD files aren't required to specify a viewportWidth and viewportHeight.  But you need to know that, in order to know the scale factor.  That means that you potentially have to parse the whole AVD, calculate the viewport size (the extent of the AVDs drawing), then compare that to the scaled width and height, and apply any needed scaling factor.  Applying a scaling factor to an SI instance would be non-trivial.  I question if it would be worth it, especially since SVGs are so much more capable, and are the main target of this library.
But this limitation should be documented.  I'll put it in the README, with a link to this issue.

@zathras Provided I know nothing about rendering vector icons, let's assume the android:width is half of the height, can't you just divide the viewportHeight by 2 along with the y coordinate of each point?

@zathras Thanks. As you've said I've yet to encounter an apk icon (what I use this library for) that makes use of this aspect-ratio feature, so I guess 100% compliancy would have little benefit.

@alesimula About dividing by two, etc...  Yes, running down the tree and transforming individual points would be the starting point for one way of implementing it.  Even that would take some care to get right, since there are two internal representations (DAG tree and compact), and they both canonicalize identical subtrees down to a single subtree (hence "directed acyclic graph," and not "tree").  Then, if AVD has outline width (it does, doesn't it?  I'd have to check to be sure), something would have to be done about that...  I assume that the AVD behavior in that case would be the same as a scaling transform, that is, horizontal lines would come out a different thickness than vertical lines, and angled lines somewhere in between.
Oh, wait, assuming that's true, then the transform-points-down-the-graph approach would be impractical, and the only choice would be to put a scaling transform at the top of the tree.  That's certainly doable.  In the in-memory DAG representation it's at least straightforward; in the compact representation, it turns into a bit of a mess.  It is possible, but it's an awful lot of trouble for a little-used (and maybe never used) feature of a secondary format for the library.

I guess I'm too much of an obsessive-compulsive software engineering type to leave that undone.  I really doubt it's of value, but implementing AVD scaling in the (normal? required?) case where viewportWidth and viewportHeight are specified does no harm.

@zathras lol I feel ya

Released in 1.0.8


include readme md in module docs iso6

Iso6 specific PR for https://github.com/inmanta/inmanta-core/pull/7861
Part of https://github.com/inmanta/irt/issues/2026
Overview in https://github.com/inmanta/inmanta-sphinx/pull/70
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Description

Short description here *

closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches iso6 in bd7bfc05f85696ce78fdad9f1ef3ab5ac5e891db


Unknown hard error [BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
for some reason, whenever i use bloxstrap to open up roblox, i am met with a 'hard error'. i have tried to launch roblox without bloxstrap and it works. and yes, i have tried reinstalling ALL files and folders for both roblox and bloxstrap and have fixed all errors in my windows through commands. not sure what to do.

logs?

Can you show a screenshot please?


SUBMARINE-427. [SDK] Add Neural Factorization Machine model

What is this PR for?
Add TensorFlow implementation of Neural Factorization Machine model
There are some common tf layer in ctr model, put common layer to core.py
make code concise and development flexible
(will refactor deepfm and fm in next Jira ticket)
What type of PR is it?
[Improvement]
Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-427
How should this be tested?
https://github.com/pingsutw/hadoop-submarine/actions/runs/58067991
https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/663851273
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Will merge if no more comments.


config.build() should return the built object

config.build() should return the built object as well as simply building the local file

Perhaps we should add a flag for writing the file locally or not. It should always return the built object though.


Update to Bootstrap 5

Migration Guide
gridcoin-community/Gridcoin-Site#332 PR on .us

@nathanielcwm please assign it to me


php5.6 mcrypt is missing

Describe the bug

php5.6 mcrypt is missing
PHP versions

php5.6.40_5
To Reproduce

Expected behavior

Screenshots/Logs

Additional context

Are you willing to submit a PR?

Please use shivammathur/extensions tap for mcrypt.
brew tap shivammathur/extensions
brew install<EMAIL_ADDRESS>


[R20-258] - Media embed

Issue: https://digital-vic.atlassian.net/browse/R20-258
What I did

Added new 'media-embed' and 'media-fullscreen' components
Added stories to cover all of the use cases
Added a new neutral colour alpha token, renamed the existing one and updated the reference to it.

How to test

Storybook

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[x] I have added a story covering all variants
[x] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

Hey @ChrisCampbellCodes, just noticed one minor thing, the complex image actions don't have the focus state. Cheers

Hey @ChrisCampbellCodes, just noticed one minor thing, the complex image actions don't have the focus state. Cheers

Hey @ChrisCampbellCodes, just checking, did you see this comment ^^


verimatrix

Hi,
Is verimatrix supported? I didn't find any reference in docs and not in the source code.
Thank you!

Hello,
Unfortunately verimatrix is not supported.
Until now, We estimate that verimatrix is an infrequently used DRM on Smart TV.
If request to support the verimatrix increase, we will consider it.
Now, If you want to support verimatrix, you need to realize by platform with this document.
Thank you.

can you support verimatrix drm on Tizen ?