Update kamon-core, instrumentations and reporters to 2.0.x.

Description
Versions prior to 2.0.x do not support Scala 2.13.
Related issue and scope
Ref #4741.
My changes affect the following components

[X] Data stores (e.g., CouchDB)
[X] Tests
[X] Deployment
[X] General tooling

Checklist:

[x] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[X] I added tests to cover my changes.

This contains a few potentially breaking changes that need discussion, especially around the PrometheusReporter (which should now be hosted on an implicit server at :9095) and the PrometheusRecorder.

Looking at code I believe if we programatically register a Module prior to Kamon.init then they would not get loaded per default settings. So in our case we can register the PrometheusReporter first and then call init which would allow us to retain the existing behaviour

Codecov Report

Merging #4768 into master will decrease coverage by 6.55%.
The diff coverage is 54.94%.

@@            Coverage Diff             @@
##           master    #4768      +/-   ##
==========================================
- Coverage   84.86%   78.31%   -6.56%
==========================================
  Files         198      198
  Lines        8836     8839       +3
  Branches      602      602
==========================================
- Hits         7499     6922     -577
- Misses       1337     1917     +580

Impacted Files
Coverage Δ

.../openwhisk/core/database/cosmosdb/cache/Main.scala
0% <0%> (ø)
:arrow_up:

...pache/openwhisk/core/monitoring/metrics/Main.scala
0% <0%> (ø)
:arrow_up:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0% <0%> (-100%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-93.85%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-96.23%)
:arrow_down:

...hisk/core/monitoring/metrics/OpenWhiskEvents.scala
93.75% <100%> (-0.37%)
:arrow_down:

...scala/org/apache/openwhisk/common/Prometheus.scala
100% <100%> (ø)
:arrow_up:

...core/database/cosmosdb/RetryMetricsCollector.scala
38.09% <100%> (-42.86%)
:arrow_down:

...nwhisk/core/monitoring/metrics/EventConsumer.scala
87.27% <100%> (ø)
:arrow_up:

...a/org/apache/openwhisk/http/BasicHttpService.scala
93.22% <100%> (ø)
:arrow_up:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb441ff...91ff04e. Read the comment docs.

@chetanmeh I managed to at least seemingly remove all blocking changes here. Do you have any testbed to test the prometheus based components or do you think the unit tests here are enough?

If I start the standalone jar built from this PR then I see all Kamon reporters are getting started.
[2019-12-23T10:30:01.796Z] [INFO] Started the Kamon Datadog reporter
[2019-12-23T10:30:01.881Z] [INFO] Started the Kamon DataDog span reporter
[2019-12-23T10:30:02.022Z] [INFO] Started the Kamon StatsD reporter

Not sure if same behaviour is happening in container mode also. Earlier we have only configured statsd to be default and started. Probably we would need to find a way to somehow disable "automatic" startup of the reporters?

May be Looking at how modules are now automatically registered. We may need to disable that per included module basis
kamon {
  modules {
    datadog-agent {
      enabled = false
    }
    datadog-trace-agent {
      enabled = false
    }
    statsd-reporter {
      enabled = false
    }
  }
}

Very good call @chetanmeh! I updated the configuration to reflect the status as it was before and verified that the Prometheus endpoint now actually ships data. I'll need to send a note to the dev-list on how configure the DataDog reporters after this change.

One more aspect to address - Currently for Standalone mode we disable all reporters and only keep Prometheus (done programatically). So we would need to disable statsd explicitly in standalone.conf
https://github.com/apache/openwhisk/blob/8eb922f568d7843cdb1068252d29ba5723b30283/core/standalone/src/main/resources/standalone.conf#L18-L22

I'm trying to test this PR, but the following exception occurs.
Have you ever had this problem? I'm analyzing the cause of the error.
Steps

hub pr checkout 4768
./gradlew distDocker
ansible-playbook -i environment/local controller.yml
tail -f /tmp/wsklogs/controller0/controller0_logs.log

Exception in thread "Host Metrics" java.lang.NoClassDefFoundError: Could not initialize class oshi.jna.platform.linux.Udev
        at oshi.hardware.platform.linux.LinuxDisks.getDisks(LinuxDisks.java:109)
        at oshi.hardware.platform.linux.LinuxHardwareAbstractionLayer.getDiskStores(LinuxHardwareAbstractionLayer.java:78)
        at kamon.instrumentation.system.host.HostMetricsCollector$InfrequentCollectionTask.recordStorageActivity(HostMetricsCollector.scala:177)
        at kamon.instrumentation.system.host.HostMetricsCollector$InfrequentCollectionTask.$anonfun$schedule$2(HostMetricsCollector.scala:131)
        at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
        at scala.concurrent.Future$.$anonfun$apply$1(Future.scala:659)
        at scala.util.Success.$anonfun$map$1(Try.scala:255)
        at scala.util.Success.map(Try.scala:213)
        at scala.concurrent.Future.$anonfun$map$1(Future.scala:292)
        at scala.concurrent.impl.Promise.liftedTree1$1(Promise.scala:33)
        at scala.concurrent.impl.Promise.$anonfun$transform$1(Promise.scala:33)
        at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:64)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

I've found the reason. The host metrics module was not explicitly disabled in the 2.x version.
Legacy configuration (1.x)
The following configuration is no longer supported. It should be removed
https://github.com/apache/openwhisk/blob/b26101b8dc0d7a2f48995cd81f12d5b2db10be46/common/scala/src/main/resources/application.conf#L84
    system-metrics {
        # disable the host metrics as we are only interested in JVM metrics
        host.enabled = false
    }

Latest version configuration (2.0.x)
To disable host metrics in the latest version, below configuration should be added
kamon.modules {
  host-metrics {
    enabled = no
  }
}

Reference
https://kamon.io/docs/latest/instrumentation/system/host-metrics/#disabling-the-module

@chetanmeh @upgle thanks for the input! I pushed a commit that should handle both comments.

LGTM 👍

Codecov Report
Attention: Patch coverage is 61.01695% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (8eb922f) to head (31f1a4f).
Report is 400 commits behind head on master.

Files with missing lines
Patch %
Lines

...in/scala/org/apache/openwhisk/common/Logging.scala
0.00%
7 Missing :warning:

...enwhisk/connector/kafka/KamonMetricsReporter.scala
0.00%
7 Missing :warning:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0.00%
3 Missing :warning:

...nwhisk/core/monitoring/metrics/KamonRecorder.scala
89.47%
2 Missing :warning:

.../apache/openwhisk/core/controller/Controller.scala
50.00%
1 Missing :warning:

.../openwhisk/core/database/cosmosdb/cache/Main.scala
0.00%
1 Missing :warning:

...la/org/apache/openwhisk/core/invoker/Invoker.scala
50.00%
1 Missing :warning:

...pache/openwhisk/core/monitoring/metrics/Main.scala
0.00%
1 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (8eb922f) and HEAD (31f1a4f). Click for more details.
HEAD has 29 uploads less than BASE

Flag
BASE (8eb922f)
HEAD (31f1a4f)

33
4

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4768      +/-   ##
==========================================
- Coverage   84.89%   78.59%   -6.30%
==========================================
  Files         198      197       -1
  Lines        8836     8839       +3
  Branches      602      619      +17
==========================================
- Hits         7501     6947     -554
- Misses       1335     1892     +557

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implement asynchronous messaging from router-> clients

Currently some listeners only supports request-reply pattern. These are

ClusterRequest / ClusterListener
RestRequest / RestListener

There needs to be some special handling to allow the server to write multiple messages to incoming requests. For the ClusterRequest this is simple, just write an async response on the bus. For the REST listener we could buffer responses and return them when polled (ping?)/piggybacking.
For the more persistent listeners, tcp/websocket we need some way to protect the local bus address of the connection. Is it enough that the addresses are randomized? Server sessions could be hijacked if the ID generation is too weak.
To improve performance when services are highly distributed the following is proposed

all responses sent to a client is encapsulated with a listener id.
a response to a request over the event bus is sent to a listener id, with some headers including a list of receivers local addresses. (make sure to check how to handle clients connecting from different listeners.)
reduces the number of event bus addresses registered on the global cluster.

Finally for the UDP listener, there needs to be an eventbus listener for each "connection". This is done in the same way as the vertx default behavior with tcp/websockets. Each connection is assigned an unique id, which is registered on the local event bus.

Service = client *

For asynchronous clients a single service may be employed, which are polled by clients. These events should have a shorter ttl, suitable for notifications. For longer ttl the service itself should store the data. For synchronous clients, the gateway could subscribe to the notification service. As an alternative, each router subscribes clients to cluster addresses: This might not be scalable as register/unregisters must propagate across the cluster.

Made an attempt at baking in async support in the ClusterRequest and BusRouter. I now believe this is a terrible idea. Melding the two modes of pushing data introduces a lot of complexity. Introduces scary corner cases, results in horrible code and generally gives you a bad day :tm:.
As a much better alternative i propose adding a Session to all requests. The session includes information on how to route to a specific listener and a specific connection. This also has other use cases as it can be used for handler->handler messaging.
How to implement the altenative solution
Add Request::session and include: listener id and request id, create a factory for creating asynchronous clustered messages. Session data is added by listeners, when requests are being constructed/forwarded.
The session contains

clustered event bus address of the source listener.
an id that is mapped to a request by the listener.

This requires the changing the following

all listeners which intend to support sessions (async messages TCP/Websock etc).
a factory to convert a single Session object into a clustered message.
async writers: stores references to a request session
use jvm-wide caching of sessions, implement hashCode appropriately and use computeIfAbsent.
implement a session store to allow sessions to expire?
implement functionality for indexing sessions? can be used to lookup sessions without having received a request previously. Essentially moves the registration/deregistration of cluster-wide handlers into a single address.

Additional benefits

no need to reference request data longer than the current request.
async messages to a closed session can fail with a callback graciously
the clustered message factory should be used for communication between services.

Remember to make something reusable to handle sessions for the listeners..

Would be great if sessions could be queried and also support multicasting.

Added a Connection context to Requests. This will work for writing asynchronous updates.


Make IfUnlessModifier respect rubocop:disable comments

A bug was discovered in https://github.com/rubocop-hq/rubocop/pull/7308#issuecomment-544236793
When Style/IfUnlessModifier decides that a line on modifier form is too long and that it should be written on normal form, it must respect comments that disable the Metrics/LineLength cop for the line in question. If that cop is disabled, then there can be no offense.

Thanks!


Circular loop between Pull Request and Branch Environment pages

The next steps on this page links to "Review Pull Requests in pre-production environments". It should really link to Named environments. Pull request environments comes before this page. The Pull Request Environments page links to this page. This creates a circular loop.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0159a25e-58b7-5e1d-305f-caa79a97be2c
Version Independent ID: d3409265-d64a-832f-cb52-488d39d2fca2
Content: Create branch preview environments in Azure Static Web Apps
Content Source: articles/static-web-apps/branch-environments.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thanks for catching this error in the doc! I have submitted a PR to fix the issue and will go-live in the public docs shortly.


Built Python prefers system packaged libpython when installed; local install should be built with rpath?

Hello,
If you happen to pull in the libpython package from the base distro into a container with the same version of Python, the built python will end up using the libpython shared-library from the system-installed package; e.g.
$ sudo docker run -it --network=host python:3.9-bullseye /bin/bash

# ldd /usr/local/bin/python3.9
	linux-vdso.so.1 (0x0000ffff9cc6a000)
	libpython3.9.so.1.0 => /usr/local/lib/libpython3.9.so.1.0 (0x0000ffff9c89a000)
        ...

# apt-get update
...

# apt-get install -y python3.9-dev
...
The following additional packages will be installed:
  libpython3.9 libpython3.9-dev
The following NEW packages will be installed:
  libpython3.9 libpython3.9-dev python3.9-dev
...

# ldd /usr/local/bin/python3.9
	linux-vdso.so.1 (0x0000ffff82c39000)
	libpython3.9.so.1.0 => /usr/lib/aarch64-linux-gnu/libpython3.9.so.1.0 (0x0000ffff82663000)
        ...

AFAICS, --enable-shared as been there basically forever (https://github.com/docker-library/python/commit/4faf7f1b13a13b24367307acc254bd2d0d48a46e).  From prior comments (https://github.com/docker-library/python/issues/777#issuecomment-1358366197) I believe the intent here is for the /usr/local/bin/python to be strongly isolated from any packaged python.
One option to avoid this might to be to build twice, a bit like the Debian package does, so that /usr/local/bin/python3.X is self-contained, and then copy back the .so library in a second step?
The other option seems to be to add rpath linker flags to ensure that the /usr/local/bin version finds its version first.  The binary could be patched post-build; I tried that, e.g. (in the same container as above)
# apt-get install patchelf
...

# patchelf --set-rpath '$ORIGIN/../lib' /usr/local/bin/python3.9

# ldd /usr/local/bin/python3.9
	linux-vdso.so.1 (0x0000ffff873dc000)
	libpython3.9.so.1.0 => /usr/local/bin/../lib/libpython3.9.so.1.0 (0x0000ffff86ffd000)
        ...

Probably that would take some thought on what other bits need patching like that.
I think the other option is to build with LDFLAGS=-Wl,-rpath='$ORIGIN/../lib'?  I feel like that should ensure that everything looks relative to itself for libraries.
For full context on this -- I actually found this with Python 3.11 containers, where we had enabled unstable repos since we needed some updated packages in the container.  It seems that unstable has had 3.11 packages committed recently, and we managed to pull in libpython3.11.  Suddenly /usr/local/bin/python3.11 had a sys.path that only had dist-packages (not site-packages).  This led me to finding that the built interpreter was using the .so from the packaged Python.

:heart: Thanks for the detailed issue. Yeah, this definitely looks worth fixing. :rocket: I'll work up a PR shortly.


CATE computation

https://github.com/OATML/ucate/blob/f57e47b1baec802c955adc7b07317d8014e50d91/ucate/library/utils/prediction.py#L37
Hi @anndvision, would appreciate if you could help me understand.
I thought that CATE computation is simply the difference between predicted y_1 and y_0 - it appears that I do not understand it correctly. What are the mu_1 and mu_0 in this case?
The IHDP data also comes with y factual and counter factual but also mu1 and mu0 - what are their differences?

Hi @jgamper,
Great questions!
So, by definition the CATE estimator is the difference in expectations:

These expectations are here modelled using parameterised neural networks  and :
.
Now, there may also be unexplained variance in  that is independent of both  and .
In expectation, this reduces to some constant, and cancels out in the difference in expectations.
That is, it has no effect on the CATE estimate.
We can think of the unexplained variance in  as observation noise (though this is not entirely precise). A single observation  will be biased by such "noise". For the IHDP dataset, we train models on observations of y factual, which are biased by this "noise", and are what we would see in a real observational dataset. While the CATE (the difference in expectations) is identifiable, the individual treatment effect (y factual - y counter factual) is not. So the ground truth for IHDP is the difference in expectations (mu_1 - mu_0).
Is this making sense?

@anndvision thanks for the explanation! Yes, it is starting to make sense now!
Right after asking the question, I found the section 5.2 from GANITE: Estimation of Individualized Treatment Effects using Generative Adversarial Nets where they discuss the difference between https://render.githubusercontent.com/render/math?math=\hat{\epsilon}{PEHE} and https://render.githubusercontent.com/render/math?math=\epsilon{PEHE} to be useful in pointing out that the difference is in the fact that the underlying data generating process is known so they can take the expectation (or as in this case have access to mu1 and mu0).

@anndvision thanks for the explanation! Yes, it is starting to make sense now!
Right after asking the question, I found the section 5.2 from GANITE: Estimation of Individualized Treatment Effects using Generative Adversarial Nets where they discuss the difference between \hat{\epsilon}{PEHE} and \epsilon{PEHE} to be useful in pointing out that the difference is in the fact that the underlying data generating process is known so they can take the expectation (or as in this case have access to mu1 and mu0).


deleted repeated global ibek files in Dockerfile

Thanks Subin.
I'm merging this now. Note that the changes include an update to ibek-support submodule to allow for use of disableLimitCheck as well as the Dockerfile fix.
If this builds in CI it will publish a new schema which we can add to your IOC instance so vscode will no longer complain about the disableLimitCheck entry (I'll show you this once it has built)


library returns '?' on every request

Here is my code:
socket = device.createInsecureRfcommSocketToServiceRecord(uuid);
socket.connect();

final CustomRPMCommand engineRpmCommand = new CustomRPMCommand();
final SpeedObdCommand speedObdCommand = new SpeedObdCommand();
while (!Thread.currentThread().isInterrupted()) {
    engineRpmCommand.run(socket.getInputStream(), socket.getOutputStream());
    speedObdCommand.run(socket.getInputStream(), socket.getOutputStream());

    runOnUiThread(new Runnable() {
        @Override
        public void run() {
            speedometerGauge.setSpeed(engineRpmCommand.getRPM(), true);
            rpmGauge.setSpeed(speedObdCommand.getMetricSpeed(), true);
        }
    });
}

What is wrong with my code?

I've copied OBD service from the sample application and it works!

Awesome!


As a developer, I would like the CLI to automatically create branches based off of Github issues so that I don't have to worry about branching.

Requirements:

Use the Github API to manage branches and pull requests.

On hold.  Not sure that it provides enough benefit.

won't fix.


URLs in email confirmation email differ

Hi,
If you register at nuget.org, you need to confirm your email address. Nuget sends you an email for that. Now, I'm an old fart from the old days where you read your email using 'mail' on a shell prompt so I read all my emails in plain text. When I got the confirmation email, I saw this: (url changed to protect the innocent)
https://www.nuget.org/account/confirm/SomeName/uiRHuje67GrebnZIJMFA2 <https://www.nuget.org/account/confirm/SomeName/uiRHuj_e67Grebn_ZIJMFA2>
So I copied the first URL, and it failed with the message it's been expired. Puzzled, I clicked the resend confirmation email link. To my surprise I received a new email with the exact same URL. Of course it still failed. I thought I was going crazy (some might think I'd reached that point many years ago, but let's say I'm sane here), so I again requested an email, same url, same story. The reason I retried the URL was that I thought it might be a problem in the service.
After more than half an hour I realized there were two '_' in the second URL, the one inside the <> characters. Using that URL worked.
Now, for the love of everything that's holy, please, make both URLs the same. Not everyone reads their email in HTML format, some of us like it when the email text they're seeing is the actual email text, stripped from all hiding HTML mess that caused and still causes so much problems in the world.
Thank you.

Seems to be an issue with the Markdown mailer which uses the underscore as italic indicator. That means that either the MarkdownSharp property StrictBoldItalic should be set (which is not accessible from the MarkdownMailer), or the underscore need to be escaped.

Thanks for reporting this - at this time, this doesn't meet our bar.

 Why? If it takes weeks to fix something, and you're nearing a deadline, sure, but the fix is right there!

@FransBouma we missed the fact that you had a PR, reactivating.

The PR has been merged into master now


make version check for both mjml 4 and 3

fixes the version check for mjml 4. with this the gem runs and compiles templates at least, have not tested it any further though.

@doits thanks for the fix!

@doits fix is deployed!

Github
RubyGems


Allow function types

eg
/** @type {function(?):?|{handleEvent:function(?):?}|null} handler */
types.g = null;

fixed by https://github.com/angular/closure-to-dts/commit/8cfb8738d78acd8dde97297a5a408cfb5352a484


no 4.0 version for windows uploaded

https://anaconda.org/conda-forge/swig/files?version=4.0.0

@jschueller  There is still no swig4 available. Maybe rerendering?


Fix: Toolbar; PDF CSS Error; ReadMe Rework

Title
Fix PDF annotation errors; closes #10
Description
This Pull Request fixes several issues related to PDF annotation in the codebase. The changes include:

Correcting the highlight selector
Fixing the pop-up bar mismatching and not conforming to style guide
Addressing a PDF highlight issue

Thank you!

I also reworked the Readme file. The CSS snippets are deprecated and would not have worked, so I added instructions on how to manually install the Theme through the RemNote theme store. However, there are also direct links to do so :)


Win comp

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@rafmudaf or @deslaughter or @andrew-platt : Can one of you go ahead and approve and merge so that I can play around with the windows conda build on this rc channel?

@gbarter done!


https://jira.desk.technology/browse/MSDKI-38

@eldark88 please review

@eldark88 any more feed back on this PR?

@nartiles no, it looks good to me :shipit:


eosd option --skip-transaction-signatures still checks for signatures

eosd option --skip-transaction-signatures still checks for signatures

made a code change for this in skipsig-317


crafttweaker/api/oredict/IOreDictEntryAny error with Array

Issue Description:
Trying to create an array for a loop and CraftTweaker gives a "crafttweaker/api/oredict/IOreDictEntryAny" error.
What happens:
Crafttweaker gives a "crafttweaker/api/oredict/IOreDictEntryAny" error.
What you expected to happen:
To not get an error.
Script used:
https://gist.github.com/The-Arcanian/5ade03e16aa3e2be1549870b12cc46b4
Minetweaker.log file:
https://gist.github.com/The-Arcanian/23795d6ba6f9c9bc67b7cdd5f79c508f

Affected Versions:

Minecraft: 1.12.2
Forge: <IP_ADDRESS>9
Crafttweaker: 4.0.9

Your most recent log file where the issue was present:
https://gist.github.com/The-Arcanian/91edc8467210ae08f4f63f68ef551e6d

Yea... you got your scripts and logs mixed up anyway, I think that the comment on the other issue will fix this one as well

The first link is the script the second is the log. They just both happened in the same CT log. The third one may not have been necessary though... Maybe that is what you meant.
Linking the other issue for anyone the googles.
https://github.com/jaredlll08/CraftTweaker/issues/374


Define devfile versioning and release process

What does this PR do?
This adds a proposal on how to handle versioning in the devfile spec, as well as outlining a process for releasing the devfile schema and Go modules.
What issues does this PR fix or reference?
https://github.com/devfile/api/issues/150
Is your PR tested? Consider putting some instruction how to test your changes
N/A
Docs PR
N/A

@amisevsk @elsony Thanks for the review comments! I've updated the PR based on your feedback.

Thanks @amisevsk, I've merged your two recommendations

@elsony Thanks, updated to add the cosmetic changes

@elsony I've updated the PR.


Magic Mount not working as intended

Magic Mount seems to think every zone is a no fly zone. And we have checked many zones.....lol
In most flying zones it' says Mode: Ground (a kind of magic) and lists only mounts that can be used for ground riding. So mostly ground only mounts.
In water it always says Mode: Water and doesn't swap between water mount and flying like it used to do. (Though I like it this way)
Is there a way to summon water mount if under water and flying when above water, That would be cool if you could get it to do that.
There is no error code that I can tell. But like in this pic it lists where you are and the mode it's going to use and then the list of mounts.

ty! I'll take care of this today.

Thank you again.
I might have fixed it. Take a look at v3.0.5 please.
#tlv

Another odd thing is when in a flying zone and using Magic Mount but have "Flight Style: Steady" active it says
68 of 69 usable

I've checked and mounted on every one of them and they are all flying mounts. So it is not counting one of them as a flying mount. I'll do more testing to see if I can find out what mount it is.

OMG!
I fixed it, well for me at least, as it was not broken. per say
Since Blizzard Made it so every mount can be Steady Flight and / or Skyridding I removed all skyridding mounts from that "skyridding" list and added them to the Flying Mount section. "skyridding" The one I said we no longer need and you could just delete or change it to something els.
But I looked at that and I'm like no way, could it be and sure enough it is.
I suppose there are mounts people may not want as regular flying mounts and some they may prefer for Skyriding. So keep it I guess.
I feel so dumb right now for wasting your time on this part.

:)

But Blizzard still makes my head hurt, because IsAdvancedFlyableArea () - function to see if Skyriding is possible - will always return true - even in dungeons or cities. So for now I can't check, if Skyriding is possible or not and always summon dragons. :-/


computational physics scripts

What do you mean by computation physics scripts as your yaml file in your github action directory?

Its just the name.

Did you create that file?

Yeah, It can be any name. Can you provide the link to that file @s4il3sh


Improve filters in AnimationTree

Operating system or device - Godot version:
Godot last build
Issue description:
Filters in the AnimationTree are somehow conterintuitive, I think that filters can be improved.
Take for example a Blend2Node. What does it mean to filter some tracks on that node? Are you filtering the animation coming from input A or B?
I've looked at the code because I can't get the behavior I want in the animation tree, and things seem a bit confsing to me, so... My proposal is:
A filter should be a node in the animation tree on its own. The effect of filteting out a track should be to have that track for every animation sub node to have a weight of zero. For example:
Anim1 <----- +
             |
Anim2 <----  Blend3Node <---------- Filter<----- Blend2Node<-----Out
             |                                       |
Anim3 <----- +                             Anim4 <---+

If the Filter is set to filter track x, y and z, then for Anim1, Anim2, and Anim3, these tracks should have a weight of zero in the final blending.
Multiple filters should accumulate unsing an OR logic. That is a filter can only filter out tracks. Tracks that have been already filtered get no effect.

moving to 3.1


Simple validation by CSV url

This adds simple validation, so if someone tries to get a CSV validation by URL, and it doesn't exist, it queues a job and returns a pending status. This will be nice for theodi/git-data-publisher#2

Coverage increased (+0.04%) to 97.54% when pulling ff7a69d72266c4b90672b4e0e8858d6cde88edd2 on feature-simple-validation into 6dd3798f45f40a6cd2e88501d5052914888bec28 on master.

Coverage increased (+0.04%) to 97.54% when pulling 81fea9041ad761505f5d223a47954112f3d315d7 on feature-simple-validation into 6dd3798f45f40a6cd2e88501d5052914888bec28 on master.


Contributor missing from 1.17 list

I think the list of contributors to 1.17 is incomplete -- so there seems to be a bug somewhere in the machinery that collects these stats.
Specifically, I am the author of commit 044ed10fee3351da2315d5d8e26949929ad918ce, which is new in 1.17:
$ git tag --contains 044ed10fee3351da2315d5d8e26949929ad918ce
1.17.0

However, my name does not appear on https://thanks.rust-lang.org/rust/1.17.0.

Sorry about that!
This is interesting; git log 1.17.0..beta does not seem to contain this commit. Hmmmmmmmm

Well, 1.17 has been released, so I'd rather expect it in git log 1.16.0..1.17.0, right? 1.16 doesn't even seem to have a tag, though... and git log 1.15.0..1.17.0 | fgrep Ralf does show something.

/cc @brson wrt the missing 1.16.0 tag

git log 1.15.0..1.17.0 | fgrep Ralf does show something.

☹
So, historically what we base this off of is stable vs beta, basically, because that's how our branching model works. And we actually produce the list originally before the tag is even made, so we have to do it that way. But stable and 1.17.0 here, should be the same, so that shouldn't exactly matter......................

But stable and 1.17.0 here, should be the same, so that shouldn't exactly matter......................

And it doesn't, right? git log 1.17.0..beta is for commits since stable, mine isn't in there. It is between 1.16 and 1.17.

I need to re-read the code. It does what we always did by hand originally.

This may be related, my name is not on the list for 1.17.0 either, and my commits https://github.com/rust-lang/rust/pull/39470/commits/fe324cea6490fc6e7ce16fb5209fde57cfa1b94f and https://github.com/rust-lang/rust/pull/39712/commits/e626a6807c44d097996b0f32a4e03b105837f9da are in 1.17.0.


[Snyk] Upgrade mongoose from 7.6.3 to 7.6.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade mongoose from 7.6.3 to 7.6.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 25 days ago, on 2023-10-30.

Release notes

Package name: mongoose

7.6.4 - 2023-10-30chore: release 7.6.4

7.6.3 - 2023-10-177.6.3 / 2023-10-17

fix(populate): handle multiple spaces when specifying paths to populate using space-delimited paths #13984 #13951
fix(update): avoid applying defaults on query filter when upserting with empty update #13983 #13962
fix(model): add versionKey to bulkWrite when inserting or upserting #13981 #13944
docs: fix typo in timestamps docs #13976 danielcoker

    from mongoose GitHub release notes

Commit messages

Package name: mongoose

4ff1916 chore: release 7.6.4
120b442 Merge pull request #14017 from Automattic/vkarpov15/gh-13973-2
8a7f2f2 Merge pull request #14011 from Automattic/vkarpov15/gh-13978
a1dc45b test: modify test name re: code review comments
a5e4ec2 Update test/schema.test.js
6c4d836 fix(document): handle #9396 case by only applying #13973 logic if in transaction
c795ce4 fix(connection): retain modified status for documents created outside a transaction during transaction retries
64f2098 fix(schema): handle recursive schemas in discriminator definitions
266804b fix: handle casting $or within $elemMatch
4d084e9 Merge pull request #13998 from suzuki/fix/doc-plungins
e7a1d6d Merge pull request #13995 from Freezystem/fix.add-fullpath-to-validator-props
44aeb96 Merge pull request #13996 from Automattic/IslandRhythms/gh13863
9bc2cf2 Update model.js
c5f75bc fix(document): fix differences between sample codes and documentation
967912f fix(populate): allow using `options: { strictPopulate: false }` to disable strict populate
1eee4f8 fix: lint
627a53e write test
e0b03ed Add fullPath to ValidatorProps
7efa151 Merge pull request #13992 from suzuki/fix/doc-typescript-query-helper
eacb5ab fix(document): fix missing import and change wrong variable name

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

picked up on release/0.0.20


Add duScrollDelay option for smoothScroll directive

This is useful when you have an additional click event bound to the same element as the smoothScroll directive that should trigger an event before triggering the scroll.

Thanks for your PR @homerjam!
Wouldn't it make more sense to have the other click handlers to invoke the smooth scroll via scrollToElementAnimated() in that case? Don't want to unnecessarily bloat the API and configs.

Well yes that's an option of course, but I personally thought the bloat was worth it in this case.
No problem if you don't want to include it though. I can make a custom directive derived from yours to use in my projects.
Thanks for the great module anyway!

I think it's an edge case that pretty easily can be done in another way that's why :-) Leaving this PR open for a while to see if anybody else has any need for it.

Good plan, consider me a +1 : )


Feature request

I have not much experience with github but i like jrnl so much, I thought to venture a request. I hope this is the right place.
Although the dating system is great, would it be possible to add a timestamp at the end of an entry.
Don't know if it is do-able, but I imagine something like
2016-06-01 10:12 Just wrote an entry.
I like JRNL
(last modified 2016-06-02 01:38)

This being an option one could de/activate in the .conf file as typing "jrnl -timestamp..." every time would be quite cumbersome.
Do you like it; is it difficult?

Hi Segdon, welcome to Github and thanks for the feature request!
In the 2.0 branch of journal, you can optionally have your journal entries stored in individual files, which will of course maintain their modification date! Would that work?

I didn't think of it that way, but i sure does meet my demands. - Thinking outside the box...

Great! I'll close this for now, and put more work behind getting 2.0 out.


March native option

Proposal to fix https://github.com/microsoft/mimalloc/issues/361

This would work great, and great default too.

This is ugly and unnecessary (user can already put -march=native via C flags). Just remove line 194 to 199.
minmalloc is not a snowflake that is needs to have it in cmake.

Hi all -- I want to surely remove -march=native by default to support @rpavlik  's case.  I am thinking though that @baryluk  may be right and we should just remove it all together?  Would that be ok @devnexen  or is there a specific use case you had in mind? I remember something about need the flag to build on certain platforms?
Thanks everyone.

It s mainly useful for platforms like raspberry but not world ending if you insist removing all.

Thanks for the reply @devnexen ; I think I will remove it then as I feel the build options are already getting too much ...

It s mainly useful for platforms like raspberry but not world ending if you insist removing all.

That still doesn't make any sense, because you can still pass -march=native manually on raspberry pi just like on any other platform, architecture or system. And every other system equally might want to specialize their compilation to be as fast as possible. It is not a job of the library authors to select all the cpu-specific options, but rather a packagers (where they will select most suitable and compatible options, giving best possible performance) and people who compile it locally (same).


Doubt

Is there a way to return the followers count of each user who didn't follow me back?

You can do this manually by checking the user's profile.


[Html] Invoking completions in the middle of html tag doesn't work as expected

Version used:
VS 2022 v17.3 Preview 3
To reproduce:
Invoke completions in <h$$1>Counter</h1>
Expected behavior:
There is only h before the cursor. So I expect to have h1, h2... h6 completions. Applying one of them changes both opening and closing tags
Actual behavior:
Cursor jumps to the end of opening tag making the line "unsaved":

This will need platform support in some way. We're returning a full set of completion items for this request, so if we want different behaviour here, its up to the platform to help us out.


Switch window is offscreen

Since the update to Atom 1.8.0, the tab switcher window appears in the top left corner instead of being centered on screen. With long file and path names, it is clipped, making it barely usable.

This is using Mac OSX 10.11.5, tab-switcher 1.5.1 and Atom 1.8.0. I tried uninstalling / reinstalling the package, but with no success.
Thanks,
G

Funny, I just noticed that myself yesterday. Just pushed a release which should fix this.
Thanks for the report!

In my case, all atom modals are at the bottom of the window.  Disabling the position: static rule on atom-panel-container seems to fix it.  Strangely, the rule is being applied even though the tab-switcher class is not present on the element.

Actually, the problem seems to be that the other modal (in my case "fuzzy finder") is nested within a tab-switcher modal:
<atom-panel-container class="modal tab-switcher">
    <atom-panel class="tab-switcher modal overlay from-top" style="display: none; transition-delay: 0.1s;">

Settings

    </atom-panel>
    <atom-panel class="modal overlay from-top">

    </atom-panel>
</atom-panel-container>

@GillesDebunne @sirianni
Dangit, sorry about that. Looks like the pane-container is shared with other panels.
I guess I should stop using panels for this, since themes seem to take liberty with panel positioning, and the tab list is kind of a separate thing. I'm short on time though, so I've just hacked the hack for now.

Looks like it's fixed - I just upgraded this morning.  Thanks for the quick turnaround!


Remove drag and drop of sessions in training mode

In the session viewer, we are primarily focused on supporting up to two sessions at the same time, specifically Capella and Jupyter. Given this limitation, the ability to move sessions around is not necessary. By eliminating this option, it may simplify future enhancements and make them easier to implement.

I'd not remove the current drag&drop feature. Instead, there should be two different layout modes:

Training Mode: The training mode has a fixed layout. Sessions can be rebalanced via sliders. There is no drag&drop.
Session viewer: The session viewer has a flexible layout, offering typical window manager features. Drag&drop, resizing of individual windows and minimizing / maximizing would be features of the session viewer.

Tracked in https://github.com/DSD-DBS/capella-collab-manager/issues/990 instead.


Retrofit 400 error during publishPlugin

Tested using same builds of my plugin that previously published successfully.
9:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: java.lang.RuntimeException: Failed to upload plugin
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	... 44 more
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: retrofit.RetrofitError: 400
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at retrofit.RetrofitError.httpError(RetrofitError.java:40)
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at retrofit.RestAdapter$RestHandler.invokeRequest(RestAdapter.java:388)
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at retrofit.RestAdapter$RestHandler.invoke(RestAdapter.java:240)
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.jetbrains.intellij.pluginRepository.$Proxy107.uploadByXmlId(Unknown Source)
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.jetbrains.intellij.pluginRepository.PluginRepositoryInstance.uploadPlugin(pluginRepositoryRest.kt:95)
09:03:30.123 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.jetbrains.intellij.pluginRepository.PluginRepositoryInstance$uploadPlugin.call(Unknown Source)

There is a note next to the button: "License URL should be provided", that's why it's not possible to upload the update. We should definitely communicate it more clear, I'll create an internal issue now.
As of the recent GDPR-related changes, a license URL must be provided for all plugins in the plugins repository, so please add a license URL on the edit plugin page (below the update upload).

And we have published additional information here: https://blog.jetbrains.com/platform/2018/05/legal-news-plugin-license-is-required-for-all-plugins/

thanks @mikhailvink.
I think the UI on the repo page could be improved to better indicate this. E.g. it wasn't clear at all that the form was in error due to a missing license.
In any case, this isn't the repo to track that so I'll close.

actually, better error messages from the publish task would have saved a lot of headache. maybe we can improve that and track here?

Yes, even if this is surfaced on the plugin repo UI, it also needs to be shown when the Gradle task fails. Since I've been using Gradle, I never use the UI to upload any more.

Is there any way to specify license URL when using Gradle publish task?

@ermadan You don't have to specify it on every publish, just once in the repo UI and then publishing will work from Gradle.

gradle-intellij-plugin 0.3.3 shows correct error message. Please upgrade if needed.
:compileJava UP-TO-DATE
:patchPluginXml UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:instrumentCode UP-TO-DATE
:postInstrumentCode
:jar UP-TO-DATE
:prepareSandbox UP-TO-DATE
:buildPlugin UP-TO-DATE
:verifyPlugin
Failed to upload plugin: Plugin license url must be set to upload plugin update
:publishPlugin FAILED


kit f -r ... should fetch wasi, wit, etc if DNE

As-is, requires the repo has been built with cargo -- which runs kinode core's build.rs and fetches some stuff.

Works as of 0c43430


[Builder State Refactor] - Design

https://www.notion.so/espressosys/Builder-State-Refactor-1022431b68e9809bb6dfe54346aa0aef


New retina-friendly flourish favicon.

This closes issue #241.
It takes the old favicon for the site …

… and replaces it with a crisper, retina-friendly version. It also now makes better use of the "flourish" element, which is a key design element in the new site. …

Yay! I love this one :) Thanks @charliepark!!!


add set -e to all scripts.

fixes: #85

jep, i'm testing locally right now because i'm also not sure 😄

local testing works. but have no deeper test scenarios.


Support for extra renderings (by adding the appropriate CSS)

[ ] Code fromatting
[ ] TeX (via Katex)
[ ] More?

@zulipbot claim

We have code formatting (since #1823, looks like). There's a more specific issue #2660 for LaTeX/TeX support; closing this one in favor of that.


Add nccl package and Bump vLLM to 0.4.3 for huggingface runtime

What this PR does / why we need it:

From 0.4.3 vLLM uses vllm-flash-attn instead of flash-attn package which is specified as a required dependency.
Updates the huggingface runtime base image to nvidia/cuda:12.1.0-cudnn8-runtime-ubuntu22.04 which has the nccl package pre-installed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #3722

Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[x] Test A

$ (.venv) root@768af757c26b:/workspace/kserve/python# python3.10 -m huggingfaceserver --model_id=facebook/opt-125m --model_name=opt-125m
/workspace/kserve/.venv/lib/python3.10/site-packages/huggingface_hub/file_download.py:1132: FutureWarning: `resume_download` is deprecated and will be removed in version 1.0.0. Downloads always resume when possible. If you want to force a new download, use `force_download=True`.
  warnings.warn(
INFO 06-04 10:46:41 llm_engine.py:161] Initializing an LLM engine (v0.4.3) with config: model='facebook/opt-125m', speculative_config=None, tokenizer='facebook/opt-125m', skip_tokenizer_init=False, tokenizer_mode=auto, revision=None, rope_scaling=None, tokenizer_revision=None, trust_remote_code=False, dtype=torch.float16, max_seq_len=2048, download_dir=None, load_format=LoadFormat.AUTO, tensor_parallel_size=1, disable_custom_all_reduce=False, quantization=None, enforce_eager=False, kv_cache_dtype=auto, quantization_param_path=None, device_config=cuda, decoding_config=DecodingConfig(guided_decoding_backend='outlines'), seed=0, served_model_name=facebook/opt-125m)
INFO 06-04 10:46:42 weight_utils.py:207] Using model weights format ['*.bin']
INFO 06-04 10:46:43 model_runner.py:146] Loading model weights took 0.2389 GB
INFO 06-04 10:46:43 gpu_executor.py:83] # GPU blocks: 37210, # CPU blocks: 7281
INFO 06-04 10:46:45 model_runner.py:854] Capturing the model for CUDA graphs. This may lead to unexpected consequences if the model is not static. To run the model in eager mode, set 'enforce_eager=True' or use '--enforce-eager' in the CLI.
INFO 06-04 10:46:45 model_runner.py:858] CUDA graphs can take additional 1~3 GiB memory per GPU. If you are running out of memory, consider decreasing `gpu_memory_utilization` or enforcing eager mode. You can also reduce the `max_num_seqs` as needed to decrease memory usage.
INFO 06-04 10:46:51 model_runner.py:924] Graph capturing finished in 5 secs.
2024-06-04 10:46:51.555 6696 kserve INFO [model_server.py:register_model():384] Registering model: opt-125m
2024-06-04 10:46:51.556 6696 kserve INFO [model_server.py:start():254] Setting max asyncio worker threads as 11
2024-06-04 10:46:51.556 6696 kserve INFO [model_server.py:serve():260] Starting uvicorn with 1 workers
2024-06-04 10:46:51.663 uvicorn.error INFO:     Started server process [6696]
2024-06-04 10:46:51.663 uvicorn.error INFO:     Waiting for application startup.
2024-06-04 10:46:51.667 6696 kserve INFO [server.py:start():63] Starting gRPC server on [::]:8081
2024-06-04 10:46:51.667 uvicorn.error INFO:     Application startup complete.
2024-06-04 10:46:51.668 uvicorn.error INFO:     Uvicorn running on http://<IP_ADDRESS>:8080 (Press CTRL+C to quit)

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[x] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Add nccl package and Bump vLLM to 0.4.3 for huggingface runtime to fix flash_attention package not available error.

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/rerun-all

Also with this change to vLLM there's no more prompt_token_ids
So this would break in kserve
We should fix this before updating vLLM to 0.4.3?

Also with this change to vLLM there's no more prompt_token_ids So this would break in kserve
We should fix this before updating vLLM to 0.4.3?

Good Catch! Fixed

From my brief testing/benchmarking, I don't see any significant improvement either by flash-attn or by vllm-flash-attn over the default. They're within the 1% range of each other.
And both with or without flash-attn, vLLM was able to create same number of blocks for paged attention aka same memory usage
This is what Tri Dao said about the same (old though)
flash-decoding which was added in FlashAttention 2.2 might help but I don't know where the said performance improvements are vanishing
FlashAttention as of now is a good to have but doesn't give us enough to necessitate it ig?

From my brief testing/benchmarking, I don't see any significant improvement either by flash-attn or by vllm-flash-attn over the default. They're within the 1% range of each other.
And both with or without flash-attn, vLLM was able to create same number of blocks for paged attention aka same memory usage
This is what Tri Dao said about the same (old though)
flash-decoding which was added in FlashAttention 2.2 might help but I don't know where the said performance improvements are vanishing

From my brief testing/benchmarking, I don't see any significant improvement either by flash-attn or by vllm-flash-attn over the default. They're within the 1% range of each other.
And both with or without flash-attn, vLLM was able to create same number of blocks for paged attention aka same memory usage
https://github.com/Dao-AILab/flash-attention/issues/427#issuecomment-1668257877 is what Tri Dao said about the same (old though)
flash-decoding which was added in FlashAttention 2.2 might help but I don't know where the said performance improvements are vanishing

vLLM does adds support for decoding using flash-attn in 0.4.3 and according to this comment it gives roughly 10% increase in throughput. Btw, vllm-flash-attn and flash-atten are essentially the same. It is just a work around for wheel size limitation.. Flash-atten has some constraints on the head size as explained here.. So if the model does not falls under this head size, then it won't enjoy any performance improvements from flash-atten.

I am just adding a Note from vllm docs here:
For v0.4.1 and v0.4.2 only - the vLLM docker images under these versions are supposed to be run under the root user since a library under the root user's home directory, i.e. /root/.config/vllm/nccl/cu12/libnccl.so.2.18.1 is required to be loaded during runtime. If you are running the container under a different user, you may need to first change the permissions of the library (and all the parent directories) to allow the user to access it, then run vLLM with environment variable VLLM_NCCL_SO_PATH=/root/.config/vllm/nccl/cu12/libnccl.so.2.18.1 .

I am just adding a Note from vllm docs here: For v0.4.1 and v0.4.2 only - the vLLM docker images under these versions are supposed to be run under the root user since a library under the root user's home directory, i.e. /root/.config/vllm/nccl/cu12/libnccl.so.2.18.1 is required to be loaded during runtime. If you are running the container under a different user, you may need to first change the permissions of the library (and all the parent directories) to allow the user to access it, then run vLLM with environment variable VLLM_NCCL_SO_PATH=/root/.config/vllm/nccl/cu12/libnccl.so.2.18.1 .

So to use NCCL we have to run vLLM as root user for 0.4.1 and 0.4.2. But that's not the case for 0.4.3

@sivanantha321
I tried mistral as said in the comment with and without flash attn
These are the results
mistral-7b-v0.1
withouth flash-attn
Avg latency: 1.8139188961683734 seconds
10% percentile latency: 1.8072806416093954 seconds
25% percentile latency: 1.8097923692512268 seconds
50% percentile latency: 1.813208505504008 seconds
75% percentile latency: 1.8156179094985418 seconds
90% percentile latency: 1.8222627914961778 seconds

Throughput: 9.91 requests/s, 4680.56 tokens/s

with flash-attn
Avg latency: 1.8172954017999776 seconds
10% percentile latency: 1.813928227701399 seconds
25% percentile latency: 1.81456515800528 seconds
50% percentile latency: 1.8163161535048857 seconds
75% percentile latency: 1.8180346899971482 seconds
90% percentile latency: 1.8244814682984725 seconds

Throughput: 10.36 requests/s, 4892.64 tokens/s

4% delta in throughput and <1% delta i latencies if my math serves me right
Maybe its more pronounced for larger models idk...

Also, if it has to be run as a root user, we have to make it optional as it might not be possible in all envs. @sivanantha321

If we are upgrading to 0.4.3, this is not required. Should we stick to 0.4.2 for this release ?

Hey just curious - is there any reason why you could not start from the vLLM Docker image?
We are going to have some new features coming out which are going to require CUDA 12.4 (which is now what we use in the official vLLM docker image FROM nvidia/cuda:12.4.1-base-ubuntu22.04 AS vllm-base). (in particular, we have some cutlass kernels for fp8 on Ada lovelace, which need CUDA 12.4)
It might be easier to stay in sync with the vLLM project this way

Hey just curious - is there any reason why you could not start from the vLLM Docker image?
We are going to have some new features coming out which are going to require CUDA 12.4 (which is now what we use in the official vLLM docker image FROM nvidia/cuda:12.4.1-base-ubuntu22.04 AS vllm-base). (in particular, we have some cutlass kernels for fp8 on Ada lovelace, which need CUDA 12.4)
It might be easier to stay in sync with the vLLM project this way

This runtime uses vLLm as one of the backends. In future, We plan on adding some more backends as well. So, Using cuda image as base image gives more advantage than relying on vLLM docker image.

/rerun-all

/lgtm
/approve


CPP : Queue Introduction

Description 📜
An Introduction to Queue

Domain of Contribution 📊

[x] C/CPP

Document

/assign


Fix minor typo

Thanks for the catch @XD-DENG, I've rebased against current master and merged the commit.

Thanks @karmi


fix it the Twig depreciation

I fix it a Twig depreciation, see https://github.com/twigphp/Twig/commit/e3a325f249a5ff4cdbbabbec7271c13dee2d7ac5 for more information.
Thanks

you need to bump the min Twig version though

Hum sorry, I'm not used to collaborate at projects... Where I need to bump the min Twig version ? In the composer.json ? Thank for your help.

yes

I update the composer.json :)

please rebase your branch to fix conflicts

Done! :)

Most change have actually disappeared because of the merge of https://github.com/kriswallsmith/assetic/pull/772
I will still merge this PR to update the lowest bound of the dev requirement

Thank you @Titome.


No module named binance

Hi id installed python-binance-master , and tried pip install python-binance too, but as soon I try to run pumpbot every time get
ModuleNotFoundError: No module named ‘binance’
C:\PumpBot-master>pumpbot.py
Traceback (most recent call last):
File "C:\PumpBot-master\PumpBot.py", line 1, in
from binance.client import Client
ModuleNotFoundError: No module named 'binance'
Windows10
Python latest version 3.9.4
All json configured and api keys too..
What I should to do?
Thanks in advance

I had 3.6 and 3.9 installed,my bad,sorry


Support musl libc binary

initial support: https://github.com/takumin/ykmgr/commit/d89ed851b65de9151d1f5838b1de6ffea571f76c
TODO: crossbuild


Microsoft Teams Desktop Personal app not working with SPFX and GraphApi

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
SharePoint REST API
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[X] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[X] other (enter in the "Additional environment details" area below)

Additional environment details

browser version
SPFx version
Node.js version
etc

Describe the bug / error
I added a Personal Tab in MS Teams which references a SharePoint Webart with on it an SPFx webpart using @microsoft/microsoft-graph-client.
In the MS Teams Web Client on TEST and PROD the page loads as expected, and the @microsoft/microsoft-graph-client calls work. In the MS Teams Desktop client on TEST environment also work perfect.
However, in the MS Teams Desktop Client (on windows) on PROD environment the @microsoft/microsoft-graph-client does not work.
Looking in Fiddler, I can see the following happening (only on the dekstop client):
A call is made to https://o2fitcom.sharepoint.com/_api/Microsoft.SharePoint.Internal.ClientSideComponent.Token.AcquireOBOToken?resource='58066c29-7a47-418b-9cb8-69adf68633b3'&clientId='08e18876-6177-487e-b8b5-cf950c1e598c' with error result Failed to load resource: the server responded with a status of 403 ()
The call returns an HTTP 500 with message:
<m:error xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"> <m:code>-2147024891, System.UnauthorizedAccessException</m:code> <m:message xml:lang="en-US">Attempted to perform an unauthorized operation.</m:message> </m:error>
I already success make solution work on TEST but not in PROD, checked all the configuration and manifest are the same. All the configuration of permission in the SharePoint Online Client Extensibility Web Application Principal are granted.
similar issue:
https://stackoverflow.com/questions/59860729/spfx-webpart-in-msteams-desktop-client-throws-an-unauthorizedaccessexception
https://github.com/SharePoint/sp-dev-docs/issues/3923
https://github.com/SharePoint/sp-dev-docs/issues/5441
Steps to reproduce

I added a Personal Tab in MS Teams which references a SharePoint Webart with on it an SPFx webpart using @microsoft/microsoft-graph-client.
In the MS Teams Web Client on TEST and PROD the page loads as expected, and the @microsoft/microsoft-graph-client calls work. In the MS Teams Desktop client on TEST environment also work perfect.

Expected behavior
we expected it should work in Teams desktop client on PROD environment as well.

I followed this guideline and face the problem above

I am also facing the issue, it was working till Friday (2 days ago).
Graph calls not working in teams desktop app using Spfx react.
Error is while getting token
https://m365x5xxxx7.sharepoint.com/sites/dev/_api/Microsoft.SharePoint.Internal.ClientSideComponent.Token.AcquireOBOToken?resource='https://graph.microsoft.com'&clientId='xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxx'

We are also seeing this issue on our apps. Seems to be a general issue once again...

@amalitabose  - the issue you are seeing is unrelated to this thread.  Your tenant is new and we have issues with tenants created after early November 2021.  A principal is not provisioned correctly.  The fix for that is already rolling out and it will remediate the issue for all new tenants within about 2 weeks.
@XixiHuang333  - I'm sorry that you are seeing this issue.  Could you send the fiddler trace to grahamc at microsoft.com so I can take a look at the cause of your issue?

@GrahamMcMynn  Thanks for your help on this. Actually I help @ntdong1889 to raise the issue here. @ntdong1889  could you please help to send fiddler log here?

MSTeams Diagnostics Log 09_12_2021__14_15_28.zip
FiddeLog.zip
Here :v

@XixiHuang333  / @ntdong1889  - Thanks for the information.  I've reached out to Xixi off of git hub to look into what is wrong.  The users do not have remote api access and therefore are blocked from making calls.  I am working with Xixi to determine what permissions you have given the users.

@ntdong1889  As Graham's guidance, could  you please check did this feature get enabled?
Impact of deactivating the Limited-access user permission lockdown mode feature - Microsoft Q&A

@ntdong1889 - When you enable this feature it prevents remote API's from being used.  Permissions for teams auth use remote API's in order to authenticate.  Having that feature active is not supported if you want SPFx apps in teams to authenticate correctly.  Is there a reason you have it active?

@ntdong1889 - When you enable this feature it prevents remote API's from being used. Permissions for teams auth use remote API's in order to authenticate. Having that feature active is not supported if you want SPFx apps in teams to authenticate correctly. Is there a reason you have it active?

Thank for your answer and support. I need to talk with SP Admin to discus about this.

I have been trying out SPFx and Graph api to create personal. I am seeing the issue in my mobile android device teams client as well. Can someone please confirm, if the issue is also impacting mobile device client as well?

Set the status of this to by design because the original bug was due to the limited access user permission setting.
@ArijitCloud  - there are other threads such as issue #7639 which are related to mobile.

Set the status of this to by design because the original bug was due to the limited access user permission setting.
@ArijitCloud - there are other threads such as issue #7639 which are related to mobile.

@GrahamMcMynn  I contacted with the SP admin and tried to deactivate Limited-access user permission lockdown mode feature but the issue still occurs. Do you have any ideas?

@ntdong1889 / @XixiHuang333 - if you are still experiencing an issue could you please send me a new trace?

@ntdong1889 / @XixiHuang333 - if you are still experiencing an issue could you please send me a new trace?
Fiddler-20220125.zip

I send you the fiddle. one for Teams App and one for Viva Connection

hey @ntdong1889, can you please do the following to see if that resolves your issue?

log in to Azure portal as a Global Administrator
go to "App registrations"
search for "SharePoint Online Client Extensibility Web Application Principal" object
click there and select "Certificates and secrets"; you should end up in a UX like the following and you should have just one client secret

at that point click on the trash can icon and delete that secret. Once you are done there. go back to SPO tenant admin and ensure you are both Global Admin AND SPO teantn admin. Then go to the "API Access" page: that will trigger generation of a new client secret (you can see that in the AAD portal after you visited the page in SPO tenant admin and refresh).
This should solve the problem: if that's not the case please open a new GH issue so we can properly track the issue.
Thanks!

hey @ntdong1889, can you please do the following to see if that resolves your issue?

log in to Azure portal as a Global Administrator
go to "App registrations"
search for "SharePoint Online Client Extensibility Web Application Principal" object
click there and select "Certificates and secrets"; you should end up in a UX like the following and you should have just one client secret

at that point click on the trash can icon and delete that secret. Once you are done there. go back to SPO tenant admin and ensure you are both Global Admin AND SPO teantn admin. Then go to the "API Access" page: that will trigger generation of a new client secret (you can see that in the AAD portal after you visited the page in SPO tenant admin and refresh).
This should solve the problem: if that's not the case please open a new GH issue so we can properly track the issue. Thanks!

I got this when try to access API Access Page

Hi @ntdong1889  - sorry to do this to you again, do you mind sending me a trace of loading the web api permissions page?

Hi @GrahamMcMynn here is the log. Thanks for all the support :)
I and another SP Admin have the same issue :(
ApiAccessLog.zip


Allow package to load on julia 0.5

This doesn't get tests passing on my machine, but at least the package loads.
I was just kicking the tires here. Interested in potentially helping mentor a GSoC student to modernize this package?

Thanks for the contributions. I would be happy to help a student to move forward with OpenCV.jl, but I am on a tight deadline with work at the moment and not actively working with Julia...

OK. I'd put you down as a co-mentor but not assume that you'd have the bandwidth to do it all alone. Sound reasonable?
Also, what would you think about having this move to the JuliaImages organization?

OK. I'd put you down as a co-mentor but not assume that you'd have the bandwidth to do it all alone. Sound reasonable?

Good.

Also, what would you think about having this move to the JuliaImages organization?

Great!


Move some @types to "dependencies"

These @types are needed if a TS project is rebuilding bitbox-sdk from source.  This would be the case even if .d.ts files were published instead of .ts files since the .d.ts file would still have references to these dependent types.
Also, on a separate note. Maybe something to consider in a future release is to publish .d.ts files instead of the .ts files.  I'm currently planning on doing this for slpjs soon, but right now I'm struggling with some strange issue preventing me from doing so.

:tada: This PR is included in version 8.8.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BUG] [GSSOC' 21] Contact us link not working on navbar at index.html page of the website

On clicking the contact us button on the navbar the link does not take the user to the bottom of the page like other links, reference screenshot is added below:

@himanshu007-creator

Yes , it's a feature,not a bug. Because contact form is under development right now.

@himanshu007-creator okay, so should i close this issue then?

@himanshu007-creator okay, so should i close this issue then?

Yes😅 but I am really looking for another PR from your side mate! Best of luck ⚡

sure I will be creating a new issue now!


sideNav Not Working with RequireJS using CDN dependencies

Using the SideNav component on Chrome 59.0. Simple Spring application, with a single app.js file included using RequireJS in HTML.  The HTML tag is:
<script data-main="/assets/js/app" src="https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js" integrity="sha256-Ae2Vz/4ePdIu6ZyI/5ZGsYnb+m0JlOmKPjt6XZ9JJkA=" crossorigin="anonymous"></script>

The javascript code in app.js is as follows:
require.config({
    'paths': {
        'hammerjs': '//cdnjs.cloudflare.com/ajax/libs/hammer.js/2.0.8/hammer.min',
        'jquery': '//cdnjs.cloudflare.com/ajax/libs/jquery/2.2.4/jquery.min',
        'jquery-hammerjs': '//bowercdn.net/c/jquery-hammerjs-1.0.11/jquery.hammer-full.min',
        'materialize': '//cdnjs.cloudflare.com/ajax/libs/materialize/0.100.1/js/materialize.min',
        'velocity': '//cdnjs.cloudflare.com/ajax/libs/velocity/1.5.0/velocity.min'
    },
    'shim': {
        'materialize': {
            deps: ['hammerjs', 'jquery', 'jquery-hammerjs', 'velocity']
        }
    }
});

require(['jquery', 'materialize'], function($) {

    // NOTE: Behavior is the same with or without this line
    window.jQuery = window.$;

    // NOTE: Behavior is the same whether call is wrapped in the jQuery DOM function or not
    $(function() {

        /**
         * The following section initializes the sideNav for all mobile pages.  See the MaterializeCSS Framework
         * documentation for more information.
         */
        $('.button-collapse').sideNav();

    });

});

The page loads and the sideNav element works, but when I click the shaded area to close the sideNav, the shading goes away but the sideNav element stays fixed at left.  I can see the transition occurring in Chrome Inspector, but it instantly resets to translateX(0px). Using a non-minified version of materialize.js does not change the issue.
In the console I see the message:
Velocity is already loaded. You may be needlessly importing Velocity again; note that Materialize includes Velocity.

Though that may be a red herring.
If I remove the velocity dependency from my RequireJS shim, I get the following error message in console:
materialize.min.js:6 Uncaught TypeError: o.velocity is not a function
    at HTMLAnchorElement.<anonymous> (materialize.min.js:6)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)

For the un-minified version of materialize, the error is:
materialize.js:4037 Uncaught TypeError: menu.velocity is not a function
    at HTMLAnchorElement.<anonymous> (materialize.js:4037)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)

So it seems like a catch-22 of loading just once somehow.
Closed issues referencing RequireJS issues seem to not touch on how to use RequireJS with CDNs.  I don't see a CDN hosting smaller individual modules for Materialize, so just importing the sideNav.js file is not an option.

Works when v1.2.3 of Velocity is used instead of 1.5.0.  Would still be curious to hear why the decision was made to package VelocityJS inside of min.js.  Would prefer that dependency to be broken out explicitly.

I would like to re-open this, as it's still an issue.  Manually fixing it inside of my materialize.js or materialize.min.js file isn't really a sustainable solution.


StopIteration is handled by the debugger when native code debugging is enabled

If you do something like
for (a, b, c) in os.walk(foo):
    pass

And you have native code debugging enabled, the debugger will break due to a StopIteration exception being thrown.  Strangely, if native debugging is not enabled, the debugger will ignore this.
I'm not sure how it even propagates up outside of the call to os.walk anyway, but either way, something seems wrong here.

Maybe this isn't specific to native debugging being enabled.  I just now got it on this line:
        dont_do_dsym_test = dont_do_dsym_test or any(platform in target_platform for platform in ["linux", "freebsd", "windows"])

when native debugging was not enabled.

I believe we have breaking on StopIteration disabled by default in Debug -> Exceptions for this exact reason (it just occurs too much for perfectly valid reasons). Can you check to see if that is enabled, and that doing "Reset" on your exception settings disables it?
Note that for pure Python debugger, there is a distinction between handled and unhandled, but it should really be unchecked for both. For mixed-mode debugger, all exceptions are considered handled by default, because support for distinguishing them hasn't been implemented yet.
StopIteration should normally propagate out of os.walk, that part is correct - that's how the for loop knows that it's done.

Here's an example of it happening with GeneratorExit.

Even if it does propagate out of the os.walk, it shouldn't ever result in a debugger break because it's handled by the loop.  I'm not sure about the case I've attached here, I assume GeneratorExit is handled by any() so maybe it's a similar cause?
All the checkboxes in the Exceptions window are unchecked, btw.

The determination whether something is handled or unhandled is a heuristic at best - Python doesn't have the notion of first and second pass for exception handling, so the best we can do is look at the code on the call stack, parse it, and try to figure out if it will actually handle things. That said, we should be able to do it for straightforward use of for, it just isn't done yet (which is, again, why the exception is disabled by default).
This window in VS 2015 is misleading - it only shows you one checkbox that corresponds to "break if thrown". Every exception actually has two flags: one determining whether debugger should break every time it is thrown (regardless of whether it's handled or not), and another determining whether it should break when it's unhandled.
I'm not actually sure if there's an easy way to change the latter setting for exceptions in advance in VS 2015 - the old modal dialog in previous releases has both checkboxes side by side, but now there's only one, and I can't find any UI to show both. However, if you look at the pop-up notification for the exception, it will have that checkbox for that particular exception type ("Break when that exception type is user-unhandled"). The default for this exception type should really be to have that unchecked, but on your screenshot it is checked.

I believe you can add an extra column to the new exceptions window to allow changing that option. But it is only available if you have Just my Code enabled.

Ahh, you can also right click the entry and there's a context-menu check item "Continue when Unhandled in User Code".  Which is confusing, because the on state of that checkbox is the opposite of the on-state in the popup window, but either way they're now both checked (on the context menu, not the dialog).


Add support for reCAPTCHA Invisible

Google has added a new type of reCAPTCHA called Invisible.
See reCAPTCHA invisible documentation

@PaulMiami any idea on timescales for this enhancement?

@egmfrs not sure I don't have much time for it at the moment

Would you be accepting this as a pull request? I might have some time to add it.

@SanderDeclerck any luck with this?

I should be able to create a pull request by the end of next week.
Outlook voor Android downloaden
On Mon, Dec 4, 2017 at 11:41 PM +0100, "dotnetshadow"<EMAIL_ADDRESS>wrote:
@SanderDeclerck any luck with this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@SanderDeclerck Awesome that would be great

I did some tests. The validator does not need to change. The form data is the same as for the standard recaptcha. Only a new tag helper is needed.
Invisible recaptcha is bound to the submit button of a form. My proposal would be to create two taghelpers.
First one: <input for-recaptcha-form>:
<form id="my-form">
   <!-- some input fields -->
   <input for-recaptcha-form="my-form" type="submit" value="Submit form" />
</form>

Second one: <recaptcha-invisible-script form-id />:
@section Scripts {
    <recaptcha-invisible-script form-id="my-form" />
}

I could have it implemented by the end of next week.

@SanderDeclerck good work, sounds like it should be simple enough

It has been implemented in the pull request I just created.

@SanderDeclerck thank you so much for this
Do you have a myget of your version?

@dotnetshadow no, I don't have it on myget, and I don't plan to either.
Just wait a bit, give @PaulMiami  some time to test and pull the changes.
If you want to use it earlier, then you could clone my fork and add a project dependency - or you could build the project and reference the dll manually.
I don't think there is much sense in creating a myget package just for a single build. One NuGet package for this project is enough: PaulMiami.AspNetCore.Mvc.Recaptcha. It makes it clear which version is the latest.

@SanderDeclerck  yes you are right, I was just wondering from a testing point of view but yes I will wait thanks again for your efforts. Much appreciated

You can always clone my fork if you wish to test. There's also a sample project in the solution.

Is anything still happening with this?


[LLVMGPU] Add multi-row vector reduction configuration for ROCm

This is to speed up matvec. The new configuration is constrained to a simple subset of matvecs and only applied on ROCm targets. I haven't evaluated this on CUDA, while adding it to the SPIR-V pipeline requires more work to lower down to vector types legal in SPIR-V.
In the future revisions, I plan to relax the heuristic and apply it to other matvec-like generics, e.g., matvec fused with dequantization.

Super cool stuff man! just have a couple questions. :)


Triggered open sensor

Please add another easy way to determine which "open sensor" triggered the alarm, directly from the Alarmo interface action configuracion or by MQTT message.

I also need to decide based on the sensor that fires the event

The request is not clear to me.
The following is in place:

In the alarmo interface you can configure a notification to be sent when alarm triggers, and use the 'open sensors' wildcard to show which sensor(s) caused the trigger.
In the MQTT interface you can subscribe to the event topic, and you will receive the 'trigger' event with JSON payload including the sensor(s) which caused the trigger.
In HA there is the alarm_control_panel entity which has the open_sensors attribute containing information of the sensors in case the state is 'triggered'.

What is missing?

Yes. Yes!... I always said it: I only know that I don't know anything...
I'm gonna check it.
The intention is to execute a specific script according to the sensor that is open.
Thank you very much for your help.

Well!... Yes, Yes, in the "Notifications" option I have the possibility to send the information of which is the open sensor (or which is the sensor that triggered the alarm). In the "Actions" option I have no way of knowing which is the open sensor.
Yes, I can find another way to obtain the information, but it is always adding more lines to the script or doing more laps that waste time (in the execution of the script).
I think it's a good idea to have the option to decide what to do in the same Alarm settings panel.
I try to write a usage idea:
Notification:
Alarm: "triggered"
is armed_home
is "sensor 1" send message 1 and photo 1
is "sensor 2" send message 2 and photo 2
etc...
Action:
Alarm: "triggered"
is armed_away
is "sensor 1" run "script 1"
is "sensor 2" run "script 2"
etc...
in this case each of the scripts looks for the appropriate photo and sends a whole message and photos using Telegram.
For my use case, today I am using the status of the sensors directly from HA, I can't find a quick way to do it using Alarmo. (always thinking "quickly execute the code").
I use, today (without Alarmo):
For when I'm home:
Perimeter alarm:
Message with the photo of the area.
Particular sound in a speaker.
When I am away from home:
Alarm:
Telegram message is sent to a group.
The message includes:
Photo of the area that triggered the alarm (Photo 1 or Important)
Photos of each of the remaining areas (Extra photos).
Link iP to the Live Cameras Panel.
Telegram buttons:
Turn on Siren - Request Photo of x Zone - etc...
I am very sorry that I don't have time to play Alarmo files and give you a better idea.
A hug.


Encryption

Hey
What is encryption file and how i can get it?

The encryption file itself is copyrighted and thus is not provided. It does appear here on a different repository, however we are not responsible for any of these.

How did you tested get_map_objects then?

We had someone test it for us :).

I use Mac OS El Capitan and try use this file: https://github.com/PokemonGoMap/PokemonGo-Map/blob/develop/pogom/libencrypt-osx-64.so
And getting this error:
Poke::API::Errors::UnknownProtoFault - An unknown proto fault has occured => [unknown type: size_t input_size

Can you help me with this?

Update your Ruby to 2.3.0+, it's a known issue with older versions of Ruby.


Getting to work on iOS with 0.27

Ok, so my last PR removed the React dependency as it's latest pod source references an outdated version of 0.14.  In order to get this completely working I am doing the following in my project's ios/Podfile:
source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '8.0'
use_frameworks!

workspace 'my-project.xcworkspace'
project 'my-project.xcodeproj'

target 'my-project' do
  # Depending on how your project is organized, your node_modules directory may be
  # somewhere else; tell CocoaPods where you've installed react-native from npm
  pod 'React', :path => '../node_modules/react-native'
  pod 'React/Core', path: '../node_modules/react-native'
  pod 'React/RCTGeolocation', :path => '../node_modules/react-native'
  pod 'React/RCTImage', :path => '../node_modules/react-native'
  pod 'React/RCTNetwork', :path => '../node_modules/react-native'
  pod 'React/RCTText', :path => '../node_modules/react-native'
  pod 'React/RCTWebSocket', :path => '../node_modules/react-native'
  pod 'react-native-maps'
end

I then add the React.framework to my Linked Libraries, and everything works.  I'm not sure if this is the best way to solve this, but thought I'd post this to start a discussion or help people in the interim.

I want to echo these changes, current master is broken while using CocoaPods

Hi, in case you get same error, just enable same platform than library podspec:
platform :ios, '8.0'
By default, this line is commented when you init a podfile in ios folder from a react native project. By uncommenting it, everything works and error disappear :)


[dubbo-1689]: Enhance the test coverage part-10 : dubbo-plugin module

What is the purpose of the change
unit test for dubbo-pluign, tracked by issue#1689
Brief changelog
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/GreetingCommand.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/HttpCommandDecoderTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/decoder/TelnetCommandDecoderTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/HelpTest.java
dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/command/impl/LsTest.java
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #1976 into master will increase coverage by 0.42%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1976      +/-   ##
============================================
+ Coverage     50.04%   50.47%   +0.42%
- Complexity     4707     4738      +31
============================================
  Files           562      562
  Lines         25213    25213
  Branches       4449     4449
============================================
+ Hits          12618    12725     +107
+ Misses        10688    10565     -123
- Partials       1907     1923      +16

Impacted Files
Coverage Δ
Complexity Δ

...he/dubbo/remoting/transport/netty/NettyClient.java
72.88% <0%> (-8.48%)
12% <0%> (-1%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
60% <0%> (-5%)
21% <0%> (-1%)

...e/dubbo/remoting/transport/netty4/NettyServer.java
72.13% <0%> (-3.28%)
9% <0%> (-1%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...ache/dubbo/remoting/transport/mina/MinaClient.java
58.46% <0%> (+1.53%)
9% <0%> (+1%)
:arrow_up:

...he/dubbo/registry/multicast/MulticastRegistry.java
57.74% <0%> (+1.67%)
41% <0%> (+3%)
:arrow_up:

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
89.71% <0%> (+1.86%)
15% <0%> (ø)
:arrow_down:

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
50% <0%> (+8.33%)
3% <0%> (ø)
:arrow_down:

...ava/org/apache/dubbo/qos/command/impl/Offline.java
12.5% <0%> (+12.5%)
1% <0%> (+1%)
:arrow_up:

...java/org/apache/dubbo/qos/command/impl/Online.java
12.5% <0%> (+12.5%)
1% <0%> (+1%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705bf37...059c7dc. Read the comment docs.


Link to documentation is broken 404

404: https://acmephp.github.io/acmephp/ssl/introduction.html

Still broken!

Still broken!

I didn't notice that indeed, but I'm planning to remove the website documentation and migrate it under the main repository as MD files anyway (less maintenance requirement). In the meantime you can find the doc here: https://github.com/acmephp/documentation

I didn't notice that indeed, but I'm planning to remove the website documentation and migrate it under the main repository as MD files anyway (less maintenance requirement). In the meantime you can find the doc here: https://github.com/acmephp/documentation

Might I recommend mkdocs: https://www.mkdocs.org/

Might I recommend mkdocs: https://www.mkdocs.org/


loginSignUpWindow too large

https://github.com/node-red/node-red/blob/master/red/api/auth/strategies.js#L58
36000000 equals to 10 hours!

huh - well spotted. Not sure what I was doing when I calculated that!


Only show files with status=published on Frontpage

Note! Files is visible to owners / admins when they aren't published.

Not logged in

Logged in

Fixed by #26


Update unicode-programming-summary.md

fix typo

@drvoss : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@corob-msft  - Would you review the proposed changes? Thanks.


Empty regions with coordinates

Hi, thanks again.
Just want to report something. Looks like some of the facilities have coordinates but does not have regions? Is that normal?
Thanks!

This issue comes with the endpoints DOH has.

PUI endpoint has Regions
Confirmed Cases endpoint has no regions

I try my best to join them but hospitals with confirmed cases and no PUIs would have no region information. A solution would be to query the google api for the address/region information but I unfortunately don't have the time to implement.
Would be happy to accept a PR :)


Plugins: Move IHostServiceProxy and IServiceProxy to Coral.PluginBase

While studying your code base I found a potential coupling issue: you are declaring both types IHostServiceProxy and IServiceProxy as well as their implementations in the same assembly, namely in Coral.PluginHost. This introduces a potential problem: every plugin assembly so now needs to reference Coral.PluginHost for the sole purpose of gaining access to one of the types IHostServiceProxy or IServiceProxy.
In the same time all other types in Coral.PluginHost are now accessible to every plugin as well, even those that are solely related to hosting plugins in general, not about implementing them.
To my understanding this is an architectural segregation issue. Plugin assemblies should never care about the way by whom or how they are going to be hosted.
I would propose to move IServiceProxy and IHostServiceProxy to Coral.PluginBase and make plugins depend only on Coral.PluginBase. This would ensure that plugins are given access only to the most essential interfaces and types they need to provide a working plugin implementation.

Hi!
Thank you for your comment - how did you find the project?
IHostServiceProxy allows plugins to gain access to certain services provided by the host. The type is then registered with the plugin's service provider so it can be accessed by the plugin. It resides within the Coral.PluginHost assembly because I wanted keep everything related to communication between the host and the plugin in one project.
How would you improve on the plugin hosts design?

I would propose to move IServiceProxy and IHostServiceProxy to Coral.PluginBase and make plugins depend only on Coral.PluginBase. This would ensure that plugins are given access only to the most essential interfaces and types they need to provide a working plugin implementation.

Would you like to create a PR for this?

Actually I found your GitHub repo and the Coral project by reading your really good article Plugins in .NET: Creating the plugin host.
Your codebase inspired me to derive a similar system based on your ideas. I will soon release some essential packages as well.
I could develop a PR for your codebase of course. I also developed a Roslyn analyzer that takes care, that assemblies only ever provide exactly one plugin implementation only, and that the implementations are declared as public classes with a public, parameter-less constructor as well.

Woah, that's really cool! I'm glad my ideas could be of help. :)


More reliable way to get the userAgent

https://github.com/ksmandersen/GoogleReporter/blob/ea9bce17695e69f0c39221d0b5f188b49e942a74/GoogleReporter.swift#L214
Instead of putting this string together from scratch, you can call:
let webView = UIWebView(frame: .zero)
let userAgent = webView.stringByEvaluatingJavaScript(from: "navigator.userAgent")

on iOS. On macOS, there's the slightly nicer:
let webView = WebView(frame: .zero)
let userAgent = webView.userAgent(for: baseURL)

@moreindirection This is amazing if true. I'll have to take a closer look. One problem however is tvOS where WebView is not available. So there needs to be another solution for that still.

Fixed in 2940d0f08180f8113720fe5cdfb9bd83e5e18bcc


Add note about embedding tilesets

Since Tiled 0.13 tilesets from tsx files are not included as json, but only referenced. To include them, you need to click the Embed tileset button (second from the left) on your tileset in Tiled.

This should solve issue #3 by adding a very short note in the README. It might be a good idea to add a helpful exception when detecting that a tileset is not embedded. @spajus Let me know if you think that's a good idea.

@phylor thanks! Definitely, it sounds like a good idea to add this exception. I haven't been doing anything with this gem (or Ruby game development) for a long while now, so not sure if I'll find the time to add this myself, but feel free to open a pull request.
Also, perhaps someone would be interested in becoming a maintainer?


Connection established successfully, but no output is shown on the window

Hello! I want to use this library for an Avalonia project which I started working on these lasts days just for fun for a custom viewer for my QEMU VMs, but I cannot make it work with my projects.
I've downloaded this repo and the sample project connects perfectly to my machine (either by <IP_ADDRESS> or <IP_ADDRESS>; both with ports 5901).

The logs don't show anything suspicious either:

/home/xavier/RiderProjects/MarcusW.VncClient/samples/AvaloniaVncClient/bin/Debug/netcoreapp3.1/AvaloniaVncClient
info: AvaloniaVncClient.Views.MainWindow[0]
Hello World!
info: MarcusW.VncClient.RfbConnection[0]
Connecting to VNC-Server on vnc://<IP_ADDRESS>:5901...
warn: MarcusW.VncClient.Protocol.Implementation.DefaultImplementation[0]
The TurboJPEG library is not installed on the current system. Please expect a performance drop, because the Tight encoding type is not available.
info: MarcusW.VncClient.RfbConnection[0]
Connection to vnc://<IP_ADDRESS>:5901 established successfully.

But when I try to add it to my projects, nothing appears on the screen.
I've created a small project with nothing but an empty window with the VncView component in it, and I followed the README.md steps.
MainWindow.axaml:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:fakevm="using:EmptyVNC.Views"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        xmlns:vnc="clr-namespace:MarcusW.VncClient.Avalonia;assembly=MarcusW.VncClient.Avalonia"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="EmptyVNC.Views.MainWindow"
        Icon="/Assets/avalonia-logo.ico"
        Title="EmptyVNC">

    <Design.DataContext><fakevm:MainWindow/></Design.DataContext>

	<vnc:VncView Connection="{Binding RfbConnection}"/>
</Window>

MainWindow.axaml.cs:
using System;
using System.Threading;
using System.Threading.Tasks;
using Avalonia.Controls;
using MarcusW.VncClient;
using MarcusW.VncClient.Avalonia.Adapters.Logging;
using MarcusW.VncClient.Protocol.Implementation.Services.Transports;
using MarcusW.VncClient.Protocol.SecurityTypes;
using MarcusW.VncClient.Security;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Hosting;

namespace EmptyVNC.Views
{
	public partial class MainWindow : Window
	{
		public object? RfbConnection { get; set; }

		public MainWindow()
		{
			InitializeComponent();

			Connect();
		}

		public async Task Connect()
		{
			IHost host = Host.CreateDefaultBuilder().ConfigureServices((context, services) =>
			{
				services.AddLogging(loggingBuilder =>
				{
					loggingBuilder.AddConsole();
					loggingBuilder.AddProvider(new AvaloniaLoggerProvider());
				});
			}).Build();

			ILogger<MainWindow> logger = host.Services.GetRequiredService<ILogger<MainWindow>>();
			logger.LogInformation("Hello World!");

			ILoggerFactory loggerFactory = host.Services.GetRequiredService<ILoggerFactory>();
			VncClient vncClient = new VncClient(loggerFactory);

			IAuthenticationHandler authenticationHandler = new DemoAuthenticationHandler();

			ConnectParameters parameters = new ConnectParameters
			{
				TransportParameters = new TcpTransportParameters
				{
					Host = "<IP_ADDRESS>",
					Port = 5901
				},
				AuthenticationHandler = authenticationHandler
			};

			CancellationToken cancellationToken = CancellationToken.None;

			RfbConnection = await vncClient.ConnectAsync(parameters, cancellationToken).ConfigureAwait(true);
		}
	}

	public class DemoAuthenticationHandler : IAuthenticationHandler
	{
		public Task<TInput> ProvideAuthenticationInputAsync<TInput>(RfbConnection connection, ISecurityType securityType, IAuthenticationInputRequest<TInput> request)
			where TInput : class, IAuthenticationInput
		{
			if(typeof(TInput)==typeof(PasswordAuthenticationInput))
			{
				string password = String.Empty;

				return Task.FromResult((TInput)Convert.ChangeType(new PasswordAuthenticationInput(password), typeof(TInput)));
			}

			throw new InvalidOperationException("The authentication input request is not supported by this authentication handler.");
		}
	}
}

When I compile the application, the window is empty:

And in the logs, it appears that the connection gets established successfully, but there's still no output on the screen.

/home/xavier/RiderProjects/EmptyVNC/bin/Debug/net5.0/EmptyVNC
info: EmptyVNC.Views.MainWindow[0]
Hello World!
info: MarcusW.VncClient.RfbConnection[0]
Connecting to VNC-Server on vnc://<IP_ADDRESS>:5901...
warn: MarcusW.VncClient.Protocol.Implementation.DefaultImplementation[0]
The TurboJPEG library is not installed on the current system. Please expect a performance drop, because the Tight encoding type is not available.
info: MarcusW.VncClient.RfbConnection[0]
Connection to vnc://<IP_ADDRESS>:5901 established successfully.

I'm using .NET 5 and Avalonia 0.10; from my Ubuntu MATE 20.04 LTS.
I noticed that the sample project uses .NET Core 3.1, I tried to switch my projects to 3.1 but still the same: white window.
I don't understand why the sample project works, but my projects do not. I've put everything the README says.
If I had to guess, I would say that I need something of MVVM and/or ReactiveUI, but I'm still a noob in these lasts things. I tried adding doing some MVVM tests but for now the same white window appears.
I've tried other VNC clients like Remmina 1.4.2, and it connects perfectly to the machine.
What I'm I missing here?

Without trying your code, I could imagine, that your issue is the Binding of the RfbConnection.  To use bindings, you should follow the MVVM pattern with a ViewModel and a DataContext set. Read here more about it: https://docs.avaloniaui.net/docs/data-binding/the-datacontext
With your code, I bet the Binding doesn't work and therefore the established RfbConnection is never assigned to the VncView.
If you don't want to use MVVM, you could also locate the VncView control directly from your code-behind by giving it a name, and set the Connection property to your RfbConnection instance. See here: https://docs.avaloniaui.net/guides/basics/code-behind#locating-controls
I'd highly recommend diving deeper into how Avalonia works.


Switch to the new gerrit url

Update gerrit url references to use the new gerrit server.

This should only be merged as part of a coordinated effort to switch gerrit servers