sometimes cucumber-jvm can't find the glue code

I use testng, having a xml test suite.
the test suite have several feature, each feature have it's test. just like this:
<suite name="regression_suite" verbose="1" parallel="false" thread-count="3">     <test name="regression1">         <parameter name="browser" value="ie"/>         <parameter name="browser_version" value="8" />         <classes>             <class name="F00001"/>         </classes>     </test>     <test name="regression2">         <parameter name="browser" value="ie"/>         <parameter name="browser_version" value="9" />         <classes>             <class name="F00002"/>         </classes>     </test>     <test name="regression3">         <parameter name="browser" value="ie"/>         <parameter name="browser_version" value="10" />         <classes>             <class name="F00003"/>         </classes>     </test> </suite>
sometimes the cases (F00003) running in the end would fail and the log shows glue code was not found while the cases running in the beginning with the same glue code pass

it seems the cucumber-jvm issue

Yes, if the test cases are running, this is either an issue in your implementation or cucumber-jvm


Server Crashing. Is this related to Engine Mode?

My Apex Hosted Minecraft Fabric Server is crashing, not sure why? It wasn't doing so before so I'm not really sure why it is now. Does this error make any sense? Trying to determine what is the cause/solution. If it needs more ram or something else.
I don't have any crazy mods, the server is crashing while the only online 3 Players are generating new chunks while exploring in the same direction.
I have removed Xray Mod and now no longer get crashes. Is this potentially a performance related thing?
Crash Report
https://drive.google.com/file/d/19N53cURs3o_pNTxFdJRgb-3h-8Zillnd/view?usp=sharing
Config File:
antixray.txt

Use the latest version of antixray. This has already been fixed!


[Addition]: Nebra Ltd fake locations

Hotspot b58 Addresses
1128yVaKo3SWz3beNW3DLPzSyXqSW6twHftHmw5ARv19obDsUijG
112vAU7MXoS2j28m2BySv3rLeQC9EREPm2dTdSuPY8V1GDjPT9SD
112Y9W1DnHfE21rwLFz21nEHw25kXZB2LxbPSkg95t5xvUG6d4Gf
Discord Handle
No response
Reason(s)
they are obvious self-witnessing and impossible long distance
they poping up on the same day
too good signal

There is one witness over 50km which is 101km which does seem excessive however this is witnessing multiple other vendors such as Bobcat, COTX, RAK, Sensecap etc
https://explorer.helium.com/hotspots/1128yVaKo3SWz3beNW3DLPzSyXqSW6twHftHmw5ARv19obDsUijG


Add Startup probe to charts.

Issue: https://github.com/rancher/rancher/issues/40824
Added the startup probe to the rancher-webhook chart so that the Webhook does not appear to be ready before it has updated the validating webhook configuration.
The startup probe checks every 5 seconds for 10 minutes before declaring that the webhook failed to start.
These values seemed reasonable to me but are up for discussion. 5s periodSeconds * 120 failureThreshold
In the second commit, I updated the integration test to install the newly packaged charts created in CI to provide us with a larger test coverage. I also added a command that will start tailing the rancher logs if Rancher-Webhook fails to deploy after 5 minutes.

It's probably also worth adding a liveness probe to the deployment with the same endpoint.


Fix: Overlap between menu and drop tooltip (issue 83)

Related Issue
https://github.com/ElliotForWater/elliotforwater.com/issues/83
Description
Previously, the drop tooltip was opening on mouseover which created a strange overlap if the hamburger menu was also open.
Now, the the drop tooltip only opens on click. It also closes on mouseLeave and on click (if open). This means if the user has opened the menu on the home page, the click required to open the drop menu  immediately closes the settings menu. Keeping the drop tooltip close functionality on close ensures the tooltip will not be open when the user starts interacting with the menu.
Impacted Areas in Application
This only impacts the tooltip/menu interaction bug.
Steps to Test or Reproduce
Open both the drop tooltip and the menu alternately. There are no cases where overlap occurs and the interaction still feels natural.
Related PRs
None

PR Checklist:

[x] My code follows the style guidelines of this project and I have double check my own code
[x] I have made corresponding changes to the documentation, if any
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run npm run test and be sure all test pass
[x] I have run npm run build:dev and be sure no error blovk the build
[x] I have test locally that everything run as expected
[x] I have properly fill in the PR template
[x] I have ask for reviews

Hi @gsambrotta -- chose this small issue as a contribution and tested locally to verify this solution. Let me know if there are any technical or procedural issues with this PR!

Hi @sarahsalder, awesome! This is a very important bug to fix for the experience of our users, so we are very grateful you picked this one.
PR template, is the one you see here above, where you can fill in info like:

Related Issue
Description
...

Please fill in those info so I can have a better understanding of what you are working on.
Thanks

@sarahsalder I finally had the time to check your PR.
Thank you very much for your code!!
There are just two corrections to make:

Your fixes apply just to the internal page, not to the home page. Homepage header is a separate component.
The idea is that the tooltip should close just when a user clicks outside the tooltip area. (on the menu button, on the search bar, on the background of the page, ... ) Basically same behaviour that the menu button has right now.

I find that UX wise, having a tooltip disappearing as soon as I move the cursor away, can be rather annoying.
Do you think you can work on those two improvements?

Closing this since the issue was fixed by another contributor #124


use latest jar-dependencies

should fix your problem with https://github.com/lookout/fast-rsa-engine/issues/28

@mkristian thanks!


Code detail

Hey, will some functions be released later, like SoftTargetCrossEntropy(), etc. ? Thanks!

Hi,
This is implemented in the timm library.

Got it! Thank you!


Clarified "Complimentary Plan" in the importer

refs https://github.com/TryGhost/Ghost/issues/15814

There's often a confusion around the logic of what makes "Complimentary Plan". It's especially confusing during the import process, where a bulk of members gets assigned to complimentary plan. This is a "quick and dirty" fix for the problem, something more holistic will be worked out in the future

This might get picked up at some point when we have time. Closing for now


Option to show the native variable view when not in the native editor experiment.

Command to show native variable view is available when not in the native experiment. View tries to open and just loads forever. It should not be available here.

Validated.


v0.2 on crates.io

Can you make a new release on crates.io for v0.2?

@raviqqe I tried to do this this morning, but ran into an issue.
error: failed to build archive: Opaque pointers are only supported in -opaque-pointers mode (Producer: 'LLVM15.0.0' Reader: 'LLVM 14.0.6-rust-1.64.0-nightly')

error: could not compile `mlir-sys` due to previous error
error: failed to verify package tarball

Is this due to mismatch between Rust LLVM version and the build source version?

@raviqqe I solved this by just rustup update -- so I perhaps do not need to know the exact source of the error.
A new version (0.1.3) should be available on crates.io now.

Thanks you so much!


Update concept-system-preferred-multifactor-authentication.md

correct the graph API path

@justinha
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


feature request: smooth results between detections on live video

When you view the hand demo the fingers wiggle a little bit.  This is due to the detection result values.  In a human hand the fingers do not wiggle like this.
Is there some way to smooth the data and take out the unnecessary wiggle?
Maybe compare change from one frame to the next for each finger and if the change is less then x keep the previous finger value.

library can only return results in a single point in time - it shouldn't do interpolation as it doesn't know how results are used the by presentation layer.
on the other hand, this is a good idea to implement in a presentation layer (e.g., demo app).
for example, current workflow is:
runHumanDetect():
    human.detect(input, userConfig).then((result) => {
      if (result.error) log(result.error);
      else drawResults(input, result, canvas);

and drawResults() then triggers next frame:
    if (elapsed > 33) requestAnimationFrame(() => runHumanDetect(input, canvas));
    else setTimeout(() => runHumanDetect(input, canvas), 33 - elapsed);

instead, it could be two separate loops:

runHumanDetect() running in its own requestAnimationFrame() loop as fast as possible
drawResults() running in its own setTimeout() loop at fixed 30FPS and drawing average of last drawn result and last available results (as updated by runHumanDetect())

i may create additional demo app for that as modifying original one would make it too much for casual user to follow.

this is the core to enable interpolation:
i've added user-configurable buffered execution browser.js:ui.buffered (also exposed in UI)

buffered: false means each detection run will be followed by screen draw
buffered: true means detection runs as fast as it can in the background and screen draw is performed at fixed intervals targeting user-defined FPS

but...since javascript is single-threaded, this only works as best-effort unless you enable detection to run in web worker thread (also configurable)
now, onto interpolation, since framework is in place, this is just a manual work - has to be done for each keypoint and landmark in each model output.
for example, draw.js:drawBody():
  if (ui.buffered) {
    lastDrawnPose[i].keypoints[pt].position.x = (lastDrawnPose[i].keypoints[pt].position.x + result[i].keypoints[pt].position.x) / 2;
    lastDrawnPose[i].keypoints[pt].position.y = (lastDrawnPose[i].keypoints[pt].position.y + result[i].keypoints[pt].position.y) / 2;
    ctx.arc(lastDrawnPose[i].keypoints[pt].position.x, lastDrawnPose[i].keypoints[pt].position.y, 2, 0, 2 * Math.PI);
  } else {
    ctx.arc(result[i].keypoints[pt].position.x, result[i].keypoints[pt].position.y, 2, 0, 2 * Math.PI);
  }

this can also be done using different methods, above is just averaging coordinates which means the first step is still going to be jumpy and then it's going to slowly converge.
much better approach would be linear interpolation - calculate each step while looking at ui.framesDrawn / ui.framesDetected as guidance for number of steps.
if someone wants to take this on, please go ahead - all changes should be limited to draw.js

One other part that I would like to have is the ability to process this type of data as new results.  For my case I am currently using the results data to animate a 3D character.  Would it be possible to return new results for output based on this smoothing code?

like i said - this is best done on app layer and the framework is ready - so go ahead.
it could be done in the library, but it's not where such things are commonly done - library returns singleton resultset from a point-in-time. it doesn't know ahead of time how many interpolations would you like or how fast does the redraw on presentation layer happen. nor it should.

Ok I understand.  I really don't know how to program something like this so I hope at some point you can add it to your demo.  Thank you very much for this app and your hard work!!!

here's a gist you can use as a template. it's intended to illustrate the approach, not to be used as-is:
https://gist.github.com/vladmandic/50f181b2393b8eddda7cf9c1be8b2c2e

Thanks.


tour: miss leading description

Context: https://tour.golang.org/concurrency/5
The description says "It chooses one at random if multiple are ready. "
However, after making the main routine waiting for 2 second, before calling func fibonacci, the channel should be the following:
c: 10 calls to get value from the channel
quit: 0
if "It chooses one at random if multiple are ready. " is true, then there is a 50% chance that the first call on the case in fibonacci will get the 0 from the quit channel. However, it is no the case. All 10 number will always get printed out before quiting. Hence it does not look like the selection is random.
reference code:
package main
import "fmt"
import "time"
func fibonacci(c, quit chan int) {
x, y := 0, 1
for {
select {
case c <- x:
x, y = y, x+y
case <-quit:
fmt.Println("quit")
return
}
}
}
func main() {
c := make(chan int)
quit := make(chan int)
go func() {
for i := 0; i < 10; i++ {
fmt.Println(<-c)
}
quit <- 0
}()
time.Sleep(2 * time.Second)
fibonacci(c, quit)
}

I got an answer fro stackoverflow.  fmt.Println(<-c) blocks until there are content in the channel. Sorry for the trouble!


[BUG] Keybinds are handled incorrectly leading to incompatibility with Controlify

Description
Currently, KeyHandler#tick is called every time a key event is fired, this is not correct behaviour.
Like all other key mappings in Minecraft, the key handler should be called once per tick.
Because of this difference, Controlify cannot emulate the key binds correctly so they can be used on a controller.
Steps to Reproduce

Install both Controlify and Shoulder Surfing
Attempt to bind a controller button to a key mapping registered by Shoulder Surfing
Observe that it doesn't work.

Expected Behavior
Shoulder Surfing and Controlify should work seemlessly, like most other mods with custom key mappings.
Screenshots
No response
Game Logs
N/A
Other Mods
Controlify
Additional Information
No response

Thanks for the report. I updated the implementation. From my testing, it seems to work now.
On another note, since you are the author of the mod: It would be nice if you could ship a refmap with your mod. This would allow loading it in a development environment, by simply putting it into the mods folder.

Thanks for the report. I updated the implementation. From my testing, it seems to work now.
On another note, since you are the author of the mod: It would be nice if you could ship a refmap with your mod. This would allow loading it in a development environment, by simply putting it into the mods folder.

Make sure your fabric loader and loom is up to date, it's a new feature where the mixins are remapped directly in the code without need for a refmap.

FYI it looks like the forge implementations are still affected by this.

Make sure your fabric loader and loom is up to date, it's a new feature where the mixins are remapped directly in the code without need for a refmap.

Thanks for the hint! I tested on 1.20.1, which has a very rather fabric version for compatibility reasons.

FYI it looks like the forge implementations are still affected by this.

Thanks for the pointer! I also updated the forge implementation.


[Bug]: DatabaseBackupJob fail

Description
Database backups fail with the following error :

Manual database work as expected.
Minimal Reproduction (if possible, example repository)
Create a backup job on a mongodb or postgresql database
Exception or Error
If you need logs, let me know 👀
Version
v4.0.0-beta.318
Cloud?

[ ] Yes
[X] No

New error now:

Performing a manual upgrade solve the issue. I think it happen after an automatic upgrade 🤔

Issue happen again, so upgrade dies not solve it :/

Error happen again after upgrading to v4.0.0-beta.320

Same i v3.0.0-beta.322

@andrasbacsai (sorry for the mention, but I can't reopen the issue and I don't know if you're enabled all notifications)

Upgraded to v4.0.0-beta.331 and error still occurs.

This error needs to be fixed somehow:
PullHelperImageJob failed with: Error response from daemon: toomanyrequests: retry-after: 244.706µs, allowed: 44000/minute
PullHelperImageJob failed with: Error response from daemon: toomanyrequests: retry-after: 385.552µs, allowed: 44000/minute

Closing in favor of the new issue: https://github.com/coollabsio/coolify/issues/3395


Root-level Parameterized pages rendered as [page] in sidebar

Bug Description

If you have a markdown page [my-page].md in the root of your evidence project, then it acts as a parameterised page as expected.
But it also shows up in the sidebar which looks weird.
For 1st and second level folders containing parameterised pages, this does not happen

Severity

[ ] Low - I'm able to keep using Evidence as normal, but flagging this for the team to fix

Expected Behaviour

Not show is sidebar
possibly crawl links in pages to determine which parameterized pages should be show in sidebar.

I think this is just a case of editing the logic in https://github.com/evidence-dev/evidence/blob/main/sites/example-project/src/components/ui/Sidebar.svelte to mirror what we do for 1st and 2nd level directories.

I took a quick look at this and it looks the root Sidebar elements are populated by the noFolders array in Sidebar.svelte. noFolders seems derived from the menu prop, which is an array passed by __layout.svelte.
That seems like the place to make the change. For the folder based sidebar elements it seems like you are simply checking for the existence of a [: if(!path.includes("/index.md") && !path.includes("[")). Adding a similar check for rootMDFiles (menu items) seems to prevent the parameterised sidebar elements from showing up at the root level.
for(let path in rootMDFiles) {
    pathEnd = path.replace('/src/pages/', '').replace(/^\.\//, '')
    if (path.includes('[')) continue; // change here
    menu.push({
        filename: pathEnd,
        label: pathEnd.replace(/\.md$/, '').replace(/_/g, ' ').replace(/-/g, ' '),
        href: "/" + pathEnd.replace(/^index\.md/, '').replace(/\.md$/, ''),
        hrefUri: encodeURI("/" + pathEnd.replace(/^index\.md/, '').replace(/\.md$/, '')),
        folder: undefined,
        folderLabel: undefined,
        folderHref: undefined,
        folderHrefUri: undefined,
        nameError: pathEnd.includes(" "),
        folderNameError: undefined
    })
}

I can make a PR for this if that sounds right, but still trying to figure out how to get the test suite running locally 😅

Running testing locally can be challenging as it requires accounts with Snowflake, Redshift, Postgres, BigQuery etc, so we typically run these in CI/CD.
If you’re having any other issues getting set up feel free to send me a dm in Slack!
PRs welcome though! (We can run tests on any PRs)


remove jQuery

Materialize 1.0 doesn't require jQuery as a dependency - https://medium.com/@materializecss/materialize-to-1-0-and-beyond-e0233b8ac15
I replaced $(document).ready(function () { with document.addEventListener("DOMContentLoaded",()=>{}); and it works well after quick testing (I have ESPHome running on Docker).
I wasn't able to test changes in login.template.html but the change there is very simple.

This will require the legacy to be dropped so we need the editor migrated or something else done before.
Thanks!

@glmnet that's the plan - to drop legacy code.
This PR is the first step, it only drops jQuery, but the functionality is unchanged.
As mentioned I replaced document.ready in legacy.js, all other functions in that file don't use jQuery, so I left them untouched.
Materialize js (which is used for toast messages) should be the next step.
I think that Monaco change should go first and then all the rest of the legacy code could be removed.
I'm not sure what browsers and in which versions are supported by the dashboard, that's something that should be added to the readme.

My bad. I though you deleted the whole legacy.js already

My bad. I though you deleted the whole legacy.js already

That's the next step :)
legacy.js has editor (ace) code, so after your PR gets merged we can remove the remaining parts.


Achievements Page

Hey @smaranjitghose , I would like to work on this issue. And can you add gssoc label to it also.

The other pages are not at all visible from the Achievements page.Fix this

Follow the same basic theme as the home page

Remove this.

Again please make the page (footer) consistent with the Home page

Have this in horizontal format

May I work on this issue? @smaranjitghose

@smaranjitghose please assign this issue to me, i am interested in working on this.

Please Can i work on this issue?

check this bug also and resolve it.

@anushbhatia I have fixed it along with a few sections on that page, I will be creating a PR soon. :)

Hey! @smaranjitghose  I have some ideas to implement on this page. So, can you plz assign me as well ?

increase the size of the logo
make the navbar the same as all pages
can you please make this page responsive too

please add colour to these.
divide the work @goyalmuskan and @mySTRiouscoder.
if someone else wants to contribute with them just message I will assign more work to you.

increase the size of the logos

increase the size of the logos

I made already as discussed on slack and gave a pull request but it was closed yesterday.

Remove this part and add a section "See what our members are up to", let the cards be in a similar fashion

Sir, why was I unassigned this issue? @smaranjitghose

If you wish to work on this more, I can reassign you

Sure, I can work on the section you've asked to edit above.

Remove this part and add a section "See what our members are up to", let the cards be in a similar fashion

this one

In the "See what our members are upto" section, I'll let the cards be the same, the data though, should I give social media icons in each card to view the member's profile on various platforms? @smaranjitghose

Ya let the cards be as its, no giving social media links is not required.


Newly created sessions aren't deleted if nobody actually joins them.

If somebody makes a request to /createSession but then doesn't join the newly created session, said session is never deleted. This is because the check for emptiness currently only takes place when a user leaves a session.
There should either be a regular check for all (or only newly created) sessions that removes them if empty, or session creation should be moved to when it is actually joined. It might make most sense to just add a timeout to every new session that deletes it again if nobody joins within something like a minute. That way, the interval is always the same for each session.

Going to take a look at it! Feel free to assign me.


Error Boundary listens to URL change

Right now, the Error boundary caches the most recent error, even across navigation events. Most of the time we'd like to flush this cache when the page moves to a new location.
Right now, you can work around this by setting a key prop on the ErrorBoundary, but since this is such a common pattern, ErrorBoundary should probably just do this by default
<ErrorBoundary key={location.pathname}>
...
</ErrorBoundary>

@rahul1 what do you think about wrapping the ErrorBoundary component with a parent that uses the useLocation hook? Something like..
const ErrorBoundaryComponent () => {
 // all the stuff it currently does
}

const ErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
  const isInRRDContext = useInRouterContext();

  let key: string | null = null;

  if (isInRRDContext) {
    const location = useLocation();

    key = location.pathname
  }

  return <ErrorBoundaryComponent { ...props } key={key} />
}

Untested but seems like implementing the workaround would be easier than clearing the cache itself based on route changes.

Hi @rahul1, can you please assign me to this issue?

Hi @Aquilaafuadajo - thank you for volunteering to help with this!
I think the proposed suggestion should work.  It will take a little bit of testing to ensure we don't accidentally cause unnecessary renders on URL changes.
Please feel free to reach out if you have any questions.  Thank you!


docs: replace gpt-3.5-turbo with gpt-4o-mini

gpt-3.5-turbo is not recommended for use as of July 2024 (https://platform.openai.com/docs/models/gpt-3-5-turbo) and it's accuracy has been unreliable in the last couple of months.
gpt-4o-mini is a recommended replacement and it's also ~3 times cheaper so it might be a good idea to use it as default model.

Thank you for this @xiormeesh would you please open this PR against K8sGPT and K8sGPT-operator to update our READMEs?


tpm_abstract: Fix ioctl number for adding entropy on x86_64

The previous change fixed the invalid argument error for the ioctl to add
entropy to /dev/random on ppc64le but broke it on x86_64 since the ioctl
numbers are architecture-dependent. This patch fixes it now for x86_64 and
ppc64le and skips all other systems that have an unknown ioctl number.
Signed-off-by: Stefan Berger<EMAIL_ADDRESS>

I apologize for the noise but didn't know the ioctl numbers were architecture-dependent...
A good alternative for this particular ioctl may be to remove the code entirely and rely on the Linux kernel mixing various entropy sources -- unless this ioctl is a selling point to run the agent on every system :-)

Please consider #653 as the alternative.


Error with latest version (2.2.0)

Hello,
Big thumbs up for the plugin, thank you.
With the latest version, I get the following warning with "ng serve". I have not tested with AOT mode yet.

WARNING in ./node_modules/ngx-take-until-destroy/dist/umd/take-until-destory.js
13:24-31 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

On on app run, following error is thrown,

take-until-destory.js:13 Uncaught Error: Cannot find module "."
at webpackMissingModule (take-until-destory.js:13)
at eval (take-until-destory.js:13)
at eval (take-until-destory.js:19)
at Object../node_modules/ngx-take-until-destroy/dist/umd/take-until-destory.js (vendor.bundle.js:2762)

I am using RxJS version 5.5.6
Thanks.

Can you verify that it's happening only with the latest version, please?

With the latest release, the issue is reproducible only with the pipe operator. When used with the this.destroyed subject, no compilation warning are seen and application runs fine.
On my other project, I am using the version 1.1.2 (by the way, I don't see that release in the release history anymore) and no errors there.

I think I know what the problem is.

Try with 2.2.1, please.

Fixed!
You have been super responsive and helpful. Thank you

Oops 😅


Add map positioning as a URL attribute; keep consistent when loading new layers

I've been meaning to write this one for a while. Resetting the map position whenever we load a new layer is frustrating. A user may have zoomed / panned to a specific area of interest but then loses that positioning by activating a new layer. Building off of the URL parsing feature (https://github.com/WFP-VAM/prism-frontend/pull/255), let's also add the necessary attributes (zoom and lat/long center position) to directly link to a specific view.

@wadhwamatic I think there are two different issues here:

the map position should not be reset whenever we load a new layer
the url parser should accept position and zoom so that users can share a link to a specific view. A caveat is that the view depends from the browser/screen size as well. Eg. the result will be very different on a desktop and mobile.

Yeah, agreed. I'll create two separate issues and close this one

Closing this issue. Refer instead to https://github.com/WFP-VAM/prism-frontend/issues/345 and https://github.com/WFP-VAM/prism-frontend/issues/346


Merge bitpay's upstream

This pull request includes the following features from https://github.com/bitpay/bitcoin:

https://github.com/bitpay/bitcoin/releases/tag/v0.12.1-bitcore-2

https://github.com/bitpay/bitcoin/releases/tag/v0.12.1-bitcore-3

https://github.com/bitpay/bitcoin/releases/tag/v0.12.1-bitcore-4

Are these features mission critical for 12.1 rollout?
12.1 branch is in feature freeze & bugfix mode, so I'd like to shift this to 12.2

nACK
This should not go into 12.1 unless there are critical fixes, IMO.

My apologies I should have included the reasoning in the description. This is a fairly important one but more on the Evolution Backend side of things. Specifically it relates to Insight API / UI as well as bitcore-node-dash: https://github.com/dashpay/bitcore-node-dash/issues/5 (and more specifically to https://github.com/bitpay/bitcoin/pull/29).
In short: the current release of bitcore-node-dash 3.1.3 is making reference to features that don't exist in dash core v0.12.1.x. We've merged up to https://github.com/bitpay/bitcoin/releases/tag/v0.12.1-bitcore.
Recently I noticed that insight-ui isn't pulling in "Latest Blocks" when using the latest build of bitcore-node-dash (you can see this at https://dev-test.dash.org). After some debugging I realized that is because it's making reference to an RPC command that isn't currently implemented in v0.12.1.x.
To fix that specific bug, I think only this commit would be needed: https://github.com/dashpay/bitcore-node-dash/commit/4a99870813d03554cf9d939504c16f917e71ef19.
As an alternative, we'd want to roll back the master branch on bitcore-node-dash to 3.0.1 (I've not yet published the update to 3.1.3 to npm so this is an option).

Why is this being held back until version v0.12.2.x ?
This is not just an enchancement but a bug fix also.

This is not a bugfix, but very specific Bitpay features - we don't want to break our stable branch 2 weeks before launch.

I believe the features that were requested have now been merged in via other PRs -- @UdjinM6 ok to close this 2-year old PR?

@nmarley I don't think any of these changes were merged in dash core (c++) but since no one complained I guess it was fixed in dashcore-node (nodejs) somehow, right?


confirmTransitionTo prompt require type string, maybe it shouldn't?

Hi all,
This may not make sense but maybe we could pass prompt as an Object? With this we can configure different outcomes of the getUserConfirmation function. Any thoughts about this or does it not make any sense?
Cheers

We are facing the same issue right now.
We'd like to have a multi-option confirmation popup (save/discard/cancel) and need a way to pass additional details about the actions, and an action handler into getUserConfirmation. This is currently not possible.
Any thoughts on this? More than happy to submit a PR if there is interest.

We are removing history.block (it's buggy, see #690), so this won't be an issue for us anymore.


3d hand timing mesh and error visualization code

Hello, can you provide complete 3d hand timing mesh and error visualization code to facilitate our comparison?

Please refer to https://github.com/fuqichen1998/Deformer/issues/8#issuecomment-2059640209  for the visualization code, which should help you to visualize.


Plugin broken?

I follow the instructions from here to setup recent version of wordpress https://www.makeuseof.com/tag/host-wordpress-raspberry-pi/.
Directly after installation I only install this plugin and directly start static site export with factory defaults  (Sub directory on current server and destination url set to /, debug log on).
Error:
Failed during "Crawling initial file list", please consult the Help tab for where to get assistance.
Expectation: the plugin should work with its factory defaults on a bare wordpress installation.
Export log
2019-06-30 01:51:25
PHP VERSION 7.0.33-0+deb9u3
OS VERSION Linux raspberrypi 4.14.98-v7+ #1200 SMP Tue Feb 12 20:27:48 GMT 2019 armv7l
WP VERSION 5.2.2
WP URL http://raspberrypi
WP SITEURL http://raspberrypi
WP HOME http://raspberrypi
WP ADDRESS http://raspberrypi
PLUGIN VERSION 6.6.5
VIA WP-CLI?
STATIC EXPORT URL /
PERMALINK STRUCTURE /index.php/%year%/%monthnum%/%day%/%postname%/
SERVER SOFTWARE Apache/2.4.25 (Raspbian)
Active plugins:
static-html-output-plugin/wp2static.php
Plugin options:
additionalUrls:
allowOfflineUsage:
baseHREF:
baseUrl: /
baseUrl-bitbucket:
baseUrl-bunnycdn:
baseUrl-folder: /
baseUrl-ftp:
baseUrl-github:
baseUrl-gitlab:
baseUrl-netlify:
baseUrl-s3:
baseUrl-zip:
baseUrl-zip:
basicAuthPassword: *******************
basicAuthUser:
bbBranch:
bbPath:
bbRepo:
bbToken: *******************
bunnycdnStorageZoneAccessKey: *******************
bunnycdnPullZoneAccessKey: *******************
bunnycdnPullZoneID:
bunnycdnStorageZoneName:
bunnycdnRemotePath:
cfDistributionId:
completionEmail:
crawl_delay: 0
crawl_increment: 1
crawlPort:
debug_mode: 1
detection_level: everything
delayBetweenAPICalls: 0
deployBatchSize: 1
excludeURLs:
ftpPassword: *******************
ftpRemotePath:
ftpServer:
ftpPort:
ftpTLS:
ftpUsername:
ghBranch:
ghCommitMessage:
ghPath:
ghRepo:
ghToken: *******************
glBranch:
glPath:
glProject:
glToken: *******************
netlifyHeaders:
netlifyPersonalAccessToken: *******************
netlifyRedirects:
netlifySiteID:
removeConditionalHeadComments: 1
removeHTMLComments: 1
removeWPLinks: 1
removeWPMeta: 1
rewrite_rules:
rename_rules:
s3Bucket:
s3Key:
s3Region:
s3RemotePath:
s3Secret: *******************
selected_deployment_option: folder
targetFolder: /var/www/html/mystaticsite
useActiveFTP:
useBaseHref:
useBasicAuth:
useRelativeURLs:
Installed extensions:
Core
date
libxml
openssl
pcre
zlib
filter
hash
Reflection
SPL
session
standard
apache2handler
mysqlnd
PDO
calendar
ctype
curl
exif
fileinfo
ftp
gettext
iconv
json
mysqli
pdo_mysql
Phar
posix
readline
shmop
sockets
sysvmsg
sysvsem
sysvshm
tokenizer
zip
Zend OPcache
Exclusion rules wp-json
Crawling /

Just a heads up that this isn't the export log but the default settings. If you enable debug in settings the debug log will be created as a txt file in your uploads directory. It will show you each page it has tried to crawl and the response for why it has/has not failed.

What do you mean with uploads directory, is this the target directory? No text file is written here. I tried different directories,

directories which are owned by apache user
owned by user
owned by root user
The directories are empty and existing.
I updated to raspbian buster which has php 7.3.

No luck, still the same error message.
The plugin seems really broken):

Hi @andre2007
Under WP2Static > Advanced Options > Enable Debug Mode you need to enable Debug Mode (which I think you have done)

This will generate an Export Log within your Wordpress 'media' directory.
This is typically wp-content/uploads
I use a 'roots' style directory structure for my sites so it looks a bit different
Within that you should have an 'export' file.

This should contain the info you posted with the actual crawl log after it
This should contain the output of the crawl

--
If the file 'stops' on Crawling / that is odd. It could be a permission issue (that it can't read anything and is timing out).

The export file from the uploads folder contains the same info as in the logs UI. It stops on crawling /. No additional info. Also the other file contain no valuable info. I also tried to switch language to English and also remote login to raspberry and start crawling from there. No success
It is strange as the crawling preview button from the UI indeed find other links.

@leonstafford could I ask you to enhance the debug log to get further information why the plugin stops/hangs on crawling / ?
At the moment the user has no chance to get any information why it "just not works".

Maybe the issue is related to a 301/.htaccess issue? Another static site plugin complains about 301 issue and that it cannot contact wordpress itself.
I installed wordpress to folder /var/www/html/wordpress. Within html folder there is an auto generated .htaccess file with content
# BEGIN WordPress
<IfModule mod_rewrite.c>
RewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php [L]
</IfModule>

Can WP2Static handle 301 forwarding?

I've just tried WP2Static with a new Wordpress install and have the same issue: Nothing in the log except Crawling / and the error message. This is Wordpress 5.2.2 on top of PHP 7.2 and nginx.

Another static site plugin complains about 301 issue and that it cannot contact wordpress itself.

If Wordpress is inaccessible to the crawler then it cannot crawl. What happens if you login to your Pi via Command Line and enter
curl -o - http://wordpressurl
It should be something like
curl -o - http://localhost/wordpress

I've just tried WP2Static with a new Wordpress install

@coljac is this on hosting or a Pi setup like @andre2007

@stirtingale This would count as a "hosted" environment (my Ububtu 18.04 desktop); yes the site is accessible from the CLI in the way you described above.

I can confirm, crawling is working fine using wget mirror and httrack on Raspberry .

Hi all - stale issue, sorry, but to inform V7 is now ready for testing and solves a lot of common problems. There's also better logging by default and a Diagnostics screen within which combined should start making things a lot easier: https://github.com/WP2Static/wp2static/releases/tag/7.0-alpha-003

Plugin has progressed quite a bit since this report, closing issue. If still having issues, please let me know with a new issue.


ERROR in node_modules/ion2-calendar/dist/calendar.controller.d.ts:1:33 - error TS2307: Cannot find module 'ionic-angular'. [ng] 1 import { ModalController } from 'ionic-angular';

Ionic version:  (check one with "x")
[ ] 2.x
[ ] 3.x
[ x] 4.x
Ion2-calendar mode:  (check one with "x")
[x ] components mode
[ ] modal mode
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] help me
Current behavior:

Expected behavior:

Steps to reproduce:

Related code:
insert short code snippets here
ERROR in node_modules/ion2-calendar/dist/calendar.controller.d.ts:1:33 - error TS2307: Cannot find module 'ionic-angular'.
[ng] 1 import { ModalController } from 'ionic-angular';

Other information:
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

I had the same problem and I solved it with npm install ion2-calendar@next moment --save

I had the same problem and I solved it with npm install ion2-calendar@next moment --save

Thanks @EDcasa .. it worked for me.

I tried the command above and still got the same error

same problem here


upgrade geo_types

update to geo_types 0.4
It might be worth waiting if a new version is pushed after this merge, but anyway I think it'll be a patch version change.

bors r+


Json Viewer:  Break long strings

Bug description
In Json Viewer long string overflows an element's box.
Linked to: #102
Steps To reproduce the bug

Search for message with id: aa8bc49c0e4bb2d1f509c1544b43b12ecfd27c0cc3c29f9faa555f799e4225ff
or navigate to  {host}/mainnet/message/aa8bc49c0e4bb2d1f509c1544b43b12ecfd27c0cc3c29f9faa555f799e4225ff

Expected behaviour
Break a long string and make it continue on the next line.

Actual behaviour

This has been resolved in d50c019ad2004642bc00c39b1834c4736a951f75


🚧 API: ReadableStreamBYOBReadDoneResult

Context
Specification: Streams
Specification interface: Interface ReadableStreamBYOBReadDoneResult TODO
Additional documentation:

mdn docs
deno docs
Cloudflare workers docs
Boa documentation

Expected TypeScript interface
/** @category Streams API */
declare interface ReadableStreamBYOBReadDoneResult<V extends ArrayBufferView> {
  done: true;
  value?: V;
}

@johnyob ReadableStreamBYOBReadDoneResult is not defined in https://streams.spec.whatwg.org/#dictdef-readablestreamreadresult.
The value is any. Should we take the deno interface for this case ?

This component is specific to deno impl and should not be implemented. Archived


implement probablistic equivalence checking

For now, a heavy draft - since it doesn't work!
My biggest question right now is how we should replace sdd_eq. In particular:

the (unsmoothed) weighted model count is a generic type, which requires weights (SddWmc<T>)
however, sdd_eq does not rely on the generic type (and in fact, does not have knowledge of it)
so, to replace invocations of sdd_eq with probabilistic equivalence checking, I feel like we ned to add the weights somewhere:

either, as a top-level variable in SddManager, which the user would need to set, or
in every invocation of sdd_eq, but that seems like it'd pollute the function namespace/make everything a generic

I did the latter in a test case in this PR, but it seems unsustainable. Am I missing a different implementation strategy?
Separately, I am trying to think of a reasonable non-trivial test case. The simplest one that comes to mind is:

A AND B
NOT (A OR B)

Is this a reasonable non-trivial case? Should I be shooting for something that uses an SDD under-the-hood (which would probably me more complicated)?

This is now outdated, so going to close this.


fix: move to new org

github.com/IBM -> github.com/oscal-compass
ibm.github.io -> oscal-compass.github.io
Types of changes

[x] Hot fix (emergency fix and release)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Release (develop -> main)

Quality assurance (all should be covered).

[x] My code follows the code style of this project.
[x] Documentation for my change is up to date?
[x] My PR meets testing requirements.
[x] All new and existing tests passed.
[x] All commits are signed-off.

Summary
Changes commensurate with new org.
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar. If you are working for a fork a maintainer will reach out, if required.

Closes #1482

@vikas-agarwal76 I have address the change you requested plus few other I found that were not addressed yet.

best I can tell, org-name = and org-remarks = in docs/cli.md also needs update.
the impetus of this change set doesn't appear anywhere, either?


Reverse ordering by file size

Process backup and restore files in reverse order.   This is more efficient at the end since you're less likely to end up with a single thread processing the last big file.

Fixed for restore in 1ac4b781fd304fcc6aa663afc324cdb2d1fdcb06.

Implemented in 0b6f81a.


Prevent built-in markdown Preview from showing for Evidence markdown documents when serer is starting and taking too long

          Issue using (I think) this functionality:

Repro
MacOS

create new project
install new project
Click run button in status bar

Expected
Server runs, Simple Browser opens, shows evidence page
Actual
server runs, Preview Opens, shows "cannot be found"

Originally posted by @archiewood in https://github.com/evidence-dev/evidence-vscode/issues/66#issuecomment-1577179589

I think the issue is being caused by this line:
https://github.com/evidence-dev/evidence-vscode/blob/ca2584a6557231eeef7c96b8e5cc09b86dbbc3d4/src/commands/preview.ts#L51
When you open a fresh project, the file you have open is not neccessarily a markdown file (and often nothing)
This means the URI does not contain /pages and it tries to boot the markdown preview

Yes. I need to add extra condition when server is started and we launch preview for the app home page in that condition.
This was a rushed extra check from this morning and I missed that scenario.

To make this much simpler for users to understand, I am going to change preview.ts command to show built-in markdown preview for all .md docs including emd when Evidence dev server is not running, and show app page preview in the built-in browser for the Evidence .md /page docs when your app server is running.
Example: server not running

Preview of same page when server is running:

You will be able to Preview emd docs in the built-in markdown preview via standard editor menu, even when the server is running.
I am afraid that's the best solution I can offer here for the v1.1.0 we want to release tomorrow.

This approach sounds sensible to me. I think it covers the major use cases. We can always revisit later once we get user feedback about it.

ok. moving that menu where vscode shows it too: https://github.com/microsoft/vscode/blob/main/extensions/markdown-language-features/package.json#L225

& you still have open markdown preivew to the side at the top of that editor context menu:

Adding this ticket to the v1.1.0 release tickets list for tracking (#65)

How is one meant to open the simple browser preview?
I can’t open it at all now - this feels like a regression vs 1.0.0
On June 5, 2023 at 21:39 GMT, Taras Novak<EMAIL_ADDRESS>wrote:
You will be able to Preview emd docs in the built-in markdown preview via standard editor menu, even when the server is running.
I am afraid that's the best solution I can offer here for the v1.1.0 we want to release tomorrow.
[image]https://user-images.githubusercontent.com/656833/243482445-6314eddf-6a8d-46cb-86eb-40f626bc1906.png
—
Reply to this email directly, view it on GitHubhttps://github.com/evidence-dev/evidence-vscode/issues/70#issuecomment-1577510853, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN3CLATIRPSWTKM3ULODMVDXJZGXFANCNFSM6AAAAAAY3JJST4.
You are receiving this because you were mentioned.Message ID: @.***>
[https://bolt.im/t/?NZl4YRur8qQUggmwSSogeVDaI6XDUGRXFGP8SKpmQfgQf8OMYlMesdgOMemaLRG9ixBZVhUTUHKCOX0d4BDt-Q]

Updated output to help us troubleshoot this:

the 1st is from preview.ts
app page is from server.ts
pinging is from httpUtils.ts

just so we can tell the diff:

How is one meant to open the simple browser preview? I can’t open it at all now - this feels like a regression vs 1.0.0

wait till I resolve this issue. It's actually very complicated because of .md and emd docs mixing.
Server start will open the app home page when it's ready to server pages.


Lack accuracy, running multiple times

Describe the bug
Hi,
Testing for XSS using the command dalfox url http://sudo.co.il/xss/level0.php?email=test --only-discovery, as example. Running this command multiple times like 10 times, dalfox sometimes finds the "Reflected email param" and sometimes not.
Not found :
Finder Of XSS and Dal is the Korean pronunciation of moon. @hahwul
[*] Using single target mode
[*] Target URL: http://sudo.co.il/xss/level0.php?email=test
[*] Vaild target [ code:200 / size:253 ]
[*] Using dictionary mining option [list=GF-Patterns] 📚⛏
[*] Using DOM mining option 📦⛏
[*] Start BAV(Basic Another Vulnerability) analysis / [sqli, ssti, OpenRedirect]  🔍
[*] Start static analysis.. 🔍
[*] Start parameter analysis.. 🔍
[I] Found 1 testing point in DOM Mining
[*] Static analysis done ✓
[*] BAV analysis done ✓
[*] Parameter analysis  done ✓
[I] Content-Type is text/html; charset=UTF-8
[*] Finish :D

Found it :
Finder Of XSS and Dal is the Korean pronunciation of moon. @hahwul
[*] Using single target mode
[*] Target URL: http://sudo.co.il/xss/level0.php?email=test
[*] Vaild target [ code:200 / size:253 ]
[*] Using dictionary mining option [list=GF-Patterns] 📚⛏
[*] Using DOM mining option 📦⛏
[*] Start BAV(Basic Another Vulnerability) analysis / [sqli, ssti, OpenRedirect]  🔍
[*] Start static analysis.. 🔍
[*] Start parameter analysis.. 🔍
[*] Static analysis done ✓
[I] Found 1 testing point in DOM Mining
[*] BAV analysis done ✓
[*] Parameter analysis  done ✓
[I] Content-Type is text/html; charset=UTF-8
[I] Reflected email param => Injected: /inHTML-none(1)  ,  =  +  ]  <  .  |  :  )  '  (  [  >  "  `  -  ;  {  $  }
    10 line:  Email <b>testDalFox</b> added to mailing
[*] Finish :D

It lack accuracy, dalfox should find the same thing everytime. If someone knows why, I'm all ears ;)
Environment

Dalfox Version: v2.2.5
Installed from: go-get

Hi @Liodeus
First of all, thank you for submit issue☺ I'm testing it, but it's not being reproduced.
is there any way, could you share the request/response when not reflected param using --proxy option?
$ dalfox url http://sudo.co.il/xss/level0.php\?email\=test --only-discovery --proxy http://<IP_ADDRESS>:8080

<IP_ADDRESS>:8080 => burp or zap or hetty or other proxy tools
[ e.g ]

If there is a detection-related phrase (DalFox) in the response and it is not detected, I think it is false positive. we need a test.

Hello again @Liodeus
Well, can I see some of the requested data with a proxy? I don't know what conditions/environment doesn't work. (it's hard to know because it's the same result in my environment).
There's a lot of possibilities. A defect in the undiscovered Dalfox or characteristic of the target service (e.g., different LB controls by country, typically AWS region, etc...).


extend/ENV/super: allow bottles with custom architectures

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?

Currently, Homebrew recognises only the architectures listed in
hardware.rb. [1] Attempting to pass an unrecognised architecture to
--bottle-arch while building a bottle returns an error.
Let's change that by passing unrecognised bottle arches to the compiler
instead of immediately failing with a CannotInstallFormulaError.
Partially resolves #5815.
[1] https://github.com/Homebrew/brew/blob/64b6846d6078525b8569834718f7b093a7dd05e1/Library/Homebrew/hardware.rb#L28-L42

Review period will end on 2021-05-11 at 00:00:00 UTC.


Create combine_contigs.smk

@brwnj What do you think of my solution to combine contigs?
This increases recovery of contigs from samples and should to construct large MAGs, which are still of high quality. It should be better than just do a co-assembly of all reads.
In addition it should allow to compare MAGs from different samples #87
Instead of calling Prokka on each sample one could call it on each genome.
If there are stain differences between samples, they should be identified afterwards by bined coverage.

I like this idea. Is this accurate:

merge contigs
align reads to contigs for coverage and bam
create bins (MAGs)

My recommendation would be that we then merge compatible bins:
https://www.nature.com/articles/s41564-017-0012-7#Sec10
Then we need to figure out what's necessary to link contig, loci, coverage across loci, and bin + bin QC data.

To do:

[x] merge contigs
[x] map reads to contigs
[x] create MAGs with concoct for low complexity samples
[ ] metBAT for high complexity
[ ] merge bins with check_m
[ ] call genes with prokka for each genome
[ ] quantify abundance of MAG and genes in each sample
[ ] combine abundance tables
[x] store bam
[ ] visualise with Anvi'o

@brwnj How should I integrate this part into Atlas.
replacing the annotation workflow,
Alternative workflow with command
Do you want to continue to call MAGs specific to each sample?

@brwnj Any comments on this branch?

Thanks for being patient on this one. I'll try to fully review soon.

Is this something we're hoping to add to the publication? I'm hoping to finish that soon and submit and this branch feels like it will need significant testing.

@brwnj  what do you think of combining bins with dREP ?https://www.nature.com/articles/ismej2017126


[JS] Try to guess what the date is when it doesn't follow the given format (issue #15490)

We use the format to guess in which order we can find month, day, ... we get the numbers in the date and consider them as month, day, ...

/botio unittest

/botio integrationtest

Oh I missed your approval, sorry for the noise.

/botio unittest


SceneView AR objects stretched on iPhone 7/8 Plus devices running iOS 12

Hello AFathi, we've been using your ARVideoKit in our app and it's super great! But we have run into a bug with iPhone 7/8 Plus devices running iOS 12.
We are finding that the recorded video on an iPhone 7/8 Plus is being captured at 4:3 aspect ratio, with the AR objects in the SceneView stretched (width). This is a new problem that has only occurred since the release of iOS 12- other devices running iOS 12 are fine, and so are Plus devices running iOS 11.
The live AR view appears fine, and I have confirmed that the SceneView is indeed matching the devices screen size, but the recorded video adds a little bit to the left and right edges of the view, outside of what is seen in the live view. The AR objects in the outputted video are stretched to match the extra width.
Any thoughts on what might be going on?

Hi Ahmed,
I have a folder here https://drive.google.com/drive/folders/1LbxeKtTVFwo3Wn0qSCdr8xaVBd0j4W9m?usp=sharing with the screen recording from the device (iPhone 7Plus) and the produced video.
Lukas, our developer is Cc’d on this email. He would be the go to re: any technical questions on this.
Andrew

On Oct 2, 2018, at 3:22 PM, Ahmed Bekhit<EMAIL_ADDRESS>wrote:
Hey,
Can you please share an example video of this issue?
Regards,
Ahmed Bekhit
On Tue, Oct 02, 2018 at 3:14 PM "People.Places.Things." < ">"People.Places.Things." > wrote:

Hello AFathi, we've been using your ARVideoKit in our app and it's super
great! But we have run into a bug with iPhone 7/8 Plus devices running iOS
12.
We are finding that the recorded video on an iPhone 7/8 Plus is being
captured at 4:3 aspect ratio, with the AR objects in the SceneView
stretched (width). This is a new problem that has only occurred since the
release of iOS 12- other devices running iOS 12 are fine, and so are Plus
devices running iOS 11.
The live AR view appears fine, and I have confirmed that the SceneView is
indeed matching the devices screen size, but the recorded video adds a
little bit to the left and right edges of the view, outside of what is
seen in the live view. The AR objects in the outputted video are stretched
to match the extra width.
Any thoughts on what might be going on?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
https://github.com/AFathi/ARVideoKit/issues/62 ) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AD6px8sfvCkYayvMZoo4eiSjFWyOvs8Cks5ug7sWgaJpZM4XEsJO
).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/AFathi/ARVideoKit/issues/62#issuecomment-426398847, or mute the thread https://github.com/notifications/unsubscribe-auth/AdVMTrvzdxKUYMPQFOqUjMXtS5o1cSpyks5ug70RgaJpZM4XEsJO.

Hey,
Can you try modifying the RecordAR.contentMode based on the device running your application?
Unfortunately I don’t have access to a large phone screen to reproduce that issue.
Please let me know if that resolves the issue!

Hey,
We tried it and it worked. Thanks!


1.2.0 Feature: Realtime: Channel Rewind (set channel options)

One of a family of pull requests addressing #3.

Having addressed @lmars' comment, I'm going to merge this pull request without waiting for approval. It has been open for a while and there is a stack of pull requests ahead of it. We are likely to have another look at the entire work at the end, to double check that it congeals holistically, so the risk of merge without approval is low.


Invalid kupo value JSON decoder

JSON decoder for KupoValue is invalid. It expect assets keys to be always in form <cs>.<tn> but when token name is empty kupo omits the dot as well. KupoValue uses GYValue parser under the hood.
Atlas version 09ab04bb6c6eb393ec4cae3fa078c38b59ab2b0f
Kupo version 2.8.0
Error:
KupoApiError "UtxoByRef" (DecodeFailure "Error in $[0].value.assets: .: not enough input" (Response {responseStatusCode = Status {statusCode = 200, statusMessage = "OK"}, responseHeaders = fromList [("Transfer-Encoding","chunked"),("Date","Mon, 08 Jul 2024 19:44:20 GMT"),("Server","kupo"),("X-Most-Recent-Checkpoint","53811823"),("ETag","aa9c60907ba7f70a2a723080b214c16cb3e58f617f3cc727cc5c1a6aa7e3d086"),("Content-Type","application/json;charset=utf-8"),("Access-Control-Allow-Origin","*")], responseHttpVersion = HTTP/1.1, responseBody = "[{\"transaction_index\":3,\"transaction_id\":\"3113b2ed36da9d0e8277f43e4cd53503e0552be2ae50b95100023e5158099542\",\"output_index\":3,\"address\":\"addr_test1wrpfqv65kts4aaz0tftafwv95fh460lnc5s7h69hckd06lgq7su4r\",\"value\":{\"coins\":1762790,\"assets\":{\"604eed076ac858d58278d943f3ae79f9a0ea958712cd50dda49c0a8b\":1}},\"datum_hash\":\"8ffb085299340929a6c62686374f8f86fd873da55c523fd88fd2981e6fc74e10\",\"datum_type\":\"inline\",\"script_hash\":null,\"created_at\":{\"slot_no\":53784599,\"header_hash\":\"0c09cf6f26ea010673d1226b5e0cf5150863cf4c513a083f53afe0822da4770d\"},\"spent_at\":null}]"}))

I've patched GYValue parser to be more flexible here but the actual (non-breaking) fix would be probably to implement a proper parser for kupo values that does not change GYValue as others depend on JSON instances already.

Thanks for identifying it! It should be fixed by this PR, please have a look.


xcodeproj is empty

Fetching https://github.com/ReactiveX/RxSwift using Carthage
Drag Rx.xcodeproj into our application project as subproject, Rx.xcodeproj is empty. It just shows targets information

Restarting Xcode 7.2 fixes the problem


Fix builds

Description
Currently, CI builds are failing after running ca. 10% of total number of examples. This happens due to a subtle bug in Yard's documentation introduced in 5deb08c329c0609429c2b8670ff139eb7a446635 (#1185).
Many RSpec examples rely on processing Yard's own documentation. Among them, following one: https://github.com/lsegal/yard/blob/75ca29898d2f6a9b1425125e6db4e42a2f3c2c4b/spec/cli/yardoc_spec.rb#L187-L190 The problem is that running Yard with --fail-on-warning option may cause abnormal exit in case of warnings. And this is actually happening, because @param tag should be followed by description:
https://github.com/lsegal/yard/blob/5deb08c329c0609429c2b8670ff139eb7a446635/lib/yard/docstring.rb#L380
The aforementioned RSpec example has been surrounded with begin-rescue-end block, so it no longer breaks builds in situations like this. Apart from that, a new Rake task test_doc has been implemented, which tests Yard's own documentation, and ensures that no warnings are generated. Finally, this Rake test has been included in Rake's default task, so documentation well-formedness is now tested in CI.
The build will fail, but this is expected. Bug introduced in #1185 hasn't been fixed (and I'm not going to fix it because people who know this project well will do it better, probably). Nevertheless, all tests are run now, and the build output is meaningful. Also, Rubies that Travis tests against have been updated.
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

This is great thanks!

Sorry, it appears that there are new code style offences which I need to fix first.

Style offence has been suppressed. Furthermore, newer Rubies have been added to the build matrix.

Coverage increased (+41.6%) to 93.646% when pulling b670cf978dd1abf732096bacc8d27bace9e39fd6 on skalee:fix-builds into 75ca29898d2f6a9b1425125e6db4e42a2f3c2c4b on lsegal:master.

Coverage increased (+41.6%) to 93.646% when pulling b670cf978dd1abf732096bacc8d27bace9e39fd6 on skalee:fix-builds into 75ca29898d2f6a9b1425125e6db4e42a2f3c2c4b on lsegal:master.

Doc fix was pushed to master so build should be passing now. Thanks a ton for diagnosing and fixing this!


Type safety not working for test callback params props

Package version
3.1.4
Describe the bug
Hi, awesome library, but im having problems trying to set it up, I have this config:
import { configure, processCLIArgs, run } from "@japa/runner";
import { expect } from "@japa/expect";
import { ApiClient, apiClient } from "@japa/api-client";
import dbConnection from "../src/db/db-connection.js";
import mongoose from "mongoose";
import { app } from "../routes.js";

ApiClient.setup(async () => {
  const connection = await dbConnection();

  // clean up the database before running the tests
  await Promise.all(
    Object.values(mongoose.connection.collections).map(async (collection) => {
      collection.deleteMany({});
    }),
  );

  return () => {
    connection.close();
  };
});

processCLIArgs(process.argv.splice(2));
configure({
  files: ["tests/**/*.spec.js"],
  plugins: [expect(), apiClient(`http://localhost:${process.env.PORT}`)],
  configureSuite(suite) {
    suite.setup(async () => {
      console.log("API suite setup");
      const server = app.listen(process.env.PORT, () => {
        console.log(`Server running at http://localhost:${process.env.PORT}`);
      });

      return () => {
        server.close();
      };
    });
  },
});

run();

and this test:
import { test } from "@japa/runner";

test.group("Health check", () => {
  test("should return status code 200", async ({ expect, client }) => {
    const response = await client.get("/");
    console.log(response);

    expect(response.status()).toBe(200);
  });
});

and im unnable to get typesafety and intellisense working in the context params props (expect and client), like, it works kinda okay, and I if I run the test it works, but, is not showing any intellisense with expect and client apis and is really annoying, I tried searching the types of the library but couldn't find anything, and I think it is meant to work just like that, but Im unnable to get the types working. idk if there are no types, or if its some bug, but, I cant really work without them. is there some work around?
I dont have too much time to create a reproducible repo, but you can checkout current mine, in this commit 7fa0a7a, the complete URL is this
Reproduction repo
https://github.com/kinal-team-1/DAEM-backend/commit/7fa0a7a

Hey @bcastillo-2022474! 👋🏻
It seems that you installed the "beta" version of our package. Could you try again with the latest release?

Closing since no response from the issue reporter and not actionable as well

Hey! I am facing the same issue, I cannot get the types to work on the TestContext.
Packages:
"@japa/api-client": "2.0.3",
"@japa/expect": "3.0.2",
"@japa/runner": "3.1.4",


Create method to handle prefixed intent messages in server

Signed-off-by: ArthurTemporim<EMAIL_ADDRESS>Fix Rasa-X to understands intent payload input, further discussion here.
Proposed changes:

Change Rasa to understands / messages
Create method parse_message_from_text() on agent.py (In RASA have others _parse_messages() methods, but this receive text type and not UserMessage object)

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog
[x] reformat files using black (please check Readme for instructions)

💯 let me know when it's ready for review

After all Travis CI checks, I will update the branch with master:D

@wochinge I think, we can merge as soon as the changelog is updated. What do you think?

@wochinge I think, we can merge as soon as the changelog is updated. What do you think?

@tabergma There is one test which makes me a bit worried. Did travis pass before?

Yes the build has passed here


Import kodi_version from kodiutils

Codecov Report

Merging #283 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   78.12%   78.08%   -0.04%
==========================================
  Files          18       18
  Lines        1842     1839       -3
==========================================
- Hits         1439     1436       -3
  Misses        403      403

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821d03b...b537040. Read the comment docs.


Inaccurate type for TextInput's onChange property

Describe the bug
I expected the onChange property of TextInput to have the same type as JSX.InstrinsicElements['input'], but it appears that currentTarget on the event is more than HTMLInputElement:

To Reproduce
Steps to reproduce the behavior:

Create a component with TextInput whose value is a piece of string state
Try to set the string state with onChange={e => setState(e.currentTarget.value)}

Expected behavior
No type error occurs.
Screenshots
See above with the current typing for onChange.

Added this to our planning project board. Thank you!


Inconsistent use of GARD IDs

In reviewing the term MONDO:0007804 'Pallister-Hall syndrome' for another ticket, I noticed that the GARD ID exists in two different formats. One where the number has zero padding (GARD:0007305) when added as the source value for a seeAlso and when added as am xref for to a synonym. Then when used as a database_cross_reference it does not have zero padding (GARD:7305).

Unclear if this is a one-off or needs to be explored further than just this example.

@matentzn I am assigning this one to you.

This is true, the GARD evidence from synonyms is from the old version, while the GARD xrefs are new. I would suggest we remove GARD evidence from synonyms until we get preferred label lists from them.. if you agree, I can make it happen


Black formatting is missing for documentation

Subj.

Have you checked that all notebooks are still correctly building after these changes? While I trust that the reformatting doesn't affect the python execution, I'm slightly less sure about how it works with jupytext.

Have you checked that all notebooks are still correctly building after these changes? While I trust that the reformatting doesn't affect the python execution, I'm slightly less sure about how it works with jupytext.

Yep, that looks fine.

Could you please rebase your branch and cherry-pick the latest three commits? It looks like you were on a stale branch when you created this branch.

Develop is up-to-date on my laptop.
(tf) artemav:~/code/GPflow/doc/source/notebooks (develop)
→ git pull
Already up to date.

Not convinced by the double blank lines in notebook code cells, but I guess I can live with that...

It's also missing for setup.py if you want to be comprehensive ?

Black strips all the trailing ; that we used in code cells. The reason we had those was that pyplot commands often return axes or other plotting objects, and notebook cells print the return value of the last executed line - so this litters up the notebooks. I don't think we should merge this without discussing what to do about all those cases.

Fixed the issue with _ =. It was a mixture of ; and _ =. Btw, ; it bad syntax, really easy to make an error with it.
Added the setup.py as suggested.


ValueError: function_call == None not supported (auto only)

Describe the bug
See log below.
Please describe your setup
MemGPT version
What is the output of memgpt version?
0.3.0
How did you install memgpt?
pip install pymemgpt
What's your OS
Fedora Linux 38
How are you running memgpt?
tmux Terminal
I did note the Q that seemed to have cause the error this time (note: siblings names have been changed here):
> Enter your message: Very good! All my siblings are younger than me and, in order, they are: x, x, x, x, x and x.
An exception occurred when running agent.step():
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/memgpt/agent.py", line 608, in step
    response = self._get_ai_reply(
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/agent.py", line 362, in _get_ai_reply
    raise e
  File "/usr/local/lib/python3.11/site-packages/memgpt/agent.py", line 342, in _get_ai_reply
    response = create(
               ^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 373, in wrapper
    raise e
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 346, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 465, in create
    return get_chat_completion(
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/local_llm/chat_completion_proxy.py", line 159, in get_chat_completion
    result, usage = get_vllm_completion(endpoint, auth_type, auth_key, model, prompt, context_window, user)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/local_llm/vllm/api.py", line 17, in get_vllm_completion
    raise Exception(f"Request exceeds maximum context length ({prompt_tokens} > {context_window} tokens)")
Exception: Request exceeds maximum context length (16604 > 16384 tokens)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/memgpt/main.py", line 356, in run_agent_loop
    new_messages, user_message, skip_next_user_input = process_agent_step(user_message, no_verify)
                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/main.py", line 332, in process_agent_step
    new_messages, heartbeat_request, function_failed, token_warning, tokens_accumulated = memgpt_agent.step(
                                                                                ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/agent.py", line 670, in step
    self.summarize_messages_inplace()
  File "/usr/local/lib/python3.11/site-packages/memgpt/agent.py", line 761, in summarize_messages_inplace
    summary = summarize_messages(agent_state=self.agent_state, message_sequence_to_summarize=message_sequence_to_summarize)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/memory.py", line 126, in summarize_messages
    response = create(
               ^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 373, in wrapper
    raise e
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 346, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/llm_api_tools.py", line 465, in create
    return get_chat_completion(
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/memgpt/local_llm/chat_completion_proxy.py", line 64, in get_chat_completion
    raise ValueError(f"function_call == {function_call} not supported (auto only)")
ValueError: function_call == None not supported (auto only)
? Retry agent.step()? (Y/n)

Your context length limit was reached. If you have a stack of Python traceback, make sure to look at the topmost one. You should try lowering the context length limit. You can achieve this via the CLI command memgpt configure. You can select the option 8,192 or 16,384 from the menu. It will warn the LLM to prepare for truncation once the current context reaches around 80% of the max context length.

This sounds like it is closely related to what I reported, and fixed, in #957.
I avoided this problem with function_call being None just by commenting out the whole condition and error.  This allowed me to proceed to find the next problem re the memory limit being exceeded.

Your context length limit was reached. If you have a stack of Python traceback, make sure to look at the topmost one. You should try lowering the context length limit. You can achieve this via the CLI command memgpt configure. You can select the option 8,192 or 16,384 from the menu. It will warn the LLM to prepare for truncation once the current context reaches around 80% of the max context length.

Hmm . . I tried:
memgpt run --agent phi_rho_05 --context-window 8192
and
memgpt run --agent phi_rho_05 --context-window 16384
but I still got the same error but:
memgpt run --agent phi_rho_05 --context-window 32768
worked! - which seems to make sense to me - but I thought I read somewhere that we weren't supposed to use that value . .


Generating a User Journey throws an Internal Server Error

Describe the Bug
As Tile says.

Updated to the new v2.12.0 update. (Image: docker.umami.is/umami-software/umami:postgresql-v2.12.0)
Going to Reports > Create Report > Journey > {website} / {any timerange} > Run Query
Throws an Internal Server Error

The environment is not critical, just for my personal use. I can rollback with an database dump and test some other stuff if that is necessary :)
Tested it in Firefox and Brave, disabled extensions and uBlock etc.
Database
PostgreSQL
Relevant log output
#### CONTAINER LOG ####
PrismaClientKnownRequestError:
Invalid `prisma.$queryRawUnsafe()` invocation:

Raw query failed. Code: `42601`. Message: `ERROR: syntax error at or near "event"`
    at In.handleRequestError (/app/node_modules/@prisma/client/runtime/library.js:122:6877)
    at In.handleAndLogRequestError (/app/node_modules/@prisma/client/runtime/library.js:122:6211)
    at In.request (/app/node_modules/@prisma/client/runtime/library.js:122:5919)
    at async l (/app/node_modules/@prisma/client/runtime/library.js:127:11167)
    at async l (/app/.next/server/pages/api/reports/journey.js:1:2025)
    at async K (/app/node_modules/next/dist/compiled/next-server/pages-api.runtime.prod.js:20:16853)
    at async U.render (/app/node_modules/next/dist/compiled/next-server/pages-api.runtime.prod.js:20:17492)
    at async NextNodeServer.runApi (/app/node_modules/next/dist/server/next-server.js:600:9)
    at async NextNodeServer.handleCatchallRenderRequest (/app/node_modules/next/dist/server/next-server.js:269:37)
    at async NextNodeServer.handleRequestImpl (/app/node_modules/next/dist/server/base-server.js:816:17) {
  code: 'P2010',
  clientVersion: '5.14.0',
  meta: { code: '42601', message: 'ERROR: syntax error at or near "event"' }
}

Which Umami version are you using? (if relevant)
v2.12.0
Which browser are you using? (if relevant)
Firefox, Brave
How are you deploying your application? (if relevant)
Kubernetes (Container/Docker)

There were no DB migrations this release, so no rollback of the database should be needed. I'm having a hard time reproducing it. What version of postgresql are you on? We use raw sql for the journey's query and it seems to be syntax with your instance vs mine, so trying to track it down.

Thanks for the fast reply :slightly_smiling_face:
Using the Postgresoperator from Zalando to rollout databases
the current version is: PostgreSQL 13.10 (Ubuntu 13.10-1.pgdg22.04+1) on aarch64-unknown-linux-gnu
i can try to update it to 14

I created a Postgre cluster with PostgreSQL 15.2. There it seems to work with the same data, so it seems like Postgre 13 has issues with the queries.

Okay, I have tested it with Postgres 12.14, 13, 14 and 15.
On 14 and 15 the journeys work.
On the other versions it reliably throws an Internal Server Error.
I have tested it with the compose and mounted files below.
For me the issue is solved and can be closed since I just upgraded to Postgres 15.
compose.yaml
services:
  umami:
    image: ghcr.io/umami-software/umami:postgresql-v2.12.0
    ports:
      - "3000:3000"
    environment:
      DATABASE_URL: "postgresql://umami:umami@db:5432/umami"
      DATABASE_TYPE: "postgresql"
    depends_on:
      - db

  db:
    image: postgres:13
    environment:
      POSTGRES_DB: umami
      POSTGRES_USER: umami
      POSTGRES_PASSWORD: umami
    volumes:
      - postgres_data:/var/lib/postgresql/data

  caddy:
    image: caddy:latest
    ports:
      - "8080:80"
    volumes:
      - ./site:/usr/share/caddy
      - ./Caddyfile:/etc/caddy/Caddyfile

volumes:
  postgres_data:

./site/index.html
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>My Static Site</title>

Welcome to My Static Site

This is a simple static website served by Caddy with Umami analytics.

Caddyfile
:80 {
  root * /usr/share/caddy
  file_server
}

Wow thanks for doing all the testing. Ill spin up a postgres 13 container and try to figure out the exact snippet that is failing, but thank for confirming.

Wow thanks for doing all the testing. Ill spin up a postgres 13 container and try to figure out the exact snippet that is failing, but thank for confirming.

Curious to know if found any workaround for running this report with postgres 13?


feat(headless): add search-parameter-manager controller

This PR adds the StateManger controller that exposes parameters relevant to include in the url. For the first PR, the manager only supports the q param.
The PR also exposes encoder and decoder functions to convert StateParameters to a string, and vice-versa. Atm, they are really simple. I will work more on these in later PRs when adding more parameters.

Looking at the current StateManager, it looks like it aims to be a partial SearchApp state manager, that's able to directly modify query params. That's fine, IMO it should be renamed to something more precise, because if someone extends Headless, like commerce, he might want to add another state manager (or extend/compose one).

Indeed, I renamed the controller to SearchParameterManager,

In the feature, I would keep the encoder/decoder and the action, but remove the definition.

I could not spot a better place for the definitions file. With the current placement, the definitions are next to the action that is being validated, and imported and reused in the controller. Another option could be to group the definitions with the actions, but then we would not be able to use export * in the index file.


change-list

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: change-list
Document link: change-list.md
My Issue/Suggestion
At some point it was explained that changes in a list in a NANOFLOW do not reflect outside of that nanoflow. This is where the behaviour of a nanoflow is fundamentally different from a microflow regarding lists (call by value vs reference). I wanted to point out the piece of documentation that describes this but I cannot find it anymore today.

Hi @tswarmerdam-mx,
Thanks for reaching out! This information is documented in the Differences between Microflows and Nanoflows section: please see the second last point in the list.
It was moved from the Nanoflows page. So if you bookmarked this section before, you won't be able to find it using the old URL.
I will also add a cross-reference to the Nanoflows page to point to this section, but the information you need is still not immediately visible. Have you tried our Search functionality at the top of the website? If you search "changes to a list in nanoflow", "change list sub-nanoflow", or just "list sub-nanoflow", you will find this information easily. If you've tried our search functionality but it didn't work for you, may I ask what words you used for searching? I might adjust our text to help find the relevant result.
Best,
Yiyun

More discussions were followed on Slack :)
PR was created and merged: https://github.com/mendix/docs/pull/8678/files.
I am closing this comment.


add disable logging files

does what #23 wants and adds a way to disable dump files

I tried testing your patch but it crashes my game on launch for some reason

I tried testing your patch but it crashes my game on launch for some reason

I will look it to that

I tried testing your patch but it crashes my game on launch for some reason

ok so I found the issue with the crash and I am working on a fix

I have fixed the crash but I had to remove the feature to disable dump files to fix the crash

Hey, your patch wasn't working because you need to check command line args after hooks are loaded. I created another commit (https://github.com/R2Northstar/NorthstarLauncher/commit/c9d66513a85d5325d3d002ca16c82d8302ec0ea2) to fix #23


Server-side automation for results submission

This change allows resctl-bench to be executed as an AWS lambda
function to validate result files and create issues on github
for them.
AWS lambda expects a `bootstrap' binary and does not give it any
arguments. For that reason we first look at our executable name to
decide whether we should be running as a lambda function and re-exec
ourselves with the appropriate arguments.
The lambda function's goal is to validate and submit benchmark results
to github as issues. The benchmark file is uploaded to S3.
Signed-off-by: Gustavo Noronha Silva<EMAIL_ADDRESS>

Can you please fix the code formatting that CI is triggering on?


Feature/dx safe provider

The purpose of this PR is to improve how DX handles/manages funds by introducing the usage of a specific Safe module.
By adopting the Safe Module, funds won't be stored on the DutchX's owner address anymore, but will stay on a Safe instance instead. Through the Safe module will be possible to interact with the Safe and access to funds, and in addition, more operation granularity is provided as the module can be disable at any moment by the Safe's owners.
The PR introduces the HDWalletSafeProvider, which proxies the ethereum calls/transactions through the Safe module when necessary.
Also a new configuration must be provided in order to enable the Safe version of the DX (https://github.com/gnosis/dx-services/blob/feature/dx-safe-provider/conf/network/ganache-config.js#L21).
Accordingly to the presence of the aforementioned configuration, the DX will detect to be on "Safe" mode, instead of "classic" one, and will proceed instantiating the Ethereum client by using the correct HDWallet provider.

Pull Request Test Coverage Report for Build 1230

75 of 165 (45.45%)  changed or added relevant lines in 9 files are covered.
22 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 41.645%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/helpers/instanceFactory.js
2
3
66.67%

src/getWeb3.js
30
41
73.17%

src/bots/SafeModuleBalanceCheckBot.js
0
33
0.0%

src/helpers/HDWalletSafeProvider.js
35
80
43.75%

Files with Coverage Reduction
New Missed Lines
%

src/repositories/AuctionRepo/AuctionRepoImpl.js
1
14.37%

src/web3.js
21
0.0%

Totals

Change from base Build 1228:
-0.2%

Covered Lines:
1718

Relevant Lines:
3882

💛  - Coveralls


Prevent TypeError on launch

Check if shortcuts constant exists before register/unregister, to prevent application trowing this error on application launch "Uncaught Exception: TypeError: Cannot read property 'forEach' of undefined"

Thank you for the patch @Hemmingsson!


No error from flutter refresh when it fails

I'm trying to refresh the Dart code for an application based on examples/hello_android.
I did this:
 flutter refresh --activity com.domokit.hub.HubActivity

I believe my activity is wrong because hello_android has a nested activity. However, flutter refresh fails with no error message.
When I enable --verbose, it shows the log below (slightly edited for sanitization). Note the error message that's not display unless --verbose is enabled.
   6 ms • /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb devices -l
   0 ms • Exit code 0 from: /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb devices -l
  24 ms • List of devices attached
          95266c40               device usb:2-1.2 product:bacon model:A0001 device:A0001
  68 ms • /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 shell getprop ro.product.cpu.abi
   0 ms • Exit code 0 from: /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 shell getprop ro.product.cpu.abi
  36 ms • armeabi-v7a
 328 ms • /media/jimbe/mojossd/sysui/src/third_party/flutter/bin/cache/artifacts/engine/linux-x64/sky_snapshot lib/main.dart --packages=/media/jimbe/mojossd/sysui/src/test/app/src/flutter/.packages --snapshot=/tmp/flutter_toolsZFMERn/snapshot_blob.bin
 561 ms • /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 push /tmp/flutter_toolsZFMERn/snapshot_blob.bin /data/local/tmp/dev_snapshot.bin
   0 ms • Exit code 0 from: /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 push /tmp/flutter_toolsZFMERn/snapshot_blob.bin /data/local/tmp/dev_snapshot.bin
 649 ms • /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --es snapshot /data/local/tmp/dev_snapshot.bin com.domokit.test.TestActivity
   0 ms • Exit code 0 from: /usr/local/google/home/jimbe/Android/Sdk/platform-tools/adb -s 95266c40 shell am start -a android.intent.action.RUN -d /data/local/tmp/dev.flx -f 0x20000000 --es snapshot /data/local/tmp/dev_snapshot.bin com.domokit.testTestActivity
   2 ms • Starting: Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x20000000 pkg=com.domokit.test.TestActivity (has extras) }
          Error: Activity not started, unable to resolve Intent { act=android.intent.action.RUN dat=/data/local/tmp/dev.flx flg=0x30000000 pkg=com.domokit.test.TestActivity (has extras) }
   2 ms • 'flutter refresh' took 1690ms; exiting with code 0.
   0 ms • ensureAnalyticsSent: 56ms

flutter doctor
[✓] Flutter (on Linux, channel master)
    • Flutter at /media/jimbe/mojossd/sysui/src/third_party/flutter
    • Framework revision 76b04cddde (8 days ago), engine revision d85ead8ec2

[✓] Android toolchain - develop for Android devices (Android SDK 23.0.2)
    • Android SDK at /usr/local/google/home/jimbe/Android/Sdk
    • Platform android-23, build-tools 23.0.2
    • OpenJDK Runtime Environment (build 1.8.0-google-v7-119990345-117822431)

[✓] Atom - a lightweight development environment for Flutter
    • Atom installed; Flutter plugin version 0.2.2

Flutter refresh is no longer a thing.


I cant patch OSX 10.8.3

The application doesn't even start.
It is complaining about compability with the OS.
This is the error:
Process:         MBPMid2010-GPU-Fix [249]
Path:            /Volumes/*/mbpmid2010-gpu-fix.app/Contents/MacOS/MBPMid2010-GPU-Fix
Identifier:      Lektroniik.MBPMid2010-GPU-Fix
Version:         0
Code Type:       X86-64 (Native)
Parent Process:  launchd [135]
User ID:         501
Date/Time:       2017-10-22 18:31:15.018 -0200
OS Version:      Mac OS X 10.8.5 (12F2560)
Report Version:  10
Interval Since Last Report:          9429 sec
Crashes Since Last Report:           82
Per-App Crashes Since Last Report:   3
Anonymous UUID:                      B8340EC8-F2CD-35BE-3241-143E1ADD93A6
Crashed Thread:  0
Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000002, 0x0000000000000000
Application Specific Information:
dyld: launch, loading dependent libraries
Dyld Error Message:
Symbol not found: _kCTLanguageAttributeName
Referenced from: /Volumes//mbpmid2010-gpu-fix.app/Contents/MacOS/../Frameworks/QtGui.framework/Versions/5/QtGui
Expected in: /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText
in /Volumes//mbpmid2010-gpu-fix.app/Contents/MacOS/../Frameworks/QtGui.framework/Versions/5/QtGui

It seems the version of Qt I use is not compatible with versions under 10.9.
I would recommend updating to 10.9 if possible.

Thanks for the response.
But I can't update, the system crashes, I've tried to update to sierra. I'll try 10.9

Could you update to 10.9 ?

You can also try to build the application from source. Let me know if you need help.

@AlexandreMagnolc Were you able to update ? I'll close the issue if I get no updates in few days.


v1.1.0 Error: Could not find the input entity for

Getting error when a new message received onNewMessage
Error: Could not find the input entity for {"CONSTRUCTOR_ID":2645671021,"SUBCLASS_OF_ID":47470215,"className":"PeerUser","classType":"constructor","userId":822063740}.
         Please read https://docs.telethon.dev/en/latest/concepts/entities.html to find out more details.
    at Object.<anonymous> (/var/www/Node/telegram-data/node_modules/telegram/client/users.js:294:15)
    at Generator.next (<anonymous>)
    at fulfilled (/var/www/Node/telegram-data/node_modules/telegram/client/users.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

For first time you you should send a message  media (sticker). Next update maybe I'll fix that so it doesn't have to send message media (sticker) for the first time.
Thanks you for report it.

should have been fixed in the latest version. Changelog


[PLAT-709] allow for @[osf] test urls

Purpose
Currently @[osf] wiki markdown tags only point to prod, this is not desirable for QA. This PR gives the markdown a bit of flexibility so QA/developers can access the staging/local servers by putting their url as the video id so while @[osf](guid1) will still always point to prod @[osf](localhost:7778/render?mode=render&url=http://<IP_ADDRESS>:5000/y98tn/?action=download%26mode=render%26direct) or @[osf](http://mfr-staging3.io/render?mode=render&url=http://<IP_ADDRESS>:5000/y98tn/?action=download%26mode=render%26direct) will validly point to
Changes

Modifies regex and return statment to allow for raw urls.

Side Effects
None that I know of.
QA Notes
For the exact MFR link, use the iframe or share button link.
Ticket
This is going to be required to test PLAT-709

@brianjgeiger linting errors fixed should be good to go.

Almost. Remember to run npm test before you push to be sure.

ug sorry about that should be a 100% now.


Issue when using 'date-format' or 'data-date-format' inside a  element

The incorrect date 'value' is being passed when a date-format other than its default format is specified. I can't quite understand the logic/outcome its producing but its producing a value that is at least 3+ years off the desired value.

Closing this issue as cannot replicate.
@pjayme if you can still replicate please provide a more specific example and I can resolve.


Fix state updates never coming back after reconnect

If we hit a connection or invalid auth error we would clear the _update_listener because it called shutdown which cleared the listener and closed the websocket connection.
We now only shutdown the websocket connection so
updates keep working once we reconnect

Confirmed this fixes it.
We should do another patch release with this fix.

Testing:
unplug shelly device.
Wait 2-3 minutes to make sure we see the disconnection.
Plug back in device.
Should recover within 10s now


Implement reservation zombie sweeper

Currently within the wallet's ChannelReservation workflow any reservation which are partially started but not ultimately completed are never cleaned up, meaning the allocated resources will be active until a daemon restart.
A "zombie sweeper" goroutine should be added which manually cancels reservations which haven't progressed for a certain "idle" period of time.

will take this one

Can I take this? It seems like it would be a good issue to get my feet wet :)

Looks like the last PR for this (#337) has been closed since Sep. 19th and the master branch still has this as a TODO. Going to pick this one up as a first issue unless someone else is actively working on it.

I was planning to pick this up, but feel free to, as I haven't started yet! 😀

Seems like this one is solved.

Yep, solved by #782 👍

Yup. This can be closed.


Remove OctreeMeta's Default instance

This is to make https://github.com/googlecartographer/point_cloud_viewer/pull/415 smaller.
This makes the two dangerous/unexpected parts more explicit and doesn't allow them to hide in ..Default::default(), namely:

You shouldn't use a zero AABB as the bounding box for generation, but the Default instance gave you such an AABB.
The two magic attributes "color" and "intensity".

The attribute data types are duplicated in two places now, but that's necessary for moving towards a state where octrees can have more attributes: The occurence in build_octree() will be removed, while the one in from_data_provider() will stay.
In the end, it's a matter of taste.

meow @feuerste

Having the Default implementation actually served the purpose of getting rid of redundant code. How about providing a new(resolution: f64, bounding_box: Aabb3<f64>) method instead?

Would it be fine to make that HashMap a constant as well?

Ok, we don't have lazy_static as a dependency, I'll go with the new method.

Using lazy_static and a const hash map is fine with me, too, whatever you prefer...