Tricks to prepare the training dataset

Hello,
I'm very interested in your great work! I have 3 questions, would you mind helping me with them?

I was wondering whether your network could be extended to use on other kinds of audio data, such as music. To this end, I tested it on different instrument datasets. In test 1, I had 33 instruments (like the "speaker" in your case), each containing only about 3 minutes of audio data. In test 2, I had 11 instruments, each containing about 1 hour of audio data. So overall, audio data in test1 is shorter than audio data in test2. However, when I ran the experiments on the same machine, test2 ran ~2-3 times faster than test1. Does the training speed have something to do with the number of "speakers" more than with the whole duration of the training data?
How would you recommend the duration for each .wav file. In your dataset, each piece of training data is rather short (~2-3 seconds). Would your network also work for long data such as 1-2 minutes?
For inference, you set the infer_step as 8 with a specific infer_schedule. Is 8 the best parameter in your experiments? If we want to test different infer_step, how should we set the infer_schedule?

Thank you very much for your help in advance!

Hi,
I'm not an author of this paper, but also working on bandwidth extension of music, so I'm very interested if you manage to apply  this method to music signals. I've also tried the same (for piano only), but quite unsuccesfully.
I think I can try to guess some answers to your quieries:

I guess that depends on how the dataloading is designed,  perhaps there is something suboptimal there on how the audio files are loaded. It is strange though, are you sure you are training on the same conditions? Just for curiosity, for how long are you training?

Anyway, it seems a bit too ambitious to me to train this model in a multi-instrument dataset. Also considering that this model is quite small (around 1M params), it would be hard for it to generete such diverse music. Did you get any interesting result?

It would be possible to extend the length of the segments, but 1-2 minutes is too much, you will run out of memory. What you should I guess is process small chunks and then concatenate them somehow. with overlap and add for example

8 seems to be a very small number, probably this fast inference schedule was finetuned for the speech dataset they trained on. If you train on a different dataset , this schedule would likely not work well, you will probably have to increase the number of steps or define another schedule by yourself.

@eloimoliner
Hi,
I'm not an author of this paper , but also working on bandwidth extension of music, so I'm very interested if you manage to apply this method to music signals.

" I've also tried the same (for piano only), but quite unsuccesfully."
as your reply mentioned. Is the generated music of poor quality?

2."It would be possible to extend the length of the segments, but 1-2 minutes is too much, you will run out of memory. What you should I guess is process small chunks and then concatenate them somehow. with overlap and add for example" .
I think so too, but I haven't done the experiment yet. Have you done this experiment.

@adagio715
Hi, I'm sorry for the late response.

We haven't tried on other kinds of audio, such as music. But we expect that our model is not only working on the speech. You may try to train with your dataset and test it. And for the answer to your question, we train with randomly selected chunks of each audio sample in the dataset with fixed length. So the training speed would not depend on the total length of your dataset, it would depend on the number of audio samples in your dataset. Additionally, we segment the training dataset and validation dataset in a fixed ratio based on the speaker, so if you want to handle it you may correct the cv_ratio in the config file. In conclusion, the training speed depends on the number of audio samples of the speaker used for training which depends on the cv_ratio in the config file.

As I answered above, we train with randomly selected chunks of each audio sample in the dataset, so the duration for each wav file is not that important. But we load the whole wav file first and then segment it, so it can be inefficient during dataloading.

I set the infer_step as 8 just for comparison with nu-wave in the same condition. To change the inference step, you can simply give the args.step as the input during inference. But it would only work well for large steps, above about 30, because it runs with a uniform noise schedule based on the log-snr which is not engineered. If you want to test with a different noise schedule you can change the code below. And as @eloimoliner answered (thank you for answering!), you may need to define another noise schedule for other datasets.
https://github.com/mindslab-ai/nuwave2/blob/c05a0b6135ce1c46b9a5e57f132f18d3e3091745/inference.py#L66-L70

@Seungwoo0326
Thank you very much for your explanation! Regarding your answer to our last question, if we try another inference step, how to define the infer_schedule accordingly? More specifically, for 8 steps, hparameters.yaml set the infer_schedule as infer_schedule: "torch.tensor([-2.6, -0.8, 2.0, 6.4, 9.8, 12.9, 14.4, 17.2])". We were wondering how these 8 specific numbers were determined?
By the way, we are not sure if we did something wrong, but we found your provided official checkpoint a bit strange. We used your source codes and tried the official checkpoint on the original low-resolution audio samples that are shown on your demo website. However, the results look much more like the NUWave model than the NUWave2 model. More specifically, the super-resolution frequency bands are very weak in energy. Could you be so kind to double-check if the provided checkpoint is correct? Or if you have heard similar issues, could you indicate what we might do wrong?
@eloimoliner @psp0001060
Thank you, both, very much for sharing your thoughts! So far, we have tried the model on the URMP dataset but the result is not very nice yet. The super-resolution part has too much noise. We think there might be two reasons for now: 1. the inference step and schedule are improper. 2 The training dataset is not enough.
If you manage to make it work well on your music dataset, it would be great to hear about your experience!

Hi,
I tried training it on MAESTRO, which consists of piano music, and the result was not much what I expected. Here you can see some spectrograms:

and here is the wandb report, where you can also listen to the audio examples.
https://wandb.ai/eloimoliner/diffusion_june_2022/reports/Training-NUWave2-on-MAESTRO--VmlldzoyNzM4MTE2?accessToken=bicl6e6c9c01oqm5hljlqkxsq8imfdmdfvpf8qvzmnm9q7h8efjwga1zm00itvqi
NUWave2 seemed to learn well where to add energy, but it seemed to fail at generating harmonics. I must say this is not a completely fair comparison, as I was not using the same diffusion parameterization as in the paper, my diffusion model is based on this: https://arxiv.org/abs/2206.00364, which I know that works quite well for music generation (I will publish the results in a couple of weeks). My experiment was only about the NUWave2 architecture (and the conditioning) . I want to believe that I did something wrong, but I cannot find any mistake. Anyway, it is a pity I can't include this model as a baseline.
@Seungwoo0326,
By any chance, did you find similar problems and have some intuition about why this may happen?

@eloimoliner
Thank you for sharing the result!
But I think you need to train more. We train our model for about 1M iterations but I can see that you only train for about 200k.
And I think we also observed a similar look of the spectrogram which you shared, in the middle of our training process.
The diffusion process is different from our's so it can be different. Despite that, I think you need to train more.
I welcome you to continue to share the results and discuss it!

@Seungwoo0326

@adagio715
I think my explanation in README may be confusing.
The 'sr' parser is the sampling rate of the "downsampled" input. So if you want to upsample from a 16kHz audio sample the 'sr' parser would be 16000.
I understand why you used the 'sr' parser as 48000, but my intention was to give the bandwidth of the input audio as a condition.
And if the sampling rate of your input is 48kHz, you also need to give '--gt' parser because with '--gt' parser we low pass filter the input before go into the model.
--checkpoint /PATH/TO/nuwave2_02_16_13_epoch=629.ckpt
--wav /PATH/TO/THE/AUDIO/SAMPLES/sample_1.wav
--sr 16000  # just for example
--gt  # you need this parser if your input is 48kHz one. If the sampling rate of your input is 16kHz same as '--sr' parser, you don't need this parser.

I think it can be still confusing but hope this explanation helps you understand. I will correct the README soon.
Please try it!
The case of 16kHz -> 48kHz
'input bandwidth: 16kHz, sampling rates: 16kHz -> --sr 16000'
'input bandwidth: 16kHz, sampling rates: 48kHz -> --sr 16000, --gt'
'input bandwidth: 48kHz, sampling rates: 48kHz -> --sr 16000, --gt'

@Seungwoo0326
Thanks for the explanation and the examples!
Just to clarify if you dont mind :) So, according to your examples on the demo webpage, for super-resolution audio samples at 48kHz, their "valid" frequency component is up until 24kHz (the Nyquist–Shannon sampling theorem). Now, if my input audio sample has a sampling rate of 48kHz, but its "valid" frequency component is only up until 8kHz, the parameters should be --sr 16000, --gt or --sr 8000, --gt?

@adagio715
For the case you said, it should be --sr 16000, --gt.
I just imagined the situation with the downsampled audio at a sampling rate below 48 kHz as the input and then added '--gt' parser for optional.
But I think it makes you very confused, I will correct it as soon as possible. Thank you for asking me.

Hi, the other day I tried experimenting with models and training
The generated music may have poor quality if the segment length is too short, as it may not capture the full musical structure. However, it can still be useful for research purposes.
Yes, I have experimented with processing small chunks and concatenating them with overlap and addition. It is a viable method for extending the length of the segments.

Thank you very much for your explanation! Regarding your answer to our last question, if we try another inference step, how to define the infer_schedule accordingly? More specifically, for 8 steps, hparameters.yaml set the infer_schedule as infer_schedule: "torch.tensor([-2.6, -0.8, 2.0, 6.4, 9.8, 12.9, 14.4, 17.2])". We were wondering how these 8 specific numbers were determined? By the way, we are not sure if we did something wrong, but we found your provided official checkpoint a bit strange. We used your source codes and tried the official checkpoint on the original low-resolution audio samples that are shown on your demo website. However, the results look much more like the NUWave model than the NUWave2 model. More specifically, the super-resolution frequency bands are very weak in energy. Could you be so kind to double-check if the provided checkpoint is correct? Or if you have heard similar issues, could you indicate what we might do wrong?
@eloimoliner @psp0001060 Thank you, both, very much for sharing your thoughts! So far, we have tried the model on the URMP dataset but the result is not very nice yet. The super-resolution part has too much noise. We think there might be two reasons for now: 1. the inference step and schedule are improper. 2 The training dataset is not enough. If you manage to make it work well on your music dataset, it would be great to hear about your experience!

The inference schedule in hparameters.yaml is set based on the authors' experience and the characteristics of the model. The specific numbers in the example are just a suggestion and can be adjusted based on the specific use case.
It's possible that the provided checkpoint is not the best one to use for the URMP dataset. It's always a good idea to try different checkpoints and see which one works best for your specific task. The quality of the results can also depend on the training dataset, so it's worth trying to improve the quality of the training dataset.
The authors of the paper suggest using the official demo audio samples, which are low-resolution audio samples. The super-resolution results might look different when using high-resolution audio samples. It's worth trying to use the official demo audio samples to see if the results are different.


Copilot showing the same recommendation twice

Example:

Plugin List:

Example:

Plugin List:

Are you using getCompletionsCycling or getPanelSolutions? Also if you hover it and preview the full body of the completions is there a slight difference or is it identical?

I was using getCompletionsCycling now im trying getPanelSolutions and i am getting the same thing with the later there are 2 options that are the same and one of them with slightly different whitespace but no actual text is different

sorry for all the images just seems like the best way to demonstrate :laughing:

when using the getCompletionsCycling i get 2 suggestions that look like the first and last suggestions from the last set of pictures which are the same

This should be fixed with the new defaults, make sure you are using getPanelCompletions and let me know if it persists.

I'm gonna close this since I think it's fixed and there hasn't been any activity but feel free to reopen if it persists.


Minimum image cropping size in pixels

I have an image editor with the fixed ratio(1:1), however I also want to limit zoom and cropping in pixels, so a user can't crop an image to size smaller than 1000x1000 px(or if one of the sides of a photo is smaller than 1000px, then we set the minimum size to this side value).
I'm wondering if it is possible in the latest version of Mantis?

Yes. You need to calculate it yourself though:
config.cropViewConfig.maximumZoomScale = imageRequirements.maximumZoomScale()

Here's my Kotlin code which does the calculation:
  /** This is useful so that you can't zoom in so far that the image will be smaller than our [minSize]. */
  @IosOnly fun maximumZoomScale(size: Size): Float {
    val minSize = minSize()
    val widthRatio = size.width / minSize.width.toFloat()
    val heightRatio = size.height / minSize.height.toFloat()

    return when {
      aspectRatio != null && size.width > size.height -> maxOf(widthRatio, heightRatio)
      else -> minOf(widthRatio, heightRatio)
    }
  }

@vanniktech Thanks! This helps a lot, but could you share your minSize() function implementation?

minSizePx is 1000 in your case:
fun minSize() = (aspectRatio ?: AspectRatio.IDENTITY).minSize(minSizePx)

@Parcelize data class AspectRatio(
  val x: Int,
  val y: Int,
) : Parcelable {
  fun minSize(size: Int): Size {
    val min = minOf(x, y)
    return Size(
      width = maxOf(x, size / min * x),
      height = maxOf(y, size / min * y),
    )
  }

  companion object {
    val IDENTITY = AspectRatio(x = 1, y = 1)
  }
}

I do support different aspect ratios as well though. If you don't need that you can drop it.

@vanniktech thank you! That resolved my problem


build-project command fails due to TOML decode error with Poetry 1.5.0 on Windows

Describe the bug
I've been successfully running poetry and the multiproject plugin with development version of poetry (and with 1.4.2 before that). After updating to the newly released 1.5.0, there's a TOMLDecodeError exception thrown when reading the transient pyproject.toml when building a project.
The exception is thrown at lib\site-packages\tomli\_parser.py:127 in loads, and is thrown because the compatibility TOML library, tomli expects a newline character exactly, and doesn't handle the \r\n sequence. It seems to be an issue primarily with tomli, but could also be addressed by normalizing newlines when creating project files.
The relevant stack trace is:
   7  .poetry-venv\lib\site-packages\poetry_multiproject_plugin\commands\buildproject\project.py:88 in handle
        86│             self.rewrite_modules(project_path, top_ns)
        87│
     →  88│         self.prepare_for_build(project_path.absolute())
        89│
        90│         super(ProjectBuildCommand, self).handle()

   6  .poetry-venv\lib\site-packages\poetry_multiproject_plugin\commands\buildproject\project.py:73 in prepare_for_build
        71│
        72│     def prepare_for_build(self, path: Path):
     →  73│         project_poetry = Factory().create_poetry(path)
        74│
        75│         self.set_poetry(project_poetry)

The path comes from create.create_new_project_file.
I tried with Python versions 3.8.10 and 3.11.2 on Windows 10.
To Reproduce

Create a virtual environment
Install poetry==1.5.0 and poetry-multiproject-plugin (optionally the poety-polylith-plugin),
Create a sample poetry project
Create a project, for example with the polylith tool, for example at projects/test,
Lock the project at project/test,
Run the command poetry -vvv build-project -C project/test, (or to debug run python -m pdb -c continue -m poetry -vvv build-project -C project/test,
Observe the error.

Error Log
The error should be roughly:
Loading the poetry-multiproject-plugin plugin
Loading the export plugin
Loading the poetry-polylith-plugin plugin
Using virtualenv: C:\Users\...\.poetry-venv
Using C:\Users\...\projects\test\pyproject.toml
Copied project & packages into temporary folder C:\Users\...\projects\.prepare_test
Generated C:\Users\...\projects\.prepare_test\pyproject.toml

TOMLDecodeError

  Expected newline or end of document after a statement (at line 1, column 14)

  at .poetry-venv\lib\site-packages\tomli\_parser.py:127 in loads
      123│             char = src[pos]
      124│         except IndexError:
      125│             break
      126│         if char != "\n":
    → 127│             raise suffixed_err(
      128│                 src, pos, "Expected newline or end of document after a statement"
      129│             )
      130│         pos += 1
      131│

On 3.11.2, with built-in tomllib the same error is thrown:
 at ...\3.11.2\Lib\tomllib\_parser.py:127 in loads
      123│             char = src[pos]
      124│         except IndexError:
      125│             break
      126│         if char != "\n":
    → 127│             raise suffixed_err(
      128│                 src, pos, "Expected newline or end of document after a statement"
      129│             )
      130│         pos += 1

Expected behavior
Loading the intermediate/transient project file during build-project should not fail due to TOML decoding errors.
The error does not appear when I insert the following line after components/project/create.py:11:
    generated = generate.generate_valid_dist_project_file(original, top_ns)
+   generated = generated.replace("\r\n", "\n")

Desktop

OS: Windows 10
Python version: 3.8.10 and 3.11.2
Poetry version: 1.5.0

Thank you @nurbo for reporting this issue!
I will have a look at it. I didn't experience any issues when upgrading to Poetry 1.5 on Mac OS X, and suspect this error might be OS-specific. The change made seems to be replacing tomlkit with tomli according to the changelog.
I will try to reproduce the error you experienced on Windows (and also Linux) and find a solution for it - your suggestion might be the best solution.

I believe the error is fixed, and have released a new version of the poetry-multiproject-plugin: v1.2.2
The issue was about Windows vs *nix line endings and the solution I chose was to set the newline property of open to an empty string. If I understand the docs correctly it will leave line endings unchanged.
https://docs.python.org/3/library/functions.html#open
Thank you again for reporting this and sharing a very detailed description with useful information! ⭐ 👏
Please let me know if it has solved your issue, otherwise please reopen or create a new issue.


Helm Add commonLabels option

Add Helm option to add common labels to all installed resources.

/approve

/retest


Improve local js dev experience

Currently, the instructions for local js development instruct to use yarn link.
However, yarn link doesn't install package dependencies like a yarn add does, causing us to require to temporarily yarn add each of the dependencies of an npm package we work on in the parent project from which we test our npm package.

This problem has been signalled to yarn for a few years now without any movement on the proposal.
The main option is to use yalc as a devDependency, which fakes yarn pack and yarn publish locally, causing the parent project to properly install dependencies of npm packages being worked on.
Since we rely on the parent project (bullet_train) to test out our javascript in system tests, this might be the best way to work.

yalc adds a bit of complexity to the development process, but that complexity could be abstracted away with bin/release and bin/develop scripts.
However, there doesn't seem to be an automated way to do something like yarn build --watch with yalc (unless maybe wiring into one of --watch's own callbacks).
The other option is to use yarn workspaces for all gem/npm packages. This would mean bringing back into the main repo the separate gems, and host them as sub-directories.
ActionCable (both the actioncable gem and the actioncable npm package) has its source code stored as a workspace under the main rails/rails project. yarn links's limits might just be the reason why they chose to use a workspace instead of a separate repo.
But bringing back all the gems' source code into the bullet_train starter repo just because yarn is broken for properly installing yarn link'ed package dependencies? That seems like a stretch.
So I'll proceed with yalc.

I tried an alternative: inline all dependencies using microbundle --external none (rationale in microbundle docs) but only in dev, while still using yarn link.
Nope. Still getting this garbage:

As for running yarn build --watch and stringing yalc push after a build, we might want to check out nam-watch.

So I just tested with yalc and it solves the problems with dependencies.
The process (very manual for now):
In the gem/npm package, build and publish locally:
yarn build
yalc push

In the upstream package:
# the first time
yalc link <npm package name>

# subsequent times, each time a push is done in the gem/npm package
yalc update


kubevirt-api 1.2.1

📝 Description
Upgrade kubevirt-api to version 1.2.1

/hold
let's try updating k8 to 1.28.X or 1.29 before adding some strange TS hacks to over come glitches


add RPC call to retrieve invoices

close #92

Tested and works

I didn't mention it but I also tested it :)


feat: add specialised replicated maps

Refs https://github.com/lightbend/akkaserverless-java-sdk/issues/48. Add specialised replicated maps for counters and registers, similar to Java SDK. Test with the new TCK tests from https://github.com/lightbend/akkaserverless-framework/pull/802 (needs to be published first, draft PR here). And support the new replicated maps from https://github.com/lightbend/akkaserverless-framework/pull/803. Refs https://github.com/lightbend/akkaserverless-java-sdk/issues/49.

Rebased and updated for the TCK in TypeScript now (from #147).
Still needs https://github.com/lightbend/akkaserverless-framework/pull/803 to be released first.

Rebased and updated to framework release 0.7.0-beta.16.


Format endnote and endexample markers

The end note and end example marker for a note should be at the end of a single paragraph note. If a note spans multiple paragraphs (including notes that contain examples or lists), the end note or end example marker should be its own paragraph.
I searched for both end note (first commit) and end example (second commit) and made the updates to those that didn't follow the format we agreed on.

@jskeet  I'm looking into it this morning. I've already got this PR local, so I'll track it down.

Found it! (actually two issues).
The good news is the word converter worked correctly, and helped find two additional formatting issues.


horizon error when trying to deploy in JSX

I have FreeTFTs in the wallet
and I'm using Freefarm (1)
registered_reservation = zos.reservation_register(r, expiration)  ->
SX> registered_reservation = zos.reservation_register(r, expiration)
Tue 05 12:35:48 s/explorer/errors.py -  23 - raise_for_status                   : EXCEPTION:
HTTPError('424 Client Error: invalid account address: horizon error: "Resource Missing" - check horizon.Error.Problem
for more information for url: https://explorer.grid.tf/explorer/reservations')
--TRACEBACK------------------
 in
1
/sandbox/lib/jumpscale/JumpscaleLibs/sal/zosv2/ZOSv2.py in reservation_register
123    return self._explorer.reservations.create(reservation)
/sandbox/lib/jumpscale/JumpscaleLibs/clients/explorer/reservations.py in create
16    resp = self._session.post(self._base_url, json=reservation._ddict)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in post
578    return self.request('POST', url, data=data, json=json, **kwargs)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in request
530    resp = self.send(prep, **send_kwargs)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in send
650    r = dispatch_hook('response', hooks, r, **kwargs)
/usr/local/lib/python3.7/dist-packages/requests/hooks.py in dispatch_hook
31    _hook_data = hook(hook_data, **kwargs)
/sandbox/lib/jumpscale/JumpscaleLibs/clients/explorer/errors.py in raise_for_status
23    raise HTTPError(http_error_msg, response=resp)
Tue 05 12:35:48 s/explorer/errors.py -  23 - raise_for_status                   : EXCEPTION:
HTTPError('424 Client Error: invalid account address: horizon error: "Resource Missing" - check horizon.Error.Problem
for more information for url: https://explorer.grid.tf/explorer/reservations')
--TRACEBACK------------------
 in
1
/sandbox/lib/jumpscale/JumpscaleLibs/sal/zosv2/ZOSv2.py in reservation_register
123    return self._explorer.reservations.create(reservation)
/sandbox/lib/jumpscale/JumpscaleLibs/clients/explorer/reservations.py in create
16    resp = self._session.post(self._base_url, json=reservation._ddict)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in post
578    return self.request('POST', url, data=data, json=json, **kwargs)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in request
530    resp = self.send(prep, **send_kwargs)
/usr/local/lib/python3.7/dist-packages/requests/sessions.py in send
650    r = dispatch_hook('response', hooks, r, **kwargs)
/usr/local/lib/python3.7/dist-packages/requests/hooks.py in dispatch_hook
31    _hook_data = hook(hook_data, **kwargs)
/sandbox/lib/jumpscale/JumpscaleLibs/clients/explorer/errors.py in raise_for_status
23    raise HTTPError(http_error_msg, response=resp)
424 Client Error: invalid account address: horizon error: "Resource Missing" - check horizon.Error.Problem for more information for url: https://explorer.grid.tf/explorer/reservations
JSX>

This error is cause the wallet address of one of the farm used in the reservation is not valid. This prevent the reservation to be paid so the explorer refuses it directly.
The error message has been improve to be more user friendly already: https://github.com/threefoldtech/tfexplorer/commit/09a28823f75877af64faa53dea793d197aa066f1


PowerToys Run Freezes on Input After Enabling Results Sorting (Disabling Does Not Fix)

Microsoft PowerToys version
0.60.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

Enable "Results order tuning"
Adjust "Global sort order score modifier" for one or more active plugins
I set Window Walker to a greater number than Program (side note: entry allows arbitrary strings)
Activate PowerToys Run and type
Observe PowerToys Run freeze (see screenshot)

Even after disabling results order tuning, disabling PTR and restarting PowerToys, the freezing behavior remains.
PowerToysReport_2022-07-11-10-04-41.zip
✔ Expected Behavior
Ability to use PowerToys Run
❌ Actual Behavior
PowerToys run freezes
Other Software
No response

@jaimecbernardo
And we should fixed the control type in settings as @ianelletson mentioned to limit input to digits.


[hold] Update bundle version to 4.2.0-rc.0

Pushing this as otherwise CI is broken since the bundle it uses was switched to rc.0


ERROR: File not found #import "React/RCTBridgeModule.h"

Hello I just install a react native project (without EXPO)
I have done the install and i got that
node_modules/react-native-share-extension/ios/ReactNativeShareExtension.h:2:9: fatal error: 'React/RCTBridgeModule.h' file not found #import "React/RCTBridgeModule.h"

This may not be an issue related to this module, specifically:
https://stackoverflow.com/questions/41663002/react-rctbridgemodule-h-file-not-found

Check out https://github.com/alinz/react-native-share-extension/issues/182


chi_magic.py

this program is still in data model 2 only.  needs upgrading to data model 3 and while we're at it, should go into ipmag as a notebook friendly version.

I made a notebook version in PmagPy_nb that works well.  maybe we should just move chi_magic.py to chi_magic2.py and use the version in PmagPy_nb  as a start for chi_magic.py which would be data_model 3 only.

Sounds good.  Do you want me to put this on my list, or do you want to do it?

not urgent.  maybe i will get to it eventually. it works in _PmagPy_nb

On Jun 12, 2018, at 11:38 AM, Lori J<EMAIL_ADDRESS>wrote:
Sounds good. Do you want me to put this on my list, or do you want to do it?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/365#issuecomment-396691938, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDVZU414kt9er05oix1K2n1q05eVjks5t8AqrgaJpZM4UhwgF.

I've basically finished with upgrading chi_magic, although it is a little bit simplified from how it worked in 2.5.  There isn't interactive entry anymore, and it only generates two plots instead of 3 (I just adapted what you have in the notebook instead of upgrading chi_magic2 directly).  Have a test if you want, I can add more to it asap or we can also flesh this out later if it isn't a high priority.

thanks lori - this is not top priority.
lisa

On Aug 2, 2018, at 2:30 PM, Lori J<EMAIL_ADDRESS>wrote:
I've basically finished with upgrading chi_magic, although it is a little bit simplified from how it worked in 2.5. There isn't interactive entry anymore, and it only generates two plots instead of 3 (I just adapted what you have in the notebook instead of upgrading chi_magic2 directly). Have a test if you want, I can add more to it asap or we can also flesh this out later if it isn't a high priority.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/365#issuecomment-410073970, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDd8CA9U5jSTL6_b706HAGbAQfGj-ks5uM29xgaJpZM4UhwgF.


Invalid JSON structure throwing UnrecognizedPropertyException  results in SERVER_UNHANDLED_ERROR 500 failure

Looking at unmapped exceptions, there is one logged as:
Unrecognized exception caught, mapped to SERVER_UNHANDLED_ERROR: Unrecognized
field "title" (class io.stargate.sgv2.jsonapi.api.model.command.impl.InsertOneCommand),
not marked as ignorable (2 known properties: "document", "options"])

com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field
"title" (class io.stargate.sgv2.jsonapi.api.model.command.impl.InsertOneCommand),
not marked as ignorable (2 known properties: "document", "options"]

which we should be able to map better.

Fix via #1213: mapped, includes set of valid field names to use instead.


Feature request: 'Ignore comments' checkbox in the 'Find' dialog

Wide popularity of the embedded documentation conventions like JSDoc and C#'s XML comments leads to a situation where comments often constitute the bigger part of a source file (e.g. look at the source of angular.js: the whole API documentation is there!). This abundance of comments makes it extremely difficult to find anything in the source code proper. For example, reading someone's code, we might want to know how and where a certain function is used. However, if we decide to conduct a search by its name, we might get lost in dozens of code samples in the comments and overlook some important case of its real usage. Shift-F12 often helps in such situations, but not always. This undermines the habitual workflow of those who are used to rely a lot on the search to read the code. Not sure if any other editor has this feature, but it would be great to have the 'Ignore comments' option in VS Code's search dialog.

Is there any way to get the list of comment tokens from all the grammar's (including extensions) installed in vscode?
I think this will become just a matter of using a strong default regex to exclude comments. I can try and implement this.

Any news on this feature request?

I'll take a look at this feature once I finish the enhancement of Find Widget. It's a valid feature request. The only technical problem we need to solve is actually detecting comment area.

@rebornix A better way could be to allow the language extension authors to implement this. Most language extensions perform some parsing and hence can figure out what the comment area is. Will need a new API in VSCode to be able to plug into it.
It also helps to future proof the implementation and that way it will work for all other languages which have a method of parsing.

Any news on this feature !!?

Any news on this feature request?

Is there any progress going on with this feature request? Its a MUST-HAVE as the only way around is using regex, which is a painful way wrt simpler ways like a checkbox of ignore comments.

As I mentioned above, this is an interesting feature which takes syntax into account for both find widget and search viewlet. WebStorm puts this feature in a filter dropdown list

We don't necessarily need to make it an UI element but a setting where users can control whether to filter out string or comments while searching. The challenge here is we are making search/find language agnostic. Currently we rely on TextMate to do the tokenization, whose most grammars are complex and beautiful but not fast enough for simple searches. When we consider sementic highlighting, we can probably think about this feature as well. The language service provides ranges for comments and strings real quick and then we can quickly filter them out.
The same technique can be used for spell checker as well, but again, relies on a fast tokenizer.

Also include "Only comments" option

Please add search in comments along with search everything but comments. Missing IntelliJ Idea today.

Please please please please please please please please please please please please please please please please please please please please please please please please please...
This feature is so desperately needed.

So is this even going to be a thing or is it something Microsoft is going to do as a wont-fix ??
It's been 3 years, with multiple people requesting it, but this is the only thing that is not "closed"

I hope this features.

4 years and no response... Is there an extension that can add this feature?

Possibly useful but not nearly as simple as requested feature https://github.com/nikaspran/vscode-ast-query (uses syntax from https://github.com/estools/esquery )

I am looking for this feature as well. Trying to exclude comments in the search results (ctrl + shift + f), but this option doesn't seem to be available yet. Would be great if we could get it :D

Hi Team, is this going to be a feature ever? Would very  much like it :) Thanks and keep up the hard work

Hope this feature +1, I think it should be implemented by the language itself.
but the problem is that we can not find any demo in the extensions.

Hope this feature +1

I couldn't understand why 5 years past, still didn't add this feature.

Did the VSCode team tried to implement it ? What were the difficulties faced ?

@Butanium It is technically impossible to figure out where the comments are without figuring out the language of the file first, and a file may be a legal content of multiple languages. E.g. a legal c/cpp source file may also be interpreted as a legal Makefile source file, and where the comments are depends on which language you are assuming. Even if a language can be specified first for a file, some languages may require a full parse according to the language grammar to determine where the comments are. For some languages, a successful full parse (that can determine the comments) might require to be run in project level, not on file level, and understanding which is the proper "project" is technically as impossible as determining the language of a single file.
Therefore, unless there involves discussion about how to redefine "comments" in this situation to make it technically possible and to make most user satisfied, this feature request can just then be considered the same as solving the halting problem. I personally think that a suitable reply in this issue might be either trying to discuss why this feature is actually doable, or some hints about the way of redefinition, or maybe even possibly both, and simply showing the strong desire of having this feature implemented without doing either of those above is not something suitable for a reply to development team of OSS VSCode.

@gnaggnoyil it's interesting that searching has a halting problem but not displaying files, where showing comments in a different colour works perfectly. very interesting that you'd choose this line of argument indeed...

@aaron-oxford If you have a file that's both a valid C source file and a Makefile source file you'll find that showing comments are not actually working that "perfectly". But yes, "what is perfect" itself can be redefined in this context too, so that both user and dev team can be satisfied here.

@gnaggnoyil oh OK, i didn't realise that loading a certain file would cause the whole IDE to hang indefinitely :-)

@aaron-oxford I think @gnaggnoyil was referring to this.
https://en.wikipedia.org/wiki/Halting_problem

@gjsjohnmurray oh of course, how silly of me to forget that fundamental tenet of computer science that totally doesn't apply to colouring text but suddenly applies when Microsoft software users want a useful feature. It's like how in Microsoft teams when someone gives your comment a thumbs up it takes switching away from the conversation and coming back then clicking on the emoji and hovering over it for 15 seconds to clear it from your feed, but meetings that start in your groups don't show up at all and you have to manually hunt out the chat where it occurred.
It's because it's np hard, right? See https://en.m.wikipedia.org/wiki/NP-hardness
Maybe we need a karnaugh map see https://en.m.wikipedia.org/wiki/Karnaugh_map
I wonder if it's possible to construct some kind of approach on my https://en.m.wikipedia.org/wiki/Analytical_Engine
LMFAO

Can we move the bum tickling off this thread pls?

@aaron-oxford
The syntax parsing and highlighting is dealing with 1 file at a time. But for search we are talking about hundreds and thousands of file (or may be more) at a same time. Search results should appear fast. From above comments it seems like, defining the comment syntax based on just extension alone, is not straight forward always and probably time taking. This can be still done, when we open 1 file but not with search.
My suggestion would be to enable the support for most popular languages like Js, Java, C, CPP, C# etc. Mixed cases like mentioned above, can be done later. The complex scenarios where it wont work has to be clearly documented.
Once rolled out, we can further improvise

Looks like a lot of people have been needing this feature for 7 years. Great this feature mentioned as a part of UI in Webstrom 4 years ago.

@Butanium It is technically impossible to figure out where the comments are without figuring out the language of the file first, and a file may be a legal content of multiple languages. E.g. a legal c/cpp source file may also be interpreted as a legal Makefile source file, and where the comments are depends on which language you are assuming. Even if a language can be specified first for a file, some languages may require a full parse according to the language grammar to determine where the comments are. For some languages, a successful full parse (that can determine the comments) might require to be run in project level, not on file level, and understanding which is the proper "project" is technically as impossible as determining the language of a single file. Therefore, unless there involves discussion about how to redefine "comments" in this situation to make it technically possible and to make most user satisfied, this feature request can just then be considered the same as solving the halting problem. I personally think that a suitable reply in this issue might be either trying to discuss why this feature is actually doable, or some hints about the way of redefinition, or maybe even possibly both, and simply showing the strong desire of having this feature implemented without doing either of those above is not something suitable for a reply to development team of OSS VSCode.

This is a great point. Thanks @gnaggnoyil.
I propose the following to make this feature workable:

Instead of "Ignore comments", call it "Try to ignore comments"
Do it only for JavaScript and TypeScript for now.
Consider that a file is in JavaScript if and only if its name ends with one of .js, .mjs, .cjs, .jsx, .mjsx, .cjsx.
Consider that a file is in TypeScript if and only if its name ends with one of .ts, .mts, .cts, .tsx, .mtsx, .ctsx.
Show a warning for users that use this feature, clarifying the above points. A suggestion: show a tooltip on checkbox hover that says:

Currently, this setting only causes comments in JavaScript and TypeScript files to be ignored. Also, this makes the search slower.

After that is successful, improvements may be considered in other feature requests.
@gnaggnoyil, thoughts?

Let's define comments as "those things that would be considered comments if I were to open the file and look at it", and maybe let the user decide whether their valuable time is best spent waiting for the computer to parse thousands of files or manually trawling through thousands of search results.
We could even think outside the box and do something like run a normal text search to show the results quickly and then reclassify the matches in the files over time once we've presented them.
If we can keep a database of function signatures and other such information that works quickly enough to guess what I'm about to type based on things defined in files I don't even have open, I'm pretty sure we can also keep a simple map of code lines we know for sure are comments and use that in a relatively timely fashion while searching.

"those things that would be considered comments if I were to open the file and look at it"

@aaron-oxford comment coloring depends on which language the file is assumed to be. What are you proposing for files whose language cannot be precisely inferred? For example, a file called foo whose content is 1 // 2? Maybe that nothing is considered a comment for them? If so, I think that's reasonable, it's similar to what I proposed above. What did you think of my proposal? Do you suggest more languages (and extensions) to start with? Which ones?

@xiety May I ask what you don't like about my idea above?

@papb I think you're considering an edge case before we have anything concrete, but I agree with what you've said at the end.
Whatever way VSCode currently determines what language a file is, is the way we should use to determine what parser to use. If this doesn't work on some file and we can't determine what are and aren't comments and just search as normal, that's fine by me.

+bump, 2024

From a comment above:

We could even think outside the box and do something like run a normal text search to show the results quickly and then reclassify the matches in the files over time once we've presented them.

This would be a fine way to do it, I think. It becomes a post-process step, so wouldn't interfere with the existing search, which ought to make it more attackable as a new feature? And then it is hopefully easy to leverage the existing syntax parsing functionality that each language already has.
From another comment:

What are you proposing for files whose language cannot be precisely inferred? ... Maybe that nothing is considered a comment for them?

I agree. I can already easily limit my search to *.js or *.cpp or even *.* if there are a lot of noisy hits from different types of file.


nginx: calculation of server_names_hash_bucket_size not right

The calculation of server_names_hash_bucket_size underestimates the required size.
With a long name (49 characters) I hit:
2017/04/19 02:01:08 [emerg] 28#28: could not build server_names_hash, you should increase server_names_hash_bucket_size: 64
nginx: [emerg] could not build server_names_hash, you should increase server_names_hash_bucket_size: 64
nginx: configuration file /tmp/nginx-cfg540721084 test failed

I confirmed in that temp file that server_names_hash_bucket_size is indeed set to 64.
Here is the relevant code:
https://github.com/nginx/nginx/blob/master/src/core/ngx_hash.c#L269
The correct calculation is  NGX_HASH_ELT_SIZE(&names[n]) + sizeof(void *)
where NGX_HASH_ELT_SIZE(name) = (sizeof(void *) + ngx_align((name)->key.len + 2, sizeof(void *)))
So for us, assuming 64 bit, we want to do
8 + 8 + align8(len(s) + 2)
My 49 characters therefore, is 16 + align8(51) = 16 + 56 = 72 (and of course we then have to round up to the next power of 2, i.e. 128)

(Working on a fix now)

@justinsb I changed this a couple of days ago #607

@aledbf right, but I think there's some extra nginx padding in the hash table that isn't accounted for.  This is just on the length (i.e. key-size) as well - I haven't hit the bucket size yet.
If in doubt, try creating an ingress with a host with 49 characters e.g.
minimal-ruby-app-staging.useast1a.k8s.example.com


find_element Hints

List:

[ ] FIND_ELEMENT
[ ] SEARCH_SORTED_LOWER

Closed as these hints are already covered in this issue


fix: AU-1786: attachment page texts. Page translations

AU-1786

What was done

Nuortoimpalk Attachment page has correct text
Swedish and English page wizard has correct numbers for pages

How to install

Make sure your instance is up and running on correct branch.

git checkout feature/AU-1786-liitetext
make fresh

Run make drush-cr

How to test

[ ] Go to Nuortoimpalk
[ ] Go to page 6. Check that the text matches the one on the ticket's attached WORD file
[ ] Switch to English. See that the numbers on the form pages and the numbers below them in the headlines match each other.
[ ] Go to page 6. Check that the text matches the one on the ticket's attached WORD file
[ ] Switch to Swedish. See that the numbers on the form pages and the numbers below them in the headlines match each other.
[ ] Go to page 6. Check that the text matches the one on the ticket's attached WORD file
[ ] Check that code follows our standards

Suomenkieliseen versioon vielä preview-sivunumeron korjaus

Nyt pitäisi olla sekin kunnossa


Use of Robot java class in Robotium through error 'Test run failed: Instrumentation run failed due to 'java.lang.VerifyError'

From<EMAIL_ADDRESS>on June 24, 2013 05:33:48
What steps will reproduce the problem? 1.Created robot method by importing
import java.awt.AWTException;
import java.awt.Robot;
import java.awt.event.InputEvent;
2. I need to click on the screen having specific x, y co-ordinate 3. What is the expected output? What do you see instead? The mouse should click on the screen of x, y co-ordinate. But running android junit test case through error 'Test run failed: Instrumentation run failed due to 'java.lang.VerifyError' What version of the product are you using? On what operating system? 4.2.2 (APL level 17) Please provide any additional information below. Embedded below code in my test script:
try {
		Robot robot = new Robot();

		robot.mouseMove(300,550);

		robot.mousePress(InputEvent.BUTTON1_MASK);
		robot.delay(2000);
		robot.mouseRelease(InputEvent.BUTTON1_MASK);

		} catch (AWTException e) {
		e.printStackTrace();
		}

Please let me know. Thanks!
Original issue: http://code.google.com/p/robotium/issues/detail?id=476

From<EMAIL_ADDRESS>on June 24, 2013 07:03:46
This is the issue tracker for Robotium. You seem to be using java.awt.Robot
Status: Invalid
Owner<EMAIL_ADDRESS>


NebulaDaoBasic‘s Schema support-show metas

Hi @amritagg
I'm glad you're interested in these features.
We need to add methods to NebulaDaoBasic that allow developers to quickly access data without having to write ngql
Just like its other interfaces.https://github.com/nebula-contrib/ngbatis/blob/master/src/main/java/org/nebula/contrib/ngbatis/proxy/NebulaDaoBasic.java
The idea is to extract the more commonly used scripts, as the name of the task item means.
For example, show metas, developers can quickly get schema information by calling the interface, tag, edgeType, etc.
cc: @wey-gu
Originally posted by @CorvusYe in https://github.com/nebula-contrib/ngbatis/issues/234#issuecomment-1740238713

I think underneath it's calling
SHOW TAGS
SHOW EDGES

And then to call
SHOW TAG <FOO_TAG>;
SHOW TAG <BAR_TAG>;
SHOW EDGE <A_EDGE_TYPE>;
SHOW EDGE <B_EDGE_TYPE>;

And put schema info into one object?
@CorvusYe

That sounds useful! I will have a try to achieve the show the meta-structure of the graph
maybe the output of it will be a map structure like
space:test
tag :[tagA,tagB,...]
edge: [ edgeA,edgeB,...]
tagIndex:[tagIndexA,tagIndexB,...]
edgeIndex:[edgeIndexA,edgeIndexB]
...
reference to this function
https://github.com/run-llama/llama_index/blob/f8c07e8eeb52cc774d9a6334effcbe4c132daef5/llama_index/graph_stores/nebulagraph.py#L596-L660

I think underneath it's calling
SHOW TAGS
SHOW EDGES

And then to call
SHOW TAG <FOO_TAG>;
SHOW TAG <BAR_TAG>;
SHOW EDGE <A_EDGE_TYPE>;
SHOW EDGE <B_EDGE_TYPE>;

And put schema info into one object?
If that's the case, I implemented similar functions here as a reference:
https://github.com/jerryjliu/llama_index/blob/f8c07e8eeb52cc774d9a6334effcbe4c132daef5/llama_index/graph_stores/nebulagraph.py#L596
@CorvusYe


WIP: Test for MAGIC in server response

added failing MAGIC test which we can verify works later (expectedOutput will have to be changed)

With the PR to allow magic in the Node API, flowControl operations are not currently valid in bake recipes. We will need to add a separate endpoint specifically to run magic on some input in the API.
Propose we expose /magic where you can similarly POST some input plus optional arguments for magic operation and receive JSON of the output of Magic.

TODO update readme


Exception handling issues

re WordCount.WebService.HttpExceptionHandler - Which version of which HttpClient are you using, that gives you HttpWebResponses and throws WebExceptions?
For example with a request of mine returning a 404 -
HttpClient.PostAsync returns me a Task<HttpResponseMessage> and nothing is thrown.
I can access the Result, still nothing is thrown.
I have to call EnsureSuccessStatusCode() on the result if I want something thrown, and this only ever throws HttpRequestException, which is not what your HttpExceptionHandler is looking for.

Not researched this (& noob) but my guess is, this was correct when HttpWebRequest was being used. This does throw WebExceptions but since @vturecek change (efb0c635f265591dc78875bea89bf26ca7600fac) the code is using HttpClient, I am finding it does not throw these exceptions
Unfortunately, I haven't tested the behavior in all these timeout/protocol/socket exception cases so I don't know the extent of changes needed to HttpExceptionHandler. Please advise...

Looks like there's a line missing that checks for HttpRequestException. We're working on a better way to do this using HttpClientHandlers. We'll get this updated soon. In the meantime, take a look here to see how that works: https://github.com/xinyanmsft/SFStartupHttp/tree/master/src/Libs/Microsoft.ServiceFabric.Http/Client

Thanks for reply @vturecek
It takes more than a missing line to fix this example. As this HttpRequestException tells me basically nothing ... unless I want to string match on its (localized!) Message.
But thanks a lot for the full example to check out. I will come back to this next month.

We've switched HTTP communication to use the SF reverse proxy, which we recommend over resolving service endpoints manually. We still have an example of that for reference though in our Service Fabric IoT sample


Pay to unlock some features

InApp Purchase to unlock some features, like:

Wallpaper download
Choose wallpaper download location
...

If json link could be changed after payment it will be pretty useful. The free users use json1 but people who have paid use json2 so they have different wallpapers.

I'll considering about it. This is still an idea, I don't know when it can be implemented to the app.

I just shared my idea 😀


Flutter and Android Studio installation

Description 📜
Flutter: Installation and Setup Android Studio
Fixes #158

Type of change 📝

[x] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilities etc)

Domain of Contribution 📊

[x] Android Dev (Flutter, Java, Kotlin)

Checklist ✅

[x] My changes generate no new warnings.
[x] I'm GWOC'21 contributor

@Janak2401 Please contact your mentor to validate your Pull Request.


Fixing issue that tags are removed before they can be pushed

I ran into the issue that I created a new tag in my Github Action and when I want to push it (by specifying the tags: true) entry for your action, the line in entrypoint.sh that I edited in this PR fetches from origin and prunes all local tags that don't exist online as well. This kinda makes the whole option tags obsolete, as that seems to be overridden by this line.
If you find a nicer solution to actually be able to still push newly created tags, that's also fine, maybe by making this conditional on whether the tags flag was set or not, but this solution worked for me.

I ran into the issue that I created a new tag in my Github Action and when I want to push it (by specifying the tags: true) entry for your action, the line in entrypoint.sh that I edited in this PR fetches from origin and prunes all local tags that don't exist online as well. (...)

Neat - and indeed, the -P option prunes all local tags not present on the remote.

(...) This kinda makes the whole option tags obsolete, as that seems to be overridden by this line.

I don't think this is the case, but I might definitely be wrong. The point of the tags option is to do an extra git push --tags command, explicitly pushing the tags, which I'm not sure would otherwise be pushed. However, if you have a way of testing this that would be amazing! I'll create another PR using your commit here, so that the CI works (my GH secrets needs to be used for the CI to work).

If you find a nicer solution to actually be able to still push newly created tags, that's also fine, maybe by making this conditional on whether the tags flag was set or not, but this solution worked for me.

The -P option needs to be removed regardless if you want to achieve your goal here and push newly created tags - so fine by me with this fix 👍

(...) This kinda makes the whole option tags obsolete, as that seems to be overridden by this line.

I don't think this is the case, but I might definitely be wrong. The point of the tags option is to do an extra git push --tags command, explicitly pushing the tags, which I'm not sure would otherwise be pushed. However, if you have a way of testing this that would be amazing! I'll create another PR using your commit here, so that the CI works (my GH secrets needs to be used for the CI to work).

Oh sorry, maybe I was a bit unclear with my previous statement. I only meant that the tags option wouldn't push the newly created tags as long as the -P option was still in there. Other than that, the tags option is of course far from obsolete and makes perfect sense.

Edit: Looking into a bit of Git documentation (see "Sharing tags"), it seems the newly created tag shouldn't be pushed along with the commit, only if it's either explicitly pushed or --tags is used will it be pushed. But this should be tested, I think.

Yeah, I'm quite sure it works that way.

The -P option needs to be removed regardless if you want to achieve your goal here and push newly created tags - so fine by me with this fix +1

Nice, thanks for taking the time to get that included! :+1:


pass children to Handle component cause the Handle not being abled to drag

my code
<Handle
      type="source"
      position={Position.Right}
      id={id}
    >
    <IconPlus style={{ opacity: disabled ? 0.2 : 1, zIndex: -1 }} />
</Handle>

when i add a source or target class to its children, it works ok
<Handle
      type="source"
      position={Position.Right}
      id={id}
    >
    <IconPlus class="source" style={{ opacity: disabled ? 0.2 : 1, zIndex: -1 }} />
</Handle>

after digging into the source code, i found this

i am not sure if this is a feature or bug, i think most users may expect the children can respond to users' drag action

+1

@datoslabs pointer-events indeed works, but i also need to add some listener to handle's children

I want to include hover behavior in the children. But doing so requires me to set pointer-events: auto. Is there any fix for this?

Would adding the hover event behavior to the handle achieve the same as hover event behavior over handle's children?

@fengChongxiu - were you able to resolve the issue?
Could you share a small codesandbox.io example so other's can take a look as well?

https://codesandbox.io/s/react-ts?file=/src/App.tsx

were you able to resolve the issue

just by setting pointer-event to none to handle's children


Improve the statistics

Currently, the statistics are very basic

WPM
Accuracy

It might be cool to add some more indicators

Keystrokes (see 10fastfingers)
speed evolution over the text (like typeracer) - plotting might be tricky (bashplotlib ?)
Average speed per character (one needs to condense this information)

It could be a good choice too
https://github.com/mkaz/termgraph

That is a really cool package, did not know about it! Thank you for sharing it.
Regarding the statistics, I agree that there are a lot of cool statistics that one can track and plot! Any chance you would want to work on it @EduardKononov  and create a PR? I can definitely provide some help too:)

I definitely want to create PR, and I will, but only when I have some free time :) Probably mid-January. If no one does it sooner, I'm in.

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

Hey there! No worries:) It is not urgent at all:) Feel free to come back to it at any point if you have more time.

Unfortunately, I still have no time to do that. I'm here just to notify that I remember but have no opportunity

Hey there! No worries:) It is not urgent at all:) Feel free to come back to it at any point if you have more time.


Add item "Context images" in User Guide

Motivation and context

This PR resolve issue #3214
To add a section, I used the "add child page" button on the website. The images were added via insert, so they were uploaded to the https://user-images.githubusercontent.com/ and are not in the repository.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@TOsmanov
Thanks, great job!


Conversion of diffusion images to BIDS format

I've noticed that the naming of the diffusion images (3 chunks from skull base to T5) is not consistent across subjects. For example, for the first subject, "chunk1" corresponds to the lower volume, "chunk2" to the upper volume, and "chunk3" to the middle. The order is different when I look at other subjects.
The original diffusion volumes were acquired from top to bottom, and were named accordingly, for example, "S2", "S3", "S4" or "S4", "S5", "S6".

@Kaonashi22 I'm working on it right now

@Kaonashi22 I fixed this issue in #18 (already merged to the 'main' branch). Could you please git pull your local repository, re-run the conversion, and let me know if this issue is solved on your end?

The issue is solved, thank you!


BUG: Incorrect reshape behavior in shap/plots/_image.py, v0.43.0

Issue Description
In  shap/plots/_image.py
95  if labels is not None:
96       if isinstance(labels, list):
97            labels = np.array(labels).reshape(1, -1)```

If the passed in labels is a list, this code will destroy the structure, making it a 1-d array, leading to the following error message
Traceback (most recent call last):
  File "/mnt/azureml/cr/j/1e7bc96644ab43af9d312340b05c2fda/exe/wd/scripts/train_image_to_pom_model.py", line 421, in <module>
    main()
  File "/mnt/azureml/cr/j/1e7bc96644ab43af9d312340b05c2fda/exe/wd/scripts/train_image_to_pom_model.py", line 395, in main
    plot_shap_deep_explainer_image(pom2d_pred, train_dataset)
  File "/mnt/azureml/cr/j/1e7bc96644ab43af9d312340b05c2fda/exe/wd/scripts/train_image_to_pom_model.py", line 293, in plot_shap_deep_explainer_image
    shap.image_plot(shap_values=[pom_explanations.reshape((32, size, size, 1)) for pom_explanations, height_explanations in shap_values],
  File "/opt/miniconda/envs/phm/lib/python3.10/site-packages/shap/plots/_image.py", line 166, in image
    axes[row, i + 1].set_title(labels[row, i], **label_kwargs)
IndexError: index 1 is out of bounds for axis 0 with size 1

work-around:
convert labels to np.array() manually before passing in.
Minimal Reproducible Example
passing labels as a 2d list to shap.image_plot()

Traceback
No response
Expected Behavior
No response
Bug report checklist

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest release of shap.
[ ] I have confirmed this bug exists on the master branch of shap.
[ ] I'd be interested in making a PR to fix this bug

Installed Versions
0.43.0

Thanks for the bug report and the analysis. Could you help zs with a reproducible example?

Sorry but the code is confidential, while it is caused by the label reshape
converting the input labels list
e.g.
labels=[
    ['a', 'b', 'c'],
    ['a', 'b', 'c'],
]

into
np.array(['a', 'b', 'c', 'a', b', 'c'])

distorting the array

I see but just any reproducible example with dummy data would help us. Otherwise we would need to reverse engineer the problem which takes a lot of time and might cause this bug to be de-prioritized.

Thank you for the reply, I will try constructing a dummy example when I have time.
Meanwhile I will leave this issue here so that when someone encountered the same error, they will know it is related to labels, instead of the input data.
I wasted a day trying to debug this lol.

Reproduction code, using shap==0.43.0
    train_loader, val_loader = my_cls.init_dataloader(train_dataset, val_split=0.2)
    # training data
    train_x, _ = next(iter(train_loader))
    train_imgs = train_x[0].to(device)
    train_feature_2 = train_x[1].to(device).float()
    e = shap.DeepExplainer(my_cls.model, [train_imgs, train_feature_2 ])

    shap_values: list[list, list] = e.shap_values([train_imgs, train_feature_2 ], check_additivity=False)
    # shap_values[0][0].shape = (32, 1, 400, 400)
    # ! MUST reshape to (32, size, size, 1) else the code will break
    # https://shap-lrjball.readthedocs.io/en/latest/generated/shap.image_plot.html
    shap.image_plot(shap_values=[explanations.reshape(32, size, size, 1) for explanations, explanations_feature_2 in shap_values],
                    pixel_values=train_imgs.cpu().numpy().reshape(32, size, size, 1),
                    width=300, labels=np.array([my_cls.targets]*32), # The structure of labels will get destroyed by the image_plot function if it is a list, convert to np.array before passing in
                    show=False)  # Do not call plt.show() before function return

labels passed into the function is a list of length 32, with sub-lists of length 13
In shap.image_plot(), if the labels passed into the function is a list, it will convert it to a np.array() while reshaping it to a 1-d array.
(32, 13) -> ( , 32*13)
While in later part of the function, it calls a 2-d slice of the label matrix to retrieve a label name to be put into plt-subplot, causing an IndexError.


Trim trailing spaces

This option doesn't work anymore in FD5 :
Settings > CodeFormatter -> Trim Trailing Whitespace (TRUE)

How it doesn't work? I set it to true and ran the Code Formatter and it did remove added spaces and tabs from end of comment and code lines.

Hi,
There used to be an option that allowed Trimming Spaces upon saving, and I thought it was this one.
The real option is actually name "strip trailing spaces" in Settings > FlashDev (which is a bit confusing as it does the same thing).
Not exactly an issue, except the option name itself :)

There few other settings overlapping there but i think its good to have separate settings for code formatter. Like if you need to temporarily format code differently from your own code.

The issue isn't so much having two different settings for this, but that their names / descriptions are so similar that it's unclear what the difference is.

Very true, renamed FD setting to match CodeFormatter setting which is better.


[Delegate] implement additional highlight APIs

Docs: https://developer.apple.com/documentation/uikit/uicollectionviewdelegate#1656670
func collectionView(UICollectionView, didHighlightItemAt: IndexPath)
Tells the delegate that the item at the specified index path was highlighted.
func collectionView(UICollectionView, didUnhighlightItemAt: IndexPath)
Tells the delegate that the highlight was removed from the item at the specified index path.

Hey @nuomi1
Just in case you wanted to keep working after #121, this would be a great one to do next. 😊


upgrade egui, egui_glow, glow crates

nice. no changes needed it seems.
it seems there's a bunch of other dependencies that are in need of upgrading.

I see rand, noise and glutin crates which are not latest.

I see rand, noise and glutin crates which are not latest.

rand and noise is just dev dependencies (only used in examples) and I remember one of them was not working on web in a newer release. An old version of glutin is used for headless since that's not supported in the new release 🤷 the rest use the latest version.


Do nothing if trying to make the current dir

This is an alternative fix to https://github.com/KhronosGroup/SPIRV-Tools/pull/592
It solves the problem where it can occur rather than requiring all call sites to avoid the issue.  Sure, there's only one call site for now. But I like this better.


Lambda expressions

Nice docs..Great work. Thanks for the support

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12c8b202-5b65-9d30-d57e-dd060a507b9a
Version Independent ID: 92cfc461-56ed-c046-bb03-cc5e46ebf5ba
Content: Lambda Expressions
Content Source: docs/csharp/lambda-expressions.md
Product: dotnet-csharp
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Thank you!!


Address compiler warnings

This addresses compiler warnings when using gcc.

Hm. A bit nasty these pragmas.

I can create macro to make it look more clean. Will that work?
Also this will make it easy to address different compilers without cluttering the main code.

Do we also only want to target GCC with this?

No, but I don't have an easy way to test windows compiler.

I created an opw_macros.h file and put all of the relevant macros in it. Also added support for clang but right now on windows the macros for ignoring warnings does nothing.

@gavanderhoorn What do you think about the changes?


Zip task with zip64 true produces zip files with headers error

When creating zip files with the zip task, we observe that zip files with a headers error are created. It seems to us, that this happens when we set zip64 true.
Expected Behavior
Zips are created without headers error.
Current Behavior
Zips are created with headers error.
Context
This can lead to all kinds of issues with the created zip files, e.g. when trying to unzip them later.
Steps to Reproduce
Here is a working example to reproduce the behavior: https://github.com/mfbieber/gradle-zip-headers-error/blob/main/minimalExample.gradle
This is the relevant code (included in the mentioned repository):
task ziptest(type: Zip) {
  archiveName "test.zip"

  destinationDir file(".")
  duplicatesStrategy DuplicatesStrategy.EXCLUDE
  zip64 true
  includeEmptyDirs = false

  def buildFile = new File(".", 'test.txt')
  buildFile.text = "test"
  into ('/') { from buildFile }

  doLast {
    delete fileTree('.') {
        include '*.txt'
    }
  }
}

The error can be seen either by trying to extract the zip file with 7Zip:

Or for with other 7Zip versions, we saw it only through the properties:

Thanks in advance!

Thanks, @mfbieber for the great bug report and the reproducer. Would you do me a favor and try a few things as I'm unable to reproduce this on my side:
a) you can try Gradle 7.0 and see if you still encounter this issue?
b) Can you try other zip tools and see if they see similar issues?
Running the reproducer, the resulting zip can be properly unzipped by the tools at my disposal (on macOS, used unarchiver and unzip):
❯ unzip -t test.zip
Archive:  test.zip
    testing: test.txt                 OK
No errors detected in compressed data of test.zip.

After digging some more, it seems that 7Zip has issues if zip64 headers are not present. The flag in your build script zip64 true is not to enable it but to enable it if needed. See also Zip64Mode. So to workaround 7zips problems dealing with this, it would require a new feature in Gradle to force zip64 (see also DefaultZipCompressor).

Thanks, @mfbieber for the great bug report and the reproducer. Would you do me a favor and try a few things as I'm unable to reproduce this on my side:
a) you can try Gradle 7.0 and see if you still encounter this issue?

Yes, I see the same error:
mfernandezbi@MFERNANDEZBI-01 MINGW64 ~/Downloads/gradle-zip-headers-error (main)
$ dir
7ziperror.png  7zipproperties.png  build.gradle  gradle  gradlew  gradlew.bat  minimalExample.gradle  settings.gradle  test  test.zip

mfernandezbi@MFERNANDEZBI-01 MINGW64 ~/Downloads/gradle-zip-headers-error (main)
$ gradle --version

Welcome to Gradle 7.0!

Here are the highlights of this release:
 - File system watching enabled by default
 - Support for running with and building Java 16 projects
 - Native support for Apple Silicon processors
 - Dependency catalog feature preview

For more details see https://docs.gradle.org/7.0/release-notes.html

------------------------------------------------------------
Gradle 7.0
------------------------------------------------------------

Build time:   2021-04-09 22:27:31 UTC
Revision:     d5661e3f0e07a8caff705f1badf79fb5df8022c4

Kotlin:       1.4.31
Groovy:       3.0.7
Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
JVM:          14.0.2 (AdoptOpenJDK 14.0.2+12)
OS:           Windows 10 10.0 amd64

mfernandezbi@MFERNANDEZBI-01 MINGW64 ~/Downloads/gradle-zip-headers-error (main)
$ gradle ziptest
Starting a Gradle Daemon (subsequent builds will be faster)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/7.0/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 6s
1 actionable task: 1 executed

b) Can you try other zip tools and see if they see similar issues?
Running the reproducer, the resulting zip can be properly unzipped by the tools at my disposal (on macOS, used unarchiver and unzip):
❯ unzip -t test.zip
Archive:  test.zip
    testing: test.txt                 OK
No errors detected in compressed data of test.zip.

The unzip utility shows the same output as yours for the same zip which contains the error visible with 7Zip:
mfernandezbi@MFERNANDEZBI-01 MINGW64 ~/Downloads/gradle-zip-headers-error (main)
$ unzip
UnZip 6.00 of 20 April 2009, by Info-ZIP.  Maintained by C. Spieler.  Send
bug reports using http://www.info-zip.org/zip-bug.html; see README for details.

Usage: unzip [-Z] [-opts[modifiers]] file[.zip] [list] [-x xlist] [-d exdir]
  Default action is to extract files in list, except those in xlist, to exdir;
  file[.zip] may be a wildcard.  -Z => ZipInfo mode ("unzip -Z" for usage).

  -p  extract files to pipe, no messages     -l  list files (short format)
  -f  freshen existing files, create none    -t  test compressed archive data
  -u  update files, create if necessary      -z  display archive comment only
  -v  list verbosely/show version info       -T  timestamp archive to latest
  -x  exclude files that follow (in xlist)   -d  extract files into exdir
modifiers:
  -n  never overwrite existing files         -q  quiet mode (-qq => quieter)
  -o  overwrite files WITHOUT prompting      -a  auto-convert any text files
  -j  junk paths (do not make directories)   -aa treat ALL files as text
  -U  use escapes for all non-ASCII Unicode  -UU ignore any Unicode fields
  -C  match filenames case-insensitively     -L  make (some) names lowercase
  -X  restore UID/GID info                   -V  retain VMS version numbers
  -K  keep setuid/setgid/tacky permissions   -M  pipe through "more" pager
See "unzip -hh" or unzip.txt for more help.  Examples:
  unzip data1 -x joe   => extract all files except joe from zipfile data1.zip
  unzip -p foo | more  => send contents of foo.zip via pipe into program more
  unzip -fo foo ReadMe => quietly replace existing ReadMe if archive file newer

mfernandezbi@MFERNANDEZBI-01 MINGW64 ~/Downloads/gradle-zip-headers-error (main)
$ unzip -t test.zip
Archive:  test.zip
    testing: test.txt                 OK
No errors detected in compressed data of test.zip.

I mentioned it above, but some of our colleagues didn't notice the headers error because 7Zip also did not complain. They could only see it via the properties. So I guess many tools will be able to unzip without complaining. We've seen this behavior before with corrupt zip files, but this lead afterward to corrupt extracted files that caused other errors in our processing pipeline (e.g. MimeType detectors).

Thanks for checking! Just to clarify, 7zip only shows Warnings: header errors but lets you unzip the file successfully?

Thanks for checking! Just to clarify, 7zip only shows Warnings: header errors but lets you unzip the file successfully?

Yes, this is what I can observe.
We checked internally and we don't really need the zip64 true option anymore, so we will be removing it and thus will not run into the error.
Maybe it is worth it to fix this headers error warning issue anyways - someone will probably need it ;)

We checked internally and we don't really need the zip64 true option anymore, so we will be removing it and thus will not run into the error.
Great that this is not blocking you anymore!

Regarding fixing this, I don't really see this as a problem on the Gradle side, to be honest. The archive we produce is valid and only has the metadata it requires. I think this is an issue that needs to be fixed on the 7zip side. Given you're unblocked, I'm going to close this one. Thanks for your time reporting this!

Thanks for your quick replies 👍


F.concate and np.concatenate do not have consistency

There are two problems:

the names are different
In numpy,  the array concatenating function is concatenate.
https://docs.scipy.org/doc/numpy/reference/generated/numpy.concatenate.html
But, in chainer, the name is concat.
the default axis values are different
In numpy, the value is 0. But, in chainer, the value is 1.

https://github.com/pfnet/chainer/blob/master/chainer/functions/array/concat.py

These are reasonable differences. Cupy, not Chainer, is intended to be consistent with numpy, and cupy.concatenate is consistent with numpy.concatenate in all the ways you mention. Chainer is specialized for neural networks, where you typically work with batched data and don't want to concatenate on the batch (zeroth) dimension, so defaulting to axis 1 is reasonable.

Thank you for the comments! Now I know the reasons chainer.functions.arrray and numpy is not consistent. I will close the issue.


Documentation dead links #840

Proposed changes
Documentation dead links #840
Types of changes
What types of changes does your code introduce to FESTIM?

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactoring
[x] Documentation Update (if none of the other choices apply)
[ ] New tests

Checklist

[ ] Black formatted
[ ] Unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

The commit "Add the slack channel." here was carried in by mistake.

The commit "Add the slack channel." here was carried in by mistake.

Yes this is because you branched out of this other branch #867 where this commit was present. This is not an issue here but in general, when you are working on two PRs in parallel then you want to create all the branches from main

The commit "Add the slack channel." here was carried in by mistake.

Yes this is because you branched out of this other branch #867 where this commit was present. This is not an issue here but in general, when you are working on two PRs in parallel then you want to create all the branches from main

Thanks! I see.


[#28] [iOS] [UI] As a user, I can see the loading animation while the app is fetching surveys

Close #28

What happened 👀

Add pod SkeletonUI
Created SkeletonSurveyContentView, SkeletonHomeHeaderView, SkeletonTextView and SkeletonHomeView for the animation
Integrate the UI of SkeletonHomeView to HomeView

Insight 📝
To let the user know the application is fetching data and keep them occupied, we will show the loading animation on the Home screen when the app is fetching surveys.
Proof Of Work 📹
https://user-images.githubusercontent.com/22606906/236989647-59d4e00d-a00b-4776-9c5c-4f7073b1133d.mp4

@markgravity, I solved your comments in 4df4bc7


Improve error handling for the Safari extension app

I also slightly improved the look of the wrapper app:

Does this fix or explain #4216? Now that the problem is gone from my computer I can't test it anymore

@fregante It doesn't fix it. But if it happens, it shows the user an error dialog at least.

Was this included in 21.4.12? 😳
Anyway, I'm not a Swift dev, so merge as you see fit

Ugh, no it was not. I'll do another release in a few days then I guess.


Theme change is not working.

I modified the custom.xaml file by adding the NavAreaBackground change.
<Style TargetType="controls:HamburgerMenu">
      <Setter Property="AccentColor" Value="{StaticResource CustomColor}" />
      <Setter Property="NavAreaBackground" Value="CadetBlue" />
      <Setter Property="HamburgerBackground" Value="Green" />
      <Setter Property="VisualStateNarrowMinWidth" Value="{StaticResource NarrowMinWidth}" />
      <Setter Property="VisualStateNormalMinWidth" Value="{StaticResource NormalMinWidth}" />
      <Setter Property="VisualStateWideMinWidth" Value="{StaticResource WideMinWidth}" />
 </Style>

They aren't working when I run the app they don't take effect. The Background stayed the same default color. Where is it being set? is it overriding my settings?

If anyone could help me out I would be grateful. I am kinda stuck at the moment.

I have spent several hours going through the code and I can't figure out exactly what is going on. In the Hamburger control it looks like the themes are hardcoded. I cloned the project and commented out the hard coded settings and tried to set it from the custom.xaml file in the minimal template. It works with the default there. I changed the NavArea background to Red. but when I select the light theme the Hamburger menu does not change to Blue like I set in the light theme.
Default "Dark"
        <Style TargetType="controls:HamburgerMenu">
            <Setter Property="AccentColor" Value="{StaticResource CustomColor}" />
            <Setter Property="HamburgerBackground" Value="Green" />
            <Setter Property="NavAreaBackground" Value="Red" />
            <Setter Property="VisualStateNarrowMinWidth" Value="{StaticResource NarrowMinWidth}" />
            <Setter Property="VisualStateNormalMinWidth" Value="{StaticResource NormalMinWidth}" />
            <Setter Property="VisualStateWideMinWidth" Value="{StaticResource WideMinWidth}" />
        </Style>

Light
        <Style TargetType="controls:HamburgerMenu">
            <Setter Property="AccentColor" Value="{StaticResource CustomColor}" />
            <Setter Property="NavAreaBackground" Value="Blue" />
            <Setter Property="VisualStateNarrowMinWidth" Value="{StaticResource NarrowMinWidth}" />
            <Setter Property="VisualStateNormalMinWidth" Value="{StaticResource NormalMinWidth}" />
            <Setter Property="VisualStateWideMinWidth" Value="{StaticResource WideMinWidth}" />
        </Style>

I also can't explain how it changes the background to white and text of some textblocks to black.
I also have a gridview setup with a Data template and that changes colors. But a regular textblock that I have on its own isn't changing. Any help would be greatly appreciated. I am completely stuck here and spent multiple days just trying to get this working.
Changes on its on. I did nothing special to make this work with the light/dark theme setup
    <GridView x:Name="gridView" Margin="10,0,0,0" ItemsSource="{Binding Articles}" VerticalContentAlignment="Top" Grid.Row="1">
        <GridView.ItemTemplate>
            <DataTemplate x:DataType="data:NewsModel">
                <StackPanel x:Name="mainPanel" VerticalAlignment="Top" MaxWidth="400" Tapped="mainPanel_Tapped">
                    <TextBlock x:Name="tbHeadline" FontSize="18" Text="{x:Bind HeadLine}" TextWrapping="WrapWholeWords" VerticalAlignment="Top" HorizontalAlignment="Left" FontWeight="Bold" />
                    <TextBlock x:Name="tbWriter" FontSize="10" Text="{x:Bind Writer}" TextWrapping="WrapWholeWords" VerticalAlignment="Top" HorizontalAlignment="Left"/>
                    <TextBlock x:Name="tbBlurb" FontSize="14" Text="{x:Bind Blurb}" TextWrapping="WrapWholeWords" VerticalAlignment="Top" HorizontalAlignment="Left"/>
                    <TextBlock x:Name="tbDateTime" FontSize="10" Text="{x:Bind DateTime}" TextWrapping="WrapWholeWords" VerticalAlignment="Top" HorizontalAlignment="Left" />
                </StackPanel>
            </DataTemplate>
        </GridView.ItemTemplate>
    </GridView>

Doesn't Change at all
    <TextBlock Margin="10,10,10,610" Height="20" Text="Status" TextAlignment="Center" Foreground="White" />
    <TextBlock Text="{Binding  ESModel.ServerOnline}" Height="40"  Margin="10,35,10,565" TextAlignment="Center" FontSize="20" Foreground="White" />

I cannot reproduce your situation. Changing from Dark to Light works like a charm. If you can duplicate your issue in a simple project, I will take a look for you. Or create a new issue if you want.


TypeError: catching classes that do not inherit from BaseException is not allowed

Just doing some unit testing here with python 3.6
Triggering the exception with monkey patch
        def func():
            containers_property_mock = mock.MagicMock()
            containers_property_mock.get.side_effect = pylxd.exceptions.NotFound('not found')

            mock_pyxld_client = mock.MagicMock()
            type(mock_pyxld_client).containers = mock.PropertyMock(return_value=containers_property_mock)
            return mock_pyxld_client

        monkeypatch.setattr("lib_vpn_customer.pylxd.Client", func)

    @property
    def container_exists(self):
        """Return the container instance, if found."""
        if self.lxd_client is None:
            self.lxd_client = pylxd.Client()
        try:
            self.lxd_container = self.lxd_client.containers.get(self.appname)
            pp = pprint.PrettyPrinter(indent=4)
            pp.pprint(self.lxd_container)
            return True
>       except pylxd.exceptions.NotFound:
E       TypeError: catching classes that do not inherit from BaseException is not allowed

Either I'm missing something or need to modify the exception hierarchy to extend from base exception.

        except:
            # TypeError: catching classes that do not inherit from BaseException is not allowed
            hookenv.log('Could not find container {}'.format(sys.exc_info()[0]), level=hookenv.ERROR)
            return False

workaround for now


Fix cursor setting for saved feed

Currently pagination for saved feed is not working. I found the cursor is being set as wrong value (undefined) – I replaced it with data.next_max_id :)

Well done!


Fix random new line breaking file paths | Add executable flag to dist/eslint-staged-files.js file

Add executable flag to dist/eslint-staged-files.js file (fix "npm run test" command for macos)

Hi, long time no see! Thanks for your input.
Could you elaborate on when it's crashing? I'm confused what it's supposed to fix 🤔

I wasn't able to pinpoint the exact underlying issue but I assume it's probably related to how stdout from executed command is processed internally by node.js. If output from command is very long it's spllited into chunks, joined by "\n". In practice long output from "git diff" (eg. for 300 files from huge merge) is affected by this chunking and paths for one or more files are being corrupted.
expected output from "git diff" command is:
src/my_project/file1.js
src/my_project/file2.js
...
src/my_project/file120.js
...
src/my_project/file199.js
src/my_project/file200.js

In some cases it becomes:
src/my_project/file1.js
src/my_project/file2.js
...
src/my_proje
ct/file120.js
...
src/my_project/file199.js
src/my_project/file200.js

I causes linter to exit with error that file src/my_proje and ct/file120.js can't be found.

Thanks for the explanation. Happy to merge :)


"toString" format not working properly with 12 hour clock

I have a date 2016-02-06 18:39:00 UTC (in variable date). When I do date.inRegion().toISO8601String(), I get the correct output: 2016-02-06T18:39:00.000Z. But when I do simply: date.toString(.ISO8601), what I get is something unexpected and possibly a wrong value: 2016-02-06T7:39:00+0100. Am I using it wrongly or is it a bug? Thanks.

Good find!
NSDate and DateInRegion should behave the same in the default region. Hence this is a bug.

let d = data.toDate(DateFormat.Custom("MM/dd/yyyy")) // "2016-02-02 18:00:29"

this syntax returns nil
Is this the same bug or related?

You have provided the wrong format according to your date string in the comment.

So to get this straight, the DateFormat should match the date string provided?
I thought it was the format based on which the Date is returned.
So how can I know which dateformat to use?

The toDate function needs a lead to know which characters in the string represent which data. Different countries and different programmers use different date formats. E.g. "11-12-13"  could mean 11 December 2013, 13 December 2011 or 12 November 2013...

@netgfx coming back to your question: you must know the date format of the string you provide before passing it on.

Yes I understand now and I was able to convert the given date to a custom formatted one.
Thanks for clarifying things.

Woops reopened since the original bug with ISO8601 date formatting in the default region is still prevailing.

I think we should reuse same function to express same features. In this way toISO8601String() is simply a shortcut for toString(.ISO8601).
So this commit (now in a separate feature) will accomplish this task: https://github.com/malcommac/SwiftDate/commit/165309fd926fac2574902025bd81343f846574b9.
Any cons?

I think we should consolidate to a minimum number of functions that describe the function of the function. In this case I would vote for the toString(style) format and deprecate the toStyleString()  format. The former is more flexible.

Totally agree. It now uses toString(.ISO8601) format but it's marked as deprecated. https://github.com/malcommac/SwiftDate/commit/9451ed3fcf3ba996a347ea96ce45694371aa4f3a


Data is stored in .local/share/dx without appending profile name

Bad config, we need to add config validation


keras.application installed by pip binary file has no resnext?

The keras.applications module has been splitted from the main Keras repository.
Please submit your issue using this link.
Thank you!

I believe that ResNeXt will be released with the next version of Keras. It's in master, but was not present when 2.2.4 was released.

@brandonschabell is right. Closing this issue as this will be solved in the next release.

print(keras.version)
2.2.4
keras.applications.resnext.ResNeXt101()
Traceback (most recent call last):
File "", line 1, in
AttributeError: module 'keras.applications' has no attribute 'resnext'

When is the next release happening? Anyways to get to that earlier?

Hi @gabrieldemarmiesse. Will ResNet50V2 be released with the next version of Keras? Thank you!


Certain movies on Tubitv.com won't download using youtube-dl.

Checklist

[ ] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.12.12
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
Certain movies on tubitv.com, are not able to be downloaded using youtube-dl, the log says this:  ERROR: unknown url type: ''
here are a few url examples of movies that wont Download using youtube DL:
http://tubitv.com/movies/563044/the-sixth-man
http://tubitv.com/movies/563667/gravity
http://tubitv.com/movies/563164/white-men-can-t-jump
http://tubitv.com/movies/563168/predators
http://tubitv.com/movies/563162/street-kings
http://tubitv.com/movies/563166/28-weeks-later
http://tubitv.com/movies/563160/max-payne
http://tubitv.com/movies/565093/baggage-claim
http://tubitv.com/movies/563170/jumper

Content Unavailable
Sorry, this video is not currently available.

All of those links are currently available at the moment in the United States

I'm totally unable to download 563667 (Gravity) from the US.  I get that same error with version 2020.12.31:
[TubiTv] 563667: Downloading JSON metadata
[TubiTv] 563667: Downloading m3u8 information
Traceback (most recent call last):
File "/usr/bin/youtube-dl", line 33, in
sys.exit(load_entry_point('youtube-dl==2020.12.31', 'console_scripts', 'youtube-dl')())
File "/usr/lib/python3.9/site-packages/youtube_dl/init.py", line 473, in main
_real_main(argv)
File "/usr/lib/python3.9/site-packages/youtube_dl/init.py", line 463, in _real_main
retcode = ydl.download(all_urls)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 2027, in download
res = self.extract_info(
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 795, in extract_info
return self.__extract_info(url, ie, download, extra_info, process)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 802, in wrapper
return func(self, *args, **kwargs)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 823, in __extract_info
ie_result = ie.extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 532, in extract
ie_result = self._real_extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/tubitv.py", line 78, in _real_extract
formats = self._extract_m3u8_formats(
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1632, in _extract_m3u8_formats
res = self._download_webpage_handle(
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 665, in _download_webpage_handle
urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 627, in _request_webpage
url_or_request = sanitized_Request(url_or_request, data, headers)
File "/usr/lib/python3.9/site-packages/youtube_dl/utils.py", line 2156, in sanitized_Request
return compat_urllib_request.Request(sanitize_url(url), *args, **kwargs)
File "/usr/lib64/python3.9/urllib/request.py", line 320, in init
self.full_url = url
File "/usr/lib64/python3.9/urllib/request.py", line 346, in full_url
self._parse()
File "/usr/lib64/python3.9/urllib/request.py", line 375, in _parse
raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: ''

I'm totally unable to download 563667 (Gravity) from the US.  I get that same error with version 2020.12.31:
[TubiTv] 563667: Downloading JSON metadata
[TubiTv] 563667: Downloading m3u8 information
Traceback (most recent call last):
File "/usr/bin/youtube-dl", line 33, in
sys.exit(load_entry_point('youtube-dl==2020.12.31', 'console_scripts', 'youtube-dl')())
File "/usr/lib/python3.9/site-packages/youtube_dl/init.py", line 473, in main
_real_main(argv)
File "/usr/lib/python3.9/site-packages/youtube_dl/init.py", line 463, in _real_main
retcode = ydl.download(all_urls)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 2027, in download
res = self.extract_info(
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 795, in extract_info
return self.__extract_info(url, ie, download, extra_info, process)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 802, in wrapper
return func(self, *args, **kwargs)
File "/usr/lib/python3.9/site-packages/youtube_dl/YoutubeDL.py", line 823, in __extract_info
ie_result = ie.extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 532, in extract
ie_result = self._real_extract(url)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/tubitv.py", line 78, in _real_extract
formats = self._extract_m3u8_formats(
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 1632, in _extract_m3u8_formats
res = self._download_webpage_handle(
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 665, in _download_webpage_handle
urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data, headers=headers, query=query, expected_status=expected_status)
File "/usr/lib/python3.9/site-packages/youtube_dl/extractor/common.py", line 627, in _request_webpage
url_or_request = sanitized_Request(url_or_request, data, headers)
File "/usr/lib/python3.9/site-packages/youtube_dl/utils.py", line 2156, in sanitized_Request
return compat_urllib_request.Request(sanitize_url(url), *args, **kwargs)
File "/usr/lib64/python3.9/urllib/request.py", line 320, in init
self.full_url = url
File "/usr/lib64/python3.9/urllib/request.py", line 346, in full_url
self._parse()
File "/usr/lib64/python3.9/urllib/request.py", line 375, in _parse
raise ValueError("unknown url type: %r" % self.full_url)
ValueError: unknown url type: ''


[Bug Report] tab-pane's closable prop is not working

Element UI version
1.3.6
OS/Browsers version
Windows 10 / Chrome 58
Vue version
2.3.0
Reproduction Link
https://jsfiddle.net/francisfeng/pj71jkyw/311/
Steps to reproduce
As has been demonstrated in the jsfiddle, the prop in tab-pane is not working. I am aware the tab-pane only emit tab-remove event as it should be. But putting on a closable prop on a tab-pane has no effect whatsoever. Shouldn't it hide the close button when the closable is set to true?
As I looked into the source code, I found out that the computed prop isClosable is not used in tab-pane.vue. I think there are some sort of bug.
What is Expected?
the closable prop in a tab-pane correctly hides the close button.
What is actually happening?
It still show the close button.

This is still not working for me with version 2.0.8
Here is a reproduction link: https://jsfiddle.net/p80u3ttc/


Rebrand rename driver

I began updating this package in conjunction with the Rancher UI driver, which for whatever reason, was assuming the driver name would be one word rather than two, so I elected to use metal rather than equinix-metal -- this would be a trivial thing to revert, if we prefer the full name, but opening the PR using what I know to be a working use of the rebranded name and providing the context.
Fixes #56

@jmarhee I pushed up fixes for my last bit of feedback. If we merge this we will want to get the repo rename in immediately afterward.
Now that I've looked at the code a little closer, I'm wondering if metal is a fair driver name for a Docker machine driver. In Terraform you are specifying equinix/metal in your configuration. In Docker machine syntax you will never use equinix after the driver is installed.
Users can alias drivers, so if metal is ambiguous they can make a more appropriate name.
I'm ok with metal, fwiw.
I'll approve this PR since it is passing tests and I've taken a closer look. I'll leave it to you to merge.


tools: Add some Windows native compilation fixes

Summary
Add some Windows native compilation fixes
Impact
Improve Windows native build
Testing
Can successfully configure project on Win8.1 with cmd

very good!
i tested these patch, is OK!
before your patch, i have to configure nuttx in this way:
tools\configure.bat boards\arm\stm32\stm32f4discovery\configs\win because of check ccname in configure.c .
after your patch, i can configure nuttx in normal way as in Linux:
tools\configure.bat stm32f4discovery:win