Error when making gallery for tutorials

🐛 Describe the bug
The steps to reproduce the error

Install torchaudio from source by CC=clang CXX=clang++ python setup.py develop
Build html by command BUILD_GALLERY=1 make html

It will throw an Extension error:
Extension error (sphinx_gallery.gen_gallery):
Handler <function generate_gallery_rst at 0x7fd73136f790> for event 'builder-inited' threw an exception (exception: Main example directory audio/docs/source/../../examples/tutorials does not have a README.txt file. Please write one to introduce your gallery.)

When I add an empty README.txt under tutorials folder and build the html again, another error shows
generating gallery...
generating gallery for tutorials... [ 10%] audio_datasets_tutorial.py
Warning, treated as error:
audio/examples/tutorials/audio_datasets_tutorial.py failed to execute correctly: Traceback (most recent call last):
  File "miniconda3/envs/dev/lib/python3.9/site-packages/sphinx_gallery/gen_rst.py", line 394, in _memory_usage
    out = func()
  File "miniconda3/envs/dev/lib/python3.9/site-packages/sphinx_gallery/gen_rst.py", line 382, in __call__
    exec(self.code, self.globals)
  File "audio/examples/tutorials/audio_datasets_tutorial.py", line 51, in <module>
    YESNO_DOWNLOAD_PROCESS.start()
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/context.py", line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/popen_spawn_posix.py", line 47, in _launch
    reduction.dump(process_obj, fp)
  File "miniconda3/envs/dev/lib/python3.9/multiprocessing/reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <function _download_yesno at 0x7f979961e040>: attribute lookup _download_yesno on __main__ failed

Versions
Collecting environment information...
PyTorch version: 1.10.0
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 12.0.1 (x86_64)
GCC version: Could not collect
Clang version: 13.0.0 (clang-13<IP_ADDRESS>)
CMake version: version 3.19.6
Libc version: N/A

Python version: 3.9.6 (default, Jul 30 2021, 09:31:09)  [Clang 10.0.0 ] (64-bit runtime)
Python platform: macOS-10.16-x86_64-i386-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] mypy==0.812
[pip3] mypy-extensions==0.4.3
[pip3] numpy==1.20.1
[pip3] pytorch-lightning==1.4.4
[pip3] pytorch-ranger==0.1.1
[pip3] pytorch-sphinx-theme==0.0.24
[pip3] torch==1.10.0
[pip3] torch-optimizer==0.1.0
[pip3] torch-stoi==0.1.2
[pip3] torchaudio==0.11.0a0+e6dd7fd
[pip3] torchmetrics==0.5.0
[pip3] torchtext==0.11.0
[pip3] torchvision==0.2.2
[conda] blas                      1.0                         mkl
[conda] mkl                       2021.2.0                 pypi_0    pypi
[conda] mkl-include               2021.3.0                 pypi_0    pypi
[conda] mkl-service               2.4.0            py39h9ed2024_0
[conda] mkl_fft                   1.3.0            py39h4a7008c_2
[conda] mkl_random                1.2.2            py39hb2f4e1b_0
[conda] mypy                      0.812                    pypi_0    pypi
[conda] mypy-extensions           0.4.3                    pypi_0    pypi
[conda] numpy                     1.20.0                   pypi_0    pypi
[conda] numpy-base                1.20.1           py39h585ceec_0
[conda] pytorch-lightning         1.4.4                    pypi_0    pypi
[conda] pytorch-ranger            0.1.1                    pypi_0    pypi
[conda] pytorch-sphinx-theme      0.0.24                    dev_0    <develop>
[conda] torch                     1.10.0                   pypi_0    pypi
[conda] torch-optimizer           0.1.0                    pypi_0    pypi
[conda] torch-stoi                0.1.2                    pypi_0    pypi
[conda] torchaudio                0.11.0a0+e6dd7fd           dev_0    <develop>
[conda] torchmetrics              0.5.0                    pypi_0    pypi
[conda] torchtext                 0.11.0                   pypi_0    pypi
[conda] torchvision               0.2.2                      py_3    pytorch

cc @mthrok

It turns out I'm using an older version of sphinx-gallery. Updating it to 0.10.0 will solve this issue.

Probably it's a good idea to add the constrain to the requirements.txt.

Sure, sounds good.


Publish Polymer 3 to npm?

It would be nice to publish the element to npm as this is used by Polymer 3 to import other elements.

Hi @DrNiels . I have published this component to npm now. Sorry for being a bit late and Thanks a lot for your help and time :)


HTTPS links to CDN

Thanks!

:-)  FYI; there are some assets loading over HTTP on https://mkoryak.github.io/floatThead/ which is causing mixed-content warnings.


Implemented delete Car functionality

Implement fetch all cars and display and display on nice UI.
Create a delete car form and style.
Implement delete functionality to the api.
Solve linters errors.
Update router to include delete functionality
update backend to include cors., so pull to update before testing.

Please pull to update backend dev branch. There is a slight change that is necessary for working of this code..


Missing data for ccs2 EU

Hyundai / Kia Connect version: 2.19.0
Python version:
Operating System:

Description
After upgrading to 2.19.0 using a kona 2024 EV which uses the new ccs2 support the following fields are missing

heating/cooling all 4 seats
smart key battery warning
defrost
back window heater

Also AC/DC Charging Limit looks strange, in the bluelink app both are set to 100, but HA shows 80

What I Did
Upgrade to 2.19.0

ccs2 support was added as part of https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api/pull/480

I think this info is available, but @Bubo08 did already a great job in providing most of the other information. I got a debug log of a German Kona 2024 with my tool debug.py  from hyundai_kia_connect_monitor.
heating/cooling all 4 seats
"Cabin": {
                    "Door": {
                        "Row2": {
                            "Right": {"Lock": 0, "Open": 0},
                            "Left": {"Lock": 0, "Open": 0},
                        },
                        "Row1": {
                            "Driver": {"Open": 0, "Lock": 0},
                            "Passenger": {"Lock": 0, "Open": 0},
                        },
                    },
                    "HVAC": {
                        "Row1": {
                            "Driver": {
                                "Temperature": {"Value": "OFF", "Unit": 0},
                                "Blower": {"SpeedLevel": 0},
                            }
                        },
                        "Vent": {
                            "AirCleaning": {"Indicator": 1, "SymbolColor": 0},
                            "FineDust": {"Level": 0},
                        },
                        "Temperature": {"RangeType": 1},
                    },
                    "RestMode": {"State": 0},
                    "Seat": {
                        "Row2": {
                            "Left": {"Climate": {"State": 2}},
                            "Right": {"Climate": {"State": 2}},
                        },
                        "Row1": {
                            "Passenger": {"Climate": {"State": 2}},
                            "Driver": {"Climate": {"State": 2}},
                        },
                    },
                    "Window": {
                        "Row1": {
                            "Driver": {"Open": 0, "OpenLevel": 0},
                            "Passenger": {"Open": 0, "OpenLevel": 0},
                        },
                        "Row2": {
                            "Left": {"Open": 0, "OpenLevel": 0},
                            "Right": {"Open": 0, "OpenLevel": 0},
                        },
                    },
                    "SteeringWheel": {
                        "Heat": {"RemoteControl": {"Step": 0}, "State": 0}
                    },
                },

smart key battery warning:
"Vehicle": {
                "Version": "CCU2024012308473901",
                "RemoteControl": {"SleepMode": 0},
                "Electronics": {
                    "Battery": {
                        "Level": 89,
                        "PowerStateAlert": {"ClassC": 2},
                        "Auxiliary": {"FailWarning": 0},
                        "Charging": {"WarningLevel": 65},
                        "SensorReliability": 0,
                    },
                    "PowerSupply": {"Ignition1": 0, "Ignition3": 0, "Accessory": 0},
                    "AutoCut": {
                        "PowerMode": 2,
                        "BatteryPreWarning": 0,
                        "DeliveryMode": 2,
                    },
                    "FOB": {"LowBattery": 0},
                },

defrost/back window heater:
"Body": {
                    "Lights": {
                        "Front": {
                            "Right": {
                                "TurnSignal": {"LampState": 0, "Warning": 0},
                                "Low": {"Warning": 0},
                                "High": {"Warning": 0},
                            },
                            "Left": {
                                "TurnSignal": {"LampState": 0, "Warning": 0},
                                "Low": {"Warning": 0},
                                "High": {"Warning": 0},
                            },
                            "HeadLamp": {"SystemWarning": 0},
                        },
                        "DischargeAlert": {"State": 0},
                        "Rear": {
                            "Left": {
                                "StopLamp": {"Warning": 0},
                                "TurnSignal": {"Warning": 0},
                            },
                            "Right": {
                                "StopLamp": {"Warning": 0},
                                "TurnSignal": {"Warning": 0},
                            },
                        },
                        "TailLamp": {"Alert": 0},
                        "Hazard": {"Alert": 0},
                    },
                    "Windshield": {
                        "Rear": {"Defog": {"State": 0}},
                        "Front": {
                            "Heat": {"State": 0},
                            "Defog": {"State": 0},
                            "WasherFluid": {"LevelLow": 0},
                        },
                    },
                    "Hood": {"Open": 0},
                    "Trunk": {"Open": 0},
                },

So someone could add this information, including the other information not yet filled.

there is data sensor and its attributes hold data about vehicle

Ok, I see now that it holds all fields that there are, also the not exported ones, thanks!

Some attributes are very hard to find out but I think
"FOB": {"LowBattery": 0}, is the low smart key battery warning.
I will integrate it.

I did also add the seat heating status.

@Bubo08
defrost/back window heater, 0 means probably off.
"Windshield": {
                        "Rear": {"Defog": {"State": 0}},
                        "Front": {
                            "Heat": {"State": 0},
                            "Defog": {"State": 0},
                            "WasherFluid": {"LevelLow": 0},
                        },

Defrost had a bug in it. I fixed it

AC DC charging limits is also fixed. It would be interesting if somebody can test it with home assistant as my EV9 is in the car repair shop.

@jwillemsen  could you update from "master" in HACS using the redownload button and let us know if any issues?

Only back window heater is still missing, all others are there now, thanks for all work

Is setting the AC and DC limits working? You are able to change the values by home assistant?

Setting them doesn’t work yet
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:238
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 4:58:46 PM (2 occurrences)
Last logged: 4:59:07 PM
[2601329896] Duplicate request - Duplicate request
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 238, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2173, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2210, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 272, in handle_service
return await service.entity_service_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 882, in entity_service_call
single_response = await _handle_entity_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 952, in _handle_entity_call
result = await task
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/number/init.py", line 111, in async_set_value
await entity.async_set_native_value(native_value)
File "/config/custom_components/kia_uvo/number.py", line 94, in async_set_native_value
await self.coordinator.async_force_update_all()
File "/config/custom_components/kia_uvo/coordinator.py", line 159, in async_force_update_all
await self.hass.async_add_executor_job(
File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/hyundai_kia_connect_api/VehicleManager.py", line 114, in force_refresh_all_vehicles_states
self.force_refresh_vehicle_state(vehicle_id)
File "/usr/local/lib/python3.11/site-packages/hyundai_kia_connect_api/VehicleManager.py", line 119, in force_refresh_vehicle_state
self.api.force_refresh_vehicle_state(self.token, vehicle)
File "/usr/local/lib/python3.11/site-packages/hyundai_kia_connect_api/KiaUvoApiEU.py", line 369, in force_refresh_vehicle_state
state = self._get_forced_vehicle_state(token, vehicle)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/hyundai_kia_connect_api/KiaUvoApiEU.py", line 1049, in _get_forced_vehicle_state
_check_response_for_errors(response)
File "/usr/local/lib/python3.11/site-packages/hyundai_kia_connect_api/KiaUvoApiEU.py", line 119, in _check_response_for_errors
raise error_code_mappingresponse["resCode"]
hyundai_kia_connect_api.exceptions.DuplicateRequestError: Duplicate request - Duplicate request

Bluelink also shows V2L limit and AC large power, these are not yet in HA

Ok, errors happens when you change the same value a few seconds after each time. But, changing one value to 90 doesn't change the value in the bluelink app

V2L discharge limitation is here in data

If I run the following test program:
    vm.check_and_refresh_token()
    vm.update_all_vehicles_with_cached_state()
    for vehicle_id in vm.vehicles.keys():
      ac = 100
      dc = 100
      vm.set_charge_limits(vehicle_id, ac, dc)

Then the values are changed in my KIA connect app. So it should work. Can you please retest and provide the debug log?

Thanks for the code, just tried that, and that works. Maybe something is broken at a higher layer, I will retest when there is a release with your fixes

Attaching the output of https://github.com/ZuinigeRijder/hyundai_kia_connect_monitor/blob/main/debug.py for my Kona 2024, all data provided by Hyundai for reference (cleared some confidential fields)
kona2024data.txt

I think we should close the bug and open a new one in kia_uvo.

Closing, we have separate issues for the last remaining sensors


fixes for Texas vaccine demographic scrapers

Small changes to column/key names.
People Vaccinated   appears to be people vaccinated with at least one shot, but I could not find a proper/formal definition.

Awesome, thakn you


Camelcase hapi

This address issue #129. @SimonDegraeve does this look good to you?
TODO:

[x] Update CHANGELOG.md with your change (include reference to issue & this PR)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass

@helfer @SimonDegraeve don't review the commits this is built on top of the hapi refactor branch.  This is ready to merge if you guys agree.

Looks good to me. Nice work.


feat(logo): adds D logo w/ darkmode support

Hello!
This is the proposal for Dats logo in two flavours 🍦 , the standard one and with the alternate version for dark-mode, following the supported url syntax :octocat: .
What do you think?

Very Cool, Good job! Thank you!
LGTM!

Cool! LGTM!


Dynamic Loss Scaling API

Now we added the dynamic loss scaling API for the mixed-precision training, as one of the experimental APIs.
For the mixed-precision training, have a look at the tutorial.

Thanks for your hard work!!


Please enforce

I am not trolling.

I really do not feel like getting intimidated by you involving politics. So I will just close this pull request for fear of retaliation. Thanks for nothing.


Feature: add unit test for getEnabledChecks() function in cmd/root.go

Function getEnabledChecks() determines which checks are enabled, using a combination of 1) supported checks for the repo interface, 2) wether a policy is given or not, 3) whether --checks is passed as argument or not.
Changing this behavior would be a breaking change.

https://github.com/ossf/scorecard/pull/1750

Closing this issue as v4 has been released and related issues added since reopening this issue have also been closed.


Icon ArrowRight

create ArrowRight icon component using wrapper for Lit

@kailueooi-seb is this PR ready for review or is there more work needed? :)

Hi, it is ready for review

Hey @kailueooi-seb, thank you for opening this PR. There have been recent work done to have React wrappers automatically generated for all icons by default in another PR: https://github.com/seb-oss/green/pull/1522
As such, I will close this one without merging. But regardless, thank you for contributing to Green! 💚


Error: Error   PA3015: Property Removed: TopParent.Children[1].Template.HostService.Name

[ ] Please attach a sample .msapp to this Issue which demonstrates the issue you are experiencing. (Please do not attach any file which may contain sensitive personal or company data.)

Describe the bug
A clear and concise description of what the bug is.
Error using Power Platform ALM Accelerator pac-Clone or Sync Solution step
To Reproduce
Steps to reproduce the behavior:

Checksum mismatch unpacking canvas app

Screenshots

Additional context
Add any other context about the problem here.
Add any helpful context on the .msapp like created from teams, contains custom pcf components, etc.

The latest version of the PAC CLI has been released with the fix. If you are still experiencing roundtripping errors on the latest version of the CLI, please feel free to reopen this issue.

Pr linked with the issue would ultimately fix this issue and other similar issues filed around the same time as this one. The fix should be in the next release of PAC CLI


Upgrade to tailwind 3

Description

Upgrade to tailwind 3
Change few deprecated tailwind class

Thanks! Ended up letting Shift handle this in #209.


Add Network Merchants Inc. (NMI) Gateway

Thanks for doing this one!

FYI, this is now used in production for 2 weeks without issues.

+1 @mfauveau thank you!


[vulkan] Debug report from ObjectType: 5

I keep getting a lot of console output, mostly this one repeating over and over again:
[vulkan] Debug report from ObjectType: 5
Message: Validation Error: [ VUID-vkAcquireNextImageKHR-semaphore-01779 ] Object 0: handle = 0x967dd1000000000e, type = VK_OBJECT_TYPE_SEMAPHORE; | MessageID = 0x5717e75b | vkAcquireNextImageKHR():  Semaphore must not have any pending operations. The Vulkan spec states: If semaphore is not VK_NULL_HANDLE it must not have any uncompleted signal or wait operations pending (https://vulkan.lunarg.com/doc/view/1.3.275.0/windows/1.3-extensions/vkspec.html#VUID-vkAcquireNextImageKHR-semaphore-01779)

Same problem.

I got the problem as well
I get two handles swapping each other each frame,
frame 1 has this handle: 0x967dd1000000000e
frame 2 has this handle: 0xdcc8fd0000000012
for the rest the entire message is the same
a quick google for this debug error got me to this thread from dear ImGui which might be the issue, although, the place where the error takes place only uses the imgui vulkan window implementation (line which causes the error)
also, the error specificly states

The Vulkan spec states: If semaphore is not VK_NULL_HANDLE it must not have any uncompleted signal or wait operations pending

and the line which causes the error uses VK_NULL_HANDLE. there are only things stated when it is not VK_NULL_HANDLE
I think this is either an issue with dear ImGui, or vulkan where walnut needs to find a workaround for, as this is a Walnut issue, and not a WalnutAppTemplate issue
Im gonna open a post there and link to this one, as it should be fixed there


Documentation issue

OpenBLAS make apparantly uses many kewords, which are poorly documented.
For instance, make NUM_THREADS=64 USE_OPENMP=1 USE_THREAD=1 PREFIX=...
Is there a full list of what make can accept?
Thank you.
Andrew

Please see Makefile.rule

Many thanks. Today I learned.

It may be a bit unusual to document it this way, but this is how it was already done in the original GotoBLAS - and it is even mentioned in the "GotoBLAS_02QuickInstall.txt" document that is retained from that time.


Refined TCK process

After rereading the TCK process, I feel the following is not practical for MicroPorfile community:

Approval that the TCK requirements have been met is a prerequisite for getting
the corresponding runtime listed as a complible implemenation of a particular MicroProfile platform release.
The required approval processes is:

Approval by lazy consensus after a period of two weeks (14 days) or

Approval by a majority vote of the specification contributors as soon as
it happens.

The sum of the +1/-1 votes must be greater than 50% of the
specification committers.

The 2nd rule about approval by a majority vote. Since MP has no boundary for specs, we have large number of committers. It is not practical to require at least half of them review the CCR. I would like to suggest the following:
Approval that the TCK requirements have been met is a prerequisite for getting

Approval by lazy consensus after a period of two weeks (14 days) or

Approval by at least two of the specification committers as soon as
it happens.

The specification committers must not work for the same company where the certification requester is associated with.


GitHub description/readme should reflect also supporting the Microsoft Store

Right now, the GitHub description says this:

"Windows Package Manager CLI (aka winget)"

Which seems incorrect and just making the app look worse than it is. Since winget also supports installing Microsoft Store apps (or rather, installing apps that are managed by Windows Update, and not by Windows Package Manager), it really is just a general package manager that supports several sources, and not just a "Windows Package Manager CLI".
Should we update the description and readme to make this clearer?
It seems to me it'd make the app even more attractive 🙂

To me it seems correct, since there isn't a GUI for winget yet - it is only a Command Line Interface. I do agree that it is a general package manager that supports several sources, and that the name "Windows Package Manager" is a bit wordy. I can certainly see how rebranding would make it more attractive, I just don't know that simply dropping the "CLI" portion would make it any more attractive to the overall userbase

Wait, I think there's a misunderstanding here. I'm not saying the "CLI" part should be dropped, that's absolutely correct. It's the "Windows Package Manager" part that's incorrect. That is because winget is not just a Windows Package Manager client, but it's also effectively a Windows Update client (since it can install Microsoft Store apps as well provided through Windows Update). So what I'm saying is that by just describing winget as "Windows Package Manager CLI", we're not making it clear that you can also use it to install any app in the Microsoft Store, thus underselling its value. Does that make sense? 🙂
As in, to me the description should be more something like:

"A CLI package manager tool for Windows, that can find and install apps from both Windows Package Manager and the Microsoft Store"

Not saying this is necessarily the perfect description, just wanted to illustrate how this would be more accurate.


Obtain HRV from ECG Signal

Issue Closed: Successful Obtaining of Heart Rate Variability from ECG signals
This issue has been successfully addressed in commit (ce8314f8e6fc83b2c83dbeaf9dbb4b50feaef278)
HRV Calculation:

RR intervals (time between consecutive R peaks) are stored for a specified window (default 30 seconds).
Once enough RR intervals are collected within the window, the Root Mean Square of the Successive Differences (RMSSD) is calculated as a measure of HRV.
The RMSSD provides an indication of the heart rate's variability, reflecting the influence of the autonomic nervous system on heart rate.

Additional Notes:
Comments have been added to explain the HRV calculation and provide reference values for interpreting RMSSD scores in healthy adults.


Fix temporary file permission issue in LogReport

Fixed the same issue as #4461.
This kind of use of temporary directory is very common, so I made a context manager as utils.tempdir(), and applied to all such instances.

LGTM!

LGTM!
@okuta Test passed. Could you merge?


Diagonal and Quantity for each leg support please

Hi, its a great tool! Thank you it works great. Can you please add the ability to add different expiry dates to each leg and quantity for each leg.
Like Friday and Monday - Diagonal
and Selling 1 and Buying 2
Appreciate it!

Thanks for the suggestion,
Options to add multiple contracts added.
Update the package check the new parameter 'contract'
Multiple expiration dates will be added soon.
Cheers!

@hashABCD In your comment you mentioned multiple expiration dates will be added soon. Is this something you've already started on? If not I was going to fork and see if I could get a working version with multiple expirations but didn't want to re-invent the wheel.


Terminal: Underline on Hover Is Inconsistent & Column/Line are not considered when jumping to source

When hovering on path, the path is underlined.
However, when hovering on the path extension, only the line number is underlined.
When hovering on the line number, the column number is underlined:

Also, when clicking on the path, the column/line numbers are not taken into account. The file is opened in the editor, but the cursor does not jump to the specified column/line number.

That is a supported format so need to investigate (path)(line,col): https://github.com/microsoft/vscode/blob/f880c417dad6ef7571bfbc80e3d4c746a6478b07/src/vs/workbench/contrib/terminal/browser/links/terminalValidatedLocalLinkProvider.ts#L41
I can also reproduce the weird offset thing going on.

Actually, the link requires ctrl meaning the regex isn't working and it's falling back to "word" links, so the offset is probably specific to word links.

Validated links regressed in https://github.com/microsoft/vscode/pull/139136, the offset problem applies to validated links and word links.

Offset problem was caused by how we changed padding handling recently: https://github.com/xtermjs/xterm.js/issues/3579


build(release, zip): pin zip build to macOS-10.15

PR #8543 specifically leaves the zip build on macOS-latest (vs macOS-11) so that the build has access to the oldest supported Xcode (12.2 as of now) to avoid bitcode-incompatibility
However, macOS-latest is currently transitioning to macOS-11 which will lead to build failures as macOS-11 does not have access to Xcode 12.2
migration plan:
https://github.com/actions/virtual-environments/issues/4060
macOS-11 without Xcode 12.2:
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode
macOS-10.15 still has Xcode 12.2:
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode
This pins the zip build to macOS-10.15 in order to maintain Xcode 12.2 access
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Testing
I rely on @paulb777's keen eyes here

Saw this while clicking through the 8.8.0 release notes and the related github links and their transitives, easier to PR it then write a note, given GitHub's web UI working pretty well...cheers


test: fix issue with region used by test

Description
ca-tor is not supported by Event Notifications, but it is by SCC, so the complete example fails when it selects ca-tor
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[porter/aks how to build azure once click UI

Can someone please help me understand how the simple/advanced Azure one-click UIs are built? Is this something we have to build ourselves each time or does this project help build them based on the porter.yaml?

Do you mean the "Deploy from Azure" button?

Thanks @HowardvanRooijen ! Yep that is what I'm looking for. I assume then that there's nothing in this quickstart (or related tooling) that builds the json for you?

The JSON is just an ARM template!

Ok thanks @HowardvanRooijen I'll take that to mean "just use the template, there is no functionality to build it in this project".


Highlight spacing issue.

This is an attempt to highlight the fact that spacing is a bit funky for YAML, see #629 for background.

Looks good to me


setMapBoundaries does not seem to be working

I am playing around with setMapBoundaries and trying to limit the map to NJ state using its NW/SE coords but it does not seem to be doing anything.
What is the expected behavior when setting map boundaries? Am I not supposed to be able to scroll beyond the boundary?
ENV INFO:
Binaries:
   Node: 10.16.3 - C:\Program Files\nodejs\node.EXE
   Yarn: 1.17.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
   npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD
 npmPackages:
   react: 16.9.0 => 16.9.0
   react-native: 0.61.5 => 0.61.5

  "react-native-maps": "^0.27.1",

USAGE:
           componentDidMount(){
               this.mapRef.setMapBoundaries(
                     {latitude: 39.833851, longitude: -74.871826},
                     {latitude: 41.342889, longitude: -74.696047});
             }

          render() {
                   return(
                                <MapView
                                       key={this.state.markers.key}
                                       style={styles.map}
                                       initialRegion={{
                                           latitude: parseFloat(this.state.lat),
                                           longitude: parseFloat(this.state.long),
                                           latitudeDelta: 0.0250,
                                           longitudeDelta: 0.0250,
                                       }}
                                       ref={(ref)=> this.mapRef = ref}
                                       loadingEnabled = {true}
                                       loadingIndicatorColor="#666666"
                                       loadingBackgroundColor="#eeeeee"
                                       moveOnMarkerPress = {false}
                                       showsUserLocation={true}
                                       showsCompass={true}
                                       showsPointsOfInterest = {false}
                                       provider={MapView.PROVIDER_GOOGLE}
                                       onPress={e => this.onMapPress(e)}>
                                       {this.state.markers.map((marker)  => (
                                           <MapView.Marker
                                               key={marker.key}
                                               coordinate={marker.coordinate}
                                               title={marker.title ||''}
                                               description={marker.description || ''}
                                           />
                                       ))}

                                   </MapView>
                    );
}

This issue still happening on Android(Mobile). It Works on Tablet, and work on iOS(Tablet/Mobile) as well.


add page slug to navigation node

Please add it to cms. It is need in navigations with dropdowns for example topmenu here
http://<IP_ADDRESS>:8000/
data-dropdown options

Would it be more useful to add the page id to a NavigationNode? Then the menu template could have access, if needed, to all of a page's attributes.
@yakky @mkoistinen comments?

Yes it's good idea

The only issue is potential performance effect in case of very big menus, we should be able to check this when adding attributes to a NavigationNode

@evildmp @mkoistinen @czpython I am +1 on adding slug to the menu (the memory impact is negligible even with very large menus)
As for the complete page, we already tried that and we had to remove it due to huge memory impact

I'm not opposed to the slug, but its not unique (can be the same at different levels), why not a page ID? Isn't that better?

@mkoistinen it's not unique but it can be helpful to provide some context. page.pk it's too unique maybe?

@evildmp and I discussed the idea of adding a page_id attribute with the page.pk. This should only be present if the node does in fact represent a Page instance. This would solve the immediate issue, but perhaps isn't as extensible as it could be. If we later have a lot of types of things that can be menu nodes, then the nodes would get pretty cluttered with attributes of different sorts.
So, we thought it best that we should add two attributes: content_type_id and object_id. In the common case, the content_type_id would reference the Page model and the object_id, of course, would reference the instance's pk.
I think this solves the issue in the general case and is in-fact, rather Djangonic.

I don't think primary key is of much use, actually, it's really too specific. slug and/or reverse id are good candidates as additional keys to attrs dictionary, like other.
Adding a 'type' attribute to the navigation node can be helpful, but id'r rather user something like app_name__model_name as menus are mostly used in templates, where you can't easily work with queryset to detect the required content type.
As NavigationNode is completely disconnected from the concept and implementation of models we should keep implementation details like ids/pks/foreign keys out of it.

Is the slug (url part at the current level) really useful for this? It's only unique at the current url level. Does it still work for the data-dropdown case when the same slug appears twice on the site? Wouldn't it fall apart when using navigation nodes that are not based on cms pages (do they all have slugs?).
So the unique thing (most of the time, but there can be exceptions) would be the whole path, but that has annoying /s in it.

I think we should rethink the way menu nodes interact with pages, the end goal would be to make it possible to access any attribute of the page/title while keeping the memory footprint low.
I have nothing against adding the slug of the page but don't see it being very useful for the reasons outlined by @stefanfoulis and also can become an issue as we start adding more and more attributes to the object.

I think we should rethink the way menu nodes interact with pages, the end goal would be to make it possible to access any attribute of the page/title while keeping the memory footprint low.

Please keep in mind that node != page. Not every node has a page associated with it, which is why there's no page attribute on the node. The idea is/was that the menu code is mostly independent from the page code and that nodes should be mostly standalone.

How about having a very simple way for developers to add desired page attributes for nodes (like a modifier that read some setting or an easy-to-subclass modifier)
NavigationNode should be kept totally agnostic on the item it represents

Thanks for the contribution @AlexProfi.
I'm closing this as it requires a design decision by the core team.


I'm not able to open pdf url

Hi barteksc
Thanks for such type of library
1 My query how to open Pdf URL I've checked but didn't get.
2 how to move a page forward and backward when user click on forward and forward button

opening pdf from webpages is not supported,


Issue in RForecast Predictor on Windows

When I am trying to use ARIMA using RForecastPredictor,it is throwing error.
from gluonts.model.r_forecast import RForecastPredictor

predictor=RForecastPredictor(
    freq='H',
    prediction_length='24',
    method_name='arima',
    period=24
)

I am getting error
RRuntimeError                             Traceback (most recent call last)
c:\users\appdata\local\programs\python\python37\lib\site-packages\gluonts\model\r_forecast\_predictor.py in __init__(self, freq, prediction_length, method_name, period, trunc_length, params)
     99             try:
--> 100                 robjects.r(f'source("{this_dir}/R/{n}.R")')
    101             except RRuntimeError as er:

c:\users\appdata\local\programs\python\python37\lib\site-packages\rpy2\robjects\__init__.py in __call__(self, string)
    350     def __call__(self, string):
--> 351         p = _rparse(text=StrSexpVector((string,)))
    352         res = self.eval(p)

RRuntimeError: Error: '\u' used without hex digits in character string starting ""c:\u"

The above exception was the direct cause of the following exception:

RRuntimeError                             Traceback (most recent call last)
<ipython-input-30-9d66d53f1765> in <module>
----> 1 predictor=RForecastPredictor(freq='H', prediction_length='24', method_name= 'arima', period=24)

c:\users\appdata\local\programs\python\python37\lib\site-packages\gluonts\core\component.py in init_wrapper(*args, **kwargs)
    441                 self.__class__.__repr__ = validated_repr
    442
--> 443             return init(self, **all_args)
    444
    445         # attach the Pydantic model as the attribute of the initializer wrapper

c:\users\appdata\local\programs\python\python37\lib\site-packages\gluonts\model\r_forecast\_predictor.py in __init__(self, freq, prediction_length, method_name, period, trunc_length, params)
    100                 robjects.r(f'source("{this_dir}/R/{n}.R")')
    101             except RRuntimeError as er:
--> 102                 raise RRuntimeError(str(er) + USAGE_MESSAGE) from er
    103
    104         supported_methods = ["ets", "arima", "tbats", "croston", "mlp"]

RRuntimeError: Error: '\u' used without hex digits in character string starting ""c:\u"

The RForecastPredictor is a thin wrapper for calling the R forecast package.
In order to use it you need to install R and run

pip install 'rpy2>=2.9.*,<3.*'

R -e 'install.packages(c("forecast", "nnfor"), repos="https://cloud.r-project.org")'

I have already installed rpy2.
pip install rpy2
Requirement already satisfied: rpy2 in c:\users\appdata\local\programs\python\python37\lib\site-packages (2.9.5)
Requirement already satisfied: six in c:\users\appdata\local\programs\python\python37\lib\site-packages (from rpy2) (1.14.0)
Requirement already satisfied: jinja2 in c:\users\appdata\local\programs\python\python37\lib\site-packages (from rpy2) (2.11.1)
Requirement already satisfied: MarkupSafe>=0.23 in c:\users\appdata\local\programs\python\python37\lib\site-packages (from jinja2->rpy2) (1.1.1)

@parimuns what version of gluonts are you using?

I have already installed rpy2.
pip install rpy2

@parimuns this is what the error message suggests:
pip install 'rpy2>=2.9.*,<3.*'

R -e 'install.packages(c("forecast", "nnfor"), repos="https://cloud.r-project.org")'

Could you try running these commands? The second may need to be done differently on Windows, I'm not sure (you just need to install the "forecast" and "nnfor" packages for R)

I am working on windows and I am using  gluonts 0.5. "forecast" and "nnfor" packages are already installed ,still its giving same error.

Hello @parimuns,
I've just merged a fix. Can you try the newest version from GitHub? Since we haven't released the fix yet the version from PyPi shouldn't work yet.


Feature flags docs

We have the docs building for all the public API.
This means that it is not immediately obvious that some
API bits are due to feature flags.
We should have a section in the doc of each item:
# Feature flags

This thing requires the cargo feature "foo"

Since docs are built using nightly on docs.rs, you could make use of the following:
https://doc.rust-lang.org/beta/unstable-book/language-features/doc-cfg.html
https://docs.rs/about/builds
i.e. enable a feature on docs builds, that enabled the unstable doc_cfg feature, which allows you to add #[doc(cfg(...))] to any public item which is cfg-ed.
See https://docs.rs/syn/latest/syn/ for an example of what that looks like

Thanks!  I'd just read this in "Rust for Rustaceans", which is what got me thinking about it.

It does seem like there's some "trust" involved that this will work.  I'm unable to get the docs.rs commands from their README to work locally to confirm that the changes actually do anything.


Use a remote bazel cache to speed up builds

There are some "413 Request Entity Too Large" errors in the build log, is that bad? I guess it still finished (and in 7m, which is awesome).

I think it's fine (if an object fails to get cached it's not ideal, but equally it won't break the build). They're coming from Cloudflare, so I can follow and try and figure out what's going on, and if the limit can be raised (I guess we have a default limit at the edge?)

To follow up on the limit, I think this is just hitting a default for workers.dev. It'll only fail on the largest of uploads. I don't think this is a blocker for this being merged though


Feature request: option for newline for Input

Could you add an option that if Shift+Enter is entered the console appends a newline?

Mentioned in #302


print("Hello World") only prints World

>> print("Hello World) returns World only, generally speaking, >> print("str1 str2 str3....") prints str2 str3 ....

Thanks for the bug report! However, I'm having trouble replicating the issue on my testing server - to use your example:

I don't really know what could be causing the issue, but I'll take a quick poke around my code and see if I can find anything that might be causing this, and I also plan to check the open issues for RestrictedPython to see if that could be a problem.
In the meantime, could I have a little more information about your OS and Discord version (just in case)? Oh, and out of curiosity, is there some reason our code boxes look different?

I made a few little improvements - improved a nasty regex that might have been mangling your input, and updated the dependencies. Let me know if this is still an issue.

Thank you for your response, I realised i was using the Android Alpha version v49.1 at that time, i tested it on the stable android version(v47.x) and on the desktop version, and it worked pretty well.
Interestingly, the test case I used previously is showing the desired result on the stable versions

Well, I guess I'll close this for now. Just let me know if you have any more problems.


rayon-demo: port nbody visualize to EventLoop::run_app

Since #1191, we have this warning:
warning: use of deprecated method `winit::event_loop::EventLoop::<T>::run`: use `EventLoop::run_app` instead
   --> rayon-demo/src/nbody/visualize.rs:137:10
    |
137 |         .run(move |event, target| match event {
    |          ^^^
    |
    = note: `#[warn(deprecated)]` on by default

Hello, just opened a pull request on this one: https://github.com/rayon-rs/rayon/pull/1206


Create saperp-opdg-checks.ps1

Settings up an on-premises data gateway for the Power Platform SAP ERP connector has several steps involved, more so if Kerberos is in play.
This goal of this script is give others a way to troubleshoot issues they might have during implementation.

Hello @JimDaly ,
Can you share next steps on who could be added as a reviewer to this PR? I spoke to Matthew Barbour (Power Apps architect) and he suggested this be the best place for distribution of this particular script.

Discussed this with Scott.
He is going to add a README.md to explain what this script is for, how, and when to use it.
This seems to be related to SAP ERP connector

@jimdaly README.md added. Please share your thoughts on any improvements I can make.

@jimdaly Any updates or thoughts you can share?

@scottwoodallmsft
I think it looks good I merged it.


Why does glyph() function panic now?

In rusttype 0.4.X, the glyph function didn't panic, but rather returned an optional value if the glyph wasn't found. Now, in rusttype 0.5.X, the function just panics. Why, what is the reason to revert a safer API?

Sorry, forgot to read https://github.com/redox-os/rusttype/issues/96


Assign task - Long task description goes beyond the scope, doesn’t disappear after delete

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Log in with any Gmail account
On LHN, click on the FAB button
Select Assign Task
Enter a title and description
Change the description for a long text, for example long URL

Expected Result:
The Task description is fully visible
Actual Result:
Long task description goes beyond the scope
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.71-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/36ec8d51-f11f-4656-bd33-e5691efb35d9
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Same thing happenning for Private Notes. And it is also showing up like [link](link) which should not be the case.

Proposal
Please re-state the problem that we are trying to solve in this issue.

On passing long text to description of Assign Task / Private Notes - the text is not wrapped.

What is the root cause of that problem?

RenderHTML component is being rendered for these previews and it is not wrapping the text.

What changes do you think we should make in order to solve the problem?

We can wrap the RenderHTML component with a View and set its style to chatItemMessage. This will wrap the text.

<View style={styles.chatItemMessage}>
    <RenderHTML html={html} />
</View>

Output:

What alternative solutions did you explore? (Optional)

N/A

Happened due to My PR only 🥲 and also the private notes.

https://github.com/Expensify/App/pull/25761
https://github.com/Expensify/App/pull/27462

@jeet-dhandha Can you spin up a PR for a fix?

Sure

@thienlnam One issue in native app. When i render below component it render's perfectly for Private notes as links are saved as [link](link) but in Assign Task we don't do that thus its not rendering and coming as empty.
<View style={styles.chatItemMessage}>
    <RenderHTML html={getProcessedTitle} />
</View>

But if i render without View in native app. It renders and wraps text perfectly.
<RenderHTML html={getProcessedTitle} />

Ready for review @thienlnam

Crap, I did not take a close enough look - we should not have added that platform specific code in there

I think we would update private notes to work the same way as task and money request descriptions

@thienlnam i think we already have some files in which we not following separation based on index.${platform}. In case this is a deploy blocker - and correct fix should be done for private notes to following the same concept (not sure why it was done in different manner)

Yeah we have had some instances slip through, but it's our responsibility to help make sure that more instances of that doesn't keep happening. Deploy blockers definitely have more urgency to them, but doesn't mean we should merge code that is against our guidelines unless there is a strong reason to.
cc @techievivek Since you added the private notes - are you able to update it to work the same way as task and money request descriptions so we can remove the solution 2 hack we added here?

@thienlnam fully agree - i just ask in PR to make additional change - for file separation - until we will not get private notes done in the same manner

Thanks - appreciate it!

@jeet-dhandha From your proposal here https://github.com/Expensify/App/issues/27722#issuecomment-1724688317

RenderHTML component is being rendered for these previews and it is not wrapping the text.
This is true only for the private notes, right? I didn't make any change for the task related code. Or am I missing something here?

Its not hack for ‘Private notes’ @thienlnam, the issue is in native apps. When we render Assign task descriptions its not rendering in native app when i add View with the chatItemMessage.

And its happening on Native Apps only and only in Assign Task 🥲

Currently my code fixes the wrapping issues for non-native platforms and not the native platforms.

If anyone can just quickly check the output without the conditional render for Android/iOS.
<View style={styles.chatItemMessage}>
   <RenderHTML html={getProcessedTitle} />
</View>

It should show empty screen which shouldn’t be the case.

https://github.com/Expensify/App/assets/28352309/d41cd15c-2c0c-44aa-baf8-44808e284ab2
It shows - empty line

@jack I am not sure what's going on with the issue. Is it a bug related to Task or private notes, or both? As far as I remember, we only render private notes as HTML. Before we move forward, it would be good to understand the issue correctly and why it happened.
After looking at the comment in the proposal https://github.com/Expensify/App/issues/27722#issuecomment-1724688317, I don't think it's true because I only passed shouldRenderAsHTML as true for private notes and not for the task.

As we both added RenderHTML in MenuItem I thought of fixing it for both Private Notes as well as Assign Task

Can you please link to your PR where you add this change?

The issue is with RenderHTML it does not wrap itself when we render long texts on web based platforms like “desktop, web, mobile chrome and mobile safari”.

Can we not mimic what we do for report actions?

let's for now clean up the code to make platform specific choice based on files instead of ? : in MenuItem file

Agree, as the first step, let's first clean this up and then we can look into the solution.

@techievivek thanks, please look for the solution while i create the PR for different files. 👍

As we both added RenderHTML in MenuItem I thought of fixing it for both Private Notes as well as Assign Task

Can you please link to your PR where you add this change?
Its linked above.

Fixed the overflow issue @narefyev91 @thienlnam.

Payment due October 2nd

Quick question: Amount and payment date ?

Payment due today. @thienlnam I'm trying to piece together all of the parts of this. Seems like there were 3 different PRs, and it was potentially also identified as a deploy blocker in https://github.com/Expensify/App/issues/27722#issuecomment-1726259154.
Can you summarise what's happened in this issue so I can finalise those payments? Thanks

Bump on https://github.com/Expensify/App/issues/27722#issuecomment-1743784376 @thienlnam

Yes, this was linked to a few regressions and a couple more feature requests, let's just do the standard single issue deduction for this one

Cool, thanks for clarifying. Offers have been sent out.
Also @narefyev91, a reminder to complete the BZ checklist when you get a chance - thanks!

The PR that introduced the bug has been identified. Link to the PR - current PR fixed most of the bugs which came
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - there were some issues which were linked to first PR, most of them were more like feature requests
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1695182982405449
Determine if we should create a regression test for this bug:
Regression tests:

First flow:

Create any task from FAB.
While creating the task in description enter any URL.
Verify that the URL is converted to a link.

Second flow:

Open any chat and open assign task modal.
Then add a long description including a url and press next.
Verify that the description should be wrapped and not overflow.

Third flow:

Go to any chat > chat header > Private note > My note
Create multiple lines
Add a code block markdown in the middle
Save it
The code block does not create empty lines below it in the note preview

@burczu mentioned that https://github.com/Expensify/App/issues/28623 and https://github.com/Expensify/App/issues/27802 might be regressions from this PR. @jeet-dhandha can you take a look and fix?

Sweet. Opened an issue for those regression tests. We're all done, thanks everyone


Querying for files included

Given a source file, how would I query for what files were included and their corresponding positions in the file?
Include is not part of the UHDM hierarchy. Can we make another UHDM model to represent this information?

UHDM does not carry pre-processor information. Surelog pre-processor on the other hand has all that information.
If you link your application to libsurelog.a, you can retrieve that information from the PreprocessFile class, it has relations of who includes a given file and what files are included from a given file. Macros are also stored in FileContent data structures.
From the Design object, you can get the list of files (Compilation Units), then from the list of Compilation units you can navigate the include information.
Some class members might have to be exposed by public assessor functions so you can make those queries.

Are you referring to using https://github.com/chipsalliance/Surelog/blob/d07533d8e119868b422605df7aaffd3908a4394f/src/Design/Design.h#L198 or https://github.com/chipsalliance/Surelog/blob/d07533d8e119868b422605df7aaffd3908a4394f/src/Design/Design.h#L200?
I see it has pointers to FileContent but how do I go from FileContent back to to PreprocessFile? Does the relation already exist?
Instead, why not use https://github.com/chipsalliance/Surelog/blob/d07533d8e119868b422605df7aaffd3908a4394f/src/SourceCompile/Compiler.h#L67 since CompilerSourceFile already has direct access to PreprocessFile. https://github.com/chipsalliance/Surelog/blob/d07533d8e119868b422605df7aaffd3908a4394f/src/SourceCompile/CompileSourceFile.h#L91
Noted - Compiler class itself is shadowed by SURELOG::scompiler and also compiler.h isn't installed either.

You proposed it originally, but let me expand on it: You could create a new set of object model in UHDM. Just don't call them vpiXXX, as they are not part of the VPI API, call them uhdmFileInfo, uhdmMacroInfo, uhdmInclude or something like that.
Then from Surelog, populate that model the same way we populate the VPI UHDM using the pointers you found above.
Your client code would interface with the UHDM model instead of the guts API of Surelog.
From the uhdmdesign object, you could have a vector of uhdmfileinfo, which in turn has include uhdmfileinfo vector and uhdmmacro info in a recursive fashion.

@alaindargelas What's the update on this? Are the all pieces in place for exposing the necessary information from within the UHDM model? I was planning on adding a list of all imports to the design model.
struct ImportFileInfo {
  SymbolId sourceFileId;
  SymbolId targetFileId;
  int32_t startLine;
  int32_t startColumn;
  int32_t endLine;
  int32_t endColumn;
};

Let me know if you had some other approach in mind.

This is way too low priority for me at this point, you have to handle it on your own.

We can probably handle this with some guidance.
The last I remember was that the end-column information for the import filename was missing. This was the only piece I wasn't clear on how to proceed.
Is design still the right place to expose this information from?

Yes, create a full schema in UHDM, (append to the existing Verilog model):
import_file_info.yaml
obj_def: import_file_info
.....

There is already a schema named 'import' which is used for representing package import. There's only a single 'constant' property. Can we use this schema to represent file import as well or would you rather define a new schema?
Also, any reason why it's named import and not import_typespec??

Please create a new schema.
Sorry, I used a wrong name, based on the struct above.
It should be:
include_file_info.yaml
obj_def: include_file_info
.....
typespec is for data type.

Fixed by #2892


STYLE: style admonitions

related to #1040
The idea here is to align the styling of our admionitions on what's used in other themes so that user don't get lost when switching to ours. In short the RTD theme is driving everything as it's the one by default when you publish on their site so I think we can consider their coloring as default. some themes are stricly respecting it (picolo, insipid, alabaster, material). Furo stands out as every admonition have a color variation on RTD theme (important green is not the same as hint green).
Thus what I changed in this PR:

use text justify for custom admonitions (inspired by Furo)
use grey color and pencil icon for todo admonitions
fallback to blue for seealso

everything can be checked on this page:

@drammock I decided to change the secondary color for 2 reasons:

it was only used by the links in our documentation (so I think users don't even know it exists)
it was the same color as warningmaking it redundant.

so by changing --pst-color-secondary I introduce a diff between 2 semantic colors (warning and secondary) and the previously used color is still there (as --pst-color-warning) without adding an extra variable.

I think users don't even know it exists

I disagree.  We use --pst-color-secondary in 5 places in our custom CSS for MNE-Python, so that various elements have similar color behavior to link hovering.  And the color variables are advertised in our docs, which say:

There are two special color variables for primary and secondary theme colors (--pst-color-primary and --pst-color-secondary, respectively).

To your second  point:

it was the same color as warning making it redundant

That is, IMO, not a problem. The same is true of primary and info.  I think it's weird if all the admonitions have an associated semantic color name variable except for one or two of them.  Having a complete suite of semantic color name CSS variables makes maintenance easier, and importantly gives users the option to alter the secondary color without affecting admonitions.  If someone wants their link hovers to be purple, we shouldn't force them to do extra work to prevent their attention admonitions from also changing to purple.

The demo page looks good to me as well!
I think if @drammock notes that mne uses the secondary color in many other places, we should assume other projects do as well. I'm +1 on merge once his suggestions are addressed!

Would it be possible to also check that the updated new colours have sufficient contrast for accessibility purposes? The --pst-color-primary has insufficient contrast, which creates a lot of noise in the accessibility contrast reports, but it would be good to check that the new colours have sufficient contrast to be accessible in both the light and dark themes. Then they won't have to be fixed in the near future to improve the accessibility.

Would it be possible to also check that the updated new colours have sufficient contrast for accessibility purposes?

+1 although I'd prefer that go in it's own PR so we don't delay this one any further.

Agree w/ @drammock - since this PR isn't about the default colors already, let's open an issue to discuss and track the need for accessible default colors, and fix that in a follow-up PR.

Fine by me. It is the eternal pull between clean, self-contained changes and fixing all the issues. I'll start making a list of colours with contrast issues in a separate issue.

I'm OK with these changes.
I dislike orange, and think it should be replace by yellow. All of the orange and yellow admonitions are "close enough" semantically not to merit distinct colors. One fewer color to wrangle in regards to accessibility is a win, too.

@scmmmh the main reason that the colors conversation might be trickier is because the two main default colors of the theme are defined by the PyData brand, and not unique to this theme. So the question of "should we change the default primary and secondary color?" will also require answering "should this theme's default style break from the PyData brand colorscheme?" and that's more complex than just deciding on the right a11y-friendly color value.
re: Orange vs. yellow, I think the reason we see orange in this theme is for the same reason - it is one of the two PyData brand colors.

@choldgraf Yes, I see the problem. In part that is why I added my comment. When making the accessibility fixes is disconnected from the initial design step, then changing can be trickier, as there are often other dependencies that have arisen since the design decision. The change is probably even trickier, because the contrast is insufficient in both the light and dark themes, but to make it compliant would need to be changed differently for each of the two themes.

OK I've pushed a commit to address these comments, and the doc builds page still looks good to me: https://pydata-sphinx-theme--1043.org.readthedocs.build/en/1043/examples/kitchen-sink/admonitions.html#admonitions
@choldgraf or @12rambau please merge unless you notice a mistake in my last commit.

sorry for not pushing it I thought it was already done. thanks @drammock

Thanks so much everybody for the discussion and thanks @12rambau for getting it through!


Implicit NK_CONSOLE_IMPLEMENTATION

This change makes a change to require a definition of NK_CONSOLE_IMPLEMENTATION to allow more control over when it's included.

@brianwatling Would love your thoughts on this. Does give a bit more control over how it's included, but does need a bit more work to include it...
#define NK_IMPLEMENTATION
#include "nukear.h"

#define NK_GAMEPAD_IMPLEMENTATION
#include "nuklear_gamepad.h"

#define NK_CONSOLE_IMPLEMENTATION
#include "nuklear_console.h"


Native Binary (1.4.0) just exits 127

I tried switching over to the new native binaries, but they are just exiting right away (127). What are the requirements?
[tmcneely@local yaml-config-updater]$ docker run -it alpine
Unable to find image 'alpine:latest' locally
latest: Pulling from library/alpine
59bf1c3509f3: Pull complete
Digest: sha256:21a3deaa0d32a8057914f36584b5288d2e5ecc984380bc0118285c70fa8c9300
Status: Downloaded newer image for alpine:latest
/ # VERSION=1.4.0
wget -O /usr/local/bin/yaml-updater https://github.com/xvik/yaml-updater/releases/download/${VERSION}/yaml-updater-linux-amd64
Connecting to github.com (<IP_ADDRESS>:443)
Connecting to objects.githubusercontent.com (<IP_ADDRESS>:443)
saving to '/usr/local/bin/yaml-updater'
yaml-updater         100% |*******************************************| 4169k  0:00:00 ETA
'/usr/local/bin/yaml-updater' saved
/ # chmod +x /usr/local/bin/yaml-updater
/ # /usr/local/bin/yaml-updater --help
/ # echo $?
127

Additional Information:
/ # ls -l /usr/local/bin/yaml-updater
-rwxr-xr-x    1 root     root       4269512 Nov 29 17:41 /usr/local/bin/yaml-updater
/ # sha256sum /usr/local/bin/yaml-updater
c4a6496685220283fc999df30b22575a428d9343cf98553f5ccdbfe1f90eb1d4  /usr/local/bin/yaml-updater

and
/ # apk add file
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/x86_64/APKINDEX.tar.gz
(1/2) Installing libmagic (5.41-r0)
(2/2) Installing file (5.41-r0)
Executing busybox-1.34.1-r3.trigger
OK: 13 MiB in 16 packages
/ # file /usr/local/bin/yaml-updater
/usr/local/bin/yaml-updater: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), statically linked, no section header

Thank you very much for the info! I didn't think about alpine at all.
Native binaries require glibc, not available on alpine.
To verify I checked this image: https://hub.docker.com/r/frolvlad/alpine-glibc/ (which is alpine + glibc) where binary is working fine.
I also found that graalvm could create binaries without glibc requirement and I'll try to add an additional binary for that (need to read a bit more about all this).

Interesting, I thought with statically linked binaries, they didn't need glibc (shrug) ... I will adjust my "FROM" :)

using the image mentioned above works (forgot to come back and close this)...
FROM frolvlad/alpine-glibc:alpine-3.15

ARG VERSION=1.4.0

RUN wget -O /usr/local/bin/yaml-updater https://github.com/xvik/yaml-updater/releases/download/${VERSION}/yaml-updater-linux-amd64 \
  && chmod +x /usr/local/bin/yaml-updater

CMD ["/usr/local/bin/yaml-updater", "--help"]


Remove TransactionAuditor

This isn't used anywhere anymore.

Review app deployed to https://teaching-vacancies-review-pr-2960.london.cloudapps.digital


Kik Bot Geeking Suddenly Stopped working

Bot Info

SDK Platform:
SDK Version:
Active Channels:
Deployment Environment:

Issue Description

Code Example

Reproduction Steps

Expected Behavior

Actual Results

So no one understands why it's messed up?

Please fill out the template and provide your code.  you have given us no information to diagnose the issue


Manage scaffolding

Added Scaffolding for Backbone. We are also using RequireJS to load the javascript files. Added the Jasmine testing framework and added tests for the BaseView. Note that all views should extend BaseView as it provides some basic functions that all of our views will need. Also note that render is not called in initialize. This allows easier testing and allows more control over when a view is rendered.

@mamcderm-usgs  and @ayan-usgs feel free to review. Please do not merge as I need to move the Jenkins jobs and additional build steps are needed. I will be updating the README.md accordingly. So there will be at least one more commit in this pull request.


Splash-o-matic MPU Not Displaying

https://twitter.com/Puffles52/status/1116080258892095489

737eff897c0ea09ce4c8eed2b05b8a4861bf3b84 Fixes this.


Add aarch64 compatibility

This adds aarch64 compatiblity.
Didn't need to change much besides presenting the package as aarch64.
Another addition is the inclusion of shadow, in my quest to get the oracle-cloud-agent working I noticed that it refuses to install if groupadd is not in the PATH. Can remove if this is OOS for this PR.
thanks for creating this!

Awesome, thanks!


[252] patstat geocoding

Closes #252

Turned out to be a problem with the translate API server, nothing to do with us.
Closes #252


Sync eng/common directory with azure-sdk-tools for PR 1335

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1335  See eng/common workflow

/check-enforcer override

/check-enforcer override


Throw when doing import defer * of a module with no exports

@guybedford Is this fix better than #33?
Closes #19

Thanks for adding this, I have a weak preference for this form. Seems sensible to leave this one open to discussion?

I'm against. It hurts consistency. Edge cases, even when they're pointless and advisable not to write, should behave the same, as much as possible, as if there were no sharp edge. It simplifies semantics, tools relying on semantics, spec size and teaching. It also saves special cases in code generation scenarios.


[3.x] Skip script property in remote object property list

3.x version of #55530

Thanks!

Cherry-picked for 3.4.1.


typos Submit page

Thanks, and for correcting the actions. We should update to last version of aifolio... https://github.com/alshedivat/al-folio This probably requires some additional manipulations not to break down the site.


[stable/filebeat] bump filebeat to 6.4.2

Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign @davidkarlsen


Make PythonAPI error: CMakeLists.txt can't found

I got a error:
CMake Error: The source directory "E:/carla/Build/rpclib-src" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
-[install_rpclib]: [CMAKE ERROR] An error ocurred while executing the cmake.
-[install_rpclib]: [CMAKE ERROR] Possible causes:
-[install_rpclib]:                - Make sure "CMake" is installed.
-[install_rpclib]:                - Make sure it is available on your Windows "path".
-[install_rpclib]:                - CMake 3.9.0 or higher is required.
-[install_rpclib]: Exiting with error...

-[Setup]:
Ok, and error ocurred, don't panic!
We have different platforms where you can find some help :)

Make sure you have read the documentation:
http://carla.readthedocs.io/en/latest/how_to_build_on_windows/

If the problem persists, you can ask on our Github's "Building on Windows" issue:
https://github.com/carla-simulator/carla/issues/21

Or just use our Discord channel!
We'll be glad to help you there :)
https://discord.gg/42KJdRj
make: *** [setup] 错误 1

I try:
1.download zlib1.2.11
2.modify E:\carla\Util\InstallersWin\install_zlib.bat
but failed.
Who can help me?

anybody?

how do you solve this problem? i encounter this

I worked around the issue for two days. It turns out as a simple 'Git' issue. 'install_rpclib.bat' uses 'Git' to pull the rpclib repo.
echo git clone -b "%RPC_VERSION%" https://github.com/carla-simulator/rpclib.git "%RPC_SRC_DIR:~0,-1%"  call git clone -b "%RPC_VERSION%" https://github.com/carla-simulator/rpclib.git "%RPC_SRC_DIR:~0,-1%"

Deleting "E:/carla/Build/rpclib-src" and making again worked for me.

Hope this helps someone. I had the same issue with Carla 0.9.13 when I run make PythonAPI. I found out that in the install_zlib.bat line 51 is set ZLIB_VERSION=1.2.13
When the batch file tries to download, it doesnt find the file at www.zlib.net/zlib1.2.13.zip. I found (I think) the reason is the file doesnt exist. The name is different. At https://github.com/madler/zlib/releases/tag/v1.2.13 the file name is zlib1213.zip
So I downloaded that file from github and manually renamed it to zlib1.2.13.zip and saved it in carla/build. Then I ran make PythonAPI. Voila.


Don't disregard falsish query spec values.

Falsish values are valid and often useful!

This change is

Looks good to me. Are there any other places in the chain before this point (eg firetruss) where we might be filtering falsish values also?

No, I followed the chain to find this spot and everything else just passes through the spec as-is.


Get cookies with twig js

Hi,
I'm using twigjs on nodejs with express js
I need to get all the cookies of the page with a twig funtion:
//create twig functions
Twig.extendFunction("$_COOKIE", function(cookie) {
    // Stuff
});

But i don't know where to place it in my code because i need to get req parameter to get cookies:
req.cookies[cookie]
And i want for twig to access to this function on every template that i load in this code.
Thanks

document.cookie?

Twig.extendFunction("cookie", function(name) {
  let cookies = Object.fromEntries(document.cookie.split('; ').map(x => x.split('=')));
  return cookies[name]
})

{{ cookie('mycookie') }}

but if i added the httpOnly parameter to true when initializing the cookie??
I really need to set the httpOnly to true so that client cannot access to it with js.
It's a really important cookie and i don't want to let the user touch to it

Users will always have access to change their own cookies. You could encrypt it, but there's only so much you can do for user cookies. Can I close this issue?

Yes, i will close this issue. I found a simple way to access to users cookies on express:
app.use((req, res, next)=>{
  res.locals.cookies = req.cookies
  next()
})

and then i just access it with cookies in my twig template.
Hope that it can help someone


added tests for cypress

Description
changed flakey tests for workbench
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sumukhswamy should this backport to 2.x?

@sumukhswamy should this backport to 2.x?

Yes, backport as well!


WIP: Fix shippable java truststore issue

Summary of the changes / Why this improves CrateDB
Fix issue with java truststore on shippable runs:
Unexpected error: java.security.InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty
Checklist

[x] User relevant changes are recorded in CHANGES.txt
[ ] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed

Seems like this is an Ubuntu 16.04 ARM issue. Found no way to fix this atm.


[PIT] should not deprecate the dance and clean-frontend goal

with Vaadin 24.4.0.alpha3, when running mvn vaadin:dance/clean-frontent , i can see a warning about
[INFO] --- vaadin:24.4.0.alpha3:dance (default-cli) @ docs ---
[WARNING]  Goal 'dance' is deprecated: No reason given

or
[INFO] --- vaadin:24.4.0.alpha3:clean-frontend (default-cli) @ docs ---
[WARNING]  Goal 'clean-frontend' is deprecated: No reason given

this should not be deprecated.

this deprecation is from hilla-maven-plugin


compare query used by amy and in redash

to understand the difference in numbers seen (cf. #10 for more context).

Closing this because we aren't generating reports in AMY anymore


search: Adjust text in has: message suggestions.

This corrects message-search suggestions to use the plural form of, for example, "Messages with one or more links."
Screenshots and screen captures:
Before:

After:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @karlstolley!


Fix: Allow Email to re-render when data changes

This PR fixes https://github.com/silverstripe/silverstripe-framework/issues/9289

PHPUnit reporting 100% on the updated EmailTest.

@maxime-rainville Now targeted against the 4.7 branch


Ctrl-I broken when using LuaSnip

Everything used to work ok, but since today, ctrl-I(for navigating jumplist) does not work anymore.
LuaSnip seems to be the culprit since it works again when I disable it.
I also tried a fresh config of Neovim without any plugin : Ctrl-I works. Then I add LuaSnip and it does not work anymore : nothing happens when hitting <ctrl+i>
Executing ':verbose map ' shows no conflicting mapping.
And plugin has been updated.
NVIM v0.8.0-1210-gd367ed9b2
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Hmmm, no idea what that might be :/
For me this is working correctly, though.. Could you make a MWE?

With a fresh install of Neovim and only Lazy.nvim and Luasnip.nvim, I narrowed the problem : it happens if I assign keyboard shortcuts to<tab>
local ls = require("luasnip")

vim.keymap.set({ "i", "n"}, "<tab>", function()
  if ls.expand_or_jumpable() then
    ls.expand_or_jump()
  end
end, { silent = true })

If i change  to <s-tab> or <c-j> then I can navigate jumps again with <c-i>.
One solution would be to use other keys to navigate placeholders, but I am very used to doing it with <tab>

It's not an luasnip issue, for apps running in a terminal  tab and c-i are the same.
In insert mode type c-v to enable raw insert, then type c-i and you will see a tab inserted.

If you wanna make it work you need to move to a terminal supporting CSI u  like kitty or wezterm.

@L3MON4D3  I think this can be closed

Yes, right! Thanks :+1:


Whitelist profile in user model

As in the README.md, the profile will be returned if it exists. But it can't be created by default (unless one creates an specific route just to update an already created user).
I just added the 'profile' string to the UserModel whitelist so that it can be added to the superlogin.register params (on the client).

@EuAndreh thank you very much for the pull request. I apologize for taking so much time to respond!
I've been distracted by other projects lately and will likely resume work on the next release within the next couple weeks.

No problem =]

Done.

@EuAndreh I decided to reverse this since not all users will want profile whitelisted. You can do it manually if you want in the config object:
{
  userModel: {
    whitelist: ['profile']
  }
}

OK, thanks anyway.


Odd behavior with twin.macro import

Your Environment

Prettier version: 3.2.5
node version: 20.5.0
package manager<EMAIL_ADDRESS>IDE: VSCode

Describe the bug
twin.macro seems to bother the sort algorithm. This is what it does:
import { useState } from 'react'
import { ApolloError, useMutation } from '@apollo/client'

import 'twin.macro'

import { v4 as uuidv4 } from 'uuid'

To Reproduce
See above and config below.
Expected behavior
I expect this:
import { useState } from 'react'
import { ApolloError, useMutation } from '@apollo/client'
import 'twin.macro'
import { v4 as uuidv4 } from 'uuid'

Configuration File (cat .prettierrc, prettier.config.js, .prettier.js)
Here is the importOrder:
  importOrder: [
    '',
    '^react$',
    '<BUILT_IN_MODULES>',
    '<THIRD_PARTY_MODULES>',
    '^twin[.]macro$',
    '',
    '^@/',
    '^[.]',
  ],

@therealgilles -- import 'twin.macro' is a "Side-effect Import" which is dangerous for us to reorganize, regardless of your regex. As a result, your importOrder isn't doing what you would like it to do.
This plugin will not reorganize "side-effect" imports.

I'm not sure I understand. The plugin is re-organizing its placement by adding blank spacing around it. Why not provide a pragma for side-effect imports, or better allow exact matches in the import list?
I would expect this to work for instance:
  importOrder: [
    '',
    '^react$',
    '^twin.macro$',
    '<BUILT_IN_MODULES>',
    '<THIRD_PARTY_MODULES>',
    '',
    '^@/',
    '^[.]',
  ],

@therealgilles That's not a feature of this plugin. This plugin takes great care to be the least dangerous it can be, and reordering across side-effect imports could break many many projects -- Other import sorting plugins do offer that feature, this plugin chose not to. Making sure not to do so took a lot of code to get right, so that's a huge attractive factor for this plugin.
This is why we have the first bullet-point in the README:
https://github.com/IanVS/prettier-plugin-sort-imports/blob/135b6e55d710df32c3a23c7fe266a04e1eb0c2c1/README.md?plain=1#L7
A pragma to permit it would be pretty complex code.

Gotcha! Thanks for taking the time to explain. It is not a big deal anyway.

I am still surprised the plugin is adding blank lines around the side-effect import. Why is that?
Also for some reason, if I use // prettier-ignore, a semi-colon is added at the end of the import line, which seems unexpected.

@therealgilles when you have a side-effect import, we treat the block above the side-effect and the block below the side-effect as independent groups (that are each sorted according to importOrder).
Your importOrder config includes 2 blank lines (above the first group, and between the 3rd-party imports and the local imports). I could be wrong because it's been a year since my last dive into the code, but I believe that's why it's inserting the blank lines you're referencing.

The semi-colon is indeed unexpected given what I assume is your prettier config. For myself I always use semi-colons in my code -- it's likely we didn't test that case heavily, but I would have expected prettier to respect your settings.
I can tell you that this plugin doesn't directly manipulate semi-colons, we just manipulate Abstract-syntax-tree nodes, and allow babel/prettier to assemble the final output according to your configs e.g. indentation, line lengths, and semi-colons are all handled outside of this plugin.

Okay got it, I appreciate the detailed explanation, thank you.
I am thinking the semi-colon may come from another setting somewhere, or another formatter.

I ran a couple experiments and the addition of the semi-colon only happens when this plugin is enabled.

@therealgilles if you're still intersted, would you be willing to create a quick reproduction repo that we can look into?  I'm not familiar with twin.macro personally.


isort Module is Observed in /spotipy/*

I installed the isort module right beside the other dependencies. Now, isort is observed in /spotipy/*.py files. There is no big change in the main algorithm.

I'm contributing in Hacktoberfest challenge. Be sure that I'll make some essential changes in the project. I just need to add the "hacktoberfest" label in this PR.

Thanks.

Thanks for that. Please update the changelog :-)
Also, how does one use "isort"? is there a command we can use to sort imports in the future? could we add this as a CI check?

Thanks for reposing soon. I'm working on the logging side of the Spotipy now. (using the default script-based configurations)
Be sure, I'll update the changelog file.
I do guess it brings some troubles in using isort module in the CI services. I've worked on a lot of projects and used isort in order to sort the import lists but in some cases, it just failed in tests!! (e.g. you can take a look at this closed PR on IBM/lale)

I suggest you add the flake8 plugin instead of using isort. It helps you to verify if all import lists are sorted. Check flake8-isort module. (I've never worked with this tool and that why I have no idea about editing the lint section so I leave it on your own)
Thank you so much. :)

I've never worked with this tool and that why I have no idea about editing the lint section so I leave it on your own

You have to start sometime @lnxpy 😺
Your PR in its current state does not break anything so that's great, but it also doesn't add long-term value. Codebase changes should come with tests and changing the style of a codebase without adding an automatic rule is useful only temporarily because others won't follow it and soon, your initial sorting will be erased. You probably wouldn't like to open that same PR in a month, would you?
For your PR to get the value it deserves and be merged, it would need:

instructions for other contributors to do the same, so they don't have to look for it and we won't loose your initial investment (please don't do this),
even better, an automatic rule so that we don't need to worry about it ever again (please do this).

I suggest you add the flake8 plugin instead of using isort

I also agree that using the flake8-isort plugin is better than using isort itself, because we already use flake8. Please note that there is also https://pypi.org/project/flake8-import-order/, feel free to pick your favorite

Thanks @stephanebruckert,
I'm kinda confused now. :sweat_smile: Where should I sign? Is there any other file to change and submit these changes? (Because I've already changed the changelog file)

@lnxpy that's fine, what command did you run to sort the imports? please add that command to the following doc, so that next contributors know how to do it: https://github.com/plamere/spotipy/blob/master/CONTRIBUTING.md#lint and we can merge your PR

I've already worked on the logging system. I suppose to make another PR for those changes.
Thanks again. Such a long conversation!! :D

Yeah I just wanted to express how important it is to share your knowledge, which you did, so thank you. Looking forward to your next PR!


javascript Store and Store.Wap

The problem is related to this :
https://github.com/LoranKloeze/WhatsAllApp/issues/15
Whatsapp released new webpacks and the logic is changed.
I'm struggle to integrate this ui.js inside wapi.js
The ui.js javascript fetch app.xxxxxx.js/app2.xxxxx.js and estract the correct functions to invoke but it' a chrome extension. But it' really working :)
This in wapi.js:
webpackJsonp([], {"bcihgfbdeb": (x, y, z) => window.Store = z('"bcihgfbdeb"')}, "bcihgfbdeb");
webpackJsonp([], {"iaeeehaci": (x, y, z) => window.Store.Wap = z('"iaeeehaci"')}, "iaeeehaci");
is not more working :(
Attach the modified wapi.js where WLAPStore,WLAPWAPStore seem correctly setup because of logs:
"Checking for more messages, status LoggedIn"
but when I try to invoke one of this:
var nr = '31612345678';
WLAPStore.Presence.find( nr + '@c.us').then(function(d){
if (d.isOnline)
console.log('online ',nr ,d.isOnline);
else
console.log('offline ',nr ,d.isOnline);
});
WLAPStore.ProfilePicThumb.find(nr+'@c.us').then(function(d){
console.log(d.img);
}, function(e){
console.error(e);
});
The  resulting object has all properties null of undefined.
The code from ui.js as chrome extension works this way.
Attached the modied wapi.js
Any clue is appreciated
Michele
wapi.js.zip

Duplicate of #217

@kevinkit i think that issue is not duplicated. As i understand @michelelaporta says that some functions are not implemented anymore in the Store.Wap that we got using the actual solution and that really occurs, because some functions are distributed in others webpack elements, like queryExist function that is in the "dgfhfgbdeb" and not in the "iaeeehaci". Maybe the PR #242 will be necessary because we will need the reference of more "Wap" objects...
best.,

@michelelaporta can you confirm  @brunosoaresds comment?

As I understand webpacks ids changes when new api changes. As whatsapp changes api last week the functions need to be remapped. In this solution  app/app2.js are dynamically queried through regexp pattern. I already tested https://github.com/LoranKloeze/WhatsAllApp and it's really works.

@michelelaporta, the regex solution arenreally better than a hard coded I’d, but still think that the solution used by @alfred82santa in #242 is much better, because we can look into created objects in runtime level. Well, I think I’m wrong in my first understand of this issue. In that case it’s really duplicated, sorry :)

No problem community comparison  is always well come :+1:


Fixed major errors

Fixed error seq1 not defined. (Issue #25 )
Fixed error sentences2idx returns only 2 values (Issue #26 )

I was about to make the same pull request for these.  It would be great to accept these since I'm working on applying SIF to a clinical text similarity challenge so it would be great if this repo were functional.


[ZEPPELIN-4643]. Fail to start zeppelin server because zeppelin-interpreter-shaded is under lib

What is this PR for?
This PR just exclude zeppelin-interpreter-shaded from zeppelin-markdown in zeppelin-jupyter/pom.xml. So that we won't include it under lib when building zeppelin distribution.
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4643

How should this be tested?

Tested manaully

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I will merge it soon, not only because it is simple but also it fix the travis CI fail issue


Added #97  CreateTransactionFromDTO - MoasicAlias

Issue: #97
fixed bug in CreateTransactionFromDTO - MoasicAlias

Pull Request Test Coverage Report for Build 247

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 72.471%

Totals

Change from base Build 245:
0.7%

Covered Lines:
1053

Relevant Lines:
1315

💛  - Coveralls

Also Added address alias fixes


Vectorize Golden Camel so we can use it in many places

Please describe the feature that you want to propose
Currently, the golden camel 🐪 is a PNG based file, the idea is to have a vector version of it, so we can embed it on several places and more important, to reduce the file size.

Hola 👋

If you give me a few minutes I can help with this.
Am I OK assuming you need a SVG file that includes those gradients?
PS: Nice work on the new website. Looks very neat 🚀

Any help is very appreciated! Thanks for jumping in!

That would be beyond great, thanks a lot @d4n1b

Mmm... @lhein / @lordrip I noticed that the original logo has letters in it.
Do you want me to add "Kaoto" to the SVG as well? - ATM, I've only done the camel
Source code

vs
My SVG redesign

I love it. Having that Camel as SVG is already awesome. If you want to you could contribute a second SVG with the text.

What was the font used?

Bitstream Vera Sans Roman or similar


Refactor connnection pooling

need to move connection pool definition to app.js and make it a global connection pool instead of per load.
see
https://github.com/mysqljs/mysql/issues/889

this is done in dev


Match to names with underscores in Twitter handle fails

I have noticed that frequently the tool fails to find a match when it should because the bluesky handle is missing an underscore that exists in the Twitter handle version, for example:
foo_bar on Twitter does not match foobar on Bluesky (same person)
I assume the Bluesky doesn't allow underscores in handles.

Seems to work now.


fix: optimize filetree view perf

变动类型

[x] 代码风格优化

需求背景和解决方案
changelog

优化文件树渲染性能

Codecov Report

Merging #149 (b8a39d1) into main (58b0f50) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   59.43%   59.43%   -0.01%
==========================================
  Files        1180     1180
  Lines       72315    72315
  Branches    14956    14956
==========================================
- Hits        42979    42977       -2
- Misses      26734    26736       +2
  Partials     2602     2602

Impacted Files
Coverage Δ

packages/core-common/src/node/port.ts
43.93% <0.00%> (-3.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b0f50...b8a39d1. Read the comment docs.


Add an option in plugin settings to set the beginning of the week to either Monday or Sunday

Would it be possible to add an option in config to set the beginning of the week to either Monday or Sunday?
Originally posted by @samtwalker in https://github.com/YU000jp/logseq-plugin-show-weekday-and-week-number/discussions/99

Thank you for the quick response and work!   I have reloaded and tested, the top calendar (for 2 weeks) is not updating, and when I try to create future days to start the week (choosing Sunday) the week is not being set on that day for the correct week.  i.e. this week is 39th and next week (starting Sunday for me) would be week 40.  Let me know if I am missing something.

@samtwalker
In that case, set Week number calculation to "US format".
(It was a bug that the mini calendar was not changed when on ISO format.)

Perfect.  Thank you!


The link of weights seems unavailabe.

The weights link seems unavailable, could you please chech and update?

Hi @afountain, thanks for letting us know!. The weights can be found at https://huggingface.co/apardyl/AME/tree/main. I've replaced the link in README as well.


CLs without me in attention set are listed as "Needing Attention"

I have CLs without me in the attention set being listed as "Needing Attention". They are newly uploaded CLs without any reviewers. I do have "Only use Attention Set to judge required attention" set.
Unfortunately the example commits I have are all in a Google internal repo. I email you them directly. Thx!

I'm seeing this issue in the public chromium Gerrit and can reproduce it. I'm the owner of the CL, but when I'm not listed in the attention set they still show as needing my attention in the extension. At the current moment I'm actually in the attention set, but multiple hours went by earlier today where this issue was true.

Here's a screenshot showing where I'm not in the attention set, but the extension still lists the CL as needing my attention.

The extension only fetches the information from gerrit every five minutes and then caches the result. Is it possible that the attention set changed less than five minutes ago?

The README says:

On click, it also polls the server to display the popup (and refresh the badge).

So does that poll not invalidate the cache of the result?
Nonetheless, for the example in the screenshot, it's been over two hours of not being in the attention set and it still lists the CL as requiring attention.


NavigationAgent3D halts at first NavPoint

Godot version
4.1.3 Stable [f06b6836a]
System information
Godot v4.1.3.stable - macOS 14.1.0 - Vulkan (Forward+) - integrated Apple M2 Pro - Apple M2 Pro (12 Threads)
Issue description
The NavigationAgent3D traverses across the NavigationRegion3D to the first Navigation Point of the path but then stops. Calls to get_next_path_position() of the NavigationAgent3D class within _physics_process() do not seem to update to the next NavPoint resulting in the mesh/node remaining at Index 1.
Steps to reproduce
Run project, click Blue cylinder.
Minimal reproduction project
Group Dynamics.zip

The NavigationAgent3D needs to be a child of the CharacterBody3D node of your "police_player" scene and the movement script needs to use that node.
Currently the script points to some arbitrary placed NavigationAgent3D node that uses an unrelated Node3D parent which is not how things are supposed to be set up.
There are other bugs or things that are not correct in that project, like using _process() with a physics CharacterBody3D node that requires _physics_process().

Thanks @smix8. As you said; the issue was that the Agent needs to be a direct child of the CharacterBody3D node within the inherited scene; rather than a child of the linked scene.