Add sum function in meter system

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. NO
[x] Update the CHANGES log.

The MAL didn't implement the sum function and the E2E test of the previous #6388 actually falls into the avg function, causing all log_count_info is 1, this PR adds the real implementation of sum function and adjust the E2E test.

Test fails, labels missing

2021-02-24T12:37:06.7762470Z [ERROR]   ExpressionParsingTest.test:124
2021-02-24T12:37:06.7764030Z Expected: is <ExpressionParsingContext(samples=[foo], isHistogram=true, percentiles=[50, 99], aggregationLabels=[], scopeLabels=[rr], downsampling=LATEST, scopeType=SERVICE)>
2021-02-24T12:37:06.7766583Z      but: was <ExpressionParsingContext(samples=[foo], isHistogram=true, percentiles=[50, 99], aggregationLabels=[tt], scopeLabels=[rr], downsampling=LATEST, scopeType=SERVICE)>

Duplicated adding? The error log seems missing label. What do I miss?

Duplicated adding? The error log seems missing label. What do I miss?

It WAS missing, after I added them in the tests, it shows up multiple times because I added multi-aggregation-functions cases (e.g. xxx.avg(['a']).sum(['a']), causing aggregationLabels being ['a', 'a']

I am just being informed this change will cause a serious bug. The previous sum(with avg downsampling) is correct, such as calculating the disk usage, CPU etc. Then, the SampleFamily have 30%(for example), and 35% next time, then we really need 33% usage. Sum function with avg downsampling is widely used.

FYI @wankai123 @hanahmily


can't build sysbox-in-docker image. sysbox-runc binary not available

When creating a docker image for sysbox-in-docker with ubuntu-bionic, sysbox-runc binary is not found as it in the directory. If the binary is available, kindly tell me where it is. In the releases section i can only find the debian package.
Here is the output of running the make ubuntu-focal from the sysbox-in-docker directory.
** Building ubuntu-focal sysbox-in-docker image **

[+] Building 1.7s (18/18) FINISHED                                                                                docker:default
 => [internal] load build definition from Dockerfile.ubuntu-focal                                                                            0.0s
 => => transferring dockerfile: 2.80kB                                                                                0.0s
 => [internal] load metadata for docker.io/library/ubuntu:focal                                                                              1.6s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 2B                                                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 9.46kB                                                                                0.0s
 => [ 1/12] FROM docker.io/library/ubuntu:focal@sha256:874aca52f79ae5f8258faff03e10ce99ae836f6e7d2df6ecd3da5c1cad3a912b                      0.0s
 => => resolve docker.io/library/ubuntu:focal@sha256:874aca52f79ae5f8258faff03e10ce99ae836f6e7d2df6ecd3da5c1cad3a912b                        0.0s
 => CANCELED [ 5/12] ADD https://raw.githubusercontent.com/docker/docker-ce/master/components/cli/contrib/completion/bash/docker /etc/bash_  0.0s
 => CANCELED [ 6/12] ADD https://github.com/just-containers/s6-overlay/releases/download/v<IP_ADDRESS>/s6-overlay-amd64-installer /tmp/           0.0s
 => CACHED [ 2/12] RUN apt-get update     && apt-get install --no-install-recommends -y        apt-utils        ca-certificates        wget  0.0s
 => CACHED [ 3/12] RUN curl -fsSL https://get.docker.com -o get-docker.sh                                                                    0.0s
 => CACHED [ 4/12] RUN sh get-docker.sh                                                                                0.0s
 => CACHED [ 5/12] ADD https://raw.githubusercontent.com/docker/docker-ce/master/components/cli/contrib/completion/bash/docker /etc/bash_co  0.0s
 => CACHED [ 6/12] ADD https://github.com/just-containers/s6-overlay/releases/download/v<IP_ADDRESS>/s6-overlay-amd64-installer /tmp/             0.0s
 => CACHED [ 7/12] RUN chmod +x /tmp/s6-overlay-amd64-installer && /tmp/s6-overlay-amd64-installer /                                         0.0s
 => CACHED [ 8/12] COPY s6-services /etc/services.d/                                                                                0.0s
 => CACHED [ 9/12] COPY sysbox /etc/cont-init.d/                                                                                0.0s
 => CACHED [10/12] COPY sysbox-mgr /usr/bin/sysbox-mgr                                                                                0.0s
 => CACHED [11/12] COPY sysbox-fs /usr/bin/sysbox-fs                                                                                0.0s
 => ERROR [12/12] COPY sysbox-runc /usr/bin/sysbox-runc                                                                                0.0s
------
 > [12/12] COPY sysbox-runc /usr/bin/sysbox-runc:
------
Dockerfile.ubuntu-focal:76
--------------------
  74 |     COPY sysbox-mgr /usr/bin/sysbox-mgr
  75 |     COPY sysbox-fs /usr/bin/sysbox-fs
  76 | >>> COPY sysbox-runc /usr/bin/sysbox-runc
  77 |
  78 |     ENTRYPOINT ["/init"]
--------------------
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref ab1fbcd0-8ffd-423c-b6c1-2d1fa516c807::vq3w13xh9mqidlge10452i7k4: "/sysbox-runc": not found
make: *** [Makefile:102: ubuntu-focal] Error 1

If i try to pull nestybox/sysbox-in-docker from docker hub or ghcr.io, i can't probably because it doesn't exist there... can anyone please tell how can i do this??

From a previous commit I can see that these files were deliberately added to .gitignore which means that they are available somewhere... This commit is 4 years old.

managed to get it working here

Hi @ghost, apologies for the belated response.
Unfortunately Sysbox-in-Docker hasn't been maintained in a while, so it's currently not working. We will likely deprecate it.
For an example of how to run Sysbox in Docker, refer to the Sysbox test container (e.g., tests/Dockerfile.ubuntu-jammy) and how it's launched by the Sysbox Makefile (see Makefile target test-shell).


Add TAA documentation

Yes, I simply did a copy/paste of my Medium blog post, and Medium converts the pictures in webp format :).


refactor(db/schema): store documentation of fields alongside code

Summary
Supersedes #10706
Supersedes https://github.com/Kong/kong/pull/10150
This PR is designed to streamline our documentation process for all configurable fields within Kong, by positioning the documentation closer to their respective definitions. This strategic placement facilitates automatic generation of updated documentation, eliminating the need for multiple location updates.
At this point, I didn't mark the description field required = true, in order to prevent potential conflicts when transitioning to EE. Instead, we should approach this as an iterative process, only making description fields mandatory once we are confident of their completeness.
Co-authored-by: Angel Guarisma<EMAIL_ADDRESS>Checklist
~- [ ] The Pull Request has tests~
~- [ ] There's an entry in the CHANGELOG~
~- [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE~
Full changelog

adding description fields to all configurable fields.

Issue reference
https://konghq.atlassian.net/browse/KAG-475

@jschmid1 Please rebase.

@chronolaw Can you please fix the failing test?

@hbagdi @kikito @jschmid1 Can we merge this?

This PR may introduce bug to EE, considering the EE schemas usually have different field attributes. Need careful cherry-pick.


Out of curiosity.. Will the dynamic css class names change after leetcode re-deployment?

Great work on this project.  👍
Might not be an issue, but I was looking at the source code and found references to dynamic css class names which seems to be generated by React Framework.
For example:
// Problem difficulty, each problem difficulty has its own class.
  const isHard = document.getElementsByClassName('css-t42afm');
  const isMedium = document.getElementsByClassName('css-dcmtd5');
  const isEasy = document.getElementsByClassName('css-14oi08n');

My guess is that these will change whenever leetcode does a rebuild of their webpack bundle.
I think this might need to be handled in a different manner. What do you think?

My thoughts too. I also noticed the use of data-cy attributes in multiple elements (typically used when cypress is used for testing). We might have to use css selectors in a more robust way. Like for example:
  const questionType = document.querySelector('[data-cy="question-title"] + div div');
  console.log(questionType.innerText);
  // output will be Hard, Medium or Easy

My thoughts too. I also noticed the use of data-cy attributes in multiple elements (typically used when cypress is used for testing). We might have to use css selectors in a more robust way. Like for example:
  const questionType = document.querySelector('[data-cy="question-title"] + div div');
  console.log(questionType.innerText);
  // output will be Hard, Medium or Easy

interesting @madhur. i've never used react so i'm not familiar with dynamic css. @rbajaj1997 could you open a PR to replace current class names? i'll merge it later.

interesting @madhur. i've never used react so i'm not familiar with dynamic css. @rbajaj1997 could you open a PR to replace current class names? i'll merge it later.

@QasimWani  I may not find time to implement it. Although, I can help in getting the generic CSS selectors. Btw, amazing idea and great work on this project!

@QasimWani  I may not find time to implement it. Although, I can help in getting the generic CSS selectors. Btw, amazing idea and great work on this project!

sure. closing for now.

sure. closing for now.


update readme

增加了英文版说明

Codecov Report

Merging #27 (cfa82b5) into main (5b3ea1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   59.90%   59.90%
=======================================
  Files          93       93
  Lines       22297    22297
  Branches     3638     3638
=======================================
  Hits        13357    13357
  Misses       5829     5829
  Partials     3111     3111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b3ea1b...cfa82b5. Read the comment docs.

太赞了，我们刚好有英文版说明的计划。
我review了一下，似乎没有写完整，确定是否需要merge这个pr？


Cache busting and Improve asset generation

Need to cache-bust with filename hash instead of query string.

Create a flexible script pipeline via https://darthmall.net/weblog/eleventy-asset-pipeline/ and add hash to the name of every possible bundle file (main + lab experiments)
or
Do some filter magic and add it only for the main bundle file.

Solved in #25


Consider storing output of add-view, refresh-views and field-counts

I'm thinking we could store a copy of these commands' standard output to a file (e.g. ~/kingfisher-views-logs/COMMAND-SCHEMA_NAME.log), so that we can manually read them for their timing information, and find slow steps/queries.
There are certainly more complicated alternatives (e.g. having a structured database of timing information and an analysis dashboard), but this seems like a fairly easy change that is good enough (just change the logger's configuration to write a file as well as print to standard output).
This would help identify slow steps like in #92.
We also shouldn't worry about the fact that, if a user re-runs a command for the same schema, then the log file is overwritten, because the timing information will be similar in both runs and we're just aiming to have a sample, not have a comprehensive logging system.

 Store outputs of add-view, refresh-views and field-counts

Views already uses logzero - it should be pretty easy to set that up so output is logged to a file as well as the screen. This should be a small job to do.

See #79 for question about why we can't just use the plain Python logging module.

Have deployed and done pull request for docs.
Logging currently goes into exactly same place as other kingfisher logs; in the absence of any user stories that that system has issues, it seemed easiest to use existing system.

Now goes to /var/log/kingfisher-views.log

Closed by #140.


Registration doesn't work on Android, verifyAttestation AndroidSafetyNet fail

First, thank you very much for your project.
I cant register my Google pixel on android 12. I get this error :
Attestation alg "-257" did not match metadata auth algs [-7] (SafetyNet).
All is ok with keys or Window Hello.
Registration parameters are :
  rp: { name: 'masked', id: 'masked' },
  user: {
    id: 'masked',
    name: masked',
   },
  pubKeyCredParams: [
    { alg: -7, type: 'public-key' },
    { alg: -257, type: 'public-key' }
   ],
  timeout: 60000,
  attestation: 'direct',
  authenticatorSelection: {
   userVerification: 'required',
   requireResidentKey: false
 }
extensions: { credProps: true, uvm: true }

Than you for your help
Best regards
Bruno.

Can you confirm that you're leveraging MetadataService in your RP? And can you please include the response returned from startRegistration() so I can see the authenticator's aaguid? If you drop the response into https://debugger.simplewebauthn.dev/ it'll be easy to see and you can easily link it here.
Based on the error I'd guess Android chose to sign the response with RS256 (-257), but FIDO metadata for Android says that it should have only used ES256 (-7). If that's the case then the issue is with Android and/or the FIDO metadata service 🤔

Thank you for your quick answer.
Yes, i use MetadataService.
Here is a part of attestation :  (I don't paste all because i am not sure what is private)
"attestationObject": {
      "fmt": "android-safetynet",
      "attStmt": {
        "response": {
          "header": {
            "alg": "RS256",
---------
"authData": {
        "rpIdHash": "-------------------------------------------",
        "flags": {
          "userPresent": true,
          "userVerified": true,
          "attestedData": true,
          "extensionData": false
        },
        "counter": 0,
        "aaguid": "b93fd961-f2e6-462f-b122-82002247de78",
        "credentialID": "------------------------------------------------------",
        "credentialPublicKey": "------------------------------------------------------",
        "parsedCredentialPublicKey": {
          "keyType": "EC2 (2)",
          "algorithm": "ES256 (-7)",
          "curve": 1,
          "x": "---------------------------------------------------------------",
          "y": "---------------------------------------------------------------"
        }
      }

It seems you are right..

That's incredibly odd. The only place you ever see RS256 normally is Windows Hello.

Yeah, this is a weird one. My gut tells me without metadata the registration response would have validated just fine. But since you're enforcing the greater authenticator scrutiny via FIDO MDS you'll have situations like this that require you to decide how to proceed...I can't say what the "best" thing is to do here because it really comes down to your application's security model.

I think the thing here is the attestation can be signed with RS256, but the authenticator signature is supposed to be Es256...the MDS entry is about the authenticator signature, not the attestation statement. Just my from the hip observation.

I suspect this might be a legitimate issue with server, then. I'm probably naively comparing against the metadata the attestation statement algorithm, not the authenticator signature. I'll dig deeper into the code tonight and see if something doesn't jump out at me that I can fix.

@bricous I think you've reported a legitimate issue with @simplewebauthn/server. Looking at how I implemented metadata checks, specifically verifyAttestationWithMetadata() I'm always comparing the attestation statement's alg (or equivalent, for example HEADER.alg for "android-safetynet") against the authenticationAlgorithms present in a matching metadata statement.
As @aseigler pointed out authenticationAlgorithms should be compared against the hashing algorithm I use when I call verifySignature(). In most cases this means SHA256, as that's what verifySignature() defaults to. But I'll have to look more into this tomorrow because it's not obvious what I'm part of the registration response I'm supposed to compare instead to pass a value like -7 to match an algorithm ID included in a metadata statement.

Sorry to be so boring...
I unplugged Metadataservice  as suggested, but now verifyRegistrationResponse -> Object.verifyAttestationAndroidSafetyNet throws this :
Error: Intermediate certificate is not yet valid or expired (SafetyNet)

I succeded ! to register with my Pixel but attestationType has to be  'none'. If 'direct' or indirect it fails.

@bricous Can you provide a full registration response when you get the "Error: Intermediate certificate is not yet valid or expired (SafetyNet)" error? There's nothing in there that will compromise your identity in any way, maintaining user privacy is one of the core tenets of WebAuthn, and I can't do anything with a credential anyway since it'll be bound to the origin you register it on!
I want that response, though, because I'm wondering why an intermediate certificate may be invalid. I'm having a hard time believing Android is producing expired intermediate certs...it may actually be the case that the GlobalSign R2 root cert finally expired and it's time to remove it from the library.

Can you try something for me? When you're initializing your server can you set up SettingsService with just the GlobalSign_Root_CA cert (the cert isn't exported in a convenient way so I just copy-pasted it into the code sample)?
import { SettingsService } from '@simplewebauthn/server';

/**
 * GlobalSign Root CA
 *
 * Downloaded from https://pki.goog/roots.pem
 *
 * Valid until 2028-01-28 @ 04:00 PST
 *
 * SHA256 Fingerprint
 * EB:D4:10:40:E4:BB:3E:C7:42:C9:E3:81:D3:1E:F2:A4:1A:48:B6:68:5C:96:E7:CE:F3:C1:DF:6C:D4:33:1C:99
 */
const GlobalSign_Root_CA = `-----BEGIN CERTIFICATE-----
MIIDdTCCAl2gAwIBAgILBAAAAAABFUtaw5QwDQYJKoZIhvcNAQEFBQAwVzELMAkG
A1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYtc2ExEDAOBgNVBAsTB1Jv
b3QgQ0ExGzAZBgNVBAMTEkdsb2JhbFNpZ24gUm9vdCBDQTAeFw05ODA5MDExMjAw
MDBaFw0yODAxMjgxMjAwMDBaMFcxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9i
YWxTaWduIG52LXNhMRAwDgYDVQQLEwdSb290IENBMRswGQYDVQQDExJHbG9iYWxT
aWduIFJvb3QgQ0EwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDaDuaZ
jc6j40+Kfvvxi4Mla+pIH/EqsLmVEQS98GPR4mdmzxzdzxtIK+6NiY6arymAZavp
xy0Sy6scTHAHoT0KMM0VjU/43dSMUBUc71DuxC73/OlS8pF94G3VNTCOXkNz8kHp
1Wrjsok6Vjk4bwY8iGlbKk3Fp1S4bInMm/k8yuX9ifUSPJJ4ltbcdG6TRGHRjcdG
snUOhugZitVtbNV4FpWi6cgKOOvyJBNPc1STE4U6G7weNLWLBYy5d4ux2x8gkasJ
U26Qzns3dLlwR5EiUWMWea6xrkEmCMgZK9FGqkjWZCrXgzT/LCrBbBlDSgeF59N8
9iFo7+ryUp9/k5DPAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E
BTADAQH/MB0GA1UdDgQWBBRge2YaRQ2XyolQL30EzTSo//z9SzANBgkqhkiG9w0B
AQUFAAOCAQEA1nPnfE920I2/7LqivjTFKDK1fPxsnCwrvQmeU79rXqoRSLblCKOz
yj1hTdNGCbM+w6DjY1Ub8rrvrTnhQ7k4o+YviiY776BQVvnGCv04zcQLcFGUl5gE
38NflNUVyRRBnMRddWQVDf9VMOyGj/8N7yy5Y0b2qvzfvGn9LhJIZJrglfCm7ymP
AbEVtQwdpf5pLGkkeB6zpxxxYu7KyJesF12KwvhHhm4qxFYxldBniYUr+WymXUad
DKqC5JlR3XC321Y9YeRq4VzW9v493kHMB65jUr9TU/Qr6cf9tveCX4XSQRjbgbME
HMUfpIBvFSDJ3gyICh3WZlXi/EjJKSZp4A==
-----END CERTIFICATE-----
`;

SettingsService.setRootCertificates({
  identifier: 'android-safetynet',
  certificates: [GlobalSign_Root_CA],
});

And then try registering again with attestation: 'direct' set so it generated an attestation statement. This'll confirm a hunch that it might actually be the expired GlobalSign R2 cert that's causing registration verification to fail.

After adding GlobalSign_Root_CA cert, i can register with attestation: 'direct'. Bravo!

Alright, then I can fix this with a couple of changes to server:

Remove the expired GlobalSign R2
Update validateCertificatePath() to change the error message slightly to better communicate when there's an error with a root certificate

Oh wait, I can't also forget the metadata-related changes I need to make too:

Calls to verifyAttestationWithMetadata() should not use the attestation statement algorithm ID, but one corresponding to the hash algorithm used for the authenticator signature

@bricous Just to follow up, I've merged fixes for the first two bullet points above, and I've identified and am working on a fix for the third bullet point. The solution to the third bullet point in particular will fix the original issue that prompted you to create this issue. None of it is available yet - they'll all go out as<EMAIL_ADDRESS>when I get the third fix merged.

@bricous Good news! I just published<EMAIL_ADDRESS>with all of the fixes above! Your Android device should now be able to complete attestation: 'direct' registration with MetadataService initialized!


Update swagger-ui-bundle or vendor it

Description
The package swagger-ui-bundle wasn't updated in a long time and uses and outdated Swagger UI version. While there are pull requests to update the package, the maintainer did not update anything.
Expected behaviour
Have the latest and greatest Swagger UI available.
Actual behaviour
Have an outdated UI which i.e. can't correctly render definitions containing oneOf statements.
Steps to reproduce
Have a definition with a oneOf in it and the result will look like the following:

Additional info:
Output of the commands:

python --version
pip show connexion | grep "^Version\:"

Unrelated since it's an external package.

Thanks for the report @aparcar.
@dtkav do you have some time to look at the open PRs on the repo?

Maybe this helps https://github.com/dtkav/swagger_ui_bundle/pull/19

Dropping 2.x would be an issue for connexion @aparcar.

Dropping 2.x would be an issue for connexion @aparcar.

Okay I reworked the PR to only update to 3.52.0

I would be interested in using a more recent Swagger UI as well.
Note that older Swagger UI versions (that are part of the currently used bundle) contain security vulnerabilities, e.g. https://nvd.nist.gov/vuln/detail/CVE-2018-25031
Thanks a lot!

Perhaps one of the other swagger-ui packages could be used: https://www.google.com/search?client=firefox-b-d&q="swagger-ui"+site%3Apypi.org ?


spec: remove marketing buzzwords from description

Signed-off-by: Jan Engelhardt<EMAIL_ADDRESS>

While I don't see a big benefit in this change I don't oppose to it. In any case Kubernetes' motto is Production-Grade Container Orchestration.

@jengelh feel free to reoepen a PR for this, somehow our ci got stuck on this pr


Design Meeting Notes, 6/18/2020

Variadic Tuples
https://github.com/microsoft/TypeScript/pull/39094
Added the ability to add a "cut point" to inference to accurately describe curry.
function curry<T extends unknown[], U extends unknown[], R>(
    f: (...args: [...T, ...U]) => R,
    ...a: T
)

This is complicated! Why?

You want to get the count from ...a to know how much to cut off from [...T, ...U]`
You want ...a to be contextually typed by whatever it could be inferred from ...args
So we now try to build up a concept of "implied arity" from these positions during the inference process.

There are some limitations around inference in certain more complex cases.
function independent<T extends unknown[], R>(
    ...args: [...T, (...a: T) => R]
): [T, R];

Works well for
[fixed-part, ...rest-part]

but not
[starting-fixed-part, ...rest-part, ending-fixed-part]
[...rest-part, fixed-part]

but...we think we could! Then we could model
declare const foo: string[];

independent(...foo, (...args) => hello)

What about pipe?

Common, but is very complicated to type without pyramids of overloads.
There's also compose which is more right to left, which we couldn't do.
Wasn't within scope for this PR.
Maybe potential in the future, but also, maybe |> is the better solution.

We had some questions about applying mapped type transformations across different places.

Turns out that we don't encode the right information to say that when constrained to a union of array/tuple types, a homomorphic mapped type will also be array/tuple-like.
Instead, we just assume that the thing is more plain object-like than array-like.

Basically the same as behavior of mapped types on arrays before they were special-cased in around TS2.9ish.

Spreading anyTypeExpr && otherExpr into Objects
https://github.com/microsoft/TypeScript/issues/39113
function fn(x: unknown) {
    const res = {
        // uh oh!
        // 'prop' is specified more than once, so this usage will be overwritten.
        prop: 100,
        // This spread always overwrites this property.
        ...(x && { prop: 200 }),
    };
}

Strange:
let x: string = (false as unknown) && "hello"; // okay
let y: string = (0 as number) && "hello"; // error

Conclusion: Try changing this behavior and see what breaks, but it sounds very breaky.
Switch to ES Maps and Sets
https://github.com/microsoft/TypeScript/pull/33771

Internally we have a Map type, have logic that uses the native ES Map type if available.
But the problem is, because our polyfill only worked on strings keys, our Map was limited like that all-around.
Will switch to having K, V.
WeakMap?

Not if we can help it, avoid using in compiler.

What about breaking change?

Very esoteric use-sites in our API.

Conclusion: Try the change in beta, work with build tool authors to see impact.

Out of time
Base tsconfigs
https://github.com/tsconfig/bases/pull/15
Abstract Constructor Types
https://github.com/microsoft/TypeScript/pull/36392

The best way to implement pipe without of overload pyramids is #38182. But as I see, nobody still really interested in this.


"in your Android and iOS build settings" does not say how to get there.

How do I find Android and iOS build settings? I have to do a separate internet search to look that up.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b74184fd-ca8a-11fa-ed37-91235fc59401
Version Independent ID: 87f197b8-20c6-4825-18e4-86562bb2523c
Content: XAML Hot Reload for Xamarin.Forms - Xamarin
Content Source: docs/xamarin-forms/xaml/hot-reload.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @maddymontaquila
Microsoft Alias: maleger

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and it's documentation can be found here.


Make validation for route destination more consistent

keep route destination validation consistent for http/tcp

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e178ff3b3462a2a89bc379ab909136c4f2fbe0ad
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
e178ff3b3462a2a89bc379ab909136c4f2fbe0ad
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
fb7d8ff97293d85552ce38ee550051bb35a10c9d
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
fb7d8ff97293d85552ce38ee550051bb35a10c9d
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We also need some handling on the Envoy side. See the validation rule below. Also, what would be the behavior when multiple 0 weighted destinations are added? We need to make sure that Envoy can handle this, and also document about the choice of destination for this specific case.
https://github.com/envoyproxy/envoy/blob/10625c596325c2bdfea47e3063161aa5edec495f/api/envoy/config/filter/network/tcp_proxy/v2/tcp_proxy.proto#L161

/test e2e-bookInfoTests-envoyv2-v1alpha3

@venilnoronha we ignore 0 weights in Pilot..

So I need do some check in buildOutboundNetworkFiltersWithWeightedClusters

/remove stale

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu,rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test istio-unit-tests

prow/e2e-mixer-no_auth.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test e2e-mixer-no_auth

prow/istio-pilot-multicluster-e2e.sh
3f65cb0a48e7ca537b0fbff6051cb99597c59f0c
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add LongAP Pro using ATECC608

There will be multiple security chips used by LongAP Pro, so we have to be specific per security chip

There will be multiple security chips used by LongAP Pro, so we have to be specific per security chip

I'd propose you add specific model numbers/names for each hardware variant/skew?

Closing PR as adding hotspots to the README just for DeWi auditing purposes is no longer required.


Question about conversion to KITTI format parameters

Hi all,
I am having difficulty determining the following arguments that need to be passed to the data2kitti.py script:
--category-limit < Category Limit for Masked and No-Mask Faces >
--tlt-input-dims_width < tlt input width >
--tlt-input-dims_height
--train < for generating training dataset >
Could you please provide more explanation with an example maybe?
Thank you for your help.

More explanation about these parameters can be found in the file argparser_data2kitti.py


🐛 Bug Report: Redundant Scrollbars in TechDocs on macOS Chrome and Firefox

📜 Description
I'm not sure if this affects other operating systems, but in Chrome and Firefox on macOS there are redundant scrollbars for each sidebar on a TechDocs page.
👍 Expected behavior
Safari seems to render correctly:

Note the lack of a scrollbar on the left sidebar and only a single scrollbar on the right side for the Table of contents.
👎 Actual Behavior with Screenshots
In Firefox:

In Chrome (with light mode):

To clarify, the issue happens in both dark and light mode on both browsers.
Note the unnecessary scrollbar on the left sidebar, as well as the right sidebar having two scrollbars (only one of which does anything useful).
Also the real scrollbar appears to be styled incorrectly in the dark theme; see the right sidebar's scrollbar.
👟 Reproduction steps

Generate a basic TechDocs site with 1 or more pages as well as a page with multiple headings.

seq 1 10 | parallel -q mkdir -p 'docs/Sub {}'
seq 1 10 | parallel -q touch 'docs/Sub {}/index.md'
cat << EOF > docs/index.md
# Example Docs page

## H2 - 1
### H3 - 1
#### H4
### H3 - 2
### H3 - 3
### H3 - 4
### H3 - 5
## H2 - 1
### H3 - 1
#### H4
### H3 - 2
### H3 - 3
### H3 - 4
### H3 - 5
### H3 - 6
## H2 - 1
### H3 - 1
#### H4
### H3 - 2
### H3 - 3
### H3 - 4
### H3 - 5
### H3 - 6
## H2 - 1
### H3 - 1
#### H4
### H3 - 2
### H3 - 3
### H3 - 4
### H3 - 5
### H3 - 6
### H3 - 6
EOF

Configure Backstage with what's needed to build and render the site

# catalog-info.yaml
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  name: scrollbars-why
  annotations:
    backstage.io/techdocs/ref: dir:.
spec:
  type: service
  owner: guest
  lifecycle: experimental

# app-config.local.yaml
techdocs:
  builder: local
  publisher:
    type: local
  generator:
    runIn: local

📃 Provide the context for the Bug.
I played around a bit but couldn't figure out a proper fix without a lot of extra work since there's no good way to "monkeypatch" the CSS the techdocs plugin injects. But I think the fix is to just set overflow-y: visible; on .md-sidebar__scrollwrap. If you make that change via the browser's devtools it fixes the issue.
As for the scrollbar styling with the dark theme, technically that's a different issue, but unsetting scrollbar-color in .md-sidebar makes it look less bad.
🖥 Your Environment
Firefox 122.0 and Chrome 121.0.6167.139
$ yarn backstage-cli info
OS:   Darwin 23.3.0 - darwin/arm64
node: v18.19.0
yarn: 3.7.0
cli:  0.25.0 (installed)
backstage:  1.21.1

Dependencies:
  @backstage/app-defaults                                          1.4.6
  @backstage/backend-app-api                                       0.5.9
  @backstage/backend-common                                        0.19.9, 0.20.0
  @backstage/backend-dev-utils                                     0.1.2
  @backstage/backend-openapi-utils                                 0.1.1
  @backstage/backend-plugin-api                                    0.6.8
  @backstage/backend-tasks                                         0.5.13
  @backstage/catalog-client                                        1.5.1
  @backstage/catalog-model                                         1.4.3
  @backstage/cli-common                                            0.1.13
  @backstage/cli-node                                              0.2.1
  @backstage/cli                                                   0.24.0, 0.25.0
  @backstage/config-loader                                         1.6.0
  @backstage/config                                                1.1.1
  @backstage/core-app-api                                          1.11.2
  @backstage/core-compat-api                                       0.1.0
  @backstage/core-components                                       0.13.9
  @backstage/core-plugin-api                                       1.8.1
  @backstage/dev-utils                                             1.0.25
  @backstage/e2e-test-utils                                        0.1.0
  @backstage/errors                                                1.2.3
  @backstage/eslint-plugin                                         0.1.4
  @backstage/frontend-plugin-api                                   0.4.0
  @backstage/integration-aws-node                                  0.1.8
  @backstage/integration-react                                     1.1.22
  @backstage/integration                                           1.8.0
  @backstage/plugin-api-docs                                       0.10.2
  @backstage/plugin-app-backend                                    0.3.56
  @backstage/plugin-app-node                                       0.1.8
  @backstage/plugin-auth-backend-module-atlassian-provider         0.1.0
  @backstage/plugin-auth-backend-module-gcp-iap-provider           0.2.2
  @backstage/plugin-auth-backend-module-github-provider            0.1.5
  @backstage/plugin-auth-backend-module-gitlab-provider            0.1.5
  @backstage/plugin-auth-backend-module-google-provider            0.1.5
  @backstage/plugin-auth-backend-module-oauth2-provider            0.1.5
  @backstage/plugin-auth-backend-module-oauth2-proxy-provider      0.1.0
  @backstage/plugin-auth-backend-module-okta-provider              0.0.1
  @backstage/plugin-auth-backend                                   0.20.2
  @backstage/plugin-auth-node                                      0.4.2
  @backstage/plugin-catalog-backend-module-scaffolder-entity-model 0.1.5
  @backstage/plugin-catalog-backend-module-unprocessed             0.3.5
  @backstage/plugin-catalog-backend                                1.16.0
  @backstage/plugin-catalog-common                                 1.0.19
  @backstage/plugin-catalog-graph                                  0.3.2
  @backstage/plugin-catalog-import                                 0.10.4
  @backstage/plugin-catalog-node                                   1.6.0
  @backstage/plugin-catalog-react                                  1.9.2
  @backstage/plugin-catalog-unprocessed-entities                   0.1.6
  @backstage/plugin-catalog                                        1.16.0
  @backstage/plugin-devtools-backend                               0.2.5
  @backstage/plugin-devtools-common                                0.1.7
  @backstage/plugin-devtools                                       0.1.7
  @backstage/plugin-events-node                                    0.2.17
  @backstage/plugin-github-actions                                 0.6.9
  @backstage/plugin-home-react                                     0.1.6
  @backstage/plugin-org                                            0.6.18
  @backstage/plugin-pagerduty                                      0.7.0
  @backstage/plugin-permission-common                              0.7.11
  @backstage/plugin-permission-node                                0.7.19
  @backstage/plugin-permission-react                               0.4.18
  @backstage/plugin-proxy-backend                                  0.4.6
  @backstage/plugin-scaffolder-backend-module-azure                0.1.0
  @backstage/plugin-scaffolder-backend-module-bitbucket            0.1.0
  @backstage/plugin-scaffolder-backend-module-gerrit               0.1.0
  @backstage/plugin-scaffolder-backend-module-github               0.1.0
  @backstage/plugin-scaffolder-backend-module-gitlab               0.2.11
  @backstage/plugin-scaffolder-backend                             1.19.2
  @backstage/plugin-scaffolder-common                              1.4.4
  @backstage/plugin-scaffolder-node                                0.2.9
  @backstage/plugin-scaffolder-react                               1.7.0
  @backstage/plugin-scaffolder                                     1.17.0
  @backstage/plugin-search-backend-module-catalog                  0.1.12
  @backstage/plugin-search-backend-module-pg                       0.5.17
  @backstage/plugin-search-backend-module-techdocs                 0.1.12
  @backstage/plugin-search-backend-node                            1.2.12
  @backstage/plugin-search-backend                                 1.4.8
  @backstage/plugin-search-common                                  1.2.9
  @backstage/plugin-search-react                                   1.7.4
  @backstage/plugin-search                                         1.4.4
  @backstage/plugin-tech-radar                                     0.6.11
  @backstage/plugin-techdocs-backend                               1.9.1
  @backstage/plugin-techdocs-module-addons-contrib                 1.1.3
  @backstage/plugin-techdocs-node                                  1.11.0
  @backstage/plugin-techdocs-react                                 1.1.14
  @backstage/plugin-techdocs                                       1.9.2
  @backstage/plugin-user-settings                                  0.7.14
  @backstage/release-manifests                                     0.0.11
  @backstage/test-utils                                            1.4.6
  @backstage/theme                                                 0.4.4, 0.5.0
  @backstage/types                                                 1.1.1
  @backstage/version-bridge                                        1.0.7

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

The issue is visible on the demo site: https://demo.backstage.io/catalog/default/component/backstage/docs

Here is my closed issue from -22: https://github.com/backstage/backstage/issues/13717

@sapslaj thanks for filing this! our team would love for this to be improved for better usability in techdocs. We'd love to see this fixed upstream from us, and are happy to support this if we can be at all helpful!

A work-around for the double scrollbars:
packages/app/src/App.css:

/* TechDoc overflow fix */
#root > div > main > article > div > main {
  overflow-y: visible;
  height: 100%;
}

/* TechDoc padding fix */
#root > div > main > article > div > main > article,
#root > div > main > article > div > main > div {
  padding: 0;
}

I might have a hint on where this issue is coming from for the doc navigation and ToC. There's a negative bottom margin on the nav for those. When I disable it in the dev console the problem goes away (Firefox on Mac)

Let's see, whether the change done in the following PR fix the issue:

backstage/backstage#23420

I'm experiencing this with Chrome and Edge. Here's an example with Edge:

This is caused by this line in the page component:
https://github.com/backstage/backstage/blob/4935ebd06fca77679629b289b9ac511c5191a25e/packages/core-components/src/layout/Page/Page.tsx#L31
Which is called by the TechdocsReaderPage:
https://github.com/backstage/backstage/blob/4935ebd06fca77679629b289b9ac511c5191a25e/plugins/techdocs/src/reader/components/TechDocsReaderPage/TechDocsReaderPage.tsx#L196
Perhaps this should be changed to minheight? That fixes it if I change it in devtools.

Just bumping this as it's still being reported repeatedly by our users as frustrating!

I concur. We're just beginning our TechDocs rollout and we're already seeing this behavior. Consumer feedback has not been positive with the duplicative scrollbars.

While a real fix is needed, to make your users happy, you can work around it by adding the following to your App.css:
`/* TechDoc overflow fix */
#root > div > main > article > div > main {
overflow-y: visible;
height: 100%;
}
/* TechDoc padding fix */
#root > div > main > article > div > main > article,
#root > div > main > article > div > main > div {
padding: 0;
}
`

While a real fix is needed, to make your users happy, you can work around it by adding the following to your App.css:
/* TechDoc overflow fix */
#root > div > main > article > div > main {
  overflow-y: visible;
  height: 100%;
}

/* TechDoc padding fix */
#root > div > main > article > div > main > article,
#root > div > main > article > div > main > div {
  padding: 0;
}

We created an App.css and used this code.  It didn't seem to fix the problem.  Are we missing something?

While a real fix is needed, to make your users happy, you can work around it by adding the following to your App.css:
/* TechDoc overflow fix */
#root > div > main > article > div > main {
  overflow-y: visible;
  height: 100%;
}

/* TechDoc padding fix */
#root > div > main > article > div > main > article,
#root > div > main > article > div > main > div {
  padding: 0;
}

@GLundh, We created an App.css and used this code. It didn't seem to fix the problem. Are we missing something?

packages/app/src/index.tsx:
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from './App';
**import './App.css';**

ReactDOM.createRoot(document.getElementById('root')!).render(<App />);

Fixing the issue with global app css rules is just a hacky workaround. I don't understand the techdocs stack enough to write a fix that I'm happy with. This is just about good enough to make our users happy (and I kinda understand other's pain of trying to roll out techdocs with this bug).
I still hope that someone that really gets the techdocs-stuff takes a look at the issue.

Thanks @GLundh, appreciate the follow up. My CSS skills are not enough to take this on sadly.

While a real fix is needed, to make your users happy, you can work around it by adding the following to your App.css:
/* TechDoc overflow fix */
#root > div > main > article > div > main {
  overflow-y: visible;
  height: 100%;
}

/* TechDoc padding fix */
#root > div > main > article > div > main > article,
#root > div > main > article > div > main > div {
  padding: 0;
}

@GLundh, We created an App.css and used this code. It didn't seem to fix the problem. Are we missing something?

packages/app/src/index.tsx:
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from './App';
import './App.css';

ReactDOM.createRoot(document.getElementById('root')!).render(<App />);

Thank you.  Unfortunately it didn't work for us.  No idea why.  This seems like a fundamental problem in TechDocs.  Would be nice to see a permanent fix.

Alright, see PR above, making things a whole lot better.

On the demo site I noticed that while scrolling TOC sidebar doesn't highlight the active heading. I also have this problem in my project. Does anyone know what might be the cause?


[release-1.14] Additional changes for istioctl analyzer when checking envoyFilter patch operations

This is an automated cherry-pick of #38389

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.14
797b5c5038e86356d4ffd95f26497fe2f05510e4
link
true
/test unit-tests_istio_release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.14


Add C API

Create .h headers with extern "C" (#if __cplusplus) to allow usage of this library from C code.

This will allow adding wrappers for other languages:

C# for Unity3D
Python3 for simple utilities


"expected value of source_id to not contain any uppercase letter" When standing Up IoThub

Hi there,
I have a terraform configuration that stands up an iothub resource. It's throwing the above error, but because the dependent resources are using Terraform to stand up the resource and its dependencies I don't understand how to prevent this error.
Here's its slice of state:
"module": "module.monitoring",       "mode": "managed",       "type": "azurerm_iot_time_series_insights_event_source_iothub",       "name": "res-794",       "provider": "provider[\"registry.terraform.io/hashicorp/azurerm\"].stage",       "instances": [         {           "schema_version": 0,           "attributes": {             "consumer_group_name": "devicetelemetry-consumergroup",             "environment_id": "/subscriptions/<subscriptionidwithnocapitals>/resourceGroups/gspiot-instiot-rg-s-use2-00/providers/Microsoft.TimeSeriesInsights/environments/gspiot-insttsi-timenv-s-use2-00",             "event_source_resource_id": "/subscriptions/<subscriptionidwithnocapitals>/resourceGroups/gspiot-instiot-rg-s-use2-00/providers/Microsoft.Devices/iotHubs/gspiot-instiothub-prodiot-s-use2-00",             "id": "/subscriptions/<subscriptionidwithnocapitals>/resourceGroups/gspiot-instiot-rg-s-use2-00/providers/Microsoft.TimeSeriesInsights/environments/gspiot-insttsi-timenv-s-use2-00/eventSources/gspiot-ehubeventsource-timene-s-use2-00",
When dependent resources call on this resource, they are throwing the following error:
"Error: expected value of source_id to not contain any uppercase letter"`

resource "azurerm_application_insights_workbook" "res-1322" {
Yadda yadda
source_id           = azurerm_iot_time_series_insights_event_source_iothub.res-794.id
Yadda yadda
}
}

Oops.
The source_id should be the name of the resource and not the id of the resource. Fixing the property that was being used on res.794 cleared things right up.


User Authentication to Data Sources section

In the security whitepaper, there are multiple reference to "Role-level security (RLS)".
Isn't it "Row-level security (RLS)" ? Am I missing something ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce725cf3-1fcb-9942-3b6f-63dade96b0d3
Version Independent ID: 0e724841-6fcc-d35a-167f-f5c7d2162f30
Content: Power BI Security - Power BI
Content Source: powerbi-docs/service-admin-power-bi-security.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

The Security whitepaper is correct as it's written; sorry that those two terms are so close.


Optionally use list type for ordered string/number arrays

Hello!
Really appreciating this library as it has saved me lots of time. However, I ran into a potential edge case when I realized that the order of my array was being changed when I inserted it into Dynamo. As stated here a String Set type will be used for an array of unique values, however Dynamo does not preserve order for sets.
I have a case where I need an ordered list of strings, so the List type would need to be used. Could this potentially be an option/configuration somewhere? Also to note is that the default in the DynamoDB console when an array is created in JSON view is to create a list.

Thanks for the issue.
I would like to direct you to the Official Document Client, because I believe it has the behavior you are after.
We are choosing not to change this library so as to support legacy systems, which may rely on the current behavior.
If you have any other questions or would like any clarification, please do not hesitate to contact us via this issue.
If you find the provided documentation helpful, feel free to close this issue.
Thanks

Thanks for the reference, I was not aware of this.
Thank you for your quick reply!


Fix generator error, update data and output directories

Fixes issue w trying to get the length of a generator which breaks everything :(
Also updates the input/output directories so that everything goes where it should

Also regarding your comments on how this code blows up because of the generator. To me, that says that no one ran the code before it was committed (not naming names). I think #15 becomes more important already.

Also regarding your comments on how this code blows up because of the generator. To me, that says that no one ran the code before it was committed (not naming names). I think #15 becomes more important already.

Yea I have committed QA sins, I shall atone for them/ fix the above mentioned comments
I happen to also be working on a branch that seems like it at least somewhat works. Will improve/ add more tests and probably integrate them into the ci/cd pipeline with some kinda github action (in a separate pr) to prevent future me from accidentally contaminating the codebase with impure untested code.

Also regarding your comments on how this code blows up because of the generator. To me, that says that no one ran the code before it was committed (not naming names). I think #15 becomes more important already.

Yea I have committed QA sins, I shall atone for them/ fix the above mentioned comments I happen to also be working on a branch that seems like it at least somewhat works. Will improve/ add more tests and probably integrate them into the ci/cd pipeline with some kinda github action (in a separate pr) to prevent future me from accidentally contaminating the codebase with impure untested code.

So much drama 😅😂


fixes complaints about missing docs

Objective
When using derive(WorldQuery), then clippy complains with the following:
warning: missing documentation for a struct
  --> src\wild_boar_type\marker_vital_status.rs:35:17
   |
35 | #[derive(Debug, WorldQuery)]
   |                 ^^^^^^^^^^
   |
   = note: this warning originates in the derive macro `WorldQuery` (in Nightly builds, run with -Z macro-backtrace for more info)

Solution

Either #[doc(hidden)] or
Add a generic documentation line to it.

I don't know what is preferred, but I'd gladly add it in here.

Preference is for generic documentation line; this struct was deliberately not hidden.

Wait, isn't it meant to inherit the docstring on the derived struct?

Why not just silence the lint?

@bjorn3 this is dealt with in packages like derive_more, so I thought it should be dealt with here as well.

Yep; silencing the lint won't work with forbid missing docs either.

#[automatically_derived] reliably silences the missing_docs lint as well as several others, even with #![forbid(missing_docs)]. This attribute is used by all builtin derives as well as custom derives like serde::Serialize. https://stackoverflow.com/questions/51481551/what-does-automatically-derived-mean

Excellent, thank you @bjorn3. I'd seen allow fail, but didn't know about automatically_derived.

bors r+


[Bug] Support dual packaging

Version
5.3.2
Link to Minimal Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-kcuvdv
Steps to Reproduce

Open the link
Wait for the test to end

Current Behavior
Vitest throw the following error:
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/echarts.test.ts [ test/echarts.test.ts ]
SyntaxError: Cannot use import statement outside a module
 ❯ Object.compileFunction https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:341311
 ❯ wrapSafe https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:218270
 ❯ Module._compile https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:218638
 ❯ Module._extensions..js https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:219666
 ❯ Module.load https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:217692
 ❯ Module._load https:/vitest-dev-vitest-kcuvdv.w.staticblitz.com/blitz.ad37e903755d89e0f5d9999e69be73a0c6cb6bcc.js:6:215263

Module /home/projects/vitest-dev-vitest-kcuvdv/node_modules/echarts/lib/core/echarts.js:26 seems to be an ES Module but shipped in a CommonJS package. You might want to create an issue to the package "echarts" asking them to ship the file in .mjs extension or add "type": "module" in their package.json.

As a temporary workaround you can try to inline the package by updating your config:

// vitest.config.js
export default {
  test: {
    deps: {
      inline: [
        "echarts"
      ]
    }
  }
}

Expected Behavior
ECharts should be imported correctly as an ES Module by vitest.
ECharts may need to support dual packaging mentioned in this guide.
Environment
- OS: Windows 11
- Browser: Chrome
- Framework: Vue@2 + Vite

Reproduction with `vue-echarts` here: [stackblitz.com/edit/vitest-dev-vitest-fhmvl9](stackblitz.com/edit/vitest-dev-vitest-fhmvl9)

Any additional comments?
This issue has been mentioned before in #16599 but is closed now.
See also the comments of vitest member:
https://github.com/ecomfe/vue-echarts/issues/601#issuecomment-1150797371
https://github.com/vitest-dev/vitest/issues/1452#issuecomment-1150750725

I am having the same error. :(

Same issue here, any update?

Closed by #19513


V0.9.0 working 2

Coverage increased (+0.1%) to 62.147% when pulling 6838dd450359e4e8d4aa1340f807bd78659d435c on v0.9.0-working2 into 978b1c3c0f795d09d0710238cb5f82853b99a460 on master.


fixes for issues found by adapter-checker

fixes for issues found by adapter-checker see issue #364

thank you

thank you

Thank you!


Support computation of norms

Computing the norm (or, actually, different types of norms) of an array is a very frequent requirement. At present, one needs the xtensor-blas extension and an external BLAS library to get a norm() function. I suggest that xtensor should support the most important norms natively by implementing ufuncs:
norm_lp(array_like, int p);  // p-norms
norm_l0(array_like);         // 0 "norm" (counting pseudo-norm)
norm_l1(array_like);         // 1-norm
norm_l2(array_like);         // 2-norm
norm_linf(array_like);       // max norm
norm_sq(array_like);         // squared 2-norm, for efficiency reasons

These are computed elementwise, regardless of array dimension. Thus, norm_l2(matrix) is the matrix' Frobenius norm. In addition, 2D arrays should support the induced norms (maximum of absolute row or columns sums)
norm_induced_l1(matrix);   // induced 1-norm of a matrix
norm_induced_linf(matrix); // induced max-norm of a matrix

The xtensor-blas library should be adapted to this naming convention. It should provide optimized versions of these functions (using BLAS primitives) and additional norms such as
norm_spectral(matrix);  // maximal singular value
norm_nuclear(matrix);   // sum of singular values

which require matrix decomposition algorithms not available in the xtensor core.
The function name norm() should be avoided because its semantics are inconsistent between the C++ standard (which unfortunately defines norm() to compute the squared norm) and numpy.

ping @wolfv

I agree that the norms should be explicitely named. Beyond the inconsistency between the C++ standard and numpy, having a norm function implies an arbitrary choice regarding the norm used for its implementation, and this may not be intuitive.

It seems like a reasonable thing to do and we can also consider splitting/renaming the functions in xtensor-blas. Given these functions, creating a numpy like interface would be trivial and could be implemented in another header if we seen it necessary.

What about norm(x, tag) and use tag dispatching?

What about norm(x, tag) and use tag dispatching?

This would also work, but is IMHO inferior

To avoid name clashes, the tag names have to be quite verbose (longer than a suffix like _l2).
The function uses the contaminated name norm().

The tag dispatching can come on top of the explicitly named norms. Thus we can have some mechanism for generic programming, but in my opinion it should be complementary to the explicitly named norms, not replace them.

Question: It would be natural to implement norm functions by means of xreducer. However, the current xreducer design is not flexible enough. Keeping the basic structure of aggregate() intact, computations proceed in three steps, which in general require three different functors:

initialization of the accumulator variable from the first element in every row, required signature: init(value_type) -> result_type
accumulation across the current row, required signature accumulate(result_type, value_type) -> result_type
merge of the results from all rows, required signature merge(result_type, result_type) -> result_type

In the current implementation, step 1 is simply an assignment, and steps 2 and 3 share function m_f with signature m_f(value_type, value_type) -> value_type (current master) or m_f(result_type, result_type) -> result_type (PR #435). This simplification works for the currently implemented functions amin(), amax(), sum() and prod(), but not for norms (as becomes apparent when value_type is std::complex).
The obvios solution is to add two additional template arguments to xreducer, which represent the functions init and merge. The new arguments can be provided with defaults that reproduce the current behavior.
Do you have any comments or better ideas?

Wouldn't a functor class for reducers with the three functions (and sensible defaults) also be an option and (maybe) a cleaner design? Or are there drawbacks?
Btw. we should probably also plan for accumulators soon (e.g. cumsum and related).

@ukoethe I really like your idea!
Gathering the three functors into a single one as suggested by @wolfv (something like a generic xreducer_functor which accepts 3 functors so we can still use existing functors) would avoid additional arguments to the reduce functions, and help keep the number of template argument of xreducer low, however there may be drawbacks that I'm not aware of. What do you think ?

Ok, good suggestion.

Please see #436 for a proof-of-concept implementation.

Can this be closed?

From my point of view, it can be closed. I just kept it open as a reminder for the necessary follow-up changes in https://github.com/QuantStack/xtensor-blas.

I filed a seperate issue in xtensor-blas. I think I'll get around to fix it in xtensor-blas next week.


HV-1744 Use auto-expanding entries in the documentation TOC

https://hibernate.atlassian.net/browse/HV-1744

I checked the rendering locally, looks good to me.

Jenkins, retest this please

@gsmet The new asciidoc "theme" is synced to Central, this PR can now be built successfully.

@gsmet Ping?

Thanks for taking the time to do it, it's significantly better.


How to set current viewport manually?

I try to invoke setCurrentViewport to zoom lineChart to specified bounds, but i does nothing. Is there any secret?

Could you paste your code in which you are setting viewport?
Two things that comes to my mind:

current viewport should fit within maximum viewport so if you are setting large currentViewport try to first modify maximumViewport as well,
viwport should be modified after chart's data had been set. Everytime chart's data is set or animated viewports are recalculated, you can disable that behavior: chart.setViewportCalculationEnabled(false);

Thank you. The second case was mine ) Actually i set current viewport after setting chart's data. At the next line of code. But it recalculates the viewport on the next frame or something. So chart.setViewportCalculationEnabled(false) at the right place helped me.


Internal server errors are being swallowed in endpoints

Bug Description
When there is an error in an endpoint, we do not get a log in the console about what it is.
Steps to Reproduce

Run nox -s api
Add a raise Exception('error') to one of the endpoints, i.e. in /api/v1/health
Navigate to the endpoint, which will display "Internal Server Error" in the browser, but nothing in the logs

Expected behavior
A stack trace with the error to show up in the logs
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Version: main
OS: macOS Monterey
Python Version: 3.8
Docker Version: 20.10.14

Additional context
Add any other context about the problem here.

closing as per @NevilleS 's comment, I think he meant to


Sage 10 Child/Parent Theme Support

[x] I've read the guidelines for Contributing to Roots Projects
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse community

Description
Related to this discussion: https://discourse.roots.io/t/sage-10-as-parent-child-themes/
It would be fantastic to get some feedback ftom @Log1x and @QWp6t
Steps to reproduce
1. Parent Theme:
1.1 Make a new Sage 10 Theme with custom Namespace "Parent" in folder 'parent'
1.2 Add some View Composers variables such as "siteName" and reference it in a blade file
1.3 Add a function my_test_function() to helpers.php
1.4 Activate the theme, it should be working and the variable $siteName is outputted correctly
2. Child Theme
1.1 Make a new Sage 10 Theme and leave the Namespace as "App" in folder child
1.2 Add Template: parent to style.css
1.3 Remove all blade files from ./resources/views/
1.4 Use \Parent\my_test_function() e.g. in a child View Composer
1.5 Autoload parent theme Class in composer.php:
"psr-4": {
      "App\\": "app/",
      "Parent\\": "./../parent/app/"
    }

1.5 Activate the child theme
Expected behavior: [What you expect to happen]

[x] Blade views are loaded from parent theme
[x] View Composers are loaded from parent theme as well as from child theme (ideally overwriting parent values)
[x] Functions from parent theme in helpers.php are available via \Parent\my_test_function()
[ ] Config via \Roots\config() is loading parent theme value, if child theme value is not set

Actual behavior: [What actually happens]

[x] Blade views are loaded from parent theme
[x] Undefined variable: siteName errors, the View Composers from the parent theme are missing
[x] Call to undefined function errors when calling \Parent\my_test_function()
[ ] Error if e.g. \Roots\config('app.debug') is not set in child theme as function not checks against parent value

Reproduces how often: [What percentage of the time does it reproduce?]
In the current setup 100%. More tests required.
Versions
Sage 10.0.0-alpha
Additional information
It would be fantastic to get a very short summary how child/parent themes should be set-up with Sage 10.

Regarding Functions from parent theme in helpers.php are available via \Parent\my_test_function() I was able to solve it:
In the functions.php I oversaw that locate_template() is used what checks for files by hierachy (Searches STYLESHEETPATH before TEMPLATEPATH). So as I still had a helpers.php, setup.php, ... in my child/app folder, it loaded the child one and skipped the parent files in parent/app even though they should get included as well (by default).
So this is fixable by renaming either the files. In my case I renamed parent/app to parent/inc so the locate_template() function in the parents function.php will recognize them.
So for now I am only confused what the best way is to autload the View Composers from the parent theme.
Cheers

Well, another issue solved. Quite easy and obvious if I now think about:
In the child theme config/view.php you have to (of cause) add the composer Classes:
    'composers' => [
        // App\Composers\Alert::class,
        Parent\Composers\Alert::class,
        Parent\Composers\App::class,
        Parent\Composers\Title::class,
    ],

Furthermore if you have custom ServiceProviders in the parent theme, you need to load them as well in /config/app.php:
 'providers' => [
        Parent\Providers\ThemeServiceProvider::class,
        // App\SomeService\SomeServiceServiceProvider::class,
    ],

So my currently only leftover is that it would be fantastic to get config values via \Roots\config() that fallbaks to parent value if it is not overwritten in the child theme.

Putting this on hold until Sage 10 documentation is finished.

To chime in here from my debugging work, it looks like the current method for adding composers/components from outside the theme directory structure is no longer in config/app.php or config/view.php.
The way I've found to implement composers and components is to implement theme in your child theme's ServiceProvider. Specifically, you'll want to add them into the boot() function as shown in the Laravel documentation for View Composers and manually registering package components. Both of these are a bit clunky, as shown below.
/** ...
* Inside your ThemeServiceProvider.php file
*/
use Roots\Acorn\ServiceProvider;
use Illuminate\Support\Facades\Blade;
use Illuminate\Support\Facades\View;

...

 /**
 * Bootstrap any application services.
 *
 * @return void
 */
public function boot() {
    // Boot your view composers here.
    // Note that you have to redefine the 'view' in order for it to use this composer on the correct view partials
    View::composer('view.name', \ParentApp\View\Composers\ViewName::class);

    // Boot your components here.
    Blade::component('alert', \ParentApp\View\ComposersComponents\Alert::class);

}

This is obviously not great because you have to define your view names, and import all your classes manually. Shouldn't we be able to boot the parent theme's ServiceProvider and bring in all those Composers/Components? Someone with more Laravel/PHP experience may be able to help with that. I have a feeling that if we want a child theme/app to work, we'll need to create a child theme fork.
In the mean time, I hope this helps the poor souls looking to make this work.

Please let me know If I need to open a new issue for this on github?
Is there any proper guide for setting up the child theme with sage 10? I am using sage 10 as my main theme on WordPress and for customizations, I have to create the child theme. I tried following the above discussion to create the child theme and it does not work. Changing the parent theme's namespace to Parent (from App) breaks the connection between composers and views, data does not go to the views.
Child theme is activated.
getting this error
Undefined variable $heroBackground in section-page-header.blade.php
$heroBackground is defined in the Parent\View\Composers\App.php
in the child App.php I have the following code
<?php

namespace App\View\Composers;

use Roots\Acorn\View\Composer;

class App extends Composer
{
}

And in the child theme's App\Providers\ThemeServiceProvider
<?php

namespace App\Providers;

use Roots\Acorn\ServiceProvider;

class ThemeServiceProvider extends ServiceProvider
{
    /**
     * Register any application services.
     *
     * @return void
     */
    public function register()
    {
        //
    }

    /**
     * Bootstrap any application services.
     *
     * @return void
     */
    public function boot()
    {
        //this outputs the correct data from the parent function
        dd((new \Parent\View\Composers\App())->getColorScheme());
    }
}

Any hint about where to go from this point will be much appreciated.

@waqas-raza-dh

Any hint about where to go from this point will be much appreciated.

If I understand from my troubles with this, it's likely that the child theme is not loading the parent's view composer for section-page-header.blade.php. Usually, that would be a SectionPageHeader.php class file in the App/View/Composers folder/namespace.
I'm sure there's a more elegant way to autoload all the parent's composer classes, but I add the ones I need to the boot function in the child's ThemeServiceProvider
 /**
     * Bootstrap any application services.
     *
     * @return void
     */
    public function boot()
    {
        View::composer('index', \Parent\View\Composers\Index::class);
        View::composer('partials.footer', \Parent\View\Composers\Footer::class);

        ... Whatever else you have here

Surely you could programmatically fetch all parent classes, or maybe I'm doing something wrong and they're supposed to be autoloaded, but this works for me.

@evankford thank you for clearing things out for me. So, in my Parent view composer App\View\Composers I am passing some common data to all the views so I am able to get the variables like {{$var}} in my parent blade files.
But when I activate my child theme and load the parent view composer in the boot method
View::composer('*', \App\View\Composers\App::class);
it does not make any difference, and I still get the error that variable does not exist.

@waqas-raza-dh Without knowing more, it's hard to say why that's not loading. I would check:

Is the \App namespace the parent or the child app? In your first example, you used \Parent for the parent app.
If you're correctly referencing the file, you should check that the code is loading at all (a var_dump, or inserting some broken code).
Is your child ThemeServiceProvider loading?

@evankford I was able to fix the issue. The issue was within the child stylesheet. So, composer files are loading perfectly now and all the data is also coming through. Is there any correct way of importing parent theme's styles and scripts.
Currently I am importing the parent theme's style in my child theme like below
@import "../parent-theme/resources/styles/app.scss";
and when i run the build some css does not load.

Hello everybody! Tell me please is there any detailed guide on how to create child theme for Sage 10 properly? Can you give me the URL of such tutorial if it exists? Is this approach recommended at all?


Respect Keras layer names for output operations in Concrete Function

Click to expand!
Issue Type
Feature Request
Have you reproduced the bug with TF nightly?
Yes
Source
binary
Tensorflow Version
2.12.0
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
3.8.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
When converting a Keras model to concrete function, you can preserve the input name by creating a named TensorSpec, but the outputs are always created for you by just slapping tf.identity on top of whatever you had there, even if it was a custom named tf.identity operation. Since many converters rely on concrete functions to make their own representation (TFLite, ONNX, CoreML, etc), this behavior messes up the output operation names, often making them inconsistent with each other.
There's currently no workaround for that. You can access previous graph nodes by calling a layer  named like {model_name}/{output_layer_name} when doing inference on frozen graph itself, but it won't help you in any way to convert the model.
So I'd be happy to see one of those things as a solution to that:

Add an option to explicitly specify the TensorSpec for outputs, just the way we do it for inputs. This would be the most obvious and convenient way of doing it from a user standpoint
Don't add new identity operations on top of existing ones. More of a kludge, but would get the job done
Add an option to rename operations in concrete function post factum.
Add an option to cut off the operations in concrete function past a certain node.
Add an option to convert a graph into a concrete function. Since you can directly modify graphs, this could work as well

Standalone code to reproduce the issue
import tensorflow as tf

# Build simple model
inputs = tf.keras.Input((224, 224, 3), name='custom_input_layer')
x = tf.keras.layers.Flatten()(inputs)
x = tf.keras.layers.Dense(512, activation='relu')(x)
x = tf.keras.layers.Dense(256, activation='relu')(x)
x = tf.keras.layers.Dense(128, activation='relu')(x)
x = tf.keras.layers.Dense(1, activation='sigmoid', name='custom_output_layer')(x)

model = tf.keras.Model(inputs=inputs, outputs=x, name='my_custom_model_name')
model.summary()

input_tensors = [tf.TensorSpec(shape=inp.shape, dtype=tf.float32, name=inp.name) for inp in model.inputs]
concrete_function = tf.function(lambda x: model(x)).get_concrete_function(x=input_tensors)

print(concrete_function.inputs)  # we can see 'custom_input_layer:0' is there. So is the 'true' output 'my_custom_model_name/custom_output_layer/BiasAdd/ReadVariableOp/resource:0'
print(concrete_function.outputs)  # pesky Identity node gets inserted

Relevant log output
Model: "my_custom_model_name"
_________________________________________________________________
 Layer (type)                Output Shape              Param #
=================================================================
 custom_input_layer (InputLa  [(None, 224, 224, 3)]    0
 yer)

 flatten (Flatten)           (None, 150528)            0

 dense (Dense)               (None,<PHONE_NUMBER>8

 dense_1 (Dense)             (None, 256)               131328

 dense_2 (Dense)             (None, 128)               32896

 custom_output_layer (Dense)  (None, 1)                129

=================================================================
Total params: 77,235,201
Trainable params: 77,235,201
Non-trainable params: 0
_________________________________________________________________
[<tf.Tensor 'custom_input_layer:0' shape=(None, 224, 224, 3) dtype=float32>, <tf.Tensor 'my_custom_model_name/dense/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_1/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_1/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_2/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/dense_2/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/custom_output_layer/MatMul/ReadVariableOp/resource:0' shape=() dtype=resource>, <tf.Tensor 'my_custom_model_name/custom_output_layer/BiasAdd/ReadVariableOp/resource:0' shape=() dtype=resource>]
[<tf.Tensor 'Identity:0' shape=(None, 1) dtype=float32>]

@DLumi
This issue seems to be Keras issue.  Please post this issue on keras-team/keras repo. as Keras development is fully moving to github.com/keras-team/keras. All issues and PRs related to keras will be addressed in that repo.
To know more see this TF forum discussion ;
https://discuss.tensorflow.org/t/keras-project-moved-to-new-repository-in-https-github-com-keras-team-keras/1999
Thank you!

I really don't see how it is the Keras issue, since it seems like a manifestation of default behavior for calling tf.function().get_concrete_function(). If you don't specify tensor names in provided list of TensorSpecs, the algorithm would just stick to defaults (x for inputs; Identity for outputs), but if you do name your tensors, the x would be replaced with whatever you provided. Sadly that's not the case for outputs that get named Identity, since the algorithm slaps a fresh copy of default Identity operation on top of whatever there was before, and you simply don't have an option to provide a spec for this, as outputs seem to be tracked and named automatically. Thus you have no ability of preserving your Keras output names.
I will repost this in Keras repo as you suggested, but I'll probably get redirected back here pretty quickly.

Hi @DLumi,
As the issue is already on Keras repo can we close it here so that it can be better tracked at single repo. Thanks!

Hi @DLumi,
As the issue is already on Keras repo can we close it here so that it can be better tracked at single repo. Thanks!

Honestly, I'd keep both issues open in case there are some tweaks required from the TF team. Unless the Keras team explicitly says they will handle this themselves, that is.
But I understand your wish to reduce issues piling up, so feel free to close this if that's really needed.

@SuryanarayanaY as expected, I got bounced back to you guys.
https://github.com/keras-team/keras/issues/18012#issuecomment-1548704057

@DLumi hi, Have you solved or bypassed this bug？same problem happens for me.

we use extract_sub_graph to get a normal pb.
import keras
import tensorflow as tf
from keras.layers import Dense
from tensorflow.python.framework.convert_to_constants import convert_variables_to_constants_v2

inp = keras.Input(shape=(3), name='id')
output = Dense(23)(inp)
model = keras.models.Model(inputs=inp, outputs=output)

logdir='a'
name='a.pb'

@tf.function(input_signature=[tf.TensorSpec(inputs.shape, inputs.dtype, name=inputs.name.split(':')[0])
                              for inputs in model.inputs])
def _func_py(*args):
    return model(inputs=args, training=False)

func_concrete = _func_py.get_concrete_function()

frozen_func = convert_variables_to_constants_v2(func_concrete)
graph_def = frozen_func.graph.as_graph_def()
#### extract subgraph--------------------------------------------------------------------------
sub=tf.compat.v1.graph_util.extract_sub_graph(
    graph_def,['model/dense_5/BiasAdd']
)

tf.io.write_graph(graph_or_graph_def=sub,
                  logdir=logdir,
                  name=name,
                  as_text=False)

@pjgao I just embraced the stupidity of this conversion, and now expect my outputs to be named Identity instead.
And I suggest you do the same (or switch to torch altogether). since google does not give an f about TF anymore, and issues are piling up like this for years

@DLumi Life is short, We need Pytorch😀


feat: upgrade palette, use Spacer with x/y

The type of this PR is: TYPE

This PR solves [PROJECT-XX]
Description

I have left the ones I am not sure about unchanged, so type-check fails on them.

Nice work y'all


Update zlib and zlib-ng library

Build is failing for beta and nightly because of https://github.com/rust-lang/flate2-rs/pull/388

Thanks a lot for the update! The referenced PR has been merged.


[App] Wrap LightningClient methods with retry wrapper by default

What does this PR do?
Addresses https://github.com/gridai/grid/pull/9033#discussion_r1071372526.
Does your PR introduce any breaking changes? If yes, please list them.
Changes retry=False to retry=True:
- lightning_app.utilities.network.LightningClient(retry=False)
+ lightning_app.utilities.network.LightningClient(retry=True)

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[n/a] Did you make sure to update the documentation with your changes? (if necessary)
[n/a] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@akihironitta Please have a look at the motivation from #15412. There are some consequences in the CLI to doing so.

@tchaton What would you suggest here? Should we still have retry=True as the default value and turn it off for CLI-related places to avoid the issue described in #15412?

Given https://github.com/Lightning-AI/lightning/pull/16382#issuecomment-1384290226, I see two options:

Close this PR
Disable retry in CLI-related codebase and merge this PR

I'll mark this PR as ready for review again once I update this PR (2.).

@akihironitta 2) sounds good to me. To be sure, I would also check the usages in other places than the CLI and see if the default value make sense or whether it should be flipped too.


Compilation error on armhf (raspberry pi2)

Compiling libttwatch.o...                                                                                libttwatch.cpp: In function ‘int ttwatch_open_file(TTWATCH*, uint32_t, int, TTWATCH_FILE**)’:
libttwatch.cpp:435:54: warning: missing braces around initializer for ‘uint32_t [2] {aka unsigned int [2]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_close_file(TTWATCH_FILE*)’:
libttwatch.cpp:459:54: warning: missing braces around initializer for ‘uint32_t [2] {aka unsigned int [2]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_delete_file(TTWATCH*, uint32_t)’:
libttwatch.cpp:476:54: warning: missing braces around initializer for ‘uint32_t [2] {aka unsigned int [2]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_read_file_data(TTWATCH_FILE*, void*, uint32_t)’:
libttwatch.cpp:507:47: warning: missing braces around initializer for ‘uint8_t [50] {aka unsigned char [50]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_write_file_data(TTWATCH_FILE*, const void*, uint32_t)’:
libttwatch.cpp:526:65: warning: missing braces around initializer for ‘uint8_t [54] {aka unsigned char [54]}’ [-Wmissing-braces]
libttwatch.cpp:527:48: warning: missing braces around initializer for ‘uint32_t [3] {aka unsigned int [3]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_find_first_file(TTWATCH*, uint32_t*, uint32_t*)’:
libttwatch.cpp:543:39: warning: missing braces around initializer for ‘uint32_t [2] {aka unsigned int [2]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_enumerate_files(TTWATCH*, uint32_t, TTWATCH_FILE_ENUMERATOR, void*)’:
libttwatch.cpp:589:5: error: invalid use of qualified-name ‘::iterator’
libttwatch.cpp:589:5: error: expected ‘;’ before ‘it’
libttwatch.cpp:589:5: error: ‘it’ was not declared in this scope
libttwatch.cpp:589:5: error: expected ‘)’ before ‘;’ token
libttwatch.cpp:589:5: error: ‘it’ was not declared in this scope
libttwatch.cpp:589:5: error: expected ‘;’ before ‘)’ token
libttwatch.cpp: In function ‘int ttwatch_reset_gps_processor(TTWATCH*)’:
libttwatch.cpp:675:38: warning: missing braces around initializer for ‘char [60]’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_get_watch_time(TTWATCH*, time_t*)’:
libttwatch.cpp:700:46: warning: missing braces around initializer for ‘uint32_t [4] {aka unsigned int [4]}’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_get_firmware_version(TTWATCH*, uint32_t*)’:
libttwatch.cpp:749:45: warning: missing braces around initializer for ‘char [60]’ [-Wmissing-braces]
libttwatch.cpp: In function ‘int ttwatch_clear_data(TTWATCH*)’:
libttwatch.cpp:823:5: error: invalid use of qualified-name ‘::iterator’
libttwatch.cpp:823:5: error: expected ‘;’ before ‘it’
libttwatch.cpp:823:5: error: ‘it’ was not declared in this scope
libttwatch.cpp:823:5: error: expected ‘)’ before ‘;’ token
libttwatch.cpp:823:5: error: ‘it’ was not declared in this scope
libttwatch.cpp:823:5: error: expected ‘;’ before ‘)’ token
libttwatch.cpp:1490:1: error: expected ‘}’ at end of input
libttwatch.cpp: At global scope:
libttwatch.cpp:1490:1: error: expected ‘}’ at end of input
libttwatch.cpp: In function ‘int ttwatch_clear_data(TTWATCH*)’:
libttwatch.cpp:1490:1: warning: control reaches end of non-void function [-Wreturn-type]
Makefile:23: recipe for target 'libttwatch.o' failed
make[1]: *** [libttwatch.o] Error 1
make[1]: Leaving directory '/home/pi/git/ttwatch/libttwatch'
Makefile:9: recipe for target 'all' failed
make: *** [all] Error 2

What version of GCC are you using? It appears that your version does not support some valid uses of decltype. I don't know exactly when support for this was added, but 4.5 and earlier definitely don't work. I'm using 4.8 and it works fine. I believe it was scheduled to be fixed in 4.6, but I don't know if it was.

gcc version 4.6.3 (Debian 4.6.3-14+rpi1)

Can you try with a newer version of GCC? It's probably that 4.6.3 doesn't support decltype fully; it's unlikely that it's from compiling for raspberry pi.

Ok Ryan you can close issue. i installed gcc version 4.9.2 (Raspbian 4.9.2-10) and now i can compile ttwatch. thanks for the hint


Visualization of data differences between different versions in HTML

Feature description
I have a requirement to compare reports between different versions and visualize the differences between the latest version and the previous version. Can HTML be differentiated? Or can I provide differentiated JSON data that can form HTML visualization?
Reasoning
No response

Hey,
Thanks for your request! Right now we don't have any plans to prioritize this soon, but we do think it would be a great addition to Ruler to have the ability to compare two apks! You are free to make your open-source contribution and open a PR adding this functionality!


Revert "Added grammar for Java EE Expression Language in xhtml files."

Reverts leosj29/jsf-primefaces-intellisense#13

Hello, thank you very much for your contribution. However, while testing the changes, I have noticed two specific things that I don't like.
1 - The tags h, p, f, etc. are displayed in red, in my case, apparently due to some scope error, as shown below.

2 - The other issue is that I'm a fan of the "Auto Close Tag" extension by Jun Han, and for some reason that I haven't been able to trace, it gets disabled, which is not good.

It is probably due to defining JSF as a new language, rather than as standard xhtml. You can activate the extention manually for JSF by adding it to the user setting "auto-close-tag.activationOnLanguage"

I will look into the posibility for activating the "Auto Close Tag" extension if prencent for jsf-files.
REgarding the coloring, which language are you currently using to highlight your jsf/xhtml files? I have always been using HTML (text.html.derivative). The PR defines JSF as a separate language (text.html.jsf), which includes the gramars for HTML.


VLAZ: Watch skillzee.in

VLAZ requests the watch of the watch_keyword skillzee\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

skillzee\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'a good watch, but 21 seconds after Jesse's version: https://chat.stackexchange.com/transcript/message/64841212#64841212'


add a way of closing a Pty

Right now, if you call spawnWithPty too many times (~128), the commands fails, even if the process being created for each Pty has terminated.
Perhaps a ptyClose would help here, but generally some way of returning the Pty UNIX resource.
ptyClose :: Pty -> IO ()

The package I am working on is https://github.com/andygill/plist-buddy, a wrapper around the OSX plist-buddy command, and the quickcheck tests are failing because of this.

This seems to be merged and pushed to hackage. Thank you!


Create dockerfile for running unified environment without dependency conflict

Develop a Docker environment tailored for Python 3.8 to mitigate dependency conflicts often encountered when using virtual environments (venv) and Anaconda.

This looks like a good start but it's not clear to me what how users are supposed to use this Docker image. Right now, this image simply statically runs mmlu:subject=anatomy,model=huggingface/gpt2 and mmlu:subject=philosophy,model=huggingface/gpt2 i.e. the tutorial workflow. Users will typically want to provide their own conf files or run specs.
I would also suggest making the shell the entry point instead, so that users can pick between helm-run / helm-summarize / helm-server.

@0xRuangsak any update on this?

Closing due to staleness.


Investigate miniconf::{Array, Option} wrapper struct usability

Investigate the usability of miniconf::{Option, Array} as opposed to additional #[miniconf(defer-further)] or something similar.
Current arguments:

The current API (Array and Option) allows for easier muxing and nesting of array types
The attribute-based approach removes the wrapper types, which enables the outer settings struct to implement all kinds of derived traits (e.g. defmt)

One finding noted by @jordens is that it is not possible #[derive(Serialize, Deserialize)] on settings structures that contain the wrapper types

For Array one could consider use serde_big_array with additional bounds on T (with e.g. derive_where).
Having used these in anger and over a good range of applications has been a good experience.
Let's close this and open issues when and if they arise.


[DO NOT MERGE] V2.46.0 rc1 validations

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python ReleaseCandidate

stop reviewer notifications

Run Go PreCommit

Run Java PreCommit

Run Java_IOs_Direct PreCommit

Run Java_PVR_Flink_Batch PreCommit

Run Java_IOs_Direct PreCommit

Java_IOs_Direct fails because the gradle task doesn't exist on the release branch. RAT fails because I added a touched file which doesn't have a license in this PR (not part of the RC)

Run Java_Amazon-Web-Services_IO_Direct PreCommit

Run Java PreCommit

Run SQL PreCommit


Add Diosix as SBI Implementation ID 5

Hi -- as discussed on the UNIX-Class Platform Specification Task Group mailing list here, I would like to request SBI Implementation ID 5, please, for the Diosix project. Many thanks.

Multiple on list approvals, so merging


apache-like directory browser for files

seems useful

This should be closed. https://github.com/twitter/finatra/pull/169


Added support for Rackspace Cloud Files as a transport

Rackspace's official Ruby SDK is the fog library which also supports S3, local and Google Storage. If you want to merge this PR it may be worth using fog for other transports as well.
Aside - I also had to add a mime-types dependency to Gemfile because grit was locking an older version that did not work with fog. I'm not sure if this is best practice or just down right wrong but it was the only way I could get fog to work. Let me know if this should be done differently.

Nice one, I'll give this a proper look over on Monday and merge


django admin not watched

Hi guys,
I use django-axes in a couple of projects and I just found out that (at least with django 1.11.4) the django admin login is not being watched. I tried axes version 2.3.3 and 2.3.2.
I tried logging in to my regular login (with "watch_login()") until i get blocked. Then I switch to /admin and I can log in or try infinite times.
I went through the docs up and down but didn't find any possibility to activate or deactivate the default watching of the django admin.
Am I missing something? In earlier time there was a specific middleware class but this seems to be gone in the current version.
Thx!
Ron

Currently this is not working on django 1.11.
If you want to help please check https://github.com/jazzband/django-axes/pull/240

OK thx for the inifo

i want to know if django-axes is usefull for backend of django, i have installed django 1.5, i know is old, how i can used it in login of administration? thanks


Merge Develop into Main for 2.16.0 release

Gitflow to make 2.16.0 release

Putting on a blocker until I can confirm it's zero-diff for GEOS

develop is zero-diff.
However, I'm waiting on a possible bugfix from @bena-nasa and @weiyuan-jiang


Question: Are WinUI3 MenuFlyout and other flyouts able to leave the application window?

In windows, most context menus are separate from their respective window, and can "float" past the window borders. However, from looking at the WinUI3 controls gallery, it seems that context menus are restricted to the application window. Is this just the control gallery, or is this actually a limitation of WinUI3? If so, are there plans to add this functionality? (Say, when background acrylic and multi window support launches?)
Compare the uwp xaml gallery and the WinUI3 gallery:

It is a known problem : #5958


Replace/remove usage of tileserver.maptiler.com

Some examples are still using tiles from https://tileserver.maptiler.com/, which we plan to shut down relatively soon.
This PR replaces the tiles in those examples with tiles from MapTiler Cloud (using the same key as other examples).

Thanks!


Import script: Fix bugs.

Fixes #8949 and #8959

I merged the first 2 commits; see the comment above for the third.

@timabbott I had corrected this, but I pushed the wrong commit here in a hurry. Thanks for the sanity check. I have updated this and I'll be careful next time.

Merged the last commit as ed7127c8b4393549c593c78abd37fa4b63d26ff1, thanks @rheaparekh!
It's important when submitting a fix for a subtle issue like this to explain clearly the problem being fixed, not just what the solution is.  Comments and the commit history can be really valuable to future developers (including our own future selves) for understanding why the code is the way it is, but only if we actually explain subtle problems like this that motivated the changes.

@timabbott Thankyou for your review. I'll make sure to add proper comments in such cases.


Item Permission

Could you implement a feature where without the necessary item permission you can't craft/use the specified item, i've been trying to separate items between worlds but none of the current RPGItems have the per item permission option. Thank you for reading! Have a nice day! :smile:

Thank you for your reply and we will try to implement this.
Duplicate with #8
Keep an eye on that issue.

try this command
/rpgitem {itemName} permission {permissionNode} {requirePermission(true/false)}
When set to true, only players have {permissionNode} can use that item.