HDDS-373. Genconf tool must generate ozone-site.xml with sample values

/ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
71
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
27
Maven dependency ordering for branch

+1
mvninstall
473
trunk passed

+1
compile
248
trunk passed

+1
checkstyle
67
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
906
branch has no errors when building and testing our client artifacts.

+1
javadoc
153
trunk passed

0
spotbugs
305
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
493
trunk passed

_ Patch Compile Tests _

0
mvndep
29
Maven dependency ordering for patch

+1
mvninstall
425
the patch passed

+1
compile
251
the patch passed

+1
javac
251
the patch passed

+1
checkstyle
72
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
708
patch has no errors when building and testing our client artifacts.

+1
javadoc
154
the patch passed

+1
findbugs
513
the patch passed

_ Other Tests _

+1
unit
293
hadoop-hdds in the patch passed.

-1
unit
1668
hadoop-ozone in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

6765

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.ozone.client.rpc.TestBlockOutputStream

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

hadoop.ozone.client.rpc.TestCommitWatcher

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1025

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0f0af5f0cb4b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 4a21224

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/1/testReport/

Max. process+thread count
4436 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-ozone/tools U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Test failures are unrelated to patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
66
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

0
mvndep
69
Maven dependency ordering for branch

+1
mvninstall
474
trunk passed

+1
compile
246
trunk passed

+1
checkstyle
68
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
904
branch has no errors when building and testing our client artifacts.

+1
javadoc
156
trunk passed

0
spotbugs
310
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
501
trunk passed

_ Patch Compile Tests _

0
mvndep
28
Maven dependency ordering for patch

+1
mvninstall
424
the patch passed

+1
compile
252
the patch passed

+1
javac
252
the patch passed

+1
checkstyle
72
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
701
patch has no errors when building and testing our client artifacts.

+1
javadoc
151
the patch passed

+1
findbugs
510
the patch passed

_ Other Tests _

+1
unit
288
hadoop-hdds in the patch passed.

-1
unit
1417
hadoop-ozone in the patch failed.

+1
asflicense
41
The patch does not generate ASF License warnings.

6533

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestOzoneRpcClient

hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis

hadoop.ozone.client.rpc.TestBCSID

hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1025

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux fbf01a24cd64 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / d203045

Default Java
1.8.0_212

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/2/testReport/

Max. process+thread count
4418 (vs. ulimit of 5500)

modules
C: hadoop-hdds/common hadoop-ozone/tools U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1025/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


ui: show domain paths for offering domain selection

Description
Displays domain path instead of domain name,

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4979 (SL-JID-117)


scrollToRow, scrollToPosition no longer works with WindowScroller after updating React to v16.8

For my case, I've tested that it works for both methods without a WindowScroller. Any idea what's happening
Please reference this issue:
https://github.com/bvaughn/react-virtualized/issues/1179#issuecomment-593502991
What is the current behavior?
Calling scrollToRow and scrollToPosition no longer scrolls properly, but the functions are defined and I can log to the console. It just failed silently.
What is the expected behavior?
It should simply scroll to the right position / row.
Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser
Chrome v80

OS
OSX 10.15.3

React
16.8.5

React DOM
16.8.5

react-virtualized
9.21.2

There are multiple issues related to this same issue.  None of the workarounds referenced in all of these issues are working and downgrading react is not a viable solution for us.
Any idea if this is going to be fixed soon?

As a quick workaround, this have worked for me - restrict the version to: "react-virtualized": "9.21.1" in package.json.
As I noticed sadly the patch version introduced the issue.

I have the same problem with this.Are you deal with this problem?

Forgot to post. My quick workaround is like this:
import getScrollYFromElementOrWindow from 'simply-utils/dist/dom/getScrollYFromElementOrWindow';
import tryUntil from 'simply-utils/dist/utils/tryUntil';

...

/*
* Put this as the `ref` prop of the `List` component
*/
const handleRef = useCallback((ref) => {
    if (ref !== null) {
        /**
         * * TEMP Fix for virtualized list scrollToPosition not working issue when using with WindowScroller
         *
         * @TODO: Wait for PR
         * Ref: https://github.com/bvaughn/react-virtualized/issues/1179
         */
        if (windowScrollerEnabled) {
            // Override and fix scrollToPosition
            ref.scrollToPosition = (scrollTop: number) => tryUntil(() => {
                // Use the scroll element ref passed from props
                const scrollEl = scrollElementRef?.current
                if (scrollEl) {
                    // Use the `scrollTo` method from the passed element
                    scrollEl.scrollTo({ top: scrollTop })
                    // Get updated scroll top form the element
                    const updatedScrollTop = getScrollYFromElementOrWindow(scrollEl)
                    // Done if targeted scroll top is met (case: true), or
                    // Try next if targeted scroll top is not met (case: false)
                    return updatedScrollTop === scrollTop
                }
                // Try next
                return false
            }, 30, 0)
            // Override and fix scrollToRow
            ref.scrollToRow = (index: number) => {
                const scrollTop = ref.getOffsetForRow({ index })
                ref.scrollToPosition(scrollTop)
            }
        }
    }
}, [scrollElementRef, windowScrollerEnabled])

Btw, simply-utils is just the open-source npm utils library I created. The tryUntil util is just keep calling the callback until success.

Sorry lads, forgot to post. My quick workaround is like this:
import getScrollYFromElementOrWindow from 'simply-utils/dist/dom/getScrollYFromElementOrWindow';
import tryUntil from 'simply-utils/dist/utils/tryUntil';

...

/*
* Put this as the `ref` prop of the `List` component
*/
const handleRef = useCallback((ref) => {
    if (ref !== null) {
        /**
         * * TEMP Fix for virtualized list scrollToPosition not working issue when using with WindowScroller
         *
         * @TODO: Wait for PR
         * Ref: https://github.com/bvaughn/react-virtualized/issues/1179
         */
        if (windowScrollerEnabled) {
            // Override and fix scrollToPosition
            ref.scrollToPosition = (scrollTop: number) => tryUntil(() => {
                // Use the scroll element ref passed from props
                const scrollEl = scrollElementRef?.current
                if (scrollEl) {
                    // Use the `scrollTo` method from the passed element
                    scrollEl.scrollTo({ top: scrollTop })
                    // Get updated scroll top form the element
                    const updatedScrollTop = getScrollYFromElementOrWindow(scrollEl)
                    // Done if targeted scroll top is met (case: true), or
                    // Try next if targeted scroll top is not met (case: false)
                    return updatedScrollTop === scrollTop
                }
                // Try next
                return false
            }, 30, 0)
            // Override and fix scrollToRow
            ref.scrollToRow = (index: number) => {
                const scrollTop = ref.getOffsetForRow({ index })
                ref.scrollToPosition(scrollTop)
            }
        }
    }
}, [scrollElementRef, windowScrollerEnabled])

Btw, simply-utils is just the open-source npm utils library I created. The tryUntil util is just keep calling the callback until success.

Hey Michael! Could you give more details how to use your solution? Maybe some https://codesandbox.io example?

@pro2html May I know which part you don't understand?
It is hard and time consuming for me to recreate a full code example now since it's a bit legacy.
And I do recommend you switching to the new package https://github.com/bvaughn/react-window.

Thanks for the link, Michael!
I think it will be easier to use the newer version than try to fix the old one.
Thank you for responding to my message, I appreciate it!

4 сент. 2021 г., в 08:57, Michael Chan L. S. @.***> написал(а):
@pro2html https://github.com/pro2html May I know which part you don't understand?
It is hard and time consuming for me to recreate a full code example now since it's a bit legacy.
And I do recommend you switching to the new package https://github.com/bvaughn/react-window https://github.com/bvaughn/react-window.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bvaughn/react-virtualized/issues/1507#issuecomment-912915030, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQ2VSGUFZBCTSXPVETBBRLUAGYLNANCNFSM4LACKL4A.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@pro2html hello, I cannot quite get how to * Put this as the ref prop of the List component * and how to use ref. scrollToRow later.

@pro2html and can you share the implementation of tryUtil function you're using?

I use the suggestion of @michchan , here is how I made it work:
  let tableRef = useRef<Table | null>(); // create a ref, so we can calling it in future const handleRef = useCallback((ref: Table | null) => {         if (ref !== null) {             ref.scrollToPosition = (scrollTop: number) =>                 tryUntil(                     () => {                         const scrollEl = window;                         if (scrollEl) {                             scrollEl.scrollTo({ top: scrollTop, behavior: 'smooth' });                             const updatedScrollTop = getScrollYFromElementOrWindow(scrollEl);                             console.log(updatedScrollTop);                             return updatedScrollTop === scrollTop;                         }                         // Try next                         return false;                     },                     30,                     0,                 );             ref.scrollToRow = (index: number) => {                 const scrollTop = ref.getOffsetForRow({ index, alignment: 'center' });                 ref.scrollToPosition(scrollTop);             };         }     }, []);
and in the <Table component I put this in the ref prop:
<Table ref={(ref) => {                             handleRef(ref);                             tableRef.current = ref;                         }}
And now we can use the function:
  tableRef.current?.scrollToRow(row);


New account not directly visible in list

Description of bug:
I synced a fresh database with nano_wallet and then imported an existing wallet with my seed. This all worked and showed the single account I was using so far. But when I then add an account it does not show up in the list under Accounts. Only after a restart of nano_wallet does it appear.
Not sure if the fresh installation matters here. I'd rather not add more accounts to test this as you can't remove them.
Steps to reproduce the issue:

Fresh installation of nano_wallet, including sync
Accounts -> Import wallet, enter seed, Import seed
Under Settings set password
Make sure account is unlocked
Accounts -> Create account

Describe the results you received:
New account not visible under Accounts
Describe the results you expected:
All accounts visible under Accounts
Environment:
Arch Linux, git 8840c9dbefb72aef255744fd5157695201511195

I can confirm this, it's an obvious bug.


feat:#31 ecran de liste des ds

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Validation for Terraform Recipe Template Paths

Overview of feature request
Current State/Problem
Currently, we support only Terraform registry and HTTP URLs as allowed module sources for Terraform recipe template paths. However, we lack a proper validation mechanism for when an incorrect source is given during either recipe registration or deployment. Consequently, when a deployment fails, the reason provided to users is ambiguous resulting into a poor user experience.
Proposed Solution
To address this, we should utilize Terraform's module parsing logic to verify the recipe template path when the recipe templateKind is provided as Terraform, at recipe registration stage.
Acceptance criteria
If an unsupported template path for a Terraform recipe is provided, the recipe registration should fail and return a detailed error message to the user.
AB#10019

Closing, we thought the initial issue was caused by Radius not supporting all module sources. This doesn't seem to be the case as Git, S3, etc are able to be used so there's no need for additional validation.


Missing one step skipped woops

Signed-off-by: Itxaka<EMAIL_ADDRESS>

Merging directly, not point in waiting for the full test @mudler @davidcassany


bug in FunctionType.hashCode

It appears we have a bug in how we compute the hashcode of FunctionType.
The algorithm tries to compute the same hashcode of two types that would be equal under unification. To map different type parameters to the same value, the algorithm uses a map of temporary hashes.
Seems that we have a bug when you can have nested function types since the index map contains references to type parameters from the enclosing type.
Here is a repro that computes the hashcode for () -> R. If computed directly on the FunctionType, the result is the same, but if computed indirectly from a nested FunctionType, the result is different:
import 'package:kernel/kernel.dart';

FunctionType createVoidToR() {
  var r = TypeParameter("R", DynamicType());
  return FunctionType(
      [], TypeParameterType(r, Nullability.legacy), Nullability.legacy,
      typeParameters: [r]);
}

FunctionType createTTo_VoidToR() {
  var t = TypeParameter("T", DynamicType());
  return FunctionType([TypeParameterType(t, Nullability.legacy)],
      createVoidToR(), Nullability.legacy,
      typeParameters: [t]);
}

main() {
  var voidToR1 = createVoidToR();
  var voidToR2 = createVoidToR();
  var voidToR3 = createTTo_VoidToR().returnType;
  print(voidToR1.hashCode == voidToR2.hashCode); // true
  print(voidToR3 == voidToR2);                   // true
  print(voidToR2.hashCode == voidToR3.hashCode); // true, good!

  // Get hashcode first to force computing and caching the hashCode recursively
  var voidToR4 = (createTTo_VoidToR()..hashCode).returnType;
  print(voidToR4 == voidToR2);                   // true
  print(voidToR2.hashCode == voidToR4.hashCode); // false, oh no!
}

The last line prints false instead of true. This issue causes some hashmaps to work improperly. (We noticed this while inspecting generated code in ddk and saw some duplicated reified types.)
/cc @johnniwinther @stefantsov

I've been investigating more closely the context where this is coming up, and I'm not sure the bug above is the reason we are hitting issues in DDK. It appears that it could be due to the fact of how hashCodes are cached even if they are queried when the proper context is not available.
The type were we are hitting issues is when compiling this type from dart:async:
typedef RunHandler = R Function<R>(
    Zone self, ZoneDelegate parent, Zone zone, R Function() f);

Unlike my first example, here the nested function uses the type parameters from the outer function.
When we run the CFE and DDC in memory together, the output looks one way, but when we serialize the sdk .dill file and then run DDC on it, we start seeing the duplicate entries. One theory I have is that we may be trying to read the hashcode of the nested function before we have computed it from the outer function. For example something like this code would do:
import 'package:kernel/kernel.dart';

final _legacy = Nullability.legacy;
FunctionType createVoidTo_VoidToR() {
  var t = TypeParameter("R", DynamicType());
  return FunctionType([], FunctionType([], TypeParameterType(t, _legacy), _legacy), _legacy, typeParameters: [t]);
}

main() {
  var outer1 = createVoidTo_VoidToR();
  var outer2 = createVoidTo_VoidToR();
  var voidToR1 = outer1.returnType;
  var voidToR2 = outer2.returnType;
  outer2.hashCode;
  print(outer1 == outer2);     // true
  print(voidToR1.hashCode == voidToR2.hashCode); // false, OK
  print(outer1.hashCode == outer2.hashCode); // false, on no!
}


[BUG] RDST bugfixes

This PR introduce bug fixes for RDST transformer to make its performance equal to the performance of the original implementation in the convst package.
What does this implement/fix? Explain your changes.

Additional Fixes for #474
Distance function as argument, with Manhattan distance as default, as in convst.
Added Manhattan distance to aeon distances
Fixed the initialization of the lambda threshold, it was only considering the lower bound and not both the lower and upper bounds.
Refactored distance vector and shapelet feature extraction
Removed the tentative optimization of using MASS algorithm to compute normalized distance profiles, this will be introduced in a future PR using the distance function argument to specify if it shall be used or not.

Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?

@MatthewMiddlehurst noted some huge accuracy difference between the convst implementation and this one, I validated locally that the differences are gone, but a check from someone else would be nice.

Did you add any tests for the change?
Unit test were added for the new functions, and I updated the one for #474
For all contributions

[X] I've added myself to the list of contributors.
[X] Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.
[X] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
[X] For new estimators, I've added the estimator to the online documentation.

Tests seem to fail on test_constructor for all estimators, is a numba function (the newly introduced distance parameter) as an argument not accepted ? It don't get why It worked on some version and failed on others, am I missing something ?

The tests are spread to only be on certain OS/Python combos. I would make the default None or str.

Tried to run it on our cluster and we have arrived back at https://github.com/baraline/convst/issues/24 🙂
I think it doesnt like caching+function input. Perhaps it breaks one of the requirements here. https://numba.pydata.org/numba-doc/latest/developer/caching.html

If i remove the distance parameter and just use the Manhattan function it seems fine. Perhaps instead of inputting a function it could be string only and select based on that inside the function based on that?
I have never run into this numba quirk before, rather annoying.

It indeed seems to be the reason for the issue we were experimenting ... Indeed, a bit annoying but at least it's nice to have part of the answer. I'll try to come up with something using a str argument,
It would be annoying to have to define individual transforms functions for each distance.

After running on some UCR datasets the fix appears to have worked and it performs as expected accuracy wise, however.

All my attempts in including the choice of distance function in the Numba functions caused problems with the caching, so I made the manhattan distance by default for all functions for consistency with convst.

After running on some UCR datasets the fix appears to have worked and it performs as expected accuracy wise, however.

However ?

ah just meant that despite the new issue the accuracy looks good. Think after this the transformer should be fine

@TonyBagnall @chrisholder the transform side of things looks good to me. Any comments on the new distance?


Bug: Attempt to concatenate field rg_regex (a nil value)

Hey folke firstly thanks for this amazing plugin!
Whenever I do :TodoQuickFix or any other command of this plugin, I get stuck on this error. Not sure if it is a problem on my end or a bug with the plugin, but yeah I need some help with this.
Bug

Config

I am using the same config that you showed in the README.md as an example.

That's odd. It would give that error if setup wasn't run. Also, you don't need to provide any options if you want the defaults.
How do you load the plugin? With packer?  Make sure the setup is in the config packer setting

Yes, I use packer

The setup should be in the use clause.
I'm not at home, but something like this:
use { "folke/todo-comments.nvim", config = function() require("todo-comments").setup() end}

The setup should be in the use clause.
I'm not at home, but something like this:
use { "folke/todo-comments.nvim", config = function() require("todo-comments").setup() end}

Nope the same error still.

I've just added some additional error logging if things aren't properly loaded. Can update and try again and see what you get?

Looks there is something is wrong with the lazy loading of Todo comments.
Without require("todo-comments.config")._setup()

With require("todo-comments.config")._setup()

Did you do PackerCompile and vim restart?

Did you do PackerCompile and vim restart?

Yep

That's so odd. And you don't get any errors  during loading right? :messages?
If you add a print inside that config, it gets printed?

Nope, no messages can be found. and yeah I can print inside pluginList.lua.

I meant print inside the config:
use { "folke/todo-comments.nvim", config = function()
print("inside todo comment config")
require("todo-comments").setup()
end}

It really seems as if the config is not executed.
Before running PackerCompile, you need to exit vim. I've noticed there's something funky going on with the compile these days.
You could also check the compiuled code and see if the setup is actually there.
I suspect this is the issue you're having.

See also this https://github.com/wbthomason/packer.nvim/issues/304

use { "folke/todo-comments.nvim", config = function()
print("inside todo comment config")
require("todo-comments").setup()
end}

Weird, that works now 🤔

Great, must've been the compile that didn't work. It's a bit weird that you need to exit vim before doing a recompile.

Another question, can I move the require("todo-comments").setup() to another file, or in init.lua?

most people make a directory lua/config. Then you can mnake lua/config/todo-comments.lua
Put your setup stuff there and then:
use { "folke/todo-comments.nvim", config = function() require("config.todo-comments") end}

most people make a directory lua/config. Then you can mnake lua/config/todo-comments.lua
Put your setup stuff there and then:
use { "folke/todo-comments.nvim", config = function() require("config.todo-comments") end}

Alright thanks!


Configure .zappr.yaml team

Configure .zappr.yaml team to get rid of compliance warnings.

:+1:

:+1:


What are the standards followed for APIs and generating payload?

TO ensure that sensitive information in the actual domain objects is not accessible even to the HCX, protocol requires the payload defined by the domain data specifications to be encrypted using a separate asymmetric encryption key of the final recipient established at the time of participant onboarding into the registry. API then carries the encrypted value of the payload. The payload encryption is expected to be performed using JSON web encryption RFC7516 as per algorithm and enclosed values fixed in the protected headers section above. At this point in time, no unprotected headers are envisioned in the HCX protocol. We also do not envision multiple recipient delivery in the current version of the HCX protocol.
More information available at https://docs.swasth.app/hcx-specifications/hcx-technical-specifications/open-protocol/data-security-and-privacy/message-security-and-integrity


ci: Add Complex Allow Test to Policy Engine

In order to understand where failures in CIDR policy rule generation happen, we need to ensure that the
policy engine is, at least, computing CIDR policies correctly when there are complex CIDRSets involved in the computation process. This test confirms that the policy engine correctly handles multiple levels of allow and deny CIDR rules that interact with one another.

blocked by https://github.com/cilium/cilium/pull/22625

This test is no longer relevant based on how the PR it was meant to test changed.


Jesse: Watch bestliveforexcomexrecommendationsprovider.wordpress.com

Jesse requests the watch of the watch_keyword bestliveforexcomexrecommendationsprovider\.wordpress\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bestliveforexcomexrecommendationsprovider\.wordpress\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


AttributeError: provides when using relay.Node

Is this a bug? I checked the code in types.py:_get_fields from the stacktrace below, and I don't think it should be looking up __provides__ on the origin. Let me know if you need a sample project that can reproduce it.
  File "/code/.../types.py", line 242, in <module>
    class OrganizationType(gql.relay.Node):
  File "/usr/local/lib/python3.9/site-packages/strawberry_django_plus/type.py", line 396, in wrapper
    return _process_type(
  File "/usr/local/lib/python3.9/site-packages/strawberry_django_plus/type.py", line 281, in _process_type
    fields = list(_get_fields(django_type).values())
  File "/usr/local/lib/python3.9/site-packages/strawberry_django_plus/type.py", line 229, in _get_fields
    attr = getattr(origin, name)
AttributeError: __provides__

Hi @eloff ,
I think this should have been fixed in the release I just made. Please reopen this issue if it is not the case.

Thanks, that fixed it


Files not showing up in workspace explorer

VSCode Version: 1.16.1
OS Version: MacOS Sierra

Steps to Reproduce:
Here's a quick screencast: https://www.screencast.com/t/fVnc2I4u9uL
Reproduces without extensions: Yes

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!


Remove instances of @unpack

Since @unpack x = y is equivalent to (; x) = y in Julia 1.7 onwards, we can remove dependence on UnPack.jl.
Motivated by https://github.com/trixi-framework/Trixi.jl/pull/1367

Exporting @unpack from SimpleUnpack.jl to avoid potential breaking changes.


maxErrors IS respected when fix is true

When fix is true the documentation says maxErrors is ignored however using 2.1.0 this does not seem to be the case i can run with fix true repeatedly and it will fix 50 errors at a time fixing 50 more with each run. I am using this with the jQuery preset and grunt-jscs.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26126174-maxerrors-is-respected-when-fix-is-true?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Are you sure this is the case?
Maybe it's showing errors it can't fix? I just did function a () {} 51 times and tried autofixing and it fixed all of them to function a() {}

Yes reproduced repeatedly with this config on the jQuery ui repository
jscs: {
		all: {
			options: {
				requireCapitalizedComments: null,
				fix: true,
				config: ".jscsrc"
			},
			files: {
				src: [ "demos/**/*.js", "build/**/*.js", "tests/**/*.js", "ui/**/*.js" ]
			}
		}
	}

the result is a passing status with no errors on each run
but running git status after each run shows an ever increasing number of changed files as it fixes 50 errors at a time.
adding maxErrors: 500000 causes the whole lib to be fixed and 175 unfixable errors to be out put

Hmm ok the code is in https://github.com/jscs-dev/node-jscs/blob/b5da623613bc81d8e92eaa3037cb8375d2909eca/lib/cli.js#L96-L98 @markelog

Yeah, maxErrors is respected if you run through CLI, but not programmatically

Okay, it is grunt-jscs, since fix property is its flag not of jscs - https://github.com/jscs-dev/grunt-jscs/issues/95


Warning: findDOMNode is deprecated in StrictMode. React 16.6 deprecated findDomNode-function

Hi,
I was recently trying to upgrade from React 16.5 to React 16.6 in which they have deprecated the findDomNode function in the react-dom npm package. We are using the <React.StrictMode> to check for programming mistakes, and now it also checks a gives a warning for usage of the findDomNode. To my surprise, when I open up the page I'm developing, I got up to 50 warnings of the same error of the form:
"Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Panel which is inside StrictMode. Instead, add a ref directly to the element you want to reference."
We are not using findDOMNode anywhere in our code. I boiled it down to the following example which produces the warning...
import { observer } from "mobx-react";
import * as React from "react";

interface IPanelProps {
    header?: React.ReactNode;
    panelStyle?: React.CSSProperties;
    panelBodyStyle?: React.CSSProperties;
    panelHeaderStyle?: React.CSSProperties;
}

@observer
class Panel extends React.Component<IPanelProps, any> {
    @override
    render() {
        const { header, panelStyle, panelBodyStyle, panelHeaderStyle } = this.props;
        return (

                {header && (

                        {header}

                )}

                    {this.props.children}

        );
    }
}

export { Panel, IPanelProps };

when I comment out the observer import, the warning goes away. So I looked in the observer implementation https://github.com/mobxjs/mobx-react/blob/73120d88cc86d2a22d36c42d385959aa396b9a8d/src/observer.js
and I found that it uses the findDOMNode function.
How much work is there in rewriting the observer implementation to not use the findDOMNode function?
We are currently waiting with our React 16.6 upgrade, because we still want to use the strict mode, but getting 30-50 warning of this sort makes it unusable.

Mobx-react 5 won't support strict mode, but v6 will, see #640


docs: update pip install to use sphinxcontrib-verilog-diagrams

I'm unsure why the pip module is called sphinxcontrib-verilog-diagrams and elsewhere sphinx_hdl_diagrams is used. Historical resasons?
Anyway, now docs match what I find on pypi:

Yes, the module was originally only able to handle verilog code, but then some people improved it to support vhdl and other things that Yosys can parse.

We should probably create a "dummy" sphinxcontrib-verilog-diagrams module which just redirects everything to sphinxcontrib-hdl-diagrams?

I'll also upload the module to PyPi as sphinxcontrib-hdl-diagrams

https://github.com/SymbiFlow/sphinxcontrib-hdl-diagrams/issues/93

@mithro I'm trusting your judgement here :-) I saw something that I thought was a simple search and replace fix...
Close this PR?

Yes, closing the pull request.
Also logged https://github.com/SymbiFlow/sphinxcontrib-hdl-diagrams/issues/94


chore(github): update code owners

Description
Remove Aurélien Gasser
Also split it in two lines like the orchestrator. Maybe we could remove the veterans to stop showering them in notifications?

Closing the PR as it has been done here https://github.com/Substra/substra-backend/pull/568


en/disabledTimeIntervals

As of #644 we can disable time intervals using disabledTimeIntervals, as in any other option making enabledTimeIntervals available would also be useful; e.g. times between May 10 at 1:00PM and May 11 at 2:00PM should only be enabled.
Or is there a built-in way to do this?

I also would like this

I would love too !

Please! I need it.
How you guys are currently dealing with this?


matrix conditions

Is it possible to execute a pipeline step if
branch = master AND event = push
OR
event=pull_request

when:   branch=master   status=success   event=push orwhen:   event=pull_request   branch=feature/*


⚠ Bofrost.de has degraded performance

In 049c041, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1447 ms

Resolved: Bofrost.de performance has improved in b9a7b20 after 42 minutes.


disallows exponential operator with BigInt for targets lower than ES2016

Fixes #30398

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Leko sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@ajafff @DanielRosenwasser Thank you for the review! I fixed code problems.

(Rebased and updated)


Update to GA4

Context: Follow the update of LightningQubit and LightningGPU PRs https://github.com/PennyLaneAI/pennylane-lightning-gpu/pull/126 and https://github.com/PennyLaneAI/pennylane-lightning/pull/469
Description of the Change: Update GA id in docs
Benefits:
Possible Drawbacks:
Related GitHub Issues:

changelog?


Refactoring: change from linuxes to elinux - step1

I changed the following.

Remove linuxes from the file name
Rename LinuxesEGLSurface to ELinuxEGLSurface

@taka-okayama Can you review my PR?


Generalize page.waitFor, make waitForSelector a utility on top of it.

Rationale: waitForSelector is rarely useful on its own. I have a DOM element, but it is off screen / display:none, etc.
We can make waitFor generic and execute it either upon every task (by default) or upon tasks that had specific activities in them (optional).

utilitites.waitForSelector = (selector) => {
  return page.waitFor(() => document.querySelector(selector), ['style'], selector);
}

utilitites.waitForLayout = () => {
  return page.waitFor(() => true, ['layout']);
}

utilitites.waitForFrame = () => {
  return page.waitFor(() => true, ['frame']);
}

Any news about...?
// wait for the 'body div' to be present and visible in the page:
await page.waitForVisible('body div');

This would be a great addition.

I stuck on scenario when modal occurs and a button should be clicked. page.waitForSelector with flag visible: true does not work in this situation. The only way is to set timeout but I hate those


Moving to Emscripten Docker

Move the build scripts to use the official Docker image instead of people having to install and configure Emscripten (emcc, em++) locally.

Great idea! Thanks! I think I will do the same for other similar projects :)


Edit UG to include line break

Codecov Report

Merging #262 (d2af4a7) into master (d12046b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #262   +/-   ##
=========================================
  Coverage     56.33%   56.33%
  Complexity      765      765
=========================================
  Files           161      161
  Lines          3305     3305
  Branches        363      363
=========================================
  Hits           1862     1862
  Misses         1317     1317
  Partials        126      126

Impacted Files
Coverage Δ

...ress/logic/commands/groups/DeleteGroupCommand.java
100.00% <ø> (ø)

...ddress/logic/commands/groups/ViewGroupCommand.java
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899084b...d2af4a7. Read the comment docs.


Question: How do you recommend adding notes to a recipe?

Should I add it as a list in the metadata section?

Ideally yes, but it would sort of be considered a description at that point. Unfortunately the Cooklang spec doesn't include an option for notes, but it does include an option for comments. So if you need to add notes to a recipe either do it via the metadata or via comments.


Why covered_percent return 100% on no files or no lines covered?

This is more of a question (though I personally think this is a bug). Why even no code (no lines) written (just gem skeleton with testing setup) SimpleCov reports the following:
Coverage report generated for RSpec to /path/to/coverage. 0.0 / 0.0 LOC (100.0%) covered.

Just to make sure others can reproduce the in question behavior of SimpleCov, here are the steps to reproduce:
Steps to reproduce

Generate a gem via bundle.
Use RSpec for testing.
Use SimpleCov for code coverage.
Then, in spec_helper.rb comment out require "counter" line

require 'simplecov'
SimpleCov.start

require "bundler/setup"
#require "counter"

RSpec.configure do |config|
  # Enable flags like --only-failures and --next-failure
  config.example_status_persistence_file_path = ".rspec_status"

  config.expect_with :rspec do |c|
    c.syntax = :expect
  end
end

Run bundle exec rspec

Current Behavior

After running last step, you will see this text at the bottom:

Coverage report generated for RSpec to /path/to/coverage. 0.0 / 0.0 LOC (100.0%) covered.

Even, simplecov-html is using the wrong percentage:

Expected Behavior (in my opinion)

It should not display (100.0%) covered.
It should rather put a notification saying (for lack of better text):

Coverage report generated for RSpec to /path/to/coverage. 0.0 / 0.0 LOC covered. Did you correctly setup SimpleCov?

In the reproduce steps, counter file is not required after SimpleCov.start so it will not be covered hence should aptly notify correct coverage numbers and say  something (in this case counter not required) is incorrectly configured/setup.
simplecov-html should report No Files covered as header text instead.

Related ruby and gem versions
ruby 2.4.0p0 (2016-12-24 revision 57164) [i686-linux]

simplecov (0.14.1)
  docile (~> 1.1.0)
  json (>= 1.8, < 3)
  simplecov-html (~> 0.10.0)

Investigation
I checked the code and I found that covered_percent is the related method which is defined as:
# Computes the coverage based upon lines covered and lines missed
# @return [Float]
def covered_percent
  return 100.0 if empty? || lines_of_code.zero?
  Float(covered_lines * 100.0 / lines_of_code)
end

Why return 100.0 if empty? || lines_of_code.zero? is evaluated to true?
I'll be happy to create a PR to return 0.0 instead of 100.0 and as well fix output_message and html view in simplecov-html gem. cc @colszowka @PragTob

:wave:
thanks for your interest :) Imo it is not a bug although I had to think about it when I first came across it. Iirc it also applies to singular files. Think about files that are fully ignored or files that are just comments (aka no relevant lines) - should they show up as uncovered aka 0%? I don't think so, they would be marked as red in the html formatter which is like "this is an action item, go fix it!" but there is nothing to fix. Even more, let's say I got one 0/0 file and the rest of my code is 100%. Total coverage would show as 100% - which is correct, but then the one 0/0 file would show as 0% which is really confusing imo.
As for the case when the whole project is 0/0 - I agree it's more weird there and one could go either way on it. But I'd prefer it to be consistent with the single file instead of special casing it. I believe the 0.0/0.0 and total lack of any coverage data should be a big enough hint for anyone to see that something isn't setup correctly :)
On another note I agree though, if someone accidentally starts ignoring their whole code base (yay regexes!) the minimum_coverage option won't make it fail. But that is also difficult/can't solve everything - i.e. if just a file with little code is in there and covered - like 2 lines, then the rule won't apply although it's inherently the same problem.

Cool, thanks for explanation! 👍🏼 Will close this ticken then.


Access problem to @triply dependencies

@LaurensRietveld It's not possible to install the latest version, because the @triply/* dependencies can't be installed. I got redirected to a login screen, when I tried to access the packages in the npm web interface. Maybe the packages only need to be marked public.

Hi @bergos , thanks for letting me know. These packages weren't needed to build yasgui, but were mistakenly included in the package.json file. The newest version (2.7.22) on npm shouldnt have this issue


Undefined constant B

The code at http://play.crystal-lang.org/#/r/bxk throws an undefined constant B error, when that makes no sense.

Error is strange. In your case you still can use self there:
http://play.crystal-lang.org/#/r/bxo
--
Best Regards,
Alexey Fedorov,
Sr Ruby, Clojure, Crystal, Golang Developer,
Microservices Backend Engineer,
+49 15757 486 476
2015-08-19 5:05 GMT+03:00 stugol<EMAIL_ADDRESS>
The code at http://play.crystal-lang.org/#/r/bxk throws an undefined
constant B error, when that makes no sense.
—
Reply to this email directly or view it on GitHub
https://github.com/manastech/crystal/issues/1226.

Very true. Thanks.
Still needs fixing though, don't you think? ;)

Yeah. Don't know if it should compile here or not, though. And if not, how
error should sound.
--
Best Regards,
Alexey Fedorov,
Sr Ruby, Clojure, Crystal, Golang Developer,
Microservices Backend Engineer,
+49 15757 486 476
2015-08-19 5:27 GMT+03:00 stugol<EMAIL_ADDRESS>
Very true. Thanks.
Still needs fixing though, don't you think? ;)
—
Reply to this email directly or view it on GitHub
https://github.com/manastech/crystal/issues/1226#issuecomment-132423052.

I tried to reduce it, seems to apply to any nested generic with a free variable in a return type restriction: http://play.crystal-lang.org/#/r/by6


[WCCMMUD] MajorMud - Game Crashes when editing Sysop Bulletin

Module Information

Identifier: WCCMMUD
Module Name: MajorMud
Version: 1.11g

Describe the bug
Try to edit Sysop Bulletin and game crashes
To Reproduce
Steps to reproduce the behavior:

Drop in generic ANSI file and name WCCSYSOP.BUL in MAJORMUD module directory
Enter MajorMud module
Enter "SYSOP" for sysop commands
Select "B" to edit Sysop Bulletin
See Error

Expected behavior
Edit ANSI file
Screenshots
Unhandled exception. System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'Unsupported OpCode: Fsubr')
   at MBBSEmu.HostProcess.ExecutionUnits.ExecutionUnit.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.Module.MbbsModule.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassSetState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.HostProcess.MbbsHost.WorkerThread()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ThreadHelper.ThreadStart()

Software Information:

OS: Windows Server 2019 Standard
Telnet Client: NetRunner

Missing FSUBR OpCode
https://www.felixcloutier.com/x86/fsubr:fsubrp:fisubr

Error now:
Unhandled exception. System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'Unable to locate FFFF:04A7')
at MBBSEmu.Memory.MemoryCore.GetArray(UInt16 segment, UInt16 offset, UInt16 count)
at MBBSEmu.Memory.MemoryCore.GetPointer(UInt16 segment, UInt16 offset)
at MBBSEmu.HostProcess.ExecutionUnits.ExecutionUnit.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassState, Queue1 initialStackValues, UInt16 initialStackPointer)    at MBBSEmu.Module.MbbsModule.Execute(IntPtr16 entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassSetState, Queue1 initialStackValues, UInt16 initialStackPointer)
at MBBSEmu.HostProcess.MbbsHost.WorkerThread()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location where exception was thrown ---
at System.Threading.ThreadHelper.ThreadStart()

@enusbaum @paladine  Please reopen issue (I don't think I have permission)


dispose method not getting called

In my main page, I have two tabs, named tab 1 and tab 2. When switch to tab 2, it has an icon on upper right corner.When icon is clicked, it will open page C.
I notice when I switch from tab 1 to tab2, it will call dispose in tab 1. When I switch from tab 2 to tab 1, tab2 dispose will be called.
However when I click the icon in tab 2 to navigate to page c, dispose in tab 2 is not getting called. How can I make dispose method called when I click the icon to navigate to page C?
I use Navigator.pushReplacementNamed(context,                                     Page.C.ROUTE) and dispose in tab 2 getting called. But the problem is when I trying to back from page c to main page, my app is closed. How to make it back to main page?

Hi @tony123S
This platform is not meant for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

help please


Mention that FAS account can't be private for verification

Related to https://github.com/packit/packit-service/issues/1574 (even though that's not exactly the issue)

RELEASE NOTES BEGIN
Packit now guides everyone better when a FAS account is private and updates internally the information about installations correctly when the app is reinstalled.
RELEASE NOTES END
Edit ttomecek: I filled this, PTAL :)

@TomasTomecek except for the changes we discussed, I implemented it in the way that if the namespace was once approved and then reinstalled, we won't create a new notifications issue and request new verification, WDYT?


Support highlighting of arbitrary strings in within javascript files

More often than not, I have GraphQL queries in my JS code itself (which is a better pattern for solutions like postgraphile, hasura).
Right now, the plugin does not highlight strings such as:
export const mutation = email => `mutation insert_email_to_waitlist {
  insert_waitlist(
    objects: {
      email: "${email}"
    }
  ) {
    affected_rows
  }
}`;

Highlighting such strings would be a great addition to the plugin 🚀

Hi Aditya,
Thanks for using the plugin.
Detecting GraphQL in arbitrary JS strings would require running the GraphQL parser over all strings, resulting in a performance hit in all JS editors.
I recommend you use a language injection comment: //language=GraphQL
This comment is picked up in the same way as the graphql/gql tagged templates, causing the editor to consider the next template string as GraphQL.
//language=GraphQL
export const mutation = email => `mutation insert_email_to_waitlist {
  insert_waitlist(
    objects: {
      email: "${email}"
    }
  ) {
    affected_rows
  }
}`;

Best regards,
Jim


middleware: introduce WASM

Description
Basic WASM HTTP middleware implement.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: https://github.com/dapr/components-contrib/issues/1171
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

I will update the docs after the code is ready.

@daixiang0 why did you close?

It is a test branch, so please see #1747.


combine_obs_healpix needs updating

combine_obs_healpix needs to be updated to conform to the new file structure.
combein_obs_hpx_image will probably need updating too.

What is the problem with Stokes parameters conversion? Running on v3.0-325-gb345644, FHD produces combined healpix cubes of stokes I and Q if using 2 polarizations. This seems to be correct.

Combine_obs_healpix produces "Stokes" images by simply adding or subtracting the instrumental xx and yy (and xy, yx) images after correcting for the primary beam. The correct approach is to calculate the Jones matrix for each pixel to perform a proper rotation. I expect this issue to be corrected soon.

This was fixed back when version 3.5 was released. Closing now.


Add test for finding g-ir-scanner through pkg-config

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes #19.

As described in #19, downstream builds using meson are sensitive to having the build prefix detected and replaced correctly so that they can call g-ir-scanner. They do this by querying pkg-config to get the path for g-ir-scanner. This adds a test to make sure that finding the path for g-ir-scanner through pkg-config works (i.e. the prefix is replaced correctly in the pkg-config file so that the path provided actually refers to the testing environment and not the build environment).
This passes locally for me using conda-build=3.19.1, and hopefully it passes on the cloud. If not, then we've definitely confirmed that the prefix replacement issue on Windows is not fixed by 3.19.1 when building with the CI infrastructure.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or Other) nor an SPDX license expression.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or Other) nor an SPDX license expression.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

This passes locally for me using conda-build=3.19.1, and hopefully it passes on the cloud. If not, then we've definitely confirmed that the prefix replacement issue on Windows is not fixed by 3.19.1 when building with the CI infrastructure.

So this does fail for the Windows build on Azure, and the logs do indeed show that no text prefixes were replaced. Strange that this is a difference between a local and cloud build.

@ryanvolz Are you able to compare your build output with the cloud output and see if any differences in slash direction are creeping in the environment? That's my best/only guess for how you can get different results in the CI vs. locally ....

On Azure, the build produces a prefix in gobject-introspection-1.0.pc of:
"D:/bld/gobject-introspection_1584652937805/_h_env/Library"

Locally, this is:
"C:/Users/rvolz/Miniconda3/conda-bld/gobject-introspection_1584636680079/_h_env/Library"

So not much of a difference, and the path separators are the same.

It's just so bizarre to me that you're seeing different results with local vs. cloud if both seem to be using the same versions of things. Unfortunately I'm not able to effectively explore things on Windows under the current conditions, so I'm not sure how much I can help :confused:

I'll plan on doing a closer comparison tomorrow and also cast a wider net to see if anyone else can help. It's perplexing.

@pkgw Any objections to merging this with a temporary pin to conda-build=3.18.11 while the bug is dealt with? The pin will be undone by a rerender, and the test will ensure that no builds with the same problem go out again.

No, not at all, I think a temporary pin seems like a good way to go. This is mergeable as-is, right?

No, not at all, I think a temporary pin seems like a good way to go. This is mergeable as-is, right?

Yes.


Document changes to Apache config?

To get the OPAC scripts to do anything I had to add this to my Apache site config:
   ScriptAlias /plugin/Koha/Plugin/EDS/opac /var/lib/koha/prv/plugins/Koha/Plugin/EDS/opac
   Alias /plugin "/var/lib/koha/prv/plugins"
   # The stanza below is needed for Apache 2.4+
   <Directory /var/lib/koha/prv/plugins>
      Options Indexes FollowSymLinks
      AllowOverride None
      Require all granted
   </Directory>

Is that considered to be part of enabling plugins in Koha, or should it be documented somewhere?

There is some documentation on Apache-Setup in the wiki for Debian and Ubuntu.
https://github.com/ebsco/edsapi-koha-plugin/wiki/Apache-Setup
Thanks for sharing this config too Magnus - I have added a link from that Wiki entry to this issue too.


How to add support for a custom in-house HTTP requests library?

Hi!
In Tribler torrent client Qt-based GUI uses our custom Qt-based HTTP requests module to connect to the core process. We would like to automate GUI testing by using vcrpy library to record its communications with the core. However, vcrpy obviously does not support our in-home requests module.
What would be the best strategy to capture the requests with vcrpy in this case (in-house custom HTTP requests module)?
Thanks

Hi @ichorid
Great question!
I'm a part time maintainer and not the original author but I hadn't seen this feature until just now but it looks like you can:
VCR(custom_patches=(obj, patched_attribute, replacement_object))

https://vcrpy.readthedocs.io/en/latest/advanced.html#custom-patches
Which passes it onto Cassette. Then applies it during CassettePatcherBuilder.
The mocked triple is a tuple of the same args that mock.patch.object accepts.
https://docs.python.org/3/library/unittest.mock.html#patch-object

I hope that is helpful. I'm going to mark this as closed for now but please feel free to comment or reopen if there is more that we can help you with.
Kind regards
Josh

Hello,
I'd like to set up vcrpy for a project that uses the agithub.API class to make requests (see https://github.com/mozilla/agithub/blob/9f44e8f862161dd5f5b6f65ee812e173291b5132/agithub/base.py).
However, I can't seem to figure out the appropriate way to set up the custom_patches. Any pointers on how this can be done?
So far, I've tried (where api is an instance of agithub.API):
my_vcr = vcr.config.VCR(custom_patches=((api, 'client', VCRHTTPSConnection),))
my_vcr = vcr.config.VCR(custom_patches=((api.client, 'request', vcr.request.Request),))
my_vcr = vcr.config.VCR(custom_patches=((api.client, 'request', vcr.stubs.VCRHTTPSConnection.request),))

If @neozenith is still involved with this project, maybe you would have a suggestion?
I'm on vcrpy 4.1.1, agithub 2.2.2, Python 3.9.4. Let me know if there is anything else I can provide.
Thanks!


fixed a typo: ' instead of `

Codecov Report

Merging #5377 (e54a9e8) into 1.4 (aaee6ab) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head e54a9e8 differs from pull request most recent head 2b1c820. Consider uploading reports for the commit 2b1c820 to get more accurate results

@@            Coverage Diff            @@
##                1.4    #5377   +/-   ##
=========================================
  Coverage     63.53%   63.53%
  Complexity     1399     1399
=========================================
  Files           195      195
  Lines          4136     4136
=========================================
  Hits           2628     2628
  Misses         1508     1508

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10957c7...2b1c820. Read the comment docs.


BTTV problem

H there!  I love that you created this alternative to using Stream Elements, because aside from their bad politics it was annoying that it was going down all the time and I was constantly having to reconnect to the service.
I only have one problem. The event kappagens are using my BTTV emotes first instead of my Twitch emotes. Is there a way to either switch the order that emotes are chosen or disable BTTV only for events but still allow them for a command kappagen? Thanks!

I'm not sure what you mean by "first" -

The priority order for emotes with identical names are:

Direct URL
Bit Cheers
User-specific emotes (usually from third-party subscriptions)
First-Party (Twitch/YT/Kick) Channel Emotes
Third-Party Channel Emotes
First-Party Global Emotes
Third-Party Global Emotes
Emojis

Meaning that if you have a Twitch Channel emote with the same name as an FFZ, BTTV, or 7TV emote, the Twitch one will be the one that's used.

If you mean the randomly selected emotes that occur with a kappagen command or event, there is no order - it's literally just a 100% random selection of all your Channel emotes, both first and third party.
For advanced control over exactly which emotes are used for which events, the Wizard has an "Emotes" list for each event and kappagen animation style in the advanced settings, which lets you enter any emote names, Emojis, or even direct URLs,, separated by spaces, which will be used as the pool to randomly choose from instead.

Hi, what I mean is that ALL of my emotes that show for events are from third party and none of my twitch ones show up at all. I guess I need to just configure set emotes to use. Thanks!

Ok, I looked but I don't see a way to have ONLY my twitch emotes pop up for an event in the wizard, I'm only seeing the animation style. I want folk to be able to use BTTV to do their own kappas, but I don't want any of those in my event kappas. I'm going to have to turn off all the event kappas because it's just annoying me at this point.

This sounds like the symptoms of a bug that was resolved two months ago. If you are using the HTML file, a simple update might fix your issue.
You can control the advanced settings for any kappa animation style (or all enabled styles at once) using the advanced buttons: https://omnimg.realityripple.com/vw5CYn.gif
Choosing which emotes you want to use for an event is done with a list, as I said: https://omnimg.realityripple.com/RepLiZ.gif


Bazel support: java_binary rule conversion [phab:D183]

Created by schroederc at 2015-04-14 22:09:35:

zarko accepted this revision at 2015-04-15 00:09:30

schroederc closed via commit 3409b8ccffdc86e920c20e68c5921b6d8d05f6ab at 2015-04-15 15:49:03


CJS warning

Steps to reproduce:

Create a new vite app: yarn create vite. Select Vanilla and JavaScript to keep it as simple as possible
Create a vite.config.js:

import { defineConfig } from 'vite';
import devManifest from 'vite-plugin-dev-manifest';

export default defineConfig({
    plugins: [
        devManifest(),
    ],

    build: {
        manifest: true,

        rollupOptions: {
            input: 'src/main.js'
        }
    }
})

Run vite build or vite dev and you get the following error:

failed to load config from C:\Git\personal\dev-manifest\vite.config.js error when starting dev server: TypeError: devManifest is not a function

You can get around the error by removing "type": "module" from the package.json. However, this results in the following warning:

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
Versions:
Node 20.1.0
Yarn 1.22.19
Vite 5.0.10
vite-plugin-dev-manifest 1.3.0

I read a little bit into it starting from a Stackoverflow issue (https://stackoverflow.com/questions/42708484/what-is-the-module-package-json-field-for) and it seems like having a "main" and a "module" field" in package.json should work. It is not an official standard, but so widespread that it should work anywhere.
The NodeJS way (TM) seems to be conditional exports: (https://nodejs.org/api/packages.html#conditional-exports). I patched this in my node_modules folder and got it to work without errors or warning, but I don't know if this would have unintended side effects.

Please add the exports fields to package.json, it solves the issue:
"exports": {
    ".": "./dist/index.mjs"
},

Without this, node will import the cjs as it's set in the main field.

@sgarcialaguna-mms as a temporary workarround, i had to change the import statement to
import devManifest from 'vite-plugin-dev-manifest/dist/index.mjs';


Port for T-Dongle-S3

Hallo,
do you know if the Launcher ist compatible with the T-Dongle-S3?
(https://www.lilygo.cc/products/t-dongle-s3)
It uses a ST7735 display and has a ESP32-S3 Xtensa LX7 as MCU.

Not yet...
I'm planning a new version where you'll be able to use the Launcher on "any" esp32 (and s3).. by launching the Web User Interface..
It would "solve" the UI porting issue and the necessity of at least 3 btns to use the Launcher..
I believe I will release this version in a few days, and I'll tag this issue on that, and this other too
https://github.com/bmorcelli/M5Stick-Launcher/issues/51

Thank you for this fantastic answer! I'm really looking forward for the new release.
Best regards!

I've made a "Headless" ESP32-S3 version that might be useful for this device...
You will flash the option "Espressif - ESP32-S3-16mb in the web flasher

After first flash, it'll be asking for restart, on serial Monitor, so unplug and plug again from USB
Now, it will turn On, and if you press the GPIO 0 btn (boot btn ) within the first 5s, it will enter the launcher, otherwise it'll go to the previously installed firmware (by Launcher)..
if you can, use a serial Monitor Application to follow the instructions
the first time, it will star the WebUi in access point mode, so turn off mobile data and connect to Launcher wifi access point.
access http://<IP_ADDRESS> or http://launcher.local in your browser
when the page opens, login is "admin", pwd "launcher"
in the web user interface (WebUI), you can:

configure the SD pins to read the SDCard (need restart to work)
configure your network to access the launcher from your computer in your home network (need restart to work)
manage your SDCard, and
install firmware using OTA Update option, using binary files compatible with your device


[Backport] Release acquired sessions for cp session_semaphore if the invocation fails

Backported the fix https://github.com/hazelcast/hazelcast/pull/17826
Releases acquired sessions for cp session_semaphore if the invocation fails.

Linux test PASSed.

Windows test PASSed.

Linux test PASSed.

Windows test PASSed.

closing for now. To be done int he future.


How to tell if a task can be used in Server Jobs or Agent Jobs?

I am creating a Deployment Job. One of the steps is to run a Docker container from an image using docker command line. I tried both Bash@3 and CmdLine@2 and they are not allowed to use in Server Job. The command line needs to be run on the target server so I set pool of the deploy hook to be server.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e7ba5cf3-d229-03d0-ad6a-a30a0379afc0
Version Independent ID: ccffed3b-ea44-517f-f7a8-a1c4c4147495
Content: Catalog of the built-in tasks for build-release and Azure Pipelines & TFS - Azure Pipelines
Content Source: docs/pipelines/tasks/index.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @steved0x
Microsoft Alias: sdanie

@xtu  Thank you for the question.
Please refer to the phases doc which was recently updated with a server job task list, under issue https://github.com/MicrosoftDocs/azure-devops-docs/issues/4672.
You can alternatively invoke the REST API as per https://github.com/MicrosoftDocs/azure-devops-docs/issues/4672#issuecomment-534023895.