Camera Keeps Frezzeing

After a little bit, the camera on will freeze and I’ll have to switch tabs to get it to unfreeze

I've also been seeing this - getting a "Request timed out" error. Can reconnect to the stream straight away, but will freeze and time out within about 5 seconds or so

Hi guys,
Thanks for sharing this issue. I would like to be able to reproduce this so would appreciate more information. Could you describe more how you're using the app that lead to this? For instance, I opened the app while I was in the wifi and when I left home with the app still running the video froze when it lost the wifi connection.  Any screenshots would also help. Does the video work when you tap on the refresh icon?
Thanks,
Gaston

For me it happens when using the app over wifi, pretty much as soon as I open it. Sometimes it will go for up to 30 seconds before losing the feed but usually around 5s. Other functions of the app are not affected (stats etc. update and controls are responsive). The video does come back after refreshing but disconnects again shortly after.

That @rodlord5000, so to confirm I understood correctly. The video works fine and while watching the camera you then get an error saying that "Request time out"? You then press refresh and works again and then it stops again?
One last question, was this working well in previous versions of the app?
Thanks,
Gaston

Thanks @rodlord5000, so to confirm I understood correctly. The video works fine and while watching the camera you then get an error saying that "Request time out"? You then press refresh and works again and then it stops again?
One last question, was this working well in previous versions of the app?
Thanks, Gaston

Yes that's correct, I have only just started using this app last week so I can't say if there was a difference in a previous verison unfortunately.

Thanks @rodlord5000 for this info. I helps a lot to start troubleshooting this. By the way, would it be possible to share a screenshot when you see this error? Maybe there is something else that could help me.
Thanks,
Gaston

Thanks @rodlord5000 for this info. I helps a lot to start troubleshooting this. By the way, would it be possible to share a screenshot when you see this error? Maybe there is something else that could help me.
Thanks, Gaston

Sure thing

@rodlord5000, I see that the first screenshot (when things were working well) was in the Panel page and the second screenshot is when you went to the Move page. If you were going to stay in the Panel page, does the error appear after the camera was streaming fine? Second question, if you press the refresh icon does the video start working?
Thanks,
Gaston

@rodlord5000, I see that the first screenshot (when things were working well) was in the Panel page and the second screenshot is when you went to the Move page. If you were going to stay in the Panel page, does the error appear after the camera was streaming fine? Second question, if you press the refresh icon does the video start working?
Thanks, Gaston

Yes it does, I was just moving the plate around to see if it stopped as the refresh prompt can take a while to appear. The video does start working again after a refresh but then soon stops.

@rodlord5000, by any chance are you using a reverse proxy (e.g. nginx) to connect to your OctoPrint instance? If you have one, I wonder how it's configured to support long-lived connections.

@rodlord5000, by any chance are you using a reverse proxy (e.g. nginx) to connect to your OctoPrint instance? If you have one, I wonder how it's configured to support long-lived connections.

Yes I use Caddy, the config is as follows:
octoprint.example.com {         reverse_proxy octoprint:5000 }
This has been working well with Cura and the Octoprint web page, but looking at the documentation there is a separate directive for the webcam path - could this be causing the issue?
octoprint.example.com {         handle_path /webcam/* {                 reverse_proxy localhost:8080         }         reverse_proxy localhost:5000 {                 header_up X-Forwarded-Proto {scheme}         } }

@gdombiak I've done some testing without using the proxy and it seems to work OK. Will keep an eye on it tonight to see if it keeps working

@gdombiak I've done some testing without using the proxy and it seems to work OK. Will keep an eye on it tonight to see if it keeps working

No disconnections while not using the proxy (which is not essential to my setup), so all good here

Thanks @rodlord5000 for the update. It's great to hear that we narrowed it down to the proxy. I think that I might have a solution for this that might help others that do require this proxy. I will see if I can install that reverse proxy (I use ngnix) and see if I can confirm the fix works fine. Worst case, would you be ok testing a beta version to see if it works with your proxy?
Gaston

Thanks @rodlord5000 for the update. It's great to hear that we narrowed it down to the proxy. I think that I might have a solution for this that might help others that do require this proxy. I will see if I can install that reverse proxy (I use ngnix) and see if I can confirm the fix works fine. Worst case, would you be ok testing a beta version to see if it works with your proxy?
Gaston

Sure thing

@rodlord5000, I installed caddy (via docker) and configured it with something like this:

:80 {
handle_path /webcam/* {
reverse_proxy http://<IP_ADDRESS>:8081
}
reverse_proxy http://<IP_ADDRESS>
}

I'm not able to cause the request timeout error. :( Later in the week I will share a beta version for you to try and confirm wether the fix worked or not.
Thanks again,
Gaston

Hi @rodlord5000 , new release is out and I'm curious to hear if that solved the issue when using Caddy. Let me know how it goes if you get a chance to test it.
Thanks,
Gaston

Hi @gdombiak, can confirm it is working thanks :)


Parse and validate valid license expressions

LicenseFinder should be able to parse and validate SPDX License Expressions, as they get more commonly adopted in supported packages, like RubyGems and NPM packages.

Closes https://github.com/pivotal/LicenseFinder/issues/509


Add README.md

Add documentation, and set a latest tag along with 3.5 when building
the container.

cc @fancyremarker @aaw

Excellent. Looks great! Merging.


addListener add even if already exist

I don't understand why the code don't detect I have already add the same Listener for a specific string.
The "indexOfListener" function try to compare if listener already exist by comparing the function.
function indexOfListener(listeners, listener) {
    var i = listeners.length;
    while (i--) {
        if (listeners[i].listener === listener) {
            return i;
        }
    }

    return -1;
}

I must add .toString() to the listeners to be able to compare them.
" if (listeners[i].listener.toString()  === listener.toString()) {
My test listeners are as simple as : function() { alert('test'); }
listeners[i].listener return apparently the string in the console.log, and listener too.
But === only work using toString()....
Can you understand what I do badly ? I test on the latest chrome.

I'm not sure what the problem is here I'm afraid. Adding two listeners
under the same event name is perfectly valid, or is that not the issue? I
may be misunderstanding.
On Tue, 9 Apr 2019, 18:20 SimplyLab<EMAIL_ADDRESS>wrote:

I don't understand why the code don't detect I have already add the same
Listener for a specific string.
The "indexOfListener" function try to compare if listener already exist by
comparing the function.
function indexOfListener(listeners, listener) {
var i = listeners.length;
while (i--) {
if (listeners[i].listener === listener) {
return i;
}
}
return -1;

}
I must add .toString() to the listeners to be able to compare them.
" if (listeners[i].listener.toString() === listener.toString()) {
My test listeners are as simple as : function() { alert('test'); }
listeners[i].listener return apparently the string in the console.log, and
listener too.
But === only work using toString()....
Can you understand what I do badly ? I test on the latest chrome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Olical/EventEmitter/issues/151, or mute the thread
https://github.com/notifications/unsubscribe-auth/AATPXQKEfIykKMwSlEGL6Bld7oJ88BJgks5vfMvNgaJpZM4clA_u
.

Thanks. My question was not clear.
If I look at the API documentation we can see that :

addListener
Adds a listener function to the specified event.
The listener will not be added if it is a duplicate.  <==== That is the problem
If the listener returns true then it will be removed after it is called.
If you pass a regular expression as the event name then the listener will be added to all events that match it.
param (String | RegExp) evt - Name of the event to attach the listener to.
param (Function) listener - Method to be called when the event is emitted. If the function returns true then it will be removed after calling.
return (Object) - Current instance of EventEmitter for chaining.
We can see that "The listener will not be added if it is a duplicate. "
So calling at 2 differents place, for example ee.addListener( 'myEvent', function() { alert('Hi');} ) will not drive to have 2 duplicates trigger for "myEvent".
Looking at the source code, i found the function indexOfListener(listeners, listener) who try to find in the listerners array, if a function is already "registered". If yes, it will not create a new listener.
But, the indexOfListener(listeners, listener) work only if I add "toString()" after my functions. If not, it consider that function() { alert('Hi'); and function() { alert('Hi'); are not the same.

Yes, this is because these are not the same:
// This is false.
function () { return 1 } === function () { return 1 }

const f = function () { return 1 }

// This is true.
f === f

If you're creating functions through the literal syntax and not reusing the reference to them each function will be a different function. It may do the same thing, but it's a new function instance. If you want to reuse the same reference, store it in a var/let/const as shown above.

Ho, ok ! It's perfectly clear.
Thank you !

No problem! 😊
On Tue, 9 Apr 2019, 23:38 SimplyLab<EMAIL_ADDRESS>wrote:

Closed #151 https://github.com/Olical/EventEmitter/issues/151.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Olical/EventEmitter/issues/151#event-2264419233, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATPXfLnT-51_gdSocPCfhbDDoiG6oOqks5vfRZXgaJpZM4clA_u
.


[BUG]: Admin | Compliance detail request fails when no owner is found

Describe the bug
This flow appears to fail when an app has no owner.
ActionFailed. An action failed. No dependent actions succeeded.
Error:
Action 'Condition:_Audit_apps_that_are_broadly_shared' failed
Component (please tell us which flow or app you are experiencing issues with):

Solution: CenterofExcellenceAuditComponents_1_25_managed
Version 1.25
App: Admin | Compliance detail request

To Reproduce

Run flow against all apps.
Any app with no owner will cause the described error during the Send an email (v2) action.

Expected behavior
I would expect the flow to account for this by providing the AdminEmail env var when an owner is not found.
Screenshots

Thanks for using CoE and for posting such an actionable issue.
Due to competing priorities we likely wont get this fixed before next release, so I just wanted to be sure you knew about the Set App Ownership canvas app in the Core Solution.
It will allow you to find and fix up these orphans with a new owner so that you can proceed with the governance while you await a fix to the toolkit.
Our fix will likely just be assigning out the email to the admin address.

Hi @JeneferM-MSFT ,
Thanks for the response. I did try that but none appear under orphaned.
I think the problem may lie in Dynamics apps, many of which have no owner. But I can't be sure.

Ah that makes sense. Yes we do not support model driven apps in that canvas app as we aren't exposed with a backend to support changing such things as owner.
Note that the information about what is orphaned is captured in the CoE though, even for model driven apps.
If you export the data in the PowerApps Apps table, you can filter to orphaned model driven apps.
Thanks again for posting.

Hi @JeneferM-MSFT,
Thanks for the tip. I have adjusted the filter query in the List Apps action to ignore 'Model Driven' apps.
_admin_appowner_value ne null and admin_appownerdisplayname ne 'SYSTEM' and admin_powerappstype ne 597910001
This has resulted in fewer apps but I still received a failed delivery because the app owner is an admin and doesn't have an Outlook license. :\
Is there a simple way to check for this, or simply continue in the event of a single delivery failure?

If you look in the flows we have in Core you will see the solution we have for this, and you can add it here if you'd like while you await our fix:
This example from (Custom Connectors) but its in all these flows

Basically you can switch on the status code of that call and do something different when it fails (the user no longer exists)

Thanks Jen.
I wound up just adding a second email action and configured its "run after" settings for skipped or failed. Works like a charm.

Wonderful. We will hold this open until we fix to ship.

I have this local fixed for next release

I have this local fixed for next release

This fix seems to have gotten lost and is not available in the Feb update.
Apologies. I will work to re-implement.

ok this is there after all, I hadnt removed my unmanaged layer :)
Thanks again.


Generate API documentation

Need to hook up jazzy.
Place the following file in the root of the repo:
.jazzy.yaml
module: MaterialMotionRuntime
umbrella_header: src/MaterialMotionRuntime.h
objc: true
sdk: iphonesimulator

Jumping on this.

🎊 My diff is ready for review at http://codereview.cc/D1135


js: Detecting pulse input on browser

This is not intended to merge. Just showing how I tried to detect pulse input on browsers.
Tap works but there is a glitch for drag arised from this.
Sorry for commit messages.

Sorry for commit messages.

No problem: all commits will be squashed so please make commits as you like :-)

Just showing how I tried to detect pulse input on browsers.
Tap works but there is a glitch for drag arised from this.

I don't understand the intention of this PR yet.  Why can this detect pulse input?

Check the difference of behaviour of examples/paint on a browser with tap on macOS trackpad.

Tried but I couldn't notice the difference...

@1l0 Could you tell me how different they are?

On official example, single tap doesn't work sometimes for me.

Do you use a Magic Trackpad? I'm using a trackpad on a MacBook Pro, and I don't think there is a difference between them.
Perhaps, did you enable 'tap to click'? I didn't, and I'll enable it and try again later. http://osxdaily.com/2014/01/28/enable-tap-to-click-mac-trackpad/

Tap to click is enabled using MacBook trackpad.

Confirmed that your PR changed the situation.

In both cases, taps were ignored in most cases.
It looks like more taps could be recognized with your PR than the original state.
Strokes didn't end until the next tap with your PR

I understand a tap is treated as a click, but should this be treated as mousedown/up or drag events? I'm a little confused.

That's strange, taps are not ignored on this PR for me. Anyway yes this PR is not a sort of solution to fix something but my demand was just simply to detect a tap on my environment so perhaps you don't need to bother with it at all.


BUG: Generate events for ScriptableObject is broken

Hi,
I have found a bug in event generation. Generate a component for a ScriptableObject work as intended, but when I add an Event attribute the generation is broken.
Here's a simple example.
using Entitas;
using Entitas.CodeGeneration.Attributes;
using UnityEngine;

[Gameplay, Unique, Event(true)]
public class TilesBlueprints : ScriptableObject
{
	public string name = '"";
}

Actually, I use Entitas 1.5.2 with external code generation. I can reproduce this issue with 1.7.0.
Best regards,
David

Hi, yes that's true.
Event tags currently only work on components
https://github.com/sschmid/Entitas-CSharp/blob/develop/Addons/Entitas.CodeGeneration.Plugins/Entitas.CodeGeneration.Plugins/Component/DataProviders/ComponentDataProvider.cs#L96
I could probably add this to dataFromNonComponents, too.

Hi,
that will be great. :)


fix for issue 10303

fix for java.lang.NullPointerException
底层调用方法：
org.apache.dubbo.metadata.MetadataInfo#getValidServiceInfo
调用方：
org.apache.dubbo.registry.client.InstanceAddressURL#getServiceInfo
org.apache.dubbo.registry.client.ServiceDiscoveryRegistryDirectory#urlChanged
问题原因：底层调用方法会返回null，调用方没有判空，导致有可能造成空指针
解决方式：调用方增加判空逻辑

Codecov Report

Merging #10306 (6cd3547) into 3.0 (d0dc792) will decrease coverage by 0.07%.
The diff coverage is 17.85%.

:exclamation: Current head 6cd3547 differs from pull request most recent head c281395. Consider uploading reports for the commit c281395 to get more accurate results

@@             Coverage Diff              @@
##                3.0   #10306      +/-   ##
============================================
- Coverage     65.62%   65.54%   -0.08%
- Complexity      296      319      +23
============================================
  Files          1233     1233
  Lines         53714    53733      +19
  Branches       8110     8121      +11
============================================
- Hits          35248    35218      -30
- Misses        14626    14667      +41
- Partials       3840     3848       +8

Impacted Files
Coverage Δ

...ache/dubbo/registry/client/InstanceAddressURL.java
51.62% <17.39%> (-3.40%)
:arrow_down:

...stry/client/ServiceDiscoveryRegistryDirectory.java
48.80% <20.00%> (-0.48%)
:arrow_down:

...mmon/threadpool/support/AbortPolicyWithReport.java
73.68% <0.00%> (-10.53%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
58.33% <0.00%> (-8.34%)
:arrow_down:

...he/dubbo/remoting/transport/netty/NettyHelper.java
29.03% <0.00%> (-6.46%)
:arrow_down:

...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java
84.84% <0.00%> (-6.07%)
:arrow_down:

...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java
73.80% <0.00%> (-4.77%)
:arrow_down:

...bbo/common/concurrent/CallableSafeInitializer.java
61.90% <0.00%> (-4.77%)
:arrow_down:

...ubbo/common/system/OperatingSystemBeanManager.java
50.00% <0.00%> (-4.55%)
:arrow_down:

.../registry/zookeeper/ZookeeperServiceDiscovery.java
68.35% <0.00%> (-2.54%)
:arrow_down:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0dc792...c281395. Read the comment docs.


CHomP extension

I'm creating a small wrapper package CHomP.jl. The goal is to have access to CHomP via python, so that I can ask Marcio Gameiro for a basic sube map exampleand then just create code to convert to the python format automatically.

CHomP.jl is now a working julia package. It is extremely barebones and doesn't do anything other than install the python package and give access to it via Pycall.jl (in particular all users would essentially be using python), but it works. It was also surprisingly easy to set up.


/api/user/user_profile/ is not user specific

@Fareed95 please make sure that api/user/user_profile/ is user specific for getting pic data

done @thisisarsh1 check it


[Traefik Plugin Catalog] Plugin Analyzer has detected a problem.

The plugin was not imported into Traefik Plugin Catalog.
Cause:
failed to get the latest tag: invalid tag: 0.1.1 (this tag must be removed, see https://semver.org)

Traefik Plugin Analyzer will restart when you will close this issue.
If you believe there is a problem with the Analyzer or this issue is the result of a false positive, please fill an issue on piceus repository.

⚠ This issue has been automatically locked since there has not been any recent activity after it was closed.
Please open a new issue for related bugs.
I am a bot reaching out to you with an automated response.


creating permutations

I need permutations of [0,1,..,n-1]
So I tried to use the  function, deal in math.js.  First I had to include it in jme.js, along with randomint
new funcObj('randomint', [TNum], TNum, math.randomint);
new funcObj('deal', [TNum] , TList , math.deal);
randomint works but not deal
I then rewrote it as
//returns a random number in range [0..N-1]
randomint: function(N) {
	return Math.floor(N*(Math.random()%1));
},

//a random shuffling of the numbers [0..N-1]
deal: function(N)
{
	var J, K,L,  Q = new Array(N);
	for(var i=0;i<N;i++)
	{
		Q[i]=i;
	}
	for (J=0 ; J<N -1; J++)
		{ K = J+math.randomint(N-J) ; L=Q[J] ; Q[J]= Q[K] ; Q[K] = L; }
	return Q;
},

Still doesn't work.
If I ask for {deal(4)} I get [ , , , ]
Any obvious errors?

When you're constructing a TList, your list needs to contain TNum objects, not just normal javascript numbers. I've just committed a JME implementation of the deal function which does the conversion for you.
It would probably be good manners if the TList constructor did the conversion for you.

Thanks

-----Original Message-----
From: Christian Perfect [mailto:reply+i-3374117-
<EMAIL_ADDRESS>Sent: 24 February 2012 3:50 PM
To: Bill Foster
Subject: Re: [Numbas] creating permutations (#142)
When you're constructing a TList, your list needs to contain TNum
objects, not just normal javascript numbers. I've just committed a JME
implementation of the deal function which does the conversion for you.
It would probably be good manners if the TList constructor did the
conversion for you.

Reply to this email directly or view it on GitHub:
https://github.com/numbas/Numbas/issues/142#issuecomment-4159050


fix($typescript): Add ExtraGlamorousProps type as top-level export

What:
This adds the ExtraGlamorousProps type as a top-level export and adds a test for the underlying TypeScript issue it works around.

Why:
This fixes issues when using TypeScript with "declaration": true in combination with webpack.
Original TypeScript issue: https://github.com/Microsoft/TypeScript/issues/5938

[ts] Exported variable 'StyledPromiseCard' has or is using name 'ExtraGlamorousProps' from external module "[...]/node_modules/glamorous/typings/styled-function" but cannot be named

One workaround of this issue is to explicitly import the misbehaving type:
import glamorous from 'glamorous'
import { ExtraGlamorousProps } from 'glamorous/typings/styled-function'

This does however break the module resolution in our webpack build for Node.JS and throws "Module not found" errors.
With this PR, the type can now be imported directly from "glamorous":
import glamorous, { ExtraGlamorousProps } from 'glamorous'

How:
To make the test work completely, the TypeScript test had to actually emit files, otherwise the error case could not be reproduced. Added rimraf as an explicit dependency to clean up after the test.

Checklist:

[ ] Documentation should be added to https://github.com/paypal/glamorous/pull/122
[x] Tests
[x] Code complete
[ ] Added myself to contributors table
[x] Followed the commit message format

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #124   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         124    124
  Branches       32     32
=====================================
  Hits          124    124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18db572...e31b2ac. Read the comment docs.

Would you like to add yourself to the contributors table? Feel free to do so in another PR :)

I will if I end up making more changes :wink:
Thanks for the super quick landing!


net: support TCP half-close when HTTP is upgraded in ReverseProxy

In order to support TCP half-close in ReverseProxy,
ReverseProxy.handleUpgradeResponse should not close all sockets
immediately when the one side gets an EOF. But we should close the
write stream on the socket to inform the transfer is complete.
Fixes #35892

@sngchlko I know that it is another issue, but did you notice that after hijacking http.ResponseWriter we cannot use it anymore? But it's still used to write errors with p.getErrorHandler()(rw, req, ...). I guess we should add getHijackErrorHandler() or kinda. It should create manually *http.Response and write it directly into hijacked connection.


ERROR running: sclvm = init(sclvm,Y=Y,tech_noise = tech_noise)

Error in python.exec(paste(objName, " = scLVM(Y,geneID=geneID,tech_noise=tech_noise)",  :
The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
scLVM R package is really hard to install and use.
Can anybody give a user friendly guideline of scLVM !!!

Same problem here.

I just changed every instance where it required a boolean values of the arrays to np.any(array)

It works on reversion to NumPy 1.12.1!


component-selector-prefix should match first word of selector instead of prefix

If I have the component-selector-prefix rule configured such that the prefix is set to "app" then the rule still allows me to use "apps-my-component" as selector.
I think it would be better if the component-selector-prefix rule would match the first word of the selector against the configured prefix. The scanning algorithm to find the first word should depend on the configured value for the "component-selector-name" rule.
Alternatively, a new rule called component-selector-first-word rule should be introduced that implements the described behavior.

Yes, we'll make a lot of improvements in near future (next release) here are some more details https://github.com/mgechev/codelyzer/issues/15.


config/types/etcd: add warnings when some fields don't start with schema

Some fields in etcd must include schemas in the given URL (http, https,
unix, or unixs), this commit adds a validation field on the options
structs that will exmit warnings if these fields don't appear to start
with the correct values.
Related to https://github.com/coreos/bugs/issues/1952#issuecomment-299489651

Refactored a little, got tests passing, and got it to handle comma separated lists of URLs

I'm leaving Red Hat, and thus won't be getting this merged in. If someone else wants to open a new PR with these changes, feel free.


fix bnb token history

closes https://github.com/trustwallet/blockatlas/issues/561

But this adds orders to the list? which we should keep disabled until update clients
test would be useful here

No, only if you filter the list by the token. We already have tests here, but don't cover this case, I going to increase that


Incorrect track numbers

Describe the bug
Track numbers in "Top tracks" seem to indicate the order of the tracks within their albums. This results in the Top tracks list containing track numbers e.g. 6, 12, 2, 14, 11.
To Reproduce
Steps to reproduce the behavior:

Search for and view an artist
See nonsuccessive track numbers in Top tracks

Expected behavior
Tracks should be numbered 1 to 5.
Screenshots

General information:

Distribution: Ubuntu 20.04.3
Installation method [e. g. built from source, installed from Flathub...]: Flathub
Version [e.g. 0.1.0]: 0.2.1
Device used [e. g. desktop, phone...]: desktop

Hey! Thanks for the report. Long story short the previous version changed the way tracks are parsed and now more tracks have their original track number (as in their index in their corresponding album). This explains the original issue with top tracks!
As for the second one, I would assume it is a 2 discs album? If so the UI could definitely be improved to reflect that, perhaps in a separate issue.

not so much of an issue with the new layout, closing for now!

This is still very much an issue, except the indices are all '1' for a brief second before the album covers load.
Do we want to just hide them outside of albums?

fair point, you caught me red handed trying to subtly close issues :D
yes I think hiding them completely is fine!


Custom fonts are rendered in Italic style

Hi I have used some custom fonts to generate PDF. I have set the absolute path in the base url. But the problem is all fonts are rendering in italic fonts even though its in normal.
@font-face {
font-family: 'effraregular';
src: url('../fonts/effra_rg-webfont.eot');
src: url('../fonts/effra_rg-webfont.eot?#iefix') format('embedded-opentype'),
url('../fonts/effra_rg-webfont.woff2') format('woff2'),
url('../fonts/effra_rg-webfont.woff') format('woff'),
url('../fonts/effra_rg-webfont.ttf') format('truetype'),
url('../fonts/effra_rg-webfont.svg#effraregular') format('svg');
font-weight: normal;
font-style: normal;
}

Mine as well
@import url('https://fonts.googleapis.com/css?family=Poppins:200,300,400,600,700');

Mine as well
@import url('https://fonts.googleapis.com/css2?family=Quicksand:wght@400;700&display=swap');

Mine as well
<link href='https://fonts.googleapis.com/css2?family=Alata&display=swap' rel='stylesheet'>
font-family: 'Alata';

Hi,
Any update on this?

@font-face {
font-family: 'Poppins';
font-style: normal;
font-weight: 400;
font-display: swap;
src: url("./Poppins-Regular.ttf");
}
this is working for me.

I having the same issue with "Font Awesome 5 Pro" icons

font-style: normal; dont work

has this issue been resolved?

i'm having the same issue. the fonts are being rendered on PDF. any updates ?

Go to the import CSS link, copy the Latin font faces and paste it into your stylesheet. It worked for me.
Ex:
@font-face {
font-family: 'Poppins';
font-style: normal;
font-weight: 600;
font-display: swap;
src: url(https://fonts.gstatic.com/s/poppins/v15/pxiByp8kv8JHgFVrLEj6Z1xlFQ.woff2) format('woff2');
unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02BB-02BC, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2122, U+2191, U+2193, U+2212, U+2215, U+FEFF, U+FFFD;
}

bump, I have this problem too, doing what @sihilelh advised didn't work either

i have this same problem too, @sihilelh trick doesn't work for me.
i am using linux server on aws

@font-face { font-family: 'Poppins'; font-style: normal; font-weight: 400; font-display: swap; src: url("./Poppins-Regular.ttf"); }
this is working for me.

Thank you. Works for me too.
Just don't forget to remove your @import(...) when you're doing this

same problems here using google fonts

It's been over 2 years now and the issue seems to persist... What I noticed is that the italic effect doesn't happen to all fonts. If you try Roboto or Lato, for example, they'll render properly (not italic):
<style>
@import url('https://fonts.googleapis.com/css?family=Lato');

* {
    font-family: 'Lato', 'Times';
}
</style>

I don't know why, though...

Same problem here. Any workaround? I'm not being able to use Montserrat

same issue. any update?

I went with pdfkit and svg-to-pdfkit. A bit trickier but does the work.

it has been 4 years and yet no answer. maybe, I have to go with something reliable and have up-to-date support.


[SPARK-12221] add cpu time to metrics

Currently task metrics don't support executor CPU time, so there's no way to calculate how much CPU time a stage/task took from History Server metrics. This PR enables reporting CPU time.

Can one of the admins verify this patch?

Jenkins, test this please

(I may be trusted enough to start a run..let's see)

Can one of the admins verify this patch?

@jisookim0513 are you still around? Do you mind updating the patch so we can trigger tests?

@vanzin sure will do

@vanzin I updated the patch

ok to test

Test build #64085 has started for PR 10212 at commit bd19098.

Test build #64085 has finished for PR 10212 at commit bd19098.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64085/
Test FAILed.

Merged build finished. Test FAILed.

Test build #64096 has started for PR 10212 at commit bf8d4f8.

Test build #64096 has finished for PR 10212 at commit bf8d4f8.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64096/
Test FAILed.

Test build #64099 has started for PR 10212 at commit 5a9ea8e.

Test build #64099 has finished for PR 10212 at commit 5a9ea8e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64099/
Test PASSed.

@vanzin this PR had passed all tests. Could you merge it if I fix the recently introduced conflicts?

Sure. Just remember to ping someone, otherwise things get lost in the mountain of e-mails github generates.

Test build #65679 has started for PR 10212 at commit d4d6f76.

Test build #65679 has finished for PR 10212 at commit d4d6f76.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65679/
Test FAILed.

Test build #65686 has started for PR 10212 at commit 2ff5bdc.

Test build #65686 has finished for PR 10212 at commit 2ff5bdc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65686/
Test PASSed.

Merged build finished. Test PASSed.

@vanzin could you merge this? Thanks!

@jisookim0513 unfortunately there are conflicts once more.

Test build #65787 has started for PR 10212 at commit d9c5f8f.

Test build #65787 has finished for PR 10212 at commit d9c5f8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkContext(config: SparkConf) extends Logging
class ChiSqSelector @Since(\"2.1.0\") () extends Serializable

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65787/
Test PASSed.

Test build #65815 has started for PR 10212 at commit f0ef503.

Test build #65815 has finished for PR 10212 at commit f0ef503.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65815/
Test FAILed.

Failure looks unrelated... retest this please

@vanzin thanks, I was about to ask for a retest :)

Test build #65834 has started for PR 10212 at commit f0ef503.

LGTM pending tests.

Test build #65834 has finished for PR 10212 at commit f0ef503.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65834/
Test PASSed.

Merging to master.

@vanzin thanks a lot!


Gaussian Blur concept

This isn't in a great place yet, but I'm submitting it for feedback. BlurX and BlurY deprecated in favor of BlurDir, which will allow some nice motion blurs later. This should also be a partial fix (and inspired by) for #1652 but it's still:

A little too griddy.
Strangely still based on the viewport.
Anyway, I'm putting this in for more eyes and feedback.

Leaving these 2 shadertoy filters here for some reference material:

https://www.shadertoy.com/view/XdfGDH
https://www.shadertoy.com/view/Mtl3Rj

Looks good to me, had some minor nitpicks about style I mentioned. Also, wouldn't this supersede the BlurX/Y filters? We should remove them if so.

Hey engle, thanks for taking a look!
Yeah I was definitely thinking about just taking them out entirely, the other option is hooking them up to 2 BlurDirs in opposite directions if you wanted to keep that.
I'll fix those style issues today, but I also kinda want to implement one of these high quality blurs as well (linked in the shadertoys). Let me know if you think we should make it an entirely separate filter.

Nice work @spaceribs!How does this perform compared to our current implementation?

I can set that up, do you guys have something for benchmarking I can use?

@spaceribs No, we don't have a framework setup for benchmarking specifically.

This looks good to me, if you remove the old filters that this replaces I will merge it.

I would like to keep both for now peeps! At least until we have done some perf tests. ta!

Done!

Hey sorry, I've been working on other stuff all day, last weekend I also
worked on a separate fine blur based on the shaders linked above, I'll open
up another PR for it though
On Wed, Apr 22, 2015, 1:22 PM Chad Engler<EMAIL_ADDRESS>wrote:

Merged #1654 https://github.com/GoodBoyDigital/pixi.js/pull/1654.
—
Reply to this email directly or view it on GitHub
https://github.com/GoodBoyDigital/pixi.js/pull/1654#event-287493138.


No Matches found. Please try another OS Build

Hi, i am trying to get HP Updates for Windows 11 23H2 with no results. What am i doing wrong here? i am running the latest version form 7.2.3
Also i am not getting any more logs in the GUI :( the log is throwing "

Thanks so much in advance!
BR Niklas

Hi!
I´ve had the same issue and found that the OEMLinks.xml is missing under C:\Program Files\MSEndpointMgr\Driver Automation Tool\Settings compared to the old installtion.
Just download it here and insert it in the installtion-path!

Other than that, if you search for Lenovo 23H2 driver some devices show up, so the catalog-XML gets downloaded, but as soon as you try to download the drivers themself it fails.
I tried surfing the URL via my browser and got a "Access is denied." - so I´m guessing the DAT can´t download them because of this.

I have just replaced the OEMLinks.XML but still failing to download drivers. The process log is empty, just states warnings/errors = Yes. This is Dell drivers. Will check to see if HP the same.


bad XRef entry -- caused by incorrect merge of nested xref and ending xref

PDF.js v1.4.76 (build: 45fea88)
Message: bad XRef entry
I have a PDF file supplied by a customer, which fails to display with above message in 'http://mozilla.github.io/pdf.js/web/viewer.html?file='.  (Unfortunately, it is medical data, so I can't share it).
I have debugged the problem, and determined that the 1.3 version PDF has 2 %%EOFs and 2 xrefs.  The second (main) xref defines replacement objects for several objects defined in the previous xref.  When the two xrefs are merged in processXRefTable, the result is one of the objects is defined twice, due to a bug in processXRefTable, resulting in a mismatch later between the expected object number and the actual object number.
I have developed a fix, and am in the process of creating a pull request.  (This is my first github contribution, and my first contribution to pfd.js (though I have PDF internals experience).  So it will probably take me several more days to submit the pull request.)

Thank you for reporting this and working on a fix! It would really help if there would be a PDF test case. Since you have experience with PDF internals, couldn't you remove the sensitive parts from the PDF file to create a reduced test case? We normally request reduced test cases to avoid regressions in the future.

Hi Tim.
I am trying to get a message to end-user, to determine what product generated the file.
I will construct a test-case using a binary editor if I am unable to get test-case from end-user.
--Blair Davies

@xrbd Your issues should be fixed by #7233. Could you confirm that ?

Closing as fixed by #7233 since the proposed PR for this fix contained the same logic. If there is anything else to do here, please let us know and we'll reopen this.


PowerRename - Make option for apply and close when enter is pressed

Description of the new feature / enhancement
Currently if enter is pressed, nothing happens. Before the redesign pressing enter would apply and close. It would be great if that could be an option in the settings.
Scenario when this would be used?
When renaming files with PowerRename.
Supporting information
No response

Very plausible to me

Yes please.


User generated list of incompatible devices lacking BLE "Peripheral mode"

CWA app has requirement of Android 6 and Bluetooth Low Energy, but that alone is not enough to get the full functionality.
To send the "Exposure Notification" beacon your device not only needs BLE but also a special feature called "Peripheral mode". That way you can never warn others if you are infected, cause your device never sends IDs to other phones. But you can get warned, cause your device is able the record others phones IDs.
Even with lack of that "Peripheral mode" on your device the CWA seems to work flawlessly from user standpoint cause neither google play service nor CWA shows the limitation that it is only working one way.
Users can test their devices with this app https://play.google.com/store/apps/details?id=no.nordicsemi.android.mcp
@JProof provided screenshots here https://github.com/corona-warn-app/cwa-app-android/issues/674#issuecomment-646949156
Selecting device information and look for Peripheral mode supported - NO

Samsung A7 (SM-A700F)

Internal Tracking ID: EXPOSUREAPP-1667

LG Google Nexus 5

Instead of generating a compatibility list (that would have to be maintained) Ii would prefer to disable the option to send the infection report to the server in that case as it is useless (as already commented in #674 ) and instead replace it with a note that explains this.
The avaliablility of the "peripheral mode" can be detected programmatically and the replaced note informs the user of anything that needs to be known ...

As I understood, the devs atm had no direct access to BT but only the GAProtocol, so perhaps no quick solution available as they (correctly) say it's Google job to warn or even disable protocol for those devices.
That's why I thought users soon should at least be able to check and inform others that there are older devices out there that SEEM to be fully compatible but aren't.  And a separate thread so the other threads aren't spammed with "this device too" .

@gizmo21 Well, the fact that the device supports "peripheral mode" or not can be detected programmatically without the help of the google library (See nRfConnect that does this).
So the problem can easily be solved on the device without the need of manually maintaining lists that nobody will ever read. ;-)

That way you can never warn others if you are infected, cause your device never sends IDs to other phones. But you can get warned, cause your device is able the record others phones IDs.

Sorry, but I don't understand that sentence. Why would the phone need to send over BLE that I am infected? This should only be sent to the server. It is enough to act as a beacon and record IDs that I observe myself.

FYI:
https://altbeacon.github.io/android-beacon-library/beacon-transmitter-devices.html
(Last Update September 13, 2018)

That way you can never warn others if you are infected, cause your device never sends IDs to other phones. But you can get warned, cause your device is able the record others phones IDs.

Sorry, but I don't understand that sentence. Why would the phone need to send over BLE that I am infected? This should only be sent to the server. It is enough to act as a beacon and record IDs that I observe myself.

Well I never wrote that BLE sends the infection message, but BLE sending your IDs need peripheral mode.
If your device can't send IDs and you are infected and send that information to the server,  the other phones will get server information about infected IDs but as your phone did not send it, other phone won't match IDs.

So people having the app installed, but can not send IDs, thus thinking they are helping by having the app installed, but in reality having the app installed for no reason?

@BudickDa As I understood now: yes.

@BudickDa: From my understanding this might in theory still be possible if all other users have active beacon transmissions. But that's a wild guess and I have no idea if this is/can be implemented in a secure way at all.

@devs it's nice to have a "FAQ" flag now, but it would be even nicer if there would be a statement if absence of "peripheral mode" really cripples the concept without informing the user in app/service.

So people having the app installed, but can not send IDs, thus thinking they are helping by having the app installed, but in reality having the app installed for no reason?

They can receive IDs and thus will be warned if they were close to an infected person (if that person did not have the same issue).
@cschweers: contrary to your current opinion on this expressed in
https://github.com/corona-warn-app/cwa-app-android/issues/674
, I am convinced being transparent about this issue will help:

people would also be informed that their phone is still doing half of the job (which is much better than nothing)
people would know that there is an issue with their handset (not the corona warn app), and might be able to resolve it by switching to a different phone (eigene oder fremde Handyschublade)

I am still searching for a suitable phone - the two I picked from my drawer are Samsung Galaxy Nexus (2011) and LG Nexus 5 (2013). Without apps like "Beacon Scope" I would not know and think everything is fine. With this information, I can improve the situation.

So people having the app installed, but can not send IDs, thus thinking they are helping by having the app installed, but in reality having the app installed for no reason?

@BudickDa: they can receive IDs and thus will be warned if they were close to an infected person (if that person did not have the same issue).
@cschweers: contrary to your current opinion on this expressed in
#674
, I am convinced being transparent about this issue will help:
* people would also be informed that their phone is still doing half of the job (which is much better than nothing)

* people would know that there is an issue with their handset (not the corona warn app), and might be able to resolve it by switching to a different phone (eigene oder fremde Handyschublade)

* if "corona warn" should in the future include some kind of feedback "confirmed receipt of a beacon" then people would wonder why other people do not see their phone

I am still searching for a suitable phone - the two I picked from my drawer are Samsung Galaxy Nexus (2011) and LG Nexus 5 (2013). Without apps like "Beacon Scope" I would not know and think everything is fine. With this information, I can improve the situation.

Looks like "Peripheral mode" can be enabled by the firmware/kernel. I tested this with an android q los build on hammerhead and "Peripheral mode" works.

Looks like "Peripheral mode" can be enabled by the firmware/kernel. I tested this with an android q los build on hammerhead and "Peripheral mode" works.

Do you have more info, link to this firmware and is the downside "only one connection", mentioned in Comment #83 in Google issue, fixed in that version or perhaps  irrelevant for full CWA use?
https://code.google.com/archive/p/android-developer-preview/issues/1570

If some users do not send IDs, they need to be informed about it in the app, so they can change their phone or can additionally use pen and paper.
Also: are there estimations how many devices are only working "half"? Is it 5 % or 50 %?

If some users do not send IDs, they need to be informed about it in the app, so they can change their phone or can additionally use pen and paper.
Also: are there estimations how many devices are only working "half"? Is it 5 % or 50 %?

Use pen and paper for what?

Which revision exactly? Because the latest does not seem to have "Peripheral mode" enabled.
After repartitioning as described in:
https://forum.xda-developers.com/google-nexus-5/orig-development/repartition-nexus-5-repartition-t3844395
I succeeded to install
lineage-17.1-20200613-UNOFFICIAL-hammerhead.zip
and
gapps pico v10 for ARM
. I installed Corona Warn app and "BLE Scanner". BLE Scanner says "Bluetooth Smart supported YES" and "Advertiser mode supported NO", i.e. no change. Also, my other phone does not see beacons from Nexus 5.

I have an update, but still no beacons:
"Beacon Scope" fails because "some other app might be sending beacons". If I disable exposure notification in CWA, then "Beacon Scope" app says that it now is able to send Exposure notification beacons.
My other phone still does not see those beacons, while it does see beacons from other phones, so I think "Beacon Scope" is wrong, the phone does not send, neither from CWA nor from "Beacon Scope".

Hmm. I do see some beacons from Nexus 5 with 20200613 LOS installed. Sometimes. So CWA "peripheral mode" might work there - or not. Need to do further research.

If some users do not send IDs, they need to be informed about it in the app, so they can change their phone or can additionally use pen and paper.
Also: are there estimations how many devices are only working "half"? Is it 5 % or 50 %?

Use pen and paper for what?

If my smartphone does not send IDs (https://github.com/corona-warn-app/cwa-app-android/issues/688#issuecomment-647159934)
, I am "invisible" for other users so I need to keep track of my contacts in another way for the authorities to inform them (for example by writing them down if possible).
If users trust that the app does their contact tracing for them, but it doesn't, the manual contact tracing by the authorities could be more difficult. Because:
If I think, I don't need to remember something, because my smartphone does it for me, I am more prone to not remember it.
In a nutshell: Users must be informed, if their app doesn't send IDs.
But I think this should be discussed in another (maybe wishlist?) issue.

We are currently discussing how to best handle the creation of such a list.
For the time being, we want to concentrate discussions on a single issue (this one). So, for reference, we will close:

#780 Fairphone
#674 Asus Nexus

For reference, the approach used by SwissCovid check BLE capabilities is mentioned here: https://github.com/corona-warn-app/cwa-app-android/issues/674#issuecomment-651531895

Huawai Y6P Android EMUI <IP_ADDRESS> MED-LX9N Modell 2020 - no Chance - GSF not installable. The old Samsung with Android 4.4. no chance and a newer Samsung J5 (2016) perhaps. LG 620 BT - no chance to get it work.

@ArnoldSchiller has recently suggested that outdated Google Mobile Services (GMS) might be the reason why phones don't have "peripheral mode". Based on that a solution for some devices might be a recent LineageOS build with up-to-date openGapps. Does anyone know whether that could work and/or has tried this?

[...] for some devices might be a recent LineageOS build with up-to-date openGapps. Does anyone know whether that could work and/or has tried this?

I think I did. But maybe you see something I missed.
I have two phones with non-working peripheral mode:

Samsung "Galaxy Nexus" aka maguro

LineageOS  13.0-20180211-NIGHTLY (not that recent)
Android version 6.0.1
CWA
up-to-date "google play services" aka com.google.android.gms, Version 20.26.14<PHONE_NUMBER>08519)

ENF possibly receives beacons (can't tell as there are no statistics). ENF does not send beacons.
BeaconScanner can receive ExposureNotification frames, but not send due to missing Peripheral Mode. THis is not an issue of GSM, but seems to be an issue of hardware drivers not supporting peripheral mode.

I tested the same with a LG "Nexus 5" aka hammerhead with LineageOS 17 and OpenGapps. See my previous comments dated june 26 (above in this thread). Currently, this phone runs UBports, but I am willing to revert to some Android to test this further.

Do you think I missed something?

@pinkit-cwa thanks for the feedback. Tbh I was mainly relaying what @ArnoldSchiller said in our twitter exchange. I couldn't really judge how likely his suggestions were to yield success, as I'm not an expert on the BT stack. It's a pity that this simple solution doesn't seem work. Maybe he can chime in with some further suggestions, I'll ping him on twitter 🙂 .

Got a reply and suggested moving the twitter conversation here:

Laut dem Text ist es Android version 6.0.1, jetzt wäre die Frage ob das einen Kernel 4.x - in 3er-Kernel wird es nur unterstützt, wenn es "Backported" geworden ist.

So this means, the Android version used would be the limiting factor for "peripheral mode", not GMS, right?
So if I understand this correctly "peripheral mode" would require either:

An Android with kernel version >= 4.x or
An Android with kernel version 3.x but with suitable backported drivers

@ArnoldSchiller is this representation correct?

Got a reply and suggested moving the twitter conversation here:

Laut dem Text ist es Android version 6.0.1, jetzt wäre die Frage ob das einen Kernel 4.x - in 3er-Kernel wird es nur unterstützt, wenn es "Backported" geworden ist.

So this means, the Android version used would be the limiting factor for "peripheral mode", not GMS, right?
So if I understand this correctly "peripheral mode" would require either:
* An Android with kernel version >= 4.x or

* An Android with kernel version 3.x but with suitable backported drivers

@ArnoldSchiller is this representation correct?

I confirm kernel version 3.0.101-g176096d for my "maguro".
I currently have installed UBports version 16.04 to the hammerhead. That one also has kernel version 3.4.0-cyanogenmod-g2b465f7 .
I did not yet check the kernel version for LineageOS on hammerhead. But, my guess would be "3.x" as well, due to the README in:
https://github.com/LineageOS/android_kernel_lge_hammerhead
I do not find a kernel 4.x based Android for either device, yet.

Bluetooth LE Linux Kernel versions:

= 4.4 	Will work out of the box
= 3.13 	Ok for Bluetooth Classic and LE however consider backporting
= 3.10 	Ok for Bluetooth Classic however consider backporting

Meanwhile, we checked quite a range of devices including Huawai, Samsung, Nokia, OnePlus that do not support the BLE peripheral mode. The results are comfortable: Even without the statement "BLE peripheral mode not supported", all devices worked fine with both

sending/receiving keys for contact tracking
regular retrieving of key packets for risk calculation

So far, we did not find any issues related to BLE peripheral mode in the test cases (test lab).

@GisoSchroederSAP
........100k infections later
somewhere in issues there are whishes from first oder second day of public official release:
Test-function or self-test or diagnose
For App-Users to check the functionality of the CWA (sending receive).
Please investigate by your self

Even without the statement "BLE peripheral mode not supported" [...]

There is some issue with this sentence. I guess the "without" should
be a "with" - or shoud the "Even" be a "When"?

So far, we did not find any issues related to BLE peripheral mode in the test cases (test lab).

I could supply you with an Google Galaxy Nexus, just to make your statistic a little bit worse. On the other hand, I doubt anybody else is using this handset anymore.
Also, I by now switched to LG Nexus 5X "bullhead", which works fine (while LG Nexus 5 "hammerhead" does not), so I do not have this issue anymore.
Regarding the missing self-test functionality, I agree, but I also have a workaround: I use "BeaconScope" to check for presence of other devices beacons. I just cannot see if CWA actually notices other devices beacons.
Actually, my bullhead once said (green) "low risk" while it mentioned an "encounter". Which might enable a usable self-test: leave your phone in some crowded underground station for a day or so. Within a few days you should know if CWA works or not. On the other hand, I am not sure if the Exposure Notification API can tell if/how many beacons have been received - probably that remains hidden within the framework. Please confirm.

On the other hand, I am not sure if the Exposure Notification API can tell if/how many beacons have been received - probably that remains hidden within the framework.

Indeed: while the Exposure Notification Framework (ENF) by Google/Apple in principle has information on all the recorded rolling proximity identifiers (RPIs) only matches with positive diagnosis keys (DKs) will be exposed to CWA by the API (see here for more details on the response CWA gets from ENF in the currently used v1 legacy mode).

Btw., even if not supported by the majority of ROMs, there are custom/unoffical Lineage builds available for Samsung Galaxy S3 (i9300) and Samsung Galaxy S3 LTE (i9305) which does indeed support BLE peripheral mode and are proven to work (tested with nrf Connect for instance).

i9300: https://forum.xda-developers.com/t/rom-unofficial-9-0-0-lineageos-16-0-beta-20-09-2020.3875899
i9305: https://forum.xda-developers.com/galaxy-s3/development-i9305/rom-lineageos-16-0-i9305-t4035331

@JProof , I just added the mentioned self-test idea to the wishlist. We'll evaluate this as part of enhancing the "tooling" within the app.

@JProof , I just added the mentioned self-test idea to the wishlist. We'll evaluate this as part of enhancing the "tooling" within the app.

@pinkit-cwa

Even without the statement "BLE peripheral mode not supported" [...]

There is some issue with this sentence. I guess the "without" should
be a "with" - or should the "Even" be a "When"?

No, I chose the phrase intetionally, but also could rephrase: _Even if you skip/forget the statement "BLE peripheral mode not supported" all devices worked fine [...] _
Meaning: Regardless of the peripheral mode, the verified devices worked fine.
Obviously, I agree, there are still devices that will not be supported (yet) - for various reasons.

@pinkit-cwa

Even without the statement "BLE peripheral mode not supported" [...]

There is some issue with this sentence. I guess the "without" should
be a "with" - or should the "Even" be a "When"?

No, I chose the phrase intetionally, but also could rephrase: _Even if you skip/forget the statement "BLE peripheral mode not supported" all devices worked fine [...] _
Meaning: Regardless of the peripheral mode, the verified devices worked fine.
Obviously, I agree, there are still devices that will not be supported (yet) - for various reasons.

I don't quite understand why there is no warning in the app when a device doesn't support BLE periphial mode. Obviously, there are some devices like the Fairphone 2 where no beacons can be sent.
It is possible to detect whether this is the case in the app with just a few lines of code.
At CCTG, I am right now working on including a warning on the main screen to inform users when the device is not able to broadcast RPIs / IDs. (Previously, we only had this warning hidden in some menu.) I think it is quite crucial for users to know when the app is not working fully, therefore, I would strongly suggest CWA to include such a warning as well.
My suggestion is to add a card to the main screen, like this (screenshot from in-development <IP_ADDRESS> CCTG):

Hi Fynn,
during end of last year there was a plan, to introduce a better user-friendly error reporting. I suppose your solution strongly goes into the direction that was planned.
I'd love to see something similar for CWA, and I'm wondering if there is a way to coordinate a common approach? So I'm pinging @BMItter here, who was supposed to work on this for CWA.
Cheers, v.

@fynngodau Can you please create a PR for this warning?

@fynngodau @thomasaugsten
One open question: should the 'incompatibility card' actually replace (or block) the 'have you been tested card' as affected users cannot warn others?

I think a normal block is ok no replacing not grey out because you can maybe in the future not only submit ENF TEKs

@thomasaugsten Sure, I can create a PR that introduces the incompatibility warning card as shown in the screenshot in the next days.

The "Fix 2.1" label should be removed here.
The PR #2873, which implements the incompatible warning card, has been merged into the release/2.2.x branch, so this will be released with version 2.2, not with 2.1.

@Ein-Tim True, I've corrected te labels.

Corona-Warn-App Open Source Team

Thanks to everyone for input and coding of the warning card now. As I see this correctly now with next version I will have a drum roll on startup on my Nexus 5 hammerhead if that one is sending dispite the lack of BLE or if this one is really in incompatble.

I opened a PR for the FAQ entry that can gets opened once the card is clicked: https://github.com/corona-warn-app/cwa-website/pull/1211

Google Play Store does not offer CWA to a Pixel 3a emulator, Android 10 (API 29), because of the lack of Bluetooth support by the emulated device. The Store says "Your device isn't compatible with this version." If I however bypass that check and sideload CWA Android 2.2.1 on to the device, then the app shows an incompatibility warning, as planned:

@MikeMcC399 Thanks, looks good! I think we can close then.
Implemented in CWA release 2.2.

Corona-Warn-App Open Source Team

Yes, works on real Nexus 5 hammerhead including FAQ.

Thx again.

As already mentioned, this is the best available list of devices with restricted support you may find


Update mdoc, sbt-mdoc to 2.2.19

Updates

org.scalameta:mdoc
org.scalameta:sbt-mdoc

from 2.1.5 to 2.2.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

labels: library-update, semver-minor

Superseded by #184.


Question

Use this issue to discuss the Question pattern in the ONS Design System

Classes parameter does not work as its not just classes in the macro template, not params.classes

When the question component is in fieldset mode and there is no question description, the spacing between the title and the legend is too big.
This is because the legend and the h1 both have a margin bottom.

Question margins are still wrong, when there is a h1 wrapped in a legend followed by p tags, the p tags aren't effected by the h1's margin bottom:

When the h1 is within the legend,  JAWS fails to find the h1 when navigating by headings.

Number of broken links encountered:
https://ons-design-system.netlify.com/components/radio
https://ons-design-system.netlify.com/components/date
https://ons-design-system.netlify.com/pattern/durations

Ensure consistent vertical spacing
Issues include:

Vertical spacing is sometimes defined varies between top and bottom margins
Spacing between a question page button varies depending on last item in question block


update copyright

Update copyright year from 2021 -> 2024

Note that the master branch is actually behind the branch we actually use in the mfem actions, v2.4. Maybe we should just merge v2.4 in master.


Lots of Errors Ticking Animal Pather

Lots of Errors Ticking Animal Pather
https://gist.github.com/maarxx/731afd71f4ae92861ea30a54436f0ad2

Please re open the issue if the issue still occurs in the new versions.


Hyperion-buildall script uses an outdated fork of SDL-Hercules

Hi Bill,
A few days ago, Fish committed a fix for a problem affecting SIE functionality in cpu.c that I wanted to test (commit e24c303, on 10/10).  On an Ubuntu system that did not have any Hercules installed, I downloaded the Hercules helper repository and ran hyperion-buildall.  Unfortunately, it is currently configured to use a wrljet fork of SDL-Hercules instead of the master SDL version, so I did not get that fix included.
I don't know if the issue you reference in the configuration file has been resolved yet, but I was able to work around this by pointing the script back to the main repository and build it.
hercules-helper.conf (as modified by me):
...
# Temporarily set up to use my fork of SDL-Hercules
# while Fish et. al. straighten out gcc function inlining.
...
# Git repo for SDL-Hercules Hyperion
git_repo_hyperion=https://github.com/SDL-Hercules-390/hyperion.git
# git_repo_hyperion=https://github.com/wrljet/hyperion.git
...
If the gcc issue has not been resolved, would it be possible to bring the fork back into sync with the master repository?  Or maybe just put out some kind of warning message about the temporary gcc workaround so users can choose whether or not to use the wrljet fork?  Your helper scripts are really convenient and I'd hate to see anybody else get bit by this.

Builds with current SDL-Hercules repo are working well now, building and passing checks on many
diverse systems.  And 4.4 is hoped to be released shortly.
The default clone repo in the Hercules-Helper config file has been pointed back to the official repo.
Bill


j/k move cursor in selection mode instead of inserting letters j/k

Example case: I have a snippet for C++ for loop, which expands to
for (int i = 0; i < counter; i++)
{

}

But when I <Tab> to i (with all three of them to be edited in the selection mode), and want to repalce it with j, my cursor moves down instead, extending the selection. The same happens with k, but this time cursor goes up one line. Other letters seem to work fine, i.e. I have no problem with replacing i with, e.g., s. I tried the same with almost all of other plugins disabled (including nvim-cmp), still behavior is the same. Franky, I am surprised to see that pressing letter keys in the selection mode works like in the visual mode (not replacing the selection).

Do you have j/k mapped to something else in visual mode? If so, try changing any v-mappings (vnoremap, etc.) to x-mapping (xnoremap...). Example:
vnoremap <expr> j v:count ? 'j' : 'gj'
vnoremap <expr> k v:count ? 'k' : 'gk'

Change to:
xnoremap <expr> j v:count ? 'j' : 'gj'
xnoremap <expr> k v:count ? 'k' : 'gk'

See help Select-mode-mapping for how mappings work in select mode. In short, select mode inherits any visual mappings when v mappings are used; use x if you don't want this to happen.

That's it, I had exacly these vnoremaps, and I've changed them per your suggestion. Now it works as expected. Thank you.
I was confused by the fact that when using UltiSnips, I didn't  observe this behaviour (all other configs being equal) - j/k/ isnerted letters instead of moving cursor in select mode. Probably, Ultisnips somehow handles this situation.

I'm glad it helped!


fmt wrapper convenience methods

Hi Mitchell,
Thanks very much for this great little library. It works a treat.
I've created some convenience wrappers around the fmt.*print* methods to add support for the colorstring color codes. My intention is make the tool a little more DRY friendly and reduce the number of fmt.Printf(colorstring.Color("..."), ...) calls by simply using colorstring.Printf("...", ...).
If you feel this is useful, I'd love to hear your feedback.

This LGTM. I think this is idiomatic, since we can see that the stdlib log package has Printf and Println. So I believe it makes sense to make this easier. Merging.


Criteria::expr()->contains() and defensive Type objects

I have a value object for Email. This object checks for a valid email given. If not throws an exception.
Now when i try to use contains the query is build like ('%foo%'), which results in throwing the Email a InvalidArgumentException because %foo% is not a valid emailadres. Am i missing something?

Can you make a gist of what you are actually doing, and what you expect instead?

@Ocramius here's the idea: https://gist.github.com/Michal-sk/d3d3389bdabd14653a7b10dff1e60632
I was thinking that the criteria builder would maybe omit or have a different way of creating the value objects as WHERE arguments. I'm aware that just 'foo' would result in an exception aswel. So would the right way here be to do a custom query?

It would be simpler to select the sub-field. Assuming your VO is mapped as foo inside an EntityA, then the field logical name would be something like EntityA#foo.email. Matching foo.email would suffice.

The examples are a bit stripped down. This is all part of a API, in which we can define for what fields we want to search.
It all goes a bit deeper. The Account has a embeddable for a Couple, which has embeddable Persons which have a Email field. So my first question was a bit of. The Email it self is not a VO, but a column type.
    /**
     * @var Email
     * @ORM\Column(name="user_email", type="email", length=64)
     */
    private $email;

Correct, and I'm suggesting that you compare it by string here. There is no way for you to represent a "partial email" and get past the VO rules anyway: that's specifically what the VO is for.

So for http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#custom-mapping-types when we would like to search for 'where Money like 10.%' there would be no way to use the Criteria API?

Ok, so this had to do with my Column Type begin converted to the object and than from the object we would get te string value. I fixed this by changing convertToDatabaseValue().
class Email extends Type
{

    /**
     * @param mixed $value
     * @param AbstractPlatform $platform
     * @return string
     */
    public function convertToDatabaseValue($value, AbstractPlatform $platform): string
    {
        // Used for searching.
        if (is_string($value) && $this->hasWildcards($value)) {
            return $value;
        }

        if (is_string($value)) {
            $value = new \Woonon\Domain\Value\Email($value);
        }

        if (!$value instanceof \Woonon\Domain\Value\Email) {
            return '';
        }

        return $value->email();
    }

    /**
     * hasWildcards returns if the given string starts and ends with the % wildcard for SQL.
     * This is used for contains queries.
     *
     * @param string $value
     * @return bool
     */
    private function hasWildcards(string $value)
    {
        $firstIsWildcard = $value[0] === '%';
        $lastIsWildcard = substr($value, -1) === '%';

        return $firstIsWildcard && $lastIsWildcard;
    }
}

So basically now when we do the Contains search it immediately returns the raw string value.

I still think there should be a more decent way to get this working. But will close for this case,

@Michal-sk if you have a better definition of what to query for, I'd:

define a VO with the search pattern, which defines what a search pattern looks like in your world
define a read model (interface) that accepts the VO and other parameters
perform the query with stringy stuff in the implementation (infrastructure)

Im not sure i see exactly what you have in mind. Ill try to elaborate and what we are doing.

We have search endpoint /search?resource=user&in_fields=users.person.email&query=michalsk
There is a function which constructs the whole Criteria, based in the fields and values given.
Than we grab the resource we want. The resource value maps to a repository class, so for above 'user', will give us the Account repository.
We pass the Criteria to the Repo to filter.
We always use a Contains for all the Critaria created, so for above the query will use %michalsk%
But our Type (Email) has the method convertToDatabaseValue(). This method first creates the VO and than returns the string from that VO (see code above).

The problem was because convertToDatabaseValue was passing the value as %michalsk% which is not a valid emailadres. What i'm basically looking for is a way to 'just' return the raw string (%michalsk%) when convertToDatabaseValue is called beloning to a Critaria call. So for now i just check for %. If you have any suggestion im glad to hear them.
The above structure makes it simple for us to quicke deploy a search endpoint for Products or what ever additional entity we want to support in search.

@Ocramius is there any benefit in creating the object when useing convertToDatabaseValue besides the obviouse that it's an extra check and the VO decides how to return the string representation.
Because looking at http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/cookbook/advanced-field-value-conversion-using-custom-mapping-types.html#the-mapping-type i see that we just dump the raw value when the given parameter is not an instance of the VO.


implement CTLineGetTypographicBounds and CTFramesetterSuggestFrameSizeWithConstraints

Fixes #1019

:clock1:

FYI your review title doesn't make sense. Our version of CT* will never be interoperable with anything on the reference platform (they have their own version).

Never be interoperable in the sense of providing exact values, or functioning 'similarly'?  It should certainly do the later.

In reply to: 249301240 [](ancestors = 249301240)

compatible / matching / etc are fine. Interoperable means able to work with (specifically to communicate / pass data between) I believe. Mostly just a semantic difference that may mislead reviewers into thinking this review is trying to build and function on the reference platform and use / communicate components from it.

In reply to: 249301613 [](ancestors = 249301613,249301240)

Our "interoperable" tag on apis and other discussions of interoperability have been in reference to app code not to reference platform code I guess. I've never thought our other uses were weird and its not a big deal obviously.

In reply to: 249302879 [](ancestors = 249302879,249301613,249301240)

If we wanted to be crazy, i think the term AJ is really meaning would be "idemoperable" or something?

In reply to: 249303282 [](ancestors = 249303282,249302879,249301613,249301240)

:shipit:

Understood.  The pull request should simply say "implement CTLineGetTypographicBounds".  +1 for idemoperable.

In reply to: 249303752 [](ancestors = 249303752,249303282,249302879,249301613,249301240)

:clock1:

Due to some overlapping changes, I added CTFramesetterSuggestFrameSizeWithConstraints to this commit.

In reply to: 249305565 [](ancestors = 249305565,249303752,249303282,249302879,249301613,249301240)

:shipit:

:clock1:


Retrieve Plasma C structs from Python objects

The API currently has the user pass an ObjectID and a PlasmaClient to create or get objects. These classes are defined in the plasma.pyx Cython code.
In libpxnd, creating or getting objects requires passing in pointers to the C++ class instances of those objects. They are accessible in the Cython code under the cdef header:
cdef class ObjectID:
    """
    An ObjectID represents a string of bytes used to identify Plasma objects.
    """

    cdef:
        CUniqueID data

cdef class PlasmaBuffer(Buffer):
    """
    This is the type returned by calls to get with a PlasmaClient.
    We define our own class instead of directly returning a buffer object so
    that we can add a custom destructor which notifies Plasma that the object
    is no longer being used, so the memory in the Plasma store backing the
    object can potentially be freed.
    Attributes
    ----------
    object_id : ObjectID
        The ID of the object in the buffer.
    client : PlasmaClient
        The PlasmaClient that we use to communicate with the store and manager.
    """

    cdef:
        ObjectID object_id

So the question is, how do I get access to these fields from the C code? They aren't properties of the PyObjects,  but they exist somewhere in that memory. The recommended way to expose Cython types to C is to use the public keyword. The plasma code doesn't.
So I was thinking if I could get into gdb and inspect that ObjectID in C, maybe I would be able to find where the pointer to the C++ class is stored.
However, I have been having some trouble getting gdb to show the traceback, it's all ?? for me.

I managed to get this working. I can now pass a ObjectID created in Python to the C library and it can extract out the C++ struct from it so that it can pass it to the client.
It required another layer of wrapping. So the Cython plasma library generates C++ code like this:
/* "pyarrow/plasma.pyx":130
 *
 *
 * cdef class ObjectID:             # <<<<<<<<<<<<<<
 *     """
 *     An ObjectID represents a string of bytes used to identify Plasma objects.
 */
struct __pyx_obj_7pyarrow_6plasma_ObjectID {
  PyObject_HEAD
   plasma::UniqueID data;
};

So I wrote a little C++ wrapper for this that exposes it to my C code:
_plasma.h:
#include "Python.h"
#include "plasma.h"

#ifdef __cplusplus
extern "C" {
#endif

ObjectID pyObjectID_data(PyObject *p);

#ifdef __cplusplus
}
#endif

_plasma.cpp:
#include "_plasma.h"
#include "plasma/client.h"

typedef struct {
    PyObject_HEAD
    plasma::ObjectID data;
} PyObjectID;

ObjectID pyObjectID_data(PyObject *p) {
    return reinterpret_cast<ObjectID>(&(reinterpret_cast<PyObjectID *>(p)->data));
}

Then in my C _pxnd.h python module, I can get the ObjectID from a python object that is passed in.
I can use the same approach for the PlasmaSession, to grab it's C++ pointer from the python instance.
I will push all this, once I organize it a bit. I also will write this up somewhere, because I haven't found this documented anywhere as a way to wrap a Cython library that hasn't exposed anything in a C Python extension.


Add filter to set contentSelector

I would be nice if the following was wrapped in an filter https://github.com/westonruter/spoken-word/blob/e0174587806802ba3668ce43e57f0429022d1d08/spoken-word.php#L88
eg:
'contentSelector' =>  apply_filters( 'spoken_word_content_selector',  '.hentry .entry-content, .h-entry .e-content, [itemprop="articleBody"]' ),

Good call. I think actually it should be a spoken_word_options filter that wraps all of the $export array:
https://github.com/westonruter/spoken-word/blob/e0174587806802ba3668ce43e57f0429022d1d08/spoken-word.php#L87-L90

See also #3 which could eliminate the need to customize the contentSelector.

Hi there,
FWIW I do think the spoken_word_options filter would be really useful, especially for theme compatibility.
E.g. some themes might remove the hentry class from the post_class() array, mostly to avoid google search console structured data errors on pages (author and updated properties are typically missing in pages, but required for the hentry microformat)
#3 would be great too, but it can coexist with this filter, making the $export something like the following:
 	$exports = array(
 		'contentSelector' => '.hentry .entry-content, .h-entry .e-content, [itemprop="articleBody"]',
 		'useDashicons'    => true,
                'autodetectContent' => false,
 	);

when autodetectContent is true the contentSelector option will not be used.
Best


Branch - feature/osw_h2

[ ] Have owners review branch to identify functionality to include in HOPP
[ ] Back-merge dev/refactor into respective branches
[ ] Remove extraneous code
[ ] Merge branch and delete old branch

There's a PR associated with this: #61


fix: honor gradle task property packagers.docker.repository.name

resolves two issues. name value set to username. name value set prematurely before parent tap values are merged.
https://github.com/jreleaser/jreleaser/issues/1438
Context

See issue above
Checklist

[x] Review Contribution Guidelines.
[x] Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
[x] Update documentation when applicable.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you! 😄


ByteSize.human_readable with an optional separator (e.g. whitespace) between value and unit

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Currently, the return value of ByteSize.human_readable does not have any separator between the value and unit.
>>> size = ByteSize(12345678)
>>> size.human_readable()
'11.8MiB'

It looks a little bit weird to me, and I think it could be better if there's a space separating the value and unit. Though there are many ways to handle this need, it may be a better idea to provide an optional argument with this method? For example:
ByteSize.human_readable(decimal: bool = False, separator: bool = False) -> str

When I switch the separator on:
>>> size = ByteSize(12345678)
>>> size.human_readable(separator=True)
'11.8 MiB'

It's probably easy to be implemented, so I can create a PR to implement this feature if it will be acceptable.
What do you think about it?
Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

@jks15satoshi,
Go for it! Just makes sure that by default, the separator is '' so that this isn't a breaking change. Thanks for the suggestion. Ping me when you need a review :).

@sydney-runkle,
Thanks. PR has been created :)


"Latest" option is missing in API V2

https://github.com/PaperMC/Paper/issues/4824#issuecomment-736125764
Hi,
reference:
https://paper.readthedocs.io/en/latest/site/api.html#i-just-want-to-download-the-latest-jar
In API V2 the "latest" build option is missing. It was present in V1:
https://papermc.io/api/v1/paper/1.16.4/latest/download
But it is not updated anymore.
Bug report:
https://github.com/PaperMC/Paper/issues/4824

By design to prevent auto updaters from existing.

The v1 latest endpoint is updated - it had a cache duration that was too long and has been fixed (https://github.com/PaperMC/library/commit/6b37a50c1a12f4b6d66005e5a2f58b14b775b68d).
v2 is not "missing" the latest endpoint, it was intentionally not done.


future request?

Hi,
Future request to be able to read SAS disks?

...i obviously can't speak myself for otakuto's intentions / future plans,
now having said that...
crazydiskinfo 1.x uses libatasmart...
libatasmart is rather limited in what it implements,
hasn't really seen development since 2012,
and also...according to the ancient legend at least,
someone first has to survive battling the leopard,
in order to use such... :-)
...i'd possibly give a try to crazydiskinfo 2.x branch,
which in turn acts like a wrapper for smartctl itself.
You'll need to include this header to build such from what i see...
Haven't really experimented myself with it,
so i really can't comment further on that.
But that's where i'd start meddling around...
However - do also note the following part from smartmontools's faq...
Maybe also see this thread here. I mean,
if smartctl itself can't really (always?) return useful data / info for SAS...

Thanks for the reply i guess ill give a try on the 2.x branch hopefully it can get updated


Custom Fee

It would be nice if there was a way to set a custom fee. Using WinZEC, I was able to manually set a fee all the way down to 0. Right now the zcash network isn't really full, so the fee doesn't actually do much.

Commit: 448b2ceca8345d29ccc39cbcab3af799f73e8d15

In v0.3.1

The default fee is there for a very good reason. All fees are transparent so using a custom fee makes all transactions indistinguishable. If you are solely using t-addrs then fair enough this is a moot point as everything is visible. I'd expect users of zec-qt-wallet to shielded tx users and in which case using the default fee is highly recommended. I'm not against setting a custom fee for those who know what they are doing but suggest flagging a warning if anyone changes the fee.

Yup, got this feedback from elsewhere as well. I will add a warning on the confirm page.


[Feature] Add one-to-many relationship between challenges and DOIs

What product(s) is this feature for?
OpenChallenges
Description

Yes, it would be helpful to have a one-to-many relationship between challenges and DOIs. They often have many, e.g. a design paper, results paper, dataset paper, dataset DOI (e.g. on Zenodo), software DOIs. I will re-order the list for you so that the DOI with the most citations appears first, hopefully that captures the most important one.

Idea shared by James Meakin (Grand Challenge) on Nov. 2023
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@gaiaandreoletti We received this request from James. If it makes sense to you, this is something that we can implement relatively easily by adapting existing code.


Enable Gitflow for Release Management

As a developer of Anchor Platform there should be a clear separation of environments for
Feature Development - next release
Bug Fixing - Production (hotfix), Current Release (Release under test)
Gitflow pattern enables such separation of concerns without blocking any development thread while also being clear what release is in each environment.
General principal
Dev Branch (next release), Feature Branches (Branched off Dev)
Master/Main Branch - current release in production
Staging/Hotfix branch - matches master/main - used to fix bugs in production - create branch, fix and test bug, merge to master and backmerge to release/develop
Release - branched off Dev for next release - used to perform integration testing before merge to main/master (cut release)
bugs that occur in release and fixed, backmerged to develop (next release) possibly patched to production.
This story encompases: document our gitflow and gain agreement from team
socialize: allow product to review,ops review as well.
define story / tasks to enable (cicd environments, kubernetes namespaces, etc, github actions).

After we adopt gitflow we should start doing releases in the maven repository. This is related to:

https://github.com/stellar/java-stellar-anchor-sdk/issues/299

proposal: https://docs.google.com/document/d/1SUh1Bi83c3UIRhQW86eVWIUZDnpyQ-OozS4BTcF-kyA


Key is ignored if it ends with a question mark

Describe the bug
Recently I tried to use dry-schema for data validation in existing app, I have a couple of use cases when hash keys end with question mark, like { 'terms_of_usage?' => 'Y' }. When I validate such data these keys are ignored.
To Reproduce
MySchema = Dry::Schema.Params do
  required(:some?).filled(:string)
end

MySchema.('some?' => 'val')
=> #<Dry::Schema::Result{} errors={:some?=>["is missing"]}>

Expected behavior
MySchema = Dry::Schema.Params do
  required(:some?).filled(:string)
end

MySchema.('some?' => 'val')
=> #<Dry::Schema::Result{:some?=>"val"} errors={}>

Your environment

Affects my production application: NO
Ruby version: 2.6.5
OS: macOS 10.14.6

I stepped through your example and this looks like an issue caused by https://github.com/dry-rb/dry-types:
From: lib/dry/schema/value_coercer.rb @ line 21 :

    16:       param :type_schema
    17:
    18:       # @api private
    19:       def call(input)
    20:         if input.success?
 => 21:           binding.irb
    22:           type_schema[input.to_h]
    23:         else
    24:           type_schema.each_with_object(EMPTY_HASH.dup) do |key, hash|
    25:             name = key.name
    26:

irb(#<Dry::Schema::ValueCoercer:0x00007f895b25eec8>):001:0> type_schema
=> #<Dry::Types[Lax<Constructor<Schema<keys={some?: Nominal<String meta={required: false, maybe: false}>}> fn=Dry::Types::Coercions::Params.to_hash>>]>
irb(#<Dry::Schema::ValueCoercer:0x00007f895b25eec8>):002:0> type_schema[some?: 'val']
=> {}
irb(#<Dry::Schema::ValueCoercer:0x00007f895b25eec8>):003:0> type_schema[some: 'val']
=> {:some=>"val"}

After a little digging, it looks like this is intended behavior: https://dry-rb.org/gems/dry-types/1.2/hash-schemas/#optional-keys

@solnic Is there any workaround for now to deal with attributes that ends with ??
3.0.1 :009 > s = Dry::Schema.Params { required(:'Enable for Sale?').maybe(:bool) }
 => #<Dry::Schema::Params keys=["Enable for Sale?"] rules={:"Enable for Sale?"=>"k...
3.0.1 :010 > s.('Enable for Sale?' => 'Yes')
 => #<Dry::Schema::Result{} errors={:"Enable for Sale?"=>["is missing"]} path=[]>

@v-kolesnikov if it's possible to turn this behavior off in dry-types, then that would be the workaround /cc @flash-gordon ?

no clue. It's possible to create a custom schema type that transforms input keys
module Types
  include Dry::Types()

  FancyHash = Hash.schema({}).with_key_transform { |key| key.gsub('?', '').gsub(' ', '_').to_sym }
end

schema = Types::FancyHash.schema(foo_bar: 'integer')
schema.({ 'foo bar?' => 123 }) # => {:foo_bar=>123}

It should be possible to make such a type as a default hash type in dry-schema's type registry, there's no "public" 1-line API for that though.


Print out filename:lineno in assert failure message

It is useful to identify which assert failed in a test.
As the filename and the line number are passed in, simply show them
in the assert message.
uasserts.c |    9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/uasserts.c b/uasserts.c
index 407fccc..b1197a3 100644
--- a/uasserts.c
+++ b/uasserts.c
@@ -46,11 +46,20 @@ __np_assert_failed(const char *file,
{

G'day,
Thanks for this patch.  I agree that showing the filename and line number
in assert messages is useful, but I'm not going to take this patch in it's
current form.  I don't think that __np_assert_failed() is the right place
for this formatting change - it belongs in text_listener_t::add_event()
which does the actual text formatting.  Also, you should probably adjust
the tests which will be broken by changing the format.  I'd be happy to
receive another patch along those lines.
On 2 August 2017 at 15:38, Kyeong Yoo<EMAIL_ADDRESS>wrote:

It is useful to identify which assert failed in a test.
As the filename and the line number are passed in, simply show them
in the assert message.
uasserts.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/uasserts.c b/uasserts.c
index 407fccc..b1197a3 100644
--- a/uasserts.c
+++ b/uasserts.c
@@ -46,11 +46,20 @@ __np_assert_failed(const char *file,
{
You can view, comment on, or merge this pull request online at:
https://github.com/novaprova/novaprova/pull/18
Commit Summary

Print out filename:lineno in assert failure message

File Changes

M uasserts.c
https://github.com/novaprova/novaprova/pull/18/files#diff-0 (9)

Patch Links:

https://github.com/novaprova/novaprova/pull/18.patch
https://github.com/novaprova/novaprova/pull/18.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/novaprova/novaprova/pull/18, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjCYGtDGhYI7ZEjGyMf3EP4QJAesrnIks5sUPqBgaJpZM4Orvx8
.

--
Greg.

I will submit a new patch.


Karate.toJava method is not working while running the karate feature files in parallel

Issue Description:
I am trying to run my feature files in parallel in async functionality using Java Thread.
Getting the below error during execution.
Acutal Error-
-unknown-:7 - javascript evaluation failed: new AsyncTest(karate.toJava(handler)), TypeError: karate.toJava is not a function
Expected Behaviour-
Feature files should execute without error and set listenResult value
Attachment
Attached sample maven project to reproduce the steps.
ParallelDemo.zip
Cmd to execute - mvn test
Java Version- jdk1.8
JUnit- 5

@sudhag85 of course. it is available only in 1.X onwards: https://github.com/intuit/karate/wiki/1.0-upgrade-guide