[HOLD][$1000] ‘&nbsp’; appears in the notification for IOU

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open chrome staging dot with User A
Go to any chat with user B. Login with User B on android app.
From user’s A account, request money to user B in a currency other than USD.
Result: You’ll see that in the notification it’s still showing &nbsp.

Expected Result:
‘&nbsp’; should not appear in the notification
Actual Result:
‘&nbsp’; appears in the notification
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.80-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/223578020-3aa5735f-4b09-45b8-b4ae-c317aabbcbb3.mp4

Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678111778601099
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0177315dd58caa2700
Upwork Job ID:<PHONE_NUMBER>113011200
Last Price Increase: 2023-03-17

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I'm able to recreate this but only using a non-USD currency, so I think that's important and comes from us putting a different character aside from $ in the notification text.
It is very similar to another GH when we use foreign characters in the request money reason.

This PR looks like it was meant to fix this - https://github.com/Expensify/App/pull/15578.

Putting this on hold and following along with https://github.com/Expensify/App/pull/15340 and will test after merge, then either move forward or close.

https://github.com/Expensify/App/issues/15665 - Closed a different GH for IOU requests. Will see if this is related and action.

Will have to get to this next week, focused on SVB stuff today.

I'm no longer able to recreate this! Looks like one of the already existing GHs took care of it. Going to close.

@strepanier03 It is reproduced with currencies without symbols. Like UAH,AED

My bad, I was rushing and tested incorrectly. Reopening.

Job added to Upwork: https://www.upwork.com/jobs/~0177315dd58caa2700

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Triggered auto assignment to @arosiclair (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

The PR you mentioned is still being worked on and looks to be addressing very similar issues. I think we should hold until those fixes are in.

Thanks @arosiclair - Will do.

PR on staging, will continue to follow.

Looks like it's no longer a problem 🙌
I tested with a couple different currencies to be sure.
ANG currency:

GNF, NOK, and ZAR currencies:

I am going to close this one out now.


[eBPF] Support submitting socket close information

[eBPF] Support submitting socket close information
This PR is for:

Agent

Affected branches

main
v6.4

Checklist

[x] Verified eBPF program runs successfully on linux 3.10.0.
[x] Verified eBPF program runs successfully on linux 4.14.x.
[x] Verified eBPF program runs successfully on linux 4.19.x.
[x] Verified eBPF program runs successfully on linux 5.2.x.

数据测试：


Exception error when running on iOS

Hi! I am experiencing issues when running my project on iOS. I get the following error:

ExceptionsManager.js:84
Exception '-[EPXProximityObserver initWithCredentials:errorBlock:]: unrecognized selector sent to instance 0x60c000010940' was thrown while invoking initialize on target RNEstimoteProximity with params (
{
appId = "my-app-id";
appToken = my-app-token;
notification =         {
text = "We'll notify you when you're next to something interesting.";
title = "Exploration mode is on";
};
}
)
callstack: (
0   CoreFoundation                      0x0000000108aa61e6 __exceptionPreprocess + 294
1   libobjc.A.dylib                     0x0000000107391031 objc_exception_throw + 48
2   CoreFoundation                      0x0000000108b27784 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3   CoreFoundation                      0x0000000108a28898 forwarding + 1432
4   CoreFoundation                      0x0000000108a28278 CF_forwarding_prep_0 + 120
5   HMExperiment                        0x000000010666c35a -[RNEstimoteProximity initialize:] + 314
6   CoreFoundation                      0x0000000108a29ccc invoking + 140
7   CoreFoundation                      0x0000000108a29b84 -[NSInvocation invoke] + 308
8   CoreFoundation                      0x0000000108a428d6 -[NSInvocation invokeWithTarget:] + 54
9   HMExperiment                        0x00000001064371fc -[RCTModuleMethod invokeWithBridge:module:arguments:] + 2796
10  HMExperiment                        0x00000001064ed242 _ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 786
11  HMExperiment                        0x00000001064ecd6f _ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$_0clEv + 127
12  HMExperiment                        0x00000001064ecce9 ___ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 25
13  libdispatch.dylib                   0x000000010ed4373b _dispatch_call_block_and_release + 12
14  libdispatch.dylib                   0x000000010ed44779 _dispatch_client_callout + 8
15  libdispatch.dylib                   0x000000010ed4e778 _dispatch_main_queue_callback_4CF + 1279
16  CoreFoundation                      0x0000000108a68c99 CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE + 9
17  CoreFoundation                      0x0000000108a2cea6 __CFRunLoopRun + 2342
18  CoreFoundation                      0x0000000108a2c30b CFRunLoopRunSpecific + 635
19  GraphicsServices                    0x000000010c2bea73 GSEventRunModal + 62
20  UIKit                               0x000000010c7ca0b7 UIApplicationMain + 159
21  HMExperiment                        0x000000010637e91f main + 111
22  libdyld.dylib                       0x000000010edb9955 start + 1
)

I've built the project using react-native init. It works fine for Android but throws the exception for iOS. The proximity observer was initialized similarly to what was shown in the example app.
Below is the content of package.json
{
  "name": "HMExperiment",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "test": "jest"
  },
  "dependencies": {
    "@estimote/react-native-proximity": "0.3.2",
    "react": "^16.4.1",
    "react-native": "^0.56.0",
    "react-native-network-info": "^3.2.2",
    "react-native-radar": "^2.0.1",
    "react-redux": "^5.0.7",
    "redux": "^4.0.0",
    "redux-actions": "^2.6.1",
    "redux-saga": "^0.16.0"
  },
  "devDependencies": {
    "babel-jest": "23.4.2",
    "babel-preset-react-native": "^5",
    "jest": "23.4.2",
    "react-test-renderer": "16.4.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

You probably have a mismatch between the react-native-proximity plugin version, and the EstimoteProximitySDK native-iOS-SDK version.
If you want to stay on "@estimote/react-native-proximity": "0.3.2", then you need the native-SDK version 0.14.0. (In your Podfile: pod 'EstimoteProximitySDK', '0.14.0', then pod update.)
But I'd recommend updating to the latest version, 0.4.0, and then you need the native-SDK version 1.0. (In your Podfile: pod 'EstimoteProximitySDK', '~> 1.0', then pod update.)
Your issue report is actually pretty revealing—the need to maintain the correct matching is probably quite a pain-point, so I'll try to experiment with bundling the native-SDK directly with the plugin. Then that burden is on the maintainers of this plugin, not on the users, as it should be (: Thanks a ton!

Thanks for your help @heypiotr ! It works now :)


live <= master

Docs Build status updates of commit e03b718:
:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/mufaro-shumba.png
:white_check_mark:Succeeded
View

advocates/mufaro-shumba.yml
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml

Line 10, Column 8: [Warning-file-not-found] Invalid file link: './map'.
Line 12, Column 8: [Warning-file-not-found] Invalid file link: './tweets'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Skip strictPropertyInitialization on derived class property with same and type as base class property and useDefineForClassFields is off

Suggestion

🔍 Search Terms
strict property initialization derived property matching base property
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
In these cases, we are already guaranteed after a super() call that the property has been assigned a value that is the type of the base class property. Thus, --strictPropertyInitialization could skip that property.
📃 Motivating Example
playground link
class Base {
    /** base tsdoc description 🤷 */
    protected value: number;

    constructor() {
        this.value = 123;
    }
}

class Derived extends Base {
    /** derived tsdoc description ✨ */
    public value: number;
        // ~~~~~
        // Error: Property 'value' has no initializer
        // and is not definitely assigned in the constructor.
}

💻 Use Cases
Derived classes sometimes redeclare properties with the same name and type annotation as parent properties, but with different peripheries such as member visibility and/or TSDoc comments.
This feels like a halfway point between a bug and a feature.

You can use declare public value: number;

True, good point! Seems odd to have to use a syntax most often used for definition files and global variable declarations in a class member, though. Perhaps I should have used the 'bug' template after all?

If useDefineForClassFields (ES-spec-compliant behavior) is enabled, or when targeting esnext, the error is actually correct, because the uninitialized property in Derived overwrites the one in Base and ends up being undefined at runtime in contravention of its type annotation.  declare is the correct way to deal with this scenario.

Err @RyanCavanaugh I think this is still a bug report


Templating feature for brackets + some style changes

Hey Teddy + other maintainers of this project,
Thanks for putting this together, I saw this link being passed around Facebook and I love the idea. Glad to see that it's picked up incredible momentum so quickly.
I wanted to contribute a few features / style changes to help out-- feel free to pick-and-choose out of the changes made, or take none of them, I understand keeping the project functional and allowing it to grow is highest priority right now.
I put together a quick fork to experiment with using the bracketed statements in the email templates to create a form that would fill the sections in the email, before either copying the text or sending it to the email client. Trying not to detract from the original simplicity, I hid the form under an accordion which you can bring up if you'd like to use it.

All original functionality works without using the form. For the most part this works well in Chrome, Safari, and Firefox, but there are some issues with longer bracketed statements like the one found in Atlanta's template: "[LIST - Community Development, COVID Relief, Education, Parks & Recreation]". I imagine there is some easy solution to this, but before I pick out all the edge cases (it also doesn't work on the Edge browser), I wanted to get this in front of some maintainers and get feedback. This templating feature of course will not be relevant if the auto-opening behavior of the email page is active, so this is mainly for those who are browsing the site.
I added a bit of styling to the bracketed statements to make them more visible,

and to the recipient + cc list to make it easier to see individual emails.

While doing this I also modified the way that some things are rendered to the DOM, using JQuery rather than directly with the Jekyll templating engine to make things easier to manage with styling (with what I know how to do, there is probably a clean way to do it using the templating engine too).
There were also a few changes made in moving where functions are located. email.js now contains the openEmail() function, and has been renamed openSystemEmail(), along with another function that specifically opens up the email in the Gmail web client. I didn't include a link on the main page to this function, but I just wanted to note here that using this link fixed issues I was having with Chrome not wanting to handle mailto: email links, in case anyone else is having that problem.
Thanks for having a look at this, and thank you again for putting this project together. It's a great idea. Besides the pull request that you never asked for, I'd be happy to contribute to this project as needed if you could use the help.

Hey @eyashi - thank you so much for your contribution! We trying to get through our backlog of content requests before reviewing contributions to the site itself. You've got some great ideas and I think we'll definitely end up using some or most of them. Stay tuned for updates, thanks again


[FLINK-7632] [document] Overhaul on Cassandra connector doc

What is the purpose of the change
Refactor Cassandra connector documentation by providing

in-depth information about Cassandra Pojo sink and Cassandra Tuple sink.
meaningful examples to show distinction between streaming over Java Tuple and Pojo data types.

Brief change log

Refactor the current usage of on Cassandra Sink w/ more in-depth information.
Provides examples for Pojo and Java Tuple data types

Verifying this change
Have tested w/ local doc server (w/ docker setup)
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive):no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no

Documentation

Does this pull request introduce a new feature? no

Nice improvement to the docs, had a few comments.

@zentol, Could you take another look? Thank you.

Hi, @zentol , could you take another look? Thank you.

Looks really god now, merging.


please add hugo-eiio theme

Hello,
I open sourced themes.
Hugo-eiio: https://github.com/leonhe/hugo_eiio
Please let me know if there are any issues.
Thanks.

Hello @leonhe,
thank you for sharing this theme with the Hugo community :+1: Let's fix the points below and we're ready to go:
Please use a valid min_version for Hugo, e.g. 0.17. Otherwise the build script for the theme site is unable to parse the metadata correctly.
Furthermore, use absolute links for the screenshot in the README. Read here why.

Hi @digitalcraftsman:
I fix this point,please check agin~
Thanks~

I've added your theme. It should be listed soon on the theme site.

Ok,Thanks~👍


Windows Package Manager Enterprise Management Docs

Type of issue
Missing information
Feedback
There aren't any links here. Just links to the root Intune page when mentioning GPOs. Would love some direct links :)
Page URL
https://learn.microsoft.com/en-us/windows/package-manager/#windows-package-manager-for-enterprise-security
Content source URL
https://github.com/MicrosoftDocs/windows-dev-docs/blob/docs/hub/package-manager/index.md
Author
@mattwojo
Document Id
805fc71b-6b54-3b09-95ef-4254de5e0036

@johnjohnjohn87 -- Could you share a little more about what sort of links you are interested in? What is the scenario that you're looking for more guidance on?


Edit Tasks

Feature Request
Feature Information:
I want to be able to edit a task instead of having to re-write the whole thing every time i want to make a minor change. As it stands when i want to go in and edit an announcement/discord trigger/other i have to delete the existing task and make a whole new one.
I confirm:

[x] that I have searched for an existing feature request matching the description.

This has been implemented and was released in AMP <IP_ADDRESS>.


Add GitHub Advanced Setup lesson

@brian-rose following your review we can merge if it looks good.


View data in CLI

I have file tst.php
require_once 'vendor/autoload.php';
d([1, 2, 3]);

run this file in cli with php-kint v3

and with php-kint v1

Why data displaying is not correct in php-kint v3?

That's weird - are you running them both in the same terminal?
In either case - your terminal doesn't seem to support unicode and/or color codes. On windows?

Yes, on windows )

Could you var_dump the value of the KINT_WIN constant?

In v1

in v3

I am find solution
Kint\Renderer\CliRenderer::$cli_colors = false;
d([1, 2, 3]);

Yeah that turns off the colors, but it's not supposed to look like that to begin with:
┌──────────────────────────────────────────────────────────────────────────────┐
│ $a                                                                           │
└──────────────────────────────────────────────────────────────────────────────┘
...
════════════════════════════════════════════════════════════════════════════════

I'd like your help to fix this, but I have no idea when I'll get around to it

never code on windows 🙈 😂

Now that Windows 11 & Microsoft Terminal support VT100 colors and UTF-8 table characters, I'm looking for a way to enable it back on CLI!

Results

@DRSDavidSoft That's great!
I don't code on windows here, so I'd have to set up a VM to test this stuff myself. I know about WSL but I didn't know it'd work like this with just normal cmd nowadays (Or are these screenshots with WSL?)
Does this basically mean that in normal circumstances you can run kint from a windows terminal and colors and utf will work out of the box? If that's the case I may just change the defaults, remove the windows-specific code there, and close this issue.

@jnvsor Thanks for all your work!
I mainly code on Windows at the office, and for a project, I'm developing a CLI script with PHP.  Note: I haven't used WSL, it's just native php.exe builds for windows from here i.e. the same stuff that WAMP and IIS use.
The screenshots you see are native cmd.exe without WSL, the only changes I've done is tweaks to the color schme.
Sidenote (off-topic): I've been using Cygwin since long before WSL/1 was a thing, so I don't have much experience with WSL either -- although, in my tests, mingw/Cygwin build of PHP behave the same.

Does this basically mean that in normal circumstances you can run kint from a windows terminal and colors and utf will work out of the box? If that's the case I may just change the defaults, remove the windows-specific code there, and close this issue.

Considering Windows 11 and PHP 8.x, yes!  But since Kint is still supporting the older PHP versions on Windows, the time hasn't come yet to do this.
I'm sad to say, until you bump the minimum supported PHP version by Kint from 5.6 to 7.2, it might not.
For now, I'd suggest to consider something like this:

set the default to false
if PHP_VERSION is 5.6 or less, return false immediately
does this function exist: sapi_windows_vt100_support()

no? return false immediately

does that function return false? return false immediately

otherwise, return true

Here's a code for that:
Kint\Renderer\CliRenderer::$force_utf8 = false;

if ( substr(PHP_OS, 0, 3) === 'WIN' )
    Kint\Renderer\CliRenderer::$force_utf8 = checkWindowsVT100();

function checkWindowsVT100()
{
    if ( !function_exists('sapi_windows_vt100_support') )
        return false; // note: no need to check for PHP 5.x as this function only exist on PHP 7.2.0

    if ( sapi_windows_vt100_support(STDOUT) )
        return true;

    return false;
}

A bit of history:
I clearly remember having the same difficulties mentioned in the beginning of this issue, in the days of using PHP/7.0 -- namely, no VT100 for color support and the unicode table drawing characters getting garbled.  That's why I stopped using Kint on the CLI and only used it for CGI scripts (which it worked awesome-ly).
After I upgraded to PHP/7.4, I modified my existing logging utilities to output in color.  A couple of days ago, I needed to dump a variable, and I remembered to use Kint, so I checked to see if it would work in my project.  It did, however, the color was turned off by default!
So I dig into the code to see if I could make the colors for Kint output correctly, and it does!
Since PHP/7.x is EOL now, and the versions of Windows 10 (and older) that does not support VT100 correctly are also EOL, I think it's a good time to implement the code I suggested, so Kint would output in all its glory, with the unicode tables, and the colors!
After PHP 5 and 7 support is dropped from Kint (maybe in 4-5 years, when Windows 10 is also EOL), then it would be possible to treat a Windows/PHP environment the same as on Linux and macOS (and thus removed all Windows-sepcific code for CLI).
Anyways, sorry for the long comment! I'll be glad to help, if any. Especially, with testing, if needed.

@DRSDavidSoft That's great!

I'm sad to say, until you bump the minimum supported PHP version by Kint from 5.6 to 7.2, it might not.

I was worried about that too: I'd have to postpone this until v5. But since we have a function to check for support I can slap this in a minor release instead.
The only thing I'm worried about is this:

the versions of Windows 10 (and older) that does not support VT100 correctly

What kind of overlap do we have between buggy windows versions that won't show utf8 and/or color control codes correctly that sapi_windows_vt100_support still returns true for? I wouldn't want to completely fubar the output with control codes just because someone's on a buggy old windows version (As opposed to a buggy new windows version)
Or should I just ignore that edge case entirely and just check with the function? (I'll take your word for it since you're half the userbase hehe)
Here's my WIP diff, if you want to give it a whirl:
@@ -69,8 +76,8 @@ class CliRenderer extends TextRenderer
     {
         parent::__construct();

-        if (!self::$force_utf8) {
-            $this->windows_output = KINT_WIN;
+        if (!self::$force_utf8 && KINT_WIN && (!KINT_PHP72 || !\sapi_windows_vt100_support(STDOUT))) {
+            $this->windows_output = true;
         }

         if (!self::$terminal_width) {

@jnvsor Awesome, I did some research in order to answer confidently.

I was worried about that too: I'd have to postpone this until v5. But since we have a function to check for support I can slap this in a minor release instead.

That would be a good idea, I'll be glad to test Kint 4.1. Also, I figure there could be other kinds of PHP-5.6 related code that might get dropped in Kint 5, when backwards compatibility for PHP-5.6 is no longer needed.

What kind of overlap do we have between buggy windows versions that won't show utf8 and/or color control codes correctly that sapi_windows_vt100_support still returns true for? I wouldn't want to completely fubar the output with control codes just because someone's on a buggy old windows version (As opposed to a buggy new windows version)

I did some tests to be sure, and also looked at the PHP source code.  This function will not return true, if the host console doesn't support VT100.  According to the PHP source code, it's calling the GetConsoleMode() from Win32 SDK, and checks if the ENABLE_VIRTUAL_TERMINAL_PROCESSING flag is present.
Since the flag is only introduced in recent versions of Windows 10 where VT100 is handled correctly, it simply doesn't exist in the older versions of Windows.
This means that if the Windows' Console Host doesn't support VT100 processing, the PHP's VT100 support function will return false, which is consistent with my tests (running PHP 7.2 and PHP 8.x on Windows 7 or Server 2008). (n/b: MSDN also provides a code sample which also confirms this method).
In short, you can be assured that the terminal will support VT100 for certain, if this functions returns true.

Or should I just ignore that edge case entirely and just check with the function?

The thing is, if you check with sapi_windows_vt100_support() and it returns true, I'd say there is zero chance that it would be a false positive and render CLI color/utf-8 incorrectly.
On the other hand, what if it returns false, and it's decided that the host for certain doesn't support VT100 processing, i.e. a false negative?  That's where the edge cases arise, since the user could be using another terminal emulator on Windows (such as ConEmu, which has support for VT100 color/utf-8) -- but Kint decides not to render the color/utf-8, even though the actual terminal emulator supports the VT100 escape sequences.
For the false negative, I'd say you can safely ignore it, as the worst case scenario is that the user would be missing the color/utf-8, but the results would render correctly (same as the current Kint 4.0 behavior).
In this unlikely scenario, the users can either a) force-enable color output for Kint themselves, b) don't care and ignore not having the colors, c) upgrade their OS to a supported one.  Honestly, the Windows 7 and the buggy Windows 10 releases are all EOL (the same way all PHP 5.x and PHP 7.x are EOL now), so I wouldn't stress on that much.
You can also test for other terminal emulator (such as ConEmu) specifically like this, but that's a whole another matter entirely.
if ( filter_var(getenv('ConEmuANSI'), FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE) === true )
    Kint\Renderer\CliRenderer::$force_utf8 = true;

Pros: Better support for ConEmu, which is an awesome terminal emulator
Cons: Only for ConEmu, missing all other terminal emulators, such as Microsoft Terminal, Mintty, etc ...

(I'll take your word for it since you're half the userbase of this feature hehe)
Lol flattered to hear that, I feel like I'm the >1% of people who develop CLI applications with PHP on Windows 😅 (I also obviously use them on Linux too, so it might be more cross-platform that Windows-only)

Here's my WIP diff, if you want to give it a whirl:

So clean and efficient!  I didn't know there were macros like KINT_PHP72 or KINT_WIN specifically for checking PHP version and OS type! :D
I tested it out, and the logic also seems to make sense.
The only issue I'd see with this is the false negatives, which as I mentioned, I don't consider to be a top priority.  In fact, it's up to the terminal emulator to announce to PHP and Kint that it supports VT100!
I'm not sure if you're doing this, but you need to also check for the TERM environment variable on *nix too, for example if TERM=xterm, TERM=xterm-256color or TERM=cygwin, then VT100 is supported.  Otherwise, you shouldn't output color on Linux.
All Linux-based terminal emulators will set this environment variable properly, which means that the terminal emulator is announing to the application that it will support the VT100 escape codes.
If it's missing, you can still output the VT100 color codes, but there is NO guarantee that what will the terminal emulator do with this.  In fact, that's part of the problem on Windows:  the conhost.exe did not specify to the program that it would support VT100 escape codes.  Now, if the program would output the escape codes blindly, Windows would display garbled characters, whereas most Linux terminal emulators would display it correctly.
As always, I'm super sorry for the really long comment, hopefully it wasn't entirely off-topic or useless.
Thanks for the work you do!
Looking forward for the changes to Kint

@michabbb Hey Micheal, may I ask why the downvote? Is it something that I said?

So clean and efficient! I didn't know there were macros like KINT_PHP72 or KINT_WIN specifically for checking PHP version and OS type! :D

Yeah but they're undocumented and only used internally so you shouldn't rely on them in your own code :)
It's actually giving me trouble with psalm because psalm gets their type wrong and won't let me fix it with annotations because they're constants...

the user could be using another terminal emulator on Windows (such as ConEmu, which has support for VT100 color/utf-8) -- but Kint decides not to render the color/utf-8, even though the actual terminal emulator supports the VT100 escape sequences.

I remember using kint in CLI on windows with the git shell installation (Though I avoided windows as much as possible) and it worked with colors just fine, though that might have been because I was running it from a linux server through SSH...

For the false negative, I'd say you can safely ignore it, as the worst case scenario is that the user would be missing the color/utf-8, but the results would render correctly (same as the current Kint 4.0 behavior).

I plan on replacing the current windows output with plain ascii anyway since it's clearly not working correctly. That should improve things for basically everyone.

I'm not sure if you're doing this, but you need to also check for the TERM environment variable on *nix too, for example if TERM=xterm, TERM=xterm-256color or TERM=cygwin, then VT100 is supported. Otherwise, you shouldn't output color on Linux.

That's a good point. I know some programs (ls comes to mind) remove colors when being piped to something else, so I'm pretty sure there's more to check with this than just $TERM...
I'll dig into it, but I doubt I'll add checks for colors in linux. (At least in 4.x) I personally use less -R occasionally so I suspect there may be people relying on it outputting colors, and configuration would get a lot more complex if I started adding a bunch of flags for that too. It'd need to be rethought out from scratch

the user could be using another terminal emulator on Windows (such as ConEmu, which has support for VT100 color/utf-8) -- but Kint decides not to render the color/utf-8, even though the actual terminal emulator supports the VT100 escape sequences.

I remember using kint in CLI on windows with the git shell installation (Though I avoided windows as much as possible) and it worked with colors just fine, though that might have been because I was running it from a linux server through SSH...

I believe that's exactly it, the raw output is passed from Windows to Linux in this scenario, and the Windows-side doesn't care _what's _ that being passed, escape code, or some other binary data.  Then, in the Linux side, the GUI Terminal emulator (like GNOME Terminal or Konsole) actually parse and render the received escape code data.
The reverse can also work correctly, e.g. if I ssh into my Linux box from Windows, I can run htop or screenfetch and it would render correctly on Windows.  (sidenote: PuTTY, a popular SSH client for Windows with built-in Terminal emulator, already supported the escape code since the ancient XP era! That's also what Kitty is based on.)

I plan on replacing the current windows output with plain ascii anyway since it's clearly not working correctly. That should improve things for basically everyone.

That's a good idea, although I suggest mostly focusing on the general color/utf-8 based rendering, as it's more cross-platform, and Microsoft is finally getting their act together to fix these annoying bugs, so the conhost.exe finally work correctly like on almost all other terminal emulators for other OSes out there.
In the future (especially on Windows 11), I expect the VT100-based codes to work 100% correctly out of the box, like how it does now on macOS, and Linux.

That's a good point. I know some programs (ls comes to mind) remove colors when being piped to something else, so I'm pretty sure there's more to check with this than just $TERM...
I'll dig into it, but I doubt I'll add checks for colors in linux. (At least in 4.x) I personally use less -R occasionally so I suspect there may be people relying on it outputting colors, and configuration would get a lot more complex if I started adding a bunch of flags for that too. It'd need to be rethought out from scratch

That's also a great idea!  I'd suggest having a general cli_color_enabled value, that is configured by the user (and defaults to true), and a general cli_color_supported that would work both for Windows, and Linux. (names can be anything, I used these for example).
That way, the user can set cli_color_enabled to false, in order to force no color/utf-8 output.
Otherwise, Kint can do a check for determining the value of cli_color_supported, based on the current running platform (e.g. Windows or Linux).
If it's on Windows, check for *_vt100_support() return value.  Otherwise, check for the proper environment variables.
This can allow the codebase to be simplified in this regard, while also becoming more logically understandable.
In any case, if the either cli_color_enabled is false, or cli_color_supported is false, instead of color/utf-8 a simplified version could be rendered for the user.
Once again, sorry for the long comment, thanks for your development, I really appreciate it! :D

That's a good idea, although I suggest mostly focusing on the general color/utf-8 based rendering

Yeah it's mostly just because we still support < 7.2. I'd love to get rid of the edge cases, but not just yet

That way, the user can set cli_color_enabled to false, in order to force no color/utf-8 output.

Well that already exists it's CliRenderer::$cli_colors - I'm just thinking we'd need another property to force it one way or another if we enable automatic detection, like we have CliRenderer::$force_utf8 for windows and mode constants for Kint::$enabled_mode

Confirmed that this works correctly

PHP Version
VT100 Support
Kint CLI Result
Correct Behavior?

7.0 (no vt100 support)
No (Win 7)
No color
✔

8.1
No (Win 7)
No color
✔

7.0 (no vt100 support)
Yes (Win 11)
No color
✔

8.1
Yes (Win 11)
Color
✔

Thanks again, and good night!
n/b 7.2-7.4 also works in place of 8.1,
5.6 also works in place of 7.0

May I also suggest the following flags:

CliRenderer::$cli_colors (i.e. does the user request color?)

true: force yes
false: force no
null: auto detect

reason: in this case, $cli_colors means force the value specified by the user.  if it's ok to differentiate between false and null, then I'd suggest this
or:

CliRenderer::$bypass_detect_cli:

false: try to detect if the cli supports color.
only allow color if both this and $cli_colors is true
true: force the value provided by the user, regardless of detection

reason: I believe the term force in the flag name could be ambiguous, I mean what would be the desired behavior if $cli_colors is false, but $force_* is true?  One outcome is to not output color since $cli_colors is false, but I'd argue that since $force_* is true, I'd expect that Kint should output color.
However, the term bypass_detection clearly means stop detecting the color support, respect the value specified by the user, even though if the console doesn't support color.

Also, instead of this:
[' ', '=', ' ', '|', ' ', '-', ' '],

I suggest the following:
['.', '=', '.', '|', '\'', '-', '\''],

Confirmed that this works correctly

Great!

May I also suggest the following flags

The bool|null option definitely seems like the way to go, but that'd be a breaking change. It'd have to wait for a major version and that's probably quite a ways off. I'd rather work on smaller easier to implement features and drop some minor versions instead

I suggest the following

My first thought would be that the . should be , to match ' but that depends on the terminal font, so my second thought is that if your terminal font has a slanted ' glyph it won't line up. Something like:
.---.
| a |
’---’

I tried extending the top/bottom and sides and it didn't look right either:
|---|
| a |
|---|

-----
| a |
-----

-----
| a |
|---|

In the end I don't want to put much time into something hopefully no users will ever have to see, so I'll leave it like that. If anyone prefers the � they can always go back hehe
 ---
| a |
 ---

Never thought I'd be closing this one without a mountain of work. Glad to get it off the docket :)


Allow Device Name change while BLE is running

As you mentioned (@h2zero) in #359 :

Do you need to change the advertised name or the device name?, they're different things.
To change the device name you would need to call deinit/init with the new name.

I would like the capability to change the device name WITHOUT deiniting BLE.
Bluedroid currently supports this functionality in some way and it would be nice to have it here.

I added this:
void NimBLEDevice::setDeviceName(const std::string &deviceName) {
    ble_svc_gap_device_name_set(deviceName.c_str());
}

To NimBLEDevice.cpp and it appears to be doing what I need.
Are there any complications of doing this?

That's the correct solution. If you would like to PR that I would be happy to merge it.

Added the PR for this code in #421
Thank you @h2zero


ci: Add initial scale test workflow for bootstrapping

Please ensure your pull request adheres to the following guidelines:

[X] For first time contributors, read Submitting a pull request
[X] All code is covered by unit and/or runtime tests where feasible.
[X] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[X] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[X] All commits are signed off. See the section Developer’s Certificate of Origin
[X] Provide a title or release-note blurb suitable for the release notes.
[X] Are you a user of Cilium? Please add yourself to the Users doc
[X] Thanks for contributing!

This commit acts as an initial effort to add automated scale testing to Cilium, as described in https://github.com/cilium/design-cfps/pull/11. The workflow added as part of this commit is meant to lay down a foundation that can be built upon, with the intent that it will be iteratively developed on to carry out the CFP. The workflow currently performs the following:

Create a two-node GCE cluster using kops
Run a bare-bones ClusterLoader2 configuration
Cleanup the cluster

The following next steps are a WIP:

Expand on the ClusterLoader2 configuration
Increase the number of nodes in the cluster
Export results from ClusterLoader2
Allow for manual runs using WorkflowDispatch

Note: ClusterLoader2 is currently pulled from a fork containing changes that are intended to be merged upstream in the coming week.
Fixes: https://github.com/cilium/cilium/issues/27749
Add initial, in-progress workflow for automated scale testing

Before doing a force push to remove items from the workflow that were needed for testing (a push trigger), this was the last successful run: https://github.com/cilium/cilium/actions/runs/6424076662/job/17443936075. Since this PR just adds a new workflow file and doesn't make any other changes, I don't believe it needs the full test suite. Therefore, I'm going to mark this as ready to merge.


Syntax errors in @ppxCustom example

The example with recursive definitions from https://beta.graphql-ppx.com/docs/directives#ppxcustom
module UserQuery = [%graphql {|
  query {
    user @ppxCustom(module: "User") {
      id
      name
    }
  }
 |} and User: {
   type t = {
     nameAndId: string
   };
   let parse: UserQuery.t_user => t;
   let serialize: t => UserQuery.t_user;
 } = {
   type t = {
     nameAndId: string
   };
   let parse = user => {
     nameAndId: switch (user.name) {
       None => "Noname" ++ user.id
       Some(name) => name ++ user.id
     }
   };
 }

has syntax errors.
It should at least be
module rec UserQuery = [%graphql
  {|
  query {
    user @ppxCustom(module: "User") {
      id
      name
    }
  }
 |}
]
and User: {
  type t = {nameAndId: string};
  let parse: UserQuery.t_user => t;
  let serialize: t => UserQuery.t_user;
} = {
  type t = {nameAndId: string};
  let parse: UserQuery.t_user => t =
    user => {
      nameAndId:
        switch (user.name) {
        | None => "Noname" ++ user.id
        | Some(name) => name ++ user.id
        },
    };
};

(Beware that this still won't compile due to the missing serialize function and there's not a way to write a sane one)

Haha you are right. I don't know what I was thinking. This is not a great example, should be better.

I don't know what I was thinking.

You're pulling a lot of weight! Mistakes are bound to happen


ethminer: provide a CUDA-free version

Motivation for this change
The cuda version is broken and my AMDGPU system doesn't need it to be built with CUDA.
cc @nand0p @noneucat @r-burns @danieldk
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120588 at 12675a78 run on x86_64-linux 1

2 packages marked as broken and skipped:

ethminer
ethminer-cuda

1 package built successfully:

ethminer-free

1 suggestion:

warning: unclear-gpl
gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/misc/ethminer/default.nix:83:5:
   |
83 |     license = licenses.gpl2;
   |     ^

@ofborg build ethminer ethminer-cuda ethminer-free


(FACT-1119) Add acceptance test for Mac OS X facts

Adds an acceptance test for core Mac OS X facts on 10.9 and 10.10.
[skip ci]

Verified using rake ci:test:aio SHA=8a07e1a5c98ca3a8ddeb9c55d820ade9e1fffa67 CONFIG=config/nodes/osx-109-x86_64.yaml TEST=tests/facts/macosx.rb SUITE_VERSION=<IP_ADDRESS>.g8a07e1a and osx-1010-x86_64.yaml.

CLA signed by all contributors.


Pipelining / stacking strategies

Hey Saeed - been looking your finmarketpy library - looks nice!
What wasn't clear to me from looking at it was if you can stack strategies upon each other?
For example:

I have 4 building-block strats which solely roll commodity futures contracts.
I have 2 strategies, say Seasonality and Momentum taking roll strats as an underlying "asset".
Combine as a portfolio with some smart switching taking all 8 as inputs

Is that achievable ?
I couldn't see how it would be set up and return risk metrics at each constituent level.

Thanks @flipdazed - one way to do this, would be to construct TradingModel classes for each of your building blocks. You'd then create a another portfolio based TradingModel strategy, and you'd fill the load_asset method to construct all the building blocks. The construct_signal method could be filled with all your weightings. You can then access all the return risk metrics for the whole portfolio, do all the sensitivity analysis (using TradeAnalysis) too.
At the moment there are automatic processes for doing things like vol targeting, but can imagine that people might want more complicated portfolio construction too.
However, I can add additional functionality to make this stacking of strategies a bit nicer/easier with TradingModel? One way I thought of doing this, would be simply to add your substrategies as parameters to the BacktestRequest and all the load_assets stuff would get filled automatically. You'd just need to write the scheme for construct_signals (and could default that to equal weighting). How does that sound?

Ok I'll check how that works and get back to you


How to update uploaded file ? (using AWS s3 Integration)

First of all, Thanks for maintaining great library
I have a question:

Describe your feature / request
How to update image when using AWS s3 Integration.

I used the code wiki provided. it works well!
I can create documents of userFiles collection and the file was uploaded on my s3 buket,
The next step after successing uploading is updating current file which was already uploaded.
I checked example at github, however, I failed to find how to update the file. ( How to update the document  or what kind of API should I use...)
Can you give me some advise?

Hello @csKangGdcomm ,
What do you mean by "How to update the document"?

Update record's meta-data?
Update file itself?

{   _id: 'RsxiWy6v5RQsc5QxN',   size: 84115,   type: 'image/jpeg',   name: '1.jpeg',   meta: {     userId: '4BRjnRDKSPJ9vdmFQ',     location: 'fake',   },   ext: 'jpeg',   extension: 'jpeg',   extensionWithDot: '.jpeg',   mime: 'image/jpeg',   'mime-type': 'image/jpeg',   userId: '4BRjnRDKSPJ9vdmFQ',   path: 'assets/app/uploads/uploadedFiles/RsxiWy6v5RQsc5QxN.jpeg',   versions: {     original: {       path: 'assets/app/uploads/uploadedFiles/RsxiWy6v5RQsc5QxN.jpeg',       size: 84115,       type: 'image/jpeg',       extension: 'jpeg',       meta: {         pipePath: 'v1/DQdGybu4SNkgXmSpY-original.jpeg',       },     },   },   _downloadRoute: '/cdn/storage',   _collectionName: 'ImageFiles',   isVideo: false,   isAudio: false,   isImage: true,   isText: false,   isJSON: false,   isPDF: false,   _storagePath: 'assets/app/uploads/uploadedFiles',   public: false, };
above is the document of FilesCollection collection.
I think Update file means the document should be updated with the information (size, type, name,  especially versions.original.meta.pipePath(location of AWS S3) and etc... ) without _id.
After updating the file, User can see the new uploaded file.
I think insert api just create new document with new information, I can replace the new _id of document, but It seems that it is not exactly update the information....
Simple use case is that user upload image. after that, the user want to change the image. So, the system should change new image and should delete the old image already uploaded.
Thank you!

@csKangGdcomm

Simple use case is that user upload image. after that, the user want to change the image. So, the system should change new image and should delete the old image already uploaded.

Just remove old file and record in DB, and upload a new one, no need to update it. Plus it's correct way to avoid running into the cached results as file will have new _id and URL.

I need the versions.original.meta.pipePath because after updating file, the system have to delete the file which is already uploaded on AWS s3.

If you've followed our tutorial you don't need to do it manually, we've covered this case here:
  // Intercept FilesCollection's remove method to remove file from AWS:S3
  const _origRemove = UserFiles.remove;
  UserFiles.remove = function (search) {
    const cursor = this.collection.find(search);
    cursor.forEach((fileRef) => {
      _.each(fileRef.versions, (vRef) => {
        if (vRef && vRef.meta && vRef.meta.pipePath) {
          // Remove the object from AWS:S3 first, then we will call the original FilesCollection remove
          s3.deleteObject({
            Bucket: s3Conf.bucket,
            Key: vRef.meta.pipePath,
          }, (error) => {
            bound(() => {
              if (error) {
                console.error(error);
              }
            });
          });
        }
      });
    });

    //remove original file from database
    _origRemove.call(this, search);

Thank you so much!
I understand what you mean. I should follow your way.
Anyway, I already stared this repo 👍

@csKangGdcomm thank you, hope my answer helped you :)


Translation changes.

Mainly translated the examples and other minor translation changes.
Also 'Hello world!' could be translated to 'Hola mundo!' but i don't like that change.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Thesaurus integration

http://www.quora.com/Is-there-an-online-synonym-API
http://words.bighugelabs.com/api.php
http://thesaurus.altervista.org/
http://www.programmableweb.com/api/thesaurus

We will integrate more services https://github.com/okulbilisim/thesaurus-manager/blob/master/app/commands/ThesaurusSuggestions.php
Bbut the main objective of this thesaurus project is to create a custom thesaurus manager companies/institutions.

Related : https://github.com/okulbilisim/thesaurus-manager/


Clicking with LMB and RMB at the same time makes window unresponsible

Clicking 2 buttons at the same time makes window unresponsive

Open any sub-window,
Click both left and right mouse button at the same time.

Result: Window can’t be moved, closed, interacted with, etc.
This was true with yesterday’s build, I can’t test with today’s build because of #13

Is this fixed yet?

Yes, the problem doesn’t happen anymore, thanks!

Closed as user reports solved.


cannot open source file "envoy/config/route/v3/route_components.pb.h"C/C++(1696)

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: One line description
Cannot find some pkg in code.
Description:

Describe the issue.

cannot open source file "envoy/config/route/v3/route_components.pb.h"C/C++(1696)

cannot open source file "absl/container/node_hash_set.h"C/C++(1696)

[optional Relevant Links:]

Any extra documentation required to understand the issue.
I'm newer to c++, otherwise, expect your warningly response.Thanks a lot!

That file is generated during the build. See .devcontainer/README.md -- I think that might help, but I don't use VScode. Another option might be to ask in the Envoy slack.

Please check tools/vscode, then you can run task to refresh comdb.

Thanks for your warmly replying. Because of my GreatWall Internet in China, I cannot download some packages by executing the shell as the tools/vscode.
By the way, which IDE your are using and recommend.

I think you need a proxy server to download the necessary dependencies.
The vscode is official support, others I have no ideas.


[WIP] Add Raycast node

This crashes at the moment, not even sure if this will turn out to be possible but trying to see if I can move vertices based on a raycast so we can have a path follow the contours of the environment and then extrude. Cool for extruding cables, roads over a terrain etc.

Add a raycast to the example raycast rope, hook it up to the curves output on one side and the path input on the other, and it crashes atm :(

Looks like GDNative is not getting data from the physics engine properly.. :(


fix a few links in the development file under adding New CRD types

The Adding New Types section under the DEVELOPMENT.md has a reference to alpha APIs instead of beta. We are now adding a new CRD to beta APIs. No changes being done in alpha APIs.
Please change this note:
Add go structs for the types in pkg/apis/pipeline/v1alpha1 e.g condition_types.go This should implement the Defaultable and Validatable interfaces as they are needed for the webhook in the next step.

to:
Add go structs for the types in pkg/apis/pipeline/v1beta1 e.g task_types.go This should implement the Defaultable and Validatable interfaces as they are needed for the webhook in the next step.

Change the links to v1beta1 APIs, such as:
Add go structs for the types in
    [pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1) e.g
    [task_types.go](./pkg/apis/pipeline/v1beta1/task_types.go) This
    should implement the
    [Defaultable](./pkg/apis/pipeline/v1beta1/task_defaults.go) and
    [Validatable](./pkg/apis/pipeline/v1beta1/task_validation.go)
    interfaces as they are needed for the webhook in the next step.

And add the new types to v1beta1:
Add the new type to the
    [list of known types](./pkg/apis/pipeline/v1beta1/register.go)

I would be happy to work on the change, looking into this..

When we add new fields to a beta API we add them in the beta folders, not in the alpha - even though we still need to make sure that the beta API can roundtrip to alpha and back to beta. The new fields will be considered of "alpha" level stability, even if defined in the beta API.
When adding brand new CRDs however, they would be alpha, not beta. We never enforced having the same level of API stability across CRDs (see PipelineResources and Conditions) and I don't think we should.
@pritidesai @vdemeester wdyt?

yup, CRDs are added as alpha.  My bad,  was reading this section in context of new fields in beta API 😜


Add an option to emit an aggregated transaction summary up to a certain date.

It may be convenient to compact transactions from previous years into a single summarized transaction.
Right now this is a little inconvenient, since the renderer doesn't show enough significant digits to always form a TX which produces identical output. There may need to be extra logic to safely emulate superficial losses.
Perhaps something like  --aggregate-upto 2019-12-31
The answer may also vary depending on what txs appear after this date.

Opted for a simpler approach for now, to just have an option to show more sigfigs.
929bf40e8f932bd8619c565fd2c2cdfdc5604ed8


Add parameter bind_addr to ApplicationEntity.

It will restrict the network interface to listen on. This is useful when one wants a server to accept
connections only from a certain set of hosts (e.g., local processes)

Can you add some test coverage for the change please?


Users can check off all completables (resource, skills, etc).

Once merged, this resolves #163.

Great work!!

@mattstauffer all set here. merging into your feature branch.


Support Tailwind SSR Styling

Describe the feature

Screenshots are from Next configuration and it supports prestyling on server side
const nextConfig = {
//...
experimental: {
optimizeCss: true, // enabling this will enable SSR for Tailwind

},
};
Additional information

[X] Would you be willing to help implement this feature?
[X] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Would you be able to provide a reproduction? 🙏
More info

Reproduction repository here

@sobbey99 please provide a minimal reproduction without additional plugins or modules (except the tailwind module)

Just commited, actually only additional module is tailwind

@sobbey99 please provide a minimal reproduction without additional plugins or modules (except the tailwind module)

@sobbey99 you need to add your server's source file paths to your tailwind config's content array, or use the safelist property.
See more at the official tailwind documentation: https://tailwindcss.com/docs/content-configuration


Corner case when passing images as numpy arrays to detectAndCompute

Thank you very much for the great work!
I noticed a potential issue: Looking at the LighterGlue demo for XFeat, loading an image via imageio seems to be perfectly acceptable. The imio.v2.imread function returns a numpy array. Passing it to detectAndCompute, the preprocess_tensor function converts the numpy array to a tensor. However, this only happens if the image is an RGB image. It crashes if the image is an grayscale image.
The correspoding code snippet is here: https://github.com/verlab/accelerated_features/blob/main/modules/xfeat.py#L220-L222
Not sure what the most principled solutions is here.

Hi @tsattler, thanks for the feedback!
Indeed there is a bug, thank you for reporting this. I believe with the fix I provided it should work with grayscale (H,W) images. Now I'm checking if numpy array shape is 2 or 3 to handle it correctly, and also some other checks to avoid other shape mismatches.

Looks good, many thanks!


README

README
User Story
As a boot camp student,
I want the prework notes to be structured on a website,
So that I can easily find and read the information.
Acceptance Criteria
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see a professional README that provides information on the project and how to use it

README done!


Update Composer dependencies (2023-05-24-00-08)

Visual regression test passed!
View the visual regression test report


Ignore grouped tests

The idea of skipping the grouped tests was discussed with @llowinge

Thats great @ppalaga !


Sample to create Duplicate Rule using Metadata API

Hello,
I am trying to create DuplicateRule and reorder them using MetadataService Class, but I did not find luck can anybody share code snippets or guidance.
Thanks & Regards,
Shrikant
<EMAIL_ADDRESS>

I have the same issue with code:
MetadataService.MetadataPort service = new MetadataService.MetadataPort();
MetadataService.DuplicateRule customObject = new MetadataService.DuplicateRule();
customObject.actionOnInsert='allow';
customObject.actionOnUpdate='allow';
customObject.isActive=true;
customObject.masterLabel='Main Label';
customObject.sortOrder=3;
MetadataService.SaveResult [] results = service.createMetadata(new MetadataService.Metadata[] { customObject });
Error: Line: 10, Column: 97
Initial expression is of incorrect type, expected: MetadataService.Metadata

Yes it looks like DuplicateRule is not extending the Metadata base class. You can make the changes manually, just follow the pattern of one of the other types like CustomField for an example. Meanwhile i'll flag this as a bug.

Hello Andrew,
I unsubscribed but I'm still receiving emails.
Thank you.
Sent from my iPhone

On Mar 19, 2017, at 12:14 PM, Andrew Fawcett<EMAIL_ADDRESS>wrote:
Yes it looks like DuplicateRule is not extending the Metadata base class. You can make the changes manually, just follow the pattern of one of the other types like CustomField for an example. Meanwhile i'll flag this as a bug.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@md6759 i am not sure how to help? I do not control GitHub... Sorry.


Feature/cookies

Pull Request Test Coverage Report for Build 77

12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.903%

Totals

Change from base Build 75:
0.0%

Covered Lines:
438

Relevant Lines:
452

💛  - Coveralls

I can see that the test has passed so approved


[MF Plugin] "promise new Promise" syntax doesn't work with @ char in it

Describe the bug
It seems like with the enhanced version of ModuleFederationPlugin, the promise new Promise syntax fails to be parsed when there is a @ character in the middle of the template string. Otherwise, the resolution still works as it does in Webpack's version.
What seems to be happening is that whenever the parser finds the @ char, it splits the string to find the host name and URL part instead of taking promise new Promise identification as a priority.
Reproduction
https://github.com/module-federation/core/compare/main...ryok90:core:main
Used Package Manager
pnpm
System Info
System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M2 Pro
    Memory: 668.42 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v20.10.0/bin/yarn
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
    pnpm: 9.4.0 - ~/.nvm/versions/node/v20.10.0/bin/pnpm
  Browsers:
    Chrome: 126.0.6478.127
    Safari: 17.5

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

the entry parser has some bugs with this format entry , i will fix it

the entry parser has some bugs with this format entry , i will fix it

Heey there @2heal1
Thank you for your reply!
@ScriptedAlchemy might be onto it already I think.

Yeah @ScriptedAlchemy has talked with me .
You can try with this version<EMAIL_ADDRESS>There is something you need to pay attention is that promise new Promise entry will be loaded as MFV1 , it means you can not use MFV2 runtime API .
I highly recommend you use mfv2 runtime api to load the dynamic remote like this demo:

[register remotes] (https://github.com/module-federation/core/blob/main/apps/runtime-demo/3005-runtime-host/src/bootstrap.tsx#L13)
load dynamic remote

@2heal1 it worked!
Thank you very much for the quick fix and response!
Closing this one as resolved!
In the future, we will indeed be looking to use the runtime API to solve these issues but ATM we only need the legacy compatibility to make a step work.
Thanks again!


Version 1.x is not compatible with PHP 5.6

In version guidance is info that version 1.x is compatible with PHP 5.6:

But there is a problem, for example:
private function encodeImage(string $image_path)

in
https://github.com/PrestaShopCorp/module-lib-billing/blob/1.x/src/Presenter/BillingPresenter.php#L154
I found only this one, but maybe there are more incompatibilities

Hello @WojtekBrzezinski19!
Thank you for your report
I just made a small PR to fix PHP compatibility


Spotify support

Checklist for new Strategies for Spotify

[x] Create a new strategy file (e.g. like this)
[x] Add tests
Add it to the README.md:

[x] About
[x] <Platform> specific environment variables
[x] Endpoint

[x] Test locally with your account

This should be good to go, test coverage is 100%, there are some formatting changes in the test file, hopefully are not a deal breaker  while reviewing

Coverage increased (+0.03%) to 99.394% when pulling 4a8ad62bbaf373cfdccf106d1b431824b1bfea9e on matteo-hertel:spotify-support into 2ae05f3c2d77800a54db7371c0f3a9b8ba5d9d40 on lipp:master.

🥇  Awesome! Thanks a lot! Will release a new version soon...


Add GitHub Actions - Checks

Codecov Report

Merging #222 (5e34a03) into 2021.3.x (ffb297f) will decrease coverage by 1.49%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           2021.3.x     #222      +/-   ##
============================================
- Coverage     40.82%   39.33%   -1.50%
============================================
  Files           602      602
  Lines         60047    52976    -7071
============================================
- Hits          24515    20837    -3678
+ Misses        32708    29338    -3370
+ Partials       2824     2801      -23

Impacted Files
Coverage Δ

pkg/options/HTTPServer.go
0.00% <0.00%> (-33.34%)
:arrow_down:

pkg/objstore/healthcheck.go
0.00% <0.00%> (-33.34%)
:arrow_down:

system/commands/commands.go
0.00% <0.00%> (-33.34%)
:arrow_down:

pkg/options/DB.go
33.33% <0.00%> (-26.67%)
:arrow_down:

pkg/filter/state.go
73.33% <0.00%> (-26.67%)
:arrow_down:

system/types/attachment.go
0.00% <0.00%> (-24.00%)
:arrow_down:

compose/types/attachment.go
0.00% <0.00%> (-24.00%)
:arrow_down:

system/types/auth_client.go
0.00% <0.00%> (-23.89%)
:arrow_down:

pkg/y7s/decoders.go
33.33% <0.00%> (-22.23%)
:arrow_down:

pkg/options/helpers.go
60.31% <0.00%> (-14.01%)
:arrow_down:

... and 592 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb297f...5e34a03. Read the comment docs.


Constructor like the example, but it doesn't work.

I'm migrating a project from Flutter 2.5.3. to Flutter 3.0.2, but, when i update i found an error with the constructor of library.

@maremaFnx Idk if it is relevant but did you also upgrade adaptive_theme to the latest version?

Closing this because of inactivity. Feel free to reopen if you're still facing this issue.


ci: add luarocks workflow

Hey :wave:
I noticed this plugin has some dependencies that are on luarocks...
Summary
This PR is part of a push to get neovim plugins on LuaRocks.

See this blog post, which follows up on a series of posts by @teto.
See also: rocks.nvim, a new luarocks-based plugin manager.

Things done:

Add a workflow that publishes tags to LuaRocks when a tag or release is pushed.

If you'd prefer automated releases, I can update this PR to use a release-please workflow that creates release PRs with SemVer versioning based on conventional commits,
based on this guide by @vhyrro.
Notes:

Tagged releases are installed locally and then published to luarocks.org.
On PRs, a test release is installed, but not published.
For the luarocks workflow to work, someone with a luarocks.org account will have to add their API key to this repo's GitHub actions secrets.
Due to a shortcoming in LuaRocks (https://github.com/luarocks/luarocks-site/issues/188), the neovim and/or vim labels have to be added  to the LuaRocks package manually (after the first upload), for this plugin to show up in https://luarocks.org/labels/neovim or https://luarocks.org/labels/vim, respectively.

I’m not really interested in increasing the maintenance burden.

That's a shame to hear.
If you're not interested in maintaining tagged releases or conventional commits, would you be open to a cron job that publishes this plugin to luarocks with the commit count as the patch version?

Not really, sorry.


Svelte 5 migration

Description
This is my attempt to kickstart svelte 5 support. It's probably enough to just allow svelte 5 as a peerDependency considering svelte 5 has backwards compatibility, but I guess it's nice to have this as a starting point for a full migration.
All tests are passing, though I had to add a line to remove comments from rendered output before comparing it to expected output.
Changes

Migrated all Svelte components using 1st party migration script, then cleaning up by hand
Added recommended svelte testing plugin to vite-config following Testing Library setup guide
Updated packages required for svelte 5 and getting tests running

Would be amazing to see this merged!

@TheOnlyTails

Would be amazing to see this merged!

Until then, you can use this: https://www.npmjs.com/package/@eirikk/portabletext-2-svelte-5
Follow the instructions in the README to not have to rewrite any imports


Invalid node in the animationTree

By checking the project, I found there is an invalid node in the AnimationTree, this led to crash my editor, see: https://github.com/godotengine/godot/issues/51889 and https://github.com/godotengine/godot/pull/51890

@fabriceci Thank you for fixing the Core, I've been putting AnimationTree on the back burner because it crashes so often when we use it normally, but in this case, it seems that when there are characters with AnimationTree enabled in multiple scenes at the same time, AnimationTree seems to be generating mysterious nodes, and still it's occurring... If you close the main scene of the sample project and then open the Player scene, it should work fine.


Properties with no setter are not set when allowPrivate members is true

POCO properties with no setters are not deserialized.
In a case where a property has no setter, we may consider looking for a compiler generated backing field when private members deserialization is allowed, setting the value of the backing field.

Reviewing with STJ


Fixing hardcoded months to improve age accuracy + subsequent style change

Anything to keep the memez alive 🤘
Resolves #17, resolves #34

links the hardcoded months to a zero-based index to play nicely with Date.prototype.getMonth()
updates the presentation form of month to add leading zero when necessary

FYI several ways I could have implemented the presentation form but the committed little hack works nicely for months
Some other options:
...
const styledMonth = '' + (parseInt(month) + 1);
const { user } = await mutation('/user', { ...values, birthday: `${year}-${styledMonth.length === 1 ? '0' + styledMonth : styledMonth}-${day.length === 1 ? '0' + day : day}` }, { method: 'PUT' });
...

or
...
const { user } = await mutation('/user', { ...values, birthday: `${year}-${parseInt(month) < 9 ? '0' + (parseInt(month) + 1)  : (parseInt(month) + 1) }-${day.length === 1 ? '0' + day : day}` }, { method: 'PUT' });
...

or
...
const styledMonth = () => {
  const incMonth = parseInt(month) + 1;
  return incMonth < 10 ? "0" + incMonth : incMonth;
}
const { user } = await mutation('/user', { ...values, birthday: `${year}-${styledMonth}-${day.length === 1 ? '0' + day : day}` }, { method: 'PUT' });
...

Let me know if you would prefer one of those options better  (ps happy to see you copy paste verbatim from stack overflow like us mere mortals i.e getAge function)

lol, thanks


Multiscrape not working after most recent update

I just upgraded to the latest HACs version of multiscrape and my sensors now no longer work.
Version of the custom_component
v6.2.1
Configuration
multiscrape:
  - resource: https://covidlive.com.au/report/daily-cases/nsw
    scan_interval: 3600
    headers:
      User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/601.3.9 (KHTML, like Gecko) Version/9.0.2 Safari/601.3.9
    sensor:
      - unique_id: nsw_covid_total
        name: NSW COVID Cases - Total
        select: ".DAILY-CASES tr:nth-child(2) .COL3.CASES"
        icon: mdi:virus
        #value_template: "{{ value and value or '' }}"

      - unique_id: nsw_covid_today
        name: NSW COVID Cases - Today
        select: ".DAILY-CASES tr:nth-child(2) .COL5.NET"
        icon: mdi:virus
        #value_template: "{{ value and value or '' }}"

      - unique_id: nsw_covid_last_update
        name: NSW COVID Cases - Last Update
        select: ".DAILY-CASES tr:nth-child(2) .COL1.DATE"
        icon: mdi:virus
        #value_template: "{{ value and value or '' }}"

Describe the bug
I've been running multiscrape for some time and the above sensors have been working fine. After upgrading to v6.2.1, multiscrape is no longer functioning and errors as per the error below.
Debug log

This error originated from a custom integration.

Logger: homeassistant.loader
Source: custom_components/multiscrape/sensor.py:40
Integration: Multiscrape scraping component (documentation, issues)
First occurred: 8:15:46 PM (3 occurrences)
Last logged: 8:15:46 PM

Unexpected exception importing platform custom_components.multiscrape.sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/loader.py", line 603, in get_platform
    cache[full_name] = self._import_platform(platform_name)
  File "/usr/src/homeassistant/homeassistant/loader.py", line 620, in _import_platform
    return importlib.import_module(f"{self.pkg_path}.{platform_name}")
  File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/config/custom_components/multiscrape/sensor.py", line 40, in <module>
    discovery_info: DiscoveryInfoType | None = None,
TypeError: unsupported operand type(s) for |: 'types.GenericAlias' and 'NoneType'

same error here

Hi all,
Same error here.

Same here!

v6.2.1 seems to now have been removed from HACS.
To revert to v6.2.0, I removed Multiscrape integration via HACS and then re-installed.

Yeah, sorry for that. Don't know what's happening yet, so I pulled back that release.

I've been getting the error: Invalid config for [multiscrape]: [index] is an invalid option for [multiscrape]. Check: multiscrape->multiscrape->0->sensor->0->index. lately. Did something change about the configuration in a recent update? Is this related to this issue?

Fixed in v6.2.2
@Sjorsa This is not related. Index feature has been removed since 6.0.0. (this might help you: https://github.com/danieldotnl/ha-multiscrape/issues/111)

I can confirm my multiscrape sensors are online again. Many thanks!


CLI doesn't seem to be working?

with chrome timeline, node 5:
> bigrig --file~/Downloads/TimelineRawData-20151109T104029.json --pretty-print
Usage: bigrig --file <input> [<option>]

Options:
  --file, -f            The trace file to be parsed                [default: ""]
  --pretty-print, --pp  Pretty print the results                [default: false]

with trace from webpage test, node 0.12.7:
> bigrig -f /Users/asanders/Downloads/1_trace.json
Usage: bigrig --file <input> [<option>]

Options:
  --file, -f            The trace file to be parsed                [default: ""]
  --pretty-print, --pp  Pretty print the results                [default: false]

same with   --pp passed in or not...

I'm seeing the same behaviour. Thought it might've been because I passed it a huge timeline, but I see the same result with a small one.
λ du -h ~/Desktop/TimelineRawData*
 51M	/Users/joseph/Desktop/TimelineRawData-20151109T093025.json
 17M	/Users/joseph/Desktop/TimelineRawData-20151109T114756.json

λ bigrig --file ~/Desktop/TimelineRawData-20151109T093025.json --pp
Usage: bigrig --file <input> [<option>]

Options:
  --file, -f            The trace file to be parsed                [default: ""]
  --pretty-print, --pp  Pretty print the results                [default: false]

λ bigrig --file ~/Desktop/TimelineRawData-20151109T114756.json --pp
Usage: bigrig --file <input> [<option>]

Options:
  --file, -f            The trace file to be parsed                [default: ""]
  --pretty-print, --pp  Pretty print the results                [default: false]

Yup, same issue here...

Just ACK'ing this. I'll take a look, see if I can repro.

OK, my bad. Looks like you maybe had multiple tabs open when you took the trace. Adding an error message to cover that now.
Can you all retry with -- say -- Canary and a single tab open?

Yup - does the tick for me - thanks Paul!

Should be fixed as of 1.0.4. Or at least should complain at you for real now.
Sorry for the hassle.

using and canary 1.0.4, get the error but only have 1 tab open?
using chrome have the same problem as before (no output)...

@sndrs Can you send me the trace at all?

using chrome have the same problem as before (no output)...

sorry ignore this bit. can't recreate that


Fixing reference to XESSmartTarget.Core.dll in the child job

Type of Change

[x] Bug fix (non-breaking change, fixes #6137)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Start-DbaXESmartTarget has correct reference to XESmartTarget.Core.dll in the begin block, but in the job it starts old/ broken reference is used.
Commands to test

Start-DbaXESmartTarget

hell yeah! love seeing PR immediately follow an issue 💃  thanks so much! will merge when tests pass.

unrelated test failure (go appveyor!). Merged, thanks much, Bartek!

Frankly speaking I had PR ready before I created issue and added latter when I realized that I need issue number for "fixing" part. ;)
Thanks for prompt response Chrissy! :)


F-Droid

XMPP software appear to be getting censored and restrained by factors who do not want others to enjoy decentralized communications.
Please use F-Droid links instead.
See https://github.com/modernxmpp/easy-xmpp-invitation/pull/51#issuecomment-2044204146

This issue would help with the F-Droid UX: https://gitlab.com/fdroid/fdroidclient/-/issues/1932
However the fact remains that most people do not have F-Droid installed already. We should encourage it, but having to install F-Droid before they can get chatting involves a lot of extra steps and will certainly lose users.
Probably the best option is to offer both.

However the fact remains that most people do not have an XMPP client installed already. We should encourage it, but having to install a client before they can get chatting involves a lot of extra steps and will certainly lose users.

Yeah, I know, since Whatsapp is already installed... :roll_eyes:

Sure. We have a hard task to convert people. Making them install one app is hard enough. Making them install two apps, download APKs, tap through multiple security warnings, it's a simple (sad) fact that many will give up and stick to WhatsApp, yes :(

Probably the best option is to offer both.

yup

No, offering both is not the best option. This project is about making onboarding easier for inexperienced users. Users who have F-Droid installed, or are ready and able to install F-Droid, are by definition not part of the target audience of this project.
The only trade-off that I would potentially accept is one that offers f-droid in an intent selection dialog if f-droid is already installed, like the Android-only market://details?id=<package_name> uri scheme. Unfortunately, that only works when clicked from an Android device (restricting usability from a desktop, where you can install an Android app to one of your phones through the Play Store web frontend), and it was obsoleted by Google, so I have no idea when it will stop working. Given those two issues, this is also a non-solution.


Remove "working doc" concept

Please preview changes here: https://hayleycd.github.io/osv-scanner/
Based on discussion with @oliverchang I have removed the working doc concept. We will be building docs from a stable branch.
There wasn't a ton of difference between the working docs and current docs at this point, and I tried to combine them and use the preview label. Mostly govulncheck related.
Addresses #273

Thanks! Before this goes out, we also need to update the stable branch as well right?

@oliverchang
I'm not sure what you are getting at. I believe we are currently building the docs from the main branch, and we will want to specify another one to build from.

Right, so before this one gets merged, we need to update the stable branch and point docs to it right? Otherwise the docs will be built from this one which is no accurate for the last stable release.

@oliverchang
I'm not sure what you are getting at. I believe we are currently building the docs from the main branch, and we will want to specify another one to build from.

Right, so before this one gets merged, we need to update the stable branch and point docs to it right? Otherwise the docs will be built from this one which is no accurate for the last stable release.

Yes! I think we are on the same page. Add the current state of docs to the stable branch and make sure the github page is building from it instead of main.


Update jsoniter-scala-core to 2.14.0

Updates com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core from 2.10.4 to 2.14.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala", artifactId = "jsoniter-scala-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.github.plokhotnyuk.jsoniter-scala", artifactId = "jsoniter-scala-core" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #957.


caffe and pytorch result is not same

Hi, I followed your deploy steps . but also get different result. I focused on this for several weeks.
Can you help me?

It's normal when caffe outputs and pytorch outputs are different. In my project, the cosine similarity of caffe outputs and pytorch outputs is from 0.95 to 0.99.

Firstly, Greatly thanks for your reply.
Yes, But when people wear similar clothes, the impact may be greater.
I'm verifying that if there's progress, I'll push it forward.
I am curious about the yaml config of your sharing weight(like bagtricks).

I just train the config with a single GPU and don't modify anything. What result did you get?

I also use the original bagtricks_R50 config file with a single GPU, but I get the best mAP 85%.
Even if I modify the config file(adding circle loss as so on), I can't get mAP 86.1%. So I wonder if some places are set up incorrectly.

I just rerun and can get this result.

Nice.I get two good news:
1.pytorch to caffe ,get Similar results.modify this:
# self.maxpool = nn.MaxPool2d(kernel_size=3, stride=2, padding=1)
self.maxpool = nn.MaxPool2d(kernel_size=3, stride=2, ceil_mode=True)

2.retrain by this setting, I get this result:

I have a new problem. I test my model on my own data and find ID mismatch when people wear similar clothes.

Good news! I may change the maxpooling for adapting to caffe converter.
The similar clothes is always a hard problem for person re-id, because it heavily depends on appearance. You can consider using face recognition to identify people wearing similar clothes.

Thanks for your reply. I hope we can discuss it together in the future.
By the way, I create a PR.

Thanks for your PR and I need to do some experiments and then merge your PR.

I  have a question about torch->caffe model. I saw in your blog, u succeed ! What's my question is that can the convert script convert any pytorch model to caffe, or it just work sfor fast-reid? @gmt710

This code is similar to https://github.com/xxradon/PytorchToCaffe.
So I think the convert script convert any pytorch model to caffe.

thank u. It may help me a lot.


add "target" property to fab-button

Short description of what this resolves:
It adds a feature: Setting a href on a fab-button renders an <a>tag instead of a button. The <a> supports the attribute target which wasn't supported yet. This PR adds this feature.
Changes proposed in this pull request:

fab-button can now have a target attribute to be applied to the anchor in case of a provided href value

Ionic Version:
Fixes: #

Nice, this fixes my circumtantial german language ;-)
Had run npm run build in the root before >:( Worked inside core...
I could possible help with finishing https://github.com/ionic-team/ionic/pull/17883
Are you guys at it already?

@bitflower Thanks! We haven't started working on the generic version of #17883. If it's something you're interested in we'd appreciate the help! I think it would be nice if we could pull in the available attributes to pass down if possible. I haven't looked into the potential issues with this approach such as typing issues or not being able to update them dynamically (if that's even needed).

Sure, this week is packed but I could stick my head into this next week for 1-2 hours?

@bitflower Absolutely! Let me know if I can help. 🙂

Hey! It stills reports me "Changes requested". Do you want to wait with the merge until all other components are done?
Have a nice week end!

Thanks so much for your work on this! I'm going to close this one and add you as a co-author on this PR: #17883

Hey Brandy, that's awesome! I'm officially an ionic developer now ;-) Thanks and CU in the future.


server: add retry mechanism for join

Signed-off-by: nolouch<EMAIL_ADDRESS>
What problem does this PR solve?
related: https://github.com/pingcap/tidb-operator/issues/568.
What is changed and how it works?
Add retry mechanism for join
Check List
Tests

Unit test
Integration test

PTAL @disksing @rleungx

/ok-to-test

/ok-to-test

/run-all-tests


Added an option to disable location extension check.

Turbolinks will not check a location's extension before visiting it if data-turbolinks-extension="false" is specified.
Or, programmaticaly, location's extension check can be avoided like so:
Turbolinks.visit("/jane.cooper", { shouldCheckExtension: false })

#26

Thanks @akxcv. I agree that URL extension eligibility should be customizable, but not on a per-visit basis. See #15 for more discussion.

Thank you for your explanation @packagethief. I should've read closed issues :grimacing:


Translate a dynamically created JSON

I am creating a json in my controller. Is it possible to translate the keys?
vm.dropdownJson = {
"Action1": {
"Answered": "ANS",
"Unable to Answer": "UNABLE_TO_ANSWER"
},
"Action2": {
"Solution Found": "SF",
"No Solution Found": "NSF"
}
};

Isn't the discussion in #930 similar and helps?

Closed due to inactivity


Change kv content-type to text/plain

CATEGORY
Choose one

[X] Bug Fix
[ ] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

Superset provides endpoints for storing and retrieving key-value pairs from database storage. For example, /explore/kv/store takes a data POST parameter for an arbitrary string to store and returns the corresponding key, which is a simple integer counter. To retrieve the saved data, users issue a GET request to /explore/kv/. The application returns the associated value with the response Content-Type set to text/html, meaning it is possible for users to construct arbitrary HTML pages.
The attacker can simply create another key-value pair with JavaScript source code in the value and include it from the constructed HTML page. Since the script source comes from the same origin as the HTML page, the CSP permits the browser to execute it
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
Tested that the value returned is text/plain
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

test this please

seeing this error:
https://travis-ci.org/apache/incubator-superset/jobs/529428886
seems unrelated to my changes

Looks like a flaky test, I restarted to confirm.

can this be merged please?


Option compact:true makes all tests pass with version 0.49.* of scss_lint

When the option for compact is true it forces the test to always pass because the regex inside the compact option fails because of a change made to the scss-lint project. https://github.com/brigade/scss-lint/commit/be66a65d46c10ecf21d89b266d60c888eb3c7934
There is an open PR to fix this #138 https://github.com/ahmednuaman/grunt-scss-lint/pull/138/commits/363a70d699b81f98bf9464778c890526f84c8939

Hi @ahmednuaman  and @nick11703  is this fixed? thank you.


Filters on array-type properties do not work

In the new V4 client, filters do not appear to support properties with array types.
If I have a collection Question with a property answer of type text[], the V3 API works as I would expect with the following dataset and query:
[
  { "answer": ["The fox jumped over the lazy dog."] },
  { "answer": ["banana", "over the hedge"] }
]

client.query.get("Question", ["answer"]).with_where(
    {"path": ["answer"], "operator": "Like", "valueText": "*over*"}
).do()

returns both objects, as expected.
The analogous operation in the V4 client does not work:
questions.query.fetch_objects(
    filters=Filter("answer").like("*over*")
)

produces the error
weaviate.exceptions.WeaviateQueryException: Query call failed with message extract params: data type
filter cannot use "valueText[]" on type "text[]", use "valueText" instead.

This error isn't specific to text[], it happens generically.

Hi @thearchitector, thanks for finding this bug and submitting such a thorough report!
I think this may in fact be an issue on the server-side so I will look into it and get back to you 😁

@thearchitector, I believe that this error should be fixed with the latest Weaviate server patch release: v1.22.6. Are you able to check this with your above MRE? Cheers!

fixed in the next beta version with weaviate 1.23

@tsmith023 sorry, a timely response got away from me here.
@dirkkul thanks for the status!


Failed to deploy byconity with k8s

(you don't have to strictly follow this form)
Describe the issue
Step1: Deploy a k8s cluster using sealos
wget https://github.com/labring/sealos/releases/download/v4.2.0/sealos_4.2.0_linux_amd64.tar.gz
tar -zxvf sealos_4.2.0_linux_amd64.tar.gz sealos && chmod +x sealos && mv sealos /usr/bin

sealos run labring/kubernetes:v1.25.0-4.2.0 labring/helm:v3.8.2 labring/calico:v3.24.1 \
    --masters <IP_ADDRESS> \
    --nodes <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> -p xxxxxx

Step2: Deploy byconity according to https://byconity.github.io/docs/deployment/deploy-k8s
git clone https://github.com/ByConity/byconity-deploy.git
cd byconity-deploy

helm upgrade --install --create-namespace --namespace byconity -f ./examples/k8s/values.yaml byconity ./chart/byconity --set fdb.enabled=false
helm upgrade --install --create-namespace --namespace byconity -f ./examples/k8s/values.yaml byconity ./chart/byconity

some pods failed to start, and the configmap byconity-fdb-config is empty.
A clear and concise description of problems in documentation.

@zhouwenyu392  we may improve the deployment scripts

From the above figure, it can be seen that there are issues with the pods that require disk usage, and they are all in a pending state. I think there may not be an openebs hostpath storageClassName issue, which needs to be further examined
@Lucie-hua  You can use this command:
kubectl describe pod  byconity-fdb-log-1
kubectl describe pod  byconity-resource-manager-5f5b7d9bc8-fjzbr

@Lucie-hua do you have further observation about his issue?


Error installing cookiecutter template

This is due to cookiecutter using anaconda as a base environment for the private virtual env it creates. For pip install to work in the virtual env, it would have to activate the root anaconda that was used as the base.
We should change the cookiecutter environment detection code to not use Anaconda as a base environment.
To get around this for now, the user can:

Close VS
Delete the env directory specified in the output window
Install CPython 3.7
Uninstall Anaconda
Start VS and install a cookiecutter template
Reinstall Anaconda

Rather than uninstall/reinstall Anaconda, you may be able to just remove the detection key from the registry and then put it back afterwards (be careful!). It will be under one of these keys:
HKEY_LOCAL_MACHINE\SOFTWARE\Python\ContinuumAnalytics
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Python\ContinuumAnalytics
HKEY_CURRENT_USER\Software\Python\ContinuumAnalytics

Error from output window:
----- Installing cookiecutter -----
Deleting previous environment at 'C:\Users\myusername\AppData\Local\Microsoft\CookiecutterTools\env'
Creating virtual environment at 'C:\Users\myusername\AppData\Local\Microsoft\CookiecutterTools\env'
Installing packages into virtual environment at 'C:\Users\myusername\AppData\Local\Microsoft\CookiecutterTools\env'
pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available.
Collecting cookiecutter<1.5
  Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cookiecutter/

Reported at https://developercommunity.visualstudio.com/content/problem/506066/cookiecutter-template-install.html

Another work around is to close VS, open a regular (non-anaconda) command prompt and create the env manually and install cookiecutter<1.5 in it.
Ex:
cd C:\Users\myusername\AppData\Local\Microsoft\CookiecutterTools
"C:\Program Files\Python37\python.exe" -m venv env
env\scripts\pip install cookiecutter<1.5

Also reported at https://developercommunity.visualstudio.com/content/problem/957196/error-installing-cookiecutter-template-no-matching.html


Basic parfor-loop support in DaphneDSL

Motivation: So far, DAPHNE only supports data-level parallelism by executing the same operations on different chunks of the input data. This is implemented in DAPHNE’s vectorized engine. However, task-level parallelism would be a viable alternative in certain cases. For instance, if the iterations of a for-loop do not depend on each other, they could be executed in parallel.
Task: This project is to introduce basic support for parfor-loops in DAPHNE. DaphneDSL should offer a parfor-statement (which could optionally accept additional parameters for the task-level parallelism). The DAPHNE compiler should analyze these parfor-loops to detect if there are dependencies between the iterations, and potentially to compile/optimize the code for different iterations individually. Finally, the DAPHNE runtime should be able to execute multiple different iterations of the loop in parallel. Implementation in C++.
Hints:

See the paper “Matthias Boehm, Shirish Tatikonda, Berthold Reinwald, Prithviraj Sen, Yuanyuan Tian, Douglas Burdick, Shivakumar Vaithyanathan: Hybrid Parallelization Strategies for Large-Scale Machine Learning in SystemML. Proc. VLDB Endow. 7(7): 553-564 (2014)” for more details on parfor-loops.

In case one wants to also look into this for generated code, the SCF dialect has scf.parallel.


clippy fixes, use matches! macro in more places

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

r? @ehuss

Hm, I can't reproduce any test failure locally. :/

Hm, I can't reproduce any test failure locally. :/

Posted a fix at #8576.

@bors r+

:pushpin: Commit f23b91190ccb103d8041a14e2a715095dcae0ce7 has been approved by ehuss

:hourglass: Testing commit f23b91190ccb103d8041a14e2a715095dcae0ce7 with merge 964a16a28e234a3d397b2a7031d4ab4a428b1391...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 964a16a28e234a3d397b2a7031d4ab4a428b1391 to master...