Port Windows Terminal to be a  Microsoft Edge web browser as an extension and a PWA

Description of the new feature/enhancement
Browsers have tabs and the browser and tab functionality build into Edge and other browser have all the proper key bindings for duplication, tab navigation/selection (e.g. ctrl+tab, ctrl+shift+tab), rearrangement, zoom/full-screen, moving the tab to a new window, web fonts, caret browsing, etc.  Local and remote development and sysadmin functions are rapidly moving towards web rendered interfaces (e.g. VS Code uses Electron, Windows Admin Center, Azure Cloud Shell, etc.). That said, it might make sense to make the Windows Terminal operate embedded in the Edge web browser with an extension.  Similarly, Windows Terminal, using the same technology underpinnings, could still be deployed as a stand-alone app (as a PWA) and distributed part of Microsoft Windows store, for those non-browser usage scenarios.
Proposed technical implementation details (optional)
Ingredient Technologies:

Progressive Web Apps (PWA)

https://web.dev/progressive-web-apps/
https://developer.microsoft.com/en-us/windows/pwa/
https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps

Edge Browser Extension
WASM
SSH, ConPTY, Named Pipes

You know, this was something I investigated at the onset of this project, and explicitly decided against. We've already got the excellent xterm.js that we help maintain, why not use that?
The conclusion we came to centered around one key set of facts:

xterm.js is currently a more complete terminal emulator than we currently had on hand.
We plan on supporting this project for a while, not just a quick 1 year sprint and then wash our hands of this project.
For any JS-based terminal, we need an HTML engine. At the time, we were considering WebViews in WPF, UWP, etc. An HTML engine incurs a pretty substantial memory impact.
No matter how long we'd work on a web-based terminal, we'd never be able to optimize out the footprint of an HTML engine.
If we supported our own terminal implementation for long enough, we'd pretty easily be able to reach feature parity with xterm.js.

These are some raw memory numbers from my original investigation in 2018.

Stack
Idle, Empty Buffer
Idle, full buffer
Scrolling
Worst-case

VT#(WPF+no renderer)
34MB
93.7MB
Peaks at ~100, mean 95MB

VT#(WPF+GlyphRun)
35.9-38MB
84.6-95MB
see above

VT# buffer+UWP
unavailable

xtermjs+UWP
46.3MB
69-73.1MB
102-117, mean 110 MB

xtermjs+WPF
28(+29)=57MB[1]
37(+48.4)=86MB
33.4-34(+101)=135MB

Prototype benchmarks

WPF+DX+native Buffer              [4]

22.4MB

VT#+optimal buffer                [5]
17.1MB
19.6MB

29.2MB

Other benchmarks

conhost+gdi
6.8 MB
6.8 MB
6.8 MB
22.5 MB

C++winrt CoreWindow             [3]
2.0MB

C++winrt Xaml app
11.5MB->9.8

CX UWP with nothing
10.0MB

C# UWP with nothing
10.8MB

UWP with webview
21.6MB

WPF with nothing
24.3MB->14.9    [2]

WPF with webview
25.2+16.8=42MB

Now that we're past the hypothetical, in a world with an actual Terminal application, we can look at how the actual terminal is doing. Right now I've got the terminal running with 3 tabs, and 3 panes in one of the tabs, for 5 total terminal instances. WT is taking 30MB of memory by itself, and with conpty's and attached processes, the entire tree is sitting at 41MB. Does even the simplest electron application take less than 41MB of memory to boot?
So that's a bit of background on why we made these decisions in the first place.
Now, I don't know the most (anything) about browser extensions.

Is there a way to embed arbitrary WinRT types in an edgeium browser tab?

We'd almost certainly be unable to use our current UWP TermControl in a browser, but maybe someone could build a WebTermControl that creates a HTML renderer for the existing Terminal implementation we have

Though, why would someone go through the trouble when they could just embed a xterm.js terminal instance and be done with it?

How would launching external processes work? I'm pretty sure there's an enormous amount of work that's been done to prevent browsers from running arbitrary executables on the user's machine.  Because launching processes is a pretty fundamental use of a terminal, so it wouldn't make sense to have a terminal running in a context where that's not possible, or heavily restricted 😆

I'm gonna leave this open for discussion, because I'd love to hear a compelling argument for why we'd want Terminal in the browser, other than just "it's what everyone else is doing".

I honestly envision a time in which Windows Terminal became embedded in games, possibly web-hosted games. I say this because there are plenty of games that created their personal console for use in-game with their own syntax language for doing stuff in-game. The Elder Scrolls games in particular come to mind but so does the Quake series and they are both from the same vendor. I think once the few PRs pending for getting us VT compliant are merged in conhost (which almost certainly these in-game consoles were using in the backend for Windows), copying the VT levels over to Terminal should be mostly a simple breeze (just copy from the console dispatch to the terminal dispatch and do alittle optimizing). Then the "core" part of Terminal which Visual Studio even now uses could be re-used anywhere so long as a supporting UI accompanied it. I don't personally see a PWA being created or this project having a stand-alone web extension for browsers. It would be nice if we could browse tabs of everything in the Windows shell like was originally planned but then discarded but it's not necessary.

Personally, I would not want to see this implemented as a browser-based solution. Certainly not one that would force me to use Edge.

This is a fascinating discussion; thanks for starting it! The terminal team is pretty deeply invested in our native code, so we're not really likely to do this.
Please feel free to continue the discussion, but I'm going to close out this issue as it's not really actionable for us without years of work (to undock the Windows APIs, and the console subsystem, and all that jazz.)

@jdhitsolutions, @WSLUser the idea was to refactor the base code so it could be delivered as a Windows store app but implemented using browser technologies behind the scenes.  The Microsoft store app would continue to be the primary deployment mechanism that we all use and love. My mention of Windows Terminal running in a Edge as an extension and PWA was just a matter of convenience for developers that develop web apps and use web-based interfaces rendered in a web browser.  It was not an either/or scenario.
@DHowett-MSFT, @zadjii-msft I now completely understand the native code issue, it didn't dawn on me that even the code was mostly C++.  In any case, thank you for the clarification. In the long run, it probably makes more sense to focus on xterm.js with SSH as a PWA (and Store App).  Once WASM, WASI and complier/transpiler ecosystem matures it will be a much easier endeavor.
Thank you for everyone's comments and taking the time to write detailed responses.  Stay safe and healthy.


Slider knob in inspector floats around

Godot version:

3.1 stable
OS/device including version:

Windows 10 x64
Issue description:

I'm quite sure slider knobs are supposed to stay where they were.

Steps to reproduce:

Open the inspector with a slider property.
Hover over the slider to make the knob visible.
Scroll using the mouse wheel without moving the cursor.

Moving the cursor will just delete the knob.
BTW, hovering the mouse right over the knob and scrolling is fine (or is it? It just wouldn't scroll. Not a problem though).

Confirmed.  Bumped into tonight, in build 4ad255a.
Can take it for a ride.  XD

I can confirm this on commit https://github.com/godotengine/godot/commit/584ca0f156cec64c259382895e105cf27566a987.


[Feature request] Custom models

Hello there!
Is it possible to add a feature such that one can add custom models for feature extraction? The donut model is not that accurate and I do not have the hardware for Idefics2. I have 8GB RAM, no GPU.

Hey there
Thank you for the tip. I already have the model on my radar. It is indeed quite remarkable and also steerable enough. There are some other small models that write long elaborations on how they derive the title rather than just returning the answer - no matter how much you ask them not to (they like their flow, don't they) :laughing:. It may take some time before I add it, though... Please stand by :smiley:

Okay @GHuserE the Moondream2 model is now available since a87135b. You can use it by setting
db.set_metadata_method(3)

About adding custom models: I am going to work on reorganizing the code, e.g. by storing all prompts in a single place. This should help it being able to scale better with supporting more models and also remote APIs (ChatGPT, etc.). Please stand by.


Error when trying to open

Tried to install and run directly, shows a error: Fatal error detected - Failed to execute script EDScout
Running on windows 10, tried on administrator mode too

of course isnt going to work, im playing on ps4, this needs the save on pc to work...


Social icons merging into footer section when tested for responsive of  home section

hey @smaranjitghose
I have found that social icons are merging with footer  in home section as shown in screenshot attached
I am interested to work on this issue.
Kindly assign this issue to me under LGM SOC '21

What device?

There is no such config in the current chrome tools on my end. However, the issue persists for iPhone SE and Galaxy Fold devices. You can resolve it if you wish

Assigned for 3 days


Update Composer dependencies (2021-07-17-00-06)

Visual regression test passed!
View the visual regression test report


zig 0.12.0-dev.3561+f45ba7d0c: remove type argument from fieldParentPtr

Thank you! I am super super busy these days so pls forgive me if it takes a bit until I merge.

Thx again, will merge.


[Temporary] Running Mesos ResourceManager on Travis

Opened this PR to check whether Travis completes successfully. It is based on #3942. Will close it afterwards.

@tillrohrmann Can you close this PR? Thanks!


Release 0.19.4 missing accelerator.zip and -.tar.gz

What happened? Provide a clear and concise description of the bug, including deployment details.
I have executed the following line in PowerShell 7.4.5 (as tab in Windows Terminal):
Deploy-Accelerator -inputs D:\xxx\accelerator\config\inputs.yaml -targetDirectory D:\xxx\accelerator\output
This used to work in the previous combination of the last 3.x-version for the bootstrap and 0.19.3 for the starter. I am using the combination of bicep, alz_azuredevops and starter complete.
Please provide the correlation id associated with your error or bug.
N/a.
What was the expected outcome?
That the script created a terraform which I could perhaps apply.
Relevant log output
Getting ready to deploy the accelerator with you...

Checking you have the latest version of Terraform installed...
Although you have selected Bicep, the Accelerator leverages the Terraform tool to bootstrap your Version Control System and Azure. This is will not impact your choice of Bicep post this initial bootstrap. Please refer to our documentation for further details...

Checking and Downloading the bootstrap module...
The directory for D:\xxx\accelerator\output\bootstrap\v4.0.1 has been created and populated.

Checking and downloading the starter module...
Invoke-WebRequest: C:\path\to\PowerShell\Modules\ALZ\4.0.0\Private\Shared\Get-GithubRelease.ps1:126
Line |
 126 |          Invoke-WebRequest -Uri $releaseArtifactUrl -OutFile $targetPa …
     |                                 ~~~~~~~~~~~~~~~~~~~
     | Cannot validate argument on parameter 'Uri'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again.
Failed to download the release v0.19.4 from the GitHub repository Azure/ALZ-Bicep
Exception: C:\path\to\PowerShell\Modules\ALZ\4.0.0\Private\Shared\Get-GithubRelease.ps1:130
Line |
 130 |              throw
     |              ~~~~~
     | ScriptHalted

Check previous GitHub issues

[X] I have searched the issues for this item and found no duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I back this up, am encountering the same issue.

Thanks both @xhoogland & @michael-novak-80 ,
Can you confirm you have upgrade the ALZ PowerShell module to the latest version v4.0.0 https://github.com/Azure/ALZ-PowerShell-Module/releases/tag/4.0.0 & https://www.powershellgallery.com/packages/ALZ/4.0.0
If not please upgrade and try again and let us know 👍
cc: @jaredfholgate  @oZakari

Yes, am on v. 4.0.0 ALZ module, previous versions removed and reinstalled from scratch.

Thanks both @xhoogland & @michael-novak-80 ,
Can you confirm you have upgrade the ALZ PowerShell module to the latest version v4.0.0 https://github.com/Azure/ALZ-PowerShell-Module/releases/tag/4.0.0 & https://www.powershellgallery.com/packages/ALZ/4.0.0
If not please upgrade and try again and let us know 👍
cc: @jaredfholgate @oZakari

Yes, I can confirm. Not behind my laptop currently but Update-Module
-WhatIf does not show this module anymore.
This morning it did and afterwards I executed Update-Module.
On Wed, 2 Oct 2024, 19:42 Jack Tracey, @.***> wrote:

Thanks both @xhoogland https://github.com/xhoogland & @michael-novak-80
https://github.com/michael-novak-80 ,
Can you confirm you have upgrade the ALZ PowerShell module to the latest
version v4.0.0
https://github.com/Azure/ALZ-PowerShell-Module/releases/tag/4.0.0 &
https://www.powershellgallery.com/packages/ALZ/4.0.0
If not please upgrade and try again and let us know 👍
cc: @jaredfholgate https://github.com/jaredfholgate @oZakari
https://github.com/oZakari
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/ALZ-Bicep/issues/871#issuecomment-2389249262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADY6D34S3HKFLOK6OEIWZ4DZZQV75AVCNFSM6AAAAABPICGNQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBZGI2DSMRWGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

The artifacts are there now. Apologies there was an issue with our workflow trigger.

Many thanks for fixing this.

Referencing the PR: https://github.com/Azure/ALZ-Bicep/pull/872

Nice fast fix, thanks!


SSO - Expiry time

Hi -
I am using ApiGility for SSO login on trusted apps and I am wondering if there is a way to increase the SSO expiry time of a given token from 3600 to 24 hours or longer?
Thanks,

Ideally, your clients should use the refresh token to get a new access token. However you can change the token expiry length using this top-level configuration setting:
    'zf-oauth2' => [
        'access_lifetime' => 7200,
    ],


coral-web: Batch file upload for conversations

Changes:

enables more than 1 file to be selected upon click on the file attach button in the compose toolbar
enables more that 1 file to be drag&drop'd into the composer to be uploaded
enables a folder to be drag&drop'd into the composer to be uploaded

File upload via attach button
https://github.com/user-attachments/assets/e0a530e3-834a-4dba-b3d8-8d660fb64907
File upload via drag & drop
https://github.com/user-attachments/assets/86de6825-303e-4255-af77-bddd89e031e6
AI Description

This PR introduces changes to the file upload functionality, allowing users to select and upload multiple files simultaneously.
Changes:

The onUploadFile function now accepts an array of File objects instead of a single React.ChangeEvent<HTMLInputElement>.
The handleUploadFile function has been updated to handle an array of File objects and perform the necessary actions for each file.
The handleFileInputChange function has been introduced to extract the selected files from the React.ChangeEvent<HTMLInputElement> and pass them to the onUploadFile function.
The multiple prop has been added to the file input elements to enable multiple file selection.
The useFileActions hook now exposes an uploadFiles function instead of uploadFile, reflecting the new multiple file upload capability.
The useBatchUploadFile hook has been added to facilitate batch file uploads.
Constants have been introduced to define the MAX_NUM_FILES_PER_UPLOAD_BATCH and the list of IGNORED_FILES during file upload.
The useFilesStore and filesSlice have been updated with the addUploadingFiles action to accommodate multiple file uploads.

tested locally, it works well! the composer just looks a bit odd when you add a lot of files, from designs it looks like we should overflow horizontally

@knajjars nice catch-- amended and feels a lot better
https://github.com/user-attachments/assets/cbd9b0df-b894-454e-a971-4eca98434331

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.38%. Comparing base (86eefe2) to head (259e587).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   81.63%   81.38%   -0.25%
==========================================
  Files         198      199       +1
  Lines        8303     8355      +52
==========================================
+ Hits         6778     6800      +22
- Misses       1525     1555      +30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


textTransform does not work with makeStyles and a theme

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
textTransform should work in typescript with makeStyles and theme
Current Behavior 😯
Argument of type '(theme: any) => { root: { height: string; color: string; textTransform: string; background: any; }; }' is not assignable to parameter of type 'Styles<any, {}, "root">'.
  Type '(theme: any) => { root: { height: string; color: string; textTransform: string; background: any; }; }' is not assignable to type 'StyleRulesCallback<any, {}, "root">'.
    Type '{ root: { height: string; color: string; textTransform: string; background: any; }; }' is not assignable to type 'Record<"root", CreateCSSProperties<{}> | ((props: {}) => CreateCSSProperties<{}>)>'.
      Types of property 'root' are incompatible.
        Type '{ height: string; color: string; textTransform: string; background: any; }' is not assignable to type 'CreateCSSProperties<{}> | ((props: {}) => CreateCSSProperties<{}>)'.
          Type '{ height: string; color: string; textTransform: string; background: any; }' is not assignable to type 'CreateCSSProperties<{}>'.
            Types of property 'textTransform' are incompatible.
              Type 'string' is not assignable to type '"uppercase" | "-moz-initial" | "inherit" | "initial" | "revert" | "unset" | "none" | "full-width" | "capitalize" | "full-size-kana" | "lowercase" | ((props: {}) => "uppercase" | ... 10 more ... | undefined) | undefined'.ts(2345)

Steps to Reproduce 🕹
https://codesandbox.io/s/typescript-react-material-ui-xe0ub

Tech
Version

Material-UI
v4.1.1

React
16.8.6

TypeScript
3.5.2

@kg-currenxie Why not following our examples? Does it work?
import {
  createMuiTheme,
  MuiThemeProvider,
  makeStyles,
  Theme,
  createStyles
} from "@material-ui/core/styles";

const useStyles = makeStyles((theme: Theme) =>
  createStyles({
    root: {
      height: "100vh",
      color: "#fff",
      textTransform: "uppercase",
      background: theme.palette.primary.main
    }
  })
);

codesandbox uses<EMAIL_ADDRESS>opening your example in VSCode using<EMAIL_ADDRESS>works fine.
You need<EMAIL_ADDRESS>or higher for your example to work without using createStyles

Hm, our actual project actually uses ts 3.5.2.
It actually compiles fine, but our IDEs still display it as a warning 🤔

I'm having this issue as well.
https://stackoverflow.com/questions/57335191/texttransform-issue-with-material-ui-typescript-makestyles-createstyles

Also having issues with latest TS version.

Same here

@meebix @jimmybrawn Please provide a reproducible example

I also happened across this issue.
https://codesandbox.io/s/eloquent-liskov-ycy5s
Here's an example of it taking place

I also have a similar issue.
Example in codesandbox is...
https://codesandbox.io/s/mui-theme-overrides-not-work-jwnxt
In case of "case1" in overrides.tsx file, the following error occurs:
(property) MuiButton?: Partial<Record<ButtonClassKey, CSSProperties>> | undefined
Type '{ label: { textTransform: string; }; contained: { boxShadow: string; "&:active": { boxShadow: string; }; }; }' is not assignable to type 'Partial<Record<ButtonClassKey, CSSProperties>>'.
  Types of property 'label' are incompatible.
    Type '{ textTransform: string; }' is not assignable to type 'CSSProperties'.
      Types of property 'textTransform' are incompatible.
        Type 'string' is not assignable to type '"none" | "-moz-initial" | "inherit" | "initial" | "revert" | "unset" | "full-width" | "capitalize" | "full-size-kana" | "lowercase" | "uppercase" | undefined'.ts(2322)

overrides.d.ts(102, 3): The expected type comes from property 'MuiButton' which is declared here on type 'Overrides'

In case of "Case2", removing the textTransform property does not cause an error.

@onlydel Your issue is described here https://material-ui.com/guides/typescript/#using-createstyles-to-defeat-type-widening

I keep running into this and it's super annoying. What's worse is it only affects certain CSS properties. Here's a component expressing the issue.
import type { FC } from "react";
import type { WithStyles } from "@material-ui/core";
import MenuIcon from "mdi-material-ui/Menu";
import { Button, withStyles, createStyles } from "@material-ui/core";

const styles = () => ({
    root: {
      textTransform: "none",
    },
  });

interface NavigationToggleMobileProps extends WithStyles<typeof styles> {
  onClick: Function;
}

const NavigationToggleMobile: FC<NavigationToggleMobileProps> = ({
  onClick,
  classes,
}) => (
  <Button
    variant="text"
    color="inherit"
    startIcon={<MenuIcon />}
    onClick={() => onClick()}
    className={classes.root}
  >
    Menu
  </Button>
);

export default withStyles(styles)(NavigationToggleMobile);

Cajole in the makeStyles function fixes the issue but if it's not happening with color (for example) it shouldn't happen with any other valid css properties. What's worse is IntelliSense doesn't seem to work with MUI so it's hard to determine if there was a typo in the property used or this bug arose. And while I'm sure V5 is "The Future" it's also going to have bugs like this which IMO should be left open as suggested by @sondrewb until they're resolved.

I keep running into this and it's super annoying. What's worse is it only affects certain CSS properties. Here's a component expressing the issue.
import type { FC } from "react";
import type { WithStyles } from "@material-ui/core";
import MenuIcon from "mdi-material-ui/Menu";
import { Button, withStyles, createStyles } from "@material-ui/core";

const styles = () => ({
  root: {
    textTransform: "none",
  },
});

interface NavigationToggleMobileProps extends WithStyles<typeof styles> {
  onClick: Function;
}

const NavigationToggleMobile: FC<NavigationToggleMobileProps> = ({
  onClick,
  classes,
}) => (
  <Button
    variant="text"
    color="inherit"
    startIcon={<MenuIcon />}
    onClick={() => onClick()}
    className={classes.root}
  >
    Menu
  </Button>
);

export default withStyles(styles)(NavigationToggleMobile);

Cajole in the makeStyles function fixes the issue but if it's not happening with color (for example) it shouldn't happen with any other valid css properties. What's worse is IntelliSense doesn't seem to work with MUI so it's hard to determine if there was a typo in the property used or this bug arose.
And while I'm sure V5 is "The Future" it's also going to have bugs like this which should be left open as suggested by @sondrewb until they're resolved. Anything else is a bad developer experience.

@sondrewb Do you have a minimal live reproduction with v5-apha?

Has MUI dropped support for V4? If not, agree this issue should be reopened. Changing coding style to match the docs to workaround this particular bug is not the ideal solution.

Has MUI dropped support for V4? If not, agree this issue should be reopened. Changing coding style to match the docs to workaround this particular bug is not the ideal solution.

@balibebas we only fix major issues in v4, which has rarely happened since we have stopped the active development of v4 a year ago.

That's fair. I'm new to MUI but if active v4 dev has stopped a year ago it sounds like v5 is the way to go and hopefully should show more maturity. If you don't already have one, a MUI 5 in 100 seconds Fireship-style video could help get more people moved onto the beta. I'll look to share feedback as I port Reaction Commerce over to the new version.

tyr textTransform: "uppercase" as const that works for me

@Changhong-st This workaround fixed it for us, but I have to be honest, I don't understand why this fixes it. Can you explain?

@jasongonzales23 Hi, I think this can explain well. TLDL: my understanding is as const would let complier know exactly what intent of the code. In this case, when we declare textTransform; "uppeercase", somehow typescript recognise "uppercase" as string, not "uppercase" type, and that cause issue, and "as const" would let it know what exactly it should be.

@Changhong-st this worked for "none" as well. e.g. textTransform: "none" as const.
Thanks!

This also worked for textTransform: 'capitalize' as const,

In case it helps someone else, what caused the error for me was writing textTransform: 'upperCase', instead of textTransform: 'uppercase',, all lowercase fixed it.

If you need it to be variable, try as "uppercase" | "lowercase" instead of as const. Worked for me.


Proof of concept Asset Model and URDF loading implementation

Hi @azazdeaz do you think we can merge this PR and start having smaller PRs per feature?


Use logger from python simple-logger

Short description:
Updated to align with the new repo to manage loggers
More details:
https://github.com/myakove/python-simple-logger/pull/1
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

/cherry-pick main

/cherry-pick main v4.13

/cherry-pick v4.13


Event Sourcing pattern results in messages skipped (messageType missing some polymorphic types)

Is this a bug report?
Yes

Can you also reproduce the problem with the latest version?
Yes
Environment

Operating system: Windows 10 Pro
Visual Studio version: 2019 (16.5.0)
Dotnet version: .NET Core 3.1
Transport layer: rabbitmq:management running in local docker container
Data layer for event store: mssql/server:2019 running in local docker container
Setup.cs for ASPNetCore api

services.AddMassTransit(options =>
{
    // assembly here is library where IConsumer and message implementations are defined
    options.AddConsumersFromNamespaceContaining(assembly.ExportedTypes.First());
    options.AddBus(context => Bus.Factory.CreateUsingRabbitMq(cfg =>
    {
        if (includeHealthChecks)
        {
            cfg.UseHealthCheck(context);
        }
        cfg.Host(rabbitMqHostOptions.Url, host =>
        {
            host.Username(string.IsNullOrWhiteSpace(rabbitMqHostOptions.Username) ? "guest" : rabbitMqHostOptions.Username);
            host.Password(string.IsNullOrWhiteSpace(rabbitMqHostOptions.Password) ? "guest" : rabbitMqHostOptions.Password);
        });
        cfg.ConfigureEndpoints(context);
    }));
});

services.AddMassTransitHostedService();

Steps to Reproduce

I'm trying to setup a portable event-sourcing pattern for use in a variety of DDD domains. To enable that, I'm creating a number of base classes to represent my patterns:
I've got an abstract type Message that is implemented by other abstract types Event : Message and Command : Message. Similarly, I have abstract classes that implement IConsumer for EventHandler and CommandHandler. Additionally, I have a MessageBus implementation that can SendCommand (which has the signature Task<TAggregate> SendCommandAsync<TCommand, TAggregate>(TCommand command, ConsumeContext commandContext = null, CancellationToken cancellationToken = default) where TCommand : Command where TAggregate : AggregateRoot and fetches the SendEndpointProvider from an injected IBus) or can PublishEvents (which has the signature Task PublishEventAsync<TEvent>(TEvent @event, ConsumeContext eventContext, CancellationToken cancellationToken = default) where TEvent : Event and uses the ConsumeContext to publish or send).
Behind the scenes, I have an Aggregate repository that is injected into required implementations of CommandHandler as necessary, and produces implementations of AggregateRoot. This is what events are applied to. Once an event is created by a CommandHandler and applied to the target AggregateRoot, the event and its context are kept in a queue of type tuple<ConsumeContext, Event>. When the command handler completes its operations, it calls Save on the aggregate repository with the modified AggregateRoot as the argument. At this point, the events are saved to an event store implementation and dumped from the queue. When they're dumped, the aggregate repository uses the same MessageBus to call PublishEvent with the stored Event and ConsumeContext.
long story short:
Controller.MessageBus.SendCommand()
    => CommandHandler.Handle
        => AggregateRepository.GetAggregate(command.AggregateId)
        => AggregateRoot.OnCommand
            => AggregateRoot.ApplyNewEvent
            => AggregateRoot.StoreEvent
        => AggregateRepository.SaveAggregate(AggregateRoot)
            => AggregateRoot.GetUncommitedEventsWithContext()
            => EventStore.Persist(events)
            => MessageBus.PublishEvent(event, context)
               => context.Publish(event)
                   => EventHandler.Handle <<< This doesn't happen
        => context.Respond(AggregateRoot)

Expected Behavior

The registered event handler for the events that get published at the end of this process pull the messages off the corresponding queue from RabbitMQ and do whatever it is they need to do.
Actual Behavior
The messages disappear. They are never added to any queue and the event handler is never triggered. When I tried to convert context.Publish(event) to context.Send(uri, event), the event message in question does show up in the skipped queue for the event handler. Upon inspecting the messages, I noticed something interesting. The following is a message that was sent using context.Send:

Similarly, a message that gets sent via the IBus, where TCommand is explicitly a non-abstract type gets added to the queue like such:

It seems that since the actual event implementation type is not in the messageTypes array, there is no consumer that knows to pull it off the queue since it assumes it won't be able to cast the message. My suspicion is that since my Command handler is calling _messageBus.SendCommand<DoSomethingCommand, DemoAggregate>(new DoSomethingCommand...), the underlying message wrapper is smarter. The event publisher, on the other hand, is called via
foreach (var eventContextPair p in uncommittedEvents) { _messageBus.PublishEvent(p.Event, p.Context); }

which seems like the reflected type that gets wrapped up into message is only Event and not SomethingHappenedEvent.
Reproducible Demo

https://github.com/pygmypenguin/kolekt.EventSourcing
The files I believe are the source of the problem are AggregateRoot.cs (UncommittedEvents), AggregateRepository.cs (Save), EventStore.cs (SaveEventsAsync) and MessageBus.cs (PublishEventAsync)

If you have a complex hierarchy and aren’t able to keep the generic type around for the most specific implementation type, you need to make sure you use the Publish(object message) with no genetic type parameter overload of publish. That way MassTransit can determine the message type and include all the proper interfaces.
By specifying a generic type argument T on publish, you are limiting the types exposed to the broker to only those included with T.

I am publishing (or sending) without the generic specification exactly for that reason. Here's my implementation
public async Task PublishEventAsync<TEvent>(TEvent @event, ConsumeContext eventContext, CancellationToken cancellationToken = default)
    where TEvent : Event
{
    var uri = GetSendUri(@event);
    var endpoint = await eventContext.GetSendEndpoint(uri);
    await endpoint.Send((TEvent)@event, cancellationToken);
    //await eventContext.Publish(@event, cancellationToken);
}

private Uri GetSendUri<TMessage>(TMessage message)
{
    return new Uri($"queue:{message.GetType().Name}Handler");
}

(the TEvent cast there is redundant and doesn't change anything)

That isn't object, it's TEvent - what is the TEvent type when Publish/Send is called?
If you cast it to (object), await eventContext.Publish((object)@event, cancellationToken); and it works, your generic type is not representing the most specific type.

TEvent isn't specified but rather implied, and I believe it's implying that it's Event and not SpecificEvent.
Explicitly casting to object does fix the problem, thanks!
Is there a better way to solve this? My problem is the producer that's ultimately sending/publishing these events is doing so from a list of mixed implementations so casting each one without reflecting is not really an option. The guidelines section of the messages page in your docs says that class-based inheritance is to be approached with caution but interface-based inheritance is "ok but don't go nuts," though there's no real mention of why. Is this the why? Would this be solved if I were using pure interfaces instead of abstract classes, or would I have the same problem?

Same problem, because you're moving your events through a common base type (class or interface doesn't matter) and MassTransit uses the generic type argument to limit the exposure of types of the broker.
Basically, you ran into one of the challenges of an extensive type hierarchy. And it's why MassTransit supports object - MassTransit will do the necessary type reflection to recall Publish or Send with the proper generic type (so you don't have to do it).
There isn't a "better way" - casting to object is the right way.

Perfect, thanks for the explanation and help.


Revert "wolfictl update: transform-version needs to run before versio…

…ns are sorted and compared"
This reverts commit bb20ed5595d97624033c9557662e4eeac06cdfa5.
There's more edge cases to consider which will need more test cases.  We've seen an unexpected version update PR come in that uses the version transforms https://github.com/wolfi-dev/os/pull/6255.  Let's roll this commit back and add more tests to cover more edge cases.

Sigh - need to think about this a bit more and look at more test cases.  The original implemenation of version transforms means we were missing some updates
wolfictl check update  --override-version 0.0.1 openjdk-21

original 21.9 is wrong it should be [jdk-21-ga](https://github.com/openjdk/jdk21u/releases/tag/jdk-21-ga) however I think that's partly down to an issue with the regex.  If you ignore the regex issue preventing-ga  then the fix my change made would work, as it would get the next most recent release jdk-21+35.
i.e. the code in wolfictl was incorrectly resolving 21.9 which it should be 21.35
So that seemed to be working but we've had a slightly different case just happed for openjdk-20 (which has now been archived last month https://github.com/openjdk/jdk20u)
With my fix the bot created a PR for an old version, the opposite of what was happening with my fix above.
TL;DR I'm going to familiarise myself with the version transform code that was added + get some more test cases that cover these odd versions we're seeing on openjdk.
Leaving as draft for now until I really understand what's going on.


[Proposal] Option to paint normals relative to camera.

Feature/enhancement description:
This is something I would really love to have for doing painterly, hand painted normals: being able to paint the normals relative to the camera angle, rather than the texture.
Another great application would be to do things like put bevels on hard edges

I actually attempted to do this, but ran out of time tonight, and figured it'd probably be a lot faster for you to implement, since you know how it all works.  Took a while to figure out how everything was set up.  I was trying to set up something similar to what you had with View2Texture using a shader that set albedo to the normal, then I could do the normal blending calculations remapped to the normals relative to the camera.

Another nice benefit of being able to paint like this would be to touch up low poly meshes where there are some ugly artifacts causing the poly edges to be really visible, especially if there's some way to blur/smooth.

Hmm normals are already relative to the camera if the brush is set to stamp or pattern mode (I'm not completely satisfied with the math, that's why the solution I mention below will be added). You can paint the "normal color" you want by just connecting a gradient node to a normal map node and the normal map output to the normal input of the brush.
Instead of the gradient, you can also define a "profile" to be drawn on the normal map:

(visible pixels are due to the very bad UV unwrap of the model).
In next release, it will also be possible to generate the normal map from the depth map, so this should be even easier (you can grab a dev build in the "Actions" section).

Another great application would be to do things like put bevels on hard edges

Note that this can also be done on the model side by using the Weighted Normal modifier in Blender 2.80 and later, or the Harden Normal option in the Bevel modifier.

I think I explained this poorly.  What currently happens, if I have just a straight "up" normal and paint it, regardless of brush mode, just paints a "flat" normal on the texture (same as if there was no normal map).  What I WANT to happen, is for the normal map to be created such that the end result would be the normal facing toward the camera in the current view.

I think I explained this poorly. What currently happens, if I have just a straight "up" normal and paint it, regardless of brush mode, just paints a "flat" normal on the texture (same as if there was no normal map). What I WANT to happen, is for the normal map to be created such that the end result would be the normal facing toward the camera in the current view.

Yep, that's what I mention in my last sentence (was not quite sure about the UI you expected). I think it's possible to have access to world normals, tangents and view vector in brushes and create a brush that calculates the right normal. Will try this later today.

BTW, any name idea for that brush?

Looks like I got something working... Should be available in latest dev build. Please tell me if it works for you.

There's a catch, though. It's possible to generate normal maps using both depth and normal layers. It's necessary to remove the depth-generated (in Tools->Paint project settings menu) part to get normals right when using this brush (just spent an hour trying to find out why my brush did not work. :( ).
This is a new feature in 0.98 and I'll probably make it a per-layer option, and I'll probably add different normal blend options that workaround this problem.

This is almost perfect!  If you could find a way to do this relative to the actual lerped vertex normals, though that'd be amazing!  In addition to the hand painted style, I was hoping to hide some of the low-poly normal artifacts like this (painted all flat, but you cans till see them):

Did you disable normals from depth as described above? Painting with that brush should completely flatten surfaces.

  I misunderstood the post.  With depth normal disabled it works just as I wanted it to!

I assume we can use this flatten node and do other math relative to those normals if we wanted to add additional texture or something?
Thanks for doing this!


Change query return type to SqliteResult

It would be nice if I could build up a data structure during a query and then return it out the top, instead of having to use mutation.

That does sound nice; it's not obvious to me how it would work, though. Care to elaborate?

@dckc Well, the idea would basically be to make query act as a fold over the results instead of just an iterator.

Sorry, it's still not clear to me. Care to elaborate?

Here's how I've implemented it on top of the current API (obviously the real implementation with access to internals would probably be different than this, but you should be able to see the idea):
fn option_map_mut<T, F: FnOnce(T) -> T>(x: &mut Option<T>, f: F) {
	match *x {
		Some(_) => {
			*x = Some(f(x.take().unwrap()));
		}
		None => {}
	}
}

fn query_fold<T, F: Fn(&mut ResultRow, T) -> T>(z: T, q: &mut PreparedStatement, values: &[&ToSql], f: F) -> T
{
	let mut zbox = Some(z);

	q.query(values, &mut |row| {
		option_map_mut(&mut zbox, { |z| f(row, z) });
		Ok(())
	}).unwrap();

	zbox.unwrap()
}

Ah. I think I get it now.


chore: zeebe-operator to 0.0.55

chore: Promote zeebe-operator to version 0.0.55

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Docs: Getting Started: GOPATH and mercurial

Following the getting started tutorial, where one runs the example processes.
You could add people need to set up their GOPATH for go get -d and go build to work.
# Fetch the client library code and compile example.
git clone https://github.com/prometheus/client_golang.git
cd client_golang
export GOPATH=$(pwd)
cd examples/random
go get -d
go build

Also, when doing go get -d I got an error for Mercurial not being installed:
$ go get -d
go: missing Mercurial command. See https://golang.org/s/gogetcmd
package bitbucket.org/ww/goautoneg: exec: "hg": executable file not found in $PATH

Might be worth mentioning.

Thanks, good point. I created https://github.com/prometheus/docs/pull/229 to address this.


Upload Collection Generation Fractal

Add collection on Unisat Wallet\ Fractal-Ordinalls-Collection

hi, you need to put Generation_Fractal under collections directory. @RumenBo78


JWT auth filter support whether forwarding request when remote jwks are fetched failed

Title: JWT auth filter support whether forwarding request when remote jwks are fetched failed
Description:
In some scenarios, if the service of remote jwks is unavailable, the jwt auth will always failed, of course, we can set allow_missing_or_failed to true, but it can not distinguish between remote jwks fetch failed or the jwt token verify failed. So if we just want to forward requests when remote jwks are fetched failed, maybe we need a new api like allow_jwks_fetch_failed.

cc @TAOXUY @lizan

friendly ping @lizan @kyessenov

friendly ping @lizan @kyessenov


Blogit: - Feature/devise 👨🏾💻 💻 👨🏾💻

Blogit: - Feature/devise 👨🏾💻 💻 👨🏾💻
In this milestone, I managed to implement the following: 🪶

Remove the current_user method in ApplicationController. Used the one provided by devise. ✅
Install and set up devise. ✅
Can register a new user. ✅
User logs in with a combination of email and password. 🔑
Hashed passwords stored in the database. ✅
Ask for confirmation of email. ✉
Can reset password. 🔑
Styled the registration and login pages. 🎨

💯

Hello @OyePriscilla THank you for the review. Could you point to a specific link that is pointing to the wrong section. Or highlight the block?


Implement custom devices marshalling routines and revert RO rootfs support

The agent does not fully support RO rootfs
Unmarshalling device interfaces is not possible with our device structures.
We need to implement our custom marshalling and unmarshalling routines
in order to properly create the right devices from a stored container config.

@sameo I have pushed a fix for the oci tests here : https://github.com/amshinde/virtcontainers/commit/cb794a6904c0e2ec8eca6749f7994ecc7e09041d

@amshinde Pulled, thanks.

Coverage decreased (-0.7%) to 64.905% when pulling 380279603b2751ca1d865e5a64277a1eb1a7061b on sameo/topic/revert-rootfs-ro into 09c706dcc2d64da386a61015063838f3e71d824f on master.

Coverage decreased (-0.7%) to 64.905% when pulling 380279603b2751ca1d865e5a64277a1eb1a7061b on sameo/topic/revert-rootfs-ro into 09c706dcc2d64da386a61015063838f3e71d824f on master.

LGTM


etcdmain: --unsupported flag for running etcd on unsupported platforms

lgtm. defer to @xiang90

/cc @luxas -- This is too late for 2.3 but planned for 2.3.1.

What's the timeframe for v2.3? This seems like a resonable compromise.
I thank you for your re-evaluation, and hope we may get a more stable 32-bit etcd from now on.
I will help with everything I can.

@luxas We are planning to release v2.3.0 with the current master branch, sometime next week. Once we publish the release binary, we can go forward merging related PRs. Thanks.

@heyitsanthony Merge?

@hongchaodeng Can we proceed with this one or totally remove the blocker?
v2.3.1 is released and this isn't in.
This PR makes it hard anyway, 'cause we would have to sed in the --unsupported flag in etcd manifests, but we may fix that.
We need etcd for arm, arm64 and ppc64le for Kubernetes, it's very experimental of course, but anyway.
So it would be great to get some support from you in this.
I've tested v2.3.0 on 32-bit intel, and it fails with ~940 MB data in it, probably a boltdb issue or boltdb implementation issue. We could fix that by adding a 900MB quota for arm (I think that's really good).
I do not think arm64 or ppc64le will suffer from the same limitations, and I'll test the same benchmark on arm64 soon.

I don't handle etcd specifically. @heyitsanthony should be able to provide more information on the release, platform support plan, or that we are not sure either.

I'm asking @heyitsanthony then. It would be kind to answer.

@luxas I didn't see the merge comment from forever ago and github wasn't sending emails on the comments. Sorry! The OS guys suggested a few days ago that a flag is probably a bad idea for testing. I'm going to close this PR and redo as an env variable.

...or maybe just set a limit for arm and 386. Can't we just do that?
No one will be angry at you for not commercially supporting 32-bit, they just might be thankful for not adding blockers. Folks might create issues, and in that case you already say that "32-bit isn't supported", but someone might help to fix it anyway

Close in favor of #5028


version 0.15

Change log file format to JSON!

Codecov Report

Merging #8 (c5580f8) into main (c6241be) will increase coverage by 0.03%.
The diff coverage is 91.21%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   91.84%   91.88%   +0.03%
==========================================
  Files          50       50
  Lines        2503     2624     +121
==========================================
+ Hits         2299     2411     +112
- Misses        132      137       +5
- Partials       72       76       +4

Impacted Files
Coverage Δ

lib-ayd/history.go
75.75% <ø> (ø)

lib-ayd/url.go
82.97% <0.00%> (-12.15%)
:arrow_down:

main.go
76.82% <ø> (+3.26%)
:arrow_up:

internal/scheme/source.go
92.46% <80.76%> (+0.18%)
:arrow_up:

lib-ayd/record.go
81.89% <82.14%> (-6.11%)
:arrow_down:

conv.go
84.11% <100.00%> (+5.70%)
:arrow_up:

internal/endpoint/endpoint.go
95.74% <100.00%> (-0.09%)
:arrow_down:

internal/endpoint/log.go
90.11% <100.00%> (+0.98%)
:arrow_up:

internal/endpoint/metrics.go
75.51% <100.00%> (ø)

internal/endpoint/templates.go
95.68% <100.00%> (+0.59%)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6241be...c5580f8. Read the comment docs.


"instructions updated"

Signed-off-by: P.K. Agrawal<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@IMPranshu  Can you please also update the screenshots on the instructions? The current screenshot does not match the current Meshery UI.

Yes, I am trying to do that but I am not able to sign in from yesterday.

Yes, I am trying to do that but I am not able to sign in from yesterday.

Are you not able to sign in on the lab too?

I am not able to sign in to the labs. I shared this error on slack yesterday when I was trying to get into the labs for taking some screenshots. Anyways will try again soon to sign in

Please see if it is ok and if I have to add something else to this.

@IMPranshu Great work 🚀 .
Please update the following screenshot also

install-consul.png
consul-installed.png
consul-sample-app.png
consul-imagehub-success.png

Also in step2.md at In the Consul Management Page section, its second point can be changed

The card name is different
And the option after clicking the +sign is different now, so change that too

In step3.md
On the Expose Your Sample Application section, Linkerd is being used so change that to Consul.

Sure will do that shortly.

Will be travelling for 2 days, I will continue to fix this after that @asubedy Will that be ok?

All right @IMPranshu 👍

@asubedy can we merge this PR, I am facing some issues while following the instructions. Will update the mentioned and Open a PR again. Will that be ok?

Gents, how are we proceeding? @IMPranshu its been a couple months. Have you completed the other changes?

@leecalcote the PR can be merged. The update is not entirely complete, because we got blocked when Istio couldn't work properly on Katacoda.


--dev ignores any per-process log file

Running procodile start --dev -p web results in everything being redirected to production.log instead of the custom log_file_name options that I've set. The production.log file does respect the log_root option however.
Maybe this is intentional behaviour but from reading the wiki (which is excellent btw!) I don't think it is. If I'm wrong then maybe it could be called dev.log rather than production.log?

FYI contents of my Profile.options
app_name: roomballot
log_root: log
pid_root: tmp/pids
console_command: bundle exec rails console
env:
RAILS_ENV: production
RAILS_MAX_THREADS: 16
processes:
web:
log_file_name: puma.log
restart_mode: usr2
term_signal: INT
worker:
log_file_name: sidekiq.log
restart_mode: start-term
term_signal: INT
cron:
log_file_name: clockwork.log
restart_mode: start-term
term_signal: INT

I don't believe Procodile ever uses a file called production.log. With --dev enabled, it should be running in the foreground with all output going to STDOUT. Rails will use production.log itself though and with RAILS_ENV set to production it will go there. If you change RAILS_ENV to development the Rails log will go to development.log.

Ah I see now - just starting out with Rails so thank you!
After a bit of research I actually ended up going for Logger.new('log/rails.log') instead which seems to do the trick.


0.8-garbled

Why is garbled, my database is set to utf-8

Hi @luojianjava is this a bug report? If so, could you please open a Jira issue and describe in more details your setup?Thanks a lot

Not knowing my MySQL data source and SQL Server imports, I had this problem reading mysql's binlog

@luojianjava This is obviously a bug report not pull request so I am closing it. Please create a report in https://issues.jboss.org/browse/DBZ Unfortunately the current level of information is not sufficient yet.
It would be great if you could provide an example of DDL and DML that exhibits the bad behaviour. We also need information about database encoding, server locales and similar stuff so we can reproduce the issue on ou side. Thanks for understanding


Product Query added dataframes to the ['data'] key?

Keepa wrapper 1.1.0 :
It seems making a product query added dataframes in the ['data'] key of the dictionnary.
Is this intentional? I don't see a mention of this anywhere,
screenshot below
Cheers,
https://i.imgur.com/4n7cCdd.png

That was added in #71, but there's no documentation for this at the moment.
Currently, this module isn't directly supported (financially or otherwise) by keepa and it's becoming increasingly hard to find time to maintain it.  If you'd like to contribute some additional documentation for this feature, please feel free to submit a PR.  Otherwise, it might take some time for me to get around to updating the module.

Thank you, I'll try my best to help maintain it, you've done a great job


Anyway to fetch just a page fragment?

Hey there
This thing is very cool! But im wondering if there is any way to just fetch a fragment of a given URL rather than the whole thing?
Iv tried the version currently in the pull requests but it does not work for me sadly
Thanks, Danny

Hi there.
Can you explain what you mean by the fragment of a given URL?  An example would be great.

Im so sorry for being vague!
Basically, im using this to load data from another page, the contect of which is a blog.
When the user clicks read more on a blog post, this awesome plugin loads the full post content, replacing the smaller preview of the post live on the page, and frankly, its working great and SO SO simple for me to work with. However what id like is rather than prepare the single-post into a separate file (minus head etc, just the bare post/comments) id like to simply target a full blog post, but only grab the 'post-content'
Basically, it seems like this pull would do it https://github.com/LeadDyno/intercooler-js/pull/29 as I could simply supply the full post url like this - ic-src="a-blog-post.html#post-content" - kinda like a regular ajax or jquery .load function would work
Im probably not using this as it was intended and im willing to accept that as it would be totally my fault, but before I try and get my head round doing this with jquery I thought id at least as the question in case im being truly dumb and missing something (iv spent all day getting to this point, and this thing so fluid and smooth it hate to have to drop it and start again)
I really hope this makes some sense, and thanks for your time!
With the history support you have now added (though im yet to really work out how the heck id implement this) I really do love how you have made this so easy to use!
Cheers, Danny

Ah, I finally understand that pull request now. :)
OK, I'm going to reimplement that functionality and give @ruricolist credit for it, since it was his idea.
Currently, the way this "should" be implemented is by checking on the server side if a request is from intercooler (by looking for the 'ic-request' parameter) and rendering the partial view, rather than the whole view. But in situations like you describe, that's probably a pain.
No guarantees on when I'll get it done, but it will be my next project.

Thanks so much! Happy to wait :)
Once you have used intercooler, everything else just seems overly complex to me, this really is some incredible work. Im sure id love it even more if I was using it for what it was intended lol

does the ic-request param work now?  and how about a server request header instead for better seo?

ic-request param should be going up, and we use a header as well.  It's all added dynamically during the ajax call, so it shouldn't have any effect on SEO.

See https://github.com/LeadDyno/intercooler-js/commit/2823151ef769f2572f587e9ac51f63796f6aaba8

:D Thank you!!
Works wonderfully!!!!!


Update error messaging

Change error messaging from a banner that comes down from the top to a toast notification in the upper corner. Also have warning messages here (such as read-only and recently edited notifications from notebooks).
Invision:
https://projects.invisionapp.com/d/main#/console/13746874/286853469/preview
Characteristics of the notification:

doesn't dismiss automatically
can only be dismissed by clicking the X, rather than the whole area so that the user can click through the messages without closing the whole notification

Refinement notes:

We should figure out if/how we want to show the content.
Does Toast support adding buttons to error messages?
Note: Think about Z-index issues

Is the intent to attach it to the top-right of the page or the top-right of the window? I think pinning it to the window is better so that it doesn't accidentally go unnoticed.

@breilly2 I believe the intent was the window, yes.


add Ta

Currently in pub webpage there is tabs for README.md, CHANGELOG.md, Example, Installing, Versions.
Would be great to have to have a dedicated tab for Screenshots/Animated gifs
The intent is to incite devs to show visual implementation, UI of their widget/package when it is relevant.
Obsviously not all packages have something to show

note. you can already embed images in your README.md, embedding gifs should be fine.

the main idea was "incite devs to"

hmm, I guess we could give a reduce package analysis score to flutter packages that don't have a screenshot in their README.md...

I guess we could give a reduce package analysis score to flutter packages that don't have a screenshot in their README.md...

Looks like a hard-to-detect target, and besides, is it true that all Flutter packages are UI-related?

talking about scoring, would be great to score lower those who keep default template data like that one

filed https://github.com/dart-lang/pana/issues/506


Upload sarif for eslint results

This change will upload the eslint results as sarif to code scanning during the CI process.
Merge / deployment checklist

[n/a] Confirm this change is backwards compatible with existing workflows.
[n/a] Confirm the readme has been updated if necessary.
[n/a] Confirm the changelog has been updated if necessary.

It's surprising to me that code scanning is showing a bunch of alerts even though when run locally, they don't appear.
https://github.com/github/codeql-action/security/code-scanning?query=pr%3A2469+is%3Aopen
It looks like the sarif formatter is including alerts that are disabled by eslint-disable-next-line.


Add clang build profile

Add a clang build profile and run it in CI.

Boost actually works with clang, but "update-alternatives" is required


allow AzureKeyVaultClient to take in custom credential

Description
Allow creating AzureKeyVaultClient with custom credentials
Other changes
Tested
Related issues
Backwards compatibility

ping? i already have a local fork for myself, but i think this is useful change for everyone, since sometimes it is better to use EnvironmentCredentials instead of DefaultCredentials (when you dont want to have a fallback, otherwise you get really confusing error messages).

@zviadm @codyborn is this PR still relevant?

@zviadm @codyborn is this PR still relevant?

i think it is still relevant and useful but up to you all if you want to pick it up or not. For my own use cases, as I mentioned, I have already made a fork anyways so I don't care if it gets merged or not.


Added ViewAttributes to Xam.Mac projects (projects were not compiling)

Confirmed fixes Xam.Mac - LGTM.
iOS still don't build because of the same issue but I'll fix that in the morning.


Irregular whitespace in Lexer

Is it intentional that self.consume_char() is after self.trivia_builder.add_irregular_whitespace() here:
https://github.com/oxc-project/oxc/blob/a79988d5e2cd0cf616b56ae1236e5c29d3d950bd/crates/oxc_parser/src/lexer/unicode.rs#L30-L35
As it is at present, self.current.token.start and self.offset() are the same, so the "trivia"'s span is just a pointer to the start of the irregular whitespace. If self.consume_char() was moved to before, span would cover the characters in question (start to end).
I'm not clear what the purpose of recording irregular whitespace is, so not sure if this is intentional or not.

It's for the linter rule "no irregular whitespaces".
I'll take a look soon.

Ah I see. Should irregular line breaks also be recorded as trivia and caught by the linter too? (I don't believe they are at present)

I need to check when I get home.
Speaking of irregular whitespaces and line breaks, if we can do a pre parsing using simd or memchr to get rid of these irregulars (allocation will be rare because they aren't present 99.99% of the time), then we can remove these irregular checks from the tokenizers and truely simd them!

Speaking of irregular whitespaces and line breaks, if we can do a pre parsing using simd or memchr to get rid of these irregulars (allocation will be rare because they aren't present 99.99% of the time), then we can remove these irregular checks from the tokenizers and truely simd them!

My work in progress takes a similar approach to what you've suggested, except it doesn't do a pre-pass. It just assumes there won't be Unicode characters or escapes in identifiers, and has a fast path for that case. Only when a Unicode character is found, it de-opts and deals with it. I've not used SIMD instructions, but have designed the implementation so it's processing batches of 32 bytes, so could be SIMD-ized quite easily later on.
A pre-pass might be even faster, but I'm not sure. That'd have the disadvantage of reading the whole file from memory twice, whereas doing it chunk-by-chunk avoids that. Not sure how the balance of those 2 would play out. Might well be worth trying.


Change structure of Contributing Guide

Description
Change the structure of the contributing.md according to the development process a developer is following
Proposal
- [Creating an Issue](#creating-an-issue)
  * [For Feature Requests](#for-feature-requests)
  * [For Bugs](#for-bugs)
- [Creating a Pull Request](#creating-a-pull-request)
  * [Prepare](#prepare)
    + [Installation](#installation)
    + [Test set-up](#test-set-up)
  * [Implement](#implement)
    + [Coding Style](#coding-style)
    + [Writing a test](#writing-a-test)
    + [Documentation](#documentation)
    + [Commiting Rules](#commiting-rules)
    + [Opening a pull request](#opening-a-pull-request)
    + [Integrating Pull Requests](#integrating-pull-requests)

Acceptance criteria

Tasks

[ ]

I'm unassigning myself, since I'll be unavailable for quite some time.

Has been merged, follow up ticket is #758


(Bug) Change wave opacity to 50%

This PR closes #167846641, by:

Updating wave opacity to 0.5 in the SVG file

Just to state that the change really applied, I'm leaving here the samples with different opacities.

10%
50%
70%
100%

@fernandomg why do we need a different file? can't we apply opacity to the image styles?

@fernandomg why do we need a different file? can't we apply opacity to the image styles?

@sirpy, The pattern is set as a background for the container. Changing the opacity of an element changes the opacity of its children.
I didn't like the idea of duplicating a file just to change its opacity but was the most straightforward way that will work on all platforms and didn't required further changes in app structure.
Finally, we can have another file (smaller) with the 70% opacity for the modals/feeds waves.
Or all waves set to 50% :man_shrugging:


Stop running seurat conversions as part of the SFN

https://github.com/chanzuckerberg/single-cell-data-portal/pull/7380


Finalize the document framework

Description:
Finalize the document framework to be used for APK(check Choreo, Asgardeo, ballerina and come to conclusion.)

Discussion with Divya

Checked how the Asgardeo and IS build process works
Checked issues faced with VuePress and Mkdocs

Discussion with Shani

Checked how the Choreo build process works
Checked issues faced with Mkdocs
Discussed facts mentioned in the framework evaluation process done by the TW (DevRel) team in the recent past.

Discussion with Chanaka

Compared and contrasted the Asgardeo, Choreo and APIM themes
Checked ways to improve the themes
Decided on framework version to use.

Discussion with Sahan

Got details on the CI/CD pipeline for Asgardeo documentation.

Discussion with Lakindu

Got details with regard whether there are any preferences on Azure over Jenkins

The document containing the framework and build comparison based on the information gathered is as follows:
[1] https://docs.google.com/spreadsheets/d/1ESCJS2k8UeoAGZAQdLUUuziSXpxWqouq6_fLNspazNQ/edit#gid=1738702184

Sent an email to Sanjeewa to share this document. Plan on having a follow-up discussion when Sanjeewa is free.
Email:  Documentation Framework for APK

Discussion
Participants: Sanjeewa, Shani and myself
Further to the discussion that I had with you both a short while ago.
The following are the details that we decided on with regard to APK.

Documentation Framework - Mkdocs (latest version). If there are issues with regard to the dependencies that we can not iron out fast then we will use the Mkdocs version currently used by Choreo and APIM, which is 1.0.4

Documentation Build - On Jenkins. The APIM build script will be used as the base and enhanced.

Documentation Theming - APIM doc theme. Later theming enhancements (e.g., extra white spaces etc.), will be done by Chanaka

Environments - For the moment have only one environment.


Question: Is there any way to draw a bell curve shape?

Thank you for reporting an issue, suggesting an enhancement, or asking a question.
We appreciate your feedback - to help the team understand your needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the Docs to see if your question is already addressed there. This will help us ensure our documentation covers the most frequent questions.
Category

[x] Enhancement
[x] Bug
[x] Question
[ ] Documentation gap/issue

Version
Please specify what version of the library you are using: [         ]
Please specify what version(s) of PowerPoint you are targeting: [         ]
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.
Expected / Desired Behavior / Question
If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!
Observed Behavior
If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a suggestion or asking a question delete this section.
Steps to Reproduce
If you are reporting an issue please describe the steps to reproduce the bug in sufficient detail to allow testing. If you are making a suggestion or asking a question delete this section.
Submission Guidelines
Delete this section after reading

All suggestions, questions and issues are welcome, please let us know what's on your mind.
Remember to include sufficient details and context.
Please check back occasionally on your issue as we may have follow up questions.
If you have multiple suggestions, questions, or bugs please submit them in separate issues so we can track resolution.

Thank you for your feedback!

Referenced video and image of the bell curve: https://www.youtube.com/watch?v=dysqb2vEkh0

Hi @gurdeep-sourcefuse
As the video shows, it's not a standard shape so it must be drawn manually.
An upcoming change will allow this: Pull #872

Implemented via https://github.com/gitbrent/PptxGenJS/pull/872


error CS1003: Syntax error, ',' expected

When we create a new theme from scratch and try to build it the first time in visual studio, we immediately get this error about a expected comma.

This has been corrected for the next release.


generated password doesn't show up in clipboard history

I've just installed pwgen 2.1.1 and now the generated passwords don't show up in my clipboard history as it used to be in previous versions. Bug or feature?
Alfred version  is 3.5.1.

Feature.
Passwords are now marked as "concealed" by default, so (compliant) clipboard managers don't record them.
Use ⌥↩ to copy a password "publicly".

Good to know. Thx for the fast answer!


Add LICENSE file

I would love to be able to use this code but it currently has no license. Issues are disabled so I took the liberty of making this pull request. I copied the LICENSE file from https://github.com/flyteorg/flyte, which seemed like a reasonable course of action. Let me know if this looks ok!

Thanks! I appreciate it :)


Add frontend for search

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#40  👈
#39
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techwithanirudh and the rest of your teammates on  Graphite


Added long argument forms

(--help, --verbose, ...)

Thanks, this is a good addition. I'll be going through pull requests and merging them in the near future and will take care of this at that time.

Many thanks for your contribution, @lucasem! My sincerest apologies for the extreme delay in merging your changes.


Feat/86 seed database

Closes #86
Changes made by this Pull Request

Seed the database from test_data.json

Definition of Done

[ ] Tests are written and run successful
[ ] Code is documented
[ ] User Manual is updated
[ ] All requirements of the user story are met

Codecov Report

Merging #112 (2a97b9a) into dev (0a6e0c6) will decrease coverage by 1.85%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##              dev     #112      +/-   ##
==========================================
- Coverage   95.54%   93.68%   -1.86%
==========================================
  Files          18       20       +2
  Lines         359      412      +53
==========================================
+ Hits          343      386      +43
- Misses         16       26      +10

Impacted Files
Coverage Δ

api/scripts/load_test_data.py
88.23% <66.66%> (ø)

api/mod/src/settings.py
91.66% <87.50%> (-2.46%)
:arrow_down:

api/mod/alembic/versions/be60cc3fc1d3_.py
78.57% <0.00%> (-21.43%)
:arrow_down:

api/scripts/config.py
83.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6e0c6...2a97b9a. Read the comment docs.


Unusual whitespace: Difference in anchor construction between Gitea and GitHub/GitLab

Description
There's a subtle difference between how GitHub/GitLab and Gitea construct in-page anchors. Behold titles with unusual whitespace, e.g., an em-space:
# 1 ab

# 1 ab

1 ab
1 ab
GitHub and Gitlab both ignore the em-space, Gitea treats it like a space. I actually like Gitea's treatment better, but I thought I'd mention it on account of conformity.
Gitea Version
1.22.0+dev-229-g51d1dc22f
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
https://try.gitea.io/
Database
None

Thanks for all your patient checks about the Gitea markdown editor. Probably we should put the markdown rendering issue into a summary issue.

GitHub and Gitlab both ignore the em-space

What does this sentence mean? Render em-space as-is?

A label with text 1<em-space>ab gets the anchor #1ab in GitHub and Gitlab, and #1-ab in Gitea.

So it's only about the generated hash, not the actual rendering?

The rendering is fine, it's just a link/anchor discrepancy.


module 'torch._C' has no attribute '_set_cached_tensors_enabled' for XPU device

🚀 The feature, motivation and pitch
Log:
test/xpu/test_autocast_xpu.py::TestAutocastGPU::test_cache_disabled FAILED [ 20%]
  File "/home/gta/penghuic/pytorch_stock/third_party/torch-xpu-ops/test/xpu/test_autocast_xpu.py", line 90, in test_cache_disabled
    torch._C._set_cached_tensors_enabled(False)
AttributeError: module 'torch._C' has no attribute '_set_cached_tensors_enabled'

command:
PYTORCH_ENABLE_XPU_FALLBACK=1 PYTORCH_TEST_WITH_SLOW=1 pytest -v test/xpu/test_autocast_xpu.py

Alternatives
No response
Additional context
No response

I see, checking...

Currently, _set_cached_tensors_enabled is tailored to CUDAGraph. So I don't think you need this API in our UT at this moment.
We also have no reason to refactor them unless there is a real case that requires it.


Writing a DropTarget as a higher order component fails due to Matching<>

I'm trying to write a higher order component that turns the WrappedComponent into a DropTarget. (Why? I'm ultimately trying to write a HOC that turns the WrappedComponent into a DropTarget for the sake of writing autoscroll, and I'm following the suggestion here to "parent drop target that compares component.getBoundingClientRect() with monitor.getClientOffset() inside its hover handler." As a first step though, I'm just trying to write a HOC that turns the wrapped component into a DropTarget.)
This is the code I've got right now:
interface TargetCollectedProps {
    connectDropTarget: ConnectDropTarget;
}

const withAdditionalFunctionality = <OriginalProps extends {}>(WrappedComponent: React.ComponentClass<OriginalProps>) => {
    const spec: DropTargetSpec<OriginalProps> = {
        hover(targetAreaProps: OriginalProps, monitor: DropTargetMonitor) {
            return;
        }
    };

    function collect(connect: DropTargetConnector, monitor: DropTargetMonitor, props: OriginalProps): TargetCollectedProps {
        return { connectDropTarget: connect.dropTarget() };
    }

    const WrappedComponentAsDropTarget = DropTarget<OriginalProps, TargetCollectedProps>(ITEM_DROP_TYPE, spec, collect)(WrappedComponent);

    class WithAdditionalFunctionality extends React.Component<OriginalProps & TargetCollectedProps> {
        constructor(props: OriginalProps & TargetCollectedProps) {
            super(props);
        }

        public render() {
            return this.props.connectDropTarget(
                <WrappedComponentAsDropTarget {...this.props} />
            );
        }
    }

    return WithAdditionalFunctionality;
};

And this is the error it's failing with:
Argument of type 'ComponentClass<OriginalProps, any>' is not assignable to parameter of type 'ComponentType<Matching<TargetCollectedProps, OriginalProps>>'.
  Type 'ComponentClass<OriginalProps, any>' is not assignable to type 'ComponentClass<Matching<TargetCollectedProps, OriginalProps>, any>'.
    Types of property 'propTypes' are incompatible.
      Type 'WeakValidationMap<OriginalProps> | undefined' is not assignable to type 'WeakValidationMap<Matching<TargetCollectedProps, OriginalProps>> | undefined'.
        Type 'WeakValidationMap<OriginalProps>' is not assignable to type 'WeakValidationMap<Matching<TargetCollectedProps, OriginalProps>>'.
          Type '(null extends OriginalProps[K] ? Validator<OriginalProps[K] | null | undefined> : undefined extends OriginalProps[K] ? Validator<OriginalProps[K] | null | undefined> : Validator<OriginalProps[K]>) | undefined' is not assignable to type '(null extends Matching<TargetCollectedProps, OriginalProps>[K] ? Validator<Matching<TargetCollectedProps, OriginalProps>[K] | null | undefined> : undefined extends Matching<TargetCollectedProps, OriginalProps>[K] ? Validator<...> : Validator<...>) | undefined'.
            Type 'null extends OriginalProps[K] ? Validator<OriginalProps[K] | null | undefined> : undefined extends OriginalProps[K] ? Validator<OriginalProps[K] | null | undefined> : Validator<OriginalProps[K]>' is not assignable to type '(null extends Matching<TargetCollectedProps, OriginalProps>[K] ? Validator<Matching<TargetCollectedProps, OriginalProps>[K] | null | undefined> : undefined extends Matching<TargetCollectedProps, OriginalProps>[K] ? Validator<...> : Validator<...>) | undefined'.

I've looked at the code for Matching, but it didn't illuminate anything for me. Does anyone have any idea what could be causing this, and how I might work around it?
Versions:

react: 16.8.5
react-dnd: 7.6.0
react-dnd-html5-backend: 7.6.0

That's a bit deep-in-the-weeds for me as far as TypeScript goes - we struggled for some time to get the typings for decorators to work ergonomically. Does this work in the JS runtime, or is this just a typings issue?
Ultimately I went and copied some of the typings for how react-redux works with decorated components. This section of code basically manages the props interface of the react-component coming out of the decorator. (https://github.com/react-dnd/react-dnd/blob/5069427fc300de818031ad050618d44593170885/packages/core/react-dnd/src/decorators/interfaces.ts#L173-L237)
If you took an approach like this and mark your return type as a "ComponentEnhancer", then you could at least have the option of doing a force cast at the end but keeping your downstream consumer typings clean.


X509 JSON format: Output serial as string

First of all thank you for making this open-source, and thank you for the effort! Works like a charm :heart:
The .Certificate.Serial field is output as a float/number in JSON. Once you parse that with e.g. NodeJS and try to output it you get the scientific notation instead of the full base 10 string (e.g. 1.0834386045428302e+38<PHONE_NUMBER>54283013782823752379123954236). Now, it's pretty easy to just wrap that in a BigInt. But tbh, you're not really expected to do any math with those numbers (except maybe conversion to hex), they're identifiers.
I suggest outputting the Base10 serial as a string.
EDIT: OK. Because of how floating points work it's actually even worse than that. The serial is plain wrong. I had to parse the raw cert and then use BigInt('0x' + serial).toString(). I suspect a lot of other languages that parse JSON ints as floating points will have the same issue.

Thank you @andsens, good catch. I will look into it in January, I have no access to my dev machine right now.

Hi @andsens, I looked into it. Unfortunately I am reluctant to change.
The output is produced by the standard MarshalIndent here:
https://github.com/lukasz-lobocki/step-badger/blob/51d7d3a7901391ead5f44cb934ef0066461badca/cmd/output_sshcerts.go#L87
It follows the standard type Certificate struct that defines Serial as uint64. I do not want to introduce a custom behavior. I suggest, as you wrote, it should be wrapped in NodeJS BigInt.
Any input of yours is appreciated.
Happy New Year, Lukasz

Makes perfect sense. It's seldom good practice to put in workarounds for limitations on the consumer side.
For anybody else stumbling across this: The proper workaround for JS would be to use a reviver function.
JSON.parse(
  '{"largeint":108343860454283013782823752379123954236}',
  (_, value) => isNaN(value) || Number.isSafeInteger(value) ? value : BigInt(value)
).largeint.toString();
# = '108343860454283018049479498025419145216' (instead of '1.0834386045428302e+38')

Happy New Year

Likewise :-)

Hi, I did something else to workaround it.
There is the new node StringSerials added to json output. It contains string-formatted serials.

Oh, smart! Yeah, that makes sense. Good thinking, no breakage of the existing API 👍


my_and_fail.erl timeout

Investigate why tally takes a long time with the new constraint system in place.
Relevant tally constraints:
[{scsubty, 10:21, false, $22},
 {scsubty,
  10:1,
  $0 /\
  not({true, any()} /\ {any(), any()}) /\
  {false, any()} /\
  {any(), any()},
  {$16, $17}},
 {scsubty, 9:1, T, $1},
 {scsubty,
  11:1,
  $0 /\
  not({true, any()} /\ {any(), any()} |
      {false, any()} /\ {any(), any()}) /\
  {any(), false} /\
  {any(), any()},
  {$27, $28}},
 {scsubty, 9:21, $11, T | false},
 {scsubty, 9:1, $0 /\ {true, any()} /\ {any(), any()}, {$7, $8}},
 {scsubty, 9:1, $0 /\ {true, any()} /\ {any(), any()}, {$3, $4}},
 {scsubty,
  11:1,
  $0 /\
  not({true, any()} /\ {any(), any()} |
      {false, any()} /\ {any(), any()}) /\
  {any(), false} /\
  {any(), any()},
  {$29, $30}},
 {scsubty,
  9:1,
  $0,
  {true, any()} /\ {any(), any()} |
  {false, any()} /\ {any(), any()} |
  {any(), false} /\ {any(), any()}},
 {scsubty, 9:1, $0 /\ {true, any()} /\ {any(), any()}, {$9, $10}},
 {scsubty, 9:21, true, $11},
 {scsubty, 9:1, any(), $2},
 {scsubty, 10:21, $22, T | false},
 {scsubty, 9:1, {$2, $1}, $0},
 {scsubty,
  10:1,
  $0 /\
  not({true, any()} /\ {any(), any()}) /\
  {false, any()} /\
  {any(), any()},
  {$14, $15}},
 {scsubty,
  10:1,
  $0 /\
  not({true, any()} /\ {any(), any()}) /\
  {false, any()} /\
  {any(), any()},
  {$20, $21}},
 {scsubty,
  10:1,
  $0 /\
  not({true, any()} /\ {any(), any()}) /\
  {false, any()} /\
  {any(), any()},
  {$18, $19}},
 {scsubty, 11:21, false, $33},
 {scsubty,
  11:1,
  $0 /\
  not({true, any()} /\ {any(), any()} |
      {false, any()} /\ {any(), any()}) /\
  {any(), false} /\
  {any(), any()},
  {$31, $32}},
 {scsubty,
  11:1,
  $0 /\
  not({true, any()} /\ {any(), any()} |
      {false, any()} /\ {any(), any()}) /\
  {any(), false} /\
  {any(), any()},
  {$25, $26}},
 {scsubty, 11:21, $33, T | false},
 {scsubty, 9:1, $0 /\ {true, any()} /\ {any(), any()}, {$5, $6}}]

Cduce needs 4 seconds to solve these constraints.


Memory Leak when Creating New Worlds During the Same Session

What you were trying to do
~ Creating/loading different worlds during the same session in Terasology; trying out each module in its own separate test world.
What actually happened
~ System memory consumption increased with each world creation/loading. Game configuration is set to "Maximum Memory" 2gb. I would shutdown the session when 5gb were surpassed. Eventually I had to reboot my entire system during long periods of modules trials.
How to reproduce

Step 1:  Create a new world with only one module.
Step 2:  Exit that world while leaving Terasology running.
Step 3:  Repeat Step 1 except deselecting all modules and selecting a different one. Then repeat this process for three more, new worlds.

Log details and game version
~ Terasology:   Stable #74
~ Gameplay Template:   Core Gameplay
Computer details
~ Linux Mint 18.3
~ 16gb RAM
~ Intel i7

Thanks for the report :-)
This might be a good fit for @TheFlash98's GSOC project as he aims to rework some of the UI flow in that area. As part of that module environment setup may change to more cleanly swap back and forth, avoiding this memory issue. At least we should re-check this with the new setup to make sure it doesn't occur anymore.

Loading a different module each time is actually irrelevant for reproducing this issue. Every time you create or load a game, it creates a new Context, and none of these are garbage-collected when returning to the main menu or start a new game, so all of the systems and things from previous games remain.
I still haven't managed to find out what's keeping the old Context alive, but there is a lot of rendering stuff that also remains even without the references to it from the Context, so it's quite likely that something there is the issue.


[Parse] Fix InFlightDiagnostic lifetime

Fixes @practicalswift's crasher 28759 (#9907), which seems to have been introduced in #9294.

@swift-ci please smoke test


Fix no _ga cookies.

When I use the site with ghostery or no google analytics cookie:
2016-08-08T15:19:34.387910+00:00 app[web.1]: Completed 500 Internal Server Error in 64ms (ActiveRecord: 27.4ms)
2016-08-08T15:19:34.392459+00:00 app[web.1]:
2016-08-08T15:19:34.392461+00:00 app[web.1]: NoMethodError (undefined method `split' for nil:NilClass):
2016-08-08T15:19:34.392462+00:00 app[web.1]:   app/controllers/application_controller.rb:45:in `tracker'
2016-08-08T15:19:34.392463+00:00 app[web.1]:   app/controllers/admin/topics_controller.rb:57:in `index'
2

Thanks for that one.  Edge case? Maybe but then again maybe not.

You are welcome ;-)


Can I change logging level globaly for a logger

Wondering if I can change the logging level for a logger on the fly across the board (i.e. not for a specific class).
I can see I can do this by removing and adding the logger again, but wondering if there is another way to do it on the fly.
I'm using Swift.
Cheers
Seth

For a single logger you better create your own logger (by subclassing one of the existing ones) and filter there the log messages according to their levels.

Can't I just do that via the log formatter?

You could try I guess, but it would be cleaner to ignore log messages directly in the logger before passing it to the formatter.

A solution suggestion, i can open a pull request if needed :
+ (void)updateLogger:(id <DDLogger>)logger level:(DDLogLevel)level {
    [self.sharedInstance updateLogger:logger level:level];
}

- (void)updateLogger:(id <DDLogger>)logger level:(DDLogLevel)level {
    if (!logger) {
        return;
    }

    dispatch_async(_loggingQueue, ^{ @autoreleasepool {
        [self lt_updateLogger:logger level:level];
    } });
}

- (void)lt_updateLogger:(id <DDLogger>)logger level:(DDLogLevel)level {
    // Find associated loggerNode in list of added loggers

    NSAssert(dispatch_get_specific(GlobalLoggingQueueIdentityKey),
             @"This method should only be run on the logging thread/queue");

    DDLoggerNode *loggerNode = nil;

    for (DDLoggerNode *node in self._loggers) {
        if (node->_logger == logger) {
            if (node->_level == level) {
                // Exactly same logger already added with same level, exit
                return;
            }
            loggerNode = node;
            break;
        }
    }

    if (!loggerNode) {
        NSLogDebug(@"DDLog: Request to update logger which wasn't added");
        return;
    }

    // Remove from loggers array
    [self._loggers removeObject:loggerNode];

    // Add updated node to loggers array
    loggerNode = [DDLoggerNode nodeWithLogger:logger loggerQueue:loggerNode->_loggerQueue level:level];
    [self._loggers addObject:loggerNode];
}

@yacir I remember I wanted to implement something similar to your solution at some point. I can't remember why I haven't added it to the project (maybe it didn't work).
Anyway, feel free to create a PR, we will need to add some unit tests to make sure it works fine, especially in a multithreading environment.
Are you still interested in doing this?

@bpoplauschi Of course i ll open a PR and add some tests.


Missing Draw overload

Hi,
for a MonoGame project, I need to replace this former SpriteBatch.Draw call:
spriteBatch.DrawString(_spriteFont, _text, _rotatedPosition, _color, _rotationAngle, _origin, _scale, _effects, _layerDepth);
with one based on FontStashSharp. More specifically, I need to display rotated text, but FontStashSharp, within its overloads of DrawText(), doesn't seems to support it.
Any suggestion?
Thank you very much in advance

Remove _effects parameter as it's not yet supported.

Remove _effects parameter as it's not yet supported.

In fact, I don't really need it.. I put it in my message just to provide the complete method signature, but in my case it's just set to SpriteEffects.None.
What about text rotation (main pain point), instead?

In fact, I don't really need it.. I put it in my message just to provide the complete method signature, but in my case it's just set to SpriteEffects.None.
What about text rotation (main pain point), instead?

_rotationAngle is supported.
There's even a corresponding sample: https://github.com/rds1983/FontStashSharp/tree/main/samples/FontStashSharp.Samples.RotatingText

_rotationAngle is supported.
There's even a corresponding sample: https://github.com/rds1983/FontStashSharp/tree/main/samples/FontStashSharp.Samples.RotatingText

Hey, this is great!
No time for more tests now, I'll let you know as soon as I can try your suggestion.
In the meantime, thx again!

Hey, this is great!
No time for more tests now, I'll let you know as soon as I can try your suggestion.
In the meantime, thx again!

yw

yw

Hey there @rds1983 thank you, I confirm that v.0.9.2 was able to sort this out for me.. thank you very much!

Hey there @rds1983 thank you, I confirm that v.0.9.2 was able to sort this out for me.. thank you very much!


Handle :append_sha256_content_hash option

Thanks @LostKobrakai will tag a new release shortly

@LostKobrakai New release available v0.13.2 :+1:


Asset retirement

Add asset retirement feature to allow users to differentiate between active and inactive assets

Closes #17


Add ability to configure etcd through the Helm CLI

Description
Now that Calico docs are rendered using helm templates, add the appropriate variables and defaults for setting the etcd configuration through the Helm CLI.
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit efe929588226a8e974fab0297cb27702d7e7e6af
https://deploy-preview-2515--calico.netlify.com


Changes GitHub Action OS Image to Avoid Python Caching Issues

This PR allows us to avoid this issue with the setup-python Action used in Hatchet's CI.
To do so, it simply changes the OS image for the CI from ubuntu-latest to ubuntu-20.04. When the linked issue is resolved, we can switch back to ubuntu-latest.

@slabasan this PR is now complete, pending a rebase. It now contains the following changes:

Fixes the original issue with the setup-python action described in the first comment of the PR
Changes .coveragerc so that all coverage files are saved into a .coverage/ subdirectory
Upgrades codecov-action from v1 (which no longer works) to v3
Adds several arguments to the invocation of codecov-action, namely:

verbose: enables verbose output from the action
env_vars: ensures the values of the runner's OS and PYTHON environment variables are included in the code coverage report
directory: ensures that the action looks in the correct place for the coverage files (i.e., the .coverage/ subdirectory)

Changes np.float to np.float64 in the timemory_json_data function in conftest.py because np.float has been removed from newer versions of NumPy


The CI build is too long

What happened?
Description
The current CI build takes too long to complete (on average 90 minutes or so).
This issue captures the ongoing efforts to get the build under a given threshold.
Please upvote this issue with :+1: if you'd like to see this effort be prioritized. Patches welcome!
Steps to Reproduce
Run a build for a pull request against the repository.
Expected Result
The build takes under 30 minutes to run.
Actual Result
The build takes 90 minutes to run.
eBPF Collector version
latest
Environment information
No response
eBPF Collector configuration
No response
Log output
No response
Additional context
No response

Some possibilities brainstormed include:

getting larger (and/or dedicated) GitHub runners
enabling build caching (ccache, build-env ~/.gradle cache)
making the builds and tests more parallel


[TW#18641] Poor TCP performance when BLE scan

I have a single TCP connection to a server (constant, stay connected forever), there is a task pushing data to the TCP socket every 200ms, when the connection stays idle for more than 6.4s (6400ms), the server will close the TCP connection (a custom timeout mechanism).
My ESP32 will keep scanning BLE devices (BLE only, no classic Bluetooth), passive scan, every 1s, forever. The issue is when BLE is keep scanning BLE devices, my TCP connection will disconnect for a long time (which means there is at least 6.4s for no data in the TCP socket stream), some of the data is delayed for few seconds to arrive to my server too.
Is there any way/tweak that I could reliably use Wi-Fi+BLE?
I am using ESP32-WROVER if that matters.

Hi,
I'm using also BLE scan + Wifi, but I do not see too big slow down. For example my BLE scans and also I'm able to do OTA (I can see a 1s delay during OTA write and BLE scan, but  then it continue properly).
Anyway be aware ESP have common RF part for Wifi and Bluetooth, so it is switching between them.
But maybe a devs will tell more :)

@jedi7 Thanks. I think the problem is I have a constant TCP connection to my server, the BLE scan will delayed my TCP data stream. Maybe the issue is not exists when you open a TCP connection every time you want to send a data out.

Cross reference back to #1658

@hopkinskong , you can try the latest master branch. We have done the wifi/bluetooth coexistence.

@TianHao-Espressif Replied in #1658


Unable to run python

I'm unable to run a python script on atom with the plugin script.
If I try, it says that it cannot run python, although it is runnable.

Same as #503


Deprecate paginated methods with an alternative

The paginated methods are dangerous. It's not obvious without reading the source that they are paginated, so it's very easy to write scripts that will fail when the number of API object it's operating on becomes large. In scripts, you almost never want pagination.
Most paginated methods also have a non-paginated '_iter' alternative that is much safer. Deprecate the paginated versions. Pycharm will now warn about uses of the deprecated methods. You can still use the methods - you'll just get a warning.
We've been bitten a few times recently by accidentally using paginated API methods inappropriately. This should hopefully make that sort of mistake less common in future.

Thanks. I had a look to see if I could do it more elegantly with decorators or metaprogramming. Unfortunately, if I do anything more clever, PyCharm stops recognising it. So simple and slightly boilerplate-y it is.

Thanks. I had a look to see if I could do it more elegantly with decorators or metaprogramming. Unfortunately, if I do anything more clever, PyCharm stops recognising it. So simple and slightly boilerplate-y it is.


sonos bugfix with unique_id

Description:
Bugfix and replace #3141

@pvizeli I will need to run it locally but I understand that in this case it will pick the default device name always.
If this is the case I think there will be an issue with several Sonos players on the network. In this case I think uid should be used for the name.

The name was never a bug only the unique_id could false generate. Default HASS do that right and should not be overwritte. I think that is a older platform plugin and this part was never updated.

🐬 LGTM

The discussion is out of scope for the change here, I'll just merge this. Another PR can address other issues if necessary.


Remove debug output when coverage fails

When make coverage fails, it logs megabytes of debug to stdout, which seems to break the drone ui as well as the log output download in drone, presumably because drone limits downloadable log size to 5MB. I think with removal of this print, we should still see any errors that gocovmerge.go logs to stderr, but a few CI runs may be necessary to get it to fail again.
Example failures:
https://drone.gitea.io/go-gitea/gitea/58933/2/18
https://drone.gitea.io/go-gitea/gitea/58928/2/17

Debug output was added in https://github.com/go-gitea/gitea/commit/c0f5da3e1adfe40cafc57de63948ef1878bd75c9 by @zeripath, but I think as it stands now, it's not useful. It may become useful if we can increase this 5MB limit of drone, thought.

If you remove this logging then we have no way of working out why the coverage is failing.
Do we understand why coverage keeps failing at present?

Do we understand why coverage keeps failing at present?

No, but maybe a few re-runs of this will reveal the error. As is stands, the debug output is useless as long as drone truncates it to 5MB.
By the way, what is the point of this coverage task? Is it needed for external tools like CodeCov?

I see that these tasks actually uploads to codecov. Still I wonder the value. I think most contributors ignore code coverage and these codecov comments are generally perceived as spam because the percentages are not stable.
I think we should just drop this codecov integration as it introduces unnecessary build failures. Anything that can fail a build randomly should be eliminated 😉.


KSPI-E needs InterstellarFuelSwitch 1.4

KSPI-E needs InterstellarFuelSwitch 1.4 otherwise people vessels might explode/implode

Once https://github.com/KSP-CKAN/CKAN-core/pull/120 is merged this will even work! :D


wasmtime-wiggle: make it possible to add host funcs to a config under an alias

This addition to wasmtime-wiggle makes it possible to add a function to a Config under an arbitrary name.
Embeddings that allow Wasm functions defined by wiggle to be imported under additional names (for example, for legacy compatibility) can do so by writing their own Linker invocation, but functions were added to a Config under only the name specified by the witx file. Now, in addition to the default add_to_config behavior, you can add_<functionname>_to_config(&mut config, module: &str, field: &str) as well.

Yeah, we could do this at compile time instead of at run-time. This does add a lot of API surface but effectively its just out-lining the functionality that is already there for add_to_config, which is implemented in terms of these new functions.
I'd like to defer adding compile-time config for this for a little bit. It is an optimization, but for code should get called once per engine creation. I expect plenty more structural changes to wiggle coming down the pipe as witx and friends evolve, so I don't want to add more complexity to the macro right now if we don't have to.

Ok sounds reasonable!


iPad popOver support?

Can't find any documentation on iPad transition fallback.
Is popOver supported and inherited from UIKit on iPad devices?
Thanks

For those who may stumble upon this, managed to solve this by detecting the device type further up the chain.
if UIDevice.current.userInterfaceIdiom == .pad { 			performSegue(withIdentifier: "SegueName", sender: nil) 		} else { // Perform hero segue here }


Limit file entry hash to 10 digits

Fixes #905

Codecov Report

Merging #908 (f5db5af) into master (4e29a55) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head f5db5af differs from pull request most recent head 044f731. Consider uploading reports for the commit 044f731 to get more accurate results

@@           Coverage Diff           @@
##           master     #908   +/-   ##
=======================================
  Coverage   91.76%   91.76%
=======================================
  Files          66       66
  Lines        5174     5174
=======================================
  Hits         4748     4748
  Misses        259      259
  Partials      167      167

👍  Can we add a test for this?

👍 Can we add a test for this?

Sure thing