wrong MacOS sdk version is detect

Hi,
I am trying to build pyobjc binding.
A builder detects 10.15 but clang gets header files for 10.12,
because new protocols are used from 10.13 - build fails.
-isysroot is ignored by clang (don't no why), but it affects sdk version detection!
my workaround is to specify -isysroot a fake path with 10.12 instead of 10.15.
I run Big Sur VM on AWS.
default.nix file:
{ pkgs ? import <nixpkgs> {} }:
  let
    pyobjc = pkgs.python39Packages.buildPythonPackage rec {
      pname = "pyobjc";
      version = "7.3";
      name = "${pname}-${version}";
      src = pkgs.python39Packages.fetchPypi {
        pname = "pyobjc-framework-Cocoa";
        inherit version;
        sha256 = "0zhbp18i06aprwfbp06l9wm3qrzsdcyy9hwis5d4b8wmlzkhb3di"; # 7.3 Cocoa
      };
      CFLAGS="-Wno-unused-argument";
      # workaround
      # CFLAGS="-Wno-unused-argument -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.12.sdk";

      doCheck = false;
      propagatedBuildInputs = [
        pkgs.darwin.libobjc
        pkgs.darwin.apple_sdk.frameworks.Foundation
        pkgs.darwin.apple_sdk.frameworks.CoreFoundation
        pkgs.darwin.apple_sdk.frameworks.AVKit
	pkgs.darwin.apple_sdk.frameworks.AppKit
	pkgs.darwin.apple_sdk.frameworks.DVDPlayback
	pkgs.darwin.apple_sdk.frameworks.CoreServices
        pkgs.darwin.apple_sdk.frameworks.Accounts
        pkgs.darwin.apple_sdk.frameworks.IMServicePlugIn
        # pkgs.darwin.apple_sdk.frameworks.CryptoTokenKit
        # pkgs.darwin.apple_sdk.frameworks.Security
        # pkgs.darwin.apple_sdk.frameworks.CoreHaptics
        pkgs.python39Packages.setuptools
      ];
    };
    foo = pkgs.stdenv.mkDerivation rec {
      pname = "foo";
      version = "0.1";
      src = ./.;
      buildInputs = [ pyobjc ];
      # pkgs.clang pkgs.darwin.libobjc pkgs.darwin.apple_sdk.frameworks.Foundation ];
    };
  in foo

nix-shell

clang -Wno-unused-argument -I/nix/store/096xl1vmxg7hn19pj8s624rpc7h4gdyp-python3-3.9.4/include/python3.9\
 -c Modules/_Foundation.m -o build/temp.macosx-10.6-x86_64-3.9/Modules/_Foundation.o -Wno-deprecated-dec\
larations -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -DPyObjC_BUILD_RELEASE=1103 -Wer\
ror
In file included from Modules/_Foundation.m:14:
Modules/_Foundation_protocols.m:101:28: error: cannot find protocol declaration for 'NSItemProviderWriti\
ng'
    p = PyObjC_IdToPython(@protocol(NSItemProviderWriting));

protocol NSItemProviderWriting appears in SDK 10.13 but headers are for 10.12.

Another miner issue but also related to version detection.
Output directory contains another sdk version not equal to 10.12 nor 10.13 but 10.6!:
clang -Wno-unused-argument -I/nix/store/096xl1vmxg7hn19pj8s624rpc7h4gdyp-python3-3.9.4/include/python3.9\
 -c Modules/_Foundation_inlines.m -o build/temp.macosx-10.6-x86_64-3.9/Modules/_Foundation_inlines.o

It doesn't break anything but looks weird. It must be in sync with version used for building. I was not able to grep location where -o <path> is generate to trace further.
When I run python3 setup.py build without nix I get a correct version of sdk there.
So this is unlikely a pyobjc bug.

Oh my workaround is working only for pyobjc-framework-Cocoa module but not for pobjc-core :(


Added more verbose logging

Excellent utility written thank you. I was having an issue where the ImageMagick was getting stuck on a .tiff file. Added some more verbose logging for success and errors relating to the current image.

Hi @Themikeross, thanks for this PR. Looks like the code got mangled/duplicated a bit, though.

@normanrz, appreciate the comments. I have reformatted.

Thanks for reformatting. What I actually meant is that the whole source code seems to be duplicated. Sorry for not being clear.
If you look at the new lines 1-14 and 15-28 you'll notice that they are almost identical. Seems to me that lines 15 to 99 were added without removing the previous code.


docker swarm 20.10.12 | "docker service update" requires exactly 1 argument.

Hi,
shepherd seams not to be working with swarm anymore, any idea?
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | Sat Nov 12 19:51:14 CET 2022 Trying to update service apps_service_pdns_dns_admin with image ngoduykhanh/powerdns-admin:latest
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | "docker service update" requires exactly 1 argument.
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | See 'docker service update --help'.
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    |
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | Usage:  docker service update [OPTIONS] SERVICE
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    |
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | Update a service
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | Sat Nov 12 19:51:14 CET 2022 Service apps_service_pdns_dns_admin update failed on shepherd!
house_keeping_service_shepherd.1.b3rmqmqvd2zh@docker-swarm    | Sat Nov 12 19:51:14 CET 2022 Rolling apps_service_pdns_dns_admin back

docker version 20.10.12 running in swarm mode
BR Takalele

Hi @etzelc,
thank you - thats on me.
BR
Takalele


Security Slam 2023 Participation

Hello inspektor-gadget community!
In preparation for this year's Cloud Native Security Slam, we've completed a survey of CNCF end users across multiple industries, including Construction, Cybersecurity, Aerospace & Defense, Game Development & Consumer Services, Consulting, and Nuclear.
Through this survey, end users have identified their interest in seeing security improvements to the projects they use. We've asked them to share which Security Slam goals are most interesting to them— and we've compiled the results in a hope that this will help your prioritization during the upcoming event.
While some users have not authorized us to share their name, we've still included their responses in our calculation for you. We CAN tell you that the inspektor-gadget responses included Epic Games.
After calculating the responses according to the interest-weight, we've found these to be the most interesting things that inspektor-gadget end users would like to see, from the five possible Security Slam badges.

The Mechanizer
The Defender
The Cleaner

More information will be announced in the event kickoff webinar on October 10th, including how to register for cash & swag prizes, details about how success is measured, and resources to help achieve each of the badge goals.
If you can't make it to the webinar, a recording will be made available within 24hrs. It will be sent out to the community newsletter with any essential details you may have missed.
Join the community & sign up for the webinar here: https://community.cncf.io/cloud-native-security-slam/

A quick look at the 2023 Event Badges
The Chronicler
Ensure that security documentation has properly formatted data relating to software supply chain security decisions, including instructions for end users seeking to validate provenance artifacts.
The Inspector
Ensure that a security self-assessment has been completed according to TAG-Security documented standards.
The Cleaner
Bring all CLOMonitor non-security scores to 100% for the project, indirectly increasing overall supply chain security (Best Practices, Documentation, License, Legal).
The Defender
Ensure each project repo is accounted for within CLOMonitor; Ensure proper check set is assigned to each project repo; Bring security score to 100% for the project (This statistically decreases the future likelihood of vulnerabilities).
The Mechanizer
Ensure that every release has an automated mechanism to supply SBOM and provenance artifacts.

Hey @eiffel-fl! There is the possibility of logging an exception with CLOMonitor, which will allow you to still be recognized for the work your team is doing to boost project security.
I'll make sure we include this in the Slam Kickoff Webinar tomorrow— thanks for highlighting!

@eiffel-fl, did you get a chance to sign up OCM to qualify for Slam prizes?
Also, we added a getting started guide if you want to check to see whether that's helpful for you

Hey @eiffel-fl, did you get a chance to sign up inspektor-gadget to qualify for Slam prizes?
Also, we added a getting started guide if you want to check to see whether that's helpful for you

@eddie-knight do you know how we can get in touch with end users like Epic Games to get more feedback from them?


distance matrix in sc.tl.dendrogram

is there a way to extract the distance matrix that comes out of sc.tl.dendrogram?
I can't find it in adata.uns['dendrogram_' + groupbyKey] to extract
...

You should be able to get the correlation matrix from:
adata.uns[f"dendrogram_{key_added}"]["correlation_matrix"]


Build landing page HTML

GIVEN I need to start my project
WHEN I load index.html
THEN I see a landing page


INode

Hi, first thanks for this repo. It's awesome :D
A problem which I have is that field names may not used in different table more than once. Otherwise I get following warning:
Interface 'INode' cannot simultaneously extend types 'IQuery' and 'IMyTable'.
Named property 'title' of types 'IQuery' and 'IMyTable' are not identical.

In IQuery is a title function which gives me an MyTable row back but in MyTable itself is a field named title. So interface INode extends IQuery, IMyTable... complains.

i think this is the same issue as #25 which I just merged 😄
thanks for the kind words!

Wow. Great timing.

yep, published in 0.4.0

Before 0.4.0 I used const moduleUtils = require('gql2ts/util/module'); is it replaced by another file?

yeah it's now called gql2ts/util/namespace, sorry for the trouble. When i moved from modules to namespaces i changed that file (~0.3.0)

Ah, easy :D


DatePickerInput component breaks automatic date separator when setting locale to "de"

Current behaviour
When the locale of the DatePickerInput component is set to "de" (German), the functionality to add an automatic date separator ("." in the case of the German locale) is broken. Instead of appending a dot to the first two characters entered, the input gets changed to a single dot. Subsequently, any numbers entered are concatenated without the proper separator.
Example: After typing the digits "25" into the input field, the input field replaces the value to "." instead of "25."
Expected behaviour
When setting the locale to "de", the DatePickerInput component should correctly append a dot (".") to the first two characters entered and add subsequent characters after the dot, maintaining the proper date format.
How to reproduce?

Set the locale of the DatePickerInput component to "de".
Click on the input field to activate the date picker.
Type in the first two characters of a date, for example, "15".
Observe that the input is changed to ".", resulting in a single dot character.
Continue entering numbers, such as "02".
Notice that the input concatenates the numbers without the automatic date separator, resulting in ".02" instead of "15.02.".

Expo Snack: https://snack.expo.dev/@pragatheeswaransornarajan/react-native-paper-dates-input
Preview
https://github.com/web-ridge/react-native-paper-dates/assets/19588386/fcc40e70-8fbc-4869-a960-54550cba34ae
What have you tried so far?
Managed to find the lines that might have caused this issue. It is from this PR and the lines here.
In en locale, the value of replace is $1/$2/$3$4 whereas in de locale, the value of replace is ..........
The issue is reproducible in the latest version 0.18.1
Your Environment

software
version

ios
x

android
x

react-native
0.71.7

react-native-paper
5.8.0

node
18.16.0

npm or yarn
x.x.x

expo sdk
x.x.x

@pragatheeswarans Thanks for opening this issue. If this issue is critical for you, please consider sending a pull request to fix it. If not, we will do our best to get it resolved when available.


chore: upgrade charts to Flux v2.2.2 release

What this PR does / why we need it:

Upgrades the helm charts to use the Flux2 v2.2.2 release.

Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist

[X] DCO signed
[X] Chart Version bumped
[X] helm-docs are updated
[X] Helm chart is tested
[X] Update artifacthub.io/changes in Chart.yaml
[X] Run make reviewable

@stefanprodan @haarchri PTAL 🙏


Add option to pin tabs similar to Visual Studio

There should be an option in Visual Studio Code to pin tabs, like you can in Visual Studio.
As with issue #10739 there should be a config option allowing you to hide the "pin tab" icon in the tab itself if you just want to use the right-click menu or shortcut to pin/unpin tabs.
There should also be an option (again, like in Visual Studio) where pinned tabs are put onto a separate line above the other tabs.

Would love this too, this is how I manage my tabs that I am working directly on in 'visual studio full' and I am finding it somewhat hard to live without as other files that I make minor edits to or simply open to have a look at get in the way.

I am agree, it would be nice

We already have functionality for this. Opening a file from the file explorer with a single or double click does what happens with a pin in Visual Studio. I'd vote to close this issue, and open another making how the tabs are handled clearer. Perhaps adding a pin icon on the window tabs are marked "Keep Open".

@wonea Visual Studio has option to keep pinned tabs separate from open tabs (and on the different row). Such option would be great to have in Visual Studio Code. Perhaps that should be a separate ticket.

@asednev Exactly.  I'd say VS Code could actually improve on Visual Studio by keeping the current behaviour, but additionally allowing pinned tabs to be "top pinned" or something, which would put them in a row about the rest of the tabs.

Another vote for the pinned tabs in a top row. This helps greatly to work on the "main" files when you end up open a lot of files.

Pinned tabs are very good feature which we must to have

I wrote a little VSCode extension to solve a similar problem. It's called Workbench: https://github.com/andrew-lis/Workbench
Maybe my solution could be a hint for you how to implement it natively.

I keep closing tabs by accident, it would be nice to have this feature available (Like Google Chrome does)

Here's a rough mock-up of what I'd like to see:

Created intersecting issue: #32836

yes, for the love of all that is holy add it.

+1

I am shocked that this feature hasn't been implemented yet, I assumed a simple Google Search would yield some setting I need to turn on. I can't say exactly what the productivity cost is, but I sometimes have up to 30-40 pins in Visual Studio and it makes life so easy. Whenever this is added I will be super happy, VS Code dev team.

+1

Is there a way to implement this via a plugin? Even if this is not something the core team is willing to do, I'd love to see this done somehow. I'd be willing to even write the damn plugin myself if it is possible. Anyone know?

+1
Seriously, it's been almost one and a half years since this issue was opened. This needs to happen. This would be a major UI improvement.

We need this.
And btw, quoting @wonea , I don't see any visual cue that the tabs I keep open will indeed be kept opened the next time I open that project. Kind of confusing.

I almost open a second issue for this one. I can't believe that this still an open issue.

I don't wish to be rude but isn't this an open source project? I presume everyone here is a developer. I would love to see this feature too but I realise I don't pay anything for what I believe is one of the best code editors out there and the developers only have a finite set of resources. If you want this feature that badly there is always the option to write it yourself.

You are absolutely right. This is a developer tool, and we as developers should be able to implement this feature. Still, this is heavily demanded and is incredible that nobody, from the community or the team, have implemented it. 😄

Haha true true!

@Caltor das rite

I'm not aware of any way to implement this. Perhaps someone from the team could at least briefly explain what would need to be done?

@Caltor there is always the option to write it yourself... and wait another one and a half year until your PR will be approved (or declined) 😉

@irudoy but you will have it working for yourself, which is nice.

@Mnuzz wouldn't #26965 not be a great starting point?

Actually, that's the thing we want 😅

+1 to have this feature in VS code

+1

+1

Please, use reactions button to vote.

+1

"Keep Open" is not equivalent to pinned tabs whatsoever. I'm not even sure what it actually does other than turn a peek tab into a permanent tab. When I open two tabs, I "Keep Open" on one tab, and then select "Close Others" on the other open tab, and my "Keep Open" tab closes.
Pinned tabs are badly badly needed in this application. I have to constantly close all my open documents because I lose track of the important files I'm currently working on.

+1

After almost 2 years we have only 300+ votes for it. I don't think this is going to make it to live soon.
:octocat:

@bpasero
Hey Ben! Do you know if this is planned in the shortcoming future?
Thanks!

Tell Satya Nadella to do it.

+1, must have feature

+1 must have indeed

+1 must have!

+1 please implement!

+1

+1 Good feature!

Pinned files

Tabs for pinned files are the left most tabs or on a different row
Files are at the top of the Open file list or in a list of their own

I'm conflicted because I'm liking vscode, but I need to pin tabs like I am used to doing in atom, so I'm not sure if I will stay with vscode or go back to atom.
Here's the atom extension, maybe it will help someone implement this feature in vscode.
https://atom.io/packages/pinned-tabs

Pinned files
* Tabs for pinned files are the left most tabs or on a different row

* Files are at the top of the Open file list or in a list of their own

Not sure if that is a question or a statement.
What I prefer is the same kind of operation as with Visual Studio: pinned tabs are in a different row.
Like this:

Why not make it configurable? So the user can choose between pinned tabs on top or pinned tabs as icon only to the left (and maybe right to accommodate users of rtl languages).

if VSC gets pinned tabs, it will go into history as one of the greatests softwares ever coded.

+1 for this feature. "Keep Open" is hardly a solution, especially if you have the "Preview Open" (or whatever it's called) turned off. The pin behavior that @Jusas posted is exactly what I'm looking for:

+1

+1

+!

+1 🚀

Really would like to see this. I miss the visual studio community "close all but pinned tabs" feature. I'd love to see that in Visual Studio Code.

Here's my vote for this. After working with Visual Studio for years, I have come to rely on pins very heavily. While at it, you should be sure to include the ability to place pinned documents on a separate line.

I would really love the option to pin files to the top in the explorer view - not necessarily leave the tab open.
That was requested here and then closed as a duplicate but I'm not sure if it's the same request... https://github.com/Microsoft/vscode/issues/23807

My guess is that a lot of UX has to be considered now that VSCode have the Grid Editor Layout option implemented and breadcrumbs.

@1trevor https://marketplace.visualstudio.com/items?itemName=howardzuo.vscode-favorites

Can't live without separate row for pinned tabs, please

+1 really need this!!

+1

+1

+1 Please

+1 ❤

+1 for this.
As asednev mentioned, pin tabs (as in vs) is more than just keep it open, it's in a different row, which gives a wider view on the opened tabs instead that annoying horizontal scrolling.

+1

Maybe something like highlighting a tab would be cool as a temporary solution,
At least I can visually differentiate important tabs.

(Just like "workbench.editor.highlightModifiedTabs")

Can people just leave a reaction on the initial post rather than adding “+1” comments.
It’s pretty annoying seeing notifications for this thread, only to find it’s someone just adding their +1 rather than an actual update on this issue.

+1

Additional row with pinned tabs reduces vertical space...
I think it would be nice to have the "Keep Open" tabs which are not closed by "close all" and "Ctrl+w".

+1

I would like to pin editor tabs so that they stay in the list of tabs without the need to scroll back to the left or closing all the other tabs one by one. I have the tendency to touch many similar files at once, looking at a few master lists of fixes to find which files to open, and keeping these lists easily accessible would be a godsend.

+1

What could possibly be more useful than this? Should be number one priority

I would really love to have this feature. It is the only thing which I miss so much when switch from VS to VS Code. In most cases, when I'm working on a new task, I have a few key files but touching many other files. If I can pin the key files then it makes my work much more efficient.. not sure why this feature is not implemented for so long time..

+1 (intentional bump for everyone) haha

almost 3 years. we are still waiting!!!

kick the horse!

Github needs a pin feature so this request stays in view until resolved.

Also, I will add that one of the reasons I personally would like pin is to be able to have the behavior provided by Firefox when you pin a tab, which doesn't give a new row but instead shortens the tab to just the favicon (icon) and prevents you from closing it. Otherwise, it's the exact same behavior as any other tab (can Ctrl+Tab to cycle through, etc.).
Could maybe have this be a toggleable feature, have two different types of pinning, or double click a pinned tab to change its size from full to icon (and then have a pin button next to the close button).

+1

+1

+1

Pinned tabs should stay open when we Right Click -> Close All that would be gangsta

This would be very useful. Let's implement this, please!

@bpasero Could you provide an ETA for this, please?
This is extremely useful feature of VS especially for huge projects, but we've been waiting for it in VS Code for almost 3yrs already.

Make this happen, pretty please? :)

Seems to be a pretty basic feature, any idea why it takes this long to implement ?

Make this happen, pretty please? I need this very much~~~

Multi-row tabs (#32836) would be ideal but please make this happen! <3

+1

Was just looking for this - there's no extension already? Is there something related to this feature request that cannot be done by an extension?

+1

+1

+1

+1

Any ETA on pinned tabs or multi-row tabs in Visual Studio Code?
Thanks.

I support having the second row for pinned tabs.
Moving from XCode, where we can open multiple files in a single tab, current VS Code tabs are very limiting.

Sept 12 is the Programmer day,
Can we all get a gift please?

Please support this functionality ASAP!

Difficult? Try impossible, can’t make the switch.

Please support this functionality ASAP!

Trying to be a bit more constructive here... can somebody tell me where's the code that renders tabs? I'm interested in contributing to this feature. In order to show what tabs are pinned, I think the tab should be rendered using an additional icon or different color. I'd also like to add rules to change tab colors per directory, so that one can have custom colors based on what project one is working on in a given workspace (I have such an extension in the full-fledged Visual Studio).

I think here's a possible place to start, the test case that tests closing of tabs...
https://github.com/microsoft/vscode/blob/30c45463bd2d3910629df96265530101bc0754cb/src/vs/workbench/test/common/editor/editorGroups.test.ts#L816

Thank you @davalapar
Interestingly enough, there is a pinned flag in the test :). Definitely indicates some level of support was/is planned.
group.openEditor(input5, { active: true, pinned: true });

+1. Much needed feature.

+1

+3

This is indeed much needed!

Could a clear answer be given on this issue, which is almost 3 years old?
What is blocking the development of this feature?

In most projects, so many files get quickly open that tabs are more of a recent files stack than an actual usable tab. Pinning it would make sure some files are immediately, deterministically accessible (config, router, plugins etc.).
I'm moving from Sublime to VS Code and hoped to get it here, unfortunately it is not ready... :(

I get dizzy scrolling the tabs. Please add this feature please.

I don't like the seperate row idea. If they're pinned like firefox at the beginning of all your tabs then you can use ctrl+[1-9] to shortcut through them. And then shrink the tab size to save space. If you've pinned it, you probably know exactly what it is.

one single row gets crowded too fast, having a second row for pinned will make the workspace much more organized and accessible

Would love to see this. ❤

@eliashdezr They closing every issue that's not happening in the next 6 months, so if this is still open at the end of the iteration, I would consider this to be implemented soon.

Nuts we haven't at least gotten an update. I do my full stack work in VS for reasons, but for our .NET Core projects I would absolutely prefer working in VS Code. Right now going back to not having pinned tabs isn't an option, I can't do it, straight up need the feature to use the product.

If it's that important, throw money at it or do it yourself; otherwise, you get what you get. I don't intend to sound offputting, just telling it like it is. But yeah, this would be really nice to have, we all think that.

I'm surviving fine without VS Code and I don't think there is anything wrong with emphasizing the value of a feature.

I think there may be fear that pinning tabs makes users end up with many of them on all the time. This may affect on performance and memory. It may not be as simple as it looks but there can be a compromise i.e. pin max of 5 windows so at least we have those important ones in our face and cherish them:)

@Enielezi How different would that be from regular tabs? In my view, one advantage of pinned tabs is that you can regularly clean up your workspace by closing all the other tabs without fear of accidentally closing the most important ones... I do that all the time in Firefox: keep Ctrl-W pressed and watch them go! In the end, it helps reducing the number of tabs you keep open.

Pinning tabs affects performance and memory because it keeps files open? I think you have a poor understanding of software and should refrain from commenting on it.

For some reason "Keep Open" is on my menu in VSCode but it's disabled. It seemed like a decent option, why would it be disabled?

That's not pinning. If you click a bunch of files on the left in the Explorer tab, they will all open in one editor tab, replacing each other. This way you can preview files quickly. Keep open causes a file to stay open while you open other files. Double clicking it, clicking Keep Open, or Ctrl+K, Enter will all do this. This discussion is about not being able to close a file with X, and also maybe having icon-only tabs to save tab space for unpinned tabs.

The main reason we don't see an extension that provides this feature yet is that VSCode API does not expose information about what files are openned at a given time. The only available option is to cycle through all the files using a built-in command and keep this by hand (with the downside of flickering the editor and not letting you work properly). And yes, that would be a problem to have several openned tabs at any given moment, specially when some of them won't close at all. Ah, and we can't intercept closed files either because the event get's called on file dispose, not closure (dispose happens in a future time from file close, it's up to VSCode to do that).

Well it's mildly lame to bring up but Webstorm has tab pinning 🤐

Feels like there's been a lot of support for this feature but no updates for 3 years?
+1 from me too.

Yeah, i would like to see this feature also happening.

I was surprised to find this issue here from 2016. Not because it was requested so long ago or so many times, but because it's not implemented. It doesn't seem like an obscenely complicated request, or one that is niche. It seems like something that should have been present since the initial release.

+1

If it isn't going to get added, please at least expose the necessary API to allow an extension to add this functionality.

+1

I am amazed that this isn't already a feature. It definitely is valuable to many other people than me, please consider it.
+1

@alexandrudima Any chance the magic that went into https://github.com/microsoft/vscode/issues/5446 could happen on this one? :)

I need it badly too , i hope it will soon be implemented.

FML, i quit VScode because this...

VS Code gets a lot of hype but it lacks a lot of basic stuff. This is one of them.  I'm really not sure what the hype is all about. I think it's time to give Atom another look but also, maybe just stick with Visual Studio. As it is, all I use VS Code for is to look at log files because it's slightly better than Notepad.

[..] all I use VS Code for is to look at log files because it's slightly better than Notepad.

Yeah, right.. 🙄

As it is, all I use VS Code for is to look at log files because it's slightly better than Notepad.

I agree. If you really need to do something, it's more of a waste of time to use VS Code than simply to load up VS Studio. It's better than Notepad though.

Is there any ETA for this awesome feature?

Adding my support for that feature. It's a mystery to me that something that appears so trivial to implement isn't there after 3 years of request!
Why do we need you night wonder? I use pinned tab has my main work focus. I usually have between 2 to 5 tabs pinned and all the tab noise of opening / looking / searching / inspecting is kept out of it. So when I find what I'm looking for, I can instantly go back to the focused tabs.
Please add this.

+1

What would it be needed to make this feature part of VS Code (baseline)? I believe this is something requested by a lot of active users.

Adding support for this, unsure why it's not being considered still

+1

+1

+1

If I double-clicked multiple files, the first file I opened is lost in oblivion. So I need pinned tabs

This facility is particularly important since the introduction of the ability to limit the number of open editors in the Nov 2019 release. Now (non-dirty) tabs may be closed in the background as I open new ones, and on any given day there are some tabs I really don't want closed — which makes the ability to limit the number of open editors essentially useless to me.

I think 4 years is enough time the VSCode team to consider this :).
We have not hear any official info regarding this, and I would expect some kind of communication from their side since this is in the top 5 more requested features for a looong time.
As someone who primarily use both Visual Studio and Visual Studio Code, is a little bit frustrating not having it.
@bpasero @misolori

The thing that annoys me the most is not that it hasn't been implemented, but the utter lack of official response/info whatsoever. We have been in the dark for years. Just give us a hint about what's going on so we don't have to guess. It's frustrating.

I commented here: https://github.com/microsoft/vscode/issues/92242

Hey, how come I don't see anything about the pinning tabs feature (like, actually pinning tabs) here? It's one of the most desired, asked for, and needed features in VSCode, it's been 3.5 years, and we haven't heard anything back about it.
#12622

Show your support! You're all in quarantine anyways...

Why is this closed?

Welp, guess I’m sticking to VS and other IDEs

@AndrewDavis i don’t think this is the kind of attention for this item you were hoping for 😂

Sorry, I don't know why this is closed now. I was just reading this on my iPad...

@weinand Why did you close that ticket? It is not mentioned as being worked on in the other ticket. Please reopen, we've been waiting for a long time for this simple functionality.

Imagine all the people triggered when they received the email saying this is closed 😂

Imagine all the people triggered when they received the email saying this is closed 😂

Guilty, I started flaming before I saw the reopen ^^
@bpasero @misolori  Any update on that 4 years old feature request btw?

Really, please add this functionality! Clearly there is demand for this feature, but not even one response regarding it from dev team... What is going on here? Another 10 days passed, so again - any updates?

not even one response regarding it from dev team... What is going on here? Another 10 days passed, so again - any updates?

March 2020 Endgame is what's going on here.

Rumor has it pinned tabs helps to spread the corona so the dev team is keeping their distance as much as possible. Until then our tabs are going to have to remain 6 feet apart.

not even one response regarding it from dev team... What is going on here? Another 10 days passed, so again - any updates?

March 2020 Endgame is what's going on here.

It's done now, so what is the next excuse to not add this simple functionality? Or even get an explanation as to why it hasn't been implemented yet?

I've been looking forward this feature, I was happy when I initially found this GH issue here; then I got notification after notification of people who got more and more rude in their tone, demanding a feature as if they were paying for it. But they are not, this is free software, and it's open source. To all you angry people out there: your are developers, so if this little feature is so super important, just do it yourself and stop whining!
... sorry for the emotions. I'm unregistering from getting this issue's notifications now, there's enough bad vibes in the world. And if tab pinning should get implemented some day in the distant future, I'll be extra happy when I see it in the release notes :)

I've been looking forward this feature, I was happy when I initially found this GH issue here; then I got notification after notification of people who got more and more rude in their tone, demanding a feature as if they were paying for it. But they are not, this is free software, and it's open source. To all you angry people out there: your are developers, so if this little feature is so super important, just do it yourself and stop whining!
... sorry for the emotions. I'm unregistering from getting this issue's notifications now, there's enough bad vibes in the world. And if tab pinning should get implemented some day in the distant future, I'll be extra happy when I see it in the release notes :)

So much this. If those who took their time to write semi-acidic comments here just spent half of a weekend looking at the actual code instead, they'd quickly realize it's a fairly trivial thing to implement and we'd already have at least one pull requests for it. But of course, feeling entitled to what you get for free is so much more convenient. :)

@drbarto @peterbozso Well said 👍
I would really like that feature but currently don't have the time to implement it myself, but I would offer a 10$ bounty for it. If some others join me we might just convince someone to implement it in a nice PR :)

Can't say I agree. They're getting paid, we're not. They have time for this, we don't. If it's so trivial, then why aren't you doing it? Don't tell people it's easy to implement it, just do it then.
One can be respectful and still ask, "Y u no do dis?" at the same time.

everyone can see what’s going on next:

https://github.com/microsoft/vscode/issues/95215
https://github.com/microsoft/vscode/issues/95168

Can't say I agree. They're getting paid, we're not. They have time for this, we don't.

some are getting paid to work on this, so they’re probably doing what they’re being told to do. or at least what is of higher priority at the time to meet their goals

If it's so trivial, then why aren't you doing it? Don't tell people it's easy to implement it, just do it then.  There’s nothing hypocrite here. He doesn’t care enough about it to do it and that’s fine (I’m in the same boat and so are you I guess). What’s not fine is continuously complaining. The issue is highly voted, in the backlog, it’ll be done once it’s on the priority list if it ever gets there. Or, if someone else contributes it.

The issue is highly voted, in the backlog, it’ll be done once it’s on the priority list if it ever gets there.

That's a foolish assumption to make. Hence the complaints. When things aren't the way they should be, a lot of people are going to complain. That's how it works.

some are getting paid to work on this, so they’re probably doing what they’re being told to do.

Okay, then we're giving feedback in the hopes that the people telling them what to do will see it?

PLEASE, FOR THE GOD SAKE, STOP SPAMMING.

The lack of communication and the feeling of being ignored for 4 years is what is generating the frustration here. This issue is the 6th most commented issue on that repo, it's supposed to be easy to do, laying around for 4 years, and we have no idea if it's even considered in the short/mid term roadmap.
I would be happy just with a "We would like to do it in the next 6 months, no promises" from a product owner but we don't even get that.
Unsubscribing from that thread as we can't get inputs from the team.

While there are some unsavory comments here, it seems that the majority range from pleasant to simply annoyed.
Telling others to just do it themselves negates the whole purpose of feature requests. Which leads to yannlaidrc's point above. What is the point of having a feature request option at all if highly requested features like this are going to be completely ignored? It certainly doesn't give one confidence in the further development of the application.

Pinning tabs and closing all un-pinned ones are two keyboard shortcuts that I use every day. Hence, this blocks my switch from Atom to VS Code. I am quite surprised that it is neither available as a plugin nor natively.

In case it helps anyone, I found out about the vscode-favorite extension (after expanding the whole history/trail of this long issue).  Not the same as pinned tabs, but serves similar purpose for me. So far so good.
There are some other similar extensions out there as well. I keep this one because it stores favorites in workspace setting instead of separate custom json file.

Brah not even close.

I had a go at trying to implement this in to VS Code about 6 months ago. However, I could not get the feature working back then.
Today I have a makeshift solution to the problem, HardPin:
Repository: https://github.com/Adamantica/HardPin
Website: https://hard-pin.adamantica.com
The solution is by no means perfect, but has still made me considerably more productive.
HardPin is a very cost efficient solution (about 200 lines of simple code) that could easily be implemented in to the actual source of VS Code with improvements. However, due to the fact that the solution leverages the styling of a ::before element and absolute positioning the code not too elegant.
See more info at: https://hard-pin.adamantica.com

I had a go at trying to implement this in to VS Code about 6 months ago. However, I could not get the feature working back then.
Today I have a makeshift solution to the problem, HardPin:
Repository: https://github.com/Adamantica/HardPin
Website: https://hard-pin.adamantica.com
The solution is by no means perfect, but has still made me considerably more productive.
HardPin is a very cost efficient solution (about 200 lines of simple code) that could easily be implemented in to the actual source of VS Code with improvements. However, due to the fact that the solution leverages the styling of a ::before element and absolute positioning the code not too elegant.
See more info at: https://hard-pin.adamantica.com

Not sure if it works. If it does, how to use it. I am still able to close a pinned tab by clicking on the close/'x' button on the tab.

I had a go at trying to implement this in to VS Code about 6 months ago. However, I could not get the feature working back then.
Today I have a makeshift solution to the problem, HardPin:
Repository: https://github.com/Adamantica/HardPin
Website: https://hard-pin.adamantica.com
The solution is by no means perfect, but has still made me considerably more productive.
HardPin is a very cost efficient solution (about 200 lines of simple code) that could easily be implemented in to the actual source of VS Code with improvements. However, due to the fact that the solution leverages the styling of a ::before element and absolute positioning the code not too elegant.
See more info at: https://hard-pin.adamantica.com

Not sure if it works. If it does, how to use it. I am still able to close a pinned tab by clicking on the close/'x' button on the tab.

Are you sure that it does not work? Try opening so many tabs that the tabscrollbar appears and then execute HardPin (as per https://hard-pin.adamantica.com/getting-started/index.html). You should now see a circle to the left of the close button on each tab. Clicking on this circle will pin the tab to the left. Now when scrolling the pinned tabs are always visible.
I have tested that HardPin works on VS Code version 1.37.1 and 1.44.2. I'm using Windows 10. Not that I think that these matter for HardPin.
I admit, I did not even think of hiding the close button. My definition of pinning tabs is that they are always visible to the left, however, hiding the close button would not be a big deal (just one CSS selector).

Hiding most or all of the text is also desired.  You can always visit or hover to see the details.) Perhaps there could be 2 different types of pins, such as "Pin Tab" and "Sticky Tab" (your version).
Not being closeable without the right click context menu is a standard feature of pinned tabs, like in a web browser. Rearranging pinned tabs is allowed, so long as they remain on the left with the other pinned tabs. Also, not having to have other tabs open to pin a tab would be a standard requirement.

Hiding most or all of the title text is also desired.

I don't agree on this one, because when pinning tabs on a browser you at least get the favicon. There is no equivalent of a favicon for files. Still an option could be nice.

Having an option to enable or disable the pin circle would be nice.

Not really how I want it to work, as I'd like exactly the same functionality as in the real Visual Studio, which always shows the pin icon. I agree that the circle could be changed to a pushpin icon. The option could be available if integrated with the VS Code context menu, which is not the case now.

Not being closeable without the right click context menu is a standard feature of pinned tabs, like in a web browser.

Agreed, however, this would have to be implemented directly in to the context menu of VS Code. HardPin is not really integrated with VS Code and is meant to be a makeshift solution that works right now. I can't wait 6 months for this functionality, which is why it is just some extra JS that is executed.

Rearranging pinned tabs is allowed, so long as they remain on the left with the other pinned tabs.

Yes, this is how HardPin works. I pushed an enhancing update a few hours ago, which you might have missed (at least if you tried it out when I first mentioned it), but rearranging pinned tabs has always been possible.

Also, not having to have other tabs open to pin a tab would be a standard requirement.

Don't understand what you mean with this. For example, you can not pin a tab in the real Visual Studio if you have not opened it.
HardPin is a makeshift solution that gets the job done acceptably, not perfectly. However, if this approach would be deemed okay on the general level (the extra style element, ::before element, position: absolute, margins and what not) it would be a cost efficient solution to implement in VS Code. Cost efficient as in small number of changes and relatively few lines of code.

That's great, hopefully that will influence them to add it in.
Again I don't really need the favicon as I'm only pinning maybe 1-4 tabs and I know exactly what they are. But I understand the other use case.

That's great, hopefully that will influence them to add it in.

Yeah, this was long term intention. In the short term I am content with running the extra code once per day.

@Adamantica Does it expose the following actions that I could bind to a keyboard shortcut?

pin current tab
close all un-pinned tabs

@konradjurk
Not yet, but this is a really easy to add. Might be able to do it even today.
What should the keyboard shortcuts be and what shortcuts do other programs use?

@Adamantica Cool! :)
I'm familiar with the "Command Palette" concept in Atom and from a first glance, VS Code seems to implement something similar: https://code.visualstudio.com/api/extension-guides/command You could expose the actions of your extension to the command palette which allows people to bind them to their preferred shortcut or UI button.
I'm personally used to Cmd+Shift+p for pinning and Cmd+Shift+x for closing all un-pinned tabs.

@konradjurk
Sorry, I misread "close all un-pinned tabs" for something else. This can not be implemented without actually coding HardPin in to VS Code. But, a keyboard shortcut for "pin current tab" is possible.
HardPin is not really integrated with VS Code at a deeper level and can thus not register commands, it is meant to be a temporary solution. However, hard coding the pinning keyboard shortcut in to HardPin is not a problem, it's just JS after all.

@Adamantica awesome contribution right there!
Question, would be possible to separate in a top row the pinned tabs?

@konradjurk
I implemented the tab pinning with keyboard shortcut Ctrl + Alt + P.
@eliashdezr
I just implemented the separate row. See https://hard-pin.adamantica.com/getting-started/index.html for instructions.

I had a go at trying to implement this in to VS Code about 6 months ago. However, I could not get the feature working back then.
Today I have a makeshift solution to the problem, HardPin:
Repository: https://github.com/Adamantica/HardPin
Website: https://hard-pin.adamantica.com
The solution is by no means perfect, but has still made me considerably more productive.
HardPin is a very cost efficient solution (about 200 lines of simple code) that could easily be implemented in to the actual source of VS Code with improvements. However, due to the fact that the solution leverages the styling of a ::before element and absolute positioning the code not too elegant.
See more info at: https://hard-pin.adamantica.com

Wow thanks for this it works great! How could this not be integrated in Vs Code now...

We had some UX discussions about how to approach this 2 weeks ago and a first version is now on master. It works pretty much like browsers support pinned tabs:

they move to the beginning of the editor group
they do not close unless explicitly closed (e.g. "Close Others" will not close them)
they stay visible when space is little and a scrollbar appears
they show only with little space (e.g. only the icon) but we think that there could be a setting to change the visual appearance

The current visual appearance is this:

When this will be available in our insiders build I would ask for more feedback when people can try this out, but happy for suggestions based on the video.
One thing to note is that this design is going into a different direction compared to Visual Studio. We currently do not plan to introduce a second tab row because pinned tabs will never scroll out of view. Support for multiple tab rows would be something to move into a new issue and discuss there.

@bpasero Thanks for the progress on this!

We currently do not plan to introduce a second tab row because pinned tabs will never scroll out of view.

After reading this, I don't want to downsize this huge announcement, but the separated row for pinned tabs is like half of the true advantage of using them. I get the technical complications, so, maybe this is not exciting for me anymore if is not possible to achieve it.
This was a long awaiting feature for me to have it, but sadly, it came down to something I did not expected to be.
Thanks for the effort on this.

@eliashdezr that is fair, and I tried to make clear that I am not opposed to discussing multiple tab rows, hence my comment:

Support for multiple tab rows would be something to move into a new issue and discuss there.

What I was trying to say is: I would like to move forward with the current design thinking, gather more feedback from insiders users trying it out and discuss individual improvements in individual issues. I think this issue has become way too large to keep a meaningful discussion in. Hope that makes sense.

Wooooooooooooooooooooooooooooo!!! Good work, and thanks!
This is exactly what I was hoping for. If it works just like in the video, and we can rearrange the pinned tabs, then I have no need to test it other than for bugs.
I don't personally see a need for multi-row tabs, given pinned tabs, scrollability, and multiple windows are all options. I think you get to a point where you have too many tabs open on one window to be effective, and this pinning functionality maximizes that number. I'm not opposed to a multi-row tabs option though, have at it.

When this will be available in our insiders build I would ask for more feedback when people can try this out...
Can you provide more information on this, the insiders build and where you would like feedback?

Thanks again.

Wooooooooooooooooooooooooooooo!!! Good work, and thanks!
This is exactly what I was hoping for. If it works just like in the video, and we can rearrange the pinned tabs, then I have no need to test it other than for bugs.
I don't personally see a need for multi-row tabs, given pinned tabs, scrollability, and multiple windows are all options. I think you get to a point where you have too many tabs open on one window to be effective, and this pinning functionality maximizes that number. I'm not opposed to a multi-row tabs option though, have at it.

When this will be available in our insiders build I would ask for more feedback when people can try this out...
Can you provide more information on this, the insiders build and where you would like feedback?

Thanks again.

@eliashdezr that is fair, and I tried to make clear that I am not opposed to discussing multiple tab rows, hence my comment:

Support for multiple tab rows would be something to move into a new issue and discuss there.

What I was trying to say is: I would like to move forward with the current design thinking, gather more feedback from insiders users trying it out and discuss individual improvements in individual issues. I think this issue has become way too large to keep a meaningful discussion in. Hope that makes sense.

Thanks for clearing that for me @bpasero

Can you provide more information on this, the insiders build and where you would like feedback?

We are about to release VSCode 1.45 this week and the insiders build will be released right after. Insider builds can be installed side by side with stable from https://code.visualstudio.com/insiders/. They update daily and include our latest changes but are quite stable to use (all of the team uses them).
Once insiders is available including this change, I will post here again.

As exciting as unexpected!
THANK YOU!
Even if I think a second row is a must have, I completely understand your approach.
I cannot say thank you enough!

@bpasero Thanks for the update on the feature!
My main feedback is that I believe it's critical to allow users to have pinned tabs on a separate row:

If we want the entire file name to show in the pinned tab, then we'll lose a lot of room for "transient" tabs which will require us to scroll horizontally way more than we should need to.
Having them on a separate line makes it much quicker to differentiate between unpinned tabs

Thank you, looks great!
How is the behaviour when closing multiple tabs?
Will they stay open on "Close All"?

If it works just like in the video, and we can rearrange the pinned tabs

Pinned tabs can be moved in and out to pin or unpin. The drop feedback will indicate what happens (e.g. if you drop on a pinned tab, the tab will be pinned and vice versa).

How is the behaviour when closing multiple tabs? Will they stay open on "Close All"?

The only way to close a pinned tab is by explicitly closing it (e.g. via Cmd+W when active). Actions such as "Close All" or "Close Others" will not close pinned tabs. There are only a few exceptions, e.g. we have a "Close All Editor Groups" command that would also take down pinned tabs.

Awesome work @bpasero ! Exited to see this in VS Code!
It's important to get this first version out there, after which enhancements (for example, the separate row) can be implemented.

Insiders is now updated with these changes: https://code.visualstudio.com/insiders/
To pin a tab you can either:

right click > Pin
or configure a keybinding to the command workbench.action.pinEditor and workbench.action.unpinEditor (CtrlCmd+K CtrlCmd+Enter by default)

I work in a full MS stack but for my client-side work I really prefer working in something lighter like VS Code. It made me sad how much pinned tabs was a deal breaker. From fellow software engineers to software engineers, thank you!

Insiders is now updated with these changes: https://code.visualstudio.com/insiders/
To pin a tab you can either:

right click > Pin
or configure a keybinding to the command workbench.action.pinEditor and workbench.action.unpinEditor (CtrlCmd+K CtrlCmd+Enter by default)

Wow, this is great! I know this is still early in development, but would be great to have an option to pin files and keep the filename visible. Lot of times I just pin things that I just want to keep open indefinitely but it gets tough to know which is which if I have multiple files of a specific type pinned.

Hiding pinned tab filename can be an issue, As most files in a project will of same type, And we cannot distinguish them by just looking at icon

Hiding pinned tab filename can be an issue, As most files in a project will of same type, And we cannot distinguish them by just looking at icon

I agree. A second row for the tabs would be buch more useful for me.
That could be a settings option. Pinned as Icon or row.

For what it's worth I would prefer the behavior to match regular Visual Studio - making the tabs "sticky" to the left, but retaining the full file name.  Heh, I can't say I've ever used the "2nd row" behavior in Visual Studio for pinned tabs :-P

All I want from pinned tabs is that they don't go away when I do a "close all" or "close others" type operation, and also don't get closed automatically if I go over workbench.editor.limit.value tabs open. In fact, the workbench.editor.limit.value thing is the most important to me, since hitting that limit will happen more than I hit "close all", and right now I don't use the workbench.editor.limit.value option at all because without pinned tabs it's useless to me.

Pinned tabs will behave as such:

close operations that are not for a single editor ignore them (e.g. "Close All")
with regards to workbench.editor.limit pinned tabs are treated like dirty tabs and will not close

I think my opinion should also see the file name on a fixed tab.
I think the reason why Chrome's fixed tabs didn't have to be named is because the icons were enough to distinguish them.

In some cases, it might be useful to show just an icon with the first letter of the filename in it (like default avatars showing a user's initials on various platforms).
So for instance with 'README.md' and 'TODO.md' pinned, you would see an icon with 'R' and one with 'T'.

I wonder if one setting should be there where you can simply put the size of a pinned tab (currently it is 38px). If you put more than 38px we start to render the name of the tab.
Btw if you have not seen pinned tabs without icons enabled, they pick the first letter of the file name:

How about adding the icon as a badge on the bottom right corner of the tab.
Just a thought...

I wonder if one setting should be there where you can simply put the size of a pinned tab (currently it is 38px). If you put more than 38px we start to render the name of the tab but it would cut off the name if exceeding that width.
I think this + rounding down to the nearest letter for each tab's title string would be a good idea. I would have suggested just doing letter counts but the tab titles don't look mono spaced so.

@CWempe

How about adding the icon as a badge on the bottom right corner of the tab.

Do you mean to always do that independent from the icon setting or only in this case? I think if the user has chosen to disable icons we should not show them and in the other case, I am not sure if a small badge has sufficient visibility to tell files apart.
@AndrewDavis

rounding down to the nearest letter for each tab's title string would be a good idea

I am not sure I understand that idea. Can you give an example?

rounding down to the nearest letter for each tab's title string would be a good idea

I am not sure I understand that idea. Can you give an example?

Since the font is not monospaced, you could set it to a pixel width and it would theoretically show part of a letter. I'm saying figure out what letter the width lands on, then round down to only show the letter before it if not a whole letter. It may already do that, idk; would look ugly with partial letter visibility though.

Do you mean to always do that independent from the icon setting or only in this case? I think if the user has chosen to disable icons we should not show them and in the other case, I am not sure if a small badge has sufficient visibility to tell files apart.

Actually, I did not know you could disable icons. 😄
Of cause this option should be configurable or depending on the general icon setting.
Here is a quick mockup.

Yes, the "bagdes" might be a little smaller once implemented.
But since many icons have different colors they might be distinguishable, even if they are small.

I guess we will have to see how this will look in reality.
Regarding the width of pinned tab.
I do not know how vscode works internally, but keep in mind users can zoom in and out the GUI.
So a fixed width in pixels might not work. In HTML there are other units ypou can use to dynamically set the size of an element.
But I am sure the vscode developers will know this better than me. 😄

I'd be happy if I could chose Icon + x characters from the file name, preferably without '…' because it just wastes space.
So you can have:
☐ GameManager.cpp
☐ GameM
☐ Ga
☐ G
or just
☐
This doesn't require big layout changes and makes it possible to adjust for every codebase and user.

Hahahaha, so this is what happens when you make a really long file name:

It just takes up the entire space with one tab! :O
(P.S. That's bad.)
And this is what happens when it can't fit it (I made the window smaller), it cuts off the letter:

I'd be happy if I could chose icon + x characters from the file name, preferably without '…' because it just wastes space.

Yeah but as I've been saying it's not a monospaced font so if you did this then the pinned tabs would all be different sizes lol. I mean, I guess you could still do that... Maybe's that's not so bad...

Really? It has no limit on tab with? Well... that's good in a way. But also... bad. Is there a setting for that?
And yes, they would have different sizes, but if you set it to say 4 characters it would only differ slightly.
To unify the widths, I would experiment with fixing the tab width num_chars * 1em. I'm not a web/css expert, but as I understood it, 1em is roughly the "width of an m", the widest character, and it changes with the selected font or zoom level.

You can configure "workbench.editor.tabSizing": "shrink" to let tabs shrink to a smaller size up to a minimum of 120px, but the default (fit) will always show the entire tab, even if it exceeds the available space.

@bpasero Really glad to see things thing are moving forward with this!
To add my view on this, I also believe it would be better to show the full name of the file on the tab by default. Having just the icon when you're working exclusively with cs or js file for example would make it hard to interact with.
There could be an option like "tab.maxfilenamecharsize" to decide if we want to cut the name of the file if it's too long, with a popup when you hover over the tab to display the fullname.
On a side note, have you already created the ticket to talk about the dedicated row for pinned tab by any chance?

I extracted the following issues:

Pinned tabs: show them in a secondary tab row above others #98160
Pinned tabs: add a setting to show more context #98161

On top of that I created a test plan item (https://github.com/microsoft/vscode/issues/98019) where people can see the current implemented set of features. I suggest to file new issues if something is not covered by the existing issues I opened.
@jez9999 if there are no objections I would go ahead and close this issue and continue the remaining parts in the referenced issues. I realize that this issue has gotten a ton of upvotes and explicitly asks for the VS way ("Add option to pin tabs similar to Visual Studio") but would ask for moving votes and discussions into the follow up issues I created.


chore(ts): added description to CreateAppFunction

Added explanation how to pass to rootProps listeners for event emitters inside rendering component.
I used it inside Angular with Webpack 5 Module Federation: link

Hmm, not sure if this is the best place to put this, since the onXXX listener convention applies to all APIs where props are expected. This will be better documented in the upcoming new docs site.


Do we really need data_valtype?

What is the real benefit of the data_valtype column of the property table?
I doubt that we need it. What we need is a documentation on how specific data types should be represented in the property table and which columns shall be used to store the value(s). For example, we must define how a gml:name, a core:lod1Solid or a con:height must be represented. And this documentation should be machine-readable because we need it to be able to map queries expressed in CityGML to a correct SQL statement. I don't see how data_valtype can help here. Moreover, we don't know all possible data types a priori (just think of data types defined in an ADE or other encodings besides CityGML that we want to store in the 3DCityDB v5).
And if data_valtype is just meant to indicate where to look for the value for a specifc row of property, then I still question whether this is useful. For example, assume data_valtype = 1 means the value is stored in val_string and data_valtype = 2 means the value is stored in val_double. If the row contains a gml:name (which I know from the name and namespace), I would always look in val_string to find the value even is data_valtype is set to 2.
I would like to start a discussion why we need data_valtype and whether we shouldn't better remove it.

Agree with removing it, but we must come up with machine-readable rules. Are there already examples regarding this?

I guess removing data_valtype could be a problem because of "cityobject_genattrib" values which may transferred from a CityDBv4 dataset. For Exp: CityDBv4_generic_attribute , CityDBv5_property

Generic attribute types and their value columns:

Generic attribute type
Value column(s)

gen:CodeAttribute
val_string, val_codespace

gen:DateAttribute
val_timestamp

gen:DoubleAttribute
val_double

gen:IntAttribute
val_int

gen:MeasureAttribute
val_double, val_uom

gen:StringAttribute
val_string

gen:UriAttribute
val_uri

gen:GenericAttributeSet
none (but has child attributes)

So, the attribute types can be distinguished based on the value columns used.
There is only one possible conflict because the codeSpace attribute for gen:CodeAttribute is optional according to the CityGML 3.0 XML schema. If not provided in a dataset, one couldn't tell the difference between a gen:CodeAttribute and a gen:StringAttribute if val_codespace is set to NULL.
We could easily require setting val_codespace to something else than NULL to make it unambigious again like, for instance, "<unknown>" or to the namespace of the Generics module. And, moreover, how likely is it that one would use a gen:CodeAttribute without providing a codeSpace?
We could also keep data_valtype just for the generic attribute types (but better rename it to something like generic_valtype then). But I would say it's absolutely required to have it.

@gioagu

Agree with removing it, but we must come up with machine-readable rules. Are there already examples regarding this?

No, there are no examples yet. I think of something similar like the schema-mapping.xml file of the 3DCityDB v4. But it would be much more lighweight because we just have to store the mapping of XML elements and attributes onto columns of property. And the mapping of complex attributes onto self-joins with property, of course.
Would be nice to have one mapping language that would work with other encodings such as (Geo)JSON as well.
Do you have ideas / recommendations?

@muratkendir, just to avoid confusion: the main purpose of the mapping I have in mind is to define how specific data types are represented in the property table. Of course, this information can also be used in a transition from v4 to v5, but this is not its primary intention.
The fact that different data types will use the same (combination of) value column(s) is not an issue. We can unambiguously distinguish them by their name and namespace.
The difference with generic attributes is that name does not store the XML element name of the generic attribute but its user-defined name. So, we only know that we deal with a generic attribute due to the namespace. But we can't tell whether it's a gen:CodeAttribute or a gen:StringAttribute by just looking at the combination of name and namespace. That's why we additionally have to check the value columns as shown in my table. For all other attributes, this is not required.

Just wanted to discuss the easiness of data type distinguishing by using "data_valtype" column. I am also supporting to keep this data in an explicit representation on database, otherwise i think that it could become confusing for the other users in the future and may need complicated switch-case/if-else conditions to convert the data.

Just wanted to discuss the easiness of data type distinguishing by using "data_valtype" column.

As mentioned in my initial post, I would only agree under the assumption that we know all data types a priori and, thus, have a fixed list of data_valtype values. But ADEs, for instance, can define their own data types which are not on our list. For example, assume we have a list of 100 known data types numbered from 1 to 100. Let an ADE define a new data type. We cannot use a data_valtype value from our list for it. So, let's pick 101 as its data_valtype value.
Now, just by looking at the number 101, you can't tell which value columns in property are required to store the value or whether we even need more than one row in property. What you need is an additional documentation (machine-readable or not) that provides this information. And if you already have this documentation, what is the additional value of storing the number 101?
Let's make the example a bit more complicated. Assume we have two 3DCityDB instances A and B. And let's assume we use ADE-1 with A and ADE-2 with B. And, finally, let's assume that both ADEs define their own data types. Then, as a consequence, the data_valtype 101 might have completely different meanings in A and B. So, again, we need a documentation.

According to the offline discussion, drop the data_valtype column. We need a database function to tell how complex attributes should be mapped onto columns of property table. see #169


Axis problem

If your data looks something like this:
let array (Sting, Double) = [("first", 0.001), ("second", 0.001), ("third", 0.001)] there will be a problem with axis x (or y depends how you will pass the parameters).
So main thing is that double value is not changing in data array (straight line) and its less then 1
And in method "func generateAxisValuesWithChartPoints" of "struct ChartAxisValuesStaticGenerator" there is a code:
let last = lastPar =~ first ? lastPar + 1 : lastPar
so "+ 1" is a problem for values than less than 1

Which problem? Can you be more specific?

Problem with scale.
So my values in array are less the 1. And if they are all equal ( like 0.001) there will be a problem.
Chart will be from 0 to 1 and all of my values will be almost invisible because of wrong scale.
Test data for "Hello world" example:
let chartPoints: [ChartPoint] = [(0.0001, 0.0001), (0.0001, 0.0001), (0.0001, 0.0001), (0.0001, 0.0001), (0.0001, 0.0001), (0.0001, 0.0001)].map{ChartPoint(x: ChartAxisValueDouble($0.0), y: ChartAxisValueDouble($0.1))}

ChartAxisValuesStaticGenerator.generateAxisValuesWithChartPoints is just convenience to generate the array and not really needed anymore... I will probably deprecate it soon. Now there are dynamic generators - please checkout the wiki. You of course can also simply pass an array with the desired axis values / write your own logic to generate this array.

thx


Does RDM training use x0-parameterization?

I am training rdm and I noticed the code uses x0-parameterization, is this the same as the rdm training in paper?
Does eps-parameterization harms performance comparing to x0-parameterization in rdm training?
Thanks!

Yes


"Delay Send=" variable in customization.

Is your feature request related to a problem? Please describe.
Even with extremely adept spam bots, spam sometimes appears on some platforms (Telegram is our specific headache) for a few milliseconds before anti-spam bots delete it.
Describe the solution you'd like
I would like a variable for how long until a message is relayed by matterbridge, so for example you could set to 40ms and the message would only get relayed after 40ms if it still existed.  I could also see a use case for setting the variable to say 5000ms or even 60000ms to reduce the number of "post relay edits" that message sometimes have due to quickly caught spelling errors.
Describe alternatives you've considered
We have looked at ways to prevent any posting in our groups until after some kind of non-bot verification is completed, but this is both arduous and only partially effective since most spam is by humans who simply act "bot like"

Aren't these messages automatically deleted on other platforms when it's deleted on one platform?

No, the tools to remove spam and other messages are different between the different environments for a variety of reasons:

the userbase is extremely different - while telegram is a sort of "front porch" environment with 1000s of members the federated Matrix servers require setup to access and have only a few 100 active project contributors, and so does not have the same spam issues.  Because there is work happening there the kind of spam blocking (deleting posts with links or a "ref=" content etc...) would be counter productive as these things are a regular part of work.
the toolsets being used are different, the telegram rooms for over 100 cryptocurrency projects utilize the same toolsets that are still being developed by early bitcoin chat room and bot developers - as such they are not modified project to project
the information passed FROM telegram to other groups (matrix/discord/slack) is sent by "DCR Bridge Bot" as part of matterbridge, and so it is not recognized as coming from a new user.

Adding a delay isn't that difficult. But ..
Telegram doesn't has "deleted messages" metadata, so we don't know which messages are deleted.
Even if it would have this metadata, matterbridge receives every message and relays it, it doesn't stop sending a message because the next messages deletes it.
It's probably possible to do this with a bit of scripting using the matterbridge api as output.
The matterbridge api buffers messages. A script could then do some logic to remove a previous message if the current message has a specific string in it, like [spam] and then sent it back through an input matterbridge api.
Another option (long-term) is to move this buffer also in matterbridge itself (instead of only the API) and expose this in the tengo scripting, so this kind of stuff can scripted there.

A little bit late to the party, apologies.
As it stands I concur with @42wim's assessment. And I do not indeed believe that this would be something easily achievable without some major changes to the manner in which Matterbridge processes messages. I'd suggest we close this issue for now as there's no clear action that could be taken at this point to satisfy the request.

Having recently established a telegram - xmpp bridge, I can say this is a necessary feature.  This creates a significant issue.
Is there any change to the situation now that some years have passed?

Aren't these messages automatically deleted on other platforms when it's deleted on one platform?

I think my question here was misunderstood.

If a message is bridged from Telegram to e.g. Slack/XMPP/whatever,
And then a Telegram bot deletes the spam message on Telegram,
That message deletion should get bridged too, so the spam is deleted on Slack.

Closing this as it's not possible to implement


Refactors to KDefinition/KPrint

From https://github.com/runtimeverification/evm-semantics/pull/1290#discussion_r926383852
Currently a KDefinition is what's needed to do unparsing, and nothing more. So a suggested plan would be:

[ ] Move pretty_print method to KDefinition instead of KPrint, since we don't actually need a kompiled directory of other things like that to unparse things.
[ ] Rename KPrint to KompiledDefinition. And it has a KDefinition (which it reads from disk). Or should it be a KDefinition (inheritance)? If we use inheritance, then when we update the definition (add a module), we need to recall kompile to update the version on disk.
[ ] symbol_table is stored in KDefinition instead.
[ ] Upstream infrastructure from https://github.com/runtimeverification/evm-semantics/pull/1290 which is able to extend an existing KDefinition with new modules automatically (and updates the unparser appropriately).

Several updates have happened to how we store pretty printers and such.


Fix typo in docstring for latsph

The docstring for latsph says that it converts to rectangular coordinates, but it in fact converts to spherical coordinates as documented in the linked page for latsph_c.

Thanks!


WIP: Add new hook for running terraform-docs with main.tf doc replace

Adds a new hook called terraform_docs_replace which uses the documentation found at the top of main.tf to recreate README.md. I'm open to suggestions on the name, I don't love it.
Fix #17
I know this is going to probably come across as "going against the grain" a little bit, but I wanted to write it because this is how I've done all my Terraform documentation, and this seemed like the right place for it to live.
It's not super thoroughly tested, but from the testing that I have done it looks very promising. Switching to Python instead of a shell script actually gives better OS compatibility because it works anywhere Python works vs the bash scripts that only work on OS's in the Unix family. Also, we know Python is already installed because you need Python to run pre-commit

Make filename README.md customizable via args.

Sure that sounds reasonable.

Where main.tf comes from? Where it is used? Why main.tf?

main.tf is the standard entrypoint for a Terraform module. terraform-docs looks for documentation at the top of main.tf to add to the markdown document it creates. I'm not explicitly telling it to do that.

Move setup.py and package files inside a folder (eg, terraform_docs_replace) to not mix root of the repo.

According to the docs setup.py has to stay at the root in order to get picked up by pip.

sed command can be different between systems. Since this is already in Python I would recommend to use native Python methods and replace sed.

Makes sense

Looks good. :)
Could you also add a note to README for developers (not users) something like "It is possible to support any and all future pre-commit hooks written in Python. All you have to do is add a line to the console_scripts array in entry_points."

Don't merge this yet. I'm not done with it.

Actually, maybe I am. @antonbabenko if you're fine with leaving the call to sed in for now this can be merged. I'll open another PR to change the sed call to native Python.

Ready to merge. I'm done making changes unless there are more requested.


fix(network): align HTTP status codes with IANA

Aline HTTP status texts with https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml

They are missing some that we have, like I’m a teapot. I feel like we are entering a scary world.

They are missing some that we have, like I’m a teapot. I feel like we are entering a scary world.

These are added


LFS_ASSERT(pcache->block == LFS_BLOCK_NULL); after LFS_ERR_NOSPC  error

Hi,
We are currently using LFS version 2.5.1 on our device.
We’ve noticed the following case: after a while, after we get the error: “LFS_ERR_NOSPC = -28” , we soon get an assertion from the LFS. For example, after calling the “lfs_remove()” function.
The assert was in: lfs_bd_prog() -> LFS_ASSERT(pcache->block == LFS_BLOCK_NULL)
We managed to overcome this problem, but it’s a bypass, and we are not quite sure this is the right way to do it, and would like for your opinion about this solution:
When lfs_file_write() failed with error: LFS_ERR_NOSPC. Do:
•	call lfs_unmount()
•	call lfs_mount()
This bypass disappeared the asserts completely (so far).
Do you know this problem? Is remounting a valid solution?
Thanks in advance

I ran into the same problem.  However, my callstack is different.
0x600011b0 lfs_bd_prog(): lfs.c, line 242
0x600097ec lfs_ctz_extend(): lfs.c, line 2756
0x6000b4d0 lfs_file_flushedwrite(): lfs.c, line 3366
0x6000b850 lfs_file_rawwrite(): lfs.c, line 3448
0x6000f840 lfs_file_write(): lfs.c, line 5571
Some variables:
lfs_ctz_extend():  head = 0x0000138d, size = 0x001ff02c, nhead = 0x0000138d, nblock = 0x0000138e i = 0
lfs_bd_prog():  lfs->cfg->cache_size = 0x00000100
The problem keeps happening when I try to write a file.  I had to format the flash to get it working again.

I'm having the exact same issue.

Hi all, thanks @TalBarYakar for creating an issue.
This is sort of a known but low priority issue. littlefs is not well tested around "exceptional" errors, so the in-device state can't really be relied on after an error like LFS_ERR_NOSPC is returned.
Calling lfs_unmount + lfs_mount when this happens is really the only safe action right now, though it should also be noted all files need to be closed and reopened as well.

Marking this low priority may be controversial, but it should be noted:

Making sure no functions corrupt filesystem state on error will require a pretty significant rewrite.
This will need quite a bit of testing. The way filesystem state and errors can interact is complex and nuanced.
This will result in a significant stack/RAM increase since most functions will need to track both the before and after on-disk state. Though it may be better to rip this bandaid off earlier than later.
There's already a significant experimental rewrite underway that includes robust error handling as a goal, though this is a WIP.


Mavlink set telemetry_status type properly for SiK radios

remove radio_status type since there's no type support in mavlink
fixes mavlink status output for SiK radios

instance #1:
	GCS heartbeat:  283840 us ago
	mavlink chan: #1
	type:           3DR RADIO
	 rssi:          152
	 remote rssi:   144
	 txbuf:         100
	 noise:         22
	 remote noise:  19
	 rx errors:     0
	 fixed:         0
	flow control: ON
	rates:
	  tx: 0.698 kB/s
	  txerr: 0.000 kB/s
	  tx rate mult: 0.654
	  tx rate max: 1200 B/s
	  rx: 0.063 kB/s
	FTP enabled: NO, TX enabled: YES
	mode: Normal
	MAVLink version: 2
	transport protocol: serial (/dev/ttyS1 @57600)
	ping statistics:
	  last: 169.72 ms
	  mean: 84.86 ms
	  max: 169.72 ms
	  min: 169.72 ms
	  dropped packets: 0

@dagar Does this indicate that we need to document something different in https://mavlink.io/en/guide/mavlink_version.html#semi-transparent-legacy-radios ? (could be fine, just checking)

No, this is just simple command line feedback. This might need review though. https://github.com/PX4/Firmware/issues/10358


huggingface download error

Thank you very much for your open source, I have encountered the following problem with the pre-trained diffusion model from huggingface.
Traceback (most recent call last):
File "/root/code/DiffAttack-main/main.py", line 107, in
ldm_stable = StableDiffusionPipeline.from_pretrained(pretrained_diffusion_path).to('cuda:0')
File "/root/miniconda3/envs/ldm/lib/python3.8/site-packages/diffusers/pipelines/pipeline_utils.py", line 884, in from_pretrained
cached_folder = cls.download(
File "/root/miniconda3/envs/ldm/lib/python3.8/site-packages/diffusers/pipelines/pipeline_utils.py", line 1208, in download
config_file = hf_hub_download(
File "/root/miniconda3/envs/ldm/lib/python3.8/site-packages/huggingface_hub/utils/_validators.py", line 120, in _inner_fn
return fn(*args, **kwargs)
File "/root/miniconda3/envs/ldm/lib/python3.8/site-packages/huggingface_hub/file_download.py", line 1259, in hf_hub_download
raise LocalEntryNotFoundError(
huggingface_hub.utils._errors.LocalEntryNotFoundError: Connection error, and we cannot find the requested files in the disk cache. Please try again or make sure your Internet connection is on.

Hi @junyizeng ,
It seems that there is a problem with the Internet connection. Maybe you can check some possible solutions here.

Thank you very much for your quick reply. Due to the limitation of the device, I am renting the online calculator platform (AutoDL) to run the code, but the file downloaded by stable_diffusion is too large and the system disk is easily filled up, which affects the normal operation of the code. Can I download the files needed to load stable_diffuion in advance and import the model from local? Since this is my first time to use huggingface, could you please provide a tutorial if possible?

Since I'm unfamiliar with AutoDL platform, I'm unsure whether the way I run it with local files will bring some inspiration.
You can first download the files by directly running the following codes on the local machine:
from diffusers import StableDiffusionPipeline
ldm_stable = StableDiffusionPipeline.from_pretrained(“stabilityai/stable-diffusion-2-base”)

Then, you can find these files in the local path (take Win10 as an example): C:\Users\$YourName$\.cache\huggingface\diffusers\models--stabilityai--stable-diffusion-2-base\snapshots\$A Long Serial Number$.
After that, you can directly load the local files without again downloading from the Internet:
from diffusers import StableDiffusionPipeline
ldm_stable = StableDiffusionPipeline.from_pretrained("C:\Users\$YourName$\.cache\huggingface\diffusers\models--stabilityai--stable-diffusion-2-base\snapshots\$A Long Serial Number$")

Thank you very much, the method you gave is effective!

Hi. Thanks for open-sourcing the code of your wonderful work. I met the same error and I cannot fix the error by https://github.com/huggingface/transformers/issues/10067. Could you provide the detailed fixing method of the issue @WindVChen?

Hi @junyizeng ,
It seems that there is a problem with the Internet connection. Maybe you can check some possible solutions here.

Hi @yuuma002 ,
Thanks for your attention. If still fail to download the weight automatically, maybe you can try to download it manually. Try to download all the files here (no need to download 512-base-ema.ckpt and 512-base-ema.safetensors) and save them into a directory (let us name it as A), then you can try to load the weight by:
from diffusers import StableDiffusionPipeline
ldm_stable = StableDiffusionPipeline.from_pretrained(A)

Hope this can help.

由于我对 AutoDL 平台不熟悉，我不确定使用本地文件运行它的方式是否会带来一些灵感。
您可以先在本地直接运行以下代码来下载文件：
from diffusers import StableDiffusionPipeline
ldm_stable = StableDiffusionPipeline.from_pretrained(“stabilityai/stable-diffusion-2-base”)

然后，您可以在本地路径中找到这些文件（以 Win10 为例）：。C:\Users\$YourName$\.cache\huggingface\diffusers\models--stabilityai--stable-diffusion-2-base\snapshots\$A Long Serial Number$
之后，您可以直接加载本地文件，而无需再次从 Internet 下载：
from diffusers import StableDiffusionPipeline
ldm_stable = StableDiffusionPipeline.from_pretrained("C:\Users\$YourName$\.cache\huggingface\diffusers\models--stabilityai--stable-diffusion-2-base\snapshots\$A Long Serial Number$")

Hello, when I load the local model like this, there are two errors. One is HFValidationError and the other is OSError, which says I cannot connect to https://huggingface.co but I want to load the local model. I put local_files_only = True, but this error will still be reported. Hope for your help, thank you


fix ci tests

fixes https://github.com/postera-ai/rdkit-stubs/issues/4
get test/test.bash running again

pin rdkit to just before they started generating thier own stubs
pin pyright to just before it started failing (future prs might update pyright)
swap out setup.py for a poetry-based build
update mypy and fix the small issue it detected in rdGeometry

Maybe marking these stubs as partial will work.


Using object getter function will fail debugger

When using a getter function the GAS Editor debugging will fail with We're sorry, a server error occurred. The script will run as expected.
Steps to reproduce:

Clone the app-script-starter repo
Add a class with getter function

class Fail {
  constructor() {
    this.log = ['a', 'b', 'c'];
  }

  get latest() {
    return this.log[this.log.length - 1];
  }
}

global.failDebugger = () => {
  const f = new Fail();
  Logger.log(`Fail: ${f.latest}`);
};

Debug failDebugger from GAS Editor

Expected result:

be able to debug

Actual result:

debugger fails w/ We're sorry, a server error occurred

Few notes:

actually it is not needed the functionality Fail to be used for the debugger to fail
the starter we where using was inspired (creative copy/paste) from Atlassian Gmail Addon

The Apps Script Starter Kit now uses the v8 Runtime that should resolve the issue.


Live mode read step with OCR can return characters that can't be echoed - to check

Have observed that for some text, after interpreting with SikuliX Tesseract, there can be strange-looking characters. In live mode, these characters when displayed to screen using echo step will throw an unexpected EOF error. Raising issue to track.

Raising as a bug for this scenario which wasn't encountered before previously.

Adding on that the unexpected EOF comes when the string has a line break \n character, which is expected when doing OCR spanning multiple lines.

Above commit fixes a problem in live mode of using echo step on variables that contains new lines.
Users can download the latest copy of TagUI from here and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip
In the next release, this fix will become part of the packaged zip files.

Above commit fixes a problem in live mode of using echo step on variables that contains new lines.
Users can download the latest copy of TagUI from here and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip
In the next release, this fix will become part of the packaged zip files.

Above commit fixes a problem in live mode of using echo step on variables that contains new lines, and adapted to also work for number variables. Otherwise when a number instead of string variable is provided, trying to escape characters will throw errors, because numbers don't have the JS object method to replace characters in them.
Users can download the latest copy of TagUI from here and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip
In the next release, this fix will become part of the packaged zip files.

Above commit fixes a problem in live mode of using echo step on variables that contains new lines, and adapted to also work for number variables. Otherwise when a number instead of string variable is provided, trying to escape characters will throw errors, because numbers don't have the JS object method to replace characters in them.
Users can download the latest copy of TagUI from here and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip
In the next release, this fix will become part of the packaged zip files.

Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0


add bearer auth capabilities to http transport;

has some connection to #1020

One other thing i can improve is the typescript definition to force the developer to use either bearer or basic. right now both could be filled in and result in some oddities.

I think if both are set then it's more or less user error.  One could imagine some weird backends too where you'd want that flexibility.  So I think this PR is good to go as-is.  Thanks for your patience!


new domain

@halukhafizoglu file/lib/domains/tr/edu/kku.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.


Python 3.8, CARLA 0.9.14, Leaderboard 2.0

I want to test the trained agent in CARLA 0.9.14. How should I go about it? Do you have any plans to upgrade to Leaderboard 2.0?

Sorry, when the paper public, CARLA don't have leaderboard 2.0, if you want, you can try to adapt this one to 2.0 version. And welcome to pull request.


let's report jacoco aggregate

Now we only report coverage of eo-parser module to codecov (see codecov.yml). Let's report an aggregate report, as explained here: https://github.com/jacoco/jacoco/wiki/MavenMultiModule

@andreoss please help us here

@yegor256 aggregated-report seems to be a too convoluted way (having an extra module to do aggregation). For codecov it's enough to read jacoco reports for each module separately, without creating one aggregated report

@andreoss let's do it the way you propose, I agree

@andreoss I believe it's fixed, I'm closing. Thanks!


Feature | Make build.py tasks composable similarly to how build.env can be combined

Currently Leverage CLI supports multiple config files (build.env) to be combined/merged by placing them in current or parent directories. We would like to explore the possibility of having the same feature applied to the tasks defined in build files (build.py).
For instance, we could have the following directory layout:
.
├── build.py
└── subdir
    └── build.py

1 directory, 2 files

The build.py file at the root could have the following task definitions:
@task()
def hello():
  ...

@task()
def test():
  ...

And then ./subdir/build.py file could have these other tasks:
@task()
def run():
  ...

So the combined build.py would end up having all three tasks. On the same line, build files in a subdirectory should be able to override task definitions.

As per our discussion along @diego-ojeda-binbash and @angelofenoglio, we'll close this issue and consider it to be re-opened in the future in case it's really needed in a project. For the moment the current leverage custom tasks (https://leverage.binbash.com.ar/user-guide/leverage-cli/tasks/) fully covers our current project requirements.
CC: @binbashar/leverage-ref-architecture-aws-admin @binbashar/leverage-ref-architecture-aws-dev


[BUG] Extracting parameter from a wrong template

While adding parameter 1 of :es:Template:NF as P569, the tool has extracted the first parameter of a different template, :es:Template:BDCL.
It is important to check when this bug has appeared in the past and to revert the affected edits.
See:

https://www.wikidata.org/?diff=331856538&oldid=329198640
https://es.wikipedia.org/w/index.php?title=Alfonso_Sánchez_Candeira&oldid=90723582&action=edit&section=4

See also https://www.wikidata.org/w/index.php?diff=331766421&oldid=331265705.

This happended because :es:Template:BD is a redirect to :es:Template:NF. The parser is then also looking for :es:Template:BD and matched unfortunately :es:Template:BDCL.


Investigate extra topics 11-13

They are very similar and they all get 0 for every metric.

This relates to #66 .

We are focusing on the final topic set, let's close this now and solve #66 if needed.


jest-repl sets NODE_ENV to 'repl'

Can we still have the null check to allow explicit overwrites?

By the time this is executed, process.env.NODE_ENV = 'test'.


Reference of Android plugins have changed in 3.3.rc6

Godot version:

3.3.rc6
OS/device including version:

MacOs Macbook air 2017
Issue description:

org.godotengine.godot.Godot): [0x6] register v2 has type Reference: org.godotengine.godot.Godot but expected Reference: android.app.Activity
Steps to reproduce:
use a plugin from 3.2.3 and copy it to 3.3.rc6
Minimal reproduction project:

https://github.com/DisDoh/GodotVibrate
I've used my plugin which is working on 3.2.3 but not on 3.3.rc6

@DisDoh that's expected behavior. Even for 3.2.3 you were using the godot instance incorrectly; you're supposed to use getActivity() instead.
Once you make the switch the plugin should work for both 3.2.3 and 3.3.

Thank you


multilanguage raw url does not redirect to slug

the langswitcher uses raw urls, clicking on them does not redirect to slug

Just needed to enable: pages: redirect_default_route: true


jo_fixed_mult actual working compiling 100% legit

haha throw football denny

by the way if you would like to contact me the most immediate method is SegaXtreme discord


Publishing doesn't flush website cache

Q
A

Bug?
yes

New Feature?
no

Sulu Version
1.4.3

Browser Version
Chrome 55.0.2883.95

Actual Behavior
When I publish a modification on a page already online, the website cache is not flushed, i don't immediately see my modification online.
Expected Behavior
When I publish a modification on a page already online, the website cache is flushed, and i immedialty see my modification online.
Steps to Reproduce
On prod env :
Publish a modif on a page, display the page on the website
Possible Solutions

I've just tried that on the master branch and it is working for me, there only seems to be an error on develop... But maybe you are experiencing a different issue than I have... Can you check the log files of Sulu and check if there are any errors?

I was on the 1.4.3 version, updated to the 1.4.5 , but it was steal the same behavior
Nothing in log files
will PR for #3149 will fix it in the next release ?

Hmm i have seen that the implemented fix is for a bug which was introduced in develop. so- if you use 1.4.5 the fix does nothing change for you.
I think you use the symfony-http-cache and not varnish? Correct me if i am wrong.
You should see in the log following line (if logging is on for prod) [CACHE] INVALIDATING [%s]: %s. This indicates that a purging is scheduled. If then happens an error the cache was not cleared if you dont see something the cache should be cleared.
Another thing which could be that your browser caches the response of the url (which will also be done for a short amount of time). then the request wont be done at the server.
Could you please give me feedback for this?

I use symfony-http-cache
i think logging is on on prod because i have files : var/logs/website/prod/prod.log and var/logs/admin/prod/prod.log, but nothing show up in theses files when i publish my page, or when i flush website cache.
it's not browser cache, il see the access log on the server, and have the same old page  on other browsers.
in the response headers i have :
Age:331
Cache-Control:max-age=240, public, s-maxage=240, max-age=0
Age grows up on each request, until i flush the website cache il the back-office.
thank's for your help

@spras just to be sure the client side cache is disabled in the chrome webdev tools? because as you see the page itself is cached for 240 seconds on the client browser. If you have a proxy in your company the proxy will also cache it for 240 seconds.

no client side cache, no company proxy , the site is on HTTPS , but nothing else : https://cms.hmdiffusion.com/

@spras can you check if it does locally work on PROD environment? And can you maybe check if it works correctly without https?

yes, i was trying to do that, and it works.
Now, i'll try to add https localy.

here it is, with https i reproduce the bug localy, (env prod of course)

ok then it seems to be related to #2929
@sulu/core-team seems like we need to have a look again into that issue because it seems not to be fixed in 1.4.3

FYI i updated to 1.4.5, and i have the same behavior.
I also notice that the PURGE request is send and respond code 200 => but on http  , not on https
my page on http is updated, but the same page on https is the old cached one.
Do we have to configure the scheme some where to tell sulu admin to purge on the right scheme ?

More infos :
When i configure my webspace with : <url language="fr">cms.hmdiffusion.com</url>  It doesn't works
When i configure my webspace with : <url language="fr">https://cms.hmdiffusion.com</url>  It doesn't works
When i configure my webspace with : <url language="fr">{host}</url>  It works !
But i ran i an other issue ? ... I have 3 webspaces , if i set  <url language="fr">{host}</url>  on the 3 webspaces, the 3 sites render the same webspace ...
What's the good practice to configure the webspaces URLs ?
Thank's for your help

@spras could you try the linked PR with your code. it seems that we have forgotten to generate urls with https at this place. The given fix should do it!

@wachterjohannes 👍  it's ok with this patch
hope it will be released soon
Thank's you very much

there will be a HOTFIX with such a fix soon (:

@spras The code was changed once more, do you want to test it again?

@danrot : it's ok for me, it's works

fixed in sulu/sulu#3150


Move healthcheck outside domain constraints

The AWS ECS healthcheck uses an internal hostname which fails to route and causes the cycling of tasks due to healthcheck failures.

Thanks 👍🏻