Safari/Firefox browser: keyboard not working for TextFields within SelectionArea + Dialog

Steps to reproduce

Run the given code with Flutter Web in the Safari or Firefox browser
Open the dialog
Try to write some text in each field

Expected results
The keyboard should work correctly
Actual results
Half of the time the keyboard doesn't work. If you focus an other field, sometime it works and sometime it just doesn't.
It works for the Chrome browser but not for Firefox or Safari (on macOS)
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(App());

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: SelectionArea(
        child: Scaffold(
          body: Builder(
            builder: (context) {
              return Center(
                child: FilledButton(
                  onPressed: () {
                    showDialog(
                        context: context, builder: (context) => EditDialog());
                  },
                  child: Text('Open dialog'),
                ),
              );
            },
          ),
        ),
      ),
    );
  }
}

class EditDialog extends StatelessWidget {
  const EditDialog({super.key});

  @override
  Widget build(BuildContext context) {
    return AlertDialog(
      scrollable: true,
      title: Text('Dialog'),
      content: Column(
        mainAxisSize: MainAxisSize.min,
        children: [
          for (var i = 0; i < 8; i++)
            TextField(
              decoration: InputDecoration(labelText: 'Enter text'),
            ),
        ],
      ),
      actions: [
        FilledButton(
          onPressed: () {
            Navigator.pop(context);
          },
          child: Text('OK'),
        )
      ],
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel beta, 3.27.0-0.1.pre, on macOS 14.5 23F79 darwin-arm64, locale en-BE)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.2.3)
[✓] VS Code (version 1.93.0)

I just found this issue and am wondering if it might be connected to my own.
I basically face the exact same issue with the same inconsistencies, but for me its a TextFormField on top of a PointerInterceptor.

Any workaround for this? Except falling back to flutter 3.19.6. This is a very serious problem, maybe a quick fix is needed.

I tried inserting SelectionContainer.disabled at different places in the widget tree but that didn't help.

SelectionArea seems to be an actual area on the screen, not just a part of the widget tree. So if there is a SelectionArea behind the text field, the text field does not work.
Here is a minimum example:
import 'package:flutter/material.dart';

void main() async {
  runApp(
    MaterialApp(
      home: Column(
        children: [
          const Expanded(child: SelectionArea(child: Placeholder())),
          Builder(
            builder: (context) {
              return ElevatedButton(
                child: const Text('Show dialog'),
                onPressed: () {
                  showDialog(
                    context: context,
                    builder: (BuildContext context) {
                      return const SimpleDialog(
                        children: <Widget>[
                          TextField(),
                          TextField(),
                          TextField(),
                        ],
                      );
                    },
                  );
                },
              );
            },
          ),
          const Expanded(child: SelectionArea(child: Placeholder())),
        ],
      ),
    ),
  );
}

The top and bottom text fields don't work because they have a SelectionArea behind them. The text field in the middle works.
This also happens in a stack:
import 'package:flutter/material.dart';

void main() async {
  runApp(
    const MaterialApp(
      home: Scaffold(
        body: Stack(children: [
          SelectionArea(
            child: Text("just some text here to create a selction area"),
          ),
          TextField()
        ]),
      ),
    ),
  );
}

Clicking closer towards the bottom of the text field enables input.
Clicking closer towards the top, where the text field is covering the selection area, leads to the broken behavior.
So this doesn't seem directly related to dialogs, but it's more likely to affect them because they cover other parts of the app.
I have tried putting an AbsorbPointer widget underneath the dialog, but that also doesn't work.
Any other workaround ideas short of removing all selection areas when showing a dialog?
I'd also be happy with a quick fix for this ;)

One not-so-clean workaround is removing the SelectionArea widget when the dialog is opened:
onPressed: () async {
  setState(() {
      modalOpened = true;
    });
    await showDialog(
      context: context,
      builder: (BuildContext context) {
        return const SimpleDialog(
          children: <Widget>[
            TextField(),
            TextField(),
            TextField(),
          ],
        );
      },
    );
    setState(() {
      modalOpened = false;
    });
}

and on the Widget tree, you add a condition for the selection area:
if(!modalOpened) const Expanded(child: SelectionArea(child: Placeholder())),

I have the same issue (only on Firefox and Safari) with :

TextField in dialog with SelectionArea
TextField in dialog with PointerInterceptor

Can we expect a fix soon ?
Thank you

I ran into the same issue and found a workaround. That is just wrap the AlertDialog in a SelectionArea
`import 'package:flutter/material.dart';
void main() => runApp(App());
class App extends StatelessWidget {
const App({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: SelectionArea(
child: Scaffold(
body: Builder(
builder: (context) {
return Center(
child: FilledButton(
onPressed: () {
showDialog(
context: context, builder: (context) => EditDialog());
},
child: Text('Open dialog'),
),
);
},
),
),
),
);
}
}
class EditDialog extends StatelessWidget {
const EditDialog({super.key});
@override
Widget build(BuildContext context) {
return SelectionArea(
child: AlertDialog(
scrollable: true,
title: Text('Dialog'),
content: Column(
mainAxisSize: MainAxisSize.min,
children: [
for (var i = 0; i < 8; i++)
TextField(
decoration: InputDecoration(labelText: 'Enter text'),
),
],
),
actions: [
FilledButton(
onPressed: () {
Navigator.pop(context);
},
child: Text('OK'),
)
],
),
);
}
}`

I'm also experiencing this issue with text boxes in dialogs.


Why is it not using cache?

I've configureD imageproxy WITH with caching to disk:
/app/imageproxy -addr <IP_ADDRESS>:8088 -cache /tmp/imageproxy -verbose

When I request the image, it's downloaded, stored on disk, resized and the resized image is also stored on disk (I can see the files in the data folder).
However in the logs I see that cache was not used when I request the same image again. Note that the image url I'm requesting contains query string parameters.
imageproxy listening on <IP_ADDRESS>:8088
2024/06/04 09:25:52 fetching remote URL: https://REDACTED/index.php?gf-download=2024%2F06%2Fimage123.jpg&form-id=47&field-id=7&hash=0afa966d17976e112816ada2cc6b9275
2024/06/04 09:25:56 request: {Method:GET URL:https://REDACTED/index.php?gf-download=2024%2F06%2Fimage123.jpg&form-id=47&field-id=7&hash=0afa966d17976e112816ada2cc6b9275#1000x0 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[image/*] User-Agent:[willnorris/imageproxy]] Body:<nil> GetBody:<nil> ContentLength:0 TransferEncoding:[] Close:false Host:REDACTED Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc000038020} (served from cache: false)
2024/06/04 09:25:58 fetching remote URL: https://REDACTED/index.php?gf-download=2024%2F06%2Fimage123.jpg&form-id=47&field-id=7&hash=0afa966d17976e112816ada2cc6b9275
2024/06/04 09:26:01 request: {Method:GET URL:https://REDACTED/index.php?gf-download=2024%2F06%2Fimage123.jpg&form-id=47&field-id=7&hash=0afa966d17976e112816ada2cc6b9275#1000x0 Proto:HTTP/1.1 ProtoMajor:1 ProtoMinor:1 Header:map[Accept:[image/*] User-Agent:[willnorris/imageproxy]] Body:<nil> GetBody:<nil> ContentLength:0 TransferEncoding:[] Close:false Host:REDACTED Form:map[] PostForm:map[] MultipartForm:<nil> Trailer:map[] RemoteAddr: RequestURI: TLS:<nil> Cancel:<nil> Response:<nil> ctx:0xc000038020} (served from cache: false)

Same problem with Redis connection
imageproxy -addr <IP_ADDRESS>:8080 -cache redis://:@redis:6379/0

what caching headers is the upstream server sending?  It's been a little while, but there was some discussion some time ago about overriding upstream caching headers, but I don't think it was ever implemented: https://github.com/willnorris/imageproxy/issues/28

Hi @willnorris
        proxy_set_header Connection "upgrade";
        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header X-Forwarded-Proto $scheme;
        proxy_set_header X-Forwarded-Host $server_name;
        proxy_set_header X-Real-IP $remote_addr;

However, the thumbnails are not in the folder. The CPU is always running. Imageproxy performs the resize but never saves the output.

But what headers are sent from the server hosting the image?  For example, the codercat image from GitHub specifies an etag, an expires timestamp, and a cache-control header:
% curl -I https://octodex.github.com/images/codercat.jpg
HTTP/2 200
etag: "64f0b60d-70bf"
expires: Sun, 08 Sep 2024 16:54:00 GMT
cache-control: max-age=600

Those are what allow imageproxy to know how long it can cache the image.  What happens if you try to load the codercat image in your proxy?  Is it being served from cache?  If so, then take a look at the response headers from the remote image you are loading to see if it has similar caching headers.


add auto ack and timeout configurable

Motivation
we need a way to configure to ack-timeout and auto-ack for the pulsar source consumer.

@srkukarni updated

rerun java8 tests

run java8 tests

run java8 tests

rerun java8 tests

rerun java8 tests

rerun java8 tests

rerun java8 tests

retest java8 tests


🐛 [firebase_ui_auth 1.1.10] strange behaviour with "enable more sign in methods"

Bug report
When there is only one auth provider configured, a problem occurs with sign-in methods button and enable more sign-in methods.
See  https://github.com/firebase/flutterfire/issues/10431 for files etc.
Issue number 2 in firebase_ui_auth 1.1.10 issues.pdf
see also
https://github.com/firebase/flutterfire/issues/10431
https://github.com/firebase/flutterfire/issues/10433
https://github.com/firebase/flutterfire/issues/10434
https://github.com/firebase/FirebaseUI-Flutter/issues/36
https://github.com/firebase/FirebaseUI-Flutter/issues/35

as of Flutter 3.13.1 • channel stable and firebase_ui_auth: 1.7.0 this is no longer reproducible (icons are not clickable in "Sign in methods" row on ProfileScreen)


Missing v0.1.11 tags for x86_64-unknown-linux-gnu has broken cross

It looks like the v0.1.11 tag wasn't deployed for the x86_64-unknown-linux-gnu target. This has broken testing for us.

Err, it seems our x86_64-linux build got removed from the .travis.yml file and that's why there's no Cross release fo that target. I'll make a manual release.

Nice, at least my code seems to build again with the v0.1.11 image pushed now :)

This has now been fixed.

Thanks for reporting @Susurrus! And thanks @CryZe for checking.


Is there a library that help me calculate password verifier for confirm device of cognito?

Confirm by changing [ ] to [x] below:

[x] I've gone though Developer Guide and API reference
[x] I've searched for previous similar issues and didn't find any solution

Platform/OS/Hardware/Device
macOS
Describe the question
Is there a library that help me calculate password verifier for confirm device of cognito?
I read cognito-user-pool-remembered-devices and want to implement it into my c++ application.
I found that there is a AuthenticationHelper.js in amplify which help js developer calculating the password verifier. So, I wonder if there is a c++ version library to do so. I do found someone posted srp_A calculator. But, password verifier calculator is missing. Thanks.

Hi @wukakuki ,
I am not really sure what you are looking for here, but I don't think we have anything of the sort, we do not really provide helper libraries... The best place to look for something like that would be on the aws-iam service but yea...
Could you show me a code sample? even if it's just pseudo code, just so I get a better idea on what you expect the helper to do. Maybe it can be done with our current tools.

can you see this picture? I want a c++ library to help me calculate the salt and password verifier for confirm device from cognito idp client.

Hi @wukakuki ,
I am not really sure what you are looking for here, but I don't think we have anything of the sort, we do not really provide helper libraries... The best place to look for something like that would be on the aws-iam service but yea...
Could you show me a code sample? even if it's just pseudo code, just so I get a better idea on what you expect the helper to do. Maybe it can be done with our current tools.

Hi @wukakuki sorry for the slow response but no, we don't really provide any such helper.

Thanks


Good article

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d35c94ec-c9ad-0233-4115-3ddc43ddcd38
Version Independent ID: 6b231b6b-523b-445d-2b15-7dfc04da7ef9
Content: Quickstart - Configure Terraform using Azure Cloud Shell
Content Source: articles/terraform/get-started-cloud-shell.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@suda007 Thanks! Please feel free to let us know any ideas you have for us to make improvements.


add metrics

We can use these metrics to see whether pd does capacity balance or not.
@disksing @BusyJay @tiancaiamao @qiuyesuifeng

Coverage decreased (-0.1%) to 81.761% when pulling b9ebd6228b254e9f587e5980d0e937bb7ecb1a29 on siddontang/store-metric into f31aaa2a8f9bc985dc303b3f0f9daba7c10c826b on master.

LGTM

LGTM.


Inspector property array for TabBar

Allows to add tabs to TabBar directly in the inspector. Related to #52463

Looks good, but the property should be called tab_count. Also needs rebase.

Rebased and ranamed to tab_count

Thanks!


support Pandas dataframe as training data

Thanks for sharing the great code!
Lightgbm is a popular package, which supports numpy, pd.df as train/test data.
It would be great for modAL to support pd.df as train/pool/test data.
Thanks!

I have started to implement the pandas.DataFrame support and I came across a major issue. The crux of the problem is that numpy arrays use row indexing, while pandas DataFrames use column indexing by default. That is, if you have a dataset X, then for instance X[0] gives the first row if it is a numpy array, but gives the column with index 0 for pandas DataFrames.
This causes a major incompatibility problem in the query strategy functions. When query strategies select the instance to query, they return the index and the instance as well. Currently, I have found no way to access the given instance in a type-agnostic way. One possible way to circumvent the problem is to remove the query instance from the return values of a query strategy. Since this would be a huge change, I am hesitant to do this.

The sklearn package is a good example to load pandas data frame. It converts the pd df to numpy.
https://medium.com/dunder-data/from-pandas-to-scikit-learn-a-new-exciting-workflow-e88e2271ef62
Hope this will be helpful.
Thanks!

It would be a very useful feature to improve the workflow and integration with other packages. Is there a branch we can help on this feature?

Currently, there are no feature branches specifically for this, but feel free to create one in a fork from the dev branch! I am happy to help, since I also think it is an important problem, I just haven't solved it yet. As I outlined in my previous comment, the main issue for me is that pandas DataFrames are indexed by column first, while numpy arrays are row first. One possible way to solve this is to immediately convert to numpy array, but this kind of defeats the purpose for me.

I have started to implement the pandas.DataFrame support and I came across a major issue. The crux of the problem is that numpy arrays use row indexing, while pandas DataFrames use column indexing by default. That is, if you have a dataset X, then for instance X[0] gives the first row if it is a numpy array, but gives the column with index 0 for pandas DataFrames.
This causes a major incompatibility problem in the query strategy functions. When query strategies select the instance to query, they return the index and the instance as well. Currently, I have found no way to access the given instance in a type-agnostic way. One possible way to circumvent the problem is to remove the query instance from the return values of a query strategy. Since this would be a huge change, I am hesitant to do this.

One could handle pandas data frames separately, e.g.
    if isinstance(X, pd.DataFrame):
        return X.iloc[query_indices]

    return X[query_indices]

In order not to include this in all query strategies, these could return indices only as you suggested. This functionality can then be added only in the query() method implementations.
Once this is done, the only changes remaining to support pandas data frames are when working with instance representations, e.g. calculating similarities between them. If #104 is resolved (I am working on it), one could replace the used estimator with an sklearn transformation + estimator pipeline, where the transformation converts the data frame to a matrix. Something similar to:
from sklearn.preprocessing import OneHotEncoder
from sklearn.pipeline import Pipeline
from sklearn.ensemble import RandomForestClassifier

ActiveLearner(
            # it's important to clone the model to have separate models for
            # predictions and active learning loop; ActiveLearner fits the
            # provided estimator to the provided training data
            estimator=Pipeline(steps=[
                ('transform', OneHotEncoder()),  # results in a matrix
                ('classify', RandomForestClassifier())
            ]),
            query_strategy=uncertainty_batch_sampling,
            X_training=X_training,
            y_training=y_training,
            on_transformed=True  # not implemented, should force query strategies to work on transformed data (one hot encoded)
        )


New version: Korg v0.17.0

Registering package: Korg
Repository: https://github.com/ajwheeler/Korg.jl
Created by: @ajwheeler
Version: v0.17.0
Commit: fc1c0b27424ed313d4d5cab66a6d533a3106092f
Reviewed by: @ajwheeler
Reference: https://github.com/ajwheeler/Korg.jl/commit/fc1c0b27424ed313d4d5cab66a6d533a3106092f#commitcomment-108012105
Description: 1D LTE stellar spectral synthesis in pure Julia

Commenting to block.  I forgot a documentation thing I wanted to add.


--insecure

Skip auth and tls configuration with --insecure

Coverage decreased (-0.5%) to 77.601% when pulling 10d9c82907daa2a64cc64b61cf5e9118eff11b75 on add-insecure-option into d14bef9fbc7fe719663012de89796b49b1cd5b41 on master.

Coverage decreased (-0.5%) to 77.601% when pulling 10d9c82907daa2a64cc64b61cf5e9118eff11b75 on add-insecure-option into d14bef9fbc7fe719663012de89796b49b1cd5b41 on master.


Add Markdown extension to LICENSE, grammar updates to README

I appreciate the contribution but these aren't changes I would like to see. You can find my thoughts on LICENSE.md at https://github.com/Erisa/download-image/pull/13 and these grammar adjustments are not ones I find necessary.


Remove type from nested documents; where types used to store nested path information

Remove _type field used to store nested paths

Confirmed with @nknize ; that this is not a blocking change for 2.0 relase.

This is implemented in https://github.com/opensearch-project/OpenSearch/pull/3004.

Closing this issue, as relevant PR is merged into main.


Error 500?

Hello,
when I try to login, the method GetUserAccountsAsync (platform is PS4) always returns:
{"debug":"","string":"","code":"500","reason":""}
Next there will be a JSon deserialization exception.
Any ideas? Sorry I'm a newbie...

Figured it out, I needed to add the code taht was mentioned in Issue "Login verification".


An attempted fix for the SignalTextChanged crash

This is conjecture - I was totally unable to repro the original crash here.
Based on the stacks in MSFT:39994969, it looks like we try to fire off a
RaiseAutomationEvent, which calls through UIA core, eventually to the point of
calling ComPtr<WUX::Automation::Peers::IAutomationPeer>::{dtor}. I'm guessing
based on the stacks that the TermControl has already been released and cleaned
up. However, the lambda in the RunAsync calls here only takes a ref to the
TCAP. The TCAP has an outstanding reference (maybe on the other side of the UIA
fence), and gets successfully resolved as strong, but when calling to
RaiseAutomationEvent, the owner we passed in is gonezo.
This explicitly passes a weak_ref to TermControlAutomationPeer, rather than
a raw ptr, so we can actually check if the control is still alive before we
dereference it.
Again, this is hearsay. Without a repro, the only way we can confirm this is
gone is by just hoping the crashes go away. 🤞

Might close #13357 (we'll reopen if it doesn't?)
narrator still works

Since the destruction process is the wild west, might be worth adding some THROW_IF_NULL(_uiaProvider) or something like that throughout?

Won't that turn destruction "whoopsies" into guaranteed crashes of the entire Terminal and all of the tabs it is hosting? Is there a safer way to do this?

I'd prefer @lhecker be the second on this if he's comfortable with it.

I'm not really in favor of this PR.

You don't need to sign off on something you're not in favor of! Should we file a workitem to fix this more soundly? Should we take this as a "stopgap" until we can fix it more soundly?

You don't need to sign off on something you're not in favor of! Should we file a workitem to fix this more soundly? Should we take this as a "stopgap" until we can fix it more soundly?

Maybe I was too terse. 😄 I'm in favor of merging this, just not in favor of this PR because it's a stopgap. I think we should just continue to work on cleaning up our pointer safety and data sharing behavior. Maybe even do it consciously at some point instead of doing it on a case by case basis.
IMO we should remove any use of this (including implicit use) if it can be avoided and find and if possible remove implicit recursion like this one were class X calls Y which calls back into X (e.g. introduce class Z which is used by both X and Y, removing the need for recursion).

Maybe even do it consciously at some point instead of doing it on a case by case basis.
YES

Noted conversation, follow-up in #13896


Issue with reassigning ctx.query and type preservation

Describe the bug
Node.js version:
16.15.1
OS version:
Windows 11
Description:
Per the Koa docs, you can reassign to the ctx.query object. Whenever I do so, any typing that I have, is not preserved in future middleware or future calls to ctx.query (i.e. a value of [ 2 ] in the object just becomes '2' or the number 5 becomes the string '5'), although the actual assignment does seem to occur as indicated below by the fact that id becomes 4 after assignment, indicating something has changed.
Actual behavior
INITIAL QUERY OBJECT [Object: null prototype] { id: '2', arr: '5' }
QUERY FROM JOI VALIDATION [Object: null prototype] { id: 2, arr: [ 5 ] }
number
CTX.QUERY AFTER ASSIGNMENT [Object: null prototype] { id: '4', arr: '5' }
QUERY IN 2ND MIDDLEWARE [Object: null prototype] { id: '4', arr: '5' }
string
Expected behavior
This is what I would expect from code example below.
INITIAL QUERY OBJECT [Object: null prototype] { id: '2', arr: '5' }
QUERY FROM JOI VALIDATION [Object: null prototype] { id: 2, arr: [ 5 ] }
number
CTX.QUERY AFTER ASSIGNMENT [Object: null prototype] { id: 4, arr: [ 5 ] }
QUERY IN 2ND MIDDLEWARE [Object: null prototype] { id: 4, arr: [ 5 ] }
number
Code to reproduce

I've included a stack overflow entry and code sandbox that replicates this issue in addition to my project on my Windows 11 computer.
https://stackoverflow.com/questions/75368044/unable-to-reassign-ctx-query-in-a-koa-middleware
const Koa = require("koa");
const app = new Koa();
const Joi = require("joi");
const PORT = 3000;
const validSchema = Joi.object({
  name: Joi.string().optional(),
  id: Joi.number().required().min(0),
  arr: Joi.array().items(Joi.number()).optional().single(),
});
// #1
app.use(async (ctx, next) => {
  console.log("INITIAL QUERY OBJECT", ctx.query);
  const { error, value } = validSchema.validate(ctx.query);
  if (!!error) ctx.throw(400, error);
  console.log("QUERY FROM JOI VALIDATION", value);
  value.id += 2;
  console.log(typeof value.id);
  ctx.query = value;
  console.log("CTX.QUERY AFTER ASSIGNMENT", ctx.query);
  await next();
});
// #2
app.use(async (ctx, next) => {
  console.log("QUERY IN 2ND MIDDLEWARE", ctx.query);
  console.log(typeof ctx.query.id);
  await next();
});

app.use(async (ctx, next) => {
  ctx.body = `test koa`;
});

app.listen(PORT);
console.log(`http://localhost:${PORT}`);

<!--
We encourage you to submit a pull request with a failing test:

1) This will make it more likely for us to prioritize your issue.
2) It's a good way to prove that the issue is related to this project and not your code.

## Checklist

- [ x] I have searched through GitHub issues for similar issues.
- [x ] I have completely read through the README and documentation.
- [ x] I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.

ctx.query  uses querystring  to parse query parameters internally.
when you use ctx.query = value，It is equivalent to ctx.query = querystring.stringify(value);
when you get ctx.query, It will return querystring.parse(value)。

This isn't a bug but a side effect of how delegation works in Context.
The return value from accessing ctx.query is actually coming from context delegating access to ctx.request.query. As @senfish wrote the result you're seeing is the evaluated queryparser result. I would recommend you instead took the result from Joi and assigned it to something under e.g. ctx.state.validatedQuery.
I'm closing this ticket as this is not a bug. If you still have questions you can re-open this or a new ticket.


BlockedFileTypes-chrisda to Master

Docs Build status updates of commit bc42fb8:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit bc42fb8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a2540df:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit a2540df:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0758eb0:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 0758eb0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit c5ed15a:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c5ed15a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 82b9e49:
:clock10: Full build: the average full build time is 18 min(s) 9 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 82b9e49:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


i made changes in css

Title and Issue number

Title :
Issue No. : #1020
Code Stack :
Close #<issue_no>

Description

Video/Screenshots (mandatory)

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[ ] I have performed a self-review of my code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have gone through the  contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

[ ] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

i made changes in css


Update search.json

Proper translation of search.json, all checked with Spanish translation. "Tags" translates to "Etiquetas", the short form to say "Labels" in Spanish as well, in both instances, the application of the word is fine given that Ghost is a blog.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!

[x] There's a clear use-case for this code change, explained below
[x] Commit message has a short title & references relevant issues
[ ] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Done.

No, there remains another spelling error/typo.

Done.

No, there remains another spelling error/typo.

Thanks,
Fernando Ochoa Olivares.

Closing as duplicate of https://github.com/TryGhost/Ghost/pull/21246.


How add CI/CD in Flutter existing Android app

We have added Flutter in existing native Android.so now we have two repositories.Flutter_module and  Android_module. I am using GitLab for CI/CD pipeline. Now the problem is how to set include_flutter.groovy path in setting.gradle because it is in another repository.

This is a question better suited for StackOverflow, since there doesn’t seem to be anything wrong with Flutter itself. Closing, as this is not an issue report. See https://flutter.dev/community for support options.
If you disagree, feel free to comment and I will reopen the issue.


linux

Doesn't work on Lubuntu 16.04.
Keepass v. 2.33 - current version on jtalylor ppa.
"Incompatible with current Keepass version"

I don't have tested it with Mono but with Windows you need to have .Net 4 installed. Don't know which Mono version you need to use, sry.

Now I have tested KeePass with Ubuntu 16.04 and I can't use KeePass with a single extension. Every extension gives me an error, so this isn't an error of my plugin.

I have tested KeePassQuickUnlock <IP_ADDRESS> on Ubuntu 16.04 with latest version of mono-complete and keepass 2.32.
The plugin works fine.
I haven't tested KeePassQuickUnlock 2.1.

Good to know, thank you!

I was also getting this with all plugins (except Ubuntu Integration Plugins) on Ubuntu 16.04 (64-bit).
I figured out how to fix this, thanks to the comment by @siamak2. All that I needed to do was to install mono-complete (it's in the repository). I would not have known to do this!


[Videos] Add error boundary to native

Copies over error boundary logic and turns web UI into a reusable component

I think we want to be logging these errors to Sentry (at least the native ones) so we can get some info if we run into anything. Maybe I'm missing where it happens, but let's add if it isn't already doing that.

<ErrorBoundary> handles it :)

swear i looked there and didnt see it...cool!


V2: Non truncated blog article in feeds

🚀 Feature
When working with the blog feed, in testing-library's, we would like a way to contain the full article and not just a truncated version of it within the feed since we don't really care about retention or something like that.
Motivation
Following this PR in testing-library, we think that having a way to send a non truncated version of an article can be helpful for people that just want to spread the word and don't care about traffic to their site rather than just spread updates.
Pitch
I believe we can add this by adding another config to the blog feed options, I'd be glad to help and create a PR for this one if you find it suitable.
Thanks for your hard work and help!

Adding to the rationale here, I would expect most Docusaurus sites to be for community projects that on't need to be monetized. I think leaving blog posts non-truncated by default and adding an option for the old behavior (if encouraging site traffic or reducing feed size is necessary) would be even better.

Also, this should be relevant to both V1 and V2. If approved, perhaps it should be backported from 2 to 1 or merged into 2 after 1.

Ok for an option to have non-truncated feeds.
I don't know much about RSS feeds and best practices regarding monetization/conversions, but if you can back up your claims by some authority link that explains why it's better to have non-truncated articles in feeds, we can make this the default.

Also, this should be relevant to both V1 and V2. If approved, perhaps it should be backported from 2 to 1 or merged into 2 after 1.

v1 is in low maintenance mode, it's not very important to backport this feature now, we'll encourage people to adopt v2 instead.

I can take this one if it's ok :)

Ok for an option to have non-truncated feeds.
I don't know much about RSS feeds and best practices regarding monetization/conversions, but if you can back up your claims by some authority link that explains why it's better to have non-truncated articles in feeds, we can make this the default.

Taken from the RSS 2.0 Spec:

I think we should keep the title and URL even if the description contains the whole item.
Any thoughts? I've already started working on this btw.

If I remember correctly the generated description didn't seem to include the title and URL

@slorber I've implemented this and I did get the full post in the description but it was plain markdown and nothing rendered it.. I saw that in the classic-theme you use MDXProvider to render the MDX.. Any ideas what we can do here for the feeds?
Thanks!

I see
The thing is, a user might be able to add mdx interactive components in the blog post. In such case, what should be the behavior of such feed? The feed reader won't be able to render the React component, but we can still render such component and get it as a static HTML string (it's just it won't be interactive anymore).
You should likely call ReactDOM.renderToString to generate the feed as HTML
MDXProvider only permits to replace default HTML elements with custom implementations, that does not seem 100% mandatory, but may be helpful to improve the default renderToString if not good enough
The question is: how do we transform markdown to a JSX tree on the server, so that we can feed renderToString with it?
The MDX apis I know compile markdown to React component source code, not a JSX directly.
We generally write this source code to disk, and require it like regular source code. Wonder if we can avoid this step that seems a bit useless in such case.

Looks like mdx/runtime is what we are looking for: https://mdxjs.com/advanced/runtime
Something like this may work
import React from "react";
import ReactDOMServer from 'react-dom/server';
import MDX from "@mdx-js/runtime";

async function mdxToHtml(sourceFilePath) {
  const mdxString = await fs.readFile(sourceFilePath);
  return ReactDOMServer.renderToString(<MDX>{mdxString}</MDX>);
}

There's a pending PR here, let me know if the implementation looks good to you, but to me it does not because it assume the blog post content is a regular string

There's a pending PR here: #4330
Let me know if the implementation looks good to you, but to me it does not because it assume the blog post content is a regular string

Hi @slorber!
Sorry, I didn't get a chance to solve this one and I have a WIP draft on my local machine..
Regarding what you wrote, I strongly agree. I'll try to add that functionality soon if this won't be solved in that PR already.

In my pr https://github.com/facebook/docusaurus/pull/4330, I already change render from plain text to Full Markdown support, but without customize component.
and i dont think its a good idea for add config to choose whether show full content for blog. Its not a content website, you know.
For feed of docusaurus, I wanna know is any other suggest about that? I am glad with someone still use rss, and hope to improve user experience in docusaurus

and i dont think its a good idea for add config to choose whether show full content for blog. Its not a content website, you know.

@moonrailgun
Actually, I do think it should be a config, one of the purposes of RSS feeds is to attract people to your site and gain visitors, not all use cases should show all content.
If you're working on that, I'll delete my draft, but for further work you do on OSS, it's generally a good idea to ask in the issue if someone is still working on a feature :)

and i dont think its a good idea for add config to choose whether show full content for blog. Its not a content website, you know.

@moonrailgun
Actually, I do think it should be a config, one of the purposes of RSS feeds is to attract people to your site and gain visitors, not all use cases should show all content.
If you're working on that, I'll delete my draft, but for further work you do on OSS, it's generally a good idea to ask in the issue if someone is still working on a feature :)

I am soooo sorry for that because i have not found your issue before.
and for config, maybe your can add a config above my work? Also i dont think its right, but more customize way is not a bad work, right?

What's remaining for this issue to be fixed/merged @MatanBobi?

This actually isn't my PR anymore as @moonrailgun did the work.
If the current implementation isn't enough, I'll try to work on one next week :)

sorry, but my pr #4330 is still pending and no reply. I have no idea how to continue.
@stnor  @MatanBobi

I'm sorry, I didn't have time to review this PR because I have more important features to work on and this feature is not a top priority in my todo list, and I think the current PR is not totally ready (I find it strange to need to use remove-imports).
Unfortunately reviewing this PR is time-consuming because I have to conduct some additional tests locally to be sure it's working fine, and it's not time I'm willing to invest atm, but will come back to this when possible.

I'm sorry, I didn't have time to review this PR because I have more important features to work on and this feature is not a top priority in my todo list, and I think the current PR is not totally ready (I find it strange to need to use remove-imports).
Unfortunately reviewing this PR is time-consuming because I have to conduct some additional tests locally to be sure it's working fine, and it's not time I'm willing to invest atm, but will come back to this when possible.

Well, thanks for your reply. Feel free to take time for other things, i will waiting for your review. If have any suggestion for my pr, I am grad to change it or modify it


Fix irmin-git -> irmin constraint

... and add installation instructions to the README for installing Irmin from master.
I'm sure I've mentioned this before, but I feel that issues with opam install . should be caught by the CI.
Resolves https://github.com/mirage/irmin/issues/972.

Also in opam-repository: https://github.com/ocaml/opam-repository/pull/16060


fix: increase memorySize for lambda

Overview

increase memorySize from 256 to 512 to decrease execution time of the api lambda

Issues

https://algorandfoundation.atlassian.net/browse/ENG-210

Sorry for late response, LGTM


The append option in file appender doesn't work properly

Description
Use new FileAppender(the append option is set to false, the fileName option is equivalent to previous FileAppender) to log rest messages after logging some messages, the previous messages still exists in the log file.
This fact does not conform to the description in official documents: When true - the default, records will be appended to the end of the file. When set to false, the file will be cleared before new records are written.
Configuration
Version: 2.23.1
Operating system: all
JDK: JDK17
Logs
xxxxxxxx
xxxxxxxx
11111
11111

Reproduction
log4j2.xml
<Configuration status="WARN">
    <Appenders>
        <Console name="Console" target="SYSTEM_OUT">
            <PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n"/>
        </Console>
        <File name="file" fileName="logs/run.log" append="true"/>
    </Appenders>
    <Loggers>
        <Root level="info">
            <AppenderRef ref="Console"/>
            <AppenderRef ref="file"/>
        </Root>
    </Loggers>
</Configuration>

a demo to reproduct the issue:
public class Main {
    private static final Logger LOG = LogManager.getLogger("logger");

    public static void main(String[] args) {
        LOG.info("xxxxxxxx");
        LOG.info("xxxxxxxx");

        LoggerContext context = (LoggerContext) LogManager.getContext(false);
        LoggerConfig logger = context.getConfiguration().getLoggerConfig("logger");
        logger.removeAppender("file");
        FileAppender appender = FileAppender.newBuilder().withAppend(false).setName("file")
                .withFileName("logs/run.log").build();
        appender.start();
        logger.addAppender(appender, Level.INFO, null);
        context.updateLoggers();

        // after using a new appender, i expect the log file to only contain the following message.
        LOG.info("11111");
        LOG.info("11111");
    }
}

I have browsed through the source code to find where the append option is actually used. This option is used when opening a FileOutputStream:
https://github.com/apache/logging-log4j2/blob/fea2a7116160fb1555d578406444b4fc4f0ef2da/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/FileManager.java#L251
When different FileAppender use the same fileName option, they can use the same FileManager, which means they will share the same FileOutputStream:
https://github.com/apache/logging-log4j2/blob/fea2a7116160fb1555d578406444b4fc4f0ef2da/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/AbstractManager.java#L144
The outputstrem in same FileManager only instantiate once, so change the append option doesn't work properly.

@taylorThunderbolt,
This behavior is by design: there can be only one FileManager per file.
If two FileAppenders point to the same file, they both use the same FileManager and they will both use the same value of the append option.
Note that having more than one FileAppender per file is not a recommended configuration. This situation occurs naturally only during a reconfiguration process, when the "old" and the "new" appender coexist for a short moment to prevent log event loss.
If you really want to change the value of the append option you need to:

either use a different file name,
or explicitly stop the old "file" appender, before creating a new one. Warning: this will cause log event loss.

NOTE: even if the current implementation would allow you to create a second FileManager, by using ./logs/run.log, I wouldn't recommend approach.
This is an implementation detail and we might change the implementation at some point (e.g. we could normalize the file names).

Note that using append="false" on a FileAppender where the same file is already open on another FileAppender would likely cause serious problems on Windows if each FileAppender had its own FileManager. Even on Unix I would imagine a user might file a bug if append="false" actually cleared the already open file being written to by another FileAppender as it would result in data loss.
Having multiple FileAppenders point to the same file on the same file system is just a bad, bad idea, even if they are in separate JVMs or are running on separate servers.
Note that in the options Piotr recommends the second option may not be possible if there are multiple LoggerContexts each trying to log with the same configuration or multiple applications running on the same server with each using the same configuration.
I should not that ALL Appender Managers exhibit similar behavior. Every Manager keys on the options that are necessary for it to be unique and will cause all other Appenders using those same values to share the same Manager.
Closing since this is by design and won't be changed.

@ppkarwasz @rgoers
got you guys point, thanks a lot ^_^


Make the error more strongly typed

Allow users to distinguish between pkg-config being disabled by an environment variable, missing and genuinely failing.

Oops, it had slipped my mind that enum variants can have named fields, I'll fix that tomorrow.

Hm, this is unfortunately a breaking change, which would require a major version bump of this library. I think I'd prefer to do this through "pseudo deprecation" like:

Add a new function (maybe named something like "probe") which sits next to the existing ones
Implement the old functions in terms of the new
Mark the old functions as #[doc(hidden)] and document them as deprecated

In terms of backwards compatibility of the enum itself I may want to think a bit more about the variants and the payloads, but I think that using named fields would probably help more here, yeah. Another thing to do would perhaps be to add a #[doc(hidden)] __Nonexhaustive variant documented as saying "please don't match on this, we're likely to add more variants over time".

Why is major version bump undesirable?
I've addressed the comments.
The lack of impl Debug for Output in stable libstd might suggest my choice of error field types is suboptimal. Alternatively we could wait for 1.7 and do bump the version.

A major version bump is basically undesirable because it's a major version bump. Most users probably won't even see breakage, and with 99 reverse dependencies there's not really any reason to require an update.
Also yes, let's use an explicit impl Debug to work around the lack of impl for Output for now.

Added explicit impl Debug and version bump.

Thanks!

I'd also like to make println!("cargo:...") optional. Would you accept such feature and does it make sense to fit into the same 0.3.7 crate push?

Yes I can add that


LoggerPluginModule giving error

I am trying to use LoggerPluginModule and it works ok as long as I have a single store. Once I add a 2nd store, I start getting the following error (Windows, Angular 5) in both Chrome and IE. Here I've added a second store "WellStore" and it's giving error.

Can you make a stackblitz demo? Would be really helpful for us

LoggerPluginModule fails for me as well, but in another way.
TypeError: Cannot read property 'app' of undefined
    at StoreFactory.invokeEvents (ngxs-api.js:200)
    at Ngxs._dispatch (ngxs-api.js:326)
    at Ngxs.dispatch (ngxs-api.js:311)

app.modules.ts config looks like this:
NgxsModule.forRoot([AppStore]),
ReduxDevtoolsPluginModule.forRoot({ disabled: isProduction }),
LocalStoragePluginModule.forRoot({
	key: STORAGE_KEY_NGXS_STORE,
	serialize: JSON.stringify,
	strategy: StorageStrategy.sessionStorage,
	deserialize: JSON.parse,
}),
LoggerPluginModule.forRoot({
	logger: console,
	collapsed: true,
}),

@amcdnl unfortunately none of jsfiddle or stackblitz work on my office workstation. I tried to move files around and was also getting the bug mentioned by @perjansson above. Not sure if could only be on windows environment as I tried somewhat similar code on osx and it worked ok.

I think this is the same as #71

@tsawan can you see if you have the same error when using 2.0?

horay!


Failed to run the unit test of bonus_tests

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Centos7.6
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.0 master branch, commit-id:af019188adc704569b7cce51e50eba489af1a725
Python version: 3.6
Bazel version (if compiling from source): 0.27.1
GCC/Compiler version (if compiling from source): 6.3
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
After build from source code:
bazel --output_user_root=$build_dir build --config=v2 //tensorflow/tools/pip_package:build_pip_package

I run the unit test:
bazel --output_user_root=$build_dir test //tensorflow/core/kernels:bonus_tests

It failed with the error message:
ERROR: no such target '//tensorflow/core/kernels:bonus_tests': target 'bonus_tests' not declared in package 'tensorflow/core/kernels' (did you mean 'loss_test'?) defined by /home/lesliefang/debug_failrunbonus_tests/tensorflow/tensorflow/core/kernels/BUILD
INFO: Elapsed time: 0.382s
INFO: 0 processes.

Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
As the description above.
Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

If I change this line:https://github.com/tensorflow/tensorflow/blob/bfce5bae88e01c080c8cc9224b439c4dd26c506b/tensorflow/core/kernels/BUILD#L3163-L3193
tf_cc_tests to tf_cc_test
It can find the unit test case and show pass result.

As you can see here tf_cc_tests perform tf_cc_test form multiple ops(components)
Source
# Create a cc_test for each of the tensorflow tests listed in "tests"
def tf_cc_tests(
        srcs,
        deps,
        name = "",
        linkstatic = 0,
        tags = [],
        size = "medium",
        args = None,
        linkopts = [],
        kernels = []):
    for src in srcs:
        tf_cc_test(
            name = src_to_test_name(src),
            size = size,
            srcs = [src],
            args = args,
            kernels = kernels,
            linkopts = linkopts,
            linkstatic = linkstatic,
            tags = tags,
            deps = deps,
        )

Example
tf_cc_tests(
    name = "bonus_tests",
    srcs = [
        "adjust_contrast_op_test.cc",
        "colorspace_op_test.cc",
        "crop_and_resize_op_test.cc",
        "non_max_suppression_op_test.cc",
        "resize_area_op_test.cc",
        "resize_bicubic_op_test.cc",
        "resize_nearest_neighbor_op_test.cc",
        "scale_and_translate_op_test.cc",
    ],
    linkopts = select({
        "//tensorflow:macos": ["-headerpad_max_install_names"],
        "//conditions:default": [],
    }),
    deps = [
        ":image",
        ":ops_testutil",
        ":ops_util",
        ":sampling_kernels",
        "//tensorflow/core:core_cpu",
        "//tensorflow/core:framework",
        "//tensorflow/core:lib",
        "//tensorflow/core:lib_internal",
        "//tensorflow/core:protos_all_cc",
        "//tensorflow/core:test",
        "//tensorflow/core:test_main",
        "//tensorflow/core:testlib",
    ],
)

Let me know if the above explanation helps. Thanks!

@gowthamkpr Thanks for the explanation. I understand the definition of tf_cc_tests.
The question is why I run：
bazel --output_user_root=$build_dir test //tensorflow/core/kernels:bonus_tests
which throws the error:
ERROR: no such target '//tensorflow/core/kernels:bonus_tests': target 'bonus_tests' not declared in package 'tensorflow/core/kernels' (did you mean 'loss_test'?) defined by /home/lesliefang/debug_failrunbonus_tests/tensorflow/tensorflow/core/kernels/BUILD
INFO: Elapsed time: 0.382s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
FAILED: Build did NOT complete successfully (0 packages loaded)

ERROR: no such target '//tensorflow/core/kernels:bonus_tests': target 'bonus_tests' not declared in package 'tensorflow/core/kernels' (did you mean 'loss_test'?) defined by /home/lesliefang/debug_failrunbonus_tests/tensorflow/tensorflow/core/kernels/BUILD
Can you take a look at the source of in this path in your system and let me know if 'bonus_tests' is declared or no?

@gowthamkpr Yes, 'bonus_tests' is defined in the file $tensorflow_root/tensorflow/core/kernels/BUILD
I am using master branch, commit-id: af019188adc704569b7cce51e50eba489af1a725
You can help to reproduce this issue if possible.

The name of the tf_cc_tests rule is never used to create an executable. If you check the definition, it creates executable tests for each of the entries in srcs (their name derived from name of their source file). So you can for example run:
bazel --output_user_root=$build_dir test //tensorflow/core/kernels:adjust_contrast_op_test
(this is the first of the created tests from the bonus_tests target).

@akuegel Thanks a lot and It explains clearly.


Revert "[Gluten-547] Shade protobuf to avoid jar conflicts (#767)"

This reverts commit cc6d264ccb9999f19584d1021724fed0f6df4c3b.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@CodingCat Why was the patch reverted? Any context about this PR we can refer to?

@CodingCat Why was the patch reverted? Any context about this PR we can refer to?

With this pr, there are errors when opening project in IDEA.


Bug: Unable to select the text typed if it initiates the Mention plugin

Lexical version:
Steps To Reproduce

Try typing Perfect in a blank editor
Mention Plugin will be initiated for a fraction of a second
Try double clicking on the typed word

https://github.com/facebook/lexical/assets/67912316/4c1f6ca9-8044-43d0-bef7-a63622d4c6cc

@KarthikRaju391 Is this the playground editor? If not, I'm not sure if there's much we can do. It looks more like an issue with the underlying Regex.

@thegreatercurve, This is the custom editor that I have been working on. But, I have just been using the mention plugin as is from the playground.


Inverse Image

I have a requirement of interviewing a candidate in realtime using realtime streaming. Everything works fine, except that the candidate has to show some ID card. When an ID card is displayed the text is reversed even in the saved video. Is it possible to stream the video without reversing the text?

Any luck with the issue?


[bug] franka state controller publish rate works incorrectly

I was trying to record the franka state at a large frequency (>200Hz) and I found out the /franka_state_controller/publish_rate parameter works incorrectly.
I used a value of 500 Hz, but when I used the command rostopic hz /franka_state_controller/franka_states, it gave me an average rate of around 380 Hz, so I thought this was the max for my system.
However, today I tried larger frequencies.
1000 Hz gave me actually 650 Hz and 1500 Hz gave me actually 975 Hz, so the system can handle higher frequencies.
The problem is that the desired frequency is not the same as the actual frequency.

This problem does not occur in the joint_state_publisher


Doc: starting-guide-concept-review

This pr aims to add documentation for

future concepts

manifest information
listening & responding to functions

future starting guide

I am seeking feedback on

the flow of the documentation
writing style (tried to keep it short and simple)
typos
links to api.dev.slack.com

the migration guide still remains to be written.
In order to run the documentation locally:
# clone project
git clone https://github.com/WilliamBergamin/bolt-python.git
cd bolt-python

# install python 3.9, this is optional
brew install pyenv
pyenv install 3.9.6

# create virtual env
pyenv local 3.9.6
python -m venv env_3.9.6
source env_3.9.6/bin/activate

# start webserver
scripts/run_jekyll.sh

# should be available on http://<IP_ADDRESS>:4000/bolt-python/

Category (place an x in each of the [ ])

[ ] slack_bolt.App and/or its core components
[ ] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[x] Document pages under /docs
[ ] Others

Requirements (place an x in each [ ])
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

NOTE everything in docs/api-docs/slack_bolt/ is generated code no need to review it


MXNet 1.8.0 fail to import ONNX model

Description
I was trying to follow the official documentation: https://mxnet.apache.org/versions/1.6/api/python/docs/tutorials/packages/onnx/super_resolution.html
to import an ONNX model into MXNet but failed.
Error Message
ValueError                                Traceback (most recent call last)
<ipython-input-6-d9827b2914f4> in <module>()
----> 1 sym, arg, aux = onnx_mxnet.import_model(onnx_model_file)

/usr/local/lib/python3.7/dist-packages/mxnet/contrib/onnx/onnx2mx/import_model.py in import_model(model_file)
     57     # loads model file and returns ONNX protobuf object
     58     model_proto = onnx.load_model(model_file)
---> 59     model_opset_version = max([x.version for x in model_proto.opset_import])
     60     sym, arg_params, aux_params = graph.from_onnx(model_proto.graph, opset_version=model_opset_version)
     61     return sym, arg_params, aux_params

ValueError: max() arg is an empty sequence

To Reproduce
code to reproduce
from PIL import Image
import numpy as np
import mxnet as mx
import mxnet.contrib.onnx as onnx_mxnet
from mxnet.test_utils import download
from matplotlib.pyplot import imshow
img_url = 'https://s3.amazonaws.com/onnx-mxnet/examples/super_res_input.jpg'
download(img_url, 'super_res_input.jpg')
model_url = 'https://s3.amazonaws.com/onnx-mxnet/examples/super_resolution.onnx'
onnx_model_file = download(model_url, 'super_resolution.onnx')
sym, arg, aux = onnx_mxnet.import_model(onnx_model_file)

You can also access the reproducible script online
https://colab.research.google.com/drive/10FuegzQA3iDusWSw4ofCMIi4tOLxg0Dd?usp=sharing
Can you help fix this issue?

super_resolution.onnx has no opset because it is too old.
import onnx
from mxnet.contrib.onnx.onnx2mx.import_onnx import GraphProto

graph = GraphProto()
model_proto = onnx.load_model('super_resolution.onnx')
sym, arg, aux = graph.from_onnx(model_proto.graph, opset_version=10)

10 is dummy number.

Hi dai-ichiro,
Thanks for your suggestion, it works!
I am wondering if the developer can nicely update the tutorial page: https://mxnet.apache.org/versions/1.6/api/python/docs/tutorials/packages/onnx/super_resolution.html
so people new to mxnet like me may not be confused.
thanks a lot!


The specified module could not be found error on Windows

Many of our Windows users are getting the following error when initialising our Electron app which includes this library:
The specified module could not be found.
<EMAIL_ADDRESS>
Note that we are using Electron Forge and have set in forge.config.js:
module.exports = {
  packagerConfig: {
    asar: {
      unpack: '*.node'
    }
}

Which works perfectly fine for other native libraries like serialport.
I have tried installing the same application on our own Windows 10 and Windows 11 machines and I can confirm:

The file exists
The module is loaded
I can connect to Ngrok

What could be causing this?
Does the MSVC runtime need to be installed on the target computer? I can't see any like that in the documentation but I'm at a loss as to what else could be causing this problem.
Edit: I am using version 1.2.0

I have tracked the issue down on a clean Windows install. The problem was indeed that the Microsoft Visual C++ Redistributable is not installed.
Our workaround for now is bundling vcruntime140.dll into the application in the same folder as ngrok.win32-x64-msvc.node.
I think this should be, at the very least, mentioned in the installation instructions. Ideally this library would bundle the DLL file for machines where MSVC is not installed.

I've opened an issue to update our README with this information. I don't think we would want to bundle this in the SDK since it would not be relevant for non-Windows users.

There is a subpackage specifically for each architecture/platform pair and I think it would make a lot of sense to bundle the DLL in the Windows MSVC one.

I have the same problem with an Electron app. In my case, I'm building a Windows APPX for the Microsoft Store, and the certification failed. I think it is impossible to install the MSVC runtime on Windows apps. Is there any solution to this problem? Should I create a new issue?
All the best

We have decided to bundle the MSVC DLL in our app separately and that seems to work for users that don't have it installed.

@chetbox Please, can you help me how to bundle the MSVC DLL?

We have a copy of the DLL checked into the repo. During the build the DLL is copied into the node_modules/@ngrok/ngrok-win32-x64-msvc folder. This is the same folder as the `.node' native library which will look here first for DLLs when it loads.
Our solution use an Electron Forge plugin that looks like this:
// NgrokMsvcWorkaroundPlugin.js
class NgrokMsvcWorkaroundPlugin extends PluginBase {
  name = 'ngrok-msvc-workaround';
  getHooks() {
    return {
      async prePackage(_forgeConfig, platform, arch) {
        // Bundle MSVC runtime for Windows builds in case it is not installed on the target machine
        if (platform === 'win32') {
          await fs.promises.cp(
            'tools/windows-dlls/vcruntime140.dll',
<EMAIL_ADDRESS>          );
        }
      },
    };
  }
}

module.exports = NgrokNativeModulesWorkaroundPlugin;

Then be sure to import it and include it in the plugins section of your Forge config.

Are you copying only the vcruntime140.dll file?

Are you copying only the vcruntime140.dll file?

For our specific use case we're copying all the node_modules/@ngrok files as well but we have quite a complex build system. Your build system should already be including the @ngrok/* dependencies. This DLL is included in addition to that.

Thank you 😊


Add ability to use go-getter for fetching remote manifests directory as chart

This, in combination with #1172, allows you to use go-getter-supported URL for K8s manifests on chart, so that Helmfile automatically fetches it and then turning it into a temporary local chart, which is then installed by Helmfile as similar as standard Helm charts.
An example usecase of this is to install cert-manager CRDs which is distributed separately from the chart:
releases:
- name: cert-manager-crds
  chart: git::http://github.com/jetstack/cert-manager.git@deploy/crds?ref=v0.15.2

I'm adding this based on discussion with @lukasmrtvy. He was trying to install cert-manager and prometheus-opreator with Helmfile, and this combined with #1373 should do the job. Thanks for the input!

@mumoshu you're on a roll! this is awesome and fixes a big painpoint for us.

@mumoshu
It will probably not work for cert-manager:
https://github.com/jetstack/cert-manager/blob/master/deploy/crds/crd-challenges.yaml#L6, due to internal templating..
Here is my workaround:
  hooks:
  - events: ["presync"]
    command: "/bin/sh"
    showlogs: true
    args: ["-c", "kubectl get --request-timeout='5m' -f https://github.com/jetstack/cert-manager/releases/download/{{`{{ .Release.Version }}`}}/cert-manager.crds.yaml || kubectl apply --request-timeout='5m' --validate=false -f https://github.com/jetstack/cert-manager/releases/download/{{`{{ .Release.Version }}`}}/cert-manager.crds.yaml"]
  - events: ["postuninstall"]
    command: "/bin/sh"
    showlogs: true
    args: ["-c","kubectl delete --request-timeout='5m' --ignore-not-found -f https://github.com/jetstack/cert-manager/releases/download/{{`{{ .Release.Version }}`}}/cert-manager.crds.yaml"]

cavetas: https://cert-manager.io/docs/installation/upgrading/upgrading-0.15-0.16/#issue-with-older-versions-of-kubectl
Isnt it possible to use something like:
releases:
- name: cert-manager-crds
  chart: file::https://github.com/jetstack/cert-manager/releases/download/v0.16.1/cert-manager.crds.yaml
  forceGoGetter: true

?


Automated cherry pick of #3213: fix: aliyun bucket sync cancel local limit

Cherry pick of #3213 on release/2.12.
#3213: fix: aliyun bucket sync cancel local limit

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@e6e7fdb). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #3215   +/-   ##
==============================================
  Coverage                ?   7.13%
==============================================
  Files                   ?     478
  Lines                   ?   77439
  Branches                ?       0
==============================================
  Hits                    ?    5524
  Misses                  ?   71452
  Partials                ?     463

Flag
Coverage Δ

#aFlag
7.13% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudprovider/objectstore.go
3.18% <ø> (ø)

pkg/compute/models/buckets.go
1.35% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e7fdb...61d5829. Read the comment docs.


Assistance with rojopolis/spellcheck-github-actions ?

Hello
I am the current maintainer of the spellcheck GitHub action I am sunsetting version 0.24.0 as by the proposed sunset policy. This version is mentioned in your code, but it has been commented out.
Please let me know if you need assistance with the action and I will see if I can help.
jonasbn

Thanks @jonasbn, I would love to have this action run as part of my CI. I started integrating to catch typos both in code and documentation, however gave up (for some reason I can't remember :sweat_smile:)
I am open to PR that would help configuring this action.

Thanks @jonasbn for implementing this.

No problem, I learned something along the way.
BTW, I have created (and updated) PRs in the following repositories:

https://github.com/SwiftyLab/swift-contexts
https://github.com/SwiftyLab/DynamicCodableKit
https://github.com/SwiftyLab/ValidatableKit
https://github.com/SwiftyLab/AsyncObjects


@rend for add

From<EMAIL_ADDRESS>on September 28, 2012 04:11:06
Right now we're missing a mechanism to identify how new material was added (sewn in, glued, overwritten, etc.). We should think about adding this.
Original issue: http://code.google.com/p/music-encoding/issues/detail?id=123

From<EMAIL_ADDRESS>on November 05, 2012 14:09:32
I don't object to adding an attribute which records how the addition was made, but I don't like calling it "rend".  How about "method" or "technique"?


NodeExporter: Added ZFS toggle (defaults to off), fixes #1930

Fixes #1930
When ZFS is disabled (= default) the following log is silenced:
..  msg="collector failed" name=zfs duration_seconds=1.4879e-05 err="couldn't get sysctl: no such file or directory"

This change also fixes toggling collectors that are enabled by default (see https://github.com/prometheus/node_exporter):
cpu, exec, filesystem, loadavg, meminfo, netdev, time
Not fixed:

"interrupts" collector is implemented for OpenBSD not FreeBSD. It cannot be toggled unless node_exporter implements it.
I've not checked if ZFS collector is generally broken. Since the Telegraf plugin has a ZFS toggle, I did not remove ZFS completely.

Merged, thanks!


display error with @RequestParam(value = "order",required = false,defaultValue = "-crtdate")LinkedList order

Please take the time to search the repository, if your question has already been asked or answered.

What version of the library are you using?
2.7.0
What kind of issue is this?
Bug report.

using spring @requestrarm as title written ,but display wrong.

The execute button will be invalid and the order param can use.
I have tried many times and found the problem is the default value; if don't provide the default value for list there will be no problem. So it is a bug or I used wrong default value?
api-docs json can be see follow
{ "name": "order", "in": "query", "description": "order", "required": false, "type": "array", "items": { "type": "string" }, "collectionFormat": "multi", "default": "-crtdate" }

I have known the main problem. For type of array, the format should be:
{
     "name": "order",
     "in": "query",
      "description": "order",
       "required": false,
       "type": "array",
       "items": {
                     "type": "string"
                       "default": "-crtdate"
                     },
        "collectionFormat": "multi",
 }

but spring fox generate default value ad fllows:
{
     "name": "order",
     "in": "query",
      "description": "order",
       "required": false,
       "type": "array",
       "items": {
                     "type": "string"
                     },
        "collectionFormat": "multi",
         "default": "-crtdate"
 }

@dilipkrish

@ysjiang4869 my guess is the its a bug with swagger-ui. Looks like you're using the new swagger-ui with the swagger 2.0 format description

@dilipkrish I am using the swagger ui version 2.2.5. It supports swagger 2.0 format description. I have just tried springfox-swagger-ui and there is no problem. Maybe I should using the old version of swagger ui, thanks

I think it doesn't support  swagger-ui with tag 3.0.0 . Will it support in the future? The new ui is more beautiful. Thans for reply and this perfect project

@ysjiang4869 thank you! yes there is a plan to support it in the next release.


Wrong order of comparison in mousePressEvent

https://github.com/nicktrandafil/tags/blob/ca30ebcfb350cb74c4b3e70955d43ad7b9d6f983/src/tags_edit.cpp#L305
should be
while (it != end(impl->tags) && it->rect.top() == row) {

or we could access out of bounds, as we are incrementing the iterator

Fixed


wasm: crashes when removing ":status" header in the response.

Currently Envoy does not limit which headers can be modified from Wasm plugins, so if a plugin removes, for example, :status header from the response headers, then Envoy crashes. Ideally, we should verify the final headers in the Wasm plugin in Envoy. In any way, Envoy should not crash even when the processed headers from filters are invalid in terms of the "contents".
This is a potential security risk when we start running untrusted Wasm binaries. I think this might not be a Wasm specific issue, but rather a generic point we can improve to make Envoy protected against a crash path.
I guess there's already a similar GH issue, but I couldn't find. Thanks!
cc @PiotrSikora  @lizan

There should be an issue for that already, but I cannot find it either.
I recall that @asraa was working on Envoy-wide guards against misbehaving filters/plugins, including removing :status header, but that was a while ago, I'm not sure what's the status of that work. Perhaps, that's the reason for the crash.

^ @asraa any comments?

Found the issue
https://github.com/envoyproxy/envoy/issues/13756

@asraa thanks!
@mathetake we should probably fix this at the Wasm level anyway, not only to avoid the crash (since that's going to be fixed in #13756), but also to notify the plugin.
The issue is that currently we return WasmResult::BadArgument in case of bad map_type value, so I'm not convinced if we should reuse the same value in case of missing :status (or :authority, :path or :scheme in case of requests), since it changes the failure modes in the SDKs... although, I could be probaly convinced that we have to do it.
The other option is to simply ignore the bad headers update and log something at the error level to notify the user.
Any thoughts?

Not stale.

not stale

https://github.com/envoyproxy/envoy/pull/16745 I reworked the Envoy-wide solution


Move to Python 3.6 for Docker

Since Python 2.x is getting deprecated as of January 2020, shouldn't we move to 3.6 for the supplied Dockerfile?

I'm always +1 for moving forward. Did you test the change?

Coverage remained the same at 81.612% when pulling 73f10b9a04f6ef8f0f608d51f0209915dc2abe0c on larsnaesbye:master into 976fa0725a896e0f4640f74144f4d6bf90588378 on voxpupuli:master.

Coverage remained the same at 81.612% when pulling 73f10b9a04f6ef8f0f608d51f0209915dc2abe0c on larsnaesbye:master into 976fa0725a896e0f4640f74144f4d6bf90588378 on voxpupuli:master.

Coverage remained the same at 81.612% when pulling 73f10b9a04f6ef8f0f608d51f0209915dc2abe0c on larsnaesbye:master into 976fa0725a896e0f4640f74144f4d6bf90588378 on voxpupuli:master.

Coverage remained the same at 81.612% when pulling 73f10b9a04f6ef8f0f608d51f0209915dc2abe0c on larsnaesbye:master into 976fa0725a896e0f4640f74144f4d6bf90588378 on voxpupuli:master.

Well, no :-D
But I saw that others use 3.6 in their puppetboard Dockerfile. I can test it out on Monday.

Tested. It doesn't seem to work any different.


Change the crd name to CertManagerConfig

change the name of certmanager Instance from certmanager.operators.ibm.com to certmanagerconfig.operators.ibm.com
this pr is blocked by: https://github.com/IBM/ibm-cert-manager-operator/pull/320,
In order to support to support generating cr at runtime, this pr still needs some additional work after the previous pr gets merged.

looks good so far
lyc@IBM-PF33CSF5:~/go/src$ oc get certmanagerconfig
NAME      AGE
default   2m14s
lyc@IBM-PF33CSF5:~/go/src$ oc get pod
NAME                                                              READY   STATUS      RESTARTS   AGE
50ae034f1fe06fcd3a2660796db80accf3371f0014b5d4b3188793d37els5gj   0/1     Completed   0          16m
cert-manager-cainjector-6754b8bb54-pvcpl                          1/1     Running     0          2m19s
cert-manager-controller-6fff564d56-mq949                          1/1     Running     0          2m19s
cert-manager-webhook-5b7fbc4946-222vt                             1/1     Running     0          2m18s
ibm-cert-manager-operator-76f5754449-8xpx7                        1/1     Running     0          15m
quay-io-yuchen-li1-ibm-cert-manager-operator-bundle-v4-0-0        1/1     Running     0          16m

/retest


Fix KML placemark popups not working

What is the behavior if the parent layer is not yet added - does calling add immediately cause any issues?

+1, assuming that binding the popup immediately doesn't cause performance issues.

@tjwitz I found this issue in the plugin repo that suggests that there may be an issue with calling bindPopup before the layer is added: https://github.com/shramov/leaflet-plugins/commit/6deca8dc6aead5b72810ef0ab22c2fbaf6dd5288 Looks like my change may be a no-go.


Prevent duplicate key exception when writing IP address logging to DB.

Concern: I don't know how to test this.  How can I invoke the TrackResourceContentRequestJob locally?

Closing this PR because Jesse's changes to logging have prevented the DuplicateKeyException error from appearing in studio-app-insights-alerts channel.


Any way to get debugging going in vscode?

I know you've mentioned that you can't debug currently, but I'm wondering if there's some way or another to get it working.
I'm not a C# developer by trade, but I did manage to get your branch working that complies with the latest Godot single project changes. I'd love to be able to debug it through VSCode with a launch.json, even if it required some effort on my part.

Hi! I'm sure there is a way to get it working. The main problem is the tests run in a different process than the editor and I'm just not sure how to connect the two.
I'd be willing to accept any reasonable PRs and do the release and version bumps.

Listing here so we can gradually find ways to do that using GodotXUnit
https://marketplace.visualstudio.com/items?itemName=cyphersignal.external-app-debug
https://devblogs.microsoft.com/visualstudio/debugging-external-sources-with-visual-studio/
https://stackoverflow.com/questions/12636966/debugging-a-library-of-an-external-program-visual-studio-2010

@rexfleischer  Still learning what is required.   Is there a way for GodotXUnit test thread to start by an external application e.g. Visual Studio 2022?  So we only have one thread. Perhaps we could use the Godot AutoLoad to specify a config how to lunch GodotXunit when Godot is lunched by Visual Studio 2022.
What do you think???

@definitelyokay
We now have working Godot4 port


Subutai Console - Bazaar?

When reviewing documentation about the Subutai Console, I got back to a point already discussed elsewhere: it's somehow confusing to have two different Bazaars - one in the Hub and the other on Subutai Console. Someone suggested changing the Console one to "Plugins" or "Extensions". Does that make sense?

Yes in the next release the naming will be changed

Fixed on master.


Redesign gym website

Title and Issue number

Close #<issue_no>

Checklist:

[] I have mentioned the issue number in my Pull Request.
[] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

I have pushes the changes @pranjay-poddar please check it.

Make new PR request @pranjay-poddar please check it


Validation checks source, not output

The documentation on validation says spec-prod builds the doc, then validates the result. However, in some test runs with validation included we see on line 400 that the file that is built to index.html.built.html, but on line 542 it validates index.html, the original source. The validation therefore fails since there are custom features in the source that are transformed to valid HTML during the build.
Either the tool should work as documented, or if the intent is to validate the source, update the documentation. I don't know which was the intended design choice.

It's still validating the built file, just it has been renamed to index.html ^1
Relevant code: https://github.com/w3c/spec-prod/blob/952786e0cf6d30139e585e05701ce7997758795b/src/build.ts#L143

The validation therefore fails since there are custom features in the source that are transformed to valid HTML during the build.

Looking at live/processed ReSpec document, it appears the custom ReSpec plugins aren't removing the <pref> element at index.html#L293, causing the HTML validation error.
NB: The built output can be accessed at https://github.com/w3c/core-aam/actions/runs/1467562510 (download the "spec-prod-result" in the Artifacts section).


refactor($compile): remove preAssignBindingsEnabled leftovers

Now that we don't need to support preAssignBindingsEnabled (removed in #15782), complexity introduced in $controller by #7645 can be removed.

@gkalpak I've addressed all the comments. Please have a look.

Travis's unhappiness seems to be unrelated to my changes.

I think the minor concerns in this comment chain: https://github.com/angular/angular.js/pull/16580#discussion_r191058195 should be included in some form in the commit message. In the off chance that this affects someone, it makes it easier to recap what happened.
Would this change affect people that access the controller of another directive in a directive controller? I assume the bindings are not initialized anyway, so it shouldn't make a difference.

@Narretz Ok, added it.

Would this change affect people that access the controller of another directive in a directive controller

If those people access other controllers via $element.controller(...) (or directly via .data(...)) from a controller constructor and don't use ES2015 classes, then yes. However, why would anyone do it? Nobody promised it would work. It's not a documented use case.

Well, .controller() is a documented function on the jqlite element. Now if accessing bound properties on the controller is part of the implicit API is probably a grey area. Let's merge and see what happens.


Fix usage of ALLOW_AUTODIFF_TAMC/ALLOW_AUTODIFF flags in pkg/seaice

What changes does this PR introduce?
Bug fix
What is the current behaviour?

Compile error with seaice_evp.F when ALLOW_AUTODIFF_TAMC is not defined, issue #730
some code within ifdef ALLOW_AUTODIFF_TAMC is not specific to TAF/TAMC

What is the new behaviour

fixes #730
replace many ALLOW_AUTODIFF_TAMC by ALLOW_AUTODIFF where code is not specific to TAF/TAMC

Does this PR introduce a breaking change?
no
Other information:
This is restricted to pkg/seaice, but there may be more in other places.
Suggested addition to tag-index

pkg/seaice:
o fix compile error in seaice_evp.F related to ALLOW_AUTODIFF_TAMC/ALLOW_AUTODIFF mix-up
o  replace many ALLOW_AUTODIFF_TAMC by ALLOW_AUTODIFF where code is not specific to TAF/TAMC

@mjlosch I pushed 2 commits: the first one for seaice_dynsolver.F does not do much, but since the local common block is useless when pkg/autodiff is compiled, I just remove it in this case.
I checked (with lab_sea set-up) that I can run with deltaTdyn = 2 x deltaTtherm and get the same results with and without pkg/autodiff compiled, but this test fails if I use useHB87stressCoupling=T.
So I added a stop for this case in seaice_check.F, but made also some minor adjustments there. If you are not happy with these changes you can revert them.
With this new stop the second/latest part of issue #730 is covered.
2 minor things:

In the set of updated files in this PR few files have a mix of almost 50% "I, J" (upper case) and "i, j" (lower case) and while it does not do any harm it might look better if this was consistently "i,j" within the same file. If you agree I can push these minor updates.
left from PR #574 (not related to this PR), I would like to add a copy of "eedata.mth" in tutorial_plume_on_slope/input.roughBot/ to run this test in multi-threaded test (testreport -mth).

yet another thought: I cannot recall, why the code between
      IF (
     &  DIFFERENT_MULTIPLE(SEAICE_deltaTdyn,myTime,SEAICE_deltaTtherm)
     &   ) THEN

and
#ifdef SEAICE_ALLOW_DYNAMICS
      IF ( SEAICEuseDYNAMICS ) THEN

is required if SEAUCEuseDYNAMICS=F. @jm-c Do you? I guess these two if-statements could be combined (after moving s/r seaice_get_dynforcing to before the IF ( DIFFERENT_MULTIPLE ...)`). This would make a lot of things easier, I guess.

I was going to push my upper/lower case stuff (as I wrote earlier) but now there are new changes so I guess I will wait.

@jm-c Sorry for this overlap. The last two commits are just suggestion and we can revert them, if they are going too far. I'll stop now and do the reference experiment after you are done.

@jm-c thanks for the upper/lower case cleanup. You'll have to show me the script that you use for this.
I "cleaned up" the SEAICE.h file a little. It's still not very consistent with other header files, but at now I have a few words about (almost) every declared variable. My next commit will be the change verification experiment, where I will need your help in updating the reference.

@jm-c I tested that the results of offline_exf_seaice with bf5c1bd are the same before and after f72a403, but it would be good, if you do this again (independently).

Thanks for the changes. All looks good to me. Why not change the 'I,J' in seaice_growth.F, too. Otherwise, this looks like it is ready to be merged (so that we can close the issue).
The failure to build readthedocs cannot be related to the code changes, can it?

@mjlosch I am going to also apply the upper/lower case changes to seaice_growth.F then and will push this soon.

@mjlosch Thanks. Going to merge this PR later today.

@jm-c
The bug:
Could not import extension sphinx.builders.linkcheck (exception: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2n  7 Dec 2017. See: https://github.com/urllib3/urllib3/issues/2168)
can be fixed by hard-coding the urllib version to:
urllib3==1.26.13

in the document's requirements.txt
see mine:
https://github.com/ECCO-GROUP/ECCO-v4-Python-Tutorial/blob/bd5b3a411c15dc6d0fe7d349f1d5b43c88311d22/requirements.txt

@ifenty Thanks for the tip. Oliver made a PR ( #733 ) to temporally fix this and it did work. At some point, we will revert it to use the latest once we are sure it's working properly.


entities and caption_entities does not support MessageEntity[]

The bug
the bug is described as follows in the title
Environment

package
version

puregram
2.2.0

TypeScript
4.5.3

currently generate-interfaces does support both MessageEntity[] and TelegramMessageEntity[], should work :shrug:


GLFW doesn't initialize

GLFW downloaded from: https://github.com/glfw/glfw/releases/tag/3.3.2 (WINDOWS 64)
File setup
-> GameEngine.Core.exe
-> glfw.dll (renamed from glfw3.dll in zip at /lib-vc2019)
-> glfw.lib (renamed from glfw3.lib in zip at /lib-vc2019)
-> glfwdll.lib (renamed from glfw3dll.lib in zip at /lib-vc2019)
Crash:

Right now it appears to be resolved, but there may be more trouble down the line, as the solution was to change my build format from x86 to x64

The BadImageFormat means that the native DLL and managed assembly have mismatched CPU architecture (i.e. you are building x86 assembly, but referencing native x64 libraries, or vice-versa). GLFW offers binaries for both architectures, though your managed assembly will need to be built with the matching architecture.
32-bit Binaries
64-bit Binaries
If you want to build your project for for x86, you would only need to get the native x86 DLL to make it work.
On a side note, the only binaries you need are the .dll ones, not the ones with .lib extension. The .lib files are mainly for static linking in C/C++, you only need the dynamic ones.


Subsequent runs have passed.


Extension bugged on arch linux (garuda) - 401 on every request

I'm using latest version of the soundcloud extension on Moosync v9.0.2, or else I'm not able to add soundcloud playlists (but that's another issue).
When playing a song I get this error most of the time

And less often I get this

After looking a bit I found out that's it's linked with the client_id used by the extension being invalid.
I fixed this locally by hardcoding my client_id in the code of the extension in
src/soundcloudApi.ts => fetchKey()
But it's a local fix, and I hope this can be fixed. If not would it be possible to add an optional settings field to set our own client_id properly
Thanks

Edit
I mentioned I'm using Garuda linux, but I'm also using a windows boot but the problem isn't there, so maybe there is some kind of link ?


Serial UART Pi3

Serial Port Usage and Access on RPi2
Raspberry Pi 2 supports the serial transport for communication through the PL011 UART. This is set by default in kernel debugging scenarios. An application or device driver can use the PL011 UART to send and receive data with the PL011 device driver turning off the debugger using the following command:
Is this true for the Pi3 also?
As I'm getting intermittent results trying to use the internal UART to communicate to Serial Devices connected

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a65560a2-dbc8-891d-0d19-5d8d2909d8b4
Version Independent ID: 577d8ef8-6774-02c6-0e70-e9ffdf165c0c
Content: Release Notes for Build 17672 - Windows IoT
Content Source: windows-iotcore/release-notes/Insider/17672.md
Product: windows-iot
GitHub Login: @zeeshanfurqan
Microsoft Alias: zeeshan.furqan

Might be a dup question - closing for now.


Building depedencies script issue on Xcode 7.0.1 with 4.0.0

I have never used Tesseract-OCR-iOS before.
To evaluate Tesseract out I just unzipped release 4.0.0 and installed Xcode 7.0.1 with command line tools.    Since I do not use CocoaPods I followed the README_how_to_compile_libraries and separately brought down leptonica 1.71 and tesseract 3.03 packages and unzipped them into the same 4.0.0 folder as instructed.
When at step 3 of the readme, and then running the build_dependencies script as instructed I get:
build_dependencies.sh: line 141: ./configure: No such file or directory
Is there perhaps some extra step or such not updated in the readme for Xcode 7?

pls, check the paths. it seems that you put sources in different folders, than build_dependencies.sh script expects.

The paths were correct, but the issue was in the script itself, as the path has spaces in it.  So, for example, the line:
cd $LEPTON_LIB
should be written with quotes to deal with embedded spaces:
cd "$LEPTON_LIB"
I'll have to go thru it and adapt but its building Leptonica now.

Sadly, ending up having to abandon this. The spaces in the path issue is a limitation with autoconf and wasn't worth trying to work around.   I moved this over to a file path without spaces.
While Leptonica built fine once removing the spaces in the path issue, Tesseract itself, with this 4.0.0 zip anyway, has a number of fatal errors under Xcode 7.0.1 and OSX 10.11.  The following repeats for each ARM build type (both armv7 & armv7s but only pasting in for armv7s):
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: specifed architecture type (armv7s) for file (./outdir/arm7s/libltdl.a) does not match its cputype (16777223) and cpusubtype (3) (should be cputype (12) and cpusubtype (11))
fatal error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo: archive member ./outdir/arm7s/libtesseract_all.a(argz.o) cputype (16777223) and cpusubtype (3) does not match previous archive members cputype (12) and cpusubtype (11) (all members must match)
I'm not having any issues building my own family of apps or their related libraries, so there is something amiss here.
The only deviation I had from the included readme, since I already had the Xcode 7 command line tools, was the Xcode version of libtool does not include libtoolize.  I have never needed libtoolize before, so I curled down libtool 2.4 and built it just for Tesseract to be happy and left it installed only in the Tesseract folder.  I did not install anything additional than this and what I already had from Apple with Xcode, but the above fatal errors persisted over several tries amid varying folder paths (none with spaces).
If someone has an idea on the fatal errors I'd love to try again.

Why do you need to build libs? There are lib binaries inside the repo.

Since I started working with Watch I build everything manually now to insure bitcode / slicing support is going to work if I end up needing to use it.

There is a [task about bitcode] (https://github.com/gali8/Tesseract-OCR-iOS/issues/185).
I'm merging it right now. So pls wait a bit and try it.

So the binaries are updated and merged in the task metnioned above.
Pls, refer it and get a feedback that it what you expect.
I'm closing this issue as a dublicate.


Missing protection against duplicate id's

Yet another technical issue incoming...
It is possible to create an instance of ModelObject using an id that is already in use. In that case, data in the model store will be untouched during instance creation, but will be changed when using the corresponding methods on the instance.
As an example, let's assume that id is not present in the model store before the following lines:
	Annotation annotation = new Annotation(modelStore, namespace, id, copyManager, true);
	annotation.setAnnotator("Person:annotator");
	SpdxFile file = new SpdxFile(modelStore, namespace, id, copyManager, true);
	file.setCopyrightText("copyrightText");

What happens is that the first line creates the corresponding StoredTypedItem in the model store, and the second line sets the annotator property. The third line creates a SpdxFile instance, but due to this part of the ModelObject constructor, nothing is changed in the model store. But the fourth line adds the copyrightText property, and we end up with a stored item having an inconsistent set of properties (some from Annotation, some from SpdxFile).
The only fairly quick fix I can think of is to change the semantics of the create boolean flag that is passed:

If set to true, fail if an object with the given id already exists
If set to false, fail if no object with the given id exists

Of course, this could break a bunch of existing code, depending on how it is used.
Remark: As @armintaenzertng pointed out to me, this is also the reason that some weird examples described in https://github.com/spdx/Spdx-Java-Library/pull/112#pullrequestreview-1120108891 are possible, where objects of different classes are erroneously considered equal.

Yikes.  A bit of a design flaw.  Thanks @nicoweidner for pointing this out.  This is probably a root cause of a few issues.
The change you proposed is very logical, but as you point out it is potentially breaking since the semantics.
I wonder if there may be another interface option that would preserve the existing semantics.
I was thinking of using the strict flag to force errors is the ID already exists, however, currently it can only be set after the ModelObject is created.

One thought is to add a new constructor with different semantics and deprecate the old one.  We could add a strict parameter, for example.  It would require, however, updating a lot of code.
The idea behind the strict parameter is, if it is set to true then the call will fail if the ID already exists.  Otherwise, it would behave the way it does today.  This is similar to how the library treats other checks on parameter validity.
I have mixed feeling about whether the strict approach is a good one.  @nicoweidner - let me know what you think.

@nicoweidner I came up with another (partial) solution we could implement with low risk.
If create is true and there is another ModelObject in the store with the same ID, check to see if the type of the ModelObject in the store is the same as type type of the newly created ModelObject.  We could fail if they are different types.
This would preserve the semantics of re-using an ModelObject even if create is true.  It would prevent the non-symentric equals behavior mentioned in PR 112 comments.
I'm pretty comfortable no one would intentionally create a ModelObject with a different type expecting it to reuse the properties of a previous type.
The only case this doesn't cover is if someone accidentally creates 2 ModelObjects of the same type with the same ID.

@goneall Given the current situation, I prefer your latest suggestion of failing when someone tries to create an object with the same id, but of different type. That should prevent all the bad scenarios, and is little effort.

Fixed (mostly) with PR #121


fix(): sass support

I see the problem you were talking about now. I had only tested with scss myself, good catch! Can you add a test for it as well? Should just be copy paste of the scss one with changed filenames and syntax.

Surething, added tests.

lgtm once tests pass


License (SPDX) maintenance strategy

We use two data files for license matching, generated by the script generate_tfidf.py
Depending on the update rate of SPDX  , we can see to have a GitHub Action to automate generation or, if release rate is once per year, then we can stick to a manual update. However, we should see to have a reminder to stay up-to-date.

note: spdx has new releases of their full list ~ every 6 months, however we only use the osi-approved licenses, which may not change nearly as frequently (Need to check).


Downloader Updates

Downloader restructure:
tasks:

modify dl.bootfiles tasks to support noos and microblaze
add options for downloading noos and microblaze, use filetype option

downloader:

get_gitsha edit, microblaze simpleImage dl support
add no-os file download support

others:

Add alternative convert address to tty for docker container
Add translation between by_id and node name for UART

Swtiched print to log modules through commit 1e02c41