Soft crash when opening plugins page on >=207.7

Vendetta - c585300
Discord - 207.7 (207207)
React - 18.2.0
React Native - 0.72.3-discord-21
Bytecode - 94
TypeError: Cannot read property 'on' of undefined
    at anonymous (Vendetta:1:8092)
    at commitHookEffectListMount (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:84050)
    at flushPassiveEffects (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:106387)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:102230

in ot
in Pn
in RCTView
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in Provider
in Unknown
in Unknown
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in ChatPanelNativeStackNavigator
in StaticContainer
in EnsureSingleNavigator
in SceneView
in RCTView
in Unknown
in MaybeNestedStack
in RCTView
in Unknown
in RNSScreen
in Unknown
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in InnerScreen
in AnimatedComponent(InnerScreen)
in Unknown
in Unknown
in ReanimatedScreenWrapper
in Screen
in SceneView
in Suspender
in Suspense
in Freeze
in DelayedFreeze
in RNSScreenStack
in ScreenStack
in NativeStackViewInner
in RCTView
in Unknown
in SafeAreaProviderCompat
in NativeStackView
in PreventRemoveProvider
in NavigationContent
in Unknown
in NativeStackNavigator
in Profiler
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in Unknown
in RCTView
in Unknown
in AnimatedComponent(View)
in Unknown
in RCTView
in Unknown
in Wrap
in AnimatedComponent(Wrap)
in Unknown
in GestureDetector
in LaunchPadContainer
in DCDVisualEffectViewTarget
in Profiler
in StackNavigator
in PanelsViewController
in RCTView
in Unknown
in SafeAreaPadding
in SafeAreaPaddingView
in SafeAreaWrapper
in RNCSafeAreaProvider
in SafeAreaProvider
in DCDSafeArea
in DCDSafeArea
in SafeAreaProvider
in AssistantContextProvider
in KeyCommandsView
in KeyCommandsView
in ErrorBoundary
in RNGestureHandlerRootView
in GestureHandlerRootView
in GestureWrapper
in t
in WebViewContextProvider
in EnsureSingleNavigator
in BaseNavigationContainer
in ThemeProvider
in NavigationContainerInner
in AppNavigationContainer
in AppNavigationContainerOrEmpty
in RedesignIconContextProvider
in AccessibilityPreferencesContextProvider
in RootThemeContextProvider
in RootThemeContextProvider
in ReanimatedScreenProvider
in Profiler
in AppContainer
in Profiler
in profiler(AppContainer)
in Profiler
in App
in RCTView
in Unknown
in RCTView
in Unknown
in AppContainer

I can't seem to reproduce this at all, regardless of whether Tabs V2 is enabled or not.

looks like this crashed is caused by an unproxied plugin https://vendetta.nexpid.xyz/themes-plus/

looks like this crash is caused by an unproxied plugin https://vendetta.nexpid.xyz/themes-plus/

I don't use Themes+, but I'll check plugins.

I checked out some plugins. After installing Cloudsync or PluginBrowser, the Plugins tab seems to work, but it stops working after you reload Discord.

@maisymoe Hey there, while you're here, can you check if clicking on a confirming action on a dialog/modal opens notification settings page after? For example, try installing a plugin.

@maisymoe Hey there, while you're here, can you check if clicking on a confirming action on a dialog/modal opens notification settings page after? For example, try installing a plugin.

Yeah, had this pointed out to me, I think I know why.

Update: For me it was the Experiments plugin. Not really sure why.

It crashes for me even in safe mode, what should I do?

It crashes for me even in safe mode, what should I do?

It seems that Vendetta won't load any plugins (vendetta.plugins.plugins is an empty object) at all, if it does crash

I'm getting this issue using the Xposed version also, so it isn't exclusive to rootless either, if that info helps with debugging somehow

I'm getting this issue using the Xposed version also, so it isn't exclusive to rootless either, if that info helps with debugging somehow

same here, and it happened just after a fix for new Discord versions which is fun
TypeError: Cannot read property 'on' of undefined
    at anonymous (Vendetta:1:8092)
    at commitHookEffectListMount (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:84050)
    at flushPassiveEffects (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:106387)
    at performSyncWorkOnRoot (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:96618)
    at flushSyncCallbacks (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:31447)
    at batchedUpdatesImpl (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:118995)
    at batchedUpdates (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:16921)
    at _receiveRootNodeIDEvent (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:17404)
    at receiveTouches (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:268:18326)
    at apply (native)
    at __callFunction (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:4266)
    at anonymous (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:825)
    at __guard (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:2908)
    at callFunctionReturnFlushedQueue (/discord/discord_android_rn/android/app/src/main/assets/index.android.bundle:48:796)

Vendetta - c585300
Discord - 208.0 (208200)
React - 18.2.0
React Native - 0.72.3-discord-21
Bytecode - 94
Loader - VendettaXposed
Operating System - Android 14
SDK - 34
Manufacturer - Google
Brand - google
Model - Pixel 6 Pro
Codename - raven

Can confirm this happens on stable, 207.23

Yeah, they'ce pushed the updates from unstable channels to stable channel so now the latest stable version of Discord is not supported anymore by Vendetta. We need a fix for that first to be able to get support for higher versions.
It seems like Discord is working really hard to make modded clients impossible to keep up-to-date. They've successfuly killed Aliucord and now they are working probably on killing Vendetta too.
Sadly, but it's true. Vendetta doesn't have 20+ devs who works 24/7 to successfuly defend themself from Discord update attacks and keep their project up-to-date and functional with any update Discord pushes.
It was possible before but now with new internal plans by Discord, they will probably kill that ability for Vendetta so that if Vendetta doesn't have active 24/7 20+ devs working on this project, the project will not be able to follow updates like before.
So, what you think - should we consider making an petition for getting modded clients approved (more legal) by Discord so that Discord will not kill modded clients anymore like that with each update they made.

Any fixes? :0

Using alpha channel. Currently fixed (?)

@Meganium97 Back when I thought that perhaps a specific plug-in was causing the crashes, I attempted to check my plugins one by one. To see what was causing the issue.
I gave up of course after both cloud sync and platform indicators, two completely unrelated plugins lead to the same results.
So I gotta ask, are all of your plugins working properly? No compromises? You're running everything you were running before the crashes began?

Yes, I can confirm I am running basically everything that I was running pre-207.23

I too have the issue on 208.
It hard crashes on booting discord. Clearing the cache works however it crashed the plugins saying cannot read property 'on' of undefined

Would you mind changing your release to alpha and trying that?

The issue has been fixed in the latest alpha.  210.5 Alpha to be more specific. There is a noticable delay in the app's startup and some of the plugin's functionality showing up properly (like a noticable increase in the time it takes to hide the gift button) but overall it seems to be completely fine and functional again.

Problem: Multiple accounts of issues still present on 210.5
Possible solution: Completely uninstall vendetta, then reinstall via vendetta manager
Discord could be hard trolling though

@Meganium97 I had issues initially with updating a preinstalled stable build. But I just wiped user data + cache and the problem got solved.
The only issues that still persist seem to be plugin specific. I didn't mention those as I presumed, they had to be fixed by the plugin authors not the Vendetta team.
The most apparent plugins that aren't working are things that change chat function or appearance, anything to do with hiding buttons appear buggy in appearance. Custom timestamps aren't working either. And so on.

This issue should be closed since fix is pushed to the air (public)


"Organization" page seems broken

On production, trying to load Myosin's "Organization" page results in an ungodly amount of console errors, and it doesn't load.
https://app.decentdao.org/hierarchy?dao=base:0x374D5a17D2433415C48C735A493F0523DaB99041
Is this only a problem on Base? Is it only a problem with Myosin's DAO?
Is it related to https://github.com/decentdao/decent-interface/issues/2347?
What's going on here?

@adamgall This one is fixed, right?

Yeah @DarksightKellar and I were exploring the loading issue some more. Narrowed the issues to:

Signal Abort: Caused by multiple requests or a not ready apollo client.
component re-rerendering; UseEffect dependencies

replacing the two useEffect dependency arrays with empty array and ignoring the warning. makes the useEffect only fire once and 'fixes' things. draft till I or @DarksightKellar can circle back to it. and drill into it further.
There is another fix for #2398 in that PR that I'll extract to its own PR.


K8SPS-217: Custom MySQL Router Config

CHANGE DESCRIPTION
Problem:
Currently there is no way to pass custom config for MySQL Router
Solution:
Pass the config the same way we add the custom config for MySQL.
Since the router creates a default config (/tmp/router/mysqlrouter.conf), the custom config will be passed to the router with --extra-config option. This will add all missing and override existing options from the default config.
CHECKLIST
Jira

[x] Is the Jira ticket created and referenced properly?
[x] Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
[x] Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

[ ] Are E2E tests passing?
[x] Are unit tests passing?
[x] Are linting tests passing?
[ ] Is an E2E test/test case added for the new feature/change?
[x] Are unit tests added where appropriate?

Config/Logging/Testability

[x] Are all needed new/changed options added to default YAML files?
[x] Are the manifests (crd/bundle) regenerated if needed?
[x] Did we add proper logging messages for operator actions?
[x] Did we ensure compatibility with the previous version or cluster upgrade process?
[x] Does the change support oldest and newest supported PS version?
[x] Does the change support oldest and newest supported Kubernetes version?

Test name
Status

auto-config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
failed

config
passed

gr-demand-backup
failed

one-pod
passed

gr-scaling
failed

haproxy
passed

scaling
passed

users
passed

monitoring
passed

async-ignore-annotations
passed

semi-sync
passed

gr-ignore-annotations
failed

service-per-pod
passed

sidecars
passed

limits
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
failed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/19609d91baf0b953ee6f4ad83c12384247127e3c
image: perconalab/percona-server-mysql-operator:PR-292-19609d9

Test name
Status

auto-config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

config
passed

semi-sync
passed

gr-demand-backup
failed

service-per-pod
passed

one-pod
passed

sidecars
passed

limits
passed

haproxy
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/ca28d27b35e111a1e047c1edb3584bce687e6b80
image: perconalab/percona-server-mysql-operator:PR-292-ca28d27

Test name
Status

auto-config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

config
passed

semi-sync
passed

gr-demand-backup
failed

service-per-pod
passed

one-pod
passed

sidecars
passed

limits
failed

haproxy
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 21 out of 21

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/72edf4e7f03f5c2ecc1e2277bec258fd5f95c30d
image: perconalab/percona-server-mysql-operator:PR-292-72edf4e

Test name
Status

demand-backup
passed

auto-config
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

config
passed

gr-demand-backup
passed

monitoring
failed

one-pod
passed

haproxy
passed

scaling
passed

users
passed

async-ignore-annotations
failed

gr-ignore-annotations
failed

semi-sync
passed

service-per-pod
failed

sidecars
failed

limits
failed

version-service
failed

tls-cert-manager
failed

gr-tls-cert-manager
failed

We run 21 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/9142d5449ff971c0de4ea1fccdd26d63ba41fbac
image: perconalab/percona-server-mysql-operator:PR-292-9142d54

Test name
Status

demand-backup
passed

init-deploy
passed

auto-config
passed

gr-init-deploy
passed

gr-scaling
passed

config
passed

monitoring
passed

semi-sync
passed

config-router
failed

gr-demand-backup
passed

service-per-pod
passed

sidecars
passed

limits
failed

version-service
passed

one-pod
passed

haproxy
passed

scaling
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/cf5e30406daa21983c7ff8b59693e237004fc10c
image: perconalab/percona-server-mysql-operator:PR-292-cf5e304

Test name
Status

auto-config
passed

config
passed

config-router
failed

demand-backup
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

limits
failed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

one-pod
passed

haproxy
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/cf5e30406daa21983c7ff8b59693e237004fc10c
image: perconalab/percona-server-mysql-operator:PR-292-cf5e304

Test name
Status

auto-config
passed

config
passed

config-router
passed

one-pod
passed

haproxy
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

demand-backup
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
failed

gr-ignore-annotations
passed

sidecars
passed

limits
failed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/6359bb10fb37cc0d64c56a3a60fae9bc425a7d93
image: perconalab/percona-server-mysql-operator:PR-292-6359bb1

Test name
Status

init-deploy
passed

demand-backup
passed

auto-config
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
failed

config
passed

config-router
passed

one-pod
passed

haproxy
passed

gr-demand-backup
passed

scaling
passed

users
passed

async-ignore-annotations
failed

semi-sync
passed

service-per-pod
failed

gr-ignore-annotations
passed

sidecars
passed

limits
failed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/6382bddf6a883b149e58954bdc6350b6114ab4e4
image: perconalab/percona-server-mysql-operator:PR-292-6382bdd

Test name
Status

auto-config
passed

demand-backup
passed

config
passed

gr-demand-backup
passed

init-deploy
passed

config-router
passed

scaling
passed

gr-init-deploy
passed

one-pod
passed

users
passed

gr-scaling
passed

haproxy
passed

async-ignore-annotations
passed

monitoring
passed

gr-ignore-annotations
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

limits
failed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/6382bddf6a883b149e58954bdc6350b6114ab4e4
image: perconalab/percona-server-mysql-operator:PR-292-6382bdd

Test name
Status

auto-config
passed

demand-backup
passed

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

config
passed

monitoring
passed

semi-sync
passed

gr-demand-backup
failed

service-per-pod
passed

config-router
passed

sidecars
passed

one-pod
passed

limits
passed

haproxy
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/34366291bab889ce13a87bc827d5072c3184e632
image: perconalab/percona-server-mysql-operator:PR-292-3436629

Test name
Status

init-deploy
passed

gr-init-deploy
passed

gr-scaling
passed

monitoring
passed

semi-sync
passed

service-per-pod
passed

sidecars
passed

limits
passed

version-service
passed

tls-cert-manager
passed

gr-tls-cert-manager
passed

auto-config
passed

demand-backup
passed

config
passed

gr-demand-backup
passed

config-router
passed

one-pod
passed

haproxy
passed

scaling
passed

users
passed

async-ignore-annotations
passed

gr-ignore-annotations
passed

We run 22 out of 22

commit: https://github.com/percona/percona-server-mysql-operator/pull/292/commits/34366291bab889ce13a87bc827d5072c3184e632
image: perconalab/percona-server-mysql-operator:PR-292-3436629


Conversion from loop.parallel to gpu.launch

The lowering from loop.parallel to gpu.launch currently in MLIR core doesnt work out-of-the-box for IREE.  That needs to be adapted to work for IREE use case (or have custom lowering within IREE)
This is the thread that will dictate the work here :
https://llvm.discourse.group/t/understanding-parallel-loops-to-gpu-lowering/727

Implemented by commit c5d332c3eebc109c9aca1ea90c9dcc35100ffb9a


Fix default pmin value as this was preventing notifications on the cl…

Fix default pmin value as this was preventing notifications on the client ipc
The default pmin value was set to -1 in the server object.
The min is used to delay notifications and is treated as unsigned
so -1 results in a very long delay.  This value was being used when
sending notifications via the client IPC, which essentially prevented
any client application from receiving notifications.
I have chosen "0" as the default, which results in no delay.
beware that this may result in the flooding of notifications in the
case where pmin is not configured appropriately. In my opinion
pmin/pmax should have no impact at all for the IPC, but we can
address that issue at another time.
Ref: FLOWDM-686
Signed-off-by: Chris Dewbery<EMAIL_ADDRESS>

+1


Added fs utils script (WIP)

I think this is really well written. Are there tests that have been run with this?
We've also had fs persistence issues with tests earlier, does this fix those?

I've done some tests with copying various directories from my machine, updating them, and removing them with deltree, and it all works as it should. This will not fix the persistence issues although it may make it easier for us to fix them by using the deltree command.

Ok I think this is good. I'm going to merge this so it can help Tristan clean up the tests.


Implement export report in different file formats feature still in progress

Currently working on the feature. Need more time to research

Export report feature for the 3 different formats (.pdf, .docx, .xls) has been completed and fully implemented. Only issue is format may look a little unflattering but can work on it if have the time.


Fix problem with objects with invalid repr

Description
Fix problem with serialization of "unserializable" objects (for example, logging.Logger or socket.socket). We cannot serialize it so cannot generate tests but in previous version we generated tests with string representation of these objects (<Logger x (NOSET)> or <socket.socket ... >).
In future we can use mocks at these situations.
Fixes #1822
How to test
Manual tests
See https://github.com/UnitTestBot/UTBotJava/issues/1822#issuecomment-1455758140
Expected: no one test have been generated
Self-check list
Check off the item if the statement is true. Hint: [x] is a marked item.
Please do not delete the list or its items.

[x] I've set the proper labels for my PR (at least, for category and component).
[x] PR title and description are clear and intelligible.
[x] I've added enough comments to my code, particularly in hard-to-understand areas.
[ ] The functionality I've repaired, changed or added is covered with automated tests.
[x] Manual tests have been provided optionally.
[ ] The documentation for the functionality I've been working on is up-to-date.

I think there is a problem with None.

Fixed


Custom color save/load/paint problem

Hi,

I'm having a problem to set the custom colors. All 20 boxes are filled but when I set my tracks to "set to ordered customs color" reaper paints the first 10 correctly, paint 6 black and start from the 1st color. Any clue?
Also, I can save and load the color preset but it doesn't work, saving and loading doesn't change the color boxes.
Mac osx 10.12.6
Reaper 5.965 64
SWS 2.10 and tried 2.9.8 as well, same problem

Hi in SWS there are 16 different custom colors as seen in your first screenshot (not 20).
From your screenshot it looks like SWS custom colors 11-16 are set to black, so when running "set to ordered customs color" it seems to me it's working correctly, setting tracks 1 - 16 to the current SWS custom colors (with tracks 11- 16 black), then repeating.

I see what you mean. The thing is if SWS picks the first 16 colors out of the 20 boxes (and they are all painted) there shouldn't be black painted tracks like I have on track 11 to 16. I guess these boxes are the ones I have to paint or there is another window to set up the custom colors?

I guess these boxes are the ones I have to paint
Yes, I think you have to set them initially, if that's what you mean.

I can only test on Windows currently, here it works like this (long screencapture, sorry):

Does this work for you on Mac too?

No, it's completly different on Mac. But hey, I found the problem. If I stretch the window to the right it shows the correct sequence of colors. Thanks anyway buddy!

Oh nice, you're welcome. :D
So can we close this or should it stay open because of the save / load issue?

The save and load isn't really important for me but I just tested and it still not working.


[Icon Request]: pdm.lock and pdm.toml files

Housekeeping

[X] I'm sure this issue is not a duplicate

Icon Type

[X] File Icon
[ ] Folder Icon

Icon Type

[ ] Extension
[X] Filename
[ ] Language ID

Original Icon

Icon Information
Icon for lock pdm.lock  and configuration pdm.toml file of the PDM Package manager.
More Information:
Project git repository: https://github.com/pdm-project/pdm
Logo source: https://github.com/pdm-project/pdm/blob/main/docs/docs/assets/logo.svg

Some short explanation:
PDM is a package manager for python projects.
The files have the following purpose:

pdm.tool: project-local PDM configuration
pdm.lock: dependency lock file
.pdm-python: local file which contains the path to the python interpreter your virtual environment was or will be created with


Save and load pretrained models in Tox21

This PR fixes #42

Currently we output accuracy of each task in the inference script. But as pointed out in #62, accuracy is not an appropriate metric for imbalanced datasets like Tox21. We need to change more appropriate ones.


Fix chunk sizing in messageSize tests

These tests are failing on checking the total count of messages being sent. Before, we assumed chunking wasn't happening and the message count would be 1, but there was a change to the chunk size override option in compatUtils.ts that caused this number to be 1000. Thus, the tests were actually producing 6 ops and failing the check.
I'm leaving this is as a draft because I want to do the actual fix of reducing message sizes and config options across the board. This PR in its current state is to show that the fix is not needed urgently.
AB#7883
AB#7924

https://github.com/microsoft/FluidFramework/pull/22010


Blue line on Carrington Villa level

I don't know if it was in old builds, but I just noticed that there was this graphical bug.

It has always been there. These are seams in map geometry as far as I can tell and they're unfortunately not really fixable. What is fixable though is the sun shining through them, but I'd argue that's a different issue.

This is something to experiment with, as there probably are places where this might result in decals merging into the surface they're on. I know Quake-based engines have an option to remove T-junctions as well, but that's a bit of a different issue.

I have a feeling that there aren't enough misaligned vertices in the game's levels to worry about decals, but surely pd has a way of differentiating surfaces as "level geometry" and "detail" or "decal" or something that you can skip those surfaces?


@Thatlifeofgames no u


feat: Allow to use secret with key-value pairs

BREAKING CHANGE: API to define credentials changed
Fixes #179

Is it ready for review?

I'll try to check this in actual environment still today that it works as expected. So trying to get it ready for review today.

Some issues that needs to be checked still with Golang, so might take a while to find time to focus on those.

@wchaws Now Lambda seemed to work as should, so I think this is ready to be reviewed. Also build works in Docker.

@wchaws Do you have had time to check this?

@wchaws how about this?

@wchaws Do you have had time to check this?

@Hi-Fi Sorry for the late reply. I was so busy for the last few months and didn't have time to review your PR until now.
Overall, your PR looks great except missing some unit test for main.go(I know it might be hard to test main.go, since main.go depends on SecretsManager).

@wchaws Do you have had time to check this?

@Hi-Fi Sorry for the late reply. I was so busy for the last few months and didn't have time to review your PR until now.
Overall, your PR looks great except missing some unit test for main.go(I know it might be hard to test main.go, since main.go depends on SecretsManager).

If remember correctly, I checked unit tests for that but it would require some refactoring to mock those secrets manager calls. But I can try to recheck those.

@wchaws I added testing for secretsmanager now. I didn't add mocking to existing tests that were skipped, even same approach could be used for those to mock out e.g. s3.

Hi @Hi-Fi, First, thanks for your contribution. But since this PR is blocking the sub-sequential release, I think I have to revert this commit. Besides that, I've been getting security alerts for quite some time now. Since our company mandates that these security vulnerabilities be solved, I think there are some issues with the current design. I will re-propose a new design to avoid receiving a lot of security vulnerabilities from go dependencies. The main idea is to download the skopeo cli tool directly instead of building go projects from scratch. I hope you can understand!


Unit Testing does not connect to tenant domain

Bug description
When launching a unit test with the default setup, any connection to the tenant sub-domain fails.  The documentation states:

Also, tests use localhost as the central domain. This is set in phpunit.xml's env. The reason for this is that changing the central domains config in setUp() doesn't work — the config is read before setUp() is executed to register the central routes.

However, the default config uses a domain called saas.test and not local host.
I have changed the phpUnit.xml
    <server name="APP_URL" value="http://tenant.saas.test"/>
and tenantTestCase.php
``
config(['app.url' => 'http://saas.test']);
        /** @var UrlGenerator */
        $urlGenerator = url();
        $urlGenerator->forceRootUrl('http://tenant.saas.test');

        $this->withServerVariables([
            'SERVER_NAME' => 'tenant.saas.test',
            'HTTP_HOST' => 'tenant.saas.test',
        ]);

AssertSee, AssertUrl return the correct domain (tenant.saas.test) but other operations like post, put etc fail.  it appears that the user is not being recognised.  i tried forcing the unit test with
$this->actingAs( Auth::user() );
``
but this doesn't make any difference.
Steps to reproduce
$this->get('posts')->assertSee('foo');
Expected behavior
pass
Laravel version
9.4.1
stancl/tenancy version
3.5.2

Hey!
Thanks for opening the issue. This doesn't seem to be a bug in package, seems to be related to your setup.
If you need quick support, you can visit our Discord community here: https://discord.gg/vHjEyrw
Thanks


Visual Settings from One Config Editing Visual Settings for Another Config

Fedoraware Version Date: 01.01.2023
Config used:

 https://files.catbox.moe/9wm32m.fw
		  https://files.catbox.moe/32oiom.fw
		  https://files.catbox.moe/o2brqp.fw
		  https://files.catbox.moe/owczmj.fw
		  https://files.catbox.moe/q488tn.fw

Description:

Whenever I change visual settings in one config, they automatically reproduce themselves onto other configs.
Ex: Enable World ESP in Config 1, go to Config 2 (which does not have World ESP enabled) and see that Config 2 now also has World ESP enabled.
Steps to reproduce:

I am able to consistently reproduce this error

Load any config
Make sure that configs have different visual settings enabled
Change any option in the visual tab in one config
Go to a different config
See those changes applied in the different config too

Additional context

Video: https://www.vidlii.com/watch?v=TwimABcbftR
(Yes I know the quality sucks but you can still see the checkmarks)

I have included the steps to reproduce to the best I am able to share.

either config 2 doesnt have that in the actual config or it's not loading world esp stuff properly

either config 2 doesnt have that in the actual config or it's not loading world esp stuff properly

Me mentioning World ESP was just as an example. Any option under the visual section can be used. In the video I used various ESP options for demonstration. The point is that a hypothetical Config 1 should have visual configuration XYZ and a hypothetical Config 2 should have visual configuration ABC. However, in practice, what ends up happening is that Config 2 adopts whatever options are chosen for Config 1 (in this case XYZ.) In the video the "no cheat" config doesn't have any ESP options enabled whilst the "scout" config also doesn't. When I enable any ESP options for "no cheat" those same options replicate themselves for the "scout" config (where previously it was shown that no options were enabled.)

Can't reproduce.


Update note for parameter group family in example main.tf

Description
Unfortunately unclear how to use newest aurora PostgreSQL version.
Notes have been added to example file how you can use it.
For example:
family      = "aurora-postgresql10"
that value was explored here:
aws rds describe-db-engine-versions --query "DBEngineVersions[].DBParameterGroupFamily"

Hi @dshuvar I suggest that we fix the code instead of adding a comment. I have created a PR #95:
Please let me know if you agree and close this PR.

closed by #95


Fix build error on Ubuntu 20.04 + ROS Noetic/Melodic

Proposed change
This PR fixes the following error on docker build.
rosdep install --from-paths src --ignore-src --rosdistro=${ROS_DISTRO} -y
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
cartographer: [libabsl-dev] defined as "not available" for OS version [focal]

related issue/PR:

https://github.com/cartographer-project/cartographer_ros/issues/1726
https://github.com/cartographer-project/cartographer/pull/1875

Testing and Verification
Test Configuration:

Ubuntu 20.04.4
Docker version 20.10.14, build a224086

Procedure:

docker build -t cartographer:noetic -f Dockerfile.noetic .
docker build -t cartographer:melodic -f Dockerfile.melodic .

Hi, Im not quite sure, how to solve the error. I tried "docker build -t cartographer:melodic -f Dockerfile.melodic". Any help will be appreciated. Thank you.


Fixes the error related to date

Fixes TypeError bug on serializable json.

LGTM! Thank you.

@GitBib Published to PyPI as v0.3.9.


Simplify dependencies for basic gridding

I've been reviewing some of the glmtools code to see what would be needed to bundle it in a CSPP (Community Satellite Processing Package) glmtools package. I had a couple things I was wondering about or changes I'd like to make but wanted to run them by glmtools developer(s). So far this is all about dependencies. We have experience slimming down and compiling some common python dependencies but not others and others are just kind of large so if they aren't absolutely needed it would be nice to save the size in the final bundle that is released.

matplotlib is used for what seems like polygon calculations. Is there a smaller library that could perform these operations? Can shapely do this? It depends on the GEOS lib, so I'm not sure that's a net gain on compilation complexity.
tables (pytables package) is only used in certain functions and isn't actually needed by glmtools directly from what I can tell. The biggest complication was lmatools using it in a class for reading HDF5 files. glmtools subclasses from this class and thus imports tables but never actually uses HDF5. I was able to successfully move the tables imports to various functions and got it to work; at least I think I did.
scikit-learn seems to be used only for it's KDTree implementation. I wonder if a lighter weight library like pykdtree could we used instead? I will try running some tests later today if I can and see how it compares (if the results are the same). We use pykdtree in pyresample.
The environment.yaml includes ipython as a dependency which is not strictly a dependence of glmtools. This is just an FYI, but not a request for any change.
Pyclipper is ~not~now available on conda-forge so no need to manually pip install it (not sure if you had a part in this or not).

Pyclipper is not available on conda-forge so no need to manually pip install it

Huh?

now not not

I think all of the polygon math in glmtools is handled by pyclipper, and glmtools only uses matplotlib for visualization. There is a matplotlib dependency in lmatools, but I've been meaning to fence that off for some time.

Yes, tables is not used from glmtools. If we can move things around in lmatools to fence it, I'm good with that.

even better … it is only used in one function that from an earlier development effort and is no longer used. The import has been fenced off in d328924 and so scikit-learn could be removed from environment.yml.

Yes, it was there for my convenience. If this becomes a problem down the road for packaging we can remove it.

Oh good, I'm glad to hear pyclipper is now on conda-forge. An update to the environment.yml and docs would be welcome.

More broadly, there is a lot of orphaned code and untested paths of operation (e.g., gridding directly to a lat lon grid) that hasn't been tested in a long time, and is probably by now quite slow. Some pruning could reduce the actual LOC in glmtools, perhaps quite substantially. Likewise, I've wanted to explore refactoring or even vendoring parts of lmatools to eliminate the need to install it.

Wow, all great stuff to hear. None of this is necessary to bundle glmtools in a CSPP package/tarball, but like I said if we've packaged all of them before then it is less work to make sure they compile well. I'm sure some users would like a smaller tarball too.
So if I start from the ugf-grid branch, I'll need to merge master in for the scikit fencing, right? I'll look in to the matplotlib import/dependency and make sure it isn't needed. If it is imported I can make a pull request where needed.
I'll see what I can get working. Thanks.

The ugf-newgrid branch should have that fencing from master. Both it and the isatss branch are kept sync’d through master as parallel “production” branches.

On Oct 18, 2019, at 16:40, David Hoese<EMAIL_ADDRESS>wrote:

Wow, all great stuff to hear. None of this is necessary to bundle glmtools in a CSPP package/tarball, but like I said if we've packaged all of them before then it is less work to make sure they compile well. I'm sure some users would like a smaller tarball too.
So if I start from the ugf-grid branch, I'll need to merge master in for the scikit fencing, right? I'll look in to the matplotlib import/dependency and make sure it isn't needed. If it is imported I can make a pull request where needed.
I'll see what I can get working. Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@deeplycloudy Does this sound right that matplotlib needs to be fenced off in stormdrain?
    from glmtools.grid.make_grids import grid_GLM_flashes
  File "/opt/ssec/cspp_geo_gridded_glm-v1.0.0-prealpha0/opt/conda/lib/python3.7/site-packages/glmtools/grid/make_grids.py", line 13, in <module>
    from glmtools.io.mimic_lma import read_flashes
  File "/opt/ssec/cspp_geo_gridded_glm-v1.0.0-prealpha0/opt/conda/lib/python3.7/site-packages/glmtools/io/mimic_lma.py", line 19, in <module>
    from lmatools.lasso.energy_stats import TimeSeriesPolygonLassoFilter
  File "/opt/ssec/cspp_geo_gridded_glm-v1.0.0-prealpha0/opt/conda/lib/python3.7/site-packages/lmatools/lasso/energy_stats.py", line 18, in <module>
    from stormdrain.support.matplotlib.formatters import SecDayFormatter
  File "/opt/ssec/cspp_geo_gridded_glm-v1.0.0-prealpha0/opt/conda/lib/python3.7/site-packages/stormdrain/support/matplotlib/formatters.py", line 5, in <module>
    from matplotlib.ticker import Formatter, EngFormatter
ModuleNotFoundError: No module named 'matplotlib'

Could you also explain what the different branches are for? Are they meant to stay separate or will they be merged to master in the future?

With #56 this seems to be all figured out. Any plans to merge minvaluegrids to lmatools master? I suppose it would require ugf-newgrid on glmtools to be merged with master?

@djhoese I'm waiting to merge those branches to master until the NWS-facing use of glmtools is ready to move to ugf-newgrid. I think that may happen in the next couple weeks. Having merged #56, is there any reason to keep this issue open?


Plugin does not work with individual function deploys

Description

Steps to reproduce the issue:

Install IO|, serverless-plugin-iopipe, and other depdencies correctly
Create simple hello world function
Run sls deploy
Execute function and notice works as expected, including reporting to IO|
Run sls deploy function -f myFuncName
Execute function and notice error in response and no reporting to IO|

Describe the results you received:
502 Bad Gateway
{
    "message": "Internal server error"
}

IO Pipe will not show error or record the execution.
AWS Cloudwatch Logs
Unable to import module 'iopipe_handlers/diffScreenshots-0-iopipe': Error
at Function.Module._resolveFilename (module.js:547:15)
at Function.Module._load (module.js:474:25)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)

Describe the results you expected:
When deploying a individual function, I expect the IO Pipe plugin to work the same as deploying the entire stack.
Application and library versions

{
"devDependencies": {
    "serverless": "1.27.3",
    "serverless-apigw-binary": "0.4.4",
    "serverless-apigwy-binary": "0.1.0",
    "serverless-domain-manager": "2.4.0",
    "serverless-dynamodb-local": "0.2.30",
    "serverless-offline": "^3.20.3",
    "serverless-plugin-iopipe": "1.5.2",
  },
  "dependencies": {
    "@iopipe/iopipe": "1.8.0",
  }
}

Additional information you deem important (e.g. issue happens only occasionally):
This only occurs when running sls deploy function -f myFuncName

Fixed with https://github.com/iopipe/serverless-plugin-iopipe/pull/89


Friendly Names

This isn't a bug per say but when mapping the areas to Home Assistant you have to map the Part Arm 1,2, 3 to the HA names.  is it possible to somehow have custom names? so in place of Arm_Home have it as say Bedtime?  I changed them in the texecom cloud config but need a way to change them in HA

I was wondering the same thing, did you ever find a way?
I don't really understand the arm types being honest :)
armed_away,
armed_home,
armed_night,
armed_custom_bypass,
armed_vacation


delete node/edge using icon

After deleting 4 nodes and refreshing it

It's good feature.
However, you should warn that the node is deleted from the actual database and the associated edges are deleted at the same time, rather than just disappearing from Viewe before data purging proceeds  It would be nice to use the Confirm window.


Wrong progress output on Data API sync

The synchronization log output of the Data API uses current height divided by final height to determine the synchronization status progress. This is not correct for blockchains which don't start at a zero height.
You can reproduce this for a spork of the Flow blockchain by running the Rosetta CLI according to the instructions found here:
https://github.com/optakt/flow-dps/tree/master/cmd/flow-rosetta-server
I would expect that the Rosetta CLI would keep track of how many blocks it actually has to synchronize, rather than just using the height.

merged a fix with the above PR. that should fix this.


PointCloudData to a .ply file

Added the ability to save the Point Cloud Data to a .ply file

Sorry for the late reply.
How about remove the large point cloud assets/saved/savedPCD.ply and save the point cloud into the user specific path instead of dump to the same path every time?


Documentation status

This is intended to keep track of documentation status. Feel free to point out anything that could be out of date !
Missing:

metrics
config
walkthrough

Update docstrings :

[x] review
[x] cropping_util
[x] convert_util
[ ] metrics_util
[x] inference/training
[x] plugin base
[x] model framework
[x] workers
[x] interface
[x] utilities
[x] config
[x] WNet

Update guides :

[x] walkthrough
[x] review
[x] cropping_util
[x]  convert util
[x] metrics util
[x] inference
[x] training module
[x] wnet_training
[ ] ONNX usage

Tooltips :

[x] review
[x] cropping_util
[x] convert_util
[ ] metrics_util
[x] inference
[x] training module

Images update :

[x] Training
[x] Inference : missing SegRes VAE size
[x] Review
[x] Crop : missing aniso
[x] Convert : could use more
[x] Metrics

Have a look at Myst/JupyterBook

Done :

Single layer inference
Swin model

Updated as of #50
See #43


feat: support ON TRUE

This PR just provides the general idea of supporting an ON TRUE condition. If you want to return a NULL-extended row in the case where the lateral join returns no rows, then you would use LEFT JOIN LATERAL (...) ON TRUE. You can already achieve it with the current implementation by providing the values manually but extending this library would even make it easier. What do you think?

As it's the second question to change the lateral join handling, I'll will think about it. At the moment i do believe that the crossJoinSubLateral shouldn't need any parameters at all. That's the definition of a cross-join. I'll dig into the source code the next days to look how this can be achieved.

Great, thanks! 😊 Of course, also thanks for the great library in general.

I looked at my lateral queries and found the same behavior. I'll definitely fix that, but with a different approach. I believe the method signature should be changed to be equal to crossJoinSubLateral so the $first parameter is completely optional and not using will it result in a TRUE join condition.
I will change that tomorrow evening ;)

Great, thanks! 😊


Update keplr dependencies

Update Keplr dependencies to the latest packages. Needed to fix https://github.com/cosmology-tech/chain-registry/issues/44

we use lerna to upgrade packages, so we did a new PR for this


Socket field access violation

Unreal Engine editor very often crashed with access violation because the field ReceiverSocket (or SenderSocked, i don't remember now...) was not initialized in the constructor.
The following code in the constructor helped me:
SenderSocket = nullptr;
ReceiveSocket = nullptr;

Yeah in debug builds uninitialized fields can be problematic, make a pull request and I'll merge it.

fix merged in https://github.com/getnamo/udp-ue4/pull/4


Add GPIOZero ADC converters for MCP3xxx

This MR adds support for additional ADC converters via the GPIOZero library.
Status: Still WIP since I will need to test this on my PI

Duplicate of #227
Closing this one


Add structured output for istioctl x precheck

Use Messages type to support structured output for istioctl x precheck in a way similar to istioctl analyze.
More details in #26220. Code logic has been noticeably changed and should require careful review.

@niwatorrri: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri This is a user visible feature, so we should have release notes added for this PR.

@niwatorrri: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@niwatorrri Can you rebase this please?

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test release-notes_istio

integ-pilot-multicluster-tests_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri Do you still want this?  Can you rebase this please, if so?

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test release-notes_istio

integ-pilot-multicluster-tests_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test integ-pilot-multicluster-tests_istio

integ-helm-tests_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niwatorrri: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test release-notes_istio

integ-helm-tests_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
741d3d0c727317506bd5494b81a3979e502b6b66
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Refactor default values of food properties

Makes it easier to track the default values of optional fields of the food properties.

Pull Request Test Coverage Report for Build 74

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.317%

Totals

Change from base Build 72:
0.0%

Covered Lines:
1586

Relevant Lines:
1718

💛  - Coveralls


Member pointer to local scope variable CoprimeRatioPiCalculator

After a recent commit, the CoprimeRatioPiCalculator receives a copy of an entropy source through its constructor rather than a direct reference. As a result, the member pointer to its entropy source, m_entropy_pointer, will point to local variable that falls out of scope after the constructor returns control to the caller.
To resolve: CRPC's constructor will receive a constant reference to its entropy source and create its own copy of source to store under its member pointer.
Also, note the vector memory leak in mock_run.cpp::run_mock_demo().

Resolved in commit 18fdfbb69bf2ee30ec85c7d703288bea9c7e2573.
Leak, minor as it was, addressed in e9a72d9f0846737f5f391f245a6c7594a1473381.


Is this project maintained?

I'm not sure if this package is still maintained, Do you need help?
I'm happy to integrate this into the storybook monorepo if you'd like?
There's a 3.0.0 release coming, and I'd like to make sure addons are maintained, we're willing to help where we can!
Can you join us in the storybook slack?
https://storybooks-slackin.herokuapp.com/
That way we can keep you updated on the upcoming 3.0.0 release!
❤ storybook team

@ndelangen It appears there is no active maintainer for this addon anymore. Maybe you should fork this addon and integrate it into the monorepo.

I will try and reach out to NewSpring in another way.

I will fork it in a week or so, if needed.

@ndelangen I'm SO sorry! I had notifications turned off for this!
I would love it if this was moved into the mono repo. We don't have time to maintain it. How can I help?

Can you add me as admin to this repo, I can move it over to the storybooks organisation and then merge it in! ❤

Hey @jbaxleyiii can you let me know when you're ready?

@ndelangen done!

Migrated, I will be integrating this repo in our storybook-repo soon!


Fix RuboCop offences

I've kept the commits separate for easier review, with descriptive commit messages where I had to make a decision that needs explanation.
Tried to keep the changes minimal, picking the style matching the code the most (specifically with %-literals and spaces inside brackets).
RuboCop version update is better to be done simultaneously with the other rspec-* repositories since a number of rules are changed/renamed/removed, so I decided not to do that in the scope of this pull request.

@benoittgt Thanks for the review.
Unfortunately, Style/RedundantSelf is not fixed in latest RuboCop, I temporarily updated to 0.65, it still detects where it shouldn't, and doesn't detect where it should, so I hope to re-evaluate and remove local disabling when it's fixed in RuboCop.

@JonRowe Addressed a couple more remarks.
Appreciate if you check out a few of the remaining questions that I have: [1],(https://github.com/rspec/rspec-expectations/pull/1104#discussion_r263993069), 2, 3.

@JonRowe I'm up for changing the code either way, please let me know what you think.

@pirj Sorry I'm very busy at the moment, I promise this is high on my list to re-review I very much appreciate your time taken here!

@JonRowe A friendly reminder. There are just three questions left (1, 2, 3), I'm up to change it the way you see fit.
My further plan is to:

perform fix the offences in the other RSpec repositories
update RuboCop version to the latest
extract common parts to rspec-dev's common .rubocop.yml

I'll stick to the practice I used here with the other repositories - reduce the code churn and disable the rules that would require massive codebase change.
This might take a while considering the effort to review those changes, I hope for your support in those changes.

Just a fix required to your "1" and a green build and this can be merged. Thanks so much for your patience here @pirj

@JonRowe Addressed the remaining issue. Please take another look.

I reviewed last commits. LGTM. Thanks for the hard work @pirj

@JonRowe Please take another look.

Thanks @pirj !

Thanks for accepting @JonRowe !


Fix Google serviceAccountJson

The helm template for the config.google.serviceAccountJson was not working before.
How to use:
config:
  google:
    adminEmail<EMAIL_ADDRESS>    serviceAccountJson: |
      {
        "type": "service_account",
        ...
      }

@skirsten this PR needs to be fixed, several things are missing. One thing above all, the chart version bump.
A Redis binary has also been added, for what purpose?
Besides the fact that I see it linked to #65, it might make sense to make an overall of the changes needed to authenticate via Google.

Hi @pierluigilenoci,
Yes, this PR was created in a haste. I will refactor it.

Updated the PR with the remaining fix (#69)

#69 is already merged, is this still useful?

No, I will close this. Thanks for merging all the code related to the Google Secret!


Update example.ipynb to clarify custom implementation requirements

Not confident in my formatting, nor that this is the best way to word this.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


parsec: Add version 150-94-0

Closed #13414
Portable version.

[x] I have read the Contributing Guide.

/verify

/verify

/verify

Please follow the standard order of fields in the json file, as per Contributing Guide.
Update to the latest version.

/verify

/verify


Line Chart & Coordinate Data abstraction

Now that the model for the components has been fully established, some functionality can be abstracted away from the Line Chart and the Line Coordinate Data components to ease the development of future Chart components.

Abstractions seem to be in order.


Refactored code calculation logic and optimized code

Refactored code calculation logic and optimized code...

@shulieTech Looking forward to your help me review the code，pls.Thanks


check-tls-certs and Proxies

Hello
Can this tool be used trough a proxy.
I've tried to define "classical variables" (HTTPS_PROXY, https_proxy ...) without success.
The process try to request the internal DNS, rather than going to the proxy?
export HTTPS_PROXY=my.proxy.com:8080
export https_proxy=${HTTPS_PROXY}
./check-tls-certs -days 3400 -hosts=$(pwd)/check-tls-certs.lst
2020/04/09 09:40:25 worker up!...checking ssl certs
2020/04/09 09:40:25 tld.domain.com:443: dial tcp: lookup tld.domain.com on <IP_ADDRESS>:53: no such host

@cyd01 Unfortunately I haven't used this project in five years, so I have no idea! :\


Fix Unauthenticated Redirect

Thanks @atoff. Looking at it now, I'm wondering whether the route name needs to be login rather than dashboard so it's explicit?

We can't name it login without changing the route name of the "actual" login route. Could rename to "landing" as that might make more sense>

Thanks @atoff. Looking at it now, I'm wondering whether the route name needs to be login rather than dashboard so it's explicit?

We can't name it login without changing the route name of the "actual" login route. Could rename to "landing" as that might make more sense>

Thanks @atoff. Looking at it now, I'm wondering whether the route name needs to be login rather than dashboard so it's explicit?

We can't name it login without changing the route name of the "actual" login route. Could rename to "landing" as that might make more sense>

Agree that makes sense

Thanks @atoff. Looking at it now, I'm wondering whether the route name needs to be login rather than dashboard so it's explicit?

We can't name it login without changing the route name of the "actual" login route. Could rename to "landing" as that might make more sense>

Agree that makes sense

:tada: This PR is included in version 6.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.7.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Link to unavailable website

https://www.lookyloo.eu/docs/main/lookyloo-integration.html links to https://phishing-initiative.lu/ but that page is unavailable. Not sure if there's new URL or if the paragraph is obsolete.

True, phishing initiative doesn't exists anymore, it is .fr now. I'll fix that, thank you for the notification.

Fixed -> https://github.com/Lookyloo/docs/commit/256664d3dc3efae7cf151ac02a51eb7ecaedbe60


Update Rails to 7.0.4

update devise dependency related to ActiveSupport::Dependencies deprecation

Description

Updates Rails to version 7.0.4 and Devise to 4.8.1 related to ActiveSupport::Dependencies deprecation in Rails 7
https://github.com/heartcombo/devise/pull/5357
Related Issue

#1702
Motivation and Context

--
How Has This Been Tested?

Ran bundle exec rubocop && bin/rails test locally
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Dependency update

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Awesome sauce, thanks!

I didn't catch it before, but it looks like you missed the config in the upgrading rails guides. Updating in #1708

I just saw the failing build a little while a go and was going to ask about what to about the bullet incompatibility(just realised also). Thank you for the update 🙏


More mouse over explanations

especially for MediaInfo and MediaTrace (possibly rename these to something more explicit/distinct)

@foundscapes / @verwinv can you nominate particular spots in the UI for tooltips and itemize them here. We can then gather the needed info and implement them.

Similar ticket in other repo: https://github.com/MediaArea/MediaConch/issues/98


[Kafka-ws] error message during graceful shutdown

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request

What is the current behavior?

During Graceful shutdown the following logs can be found:

2021-03-10T18:55:18.568Z -- microservice-sdk:service-state-manager -- warn: Removing 3 services...
2021-03-10T18:55:18.569Z -- microservice-sdk:service-state-manager -- warn: Removed service "kafka"
2021-03-10T18:55:18.570Z -- microservice-sdk:service-state-manager -- warn: Removed service "http"
2021-03-10T18:55:18.570Z -- microservice-sdk:service-state-manager -- warn: Removed service "redis"
2021-03-10T18:55:18.571Z -- microservice-sdk:service-state-manager -- warn: ... successfully removed all services
2021-03-10T18:55:18.571Z -- kafka-ws:redis-manager -- warn: Disconnecting from Redis...
2021-03-10T18:55:18.572Z -- kafka-ws:websocket-tarball -- debug: Closed connection.
2021-03-10T18:55:18.573Z -- kafka-ws:websocket-tarball -- debug: Code: undefined
Reason: undefined
2021-03-10T18:55:18.574Z -- microservice-sdk:consumer -- debug: Disconnecting from kafka...
2021-03-10T18:55:18.574Z -- microservice-sdk:consumer -- debug: Unsubscribing from all topics and disconnecting ...
2021-03-10T18:55:18.575Z -- microservice-sdk:commit-mngr -- debug: CommitManager finished successfully.. committing processed offsets
2021-03-10T18:55:18.576Z -- microservice-sdk:consumer -- debug: Committed processed offsets!
2021-03-10T18:55:18.577Z -- microservice-sdk:consumer -- info: Consumer disconnected. { connectionOpened:<PHONE_NUMBER>468 }
2021-03-10T18:55:18.578Z -- microservice-sdk:consumer -- debug: Successfully disconnected producer from Kafka.
2021-03-10T18:55:18.579Z -- kafka-ws:kafka-consumer -- warn: Kafka Consumer finished!
2021-03-10T18:55:18.580Z -- microservice-sdk:service-state-manager -- debug: Service "redis" is not registered, will not signalize anything
2021-03-10T18:55:19.581Z -- microservice-sdk:service-state-manager -- warn: process did not exit on its own; investigate what is keeping the event loop active
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>kafka-ws: node index.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>kafka-ws script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!

I expected don't see the error messages

Please tell us about your environment:

Version: 0.6.0 rc1
Environment:  docker-compose
Operating system: Ubuntu 18.04 on VirtualBox (Windows 10)

Test OK.
graceful shutdown
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.444Z -- kafka-ws:redis-manager -- debug: Checking if redis is health...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.447Z -- kafka-ws:redis-manager -- debug: redis is health.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.545Z -- kafka-ws:redis-expire-mgmt -- debug: Checking if redis-expire-pub is health...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.548Z -- kafka-ws:redis-expire-mgmt -- debug: redis-expire-pub is health.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.561Z -- kafka-ws:redis-expire-mgmt -- debug: Checking if redis-expire-sub is health...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.562Z -- kafka-ws:redis-expire-mgmt -- debug: redis-expire-sub is health.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:45.585Z -- kafka-ws:kafka-consumer -- debug: Kafka is health
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.593Z -- microservice-sdk:service-state-manager -- warn: Removing 5 services...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.602Z -- microservice-sdk:service-state-manager -- warn: Removed service "kafka"
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.603Z -- microservice-sdk:service-state-manager -- warn: Removed service "http"
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.603Z -- microservice-sdk:service-state-manager -- warn: Removed service "redis"
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.603Z -- microservice-sdk:service-state-manager -- warn: Removed service "redis-expire-pub"
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.616Z -- microservice-sdk:service-state-manager -- warn: Removed service "redis-expire-sub"
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.616Z -- microservice-sdk:service-state-manager -- warn: ... successfully removed all services
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.617Z -- kafka-ws:redis-manager -- warn: Disconnecting from Redis...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.632Z -- kafka-ws:redis-manager -- info: Successfully disconnected.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.656Z -- kafka-ws:redis-manager -- info: end
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.658Z -- kafka-ws:redis-expire-mgmt -- info: RedisExpireMgmt sub client successfully unsubscribe.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.659Z -- kafka-ws:redis-expire-mgmt -- info: RedisExpireMgmt sub client successfully disconnected.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.675Z -- kafka-ws:redis-expire-mgmt -- info: RedisExpireMgmt pub client successfully disconnected.
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.676Z -- app -- debug: Stopping the server from accepting new connections...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.678Z -- app -- debug: The server no longer accepts connections!
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.679Z -- kafka-ws:kafka-consumer -- info: Finishing kafka consumer ....
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.679Z -- microservice-sdk:consumer -- debug: Disconnecting from kafka...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.697Z -- microservice-sdk:consumer -- debug: Unsubscribing from all topics and disconnecting ...
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.697Z -- microservice-sdk:commit-mngr -- debug: CommitManager finished successfully.. committing processed offsets
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.706Z -- microservice-sdk:consumer -- debug: Committed processed offsets!
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.706Z -- microservice-sdk:service-state-manager -- debug: Service "redis" is not registered, will not signalize anything
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.707Z -- microservice-sdk:service-state-manager -- debug: Service "http" is not registered, will not signalize anything
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.707Z -- kafka-ws:redis-expire-mgmt -- info: pub: onEnd
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.734Z -- kafka-ws:redis-expire-mgmt -- info: sub: onEnd
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.734Z -- microservice-sdk:service-state-manager -- debug: Service "redis-expire-pub" is not registered, will not signalize anything
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:56.734Z -- microservice-sdk:service-state-manager -- debug: Service "redis-expire-sub" is not registered, will not signalize anything
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:57.541Z -- microservice-sdk:consumer -- info: Consumer disconnected. { connectionOpened:<PHONE_NUMBER>565 }
kafka-ws-c6797458f-qvmwt kafka-ws 2021-08-02T14:06:57.542Z -- microservice-sdk:consumer -- debug: Successfully disconnected producer from Kafka.
- kafka-ws-c6797458f-qvmwt

Tested in v0.7.0-rc.2


Win11-Can`t search any files that not in desktop and only English supported

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
1, Only can search files located in desktop

2, Only can use English to search something like 'Control Panel

'
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Search only searches in indexed locations. Do you see that warning that appears on your second screenshot?

You need to index your whole disks if you want PowerToys Run to find those files. Hope this helps.


test_partitioned_topic_multi_consumer_ingestion fails occasionally

Describe the bug
I ran all our tests many time over night to verify my fix, but as a side effect I collected some of other failures. This test failed in 2.4% of the runs.
running 1 test
test source::pulsar_source::pulsar_broker_tests::test_partitioned_topic_multi_consumer_ingestion ... FAILED

failures:

failures:
    source::pulsar_source::pulsar_broker_tests::test_partitioned_topic_multi_consumer_ingestion

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 149 filtered out; finished in 7.03s

thread 'source::pulsar_source::pulsar_broker_tests::test_partitioned_topic_multi_consumer_ingestion' panicked at 'assertion failed: `(left == right)`
  left: `[b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"0\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"0\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"1\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"1\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"2\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"2\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"3\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"3\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"4\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"4\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"5\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"5\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"6\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"6\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"7\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"7\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"8\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"8\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"9\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-0\"}", b"{\"body\":\"Hello, world! This is some test data.\",\"id\":\"9\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}"]`,
 right: `["{\"body\":\"Hello, world! This is some test data.\",\"id\":\"0\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"1\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"2\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"3\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"4\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"5\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"6\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"7\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"8\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}", "{\"body\":\"Hello, world! This is some test data.\",\"id\":\"9\",\"timestamp\":1674515715,\"topic\":\"test-pulsar-source--partitioned-multi-consumer--topic-veB8p-partition-1\"}"]`', quickwit-indexing/src/source/pulsar_source.rs:1150:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Assigning to myself.


Release v0.20.0

to be able to use the changes from #1372 to fix https://github.com/kata-containers/kata-containers/issues/1204

Yes please. Don't intend to pressure the maintainers or anything but it'd be nice to know when is the release planned for. So I know when we can merge a PR in zbus that can use the new release to avoid unsafe code on our side.

superseded by #1389 .


Xbox game pass, won't start up.

Just received my new Steam deck to day.
Xbox Game Pass wont start up.
After installing everything, it is only the Xbox game pass, that won't start op when I push the start button.
And I have followed the tutorial.
The steam logo comes up, and then force close.  ??
Br. Kim

Make Sure You have Microsoft Edge installed thi happened to me (i did a first run inside desktop mode then signed in first )

Thanks for the suggestion, but it still doesn't work.
I tried to start it in desktop mode, with Microsoft Edge installt.
Its trying to start but after 5 sec. It just shows the green start button again.
Never got to sign in.
I have done all the steps + experimental settings.
???
Br. Kim.

@Owendbyme1980 brother, is force compatability on? It's not supposed to be, if you installed chrome or edge in the discovery store it's a flatpak and Linux based meaning, forcing experimental proton will make the program not run. Make sure it's unchecked.

@Owendbyme1980 brother, is force compatability on? It's not supposed to be, if you installed chrome or edge in the discovery store it's a flatpak and Linux based meaning, forcing experimental proton will make the program not run. Make sure it's unchecked.

Thanks 😁
Now works like a charm.


Get Data from the Internet

URL of codelab:
https://developer.android.com/codelabs/basic-android-kotlin-compose-getting-data-internet?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-5-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-getting-data-internet#4
Specify the language of the codelab if it is not English:
In which task and step of the codelab can this issue be found?
8
Describe the problem
plugin id("org.jetbrains.kotlin.plugin.serialization") version "1.8.10" throws an exception   java.lang.IllegalArgumentException: Unable to create converter for java.util.List<com.example.marsphotos.model.MarsPhoto>
Changing to version 1.9.23 solves the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
_Android Studio version:_Android Studio Iguana | 2023.2.1 Patch 1
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

I also had the same issue and moved to 1.9.23 and it solved the issue.


[BUG] Can't use use Mockito to mock static due to PriviledgedMockMaker

Describe the bug
I'm trying to use Mockito's mockStatic to write unit tests in ml-commons plugin. The plugin depends on OpenSearch-core. Core depends on org.mockito:mockito-core:5.11.0 which should already support mockStatic.
Here is the output of error when I ran the UT.
org.opensearch.ml.engine.algorithms.remote.AwsConnectorExecutorTest > executePredict_RemoteInferenceInput_EmptyIpAddress FAILED
    org.mockito.exceptions.base.MockitoException:
    The used MockMaker SubclassByteBuddyMockMaker does not support the creation of static mocks

    Mockito's inline mock maker supports static mocks based on the Instrumentation API.
    You can simply enable this mock mode, by placing the 'mockito-inline' artifact where you are currently using 'mockito-core'.
    Note that Mockito's inline mock maker is not supported on Android.
        at app//org.opensearch.mockito.plugin.PriviledgedMockMaker.createStaticMock(PriviledgedMockMaker.java:117)
        at app//org.opensearch.ml.engine.algorithms.remote.AwsConnectorExecutorTest.setUp(AwsConnectorExecutorTest.java:99)

It's because OpenSearch core provides its own version of MockMaker through PriviledgedMockMaker.java and configured here.
The PriviledgedMockMaker's logic hasn't been touched for >3 years and obviously it doesn't include the new mockito's features.
It's very confusing when people try to write tests in all repos depending on OpenSearch by mocking static class and this is an example I found from Mockito issues: https://github.com/mockito/mockito/issues/2877#issuecomment-1797187776
Related component
Libraries
To Reproduce
Try to write a unit test by mocking static class e.g.
 MockedStatic<Credentials> credentials = Credentials.getCredentials(any());

Expected behavior
Repos depending on OpenSearch core can utilize Mockito's feature to mock static class and won't get exception.
Additional Details
Plugins
I found this issue from ml-commons plugin, but it's not limited to this plugin.

I don't really have anything helpful to add for the specific request here, but in my experience the need to mock a static method is almost always a symptom of some other problem. I would strongly encourage you to look for other alternatives, such as refactoring the code under test to be properly testable without having to replace arbitrary functions at runtime. (Sorry, I'll get off my soapbox now)

@chishui does other tests of ml-commons using MockedStatic would help you? Found one reference here.

@chishui does other tests of ml-commons using MockedStatic would help you? Found one reference here.

I'm trying to do the same, tests in the code you linked are marked as ignore and have // TODO: fix mockito error code
Actually, I'm already able to bypass PriviledgedMockMaker by defining MockMaker in ml-commons similar to here with default MockMaker in Mockito.
The problem with PriviledgedMockMaker is that it needs update, otherwise, whenever people want to use Mockstatic, they run into exception but don't know how to solve as the mock is done by OpenSearch's PriviledgedMockMaker is not obvious to everyone https://github.com/mockito/mockito/issues/2877#issuecomment-1797187776.  And people have to either not test the function properly or ignore the tests like the code

I don't really have anything helpful to add for the specific request here, but in my experience the need to mock a static method is almost always a symptom of some other problem. I would strongly encourage you to look for other alternatives, such as refactoring the code under test to be properly testable without having to replace arbitrary functions at runtime. (Sorry, I'll get off my soapbox now)

Totally agreed with you about static functions. If I'm writing a new static function, I would reconsider my choice and refactor my code. But I'm trying to add/fix tests involving existing static functions. There are static functions here and there which may lack testing and it's still beneficial if we can fix this issue and make static mock work and improve our test coverage.

Found another way to bypass: using customized MockMaker
Mockito.mockStatic(Credentials.class, new MockSettingsImpl().mockMaker("org.mockito.internal.creation.bytebuddy.InlineByteBuddyMockMaker"));

[Triage - attendees 1 2 3 4 5]
@chishui Thanks for creating this issue; however it is being closed out because this is an anti-pattern in our codebase - that hasn't yet been removed.
We would recommend that refactor the code under test not to use a static reference so this case isn't needed.

@chishui Can you refactor the code under test to make the Credentials instance injectable so that you don't need to mock that static method?


Invalid SMARTS generated by MolToSmarts

Describe the bug
Chem.MolToSmarts returns a SMARTS string which is invalid when converted back to a molecule using Chem.MolFromSmarts.
Original SMARTS: [NX3H2+0,NX4H3+;!$([N][!C]);!$([N]*~[#7,#8,#15,#16])]
RDKit SMARTS generated by Chem.MolToSmarts: [N&X3&H2&+0,N&X4&H3&+;!$(N!C);!$(N*~[#7,#8,#15,#16])]
The error is in the $(N!C) part. If I change back to $([N][!C]) the SMARTS become valid.
I have seen this bug with multiple different SMARTS strings, and all seem to involve a removal of square brackets around a !C (or other atoms).
To Reproduce
smarts = [NX3H2+0,NX4H3+;!$([N][!C]);!$([N]*~[#7,#8,#15,#16])]
mol = Chem.MolFromSmarts(smarts)
rdsmarts = Chem.MolToSmarts(mol)
mol2 = Chem.MolFromSmarts(rdsmarts)  # mol2 is None

Expected behavior
The SMARTS returned by Chem.MolToSmarts should be valid.
Configuration (please complete the following information):

RDKit version: 2021.09.4
OS: Ubuntu 20.04 on WSL2 (Windows 10)
Python version: 3.9.10
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? conda-forge

confirmed. Thanks for the bug report.

And here's an even simpler simple reproducible:
In [6]: Chem.MolToSmarts(Chem.MolFromSmarts('[!C]'))
Out[6]: '!C'


Fix TOC for headlines with span

Closes: https://github.com/ipython-contrib/IPython-notebook-extensions/issues/380

Looks good for me.


Improve GUI for appointment

Change ways of displaying appointment content
Change the size of appointment section

LGTM! The UI for v1.2 is almost done!


Make updated gases file with more F-gases

Here is a list of suggestions:
CHCL3, CH2Cl2, CH3Cl, C3F8, c-C4F8, C4F10, C5F12, C6F14, C7F16, C8F18, NF3, SO2F2

And this one: 'HFC-152a'

Couple more: 'HFC-236fa', 'HFC-365mfc'


fix: custom placement not getting applied to CephCluster

Signed-off-by: Ashish Ranjan<EMAIL_ADDRESS>This commit fixes custom placement provided in storageCluster not getting applied to cephCluster.

I don't think we want this. Any placement configuration should override the default, not append to it. If the admin wants to keep the default behavior, they should specify it explicitly as well.

cool done

/retest


Add aurutils logo to repository

It used to be hosted on ptpb, which has been defunct for a while.

Yay! It's now nice again to look at aurutils. :blush:


How to by-passing the aspect of using special fonts?

This is not really a bug, but rather a question for my own situation. Sorry to bother you.
In my office environment of Windows 7, I don't have administrator privileges, thus I can't install special ttf fonts. Thus the display aspect of your excellent package is not usable, causing very poor display with not legible icons.
So I'd like to seek your advice on how I can disable or by-pass the display functionalities requiring special fonts.
Thanks!

I set all the unicode points that reference the ttf fonts in the display layer's package.el. So either specify points that don't require a ttf font or disable them entirely within that file, and that should be sufficient.

Thanks for the advice.
On Wed, Sep 12, 2018, 5:12 PM Eric Kaschalk<EMAIL_ADDRESS>wrote:

Closed #15 https://github.com/ekaschalk/.spacemacs.d/issues/15.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ekaschalk/.spacemacs.d/issues/15#event-1842454990,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AChCUWw3kOMZycZj280vpDZeI_N4UBEJks5uaaLogaJpZM4WE9cZ
.


Sonos platform fills logs with AttributeError references

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.50.1
Python release (python3 --version):
Python 3.5.2
Component/platform:
media-player/sonos
Description of problem:
Upon starting up HASS, the logs are filled with Sonos errors. They seem to stop content from loading in the UI.
Expected:
The exact opposite. :)
Problem-relevant configuration.yaml entries and steps to reproduce:
sonos:

Add sonos: to configuration.yaml.
Start HASS.

Traceback (if applicable):
Traceback (most recent call last):
  File "/usr/lib/python3.5/socketserver.py", line 625, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python3.5/socketserver.py", line 354, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.5/socketserver.py", line 681, in __init__
    self.handle()
  File "/usr/lib/python3.5/http/server.py", line 422, in handle
    self.handle_one_request()
  File "/usr/lib/python3.5/http/server.py", line 410, in handle_one_request
    method()
  File "/config/deps/lib/python3.5/site-packages/soco/events.py", line 237, in do_NOTIFY
    _sid_to_event_queue[sid].put(event)
  File "/usr/lib/python3.5/site-packages/homeassistant/components/media_player/sonos.py", line 238, in put
    self._sonos_device.process_sonos_event(item)
  File "/usr/lib/python3.5/site-packages/homeassistant/components/media_player/sonos.py", line 731, in process_sonos_event
    creator=next_track_metadata.creator
AttributeError: 'DidlMusicTrack' object has no attribute 'creator'
Traceback (most recent call last):
  File "/usr/lib/python3.5/socketserver.py", line 625, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python3.5/socketserver.py", line 354, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.5/socketserver.py", line 681, in __init__
    self.handle()
  File "/usr/lib/python3.5/http/server.py", line 422, in handle
    self.handle_one_request()
  File "/usr/lib/python3.5/http/server.py", line 410, in handle_one_request
    method()
  File "/config/deps/lib/python3.5/site-packages/soco/events.py", line 237, in do_NOTIFY
    _sid_to_event_queue[sid].put(event)
  File "/usr/lib/python3.5/site-packages/homeassistant/components/media_player/sonos.py", line 238, in put
    self._sonos_device.process_sonos_event(item)
  File "/usr/lib/python3.5/site-packages/homeassistant/components/media_player/sonos.py", line 731, in process_sonos_event
    creator=next_track_metadata.creator
AttributeError: 'DidlMusicTrack' object has no attribute 'creator'

Additional info:
N/A

I'm seeing this on 0.52.1.
@bachya are you only seeing this when playing from specific music services?

@jjlawren: Really hard to tell; haven't seen it pop up in a while. The two primary services we use are Spotify and Line-In (i.e., our TV).

Mine started doing this today as well (approx. every 10 seconds)..
2017-09-07 22:51:48 ERROR (MainThread) [homeassistant.components.media_player] Error while update entity from sonos in media_player Traceback (most recent call last):   File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 450, in _update_entity_states     yield from update_coro   File "/usr/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 246, in async_update_ha_state     attr = self.state_attributes or {}   File "/usr/lib/python3.6/site-packages/homeassistant/components/media_player/__init__.py", line 889, in state_attributes     in ATTR_TO_PROPERTY if getattr(self, attr) is not None   File "/usr/lib/python3.6/site-packages/homeassistant/components/media_player/__init__.py", line 889, in <dictcomp>     in ATTR_TO_PROPERTY if getattr(self, attr) is not None   File "/usr/lib/python3.6/site-packages/homeassistant/components/media_player/sonos.py", line 942, in source_list     return self._coordinator.source_list   File "/usr/lib/python3.6/site-packages/homeassistant/components/media_player/sonos.py", line 944, in source_list     model_name = self._speaker_info['model_name'] TypeError: 'NoneType' object is not subscriptable

Seems like it stopped when I dissolved the group that the sonos speakers where in.
The grouping was done in the sonos Android app in the first place..

I managed to reproduce the original AttributeError by using a local file with title but no author, created with:
lame -tt "Test title" test.wav

The error pops up repeatedly when this file is the next track to play.
The PR linked above should fix it.

I don't believe this is completely fixed yet. I am on 0.59.2 and get the following errors on startup:
Exception happened during processing of request from [URL removed]
Traceback (most recent call last):
File "/usr/lib/python3.5/socketserver.py", line 625, in process_request_thread
self.finish_request(request, client_address)
File "/usr/lib/python3.5/socketserver.py", line 354, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python3.5/socketserver.py", line 681, in init
self.handle()
File "/usr/lib/python3.5/http/server.py", line 422, in handle
self.handle_one_request()
File "/usr/lib/python3.5/http/server.py", line 410, in handle_one_request
method()
File "/home/pi/homeassistant/lib/python3.5/site-packages/soco/events.py", line 225, in do_NOTIFY
service.service_id, threading.current_thread(), timestamp)
AttributeError: 'NoneType' object has no attribute 'service_id'

@jmesberg Thanks for reporting. That is a different error and it is already being worked on in the external library (SoCo).


JSON API valid URI's fix

Purpose
Solves issue https://openscience.atlassian.net/browse/OSF-5249
Corrects bug caused by https://github.com/CenterForOpenScience/osf.io/pull/4629
Above PR raises SkipField in multiple places when URL is none.  However, this causes comments relationships link to disappear.  When going to fetch get_unread_comments, if there are 0 comments on a node, URL is none and SkipField is raised.  The comments relationships link disappears.
Changes
Small change to def _url_val.
if not url and not url ==0:  ==>  comment link is restored.

@pattisdr Can you look into the failing build?


509 after deployment on  first request

It seems to me that after a deployment to azure website with RC1, the first request always get a 500 error. Has anyone been able to confirm the same?
The error information logged was:

HTTP Error 500.19 - Internal Server Error

The requested page cannot be accessed because the related configuration data for the page is invalid.

Detailed Error Information:

Module
   IIS Web Core

Notification
   Unknown

Handler
   Not yet determined

Error Code
   0x80070002

Config Error
   Cannot read configuration file

Config File
   \\?\D:\home\site\app0\web.config

Requested URL
   http://localhost:80/

Physical Path

Logon Method
   Not yet determined

Logon User
   Not yet determined

Can you share the final web.config file that ended up on the server?

So, the error page is very much correct. There is no web.config at app0. so there might not be any direct issue with the hosting bits.
I need to figure out how a /demos/demo1 request ends up at the app for / .
The apps deployed is simple app.useFileServer() apps.
Next time the server have been idling for a bit i will try to monitor the request abit better to see if I get anything from there.

Closing per the last comment


Refactor logic

Checks are still failing as I require some of logic components depend on model. So will check again after all the refactoring commits are done after merging into development tonight

@gjlam95 I'll revert some of the changes made to the test cases.
Side note: Branches should always be passing when we merge. We can make the changes to the test cases again in a separate branch.


Sensor card configuration nomenclature inconsistent

Now that I switched to a lovelace based UI in my Home-Assistant setup I came across the following inconsistency:
In the sensor-card it's title is configured by setting the 'name' whereas for all other card types with a configurable name this is done by setting the 'name'.
See the screenshots for the current difference.

Cards have titles, entities have names.

This seems like it needs resolved. The name refers to the name of the Card and therefore should be a title variable.


Unhandled 'error' event after creating a tunnel

Hi @defunctzombie,
I receive the following error after creating the tunnel using the node.js API:
events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: connection refused: localtunnel.me:39204 (check your firewall settings)
    at Socket.<anonymous> (/usr/local/lib/node_modules/localtunnel/lib/TunnelCluster.js:47:32)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at emitErrorNT (internal/streams/destroy.js:64:8)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

The time it takes to error out is not constant. Sometimes it errors out as soon as it creates a tunnel and sometimes it takes a few minutes or even hours.
What could be the issue here?
How do I debug it?
Thank you,
Dhaval

@defunctzombie Any insights on what could be going on?
Thanks!

The localtunnel server sometimes has issues. The error message is not ideal - I might get around to making it better it in a later version.

@defunctzombie Ok. But how do I handle that issue?

Try again. It should eventually work.

@defunctzombie I want to catch that error and reconnect automatically and not do it manually everyday.

Please see other issues that have tips on how to handle retrying. Practically - localtunnel is designed for short ephemeral testing rather than long lived sessions that you keep open for a long time.


Solve the problem that LookupFileId lookup urls is empty due to lea…

What problem are we solving?
fix #3327
Solve the problem that LookupFileId lookup urls is empty due to leader switching
How are we solving the problem?
The vidMap structure is modified to a linked list structure (the length is limited to 5). When the vidMap is reset, the current vidMap is added to the new vidMap as a cache node. When the query locations is empty, the cache node is searched to avoid problems when the master switches leaders.
Checks

[x] I have added unit tests if possible.
[ ] I will add related wiki document changes and link to this PR after merging.

In order to avoid the vidmap cache being empty due to the failure of the master reconnection immediately after the successful reconnection, I set the length of the linked list to 5 by default.

Great job.
Only I did not understand what is the point of storing 5 linked list , if, as I understand it, it always refers to the current and cache?

Great job.
Only I did not understand what is the point of storing 5 linked list , if, as I understand it, it always refers to the current and cache?

If locations is empty, GetLocations will recursively execute until the cache is nil, that is, traverse the linked list

Great job.
Only I did not understand what is the point of storing 5 linked list , if, as I understand it, it always refers to the current and cache?

If locations is empty, GetLocations will recursively execute until the cache is nil, that is, traverse the linked list

Got it


Delete an account from the service

As a developer
I need to delete a customer account from the service
So that I can remove customers who are no longer needed
Details and Assumptions:
The account exists before deletion.
Endpoint: DELETE /customers/{id}.
Acceptance Criteria:
Given a customer with ID exists, when I send a DELETE request to /customers/{id}, then the customer's account is deleted from the system.
Given a customer with ID does not exist, when I send a DELETE request to /customers/{id}, then I receive a 404 error response.


3.2: Is there a “secondary” objective?

If there is nothing but “primary” objectives, then you can remove the “primary” bit.

My thinking here is that the "primary objectives" are the ones worth mentioning in the plan, since there are other more trivial objectives that aren't really necessary here (e.g., to meet course requirements, to practice my skills in writing/testing software). So there are more objectives, but the main ones are the ones listed. It would feel weird to me to just say "objectives" since that implies that the list is comprehensive.

What do you think about dropping the 'primary' and adding this rationale, explaining that there are some that aren't important?

Do you think replacing "primary" with "nontrivial" is sufficient?

Sounds good to me!