Generating of enums in latest version (0.27.27)

Describe the bug
The generated file looks something like this:
export enum DownloadState {
	WAITING = 'WAITING',
	DOWNLOADING = 'DOWNLOADING',
	PROCESSING = 'PROCESSING',
	DONE = 'DONE',
	ERROR = 'ERROR'
}
export type TDownloadState = 'WAITING' | 'DOWNLOADING' | 'PROCESSING' | 'DONE' | 'ERROR';

The issue is that DownloadState is exported from the index file but TDownloadState is used in the generated code. Should we only have one or the other?

@jordanshatford is it causing issues with your usage? This was done intentionally. In general, I'd say types should be used for everything as they have better autocompletion support in IDEs and get discarded from final bundles. However, there might be times when you want an enum and loop through all possible states -> this is annoying to do with types. What's your take?

Maybe I should append enum names with Enum and drop that T prefix?

@mrlubos  My use case is this [DownloadState.DONE, DownloadState.ERROR].includes(download.status.state). Where I get an error like this:
Argument of type 'TDownloadState' is not assignable to parameter of type 'DownloadState'.
  Type '"WAITING"' is not assignable to type 'DownloadState'.

The ability to iterate over all enum values is also something I do use. With types this would be annoying (but do-able). Im just not sure if we need both the enum and union type.

@jordanshatford i'm going to assume that error is in a code you wrote, i.e. it would error even if we picked types only, correct? Maybe getting rid of TypeScript enums completely would work if we replaced them with regular JavaScript objects. That should give us both type safety and the ability to iterate over type values which seems to be the main use case for enums

@jordanshatford i'm going to assume that error is in a code you wrote, i.e. it would error even if we picked types only, correct? Maybe getting rid of TypeScript enums completely would work if we replaced them with regular JavaScript objects. That should give us both type safety and the ability to iterate over type values which seems to be the main use case for enums

Is there any issue with using enums? It would get compiled to JS objects anyways. Either that or use something like is suggested here:
https://stackoverflow.com/a/59420158
The code I have can be fixed to prevent the error. I guess the main issue is I would like both the enum and type exported for use in the generated code.

@jordanshatford Yeah, I agree with this take https://dev.to/ivanzm123/dont-use-enums-in-typescript-they-are-very-dangerous-57bh
The issue you pointed out resulted from me removing the useUnionTypes flag and trying to keep/mix both approaches from the original package. I will remove enums altogether and generate JavaScript objects or arrays under an optional flag.

@jordanshatford Yeah, I agree with this take https://dev.to/ivanzm123/dont-use-enums-in-typescript-they-are-very-dangerous-57bh
The issue you pointed out resulted from me removing the useUnionTypes flag and trying to keep/mix both approaches from the original package. I will remove enums altogether and generate JavaScript objects or arrays under an optional flag.

Sounds good to me. Could you reference this ticket when that change is released so I can update my client with it.

@jordanshatford yep!

@jordanshatford thanks for bearing with me! This has been updated in the latest release v0.27.28 🎉
I added a section on enums to README if you need to use them. I export enums in my projects too and this works for me better than the previous version.
In my projects, I use a little utility for extracting types from enums like this
export const objToEnum = <T extends Record<string, unknown>>(obj: T) =>
  Object.values(obj) as [T[keyof T]];

You might find it useful too!


Document SQL Server clustered/unclustered indexes

Need to check the relevant ticket on the Migrate side.

closing for now, if important will come back up


Update OilSource.scala

So found this bug on my retro server. It only shows up when the actual cycle sim time is less than the scheduled time. Main sim runs the cycle then increments the week. This causes the current oil prices (for contracts, etc) not be able to load (and then defaults to 70) as it's requesting "NEXT WEEK" if you check prices during the time the simulator has finished with the last week but hasn't started the next week.
Of course you could just change the order of the main sim actor so it increments first then triggers start cycle, but due to consistency concerns I did it this way.

@daprof1 Just want to see where Dairy is  🥛
The game has been getting a lot of updates and a Christmas event!
Going to work on V2 soon too!
Where's the UI update!!??


Basic Royal Render Integration ✨

Feature
This PR is adding basic Royal Render infrastructure support in OpenPype. Before full host implementation this is providing publish plugin for rr_control application to publish already rendered job directly from Royal Render. This doesn't depend on information obtained from host, but needs to do some guess work so it won't never be as precise as full host implementation.
Setup
I. - Environment variables
It needs OpenPype on artist's workstation. Path can be set with OPENPYPE_ROOT environment variable or if not set, it will try to auto-detect it in default install location on Windows. On Linux and macOS you need to set OPENPYPE_ROOT.
In RoyalRender this could be set manually in win__global.bat or lx__global.sh in RoyalRender root directory:
rem Custom OpenPype path - to build OpenPype executables
set "OPENPYPE_ROOT=E:\projects\openpype\3x\build\exe.win-amd64-3.7"

# on linux
setenv "OPENPYPE_ROOT" "/usr/local/OpenPype"

II. - rr_control job plugin
It is necessary to copy openpype/modules/default_modules/royal_render/rr_root to RoyalRender installation root - mainly m50_openpype_publish_render.py needs to go to RR_ROOT/plugins/control_job/perjob/m50__openpype_publish_render.py.
III. - Enable module in Settings
Enable RoyalRender module in Settings UI - modules/royalrender

You can set Royal Render root path there but it is not used in current state.
All done. 🥳
Usage
Run rr_control. Right+click on job you want to publish:

OpenPype should pop Select Context dialog:

Select context you want to publish to and hit OK. Next, classic publish windows should appear and publishing then continues as expected.
Details
You can publish only one job at time. Context is determined by that dialog window and passed via temporary file back to plugin. Publishing will now collect file sequences from image directory determined from Royal Render and using regexp will set subset name.
Debugging
Output from RoyalRender scripts can be seen in Application Log (Layout -> Show Application Log (Python)). For changes in plugin (m50_openpype...) rr_control application doesn't need to be restarted.

If we resolve the conflict @antirotor it can go to 3.6


Update data-loss-prevention-policies.md

@chrfox Please review the changes make edits if required. Could you do the formatting (numbering) adjustments.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@pratjain523 - please merge the commit on the copy/edit review done by JohanFreelancer9 or make the necessary changes on the PR following the suggestions made. Thank you.

I have committed 3 changes except for the one below. It should be Restrict access to content using “Anyone with the link” option.
<EMAIL_ADDRESS>Thanks,
Prateek
From: Joyce Y<EMAIL_ADDRESS>Sent: Friday, June 5, 2020 4:58 AM
To: MicrosoftDocs/microsoft-365-docs<EMAIL_ADDRESS>Cc: Prateek Jain<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/microsoft-365-docs] Update data-loss-prevention-policies.md (#2100)
@pratjain523https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpratjain523&data=02|01|pratj%40microsoft.com|353af319a1b24dedf0c408d808dee197|72f988bf86f141af91ab2d7cd011db47|0|0|637269100650444632&sdata=Zcd5HGHX25u%2B4kDii1MpV27Y%2BxH7jW1lhA%2FHwYnkdGU%3D&reserved=0 - please merge the commit on the copy/edit review done by JohanFreelancer9 or make the necessary changes on the PR following the suggestions made. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fpull%2F2100%23issuecomment-639169209&data=02|01|pratj%40microsoft.com|353af319a1b24dedf0c408d808dee197|72f988bf86f141af91ab2d7cd011db47|0|0|637269100650444632&sdata=P9hunZKOf5IfsXl72bf%2F5pTeiDH6t99k%2BgCAAg17OIc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM6JWITAYS4YMMNIRRMVYV3RVAUW7ANCNFSM4NRVAKSQ&data=02|01|pratj%40microsoft.com|353af319a1b24dedf0c408d808dee197|72f988bf86f141af91ab2d7cd011db47|0|0|637269100650454629&sdata=hSlsLGMFa6Rs9otuGzfSC6H%2Fi00MkEJuoFnIdF2n2hM%3D&reserved=0.

@chrfox - PR has been copy edited and is ready for final review.
Thank you.
cc: @kenwith


[SMALLFIX] Add javadoc for DFSIOIntegrationTest#main

Add javadoc for DFSIOIntegrationTest#main

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14183/
Test PASSed.


nixos-install doesn't ask for root password anymore

Since a while doing a stock installation (which doesn't set mutableUsers = false) doesn't ask for the root password anymore.
Probably the if [ -z "$noRootPasswd" ] && [ -x $mountPoint/var/setuid-wrappers/passwd ] && [ -t 0 ]; then check doesn't work since the latest setuid wrapper changes, as the absolute symlink resolves incorrectly in the installing host.
+ ls -lah /mnt/var/setuid-wrappers
lrwxrwxrwx 1 root root 51 Sep 21 15:41 /mnt/var/setuid-wrappers -> /run/setuid-wrapper-dirs/setuid-wrappers.zHrN5I4dUK

cc @domenkozar

806e88c1

Maybe it should be:
[ "$(chroot $mountPoint '[-x /var/setuid-wrappers/passwd ] && echo true') = true ]
or something similar. cc @obadz

Not directly related to this issue, but the password setup phase is a point of possible failure (in the case the user make a mistake in the password check).
Would it make sense to separate the password setup in a dedicated command (nixos-install --setup-root-password), or to at least to add some instructions in the documentation for what to do when the password setup failed?

Well the install command can simply be re-run.
If someone wants to make it fancy, I guess it could ask the user whether to retry if the passwd command did not exit with status 0.

Argl, this definitely needs to be fixed :-(
The idea is to find out if the closure has mutableUsers turned on or off, without invoking invoking a nix evaluation (since with --closure we may only have the output and not the nix source).
Right now I can only think of parsing the json out of grep users-groups.json$ /nix/var/nix/profiles/system/activate. That's quite ugly. Maybe a better solution would be to modify the nixos/modules/config/users-groups.nix so that it creates a /etc/static/mutable-users whose existence we can test?

The flag file approach sounds sensible to me.

Is there any reason you can't do something like this?
if [ -z "$noRootPasswd" ] && [ -x "$mountPoint/$(readlink -f $mountPoint/var/setuid-wrappers/passwd)" ] && [ -t 0 ]; then
    echo "setting root password..."
    chroot $mountPoint /var/setuid-wrappers/passwd
fi

... although, a flag file would probably be less fragile.

@cstrahan, I like your solution the best.  If someone has a chance to test & push that would be great.  I'm really tied out these days so can't do it myself.

That solution feels kind of brittle, since if anybody changes the absolute symlink to relative, it will break again.

I settled for a34ec1517fc76dca1d3aa1cd3f04a04ef4109753.

@dezgeg, thanks!


implement GC of unused inodes in OffsetStreamState after FS restart

Would you mind adding some information in the description? Just a general overview of what this doing.


OCTGN IDs?

If there's interest in adding an OCTGN deck export option (similar to thronesdb), I can go through and add in the existing IDs for the cards into the database.

I haven't had many requests for an OCTGN export, and I'm not in a hurry to add export options to the site. If there's a need for such an option, I would add the octgn IDs to the cards, but I wouldn't implement an OCTGN export feature. The OCTGN IDs would be exported with the deck contents at the API level, and we would need a thrid-party tool to convert such json data into a proper OCTGN deck.

that's a good idea -- my group can look into writing an OCTGN deck editor plugin to read the json data and convert that to an OCTGN deck.  We can probably extend such a plugin to work with thronesdb and the other deckbuilders as well, assuming the json data is exported in the same format.

Ok then. If you can submit a PR with an octgn_id value for each CardPack (or Card, as you see fit), I'll update the code to read and use it.

The decks themselves don't retain individual printings from PackCard, correct?  From a data perspective it makes sense for the IDs to go into PackCard data as each physical printing/release of a card would have its own OCTGN GUID assigned in its set definition file.
If the deck editor doesn't interpret any of the PackCard data then I'll have to think of a better way to approach this.

That's correct: the decks don't know which packs the cards come from.


refactor: resolve conflict dependency location

Summary
Related to #7635 and #7422

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

@h-a-n-a cc


New package: URL

This package focuses on three interfaces: Browser's window.location, URL and URLSearchParams. Providing a couple reactive primitives, reactive classes and additional utilities.
A detailed overview can be found in the README
The package has many possible improvements, (some noted in the readme) but I've decided to leave them for later. So that I'm able to use these primitives first and get some feedback, before extending them further.
A question:
Should this be kept as one package or split into separate location, url and url-search-params smaller packages?
I started it as a single package, and as all the primitives are related to each-other more or less, I've kept it as is. But it is possible to split them. (already are kept in separate files anyway) They would stay as dependencies when needed.

It would help if a fallback could also be given as string (we can easily detect this case and wrap in URL()).

I think having these under a URL package is fair. They are all generally related to url and packaging them as some keeps them contained. I think this is safe to merge unless you have further changes.

How do we feel about merging this in? :-)

@davedbase I was deferring the merge because I wasn't sure about the current API, it's "finished" but still requires a lot of further work on refactors and more features. Work that I lost interest in, for now ;)
I will try to merge and publish in soon. Maybe some minor adjustments. URL is a rabbit hole...


Regression in PolygonSpatialObject::IsInsideInObjectSpace

Description
Polygon spatial objects have extra horizontal lines on some vertices. It is especially apparent when converted to binary image.
Steps to Reproduce
#include <itkImage.h>
#include <itkPolygonSpatialObject.h>

using ImageType = itk::Image<unsigned char, 2>;
using PolygonType = itk::PolygonSpatialObject<2>;

int main()
{
  PolygonType::Pointer polygon = PolygonType::New();

  // bottom left triangle
  float points[][2] = {
    {0.0, 0.0},
    {0.0, 10.0},
    {10.0, 10.0},
  };

  for (auto point : points)
  {
    PolygonType::SpatialObjectPointType so_point;
    so_point.SetPositionInObjectSpace(point);
    polygon->AddPoint(so_point);
  }

  polygon->Update();

  // top right corner
  ImageType::PointType test_point;
  test_point[0] = 10.0;
  test_point[1] = 0.0;

  // outputs "1"
  std::cout << polygon->IsInsideInObjectSpace(test_point, 0, "") << std::endl;

  return 0;
}

Expected behavior
test_point shouldn't be inside the polygon.
Actual behavior
test_point is inside the polygon.
Reproducibility
100%
Versions
The regression was introduced in b83454ef2b4d2385adddab67d6378fe8c47f8800.
Environment
MacOS Mojave

Hello,
I faced the same issue. I resolved it by the following update at itkPolygonialSpatialObject.hxx
Before Update:

After Update:

I colored the contour points in the ascending order in the list.
For my local problem, the problem occurs at:

When y1 is equal to py, in the bounding box, any value of px greater than x1 returns true, hence in the bounding box it returns a straight line for the values of px greater than x value of node1.
I updated the if conditions to handle the condition y1 equal to py, rebuilt ITK and it is resolved for me.
Thanks,
Neslisah.

@neslimsah Would you please submit the code changes in a Pull request so that we may incorporate them in ITK?
Thank you, Hans


TS Server crashes once TS file is open

VSCode Version: 1.12.1
OS Version: macOS 10.12.4 (16E195)

The project is private so I can't share the code or steps to reproduce it though I'm going to provide some logs, hopefully will be enough. If you need something else please ask.
The file that I open is about 1100 lines and it's a pure typescript file that is importing some of lodash, d3 and angular v4.
As soon as I open this file TS Server crashes and nothing will work anymore! TS Server restarts but it gets stuck at binding forever, and the only way to get Code to work is to restart.
This issue started right after updating to 1.12
Here is the TS Server log file
Here is the ChromeDevTools console

So apparently the issue is with Typescript v2.3.x, it works with v2.2.x

This issue was moved to Microsoft/TypeScript#15716


Fix/simulate push box

Air resistance changes with speed and has different values at different times, and sliding friction changes with the direction of speed. Their combined force cannot be considered constant. This is a differential equation that requires an analytical solution for accurate simulation. The differential equation needs to be solved based on $m * dv/dt == F - f - kv^2$, and the first zero point is solved to determine whether the speed passes through zero within a given time, the direction of sliding friction jumps, and the magnitude of the speed after t is solved.

I haven't implemented an analytical solution yet (I need some sin and sh functions) and I need someone to help me. But I have implemented a simple iterative solution, but the accuracy should not be high.

But I am not sure whether this implementation is correct, please test this code.

Ok, it seems to be running normally now. Proof in simulate/push-box.md.


card stack transitions

Fixes #56
~This PR is currently pointing at #96, which is why I think the commit log is a little dirty (showing the 90-upgrade-apollo changes, for example). After #96 is merged lets edit this pr to point at master.~
Adds in horizontal transitions and swipe to go back functionality.
The majority of this PR is in @modules/CardStack/Transitioner.js. The difficulty in trying to achieve card-stack style transitions with react-router is that it mirrors browser history, as in there's a single history object with an array of locations that have been visited. Even when you have nested routes, everything boils up to a single history object. Something like react-navigation and more traditional react-native navigation solutions have this concept of "Navigators" that contain the routing history just for a single level of routes - nested Navigators in this paradigm each manage their own state.
With ReactRouter, we have to keep in mind of routing state and history at a global level. So Transitioner needs to consider this when deciding how to transition routes - tapping on Tabs in the TabBar, for example, shouldn't cause a CardStack animation to trigger.
In this PR, <CardStack> will only animate routing changes that deal with CardStack's direct child <Route>.
For example:
<CardStack>
  <Route tabs>
     <Route one />
     <Route two />
  </Route>
  <Route page />
</CardStack>

If you navigate from tabs one to tabs two, CardStack will not trigger in animation. But if you navigate from tabs to page, you will get an animation.
Creator

[ ] Build relevant tests if any apply
[x] Ensure there are no new warnings
[x] Upload an animated GIF showcasing the solution (if it applies)
[x] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

Warnings

:warning:

Please assign someone to merge this PR, and optionally include people who should review.

:warning:

No Changelog changes!

:warning:

:exclamation: Big PR

  Generated by :no_entry_sign: dangerJS

@burkeshartsis got this all synced up with master and ready to review

I originally had this assigned to @burkeshartsis, of which I'd still like you to look at it. But was thinking about this a little and @Lepozepo you might look at it as well / instead...I think you're more familiar with React Router then either of us, and this isn't so much visually concerned as it is structuring how we're going to do routing. Would love your thoughts on this.
This PR is paired along with #111

@Lepozepo here's the only warning i'm seeing, and frankly, I'm not quite sure how to fix:

In the audio player, I think it's this:

Yeah, I noticed that too but figured that component is probably going to disappear anyway. I was talking about web not native though. There's like 4 or 5 new warnings there. Do you see them?

@Lepozepo got it. I fixed most of the warnings. There's one that I'm still unsure why it's triggering:

The propTypes:

It's being rendered here:

I don't see how pop is being set to a string containing "false". Do you?


problems running spyder in Ubuntu 16.04 Python 2.7.x

Description of your problem
I am not able to run spyder.  I have two versions of Python: one through pip and another through anaconda.  This problem I am having in the version through the pip command.  Updating spyder to 3.1.3 gave me the following errors.  Please help

File "/usr/local/lib/python2.7/dist-packages/spyder/app/mainwindow.py", line 2989, in main
mainwindow = run_spyder(app, options, args)
File "/usr/local/lib/python2.7/dist-packages/spyder/app/mainwindow.py", line 2893, in run_spyder
main.setup()
File "/usr/local/lib/python2.7/dist-packages/spyder/app/mainwindow.py", line 872, in setup
from spyder.plugins.ipythonconsole import IPythonConsole
File "/usr/local/lib/python2.7/dist-packages/spyder/plugins/ipythonconsole.py", line 60, in
from spyder.widgets.ipythonconsole import ClientWidget
File "/usr/local/lib/python2.7/dist-packages/spyder/widgets/ipythonconsole/init.py", line 12, in
from .debugging import DebuggingWidget
File "/usr/local/lib/python2.7/dist-packages/spyder/widgets/ipythonconsole/debugging.py", line 16, in
from qtconsole.rich_jupyter_widget import RichJupyterWidget
File "/usr/local/lib/python2.7/dist-packages/qtconsole/rich_jupyter_widget.py", line 14, in
from .jupyter_widget import JupyterWidget
File "/usr/local/lib/python2.7/dist-packages/qtconsole/jupyter_widget.py", line 19, in
from IPython.lib.lexers import IPythonLexer, IPython3Lexer
ImportError: No module named  lexers

What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
Versions and main components

Spyder Version:
Python Version:
Qt Version:
PyQt Version:
Operating system:

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:

I think you need to update IPython too to sole this problem.

Hi Carlos,
I am going nuts with maintaining two sets of Python: one through pip and
another through Anaconda.  Per your suggestion a few weeks back I moved to
Anaconda because a 3d visualization software Mayavi was not working through
pip, probably due to inconsistent dependencies.  However, although Anaconda
solved the Mayavi problem, but I encountered a different problem with boost
bindings.
I installed openni package, and I now I am facing Boost Python argument
error.  Is there anything you can do to resolve this issue with Anaconda.
Anaconda is a little slow to reply compared to you.
Btw, I just did pip install --upgrade ipython[all].  And I still stuck with
the same Spyder error
Srini
On Thu, Mar 30, 2017 at 4:15 PM, Carlos Cordoba<EMAIL_ADDRESS>wrote:

I think you need to update IPython too to sole this problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spyder-ide/spyder/issues/4310#issuecomment-290531663,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKwmgyNjEhfFl7HeVN-FCYoeFutXZ5Kjks5rrA1wgaJpZM4Mu3GB
.

I don't know about openni, sorry.
IPython.lib.lexers is certainly there in IPython 5:
https://github.com/ipython/ipython/blob/5.x/IPython/lib/lexers.py
so I don't know what's happening :-/

Sorry, but there's nothing we can do about this because it's not a Spyder bug.
So I'm closing this one.


Expected an assignment or function call

My JS linter complains on store.client
store.on('connected', function() {
  store.client; // The underlying MongoClient object from the MongoDB driver
});

Actually, since I'm new to connect-mongodb-session, I'm not sure if this is a real issue, or .. ?

The store.client; bit is just an example, you don't really need that line or even store.on('connected') in general. Will add a comment about that in the docs.

Oh I understand. I would suggest to modify it to
store.on('connected', function() {
  console.log(store.client); // The underlying MongoClient object from the MongoDB driver
});

I just removed it. That's really something that belongs in API docs, not a first example, because it isn't necessary to get up and running with this module.


Vue 3 wrapper

Feature description
Create an Embla Carousel Vue wrapper - A component that allows Vue users to consume Embla Carousel.
Release
Released with v7.0.0-rc05. Documentation will be released with stable v7 but until then you can check out usage instructions below:
Vue wrapper
Start by installing the Embla Carousel npm package and add it to your dependencies.
npm install embla-carousel-vue --save

The component structure
Embla Carousel provides the handy emblaCarouselVue function for seamless integration with Vue. A minimal setup requires an overflow wrapper and a scroll container. Start by adding the following structure to your carousel:
<template>

Slide 1

Slide 2

Slide 3

</template>

Styling the carousel
The emblaCarouselVue function gives us an emblaNode to attach to our wrapping element with the classname embla, which is needed to cover the scroll overflow. The element with the container classname is the scroll body that scrolls the slides. Continue by adding the following CSS to these elements:

Accessing the carousel API
The emblaCarouselVue function takes the Embla Carousel options as the first argument. Additionally, you can access the API with an onMounted like demonstrated below:
<template>

Slide 1

Slide 2

Slide 3

</template>

Adding plugins
The emblaCarouselVue function also accepts plugins as the second argument. Note that plugins need to be passed in an array like so:
<template>

Slide 1

Slide 2

Slide 3

</template>

Congratulations! You just created your first Embla Carousel component.

Released with v7.

Is it working with Vue 2 + @nuxtjs/composition-api ?

@sinneren thank you for your question. It only works with Vue 3.

@davidjerleke I'm not sure if I do something wrong and maybe it's a dumb question, but how can I access the clickAllowed method?

@davidjerleke thank you for your response. Here is a link to the sandbox. I'm not sure if the vue setup syntax is a problem or maybe the only problem.

@rojadesign I think the setup is not working as expected because importing onMounted shouldn't cause any errors. Would you mind trying the following Vue3 + TypeScript template instead?

@davidjerleke thank you for your time. Here is the Vue3 + TypeScript template used - not really working but the same error I have locally also appears there:
Property 'clickAllowed' does not exist on type 'EmblaCarouselType | HTMLElement'.
Property 'clickAllowed' does not exist on type 'HTMLElement'.ts(2339)

@rojadesign yes, this is clearly a TypeScript bug and the typings are wrong. The type for emblaApi should be EmblaCarouselType | null. I'll have to look into this when possible. Feel free to propose a solution if you want. The Vue wrapper code is here.

Hello,
Can this work with the api option ? I can't.

@spoitler I don’t understand the question. Would you mind clarifying what you mean?

is it necessary to use the setup() function to initialize it ?

@spoitler yes I think so.


Adding Youtube --card

#25 Created a Youtube card

Added a card
did css
made it responsive

Hey will you add label:"HACTOBERFEST-ACCEPTED"


Add support for setting SM2 id field

Fixing #6534

[x] documentation is added or updated
[x] tests are added or updated

This is a contribution from Ribose Inc (@riboseinc)

Review comments should be addressed. There is also a proper test now.

Been away...just trying to catch up. I'll try and take a look at this on Monday.

Review comments addressed

Hoping this can be merged soon for #6837 and certificate generation. Thanks!

My reading is that the UID is fairly critical for SM2, so I guess this is a "bug" that it wasn't there before, and hence should be in 1.1.1.

I agree this should be considered a bug. On the other hand, we still don’t have certificate generation so the functionality of SM2 isn’t yet complete.

On the other hand, we still don’t have certificate generation so the functionality of SM2 isn’t yet complete.

Right...but SM2 is useful by itself without certificates. So certificate support seems like a new feature.

Agreed! :+1

Review comments addressed (modulo the non-optimal API for setting the UID, but it's not clear how else to make this work).

I'm not quite clear what is target here. Last said words were about personalization data being a feature, yet "post 1.1.1" milestone was changed to "1.1.1"...

Last said words were about personalization data being a feature, yet "post 1.1.1" milestone was changed to "1.1.1"...

No, we agreed above that UID is required for SM2. Hence the 1.1.1 milestone. The discussion above was that certificate support was a feature (which also depends on the UID support).

Well, I disagree with this assessment. It's more of a feature than some of others that were disqualified. At least it's clearly visible in public headers...

Well, I disagree with this assessment. It's more of a feature than some of others that were disqualified. At least it's clearly visible in public headers...

My understanding is that we can't really use SM2 without it because there is required to be a UID present.

Common "mistake" seems to be that it's assumed that it's sufficient to add an algorithm and then magic would happen by itself. But it never does. Focus should really be on how implementation interacts with outer world. For example you say that "we can't really use SM2 without it because there is required to be a UID present." But it's still about algorithm implementation. Customarily signature is structured data blob that describes algorithms and parameters, and question should be how that is supposed to work, not how to hammer stuff into box and make it crack, so that one can write tailored test program. In other words even with this it's not as useful as user would expect.

Common "mistake" seems to be that it's assumed that it's sufficient to add an algorithm and then magic would happen by itself. But it never does. Focus should really be on how implementation interacts with outer world. For example you say that "we can't really use SM2 without it because there is required to be a UID present." But it's still about algorithm implementation. Customarily signature is structured data blob that describes algorithms and parameters, and question should be how that is supposed to work, not how to hammer stuff into box and make it crack, so that one can write tailored test program. In other words even with this it's not as useful as user would expect.

I don't really understand your objection or what you are trying to say here. Are you suggesting we should release SM2 without UID support? That seems to be the default we are going to end up with unless we can resolve this.

I don't really understand your objection or what you are trying to say here.

What I'm trying to say is that it doesn't work in long run to practice this way. That is to just hammer stuff in till something implementation-specific works. Initial SM2 support that was hammered into ecdsa_ossl.c? Not the way to do it, was resolved. Making this work through double call? I'd say as bad, not the way to do it. And we choice is between hammering and releasing without something, I'd say latter. This is what I'm trying to say. As for objections, there is "however" paragraph in https://github.com/openssl/openssl/pull/6757#discussion_r208184883. Though I'm not saying that it would do, only that it might. As already said, one should view it from application side, i.e. how it would be used in implementation-neutral way, rather than from algorithm side, i.e. implement algorithm and what it takes to use it is application problem.

Since SM2 requires an ID/UID string when forming the 'prefix'(ZA) of the being signed message, the current implementation is not correct (more accurate, it has a bug...). To fix this bug, I would like to agree with @mattcaswell , or there might be a better way on the implementation side?
Furthermore, as discussed in relevant PR #6837 , we should be able to use the SM2_DEFAULT_USERID when forming the prefix ZA in SM2 sign/verify procedure if the user doesn't set a UID. Thus I guess if it's possible, then PR #6837 seems avoidable...

Ping @randombit , what's your opinion on this?

@InfoHunter Using the default user ID for SM2 signatures in any situation where the application has not set it probably makes sense. @ronaldtse what do you think?

Using the default user ID for SM2 signatures in any situation where the application has not set it probably makes sense.

I fully agree.

-1 blocker for now until we get through this context as it isn't making sense to have a "default" for something that is always meant to be set by the user.
The concept that there are test cases that need this set doesn't remove the idea that without it being set there should be an error.
I think we need to look at the usage here before we hardwire in something like this.

@t-j-h the default user ID is specifically demanded by GM/T 0009 Clause 10. GM/T 0009 is the document that specifies usage of the SM2 algorithm:
https://riboseinc.github.io/gmt-0009-2012/
The User ID field is only meant to be customized by the user with pre-agreement.

I think you are mixing things up here.
ISO/IEC 14888-3:2016 does not define that there is a default "identity string" at all and that is the low level algorithm document.
If there are other standards that are layered on top which specify what to do if an "identity string" is not specified then those (to me at least) are meant to be handled elsewhere.

The comment from @dot-asm on the name for this function and ID that does not contain SM2 should be addressed. ISO/IEC 14888-3:2016 calls it "identity string" and we could call it "personalisation string" for a generic term as suggested by others - but SM2_UID is not the right naming. Please fix that.

@t-j-h just for the record, both GM/T 0003 and GB/T 32918 (Parts 2-4), which are the official specifications of SM2, require usage of the default UID string in its tests. ISO/IEC 14888-3 "adopts" SM2 from these two documents.
In particular, the GM/T 0009 and GM/T 0010 documents are normative references of GB/T 32918, and defers to them within the standard. In a Standards point of view, both 0009 and 0010 form part of the official SM2 standard.

@ronaldtse I have an official copy of ISO/IEC 14888-3 and have read it in detail. I have read translations of the GM/T docs too.
The alternative approach in #7113 allows for the user setting the identity string and is layered in a manner which allows for multiple usage contexts and nothing precludes the outer code from using the functionality in a manner which passes the tests.
There is no requirement for a default value in the ISO specification or in the base SM2 specification document either, and it is also made clear that the value itself is an OCTET STRING which may have any valid length (including 0) conceptually - it is not an ASCII string. The base primitive as published does not wire in a default and the documents that suggest the default value are themselves rather terse and incomplete and do not override the base definition.
This particular PR contained a number of assumptions which were incorrect and certainly not covered in the base specification. The alternate PR allows for the functionality this covers and does not restrict the usage model and also avoids the double calls to EVP_DigestSignInit and SM2-specific labeling of the concepts.
The functionality in #7113 allows OpenSSL users to perform all the required capability without the limitations and assumptions that were in this PR. There isn't anything which is missing in terms of being able to drive the underlying crypto in order to pass the tests. it is a different way to solve the problem and it fits into the code base more cleanly and avoids SM2-specific items an invalid assumptions about ASCII-only. This is why we have a review process in place and why we need PRs like this one put forward for review so that multiple people can look at it and evaluate a range of approaches. Your contributions in this PR are valued and welcome and that is how collaboration works so we get better outcomes.
@InfoHunter has addressed all of the issues noted above and also your PR and his have encouraged more people to read the specification and to look into how to best fit this capability within OpenSSL.

@t-j-h , I agree that @InfoHunter 's approach is more suitable for OpenSSL and we have no objections to the newer PR.

the documents that suggest the default value are themselves rather terse and incomplete

I suppose this comment is for GM/T 0009 and GM/T 0010. They are regardless still "base" normative documents to a whole body of work relating to SM2, including certificate formats. Glad I wasn't involved in these. 😉


Don't consume extra content as the title block.

Fixes accidentally grabbing more content between hugo title delimiters.
Example: https://kpt-dev-ee2a9--bad-titles-0tgvg2bo.web.app/reference/pkg/cat/

Title for these commands shouldn't be capitalized:
https://kpt-dev-ee2a9--bad-titles-0tgvg2bo.web.app/reference/pkg/cat/
It's cat not Cat.

That's feature parity with the current primary site (see https://googlecontainertools.github.io/kpt/reference/cfg/cat/). It's editable at the same location as that site would be in either the main or next branch (https://github.com/GoogleContainerTools/kpt/edit/next/site/reference/pkg/cat/README.md line 2). @frankfarzan Do you want this PR to include the appropriate change across each file that was moved over from the main branch?

That's feature parity with the current primary site (see https://googlecontainertools.github.io/kpt/reference/cfg/cat/). It's editable at the same location as that site would be in either the main or next branch (https://github.com/GoogleContainerTools/kpt/edit/next/site/reference/pkg/cat/README.md line 2). @frankfarzan Do you want this PR to include the appropriate change across each file that was moved over from the main branch?

It can be a follow up PR making all the changes to the next branch.


bug fix: blender-cycles path

Models and lighting were previously moved out of shared-assets and this fix uses os.path.join to create the correct paths.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mike Festa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


dynamic values in file contains

How can we validate some parameters dynamically in some config file.
for example :
redis.conf
bind {{ eth2.ip_address }}

There would need to be a source of facts for this to work cleanly. Perhaps use Puppet's facter or Ansible setup to determine the value and populate the goss template

You should be able to use the --vars flag for this.
See Templates


Missing double-dash in front of "install"

The command line to install the templates is missing the double-dash in front of "install".
It currently is
"dotnet new install Microsoft.EntityFrameworkCore.Templates"
It should be
"dotnet new --install Microsoft.EntityFrameworkCore.Templates"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cae415b7-c0ea-4d96-9d17-7e7d3163c09d
Version Independent ID: cae415b7-c0ea-4d96-9d17-7e7d3163c09d
Content: Custom Reverse Engineering Templates - EF Core
Content Source: entity-framework/core/managing-schemas/scaffolding/templates.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: avickers

Duplicate of #4100


Bump test coverage

Codecov Report

Merging #9 into master will increase coverage by 10.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
+ Coverage   87.89%   98.08%   +10.19%
===========================================
  Files           9        9
  Lines         157      157
===========================================
+ Hits          138      154       +16
+ Misses         19        3       -16

Impacted Files
Coverage Δ

src/fast_nau.jl
88.88% <100.00%> (+1.38%)
:arrow_up:

src/fast_npu.jl
100.00% <100.00%> (ø)

src/nmu.jl
100.00% <0.00%> (+9.09%)
:arrow_up:

src/npu.jl
100.00% <0.00%> (+10.16%)
:arrow_up:

src/nalu.jl
100.00% <0.00%> (+23.52%)
:arrow_up:

src/nau.jl
100.00% <0.00%> (+25.00%)
:arrow_up:

src/nac.jl
100.00% <0.00%> (+36.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b7e5d...0c6a083. Read the comment docs.


[GHSA-rxmx-cgf3-gfph] An issue in Doccano Open source annotation tools for...

Updates

Affected products
CWEs
References
Source code location
Summary

Comments

Added the source code location
Added the ecosystem, package name, affected versions
Added the title
Added CWE

See #4857 4857


Handling the cases where the target_modality is a dict

Handling the cases where the target_modality is a dict (mostly in functions used at inference time) in t2t_model and transformer.

Thanks Mostafa. Can you make sure the CLA passes? We need it to merge, unclear why it's not passing. Maybe try again?

Not sure what's wrong with the CLA. I disabled two-factor authentication and this might be the problem. Going to enable it and send a new pull request.


Internal Config State Report

Adds a "Config State" report to the /status/config endpoint. The report presents a JSON representation of the "runtime" CAS server configuration as well as all available properties. This is useful for determining the state of the CAS configuration without fishing for settings inside the xml configuration files, etc and allows administrators to quickly determine CAS behavior based on configuration.
Important to note that only org.jasig components are reported back and everything else is filtered.

The screenshot above shows a filtered list of view of the CAS state and properties.

+1 with a question


switch to lambda-proxy v4

https://github.com/vincentsarago/lambda-proxy/pull/10

closed by https://github.com/vincentsarago/lambda-tiler/commit/597cdc7123d1e39081ea603ef481606f1092a3b1


4.3.0 is using SNAPSHOT dependencies version

Describe the bug
Cannot use current version 4.3.0 because it uses SNAPSHOT dependencies.

See https://github.com/cloudyrock/mongock/pull/289/files#diff-6d3b8e38bec2aaa78da8cd1ce19a25753752de347f6ccb0223e0e2fe5cc28c8bR17
To Reproduce
See  https://github.com/jhipster/jhipster-bom/pull/160/checks?check_run_id=1819652928

@DanielFran We found the issue. I will notify you soon with the fix

Hello @DanielFran. Apparently we made a mistake upgrading the versions in our integration tests and then, due to extra load on nexus servers, we spent more time than expected releasing the new version.
But finally we managed to release the version 4.3.2. It should work.
Please let me know if you need anything else.
Thanks


Bug fix in split_index method

Bug description: on a dataset of 20 samples, when running 4 workers with 8 threads per worker, then the split_dataset would return for worker id 1:
self.worker_splits
[[0, 5], [5, 10], [10, 15], [15, 20]]

self.thread_splits
[[5, 6], [6, 7], [7, 8], [8, 9], [9, 10], [10, 10], [11, 10], [12, 10]]

thread_splits is wrong and causes a crash in the DataAnalyzer: the end sample id is lower than the initial one on the last 2 threads.
This PR fixes that by fixing the behaviour of split_index

@loadams @conglongli  what's holding this PR?

@loadams @conglongli what's holding this PR?

We need the correct folks to review


Enhance clearError docs + fix bug

add TS and JS code example and sandbox to clearError Docs
fix CodeArea bug that would show CodeSandbox link even when there was none.

nice! thank you 🙉


coqPackages.coq-elpi: 1.6.0 -> 1.6.1

Motivation for this change
Update coq-elpi for Coq 8.11
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build coqPackages_8_11.coq-elpi coqPackages_8_11.hierarchy-builder

CC @vbgl @gares


Create vs Init functions

Review create vs init functions.  Need to settle on a consistent pattern for using each

Guidelines updated


Add terraform project to staging and production

This job is running well in integration.

:+1: go merge


Simple JSON select fails miserably

import clickhouse_connect

client = clickhouse_connect.get_client(host='localhost')
print(client.query("""
SELECT * FROM format(JSONEachRow, 'data JSON', $${"data": {"a":1}}$$)
""").result_set)

Will fail with:
Traceback (most recent call last):
  File "/home/user/git/project/tt.py", line 6, in <module>
    """).result_set)
         ^^^^^^^^^^
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/query.py", line 254, in result_set
    return self.result_rows
           ^^^^^^^^^^^^^^^^
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/query.py", line 272, in result_rows
    for block in stream:
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/common.py", line 195, in __next__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/query.py", line 292, in _row_block_stream
    for block in self._column_block_stream():
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/transform.py", line 75, in gen
    next_block = get_block()
                 ^^^^^^^^^^^
  File "/home/user/git/project/.venv/lib/python3.11/site-packages/clickhouse_connect/driver/transform.py", line 63, in get_block
    raise StreamFailureError(message) from None
clickhouse_connect.driver.exceptions.StreamFailureError:

Same thing in clickhouse-client:
cc85a1e2bfab :) SELECT * FROM format(JSONEachRow, 'data JSON', $${"data": {"a":1}}$$)

SELECT *
FROM format(JSONEachRow, 'data JSON', '{"data": {"a":1}}')

Query id: 9ac11d9c-987c-496e-8573-aa68f0688552

┌─data────┐
│ {"a":1} │
└─────────┘

1 row in set. Elapsed: 0.001 sec.

In more elaborate cases it will fail with:
Unrecognized ClickHouse type base:  name:

Yes, base is "" and name is "" too. :)
Probably the parser for types like Object('json') or Array(Object('json')) is pretty confused...
Connected to ClickHouse server version 23.8.1 revision 54465.

clickhouse-connect==0.7.0

ClickHouse does not support the JSON data type.

I'm not sure... I do see docs about it.
https://clickhouse.com/docs/en/sql-reference/data-types/json
https://clickhouse.com/docs/en/integrations/data-formats/json

The JSON data type is not supported: https://clickhouse.com/docs/en/sql-reference/data-types/json

I'm not sure it can be a tuple, if it's a real json type.
I.e. {"a":1}\n{"b":"foo"} what tuple it is? Tuple(a In64, b String)? Why? etc.
And it's not really a bug, 'cos clickhouse-client parses it perfectly. Or you're implying that it passes Tuple over TCP connection but something different for HTTP?
There's something that I still think is a problem: in my tests I've found out that different errors are returned for different queries, and sometimes even result is returned (wrong result). I would suspect that the C code is jumping all over the memory and not parsing the Native encoding correctly. Which is usually bad...

The binary result I get back from contains the column type Object('json'), which clickhouse-connect doesn't even implement a deserializer for, because queries of jSON columns normally return either a Tuple (or alternative, an Array) column type.  Because there's no specific deserializer, the transform code return an invalid null result, causing the error you see.  This never gets to any C code, but the expected result does return a rather cryptic error.
I suspect that ClickHouse client has some different binary/Native implementation to actually deserialize an Object('json') column, but given the downgraded status of the JSON type, I don't think it's worth digging through the ClickHouse C++ source code to implement it in clickhouse-connect for this edge case.

I think when I did Array(JSON) or something similar it returned [(),(),()]
So it does try to deserialize.
Ok.


I CAN NOT LOG IN THE APPLICATION: "Checkpoint issue"

Good night guys.
I just can not log in to the program, I always get the following message: "Instagram call checkpoint for this action!". From this, when at the official Instagram web he brings me the following message "We detected an unusual login attempt" and asks me to confirm if it was me that I tried to access. When I confirm and try to log back into "IGDM", the same checkpoint problem happens, in an infinite and unresolved cycle (prints below). The computer and smartphone are always logged on to the same network.
I'm looking for help, feelas. Thanks for listening!
Have a good weekend!

Duplicate of #60


ROS noetic implementation

@marinaKollmitz Do we have a ROS noetic implementation of this.
I am interested to use your work in LAAS-CNRS to benchmark our work. Please let us know.

@marinaKollmitz
Hi Marina! I am really interested in your work. Have you worked on releasing any ROS noetic version of this method? Thank you!


Errors and missing items in highly nested tree

When I try this code
tree = Tree(stripes=True, multiple_selection=False)
subtree = Node(f'subtree')
subtree.opened = False
tree.add_node(subtree)
for i in range(15):
    node = Node(f'node{i}')
    subtree.add_node(node)
    for j in range(15):
        subnode = Node(f'node{j}')
        node.add_node(subnode)
        for k in range(15):
            subsubnode = Node(f'node{k}')
            subnode.add_node(subsubnode)

I see a few errors in the browser console of this type
Comm promise not found for comm id f8eeb9730a294ab8a26ecdae8ed77a9c
When I try displaying it with
tree
I get quite a few errors like this in the console:
Uncaught (in promise) TypeError: t is undefined
    create_view manager-base.js:85
    create_child_view widget.js:604
    addNodeModel tree.js:166
    update viewlist.js:54
    onRendered tree.js:142
    t Lodash
    create_node jstree.js:3928
    renderNode tree.js:56
    initialize tree.js:51

and the actual tree display is missing the + and - open/close widgets.
If I have only 5 nodes at each level, then I don't get any errors.
I also tried this with 15 at each level but put in a time.sleep(0.2) in the innermost loop to see if it was a timing issue and then I did not get any errors and the display was perfect.
I have a real world tree with more levels of depth that is why I ran into this. I have inserted sleep statements in that and I can't get it to work at all there.
Thanks

I'm experiencing the same error with the reproducer above and with my own real-world tree. I would love to help debug this if possible. @martinRenou do you have any tips on how to dig in on this one?


Support service name in the ref verification.

There is a ref check feature missing in the current version. We are checking the instance id != 0 today, which is helpful but not enough, we should add service name(entry/parent) translated from the instance id in the mock.

Replaced by #4612


301 redirect in VirtualHost when server HttpsRedirect true

fix https://github.com/istio/istio/issues/34609
Signed-off-by: Zufar Dhiyaulhaq<EMAIL_ADDRESS>Please provide a description of this PR:
previously, we only create custom virtual hosts with 301 redirections when there is no virtual service available for a specific server in the Gateway object with HttpsRedirect set to true.
Gateway server & virtual service will create a virtual host. virtual host for HTTP might be empty if we create something like this:
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: my-gateway
  namespace: my-namespace
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "example.com"
  - port:
      number: 443
      name: https
      protocol: HTTPS
    hosts:
    - "example.com"
 apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: my-service
  namespace: my-namespace
spec:
  gateways:
  - my-gateway
  hosts:
  - "example.com"
  http:
  - name: example
    match:
    - port: 443
    route:
    - destination:
        host: my-kubernetes-service
        port:
          number: 443

but when the HTTP server enabled TLS redirection, this PR will create dummy virtual host for HTTP also.
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: my-gateway
  namespace: my-namespace
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    tls:
      httpsRedirect: true
    hosts:
    - "example.com"
  - port:
      number: 443
      name: https
      protocol: HTTPS
    hosts:
    - "example.com"

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test release-notes_istio

unit-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test release-notes_istio

unit-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test release-notes_istio

unit-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test release-notes_istio

unit-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
de4d55b502455f767dc26122778cd138314cd50f
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
d64bf808c62cd82c39a251134f8ce092ba871245
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

I don't think this is safe, see comment above.

I cannot see your comment.

The other case is that a user can have an HTTP server but still "bypass" the httpsRedirect with X-Forward-Proto and num_trusted_hops, so removing the routes breaks this.

If you remove all of the vhosts then this shouldn't work I would think?

Hi @howardjohn sorry, forgot to change the description, already updated it to not making confusion.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
f4380020717d0b8fab9d461955a20b72087cb8f1
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
f4380020717d0b8fab9d461955a20b72087cb8f1
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
baa2049126e3eb54fbfb905302fb20a80c1ac3a5
link
/test integ-pilot-multicluster-tests_istio

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-k8s-tests_istio

integ-cni-k8s-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-cni-k8s-tests_istio

integ-pilot-multicluster-tests_istio
203a52398b93c7afdb9b8b85b3d5aa6a849e2a3c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn create two integration tests, let me know what do you think and what do you expect.

FWIW https://github.com/istio/istio/issues/30501#issuecomment-903925200 appears to be not fixed by this PR (but it also was broken before the PR). Maybe we can get that one after this lands. Thanks for the PR, will give it another review shortly

@zufardhiyaulhaq: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-mc-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-istiodremote-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-mc-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-istiodremote-k8s-tests_istio

integ-pilot-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zufardhiyaulhaq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test unit-tests_istio

analyze-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test analyze-tests_istio

release-test_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test release-test_istio

integ-pilot-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test gencheck_istio

integ-helm-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-helm-tests_istio

integ-ipv6-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-ipv6-k8s-tests_istio

lint_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test lint_istio

integ-multicluster-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-multicluster-k8s-tests_istio

integ-security-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-security-multicluster-tests_istio

integ-telemetry-mc-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-telemetry-mc-k8s-tests_istio

integ-istiodremote-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-istiodremote-k8s-tests_istio

integ-pilot-multicluster-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-pilot-multicluster-tests_istio

integ-cni-k8s-tests_istio
df273e77a6f3902e5dbfb456a6c567768e45f113
link
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #34917

In response to a cherrypick label: #34689 failed to apply on top of branch "release-1.10":
Applying: create virtualhost with require_tls ALL when there is HttpsRedirect in gateway server
Applying: fix httpspport with rredirection enabled will create vHost from virtualservice
Applying: remove duplicate code
Applying: add integration tests
Using index info to reconstruct a base tree...
M	tests/integration/pilot/common/routing.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/common/routing.go
CONFLICT (content): Merge conflict in tests/integration/pilot/common/routing.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 add integration tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #34918

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.11 from head istio-testing:cherry-pick-34689-to-release-1.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-34689-to-release-1.11."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to a cherrypick label: #34689 failed to apply on top of branch "release-1.10":
Applying: create virtualhost with require_tls ALL when there is HttpsRedirect in gateway server
Applying: fix httpspport with rredirection enabled will create vHost from virtualservice
Applying: remove duplicate code
Applying: add integration tests
Using index info to reconstruct a base tree...
M	tests/integration/pilot/common/routing.go
Falling back to patching base and 3-way merge...
Auto-merging tests/integration/pilot/common/routing.go
CONFLICT (content): Merge conflict in tests/integration/pilot/common/routing.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 add integration tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #34919


fix: show editor topnav

Currently Topnav is showing wrong on editor page.
Test plan

Go to proposal editor.
Publish button is there.

Hold on

Can you fix this too? Modal should be over the topnav


Patents Pipeline

Description
This PR contains:

An initial analysis of the # of patents in google bigquery between 2016-2021 where at least one inventor is from the UK;
The full, initial patents pipeline of querying google bigquery for patents data, cleaning it and saving it to s3.

This PR closes:
#19
#3
#4
Instructions for Reviewer
To pull data from google bigquery:
python dap_aria_mapping/pipeline/data_collection/patents.py run
BEWARE!!! If production=true, this will cost money! I accidentally charged myself £5.36 for the full dataset. I've since changed cards to be nesta's business card but lets not run it in production unless it feels like we've got to re-collect data.
To post process the data:
python dap_aria_mapping/pipeline/data_collection/processed_patents.py run
This reformats all the date columns, extracts english titles and abstracts and unnests the assignee and inventor to be in a list of strings format instead of a list of dict format.
It also creates a look up table sam will need to extract entities.
In order to test the code in this PR you need to ...
pytest dap_aria_mapping/pipeline/data_collection/tests/test_patents.py
To make sure that the clean patents dataset:

Has a unique publication_number AND family_id per row;
Each patent document's filing date is between 01-01-2016 and 31-12-2021;
Has at least 1 inventor based in the UK associated to the invention

pytest dap_aria_mapping/pipeline/data_collection/tests/test_processed_patents.py
To test the unnest_column and extract_english_text processing functions
Please pay special attention to ...
running python dap_aria_mapping/pipeline/data_collection/patents.py run in production - it will cost money!
Checklist:

[ ] I have refactored my code out from notebooks/
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[ ] Appropriate information has been added to READMEs

[x] I have explained this PR above
[x] I have requested a code review

Side note: this is gonna cause merge issues with my branch, but once this is merged i'll fix them on my branch, then re-request a review