Implement Pending PipelineRun status (TEP-0015)

Changes
Implements the Pending PipelineRun status as described in TEP-0015. (based on https://github.com/tektoncd/pipeline/pull/3223)
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Added PipelineRunPending setting to PipelineRun Spec Status to allow creating PipelineRuns in a Pending state.

btw this is a relatively small PR so what im suggesting might be overkill but probably the fastest way to get this merged might be to break it up a little, e.g. if you had a PR with just the types and the validation, that could probably get merged a lot faster than this entire PR

btw this is a relatively small PR so what im suggesting might be overkill but probably the fastest way to get this merged might be to break it up a little, e.g. if you had a PR with just the types and the validation, that could probably get merged a lot faster than this entire PR

Thanks, if this makes it significantly easier for you as a reviewer I'm happy to do this, but I'm in no rush to get the API changes merged in without the implementation.

/ok-to-test
Logistics 😄  - please squash the commits

Thanks! I'll close my original PR after this is merged😸

I notice that the TEP says it's a non-goal to support pending TaskRuns, "as that would requiring pausing the Kubernetes pods themselves" -- I think that's actually a bit misstated -- pending TaskRuns could just not create Pods, the same way that pending PipelineRuns just don't create TaskRuns. I think it's worth reconsidering implementing pending TaskRuns for consistency, or at least coming up with a better rationale for not doing so.

Thanks, if this makes it significantly easier for you as a reviewer I'm happy to do this, but I'm in no rush to get the API changes merged in without the implementation.

I think I'm just over-applying this principle and this PR is pretty easy to review as it is 👍

I notice that the TEP says it's a non-goal to support pending TaskRuns, "as that would requiring pausing the Kubernetes pods themselves" -- I think that's actually a bit misstated -- pending TaskRuns could just not create Pods, the same way that pending PipelineRuns just don't create TaskRuns. I think it's worth reconsidering implementing pending TaskRuns for consistency, or at least coming up with a better rationale for not doing so.

Nice catch, yeah this is left over from when the proposal was to actually pause a running pipeline.

Thanks @jbarrick-mesosphere !!
What do you think about maybe including an end to end test as well? https://github.com/tektoncd/pipeline/tree/master/test#end-to-end-tests

Added an e2e test. :+1:

Nice catch, yeah this is left over from when the proposal was to actually pause a running pipeline.

I see. Is the intention to support creating pending TaskRuns as well then? Either way, can you update the TEP with this?

I see. Is the intention to support creating pending TaskRuns as well then?

I don't currently have a use-case for this.

Either way, can you update the TEP with this?

I can update the TEP, but that is outside of the scope of this PR.

I don't currently have a use-case for this.

The initial TEP proposal PR says it will cover TaskRuns: https://github.com/tektoncd/community/pull/203
Another recent TEP, https://github.com/tektoncd/community/pull/228, assumes pending TaskRuns to limit concurrency during PipelineRun execution.

The initial TEP proposal PR says it will cover TaskRuns: tektoncd/community#203

I wrote the TEP, it doesn't say that.

Another recent TEP, tektoncd/community#228, assumes pending TaskRuns to limit concurrency during PipelineRun execution.

That would be a discussion to have on that TEP's PR.

I wrote the TEP, it doesn't say that.

Hey, sorry, I think I spoke imprecisely. I just meant the PR's title as merged was "Add a pending setting to Tekton PipelineRun and TaskRuns", so it seemed like we had intended to support it at some point. It's fine that the TEP's scope eventually narrowed -- better that than the opposite! -- and that the actually-merged TEP didn't cover pending TaskRuns at all.
Your previous comment had been about lacking a use case, and I found the pipeline-concurrency TEP as a use case which was depending on pending TaskRuns, seemingly assuming they'd be added as part of your TEP. You're absolutely right that the pipeline-concurrency TEP is the place to discuss the addition of pending TaskRuns as a requirement for concurrency-limited pipelines.
(To be clear, none of this discussion should block this PR, which otherwise looks great to me.)
If you felt so inclined to extend this work in another PR to include pending TaskRuns, being as you have recent experience implementing such a change, I'm sure the authors of the pipeline-concurrency TEP would appreciate it. If that's outside your needs and you'd prefer the author of that TEP or the community at large to support pending TaskRuns, that's fine too. Thanks for your contributions of all kinds throughout this process. :)

This should be ready for review.

Do we have any plans to move forward this PR? 🤔

Do we have any plans to move forward this PR? 🤔

Any process of the PR, here we have a case and expect to leverage this feature:
There is a specific task named terminator and when arrive the task, the pipeline should be pause, and before cancel need to do some cleanup work...
@ImJasonH @bobcatfish

Any process of the PR, here we have a case and expect to leverage this feature:
There is a specific task named terminator and when arrive the task, the pipeline should be pause, and before cancel need to do some cleanup work...
@ImJasonH @bobcatfish

Given how long this PR has been open and that I only have a nit about a comment, I'm happy to add that comment in a follow-up PR.
/approve

Given how long this PR has been open and that I only have a nit about a comment, I'm happy to add that comment in a follow-up PR.
/approve


Issue-change body background and bar hover styles

Automated Review Comments
Issues in examples/barChartExample/index.html:

(2, 'Line exceeds 80 characters')
(2, 'Hardcoded string found')
(7, 'Hardcoded string found')

I got it.


Set default for event attachments

Currently when someone adds an image to their event to be displayed as a banner, they have to manually choose that item as the one to be displayed. If there is only one, or even if they add multiple, we just choose a default selected attachment.

 Set default for event attachments

Resolved in PR #1221


bodyParser (multipart) suggestion/question

So love the multipart parser, thanks for getting it apart of connect!  One thing I noticed, if you have a form with three inputs (say two text fields and a file input), and they are all in an array.  The order of the fields in the array will be consistent for the two text fields but the file ones will be jumbled (I'm assuming based on when they finish being parsed), is there a way to maintain the array ordering for files as well as fields?

hmm anything i could reproduce? I suppose it depends on when formidable can write them to disk and consider them "done" etc

sure, here is an example html snippet that I'm using to submit the form
<form enctype="multipart/form-data" method="post">
   <input name="names"> : <input type="file" size="10" name="files">
   <input name="names"> : <input type="file" size="10" name="files">
   <input name="names"> : <input type="file" size="10" name="files">
</form>

In this example, names will be an array and appear in the order seen above, however files could be any order.
Marc

I'm sure we could map them to retain ordering but im also curious what the use-case is? does the ordering really matter? but we do wait to next() anyway so we could certainly retain it

Sure, in my case I had a photo upload, where you could specify a name and a file (and other details) for each photo, in order to keep them together.  So when I saved, I could grab the file, name, etc from the same index and put them together.  Right now, since this isn't the case I have to letter the inputs like nameA, fileA, typeA.  Which is doable, but this way it'd save me a step.  It probably is minor but if there is a use case like this one, it may be worth it (or at least more usable than the current state in my case)

ah gotcha, cool


Using VS2019 to Build AWS-SDK-CPP files and libraries, Failing

Describe the bug
I am using VS2019 to make the libraries and its failing with the error msg:  Building Custom Rule D:/Projects/Sdks/aws-sdk-cpp-Source/aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-cal/CMakeLists.txt
cl : command line error D8016: '/O2' and '/RTC1' command-line options are incompatible.
Whether its on the command line or inside VS2019, cannot build.
VS2019 is different than VS2015 and /RTC1 cannot operate with /O2 together. In the properties of each file is the "Optimization" where /O2 is specified. On the "Code Generation" property under "Basic Runtime Checks" is where AWS has put the switch "/RTC1". I have to change that to default although I have not tested it yet. There are a lot of files.
What is the workaround?

Expected Behavior
Expect no errors
Current Behavior
I have to open each file separately and set the RTC1 to default, every FILE!
Reproduction Steps
each file is modified for no /RTC1 if /O2 is set under Optimization

Possible Solution
Edit each individual code in VS2019 and change the Code Generation to default
Additional Information/Context
No response
AWS CPP SDK version used
latest clone from Github Aug 26, 2022
Compiler and Version used
gcc== 12.1.0 , VS2019
Operating System and version
windows 11, Version	10.0.22000 Build 22000

Sorry for the slow reply. The building process of this sdk has changed since this issue was opened. I'm not able to reproduce this with the current version. Can you update and try again with the latest version


Logging: Use ISO8601 timestamps

This patch disables the zap development logging mode that was the
default in the Cinder operator.
The new code does not set any zap options and only expects to read
options from the command line.
For development purposes it is convenient to run logging not only in
development mode, but also increase the log levels and change the time
encoding from epoc to iso8601 which is easier to read for humans, so 2
new make targets are added, run-dev and docker-build-dev which are
similar to the run and docker-build targets.
The run-dev target is different from the standard run because it
will only build the operator if the binary doesn't exist.

This has been fixed somewhere else.


HacktoberFest - Indian flag canvas

Due to merging your other pr, there are conflicts that need to be resolved. You can pull the updated master version to review and fix the conflicts.

Reviewed and resolved the merging conflicts in this branch


Default is required on generic type of skipped fields

rust: v1.51.0
serde: v1.0.125

use serde::{Deserialize, Serialize};

#[derive(Deserialize, Serialize)]
struct Foo<T> {
    vals: Vec<Bar<T>>,
}

#[derive(Deserialize, Serialize)]
struct Bar<T> {
    #[serde(skip)]
    skip: OCell<T>,
    other: usize,
}

pub struct OCell<T>(Option<T>);

impl<T> Default for OCell<T> {
    fn default() -> Self {
        Self(None)
    }
}

gives me the error message
error[E0277]: the trait bound `T: Default` is not satisfied
 --> src/lib.rs:5:5
  |
5 |     vals: Vec<Bar<T>>,
  |     ^^^^ the trait `Default` is not implemented for `T`
  |
  = note: required because of the requirements on the impl of `Deserialize<'_>` for `Bar<T>`
  = note: 1 redundant requirements hidden
  = note: required because of the requirements on the impl of `Deserialize<'_>` for `Vec<Bar<T>>`
  = note: required by `next_element`
help: consider further restricting this bound
  |
3 | #[derive(Deserialize + Default, Serialize)]
  |                      ^^^^^^^^^

error[E0277]: the trait bound `T: Default` is not satisfied
 --> src/lib.rs:5:5
  |
5 |     vals: Vec<Bar<T>>,
  |     ^^^^ the trait `Default` is not implemented for `T`
  |
  = note: required because of the requirements on the impl of `Deserialize<'_>` for `Bar<T>`
  = note: 1 redundant requirements hidden
  = note: required because of the requirements on the impl of `Deserialize<'_>` for `Vec<Bar<T>>`
  = note: required by `next_value`
help: consider further restricting this bound
  |
3 | #[derive(Deserialize + Default, Serialize)]
  |                      ^^^^^^^^^

Why Default is required on T? OCell is implemented Default for any type, so I don't think it's necessary to ask for that

I found the solution in the offical documentaion.
use serde::{Deserialize, Serialize};

#[derive(Deserialize, Serialize)]
struct Foo<T> {
    #[serde(bound(
        deserialize = "Vec<Bar<T>>: Deserialize<'de>",
        serialize = "Vec<Bar<T>>: Serialize"
    ))]
    vals: Vec<Bar<T>>,
}

#[derive(Deserialize, Serialize)]
struct Bar<T> {
    #[serde(skip)]
    skip: OCell<T>,
    other: usize,
}

pub struct OCell<T>(Option<T>);

impl<T> Default for OCell<T> {
    fn default() -> Self {
        Self(None)
    }
}


Get engine from connection when none provided

The currently used database engine can be fetched from PDO if it is not
set at runtime.
Fixes #23

I have no idea how to test this.

I do. :)


menu with header (beta10)

Since beta  10, my menu have some view problem. Middle down part of it is empty.
In breaking changes I see we must insert toolbar inside header/footer or content.
But, it's not updated in doc for menus. (toolbar is always outside ion-content tag)
http://ionicframework.com/docs/v2/components/#menus
How we should use menus and toolbar in menu ?

The toolbar should also be inside a header. Check out Step 3 of Steps to Upgrade to Beta 10, and this quote from the Changelog:

The only elements that should be children of a page are ion-header, ion-content, and ion-footer

It normally takes a couple of days for the doc to reflect changes from a new beta release.

Thanks for the issue! I'm going to move this to the ionic-site repo to make sure the docs are updated for this. :smile:
To answer your question: The menu toolbar should be similar to a page where the ion-toolbar is inside of an ion-header or ion-footer.

This issue was moved to driftyco/ionic-site#676

I am not sure to understand, it means that the menu has to be in a ion content too ?
<ion-menu [content]="content">
      <ion-content>
      <ion-toolbar>
        <ion-title>Pages</ion-title>
      </ion-toolbar>
...

or
<ion-content>
    <ion-menu [content]="content">
      <ion-toolbar>
        <ion-title>Pages</ion-title>
      </ion-toolbar>
...

I'm having the same problem, the menu doesn't render it's content and navigation also doesn't work (worked as of beta 9).

Can you try it with the nightly? We made a change recently that may have fixed it:
npm install --save ionic-angular@nightly

This vesion doesn't work in my browser (ionic serve):
It errored that it couldn't find ion-app selector, even though I'm using app selector in index.html and the App component

I changed the selector to ion-app, the error went away, but nothing is showed (blank screen)
It also shows an error cordova_not_available, but that was also showing in beta10.

Could you please clarify which one of the two ways of ion-content hierarchy from @movrack's comment is correct? An updated menu starter template would be nice in the future :-)

When you update the doc, please, could you also explain how to set the menu in an other file than the app.ts? And then use it.
Is it possible ta have an event (eventemitter) suscribable from ts file ? Actually, I use events ionOpen and ion Close to call methods who call a menu service to emit event suscribable.

The following markup should be used for a menu:
<ion-menu>
  <ion-header>
  </ion-header>

  <ion-content>
  </ion-content>

  <ion-footer>
  </ion-footer>
</ion-menu>

See: https://github.com/driftyco/ionic/blob/master/src/components/menu/test/basic/main.html
If I remember correctly there was an issue with the beta 10 release where this wasn't working right. That should be fixed in the beta 11 release by this commit: https://github.com/driftyco/ionic/commit/3cd31c3d17b358f6b6afa5c9512ff605517d781b
To test this out, install the nightly:
npm install --save ionic-angular@nightly

We'll update the starter template as soon as beta 11 is released. Thanks! :)


3rd-party: JSMinPlus 1.3 exhausts memory

2 users have complained that JSMin+ exhausts PHP's memory.
http://www.google.com/url?sa=D&q=http://groups.google.com/group/minify/browse_th
read/thread/6f98e6462b2e2d65&usg=AFQjCNF0Jt8UevopaOx-6NY49qF3mNzC4Q
http://groups.google.com/group/minify/browse_thread/thread/64a8579f8add029e

My suggestion is to remove the singleton instance, allowing all the objects
to be GCed when ::minify() returns. Simply replace (line 118 of v1.3):

static $instance;

with:

$instance = false;

Neither user has notified me if this helped...

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 3 Feb 2010 at 8:12

This may not be due to the static, but rather the memory intensive design.
http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html#r_35237

Only workaround is raising PHP's memory limit...

Original comment by<EMAIL_ADDRESS>on 3 Feb 2010 at 8:16

Changed state: NeedInfo


Improved Behavior of Selection Tool

Current Behavior:
The current implementation of the selection tool allows users to drag from any point on the selected object, whether it be a corner or a side. Once a point is dragged, only that point moves, with all other points remaining stationary.

Desired Behavior:
The enhancement proposal focuses on making the tool's behavior more intuitive and flexible:

Only corners should initially be fixed in place.
Points located on the sides of the rectangle should be able to move in conjunction with the corners, assuming their positions haven't been manually adjusted.
If a user adjusts the position of a point on a side, this action should create a new corner. Additionally, new draggable points should appear in the middle of the newly formed sides, allowing for more precise adjustments.

This proposed change aims to improve the tool's usability and efficiency, offering users more control over the selection shape with an intuitive interface.

Fixed in https://github.com/ugcs/UgCS-GeoHammer/commit/22a4a319e785555c7391bda0323faa36960692d1


Enter key dosen't work

Description

How to reproduce?
Hi, I'm start using this editor, the system is develop using bootstrap 3.3.7 and jquery 2.2.4.
The editor is loaded normally and I can use all the features but the enter Key is not working.
I loaded the editor witch CDN

Can you please provide me a demo page, where I can 100% reproduce the bug?

Hi, Alex. I just found the problem. There is an script that is included in this page that prevent the function of Enter key. Problem solved!
Thanks


React and<EMAIL_ADDRESS>fails to render

Describe the bug
React and<EMAIL_ADDRESS>fails to render.  Any version of 6 (I tried 6.0.1-dev.1571252146179, latest as of today and 6.0.0).  5.3.3 works fine.
To Reproduce
Steps to reproduce the behavior:

npx create-react-app test-app
Add the Map.js shown below
Update the App.js shown below
npm i<EMAIL_ADDRESS>npm start
Observe that the page is blank.  React Dev tools shows there is a component.
npm i<EMAIL_ADDRESS>Restart dev server (ctrl-c, npm start)
Observe that the map is rendering

Map.js
//externals
import ReactDOM from 'react-dom';
import React from 'react';

import View from 'ol/View';
import Projection from 'ol/proj/Projection';
import olMap from 'ol/Map';
import Tile from 'ol/layer/Tile';
import OSM from 'ol/source/OSM';
import Zoom from 'ol/control/Zoom';

require('ol/ol.css');

export default class Map extends React.Component {
    constructor(props) {
        super(props);

        this.view = new View({
            center: [-41925.302985762304, 4789880.268977703],
            zoom: 12,
            minZoom: 2,
            maxZoom: 28,
            projection: new Projection({
                code: 'EPSG:3857',
                units: 'm'
            })
        });
    }

    componentDidMount() {
        this.map =  new olMap({
            view: this.view,
            controls: [ new Zoom() ],
            layers: [new Tile({ source: new OSM() })],
            target: this.refs.mapContainer
        });
    }

    render() {
        console.log('-> render App')
        return (

        );
    }
}

// module.exports = Map;

App.js
import React from 'react';
import logo from './logo.svg';
import './App.css';

import Map from './Map'

function App() {
  return (

      <Map/>

  );
}

export default App;

Expected behavior
The map should render for version 6.0.0

Looks like your mapContainer div does not have any dimensions. You have to give it a width and height.

Ok thanks (of course!).  Funny that<EMAIL_ADDRESS>doesn't have an issue with this.
I'm updating the code in the question with an id and adding the App.css file below for completeness for anyone following this.
#mapContainer {
    height: 850px;
    width: 100%;
}

This might be obvious for some, for me it wasn't :
one could use height: 100% again if all parent container's (css elements) has a height specified, since % must be based of something.

i try this and my problem is in .css file, for the map container i used a min-height and min-width. i changed it to height and width and problem solved!
any ideas?


Implement CreateNetwork

New feature: run TOBIAS CreateNetwork to identify TF-TF regulatory networks. (resolves #1)

JASPAR PFMs set in the config file. These are used to map TF motif names to the genes that encode them.

Add hg19 to the config file for biowulf users. (resolves #2)

@kopardev should we release a new minor version soon with the bug fixes in master plus the new features in this PR? Krithika is running TOBIAS on biowulf so we may want to get this out soon.


Release code about Contact Head prediction and evaluation

Thx for your great job!
I wonder when will release the code about Contact Head prediction and evaluation. Since the evaluation pipeline seems quite different from ESM-2 and TAPE.

Hi, thank you for you interest in our work!
We have uploaded the dataset of contact head prediction and provided scripts for training and evaluation. You could download the dataset here https://drive.google.com/drive/folders/11dNGqPYfLE3M-Mbh4U7IQpuHxJpuRr4g and run the script below:
python scripts/training.py -c config/Contact/saprot.yaml

Let me know if you have any other question!


Issue from website page 404

From URL: https://www.flutterchina.club/404.md

You can raise the issue in the
respository flutterchina/website.

@justinmc you should close this issue.


Missing data-item-length attribute

Attributes to configure item dimensions are present, but the data-item-length attribute is missing. It will be required in order to get precise shipping rates estimates.

Thanks! Fixed in upcoming v0.9.2.

Closing


Remove type=number from date field

Fixes #481

Codecov Report

Merging #779 (9f625a0) into master (4264c2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   99.30%   99.30%
=======================================
  Files         121      121
  Lines         858      858
  Branches      248      248
=======================================
  Hits          852      852
  Misses          6        6

Impacted Files
Coverage Δ

components/date-field/src/input.js
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4264c2a...9f625a0. Read the comment docs.

Deploy preview for govuk-react processing.
Building with commit 9f625a02977f15e4575e9d6e2f4b630f1f1e420c
https://app.netlify.com/sites/govuk-react/deploys/609fee6023dc820008bd7733


duplicate symbol _sbox issue, one project with EstimoteSDK + SensoroSDK for arm64

I have some issue:
EstimoteSDK v4.0.0-beta8
SensoroSDK v4.1.3
when import two SDK  Estimate + Sensoro for one project I have this issue:
duplicate symbol _sbox in:
Dependencies/estimote-sdk/EstimoteSDK.framework/EstimoteSDK(Encryption.o)
/Users/ErmaCK/Documents/PointInside/ios-beacontool/Dependencies/SensoroBeaconKit/libSensoroBeaconKit.a(SBK_TI_aes_128.o)
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
This issue only for arm64. Can you help me?
Thanks

Thanks, we're looking into that. I think Sensoro uses the same Nordic BLE chip that we do, so this is likely just a conflict due to a duplicated Nordic library we both use in our own SDKs. We've seen something similar before with Estimote + Kontakt SDKs in a single project. We'll see if we can namespace that.

Fixed in beta13. Also, let's move beta SDK bug reports into the beta SDK repo. If you need access, shoot me an email<EMAIL_ADDRESS>


Getting physics control crashing in Synchronous mode with a fixed time-step

Hi,
CARLA version: 0.9.13 (Built from source with Unreal Engine)
Platform/OS: ubuntu 18.04.6
Run mode: Synchronous mode with a fixed time-step
Problem you have experienced: I am trying to get physics control for each vehicle in the scene but the engine keeps crashing with the following error -
4.26.2-0+++UE4+Release-4.26 522 0
Disabling core dumps.
Signal 11 caught.
Malloc Size=65538 LargeMemoryPoolOffset=65554
CommonUnixCrashHandler: Signal=11
Failed to find symbol file, expected location:
"/opt/carla-simulator/CarlaUE4/Binaries/Linux/CarlaUE4-Linux-Shipping.sym"
Malloc Size=131160 LargeMemoryPoolOffset=196744
Malloc Size=131160 LargeMemoryPoolOffset=327928
Engine crash handling finished; re-raising signal 11 for the default handler. Good bye.
Segmentation fault (core dumped)

Steps to reproduce:
I tried the following fixed_delta_seconds - 0.2, 0.1, 0.05. I have initialized the synchronous mode in the following way -
settings = client.get_world().get_settings()
settings.fixed_delta_seconds = 0.1
settings.synchronous_mode = True
world.apply_settings(settings)

After spawning the vehicles and running a few time steps, I'm trying to get physics control for each car. This is where the code breaks.
vehicle = world.get_actors().filter('*vehicle*')[0]
print(vehicle.type_id)
physics = vehicle.get_physics_control()      <----

I'm able to get physics control in the Async mode but cars are not in auto-pilot. As soon as I turn the auto-pilot on for each car and try to get physics control, the simulator crashes again.
I would appreciate any help. Thank you!

It was a bug in my code, I was accidentally turning on the hybrid physics mode and requesting physics for all the vehicles in the scene.
traffic_manager.set_hybrid_physics_mode(True)
traffic_manager.set_hybrid_physics_radius(70.0)

Removed it. Thanks!


[New Port Request] <Cista++>

Library name: Cista++
Library description: Cista++ is a simple, open source (MIT license) C++17 compatible way of (de-)serializing C++ data structures.
Source repository URL: https://github.com/felixguendling/cista
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


Cant connect with Home Assistant via Tunnelmole

I cant connect to my home assistant system that is connected via a tunnelmole client.
I get constantly the following screen.

When i connect my HA instance directly via a ip address then it works but not via tunnelmole what i want to give it a bit of security.
i got login errors in my logs when i login into HA when i connect via Tunnelmole.

Most likely it has a TCP based protocol that is not HTTP/HTTPs. Tunnelmole currently only supports services running over HTTP/HTTPs.


Opcodes

A handful of changes to implement some unofficial opcodes.

Must be something in the air - Holladiewal's work on opcodes is much more complete than the above, so I'll close this out.


Use image2pipe?

We might be able to improve performance by using FFmpeg's image2pipe and streaming each frame to the open process, instead of writing each one to a file first and loading those.  Unclear how much of a performance boost this would be.

A few tests indicate the possible performance gains aren't that great, maybe 20%, and introduce a lot of new FFmpeg pitfalls.


Add support for Kubernetes-based IaC - CAPZ and ASO

In a modern GitOps workflow for IaC, using Kubernetes as a control plane is an excellent way to accomplish this via Cluster Api Provider for Azure (for self-managed Kubernetes or AKS) and Azure Service Operator (for almost any Azure resource).  I'd like this to work with azd tooling.

For this, do you imagine that for an individual application all resources would be represented via K8s manifests or are there instances where you might mix and match Bicep/TF with K8s manifests? Interesting in the split, if that's a viable use case.
@markweitzel @chuxel for input here too

Target primary use case is everything represented in ASO or CAPZ.  I have not heard of a customer desiring a mixed-use case of ASO/CAPZ plus something else (Bicep/Terraform).  The only time I see it is if there is a need to temporarily fill a gap in ASO.


yuzu-early-access: fix build error due to warning as errors

Description of changes
yuzu-early-access uses a blanket -Werror which causes the build to fail due to library functions marked as deprecated
Things done
Added a patch that removes -Werror

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux (not supported)
[ ] x86_64-darwin (not supported)
[ ] aarch64-darwin (not supported)

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 220931 run on x86_64-linux 1

1 package failed to build:

yuzu-mainline

1 package built:

yuzu-early-access

This appears to break yuzu-mainline. Maybe you can just do a hook like this instead?
postPatch = ''
  sed -i '/-Werror/d' src/common/CMakeLists.txt
'';

Fixed!

Fixed!

Okay, so I know I suggested the patch you just used, but could you also add a short comment above the hook explaining its purpose?
That way its function is clear and if upstream changes what they're doing, then it's clear when the hook can be removed
Thank you!

I wonder if this means the package will be maintained in the future.
Both yuzu packages are outdated since months and outdated.
Sorry to spam this merge request but I hope somebody can give me a answer.
I've already created an update request: https://github.com/NixOS/nixpkgs/issues/218827
)So is someone planing to update this package?

I wonder if this means the package will be maintained in the future. Both yuzu packages are outdated since months. Sorry to spam this merge request but I hope somebody can give me a answer. I've already created an update request: #218827 So is someone planing to update this package?

https://github.com/NixOS/nixpkgs/pull/224348#issuecomment-1493299886


Docker updates

I was running the code to debug #1116 and understand the project, modified some stuff in it:

speed Docker build by doing the npm install with only npm package* files before copying the whole codebase (also had a dev/devcontainer setup using a dev target but didn't want to pollute with vscode-specific files
add an autoRemove option to the server docker config: the created container is kept, even if it's not working
add log debug in the go code to show the created container config

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matthieu Berthomé seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


WIP: Ize 587 component tree for ize website (+ IZE-608)

Codecov Report

Merging #480 (e9ec662) into ize-sh-v1 (a3236bd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           ize-sh-v1     #480   +/-   ##
==========================================
  Coverage      28.60%   28.60%
==========================================
  Files             51       51
  Lines           5446     5446
==========================================
  Hits            1558     1558
  Misses          3766     3766
  Partials         122      122

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


!schedule remove now actually removes things that exist

I'm not good at programming. Now schedule remove will remove things that exist.

Thanks for not using any of the fancier options :+1:


How to set the hyperparameter ‘in_dim ’ in WATTNet?

Should this hyperparameter be set equal to the number of time series？
when x_in in shape (N, C, H, W), should in_dim set equal to W

p.s. What are preMLP and postMLP used for?

Hi @qiao1406, thanks for asking.
(1) You're correct, in_dim should be W
(2) A simple means to change the dimensionality. For example postMLP is useful when the pyramid structure of WATTNet does not leave you with the desired output dimensions. You can use other components, such as an RNN/LSTM there.

thank you!

thank you!


:sparkles: feat(icons): Use icons in HTML

Summary
According to https://design.baloise.dev/?path=/docs/foundation-icons-development--page#import-into-the-component
there isn't a simple way to use the icons in a HTML & JS app.
So we can't do something like
import { balIconAccount } from '@baloise/design-system-icons'

even the provided index.js throws an error.

Use Case
Using HTML & JS. We don't have any angular capabilities and we just understand JS supported natively by the browser.
Preferred Solution
Maybe you could provide a loading mechanism that the following list get's extended.

Additional Information
Currently my workaround is to copy&past svg code.

Will this feature introduce breaking changes?
None
Code of Conduct

[X] I agree to follow this project's Code of Conduct

/cib

Hi @dweber019,
Try to use  the ES module file with script type module, then it should work fine.
<script type="module">
      import { balIconAccount } from './dist/index.esm.js'

      console.log('balIconAccount', balIconAccount)
</script>

Can't use type module as we have no control how js files are loaded in the header section.


can oap auto get host ip to register center  in cluster mode

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
if I dont set gRPCHost: ${SW_CORE_GRPC_HOST:<IP_ADDRESS>} , can oap auto get host Ip or docker container ?

We don't provide this, as mostly, the IP or hostname could be multiple. If you want to add this kind of feature, you could send a pull request, and we discuss there. WIll you?

I very like to ,but I have a little trouble to understand the  meanings of  source code . I need to learn soure code further

have same problem.
but i think when grpcHost set <IP_ADDRESS>  , we could throw an warn or error  for in cluster mode at lest.
and mention it in our doc。


feat: support multi-part extensions for file icons

nvim-tree/nvim-web-devicons supports "mult-part" file extensions.
E.g. for these 2 files:

file1.js
file1.test.js

nvim-web-devicons can return different icons for "js" and "test.js". But right now fzf-lua only ever passes "js" as the extension.
This PR parses the filename in order to determine the extension and handles these multi-part extensions.
Before:

After:

P.s. thank you for this plugin!! 🔥

Ty for this PR @mikeroelens, definitely worth considering, I will look into it as well as the code provided, this is called for every single file and has performance implications, I’ll do some testing and if need be use something other than a lua regex, it’s also worth looking what are the conditions for enabling that in devicons (is it the default?) and respecting the options if such exists.

@ibhagwan wow thanks for the wicked fast reply!

g what are the conditions for enabling that in devicons

These extensions are built right into devicons (example)
When looking through that though I realized this is only a thing for JS projects. So if there's any performance degradation at all likely not worth it. Or at least could make it configurable I suppose.

Question, does this PR take into account a fallback icon?

Great call! Just tested it and it doesn't work as expected, just falls back to the overall default. I can try and fix that

When looking through that though I realized this is only a thing for JS projects. So if there's any performance degradation at all likely not worth it. Or at least could make it configurable I suppose.

Yes, I just did the same exploration of the devicons code and got to the same conclusion.

So if there's any performance degradation at all likely not worth it. Or at least could make it configurable I suppose.

I think there is bound to be performance impact as we’ll need to (at the bare minimum) test for 2 different extensions, xxx.js and .js as fallback (you wouldn’t want to lose the icon for regular js files), I assume we would probably want to test this for every extension not just js for future devicons changes which means the double(+) map lookup would happen on every file, we’d also need to search every file for every dot occurrence (vs reverse search from the end as it is now).

Great call! Just tested it and it doesn't work as expected, just falls back to the overall default. I can try and fix that

If we are to do this work, I’d like to refactor the entire logic and basically stop calling devicons.get_icon and have our own logic do the work against the copy of the icons table we already maintain for the multiprocess queries so don’t spend too much time on this as I’m going to rewrite the whole thing differently.

Perhaps we can limit the perf impact if we decide to support only 2-part extensions, this way we limit the dot reverse search to 2, this still means we’d have to perform 2 lookups for files in the format of file.class.obj.ext, one failed looked up for obj.ext and another for ext.
Another idea I have is a list of valid pre-extensions warranting lookups, so we can limit the 2nd lookup only if the second part is test or spec therefore skipping the above example of obj.ext.
All of the above won’t prevent having to reverse scan for dots but it would alleviate some of the performance loss.

Perhaps we can limit the perf impact if we decide to support only 2-part extensions, this way we limit the dot reverse search to 2, this still means we’d have to perform 2 lookups for files in the format of file.class.obj.ext, one failed looked up for obj.ext and another for ext.
Another idea I have is a list of valid pre-extensions warranting lookups, so we can limit the 2nd lookup only if the second part is test or spec therefore skipping the above example of obj.ext.
All of the above won’t prevent having to reverse scan for dots but it would alleviate some of the performance loss.

All of this makes a ton of sense to me!
Another thing I was thinking about is personally I don't really care about the different icon for test files. I more so care about a different icon color for tests. Just some quick indicator to distinguish a test file from a regular file.  I'm wondering if people feel the same way. If so maybe there's a nice way fzf-lua could expose a mapping like:
icon_mapping = {
   [".test.ts"] = {
       color = "yellow",
   },
   [".spec.ts"] = {
       color = "yellow",
   },
   -- Example where the naming convention doesn't have another '.' but rather just ends with '_test'
   ["_test.go"] = {
       color = "yellow",
   },
}

Essentially a mapping of "file name ends with" - > icon color (could also add other options like icon_override). Would be neat for a lang like Go that has a filename pattern of _test.go for tests.
It would be a little more flexible than strict "extensions". A user could provide anything, and could still keep it as performant as possible by only looking for known mappings. Just food for thought, just throwing it out there in case it also sparks any ideas for you 😄

Just some quick indicator to distinguish a test file from a regular file. I'm wondering if people feel the same way. If so maybe there's a nice way fzf-lua could expose a mapping like
Essentially a mapping of "file name ends with" - > icon color (could also add other options like icon_override). Would be neat for a lang like Go that has a filename pattern of _test.go for tests.
It would be a little more flexible than strict "extensions". A user could provide anything, and could still keep it as performant as possible by only looking for known mappings. Just food for thought, just throwing it out there in case it also sparks any ideas for you 😄

IMHO we should match the behavior devicons, over configuration (fzf-lua is already very customizable) can create confusion and customizing icons is better suited for devicons overrides (which fzf-lua should respect).

IMHO we should match the behavior devicons, over configuration

Yep, you're totally right! I just reread the advanced configuration docs and seems like I can make anything happen if I really want to. Well thanks for all your help so far! If there's any way I can continue to help please let me know!

IMHO we should match the behavior devicons, over configuration

Yep, you're totally right! I just reread the advanced configuration docs and seems like I can make anything happen if I really want to. Well thanks for all your help so far! If there's any way I can continue to help please let me know!

Ty @mikeroelens, I’ll give this some more thought and do it sometime next week.

This is gonna take a tiny bit longer as I'm using this as an opportunity for a much bigger refactor of the way devicons (and its highlighting work) in fzf-lua, you can track the progress in the refactor_devicons branch.

@mikeroelens, looks like I'm done with the refactor you're free to give it a run.
I'll do more extensive testing tomorrow and merge it.
A note regarding the logic so that it doesn't impact performance much:
On init, we load all the devicons and split them into different maps:

by_filename
by_ext_2part
by_ext
ext_has_2part

This way the maps are smallers and lookups are faster as a result, the lookup order is as follows:

If path ends in a separator we return a directory icon (only in fzf-lua, devicons has no concept of directory)
Check direct match of the filename within by_filename
Check if extension has an entry in ext_has_2part (for example js would return true here)
If the above returns true we extract the extension prefix (i.e. spec) and test for existence of spec.js within by_ext_2part
Finally, we do a simple lookup of the extension in by_ext

@mikeroelens, this is now merged to main, including your original contribution (https://github.com/ibhagwan/fzf-lua/commit/2ba4a51eb36febd864735b7b25ac2bd1d1f7cf08 - authored by you), closing.


Doc Feedback:

Location : https://apim.docs.wso2.com/en/latest/install-and-setup/upgrading-wso2-api-manager/upgrading-from-310-to-400/
Step 2 - Upgrade API Manager to 4.0.0
Upgrade the WSO2 API Manager database from version 3.1.0 to version 4.0.0 by executing the relevant database script, from the scripts that are provided below, on the WSO2AM_DB database.
Postgres SQL  script  on the table AM_GW_API_DEPLOYMENTS missing vhost filed in table create schema
CREATE TABLE IF NOT EXISTS AM_GW_API_DEPLOYMENTS (
  API_ID VARCHAR(255) NOT NULL,
  REVISION_ID VARCHAR(255) NOT NULL,
  LABEL VARCHAR(255) NOT NULL,
  PRIMARY KEY (REVISION_ID, API_ID,LABEL),
  FOREIGN KEY (API_ID) REFERENCES AM_GW_PUBLISHED_API_DETAILS(API_ID) ON UPDATE CASCADE ON DELETE NO ACTION
);

It should be like below
CREATE TABLE IF NOT EXISTS AM_GW_API_DEPLOYMENTS (
  API_ID VARCHAR(255) NOT NULL,
  REVISION_ID VARCHAR(255) NOT NULL,
  LABEL VARCHAR(255) NOT NULL,
  VHOST VARCHAR(255) NULL,
  PRIMARY KEY (REVISION_ID, API_ID,LABEL),
  FOREIGN KEY (API_ID) REFERENCES AM_GW_PUBLISHED_API_DETAILS(API_ID) ON UPDATE CASCADE ON DELETE NO ACTION
);

@pubudu, please confirm.

Yes, it should be included as in the migration resource scripts [1].
@isharac, just coping this script from migration scripts to docs is right?
[1] https://github.com/wso2-extensions/apim-migration-resources/blob/master/migration-scripts/migration-3.2.0_to_4.0.0/postgresql.sql#L69-L76

yes, we can copy thr table from the dbscript in the migration resources.


API calls fails due to api key not being set

Describe the bug
When following the installation guide, every node will decline all request due to "invalid key" not being provided.
This is due to the typesense-operator-sa not having permission to read the api key form the secrets
To Reproduce
Make a minimal installation

While following the installation guide
Specify default as the namespace when creating resource in ./deploy (will not accept any other namespace because default is hardcoded in rbac.yaml)
Change the namespace in operator-config.yaml to default to match the namespace used in rbac.yaml
Follow remaining steps in the installation guide
Port forward a typesense node to call its api kubectl --namespace default port-forward typesense-0 8108:8108
In another terminal curl the api using the secret key you created (MWYyZDFlMmU2N2Rm in the installation guide)
curl -H "x-typesense-api-key: MWYyZDFlMmU2N2Rm" "http://localhost:8108/collections"

The expected response should be [] but the request will be declined due to the api key being "invalid"
If you look at the operator's logs, you'll see it failing to retrieve the api key. secrets "typesense-apikey" is forbidden: User "system:serviceaccount:default:typesense-operator-sa" cannot get resource "secrets" in API group "" in the namespace "default"
Expected behavior

Requests should return the appropriate payload when making a call with the right key
Typesense operator should be able to access its secrets

Please complete the following information:

Kubernetes version - 1.30.5 (using rancher-desktop)
Typesense version - 27.1
Cloud provider or self-managed? - self-managed

Additional context
Guide & Namespace issues
The guide wrongly suggest the user specify a namespace with every kubectl create while some resources have hardcoded namespaces and will fail to be created if any namespace other than "default" is specified
operator-config.yaml has the namespace typesense hardcoded which will prevent it from working due to default being the namespace used in other part of the codebase.
Ideally no namespace should be hardcoded unless necessary, or at least the guide shouldn't lead the user into messing the installation by specifying the wrong namespace.
Potential Fix
Fixed locally by adding the following ClusterRole and ClusterRoleBinding, I'm not 100% sure its production ready but its a start
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  # "namespace" omitted since ClusterRoles are not namespaced
  name: secret-reader
rules:
  - apiGroups: [""]
    #
    # at the HTTP level, the name of the resource for accessing Secret
    # objects is "secrets"
    resources: ["secrets"]
    verbs: ["get", "watch", "list"]
---
# Grant permission to read api key secret
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: read-secrets
  namespace: default
subjects:
  - kind: ServiceAccount
    name: typesense-operator-sa
roleRef:
  kind: ClusterRole
  name: secret-reader
  apiGroup: rbac.authorization.k8s.io

Hi,
Thank you so much for reporting this. This will be fixed in the upcoming release.

Thank you very much!


Efficiency investigation

I would maybe expect this when throttling is enabled, but I was surprised to see an OOM when it wasn't enabled. This happened when sending a bunch of requests to elasticsearch where both the zipkin server and elasticsearch were in the same container. I've never seen an OOM zipkin side, even with ES_HTTP_LOGGING=basic prior
zipkin                      | 2019-08-17 12:39:26.914  WARN 1 --- [orker-epoll-2-6] c.l.a.c.l.LoggingClient                  : Response: {startTime=2019-08-17T12:39:23.939Z(1566045563939802), length=0B, duration=0ns, cause=com.linecorp.armeria.client.ResponseTimeoutException, headers=[]}
zipkin                      |
zipkin                      | com.linecorp.armeria.client.ResponseTimeoutException: null
zipkin                      |
zipkin                      | Exception in thread "armeria-common-blocking-tasks-1-31" java.lang.OutOfMemoryError: Java heap space
zipkin                      | 	at io.netty.util.internal.PlatformDependent.allocateUninitializedArray(PlatformDependent.java:264)
zipkin                      | 	at io.netty.buffer.PoolArena$HeapArena.newByteArray(PoolArena.java:679)
zipkin                      | 	at io.netty.buffer.PoolArena$HeapArena.newChunk(PoolArena.java:689)
zipkin                      | 	at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:245)
zipkin                      | 	at io.netty.buffer.PoolArena.allocate(PoolArena.java:215)
zipkin                      | 	at io.netty.buffer.PoolArena.allocate(PoolArena.java:147)
zipkin                      | 	at io.netty.buffer.PooledByteBufAllocator.newHeapBuffer(PooledByteBufAllocator.java:325)
zipkin                      | 	at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:168)
zipkin                      | 	at io.netty.buffer.AbstractByteBufAllocator.heapBuffer(AbstractByteBufAllocator.java:159)
zipkin                      | 	at zipkin2.elasticsearch.internal.BulkCallBuilder.write(BulkCallBuilder.java:154)
zipkin                      | 	at zipkin2.elasticsearch.internal.BulkCallBuilder.build(BulkCallBuilder.java:134)
zipkin                      | 	at zipkin2.elasticsearch.ElasticsearchSpanConsumer$BulkSpanIndexer.newCall(ElasticsearchSpanConsumer.java:122)
zipkin                      | 	at zipkin2.elasticsearch.ElasticsearchSpanConsumer.accept(ElasticsearchSpanConsumer.java:62)
zipkin                      | 	at zipkin2.collector.Collector.store(Collector.java:200)
zipkin                      | 	at zipkin2.collector.Collector$StoreSpans.run(Collector.java:229)
zipkin                      | 	at com.linecorp.armeria.common.AbstractRequestContext.lambda$makeContextAware$1(AbstractRequestContext.java:69)
zipkin                      | 	at com.linecorp.armeria.common.AbstractRequestContext$$Lambda$889/0x00000001006a7440.run(Unknown Source)
zipkin                      | 	at com.linecorp.armeria.common.AbstractRequestContext.lambda$makeContextAware$1(AbstractRequestContext.java:69)
zipkin                      | 	at com.linecorp.armeria.common.AbstractRequestContext$$Lambda$889/0x00000001006a7440.run(Unknown Source)
zipkin                      | 	at io.micrometer.core.instrument.AbstractTimer.record(AbstractTimer.java:160)
zipkin                      | 	at io.micrometer.core.instrument.Timer.lambda$wrap$0(Timer.java:144)
zipkin                      | 	at io.micrometer.core.instrument.Timer$$Lambda$897/0x00000001006a3840.run(Unknown Source)
zipkin                      | 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
zipkin                      | 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
zipkin                      | 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
zipkin                      | 	at java.base/java.lang.Thread.run(Thread.java:834)

I'm going to run a comparison before (2.15.0) and after (2.16.1) to see if the memory usage is different. It is probably not a huge deal to OOM if things are timing out anyway, but better to hunt now before we announce, in case it is something small.

here's some charts for a 100s run of brave-webmvc-example against latest docker with 2.16.1 and ES 7 (ES_HTTP_LOGGING=basic)

here's the same run, I only changed the image of zipkin to 2.15.0 leaving the ES image etc exactly the same.

I will now do the same without basic on, just in case something about basic logging is using a lot of memory

this is 2.16.1 with complete defaults, no ES logging.

@anuraaga @trustin can I leave this one to you to look into? I don't want us to do a release announcement saying we did all this stuff to make things efficient with results that seem much worse. It wouldn't be a good reflection on armeria. Probably there's something we are doing that ends up less efficient and slower than before. Since we were using a very late version of okhttp, they had a long time to find all the bugs.  Probably some opportunity to figure out what's up.

and btw in both cases we were using armeria server. the main thing we did was change the elasticsearch client to use armeria vs okhttp. It ended up a lot of work because we also switched things like json codecs from using moshi/okio which shares buffers with okhttp underneath, and also changed a lot of the async behavior. I don't think health check has anything to do with it, but if necessary I could run something with it turned off.

Going to take a look at this. Assuming the graphs are from the normal wrk command against brave-springmvc?
Also just wondering, do you startup both a prometheus and a grafana to get those graphs? Wish it was easier to get graphs when just running locally 😅

Looked a bit, haven't seen any OOM on my computer yet (probably not as limited memory as the container).
One finding is when running 2.15.0 with throttling disabled for comparison, meaning setting  ES_MAX_REQUESTS=1000000000, I could reproduce all requests becoming timeouts right away, with a similar spike in latency (viewing /internal/metrics instead of using Grafana to avoid the steps which would be more precise, I may be misreading the numbers but don't think so).
Will try in the coming days with less extreme loads to see what happens.

I will also take a look once I'm back from Taiwan mid next week.

Quick update from my investigation, it seems that handleAsync(..., ctx.contextAwareExecutor()) adds tens of milliseconds. changing back to handle made the numbers look much more sane.
https://github.com/openzipkin/zipkin/blob/master/zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java#L116
This does not make that much sense to me based on my expectations of how handleAsync would work, but perhaps we need to tweak this to run callbacks inline when on the event loop thread
https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/RequestContextAwareEventLoop.java
Will verify self tracing before sending out a change

ok thanks. this seems like great progress. also that's right about before
we had a semaphore which would have dropped immediately.
wrt the callbacks, if we need to temporarily remove self-tracing that's not
a big deal as few use it. since the cat is already out-of-the bag (we've
already released eventhough not notified with notes etc), any low-hanging
fruit to make sure people have a good experience is much more important
than self-tracing.
On Sun, Aug 18, 2019 at 7:28 AM Anuraag Agrawal<EMAIL_ADDRESS>wrote:

Quick update from my investigation, it seems that handleAsync(...,
ctx.contextAwareExecutor()) adds tens of milliseconds. changing back to
handle made the numbers look much more sane.
https://github.com/openzipkin/zipkin/blob/master/zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java#L116
This does not make that much sense to me based on my expectations of how
handleAsync would work, but perhaps we need to tweak this to run
callbacks inline when on the event loop thread
https://github.com/line/armeria/blob/master/core/src/main/java/com/linecorp/armeria/common/RequestContextAwareEventLoop.java
Will verify self tracing before sending out a change
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/zipkin/issues/2757?email_source=notifications&email_token=AAAPVVYLCQ7ZIIVONMPCHITQFCCQLA5CNFSM4IMPKAJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QVIZY#issuecomment-522277991,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAPVV3AVWTLPNRK3PCE3BTQFCCQLANCNFSM4IMPKAJQ
.

Thanks for the progress, @anuraaga. cc also @trustin Here's the current master vs 2.15.0 on the same burst of 100s in the same docker etc everything. It is much much better than before, as it doesn't end up blocking clients for seconds which could really mess up things.
We should admit our current evolution is still significantly more heap usage, more and longer gcs, and an order magnitude higher p90 response time now vs 2.15 (okhttp based) for the same load. This doesn't mean we enter a pit of work, but I do think we need to at least acknowledge this.
Using zipkin 2.15.0

Using the last commit (verified the actual commit ID from the /info endpoint)

TL;DR; we should probably continue this investigation, or not mention efficiency as a rationale for upgrading during release notes. There are other wins such as load balancing or platform coherency we can still mention, and I know many will be happy to have these features as they were directly requested.

I created an issue to make troubleshooting easier though it isn't hard to start frontend/backend and smack it with wrk (agreed current approach doesn't help in cloud but we aren't using cloud here either) https://github.com/openzipkin/sleuth-webmvc-example/issues/27


Terminology confusing

Based on this article and others, it sounds like the lists, files and content is actually MOVED which would be disastrous from a testing and change management perspective. Even the tool itself uses this language which caused me not to press go.  Is the data actually COPIED or is it MOVED?  Which one?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36d01d11-eea9-7f49-693d-25c3fecc6253
Version Independent ID: 6749a619-2b75-1561-81e9-b45888c58c4b
Content: How to use the SharePoint Migration Tool
Content Source: migration/how-to-use-the-sharepoint-migration-tool.md
Product: sharepoint-server-itpro
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Hi Cloudmaister:
Thank you for pointing this out -- I agree that it is not clear.  I just updated the article (and will look at other topics that also use this phrase) to make it clear.  The content is COPIED.  It is not deleted from the source.
Thanks for the feedback!
Joanne

You guys rock!
Please excuse any typos. Sent from my iPhone
On Jul 23, 2019, at 6:22 PM, JoanneHendrickson <notifications<EMAIL_ADDRESS>wrote:
Hi Cloudmaister:
Thank you for pointing this out -- I agree that it is not clear. I just updated the article (and will look at other topics that also use this phrase) to make it clear. The content is COPIED. It is not deleted from the source.
Thanks for the feedback!
Joanne
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/1193?email_source=notifications&email_token=AID73TGRS5RGMTW2ENUPU7TQA6AB5A5CNFSM4IFZ6YGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2UTJAQ#issuecomment-514405506, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AID73TASWW437LCQFI67ZMLQA6AB5ANCNFSM4IFZ6YGA.


Rename namer kinds

Update to match current conventions:

kind names should not include experimental status
experimental status of a namer must be explicitly acknowledged by setting experimental: true in the namer config
move namers out of io.l5d package

⭐  Great, thanks for updating.

⭐


Fix/node12 multithreaded devices

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Uses latest threadedClass, and resolves errors when running with node12

This is not yet complete. While playout works, there are still some data clone errors/uncaught exceptions logged.

What is the current behavior? (You can also link to an open issue here)
Attempting to run with node12 crashes on startup unless multi-threaded devices is disabled

Other information:
The primary issue is that threadedClass would never be able to pass in getCurrentTime to the child due to it silently failing. This became a fatal error in node 12 and so was noticed.
Part of the problem was that the function was inside an object. This has had to be flattened out to get it to work. However this means that it gets mangled which causes problems for jest (hence some of the commented hacks)

@nytamin I am not noticing any more errors.
I think later on we should rethink some of the TSR device api, once we have worked on strictening up the threadedclass api and figuring out to minimise and easily test for data clone errors

Codecov Report

Merging #129 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    75.84%   75.87%   +0.02%
===========================================
  Files           40       40
  Lines         4132     4124       -8
  Branches       935      886      -49
===========================================
- Hits          3134     3129       -5
+ Misses         963      961       -2
+ Partials        35       34       -1

Impacted Files
Coverage Δ

src/devices/casparCG.ts
70.07% <ø> (ø)
:arrow_up:

src/doOnTime.ts
88.28% <ø> (-0.21%)
:arrow_down:

src/devices/deviceContainer.ts
81.25% <100%> (+6.25%)
:arrow_up:

src/AsyncResolver.ts
78.72% <100%> (-0.45%)
:arrow_down:

src/conductor.ts
83.08% <100%> (-0.01%)
:arrow_down:

src/devices/device.ts
91.83% <100%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85413e...02d8e5a. Read the comment docs.

This needs to be changed to bump the version number more than a patch release.


Update redoc and add DVP Data API doc

Proposed changes

Updates redoc to the latest version
Updates existing Hub API doc to OAPI 3
Adds new DVP Data API doc
Links to DVP Data API doc from the "API Documentation" section
Fixes a bug in URL processing

Pushed some updates. 😄

Could you squash some of the commits, and group them into logical steps? I don't think we should squash all commits down to one, but perhaps something like;

Update redoc to latest version
Update HUB API docs to OpenApi 3
Add separate DVP Data API docs in OpenAPI 3

Squashed down to 4 clearer commits

I think some of the styling issues are just down to how our custom CSS interacts with the new redoc CSS. We can definitely look at improving it, but I don't think there are any functional issues currently.
For reference, this is the "default" styling - https://redocly.github.io/redoc/


No results using in Windows 10

php-cs-fixer package 4.1.1
Atom 1.47.0
PHP (v. 7.3.6) is installed in  Xampp.
php-cs-fixer.phar is v. 2.16.3
Installation of the package in Atom worked OK (it appears in menus etc.), but when I run it I get only this message in console:
php-cs-fixer.coffee:173 c:\xampp\php\php.exe exited with code:<PHONE_NUMBER>
Atom config has this for settings:
"php-cs-fixer":
executablePath: "c:\Users\Nigel\.atom\packages\php-cs-fixer\php-cs-fixer.phar"
phpExecutablePath: "c:\xampp\php\php.exe"
These are definitely the correct file locations.
Can you suggest what I might be doing wrong, or missing?

Sorry, but I have no Windows to test the scenario, but perhaps this might help: https://stackoverflow.com/questions/1138269/apache-error-notice-parent-child-process-exited-with-status-3221225477-res

Thanks for the quick reply. Unfortunately  that link has at least one "did not fix it for me" attached to every "I did this and it worked" :-)  I could spend a lifetime trying all the different possibilities.
However, trying easier random ideas I added a "-n" argument to the setting "Add PHP arguments". This completely excludes the php.ini file. I have no idea why, but it seems to have worked.

Do you have only one php.ini file, for cli and for Apache? Perhaps that’s why!

Yes, it looks like that is the reason. Thanks again for the prompt help.
I shall close this issue.

Solution found.


do you want to rewrite the code in tensorflow or pythorch

There are fewer and fewer people using Theano.So why not consider running in the tensorflow or pytorch?

Simply because we are not maintaining this code. It is not meant to be actually used, but instead it's published such that all details that are unclear (or missing) in the paper can be read in the code by interested people.


Arizona

I'll grab this one if it's still up for grabs.
I'm still trying to get access to the full slack channels after being onboarded - figure I'll make myself useful here and just browse the Trello board while waiting for people to get back from the holidays.
Happy Holidays, Spencer!

OK awesome, thank you. I'll assign you this one!


Is it a good practice to change state in guard block? Is there any alternative?

Generally speaking:
I have 3 states: stateA, stateB, stateC
and one event eventA with attached data dataA
Statemachine is in stateA and receives eventA.
if dataA is valid statemachine should switch to stateB if not it should switch to stateC.
What is best practice for doing it with your library.
Here is my current implementation, but I am not sure that it is a good practice.
[waitingForFirstVideoFrame addHandlerForEvent:ZZMRecordingSessionVideoFrameEvent
                                               target:recording
                                                 kind:TBSMTransitionExternal
                                               action:nil
        guard:^BOOL(TBSMState * _Nullable sourceState, TBSMState * _Nullable targetState, ZZMFrame *videoFrame) {
            BOOL setup = [self startRecordingWithFrame:videoFrame];
            if (!setup) {
                [_stateMachine switchState:sourceState targetState:die action:nil data:nil];
            }
            return setup;
        }];

Thank you in advance.

Oh, I missed Junctions concept. Figured out how to use it properly:
        TBSMJunction *junction = [TBSMJunction junctionWithName:@"Setup Recording Session"];

        [junction addOutgoingPathWithTarget:recording action:nil guard:^BOOL(TBSMState * _Nullable sourceState, TBSMState * _Nullable targetState, ZZMFrame *videoFrame) {
            return [self startRecordingWithFrame:videoFrame];
        }];

        [junction addOutgoingPathWithTarget:die action:nil guard:^BOOL(TBSMState * _Nullable sourceState, TBSMState * _Nullable targetState, ZZMFrame *videoFrame) {
            return YES;
        }];

        [waitingForFirstVideoFrame addHandlerForEvent:ZZMRecordingSessionVideoFrameEvent
                                               target:junction];


Create class Composition that is a composition of a Map and some function

https://en.wikipedia.org/wiki/Function_composition
Map in Java can be viewed as a function from K to V. Functions can be composed. It would be neat to be able to compose a Map and a function. Thus, Composition class:
class Composition<K, V> implements Map<K, V> {
  // ...
}

new Composition<>(
  ImmutableMap.of(
    "dude", 4,
    "man", 3
  ),
  (k, v) -> new Placard(k, v)
); // "dude" -> Placard("dude", 4), man -> new Placard("man", 3)

Composition is a bad name for this class. I'm trying to figure out a better name:
Is there an established name for this operation similar to function composition?

A TransitiveMap sounds like a good name.


I was trying to add extensions. "No access to Extensions Marketplace" When will this be available again?

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:
OS Version:

Steps to Reproduce:

No, I am not aware of having anything disabled.

Solved the issue. Thanks


Unable to pull insiders images as shown on this this page

This page suggests you can do the following to pull insiders image:
# pull nanoserver image
docker pull mcr.microsoft.com/nanoserver/insider
# pull servercore image
docker pull mcr.microsoft.com/windows/servercore/insider

But I get errors:
PS> # pull nanoserver image
PS>  docker pull mcr.microsoft.com/nanoserver/insider
Using default tag: latest
Error response from daemon: manifest for mcr.microsoft.com/nanoserver/insider:latest not found: manifest unknown: manifest tagged by "latest" is not found
PS > # pull servercore image
PS> docker pull mcr.microsoft.com/windows/servercore/insider
Using default tag: latest
Error response from daemon: manifest for mcr.microsoft.com/windows/servercore/insider:latest not found: manifest unknown: manifest tagged by "latest" is not found

Are there even server core insiders images??
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9e029ec8-06e2-c75e-7007-030b69a6ad00
Version Independent ID: 941a16de-c29b-e3af-58f9-5c3b216b2c18
Content: Use Containers with Windows Insider Program
Content Source: virtualization/windowscontainers/deploy-containers/insider-overview.md
Product: windows-server
Technology: windows-containers
GitHub Login: @v-susbo
Microsoft Alias: v-susbo

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.landroid

[ ] [E149] instanceObject common.type has an invalid value: switch
[ ] [E150] No common.connectionType found in io-package.json
[ ] [E152] No common.dataSource found in io-package.json
[ ] [E140] width and height of logo are not equal
[ ] [E504] found setInterval in "main.js, but no clearInterval detected
[ ] [E301] Tests on Travis-ci.org are broken. Please fix.
[ ] [E605] No actual year found in copyright. Please add "Copyright (c) 2018-2021 ldittmar<EMAIL_ADDRESS>at the end of README.md
[ ] [E701] No actual year found in LICENSE. Please add "Copyright (c) 2021 ldittmar<EMAIL_ADDRESS>at the start of LICENSE

Thanks,
your automatic adapter checker.

outdated


Chaining selectProperty methods

Hi, thank you for your great work on EasyBind.
I come from using Tomas Mikula's EasyBind and would like to know how to achieve selectProperty chaining using your latest release (2.20 as of time of writing).
Using Tomas Mikula's version I would write for example the following code:
textField.textProperty().bind(
                    org.fxmisc.easybind.EasyBind.monadic(itemProperty())
                            .selectProperty(Item::thingProperty)
                            .selectProperty(Thing::stringProperty));

Using your implementation, I cannot chain selectionProperty methods. Would the following be the correct equivalent?
textField.textProperty().bind(
                   EasyBind.wrapNullable(
                           EasyBind.select(itemProperty())
                                   .selectObject(Item::thingProperty)
                   ).selectProperty(Thing::stringProperty));

Thank you for you help!
Matthis

This is currently not easily possible. If I understand you correctly, then this is a duplicate of https://github.com/tobiasdiez/EasyBind/issues/10, right?

You are right… sorry I had not read #10 before posting…!


fix for #1656 another solution

another solution (perhaps a better one)

perhaps we could extend this for other properties as well....
It looks like it is not a bad idea to process -Dselenide.anything= the same way as not setting it at all.


mp3 playback not working on Android

Describe the bug
Playback is not working on android for me, on iOS it works great tho. I notice that usePlaybackState is notifying the proper state changes as if the audio were playing but it's not... I'm trying to play an mp3 file that I'm hosting in Amazon S3 and I'm accessing it through CloudFront, so I'm getting the track via HTTPS.
When I tested on a physical device I wasn't able to do much, no particular findings. Still using that same physical device but with debugging turned on, although the app was sluggish all around, it eventually did play the track. Playback started at random moments and stuff so I wouldn't say it worked per se... However, since everything was SO sluggish I wouldn't really pay attention to this.
When I tested on my android emulator I had the behavior I described first and I was able to see this in my logcat:
I/ExoPlayerImpl: Init e29a89b [ExoPlayerLib/2.11.4] [generic_x86_arm, sdk_gphone_x86_arm, Google, 30]
D/RNTrackPlayer: onPause
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onTimelineChanged: 0
    onStop
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onTrackUpdate
    onEnd
D/RNTrackPlayer: onTimelineChanged: 1
    onStateChange
D/RNTrackPlayer: onPause
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onTrackUpdate
D/RNTrackPlayer: onTimelineChanged: 0
    onStop
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onTrackUpdate
    onEnd
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onPositionDiscontinuity: 1
D/RNTrackPlayer: Preparing the media source...
    onPause
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onStop
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onPositionDiscontinuity: 1
D/RNTrackPlayer: Preparing the media source...
    onPause
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onPlay
    Requesting audio focus...
I/VideoCapabilities: Unsupported profile 4 for video/mp4v-es
D/CCodec: allocate(c2.android.mp3.decoder)
I/Codec2Client: Available Codec2 services: "software"
I/CCodec: Created component [c2.android.mp3.decoder]
D/CCodecConfig: read media type: audio/mpeg
D/ReflectedParamUpdater: extent() != 1 for single value type: algo.buffers.max-count.values
D/ReflectedParamUpdater: extent() != 1 for single value type: output.subscribed-indices.values
D/ReflectedParamUpdater: extent() != 1 for single value type: input.buffers.allocator-ids.values
D/ReflectedParamUpdater: extent() != 1 for single value type: output.buffers.allocator-ids.values
D/ReflectedParamUpdater: extent() != 1 for single value type: algo.buffers.allocator-ids.values
D/ReflectedParamUpdater: extent() != 1 for single value type: output.buffers.pool-ids.values
D/ReflectedParamUpdater: extent() != 1 for single value type: algo.buffers.pool-ids.values
I/CCodecConfig: query failed after returning 7 values (BAD_INDEX)
D/CCodecConfig: c2 config diff is Dict {
      c2::u32 coded.bitrate.value = 64000
      c2::u32 input.buffers.max-size.value = 8192
      c2::u32 input.delay.value = 0
      string input.media-type.value = "audio/mpeg"
      string output.media-type.value = "audio/raw"
      c2::u32 raw.channel-count.value = 2
      c2::u32 raw.sample-rate.value = 44100
    }
D/CCodec: [c2.android.mp3.decoder] buffers are bound to CCodec for this session
D/CCodecConfig: no c2 equivalents for flags
D/CCodecConfig: config failed => CORRUPTED
D/CCodecConfig: c2 config diff is   c2::u32 raw.sample-rate.value = 48000
W/Codec2Client: query -- param skipped: index =<PHONE_NUMBER>.
D/CCodec: client requested max input size 4096, which is smaller than what component recommended (8192); overriding with component recommendation.
W/CCodec: This behavior is subject to change. It is recommended that app developers double check whether the requested max input size is in reasonable range.
D/CCodec: setup formats input: AMessage(what = 0x00000000) = {
      int32_t channel-count = 2
      int32_t max-input-size = 8192
      string mime = "audio/mpeg"
      int32_t sample-rate = 48000
    } and output: AMessage(what = 0x00000000) = {
      int32_t channel-count = 2
      string mime = "audio/raw"
      int32_t sample-rate = 48000
    }
W/Codec2Client: query -- param skipped: index =<PHONE_NUMBER>.
    query -- param skipped: index =<PHONE_NUMBER>.
E/FMQ: grantorIdx must be less than 3
E/FMQ: grantorIdx must be less than 3
D/CCodecBufferChannel: [c2.android.mp3.decoder#861] Created input block pool with allocatorID 16 => poolID 17 - OK (0)
I/CCodecBufferChannel: [c2.android.mp3.decoder#861] Created output block pool with allocatorID 16 => poolID 75 - OK
D/CCodecBufferChannel: [c2.android.mp3.decoder#861] Configured output block pool ids 75 => OK
E/ion: ioctl c0044901 failed with code -1: Inappropriate ioctl for device
E/FMQ: grantorIdx must be less than 3
E/FMQ: grantorIdx must be less than 3
D/AudioTrack: getTimestamp_l(57): device stall time corrected using current time<PHONE_NUMBER>2562
D/RNTrackPlayer: onStateChange
I/Choreographer: Skipped 242 frames!  The application may be doing too much work on its main thread.
D/RNTrackPlayer: onTimelineChanged: 0
    onPositionDiscontinuity: 4
D/RNTrackPlayer: onTimelineChanged: 2
    onPositionDiscontinuity: 4
D/RNTrackPlayer: onStateChange
I/OpenGLRenderer: Davey! duration=4052ms; Flags=0, IntendedVsync=45416161661974, Vsync=45420194995146, OldestInputEvent=9223372036854775807, NewestInputEvent=0, HandleInputStart=45420202655562, AnimationStart=45420202715562, PerformTraversalsStart=45420206891562, DrawStart=45420207047562, SyncQueued=45420207738562, SyncStart=45420210353562, IssueDrawCommandsStart=45420210869562, SwapBuffers=45420214186562, FrameCompleted=45420216887562, DequeueBufferDuration=1134000, QueueBufferDuration=1132000, GpuCompleted=45412264316562,
D/BufferPoolAccessor2.0: bufferpool2 0xb9853cc8 : 5(40960 size) total buffers - 4(32768 size) used buffers - 0/5 (recycle/alloc) - 4/435 (fetch/transfer)
D/BufferPoolAccessor2.0: evictor expired: 1, evicted: 1
D/RNTrackPlayer: onStop
I/CCodecConfig: query failed after returning 7 values (BAD_INDEX)
W/Codec2Client: query -- param skipped: index =<PHONE_NUMBER>.
    query -- param skipped: index =<PHONE_NUMBER>.
D/CCodecBuffers: [c2.android.mp3.decoder#861:Output[N]] popFromStashAndRegister: output format changed to AMessage(what = 0x00000000) = {
      int32_t channel-count = 2
      string mime = "audio/raw"
      int32_t sample-rate = 48000
    }
D/CCodecBufferChannel: [c2.android.mp3.decoder#861] MediaCodec discarded an unknown buffer
I/chatty: uid=10161(com.testbuild) MediaCodec_loop identical 2 lines
D/CCodecBufferChannel: [c2.android.mp3.decoder#861] MediaCodec discarded an unknown buffer
I/hw-BpHwBinder: onLastStrongRef automatically unlinking death recipients
D/RNTrackPlayer: Abandoning audio focus...
D/RNTrackPlayer: onStateChange
D/RNTrackPlayer: onPositionDiscontinuity: 1
I/Choreographer: Skipped 240 frames!  The application may be doing too much work on its main thread.
D/BufferPoolAccessor2.0: bufferpool2 0xb9853cc8 : 0(0 size) total buffers - 0(0 size) used buffers - 0/5 (recycle/alloc) - 4/682 (fetch/transfer)
    evictor expired: 1, evicted: 1
W/OkHttp: A connection to http://<IP_ADDRESS>:8081/ was leaked. Did you forget to close a response body? To see where this was allocated, set the OkHttpClient logger level to FINE: Logger.getLogger(OkHttpClient.class.getName()).setLevel(Level.FINE);

What caught my attention was that corrupt config it talks about and the Inappropriate ioctl for device.
To Reproduce
Steps to reproduce the behavior:
Just start playing any track on Android, the bug happens there for me.
Environment (please complete the following information):
Run react-native info in your project and share the content.
System:
    OS: macOS 11.2.3
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 226.87 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.4 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.14.11 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
    Android SDK:
      API Levels: 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.3
      System Images: android-30 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.1 AI-201.87<IP_ADDRESS>42882
    Xcode: 12.4/12D4e - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_282 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.4 => 0.63.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

What react-native-track-player version are you using?
^1.2.7
Are you testing on a real device or in the simulator? Which OS version are you running?

Samsung Galaxy A10 (SM-A105m) running Android 10
Pixel 3A emulator running Android 11.

Code
Please, share the code that is causing the issue
I run this when I tap on the album cover, on iOS that just starts playing the song and I'm using that same code on an older app I made a few months ago using this lib in version 1.2.3.
const onPressCover = useCallback(async () => {
    await TrackPlayer.setupPlayer();
    await TrackPlayer.reset();
    await TrackPlayer.add({
      id: props._id,
      title: props.title,
      artwork: props.coverUrl,
      artist: props.createdBy,
      url: props.taggedFileUrl,
    });
    await TrackPlayer.play();
  }, [props]);

I tried to see if there was an error being emitted but none are being sent over to javascript, it all seems to be failing on the Android realm... I'm using this code to print errors in JS:
useTrackPlayerEvents([TrackPlayerEvents.PLAYBACK_ERROR], (e) => {
  console.log(e);
});

I was able to make this work: I was calling setupPlayer everytime I wanted to play a track, I changed that to calling the method only once and it was magical, it worked.
If that is unintended then I'd look into it, if it's expected I recommend updating the documentation. I could give a hand with that if you guys wanted me to.

This issue is fixed using following code:
const trackState = await TrackPlayer.getState();
if (trackState === 1) {
await trackPlayerInit();
setTimeout(() => {
TrackPlayer.play();
}, 200);
}


Pass hidden field value to dynamicFormData

if jquery.uploadfile.min.js file, i modified the function by assign value to hidden field:
function u(e, a) {
       if (e) {
           a.show();
           var t = new FileReader;
           t.onload = function (e) {
               // image processing algorithm
                .
                .
                .
                .
               // assign value 12345 to hidden field
               $('#hidID').attr('value', "12345");
               a.attr("src", e.target.result)
           }, t.readAsDataURL(e)
       }
   }

Then I use dynamicFormData to pass the hidden field value to php:
dynamicFormData: function () {
    var data = {postcode: $("#hidID").val()};
    return data;
},

But I get empty value for $_POST['postcode']. How to I get my hidden field value within onload? Thanks

i think $("#hidID").val() is empty. can you check that . ?
can you share me your URL ?

Sorry, I can't share the URL to you due to privacy. Yes, the $("#hidID").val() is empty. What I want is update the hidden field value dynamic and pass to another page during upload image. dynamicFormData seem only pass the value which static in docement.ready function. How do I pass the dynamic value during upload image?

Plugin has Two options.
1).formData - static
2).dynamicFormData - dynamic
Check the demos
On Thursday, March 31, 2016, howardhee<EMAIL_ADDRESS>wrote:

Sorry, I can't share the URL to you due to privacy. Yes, the
$("#hidID").val() is empty. What I want is update the hidden field value
dynamic and pass to another page during upload image. dynamicFormData seem
only pass the value which static in docement.ready function. How do I pass
the dynamic value during upload image?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/hayageek/jquery-upload-file/issues/97#issuecomment-203721753

Yes, I am using dynamicFormData based on my code, but the post value is empty, please try assign a value to hidden field like me in jquery.uploadfile.min.js, then use dynamicFormData to post the value. See whether is empty. Thanks

I tested this many times , working good.
Can you Create a sample code and share me the URL ? Or js fiddle ?
On Thursday, March 31, 2016, howardhee<EMAIL_ADDRESS>wrote:

Yes, I am using dynamicFormData based on my code, but the post value is
empty, please try assign a value to hidden field like me in
jquery.uploadfile.min.js, then use dynamicFormData to post the value. See
whether is empty. Thanks
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/hayageek/jquery-upload-file/issues/97#issuecomment-203739176

Here is my demo link: http://2-dot-com-gavesoft-weddingchat.appspot.com/test2.php
my test2.php code as below:

        <link href="https://rawgithub.com/hayageek/jquery-upload-file/master/css/uploadfile.css" rel="stylesheet">

Upload

        <input type="hidden" name="hidpostcode" value="" id="hidID">

I modified the function in "jquery.uploadfile.min.js" by added one line "$('#hidID').attr('value', '12345');"
        function u(e, a) {
            if (e) {
                a.show();
                var t = new FileReader;
                t.onload = function (e) {
                    $('#hidID').attr('value', '12345');
                    a.attr("src", e.target.result)
                }, t.readAsDataURL(e)
            }
        }

My test3.php code as below:
<?php

if (isset($_FILES['chatsidefile'])) {

    $postdata = $_POST['postcode'];
    $data = array();
    $data['postdata'] = array($postdata);

    echo json_encode($data);
}

As you can see the alert post value is empty.

You are assigning the $('#hidID').attr() at wrong place.
The value is assigned after the request is sent. Do this.
1). Upload a file and you get the empty response.
2). Upload one more(without refreshing the page) file, you get the response value 12345.
You need to assign the $('#hidID').attr() value before sending the request.
onSelect() callback is fine.
One more thing, don't modify minified code, you can get the source code from here.
https://github.com/hayageek/jquery-upload-file/blob/master/js/jquery.uploadfile.js

my code required FileReader, can you show me where should I put my code?

I am not getting your requirement , what is the value you want to put ?
What is the need of that ?
On Thursday, March 31, 2016, howardhee<EMAIL_ADDRESS>wrote:

my code required FileReader, can you show me where should I put my code?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/hayageek/jquery-upload-file/issues/97#issuecomment-203760407

I want to pass the image dataURL to test3.php instead of file. Below is code I put inside onload function, So I required FileReader to read the upload image to generate the dataURL.
function u(e, a) {
            if (e) {
                a.show();
                var t = new FileReader;
                t.onload = function (e) {
                    var image = new Image();
                    image.onload = function () {
                        var canvas = document.createElement("canvas");

                        var x = 0;
                        var y = 0;
                        var iwidth = image.width;
                        var iheight = image.height;
                        var newwidth;
                        var newheight;
                        var maxframe = 1280;
                        var ratio = 0;
                        if (maxframe && (iwidth > maxframe || iheight > maxframe)) {
                            ratio = iwidth / iheight;

                            if ((ratio >= 1 || maxframe == 0)) {
                                newheight = maxframe / ratio;
                                newwidth = maxframe;
                            } else {
                                newwidth = maxframe * ratio;
                                newheight = maxframe;
                            }
                        } else {
                            newwidth = iwidth;
                            newheight = iheight;
                        }

                        canvas.width = newwidth;
                        canvas.height = newheight;
                        var ctx = canvas.getContext("2d");
                        ctx.save();
                        ctx.drawImage(image, x, y, newwidth, newheight);
                        ctx.restore();

                        var dataURL = canvas.toDataURL("image/jpeg", 0.75);
                       // pass the dataURL
                        $('#img64base').attr('value', dataURL);
                    };
                    image.src = e.target.result;

                    a.attr("src", e.target.result)
                }, t.readAsDataURL(e)
            }
        }

why you want to pass dataURL ? what is the difference between dataURL & FILE ?
dataURL is base64 of image data;

please don't modify in minified code, use the source code.
https://github.com/hayageek/jquery-upload-file/blob/master/js/jquery.uploadfile.js

dataURL seem faster?

don't do that.   you are sending two files for every file upload.
one actual file($_FILES['chatsidefile']), other one is base64 of it($_POST['postcode'])

Alright, thanks for your help.


gh-pages refactor

Does stuff outlined in #1714.
No content changes, just reorganizing things.

btw this is an alternate implementation to #1726... only:

no actual content changes. grammar and stuff are left alone.
no marked-toc
syntax highlighting is still client-side

demo for now: http://ricostacruz.com/mocha

I won't have time to look at this in more care until later tonight, but big :+1:! The css issue in #1726 seems to not be present on your demo (which is great), and no changes to grammar etc only helps in making it more modular and easy to merge.

toc looks exactly like how it is now, not the nested version in #1726

No worries, I believe this is a bug due to style.css somehow not being applied (even though it's loaded, haven't figured out the root cause yet), so you're version is right :)

@jbnicolai what's the CSS issue in #1726?

to note, this is fully incompatible with #1726, so it's one or the other

just a subtle nudge... any updates? :)

I like the idea of merging this, and later pulling copy/doc changes from https://github.com/boneskull/mocha/blob/jekyll/index.md
For example, I like that this PR doesn't change the table of contents. For comparison:
http://boneskull.com/mocha/#table-of-contents
http://ricostacruz.com/mocha/#table-of-contents

@danielstjules I don't think anybody's going to take the time to extract my copy changes.  honestly I didn't expect anyone else to submit a PR for this, which is why I did it the way I did.
The current ToC is missing stuff and needs to be maintained manually.

@rstacruz going to close this in lieu of #1777, please continue conversation there


Unit testing (PHPUnit)

#112 got me thinking that unit tests wouldn't be a bad thing to have.
This contains the basic setup along with tests for:

Pokemon::isDeployed()
Pokemon::canEvolve()
Pokemon::canUpgrade()

(Tell me if I did things wrong with the mocks)

src/Api/Pokemon/Support/PokemonDetailsTrait.php
update this:
 if ($this->getCandies()->getCount() < $data->getCandyToEvolve()) {
to this:
 if ($data->getCandyToEvolve()>0 && $this->getCandies()->getCount() < $data->getCandyToEvolve()) {

Clean use of generators and data providers 👍 . I really want one of those Abras on steroids ;)

ah right, what about the new attacks introduced by niantic this night?

@f2008305 Feel free to update the https://github.com/NicklasWallgren/PokemonGoAPI-PHP/blob/master/src/Api/Pokemon/Data/PokemonMetaRegistry.php with the latest changes.


Custom pronunciation?

This link states that E2 TTS can explicitly specify the pronunciation of the word (IE sake spelled as (S AA1 K EH0)). How do I do that?
https://www.microsoft.com/en-us/research/project/e2-tts/

Sry that this feature is not supported currently.
It requires to train with a random replacement of words to phonemes, and need force-align to take care of the data.


Disable menu on the wallet integration page

Menu still shows hover states and animations and allows user to click, but the links don't work and there's no feedback from system as to why they're not working.
Few solutions:

Disable the menu into a disabled state, like the greyed out menu in the Figma file
Remove the menu entirely and allow full screen for the wallet selection
Provide feedback message on click that menu won't work until wallet is selected

I would recommend a combination of option 1 and 2, which keeps the menu but has all of the links in a disabled state. The context a menu provides let's a user know what is in the dApp, whereas if we just have the wallets it doesn't give any clues as to what the dApp does (besides the name Token Dashboard).
However like in option 3, there should still be some indication from the system why those links aren't working. I think having the cursor turn to disabled icon and a note that reads something like "Please choose a wallet first."
Screenshot from https://dashboard.test.keep.network/ -->

Figma file screenshot of disabled menu:

https://www.figma.com/file/Su61MwHLrQn3ld24q85pMx/Token-Dashboard-dApp?node-id=3096%3A0


Component docs second edits

closes #777

@joshwooding looks like the vertical nav fails in the preview, just like it did when we looked at the error before. any ideas?

fixed, it was a missing "

Maybe a smaller PR next time please....


Address DH end-of-epoch feedback

Current dependencies on/for this PR:

feature/proof-of-stake

PR #831

PR #871   👈

This stack of pull requests is managed by Graphite.


Bump lib to 0.29.1

We should bump the lib in core to fix the incorrect classification of ElectricScale.PULSE_COUNT that's fixed in #283 (we can save adding support for the gas device class for later) improve the UnknownValueData exception message #284 to reduce the number of tickets that could get opened as a result of seeing this message in the logs
Because of the refactor to constants, this dependency update will be a bit of work on the core side but it shouldn't be too bad

@MartinHjelmare so are we good to merge here?


Typo fix in zetcd/README.md

Line 27: "an  zetcd deployment"->"a  zetcd deployment"

/assign @scottrigby


Fix empty file failing to clone on Windows

When I clone, I have the following error:
Cloning into 'AAWirelessDongle'...
remote: Enumerating objects: 582, done.
remote: Counting objects: 100% (51/51), done.
remote: Compressing objects: 100% (28/28), done.
Receiving objects:  98% (571/582)sed 36 (delta 20), pack-reused 531Receiving objects:  97% (565/582)
Receiving objects: 100% (582/582), 89.29 KiB | 3.57 MiB/s, done.
Resolving deltas: 100% (279/279), done.
error: invalid path 'aa_wireless_dongle/board/raspberrypi0w/rootfs_overlay/.empty '
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Note the space after .empty.
BTW: Many thanks for this project, it works like a charm on my Peugeot 208 !

Thanks for this, don't know how did I miss the space in filename earlier!