[Bug] - The Python DoOutputsTuple force Tagged PCollection to is_bounded=True

Hello,
When you apply a beam.Partition on a unbounded PCollection, the tagged PCollections from DoOutputsTuple have is_bounded=True.
Normally, if the source is unbounded then the Pcollections from partition are unbounded too, no ?
https://github.com/apache/beam/blob/bc06581e11085d02a52356681226ee8caac5a825/sdks/python/apache_beam/pvalue.py#L307

Hello,
A workaround waiting for support response :
# The Taggedoutput have to have same is_bounded state like the source
initial_get_item = DoOutputsTuple.__getitem__

def new_get_item(self: DoOutputsTuple, tag: int | str | None):
    tag_not_in_pcolls = tag not in self._pcolls

    pcoll = initial_get_item(self, tag)

    if tag_not_in_pcolls:
        assert self.producer is not None
        pval = self.producer.parts[0].outputs[None]

        # pass bounded state
        pcoll.is_bounded = pval.is_bounded

    return pcoll

DoOutputsTuple.__getitem__ = new_get_item

Re-create with report issue template https://github.com/apache/beam/issues/29196


sparkR command does not work

I downloaded docker-spark images via docker pull command and run it with
docker run -it sequenceiq/spark:1.4.0 bash

After that, I found "sparkR" was already in /usr/local/spark/bin.
I wanted to try it ant got the following result:
bash-4.1# sparkR
env: R: No such file or directory

It seems that we have to write "install R" like commands in docker file.
Do you have any plan to install R in this docker image in the near future?
(Is it possible for me to write that and make a PR to this rpeository?)

Thanks for the fix.

Hi,
I've been facing the same issue i.e. while trying to run the command ./bin/sparkR it gives me the error:
env: R: No such file or directory
Could you please help to resolve the issue.
Regards,
Neeraj


Add @tisvictress to Buildpacks approvers

I'm a current member of the buildpacks team and have been contributing to buildpacks since 2017. Additionally, the current approvers @ryanmoran, @arjun024, and @brayanhenao can all confirm that I meet that qualifications for approval.

CC @Gerg


How to use a package in R which has two types of outputs(data and image) using Stored procedure in SQL and display the same as in screenshot from R-studio in SQL

How to use a package in R which has two types of outputs(data and image) using Stored procedure in SQL and display the same as in screenshot from R-studio in SQL

Sorry - best to post this is in a help chat. This is a place to enter bugs on the courses on this site. Thanks!


AJV Example Validation Fails for Nested $refs

Describe the bug
When linting with rules no-invalid-schema-examples or no-invalid-media-type-example enabled and having nested $ref tags in properties, a schema with key or id <pointer> already exists error will be thrown.
To Reproduce

Given the following files:
test.yaml

openapi: 3.1.0

info:
  title: Example API
  version: v1

servers:
  - description: Server
    url: https://domain.com

components:
  schemas:
    id:
      type: string
      format: uuid
    UserType1:
      type: object
      properties:
        id:
          $ref: '#/components/schemas/id'
          description: User ID
        anotherId:
          $ref: '#/components/schemas/id'
          description: Another ID
        name:
          type: string
      required:
        - id
        - name
    UserType2:
      type: object
      properties:
        id:
          $ref: '#/components/schemas/UserType1/properties/id'
        anotherId:
          $ref: '#/components/schemas/UserType1/properties/anotherId'
        age:
          type: number
      required:
        - id
        - age
      example:
        id: 9f5668cd-c3a3-4024-985c-2489715b2cb8
        age: 21

paths:
  /test:
    get:
      summary: Test
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/UserType2'

.redocly.yaml
apis:
  test:
    root: test.yaml
    extends:
      - minimal
    rules:
      no-invalid-schema-examples: error
      no-invalid-media-type-example: error
      info-license: off
      operation-operationId: off
      security-defined: off
      no-unused-components: off

Run redocly lint test
See error: Example validation errored: schema with key or id "test.yaml#/components/schemas/id" already exists.

Expected behavior
Nested $ref tags should not cause errors on validation.
Redocly Version(s)
1.0.0-beta.113
Additional context
The error seems to occur in core/src/rules/ajv.ts during loadSchemaSync. I was unable to find any documentation or references to loadSchemaSync. I assumed it was a custom function being used in Redocly's fork of ajv, but I still couldn't find any references in that repo either. Regardless, it seems to be creating a schema with a duplicate $id because it will resolve nested references to the same base schema. There needs to be some kind of cache to avoid loading the same schema multiple times: https://ajv.js.org/guide/managing-schemas.html#caching-schemas-in-your-code.

Hi @jd014. Thanks for reporting the bug. We will take a look.

I think the bug has been already fixed (works on 1.25.0 as expected).
@jd014 please let me know if the issue is still there for you.


read config from some way、unit test example、rename something、update R…

What type of PR is this?
/kind feature
What this PR does / why we need it:
more some way for reading config、unit test example、rename something、update README.md
Special notes for your reviewer:
./base/servicehub/examples
Reivewers List:
@liuhaoyang
Does this PR introduce a user-facing change?

Additional documentation usage docs, etc.:

@recallsong: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@recallsong: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind feature
What this PR does / why we need it:
more some way for reading config、unit test example、rename something、update README.md
Special notes for your reviewer:
./base/servicehub/examples
Reivewers List:
@liuhaoyang
Does this PR introduce a user-facing change?

Additional documentation usage docs, etc.:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: recallsong
To complete the pull request process, please assign luobily after the PR has been reviewed.
You can assign the PR to them by writing /assign @luobily in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: liuhaoyang, recallsong
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [liuhaoyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Incorrect toolset detection blocks clang-tidy from completing

Unable to use the current version of Clang Power Tools (4.5) as the incorrect detection of the platform VS2013 XP toolset breaks the ability for clang-tidy to complete its analysis.
All our projects use either the VS2013 or VS2013 XP toolsets.
VERBOSE: Platform toolset: v120_xp
VERBOSE: Switching to VS2015 because of v140 toolset. Reloading project...
Because of this switching, the include paths are not correct for VS2013 XP toolset, and therefore a required include in our project cannot be found
X:******\stdafx.h(18): error: 'afx.h' file not found [clang-diagnostic-error]
This prevents clang-tidy from performing any further analysis, and resulting in this being the only error/warning being detected.

Hi,
Can you attach a sample project reproducing the issue ?

This is probably linked to #450, the VS120 toolset will not be used in the current versions.

Hello,
This issue should be fixed as consequence of #525, which has been released with Clang Power Tools v4.8.
We've retried Clang Compile and Tidy using your sample project and everything appears to be OK now.


Updating result files for P100, TitanXP & 1080Ti

DeepBench_NV_P100_Trg_CUDA_8_0_88.xlsx
DeepBench_NV_TitanXp_Trg_CUDA_8_0_88.xlsx
DeepBench_NV__1080Ti_Trg_CUDA_8_0_88.xlsx

@dibasc , Thanks for submitting results to DeepBench. Happy to accept these results but I'd request a couple of changes:

Can you rename the files to follow the standard format? P100 results would be DeepBench_NV_P100.xlxs. We don't include the CUDA version or Trg keyword in the filename. We only include one results file per processor to avoid confusion. So, these results would replace the existing results file in the results/train directory.
Can you confirm the precision for Fp16 sheet in the P100 results spreadsheet? Currently, the precision is mentioned as Float.
The All reduce results are missing from the P100 results. You don't need to rerun them. You can simply copy them from the existing DeepBench_NV_P100.xlxs file since this change doesn't impact the all reduce results.
It would be great if you can include results on the TitanX Pascal as well. It would keep all the Pascal processors results at the same CUDA and cudNN versions.

DeepBench_NV_1080Ti.xlsx
DeepBench_NV_P100.xlsx
DeepBench_NV_TitanXp.xlsx
Renamed the files to the correct format.  Also, included description for P100 FP16 sheet to match.  Will upload the TitanX Pascal data when I have it ready.

Could you update the PR as well? The PR still shows three additional files. Instead, you can replace the existing files in the repo.

LGTM, merging


modified install- and advanced-options description for using yarn ins…

…tead of npm
yarn is the new way of managing javascript packages. It is much faster than with npm and saver. Also it is not much effort to use yarn instead of npm and all new Laravel projects come with a yarn.lock file...
I think it is worth a look.
Just take a look at the inital post about yarn or at the hompeage

@Naoray Thanks for proposing this change, I'll pull this down and take a look at it. Looks pretty simple though so I'll merge it in soon. 👍


Korean translation for chapter 2

Locally checked rendering using zola :smiley_cat:

CI indicates there are some broken URLs (from both the original post & the translation posts)

I will try to find a reviewer for this translation by posting a message to the Discord chat of Korean Rust users' group.

Thanks a lot for the translation @JOE1994! Any luck with finding someone to review it?
@QuqqU Maybe you could take a quick look?

Thanks a lot for the translation @JOE1994! Any luck with finding someone to review it?

Unfortunately not yet 😢
It seems like people are busy with final exam preps, other  ongoing projects, etc..

Ok, no problem. If we don't find anyone within the next week, I will add it to "call for participation" section of the next "This Month in Rust OSDev" issue.

I think I can do it until this weekend!
I couldn't review it quickly because I had a lot of work to do this month, but it's almost over.

@QuqqU Thank you so much for your time and valuable feedback! Your feedback was very helpful :+1:

I squashed the commits into a single commit, and I think this PR is now ready to be merged.

Awesome, thanks a lot!

Published at https://os.phil-opp.com/ko/minimal-rust-kernel/


artifact code extraction cannot split within lines.

Your code:
a = 1; b = 2; d= 4; print(a); c = a + b
c_art = lineapy.save(c, "test multiple lines")

Issue: the code for c_art includes the entire line: a = 1; b = 2; d= 4; print(a); c = a + b
It's probably lower priority to slice within a line, but just flagging that this is a known issue.

additional test for for-loop cases
import lineapy
a = 1
b = 0
for i in range (4): b = b + 1; print('Added 4 times'); d = 3;
c = a + b

c_art = lineapy.save(c, "test multiple lines")

@eunminlee thanks for adding your thoughts! Curious if this syntax is something you use often at work? Curious so we can gather evidence for prioritization.
Thanks!

@yifanwu I never use this syntax. In my opinion, ";" shouldn't be used in python.

Haha that's good to hear. We'll then continue to de-prioritize the feature support because of how uncommon the syntax is.


include brew info  with brew desc if applicable

I like seeing all the information about a package that the brew info command displays, so right now I have a command in my ~/.bash_profile that looks like this:
brewinfo() { brew info "$1"; brew desc "$1"; } # get all information on a brew package.

This is not breaking or critical, but would be a nice touch if it could be added to features like the brew desc search.

:+1: In general.
:+1::+1: On adding description to the formula DSL.

Yup. I really need to carve out time this summer and make this happen. Maybe I'll figure out a way to rope a few other people into the work.

@telemachus I'd be happy to help! I might need a few days to catch up on the history and all you've done so far, but next week my schedule's fairly empty. I don't know how this project just completely slipped my radar until now!
Its kind of funny, I've actually been using a vaguely similar subcommand, something that I've been calling brew tagline, a script a wrote a while back. Here it is (cleaned up a bit for public consumption):
#!/bin/sh # brew-tagline

## Make sure we have an argument. The subcommand can be called anything.
[ $# != 1 ] && echo "Usage: $(basename $0 | tr - ' ') FORMULA" && exit 1

home="$(brew info $1 2>/dev/null | grep '^http')"   ## Grep the homepage.
[ $? = 1 ] && echo "$1: No such formula." && exit 1 ## If it exists.

## Then we're just grabbing what's in the <title> tag and cleaning it up.
title=$(curl -Lks "$home" | xmllint --html --xpath //title - 2>/dev/null |
                                        tr '\n' ' ' |  sed 's|<[^>]*>||g')
[ "$title" ] && echo $title || echo $1

It fails to produce anything meaningful maybe a third of the time, but when it works, it's actually fairly comparable in a lot of cases (go, lua, llvm, gcc are good examples).
I bring it up mainly because something along these lines might be a halfway decent way to try to automatically populate a description for brew create ...?

I just wrote up a script, moved the descs into the relevant formulas, and updated audit.rb, info.rb, and formula.rb to match. Should I send a PR to Homebrew? I might add a comment here, or something:
https://github.com/Homebrew/homebrew/issues/32517

@adzenith wow, thanks for all that work! I believe that you would also need to write a sub-command for brew to handle brew desc invocations. That said, the code for it should be pretty simple.
Do you have a publicly available repo with the updated Homebrew formulas? If so, I'd be very happy to play with it as well.

Yup! Just pushed it. I guess I was thinking that you wouldn't use desc anymore because it's in the info now, but I could also add a desc command if you like.
https://github.com/adzenith/homebrew

Oh, and I wasn't sure where to put the script that moves the descriptions, so I haven't checked it in yet.

@adzenith Could you gist your script for me (in case I end up needing to adjust it)?
As for the material being in brew info, that's great, but it's only part of what brew desc does. In addition to getting information on specific items (à la brew info), brew desc allows you to search for packages by name and description (and in a forthcoming branch, you can search by name or description, too). So we would need a command for that.
I'd be happy to do the work of writing the subcommand, though help is always welcome.

How do you feel about just adding that to brew search?
Right now it will display the desc; do you think that's enough to send a PR?

How do you feel about just adding that to brew search?

I think that's probably smarter than a separate (new) subcommand, now that you mention it.

Right now it will display the desc; do you think that's enough to send a PR?

Very likely, but let's get some more people involved.
Paging @mistydemeo , @jacknagel @mikemcquaid -- are we ready to consider bringing brew desc into the DSL?

I made a new branch on my fork and just checked in the script. It uses relative paths s you have to run it in place.
https://github.com/adzenith/homebrew/blob/add-desc/Library/Formula/add-desc.py

(also swiftlint and xtail don't have descriptions yet; I believe those are the only two Homebrew/homebrew formulae missing a desc)

I added a first pass of searching through the descriptions. Try brew search --desc something or brew search --desc /regex/. I think it's probably clear from the code that I normally write Python and not Ruby, so please feel free to make it better.

Thanks. I'll take a look. I'll likely need to tweak it to handle the updated options for brew desc (which are still only in a branch in the brew-desc repo itself).

Yeah, I mean, it's pretty basic right now—just a proof of concept. It would be nice if it were integrated into the non-desc searching a little bit more (imagine a future where you could search the descs of taps!).

(imagine a future where you could search the descs of taps!).
:+1:

The nice thing, I think, is that if/when it gets pulled into master, then searching taps should be a snap. All it would require is that tap maintainers add descriptions to their formulas. Everything else should JUST WORK (TM).

are we ready to consider bringing brew desc into the DSL?

I would be very happy to do so!

Awesome! I made a PR here: https://github.com/Homebrew/homebrew/pull/39911
Can we move discussion over there?


Create Summoner Component Checklist

Thinking this was resolved with the audit, right?

Yup. I think so


fix #55

PULL REQUEST
Overview
Fix "updated _ ago" in the Dapp card not updated correctly
Fixed by using the addedOn of the last item added to the skylinks list
Example for Visual Changes

Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

[ ] All new methods or updated methods have clear docstrings
[ ] Testing added or updated for new methods
[ ] Verify if any changes impact the WebPortal Health Checks
[ ] Approriate documentation updated
[ ] Changelog file created

Issues Closed
#55

Any update? Its a simple fix, should not break anything

Check failed because at deploy (siasky.net network error) not because it had a build error

The base branch requires all commits to be signed. Learn more about signing commits.

Do I need to sign them or can you do that too?

Do I need to sign them or can you do that too?

I can't do that for you, you will need to set up commits signing yourself and rebase the pull request so that the commits are rewrtitten I think. If this is too much I can just create new pull request myself with your change. Let me know.

Okay I'm not quiet sure how to rebase this PR, but I now have setup git to sign my commits from here on.
I think for this PR it'd be easier if you just apply the changes manually/in a new pr and close this one.


429 Too many request while translating

I tried to translate https://aws.amazon.com/tw/ to English and see a lot of 429 Too Many Requests errors from AWS API in the console.
Cloud we do something slightly "smart" like only translating visible (within the viewport, see https://stackoverflow.com/a/41698614) elements first, then slowly translate other part of the page with rate limiting?

Yes, I think that idea has been proposed in this issue: #25


https://semver.io is now sunset

This project has been deprecated since 2019 (#69), and the Heroku instance of the project is due to be switched off shortly.
As such, any consumers of https://semver.io, https://www.semver.io or https://semver.herokuapp.com should migrate to another solution, or host their own version of the site using the source here.
If you are using a buildpack and are getting semver.io related errors - you are likely pinned to an outdated version tag of a buildpack, or using an unmaintained fork. Switch to an official/maintained buildpack instead:
https://devcenter.heroku.com/articles/buildpacks#officially-supported-buildpacks

The semver.io service has been sunset, and the DNS entries will be removed shortly.


Update bricked my module.

Update bricked my module. I'm going to have to reflash the firmware with the previous. We couldn't get the dump to work and the previous update didn't work via the SD if you remember, you sent me the update in the form of a complete firmware HEX.

No, it didn't brick it :)
What has happened is that it right now has some extra overlays in the firmware FWX file and this file has to be present on the SD card all the time.
So you need the_centre_v3.fwx on the SD crad.

And rename it?
That's what caused it.
I've reflashed it with the HEX you gave me for the previous update.

Current FW. 0.61.40, doesn't update with it named the_centre_v3 but if I rename it it results in the above photo...

Please download the_centre_v3.fwx and put the file twice on SD-card. Once name it the_centre.fwx and once with original name. It should work. The file the_centre_v3.fwx must remain on the SD Card inside SD card slot all the time. Some units (like your) are older version without extra SPI memory which means the firmware must be loaded from card all the time.
So again, keep two files. Same version.

As discussed. Problem solved :) Closing.


Generated types clash and fail to compile

I've got the following WSDL spec which fails to compile with
gensrc/oil/salesorderv201901/definitions/ProductLineItemUpdateOrderRequest.ts:1:33 - error TS1149: File name 'gensrc/oil/salesorderv201901/definitions/ProductLineItem.ts' differs from already included file name 'gensrc/oil/salesorderv201901/definitions/ProductLineitem.ts' only in casing.
SalesOrder_v201901.txt

Any new on #46 ? Have any maintainers went through this ?

I have a similar situation where the wsdl-tsclient CLI made duplicates :

Any idea how I could fix this ?

I ended up just manually adding aliases for the clashing names, like:
export { WebPaymentApi as WebPaymentApiService } from "./services/WebPaymentApi";
export { WebPaymentApi as WebPaymentApiPort } from "./ports/WebPaymentApi";

Same in the services/WebPaymentApi.ts file (alias for port).
I don't mind that much as I only have one service and my wsdl is quite stable. But would be nice if the the tool would detect those kind of duplications itself - or at least provide a standardized way to provide aliases. It seems like it's not very unlikely that a real-life wsdl would result in duplications like that...
If it would bother me more and/or I had the time, I might try to fix it myself with a pull request...

If fixed this using a JS script that patches the files after having generated the code. It's more of a workaround than a real fix of the wsdl-tsclient library.
I can share the script if you want to. I used regular expressions to find and replace the duplicates.
const lServiceExportRegEx = /export { ([A-Za-z]*) } from ".\/services\/\1";/gm;
const lPortExportRegEx = /export { ([A-Za-z]*) } from ".\/ports\/\1";/gm;
const lPortImportRegEx = /import { ([A-Za-z]*) } from "..\/ports\/\1";/gm;
const lServiceInterfaceRegEx = /readonly ([A-Za-z]*): \1;/gm;

const lServiceSubValue = `export { $1 as $1Service } from "./services/$1";`;
const lPortSubValue = `export { $1 as $1Port } from "./ports/$1";`;
const lPortImportSubValue = `import { $1 as $1Port } from "../ports/$1";`;
const lServiceInterfaceSubValue = `readonly $1: $1Port;`;

Still an issue for us


Deployment template keyvalut prefix limited to 20 characters

Attempting to re-deploy the shared v4-australiasoutheast resource group on Azure causes the following error as the prefix is limited to 20 characters, yet v4-australiasoutheast is 21 characters.
########## Deploying rp-development-predeploy in RG v4-australiasoutheast ##########
Azure Error: InvalidTemplate
Message: Deployment template validation failed: 'The provided value for the template parameter 'keyvaultPrefix' at line '1' and column '300' is not valid. Length of the value should be less than or equal to '20'. Please see https://aka.ms/arm-template/#parameters for usage details.'.
Additional Information:
	Type: TemplateViolation
	Info: {
	    "lineNumber": 1,
	    "linePosition": 300,
	    "path": "properties.template.parameters.keyvaultPrefix.maxLength"
	}

Where:
KEYVALUT_PREFIX=v4-australiasoutheast
@mjudeikis

If redeploying (why?) you should be using KEYVAULT_PREFIX=v4-australiase.


Bitmap from Picasso is very slow

When dragging and zooming the image that has been loaded with Picasso (and I think is in memory) is very slow.
The zooming occurs with big steps and is very shockery. The dragging also shocks alot.
I don't think this is how it is supposed to be :-P

I am using Glide, and it works very fast. Try it

@va I think that switching to Glide costs more time than fixing the slow dragging problem. Could you send an example URL of your image? I fetch mine from Unsplash.com

If you're displaying large images by providing a bitmap, the view can't do subsampling and you may get poor performance. Please see https://github.com/davemorrissey/subsampling-scale-image-view/wiki/X.-Using-with-Picasso

@vavan4567 can u show Glide's code? Thanks


Immersive Application Laggy after deployment

Overview
The application works very smoothly in Unity, however, after it's been deployed and is run through the Mixed Reality Portal there is noticeable delay and FPS loss.
Expected Behavior
Should run smoothly as any other immersive application, i guess?
Actual Behavior
Runs much slower compared to when it was run in unity
Steps to reproduce
followed  the steps for deployment here https://github.com/Microsoft/MixedRealityToolkit-Unity/blob/master/GettingStarted.md
Unity Editor Version
unity v3.0.f3
Mixed Reality Toolkit Release Version
toolkit v2.1.3

Probably you selected Debug configuration, try Release or Master

Unable to repro with the above repro steps. Double checking that your configuration isn't set to Debug (as described above) is a good place to start. Closing as no repro.


Popup notification not "click-through"

Possible to lose focus from game by clicking into notification, need to make it not focusable/click-through.

Resolved in #13


Feat/ displays gateway balance command so that it displays token balances by network rather than dex

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

[ ] introduced a new class to create and get data from json file used  to save chain_network for gateway connector_tokens completer
[ ] refactored balance to Get balances from chain_network
[ ] remove unused Parameters and functionalities
[ ] refactored the balance and connector_token display for chain_network feature

Tests performed by the developer:

[x] connected chain and network ✅
[x] ran gateway connector_tokens successfully ✅
[x] gateway command balances displayed as proposed ✅

Tips for QA testing:

@nikspz working on gateway connector_tokens currently

A) Currently connector-tokens not showing in total balance if added
Steps:

connected quickswap_polygon_mainnet and uniswap_polygon_mainnet
Added different connector-tokens for polygon_mainnet
check gateway balance

Actual:
Not showing both tokens added
Expected:
Please modify the gateway connector-tokens command so that it accepts chain_network instead of exchange_chain_network
2023-12-05 15:30:56,912 - 2225040 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: not enough values to unpack (expected 2, got 1)
Traceback (most recent call last):
  File "/home/nikita/gwbalance2chains/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/home/nikita/gwbalance2chains/hummingbot/client/command/gateway_command.py", line 633, in _update_gateway_connector_tokens
    conf: Optional[Dict[str, str]] = GatewayConnectionSetting.get_connector_spec_from_market_name(chain_network)
  File "/home/nikita/gwbalance2chains/hummingbot/client/settings.py", line 121, in get_connector_spec_from_market_name
    connector, network = market_name.split(f"_{chain}_")
ValueError: not enough values to unpack (expected 2, got 1)

B) I guess we should change from Exchange to Chain_Network

I think its ready for a review now @nikspz @fengtality

@isreallee82
A) Expected:
drop-down list for chain_network available (polygon_mainnet ethereum mainnet etc), as previously available for exchanges

B)
Expected:
Please modify the gateway connector-tokens command so that it accepts chain_network instead of exchange_chain_network

a min @nikspz checking that currently

I see! I have to make few modifications battery is down should push in few hours

hi @nikspz @rapcmia my discord was hacked yesterday and used to send spam messages but I already reset all keys and removed all unauthorised applications, but currently I can't access hummingbot discord channel, is there anything I can do about that

@isreallee82 check now


Access error when make launch

CARLA version: 0.9.15
Platform/OS: Ubuntu 20.04
Problem you have experienced:
This is the log.

It should be a network error. But the strange thing is this link is 404 Page not found now. Amd yesterday when I run make launch it does not have this problem. I check the Plugins folder in carla and StreetMap does exist. What might be the problem? Does carla need to access this link everytime running make launch?

What you expected to happen:
Tell me what's happening.
Steps to reproduce:
No idea. Just run make launch.

Another strange thing. Although I can not access this link in web browser, I can access it by git clone.

Repository is still there https://github.com/carla-simulator/StreetMap
Try again

Repository is still there https://github.com/carla-simulator/StreetMap Try again

Thank you very much for your reply! I delete my carla folder and remake another one, it works again. But I'm confused that each time I run make launch, it will try to access ths Repo. If I do not connect to internet, make launch won't work. Is this normal? I'm new to Carla, it is kind of wierd that I can not run UE editor if I do not have internet connection.

Our build system is not the best one. We are open to contributios while dealing with other stuff. Sorry for inconveniences


Why dont you add a shortkey for open folder?

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:46:46.244Z)
OS Version: Linux x64 4.4.0-45-generic
Extensions:

Extension
Author
Version

python
donjayamanne
0.5.0

Lua
keyring
0.0.8

cpptools
ms-vscode
0.9.2

Steps to Reproduce:

Should be ctrl+o on Linux, the default open action (workbench.action.files.openFileFolder) which opens both – files and folders.


Parsing sentence into constituents.

There can still be diverse topics in one sentence, and a way of resolving this is to split sentences into constituents.

Check this for the difference between constituency and dependency parsing: https://www.baeldung.com/cs/constituency-vs-dependency-parsing

The result seems to be a bit anti-intuition. The dependency parser actually works better in most of the cases.
Check this: https://github.com/EyeofBeholder-NLeSC/orange3-argument/blob/dev_bert_miner/notebooks/sentence_parser.ipynb


Scenes in picture-elements cant be activated via the tap_action: toggle

Right now it seems not to be possible to activate a scene within picture-elements without the details popup, which should be not needed for easy use.

Scenes are not toggle-able.

yes thats the problem, so there could be another tap_action entry, like "activate", or an autodetect, that a scene cant be toggled, so it should just decide by its own to activate it instead.


Deployment does not create runner

Describe the bug
I had an EC2 instance with GitLab runner which stopped working. So, I attempted to simplify redeploy the stack that contained the runner; however, no runner is created after the stack has been redeployed.
When logging into the instance using ec2 connect, there are no docker containers running.
To Reproduce

Deploy construct
Deployment succeeds
No GitLab runner is created

Expected behavior
Runner is created
Additional context
Created using Python CDK using the following arguments:
from cdk_gitlab_runner import GitlabContainerRunner

...
        runner = GitlabContainerRunner(
            self, 'gitlabRunner',
            gitlabtoken=gitlab_token.string_value,
            ec2type='t3.small',
            concurrent_jobs=3,
            tags=[],
            runner_description='Group Runner',
        )

After attempting to reproduce the same steps done by the user data, I got this error:
Unable to find image 'public.ecr.aws/gitlab/gitlab-runner:alpine' locally
docker: Error response from daemon: manifest for public.ecr.aws/gitlab/gitlab-runner:alpine not found: manifest unknown: Requested image not found.

Checking the ECR gallery it does indeed appear to be missing.
Changing the GitLab runner image to public.ecr.aws/gitlab/gitlab-runner:alpine3.15-v15.5.2 appeared to resolve the issue.
        runner = GitlabContainerRunner(
            self, 'gitlabRunner',
            gitlabtoken=gitlab_token.string_value,
            gitlab_runner_image='public.ecr.aws/gitlab/gitlab-runner:alpine3.15-v15.5.2',
            ec2type='t3.small',
            concurrent_jobs=3,
            tags=[],
            runner_description='Group Runner',
        )

Thanks for reporting this.
Let's pick a tag from
https://gallery.ecr.aws/gitlab/gitlab-runner, that is less likely to be replaced.

hi @bobveringa.
I replaceed public.ecr.aws/gitlab/gitlab-runner:alpine with public.ecr.aws/gitlab/gitlab-runner:latest.
 docker manifest inspect public.ecr.aws/gitlab/gitlab-runner:latest
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 898,
         "digest": "sha256:a91ed0eb759b758a95156e2d43042cdae15c7c456f270dbc21c9590c0bf99a69",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 898,
         "digest": "sha256:d605d5dc17273bf5601d112961a96d7740638fc87422d913c82e647a9edc242b",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 898,
         "digest": "sha256:b55a22dd6bc02a910e6f5a9d6f223b2a23bf2f79b230ee1cac397d664e53a0cd",
         "platform": {
            "architecture": "ppc64le",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 898,
         "digest": "sha256:dd35e1e92b6509bb58cb668e6dcd420d2a6e7e319f0dac35dba97d705138aa16",
         "platform": {
            "architecture": "s390x",
            "os": "linux"
         }
      }
   ]
}


Fixes paths for code of conduct

While browsing the .NET Fringe site I noticed that the code of conduct link 404ed in some cases.

@thoward and I are checking it out, thanks @jeremyabbott!   👍


Wrangler timeout in WSL2

🐛 Bug report
Describe the bug
The wrangler CLI timeout every time it tries to interact with the Cloudflare API.
It is similar that issue #1614 but applied to all commands
Reproduce the bug
A list of steps to reproduce the bug.

Open WSL
Open https://dash.cloudflare.com/ in default browser
Run wrangler login
After been authenticated run wrangler whoami

Logs from my execution
 RUST_LOG=debug wrangler whoami
[2021-10-09T21:32:46Z INFO  wrangler::settings::global_config] No $WRANGLER_HOME detected, using $HOME
[2021-10-09T21:32:46Z INFO  wrangler::cli::whoami] Getting User settings
[2021-10-09T21:32:46Z INFO  wrangler::settings::global_config] No $WRANGLER_HOME detected, using $HOME
[2021-10-09T21:32:46Z INFO  wrangler::settings::global_config] Using global config file: /home/smoser/.wrangler/config/default.toml
[2021-10-09T21:32:46Z INFO  wrangler::settings::global_user] Config path exists. Reading from config file, /home/smoser/.wrangler/config/default.toml
[2021-10-09T21:32:46Z DEBUG wrangler::login] Refreshing access token..
[2021-10-09T21:32:46Z DEBUG reqwest::connect] starting new connection: https://crates.io/
[2021-10-09T21:32:46Z DEBUG reqwest::connect] starting new connection: https://api.cloudflare.com/
[2021-10-09T21:33:16Z DEBUG wrangler::version] could not determine if update is needed:
    error sending request for url (https://crates.io/api/v1/crates/wrangler): operation timed out
Error: ⚠  Error: error sending request for url (https://api.cloudflare.com/client/v4/user): operation timed out

Expected behavior
Expect the wrangler to finish the commands with sucesss
Environment and versions
Fill out the following information about your environment.

operating system: Windows 10 - with WSL2 using Distro Ubuntu 20.04
output of wrangler -V:wrangler 1.19.3
output of node -v:v14.17.6
content of wrangler.toml:

Can confirm this happens to me too

I saw different reports on issues and forums every month since 2020.
This doesn't seem to be fixed soon (many issues reported with this has been closed with no real solution)
the only way now seems to be installing node for windows, set up wrangler there, and navigate to the directory of the app in linux through powershell

This is weird, but it fixed it for me:
I set up the DNS of my wifi to the Cloudflare provided DNS. But the IPv6.
And now it works. might worth your try whoever reads that in the future

It is really mind-blowing, I set up the Cloudflare DNS in my system IPv4 and IPv6 and just start work

@Moser-ss  I see you closed the issue, but the bug is still here :(
Using the Cloudflare DNS is not an option for me, and I guess that is true ffor many other environments as well... Therefore not a fix :/

Struggling with this unreproducible bug for weeks and now, after setting all my DNS (both ip4 and ip6) to Cloudflare, everything works smooth as butter.
This must go into the docs or fixed asap. @kentonv, who is the right person for this issue?

I don't know anything about this issue, but just from the comments, it sure sounds like something is wrong with your regular DNS provider, like it is returning the wrong result for api.cloudflare.com. This is probably not an issue the Workers team is positioned to fix, but it would help if you could tell us what DNS provider you are using and what IP it is returning for api.cloudflare.com.
With that said, this issue is on Wrangler v1. We released Wrangler v2 more than a year ago and strongly recommend that everyone upgrade. Does the same bug happen in Wrangler 2? If so, maybe you should file a new issue on https://github.com/cloudflare/workers-sdk .

Thanks for the quick reply. I've posted the issue here https://github.com/cloudflare/workers-sdk/issues/3411
This bug is a major dealbreaker for WSL2 users if they aren't aware of the DNS hack.


Size Cost of Single Package and Dependencies

I removed the rounding from my function. I figured it would be better not to round when performing consecutive calculations for dependencies because of the loss in precision. Instead, I waited to round until the end in the controller. I also made it round to 1 decimal place instead of 2 decimal places because that is what his examples seemed to do

Let me know if there are any issues or you prefer how it was before!


Invisible and minuscule typo in fraud

@patriciorocca This typo was displayed in the blog; amazingly surpassing @GervasioCalderon 's filter 😛
All else is fine. LLG

@jdemonasterio : Puede fallar (no translation available for Tusam).

LGTM


Support or plugin for JWT (Json Web Tokens)

Hi,
I didnt find any plugin or way to use guzzle with JWT, i mean, with renew token mechanism when JWT ttl expires. Is planned to support this in the future? or there are a simple way to do this?
thanks

Hi. Guzzle does not have any direct JWT support, but it could be done using a middleware to sign requests as needed. That said, this feature will not be added to Guzzle.


TOO_MANY_SIMULTANEOUS_QUERIES from tableau

I get the following from myTableau server and/or Tableau client connecting to the clickhouse when refreshing a tableau report.
Error executing subquery id: "4553"
Code: 202. DB::Exception: Too many simultaneous queries. Maximum: 15. (TOO_MANY_SIMULTANEOUS_QUERIES) (version <IP_ADDRESS> (official build)) , server ClickHouseNode(addr=http:xxx-clickhouse-default-1.core.xxxx.com:443, db=default)@1273894842
Connector Class: clickhouse_jdbc, Version: 0.2.6
Is there a way to throttle how many connections are made at the JDBC (client) level?  to avoid this limitation on the clickhouse server? It seems it should be possible to pass JDBC option to throttle how many QUERIES run ?

Tableau (Server) set the native_api.connection.globallimit to 16 by default
(though it could be overwritten by setting the native_api.connection.limit.clickhouse_jdbc to a lower value):
https://help.tableau.com/current/server-linux/en-us/cli_configuration-set_tsm.htm

Thanks for the quick reply. I saw this option in general web searches but the key is unknown.
I had to use --force-keys in order to get this to go through. Is this correct/expected? It seemed to have added it but then when I try to query it it's not showing anything?
tsm configuration set -k native_api.connection.limit.clickhouse_jdbc -v 4
Configuration error: At least one configuration value you specified does not match a known configuration key. This applies to the following keys: '[native_api.connection.limit.clickhouse_jdbc]'
Known keys:
native_api.node_limit_checker_disable
native_api.connection_ip_blacklist

Use this parameter to override unknown key error: --force-keys

So I used --force-keys:
tsm configuration set -k native_api.connection.limit.clickhouse_jdbc -v 4  --force-keys

And this appeared to work???
But tsm configuration get in various incantations doesn't seem to show this key has actually been set?

tsm pending-changes list
If any exists then
tsm pending-changes apply

This seems to have fixed it. Thanks for the quick help!!!

You're welcome.

This works great for the Tableau server but if I download the workbook and edit it locally in tableau desktop I still get this error? Is there a way to set native_api.connection.limit.clickhouse_jdbc=4 for tableau desktop?

Unfortunately, not.

One more thing that you may want to try (if curious and have a spare time):

Make a copy of the clickhouse_jdbc.taco file, rename it to be clickhouse_jdbc.taco.zip
then unzip to the ~/My Tableau Repository/Connectors/clickhouse_jdbc folder.

Edit the manifest.xml file to change the customisation option on the row 15 to be like this:
     <customization name='CAP_JDBC_QUERY_ASYNC' value='yes'/>

start Tableau Desktop in the terminal, with the flag allowing for non-signed taco:
/Applications/Tableau\ Desktop\ 2023.2.app/Contents/MacOS/Tableau -DDisableVerifyConnectorPluginSignature=true

Hope this may help. If not, please reply (frankly, I have no idea what else one could do with the Desktop).


Panic compiling a memory operation with fuel and nonstandard configuration

This input module:
(module
  (func
    (local i32 i64)
    local.get 0
    i64.load8_s offset=2147483631
    local.set 1
  )
  (memory  1 1)
)

will fail to compile with:
$ cargo run compile testcase0.wat --fuel 0 --static-memory-maximum-size 538976288
...
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `2`,
 right: `0`', crates/cranelift/src/func_environ.rs:388:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cc @fitzgen as bisection shows that this was a regression from https://github.com/bytecodealliance/wasmtime/pull/5386

Thanks! Looking into it.


CSCFAIRMETA-368: Fix indexing logic for PAS datasets.

PAS datasets should only be searchable in etsin if they are not created from
another dataset and if the preservation_state is 120.
In both the reindexer and in the rabbitmq consumer check theese conditions
with the utils functions: catalog_record_is_pas_catalog, get_catalog_preservation_state
catalog_has_preservation_dataset_origin_version
Effects PAS dataset searchability in etsin.

For testing of the PR see https://wiki.eduuni.fi/display/cscetsin/PAS+datasets+in+Etsin
The most important factor to check "PAS datasets should only be searchable in etsin if they are not created from another dataset and if the preservation_state is 120."
Before testing The elasticsearch index should be reindexed to remove the datasets that don't fit the description above (ALSO check that the reindexing actually removes them!).
Reindexing:
In your local environment, inside the vagrant box run the following commands as etsin-user:
source_pyenv
python /etsin/etsin_finder_search/reindex.py


Define testTarget

Add the ability to define a TestTargetID for a test target.
You can already set the TEST_TARGET_NAME build setting but that doesn't change the "Host application" in the Xcode UI without a TestTargetID target dependency

This could also automatically be done by setting the TestTargetID attribute if a test target has a target dependency that is an application

TEST_TARGET_NAME is now automatically set in 1.2.2 if a ui test target has a target dependency that is an application


Unable to update literature to Notion

Thank you for your hard work on this add-on.
I suddenly encountered a problem these days.
When I was in zotero use, everything is normal, adding the new literature, have appeared in the synchronous Notero popup window, but when I returned to the Notion, found no update this literature.
Would you please take a look at this question? Thank you very much

Hi @zny3108, thanks for reaching out.
Does the Notero popup (see below screenshot) still show up? Does it show any error message, or does it show the green checkmark like in the screenshot?

Thank you for your reply.
These diagrams are all show up, and everything is fine in Zotero, and there were no errors reported. The only change is that there is no update in Notion.
I also double-checked if the Notion is updated to when I change folders in Zotero, which is also fine.
I'm at my wit's end now.

Hmm very strange! Let's try something... If you create a new database in Notion, connect it with Notero, and update the database ID in the Notero preferences, are you able to sync items into that new database?

It Notero again, thank you very much for your advice.
Although the previous issues have not been fixed, but I can start taking notes again.
Finally, thank you again. Your answer and your work on this add-on have greatly improved my learning efficiency.
Thank you.

I've got some new cues for you.

It has embedded the address to jump to notion in zotero:

I clicked on the address and found that it did appear on the correct page, namely that it was saved in Notion

But when I go back to the bibliographic page, it's gone, it's not recorded here

Strangely, I found it here, and when I clicked "move to", it was there.

But I don't see it in the superior menu("private")

Do you have any new idea? Please tell me

The possibility occurs to me that it is not a problem with the error reported, but rather that I cannot see the latest addition at the top of the template because of a sorting error in Notion? How do I reset the sort?

Now I can confirm the problem: it is normal to import the literature, but the imported new literature is not at the top of the table of the template, so I did not find it at the beginning.
Do you have a way to restore the sorting problem when importing new documents?

Hi @zny3108, thanks for the additional info!
Something you can try is to add two more properties to you Notion database. There are two special types of property called Created time and Last edited time. If you add those to your database, you can then use them to sort the pages in your database. For example, if you sort by Last edited time in descending order, then whenever you sync an item from Zotero into Notion, it will show up at the top of your database.
Can you let me know if that helps?

Yes, you're right.
Although I am not sure why this is the case, your answer solves my question.
Thank you very much.


GUACAMOLE-289: Allow extensions to provide their own REST services.

This changes adds a getResource() function to both AuthenticationProvider and UserContext which can return an arbitrary REST service annotated with JSR-311 annotations (JAX-RS). The resource returned by AuthenticationProvider is available without authenticating with the extension, while the resource returned by UserContext implicitly requires authentication (there would be no UserContext instance to return it otherwise).

For reference, getResource() provides the following behavior:

Class
Authenticated?
Resource URL

UserContext
Yes (implicitly)
.../api/session/ext/IDENTIFIER/

AuthenticationProvider
No
.../api/ext/IDENTIFIER/

where "IDENTIFIER" is the identifier of the authentication provider.


Implement phone number analyzer

Description
this is largely based on elasticsearch-phone and internally uses
libphonenumber.
this intentionally only ports a subset of the features: only phone and
phone-search are supported right now, phone-email can be added
if/when there's a clear need for it.
using libphonenumber is required since parsing phone numbers is a
non-trivial task (even though it might seem trivial at first glance!),
as can be seen in the list falsehoods programmers believe about phone
numbers.
this allows defining the region to be used when analysing a phone
number. so far only the generic "unkown" region (ZZ) had been used
which worked as long as international numbers were prefixed with + but
did not work when using local numbers (e.g. a number stored as
+4158... was not matched against a number entered as 004158... or
058...).
example configuration for an index:
{
  "index": {
    "analysis": {
      "analyzer": {
        "phone": {
          "type": "phone"
        },
        "phone-search": {
          "type": "phone-search"
        },
        "phone-ch": {
          "type": "phone",
          "phone-region": "CH"
        },
        "phone-search-ch": {
          "type": "phone-search",
          "phone-region": "CH"
        }
      }
    }
  }
}

this creates four analyzers: phone and phone-search which do not
explicitly specify a region and thus fall back to ZZ (unknown region,
regional version of international dialing prefix (e.g. 00 instead of
+ in most of europe) will not be recognised) and phone-ch and
phone-search-ch which will try to parse the phone number as a swiss
phone number (thus e.g. 00 as a prefix is recognised as the
international dialing prefix).
note that the analyzer is (currently) not meant to find phone numbers in
large text documents - instead it should be used on fields which contain
just the phone number (though extra text will be ignored) and it
collects the whole content of the field into a String in memory,
making it unsuitable for large field values.
closes opensearch-project/OpenSearch#11326
Signed-off-by: Ralph Ursprung<EMAIL_ADDRESS>Related Issues
Resolves #11326
Check List

[ ] Functionality includes testing. TODO: do some (more) manual testing
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable. -- TODO if general PR is ok

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

❕ Gradle check result for f7669e2: UNSTABLE
* **TEST FAILURES:**

      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

this is a flaky test: #14304

this should now be ready for review :rocket:
CC a couple of people who were involved in the discussions (in no particular order):
@reta (for the things we discussed on slack about Strings & Streams)
@msfroh (i now ended up not using RemoveDuplicatesTokenFilter as using a Set internally remains much simpler and means that the tokenizer already returns unique tokens plus i ran into the error first position increment must be > 0 (got 0) for field 'phone' while trying to get it to work)
@dblock
@timsmithgenesys (as discussed in #11326 this is based on the old ES plugin from your company - thanks again for licensing it as Apache 2.0! ❤)
@macohen (originally pointed out the old ES plugin)

Thanks! Probably @msfroh is our best reviewer for this.

Thanks @rursprung , I feel strongly that we should have it under separate plugin (analysis-phonenumber fe) and keep the analysis-common clean (not everyone needs this functionality)

@reta: i put it in analysis-common based on @msfroh's comment here: https://github.com/opensearch-project/OpenSearch/issues/11326#issuecomment-2334939361 (seconded also by @dblock). i'm happy to move things around if this is the general consensus but would like to avoid doing that a few more times :)

@reta -- do you mean a separate plug-in in a separate repo? Or just a separate plug-in in the core repo?
In my opinion, the overhead of maintaining a separate plugin build/distribution is not worth it for a single analyzer class of ~20 lines.

separate plug-in in the core repo?

Thanks @rursprung , yes, I mean a separate plug-in in the core repo (under plugins), it is indeed small enough.

@reta: i put it in analysis-common based on @msfroh's comment here: #11326 (comment) (seconded also by @dblock). i'm happy to move things around if this is the general consensus but would like to avoid doing that a few more times :)

My apologies @rursprung , I missed that but would have commented there. If folks think analysis-common is the place - no objection (but in my option, it does not belong here, the phone numbers are relevant to small percentage of the applications and is not common case).

Between analysis-common and a separate plugin in this repo, I don't have strong opinions. I definitely agree that it's not likely to be widely used, so a separate plugin in this repo gives people the choice to install it if they want it.

wouldn't the separate plugin in this repo cause quite a bit of overhead for the release process? (i'm not familiar with that part but would presume that it'd have to be patched in at several places to make sure that it gets published?)
having it in analysis-common would have one major benefit for me: it'd become available on all public cloud offerings (once they upgrade to that release) - and i need it on at least some of them 🙂.
also, i don't think that it's a less common use-case than many other analyzers currently in the analysis-common package and my gut feeling (without having done a market survey) is that it'll be used once it's available (and communicated) since there are many use-cases where you're ingesting phone numbers, e.g. as part of contact data (true, you might not need this for a web shop).

wouldn't the separate plugin in this repo cause quite a bit of overhead for the release process? (i'm not familiar with that part but would presume that it'd have to be patched in at several places to make sure that it gets published?)

No, we build and release the core as a whole

having it in analysis-common would have one major benefit for me: it'd become available on all public cloud offerings (once they upgrade to that release) - and i need it on at least some of them 🙂.

It would be the same plugin as any other bundled with core and installable with opensearch-plugin tool. analysis-common is a module which means you cannot install it, what it or not. For example, assume there is CVE published against libphonenumber. The mitigation with plugin is easy - uninstall it till fix available, with module it is impossible.

It would be the same plugin as any other bundled with core and installable with opensearch-plugin tool. analysis-common is a module which means you cannot uninstall it, want it or not. For example, assume there is CVE published against libphonenumber. The mitigation with plugin is easy - uninstall it till fix available, with module it is impossible.

you say "bundled" - does that mean that it'll be part of the standard (or even min?) opensearch distribution by default if it's a plugin in this repo and it can just optionally be uninstalled rather than being something which has to be installed explicitly?

it's a plugin in this repo and it can just optionally be uninstalled rather than being something which has to be installed explicitly?

it would be a plugin which is not installed by default, has to be installed and uinstalled explicitly

it would be a plugin which is not installed by default, has to be installed and uninstalled explicitly when there is a need to use it.

oh 🙁
well, i guess it's the same as an external plugin with the advantage that it's in this repo, making maintenance easier (releasing & publishing happens out of the box).
so, is it the final consensus of the reviewers that i should move it to a new analysis-phonenumber plugin within this repo? if so, i'll take care of it next week

so, is it the final consensus of the reviewers that i should move it to a new analysis-phonenumber plugin within this repo? if so, i'll take care of it next week

+1 from me, thanks @rursprung

i've done the move and now just need to make some checks happy (namely the javadoc one; it seems to ignore some things in common but not here) and give it another manual test spin and then we should be good to go. just pushed it so that you can have a first look as i don't expect to change the business logic of it anymore (hasn't changed since the last push either)

i've done the move and now just need to make some checks happy (namely the javadoc one; it seems to ignore some things in common but not here) and give it another manual test spin and then we should be good to go. just pushed it so that you can have a first look as i don't expect to change the business logic of it anymore (hasn't changed since the last push either)

Thanks @rursprung , the plugin should be under plugins folder, the modules are plugins that are installed by default, As far as I remember, we concluded that this plugin is optional (opt-in).

It looks great, thanks @rursprung a few things left:

could you please add YAML tests for analyzer itself (fe analysis-icu/src/yamlRestTest/resources/rest-api-spec/test/analysis_icu/20_search.yml)
please create a documentation issue for 2.18.0 release to document this new analyzer (https://github.com/opensearch-project/documentation-website/)

Thank you.

namely the javadoc one; it seems to ignore some things in common but not here

turns out that check is excluded for most existing plugins, so that's why it didn't fail there 😅:
https://github.com/opensearch-project/OpenSearch/blob/e8b02c9545d7908ae1a3ea2d109c06ff3e0c07a5/gradle/missing-javadoc.gradle#L109
as discussed on slack i've now added the new plugin to that list as well as the check is overzealous (details also in the commit-msg)

Thanks @rursprung , the plugin should be under plugins folder, the modules are plugins that are installed by default, As far as I remember, we concluded that this plugin is optional (opt-in).

ah, i didn't spot that yet. moved it now.
should now be ready for review! (the previous failure seems like a false reject; i just rebased now, hopefully it goes away by itself)

sorry, missed your comment before :(

could you please add YAML tests for analyzer itself (fe analysis-icu/src/yamlRestTest/resources/rest-api-spec/test/analysis_icu/20_search.yml)

does this add any benefit over the java-based test? or should i even replace the java-based test with this one?

please create a documentation issue for 2.18.0 release to document this new analyzer (https://github.com/opensearch-project/documentation-website/)

if everything (names of analyzers, index setting, etc.) is ok for you then i can do this (just wanted to avoid having to get it updated several times)

does this add any benefit over the java-based test? or should i even replace the java-based test with this one?

it gives a good example of how the analyzer could be used (+ very consistent with the test anaylsis-* suites)

if everything (names of analyzers, index setting, etc.) is ok for you then i can do this (just wanted to avoid having to get it updated several times)

Sure, this is just an issue (not a documentation update), so docs team knows that new features will be added to the release, there is no need to create a pull request now

❌ Gradle check result for f1dffe9: FAILURE
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

flaky test: https://github.com/opensearch-project/OpenSearch/issues/16109

does this add any benefit over the java-based test? or should i even replace the java-based test with this one?

it gives a good example of how the analyzer could be used (+ very consistent with the test anaylsis-* suites)

i'll update it next week

if everything (names of analyzers, index setting, etc.) is ok for you then i can do this (just wanted to avoid having to get it updated several times)

Sure, this is just an issue (not a documentation update), so docs team knows that new features will be added to the release, there is no need to create a pull request now

done: https://github.com/opensearch-project/documentation-website/issues/8389

does this add any benefit over the java-based test? or should i even replace the java-based test with this one?

it gives a good example of how the analyzer could be used (+ very consistent with the test anaylsis-* suites)

i'll update it next week

i've now added the test.
note that the analysis-icu example is probably not particularly good since it's testing with a french text, thus not testing the ICU part at all 😅

@rursprung thank you, could you please resolve the conflicts?

@rursprung thank you, could you please resolve the conflicts?

done (let's hope it stays mergeable for longer this time!)

@rursprung apologies, mind please sending a manual backport to2.x branch? thank you

@rursprung apologies, mind please sending a manual backport to2.x branch? thank you

no worries, done: #16187
i'm a big fan of having a changelog, but it's causing a lot of merge conflicts here 🙁
i've seen another repo (don't remember which, but i have a vague feeling that it was even in the opensearch org?) which had a subfolder where you created one file per PR for the changelog and some automated tooling then collected all of that together and merged it into the main changelog file for the release (and deleted the other files). maybe that might be an idea here as well to avoid the merge conflicts? might be worth discussing in a separate issue (which should probably come from someone regularly contributing to this repo as you'll be much more affected by this issue than me)?
on another note: squash-merging destroys my nice atomic commits 🙁
i get that you do that for PRs where people just add a ton of "fix review finding" commits, but for the proper (linux kernel style ;)) PRs where you force-push to have a nice linear commit history with atomic commits, each with a nice commit message) i think this is a big loss (and makes it harder to find the actual culprit with tools like git-bisect and git-revert)

might be worth discussing in a separate issue (which should probably come from someone regularly contributing to this repo as you'll be much more affected by this issue than me)?

Please feel free to open an issue or kick off discussion!

on another note: squash-merging destroys my nice atomic commits

The clean repo history is useful, but this is a tradeoff for sure


Orchard.Azure.MediaServices module updates

Upgraded Azure Media Services legacy components (like the encoder and presets)
Included Azure Media Player v<IP_ADDRESS> for the video playback experience
Added support to auto-configure the Orchard.Azure.MediaServices module (Media Services and Storage credentials) based on application settings
Added new 'Video Portal' recipe (based on 'Default' recipe) to enable Orchard.Azure.MediaServices module
Improved Setup experience to avoid asking for connection string if it's already available in the application settings

@mconverti,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.
It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@mconverti, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

@sebastienros regarding the AMS recipe, we are not familiar with the Orchard CMS build process and we currently ran out of cycles to apply this improvements. Perhaps you can handle this change with your team.
Thanks!

We can close this PR and issue due to #8759.


Error to configure a report in grafana

Describe the issue
I have configured the reporter service in a linux centos, it generates the demo report without problem, however following the documentation I have created a variable in my report.

I have created the variable as a constant and as a text and I have entered the name of the grafana dashboard.
The link configuration in the dashboard grafana it is.

When Running it shows me the following error

Application call
I do the application call as shown

Environment (please complete the following information):

OS [e.g. Windows 10]:
Grafana version [e.g. 6.3.4]: 9.0.2
Environment [e.g. source, gem, docker or windows-exe]: gem
Ruby Version, if source or gem environment [e.g. 2.3.7]: ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux]
Reporter version [e.g. 0.3.0]: lastest

How do I be able to call the report for each one of the dashboards? Is there a portal with examples? I just followed the github documentation.
Thanks

Thanks for using the reporter.
So, it looks like, you try to have a variable in your dashboard, which points to the reporter template name. In your configuration, you point to a template named ˋVMwarevSphere_Overviewˋ, but obviously this file does not exists, as you can see in the log entries.
The ˋtemplateˋ variable has to point to the template file name, not to the dashboard. If you want to configure a template for a dashboard, you have to simply use the functions, e.g. ˋgrafana_sql_tableˋ with the option ˋdashboardˋ etc., to configure it properly.
I strongly recommend digging deeper in the wizard template file, which should make thinks a bit clearer.
Feel free to get back in case of questions.

hello. i did the same but got the same error. now i understand the problem is the lack of a template file.
that being said how do i make this template file and what can i include in it to make it render the graphs in my grafana web view?
sorry if this has already been answered somewhere else.

Try creating a report template as described here: https://github.com/divinity666/ruby-grafana-reporter?tab=readme-ov-file#quick-start
Then you should be able to render that template with the reporter.
After that succeeds, you should be able to go through the template file and create your own, or adapt the demo report as needed to get to the desired result.

Closing because of missing feedback.


highlight URL variable

Is it possible to add a highlightURL variable in the template to render links to each highlight, i.e, clicking on the link opens the webpage in Raindrop to view the highlight in context?

No, it's currently impossible. Raindrop API does not provide the anchor point information of the highlight.


Switch order of period compare and rolling periods to enable using both together in Advanced Analytics

Very small and specific bug around using Advanced Analytics in Line Charts.
There is unexpected behavior when using both Rolling and Period ratio in conjunction.  Based on the code (https://github.com/airbnb/superset/blob/master/superset/viz.py#L1190-L1215), all we do is compute the period ratio however specified, then do rolling windows thereafter. This is pretty counter-intuitive. Basically, when I select rolling sum of 7 days and period compare of 1, it gives me a time series that sums those factors (it will be ~7, and not anywhere near 1)! Which is not really something anybody would want to do. If we switch the steps for period compare and rolling computations, that would make sense. I want to compare each rolling 7 day window with the previous (1 before) rolling 7 day window. The problem doesn't surface for values, but only for factor and growth modes.
Eventually it may make sense to think about how these operations interact but for now switching order is sufficient.
@mistercrunch


Need to click run twice on the first embedded DP for the page

Often, when I first load a page, I have to click the run button twice to see the app running. But usually just the one time for the whole page, even if it has multiple embedded DP instances.
behavior:
On first clicking the run button, the green progress bar cycles, but when it finishes moving, the output area remains blank. I click a second time and it repeats the process, but this time I see the output.

Most recent push should have addressed this issue (at least for the first load) - please reopen if this comes up again.


Add helper function SecretOperatorVolumeSourceBuilder::with_kerberos_service_name

Description
Needed for https://github.com/stackabletech/hdfs-operator/pull/334 and https://github.com/stackabletech/hdfs-operator/issues/178

Review Checklist

[ ] Code contains useful comments
[ ] (Integration-)Test cases added (or not applicable)
[ ] Documentation added (or not applicable)
[ ] Changelog updated (or not applicable)
[ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Thx!

bors r+


Remove ember-try

Shouldn't we remove ember-try, since it is bundled with CLI by default now?

👍  I need to refactor soon so I will remove ember-try from genie-init :)

Done 😸


[Hub Generated] Review request for Microsoft.DevHub to add version preview/2022-10-11-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

For the API breaking change, it was never actually ManifestType in the AuthStatus field in the code base, it was always AuthorizationStatus, so that slipped through the first version API changes. And the API readiness check is going to fail because we have a PR open for the ARM Manifest that wont be signed off until this PR is signed off: https://armmanifest.visualstudio.com/One/_git/Manifest/pullrequest/6409?_a=overview

@tadelesh @pilor some of these scenarios tested in the pipeline for Service API Readiness will require a subscription to setup a valid connection to github to be used successfully. How can we move this PR forward with that in mind?

You could ignore it. I'll merge this PR.

Breaking change is introduced and approved in this PR: https://github.com/Azure/azure-rest-api-specs/pull/20868.


hw show Today current date with different color when i selected other date

hw show Today current date with different background when i select other date

same thing. And how to change font to custome one of the dates?

public class Decorator implements DayViewDecorator {

        private final Calendar calendar = Calendar.getInstance();
        private final Drawable highlightDrawable;
        private final int color = Color.parseColor("#228BC34A");
        private CalendarDay date;

        public HighlightWeekendsDecorator() {
            highlightDrawable = new ColorDrawable(color);
            date = CalendarDay.today();
        }

        @Override
        public boolean shouldDecorate(CalendarDay day) {
            day.copyTo(calendar);
            int weekDay = calendar.get(Calendar.DAY_OF_WEEK);
            return date != null && day.equals(date);
        }

        @Override
        public void decorate(DayViewFacade view) {
            view.setBackgroundDrawable(highlightDrawable);
        }

class Decorator() : DayViewDecorator{

    private val color: Int = Color.parseColor("#0bb7b9")
    private var date: CalendarDay? = null

    init {
        date = CalendarDay.today()
    }

    override fun shouldDecorate(day: CalendarDay): Boolean {
        return date != null && day == date
    }

    override fun decorate(view: DayViewFacade) {
        view.addSpan(ForegroundColorSpan(color))
    }
}


tests: Build on Linux even though tests are not currently run

The 'EndToEndTests' are only run on Linux but testing is currently disabled in CI.  This makes it likely that the tests will not be built often and makes it possible for them to drift out of sync with the code they test without being noticed.
This change ensures that the tests are built in CI, even if they are not run.

@swift-ci test

Fix for End-to-End test build failure to follow once CI has run and failed.

@swift-ci test


[ACS] Deleting an ACS instance only deletes the "logical" ACS resource

Creating an ACS instance via az acs create generates all of the necessary Azure resources in order to support the cluster (e.g. load balancer, master/agent VMs), however, when you delete it via az acs delete, it only seems to remove the "logical" ACS resource, and none of its children that were created as a result of its corresponding create command.
Maybe this is expected behavior, but it seems non-ideal since ACS provides such a great higher-level abstraction on top of the underlying infrastructure, kind of like how deleting a k8s Deployment object will also delete the "underlying" ReplicaSets, Pods, etc. Using a resource group to manage this provides a reasonable work-around, so it definitely isn't a blocker, but I'd love to better understand the expected user scenarios that the az acs delete command is supporting. Thanks!

@brendanburns to comment

Yeah, this is the current ACS behavior for all orchestrator types.  Its not ideal.  The trouble is right now you can deploy an ACS cluster into a resource group with other stuff in it, and we don't really track what we created, so it's tricky to know what to delete.  We will be improving the ACS API to do a better job here.
In the mean time, we could add a --delete-parent-resource-group flag that would also delete the resource group and help clean this up.
--brendan

It should be soon resolved by latest ACS implementation.
logical ACS resource are not sitting together with other resources anymore. And az acs delete should remove the logical one and also the underlying resource. Try regions in this announcement.
https://github.com/Azure/ACS/blob/master/announcements/2017-08-04_additional_regions.md

This behavior is no longer the case--az acs delete removes all the expected resources. @mayurid @tjprescott we can close this issue.


Gnu debug link CRC read failures

Description
I was reported a failure on symbolizing some libraries using split debug. Investigating further I could see everything should be working as expected

gnu debug links are available
.debug (split debug) is in the same folder

So I went further to try and understand. I removed the debug link and replaced it, and that fixed it!
Looking at the CRC read, with the broken version, the data is not a u32, which yields a failure:
blazecli symbolize elf --path Datadog.Profiler.Native.so 0x8e842
[61, 40, 17] // printing the content of the data before crc read
Error: failed to symbolize addresses

Caused by:
    failed to read debug link checksum

Versus the version that is succeeding (re-writing the debug link)
blazecli symbolize elf --path ./dupe.so 0x8e842
[65, 61, 40, 17]
0x0000000008e842: anyhow::error::<impl anyhow::Error>::construct @ 0x8e7bd+0x85 /go/src/github.com/DataDog/apm-reliability/libddprof-build/.cargo/registry/src/github.com-1ecc6299db9ec823/anyhow-1.0.81/src/error.rs:245:40
                  alloc::boxed::Box<T>::new @ /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/alloc/src/boxed.rs [inlined]

The difference is probably related to the version of objcopy being used and alignment constraints imposed.
I will add the library that highlights this issue (it is open source code) and continue digging when I have some time.

I could not attach the libraries to the issue, so this will take a few extra download steps to reproduce.

Debug symbols are here
Extracting this debug file only

tar -xvf linux-native-symbols.tar.gz ./symbols/linux-x64/linux-x64/Datadog.Profiler.Native.debug

Main library is here
At this path linux-x64/Datadog.Profiler.Native.so

If I modify the logic by just taking the last 4 Bytes, it fixes the issue. However I am not sure if this complies with elf specifications.
    let crc_bytes = &data[data_len - 4..];
    let crc = u32::from_le_bytes([crc_bytes[0], crc_bytes[1], crc_bytes[2], crc_bytes[3]]);

Thanks for the report! Will take a look today.

Our logic is based on https://sourceware.org/gdb/current/onlinedocs/gdb.html/Separate-Debug-Files.html, which states:
A debug link is a special section of the executable file named .gnu_debuglink. The section must contain:

A filename, with any leading directory components removed, followed by a zero byte,
zero to three bytes of padding, as needed to reach the next four-byte boundary within the section, and
a four-byte CRC checksum, stored in the same endianness used for the executable file itself.

To the best of my reading, that's exactly what we expect. It's interesting that basically nothing is aligned in this binary:
$ readelf --sections /tmp/repro/linux-x64/Datadog.Profiler.Native.so --wide
  [Nr] Name              Type            Address          Off    Size   ES Flg Lk Inf Al
...
  [28] .gnu_debuglink    PROGBITS<PHONE_NUMBER>000000 70b153 000024 00      0   0  1
...

So there is no alignment requirement on the section itself (Al=1). That's different to what I see on binaries I've looked at, but it's not necessarily wrong. The offset is 0x70b153 from the start of the binary (which is page aligned as per my understanding), so that is unaligned. Also not wrong (I believe), just uncommon.
Our alignment logic itself seems kosher:
--- src/dwarf/debug_link.rs
+++ src/dwarf/debug_link.rs
@@ -145,13 +145,16 @@ pub(crate) fn read_debug_link(parser: &ElfParser) -> Result<Option<(&OsStr, u32)
     // SANITY: We just found the index so the section should always be
     //         found.
     let mut data = parser.section_data(idx).unwrap();
+    println!("RAW DATA: {data:p}: {data:#x?}");
     let file = data
         .read_cstr()
         .ok_or_invalid_data(|| "failed to read debug link file name")?;
     let file = bytes_to_os_str(file.to_bytes())?;
+    println!("BEFORE ALIGN: {data:p}: {data:#x?}");
     let () = data.align(4).ok_or_invalid_data(|| {
         "debug link section contains insufficient data: checksum not found"
     })?;
+    println!("AFTER ALIGN: {data:p}: {data:#x?}");
     // TODO: The CRC value is in the same endianess as the ELF file itself. Once
     //       we support non-host endianesses we need to take that into account.
     let crc = data

RAW DATA: 0x7f4df760e153: [
    0x44,
    0x61,
    0x74,
    0x61,
    0x64,
    0x6f,
    0x67,
    0x2e,
    0x50,
    0x72,
    0x6f,
    0x66,
    0x69,
    0x6c,
    0x65,
    0x72,
    0x2e,
    0x4e,
    0x61,
    0x74,
    0x69,
    0x76,
    0x65,
    0x2e,
    0x64,
    0x65,
    0x62,
    0x75,
    0x67,
    0x0,
    0x0,
    0x0,
    0x69,
    0xc4,
    0xd4,
    0xa6,
]
BEFORE ALIGN: 0x7f4df760e171: [
    0x0,
    0x0,
    0x69,
    0xc4,
    0xd4,
    0xa6,
]
AFTER ALIGN: 0x7f4df760e174: [
    0xc4,
    0xd4,
    0xa6,
]

This all seems to be by the book.
Have you checked how other tools behave by any chance? If I open the file in gdb I see:
Missing separate debuginfo for /tmp/repro/linux-x64/Datadog.Profiler.Native.so.
The debuginfo package for this file is probably broken.

So it may be choking on the same issue.
llvm-symbolizer also does basically nothing, but it's not exactly vocal as to why that is (that is, it could conceivably have other reasons):
$ llvm-symbolizer --obj=/tmp/repro/linux-x64/Datadog.Profiler.Native.so --functions 0x8e842 --verbose --debug-file-directory=/tmp/repro/symbols/linux-x64/linux-x64
??
  Filename: ??
  Line: 0
  Column: 0

Same with llvm-addr2line:
$ llvm-addr2line --obj=/tmp/repro/linux-x64/Datadog.Profiler.Native.so --functions 0x8e842 --debug-file-directory=/tmp/repro/symbols/linux-x64/linux-x64 --verbose
??
  Filename: ??
  Line: 0
  Column: 0

And eu-addr2line:
$ eu-addr2line -e /tmp/repro/linux-x64/Datadog.Profiler.Native.so --functions 0x8e842
??
??:0

From a brief look, these all seem to be debug link aware. E.g., they work on a stripped binary with only a debug link when I use valid blazesym test data:
eu-addr2line -e .../blazesym/data/test-stable-addrs-stripped-with-link.bin --functions 0x2000100
factorial
.../blazesym/data/test-stable-addrs.c:10:27

So to me, everything seems to point to this being a faulty binary. What toolchain and version generated it?

On the other hand...
$ readelf -wk Datadog.Profiler.Native.so

Datadog.Profiler.Native.so: Found separate debug info file: Datadog.Profiler.Native.debug
Contents of the .gnu_debuglink section (loaded from Datadog.Profiler.Native.so):

  Separate debug info file: Datadog.Profiler.Native.debug
  CRC value: 0xa6d4c469

and
$ readelf Datadog.Profiler.Native.so --debug-dump=follow-links --process-links --symbols --wide
<more symbols than without debug links following>

So readelf at least seems to be able to make sense of the data.

https://github.com/libbpf/blazesym/issues/769#issuecomment-2263475250
Actually, it seems if I link the .debug file in the directory of the main binary everything works with the other tools. So they don't seem to be choking on the CRC.

Looking at binutils' readelf, the reason it seems to work in their case is because they heap allocate memory for and then copy over the section contents before parsing them. Because the memory buffer returned there is aligned, everything works out.

So basically, the question is relative to what are things aligned. Now with that question in mind, if we read the specification again:

[...] zero to three bytes of padding, as needed to reach the next four-byte boundary within the section, [...]

Our alignment is not with respect to the beginning of the section, but rather the overall file. I suspect that's the crux of the matter.

@r1viollet this hopefully is fixed now. Thanks again for the report. If you see any issues, let us know. Also, feel free to reach out if you need this fix in a release.

Oh wow, that explains it. That is some lawyer level interpretation. Thanks for the thorough analysis! :bow:

I can use the commit, don't force a release just for me. Thanks again!


Display properly when station pair returns no data

In v3 we showed

In v4 we currently show

We should be clearer that there's no data to show

As a note for whoever is working on this, I believe that the code to display this message is still here, but in most of our charts we are passing empty arrays which do not show this message. I believe it needs to receive undefined.
Another note is that some charts are using the ChartPlaceholder component and some are not. I believe the ones that are using the component would show an error message in this case. However if we want to differentiate between error and no data we could add some fairly simple logic to do so.


[Event Request] Codeunit 5520 Get Unplanned Demand - OnBeforeGetUnplannedAsmLineOnBeforeInsertAsmLine

Hi, would it be possible to get an event OnBeforeGetUnplannedAsmLineOnBeforeInsertAsmLine codeunit 5520 , procedure GetUnplannedAsmLine, like this :

    local procedure GetUnplannedAsmLine(var UnplannedDemand: Record "Unplanned Demand")
    var
        AsmHeader: Record "Assembly Header";
    begin
        OnBeforeGetUnplannedAsmLine(UnplannedDemand, AsmLine);

        with UnplannedDemand do
            if AsmLine.FindSet() then
                repeat
                    UpdateWindow;
                    DemandQtyBase := GetAsmLineNeededQty(AsmLine);
                    if DemandQtyBase > 0 then begin
                        if not ((AsmLine."Document Type".AsInteger() = "Demand SubType") and
                                (AsmLine."Document No." = "Demand Order No."))
                        then begin
                            AsmHeader.Get(AsmLine."Document Type", AsmLine."Document No.");
                            InsertUnplannedDemand(
                              UnplannedDemand, "Demand Type"::Assembly, AsmLine."Document Type".AsInteger(), AsmLine."Document No.", AsmHeader.Status);
                            OnBeforeGetUnplannedAsmLineOnBeforeInsertAsmLine(UnplannedDemand);
                        end;
                        InsertAsmLine(UnplannedDemand);
                    end;
                until AsmLine.Next = 0;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeGetUnplannedAsmLineOnBeforeInsertAsmLine( var UnplannedDemand: Record "Unplanned Demand")
    begin
    end;

Thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Alpha-channel support in drawing mode

Would be nice to allow user to draw with semi-transparent colors.

--edit
That was just an example and would only work with PC users. It could be any other thing, whether you want me to think of the idea or not.


Change default case to lid-driven cavity instead of heat-driven cavity.

There is no longer a default case.  "Explicit is better than implicit." PEP 20


kube-apiserver failed to load SNI cert and key

As of today, the dynamic certificates i.e. kube-apiserver-certs are accessed by at least two processes, namely the installer pod and the cert-syncer.
Up until now, there was no coordination between these processes that might have lead to many unexpected errors, like https://bugzilla.redhat.com/show_bug.cgi?id=1963730
This PR writes all certificates in an atomic way by first creating a temporary file, writing the content to it, and then renaming it to the original file.
os.Rename calls syscall.Rename which in turn uses the rename syscall (Linux) which provides atomicity (https://man7.org/linux/man-pages/man2/rename.2.html)
The previous attempt didn't work as it would break the DR scripts - https://github.com/openshift/library-go/pull/1098

/retest

/lgtm
/approve

/retest

/hold
ci/prow/e2e-gcp-operator  seems to be broken

/hold cancel
/retest

/cherrypick release-4.8

/test e2e-gcp-operator

ci/prow/e2e-gcp-operator

keeps failing on Multus: [openshift-kube-apiserver/installer-13-ci-op-h6m9mzk7-f6035-jxnvh-master-1]: error getting pod: Unauthorized

/test e2e-gcp-operator

/retest

failed to create pod network sandbox will be fixed by https://bugzilla.redhat.com/show_bug.cgi?id=1972490


Help with Phishlet for horizon vmware

Got a start of a phishlet. It hangs with "Waiting..." and never loads the username/password fields.

Thanks! Can you confirm that the phishlets are working?
Let me know and I can merge them in.


Add tidb vector indtroduction in module guides

Description
Add tidb vector indtroduction in module guides
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

@logan-markewich Sorry for the late fix, PTAL agagin


image: error out on duplicate tar entry

Should address the code change requested in https://github.com/opencontainers/image-spec/issues/196
/cc @philips @stevvooe @vbatts @s-urbaniak
Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

LGTM

network error in Travis, any way to re-start it?

@runcom add whitespace to your commit message with git commit --amend and repush...

@caniszczyk could we get maintainers access to Travis to be able to restart builds?

tests now green though

lgtm

LGTM

@wking I have a branch which will take care of what you're saying but I'm buried with other stuff/PRs that are higher priority to me right now.

Can you open an issue to track this refactor of the unpack code?

On Thu, Sep 01, 2016 at 09:51:16AM -0700, Antonio Murdaca wrote:

Can you open an issue to track this refactor of the unpack code?

I've opened #242 to track cleanup on unpack errors.


Event 'add' not fired on polling over network > file was created via remote ssh

Two linux machines servers:
One runs the node.js script (script-server) and the other one holds the data (data-server).
The script-server mounts successfully the data-server to '/mnt/data-server' and chokidar monitors this mounted folder. Chokidar is in polling mode (usePolling: true).
Case 1 (not working):
When copying a file via commandline (script-server) into the mounted folder, chokidar fires no events (even not when displaying raw events).
Case 2 (working):
When mounting the data-server additionally on a windows client (samba) and creating the file from the windows client, chokidar (on the script-server) works as excpected and fires the add-event for the file.
Whats the problem here?

You said it yourself - the raw events from the polling aren't picking up the change, but I don't know why. This happens every time you create a new file in the mounted drive from the script-server? What if it isn't a copy command, something like touch foo.bar instead?

Sadly it happens every time. Even withtouch foo.bar.

Try touch /mnt/data-server
Also take a look at the output of stat on the dir and any relevant files before and after your attempts to make something happen.

Okay - Touch  on the file > no change.
Touch on the folder > Chokidar recognized the file after the touch.

Okay my workaround is now to touch the folder every second continuosly. Thank you very much Elan for helping me on this! Looks like there is a caching problem with cifs-mounts. Maybe the touch shoud be also part of the polling-feature?

Maybe the touch shoud be also part of the polling-feature?

I don't think so, especially considering this doesn't appear to be a common problem.