NextJS 13.4.12 - Issue when including more than one handler in api route

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
d958wox4bf0gy
AWS Region
eu-west-1
Amplify Hosting feature
Deployments
Frontend framework
Next.js
Next.js version
13.4.12
Next.js router
App Router
Describe the bug
I've been having issues when adding multiple handlers into an api route in Next JS 13.
Next JS 13 requires that you provide the name of the handler(s) as below:
export async function GET () {
  const { DYNAMODB_IMPACT_AREAS } = process.env
  const { Items } = await dynamoDb(DYNAMODB_IMPACT_AREAS).scan({})
  if (!Items) NextResponse.json({ test: false })
  return NextResponse.json({ impacts: Items })
}

// export async function POST () {
//   return NextResponse.json({ test: true })
// }

// export async function PATCH () {
//   return NextResponse.json({ test: true })
// }

// export async function DELETE () {
//   return NextResponse.json({ test: true })
// }

This version works, however if I uncomment out the rest of the handlers the route endpoint does not work, even the GET request does not work
Expected behavior
You should be able to access the GET query when viewing this in the browser regardless of whether there are multiple handlers or not
https://main.d958wox4bf0gy.amplifyapp.com/api/impacts
Reproduction steps
Go to https://main.d958wox4bf0gy.amplifyapp.com/api/impacts and see that route is broken
Build Settings
No response
Log output

# Put your logs below this line

2023-08-17 | 08:42:39 | LHR61-C1 | 194 | <IP_ADDRESS> | GET | d958wox4bf0gy.cloudfront.net | /api/impacts | 500 | - | Mozilla/5.0%20\(Macintosh;%20Intel%20Mac%20OS%20X%2010_15_7)%20AppleWebKit/537.36%20\(KHTML%20like%20Gecko)%20Chrome/<IP_ADDRESS>%20Safari/537.36 | - | - | Error | tPbnpsncRAED6oWnYTcIQIjVNvRKVQzwqRlZYRDvX_JdN_B7GsIj9A\=\= | main.d958wox4bf0gy.amplifyapp.com | https | 36 | 8.933 | - | TLSv1.3 | TLS_AES_128_GCM_SHA256 | Error | HTTP/2.0 | - | - | 57576 | 8.933 | OriginError | - | 0 | - | -
-- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --

2023-08-17	08:42:39	LHR61-C1	194	<IP_ADDRESS>	GET	[d958wox4bf0gy.cloudfront.net](http://d958wox4bf0gy.cloudfront.net/)	/api/impacts	500	-	Mozilla/5.0%20\(Macintosh;%20Intel%20Mac%20OS%20X%2010_15_7)%20AppleWebKit/537.36%20\(KHTML%20like%20Gecko)%20Chrome/<IP_ADDRESS>%20Safari/537.36	-	-	Error	tPbnpsncRAED6oWnYTcIQIjVNvRKVQzwqRlZYRDvX_JdN_B7GsIj9A\=\=	[main.d958wox4bf0gy.amplifyapp.com](http://main.d958wox4bf0gy.amplifyapp.com/)	https	36	8.933	-	TLSv1.3	TLS_AES_128_GCM_SHA256	Error	HTTP/2.0	-	-	57576	8.933	OriginError	-	0	-	-

Additional information
No response

Hi @baskeyx 👋 , thanks for raising this with us!
I wasn't able to reproduce this behavior with Next.js version 13.4.12. Here is the route.js file that I used for testing purposes:
import { headers } from 'next/headers'
import { NextResponse } from 'next/server'

export async function GET(request) {
  const headersList = headers()
  const referer = headersList.get('referer')

  return new Response('Hello, Next.js!', {
    status: 200,
    headers: { referer: referer },
  })
}

export async function POST () {
    return NextResponse.json({ test: true })
}

export async function PATCH () {
    return NextResponse.json({ test: true })
}

export async function DELETE () {
    return NextResponse.json({ test: true })
}

Additionally, I tested it as follows:
curl https://main.d2kcqri7zze2uz.amplifyapp.com/api/test

curl -X POST https://main.d2kcqri7zze2uz.amplifyapp.com/api/test -d "key=value"

curl -X PATCH https://main.d2kcqri7zze2uz.amplifyapp.com/api/test -d "key=1"

curl -X DELETE https://main.d2kcqri7zze2uz.amplifyapp.com/api/test

You may want to review your Hosting Compute logs for this API route to check for any errors.


MongoError: Invalid collection name: test.$cmd

I got the error when trying to run mongodb command using namespace of COLLECTION + '.$cmd'
2.1.8 is working but 2.1.9 throw an exception
const connection = new Server({}});
connection.command('test.$cmd', ... )

can you provide a failing test case ?

create one db develop and collection user
run following script.
got error MongoError: Invalid collection name: develop.$cmd
node: v6.10.0,  mongodb-core: 2.1.9, mongodb: 3.4.0

var Server = require('mongodb-core').Server

// Set up server connection
var server = new Server({
  host: 'localhost'
  , port: 27017
  , reconnect: true
  , reconnectInterval: 50
});

// Add event listeners
server.on('connect', function (_server) {
  console.log('connected');

  var db = 'develop';

  const cmd = {
    "find": "user",
    "filter": {
      "$or": [
        { "provider": "google", "providerData.id": "placeholder" },
        { "additionalProvidersData.google.id": "placeholder" },
        { "email": "placeholder" }
      ]
    },
    "limit": 1,
    "projection": {},
    "sort": {}
  };

  server.command(`${db}.$cmd`, cmd, {}, (err, response) => {
    console.log(err, response);
  });

});

server.on('close', function () {
  console.log('closed');
});

server.on('reconnect', function () {
  console.log('reconnect');
});

// Start connection
server.connect();

above script will fail only 2.1.9
will get result { cursor: { firstBatch: [], id: 0, ns: 'develop.user' }, ok: 1 } with 2.1.8

Thank you so much. I really appreciate your great work and the fantastic library.

Why are you executing the find command and not using the cursor method ?

It's return 1 record at most in this case. In other case. i will use count/find and cursor method to pipe the results to a stream and transfer using protobuf.


Run pytest in conda recipe

Closes #222

Command to run tests in dpCtl:
https://github.com/IntelPython/dpctl/blob/77bc086561e87770eef5237d58b46c1564f290c8/conda-recipe/run_test.sh#L9


Copying examples into HTML5 pages doesn't work

Copy-pasting ui-demo example (and base.css file) into HTML5 web page doesn't work:

The page above is in html5 "standards mode":
<!doctype html>
<html>…

While eve-starter pages are missing the doctype ("quirks mode"):
<html>…

I don't know all the differences between the modes. (Most of the modern pages on the web have  doctypes.) However, Chrome points to one problem - missing px unit:

I would suggest adding the doctype and adding px where necessary.

(http://play.witheve.com/ is also missing the doctype.)


Content containing CSV separator

Copied issue from https://github.com/CommunityHiQ/Frends.Community.ConvertXmlToCsv
If the the content of an XML element contains the separator, the task adds the character " to the beginning and the end of the value. For example, if the separator is ',', the value of Not now, not ever becomes "Not now, not ever". However, this does not have the intended result of producing a single CSV column value. If the separator is ',', the aforementioned result counts as two CSV column values: ""Not now" and "not ever"".
It might be better that the task merely throws an error if one of the element values contains the separator. Then it would be up to the customer and developer to decide how to handle it.

Fixed by making the task throw error if the csv separator is in the input.


SleepSort [Java]

This issue is about adding a SleepSort implementation in Java.

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[ ] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

i would like to work on this

@riktimmondal: @ashutosh-wad is already working on it. You can take a look at other issues or create a new one and work on it.

@ashutosh-wad: Thanks for contributing.
Can you change other implementations in the similar way where the sleep time is scaled according to numbers?


workaround for synthesizing text

#44 mentioned: # synthesize text - does not work on Mojave (for now..)
this PR adds option -a to simplify configuration of keystroke-sequence, previously:
ctrl - j : skhd -k "1"; skhd -k "w"; skhd -k "2"; skhd -k "w"; skhd -k "3"; skhd -k "q"; skhd -k "e"; skhd -k "4"; skhd -k "e"; skhd -k "w"; skhd -k "q"

new:
ctrl - j : skhd -a "1w2w3qe4ewq"

I don't want to be making any changes related to this until Mojave GM is released, as there is no indication in their documentation that any changes have been made to the API we use to implement this. As such, I believe this is just a bug or unintended change.
This feature also uses non-deprecated APIs which make my point above seem more valid.
If Mojave is released and this is still a problem,I will consider different ways to replicate said functionality (with utf8 support).

-t works here after upgrade to Mojave(10.14), you may test and close this PR...


Automatically convert multiple files if multiple files are given in argv.

I wrote geojson-merge. It's easy to implement merging, and probably both expected and convenient to the users of this module.

Implemented in togeojson-cli.


As a user, I need to be able to set the id attribute to the div that replaces the tab-content tag

The current way (t.tabId=""+t.title.replace(/ /g,"")+e) of generating the id attribute makes it unusable for cases when you need a clear control over the id of the "div"s.
For example, before allowing the user to move forward or backward, I need to call a validation plugin  with one or more divs as containers which are validated. If the given divs are valid then the forward/backward movement is allowed.

Hi @ksidibe. This could be implemented but you could simply place a div inside each tab-content and give it your own ids. Wondering what validation do you use since most validation libraries for vue work with components/refs

Hey, @cristijora. The approach you suggested could work. Although, that would make the HTML markup more verbose (granted very slightly) with an extra set of "div" tags per tab-content.
Other than that, your suggestion will do the job nicely.
I use [http://formvalidation.io/](a jQuery plugin called FormValidation). For tabular/wizard-based forms, it allows you to  validate the current tab only if you wish.
I think, it would be handy to allow the user to pass attributes to the tab-content divs. As an intermediate step, we could implement a method that returns the DOM element of the current tab-content.
For the time being this is the solution I'm using:
var $currentTab = $('.wizard-tab-content .wizard-tab-container:visible:first'); fv.validateContainer($currentTab);

@ksidibe I would advise against such solutions (jquery validate) You will find yourself writing jquery based code where it shouldn't be.
Use a native vue validation solution instead. https://github.com/vuejs/awesome-vue#validation
I could recommend vee-validate or element-ui validation if you use that.
The problem with using such jquery plugins is that you tend to manipulate DOM which Vue tries to avoid via it's reactive nature.
Such an approach will also

Get complicated fast
Will be hard to understand and maintain after some time
Depends on some selectors which might change
Will be hard to unit test

If you worry about validation only the current tab, you could simply separate each tab into a separate component, have a validation method and call it when you need. I will try to provide a realistic example with codesandbox and vee validate later on

Hey, @cristijora.
Your points are valid.
But in our case, Vue is used in a much smaller subset of the code base. So, there are many more parts where we use this validation plugin.
In any case, whatever the use-case might be, I think vue-form-wizard is a very good Vue component that can be further enhanced by adding attribute processing functionality to it. for example, even being able to define the id and classes in the tab-content directly.
I'm new to Vuew in general. But if you are opened to the idea suggested above, I could work on it offline and submit a pull request when I'm done.
Thanks.

Yeah, it doesn't hurt adding other properties on the tab-content.
If you have the time and patience, you could simply add an id prop to the TabContent component and set it if it exists.
:id="id ? id : tabId "
This would be a very simple fix.
Another option would be to pass attributes with https://vuejs.org/v2/api/#inheritAttrs option
which will allow passing other attributes as well


WHEN I click one of the links in the navigation

`THEN the UI scrolls to a section with titled images of the developer's applications

Done


[stable/pomerium] Add option to configure forward-auth automatically

Is this a new chart
No
What this PR does / why we need it:
Adds logic to automatically configure the chart to support Pomerium for a forward authentication deployment.
Related:
https://github.com/pomerium/pomerium/issues/94
https://github.com/pomerium/pomerium/issues/323
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/lgtm


[ci skip] [cf admin skip] NO_CI adding bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I've added bot automerge as instructed in #2.
Merge this PR to enable bot automerging.
Fixes #2

@thewchan if you agree, then I would like to add the automerge bot with grayskull to automatically update the dependencies.

@jan-janssen I'm usually a little distrustful of the bots so I prefer to use hint-all and merge manually, but if you feel confident then go for it!

As we have the pip check and import test I am confident to merge them automatically, it helps me to stay on top of the large number of recipes. But I am also open to disabling it.

All good to me; let's try it!


Feature/139 govuk react jsx components

Description

Replace temporary govuk components replicas with components from govuk-react-jsx library.
Fix broken tests.
Significant refactor of tests to improve code readability.

Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] I have added tests that prove my fix is effective or that my feature works
[X] I have run all unit tests
[X] I have manually tested the application and related features

Checklist:

[X] My changes do not introduce any new linting errors
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I have rebased onto master and there are no code conflicts

lgtm apart from build-state. could you delete and add to gitignore please


Workflow script

Add a main script that runs the entire workflow start to finish, given an image directory and model locations
The script should contain debugging statements for testing that can be muted by advanced users when used for real analysis

Pushed the main workflow : main_imageproc.py(renamed it to meet snakecase standards but can rename it again). It works and has been linted. Contains docstrings and debugging statements. Args are given through command line.


Create a display function/class.

@Smichels27 For me it seems your classes have integrated fine, but I'd recommend trying it out yourself to be sure. Just one thing needs to be changed, for your display function it'd be great if you could remove the static identifiers on the functions so that they can be used in main.java. Feel free to update them at any point.

Never mind, everything's fine. I was getting an error and it acted like static was causing issues, but it seems it's completely fine. Sorry for that.

Allowed me to actually figure out what static means, I didn't have a full understand of it before.

IT's all right, just let me know if there's anything else i can do/


Implement Register Allocation

From<EMAIL_ADDRESS>on June 28, 2009 20:17:53
Describe the New Feature: 1. The current register allocation scheme simply maps PTX register
variables to unique identifiers.
2. Implement a graph coloring register allocator.
3. Implement a linear scan register allocator. Which milestone does the feature belong to? 0.5.0 Which branch does the new feature go in? Trunk
Original issue: http://code.google.com/p/gpuocelot/issues/detail?id=5

From<EMAIL_ADDRESS>on December 21, 2009 07:19:27
Starting on 3.  This is going to be a PTX transform that performs allocation and
manages spill code.  I will also add a stand alone program.
Status: Started

From<EMAIL_ADDRESS>on January 05, 2010 00:40:41
There is a preliminary version of 3 checked in in r282 .  This should be updated such
that registers are given the correct type.  A graph coloring allocator can probably
resuse much of the same code.
Status: Accepted

From<EMAIL_ADDRESS>on July 01, 2010 14:01:52
Updated this so that registers now have the correct types.  I am leaning against doing a graph coloring allocator at this point at least, but I am going to keep this open in case someone else wants it.
Status: Verified


fix(charts): bump router's livenessProbe initial delay

ref https://github.com/deis/charts/pull/368

Current coverage is 55.11% (diff: 100%)

Merging #284 into master will not change coverage

@@             master       #284   diff @@
==========================================
  Files             6          6
  Lines           381        381
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            210        210
  Misses          151        151
  Partials         20         20

Powered by Codecov. Last update b9c67e9...646b1c6


Bump bazeldnf to fix rpm verification

The new bazeldnf release can deal better with unreachable sites during
the RPM verification process.
Fixes the failing rpm verification job: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4765/pull-kubevirt-verify-rpms/1347458747215122432
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @dhiller

/cc @dhiller

/retest

/retest


[Bug]: Movies Not Displaying After Selecting Year and Genre in Search Page

What happened?
After selecting a year and genre on the search page, no movies are being displayed. Currently, movies only appear when the user types something in the search bar. This behavior is not as expected. A default list of movies should be shown based on the selected year and genre, sorted in alphabetical order, even if the search bar is empty.
Expected Behavior:
Movies should display automatically after selecting a year and genre, sorted alphabetically. The search bar should then allow users to filter the displayed movies by name if needed.
Screenshot

How can we reproduce this bug?
Navigate to the search page.
Select a year and a genre without typing anything in the search bar.
Observe that no movies are displayed.
Type a movie name in the search bar to see the movies appear.
Please assign this issue to me under gssoc-ext level2 and hactoberfest-accepted, @sid0000007 , as I am interested in working on it.

@sid0000007 could you please assign me this issue.

@sid0000007 kindly update about the status of this issue as today is the last day for gssoc-ext PRs.


Adjustments to the PMP PR

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features).
[ ] (If applicable) Tests have been added.
[ ] CHANGELOG.rst has been updated (with summary of main changes).

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Better typing hints.
Reworked some code when functionalities already existed elsewhere (xarray, xclim, xscen).
Removed lmoments3 from the tests. They can work with SciPy.
Where relevant (e.g. precipitable_water), the arguments of the function are DataArrays for each required climate variable, instead of a dataset. This is closer to how xclim does it.
Simplified the summer/spring mask code and changed to tests to try a few possible cases.
Added attributes to the new indicators.
Removed explicit references to spatial dimensions. Now, it uses ds.cf.axes to get the name of the axes.

Other information:

I started to change the tests to implement the building tools from xclim/xscen, as well as xclim.open_dataset(), but in the end I didn't want to change them too much to make sure that my changes weren't breaking anything. We can update them later if required.

Nice implementation !
Should we also add in the code the reference ?
Jacinthe Clavet-Gaumont, David Huard, Anne Frigon, Kristina Koenig, Phillip Slota, Alain Rousseau, Iris Klein, Nathalie Thiémonge, Fanny Houdré, John Perdikaris, Richard Turcotte, Julie Lafleur, Bruno Larouche,
Probable maximum flood in a changing climate: An overview for Canadian basins,
Journal of Hydrology: Regional Studies,
Volume 13,
2017,
Pages 11-25,
ISSN 2214-5818,
https://doi.org/10.1016/j.ejrh.2017.07.003.
(https://www.sciencedirect.com/science/article/pii/S2214581817301696)

Nice implementation !
Should we also add in the code the reference ?
Jacinthe Clavet-Gaumont, David Huard, Anne Frigon, Kristina Koenig, Phillip Slota, Alain Rousseau, Iris Klein, Nathalie Thiémonge, Fanny Houdré, John Perdikaris, Richard Turcotte, Julie Lafleur, Bruno Larouche, Probable maximum flood in a changing climate: An overview for Canadian basins, Journal of Hydrology: Regional Studies, Volume 13, 2017, Pages 11-25, ISSN 2214-5818, https://doi.org/10.1016/j.ejrh.2017.07.003. (https://www.sciencedirect.com/science/article/pii/S2214581817301696)

Quelles fonctions exactement devraient avoir la référence ? Toutes ?

This PR is not relevant anymore.


⚠ Empornium has degraded performance

In 84cf621, Empornium ($EMP) experienced degraded performance:

HTTP code: 500
Response time: 1010 ms

Resolved: Empornium performance has improved in c72146b after 34 minutes.


Question: how to use the environment data in the library?

Hello. Thanks for the awesome tool!
Perhaps someone can suggest how to use the data from the current environment. More specifically, how can I get the namespace name?
I ran into this issue while trying to implement podAntiAffinity for deployment. I looked at the documentation and tried to search for examples on the Internet, but I did not find an elegant solution.
I understand that I can put it in a separate variable, but why? After all, I already said everything to tanka at the stage of creating the namespace, but I can’t use this data.
tk env add environments/dev --namespace=dev

Example:
local k = import "ksonnet-util/kausal.libsonnet";

{
  new(name, image,): {

  local container = k.core.v1.container,
  local deployment = k.apps.v1.deployment,
  local spec = k.apps.v1.deployment.spec.template.spec,
  local podAntiAffinity = k.apps.v1.deployment.spec.template.spec.affinity.podAntiAffinity,
  local podAffinityTerm = k.core.v1.podAffinityTerm,

  container:: container.new(name=name, image=image),

  deployment:
    deployment.new(
      name=name,
      replicas=1,
      containers=[self.container],
    )
    + podAntiAffinity.withPreferredDuringSchedulingIgnoredDuringExecution(
        podAffinityTerm.withNamespaces(
          // self.deployment.metadata.namespace
          // RUNTIME ERROR: Field does not exist: namespace
          self.deployment.metadata.name // ok
        )
    ),
  }
}

Maybe there is some way to refer to the data from the specification, as it is implemented in the export, for example:
{{env.spec.namespace}}

https://tanka.dev/exporting/#multiple-environments

If I don't understand something, it might be worth adding an example of how to use it here.
https://github.com/grafana/tanka/blob/cfe9627dcab2321746e5cd2eeb05a6b54a674432/docs/design/tanka.md?plain=1#L226

The namespace value is not known in Jsonnet at self.deployment.metadata.namespace unless explicitly set by the user, Tanka will configure the namespace on tk apply/diff when running against a cluster.
The namespace should be passed down as an argument in new(name, image, namespace): { from the environment to the library.
The design doc you referenced refers to spec.json environments and the magic import import "tk", note that this does not work with inline environments (not sure which you use).
The templating for tk export refers to the export path for the actual YAML manifests.

Thanks for the clarification


Help,How to use create_transaction intent?

I want parse text SMS into payment data ,then insert into guncash. after view code ,".receivers.TransactionRecorder" maybe a way.
But How can i know  account's UID , in code use"args.getString(Transaction.EXTRA_ACCOUNT_UID);"

You make a good point. There is currently no way to retrieve an account UID
via an external app.
I will think about how to improve this in future releases. Such as letting
other apps query accounts/transactions.
On Wed, Mar 9, 2016 at 4:41 PM, Alex Lei 雷<EMAIL_ADDRESS>wrote:

I want parse text SMS into payment data ,then insert into guncash. after
view code ,".receivers.TransactionRecorder" maybe a way.
But How can i know account's UID , in code
use"args.getString(Transaction.EXTRA_ACCOUNT_UID);"
—
Reply to this email directly or view it on GitHub
https://github.com/codinguser/gnucash-android/issues/483.

Thanks a lot！


Docker image includes dev dependencies

Describe the bug
Docker image includes dev dependencies
Suggested solution
Set the NODE_ENV environment variable to production in the docker env.

This is intended behavior.


changes are done

#138 Improve the footer
under gssoc'24
fixes #138

@drick-infinity  Poor UI, improve it


feat: allow custom lifetime for impersonated creds

Fixes #474 for impersonated credentials.
The default maximum lifetime for token is 1 hour, but users can configure service account to extend the maximum lifetime to 12 hours.
This PR allows users to set custom lifetime (<= 12 hours).

The format / format-code failure is not caused by the PR.


Fix bookinfo

We need a newer node image to be able to build the image. This is in line with upstream.

/retest

/retest

/retest

/override ci/prow/integ-servicemesh-multicluster-2-4


Protect master branch

The master branch is currently not protected. I myself do not have the permissions to change the branch protection rules; I only see the two menus Options and Moderation settings.
@TamimiGitHub Could you please enable the branch protection rules for the master branch as following?
Protect matching branches

[x] Require pull request reviews before merging

[x] Dismiss stale pull request approvals when new commits are pushed

[x] Require status checks to pass before merging

[x] Require branches to be up to date before merging

[x] Linting
[x] Building solace-message-client
[x] Unit Testing
[x] Building Testing App
[x] E2E Testing

[x] Require linear history
[x] Include administrators
[x] Restrict who can push to matching branches, except:  @GreenRover, @danielwiehl, @TamimiGitHub, Solace admins

Rules applied to everyone including administrators

[ ] Allow force pushes
[ ] Allow deletions

Perfect! Done 👍


'Cheerio' is used, but not imported in server-test-utils/types

Version
1.0.0-beta.33
Steps to reproduce

Check the file https://github.com/vuejs/vue-test-utils/blob/dev/packages/server-test-utils/types/index.d.ts
It contains the usage of the Cheerio type, but the type is not defined/imported

What is expected?
The Cheerio type must be imported from '@types/cheerio'.
What is actually happening?
This issue prevents TypeScript compilation.

Made a fix: https://github.com/vuejs/vue-test-utils/pull/1527

🤔 strange that this was un-noticed for so long! I will review the PR in the next day or so and give it a test. Thanks!


[TableCell] Height of table rows / cells

Default table row height is 49px, but according to specification it should be 48px. The current behaviour distorts the vertical spacing / grid (multiples of 8).

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔
Default table row height should be 48px.
Specification:

Current Behavior 😯
Default row height is 49px
From the docs:

Context 🔦
Setting
lineHeight: theme.typography.pxToRem(19)
in TableCell resolves the issue, but I'm quit unsure if that's the correct approach.

Tech
Version

Material-UI
v4.2.0

Looks like a divergence of the spec. I'm happy to have this fixed. Let's see what others think.

It's something we have tried to do right at multiple occasion when refactoring the component, I have never been able to find a better tradeoff. I'm happy to explore the different options and their tradeoffs.

Another approach could be to subtract 1px from top or bottom padding. Possible tradeoff might be the content not being centered perfectly.

I'm going to close over the following reasoning simplicity > following the spec.


running on arm64 platform

Hi guys
Is there a way to build this image for arm64 platform like for example for a raspberry pi?
I tried but I got loads of errors.
Thanks

Not unless they release arm builds of the server files


Add self parameter in  get_mm_per_unit function

When Focal Plane Resolution Unit is present in exif,  function extract_sensor_width calls self.get_mm_per_unit(resolution_unit) with only one argument.  Added self as first argument.
File "/home/test/OpenSfM/opensfm/exif.py", line 197, in extract_sensor_width
mm_per_unit = self.get_mm_per_unit(resolution_unit)
TypeError: get_mm_per_unit() takes exactly 1 argument (2 given)

I'm not a Python programmer, and i know this patch may be not the most elegant solution, but works :)

Thanks, @sabado !

@paulinus there is an image with FocalPlaneResolutionUnit tag on it! And thanks you for make this software exists :)


Zigbee2MQTT - cannot open Web UI - 502 Bad Gateway

I have been using same config now for some months.
Nothing has been changed.
Since yesterday: I noticed that my lights where not available.
Restarted Z2MQTT, restarted the RPI4.
Nothing helps and I cannot use the Web UI: 502 Bad Gateway
Current version: 1.18.1-1
HA Core 9.7
RPI4
Log:
Zigbee2MQTT:info  2021-10-01 15:33:28: Starting Zigbee2MQTT version 1.18.1 (commit #1.18.1)
Zigbee2MQTT:info  2021-10-01 15:33:28: Starting zigbee-herdsman (0.13.71)
Zigbee2MQTT:debug 2021-10-01 15:33:28: Using zigbee-herdsman with settings: '{"adapter":

2021-10-01T13:33:28.395Z zigbee-herdsman:adapter Failed to validate path: 'Error: spawn udevadm ENOENT'
Zigbee2MQTT:error 2021-10-01 15:33:47: Error while starting zigbee-herdsman
Zigbee2MQTT:error 2021-10-01 15:33:47: Failed to start zigbee
Zigbee2MQTT:error 2021-10-01 15:33:47: Exiting...
Zigbee2MQTT:error 2021-10-01 15:33:47: Error: Failed to connect to the adapter (Error: SRSP - SYS - ping after 6000ms)
    at ZStackAdapter.<anonymous> (/app/node_modules/zigbee-herdsman/dist/adapter/z-stack/adapter/zStackAdapter.js:94:31)
    at Generator.throw (<anonymous>)
    at rejected (/app/node_modules/zigbee-herdsman/dist/adapter/z-stack/adapter/zStackAdapter.js:25:65)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `node index.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  I have the same problem.
Zigbee2mqtt
Current version: 1.22.0-2
Сore-2021.11.3
[15:47:38] INFO: Handing over control to Zigbee2mqtt Core ...

<EMAIL_ADDRESS>start
node index.js
Zigbee2MQTT:error 2021-11-15 15:48:11: Error while starting zigbee-herdsman
Zigbee2MQTT:error 2021-11-15 15:48:11: Failed to start zigbee
Zigbee2MQTT:error 2021-11-15 15:48:11: Check https://www.zigbee2mqtt.io/information/FAQ.html#help-zigbee2mqtt-fails-to-start for possible solutions
Zigbee2MQTT:error 2021-11-15 15:48:11: Exiting...
Zigbee2MQTT:error 2021-11-15 15:48:12: Error: Failed to connect to the adapter (Error: SRSP - SYS - ping after 6000ms)
at ZStackAdapter.start (/app/node_modules/zigbee-herdsman/src/adapter/z-stack/adapter/zStackAdapter.ts:102:27)
at Controller.start (/app/node_modules/zigbee-herdsman/src/controller/controller.ts:123:29)
at Zigbee.start (/app/lib/zigbee.ts:58:27)
at Controller.start (/app/lib/controller.ts:100:27)
at start (/app/index.js:97:5)
[15:48:13] INFO: Handing over control to Zigbee2mqtt Core ...
<EMAIL_ADDRESS>start
node index.js

I tried everything, reset, delete and reinstall devices, backup from HA. Nothing  helped.
Untill I ordered and installed a new adapter.
Everything worked fine after that.

+1 on the issue. 2 installations, bad gateway or connection refused on both installations.
This is also valid for other new installed addons as well. (Old addons working)


check that the scope of the dependency is "application" (compile is Maven)

we should discard breaking updates in testing dependencies such as a breaking update in junit or mocikto

This is fixed with #73.


encoding/json: omitempty for arrays is confusing

What version of Go are you using (go version)?

$ go version
go version go1.11.2 darwin/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOOS="darwin"

What did you do?
https://play.golang.org/p/NlRBFTZHFYd
func main() {
	type Foo struct {
		ID [16]byte `json:",omitempty"`
	}

	var f Foo
	j, _ := json.Marshal(f)
	fmt.Println(string(j))
}

What did you expect to see?
{}

What did you see instead?
{"ID":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]}

This is caused by isEmptyValue inside encoding/json checking to see if the length of the array is 0. For people actually using an array (and not a slice), it is unlikely that they would ever use an array of zero length. It is likely, however, that they might want to omit the result if all of the values in the array are empty. For example, if a user is using [16]byte to represent a UUID, they might want to omit encoding it if it is all zeroes. This was brought up in #11939, specifically this comment. It would be nice if we could do this generically for arrays with values we can determine are empty.

An array that has a bunch of 'zero values' is still is not empty. The list of zeros means something. I would expect the array to be printed as is shown in the "what did you see instead" (for example a zero matrix). I played around with this a little and think this is a real issue.
My first attempt would be to implement the json.Marshaler interface for some type encapsulating [16]byte.
type UUID [16]int

func (uuid UUID) MarshalJSON() ([]byte, error) {
	for _, num := range uuid {
		if num != 0 {
			return json.Marshal([10]int(uuid))
		}
	}
	return json.Marshal(/* some zero value */) // <--- this is the real problem in my opinion.
}

Since it seams MarshalJSON is called after the value is established to not be zero, no matter what you put return from MarshalJSON, the value returned is not considered to be an empty value.
I think a json.ErrValueIsZero would be useful in this situation. So you can override the zero-ness of a type.
The only other solution that I can think of would be to implement MarshalJSON for all types that embed the [16]byte or make all structs point to a *[16]byte. I don't like either option too much.
Notes (my playground): https://play.golang.org/p/GV8rX6f30ba

IMO, it doesn't seem confusing to me. The array indeed contains 16 zeros (which are totally valid values). So why should it be {} ? It makes sense if it is a slice or a map (which is https://github.com/golang/go/issues/27589), but printing zeros sounds like the right behavior to me.
If you want this behavior to be there, this should be a proposal instead of a bug report.

This is a bug in the semantics of omitempty, which is why I didn't file it as a proposal. The documentation even points out specifically that there is such a thing as an empty array:

The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string.

There aren't any caveats added there. For all the other items in the list, any type of those things is considered empty, but with arrays only specific types of arrays can be considered empty and those are arrays that it is doubtful someone would use as a struct field.
What most users who add omitempty as a struct tag to an array field want is for the zero version of an array, e.g. var id [16]byte, to be evaluated as empty.
The confusing part is the definition of an empty array.  It doesn't make much sense to provide a struct tag for something that is quite useless in practice and call it out in the documentation. A struct field with [0]byte is always empty and will only ever be empty. There could be a use case for using something like [0]byte as a struct field, but it's likely extremely rare.

It's really not a semantics bug, though. Since an array is not a pointer type,[16]byte is transported around as what is functionally a single value that is 16 bytes in length. "Empty" in the context of that text you cited means len(val) == 0, in which case [16]byte is not an empty array (because it has 16 elements, in which 0 could be considered a valid element value).

What most users who add omitempty as a struct tag to an array field want is for the zero version of an array, e.g. var id [16]byte, to be evaluated as empty.

You may prefer this, but many (for example me) do not. As far as Javascript/JSON is concerned, an array with 16 0-valued elements is not an empty array, so considering it as such would be incorrect, wouldn't it? Why not just use *[16]byte or marshal the value to null if you need to treat the zero value in a special way?

The confusing part is the definition of an empty array. It doesn't make much sense to provide a struct tag for something that is quite useless in practice and call it out in the documentation. A struct field with [0]byte is always empty and will only ever be empty. There could be a use case for using something like [0]byte as a struct field, but it's likely extremely rare.

I don't disagree that you'd probably never have [0]byte in as a struct field... but what about as an interface value? It could be a sentinel value that you ascribe special meaning to. It's not common, but it certainly isn't "useless".
I do agree with @crhntr that a special error to return from json.Marshaler implementations noting that a value should be omitted  would be useful.

CC @rsc @dsnet @bradfitz @mvdan for encoding/json

Reminds me of https://github.com/golang/go/issues/28391 - in that issue, text/template's definition of whether a value is true was a bit too stiff. Seems a bit similar to how users have different expectations of what "empty" means here.
I don't personally have an opinion, but I think the current behavior of omitempty is consistent and well documented. You can argue that omitting an empty array is almost never useful, but making omitempty suddenly mean something different like "omit zero values" would likely be a breaking change.
For example, I presume that a slice with zero length and non-zero capacity is empty, but non-zero. That distinction could break dozens of programs in the wild if we suddenly change the meaning of omitempty.

@skriptble I also run into this issue using UUID's. Did you find a workaround?
Interesting issue tho, definitely worth looking into.

@andybons I see the milestones on this issue have been updated twice, but it doesn't seem like there was a resolution on what to do going forward. I assume changing the default behavior of omitempty with respect to arrays isn't on the table, but I can think of two ways to address this:

Add support for a custom interface like

type Zeroer interface {
    func IsZero() bool
}

that types can implement. The existing isEmptyValue function would check if the type implements this interface and omit it if IsZero returns true.

One of the comments above suggests adding a custom error type that can be returned from json.Marshaler implementations to indicate that the value should be omitted.

Any thoughts as to which solution would be better? I can pick up this task and file a PR once we've decided on a way forward.

@divjotarora sounds like you want a proposal as you’re looking to add to the API surface.

Also, please search before making either of these suggestions. I'm pretty sure the first one has been made before, for example.

@mvdan Are you referring to #11939? I read through it, and it seems like there are concerns about IsZero, but I don't see any sort of resolution on that thread either. Also, that thread is struct-specific but the use case in this issue is for arrays and potentially other values too. Do you think a new proposal is warranted here or should I wait until there's been more progress on #11939?

@divjotarora yes, that's the issue I mean. I think a new proposal would be so alike, that it would be considered a duplicate. If you have something to add to the original thread, I'd do it there.

I was recently tripped up by this. I think the issue (for me) was that all of "false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string" are also the zero value for their type, and it's easy to then (wrongly) think "zero values are omitted".
The confusion comes from "empty array": by itself, "array" can mean an array of 0, 1, or more elements. It took me a second take to realize "empty array" can only ever refer to zero-length arrays.
I suggest changing the documentation to:

The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any zero-length array, slice, map, or string.

I was recently tripped up by this. I think the issue (for me) was that all of "false, 0, a nil pointer, a nil interface value, and any empty array, slice, map, or string" are also the zero value for their type, and it's easy to then (wrongly) think "zero values are omitted".
The confusion comes from "empty array": by itself, "array" can mean an array of 0, 1, or more elements. It took me a second take to realize "empty array" can only ever refer to zero-length arrays.
I suggest changing the documentation to:

The "omitempty" option specifies that the field should be omitted from the encoding if the field has an empty value, defined as false, 0, a nil pointer, a nil interface value, and any zero-length array, slice, map, or string.

@pmahoney that seems reasonable - want to send a patch?

@pmahoney that seems reasonable - want to send a patch?

Hi all, we kicked off a discussion for a possible "encoding/json/v2" package that addresses the spirit of this proposal.
See the "omitzero" struct tag option under the "Struct tag options" section, which omits a struct field if it is the zero Go value (or has a IsZero method that reports true). Under this semantic, [16]byte{} would be omitted because every element of the array is the zero Go value (i.e., byte(0)).

We can now use omitzero option in this case, see #45669.
Example using this new option works fine: https://go.dev/play/p/BVs9gA3u1bU?v=gotip


”Toporu” is listed in the drop-down menu

Description:
"Toporu" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Toporu" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Toporu, GIURGIU".


Implemented CRUD operation and visualizing backend measurement …

Implemented CRUD operation and visualizing backend measurement …

Completed and Resolved ✅


Update template README to use yarn instead of npm

Public-Facing Changes
Update template README to use yarn instead of npm.

Description
Update template README to use yarn instead of npm.

Actually it sounds like the goal here is to switch the template to npm.


security: First attempt at offload API

This is an initial attempt to realize the new OPI Security session offload APIs [1].
Related to #355
[1] https://github.com/opiproject/opi-api/blob/main/security/proto/openoffload.proto
Signed-off-by: Kyle Mestery<EMAIL_ADDRESS>

can you add SessionTableServer to CI  ?
https://github.com/opiproject/opi-poc/blob/main/.github/workflows/poc-security.yml#L100
like
"${grpc_cli[@]}" ls opi-security-server:50151 opi.security.v1.SessionTable -l

@mestery can you please add SessionTable to CI ? https://github.com/opiproject/opi-poc/blob/main/.github/workflows/poc-security.yml#L100 like
"${grpc_cli[@]}" ls opi-security-server:50151 opi.security.v1.SessionTable -l

Yes, will do that next.


A use case of minisam for 3D lidar slam

Hi, I am a Ph.D. student, from KAIST, South Korea.
This issue is not intended to report any difficulties,
but to share a use-case of miniSAM.
For me, miniSAM was easy to use, especially for Python.
So I have created a simple, practical, and educational purpose 3D lidar SLAM example implemented using miniSAM.
https://github.com/kissb2/PyICP-SLAM
Thank you!

This is cool! Thanks for letting us know it is helpful and set up a great tutorial using it. This is exactly what motivated us to make it public.
@dongjing3309 Maybe we should add a link of this project on our readme?

@kissb2 Thanks a lot for contributing the great example! I briefly looked at the code, looks like it's hard to put this in minisam main repo as other examples, since it's not a single file self-contained example due to utils and data. I will put the link in readme and also the website. Thanks!!

thank you all!

Hi @kissb2 I have run PyICP-SLAM but after installing minisam, I ran into a problem that is:
AttributeError: module 'minisam' has no attribute 'DiagonalLoss
I have built successfully like the guidance in the minisam repo. Could you help me, please ?


Array keyPath for toHaveProperty

Summary
Add support to .toHaveProperty matcher to accept the keyPath argument as an array of properties/indices.
Discussion can be found at #3873
Test plan
Update the .toHaveProperty tests to test against array as the keyPath argument.  Include test for testing that an object has a flattened property like: {'a.b.c.d': 1} and against array indices.

Hi.
It seems that this fine feature lacks the update of flow type-def.
The type in jest_v23.x.x.js is still:
toHaveProperty(propPath: string, value?: any): void;

I'd post the update, but I'm at loss where's the correct place

Flow-typed repo


ARCore not compatible with moto G5S Plus

I am trying to run the sample app on Moto G5S plus. However it giving me an error saying not compatible. Please help me out here.

Even i am facing the same issue.

ARCore's list of supported devices is at https://developers.google.com/ar/discover/supported-devices
https://github.com/google-ar/arcore-android-sdk/issues would be a good place to discuss device support.


docker setup issues

Description
After a few false starts, I thought I'd recap the issue I'm facing.
I've restored the machine to a fresh image, to ensure no cruft remained.

I created the arm user by using the sudo groupadd arm and sudo useradd -m arm -g arm -G  cdrom steps from the regular installation process and set the password. This user UID is 1001
I setup all the drives per the instructions and added to fstab
I went with the pre-built option instructions, and used sudo wget to copy the udev rules to to /etc/udev/rules.d and used sudo mkdir to create the /arm/scripts folder in /opt and then used sudo wget to save the docker_arm_wrapper.sh in the scripts folder.
Finally, I created the container per the instructions and only modified them to include the additional drives, and to reference UID 1001 instead of 1000

Result: I can open the webserver setup, and it says it successfully created all the ARM directories, and I was able to setup the admin user. It says setup of the db was successful. There is an error  [Errno 13] Permission denied: '/opt/arm/installed' and nothings happening when I insert the disc.
I've tried this so many times, I can't imagine what to try next. I'll try one more time using the steps to build my own image, but if you could clarify whether I should be starting with a clean box with only an ARM user (no other user), then from within ARM user, I'll install docker, lsscsi, - then from which directory should I begin the git clone? Where should those files be cloned to? Does it matter? should it be in opt as is done in the manual install steps?
Environment
[OS Distribution and version (run "cat /etc/lsb-release")]
[ARM Release Version or if cloning from git branch/commit (run "git branch" and "git log -1" to get this)]
Log file
[Run the rip in DEBUG and drag and drop the log file onto this comment box]
[>>>>> DRAG AND DROP LOG FILE HERE <<<<<]

 [Errno 13] Permission denied: '/opt/arm/installed' This error can be ignored, its a remnant of the v2_devel branch, normally the devel branch creates an installed file inside /opt/arm to stop database deletion should the user accidentally visit the /setup page again.

If udev rule is setup correctly it should be calling /opt/arm/scripts/docker_arm_wrapper.sh sr[x] and logging success/failures in the syslog.
If you're building from your own image, personally i always git clone into /opt/arm anyway. But it shouldn't matter where as long as the git repo structure stays the same.

Ok thanks! I'll try again later today and report back. tail -f /var/log/syslog wasn't doing the expected, so clearly somethings not right. I'll retry it all and start with cloning into /opt/arm

If you're not getting any output in the system log its most likely a udev issue. I would double check that the udev rule is setup on the host machine.

ok! I started over entirely with an arm user, and ensuring that I was git cloning into opt/arm (needed sudo for this step). What I had to do then was all the chown and chmod gymnastics to allow arm to do the necessary steps, after the clone - which I had to use sudo for everything to work. Ripping sooooo many discs now. One tiny issue which I'll try to fix and otherwise will open an issue for, is that there doesn't seem to be an .abcde.conf file in the home/arm/config directory (I looked for it, a hidden file but it's not there at all - perhaps I'm looking in the wrong place though) - I'll try adding an old version of one I used to use in another project.

Ive added some more comments to the docker wiki, hopefully it helps in future.
As for the .abcde.conf does it exist inside home/arm/ ? This is the real location for it, ARM should have created a link in the config folder though.


HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler (branch-2)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m  8s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 29s

branch-2 passed

+1 :green_heart:
compile
1m  2s

branch-2 passed

+1 :green_heart:
javadoc
0m 42s

branch-2 passed

+1 :green_heart:
shadedjars
4m 54s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 17s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 35s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
0m 35s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
javadoc
0m 40s

the patch passed

-1 :x:
shadedjars
3m 36s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 15s

hbase-common in the patch passed.

-1 :x:
unit
0m 35s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

21m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ff94242e99d7 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 /<PHONE_NUMBER>b39fceb9a424dc6252337fa33d24a2

Default Java
Temurin-1.8.0_412-b08

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/testReport/

Max. process+thread count
354 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  7s

branch-2 passed

+1 :green_heart:
compile
1m 13s

branch-2 passed

+1 :green_heart:
javadoc
0m 46s

branch-2 passed

+1 :green_heart:
shadedjars
5m 34s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 33s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 43s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
0m 43s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
javadoc
0m 46s

the patch passed

-1 :x:
shadedjars
4m  1s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 31s

hbase-common in the patch passed.

-1 :x:
unit
0m 41s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

23m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 3e0b83ecd3bc 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 /<PHONE_NUMBER>b39fceb9a424dc6252337fa33d24a2

Default Java
Eclipse Adoptium-11.0.23+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/testReport/

Max. process+thread count
385 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 13s

branch-2 passed

+1 :green_heart:
compile
1m 17s

branch-2 passed

+1 :green_heart:
javadoc
0m 43s

branch-2 passed

+1 :green_heart:
shadedjars
5m 57s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 38s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 46s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
0m 46s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
javadoc
0m 42s

the patch passed

-1 :x:
shadedjars
4m 16s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 12s

hbase-common in the patch passed.

-1 :x:
unit
0m 46s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

24m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 785c1c37e022 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 /<PHONE_NUMBER>b39fceb9a424dc6252337fa33d24a2

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/testReport/

Max. process+thread count
377 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 15s

branch-2 passed

+1 :green_heart:
compile
3m 27s

branch-2 passed

+1 :green_heart:
checkstyle
0m 51s

branch-2 passed

+1 :green_heart:
spotbugs
2m  7s

branch-2 passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s

Maven dependency ordering for patch

-1 :x:
mvninstall
1m 28s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
1m 26s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

-0 :warning:
javac
1m 26s
/patch-compile-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 12s
/results-checkstyle-hbase-common.txt
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
spotbugs
0m 28s
/patch-spotbugs-hbase-server.txt
hbase-server in the patch failed.

-1 :x:
hadoopcheck
1m 20s

The patch causes 20 errors with Hadoop v2.10.2.

-1 :x:
hadoopcheck
3m  6s

The patch causes 20 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
4m 56s

The patch causes 20 errors with Hadoop v3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s

The patch does not generate ASF License warnings.

24m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 758309d035dc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 /<PHONE_NUMBER>b39fceb9a424dc6252337fa33d24a2

Default Java
Eclipse Adoptium-11.0.23+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  1s

branch-2 passed

+1 :green_heart:
compile
3m 21s

branch-2 passed

+1 :green_heart:
checkstyle
0m 50s

branch-2 passed

+1 :green_heart:
spotbugs
2m  0s

branch-2 passed

+1 :green_heart:
spotless
0m 45s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  8s

the patch passed

+1 :green_heart:
compile
3m 23s

the patch passed

+1 :green_heart:
javac
3m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 13s
/results-checkstyle-hbase-common.txt
hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
spotbugs
2m 16s

the patch passed

+1 :green_heart:
hadoopcheck
16m 28s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 44s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s

The patch does not generate ASF License warnings.

40m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 2366aaa231ba 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f077349e991af3542bcf70cd559d12539e7b343f

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 43s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s

branch-2 passed

+1 :green_heart:
compile
1m 18s

branch-2 passed

+1 :green_heart:
javadoc
0m 42s

branch-2 passed

+1 :green_heart:
shadedjars
5m 58s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  5s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed

+1 :green_heart:
shadedjars
6m  1s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 14s

hbase-common in the patch passed.

+1 :green_heart:
unit
209m 43s

hbase-server in the patch passed.

239m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 5a01fcb6825a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f077349e991af3542bcf70cd559d12539e7b343f

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/testReport/

Max. process+thread count
4597 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 25s

branch-2 passed

+1 :green_heart:
compile
1m  2s

branch-2 passed

+1 :green_heart:
javadoc
0m 41s

branch-2 passed

+1 :green_heart:
shadedjars
4m 55s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed

+1 :green_heart:
shadedjars
4m 55s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 14s

hbase-common in the patch passed.

+1 :green_heart:
unit
225m 33s

hbase-server in the patch passed.

252m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 34370741ead8 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f077349e991af3542bcf70cd559d12539e7b343f

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/testReport/

Max. process+thread count
4195 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 10s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  2s

branch-2 passed

+1 :green_heart:
compile
1m 12s

branch-2 passed

+1 :green_heart:
javadoc
0m 45s

branch-2 passed

+1 :green_heart:
shadedjars
5m 30s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  4s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed

+1 :green_heart:
shadedjars
5m 29s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 32s

hbase-common in the patch passed.

+1 :green_heart:
unit
232m 53s

hbase-server in the patch passed.

262m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6181

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 315524793eda 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / f077349e991af3542bcf70cd559d12539e7b343f

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/testReport/

Max. process+thread count
4426 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6181/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


don't persist the java home path for shared local dev run configs

fixes #1094

@etanshaul can you provide more detail as to how that property is used.  What impact does not persisting the path have?  Shouldn't java home path always be provided by the module?

@patflynn
The project JDK is fetched when the server instance is run. This is so that the JAVA_HOME environment variable can be set for the dev app server.
Persisting it only has the effect of saving it when the user chooses to "share" the run configuration - if "share" is not checked, then no xml file is created. When shared, this has the incorrect outcome of saving a user's path to the JDK which would cause problems when the shared config is version controlled (as described in the referenced bug).
Not persisting it does not have any effect as the JDK value will be fetched on each server run.
See https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/942 for details on the initial implemation of this. + @aslo (the auther of that PR) - does this sound correct to you?

Worth pointing out too:
Weather this is persisted or not has no effect on if the dev app server will run correctly: as I mentioned, the JDK value is retrieved on each run of the dev app server.
Looking at the user reported bug more closely it seems that its merely a problem of unnecessary commits:

this behaviour results in occasional version control commits and unnecessary conflicts.

I verified this too. The correct env variable is set regardless of if this is persisted or not, so this fix will just prevent excess commits for those who version control their shared run configs.

Actually, if we're not persisting javaHomeDir, is it still required in the class, or can we get rid of the member completely?

I wondered that too. But looking at @aslo's related PR (#942) I think this is in preparation for supporting a JDK chooser from within the server configuration. @aslo can you further comment on this?

My memory of https://github.com/GoogleCloudPlatform/google-cloud-intellij/pull/942 is a bit hazy, but I don't believe it should be necessary to keep javaHomeDir as a member of AppEngineModelSettings if we're no longer persisting it. It's also not necessary to keep that field in order to implement a jdk chooser.
I think AppEngineModelSettings.javaHomeDir is read elsewhere though, so you'd need to update any references to grab that setting from elsewhere if you do remove it.

@joaoandremartins @patflynn @aslo
ptal. I removed the javaHomeDir var from the persisted model settings class altogether.

Go for it


Add template support for solidity configuration

Hey guys,
This PR extends the hardhat.config.ts.template.mjs template.
Currently we can change the solidity version, however solidity configuration  has more options.
I started experimenting with a uniswap-v2 extension, the uniswap contracts need an older compiler version, so I'd need to use multiple compilers.
With this current change I was able to create an extension with multiple compilers.
Let me know what do you think.
Thanks,
Tamas

Thanks for this @moltam89 !!
Without testing it, one thought: this will break all the existing extensions that use the solidity Version. This is something that we need to think about for the future (cc @technophile-04 @rin-st). We are in a stage where it might be fine to do so, but just mentioning it here.
In this particular case, a safer alternative could be to leave solidityVersion and add a new one soliditySettings
Let's see what others think too!

Thanks for the reply @carletex!
Yeah, you're right, if someone already used the solidity version in an extension, that would break.
I checked that this option was added recently, also, I couldn't really figure out a way to preserve the solidity version option.
The Solidity configuration can describe a single compiler, or multiple compilers, and the formats are different. I think the only option is to replace the whole solidity object, but there might be other solutions I missed.
solidity: {
    version: "0.8.17",
    settings: {
      optimizer: {
        enabled: true,
        // https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options
        runs: 200,
      },
    },
  },

solidity: {
    compilers: [
      {
        version: "0.8.17",
        settings: {
          optimizer: {
            enabled: true,
            // https://docs.soliditylang.org/en/latest/using-the-compiler.html#optimizer-options
            runs: 200,
          },
        },
      },
      {
        version: "0.5.16",
        settings: {},
      },
    ],
  },

Thanks @technophile-04!
So if I understand it correctly, if https://github.com/scaffold-eth/scaffold-eth-2/pull/938 would be merged, we could change the solidity version of the "default" compiler from the template the same way as right now and we could also pass in extra compilers.
Sounds good to me, great idea!

we could change the solidity version of the "default" compiler from the template the same way as right now and we could also pass in extra compilers.

Sounds good to me, great idea!

Yup! Can you update it? Thanks @moltam89!

Resent here:
https://github.com/scaffold-eth/create-eth/pull/129


Variables from OnTime

Would like to request that the Companion module be able to get variables from Ontime. Things like:

OnAir/OffAir status
Current running time
Current Title and Subtitle
Current Cue Start, End, Duration

This would be super helpful as we build out our Companion buttons!
Thanks!

Hi @tcconway , have you got a chance to check the changes in the latest beta?

Hi @cpvalente  -- I'm running companion (3.0.0+5393-beta-c304f676), but don't see the variables @kellhogs mentioned...perhaps I'm running the wrong ver? Would I need to get beta code for this module directly? Thanks all!

Hey @tcconway,
unfortunately my changes haven't been merged to the official repository yet. So to test the changes you would need to clone my repository (https://github.com/kellhogs/companion-module-getontime-ontime) and run it on a local development instance of companion.
I haven't gotten around to make the module v3 ready yet. Some features are working in v3 and some don't. So it would be best if you test it with the latest stable version of companion.

Thanks @kellhogs for the clarification.

@kellhogs can this be closed?

I've implemented the variables as requested by @tcconway
I would like to get feedback from @tcconway on the implementation before we close this.

Closing the issue as implemented. No more actionable points here

Thanks for working on this! I do only see "undefined" variable data though.

Hi @tcconway, great to hear from you
There have been some braking changes in the API recently. With ontime 2.9.0 you need the module version 2.3.0


Allow ssr cookies

Description
SSR currently blocks setting cookies and strips them from requests because our CloudFront doesn't pass cookies. We are adding an environment setting to allow it in CloudFront and this allows the setting to disable the cookie blocking code from here.
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Documentation update
[ ] Breaking change (could cause existing functionality to not work as expected)
[ ] Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop
Adding a required argument to a function
Changing the data type of a function parameter or return value
Adding a new peer dependency to package.json

Changes

Put setting in SSR code to disable cookie blocking
Add test endpoint to MRT app for cookies

How to Test-Drive This PR

Locally set MRT_ALLOW_COOKIES to true in env or configure ssrAllowCookies to true and then see that cookies work
Use /cookie?name=test&value=test in mrt app to check

Checklists

General

[x] Changes are covered by test cases
[ ] CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance
You must check off all items in one of the follow two lists:

[x] There are no changes to UI

or...

[ ] Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
[ ] Changes comply with WCAG 2.0 guidelines levels A and AA
[ ] Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

[ ] Changes include a UI text update in the Retail React App (which requires translation)

@bredmond-sf don't we want to test this in local dev / build-dev-server.js?
I was thinking about our recent conversation and realized that although we don't have .env.development you could still test this locally via SSR_ALLOW_COOKIES=true && npm start if you add the change there

@bfeister I dug a bit and understand this better. I'm using the mixin now in dev server

Please address the naming of the env var and server setting, then we're in good shape to ...

Allow ssr cookies #1318 (comment)
Allow ssr cookies #1318 (comment)

🚢 🚢 🚢

@johnboxall I think I've got this right now

Also... @bredmond-sf you need to run npm run lint:fix from the monorepo root to get passing tests and fix your linting errors

@bfeister thank you, done!


Failure to start in ubuntu 19.04

Hi!
I had the driver working wonderfully in Ubuntu 18.10. Once I updated to 19.04 it stoped working with this Error:
Finding USB device. . . Done!
Reading configuration. . . Done!
Preparing driver. . . Done!
Setting up driver. . . Done!
	Tablet model name         GT-191
	Buttons                   disabled (0)
	Scrollbar                 disabled (0)
	Notifications:            ENABLED
		for buttons       ENABLED
		for scrollbar     disabled
	Screen                    Enabled (1920x1080)
	Current Monitor Setup     [monitor_3]
	Multi Monitor Setup       ENABLED
	Calling xrandr            ENABLED

Setting up multiple monitors. . .
Running xrandr. . .
Traceback (most recent call last):
  File "./huion-tablet-driver.py", line 743, in <module>
    main.run()
  File "./huion-tablet-driver.py", line 33, in run
    multi_monitor()
  File "./huion-tablet-driver.py", line 223, in multi_monitor
    cmd='xrandr {}'.format(main.settings['xrandr_args'])
KeyError: 'xrandr_args'

I traced back the error to the line 663:
        main.settings['total_screen_width'] = ast.literal_eval(config.get(current_monitor_setup,             'total_screen_width').split("#",1)[0].strip())
I tested a bit and seems that ast.literal_eval fails to eval the string "2560 + 2560 + 1920". I researched a bit and seems that literal_eval shouln't eval expressions bit it was doing it because of compatibility reasons. (https://stackoverflow.com/questions/40584417/why-does-ast-literal-eval5-7-fail)
I changed it to a normal (and more dangerous) eval and it works now. I wond't suggest to use eval in a driver that runs with sudo, but maybe you can find another way to make the maths there. I'm not an expert in python.

Thank you very much for the through investigation.
I found the module numexpr is probably the best option for safely parsing algebraic expressions, and it's already present in major distributions repositories.
So I've replaced all calls to ast.literal_eval for calls to numexpr.evaluate, and it seems to works well.
You'll have to install the additional dependency (sudo apt install python3-numexpr) and then it should work just fine using the last version of the script.


Create CastleWindsor DI integration

[ ]  Implement CastleWindsor.TypeRegistrar.
[ ]  Implement CastleWindsor.TypeResolver.
[ ]  Unit tests for classes.
[ ]  Implement CommandAppBuilder extension method for CastleWindsor.
[ ]  Extension method unit tests.
[ ]  Sample project for CastleWindsor integration.
[ ]  Update docs: readme, release notes.
[ ]  Release.

Issue postponed for the time being... waiting for Castle.Windsor to update to .NET 6.


Ability to disable metrics exporter for helm-installed components and daprd

Description
This PR makes the following minor tweaks with regards to the --enable-metrics flag.

Pass --enable-metrics=false in helm where appropriate when global.prometheus.enabled=false. This will disable the prometheus exporter (listening port) for the dapr system components (does not include daprd).
For daprd, add dapr.io/enable-metrics annotation to the sidecar injector so it can pass true or false to the --enable-metrics flag of daprd
Add the --enable-metrics flag to daprd which was absent before this PR
Add EnableMetrics to AppDescription in /test/platforms/kubernetes/app_description.go in case that is a needed setting for tests in the future

Issue reference
Resolves #2677 - @pzou19741 should be able to prevent daprd from listening on port 9090 by adding the dapr.io/enable-metrics: "true" annotation to his deployment.
If this PR is merged, I will look through the docs site for any pages that need to be updated with this information. This most likely page is here. Setting enabled: false in the metric spec configuration may only disable metric collection but still initialize the exporter to listen on --metrics-port.
Checklist

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Please, review E2E tests.


Add support for pagination in monitor subparser

Pagination is mapped to PgDn (Next Page) and PgUp (Prev. Page),
allowing content to overflow the visible screen and still be rendered on
a new page.

Coverage increased (+0.03%) to 96.784% when pulling c3ca998f2d250dee2b4bec3987e71e9fc3ddd5fb on karlding:add_monitor_pagination_support into dda878986b36d355bf8d044663d6b3c0522e0b62 on eerimoq:master.

Coverage increased (+0.03%) to 96.784% when pulling c3ca998f2d250dee2b4bec3987e71e9fc3ddd5fb on karlding:add_monitor_pagination_support into dda878986b36d355bf8d044663d6b3c0522e0b62 on eerimoq:master.


StyleLint plugin should work without configuration and just use default one

Currently it throws exception for this config:
plugins: [
  new StyleLintPlugin()
]

This is fix for this use case

Coverage increased (+7.8%) to 95.0% when pulling e03443cb24ad929db0e4ca31998d469d00386c90 on artyomtrityak:master into 53a19b54e5e1f109e904411aff61695bd5170126 on vieron:master.

I don't think we should requiring config, default one works great. Same as eslint

Coverage increased (+7.8%) to 95.0% when pulling b1799147557ca90606262f699bc5ded2e06ce7eb on artyomtrityak:master into 53a19b54e5e1f109e904411aff61695bd5170126 on vieron:master.

@vieron I've had some time to think about this and I think it's a good idea. Do you have any objections? If not I'll release this as the next version :)


cni: full repair in repair controller

Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.19
d60d686a7d86836d313dc9c1fb87f162485cad4e
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Provide configurable block time and result wait time

It's faster to run integration tests by configuring smaller block time which is possible through the gochain-local repo. However, the score client is not configurable for a manually configured block time.
https://github.com/icon-project/javaee-annotation-processor/blob/92b3edbc1d8384a591b57097b5960fbd00ee6dce/score-client/src/main/java/foundation/icon/score/client/DefaultScoreClient.java#L57-L58
Thus, it doesn't take advantage of shorter block time in the local environment. It would be better to be able to configure block time in score client too so that score-client can be easily used with the manually configured block time.

Implemented in https://github.com/icon-project/javaee-annotation-processor/commit/929c862f16dbfe7d1792885ab8a274577cdf25ab
BLOCK_INTERVAL is removed. Instead, resultRetryWait * 2 is used and it can be configured by void _resultRetryWait(long resultRetryWait)

Thanks for the update.


[#5833] Ensure direct memory is released when DirectPoolArena is coll…

…ected
Motivation:
We need to ensure we release all direct memory once the DirectPoolArena is collected. Otherwise we may never reclaim the memory and so leak memory.
Modifications:
Ensure we destroy all PoolChunk memory when DirectPoolArena is collected.
Result:
Free up unreleased memory when DirectPoolArena is collected.

@Scottmitch @trustin PTAL

Looks like there are other places leaking memory.
I tried the following test case and it failed in 10 seconds.
    @Test
    public void testNoCleanerDirectByteBuffer() throws InterruptedException {
        // System.setProperty("io.netty.maxDirectMemory", "0");
        for(;;) {
            PooledByteBufAllocator allocator = new PooledByteBufAllocator(true);
            allocator.buffer(8000).release();
            allocator.freeThreadLocalCache();
            System.gc();
        }
    }

But if I set System.setProperty("io.netty.maxDirectMemory", "0");, it doesn't fail.

I also built the netty and run our tests, still saw the OutOfMemoryError.

@zsxwing sorry I missed something. please check again

@trustin PTAL again

@Scottmitch can you take another look as well

👍 I just tested this PR and verified it fixed the issue I reported.

Cherry-picked into 4.1 (5986c22) and 4.0 (b861961e60bc599c87cecaf82d2ca96831336bd8)


Fix bug currency can be negtive

https://rockabox.tpondemand.com/entity/9470

There should probably be a unit test for this behaviour?

noted, will add

Test added :)

Should there be a message to the user specifying that they can't add negative numbers? also this will need a squash

@nwhite89 have squashed. It will show user the message  'Please enter a valid monetary value.' which cover the case of a negative number.

Oh yeah ok cool thanks @jess0407 will merge


Idea: filters for private (starts with an underscore) functions and methods

Maybe like this:

--private - only functions and methods with a name that starts with _
--unprivate (or --public - but --unprivate is more consistent with --undocumented and --untypedand--unasync`) - exclude those private methods and functions
--dunder - only functions and methods that match are __blah__.

Open question: should --private return __init__ etc? Are dunder methods considered private? I think probably not.

My main use-case for this is a CI check which enforces documentation on everything except for private functions and methods:
symbex --unprivate --undocumented --check

I think classes with a leading _ in their name _MyClass should be treated as matching the private filter too.

Docs: https://github.com/simonw/symbex/blob/ced957da0569777efdfbd12a9a828e5816c06c54/README.md?plain=1#L103-L105


Render 3d overlay for displaying skeleton (during calibration, verifying bone lengths?)

We're an overlay, so we should be able to do this.
I was originally planning on hacking something together using openvr's overlay render models. However, those seem to have been removed. The remaining option to implement this is to place a 2d overlay (either relative to head or "projection") and render in stereo.
"Small" issue, given the nature of this being a quick application written in C++, is that there's no rendering engine. I'm also not very familiar with rendering, in general. >_>
Something to look at is Aardvark, either as building a gadget for it or as a reference to how to render a 3d overlay for openvr.
Also worth taking a look at https://bkaradzic.github.io/bgfx/overview.html or similar libraries.

I'm gonna close this for now. Considering it out of scope for the current codebase, I think I'd rather start with something that renders an overlay, then rewrite/merge the feeder app into that overlay.


step extension docs

This PR is to add documentation for creating a custom view, or Step Extension. There was already a "Custom Views" post that I've essentially just updated to include details of the Step Extension API.
NOTE: This is NOT documentation for the API, this is just for creating a Step Extension. The next PR would include details about the methods exposed, but this was a requirement for that.
I also added some other nice changes in:

Added a markdown render hook for all remote links (those that don't begin with /) to be opened in a new tab.
Fixed a lot of formatting for syntax highlighting. Now we can actually take advantage of code line number highlighting for certain code types. See screenshots below.
Overrode the footer so we could make changes to it. I changed the URL to just show the handle for social media stuff.
Removed unused references to Baidu, Google Maps plugin, etc.
Changed typography a bit to use 'Lato' as the base font, as it's more readable.

Screenshots
Code Syntax Inline (before)

Changes
I also updated old posts that were not using code blocks, since they won't use the styling. Sometimes the inline styling is fine for a short piece of code, but not for a block. See the difference here:

With highlights:

Footer:

relates to https://github.com/KaotoIO/kaoto-ui/issues/214

Thanks @Delawen , though for some reason the website isn't being updated?

There is some syntax error:
https://github.com/KaotoIO/kaoto.io/runs/6826513234?check_suite_focus=true


[DebugInfo][SILGen] Ensure "guard let" is lowered with a non-implicit location

Prior to this patch, a "guard let" was being lowered with an implicit debug location, causing it to be dropped in later stages of the compiler, and making it impossible to set a breakpoint in that line.
This was tracked down to a piece of code in SILGenFunction::emitExprInto, which takes an optional Location parameter that was being ignored in one code path.

I had changed the test to make sure I saw it failing and forgot to undo the change prior to committing..

Other than that, the tests are clean. I also ran the LLDB tests locally

@swift-ci please test

@swift-ci please test


Removed set-value dependency in Tasks/DownloadBuildArtifactsV0

The dependency package was removed by running: npm audit fix.
Affected package where set-value was is: artifact-engine
This affects the package set-value before 2.0.1, and starting with 3.0.0 but prior to 4.0.1. A type confusion vulnerability can lead to a bypass of https://github.com/advisories/GHSA-4g88-fppr-53pp when the user-provided keys used in the path parameter are arrays.

solved in https://github.com/microsoft/azure-pipelines-tasks/pull/16297


Excel Parsing Issue.

Some Method may have Custom Parameter types.
So if the cell in Excel need to convert to Custom Type, We have to customizing the data.
How can i handle them?

If parameter Type is Primitive Type like int, double, char... (including Wrapper Types)
Convert them
If not, Just hold them as String Type. It may be mock Name or Custom Types.

It needs Another Idea.

I conclude it if there are custom type parameters, then just stay as a String value. but it must mean Mock name.
So Tester must make mock Object with its name.


Layout options

Is your feature request related to a problem? Please describe.
The editor provides easy tools to quickly create websites. The only problem I have is for more advanced layouts. For example to docs page. This page has a sidebar, which I don't think to be possible to do with primo yet.
Describe the solution you'd like
For it to work you would have to be able to nest a component. Maybe something like a layout could also work.
Maybe an extra menu item next to the Add content and Add component butten, like Add layout item. Which would then allow to set grid columns or something alike.
Describe alternatives you've considered
Writing the page as one big component maybe?
Additional context
I get that it might be difficult to implement due to complex layering systems. However I do believe it to be crusial for it to work in production environments.

Thanks for the suggestion. Primo actually did have what you're describing in an earlier version, but there were a lot of downsides:

Not all the components in the component library could be used as independent sections
Added complexity in the UI that made content editing & page building more complicated
Lots of added complexity in the codebase that could have been spent on other features

The biggest benefit was being able to have a content block next to a component - so a docs page like what you've described was smoother than the current situation where you have to write the content in a field (to get the side navigation) - but it was far outweighed by the downsides.
We're planning on getting that benefit back later in a different way that doesn't add the negative usability effects by consolidating component & content sections - so in this case you'd add a 'Documentation' component & edit its content by both editing its fields (to update the navigation items) & write on the page to edit the documentation itself.


Chem.Kekulize(mol) error

rdkit version: 2021.03.3
(didn't check in other versions)
Doing
python get_vocab.py --ncpu 16 < aromatic.txt > vocab.txt with aromatic SMILES,
an error occurs because of Chem.Kekulize function.
In chemutils.py,
Before:
def get_mol(smiles):
    mol = Chem.MolFromSmiles(smiles)
    if mol is not None: Chem.Kekulize(mol)
    return mol

After: adding clearAromaticFlags=True
def get_mol(smiles):
    mol = Chem.MolFromSmiles(smiles)
    if mol is not None: Chem.Kekulize(mol, clearAromaticFlags=True)
    return mol

Solved.

Thank you SO much! I have been stuck in the error for a long time.
However, I still want to know whether something different would happen in the later judgement if I changed the code.

Hi, I think I had the same issue. The error message I've got was
"rdkit.Chem.rdchem.KekulizeException: Can't kekulize mol.  Unkekulized atoms: 5 6 7 8 9 10 18 26 27"
Nokimann's suggestion works for me as well, but it would be great if the author or others confirm it.

Just had the same issue as @purplerainf and @Nokimann's suggestion seemed to fix the issue. Thanks!