MessagingApi retrieveSMSResponses not working

Calling this returns an array of InboundPollResponses, all blank

Telstra_Messaging\Model\InboundPollResponse (1)
→protected container -> array (6)
to => null
from => null
body => null
received_timestamp => null
more_messages => null
message_id => null

But the JSON content is
{ "status": "RECEIVED", "destinationAddress": "+XXXX", "senderAddress": "+XXXX", "message": "Tests 4", "sentTimestamp": "2018-02-08T16:42:49+10:00" }

Pushed 1.0.2 with the fix for this into the dev branch
https://github.com/telstra/MessagingAPI-SDK-php/tree/dev


Changes to support reloctable rocm for UT execution

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

This change is no more required, since the code is implemented in a different way.
So closing the PR.


Update typer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.26%. Comparing base (5dd276f) to head (9fa5717).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   92.26%   92.26%
=======================================
  Files           5        5
  Lines         401      401
=======================================
  Hits          370      370
  Misses         31       31

Flag
Coverage Δ

unittests
92.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix so that $CustomModulePath is used

This should resolve issue #189. Not sure this is the way you want it resolved. Since logic was added to the root of the script I moved out the logic from Invoke-Main.

@JustinGrote do you have time to review this? It's a small diff to resolve a regression bug that was introduce in a prior PR. Thanks.


Exporting a datable that is filtered using query parameters?

I am attempting to export a data table to CSV, but when I use query parameters to filter by a set of lookup tables (example: status, classification, using query parameters s and c respectively) and click on the export button, it will only export whatever is currently being searched (or not), and not what is currently shown in the data table, as the query parameters are not passed into the CSV export button.
What is the best way to get around this, since I need to have this multiple filtering functionality that can be exported.

Wrong repo.


feat: uninstall eslint-plugin-jest and ts-jest as dev dependencies

PR Checklist

[x] Addresses an existing open issue: fixes #807
[x] That issue was marked as status: accepting prs
[x] Steps in CONTRIBUTING.md were taken

Overview

updated devDependenciesToRemove array with eslint-plugin-jest and ts-jest

@all-contributors please add @vasanth9 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙


Incompatibilities with "service_id" as a column name

At the moment, this gem isn't compatible with any rails application that has a table with a column named "service_id".
It throws
ActiveRecord::DangerousAttributeError:
       service_id is defined by Active Record. Check to make sure that you don't have an attribute or method with the same name.

My application has a table with a column name of "service_id", so this is problematic.

I'm running into the same issue. Any idea when this will be resolved? I would recommend renaming service_id to customer_key, since the Fastly web interface calls it Customer ID, not Service ID.

Also, what is the purpose of defining these methods on the Model? If you don't need to override the global service_id, do you still need the Model methods?
And in what scenario would you need to override the global service_id? Is that common?

Hi,
Sorry for the delay in getting to this issue.  It's definitely something to resolve.  As a simple measure, we will rename this attribute to be much more unique.  That should remove the 99% of collision.

since the Fastly web interface calls it Customer ID, not Service ID

The customer id and service id represent two separate things.  In the relational sense, a customer has many services.

Also, what is the purpose of defining these methods on the Model? If you don't need to override the global service_id, do you still need the Model methods?

In order to perform surrogate-key purging, you need access to that particular Fastly service's unique identifier.  The particular concept of this plugin was to provide simple capabilities to allow easy edge caching and purging at the model level in Rails applications.  Depending on the purpose of your application and your usage of Fastly, you may want to be able map models to different Fastly services.  If you are interested in more information on this, definitely check out https://docs.fastly.com/, or get in touch with us, we'd be happy to help.
It's possible there's another implementation that could totally rid us of worrying about collision in any scenario, but it would probably take a bit more rethinking, and renaming seems a lot simpler and easy to resolve the issue at hand.
Thanks again for pointing this issue out.

Thanks for the explanation, and the fix! I totally missed that the Customer ID and Service ID are different. Makes sense. Perhaps it would help to add a link to this FAQ in this repo's Readme, and/or add a label for "Service ID" on the Fastly website to make it clearer.


How to close a specific dialog?

Is there a way to close a specific dialog in my stack?
I have a function that opens a loading dialog, which is undismissable. While that function is running, some other dialogs may open. Is there any way I can specifically close that first "loading" dialog? Using Get.back() doesn't work as I need those extra dialogs to stay open but only close that first one.
I tried looking in the documentation and couldn't find anything. I thought the "name" parameter in Get.dialog could help but also didn't find a way to close it that way.
Thanks!

I don't know if this is the right approach but I was able to resolve the issue by creating a route and using Get.removeRoute to remove the specific dialog.
final route = GetDialogRoute(
  pageBuilder: (_, __, ___) => MyLoadingDialog(),
  barrierDismissible: false,
);
Navigator.of(Get.context).push(route);

...

Get.removeRoute(route);

With this I was able to push 3 dialogs and only 'pop' the first 2 while keeping the one on top.

SuporteSysrs01
YES! This is the solution for multiple Loading Dialog that can be closed simply by specifying the route generated by GetDialogRoute.
This kind of solution should be included in the official documentation of GetX Route Management. Because Loading dialog is one of the ingredients of a good application.
Thanks SuporteSysrs0

Thanks, helped a lot.
i agree, should be included in docs

Hey there!
I squashed this problem by giving our dialog a custom name. Now you can open a whole bunch of different dialogs at once and close them one by one.
Here's the magic:
static showProgressDialog({String name = "progress-dialog"}) {
  Get.dialog(
    const Center(...),
    routeSettings: const RouteSettings(
      name: name,
    ),
  );
}

void hideProgress() {
  Navigator.of(Get.context!).popUntil((route) =>
      route.settings.name != "progress-dialog");
}

Hey there!
I squashed this problem by giving our dialog a custom name. Now you can open a whole bunch of different dialogs at once and close them one by one.
Here's the magic:
static showProgressDialog({String name = "progress-dialog"}) {
  Get.dialog(
    const Center(...),
    routeSettings: const RouteSettings(
      name: name,
    ),
  );
}

static hideProgressDialog({String name = "progress-dialog"}) {
  if (Get.context != null) {
    Navigator.of(Get.context!).popUntil((route) {
      return route.settings.name != name;
    });
  }
}


Buffer table does not work with materialized columns

When the underlying table has a materialized column, the database raises an exception when trying to flush the buffer to disk. Here's a simple example that demonstrates the problem:
CREATE DATABASE IF NOT EXISTS test;

CREATE TABLE test.nums (
    n UInt64,
    m UInt64 MATERIALIZED n+1
) ENGINE = Log;

CREATE TABLE nums_buf AS test.nums ENGINE = Buffer(test, nums, 1, 10, 100, 1, 3, 10000000, 100000000);

INSERT INTO nums_buf (n) VALUES (1);
INSERT INTO nums_buf (n) VALUES (2);
INSERT INTO nums_buf (n) VALUES (3);
INSERT INTO nums_buf (n) VALUES (4);
INSERT INTO nums_buf (n) VALUES (5);

After inserting a few rows successfully, you get this error:
Received exception from server:
Code: 44. DB::Exception: Received from localhost:9000, ::1. DB::Exception: Cannot insert column m.

The server log shows this stack trace:
2017.07.08 09:58:08.198983 [ 9 ] <Trace> StorageBuffer (nums_buf): Flushing buffer with 4 rows, 64 bytes, age 1 seconds.
2017.07.08 09:58:08.238359 [ 9 ] <Error> void DB::StorageBuffer::flushThread(): Code: 44, e.displayText() = DB::Exception: Cannot insert column m, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2969826]
1. clickhouse-server(DB::ProhibitColumnsBlockOutputStream::write(DB::Block const&)+0x112) [0x2bedfa2]
2. clickhouse-server(DB::SquashingBlockOutputStream::finalize()+0x3f5) [0x2d74145]
3. clickhouse-server(DB::SquashingBlockOutputStream::writeSuffix()+0x11) [0x2d742b1]
4. clickhouse-server(DB::StorageBuffer::writeBlockToDestination(DB::Block const&, std::shared_ptr<DB::IStorage>)+0xb8c) [0x2a1c63c]
5. clickhouse-server() [0x2a1d4f4]
6. clickhouse-server(DB::StorageBuffer::flushThread()+0x63) [0x2a1d793]
7. clickhouse-server() [0x36744ef]
8. /lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba) [0x7ff1c2c656ba]
9. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7ff1c22863dd]

Buffer tables just doing ordinary INSERTs to destination table.
That's why they could not have columns, that are MATERIALIZED in destination table.
This is understandable, but inconvenient behavior.
We could do one of the following:

add a flag, that will allow to INSERT into MATERIALIZED column, if INSERT is generated internally (it will also solve the same issue in Distributed tables);
add a check, that will verify, that Buffer table can INSERT data to destination table.

add a flag, that will allow to INSERT into MATERIALIZED column, if INSERT is generated internally (it will also solve the same issue in Distributed tables);

That is the preferred solution.
This is very easy task (half an hour for those who are familiar with the codebase).

Add a setting insert_allow_materialized_columns, default 0.
Use this setting in InterpreterInsertQuery, InterpreterCreateQuery to bypass ProhibitColumnsBlockInputStream.
Pass this setting to INSERT query in StorageBuffer and in RemoteBlockOutputStream in DistributedDirectoryMonitor.


Update Wordpress and Meteor example README's

Update to be more explicit about using GCE persistent disks, and provide
a quick list of prereqs.
Fixes #8824 #8828

Hi @jeffmendoza, thanks for the PR. May I ask why can't we just point the reader to the Getting started guides instead of repeating the instructions here?

@caesarxuchao see #8824

A nit, otherwise LGTM. Thanks @jeffmendoza.

@caesarxuchao Updated, thanks.

Thank you @jeffmendoza. LGTM.


python3Packages.flake8-quotes: init at 3.4.0

Hi,
This add https://github.com/zheller/flake8-quotes, a  flake8 extension for checking quotes in python
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365983

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.flake8-quotes
python311Packages.flake8-quotes.dist
python312Packages.flake8-quotes
python312Packages.flake8-quotes.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365983

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.flake8-quotes
python311Packages.flake8-quotes.dist
python312Packages.flake8-quotes
python312Packages.flake8-quotes.dist

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 365983

x86_64-darwin

:white_check_mark: 4 packages built:

python311Packages.flake8-quotes
python311Packages.flake8-quotes.dist
python312Packages.flake8-quotes
python312Packages.flake8-quotes.dist


We create UINibs for the same nibName & bundle multiple times, slow performance

BrickKit creates a new instance of a nib everytime when we don't need to, causing multiple costly UINib instantiations.
We should keep a reference to the nibs created and check before we instantiate any UINib.
In order to do this, just subclass UINib and call it something like BrickNib.  Implement hashable based off of nibname and bundle so we can compare the BrickNib we want to create with the BrickNibs we have already made.  (It looks like UINib already conforms to Hashable, I'd double check to see if the hashing it has is what we want)
Should be a decent performance increase upon setting of the BrickSection.

To clarify: should be [hash: bricknib] for o(1) access time

We should also make labelbrick nibless


Incompatible with Terraria 1.3 Update.

When loading a 1.3 world, MoreTerra crashes with the attached error.

I am simply unable to load the world, with 'World Name: Not a valid World file.', and I am unable to select a different world.

We are in the process. There were huge changes the the wld file header. Will update when done.
We hope to get this out soon.
Sent from my Windows Phone

From: Ben<EMAIL_ADDRESS>Sent: 7/3/2015 3:20 PM
To<EMAIL_ADDRESS>Subject: Re: [MoreTerra] Incompatible with Terraria 1.3 Update. (#2)
I am simply unable to load the world, with 'World Name: Not a valid World file.', and I am unable to select a different world.

Reply to this email directly or view it on GitHub:
https://github.com/mike-mo/MoreTerra/issues/2#issuecomment-118410711

Just to note, I am running Terraria <IP_ADDRESS>, and MoreTerra 1.13.
I did not receive this error, but instead, this one in #6: "Error Opening World: Parameter name: dateData"
The issue title should probably be more descriptive, such as: "Error Opening World: Unable to read beyond the end of the stream."

As far as I can tell, this project is no longer being maintained.  For now, I'd recommend using Terra Firma as a replacement.

this is now fixed, please get latest binary


Option to define custom IP address ranges in the EUM server

This change is

@JonasKunz , I've implemented your comments :)


Graphing calculator

Calculator Functions
graphing calculator is a scientific calculator with a high resolution screen and includes the ability to plot coordinates and graph functions.
A graphing calculator is a handheld computer that is capable of plotting graphs, solving simultaneous equations, and performing other tasks with variables.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign @vasu-1 this issue to me

Hi can I work on this issue for gssoc'22?

/assign


Nullable enums not validating

Hi, I'm having the following issue. drf-spectacular for some reason generates nullable enums like a oneOf of two enum types, one which contains the enum options and a NullEnum containing only the None option. So for example, if I have the following field in my model:
    building_type = models.CharField(
        max_length=25,
        choices=(('hs', 'House'), ('apt', 'Apartment'), ('farm', 'Farm')),
        default=None,
        null=True,
    )

It will generate the following field in my schema:
...
        building_type:
          nullable: true
          oneOf:
          - $ref: '#/components/schemas/BuildingTypeEnum'
          - $ref: '#/components/schemas/NullEnum'
...
    BuildingTypeEnum:
      enum:
      - hs
      - apt
      - farm
      type: string
    NullEnum:
        enum:
        - null

So the issue I'm having is that drf-openapi-tester fails to validate this when using a valid enum option (e.g. hs in the example). This is because handle_one_of method will fail if the value matches both of the types. It's matching the BuildingTypeEnum correctly because hs is one of the options in the enum, but it's also matching the NullEnum because of these two lines in test_schema_section:
        schema_section_type = self.get_schema_type(schema_section)
        if not schema_section_type:
            return

Since NullEnum doesn't have a type or a properties field, get_schema_type is returning None and so it will exit early without running the validators.
The quickest fix I can think of to support this case is to change those two lines to:
        schema_section_type = self.get_schema_type(schema_section)
        if not schema_section_type and 'enum' not in schema_section:
            return

but maybe theres' some more generic fix?
FTR, this is what drf-spectacular says about this NullEnum type: https://github.com/tfranzel/drf-spectacular/issues/235

Hi, thanks for your report.
I believe the behaviour of DRF spectacular is in fact wrong. Use of oneOf and the null enum are a proposal, not a part of the spec.
I will see about extending support for this. For the time being though, you can turn off the the DRF spectacular behaviour in that library's configs.

Thanks! Yes, that was my plan B, to disable the NullEnum in drf-spectacular. But when I do that it will generate something like this:
        building_type:
          allOf:
          - $ref: '#/components/schemas/BuildingTypeEnum'
          nullable: true

which is not correct according to the OpenAPI Enums documentation because it should contain a null option.
Note that null must be explicitly included in the list of enum values. Using nullable: true alone is not enough here.

But I guess that would be an issue for drf-spectacular 🙂

TBH the way drf spectacular is behaving here is very weird. Why allOf? ffs.
Anyhow, we are always happy for contributions :). But the fix you are proposing is not really a fix - this piece of logic is used not only for enums:
        schema_section_type = self.get_schema_type(schema_section)
        if not schema_section_type and 'enum' not in schema_section:
            return

If you would like to offer a fix PR on your own, please start with adding a test case for the behaviour that is currently buggy - that will be a big help. A followup PR can perhaps be (without actually going into the code) to make a proper enum validator in the validators.py file.

I know this method is not only used for enums, but this extra condition will not affect anything else. The problem is that this check is currently assuming that anything that doesn't have a type or properties doesn't need to be validated, which is not the case of the NullEnum example (assuming that is valid, which I think it is because it's allowed to not have an explicit type and then it just adds an enums property that would have to be validated).
The project already has an enum validator in validators.py, but the problem is that because of this check that we're discussing it is not ran for the NullEnum because the method just returns before it is ran.
I'd be happy to add a PR including tests, but I think i need permissions to be able to create a branch?

I'd be happy to add a PR including tests, but I think i need permissions to be able to create a branch?

See CONTRIBUTING.md :relaxed:

Thanks 🙂

Hey! the author of drf-spectacular here :smile: this issue has been bugging me for a while too.

TBH the way drf spectacular is behaving here is very weird. Why allOf? ffs.

        building_type:
          allOf:
          - $ref: '#/components/schemas/BuildingTypeEnum'
          nullable: true

@Goldziher the reason we do this is because of the $ref semantics. $ref will replace the scope it is located in and thus would wipe out the nulllable. nesting inside a allOf, oneOf creates a new scope and thus leaves the nullable untouched. https://swagger.io/docs/specification/using-ref/ ($ref and Sibling Elements)

I believe the behaviour of DRF spectacular is in fact wrong. Use of oneOf and the null enum are a proposal, not a part of the spec.

i admit i went creative there in order to prevent noise via trivial duplication. @Goldziher what exactly is the proposal part you are refering to (null in enum or oneOf semantics)? the oneOf certainly makes the parsing more difficult, but to my current understanding this is absolutely valid and also the right thing semantically.
happy to support the resolution of this. please point out if i said anything questionable or wrong.

Howdy @tfranzel, welcome :)
Thanks for the explanation - I now understand why you are using allOf and it does make sense for schema reusability.
The proposal component is regarding what "nullable: true/false" means, e.g. whether or not it prohibits / allows null values and how to interpret this.  If I understood this link correctly: https://github.com/OAI/OpenAPI-Specification/blob/master/proposals/003_Clarify-Nullable.md#if-a-schema-specifies-nullable-true-and-enum-1-2-3-does-that-schema-allow-null-values-see-1900
But TBH I left academia to not argue about "semantics" :), so let's not do this.
I will take a look at how we are handling enums later tonight or tomorrow morning. @idesoto-rover are you working on this actively?

@Goldziher No, sorry, I haven't had time to start working on this yet.

Ok, so I have been digging into this on my end. I do find the specs generated by drf-spectacular problematic @tfranzel. I have the following mode:
class Names(models.Model):
    custom_id_field = models.IntegerField(primary_key=True)
    name = models.CharField(
        max_length=254,
        choices=(("mo", "Moses"), ("moi", "Moishe"), ("mu", "Mush")),
        default=None,
        null=True,
        blank=True
    )

Then a serializer / view setup like so:
class NamesSerializer(serializers.ModelSerializer):
    class Meta:
        model = Names
        fields = "__all__"

class NamesRetrieveView(RetrieveAPIView):
    model = Names
    serializer_class = NamesSerializer
    queryset = Names.objects

    def get_object(self):
        return Names.objects.get(custom_id_field=int(self.kwargs["pk"]))

The resulting schema looks like this:
components:
  schemas:
    BlankEnum:
      enum:
        - ''
    NameEnum:
      enum:
        - mo
        - moi
        - mu
    NullEnum:
      enum:
        - null
    Names:
      type: object
      properties:
        custom_id_field:
          type: integer
        name:
          nullable: true
          oneOf:
            - $ref: '#/components/schemas/NameEnum'
            - $ref: '#/components/schemas/BlankEnum'
            - $ref: '#/components/schemas/NullEnum'

The problem from my side is that there is no type in the "name", rather the type property  is present only in the NameEnum.  and both BlankEnum and NullEnum do not have a type.
Although the NullEnum might be ok from a semantic POV, the BlankEnum is definitely not --> blank=True is a django thing, and the translation here to an enum is not good, especially not without a type attached.

PR added, I think this resolves the issue well - I basically replace the oneOf with a merge in the particular case of having multiple enums inside the oneOf.
Feel free to take a look and review the PR.

@idesoto-rover - i release v1.3.4. Please test if it resolves your issue.

Solves the issue! Thank you so much!!! 👏


[1157] Return user to courses index after editing vacancies

Guidance to review
:ship:

 Return user back to where they clicked 'edit vacancies'


Material components blurry on Chrome

Bug, enhancement request, or proposal:
I've been noticing that blurriness of button, input fields and few other components on chrome. It is not just the text, but also the background color and borders. I would like to know if there is any potential fix for this problem?
On chrome:

On Firefox and Edge:

This is tested on a fresh install of material and using prebuilt material theme.
OS: Windows 10
Chrome: Version 68.0.3440.106 (Official Build) (64-bit)
Angular Material Version: 6.4.6

@crisbeto Are you seeing the same on Windows? I was not able to reproduce this myself.

I don't have my Windows machine with me, but I can check it on Monday. That being said, I don't remember noticing anything over the past couple of weeks since this issue was posted.

There does seem to be a slight difference, but I think it's down to Chrome not being as zoomed in as Firefox. Here's a couple of screenshots at my default zoom level:

Here's an alternate screenshot that is at a similar zoom level and which looks identical:


HBASE-27970 Make sync replication also work with FSHLog

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-server generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95)

_ Other Tests _

+1 :green_heart:
unit
2m  7s
hbase-common in the patch passed.

-1 :x:
unit
11m 36s
hbase-server in the patch failed.

34m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 78a4e46cc012 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Eclipse Adoptium-11.0.17+8

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/testReport/

Max. process+thread count
1814 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
3m 37s
master passed

+1 :green_heart:
checkstyle
0m 52s
master passed

+1 :green_heart:
spotless
0m 52s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 19s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s
the patch passed

+1 :green_heart:
compile
3m 26s
the patch passed

-0 :warning:
javac
2m 52s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
1m  1s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 21s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

-1 :x:
spotless
0m 51s
patch has 1 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m 48s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

42m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 3bb607b8ccf7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-general-check/output/patch-spotless.txt

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 26s
master passed

+1 :green_heart:
compile
0m 48s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 13s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
5m 10s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-server generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)

_ Other Tests _

+1 :green_heart:
unit
2m 16s
hbase-common in the patch passed.

-1 :x:
unit
231m 58s
hbase-server in the patch failed.

257m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cde0c836af57 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/testReport/

Max. process+thread count
4333 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  7s
master passed

+1 :green_heart:
compile
3m 31s
master passed

+1 :green_heart:
checkstyle
0m 57s
master passed

+1 :green_heart:
spotless
0m 49s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 32s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
3m 30s
the patch passed

-0 :warning:
javac
2m 52s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 21s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 49s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

41m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 9dca05dd7502 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
4m 50s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
4m 50s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 25s
hbase-server generated 1 new + 95 unchanged - 0 fixed = 96 total (was 95)

_ Other Tests _

+1 :green_heart:
unit
2m 19s
hbase-common in the patch passed.

-1 :x:
unit
217m 13s
hbase-server in the patch failed.

243m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7e47fdc33ce0 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Eclipse Adoptium-11.0.17+8

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/testReport/

Max. process+thread count
5017 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 12s
master passed

+1 :green_heart:
compile
0m 51s
master passed

+1 :green_heart:
shadedjars
5m  8s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 22s
hbase-server generated 1 new + 22 unchanged - 0 fixed = 23 total (was 22)

_ Other Tests _

+1 :green_heart:
unit
2m 15s
hbase-common in the patch passed.

+1 :green_heart:
unit
220m 56s
hbase-server in the patch passed.

245m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b57a3c6e7b0f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 20c4136bf6

Default Java
Temurin-1.8.0_352-b08

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/testReport/

Max. process+thread count
4341 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
3m  4s
master passed

+1 :green_heart:
checkstyle
0m 48s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 46s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

-0 :warning:
javac
2m 33s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 27s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

37m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 7bb22b8270e1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 05f5d5b33c

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 45s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
4m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 55s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  9s
hbase-common in the patch passed.

-1 :x:
unit
217m 46s
hbase-server in the patch failed.

243m 37s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f856a13864ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 05f5d5b33c

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/testReport/

Max. process+thread count
4737 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 11s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 13s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 17s
hbase-common in the patch passed.

+1 :green_heart:
unit
221m 38s
hbase-server in the patch passed.

246m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 68feb644d9c5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 05f5d5b33c

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/testReport/

Max. process+thread count
4347 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
3m  5s
master passed

+1 :green_heart:
checkstyle
0m 45s
master passed

-1 :x:
spotless
0m 46s
branch has 1 errors when running spotless:check, run spotless:apply to fix.

+1 :green_heart:
spotbugs
2m  0s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 43s
the patch passed

+1 :green_heart:
compile
3m  4s
the patch passed

-0 :warning:
javac
2m 34s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 21s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

37m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 6b2cbf30397d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 79fbbc3ef4

Default Java
Eclipse Adoptium-11.0.17+8

spotless
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-general-check/output/branch-spotless.txt

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
0m 56s
master passed

+1 :green_heart:
shadedjars
4m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 11s
hbase-common in the patch passed.

-1 :x:
unit
214m 23s
hbase-server in the patch failed.

240m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 86693c218c67 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 79fbbc3ef4

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/testReport/

Max. process+thread count
4696 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 24s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 24s
master passed

+1 :green_heart:
compile
0m 52s
master passed

+1 :green_heart:
shadedjars
5m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
shadedjars
5m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 15s
hbase-common in the patch passed.

+1 :green_heart:
unit
218m 51s
hbase-server in the patch passed.

244m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 09192901df0f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 79fbbc3ef4

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/testReport/

Max. process+thread count
4239 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/4/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 59s
master passed

+1 :green_heart:
compile
3m  3s
master passed

+1 :green_heart:
checkstyle
0m 46s
master passed

+1 :green_heart:
spotless
0m 42s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 28s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 23s
the patch passed

+1 :green_heart:
compile
3m 26s
the patch passed

-0 :warning:
javac
2m 52s
hbase-server generated 1 new + 194 unchanged - 1 fixed = 195 total (was 195)

+1 :green_heart:
checkstyle
0m 52s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 57s
Patch does not cause any errors with Hadoop 3.2.4 3.3.6.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

39m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 4009274ff94a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6cb15b14d4

Default Java
Eclipse Adoptium-11.0.17+8

javac
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 27s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 15s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
5m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 50s
hbase-common in the patch passed.

+1 :green_heart:
unit
216m 27s
hbase-server in the patch passed.

241m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fe155d5a147f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6cb15b14d4

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/testReport/

Max. process+thread count
4569 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
0m 55s
master passed

+1 :green_heart:
shadedjars
5m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 52s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  9s
hbase-common in the patch passed.

-1 :x:
unit
237m 35s
hbase-server in the patch failed.

265m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5430

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 976ed2e84d60 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6cb15b14d4

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/testReport/

Max. process+thread count
4675 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5430/5/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Prayer bar

Adds a toggle-able prayer bar underneath the health bar, indicating your amount of prayer left.
it can be toggled to show only while praying, only show if your health bar is also visible, or simply be "always on".

I'll probably still want at least the background to have a configurable color though. I think it's fine as long as the default color is consistent. A dropdown list might be more suited as there were only ~4 colors I tried that looked decent, out of many I tested.
I was going to try using a smaller height for the bar to make more space for other bars to be added and to differentiate this more from the health bar, but it didn't look good on its own that way and would maybe need further non-vanilla stuff like a 1px shadow or something to look nice.

I don't think this is related to prayer flicking at all. Maybe this and #1578 could be merged into a "prayer" plugin?

Yeah, I was thinking it'd make sense to merge this and Prayer Flick into a 'Prayer' plugin. Or 'Prayer Indicators' as @deathbeam likes to call it 😄
The plan was to add a tick indicator similar to the Prayer Flick plugin, that flashes over the bar, or something of that sort, and also address #2088 with that too.

Oh I completely misread the OP - I thought this was a prayer-flicking display, since you linked to it on #2088. I guess that's your ultimate goal though. Renaming the plugin to Prayer for this seems pretty clean.

Needs rebase


Feedback: consider returning the callbacks in the setters

Thanks a lot @gereleth for this helpful package. One thing that tripped me up: I tried using on_submit and on_skip as decorators. For example:
widget = BBoxWidget(classes=[...])

@widget.on_skip
def advance():
   ...

@widget.on_submit
def submit():
   save()
   advance()

However, this did not work as intended, as on_submit and on_skip do return None. Maybe it would be an option to return the functions themselves?

Hi, this seems like a good idea at first glance. I'll take a closer look in a few days.

Thanks again for the suggestion, I implemented this in version 0.5.0.

Really cool. Looking forward to use it :)


GoTo Definition doesn't work on VS 2017 with Specflow 2.14

I tried this extension instead of regular Specflow one, from what I observed this extension seems to lack in few areas namely:

Goto Definition doesn't work
No provision to see if the step is missing
Cannot execute tests from file directly and also by right clicking on feature file
Above features might not be standard part of the package but that was my observation

Go to definition and missing step indication should work. The problem in your case that the binding did are not discovered properly by deveroom. This is done normally after build.
Could you please open the "Output" window and switch to the "Deveroom" pane to see if it reports any error and paste the error here?

I tried everything as you said Gaspar, this is output of deveroom in VS 2017
Even after sometime I don't get any bindings.
I don't get option to generate bindings and also to somehow run the feature file

@ParagRaut I see. It looks like Deveroom does not recognize your project as a SpecFlow project.
Could you please let me know the (SpecFlow related) NuGet packages you have installed?
Also could you please check the latest log file at %LOCALAPPDATA%\Deveroom to see if there is any further information about the problem?

 Currently Deveroom only able to detect SpecFlow version from NuGet packages. Later we plan to provide support for binary-based references as well, but unfortunately, that is not ready yet.
I will close this issue now, but create another one so that you can track the implementation status.

yes and thanks Gaspar, also let me know if you're also planning on other features as I mentioned earlier and also might be support for Visual studio for Mac

#14


Give friendly option to reset admin's password

Right now there is no direct option to reset admin password. For non technical people it is difficult to reset admin password with database access. Add an option to reset admin password without touching database.

With this fix to reset password for a user(user can be admin also), follow the mentioned steps,

Create a file with the name password or password.txt under mycontroller/conf/
File should contain username and password with comma separated Without space, example: admin,admin
Save your file.
Stop and Start MyController
After started successfully you can see a line in mycontroller/log/mycontroller.log as follows,

2016-08-04 15:18:14,339 INFO [main] [org.mycontroller.standalone.ResetPassword:86] Password successfully update for the user[admin]


Added Pull Request Template

What were proposed in this Pull Request ?

Added Pull Request template for github

@mli For open source contribution guideline Pull Request template has been added

I'm going to close the PR since there is no activity for more than 1 month. But please feel free to re-open it and update with the master.


Reachability analysis doesn't run for query actions

Description:
$title.
Steps to reproduce:
public function main() {
    error? n = from int i in 0 ... 2
    do {
        return;
        int _ = 1; // no error!
    };

    _ = n is error;
}

Affected Versions:
slbeta6

Fixed in https://github.com/ballerina-platform/ballerina-lang/pull/34454.


src: change js runtime repo and fix linting issues

This commit changes the repository that is used for the JS language runtime to https://github.com/openshift-cloud-functions/faas-js-runtime. There are also a number of immaterial changes that address go lint errors in this file.

Replaced by #26


[test, top_earlgrey] Reduce timeout values for otbn_ecdsa_op_irq_test

lowRISC/OpenTitan#14428 helped to reduce both the simulated and wall clock time for these tests. This PR adjusts the specified timeout values accordingly.

As discussed here https://github.com/lowRISC/opentitan/pull/14428#issuecomment-1223778988

|   Old/New    |      Name       | Tests                     |  Max Job Runtime  |  Simulated Time  |  Passing  |  Total  |  Pass Rate  |
|:------------:|:---------------:|:--------------------------|:-----------------:|:----------------:|:---------:|:-------:|:-----------:|
|     New      | chip_sw_otbn_op | chip_sw_otbn_ecdsa_op_irq |      3.510h       |     17.909ms     |     1     |    1    |  100.00 %   |
| Old (nightly)| chip_sw_otbn_op | chip_sw_otbn_ecdsa_op_irq |      1.141h       |     24.317ms     |     1     |    1    |  100.00 %   |

->  run_timeout_mins = 300, sw_test_timeout_ns = 22_000_000
|   Old/New    |      Name       | Tests                               |  Max Job Runtime  |  Simulated Time  |  Passing  |  Total  |  Pass Rate  |
|:------------:|:---------------:|:------------------------------------|:-----------------:|:----------------:|:---------:|:-------:|:-----------:|
|     New      | chip_sw_otbn_op | chip_sw_otbn_ecdsa_op_irq_jitter_en |      3.542h       |     20.806ms     |     1     |    1    |  100.00 %   |
| Old (nightly)| chip_sw_otbn_op | chip_sw_otbn_ecdsa_op_irq_jitter_en |      1.145h       |     27.011ms     |     1     |    1    |  100.00 %   |

-> run_timeout_mins = 300, sw_test_timeout_ns = 29_000_000

Some seeds in the nightly regression appear to need longer simulated time:
https://reports.opentitan.org/hw/top_earlgrey/dv/latest/report.html
UVM_ERROR @ * us: (chip_sw_base_vseq.sv:218) virtual_sequencer [chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = * ns has 1 failures:

Test chip_sw_otbn_ecdsa_op_irq has 1 failures.
0.chip_sw_otbn_ecdsa_op_irq.1078378066
Line 404, in log /container/opentitan-public/scratch/os_regression/chip_earlgrey_asic-sim-vcs/0.chip_sw_otbn_ecdsa_op_irq/latest/run.log

  UVM_ERROR @ 22011.630257 us: (chip_sw_base_vseq.sv:218) uvm_test_top.env.virtual_sequencer [uvm_test_top.env.virtual_sequencer.chip_sw_base_vseq] SW TEST TIMED OUT. STATE: SwTestStatusInTest, TIMEOUT = 22000000 ns

  UVM_INFO @ 22011.630257 us: (uvm_report_catcher.svh:705) [UVM/REPORT/CATCHER]
  --- UVM Report catcher Summary ---

Hi @sriyerg ,
I've noticed that, too. Thus, I've increased the time out values again (~28us now) and also increased the rate at which entropy source generates raw entropy with this PR #14571. In the last regression, both ecdsa tests passed with a simulated time of around 18ns.

Hi @sriyerg , I've noticed that, too. Thus, I've increased the time out values again (~28us now) and also increased the rate at which entropy source generates raw entropy with this PR #14571. In the last regression, both ecdsa tests passed with a simulated time of around 18ns.

Thanks @vogelpi!


Update topology-mainnet

Participating in Koios Cluster as instance Provider
Description
We have added the gRest running IP address to the topology-mainnet.json file with the current version we are installing as koios-1.0.10
Where should the reviewer start?
We are running gRest instance with koios-1.0.10. You can access test APIs.
Sample query: http://<IP_ADDRESS>:8053/api/v0/tip
Motivation and context
We built CNODE and DBSync and installed gRest through the cardano-community documentation and through that we found the information to join the Koios Cluster because we wanted to contribute to the Cardano community more development
Which issue it fixes?
Many people join the Koios Cluster as the Version Provider I believe will make the koios API system stable and under high load & at the same time increase the ability to serve the programming community better
How has this been tested?
I have been testing the APIs and our team wants to dig deeper into the blockchain system with teams around the world. Where we can exchange and learn more experiences

While the validations against this instance looks good, left some comments on telegram regarding your instance


fix typos in manifest

I was reading the manifest and found these typos. Looking forward to learn more about the project

Thank you very much.


[OTHER] Profile page codebase refactor

What would you like to share?
Profile page code is burdened with redundancy and superfluous code which might make it difficult for the developers to read, understand and contribute efficiently.
As a seasoned open-source enthusiast and an ardent advocate of clean and efficient code, I firmly believe that "less is more" when it comes to software development. My aim is to meticulously analyze, streamline, and refactor this component, preserving its exceptional functionality while eliminating any extraneous code that hinders its performance and clarity.
I envision a streamlined component that empowers users with its improved performance and readability. With careful attention to detail and adherence to best practices, I am confident that the result will not only be a cleaner look but also a testament to the commitment of this project to maintain excellence.
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

What would you like to share?
Profile page code is burdened with redundancy and superfluous code which might make it difficult for the developers to read, understand and contribute efficiently. As a seasoned open-source enthusiast and an ardent advocate of clean and efficient code, I firmly believe that "less is more" when it comes to software development. My aim is to meticulously analyze, streamline, and refactor this component, preserving its exceptional functionality while eliminating any extraneous code that hinders its performance and clarity. I envision a streamlined component that empowers users with its improved performance and readability. With careful attention to detail and adherence to best practices, I am confident that the result will not only be a cleaner look but also a testament to the commitment of this project to maintain excellence.
Additional information
No response
Record

[x]  I agree to follow this project's Code of Conduct
[x]  I have checked the existing issues
[x]  I'm a GSSoC'23 contributor
[x]  I want to work on this issue

Kudos to you for donning the 'Code Detective' hat! Our profile page might have a PhD in redundancy, but we'll teach it the art of simplicity. Get ready for the code makeover of a lifetime – welcome to the 'Less is More' Academy! 🎓💻


Country Display Modes

I've seen a few people using the plugin by setting onlyCountries to a single country, which looks terrible. I propose we have a new initialisation option e.g. countryMode, which could be "full" (normal), "single" (no dropdown/arrow), or "none" (no selected country or dropdown - just a normal input).

I was also thinking about having an excludedCountries option for cases where you require most of the countries on the list, but would like to remove some of the more obscure countries. If onlyCountries is set that would take precedence, of course.

There's another issue for that: https://github.com/Bluefieldscom/intl-tel-input/issues/200

Do you mean a country flag + input when countryMode = single?

Yes: we would display the flag next to the input, but no arrow, and no dropdown.

That's exactly what I need. Anyone working on this? If not, I'm going to do this

Hi there, what do you think about the 'none' mode? I'm a little confused.

Hmm I suppose you would still get the auto placeholder functionality, and the auto format functionality. But I'm not sure how useful it is any more - I'd definitely be happy to release this feature without it for now.

In my use case, I keep a country select when I use 'single' mode, in that way, I don't want the '_updateFlagFromNumber' work. What do you think about this? I think, when someone use 'single' mode, he must want to keep the country value under control, but updateFlagFromNumber will break this.
Then, for the 'none' mode, if we keep the auto placeholder and format functionality, user must have a country select or set a default country. How about just hide the flag, dropdown, and the arrow?

Re: single mode: I don't see any reason to change the behaviour of updateFlagFromNumber - the flag would only change if the user typed a plus and then a different country calling code - and if they do that  then I think it would be wrong to leave the old flag displaying - it wouldn't make sense - the plugin would be in an inconsistent state. I think we should change as little as possible for this feature - keep it simple - just a visual change.

Ok I ended up implementing something similar as a new option called allowDropdown which is true by default (normal behavior), but if you set it to false, it will remove the dropdown arrow, hover states and click listener (as well as the actual dropdown markup). Finally, it displays the flag on the right of the input because it's now just a visualization of state rather than an action. Release in v8.1.0.


MessageType for HDC protocol revision

Would allow a simple basic mechanism, which might likely survive changes introduced in future revisions of the HDC-Spec.
In the manner of the EchoCommand, but always replying a version string.

In this context we will also clean-up the ambiguity in HDC-spec between FeatureCommand and EchoCommand.
We'll rename FeatureCommand to simply command and will make it's meaning specific.
EchoCommand will be renamed into EchoMessage, which is also how we'll name the feature requested in this issue: VersionMessage

Closing this manually, because github does not understand "Fixes issue #4" of the previous commit.
It probably should have been "Fixes #4", instead. 😄


Type parameters in type aliases aren't usable in lambdas

type Sort[A] is {(Seq[A]): Bool}

The above example causes compilation to fail, reporting:
" can't find definition of 'A' "

Is this legal? I'm not sure it is when defining a type.
@sylvanc? @jemc?

Not sure if it's supposed to be legal, but it does seem reasonable to me.

It does? So what is this doing?
wouldn't that be
class or primitive not type?
I thought type was an alias, not a generic alias. I'm not sure what a generic alias would be. I'm confused by what it would mean.
@jemc or @lukecheeseman could you explain the idea to me and how it would know that [A] is supposed to be a generic and not a concrete type?

I believe these are generic aliases. For example, the following compiles:
type StringableArray[A: Stringable] is Array[A]

actor Main
  new create(env: Env) =>
    let m: StringableArray[U32] = StringableArray[U32]

I think the definition of A is used to decide whether the type is a generic or concrete type. Here the A type definition is in StringableArray[A: Stringable]

Thanks @lukecheeseman. With a bit of sleep and a little prodding, this all makes much more sense to me now.

@lukecheeseman for triage purposes i marked this as low priority as I think there are some ways to work around this (although they are slightly unpleasant). If this is a blocking issue for you or a significant hinderance, let me know and I can change the priority level.

Definitely legal, definitely a bug :)

This was fixed in 611b5b6fe4dbdcb02ee9992b657366cd9b70af11.

sweet!


Preselected in collapsible no longer works

Description
In a collapsible, applying 'active' as a class to a preselected item no longer opens that item by default.
Repro Steps
Check the official website, see the appropriate section under 'Collapsible'.
This works in 0.98.0, not in 0.98.1.

Duplicate of #4375


feat: focus-scope component

Description

Linked Issues
close #268
Additional context

You are great ❤

There is a storybook, can you add that too ?

@Cr0zy07 i am same send commit, new struct pnpm dev and pnpm build system. pnpm story same dont change.

Some of your tests are not working because we passed happy-dom from jsdom. If you can get them working can you post them in the next pr?


fix: allow gui build without drm

lact-daemon with default features depends on drm, which breaks build without drm.

Thanks, I've overlooked this


Installer should update default behavior

Current behavior
The following yml:
- uses: dapr/setup-dapr@v1

defaults to install v1.2.0 of the Dapr CLI, which is out of date.
Users can specify a version to install the latest version:
- uses: dapr/setup-dapr@v1
  with:
    version: '1.3.0'

Proposed behavior
There are two possible solutions we should explore:
Option A: Default to the latest stable release
The following yml:
- uses: dapr/setup-dapr@v1

will now install the latest stable release. As the Dapr CLI continues to release new versions, the version installed by this yml will follow the latest release.
Users can still specify a version like the current behavior.
This is the behavior the azure/setup-helm uses

Option B: Require a version, and add a latest value
The following yml:
- uses: dapr/setup-dapr@v1
  with:
    version: 'latest'

will now install the latest stable release.
This forces users to opt-in to the latest release, instead of the latest release being the silent default.

This was fixed by #142 .  It does (can) not know what latest is, but every release we just update globals.env and up the default.


.gitattributes file addition for matlab usage

I want to create a .gitattributes file to register matlab binary files as suggested in the link.
https://www.mathworks.com/help/matlab/matlab_prog/set-up-git-source-control.html

Resolved with pull request https://github.com/wwarriner/casting_geometric_toolsuite/pull/13.


Reference Types Working Group remaining tasks

We agreed to merge #934 with the following outstanding tasks:

[x] Update image-spec spec.md definitions to match distribution-spec
[x] refers naming
[ ] MUST language
[ ] potentially other restrictions / allowances for the use of the new fields (@mikebrow)

"refers" alternatives below:

Image
Distribution

affects
affectors

connects
connectors

qualifies
qualifiers

I can't edit, so my vote is for the last one:

relates_to and relationships

It's not the nicest looking one (the underscore!), but I think for the image it's the most obvious term to indicate a relationship (akin to how you'd see when working with graphs "this thing relates to...") and then relationships are also what graph/ontology communities use. This makes me think that having the others as "has X" would actually make them fit that criteria too.  "Attribute" is confusing with a kind of feature/descriptor, and qualifies suggests there is some criteria that one thing has that "qualifies" or validates the other. Affects makes me think of seasons, touching, it's just not the right word. So then my second and third choices would be refers and referrers, slight preference over connects/connectors which sounds like it's describing lego pieces.

Given most people in this community are not necessarily members of the image-spec repo, maybe it makes more sense to not require edit, but pick 6 of the more "positive" looking response emojis and assign them to the rows of your table @nishakm? That way people can just click an emoji response to vote, and it's easier to see totals anyway and who voted. Then we just have to make sure that whatever :heart: is is what @sudo-bmitch actually wants to vote for 😂

I think discussions might have support for polls? https://github.blog/2022-04-12-whats-new-in-github-discussions-organization-discussions-polls-and-more/

A key named "attribute(s)" that contains an oci descriptor doesn't make much sense to me. I'm not sure if I get a vote, but "referrer" or "relates_to" are the only ones that form coherence about what that object might contain in my mind.
If I do get a vote, then I agree with @vsoch's comment and vote for relates_to/relationships

😅 Sorry everyone. Just comment here on which ones you like and I will count the thumbs up from others.

@afflom you can totally vote!

@nishakm could we AT` the usernames next to the voting grid so it's easier to count / see who voted?

Thank you that is super helpful! So I’d only like to vote for one, my first choice “relates to and relationships” please! Otherwise I’m watering down my top vote.

Perfecto thank you @nishakm ! And sorry for the multiple pokes, if you ever need some random help on something I will make time!

refers / referrers is fine for me
relates_to / relationships is good too
I don't like any of the others! Too many assumptions in them.

other...   @lachie83 's subject mention in slack drawing from proposal A... seems to me to make it very clear.  Otherwise refers is fine let the documentation explain that it's the subject reference of the artifact.

@nishakm can you please add the following with my vote to the table in your comment above - https://github.com/opencontainers/image-spec/issues/940#issuecomment-1234578277

Image
Distribution
Votes

subject
referrers
@lachie83

Doh, apparently I forgot to submit my comment. My vote is for refers/referrers. I'm not a huge fan of the wording, but the longer we go, the more code gets written with those. I'm not a fan of an underscore in the field, but we could also do camel case if that were to get picked.
Other ideas to consider (but I'm not voting for):

extends/extenders (similar issue to attributes since we have extensions)
parent/children (denotes directionality, but not much else)
associate/associates (might be even harder to type/say than referrers)

I'd also vote for subject/refers & referrers. (Same votes as the other MB 👍 )

Actually, I like subject / referrers and would change my vote(s) to just that one. Subject is more clear I think.

Refers / Referrers 👍

@nishakm can you help update the table with the other votes -
There are more folks who are voting for subject/referrers  including me.
I know we discussed this in the call but it looks like folks started chiming in after the call.

FYI my preference is 1 subject, referrers; 2 refers, referrers

I've removed duplicate votes since more have come out. Seems like subject/referrers has won out. Any disputes on the vote?

Bit late to the party but having caught up on the specs etc this week I struggled a bit with refers/referrers so was glad to see this issue.
subject/referrers works best for me


KillSwitch race testing

This moves testing of KillSwitch out of lucet-runtime-tests and into a new crate, lucet-concurrency-tests. It also adds instrumentation into lucet-runtime, conditionally present on a new concurrent_testpoints crate flag, to force specific orderings in execution. This instrumentation lets us replace some OS-scheduler-dependent timing fickleness with strict happens-before guarantees, which should fix the flakiness of double_timeout in Mac CI.

I see there's a merge conflict.  I'm happy to do a quick reapproval when you are ready.


Remove redundant license clause from PR template

I've added this PR to this repository for discussion's sake, but if this suggestion is applicable to all of Amazon's recently-published public GitHub repositories created from the same internal template.

Users accepting GitHub's Terms of Service already agree to license any contribution to a repository under the same terms as that repository's license, so including the same agreement in a Pull Request is redundant.
See: https://help.github.com/articles/github-terms-of-service/#6-contributions-under-repository-license:

6. Contributions Under Repository License
Whenever you make a contribution to a repository containing notice of a license, you license your contribution under the same terms, and you agree that you have the right to license your contribution under those terms. If you have a separate agreement to license your contributions under different terms, such as a contributor license agreement, that agreement will supersede.
Isn't this just how it works already? Yep. This is widely accepted as the norm in the open-source community; it's commonly referred to by the shorthand "inbound=outbound". We're just making it explicit.

Removing this statement from your PR template will reduce friction and encourage more active community participation with less hesitation.

Thanks Will. Kudos on the attention to detail :)
I want to make sure it's explicit, and given it's the same principle I'm not expecting any friction. It's also covered in clause 5 of the Apache License 2.0. Another benefit is that, for future archaeology, it doesn't involve identifying what the GH T&C were at any particular time.
On the more programmy side, it also helps on the many-repo management side to have a 'default' marker should we have a different project that follows the 'Must sign a CLA' type instructions. My dashboards can flag 'nothing' as "needs to decide" :)


Moving forward with Docker.DotNet / Contributions

Hello guys,
I'm using this library today but I'm struggling to decide if I should keep it or start one on my own.
The major reason is the number of old and open issues so I don't know the size of the commitment on keep this library updated.
I want to contribute to it by doing the following improvements:

Migrate projects to new MSBuild-based tooling
Add test projects so we can have a CI (given that on README there is a mention that a private instance will be provided so the tests can run against it)
Make all stream events (from Monitoring or long running methods) to report progress instead of Stream  (by making them return Task and notify by IProgress<T>.Report(T) or make them return IObservable<T>)
Add support to all missing Swarm APIs
Fix some wrong/unnecessary types like in Filters

If those items make sense and the PRs for it would be (after review ofc) accepted, I'll do them otherwise, please let me know if there is no interest on support those items and I'll roll it on my own.
Thanks!
Best regards

@galvesribeiro - Thanks for your interest in the repo. We are more than happy to take your contributions as they come and incorporate them into our project. Many of the items you listed above already have tasks associated with them but were not a high priority. Let me outline some of them so you can understand the reasoning but if you are willing to contribute I am happy to review/add where we can.

Migrate to MSBuild -> Absolutely, this just isn't released yet so not a huge priority over dotnet cli as is.
Add tests -> No problem that sounds great. Mostly this project is to aid in our cmdlets Docker-PowerShell which do have tests so we didn't add more here. But this is a good idea for better unit style tests.
Stream events -> Task 108 lets do it!
Swarm API's -> Task 119. The reason this isnt a high pri for us is because again, we are using this for Docker-PowerShell. But happy to have this library be bigger than what we need there. If you want to write the endpoints I can get the models updated.
Filters -> These are an absolute trick in Docker how they do them. Open for ideas.

Feel free to add any other items to the list or open issues. Happy to tackle them as we can.

@jterry75 Great to hear that! :) The initial use case is for Microsoft Orleans. We are building a cluster membership provider for it that uses docker so I need Swarm objects in the library.
The second use is a new Orchestration engine (like swarm and kubernetes) that I'm working as a side project which will use Orleans and Docker.DotNet.
Regarding the task I agree with all them, and will engage on each one right after we get the new tooling stuff merged, since it is a blocker for me (I can't open the old projects here).

If you want to write the endpoints I can get the models updated.

Please do, I'll be working on it as soon as we get that netstandard PR done.
Thanks! Glad to know people are alive here!

@galvesribeiro - Take a look at branch: docker-v1.13.0. This has the updated models. If you add the swarm API's here we can merge them all at once. Let me know if anything is missing.

@jterry75 ok thanks. So basically I should create a branch from that branch with the models and submit the PR against that same, right?

Yep. My workflow is typically to create a topic branch from master and then submit PR's that way. But because Docker is not done with v1.13 (they are in RC5) I dont want to mainline it quite yet. So just create a topic branch off of docker-v1.13.0 in your fork (you can even call it the same name). And then submit PR's from there. I will merge it if there are any final updates when docker goes RC5 -> finished.

Ok good. For now let me first focus on the things that don't rely on those RC code. First finish that MSBuild thing, and later the streams and filter. After that complete the tests and then we get to swarm. Hopfuly it will be finished by.

@galvesribeiro - Also just merged your MSBuild work into the docker-v1.13.0 branch so you have the latest there too.

Thank you @jterry75. Let me finish this progress issue in main branch and when I start the swarm one, I'll move to that branch and PR against it. Thanks

@galvesribeiro - Want to take a stab at some first tests? Or the filters work you had ideas on? I will try to get the rest of Services/Nodes API's in the works

When you merge 1.3 to master I'll go thru the filters.

@galvesribeiro - Just added #157, #158, #159 to finish what I think is the complete swarm API but the majority of the functions are there now. Can we close this and just track those or are there other outstanding requests we need single items for?

@jterry75 do you need my help on those or you will takle it yourself?
According to the new API 1.25, need only Volumes and Network if I understood correctly.
Btw, once that is complete, I'll put Docker.Net here https://docs.docker.com/engine/api/ on their SDK pages. Already spoke with some docker guys.

@galvesribeiro - Added all of the sections as issues that were missing from documentation as well as updated any reorganization we need to make to better align with the docs. Please feel free to tackle any of these issues if you have the bandwidth.
As for Network we have INetworkOperations that has all the functionality, what am I missing?

@jterry75 perfect! I'll check each one of the issues and make a PR for each...
Did you updated the models for 1.25?
Yes, lets close this issue as we are moving to the others.
Thanks!

Yep should be full v1.25 update. If anything is missing (because there were no references the generator will skip some of the types sometimes) I'll make some additions on just the GO side and you can tackle the C# side

Perfect! Thanks!


[Memory Engine] Add hash index implementation

This commit adds a hash index implementation for memory engine, it maps uint64_t hashcode(key) to uint32_t rowid(value). This hash index is different from the classical hash table in many ways:

To save memory usage, it does store value (only rowid), user need to follow the rowid and get the actual rowkey and check rowkey equality.
Only support insertion, no delete support
One writer/multi-reader concurrency support

It's specially designed for the memory storage engine.

@decster Hi, I think we need to support SSE2 operation rollback to normal scalar operation，because Doris BE maybe run on ARM architecture machine.

LGTM


Fix address validation

lbryum has the same address validation bug as lbryschema: https://github.com/lbryio/lbryschema/issues/17

well that's not good,
I added some additional tests LGTM


Windows registration script fails to github certificate error

Agent version and platform
Trying to download the agent on Windows
VSTS type and version
On-Prem TFS 2018
What's not working?
Downloading https://go.microsoft.com/fwlink/?linkid=858950 using the powershell script
Exception calling "DownloadFile" with "2" argument(s): "The request was aborted: Could not create SSL/TLS secure channel to SSL/TLS."
At line:1 char:538
+ ... \agent.zip";(New-Object Net.WebClient).DownloadFile( 'https://go.micr ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : WebException

Powershell script with sensitive data removed
$ErrorActionPreference="Stop";If(-NOT ([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent() ).IsInRole( [Security.Principal.WindowsBuiltInRole] “Administrator”)){ throw "Run command in Administrator PowerShell Prompt"};If(-NOT (Test-Path $env:SystemDrive\'vstsagent')){mkdir $env:SystemDrive\'vstsagent'}; cd $env:SystemDrive\'vstsagent'; for($i=1; $i -lt 100; $i++){$destFolder="A"+$i.ToString();if(-NOT (Test-Path ($destFolder))){mkdir $destFolder;cd $destFolder;break;}}; $agentZip="$PWD\agent.zip";(New-Object Net.WebClient).DownloadFile( 'https://go.microsoft.com/fwlink/?linkid=858950', $agentZip);Add-Type -AssemblyName System.IO.Compression.FileSystem;[System.IO.Compression.ZipFile]::ExtractToDirectory( $agentZip, "$PWD");.\config.cmd --deploymentgroup --agent $env:COMPUTERNAME --runasservice --work '_work' --url 'https://secret.place.dk/' --collectionname 'AldenteCollection' --projectname 'Secret project' --deploymentgroupname "demosite.dk" ; Remove-Item $agentZip;

The testcase can be reduced to this essentially:
$agentZip="$PWD\agent.zip";(New-Object Net.WebClient).DownloadFile( 'https://go.microsoft.com/fwlink/?linkid=858950', $agentZip);

Or even with the github redirected page instead:
$agentZip="$PWD\agent.zip";(New-Object Net.WebClient).DownloadFile( 'https://github.com/Microsoft/vsts-agent/releases/download/v2.122.1/vsts-agent-win7-x64-2.122.1.zip', $agentZip);

This download is failing on Windows 10 and Windows server 2016r2 machinery.
This is probably an issue on our end somehow, but I don't know what to do about it honestly.

May be related to GitHub deprecating TLS 1.0 and 1.1? Can you try to force/use TLS 1.2?
https://www.thesslstore.com/blog/deprecation-tls-1-0-1-1-underway/

@jespersh we are moving away from github release, the recent agent releases are located in AzureCDN.
for now, you can change your script as @alexwiese suggest.
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12

Thanks @TingluoHuang and @alexwiese!
While I'll close this for now I'd like to ask if you know if future versions of powershell will automatically set this for us?

it should as old TLS version will be deprecated eventually, but i have no idea about when that will happen. :D

Just ran into the same issue with setting up a deployment group for on prem TFS 2018. thanks for your suggestion.
FYI for others that aren't PowerShell savy like me, you just have to paste the command that @TingluoHuang proposed first and run it (press enter), then run the script like normal afterwards.