Removing pointless (?) setter/getter patter from some algorithms

Some of the code imported from Aqua came with this pattern of pointless-looking setter/getters. I might be missing something here. Is it okey to remove them?

One thing I might say is that, specially in the result classes, you lose the property type information and sphinx documentation allowed by typehints for each property getter/setter removed.

I agree with Manoel, there's value in having the documentation in some cases. However I think that we indeed to have a lot of boilerplate here.
One solution would be to put the documentation in the class docstring. To keep the type info (which we should) can we use Python's dataclass? https://docs.python.org/3/library/dataclasses.html

yeap... I think class docstring is the way to go.

Its a public interface - the variables and there interaction with the class may be self-evident but it should have documentation as needed. Instance vars can be documented via Sphinx - they are not for now from what I have seen - only class vars.
The getter/setter, even when its a simple private field, is consistent with what is done elsewhere in Qiskit. This change, if its wanted, should be done in a consistent way throughout - maybe doing it on a couple of algos in a PR here  was to open up some discussion with more concrete examples. Maybe it should be opened up as an Issue to bring the subject up more generally with examples to have a wider discussion in Qiskit.

To keep the type info (which we should) can we use Python's dataclass? https://docs.python.org/3/library/dataclasses.html

Dataclass is really nice but it's a python 3.7+ feature and currently we still support 3.6 (see #5301)

For documentation, Sphinx will autogenerate the attribute entries for @property methods and use the method docstring for that getter method as the attribute docstring. However, there is no requirement to do that just to get documentation, the easiest way is to manually list the attribute in the docstring for the class. With the napolean plugin we use for docstrings it would be something like:
class Foo:
    """Class for something

    Attributes:
        my_special_attr (int): This attribute has the number of something for the class
   """


cFS Bundle Integration Candidate: 2021-01-12

Describe the contribution
A clear and concise description of what the contribution is.

Include explicitly what issue it addresses [e.g. Fixes #X]

Testing performed
Steps taken to test the contribution:

Build steps '...'
Execution steps '...'

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

API Change: xxx (if applicable)
Behavior Change: xxx (if applicable)
Or no impact to behavior

System(s) tested on

Hardware: [e.g. PC, SP0, MCP750]
OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]

Additional context
Add any other context about the contribution here.
Code contibutions
The cFS repository is provided to bundle the cFS Framework.  It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software.  Code contributions should be directed to the appropriate submodule.
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)

Note CLA's apply to software contributions.

@skliper @jphickey still have 57: select-test hanging, Wasn't this fixed by https://github.com/nasa/osal/pull/721?

@skliper @jphickey still have 57: select-test hanging, Wasn't this fixed by https://github.com/nasa/osal/pull/721?

@astrogeco it should have, maybe there is another issue...

@astrogeco it should have, maybe there is another issue...

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

@zanzaben - could you prioritize looking into this?

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

@zanzaben - could you prioritize looking into this?

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

How often did it happen?

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

How often did it happen?

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

How often did it happen?

Here is another instance
https://github.com/nasa/cFS/runs/1690379753?check_suite_focus=true

@skliper @jphickey still have 57: select-test hanging. See https://github.com/nasa/cFS/pull/174/checks?check_run_id=1689399944
Wasn't this fixed by nasa/osal#721?

How often did it happen?

Here is another instance
https://github.com/nasa/cFS/runs/1690379753?check_suite_focus=true

And one more
https://github.com/nasa/cFS/pull/174/checks?check_run_id=1690641558

And one more
https://github.com/nasa/cFS/pull/174/checks?check_run_id=1690641558

And one more
https://github.com/nasa/cFS/pull/174/checks?check_run_id=1690641558

Thank you, I understand the issue now and am working on a fix.

And one more
https://github.com/nasa/cFS/pull/174/checks?check_run_id=1690641558

Thank you, I understand the issue now and am working on a fix.

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

Adding information for completeness,
Issue: nasa/osal#755 "resolve subtasks not ending on time "
and
PR: nasa/osal#756

I recommend merging in the PR as a hotfix so it gets exercised this round if possible.

Adding information for completeness,
Issue: nasa/osal#755 "resolve subtasks not ending on time "
and
PR: nasa/osal#756


Update feature quality level descriptions

Summary
Proposing some definition updated after I received feedback that the current definitions were confusing. For example, the wording around beta features made it seem like they were not recommended for use in production. However, this does not match our actual usage of the term, as we actively encourage customers we partner with to use beta features so we can get feedback.
Reviewers -- I think you have all used the beta label the most. Can you review these definitions and see if they match with how you have been using the term, or if there are other parts we should update?

Following up on this to confirm thoughts around the suggested changes. Thanks!

@justinegeffen - I like the change, let's just call it "modifying the configuration setting" rather than config.json though as I think they are moving towards config in the DB rather than config.json


Missing Dependency ImageMagick/GraphicsMagick

While i try shoppe, and follow the tutorial in tryshoppe, i got error when on route product#new
the details attached. I solve it by install it manually, look like the dependency not installed automatically, if it used by shoppe when build new product i think it should installed automatically. :)
By the way, I love this gem though.

I don't believe installing automatically is an option, as the backend is configurable. Some like imagemagick over grapghicsmagic, some the other way around. So there is no best guess.
If any gem would be installing the actual library, it should be the IM or GM gem itself, not shoppe.

Yep you'll need to install ImageMagick. I have no experience with running Rails on Windows but you can download IM from their site - http://www.imagemagick.org/script/binary-releases.php#windows


Menu activeElement / onSelect functionality - pass props to first row of children

This is a proposal.
We want to provide the functionality of an activeElement parameter.
This will allow our users to activate an element without worrying about closing another one.
We can save an activeElement parameter in our state, pass an onSelect and index method to component's children and use it onClick before user's onClick prop. If the user provides a custom element, we will ask to use our onSelect function with the index prop.
something like:
onClick = () => {
    // using our onSelect with index prop
    this.props.onSelect(this.props.index);
   // invoke user's onClick event
    this.props.onClick();
}

For example, a dropdown will be open if:
this.props.activeElement === this.props.index

WDYT?
@AmirAsaraf @liorheber @johanzilber

@PeterShershov please resolve conflicts and merge


v2 track events with CSS classes

Is there any particular reason why this simple and straightforward method of tracking events has been removed in v2? Is this temporary? Not only would i have to go back into many, many sites and redo all my event codes, but i'd have to write a bunch of js for sites that don't use data attributes. not looking forward to it.

The reason we changed was because data attributes allow you set arbitrary values, whereas CSS classes had to follow CSS variable naming rules.

I understand the reason for the change to data attributes, but I had the same problem as @wheeleran.
Further, my Wordpress theme does well support the custom css-classes everywhere, but does not support the adding of data attributes.
I came up with following solution, to migrate my umami css class event tracking from v1 to v2.
This script has been added to the footer! section of my pages:
<script>
document.querySelectorAll("[class*='umami--click']").forEach((element, index) => {
	element.onclick = (event) => {
	umami.track('Click' + index + ': ' + event.target.innerText);
//	console.log('Click' + index + ': ' + event.target.innerText);	// for debugging
	}
})
</script>

The script watches all my existing umami--click--xxxxxxxxx classes
At click, the script calls umami.track() to send the information I need. In my case I want to see the innerText and the index (if two elements on a page have same innerText).
I used the console.log line only for debugging

Oh now THIS is cool!!


feat!: reduce subtree root threshold to 64

Overview
per sync discussion/agreement, we are decreasing the subtree root threshold to 64 instead of 128. This has the tradeoff of slightly increasing the % padding for real world usecases while decreasing the size of blob inclusion proofs significantly.
Checklist

[x] New and updated code has appropriate documentation
[x] New and updated code has new and/or updated testing
[x] Required CI checks are passing
[x] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #1766 (a5131e2) into main (d56fcb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1766   +/-   ##
=======================================
  Coverage   51.94%   51.94%
=======================================
  Files          93       93
  Lines        6080     6080
=======================================
  Hits         3158     3158
  Misses       2594     2594
  Partials      328      328

omg github.


<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!

Do you want to request a feature or report a bug?
bug

What is the current behavior?
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>

What is the expected behavior?
@angular2-material/icon should use<EMAIL_ADDRESS>

Which version of Angular and Material, and which browser and OS does this issue affect?
Did this work in previous versions of Angular / Material?
Please also test with the latest stable and snapshot versions.
<EMAIL_ADDRESS>

Other information
(e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)

The angular version will be updated in the next release, see #395


"Learning objective for pretraining" vs "Gene expression prediction."

[
\mathbf{h}^{(i)}_n
]
Isn't the shape of ( \mathbf{h} ) ( M \times D )? ( M ) represents the gene input. After passing through the MLP, it should be ( M \times 1 ), right? So how is the formula in the "Learning objective for pretraining" calculated? The dimensions don't match, do they?

[
\mathbf{h}^{(i)}_n
]
Isn't the shape of ( \mathbf{h} ) ( M \times D )? ( M ) represents the gene input. After passing through the MLP, it should be ( M \times 1 ), right? So how is the formula in the "Learning objective for pretraining" calculated? The dimensions don't match, do they?

Oh, do you mean it should be like equation 13 in the sense that there should be a subscript j? Yeah, I think that can be more accurate. Are you talking about the substraction in the first equation?

"First of all, thank you for your response. Secondly, I still have questions about the handling of 'unknown' and 'mask' in formulas 12 and 13 of the article. For 'unknown', does scGPT only input the embedding of gene tokens during processing, rather than the sum of embeddings for gene tokens and their corresponding expression tokens? For 'mask', is it inputting a special expression token called 'mask'?"

"The selected positions with high prediction confidence" is no longer mentioned in the paper.
What does "high prediction confidence" mean, and how does scGPT determine which positions have high prediction confidence?


Add flag to enable startTLS

LDAP providers allow connection using StartTLS.
The API for ldap config has new boolean field StartTLS.
This should be provided in the UI as well for these providers:
OpenLDAP
FreeIPA
Active Directory
Backend available on 2.5-head
https://github.com/rancher/rancher/issues/29153

For 2.5.4 we will only add the UI for OpenLDAP, the other 2 providers will be tracked here: https://github.com/rancher/rancher/issues/30348

Rancher version: 2.5.4-rc1
Rancher version: master-head (12/05/2020) e129f92
Validated the original LDAP test server without StartTLS fails if we try to use it over port 389.
Validated the new LDAP server with StartTLS succeeds to enable the openLDAP authentication.
Spot check P1 scenarios manually done with the StartTLS test server.
Regression tests done as part of #29153
Scope of this issue for UI was only done for openLDAP
AD and FreeIPA StarTLS is scheduled for 2.5.5 in #30348


Missing six in project requirements

Describe the bug
Parsl is missing "six" from it's project requirements
To Reproduce
Steps to reproduce the behavior, for e.g:

Install Parsl in a clean environment
Try to import parsl

Expected behavior
It imports
Environment

OS: ubuntu
Python version: 3.10
Parsl version: 2023.*

Evidence
(test) lward@bettik-linux:~/Work/ExaLearn/colmena$ pip install parsl
Collecting parsl
  Using cached parsl-2023.1.16-py3-none-any.whl (481 kB)
Collecting types-six
  Using cached types_six-<IP_ADDRESS>-py3-none-any.whl (14 kB)
Collecting types-requests
  Using cached types_requests-<IP_ADDRESS>-py3-none-any.whl (14 kB)
Collecting dill
  Using cached dill-0.3.6-py3-none-any.whl (110 kB)
Collecting psutil>=5.5.1
  Using cached psutil-5.9.4-cp36-abi3-manylinux_2_12_x86_64.manylinux2010_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (280 kB)
Collecting pyzmq>=17.1.2
  Downloading pyzmq-25.0.0-cp310-cp310-manylinux_2_28_x86_64.whl (1.1 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.1/1.1 MB 7.3 MB/s eta 0:00:00
Collecting typeguard>=2.10
  Using cached typeguard-2.13.3-py3-none-any.whl (17 kB)
Collecting requests
  Downloading requests-2.28.2-py3-none-any.whl (62 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 62.8/62.8 kB 12.2 MB/s eta 0:00:00
Collecting globus-sdk
  Using cached globus_sdk-3.15.1-py3-none-any.whl (206 kB)
Collecting tblib
  Using cached tblib-1.7.0-py2.py3-none-any.whl (12 kB)
Collecting typing-extensions
  Using cached typing_extensions-4.4.0-py3-none-any.whl (26 kB)
Collecting types-paramiko
  Using cached types_paramiko-<IP_ADDRESS>-py3-none-any.whl (32 kB)
Collecting paramiko
  Downloading paramiko-3.0.0-py3-none-any.whl (210 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 210.8/210.8 kB 1.4 MB/s eta 0:00:00
Collecting setproctitle
  Using cached setproctitle-1.3.2-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (30 kB)
Collecting pyjwt[crypto]<3.0.0,>=2.0.0
  Using cached PyJWT-2.6.0-py3-none-any.whl (20 kB)
Collecting cryptography!=3.4.0,>=3.3.1
  Using cached cryptography-39.0.0-cp36-abi3-manylinux_2_28_x86_64.whl (4.2 MB)
Requirement already satisfied: certifi>=2017.4.17 in /home/lward/miniconda3/envs/test/lib/python3.10/site-packages (from requests->parsl) (2022.12.7)
Collecting urllib3<1.27,>=1.21.1
  Downloading urllib3-1.26.14-py2.py3-none-any.whl (140 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 140.6/140.6 kB 9.2 MB/s eta 0:00:00
Collecting idna<4,>=2.5
  Using cached idna-3.4-py3-none-any.whl (61 kB)
Collecting charset-normalizer<4,>=2
  Downloading charset_normalizer-3.0.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (198 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 198.8/198.8 kB 536.8 kB/s eta 0:00:00
Collecting pynacl>=1.5
  Using cached PyNaCl-1.5.0-cp36-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (856 kB)
Collecting bcrypt>=3.2
  Using cached bcrypt-4.0.1-cp36-abi3-manylinux_2_28_x86_64.whl (593 kB)
Collecting types-urllib3<1.27
  Using cached types_urllib3-<IP_ADDRESS>-py3-none-any.whl (14 kB)
Collecting cffi>=1.12
  Using cached cffi-1.15.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (441 kB)
Collecting pycparser
  Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Installing collected packages: types-urllib3, types-six, charset-normalizer, urllib3, typing-extensions, types-requests, typeguard, tblib, setproctitle, pyzmq, pyjwt, pycparser, psutil, idna, dill, bcrypt, requests, cffi, pynacl, cryptography, types-paramiko, paramiko, globus-sdk, parsl
Successfully installed bcrypt-4.0.1 cffi-1.15.1 charset-normalizer-3.0.1 cryptography-39.0.0 dill-0.3.6 globus-sdk-3.15.1 idna-3.4 paramiko-3.0.0 parsl-2023.1.16 psutil-5.9.4 pycparser-2.21 pyjwt-2.6.0 pynacl-1.5.0 pyzmq-25.0.0 requests-2.28.2 setproctitle-1.3.2 tblib-1.7.0 typeguard-2.13.3 types-paramiko-<IP_ADDRESS> types-requests-<IP_ADDRESS> types-six-<IP_ADDRESS> types-urllib3-<IP_ADDRESS> typing-extensions-4.4.0 urllib3-1.26.14
(test) lward@bettik-linux:~/Work/ExaLearn/colmena$ python
Python 3.10.9 (main, Jan 11 2023, 15:21:40) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import parsl
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/lward/miniconda3/envs/test/lib/python3.10/site-packages/parsl/__init__.py", line 22, in <module>
    from parsl.app.app import bash_app, join_app, python_app
  File "/home/lward/miniconda3/envs/test/lib/python3.10/site-packages/parsl/app/app.py", line 12, in <module>
    from parsl.dataflow.dflow import DataFlowKernel
  File "/home/lward/miniconda3/envs/test/lib/python3.10/site-packages/parsl/dataflow/dflow.py", line 22, in <module>
    from parsl.app.errors import RemoteExceptionWrapper
  File "/home/lward/miniconda3/envs/test/lib/python3.10/site-packages/parsl/app/errors.py", line 8, in <module>
    from six import reraise
ModuleNotFoundError: No module named 'six'
>>>

It's right that we should require six explicitly.
It looks like previously it was provided as a transitive dependency via paramiko, but paramiko recently removed this, here: https://github.com/paramiko/paramiko/commit/39f458c834def3c217a3bd2eb62cc92032e20975

In CI this does not show up, because test-requirements.txt transitively installs this via pytest-xdist.


Azcopy sync --delete-destination=true not marking item in cloud for delete when versioning is turned on.

Which version of the AzCopy was used?
10.15.0 and 10.18.1
Note: The version is visible when running AzCopy without any argument
Which platform are you using? (ex: Windows, Mac, Linux)
server 2019
What command did you run?
azcopy sync 'D:\MSSQL\MSSQL15.MSSQLSERVER\MSSQL\Backup' 'blob.location' --recursive --delete-destination=true --log-level=ERROR
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
What problem was encountered?
Files no longer on the local machine were changed to without current version in blob storage.  The expect behavior was for the files in the blob storage that were not longer local to be deleted.  We have soft delete enabled, and versioning turned on for the blob.
How can we reproduce the problem in the simplest way?
Run the sync command with some files locally then remove a local file and see if in Microsoft Azure Storage explorer the missing file locally is not marked as status deleted or active.  You'll have to change the dropdown for the filtering to All blobs and blobs without current version.  To see it.  If you leave it on the default, Active blobs (Default) it will appear that the file was deleted from the blob storage, you'll see that it isn't when you switch the drop down.
Have you found a mitigation/solution?
No, hand delete files on a regular basis using Azure storage explorer.

Feature request: Permanent delete for sync --delete-destination


[Question] Result better than baseline

I run some tests on dopamine. When I run the game 'Qbert', the result seems better than the result presented in the baseline.
I use here config located in dopamine/agents/rainbow/configs/rainbow.gin. I only change the environment name to Qbert.

That does seem a little better. Our baseline results are reporting 1) training scores, 2) with sticky actions. Are you using 2)?

I use here config located in dopamine/agents/rainbow/configs/rainbow.gin.
So the configuration seems with sticky actions.

Strange. Maybe the code is getting better as it ages? :)
Is the x axis on your tensorboard million agent steps, or million frames (x4 steps)? The numbers would match the former.

I didn't change any training code, nor tensorboard summary code. So I think it matches the baseline. BTW, I run the training for Pong before and the score didn't reach 15 as the baseline showed. I didn't know the reason, so I run rainbow for the game Qbert.

@Seraphli, Were you using a GPU to run the code and how long did it take to get the above results?

@satyakesav 1d13h for first 100 iterations on Qbert

@Seraphli, Ahh. I see. What GPU did you train it on again?

@satyakesav 1080ti

@satyakesav 1d13h for first 100 iterations on Qbert

That is really fast, normally for DQN, one iteration takes 40 minutes on V100.


Showing a dialog before android permision dialog onPermissionRationaleShouldBeShown does not work when pressing back button

Expected behaviour
I want to help the user understand why my app needs a permission before showing android permission dialog. I'm using a helper dialog to explain that. I disabled the back press button on the helper dialog so the only way to close the dialog is to press  a button on the dialog. after user press the close button I consume token with token.continuePermissionRequest(); and android permission dialog is shown and everything should continue to be  working fine.
Actual behaviour
when a helper dialog is displayed to user to explain why permission needed and user press on back button then clicks on dialog close button dexter does not work anymore anywhere and show nothing.
Steps to reproduce

after the helper dialog is shown just press back button then continue.

`
@Override
public void onPermissionRationaleShouldBeShown(PermissionRequest permission, PermissionToken token)
{
new AlertDialog.Builder(context).setTitle("test")
.setMessage("test")
.setCancelable(false)
.setNegativeButton(android.R.string.cancel, new DialogInterface.OnClickListener() {
@Override public void onClick(DialogInterface dialog, int which) {
dialog.dismiss();
token.continuePermissionRequest();
}
})
.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {
@Override public void onClick(DialogInterface dialog, int which) {
dialog.dismiss();
token.continuePermissionRequest();
}
})
.setOnDismissListener(new DialogInterface.OnDismissListener() {
@Override public void onDismiss(DialogInterface dialog) {
token.continuePermissionRequest();
}
})
.show();
}

`
Dexter.withActivity(this)                 .withPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)                 .withListener(dialogPermissionListener)                 .check();
Version of the library
5.0.0

token.cancelPermissionRequest() cancels the permission request until the app is killed. It have been discussed few years ago in #170. @eygraber told us that he want to mimic Google's way when cancelling the permission request. But this comes to a problem when we want to display a consent dialog before showing the permission dialog.
Agreed with @omidp. Not all apps should follow Google's UX. Every company has their own UI/UX designer. Adding parameter canRequestAgain into token.cancelPermissionRequest(boolean) is a good idea.

I don't get if you are reporting a bug or a feature. Not all apps should follow Google's UX but not all libraries should follow your design either. Don't you think so? If we are talking about a bug, could you please provide a minimum working example and a list of steps to reproduce so I can test it out? Thank you in advance.


update recipe/meta.yaml for 801 release

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@AntoinePrv  do you have an idea about the fail of the soplex shared lib build on windows?

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [40, 59, 131, 139]

For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

It looks like the 'papilo' output doesn't have any tests.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin please rerender

:woman_dancing:


Memory issue with "configureCell"

I am seeing a strong retain when using "datasource.configureCell = ...."
Unless i call dataSource.configureCell = nil in the viewController the class that owns the dataSource will never be disposed.

Hi @grangej ,
I think this means that you are holding a reference inside of that closure to something that is creating a release cycle, right?


Fix spelling error in documentation

I happened to notice this while reading the documentation. This PR changes the spelling of "targetted" to "targeted". I double-checked, and it is indeed spelled "targeted" in both British and American English. For example: https://dictionary.cambridge.org/us/dictionary/english/targeted

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


⚠ ClamAV has degraded performance

In 5392188, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 206 ms

Resolved: ClamAV performance has improved in e0acdc1.


Implement DETACH PART

It's possible to ATTACH PARTs manually but DETACH only works with partitions which makes moving data between nodes impossible. Currently, the only workaround is to delete the directory of PART and restart the node but it's not a reliable way since we don't keep track of merges which might include the PART we want to delete and the queries that are executed before restart will fail because of missing PART.
At least support for DETACH PART for non-replicated MergeTree tables would be a good starting point and would solve our issue since we handle replication externally.
Also see the discussion here: https://groups.google.com/forum/#!msg/clickhouse/ZABNyXsiIWI/fZyFk6IQBAAJ

+1 We need DETACH PARTs so we can purge data in a daily manner.

If you need daily data purge, nowadays you should consider using custom partitioning:
https://clickhouse.yandex/docs/en/table_engines/custom_partitioning_key/


I got some issues

Hey Mr Robert i have some problem to install some of tools, can i get your discord or something to talk with you
P.s sorry for faut I'm french
My discord:Lucifer_MorningStar#6880

Hello, I haven't considered making a discord for it until now but I suppose I can. What issue are you having? Is it when you are trying to install lavalink, dotenv and dependencies like that? If so its through pip when you install python3. pip install python-dotenv for example will install dotenv. pip install lavalink will install lavalink. If you have other versions of python and depending on your os you may have to do pip3 install. I hope this helps, if not describe your issue a little bit and I will try to help from here. Otherwise I may create a discord for it. Thank you


[docs] Remove Gitter and Slack (fixes #3689)

This PR closes #3689. It removes references to Gitter and Slack.
I hope this will strengthen the LightGBM community by consolidating the conversation. As of this PR, the official advice in the README will be that general questions about LightGBM should go to the lightgbm tag on Stack Overflow, and bugs + feature requests should go on the GitHub Issues page here.

Do we need to actually remove these channels as a next step? Or I believe we should at least mark them as "no devs here".

I think that once this PR is merged, we should post in there something like this:

Hello all. To consolidate the conversation, we have decided to shut down this Slack. Starting today, please use the lightgbm tag on Stack Overflow for general questions or https://github.com/microsoft/LightGBM/issues to report bugs or feature requests. This Slack will be deleted on February 15, 2021.

And then completely delete those. I think it is worth waiting a month to delete them completely, so that anyone who wants to can go back and save links or discussions. I chose one month because I expect that the average member of these channels does not check it very often.
I think it's preferable to delete them completely, to reduce the number of places where people are asking for LightGBM help.  That reduces the number of places maintainers have to check and helps search engines to return more relevant results

Do we need to actually remove these channels as a next step? Or I believe we should at least mark them as "no devs here".

I think that once this PR is merged, we should post in there something like this:

Hello all. To consolidate the conversation, we have decided to shut down this Slack. Starting today, please use the lightgbm tag on Stack Overflow for general questions or https://github.com/microsoft/LightGBM/issues to report bugs or feature requests. This Slack will be deleted on February 15, 2021.

And then completely delete those. I think it is worth waiting a month to delete them completely, so that anyone who wants to can go back and save links or discussions. I chose one month because I expect that the average member of these channels does not check it very often.
I think it's preferable to delete them completely, to reduce the number of places where people are asking for LightGBM help.  That reduces the number of places maintainers have to check and helps search engines to return more relevant results


Only one identical cookie should be accepted per domain

Summary
When a cookie is received by a UA, it should check if there are any existing stored cookies with an identical:

Domain
Path
Name

If any cookies with identical values are found, they should be replaced with the new cookie:
11.  If the cookie store contains a cookie with the same name,
        domain, and path as the newly created cookie:
...
        4.  Remove the old-cookie from the cookie store.

Mojolicious does not set the cookie domain if it is unset, but instead stores an additional origin parameter to store the original request-host. RFC 6265 also requires that cookies without a valid domain set are assigned the domain of their request-host:
   6.   If the domain-attribute is non-empty:
...
        Otherwise:

           Set the cookie's host-only-flag to true.

           Set the cookie's domain to the canonicalized request-host.

As a result, the original cookie is never removed from the store, and is in fact submitted to the host:
use Mojolicious::Lite;
use Mojo::UserAgent;
use Data::Dump 'pp';

get '/with' => sub {
	my $c = shift;
	$c->cookie(test => 'WITH DOMAIN', {domain => '<IP_ADDRESS>'});
	$c->rendered(200);
};
get '/without' => sub {
	my $c = shift;
	$c->cookie(test => 'WITHOUT DOMAIN');
	$c->rendered(200);
};

get '/say' => sub {
	my $c = shift;
	return $c->render(
		text => "Say handler got cookies: " . join ', ', map { pp($_) } $c->req->cookies->@*
	);
};

my $ua   = Mojo::UserAgent->new;
# This request sets a testing cookie without a domain parameter
# according to RFC 6265 Section 5.3 bullet 6 this should be set to the request-host
$ua->get("/without");
# This request now sets a cookie with a domain parameter. This should override the existing cookie
# and end up the only one in the jar according to RFC 6265 Section 5.3 bullet 11
$ua->get("/with");

# This request now passes BOTH cookies despite them having identical paths and names
say $ua->get("/say")->res->body;

Say handler got cookies:
    bless({ name => "test", value => "WITHOUT DOMAIN" }, "Mojo::Cookie::Request"),
    bless({ name => "test", value => "WITH DOMAIN" }, "Mojo::Cookie::Request")

Motivation
This change encompasses only the corrections to tests in order to make them representative of RFC 6265. The behaviour of domain-less cookie handling also needs fixing in order to comply with the RFC.
Additionally, it may be considered a security risk that two cookies with identical parameters can be submitted to the same site.
References
Prior issue: https://github.com/kraih/mojo/issues/1185
PR to fix behaviour in Cookie/UA: https://github.com/kraih/mojo/pull/1186
RFC Section: https://tools.ietf.org/html/rfc6265#section-5.3
sri's request from IRC:
<@sri> exp-innit: so you could make a failing test case for cookiejar.t?
<@sri> if an incorrect cookie is sent that would be a serious bug
...
<@sri> no, i want a mojo/cookiejar.t test case that fails but shouldn't
<@sri> the most minimal it can be

Calling for a vote on this: @jberger, @jhthorsen, @marcusramberg.

If these findings can be confirmed to be consistent with Browser behaviour i think this is a (weak) security issue and should be fixed as quickly as possible.

I've confirmed that browsers do in fact only send one cookie, so we are leaking old cookies.


Support for provider_verification_failed event

Would it be possible to include support for provider_verification_failed event as described in Webhook docs?
I'm not sure but I believe that the client used under the hood supports this kind of event and it is only a matter of extending the following list:
https://github.com/pactflow/terraform/blob/dda87a391c9780948fca285a9d6337dc17f27344/resource_webhook.go#L18

Yep, I'll get this out tomorrow! Thanks.

Release on the way (v0.1.0).

Thanks @mefellows for (lighting fast) delivering of a  fix :)
I've got one remark though. The following method is implemented in a way which requires the input array s to be initially sorted.
func stringContains(s []string, searchterm string) bool {
	i := sort.SearchStrings(s, searchterm)
	return i < len(s) && s[i] == searchterm
}

Currently, if you use the new type of the event (provider_verification_failed) it won't be validated because returned index i doesn't match the index of the input array s.
As a quick fix I propose to reorder the allowedEvents array:
var allowedEvents = []string{
	"contract_content_changed",
	"contract_published",
	"provider_verification_failed",
	"provider_verification_published",
	"provider_verification_succeeded",
}

Ah! Good pickup, apologies for that.
I've just pushed out a minor fix to address that issue (it will now sort the input array too).


m.me

Hi,
This domain is simply Facebook Messenger URL shortening service

This was blocked in a phishing blocklist, so probably had a link to a phishing website so became a false positive. Thanks, and added to whitelist


l2 announcer is 🤌 (but weird bugs with /32's)

I switched our cluster over from metallb to the l2 announcer in a single evening with 0-downtime. This is a very awesome feature!
However, it is issuing IP's outside of the IP pool...
Example pool:
apiVersion: cilium.io/v2alpha1
kind: CiliumLoadBalancerIPPool
metadata:
  name: pool
spec:
  cidrs:
    - cidr: <IP_ADDRESS>/32
    - cidr: <IP_ADDRESS>/32
  disabled: false

I'm seeing it issue IP's to services (LB type) to <IP_ADDRESS>, for example. Deleting the status doesn't cause it to reissue the IP address from the pool (in fact, I couldn't figure out how to invalidate the assignment), and had to force an actual IP using the io.cilium/lb-ipam-ips annotation.
However, when setting that, I got the following status:
No pool exists with a CIDR containing '<IP_ADDRESS>'

I had to set the /32 cidr on the annotation, which doesn't match the documentation here: https://docs.cilium.io/en/stable/network/lb-ipam/#requesting-ips
The only thing I can think of is that I'm using /32's because my IP block has some 'holes' in it (external services) that I don't want to be included in the pool, thus I had to enumerate the entire block using /32's.
# cilium version
cilium-cli: v0.15.8 compiled with go1.21.0 on linux/amd64
cilium image (default): v1.14.1
cilium image (stable): v1.14.2
cilium image (running): 1.14.2

# uname -a
Linux capital 5.15.0-84-generic #93-Ubuntu SMP Tue Sep 5 17:16:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

#  kubectl version
WARNING: This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.6+k3s1", GitCommit:"bd04941a294793ec92e8703d5e5da14107902e88", GitTreeState:"clean", BuildDate:"2023-09-20T23:05:58Z", GoVersion:"go1.20.8", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.6+k3s1", GitCommit:"bd04941a294793ec92e8703d5e5da14107902e88", GitTreeState:"clean", BuildDate:"2023-09-20T23:05:58Z", GoVersion:"go1.20.8", Compiler:"gc", Platform:"linux/amd64"}

cilium-sysdump-20230924-231254.zip

@withinboredom You don't have serviceSelector on the pool, we had some issues before when we didn't set it. Try doing something like:
apiVersion: cilium.io/v2alpha1
kind: CiliumLoadBalancerIPPool
metadata:
  name: pool
spec:
  cidrs:
    - cidr: <IP_ADDRESS>/32
    - cidr: <IP_ADDRESS>/32
  disabled: false
  serviceSelector:
    matchLabels:
      ip-pool: my-pool

(you need to set this label on the LB service as well)

Currently, LB IPAM doesn't allow to specify /32. This should be fixed with this PR https://github.com/cilium/cilium/pull/26488.

Tagging this as a bug since released versions don't reject the /32.

cc @dylandreimerink


SDK_ERROR, 20006, There is no valid registration

Hello, I integrated infobip hms sdk for push notifications according to official documentation, the problem is that android devices receive Installations with pushRegistrationId, but huawei devices don't.  My code below:
   MobileMessaging.getInstance(fragment.context).fetchInstallation(object : MobileMessaging.ResultListener<Installation>() {
        override fun onResult(result: org.infobip.mobile.messaging.mobileapi.Result<Installation, MobileMessagingError>?) {
            pushRegistrationId = result?.data?.pushRegistrationId ?: ""
    })

Can you give me any thoughts how to fix that ?

Hello @Demetresko,
Here we have the description of this error https://github.com/infobip/mobile-messaging-sdk-android/wiki/Troubleshooting
Could you please provide more information for us:

Android version (target, compile)
Used Mobile Messaging SDK version
Code-snippet describing how are you initializing MobileMessaging SDK

Hi @Demetresko
Seems like an error with app or device configuration.

Could you please explain how it's configured? Or provide sample?
Have you installed HMS services from appgallery?

Best regards

@kostap13

I did configuration according to official  doc https://github.com/infobip/mobile-messaging-sdk-huawei
we tested app on huawei p40 lite with hms services and pushRegistrationId didnt come
Should I enable push kit in my project huawei console  or there is no relation between infobip and it ?

@Demetresko

Should I enable push kit in my project huawei console

Yes. It's required. Like other steps from Huawei PushKit config
https://developer.huawei.com/consumer/en/doc/development/HMSCore-Guides/android-config-agc-0000001050170137

Hi @Demetresko,
Did you manage to configure our SDK properly (so that we are able to fetch the token from HMS and generate push registration ID). Can we close this issue?
BR,
Tereza


Release Camunda Modeler v4.3.0

What's inside?

(see Milestones M42 for all details). Summary:

fix(modeling): incoming flows to boundary message events shall be allowed
fix(dmn): make undo/redo work in various scenarios
fix(dmn): make copy/paste work in various scenarios
feat(dmn): improve intuition recognizing input and output columns
feat(dmn): move bpmn.io logo
feat(properties-panel): Improved input/output mapping GUI component
feat(properties-panel): process variable detection based on output mappings, form fields and result variables
feat(properties-panel): process variable overview for (sub) processes
feat(properties-panel): process variable typeAhead functionality
feat(properties-panel): adjusted element template view
feat(properties-panel): crop descriptions
feat(elementTemplates): modal to apply elementTemplates
feat(elementTemplates): introduction of apply/link/unlink logic
feat(elementTemplates): handling of missing templates
fix(diagram-js): Correctly handle stopPropagation for iphone and ipad devices

Release Checklist
To be done immediately after creating this issue.

[x] put up code freeze appointment in calendar (include modeling, qa, infra, and Team-Support)
[x] put up release appointment in calendar (include modeling, DevRel and Marketing [Charley Mann & Christopher Rogers])
[x] add Slack role to release manager (@modeling-release-manager)

To be done after code freeze and prior to the release day to prepare and build the release.

[x] make sure changes in upstream libraries are merged and released

bpmn-js, dmn-js, cmmn-js, *-properties-panel, *-moddle, ...

[x] make sure dependencies to upstream libraries are updated and can be installed (rm -rf node_modules && npm i && npm run all works)
[ ] close all issues which are solved by dependency updates
[x] verify develop is up to date with master: git checkout master && git pull && git checkout develop && git merge master
[ ] smoke test to verify all diagrams can be created
[ ] update CHANGELOG
[x] merge to master: git checkout master && git merge develop
[x] create release candidate (npm run release), e.g. v1.0.0-rc.0

[x] wait for Travis to build the executables

[ ] execute integration test on released artifacts

[ ] Works on Linux @MaxTru
[ ] Works on Mac @oguzeroglu
[ ] Works on Windows @pinussilvestrus

[ ] execute release specific integration tests

[ ] Cawemo <-element template sync-> Modeler
[ ] Modeler element templates regression test

[ ] trigger QA for fuzzy testing
[ ] write blog post for blog.camunda.org according to this process

[ ] copy and paste this template to a new docs file in Modeling blog posts
[ ] write a draft version of the blog post
[ ] send it to Charley Mann and Christopher Rogers for review and ask them to coordinate the publishing

To be done after integration test was successful or if not issues were fixed.

[ ] create release (npm run release), cf. release schema

[ ] wait for Travis to build the executables

To be done on release day to announce the release and making it publically available.

[ ] publish release on Github Releases
[ ] trigger mirroring of release to https://camunda.org/release/camunda-modeler/ via Jenkins
[ ] update download version of Camunda Modeler by reaching out to David Paradis
[ ] spread the word

[ ] send release notice email
[ ] tweet

[ ] add new version to updates-server releases JSON file. Merge this file to master/live branches.
[ ] close current milestone

Blog post draft: https://docs.google.com/document/d/1RnonxwJhkz7b4xVdKoQEGv3XeEDvitLlSquZUuDGeKI/edit


Remove readme push

needs a longer look as to what is needed on the agents to run.
this issue is currently blocking image publishing.

@eganjs - FYI. It has been blocking so temporarily removed.

I have created a branch off the current master for investigation.


Error during run on windows 11

Hi,
I'm currently getting this error when trying to run the exe in any command line:
Error:
  An assembly specified in the application dependencies manifest (trash.deps.json) was not found:
    package: 'LibGit2Sharp.NativeBinaries', version: '2.0.312'
    path: 'runtimes/win-x64/native/git2-6777db8.pdb'

Running latest version 1.6.2
Regards,
Landelor

Retested previous version and that works fine.

What OS (and OS version) are you running on?

Was Windows 11, and I'm assuming that is the issue. I'm in the process of reverting and will retest once done.

Same thin here on Windows 10 21H1 19043.1110

This is now fixed in v1.6.3
Note that you will temporarily see a new PDB file bundled with trash.exe. This is normal and that file is required. The release notes go into more details.


Milestone creation

I have created two milestones. Can you guys check and confirm me? @poojashresthacode  @Mosaddeq107

Yup, we can see


Allow "binary sensor" as "Charger control Switch"

The tesla wall charger integration uses "binary sensor" and not a switch as the charger entity.
Would be awesome if we could add that under the configuration (the last option)

Binary sensors as well as any kind of sensor are read-only. It can't be used to control the integration. I looked at the Tesla Wall Cconnector implementation, and I couldn't find anything that will make it possible to start charging using that integration. It only seems to have (read-only) sensors.


remove unnecessary clone() in create.rs

I will try to make create.rs easier to understand little by little.

The create.rs should be split up more, but I don't have a good idea how to split it up, so if you have any suggestions, please let me know.

@utam0k I plan to move the create.rs code to a builder, so that we can reuse it in exec and in tests. This should give me more ideas on how to organize it.

@Furisto Your idea sounds good to me. Since I think it's fine to proceed in that direction, but I'd really like to hear other developer's opinions, could you create an issue about it?


Removed TravisCI config

The project is switching to GitHub Actions for its CI needs, removed
the config for TravisCI as it'll no longer be used

Great stuff! Many thanks for this and the other PRs :)

Great stuff! Many thanks for this and the other PRs :)

You're welcome :)


Updated dustinbrett.com link/repo name

I've rebranded x to daedalOS and also spent all year rebuilding it from scratch to be 10x better. The new version is live and ready to check out.

cool stuff man!

Thanks @syxanash!


Added collation

Coverage remained the same at 61.268% when pulling d11097d1bead33d7c53d8f53e58adef1c81908a5 on lproperty:v0.4.1 into cf42053132f7d4551c1899b757e0a2ffbfda16c5 on CS2103JAN2017-T15-B3:v0.4.1.

Coverage remained the same at 61.268% when pulling c14759aa16591575681ce89b0c74f846c4385d61 on lproperty:v0.4.1 into cf42053132f7d4551c1899b757e0a2ffbfda16c5 on CS2103JAN2017-T15-B3:v0.4.1.


Nest Hello Doorbell

Hi,
I was able to add the normal Next camera via the go2rtc nest integration, but it didn't see my gen 1 doorbell.
Tried to add the device-id manually as a nest? integration, I got the device-id from the command:
curl -X GET 'https://smartdevicemanagement.googleapis.com/v1/enterprises/xxxxx/devices' \     -H 'Content-Type: application/json' \     -H 'Authorization: Bearer xxxxxxxxx'
But when I check the streams on go2rtc dashboard it just says "mse: streams: nest: wrong status: 404 Not Found"
The main difference that I noticed in the GET api call was that the camera is type "sdm.devices.types.CAMERA" while the doorbell is type "sdm.devices.types.DOORBELL".
Is this not intended to work yet? Just trying to figure out if I should continue to bang my head against the wall.
Thanks for all your work.

Are you sure your device model works over WebRTC proto?


Move to github actions.

The flow is the same as it is for Jenkins. It will run the tests on push
or pull request. If the branch is master, then the docker image is built
and pushed with a version tag and the deploy job is called.
A lot of this will be common to a lot of the other test and deploy jobs. When I do another repository, I'll move the common code out into another repo but for now, I just want to get it working.

Marking this as draft as there's a load of other stuff that has to go in first


fix: indent & line highlighting in guides/internationalization.mdx

Description (required)
Fixes a few nitpicks in guides/internationalization.mdx:

in the domains section, the highlighting for inserted lines should be restricted to the domains property
in the code snippet of Custom locale paths, the indent for codes was wrong
in the Create localized folders section, missing backticks for a route (all other routes on the page are wrapped with backticks)

Related issues & labels (optional)

Suggested label: code snippet update

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File
Note

en/guides/internationalization.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Simplify construction of Height

Since the constructor accepts `bigint | string | UInt64`,
there's no need to call either `fromString` or `fromNumber`,
reducing the dependencies between modules.

The string type is entered.
two toString() runs

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toString
String.prototype.toString is equivalent to valueOf, so it's a no-op.
E.g. try:
$ node -e 'console.info("hello".toString().toString().toString());'

And you'll get the same result no matter how many toString() you add.


java.lang.IllegalStateException: Added View has RecyclerView as parent but view is not a real child. Unfiltered index:0

Hi, I use expandable and draggable adapter in my app. Some users crashed when use my app, but I can't response this crash.
Here's the crash log, I want to know if there's any other people has this crash? And how to solve it?
java.lang.IllegalStateException: Added View has RecyclerView as parent but view is not a real child. Unfiltered index:0
    at android.support.v7.widget.RecyclerView$LayoutManager.addViewInt(RecyclerView.java:6071)
    at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:6037)
    at android.support.v7.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:6025)
    at android.support.v7.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1378)
    at android.support.v7.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1327)
    at android.support.v7.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:556)
    at android.support.v7.widget.RecyclerView.dispatchLayout(RecyclerView.java:2713)
    at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:3011)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1673)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1527)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1436)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:453)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:388)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:453)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:388)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:453)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:388)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1673)
    at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1527)
    at android.widget.LinearLayout.onLayout(LinearLayout.java:1436)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.widget.FrameLayout.layoutChildren(FrameLayout.java:453)
    at android.widget.FrameLayout.onLayout(FrameLayout.java:388)
    at android.view.View.layout(View.java:14858)
    at android.view.ViewGroup.layout(ViewGroup.java:4646)
    at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2035)
    at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1792)
    at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1047)
    at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:5896)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:761)
    at android.view.Choreographer.doCallbacks(Choreographer.java:574)
    at android.view.Choreographer.doFrame(Choreographer.java:544)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:747)
    at android.os.Handler.handleCallback(Handler.java:733)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:136)
    at android.app.ActivityThread.main(ActivityThread.java:5103)
    at java.lang.reflect.Method.invokeNative(Native Method)
    at java.lang.reflect.Method.invoke(Method.java:515)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606)
    at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
    at dalvik.system.NativeStart.main(Native Method)

I had the same error when using the Swipe adapter and removing/adding elements.
It was related to duplicate IDs given to items. (2 items had the same ID, if I clicked on the second item -> crash).
Once I made sure every IDs were unique everything worked fine.
Hope it helps you.

@GauthierRoomDotMe  Thanks for your reply.
I think I had already fixed this problem. It caused by something in onCreateGroupViewHolder . I had some wrong code when creating view.
Seems it not related to item id. The item id in my code is like below:
	@Override
	public long getGroupId(int groupPos) {
		return  groupPos;
	}

	@Override
	public long getChildId(int groupPos, int childPos) {
		return childPos;
	}

What's your meaning of duplicate IDs ? I think use the position as the id is OK.

I had the same error and the solution for me was to no longer specify my own ids.
So I removed the following lines of code and it started working again:
  public MyAdapter(Context context) {
      this.context = context;
-     setHasStableIds(true)   // <----- removed this
  }

and all of this:
-    @Override
 -    public long getItemId(int position) {
 -        return position;
 -    }

@crazymajax Hi. This library need stable IDs. Without stable and unique ID values, unintended item animations and crashes will be caused.
  @Override
    public long getItemId(int position) {
        // return position; <- this is not stable!

        // should returns stable value. IDs have to be kept the same value
        // even after its position has been changed.
        return mItems.get(position).getId();
    }

related issues:

Help!! #180
Swipe state not working properly #170
swiping on any item only moves index 1 #159
Unnecessary animation on drag #83
Position Changing Between List Item #22
Issues with stable ids #7
Repeated animation problem #5

is that even the sdk bug?

Hi @h6ah4i,
I have same issue in my App. I have never seen this in testing but I see many crash logs from production.
I have one activity, viewpager with multiple fragments and nested fragments in it. I have 1 expandable swipable draggable adapter and 4 expandable recyclerview adapters. I couldn't get line number of my code also. I am sure, i am setting unique group id for each item. I have 1 as child item id in all these recyclerview. Can you suggest me where to start debugging this?

@kssujithcj Hi. Maybe this kind of error caused by duplicate IDs or adapter state mismatch with notify* methods.
Duplicate IDs
I suspect this would be the most probable cause of the issue if you are using v0.9.x. The getGroupId() and getChildId() methods have limitation of its returning value range. If the out-of-range group/child IDs are returned, duplicated flattened IDs will be generated by this library (*1, *2).

Library version
Group ID
Child ID
Note

v0.9.x
31 bit integer
32 bit integer
ID value range is not checked, unsupported range bits are just ignored (masked)

v0.10.0 (*3)
28 bit integer
28 bit integer
ID value range is strictly checked

(*1) Source code: How flattened ID generated in v0.9.3
(*2) Source code: How flattened ID generated in v0.10.2
(*3) How ARV uses item ID - ItemIdComposer
related issue) https://github.com/h6ah4i/android-advancedrecyclerview/issues/321
Adapter state mismatch
The RecyclerView.Adapter has notify* methods, if these methods are not used properly dataset and adapter will get into inconsistent state. Note that this library uses these methods internally and it might be what you are not intended! I think detecting this kind of error is very hard... but at least you can observe and logging these method calls by using the registerAdapterDataObserver().

@h6ah4i,
Thank you. This new update saved my months of quest.

@h6ah4i  I am having the same error in my app, how do I fix it ? I understand the wrap around problem as the range of the numbers represented by the 32 bit integer is fixed. How do I go about finding the error. my app crashes when I try and open a webview in my app.

@11manu96 Sorry, I do not have any more advices about this issue. If possible, can you please share your app code (or minimal example code to reproduce) with me?

@GauthierChan your reply saved me! Thanks!


qt_gui_core: 0.2.33-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository qt_gui_core to 0.2.33-0:

upstream repository: https://github.com/ros-visualization/qt_gui_core.git
release repository: https://github.com/ros-gbp/qt_gui_core-release.git
distro file: indigo/distribution.yaml
bloom version: 0.6.4
previous version for package: 0.2.32-0

qt_dotgraph
* limited backport of recursive subgraph parsing (#117 <https://github.com/ros-visualization/qt_gui_core/issues/117>)

qt_gui

No changes

qt_gui_app

No changes

qt_gui_cpp

No changes

qt_gui_py_common

No changes

Holding for melodic rebuild...


Improve testing to achieve threshold coverage for mutation testing under Stryker

Improve the testing across the project by reducing the number of surviving mutants under Stryker to a reasonable level. Probably establish what "reasonable level" means too.

Done. 100% mutation coverage.


Fixed links in RU translation

PR fixes links in RU translation of the course

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add managerConnectString to query service config

Add managerConnectString to query service config.
To be used by the query service for connections to the manager.

@alllcontributors add @kx-chen for code

@allcontributors add @kx-chen for code


Friendly names not recognised

Hi Kellerza
The Add-on works great thank you.
I just couldn't see the filtered values after adding the info to the configuration.yaml file
I used the friendlly (sensor.sma_grid_total_5s) names like you show in the docs.md but just shows unavailable.
So I had to use the original entity name (sensor.pconsumecounter) in the filter platform part.
Not sure why but I thought you would like the feed back.
Thanks Again
Nicko1

Great news, thanks for the feedback. And glad you got your connectivity fixed!
in docs.md there is a table with old names& new names. So after discovery by the addon I renamed my sensor’s entity_id to the new name, not just the friendly name. Iirc you click on the gear to change it, maybe that was not clear enough, but the purpose of the table 😄

@johnnysmithy852456 with the new (dev) version of the plugin the filter can be applied at the source and no need for adding them in home assistant. Once you have the addon repo, simply install the dev version and try it out - info on the docs tab of the new version


Add ROS-CI using GitHub Actions based on Industrial-CI

@wxmerkt Thanks a lot for this nice feature.


Removed installation of gsplot from R script to:

attempt to work around GitHub HTTPS throttling.

Coverage remained the same at 97.425% when pulling f734db0b1f62befcf94f06ff9f528d10287b624f on ashalper-usgs:AQCU-936 into 4c06d9457d55b435ae0c36779ca0f8bd32b2b0ee on USGS-R:master.


[BUG] Logging not working from other threads

Investigative information
Python version: 3.9.10
Core Tools Version: 4.0.4915
Function Runtime Version: <IP_ADDRESS>31
Repro steps
dispatch a function that uses logging to a background thread
Expected behavior
The logged text appears in the logs
Actual behavior
The text isn't logged
Example:
import logging
from concurrent.futures import ThreadPoolExecutor
import azure.functions as func

def main(req: func.HttpRequest) -> func.HttpResponse:
    logging.info('Python HTTP trigger function processed a request.')

    with ThreadPoolExecutor() as pool:
        pool.submit(foo)

    return func.HttpResponse(
        "This HTTP triggered function executed successfully",
        status_code=200
    )

def foo():
    logging.info("Hello from foo")
    print("foo completed")

When I trigger this, In the console I can see "foo completed" but not "Hello from foo".
Contents of the requirements.txt file:
azure-functions==1.12.0

Related:
https://github.com/Azure-Samples/fastapi-on-azure-functions/issues/11

Thanks for reporting we will discuss this feature issue and update you on the inputs soon.

@bhagyshricompany Any update on this?

@Qmatteo we have looked and identified the cause, within python function worker there is a managed threadpoolexecutor which wraps cx's sync function by assigning function invocation id to thread_local. This does not apply to cx managed threadpoolexecutor and thread without function invocation id assigned will not be logged
https://github.com/Azure/azure-functions-python-worker/blob/9a58193076e9b7b14990aa3fe09b5336b5c3db4c/azure_functions_worker/dispatcher.py#L713
we are working on the fix and will let you know

@YunchuWang how long do you think it will take to fix the problem?

@vrdmr please comment on this

@vrdmr please comment on this

Hi, a potential fix is currently under review. Thank you for your patience, and we will keep you updated on this.

@EvanR-Dev ok. Any ideas on the timeline?
Coz I think that the PR must be reviewed, approved, completed and released.
But right now we have some functions in production that we are not able to monitor since we don't see any logs

I understand. It will be merged by the end of this week and part of the next release. The release will take time as we are doing hot fixes and could take by the end of March by the time it is finally out. We thank you for your patience once again.

has this fix been released?

This fix will be released with runtime version 4.19. ETA mid-April

Hi @gavin-aguiar ,
how can we track when the 4.19 is going live?

@Marco-Santoni 4.19 is already deployed for dedicated plan in all regions. Consumption deployment has started and should be done in a week.

Investigative information
Python version: 3.9.10 Core Tools Version: 4.0.4915 Function Runtime Version: <IP_ADDRESS>31
Repro steps
dispatch a function that uses logging to a background thread
Expected behavior
The logged text appears in the logs
Actual behavior
The text isn't logged
Example:
import logging
from concurrent.futures import ThreadPoolExecutor
import azure.functions as func

def main(req: func.HttpRequest) -> func.HttpResponse:
    logging.info('Python HTTP trigger function processed a request.')

    with ThreadPoolExecutor() as pool:
        pool.submit(foo)

    return func.HttpResponse(
        "This HTTP triggered function executed successfully",
        status_code=200
    )

def foo():
    logging.info("Hello from foo")
    print("foo completed")

When I trigger this, In the console I can see "foo completed" but not "Hello from foo".
Contents of the requirements.txt file:
azure-functions==1.12.0


ILSVRC extremely slow reading using ImageFromBytes

Both classes for ImageNet task store encoded images using raw bytes buffer in hdf5 files. Upon reading the data is converted using PIL to numpy array. The conversion takes too long time.
With ImageFromBytes it takes around 11 seconds to read 20 batches of size 256.
Commenting out ToBytes and ImageFromBytes, it takes less than half second.
I tried to use multiprocessing.Pool but it didn't help.
from fuel.datasets.imagenet import ILSVRC2012
from fuel.streams import DataStream
from fuel.schemes import ShuffledScheme
from fuel.transformers.defaults import ToBytes
from fuel.transformers.image import ImagesFromBytes

train = ILSVRC2012(('train',))
indices = range(train.num_examples)

stream = DataStream(train, iteration_scheme=ShuffledScheme(indices, 256))
stream = ToBytes(stream, which_sources=('encoded_images',))
stream = ImagesFromBytes(stream, which_sources=('encoded_images',))

epoch = stream.get_epoch_iterator(as_dict=True)
batch_index = 0
import time
s = time.time()
while batch_index < 10:
    batch_index += 1
    batch = next(epoch)
print("took: %f" % (time.time() - s))

Yeah. There isn't a great solution (that I could find) if you want to store the full images. I've mostly been using the 2010 class as a source for conversion to a pre-cropped H5PYDataset.

Here's some code I wrote that helps a little bit, insofar as the issue is JPEG decoding being slow. Not much help with speeding up disk I/O. For that I think we'd need to go the Caffe route and write a leveldb backend (which may not be much work for the right person).
from concurrent.futures import ThreadPoolExecutor

import numpy
from jpeg4py import JPEG, JPEGRuntimeError
from PIL import Image
from toolz import flip

class JPEG4PY(SourcewiseTransformer):
    def __init__(self, stream, max_workers=True, **kwargs):
        kwargs.setdefault('produces_examples', stream.produces_examples)
        self.thread_pool = ThreadPoolExecutor(max_workers=max_workers)
        super(JPEG4PY, self).__init__(stream, **kwargs)

    def transform_source_example(self, source, source_name):
        try:
            return JPEG(source).decode().transpose(2, 0, 1)
        except (JPEGRuntimeError, TypeError):
            im = Image.open(io.BytesIO(source.tostring()))
            if im.mode != 'RGB':
                im = im.convert('RGB')
            return numpy.array(im).transpose(2, 0, 1)

    def transform_source_batch(self, source, source_name):
        f = flip(self.transform_source_example, source_name)
        return list(self.thread_pool.map(f, source))

Yeah, that quite helps. I am getting 4-5 speed (around 2 seconds) improvement with 8 threads. Do you want to add it to the image transformers?
Btw, there are many transformers which do not have an efficient batch transformation. Shouldn't we fall back on multi-threaded batch transform then? It gives some improvements.

jpeg4py calls into C code and releases the GIL, so it is particularly well
suited to parallel decoding. Unfortunately most Python code won't
parallelize like that.
Not sure if we want to add jpeg4py as a hard dependency, either.

For the current implementation, image decoding is a bottleneck, not i/o. That's
why in my opinion leveldb is not necessary yet.
I had a brief look at caffe conversion code for imagenet dataset. And by default
they store decoded data using their native format Datum (correct me if I am
wrong). So it is not necessary to jpeg decode it again if encoding is not set.
Maybe option can be added where image will be decoded and stored directly as
numpy array/buffer/string. What issues did you have when trying to store data in
hdf5 using numpy arrays? I think you mentioned about it somewhere.

At full resolution a) the files will be huge b) I'm fairly sure that the amount of bytes you will need to read off of disk per minibatch will create an I/O bottleneck. I'd be very surprised if people training with ImageNet on Caffe are not decoding on the fly. The ServerDataStream may help pipeline that.


update dependencies, handle profile links.

Hi,
I'm proposing some minor changes.

I updated the packages.json file to latest working versions. (note: the largest chunk size did increase from 700kb to 1mb, due to upstream additions to the bluesky API package, I've +1'd the issue https://github.com/bluesky-social/atproto/issues/2175 about the problem)
I corrected the links to profile pages for users on *.bsky.social, previously it was stripping out that part of the profile URL, resulting in broken links.
I changed the loading text from 'loading your {collection}' to 'loading {collection}', as you could be looking at any profile. :)

Just seen a dupe PR here - https://github.com/bskyviewer/bskyviewer.github.io/pull/2
Didn't realise that was being worked on elsewhere :)


Cannot find files under '/bower_components'

$ polylint --root app/ --input index.html
ERROR finding app/bower_components/webcomponentsjs/webcomponents-lite.js
Error: ENOENT: no such file or directory, open 'app/bower_components/webcomponentsjs/webcomponents-lite.js'
    at Error (native)

Set your root to / and the file to app/index.html


[DEV-759] [BUG] pygwalker visualization size not rendered correctly in streamlit app

Original bug report: https://toriaezuugoku.com/pygwalker-2/

Windows10
streamlit==1.27.0
pygwalker==0.4.7

It seems pygwalker does not rendered with correct size so the charts in the article only shows legend parts.

related code with bug
https://github.com/Kanaries/pygwalker/blob/ac6c12dbadf85ac03e4e36e35c130351be3689fa/pygwalker/api/streamlit.py#L223
DEV-759

This is because when the size of graphic-walker is auto, pygwalker does not correctly give the streamlit iframe a correct width and height.
chart_size_config["mode"] = "fixed"

The above code is for pygwalker to render the graphic-walker chart according to the width and height passed in by the user.


Add gRPC async stream support to ent

Title: Add gRPC async stream support to ent

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary
ent should support gRPC async streams to allow users to take advantage of the performance, scalability, and flexibility offered by this feature when building applications that use ent as their database. This would also make it easier to integrate ent with other systems that use gRPC.
Motivation
gRPC async streams allow clients and servers to send and receive an unbounded number of messages over a single connection. Adding support for gRPC async streams to ent would provide benefits to users, including improved performance, increased scalability, and greater flexibility when exchanging data between the client and server. The lack of this feature has made it more difficult to build applications that use ent as their database and to integrate ent with other systems that use gRPC.

Hi 👋
Thanks for reaching out.
Can you please elaborate on how you would expect the generated gRPC service definition to look like?

Hi 👋
Thank you for your response. I am a big fan of the ent project and appreciate all of the hard work that has gone into it.
Regarding the gRPC service definition, I would expect it to follow the standard gRPC syntax as outlined in the documentation at https://grpc.io/docs/languages/go/basics/. Here is an example of a simple gRPC service declaration in a .proto file:
service MyService {
  rpc MyMethod(MyRequest) returns (MyResponse) {}
  rpc ServerStreamingMethod(ServerStreamingRequest) returns (stream ServerStreamingResponse) {}
  rpc ClientStreamingMethod(stream ClientStreamingRequest) returns (ClientStreamingResponse) {}
  rpc BidirectionalStreamingMethod(stream BidirectionalStreamingRequest) returns (stream BidirectionalStreamingResponse) {}
}

Thanks for the quick response 🙃
I'm aware of the streaming options on gRPC. Let me clarify my question -
What do you hope to achieve with streaming using entproto/gRPC? The current generated methods are basic CRUD operations, these don't benefit much from streaming.
So, it would help to see some practical example of how you would expect streaming methods on a specific ent schema would work 🙏

I am interested in using ent with an existing project that uses streaming rpc endpoints. In our case, we found that using grpc was the most efficient way to use gomobile inside an iOS or android app. We use grpc-swift's generate clients to communicate with the embedded go code. This approach allowed us to access a set of messages using an async sequence, avoid polling, and avoid type conversion issues (we use protobuf for portability between go and swift).
We got the idea to implement an async service using grpc.health when implementing a swift grpc.health client. This allowed us to get rid of our previous gomobile API wrappers and standardize around protobuf and grpc for portability.
However, when we tried to use ent, we got stuck on how to define our existing streaming rpc. Adding support for gRPC streaming to ent would allow us to take advantage of these features when working with ent, making it easier to integrate ent with our existing project. I hope this helps to clarify my request.

It sounds like you want to add some custom streaming gRPC methods to your program and use Ent to access the database.
My advice in this case is to add another service definition in a separate proto file next to the generated proto file. This way you can use the generated pb messages that represent your Ent schemas. Then implement the custom service, embedding an Ent client in the struct. If you do this in the same go package as the generated service you can use the private generated conversion functions between ent and proto structs.
HTH
R


Replacement PR for #8761, 8760, 8759 and 8758

This change builds upon the work done by @brandf and addresses the missing TextMesh Pro dependency.
It also moves the IrridescentSpectrum*.* files from the foundation to the standard assets package.
Note: This change does not cover the complete list of missing dependencies as outlined in #8763. Those will be covered in a future PR.

/azp run

/azp run


Add shared CSS for docs prose

Closes #25
There's not much in here now, but we can add more if necessary later.

Just to be clear: nothing in dr-ui is referencing docs-prose.css right now, right?

🗣 CORRECT.


Refactor naming of Dependencies -> Prepare

We're shifting the terminology of this new config. The new keys will
be:
prepare:
  fetch:
    - "http://example.com/thing"
    - url: "foo"
      path: "bar"

Cool.

LGTM


[PackageTool] Add update cli for new resolver

It is still hidden behind the --enable-new-resolver flag which is
expected to be removed once we make the switch to the new dep resolver.

@swift-ci please test

Unrelated linux failure, tested locally. This PR is now a very small change due to the recent refactor in SwiftTool


Update Rosetta README Coda references to Mina

Update Rosetta README Coda references to Mina
Text changes don't require testing. Tested updated links in browser.
Checklist:

[x] Document code purpose, how to use it
[x] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? List them: -

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

Only the rosetta-docker step is failing, which we'll address with a later PR


Added transparency to window builder

Applogies, had to recreate this pr because of branching issue.
Old PR: https://github.com/bevyengine/bevy/pull/3033
Objective
Fixes #3032
Allowing a user to create a transparent window
Solution
I've allowed the transparent bool to be passed to the winit window builder

Code looks fine,
sucks that it's not supported on so many platforms.

Code looks fine, sucks that it's not supported on so many platforms.

Well it only makes sense for Desktop platforms(Windows, Mac, Linux) and:

I think I found a workaround on Linux, forcing winit to run on it's master branch fixes this, or at least just on my Manjaro Linux machine with Nvidia proprietary drivers. I'm assuming that this now works because of this PR: rust-windowing/winit#2006

Originally posted by @Supermath101 in https://github.com/bevyengine/bevy/issues/3032#issuecomment-954148213
So if that gets updated in the future then only mac will not be supported which might get fixed by this issue: https://github.com/gfx-rs/wgpu/issues/687

bors try

@louisgjohnson, you need to be on the Bevy org to be able to do that :) It's a low bar (pretty much just "good faith"), just ping cart on Discord or Github.

bors try

I think I found a workaround on Linux, forcing winit to run on it's master branch fixes this, or at least just on my Manjaro Linux machine with Nvidia proprietary drivers. I'm assuming that this now works because of this PR: rust-windowing/winit#2006

Originally posted by @Supermath101 in #3032 (comment)

If it won't work by default on linux, then linux should be mentioned in the platform specific documentation

bors r+

@louisgjohnson I can confirm this works on Ubuntu 20.04 with nvidia 1070, on bevy main.


Form Links do not open to new page (Global Function impacted by Update 5.0)

Background: As a form's designer, I noticed when building a new form that the form links do not open to a new page.
Steps to Reproduce: In the dev env, the 1.10 Complaint form being built has 3 links located in the instructions panel. These links do not open to a new page.
Actual Behavior: This is a global function that was applied to all forms to ensure that (_blank) or new page/tab was opened up after a link was selected.  The recent 5.0 updated may have affected the actual behavior.
Expected Behaviour: User should not leave the form, a new/second web page should open, i.e. to view the collective agreement.
Environment: Dev (not sure if this impacts all other environments since its global function)

@MissionT @Stella-Archer
I have deployed this change on DEV. Could you please test it here? If it looks good then I'll move it to TEST today.

Nice this works perfectly in DEV @iman-jamali-fw good to move to TEST

This worked great

We noticed when reviewing the Bulling Form 1.10 form that the GEU and PEA links do not open to a new web page. Can this fixed so that the user does not leave the Forms page when selecting a URL to view related data.


Update configure.py to support pre-release versions of clang

Since commit 055e421c4004b60588de2d728cc51cdd749dd350, pre-release versions of clang may no longer be supported, if they are built from the llvm git and include the "git" suffix in their version message.
In this case, retrieve_clang_version will return None, which will then abort the program:
Traceback (most recent call last):
  File "configure.py", line 1466, in <module>
    main()
  File "configure.py", line 1417, in main
    disable_clang_offsetof_extension(clang_version)
  File "configure.py", line 886, in disable_clang_offsetof_extension
    if int(clang_version.split('.')[0]) in (16, 17):
AttributeError: 'NoneType' object has no attribute 'split'

Fix this by falling back to an assumed version. That is, treat 18.0.0git as 18.0.0. The warning will still be printed.
For context, an example clang --version excerpt:
clang version 18.0.0git (https://github.com/llvm/llvm-project.git ea3a3b25b93664c8be750ac3cd550855dcd1848b)

Hi @kanglant Can you please review this PR ? Thank you!

Hi @kanglant Can you please review this PR ? Thank you!


Chaper 04 typos

Minor typos

Hi @jrandallsexton, thanks for spotting those typos! Can you please resolve the conflicts with your branch in a way I can merge your PR?


Save audio/video files

The issues I recall : missing tip/download button on anonymous claims, not being able to delete correctly (kept spinning / notification for "active lbry downloads" stayed available), turning off autoplay on download (which you said you fixed)


[docs] Demo SearchIcons crashes

[x] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://mui.com/components/material-icons/?query=arrow
??
demo SearchIcons crashes

Your Environment

Tech
Version

MUI
v5.5.0

netlify deploy
https://622bf492b027b5000960dea3--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.51 Safari/537.36

Duplicate of #31562


eddiejaoude profile shows fewer testimonials than those in the data

Description
I was comparing the number of testimonials in the data for @eddiejaoude and realised there is a discrepancy between what the profile shows (5 testimonials) and what is contained in the data (7 testimonials). Please have a look.
Screenshots
No response
Additional information
No response

This is working correctly.
In order for a testimonial to be displayed, the name of the file in the testimonial directory must also be in the profile testimonials field. Only 5 of the 7 files meet this requirement.
Eddie's profile has 2 names in the testimonials section that don't have a matching file in the testimonials directory.

Thank you both for collaborating 👍
Yep I am have not reviewed the other testimonials yet, so I have not included them on my profile. Currently these are the ones included https://github.com/EddieHubCommunity/LinkFree/blob/main/data/eddiejaoude.json#L20
Here are the docs to the testimonials section if you would like to learn more (or let us know if something doesn't make sense or is missing)


Percona 5.6 Docker Image cannot load my /etc/mysql/conf.d/*.cnf

I am struggling on this issue for at least 14 hours so far :(.
I am configuring a build server with docker, jenkins, java, scala on top of CentOS 7.
While working with liquibase and jooq:codegen, I need to have proper MySQL(Percona:5.6) containers setup, but unfortunately, it seems that Official Percona Image (Percona:5.6) does not load *.cnf files under /etc/mysql/conf.d properly, which I do think it is my issue, such as file permissions issues.
I posted details on http://stackoverflow.com/questions/37501725/percona-5-6-docker-image-cannot-load-my-etc-mysql-conf-d-cnf

Closing since the stack overflow answer was accepted as resolving the issue

the reason is because the directory: /etc/mysql/conf.d should have at least 555 permission.


Run button for withData tests

Hello,
thanks kotest and idea plugin.
Would be possible to add run button for test wrapped by withData from "io.kotest:kotest-framework-datatest-jvm"?
On attached image - run button on line 35.

+1

+1, we are currently considering going back to junit because of the intellij integration of kotest

I'm working on an updated plugin for the 6.0 release. Eta Q4.


Multimedia

Is there anyway to play audio either from a file or device? I saw quasar has an extension, but wasnt sure if it was supported.

Yes, see example below taken from the Quasar docs. Please bear in mind that it will not work in a localhost environment https://stackoverflow.com/questions/51424578/embed-youtube-code-is-not-working-in-html (You will see the youtube interface but will get a download error when you try plating it)
import justpy as jp

html_string = """

"""

def video_test():
    wp = jp.QuasarPage()
    v = jp.parse_html(html_string, a=wp)
    return wp

jp.justpy(video_test)


Spectrogram fft fix

What changes were proposed in this pull request?
Fixes for issue #502
Length of each timewindow in Spectrogram now is same sa fftSampleSize.
FastFourierTransform has a method which takes a real-valued signal. I left the old behaviour (which assumed complex valued) since there was a testcase for it already.
How was this patch tested?
New testcase for FFT added, although it has magic numbers in it. Manual inspection in debugger to see that change of real to complex format expected by FFT is correct.
Spectrogram windowing was tested manually by (temporarily) adding amplitudes as argument to buildSpectrogram, commenting out calling it from constructor and a main method like this:
public static void main(String[] args) {
Spectrogram spec = new Spectrogram(null, 4,2);
short[] testVec = {0,1,2,3,4,5,6,7};
spec.buildSpectrogram(testVec);
}
Please review
https://github.com/deeplearning4j/deeplearning4j/blob/master/CONTRIBUTING.md before opening a pull request.

@saudet Sorry for the delay. Noob as I am I accidentally pushed changes to the fork master and not to the branch.
I'm not sure this is exactly what you were after, but I assumed you didn't want four public methods to do the two things the class can do.

Well, looks like a good enough compromise for me for now. 👍  Thanks!
We'll need to revist this anyway to get rid of the com.sun.media.sound.FFT class at some point since it's not available in Java 9 anymore.

@saudet Glad I could help!
Just a tip regarding the FFT: I recently converted my project to use Jtransform for transforms. It's licensed under BSD-2 Clause which from what I understand is a nicer license compared to GPL as it is non-viral. They claim comparable performance to FFTW (although the min execution time benchmark methodology looks somewhat fishy to me). Having a mix java and c in your project is bound to fail anyways /jk :)
I haven't done any measurements, but to me, there is no perceptable difference for ETL when training on raw waveforms vs spectrograms/MFSC/MFCC etc. It seems to be dominated by the file reading. For "online" inference (classifying audio stream from soundcard) even with my worst model ensembles the program spends ~70% of the time idling while the sound buffer fills up. All in all, FFT performance does not seem to be that important since other things (GPU memory for me) is bottlenecking.
I also saw that NDArrays have a built in fft method. I haven't tried it yet though but I guess it could be a kind of nice self-containment thing.

https://github.com/wendykierp/JTransforms looks awesome! If you could integrate that it would be great! FFT isn't currently implemented in ND4J and since this is currently only for ETL, I think it makes sense to just use JTransforms as is in DataVec. But if you'd like to create the API in ND4J for FFT first, and then use that in DataVec, that would be fine too.


use a cache wheel server to check if wheel was already built in build-sequence

fixes #505

I am not sure what would be the best way to implement the cache wheel server url argument. I didn't think it was best UX to have 2 options to actually enable skip existing behavior --skip-existing and --cache-wheel-server-url.
I went with the option of using only --skip-existing and passing a url instead of a boolean to implement this. The user can pass "localhost" if they want to use the wheel server that fromager spins up (this is consistent with the existing behavior)
thoughts @dhellmann ?

I am not sure what would be the best way to implement the cache wheel server url argument. I didn't think it was best UX to have 2 options to actually enable skip existing behavior --skip-existing and --cache-wheel-server-url.
I went with the option of using only --skip-existing and passing a url instead of a boolean to implement this. The user can pass "localhost" if they want to use the wheel server that fromager spins up (this is consistent with the existing behavior)
thoughts @dhellmann ?

I'm not sure why the 2 options are so tightly coupled. What's your reasoning there?
What if "skip existing" was the default behavior, what would the options for forcing a build look like?

From a user of fromager perspective who has been using skip-existing with build-sequence and build from the re-naming of cache-wheel-server-url is a little confusing as it is not necessarily a cache.
Previously eg in 0.34.0 and earlier I believe wheel_server_url: https://internal.pypi.example/simple would both disable the internal wheel server which allows for running parallelizable parts of the build graph (eg in separate containers), and be used for skip exising and thus also allow running multiple rebuilds simultaneously to also minimize work if they have a matching specification in the internal rebuilt repo.

As discussed offline, we will make fromager behave like make where it doesn't build a wheel if it already exists. We will add --force flag to force rebuild everything. We will also change the name of the option to --extra-index-url (just like pip) where this url is in addition to the local pypi server fromager spins up

Will --extra-index-url behave exactly like in pip? In pip, it adds additional URLs to the resolver. The resolver merges packages from the primary and all extra indexs.

Will --extra-index-url behave exactly like in pip? In pip, it adds additional URLs to the resolver. The resolver merges packages from the primary and all extra indexs.

Oh it won't. Should we rename it this to avoid confusion?


Vagrant internal network config

Issue Type

Feature request

Desired Behavior
When using Vagrant driver with VirtualBox provider it is sometimes desirable to create machines with network type "internal". In plain Vagrant it is done by providing additional parameter
config.vm.network "private_network", ip: "<IP_ADDRESS>", virtualbox__intnet: "mynetwork"

While it can be done by using instance_raw_config_args it has some limitations. For example it prevents using YAML anchors for pasting specific IPs. Also it would be much more convenient to use standard interfaces section. I've looked through code and it seems there are two options:

instead of hardcoding parameters passed based on type property just pass them all
add one more if-else branch with another type option

Please let me know whether you are going to accept PR with this functionality and if yes what implementation would you prefer.

Sounds fine to me.

Implemented in PR #1422

merged, thanks @skhoroshavin \m/


Autowatch stopped working

Expected behaviour
running from command line using ng test with configuration file having autowatch set to true and restartOnFileChange also set to true, when changing a spec file the karma test runner would re-run the tests.
Actual behaviour
It runs the tests once on start up and then does nothing more, even if you change a spec file and save the changes
Environment Details
config file
module.exports = function (config) {   config.set({     basePath: '',     frameworks: ['jasmine', '@angular-devkit/build-angular'],     plugins: [       require('karma-jasmine'),       require('karma-chrome-launcher'),       require('karma-jasmine-html-reporter'),       require('karma-coverage-istanbul-reporter'),       require('@angular-devkit/build-angular/plugins/karma')     ],     client: {       clearContext: false // leave Jasmine Spec Runner output visible in browser     },     coverageIstanbulReporter: {       dir: require('path').join(__dirname, '../coverage/bpmgroup'),       reports: ['html', 'lcovonly', 'text-summary'],       fixWebpackSourcePaths: true     },     reporters: ['progress', 'kjhtml'],     port: 9876,     colors: true,     //logLevel: config.LOG_INFO,     logLevel: config.DEBUG,     autoWatch: true,     browsers: ['Chrome'],     singleRun: false,     restartOnFileChange: true   }); };

Karma version (output of karma --version): Command 'karma' not found, however Karma v4.1.0 server is reported by ng.
Relevant part of your karma.config.js file
autoWatch: true,   browsers: ['Chrome'],   singleRun: false,   restartOnFileChange: true

Steps to reproduce the behaviour

Write spec
Run ng test
change spec and save file

Our watcher works so I have no idea why yours does not.

You can try --logLevel=debug to verify that your watcher is loaded.

I've tried this with the freshly generated Angular CLI application and tests are indeed re-run after editing a spec file. Your error is likely a misconfiguration or environment-specific. In either case we can't really do anything to resolve it without being able to reproduce it. Please open a new issue providing a minimal reproduction of this behaviour if you still experience the problem.


casesadd json format regress test for nested types

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run buildall

run p0


can't compile on API 27

wait..

I am getting the same issue too, any help would be highly appreciated.

for the time being i used another  implementation : https://github.com/ww6015132/SilkySignature

Any update on this?

Try with latest version.


[4.0.3] No way to update placeholder when data-placeholder is preset

I can't find a way to update placeholder. I have:

...

I was trying:
$("select[name='paid_by']").select2({ placeholder: "xxxxxxxxxx", allowClear: true }).attr("disabled", false);
$("select[name='paid_by']").attr("data-placeholder","bar").select2({ placeholder: "updated text..." });
It doesn't work when data-placeholder is preset in HTML. But everything is working fine when I remove data-placeholder...

Ok, I've found the solution:
$("select[name='paid_by']").data('placeholder', 'updated text...').select2();
but, there should by any method to change placeholder without reinitialize select2.

Maybe I found a solution (it's not sure at all, so if you can test and told me if it's work):
  // change placeholder in select2
  $el.data('select2').selection.placeholder.text = text;

  // change placeholder in dom
  $el.next("span.select2:first").find("span.select2-selection__placeholder").html(text);

Even if that works, I was expected method or function in plugin 🔢 :)

@avernet I'm not sure if your update addresses this feature request. I'm still not able to dynamically update the placeholder without re-initiating the select element.
@PatrikGuerra's extensions do the trick for now, but it feels hack-y.

@dearsina What update are you referring to, specifically?

@avernet on the thread it says you "mentioned this issue" attached to this thread (that looks like an update): https://github.com/orbeon/orbeon-forms/issues/1433
Apologies if I've misunderstood!

@dearsina Got it, some time has passed, and my memory of this had faded ;). In Orbeon Forms, we're just reinitializing the Select2 when the placeholder changes, and using a MutationObserver to know when that attribute changes. In practice, this happens when users change the current language, and hence the placeholder changes. You can see the code updating the placeholder (initOrUpdatePlaceholder) being hooked to the MutationObserver here. The code is in Scala.js, but I imagine you can get the gist of it. I hope this helps!

Thanks! I was trying to find a way to update my select2 dropdown boxes without having to regenerate/reinitialise them, but it seems like that's the best/only way without resorting to hacking!

Combination of @PatrikGuerra and @alkana approaches works well for me:
$.fn.Select2UpdatePlaceholder = function (newPlaceholder) {
    var $select2 = $(this).data('select2');
    $select2.selection.placeholder.text = newPlaceholder;
    return $select2.$container.find('.select2-selection__placeholder').text(newPlaceholder);
};