Crash when duplicating the last line of a file

@fschwehn thanks for reporting this. I'll have a look to see what is going on!

@fschwehn can't seem to reproduce this right of the bat, tried with a .m and .swift file and both seem to work. Do you have a crash report of a sample file that I could use to narrow it down a bit?

Now I got it: you won't get a crash if the last line you delete is empty (consists of just a newline character).
Crash reports look like so:
`Process:               Xcode [44516]
Path:                  /Applications/Xcode.app/Contents/MacOS/Xcode
Identifier:            com.apple.dt.Xcode
Version:               7.3 (10183.3)
Build Info:            IDEFrameworks-10183003000000000~2
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Xcode [44516]
User ID:               501
PlugIn Path:             /Users/USER/Library/Application Support/Developer/*/MarvinPlugin
PlugIn Identifier:       com.zenangst.MarvinPlugin
PlugIn Version:          2.0.5 (2.0.5)
Date/Time:             2016-05-22 17:19:59.712 +0200
OS Version:            Mac OS X 10.11.5 (15F34)
Report Version:        11
Anonymous UUID:        911CA02B-3E9A-FC6B-7D5F-16828AAF18C2
Sleep/Wake UUID:       778C9A0C-F57E-461B-9D10-DBC8217B785C
Time Awake Since Boot: 160000 seconds
Time Since Wake:       3200 seconds
System Integrity Protection: enabled
Crashed Thread:        0  Dispatch queue: com.apple.main-thread
Exception Type:        EXC_BAD_INSTRUCTION (SIGILL)
Exception Codes:       0x0000000000000001, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY
Application Specific Information:
Sending deleteLineAction to <MarvinPlugin.MarvinPlugin: 0x7fa48740f6e0> from <NSMenuItem: 0x7fa48846d080 Delete Line>
ProductBuildVersion: 7D175
~Üä§
Performing @selector(deleteLineAction) from sender NSMenuItem 0x7fa48846d080
Global Trace Buffer (reverse chronological seconds):
18446744065.293400 CFNetwork                 	0x00007fff888833cb TCP Conn 0x7fa4883d27f0 SSL Handshake DONE
18446744065.944691 CFNetwork                 	0x00007fff888832a7 TCP Conn 0x7fa4883d27f0 starting SSL negotiation
18446744065.944836 CFNetwork                 	0x00007fff88881c71 TCP Conn 0x7fa4883d27f0 complete. fd: 10, err: 0
18446744065.947037 CFNetwork                 	0x00007fff8891054b TCP Conn 0x7fa4883d27f0 event 1. err: 0
18446744066.297173 CFNetwork                 	0x00007fff88880f43 TCP Conn 0x7fa4883d27f0 started
18446744066.344681 CFNetwork                 	0x00007fff88844bc6 Creating default cookie storage with process/bundle identifier
18446744066.344681 CFNetwork                 	0x00007fff88844b5e Faulting in CFHTTPCookieStorage singleton
18446744066.344681 CFNetwork                 	0x00007fff888449ed Faulting in NSHTTPCookieStorage singleton
18446744066.348026 CFNetwork                 	0x00007fff889423a4 NSURLConnection finished with error - code -1100
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.zenangst.MarvinPlugin     	0x000000011cf60797 _TFC12MarvinPlugin12XcodeManager9lineRangefT_VSC8_NSRange + 3063 (XcodeManager.swift:150)
1   com.zenangst.MarvinPlugin     	0x000000011cf65fbe TToFC12MarvinPlugin12MarvinPlugin16deleteLineActionfT_T + 286 (MarvinPlugin.swift:151)
2   libsystem_trace.dylib         	0x00007fff857c907a _os_activity_initiate + 75
3   com.apple.AppKit              	0x00007fff81c93dbd -[NSApplication sendAction:to:from:] + 460
4   com.apple.dt.DVTKit           	0x000000010de9412f __37-[DVTApplication sendAction:to:from:]_block_invoke + 378
5   com.apple.dt.DVTFoundation    	0x000000010d95b0c2 DVTInvokeWithFailureHint + 83
6   com.apple.dt.DVTKit           	0x000000010de93f21 -[DVTApplication sendAction:to:from:] + 335
7   com.apple.AppKit              	0x00007fff81c93b57 -[NSMenuItem _corePerformAction] + 336
8   com.apple.AppKit              	0x00007fff81c938b7 -[NSCarbonMenuImpl performActionWithHighlightingForItemAtIndex:] + 114
9   libsystem_trace.dylib         	0x00007fff857c907a _os_activity_initiate + 75
10  com.apple.AppKit              	0x00007fff81c927a5 -[NSMenu performKeyEquivalent:] + 357
11  com.apple.AppKit              	0x00007fff81c91949 -[NSApplication _handleKeyEquivalent:] + 920
12  com.apple.AppKit              	0x00007fff81bb80fe -[NSApplication sendEvent:] + 4274
13  com.apple.dt.IDEKit           	0x000000010ede57f2 -[IDEApplication sendEvent:] + 894
14  com.apple.AppKit              	0x00007fff81a1edf2 -[NSApplication run] + 796
15  com.apple.AppKit              	0x00007fff819e8368 NSApplicationMain + 1176
16  com.apple.dt.Xcode            	0x000000010d72539b 0x10d724000 + 5019
17  libdyld.dylib                 	0x00007fff93c545ad start + 1`

Thanks mate, I'll have a look ;)

@fschwehn Is it delete or duplicate?

You are right - it is delet not duplicate! Sorry, must have been a long day when I originally reported the issue ;)

No worries mate! Hunting down the bug now! I'll keep you posted!

@fschwehn unable to reproduce this with the files that I'm using now. Could you provide a sample gist that I could use?

Just found out something new. It just happens under the following conditions:

The cursor is within the last line of a file
This line is not empty
The file has unsaved changes

The resaon why it doesn't happen with saved files is that Xcode (at least my setup) adds a line break on save automatically.

https://gist.github.com/fschwehn/493670807b100094759ce068d0af01f2

@fschwehn thanks for all the info you have provided, I was just able to reproduce it! Time to 🐛🔨

@fschwehn could you try and update to 2.0.7 to see if that fixes the issue?

Works like a charm now! Thanks a lot for your quick support!

My pleasure @fschwehn thanks for reporting it and for supplying enough information to be able to debug it properly! Cheers! 🍻


add signaling_client_fetch

add signaling_client_shutdown
can shutdown signaling client after create signaling state machine
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Many thanks for your modification!


Adding credentials file reader support for session token.

It's already supported in awscredentials.py but it just wasn't being parsed from the credentialsreader.

Will the token expire?

Tokens will always expire. This is to support the use case where  you have another process generating the credentials file entry and want the plugin to consume those credentials. This was required for us because we were using an instance profile that was doing a cross account assume role.


Update Format for s3.ts

Abstract
Format the s3.ts example that follows the pattern of other example
Reason
Follow the convention of other examples

Hi @CHAOWEICHIU this actually is the new pattern for examples, we've done away with the requirement to have a run function surrounding the code.


how to prepare the input for the initial run

Hi, this is not an issue but a usage problem. I created a simple example which expects the input from stdin. But I don't know how to prepare the input file for the testing because the document about this part is not very clear. I tried to follow the examples shown in the examples folder. The testing goes forever and it seems no coverage is reported.
The cmd I used:
honggfuzz -f input --linux_perf_ipt_block -x -s -- ./multithread FILE
I need some help on how to prepare the form of the initial input. Thanks.

Please re-open if you have any more questions about PT


I created a new library, much more optimized than this.

I created a new library, much more optimized than this.
Originally posted by @kreshnikalidema in https://github.com/venits/react-native-map-clustering/issues/223#issuecomment-973108883
can you share it with us please?

Check out the clustering library that I created: react-native-clusterer.

thanks @JiriHoffmann
I will try it

Can't you just use expo run:ios to create native directories? You should be able to run pod install after. I do remember testing it on an expo managed project.

@JiriHoffmann You're right in bare workflow this is going to work.
Also I want to attract your attention that it could be nice to add : https://docs.expo.dev/guides/config-plugins/
With the new preview feature of expo development build, this is going to rock in the future.
Expo is getting detached to the need to use Expo-go all time and simplify any lib installation

For users coming across this issue, I just want to clarify that it does work with Expo's managed workflow without config plugins or anything. (@ScreamZ )
Just install react-native-clusterer with npm/yarn/pnpm, make a new development build/release build and use it. The iOS pods are automatically installed at build time.


Correcting spelling error in README

This was a minor error I spotted in the README while reviewing the documentation, but I figured it was worth correcting.

@AramZS thank you, I will merge it now.


Fix comple error with opencv 3.0 on Nvidia Jetson

This re-creates a fix for a bug reported here: https://github.com/CVVisualPSETeam/CVVisual/issues/46.
The original fix is show here: https://github.com/CVVisualPSETeam/CVVisual/commit/f7b1c68cb693167c6fd8656e91fab3d1da07d1bb
This fix applies the replacement of 10,50lu with std::size_t{10},  std::size_t{50} in the three files.

Please fix commits hell: 1 commit is enough for this patch.
Please use more traditional format for type casts without curly brackets: (std::size_t)50
Remove unnecessary +.


clustermesh-apiserver: write synced information into etcd

This PR includes the glue logic to introduce the support of per-prefix "synced" canaries in the clustermesh-apiserver. This enables remote watchers understand that the initial synchronization has completed, and it is possible to retrieve an up-to-date state.
Related: https://github.com/cilium/cilium/pull/25388

clustermesh-apiserver: expose information about completion of initial synchronization through etcd

Conformance ClusterMesh hit known flake https://github.com/cilium/cilium/issues/25816. Rerunning manually.

/ci-gke


Rename ADDUW, SUBUW, SLLIUW

The new "prefix zero-extend" instructions currently have names that don't follow the existing convention for *W instructions.  In particular, these new instructions do not act at all like instructions DIVUW and REMUW, which perform their operation on two unsigned 32-bit values and then sign-extend the 32-bit result.
To avoid confusion, the new instructions need different names.  I propose
ADDZX
SUBZX
SLLZXI

where "ZX" stands for "zero-extend".  For example, instruction
SLLZXI rd,rs1,i

acts the same as the sequence
ZEXT.W rd,rs1
SLLI rd,rd,i

ADDZX doesn't convey that it's a 32-bit add which is zero-extended.  This could cause confusion on RV128 where there would presumably be a 32-bit zero-extended add and a 64-bit zero-extended add (much like there are ADDW and ADDD for sign-extended adds).  How about ADDWZX, SUBWZX, SLLWZXI which allows for ADDDZX, SUBDZX, SLLDZXI on RV128?

How about ADDWZX, SUBWZX, SLLWZXI

Okay by me.  (In some respects it's imperfect, but I can't think of a better arrangement.)

The original name would have been ADDWU_RS2, so ADDUW is already is an improvement.  ;)

ADDZX

As @pdonahue-ventana pointed out, we need the W/D in there so that it's clear is if't zero-extending a 32-bit or 64-bit input.

have names that don't follow the existing convention for *W instructions

Since they do not have the semantic of *W instructions I don't understand in what way that would matter.

ADDWZX, SUBWZX

I think there should be a consistent naming scheme for what's currently called *WU and *UW instructions. I'm fine with renaming it *ZX or whatever, but only as part of a proposal that also renames the *WU instructions.
The name should include the following information:

The size of the word we are zero-extending (W/D)
If the zero-extension happens post- or prefix (rs1 for SLLIUW, rs2 for ADDUW/SUBUW)

SLLWZXI

If at all then SLLIWZX.

For the *WU names, I would say there is existing precedent in the load instructions:  LWU acts the same as LW, except for zero-extending the 32-bit result, and likewise, LHU and LBU act the same as LH and LB except for zero-extending the result for halfword and byte sizes.  For this reason, I find it consistent and unsurprising that ADDWU would act the same as ADDW except for zero-extending the word-size result.
Yes, it would be nice if we could have a complete naming system that would encode all the variances we want in a logical and succinct way, but I don't think that's going to be possible.  The best we can do, I think, is to try to avoid unnecessary inconsistencies that increase the mental burden for programmers.  I accept that that inevitably depends on individual judgement and taste.
In my judgement, the *WU system is already established and works fine for the proposed "postfix zero-extend" instructions.  If we agree that the "prefix zero-extend" instructions can't simply use *UW because of DIVUW and REMUW (if for no other reason), then something new must be invented for them.  I'm okay with either *WZX or *ZXW as a suffix, so ADDWZX or ADDZXW, etc.  Of course, it isn't entirely self-explanatory, but that goal seems out of reach to me.  It's sufficient that the "ZX" is distinctive, isn't likely to be subject to name clashes, is reasonably logical as an abbreviation of ZEXT, and is easy to remember once learned.
Clifford wrote:

SLLWZXI

If at all then SLLIWZX.

Okay then.

If we agree that the "prefix zero-extend" instructions can't simply use *UW because of DIVUW and REMUW (if for no other reason), then something new must be invented for them.

But DIVUW and REMUW are not DIV/REM with an added UW. They are DIVU/REMU with an added W, and of course DIVU/REMU are DIV/REM with an added U.
There is no and never will be ADDU or SLLU instructions, because they would just be equivalent to ADD and SLL. So there is no possible confusion if for example ADDUW is the -W version of ADDU or the -UW version of ADD. Thus I do not agree with the statement that "something new must be invented for them".
Maybe you'd prefer a different scheme. And that's perfectly valid. But there surely is no imperative to use a different scheme. It's just a matter of taste. We clearly do have a choice here.

Of course, it isn't entirely self-explanatory, but that goal seems out of reach to me.

I think "not entirely self-explanatory" is an understatement. Imo it's not a bit self explanatory. In what way is *WZX for prefix and *WU for postfix self explanatory?
I think the *UW vs *WU proposal demonstrates very well that we can at least do much better than *WZX and *WU in terms of how self-explanatory the instructions are.

So there is no possible confusion if for example ADDUW is the -W version of ADDU or the -UW version of ADD.

We're just going to have to disagree about that.  As far as the tools and hardware are concerned, it's fine for the relationship between ADD and ADDUW to be entirely different from the relationship between DIV and DIVUW.  The computer won't care.  But it's an unwise surprise to pull on programmers.

I think the *UW vs *WU proposal demonstrates very well that we can at least do much better than *WZX and *WU in terms of how self-explanatory the instructions are.

Since *UW doesn't cut it as self-explanatory (not if it means one thing for ADD and a different thing for DIV), I look forward to seeing your own proposal for the names.

I think the *UW vs *WU proposal [..]

Since *UW doesn't cut it as self-explanatory [..]

JFYI, while I'm trying as good as I can to stick to phrases like "I think" when describing my subjective preference you are now repeatedly presenting your subjective preference and/or personal conclusion as if it were an objective and undisputed truth. It's borderlining to begging the question. This makes it increasingly harder for me to take your position seriously, and I will undoubtedly have troubles to trust any future factual statements you make since I will have to assume that you are just presenting your feelings as if they where undisputed fact again.
As a rhetoric tactic this accomplishes the exact opposite of what you are seemingly trying to accomplish, at least when directed at me.

I look forward to seeing your own proposal for the names.

The only possible sensible definition for an ADDU instruction that isn't equivalent to ADD would require one or both source operands to be smaller than the result. And that's exactly what ADDUW is.
Therefore I see no problem with the U suffix here, and we need a size following it. Arguably there is some room for confusion regarding the final W. But that's easy enough to fix. Lets just call it ADDU.W then.
(If you are categorically opposed to using U here then there are 25 other letters in the alphabet that aren't U. However, I strongly feel that U makes most sense.)

I wrote:

Since *UW doesn't cut it as self-explanatory [..]

Clifford:

JFYI, while I'm trying as good as I can to stick to phrases like "I think" when describing my subjective preference you are now repeatedly presenting your subjective preference and/or personal conclusion as if it were an objective and undisputed truth.

Surely something can't be self-explanatory if it requires additional outside explanation.  If the *UW suffix means one thing for ADD and a different thing for DIV, but the difference is very logical as made clear by the documentation, then it isn't self-explanatory by definition of the term.  Yes, I'm going to state that as an undisputed truth.  I honestly believe that it is.
To be clear, I've never claimed we can have a totally self-explanatory naming system for the instructions.

I didn't think about DIVUW when the *UW suffix was proposed.  There's an obvious and avoidable potential for confusion here.  Programmers who aren't following this discussion will understandably assume DIVUW and ADDUW are analogously defined (even though we know that doesn't make much sense, since "add unsigned then sign-extend" is exactly the same thing that the existing ADDW instruction does).
I think something like ADDZW is preferable to something like ADDU.W (with the period inserted to distinguish it from DIVUW), but I also think ADDU.W is a workable compromise.

Andrew wrote:

I think something like ADDZW is preferable to something like ADDU.W

So you prefer ADDZW instead of ADDZXW?  Or was that just a typing error?

Not sure if it was a typo or if I misread something in this thread. I think ADDZXW is the better name because it’s a bit more explicit about what the Z means.

I think something like ADDZW is preferable to something like ADDU.W (with the period inserted to distinguish it from DIVUW), but I also think ADDU.W is a workable compromise.

I didn't "insert a period to distinguish a it from DIVUW". I suggested ADDU.W because it makes sense.
I pointed out that ADDU describes the instruction semantic well, but that the final W is more like a size modifier, as in LR.W and CRC23C.W and FEQ.D. Should those instructions be named LRW and CRC23CW and FEQD instead as well?
If you really prefer ADDZXW over ADDU.W then you should probably also give a reason why you think this way. Otherwise there's no argument whatsoever here.

If the *UW suffix means one thing for ADD and a different thing for DIV

Similarly ADDZW or ADDZXW could be misunderstood as *W version of some weird ADDZ or ADDZX instruction. Even if we didn't know what ADDZ or ADDZX does, we'd expect the result of the instruction to be a 32-bit value sign-extended to XLEN.
But that's not a property that this instruction has! I don't understand why you think one case is confusing and the other isn't! It just doesn't make any sense. If you reject one on the basis of the observation that it breaks an establish pattern then you have to reject the other on the same grounds.
If ADDZXW is acceptable then so must be ADDUW. If you reject ADDUW with the reasons you gave then you also must reject ADDZXW for the same reasons.
ADDU.W would be completely consistent with all established patterns afaict.

ADDU.W would be completely consistent with all established patterns afaict.

Looking at the existing instructions (including, for example, FCVT.S.WU), seems to me it should be ADD.WU.

Similarly ADDZW or ADDZXW could be misunderstood as *W version of some weird ADDZ or ADDZX instruction.

Of course.  But we also know it would send someone to the documentation to look up ADDZ or ADDZX, which would then protect them from misunderstanding.  Adopting a *ZXW suffix (along witih *ZXD) would block any future *ZX instructions, to avoid exactly the problem you mention.  But that seems like a small sacrifice to me.
The concern I have with ADD.WU is that it's visually so close to ADDWU, a shortcoming definitely not suffered by ADDZXW.  But if ADD.WU is really what people want, I believe it technically answers the problem raised by this issue.

Similarly ADDZW or ADDZXW could be misunderstood as *W version of some weird ADDZ or ADDZX instruction.

Of course. But we also know it would send someone to the documentation to look up ADDZ or ADDZX, which would then protect them from misunderstanding.

That's not a proper argument for anything. You could say the exact same thing about any other proposal. It's confusing? No problem. It will just send the user to the documentation.

seems to me it should be ADD.WU. [..]
The concern I have with ADD.WU is that it's visually so close to ADDWU

So you are saying it can't be ADDU.W because it has to be ADD.WU but then it can't be ADDWU?

But if ADD.WU is really what people want

Nobody wants ADD.WU. THIS IS THE STRAWMAN YOU JUST CREATED.
AAARGH! This is so frustrating.
I'm now closing this issue. I'm so done debating informal fallacies.
If you have a proper argument I'll listen to it. But I don't have any nerves for a continuation of this BS.

Clifford wrote:

So you are saying it can't be ADDU.W because it has to be ADD.WU but then it can't be ADDWU?

I'm saying it can't be ADDWU, and ideally it shouldn't be ADDU.W.
For now, the names are as you made them, SLLIU.W, ADDU.W, and SUBU.W, and I assume they will stay that way unless they attract other comments.


Use fabric's event system for firing our events

Using fabric's event handler registry might be faster than our current approach, especially with events that are possibly fired every frame.
https://github.com/NerdHubMC/TextileLib/tree/fabric-event-system is hte branch for testing that.
see https://github.com/FabricMC/fabric/blob/master/src/main/java/net/fabricmc/fabric/api/event/EventFactory.java for reference on their event system.

closed by #22


Update Hud documentation

Description
Small error in the Hud documentation

Updated here: https://github.com/raycast/extensions/commit/b3e8e5f78bca5b65bce3f3b5575fab983f5b1a6b
Thanks for flagging 🔥


Modify table fields with data in it

Is there a plan to be able to change the structure of a table on an eosio smart contract with existing data in it? This is a huge issue for systems in production.

Writing migration scripts every time is not a solution. It creates a bottleneck and is manual every time. It also creates a downtime.
Creating other joint table is not a solution, slows down the queries for clients
JSON fields are not a solution, its slowing down and takes more memory. makes it hard to filter too.
Adding extra fields just in case is also not a solution, its circumventing the source problem and you eventually run out of these fields.

Software always change with time. Business requirements are evolving.

This maybe a possible design that supports extension in the future:
// vesion 1:
struct futuredata { char _unused; };
struct [[eosio::table]] userdata {
  uint64_t userid; // primary key
  string string_data;
  std::optional<futuredata> data_for_future;
};

keep in mind that data_for_future must be empty in version 1.
// vesion 2 (add new field "float_data" in the future):
struct futuredata {
  double float_data;
};
struct [[eosio::table]] userdata {
  uint64_t userid; // primary key
  string string_data;
  std::optional<futuredata> data_for_future;
};

in this case old data will still be serialized correctly, but you can put new data in data_for_future for new userid.

@taokayan can you safely upgrade version 2 to a struct with new field for version 3?
what if in version 3, you have:
struct futuredata {
double float_data;
double float_data2;
double float_data3;
};

@raphaelgodro why is JSON field not a solution? what is wrong with
struct [[eosio::table]] userdata {
  uint64_t userid; // primary key
  std::map<std::string, std::string> data;
};

Found this good resource: https://eosio.github.io/eosio.cdt/latest/best-practices/data-design-and-migration

@taokayan can you safely upgrade version 2 to a struct with new field for version 3?
what if in version 3, you have:
struct futuredata {
  double float_data;
  double float_data2;
  double float_data3;
};

No, you probably need to have another optional for future's future.
struct futuredata {
  double float_data;
  std::optional<int>  reserved_for_another_future;
};


⚠ Samsung has degraded performance

In ead432b, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2101 ms

Resolved: Samsung performance has improved in a149b66.


test model submission that does not sum to 1

This can be completed by submitting a file that is fully correct but has at least one value that makes a sum of clade proportions to not 1.

For reference, here's what an example output of this error may look like. In this case, many proportions do not sum to 1, see [value_col_valid] below:
hubValidations::validate_model_data(hub_path = ".",
+                                     file_path = "2024-10-02-umass-badtestsubmission.parquet")

── 2024-10-02-umass-badtestsubmission.parquet ────

✔ [file_read]: File could be read successfully.
✔ [valid_round_id_col]: `round_id_col` name is valid.
✔ [unique_round_id]: `round_id` column "nowcast_date" contains a single, unique round ID value.
✔ [match_round_id]: All `round_id_col` "nowcast_date" values match submission `round_id` from file
  name.
✔ [colnames]: Column names are consistent with expected round task IDs and std column names.
✔ [col_types]: Column data types match hub schema.
✔ [valid_vals]: `tbl` contains valid values/value combinations.
✔ [rows_unique]: All combinations of task ID column/`output_type`/`output_type_id` values are
  unique.
✔ [req_vals]: Required task ID/output type/output type ID combinations all present.
✖ [value_col_valid]: Values in column `value` are not all valid with respect to modeling task
  config.  Values 1.64082051954864, 1.39419327558475, 1.7781695793825, 1.56652143950033,
  1.11891236899438, 2.35824530656231, 1.77210188717548, 1.02784946334966, 1.92670602467648,
  1.4257758888811, 2.32423973426083, 1.24590460946878, 1.21852336365822, 2.14001639972308,
  1.0208080346671, 1.11427194788356, 1.08532523128854, 1.16144359215991, …, 1.27441130988298, and
  1.36619765625589 are greater than allowed maximum value 1 for output type "sample".
ℹ [value_col_non_desc]: No quantile or cdf output types to check for non-descending values. Check
  skipped.
ℹ [value_col_sum1]: No pmf output types to check for sum of 1. Check skipped.
✔ [spl_compound_taskid_set]: All samples in a model task conform to single, unique compound task ID
  set that matches or is coarser than the configured `compound_taksid_set`.
✔ [spl_compound_tid]: Each sample compound task ID contains single, unique value.
✔ [spl_non_compound_tid]: Task ID combinations of non compound task id values consistent across
  modeling task samples.
✔ [spl_n]: Required samples per compound idx task present.

I ran this locally but would like to make a more complete solution soon.

closed by appropriately failing PR in #97


Compatibility Python3

Hi,
we could use your tutorial to create python 2.7 bindings, but it is quite harder to use python3 libs. StringsIO has changed, and strings are automatically formatted to unicode now, which is a problem. Is there any solution for this yet?

I don't need to create any ROS binding for Python right now so I'd welcome any help to port the tutorial to Python3.
I don't understand what is difficult with StringIO, it's just at a different place. Can you give some details about the issue with unicode strings in Python3?

Change _add_two_ints_wrapper_py.py as follows
from io import BytesIO

import rospy
from std_msgs.msg import Int64

from python_bindings_tutorial._add_two_ints_wrapper_cpp import AddTwoIntsWrapper

class AddTwoInts(object):
    def __init__(self):
        self._add_two_ints = AddTwoIntsWrapper()

    def _to_cpp(self, msg: Int64):
        """Return a serialized string from a ROS message

        Parameters
        ----------
        - msg: a ROS message instance.
        """
        buf = BytesIO()
        msg.serialize(buf)
        return buf.getvalue()

    def _from_cpp(self, str_msg, cls):
        """Return a ROS message from a serialized string

        Parameters
        ----------
        - str_msg: str, serialized message
        - cls: ROS message class, e.g. sensor_msgs.msg.LaserScan.
        """
        msg = cls()
        return msg.deserialize(str_msg)

    def add(self, a, b):
        """Add two std_mgs/Int64 messages

        Return a std_msgs/Int64 instance.

        Parameters
        ----------
        - a: a std_msgs/Int64 instance.
        - b: a std_msgs/Int64 instance.
        """
        if not isinstance(a, Int64):
            rospy.ROSException('Argument 1 is not a std_msgs/Int64')
        if not isinstance(b, Int64):
            rospy.ROSException('Argument 2 is not a std_msgs/Int64')
        str_a = self._to_cpp(a)
        str_b = self._to_cpp(b)
        str_sum = self._add_two_ints.add(str_a, str_b)
        # encode the string into bytes
        str_sum = str_sum.encode('utf-8')
        return self._from_cpp(str_sum, Int64)

@YinpeiDai is your change compatible with Python2, so that I wouldn't need to create a Python3 branch?

@galou
Hi, I think you need to create a Python3 branch, because there are some differences between Python2 and Python3 when using boost bind.
I am not familiar with serialization and BytesIO and StringIO in python. I followed the tutorial on Ubuntu20.04 ROS noetic with Python 3.8. I got a error in Python:

And fortunately I see the upper comment, it seems like I should use ByteIO instead of StringIO in Python3


EpicEditor not working

EpicEditor isn't working for me.
I also tried changing the change_form.html template to:
{% extends "admin/cms/page/plugin/change_form.html" %}

{% block after_field_sets %}

{% endblock %}

{% block extrastyle %}
{{ block.super }}
<link rel="stylesheet" type="text/css" href="{{ STATIC_URL }}cmsplugin_markdown/themes/base/epiceditor.css" />
{% endblock %}

{% block admin_change_form_document_ready %}
{{ block.super }}

{% endblock %}

which at least made the EpicEditor load, but it doesn't show up. Any ideas?
I am using Django 1.8 and DjangoCMS 3.2.

Unfortunately we're not using this app at the moment and I don't have the time to create an update. We need to debug the JS code and actually I don't know, if this epic editor version is working at all.

I see. I might be able to contribute when I have more time. Or I can fork this, if you won’t have time to maintain it anymore?

On 03 Mar 2016, at 20:44, Tobias Lorenz<EMAIL_ADDRESS>wrote:
Unfortunately we're not using this app at the moment and I don't have the time to create an update. We need to debug the JS code and actually I don't know, if this epic editor version is working at all.
—
Reply to this email directly or view it on GitHub https://github.com/bitmazk/cmsplugin-markdown/issues/9#issuecomment-191931307.

Sure!

@zanderle if you send a pull request, we will test it quickly and merge it, usually within a few days. If we don't know how to test it, we will ask you ;)

i google chrome
(index):33 Uncaught TypeError: $ is not a function
i'm looking forward to fix. :) thank you!!

This fork fixes this issue: https://github.com/niconoe/djangocms-markdown

@Flimm this is not a fork of this app.

@Tyrdall Actually it is. https://github.com/niconoe/djangocms-markdown is a fork of https://github.com/ovidner/djangocms-markdown , which is a fork of https://github.com/ovidner/djangocms-markdown , which is a fork of https://github.com/USGM/cmsplugin-markdown , which is a fork of https://github.com/bitmazk/cmsplugin-markdown .

@Flimm Hahaha, alright. Never seen something like that before :)

Should be fixed now.


Suggest using Control.Monad.State.gets when possible

See https://github.com/jgm/pandoc/commit/39a8359b571ba0aa1e193b0ff9ef6252acc7a754

Thanks, seems like a good idea - provided we don't clash with get due to Binary too much.

Would these rules be added to data/default.yaml, or is that for base only?

See #14 for a discussion about how to do linters for libraries. Basic answer is that I have little to no idea how to do it - putting it into data/default.yaml is probably the pragmatic short-term solution and then worry about it if it gets too big.

We have state monad hints now.


⚠ GitHub has degraded performance

In 18b9b61, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 290 ms

Resolved: GitHub performance has improved in 4c6ad12.


deno version badge

It would be nice to have a deno version badge, maybe something similar to node version badge

or the deno logo instead of text?

I actually fiddled around a bit and found this solution.

I actually fiddled around a bit and found this solution.


Turn PropertyAccessor into a generic component

Make PropertyAccessor reusable for other projects.
turn it into its own package.

We need to split wrapping a property and handling gets and sets into two different things, making the wrapper reuseable.

The PropertyAccessor is already extracted into its own file. We stil ned tok introduce a proper package, which is to be done in #7.


Update tutorial-firewall-deploy-portal.md

Minor spelling mistakes.

@llstrk : Thanks for your contribution! The author, @vhorne, has been notified to review your proposed change.

#sign-off

@GitHubber17 : Thanks for your contribution! The author, @vhorne, has been notified to review your proposed change.


Chart title doesn't display

I copied and pasted example pie chart code from:
https://tobiasahlin.com/blog/chartjs-charts-to-get-you-started/#pie-chart-html--javascript
The title "Predicted world population (millions) in 2050" is missing.
https://codepen.io/blacksqr/pen/PopVmVZ
I also copied and pasted example bar chart code from:
https://tobiasahlin.com/blog/chartjs-charts-to-get-you-started/#bar-chart-html--javascript
The title is also missing here and in its place is the dataset title "Population (millions)" along with an inexplicable and unhelpful blue rectangle.
https://codepen.io/blacksqr/pen/LYWqLVw
I'm new to chart.js and trying to learn it, but I've been unable to find any errors in the example code.

Example code was outdated, sorry.

Why don't you take a look at the official samples that are up to date. Those you linked are for chart.js v2


ISPN-1826 Make sure address cache is updated before comparing view ids

https://issues.jboss.org/browse/ISPN-1826
This avoids a race condition where a view id might be updated before the address cache, so clients could end up receiving views that do not contain the address updates.

@danberindei I've updated the pull request, can you check?


[iOS] Chinese and English can not be centered?

Why chinese and english can not be centered. Here is an example:
elements:
          <View style={styles.header_info_sub}>
                  <Text style={styles.header_info_sub_time}>刚刚</Text>
                  <Text style={styles.header_info_sub_from}>来自 aaa.com</Text>
          </View>

styles:
  header_info_sub: {
    flex: 0,
    flexDirection: 'row',
    alignItems: 'center',
  },
  header_info_sub_time: {
    fontSize: 12.0,
    color: 'orange',
  },
  header_info_sub_from: {
    fontSize: 12.0,
    marginLeft: 4.0,
    color: 'gray',
  },

effect:

I must add paddingBottom: 1,  to header_info_sub_from style to fix it. Why it can not be centered automatically?

If you want "来自" and "aaa.com" vertical aligned center, you should separate it into two <Text> component and use alignItems:center on parent component.

@yueshuaijie What? I have done like this.
header_info_sub: {
    flex: 0,
    flexDirection: 'row',
    alignItems: 'center',
  },

@eggswift
Sorry, it seems I misunderstand. I thought you want make "来自" and "aaa.com" vertical center aligned. In fact you mean making "刚刚" and "来自 aaa.com" vertical center aligned :)

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/ios-chinese-and-english-can-not-be-centered
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.

that is the because of the font
use the default system font, Chinese character and English character even the Number are not in same alignment
so when they in same line and same  components, the render result will not be centered!
You should found the FONT that the two kind of character render the same alignment


Add script to run a ci job

Add a script that will be triggered on github pull request,
for now just calls make but will be expanded in the future.
Not sure if this is a good idea but would like to give it a go, I got a baremetal host that I intend to reset back to a fresh centos between jobs.

Can one of the admins verify this patch?

lgtm, just a couple of suggestions inline - generally have an uneasy sense that it's only a matter of time before some accidental printing of the secret gets reintroduced, though

This looks OK to me.
I wonder what the OCP team does about dumping the config file without exposing the pull secret in their CI jobs.

lgtm, just a couple of suggestions inline - generally have an uneasy sense that it's only a matter of time before some accidental printing of the secret gets reintroduced, though

thanks, did you forget to submit the inline comments?
ya, agreed, it would only be a matter of time, I was thinking instead I could scp the artefacts somewhere and globally delete any occurrences from the directory before making it available of http but then its only a matter of time before somebody zipped something and that would fail.

lgtm

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/106/

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/115/

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/121/

Build ABORTED, see build http://<IP_ADDRESS>:8080/job/dev-tools/123/

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/124/

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/126/

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/127/

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/128/

Build FAILURE, see build http://<IP_ADDRESS>:8080/job/dev-tools/129/

Build SUCCESS, see build http://<IP_ADDRESS>:8080/job/dev-tools/130/


Malformed item damage parts brick Actions tab

Foundry v9.269; dnd5e v1.6.1; Character Actions List 5.0.1
As per title. Repro:
(async () => {
	const act = await Actor.create({type: "character", name: "Repro"});

	await act.createEmbeddedDocuments(
		"Item",
		[
			{
				name: "Repro",
				type: "weapon",
				data: {
					"damage.parts": [["1d@(lol)", ""]],
				},
				flags: {
					"character-actions-list-5e": {
						"filter-override": true,
					},
				},
			},
		],
	);

	act.sheet.render(true);
})();

Fixed in 5.0.2, good find!


Bump CSA versions on 7.2.14 and 7.2.15

@ferenc-csaky Is it intentional not to have a tracking Jira ticket for this? (It is missing from both commit title & PR title.)

Great point, I updated the PR. If it LG, can someone merge it pls, I don't have permission. Thanks!

missing jira ticket

done

missing jira ticket

done

to the commit message please. thats what matters when we check git history. thanks


Prerendering fails when defineI18nRoute is set for nested pages

Environment

Operating System: Linux
Node Version:     v16.20.0
Nuxt Version:     3.7.0
CLI Version:      3.7.2
Nitro Version:    2.6.2
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      modules, i18n
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

[Edit: edited to match the Stackblitz environment instead of my project]
Reproduction
https://stackblitz.com/edit/github-at1ynv?file=pages%2Fmother%2Fdaughter.vue
Describe the bug
In nested pages with locale-specific paths defined in defineI18nRoute, like this:
defineI18nRoute({
  paths: {
    fr: '/mere/fille',
  },
});

the prerendering fails when doing npm run generate
ℹ Prerendering 10 initial routes with crawler                                                                          nitro 08:47:08
  ├─ /200.html (97ms)                                                                                nitro 08:47:08
  ├─ /404.html (97ms)                                                                                nitro 08:47:08
  ├─ /fr/mere (155ms)                                                                                nitro 08:47:08
  ├─ /mother (154ms)                                                                                nitro 08:47:08
  ├─ /fr (155ms)                                                                                nitro 08:47:08
  ├─ / (155ms)                                                                                nitro 08:47:08
  ├─ /mother/daughter (154ms)                                                                                nitro 08:47:08
  ├─ /mother/son (154ms)                                                                                nitro 08:47:08
  ├─ /fr/_payload.json (8ms)                                                                                nitro 08:47:08
  ├─ /_payload.json (8ms)                                                                                nitro 08:47:08
  ├─ /mother/daughter/_payload.json (7ms)                                                                              nitro 08:47:08
  ├─ /mother/son/_payload.json (7ms)                                                                                nitro 08:47:08
  ├─ /fr/mere/fille (7ms)                                                                                nitro 08:47:08
  ├─ /fr/mere/fils (7ms)                                                                                nitro 08:47:08
  ├─ /fr/mere/fr/mere/fille (183ms)                                                                                nitro 08:47:08
  │ └── Error: [404] Page not found: /fr/mere/fr/mere/fille
  ├─ /fr/mere/fr/mere/fils (183ms)                                                                                nitro 08:47:08
  │ └── Error: [404] Page not found: /fr/mere/fr/mere/fils
  ├─ /fr/mere/fille/_payload.json (1ms)                                                                                nitro 08:47:08
  ├─ /fr/mere/fils/_payload.json (1ms)                                                                                nitro 08:47:08
                                                                                nitro 08:47:08
Errors prerendering:
  ├─ /fr/mere/fr/mere/fille (183ms)                                                                                nitro 08:47:08
  │ └── Error: [404] Page not found: /fr/mere/fr/mere/fille
  ├─ /fr/mere/fr/mere/fils (183ms)                                                                                nitro 08:47:08
  │ └── Error: [404] Page not found: /fr/mere/fr/mere/fils
                                                                                nitro 08:47:08

 ERROR  Exiting due to prerender errors.

We clearly see the bug, where /fr/mere is duplicated while it shouldn't. The children routes /fr/mere/fille and /fr/mere/fils are properly generated, so the failing route prerenders are additional and should rather not happen at all.
Additional context
No response
Logs
No response

What causes the issue, is there any workaround? Two months ago with 8.0.0-beta.13 I did not have the issue, now I face it with beta.13 and 8.0.0-rc.4, too. Same with nuxt versions 3.6.2 and 3.7.1.
I tried to define the phantom paths in defineI18nRoute.paths but the same errors come.

I have just noticed that the error I have is slightly different, I defined all the paths in defineNuxtConfig.i18n.pages (so not in page's defineI18nRoute). What do you think shall I make another bug about it or are these really the same?

Workaround, in nuxt.config.ts:
export default defineNuxtConfig({
...
    nitro: {
        prerender: {
            ignore: ['/fr/mere/fr']
        }
    },
})

I have a simliar error here but with prettier:
[vue/compiler-sfc] Unexpected token (13:10)
talking about the single-quote, but I have this option defined as ok in prettier, so I don't know what may be wrong
{
"tabWidth": 2,
"semi": false,
"singleQuote": true
}

@davidsandoz
Sorry for the confusion 😅, #2625 was only preparation to fix this issue. I did try fixing this last month and made progress but it broke other project configurations, hopefully I have some time this month to pick it up again.


Produce at most N threshold reached messages when {Threshold} * N messages are received

This introduces a change in behavior in commit 5802dd47c2e6b738fd1e575352e3531e93eac3b2.
Previous behavior: "Reset on threshold reached"=false:
When threshold is reached, all messages exceeding the threshold will log a threshold reached message until the count is reduced by the passing of time.  Given a constant stream of log messages at a high enough rate, every message will produce a threshold reached message.
New behavior: "Reset on threshold reached"=true:
When threshold is reached, after a threshold reach message is logged, the counters will be reset.  Threshold must be reached again before another threshold reached message is logged. Given a threshold of N, a threshold reached message will be logged at most every N messages.
Other changes:

Added tests around ThresholdReactor to document its behavior in 48594ee9c3f4d0b1b4b73852a7ab852fcb2fa459 and 69a13dbdf76c9838f4e6f1d5aec86cd60319e0f7
Reduced some duplication in ThresholdReactor in 09c91c5e360104b27a509d840aa462203c7a63eb

Hi Ben, thanks for the PR! The refactor looks great.
Is the scenario you're addressing here covered by the SuppressionTimeSeconds setting? If set, additional "threshold reached" messages shouldn't be raised until the specified number of seconds elapses.

I have below a couple of the requirements for notifications I am looking at implementing.  For the first, suppression works great.  For the second requirement, I cannot devise a good way for the Threshold App to meet the requirement in its current state.
Req 1
When {criteria} occurs. Alert at most once per {number} minutes.
Suppression time works great for this one.  The plan is to

Create a signal with the specified criteria
feeding an app instance of Threshold Detection

with detection window of 2,
threshold of 1,
threshold name of {threshold},
and suppression time of {number}.

Create a signal to capture events tagged with {threshold}.

Req 2
When {criteria} occurs {number occurrences} within {number minutes} minutes.
I've mapped this to Seq constructs as:

Create a signal with the specified criteria
feeding an app instance of Threshold Detection

with detection window of {number minutes},
threshold of {number occurrences},
and threshold name of {threshold}.

Create a signal to capture events tagged with {threshold}.

Example Case 1

When {criteria} occurs {number occurrences} within {number minutes} minutes.
Receiving 1 matching logs per minute.
Threshold set to 20.
Sliding windows set to 60 minutes.
I  would expect in this case to receive 2 or 3 notifications in an hour.  With the previous Threshold behavior, without suppression, after the initial 20 matching logs, I would receive a steady stream of 1 per minute threshold notifications.

For this specific case, as a workaround, I could set a suppression time of 20 seconds.  But this would be problematic if the log velocity increased.
Example Case 2

When {criteria} occurs {number occurrences} within {number minutes} minutes.
Receiving 4 matching logs per minute.
Threshold set to 20.
Sliding windows set to 60 minutes.
Suppression time of 20 seconds.
I would expect to receive ~15 notifications based on the requirement 2.  Instead I will receive 2 or 3.

Followup Question
Is it possible that anyone would consider the previous behavior (notifying for every message after the threshold is reached) desirable?

Thanks for the detailed reply Ben. I think your change is probably broadly desirable. The existing behaviour might possibly work well for long-window/short-threshold configurations, I have no idea if anyone relies on it though.
What do you think about a checkbox "Reset on threshold reached?" - defaulting to false would preserve the current behaviour, selecting it would behave as in this PR?
Regards,
Nick

I'm fine with having an option if that's what we need to do.  I am unable to think of a useful business case for the previous behavior, so I'll leave that decision up to you.

Hi Ben - I am not certain how much it is used, but I think the long-window scenario is still relevant (think of the additional messages, after the suppression time, as indicating "hey, this condition is still occurring!"). Resetting in these cases would delay feedback on whether a threshold was still exceeded.
If the checkbox approach works for you I think it's a good option here, at least to stay on the safe side.

Hi Nick,
I was looking at adding the "Reset on threshold reached" option to Seq.App.Thresholds, but I noticed some of my tests are occasionally failing.  An out of range exception occurs when the eventSeconds  in TrySlideWindow() in ThresholdReactor is 1 second before the _currentBucketSecond in ThresholdReactor.  Is this something that could occur in normal operation or do I just need to adjust my test?
I see that  currentBucketSecond is set in the OnAttached() of ThresholdReactor, but I am unsure of where the TimestampUtc of the Seq.Apps.Event originates.
Thanks.

I updated the test in this pull request to not have the error condition.  If event time can be before the app attached time, possibly in the case of running for older events, then this other branch still has the error condition and a possible workaround:
https://github.com/continuousit/seq-apps/compare/master...bbrandt:event-time-before-bucket-seconds?expand=1

Hi Ben, thanks for the information regarding the error condition, this is very interesting. It's been a while since I dug deeply into this part of the code - investigating now :+1:

Thanks for the PR Ben. I think I have the error pinned down - in the constructor of ThresholdReactor we initialize _currentBucketSeconds to an un-rounded seconds value, which will make a mess of quite a bit of logic. Pushing that change through now. Cheers!

Thanks for looking into this Nick.

@bbrandt just a heads up, I'm creating a new (public) CI build for this project, so it may take a day or two for me to get the new package version published.

Thanks for the heads up.

This is published now.


Raise exception with more information upon plugin bug

Fixes https://github.com/apache/buildstream/issues/1783

@gtristan so is this now okay after your requested changes?

Yes thankyou ! Sorry again for leading you down a rabbit hole


For OnePlus 8T, sdm865_lp4x.json should be used, but it uses sdm865_lp5.json

ROM: LineageOS 18.1
Uperf: dev-21.1.31

Solved


Fixed issue with production build throwing error. Closes #18

This fixes the issue described in #18

Thanks! Merging.


Create shahvithik.c

This Pull Request resolves Issue #3

Thank you for contributing!

Thank you for contributing!


[Python] Memory leak with dataset.head

Describe the bug, including details regarding any error messages, version, and platform.
dataset.head loads all data in memory and doesn't release it. when it should just load the top n rows.
This issue started after July 17 2023.
Versions
Pyarrow : 12.0.0
Python: 3.10.6
Jupyter lab: 3.3.4 on
Docker: 4.12.0 (85629) on
windows 10, version: 21H2,  build: 19044.3086
Sample data
https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2009-01.parquet   For all the months
Sample Code

Install memory_profiler

pip3 install memory_profiler

load Extension and Check mem

%load_ext memory_profiler
%memit

peak memory: 163.00 MiB, increment: 0.21 MiB

Create Dataset

import pyarrow.dataset as ds
data = ds.dataset('./testdata/nyc/year=2009', format='parquet', partitioning='hive')

Check mem

%memit

peak memory: 157.97 MiB, increment: 0.01 MiB

Count rows

data.count_rows()

170896055

Check mem

%memit

peak memory: 170.34 MiB, increment: 0.02 MiB

get first 10 rows

data.head(10).to_pandas()

Check Mem

%memit

peak memory: 11753.76 MiB, increment: 142.51 MiB
peak memory: 9914.21 MiB, increment: 0.00 MiB
peak memory: 9914.21 MiB, increment: 0.00 MiB
peak memory: 9914.21 MiB, increment: 0.00 MiB
Component(s)
Parquet, Python

You are correct.  That is the way it currently works.  There is a better implementation of this operation in the C++ but it requires that the batch's index is set and the scan node does not currently do this.  The new scan work I am adding does and so we should be able to switch when that is ready but I don't know how long that will take.  Otherwise someone could probably look into adding the order number in the old scan node if they had time.


1.9.3 Hotfix release checklist

[x] Dapr maintainer(s) communicate out the discovery of an issue that requires a hotfix and the reason why to the Discord Maintainers and Release channels. Hotfix is one of categories below:

[ ] Security vulnerability
[X] Regression that does not have a work around: https://github.com/dapr/dapr/pull/5455
[ ] Broken mainline scenario that has a missing test case

[ ] Create the v1.9.3-rc.1 Hotfix release (code changes) and test it
[ ] ~~Create v1.9.3-rc.1 Tag ~~
[x] Performance tests passing: https://github.com/dapr/dapr/actions/runs/3395935019
[x] End to End tests passing on Linux and Windows: https://github.com/dapr/dapr/actions/runs/3395934010
[X] New test case written to catch future occurrences: [@johnewart] https://github.com/dapr/dapr/pull/5455
[ ] Notify users to try RC1
[ ] Update the longhaul tests to use 1.9.3-rc.1
[x] Write release notes [@italypaleale]
[X] Review release notes [@artursouza or @yaron2 ]
[x] Create v1.9.3 Tag [@artursouza or @yaron2 ]
[x] Backport fixes into master branch: https://github.com/dapr/dapr/pull/5461
[ ] Update the documentation: Latest version & versions in supported releases [@greenie-msft or @nyemade-uversky ]
[x] Push new tag in installer-bundle repo. [@shivamkm07]
[ ] Announce the hotfix release on Discord Announcements channel [@greenie-msft or @nyemade-uversky ]

Closed as complete


IVY-1631: ivy:retrieve Ant task and empty FileSet bug

IVY-1631: when the ivy:retrieve Ant task retrieves the jars to a non-empty directory, but the retrieve task itself didn't retrieve any files, the created fileset was not empty but contained the existing files in that directory.

Hello @maartenc, this looks good to me. One question - The retrieve also has a pathId which creates a path out of the retrieved artifacts. Is that affected by this issue too and would that need to be fixed too? It's OK with me if you think we should deal with that separately and merge this PR.

Thanks for the review @jaikiran, the path creation is ok (we use that as a workaround for the moment), but just to be sure I've added some extra checks to the junit test.
I'll merge this PR later today.
thanks,
Maarten

Thank you Maarten for the updated tests. They look fine to me.


issue when installing phpci

Hi
I am trying to install phpci on my server cloudways the problem is when I use the url of my application it gives me what I have in my index.php given by cloudways and when I add public to url I get "session/login not found" please help

Make sure you have mod rewrite enabled and that Apache points to public folder.
Sent from my phone so I couldn't check against my setup

Hi,
Yes mod rewrite is enabled and I add this to my httpd_vhots  <VirtualHost *:80>
DocumentRoot c:/wamp/www/phptesting/public
ServerName add.test.ra
ServerAlias add.test.ra
<Directory c:/wamp/www/phptesting/public >
    Options Indexes FollowSymLinks
    AllowOverride All
    Require all granted
</Directory>

But I still have the same issue

Have you copied/renamed .htaccess.dist to .htaccess?

I have the same problem on my Ubuntu machine with Apache 2.4.18. The public folder of PHPCI is located at /var/www/html/phpci/public and I copied .htaccess.dist to .htaccess in that folder.
My VirtualHost file (phpci.localhost.conf) is placed at /etc/apache2/sites-available and in /etc/hosts phpci.localhost points to <IP_ADDRESS>. The VirtualHost is also activated.
<VirtualHost *:80>
        ServerName phpci.localhost
        ServerAdmin webmaster@localhost
        DocumentRoot /var/www/html/phpci/public/
        <Directory /var/www/html/phpci/public/>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride None
                Order allow,deny
                allow from all
        </Directory>
        ErrorLog /var/log/apache2/error.log
        LogLevel warn
        CustomLog /var/log/apache2/access.log combined
        ServerSignature On
</VirtualHost>

When I call now phpci.localhost in the browser I receive a HTTP 302 (Moved temporarily) and I'm forwarded to localhost/phpci/session/login and receive a HTTP 404 (The requested URL /phpci/session/login was not found on this server.). The same happens when I call localhost/phpci/public directly. First I receive the HTTP 302 then the HTTP 404.

Make sure mod_rewrite is activated aside from just being enabled.


Max pooling in character embedding.

At line 32 in the my.tensorflow.nn.py, you used reduce_max. But in your paper, you said using max pooling after CNN to extract character features. Could you please explain it? Thanks!

Hi. It's basically a global max pooling over the sequence length. I used a reduce_max to replace tf.squeeze(tf.max_pooling(tensor, [stride is the sequence length])).


HttpError: Package not found (not permission issue)

I recently noticed that my cron job now constantly fails to prune images. I am getting this error: Error: Failed to prune because of: HttpError: Package version not found.
Though I have many jobs, running for different packages to remove images and only some fail. If I later re-run failed jobs, they complete fine. So I guess its related with some timeout issues or something?

P.S. I see there was issue regarding same error here: https://github.com/vlaurin/action-ghcr-prune/issues/64 but in my case, it does not look like its access issue.

Hi @oerp-odoo,
Given there are multiple jobs that seem to be running concurrently, could it be that there's an overlap in the versions being pruned by 2 different jobs?
For example, prune_images (17.0) and prune_images (16.0) running in parallel; both listing the same versions; but 17.0 having started a few seconds earlier starts pruning first and when 16.0 then tries to prune the packages they've already been removed hence the Package version not found error?
You should be able to confirm that by expending the Pruning x versions... in the logs and cross-checking version IDs/SHAs for overlap.

@vlaurin you are right, it could be the case. As I am not filtering per version and multiple jobs can use same step, so it could get same images:
      - name: Prune specific ref old images
        uses<EMAIL_ADDRESS>        with:
          token: ${{ secrets.GHCR_DELETE_TOKEN }}
          organization: versada
          container: ${{ matrix.project }}
          dry-run: false
          keep-younger-than: 10
          keep-last: 0
          prune-untagged: false
          prune-tags-regexes: ^ref-.+$

I will simplify prune logic and see how it goes. Thanks for suggestions.

No worries. You mentioned the workflow is running on a cron schedule, so I assume there's no performance requirements. If so, one option would be to configure the jobs to run sequentially instead of concurrently. It will take a couple more minutes for the workflow to complete but that will solve the concurrency issue.

Yeah I currently run this once every night, to clean up old images.


"GenericArguments[0], 'SystemMessageTest', on 'Google.ProtocolBuffers.IBuilderLite`2[TMessage,TBuilder]' violates the constraint of type parameter 'TMessage'."

What steps will reproduce the problem?
1.Build a simple .proto file then convert into .cs file ( simple .proto file can just be a simple class with single data )
2.Import into Unity project ( with .cs file and .dll file for windows phone 8 ) - Unity v5.0.2p1
3.Build Unity project into Windows phone 8 project
4.Run on device in RELEASE mode => see it crashed.

I cant see the whole stack trace since everything is "Null" the only message I got from debug data is this
"GenericArguments[0], 'SystemMessageTest', on 'Google.ProtocolBuffers.IBuilderLite`2[TMessage,TBuilder]' violates the constraint of type parameter 'TMessage'."
But by doing exactly my step will get you guys there . ( dont run in Debug mode since it will be ok , run in Release mode instead )
Thanks.

I manage to get the full stack trace here

  $exception	{System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'WinRTBridge.WinRTBridge' threw an exception. ---> System.TypeInitializationException: The type initializer for 'WinRTBridge.TypeInformation' threw an exception. ---> System.TypeLoadException: GenericArguments[0], 'SystemMessageTest', on 'Google.ProtocolBuffers.IBuilderLite`2[TMessage,TBuilder]' violates the constraint of type parameter 'TMessage'.

at UnityEngineInternal.BootstrapHelpers.FillTypeMaps(Dictionary2& typeToTypeIdMap, List1& typeIdToTypeMap)
at WinRTBridge.TypeInformation..cctor()
--- End of inner exception stack trace ---
at WinRTBridge.WinRTBridge..cctor()
--- End of inner exception stack trace ---
at WinRTBridge.WinRTBridge.set_Control(Object value)
at NPlayTest.MainPage..ctor()
--- End of inner exception stack trace ---
at System.Windows.Navigation.PageResourceContentLoader.EndLoad(IAsyncResult asyncResult)
at System.Windows.Navigation.NavigationService.ContentLoader_BeginLoad_Callback(IAsyncResult result)
at System.Windows.Navigation.PageResourceContentLoader.BeginLoad_OnUIThread(AsyncCallback userCallback, PageResourceContentLoaderAsyncResult result)
at System.Windows.Navigation.PageResourceContentLoader.<>c__DisplayClass4.b__0(Object args)
--- End of inner exception stack trace ---
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
at System.Reflection.RuntimeMethodInfo.UnsafeInvoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.Delegate.DynamicInvokeImpl(Object[] args)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.Dispatch(DispatcherPriority priority)
at System.Windows.Threading.Dispatcher.OnInvoke(Object context)
at System.Windows.Hosting.CallbackCookie.Invoke(Object[] args)
at System.Windows.RuntimeHost.ManagedHost.InvokeDelegate(IntPtr pHandle, Int32 nParamCount, ScriptParam* pParams, ScriptParam* pResult)}	System.Exception {System.Reflection.TargetInvocationException}

Without knowing anything about UnityEngineInternal.BootstrapHelpers.FillTypeMaps, it's hard for me to do anything else with this issue, I'm afraid.
(I've never advertised Unity as a supported platform for Protocol Buffers, and I've never used it myself. I'm not going to install it just to chase down this problem - particularly not right now, as I'm on holiday at the moment.)
As mentioned elsewhere, you could try applying https://github.com/ironhidegames/protobuf/commit/83bcfefb0be8a2a05a03e7d7080b354973c39b20 - but it's not clear that it's the same issue that that one fixes.
I suggest you contact Unity support about this - they're more likely to know about the quirks of Mono at that particular version and running on iOS than I do.

Ok I had fix this via Unity side , it is not because of Protocol buffer .
Thanks a lot.


Unable to Connect the MatchesPage with the Main Dashboard

Finding it tough to connect the MatchesPage with the recruiter dashboard. Need to Fix that soon.

Issue Fixed. The two are working well now.


Adding dataset Paris Bible Project

schema: https://htr-united.github.io/schema/2022-04-15/schema.json
title: Paris Bible Project (PBP)
url: https://github.com/parisbible
authors:
  - name: Estelle
    surname: Guéville
    orcid: 0000-0003-2603-1051
    roles:
      - transcriber
      - aligner
      - project-manager
      - quality-control
  - name: David
    surname: Wrisley
    orcid: 0000-0002-0355-1487
    roles:
      - transcriber
      - aligner
      - project-manager
      - quality-control
  - name: Niccolò Acram
    surname: Cappelletto
    roles:
      - transcriber
      - aligner
      - quality-control
institutions: []
description: >-
  The Paris Bible Project aims to understand the production and diffusion of
  medieval Latin Bibles in Europe. The dataset includes ground truth from Paris
  Bibles produced in the 13th and 14th centuries. We also provide the most
  recent version of our list of Paris Bible manuscripts found in the world along
  with information about them.
project-website: https://parisbible.github.io/
language:
  - lat
production-software: Transkribus
script:
  - iso: Latn
  - iso: Goth
script-type: only-manuscript
time:
  notBefore: '1200'
  notAfter: '1399'
hands:
  count: more-than-10
  precision: estimated
license:
  - name: CC-BY 4.0
    url: https://creativecommons.org/licenses/by/4.0/
format: Alto-XML
volume:
  - metric: lines
    count: 10000
transcription-guidelines: 'See: https://parisbible.github.io/guidelines/'

Hello!
Thank you for this proposition! Do you only offer TXT files for the ground truth? (I assume the link to the ground truth files is https://github.com/parisbible/ground_truth)
If so, then it would be preferable to export XML ALTO or XML PAGE from Transkribus. Also, any chance you can publish the images corresponding to the ground truth?
Otherwise, if I didn't look at the right repository, could you indicate where to find it?

Dear Alix,
Apologies for the delay. We have updated everything in github, here: https://github.com/parisbible/ground_truth/tree/main/PBP 1.0
You will find TXT, ALTO and XML files as well as the images when they are publicly available.
We will keep updating things as the project evolves.
All the best,
Estelle

Thaniks and sorry for the delay, we are kind of drowning lately with @alix-tz but we're back :)

Added to HTR-United through #108. It will be visible online soon :)
I recomputed some metrics: I only found 1700 lines and not 10000. I updated  the scripts (Goth is for gothic script such as https://www.compart.com/en/unicode/scripts/Goth ).
Thanks !


[Bug]: DNN 9.13.6 Upgrade Overwrites Newer DLL, Breaking 2sxc Module

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When upgrading a DNN 9.13.4 site with 2sxc 18.4 to DNN 9.13.5+, the 2sxc module stops working. The DNN upgrade overwrites System.Runtime.CompilerServices.Unsafe.dll version <IP_ADDRESS> with an older version <IP_ADDRESS>, causing compatibility issues with 2sxc.
The DNN upgrade should not break the 2sxc module. It should preserve newer versions of DLLs or handle dependencies correctly to ensure that modules depending on newer versions continue to function.
Steps to reproduce?

Install DNN 9.13.4 with the 2sxc 18.4 module.
Verify that 2sxc is working correctly.
Upgrade DNN to version 9.13.6.
Observe that the 2sxc module stops working and throws exceptions.

Detailed steps and discussion are available at 2sic/2sxc#3511.
Current Behavior

The 2sxc 18+ module installs System.Runtime.CompilerServices.Unsafe.dll version <IP_ADDRESS> in the bin directory.
After upgrading to DNN 9.13.5+, the DLL is overwritten with version <IP_ADDRESS>.
The web.config and the Assemblies table in the DNN database still reference version <IP_ADDRESS>.
As a result, 2sxc, which depends on version <IP_ADDRESS>, fails to work and throws exceptions.

Expected Behavior
The DNN upgrade process should not overwrite newer DLLs with older versions without appropriately handling assembly bindings. It should:

Preserve newer versions of DLLs if they exist.
Update web.config and the Assemblies table to reflect any changes in DLL versions.
Ensure that modules depending on newer DLL versions continue to function after the upgrade.

Relevant log output
System.ArgumentNullException: Value cannot be null. Parameter name: collection
   at System.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Collections.Generic.List`1.InsertRange(Int32 index, IEnumerable`1 collection)
   at ToSic.Eav.Apps.Services.AppDataStackService.GetStack(AppThingsIdentifiers target, IEntity viewPart) in C:\Projects\2sxc\eav-server\ToSic.Eav.Core\Apps\Services\AppDataStackService.cs:line 40
   at ToSic.Eav.Apps.Services.AppDataStackService.GetStack(String part, IEntity viewPart) in C:\Projects\2sxc\eav-server\ToSic.Eav.Core\Apps\Services\AppDataStackService.cs:line 31
   at ToSic.Lib.Helpers.GetOnce`1.Get(Func`1 generator) in C:\Projects\2sxc\eav-server\ToSic.Lib.Core\Helpers\GetOnce.cs:line 38
   at ToSic.Sxc.LookUp.Internal.SxcAppDataConfigProvider.GetLookupEngineForContext(IContextOfSite context, IApp appForLookup, IBlock blockForLookupOrNull) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic.Sxc\LookUp\Internal\SxcAppDataConfigProvider.cs:line 63
   at ToSic.Sxc.LookUp.Internal.SxcAppDataConfigProvider.GetDataConfiguration(EavApp app, AppDataConfigSpecs specs) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic.Sxc\LookUp\Internal\SxcAppDataConfigProvider.cs:line 21
   at ToSic.Eav.Apps.Internal.EavApp.<get_AppDataConfig>b__22_0() in C:\Projects\2sxc\eav-server\ToSic.Eav.Apps\Eav.Apps.Internal\App\EavApp_Data.cs:line 17
   at ToSic.Lib.Helpers.GetOnce`1.Get(Func`1 generator) in C:\Projects\2sxc\eav-server\ToSic.Lib.Core\Helpers\GetOnce.cs:line 38
   at ToSic.Eav.Apps.Internal.EavApp.<get_ConfigurationProvider>b__19_0() in C:\Projects\2sxc\eav-server\ToSic.Eav.Apps\Eav.Apps.Internal\App\EavApp_Data.cs:line 11
   at ToSic.Lib.Helpers.GetOnce`1.Get(Func`1 generator) in C:\Projects\2sxc\eav-server\ToSic.Lib.Core\Helpers\GetOnce.cs:line 38
   at ToSic.Eav.Apps.Internal.EavApp.BuildData[TDataSource,TResult]() in C:\Projects\2sxc\eav-server\ToSic.Eav.Apps\Eav.Apps.Internal\App\EavApp_Data.cs:line 39
   at ToSic.Eav.Apps.Internal.EavApp.get_Data() in C:\Projects\2sxc\eav-server\ToSic.Eav.Apps\Eav.Apps.Internal\App\EavApp_Data.cs:line 33
   at ToSic.Sxc.Web.Internal.JsContext.JsContextAll.GetJsContext(String systemRootUrl, IBlock block, String errorCode, List`1 exsOrNull, RenderStatistics statistics) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic.Sxc\Web\Internal\JsContext\JsContextAll.cs:line 60
   at ToSic.Sxc.Blocks.Internal.Render.RenderingHelper.ContextAttributes(Int32 instanceId, Int32 contentBlockId, Boolean includeEditInfos, Boolean includeJsApiContext, String errorCode, List`1 exsOrNull, RenderStatistics statistics) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic\ToSic.Sxc\Blocks\Internal\Render\RenderingHelper.cs:line 77
   at ToSic.Sxc.Blocks.Internal.Render.RenderingHelper.WrapInContext(String content, NoParamOrder noParamOrder, Int32 instanceId, Int32 contentBlockId, Boolean editContext, Boolean jsApiContext, String tag, Boolean addLineBreaks, String errorCode, List`1 exsOrNull, RenderStatistics statistics) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic\ToSic.Sxc\Blocks\Internal\Render\RenderingHelper.cs:line 56
   at ToSic.Sxc.Blocks.Internal.BlockBuilder.RenderInternal(RenderSpecs specs) in C:\Projects\2sxc\2sxc\Src\Sxc\ToSic\ToSic.Sxc\Blocks\Internal\BlockBuilder\BlockBuilder_Render.cs:line 88

Anything else?

This issue has been reported and discussed in the 2sxc repository: 2sic/2sxc#3511.
The problem appears to have started with DNN version 9.13.5, where the upgrade package includes the older System.Runtime.CompilerServices.Unsafe.dll version <IP_ADDRESS>.
Manual workaround i just to copy System.Runtime.CompilerServices.Unsafe.dll version <IP_ADDRESS>. over version <IP_ADDRESS>. in bin folder, or reinstall 2sxc module

Affected Versions
9.13.6 (latest release)
What browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Request for Insights
@mitchelsellers, @bdukes, and @valadas:
Is there any specific limitation or reason in DNN versions 9.13.5 and above that necessitates the current behavior regarding the System.Runtime.CompilerServices.Unsafe.dll dependency? Specifically, the upgrade process overwriting newer DLLs with older versions seems to cause compatibility issues with modules like 2sxc that depend on the newer DLL versions.
Your insights on this matter would be greatly appreciated.

I am not sure if this helps, but in DNN v9.13.06 with 2sxc 8.0.4 re-installed (so its fixed), you can find 3 copies/versions of System.Runtime.CompilerServices.Unsafe.dll in /bin/* as follows:

\bin\roslyn, 4.700.18.56404
\bin]Imageflow, 4.6.28619.1
\bin, <IP_ADDRESS>210

The version in the \bin folder of the DNN v9.13.06 upgrade zip is 4.6.28619.1.

This is an item included by DLL by default, so unzipping the upgrade package overwrites, there is no possibility to protect this version at upgrade.
It is possible, depending on usage for this also to be extracted as a package so version number rules could be respected but it would need to be reviewed.
This is a reason why upgrading versions of core distributed components should be discouraged/avoided wherever possible. As there are limitations of what is possible due to the way the DNN upgrades are applied.

as a workaround, you can binding different version of the assembly to different dll files:
https://stackoverflow.com/questions/638310/how-to-operate-with-multiple-assembly-versions-in-private-folders-using-config

Another possible fix is to (in this order):

before upgrading to DNN v9.13.06 (while still on .04), copy the System.Runtime.CompilerServices.Unsafe.dll from /bin to /bin/2sxc
add a binding redirect (working example below) in /web.config
upgrade to DNN v9.13.06 (and 2sxc does not break**)

DLL version assignments via Binding Redirect:
  <dependentAssembly xmlns="urn:schemas-microsoft-com:asm.v1">
        <assemblyIdentity name="System.Runtime.CompilerServices.Unsafe" publicKeyToken="b03f5f7f11d50a3a" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-<IP_ADDRESS>" newVersion="<IP_ADDRESS>" xmlns="urn:schemas-microsoft-com:asm.v1" />
        <codeBase version="<IP_ADDRESS>" href="bin\Imageflow\System.Runtime.CompilerServices.Unsafe.dll" xmlns="urn:schemas-microsoft-com:asm.v1" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-4.32767.32767.32767" newVersion="<IP_ADDRESS>" />
        <bindingRedirect oldVersion="<IP_ADDRESS>-32767.32767.32767.32767" newVersion="<IP_ADDRESS>" />
        <codeBase version="<IP_ADDRESS>" href="bin\2sxc\System.Runtime.CompilerServices.Unsafe.dll" xmlns="urn:schemas-microsoft-com:asm.v1" />
  </dependentAssembly>

In English, this tells your app which DLL to use based on the version needed. 0 to <IP_ADDRESS> for ImageFlow, <IP_ADDRESS> to 5.* use the default (in /bin), and 6+ uses the 2sxc folder one. More help on this is available here.
** and stress is greatly reduced ;)

This is an item included by DLL by default, so unzipping the upgrade package overwrites, there is no possibility to protect this version at upgrade.
It is possible, depending on usage for this also to be extracted as a package so version number rules could be respected but it would need to be reviewed.
This is a reason why upgrading versions of core distributed components should be discouraged/avoided wherever possible. As there are limitations of what is possible due to the way the DNN upgrades are applied.

@mitchelsellers AFAIK 2sxc never upgraded an existing DNN DLL - this is a brand-new DLL for DNN since 9.13.5. So this is a breaking change introduced by DNN without respecting the versions table...
So DNN could at least include the latest version, instead of an old one.
@tvatavuk is what I wrote above correct?

I think Daniel is right.  I understand it's not for DNN community to police what third party modules use what dlls, but it's strange that DNN did not use the latest version.  Is there a reason for this?

We will have to review then why this came in, I'm not aware of dependency updates they were in this version only.
Because it is in the initial zip, there is no way to respect the DLL table.
It's a holiday here in the US. I'll try to review asap if no one else has time.

My guess would be that there has been a LOT of "version bump" clean up on dependencies, most likely it is a sub (sub) dependency that was brought in to play. Likely recent stuff here?
Searching Pull Requests for "unsafe":
https://github.com/dnnsoftware/Dnn.Platform/pulls?q=is%3Apr+Unsafe

Yeah, I'm looking there.  THe biggest thing I'm seeing so far is that is only in Test projects not normal ones, so not sure why it would even be in the package.

Just an update for everyone, I have found where this started coming in, not 100% sure what package actually has it, but we can at least start to figure out where to look from here.
This file was introduced in 9.13.5, and is also here in 9.13.6
So this issue impacts BOTH 9.13.5 and 9.13.6

For the record, I triple checked and these 5 DLLs (red line to the right) were introduce in 9.13.05.

@mitchelsellers thanks for prioritizing this 🙏🏽

DNN 9.13.7-rc1 appears to resolve the problem. I did a test upgrading a DNN 2sxc v9.13.4, 2sxc v18.04.00 to DNN 9.13.7-rc1. There were no issues.


Add background decorations to landing page

Reference Issues or PRs

https://github.com/nebari-dev/nebari-docs/issues/220

Note: there was no guidance from the Figma about how these should behave at very narrow/mobile or very wide widths, so I just made some guesses. I need people to examine the preview page at various widths to make sure it looks good.

@gabalafou Thank you, this is looking really nice! ✨
A thought (that doesn't need to block merging this PR) -- the Nebari silhouette in the footer seems to be visually interfering with the Documentation column text on desktop sizes, and feels oddly large on medium/small width. I'd prefer updating or removing it.
@trallard What are your thoughts on this PR?

Thanks for the review @pavithraes. The footer is so far from the intended design, it should probably be handled in a separate pass. I went ahead and reverted the changes to the footer. I'll wait for the preview build, and then merge this in.

Actually I am going to make a few small tweaks from comments I got from Irina before merging this in, so stay tuned 🙂

Oooooo fancy ✨ 💅🏽  - out of curiosity I ran a Lighthouse test and it threw away that the Get started button (#C118E4) does not have enough contrast with the text (#F1F1F6) so could you sneak in that fix in the PR 🙏🏽 (--nebari-magenta-3 should fix this)?
Observations for small screens/mobile:

The GIF becomes extremely hard to read/appreciate - not really sure what the best alternative would be. Filling the width of the screen?

The hero banner has a golden circle on the right-top quadrant, as I was changing the screen width, I could see the circle move away towards the right until it disappears (it seems to be the only item doing that or at least obviously). It completely disappears at 1000px - it is not a big issue and perhaps only noticeable if one is resizing to catch any nags like this

Thanks Tania for the review!

Accessibility / color contrast. This isn't related to this PR, so I will open another PR to address the color contrast issue specifically.
The GIF also isn't related to this PR, so I will open an issue for it.
This seems fine to me, but I defer to @Irinafumarel

#269
#270


Make widget Expanded size as min height in SingleChildScrollView Widget

Here is my code
child: Scaffold(
        resizeToAvoidBottomPadding: false,
        appBar: AppBar(),
        drawer: MyDrawer(),
        body: SingleChildScrollView(
          child: Column(
            mainAxisSize: MainAxisSize.min,
            // direction: Axis.vertical,
            children: [
              Container(
                height: 400,
                child: Text('PageOne'),
              ),
              IntrinsicHeight(
                child: Expanded(
                  child: Container(
                    width: double.infinity,
                    color: Colors.grey,
                    child: Text(
                      'Hi',
                      textAlign: TextAlign.center,
                    ),
                  ),
                ),
              ),
            ],
          ),
        ),
      ),

I want this grey container in the screenshot fill the height as min height, I need it responsively with rotate the screen phone and for all phone screen size, it's only takes static height size when use SingleChildScrollView because unlimited height is available, i try to find way to make him take the remaining height of the screen as min height of container.
any ideas?

Hi @AbdallahR99
It seems you are asking for assistance on personal code. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


[Task] Design review for the nav bar of the platform

Currently, there's placeholder design in the nav bar of the app, which needs a design review since it does not align with the current designs.
Related to:
https://github.com/cfpb/sbl-project/issues/80
https://github.com/cfpb/sbl-project/issues/78
https://github.com/cfpb/sbl-project/issues/157
Current behavior

nav bar doesn't align with designs

Expected behavior

nav bar should be approved by @natalia-fitzgerald through a design review

Screenshots
Currently on main:

Design (like do we not want an underline when a user is on their profile page?):

Closed by #754 and #775


Typo in Unit 1 Hands-on page

Under the "Create the LunarLander environment 🌛 and understand how it works" section, the link to the environment documentation is still in markdown
[The environment 🎮](https://gymnasium.farama.org/environments/box2d/lunar_lander/)

Thanks I'm adding it to the update of the week 🤗

Updated. Thanks again 🤗


docs/FileDialog: Use clickable references

Minor edits to the documentation of FileDialog.access (method) and FileDialog.mode_overrides_title (property)
This PR adds 2 clickable references, and also fixes a mistake of citing a property named Mode when it should be file_mode.

Thanks! And congrats on your first merged Godot PR!

Cherry-picked for 4.0.3.


Set style for Image

Can you help me set style for image ?
I reading your source code, I don't see you allow set style

You cannot directly set class or style. But you can override the styling in your css by target this classname md-block-image-inner-container

OK thanks you


docs: fix typos

Description
Typo fix in README and code comments:
README.md
packages/gql-utils/prisma/connection-key.ts
packages/gql-utils/prisma/create-connection-loader.ts
packages/ui/index.ts b/packages/ui/index.ts

Checklist

[x] discord username: sadikkuzu
[ ] Closes #
[ ] PR must be created for an issue from issues under "In progress" column from our project board.
[x] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules, and should include the app/package/service name in the title. For example, a title like "docs(@kampus-apps/pano): Add README.md" can be used.
[ ] Related file selection: Only relevant files should be touched and no other files should be affected.
[ ] I ran npx turbo run at the root of the repository, and build was successful.
[ ] I installed the npm packages using npm install --save-exact <package> so my package is pinned to a specific npm version. Leave empty if no package was installed. Leave empty if no package was installed with this PR.

How were these changes tested?
Code inspection only.

My pleasure 🙏🏼✨🚀


When I use swiper in webpack has error

When I use swiper in react, and use webpack to run my web application, it has a error:
ERROR in bundle.js from UglifyJs Unexpected token: name (w) [./node_modules/swiper/dist/js/swiper.esm.bundle.js:15,0][bundle.js:55903,4]
How to fixed it?
Thanks!

Look at the end of this page http://idangero.us/swiper/get-started/


Enhance typings for compareSnapshot and hideElement custom command

Enhance typings for compareSnapshot and hideElement custom command
Include HTML Report demo in README.md

:tada: This PR is included in version 2.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


python38Packages.flexmock: 0.10.4 -> 0.10.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.flexmock is: "flexmock is a testing library for Python that makes it easy to create mocks,stubs and fakes."
meta.homepage for python38Packages.flexmock is: "https://flexmock.readthedocs.org"
meta.changelog for python38Packages.flexmock is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.10.5 with grep in /nix/store/vzxdkgr36p3a1cb1kr6h94n2g0k9bk46-python3.8-flexmock-0.10.5

found 0.10.5 in filename of file in /nix/store/vzxdkgr36p3a1cb1kr6h94n2g0k9bk46-python3.8-flexmock-0.10.5

directory tree listing: https://gist.github.com/0c771fb25a536d7c1d53a824c045e5e3

du listing: https://gist.github.com/e1c9baa2327825d168940599e27e0ef5

Rebuild report (if merged into master) (click to expand)

27 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
borgmatic
python38Packages.flexmock
python38Packages.ihatemoney
python38Packages.sqlalchemy-continuum
python39Packages.flexmock
python39Packages.ihatemoney
python39Packages.sqlalchemy-continuum

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vzxdkgr36p3a1cb1kr6h94n2g0k9bk46-python3.8-flexmock-0.10.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.flexmock https://github.com/r-ryantm/nixpkgs/archive/c657711707f8bf14f1ba62fab6ac69b0cc5bd659.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vzxdkgr36p3a1cb1kr6h94n2g0k9bk46-python3.8-flexmock-0.10.5
ls -la /nix/store/vzxdkgr36p3a1cb1kr6h94n2g0k9bk46-python3.8-flexmock-0.10.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings

Result of nixpkgs-review pr 133820 at c6577117 run on aarch64-linux 1

4 packages failed to build:

python38Packages.ihatemoney
python38Packages.sqlalchemy-continuum
python39Packages.ihatemoney
python39Packages.sqlalchemy-continuum

3 packages built successfully:

borgmatic
python38Packages.flexmock
python39Packages.flexmock

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/flexmock/default.nix:21:3:
   |
21 |   meta = with lib; {
   |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Remove extra ligands

Description
We've had a hard time tracking down when OpenEye grabs the ligand from chain A vs chain B to use to create the receptor grid. In order to do this explicitly, @kaminow has written a function to first remove the ligand from the chain we don't need.
Todos
Notable points that this PR has either accomplished or will accomplish.

[x] remove ligands from chains that aren't in xtal.active_site_chain
[x] confirm that resulting docked poses are aligned with the ligands aligned to each other

Questions

[ ]

Status

[ ] Ready to go

Codecov Report

Merging #103 (578017a) into main (3a73101) will not change coverage.
The diff coverage is 0.00%.


(WIP) Snakemake workflow update

Update existing snakemake workflow to cope with repo update.
detailed progress at #205
open this PR for code check and update.

There are quite a few files in there that probably shouldn't be part of this pull request e.g. changes to method implementations.

Hi, yes that's cuz I merged main to the wip_wf_optargs. I also merged main to wip_workflows: maybe those changes shouldn't matter? I can restart a new pr

Please only add workflow related changes to this PR, otherwise we might get a mess when trying to merge the workflow to main later.


Refactor PolarisRestCatalogViewIntegrationTest into per cloud provider tests

Description
Test-only change that refactors the PolarisRestCatalogViewIntegrationTest, which runs the Iceberg REST Catalog test suite, into 1 test per cloud provider. There doesn't seem to be a way to do this in 1 file because we inherit the test methods from a superclass.
I'm also interested in doing this for other tests but would like to first gather feedback on this one.
Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[X] The tests

Checklist:

[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings

@eric-maynard Updated it to be multiple files once again and the cloud-provider specific ones will skip the test if the configs aren't specified. This lets people distinguish between tests that were actually ran vs. not.


Fix Rails 6 warnings about BINDING env var

@kevindew I forgot about that! Unfortunately we don't need my change anymore, since we're using the --restart flag now 😬


Using @ignore now renders empty ignore block

Search terms
ignore, rendering
Expected Behavior
In a barrel file for Typescript, using the @ignore tag should ignore the file completly
Actual Behavior
In the rendered documentation an empty 'ignore' block is rendered
Steps to reproduce the bug
Example Barrel: https://github.com/tanepiper/rxjs-primitives/blob/master/libs/rxjs/array/src/index.ts
Typedoc config: https://github.com/tanepiper/rxjs-primitives/blob/master/typedoc.json
Run typedoc, generate output to docs: https://tanepiper.github.io/rxjs-primitives/modules/array.html

Environment

Typedoc version: 0.19.2, typedoc-plugin-external-module-name: 4.0.3
TypeScript version: 4.05
Node.js version: 13.14.0
OS: OSX 10.15.7

Fixed in 0.20.0-beta.11 (though likely not quite in the way you expect, library based docs changes what it means to "ignore" a reflection somewhat), looks like you may have found a workaround in the meantime - nice looking docs! I like it better than TypeDoc's default theme.


Add dependabot for github actions

That way dependabot will open PRs on a weekly basis to update Github Actions dependencies

Thanks!

Would you mind doing the same for crates as well? could be useful, at least to get an idea of when a new update is available for a crate

Would you mind doing the same for crates as well? could be useful, at least to get an idea of when a new update is available for a crate

So you want to have a PR simply as notification which you then close again?

Would you mind doing the same for crates as well? could be useful, at least to get an idea of when a new update is available for a crate

So you want to have a PR simply as notification which you then close again?

yeah, or merge them if no changes are needed


Add nanoid package

This package is nanoid, implemented in Nim.

Something wired.... GitHub problem? Is nanoid still well maintained or should I choose another library?
https://github.com/Cirru/calcit-runner.nim/runs/1498458836?check_suite_focus=true
 Installing nanoid@any version
    Reading official package list
Downloading https://github.com/icyphox/nanoid.nim using git
download.nim(93)         getTagsListRemote
Error: unhandled exception: Unable to query remote tags for https://github.com/icyphox/nanoid.nim. Git returned: error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: expected flush after ref listing
 [OSError]
Error: Process completed with exit code 1.

Jon<EMAIL_ADDRESS>wrote:

Something weird.... GitHub problem? Is nanoid still well maintained or should I choose another library?

Looks like an issue with GitHub, works fine here. As for nanoid being
maintained -- the JS version hasn't changed all that much (aside from
the API); the algorithm in use remains the same. The only thing missing
is async, which I'll probably implement over the weekend.
--
Anirudh Oppiliappan
https://icyphox.sh

that's quite quick response :D
the thing made me worried was nimble shew me warnings about nanoid. could you look into that as well:
 Installing nanoid@any version
Downloading https://github.com/icyphox/nanoid.nim using git
   Warning: Package 'nanoid' has an incorrect structure. It should contain a single directory hierarchy for source files, named 'nanoid', but file 'nonsecure.nim' is in a directory named 'nanoidpkg' instead. This will be an error in the future.
      Hint: If 'nanoidpkg' contains source files for building 'nanoid', rename it to 'nanoid'. Otherwise, prevent its installation by adding `skipDirs = @["nanoidpkg"]` to the .nimble file.

Jon<EMAIL_ADDRESS>wrote:

that's quite quick response :D
the thing made me worried was nimble shew me warnings about nanoid. could you look into that as well:

Sure, this package needs some TLC. Will fix. Thanks.

 Installing nanoid@any version
Downloading https://github.com/icyphox/nanoid.nim using git
   Warning: Package 'nanoid' has an incorrect structure. It should contain a single directory hierarchy for source files, named 'nanoid', but file 'nonsecure.nim' is in a directory named 'nanoidpkg' instead. This will be an error in the future.
      Hint: If 'nanoidpkg' contains source files for building 'nanoid', rename it to 'nanoid'. Otherwise, prevent its installation by adding `skipDirs = @["nanoidpkg"]` to the .nimble file.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/nim-lang/packages/pull/875#issuecomment-738746417

--
Anirudh Oppiliappan
https://icyphox.sh