Regression in form submissions without JS in Remix 1.8.2

What version of Remix are you using?
1.8.2
Steps to Reproduce
Remix 1.8.2

Open https://stackblitz.com/edit/remix-forms-no-js-broken
Navigate with the Broken link (this is a test page using a normal form)
Click the Test button
Observe that you are redirected to the login page and No cookies is logged to the console
Login again and navigate to the Working link (this is a test page using a Remix Form)
Click the Test button and observe that you are not redirected to the login page and the session is logged to the console

Remix 1.8.1

Open https://stackblitz.com/edit/remix-forms-no-js-working
Navigate with the Broken link (this is a test page using a normal form)
Click the Test button
Click the Test button and observe that you are not redirected to the login page and the session is logged to the console
Login again and navigate to the Working link (this is a test page using a Remix Form)
Click the Test button and observe that you are not redirected to the login page and the session is logged to the console

You can also recreate the issue on the "Working" page of the Remix 1.8.2 version by disabling JS and clicking the Test (you get redirected)
Expected Behavior
Form submissions should work the same, with or without JavaScript, and I should be able to access the cookies regardless of whether I use form or Form
Actual Behavior
Disabling JavaScript or using a plain old form means that I have no headers in the Request when submitting a form and I can therefore not validate that the user has a session.

I'm pretty sure this is a duplicate of https://github.com/remix-run/remix/pull/4826, which is fixed in 1.9.0-pre.0 - would you mind seeing if that resolves your issue?  I think we're planning to release the stable 1.9.0 today

I'm pretty sure this is a duplicate of https://github.com/remix-run/remix/pull/4826, which is fixed in 1.9.0-pre.0 - would you mind seeing if that resolves your issue?  I think we're planning to release the stable 1.9.0 today

Apologies! Didn't see that issue when I did a search, will test 1.9.0 and let you know. Thanks for your speedy response! 🙂

I can confirm that this is fixed in 1.9.0-pre.0 (https://stackblitz.com/edit/remix-forms-1-9) so I'll close this issue and look out for 1.9.0 being released 🙂 Thanks again!


Missing MITRE ATT&CK tactics

Background
When MITRE ATT&CK techniques are added in T#### format instead of TA####:T#### it breaks the UI.  See this PR for more details
Changes

added missing MITRE ATT&CK tactics to the rules

Testing

make test

Found a set of other mappings that don't match this pattern. Do we need to update these too?
queries/aws_queries/aws_potentially_compromised_service_role.yml
    T1528
correlation_rules/okta_login_without_push.yml
    T1212
    T1539
correlation_rules/aws_privilege_escalation_via_user_compromise.yml
    T1098.001
correlation_rules/aws_potentially_compromised_service_role_cr.yml
    T1528
correlation_rules/aws_user_takeover_via_password_reset.yml
    T1098.001
correlation_rules/secret_exposed_and_not_quarantined.yml
    T1552.001
correlation_rules/potential_compromised_okta_credentials.yml
    T1212
    T1539
rules/crowdstrike_rules/event_stream_rules/crowdstrike_api_key_created.yml
    T1098.001
rules/crowdstrike_rules/event_stream_rules/crowdstrike_api_key_deleted.yml
    T1531
    T1070
rules/gcp_k8s_rules/gcp_k8s_pod_create_or_modify_host_path_vol_mount.yml
    TA0001
    TA0002

Good catch!  Updated.


Backtick hightlight errors vue html pug ts/js

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.93.1
OS Version: windows 11

Steps to Reproduce:
In vue has error backtick highlighting (pug or html)

And typescript/js too

Can you file the vue issue against the vue extension that you are using? Maybe https://github.com/vuejs/vetur ?
For TypeScript, can you paste the code snippet?

  const cli = createClickHouseClient({
    url: `http://${E.config.connections?.clickhouse?.host ?? 'clickhouse'}:${E.config.connections?.clickhouse?.port ?? 8123}`,
  })
  cli.insert({
    table: table,
    values: dataToSave,
    format: 'JSONEachRow',
  }).then((res: any) => {
      cli.close()
  })

No, use vue official
https://github.com/vuejs/language-tools

Can you file the vue issue against the vue extension that you are using? Maybe https://github.com/vuejs/vetur ?
For TypeScript, can you paste the code snippet?

I create issue
https://github.com/vuejs/language-tools/issues/4877

vuejs/language-tools#4877

And they close =/
I d'ont understand it vscode bug or plugin
In phpstorm this construction supports

Every language has different syntax highlighting grammars and the grammars are maintained by different projetcs.
Thanks for the typescript sample.

all looks correct to me here. The back tick has a variable with typesrcipt code in it.
What is wrong in your opinion?

Yes this code work good, but they break highlighting after

  E.lEngine(`Save to cl ${table}`, dataToSave)
  const cli = createClickHouseClient({
    url: `http://${E.config.connections?.clickhouse?.host ?? 'clickhouse'}:${E.config.connections?.clickhouse?.port ?? 8123}`, // - a ClickHouse instance URL. Default value: http://localhost:8123
    request_timeout: 60_000,
    clickhouse_settings: {
      min_chunk_bytes_for_parallel_parsing: '52428800',
      wait_end_of_query: 0,
    },
    keep_alive: {
      enabled: true,
    },
    compression: {
      response: true,
      request: true
    }
  })
  cli.insert({
    table: table,
    values: dataToSave,
    format: 'JSONEachRow',
  }).then((res: any) => { // @ts-ignore
    cli.close()
  })

I cannot confirm
you must have another extension that's causing it
run editor.action.inspectTMScopes, click on the green area and send screenshots

I don't see that either.

Can you confirm that the editor mode of that file is 'TypeScript'? You run without any extensions?

After disable plugins and update vscode probltm is gone. Thans!


ACME account registration rejected due to missing TOS field

Hi,
We are running cert-manager against our acme-proxy acme2certifier that requires an acceptance of the terms-of-service during account registration. According to RFC8555 this can be achieved by sending the field “termsOfServiceAgreed” with value “True” in the body of the account registration request.
Is there an option we can set as part of the Issuer configuration forcing cert-manager to include this field?
Thank you for your help and have a nice day.
/G.
Environment details::

cert-manager version; v0.15.1
Install method with regular manifests

/kind bug

We should already do this in https://github.com/jetstack/cert-manager/blob/46eaf3d1a4b5e977b612393300f0f11978ebf72e/pkg/issuer/acme/setup.go#L321
Not sure why acme2certifier is not accepting this.
Does it use anything like EAB? Do you have any error logs where this is shown? Thanks!

Are you by any chance requiring the acceptTOS field on onlyReturnExisting: "true" requests as well? If an account is already registered, a call to this endpoint should return a Location header pointing to the registered account URL (as well as potentially a copy of the Account object).
We have not seen this kind of report against other ACME server implementations, and we currently run our end-to-end suite with the Pebble ACME server in strict mode, so I suspect that this is a bug/divergence from the spec in your own ACME implementation rather than in cert-manager.

I did some further investigation. It seems that cert-manager sets the "termsOfServiceAgreed" field only if there is a "termsOfService" - url being part of the response to a directory resource request. Although this behavior is different than the one from other acme-clients it makes perfectly sense.
We adapted the behavior in acme2certifier and where able to register an account successfully.
Thank you for help.


AZURECP :-The table is not keeping the "Email" value, the cell return to empty after clicking on save

Reference to same issue raised by Custom domains allowed?  #45
Issue found in the in the AzureCP Claim types configuration in central admin: http://server_name/_admin/azurecp/ClaimTypesConfig.aspx

The issue is that after configuring the AzureCP on SP 2016 On-Premise the email address not gets populated as soon as the user is added by people picker. As a result invitation emails are now working for these users too.
Any solution please.

You changed the default configuration and associated the metadata Email with the Azure AD property UserPrincipalName.
But it should be associated with the Azure AD property Mail instead, as done by default:

Hello Yvand,
Thank you so much for your prompt reply and suggestion.
Here below are my configuration settings. can you please review and let me know where i am wrong setting it up. The "Work Email" not saving under Picker Entity.

Hello Yvand,
Thank you so much for your prompt reply and suggestion.
Here below are my configuration settings. can you please review and let me know where i am wrong setting it up. The "Work Email" not saving under Picker Entity.

I have sent you the User Attributes screenshot above.
here below are the AZURECP configuration. Please advise where I am wrong here.

I recommend that you configure Azure AD and the SharePoint trust as documented in this page.
In your current configuration, you use the emailaddress claim type as the identity claim type. This is different from the recommended configuration above.

Thank you.
I think the work email issue resolved now.
Sent from my iPhone

On May 5, 2020, at 11:57 AM, Yvan Duhamel<EMAIL_ADDRESS>wrote:

I recommend that you configure Azure AD and the SharePoint trust as documented in this page.
In your current configuration, you use the emailaddress claim type as the identity claim type. This is different from the recommended configuration above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank You Yvand its working. the Work Email issue resolved with new configuration. i have attacheed the new claim type configuration screenshot.
However got the following issues. Need your expert advise to fix this issue.
We have 3 tier farm.

Application Server (Running Central Admin Site and Search)
WFE1 (load balancing)
WFE2 (load balancing)
The People Picker Control not working and not giving any results when request go to WFE1.
The People Picker Control working fine on WFE2 when search for the users.
We have checked the ULS Logs on WFE1 and found the following errors multiple times...

Unexpected	[AzureCP] Cannot continue because identity claim type 'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn' set in the SPTrustedIdentityTokenIssuer 'AzureAD' is missing in the ClaimTypeConfig list.	69a34f9f-dafc-c0d8-649e-a10bf4e3a569
05/05/2020 23:31:27.32 	w3wp.exe (0x20F0)    	0x25F4	AzureCP                       	Core                          	1337

here below are my existing mapping.....
$map1 = New-SPClaimTypeMapping -IncomingClaimType "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name" -IncomingClaimTypeDisplayName "name" -LocalClaimType "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn"
$map2 = New-SPClaimTypeMapping -IncomingClaimType "http://schemas.microsoft.com/ws/2008/06/identity/claims/role" -IncomingClaimTypeDisplayName "Role" -SameAsIncoming
$ap = New-SPTrustedIdentityTokenIssuer   -Name "AzureAD"  -Description "SharePoint secured by Azure AD"  -realm $realm  -ImportTrustCertificate $cert  -ClaimsMappings $map1,$map2 -SignInUrl $wsfedurl  -IdentifierClaim "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name"

@uday30980 you just need to reset the AzureCP claim types mapping. You can do that in the central administration > security > AzrueCP claim types mapping page, and click on button Reset configuration.

Closing issue due to no response, feel free to reopen it if needed


Add notifications

Adds some notification popups for when events happen in the script
Reformat successful

Can't find executable

I've also added another one for the times when phpcbf fails and just returned the output of stderr

Thanks! I've added some minor string formatting comments to your commits, then I reconsidered and deleted them.
I think all the top line messages need terminal punctuation. Initially I thought this should be a colon to indicate details follow, but I now think for consistency it should be a period.
So, please add periods (full stop) to the end of each addError/addSuccess message.

Hey sorry I will get these changes and the other prs added in a future pr :+1:

No problem - I had a few minutes so I just went ahead and did it. Let me know if everything is working for you. It's all in 0.2.0.
Thanks for the PRs!


Open generic types shouldn't have parameter names included

For example:
var type = typeof(IEnumerable<>);
Console.WriteLine(type.GetFormattedName());
// => IEnumerable<T>

Since the type parameter name T isn't mentioned in C# code, it probably shouldn't end up in the formatted string, either.

Done in 2e23fb69d0d946fabd49ebb34baefafccd6b33a1.


Google 'azure storage sdk', the top results all point to track 1 SDKs

Some suggestions

Have clear announcements in track 1 SDK pages (github repo, readthedocs.io sites, etc.) and point users to track 2 SDKs.
Can we do something to change google search results? e.g. if SEO work helps?

We were just discussing that earlier today. @tamram and @rishabpoh are supposed to sync later to discuss what are the options here and share the knowledge.

@twooley - FYI. The repositories for the legacy client librarys (pre-v12) are often showing up in search before the v12 repos or docs.ms content.
While this is not something we can solve directly, we can update our references to the repos in the docs and TOC to diminish the SEO power of the older repos.
Any other ideas are welcome.

Update: seems like it works correctly now. When I searched "azure storage sdk", the first page showed all track 2 libraries.
Close.


Add pre-commit config and a new workflow to run the pre-commit hooks on any PR

Linked Issue(s)

Closes #502
Acceptance Criteria fulfillment

[x] Create a .pre-commit-config.yaml file and add the custom listing logic there
[x] Create the GH workflow that will run the pre-commit action
[x] Format the entire codebase with pre-commit hooks

Proposed changes (including videos or screenshots)

Change the scripts command in package.json of both node sub dir(cli/ and web-server/). As eslint should be ran with a proper path. Earlier running yarn lint resulted in nothing because paths were not configured
Introduced pre-commit to Run before committing anything. As of now, I have setup for only linitng and formatting files before committing. I can integrate more pre-commit hooks if you want one. But these are the ones I think are necessary.
Added a new GH workflow to run the pre-commit hooks.(Just saying it would have been a little simpler if both web-server/ and cli/ used the same version of node)(So I setup two node versions in the workflow)

Further comments

I tested this with a test PR. Though you see the hooks failed there, but I created that PR to see if the workflow setup runs correctly or not. It does work.
Now After you review this PR, I will also push the formatted files(Not pushing now as reviewing would be gnarly for the maintainers)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Just so you know we dont need a separate black workflow with this one.
Feel free to close it if the feature is not desired for now:)

Hey @thesujai, thanks for your contribution!
I'm curious about why flake8 was introduced instead of just using black.

One of the checks failed. Interesting.
If you could look into sorting it out (our team will help), we'd love to accept this PR. 🤝

Hi @jayantbh for a quick review
Flake8 does so much more than just lining the code(It checks for unused imports, also potential bugs!)
Like for eg the below code will be given a green flag by black:
import os
print("Hello")

But flake8 will throw an F401(Imported but not used) as the os module is imported but never used.
For now black ignores such best practices and focuses on PEP8 guidelines(Which don't include a F401 type thing!). So most error thrown by flake8 should be manually fixed(As no library I know of does things like this automatically)

One of the checks failed

Yes, it is supposed to fail, I just introduced it with this PR. It will pass once I push all the formatted files(formatted by the pre-commit hooks). I am not pushing now as reviewing would be really irritating with so many lint-fixed files

Sounds good. I'd like @samad-yar-khan and @adnanhashmi09 to confirm if flake8 plays well with our dev setup, so we can replace black with it.

I am just bad with explaining my thoughts
More like having flake8 along with black(as black is just the formatter, flake8 is just a checker). But both of these we will have as pre-commit hooks(with the pr introduces).
Just the think to remove will be the black github action, as black will be ran as the last hook of pre-commit with the new pre-commit workflow.

@thesujai there's a conflict, and a failing lint test.

@jayantbh It should work now. I rebased it with main.
Any changes in the upstream will again make the workflow to fail if this gets merged, so we have to make sure this is up to date with main before it is merged(it is now!)

Hey @thesujai, this PR is currently on pause because we're waiting for some other PRs to get merged to avoid rework on them. We'll take it up again in 1-2 days.
Apologies for the slow movement on this.

Add the related docs as well(Pardon the grammar there 🙃 )

Thanks! I've triggered the workflows.

@thesujai Got it. Thanks for the clarifications. We should have a followup PR to have these comments removed. But for now it looks good to me.

So, it tells me whats wrong but shouldn't the precommit hook fix these for me ?

I can add autoflake for that

I missed this, but yeah a linter should absolutely try to fix as many issues automatically as it can.

Preferably, if someone is using /.dev.sh for dev, they are looking to change the code. See if we can get them to install the precommit at the top rather than potential misses and a lint commit at the end when they discover the precommit hook

I don't understand what you trying to say here. Let me know if the latest commit solves your concern!

Preferably, if someone is using /.dev.sh for dev, they are looking to change the code. See if we can get them to install the precommit at the top rather than potential misses and a lint commit at the end when they discover the precommit hook

I don't understand what you trying to say here. Let me know if the latest commit solves your concern!

Hey @thesujai , that last commit solves a part of the problem of automatic linting with pre-commit hook. This still does not solve the effort of manually installing python dependancies just to run the precommit hook.
Currently our dev setup only requires the user to use the ./dev.sh to develop using docker. All things needed by the dev setup should be a part of that script. This means, if I use dev.sh, it should automatically check if I need to install precommit hooks or any dependancies, install them at system level or in a virtual env and activate venv (in case of python) and let the dev build and commit without having to manually go and install these just to commit.

@samad-yar-khan I updated the PR

@thesujai I see the updated dev.sh, nice work on that. I don't have to install python packages now. But, its not working for me. Also, one of the linting workflows is failing.
https://github.com/user-attachments/assets/ebfcc4bd-330c-4484-963c-19c1ea1b2fb5

@samad-yar-khan What node version were you using?

Was previously using 18, now using 16.19.1

From here it looks like your cli/ had node modules installed, but not your webserver/.
We can configure dev.sh to also install the node_moduels(locally, not in a docker container), but this would mess up the current workflow where node_modules are getting installed into docker containers.
I suggest doing this but only adding eslint(and other linting tools) to the dev.sh workflow that will install node_modules(only with required tools) locally. But this would be extra work to keep maintaining the tools versioning in package.json as well as the dev.sh script.
Let me know if you have other ideas.
How I like to view things is that development is one thing and contributing is another.

Just like in this workflow, I am installing the lining tools for webserver/ then for cli/ here

Can't we just use docker volumes to map the node_modules and python dependencies to the host's filesystem?

Possible, but there are some tradeoffs:

It might compromise the container’s isolation by exposing dependencies to the host. The major advantage of Docker is keeping dependencies isolated within the container.
Docker volumes can cause compatibility problems across different OSs, especially with node_modules. The docker base image isn't the same as host OS.

Possible, but there are some tradeoffs:

It might compromise the container’s isolation by exposing dependencies to the host. The major advantage of Docker is keeping dependencies isolated within the container.
Docker volumes can cause compatibility problems across different OSs, especially with node_modules. The docker base image isn't the same as host OS.

Yeah makes sense. To run the linting process we would have to install node_moduels and python dependencies anyhow. Maybe we could remove it from the dev process and add to the contributing docs. This is making things a little messy in my opinion.
@jayantbh Thoughts?

@thesujai I'd say let's remove the installation of linters from the dev process and make this a part of CONTRIBUTING.md. We'd leave the installation of linters to the contributors and just give them steps how to do that.

Clean now, rebased with main branch as well

@adnanhashmi09 should work?

Amazing. This was a trip. 🚀🚀🚀
Great work @thesujai 👏


Find the right place for bosh-package-java-release and bosh-package-cf-cli-release

With Consolidate bosh-packages and bosh-io into cloudfoundry github org the FI WG got two repositories which don't really belong to the WG. This pr suggests a possible move but our intention is to start a discussion to find right place for them. cc @rkoster & @jpalermo

Seems good to me, but it would also be good to have somebody from those WGs weigh in too.

@dmikusa or @anthonydahanne could you please comment regarding the move of cloudfoundry/bosh-package-java-release?
@reedr3 or @a-b could you please comment regarding the move of cloudfoundry/bosh-package-cf-cli-release?

Adding @pivotal-david-osullivan for cloudfoundry/bosh-package-java-release

@beyhan @rkoster What is the rationale for moving bosh-package-java-release out of FI, but not the other language packages (package-ruby-release, package-golang-release, etc)?

The java package according to bosh.io is only being used by the autoscaler: https://github.com/cloudfoundry/app-autoscaler-release/tree/main/packages/openjdk-17
Maybe it would be more appropriate to move it into the Autoscaler area.

Right, but what is the reason for moving some of the bosh-package-* releases out of FI?
Why is bosh-package-ruby-release staying in FI? Just because BOSH uses it?
Why is bosh-package-python-release, for instance, staying in FI?
What if another release wants to start using bosh-package-java-release?

We certainly know that FI has no expertise with the java package or bosh releases using java or how these packages should be built.
It would be good to have an owner that has a vested interest in it, but maybe that doesn't exist...

The alternative is to archive bosh-package-java-release, given that we have no approvers in the FI working group who have context on this release (UAA & Credhub do not use it).

What is the history for why that package was introduced in the first place? Just for language completeness?

I don't the history. @jpalermo, @rkoster do you know?

Don't have the full history, but based on some old tracker stories (with virtually zero details), the commit history, and some wild speculation; my guess would be it was created because we were doing it for other languages and we had at least one bosh release using Java.

we had at least one bosh release using Java

Which release was it?

Looks like UAA/Credhub have never used it. It was used by a closed source release from 2018 to 2020, and then app autoscaler has been using it since 2022.
2018 isn't TOO far off from when it was created, but it was ~9 months after.
So my guess is it was created because we had some Java releases, primarily UAA/Credhub, and they never adopted it.

I would suggest then to archive the bosh-package-java-release.

If we did want to archive it, we'd need to give app-autoscaler-release a chance to move off of it first.

Should we consider transferring ownership to the ARI Autoscaler area then?

Hi @silvestre,
With the implementation of https://github.com/cloudfoundry/community/pull/512 the FI WG got the bosh-package-java-release repository which is not used in the FI WG and we don't have expertise to maintain this repository. It looks like the ARI Autoscaler area is the only use of this repository. Do want to take ownership of this repository? The alternative is to archive it.

Hi @beyhan, @Gerg,
thanks for reaching out!
As app-autoscaler-release is the only user, I don't think it makes sense for us to maintain this but we will switch back to packaging Java ourselves.
Feel free to archive it at any time.

Thanks @silvestre for the response. Based on the discussion I open https://github.com/cloudfoundry/community/pull/687 to archive bosh-package-java-release. I will close this pr because it includes more things than just the bosh-package-java-release.


Setting Stripe Publishable Key dynamically

I have an integration which requires multiple stripe accounts to be used. The publishable keys are stored in the database. When I am ready to generate the stripe token, I m calling the setPublishableKey with the appropriate key for that account. It seems that only the first publishable key that was set can be used to do further credit card processing to generate the token. Can this be enhanced to allow multiple stripe accounts to be used? Stripe supports that and allows that. Can you provide your input on this? Thanks for all your hard work and effort.

Just call setPublishableKey.. Every time you call that method, it changes the key for any subsequent API calls.

Ibby,
I appreciate your prompt response. In doing further testing, I realized
this is issue on IOS only. It works perfectly in Android. Is this something
you can look into? We are about to go live and this will stop us. I will
really appreciate your help in this matter. Thanks.
On Wed, Jun 7, 2017 at 4:03 PM, Ibby Hadeed<EMAIL_ADDRESS>wrote:

Just call setPublishableKey.. Every time you call that method, it changes
the key for any subsequent API calls.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zyra/cordova-plugin-stripe/issues/18#issuecomment-306924296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT4jvUS-9iFGNdrk-kC23KjvNa2yPiJJks5sBxAygaJpZM4NzQED
.

I have fixed the issue. in CordovaStripe.m, I commented out the check to see if client is nill before initializing the client. This way, it will initialize it everytime and get new publishable key everytime. I am sure there is a better way to fix it but this was quick and dirty for me.

Just pushed a commit to fix this. If a stripe client already exists, it will update the publishable key for that instance as well. No need to recreate the client every time.
Thanks for pointing this out!


Rename array contains to includes

In JavaScript array there is an includes method, it catches me out that the same functionality has a different method name in minim. I think we should align the name.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes

👍 . Go ahead with the PR.


Adopt sphynx style for API documentation.

[x] hfc/fabric
[x] hfc/utils
[x] hfc/fabric_ca
[x] hfc/fabric_network
Signed-off-by: K mehant<EMAIL_ADDRESS>

@dexhunter
As these are huge changes in terms of number of lines. I would request you to give a casual review on the work so far so that I can continue on the other parts.

@dexhunter I have completed it, Please review!

Some flake8 errors need to be fixed
[31064] /home/vsts/work/1/s$ /home/vsts/work/1/s/.tox/flake8/bin/flake8 hfc test test --exclude=protos
hfc/fabric_ca/identityService.py:22:109: W291 trailing whitespace
hfc/fabric_ca/identityService.py:25:121: E501 line too long (131 > 120 characters)
hfc/fabric_ca/caservice.py:639:59: W291 trailing whitespace
hfc/fabric_ca/certificateService.py:32:121: E501 line too long (165 > 120 characters)
hfc/fabric/user.py:179:28: W291 trailing whitespace
hfc/fabric/channel/channel.py:199:28: W291 trailing whitespace
hfc/fabric/channel/channel.py:215:28: W291 trailing whitespace
hfc/fabric/channel/channel.py:236:28: W291 trailing whitespace
hfc/fabric/channel/channel.py:1091:25: W291 trailing whitespace
hfc/util/utils.py:307:31: W291 trailing whitespace
hfc/util/utils.py:323:30: W291 trailing whitespace
hfc/fabric_network/inmemorywalletstore.py:20:31: W291 trailing whitespace
hfc/fabric_network/wallet.py:81:23: W291 trailing whitespace
ERROR: InvocationError for command /home/vsts/work/1/s/.tox/flake8/bin/flake8 hfc test test --exclude=protos (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   flake8: commands failed

@dexhunter Fixed :)

Thanks for your contribution! @kmehant


Vulnerability roundup 112: cri-o-1.22.1: 1 advisory [8.8]

search, files

[ ] CVE-2022-0811 CVSSv3=8.8 (nixos-21.11)

CVE details
CVE-2022-0811
A flaw was found in CRI-O in the way it set kernel options for a pod. This issue allows anyone with rights to deploy a pod on a Kubernetes cluster that uses the CRI-O runtime to achieve a container escape and arbitrary code execution as root on the cluster node, where the malicious pod was deployed.

Scanned versions: nixos-21.11: efea022d6fe.
Cc @adisbladis
Cc @kalbasit
Cc @saschagrunert
Cc @vdemeester
Cc @zowoq

21.11 is EOL.


Publish as Godot addon

Once the quality is decent enough, it's useful to release the plugin for the Godot AssetLib and inform on social media about the release

Done!
https://godotengine.org/asset-library/asset/692


Update app-insights-code-sample-export-telemetry-sql-database.md

Added the class definition for Pageviewperformance

Hi @arunvinoth, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@arunvinoth, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;


bug: after restarting the engine, the same step gets executed twice, leading to unexpected behavior

After restarting the engine, the same step gets executed twice, leading to unexpected behavior. Below are the steps to reproduce this issue and the observed logs highlighting the problem.

Run the engine: In Terminal 1, execute docker compose up.
Start the worker script: In Terminal 2, run the worker script.
Start the client script: In Terminal 3, run the client script (just call run_workflow).
Wait for one minute, then kill the engine with docker compose down.
Wait another minute and start the engine again using docker compose up.

Upon restarting the engine, the logs indicate a doubled execution of the same step:
2024-06-04T12:33:50.018Z: Step 1
2024-06-04T12:33:50.036Z: Input: {'items': ['c']}
2024-06-04T12:33:50.05Z: Processing 0
2024-06-04T12:33:55.023Z: Processing 1
2024-06-04T12:34:00.025Z: Processing 2
2024-06-04T12:34:05.026Z: Processing 3
2024-06-04T12:34:10.027Z: Processing 4
2024-06-04T12:34:15.027Z: Processing 5
2024-06-04T12:34:20.029Z: Processing 6
2024-06-04T12:34:25.032Z: Processing 7
2024-06-04T12:34:30.033Z: Processing 8
2024-06-04T12:34:35.036Z: Processing 9
2024-06-04T12:34:40.036Z: Processing 10
2024-06-04T12:35:30.05Z: Processing 20
2024-06-04T12:35:34.453Z: Step 1
2024-06-04T12:35:34.464Z: Input: {'items': ['c']}
2024-06-04T12:35:34.471Z: Processing 0
2024-06-04T12:35:35.055Z: Processing 21
2024-06-04T12:35:39.455Z: Processing 1
2024-06-04T12:35:40.058Z: Processing 22

The workflow simulates a long running operation:
@hatchet.workflow(name="long-workflow")
class LongWorkflow:
    @hatchet.step(name="step1", timeout="1h")
    def step1(self, context):
        context.log("Step 1")
        context.log(f'Input: {context.workflow_input()}')
        for i in range(60):
            context.log(f'Processing {i}')
            context.put_stream(f'Processing item: {i}')
            context.sleep(5)
        context.log('Done sleeping, returning')
        return {"result": "success"}

python sdk: hatchet_sdk-0.24.0
Question
Is this behavior intentional, or is it a bug? The expectation is that after restarting, the steps should either continue from where they left off or start over completely, not both.

Hey @rbtbar, this is not expected behavior. When we lose connection with the worker, we will reassign work after a visibility timeout of 30 seconds. It seems that when the engine is starting up, we are checking the reassignment immediately, which will always be triggered since the workers haven't connected yet. We'll patch a fix to set a delay on checking for reassignments to give the workers a chance to reconnect.
A few additional questions:

We've been planning to have reassignments trigger the retry loop (they currently bypass the retry loop), which means we'll only reassign work if you have set retries greater than 0. Thoughts on the ideal behavior here?
Just to be sure, which version of the hatchet-engine are you running in docker compose?

Additionally, the latest version of the Python SDK is 0.26.1 (though this shouldn't impact the behavior here)


WIP: Restructuring to enable multiple rows, multiple access points, and unit tests

This is an attempt to go beyond the simple use cases and consider a realistic case of a user submitting a list of products as either an astropy.Table or pyvo.dal.DALResults.
Both a json column and datalinks are processed to create a list of AccessPoint objects for each row of the data product.
AccessPoint and its subclasses (for aws, gc etc) have a download method that downloads the data

I have an implementation that integrates this into pyvo. It is in my pyvo cloud-links branch.

@zoghbi-a - a lot of it is already massaged into pyvo in https://github.com/astropy/pyvo/pull/369, I'll come back to that PR and chop it up to smaller pieces.

Thanks @bsipocz,
Yes https://github.com/astropy/pyvo/pull/369 does the json part. The datalinks part that I added is clunky and I plugged it in as proof of concept only. This restructuring allows both (json and datalink methods; plus others if needed, e.g. a column with s3 uris) to be done cleanly both for a single row and for a set of rows. This latter point is important, because for datalinks, it is inefficient to make a datalink call for every row. It is more efficient to make a single call requesting all datalinks. The restructured code allows that.
One other difference is how to deal with services other than SIA, which we want to consider in the future. With what we have, it is not straight forward to expand it to SSA and other services. With the new code, it is a matter of adding a single inheritance to the relevant service or Query class.

This will be closed in favor of a other PRs (#21 and #22).


Can't login "sign verification failed"

Hello,
Since this morning, I can no able longer connect in to my account anymore. See home assistant errors:

But I can still use the mobile app with same username/password.
Do you have any idea of what's going on ?
Thanks in advance,
Best regards,

Also seeing this:
Traceback (most recent call last):
 File "/path/to/homeassistant/custom_components/sonoff/__init__.py", line 156, in async_setup_entry
   await registry.cloud.login(username, password)
 File "/path/to/homeassistant/custom_components/sonoff/core/ewelink/cloud.py", line 150, in login
   raise AuthError(resp["msg"])
custom_components.sonoff.core.ewelink.cloud.AuthError: sign verification failed
WARNING (MainThread) [homeassistant.config_entries] Config entry '<email address>' for sonoff integration could not authenticate: sign verification failed

A little bit of digging gets me:
{'data': {}, 'error': 400, 'msg': 'sign verification failed'}
as the contents of resp
Home Assistant is coming straight from latest git, though I don't think that' particularly playing much of a part here, SonoffLan is the tagged 3.0.5.  I do have mode: local set in my configuration file

I have the same problem…

After upgrading to newest beta it asked to to reconfigure. It won't accept my login credentials whic I'm positive are correct

Same here

Same here, I rolled back my home assistant to 2022.6.7, it worked properly.  This only happened when upgraded to 2022.7.0.b2 (beta).   Devices with local (LAN) sonoff enabled still works.
WARNING (MainThread) [custom_components.sonoff] Can't login with mode: auto
Traceback (most recent call last):
 File "/config/custom_components/sonoff/__init__.py", line 156, in async_setup_entry
   await registry.cloud.login(username, password)
 File "/config/custom_components/sonoff/core/ewelink/cloud.py", line 150, in login
   raise AuthError(resp["msg"])
custom_components.sonoff.core.ewelink.cloud.AuthError: sign verification failed

I have the same issue on beta 2022.7.bxx

Downgraded. Same issue. Not only with this integration btw.

Downgraded. Same issue. Not only with this integration btw.

Ended up downgrading too....many other components failed too (my vacbot and other sign in warnings)

I thought this might be an expired app id + app secret, but I've swapped out a few that SEEM to be working elsewhere, and I'm continuing to run into the same problem with those.  I've double checked the calculation for the authentication and it looks right to me given the examples I can find.  Best guess, is there's something else required in the payload and it's complaining about the verification that way, unfortunately I don't see a way to get past that without some additional guidance on what's, now, missing.  I did take a look at the CoolKit ha-addon to see if I could see anything obvious, and so far my poking through the code from that isn't yielding anything (also unfortunately, that add-on plays havoc with trying to run it on core)

I've added two debug lines to capture what is sent and received upon login. I replaced username and password, and replaced 10 characters of the sign with xxxxxxxxxx, No other format changes to the output:
2022-06-30 14:18:11 DEBUG (MainThread) [custom_components.sonoff.core.ewelink.cloud] Hmmbob debug: Host: https://eu-apia.coolkit.cc/v2/user/login | json: {'password': '--contains my actual password--', 'countryCode': '+86', 'email': '--contains my actual email--'} | headers: {'Authorization': 'Sign 4vmH1ALSoy0BEmF/7yb/geaxxxxxxxxxxLaoo7aGe4k=', 'X-CK-Appid': 'oeVkj2lYFGnJu5XUtWisfW4utiN4u9Mq'}
2022-06-30 14:18:11 DEBUG (MainThread) [custom_components.sonoff.core.ewelink.cloud] Hmmbob debug: {'error': 400, 'msg': 'sign verification failed', 'data': {}}

Could someone try to delete integration (and clean up all traces of the component in ha folders) and re configure it to see if that works?

Could someone try to delete integration (and clean up all traces of the component in ha folders) and re configure it to see if that works?

Deleted Sonoff LAN Integration
Removed folder custom_components/sonoff
Removed file .sonoff.json
Restarted hass 2022.7.0b0
Redownload from HACS the Sonoff LAN
Restarted hass 2022.7.0b0
Tried adding the Sonoff integration back
Same error:
Sign verification failed

We did switch from python 3.9 to python 3.10 so that could be in play here

Verified the json payload is exactly the same between 2022.6.6 and 2022.7 so not json
but I like the python version changing as a potential source since many of the encryption libs changed

Headers are exactly the same between 2022.6.6 and 2022.7.0b0
2022.6.6 responds:
2022-06-30 15:21:43 WARNING (MainThread) [custom_components.sonoff.core.ewelink.cloud] resp: {'error': 10004, 'msg': 'request redirection', 'data': {'region': 'us'}}
2022.7.0.b0 responds:
2022-06-30 15:22:54 WARNING (MainThread) [custom_components.sonoff.core.ewelink.cloud] resp: {'error': 400, 'msg': 'sign verification failed', 'data': {}}

Switching the payload order to the one shown on https://coolkit-technologies.github.io/eWeLink-API/#/en/DeveloperGuideV2 and removing the spaces in the separators fixed it for me

That error code is well known: https://github.com/AlexxIT/SonoffLAN/blob/c317407a09e5c5e9aaf2a95e044e5afb5a367dec/custom_components/sonoff/core/ewelink/cloud.py#L141
I guess it's part of successful logon flow (and you are probably not EU based)

@bdraco do you have a quick patch I can toss on mine and check here?

@warthog9 Can you test the linked PR?

@bdraco yup, that sorted it for me

@bdraco, thanks it worked after modifying the cloud.py file

Yup, fixed

@bdraco Same here: fixed
additional question: why countryCode is a constant value?

Because it's not allowed to be empty:
https://coolkit-technologies.github.io/eWeLink-API/#/en/APICenterV2?id=login

@hmmbob shouldn't there be real value then? The one I give when logging in to the original eWeLink application?

The countrycode is used server side to determine which region you 'belong to'. This component actually doesn't use logic for that, but ensures that you're redirected automatically to the correct region, if your region is not China.
So, "maybe" is the answer here ;-)

I'm with HA 2022.6.6, and latest Sonoff integration, but I changed my eWelink password, both in the app and in HA config file.
Then I started getting the same error.
Copying over the cloud.py file didn't fix the issue, so I reverted to the previous password and got access again.

TPLINK integration and SONOFF integration report the same error "Sign Verification Failed"

The pull request above fixes it for me.

The availability of the maintainer to review and publish?

Thanks @AllexIT for your prompt support :)


[Bug]:  False negative (instanceof Float32Array)

Version
27.1.1
Steps to reproduce
I prepared an example here, simply run npm install then you have the node run.js that shows the expected behavior (without jest), and npx jest will show the behavior when running in jest.
Expected behavior
In this instance I expected that Float32Array created by native code to be instanceof Float32Array.
Actual behavior
It seems that jest redefined Float32Array globally, maybe we could simply surround commands like this by some function that would restore the native functions. jest.withNativeTypes( () => do my test )
Additional context
onnxjs is a frame work to evaluate neural network models in the format ONNX, it supports
different backends. onnxjs-node enables the use of onnxruntime in onnxjs.
These libraries use tensors objects, a tensor class is a multidimensional view of a typed array.
The outputs of a neural network are constructed in NAPI as typed arrays
[1].
Both the native code and javascript code have typed array maps [2],[3], and the javascript code checks if the value
returned is an array of the expected type[4]. Normally this works, but if we invoke this from a jest test, that check will evaluate to false,
and finally it will throw an error[5].
Environment
For a way to reproduce, check Dockerfile, and docker-compose.yaml.

I've come across this problem too. It appears to be related to/a recurrence of: https://github.com/facebook/jest/issues/10786, which also replicates for me in version 27.3.1.

Hello,
I had this same problem, and after a lot of tinkering I eventually found a workaround.
As far as I can tell, the problem happens because Jest uses the module node:vm to run tests. This module allows running JavaScript code in a different V8 context. The module onnxruntime doesn't recognize the instances of Float32Array because they were defined in another VM context. Their constructor is different from the Float32Array of the current context, so the operator instanceof returns false and an exception is thrown.
For some reason, the utility functions in the module node:utils/types seems immune to this problem : they return the correct result no matter which VM context the argument comes from.
I ended up making use of Symbol.hasInstance to overload the instanceof operator.
It's not a clean solution, but it works, and it allows me to run my model using Jest.
// Import Node typing utilities
import * as types from "node:util/types";

// Import onnxruntime-node's default backend
import { onnxruntimeBackend } from "onnxruntime-node/dist/backend";
import { registerBackend } from "onnxruntime-common";

// Define the constructors to monkey-patch
const TYPED_ARRAYS_CONSTRUCTOR_NAMES = [
  "Int8Array",
  "Int16Array",
  "Int32Array",
  "Uint8Array",
  "Uint8ClampedArray",
  "Uint16Array",
  "Uint32Array",
  "Float32Array",
  "Float64Array",
] as const;

// Keep a reference to the original initialization method
const originalMethod = onnxruntimeBackend.init;

// Monkey-patch the initialization function
onnxruntimeBackend.init = function (...args) {
  // There is probably a better way to do this
  Array.isArray = (x: any): x is any[] =>
    typeof x === "object" &&
    x !== null &&
    typeof x.length === "number" &&
    x?.constructor.toString() === Array.toString();

  // For each typed array constructor
  for (const ctorName of TYPED_ARRAYS_CONSTRUCTOR_NAMES) {
    // Get the constructor from the current context
    const ctor: Function = global[ctorName]!;

    // Get the corresponding test function from the `util` module
    const value = types[`is${ctorName}`].bind(types);

    // Monkey-patch the constructor so "x instanceof ctor" returns "types[`is${ctorName}`](x)"
    Object.defineProperty(ctor, Symbol.hasInstance, {
      value,
      writable: false,
      configurable: false,
      enumerable: false,
    });
  }

  // Call the original method
  return originalMethod.apply(this, args);
};

// Register the backend with the highest priority, so it is used instead of the default one
registerBackend("test", onnxruntimeBackend, Number.POSITIVE_INFINITY);

I hope this code can be useful to other people who have the same problem.

Anything new on this issue? The work around by @m-r-r works nicely, but this can't be a viable long-term solution.

Also just bumped into this issue. Would be nice to have a proper fix for it.

I hit this issue as well. I couldn't get the above workaround to work, so I solved it by mocking Array.isArray. Details are here in case it helps anyone.

I don't know whether there should be a general fix in testjs, or onnxruntime should submit a fix for compatibility for supporting testjs.
Is the tfjs PR mentioned above (https://github.com/tensorflow/tfjs/pull/7181) a good example for enhance test compatibility?

FWIW, this is essentially a duplicate of #2549, like https://github.com/jestjs/jest/issues/11864#issuecomment-1261468011 touches upon


⚠ SceneTime has degraded performance

In d60075b, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1859 ms

Resolved: SceneTime performance has improved in eb0acc1 after 6 minutes.


feat: HTTP traffic should be routable to the user services using more than one Host header format

Background & motivation
The request Host header reaching the user service should match the original request Host header so URLs generation and redirects work correctly.  This should happen locally and in the cloud.
Desired behaviour
Traefik routes http traffic to the user services.  The user service Host header label should accept the following two formats:

<port number>.<service short uuid>.<enclave short uuid>
<port number>.<service short uuid>.<enclave short uuid>.<cloud instance short uuid>.<subdomain>

Method to update: https://github.com/kurtosis-tech/kurtosis/blob/c640c5eae57429de2a827e64de0175a111fc298d/container-engine-lib/lib/backend_impls/docker/object_attributes_provider/enclave_object_attributes_provider.go#L533
How important is this to you?
Critical; Kurtosis is unusable for me without it.
What area of the product does this pertain to?
Other: anything not covered by the above

It was fixed with those PRs, and it supports retro-compatibility.

@leoporoli was this tested?
I'm not sure if the Traefik Golang Regexp for Host matching HostRegexp({^name:80-3771c85af16a-65d2fb6d6732-?.*$}is correct? Is the caret ^name` part of the  "arbitrarily named variable followed by the colon-separated regular expression"?
I have a kurtosis setup running on docker that I would like to use the reverse proxy feature for, but it's unusable... I'm unable to reach those hosts on the Traefik configured routes.


Enable to receive compressed request from client

Motivation:
Most of servers can send compressed response to client. But can't receive compressed request from client.
In this PR. armeria can receive compressed(gzip or deflate) request from client with Content-Encoding header
Modifications:

Add DecodingService and HttpDecodedRequest

Result:

You can receive compressed request from client

Create FilteredHttpRequest without pool is correct way?

Could you also make DecodingClient accept the StreamDecoderFactory from the common package?

Iterable<? extends StreamDecoderFactory> will be a problem due to type erasure. How about making the deprecated StreamDecoderFactory and StreamDecoder extend the new interfaces in the common package; and changing the factory methods accept the new interfaces?

This action brings some breaking changes I think. Can I do it?

Could you also make DecodingClient accept the StreamDecoderFactory from the common package?
Iterable<? extends StreamDecoderFactory> will be a problem due to type erasure.
How about making the deprecated StreamDecoderFactory and StreamDecoder extend the new interfaces in the common package; and changing the factory methods accept the new interfaces?
This action brings some breaking changes I think. Can I do it?

It only breaks ABI compatibility (not API compatibility), but I think it's fine because we're bumping minor version anyway.

Could you also make DecodingClient accept the StreamDecoderFactory from the common package?
Iterable<? extends StreamDecoderFactory> will be a problem due to type erasure.
How about making the deprecated StreamDecoderFactory and StreamDecoder extend the new interfaces in the common package; and changing the factory methods accept the new interfaces?

This action brings some breaking changes I think. Can I do it?

It only breaks ABI compatibility (not API compatibility), but I think it's fine because we're bumping minor version anyway.

I tested it by adding an import statement that reference common.encoding package and it seems to be worked. (passed all test)
DecodingClient.java
import com.linecorp.armeria.common.encoding.StreamDecoderFactory;

HttpDecodedResponse.java
import com.linecorp.armeria.common.encoding.StreamDecoder;
import com.linecorp.armeria.common.encoding.StreamDecoderFactory;

(Also, the import statement of the related test class was changed.)
How about this way?

How about this way?

Then a user will have to change his or her import statements, which is what we want to avoid. What's important is that recompiling a user's project without any source code changes should work. In the case you mentioned, the test case should be compiled even if you didn't update its import statements.

@trustin
Is this work(https://github.com/line/armeria/pull/3087/commits/be1750742c4b8a729a9d1c7d7ee376d740ec81f7, https://github.com/line/armeria/pull/3087/commits/0341e11e2c1e32ca8107f6f4776a2bc5663fa6dc) consistent with your intention?

@joonhaeng Your change looks nice. I think I explained incorrectly, but you seemed to have sorted it out anyway. I left just one minor comment. :+1:

@ikhoon @minwoox Time to take another look 😉

Looking forward to your follow-up PR, @joonhaeng! ❤

I am very happy to contribute to this awesome repository!


Remove RigidBodyTree code from build

Marks all remaining drake/attic code (RigidBodyTree) to only be built manually, and adds a deprecation warning. This code is not guaranteed to build anymore, but we can leave it for a few months until we're satisfied that it is not needed. Of course, it still will exist in git's history.
A number of lightly (or unused) programs fall into this category, including some of the KUKA-specific code. I've updated where it was just a matter of dependency cleanup, but have not re-written any examples that are fully-based in RigidBodyTree.
This update also adds the IMU sensors to Cassie.
I tried both Cassie walking/balancing examples with the EKF, but both failed. The EKF in the balancing example was clearly not working. A very quick look did not show any obvious problems with the IMU readings (near steady-state while balancing). @yminchen could you take a quick look at this branch and see if you can tell if the EKF is behaving properly, as I know this was recently updated?

@mposa Looks like the QPs for contact estimation are not giving good solutions. I checked the imu measurement is correct. I'm wondering if the equations of motion are not constructed correctly
https://github.com/DAIRLab/dairlib/blob/master/examples/Cassie/cassie_state_estimator.cc#L522-L528

@mposa Looks like the QPs for contact estimation are not giving good solutions. I checked the imu measurement is correct. I'm wondering if the equations of motion are not constructed correctly
https://github.com/DAIRLab/dairlib/blob/master/examples/Cassie/cassie_state_estimator.cc#L522-L528

Compare to this (which I'm pretty sure is correct for our examples, though potentially imperfect in how it includes generalized forces--there's an open issue in Drake to improve the API)
https://github.com/DAIRLab/dairlib/blob/e5d3ac0186e1c09c0bcafa487687331565dbba3f/multibody/kinematic/kinematic_evaluator_set.cc#L179-L193

I found the issue comes form the distance constraint of the QPs in EKF. Because the loop closure in the simulation is implemented via a spring, the displacement of this virtual spring is translated to the real ankle spring deflection in the QPs which leads to inaccurate dynamic prediction.
I'm guessing this virtual spring also affects the OSC solution, but I haven't looked into it yet.

Benchmark of the optimal QP cost in EKF:

The cost for the double support, including dynamics error and soft constraint error, is about 1e-5 when we use distance constraint in simulation.
The cost is about 250 when we use spring stiffness of 2e5 for loop closure
The cost is about 20 when we use spring stiffness of 1e6 for loop closure

Benchmark of the optimal QP cost in EKF:

The cost for the double support Cassie, including dynamics error and soft constraint error, is about 1e-5 when we use distance constraint in simulation.
The cost is about 250 when we use spring stiffness of 2e5 for loop closure in simulation
The cost is about 20 when we use spring stiffness of 1e6 for loop closure in simulation

Is the error in the spring constraint of a realistic scale, or is it unreasonably large? If the former, then we should be robust to it.

Is the error in the spring constraint of a realistic scale, or is it unreasonably large? If the former, then we should be robust to it.

I looked at the value of the spring deflection for the loop closure in Drake simulation. With stiffness = 1e6, the deflection is about 0.0004 meter at steady state, which could probably be realistic?
Roughly calculating the stiffness of the achilles rod with the equation given by https://physics.stackexchange.com/questions/320089/what-is-the-spring-constant-of-a-steel-wire,
k = E*A/L = 1e10 * 1e-4 / 0.5 = 2e6
where I assume the young's modulus E is 1e10 pa (Cassie's should be higher? https://www.engineeringtoolbox.com/young-modulus-d_773.html), the area A is 1 cm^2, and length is 0.5 m.
I'm guessing simulated stiffness 1e-6 is an underestimate, but maybe it's not too far from the real value.
I will check the value of the QP cost is when Cassie stands still in experiment. This will tell us how close our model is to the robot, and I'll tune the EKF to be robust against the model error

Is the error in the spring constraint of a realistic scale, or is it unreasonably large? If the former, then we should be robust to it.

I looked at the value of the spring deflection for the loop closure in Drake simulation. With stiffness = 1e6, the deflection is about 0.0004 meter at steady state, which could probably be realistic?
Roughly calculating the stiffness of the achilles rod with the equation given by https://physics.stackexchange.com/questions/320089/what-is-the-spring-constant-of-a-steel-wire,
k = E*A/L = 1e10 * 1e-4 / 0.5 = 2e6
where I assume the young's modulus E is 1e10 pa (Cassie's should be higher? https://www.engineeringtoolbox.com/young-modulus-d_773.html), the area A is 1 cm^2, and length is 0.5 m.
I'm guessing simulated stiffness 1e-6 is an underestimate, but maybe it's not too far from the real value.
I will check the value of the QP cost is when Cassie stands still in experiment. This will tell us how close our model is to the robot, and I'll tune the EKF to be robust against the model error

Ok! Good sanity check on Young's Modulus, though I'd say that compliance in a robot typically comes from the inclusion of other more flexible elements (like bushings) or from beam bending rather than pure tension/compression.

Ok! Good sanity check on Young's Modulus, though I'd say that compliance in a robot typically comes from the inclusion of other more flexible elements (like bushings) or from beam bending rather than pure tension/compression.

A correction on the Young's modulus -- I forgot to time 6.8 when converting psi to pa. The real stiffness is probably higher than 1e7


asymmetric error in XY like

I have spectral points which have asymmetric error and I am hoping to use XY Like to fit those spectral points. However, it seems like XY Like only supports symmetric errors. Is it possible to make XY Like support asymmetric error?

Hi @jasonfan1997 in fact, it is not really possible from a mathematical standpoint to fit so-called asymmetric errors. Assuming they come from running a profile on a fit from another dataset, the mere fact that the profile returns an asymmetry tells you that the asymptotic assumptions (and others) that go into doing a maximum likelihood fit have broken and the fit is invalid.
Indeed, the point of 3ML is that the instrument from where these asymmetric flux points came from would be fit simultaneously with the rest of the data.. eliminating this invalid second step of creating asymmetric flux points.

Thanks for the quick response

There is a plugin that might be able to help you if you have access to what generates the flux points, you may be able to binned profile likelihoods.

Hi, can you elaborate on it? I do have access to what generates the flux points

@grburgess I would also like to elaborate a bit more on it. The error in flux is symmetric in log space but becomes asymmetric after parameter.transformation.backward to linear distance. However, it seems like XYLike only uses the output flux value on the source and does a chi2(XYLike._get_total_expectation), any suggestions on how I should handle it? Is it possible to make XYLike handle this situation?

I'm currently on travel but I will get back next week.

@jasonfan1997 There is a plugin called CastorLike that is experimental and I am unaware of its status which uses something call Binned profiled likelihoods. This is a bit of an adhoc way to deal with your situation and I have my doubts on it's statistical validity. What instrument is your flux coming from and what are the errors in log space?

Hi, I am currently using hawc_hal, and the error in the flux norm is not symmetric. I looked at the code and believe it is sampling from the covariance matrix so the error is symmetric in log space(It didn't use get_errors and minos).

If you're using HAL, why not include that directly? That way, also the
energy uncertainty will be taken into account properly.
On Wed, Oct 26, 2022 at 11:14 AM Kwok Lung(Jason) Fan <
@.***> wrote:

Hi, I am currently using hawc_hal, and the error in the flux norm is not
symmetric. I looked at the code and believe it is sampling from the
covariance matrix so the error is symmetric in log space(It didn't use
get_errors and minos).
—
Reply to this email directly, view it on GitHub
https://github.com/threeML/threeML/issues/595#issuecomment-1292204728,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3PSBXR27IXE7E2E3PGVDTWFFDFPANCNFSM6AAAAAARKNTLL4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
sent from Mars

What kind of sources are you looking at and how many free parameters?
Honestly, I think the statistically more correct way would be to tabulate
the hawc likelihood vs flux norm (assuming that's the only free parameter)
rather than relying on the errors to be gaussian (or log-gaussian).
On Wed, Oct 26, 2022, 11:26 Kwok Lung(Jason) Fan @.***>
wrote:

@henrikef https://github.com/henrikef I am trying to do a joint-fit
between IceCube and HAWC, but using HAL directly is too slow since IceCube
requires thousands or even millions of background trials to compute the
p-value and sensitivity. I am hoping I can first fit a model with HAL and
extract the flux point, then do a joint-fit using XYLike and IceCube data.
—
Reply to this email directly, view it on GitHub
https://github.com/threeML/threeML/issues/595#issuecomment-1292222074,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3PSBWBG4FQ5HTENXXWAUDWFFESBANCNFSM6AAAAAARKNTLL4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am looking at ~20 sources in 3HWC and I am fitting the flux norm and the index or alpha/beta(if log parabola). My plan is to link the index of gamma rays and neutrinos together while letting the index,flux of gamma-ray, and neutrino float. I think the gaussian error here is not a bad approximation here since it only controls the spectral shape of the neutrino.

You need to be careful. Remember that HAWC's measured (reconstructed)
energy has large uncertainties. That means that the location of the SED
points (the "energy value") depends on the spectral shape. You should not
use those SED points for a spectral fit.
On Wed, Oct 26, 2022 at 11:49 AM Kwok Lung(Jason) Fan <
@.***> wrote:

I am looking at ~20 sources in 3HWC and I am fitting the flux norm and the
index or alpha/beta(if log parabola). My plan is to link the index of gamma
rays and neutrinos together while letting the index,flux of gamma-ray, and
neutrino float. I think the gaussian error here is not a bad approximation
here since it only controls the spectral shape of the neutrino.
—
Reply to this email directly, view it on GitHub
https://github.com/threeML/threeML/issues/595#issuecomment-1292253320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3PSBQ6IS6PORTQT6YQYU3WFFHHZANCNFSM6AAAAAARKNTLL4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
sent from Mars

@henrikef above were you referring to binned profile likelihood?
@jasonfan1997 I'm still kind of confused on the approach of the icecube plug-in. I've seen other instruments recently fit for an LRT or p-value which makes no sense to me and smells of some misinterpretation of spectral fitting... but I could be wrong. I would love to see a small presentation of this in one of our meetings if possible.

@henrikef I am still using the actual hawc map and hal to fit the spectral shape and obtain the best-fit model. The Flux points is used when performing joint-fit, and since IceCube background is just no signal, the goal of HAWC data in the joint-fit is essentially to constrain the spectral shape parameter to be close to the HAWC-alone best-fit model, and I think the Flux points is good enough to serve that purpose. However, if HAWC or other instruments want to model testing to constrain or rule out certain hadronic models (aka only need to fit once), using the actual hawc map or other experiments plugin is definitely needed to handle it.
@grburgess I would love to present it during 3ML meeting. We can talk through email or slack if possible.


doc: Migrate README to markdown and use GitHub mermaid

This PR migrates the README file from reStructuredText (.rst) format to Markdown (.md). Mermaid diagrams have been integrated.
I don't know your documentation style convention for links in Markdown files, so feel free to adjust. Also you can adjust styling of mermaid diagram if you wish.

[x] TODO: Delete images from doc/source/_static/ if not needed anymore

Close #587

Also, can you state that you agree with the CLA ?

Yeah, I submitted the form before creating PR.

In last commit I updated stroke and fill colors in diagrams. Now they look good in both light and dark mode (in my taste). Feel free to adjust!

Many thanks for fixing all the necessary files, @SerTetora. I added your name and GitHub profile to the CONTRIBUTORS.md file. Waiting for the CI/CD to pass and merging then.


        By default this method just initializes a :class:`Stream` object
        connected to the given file-like object and its underlying file
        descriptor (a simple one-liner).

        If however the file descriptor of the file-like object doesn't have the
        expected value (``expected_fd``) two :class:`Stream` objects will be
        created instead: One of the stream objects will be connected to the
        file descriptor of the file-like object and the other stream object
        will be connected to the file descriptor that was expected
        (``expected_fd``).

        This approach is intended to make sure that "nested" output capturing
        works as expected: Output from the current Python process is captured
        from the file descriptor of the file-like object while output from
        subprocesses is captured from the file descriptor given by
        ``expected_fd`` (because the operating system defines special semantics
        for the file descriptors with the numbers one and two that we can't
        just ignore).

        For more details refer to `issue 2 on GitHub
        <https://github.com/xolox/python-capturer/issues/2>`_.
        """
>       real_fd = file_obj.fileno()
E       io.UnsupportedOperation: fileno

I suspect, this has to do with nested capturing, as the function's documentation helpfully states (#2).
Reproduction
python 3.7.3
pytest 5.3.5
capturer 2.4
File test_file.py, called with pytest test_file.py:
import subprocess
from capturer import CaptureOutput

def test_capturer(capsys):
    with CaptureOutput() as capturer:
        # Generate some output from Python.
        print("Output from Python")
        # Generate output from a subprocess.
        subprocess.run(["echo", "Output from a subprocess"])
        # Get the output in each of the supported formats.
        assert capturer.get_bytes() == b'Output from Python\r\nOutput from a subprocess\r\n'
        assert capturer.get_lines() == [u'Output from Python', u'Output from a subprocess']
        assert capturer.get_text() == u'Output from Python\nOutput from a subprocess'

Hi @clara-avnet and thanks for the feedback. The exception you reported is indeed reproducible. This prompted me to play around a bit with the interactions between pytest's capturing behavior and capturer to see if it can be improved. The good news is that the exception can be avoided:
diff --git a/capturer/__init__.py b/capturer/__init__.py
index 407ba26..442ca86 100644
--- a/capturer/__init__.py
+++ b/capturer/__init__.py
@@ -7,6 +7,7 @@
 """Easily capture stdout/stderr of the current process and subprocesses."""

 # Standard library modules.
+import io
 import multiprocessing
 import os
 import pty
@@ -264,12 +265,19 @@ class CaptureOutput(MultiProcessHelper):
         For more details refer to `issue 2 on GitHub
         <https://github.com/xolox/python-capturer/issues/2>`_.
         """
-        real_fd = file_obj.fileno()
-        stream_obj = Stream(real_fd)
-        self.streams.append((expected_fd, stream_obj))
+        try:
+            real_fd = file_obj.fileno()
+            stream_obj = Stream(real_fd)
+            self.streams.append((expected_fd, stream_obj))
+        except io.UnsupportedOperation:
+            # This happens when the pytest capture fixture is being used.
+            real_fd = None
+        # Regardless of how the above went we're interested in what child
+        # processes have to report on the OS defined file descriptor.
         if real_fd != expected_fd:
             self.streams.append((expected_fd, Stream(expected_fd)))
-        return stream_obj
+        # Get the first stream available (we know there will be at least one).
+        return next(stream for fd, stream in self.streams if fd == expected_fd)

     def __enter__(self):
         """Automatically call :func:`start_capture()` when entering a :keyword:`with` block."""

Unfortunately this means output capturing by capturer is only done on the level of file descriptors and not inside Python, which is likely not the expected behavior (as your test nicely illustrates). This means I don't see a realistic way to make the test as you wrote it succeed, it would end up like this:
def test_pytest_capture_fixture(capsys):
    with CaptureOutput() as capturer:
        # Generate some output from Python.
        print("Output from Python")
        # Generate output from a subprocess.
        subprocess.call(["echo", "Output from a subprocess"])
        # Get the output in each of the supported formats.
        assert capturer.get_bytes() == b'Output from a subprocess\r\n'
        assert capturer.get_lines() == [u'Output from a subprocess']
        assert capturer.get_text() == u'Output from a subprocess'

However this seems like counterintuitive behavior to me, so I'm not convinced about enabling this. Maybe instead the documentation should just explicitly state not to mix capturer and the pytest output capturing fixtures? After all they serve very similar purposes. I'm open to discussion about whether there's a right choice here 🙂.

I think your suggestion to simply warn users not mix usages of capturer and the capsys fixture, sounds like the best option.
After all, in my use case I ended up using only capturer


Add ZipArchive::CREATE flag for PHP 5.6

Since PHP 5.6, ZipArchive::open will return ZipArchive::ER_NOENT if the ZipArchive::CREATE option is not given and the file doesn't exist, while previously, it was created without error with only ZipArchive::OVERWRITE.

Thanks!


Fine-tuning for multi objects

Looking at the fine-tuning loss function, it is a DiceCELoss between the predicted and actual masks. How would this work for multiple objects, especially when the multiple objects need to be represented in separate channels?

@MLDeS ,
thanks for your great question. currently, sam/medsam only supports binary segmentation.

Thanks, @JunMa11. Just to clarify, so the "different" masks for the multiple objects that we see for an image using sam is basically generated sequentially, i.e., by looping over the different objects' (point prompts, bbox prompts etc.) and treating them as single entities and generating a binary mask (foreground vs background) for each of those objects separately, is that right? And then combining them for visualization. Please correct me if I am wrong.

Hi @MLDeS ,
I don't think they are generated sequentially.
Here are the details:)


docs(structural-components): add chapter

Copied from ideablade pr 10
Ward says: WORK-IN-PROGRESS! Do not merge
The second half of Filipe's original "Structural Directives" chapter is here.
IMO (and Filipe and Pascal's apparently), that half seemed to depart from the point of Structural Directives and, in fact, defined a new kind of component that did the job of incorporating external content by projection.
This seemed to me to be a new concept, deserving its own chapter. For lack of better terms, I dubbed it the "Structural Component".
So, Filipe, this is something on my plate for review in the not-to-distant future.  You may want to take it a next step before I get there. My sense is that a Tab/Tab Pane example fits perfectly in this chapter. Do you agree?
Filipe says:  I was trying to move away from tabs because that was Victors example for ng-content (which isn't a strong reason).
But to show DynamicComponentLoader, I think something simpler would be in order since tabs/tab-pane would require a bit more complexity in structure organization.
For instance, the recall button component class could be provided by the parent component, and the dashboard would instantiated it. It would demonstrate that a component class could be referenced and used outside of templates, which is an amazing thing conceptually.
Ward replies:  I know Victor did Tabs. But that's on his blog. If that seems the most obvious example of the need to project developer content into a component's template, I'm sure he would not mind.
I would prefer NOT to lead with DynamicComponentLoader. It's cool but not mainstream.  Mainstream is the stuff with content children.  That said, I'd love to see what you do with it.

Noticed that @robertmesserle put I very nice and succinct version on the A2.io home page!  Source is here. We should steal it.

It does look steal worthy!
I'll work on this some more soon, and get back to you with a finished chapter.

In a conversation with @teropa it just dawned on me that I haven't covered the simple default case of <ng-content> with no selector, which just transcludes everything in the components light dom.
I need to add a section about that.

I agree with the direction. Carry on!

@wardbell I've updated the current content and examples to beta.2, added intro, table of contents and other minor edits.
This PR at the moment does not include all the additions previously discussed, but it is functional and complete as is. We can come back to it later and add more content.

@wardbell I've rolled this chapter into structural directives, as we discussed.

@wardbell @filipesilva  - still actual?

We will revisit this kind of PRs soon.


Idea for improving withDocument

Right now withDocument makes a query, without checking if the data that it requires is already in the store. This makes withDocument unusable if you have done any kind of data pre-fetching.
I suggest to change the logic of withDocument as follows:

Fetch data from the client store.
If data from the client store not available, make a query.

However, I have some concerns:

How do we know if the data in the client store is the most up-to-date?
Should the mutations also affect the client store?

I am some code that does the above, however I am still testing it.
I want to open the discussion to find the best way to improve withDocument.

I think withDocument should just take an argument in the options document that sets the Apollo query mode.
I think in general we want rewrite withDocument so that it's basically just a wrapper around withList, since the two components do almost precisely the same.

I am not sure wrapping withList to achieve what withDocument does is a good idea. Probably some code can be extracted to make withList and withDocument more modular.
In both cases they should check if the client cache already contains de information.

Actually this is something I added to both withList and withDocument recently:
if (options.fetchPolicy) {
        graphQLOptions.fetchPolicy = options.fetchPolicy;
      }

So you can now specify a fetchPolicy option, which should address your concern.

I think in general we want rewrite withDocument so that it's basically just a wrapper around withList, since the two components do almost precisely the same.

Maybe, I'll think about it when we rewrite withList to not use the reducer anymore.

(oh this is on the devel branch btw)

@PolGuixe when you talk about caching, isn't Apollo client taking care of some of the caching you are trying to achieve? I am not sure if Vulcan should get into caching at all. @SachaG is there an example of how to use fetchPolicy?

Through a lot of testing, I realized that you can have a finer control of the data cached using ApolloClient.readFragment and ApolloClient.readQuery.
ApolloClient.readFragment is required if you are trying to implement a proper pre-fetching on your app and is faster than doing any query. It is basically a sync function. I would like to use it in withDocument. If ApolloClient.readFragment fails, then it can fallback to perform a query, which will probably go to the network.
To implement something similar for the withList, probably is better to use ApolloClient.readQuery. Although, I haven't performed many tests with it. In some of them, it was behaving as I expected just partially.
What I am not sure about is the difference between ApolloClient.readQuery and ApolloClinet.query with the fetch policy set to cache-only.

That's definitely outside the scope of withDocument and withList. In that case I would suggest writing your own HoC that calls readFragment.

I think that being able to use pre-fetching and read the data from client cache are really useful features.
maybe this logic can be implemented as a HoC that can wrap withDocument?
I don't have many ideas for the naming. So please feel free to suggest names.

I think that being able to use pre-fetching and read the data from client cache are really useful features.

But that's already implemented by Apollo itself. This is what fetchPolicy is for.

Imagine you have a list of Posts. To get the data and display them you have the following query
query postsList {
  posts {
    id
    title
    shortDescription
    image
  }
}

When the user navigates to a specific post then you use this query
query postsList {
  onePost(id: $postId) {
    id
    title
    body
    image
  }
}

Above you have a basic normal pattern. You first query for the list and then you query for the post.
Imagine you want your users to access the post instantly -without a network query-. You could modify the first query as follows:
query postsList {
  posts {
    id
    title
    shortDescription
    body
    image
  }
}

This way you'll have all the data you need on the client. However, when you access your post by using the following query:
query postsList {
  onePost(id: $postId) {
    id
    title
    body
    image
  }
}

You'll still have to do a network query, even if all the data you need is on the client. Because Apollo hasn't performed this query before.
If you want to access that data 'directly' you can use readFragment. In this  readQuery won't work as there is no query registered like this one yet. Moreover, you can have logic to still perform de query if readFragment fails or still do it anyway for the sake of data consistency on the client or you want to add a pollInterval, etc.
Does it make sense?
I think it will be useful for Vulcan to have such capabilities. Otherwise, this could be a separate library. :)

I always assumed that Apollo already does what you describe out of the box. I might be wrong though, I would suggest asking in the Apollo chatroom directly to make sure.

Has anyone read this: dev-blog.apollodata.com

@MHerszak that topic is super interesting and I would love to explore it!
Probably the very first step to implement it would be to upgrade to Apollo Client 2. I gave it a try, however I got stuck at the redux interface and I did had much time to investigate.

@PolGuixe yeah redux can be tricky when you try to cut a domain into pieces. Do you think we can close this issue, for now?

@MHerszak honestly I don't think so. The behavior, I've described is not the one offered by Vulcan right now. My question is: do we want Vulcan to have this behavior?
I'll try to make a PR, so it is more clear what I am proposing.

I think this should be handled at the Apollo level, not the Vulcan level. So I would probably discourage a PR in that direction to be honest.

I've made a PR to our fork: https://github.com/OrigenStudio/Vulcan/pull/1
Currently to go around we are using another HoC, we have call it withLocalDocument. See PR.
We use this HoC in combination of withDocument:
// curryWithRouteNode.js

....

export default options => {
  const {
    collection,
    fragmentName,
    pollInterval,
    localDocumentOptions,
  } = options;
  return compose(
    withDocumentID,
    withDocument({
      collection,
      fragmentName,
      pollInterval,
    }),
    withLocalDocument({
      collection,
      fragmentName,
      ...localDocumentOptions,
    }),
  );
};

I believe that the logic in withLocalDocument should be combined with the logic in withDocument. I understand you @SachaG when you say that it should be handled at Apollo level, however right now they are not doing it. I my opinion the problem arises from the differences between fragments and queries.

This is really cool, but yeah it's just too much magic/complexity on top of an already magic/complex thing (withDocument) on top of Apollo which itself has its own magic and complexity… So I think it's better to either A) keep this as a separate, optional withLocalDocument HoC or B) find a way to integrate this feature into Apollo directly.
I'm going to close this for now, but let me know if you open an issue in the Apollo repo or somewhere else, I would be interested in seeing the discussion around this topic.

@SachaG ok. I'll try to open an issue in the apollo repo.
If we would like to open source this code and other code that supplements Vulcan, which way you think is the best? A separate package authored by us?  or a Vulcan package?

Does anyone knows where is the best place to discuss this with the Apollo team? I feel like if I open an issue in Github, it will be ignored. As it is not an issue with their current API.
It is more of a feature request.

A separate package would be best. And I don't think a GitHub issue will be ignored, but if it is let me know and I'll nudge them to answer it :)

Just opened an issue in the react-apollo repo.

@PolGuixe The latest medium article shows they will work on state handling in Apollo client. That means no detour (to redux) necessary.

https://www.apollographql.com/docs/react/features/cache-updates.html#cacheRedirect


Update map marker popup text

Closes #270

GHI, DNI units seem off here

Aha yes but of course

GHI, DNI units seem off here

This has been fixed in #276


Removed unnecessary docker-compose files

Describe your changes :

I worked on the #7099  because I needed to remove unused docker-compose files and also update the docs with new docker-compose files

Type of change :

[ ] Bug fix
[x] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Hey @akash-jain-10 , Can I get some feedback on this PR?

@akash-jain-10 Please verify the changes

@akash-jain-10 Please verify the changes

Thanks. LGTM.


size for built dist file for markedarea.js

dist file markedarea.js is with 1.6 mb quite huge. need to investigate / fix.

Version 0.1.0 fixes this problem and size is now 6kb.

Its actually 2.7k gzipped.


Optimize

Possibly look at using neon to write bindings to protodefc, it would make it considerably faster, but we'd have to cross-compile for each platform

test.pds, 1.10 real 1.07 user 0.08 sys
protocol.pds, 2.64 real 5.24 user 0.35 sys

Switching to native extensions


Plot tumor mutation burden and MATH score

Hi Anand,
I am interested in plotting 'tumor mutation burden' and MATH score as a panels in the 'coOncoplot'. I was able to calculate 'tmb' and 'math.score' using respective functions. Could you please suggest me on how to add this to 'MAF' object or a better way to include those 'tmb' and 'math' as panels for 'coOncoplot'?
Thanks,
Praveen

Hello Praveen,

You can add any deatils to sample information in the MAF object. In your case, if you have calculated TMB/MATH scores, you can merge the results to clinical.data slot of MAF object.

library(maftools)
laml.maf = system.file("extdata", "tcga_laml.maf.gz", package = "maftools") #MAF file
laml.clin = system.file('extdata', 'tcga_laml_annot.tsv', package = 'maftools') #clinical data
laml = read.maf(maf = laml.maf, clinicalData = laml.clin)
laml_math = maftools::math.score(maf = laml, vafCol = "i_TumorVAF_WU")

# merge math scores with the clinical data
<EMAIL_ADDRESS>=<EMAIL_ADDRESS>laml_math[,.(Tumor_Sample_Barcode, MATH)], by = 'Tumor_Sample_Barcode', all.x = TRUE)

# ... do the same for TMB

Unfortunately coOncoplot does not allows to include any top or sidebar plots. The easiest way would be to plot two oncoplots for the same set of genes with keepGeneOrder = TRUE and put them side by side in illustrator. You can use  topBarData to show TMB or MATH scores.

Hope this helps.

Hi Anand,
Great. Thanks so much for the quick reply.
Thanks,
Praveen


Increase page size for services fetch to 100

I feel like stubbing the API_FETCH_SIZE with a lower value in tests might be a good idea. I've run the run_tests.sh and it takes ~0.8s longer with this change, which is not that bad, but I think it's better to keep the test run time as low as possible right from the start.
Other than that the change looks good and listing 100 services per response seems like a good idea, especially for our ES export scripts.

Merging this now, we'll add the fetch size stubbing later


V2.6.0 20220522

This change will allow loaders to be used independently of SecretBox. The auto-load feature will remain as a simple method for loading the local .env file. Additional loaders will be called directly which will give more control and clarity to they are to be used.
The following SecretBox method will be marked deprecated and removed in future versions:

.get_list(...)
.get_int(...)
.load_from(...)

resolves #79 (eventually)


Expensive iOS CPU usage

Bug
While running on iOS simulator there was a huge noticeable CPU usage when using this nice library which causes drop in the whole app performance.

Environment info

Library
Version

@gorhom/animated-tabbar
1.2.0

react-native
0.61

react-native-reanimated
1.8.0

react-native-gesture-handler
1.6.1

react-native-svg
12.1.0

Reproducible sample code
By just simply adding it as a prop:
tabBar={props => (
<AnimatedTabBar
isRTL={I18nManager.isRTL}
duration={500}
iconSize={29}
//itemOuterSpace={{horizontal:20}}
itemInnerSpace={{horizontal: 15,}}
style={{
shadowOffset: {
height: 0,
width: 0,
},
shadowColor: 'rgba(0,0,0,0.16)',
shadowRadius: 5,
shadowOpacity: 0.4,
backgroundColor: '#FFFFFF',
height: hasNotch ? 98 : null,
paddingHorizontal: 0,
elevation: 12,
}}
tabs={tabs}
{...props}
/>
)}

@muxbert , thanks for reporting this i'll prioritise solving this issue 👍


[Java] Update Unit Tests for Flight Module

Describe the enhancement requested
This is a sub-issue of the issue below.

#41680

The unit tests should use the org.junit.jupiter.api package. This issue deals with the flight module.
Component(s)
Java

Issue resolved by pull request 42158
#42158

Issue resolved by pull request 42158
https://github.com/apache/arrow/pull/42158


Cannot compile with mingw in Windows 10

I designed a board with the ATSAME54N20A and I like to use the latest BOSSA 1.9. Unfortunately no binary is created yet, and I am stuck with compiling it with mingw. Do you have any instructions on how to compile this. Currently the following messages appear:
C:\msys32\home\BOSSA>mingw32-make
wx-config Warning: Multiple compiled configurations of wxWidgets have been detected.
Using first detected version by default.
Please use the --wxcfg flag (as in wx-config --wxcfg=gcc_dll\mswud)
or set the environment variable WXCFG (as in WXCFG=gcc_dll\mswud)
to specify which configuration exactly you want to use.
wx-config Warning: Multiple compiled configurations of wxWidgets have been detected.
Using first detected version by default.
Please use the --wxcfg flag (as in wx-config --wxcfg=gcc_dll\mswud)
or set the environment variable WXCFG (as in WXCFG=gcc_dll\mswud)
to specify which configuration exactly you want to use.
CPP APPLET src/WordCopyArm.cpp
In file included from src/Samba.h:38:0,
from src/Applet.h:34,
from src/WordCopyApplet.h:32,
from src/WordCopyArm.cpp:3:
src/SerialPort.h:76:18: error: 'unique_ptr' in namespace 'std' does not name a template type
typedef std::unique_ptr Ptr;
^
In file included from src/Applet.h:34:0,
from src/WordCopyApplet.h:32,
from src/WordCopyArm.cpp:3:
src/Samba.h:55:30: error: 'SerialPort::Ptr' has not been declared
bool connect(SerialPort::Ptr port, int bps = 115200);
^
src/Samba.h:99:17: error: 'Ptr' in 'class SerialPort' does not name a type
SerialPort::Ptr _port;
^
src/Samba.h: In member function 'const SerialPort& Samba::getSerialPort()':
src/Samba.h:75:49: error: '_port' was not declared in this scope
const SerialPort& getSerialPort() { return *_port; }
^
Makefile:248: recipe for target 'obj/WordCopyArm.o' failed
mingw32-make: *** [obj/WordCopyArm.o] Error 1

I changed to Cygwin, but still have a similar issue. I added COMMON_CXXFLAGS=-std=c++11 in the makefile already per one of the previous posts. Mingw had no issues with the build after that change, but didn't create any binary files. See the new errors below.
make all
Building file: ../src/Applet.cpp
Invoking: Cygwin C++ Compiler
g++ -O2 -g -Wall -c -fmessage-length=0 -MMD -MP -MF"src/Applet.d" -MT"src/Applet.o" -o "src/Applet.o" "../src/Applet.cpp"
In file included from ../src/Samba.h:38:0,
from ../src/Applet.h:34,
from ../src/Applet.cpp:29:
../src/SerialPort.h:76:18: error: 'unique_ptr' in namespace 'std' does not name a template type
typedef std::unique_ptr Ptr;
^
In file included from ../src/Applet.h:34:0,
from ../src/Applet.cpp:29:
../src/Samba.h:55:30: error: 'SerialPort::Ptr' has not been declared
bool connect(SerialPort::Ptr port, int bps = 115200);
^
../src/Samba.h:99:17: error: 'Ptr' in 'class SerialPort' does not name a type
SerialPort::Ptr _port;
^
../src/Samba.h: In member function 'const SerialPort& Samba::getSerialPort()':
../src/Samba.h:75:49: error: '_port' was not declared in this scope
const SerialPort& getSerialPort() { return *_port; }
^
make: *** [src/subdir.mk:121: src/Applet.o] Error 1
13:58:43 Build Finished (took 344ms)

Exactly same problem here. I'm using mingw (gcc --version 5.1.0)

I ended up just compiling the BOSSAC.EXE from Mattairtech in MSYS with MINGW32, just use the  BOSSA/arduino/make_package.sh. Using BOSSAC in Arduino to upload sketches to a board with SAME54 now.

I use msys2 with mingw32 7.3.0 to build the releases.  I configure wxWidgets with:
configure --disable-shared --enable-unicode --with-zlib=builtin --disable-debug


Tests fail for a new installation of pyPPI.

Hey!
I was trying to use pyPPI on my PC. I followed the steps mentioned on the docs, and the tests always fail.
I built and installed the package in a virtual environment. After that, I downloaded the required data (It takes forever to download it). However, whenever I run python setup.py test it says test failed, giving an output as below.
running test
/home/major/.local/share/virtualenvs/pyPPI-nTZk3L3o/lib/python3.7/site-packages/scikit_learn-0.19.2-py3.7-linux-x86_64.egg/sklearn/feature_extraction/text.py:17: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  from collections import Mapping, defaultdict
/home/major/.local/share/virtualenvs/pyPPI-nTZk3L3o/lib/python3.7/site-packages/scikit_learn-0.19.2-py3.7-linux-x86_64.egg/sklearn/ensemble/weight_boosting.py:29: DeprecationWarning: numpy.core.umath_tests is an internal NumPy module and should not be imported. It will be removed in a future NumPy release.
  from numpy.core.umath_tests import inner1d
........................................................................................................................................................................................................................................................................................2018-08-31 18:50:41 pyppi    WARNING  No protein for '"about:legacy-compat">' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for SYSTEM.
2018-08-31 18:50:41 pyppi    WARNING  Could not map SYSTEM.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'xmlns="http://www.w3.org/1999/xhtml"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for <html.
2018-08-31 18:50:41 pyppi    WARNING  Could not map <title>Retrieve/ID' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for lang="en".
2018-08-31 18:50:41 pyppi    WARNING  Could not map lang="en".
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'content="IE=edge"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for mapping</title><meta.
2018-08-31 18:50:41 pyppi    WARNING  Could not map mapping</title><meta.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'content="text/html;' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for http-equiv="X-UA-Compatible"/><meta.
2018-08-31 18:50:41 pyppi    WARNING  Could not map http-equiv="X-UA-Compatible"/><meta.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'http-equiv="Content-Type"/><meta' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for charset=UTF-8".
2018-08-31 18:50:41 pyppi    WARNING  Could not map charset=UTF-8".
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'initial-scale=1"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for content="width=device-width,.
2018-08-31 18:50:41 pyppi    WARNING  Could not map content="width=device-width,.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'href="/"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for name="viewport"/><link.
2018-08-31 18:50:41 pyppi    WARNING  Could not map name="viewport"/><link.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'href="http://creativecommons.org/licenses/by-nd/3.0/"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for rel="home"/><link.
2018-08-31 18:50:41 pyppi    WARNING  Could not map rel="home"/><link.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'type="image/vnd.microsoft.icon"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for rel="license"/><link.
2018-08-31 18:50:41 pyppi    WARNING  Could not map rel="license"/><link.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'rel="shortcut' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for href="/favicon.ico".
2018-08-31 18:50:41 pyppi    WARNING  Could not map href="/favicon.ico".
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'href="/uniprot.min.css2018_07"' found in the database. Consider downloading the latest UniProt dat files and updating the database.
2018-08-31 18:50:41 pyppi    WARNING  No reviewed acc found for icon"/><link.
2018-08-31 18:50:41 pyppi    WARNING  Could not map icon"/><link.
2018-08-31 18:50:41 pyppi    WARNING  No protein for 'rel="stylesheet"/>


Nami Testnet Airdrop hangs

I setup a Nami wallet, added 1000 tAda was able to connect, but choosing Testnet and trying to claim airdop
Http failure response for https://rwd.freeloaderz.io/rwdbuild/multisig/1/testrewards: 503 Service Unavailable

Somehow one of the gateway server got stuck on aws status checks and was not reachable anymore, I spooled up a new gateway server all fine now, need to observe if this happens again


Add sensors to simulated robot

Refer to http://gazebosim.org/tutorials?tut=ros_gzplugins for more info.
At least a front camera should be added to the robot in the first interation.
The #1 should be resolved first.

Camera and Lidar were added to the simulated robot. We should open new issue if when we need additional sensors.


Syntax error as type for JSX

The new feature syntax error as type seems not to work seamlessly with the JSX application. I'm 100% not sure. My best guess is that JSX expression(especially JSX call site) is not transformed as type, or Reanalyze doesn't do analysis for the jsx application. Any future plan for improving checking syntax error as typing for JSX?

Could you describe a bit more in depth what it is you're seeing now, and what you expect to see instead? Preferably with something minimal and reproducible.

Syntax errors are produced by the parser, not the editor.
You should have a similar repro using just a file and the command line.

I think I am confused about what I've gotten from the OCaml experience. That means OCaml IDE checks the type error and syntax errors without saving. I'm clear now. And I really want that either. 😄