Add pom.xml for maven

I add the pom.xml for maven repo. The dependencies are based on "build.gradle". Tests passed.

Hi Yifan,
Thank you very much! The xml looks good and we have merged it.
Best,
Yibin


Better associate docs 'run' buttons with the sections they run

One option is to move the buttons into the corner (I think top right might actually be best), and lighten the background of the runnable code areas a bit more:

Thanks!

After trying this out for a bit, I felt that putting the buttons on the bottom didn’t work because they interacted with the horizontal scrollbar.
For design/development, I recommend setting “Show scrollbars” to “Always” in System Preferences, as it makes issues like these more obvious.

I did however increase the contrast of the code block, which should help with the association, and improve the scrollbar styling. https://github.com/EagerIO/EmbedBox/commit/7f1fe21aca75b009a9f46924bbdab14fbc17e38a

Is putting them in the top right, but more tightly connected with the edge of the box like in the example an option?

I’ll show you what that looks like. I tried that myself in my iterations just now and didn’t love it, but we’ll see what you think ;)

Thx, I appreciate it!
On Thu, Sep 8, 2016 at 3:17 PM, Adam Schwartz<EMAIL_ADDRESS>wrote:

I’ll show you what that looks like. I tried that myself in my iterations
just now and didn’t love it, but we’ll see what you think ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/EagerIO/EmbedBox/issues/98#issuecomment-245709281,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADYM7nVufVL4ISpdZuhJBba6t42YqSRks5qoF9mgaJpZM4J4SK5
.

A few options. Last one is current.

Oddly enough, my favorite is now this one:

Let me know!

For me any of the options which move the buttons outside of the code area break the association.  Also for me, having the padding around the buttons makes it hard to tell this isn't a part of the code sample, but is meta.
My personal favorites are the first two:

and

After much deliberation we have decided to go with this:


Introduce release template

https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

It's https://github.com/ComposeGears/Valkyrie/releases/tag/Nightly


glob() finds gml-files twice

On my Windows machine with Python 3.10 I found that gml-files of the input directory are processed twice since the glob() function does not appear to be case in-sensitive and identifies identical gml-files twice when checking first on "*.gml" and then on "*.GML":
https://github.com/tum-gis/CityGML2OBJv2/blob/c55356ab74606e9802ffa390bed7ac1953596c79/CityGML2OBJs.py#L348-L351

Hi, thank you for pointing this out. If my understanding is correct, modifying the types would solve the issue. Would you agree?

Yes you are right. My quick fix was to simply remove the upper case types. But did not test it with upper case file extensions so far

I have tested it and have not encountered any issues related to this change so far. I think that it solves the issue and I am therefore going to incorporate your approach. Thank you very much for your help!


[hunspell] learn replacements provided interactively by the user

Summary
Currently the same custom replacement has to be typed over and over again, for no reason.
It would be better to learn one instance and then re-run the checkers with the newly recorded item for the current doc comment and all remaining ones.
Will require some re-thinking,one of the following two:
check all items...

lazily in interactive mode, i.e. by moving to an iterator only design.
and recheck on every learned item, requires to record all decisions of the user made before

Relvenat files: interactive.rs ,hunspell.rs

One optione would to use dashmap to store the user selections and skip follow up corrections. This would be significantly easier if most of it would be done async on demand I think.

This would be so appreciated! In big projects there are lots (dozens and dozens) of instances where words like "config", "JSON", or "IDE" are flagged. It would be nice to keep track of which words have already been discarded as typos and just skip them next time.

Work has started, but given a surge of lack of time, it's going to take some more time https://github.com/drahnr/cargo-spellcheck/pull/296 - note that it's a bit more complex than anticipated and requires some additional refactor to work consistently.


Left and right taskbar is broken

Description
The taskbar is broken when it is displayed at the left or right side of the screen. This might be connected to a problem that occurs when the taskbar is positioned at the bottom: #676. All in all it only seems to work perfectly fine at the top.
Steps to reproduce

Start TaskbarX (just downloaded and extracted, default settings)
Change the position of the taskbar

Screenshots

Desktop:

OS: Windows 10 Home
Version: 21H1
Build: 19043.1052
TaskbarX: <IP_ADDRESS>

To be able to focus on major/current bugs I had to close all issues. The issues section has gotten very messy to a point that I couldn't follow it anymore. Most issues are duplicates, very old or are already fixed/solved. Feel free to reopen this issue if you still have this issue on the latest version of TaskbarX to get my attention. All feature requests have been put in a list here: 💡| Feature requests #870
I hope you understand ❤


tagUI is not recognized as a command in Terminal - macOS

Hi!
I tried to install TagUI for macOS, following the instructions.
I tried everything I knew in MacOS Catalina, in MacOS Big Sur and in MacOS Monterey, including installing homebrew, changing the names of the directories, but I always get the answer: zsh: command not found: tagui. (first it was bash: command not found)
I tried with different directory flows, but the last attempt I made was with:
sudo ln -sf /Desktop/tagui/src/tagui /usr/local/bin/tagui
tagui /Desktop/tagui/flows/samples/1_google.tag
Anyone with the same problem?

When you click on the alias / usr / local / bin / tagui, can it be opened?
The alias may be wrong

Adding on, I have not used ZSH shell. After you run sudo ln -sf /Desktop/tagui/src/tagui /usr/local/bin/tagui is there any error message? If not, try running ls -l /usr/local/bin/tagui to see if the shortcut has been created.
Also, I think for Mac, the folder you used is wrong. It is probably /Users/your_username/Desktop/tagui/src/tagui instead of /Desktop/tagui/src/tagui. Maybe that's the reason why the symbolic link is not working.

Hi!
Thanks a lot for your help.
I changed the shell to Bash again. Then I tried doing what you told me and this was the result:
MBPSu2020:~ susanaribeiro$  sudo ln -sf /Desktop/tagui/src/tagui /usr/local/bin/tagui
Password:
MBPSu2020:~ susanaribeiro$ ls -l /usr/local/bin/tagui
lrwxr-xr-x  1 root  wheel  24 20 Dez 11:27 /usr/local/bin/tagui -> /Desktop/tagui/src/tagui
MBPSu2020:~ susanaribeiro$ tagui /Desktop/tagui/flows/samples/1_google.tag
-bash: tagui: command not found
Then I tried with the other options of folders and it happened this:
MBPSu2020:~ susanaribeiro$ sudo ln -sf /Users/susanaribeiro/Desktop/tagui/src/tagui /usr/local/bin/tagui
MBPSu2020:~ susanaribeiro$ ls -l /usr/local/bin/tagui
lrwxr-xr-x  1 root  wheel  44 20 Dez 11:32 /usr/local/bin/tagui -> /Users/susanaribeiro/Desktop/tagui/src/tagui
MBPSu2020:~ susanaribeiro$ tagui /Users/susanaribeiro/Desktop/tagui/flows/samples/1_google.tag
/usr/local/bin/tagui: line 300: php: command not found
Unable to open file: /Users/susanaribeiro/Desktop/tagui/flows/samples/1_google.tag.js
phantomjs://code/bootstrap.js:113 in __die
Unable to load script /Users/susanaribeiro/Desktop/tagui/flows/samples/1_google.tag.js; check file syntax
phantomjs://code/bootstrap.js:113 in __die

Hi @suribeiro great! Looks like you found the issue, by including /User/username you are able to map the command correctly. This next error is due to Mac newer version removing a component used by TagUI, the PHP engine.
You can fix this by running below 2 lines to install PHP manually -
https://github.com/kelaberetiv/TagUI/issues/1137#issuecomment-989465983
This issue is recently reported and I have updated the setup guide to include this troubleshooting step.

Hi @kensoh
I followed the instructions in #1137 and #1136 and finally it's working!!!
Thank you very much!


Is it should be possible to use Dependency Injection on Active Record classes?

Question related to Yii2 logic.
According to application configuration for Dependency Injection at manual. I can write next code and UserHelper class should handle events:
//main.php
'container' => [
        'definitions' => [
            User::class => [
                'on ' . User::EVENT_BEFORE_INSERT => [UserHelper::class, 'eventHandler'],
                'on ' . User::EVENT_BEFORE_UPDATE => [UserHelper::class, 'eventHandler'],
                'on ' . User::EVENT_BEFORE_DELETE => [UserHelper::class, 'eventHandler'],
            ]
        ],
    ],

But it not work because ActiveRecord classes creates at BaseActiveRecord::instantiate() method using simple creation.
__Can I use Dependency Injection for ActiveRecord classes or I should register event handlers at __construct() method?
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
PHP Version 7.1.17-1+ubuntu16.04.1+deb.sury.org+1

Operating system
Linux Mint 18.3

You can if you'll override instantiate(). By default you can't cause it trashes performance significantly.


ui: add action to declare/cancel host as degraded

Description
Fixes #8318
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8327 (QA-JID-242)

tested in simulator locally by marking a host in state Alert in the DB. LGTM


Add print foreign function

I think this solution is good. But I prefer to translate it to a drop instruction. @junyu0312 it is possible?

I think this solution is good. But I prefer to translate it to a drop instruction. @junyu0312 is it possible?

I prefer this implementation because by modifying the register function, it can easily support print in various environments

I think this solution is good. But I prefer to translate it to a drop instruction. @junyu0312 is it possible?

I prefer this implementation because by modifying the register function, it can easily support print in various environments

Ok.

Closed because this PR has been updated and merged. See https://github.com/DelphinusLab/zkWasm/pull/114 for more details.
We don't have permission to force push, so we created a new pr while retaining the commit message and author. Thanks.


PMID:32735772

normal macroautophagy during endoplasmic reticulum stress.
decreased endoplasmic reticulum autophagy during endoplasmic reticulum stress.
normal endoplasmic reticulum autophagy during nitrogen starvation.

increased presence of  membrane structures inside autophagosomes
(not sure what the correct wording would be)
fig2E (fsc1delta)

abolished protein localization  ER  with protein misloicalized to cytoplasm

abolished decreased endoplasmic reticulum autophagy during endoplasmic reticulum stress.

that last one doesn't make sense as written - copy/paste mishap?

yup fixed

adding IDs for future ticket searches (forgot back when this closed):
normal macroautophagy during cellular response to endoplasmic reticulum stress FYPO:0007444
abnormal reticulophagy FYPO:0007445
decreased reticulophagy during cellular response to endoplasmic reticulum stress FYPO:0007446
abolished reticulophagy during cellular response to endoplasmic reticulum stress FYPO:0007447
normal reticulophagy during nitrogen starvation FYPO:0007448
abolished protein localization to endoplasmic reticulum, with protein mislocalized to cytoplasm FYPO:0007449

adding IDs for future ticket searches (forgot back when this closed):
normal macroautophagy during cellular response to endoplasmic reticulum stress FYPO:0007444
abnormal reticulophagy FYPO:0007445
decreased reticulophagy during cellular response to endoplasmic reticulum stress FYPO:0007446
abolished reticulophagy during cellular response to endoplasmic reticulum stress FYPO:0007447
normal reticulophagy during nitrogen starvation FYPO:0007448
abolished protein localization to endoplasmic reticulum, with protein mislocalized to cytoplasm FYPO:0007449


[AIRFLOW-373] Enhance CLI variables functionality

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-373

Testing Done:

Extended CLI unit tests

Add export/import to/from json file option for CLI variable command.
Add delete variable option for CLI variable command.

+1 after the code style (landscape) errors are fixed.

@r39132 does this overlap with any existing CLI functionality? Thought I recall being able to set variables via CLI already (can't find it now though, but CLI is getting pretty complex).

@criccomini currently the CLI is capable of manually setting and getting a variable. This adds functionality to import a file to set multiple at once, and also export values to a file.

Ah, got it. Nice!
Random thought: a similar feature for connections would be interesting (though would require passwords to be in the file). There was some discussion on the mailing list about this.

@criccomini the true value of this functionality is that we can now set up variables using automation! With this CLI subcommand for the existing variables command, we can easily set up a new airflow services, exporting and importing variables. I agree the connection export/import would be the next useful piece to add.

FYI.. this was actually merged.. but was left open for some reason so I am closing it.


Handle defaultValue NULL for MySQL driver (with unit test)

I also updated another test (with 9 columns -> with 10 columns) since it was impacted.

Should fix #254

Considered as bugfix. Is also going to be released under v0.9.12 as soon as all travis tests passed.


Add images to canvas

Is it possible to select images from the phone gallery and add it to canvas?

@arunnambissan  have you successfully linked to this library?

No. I have implemented fetching the image URI of an image from the gallery. But didn't find a way to add inside the canvas.

Any update on this ?

@arunnambissan @paraswattschicmic @krishcdbry
localSourceImage={this.state.imageEditorBackgroundImage}

@creambyemute , is you localSouceImage gets a little bit blurred when you take picture of text?

Can we add multiple images on canvas?


feat(tutorial): complete step 1

Closes "Installing Carbon"
Complete first step of the tutorial.
Changelog
New

Create a web app with the UI shell component

Changed

package.json scripts to run properly on WIndows 10

@sergey-siuchanka Looks great 💯 ! I've recorded your completion of step 1.


Update clean db dump to overwrite supplier contact details

We should remove this PII from our dev data

@samuelhwilliams Good shout


Updates, Improvements & standardizations

Is this PR still relevant?

Can this be closed?

Closing this as it has been superseded in another PR.


Delete Version check logic

closes: #89

UPDATE: We identified the root cause and it fixed. but because that the applied code is vulnerable due to trusting all certificates during interacting with GitHub API.
We will continue to explore more safer way to fetch versions and checking for updates. Until it is discovered, the update checking functionality is replaced to opening browser to check version manually.


Multi root: search in folder no longer allows to provide file types

Steps to Reproduce:

have a multi root setup
right click on a folder to search in that folder
add a file extension to the end (e.g. *.ts)
search

=> no results found

https://github.com/Microsoft/vscode/issues/29924


Slf4jLogConsumer improvements

Adds support for MDC
Uses log levels based on output type

Thanks for making the change - I just have one final tweak request and then I think we're good to merge.

Thanks @toadzky - will merge


fix: cmfpackage save

can we get a test for this, so we don't regress again?

tests added 9df7426


Don't run rpmqa plugin if koji configured

No need to run rpmqa if koji_promote will be fetching that data anyway and koji-containerbuild won't need its output.

Should be an osbs-client issue.


Add RefreshMode and Times to Java Gateway

Idea: avoid sending too much data over the network. Setting a polling interval will reduce traffic, normally 30 seconds resolution should be enough.
Ideas:

set a value > 0 as default, however this changes current behavior, maybe expectations of certain users.
limit the value to a maximum. Is there any risk of the car becoming unresponsive while HV battery is active? Maybe setting too high values (like 10 minutes) kills the purpose of the gateway?

As described here (issue 46) the polling time should be  implemented by MQTT (refresh/period/active or refresh/period/InActive). So it's not necessary to implement a commandline option.

OK, means that functionality is right, but should base on that topics instead of parameter? Could change that in the afternoon.

Both Gateways should work the same way, so take a look at saic-python-mqtt-gateway.
The idea is that the gateway does nothing without a motor start message or forced updates over mqtt. It only looks for these start conditions, but without it there is only one poll per day (inActive value). But the active value defines how often you get an update while driving (30s is default).
Additionally you can change the mode of polling with the topic saic/xxx/vehicles/xxx/refresh/mode/set:

off
periodic (like auto mode)
force

Under these conditions the 12V battery drain should be minimized enough :)
On the python gateway there is a third way to poll: OpenWB Loadpoint Map. But i think this is not planned for java.
So there is still a lot to do...

Hi,
I switched the logic to the behavior I understood from the python gateway.
However, what I don't like, it seems as if restarting the gateway will also reset the values to the default (30s/1day). Is that correct and expected? I would rather like to check if there is a value in the topic and use it, or else set the default...

I have been wanting to test the feature directly on the vehicle, but API seems broken right now, not sure if it only affects my car or the API in general. I would be OK to wait until it is completely testable...

Thanks for the PR, I'll try to test it next weekend. :)

Fixed the FORCE issue, and added some logging in case SAIC API fails to make the behaviour of the gateway more transparent. Also each gateway refresh now causes a log entry (with 30s refresh delay it is manageable). If you consider this to be rather a debug message (LOGGER.info("Refreshing vehicle status...");), then we could change it. In this case I might also suggest switching all the JSON printing stuff to trace so users can use the debug flag to get usable information...

Added one more commit to better group code by feature...
Added a workaround to keep chargeStatus from being called if vehicleStatus was not succesful.

Did some more detailed testing and modified some other things. One question I would have is that right now, if we switch from active to inactive mode, it will do it more or less immediately. With the 1day inactive timer, chances are big that charging status will never be caught, as there is no charging start message afaik. Is there a grace period that should be implemented to overlap the active mode for a few minutes after engine stopped?

Before this change, I had a grace time from 10 Minutes after engine off (or charging end) was detected. I think we should keep something like that. Maybe also make it configurable?
Thanks for all your work by the way. I will go over the PRs soon, time is a bit sparse at the moment.

Will check the Python code and compare it, if we set a configurable value, it will need to be set as a topic. Shall I propose one?

@tisoft , please review the topic name for the 10m tolerance after shutdown as this is a proposal from me, didn´t find it documented anywhere...

Lets's discuss the name here: https://github.com/orgs/SAIC-iSmart-API/discussions/6#discussioncomment-5923443

The topic constants sometimes start with a / and sometime not, same for their ending. I think we should remove all leading and trailing / in the constants and handle that in the place they are used.
Currently the topics for refresh, drivetrain and climateare broken, because they are missing a /.

@mschmiedel I rebased the commits a bit and squashed the format/lint into the corresponding commits.
Will do a final review tomorrow and then do the merge.

@mschmiedel Vielen Dank für den PR!


msal-browser and omniauth for rails api only backend

Hi,
not sure if this is the right place to ask, but what is the best way to use omniauth and msal.browser msal-react for a rails api with omniauth?
Thanks!

@arpu you're right, this isn't the best place to ask. You will probably have more luck on Microsoft Q&A, tagging your question with Microsoft Entra ID.


Missing release tag for 1.8.0

Nuget is showing a new package version of 1.8.0 but there is no associated tagged release with change notes in this repo. Please add so users can evaluate upgrading.
It would also be nice if a CHANGELOG file were added to consolidate change history for the same purpose.

Thanks for pointing this out. https://github.com/Azure/azure-signalr/releases/tag/v1.8.0


Can't extend {way_name} with an option on Transifex

I prepared new feature for OSRM Text Instructions - grammatical cases support for way names. This is quite important for many languages (Russian, Ukrainian, Polish, Bulgarian, Finnish, Estonian and many others) - otherwise translated strings with inserted way names (in nominative case as in OSM) look grammatically incorrect in most cases. Moreover, I don't know any other navigation system that could do this properly (except my humble attempt to improve Garmin TTS voices :wink:). I would be proud to make OSRM Text Instructions the first system with grammatical case support but I can't :disappointed:
The main idea of this future feature is in extending {way_name} and {rotary_name} variables in target language's strings with explicit grammatical case label - {way_name:accusative} for example - and processing way names with block of regular expressions grouped by this grammatical case.
But Trasifex rejects my attempts to change "Turn left onto {way_name}", in Russian "Поверните налево на {way_name}" to "Поверните налево на {way_name:accusative}" with "Missing {way_name} variable error" :disappointed_relieved: Other variants ({way_name}{accusative} for example) also don't work due to difference with variables from original English string.
My experience with TTS voices reveals that determining required grammatical case for part of whole text is not the simple task and could be easily done only for known and expected words combinations. Actually this could be implemented too but extends already big regular expressions file (already ~900 expressions for Russian street names only) some more.
I don't like the extending all translation strings with proposed grammatical case option - this has no sense for them. I don't want to extend English strings only with this option - this invalidates all existing translations. I would like to update Russian (currently) translation only. Maybe some Transifex checks could be suppressed/updated to allow non-exact match of variables?
@1ec5, @freenerd, @TheMarex, need your advice please.

Whole feature description for reference (from uncommitted changes):
Grammar support
Many languages - all Slavic (Russian, Ukrainian, Polish, Bulgarian, etc), Finnic (Finnish, Estonian) and others - have grammatical case feature that could be supported in OSRM Text Instructions too.
Originally street names are being inserted into instructions as they're in OSM map - in nominative case.
To be grammatically correct, street names should be changed according to target language rules and instruction's context before insertion.
Actually grammatical case applying is not the simple and obvious task due to real-life languages complexity.
It even looks so hard so, for example, all known native Russian navigation systems don't speak street names in their pronounceable route instructions at all.
But fortunately street names have restricted lexicon and naming rules and so this task could be relatively easily solved for this particular case.
Implementation details
The quite universal and simplier solution is the changing street names with the prepared set of regular expressions grouped by required grammatical case.
The required grammatical case should be specified right in instruction's substitution variables:

{way_name} and {rotary_name} variables in translated instructions should be appended with required grammar case name after colon: {way_name:accusative} for example
languages/grammar folder should contain language-specific JSON file with regular expressions for specified grammar case:

{
    "v5": {
        "accusative": [
            ["^ (\\S+)ая-(\\S+)ая [Уу]лица ", " $1ую-$2ую улицу "],
            ["^ (\\S+)ая [Уу]лица ", " $1ую улицу "],
            ...

All such JSON files should be registered in common languages.js
Instructions text formatter (index.js in this module) should:

check {way_name} and {rotary_name} variables for optional grammar case after colon: {way_name:accusative}
find appropriate regular expressions block for target language and specified grammar case
call standard string replace with regular expression for each expression in block passing result from previous call to the next; the first call should enclose original street name with whitespaces to make parsing words in names a bit simplier.

Strings replacement with regular expression is available in almost all other programming language and so this should not be the problem for other code used OSRM Text Instructions' data only.
If there is no regular expression matched source name (that's for names from foreign country for example), original name is returned without changes. This is also expected behavior of standard string replace with regular expression. And the same behavior is expected in case of missing grammar JSON file or grammar case inside it.

Example
Russian "Большая Монетная улица" street from St Petersburg (Big Monetary Street in rough translation) after processing with Russian grammar rules will look in following instructions as:

"Turn left onto {way_name}" => ru:"Поверните налево на {way_name:accusative}" => "Поверните налево на Большую Монетную улицу"
"Continue onto {way_name}" => ru:"Продолжите движение по {way_name:dative}" => "Продолжите движение по Большой Монетной улице"
"Make a U-turn onto {way_name} at the end of the road" => ru:"Развернитесь в конце {way_name:genitive}" => "Развернитесь в конце Большой Монетной улицы"
"Make a U-turn onto {way_name}" => ru:"Развернитесь на {way_name:prepositional}" => "Развернитесь на Большой Монетной улице"

Design goals

Cross platform - uses the same data-driven approach as OSRM Text Instructions
Test suite - has prepared test to check available expressions automatically and has easily extendable language-specific names testing pattern
Customization - could be easily extended for other languages with adding new regular expressions blocks into grammar support folder and modifying {way_name} and other variables in translated instructions only with necessary grammatical case labels

Notes

Russian regular expressions are based on Russian Garmin TTS voices update project; see file with regular expressions to apply to source text before pronouncing by TTS.
There is another grammar-supporting module - jquery.i18n - but unfortunately it has very poor implementation in part of grammatical case applying and is supposed to work with single words only.
Actually it would be great to get street names also in target language not from default OSM name only - there are several multi-lingual countries supporting several name:<lang> names for streets. But this the subject to address to OSRM engine.

:+1: would be nice to have correct grammatical cases!
The note about OSRM is doable, but would require a change in datafacde interface   to virtual StringView GetStringForID(const NameID id, StringType, ISOLocale) const = 0;, that will involve changes in lua profiles, extraction, path annotation and name table parts /cc @TheMarex @danpat

@oxidase, BTW actually it's a bit harder to apply grammatical cases to Ukrainian streets - they use "sorting" words order (that's street status name is always last) instead of "natural" words order in Russian OSM. But there is known solution for this - Garmin maps use "sorting" words order everywhere so I should be aware about this too :wink:

Thanks @yuryleb, this is a great issue providing a lot of awesome context. Awesome 🎉
Overall this sounds like an interesting problem we want to solve in osrm-text-instructions and the plan you outlined sounds reasonable.
We are looking into if there are other language-specific cases we would want to handle with a similar pattern and only want to integrate something that can hit more of these cases at once. That will take a bit of time. If you want to go ahead and implement your approach now we are happy top consider it, but I can not guarantee you we will merge it soon.
I'm not sure yet how we'd solve the problem with Transifex variables. As an ugly hack we have overrides right now, but these so far were not used for adding new content, which would remove some of the translation from Transifex and therefore make translating harder.
The ruleset you build for the Garmin TTS is very impressive. Including these in the language JSON will likely make sense then. Likely these could be added via overrides, since they don't have to be handled in Transifex.

Actually the JSON with regular expressions to apply grammatical cases only looks not so huge :wink: I also worried about that. I tested my feature on local frontend instance and saw no any responses delays or memory overdraft (as it was possible without special profiling tools actually).
I feel it would be better to publish my changes as PR for public review. Of course, I don't expect it will be merged soon or merged at all.

But Trasifex rejects my attempts to change "Turn left onto {way_name}", in Russian "Поверните налево на {way_name}" to "Поверните налево на {way_name:accusative}" with "Missing {way_name} variable error" 😥

Is it a warning, or does Transifex actually disallow the translation? If it’s just a warning, I’ve just made you a reviewer for Russian, so you can “review” the string to suppress the warning.

@1ec5, it was error for me early and I couldn't save my changes. I'll try now.

Thanks @1ec5 but I still can't save changes even with Reviewer rights with the same 'Missing {way_name} variable error':

And I don't think this will be a good solution - any new contributor with regular rights can't save his changes here without restoring original {way_name} instead of my {way_name:dative} here :disappointed:
There should be some option in Transifex to control this...

How tied are we to JSON, at least as the format we use to communicate with Transifex? It isn’t particularly well-suited for localization, as #19 points out. The native .stringsdict format on iOS and the Android strings XML format both have built-in support for grammatical gender and number. It’s unfortunate that we have to roll our own ad-hoc translation format atop JSON; we’d probably end up having to reverse engineer that into .stringsdict and Android strings XML for the native platforms.

Added avoidance in redesigned #102 to insert grammatical case labels in override post-Transifex script (for Russian language only)


Demo isn't working

Hey man, that's me right now:

I was spending 2 days figuring out why the widget is not working, even copying your whole demo expo project.
Now i saw that you wrote in your recent version that new gen isn't supported, however its enabled in your demo project.
Please fix it to save lives.

Sorry it wasn't more clear.
I set newArchEnabled to false in the expo demo, and opened #110 to track the crash on new arch.


cmd/compile: internal compiler error: init .autotmp_0 recorded as live on entry

$ gotip version
go version devel +c99300229d Mon Jun 18 23:20:57 2018 +0000 linux/amd64

The following program (reduced from a gosmith-generated one):
package p

var F = []func(){
	func() func() { return (func())(nil) }(),
}

var A = []int{}

type ss struct {
	string
	float64
	i int
}

var V = A[ss{}.i]

crashes the tip compiler when building for GOARCH=wasm with optimization disabled:
$ GOOS=js GOARCH=wasm gotip build -gcflags=-N crash.go
# command-line-arguments
<autogenerated>:1: internal compiler error: internal error: init .autotmp_0 (type ss) recorded as live on entry

goroutine 34 [running]:
runtime/debug.Stack(0x0, 0x0, 0x0)
	/home/alberto/go/src/runtime/debug/stack.go:24 +0xa7
cmd/compile/internal/gc.Fatalf(0xcc3c19, 0x2f, 0xc000535968, 0x2, 0x2)
	/home/alberto/go/src/cmd/compile/internal/gc/subr.go:182 +0x1f7
cmd/compile/internal/gc.(*Liveness).epilogue(0xc000502420)
	/home/alberto/go/src/cmd/compile/internal/gc/plive.go:1159 +0x1642
cmd/compile/internal/gc.liveness(0xc000500000, 0xc000502000, 0x0, 0x0, 0x0)
	/home/alberto/go/src/cmd/compile/internal/gc/plive.go:1690 +0xc4
cmd/compile/internal/gc.genssa(0xc000502000, 0xc0005181c0)
	/home/alberto/go/src/cmd/compile/internal/gc/ssa.go:4777 +0xbe
cmd/compile/internal/gc.compileSSA(0xc0004f6000, 0x0)
	/home/alberto/go/src/cmd/compile/internal/gc/pgen.go:269 +0x1bc
cmd/compile/internal/gc.compileFunctions.func2(0xc0004d8a80, 0xc0004b01b0, 0x0)
	/home/alberto/go/src/cmd/compile/internal/gc/pgen.go:323 +0x49
created by cmd/compile/internal/gc.compileFunctions
	/home/alberto/go/src/cmd/compile/internal/gc/pgen.go:321 +0x11a

cc @neelance

I've investigated this a bit, but I'm not sure on the details of the liveness analysis.
@aclements Question: How does VarDef relate to other operations, especially Addr? Is the following a valid order?
v27 (15) = Addr <*ss> {.autotmp_0} v2
v28 (15) = VarDef <mem> {.autotmp_0} v22

"recorded as live on entry" means that the liveness analysis thinks that a pointer contains a meaningful value (is live) when the function begins, before even considering arguments (on entry). In practice, usually this means that you have a "use before assignment/initialization" problem.
For most of SSA world, Value order is meaningless. VarDef relates to other values through the memory chain (an ordering implicit by values that have a memory argument and values that have memory type). The schedule pass is responsible for putting values in a good order; it should use the memory chain as part of that.
You might want to try running with the SSA check enabled. It can often spot problems in SSA form earlier and help pinpoint them.

It looks to me that we take the address of .autotmp_0 before the VarDef. The liveness code probably considers the autotmp should be live at this point, then back it up to the function entry. The address is used to compute an offset, and the offset is not used until after the VarDef.
v56 (15) = LoweredAddr <*ss> {.autotmp_0} v2
v52 (15) = I64AddConst <*float64> [16] v56 : R2
... // no use of v52 until later

Later,
v28 (15) = VarDef <mem> {.autotmp_0} v22
...
v51 (15) = F64Store <mem> [0] v52 v62 v53 // use of v52

On other architectures, address operation takes offset, and it is rematerializeable, so it is moved down right before use. However, on Wasm, while LoweredAddr is rematerializeable, it doesn't take offset, and the offset calculation (I64AddConst) is not rematerializeable, so it is not moved down. Maybe we should make LoweredAddr take offset.

I am still thinking about which compiler phase is to blame. As far as I understand it is not really wrong to have a LoweredAddr and I64AddConst above the VarDef (even after the schedule phase), since both operations don't access the memory. And without mem parameters, we can't really make it end up in a better order. So my current conclusion (without knowing that much) would be that the liveness analysis should be okay with this output and not throw an error.

Yes, I think the generated code is not wrong. It might be possible to change liveness code to not think it live when the address is taken, but until the address is used. I'm not sure. The tricky part is what uses are considered make it live? Load/Store should be. Offset calculation is not, but it needs to propagate the value. Passing address to a Call should make it live. What about Phi? Anything else?

I'm not working on this right now. I could take a look, maybe tomorrow.
I think for Go 1.11 we probably want to have some simple workaround, if possible. If we want to change the liveness code, it's gonna be complicated. As we're late in the freeze, I would suggest not to change the liveness code now, and we can revisit in Go 1.12.


Edit hdinsight-giraph.md

Edit complete. Sending this feedback to Larry:
Line 55: You mention a 2014 date. Is there an update on that issue? Note that we are no longer using the term “Windows Azure” so trying to write around it.
Bullets around line 73-77: You should be listing the most recent version first
Line 111: Image is not showing
Line 148: I think you should move this ahead of the command so the user knows to change it before running the command.
Line 169: Image is not showing
Line 185: “may” is nebulous. If they don’t work, say that.

Hi @ClarityQueen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-diree). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

These changes look fine.

@ClarityQueen
Hi, Dia, This was a deprecated article that should have been removed from the repo. Sorry! I'm going to close this PR without accepting, and delete the article.
Thanks!
Carolyn


adding varscan pipeline

contains
varscan.py wrapper script that runs the jeltje/varscan docker container on encrypted bam inputs from S3. Outputs to local dir or encrypted S3
launch_varscan_mesos.sh to run on toil mesos cluster
config.txt example input S3 bam files

What Ticket does this refer to?

I'm sorry, I'm really not that familiar with the git system. You told me to create a PR, so I created a PR...


[Android] TabNavigator incredibly slow when tabs have content (FlatList)

Current Behavior
I have a TabNavigator inside of a StackNavigator and the behavior when a tab is pressed is extremly laggy when the tabs include a FlatList (or ListView). When the tabs dont have any content, then there are no lags and everything works like in the Expo example. The array of the FlatList only has 10 entries (rows).
Environment
Samsung Galaxy S6, Debug mode is turned off (with debug the app is not really usable anymore because of extreme lags).
react-native: 0.46
react-navigation: newest version from master branch (commit 2b40182cd72861691956f059e56535c1994abd57)

Can you make a repo showing code that reproduces this?

@matthamil I think I have resolved the issue by changing "Component" to "PureComponent" in my FlatList. Now, the tabs change more smoothly.
I guess the FlatList was re-rendering all the time when I used "Component" and changed the tabs.

Glad you got it resolved :). Do you think it's resolved enough to close the issue?

Yes I think that was the reason. However, quite strange that it laged so much when I used "Component", even though the FlatList only had 10 rows.


fixset mark join reference for bitmap-in-apply

Proposed changes
pick #35435
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Missing heroes (Junkrat and Torbjorn)

Hello,
i found that torbjon and junkrat are missing.
Why?

Hello, I'm retrieving the data from Blizzard pages, and it seems they are not here anymore 😅 Will have to wait for Blizzard to fix it.
https://overwatch.blizzard.com/en-us/heroes/

https://overwatch.blizzard.com/en-us/heroes/
https://overwatch.blizzard.com/en-us/career/GGuppy-1953/
Both characters appear in both of those links for me. but still not pulling stats for them.

U have private profile.
You need to open the profile privacy

My profile was public at the time, had to private it for separate reasons.
Here's another example:
https://overwatch.blizzard.com/en-us/career/DaddyRod-11680/
https://overfast-api.tekrop.fr/players/DaddyRod-11680
Here is the snippet I'm having issues with. Junkrat and Torbjorn are both missing.
"stats": {
  "pc": {
    "quickplay": {
      "heroes_comparisons": {
        "time_played": {
          "label": "Time Played",
          "values": [
            {
              "hero": "reinhardt",
              "value": 98315
            },
            {
              "hero": "ana",
              "value": 64319
            },
            {
              "hero": "hanzo",
              "value": 59831
            },
            {
              "hero": "genji",
              "value": 59670
            },

@GGuppyGit On your example, both heroes are not displayed at all on Blizzard page, is it also the case for you ? As the API is based on those pages, that's why they're both missing.

They appear for me.

OK I investigated a bit more, and I found out why : it seems linked to the user location for some reason 🤦
I'm located in France, and so are my servers hosting the API, and Junkrat and Torbjorn are not displayed at all, either on the profile page or the heroes page.
I tried loading both pages with a VPN located in US, and they both appeared on the profile page and the heroes pages...

wow, nice job blizzard!

I left a bug report on their forum as a last resort, hoping they will notice and fix this x)
https://us.forums.blizzard.com/en/overwatch/t/junkrat-and-torbjorn-missing-on-heroes-page-and-career-page/849903

Seems to be fixed one way or another

Indeed they're back on Blizzard pages for me, and back on the API 😄 IDK if they saw my post on their forum but good timing, I'm closing the issue then 👍


Project Name Escaping/Checking

Handle cases in which Project names are empty//add testing for various special character, etc.

Project name isn't an important detail, and will no longer be visible to the user once #230 is complete.


Making the App Crashed Messages more descriptive

Problem
Whenever there is a line in the code that does not break during nargo check (syntactic), but does during nargo prove, the error message is something like:
The application panicked (crashed).
Message:  internal error: entered unreachable code: logging this expression type is not supported
Location: crates/noirc_evaluator/src/ssa/context.rs:1181
This is a bug. We may have already fixed this in newer versions of Nargo so try searching for similar issues at https://github.com/noir-lang/noir/issues/.
If there isn't an open issue for this bug, consider opening one at https://github.com/noir-lang/noir/issues/new?labels=bug&template=bug_report.yml
If this could be made more descriptive, it would surely help the devs in the ecosystem.
Happy Case
A message along the lines:
This error is caused because Noir doesn't allow tuple elements to be used in an std::println statement. This is a bug that has not yet been corrected in the latest version. The issue is already logged as an issue on the Noir GitHub.
or something like that would help avoid duplicate bug logging, as well as keep newer devs updated on the progress.
Alternatives Considered
Even if the message just mentions if something has been corrected in any version so far at all would be quite helpful.
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Assigning this to you @f01dab1e

I'm not sure what's actionable here other than just generally replacing panics in the evaluator with RunTimeErrors.
The described panic no longer exists and I think the happy case is "E-HIGH" as we'd need nargo to be able to diagnose arbitrary panics (as if we knew in advance that could be a panic then we'd turn it into an error), look these up against some external registry which would need to be maintained, etc.

I'm not sure what's actionable here other than just generally replacing panics in the evaluator with RunTimeErrors.
The described panic no longer exists and I think the happy case is "E-HIGH" as we'd need nargo to be able to diagnose arbitrary panics (as if we knew in advance that could be a panic then we'd turn it into an error), look these up against some external registry which would need to be maintained, etc.

I was mainly looking at this part of the error message:

This error is caused because Noir doesn't allow tuple elements to be used in an std::println statement

Which was a lot more user friendly to read.
Agreed that it would be E-HIGH if we needed to specify whether the issue has already been solved; we don't want to do this, thanks for pointing that out!


Show RT/Repost in two points of a Timeline

I think that it's logical: I'm doing a repetition, anyway, it's more comfortable: if I Repost anything and later mark as favourite, I have to go upside of my timeline, favourite it and go down again to keep reading the Home TL.

The problem is solved in AndStatus v.36:
The whole internal data model of the application has changed from working with "messages" to working with "activities", allowing to present social networks in a richer way and to solve many old problems. E.g. after reblogging of a message the message doesn't "jump" to the top of a timeline, as before: now you see a new "Reblog action" for this message at the top the timeline.
The same for Like/Favorite and Follow/"Stop following" actions...


Parameters to custom connector

Hi,
I've been trying to get my custom connector to be able to take parameters much like the SQL database connector.

However I can't seem to find any information on how to recreate this feature. My guess is that it might have something to do with Value.ReplaceType but I've only seen examples where you give allowed values.
Thanks in advance.

Hey!
This is currently a gap that has been already identified and is being tracked internally at Microsoft.
The Power Query experience on desktop will be replaced by the Power Query experience found online in products such as Power BI Dataflows. We do not have an ETA on when this will effectively happen, but we will be addressing the current "Parameters" input gap in the new Power Query experience.


wip: genesis tests

Please, do not review yet.
PRs involved (see all PRs labeled with “Genesis”):

#368
#371

All the commits here have been squashed in #434


Feat/progressbar valueformatter

This is related to pr https://github.com/spectreconsole/spectre.console/pull/1388 and issue https://github.com/spectreconsole/spectre.console/issues/1382
Goal is to provide formatting for number values in the progress bar

[x] I have read the Contribution Guidelines
[x] I have commented on the issue above and discussed the intended changes
[x] A maintainer has signed off on the changes and the issue was assigned to me
[x] All newly added code is adequately covered by tests
[x] All existing tests are still running without errors
[x] The documentation was modified to reflect the changes OR no documentation changes are required.

Not sure I know what this Pull Request / Documentation error is about
Error: Inputs/Process » ExecuteIf » ExtractFrontMatter » ParseYaml » [/home/runner/work/spectre.console/spectre.console/docs/input/widgets/breakdownchart.md => widgets/breakdownchart.md] (Line: 4, Col: 13, Idx: 126) - (Line: 4, Col: 13, Idx: 126): Block sequence entries are not allowed in this context.

Merged! Thank you for your contribution. Much appreciated! 👍


BYOE Documentation Update/Clarification - Buffer Configuration

I have set the SC4S_DEST_SPLUNK_HEC_DEFAULT_DISKBUFF_DIR to a local directory on my SC4S machine and it does not seem to work.  Nothing ever gets cached there when SC4S cannot establish an HEC connection to Splunk.  Is there anywhere I can look to figure out what the issue is?

@mattweber78 thank you for pointing this out , we will check this, there is a possibility that there is a gap in doc and Code in BYOE ( as BYOE is still a work in progress), we will update as soon as possible.


Area search doesn't seem to work

After a 24 hours parsing of the Europe dataset from Geofabrik I have the overpass api succesfully running inside the docker container.
Simple overpass queries seem to work just fine but for some reason area limiting doesn't seem to work, no error, just no results. Below query works fine on the public overpass-turbo server but not on my own instance.
{{geocodeArea:Germany}}->.country;
rel(area.country)["boundary"="administrative"]["name"~"Main"][admin_level=10];
out geom;

area["ISO3166-1"="DE"][admin_level=2];
rel["boundary"="administrative"]["name"~"Mainz"][admin_level=6](area);
out geom;

When I remove the area restriction it works but it returns all matches inside Europe.
Any idea?

Are you sure that areas have been calculated? Area's calculation is not part of the initialization script. Please check contents of the file inside containter /db/db/rules_loop.log if any update has finished, like:
2018-12-19 06:52:08: update started
2018-12-19 07:08:29: update finished

Above entry is only for one country. For whole EU it might take considerably longer to compute.

@wiktorn Ah, I guess it's still running then:
2018-12-19 06:39:46: update started
Nothing about it being finished. I'll wait for that then and try again.
Thanks for your quick help here!

I guess that's solved.

Is there any way to determine when area creation has finished and area queries become available?
I've setup the docker image yesterday for the whole planet and area queries return no elements yet.
My rules_loop.log looks like this:
2020-06-12 06:20:55: update started
2020-06-12 07:31:02: update started
2020-06-12 07:31:03: update finished
2020-06-12 07:32:42: update started
2020-06-12 17:40:14: update started
2020-06-12 17:40:14: update finished
2020-06-12 17:40:17: update started
2020-06-12 17:47:28: update started
Thanks for a hint.

Entry in rules_loop.log like one that you see:
2020-06-12 17:40:14: update finished

Means that area calculation has ended and area queries should be working.
Though I worry that you see two starts and only one finish. What did you set for OVERPASS_RULES_LOAD?
Are you sure that you don't have two containers running from one database directory?

Hm, I restarted the container 2 or 3 times today. I left OVERPASS_RULES_LOAD at the default, but changed it to 20 now on the latest start (the 17:47 time stamp).
First startup was yesterday in the evening. Today in the morning, after I saw the "Update finished" message, I tried a simple area query:
[out:json][timeout:5];
area[name="London"];
out body;
Then I waited until the evening. Nothing yet.
Are there other signs to see if areas should be available?

If you use areas there should be header informing about the date of areas, as follows:
curl -g 'http://localhost:12345/api/interpreter?data=[out:json];area[name="London"];out;'
{
  "version": 0.6,
  "generator": "Overpass API <IP_ADDRESS> eb200aeb",
  "osm3s": {
    "timestamp_osm_base": "2020-06-11T20:58:48Z",
    "timestamp_areas_base": "2020-06-11T20:58:48Z",
    "copyright": "The data included in this document is from www.openstreetmap.org. The data is made available under ODbL."
  },
  "elements": [

  ]
}

(This instance doesn't have UK data).
Anyway since c764547808a3089a9587c4d2b8d782c036a69881 areas are generated during initial container setup, so they should be working right away, after first exit of container.

Ok, thanks. This is my output one day later:
{
  "version": 0.6,
  "generator": "Overpass API <IP_ADDRESS> eb200aeb",
  "osm3s": {
    "timestamp_osm_base": "2020-06-13T06:09:58Z",
    "copyright": "The data included in this document is from www.openstreetmap.org. The data is made available under ODbL."
  },
  "elements": [
  ]
}

I try again from scratch with this environment variables:
      - OVERPASS_META=yes
      - OVERPASS_MODE=clone
      - OVERPASS_DIFF_URL=https://planet.openstreetmap.org/replication/minute/
      - OVERPASS_RULES_LOAD=20
      - OVERPASS_UPDATE_SLEEP=300

I let you know in the evening how it went. Thanks for your help so far. This is a great image. I tried it myself last year (jhassler/overpass-api), but now I'm going to switch to this one. Great work!

Ok, so it looks like areas have failed to build. Do you have any logs from container creation, such as these:
Update finished with status code: 3
<?xml version="1.0" encoding="UTF-8"?>
<osm version="0.6" generator="Overpass API <IP_ADDRESS> eb200aeb">
<note>The data included in this document is from www.openstreetmap.org. The data is made available under ODbL.</note>
<meta osm_base="2020-06-11T20:50:38Z" areas="2020-06-11T20:50:38Z"/>

After 0h0m15s: in "make-area", part 0, on line 29. Stack: 0 of 0 1109 of 0
After 0h0m30s: in "recurse", part 0, on line 255. Stack: 0 of 0 725 of 0 0 of 0
After 0h0m45s: in "recurse", part 0, on line 255. Stack: 0 of 0 3600 of 0 0 of 0
After 0h1m0s: in "make-area", part 0, on line 257. Stack: 0 of 0 6198 of 0
After 0h1m15s: in "make-area", part 0, on line 257. Stack: 0 of 0 7807 of 0
After 0h1m30s: in "recurse", part 0, on line 255. Stack: 0 of 0 10398 of 0 0 of 0
After 0h1m45s: in "make-area", part 0, on line 257. Stack: 0 of 0 13265 of 0

</osm>
Overpass ready, you can start your container with docker start

(This was for small extract). If you have whole world, your areas creation might have timed out, as by default, it's only allowed 86400 seconds to finish. See the file /app/etc/rules/areas.osm3s within container.

I think when creating the container by cloning, the areas are not created initially. The process is started upon first start after cloning.
I restarted everything from scratch in the morning. Cloning was done in about an hour. Now I have one line in my rules_loop.log:
2020-06-13 07:37:58: update started

The current logs output stuff like this:
After 10h39m7s: in "make-area", part 0, on line 257. Stack: 0 of 0 1538393 of 0
After 10h39m22s: in "make-area", part 0, on line 257. Stack: 0 of 0 1540403 of 0
After 10h39m37s: in "recurse", part 0, on line 255. Stack: 0 of 0 1543817 of 0 0 of 0
After 10h39m52s: in "make-area", part 0, on line 257. Stack: 0 of 0 1546804 of 0
INFO: Using replication server at https://planet.openstreetmap.org/replication/minute/
DEBUG: Using given sequence ID 4064023
DEBUG: Starting download at ID 4064024 (max 100 MB)
DEBUG: Downloaded change 4064024. (102190 kB available in download buffer)
DEBUG: Downloaded change 4064025. (102013 kB available in download buffer)
DEBUG: Downloaded change 4064026. (101964 kB available in download buffer)
DEBUG: Downloaded change 4064027. (101803 kB available in download buffer)
DEBUG: Downloaded change 4064028. (101372 kB available in download buffer)
/app/bin/update_database --version=2020-06-13T18:17:01Z --compression-method=gz --map-compression-method=gz --flush-size=16 --meta
Reading XML file ... finished reading nodes. Flushing to database .....After 10h40m7s: in "make-area", part 0, on line 257. Stack: 0 of 0 1548868 of 0
After 10h40m22s: in "make-area", part 0, on line 257. Stack: 0 of 0 1550027 of 0
. done.
Reading XML file ... finished reading ways. Flushing to database ....After 10h40m37s: in "make-area", part 0, on line 257. Stack: 0 of 0 1551364 of 0
.After 10h40m52s: in "make-area", part 0, on line 257. Stack: 0 of 0 1552624 of 0
After 10h41m7s: in "make-area", part 0, on line 257. Stack: 0 of 0 1555364 of 0
After 10h41m23s: in "recurse", part 0, on line 255. Stack: 0 of 0 1557910 of 0 0 of 0
After 10h41m38s: in "make-area", part 0, on line 257. Stack: 0 of 0 1560289 of 0
I won't touch the container and see what happens tomorrow.

Ok, done.
After 24 hours and 1 minute the areas loop finished:
2020-06-13 07:37:58: update started
2020-06-14 07:39:09: update finished

... and the API returns data. Great!
Interestingly, the header still does not contain the "timestamp_areas_base".
{
  "version": 0.6,
  "generator": "Overpass API <IP_ADDRESS> eb200aeb",
  "osm3s": {
    "timestamp_osm_base": "2020-06-14T09:14:02Z",
    "copyright": "The data included in this document is from www.openstreetmap.org. The data is made available under ODbL."
  },
  "elements": [

{
  "type": "area",
  "id":<PHONE_NUMBER>,
  "tags": {
    "name": "London",
    "natural": "wetland",
    "source": "NPE",
    "source:alt_name": "OS 1854",
    "wetland": "marsh"
  }
}
[...]

Ok, it wasn't quite finished, I think it got killed like you said after 24 hours. Only a subset of the data was queryable.
I edited /app/etc/rules/areas.osm3s and adjusted the timeout, then I restarted the container and waited another 24 hours.
Now it displays the right header:
{
  "version": 0.6,
  "generator": "Overpass API <IP_ADDRESS> eb200aeb",
  "osm3s": {
    "timestamp_osm_base": "2020-06-16T20:06:01Z",
    "timestamp_areas_base": "2020-06-15T18:30:59Z",
    "copyright": "The data included in this document is from www.openstreetmap.org. The data is made available under ODbL."
  },
...

Actually I'm running on a very fast machine (10 Core 2.6 GHz, 256 GB RAM). Any way to speed this up or use multi processing?

I can only refer you to Overpass API tickets:  drolbr/Overpass-API#540, drolbr/Overpass-API#349 and drolbr/Overpass-API#534.
Generally, maybe local fast SSD storage might help you more with that than cores/RAM (though probably almost whole database fits in your RAM).
Rules_delta might help updating areas faster than initially but this is not something that I've tested.


Disable hotkeys in fullscreen programs.

It would be helpful to have an option to disable all the hotkeys in fullscreen programs. You don't want to be brought to desktop when you're playing games :P
Thank you!

there is only one hotkey running when the clipboard isnt beeing displayed

there is only one hotkey running when the clipboard isnt beeing displayed

Sorry my bad. Did test enough. The default Ctrl+D is very easy to use but could easily be triggered when you're playing any game that utilizes a WASD control scheme.

you can change that in the settings

you can change that in the settings

I know that. But I want to use the default Ctrl+D. Could you add an option to disable the hotkey in fullscreen programs? Never mind if it's too much effort or a feature you don't like :P

Yeah, it's not that easy since it's multiplatform, and I would have to implement each individually.

Yeah, it's not that easy since it's multiplatform, and I would have to implement each individually.

Got it. It would also work if there is a hotkey or right-click menu option to disable the global hotkey. Okay, I admit that this isn't an elegant way to do it lol


Groups authorization not working as expected for GraphQL transformer v2 - Not Authorized

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v16.13.2
Amplify CLI Version
7.6.12
What operating system are you using?
macos
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
no
Amplify Categories
auth, api
Amplify Commands
Not applicable
Describe the bug
Getting:
Not Authorized to access listFoo on type Query
When performing a list on the model
this.apiService.ListFoo();

Expected behavior
Group authentication should work as documented
Reproduction steps

auth rule for groups
cognito user with admin
try to access model data restricting to admin group

GraphQL schema(s)

# Put schemas below this line
type Foo
  @model
  @auth(rules: [
    { allow: groups, groups: ["admin"]},
    { allow: groups, groupsField: "groupsCanAccess", operations: [read] }
  ])
{
  name: String!
  groupsCanAccess: [String]
}

Log output

# Put your logs below this line
error: Error: Uncaught (in promise): Object: {"data":{"listFoos":null},"errors":[{"path":["listFoos"],"data":null,"errorType":"Unauthorized","errorInfo":null,"locations":[{"line":2,"column":3,"sourceName":null}],"message":"Not Authorized to access listFoos on type Query"}]}
    at qe (polyfills.js:1:150135)
    at polyfills.js:1:149161
    at c (main.js:1:251763)
    at S.invoke (polyfills.js:1:140059)
    at Object.onInvoke (main.js:1:147119)
    at S.invoke (polyfills.js:1:139998)
    at S.run (polyfills.js:1:135092)
    at polyfills.js:1:150973
    at S.invokeTask (polyfills.js:1:140745)
    at Object.onInvokeTask (main.js:1:146929)

Additional information
No response

@malcomm - can you give more specifics with how you set up your auth and user groups? Also, how are you making your mutations/create requests? This feature works as expected, so I think you are setting up auth and/or creating records with the incorrect access. Thank you.

@danielleadams - note: this project was previously a transformer v1 implementation.
My setup:

Cognito User
Cognito group: admin
Add user to the admin group
Just trying to list out all the items gives me this error, I'm calling this code:

this.apiService.ListFoo();

@danielleadams - I even deleted my environment and started over from a brand new environment. Still not working. I've tried multiple models to query and no matter what I do the groups auth is not work.

@malcomm What client library are using and is this a mocked or deployed server?

@danielleadams - I'm using Angular on the frontend and calling the generated APIService for the graphql/DynamoDB backend. I have deployed servers that I'm hitting via the standard amplify push. Here's my amplify status:
> amplify status

    Current Environment: devthree

┌───────────┬─────────────────────────┬───────────┬───────────────────┐
│ Category  │ Resource name           │ Operation │ Provider plugin   │
├───────────┼─────────────────────────┼───────────┼───────────────────┤
│ Auth      │ foof6ac14a6.            │ No Change │ awscloudformation │
├───────────┼─────────────────────────┼───────────┼───────────────────┤
│ Api       │ fooapi                  │ No Change │ awscloudformation │
├───────────┼─────────────────────────┼───────────┼───────────────────┤
│ Analytics │ fooui                   │ No Change │ awscloudformation │
└───────────┴─────────────────────────┴───────────┴───────────────────┘

Foo is not the name on the resources, just omitted those to keep it generic for the ticket. I'm happy to supply the specifics of my environments via other channels.

@danielleadams - also of note: it looks like the permissions are setup correctly from the API perspective:
> amplify status api -acm IssueComment

userPools:staticGroup:admin
  ┌───────────┬────────┬──────┬────────┬────────┐
  │  (index)  │ create │ read │ update │ delete │
  ├───────────┼────────┼──────┼────────┼────────┤
  │    id     │  true  │ true │  true  │  true  │
  │  issueID  │  true  │ true │  true  │  true  │
  │ createdAt │  true  │ true │  true  │  true  │
  │ updatedAt │  true  │ true │  true  │  true  │
  │  author   │  true  │ true │  true  │  true  │
  │  comment  │  true  │ true │  true  │  true  │
  └───────────┴────────┴──────┴────────┴────────┘
userPools:staticGroup:practitioner
  ┌───────────┬────────┬──────┬────────┬────────┐
  │  (index)  │ create │ read │ update │ delete │
  ├───────────┼────────┼──────┼────────┼────────┤
  │    id     │  true  │ true │  true  │  true  │
  │  issueID  │  true  │ true │  true  │  true  │
  │ createdAt │  true  │ true │  true  │  true  │
  │ updatedAt │  true  │ true │  true  │  true  │
  │  author   │  true  │ true │  true  │  true  │
  │  comment  │  true  │ true │  true  │  true  │
  └───────────┴────────┴──────┴────────┴────────┘

Hey @malcomm - I've been doing some testing on my end, and it appears the ACM is correct. I'm not able to reproduce your issue with the auth setup you've shared. Do you mind running the queries in AppSync to see if we can isolate the issue to either the front end or the backend?

@danielleadams - I was able to run the query from AppSync when logged into Cognito.

@danielleadams - I looked at my config and setup and it's all pretty standard. The one thing I forgot to mention:
    "aws-amplify": "^4.3.13",

I'm also not using the @aws-amplify/ui-angular package. Instead, I'm handling authentication using my own authentication service. But in the end, it does the same thing:
import { Auth } from 'aws-amplify';

...

  async login(username: string, password: string): Promise<CognitoUser> {
    const user = await Auth.signIn(username, password);
    this.currentUser = user;
    return user;
  }

This was all working great under Transformer v1.

@malcomm I'm going to transfer this to amplify-js repo so you can chat with that team. Unfortunately, I don't have much knowledge on the library.


Unable to re-enable built-in extension

VSCode Version: 1.47.2 (user setup)
OS Version: Windows_NT x64 10.0.19041

Steps to Reproduce:

Disable the TypeScript and JavaScript Language Features extension from the Extensions @builtin
Try to enable it

@disabled

@builtin

Does this issue occur when all extensions are disabled?: Yes

This issue occurs only with the project/folder that I have disabled for it. Rest isn't affected.

I've found a temporary solution. I have created a symbolic link to the project folder to continue to work on the project and have the extension enabled.
But this doesn't change the original status of the main issue

There is one possibility to reset workspace related configurations/states which helped me to reset extensions current state.
I have found this folder %userprofile%\AppData\Roaming\Code\User\workspaceStorage
As I understand, this folder contains workspace related databases.
All folders under workspaceStorage have generated names.
I have looked at every workspace.json files inside every folder to identify the folder that I want to reset.
Once I found, I just simply deleted the folder named as 2882fa7d49d6d9d80b49cb04f5900284.
After that, I have reopened my projects folder and there was no problem that I can report so far.
Of course, this approach allows you to have reset, not fix.

/duplicate
#102645


fixes for builds with no raja or umpire

I tried building serac without RAJA or Umpire and found some code that needs some #ifdef macros around it.  This PR adds them.

Should we test this in CI? Maybe in Azure?

Should we test this in CI? Maybe in Azure?

We probably don't want to get into all of the combinatorics, but I see the value in adding a CI test with minimal TPLs, just to check stuff like this.


Fix localhost issue

Work around lack of proper nsswitch.conf on existing tiller images. versions 2.8.1 - 2.10.0 are known bad.
See https://github.com/helm/helm/issues/4511 for some details

/ok-to-test

/lgtm

/assign @krancour

/approve


In multiple overlapping folders, ctrl+p shows duplicates for root files

Testing #29176

open vscode
add root folder vscode\src
search for a file which is not in the recently used section, but which is inside vscode\src (at the top)
e.g. cli.js
note: if the file is in the recent list it is not duplicated

I think I missed this because as you point out, they get deduped if they show up in the recently used section. This is actually going to be a pain to fix using find unless I dedupe results after find runs.


well

im sure you have long forgotten about this project, but in all honestly this would be the best loading screen around if you could make it work. the only thing wrong is that it doesnt pull the steam information.

I cant get my loading screen works


Created check_site_changes.sh script

Created this script to check for any unmerged code that would affect the website output. If there are relevant changes, Vercel will be asked to build.

Closing #198 with a new script.

Has this been tested?

Has this been tested?

It works as intended in this PR. ￼
Since the only change in this PR is a non-website change, Vercel skips building this PR. I tested the script locally to see if it exits correctly when there are changes though and both cases work correctly.


change the candlestick data on click react js

i am using react hook useffect to render my candlestick but when i want to change the data on click its does not change . when click i save my api data in use context hook and then use in my candlestick component .i dont how to change on click and didnt find any reference kindly help.
`
let CandleData = state.CandleData
useEffect(() => {
chart.current = createChart(chartContainerRef.current, {
width: chartContainerRef.current.clientWidth,
height: chartContainerRef.current.clientHeight,
layout: {
backgroundColor: '#1c1f2d',
textColor: 'rgba(255, 255, 255, 0.9)',
},
grid: {
vertLines: {
color: '#334158',
},
horzLines: {
color: '#334158',
},
},
crosshair: {
mode: CrosshairMode.Normal,
},
priceScale: {
borderColor: '#485c7b',
},
timeScale: {
borderColor: '#485c7b',
rightOffset: 2,
},
});
// chart.current.timeScale().getVisibleRange()
const candleSeries = chart.current.addCandlestickSeries({
  upColor: '#4bffb5',
  downColor: '#ff4976',
  borderDownColor: '#ff4976',
  borderUpColor: '#4bffb5',
  wickDownColor: '#838ca1',
  wickUpColor: '#838ca1',
});

candleSeries.setData(CandleData);

}, []);`

i need some help in this if anyone can help

Hi @zeeshan-shabbir,
As you can see here, we are preparing a tutorial with React.
Don't really know how you use/reuse your chart but from what I can see you may not need a useRef for this one.
You could do something like
export const ChartComponent = props => {
	const chartContainerRef = useRef();

	useEffect(
		() => {
			const handleResize = () => {
				chart.applyOptions({ width: chartContainerRef.current.clientWidth });
			};

			const { data } = props;

			const chart = createChart(chartContainerRef.current, {
				width: chartContainerRef.current.clientWidth,
				height: 300,
				layout: {
					backgroundColor: '#1c1f2d',
					textColor: 'rgba(255, 255, 255, 0.9)',
				},
				grid: {
					vertLines: {
						color: '#334158',
					},
					horzLines: {
						color: '#334158',
					},
				},
				priceScale: {
					borderColor: '#485c7b',
				},
				timeScale: {
					borderColor: '#485c7b',
					rightOffset: 2,
				},
			});
			chart.timeScale().fitContent();

			const newSeries = chart.addCandlestickSeries({
				upColor: '#4bffb5',
				downColor: '#ff4976',
				borderDownColor: '#ff4976',
				borderUpColor: '#4bffb5',
				wickDownColor: '#838ca1',
				wickUpColor: '#838ca1',
			});
			newSeries.setData(data);

			window.addEventListener('resize', handleResize);
			return () => {
				window.removeEventListener('resize', handleResize);

				chart.remove();
			};
		},
		[props.data]
	);

	return (
		<div
			ref={chartContainerRef}
		/>
	);
};

Using the above component with some random OHLC data it produces something like

Using the above component with some random OHLC data it produces something like

thank you much exactly what i want i was searching this from 2 days thanks but there is few things i want to known how can i update my data real time in this component which come api ?
and second i want to get x,y values on click from another component .
it will be pleasure .


[Event Request] - SalesPost.Codeunit.al - OnBeforeIsEndLoopForShippedNotInvoiced

We like to request the following Event:
Object: SalesPost.Codeunit.al
Note: The procedure IsEndLoopForShippedNotInvoiced is used inside PostItemTrackingForShipment() to determine if the repeat until loop should end. It would be nice to have the same logic applied to the equivalent PostItemTrackingForReceipt(). This is also not the case for the same procedures in PurchPost.Codeunit.al
Where is the event placed:
local procedure IsEndLoopForShippedNotInvoiced(RemQtyToBeInvoiced: Decimal; TrackingSpecificationExists: Boolean; var HasATOShippedNotInvoiced: Boolean; var SalesShptLine: Record "Sales Shipment Line"; var InvoicingTrackingSpecification: Record "Tracking Specification"; var ItemLedgEntryNotInvoiced: Record "Item Ledger Entry"; SalesLine: Record "Sales Line") EndLoop: Boolean
var
    IsHandled: Boolean;
begin
    OnBeforeIsEndLoopForShippedNotInvoiced(RemQtyToBeInvoiced, TrackingSpecificationExists, HasATOShippedNotInvoiced, SalesShptLine, InvoicingTrackingSpecification, ItemLedgEntryNotInvoiced, SalesLine, EndLoop, IsHandled);
    if IsHandled then
        exit;

    if TrackingSpecificationExists then
        exit((InvoicingTrackingSpecification.Next() = 0) or (RemQtyToBeInvoiced = 0));

    if HasATOShippedNotInvoiced then begin
        HasATOShippedNotInvoiced := ItemLedgEntryNotInvoiced.Next <> 0;
        if not HasATOShippedNotInvoiced then
            exit(not SalesShptLine.FindSet or (Abs(RemQtyToBeInvoiced) <= Abs(SalesLine."Qty. to Ship")));
        exit(Abs(RemQtyToBeInvoiced) <= Abs(SalesLine."Qty. to Ship"));
    end;

    exit((SalesShptLine.Next() = 0) or (Abs(RemQtyToBeInvoiced) <= Abs(SalesLine."Qty. to Ship")));
end;

Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeIsEndLoopForShippedNotInvoiced(RemQtyToBeInvoiced: Decimal; TrackingSpecificationExists: Boolean; var HasATOShippedNotInvoiced: Boolean; var SalesShptLine: Record "Sales Shipment Line"; var InvoicingTrackingSpecification: Record "Tracking Specification"; var ItemLedgEntryNotInvoiced: Record "Item Ledger Entry"; SalesLine: Record "Sales Line"; var EndLoop: Boolean; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


🫐 🐛 Replacing a lost node requires manual intervention

What happened?
I was testing losing a node in Azure by following these steps:

Terminate 1 node out of 3 running nodes
Launch a new node

All the pods but Redpanda were rescheduled correctly on the new node.
What did you expect to happen?
I was expecting the Redpanda pod to be successfully rescheduled.
How can we reproduce it (as minimally and precisely as possible)?. Please include values file.

Deploy a 3-node cluster
Terminate 1 node
Launch a new node

Anything else we need to know?
It seems the PVC was left still bound to the lost node.
Which are the affected charts?
Redpanda, Operator
Chart Version(s)
5.8.5
Cloud provider

Azure

JIRA Link: K8S-228

Duplicated of https://github.com/redpanda-data/redpanda-operator/issues/133


Add Cairo steps calculation in tests using res.call_info.execution_resources

We want to be able to compute no. of Cairo steps used in a specific computation

The aim here is to be able to have some kind of metric of efficiency. How many cairo steps did an opcode take?
This way, we'll be able to compute Kakarot performance

Closing, as it is a duplicate of #230


Update obtaining-a-google-maps-api-key.md

The metadata android:name was obsolete and I've changed it to the one used in the WorkingWithMap demo solution.
Starting from June,11 2018 the map api key won't work if the project is not connected to a billable account, even if the service is still free for mobile apps.
I've applied those two fixes on my Xamarin app and found that those two things solve my issue of gray map.
More over, I've recreated the images that now reflect the new Google restyle of the developer web site and added the steps related to connecting the project to a billable account.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ncarandini sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks! 😺


Add code to generate and clean up monsters

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #51

PR #52   👈

This stack of pull requests is managed by Graphite.

Merge activity

Dec 27, 10:16 PM: @kadhirvelm started a stack merge that includes this pull request via Graphite.


Shape mismatches in MMLU

I've setup accelerate and running multi-gpus with
accelerate launch run_evals_accelerate.py --tasks="leaderboard|mmlu:abstract_algebra|0|0" --output_dir "/weka/home-marcob/lighteval/scores" --model_args "pretrained=gpt2"
I get:

Cannot apply desired operation due to shape mismatches. All shapes across devices must be valid.
[rank3]: Operation: accelerate.utils.operations.gather`
[rank3]: Input shapes:
[rank3]:   - Process 0: [1024]
[rank3]:   - Process 1: [2048]
[rank3]:   - Process 2: [2048]
[rank3]:   - Process 3: [2048]
[rank3]:   - Process 4: [2048]
[rank3]:   - Process 5: [2048]
[rank3]:   - Process 6: [2048]
[rank3]:   - Process 7: [2048]

Note that with the same identical setup I can run if I use 5-shots, i.e. the following doesn't throw an error
accelerate launch run_evals_accelerate.py --tasks="leaderboard|mmlu:abstract_algebra|5|0" --output_dir "/weka/home-marcob/lighteval/scores" --model_args "pretrained=gpt2"
The same error happens systematically when running the custom MMLU eval from finewebedu (https://huggingface.co/datasets/HuggingFaceFW/fineweb/blob/main/lighteval_tasks.py#L12).
Also note that without configuring accelerate to explicitly verify tensor shapes no error is thrown and the process just hangs indefinitely

Thanks for reporting!
We normally have a pad and gather to prevent this (which pads too short splits before gathering if needed). We'll investigate what happens here, as it should apply.

Hi! I can't reproduce, can you try to reinstall from main and tell me if you're still getting an error?
It would also be nice to provide your detailed accelerate config

Closing for inactivity


Feedback/beta release for StepOverrides and SidecarOverrides

This issue tracks bringing step and sidecar overrides to beta, and any feedback on or issues with this feature.
We'll be renaming these fields to stepSpecs and sidecarSpecs in v1 and can optionally do so as well if/when we enable this feature in v1beta1 without enable-api-fields set to alpha.

If we can change the names here can we just use steps and sidecars. The Specs or Overrides word does not add anything and really is not making things less confusing about what you can and can't do.

@skaegi This feature was actually renamed to stepSpecs and sidecarSpecs in the v1 API (https://github.com/tektoncd/community/blob/main/teps/0096-pipelines-v1.md#api-changes) for consistency with taskRunSpecs in PipelineRun

I fully understand... wish that was just taskRuns too but admit the ship has sailed there. With that said I definitely think that Specs is better than Overrides and indeed more consistent.

@lbernick Think this is still an issue, can you remove lifecycle/rotten please?

/lifecycle frozen

/assign @khrm

Let's add this to the milestone for v0.61.0 @chitrangpatel @vdemeester
I wrongly pinged you guys in some other issue.

@khrm can we move this to the next milestone?

Removing a milestone from this issue. I think we can assign it as soon as it is picked up again.

@chitrangpatel This was already merged. So we can close this. https://github.com/tektoncd/pipeline/pull/8006/
/close

/close


[glslang] Include/Types.h is missing in 14.0.0

Is your feature request related to a problem? Please describe.
Types.h that defines TType is missing after the upgrade to glslang 14.0.0. ShaderLang.h has a forward declaration for it but the definition in the header file is missing. Existing code that used getAttributeTType can no longer be compiled.
Proposed solution
Add Types.h back into the Include folder.
Describe alternatives you've considered
No response
Additional context
No response

Traced this back to an upstream decision documented in https://github.com/KhronosGroup/glslang/issues/3320.
Apparently TType was never intended to be public. I'll need to find an alternative for getAttributeTType.
https://github.com/KhronosGroup/glslang/issues/3491#issuecomment-2099331192


Updates disabled state when changed after initialisation.

This pull request includes a

[x] Bug fix

The following changes were made

adds a check within setClasses to set "aria-disabled" attribute based on state of option.disabled.

Fixes #3347

Thanks!  is this something we can add a test for as well?

Alex - not ignoring this; just been busy!
Yes, I'll sort out a unit test for this asap.

Awesome, thanks!

Is this a duplicate/enhancement of #4818?

#4537 also claims to address this problem.

Actually, this PR might be what @kevin-brown is looking for, as per #4575.  Seems like a strong signal that we should merge this.

Hi, how can I apply this patch in 4.0.6.rc-1 or get minified version of this branch?

I just want to point out the importance of this behavior. Without a fix, Select2 is no longer analogous to a normal a select element. We can work around it, but it's been kind of painful.


Add PeakHour.app v3.1.1

Thank you for the contribution. It needed some fixes, so they were made in ca1d434f7bbda55713d2c21be33c99574eaefce8. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


Fix namespaces 2

All right, what do you think about this?

Looks much better, thank you for this work. I am afraid, though, that I can only review it in detail. I did notice something that arouse my interest: why do you need to change tunit.Name in your pass? We do have Declaration.OriginalName in case of need but I'm just wondering.
@tritao your opinion on this pull would be most useful.

@golddranks please also remove using System.Runtime.Serialization.Formatters.Binary; and other using directives you don't need any more.

OK, I can see now why you rename the translation unit. There's something interesting in the idea, I also like that it allows to to remove code in GetNestedQualifiedName rather than add more. Joao, what do you think?
Now that you do this anyway, please use full names to all needed cases. Now you only use it for base types which would cause incompilable code when a dependent type is used as a parameter or a return type, etc. In short, now that you've gone for qualified names instead of usings, any usage of a dependent type must be fully qualified.


Textarea resize

There should be a way to disable resizing, or at the least, if the rows is equal to the maxheight it should be disabled by default since resizing isn’t allowed anyway.

Here's one way:
viewof box = {
  var box = Textarea()
  box.querySelector('textarea').style = 'resize: none;'
  return box
}

Here's one way:
viewof box = {
  var box = Textarea();
  box.querySelector('textarea').style = 'resize: none;'
  return box;
}

As a reader though I'd prefer if authors just left the browser text boxes alone, and didn't try to disable resize.

Also, there should be a way to have auto resize, so that the textarea expands to fit its content.


add docs for kinesis lag metrics

Adds missing docs for kinesis lag metrics

thanks for the review @ccaominh :metal:


scipy.misc.imsave was removed

Should be changed to imageio.imwrite

https://github.com/facebookresearch/pytorch_GAN_zoo/pull/73


What happened to the styles ?

V2 had a really nice style associated with the toast. I could easily display warnings, errors, and success messages to my user. With V3 the API is completely different and there are no clear instructions on how I can replicate this functionality.

In order to bring the toast notifications in line with the native functionality, it now uses the native toasts function. However this brings very limited styling options. If you need the styling, I would stick with v2.0.4 for now.


[SCB-582]Provide a way to protect instance removal

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.02%) to 87.365% when pulling 6cf01cf7ac0d9a0da5749c2375d5a45309022bbd on liubao68:instance_protection into 2f8de349d4b0b82d3dc14fcb9c94d3ae7046f9b5 on apache:master.

Change the behavior to only protect empty instances and make this behavior on default.


STEAM Guide

[ ] Complete STEAM Guide

I am going to start working on the STEAM Guide

I am starting with the description of Read me.md file of STEAM Guide.


Orchestrator-agent. Redesign and support for new seed methods

Hi @shlomi-noach,
We spoke some time ago about adding support for different seed methods for orchestrator and orchestrator-agent, and here it is.
This PR adds following:

Redesign base struct and methods for agent
New logging
New command execution with pipes support
New API commands
New configuration file parameters and format
5 supported seed methods: mysqldump, mydumper, xtrabackup, lvm and clone plugin
Packaging using goreleaser
Integration tests for all new seed methods (see /tests/integration/README.MD)

We define seed as an operation, which consists of a set of predefined stages, where 2 orchestrator agents participate - one agent is called source agent(so it is on a source side of seed), another - target agent (so it is on a target side of seed), and the goal of seed is to transfer all data from source agent to target agent and add target agent as a slave to source agent.
Seed can be executed using different seed methods - special ways or programs used to transfer data from source agent to target agent
In order to simplify developing new seed methods for orchestrator-agent, each of seed methods should support following interface:
type Plugin interface {
	Prepare(side Side)
	Backup(seedHost string, mysqlPort int)
	Restore()
	GetMetadata() (*SeedMetadata, error)
	Cleanup(side Side)
	isAvailable() bool
	getSupportedEngines() []mysql.Engine
	backupToDatadir() bool
}

By design, each seed operation consists of 5 stages, which are executed one after another by orchestrator (and each stage is a function, which seed method should support and had a corresponding orchestrator-agent API method which is used by 'orchestrator' to start it) :

Prepare. On this stage different preparations for seed are done on both sides, target and source. These preparations could be creating or cleanup of different directories, starting socat for data transfer
Backup. On this stage backup is executed - transfer of data from source to target. The side of the execution (target or source) depends on the seed method (some of them, like mydumper\mysqldump\clone plugin, are executed on target side, while xtrabackup\lvm are executed on source side). Each of the registered seed methods should provide information about the side, on which backup process is executed
Restore. On this stage restore is executed. This stage is always executed on target side. Operations on this stage depend on seed method - for mysqldump it's just uploading of .sql backup file to database, for xtrabackup - it's more complex process of uncompressing\preparing data in backup.
ConnectSlave. This stage will be executed completely by orchestrator. During this stage target agent is connected as a slave for source agent. But in order to implement this, orchestrator should know position\gtids from backup. So it asks target agent to provide backup metadata by calling GetMetadata method.
Cleanup. This stage is executed on both sides, target and source. Different cleanup activities will be executed on this stage - cleaning backup directories, unmounting snapshots

Other functions in this Interface are helper methods:

isAvailable() - is a function, which tests if seed method is available on a current host (for example, for xtrabackup it calls xtrabackup --version command to check availability of xtrabackup binary)
getSupportedEngines() - returns an array of supported engines for seed method. We need this because different seed methods supports different engines, and we can't, for example, use xtrabackup on MySQL 5.7 if there are tables with Myrocks engine, as they are not supported
backupToDatadir() - is a helper function, which returns true in case of this seed method is capable of backing up data directly to mysql data directory (like xtrabackup`cloneplugin`, 'lvm' - the do not create intermediate backup files with data)

Stages are exposed through orchestrator-agent API and orchestrator calls them in order.
As each stage can take quite a big amount of time to execute, they are executed asynchronously in goroutines. In order to be able to track progress of each stage, 'seed method' sends to 'orchestrator-agent' information about seed stage progress via channel and  this information is also exposed through API, so orchestrator can call this API to be able to track stage progress.
That is the basic overview of the process from the orchestrator-agent side. All the philosophy is still the same as was - it's just exposes API calls to process seed and all logic is handled on the orchestrator side.
If you want to test it - there are integration tests available for all seed methods for different versions of mysql (5.7 and 8) and different binlog settings (gtid and positional). They are located in /tests/integration/ folders and in README.MD there is information about how to run them.
We started testing new agent and orchestrator functionality on our staging environments and I think we will find different issues related to this PR, so I think this functionality should be mostly classified as beta right now.
But I will be very grateful for your feedback and comments :)
Thanks,
Max

@MaxFedotov
Hi,
Thanks for your works !
I'm interested to test it, do you have any builds somewhere for both agent && orchestrator ?


scale is not working before cursor enters a block

  transform:
    translate(calc(-50% + var(--cursor-translateX)), calc(-50% + var(--cursor-translateY)))
    scale(var(--cursor-scale));

--cursor-translateX and --cursor-translateX are first set in onBlockMove(), which will only be triggered when mouse is moving on a block. Therefore, these two CSS variables are undefined before the cursor enters a block, resulting in the transform property being none. Consequently, scale will not work.

Thanks, it's fixed and will be released later. Feel free to report issue if still have problems.


InfluxDB gives incorrect results when using epoch times.

Bug report
System info: [Include InfluxDB version, operating system name, and other relevant details]
influxdb-1.1.0~n201610280800-0.x86_64
CentOS/7
Steps to reproduce:

select count("connection_time") from postgresql_activity where host='iad1gdbs01' and time > '2016-10-28 00:08:21' and time < '2016-10-28 00:14:08' group by time(1m)
select count("connection_time") from postgresql_activity where host='iad1gdbs01' and time ><PHONE_NUMBER>s AND time <<PHONE_NUMBER>s group by time(1m)

Expected behavior: [What you expected to happen]
Receive the same results for both queries.
Actual behavior: [What actually happened]
Received different results for both queries.
Additional info: [Include gist of relevant config, logs, etc.]
This is a regression as the issue is not present in InfluxDB 1.0.2
1477699701 == 2016-10-28 00:08:21
1477700048 == 2016-10-28 00:14:08
> select count("connection_time") from postgresql_activity where host='iad1gdbs01' and time > '2016-10-28 00:08:21' and time < '2016-10-28 00:14:08' group by time(1m)
name: postgresql_activity
time            count
----            -----
2016-10-28T00:08:00Z    163
2016-10-28T00:09:00Z    161
2016-10-28T00:10:00Z    160
2016-10-28T00:11:00Z    160
2016-10-28T00:12:00Z    157
2016-10-28T00:13:00Z    160
2016-10-28T00:14:00Z    0

> select count("connection_time") from postgresql_activity where host='iad1gdbs01' and time ><PHONE_NUMBER>s AND time <<PHONE_NUMBER>s group by time(1m)
name: postgresql_activity
time            count
----            -----
2016-10-29T00:08:00Z    166
2016-10-29T00:09:00Z    166
2016-10-29T00:10:00Z    162
2016-10-29T00:11:00Z    0
2016-10-29T00:12:00Z    325
2016-10-29T00:13:00Z    162
2016-10-29T00:14:00Z    0

1477699860 == 2016-10-28 00:11:00
1477699920 == 2016-10-28 00:12:00
> select active from postgresql_activity where host='iad1gdbs01' and time ><PHONE_NUMBER>s and time <<PHONE_NUMBER>s
(no results)

> select active from postgresql_activity where host='iad1gdbs01' and time > '2016-10-28 00:11:00' and time < '2016-10-28 00:12:00'
name: postgresql_activity
time                active
----                ------
2016-10-28T00:11:51.694Z    false
2016-10-28T00:11:51.695Z    false
2016-10-28T00:11:51.705Z    false
2016-10-28T00:11:51.705Z    false
2016-10-28T00:11:51.72Z     false
2016-10-28T00:11:51.722Z    false
2016-10-28T00:11:51.722Z    false
2016-10-28T00:11:51.723Z    false
2016-10-28T00:11:51.723Z    false
2016-10-28T00:11:51.723Z    false
2016-10-28T00:11:51.723Z    false
2016-10-28T00:11:51.723Z    false
2016-10-28T00:11:51.723Z    false
...
...
...

I'm not sure your unix times are correct. Quick code snippet: https://play.golang.org/p/9g5ZBTQwD0
This gives me<PHONE_NUMBER> for 2016-10-28T00:08:21Z, but it looks like you tried<PHONE_NUMBER>. Can you double check your numbers to make sure I didn't mess up anything?

Nope, you're right. I apparently made a typo during my initial conversion to epoch time, and then kept on using the bad value for all further calculations. Using the proper unix epoch time, I get the same value for both.
I am experiencing an issue with the nightly, but apparently misdiagnosed it. I'll reinvestigate and create a new issue once I identify the pattern.

Ok, thanks!


Getting date picker to recognize YYYYMMDD format?

We have legacy birth date data in the format of YYYYMMDD (20151022). Angular and the ui-bootstrap date picker obviously don't like this format. Also, our new UI requirements are to display the format as MMM, d YYYY (Oct, 22 2015). I'm not seeing a way to enforce a non-standard date format (for data, not for display) in the documentation. Is this not supported or am I just overlooking it?

@uberspeck, please do not use the issues forum for support related requests.  Rather, please follow the instructions here.  The issues forum is reserved for bugs.


Bugfix: dropForeignKey SQLite adapter

Removing a foreign key with SQLite adapter caused the table to be removed. Also the create syntax left out the original column.

Thank you!