RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

I've been trying to run the repo on a locally installed copy of Jupyter Labs using Ubuntu 22. I've managed to solve nearly all the issues but hit this one and I can't solve it. Anyone else encountered this with a fix whilst running ubuntu on a windows PC?
Traceback (most recent call last):
File "/home/cyndre/Dreambooth-Stable-Diffusion/main.py", line 875, in
trainer.fit(model, data)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 770, in fit
self._call_and_handle_interrupt(
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 723, in _call_and_handle_interrupt
return trainer_fn(*args, **kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 811, in _fit_impl
results = self._run(model, ckpt_path=self.ckpt_path)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1236, in _run
results = self._run_stage()
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1323, in _run_stage
return self._run_train()
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1345, in _run_train
self._run_sanity_check()
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1413, in _run_sanity_check
val_loop.run()
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/loops/dataloader/evaluation_loop.py", line 155, in advance
dl_outputs = self.epoch_loop.run(self._data_fetcher, dl_max_batches, kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/loops/base.py", line 204, in run
self.advance(*args, **kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 128, in advance
output = self._evaluation_step(**kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/loops/epoch/evaluation_epoch_loop.py", line 226, in _evaluation_step
output = self.trainer._call_strategy_hook("validation_step", *kwargs.values())
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/trainer.py", line 1765, in _call_strategy_hook
output = fn(*args, **kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/pytorch_lightning/strategies/strategy.py", line 344, in validation_step
return self.model.validation_step(*args, **kwargs)
File "/home/cyndre/.local/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
return func(*args, **kwargs)
File "/home/cyndre/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 368, in validation_step
_, loss_dict_no_ema = self.shared_step(batch)
File "/home/cyndre/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 908, in shared_step
loss = self(x, c)
File "/home/cyndre/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1190, in _call_impl
return forward_call(*input, **kwargs)
File "/home/cyndre/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 945, in forward
return self.p_losses(x, c, t, *args, **kwargs)
File "/home/cyndre/Dreambooth-Stable-Diffusion/ldm/models/diffusion/ddpm.py", line 1096, in p_losses
logvar_t = self.logvar[t].to(self.device)
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

After some trial and error from another linked issue I managed to nix this error but immediately got a new one;
RuntimeError: No CUDA GPUs are available
I'm using an RTX 3090 Strix

If using vast.ai, use an older version of CUDA to use -- the "latest" build breaks this script.  The 1.12.1 version seems to work fine

@chakalakasp do you have steps to fix this so we can update the script?

Hi - unfortunately no, I didn’t dig into the script to figure out the issue, which I suspect is some sort of incompatibility with a recent update to the CUDA environment used with PyTorch by vast.ai (and probably others, if they stay updated). I simply used the previous version of PyTorch. This was something I selected at vast.ai before I even launched the machine.
On Sun, Oct 30, 2022 at 10:11, David B. @.***> wrote:

@.***(https://github.com/chakalakasp) do you have steps to fix this so we can update the script?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Select 1.12.1 as your version of PyTorch in the configs, should fix this.

@chakalakasp Thanks. I'm using pip, and downgrading to torch 1.12 fixes the problem:
pip install torch==1.12.1+cu113 torchvision==0.13.1+cu113 torchaudio==0.12.1 --extra-index-url https://download.pytorch.org/whl/cu113

a simpler solution that allows you to keep the latest version of torch is to patch ddpm.py on L1096 with logvar_t = self.logvar[t.cpu()].to(self.device), i.e. add .cpu() to the step counter

a simpler solution that allows you to keep the latest version of torch is to patch ddpm.py on L1096 with logvar_t = self.logvar[t.cpu()].to(self.device), i.e. add .cpu() to the step counter

Maybe create a PR for this, if it works with all versions? @vshulman

a simpler solution that allows you to keep the latest version of torch is to patch ddpm.py on L1096 with logvar_t = self.logvar[t.cpu()].to(self.device), i.e. add .cpu() to the step counter

Maybe create a PR for this, if it works with all versions? @vshulman

totally fair. I've not had a chance to test it with other versions of torch, but should I get around to it, I'll PR.

a simpler solution that allows you to keep the latest version of torch is to patch ddpm.py on L1096 with logvar_t = self.logvar[t.cpu()].to(self.device), i.e. add .cpu() to the step counter

Maybe create a PR for this, if it works with all versions? @vshulman

totally fair. I've not had a chance to test it with other versions of torch, but should I get around to it, I'll PR.


Reinstate the Master branch

Bug Report
$ wp package install wp-cli/i18n-command
[...]
Dependency resolution completed in 0.002 seconds
Your requirements could not be resolved to an installable set of packages.
Problem 1
    - Root composer.json requires wp-cli/i18n-command dev-master, found wp-cli/i18n-command[dev-fix/adapt-branch-alias, dev-main, dev-gettext-5, v2.0.0, v2.0.1, v2.0.2, v2.0.3, v2.1.0, v2.1.1, v2.1.2, v2.2.0, v2.2.1, v2.2.2, v2.2.3, v2.2.4, v2.2.5, v2.2.6, v2.2.7, v2.2.8, v2.2.9, v2.2.10, v2.2.11, v2.2.12, v2.2.13, 2.x-dev (alias of dev-main)] but it does not match the constraint.
Running update with --no-dev does not mean require-dev is ignored, it just means the packages will not be installed. If dev requirements are blocking the update you have to resolve those problems.
---
Error: Package installation failed (Composer return code 2).

git clone -b master https://github.com/wp-cli/i18n-command
Cloning into 'i18n-command'...
fatal: Remote branch master not found in upstream origin

These renamings (#5598) (happening for totally futile pretexts) are causing actual trouble to developers (who are the primary audience of such a software)

Since this is a change that was done for all packages, I am moving this ticket accordingly. This is not an issue specific to the i18n-command.
I understand your concern and it's definitely not ideal right now because things are currently moving. Good news is this is fixed in WP-CLI nightly (wp cli updatee --nightly) and you could also use wp package install wp-cli/i18n-command:dev-main as a workaround as well.
cc @schlessera for thoughts


[BUG]: Admin Flow add admins as owner for apps which use certain connectors

Describe the bug
I was running this flow and based on the title it should add an owner to the certain app which are using a certain connector but when I run this app it sends me an email saying that it disabled the app. It should say that it added the group to the app. Also when it tries to add a security group into an app it throws an error message saying could not add a group.
Component (please tell us which flow or app you are experiencing issues with):

Solution - Compliance and Report Components
Version - 1.17
Flow - SETUP REQUIRED | Admin | Find and add admins as owners for apps that leverage certain connectors

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

The note in the email is a typo from copy-pasting that email step from another flow. Thanks for letting us know, we've updated for the next version of the CoE.
For the failure to add the group, can you please show what you have for the environment variable for Power Platform Admin Security Group?
Note that it needs to be the Object Id, not an email address, as shown here:

Error Message{  "error": {    "code": "SolutionAppCanEditShareNotAllowedWithGroups",    "message": "The solution aware canvas application could not be shared with a security group with edit or share permissions"  }}
Action 'Check_if_connection_references_are_not_null' failed
On Tuesday, 26 May, 2020, 02:55:56 pm GMT-4, Jenefer Monroe<EMAIL_ADDRESS>wrote:

The note in the email is a typo from copy-pasting that email step from another flow. Thanks for letting us know, we've updated for the next version of the CoE.
For the failure to add the group, can you please show what you have for the environment variable for Power Platform Admin Security Group?
Note that it needs to be the Object Id, not an email address, as shown here:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

We are able to reproduce this. It seems there is a product limitation on this feature for apps in solutions. We are seeing if there is a workaround.

Hello. Unfortunately there isnt a workaround for this. We have put a fix on the backlog for the product team.
Thanks for using CoE!


Can no longer connect

Version of the extension: v0.0.46
Version of VSCodium:
Version: 1.94.0
Release: 24281
Commit: e3ecc7b1f165b02bbce073afbe9ab016559e91cb
Date: 2024-10-07T16:22:10.210Z
Electron: 30.5.1
ElectronBuildId: undefined
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.1.0-26-amd64

Client and host are Debian 12 instances. All of a sudden I'm getting on a machine I could access yesterday:
[Info  - 06:13:40.150] Resolving ssh remote authority 'ssh-remote+hostname' (attemp #1)
[Trace  - 06:13:40.170] Identity keys:
/home/user/.ssh/id_rsa ssh-rsa SHA256:XXX=
[Trace  - 06:13:40.172] Identity keys:
/home/user/.ssh/id_rsa ssh-rsa SHA256:XXX=
[Info  - 06:13:40.293] Trying no-auth authentication
[Info  - 06:13:40.342] Trying publickey authentication: /home/user/.ssh/id_rsa ssh-rsa SHA256:XXX=
[Error  - 06:13:40.469] Error resolving authority
Error: All configured authentication methods failed
	at me (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:155776)
	at /home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:409410
	at authHandler (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:403927)
	at Se (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:158994)
	at USERAUTH_FAILURE (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:147797)
	at 51 (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:311810)
	at e.exports.M (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:178339)
	at H.decrypt (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:274675)
	at e.exports.F [as _parse] (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:177863)
	at e.exports.parse (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:182250)
	at Socket.<anonymous> (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:154516)
	at Socket.emit (node:events:519:28)
	at Socket.emit (node:domain:488:12)
	at addChunk (node:internal/streams/readable:559:12)
	at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
	at Readable.push (node:internal/streams/readable:390:5)
	at TCP.onStreamRead (node:internal/stream_base_commons:191:23)

The machine is behind a 2FA jump host and I do not even get the prompt for 2FA.
The 2FA host I also can no longer access but at least I'm getting the prompt:
[Info  - 06:17:42.598] Resolving ssh remote authority 'ssh-remote+jumphostname' (attemp #1)
[Trace  - 06:17:42.613] Identity keys:
/home/user/.ssh/id_rsa ssh-rsa SHA256:XXX=
[Info  - 06:17:42.734] Trying no-auth authentication
[Info  - 06:17:42.789] Trying publickey authentication: /home/user/.ssh/id_rsa ssh-rsa SHA256:XXX=
[Info  - 06:17:42.900] Trying keyboard-interactive authentication
[Trace  - 06:17:46.933] Server install command:

# Server installation script

TMP_DIR="${XDG_RUNTIME_DIR:-"/tmp"}"

DISTRO_VERSION="1.94.0"
DISTRO_COMMIT="e3ecc7b1f165b02bbce073afbe9ab016559e91cb"
DISTRO_QUALITY="stable"
DISTRO_VSCODIUM_RELEASE="24281"

SERVER_APP_NAME="codium-server"
SERVER_INITIAL_EXTENSIONS=""
SERVER_LISTEN_FLAG="--port=0"
SERVER_DATA_DIR="$HOME/.vscodium-server"
SERVER_DIR="$SERVER_DATA_DIR/bin/$DISTRO_COMMIT"
SERVER_SCRIPT="$SERVER_DIR/bin/$SERVER_APP_NAME"
SERVER_LOGFILE="$SERVER_DATA_DIR/.$DISTRO_COMMIT.log"
SERVER_PIDFILE="$SERVER_DATA_DIR/.$DISTRO_COMMIT.pid"
SERVER_TOKENFILE="$SERVER_DATA_DIR/.$DISTRO_COMMIT.token"
SERVER_ARCH=
SERVER_CONNECTION_TOKEN=
SERVER_DOWNLOAD_URL=

LISTENING_ON=
OS_RELEASE_ID=
ARCH=
PLATFORM=

# Mimic output from logs of remote-ssh extension
print_install_results_and_exit() {
    echo "01077d1051173abf5d9fdd2f: start"
    echo "exitCode==$1=="
    echo "listeningOn==$LISTENING_ON=="
    echo "connectionToken==$SERVER_CONNECTION_TOKEN=="
    echo "logFile==$SERVER_LOGFILE=="
    echo "osReleaseId==$OS_RELEASE_ID=="
    echo "arch==$ARCH=="
    echo "platform==$PLATFORM=="
    echo "tmpDir==$TMP_DIR=="
    echo "SSH_AUTH_SOCK==$SSH_AUTH_SOCK=="
    echo "01077d1051173abf5d9fdd2f: end"
    exit 0
}

# Check if platform is supported
KERNEL="$(uname -s)"
case $KERNEL in
    Darwin)
        PLATFORM="darwin"
        ;;
    Linux)
        PLATFORM="linux"
        ;;
    FreeBSD)
        PLATFORM="freebsd"
        ;;
    DragonFly)
        PLATFORM="dragonfly"
        ;;
    *)
        echo "Error platform not supported: $KERNEL"
        print_install_results_and_exit 1
        ;;
esac

# Check machine architecture
ARCH="$(uname -m)"
case $ARCH in
    x86_64 | amd64)
        SERVER_ARCH="x64"
        ;;
    armv7l | armv8l)
        SERVER_ARCH="armhf"
        ;;
    arm64 | aarch64)
        SERVER_ARCH="arm64"
        ;;
    ppc64le)
        SERVER_ARCH="ppc64le"
        ;;
    riscv64)
        SERVER_ARCH="riscv64"
        ;;
    *)
        echo "Error architecture not supported: $ARCH"
        print_install_results_and_exit 1
        ;;
esac

# https://www.freedesktop.org/software/systemd/man/os-release.html
OS_RELEASE_ID="$(grep -i '^ID=' /etc/os-release 2>/dev/null | sed 's/^ID=//gi' | sed 's/"//g')"
if [[ -z $OS_RELEASE_ID ]]; then
    OS_RELEASE_ID="$(grep -i '^ID=' /usr/lib/os-release 2>/dev/null | sed 's/^ID=//gi' | sed 's/"//g')"
    if [[ -z $OS_RELEASE_ID ]]; then
        OS_RELEASE_ID="unknown"
    fi
fi

# Create installation folder
if [[ ! -d $SERVER_DIR ]]; then
    mkdir -p $SERVER_DIR
    if (( $? > 0 )); then
        echo "Error creating server install directory"
        print_install_results_and_exit 1
    fi
fi

SERVER_DOWNLOAD_URL="$(echo "https://github.com/VSCodium/vscodium/releases/download/\${version}.\${release}/vscodium-reh-\${os}-\${arch}-\${version}.\${release}.tar.gz" | sed "s/\${quality}/$DISTRO_QUALITY/g" | sed "s/\${version}/$DISTRO_VERSION/g" | sed "s/\${commit}/$DISTRO_COMMIT/g" | sed "s/\${os}/$PLATFORM/g" | sed "s/\${arch}/$SERVER_ARCH/g" | sed "s/\${release}/$DISTRO_VSCODIUM_RELEASE/g")"

# Check if server script is already installed
if [[ ! -f $SERVER_SCRIPT ]]; then
    if [[ "$PLATFORM" != "darwin" ]] && [[ "$PLATFORM" != "linux" ]]; then
        echo "Error "$PLATFORM" needs manual installation of remote extension host"
        print_install_results_and_exit 1
    fi

    pushd $SERVER_DIR > /dev/null

    if [[ ! -z $(which wget) ]]; then
        wget --tries=3 --timeout=10 --continue --no-verbose -O vscode-server.tar.gz $SERVER_DOWNLOAD_URL
    elif [[ ! -z $(which curl) ]]; then
        curl --retry 3 --connect-timeout 10 --location --show-error --silent --output vscode-server.tar.gz $SERVER_DOWNLOAD_URL
    else
        echo "Error no tool to download server binary"
        print_install_results_and_exit 1
    fi

    if (( $? > 0 )); then
        echo "Error downloading server from $SERVER_DOWNLOAD_URL"
        print_install_results_and_exit 1
    fi

    tar -xf vscode-server.tar.gz --strip-components 1
    if (( $? > 0 )); then
        echo "Error while extracting server contents"
        print_install_results_and_exit 1
    fi

    if [[ ! -f $SERVER_SCRIPT ]]; then
        echo "Error server contents are corrupted"
        print_install_results_and_exit 1
    fi

    rm -f vscode-server.tar.gz

    popd > /dev/null
else
    echo "Server script already installed in $SERVER_SCRIPT"
fi

# Try to find if server is already running
if [[ -f $SERVER_PIDFILE ]]; then
    SERVER_PID="$(cat $SERVER_PIDFILE)"
    SERVER_RUNNING_PROCESS="$(ps -o pid,args -p $SERVER_PID | grep $SERVER_SCRIPT)"
else
    SERVER_RUNNING_PROCESS="$(ps -o pid,args -A | grep $SERVER_SCRIPT | grep -v grep)"
fi

if [[ -z $SERVER_RUNNING_PROCESS ]]; then
    if [[ -f $SERVER_LOGFILE ]]; then
        rm $SERVER_LOGFILE
    fi
    if [[ -f $SERVER_TOKENFILE ]]; then
        rm $SERVER_TOKENFILE
    fi

    touch $SERVER_TOKENFILE
    chmod 600 $SERVER_TOKENFILE
    SERVER_CONNECTION_TOKEN="76b5f4b0-e541-4274-ab7b-541fd5fd9f04"
    echo $SERVER_CONNECTION_TOKEN > $SERVER_TOKENFILE

    $SERVER_SCRIPT --start-server --host=<IP_ADDRESS> $SERVER_LISTEN_FLAG $SERVER_INITIAL_EXTENSIONS --connection-token-file $SERVER_TOKENFILE --telemetry-level off --enable-remote-auto-shutdown --accept-server-license-terms &> $SERVER_LOGFILE &
    echo $! > $SERVER_PIDFILE
else
    echo "Server script is already running $SERVER_SCRIPT"
fi

if [[ -f $SERVER_TOKENFILE ]]; then
    SERVER_CONNECTION_TOKEN="$(cat $SERVER_TOKENFILE)"
else
    echo "Error server token file not found $SERVER_TOKENFILE"
    print_install_results_and_exit 1
fi

if [[ -f $SERVER_LOGFILE ]]; then
    for i in {1..5}; do
        LISTENING_ON="$(cat $SERVER_LOGFILE | grep -E 'Extension host agent listening on .+' | sed 's/Extension host agent listening on //')"
        if [[ -n $LISTENING_ON ]]; then
            break
        fi
        sleep 0.5
    done

    if [[ -z $LISTENING_ON ]]; then
        echo "Error server did not start sucessfully"
        print_install_results_and_exit 1
    fi
else
    echo "Error server log file not found $SERVER_LOGFILE"
    print_install_results_and_exit 1
fi

# Finish server setup
print_install_results_and_exit 0

[Trace  - 06:17:49.563] Server install command stdout:
Server script already installed in /local/home/user/.vscodium-server/bin/e3ecc7b1f165b02bbce073afbe9ab016559e91cb/bin/codium-server
Error server did not start sucessfully
01077d1051173abf5d9fdd2f: start
exitCode==1==
listeningOn====
connectionToken==76b5f4b0-e541-4274-ab7b-541fd5fd9f04==
logFile==/local/home/user/.vscodium-server/.e3ecc7b1f165b02bbce073afbe9ab016559e91cb.log==
osReleaseId==sles==
arch==x86_64==
platform==linux==
tmpDir==/run/user/4154591==
SSH_AUTH_SOCK==/tmp/ssh-XXXXf3fFXQ/agent.99088==
01077d1051173abf5d9fdd2f: end

[Error  - 06:17:49.564] Error resolving authority
Error: Couldn't install vscode server on remote server, install script returned non-zero exit status
	at t.installCodeServer (/home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:441139)
	at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
	at async /home/user/.vscode-oss/extensions/jeanp413.open-remote-ssh-0.0.46-universal/out/extension.js:1:404879

Using Visual Studio Code and the SSH extension works though.

I believe this is related to https://github.com/VSCodium/vscodium/issues/2049.
If you look at /local/home/user/.vscodium-server/.e3ecc7b1f165b02bbce073afbe9ab016559e91cb.log, and you see the following error message you can use the workaround described in the above issue.
$ tail -n 7 ~/.vscodium-server/.e3ecc7b1f165b02bbce073afbe9ab016559e91cb.log
SyntaxError: The requested module 'node:module' does not provide an export named 'register'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:123:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:189:5)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:530:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

I believe this is related to VSCodium/vscodium#2049.

Yes. This is fixed by VSCodium <IP_ADDRESS>82.

Yes. This is fixed by VSCodium <IP_ADDRESS>82.

Can only partially confirm. I can again connect to the jump host but not to any hosts behind that. The error remains the same.

@jeanp413 are you still monitoring this repo?

This is getting ridiculous. It's really sad seeing this once great project simply being abandoned without any notice.


[SPARK-36152][INFRA][TESTS] Add Scala 2.13 daily build and test GitHub Action job

What changes were proposed in this pull request?
This PR aims to add a new GitHub Action daily workflow for Scala 2.13 build and test.
Why are the changes needed?
Apache Spark 3.2.0 aims to support Scala 2.13 officially. We need a test coverage for master.
The following is the test result on my repository. The daily schedule triggered correctly for both master/3.2 branches.

https://github.com/dongjoon-hyun/spark/actions/runs/1036083268

Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a daily job.

Since this is a cron scheduled job, I'm testing in my repo. After checking the result, I'll update this PR.

Test build #141065 has started for PR 33358 at commit 6b00d27.

Test build #141065 has finished for PR 33358 at commit 6b00d27.

This patch fails executing the dev/run-tests script.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141065/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45578/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45578/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45578/

Test build #141120 has started for PR 33358 at commit c3e9b4d.

It's sad GitHub Actions doesn't have a feature to deduplicate workloads .. 😭

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45633/

Hi, @HyukjinKwon , @sarutak , @gengliangwang .
This PR is ready and tested in my repo. I updated the PR description.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45633/

The UT failure is irrelevant to this PR because this PR is only adding a new GitHub Action.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45633/

Test build #141120 has finished for PR 33358 at commit c3e9b4d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141120/

Thank you, @srowen , @sarutak , @gengliangwang , @HyukjinKwon .
Merged to master.

FYI, Scala 2.13 daily test GitHub Action job passed like the following. Now, Apache Spark community have a regular Scala 2.13 test coverage.
https://github.com/apache/spark/actions/runs/1043910113
Thank you all, @gengliangwang , @srowen , @HyukjinKwon , @sarutak , @maropu .

Yeah, thanks for setting it up.

Oh, sorry. I'm taking it back. It checked the updated module with the very previous commit. So, the job actually didn't run the Hive module actually. Let me check and fix it~ :(

No problem nothing blocks dev and PRs 👍


Interactive Animation Support

https://github.com/user-attachments/assets/567980d2-3088-4361-a027-3dae35d0f270
https://github.com/thorvg/thorvg/issues/2055

do we want to have a C api to set the id to the Tvg_Paint object?
in the svg loader we could set the node->id to the id (or it can be done in a separate pr)

For both questions, yes. probably. we can add them if it's necessary but I don't see any requirement yet.


gogs overwrite  my ssh configure  on my mac?

i just wanted to try gogs on my mac for fun, but after setting up the server, create a project, try to push it via cli, the git push freezes.
and after that, when i try to ssh myself, here is what i get:
> ssh localhost
PTY allocation request failed on channel 0
2014/04/25 11:51:34 [conf.go:340] [D] LDAP AUTHENTICATION NOT activated
Hi ya ! You've successfully authenticated, but Gogs does not provide shell access.
Connection to localhost closed.

looks like gogs overwrite my ssh config or something?

Hmmm, I am getting this same error
Hi evwill ! You've successfully authenticated, but Gogs does not provide shell access.```

Now I can't SSH into my VPS. Anyone know what I did wrong and how I can fix this?

@EvWill this is why Gogs sets default user to git. You may need to log in with password then kill Gogs instance.

Thanks :+1: Thought so

@EvWill no problem!


[Anime|Manga] REST Search with a space returns an error

For example, https://api.jikan.me/search/anime/code geass gives:
{"error":"Undefined offset: 1651"}
Character/Person search with a space appears to be functional.

Fixed, thanks for the report.


⚠ ClamAV has degraded performance

In c569a30, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 73de87e after 5 minutes.


useEffect is being called twice in StrictMode

This is expected behavior that got introduced in React 18. https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors

https://github.com/facebook/react/issues/24425#issuecomment-1106114722


Background color. I changed background color to black but text not able to see, how to make font color to white

Screenshot

[drag & drop image(s) here!]
Description
[describe the issue here!]
Background color. I changed background color to black but text not able to see, how to make font color to white and need to remove white lines.
Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label design:review. If this includes a design proposal,
include the label design:suggest]

we don't currently support this feature and i'm not sure if we can change the dashboard properties to achieve the goal? Echarts(our main charting library does offer dark mode but it doesn't cover table and pivot table. If anyone knows how, please let us know 🙏


Ansible updates

Just minimal etcd and kube. But use tags, rename minion->node. Tiny readme update.

@nzwulfin

Failed boilerplate checks.

hopefully that fixed the boilerplate.

@eparis Could you please suggest a reviewer?

@bgrant0607 I don't know. both @nzwulfin and @jeffbean are good with ansible. Not sure who to call the 'reviewer' though.  I'm 'out' this week, but might be able to find a Red Hat OpenShift person next week to look at well...

closing, this has been subsumed by other PRs


Minimizing app on iPad does undesirably resize display size via MediaQuery

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Open app on iPad (Simulator in my case) in landscape orientation
Send app to background via simulator home button
Optionally bring app back and change orientation and repeat the procedure

Expected results
I would not expect the app to change its size when going to background. On an Android Emulator (Pixel C with API 33) this behavior does not happen.
Actual results
The app changes its size twice. First it is reduced in its width and secondly it goes back to original size (while still minimized/in background). It is notable that the printed sizes are always the same. Also, the reduced size (in width) matches exactly the size when adding the app to the native iPad SplitView.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({super.key});

  @override
  Widget build(BuildContext context) {
    print(MediaQuery.sizeOf(context));
    return const Placeholder();
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
// initial, in landscape
flutter: Size(1366.0, 1024.0)
// minimize app to background
flutter: Size(678.0, 1024.0)
flutter: Size(1366.0, 1024.0)
// reopen app, nothing prints
// change orientation to portrait
flutter: Size(1024.0, 1366.0)
// minimize app to background
flutter: Size(639.0, 1366.0)
flutter: Size(1024.0, 1366.0)

Flutter Doctor output
Doctor output
[!] Flutter (Channel stable, 3.10.2, on macOS 13.4 22F66 darwin-arm64, locale de-DE)
    • Flutter version 3.10.2 on channel stable at /Users/me/fvm/versions/3.10.2
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/2.18.4/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/me/fvm/versions/3.10.2. Consider adding /Users/me/fvm/versions/3.10.2/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9cd3d0d9ff (3 weeks ago), 2023-05-23 20:57:28 -0700
    • Engine revision 90fa3ae28f
    • Dart version 3.0.2
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/me/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Users/me/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.9971841/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/me/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.9971841/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Users/me/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/222.4459.24.2221.10121639/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] IntelliJ IDEA Community Edition (version 2023.1.1)
    • IntelliJ at /Users/me/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/231.8770.65/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2023.1.2)
    • IntelliJ at /Users/me/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/231.9011.34/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • iPhone 14 Pro Max (mobile)                     • ED46C607-0500-4442-A6C9-D9A3109B8E97 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • iPad Pro (12.9-inch) (6th generation) (mobile) • C094B64E-17B5-4B92-AFC5-8535937FFE6B • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)                                • macos                                • darwin-arm64   • macOS 13.4 22F66 darwin-arm64
    • Chrome (web)                                   • chrome                               • web-javascript • Google Chrome 114.0.5735.106

[✓] Network resources
    • All expected network resources are available.

This is not a flutter bug. It's a behaviour of iOS to prepare the app for possible split view, capturing screenshots in different sizes. What is a bit of a bug here is the scroll behaviour, when this is done, the app is re-laid-out thinner, so your scroll position will be relatively further up the content. Then when we go back to wide, the scroll position is not restored to exactly the same spot.

This is not a flutter bug. It's a behaviour of iOS to prepare the app for possible split view, capturing screenshots in different sizes. What is a bit of a bug here is the scroll behaviour, when this is done, the app is re-laid-out thinner, so your scroll position will be relatively further up the content. Then when we go back to wide, the scroll position is not restored to exactly the same spot.

It doesn't really make sense for the app to change size while minimizing. Of course, the app size should adjust as soon as it is docked in a SplitView or it changes the displayed size. However, when an app goes into the background, it takes a millisecond and when it opens, the size may be unchanged.
What is the point behind such temporary resizing? I don't see any use case what a developer can do with it. It just makes the work more complicated and not consistent between platforms.

Flutter is not doing it. iPadOS is doing it. That's why it's different across platforms. The platforms are different. iPadOS wants to capture snapshots of the device in different sizes, so if you adjust the multitasking mode, it can preview what the app will look like correctly.

Flutter is not doing it. iPadOS is doing it. That's why it's different across platforms. The platforms are different. iPadOS wants to capture snapshots of the device in different sizes, so if you adjust the multitasking mode, it can preview what the app will look like correctly.

Thanks, that makes sense.


Missing foreign key constraints on borehole_files composite primary keys

As mentionend in #1044 there are a bunch of outdated records in the borehole_files and files table due to missing foreign key constraints.

[ ] Delete obsolete records in borehole_files and files. (manually on all environments).
⚠ This needs to be done first. Otherwise the db migration will fail.
[ ] Add missing foreign key constraints on borehole_files for all composite primary keys (db migration)

-- Entries in borehole_files with missing boreholes or files
SELECT * FROM bdms.borehole_files
WHERE
  id_fil_fk NOT IN (SELECT id_fil FROM bdms.files) OR
  id_bho_fk NOT IN (SELECT id_bho FROM bdms.borehole)

-- Obsolete files which can be deleted
SELECT * FROM bdms.files
WHERE id_fil NOT IN (SELECT id_fil_fk FROM bdms.borehole_files)

SQL statement to use to delete outdated borehole_files records.
DELETE FROM bdms.borehole_files
WHERE (id_fil_fk, id_bho_fk) IN (
	SELECT id_fil_fk, id_bho_fk FROM bdms.borehole_files
	WHERE
	  id_fil_fk NOT IN (SELECT id_fil FROM bdms.files) OR
	  id_bho_fk NOT IN (SELECT id_bho FROM bdms.borehole))


⚠ Bofrost.at has degraded performance

In 3ecb131, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1681 ms

Resolved: Bofrost.at performance has improved in 4e19ec7.


Failing validators/policies on-chain do not reflect on tests

create a new project via plutus-scaffold, remove ?rev=<hash> field from plutip to track master.
write a simple validator that always fails.
run its endpoint via assertExecution with shouldFail
the test does not follow expectations, instead, the contract succeeds

Is this the intended behaviour? i.e. does plutip only catch contract errors and no onchain errors?

write a simple validator that always fails.
run its endpoint via assertExecution with shouldFail

@hyphenrf maybe I'm missing something, but if validator always fails, then asserting execution with shouldFail should succeed, as failure is expected behavior signaled by shouldFail - contrary to shouldSucceed.  When shouldSucceed is used for contract with validator that always fails - it will fail the test.

wording is hard

@hyphenrf
main branch now has case with validator that always fails:
on- and off-chain code
test case
It fails as expected.
Does this case looks something like you were running with assertExecution and shouldFail?

oh I should've closed this, yeah it turned out the problem was in my understanding of when a validator executes, signaling failure.
Thanks for the test-case :heart:


Expose ServerInfo

Hello, I'm working on adding LSP support to CodeEdit. Can we get this ServerInfo struct exposed when initializing a server? It's great information to have for logging. Thanks!

Great idea, and thanks so much for making the PR! I totally forgot about the ServerInfo structure and had to look it up to even figure out what it was!
It got me thinking, I believe we can simplify a lot of this by just storing the InitializationResponse instead of destructuring it first and storing the fields. That's my bad design. I don't think fixing that internally is necessary, but I do think it's worthwhile fixing the publicly-facing API to reduce client churn.
I don't think it's essential to change all the internals now. But, how about just adjusting that one function signature, which should be a snap?

Oh, and I'm thrilled to see you starting on this work! Please do not be shy about questions! Also, there's been a lot of change to this repo in the last little while, and I anticipate more...

Agreed, made the change.

Oh, and I'm thrilled to see you starting on this work! Please do not be shy about questions! Also, there's been a lot of change to this repo in the last little while, and I anticipate more...

Sounds great!

This is a fantastic change, and you cleaned up all the internals too! Great stuff, thank you!


fix: fix 0.4.0 can't using custom pattern issue and also update default reg…

This PR include these changes, which is for 0.4.0(docker runtime):
[1] resolved can't using flag to custom regex pattern issue.
[2] update default regex pattern for match both docker runtime and containerd runtime.
[3] update unit test include docker runtime and containerd runtime.

Oh...0.4.0's branch already closed
Can you create new branch for 0.4.0? thanks.


Implement #99: Custom solution properties

Part1: User defined properties in Solution and send to SolGenEvent done
In progress: Excel serialize them

I have tested the implementation in a project, it seems to work. Next I will perform the tests and then merge it.

Hi! Did you write the tests @scaverod ? I can give you a hand if not, I am interested in merging the PR.

wip @rmartinsanta. Pushing asap.

I've just implemented the tests for testing the custom properties of a solution.


The way to pull metrics from nsq channel

Hi!
I am looking for ways to migrate from influxdb to prometheus.
Currently i have several custom collectors that push metrics to nsqd in influxdb line protocol and custom writer to influxdb.
Is there i way to teach prometeus got that metrics from nsq ?
At present moment i found only one - telegef nsq consumer, but that approach looks ugly.
Maybe there is a better way ?

There's a influxdb exporter that can take in the line procotol and produce Prometheus metrics.
https://github.com/prometheus/influxdb_exporter/


More control on positioning.

Currently we can display a tip view above another view (view A), with the tip view horizontally aligned with view A. Is it possible to specify offset? For example:
Center tip view, with 10px to the right;
Place the tip view on the right, with 20px to the left.
Thanks!

It is not possible to offset the position at the moment. Cheers!


Add introduction to fork on README

Following the discussion https://github.com/dsgibbons/shap/discussions/1#discussioncomment-5789209 , I've taken a stab an some introductory text on the README, to help draw attention to the purpose of the fork.
I thought at this stage, it probably makes sense to put this information somewhere prominent, as a new CONTRIBUTING.md might not be noticed by people casually browsing the repo. For a title, how about "SHAP Community Fork"?
I haven't written a CONTRIBUTING.md in this PR, so that could be useful to have to flesh out the details of the how the pool of maintainers is managed.

Thanks for the review comments! Feel free to change the title if you have something else in mind other than Shap Community Fork


fix(publish): Correctly get latest published version when there was only one release

npm view version not always returns the array, it might return a
single string if there was only one version published

Looks like "Detect jobs to run" script is stuck again. Could somebody with admin rights merge this PR?

We should fix that script...


Executable configuration parameter

On EL distributions (CentOS, RHEL, probably Oracle) /usr/local/bin/ is not in $PATH by default, so I added an executable configuration parameter (which is still set by default to /usr/local/bin/docker-compose).

Great idea. Also is there a better location docker-compose should be installed to for CentOS and RHEL?

I think /usr/local/bin is fine until docker-compose is released as a rpm package.

@fabiocorneti I dropped a couple comments, if you can make those changes I'll merge it in.

@leighmcculloch I've simplified the pull request by removing the validate method.

@fabiocorneti this is in v0.0.2 now. Thanks for submitting this PR!


Azure: defer endpoint creation until after VM creation.

@skschneider / @ehankland - could you take a look?

LGTM.
The lock is probably unnecessary.

Checked test errors, and they're caused by #723. Okay to merge.

test this please

test this please.

Looks like the AWS firewall depends on the VM's group id:
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/master/perfkitbenchmarker/providers/aws/aws_network.py#L67


Detection url/page redirection

Currently SenseMap doesn't know if a URL change is caused by user (such as clicking a link) or by the website (redirection), so it always creates a new node, which may not make sense for the temporary url in page redirection.

Adding a screenshot of the google search result redirection with 'complete' status before the redirection. Might have to create a check specifically for google search.


297 omp sentinels

Adds some support for OMP sentinels (#297), which are required for compiling lfric_atm.
The next release of fparser adds support for sentinels to fparser, so this change can then be removed again (#todo in place to remind us, so I would also leave #297 open), we only need to trigger this behaviour in fparser (which means it will not only work for declaration statements). We need this patch for now to continue LFRic compilation (but the source code in question is UM, so I added label UM, and not LFRic).

Ready for next review.

What's the timescale for the fParser fix and the need for directive support in Fab?

I've just submitted my last additional PR that I wanted for the next release, and there seems to be only one issue that might need to be handled before the next release. An fparser release is usually done very quickly, so I would hope (depending on priorities) to get this in maybe a month?
I originally intended not to push this PR to the official repo at all, but we had to integrate all these changes into our PRs (it became very messy to keep track and merging things), so it simplifies things a bit for us. E.g. #301 has this patch and it's not easy to remove it (conflicts).


Update urls following repo move

Summary
Following the recent move of this repo from Qiskit organization to qiskit-community this updates all the urls to the new location. The file theme-variables.jinja is quite out of date and being unused the conclusion was to remove this.
See qiskit-community/qiskit-optimization#529 for similar
Details and comments
Data provider links for more info were to the source notebook and instead of changing that to the new repo location I switched it to point to the published docs. Whether there is way to have this more relative urls, given that the tutorials are part of the overall docs that includes the API ref, which has the data provider info in them, I did not pursue.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.793%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
645

Relevant Lines:
851

💛  - Coveralls


Debug karma tests in WebStorm

Hi
Is anybody was successful to debug karma tests in WebStorm?
I successfully run karma tests in WebStorm but breakpoints do not work in usual way. I mean debug which is described in docs/general/faq.md

As the project has moved on beyond Karma/Mocha, and due to lack of interest. I'm closing this, but fee free to contribute if you have anything to offer.


Encode URL parameters

This is a change so that URL parameters are properly encoded. Previously a call such as:
CreateItem("John&Johnson")

Would produce a request with the following URL:
.../create-item?name=John&Johnson

(i.e, the ampersand isn't encoded and the server only receives the first part of the string, "John", as the parameter value).
Strangely there was already a couple of EncodeParam() methods but they weren't called anywhere, so I just made sure they were applied. I am a bit puzzled as to how this issue could have stayed undetected so I might be missing something.
There was code to format dates with .ToString("o") so I simply updated the overload of EncodeParam() that deals with dates to use the same format.
The changes in the .cs file are auto-generated, the real changes are in the .tt file.
I am hoping that this can be merged, and that the NuGet packages can be updated soonish. Let me know if I can do anything else to assist.

@xps - I see your pull request is rather old! Have you had challenges with thus repo accepting pull requests? The change in your PR, do you now just use your fork or did the same change somehow get made into the main repo by someone else?

@Korporal - I haven't heard from the maintainers after submitting my pull request, and there hasn't been any commits to the main branch since then either. At this point, I do use my own fork.

@xps - I did communicate with the owner a little and it seems that his level of involvement or enthusiasm is pretty much what it is. This is a shame because it discourages others from submitting changes and eventually makes the repo less attractive because there's no real effort being put into improving the code.
I posted this question too:
https://github.com/RestCode/WebApiProxy/issues/121
and haven't seen any reply so I'm now wondering whether I should embark on my own effort, one that I'd make an effort to maintain...

	Hi Hugh,

At this moment is is very challenging for only me to be actively involved all the time with this project as time is a big issue due to other responsibilities that requires my immediate attention at this stage.
I am very sorry that you feel that way about the project and really hope your mind will change in the future. From my side, I’ll do my best to dust of the cobwebs whenever it’s possible, but it still stays a community effort.
	Get Outlook for iOS
_____________________________

From: Hugh Gleaves<EMAIL_ADDRESS>Sent: Tuesday, June 13, 2017 8:49 pm
Subject: Re: [RestCode/WebApiProxy] Encode URL parameters (#117)
To: RestCode/WebApiProxy<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>@xps - I did communicate with the owner a little and it seems that his level of involvement or enthusiasm is pretty much what it is. This is a shame because it discourages others from submitting changes and eventually makes the repo less attractive because there's no real effort being put into improving the code.
I posted this question too:
#121
and haven't seen any reply so I'm now wondering whether I should embark on my own effort, one that I'd make an effort to maintain...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@faniereynders - Thanks for responding, but you wrote:
"but it still stays a community effort."
and people are submitting pull requests and issues that you don't have time to respond to. Yes it's a community effort but the community does have some reliance on the owner(s) to approve/deny pull requests!
I don't see how you can expect the "community" to do much when they must eventually wait for the owner(s) to respond to pull requests?
If you're too busy (which you clearly are) then I don't see how we can contribute much to your project, all people can do is submit pull requests and wait - or make their fork more active than your repo and so eventually take over the effort.

To get back to this PR, I'm going to merge it back to master. Many thanks @xps! @Korporal let's continue this discussion on the Gitter space https://gitter.im/RestCode


Corrected in typo in data/lookups/asa_parsing.csv

Typo at line 51 in the data/lookups/asa_parsing.csv file that breaks the csv format.

Thank you, olauret!


Gracefully handle when journ.cfg.json not found in directory

Maybe it should search for journ.cfg.json in local directory, then home directory, then display gracefully error message to user with fix example

kyle@KMBP:~/code/toolkit$ journ new
===== A New Day ====
fs.js:641
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open './journ.cfg.json'
    at Error (native)
    at Object.fs.openSync (fs.js:641:18)
    at Object.fs.readFileSync (fs.js:509:33)
    at Object.module.exports.recordLog (/usr/local/lib/node_modules/journ/lib/api.js:163:29)
    at Object.newDay (/usr/local/lib/node_modules/journ/journ.js:39:8)
    at Object.<anonymous> (/usr/local/lib/node_modules/journ/journ.js:131:11)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)

[ ] rename the the config file as ".journ.cfg.json" as a  hidden file in Finder
[ ] search working directory, then in home directory


Added customIcons property on DynamicForm.

Q
A

Bug fix?
[ ]

New feature?
[x]

New sample?
[ ]

What's in this Pull Request?
Added a new property on the DynamicForm control called customIcons. This property is used if the developer wants to override the default icons generated automatically by the DynamicForm.
To use it simply define a dictionary with the internalColumnName as key and set the corresponding Fluent UI icon name.
I've also updated the ControlsTest web part with a sample using the Title column.

@GuidoZam - could you please resolve the conflicts

@AJIXuMuK 👍 I'll do as soon as I can.

@AJIXuMuK it should be ok now 😄