Discussions Error Handling

Jira: https://openedx.atlassian.net/browse/MA-2284

@aleffert Please review

[Current coverage][cc-pull] is 49.20%

Merging [#718][cc-pull] into [master][cc-base-branch] will decrease coverage by -<.01%

File ...ViewController.swift was modified. more

Misses -5
Partials 0
Hits 0

@@             master       #718   diff @@
==========================================
  Files           445        445
  Lines         28839      28862    +23
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits          14200      14200
- Misses        14639      14662    +23
  Partials          0          0

Powered by Codecov. Last updated by [ce14f83...b561a1f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/edx/edx-app-ios/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/edx/edx-app-ios/compare/ce14f83055493ec89784324670e9da520c376eb5...b561a1f6788149e96cc2a0f731c848fec539d8d8
[cc-pull]: https://codecov.io/gh/edx/edx-app-ios/pull/718?src=pr

Couple minor nitpicks. Otherwise looks good


bug: Documentation no longer specifies go (and version) in prerequisites to install

Describe the bug
The "required packages" include files no longer mention go, and any of the examples which include a "make build" command may fail as a result.
Steps To Reproduce

go to https://docs.kubestellar.io/main/Coding Milestones/PoC2023q1/example1/
Read and follow the instructions to install prerequisites
Continue down to https://docs.kubestellar.io/main/Coding Milestones/PoC2023q1/example1/#get-kubestellar
reach the make build command and run it
if go is not installed, or too old a version is installed, this will fail

Expected Behavior
Add mention that if you will be building kubestellar from the source, you need to have go>= 1.19 installed. This used to be in the prerequisites include file.
If it was removed from there as excess because its not needed for the containerized quickstart using bootstrap, which also pulls in those required software include files, call out the requirement for go in the main file after the prereqs section.
Additional Context
No response

@KPRoche I think that is in the top of the page under required packages, no?

hmm, well, that was there a while back - guess it needs to be re-added

nope

I think it was pulled out in the name of simplifying the quickstart

hmm, well, that was there a while back - guess it needs to be re-added
It is a conditional requirement IFF you are doing a build. Might be worth standing it out from the main prereqs as an optional requirement

QUESTION: when is go actually required? only for doing a make build or code development, or does it need to be installed for the using one of the release archives?
In other words, if I'm not building my own binaries, but just want to run from one of the releases, do I need to install go?

Right, it depends on the role of the person involved.  For a user of a release, there is no go compilation involved.  For a contributor who is building, go compilation is involved.

@KPRoche @fab7 can you work together to knock this out?

@KPRoche @fab7 can you work together to knock this out?
@clubanderson
Would you prefer this be mentioned in the pre-reqs include file, or as a note for contributors/developers in the text specific to the extended example?

well, you opened the issue - where do you think it fits best?  Where is it most useful/helpful?

I think including it in the prereqs is still appropriate, at least in the overview section. I'll create a fork and a PR.

PR #1233 created

is this closed now @KPRoche ?


Open external links in a new tab

We currently style external links with an arrow by adding the the class external-link. This change extends that behavior to also add the target _blank so that external links open in a new tab.
Opening external links in a new tab helps users avoid losing the context they were in with Buildkite.
Example
See the link on to Jenkins in the first sentence:
Before: Current page
After: Preview page

This looks great @mbelton-buildkite !
I've tested the external link behaviours on the before and after pages you linked to above, as well as some external links in the 'Background to packages' page of the Packages docs, and they work as expected.


feat(Storage): add columns setup

Closes #1216
Add columns setup to Storage groups and nodes tables on Cluster, Tenant, Group, PDisk and VDisk pages
Remove advanced storage setting, since VDisks with PDisks column could be selected in setup
Stand: https://nda.ya.ru/t/RkTCeA0U78MSpb
CI Results
Test Status: ❌ FAILED
📊 Full Report

Total
Passed
Failed
Flaky
Skipped

124
114
2
8
0

Bundle Size: 🔺
Current: 79.01 MB | Main: 78.98 MB
Diff: +0.04 MB (0.05%)
⚠ Bundle size increased. Please review.

ℹ CI Information

Test recordings for failed tests are available in the full report.
Bundle size is measured for the entire 'dist' directory.
📊 indicates links to detailed reports.
🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov what do you think if we move column selector in Vdisk and Pdisk pages on a previous line like:

@artemmufazalov what do you think if we move column selector in Vdisk and Pdisk pages on a previous line like

I don't like the control on the tabs level, since it is connected to content of one tab and isn't connected to another - PDiskPage , or control changes depending on tab - StorageGroupPage
As for VDiskPage - I don't see much difference, I prefer to leave it the same way as for PDiskPage and StorageGroupPage


Records accurate mouse movements but no actual content?

Anything I record results in a black screen. Mouse movements are tracked accurately. I've tried messing around in the options but can't find anything that seems amiss. Any suggestions?

Lets see, could you share your system info?
Windows version/build
Laptop or desktop?
If laptop, contains GPU?
If you have a laptop with GPU, you can try switching the settings to make the app use only the CPU or to use the GPU.

Windows 10, Lenovo Desktop.

I guessed that a video setting could be the culprit. I'll keep searching for answers.

Sorry for taking so long, there's a new capture method incoming, in v2.20:
Would you like to try it? #551

Also, the content that you tried to record could be blocked by DRM.

Closing as inactive.


Update to Bevy .10.1 and Add additional method to reparent found meshes to Named nodes within the Scene

Just a quick update for version nums -- was causing issues on .10

Note: Currently an issue where Rapier colliders aren't registered so the Scenes API panics when they try to spawn; Currently researching a work around

Worked around this by serializing the colliders to bytes and then deserializing them back to Colliders after the scene is spawned.


Documentation Confusion

I was following the documentation and it took me a second to remember that I would have to restart the server after I set the API Token and hit submit.  Maybe its just me but after a user hits submit it might be useful to remind them to restart the server in order for the changes to take place.
Follow the instructions on the Admin page. After configuring the "Base URL" and "API Token", click on the green "Submit" button
Click the blue "Home" button
Restart Server
Head back to localhost:3000
You should now see a purple "Log in with Facebook" button, click that button.
Thanks :)

Thanks for the issue! Sorry that this took so long for me to see :disappointed:


send file with non-ACSII filename

Error will occur when using sendDocument/sendAudio/...etc with non-ASCII filename.
The underlying cause is that the function format_header_param() in "requests/packages/urllib3/fields.py" (from library requests) is using an old way "RFC 2231" to handle non-ASCII character for the content-disposition of multipart/form-data. However, telegram bot API seem aborted this way and accept the utf-8 charater directly.
The way I solve this issue is changing the body of format_header_param() from
...
value = email.utils.encode_rfc2231(value, 'utf-8')
value = '%s*=%s' % (name, value)
...

to
value = '%s=%s' % (name, value)

Obviously, it is not a perfect way to tackle the problem since it may affect other process to use library requests

This may be related to issue #32, which will be my priority from now on. Let's see how it ends up.


New student

Name: Rania H.
GitHub: @neuravinci
Website:

@neuravinci
Can you create your profile in that way?
Thanks! :smile:


tssserver.log enabled installation wide

re #23187

have a small workspace without settings
look at server log, get prompted about missing setting, follow steps
🐛 the setting is stored globally enabled logging for all my ts project

Thanks. I agree this is not ideal but it was by-design. The server log setting is a user-specific setting instead of one that is meant to be shared among team or project members. That's why I was hesitant to write it to the .vscode/settings.json.
Let me know if you have any suggestions on how this could be handled better

How about not making it a setting but just stored state via workspaceState

Interesting option. I have a few concerns with that approach though:

The "typescript.tsserver.trace" setting. Having trace be a setting but logging be workspace state felt confusing
Less knowledge of when logging is enabled or disabled for users. Having a setting makes it explicit that logging is enabled for you. We could look at exposing logging status somewhere in the UI,  but using a setting makes it more clear using logging is enabled or not

Closing as-designed. As noted, the current solution is not ideal, but this is not an option we hope to have users messing around with too often, and a user setting seems to offer the most consistent behavior here


Issue with paring - "your permission is required to connect your device to TV" required each time

Thank you for all your hard work!
I'm having an issue getting this to pair with my new samsung frame tv (2021). I have tried manually pairing with the command suggest in my homebridge logs:
sudo npx homebridge-samsungtv-control pair2 <IP_ADDRESS> 68:72:c3:c5:a7:0a ornpx homebridge-samsungtv-control pair1 <IP_ADDRESS> 68:72:c3:c5:a7:0a
This appears to work. However any time I try and interact with the TV via homebridge the TV pops a dialogue up saying "Your permission is required to connect your device to the TV [allow] [deny]" - I have turned off the security setting in the TV to ask each time, but still it continues to ask, which renders the plugin unfunctional.
Example output from my homebridge startup
[6/29/2021, 3:28:41 PM] [SamsungTVControl] Found device The Frame (QN75LS03AAFXZA), usn: uuid:c9731f69-25be-43af-8e82-3ccfe89fc33c
Preparing Advertiser for 'The Frame A4D3' using bonjour-hap backend!
Starting to advertise 'The Frame A4D3' using bonjour-hap backend!
[6/29/2021, 3:28:41 PM] The Frame A4D3 is running on port 45775.
[6/29/2021, 3:28:41 PM] Please add [The Frame A4D3] manually in Home app. Setup Code: 123-45-678

Example of my config
{
    "platform": "SamsungTVControl",
    "devices": [
        {
            "usn": "uuid:c9731f69-25be-43af-8e82-3ccfe89fc33c",
            "token": "14970221",
            "name": "The Frame"
        }
    ]
}

Example output of:
$ sudo npx homebridge-samsungtv-control pair2 <IP_ADDRESS> 68:72:c3:c5:a7:0a ornpx homebridge-samsungtv-control pair1 <IP_ADDRESS> 68:72:c3:c5:a7:0a
Ok... sending the pairing request to your tv. Please click allow when asked
Looks good so far. Sending the MUTE key to your tv to see if it works...
Did the tv switch it's mute state? If yes then add this to your config as token: 14970221

If it didn't work, here are some other possible solutions:
        1. Try another port npx homebridge-samsungtv-control pair2 <IP_ADDRESS> 68:72:c3:c5:a7:0a --port 8001
        2. Try another port npx homebridge-samsungtv-control pair2 <IP_ADDRESS> 68:72:c3:c5:a7:0a --port 55000
        3. Try the other pairing method npx homebridge-samsungtv-control pair1 <IP_ADDRESS> 68:72:c3:c5:a7:0a
        4. Try the legacy protocol npx homebridge-samsungtv-control legacy <IP_ADDRESS> 68:72:c3:c5:a7:0a

All other pairing methods suggested fail.

I have exactly the same problem.
I also get this message in the log file:
This plugin slows down Homebridge. The write handler for the characteristic 'Active Identifier' on the accessory 'Bedroom TV CBCB' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

I have the same issue too with a frame 2020.

Same problem as others. Tried all pairing options. Removed reinstalled bridge and plug-ins.

Has anyone figured / managed a work around to this issue?

yeah would be great.... paring seems to work with my tv, but then nothing... and tv is always askin for permission after a command send from homekit.

Has anyone figured / managed a work around to this issue?

FWIW I have not found a workaround and have given up at this point with this plug-in/bridge having tried all options and retrying after the recent HOOBS upgrade (4.0.92 ). I will wait and see if a bridge or plug-in upgrade fixes the problem.

I have the same (or a very similar) issue on my 2017 or 2017 model. Pairing worked (muted, was given a pin) but every time I try and do anything in HK the TV asks for permission. I've tried all the different settings for permissions on the TV.
Any ideas on what might be happening/how we can fix it?

i am honing in on the problem at least for me. I turned on debugging and saw errors from the bridge saying it could not connect to my EERO router. That prompted me to look and indeed all my other bridges are listed in EERO as a device. However this samsungTV control bridge never connects to the EERO. I tried bypassing the EERO but had the same issue with the Xfinitity router which would not allow the SamsungTV to connect. I have tried putting in MAC addresses etc to no avail. All my other Hoobs bridges had no problems connecting to my EERO router and all work fine. I am not sure why this is considered a certified plugin when it has a basic connectivity problem like this.

Same problem here. FYI, The PIN provided is not the token - that's the HomeKit device PIN. The mute test works, But it still requests permission every time it tries to do something, and a token is never generated. TV is a 2015 6 Series.

I have a Samsung Frame as well, exactly the same issues as described above; mute was working but kept asking for permissions. Switched to https://github.com/tavicu/homebridge-samsung-tizen plugin and managed to get on/off with art-mode working as well as the apple-remote for homekit-tv so i can control the volume, up/down buttons etc with the apple remote widget from my iOS widget panel


Add support for Heiman Alarm remote HS1RC-EM

The HS1RC-EM is a keychain remote control for arming and disarming alarm systems and. includes an emergency button. It is a variant of the HS1RC-N.
HS1RC-EM is not yet in the master branch of zigbee2mqtt, but will be soon. It is already in the master of zigbee-herdsman-converters.
HS1RC-N already is supported bij zigbee2mqtt and would probable work with the same code! You could probably add it to init.py. I did not because I only submit PR's for things I could actually test.

Thanks!


WIndows is_mount is not supported

deluge-card version: 0.1.1
Python version: 3.9
Operating System: Windows

Description
tox test fails
    def is_mount(self):
  >       raise NotImplementedError("Path.is_mount() is unsupported on this system")
  E       NotImplementedError: Path.is_mount() is unsupported on this system

fixed in https://github.com/mupaduw/deluge-card/pull/1/commits/ba6570df10188378e6beaf69c439f010db76b9c8


Error while executing evaluate

CODE:
function BungeeEvaluateAllServers(eval:text):
	loop all bungee servers:
		evaluate {_eval} on loop-value
BungeeEvaluateAllServers("broadcast ""This is a test""")

04.11 21:45:10 [Server] INFO [Skungee] [Skungee] Severe Error:
04.11 21:45:10 [Server] INFO [Skungee] Could not read incoming packet
04.11 21:45:10 [Server] INFO [Skungee] Something went wrong within Skungee.
04.11 21:45:10 [Server] INFO [Skungee] Please report this error to the developers of Skungee so we can fix this from happening in the future.
04.11 21:45:10 [Server] INFO [Skungee] Report this at https://github.com/TheLimeGlass/Skungee/issues
04.11 21:45:10 [Server] INFO [Skungee] You can also message one of the Skungee developers this error.
04.11 21:45:10 [Server] INFO [Skungee] Stack trace:
04.11 21:45:10 [Server] INFO [Skungee] java.net.SocketException: Relais brisé (pipe) (Write failed)
04.11 21:45:10 [Server] INFO [Skungee]     at java.net.SocketOutputStream.socketWrite0(Native Method)
04.11 21:45:10 [Server] INFO [Skungee]     at java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:111)
04.11 21:45:10 [Server] INFO [Skungee]     at java.net.SocketOutputStream.write(SocketOutputStream.java:155)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1877)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1786)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1286)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1231)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1427)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1577)
04.11 21:45:10 [Server] INFO [Skungee]     at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:351)
04.11 21:45:10 [Server] INFO [Skungee]     at me.limeglass.skungee.spigot.sockets.SpigotRunnable.run(SpigotRunnable.java:103)
04.11 21:45:10 [Server] INFO [Skungee]     at java.lang.Thread.run(Thread.java:748)
04.11 21:45:10 [Server] INFO [Skungee] Information:
04.11 21:45:10 [Server] INFO [Skungee]   Skungee: 1.0.11
04.11 21:45:10 [Server] INFO [Skungee]   Bukkit: 1.12.2-R0.1-SNAPSHOT
04.11 21:45:10 [Server] INFO [Skungee]   Minecraft: v1_12_R1.
04.11 21:45:10 [Server] INFO [Skungee]   Java: 1.8.0_181 (Java HotSpot(TM) 64-Bit Server VM 25.181-b13)
04.11 21:45:10 [Server] INFO [Skungee]   OS: Linux amd64 4.9.87-xxxx-std-ipv6-64
04.11 21:45:10 [Server] INFO [Skungee] Running CraftBukkit: false
04.11 21:45:10 [Server] INFO [Skungee] Thread: Thread[Thread-102,5,main]
04.11 21:45:10 [Server] INFO [Skungee] End of Error.

However, the evaluate is executed!

Update: It is not a really important problem I think, the error disapear one day later...


enhancement Optimize stats pre-load logic

Don't do pre-load until stats table gets ready
Don't put pre-loaded unknown stats to cache

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Custom Magento order types cause order to skip order states

Merchant is using Magento <IP_ADDRESS>, with the latest BitPay plugin (2.1.18).
Merchant is using the iframe invoice.
Merchant has added custom order types.
Orders are marked as fully paid in Magento, whereas the BitPay invoice has not been paid at all.

The issue appeared to be a Magento system configuration issue (the order states were not mapped correctly within Magento)


#4953 Adding rule to package info to be required

Adding as commented rule.
Issues fond that need to be fixed before turning on:

com/azure/storage/common/Utility.java
com/azure/storage/file/ShareClientBuilder.java

Issues found report
checkstyleIssuesReport.zip

@alzimmermsft Can you get the two missing package-info.java files added, so that this rule can be enabled? Thanks!


fix bug - missing colon

Missing colon for if statement.

It look this as resolved, and there has been no response for the author.  I'm closing it, but if it is still an issue, please reopen it.  Thanks for your help


MWC Snackbar: CSS variable for background color

Is your feature request related to a problem? Please describe.
Can't change the background color of a snackbar.
For example, the standard snackbar is great for dark themes, but not on light ones
Describe the solution you'd like
Support snackbar theming (css variable for background color)
Describe alternatives you've considered
It's possible to do this only with JS at the moment

Thanks for the issue!

@maicol07 out of curiosity: how are you handling it with JS?

@veller at the moment you have only two possibilities:

Extending the webcomponent and then add the background color (recommended):

import {Snackbar as MWCSnackbar} from '@material/mwc-snackbar`;
import {css} from 'lit';

export class Snackbar extends MWCSnackbar {
	static styles = [MWCSnackbar.styles, css`.mdc-snackbar__surface { background-color: white }`]
}

Traverse the shadow root to change the color manually (might not work):

document.getElementsByTagName('mwc-snackbar')[0].shadowRoot.firstElementChild.firstElementChild.style['background-color'] = 'white'


[CORE] Add GlutenImplicits to get FallbackSummary easily

What changes were proposed in this pull request?
This pr adds a a helper class to get the Gluten fallback summary from a Spark Dataset. If AQE is enabled, but the query is not materialized, then this method will re-plan the query execution with disabled AQE. It is a workaround to get the final plan, and it may cause inconsistent results with a materialized query. However, we have no choice.
For example:
import org.apache.spark.sql.execution.GlutenImplicits._
val df = spark.sql("SELECT  FROM t")
df.fallbackSummary

How was this patch tested?
add test

cc @zhouyuan @PHILO-HE thank you

Hi @ulysses-you, could you also update the doc? This may be a good place: https://github.com/oap-project/gluten/blob/main/docs/get-started/Velox.md

@PHILO-HE yes, added the docs

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3599_time.csv
log/native_master_11_05_2023_16e287450_time.csv
difference
percentage

q1
32.73
34.85
2.126
106.49%

q2
24.76
25.12
0.356
101.44%

q3
37.88
40.11
2.231
105.89%

q4
36.83
37.09
0.264
100.72%

q5
69.01
71.44
2.431
103.52%

q6
6.49
9.10
2.608
140.18%

q7
85.59
87.61
2.027
102.37%

q8
86.81
85.22
-1.592
98.17%

q9
123.02
121.12
-1.894
98.46%

q10
51.97
51.83
-0.138
99.74%

q11
20.23
19.68
-0.549
97.29%

q12
25.58
28.01
2.433
109.51%

q13
49.44
48.61
-0.833
98.32%

q14
17.57
19.14
1.571
108.94%

q15
30.50
33.03
2.522
108.27%

q16
16.71
16.10
-0.611
96.35%

q17
102.53
102.08
-0.447
99.56%

q18
147.61
149.04
1.430
100.97%

q19
14.80
18.25
3.449
123.31%

q20
30.65
30.91
0.269
100.88%

q21
222.07
222.95
0.878
100.40%

q22
13.76
13.47
-0.291
97.88%

total
1246.52
1264.76
18.242
101.46%


Fix failing ToolchainsParallelActionExecutionCrossVersionSpec

This was attempted in https://github.com/gradle/gradle/pull/28291, but that was not enough. We need to conditionally assert output message, depending on target Gradle version.

The merge queue build has started. Click here to see all failures if any.


"#undef" after DataFrame conversion

Conversion to DataFrame doesn't seem to work.
Before conversion username is like PointerString("myUsername").
 1x2 Data.Schema:     id,             username  Int32, PointerString{UInt8} Column Data: 	Int32[1] 	PointerString{UInt8}[PointerString("myUsername")]
After conversion it becomes #undef
│    Row    │     id     │        username           │  ├─────┼────┼──────────┤ │      1        │     1      │         "#undef"            │

Should be fixed by 99120a1febda35407fe0a963a51e3337aaeb8901


Improve CICD

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.
[ ] npm run build runs as expected.

Please review per commit.
Release plan:

Make a final prod release using Lerna so all prerelease versions graduate to the next stable version
Rebase and merge this one. This PR also removes Lerna as a dependency
Make a test release with changeset

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Confusing code in class BertHighway in modeling_highway_bert.py

Greetings, DeeBERT is really a crucial and easy-to-understand achievement in BERT inference acceleration.
However, in transformers/modeling_highway_bert.py, the forward function of class BertHighway is a bit confusing. Your original code is as follows
def forward(self, encoder_outputs):
    # Pooler
    pooler_input = encoder_outputs[0]
    pooler_output = self.pooler(pooler_input)
    # "return" pooler_output

    # BertModel
    bmodel_output = (pooler_input, pooler_output) +encoder_outputs[1:]
    # "return" bodel_output

    # Dropout and classification
    pooled_output = bmodel_output[1]

    pooled_output = self.dropout(pooled_output)
    logits = self.classifier(pooled_output)

    return logits, pooled_output

I am not quite sure about introducing bmodel_output for it's not actually used.
It seems that pooler_input is sequence_output, and pooled_output is equivalent to pooler_output.
Is there any trick that should be noticed? Maybe the comments starting with "return" can be updated for more details.

You are right that bmodel_output is not actually used and all we need is pooler_output. I wrote it in this way mainly because I want them to align with BertPooler, BertModel output at the time of implementation.


fix: dependabot ci

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Additional features to support unpkg.com as a SystemJS source

It would be nice to use Unpkg as a universal source for packages when using dynamic loaders such as SystemJS. An ideal configuration would be:
SystemJS.config({paths:{"*":"//unpkg.com/*.js?as=umd"}})

Allowing the following forms:
require("jquery")
require("gl-matrix")
require("tgd")

Right now, this would not work for modules such as gl-matrix and tgd for the following reasons:

gl-matrix exports the ES6 code by default, but has a dist version with an UMD build at<EMAIL_ADDRESS>tgd exports the UMD build under the umd directory and uses umd/index.js as the main file, however the relative imports fail because the Unpkg URL is unpkg.com/tgd and not unpkg.com/tgd/umd

In order to better support SystemJS-like paths, Unpkg could:

Add a as=umd parameter with the following semantics: look for an umd or dist directory, and use it as root.
If an index.js is present in this directory, it should be served by default when the request URL path does not end with a /. For instance<EMAIL_ADDRESS>and<EMAIL_ADDRESS>now return the same, while it could<EMAIL_ADDRESS>return the contents of<EMAIL_ADDRESS>(or at least redirect to it).

The relatively simple changes would allow to bypass package management systems such as NPM or JSPM and use unpkg as an online, versioned, package source.

I don't have a lot of experience w SystemJS, but just looking at the config you've got there, could you do something like this right now?
SystemJS.config({
  paths: {
    "gl-matrix": "//unpkg.com/dist/*.js",
    "tgd": "//unpkg.com/umd/*.js"
  }
})

Yes, that might work, but then I would need to specify each dependency (and the dependencies's dependencies) in the the paths. With the solution outlined above, you just need to configure the catchall path and most require should succeed without additional configuration.

What is the root problem here?
I see that in the tgd package you're using "main": "umd/index.js". So, technically if you have a require("tgd") that should just work. Are you trying to require other files deeper inside the tgd package? What do your require paths look like?

Also, do you think the the browser package.json field could help here in some way? Sorry for so many questions. I'm just trying to understand the root of the problem before we talk about solutions.

The root problem is as follows: we do not want to manually register the unpkg URLs for every single package (including their dependencies).
For instance:

tgd contains pre-built files in the umd directory, as a result, the ideal generic SystemJS config path "*":"//unpkg.com/*.js" would not work. Instead, one has to specify "tgd": "//unpkg.com/tgd/umd/index.js"
tgd transitively imports gl-matrix and performance-now. gl-matrix has a pre-built UMD file in dist. Like with tgd, we can't use the generic "*":"//unpkg.com/*.js", and instead need to add "gl-matrix": "//unpkg.com/glmatrix/dist/glmatrix.js"

And yes, taking hints for the browser field would probably help, although this is more a nice to have.

Hi Michael! I was wondering if you needed some help to better formalize the feature, I could also give a hand for implementation.

Yes, some help would be very much appreciated. I think implementation
should be pretty straightforward.
Let's pretend we're writing some user-facing docs for this feature. How
could we describe it in a sentence or two?
Here's a first draft:
"You can use the 'as' query parameter to specify a directory that unpkg
should look in if the file in the original request path is not found. This
is useful when using SystemJS to include packages that keep their browser
builds in different directories but do not use the browser field in their
package.json."
Is that last part wrong? It seems like we're incurring extra complexity on
our side because packages are not using the "browser" field properly, but
there may still be a piece I'm missing.
On Fri, Oct 7, 2016 at 7:35 AM Sébastien Pierre<EMAIL_ADDRESS>wrote:

Hi Michael! I was wondering if you needed some help to better formalize
the feature, I could also give a hand for implementation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/unpkg/unpkg.com/issues/16#issuecomment-252269131, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFqp9xL06hKfyuGcqpWpsm4Vpp0dzYpks5qxljCgaJpZM4KJOFN
.

--
Michael Jackson
@mjackson

As stated in https://github.com/unpkg/npm-http-server/issues/57, i'm happy to make MR

Go for it! Can you also please include an example app that demonstrates the
functionality you're after? I still haven't had time to look into this
properly (sorry!) and I think a sample app might help me understand better.
On Tue, Nov 15, 2016 at 2:40 AM TruongSinh Tran-Nguyen <
<EMAIL_ADDRESS>wrote:
As stated in unpkg/npm-http-server#57
https://github.com/unpkg/npm-http-server/issues/57, i'm happy to make MR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/unpkg/unpkg.com/issues/16#issuecomment-260607822, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFqp9uE3VSH3pDqr7tzgzR4KLIPdDdEks5q-Yw6gaJpZM4KJOFN
.
--
Michael Jackson
@mjackson

@truongsinh Have you had a second to look further into this? I'd really love to see a simple little app that I can just npm start to get the idea of what you guys are trying to do.

@sebastien If you're still up for it, I'd love a hand with this. It sounds very promising.

I'm not sure what to add to what I've already written. Basically, there are two new features/changes to implement:

Detect a dist/build version and serve it when passed the "as=umd" parameter. The behaviour should be: a) look for a browser entry in package.json, b) look for a dist or umd directory c) use it as the new root for serving files.

Make sure that any path ending with a slash shows the directory content, no slash can default to an index.js files as it is currently the case.

The end goal of this is to allow unpkg to be used as a source of directly usable JavaScript packages, without having to use any packager manager at all. The problem that these changes try to solve is the variety of configurations of where the pre-built files are located.

Thanks for the summary, @sebastien. Would you care to make a PR? Otherwise I may have some time soon to take a look.

I sadly don't have any experience with NodeJS server development :/

Just a note about this:

If an index.js is present in this directory, it should be served by default when the request URL path does not end with a /. For instance<EMAIL_ADDRESS>and<EMAIL_ADDRESS>now return the same, while it could<EMAIL_ADDRESS>return the contents of<EMAIL_ADDRESS>(or at least redirect to it).

<EMAIL_ADDRESS>now redirects to<EMAIL_ADDRESS>I'm not sure why I didn't see this before. It seems obvious now that it always should've worked that way to preserve relative module paths.
Anyway, I think this should get us closer to being able to load stuff directly using SystemJS.

I just opened a case https://github.com/ModuleLoader/es-module-loader/issues/538 that might be of interest. Basically I noticed that relative URLs are being resolved wrt the import URL rather than the import URL after redirects, and think that may be a bug in Chrome or an opportunity to improve the spec.

Hey guys
Have been trying to get it work for almost two years now.
Made many iterations, but always had some issue. But recently, I have been successful in using npm5's package-lock.json along with some simple post processing as source for systemjs config.
Post processing is necessary for two things

to make sure require('src/common') maps to require('src/common/index')
to deal with issues with some jspm-nodelibs-* packages - these have jspmNodeConversion = false in their package.json and I need to copy the map object from their package.json to make them work.

Code can be found here if anyone is interested abhishiv/npm-resolver

I'm a little late here, but I started to use SystemJS with a PHP env in past year and I want to know: can I use unpkg as a SystemJS source now or it stills kinda buggy?


Removed all punning, ie an illegal mix of DatatypeProperties and Objectproperties

Great job! Must have been a lot of work ...


feat: update config_driver tests for Appium

Coverage: 90.54% (+0.9%) from 89.679% when pulling 8d5476a9a3b820390f7a1c3e3305b97332ecc9a8 on feat/config_driver_appium_tests into b04106101dc76ba25585e234b2e12cb5e93ee5a0 on master.


⚠ Bofrost.lu has degraded performance

In f8831c3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1061 ms

Resolved: Bofrost.lu performance has improved in b292619 after 6 minutes.


(maint) Remove Ruby 2.3.0 from Travis C.I. matrix

Since we're getting a mysterious seg fault when running our spec
tests against Ruby 2.3.0, remove it from the Travis testing matrix
for now until the issue is sorted out.

Can you remove the other 2.3.0 exclusion as well? It's on lines 32-33 of the original (if I read the line numbers right :)).

@kylog Whoops, sure thing thanks for pointing that out. Apparently if things are not grouped together I ignore them

https://bugs.ruby-lang.org/issues/11928 looks likely

@kylog Updated! :+1:

Thanks for running down the bug @MikaelSmith! @HAIL9000 can you drop that in the commit message? Once they release a fix, it'll be nice to restore this in travis.

Updated to reference Ruby ticket :sunglasses:

Were you going to try bumping this to 2.3.0-dev?

I suggested we get it in so we can merge PUP-5696, then mess with trying 2.3.0-dev separately.


Add .DS_Store to .gitignore

While I was poking around with prism locally, git was kind to point out that I had modified this (mac specific) file. It would be convenient if it was ignored by default.

Thanks!


HABTM inverse_of relationship using $set instead of $pushAll

On the other side of an HABTM relationship, on the inverse_of model Mongoid is using $set instead of $pushAll to update the "*_ids" attribute. This can cause data loss in a quick moving application. Using 2.2.0 gem here.
Here's a snippet from my logs:
MONGODB laylow_development['users'].update({"_id"=>BSON::ObjectId('4e72a09573036a70ca000004')}, {"$set"=>{"interaction_ids"=>[BSON::ObjectId('4e9142fb73036a3f61000005')], "updated_at"=>2011-10-09 06:50:11 UTC}})
MONGODB laylow_development['interactions'].update({"_id"=>BSON::ObjectId('4e9142fb73036a3f61000005')}, {"$pushAll"=>{"participant_ids"=>[BSON::ObjectId('4e72a09573036a70ca000004')]}})

@radicaled I think we should be doing $addToSet instead of $pushAll or $set here - would you agree with that?

The core issue here is slightly more general - dirty tracking needs to be smarter with arrays... It should know to $set/$pull/$push depending on how the array has actually changed, not that it only changed.

Note this is going to require smarter atomic update generation of array fields in general. Instead of just checking if they changed and performing a $set, they need to know if something was added or removed and perform the necessary $push/$pull operations.


Fix Nav Bar

There's a yellow node appearing in the submenu components
Submenu components have a scroll bar

Fixes added in https://github.com/ladyofcode/artifex-site/pull/35


Support DIMENSION PROPERTIES in mdxpy

MDXpy should support DIMENSION PROPERTIES. They are a standard feature of MDX and are supported in TM1. Since TM1 11 they can also be used in MDX datasources for TI.

Microsoft Reference:

https://docs.microsoft.com/de-de/analysis-services/multidimensional-models/mdx/mdx-member-properties-intrinsic-member-properties?view=asallproducts-allversions

TM1 sample

SELECT
{[plan_time].[plan_time].[Q1-2004], [plan_time].[plan_time].[Q1-2004].CHILDREN}
DIMENSION PROPERTIES [plan_time].[Time_Swedish] on 0,
[plan_chart_of_accounts].[plan_chart_of_accounts].MEMBERS
DIMENSION PROPERTIES MEMBER_NAME on 1
FROM [plan_BudgetPlan]
WHERE ([plan_business_unit].[plan_business_unit].[10110], [plan_department].[plan_department].[105], [plan_source].[plan_source].[input])
DIMENSION PROPERTIES MEMBER_NAME, [plan_business_unit].[BusinessUnit_Swedish], [plan_business_unit].[Currency], [plan_department].[Department_Swedish]

More background in IBM Planning Analytics Forum

https://community.ibm.com/community/user/businessanalytics/communities/community-home/digestviewer/viewthread?GroupId=3067&MessageKey=beac9ad9-37cf-403c-9436-5fdb8fac8f87&CommunityKey=8fde0600-e22b-4178-acf5-bf4eda43146b&tab=digestviewer&ReturnUrl=%2Fcommunity%2Fuser%2Fbusinessanalytics%2Fcommunities%2Fcommunity-home%2Fdigestviewer%3Fcommunitykey%3D8fde0600-e22b-4178-acf5-bf4eda43146b%26tab%3Ddigestviewer

Hi, @MariusWirtz
Just check on this one. Is the enhancement available now for the latest release? Thanks.

Hi @macsir,
sorry for the late reply.
No. Unfortunately, it's not available yet. please feel free to open a MR.


Task message is encoded

Description:
Schedule tasks won't work as the message element is encoded. We should have it as follows without encoding,
<message @_xmlns=""></message>

@SanojPunchihewa could you please try with the latest version 1.0.1?

This seems to be fixed in latest version

Closing this as it is already fixed. Please reopen if you have any more concerns.


Does not open in NavigationLink

Hello, I have a NavigationStack along with a Navigation Link, and I also have a .resizableSheet($state) modifier. When I open a nested View (resizableSheet is encountered for the first time), it is freely called, but when I go even further through NavigationLink and .resizableSheet is also used there, it is no longer called
My test project: https://github.com/Festanny/ResizableSheet

It was solved simply by adding a different id
.resizableSheet($state, id: "1")


Long proposal name causes horizontal scroll

(scrollbar not visible because modern UI)

Note that I trimmed the names in UI further (removing excess ... Proposal and somewhat unneeded/verbose ... .prototype. ...) which should help for now, but still remains an issue.

This is mostly not an issue for now and unlikely to come up again - we should trim proposal names so they should never be this long ever really, if not they should probably be trimmed further.


rougeL returns 0 score on perfect prediction in some languages

Change xlsum.py to run on all languages (remove if lang == langs[0]:)
Run python  prepare/cards/xlsum.py
Traceback (most recent call last):
File "/home/runner/work/unitxt/unitxt/tests/test_preperation.py", line 47, in test_preprations
import_module_from_file(file)
File "/home/runner/work/unitxt/unitxt/tests/test_preperation.py", line 27, in import_module_from_file
spec.loader.exec_module(module)
File "", line 843, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/runner/work/unitxt/unitxt/prepare/cards/xlsum.py", line 42, in
test_card(card, debug=False)
File "/home/runner/work/unitxt/unitxt/src/unitxt/test_utils/card.py", line 238, in test_card
test_with_eval(
File "/home/runner/work/unitxt/unitxt/src/unitxt/test_utils/card.py", line 184, in test_with_eval
raise AssertionError(error_message)
AssertionError: The results of running the main metric in used in the card (rougeL) over simulated predictions that are equal to the references returns a different score than expected.
One would expect a perfect score of 1.0 in this case, but returned metric score was 0.0.
This usually indicates an error in the metric or post processors, but can be also an acceptable edge case.
In anycase, this requires a review.  If this is acceptable, set strict=False in the call to test_card().
The predictions passed to the metrics were:
['በታይዋን ከአንዲት ሴት አይን ውስጥ ዶክተሮች አራት ንቦችን አወጡ። በደሴቲቱ እንዲህ አይነት ነገር ታይቶም ተሰምቶም አይታወቅም ሲሉ ተናግረዋል።', 'ከሰሞኑ ባለቤትነታቸው የአረና ትግራይ ፓርቲ አባል ናቸው የተባሉ አስራ ስድስት ፍየሎች የመታሰራቸው ዜና የማህበራዊ ሚዲያ ተጠቃሚዎች መነጋገሪያ ሆኖ ቆይቷል።', 'የአሜሪካው ፕሬዝደንት ዶናልድ ትራምፕ ቲክ ቶክ የተሰኘው የተንቀሳቃሽ ምስሎች መጋሪያ በአሜሪካ ድርጅት ካልተገዛ ሊያግዱት እንደሚችሉ አስጠንቅቀዋል።']

My 2 cents, having dug some:
Rouge employs its default tokenizer as first step to computing the score.
When lang = nepali, for example, no token identified, nor in prediction nor in target. Hence the score is 0 for all three examples.
When lang = marathi (!!) it gladly jumps on a '22'  encountered in the string, and then target and prediction both are 'tokenized'  to: ['22'], and this is a hit!  being one of 3 examples, the final score is 0.3333 for this language.
I am not sure how to automatically recognize the language, or whether to use the known language in this case, and where to pull an adequate tokenizer from. whitespace tokenizer does some work, but this is just to prove a concept..


[SymbolGraph] Ignore some Self requirements

To ease the burden on the client, ignore some generic requirements involving
Self. For example, Self: P where we already know that Self conforms to P.
An example case:
public struct S: Equatable {
  public static func ==(lhs: S, rhs: S) -> Bool { ... }
}

!= is defined in terms of Self and the default implementation has a Self: Equatable. For the purposes of documentation, it's not necessary to specify
that again on the page of documentation for !=.
rdar://60963924

@swift-ci Please smoke test


boards: up7000: Add UP 7000 board definition

Add board definition for UP 7000 (https://up-board.org/up-7000/). The board is powered by Intel Alder Lake N (N-series Intel Platform).

@kartben Do you know, can this work 3ec24fa

I think something maybe something like the following would be better (didn't actually test the pattern btw)?  renaming common to _common to better materialize that it's "internal" stuff?
[!_]*/**/*

Added commit ad1a734 to fix broken CI

@finikorg I guess we can remove the DNM label now?

@finikorg I guess we can remove the DNM label now?

Added commit to fix CI: e3efcdb


It doesn't seem to be possible to configure WithInsecure for an opentelemetry collector endpoint

This is absolutely true if you only want to use flags. cobrautil also supports the OpenTelemetry environment variables though, which can configure this.
Because there are just an absolute ton of options as standard environment variables, I'm not sure what ones are best represented as flags or if I should remove the flags entirely and only support the standard environment variables.

It doesn't look like OTEL_EXPORTER_OTLP_INSECURE is supported in this component or in opentelemetry-go. At least I can neither make it take any effect nor can I find any code suggesting that it's actually used.

hmm I was under the impression from the otlptrace readme that it was reading environment variables when we call otlptrace.New().

As described in https://github.com/jzelinskie/cobrautil/pull/14#issuecomment-1249538572, you can use OTEL_EXPORTER_OTLP_ENDPOINT. If the protocol is http, the go OTEL library will automatically use insecure communication


Pip2 Broken Mac OSX 10.13.5

pip version:10.0.1
Python version:Python 2.7.15
OS: Mac OSX 10.13.5

$ which pip
/usr/local/bin/pip
$brew info python@2
`python@2: stable 2.7.15 (bottled), HEAD
Interpreted, interactive, object-oriented programming language
https://www.python.org/
<EMAIL_ADDRESS>(4,726 files, 83.8MB) *
Poured from bottle on 2018-06-26 at 23:44:11
From<EMAIL_ADDRESS>==> Dependencies
Build: pkg-config ✔, sphinx-doc ✘
Required: gdbm ✔, openssl ✔, readline ✔, sqlite ✔
Optional: tcl-tk ✘
==> Options
--with-tcl-tk
Use Homebrew's Tk instead of macOS Tk (has optional Cocoa and threads support)
--HEAD
Install HEAD version
==> Caveats
Pip and setuptools have been installed. To update them
pip install --upgrade pip setuptools
You can install Python packages with
pip install
They will install into the site-package directory
/usr/local/lib/python2.7/site-packages
See: https://docs.brew.sh/Homebrew-and-Python`

I can not do anything with Pip. I can not even learn version knowledge.It gives the following error.
Screenshot of fault screen

➜  ~  pip --version Traceback (most recent call last):   File "/usr/local/bin/pip", line 11, in <module>     load_entry_point('pip==10.0.1', 'console_scripts', 'pip')()   File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 476, in load_entry_point     return get_distribution(dist).load_entry_point(group, name)   File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2700, in load_entry_point     return ep.load()   File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2318, in load     return self.resolve()   File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2324, in resolve     module = __import__(self.module_name, fromlist=['__name__'], level=0)   File "/usr/local/lib/python2.7/site-packages/pip/_internal/__init__.py", line 42, in <module>     from pip._internal import cmdoptions   File "/usr/local/lib/python2.7/site-packages/pip/_internal/cmdoptions.py", line 16, in <module>     from pip._internal.index import (   File "/usr/local/lib/python2.7/site-packages/pip/_internal/index.py", line 15, in <module>     from pip._vendor import html5lib, requests, six   File "/usr/local/lib/python2.7/site-packages/pip/_vendor/requests/__init__.py", line 86, in <module>     from pip._vendor.urllib3.contrib import pyopenssl   File "/usr/local/lib/python2.7/site-packages/pip/_vendor/urllib3/contrib/pyopenssl.py", line 46, in <module>     import OpenSSL.SSL   File "/usr/local/lib/python2.7/site-packages/pyOpenSSL-18.0.0-py2.7.egg/OpenSSL/__init__.py", line 8, in <module>     from OpenSSL import crypto, SSL   File "/usr/local/lib/python2.7/site-packages/pyOpenSSL-18.0.0-py2.7.egg/OpenSSL/crypto.py", line 16, in <module>     from OpenSSL._util import (   File "/usr/local/lib/python2.7/site-packages/pyOpenSSL-18.0.0-py2.7.egg/OpenSSL/_util.py", line 18, in <module>     no_zero_allocator = ffi.new_allocator(should_clear_after_alloc=False) AttributeError: 'CompiledFFI' object has no attribute 'new_allocator'

pip3 command works fine

$ pip3 -V
pip 10.0.1 from /usr/local/lib/python3.7/site-packages/pip (python 3.7)

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.


Update dependencies

Codecov Report

Merging #88 (5526f76) into master (7976648) will increase coverage by 4.87%.
The diff coverage is 92.72%.

:exclamation: Current head 5526f76 differs from pull request most recent head 2b20132. Consider uploading reports for the commit 2b20132 to get more accurate results

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   76.12%   81.00%   +4.87%
==========================================
  Files           8        8
  Lines         930      895      -35
==========================================
+ Hits          708      725      +17
+ Misses        222      170      -52

Impacted Files
Coverage Δ

src/lib.rs
94.64% <ø> (ø)

src/codegen/pda.rs
83.92% <91.48%> (+14.83%)
:arrow_up:

src/pda.rs
66.91% <92.85%> (+3.46%)
:arrow_up:

src/codegen/state.rs
73.91% <100.00%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7976648...2b20132. Read the comment docs.


GCA Intern: Improve DMARC and SPF advice

Adds additional checks for DMARC and SPF records.
DMARC
-Check for v=DMARC1
-Check for p= tag
-Verify akim and aspf values
SPF
-Warning for ptr mechanism
-Check for exceeding dns lookup limit

Thanks for the changes, @SeanM-temp!
The existing separation of the advisor and scanner packages does make validating the number of SPF host lookups difficult. The advisor package shouldn't import scanner; however, the custom DNS implementation being outside of the scanner package is difficult. I'll find some time to properly look over your implementation, and see whether we can improve it :)

Hey @SeanM-temp, apologies that this hasn't been properly reviewed and/or merged yet! I intend to look over it soon :)


Updated handling of splitFrame as job.

Testing PR workflow: The commit includes a tiny change to in splitFrame flow. Now, it is handled as a generic job.

will close this PR per a conversation with @mmalohlava - it sounds like this was implemented another way


ImageLoader: Task was interrupted

I have this error: ImageLoader: Task was interrupted

Any solutions??
Thanks


Feat/apitest2

Version 0.5.1
Added test functions for all storage api commands used by the driver
Removed "poolType" from StorageClass parameters, this is retrieved from the controller
New client.InitSystemInfo() which is called once to retrieve required storage system info
Sets the stage for removing iqn and portals from StorageClass, since the data is now discovered

MaximumLUN is used by the driver when choosing a new LUN number. This will be the maximum number of LUNs allowed per host initiator. This is hard coded in the current version, but it should be extracted from the storage system dynamically. This will be addressed in a separate pull request.


Error with MassiveCombat

Ever since installing LP I've been getting this console spam:
[18:28:48 ERROR]: Could not pass event EventMassiveCorePlayerLeave to MassiveCombat v2.13.1
org.bukkit.event.EventException: null
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:72) ~[patched_1.12.2.jar:git-Paper-1428]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:515) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:500) [patched_1.12.2.jar:git-Paper-1428]
        at com.massivecraft.massivecore.event.EventMassiveCorePlayerLeave.run(EventMassiveCorePlayerLeave.java:84) [MassiveCore.jar:?]
        at com.massivecraft.massivecore.engine.EngineMassiveCorePlayerLeave.runQuit(EngineMassiveCorePlayerLeave.java:57) [MassiveCore.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor56.execute(Unknown Source) [?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) [patched_1.12.2.jar:git-Paper-1428]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:515) [patched_1.12.2.jar:git-Paper-1428]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:500) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.PlayerList.disconnect(PlayerList.java:429) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1147) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.NetworkManager.handleDisconnection(NetworkManager.java:343) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.ServerConnection.c(ServerConnection.java:184) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:941) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:427) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:767) [patched_1.12.2.jar:git-Paper-1428]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:665) [patched_1.12.2.jar:git-Paper-1428]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]
Caused by: java.lang.NullPointerException: attachment
        at com.massivecraft.massivecore.util.PermissionUtil.setAttachmentPermissions(PermissionUtil.java:480) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:231) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:218) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.setFlaggedPermissions(MPlayer.java:212) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.tickFlagged(MPlayer.java:287) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isFlagged(MPlayer.java:350) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isEnabled(MPlayer.java:102) ~[?:?]
        at com.massivecraft.massivecombat.entity.MPlayer.isEnabled(MPlayer.java:97) ~[?:?]
        at com.massivecraft.massivecombat.engine.EngineLogout.listener(EngineLogout.java:53) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor126.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1428]
        ... 21 more

As I said, it started happening immediately after getting LP
Read the second part of the stacktrace. It's a permissions error.

 They absolutely should not be doing this - there is little to no benefit of their approach here.
I've added a workaround for it in LP (see the commit above) - but just want to be clear that this is absolutely an issue with MassiveCore, not LuckPerms.

Still getting this with 4.2.17

Try with 4.2.18, I've made further changes and tested it with MassiveCombat
seems to be working ok
f4e4f727dd835463efbe40570e5dda2344273722

@lucko Totally not your fault, and the issue has been reported to the author for a long time now! No response from the original author.
Opened issue: https://github.com/MassiveCraft/MassiveCore/issues/341
It sucks that we need to rely on you on fixing something that it's not your fault, but we are very grateful for it and for your amazing plugin. Thank you lucko.

^ this

Just to reiterate what I said before:

MassiveCore (a lib used by MassiveCombat) is doing some very stupid things in order to modify attachment permissions. They absolutely should not be doing this - there is little to no benefit of their approach here.

The problematic code is in this class:
https://github.com/MassiveCraft/MassiveCore/blob/master/src/com/massivecraft/massivecore/util/PermissionUtil.java#L405-L493
They're using tons of reflection (a technique for accessing and invoking code outside of a classes normally accessible scope) to really achieve something very simple.
This unfortunately isn't uncommon, and I've had to write a number of workarounds so plugins like this continue to work.
https://github.com/lucko/LuckPerms/blob/master/bukkit/src/main/java/me/lucko/luckperms/bukkit/model/permissible/LPPermissible.java#L331-L416
https://github.com/lucko/LuckPerms/blob/master/bukkit/src/main/java/me/lucko/luckperms/bukkit/model/permissible/LPPermissionAttachment.java#L297-L416
These workarounds have fixed most plugins, but MassiveCore seems to be relying on implementation details for almost all of their code.
As far as I know, this commit https://github.com/lucko/LuckPerms/commit/07b003c77a4c76391f3d91e93b5581db59c2d65c fixed the last issue you posted. Are you sure you were testing on 4.2.19?

Totally not your fault, and the issue has been reported to the author for a long time now! No response from the original author.

I think it's pretty terrible that support is nonexistent for plugins with such high price tags.
I encourage you to make your feelings known via the respective review sections and try to get a refund or chargeback.

https://i.imgur.com/Acr4oH0.png

Anyone know of an alternative plugin for adjusting attack speeds per item? That's all i really need mcombat for anyway..

Turns out I had an outdated MCombat version, the errors with the latest version are fixed in luckperms .18

I'm running the latest version of LuckPerms and MCombat and am still getting this issue.

@Miclebrick Could you reopen this? Still getting this issue on latest version.

Alright, will do.


add vulnerability certifier

Signed-off-by: pxp928<EMAIL_ADDRESS>Adds vulnerability certifier interface that allows for other certifiers to be pluggable. Currently added OSV support.
The certifier asynchronously queries the graph DB recursively for artifacts to scan. It passes these to the certifiers asynchronously to scan for vulnerabilities and generates vulnerability attestations. The generated attestations are passed asynchronously to the emitter to be ingested.
Currently, we are missing integration testing for the certifier as it needs to query a graph DB for artifacts.
Added internal OSV_query package until the upstream https://github.com/google/osv-scanner/blob/main/internal/osv/osv.go becomes public or another method is used.
ReadQuery is a modified version of ReadQueryForTesting for this use case but this will be replaced once we refactor graph DB functions and API are generated.
Part of Issue https://github.com/guacsec/guac/issues/222

So overall I like the approach. My only major concern is it being unclear how the graphdb stuff works with a bunch of this all parallelized. However, I'm not a neo4j expert here.

created Issue https://github.com/guacsec/guac/issues/254 to track adding tests


Fix Typo in Log Output

Thanks for spotting it and for sending the PR. It's integreated.

Thanks for spotting it and for sending the PR. It's integreated.

Thanks for all your work, much appreciated!

Thanks for all your work, much appreciated!

I'm glad I could help. Stay tuned for more.

I'm glad I could help. Stay tuned for more.


Feature Request: Adaptive Suggestions

VSCode Version: Code 1.13.0 (376c52b955428d205459bea6619fc161fc8faacf, 2017-06-08T16:43:13.058Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: the listing length exceeds browsers' URL characters limit

It would be nice if the suggestions for a file or language would come up with a sorted list where the most used partial match would end up at the top of the list.
Simple example, when you type req in a js file, eventually requestAnimationFrame will be at the top, most likely you want require there if you work in nodejs.

dupe of #22839


Remove Google Analytics "Audience Stats by Country and City" default report

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1926
Originally created by @DouweM on 2020-03-26 23:01:48

View 4 previous comments from the original issue on GitLab


Document part of bevy_ecs::Commands

Here is a first pass at adding some clarification to Commands, which is a type that most folks need to use and can sometimes be confusing. This is not meant to be a "final draft" but are intended just to help answer some common questions for new users before bevy has more thorough docs.
I've specifically tried to address which methods should be called with bundles vs single components. This changeset renames some usages of components to bundle.
I'd also like to document the following, but need some further guidance for:

insert_local_resource: I'm unsure what SystemId is in relation to Resources (is it just like a namespace for archetypes?)
despawn: I'd like to clarify what "other considerations" the existing comment is referring to (currently documented as: Despawns only the specified entity, ignoring any other consideration.)

for despawn, I think the "considerations" are about hierarchy. despawn will just despawn the entity, not its children, unlike despawn_recursive

insert_local_resource: I'm unsure what SystemId is in relation to Resources (is it just like a namespace for archetypes?)

"local resources" are resources created for a specific system. SystemId is a unique identifier for a system.

despawn: I'd like to clarify what "other considerations" the existing comment is referring to (currently documented as: Despawns only the specified entity, ignoring any other consideration.)

I'm guessing the author intended "other considerations" to be "children" (to contrast with the despawn_recursive command). I personally think we should just cut out that phrasing. We should just describe what despawning a specified entity does. We don't need to care about describing what it doesn't do.

Since latest rust version you can use easy intra doc links: https://doc.rust-lang.org/stable/rustdoc/linking-to-items-by-name.html
Could you link all items that make sense? (like the "See something")

It may be worth adding #![deny(broken_intra_doc_links)] whenever #![warn(missing_docs)] is considered to be added.


Images in gallery mode jump around

https://user-images.githubusercontent.com/108767/200642317-eb01d699-d007-43c8-9337-e638e2f7be4a.mp4

my $0.02... I've seen this happen when the client can't access the noimage.png file.

Tina says this happens all the time


Enable syntax highlighting for code snippets. Fix minor typos.

Thx @johnjohndoe

You are welcome. :-}


Adding undersores for class dict instances

First of hopefully two pull requests to address the issue in #486.
This changes the generation function for class instance dicts.
Class instances
class MyClass a b c where

instance MyClass Tt Aa b where
instance MyClass Tt A ab where

Would previously both result in the instance dict named $fMyClassTtAab.
To reduce name clashes and make instances more readable we introduce a _ as separator for individual type arguments resulting in the two dicts $fMyClass_Tt_Aa_b and $fMyClass_Tt_A_ab.
Dicussion
Considering that we need further changes to address the case-sensitivity issue do we want to escape literal _?
Aka should
MyClass T_t be $fMyClass_T_t (no escaping)
or
MyClass T_t be $fMyClass_T__t (_ escaped to __)?

The build failed with this:
java.lang.NoSuchMethodException: base.java.Exception.$fExceptionJException()
	at java.lang.Class.getMethod(Class.java:1786)
	at eta.runtime.stg.Closures.loadClosure(Closures.java:63)
	at eta.runtime.stg.Closures.<clinit>(Closures.java:50)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at Verify.main(Verify.java:39)

Can you also change eta.runtime.stg.Closures to reference $fException_JException instead of $fExceptionJException? Also run tests/verify/verify.sh to ensure that this change works.

And please do escaping because _ is an artifact of the encoding we're doing and _ itself should be able to be distinguished from the separator _.

Okay, interesting. For me this morning for some reason the build worked and also the verify script. It didn't a few days back when I tried it. I suppose something is wrong with my test setup, I'll have to figure that out.
I also considered some kind of encoding for parentheses, but I couldn't think of one that I would have deemed readable.

You can run ./cleaninstall.sh to ensure that the old version is cleanly removed. Another issue may be if you did the binary installation first, in which case etlas would be using your downloaded binary and not the source installed eta.
Yup, as I said, nothing to worry about (in regards to the parenthesis).

Hey @JustusAdam, let me know if you have time to fix the naming change in the runtime as well. If not, I'll merge this and immediately push the fix.

Oh if you want you can fix it. In fact you can fix it on this branch. I have enabled allow edits from maintainers so you should be able to push directly into this PR.
I might get around to fixing it today but I am not sure.

Merged, thanks for bringing this in!


VG-4028: Grey out Processing tasks when not available

Can one of the admins verify this patch?

Current coverage is 72.05%

Merging #28 into master will decrease coverage by -0.04% as of 151a2e6

@@            master     #28   diff @@
======================================
  Files          111     111
  Stmts         7052    7042    -10
  Branches      1005    1003     -2
  Methods          0       0
======================================
- Hit           5084    5074    -10
+ Partial        527     524     -3
- Missed        1441    1444     +3

Review entire Coverage Diff as of 151a2e6

Uncovered Suggestions

+0.20% via ...ters/tree-service.js#103...116
+0.13% via ...-scroll-directive.js#151...159
+0.13% via ...ters/tree-service.js#285...293
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Include additional files

Reason/Context
We have a workflow that runs some pre-commit checks, this requires an additional file in the root of each repo.
Description
This could be implemented by adding a files_to_include option which would allow supplementary files to be included.

@ChipWolf hey, interesting feature! so how would it work? files_to_include? each file is picked, it the order it is added to the list and invoked? or? would it be a script file or what exactly?
or....wait, you mean make this workflow support more than .github/workflows located files?


Autopairs doesnot work after I update Neovim to version 0.7.0

Description
I cannot get autopairs working after updating Neovim to version 0.7.0.
No error messages. It just doesn't work.
Minimal config
-- Setup function
require("nvim-autopairs").setup() -- very very simple

Experimenting a similar situation, I might detail a little more. In my case, with neovim 0.7, fastwrap works properly and autopairs works  for [], {} and ``, but do not work for "", '' and (). The imapcommand confirm there is proper mappings for all pairs, and no rules have been set in my configuration. When I roll back to neovim 0.6 with the same configuration, autopairs works perfectly fine again.

I have the same issue, but I do have some pairing working (just single quotes and square brackets)
However, if I launch neovim in any vterm (tmux, composer in aerc), all of the pairing works like normal.

For me, it's happening with foot terminal, but not kitty. Probably a neovim issue with fixterm encoding and not an issue of nvim-neopairs. (I have also tried another pair plugin and had the same issue).
https://gpanders.com/blog/whats-new-in-neovim-0-7/

For me, it's happening with foot terminal, but not kitty. Probably a neovim issue with fixterm encoding and not an issue of nvim-neopairs. (I have also tried another pair plugin and had the same issue).
https://gpanders.com/blog/whats-new-in-neovim-0-7/

Thank you for your nice answer. I temporarily switch to alacritty now and it's working.

This is problem of fixterm encoding on foot terminal. Not nvim-autopairs.

This should be fixed on latest master of foot.

By the way, so much appreciation for everybody's word (foot termial, autopairs and neovim). Thank you so much for those great tools!


fix BufferedProducerIdleCompleteCore 0xc0000409 - The system detected an overrun of a stack-based buffer in this application.

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Add forceSet option for collection

Ignores maxSize
collection.set('292892', {name: 'test'}, {forceSet: true})

Elaborate when this would be used

For instance the member collection can be capped to 0. During allowing to save just the bot guild member...
Or when you fetch something and want to keep it for further processing...

For the 1st there will be a cache update which improves that behaviour.
For the 2nd I'm not sure why you would use a maxed collection for that?

When you usually do not want to cache the resource type, but need it for some commands.


[Support]

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[x] The issue I am reporting can be is directly related to the pivpn installer script.
[x] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Issue
SSL expired
Have you searched for similar issues and solutions?
(yes/no / which issues?)

yes nothing found
Console output of      curl -L install.pivpn.io | bash

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (60) SSL certificate problem: certificate has expired
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
root@raspberrypi:/usr/share#

Console output of      pivpn add or pivpn add nopass
  Output Here

Console output of      pivpn debug
  Output Here

Have you taken any steps towards solving your issue?
  which?

The

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[x]  I have read and understood the contributors guide.
[x]  The issue I am reporting can be replicated.
[x]  The issue I am reporting can be is directly related to the pivpn installer script.
[x]  The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Issue
SSL expired
Have you searched for similar issues and solutions?
(yes/no / which issues?)

yes nothing found
Console output of curl -L install.pivpn.io | bash

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (60) SSL certificate problem: certificate has expired
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
root@raspberrypi:/usr/share#

Console output of pivpn add or pivpn add nopass
  Output Here

Console output of pivpn debug
  Output Here

Have you taken any steps towards solving your issue?
  which?

i updated the raspberry os and finally was able to do it.

los

Al plantear este problema, confirmo lo siguiente:
{please fill the checkboxes, e.g: [X]}

[x]   He leído y comprendido la guía para colaboradores .
[x]   El problema que estoy informando se puede reproducir .
[x]   El problema que estoy informando puede ser se relaciona directamente con el script de instalación pivpn.
[x]   El problema que estoy informando no es un duplicado (consulte Preguntas frecuentes , problemas cerrados y problemas abiertos ).

Asunto
SSL caducado
¿Ha buscado problemas y soluciones similares?
(yes/no / which issues?)

si nada encontrado
Salida de consola de curl -L install.pivpn.io | bash

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (60) SSL certificate problem: certificate has expired
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
root@raspberrypi:/usr/share#

Salida de consola de pivpn addopivpn add nopass
  Output Here

Salida de consola de pivpn debug
  Output Here

¿Ha tomado alguna medida para resolver su problema?
  which?


Added Common Log Format output

Add an option to select between Common Log Format and Extended Log Format.
By default Extended Log Format is chosen for backwards compatibility.
Note. Tabs are changed by spaces to follow PEP8 recommendations
https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

nice.. thanks


Static manifests don't include CRDs

Describe the bug:
There are no CustomResourceDefinitions for the static manifests.
Expected behaviour:
I expect when deploying the static manifests to my Kubernetes cluster to not encounter an error, but I receive this error
unable to recognize "STDIN": no matches for certmanager.k8s.io/, Kind=Issuer
unable to recognize "STDIN": no matches for certmanager.k8s.io/, Kind=ClusterIssuer
unable to recognize "STDIN": no matches for certmanager.k8s.io/, Kind=Certificate
unable to recognize "STDIN": no matches for certmanager.k8s.io/, Kind=ClusterIssuer
unable to recognize "STDIN": no matches for certmanager.k8s.io/, Kind=Certificate

Steps to reproduce the bug:
Deploy using the static manifests located here.
Anything else we need to know?:
N/A
Environment details::

Kubernetes version: 1.10.0
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): kops AWS
cert-manager version (e.g. v0.4.0): 0.5.2
Install method (e.g. helm or static manifests): static manifests

/kind bug

Hm, which manifests are you applying? I can see the CRDs defined here: https://github.com/jetstack/cert-manager/blob/master/contrib/manifests/cert-manager/with-rbac.yaml#L25-L124

I think they are only defined in with-rbac.yaml and without-rbac.yaml, but not in the other 2 static manifests.
The documentation doesn't make clear what exactly each of these static manifests are, so I could be using the incorrect manifest.


When searching for versions, try with and without a "v" prepended.

Here I tried to install micro-editor:
$ stew install<EMAIL_ADDRESS>zyedidia/micro
! Could not find a release with the tag 2.0.14 - please select a release:  [Use arrows to move, type to filter]
> nightly
  v2.0.14
  v2.0.14-rc1
  v2.0.13
  v2.0.12
  v2.0.11
  v2.0.10

Of course, 2.0.14 is right there, but they tagged it with a v and I didn't use that.

I understand why you'd want this, but I'd rather keep the tag matching as is. It's more predictable and explicit the way it is now. Also, consider that sometimes tags aren't even versions, they're actual words.


Include .js in import statements for the browser

Hello!
Would it be possible to add the .js extention to the statement
import isPromise from './isPromise';

in dist/es/index.js? browsers need an absolute path to a file in order to resolve modules. If this change were made, browsers could import this module without any build step.

Hi! Yes, it would make sense to include the .js extension. Feel free to make a PR implementing this.


[AutoPR datamigration/resource-manager] Fix Version value to fix Ruby SDK Generation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/4400

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/3747


Migrate gradle plugin to version 3

Fix WARNING:
Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
Quick Reference:

https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html

Close because dupplicate with PR #24


TCK: Receptacle#expectError timeout approach

Motivation:
defaultTimeoutMillis is typically used as a "max time to wait until an expected event occurs". For example this value is used as the argument to a ArrayBlockingQueue#poll(timeout) [1][2][3] method call and therefore when things work as expected you rarely wait this full duration. However Receptacle#expectError does a Thread.sleep(..) and then checks if there is something present in the error list (which is a CopyOnWriteArrayList). The value for the sleep is typically derived from defaultTimeoutMillis which leads to unconditional delays. This makes it challenging to use defaultTimeoutMillis in tests to specify "maximum amount of time to wait until some event occurs". The impacts are if defaultTimeoutMillis is set very small you are more likely to see timeouts (especially on over utilized CI servers), but if defaultTimeoutMillis the tests take a long time to complete.
[1] https://github.com/reactive-streams/reactive-streams-jvm/blob/master/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java#L1019
[2] https://github.com/reactive-streams/reactive-streams-jvm/blob/master/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java#L978
[3] https://github.com/reactive-streams/reactive-streams-jvm/blob/master/tck/src/main/java/org/reactivestreams/tck/TestEnvironment.java#L990
Modifications:

TestEnvironment now supports an additional poll timeout parameter to be used
when there is no explicit async event to trigger off of.

Result:
TestEnvironment's defaultTimeoutMillis can be used as "max time until some event
occurs" where defaultPollTimeoutMillis provides the polling interval to check
for an event if there is no explicit async event to trigger off of.
Fixes https://github.com/reactive-streams/reactive-streams-jvm/issues/451

I have updated the CopyrightWaiver.txt as part of https://github.com/reactive-streams/reactive-streams-jvm/pull/450

Thanks Scott! Seems I'll be able to review this, yay! I'll give it a look now 👍

Thanks for opening this PR @Scottmitch!
@reactive-streams/contributors Please chime in!

The new config has to be able to be configured from the env variables, as some people rely on those -- commented in line how to do it.
And the param has to be documented as well in the tck/README.md
Note that the TCK differentiates between timeouts for "waiting for a signal" (`defaultTimeoutMillis`),
and "asserting no signals happen during a given amount of time" (`defaultNoSignalsTimeoutMillis`).
While the latter defaults to the prior, it may be useful to tweak them independently when running on continuous integration servers (for example, keeping the no-signals timeout significantly lower).

In order to configure these timeouts (for example when running on a slow continuous integration machine), you can either:

**Use env variables** to set these timeouts, in which case the you can do:

    export DEFAULT_TIMEOUT_MILLIS=100
    export DEFAULT_NO_SIGNALS_TIMEOUT_MILLIS=100
    export DEFAULT_POLL_TIMEOUT_MILLIS=20
    export PUBLISHER_REFERENCE_GC_TIMEOUT_MILLIS=300

Along the way there's some typos there we could fix (the above text should be fine to copy verbatim if you like it @Scottmitch :)
Sadly we have the readme in two places, since JDK and RS versions, so this would also have to be done in: https://github.com/reactive-streams/reactive-streams-jvm/tree/master/tck-flow/README.md

thanks for review @ktoso and @viktorklang! Any other comments, or can this be merged?

Looks good as I said above here. Ping @viktorklang. Sadly I never got merge powers here... ¯_(ツ)_/¯

@Scottmitch Thanks for the great contribution!
@ktoso Thanks for helping out reviewing, Konrad! ^^
I'll investigate if we can give you merge-powers, it seems like an oversight.


game is blocked on school internet.

just make a github pages variant please.

@guzuv Thank you for your comment,
It seems like it must be the connected network that has the problem.
Also, the game is already served on GitHub pages using a custom domain.
If you get a specific error, or you're using a unique/old browser, let me know. I'd be happy to fix it

yeah, could you make a clone connecting to your servers with parking-master.github.io/FPS2? lots of firewalls don't block a github.io site.

@guzuv I understand, so you would like a clone of the repo that points to a *.github.io domain, instead of redirecting to www.fps2.ml

On Mon, Oct 31, 2022 at 11:16 AM Parking Master @.***>
wrote:

@guzuv https://github.com/guzuv I understand, so you would like a clone
of the repo that points to a *.github.io http://github.io domain,
instead of redirecting to www.fps2.ml http://www.fps2.ml
—
Reply to this email directly, view it on GitHub
https://github.com/Parking-Master/FPS2/issues/1#issuecomment-1297245787,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2MQOUUOAUGIITJVO3PSSPLWF7PFTANCNFSM6AAAAAARQKFGKA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, that’s what I was thinking. I made a fork, but I want you to make an
“official” version.

@guzuv Ok, I'll work on it.

Ok, I've completed your request. You can use https://parking-master.github.io/FPS2-Clone instead of www.fps2.ml


Multi-tab editor

Main ideas:

This would automatically implement #21
Tabs would open when double-clicking an xml part, unlike now that they open on a single click

Collapsing the tree items of a part (i.e. its icons) should no longer happen on double click

Automatic saving of tabs (JetBrains-style) or save on demand?

If saving each tab on demand, tool should distinguish between this and saving the entire document. What action should Ctrl-S do then? What should happen when you close the document or the application without saving? Should it ask you whether you want to save each tab individually?
Given there will be a proper undo history per tab, an automatic save seems like a better idea

There could also be a tab for viewing an icon inserted, perhaps with pan / zoom controls and some file info (resolution, image format, file size, etc.)
What to do with the results control (for find results / XML validation errors) at the bottom?

Keep having a single control common to all tabs: the control should be aware of which tab launched it, and have the ability to re-open it if it was already closed
Have an independent tab for each results control needed: this seems a bit of an overkill. Not even Visual Studio does that for find results
Keep one control per tab: this might be the easiest thing to do, with users clearly knowing which tab triggered the results (the one they are looking at)

What should the tab title say?

If only showing the part name, you can easily end up with duplicates as soon as you open more than one document
If showing both file and part names, titles could be long
Intermediate approach, similarly to how IDEs resolve this:

When there is only one tab with that part name, show just that
When there is more than one, show also the file name
If there are still duplicates, show also the path

Also, check how viable it would be to highlight the part in the tree view that corresponds to the open tab
Maybe just temporarily, as soon as you have the focus on that tab
There could also be a find in tree view kind of manual action which would select the part there

When a document is closed, the associated tabs should obviously close as well
The selected item in the tree view should still be what decides which actions are available. This should be more intuitive than the currently focused editor deciding it

Actually, only for some actions such as inserting an icon. For purely code-related actions (validate XML, generate callbacks, etc.), it makes more sense if they are focused on the currently viewed tab

Fixed by #58. Some things might need to be polished but these can have their own issues.


API Explorer loses filter state on navigation

Expected Behavior
When configuring a filter in the API explorer, then navigating to an entity, and then back to the API explorer with the browser history, the filter state should be restored. The filter parameters are added to the URL and kept in the browser history.

Current Behavior
Filters are not restored, they aren't added to the URL anymore.

Possible Solution
Store filters in the URL.

Steps to Reproduce

Navigate to the API explorer
Select a filter, e.g. an owner
Click on one of the entities
Use the browser history to navigate back to the API explorer
Filter for owner should still be set

Context
There were some recent changes to the API explorer, I guess it was broken by them (#5984).
Your Environment

Current master

NodeJS Version (v12):
Operating System and Version (e.g. Ubuntu 14.04):
Browser Information:

@kunagp for visibility, also @timbonicus is this something that we have a solution for in the catalog page that we can help move across to here?

Nothing in place on the catalog page at the moment, I made a draft PR #6140 to show how it might be fixed. 🤔 In case anyone wants to pick this up.

@timbonicus took the opportunity to pick up where you left off in your draft, thanks for getting it started!


Enable PDF (.pdf) preview toggle breaks either explorer preview --OR-- outlook preview

Microsoft PowerToys version
0.56.2
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Hours with IT on my work PC:
When I turn Power Toys >> File Explorer Add-ons >> Enable PDF (.pdf) preview >> toggle to "On", the preview window in OUTLOOK says "this file cannot be previewed because there is no previewer installed for it." but I am able to view PDFs in Explorer preview window.
When I turn Power Toys >> File Explorer Add-ons >> Enable PDF (.pdf) preview >> toggle to "OFF", the preview window in OUTLOOK displays the PDF but the preview window Explorer for PDFs preview window says "File Not Found.  It may have been moved or edited"
Toggle back and forth and the problem moves from Outlook to Explorer.  Exclusive NOR.  One or the other can function as intended, not both.
All windows updates are executed.  all power toys updates are in place from general tab.  V0.56.2 last checked 3/9/2022 1:09:14 PM
✔ Expected Behavior
previews to work
❌ Actual Behavior
toggle breaks either outlook or explorer depending on position.
Other Software
outlook and windows explorer

cc: @Aaron-Junker fyi.

/dup #14283

Here's an official helparticle to this topic: https://support.microsoft.com/en-gb/office/outlook-pdf-preview-error-this-file-cannot-be-previewed-because-there-is-no-previewer-installed-for-it-b78bfe24-ba13-44bd-8289-1919ece7ded2


web server

quick module editing, maybe server monitoring, player management, etc

kotlin react maybe

Vue + Node with a socket to the server software would be a good system

never used vue but I might use this as an excuse to check it out lol


Vuejs

Please provide a frontend in Vuejs

hi @pperliti, we are planning on adding a vue sample. I'll update this issue once we have it ready :)


chopping a ZIP file into fragments

Since ZIP allow data splitting, take a look at https://kb.winzip.com/help/winzip/help_splitdlg.htm
Imagine a tweet thread with split files

This project should already work with split zip files.

Clarification on https://github.com/DavidBuchanan314/tweetable-polyglot-png#embedded-file-requirements
Sinde it does not hint at the use of the split function when creating the image, maybe I read that wrong.

Are you suggesting an update to the readme? How would you phrase it differently?

"If the embedded file is a .zip, then the offsets are automatically adjusted so that the overall file is still a valid zip."
This can be interpreted as a partial file, which does not quite make sense. Maybe:
"If the embedded file is a .zip, then it will be divided into partial zip files, each stored in a separate image."

Oh, that's not the current behavior. Zipping files is out-of-scope of this project, it just packs pre-zipped files. How those files are zipped is entirely up to the end-user.

I like this feature
Sent from my iPhone
On 22 Mar 2021, at 1:44 pm, BrandonKMLee @.***> wrote:

"If the embedded file is a .zip, then the offsets are automatically adjusted so that the overall file is still a valid zip."
This can be interpreted as a partial file, which does not quite make sense. Maybe:
"If the embedded file is a .zip, then it will be divided into partial zip files, each stored in a separate image."
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDavidBuchanan314%2Ftweetable-polyglot-png%2Fissues%2F3%23issuecomment-803778079&data=04|01||0b7f4000b0f3416f2e9f08d8ecf581cf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637519886475281489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xHFJi1oUi%2B6QTUnio%2FVM%2FZR15e%2FflRxurQ5ds8FOGcU%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATKP4FBVMURTSFAS2HYWNSDTE3KKLANCNFSM4ZRBNL3A&data=04|01||0b7f4000b0f3416f2e9f08d8ecf581cf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637519886475291490|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PM82Q3NBjBwNKSf96pS9KN1xCmgpCHIycDHCsudJq3I%3D&reserved=0.

Is bit torrent any good ??
Sent from my iPhone
On 22 Mar 2021, at 2:29 pm, luke graham @.***> wrote:
 I like this feature
Sent from my iPhone
On 22 Mar 2021, at 1:44 pm, BrandonKMLee @.***> wrote:

"If the embedded file is a .zip, then the offsets are automatically adjusted so that the overall file is still a valid zip."
This can be interpreted as a partial file, which does not quite make sense. Maybe:
"If the embedded file is a .zip, then it will be divided into partial zip files, each stored in a separate image."
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDavidBuchanan314%2Ftweetable-polyglot-png%2Fissues%2F3%23issuecomment-803778079&data=04|01||0b7f4000b0f3416f2e9f08d8ecf581cf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637519886475281489|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=xHFJi1oUi%2B6QTUnio%2FVM%2FZR15e%2FflRxurQ5ds8FOGcU%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATKP4FBVMURTSFAS2HYWNSDTE3KKLANCNFSM4ZRBNL3A&data=04|01||0b7f4000b0f3416f2e9f08d8ecf581cf|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637519886475291490|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PM82Q3NBjBwNKSf96pS9KN1xCmgpCHIycDHCsudJq3I%3D&reserved=0.


quic: add peer_transport_params()

Currently, transport parameters are available through stats(). APIs that used to offer access to certain transport parameters have been removed in favor of using stats(). While this does work, it's wasteful to return such a large structure when you may only care about a single TP. This change makes TransportParameters public, adds a method peer_transport_params() that returns a reference, and removes transport parameter fields from Stats.

Merged (with some small fixes), thanks @ehaydenr!


strictModuleExceptionHandling missing in documentation of webpack 2

strictModuleExceptionHandling missing in documentation of webpack 2

Can you move this to the doc site tracker with more context?


python312Packages.open-clip-torch: 2.27.1 -> 2.28.0

Things done
Changelog: https://github.com/mlfoundations/open_clip/releases/tag/v2.28.0
cc @iynaix

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 350420

x86_64-linux

:white_check_mark: 6 packages built:

python311Packages.open-clip-torch
python311Packages.open-clip-torch.dist
python312Packages.open-clip-torch
python312Packages.open-clip-torch.dist
rclip
rclip.dist

aarch64-linux

:white_check_mark: 6 packages built:

python311Packages.open-clip-torch
python311Packages.open-clip-torch.dist
python312Packages.open-clip-torch
python312Packages.open-clip-torch.dist
rclip
rclip.dist

x86_64-darwin

:fast_forward: 6 packages marked as broken and skipped:

python311Packages.open-clip-torch
python311Packages.open-clip-torch.dist
python312Packages.open-clip-torch
python312Packages.open-clip-torch.dist
rclip
rclip.dist

aarch64-darwin

:white_check_mark: 6 packages built:

python311Packages.open-clip-torch
python311Packages.open-clip-torch.dist
python312Packages.open-clip-torch
python312Packages.open-clip-torch.dist
rclip
rclip.dist


feat: Connext Amarok

Motivation
Integrate Connext Amarok into Nomad BridgeRouter to enable native fast liquidity.
Solution

PR Checklist

[ ] Added Tests
[ ] Updated Documentation
[ ] Updated CHANGELOG.md for the appropriate package

We should definetely add tests before merging this

@anna-carroll if you want to decrease the CI speed, you can rebase onto master

To make review easier, please remove format-only changes to BridgeToken, TokenRegistry, and BridgeMessage. What caused these? These changes aren't made with a local prettier run

To make review easier, please remove format-only changes to BridgeToken, TokenRegistry, and BridgeMessage. What caused these? These changes aren't made with a local prettier run

They were caused by running prettier on my machine

We need to update documentation to reflect the inclusion of this feature

We need to update documentation to reflect the inclusion of this feature

issue on docs repo?

We need to update documentation to reflect the inclusion of this feature

issue on docs repo?

i think the docs repo is no longer the source of changes for docs - docs now live in gitbook. will escalate convo to slack


rename nosshkeys to nokeys, part 1

This part is about adding the new build image "nokeys".  After we change the jenkins process to  build "nokeys", we will remove the build image "nosshkeys".

I'm not sure why the tests didn't run automatically. I'm going to close then reopen the PR to see if this gets things going.

This might be a clue. In the action on your fork (https://github.com/NerdLogic/vertica-kubernetes/actions/runs/4494004180). I see this error:

Invalid workflow file: .github/workflows/e2e.yml#L1
you may only define up to 10 inputs for a workflow_dispatch event

We may need to temporarily steal a parameter. You can safely remove security_scan_exit_code for now, then add it back when the nosshkeys_vertica_image parm is removed.