Some games launch in floating mode instead of fullscreen

Bug or Regression?
Regression
System Info and Version
 System/Version info
<Hyprland, built from branch  at commit 9e781040d9067c2711ec2e9f5b47b76ef70762b3  (props: bump version to 0.41.1).
Date: Thu Jun 13 09:54:06 2024
Tag: v0.41.1, commits: 4818

flags: (if any)

System Information:
System name: Linux
Node name: arch
Release: 6.9.5-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:37 +0000

GPU information:
2b:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M] [1002:73ff] (rev c7) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

======Config-Start======

Config File: /home/theodor/.config/hypr/hyprland.conf: Read Succeeded
# Some default env vars.
env = XCURSOR_SIZE,24
env = XDG_CURRENT_DESKTOP,hyprland
env = QT_QPA_PLATFORM,WAYLAND
env = QT_QPA_PLATFORMTHEME,qt6ct
env = XDG_SESSION_TYPE,wayland
#env = SDL_VIDEODRIVER,wayland

# autostart
exec-once=dbus-update-activation-environment --systemd WAYLAND_DISPLAY
exec-once=firefox
exec=telegram-desktop
exec-once=thunderbird
exec=$HOME/.config/waybar/launch.sh
exec-once=sed -i 's/offset = 10x30/offset = 10x10/g' ~/.config/dunst/dunstrc && dunst
exec-once=swaybg.sh
exec=easyeffects --gapplication-service
exec-once=/usr/lib/polkit-gnome/polkit-gnome-authentication-agent-1
exec-once=automount.sh
exec-once=wl-paste --watch cliphist store

# window rules
windowrulev2 = workspace 1,class:(firefox)
windowrulev2 = workspace 2,silent,class:(org.telegram.desktop)
windowrulev2 = workspace 3,class:(pcsx2-qt)
windowrulev2 = workspace 3,silent,class:(steam)
windowrulev2 = workspace 3,class:(org.libretro.RetroArch)
windowrulev2 = workspace 4 silent,class:(thunderbird)
windowrulev2 = workspace 5,class:(com.transmissionbt.transmission_2066_12218468)
windowrulev2 = workspace 5,class:(transmission-gtk)
windowrulev2 = workspace 6,class:(Gimp-2.10)
windowrulev2 = float,class:(flameshot)
windowrulev2 = float,class:(galculator)
windowrulev2 = fullscreen,class:(Rusted Warfare)

# appearance
exec=gsettings set org.gnome.desktop.interface gtk-theme 'Gruvbox-Material-Dark'
exec=gsettings set org.gnome.desktop.interface icon-theme 'Papirus-Dark'
exec=gsettings set org.gnome.desktop.interface cursor-theme 'Adwaita'
exec=gsettings set org.gnome.desktop.interface font-name 'Noto Sans Regular 10'

# main settings
monitor=,preferred,auto,auto

general {
    gaps_in = 3
    gaps_out = 3
    border_size = 1
    col.active_border = rgba(c2af8dee) 45deg
    col.inactive_border = rgba(665c54aa)

    layout = master
}

input {
    kb_layout = us,ru
    kb_variant =
    kb_model = pc104
    kb_options = grp:caps_toggle
    kb_rules =

    follow_mouse = 1
    repeat_rate = 20
    repeat_delay = 300

    touchpad {
        natural_scroll = no
    }

    sensitivity = 0 # -1.0 - 1.0, 0 means no modification.
}

misc {
    disable_hyprland_logo = true
    focus_on_activate = true
    force_default_wallpaper = 0
    disable_splash_rendering = true
    enable_swallow = true
    swallow_regex = kitty
    swallow_exception_regex = wev

}

decoration {
    rounding = 0
    blur {
    enabled = false
    size = 20
    passes = 1
    new_optimizations = true
    }
    drop_shadow = yes
    shadow_range = 4
    shadow_render_power = 3
    col.shadow = rgba(1a1a1aee)
}

animations {
    enabled = 0

    bezier = myBezier, 0.05, 0.1, 0.1, 1.05

    animation = windows, 1, 2, myBezier
    animation = windowsOut, 1, 2, default, popin 80%
    animation = border, 1, 2, default
    animation = borderangle, 1, 2, default
    animation = fade, 1, 3, default
    animation = workspaces, 1, 2, default
}

master {
    #new_status = master
    new_is_master = true
    mfact = 0.55
    new_on_top = true
    no_gaps_when_only = 0
    orientation = left
    always_center_master = true
}

gestures {
    workspace_swipe = off
}

# binds
$mainMod = SUPER

bind = $mainMod, return, exec, kitty
bind = $mainMod SHIFT, return, layoutmsg, swapwithmaster
bind = $mainMod, Q, killactive
bind = $mainMod SHIFT, Q, exec, killactive.sh
bind = $mainMod, E, exec,rofi -show emoji -modi emoji
bind = $mainMod, D, exec, rofi -show drun
bind = $mainMod, X, exec, rofi -modi clipboard:$HOME/.local/bin/cliphist-rofi -show clipboard
bind = Control, delete, exec, dunstctl close-all
bind = Control, insert, exec, dunstctl history-pop
bind = Control, backslash, exec, dunstify -u low $(curl 'wttr.in?format=1')
bind = Control_ALT, r, exec, systemctl reboot
bind = Control_ALT, s, exec, suspend.sh
bind = Control_ALT, p, exec, systemctl poweroff
bind = $mainMod, S, togglefloating,
bind = $mainMod, P, pseudo, # dwindle
bind = $mainMod, J, togglesplit, # dwindle
bind = Control ALT, Down, exec, playerctl play-pause
bind = Control ALT, Right, exec, playerctl next
bind = Control ALT, Left, exec, playerctl previous
bind = $mainMod SHIFT,E,exit
bind = $mainMod SHIFT,R,exec,hyprctl reload
bind = $mainMod,F,fullscreen
bind = $mainMod SHIFT, F, fakefullscreen
bind = $mainMod,F1,exec,firefox
bind = $mainMod,F2,exec,telegram-desktop
bind = $mainMod,F3,exec,steam
bind = $mainMod,F4,exec,crow
bind = $mainMod,F5,exec,thunderbird
bind = $mainMod,F6,exec,galculator
bind = $mainMod,F7,exec,kitty -e btop
bind = ,Print,exec,flameshot screen
bind = SHIFT,Print,exec,flameshot gui
#bind = ,Print,exec,grim ~/Pictures/screenshots/screen-"$(date +%s)".png
#bind = SHIFT,Print,exec,grim -g "$(slurp)" ~/Pictures/screenshots/screen-"$(date +%s)".png
#bind = $mainMod,Print,exec,grim -g "$(slurp -p)" -t ppm - | convert - -format '%[pixel:p{0,0}]' txt:- | tail -n 1 | cut -d ' ' -f 4 | wl-copy
bind = $mainMod,A,layoutmsg,addmaster
bind = $mainMod,R,layoutmsg,removemaster

binde = CTRL,right,exec,changevolume.sh 5%+
binde = CTRL,left,exec,changevolume.sh 5%-
bind = CTRL,m,exec,changevolume.sh mute
bind = CTRL,u,exec,changevolume.sh unmute

# Move focus through list of windows
bind = $mainMod, up, layoutmsg, cyclenext
bind = $mainMod, down, layoutmsg, cycleprev
bind = $mainMod SHIFT, up, layoutmsg, swapnext
bind = $mainMod SHIFT, down, layoutmsg, swapprev

# chandge layout orientation
bind = $mainMod, grave, layoutmsg, orientationcycle left right bottom top

# Switch workspaces with mainMod + [0-9]
bind = $mainMod, 1, workspace, 1
bind = $mainMod, 2, workspace, 2
bind = $mainMod, 3, workspace, 3
bind = $mainMod, 4, workspace, 4
bind = $mainMod, 5, workspace, 5
bind = $mainMod, 6, workspace, 6
bind = $mainMod, 7, workspace, 7
bind = $mainMod, 8, workspace, 8
bind = $mainMod, 9, workspace, 9
bind = $mainMod, 0, workspace, 10

# Move active window to a workspace with mainMod + SHIFT + [0-9]
bind = $mainMod SHIFT, 1, movetoworkspacesilent, 1
bind = $mainMod SHIFT, 2, movetoworkspacesilent, 2
bind = $mainMod SHIFT, 3, movetoworkspacesilent, 3
bind = $mainMod SHIFT, 4, movetoworkspacesilent, 4
bind = $mainMod SHIFT, 5, movetoworkspacesilent, 5
bind = $mainMod SHIFT, 6, movetoworkspacesilent, 6
bind = $mainMod SHIFT, 7, movetoworkspacesilent, 7
bind = $mainMod SHIFT, 8, movetoworkspacesilent, 8
bind = $mainMod SHIFT, 9, movetoworkspacesilent, 9
bind = $mainMod SHIFT, 0, movetoworkspacesilent, 10

# Scroll through existing workspaces with mainMod + scroll
bind = $mainMod, mouse_down, workspace, e+1
bind = $mainMod, mouse_up, workspace, e-1

# Move/resize windows with mainMod + LMB/RMB and dragging
bindm = $mainMod, mouse:272, movewindow
bindm = $mainMod, mouse:273, resizewindow

# sets repeatable binds for resizing the active window
binde = $mainMod,right,resizeactive,50 0
binde = $mainMod,left,resizeactive,-50 0

======Config-End========>

Description
After updating to version 0.41, Hyprland began to ignore fullscreen requests from some games
https://github.com/hyprwm/Hyprland/assets/52626363/8385b632-791b-4876-8c0e-6086fae2dc18
How to reproduce
Just launch War Thunder (for example) on Steam
Crash reports, logs, images, videos
No response

For me it only seems to do this on initial launch. If the game has an in-game option to switch between fullscreen/windowed, it seems to work when toggled.

Of course this works if I press the shortcut to go to fullscreen but this should happen automatically

For me it only seems to do this on initial launch. If the game has an in-game option to switch between fullscreen/windowed, it seems to work when toggled.

Same here

Also noticing this behaviour, perhaps its because the laucher is initially floating

can't you just set a window rule

can't you just set a window rule

No, it has no effect from what I've tried, possibly due to this:

Also noticing this behaviour, perhaps its because the laucher is initially floating

I've noticed it's impossible to tile the launchers for some games, and that they share the same class and title as the game windoe itself

can't you just set a window rule

No, it has no effect from what I've tried, possibly due to this:

Also noticing this behaviour, perhaps its because the laucher is initially floating

I've noticed it's impossible to tile the launchers for some games, and that they share the same class and title as the game window itself

that's impossible window doesn't have any say in fullscreen window rules, specially if the fullscreen and maximize events have been supressed
what's the output of hyprctl clients and what window rule did you make?

What do you mean by fullscreen and maximise events being supressed?

windowrulev2=suppressevent maximize, class:^(firefox)$ for example to make sure the client isn't removing maximized state

Adding the suppressevent for maximize and fullscreen worked perfectly, thank you - I didn't realise those existed
@TAforever looks like the issue can be closed now

There is such a thing as a fullscreen request that some programs request to automatically launch in fullscreen, and until version 0.41 Hyprland correctly processed these requests. I have one game that does not send fullscreen requests even to Windows and for it I made a fullscreen rule, but here the error is on Hyprland’s side. Specifically for the game War Thunder, hyprctl clients does not even give out the class name so that I can make a fullscreen rule

There is such a thing as a fullscreen request that some programs request to automatically launch in fullscreen, and until version 0.41 Hyprland correctly processed these requests.

true and probably should be fixed, however since it's on xwayland I'd expect it to have a lower priority

Specifically for the game War Thunder, hyprctl clients does not even give out the class name so that I can make a fullscreen rule

i think this is reported somewhere, but can't find it atm

You should perform a bisect https://wiki.hyprland.org/Crashes-and-Bugs/#bisecting-an-issue

You should perform a bisect https://wiki.hyprland.org/Crashes-and-Bugs/#bisecting-an-issue

it was likely the xwayland rewrite

There is such a thing as a fullscreen request that some programs request to automatically launch in fullscreen, and until version 0.41 Hyprland correctly processed these requests.

true and probably should be fixed, however since it's on xwayland I'd expect it to have a lower priority

Specifically for the game War Thunder, hyprctl clients does not even give out the class name so that I can make a fullscreen rule

i think this is reported somewhere, but can't find it atm

Yes, I understand that a lot of work is being done now and my problem has a low priority

The problem is still relevant and I will add that when switching to a workspace with another XWayland client and returning back to the game, the previously launched game that did not switch to fullscreen mode on startup goes into full screen mode.

supressevent window rule if you want to

Guys, I think I've found a solution. It seems to me that the games still run in fullscreen, but the waybar remains visible. To avoid this, specify the bottom layer for the waybar in ~/.config/waybar/config.jsonc "layer": "bottom"

Uh that isn't the issue I was having? I had Waybar appear above windows in some cases way before having this

Guys, I think I've found a solution. It seems to me that the games still run in fullscreen, but the waybar remains visible. To avoid this, specify the bottom layer for the waybar in ~/.config/waybar/config.jsonc "layer": "bottom"

That is not a fix for this issue. It's just a workaround. You're changing the behavior of waybar to mask an actual bug. Also means if you actually want waybar above non-fullscreen windows you can no longer do that.
This weird fullscreen but not really issue started happening after the xwayland rewrite, so it is an actual bug that needs fixing.

That is not a fix for this issue. It's just a workaround. You're changing the behavior of waybar to mask an actual bug. Also means if you actually want waybar above non-fullscreen windows you can no longer do that.
This weird fullscreen but not really issue started happening after the xwayland rewrite, so it is an actual bug that needs fixing.

Yes, you're right, I didn't need to close the issue, hyprctl activewindow shows that the game is not in fullscreen


Fix #1074

This would fix #1074

Thanks for the contribution. Need to check first if there are some side-effects

Yes, side-effects are the main concern. 👍

No updates on this? :thinking:

Thanks again!


I couldn't find any documentation for this simple task.
I tried with click() over the control, but doesn't make the dropdown to display the options.
The selector is returning an OpenQA.Selenium.Remote.RemoteWebElement object.
thanks.

 And dropdowns are a lot trickier with Selenium than one might expect.
On your Page Object, you have a couple of methods for selecting items in a dropdown, either by value or by text:
Input.SelectByOptionValueInDropDown(x => x.RequiredEnum, value);
Input.SelectByOptionTextInDropDown(x => x.RequiredEnum, value);

You can see them both illustrated in our acceptance tests, on this page object:
https://github.com/TestStack/TestStack.Seleno/blob/master/src/TestStack.Seleno.AcceptanceTests/PageObjects/Form1Page.cs
And these two acceptance tests in this file:
https://github.com/TestStack/TestStack.Seleno/blob/master/src/TestStack.Seleno.AcceptanceTests/PageObjects/Controls/IndividualWritingTests.cs
Selecting_option_by_its_value_in_a_Drop_Down
Selecting_option_by_its_text_in_a_drop_down
Hope that helps.

Hi @mwhelan. thanks for your response.
I'm seeing in the test acceptance examples they're using strongly-typed page objects.
This is not my case. I just use weakly-typed ones and use Find.Element to look for controls by ID, name, etc.
I'm new to the repo. Is there an example there with weakly typed?
thanks.

Try using
HtmlControlFor<DropDown>("nameOfSelectElement").SelectElementByText("Name of option to select");
// or
HtmlControlFor<DropDown>("nameOfSelectElement").SelectElement(value);

Thank you @robdmoore
It worked pretty well.
It would be helpful that HtmlControlFor<> receives a selector instead of an Id, and work similar to Find.Element


[rancher-compose] docker-compose extends behaviour

rancher-server: v0.28-rc1
rancher-compose: v0.2.1
docker-compose: 1.3.2
The compose feature of docker supports extending of docker files. At the section about overriding configuration it states:

Compose copies configurations from the original service over to the local one, except for links and volumes_from.

Example 1
common.yml:
web:
  image: ubuntu:14:04

db:
  image: ubuntu:14:04

docker-compose.yml:
web:
  extends:
    file: common.yml
    service: web

db:
  extends:
    file: common.yml
    service: db
  links:
    - web:web

Command
rancher-compose create

I expected to see the link from db to web. However, there are no links at all.
Example 2
When adding the link to the common.yml file and removing it from the docker-compose.yml:
web:
  image: ubuntu:14:04

db:
  image: ubuntu:14:04
  links:
    - web:web

docker-compose.yml:
web:
  extends:
    file: common.yml
    service: web

db:
  extends:
    file: common.yml
    service: db

I expect to see no link. However, there is a link between db and web now. docker-compose even says the second example is invalid.
$ docker-compose up
Cannot extend service 'db' in <path>/common.yml: services with 'links' cannot be extended

@VogonogoV Thanks for the detailed issue!  I'll look at it now.

@VogonogoV This will be fixed shortly.  Thanks.  Do you want Example 2 to fail like docker-compose does?  I can easily make it work.

@ibuildthecloud Yes, I think it would make more sense to adopt the docker-compose behaviour. So, don't except links as in Example 2, and only use the links from the extending yml file. This would make the docker-compose files usable locally with docker-compose, and remote with rancher-compose.

@VogonogoV This has been fixed in v0.2.2 https://github.com/rancher/rancher-compose/releases/tag/v0.2.2 but I don't know if I did it exactly how you suggested, so I could change it.  Do you want example 2 to actually fail, or just silenty ignore the links.  I guess the safest approach could be to just do exactly what docker-compose does.  Right now I silently ignore links and volumes-from from the base config.  I could actually fail the same way as docker-compose.  Thoughts?

@ibuildthecloud Yes I would like to see example 2 fail. That would indeed be the safest approach and exactly what docker-compose does :) Thank you for the support!

Verified with build from master 752bc89. (Will be in v0.2.3)


Bump adafruit libs to latest version

Summary
Bump lib-all and lib to latest adafruit libs version.
How It Was Tested
Flashing ZeBadge...
Screenshot/Gif

Screenshot Name

@mariobodemann could you check this one?

That is quite a change! But for the libs it makes sense that this is the size. I'll need a bit more time to review it and check it on my ZeBadge.
Thanks so far for the contribution though... :heart:


(feature) Multiple config files

Requirements
Sometimes for security reasons, you want to have multiple configurations files to restrict access to some of them.

I'll reopen this one because it has been mentioned a couple of times when asking for feedback about the solution.


Update README.md

Fix typo/spelling mistake
Fixes 1.
Changes proposed in this pull request:

Fix typo/spelling mistake

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Client module functionality

Crud functionality for Client module

This task did not reach completion before the deadline. I will move this ticket to the 2024.04.2 Sprint.


Setting up permissions described procedure isn't complete

I setup permissions for collector directory and trace log location as described:
icacls "C:\temp\trace" /grant "IIS APPPOOL\DefaultAppPool":F
icacls "C:\Prog\IntelliTraceCollection" /grant "IIS APPPOOL\DefaultAppPool":RX
But when I run Start-IntelliTraceCollection it fails with bizarre error:
PS C:\temp>Start-IntelliTraceCollection -ApplicationPool DefaultAppPool -CollectionPlan C:\Prog\IntelliTraceCollection\collection_plan.ASP.NET.default.xml -OutputPath C:\temp\trace
Start-IntelliTraceCollection : The following application pool requires read and execute permissions for the IntelliTrace directory: "IIS APPPOOL\DefaultAppPool", "C:\WINDOWS\system32\WindowsPowerShell\v1.0".
It looks like cmdlet needs permissions on powershell folder ("C:\WINDOWS\system32\WindowsPowerShell\v1.0"). But why?
The problem is that it's not possible to change permissions for that folder. Add/Remove buttons are disabled in Permissions dialog. Probably it's because of the owner of this folder is TrustedInstaller. It seems to be wrong to change owner for powershell home folder to allow iTrace collectionn.
Env: Windows 10 Fall Creator Update, eng, PSVersion 5.1.16299.98, running under local admin user.
Please advice a workaround.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 995e3a2f-5674-63c4-5899-ba9a6b0e5da6
Version Independent ID: b93833ad-9195-96b4-6fac-8893836cde4e
Content: Using the IntelliTrace stand-alone collector | Microsoft Docs
Content Source: docs/debugger/using-the-intellitrace-stand-alone-collector.md
Service: unspecified
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

But even if I change owner of "C:\WINDOWS\system32\WindowsPowerShell\v1.0" to me and grant permissions for the folder to IIS APPPOOL\DefaultAppPool, the error won't gone!
Start-IntelliTraceCollection : The following application pool requires read and execute permissions for the IntelliTrace directory: "IIS APPPOOL\DefaultAppPool", "C:\WINDOWS\system32\WindowsPowerShell\v1.0".

@deborahc Deborah, could you advise on this? Thanks.

@evil-shrike Sorry for the slow response, evil.
It looks like you're having an issue with the product itself, rather than an issue with the documentation, which is what these GitHub issue are for. For options to report your product issue, consider using the following venues:

You can report product issues to us via the Report a Problem tool that appears both in the Visual Studio Installer and in the Visual Studio IDE.
You can track product issues in the Visual Studio Developer Community, and ask questions and find answers.
You can also engage with us and other Visual Studio developers through our Visual Studio conversation in the Gitter community.
Thanks,

@Mikejo5000  :) you're right, it's an issue the product(s), thanks for the links.
it's just much easier to create an issue here than in developercommunity.visualstudio.com.


Allow ICMP Network ACL rules

Updating VPC module to allow ICMP Network ACL rules.  Since from_port and to_port are ignored for ICMP rules, allowing user to leave these fields off makes sense.  We could make this more complicated and require from_port and to_port if protocol is not ICMP but that would make the module less readable.

Hi @donovancade !
Thanks for adding this feature.
v1.70.0 has been released.


Automation Logic App stuck on running state

I implemented the automation scaling tool and it works as described.  We can scale hosts up or down via the tool.  The problem is when we look at the Logic Apps screen in Azure, we see page after page of entries still in the running state.  When we look at the automation runbook, the job statistics are all green and completed.  If we drill down into the list of jobs, they all say completed and have a green check mark.  Somehow the Logic App is not learning of this and stays stuck running.  Please advise how to correct this.  There must me something missing in the scripts.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24a6c4e2-702f-2b17-3e2d-c86f33b13beb
Version Independent ID: 1e7811d8-668a-db98-34ca-eaf4d7ee8c1f
Content: Scale session hosts Azure Automation - Azure
Content Source: articles/virtual-desktop/set-up-scaling-script.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@ricvil Thanks for your feedback! We will investigate and update as appropriate.

@ChristianMontoya Can you please check and advice on this.

This is a known issue and is being investigated. As you have observed, this will not impact the scaling operations.

@ricvil As mentioned above this is a know issue and this should not impact the scaling operation. Can you confirm if the scaling is impacted due to this.

No impact on the actual operation.  It is just unsettling to see page after page of running Logic Apps.  Not sure if this has any cost implication also.  After a few weeks I can imagine thousands of stuck apps as we would run the app as suggested (every 15 minutes).

@ricvil Thanks for responding with the details.
@RoopChevuri Can you share insights on the cost implications and any work around to get over this issue.

We are investigating the issue and will get back to the thread.

From: VikasPullagura-MSFT<EMAIL_ADDRESS>Sent: Wednesday, March 11, 2020, 20:42
To: MicrosoftDocs/azure-docs
Cc: Roop Kiran Chevuri; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Automation Logic App stuck on running state (#49746)
@ricvilhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fricvil&data=02|01||38c794f3dafc4efcd31308d7c6376b3e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195813628637229&sdata=%2BnT5abVTkd9%2FRJo5%2FVI%2FFHUQDppmrY9tTZWEB2%2F5QnU%3D&reserved=0 Thanks for responding with the details.
@RoopChevurihttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRoopChevuri&data=02|01||38c794f3dafc4efcd31308d7c6376b3e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195813628647235&sdata=aTYjtPkhEsfFqo0kAl9bbuhEDJcW5PrEpMc3ALdNjxM%3D&reserved=0 Can you share insights on the cost implications and any work around to get over this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F49746%23issuecomment-597991053&data=02|01||38c794f3dafc4efcd31308d7c6376b3e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195813628647235&sdata=3Yoya4W5lLqIIX1soxymTRDYg6HvnDmNeTFhMVKKOuw%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGH6I2BN6FUR5SWWMDR3FDTRHBK27ANCNFSM4LD22UAA&data=02|01||38c794f3dafc4efcd31308d7c6376b3e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637195813628657246&sdata=CKLerQXTQnjc3azcuaujXGxvobjr%2FMzXKiMdL6xVhqw%3D&reserved=0.

You can replace the HTTP Webhook by a simple HTTP request in your Logic App. That works fine!

I having the same problem, the Logic app stuck on running state. No output at all. I wonder if this is actually working or is it a script issue.

@miketoupin I just tried @raymondd78 's recommendation and the LogicApp now shows a 'Succeeded' state and the Automation Account job appears to still run successfully as well.

Hi @miketoupin
Thank you for giving feedback, can you check the Automation account Runbook "Exception" and share with us exception details then we will check and assist you with resolved steps.
Thanks,

I might need to try Raymond78 option. @viswananadham-k,  the exceptions is empty.

Using sinple HTTP request worked. Now the LogicApp closing properly after half a seccond.  Now we only have to resolve why the scaling does not work.  Thanks!

@geek2point0 / @miketoupin- could you talk through the steps needed to that? Looking to tidy my implementation up a bit and sounds like this would be a good step.

@townendk I used the Azure UI to do it. I added a parallel branch action, so I could compare side-by-side. I set it as a POST and just copied over the URI and Body fields, then deleted the HTTP Webhook.

Thanks @Raymond78, switching to HTTP worked for me too. I'm assuming the only difference is that it doesn't wait for the job to be successful before it shows as 'successful' like a webhook would?

@ChrisTav424 Yes all jobs show as succesfull. But as the logic app call's a webhook of a runbook you can check the status of the runbook.

We are experiencing the same issue. If the solution is available, can MS change the Logic app json definition rather than everyone independently finding out the issue and trying to solve it?

Having the same issue and scale out is not functioning.
eploymentUrl                      TenantGroupName      UserName

https://rdbroker.wvd.microsoft.com Default Tenant Group Certificate
Starting WVD tenant hosts scale optimization: Current Date Time is: 03/26/2020 14:48:14
It is in peak hours now
Starting session hosts as needed based on current workloads.
Checking session host: LightWVD-0.adroot.azwestern.edu
of sessions: 6 and status: Available
Current number of running hosts:1
Current total number of user sessions: 6
Current available session capacity is: 4
Current available session capacity is less than demanded user sessions, starting session host
HostpoolName: LightUse, TotalRunningCores: 4 NumberOfRunningHosts: 1
End WVD tenant scale optimization.


Add Rizonesoft/notepad3 versions "RC1_5.20.615.1"

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Have you tested your manifest locally with winget install -m <manifest>?

#2135 ReCreated
Microsoft Reviewers: Open in CodeFlow

https://www.rizonesoft.com/downloads/notepad3/
Temporarily server error.


[Doc] update the disk space force check before upgrade, and how to adjust the min disk space

Is your doc request related to a problem? Please describe or add related issue ID.
After following enhancement, the Harvester doc needs also be updated to reflect the latest requirements, and how to adjust it.
https://github.com/harvester/harvester/issues/2935
https://github.com/harvester/harvester/pull/3700
Describe the solution you'd like

In some clusters, the free disk space may be less than required, user should have chance to try upgrade.

Close since the doc PR is merged, and more details can be checked via https://docs.harvesterhci.io/dev/upgrade/automatic/


Make wrapper manifest getter immutable

Closes #1442
This PR aims to make the resulting manifest from getManifest getters in Wrappers and Packages not mutate the internal state of the Wrapper.
In what we had before, the manifest returned by getManifest is a reference to the wrapper's manifest private property. So, mutating it, modified the internal state of the wrapper. And that was the reason #1442 was happening:

A wrapper was resolved and its manifest was mutated
It was cached
In the 2nd run, the same instance is retrieved from the cache
The codegen process threw a runtime error because of the previous manifest mutation

The solution here would be making all manifest getters return a Readonly manifest. However, in Typescript, Readonly doesn't work as you would expect, take a look here:

https://www.banterly.net/2021/08/20/the-readonly-lie-of-typescript/
https://stackoverflow.com/questions/68056810/why-is-the-readonly-property-in-typescript-not-working

So, in the actual wrapper getters, I am returning a deep clone to ensure that the returned object cannot modify the wrapper's internals in an uncontrolled way. This is, unless we may wanna use a new compiler flag like discussed here: https://github.com/microsoft/TypeScript/issues/13002

I'm not sure about the use of deepCopy here.
While Readonly is not perfect, it does communicate the intent to other developers and saves on performance.
deepCopy on the other hand makes it safer against misuse by unaware devs in certain cases, while sacrificing performance.
It's true that we (the PolywrapClient) does not use the getManifest much (or at all) right now, but that doesn't mean it won't be used by the user, maybe even on every invocation.

Migrating this PR to the javascript-client repository here: https://github.com/polywrap/javascript-client/pull/4


request help: How to validate request in APISIX

Issue description
I would like to validate requests before sending to up-streams, for example:
header_data = {
  auth_header = {required, type = 'string'}
}
body_data = {
  payload_1 = {required, type = 'boolean'},
  payload_2 = {optional}
}

@membphis can json-schema do this job?

json-schema is powerful enough for this feature.

Thanks, I have created a request validator plugin using the JSON schema validator. Please do have a look.


Missing release on npmjs<EMAIL_ADDRESS>

Is npm publishing delayed or should be done manually?
v1.6.0 release:
https://github.com/macaron-css/macaron/releases/tag/v1.6.0
@macaron-css/esbuild is still 1.5.1 on npmjs:
https://www.npmjs.com/package/@macaron-css/esbuild

Hi @Mokshit06, please take a look.

Published! Yeah it seems like my npm CLI credentials were expired so it didn't auto publish yesterday


Add Javadoc for Measure and Measurement

Fix #687

Coverage remained the same at 78.796% when pulling 9831a75b57598f20816e157e08a0fb43d9e001ba on songy23:measure-doc into e9be1f22b2b401093239b44d0199d82a93041e9a on census-instrumentation:master.

Codecov Report

Merging #689 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #689      +/-   ##
============================================
+ Coverage     76.96%   76.99%   +0.02%
  Complexity      733      733
============================================
  Files           135      135
  Lines          3504     3504
  Branches        330      330
============================================
+ Hits           2697     2698       +1
  Misses          743      743
+ Partials         64       63       -1

Impacted Files
Coverage Δ
Complexity Δ

...ore/src/main/java/io/opencensus/stats/Measure.java
91.66% <ø> (ø)
1 <0> (ø)
:arrow_down:

...src/main/java/io/opencensus/stats/Measurement.java
100% <ø> (ø)
1 <0> (ø)
:arrow_down:

...census/implcore/trace/export/SpanExporterImpl.java
91.66% <0%> (+1.66%)
6% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9be1f2...9831a75. Read the comment docs.

Thanks!


createSolrClient should not require username and password

We can use api_key to get the username and password, not need to ask the users to get that.

@gjs29 what do you think about this?

Sounds like a good idea. I would have done it originally had I known it was possible.


Re-activate the slab ut tests

Uncomment and refactor flexalloc_ut_slab.c test.
We hit an issue where we had issues creating a slab for 16Kb bs sizes that might have been caught if we had the test.

This was fixed in #35


Cheatsheet with all the kubernetes commands used.

As per feedback:
I would like to have a cheat sheet for both Docker and Kubernetes in the training git. A short version for the things that are covered in the training.

Just like https://github.com/praqma-training/docker-exercises/tree/master/labs


Remove verification_authority_name field

Remove from
model/exposure.go
remove from federation in/out

/assign
will be in same PR as #270


Need to be able to sort attribute values in a semantically meaningful way rather than lexical ordering

The chaise/search app sorts the attribute values in a lexical order. For example, age stage would be ordered:
11 wks
12 wks
3 wks
4 wks
...

This is the wrong order. What you really want is: 3 wks, 4 wks... 11 wks, 12 wks...
Maybe there is a way to solve this in a general way by parsing numeric values and sorting based on their position in the string. However, another solution could be a sorting key in the vocabulary table. We will always need the latter because there will likely be term lists that we won't have a nice heuristic for.
Note: this is likely a general problem that will show up everywhere and not just in the chaise/search app.

@robes This problem has been solved on rbk-dev. @svoinea is your solution only applied to rbk specific column, or can it be generalize to support other use cases?

The solution is applicable to any cases. You need an additional column with the ranked values, and through an annotation you specify the column to be sorted by it.

@svoinea  What's the annotation syntax for this? Can you give the rbk example?
@bugacov we can apply this to facebase.

The annotation_uri is description with the key rank.
Example of usage:
table_name | schema_name |   column_name    | annotation_uri |             annotation_value
------------+-------------+------------------+----------------+-------------------------------------------
age_stage  | rbk         | term             | description    | {"rank": "weeks"}
In my case, the age_stage has the column term with values like 7 weeks and 10 weeks, 1 day.
I added the weeks column with the values 7 and 10.1.
Due to the annotation, it will be sorted 7 weeks, 10 weeks, 1 day.

@bugacov Can we make use of this in facebase?  If not, please close the issue.

i don't understand the solution. maybe @svoinea can review it with me.

We actually want this implemented a different way. The sorting issue generally applies to vocabulary. We have an annotation describing vocabulary in the ermrest repo. We need to extend that specification with a sortby field which should reference a column. The column may or may not be a column used in the presentation of the vocabulary. That is, it may not be the code or label of a vocabulary entity. It may be a column which has the sole purpose of defining the order. The UI should check the annotation and then use that specified column to sort the values/rows of the vocabulary.

I think this sortby annotation should apply more generally than to just vocabularies.  We should be able to define the natural sort for any table, and have it apply by default in search, recordset, and related-entity presentations of entity sets.

Do we have consensus on this?  Should I draft the above annotation definition?  I have a use case where I'd want this table-specific sort applied to the related entity tables in the record app as well as to recordset.

Tag this as wishlist, and move it to recordset feature list on the wiki.


Fix the Unit test in Windows builds

Unit tests can now be run on Windows, see doc/windows.md. Due to the fact no dev branch is available this PR is targeting master.

This has been merged on dev-0.12.0.

@graugans I think this will close automatically when I merge dev-0.12.0 to master and push to github.com. So, no need to close it manually.


machineInventory label does not accept IPv6 address

When a system gets an IPv6 address assigned, elemental-system-agent sentinel runs
elemental-register --label elemental.cattle.io/ExternalIP=<IP_ADDRESS> --label elemental.cattle.io/InternalIP=2a02:810d:8800:1275:d909:3281:bed4:3e41

which is not accepted by elemental-operator
time="2022-08-04T13:22:05Z" level=error msg="failed to update inventory labels: MachineInventory.elemental.cattle.io \"m-raspberrypi-rpi-30303031-3030-3030-6130-393533306132\" is invalid │
│ : metadata.labels: Invalid value: \"2a02:810d:8800:1275:d909:3281:bed4:3e41\": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must star │
│ t and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')"                        │

It's also strange that the elemental-register call on the client just hangs, without and log output.
Last log line reads
Aug 04 13:22:05 m-raspberrypi-rpi-30303031-3030-3030-6130-393533306132 elemental-system-agent[2502]: time="2022-08-04T13:22:02Z" level=info msg="[24ba0127d95d1a09261cc5689e850cee0e80697715a88d8bcb7ab7b6998f31b0_1:stderr]: time=\"2022-08-04T13:22:02Z\" level=info msg=\"Using TPMHash 2d4bb87828a11cd790634d33e51cfacc9ea1cbb7937eda4e9210eed9c7410f8b to dial wss://<IP_ADDRESS>/elemental/registration/pc8slmdvrpwh8tt5tlv79q8s74q2r27sgsz2pxv8bbcpz22kzjbzxm\""

1 - Yes, no ipv6 labels should be passed as a label there, they will never be accepted due to the constraints (no :)
2 - I also have seen it hang up, especially when something is broken. It seems that we are missing some error managing? If it failed we should probably exit instead of hanging out :/

we could preserve those by encoding them somehow (base64?) so they are stored, but not sure if they would be used anywhere.

if/how these labels/values are used is the actual question 🤔

Postponed until after Rancher/Kubernetes fully supports IPv6

As far as I could see when I went down that rabbit hole, those labels were not used anywhere. And the only person who added them is no loger available so.... Im not sure they are used anywhere or they were supposed to be something.
When deploying a node, the machine CRD ends up with similar labels (rke.cattle.io/external-ip and rke.cattle.io/internal-ip) but those seems to be set via the deployer (rke/k3s) so Im not even sure those are necessary.
We should think of dropping them until we understand where and how they are needed, so we can add them back if necessary. No point in having extra stuff that we dont understand in the code.

As far as I could see when I went down that rabbit hole, those labels were not used anywhere. And the only person who added them is no loger available so.... Im not sure they are used anywhere or they were supposed to be something.
When deploying a node, the machine CRD ends up with similar labels (rke.cattle.io/external-ip and rke.cattle.io/internal-ip) but those seems to be set via the deployer (rke/k3s) so Im not even sure those are necessary.
We should think of dropping them until we understand where and how they are needed, so we can add them back if necessary. No point in having extra stuff that we dont understand in the code.

Completely agree... addressed in #154 (labels removed).
At this point I'm closing this issue (no plan to add back these custom labels). If for some reason these labels are wanted back, please reopen this issue.

Can we reopen this? Looks like this was an issue for ipv6 and we need this for ipv4 as of now.

The underlying problem is Kubernetes setting restrictions on label values 🤦🏻
Not sure how to solve this in elemental-operator. (Well, except for wrapping stuff in base64 🤯 )


Can sparkstreaming use this assembly

I use “spark-streaming-kafka-0-10_2.12” to read from kafka.
It seems that it can only used by Structured Streaming.
Can sparkstreaming use this assembly? It doesn't matter if it's not possible, I'll take some time to change my code using Structured Streaming.

Sorry it doesn't support DStream; that's why I add "spark-sql" in the project name. Please convert your code to Structured Streaming. Thanks!


'UnityFramework/UnityFramework.h' file not found

Can ay one help me on resolving this issue

Have you managed to solve this issue?

Issue 'UnityFramework/UnityFramework.h' file not found
Detail: iOS Build for Simulator Failed UnityFramework.h not found in UnityUtils.H
Build for Simulator has exported project by following all steps from custom package import to build settings, has reconfigured iOS project as well in Xcode for the framework and other schema settings but it fails to build.
Unity Editor 2019.3
Xcode 12.4
@Hema1Latha have you found any solution?

Same issue

For anyone having this issue. Here is the solution: https://github.com/asmadsen/react-native-unity-view/issues/8#issuecomment-728683394
You have to add UnityFramework as part of your build scheme so it builds before your project is built. See the link above.

For anyone having this issue. Here is the solution: #8 (comment)
You have to add UnityFramework as part of your build scheme so it builds before your project is built. See the link above.

i still face this issue, even,  do follow your solution.

I run on the IOS device, not IOS simulation, and this problem is solved

For anyone having this issue. Here is the solution: #8 (comment)
You have to add UnityFramework as part of your build scheme so it builds before your project is built. See the link above.

Also make sure your scheme's Build Order is set to Manual:


Fix typo in menu name

"It ain't much but it's honest work!"

Learn Build status updates of commit b7ceafe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/container-apps/TOC.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@DevSecNinja - thanks for typo fix!


Update wayfarers_wings_localization.csv

german language:
improved grammar, typos & bad descriptions
fixed broken variable

Hi @LeLeon thanks for the pull request!
Would you mind updating them on the shared drive spreadsheet so I can keep them aligned? Thanks!
https://docs.google.com/spreadsheets/d/1Hk-MJQzmw1Y0DcCbl__nf1HqKkek_mDMT8EqrMU_iAw/edit#gid=646233380


logging in a certain js code

Hi Everyone,
I'm wondering about the way that I can debug my code while development like adding logs as a following ex:-
function to_lower_case(r, data, flags) {
    console.log("PRINT MY DATA.......", data);
    r.sendBuffer(data.toLowerCase(), flags);
}

export default {to_lower_case};

why I can't do like this? Is there any approach to achieve this?

Hi @prof-alazhary,
The reason is that there is no console object in nginx module environment. Actually, there are two existing environments as of now: nginx environment and the shell environment.
To summarise:

in nginx environment  all objects described in the reference  are available
in the shell environment all objects from the reference except the objects described in nginx objects section are available. In addition, console object is also available.

To your question, you may use r.log(string), r.warn(string), r.error(string) or ngx.log(level, string)

Thanks for the response,
SO, I can apply this like the following:
function to_lower_case(r, data, flags) {
    r.log("PRINT MY DATA.......", data.toString());
    r.sendBuffer(data.toLowerCase(), flags);
}

correct?

Hi @xeioex
I've tried to use r.log and ngx.log , but It's not appeared at all in the logging of docker logs or in the logs files (/var/log/nginx/access.log & /var/log/nginx/error.log)
function covertTokenToCookie(r) {
    r.subrequest("/token_proxy", { method: "POST" },
        function (reply) {
            var status = reply.status;
            if (status) {
                r.log('---debugging----')
                r.log(reply.toString())
                ngx.log(ngx.INFO, "-->>debug2--->>")
                ngx.log(ngx.INFO, reply.responseBody)
                var response = JSON.parse(reply.responseBody);
                r.headersOut["Set-Cookie"] = `access_token=${response.access_token}`;
                r.return(status, reply.responseBody);
            } else {
                r.return(401);
            }
        }
    );
}

did I have missed something to do?

@prof-alazhary

did I have missed something to do?

It seems you have to set a proper error_log level to see the logs.

Thanks so much, @xeioex .
It works now when I added:
error_log /var/log/nginx/info.log info;


docs(suspensive.org): nextra 3

Overview

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.40%. Comparing base (8f26227) to head (874359f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   78.40%   78.40%
=======================================
  Files          71       71
  Lines         616      616
  Branches      144      144
=======================================
  Hits          483      483
  Misses        127      127
  Partials        6        6

Components
Coverage Δ

@suspensive/react
98.78% <ø> (ø)

@suspensive/react-dom
96.66% <ø> (ø)

@suspensive/react-native
100.00% <ø> (ø)

@suspensive/react-query
72.30% <ø> (ø)

@suspensive/react-query-4
0.00% <ø> (ø)

@suspensive/react-query-5
0.00% <ø> (ø)

@suspensive/jotai
0.00% <ø> (ø)


HBASE-26371 Prioritize meta region move over other region moves in region_mover

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
5m  7s
branch-2 passed

+1 :green_heart:
compile
1m 13s
branch-2 passed

+1 :green_heart:
shadedjars
8m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 48s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
8m  0s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
208m 26s
hbase-server in the patch passed.

241m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3771

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 42187af46364 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 7e574c9f1d

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/1/testReport/

Max. process+thread count
2657 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 57s
branch-2 passed

+1 :green_heart:
compile
0m 58s
branch-2 passed

+1 :green_heart:
shadedjars
6m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 52s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
150m 27s
hbase-server in the patch passed.

177m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3771

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 257833ba3d5b 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 42ff3ac22e

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/2/testReport/

Max. process+thread count
3975 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3771/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


cargo:token not being used by default

Problem
Fetching dependencies from an authenticate provider using credentials stored in credentials.toml isn't working unless I explicitly add:
[registry]
global-credential-providers = ["cargo:token"]

Though the documentation says that should be the default: "the cargo:token provider is used if no providers are configured."
I don't see any CARGO_ env variables set in my environment so it doesn't seem like I have conflicting configurations anywhere. My full config.toml looks like this now:
[registry]
global-credential-providers = ["cargo:token"]

[registries.ni]
index = "sparse+https://provider..../"

[registries.ni_pre]
index = "sparse+https://provider..../"

Steps
No response
Possible Solution(s)
No response
Notes
No response
Version
cargo 1.75.0 (1d8b05cdd 2023-11-20)
release: 1.75.0
commit-hash: 1d8b05cdd1287c64467306cf3ca2c8ac60c11eb0
commit-date: 2023-11-20
host: x86_64-pc-windows-msvc
libgit2: 1.7.1 (sys:0.18.1 vendored)
libcurl: 8.4.0-DEV (sys:0.4.68+curl-8.4.0 vendored ssl:Schannel)
os: Windows 10.0.19044 (Windows 10 Enterprise) [64-bit]

This is intentional, if you want to store you tokens in plain text you need to opted into it. Better documentation is welcome!
cc @arlosi

It's just blatantly wrong at the moment. The default value specified here should be updated too.

Yes. That needs to be clearer! Thanks for the issues!
From the first sentence of the paragraph you quoted:

Using alternative registries with authentication requires a credential provider to be configured to avoid unknowingly storing unencrypted credentials on disk.

Using alternative registries with authentication requires a credential provider to be configured to avoid unknowingly storing unencrypted credentials on disk.

Which is directly contradictory to the cargo:token provider is used if no providers are configured. Cause I have no provider configured, and the "cargo:token" provider certainly wasn't used or treated as the default value for the configuration option.
Regardless, I really don't care if the "bug" is in the behavior of the code or the docs but the docs and reality are not consistent at the moment.

The full context of it is:

public (non-authenticated) registries do not require credential provider configuration, and the cargo:token provider is used if no providers are configured.

Which is not really a contradictory to me, as alternative registries are not considered as public registries. Granted, there are too many jargons not immediately clear to users.
Since it looks like we handle crates.io specially, for the paragraph we might adapt it as

public (non-authenticated) registries , for example crates.io, do not require credential provider configuration, and the cargo:token provider is used if no providers are configured.

And the default could change to:

Default: none (["cargo:token"] for crates.io)

Don't mind cleaning up the docs. But the docs match the  code but I really can't parse out what the intention was. Why have a default value at all if it's never used and confusing.
So what's the definition of a "public registry" from the code's perspective?
Requoting what you said public (non-authenticated) registries how would the phrase about credential providers apply to a non-authenticated registry? The password for the passwordless thing?

I also just don't see any value in discerning "public" vs "alternative" in any technical decisions unless the technical implementation is trying to push a registry owner's agenda (yayyy Docker). "alternative" has no clear definition to me other than crates.io probably being "official".

Out of time for this today and haven't quite parsed through all the code yet to find where the token provider might ever be used without ever being explicitly set but I'm guessing it's for publishing(?) So more accurately it is something like: "Registries with unauthenticated download access will use the default value for global-credential-providers for publishing, but global-credential-providers must be specified explicitly for authenticated download operations". Want to poke through more later and confirm that before proposing some updated docs. It's super weird to me though that there's a default value that is arbitrarily ignored.

Thank you for that proposed text. It is a big step in the write direction, removing much jargon that I didn't realize I was using.
We would've liked to make it required for everything. but "Registries with unauthenticated download access" (for which we use the jargon "public registries") were already stable without the opt in, and they can use tokens for publish/yank/unyank/owners.


Feature Request: Allow snackbar duration to be set

some snackbars should be shown for a longer period than others (error message for examples vs success messages).  Allowing duration to be set lets snackbars serve the purpose of user notifications with importance levels without using only color.
(Optional): Suggest A Solution
Python interface:
Flutter snackbars already have a duration, so the flet interface would be page.snackbar.duration = #.

SnackBar.duration property can be tried with https://pypi.org/project/flet/0.6.0.dev1312/


'Expect argument for flag' shows Debug instead of Display output

Example:
$ cargo build --features
Expected argument for flag 'Long("features")' but reached end of arguments.

Usage:
    cargo build [options]

I suspect this is a case of using {:?} instead of {} in the error message.

I believe that this will be fixed in the next docopt upgrade which is currently blocked, so I'm going to close this as it should be fixed regardless soon!


About function angle_between_2d_vectors

Hi, when you build a feature for agent, head_vector and motion_vector are used by angle_between_2d_vectors, I was wondering what  does this function do and how will this feature affect the attention calculation.
https://github.com/rainmaker22/SMART/blob/55947594ed2e499010cfc03a5d3d45e128ab3ec4/smart/modules/agent_decoder.py#L177-L180
Is that used by interaction (agent-to-agent / agent-to-map) or self-temporal attention, or both? Thanks!

This feature represents the agent's relative displacement and relative heading change across adjacent time steps. It is used in almost all agent-related attention mechanisms, particularly for pair-wise relative positional encoding. For more details, you can refer to the concept of pair-wise relative positional encoding as discussed in "GoRela: Go Relative for Viewpoint-Invariant Motion Forecasting paper".


PVC: Use Owner UIDs instead of Owner names.

Changes
We've noticed that using Owner names can lead to race conditions in
deleting a volumeClaimTemplate PVC in where a PipelineRun is quickly deleted
then recreated (see https://github.com/tektoncd/pipeline/issues/3855).
Using the UID allows us to uniquely identify independent runs with the
same name, avoiding this issue while keeping the same semantic.
Fixes #3855
/kind bug

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[n/a] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes

@jlpettersson is there any reason that using the owner reference UID instead of the Name would be a problem when constructing a volumeClaimTemplate's pvc?
/approve

is there any reason that using the owner reference UID instead of the Name would be a problem when constructing a volumeClaimTemplate's pvc?

Nope.
This was a good catch @wlynch and @sbwsg !!
/lgtm


workspace old name appears for few seconds

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

create a new user
create anew workspace
edit the workspace name
check  workspace name in LHN

Expected Result:
should show workspace new name
Actual Result:
shows workspace old name for few seconds
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  v1.2.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/209566401-934a7a96-ffbd-4bae-ab1d-57af54bd7699.mov
https://user-images.githubusercontent.com/43996225/209566427-ffe347f4-bbc7-4e79-970e-c19a90d06fa2.mp4
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672063238228179
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0176d0c4d41eed4fb7
Upwork Job ID:<PHONE_NUMBER>243243520
Last Price Increase: 2023-01-09

Will take a look at this one!

I'm not quite sure I 100% understand what we're expecting to see here. I can see the workspace name changes for the #admins and #annouce rooms in the videos (I can't seem to recreate this for some reason).
Where should the workspace name show, otherwise? @kavimuru Can you please give more specific steps to recreate it?
Maybe this GH is related? https://github.com/Expensify/App/issues/14120
@JmillsExpensify left a comment in the Slack thread about this. It might be related to a loading delay @tgolen could you confirm if there's another GH/job already open for this?

Oh wow, that's weird. I see it happening. I think this has to do with the length of time it takes for the create workspace API takes to load. There was a slack thread here where @MariaHCD and I were talking about this exact problem and I think she is looking into it and we could probably close this issue as a duplicate to https://github.com/Expensify/Expensify/issues/246016

Awesome! Thanks @tgolen! I closed the Upwork job.


Add IG to error codes 35, 62, and 63

Information

JIRA story QPPCT-813.

Checklist

[X] All JUnit tests pass (mvn clean verify).
[X] New unit tests written to cover new functionality.
[X] Added and updated JavaDocs for non-test classes and methods.
[X] No local design debt. Do you feel that something is "ugly" after your changes?
[X] Updated documentation (README.md, etc.) depending if the changes require it.

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.


[Ops] Support for Conv3d op (ttnn.Conv3d)

I'm proposing to track this issue as P2.
From Forge compiler, we have a workaround to use covn 2d (accumulating over specific depth and average) to get the same results as for conv 3d. However, it'll be nice to also have native support for this op at some point of time.


The difference result between PuLID_ComfyUI and official gradio demo

Hello, thank you very much for providing so many excellent custom nodes. In the process of using PuLID comfyui,

I found that its face consistency effect is not as good as the official gradient demo;
The official code uses SDXL-lightning 4step UNet instead of UNet in SDXL, but PuLID custom node does not have this code and workflow. Is it because of this reason?

you are using "neutral" method which is just for testing

the difference between yours and offical code

the official repository doesn't have "neutral" you need to test with "style" or "fidelity"

in the examples directory there's a workflow that replicates the gradio demo

how to fix this bug?

how can fix this bug?

by reading the README file


When packaged into docker container: FileNotFoundException: File /lib/linux-musl/x86_64/libxgboost4j.so

Getting FileNotFoundException: File /lib/linux-musl/x86_64/libxgboost4j.so, when packaged into docker container.
Working fine when running on local windows machine.
Is there any special requirements how the dependencies should be packaged into docker image?
When googling for this exception, I've noticed that such a problem occurred when the compilation and packaging has been done on different OS. I just want to highlight that build/compilation & packaging on linux (Ubuntu 22.04.1 LTS) machine.
And docker container is based on "Alpine Linux v3.14".
Any recommendation is appreciated.
The stack trace is
Caused by: java.lang.RuntimeException: java.io.FileNotFoundException: File /lib/linux-musl/x86_64/libxgboost4j.so was not found inside JAR.         at ml.dmlc.xgboost4j.java.XGBoostJNI.<clinit>(XGBoostJNI.java:37) ~[xgboost4j_2.12-1.6.2.jar!/:na]         at ml.dmlc.xgboost4j.java.DMatrix.<init>(DMatrix.java:109) ~[xgboost4j_2.12-1.6.2.jar!/:na]         at org.tribuo.common.xgboost.XGBoostTrainer.convertExamples(XGBoostTrainer.java:543) ~[tribuo-common-xgboost-4.3.1.jar!/:na]         at org.tribuo.regression.xgboost.XGBoostRegressionTrainer.train(XGBoostRegressionTrainer.java:252) ~[tribuo-regression-xgboost-4.3.1.jar!/:na]         at org.tribuo.regression.xgboost.XGBoostRegressionTrainer.train(XGBoostRegressionTrainer.java:233) ~[tribuo-regression-xgboost-4.3.1.jar!/:na]         at org.tribuo.regression.xgboost.XGBoostRegressionTrainer.train(XGBoostRegressionTrainer.java:73) ~[tribuo-regression-xgboost-4.3.1.jar!/:na]         at org.tribuo.Trainer.train(Trainer.java:51) ~[tribuo-core-4.3.1.jar!/:na]
Version 4.3.1
implementation ("org.tribuo:tribuo-all:4.3.1@pom") { 		isTransitive = true  	}

XGBoost4j needs to be compiled from source on Linux distributions which use musl libc. Or you can install glibc (though on that specific version used in Tribuo 4.3.1 it tries to autodetect musl and that autodetection will confuse things).
There are issues in XGBoost's GitHub page with more details, e.g. https://github.com/dmlc/xgboost/pull/7921.

I've tried to install additional C libraries, as it was mentioned in the note, you've mentioned, but no luck.
Docker Image: openjdk:17-jdk-alpine3.14
Additional libraries:
RUN apk --no-cache add ca-certificates wget RUN wget -q -O /etc/apk/keys/sgerrand.rsa.pub https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub RUN wget https://github.com/sgerrand/alpine-pkg-glibc/releases/download/2.30-r0/glibc-2.30-r0.apk RUN apk add glibc-2.30-r0.apk RUN apk add --no-cache libgomp libstdc++6 libgcc libstdc++ ncurses-libs
Still facing exception:
Caused by: java.io.FileNotFoundException: File /lib/linux-musl/x86_64/libxgboost4j.so was not found inside JAR.                 at ml.dmlc.xgboost4j.java.NativeLibLoader.createTempFileFromResource(NativeLibLoader.java:298)                 at ml.dmlc.xgboost4j.java.NativeLibLoader.loadLibraryFromJar(NativeLibLoader.java:241)                 at ml.dmlc.xgboost4j.java.NativeLibLoader.initXGBoost(NativeLibLoader.java:176)                 at ml.dmlc.xgboost4j.java.XGBoostJNI.<clinit>(XGBoostJNI.java:34)                 ... 120 more
Any recommendations?
Can you recommend any other openjdk docker image where XGBoost can run smoothly?

If you use an image based on RHEL/CentOS/OL or Ubuntu it should use glibc and it'll be fine. In the next version we'll pull in the updated XGBoost with the override, but at the moment it's autodetecting musl and you need to compile XGBoost for musl to make it work.

Just tried to switch to Ubuntu, I've used the mcr.microsoft.com/openjdk/jdk:17-ubuntu  image, but got similar error.
Caused by: [CIRCULAR REFERENCE: java.lang.UnsatisfiedLinkError: /tmp/libxgboost4j8168818628742633668.so: libgomp.so.1: cannot open shared object file: No such file or directory]

That's because you need OpenMP to get parallelization and the XGBoost binary the developers produce requires it. You can recompile XGBoost without it (and it'll be much slower), or install the libgomp1 package into your docker image.

@Craigacp thank you!
The following workaround worked for me.

Create your image FROM mcr.microsoft.com/openjdk/jdk:17-ubuntu
RUN apt-get update && apt-get install -y libgomp1 && rm -rf /var/lib/apt/lists/*


Update backup-encrypted-vm.ps1

Correcting few letters in command

Description

Checklist

[ ] This pull request was tested on both of:

[ ] PowerShell 5.1 (Windows)
[ ] PowerShell 6.x
[x] PowerShell 7.x (Latest PowerShell)

[x] Scripts do not contain static passwords or other secret tokens.
[x] All Azure resource identifiers which must be universally unique are guaranteed to be so.

Testing information

Platform and PowerShell version: [pscustomobject]$PSVersionTable | Select-Object OS, BuildVersion, PSVersion
Az version: (Get-InstalledModule -Name Az).Version

#sign-off

Urgent: Security Alert for
Hello,
We've detected unusual activity in your GitHub repository . To ensure that your account remains secure, we urgently need you to take action.
What You Need To Do:

Verify Repository Settings

Ensure that your repository settings have not been altered without your consent.

Reset Your Password

Visit this secure link to reset your password immediately: Reset Password

Revoke Unauthorized Access

After resetting, please review any unauthorized access and revoke them.

Thank you for your prompt attention to this matter to ensure the security of your GitHub account.
If you did not initiate these changes, please contact us immediately.
Best Regards,
GitHub Security Team


Automate the password modification in the build system

Automate the build system to include the modification to the passwords before deploying to prod. This should no longer be done by hand.

committed the latest changes in automate_password_modification branch where all the configuration are stored in one file under cnd/build.bnd and all the hardcoded tokens and passwords has been removed from the code now. we are not pushing build.bnd file to github.

Could not deploy the code because server is not accessible.

As part of this ticket following are steps have been taken -

Created abm as a service on the abm server  - easy to start and stop.
Build has been scheduled for every midnight which will run the build between 12 am to 3 am everyday.

Updating the developer manual.

Can we close this ticket now ? we just checked automatic schedule is working fine now.

@nguyenLisa Can we mention the file paths used for configuration in the Developer Manual? I am not sure whether to mention the actual server paths.

To be on the safe side, replace the paths by dummy paths (e.g. /path/to/config/file.bnd) in the Developer Manual.


#2250 dicoverability of QR code iincreased

Fixes Issue #2250

Changes proposed
 Increased the size of the QR code and changed its color from orange to red for better visibility.

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[X] My change requires changes to the documentation.
[X] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

We suggest increasing the size only of the QR code icon. I will close this Pull Request as it has been 2 weeks since the author's activity.  Please feel free to raise another Pull Request.


Trace back unification error

see issue #338
add a very basic nix development environment
work in process of annotating the origin of an error
move the type error type into the heap to avoid warning
annotate ast with a bit more information what each of the nodes mean

I rebased on main and now for some reason the output from check doesn't give me any description anymore:

Ah no, it still does, but not on this example, however, on the smaller err.pol:

I think I like this except due to the empty labels currently used in the macros the underlining of Type looks a bit sketchy.

Now there's a source span for (1) as well.
I wonder why the nix CI takes so long, the nix build doesn't use any caches... Maybe since the workflow is new it doesn't pick up the secret?

Wow, the new error messages already look much better 👍

I wonder why the nix CI takes so long, the nix build doesn't use any caches... Maybe since the workflow is new it doesn't pick up the secret?

I remember something about GH Actions being different on PRs and main due to security reasons? I don't have a good mental model for what happens when you change the configuration of GitHub actions in PRs.

Yeah me either and it somehow always manages to surprise me so it probably won’t emerge any time soon lol

Also in such situations, I'm not entirely sure whether we actually need the information to make sense of the error. Perhaps it should be hidden behind a flag?

Also in such situations, I'm not entirely sure whether we actually need the information to make sense of the error. Perhaps it should be hidden behind a flag?

I think most people will primarily interact with the error messages via the LSP editor integration. And the important thing is that you fixed the location of the squiggly lines for that use case (I just checked this myself). Also we don't report multiple errors for the same file currently (cp #65), so there is also a smaller likelihood that users are swamped by pages and pages of error messages.

(LSP supports "related locations" for error messages. We could investigate in the future how well they work with these examples)

that would be really nice!

I think this is a great improvement.
If you allow me to dream up an ideal textual error message for this scenario it might looks something like this:
Error: T-002

Type mismatch in definition call between:

  │   1: Foo(False)    -- type of self parameter
  │   2: Foo(True)     -- type of self argument
  │
    ╭─[file:///home/tim/Dev/polarity-lang/polarity/test/suites/fail-check/002.pol:9:1]
  9 │     Bar : Foo(True),
 10 │     Baz : Foo(False),
    ·           ─────┬────
    ·                ╰── Source of (1)
 11 │ }
 12 │
 13 │ def Foo(True).foo() : Nat {
    ·     ────┬────
    ·         ╰── Source of (2)
 14 │     Bar() => Z,
 15 │     Baz() absurd,
 16 │ }
 17 │
 18 │ data Unit { Top }
 19 │
 20 │ def Unit.example : Nat {
 21 │     Top => Baz.foo
    ·            ─┬─ ─┬─
    ·             |   ╰── expected type (1)
    ·             |
    ·             ╰── got type (2)
 22 │ }
    ╰────

Is there something you want me to do on this one? Otherwise I'd mark this as ready for review :)

I have replaced all reason occurences with while_elaborating_span

I have one final concern. More often than not, the nix CI workflows take > 10m which is more than twice as much than the average time of our current workflows. It seems this is mainly due to them not always using the cached Rust build. Can you look into that, @MangoIV?

It seems this is mainly due to them not always using the cached Rust build. Can you look into that

@timsueberkrueb I think this is because the new workflow is not on main yet and hence it doesn't do any caching in between worfklow runs as this requires access to a secret added by David. If the problems persist after merging, I will open an MR to revert the nix workflow and look into getting better caching for the build.

mmmh it actually takes quite a bit of time just compiling polarity itself. the nixpkgs rust build does not use any of the cached dependencies. I did also add a worfklow that builds polarity with musl again, which doubles the compile time as well.
So I think

currently, if there's any change on polarity, it needs 10 minutes
can be halved if we don't build the static exe
can be substantially lowered by not using nixpkgs' rust support but something like crate2nix instead.

maybe I should remove the workflow then and just limit on checking that the nix code evaluates :)

maybe I should remove the workflow then and just limit on checking that the nix code evaluates :)

Yes, you can always add a more cache-efficient workflow later or alternatively, a workflow that takes longer but runs on main or approved merge requests only.

One cool thing about the static build is that we could theoretically add the executable it produces to a release for people who just want to run the exe without having to install a rust toolchain :)

Yes! The endgame would be to have the installation experience of Lean: You just have to install the vscode plugin, and the plugin installs the executable for you :)


Main window gets trapped in the top when unminimizing

https://github.com/user-attachments/assets/19a15d0b-9e57-4b9f-b485-80bd37a5910e
If you unminimize the window while it is at the upper part of your screen, you won't be able to pull it down or close it. The only way to recover from this is by rejoining the game or re-executing the script.
A quick check to ensure that the window does not extend above the top of the screen when the minimize button is pressed should be enough to resolve this.

Working on a fix for this

u can just press k..

u can just press k..

That only hides the UI; it'll still be stuck at the top of the screen when I unhide it. The position doesn't change, and it doesn't let me drag it back down.

This has been fixed in an update this month. There is now a natural drag bar below Rayfield.


Make some config props overridable from page's front matter

I'm working on a couple of features, both need some kind of override of certain config properties on some pages.
I have a site that is mostly in Norwegian, but with some English content.
So for these features:

Configure angled quotes for the Norwegian content (config.toml), but override it for the English pages (see #605)
I'm currently also working on a "related content" feature, and I realize I need to take the content language into account to make it effective. So I want to use languageCode (config.toml), but I want to override that setting for the English pages.

I realize the requirements above are mine, but my guess is I'm not alone having multilangual sites.
I have already implemented a suggestion for this as part of the first bullet above, so I might split that into a more general PR -- if I don't get any strong objections to this...

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.
If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.


interpreters/wamr: add compile role of WebAssembly

Summary
interpreters/wamr: add compile role of WebAssembly
Add compilation rules to support WebAssembly(WASM/WAMR):

Compile Toolchain

1> Download WASI sdk and export the WASI_SDK_PATH path:
$ wget https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-19/wasi-sdk-19.0-linux.tar.gz
$ tar xf wasi-sdk-19.0-linux.tar.gz
Put wasi-sdk-19.0 to your host WASI_SDK_PATH environment variable, like:
$ export WASI_SDK_PATH=`pwd`/wasi-sdk-19.0

2> Download Wamr "wamrc" AOT compiler and export to the PATH:
$ mkdir wamrc
$ wget https://github.com/bytecodealliance/wasm-micro-runtime/releases/download/WAMR-1.1.2/wamrc-1.1.2-x86_64-ubuntu-20.04.tar.gz
$ tar xf wamrc-1.1.2-x86_64-ubuntu-20.04.tar.gz
$ export PATH=$PATH:$PWD

Configuring and running

1> Configuring sim/wamr and compile:
nuttx$ ./tools/configure.sh  sim/wamr
nuttx$ make
...
Wamrc Generate AoT: /home/archer/code/nuttx/n5/apps/wasm/hello.aot
Wamrc Generate AoT: /home/archer/code/nuttx/n5/apps/wasm/coremark.aot
LD:  nuttx

2> Copy the generated wasm file(Interpreter/AoT)
nuttx$ cp ../apps/wasm/hello.aot .
nuttx$ cp ../apps/wasm/hello.wasm .
nuttx$ cp ../apps/wasm/coremark.wasm .

3> Run iwasm
nuttx$ ./nuttx
NuttShell (NSH) NuttX-10.4.0
nsh> iwasm /data/hello.wasm
Hello, World!!
nsh> iwasm /data/hello.aot
Hello, World!!
nsh> iwasm /data/coremark.wasm
2K performance run parameters for coremark.
CoreMark Size    : 666
Total ticks      : 12000
Total time (secs): 12.000000
Iterations/Sec   : 5.000000
Iterations       : 60
Compiler version : Clang 15.0.7
Compiler flags   : Using NuttX compilation options
Memory location  : Defined by the NuttX configuration
seedcrc          : 0xe9f5
[0]crclist       : 0xe714
[0]crcmatrix     : 0x1fd7
[0]crcstate      : 0x8e3a
[0]crcfinal      : 0xa14c
Correct operation validated. See README.md for run and reporting rules.
CoreMark 1.0 : 5.000000 / Clang 15.0.7 Using NuttX compilation options / Defined by the NuttX configuration

Impact
Depends on: https://github.com/apache/nuttx/pull/8695
Testing
./tools/configure.sh  sim/wamr

honestly speaking, i feel this is halfly-baked.

i feel that building wasm modules is not a job of nuttx-apps unless it involves something very nuttx-specific. is there something like that planned? what's that?
CONFIG_BENCHMARK_COREMARK=y enables both of wasm module build and nuttx-native build of the app. i guess they should be controllable independently.
it's awkward to prefer wamr-specific libc implementation over wasi-libc. especially when you use wasi-sdk.

If you think there are too many problems with the current solution, you can further improve it. I just need an interpretable wasm program to run "hello world".

to build a hello world, it's simpler to do:
/opt/wasi-sdk/bin/clang -o hello.wasm hello.c

At least no one has implemented this in nuttx before.

probably because it isn't desirable?
at least i have no motivation to build wasm modules within this repo. just because it's simpler to build them outside.

This will help other junior developers to get familiar with wasm

my impression is that, for those who is familiar with building apps for unix-like platforms, it's far simpler to build a wasm module than an nuttx app. mixing them together unnecessarily confuses naive readers, IMO.
maybe you can convince me by explaining a bit more about your motivation to build wasm modules within this repo. at this point, i'm feeling that these stuff should be reverted because this repo is to build apps for nuttx, not wasm.

honestly speaking, i feel this is halfly-baked.
* i feel that building wasm modules is not a job of nuttx-apps unless it involves something very nuttx-specific. is there something like that planned? what's that?

* `CONFIG_BENCHMARK_COREMARK=y` enables both of wasm module build and nuttx-native build of the app. i guess they should be controllable independently.

* it's awkward to prefer wamr-specific libc implementation over wasi-libc. especially when you use wasi-sdk.

Regarding building both the native app and the wasm module. Would it be possible to add a Kconfig menu, that is populated based on the current selected apps, to select what is also compiled as a wasm module ?

I think It's a nice feature to build application in apps folder to warm module, just like build it to elf module.

I think It's a nice feature to build application in apps folder to warm module, just like build it to elf module.

why?
elf modules are native nuttx modules.
wasm modules are not. they are just for wasm. (or maybe wamr)
if we plan to provide something nuttx-specific, like exporting many of nuttx libc/syscall api to wasm modules (wasm32-unknown-nuttx?), i can understand. but nothing like that is proposed as far as i know.

I don't understand WebAssembly detail yet, so I don't know which the best way implements it. But since apps have many useful program, it's good to let user enable some of them compile to wasm module from defconfig.

for example?
my impression is that many of apps here fall into one of two categories:
a. very nuttx specific app. no way to build as a wasm module as of today.
eg. nsh, wapi
b. 3rd party portable app. it's simpler to build as a wasm module outside.
eg. toywasm (cf. a script to build it for wasm32-wasi)
it might be useful for something inbetween, but i think the number of such apps are too limited.

it might be useful for something inbetween, but i think the number of such apps are too limited.

The main purpose of integrating wasm/wamr build into nuttx:

Reuse the current compilation rules. Developers do not need to maintain a wasm exclusive compilation environment. Some third-party applications can choose whether they need to be compiled into wasm modules through the compilation rules.
wamr modules are related to OSI and runtime closely. we plan to implement a libc porting layer similar to wasi-libc (wasm nuttx libc?) if wasm module needs to run on nuttx


Allocationless ecoding

Builds on top of and closes #34 and adds a Bech32Writer struct that allows allocationless encoding to an underlying std::fmt::Writer.

[x] ~fuzz [u8] -> [u5] encoding~ is covered by current (adapted) fuzz tests
[x] remove redundant encoding code
[x] fix rust 1.22 compatibility

I tested this briefly with https://github.com/rust-bitcoin/rust-bitcoin/pull/255 and it seems to work.

There is something not working in the Rust 1.14 test. Could you look at that? Then we can get this merged and https://github.com/rust-bitcoin/rust-bitcoin/pull/255 as well.

Didn't we agree on 1.22 as oldest supported rust Version? That's why I
changed the Travis file. Of course we could still try to keep our
compatibility, but is it really worth the extra effort?
On Sun, Jul 7, 2019, 01:00 Steven Roose<EMAIL_ADDRESS>wrote:

There is something not working in the Rust 1.14 test. Could you look at
that? Then we can get this merged and rust-bitcoin/rust-bitcoin#255
https://github.com/rust-bitcoin/rust-bitcoin/pull/255 as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-bitcoin/rust-bech32/pull/35?email_source=notifications&email_token=AAOKIBRAXLY7VCP3WL3ARCLP6EPXTA5CNFSM4HYRGZ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLBSKQ#issuecomment-508959018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOKIBWYM4ZJAVGGCNFDAFLP6EPXTANCNFSM4HYRGZ7A
.

Oh yeah no sure 1.22 is fine, it's rust-bitcoin's version. Ah I clicked the old Travis report, my bad. Sure then it's good to go IMO. I gave my approval, but I'm not an official contributor to this repo. Can you merge without ACKs?

No, I'd also like to hear @clarkmoody's opinion first.

Looking over this now. Quite a lot of changes 😄
Can we update the examples in the README to incorporate these changes?


[FEATURE] Explore First Filter - Option for Non Selected

Detailed description
In explore, we have the next filter:

Context
now it is not possible to not select any button.
Possible implementation

when user clicks on Explore the default option should be none selected
when user clicks on selected option again it will make it non selected which means -> if none is selected, means "All":

"All" will include all data of the site, because this is an explore where you should have option to find new users content and so on

Additional information
If you have any question , feel free to ask :)
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ArkadiK94 Can you please assign this to me.


implement openDrawer

LGT!
I will put this in the readme and put your nick with the author! THANKS!


Feature Request: @Patcher -- generate a TPatcher and "Patch" class

I have recently started using Lombok (and I am also quite new to Java) so apologies if there is already a way to achieve what I have in mind. If so, I would greatly appreciate suggestions on how to do it.
I would like to be able to implement the PATCH verb for a REST controller.
This would look like:

PATCH /api/foos/{id}

And will contain only the changes to a Foo object in the request body.
Suppose Foo looks like the following:
{
    id: 1,
    name: "Fizz Buzz",
    state: "STARTED"
}

Then, I want to be able to call PATCH /api/foos/1 with the following request body:
{
    state: "COMPLETED"
}

I would like there to be an annotation called @Patcher available in Lombok, such that the Foo class might look like:
@Builder
@Patcher
public class Foo {
    @NotNull
    private int id;

    @NotNull
    private String name;

    @NotNull
    private FooState state;
}

Having the @Patcher annotation applied to a class should generate a class called FooPatcher which would enable the following syntax:
Patch<Foo> patch = Foo.patcher()
    .state(FooState.COMPLETED)
    .patch();

And
@PatchMapping("{id}")
public Foo patch(@PathVariable int id, @RequestBody Patch<Foo> patch) {
    Foo foo = fooService.get(id);

    // NOTE : patch.isXyzChanged() should return true only if
    // FooPatcher.xyz(newXyz) was called before FooPatcher.patch() was called
    // FooPatcher.patch() should return a Patch<Foo> object

    if (patch.isNameChanged()) {
        // TODO : implementation here
    }

    if (patch.isStateChanged()) {
        // TODO : implementation here
    }

    // TODO : implementation here

    return foo;
}

Having the @Patcher annotation applied to a class should generate a class called FooPatcher

This sentence shows that this is not the job for Lombok. Lombok manipulates existing files and does not create new ones; standard annotation processors do. Luckily, writing an AP is orders of magnitude simpler than extending Lombok.
You could also use reflection, which is even simpler. It's ugly as it's a manual step and it requires the code to compile before it can be processed, but that's what I'm using a lot currently and it works pretty well.

Infact, AFAIK applying @Builder works in a similar manner.
BTW, I am not suggesting that any new files be generated, but that 2 types be generated, similar to how the Builder class is generated by the use of the @Builder annotation.

OK, I see that you want the generated Patcher to be an inner class just like the Builder. You've looked into the source code and don't you think that it's damn complicated? The Lombok's way(*) is only usable for the very most important features, which are also simple enough, so that they can be implemented in a way satisfying the majority of users (while patching seems to have many possible options).
I really don't think, your Patcher crosses the bar, but I'm not in charge of this project. I'm just saying that it looks rather complicated. It's also not perfectly clear to me, what it should exactly do. For this, something like "With Lombok" and "Vanilla Java" would be needed.

(*) The Lombok's way is necessary for enhancing existing code on-the-fly and is much more complicated than using AP or reflection. Recently, I wrote a code generator for comparing my entities field-by-field, generating and applying a "binary patch", and some other features. All in all some 400 lines of trivial code, half as much as the class you linked (note that there's an eclipse implementation, too).

I have no doubt that it is complicated, as indeed most of what's been done in Lombok is. In fact, to handle this properly, another class which implements Converter<S, T> would also be needed. Yes, I did realize that Eclipse has it's own implementation as well, although the reasons are a bit unclear to me.
I am not sure whether other people would be interested in a @Patcher annotation, which will allow only changes to an object to be captured by an object. That's why I raised this feature request to see if it generates any interest! :)
Thank you for engaging with me, and taking the time to respond. I really appreciate it.

Yes, I did realize that Eclipse has it's own implementation as well, although the reasons are a bit unclear to me.

Eclipse has it's own Java compiler, and Lombok is manipulating the abstract syntax tree (AST) generated by the compiler - thus each compiler has it's own version/type of AST - that's the reason.


feat: custom base url

It is not correct, so I reopen new PR https://github.com/jack482653/openai-slack-bot/pull/16


Unit test/ble - iot_ble_data_transfer.h API

CMock unit test suite for iot_ble_data_transfer.c/.h API

cmock + unity test suite for file in title
100% line coverage
99.4% branch coverage (don't care about one assert conditional)
Related to this pull request: https://github.com/aws/amazon-freertos/pull/1720
Checklist:

[ x] I have tested my changes. No regression in existing tests.
[ x] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

going to re-open with less commits which came from merging from upstream master