Better discord unninstalled it self

Describe the Bug
Better discord deleted it self
To Reproduce
no idea it just happened today
Expected Behavior
Screenshots
Discord Version
latest
Additional Context
Idk it litteraly deleted it self

Discord just made an update, you have to reinstall BandagedBD with the installer.

@xdjoee please try reinstalling with the latest installer and let me know if the issue persists. It's likely that you got the versioned update of Discord so BD did not delete itself, but rather it was never injected into the new version.

Piping in on this one that I got a forced update today myself and couldn't get BD and BBD to reinstall.  Ran the installer like normal, but the BBD one kept failing on one of the JS verifications and wouldn't go further.  A manual install following the instructions in the readme here worked after I unzipped the app folder, but not before (which wasn't mentioned in the manual instructions.  Seems to be working now - here's my version info if you need it!  https://cdn.discordapp.com/attachments/574799106124546069/743691340084150303/unknown.png

after I unzipped the app folder, but not before (which wasn't mentioned in the manual instructions)
Hmmm, "Download and extract this:"

D'oh. That's what I get for fixing things after a 16 hour shift.  Edited!

But also, you were using an old installer if it failed to verify one of the files. Make sure to always download the latest installer.

I agree to be honest. This is a dying mod client.


Bugfix Service Description

For some reason Puppet created the passive check details as having the incorrect service description ("AutoPostgreSQL backup"). This may be because the class and parameter both share the same name. I assumed this wouldn't cause a problem, but I've made it unique to test and ensure this fixes it.

Merge when green.


add document elaborating on how to use TLS and examples

This fixes #331.

/cc @danehans @jpeach @robscott @Miciah

@hbagdi Great job with this doc. I have a few nits.

LGTM (holding for others comments)

@hbagdi It looks like you've addressed most feedback now, is there anything still left? This generally LGTM.

@hbagdi It looks like you've addressed most feedback now, is there anything still left? This generally LGTM.

That's my understanding as well. Other than one comment from @Miciah , I'm seeking an approval so that this PR can get merged.

Thanks! Will let @danehans, @jpeach, or @Miciah add the final LGTM here.
/approve

/lgtm
Let's address https://github.com/kubernetes-sigs/service-apis/pull/391/files#r505915278 in a follow-up (I agree, the API godoc can cover this).

/lgtm


Restore compatibility with GHES 3.1

This PR fixes a few problems related to GHES compatibility.

Check whether the RUNNER_ARCH environment variable exists before accessing
Do not send status reports if the action is being used with GHES 3.1

Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.
[x] Confirm the changelog has been updated if necessary.

Also did you mean to open this from your main branch?

Good catch!  And no, it was a screw-up on my part.
I don't think there is a way to switch the source branch of a PR, so I will just have to learn my lesson and put the main branch of my fork back in order afterwards.

@adityasharad
Thank you for your feedback; I think I addressed them all.  Please take another look.  Thank you!


Add debug logs to RuleToDependency

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   92.16%   92.16%
=======================================
  Files          24       24
  Lines         740      740
=======================================
  Hits          682      682
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22b489...60568ab. Read the comment docs.


fix(deps): update dependency cypress to ^12.7.0

This PR contains the following updates:

Package
Type
Update
Change

cypress
dependencies
minor
^12.6.0 -> ^12.7.0

Release Notes

cypress-io/cypress
v12.7.0
Compare Source
Changelog: https://docs.cypress.io/guides/references/changelog#12.7.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

Let's do the same thing as the last time, as we also need to update the docker image. Can we close this one? So, afterward, I can open a new one with all changes?

@leonardomendix, yes, sure. JFYI: You can close any PR that you think is not a good fit for update. Renovate will just skip this single version. Additionally, you can always re-open PR and renovate will handle rest of the work.


python310Packages.jupyter-lsp: 1.5.1 -> 2.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.jupyter-lsp is: Multi-Language Server WebSocket proxy for your Jupyter notebook or lab server
meta.homepage for python310Packages.jupyter-lsp is: https://pypi.org/project/jupyter-lsp
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.0 with grep in /nix/store/c7agfyayfn5r9v0pa2nv7i309bis6ghp-python3.10-jupyter-lsp-2.0.0
found 2.0.0 in filename of file in /nix/store/c7agfyayfn5r9v0pa2nv7i309bis6ghp-python3.10-jupyter-lsp-2.0.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.jupyter-lsp
python310Packages.jupyterlab-lsp
python311Packages.jupyter-lsp
python311Packages.jupyterlab-lsp

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c7agfyayfn5r9v0pa2nv7i309bis6ghp-python3.10-jupyter-lsp-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.jupyter-lsp https://github.com/r-ryantm/nixpkgs/archive/b8cf3a59afec38c7ffe73a36aecfe783ac4e2380.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c7agfyayfn5r9v0pa2nv7i309bis6ghp-python3.10-jupyter-lsp-2.0.0
ls -la /nix/store/c7agfyayfn5r9v0pa2nv7i309bis6ghp-python3.10-jupyter-lsp-2.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

python310Packages.jupyter-lsp
python310Packages.jupyterlab-lsp
python311Packages.jupyter-lsp
python311Packages.jupyterlab-lsp

Maintainer pings
cc @doronbehar for testing.

Opened again at:
https://github.com/NixOS/nixpkgs/pull/221460


Ensure all data stored in the Sagemaker is securely encrypted at rest

Possible check to target the following resource

[ ] aws_sagemaker_notebook_instance

closing, tracking in spreadsheet

closing, tracking in spreadsheet


Time out at first redis search  (Timeout performing UNKNOWN (1000ms))

Hi
Using the Redis.OM to get a JSON for  the enterprise redis we get following time out (60 /1000 of the times)
Timeout performing UNKNOWN (1000ms), next: FT.SEARCH, inst: 2, qu: 0, qs: 1, aw: False, bw: Inactive, rs: ReadAsync, ws: Idle, in: 181, in-pipe: 0, out-pipe: 0, last-in: 2, cur-in: 2570, serverEndpoint: redis-.*.us-east1-mz.gcp.cloud.rlrcp.com:18600, mc: 1/1/0, mgr: 10 of 10 available, clientName: master-data-api-7ff46c85f8-fs64r(SE.Redis-v<IP_ADDRESS>26), IOCP: (Busy=0,Free=1000,Min=1,Max=1000), WORKER: (Busy=2,Free=32765,Min=1,Max=32767), POOL: (Threads=4,QueuedItems=2,CompletedItems=12349), v: <IP_ADDRESS>26 (Please take a look at this article for some common client-side issues that can cause timeouts: https://stackexchange.github.io/StackExchange.Redis/Timeouts)
at StackExchange.Redis.ConnectionMultiplexer.ExecuteSyncImpl[T](Message message, ResultProcessor`1 processor, ServerEndPoint server, T defaultValue) in /_/src/StackExchange.Redis/ConnectionMultiplexer.cs:line 1895
at Redis.OM.RedisConnection.Execute(String command, String[] args)
at Redis.OM.Searching.RedisQueryProvider.ExecuteQuery[T](Expression expression, Expression mainBooleanExpression)
at Redis.OM.Searching.RedisQueryProvider.FirstOrDefault[TResult](Expression expression)
any clue about what operation is causing the problem?

Looks like it's probably an FT.SEARCH, the UNKNOWN next FT.SEARCH is something of a misnomer here - the UNKNOWN is being logged from the command Enum in stackexchange.redis.
Are you running many searches concurrently?
How large are you setting the chunk size on the collection?

Closing this to tidy up - feel free to reopen if necessary :)


[BUG]Could not decode file

Information

Apktool Version： 2.9.3 -
Operating System： Linux or Windows -
APK From： Gaode Map -
Java Version： 21.0.2 -

apktool.bat d .\gaode.apk

apktool.bat b .\gaode\

I have discovered the problem. It only occurs when it is greater than v2.8.1

The 2nd issue is being tracked in - https://github.com/iBotPeaches/Apktool/issues/3534 so closing as duplicate.


NavigationBar Issue

Hi,
Is there any way we can hide the horizontal thin line in navigation bar. My modal sheet is a fixed one and that horizontal line urges users to drag the content.

Hi! You can do this both in modal sheet level and page level. This line will do it when showing the modal. Setting enableDrag to false will also hide it.


Data split issue in PDF

Hi, I used page breaks for page splitting. but the data in pages is getting dynamically. so, we don't know how much data is getting while generating PDF. The Text or images breaks in middle.

Hi good morning, providing more information about the above issue -
- for your reference added image -data /Image is splitting.
Can any one give advice to resolve this. Waiting for your reply. Have a nice day..!

Hey @bangararaju, yes, this is something I hope to make a solution for in the future, but I don't have a fix right now. You can see this comment for one user's solution.


Add NEII vocabs pid-proxy rewrites and corresponding tests

Rescued 29 abandoned NEII (and BOM) vocabularies.
All vocabularies have been updated with https://linked.data.gov.au/ URIs, and are re-hosted on ARDC Research Vocabularies Australia vocab hosting, with SISSVOC and LDAPI endpoints enabled.
See these scripts for details of how these Rewrites and Tests were built:
https://github.com/dcceew-bdr/neii-vocabs/blob/main/scripts/maps.py

The test suite was run, and failed. Log: https://staging-linkeddata-rewriter-nectar.ardc.edu.au/test-logs/PR127.txt

I ran the test suite before merging. As you can see, there are a number of tests for which the "from" value is not a linked.data.gov.au URL, but www.opengis.net.

Oh right, thanks. That's an issue with my test-file build script. There is one NEII vocabulary that contain Concepts originating from other source, so obviously the redirects for those should not be included in the tests. I'll push an update asap.

Okay, ready for tests to run again now.

The test suite was run, and passed. Log: https://staging-linkeddata-rewriter-nectar.ardc.edu.au/test-logs/PR127.txt

See PR #131 for the continuation.


Add documentation for schema.refresh.mode option

Documentation for PostgreSQL connector configuration updates from https://issues.jboss.org/browse/DBZ-911.

Perfect. Thanks, @ian-axelrod! Will merge once the 0.9.0.Alpha2 release is out (later today).

Applied; thanks, @ian-axelrod!


Add syntax for subfunctions

Pull Request Test Coverage Report for Build 629

19 of 25 (76.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 82.544%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/ast/function_def.js
18
24
75.0%

Totals

Change from base Build 628:
-0.06%

Covered Lines:
6552

Relevant Lines:
7723

💛  - Coveralls


Make services have a structured hierarchy

Having to manauly get the id of the class you want and then pass it to a call is cumbersome.
let response = await client.send(spaceCenter.getActiveVessel());
let vesselId = response.results[0].value;
response = await client.send(spaceCenter.vesselGetControl(vesselId));

Something like this would be better
let vessel = await client.services.spaceCenter.activeVessel;
let control = await vessel.control;
control.sas = true;

I understand this removes the ability to batch send calls.
It has already been implemented in here. I'd be happy to give it a shot and submit a pull request?

I really like the updated syntax that @lucaelin has used there. If possible I'd like the option to keep the existing client.send([...]) functionality for backwards compatibility and for the case where a person may want to send multiple requests to the server at one time. I think there may be a way to have the best of both worlds and will try some things from my side.
If you are interested you are welcome to take a look as well, I'd be happy to take a look at a PR. If it turns out it's not possible to support both ways without a breaking change, we can look at incrementing the major version number and supporting both pieces of functionality that way.

Have started a  taking a stab at it in this branch https://github.com/eXigentCoder/krpc-node/tree/direct-call-invocation

Awesome. I'll take a look at it in a few hours.

Manged to make quite a bit of headway with it, can see it working with this test: https://github.com/eXigentCoder/krpc-node/blob/direct-call-invocation/test/api/direct-invocation.js
It still needs quite a bit of a clean up, and I'm thinking of changing how the responses get returned when invoked in this way but it's late here, so going to get some sleep!

I looked it over. Looks like a good start. I could not get anything done today, but I'm thinking of popper getters and setters (instead of having to do control.get()) and a better way of obtaining the result of a direct calls (instead of having to do results[0].value).
I'll throw something in tomorrow (I'm completely free)

Hay

Getters and Setters
I replaced class.get() and class.set() with built in getters and setters. Link
Easier responses
I also changed how responses are returned when using direct invocation. Link.
Misc and Notes
The downside of using getters and setters is that you can not await for a setter call to complete. Maybe the original system of using .set() is better.
Instead of having to call response.results[0].value, a direct response call will now simply just return the value. And if response.results[0] contains an error, then that error will be thrown, though my current formatting of the error may not be very informative.

I really like the easier response option, I'm going to give some thought to if this should be the default behaviour for calling methods in the old way as well. Of course that might break existing functionality and result in a major version bump but could be controlled with a options flag when making the client. Will pull your code in a bit later today, thanks!
For a variety of reasons (see below) I'm not a fan of the ES6 class keyword and it's associated getters and setters. Another difficulty with the getters and setters is they seem to prevent you from being able to pass the associated function around for later execution. I think the downsides outway the conciseness they bring.
Why Composition is Harder with Classes
How to Fix the ES6 class keyword
JavaScript Factory Functions vs Constructor Functions vs Classes

I've been playing around with adding top level classes like Vessel and World. This way, I can do things like this (note that I'm in TypeScript)...
const world = await World.create(client); 	const vessel = await world.getActiveVessel(); 	await vessel.autoPilotSetSasMode(SASMode.StabilityAssist); 	await vessel.setTranslation(1, 1, 1, 1); 	await vessel.stage();
And some sample Vessel code is...
`export class Vessel {
static async create(client: Client, id: number) {
const [autoPilot, control] = (await client.send<Result.Id, Result.Id>(
[
spaceCenter.vesselGetAutoPilot(id),
spaceCenter.vesselGetControl(id)
]
)).results;
	const vessel = new Vessel(autoPilot.value, client, control.value, id);
	return vessel;
}

private constructor(
	private autoPilot: number,
	private client: Client,
	private control: number,
	public id: number
) { }

async setThrottle(throttle: number) {
	await this.client.send(
		spaceCenter.controlSetThrottle(this.control, throttle)
	);
}

}`
I'm liking this approach so far, as it bring a new level of class organization while retaining the ability to batch RPC calls and such. Any thoughts on this approach? I'm thinking about eventually publishing this as a separate package that depends on krpc-node, although I'm certainly open to consolidating here if applicable.

Also, awesome repo! I'm so happy I can use krpc with Node. I don't want to use C# or Lua or any of the other offerings in the standard krpc mod.

@parkerbossier So glad you are enjoying the module, and thank you for your input!
I'm just about to publish the changes for the object hierarchy and bump the major version number. After that I'm going to close this issue, would you mind taking a look at the code (Have updated examples in the README.md file) and see how this would fit in with your TS implementation?

Version 4.0.0 is now on the repo, please feel free take a look and let me know what you think!

This looks cool! I'm still definitely writing a Vessel TypeScript class to add type safe helpers for things like setting up streams and things, but it looks like it now might be worth it to write up a module type def for the new object hierarchy setup. Have you used or do you want to use TypeScript at all?

Just dropping by to say that things are MUCH EASIER now. Thanks for this :)

So glad you are enjoying the update!
I have used TypeScript briefly and I'm not a big fan, Eric Elliott has put my feelings into words already.
That being said, I'm not opposed to including the type definitions in the module, as long as I can still write code in plain JS. Ideally the definitions for the services would be generated in the same way the services themselves are generated.
If that's not possible, I think it would be great if I could put a link in the README.md to your work to help people out?


Dev

目前新增组件的时候需要手动添加index.js里面的代码，完全可以用脚本替代这一步机械并且容易遗忘的步骤。
所以添加了一个自动化生成index.js入口文件的脚本，并且更新的了package.json的scrips，ci的时候也会自动去生成index.js。

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.赵斌 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Multi-store compatibility

Questions
Answers

Description?
Compatibility with multi store, allowing to create blocks only for specified shops

Type?
new feature

BC breaks?
yes

Deprecations?
yes

Fixed ticket?
Fixes PrestaShop/Prestashop#9795.

How to test?
Make sure to read related ticket and: https://github.com/PrestaShop/PrestaShop/issues/23521 and https://github.com/PrestaShop/prestashop-specs/pull/210 to understand how it should work on multi-store - basic idea is to give people possibility to create different blocks, on different stores

:notebook: BC Break :

LinkBlockRepository has three new parameters now, [$isMultiStoreUsed, $multiStoreContext, $objectModelHandler]
LinkBlockGridFactory has one new parameter, $shopContext
LinkBlockFormDataProvider, here $shopId: '@=service("prestashop.adapter.shop.context").getContextShopID()' has been replaced with  $shopContext<EMAIL_ADDRESS>LinkBlockType has one new parameter, $isMultiStoreUsed
We introduced new ObjectModelHandler which is required for LinkBlockRepository now
We don't use position from link_block table anymore, data has been migrated to link_block_shop

We'll have to keep the bundled files views/public/form.bundle.js because the default way of deploying this module is
"When we merge branch dev into master, a cron job on addons.prestashop.com looks at this repository, take the code on master, do composer install --no-dev and then build a ZIP that is being pushed by Addons API. That is the ZIP that people will get when downloading ps_linklist from PrestaShop Back Office (that relies on Addons API) or when upgrading ps_linklist.
We can build and commit bundled JS files in another PR 😄 we just need to make sure that, when we merge dev into master, the files are there. Else the ZIP distributed by Addons API will not have them.

Hey @matks and thanks for your comments
All assets are available, I just build them in production mode and now they are minimized

Can we test this in first half of April @PrestaShop/prestashop-qa ?

Hi @kpodemski :)
Thanks for the ping, we will test it really soon ! :)

Hi @kpodemski,
I have some issues:
The spec: https://github.com/PrestaShop/prestashop-specs/blob/master/back-office/multistoregeneralspecs.md
Linklist - Add multistore header
User acceptance test

Given I am a merchant in a multistore context, when I am in the back-office and when I try to change context, if I have not saved my modifications then a modal is displayed with 2 choices: Save & Cancel.

Given the modal displayed, when I click on Save, then my modifications are saved and the context is changed for the one selected.

Given the modal displayed, when I click on Cancel, then my modifications are not saved and the context is changed for the one selected.

This UAT doesn't exist, it should be fixed in this PR or here: https://github.com/PrestaShop/PrestaShop/issues/19295?
In fact, there is no medal displayed when selecting another shop without saving changes.
Shop association block
If the merchant unselect all the checkboxes (all the shops), then an error message in red is displayed below the shop association block to inform of the obligation to have at least one shop checked: "You have to select at least one shop to associate this item with" + the save button

In this PR => I have incorrect alert:

Actions in the listings (grids): Delete action
Given I am a merchant in a multistore context, when I am deleting an element associated with several shops from the listing then I want it to be deleted if it is no longer associated with any store.

Steps to reproduce the issue:

Enable multistore context
Create a new shop & configure it
Go to BO > Design > Link list page
Select "All shops"
Click on "Add new block"
Set block name
Set Hook to unused one for example displayFooterAfter
Save

Select shop1
Delete the last created block:

Select shop2
Delete the last created block:

Select any link in the Header (All shops - Group - shop1 - shop2)
For example select "All shops"
See error: displayFooterAfter displayFooterAfter is always displayed => NOK
As described in the specs: then I want it to be deleted if it is no longer associated with any store.
I attached a screen record:
https://drive.google.com/file/d/1j17zKrb5Wk8kRanAkHy7ZnrAysd67lxO/view?usp=sharing

About this issue: https://github.com/PrestaShop/PrestaShop/issues/9795, the issue became a normal behavior as discussed with @marionf
Actions in the listings (grids): Edit action
User acceptance test Given I am a merchant in a multistore context, when I am editing an element then I want the changes I made to be applied to all stores with which the element is associated.

According to the specs, when an element is edited, the modifications made are applied to all the stores with which the element is associated.
=> This is OK with this PR:
Thank you!

Hello @khouloudbelguith

Linklist - Add multistore header

I think it should be fixed in next PR.

Shop association block

This is "to do" for me

Actions in the listings (grids): Delete action

This is "work in progress" in different PR:
https://github.com/PrestaShop/ps_linklist/pull/101
I think I'll take @sowbiba changes and put in my PR. This is "to do" for me in this PR.

Given I am a merchant in a multistore context, when I am in the back-office and when I try to change context, if I have not saved my modifications then a modal is displayed with 2 choices: Save & Cancel.

Given the modal displayed, when I click on Save, then my modifications are saved and the context is changed for the one selected.

Given the modal displayed, when I click on Cancel, then my modifications are not saved and the context is changed for the one selected.

hello ! @khouloudbelguith
This aspect of the PR has not been implemented yet, we have an issue for it, but it's not this PR's job to do it 👍
As seen with @marionf  it will be done in the beginning of 1.7.9

Hi @kpodemski,
It is ok :heavy_check_mark:
Linklist - Add multistore header

Given I am a merchant in a multistore context, when I am in a specific shop context in the back-office and if I have define a color for it, then I want to see the color of the shop selected in the header => ok
Given I am a merchant in a multistore context, when I am in a specific shop context in the back-office and if I have define a color for it, then I want to see the color of the shop selected in the header => ok
Given I am a merchant in a multistore context, when I am in "all shops" context in the back-office then I want to see the header in blue #25B9D7 => ok
Given I am a merchant in a multistore context, when I am in "all shops" context in the back-office then I want to see the header in blue #25B9D7=> ok
Given I am a merchant in a multistore context, when I am in the back-office, then I want to see the name of the context selected in the header => ok
Given I am a merchant in a multistore context, when I am in a specific shop context in the back-office and if the URL of the shop has been configured, then I want to be able to see the shop URL and click on it to see the front-office. => ok

Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has been configured, then I want to be able to search for a context.
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has not been configured, then I want to not be able to search for this context.
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has been configured, then I want to be able to select the context
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has not been configured, then I want to not be able to select this shop context.
 I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office, then I want to be able to edit the shop color and shop group color.
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office, then I want to be able to see which context is selected.
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has been configured, then I want to be able to see the shop URL and click on it to see the front-office.
Given I am a merchant in a multistore context, when I am in the multistore header context drop-down in the back-office and if the URL of the shop has not been configured, then I want to be able to configure the URL.

=> ok
8. Given I am a merchant in a multistore context, when I am in the back-office and when I try to change context, if I have not saved my modifications then a modal is displayed with 2 choices: Save & Cancel. => will be fixed in another PR
Shop association block
1.
The shop association block is displayed when you add or edit something.
The shop association block displays all groups and all shops.
Checkboxes allow to select / unselect groups and shops.
It's possible to expand / collapse the wall tree and expand / collapse each group
If you select / unselect a group, all shops of this group are selected / unselected

=> ok
2. When you add something, the shop(s) selected in the context are automatically checked in the shop association block. But it's possible to select / uncelect shops, no matter the context selected. => ok
3. If the merchant unselect all the checkboxes (all the shops), then an error message in red is displayed below the shop association block to inform of the obligation to have at least one shop checked: "You have to select at least one shop to associate this item with" + the save button => ok
Actions in the listings (grids)

Given I am a merchant in a multistore context, when I am editing an element then I want the changes I made to be applied to all stores with which the element is associated. => ok
User acceptance test Given I am a merchant in a multistore context, when I am deleting an element associated with several shops from the lisitng then I want it to be disassociated from the stores selected in the context. => ok
Given I am a merchant in a multistore context, when I am deleting an element associated with several shops from the lisitng then I want it to be deleted if it is no longer associated with any store. => ok
User acceptance test Given I am a merchant in a multistore context, when I am in a specific shop context and if the listing has a position column, then I want to be able to change the position of the element => ok

https://drive.google.com/file/d/1uOu6bPVzYWi8NysCX2SNBqU1srt0RtOm/view?usp=sharing
Without multistore context => ok (create, update, delete, change position)
Thank you!

Thanks @kpodemski


Updated: webcatalog 20.0.5

$notices:
- Updated `repo`

5ffe879c-3961-4417-bd12-0092bef2c033

Newer version of webcatalog (20.1.1) is now available in master. 86810109ea1fc55b261b58a658eb3be4689ce4e6


Slider's grabbing point should not change.

As demonstrated here: https://gouz.tinytake.com/sf/MTM0NzU5Xzg1NDk4NA
this should not be happening I guess.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

I'm not sure if that's completely addressed with #5145, however it provides a way how to set the collision only for the slider button/handle, therefore the "grabbing point" will be the handle if selected and not the whole widget area.


feat: multiple authors on reports

Description
Fix ZEN-256
Blocked by #560
Edits to database:

This is slightly complicated on how we implement it, kinda gave up for now.


Fix display only updating every other frame

AndyCap on Discord noticed that the display was only actually updating every other frame.  Not quite sure how we had missed that!
I tried various timing tweaks in DE mode but always saw that behaviour.  Switching to HV mode fixed it.

Nice one Mike, works perfectly :)


Migrating a library Godeps.json with transitive deps

In the process of adding dep support to k8s.io/client-go and friends I hit the following problem:
k8s.io/client-go depends on many packages that do not support golang/dep (= do not ship a Gopkg.toml). Some of them are not direct dependencies of k8s.io/client-go itself, i.e. client-go's Gopkg.toml cannot use constraints. At the same time, client-go is not the root package, but users depend on it using golang/dep. Hence, client-go's overrides have no effect either.
In addition, client-go's dependencies are complex enough that we want to avoid putting the burden on the users to declare dependencies themselves.

How can we provide those dependencies to the users while the packages we depend on do not support golang/dep?
Even if all dependencies support golang/dep some day, I claim that there will be situations when we cannot trust them or just have to override them for technical reasons. Imagine client-go depends on foo v1 and foo depends on bar v2.  Now bar v2.1.2 is released, but – while source code compatible – brakes a feature of foo. In client-go we would have no way to restrict to <v2.1.2.

While (1) suggests that we might want to follow overrides in dependencies until the direct dependencies ship Gopkg.toml, (2) suggests that the problem won't go away in the future with full golang/dep support throughout all packages.

This seems to be a blocker for any further work towards supporting golang/dep in k8s.io/client-go. Ideas how to work around it, are very welcome.
/cc @carolynvs @sdboyer

I wonder whether we need something like primary and secondary overrides:

the user defines primary overrides for his/her root project,
import may define secondary overrides.

Primary always trump over secondary ones. If secondary overrides conflict, the resolution is failed and the root project has to deconflict by defining primary overrides.
In other words, we have only two layers, not a complete hierarchy.

I think I just hit this vendoring k8s.io/client-go and apimachinery.  I got the correct level of client-go (4.0) and the wrong level of apimachinery (master) that it depends on.  The write up in the description here explains the problem well overall.
@lavalamp this is going to keep dep from being a reasonable contender for client-go for a while.

@deads2k if we add a native Gopkg.toml we can actually restrict the direct imports of client-go correctly (using a revision constraint). The issue here is one step further: there are (transitive) imports from our dependencies which we don't control:
E.g. client-go -> apimachinery -> docker/docker -> docker/runc. We control the first two and can create a Gopkg.toml for each. Then everything up to docker/docker is specified. But we cannot specify docker/runc, but have to trust Docker adding Gopkg.toml for their projects. If they do that one day, great.
But if we find an issue in docker/runc we cannot override that version either, but depend again on Docker doing this. If the issue is not directly relevant for docker/docker, but for our usecase of it, we are screwed as Docker will refuse (for good reason) to follow our special requirement.

oooook, buncha things here!

In addition, client-go's dependencies are complex enough that we want to avoid putting the burden on the users to declare dependencies themselves.

this is the second time this has come up as a significant point of frustration, with little feasible recourse - shurcooL/github_flavored_markdown#12 /cc @shurcooL @rtfb. i also believe that complexity-gatekeeping in this way is an important value that projects can and should be able to provide, at least in some way. so yeah, i'm bumping this up my priority list of things that really need fixing.

I wonder whether we need something like primary and secondary overrides:

i think the property you're really hunting for here is the transitive power that we give to overrides, but not constraints. this is something we could do - we could even extend the power to constraints. or have an extra value within a [[constraint]] that allows it to say, "this should apply transitively." but at least one problem is always going to be that...
hmm. actually. i've not thought this all the way through and am just spitballing, but if we make the transitivity flag explicit, then it could effectively mitigate the harms here without many of the unintended side effects described in https://gist.github.com/sdboyer/b0813bf2b9dba58a335a85092085472f. those side effects occur if we make constraints always transitive, because we can't distinguish between old, decrepit constraints and ones that are actually meaningful, which could end up creating an ecosystem with lots of "ghost" conflicts - conflicts between old constraints declared by projects that they never cleaned up. maybe those constraints are on a project that doesn't even end up in the depgraph. (i realize that sounds extra-absurd, but it could be damaging to solving efficiency if we try to "defer" mutual constraint agreement checks until a package actually shows up. not sure.)
but if a project can specify a flag that a constraint is transitive...yeah, this needs more whiteboarding, etc., but unless i'm missing something, this could work well.
this, though:

Primary always trump over secondary ones. If secondary overrides conflict, the resolution is failed and the root project has to deconflict by defining primary overrides.

at first glance, this basically just seems like an arms race to me: "they made a constraint, so we fired back with a secondary override, and now y'all need a primary override to settle the dispute." i don't think that direction is sustainable.
in any case, right now:

How can we provide those dependencies to the users while the packages we depend on do not support golang/dep?

the simplest thing you can do, for now, is to hoist up these packages as your own direct dependencies, so that you can constrain them as normal. ordinarily that means a required field in Gopkg.toml, but required is a power only afforded to the root project, so if your goal is to make things better for your dependers, then you'll need to make a dummy import somewhere:
package whatever

import _ "github.com/docker/runc"

the limitation there is that your constraint will only be activated if your dependers import the package in which that declaration exists. that may or may not be obnoxious in the k8s.io/client-go case.

but required is a power only afforded to the root project

I was excited about the described workaround until I read this sentence.
For the other idea with the imports: we have many packages in client-go (and apimachinery, and apiserver, ...) and we would have to add those artifical dummy imports everywhere. While technically feasible, this also means you get the whole dependency chain for the smallest program (go build times will shoot to the sky I fear). On the other hand, I am happy that dep ignores constraints for packages in not-imported packages.

i think the property you're really hunting for here is the transitive power that we give to overrides, but not constraints. this is something we could do - we could even extend the power to constraints. or have an extra value within a [[constraint]] that allows it to say, "this should apply transitively."

i think the property you're really hunting for here is the transitive power that we give to overrides, but not constraints. this is something we could do - we could even extend the power to constraints. or have an extra value within a [[constraint]] that allows it to say, "this should apply transitively."

Yes, this is what we look for.
I wonder what you have in mind with this flagging of transitive constraints? This sounds like my primary-vs-secondary idea that you want to change the logic for them in case of conflicts?

One thought, not to forget: transitive constraints inherited from a dependency on packages that your root package does not import, must still be ignored. Example: docker/runc above if my root package does not depend on docker/docker.
In other words, this behaviour must be different to overrides (which are unconditional by definition). So I agree, what we need something which is more like a transitive constraint than an override that is inherited from a dependency.

@deads2k I filed https://github.com/kubernetes/apimachinery/issues/23

Maybe I am missing something, but wouldn't [[constraint]] + [[override]] work even if your project doesn't use that dependency directly?
[[override]] pulls right dependencies when you are building project
[[constraint]] make any parent project to choose transitive dependencies within your constraint

[[constraint]] has no effect if your project doesn't use it. why is that?

Two options:

Use [required]=["github.com/foo"] but you can't specify the version or anything.

What is downside of respecting [constraint] of transient dependencies without using import _ hack? Would you accept patch?
BTW,  import trick doesn't work reliably, seems that you'd need to add it to every subpackage, which can possibly imported by parent project,

@redbaron Care to open a new issue? These questions are about how to use dep, and aren't related to the original post.

@redbaron the downsides of simply making [[constraint]] transitive are discussed and described extensively in this issue, including links off to further documents.
this is now the third issue where you've dropped in with questions or overly simple suggestions that are already addressed/eliminated upthread. all that does is make work for maintainers to reiterate information that was already readily available. please, do us the courtesy of reading and absorbing the information at hand before commenting.

@carolynvs:

Use [required]=["github.com/foo"] but you can't specify the version or anything.

This elevates the dependency to a direct dependency, and therefore [[constraint]]s should be respected. Or am I missing something? A bit ugly, but it should work.

ok, getting around to a more thoughtful response now.

but required is a power only afforded to the root project

I was excited about the described workaround until I read this sentence.

yknow, it doesn't actually HAVE to be root-only. requireds are almost functionally indistinguishable from imports. almost, because people can use required to pull in main packages (which is the only functional difference vs. imports, really)...which may not be great.
but i think that's actually a red herring here, anyway.

I wonder what you have in mind with this flagging of transitive constraints? This sounds like my primary-vs-secondary idea that you want to change the logic for them in case of conflicts?

in terms of the user-facing bits? i was just imagining this, in Gopkg.toml:
[[constraint]]
name = "github.com/shrimply/pibbles"
version = "^1.0.0"
transitive = true

One thought, not to forget: transitive constraints inherited from a dependency on packages that your root package does not import, must still be ignored. Example: docker/runc above if my root package does not depend on docker/docker.
In other words, this behaviour must be different to overrides (which are unconditional by definition). So I agree, what we need something which is more like a transitive constraint than an override that is inherited from a dependency.

this isn't impossible, but it's potentially quite costly. i'm gonna go a ways into the details of the solving algorithm to explain, as i've been meaning to think these things through for a while, and here's as good a place as any to write them down.
so: there are several critical issues, all of which ultimately stem from the order in which we explore the graph. if we used something more conventional, e.g. depth-first search, then a convenient side effect would be that the visit stack itself would provide the scoping we need to tell if a transitive constraint is in effect.
but, an unguided search like BFS or DFS is highly inefficient (having a much higher likelihood of costly backtracking) when compared to a visit order that takes advantage of what we know about the domain. unfortunately, using this more complex order means that the visit trail no longer tells us anything about reachability. and, because we've not had any need of transitive reachability calculations thus far within the algorithm, we don't keep that information on hand in a terribly efficient form
so, here's the first problem: the naive approach would add a check at each step in the algorithm that does a naive e.g. DFS on the backlinks we keep (the map in that previous link) in order to determine if a [[constraint]] marked transitive = true should actually be applied. so, a non-constant coefficient on the n of an O(2^n) algorithm.
the second problem is actually a generalization that entirely subsumes the first, and it's much nastier: say A declares a transitive constraint on D, and the only connecting path is A -> B -> C -> D. only once we have visited all four of those can we establish that D is reachable from A -
but it is quite conceivable that visit order would be A, D, C, B, meaning that the moment where we can first know that A's transitive constraint on D needs to come into force is when we connect B and C. neither of the already-known nodes are in sight.
this means that as long as there are any known transitive constraints where reachability has not yet been established, then every time we select any new node, we must perform a search to determine whether reachability has been established. maybe we have to do DFS for each of these, but it seems like an online connected components algorithm might be better, as we could keep it up to date at each solving step, then query it as needed. the best i've found in my brief literature searches for that are polylogarithmic for connectivity queries, updates, and deletions.
those algorithms are fully dynamic (support arbitrary add/remove of edges), though, which we may be able to skirt. clearly we need edge addition, for when we select a new project at a particular version, but we don't actually need fully dynamic edge removal - we just need to be able to "undo" an addition, which suggests we may want a persistent datastructure, as they're brilliant at undos - just keep a stack of pointers to previous versions, and let GC take care of reaping unused segments after popping.
so, if we only need edge addition, then that's "incremental connectivity". union-find is sufficient for that, and its optimum is nearly linear (in time and space, both average and worst), and it seems there are persistent union-find algorithms which claim equivalent complexity costs.
(note that this algorithm would also probably ideally be what we'd want to use for #439)
however, even assuming that we have a working algorithm in hand, there's another cost. say that we're assessing dependency X to see if it's satisfiable. if it's not, the projects "involved" in the failure will be shaped like one of two sets:

{X, Y, ...} - X, Y, and maybe a bunch of others, disagree on something - e.g., Y imports a package from X, but X doesn't have that package
{Y, Z, ...} - the addition of X reveals a disagreement between Y, Z, and maybe a bunch of others - e.g., this case here

very few of our current failures are of the latter form. in fact, the solver doesn't even really support the latter properly; the assumption is that if checks failed while visiting X, then X is part of the problem, rather than just being the messenger. i'm sure that's fixable, but it'll be a bit of complex rabbit hole on its own.

while the prospect of adding the above capabilities does excite me, even if only from an "OOOOH ALGORITHMS 🎉 🦄 🌈 " perspective, given all of the complexity involved in upholding a strict definition of transitivity, it's really worth considering whether it might be worth it to just treat them globally, in the same way we do overrides today. i think the chances of problematic conflicts here are very low, as it would require:

Some project, A, to declare a transitive constraint on C, which is brought in by B
B to stop relying on C
A to not notice (or not be updated) that B no longer pulls in on C, and leave its transitive constraint around
D to import A, and also C
A's constraint on C to just not be workable for D

it's those second and third steps that seem most unlikely to me. and we can even warn A's author about having an ineffectual constraint in the same vein as #302 - just, after a whole solution is computed. also, doing it this way admits strictly fewer possible combinations than the more nuanced, truly transitive approach, and it's always much easier to ease up later than it is to ratchet down, as we can know for certain that we won't be invalidating anyone's current solutions with the rule change.
last note - if we do get around to the more complex implementation, i might want to experiment doing it with multiple solver passes. e.g., let the first pass run with only less expensive checks that we do today, but if it fails, inspect the solution for any phantom conflicts arising from treating these constraints as global instead of truly transitive. if so, automatically re-solve, but with the heavier-duty checks.

@sttts if i do up an experimental branch where we add support for the simplified transitive-as-global approach, are you able to invest some time in exploring its utility for your use cases?

In my opinion dependencies are a set, not a graph. Figuring out the allowable versions in that set may require a graph, but from the final product; which revisions of the source code are placed in vendor/, this is a set. Why should a package being directly imported by code in my project be different to a package who's types are returned from code that I directly imported from my project?
As I said in #1231, having [[constraint]] flip between working and non working states simply because the package is directly referenced via an import statement in my project, is very hard to debug.

if i do up an experimental branch where we add support for the simplified transitive-as-global approach, are you able to invest some time in exploring its utility for your use cases?

@sdboyer finally finding time again to work on this again. Yes, such a branch would be great and I am happy to prototype the client-go use-case for that feature to validate the idea.

just wanted to update this to say that i'm still chewing on this, a lot. i'd written a whole big response, then kinda chucked it. even a simplistic, all-global implementation for experimentation purposes requires some nontrivial refactoring.
so, very much not forgotten. quite the opposite. just, a lot to mull over.

@andreic92 unfortately this is not enough. It misses all transitive dependencies. Moreover, you mix branch heads and the tagged client-go. Use branches only or tags only (e.g. via the kubernetes-1.8.x tags, which exist for all repos).

@sttts Thanks for the observation regarding the mix between branch heads and tagged entries, I fixed it.
For a demo project, this is my full Gopkg.toml:
[[constraint]]
  name = "k8s.io/apimachinery"
  version = "kubernetes-1.8.1"

[[constraint]]
  name = "k8s.io/client-go"
  version = "5.0.1"

[[override]]
  name = "k8s.io/api"
  version = "kubernetes-1.8.1"

Also see tree -L 2 vendor output:
.
├── github.com
│   ├── PuerkitoBio
│   ├── davecgh
│   ├── emicklei
│   ├── ghodss
│   ├── go-openapi
│   ├── gogo
│   ├── golang
│   ├── google
│   ├── googleapis
│   ├── gregjones
│   ├── howeyc
│   ├── imdario
│   ├── json-iterator
│   ├── juju
│   ├── mailru
│   ├── modern-go
│   ├── petar
│   ├── peterbourgon
│   └── spf13
├── golang.org
│   └── x
├── gopkg.in
│   ├── inf.v0
│   └── yaml.v2
└── k8s.io
    ├── api
    ├── apimachinery
    ├── client-go
    └── kube-openapi

As can be seen, the transitive dependencies seems to be in there, but the problem that is visible in Gopkg.lock is that the revision attribute for the transitive dependencies are not the same with the ones required by<EMAIL_ADDRESS>I guess that everything is working for me because there are no breaking changes for the fetched dependencies, maybe.
Maybe, adding [[override]] stanzas for the missmatched dependencies would work?

I guess that everything is working for me because there are no breaking changes for the fetched dependencies, maybe.

Yes, it's working reasonably well if you have a client-go that is not too old. But we had problems before that transitive dependencies suddenly broke our code, and people newly vendoring client-go were running into issues. It's an unfortunate situtation, but we cannot do much about it.

I have an open PR to add transitive constraints to dep, the maintainers are all committed to getting that feature in soon, along with preferred versions. So hopefully we can close this gap in dep but yes for now there's no way for the k8's client to protect people from this. 😢


replace picasso library to universal image loader library

this option only work with image url

It's not a good idea to totally replace Picasso with Universal Image Loader,  cause there are lots of developers are using this library.
A good solution is support multiple image load method, for example, when I call a method named setImageLoadEngine(Engine.Picasso| Engine.ImageLoader), it uses the diffirent image load engine.

ok.
please remove this pull request, I will try do that :-)

There is no need to close this PULL, every time you push your own code, it will be automatically sync here. :-D

I agree that:  It's not a good idea to totally replace Picasso with Universal Image Loader, cause there are lots of developers are using this library.
A good solution is support multiple image load method, for example, when I call a method named setImageLoadEngine(Engine.Picasso| Engine.ImageLoader), it uses the diffirent image load engine.


Implement Dashboards

https://github.com/GeoNode/geonode-mapstore-client/issues/266

duplicate of https://github.com/geosolutions-it/nexus-geonode/issues/300


Bug-fix / Join Output Orderings

Which issue does this PR close?

Closes #.
Rationale for this change

Output orderings and ordering equivalence classes of joins may result in suboptimal ways. There are some minor fixes to clean them up.
What changes are included in this PR?

A few util functions are added to normalize orderings and matching sort exprs with columns.
Are these changes tested?

Are there any user-facing changes?

Are the existing join operators "advanced" enough to let us write end-to-end SQL tests? If yes, can we add such a test? Otherwise, we can add such a test once we have a join operator that enables us to write such tests.

I agree sql level tests would be ideal -- let's try and add them as a follow on PR. I can file a ticket to track this if that is helpful


Fix validate exit

I've noticed that with #92 (released with 2.13.0) we introduced a bug where the CLI dosn't exit the process correctly anymore. This was due to wrapping validate() in a try/catch statement although neither validate() or validateMessage() actually throws.
To reproduce:

Install validate-commit-msg v2.13.0
attempt to commit locally with a non-valid msg
=> You'll see the error message on the CLI, but the commit will still happen anyway (check git log)

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #104   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         126    126
=====================================
  Hits          126    126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d23bbc...077d8b3. Read the comment docs.

Ah, another bug here is the wrong status code was being returned too for invalid states. Good catch.


Bump to v0.37.2

Waiting for:

~https://github.com/FuelLabs/sway/pull/4488~ we can get this later on it is not urgent.

This release includes quite a few breaking changes (including Mohammad's storage key refactor) and likely should be rolled out under a new minor release, 0.38.0.
I'm unsure if we have the ability to yank 0.37.2, but if we can we should and re-release as 0.38.0 to avoid mysteriously breaking things for users who d epend on 0.37.1.

It looks like yanking might not be an option, so we might need to:

Make a branch from 0.37.2.
Create a new patch release from this branch for 0.37.3.
Create a new minor release with these changes as 0.38.0.


Made Mailbox more Idiomatic for Zig.

Updated close() to align w/ Zig Zen.
Updated pointer dereferences.
Updated the README.

super
thanks a lot

Glad to help!


Forge roaster up

[merge]

Code not merged because @oscerd (Andrea Cosentino) is not in the Admin list.

ping @davsclaus

ok to test

[merge]


UCP: Reduce output when using pd-ctl config show

Description
As we add more and more parameter into the configuration, the output of pd-ctl config show is more and more, e.g.
» config show
{
  "replication": {
    "enable-placement-rules": "false",
    "location-labels": "",
    "max-replicas": 3,
    "strictly-match-label": "false"
  },
  "schedule": {
    "enable-cross-table-merge": "false",
    "enable-debug-metrics": "false",
    "enable-location-replacement": "true",
    "enable-make-up-replica": "true",
    "enable-one-way-merge": "false",
    "enable-remove-down-replica": "true",
    "enable-remove-extra-replica": "true",
    "enable-replace-offline-replica": "true",
    "high-space-ratio": 0.6,
    "hot-region-cache-hits-threshold": 3,
    "hot-region-schedule-limit": 4,
    "leader-schedule-limit": 4,
    "leader-schedule-policy": "count",
    "low-space-ratio": 0.8,
    "max-merge-region-keys": 200000,
    "max-merge-region-size": 20,
    "max-pending-peer-count": 16,
    "max-snapshot-count": 3,
    "max-store-down-time": "30m0s",
    "merge-schedule-limit": 8,
    "patrol-region-interval": "100ms",
    "region-schedule-limit": 2048,
    "replica-schedule-limit": 64,
    "scheduler-max-waiting-operator": 5,
    "schedulers-payload": {
      "balance-hot-region-scheduler": "null",
      "balance-leader-scheduler": "{\"name\":\"balance-leader-scheduler\",\"ranges\":[{\"start-key\":\"\",\"end-key\":\"\"}]}",
      "balance-region-scheduler": "{\"name\":\"balance-region-scheduler\",\"ranges\":[{\"start-key\":\"\",\"end-key\":\"\"}]}",
      "label-scheduler": "{\"name\":\"label-scheduler\",\"ranges\":[{\"start-key\":\"\",\"end-key\":\"\"}]}"
    },
    "schedulers-v2": [
      {
        "args": null,
        "args-payload": "",
        "disable": false,
        "type": "balance-region"
      },
      {
        "args": null,
        "args-payload": "",
        "disable": false,
        "type": "balance-leader"
      },
      {
        "args": null,
        "args-payload": "",
        "disable": false,
        "type": "hot-region"
      },
      {
        "args": null,
        "args-payload": "",
        "disable": false,
        "type": "label"
      }
    ],
    "split-merge-interval": "1h0m0s",
    "store-balance-rate": 15,
    "store-limit-mode": "manual",
    "tolerant-size-ratio": 0
  }
}

We need to reduce it in order to improve the usability.
Score

936

Recommended Skills

Golang

Learning Materials

PD Control User Guide

Can we move scheduler related configs into an individual config rather than put it into the schedule part? @disksing @nolouch

Does this is contained https://github.com/pingcap/pd/issues/2180?

Yes, I think so.

I thinks close this one.


Remove subclassed UpdateAdminProfile

CumulusCI 2.0.10 contains an enhanced update_admin_profile task which allows specifying record type visibility options in the cumulusci.yml.  This branch removes the previous implementation which required a Python subclass to implement this functionality.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

@jlantz this caused a failure in the person-account beta build: https://mrbelvedereci.herokuapp.com/builds/36784


utils: Fix bad conversion for enumerations

When an interface contains both a string and an enumeration (or multiple
of each), the variant visitor matches the wrong make specialization.
This is because a string is convertible to variant<string, enum, ...>.
Fix this by moving out all conversions from a string to the template
specialization that first checks if the string can be converted to
an enumeration.
This still leaves a hole where trying to set a fully-qualified
enumeration name to a string property will fail, but I am not sure what
to do about that within the current PIM framework.
Tested: Tested Notify with enumerations on interfaces that contain both
a string and an enumeration.
Signed-off-by: Santosh Puranik<EMAIL_ADDRESS>

Can one of the admins verify this patch?

This fixes SW552194


BPMN Error and Event Subprocess Support

Description
Hi,
According to the documentation, the Error and Event Subprocess components are not supported.
Is this up to date ?
If yes, is there any plans to support those components soon ? if yes, when ?
Thanks
Implementation ideas
No response

i am using BPMN Errors, and they are working like a charm.
Service can throw a BPMN Error with :
throw new WorkItemExecutionException(openAiErrorCode, message, exception);


smlnj: 110.95 -> 110.99.6

Description of changes
Standard ML of New Jersey is updated to 110.99.5.
Change log can be found on the smlnj.org website.
Outside of updating hashes, this version bump allows the removal of the heap2exec.diff file, since the build system issue was fixed. It also requires a slightly different regex to pass to sed during patching.
The compiler binary and libraries have been extensively tested. The other binaries all run but have not yet been as extensively tested.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@thoughtpolice Can this be merged?

@thoughtpolice Can this be merged?

No, there are merge conflicts.

One remaining issue is the use of a timestamp in the build process.
There is a call to the SML function Time.now during build, which is output on startup. This means that the build is currently not fully reproducible.
If this is an issue, I could try to add a patch that fixes the date of the version release.

One remaining issue is the use of a timestamp in the build process. There is a call to the SML function Time.now during build, which is output on startup. This means that the build is currently not fully reproducible.
If this is an issue, I could try to add a patch that fixes the date of the version release.

I'm not the maintainer but I think adding a small patch to fix this would be the best. If it must be a time/date it's typically the unix epoch and that is overall pretty straightforwardly clear where it's coming from / if it's in nixpkgs the user can check the path to determine what build it was from nonetheless.

Although the call to Time.now is in a specific file (base/system/smlnj/internal/version.template), that code is ran by the boot file which is downloaded as binary. I can try to get a change made upstream but it will take time, and the existing nixpkgs derivation has this same issue, so I do not think it should block merging.

I got verbal confirmation that this will be fixed in the next upstream release. I think it doesn't make sense to implement the patch in Nix since it cannot be done via patch, especially since it already exists in the current nixpkgs version.

<IP_ADDRESS> fixes a bug, but also changes removes the build-time dependency. This should fix the non-reproducibility issue.

Should be squashed now. Do I need to document the changelog, or link to the changelog on smlnj.org anywhere?

No. If you write an update script so that updates are automatic, then the @r-ryantm can normally do the links and stuff for you. But I wouldn't worry about it for now.

Should be fixed now.
Regarding the update script, I have a Perl script that I can use to manually update the nix file, but unfortunately there aren't many examples of packages with update scripts which have multiple hashes to update. Can take a look here if that's something worthwhile to add, though with SML/NJ only updating once a month it's fine to keep it manual for now.


CsvListReader reads unusual final line of 906 bytes after EOF

I have a simple CSV file as follows:
name, age, weight
John, 22, 150

I have code that reads this csv as follows:
InputStream myFile = ...;
ICsvListReader csvReader = new CsvListReader(
   new InputStreamReader(myFile),
   CsvPreference.STANDARD_PREFERENCE);

int rowNum = 0;
List<String> row;
while ((row = csvReader.read()) != null) {
   System.out.println("Got row " + rowNum++);
}

When I run it, I get the following output:
Got row 1
Got row 2
Got row 3

Obviously, there's not actually a third row in this file. I dug super deep, and it looks like LinNumberReader, used by AbstractTokenizer.readLine(), returns what's left of its buffer before finally reporting EOF. I took a look, and the "row" I get for the third invocation is a 1-element List whose String value is a bunch of unicode \000 characters - one for 1024 minus the characters in my file. E.g, if my file, in total, has 118 characters, this weird value has exactly 906 blanks in it.
This doesn't seem correct. I'd expect not to be told there's a third row of leftover buffer-data when, in fact, there is no row at all.

My exact file content is a little bit different. The above is an example. My particular file has what looks to be some kind of cruft at the end. I'm checking to see if that might be causing the issue.

After further review of the exact characters in my file, I have discounted my "cruft" there. There isn't any extra data after the final newline in my file.

After further investigation, a filesystem abstraction I have in play, which I had excluded from my initial investigation, proved to be the culprit. My files are not being correctly written to disk in the form I give it; additional bytes are getting written that weren't in the original file.
Attempts to reproduce w/o this abstraction proved fruitless. The API is working as-designed.


introduce build(nodes=list)

Wow that was fast :). I think that will really helpful.
Does project.build() then replace the former project.run(repro=False)?
>     project.build(nodes=[node_1, node_2])

>     project.repro()

In the example above one would use project.run(nodes=[node_1, node_2]) instead? Or is there not such a strict distinction here? Would be nice is build() replaces run(repro=False) because I think its a bit counterintuitive.


How can I use CpModel  to  make three 1s appear in  a 1D array ?

I want three 1s to appear in the shift array，I wrote the following code：
model = cp_model.CpModel()
solver = cp_model.CpSolver()
shifts = {}
for i in range(5):
shifts[(i)] = model.NewIntVar(0, 3, "shifts(%i)" % i)
for i in range(5):
model.Add(sum([shifts[(i)]==1  for i in range(5) ]) == 3)
solver = cp_model.CpSolver()
status = solver.Solve(model)
print("status:",status)
for i in range(5):
print(solver.Value(shifts[(i)]))
But it return:
TypeError: unsupported operand type(s) for +: 'int' and 'BoundedLinearExpression'
Can anyboday help me ,please!

Please use the mailing list.


Deploy production instance of Find MOJ data

Part of https://github.com/ministryofjustice/find-moj-data/issues/494
Once we have datahub running in prod, we can deploy Find MOJ data.

Set up secrets & environment variables for prod
Add prod to CI/CD workflow
Create a release in github (come up with a version number & release notes)
Creating a GH release approves the prod deployment
Deploy it

CP Prod Namespace PR

Agreed to proceed with the workflow approaches laid out in this ticket -

Workflow update required


[BUG] with date of birth

Describe the bug

When download the CV
the date of birth in the PDF file is shown the day before. conditionally birthday June 28. a shows 27
Product Flavor

[ ] Managed (https://rxresu.me)
[ ] Self Hosted

To Reproduce

Go to 'the CV editor'
Click on 'date of birth'
Scroll down to 'the button download pdf'
See error in date of birth

Expected behavior

The correct date
Screenshots

Desktop (please complete the following information):

OS:  Window
Browser  Chrome
Version  103.0.5060.114

Additional context

This should be fixed as of v3.5.0 :)


ratbagctl (from libratbag) fails to run

Describe the bug
it's impossible to use ratbagctl due to an import error:
[user@system:~]$ ratbagctl info
Traceback (most recent call last):
  File "/nix/store/4x1mm4cm6a891yyl1a9ky08fxril160h-libratbag-0.17/bin/ratbagctl", line 36, in <module>
    from gi.repository import Gio, GLib, GObject
  File "/nix/store/czg030czd0sc7vmwjf71afhd9zskf5n2-python3-3.11.9-env/lib/python3.11/site-packages/gi/importer.py", line 133, in create_module
    raise ImportError('cannot import name %s, '
ImportError: cannot import name Gio, introspection typelib not found

[user@system:~]$

Steps To Reproduce
Steps to reproduce the behavior:

set services.ratbagd.enable = true;
try to run eg ratbagctl info

Expected behavior
ratbagctl "shows something". (i.e. current mouse hardware/mapping etc.)
Screenshots
(no gui, cli only)
Additional context
I (may) need ratbagctl because it has infos/options that are not yet fully implemented in piper
Notify maintainers
@mvnetbiz
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.11 (Vicuña), 24.11.20240529.ad57eef`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/nix/store/qgbn0imyridkb9527v6gnv6z3jzzprb9-source`

Add a :+1: reaction to issues you find important.

https://github.com/NixOS/nixpkgs/pull/316717


org.jsoup.select.Selector Javadoc typo: "td:lt(3) finds the first 2 cells of each row"

"td:lt(3) finds the first 2 cells of each row" should be either "td:lt(2) finds the first 2 cells of each row" or "td:lt(3) finds the first 3 cells of each row"

Thanks, fixed


Source file ostream operators

Many src files only contain a single ostream<< operator overload, look into how we manage src a larger number of src files.
Recommended:
Merge these file contents into a single larger cpp file for faster compiling.

Suggest to make this issue about faster compilation more generally.
That means

Measure the current compilation performance and get some statistics (how many compilation units do we have)
Look at opportunities to merge different compilation units; e.g., fold simple cpp files into headers and combine conceptually related compilation units together, if they make sense.


Illustrate call to ppcg_schedule_node_can_cross_tile

Subsumes #26 which has gone stale, this was easier for me to rebase on ntv_dev

works for me


Add tests which invoke hub methods with different type param

Add tests which invoke hub methods:
o   Without parameters
o   With primitive type parameters
o   With complex type parameters

Hi @Xiaohongt, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

:sheep::it:


Time fields should have a calendar option

All fields that allow the inputting of dates and times should allow the option of popping up a calendar to enter the date.

There are lots of ways to enter a date, and no one has ever asked for a calendar pop-up. There's really no point to this.


Support using trouble as a BLE stack

We should still support bleps but supporting Trouble would be a good thing to do. We probably should also add an example using it

+1 to this - trouble seems like the way forward to having a standardised ble stack for embedded rust.

Resolved via #1971


More than 25k error logs while editing tileset

Godot version
4.0.stable.mono
System information
MacOS
Issue description

Steps to reproduce

The error logs will appear when I click this.
Minimal reproduction project
BaseTileMap.tscn.zip

Minimal reproduction project
BaseTileMap.tscn.zip

This contains only BaseTileMap.tscn file, without any of its dependences. It fails to be opened. Please upload a proper project.


Support reading nlog.config from Android assets folder

Fixes https://github.com/NLog/NLog/issues/1172
Example call:
LogManager.Configuration = new XmlLoggingConfiguration("assets/nlog.config");

Current coverage is 74.02%

Merging #1212 into master will decrease coverage by -0.03% as of 2d0f0c3

@@            master   #1212   diff @@
======================================
  Files          265     265
  Stmts        15299   15306     +7
  Branches      1681    1682     +1
  Methods          0       0
======================================
+ Hit          11329   11330     +1
- Partial        417     421     +4
- Missed        3553    3555     +2

Review entire Coverage Diff as of 2d0f0c3

Uncovered Suggestions

+0.08% via ...argets/FileTarget.cs#1722...1734
+0.08% via ...gingConfiguration.cs#282...293
+0.08% via ...gingConfiguration.cs#244...255
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Problem with defining global service.

I am tying to make service, which would be visible without importing in component.
My bootstrap function:
export function main(initialHmrState?: any): Promise<any> {
  console.log(APP_PROVIDERS);
  return bootstrap(App, [
    ...PLATFORM_PROVIDERS,
    ...ENV_PROVIDERS,
    ...APP_PROVIDERS
  ])
  .then(decorateComponentRef)
  .catch(err => console.error(err));
}

App providers definition:
export * from './app.component';
export * from './user.state';
export * from './app.service';

import { UserState } from './user.state';
import { AppState } from './app.service';

// Application wide providers
export const APP_PROVIDERS = [
  UserState,
  AppState
];

And i can not call it in components constructor
constructor( private userState: UserState ) {}
How i can fix my problem?

you still need to do import in your file like this:
import { UserState } from './user.state';


Laboratory work #1, Anna Azimkova - 22FPL1

import style checks make me so upset......

what can i do with the detect_language ?

i guess i need help with def detect_language i do not know how to fix it :(

If you still have questions, please ask in the group chat and tag me.


Typo in repo's description

...live in a terminl -> ...live in a *terminal* 😅

Oh Thank you. :heart:
I thought I can trust the spell check in GitHub with Firefox. Apparently I was wrong :smile:
I fixed it and added the link to crates.io


Manifest formatter doesn't format manifest file

Running forc fmt doesn't format the manifest file, even though forc fmt --check will report incorrect formatting.

That's on me, I thought I had tested this…


Juniper SRX dns-name fqdn address-book generated configuration missing suffix index number

After testing aerleon srx dns-name support, notice the generated configuration was not correct.
aerleon==1.6.0
---
networks:
  Mgmt_Mgmt-Net_0:
    values:
      - address: <IP_ADDRESS>/24
        comment:
  Mgmt_Mgmt-Net:
    values:
      - Mgmt_Mgmt-Net_0
  Pub_Mgmt-Name_0:
    values:
      - address: <IP_ADDRESS>/23
        comment:
  Pub_Mgmt-Name_FQDN_0:
    values:
      - fqdn: pubtest1.jimbo.net
        comment: pubtest1
  Pub_Mgmt-Name_FQDN_1:
    values:
      - fqdn: pubtest2.jimbo.net
        comment: pubtest2
  Pub_Mgmt-Name:
    values:
      - Pub_Mgmt-Name_0
  Pub_Mgmt-Name_FQDN:
    values:
      - Pub_Mgmt-Name_FQDN_0
      - Pub_Mgmt-Name_FQDN_1

The following networks.yaml file after running aerleon config rendered generate the following output
        security-zone Pub {
            replace: address-book {
                address Pub_Mgmt-Name_0 <IP_ADDRESS>/23;
                address-set Pub_Mgmt-Name {
                    address Pub_Mgmt-Name_0;
                }
                address Pub_Mgmt-Name_FQDN_FQDN_0 {
                    dns-name pubtest1.jimbo.net;
                }
                address Pub_Mgmt-Name_FQDN_FQDN_0 {>>>>>> should be Pub_Mgmt-Name_FQDN_FQDN_1
                    dns-name pubtest2.jimbo.net;
                }
                address-set Pub_Mgmt-Name_FQDN_FQDN {
                    address Pub_Mgmt-Name_FQDN_FQDN_0;
                    address Pub_Mgmt-Name_FQDN_FQDN_1;
                }
            }
        }

after looking the code, there's a missing counter += 1 inside the condition that generate the configuration on junipersrx.py
https://github.com/aerleon/aerleon/blob/18e6044ee6bc181fb08cdcb799bc634083840e9c/aerleon/lib/junipersrx.py#L703
    def _GenerateAddresses(self, token: str, ips, fqdns):
        target = IndentList(self.INDENT)
        counter = 0
        ips = nacaddr.SortAddrList(ips)
        ips = nacaddr.CollapseAddrList(ips)
        for ip in ips:
            target.IndentAppend(4, 'address ' + token + '_' + str(counter) + ' ' + str(ip) + ';')
            counter += 1
        for fqdn in fqdns:
            target.IndentAppend(4, f'address {token}_{counter} {{')
            target.IndentAppend(5, f'dns-name {fqdn.fqdn};')
            target.IndentAppend(4, f'}}')
            # counter += 1   After adding this line, the generated configuration match the yaml
        return target

output after adding the counter +=1 line
        security-zone Pub {
            replace: address-book {
                address Pub_Mgmt-Name_0 <IP_ADDRESS>/23;
                address-set Pub_Mgmt-Name {
                    address Pub_Mgmt-Name_0;
                }
                address Pub_Mgmt-Name_FQDN_FQDN_0 {
                    dns-name pubtest1.jimbo.net;
                }
                address Pub_Mgmt-Name_FQDN_FQDN_1 {
                    dns-name pubtest2.jimbo.net;
                }
                address-set Pub_Mgmt-Name_FQDN_FQDN {
                    address Pub_Mgmt-Name_FQDN_FQDN_0;
                    address Pub_Mgmt-Name_FQDN_FQDN_1;
                }
            }
        }

After having a quick chat with @ankenyr, I will submit a PR with the changes required and testing to cover it.

Any chance you had some time to work on this @jbotello7381 ?

Any chance you had some time to work on this @jbotello7381 ?

Nope, need to finish few projects first.   Is in my aspirational todo list :) at the moment


Revert to TRANSIENT_FAILURE during backoff

Fix https://github.com/grpc/grpc/issues/16239. This reverts part of https://github.com/grpc/grpc/pull/16076.
https://github.com/grpc/grpc/pull/16076 fixed a test flake by setting the connectivity during backoff to CONNECTING. But that makes it hard to detect the situation that all the subchannels in RR have failed and we should set the RR to TRANSIENT_FAILURE.
So this PR reverts that connectivity change. To fix the test flake above, this PR depends on https://github.com/grpc/grpc/pull/16306.

****************************************************************

libgrpc.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.0%    +336 [None]                                                                               +1.16Ki  +0.0%
      +0.0%    +304 [Unmapped]                                                                           +1.12Ki  +0.0%
       +17%      +8 vtable for grpc_core::(anonymous namespace)::RoundRobin::RoundRobinSubchannelData         +8   +17%
       +17%      +8 vtable for grpc_core::(anonymous namespace)::PickFirst::PickFirstSubchannelData           +8   +17%
       +17%      +8 vtable for grpc_core::SubchannelData<grpc_core::(anonymous namespace)::RoundRobin::R      +8   +17%
       +17%      +8 vtable for grpc_core::SubchannelData<grpc_core::(anonymous namespace)::PickFirst::Pi      +8   +17%
  +4.3%    +544 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  +544  +4.3%
      [NEW]    +812 grpc_core::(anonymous namespace)::PickFirst::PickFirstSubchannelData::ProcessUnselec    +812  [NEW]
      [NEW]    +200 grpc_core::(anonymous namespace)::PickFirst::PickFirstSubchannelData::StartConnectiv    +200  [NEW]
      +9.0%     +26 [Unmapped]                                                                               +26  +9.0%
      +2.5%      +8 grpc_core::SubchannelData<grpc_core::(anonymous namespace)::PickFirst::PickFirstSubc      +8  +2.5%

 -------------- SHRINKING                                                                            --------------
  -0.2%     -16 src/core/ext/filters/client_channel/subchannel.cc                                        -16  -0.2%
     -12.0%     -47 maybe_start_connecting_locked                                                            -47 -12.0%

  +0.1%    +864 TOTAL                                                                                +1.67Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,951,548      Total (>)      1,950,932

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
 3,617,434       Core (>)      3,615,418

10,671,345      Total (>)     10,669,329

[microbenchmarks] No significant performance differences

This looks great!  I'll wait for the dependent PR to be merged before approving.

https://github.com/grpc/grpc/pull/16306 has been merged. This is ready for review again. Thanks!

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,953,114      Total (>)      1,952,998

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
 3,618,710       Core (>)      3,617,710

10,665,792      Total (>)     10,664,800

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,952,962      Total (<)      1,952,998

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,664,801      Total (<)     10,664,803

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++

 -------------- SHRINKING                                         --------------
  -0.2%     -16 src/core/ext/filters/client_channel/subchannel.cc     -16  -0.2%
     -12.0%     -47 maybe_start_connecting_locked                         -47 -12.0%

 -+-+-+-+-+-+-+ MIXED                                             +-+-+-+-+-+-+-
  +0.0%     +16 [None]                                               -320  -0.0%

  [ = ]       0 TOTAL                                                -336  -0.0%

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,952,962      Total (<)      1,952,998

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,664,798      Total (<)     10,664,804

 No significant differences in binary sizes

Basic Tests MacOS [dbg] (internal CI): https://github.com/grpc/grpc/issues/16392
Basic Tests MacOS [opt] (internal CI): https://github.com/grpc/grpc/issues/16392
Basic Tests Multi-language Linux (internal CI): https://github.com/grpc/grpc/issues/16392
Basic Tests Windows [dbg] (internal CI): https://github.com/grpc/grpc/issues/14128


Cask request: Mozilla Firefox 57.0

Cask details
Mozilla Firefox 57.0 Final is available !
Name: Firefox
Homepage:  https://www.mozilla.org/en-US/firefox/new/
Download URL: https://archive.mozilla.org/pub/firefox/releases/57.0/
Description: Mozilla Firefox 57.0 Final is available !

#40700


fix(chore): update usage information

Presently, the usage information shown as part of the help text lacks reference to options.
Present state
Usage: create-nuxt-app [out-dir]

Updated To
Usage: create-nuxt-app [out-dir] [options]

cc @clarkdo


exec_doc breaks widgets

If users update widgets with the exec_doc directive, the widget "view" is updated (in the cell output), but the old widget "state" is used (in notebook metadata). This refreshes widget state using ipywidgets.Widget.get_manager_state.
See Tyler's comment for context. cc @tylere

Hmm I just realised that this always overwrites existing widget state (e.g. if a user saved it in their IDE). So if your exec_show_docs doesn't render any new widgets, all of your existing widgets will break...

One solution would be to merge the exec_show_docs state dict with any existing one in the nb, since the state dict is keyed on widget UID.. Will update the PR with that

Do you think it might make sense to add a test for this?


[support] app doesn't seem to be responding to settings.yml changes

I had the settings app enabled on my one repo (and then globally, just to be sure), and pushing updates didn't seem to have any effect. Am I doing this right?
https://github.com/patcon/sample-civictech-app

Yep, I did -- both via PR and directly. Real odd.
Can anyone reproduce?

[ ] fork repo to personal account
[ ] enable settings plugin on repo
[ ] add a newline in settings.yml via GitHub UI

Just tried the above again (minus the fork), and no dice.

let me debug and get back to you.

I found it. Problem you are facing is beacuse of description. Try removing :balloon: . Try it @patcon .

Its because after description :  the yaml file is reading :ballon: as another key and hence not following format of yaml file.


z.nullable does not use schema references

I have a schema like this:
  parentVenue: z.nullable(ProfileReferenceDTOSchema).openapi({
    description:
      'A venue to which this venue belongs.\n\nFor example, the theoretical venue "Dance Palace" may be the parent venue of the venues "Indoors" and "Outdoors"',
  }),
  childVenues: z.array(ProfileReferenceDTOSchema).openapi({
    description:
      'The venues that belong to this venue.\n\nFor example, the theoretical venues "Indoors" and "Outdoors" may be child venues of the venue "Dance Palace"',
  }),

Which causes an annoying difference when rendered:

It seems the reason for this is that the openapi spec generated for z.array uses
"type": "array",
"items": {
  "$ref": "#/components/schemas/profiles.ProfileReferenceDTO"
},

whereas the openapi spec generated for z.nullable does not use $ref (tested for openapi 3.0.3 and 3.1.0):
"type": "object",
"nullable": true,
"properties": {
  "id": { "type": "string", "format": "uuid" },
  "name": { "type": "string" },
  "type": {
    "type": "string",
    "enum": ["organization", "individual", "venue"]
  },
  "images": {
    "$ref": "#/components/schemas/storage.ImageDTO"
  }
}

Would it be possible to get z.nullable to generate a $ref as well? Perhaps using oneOf?

@FelixZY thanks for bringing this up. nullables are tricky since they behave differently based on the chosen OpenApi version (3.0 or 3.1). I'll try and take a look asap, but right now we are hoping to release a new major version and I'll probably have to prioritize the feature requests of the other open issues slightly higher. Sorry for that, and I'll come back to you as soon as I can. In the mean time feel free to give it a go and open a PR yourself.

@FelixZY I took a look at your example. And actually we already support that. The result has allOf. However we've only currently done the required support on schema.nullable() and not on z.nullable(schema). I'll open a PR soon but you can also fix this on your end (functionally there shouldn't be any difference for you).

This turned out to be impossible with the current way of implementing such methods. Because of that I've just updated the README.md file with a note for it (that schema.nullable() should be used instead)


Add permissions to gate.yml

PRs now fail like this:

Added permissions based on the example here:
https://github.com/dorny/test-reporter#recommended-setup-for-public-repositories
Updated to v15

coverage: 99.242%. remained the same
when pulling 4e545971d7fd67812487057ac407ecacf323ba4e on users/alexpeck/resinaccess
into 38d4b037ebfc634efed6cfaf1ceeb0147fbc555a on main.


estypes has no exported member SnapshotInfo

This is defined (https://github.com/elastic/elasticsearch-specification/blob/main/specification/snapshot/_types/SnapshotInfo.ts) but it's not available on estypes.

Hello! It's defined, but the exported name is slightly different: SnapshotSnapshotInfo.


Enable inline code in  tags

When writing expandable blocks via  and  tags, it's currently not possible to use inlince code. Fro example in this case, User and @@unique should be written as inline code:

For example like this:
Expand for example <InlineCode>User</InlineCode> model with an <InlineCode>@@id</InlineCode> block

@nikolasburk This is already available in the docs. You can use:
Expand for example <inlineCode>User</inlineCode> model with an <inlineCode>@@id</inlineCode> block

Ah that's great to know, thanks 👍


chore(install): reintroduce single install script

Our installation process can change rapidly. I think it helps if we have a single script to run that we ensure is up-to-date for all.
This PR reintroduces a single install script, which, in particular:

Checks for the proper version of node (some of us develop with node
v4 on other sites, and it is too easy to forget to switch to v5 for
angular.io).
Applies the patch (that is necessary to support harp compilation of
Dart API pages).

@filipesilva @Foxandxss @wardbell @kwalrath : ready for review. Note that I have not touched the travis config.

lgtm.
@chalin you mentioned something about the dart compilation, is it possible to run dart specific tasks via the CI at the moment? I tried to cover the ts/js ones I know of, but I don't know anything about the dart workflow for docs.

is it possible to run dart specific tasks via the CI at the moment?

Not at the moment. That is part of what I will be working on next.