Feature player filter

This PR introduces a filter function for the player.
Purpose of Change

To allow the user to preview the audio more precisely.

For audio recording use cases, the user can focus on or remove unwanted noise.
For music listening use cases, the user can focus on a specific instrument or vocal.

Changes

Added bi-quad filters for playback audio path.

The added filters are only inserted into the path when enabled.

Added PlayerSettingsComponent to set the filter enable and the cutoff frequencies.

The user can enable the high-pass and low-pass filters individually.
The user can also set the cutoff frequencies.
By selecting the "match to spectrogram frequency range" option, the cutoff frequencies automatically match the analyzer frequency range.

The user can select the frequency range to preview visually by selecting a range on the spectrogram.

Tests

I've confirmed the changes visually, and tested the UI operations as well.
Some tests have been added to test the new component and settings.
The changes conform to all existing tests.

Notes

This PR includes the fix of const declaration which I was mentioned in #57.
I replaced some "playerSettingService" to "playerSettingsService" for consistency.

@sukumo28 I also fixed the code in this PR. thanks.

Thank you for your feedback.
Also I'm sorry to have kept you waiting because I found some bugs in my implementation and it took some time to resolve them.
Now, I've finished fixing the code including the bugs I found.
Please kindly check if the changes have been made as intended.
Regarding the way of contribution, I think you mentioned this matter at first, I completely agree with your suggestion to make the issue in advance of PR.
Thank you for maintaining flexibility while making the rules stricter.
Now I have some ideas for new features and haven't started coding yet, so I'll make the issues one by one.

Thank you!!

Thank you for your feedback.
Let me break down the matter into some aspects.
Proposed UX goal
I think it's better to set the filter frequency independently of analyzer range because fine tuning with cut and try is needed.
In current implementation, changing the filter frequency immediately reflects in the sound the user hears so that the user can adjust the filter frequency by hearing.
Why current implementation has conditional branch
There are two reasons.
Firstly, I used the CHANGE event of HTML input instead of the INPUT event to reflect the change immediately.
However, it causes an event loop. Changing HTML input makes the setting update, and the setting update makes the input UI update.
So, I added the conditional branch, this._hoge !== newValue, which only issues the event when the value is updated.
Secondly, the bi-quad filter cannot work as expected when the frequency set is too low, especially at zero.
So, I validate and limit the value range.
Then, to reflect the value modification to the UI, I added the condition value !== newValue.
How to resolve
From a UI perspective, I suppose it is better to set the filter frequency independently of analyzer range.
However, real-time update with the UPDATE event is not mandatory, we can use INPUT event.
By this approach, we can remove this._hoge !== newValue.
Regarding another condition value !== newValue, I think we can just remove this condition.
Though the modified value will not be reflected in the UI, the frequency is surely limited to make the bi-quad filter work as expected.
Let me summarize my proposal again:

Keep the filter frequency setting independently of analyzer range to make it possible to adjust by hearing.
Remove conditional branch in the set function with the following countermeasures:

Using INPUT event for value inputs to avoid the event loop.
Do not reflect the modified frequency to the UI when it is limited.

What do you think about this idea?

Thank you!!
I understand the reason for implementiation of this PR.
With that in mind, there are a few points I would like you to confirm.
If you read the following, you may think that the UX goal of immediately reflecting value changes for trial and error can be achieved even if you reuse the existing minFrequency and maxFrequency input.
Therefore, it may be a little long and tedious to read, but please check it once.
However, I also write about a compromise at the end, so please check that if you really want to separate the input fields.
About limiting the frequency so that the biquad filter works as expected
In this regard, if you reuse minFrequency and maxFrequency, the reflection in the UI will not be strict.
However, from what I can see, the only special processing that is different from minFrequency and maxFrequency is to set the minimum value to 10, right?
If that's the case, I think it's enough to set 10 in PlayerService if the frequency is too small.
The UI displays a value smaller than 10, so the UI display and the actual sound are different, but since 10Hz is a sound lower than the lower limit of the human audible range and cannot be perceived, this is not a problem.
(If you want the minFrequency or maxFrequency input to become sampleRate/2 instead of the defaultValue when too large an input is entered, you can change the code for the check in the minFrequency or maxFrequency setter.
However, if you do this, I want to make a separate PR and change all the settings in AnalyzeSetting that have this desired behavior. I want you to compromise and keep it as is for this PR.)
About event loops
Will an event loop occur if you use a CHANGE event?
Currently, minFrequency updates setting.minFrequency in the CHANGE event handler.
When updated, AnalyzeSetting fires the AS_UPDATE_MIN_FREQUENCY event in the setter.
The UI receives AS_UPDATE_MIN_FREQUENCY and updates the value displayed in the UI.
The event chain ends there, and it does not appear to have entered an infinite loop.
Thus, I don't think a loop would occur even if the CHANGE event was used.
This behavior was the same when I use the INPUT.
Therefore, it seems strange to say that the CHANGE event was chosen because a loop would occur.
About the choice between the CHENGE event and the INPUT event
Considering that there is no risk of an event loop, the reason for choosing INPUT instead of CHANGE is probably just the difference between whether an event will fire just by changing the value.
With the CHANGE event, the event will not fire unless you press the Enter key, so it may be a little more work when trying and error things out.
About the opinion that you want to separate the input fields to allow fine adjustments by hearing
The desire to separate the input fields because fine adjustments are necessary seems to be due to a misunderstanding between us regarding the timing at which changes in minFrequency and maxFrequency are reflected in AnalyzeSetting.
When the CHANGE event is fired, minFrequency is reflected in AnalyzeSetting immediately, and AS_UPDATE_MIN_FREQUENCY is fired by the setter.
Therefore, by receiving these events with PlayerService, any changes to minFrequency and maxFrequency can be reflected in the Player's behavior immediately, so fine-tuning by hearing is possible.
If there is a concern, it is that, as mentioned above, INPUT events are more convenient for trial and error.
However, isn't it acceptable that just to press the Enter key after entering a number in tne input field? (If you can accept this, CHANGE event is enough)
If this is not acceptable, there is no problem in changing minFrequency and maxFrequency to INPUT events.
(Because this change does not affect the original purpose.)
Policy if you absolutely want to separate the input fields
You are probably the only user of this function, so if you have read all of these comments and still have a strong desire to separate the input fields, we would like to prioritize the user's (your) wishes. I will write the policy in that case here.
As mentioned above, since an infinite event loop will not occur, there is no need to check with an if statement when firing an event such as PS_UPDATE_HPF_FREQUENCY. There is also no need to check with an if statement when reflecting the limited frequency in the UI (even in that case, the event loop will not occur).
So there is no need to give up on displaying the limited frequency in the UI.
For convenience, I think using the INPUT event is more convenient when making fine adjustments, so I think INPUT is fine.
However, if you enter a value smaller than 10, it will be immediately corrected to 10, so you will not be able to delete it if you want to enter a different value, so in that respect the CHANGE event may be more convenient.
Which one you use is up to you as it will not affect any existing code.

Thank you for the feedback!
About event loop
I apologize for the incorrect explanation in my last comment.
I utilize INPUT, not CHANGE event, but I mistakenly stated the opposite.
I was also wrong regarding the matter of event loop itself.
Actually, I faced it in early stage of developing this feature, but it cannot be reproduced now if I remove the conditions, as you said.
I think there was another issue at that time, unrelated to this matter.
Thank you for your explanation in detail so that I could notice my wrong coding.
About input field
For this point, I would appreciate it if you could allow me to maintain the current condition.
Though I am the only user for this feature now, I believe it would be better for any future user to have enable checkbox and frequency input located nearby.
For this, it is also possible to put the filter enable checkbox next to min/max frequency field in the analyzer setting.
However, I think it makes the UI more messy because filter enable is the setting for the player.
About event type
Regarding the event type, I would like to choose CHANGE event.
I've recently tested this feature with a local build and found that it was more disturbing to have the value automatically changed by the validator, compared to the need to press the Enter key after modifying the value, as you mentioned.
Modification
Finally, I modified the code as following:

Removing the existing conditions from each set functions.

Keep each frequency input as it is.

Keep separated from min/max frequencies.
Replace INPUT event to CHANGE event and fix test accordingly.

Please confirm above, thank you.

Thank you!


Return correct package name when using a custom react-script scoped package

Currently the getPackageName method returns an empty string when attempting to use a custom react-scripts package that's a scoped package (e.g. create-react-app my-test-app --scripts-version=@dpoineau/react-scripts), which causes the final step of create-react-app to fail.
This slightly tweaks the condition so that it will work correctly with scoped packages too.

Hmm, actually this fix will still fail when attempting to use a scoped package at a specific version (e.g<EMAIL_ADDRESS>

Hi @dpoineau , is this PR related: https://github.com/facebookincubator/create-react-app/pull/826

@dvkndn ah yes, that's the exact same issue, my mistake, somehow I missed it. I'll close the PR I opened in favor of that one. Thanks for pointing it out!


Add the admin show into the queryMap

Add the admin show into the queryMap otherwise the admin show ddl jobs;  can't get the right result. admin show ddl jobs; is the tidb sql.

the code link:  https://github.com/xo/usql/blob/dc1d600c9c5b6964533c78f34d62f81e0783b6f5/drivers/qtype.go#L8.


Harbor's  some container sometimes restart and keep on being restarting or Exit status?

If you are reporting a problem, please make sure the following information are provided:
1)Version of docker engine and docker-compose.
docker version
Client:
 Version:      17.09.0-ce
 API version:  1.32
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:41:23 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.09.0-ce
 API version:  1.32 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   afdb6d4
 Built:        Tue Sep 26 22:42:49 2017
 OS/Arch:      linux/amd64
 Experimental: false

docker-compose version
docker-compose version 1.9.0, build 2585387
docker-py version: 1.10.6
CPython version: 2.7.5
OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013

Harbor version: 1.2.0 GA

2)Log files, you can get them by package the /var/log/harbor/ .
i have the same problem like #3276 ,when adminserver.log stop output 200 status log like :
adminserver[25935]: <IP_ADDRESS> - - [06/Dec/2017:10:16:56 +0000] "GET /api/configurations HTTP/1.1" 200 957
jobservice.log will be input like:
jobservice[1141]: 2017-09-22T20:43:58Z [ERROR] [utils.go:94]: failed to connect to  tcp://adminserver:80, retry after 2 seconds :dial tcp: lookup adminserver: no such host
Can someone provide some  method to debug this problem?
It seem adminserver container's exiting cause the problem but it doesn't give some error log.

please provide the harbor log.


Fix google login

I'm not completely sure about this solution but I think it could work:

When a campaigner is not logged into Google with any account, when going to /actionite, she/he will need to click on the SignIn Google button to log in, choose the correct account and it will redirect to /dashboard.

When a campaigner is signed into her/his SOU Google account, when going to /actionite it will login automatically and redirects to /dashboard.

When a campaigner is logged into her/his personal Google account, when going to /actionite it will redirect to a notification page that explains what the problem is (not being logged into her/his SOU Google account), and ask to do that in order to try lo login again into Actionite (this will also works if the campaigner is logged into her/his personal Google account and tries to go to /dashboard).

This looks good and is really simple; merging!


Enhanced ValidationCtx method to support nested map in slice

[x] I have looked at the documentation here first?
[x] I have looked at the examples provided that may showcase my question here?

Package version eg. v9, v10:
v10
Issue, Question or Enhancement:
Enhanced ValidationCtx method to support nested map in slice
Currently ValidateCtx cannot support the validation method of nested map in slices, which makes ValidateCtx inconvenient to use. Can it be enhanced?
Code sample, to showcase or reproduce:
test data like this
data: map[string]interface{}{
	"Test_A": map[string]interface{}{
		"Test_B": "Test_B",
		"Test_C": []interface{}{"Test_D"},
		"Test_E": map[string]interface{}{
			"Test_F": "Test_F",
		},
		"Test_G": "Test_G",
		"Test_I": []map[string]interface{}{
			{
				"Test_J": "Test_J",
			},
		},
	},
},
rules: map[string]interface{}{
	"Test_A": map[string]interface{}{
		"Test_B": "min=2",
		"Test_C": map[string]interface{}{
			"Test_D": "min=2",
		},
		"Test_E": map[string]interface{}{
			"Test_F": "min=100",
		},
		"Test_G": map[string]interface{}{
			"Test_H": "min=2",
		},
		"Test_I": map[string]interface{}{
			"Test_J": "min=100",
		},
	},
},

PR #915 merged


Eliminate need for time-macros crate

The time-macros crate currently provides macros for statically-known values. With the stabilization of proc_macro_hygiene in Rust 1.46, a second crate is no longer needed solely to hack around compiler limitations. However, there are still some restrictions that prevent these macros from becoming declarative macros, rather than the current procedural macros. This would simplify the code, as it wouldn't be necessary to duplicate code across crates. Additionally, the macros could be used internally and could exist without the need of a feature flag, as the compile-time impact would be minimal.
The offset! macro can be implemented relatively easily on stable today, as advanced features are not needed and the range of valid integers is small. The snippet below relies on const_panic, as it appears to be progressing towards stabilization; this dependency can be removed for the offset! macro without much effort.
The time! macro is a bit trickier, as handling the subsecond values requires additional effort. While floating point methods are not even unstably const, basic arithmetic is stably const. Because the floating point literal cannot be trivially matched in a macro_rules!, const_panic is a dependency for porting the time! macro, which would allow static verification of the value.
The date! macro could conceivably be implemented as macro_rules! on stable, but doing so would be infeasible (both to the author and the compiler). As the range of valid years is significant, the number of macro matchers would be in the tens of thousands (or multiple million if the large-dates flag is enabled). With the stabilization of const_panic, the date! macro should be able to be implemented without issue. The macro below does not include week-based dates, as it isn't possible to use the same syntax in macro_rules!.
The format_description! macro is by far the most challenging. As a non-exhaustive list, const destructors, const allocation, const trait implementations, and the stabilization of a number of stdlib methods as const. This is undoubtedly a long ways off, so it's not particularly worth going into a ton of detail here.

This snippet currently relies on the const_panic feature. Note that this is only a proof-of-concept and has not been thoroughly tested; it is not what currently backs the time crate. Having rust-lang/rust#59368 would be useful to (publicly) keep the macros in the existing macros module.

Given that proc macros can control where the error message points to, even on stable, there are definitive advantages to keeping it this way. When proc_macro_diagnostics is stabilized, this situation will only be improved. As a result, I feel this is the best way forward.


M1 Support

Hi @whogaurav, thank you for opening this issue. Do you have an M1? What's the error you are facing?

I have M1 and am facing "Clorio-Wallet quit unexpectedly" immediately upon open. An excerpt from the report:
Termination Reason:    Namespace DYLD, Code 1 Library missing
Library not loaded: @rpath/Electron Framework.framework/Electron Framework
Referenced from: /private/var/folders/*/Clorio-Wallet.app/Contents/MacOS/Clorio-Wallet
Reason: tried: '/private/var/folders/_z/x5t6r3g91pq766rq4_8744lr0000gn/T/AppTranslocation/01E1A3C9-D62C-40B0-A5C1-E4E675260661/d/Clorio-Wallet.app/Contents/MacOS/../Frameworks/Electron Framework.framework/Electron Framework' (not a mach-o file), '/private/var/folders/_z/x5t6r3g91pq766rq4_8744lr0000gn/T/AppTranslocation/01E1A3C9-D62C-40B0-A5C1-E4E675260661/d/Clorio-Wallet.app/Contents/MacOS/../Frameworks/Electron Framework.framework/Electron Framework' (not a mach-o file), '/Library/Frameworks/Electron Framework.framework/Electron Framework' (no such file), '/System/Library/Frameworks/Electron Framework.framework/Electron Framework' (no such file)
(terminated at launch; ignore backtrace

Hi @whogaurav @llama I finally have been able to test the latest Clorio version on M1. It seems to be running smoothly and haven't faced any issue 😕

Closing this issue as Clorio appears to be working on M1 :)
I'll re-open the issue if any issue arises.


#4507 add select network screen after you create import a new wallet

Closes #4507.
I will squish and merge once approved.
Create Wallet Test:

Delete the app from your device.
Run.
Select "Create wallet" (screen 7).
Expect InitialNetworkSelectionViewController (screen 1) to show up.
Select one or more networks in main net.
Press continue button.
Expect TokensViewController (screen 6) to show up.

Import Wallet Test:

Delete the app from your device.
Run.
Select "I already have a wallet" (screen 7).
Select "Import existing wallet" (screen 8).
Enter wallet data.
Expect InitialNetworkSelectionViewController (screen 1) to show up.
Select one or more networks in mainnets.
Press continue button.
Expect TokensViewController (screen 6) to show up.

Watch Wallet Test:

Delete the app from your device.
Run.
Select "I already have a wallet" (screen 7).
Select "Track wallet address" (screen 8).
Enter wallet address.
Expect TokensViewController (screen 6) to show up.

Testnet Test:

Delete the app from your device.
Run.
Select "Create wallet" (screen 7).
Expect to see InitialNetworkSelectionViewController (screen 1).
Click on the Mainnet toggle switch to turn off mainnets.
Expect Overlay to appear (screen 3).
Press "Got it, enable testnets" button.
Expect Testnets screen (screen 4).
Click on the Testnet toggle switch to turn off testnets.
Expect to see InitialNetworkSelectionViewController (screen 1).

Filter Test:

Delete the app from your device.
Run.
Select "Create wallet" (screen 7).
Expect to see InitialNetworkSelectionViewController (screen 1).
Select the searchBar and type some letters.
Expect to see searchBar filtering (screen 2).

Continue button Test:

Delete the app from your device.
Run.
Select "Create wallet" (screen 7).
Expect to see InitialNetworkSelectionViewController (screen 1).
Deselect all networks.
Expect to see Continue button disabled (screen 5)

Screen #

Screen 1InitialNetworkSelectionViewController

Screen 2SearchBar filtering

Screen 3Testnets Overlay

Screen 4Testnets

Screen 5Continue button disabled when no networks are selected

Screen 6TokensViewController

Screen 7Initial Wallet Creation

Screen 8Import/Track Wallet Options

Ack! I need to implement the empty screen when the search filter turns up nothing.

Can just skip it and do it in another PR. If reasonable, always merge a smaller PR.

The current master f8a81891fe88186401f131890fefc560a455b597 has the following behaviour:
If I make changes in the main nets, then return to the main screen, I get the main screen. I cannot select no active networks. Selecting no active networks and returning to the main screen does not give an error message; the app simply does nothing. The app should inform the user.

@hboon

I'm going to add the following behaviour:

If main nets or tests nets are selected and there are no active selected networks, a default set of selected networks will be presented.
When no networks are selected in the current screen (main net or test net), the user cannot hit the continue button.
The current selected screen (main net or test net) will have their selected networks loaded. The selected networks in the other screen (test net or main net) will be ignored.

If I make changes in the main nets, then return to the main screen, I get the main screen. Selecting no active networks and returning to the main screen does not give an error message; the app simply does nothing. The app should inform the user.

I'm not sure if you decided on something different in the earlier comment, if so ignore this:
I think it's good to just go back and do nothing if the user de-selects everything. It's a less hassle than the user trying to remember what they want to select, and less disruptive than a popup, but not too important.

If main nets or tests nets are selected and there are no active selected networks, a default set of selected networks will be presented.

This is right after creating a wallet right? Sounds OK.

When no networks are selected in the current screen (main net or test net), the user cannot hit the continue button.

OK, but this contradicts (1) above

The current selected screen (main net or test net) will have their selected networks loaded. The selected networks in the other screen (test net or main net) will be ignored when the continue button is pressed.

Not sure what this means.

Should the user not be allowed to deselect the last selected network?

They should be allowed to with the expectation that they go and select another network.

If main nets or tests nets are selected and there are no active selected networks, a default set of selected networks will be presented.

This is right after creating a wallet right? Sounds OK.

When no networks are selected in the current screen (main net or test net), the user cannot hit the continue button.

OK, but this contradicts (1) above

The user can deselect networks.

The current selected screen (main net or test net) will have their selected networks loaded. The selected networks in the other screen (test net or main net) will be ignored when the continue button is pressed.

Not sure what this means.

If you are in test net, only test nets will be added. If you are in main nets, only main nets will be added.

Should the user not be allowed to deselect the last selected network?

They should be allowed to with the expectation that they go and select another network.

I will squish and merge once approved.

Eek. That didn't happen.


Add routes for creating events!

This PR adds the code for creating events.
@spkane31 the thing I'd appreciate it if you did is look at the test cases and the data we send to the event creation and think of things we should be validating/testing. For instance, the end time needs to be after the start time (already implemented and tested).

Good call. You got me thinking about the structure of this code - eventually we'll probably need to make this a function that is called for multiple endpoints - for instance this endpoint and a private event for like one-on-ones. In that case we'd need to be able to make events in the past. But I agree - this endpoint should be only in the future. Will add that and merge!


tests: logging: uart: log_core_additional/logging.async failing

Describe the bug
tests/subsys/logging/log_core_additional/logging.async is failing in the main branch after the merge of https://github.com/zephyrproject-rtos/zephyr/pull/64917. As the PR changed the name of the UART log backend to log_backend_uart##idx and the test is looking for log_backend_uart.
To Reproduce
Steps to reproduce the behavior:

Checkout current main branch
west build -b m2gl025_miv -p auto -t run -T zephyr/tests/subsys/logging/log_core_additional/logging.async

Expected behavior
The test should pass.
Impact
This can cause error in PR and blocking development. It is currently causing our CI to fail:

https://github.com/zephyrproject-rtos/zephyr/actions/workflows/twister.yaml?query=branch%3Amain
Logs and console output
START - test_multiple_backends
Test multiple backends
    Assertion failed at WEST_TOPDIR/zephyr/tests/subsys/logging/log_core_additional/src/log_test.c:399: test_log_core_additional_test_multiple_backends: (have_uart is false)
There is no UART log backend found
 FAIL - test_multiple_backends in 0.001 seconds
===================================================================
TESTSUITE test_log_core_additional failed.

Environment (please complete the following information):

OS: Windows, Linux
Toolchain: Zephyr SDK
Commit SHA or Version used: current main

@nordic-krch Please look into this.


How to to codegen for "useSuspenseQuery "

I want to useSuspenseQuery in my code, but I want codegen to generate all the queries for me. how can I do that.
so basically I want the generated file to have
import { useSuspenseQuery } from "@apollo/experimental-nextjs-app-support/ssr";
then to generate useSuspenseQuery  for all my graphql queries

Please see the Codegen example in our polls demo. The codegen here generates TypedDocumentNodes that you can use in useSuspenseQuery and everything will be fully typed as a result.

I wrote custom plugin for new Apollo hooks support @MaherSaleem
codegen-apollo-hooks.js
const apolloImport = "import * as Apollo from '@apollo/client';";

function generateOperationHook(type, name) {
    const operationName = name.charAt(0).toUpperCase() + name.slice(1);
    if (type === 'query') {
        return `export const use${operationName}Query = (options?: Apollo.QueryHookOptions<${operationName}Query, ${operationName}QueryVariables>) => {
  return Apollo.useQuery<${operationName}Query, ${operationName}QueryVariables>(${operationName}Document, options);
};
export const use${operationName}LazyQuery = (options?: Apollo.LazyQueryHookOptions<${operationName}Query, ${operationName}QueryVariables>) => {
  return Apollo.useLazyQuery(${operationName}Document, options);
};

export const use${operationName}SuspenseQuery = (options?: Apollo.SuspenseQueryHookOptions<${operationName}Query, ${operationName}QueryVariables>) => {
  return Apollo.useSuspenseQuery(${operationName}Document, options);
};

export const use${operationName}BackgroundQuery = (options?: Apollo.BackgroundQueryHookOptions<${operationName}Query, ${operationName}QueryVariables>) => {
  return Apollo.useBackgroundQuery(${operationName}Document, options);
};
`;
    } else if (type === 'mutation') {
        return `export const use${operationName}Mutation = (options?: Apollo.MutationHookOptions<${operationName}Mutation, ${operationName}MutationVariables>) => {
  return Apollo.useMutation(${operationName}Document, options);
};`;
    } else if (type === 'subscription') {
        return `export const use${operationName}Subscription = (options?: Apollo.SubscriptionHookOptions<${operationName}Subscription, ${operationName}SubscriptionVariables>) => {
  return Apollo.useSubscription(${operationName}Document, options);
};`;
    }

    return '';
}

function generateFragmentHook(fragmentName) {
    return `export const use${fragmentName}Fragment = (options?: Pick<Apollo.UseFragmentOptions<${fragmentName}Fragment, Apollo.OperationVariables>, 'from'> & Partial<Apollo.UseFragmentOptions<${fragmentName}Fragment, Apollo.OperationVariables>>) => {
  return Apollo.useFragment<${fragmentName}Fragment>({
    fragment: ${fragmentName}FragmentDoc,
    fragmentName: "${fragmentName}",
    ...options
});
}`;
}

module.exports = {
    plugin: (schema, documents, config) => {
        const hooks = documents.flatMap(({ document }) => {
            const operations = document.definitions
                .filter((def) => def.kind === 'OperationDefinition')
                .map((operation) => ({
                    type: operation.operation,
                    operationName: operation.name.value,
                }));

            const fragments = document.definitions
                .filter((def) => def.kind === 'FragmentDefinition')
                .map((fragment) => ({
                    fragmentName: fragment.name.value,
                }));
            const solvedOperations = operations.map(({ type, operationName }) =>
                generateOperationHook(type, operationName)
            );
            const solvedFragments = fragments.map(({ fragmentName }) => generateFragmentHook(fragmentName));
            return [...solvedOperations, ...solvedFragments];
        });

        if (hooks.length) {
            return [apolloImport, ...hooks].join('\n\n');
        }
    },
};

and just add reference to the codegen config e.g. plugins: ['typescript-operations', 'typed-document-node', './codegen-apollo-hooks.js'],

Please be aware though that we generally do not recommend code-generating hooks anymore.
They do not give you any benefit over using TypedDocumentNode, but they add additional bundle size to your application.

I'm doing some housekeeping so I'm closing some older issues that haven't seen activity in a while.
If this is still relevant, please feel free to reopen the issue.


pom.xml:41-45: Enable Opeo Spring Fat Integration Test....

The puzzle 200-30ec0eb9 from #200 has to be resolved:
https://github.com/objectionary/opeo-maven-plugin/blob/64b596d8f76c3e148ea2dff9ca06288484e59f00/src/it/spring-fat/pom.xml#L41-L45
The puzzle was created by @rultor on 22-Apr-24.
Estimate: 90 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 200-30ec0eb9 has disappeared from the source code, that's why I closed this issue.

@0pdd 2 puzzles #228, #229 are still not solved.

@0pdd the puzzle #229 is still not solved; solved: #228.

@0pdd 2 puzzles #229, #242 are still not solved; solved: #228.

@0pdd 3 puzzles #229, #242, #249 are still not solved; solved: #228.

@0pdd 4 puzzles #229, #242, #249, #260 are still not solved; solved: #228.

@0pdd 14 puzzles #229, #242, #249, #260, #274, #275, #276, #277, #278, #279, #280, #281, #282, #283 are still not solved; solved: #228.

@0pdd 14 puzzles #229, #242, #249, #260, #274, #275, #276, #277, #278, #279, #280, #281, #283, #286 are still not solved; solved: #228, #282.

@0pdd 13 puzzles #229, #242, #249, #260, #274, #275, #276, #277, #278, #279, #280, #281, #286 are still not solved; solved: #228, #282, #283.

@0pdd 13 puzzles #242, #249, #274, #275, #276, #278, #279, #280, #281, #286, #382, #387, #388 are still not solved; solved: #228, #229, #260, #277, #282, #283.


Edit a specific column for all rows

Hello,
Is there a way to edit a specific column for all the rows in my grid?
It's like trying to do what the editItem(item|$row|rowNode) method does, but, for all the rows. Thanks.

No, nothing out-of-the-box. You need to write your own function that takes the new value, loops through all the grid items and updates them.

Okay, thanks.


Allow GcpProjectIdProvider to provide the numerical value for the project

GcpProjectIdProvider currently only provides the string value that contains the name of the project, it would be useful to have it also contain the numerical value associated with the project.

I think in that in terms of the single responsibility principle, we should keep GcpProjectIdProvider simple. However, we might want to provide a template for the Project Metadata Service. How common is the need for the project number?

I'd say that it's somewhat common, but not as common as the project-id. For example, if you want to know what the name of the service account is for a specific GCP project (The one that is automatically created for Builds and Compute Engine.), the only way to currently do that is through something like: this.

Sounds like auto-configuration for the Resource Manager API or even a template for it can be useful in case like this one.

Yeah, having a way to ask the Resource Manager API directly What is the Project Number? would be useful.

Note that Resource Manager API is disabled by default, so if we provide an autowired object, we should at minimum document it as the most common issue.
There is an example of acquiring ResourceManager client library abstraction and getting a project number from it in IAP.

I think most APIs are disabled by default.


[Snyk] Security upgrade python from 3.7-slim to 3.13.0a2-slim

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

terraform/aws/resources/Dockerfile

We recommend upgrading to python:3.13.0a2-slim, as this image has only 36 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

514
Use After Free SNYK-DEBIAN12-GLIBC-5894114
No Known Exploit

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Proof of Concept

721
Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
Proof of Concept

614
CVE-2023-5363 SNYK-DEBIAN12-OPENSSL-6032384
No Known Exploit

614
CVE-2023-5363 SNYK-DEBIAN12-OPENSSL-6032384
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use After Free

Checkmarx One – Scan Summary & Details – 4b9897d2-e5de-4eac-b659-0a82018000e0
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Aurora With Disabled at Rest Encryption
/rds.tf: 49
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 97
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 17
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 113
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 1
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 81
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 130
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 65
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

Aurora With Disabled at Rest Encryption
/rds.tf: 33
Amazon Aurora does not have encryption for data at rest enabled. To prevent such a scenario, update the attribute 'StorageEncrypted' to 'true'.

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

CVE-2023-45133
<EMAIL_ADDRESS>Vulnerable Package

Cx37f28a21-b2a7
Npm-angular-1.8-1.8.2
Vulnerable Package

Cx94a5c81d-63b1
Npm-angular-1.8-1.8.2
Vulnerable Package

Cx9eb96c9b-eb45
Npm-angular-mocks-1.8-1.8.2
Vulnerable Package

Cxcf770dcb-fd21
Npm-angular-1.8-1.8.2
Vulnerable Package

Missing User Instruction
/Dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Passwords And Secrets - Generic Access Key
/lambda.tf: 45
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Access Key
/providers.tf: 10
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/instance.tf: 45
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/instance.tf: 11
Query to find passwords and secrets in infrastructure code.

Passwords And Secrets - Generic Password
/sql.tf: 50
Query to find passwords and secrets in infrastructure code.

CVE-2023-44270
Npm-postcss-8.3.11
Vulnerable Package

CVE-2023-44270
Npm-postcss-7.0.39
Vulnerable Package

CVE-2023-5752
Python-pip-22.2
Vulnerable Package

Healthcheck Instruction Missing
/Dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

Fixed Issues

Severity
Issue
Source File / Package

Cx6b921f00-d395
Npm-vm2-3.9.5

Missing User Instruction
/Dockerfile: 1

CVE-2023-2251
Npm-yaml-1.10.2

Healthcheck Instruction Missing
/Dockerfile: 1


[SPARK-31723][CORE][TEST] Reenable one test case in HistoryServerSuite

What changes were proposed in this pull request?
Enable test("static relative links are prefixed with uiRoot (spark.ui.proxyBase)")
Why are the changes needed?
In Jira, the failed test is another one test("ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase)"). This test has been fixed in 6a895d0
Does this PR introduce any user-facing change?
No
How was this patch tested?
Fix UT

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

@warrenzhu25 I have updated the PR title for you. Feel free to update it again if you have comments.

Test build #124823 has started for PR 28970 at commit 057d543.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29431/
Test PASSed.

Thanks, @warrenzhu25 and @gengliangwang .

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124823/
Test FAILed.

Retest this please.

Test build #124913 has started for PR 28970 at commit 057d543.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29519/
Test PASSed.

Test build #124913 has finished for PR 28970 at commit 057d543.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124913/
Test FAILed.

Retest this please.

Retest this please

Test build #124933 has started for PR 28970 at commit 057d543.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29539/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124933/
Test FAILed.

Retest this please

Test build #125085 has started for PR 28970 at commit 057d543.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29692/
Test PASSed.

Test build #125085 has finished for PR 28970 at commit 057d543.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125085/
Test FAILed.

Merged build finished. Test FAILed.

Retest this please.

Test build #125391 has started for PR 28970 at commit 057d543.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30004/
Test PASSed.

Test build #125391 has finished for PR 28970 at commit 057d543.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125391/
Test PASSed.


SB-786 Repository based user-agent mapping added to HeadersMappingFilter

Overall, the commit looks good! Could you please sort out the code style and the comments and I'll merge it when you're done...?

@carlspring
I'm very sorry, but could you specify places with unacceptable formatting?


please tell me what's the purpose of this sentence

sorry but I wonder why this sentence exist in the method _.throttle
if (!timeout) context = args = null;
what's the purpose?

To allow context and args to be garbage collected, but only if the invocation above it didn't call the throttled function.

Github repos aren't your personal question and answer service. Please use StackOverflow, the Gitter channel or the mailing list.


Create code

@Ananya01Agrawal Follow the guidelines. If you are facing issues with the guidelines then open a discussion in Q&A section. Feel free to share your problem.

ok sir, for sure

Also I think you have not registered for the event

I have registered for the event and also made changes in the  readme file

You can start adding the code with explanation
Inside Ananya Agrawal folder crate a folder with problem title

Create two files inside the folder
explanation ofthe code in readme
code with extension
keep the timer on while solving the problem in leetcode
take a screensot of submission status
attach the screenshot in the next pull-request
once the pull request is merged update the readme file with the merged pull equest number and also update the status of problem as solved


Remove deprecated set-output action commands

actions/core is already at ^1.10 so only the workflows require updating to use the new environment files
Closes #147

Looks to me that all the remaining notices for set-output come from sergeysova/jq-action@v2 - a patch exists for that here: https://github.com/sergeysova/jq-action/pull/9

If there is possibly multiline with some escaping, the change seems needs to be something like:
        run: |
          echo "log<<MESSAGE" >> $GITHUB_OUTPUT
          echo "$(some_data)" >> $GITHUB_OUTPUT
          echo 'MESSAGE' >> $GITHUB_OUTPUT

ref

https://github.com/phpstan/phpstan-src/pull/1917/files#diff-39c7f1bcfed19e41d56b6260c66af6d03da1257d053b371b7c0de3a3ed01bb13
https://github.com/rectorphp/rector-src/pull/3016/files

@samsonasik shell-check seems OK with the changed lines - is there something specific that looks wrong? Won't single quotes break the expansions?

@gsteel probably if there is some special chars like in PHPStan, which when combining with multiline, may break the workflow:
Run echo "log=$(git log c2ef009c67198d39a6e685a1bca21ceab798d35b..fec8acc849277c78755d3d00767eff95ed3c4014 --reverse --pretty='%H %s' | sed -e 's/^/https:\/\/github.com\/phpstan\/phpstan-src\/commit\//')" >> $GITHUB_OUTPUT
Error: Unable to process file command 'output' successfully.

ref https://github.com/phpstan/phpstan-src/actions/runs/3320826153/jobs/5487697232#step:6:1
The multiline example is at https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-2

Thanks @samsonasik - I understand now! None of the changed lines output multiline. The CI workflow which dumps a load of json is single line too: https://github.com/laminas/laminas-ci-matrix-action/actions/runs/3460149728/jobs/5776368483#step:3:2

Can only tell that tests seem to run, therefore I guess it works for the continuous-integration plan.
Not sure if it works properly for the tag stuff regarding container creation, no idea how to test that.

Nobody presses the bad green button? I'll do it then :P


feat(file-uploader): implements file uploader

WIP still, but wanted to get an initial pr up here. Based quite a lot on jerome's work. Still some unknowns concerning various ui states. Only basic render has been provided.

it may be worth holding off on dev here until headless dropzone is released https://github.com/react-dropzone/react-dropzone/pull/717
that would streamline implementation to only include presentation

Nice job! Is this expected for a disabled state?

the inline styles are applied by the react-dropzone package


E2E: go tag branch1 SLSA3 config-ldflags assets

Repo: https://github.com/slsa-framework/example-package/tree/v10.10.29
Run: https://github.com/slsa-framework/example-package/actions/runs/2278860962
Workflow name: go tag branch1 SLSA3 config-ldflags assets
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.branch1.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v10.10.29
Date: Thu May  5 23:48:55 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v10.10.30
Run: https://github.com/slsa-framework/example-package/actions/runs/2278889155
Workflow name: go tag branch1 SLSA3 config-ldflags assets
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.branch1.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v10.10.30
Date: Thu May  5 23:57:25 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/v10.10.31-go-branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/2278931545
Workflow name: go tag branch1 SLSA3 config-ldflags assets
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.branch1.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v10.10.31-go-branch1
Date: Fri May  6 00:13:17 UTC 2022
Tests are passing now. Closing this issue.


Question

Question
Why would the id when scanning for a device be different between Android and iOS for the same exact ble device? Android shows the id that is listed on the device screen, but iOS shows a GUID.

That's because iOS hides MAC address and generates its own id. Unfortunately there's no easy around this. If you can change device's firmware, you can add separate characteristic with constant device identifier.

Both MAC address on Android and UUID generated by the iOS share the same trait: they uniquely identify the device. That's why they are under the same property.

These devices all have the same localName, but different ids. So I have no idea which device is the correct device I'm connecting to if there are multiple in the area. There is manufacturerData, but that doesn't look like it has the mac address in there.

The only option to uniquely identify the same device between multiple platforms during the advertising phase is to use manufacturerData field. However, it's a firmware developer responsibility to define it and fill with useful data.

Would this have any effect on writing characteristics to a device? I'm able to connect and read/write on Android. On iOS I'm able to connect but when I try to write it never returns.

What do you mean by your last sentence? Asynchronous call to write doesn't complete?


Put zebrad/Cargo.toml in a nicer order

I thought I needed to add a dependency to zebrad/Cargo.toml, so I re-ordered the dependency list. Since I'd done the work anyway, I thought I'd submit it as a PR.
I'm not sure if we have a standard order, or if this is a better order.
Feel free to quickly merge or just close.

Looks great, personally I think it's helpful to keep the internal workspace dependencies separated from the external ones like this.


Addresses to take destinations instead of public keys and public key hashes

Thanks, @OBorce, this is looking good now.


VXLAN support

Add VXLAN support, hook into newwanip event, skip type in interfaces_configure() and move interface configuration into device setup vxlan_configure_interface()

@mimugmail that would be me :) your welcome, it started out as an experiment, but seems to be working nice now.


Validate guidelines.

Two questions on this:
Is this how you want to check the angle being between 0 and 360?
I didn't see any use of validateGuideline in the rest of the code, so I just took a naïve stab at it; is this how things should work in these general purpose validators?

I must have roughed that function in and then decided to do it all independently. You can move the code to the validateGuidelineXXX functions.
For the angle, what if we took anything between -360 and 360? We could normalize that back to 0 to 360. I'm lazy so I can see myself wanting to rotate something -11°.

Instead of having a validation, the value could be coerced into a 0 to 360 number in the setter, which would allow negative numbers: (n + 360) % 360

(and then validated between 0 and 360)

Yeah. We'd have to do it in several places though. font.appendGuideline, font.insertGuideline, glyph.appendGuideline, glyph.insertGuideline, guideline.angle and probably elsewhere. I'm trying to shift as much of the gentle-scripting-value-tolerance normalization logic to the validators to keep everything consistent.
Maybe these should be called normalizers instead of validators. They do more of that than validation now that I think about it. Or normalidators.

I'm reading now that the guideline class itself could just be the place where normalization happens?


Strided slices are converted to gather rather than slice

In a piece of code such as:
jax.jit(lambda m: m[::2, :])(np.random.rand(1024, 1024))

running on TPU, a gather operation is generated rather than a strided slice. These gather operations sometimes seem to even turn into while loops. This is very slow compared to a direct implementation of the slice, which is already available in JAX.

Thanks for the report – I think currently all bracket-based indexing is converted to gather primitives, but that is not set in stone. It might be worthwhile to try lowering specific types of indexing to more specialized primitives such as slice, though I'm not aware of anyone currently looking into it.

Maybe, but at least for simple strides it looks like gather:
In [3]: jax.make_jaxpr(lambda m: m[:5, :])(np.random.rand(1024, 1024))
Out[3]:
{ lambda ; a:f32[1024,1024]. let
    b:i32[1] = broadcast_in_dim[broadcast_dimensions=() shape=(1,)] 0
    c:f32[5,1024] = gather[
      dimension_numbers=GatherDimensionNumbers(offset_dims=(0, 1), collapsed_slice_dims=(), start_index_map=(0,))
      fill_value=None
      indices_are_sorted=True
      mode=GatherScatterMode.PROMISE_IN_BOUNDS
      slice_sizes=(5, 1024)
      unique_indices=True
    ] a b
  in (c,) }

Ah, I see. I misunderstood what you meant by "generating a slice operation". I thought you were talking about slice_p, rather than gather_p with different parameters.

I did want a slice_p, but I'm pointing out that the current gather_p generation is different based on whether the slice is strided or not. The example you showed has a trivial gather of a single slice, while using a stride makes the gather have many indices.

At the TPU level in Xprof, it looked like a single slice rather than a gather, while the strided case stayed a gather. I do not fully understand which layers handle which parts of that transformation. I suspect a slice at the JAX level would be cleaner, though. Can a JAX gather gather strided slices using a single index?

Can a JAX gather gather strided slices using a single index?

I'm unsure what this question means.

We could probably add logic to dispatch simple index expressions to slice_p or dynamic_slice_p, but yes it would add even more complexity to already complicated code. Before doing any work on that, it might be useful to run some benchmarks to see the potential improvement


feat(app, components): align Liquid Setup UI with Figma

fix #11037

Overview

A few UI fixes on liquid setup to align with the Figma designs
Changelog

Align labware name column in liquids list view
Adjust flex shrink on total volume so it doesn't shrink when window does
Modal should scroll to highlighted liquid card on open
Match Figma for well highlight styling

Review requests

Look over changes, let me know if anything else needs to be fixed!
Risk assessment

Low

@mmencarelli perfect - I fixed 1,2 and 4 but added 3 to the modal ticket I made


[BUG] GPU Dashboards blank on dev container due to old jupyterlab-nvdashboard version

Describe the bug
The current rapids nightly docker + dev container pulled with
docker pull rapidsai/rapidsai-dev:0.12-cuda10.0-devel-ubuntu18.04-py3.7
docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786
rapidsai/rapidsai-dev:0.12-cuda10.0-devel-ubuntu18.04-py3.7
I using an old version of jupyterlab-nvdashboard that causes the gpu dashboards to be blank.
Updating the version resolves the issue. This guidance was given in this issue:
https://github.com/rapidsai/jupyterlab-nvdashboard/issues/24#issuecomment-604482425
and the resolution steps came from this issue:
https://github.com/rapidsai/jupyterlab-nvdashboard/issues/49
Steps/Code to reproduce bug
Run the container using
docker pull rapidsai/rapidsai-dev:0.12-cuda10.0-devel-ubuntu18.04-py3.7
docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 \
    rapidsai/rapidsai-dev:0.12-cuda10.0-devel-ubuntu18.04-py3.7

And go to any of the gpu dashboards, they will be blank.
Expected behavior
The gpu dashboards show the expected output.
Additional context
Testing was done on a dgx station.

@arnoldrw, apologies for the late response here. it appears that our containers now have the latest version of jupyterlab-nvdashboard and therefore I was not able to replicate the issue at this time. I will close the issue now, but feel free to reply if you're still exhibiting the problem and we can open it back up.


run_seq.sh报错：Can't pickle local object 'get_linear_schedule_with_warmup..lr_lambda'

Traceback (most recent call last):
File "main.py", line 146, in
main()
File "main.py", line 117, in main
if not test_only: trainer.fit(lit_model, datamodule=data)
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 458, in fit
self._run(model)
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 756, in _run
self.dispatch()
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/pytorch_lightning/trainer/trainer.py", line 797, in dispatch
self.accelerator.start_training(self)
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/pytorch_lightning/accelerators/accelerator.py", line 96, in start_training
self.training_type_plugin.start_training(trainer)
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/pytorch_lightning/plugins/training_type/ddp_spawn.py", line 122, in start_training
mp.spawn(self.new_process, **self.mp_spawn_kwargs)
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
File "/cephfs/xqwang/openue/openue/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 179, in start_processes
process.start()
File "/root/miniconda3/lib/python3.7/multiprocessing/process.py", line 112, in start
self._popen = self._Popen(self)
File "/root/miniconda3/lib/python3.7/multiprocessing/context.py", line 284, in _Popen
return Popen(process_obj)
File "/root/miniconda3/lib/python3.7/multiprocessing/popen_spawn_posix.py", line 32, in init
super().init(process_obj)
File "/root/miniconda3/lib/python3.7/multiprocessing/popen_fork.py", line 20, in init
self._launch(process_obj)
File "/root/miniconda3/lib/python3.7/multiprocessing/popen_spawn_posix.py", line 47, in _launch
reduction.dump(process_obj, fp)
File "/root/miniconda3/lib/python3.7/multiprocessing/reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
AttributeError: Can't pickle local object 'get_linear_schedule_with_warmup..lr_lambda'
请问这个是什么问题呢？run_ner.sh也遇到了同样的问题。依赖都是按照requirements安装的。

你好，请检查一下pickle的版本，我们开发环境的版本是pickle==0.7.5。


When doing a diff print errors found during stack initialization

When a instance of each stack is created it resolves a bunch of information about that stack. If the request fails because of rate limiting we do not collect the needed info. Then when doing a diff we may assume the stack does not exist or certain attributes are not set and display them as changes. This change will collect errors encountered and display them before discontinuing the diff.
Example
$ convection diff
       error  Error(s) during stack diff Rate exceeded

Verification Steps

[x] Run diff where we are rate limited and see that the diff does not happen and a error is returned
[x] Run a diff not rate limited and see that the diff is done.
[x] Inject another error and see that both errors are printed.

LGTM


add dynatrace_agents_linux_install_dir placeholder

to default dynatrace_java_agent_linux_agent_path to avoid mis-configured defaults
this might not seem much, but it was a quick error that can be avoided when using defaults, and cross-repo vars.   especially nice when merging/using Dynatrace-Ansible repo that concats all pieces together for you.

@countryHick: great idea! Our Ansible roles have been overhauled in the meantime: the dynatrace.Dynatrace-Agents role has been renamed to Dynatrace.Dynatrace-Agent on Ansible Galaxy 2.0. Thus, the variable dynatrace_agents_linux_install_dir  in your commit would need to be changed to dynatrace_agent_linux_install_dir. Do you want to resubmit? Otherwise I will publish my local changes at the end of this week.

@countryHick: I have already published this change to all affected Ansible roles. See commit https://github.com/Dynatrace/Dynatrace-Java-Agent-Ansible/commit/4e8ab8fcfdde2dcd125dca72463c296fdd26a9f3. Thanks!


Update IPARDownloadViewController.m

Fix bug  when  CFBundleIcons not exist in old ipa

nice, i will check this out soon
thank you!


Story of a girl

A dark, cinematic depiction of a Naked woman and a dog in a dimly lit forest. The woman has a mysterious aura, wearing a black tong panties, her sharp features partially illuminated by moonlight.


Improve performance polling / task sharing mechanism in Ballista

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In https://github.com/apache/arrow-datafusion/pull/698 some improvements where added to avoid sleeping when there are enough tasks around.
In order to support quicker query responses (e.g. <100ms) and avoid delays in between stages we need to remove calls like sleep(Duration::from_millis(100)) from executor/scheduler and move away from interval-based polling.
This also will reduce CPU/network waste, as there are less calls being done (currently I am seeing around 1-2% of CPU being used when idling, not much, but when going to higher polling frequencies this increases. Setting it to 1ms gives it a very high CPU usage.
Describe the solution you'd like
Wait on tasks to be available in the scheduler and only send a response when having tasks for the worker.
Remove calls to sleep.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I tried to to a part of this by moving the polling loop to the scheduler, but an important prerequisite to this is moving the number of free task slots information to the scheduler.
Currently this information is kept in each executor and sent with the info during a polling call (can_accept_task).

Is there any PR related to this ? If not I think I can work on this.

AFAIK No @mingmwang . Feel free to work on this - that would be great.

@mingmwang can update the status?

Hi @Dandandan, recently we have implemented an initial version of push-based task scheduling. Here's the design document. Could you help have a review?
https://docs.google.com/document/d/1Z1GO2A3bo7M_N26w_5t-9h3AhIPC2Huoh0j8jgwFETk/edit?usp=sharing
PR is ongoing.


feat: add CORS headers to allow RSS inclusion everywhere

This PR allows our RSS feeds to be accessed by other websites client sides.
Example: https://developers.front-commerce.com/changelog/rss.xml

I'm merging as I need it right away, but don't hesitate to provide feedbacks.


About the format of list of gRNA

I didn't find any information about how did you generate these two files: cbc_gbc_dict_grna.tsv, cbc_gbc_dict.tsv, it can't be generated from 10X genomic cell_ranger. I know these two files are the information of sgRNA although it shows no much different. I create my own sgRNA information file based on the format of yours, however, it shows an error when I run the MUSIC in R:
Error in strsplit(perturb_information[i], ",") : non-character argument
Could you give me more information about how did you create these files?

I fixed the problems. Just make a little change on your original code: sample_info_arr <- unlist(strsplit(as.character(perturb_information[i]),",")). BTW, other code might also be fixed since it shows errors when the people use the newest version of 10X genomics and Seurat.

Hi, I would like to ask when you use "cellranger count" function, did you make the ref genome by yourself. More specifically, do we need to add sgRNA sequence into the human reference genome?

I didn't find any information about how did you generate these two files: cbc_gbc_dict_grna.tsv, cbc_gbc_dict.tsv

I am also running into this error when using MUSIC::Input_preprocess_10X() as described in #3

Related to OP question, how did you assign guides RNA to cell barcodes to create cbc_gbc_dict_grna.tsv, cbc_gbc_dict.tsv ? One would expect a bimodal distribution of guides RNA in each cell, did you use an homemade Gaussian Mixture Modeling (GMM) to discriminate the two modalities ?


common Picture: Calculate to area that to be drawn, based on the ViewBox

Description :
If the drawing target(paints) is outside the scope of the viewbox, there is no need to draw.
The  provided by SVG has a feature to limit the area to be drawn.
Therefore, use renderer's composite so that the actual area to be drawn is drawn using
vx,vy,vw and vh values of the loader.

Issue Tickets (if any) :
https://github.com/Samsung/thorvg/pull/277

Tests or Samples (if any) :
[Test SVG]

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 552 240" width="400" height="200" version="1.1">
  <circle  opacity="0.9" fill="#2c9691" fill-rule="nonzero"  cx="100" cy="100" r="300" />
</svg>

Screen Shots (if any) :
[before]

[result]

make a new patch
https://github.com/Samsung/thorvg/pull/292


How to install asset server?

Please, share your knowledge.

Please, elaborate what you mean by "asset server" because I am not sure what you mean.

I tryed to connect from second computer to first (master client), but got a error: "Unable download map" I don't changing your game map.

You need to forward port 8011 (tcp) for asset server to work.

Also, I am not sure but
var serverURL = flag.String("server-url", "http://localhost:8011/", "url of asset server")

server-url should be setted properly. So it should be external ip instead of localhost.

@Lourens-Rich, do you still have issues with asset server?

Reopen or comment if you have any issues with asset server.


WIP: bp_top with latest dmc: compilation clean

Thanks for contributing to BlackParrot! Check out the CONTRIBUTING guide, if this is your first
time. A few details to check:
Summary
This PR contains changes to enable bp_top regression with the latest bsg_dmc (bsg DRAM controller) available in basejump STL.
Right now, the compilation is with hello_world bp-test passing.
Issue Fixed
Does this PR address a BlackParrot GitHub issue? Link it here:
Area
Module/tool/makefile/script in question.
bp_ddr, bsg_tag_boot.tr
Reasoning (outdated, confusing, verbose, etc.)
Why is this change required?
To start running BP tests with dmc RTL and Micron DDR bus model
Additional Changes Required (if any)
Next steps, downstream modules affected, etc.
Analysis
Potential impact of the change.
Verification
Steps to taken to verify the change.
As of now, only hello_world test is passing. Debugging other dram_stress test failure.
Additional Context
Add any other context about the problem here.
Logs, screenshots or videos that show the issue are very helpful.
Basejump PR with changes to bsg_dmc: Link

Thanks! Will check it out

Which tests have you run? And can you rebase on top_dev to eliminate the conflict?

Which tests have you run? And can you rebase on top_dev to eliminate the conflict?

Hi Dan, rebased to top_dev. Only hello_world passes right now. Trying to debug dram_stress test failure.


Support activation collection from The Pile

I currently collect all LLM activations from truthful_qa. This is a legacy choice, from when I was hunting for truthfulness directions in activation space.
I would like to test how my technique generalizes, and for that I should also support activation collection on a representative subset of The Pile. That way, I can train and interpret autoencoders and circuits using one of those two datasets, and see how those features and circuits hold up under causal intervention on the other dataset. There is already a little support for a holdout validation subset, but this is a more interesting distributional shift to evaluate.
Basically, have an acts_collect_pile.py and an acts_collect_qa.py.

openwebtext instead of The Pile, but same idea: a representative sample of the internet, alongside truthful_qa.


Notification function not able to deconstruct webhook body

Deployment
My deployment is on:

[ ] Docker
[ ] AWS Lambda
[ ] GCP
[x] Azure
[ ] Other Please specify:

Expected behaviour
The notification function deconstructs the request body correctly and has a payloadId which it then uses for further processing.

Actual behaviour
The request body cannot be deconstructed correctly, because the webhook sends the data in an unexpected format. Looking at the unit test implementation, the notification function expects a JSON request body.

But in reality the webhook sends the data formatted differently. See https://docs.mollie.com/overview/webhooks

Attempted fixes
-
Please provide more information about how this can be reproduced. Please include jsfiddle links, code snippets or any other necessary information
-

I was able to fix this by doing the following in azureHandler.ts


More graceful fallback when grpc is not present.

DESCRIPTION HERE

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand:

[ ] What the pull request does
[ ] Why it does it
[ ] How it does it
[ ] Why this approach

[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

LGTM. I do not think test errors are related.

retest this please


Nightly: Fix log gathering for Kubernetes stages

Fix a typo in the ENV variable that it does not allow Jenkins to
retrieve Kubernetes logs correctly.
Fix #3656
Signed-off-by: Eloy Coto<EMAIL_ADDRESS>

The archive the artifacts step still failed:
19:34:24 Archiving artifacts
19:34:24 WARN: No artifacts found that match the file pattern "test_results_k8s_Cilium-PR-Nightly-Tests-All_90.tar". Configuration error?
19:34:24 WARN: ‘test_results_k8s_Cilium-PR-Nightly-Tests-All_90.tar’ doesn’t match anything

test-nightly

test-me-please

test-nightly

@ianvernon Yep, I know, the issue is that the file is always the same. I need to workaround this one a little bit. Will do at end of the week.

test-nightly

test-me-please

test-nightly

Update: because nightly tests failed, we cannot see if the log-gathering functionality worked correctly because if one stage fails the tests, all subsequent stages are skipped. @eloycoto said he has been working on a fix for the failure experienced here

test-me-please

test-nightly

@eloycoto this PR has been open for some time. Given that we have had a few green nightly builds (apart from infrastructure provisioning issues), can this PR be resurrected?

Close this one due the new jobs (BETA-*) that will be in there in the following weeks.


Crash with Epic Siege mod on world join

latest.log
Mods:
!mixinbooter-5.0.jar
assetmover-1.1.jar
EpicSiegeMod-13.167.jar
ExtraSounds-1.12.2-1.3.1.jar

This should already be fixed in v1.3.2. 🙂

Indeed it is, didn't notice the update!


Avoid scrobbling advertisements

Google Play Music Radio now inserts ads every 2-5 songs. It would be nice to not scrobble these fake tracks during the ads, as otherwise it quickly becomes the top listened to track.

Hello thank you for this info. I had the same problem with Spotify. Hopefully there is a good fix.

I have been testing this on my phone and it doesn't seem to be a problem.

I am going to close this, because the updated version of Google Play doesn't seem to scrobble commercials.


cli: add support for generating ' ready' badges

Currently the command generates "service-ready" badges linking to documenation, as specified in #357.
A caveat is that the badges generated link to the docs-reorg readthedocks branch, so they will need to be updated once the new docs go online.

I've added the requested test.


VS Code freezes upon Adding Folder to Workspace

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.67.1
OS Version: Linux x64 5.4.0-110-generic snap

Steps to Reproduce:

Select File.
Click "Add Folder to Workspace ..."
VS Code freezes up.

20-second video clip: https://webmshare.com/play/5Kq8n
About my VS Code:
Version: 1.67.1
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-06T12:39:22.915Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.4.0-110-generic snap

Does this also happen when you use the Open Folder... option from that menu?

Does this also happen when you use the Open Folder... option from that menu?

Yes. Actually it happens with all of the following:

Open Folder
Open File
Open Workspace from file

My OS Version:

This video shows that Atom is able to open files/folders on my Ubuntu while VS Code can't:

https://webmshare.com/play/zOA9P

After downgrading to the version below, I became able to open files again.
Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:39:46.686Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.4.0-113-generic snap

https://webmshare.com/play/6e0JB

Merging to https://github.com/microsoft/vscode/issues/146584


Update syntheticdata.rst

Provided copyedits, formatting revisions, sentence updates, and ToC changes per customer feedback.
Description

Usage

# Add snippet demonstrating usage

Checklist

[ ] I am familiar with the Contributing Guide.
[ ] New or Existing tests cover these changes.
[ ] The documentation is up to date with these changes.

Added reviewer comments to file.


Generate impl EntityTable<XxxAnyHolder>

Resolve #134

EntityTable in ruststep/test works well. This part has been split into #136, and this PR focus to ap201

running 2 tests
test get_owned_any ... FAILED
test get_owned ... FAILED

failures:

---- get_owned_any stdout ----
thread 'get_owned_any' panicked at 'called `Result::unwrap()` on an `Err` value: DeserializeFailed("invalid length 3, expected COLOUR_RGB")', ruststep/tests/ap201.rs:14:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- get_owned stdout ----
thread 'get_owned' panicked at 'called `Result::unwrap()` on an `Err` value: DeserializeFailed("invalid length 3, expected COLOUR_RGB")', ruststep/tests/ap201.rs:14:6

failures:
    get_owned
    get_owned_any

Codes itself has been generated, but it fails deserialize

Currently, ap201.rs is following:
    #[derive(
        Debug, Clone, PartialEq, :: derive_new :: new, Holder, AsRef, AsMut, Deref, DerefMut,
    )]
    # [holder (table = Tables)]
    # [holder (field = colour_rgb)]
    #[holder(generate_deserialize)]
    pub struct ColourRgb {
        #[as_ref]
        #[as_mut]
        #[deref]
        #[deref_mut]
        #[holder(use_place_holder)]
        pub colour_specification: ColourSpecification,
        pub red: f64,
        pub green: f64,
        pub blue: f64,
    }

this corresponds to its EXPRESS definition:
  ENTITY colour_rgb
    SUBTYPE OF (colour_specification);
      red   : REAL;
      green : REAL;
      blue  : REAL;
    WHERE
      wr1: (0 <= red) AND (red <= 1);
      wr2: (0 <= green) AND (green <= 1);
      wr3: (0 <= blue) AND (blue <= 1);
  END_ENTITY; -- colour_rgb

The error
thread 'get_owned' panicked at 'called `Result::unwrap()` on an `Err` value: DeserializeFailed("invalid length 3, expected COLOUR_RGB")', ruststep/tests/ap201.rs:14:6

is correct, it should be error.

#134 has been fixed while debugging code generation around Any.


Timeout downloading stagexl_spine 0.4.0

From @meibegger on July 12, 2015 18:19
I get this for pub get and upgrade
Downloading stagexl_spine 0.4.0...
Timed out after 30.0s while downloading https://pub.dartlang.org/packages/stagexl_spine/versions/0.4.0.tar.gz.
This is likely a transient error. Please try again later.
package:pub/src/io.dart 831  timeout.<fn>
dart:isolate                 _RawReceivePortImpl._handleMessage
This is an unexpected error. Please run

    pub --trace upgrade

and include the results in a bug report on http://dartbug.com/new.

The trace is
ERR : Timed out after 30.0s while downloading https://pub.dartlang.org/packages/stagexl_spine/versions/0.4.0.tar.gz.
    | This is likely a transient error. Please try again later.
FINE: Exception type: TimeoutException
ERR : package:pub/src/io.dart 831  timeout.<fn>
    | dart:isolate                 _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                              Timer.Timer
    | package:pub/src/io.dart 820             timeout
    | package:pub/src/source/hosted.dart 194  HostedSource._download.<fn>.<fn>
    | dart:isolate                            _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                              _Future.then
    | package:pub/src/source/hosted.dart 193  HostedSource._download.<fn>
    | dart:async                              Future.Future.sync
    | package:pub/src/source/hosted.dart 184  HostedSource._download
    | package:pub/src/source/hosted.dart 93   HostedSource.downloadToSystemCache.<fn>
    | dart:isolate                            _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                             _Future.then
    | package:pub/src/source/hosted.dart 86  HostedSource.downloadToSystemCache
    | package:pub/src/source/cached.dart 51  CachedSource.get
    | package:pub/src/entrypoint.dart 365    Entrypoint._get.<fn>
    | dart:async                             Future.Future.sync
    | package:pub/src/entrypoint.dart 357    Entrypoint._get
    | dart:async                             Future.wait
    | package:pub/src/entrypoint.dart 133    Entrypoint.acquireDependencies.<async>
    | dart:isolate                           _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                           _Future.then
    | package:pub/src/entrypoint.dart 115  Entrypoint.acquireDependencies.<async>
    | dart:isolate                         _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                               Future.Future.microtask
    | package:pub/src/entrypoint.dart          Entrypoint.acquireDependencies
    | package:pub/src/command/upgrade.dart 34  UpgradeCommand.run.<async>
    | dart:isolate                             _RawReceivePortImpl._handleMessage
    | ===== asynchronous gap ===========================
    | dart:async                               Future.Future.microtask
    | package:pub/src/command/upgrade.dart     UpgradeCommand.run
    | package:args/command_runner.dart 178     CommandRunner.runCommand.<fn>
    | dart:async                               Future.Future.sync
    | package:args/command_runner.dart 131     CommandRunner.runCommand
    | package:pub/src/command_runner.dart 121  PubCommandRunner.runCommand.<async>.<fn>
    | dart:async                               Future.Future.sync
    | package:pub/src/utils.dart 103           captureErrors.<fn>
    | package:stack_trace/src/chain.dart 78    Chain.capture
    | package:pub/src/utils.dart 117           captureErrors
    | package:pub/src/command_runner.dart 121  PubCommandRunner.runCommand.<async>
    | dart:isolate                             _RawReceivePortImpl._handleMessage
---- End log transcript ----

I am able to download the file "manually" - but due to a slow internet connection it does take a little > 30sec ... but that can't be the issue - can it?
Copied from original issue: dart-lang/sdk#23833

From @mkustermann on July 13, 2015 7:38
When increasing the maximum size of packages to 100MB on the server, I recommended on #1270  to also increase the timeout value. One possibility would be to make it linear in the size of the to be downloaded tarball (the information should be available via the content-length header).

From @jarontai on July 13, 2015 3:49
Got timeout too when I use 'pub get' to download sky. I'm use a slow vpn which makes the download time greater than 60s. It would be helpful if pub's timeout is configurable, but it seems like pub have no plan to do this right now - https://github.com/dart-lang/pub/issues/1064.

From @bp74 on July 13, 2015 8:53
There shouldn't be a timeout as long as bytes are received, right?
Even if i use a 56K modem and it takes an hour to download a package.

From @jarontai on July 13, 2015 4:0
Currently, my workaround is - download the package's archive in browser, then extract it to ~/.pub-cache/hosted/pub.dartlang.org.

This timeout issue, is a client side restriction of pub and not a server bug.
Even more so, since we just redirect the pub client to Google Cloud Storage - which should not have any issues serving our packages.

This issue was moved to dart-lang/pub#1299


Image not dispalyed in README.md

I have created a pull request to fix this issue. Please have a look at #34 .

Now the image has changed.


Chef13 deprecation warning fix

Can't have nil values as default passed values.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Merging under the obvious fix policy


licence?

What should this be licenced under? Will we need different licences for different folders (e.g. if one folder has code, another has text)?

I think that it would be fine to license the entire repo under CC-BY and add "unless otherwise specified". If we add code, we can add a BSD license for the specific code added. What do you think about that?

Added CC-BY


Following symlinks does not work when matched against sth* pattern

I've got the following setup:
In /www/ckeditor5/node_modules/ I've got two symlinks:
lrwxr-xr-x    1 p  staff     29 15 Dec 17:14 ckeditor5-foo -> /www/ckeditor5-foo
lrwxr-xr-x    1 p  staff     39 15 Dec 17:16 ckeditor5-bar -> /www/ckeditor5-bar

When using chokidar as follows, changes made in ckeditor5-core are not discovered. However, the changes made in ckeditor5-bar are.
const chokidar = require( 'chokidar' );

chokidar.watch(
    [
        '/www/ckeditor5/node_modules/ckeditor5-f*/**/*.js',
        '/www/ckeditor5/node_modules/ckeditor5-bar/**/*.js',
    ],
    {
        ignoreInitial: true
    }
).on( 'all', ( event, path ) => {
    console.log( event, path );
} );

When I change the first pattern to '/www/ckeditor5/node_modules/ckeditor5-foo/**/*.js' everything works fine.
I'm on MacOS 10.11.2, Node v5.2.0.

A version of this issue was fixed with https://github.com/paulmillr/chokidar/pull/406, but that wasn't with the glob pattern on the symlink's path itself.

I believe I'm also run into this issue. I'm watching a path that has a glob pattern in it containing a symlink (via browsersync), and chokidar is not watching files under a symlink.
Any idea if there's a workaround I could use?

Found a workaround by watching the parent then using ignored to filter the files, but my directory was gigantic and "ignored" doesn't seem to be as efficient as matching with glob pattern itself (my cpu almost melted).
Found a second workaround by iterating through my directory and adding individual watches against each folder in the parent folder, and glob after that. That seems to work fine without any performance penalty. Hope this helps someone!
Still would be nice to have this working :) Cheers.

+1. My issue is a little different.  It doesn't work when watching a folder with symlinks.  I have a modules/ folder with symlinks in it and watching ./modules/*/.js. Using Gulp 4 with latest chokidar. It does not work with matching a pattern in folder/symlink/pattern. If I watch the direct file path without a pattern it works with symlink and if I remove the symlink and copy the directory in /modules folder it works.  So the issue is watching a folder with symlinks as subdirectories.

+1. I'm experiencing this in the same way @trainerbill is: where the symlink is a subdirectory matched by the glob, the watch does not recurse through that symlink regardless of glob.
In-case it's of any use, I had a similar problem with vinyl-fs not srcing files when symlinked subdirectories are present and matching with something like foo/**/*.* (where foo is not a symlink), purely by instinct I found that foo/**/**/*.* will inspect symlinked subdirectories under foo and deeper. However this does not work with chokidar.

One workaround if you don't mind it watching an entire directory without filtering: Specify only the top level directory without any globbing... symlinked subdirectories are recursed normally.

As far as I can tell on Linux, this is still a problem today.


Class "Sector_bend"

I've added Class "Sector_bend"

I've renamed elements.py to accmodel.py (the package will be called accmodel probably)


Traefik v3.0 Log Error on unexposed services (docker swarm)

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
I migrate my traefik from v2.11 to v3.0 with change on
<       - --providers.docker.swarmmode
---
>       - --providers.swarm.endpoint=unix:///var/run/docker.sock

Everything went right (routing, ssl, load balancing, etc.) not even single service reported as unhealthy and rebooted by itself
What did you see instead?
I have unexposed service (like database) that runs on another virtual network that doesn't connect with traefik. But upon inspecting traefik log, I have seen error like
2024-05-09T14:49:01Z ERR error="service \"redacted\" error: port is missing" container=redacted-redacted-szcg2tz4e0icftu3errf0glr7 providerName=swarm
2024-05-09T14:49:01Z ERR error="service \"redacted\" error: port is missing" container=redacted-redacted-e0kfu50lwfuwsf01s4abcawxg providerName=swarm
2024-05-09T14:49:16Z ERR error="service \"redacted\" error: port is missing" container=redacted-redacted-szcg2tz4e0icftu3errf0glr7 providerName=swarm
2024-05-09T14:49:16Z ERR error="service \"redacted\" error: port is missing" container=redacted-redacted-e0kfu50lwfuwsf01s4abcawxg providerName=swarm

What version of Traefik are you using?
Version:      3.0.0
Codename:     beaufort
Go version:   go1.22.2
Built:        2024-04-29T14:25:59Z
OS/Arch:      linux/amd64

What is your environment & configuration?
version: '3.3'

services:
  redacted:
    image: redacted
    environment:
      redacted: ${redacted}
      redacted: ${redacted}
    volumes:
      - redacted:/redacted
    networks:
      - backend-network

volumes:
  redacted:
    external: true

networks:
  backend-network:
    external: true

My unexposed service ^
If applicable, please paste the log output in DEBUG level
No response

apparently this label make the error log gone,
    deploy:
      labels:
        - traefik.enable=false

Actually, I forgot to change --providers.docker.exposedbydefault=false into --providers.swarm.exposedbydefault=false. Sorry for the inconvenience :)


fix(common): Fix issue when using passport and multer on route

Closes: #1189
Information

Type
Breaking change

Fix
No

:tada: This PR is included in version 6.22.2 :tada:
The release is available on:

v6.22.2
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 6.22.2 :tada:
The release is available on:

v6.22.2
GitHub release

Your semantic-release bot :package::rocket:


remove_columns is not in-place but the doc shows it is in-place

Describe the bug
The doc of datasets v2.17.0/v2.17.1 shows that remove_columns is in-place. link
In the text classification example of transformers v4.38.1, the columns are not removed.
https://github.com/huggingface/transformers/blob/a0857740c0e6127485c11476650314df3accc2b6/examples/pytorch/text-classification/run_classification.py#L421
Steps to reproduce the bug
https://github.com/huggingface/transformers/blob/a0857740c0e6127485c11476650314df3accc2b6/examples/pytorch/text-classification/run_classification.py#L421
Expected behavior
Actually remove the columns.
Environment info

datasets v2.17.0
transformers v4.38.1

Good catch! I've opened a PR with a fix in the transformers repo.

@mariosasko Thanks!
Will the doc of datasets be updated?
I find some possible mistakes in doc about whether remove_columns is in-place.

You can also remove a column using map() with remove_columns but the present method is in-place (doesn’t copy the data to a new dataset) and is thus faster.
You can also remove a column using Dataset.map() with remove_columns but the present method is in-place (doesn’t copy the data to a new dataset) and is thus faster.
🤗 Datasets also has a remove_columns() function which is faster because it doesn’t copy the data of the remaining columns.

I've linked a PR that will fix the datasets docs.


Destructor not actually freeing allocated descriptor sets for DescriptorPoolVK

@dzhdanNV   The code here seems to be incorrect:
https://github.com/NVIDIAGameWorks/NRI/blob/main/Source/VK/DescriptorPoolVK.cpp#L31-L32
It seems it should be attempting to free 0-m_UsedSets instead of m_UsedSets-m_AllocatedSets.size()  (which is the same in some cases.)

Fixed in NRI v1.82. (commit: c82f6f90b41060437a4f883e5212b687e7f4cca0)


revert(router): page navigation with RouteReuseStrategy

Due to problems with lazy loaded routes.

uitests

Hi @sis0k0 I'm curious if this fixes this issue on latest at moment when navigating to pages at times:
ERROR Error: Uncaught (in promise): TypeError: Cannot read property 'reusedRoute' of undefined
JS: TypeError: Cannot read property 'reusedRoute' of undefined
JS:     at PageRouterOutlet.activateOnGoBack (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:270:18)
JS:     at PageRouterOutlet.activateWith (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:217:18)
JS:     at ActivateRoutes.activateRoutes (file:///data/data/com.ugroupmedia.pnp.client.mobile/files/app/tns_modules/@angular/router/bundles/router.umd.js:4764:40)

If so, curious if any reasonable estimate on a merge to master? Just curious :)

Hi @NathanWalker
This is just a revert of the changes form last week related to the router. They don't work when there is lazy loading involved, so we decided to revert the changes until we have a more stable implementation.
That said, I'm not sure which exactly is the issue you mentioned - is it logged?

uitests


Using renderdoc to catch frames, the swapchain image only shows UI with a black background.

I was using renderdoc to capture the async_compute sample's frames, and found that the swapChain image only contains UI informations . At first, I guess that might be caused by the multi queues. But when I set the async_enabled false, this problem remained.
And later I tested several other samples like msaa , render_passes , the same problem occurred.
The problem shows as below:

I have no idea about why this will happen. And I know there is In-application API of renderdoc for headless vulkan application, but it seems have nothing to do with my problem.
Could anyone offer some help, thanks very much!

Can you please add some information on you setup? What OS? What device? And does this also happen with earlier RenderDoc version?
I just tested with RenderDoc 1.33 and the samples you mentioned on Win11 with an RTX 4070 and everything works as expected.

Thank for your reply.
Below is my environment:

RenderDoc version: 1.34
Operating System: Windows10
Graphics API: Vulkan1.3.283
Graphics Card: RTX 2060 super

And I have just downloaded the old 1.33 renderdoc, and tested some other samples.
The pipeline cache scene looks like:

But the capture of pipeline_cache sample looks like:

Howerver, the capture of multi_draw_indirect works as expected, it looks like:

That's really weird.

The samples use different frame works. One based on mine and one based on ARM samples. The ARM samples framework does have some sync/resource creation issues that might explain why you see differences between different samples.

I just found out that, all the samples inherited from VulkanSampleC or VulkanSampleCpp could not be captured as expected. And all those samples have the same warning in renderdoc, shows as below:

The message is:

Validation Error: [ VUID-vkCmdDrawIndexed-None-08114 ] Object 0: handle = Descriptor Set 772, type = VK_OBJECT_TYPE_DESCRIPTOR_SET; | MessageID = 0x3f6fd836 | vkCmdDrawIndexed():  the descriptor (VkDescriptorSet Descriptor Set 772, binding 1, index 0) is using buffer VkBuffer 0x9dc4de00000002b8[] that is invalid or has been destroyed. The Vulkan spec states: Descriptors in each bound descriptor set, specified via vkCmdBindDescriptorSets, must be valid as described by descriptor validity if they are statically used by the VkPipeline bound to the pipeline bind point used by this command and the bound VkPipeline was not created with VK_PIPELINE_CREATE_DESCRIPTOR_BUFFER_BIT_EXT (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-vkCmdDrawIndexed-None-08114)

And when those samples runs, the console window also shows a bunch of validatiion errors:

[debug] Building #1 cache object (class vkb::DescriptorSet)
[error] -36706146 - VUID-VkWriteDescriptorSet-descriptorType-00327: Validation Error: [ VUID-VkWriteDescriptorSet-descri
ptorType-00327 ] | MessageID = 0xfdcfe89e | vkUpdateDescriptorSets(): pDescriptorWrites[0].pBufferInfo[0].offset (1872)
must be a multiple of device limit minUniformBufferOffsetAlignment 64 when descriptor type is VK_DESCRIPTOR_TYPE_UNIFORM
_BUFFER. The Vulkan spec states: If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER or VK_DESCRIPTOR_TYPE_UNIFORM_BU
FFER_DYNAMIC, the offset member of each element of pBufferInfo must be a multiple of VkPhysicalDeviceLimits::minUniformB
ufferOffsetAlignment (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkWriteDescri
ptorSet-descriptorType-00327)
[debug] Building #2 cache object (class vkb::DescriptorSet)
[error] -36706146 - VUID-VkWriteDescriptorSet-descriptorType-00327: Validation Error: [ VUID-VkWriteDescriptorSet-descri
ptorType-00327 ] | MessageID = 0xfdcfe89e | vkUpdateDescriptorSets(): pDescriptorWrites[0].pBufferInfo[0].offset (2064)
must be a multiple of device limit minUniformBufferOffsetAlignment 64 when descriptor type is VK_DESCRIPTOR_TYPE_UNIFORM
_BUFFER. The Vulkan spec states: If descriptorType is VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER or VK_DESCRIPTOR_TYPE_UNIFORM_BU
FFER_DYNAMIC, the offset member of each element of pBufferInfo must be a multiple of VkPhysicalDeviceLimits::minUniformB
ufferOffsetAlignment (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkWriteDescri
ptorSet-descriptorType-00327) .....

Could this be caused by the different vulkan sdk version?

The samples use different frame works. One based on mine and one based on ARM samples. The ARM samples framework does have some sync/resource creation issues that might explain why you see differences between different samples.

That means those ARM samples might not work properly on WIndows. Emmmm, that sounds sad~.

Are you running the latest commit? We had a buffer alignment issue recently but since then merged a PR to fix it. I'm not seeing any of those errors on my side.

Are you running the latest commit? We had a buffer alignment issue recently but since then merged a PR to fix it. I'm not seeing any of those errors on my side.

I was running the code updated in Jul 29 with the commit 9487ac2f3be74dd0d3ce4580d3fd45cee0359cb1.
And I just pulled the latest commit and ran, but the same validation errors still remained.
I turned to use Nsight Graphics to capture those sample frames, it just worked fine.
It might be my individual problem, with something wrong on my environment. If  I figure it out, I will record it at this isssue.
And thank you very much for your reply!

Are you running the latest commit? We had a buffer alignment issue recently but since then merged a PR to fix it. I'm not seeing any of those errors on my side.

I was running the code updated in Jul 29 with the commit 9487ac2f3be74dd0d3ce4580d3fd45cee0359cb1.
And I just pulled the latest commit and ran, but the same validation errors still remained.
I turned to use Nsight Graphics to capture those sample frames, it just worked fine with the expected swapchain image.
It might be my individual problem, with something wrong on my environment. If I figure it out, I will record it at this isssue.
And thank you very much for your reply!

After updated the latest commit, the problem of renderdoc captures and validation error of bufferInfo has desappeared.
And I found out that the commit 90c1d924a01d2ebf461b8e5281869b811f7de274 exactly solved the issue.