[BUG] [SM] Valid config.json (removed IAM users) failing on step function re-run

Bug reports which fail to provide the required information will be closed without action.
Required Basic Info

Accelerator Version: 1.3.3
Install Type: (Clean)
Upgrade from version: (N/A)
Which State did the Main State Machine Fail in:  Phase 0

Describe the bug
When editing the config.json file and within the "management" account configuration, removing users from the iam block, the state machine fails. It appears that you must have a user being created for the state machine to succeed.
From looking at the code at the following location, it states that the iam object is optional, but even removing that completely from my config.json file it still fails.:
https://github.com/aws-samples/aws-secure-environment-accelerator/blob/4b4bd995417560a552af43d888f28ad13c024716/src/lib/common-config/src/index.ts#L578
In the meantime I have had to pass in a user to be created for the step function to succeed.
Failure Info

What error messages have you identified, if any:

{"acceleratorVersion":"1.3.3","Status":"FAILED","FailedState":"Deploy Phase 0","ExecutionArn":"arn:aws:states:eu-west-2:############:execution:Prefix-CodeBuild_sm:ba5e9d96-e451-4082-8183-39271a671f82","Input":{"codeBuildProjectName":"Prefix-DeployPrebuilt","environment":{"ACCELERATOR_PHASE":"0","ACCELERATOR_PIPELINE_ROLE_NAME":"Prefix-L-SFN-MasterRole-C4086704","ACCELERATOR_STATE_MACHINE_NAME":"PALZ-MainStateMachine_sm","CONFIG_BRANCH_NAME":"main","STACK_OUTPUT_TABLE_NAME":"PALZ-Outputs","BOOTSTRAP_STACK_NAME":"PALZ-CDKToolkit","CONFIG_COMMIT_ID":"7edc15d4994d1b8429a4db6ac299dff29b3d6afb","SCOPE":"FULL","MODE":"APPLY","INSTALLER_VERSION":"1.3.3","CONFIG_REPOSITORY_NAME":"PALZ-Config-Repo","CDK_DEBUG":"0","CONFIG_ROOT_FILE_PATH":"config.json","ACCELERATOR_BASELINE":"ORGANIZATIONS","CONFIG_FILE_PATH":"raw/config.json"}},"InputDetails":{"Included":true},"Name":"ba5e9d96-e451-4082-8183-39271a671f82","StartDate":1622206104187,"StateMachineArn":"arn:aws:states:eu-west-2:############:stateMachine
:PALZ-CodeBuild_sm","StopDate":1622206166085}

Required files

Please provide a copy of your config.json file (sanitize if required)

"management": {
      "account-name": "Test ASEA",
      "__LOAD": "global/primary-email.json",
      "ou": "Core",
      "src-filename": "config.json",
      "budget": {
        "__LOAD": "global/budgets.json"
      },
      "s3-retention": 180,
      "limits": {},
      "iam": {
        "users": [],
        "policies": [],
        "roles": []
      },
      "deployments": {}
    },

Steps To Reproduce

Go to config.json locate the mandatory-account-configs > management block.
ensure that the IAM block is empty

"management": {
      "account-name": "Test ASEA",
      "__LOAD": "global/primary-email.json",
      "ou": "Core",
      "src-filename": "config.json",
      "budget": {
        "__LOAD": "global/budgets.json"
      },
      "s3-retention": 180,
      "limits": {},
      "iam": {
        "users": [],
        "policies": [],
        "roles": []
      },
      "deployments": {}
    },

Commit the new config.json and trigger a full re-run of the state machine

Expected behavior
Any users created using ASEA would now be removed from the master account

Hi,
To troubleshoot the specific failure, we need the CloudWatch log from the Codebuild session (State Machine Phase) that failed.  In that log, specifically if you search for the first (not last) occurrence of UPPERCASE "FAIL" - it normally leads to the exact cause of failure.
If I was to GUESS, you removed the users and policies at the same time.  CloudFormation, which CDK synthesizes too, is not smart enough to reverse order of operations for remove versus create, so it is likely trying to delete the policy before the user that uses it has been removed, which is blocking the operation.  (i.e. remove the users, run the SM, then remove the policy, run the SM, and may resolve your problem).
To simplify your config file, once complete you can drop to using the following with the same outcome:
"management": {
      "account-name": "Test ASEA",
      "__LOAD": "global/primary-email.json",
      "ou": "Core",
      "src-filename": "config.json",
      "budget": {
        "__LOAD": "global/budgets.json"
      },
      "s3-retention": 180,
    },


GEODE-7845: adding PRClear protection code

prevent PRClear messages from going to older servers.

I am not a fan of this solution at all. I am hoping people can provide some useful feedback to make this way better.


unflip high and low flap thresholds

assuming this wasn't on purpose.
mapping monitoring_check param high and low thresholds to corrosponding
sensu::check params rather than flipping them.

somethings up with the ci build.  Gem::InstallError: listen requires Ruby version >= 2.2.3, ~> 2.2.

Yikes! Whoops! Thanks!
I'll push something else on master to fix/pin the gems unless you beat me to it.


feat: update widgets

Description
Updates widgets UI to design prototype v39 and moves them to web-relay.
Linked Issues/Tasks
Replaces https://github.com/synonymdev/bitkit/pull/1169
Closes https://github.com/synonymdev/bitkit/issues/633
https://app.asana.com/0/0/1205132561089041/f
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (improving code without creating new functionality)

Tests

[x] Detox test
[ ] Unit test
[ ] No test

Screenshot / Video

Looks like feeds are not reachable from CI for some reason.

Looking at the video from test run, I can see It can fetch feed description and later fails with "undefined is not a function" error
So, feeds are pretty much reachable

Interesting, didn't know about the video for e2e tests!
Locally, tests keep hanging because of network requests to feeds:
09:19:05.693 detox[80834] i The app is busy with the following tasks:
• There are 1 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".
• Run loop "Main Run Loop" is awake.
• The event "Network Request" is taking place with object: "URL: “https://dht-relay.synonym.to/staging/web-relay/subscribe/azswe48ifp8gmk3p44e7futnxp6dxjm6izbgdyy96nqk8876xtty/Bitcoin%20Price/feed/BTCUSD-last”".
09:19:15.695 detox[80834] i The app is busy with the following tasks:
• There are 1 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".
• Run loop "Main Run Loop" is awake.
• The event "Network Request" is taking place with object: "URL: “https://dht-relay.synonym.to/staging/web-relay/subscribe/azswe48ifp8gmk3p44e7futnxp6dxjm6izbgdyy96nqk8876xtty/Bitcoin%20Price/feed/BTCUSD-last”".

I think event streams are not supported in detox, although I can't find anything on that when looking for similar issues.

I have same error on my machine:
error: Error: Unable to resolve module web-streams-polyfill/ponyfill/es6 from /Users/limp/s/bitkit/node_modules/react-native-polyfill-globals/src/readable-stream.js: web-streams-polyfill/ponyfill/es6 could not be found within the project or in these directories:
  node_modules
  ../../node_modules
  2 |
  3 | export const polyfill = () => {
> 4 |     const { ReadableStream } = require('web-streams-polyfill/ponyfill/es6');
    |                                         ^
  5 |
  6 |     polyfillGlobal('ReadableStream', () => ReadableStream);
  7 | };
    at ModuleResolver.resolveDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:162:15)
    at DependencyGraph.resolveDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/node-haste/DependencyGraph.js:260:43)
    at Object.resolve (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/lib/transformHelpers.js:177:21)
    at Graph._resolveDependencies (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:432:35)
    at Graph._processModule (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:218:38)
    at async Graph._addDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:314:20)
    at async Promise.all (index 4)
    at async Graph._processModule (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:263:5)
    at async Graph._traverseDependenciesForSingleFile (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:207:5)
    at async Promise.all (index 0)

Should be fixed now, just a small merge mistake.


markdown preview not work

VSCode Version:1.5.3
OS Version:win10
I in put

##haha
#hehe
and in preview window i got
##haha #hehe
I don't know why .....
Steps to Reproduce:

add a file named test.md
add some words in test.md
3, click preview

You need to add spaces:
## haha
# hehe

yes ,thank you


nodejs_compat docs

Do not merge until https://github.com/cloudflare/cloudflare-docs/pull/7180 lands
Documents how to use node.js Runtime APIs with a Worker, documents available APIs.
Adds docs on how to use the nodejs_compat compatibility flag to the following places

/workers/wrangler/configuration/ (breaks existing node_compat section into two, to clarify difference between the node_compat wrangler flag and the nodejs_compat compatibility flag)
/workers/platform/compatibility-dates/#nodejs-compatibility-flag (adds a special section, distinct from other compatibility flags, for the nodejs_compat flag, since this flag is different from others, in that we never expect it to become the default, and we always want to highlight it above other flags, since it will be used much more often than most other flags)
/workers/runtime-apis/nodejs (Reiterates how to opt-in to these APIs at the top of this page, as well as at the top of each API page)

...cross linking between them to help people understand concepts (compatibility flags, runtime APIs, and wrangler configuration)
Documents the following APIs:

Buffer
EventEmitter
util
assert

@deadlypants1973 — this is ready for review.
@jasnell — adapted based off your post. Can land https://github.com/cloudflare/cloudflare-docs/pull/7180 and then merge this right afterwards.


[TR#13] Add tab component

Task
TR #13
Why?
This needs to be developed to match the revised Figma component.
What Changed

[X] Add component

Sanity Check

[X] Have you updated any usage of changed tokens?
[X] Have you updated the docs with any component changes?
[X] Have you updated the dependency graph with any component changes?

[X] Have you tried building the css?
[X] Have you tried building storybook?
Do you need to update the package version?

Screenshots

 Tabs


Version 0.12.3 AttributeError: 'str' object has no attribute 'get'

Rasa NLU version: 0.12.3
Operating system osx
Content of model configuration file:

{
    "pipeline": [
      "nlp_spacy",
      "tokenizer_spacy",
      "intent_featurizer_spacy",
      "intent_classifier_sklearn",
      "ner_crf",
      "ner_synonyms"
    ],
    "path" : "./models/nlu",
    "project": "clofusbot",
    "fixed_model_name": "current",
    "data" : "./intents",
    "port": 5004
  }

Issue:
python -m rasa_nlu.train -c nlu_model_config.json --fixed_model_name current -d ./intents
Traceback (most recent call last):
File "/anaconda3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "/anaconda3/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/Users/karthikbalu/MYDRIVE/DEVELOPMENT/Clofus/clofus-assistant/rasa_nlu/rasa_nlu/train.py", line 174, in
num_threads=cmdline_args.num_threads)
File "/Users/karthikbalu/MYDRIVE/DEVELOPMENT/Clofus/clofus-assistant/rasa_nlu/rasa_nlu/train.py", line 143, in do_train
trainer = Trainer(cfg, component_builder)
File "/Users/karthikbalu/MYDRIVE/DEVELOPMENT/Clofus/clofus-assistant/rasa_nlu/rasa_nlu/model.py", line 146, in init
components.validate_requirements(cfg.component_names)
File "/Users/karthikbalu/MYDRIVE/DEVELOPMENT/Clofus/clofus-assistant/rasa_nlu/rasa_nlu/config.py", line 146, in component_names
return [c.get("name") for c in self.pipeline]
File "/Users/karthikbalu/MYDRIVE/DEVELOPMENT/Clofus/clofus-assistant/rasa_nlu/rasa_nlu/config.py", line 146, in
return [c.get("name") for c in self.pipeline]
AttributeError: 'str' object has no attribute 'get'

There are a lot of config changes that came with 0.12 make sure you're using the docs for help on configuring 0.12.3: https://nlu.rasa.com
For example, the config file is now specified via yaml and only expects language and pipeline keys. Everything else should be specified as command line arguments: https://nlu.rasa.com/http.html#server-parameters

I'll close this for now, please let us know if you have any further questions.


BibAuthorID: take advantage of affected fields

Originally on 2013-11-19
Similarly to the record indexer, see #1573, it would be good to
take advantage of records' affected fields to see if BibAuthorID
daemon has to really run on a given modified record or not.  Example:
when only title field was changed, it should not be necessary to
trigger author disambiguation of the record.

There is no PR for this issue, hence closing it as per the legacy code base freeze; it is addressed in master code base differently.


how to chagen the Languages to Chinese

how to chagen the Languages to Chinese
I don't good at english

Download this file:
https://raw.githubusercontent.com/elBukkit/MagicPlugin/master/Magic/src/examples/localizations/messages.ZH.yml
And place it in plugins/Magic/messages/
It is a little out of date but should be a good start.

Please re-open if you need more help!


Key wrapping as defined in NIST SP800-38F

Description
Key wrapping support, as defined in NIST SP800-38F
Status
READY
Requires Backporting
NO
Migrations
New API
Additional comments
Fully feature key wrapping for KW and KWP modes
Todos

[x] Tests
[x] Documentation
[x] Changelog updated
[ ] Backported

Steps to test or reproduce
Outline the steps to test or reproduce the PR here.

@gilles-peskine-arm I addressed your comments. I have updated the API accordingly. I haven't updated documentation part yet.
Please review the API

@gilles-peskine-arm I believe I have addressed all the comments related to the API prototypes.
I haven't updated the documentation, but it shouldn't block design approval.
As long as the functions have the prototypes as their final design, we can do the fine tuning for the rest

@gilles-peskine-arm I addressed all your comments

@Patater I believe I addressed your coments, except the VS project parts, which I will work shortly on my windows machine

I updated the VS project with the files.
Please review

@gilles-peskine-arm @Patater I believe I have addressed your comments

I modified the wrapping \ unwrapping function to be as defined in RFC 3394, which is more efficient in my opinion.
This involves less memory copies, with same result.

@gilles-peskine-arm I believe I have addressed your comments

@gilles-peskine-arm I had split the latest commit and addressed your latest comments.

Note that in order to add the feature unavailable error for ARIA and Camellia, I will need to rebase, as this branch still doesn't have the Aria feature

@RonEld Please don't rebase during the review. You don't need to rebase to add the feature unavailable error. Return it for any block cipher with a block size of 128 bits which isn't explicitly supported.

@gilles-peskine-arm I disagree. We should allow only ciphers that have some standard for this algorithm.
Just because we can have the key wrapping feature for any 128-bit block cipher, doesn't mean we should.

@RonEld I don't understand your objection to returning FEATURE_UNAVAILABLE for an unsupported block cipher. That's what this error is for.

FEATURE_UNAVAILABLE error is for an allowed cipher, that we simply don't support. Not for an unallowed cipher that we don't support.

But, once again, KW and KWP allow any 128-bit-block cipher. NIST  only allows a single 128-bit-block cipher, which is AES. But we aren't NIST and we do support algorithms that NIST does not approve of. If we don't support some mode/block-cipher combinations because we don't have tests for them, fine. But FEATURE_UNAVAILABLE is the correct error code because this is a valid combination that we do not support.

I know KW and KWP allow 128 bit block cipher. and NIST restricts only aes. Nut, if there isn't some standard defining key wrapping with some 128 bit block cipher, I don't think we should allow it.
Anyway, this discussion is redundant, as the only 128 bit block ciphers other than aes that we do support and have cipher info for are aria and camellia. I'll change to FEATURE_UNAVAILABLE support.

@gilles-peskine-arm I have addressed your comments.
What about design review? Is this PR approved for design?

As far as I'm concerned this is approved for design. I still need to review the latest commits before I approve the implementation.

@gilles-peskine-arm I have addressed your comments

I reduced the width to 80 characters, but frankly I think that some lines are not so readeable with this change

Note: once #1454 is merged, need to add nist_kw.h to cpp_dummy_build.cpp to the include list

@Patater @gilles-peskine-arm I believe I have addressed all yo.ur comments

@gilles-peskine-arm I believe I have addressed your comments.

@gilles-peskine-arm I addressed your comments

@Patater I believe I have addressed your comments

@gilles-peskine-arm @Patater I believe I have addressed most of your recent comments. Some comments are not relevant from latest changes.

Changed to needs design approval as a minor change in design, regarding the usage of out_len

@Patater I have updated the header file, for design approval, I will continue working on the rest of the comments soon

@Patater I believe I have addressed your comments.
Please review

@gilles-peskine-arm I amy be missing something. Why is  https://github.com/ARMmbed/mbedtls/pull/1658#discussion_r200074210 only partially addressed? Doesn't the safer_memcmp() add the trace constant code?

@Patater I believe I have addressed all your comments.
Is the new design about out_len acceptable?

@gilles-peskine-arm I changed the padding check to constant time, if this is what you were referring to

@Patater In terms of design, I don't think the code should be implemented. Thanks!
Nonetheless, I believe I had already implemented it.

@Patater I believe I addressed your comments

@gilles-peskine-arm

API design blocker: Mbed TLS doesn't have any in-out size parameters and I don't want to introduce them in just one place

That's not entirely correct. For example:
nc_off in AES_CTR
(also blowfish and cammelia ctr modes)
Please discuss this with with @Patater As he wants to verify that we won't have a buffer overflow, and I agree with him.
I disagree, however, to add another parameter to state the output buffer size, as it's not user friendly and not clear, especially that we have a parameter that we can use as an in \ out.
As for the rest of the comments, I'll work on them

@RonEld Separate parameters for buffer size (input) and output length (output) are what most of the library does, when it doesn't leave the buffer size or output length up for guessing. I don't feel strongly between in-out size parameters and separate parameters, but I prefer separate parameters because they're clearer than having a parameter that serves two different purposes. In any case, having inconsistent design between library modules is very user-unfriendly, so given the design of the rest of the library, adding an in-out size parameter is a blocker.
nc_off is an offset, not a size. It makes a difference because a misuse has less of a chance of enabling a buffer overflow.

Separate parameters for buffer size (input) and output length (output) are what most of the library does, when it doesn't leave the buffer size or output length up for guessing.

Another example is cipher.h, when we use padding, we assume that the buffer is big enough. The same for pk_sign(), but we already discussed this example.

but I prefer separate parameters because they're clearer than having a parameter that serves two different purposes.

I disagree about this being clearer. An API should be self explanatory without documentation. Usually, when there is parameter that points to the output buffer size, it implies that it is an in \ out parameter.

In any case, having inconsistent design between library modules is very user-unfriendly, so given the design of the rest of the library

I agree that it is better to be consistent, but we aren't entirely consistent in the library when it comes to output buffer size

And as for nc_off, yes it's an offset, but it's still an in \ out parameter that is used in the library, contrary to your point that in \ out are not used

I agree that it is better to be consistent, but we aren't entirely consistent in the library when it comes to output buffer size

I personally like the inout parameter for capacity on input and a count on output, but that's yet another style added to the library. We should pick our favorite from the available choices to be consistent with, rather than add yet another inconsistent approach to the library.

The same for pk_sign(), but we already discussed this example.

pk_sign() omits the buffer capacity parameter, and we recognize this as a defect that we plan to change the next time we allow ourselves to make incompatible changes to the API (i.e. in the next major version). But it does fits the library convention: it doesn't take an input-output size parameter.

Usually, when there is parameter that points to the output buffer size, it implies that it is an in \ out parameter.

Not necessarily, it depends on the convention followed by the library. Mbed TLS doesn't follow this convention.

I agree that it is better to be consistent, but we aren't entirely consistent in the library when it comes to output buffer size

We are consistent in not using input-output size parameters, and users are used to not initializing a size_t* parameter that outputs the size of some data.

and we recognize this as a defect that we plan to change the next time we allow ourselves to make incompatible changes to the API

If we make it an in-out parameter, it doesn't need to be an API change, just a minor functional change. In addition, as mentioned before, the cipher_update has the same issue, and the output buffer is not checked.

@RonEld If we turned an output-only parameter into an input-output parameter, that would be an API breaking change, which would break plenty of perfectly sensible existing code. It would be a dangerous change because it isn't something a compiler would catch.
size_t output_size;
mbedtls_pk_sign(…, &output_size); // Note: output_size is not initialized here

@gilles-peskine-arm
Although I stongly disagree with this change of API, I modified it to contain two variables.
The example you gave in your last comment, is not a change in the interface, but a change in behaviour., which although compiloers might not catch, static analyzers will probably do.
I don't see why the padding check is not in constant time. The last full semiblock is being xored with a size_t variable. Whether it is diff or bad_padding it's according to location.
I addressed all the other issues
cc @Patater

@gilles-peskine-arm I have looked at the padding as I promised:

There is a cache based side channel that can be used as a padding oracle.
I don't see any straightforward way to use this for an attack, because there is no easy way to control the plaintext like in CBC.
Not having side-channels is a good practice in general, but I don't think that they are an immediate threat in this case.

@yanesca So to prevent a cache based channel attack, I will clear the value of diff and bad_padding, but do you see a time based channel attack?

@RonEld I see some side channel information leaking about the padding both cache and timing based, but I can't see any way to exploit them. In summary, I don't see a timing based side channel attack.

@yanesca Thank you for your comments!
Do you see anything suspicious in the current implementation?

The thing I see suspicious, is we calculate padlen and Plen regardless of whether ICV2 is correct, which might result in bad value, but worst case, the unsigned padlen will have a very large value, causing yet another authentication failure:

If calculated padlen is > 7 , then we fail in this check, and also in  i >= KW_SEMIBLOCK_LENGTH - padlen ( except when padlen is 8 ) but it will not result in overflow, as we are not using padlen to access the buffer.
If calculated padlen is < 7 then we check padding, as currently.

@gilles-peskine-arm I believe I addressed your comments

@Patater I addressed your comments. Please review
cc @gilles-peskine-arm

Now that it is approved, should I rebase to resolve conflicts in the Makefile?

@RonEld Yes, please rebase. Almost all the content of this PR is in new files, so it will be easy to review after the rebase by comparing with the current version. Before rebasing, please make sure that the current version is archived in a branch in the mbedtls repository.

Before rebasing, please ensure that MSan and Valgrind pass (they don't run in our per-PR CI job). I'm getting this error from MSan which I haven't analyzed:
library/nist_kw.c:487:18: error:
      variable 'bad_padding' is uninitialized when used here
      [-Werror,-Wuninitialized]
                 bad_padding |= output[ *out_len - KW_SEMIBLOCK_LENGTH + i ];
                 ^~~~~~~~~~~

OK, I'll initialize the bad_padding variable.

I ran MSan and valgrind, and fixed a couple of uninitialized variables that surfaced.
@gilles-peskine-arm @Patater please review

Looks like there are still Makefile conflicts that will need to get resolved before this can be merged

@gilles-peskine-arm @Patater I rebased to resolve the conflicts in the Makefile.
Please review

Note: CI fails on build for IAR. I'll have a look

@RonEld has been cleaning up the commit history, so we should expect to have to do another set of reviews

@gilles-peskine-arm @Patater I have re-written history as requested

CI failure is due to an inability to lease a pickle. (IOTTESTINF-2881)

CI also failing on FreeBSD timing-suite (known issue).

PR job succeeded except for FreeBSD timing tests and pickle lease (known issues). Msan and Valgrind passed locally. This is ready for merge.

Unfortunately this PR is failing to build under Visual Studio in cmake builds. Here's a log extract from Jenkins build #586:
    36>C:\Windows\Temp\tmpnsn7n2wc\library\nist_kw.c(642): error C2220: warning treated as error - no 'object' file generated [C:\Windows\Temp\tmpnsn7n2wc\cmake_solution\library\mbedcrypto.vcxproj]
    36>C:\Windows\Temp\tmpnsn7n2wc\library\nist_kw.c(642): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\Temp\tmpnsn7n2wc\cmake_solution\library\mbedcrypto.vcxproj]
    36>C:\Windows\Temp\tmpnsn7n2wc\library\nist_kw.c(664): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\Temp\tmpnsn7n2wc\cmake_solution\library\mbedcrypto.vcxproj]
    36>C:\Windows\Temp\tmpnsn7n2wc\library\nist_kw.c(697): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\Temp\tmpnsn7n2wc\cmake_solution\library\mbedcrypto.vcxproj]
    36>C:\Windows\Temp\tmpnsn7n2wc\library\nist_kw.c(719): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\Temp\tmpnsn7n2wc\cmake_solution\library\mbedcrypto.vcxproj]

I've kicked off a Jenkins release build of #590 to test just this PR, and am demoting the PR to needs work.
cc: @Roneld, @Patater

@sbutcher-arm Is this the only error you encountered? The links are pointing to github issue numbers.

Although I couldn't reproduce this issue, I believe I have fixed this according to the log extracted.
I have also fixed a compilation warning I encountered in windows visual studio build.
cc @gilles-peskine-arm @Patater

New commit looks fine, but it should be applied as a fixup to where that code was original introduced (09a646a927d7 "Add selftests") after we verify it passes Windows testing.
Should we also change key_len, kw_msg_len, kw_out_len, kwp_msg_len for consistency?

@Patater

Should we also change key_len, kw_msg_len, kw_out_len, kwp_msg_len for consistency?

I don't think so, because for these values, the API receives type size_t, and then we will also get a compilation warning
once we verify the windows build succeed, I will merge this PR in to the add selftests commit

OK. Thanks.

all.sh is also failing on the section test: main suites (full config). Log extract:
******************************************************************
* test: main suites (full config)
* Fri 20 Jul 10:14:56 BST 2018
******************************************************************
Running tests...
Test project /home/simbut01/work/mbedtls/mbedtls-development
...
      Start 53: nist_kw-suite
53/69 Test #53: nist_kw-suite ....................***Failed    0.00 sec

all.sh is also failing in section test: MBEDTLS_NO_UDBL_DIVISION native. Log extract:
******************************************************************
* test: MBEDTLS_NO_UDBL_DIVISION native
* Fri 20 Jul 10:44:33 BST 2018
******************************************************************
...
test_suite_nist_kw ................................................ Current use: 0 blocks / 0 bytes, max: 3 blocks / 576 bytes (total 768 bytes), alloc / free: 158 / 158
All memory de-allocated in stack buffer
FAIL

all.sh is also failing in section test: MBEDTLS_NO_64BIT_MULTIPLICATION native. Log extract:
******************************************************************
* test: MBEDTLS_NO_64BIT_MULTIPLICATION native
* Fri 20 Jul 10:45:06 BST 2018
******************************************************************
...
test_suite_nist_kw ................................................ Current use: 0 blocks / 0 bytes, max: 3 blocks / 576 bytes (total 768 bytes), alloc / free: 158 / 158
All memory de-allocated in stack buffer
FAIL

@RonEld Please do NOT modify the history of this PR before 40af97645f323e63d633ed53537d1ce6154665b2. That would make the accuracy of the history and the traceability of the review even worse than it is now.

Rebased to resolve calloc issue.
Diff at https://gist.github.com/Patater/9fc367023e2ae68ccc9e94173e612724
Original at Patater/dev/RonEld/key_wrapping-1

the only comment I have on your patch is that the calloc for the output_len should probably have the same check as input_len, but I wouldn't block the PR, as in practice, we don't send zero output length.

all.sh passes now.

A release job is running at https://jenkins-internal.mbed.com/view/mbed-tls/job/mbedtls-release/597/ as well

Release job failed due to Windows 64-bit CMake errors.
Build FAILED.

       "C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\mbed TLS.sln" (Rebuild target) (1) ->
       "C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj.metaproj" (Rebuild target) (25) ->
       "C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj" (Rebuild target) (56) ->
       (ClCompile target) ->
         C:\Windows\Temp\tmpx8rj5xn3\library\nist_kw.c(642): warning C4267: 'function' : conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj]
         C:\Windows\Temp\tmpx8rj5xn3\library\nist_kw.c(664): warning C4267: 'function' : conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj]
         C:\Windows\Temp\tmpx8rj5xn3\library\nist_kw.c(697): warning C4267: 'function' : conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj]
         C:\Windows\Temp\tmpx8rj5xn3\library\nist_kw.c(719): warning C4267: 'function' : conversion from 'size_t' to 'unsigned int', possible loss of data [C:\Windows\TEMP\tmpx8rj5xn3\cmake_solution\library\mbedcrypto.vcxproj]

I finally managed to reproduce the issue, and fixed it. I accidentally changed different  variable to unsigned int.
fixed now.

New release job running at https://jenkins-internal.mbed.com/view/mbed-tls/job/mbedtls-release/598/

Windows release testing job passed.

Rebased on top of latest development branch
Added a new commit to add the new header file to the cpp_dummy_build

For reference's sake, here's the final diff between what was reviewed by @Patater @RonEld @dgreen-arm and @sbutcher-arm
https://gist.github.com/Patater/070c8379d41dfcf083fbb5adbb506999
The second column of plusses is the changes added by the new version of this PR
The first column of plusses is the diff added by the rebase onto the latest development branch that provides context for the new changes

Apologies if this was already discussed, but GitHub doesn't make it easy to search through all the comments.
Is there a reason this cipher mode isn't integrated with the standard mbedtls_cipher_* interface?

@jethrogb Key wrapping is a fairly special use case, which has a specific purpose, whereas the cipher module is about encrypting arbitrary data. Furthermore key wrapping operates on the whole input in a single shot, whereas modes supported by the cipher module allow piecewise (multipart) operations. For these reasons I don't think we'll integrate key wrapping modes in the cipher API. Do you have a use case for it?

@gilles-peskine-arm "Key Wrap" is just a name and this is really a non-randomized authenticated encryption cipher mode. There are other cipher modes that are single shot (CCM*).
Guidance from SP800-38F §3.1 on this matter:

Nevertheless, there is no requirement to protect cryptographic keys with a distinct cryptographic method. Previously approved authenticated-encryption modes—as well as combinations of an approved encryption mode with an approved authentication method—are approved for the protection of cryptographic keys, in addition to general data.
Similarly, KW, KWP, and TKW are each approved for the protection of general data, as well a s cryptographic keys.

CCM could be done multi-part, but since you need to know the length up front, most APIs implement it as single-shot only.

@jethrogb Sure, it can be used for any kind of data, but in practice, is it commonly used for anything other than a key and possibly some associated metadata?
It's true that we do provide CCM through the cipher module, but only through the single-shot functions. But CCM is a very widely used AEAD mode (especially in the IoT world), whereas the NIST KW modes are rarely used for general-purpose AEAD.

My use case is that I currently use the cipher API for key wrapping (GCM or CCM), and it would be nice if I didn't have to use a completely different API to do the same with KW/KWP. I'm happy to write the patch for this as well, if you decide that it would be worthwhile.

@jethrogb This makes sense. I've filed it as #2003 so we don't forget it.
I can't make any promises as to whether or when we'll do it, but if you write a patch that conforms to our coding standards, that would be appreciated and that would increase the chances of getting it done faster.


Navbar on landing page added, group and groupToUser added

Navbar on landing page added with Bootstrap
MVC groups, and GroupToUSer added
SOme of the test covering them added

Tests are not passing because we decided to move on for time's sake and to focus on passing tests later since this is only merging to Beta and not Main.
Acceptance Criteria:

The landing page is the family tree.
Easily clickable tabs to switch features.

Definition of Done:

Code is reviewed
Code is tested by peer
Pull request is merged by its reviewer
Feature is deployed


Provide more information on the event template card

Whether the template has a process, default participants and so on

Done when refactoring the cards rendering. See: https://github.com/kalisio/aktnmap/issues/273


Suggestion: variance weighted sum of experts

Hi Lucas,
Product of experts reminds me of cross-correlation in signal processing, it works well in high noise but it is a harsh filter.
I would like to suggest a "sum of experts" method, which when predicting a point evaluates the stdev from each expert. The inverse of the relative stdev is then used to weight the sum of these predictions.

I would say that this method produces "softer" averaging than the product of experts method, at the expense of computational resources at the prediction stage. I believe it could produce more accurate results however, and provided the prediction computation could be distributed also, it could be quite scalable.

A quick implementation shows that a variance weighted sum under-performs compared to the full treatment, but non-linear biasing that variance weighted sum improves the result. The result is improved further still by selecting the single-best predictor.

I must admit that I have little experience in signal-processing approaches. However, the paper that this implementation was based on compares a few weighting procedures and is worth reading if you haven't seen it and are considering other weighting formulae.
Before I was distracted by my job, my original plan was to implement several of the procedures in the paper to facilitate comparisons. However simply getting through the primary rBCM was challenging enough for me and there are some critical bugs that remain so I never got to it. I'm not opposed to adding others such as this into the project though.
If you're interested in doing it yourself, I'd suggest switching the 'weighting.py' file to a 'weighting' directory module and putting the original and this new approach under there. However, I'm interested as well and once I get some time I'll get back to experimenting on this and see how it goes.
Thanks for your interest!

Thanks I will take a look into that paper.
BTW I also came up with a crude clustering method to make the above work as well as that, I was thinking to integrate that since it's actually very simple. This is the clustering of an 18 dimensional dataset designed to preserve the original structure of the data.
Compared to random clustering it has half of the error, and compared to K-means it is 15% better in early tests.

An interesting summary of mixtures of experts over the past 20 years.
20 years mixture of experts.pdf

I am considering some "soft clustering" approaches where some data (<5% at the cluster edges) is shared between adjacent clusters. This would remove the (corner) case where data is not accurately predicted by any single group since it is at the edge of one cluster and not present in another split of the data.
In my clustering approach this is trivial to add by simply making it divide the data by the distance metric into slightly overlapping chunks ~5% of the chunk width. If the chunk population is < threshold, fix overlap to some sensible number


How to achieve ZoomableGlobe under current version?

I notice that there is a API called ZoomableGlobe which supports zoom and rotate in the map. But it disappears in the master branch. Is there an easy way to implement it?

Took a while to find, but it was commited here https://github.com/zcreativelabs/react-simple-maps/commit/51178d041dbb1e7e77b0d6e1d8b8d2c25d7f570f#diff-4486c9691fe14ecc7db27addcb8692dad0d6e618a036c1027bbac182ba488166


Use the given password in the config

See https://jira.mesosphere.com/browse/DCOS-16035.
This makes it possible to set the DCOS_SUPERUSER_PASSWORD for an enterprise cluster without hashing the password yourself.
I have tested this by creating a cluster and then using the DC/OS CLI as follows:
dcos cluster setup http://<IP_ADDRESS> --username admin --password <my_password> --no-check

Authentication succeeds.
This makes overriding the hash manually a little more complex - maybe the override command needs to include "echo". There may be ways to fix this, like having the command look at the environment for an existing variable, but I think that this complexity can be added when the feature is requested.
This shouldn't be worked out at the time of the variable definition as it is a slow process (a few seconds) and it is not necessary for e.g. make clean.

cc @mhrabovcin @karlkfi

As discussed on Slack it would be nice to remove the unused variable and not implement a mechanism that makes the file common.mk contain sensitive data.

Thank you @jgehrcke and @mhrabovcin for the feedback. I am closing this in favour of https://github.com/dcos/dcos-docker/pull/51.


CD fixes nedded for Release 1.2.1

Issue link
This Pull Request is linked to issue https://github.com/valkey-io/valkey-glide/issues/2885
The usage of /home/ubuntu/actions-runner/_work/valkey-glide that replaced by /home/ubuntu/action-runner-ilia/_work/valkey-glide is a bad idea in general.
It should move to environment parameters, or better, to be replaced by the new runners' logic.
As for this fix, it's just replacement to old hard codded values with the currents.
Checklist
Before submitting the PR make sure the following are checked:

[x] This Pull Request is related to one issue.
[x] Commit message has a detailed description of what changed and why.
[-] Tests are added or updated.
[-] CHANGELOG.md and documentation files are updated.
[x] Destination branch is correct - main or release
[x] Commits will be squashed upon merging.

The renaming of the folder was a quick hack to unblock the release.
No need to have it in the code - I have created a symlink 'actions-runner' to the new folder so no change is required.
I see there are addition changes besides the renaming, please make sure we still need them


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_d2fx1llrsu/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_d2fx1llrsu/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_d2fx1llrsu/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_79gaxku03r/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_79gaxku03r/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_79gaxku03r/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
Errors were found


Update README.md

Lab test run feedback.

This PR fixes several spelling mistakes and moves us to use an Oxford comma.


Using zig cc

I don't know if this is another skill issue on my end or related to zig cc or webui.  I'm using c as my backend language, but attempted to use zig cc as my compiler to also have cross compile abilities.
Using make CC="zig cc -target x86_64-linux-musl" everything works just as it should.  I'm able to use zig cc to build my project against musl no problem.
However, when I try make CC="zig cc -target x86_64-windows-gnu" it outputs a lot of errors related linker errors with civetweb.  Is there something else that I should be doing when trying to cross compile on windows, is this related to zig or does something else needed to be handled with webui?

Both webui and zig-webui provide build.zig. If you want to use them for cross-compilation, just use zig build examples -Dtarget=x86_64-windows-gnu，this will compile x86 64 bits windows' exe with GNU C

make will execute the makefile prepared for Linux and Macos, which lacks linking some libs required by Windows, so theoretically it cannot be compiled.

Yea, straight zig build still gives me the error on Ole32, which I think is also what it was complaining about using make as well.  It seems to work on the host system, but not when cross compiling.

Because the lib should be ole32 on linux, not Ole32

Windows is not case sensitive when linking libraries

You can temporarily use the zig-webui build library, which is the same as webui.

I noticed the main branch was updated as well, it appears to be working there now.  I managed to get that and the zig-webui working as well.  I may try out the wrapper, I've been meaning to learn more zig (I can't mentally handle Rust, zig seems to make more sense to me), but still in the baby steps phase.
Thanks for the help!!!


How can I implement Dark theme?

Summary
Hello, I would like to add toggle button for dark theme, do I need to install anothrt plugin for this to work?  Thanks
Relevant information

Hey @tungandy! By now, the only way is basically shadowing files and adding the dark implementation, but we are working on version 3.0 that will include it by default, without any effort or need to shadow files 💜

Hey!
I am using this to build a website for open source library docs and I shadowed the<EMAIL_ADDRESS>here is my code
import React from "react";
import { Global, css } from "@emotion/core";
import { useTheme } from "emotion-theming";
import { lighten } from "polished";

export default function GlobalStyle() {
  const theme = useTheme();

  return (
    <Global
      styles={css`
        @import url("https://fonts.googleapis.com/css?family=Roboto&display=swap");
        @import url("https://fonts.googleapis.com/css?family=Inter&display=swap");

        *,
        *::after,
        *::before {
          margin: 0;
          padding: 0;
          box-sizing: border-box;
        }

        *::selection {
          background: ${lighten("0.35", "#d6d6d6")}!important;
        }

        body {
          font-size: 16px;
          font-family: "Inter", sans-serif;
          background-color: #0e0e0e;
          text-rendering: optimizelegibility;
        }

        h1 {
          font-size: 32px;
          color: ${theme.colors.background};
          font-weight: normal;
          margin-bottom: 24px;
        }

        h2 {
          font-size: 24px;
        }

        h3 {
          font-size: 18px;
        }

        h4 {
          font-size: 16px;
        }

        h2,
        h3,
        h4,
        h5,
        h6 {
          color: #d6d6d6;
          margin: 24px 0 16px 0;
          font-weight: normal;
        }

        p {
          color: #d6d6d6;
          font-size: 16px;
          line-height: 28px;
          margin-bottom: 16px;
          font-weight: 400;
        }

        code.inline-code {
          display: inline-block;
          vertical-align: middle;
          line-height: 1;
          padding: 0.2em 0.2em 0.3em 0.2em;
          background-color: #44475a;
          color: rgba(248, 248, 242);
          font-size: 14px;
          border-radius: 3px;
          font-feature-settings: "clig" 0, "calt" 0;
          font-variant: no-common-ligatures no-discretionary-ligatures
            no-historical-ligatures no-contextual;
        }

        a {
          color: #d6d6d6;
          font-weight: bold;

          &:hover {
            color: #5991c1;
            transition: all 100ms cubic-bezier(0.4, 0, 0.2, 1) 0s;
            opacity: 1;
          }
        }

        blockquote {
          margin: 0;

          p {
            padding: 1rem;
            background: #232323;
            border-radius: 5px;
          }
        }

        hr {
          border: 0;
          height: 0;
          border-top: 1px solid rgba(0, 0, 0, 0.1);
          border-bottom: 1px solid rgba(255, 255, 255, 0.3);
        }

        table {
          border-collapse: collapse;
          border-spacing: 0;
          width: 100%;
          margin-bottom: 16px;
          color: #444;
        }

        th,
        td {
          text-align: left;
          padding: 12px;
        }

        tr:nth-of-type(2n) td {
          background-color: ${theme.colors.sidebar.itemActive};
        }

        tr {
          background-color: #ffffff;
        }

        iframe {
          margin-bottom: 16px;
        }

        img {
          max-width: 100%;
        }

        ul,
        ol {
          color: #d6d6d6;
          padding-left: 15px;
          margin-bottom: 16px;

          li {
            line-height: 28px;
          }
        }

        .gatsby-highlight {
          position: relative;

          .token {
            font-style: normal !important;
          }
        }

        pre[class*="language-"]::before {
          background: #d9d7e0;
          border-radius: 0 0 4px 4px;
          color: #232129;
          font-size: 12px;
          font-family: SFMono-Regular, Menlo, Monaco, Consolas,
            "Liberation Mono", "Courier New", monospace;
          letter-spacing: 0.075em;
          line-height: 1;
          padding: 0.25rem 0.5rem;
          position: absolute;
          left: 1rem;
          text-align: right;
          text-transform: uppercase;
          top: 0;
        }

        pre[class*="language-"] code {
          font-family: SFMono-Regular, Menlo, Monaco, Consolas,
            "Liberation Mono", "Courier New", monospace;
          font-variant: no-common-ligatures no-discretionary-ligatures
            no-historical-ligatures no-contextual;
        }

        pre[class~="language-js"]::before,
        pre[class~="language-javascript"]::before {
          content: "js";
          background: #f7df1e;
        }

        pre[class~="language-jsx"]::before {
          content: "jsx";
          background: #61dafb;
        }

        pre[class~="language-typescript"]::before,
        pre[class~="language-ts"]::before {
          content: "ts";
          background: #294e80;
          color: #fff;
        }

        pre[class~="language-tsx"]::before {
          content: "tsx";
          background: #294e80;
          color: #fff;
        }

        pre[class~="language-graphql"]::before {
          content: "GraphQL";
          background: #e10098;
          color: #fff;
        }

        pre[class~="language-html"]::before {
          content: "html";
          background: #005a9c;
          color: #fff;
        }

        pre[class~="language-css"]::before {
          content: "css";
          background: #ff9800;
          color: #fff;
        }

        pre[class~="language-mdx"]::before {
          content: "mdx";
          background: #f9ac00;
          color: #fff;
        }

        pre[class~="language-shell"]::before {
          content: "shell";
        }

        pre[class~="language-sh"]::before {
          content: "sh";
        }

        pre[class~="language-bash"]::before {
          content: "bash";
        }

        pre[class~="language-yaml"]::before {
          content: "yaml";
          background: #ffa8df;
        }

        pre[class~="language-markdown"]::before {
          content: "md";
        }

        pre[class~="language-json"]::before,
        pre[class~="language-json5"]::before {
          content: "json";
          background: linen;
        }

        pre[class~="language-diff"]::before {
          content: "diff";
          background: #e6ffed;
        }

        pre[class~="language-text"]::before {
          content: "text";
          background: #fff;
        }

        pre[class~="language-flow"]::before {
          content: "flow";
          background: #e8bd36;
        }
      `}
    />
  );
}

Hope this helps

Sounds great, cant wait for the new version!

Hey,
We have worked in the past months to build a great and complete solution for simple documentation websites. As we have changed our plans for the project, we won't include anymore search, dark mode, or i18n.
If you need a search solution, I'd recommend taking a look at other documentation starters, like gitbook or you can build your own solution by shadowing the theme files (also, look at #61 to see options of what you can use),
For dark mode, there's still hope. We have refactored the whole theme to use the colors defined on the styles/theme.js object. You can include it by default by changing the colors to dark. If you want to know more, check this doc we have created.
If you have any questions, feel free to reach out. I'd love to help 💜

Hey,
We have worked in the past months to build a great and complete solution for simple documentation websites. As we have changed our plans for the project, we won't include anymore search, dark mode, or i18n.
If you need a search solution, I'd recommend taking a look at other documentation starters, like gitbook or you can build your own solution by shadowing the theme files (also, look at #61 to see options of what you can use),
For dark mode, there's still hope. We have refactored the whole theme to use the colors defined on the styles/theme.js object. You can include it by default by changing the colors to dark. If you want to know more, check this doc we have created.
If you have any questions, feel free to reach out. I'd love to help 💜


Add option to remove PDBs for non-ready resources

This adds a flag --non-ready-ttl which, when set, will make the
controller remove managed PDBs in case the pods of a targeted
deployment/statefulset are not ready for ttl time.
Enabling this feature ensures that broken deployments won't block
cluster operations.
Fix #13

Coverage decreased (-28.2%) to 36.26% when pulling 7e5390e5799351d75357a9bca31462fdbdec5ae3 on non-ready-ttl into 3ea3e5d1e1fa4a7cf7cc30d9bf7090297acac24a on master.

👍

👍


Multisearchable rank by closest

I have a multisearchable columns for many users and posts and I'd like to rank them by closest match.
currently it ranks as so
Eg search term, "Jason Ball"

Sam Ball
Jason Smith
Article about beach ball
Jason Ball

I would like to rank Jason Ball higher than the first two ranking.
Tried fiddling around PgSearch.multisearch_options{ ranked_by: } to no avail, could use a bit of guidance here
PgSearch.multisearch_options = {
  using: {
    tsearch: { any_word: true },
    trigram: { threshold: 0.4 }
  },
  ranked_by: "(:tsearch * 1.5) + (:trigram * 1.0)"
}

I have a similar issue: https://github.com/Casecommons/pg_search/issues/354
I think I might end up just using the raw sql, but it would seem that you also want to rank by exact matches, where the tsearch or trigram rank is not the most similar result.

I made a ruby class you might find useful @choonggg: https://gist.github.com/kluzny/498e3a3bace43b0e44ce07add44a99fa
Not as feature rich as the gem, but will likely solve your use case.

+1

+1


improvement optimize template function log for performance

Proposed changes
change log level to debug and use format in template function log for performance.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.59 seconds
stream load tsv:          544 seconds loaded<PHONE_NUMBER>9 Bytes, about 131 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size:<PHONE_NUMBER>1 Bytes

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.56 seconds
stream load tsv:          551 seconds loaded<PHONE_NUMBER>9 Bytes, about 129 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>4 Bytes


initialize new List(len) items with null

We can use Array.prototype.fill to do this. It may have some overhead at allocation time, but it avoids the slowness associated with accessing an array with holes.
(After this change, we may also want to reconsider if we need to handle JS undefined as Dart null in DDC. If we know Dart code never creates undefined we could optimize null checks, == and identical. However, it may still be required due to undefined from HTML and/or JS interop.)

I filled https://bugs.chromium.org/p/v8/issues/detail?id=6892 just in case.

@mraleph
I did this, which does show a small perf benefit:
https://dart-review.googlesource.com/c/sdk/+/11242
For new List(n), it generates:
var list = new Array(n);
list.fill(null);

From, your comment, though, it doesn't fix the issue with holes.

@vsmenon it fixes issue with holes, but I don't think fill(...) is super efficient by itself right now. It is written in JS...
(Note: there is a difference between array containing any holes and array having holey element kind - element kind is more pessimistic because it can't track when the last hole disappears).


Issue with autofocus directive

Seems like the "autofocus" directive that comes with ng2-bs3-modal overrides the default autofocus attribute. If you assign autofocus to an input element which is not a part of a modal dialog, you get "No provider for ModalComponent!" exception.

@adaneam this is hopefully fixed in v0.8.0. Lemme know if you find otherwise.


Pack constraint strange behavior

Hello, I want to use the Pack() function (https://developers.google.com/optimization/reference/python/constraint_solver/pywrapcp#pack_1) of the Routing solver.
I read the documentation and I wrote some code based on the basic VRP example (https://developers.google.com/optimization/routing/vrp#entire_program1) to test this function.
In the above VRP example, I just added the following code before the solver starts to search for a solution:
    solver = routing.solver()

    all_vars_to_pack = [solver.IntVar(0,2,"a"), solver.IntVar(0,2,"a")]

    for var in all_vars_to_pack:

        routing.AddToAssignment(var)

    pack_constraint = solver.Pack(all_vars_to_pack, 2)

    usage_vars = [solver.IntVar(4,4,"a"), solver.IntVar(4,4,"a")]

    for var in usage_vars:

        routing.AddToAssignment(var)

    pack_constraint.AddSumVariableWeightsLessOrEqualConstantDimension(usage_vars, [3, 5])

    solver.Add(pack_constraint)

The problem is this: When the program is executed, I see that it packed both of the items (quantity 4+4=8) in the 2nd bin which is not feasible because the capacity of the 2nd bin is 5.
My questions are the following:

Is there a way to avoid the mixing of items?

Are there any examples of how to properly use the Pack class and Pack() function while trying to solve a VRP?

What are the values of all_vars_to_pack in the assignment ?
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le dim. 28 juin 2020 à 20:58, AntonisK<EMAIL_ADDRESS>a écrit :

Hello, I want to use the Pack() function (
https://developers.google.com/optimization/reference/python/constraint_solver/pywrapcp#pack_1)
of the Routing solver.
I read the documentation and I wrote some code based on the basic VRP
example (
https://developers.google.com/optimization/routing/vrp#entire_program1)
to test this function.
In the above VRP example, I just added the following code before the
solver starts to search for a solution:
solver = routing.solver()

all_vars_to_pack = [solver.IntVar(0,2,"a"), solver.IntVar(0,2,"a")]

for var in all_vars_to_pack:

    routing.AddToAssignment(var)

pack_constraint = solver.Pack(all_vars_to_pack, 2)

usage_vars = [solver.IntVar(4,4,"a"), solver.IntVar(4,4,"a")]

for var in usage_vars:

    routing.AddToAssignment(var)

pack_constraint.AddSumVariableWeightsLessOrEqualConstantDimension(usage_vars, [3, 5])

solver.Add(pack_constraint)

The problem is this: When the program is executed, I see that it packed
both of the items (quantity 4+4=8) in the 2nd bin which is not feasible
because the capacity of the 2nd bin is 5.
My questions are the following:

Is there a way to avoid the mixing of items?
2.
Are there any examples of how to properly use the Pack class and
Pack() function while trying to solve a VRP?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/2087, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3I6FVLGCK5J52SLMSTRY6HHFANCNFSM4OKU63RA
.

Each var of all_vars_to_pack list has 1 as value in the assignment.


NavSat Implementation

Hi !
I am now adding GNSS positionning to my cartographer_ros implementation.
I use navsat fix messages that I acquired from an antenna and reciever.
In cartographer 3D that used to work without it , I changed these lines:
launch file:
<remap from="fix" to="navsat_pos" />
<node pkg="tf" type="static_transform_publisher" name="tf2" args="0 0 0 0 0 0  base_link navsat_link 50" />
lua file:
use_nav_sat = true
The result is this:
[ WARN] [1558448912.285468952,<PHONE_NUMBER>.718096664]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.
[ INFO] [1558448912.285897776,<PHONE_NUMBER>.719421622]: I0521 16:28:32.000000 15402 sensor_bridge.cc:88] Using NavSatFix. Setting ecef_to_local_frame with lat = 12.6139, long = 1.43339.
[ WARN] [1558448912.288218687,<PHONE_NUMBER>.822027745]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
[ WARN] [1558448912.291843581,<PHONE_NUMBER>.921378049]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.
[ WARN] [1558448912.294411677,<PHONE_NUMBER>.017106302]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.
[ WARN] [1558448912.296625682,<PHONE_NUMBER>.107034573]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.
[ WARN] [1558448912.298618946,<PHONE_NUMBER>.206882088]: W0521 16:28:32.000000 15402 tf_bridge.cc:52] "imu_link" passed to lookupTransform argument target_frame does not exist.

And a lot more of this warning to finish by killing cartographer...
So navsat topic is seen but it doesn't work.
What did I do wrong ?

hi， can you share how to add gps in cartographers 2d mapping and pure localization ?

Hi Karltlbm, do you have gps rosbag data shared?

Hi all, thanks for your help but I stopped working on this topic. Good luck :)


[tcgc] Fix generated name

All changed packages have been documented.

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/444/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/444/


Includes

How to add include to index with fluent api or another way.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f85ea32c-8d23-d61d-6036-cd772e3e95d9
Version Independent ID: 25dd8ac4-2521-5200-0ddf-63ac8c83787a
Content: Indexes - EF Core
Content Source: entity-framework/core/modeling/indexes.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @rowanmiller
Microsoft Alias: divega

I'm assuming you're asking how to include columns inside your index. If that's the case see the documentation here, otherwise post back and I'll reopen the issue.
Note: I'll be merging the relational index doc page (where this info lives) into the general index modeling page, that's already tracked by #1669


More about SQLi?

This might be a dump question, but the ORM exercise readme mentions that:

a library like SQLi creates one instance for each row of a query expressed in SQL. So two different queries on the same table may use two different classes

However, I am not able to find any relevant information about the library SQLi. Could you please give some pointers?

brainfart :)
SQLi should be JDBi (https://jdbi.org/)

fixed by https://github.com/forax/write_your_own_java_framework_exercices/commit/642185237fa941b1593e28b33171a61dce178dc0


Support jlenv

I made configurations for jlenv.
Would you merge it?

cc: @riywo
It looks so nice! I hope that this request would be merged.
However, this project stopped to activity since over 6 months ago.


text lang keyword not propagating into figure

When using for instance #set text(lang:"is") the figure caption does not inherit the figure formatting of the document, meaning it displays "figure N:" and not "Mynd N:" as it should.

When I wrote the feature to propagate supplements, I had to essentially copy the built-in supplement behavior, and it seems the supplements of is might have been added after this feature was initially added. I'll update the list of supplements, but for now you have two ways to get around this:

set the supplement yourself on the figure using supplement: [Mynd]
turn off propagation by passing propagate-supplement: false and it'll make use of the built-in supplement mechanism

The latter will mean that if you mix figure kinds (an image figure containing listings, for example), you may get unexpected results. If you don't do this, turning off propagation should have no downsides.

Fixed in #22.


Confidence interval for SK distance

Add get_sk_ci to helpers:

Inputs

Number of replicates
Maximum positive distance, maximum negative distance
Alpha (defaults to 0.05)

Outputs

Lower bound of CI, upper bound of CI

Methods

See section confidence interval for SK distance in docs

Add to initialization block in main code that looks roughly like this:
 [self.sk_pos, self.sk_neg] = helpers.get_sk_dist(self.replicates, norm(loc = estimate, scale = se), sep = True)
 [self.sk_ci_lb, self.sk_ci_ub] = helpers.get_sk_ci(leng(self.replicates), self.sk_pos, self.sk_neg)

@isandrews in f5b629b I sketched the methods I think we should use here. (Snip below for convenience.)
Can you let me know if this looks right?
(If you like, feel free to also check the design in https://github.com/JMSLab/BootstrapReport/issues/19#issue-2002786349.)

Looks good to me - thanks @jmshapir!

@jmshapir, I added the function for producing the SK CI's in https://github.com/JMSLab/BootstrapReport/commit/b547b56c23024fd549af4af9d7fd72e91f1cedaf.

@rcalvo12 great thanks! Let's add a unit test and open a pull with @isandrews @jmshapir @MosesStewart as reviewers.

Thread continues in #20.

Summary:
In this issue we added a function for calculating confidence intervals for the SK distance as well as unit testing.
Merged in https://github.com/JMSLab/BootstrapReport/commit/2cfe33c2e0563a69893f9fc13cd2ca90c7c126d6.
Final state of issue branch here.


[SPARK-41445][CONNECT] Implement DataFrameReader.parquet

What changes were proposed in this pull request?
This PR implements DataFrameReader.parquet alias in Spark Connect.
Why are the changes needed?
For API feature parity.
Does this PR introduce any user-facing change?
This PR adds a user-facing API but Spark Connect has not been released yet.
How was this patch tested?
Unittest was added.

LGTM!

Merged to master for Apache Spark 3.4. Thank you, @HyukjinKwon and all!


Fix typo in control-flow-wait-activity.md

Correct header to refer to the Wait activity the page documents.

@yobryon : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@chez-charlie
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"


ExcelWriterMixin null column not allowed

I dump data from mysql query stream and there is null allowed column.
Now I have to check null value and convert it to empty string.
In my opinion it is not necessary. Instead, leave cell empty.

I've fixed this issue, just the way you recommended. The fix is in v0.3.24.


Plugin cleanup - Franz from goatplace

This PR addresses the following:

removed unused dependencies and files
general cleanup of csproj file
adjustments for DalamudPackager to result in working artifact

NOTE: I've disabled automatically building to devPlugins as this may be being phased out in the future. It's recommend to use the External DevPlugins Folder feature in Dalamud Settings instead. You'll find the files for DalamudPlugin PRs in <source>\FullscreenToggle\bin64\Release. The entire folder can be copied over, as it will now generate the correct structure for an images folder, zip, and manifest with the correct details filled out.
The previously PRed manifest was incorrect, which resulted in the plugin not being installable once the PR was merged. This should help resolve that!

ah nice. thanks for catching these.


DEVICE_DISCONNECTED_C as -255 exceeds int8_t storage

DEVICE_DISCONNECTED_C was defined as -127 which has no issues around storage size. However, a change to make this -255 causes warnings and a compiler 'conversion' of -255 ==> 1.
This change has created warnings in what was a totally clean build library. And it may also cause real problems in the disconnected case.
int8_t DallasTemperature::getHighAlarmTemp(const uint8_t* deviceAddress)
This function returns an 8-bit signed value who's range is -127 to 128 but the DEVICE_DISCONNECTED_C is now -255 (used to be -127).

See commit - https://github.com/milesburton/Arduino-Temperature-Control-Library/commit/ac1eb7f56e3894e855edc3353be4bde4aa838d41#commitcomment-75490966

(from the commit comments)
Some options

revert the values and accept that they are in range of the MAX31850
create a separate class for MAX31850
create a derived class for MAX31850
replace all int8_t code into int16_t in the library.

Option 1 is the quick fix.
Drawback is that -127°C is within the MAX31850 range. Applications that use these low temperatures (liquid N2 ?) would possibly be affected, however:
According to the datasheet - https://datasheets.maximintegrated.com/en/ds/MAX31850-MAX31851.pdf -
The converters resolve temperatures to 0.25°C, allow readings
as high as +1768°C and as low as -270°C, and exhibit
thermocouple accuracy of 8 LSBs (2°C) for temperatures
ranging from -200°C to +700°C
So even the current DEVICE_DISCONNECTED_C   -255 is technically in the range of the MAX31850 converter.

We could throw in an Option 5 and use a C++ Macro to enable those who need
such a broad range of temperatures?
I presume those who need -200C are likely outliers.
On Tue, 7 Jun 2022 at 16:59, Rob Tillaart @.***> wrote:

(from the commit comments)
Some options

revert the values and accept that they are in range of the MAX31850
create a separate class for MAX31850
create a derived class for MAX31850
replace all int8_t code into int16_t in the library.

Option 1 is the quick fix.
Drawback is that -127°C is within the MAX31850 range. Applications that
use these low temperatures (liquid N2 ?) would possibly be affected,
however:
According to the datasheet -
https://datasheets.maximintegrated.com/en/ds/MAX31850-MAX31851.pdf -
The converters resolve temperatures to 0.25°C, allow readings as high as
+1768°C and as low as -270°C, and exhibit thermocouple accuracy of 8 LSBs
(2°C) for temperatures ranging from -200°C to +700°C
So even the current DEVICE_DISCONNECTED_C -255 is technically in the
range of the MAX31850 converter.
—
Reply to this email directly, view it on GitHub
https://github.com/milesburton/Arduino-Temperature-Control-Library/issues/219#issuecomment-1148863258,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJGHM5T2NVCK5GQWW3LKTLVN5WWLANCNFSM5YDJWOKQ
.
You are receiving this because you are subscribed to this thread.Message
ID: <milesburton/Arduino-Temperature-Control-Library/issues/219/1148863258
@github.com>

A macro sounds like a better fix than reverting. +1

Hey guys - Any chance of getting a decision on the solution here and getting it published? I'd love to not fork to get this settled in my own builds. Thanks!

I think a macro is the way to go, unfortunately I don't have an IC to actually test the change so I'm hesitant to raise a PR until I know it won't nuke anything.
If you want to make the change Rob and I can give you a review?

Well, for me it's not a quandry - I'd just pick option 1 and revert the change. :)   But if you're going to cope with this otherwise, I'd think the 16-bit change would be proper but I'm not clear on whether a 2-byte value would be problematic for other reasons. But I'm concerned that the macro would map things that are technically still out of bounds. That seems like just askin' for trouble down the line. Right?

Let me grab a branch and I'll get back to you
On Tue, 5 Jul 2022 at 07:12, Robert Wolff @.***> wrote:

Well, for me it's not a quandry - I'd just pick option 1 and revert the
change. :) But if you're going to cope with this otherwise, I'd think the
16-bit change would be proper but I'm not clear on whether a 2-byte value
would be problematic for other reasons. But I'm concerned that the macro
would map things that are technically still out of bounds. That seems like
just askin' for trouble down the line. Right?
—
Reply to this email directly, view it on GitHub
https://github.com/milesburton/Arduino-Temperature-Control-Library/issues/219#issuecomment-1174656800,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJGHM5K3SPSJF7XDVOAAVDVSPG5HANCNFSM5YDJWOKQ
.
You are receiving this because you commented.Message ID:
<milesburton/Arduino-Temperature-Control-Library/issues/219/1174656800@
github.com>

Can someone sanity check this reversion: https://github.com/milesburton/Arduino-Temperature-Control-Library/pull/223

Take two. Helps if I don't mix up my data types: https://github.com/milesburton/Arduino-Temperature-Control-Library/pull/224

@bobwolff68 Change merged. Let me know if that solves your problem. I'll close the issue for now (we'll revisit the Macro when I get a test setup on the bench)

Thanks, Miles. Re-compiled with the change - zero warnings is a beautiful
thing. Let me know when the macro version comes aroun d- happy to give that
one a spin as well.
--bob
On Tue, Jul 5, 2022 at 4:23 AM Miles Burton @.***>
wrote:

Closed #219
https://github.com/milesburton/Arduino-Temperature-Control-Library/issues/219
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/milesburton/Arduino-Temperature-Control-Library/issues/219#event-6933610430,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFYP5VHFWY5MMJQ7GWDYHTVSQLMRANCNFSM5YDJWOKQ
.
You are receiving this because you were mentioned.Message ID:
<milesburton/Arduino-Temperature-Control-Library/issue/219/issue_event/6933610430
@github.com>


Require inside if produces semantically different or invalid code

rollup version: 1.0.1
rollup-plugin-commonjs version: 9.1.3
When there is a require inside an if statement with no braces, the resulting bundle can be invalid or at least semantically very different. Consider these files:
// main.js
if (Math.random() < 0.5)
  require('./mod.js');

// mod.js
foo = 1

Resulting IIFE bundle:
var test = (function () {
  'use strict';

  foo = 1;

  if (Math.random() < 0.5) // <- Problem here

  var main = {

  };

  return main;

}());

A real-world example of where I ran into this was with the treo WebSQL plugin, here: https://github.com/treojs/treo/blob/master/plugins/treo-websql/index.js#L24

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid.
We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets reopened and transferred to the new repo. :beer:

@shellscape I'm still able to replicate this issue with the latest versions of rollup and this plugin:

rollup: 1.27.4
rollup-plugin-commonjs: 10.1.0

@edsrzf OK thanks. Can you put together a very small repo that demonstrates a reproduction? We'll need it once the issue is transferred to the new repo.


Reverted back to original yes/no questions

This is for #12.

Thanks for helping #keepTheInternetGreat!


[phenotype querying weirdness

No results for: increased cortical endoplasmic reticulum remodeling (FYPO:0007273) [single allele genotypes]
but
https://www.pombase.org/reference/PMID:32023460

also
No results for: decreased histone H4-K12 acetylation during vegetative growth (FYPO:0005014) [single allele genotypes]
but
https://www.pombase.org/term/FYPO:0005014

I think it might be all phenotypes ;)

Sorry about that! I'm not having a good week. I'm working on a fix.

I've temporarily reverted to the previous day's release while I investigate.

Sorry about the bug.  It's fixed now.


change from pub(super) or pub(crate) when reusing fns in aggregate.rs in window function implementations

pub(super) or pub(crate) instead?
Originally posted by @jorgecarleitao in https://github.com/apache/arrow-datafusion/pull/334#discussion_r636597497

I'd like to have a try if no one has been doing it.


Angle op fix

Ticket
Link to Github Issue
Problem description
ttnn.angle op incorrect implementation.
What's changed

Fixed the op in ttnn/cpp/ttnn/operations/eltwise/complex_unary/device/complex_unary_op.cpp
Added nightly suite in tests/sweep_framework/sweeps/eltwise/unary_complex/angle/angle.py sweep
Minor modficiations inside unary_complex sweeps invalidate vector functions

Checklist
Unit test from the issue link now fails if the mentioned code lines are not removed/commented.

@amalbasaTT Are you planning to merge this PR?

@amalbasaTT Are you planning to merge this PR?

As soon as someone approves it.


insula subsegmentation

Hi, I'm new to medical imaging segmentation and this would be a great tool for my research!
What's the workflow like, if I only want to perform cortex parcellation, particularly insula, and I would like to further partition it into anterior and posterior insula?
Thanks!

I'm trying to run cortical parcellation, but it seems we do not have the correct models available.
(unable to open file: name = 'D:\project\SynthSeg\models\synthseg_parc_2.0.h5', errno = 2, error message = 'No such file or directory', flags = 0, o_flags = 0)


Upgrade to kubernetes 1.28

We need to upgrade from 1.25 to kubernetes 1.28:

[ ]  For AWS
[ ]  For Azure
[ ]  For GCP
[ ]  For minikube
[ ]  For minikube based actions/github workflows

Depends on https://github.com/OWASP/wrongsecrets/issues/974


feat: Added outputs sns_topic_name, sns_topic_id, sns_topic_owner

Description
This change will add outputs to the module to allow for greater integration with terraform modules and resources
Motivation and Context
The change covers common use cases for SNS topics:

Implementation on resources and modules
Get more details on running the Terrafom Plan / Apply command

Breaking Changes
No breaking changes!
How Has This Been Tested?
Here are my test scenarios:
Created a Topic SNS and sent the following values in outputs:

sns_topic_name

sns_topic_arn

sns_topic_id

sns_topic_owner

After executing the Terraform Apply command, the correct execution was verified.
The code used to run the test is located at this repository: simoferr98/infrastructure-terraform-example
My test environment is:

MacOS Monterey 12.0.1
Terraform v1.0.11
AWS Personal Account

Please fix the docs by running pre-commit run -a.

Hi @antonbabenko  corrected the documentation as required in the README.md

This PR is included in version 3.3.0 :tada:


Rya mongo shell [WIP] RYA-999

Description

What Changed?
Run the build with: mvn clean install -DskipTests -Drat.numUnapprovedLicenses=100
new libraries will need to be added to support list.
This is a different rya Shell for MongoDB.  Below are the supported commands.
connect-rya			disconnect-rya
sparql-query-rya
connect-mongo-rya	disconnect-mongo-rya
sparql-query-mongorya

Tests

Coverage?

Manual unit testing needs to be done.
Links
[WIP] RYA-999
RYA-368 was created for shell MongoDB
Checklist

[ ] Code Review
[ ] Squash Commits

People To Reivew
@pujav65
@DLotts

Can one of the admins verify this patch?


Links to storage SDK methods are outdated

Links to the storage sdk methods lead to a legacy SDK. They should be referring to the new, v12 SDK version.
The links are listed here: "The topic demonstrates UploadFromFileAsync, but UploadFromStreamAsync"
The links should point to the newest library https://docs.microsoft.com/en-us/dotnet/api/azure.storage.files.shares?view=azure-dotnet

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a5cfa38-0e6c-4346-dafc-84ea5c513fcf
Version Independent ID: c6787f0f-3e9a-6efb-0e6e-5ccb957d3f4a
Content: Upload files in ASP.NET Core
Content Source: aspnetcore/mvc/models/file-uploads.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @guardrex
Microsoft Alias: riande

Thanks @kaerm!


multiple samples

It appears that the pipeline is not being run on multiple samples, let's fix that.

the reason is that we take only the first |/data path: https://github.com/break-through-cancer/btc-spatial-pipelines/blob/75395c7bf3e5b37f7180f1442fd3019ca61a9e92/.cirro/process-input.json#L4


Fix postgreSQL containers failing due to file permissions errors

What type of PR is this:
/kind tests

/override windows-integration-test/Windows-test


Lale-Bot comments are no longer counted in task and supply list view

#332
Hopefully the wording is sensible. I chose to make it a scope to not clutter the view

Hi @nolanchan. How would this manifest in the app?

@dottorer , I'm not sure I understand the question. What do you mean by "manifest" ?

Sorry, just was wondering how it would look? Are we displaying something special here or just not counting the Lalebot comments in the little badge?

Hi @dottorer , everything is as it should be (Lale-bot comments are no longer counted in the comment count box). I updated the description to make it not cryptic-sounding. Sorry about the confusion

Reviewed the PR and looks good to me. @dottorer feel free to merge it.


feat: email verification

I was able to delete the email and then re add it using the code from kratos. Is that what is intended in this PR?


chore(ci-checks): fix the ddescribe-iit task for Jasmine 2

Without this fix, we are "vulnerable" to sneaky fit/fthey/fdescribes.

LGTM


[New API] : Thumbor API

Brief Description 🤓
An open-source image processing service that allows for smart cropping, resizing, and filters, tailored to the needs of web applications.
How will you develop it?🤩
React, JavaScript
Deployment
None
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @sreevidya-16🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24


Fix default double backslashes model name

Stripslashes to use single backslash

Not the right fix.
The right fix would be to remove the backlash after $this->getAppNamespace().
Since that returns with a backslash like App\.

@marktopper fixed


Missing Database Schema Documentation

There is no visible documentation or ERD of the database structure, which could make it difficult for new developers to understand data flows.

please note every table in the db is represented by a very detailed entity file.
any change/addition to the db is done by modifiying these files, and migrations are generated automatically with npm run scripts

please note every table in the db is represented by a very detailed entity file. any change/addition to the db is done by modifiying these files, and migrations are generated automatically with npm run scripts

While this is true, I'd claim that a higher-level database schema overview is still valuable. An ERD or similar schema documentation provides an accessible, visual snapshot of the relationships between tables, which is particularly helpful for:

Onboarding and Collaboration (New team members or external collaborators / licensees) - not  needing to go through each entity file in detail.

System Design Discussions: A visual schema is useful in planning and architectural discussions.

Database Management: with more people involved, a schema overview helps ensure everyone understands the relationships and data flow, reducing the chance of misinterpretation or errors during maintenance.


Output numbering

I noticed that when running mom6-panan starting from a previous restart stored in a different directory from where the output is going to be, the output name is output000, regardless of what number the restart was from. This is using restart: path line in config.yaml
So for example, continuing an existing experiment in ik11 using restart039, will save the output in my output directory as output000. I then have to rename it manually to output040.
Not super important, but good to know

Just a comment for future reference, this is sort of by design. The code block where this is checked is here:
https://github.com/payu-org/payu/blob/a83d60b09f8ff93432cde302d36904edc4b79f16/payu/experiment.py#L348-L352
and it checks that no prior restarts are found by checking the current run counter is zero. This means a
restart: /path/to/restart/directory

can stay in the config.yaml and not affect subsequent runs, which is a nice bit of run documentation.
If you want to continue an existing run then it doesn't work as nicely. Nor, potentially, if you want to fork a perturbation experiment at a point and have the numbering match that of the control.
The logic could probably be rearranged, but quite a lot depends implicitly on the current run counter, so it would need to be done quite carefully. It would probably need to be added here:
https://github.com/payu-org/payu/blob/a83d60b09f8ff93432cde302d36904edc4b79f16/payu/experiment.py#L180-L212

Note that #324  is related, because it fixes a logic error that could lead to buggy behaviour.


Lens no longer connects to cluster properly after upgrade

Describe the bug
None of my clusters connect and I can not see anything
To Reproduce
Steps to reproduce the behavior:

Start lens, view nothing

Expected behavior
When starting I would expect to see pods and namespaces and pretty much any resource. I did not make any changes to my kubecontext before or after the forced upgrade
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Lens Version: 3.6.0
OS: [e.g. OSX] 10.15.6
Installation method (e.g. snap or AppImage in Linux): homebrew on macOS

Logs:
When you run the application executable from the command line you will see some logging output. Please paste them here:
info: [IPC]: setup channel "cluster:activate"
info: [IPC]: setup channel "cluster:disconnect"
info: [IPC]: setup channel "cluster:install-feature"
info: [IPC]: setup channel "cluster:uninstall-feature"
info: [IPC]: setup channel "cluster:upgrade-feature"
info: 🚀 Starting Lens from "/Users/blair/Library/Application Support/Lens"
info: Checking for update
info: [STORE]: LOADED from /Users/blair/Library/Application Support/Lens/config.json
info: [STORE]: LOADED from /Users/blair/Library/Application Support/Lens/lens-cluster-store.json
info: [STORE]: LOADED from /Users/blair/Library/Application Support/Lens/lens-workspace-store.json
info: [CLUSTER-MANAGER]: init cluster {"id":"040a9a22-5642-47d2-9688-10b408275465","name":"development","initialized":false}
info: [CLUSTER]: "development" init success {"id":"040a9a22-5642-47d2-9688-10b408275465","context":"development","apiUrl":"https://loft.hqo.dev/kubernetes/cluster/development"}
info: LensProxy server has started at http://localhost:53467
info: Update for version 3.6.0 is not available (latest version: 3.6.0, downgrade is disallowed).
info: [KUBE-AUTH]: out-channel "kube-auth:040a9a22-5642-47d2-9688-10b408275465" {"data":"Authentication proxy started\n","meta":{"id":"040a9a22-5642-47d2-9688-10b408275465","name":"development","initialized":true}}
info: [CLUSTER]: activate {"id":"040a9a22-5642-47d2-9688-10b408275465","name":"development","initialized":true}
info: [CLUSTER]: bind events {"id":"040a9a22-5642-47d2-9688-10b408275465","name":"development","initialized":true}
info: [CLUSTER]: refresh {"id":"040a9a22-5642-47d2-9688-10b408275465","name":"development","initialized":true}
error: failed to request selfSubjectAccessReview: HttpError: HTTP request failed

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
 apiVersion: v1
clusters:
- cluster:
    server: https://loft.hqo.dev/kubernetes/cluster/development
  name: loft-development
contexts:
- context:
    cluster: loft-development
    user: loft-development
  name: development
current-context: development
kind: Config
preferences: {}
users:
- name: loft-development
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      args:
      - token
      - --silent
      - --config
      - /Users/blair/.loft/config.json
      command: /Users/blair/.devspace/plugins/NB2HI4DTHIXS6Z3JORUHKYROMNXW2L3MN5THILLTNAXWY33GOQWWIZLWONYGCY3FFVYGY5LHNFXA0000/binary
      env: null

Additional context
Add any other context about the problem here.

Same for me

Problem solved for me with upgrading to v3.6.2

Should be fixed in v3.6.2.


Could you elaborate on the runtimes of the operations, basically get, set, multi and has?

Hi, I'm curious to know the run-time of each of the operations, get, set, multi and has.
I wouldn't mind knowing the runtimes of the other functions. But mainly these.

Hi, not sure what you mean by run-time, whether it's complexity or, something else. You can check the code for that.

 :)

Correct, that's not available anywhere. Feel free to check the code for that. I'm closing this, questions are better done in public forums. Have a good one