python-bindings|prover_disk|tests: Add pickle support for DiskProver

This is needed for plots caching in chia-blockchain.
Based on #302

I think it's a bit weird to lock the mutex in the move constructor, just like in the destructor. Another thread better not have a reference to the object as it's about to be destructed. If it does, locking the murex won't help.
Some of the getters seems to copy the vectors a bit gratuitously as well.

My comment in the G1 pickle support applies here too. Can we rely on pickle being a stable format across python versions?
We need to ensure we don't accidentally break backwards compatibility.

Another thread better not have a reference to the object as it's about to be destructed.

Hmm better not yeah but how to prevent it? If we don't lock it in the move constructor we could end up moving the object while another thread has the mutex locked i.e. its still fetching a proof or so, no?

My comment in the G1 pickle support applies here too. Can we rely on pickle being a stable format across python versions?
We need to ensure we don't accidentally break backwards compatibility.

The soon following change in chia-blockchain will cache the following data structure:
@dataclass
class Cache:
    version: int
    plots: Dict[Path, PlotInfo]
    plot_filename_paths: Dict[str, Tuple[str, Set[str]]]
    failed_to_open_filenames: Dict[Path, int]
    no_key_filenames: Set[Path]

which contains the version field i guess that's good enough?

Another thread better not have a reference to the object as it's about to be destructed.

Hmm better not yeah but how to prevent it? If we don't lock it in the move constructor we could end up moving the object while another thread has the mutex locked i.e. its still fetching a proof or so (relies on the data we are about to move), no?

My point is that locking the mutex won't help in that case. We have UB either way. So, we could assert that the mutex isn't locked maybe, but fundamentally, I think we just have to assume the users of this class aren't doing shady stuff with it.

We need to ensure we don't accidentally break backwards compatibility.

which contains the version field i guess that's good enough?

If the pickle file format changes, you won't ever get to see the version number.
Using our Streamable format may be an alternative, but that would create a dependency on the chia-blockchain repo which would be a hassle.

My point is that locking the mutex won't help in that case. We have UB either way. So, we could assert that the mutex isn't locked maybe, but fundamentally, I think we just have to assume the users of this class aren't doing shady stuff with it.

I mean, technically there is still a possible case where its no UB if we lock the mutex like if we have two threads and we trigger stop for both, one of them has currently the mutex locked and the other wants to move the object to a shutdown thread or whatever idea one might have, right?  But if we don't lock the mutex this case would be an UB. Not that this is super likely but its there and a reason to just lock it unless i miss something.

If the pickle file format changes, you won't ever get to see the version number.

You can still always use older protocols if there will be a non-backwards compatible protocol bump at some point.
https://docs.python.org/3/library/pickle.html#module-pickle
....
The pickle serialization format is guaranteed to be backwards compatible across Python releases provided a compatible pickle protocol is chosen and pickling and unpickling code deals with Python 2 to Python 3 type differences if your data is crossing that unique breaking change language boundary.
....

Using our Streamable format may be an alternative, but that would create a dependency on the chia-blockchain repo which would be a hassle.

Thats what i started with... but not to add Streamable as dependency here but rather just to implement a __bytes__ and a from_bytes for DiskProver in the python bindings by adding serialization to the C++ part and have DiskProver serialized as Streamable in chia-blockchain then. But this also required to change a lot stuff in the Streamable implementation because it doesn't support Dict, Set and the dynamic custom types at this point. I got the custom types working kind of by prepending the size of the serialized data in the pybind implementation before returning in __bytes__ but for the Dict part i ended up in a blind end at some point where i wasn't able to de-serialize it because of some weird "isinstance can't be used for nested type annotations" thing. I even already spent quite some time implementing basic serialization for the C++ part here https://github.com/xdustinface/chiapos/commit/a84ad93c10323a94d7e9650600e42cea765da41c and for DiskProver itself here https://github.com/xdustinface/chiapos/commit/748c3df7a7de62486568e98cfb875e085865bbf6. Thats what i also wanted to use for the implementation of the pickle support initially but basically the moment i wanted to submit the PR for the serialization part i realized its simpler to just add another constructor for DiskProver to make it simpler and add less new code :smile:

I think the EnsureValid() patch should be reverted.
Generally, classes should avoid using 2-phase initialization. If a constructor fails to establish the class invariant, it should fail. That way, all instances of a class are known good, no half-initialized objects.
It seems the reason why you want the DiskProver to have such "invalid" or half-initialized state is because the de-serialization code (de-pickling) isn't controlled by you, and it doesn't support the concept of individual items in a list failing, without failing everything.
The modern alternative to 2-phase initialization is to use std::optional<DiskProver>. If all of that is too impractical, I think the impact of the compromise to use 2-phase initialization should at least be mitigated and isolated. The EnsureValid() patch exposes the possibly-uninitialized nature of this class to all of its users, that's why I think it should be reverted.
exposing is_valid() to allow filtering out objects that failed to load immediately after de-pickling seems like a reasonable compromise.

@arvidn I restructured the commit history a bit and put some stuff into separate commits. I just saw windows tests failing for some reason but i need to sleep now.. will check that when i wake up.

The modern alternative to 2-phase initialization is to use std::optional<DiskProver>. If all of that is too impractical, I think the impact of the compromise to use 2-phase initialization should at least be mitigated and isolated. The EnsureValid() patch exposes the possibly-uninitialized nature of this class to all of its users, that's why I think it should be reverted.

Unfortunately it seems like its not possible to use std::optional with pybind/pickle here. I tried a bit but couldn't get it working in reasonable time. If you have a solution feel free to provide a commit. Otherwise, see below.

I think the EnsureValid() patch should be reverted.

I refactored it, see b395860. Note that the alternative constructor still throws the same way like it did before but the new DiskProver::Validate is not longer enforced by all class methods, it just throws if it gets called + there is still the non-throwing DiskProver::IsValid.

It's not clear to me how or why one would use the Validate() or is_valid() functions. It would seem simpler to just attempt to look up a proof and have it fail. It's fine to defer the failure until we actually need to do the lookup, right?

I'm using it to drop invalid provers after cache loading, see https://github.com/Chia-Network/chia-blockchain/pull/8009/commits/3b0b971df8da225c13cf99be5b56ce03b82f437f#diff-1c950ad1eb2a79b51cb4f61cf39b8fe8d09d28ad963ce7dd24107053ff316d14R116

I'm using it to drop invalid provers after cache loading,

It would seem to me that doing that would defeat the purpose of caching these entries in the first place. If we're reading it back from the files unconditionally, to validate it, couldn't we just do that to begin with, and not also read the pickled cache?
Perhaps I'm missing something

is this PR abandoned now?

Yes!


python taking a really long time to load. 20+ seconds.

Extension Name: python
Extension Version: 2018.9.0
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.28.0

We have written the needed data into your clipboard. Please paste:
{
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 19889,
		"activateCallTime": 271,
		"activateResolvedTime": 71,
		"activationEvent": "onLanguage:python"
	}
}

@stolencatkarma Did you chec this issue?
https://github.com/Microsoft/vscode-python/issues/2827

Duplicate of #2827


I am getting OUT OF ENERGY Error

this is my code I have faced this error before and fixed it with changing isConstant to false but now I am getting the same error
async function createTSD(proofName, proofDescription, ipfsUrl) {
    try {
      const result = await tronWeb.transactionBuilder.triggerSmartContract(
        tsdFactoryAddress,
        "createTSD(string,string,string,string)",
        { _isConstant: false },
        [
          {
            type: "string",
            value: "EC",
          },
          {
            type: "string",
            value: proofName,
          },
          {
            type: "string",
            value: proofDescription,
          },
          {
            type: "string",
            value: ipfsUrl,
          },
        ]
      );
      console.log(result);
      const signedTransaction = await sign(result);
      const transaction = await sendRawTransaction(signedTransaction);
      console.log(transaction);
    } catch (error) {
      console.log(error);
    }

    setresult(result);
  }

@Emirhan-Cavusoglu-sftw For out of energy issue, please set a larger feelimit, and ensure the account has enough TRX or energy. Energy can be obtained by staking TRX.


Add example of using to readme

Is your feature request related to a problem? Please describe.
Add example of using
Describe the solution you'd like
async () => {}

Describe alternatives you've considered
No response

@FreePhoenix888 what exactly do you mean? What should be added to README.md?

@FreePhoenix888 what exactly do you mean? What should be added to README.md?
Minimal handler

And handler with all args descructured
To easily understand how handler looks like and what is passed there


Keyword research and content plan

Keywords & content plan
A quick look at the keywords bringing people to our website reveals a few recurring topics:
Feature flags
Keywords:

feature flag tools
feature flag example
what is feature flags
why use feature flags
posthog feature flags
feature flags deployment
feature flag best practice
open source feature flags
how do feature flags work
feature flags development
feature flag implementation

Feature flags received the most number of queries to the website by far. We can do a pillar post on how feature flags work in PostHog.
Heatmaps
Keywords:

heatmaps b2b
posthog heatmap
open source heatmap software

What exactly is a heatmap and how does it help you understand user behavior in your product? This blog post would address that.
Funnels
Keywords:

funnel analytics
how to use funnel
user funnel analysis
how to make a funnel
product funnel analysis
how to do funnel analysis
conversion funnel dropout
marketing funnel analytics
what is a funnel in analytics

Funnels are another popular search query leading people to our website, so we should focus on creating multiple pieces of content around how funnels work (esp. in PostHog) and how they can be better used to understand app user behavior.
Session recording
Keywords:

user session recording
posthog session recording
session replay self-hosted
website session recording open source

This is an opportunity to explain the session recording and replay feature in PostHog and show how it helps devs better understand their products.
Databases
Keywords:

postgres scaling
posthog clickhouse
postgresql to clickhouse

Your database’s performance determines how fast your app loads, among other things. We can do a post on our decision to move to Clickhouse and drop Postgres, plus other posts on database performance/maintenance in general.
Comparisons and alternatives
Keywords:

PostHog alternative
posthog vs mixpanel
posthog vs amplitude
amplitude vs heap vs mixpanel
mixpanel open source alternative

Our users will be comparing us against the competition, so we might as well have a definitive comparison post that positions us in the best light and drives that valuable traffic to our sign-up page.
Tool, plugins, frameworks,. and platforms
Keywords:

posthog react
posthog flutter
posthog docker
posthog plugins
posthog react native

What are the underlying frameworks and platforms that PostHog is built on/with? This series could explore these technologies and explain why//how they contribute to making PostHog such a powerful platform.
Metrics
Keywords:

b2b product metrics
product usage metrics

PMs and devs always want to know what type of metric is key to track. This blog will outline a few  metrics that high-performing business use to build better businesses.
Open source web and app (product) analytics
Keywords:

self hosted analytics
product analytics system
product analytics platform
open source web analytics
open source [app] analytics
website analytics open source
open source analytics software
web analytics tools open source
analytics database open source
product usage analytics software
web analytics software open source
user behavior analytics open source
data analytics platform open source
software for product usage analytics
marketing and analytics platform open source

People are searching for open source data analytics platforms, and a blog post on this topic would be a great way to draw people in.
Revenue tracking
Keywords:

revenue tracking
track revenue

Would PostHog be useful for tracking revenue within an app? If possible, this functionality might be highly useful for e-commerce brands with online stores.
Event tracking
Keywords:

event tracking guide
custom event tracking

How do you track different events within your app? We’ve got the answers - using PostHog, of course…
Cohorts, retention, and segmentation
Keywords:

retention cohort
cohort retention
retention metrics
retention tracking
cohort segmentation
cohort analysis tutorial
how to measure app retention

Retention is a huge aspect of product development and growth, and we can touch on how PostHog helps companies track their user retention metrics over time.
Monetizing open source
Keywords:

how to make money with open source
open source software software as a service

We already have an article out on this, but we can repurpose that info into an infographic, a narration, etc.
Developer marketing strategy
We’d be getting a bit meta here, but a post like this would be extremely useful for exposing current and future devtool founders to PostHog early in their journey.
Product-led growth
Keywords:

product led companies examples
product led growth

We can do an explainer on what PLG is, what metrics to track, and what mistakes to avoid.

This is super helpful! Just requested access to the sheet, but in the meantime - in general, how many times do these terms actually come up? It would be helpful to get a sense of scale, as the terms without this context might lead us down the wrong path.

Thanks Mo, this is a great list.
Do you have an idea of which keywords you want to prioritise and what the timeline/approach for delivering these ideas would be? I've requested access to the sheet but I wonder whether we go deep on a particular area (such as funnels) with multiple posts, or whether we hit each topic once as fast as we can and reassess.
Tonally too, I wonder if we want to consider the positioning of the blog. Up until now the blog has mostly been content about PostHog's journey and we'd dilute that considerably if we drop in (potentially multiple) posts on these 15 topics. That may not be a problem, but I think worth considering if some of the content outlined should exist off-blog or should be de-listed from the main feed in order to preserve the current content-feel.
Competitor comparison articles, for example, may exist better either as a separate landing page or as something which isn't listed in the main feed.
On that topic I'd also suggest that in addition to doing straight 'PostHog vs. Mixpanel' comparisons we also do some aggregator articles ('The 31 Best Product Analytics Platforms', 'The 11 Best Heatmap Tools', etc). They tend to perform better at an SEO level as a result of the extra keywords and links, in my experience.
This is a long list, so if helpful then I'm happy to work on a couple of these articles or reach out to my freelance network to help us scale. Let me know.

@piemets:
Just opened access to the Sheet for anyone with a PH email addy - please try accessing it again. I've also sorted the terms by impressions to give you an idea of which keywords are netting us the most views.
@joethreepwood:
Re: the list, I'm thinking:

Pillar articles on each topic, max 2 posts per topic (to not dilute link juice).
We already have a mix of articles at the moment (storytelling mixed w/ Arrays) so adding technical content shouldn't be too much of a disruption - but what we can do is divide the blog into different sections like monday.com does. @corywatilo is this something we can do?
Comparison articles should exist as individual landing pages. We can then play around with different page structures and layouts as needed.
Round-up articles are a great idea - will need your and/or engineering's input here as you/they have got more experience with competing products (cc: @jamesefhawkins, @timgl, @paolodamico).
Would definitely love your help with these, especially the comparison articles as your positioning chops will come in handy there.


[Question] How to run/debug individual scene?

Readme page shows following text.

Context menu on a scene file allows running game directly to that scene.

However, when I right click scene(.tscn) file, there are no any run/debug action.
How can I fix it?

Make sure that scenes are added in the csproj.
<ItemGroup>
  <None Include="**/*.tscn" />
</ItemGroup>

It works!!! Thank you!!!


Add support for LS_COLORS through vivid

Another nice to have functionality for this tool might be
generating LS_COLORS colors compatible with theme. I personally use vivid for this. Generating vivid color theme file compatible with selected theme would be lovely. It is annoying when ls_colors settings and your terminal colors do not match.

I'm not familiar with LS_COLORS or details of terminal colors, but it seems that the theme files of vivid have arbitrary color names in colors. So, I'm not sure how to map alacritty colors to the colors in LS_COLORS.
One possible way to match colors of alacritty and LS_COLORS would be to use the 16 colors instead of exact color codes in LS_COLORS. Then, alacritty will render the 16 colors with its color scheme.

Actually as far as  i know there is not a one to one mapping between terminal colors and LS_COLORS. May be we can look at a well known terminal color theme and vivid configuration and find a mapping.
Monokai is a good example of this.

I checked vivid themes and read about LS_COLORS. If we want to create LS_COLORS that match with Alacritty color theme, we need two information.

pick colors for file types (for example, make executable red)
use the exact colors from Alacritty color theme

can be automatically achieved if LS_COLORS uses 3/4 bit colors. We can't automatically generate 1) for arbitrary color schemes. You can use an OS default LS_COLORS that uses 3/4-bit colors or create one with more file types.

I'm closing this issue because I think it's out of the scope of converting Alacrtty color schemes.


[Recipes] Add star ratings on recipe cards

Add star ratings card to recipe page as on original site:

As agreed in client call today, star rating is out of scope.


soc: npcx: add support for npcx9m7fb

Add new SoC npcx9m7fb support for npcx9 series.

this should probably wait for the hwm2 merge

Needs to be migrated to hwmv2

@fabiobaltieri @nordicjm Do you mean that this PR should waiting for the collab-hwm merged to the branch main? If so, when do you expect it will be ready?

You can re-target to the collab-hwm branch and update it to hwmv2 if wanted (though note existing nxp devices are not ported yet so would likely cause problems). Aiming for this friday to have it ready to be merged

Needs to be migrated to hwmv2

@fabiobaltieri @nordicjm Do you mean that this PR should waiting for the collab-hwm merged to the branch main? If so, when do you expect it will be ready?

You can re-target to the collab-hwm branch and update it to hwmv2 if wanted (though note existing nxp devices are not ported yet so would likely cause problems). Aiming for this friday to have it ready to be merged

Thanks for the comment. I think I can wait for the hwmv2 landing to main based on the estimated timeframe .

This PR is changed to follow HWMv2 and rebase to ToT.

Friendly ping.


Allow syncing full article, not just highlights

I have a use-case where having full article content synced to my vault would be fantastically useful. Is this something the project would consider adding? I'd be happy to take a swing at implementing it.

Hey @samwho, you can use content variable in your template to import the article content.
For instance:
## Content
{{content}}

Oh my gosh, I completely missed that. Thank you so much.

Hmm, the content appears to have escaping.
I have synced the article https://www.bowtie.works/blog/baking-images-with-nix-for-robust-private-networks-at-bowtie and in the article we have this code block:

Which appears as this in Obsidian:

A-ha! Using {{&content}} removes the escaping. Hopefully this helps others who stumble upon this. :)


Image acquisition from IRC900 through GigE with Harvesters

Having a problem extracting an image stream from an IRC900 camera through the GigE interface. I'm using python version 3.9.12
The code segment below describes how I have endeavored to extract the image stream:
from harvesters.core import Harvester
from genicam.genapi import NodeMap
node_map = NodeMap( )
xml_filename = r"path\IRCameras_Stream_rev0.xml"
node_map.load_xml_from_file(xml_filename)
h = Harvester( )
cti_filename = r"path\irctransport.cti"
h.add_file(cti_filename)
No error messages result from this code and printing h.files indicates correct path and filename of .cti file loaded
However, when I execute the h.update( ) command I get messages as below:
GenTL producer does not implement IFGetParentTL
GenTL producer does not implement DSGetBufferCheck
GenTL producer does not implement DevGetParentIF
etc ... (6 listed in total)
Then executing the command
print(h.device_info_list)
prints [ ]
Any suggestions as to where I might be going wrong would be appreciated.

Can you connect to the camera and start acquisition without loading the XML file, or does that also give errors? If so, there might be something wrong with the GenTL producer, if not there might be a mismatch between the XML file and the GenTL producer.
And you can add code blocks like this:
```
print("Code block")
```
Which will result in:
print("Code block")


bugfix: 后台下载文件接口鉴权失败 (closed #1076)

Codecov Report

:exclamation: No coverage uploaded for pull request base (V2.2.23-rc@2563f14). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             V2.2.23-rc    #1077   +/-   ##
=============================================
  Coverage              ?   73.21%
=============================================
  Files                 ?      322
  Lines                 ?    22976
  Branches              ?        0
=============================================
  Hits                  ?    16821
  Misses                ?     6155
  Partials              ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

是这个问题引发的 Windows 执行 curl.exe 报错？

是这个问题引发的 Windows 执行 curl.exe 报错？

目前看起来是的，登录鉴权导致了接口的302，文件写入出现了问题


Allow timeouts to be configured in config

This adds a singleton timeout package that will allow services and user
to configure timeouts in the daemon.  When a service wants to use a
timeout, it should declare a const and register it's default value
inside an init() function for that package.  When the default config
is generated, we can use the timeout package to provide the available
timeout keys so that a user knows that they can configure.
These show up in the config as follows:
[timeouts]
  "io.containerd.timeout.shim.cleanup" = "5s"
  "io.containerd.timeout.shim.load" = "5s"
  "io.containerd.timeout.shim.shutdown" = "300ms"
  "io.containerd.timeout.task.state" = "100ms"

Timeouts in the config are specified as a string and parsed as a duration.
Timeouts are very hard to get right and giving this power to the user to
configure things is a huge improvement.  Machines can be faster and
slower and depending on the CPU or load of the machine, a timeout may
need to be adjusted.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #3459 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
- Coverage   44.22%   44.21%   -0.02%
==========================================
  Files         124      124
  Lines       13724    13727       +3
==========================================
- Hits         6070     6069       -1
- Misses       6723     6727       +4
  Partials      931      931

Flag
Coverage Δ

#linux
48% <0%> (-0.01%)
:arrow_down:

#windows
39.87% <0%> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

services/server/server.go
1.22% <0%> (-0.02%)
:arrow_down:

runtime/v2/shim/shim_windows.go
42.85% <0%> (-0.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab78270...dbdd262. Read the comment docs.

@kevpar - FYI this is similar to what we have been seeing.

I agree with @dmcgowan with naming GetContext -> WithContext -- otherwise LGTM

Updated

Updated to specify timeouts as a time.duration ( string in the config)

@jterry75 see above; those commits are from 2019 😅 (not sure why they showed up in timelines / notifications)

LOL!!!


improve ansible tagging

Improves and adds some additional tags.
Fixes use of greenlight and monitoring tags, by adding the tags to the depended docker tasks.
Also fixes #181.

Hi @BrutalBirdie, I resolved the merge conflicts. What do you think?


Updates for showing version on UI.

Updates for showing version on UI.

Coverage decreased (-0.02%) to 40.864% when pulling edc10fc96ed7e010c5cfa60fd2e8d8f7a8eb5cc8 on wknet123:dev into 42d0f968d3510d495a740c1411cbdd6244744d2a on vmware:dev.


[integration tests]: restart Alice after on-chain settle

To ensure lnd is able to pick up an on-chain preimage properly after a
restart, we suspend Alice and check that the payment is listed correctly
as succeeded after a restart.
Builds on #3190

PTAL @wpaulino

Do we still test that the preimage is properly recovered w/o a restart?

Still relevant?

Still relevant?

Yes, will update this the coming week.


Add HIGHLIGHT function to SQL

Description
This PR adds a highlight function to SQL plugin.
Sample usage
SELECT Tags, highlight(Tags) from Index WHERE match(Tags, 'structure')

would return

Tags
highlight(Tags)

data structure array
data structure array

Issues Resolved
#636
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #677 (c365d8a) into main (8523ad8) will decrease coverage by 31.92%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #677       +/-   ##
=============================================
- Coverage     94.68%   62.76%   -31.93%
=============================================
  Files           281       10      -271
  Lines          7589      658     -6931
  Branches        558      119      -439
=============================================
- Hits           7186      413     -6773
+ Misses          349      192      -157
+ Partials         54       53        -1

Flag
Coverage Δ

query-workbench
62.76% <ø> (ø)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ain/java/org/opensearch/sql/analysis/Analyzer.java

...rg/opensearch/sql/analysis/ExpressionAnalyzer.java

...ensearch/sql/expression/ExpressionNodeVisitor.java

...h/sql/expression/function/BuiltinFunctionName.java

...h/sql/expression/function/OpenSearchFunctions.java

...org/opensearch/sql/planner/DefaultImplementor.java

...opensearch/sql/planner/logical/LogicalPlanDSL.java

...ch/sql/planner/logical/LogicalPlanNodeVisitor.java

...ch/planner/logical/OpenSearchLogicalIndexScan.java

...h/planner/logical/rule/MergeLimitAndIndexScan.java

... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8523ad8...c365d8a. Read the comment docs.

Closing this draft PR since the proper one is imminent.


Pull request, but not a pull request

Howdy, Mika
I've been using your lazyload plugin for a long time, and it has worked great for me.  I wanted to start by thanking you for sharing it.  So... Thanks!
I ended up having to make some modifications to your plugin for a project I was working on, and I figured I'd share them in case you'd like to incorporate any of them.  I did a pretty major overhaul of the code, so I'm not sure I'd be able to separate all the feaures and do individual manageable PRs for them.  I did try to keep my commits small and well-documented, though, so I'll just give a rundown of the major changes here to supplement what's in my fork.
https://github.com/saucecontrol/jquery_lazyload/commits/master
The biggest change I made was a rewrite of the core measurement logic, in the first commit on that fork.  I found that on pages with a large number of images and a high failure_limit set (a requirement on my project), the processing of the scroll event handler slowed too much to be usable.
I created a jsperf (actually a revision of one of yours) showing a basic comparison between the new and original logic.  For the comparison, I stripped the 'box' class out of my revised plugin and used it to create mirrored helper methods and jQuery pseudo selectors so they could be compared in the same page.  Just using the updated logic with the :in-viewport pseudo resulted in ~10x performance gain in the browsers I tested.
I also revised the update() function in the plugin to measure the container only once per call rather than once per child element.  This can yield up to another 2x performance gain, depending on the container (window measurement is less overhead, so less gain for that).
In addition, I addressed some of the event and DOM leaks to make the plugin behave better when using it with AJAX-loaded content.
I did a couple of profiles in the Chrome developer tools illustrating some of the problems and their fixes.  For these profiles, I used the default plugin settings with the exception of failure_limit, which was set to 400.    I repeated the process with both v1.9.3 and with my modified copy.  In both cases, all the images were already in the local cache, so all processing is from the plugin and the painting from the scroll.
Memory/Objects Before:

Memory/Objects After:

Frames Before:

Frames After:

Events Before:

Events After:

About the major changes
I updated the measurement logic to use getBoundingClientRect (gbcr) where possible.  gbcr always returns coordinates relative to the window viewport, regardless of document hierarchy or position: styles.  This allows any two sets of coordinates to be compared directly, since they always have the same origin.  When comparing to the window, you simply compare with a rectangle starting at 0,0 and going to window width,height.  This is the simplest possible logic and because gbcr returns both position and size in the same call, it is incredibly fast.
For clients not supporting gbcr, I fall back to the jQuery logic used in the original version, with only two differences.  1) I use outerWidth() and outerHeight() instead of width() and height() for consistency with the gbcr measurements, which include padding and borders.  2) I force anything with display:hidden or that is detached from the DOM to return an empty rectangle.  Again, this is for consistency with gbcr.  It also addresses most of what the original skip_invisible logic does. More on that...
Elements that have display:hidden or that have been detached from the DOM have neither position nor size, so their relationship to anything else is undefined.
getBoundingClientRect() reports this correctly by returning an empty rectangle (0,0,0,0) in either of these cases.  jQuery's offset() method will return an origin of 0,0 for either case, but if an element is only display:hidden, the width() and height() methods may return non-0 values depending on how they are styled.
The :visible check in the old logic handles either of those situations correctly but will also lump in elements that have no size, even if they are part of the layout and have position.  This is the source of most of the complaints related to images not loading in webkit browsers if the size isn't set explicitly.  In my testing, even when an image is in the local cache, webkit will report its size as 0x0 at the time of document.ready.  It may then have a size as little as 1ms later, once it has been retrieved from the cache.  My updated logic allows an image with no size but with a position to be considered for triggering, which should eliminate this problem.  The only downside to that logic is that if the page layout consists of nothing but images with height and width of 0, they may all fit in the viewport initially and may all trigger.  In reality, that's pretty unlikely, so I think it's a good compromise... showing more rather than less.
Anyway, if there are any questions I can answer or anything I can do to make my changes easier to incorporate, let me know.  And thanks again for sharing and maintaining this plugin.

I saw your code, feel your idea is very good, but the code has a few obvious mistakes, don't know whether you test your code?
options.threshold === undefined

this.empty always equal to the false

Should be modified to:

Quite right.  Thanks for pointing those out.  I always use a threshold when I use this plugin, so the value is always present in both options and settings for me.  I've updated my fork with your suggested changes.


Atomic recreation of views

Describe the bug
When views are recreated, it is not atomic. The run might fail after the existing view has been renamed to backup, but before the new (intermediate) has been renamed to the target.
https://github.com/ClickHouse/dbt-clickhouse/blob/main/dbt/include/clickhouse/macros/materializations/view.sql#L42
Steps to reproduce

dbt run -m some_view_that_already_exists
If it fails between line 47 and 48 in the code linked above, your don't have your view anymore.

Expected behaviour
I though it would be possible with atomic view re-creation. It is possible to run CREATE OR REPLACE VIEW, or is that not an atomic operation?

Actually I'm wrong, there is REPLACE VIEW (I'm not sure it's atomic), I was thinking of tables and cluster operations.  We can look using that instead.

It turns out the REPLACE VIEW is not, in fact, atomic, so changing the DDL won't guarantee a fix for your particular issue.
Regardless, it's definitely cleaner and worth doing as time permits.  This could be fixed eventually in ClickHouse server.
In general however, I would not want to construct workflows that depend on atomic operations in ClickHouse via dbt.  True atomic operations especially across a ClickHouse cluster are extremely difficult to guarantee, and dbt itself isn't going to be aware of various temporary tables and other mechanisms across a cluster either.


Translate tasks/run-application/run-stateless-application-deployment/ in Japanese

This is a Feature Request

What would you like to be added

Translate tasks/run-application/run-stateless-application-deployment/ in Japanese
Why is this needed
This document is not translated in Japanese.
Comments

Copy a file from en contents to content/ja/docs/tasks/run-application/run-stateless-application-deployment.md and translate it into Japanese.
/language ja

/close


⚠ Bofrost.be has degraded performance

In dc40bbc, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1334 ms

Resolved: Bofrost.be performance has improved in fee16a5 after 13 minutes.


Implement auto-labeller

labelOpenedIssue is partially implemented with poorly-written JavaScript and pseudo-code comments. It needs a good solution to the brains of the auto-labelling algorithm.
The Problem
Accurately pick and apply 1 or 2 labels for newly-opened PRs and issues.
Input

Available labels for the repository (https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels, for example)
Comments, assignees, milestones, title/body of initial post

Missing Information
As far as I can tell, there is no way to get these from the GitHub REST API:

Commits/commit messages of the PR
Files that have changed with the PR

Patrick initially wanted a machine-learning algorithm to pick labels. This seems impossible without knowing the files that have changed (not to mention my inexperience with machine learning).
Possible Solution
The framework I currently have in labelOpenedIssue is roughly:

Scan the comments of a newly-opened pull request or issue ->
Find linked issues and pull requests ->
Scan the linked issues and pull requests for their labels ->
Collect them and order by frequency ->
Choose a label from this smaller input space

Still not sure how...

From https://github.com/AnalyticalGraphicsInc/cesium/issues/5489

To reduce manual paperwork, it would be cool to apply some simple "machine learning" to assign labels to GitHub issues and pull requests just like GitHub suggests reviewers for pull requests.
Pull requests should be easy to get mostly right based on the directory/files with the major changes.
Issues will be harder but could rely on keywords or even identifiers in example code.
For both pull requests and issues, we could have a friendly bot comment saying "I labeled this x and y. Please update if this is incorrect." It could even say different funny things based on its confidence level.
If nothing else is already out there, this could be a standalone project/repo that is configurable and perhaps useful to other projects, both our's and other's.

Also see https://github.com/marketplace/issue-label-bot


Unable to parse certain Namespaces

The following snippet is found in one of the IDL files in the Mozilla Gecko repo
namespace console {
  *irrelevant content*
  void profileEnd(any... data);

  [ChromeOnly]
  const boolean IS_NATIVE_CONSOLE = true;
}

This bug is unrelated to the workaround that was previously implemented.
Cause: The parser is not consuming spaces between NamespaceMember
Solution: Changing grammar to account for that. Will be corrected in a PR that is coming later today
Found while attempting to solve #39

Resolved by adding an additional semantic rule specific to WebKit. Note that many IDL Interface definitions have no semicolon, and the semantic rule for that had to be relaxed as well...

This is now fixed, yes?

Yes, it has been fixed. Closing now


it seems this isn't working on iOS 18

The items in the background are supposed to be blurred out.. works perfect on Android and iOS versions below 18...

I found this,
https://discussions.apple.com/thread/255764118?sortBy=rank

did u find another solution or an alternative @kelvinOfoli ?

@vstacked
I resulted to using "@react-native-community/blur" just for iOS 18 and above
  if (majorVersionIOS >= 18 && isIOS) {
    return <RNBlurView style={styles.container} blurType={blurType} />;
  }

Yes, in the end I also used that, but with that library I encountered another problem, which was a white screen. According to this https://github.com/software-mansion/react-native-screens/issues/1882#issuecomment-2435173230, need to set animation to none. Did you @kelvinOfoli experience something similar?

I think I remember experiencing something like this only for android..
from what I remember giving the container of the blueView (@react-native-community/blur)  a
overflow: "hidden"
fixed the issue.

I think I remember experiencing something like this only for android.. from what I remember giving the container of the blueView (@react-native-community/blur) a overflow: "hidden" fixed the issue.

Oh I see, okay I'll try it later, thank you


fix: PointCloudView need to sync data after drag & move

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


Wrong icon name

close_cricle_outlined should be close_circle_outlined here

Thank you for bringing this to our attention!
This looks to be a typo we need to fix in our assets in Figma, so it affects all our instances of icons hosting.

Thank you for bringing this to our attention!
This looks to be a typo we need to fix in our assets in Figma, so it affects all our instances of icons hosting.

@equinor/eds-ux Will you have a look at this in Figma?

@equinor/eds-ux Will you have a look at this in Figma?

Name is now updated

Name is now updated


after ROCm 1.7.60 kernel module gets SIGKILL-ed

Any GPU tool or application is started it gets immediately killed. Kernel message below.
[ 3063.518775] BUG: unable to handle kernel paging request at ffffaad345941000
[ 3063.520296] IP: memset_erms+0x9/0x10
[ 3063.521807] PGD 4aec9b067
[ 3063.521808] PUD 4aec9c067
[ 3063.523312] PMD 4a1889067
[ 3063.524817] PTE 0
[ 3063.526319]
[ 3063.529273] Oops: 0002 [#5] SMP
[ 3063.530683] Modules linked in: xt_multiport iptable_filter ip_tables x_tables nfsv3 nfs_acl nfs lockd grace fscache binfmt_misc nls_iso8859_1 intel_rapl edac_core x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm snd_hda_codec_hdmi irqbypass crct10dif_pclmul snd_hda_intel crc32_pclmul snd_hda_codec ghash_clmulni_intel snd_hda_core pcbc snd_hwdep snd_pcm aesni_intel snd_timer snd 8021q soundcore garp aes_x86_64 mrp crypto_simd mei_me stp glue_helper llc input_leds cryptd mei lpc_ich shpchp mac_hid sunrpc lp parport autofs4 hid_generic usbhid hid amdkfd amd_iommu_v2 amdgpu mxm_wmi i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect e1000e sysimgblt fb_sys_fops ahci drm ptp libahci pps_core wmi
[ 3063.539426] CPU: 12 PID: 2814 Comm: rocminfo Tainted: G      D         4.11.0-kfd-compute-rocm-rel-1.6-180 #1
[ 3063.540901] Hardware name: MSI MS-7885/X99S SLI PLUS (MS-7885), BIOS 1.D0 07/15/2016
[ 3063.542387] task: ffff9950e8ba2a00 task.stack: ffffaad345918000
[ 3063.543884] RIP: 0010:memset_erms+0x9/0x10
[ 3063.545365] RSP: 0018:ffffaad34591bd00 EFLAGS: 00010286
[ 3063.546849] RAX: ffff9950e85568ff RBX:<PHONE_NUMBER>000008 RCX:<PHONE_NUMBER>001000
[ 3063.548352] RDX:<PHONE_NUMBER>009000 RSI:<PHONE_NUMBER>0000ff RDI: ffffaad345941000
[ 3063.549845] RBP: ffffaad34591bd48 R08: ffff9950ef51e440 R09: ffffaad345939000
[ 3063.551347] R10: ffff9950e8556800 R11:<PHONE_NUMBER>000901 R12: ffff9950e2c2bd60
[ 3063.552839] R13: ffff9950e440dd80 R14: ffffaad34591bdf8 R15: ffff9950e2c2bc00
[ 3063.554316] FS:  00007fd2c03b3780(0000) GS:ffff9950ef500000(0000) knlGS:0000000000000000
[ 3063.555801] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[ 3063.557273] CR2: ffffaad345941000 CR3: 00000004a91b2000 CR4:<PHONE_NUMBER>1406e0
[ 3063.558766] Call Trace:
[ 3063.560262]  ? kfd_event_create+0x36c/0x550 [amdkfd]
[ 3063.561767]  kfd_ioctl_create_event+0x8a/0x160 [amdkfd]
[ 3063.563272]  kfd_ioctl+0x241/0x3f0 [amdkfd]
[ 3063.564764]  ? kfd_ioctl_destroy_event+0x20/0x20 [amdkfd]
[ 3063.566271]  ? common_mmap+0x48/0x50
[ 3063.567767]  ? apparmor_mmap_file+0x18/0x20
[ 3063.569274]  do_vfs_ioctl+0x92/0x5a0
[ 3063.570772]  SyS_ioctl+0x79/0x90
[ 3063.572264]  entry_SYSCALL_64_fastpath+0x1e/0xad
[ 3063.573747] RIP: 0033:0x7fd2bf8ccf07
[ 3063.575212] RSP: 002b:00007fffe1c93fe8 EFLAGS: 00000246 ORIG_RAX:<PHONE_NUMBER>000010
[ 3063.576714] RAX: ffffffffffffffda RBX:<PHONE_NUMBER>a81530 RCX: 00007fd2bf8ccf07
[ 3063.578228] RDX: 00007fffe1c94040 RSI: 00000000c0204b08 RDI:<PHONE_NUMBER>000003
[ 3063.579744] RBP:<PHONE_NUMBER>000000 R08:<PHONE_NUMBER>000000 R09: 70fb000100003000
[ 3063.581260] R10:<PHONE_NUMBER>00046c R11:<PHONE_NUMBER>000246 R12:<PHONE_NUMBER>000000
[ 3063.582732] R13:<PHONE_NUMBER>a878c0 R14:<PHONE_NUMBER>000002 R15: 00007fffe1c94040
[ 3063.584160] Code: 48 c1 e9 03 40 0f b6 f6 48 b8 01 01 01 01 01 01 01 01 48 0f af c6 f3 48 ab 89 d1 f3 aa 4c 89 c8 c3 90 49 89 f9 40 88 f0 48 89 d1 <f3> aa 4c 89 c8 c3 90 49 89 fa 40 0f b6 ce 48 b8 01 01 01 01 01
[ 3063.587152] RIP: memset_erms+0x9/0x10 RSP: ffffaad34591bd00
[ 3063.588645] CR2: ffffaad345941000
[ 3063.590114] ---[ end trace 87f56add3e2b9acb ]---

Which hardware?
Greg

Also did you do this
With move to upstreaming the KFD driver and the support of DKMS, for all Console aka headless user, you will need to add all your users to the ‘video” group by setting the Unix permissions
sudo usermod -a -G video <username>

Which hardware?
X99 + i7 5960X CPU.

The video group does not help now, I assume that will be needed in the future?

With move to upstreaming the KFD driver and the support of DKMS,
From which Linux release has upstreaming started (wasn't it 4.15?); mine is still only 4.11.

For ROCm 1.7 you have to use this command it not future thing,   sudo usermod -a -G video
For this release you do not need to use  4.11 any longer just the standard Ubuntu  Linux kernel that came with Ubuntu 16.04.3 LTS    This new release use DKMS, not replacing the Linux kernel like in the past.  Just like how AMDGPUpro installs

Can you put a clean install of Ubuntu on the system
sudo apt update
sudo apt dist-upgrade
sudo reboot
Then follow the instructions.   we run with same CPU on ASUS x99 system

It looks like it issue with the Hawaii hardware and the driver, can you try it with just the Vega10 cards

@gstoner this thread has derailed quite a bit, but I'd really like to know whether I should expect that my X99 machine will be usable with the next patch release. Right now I can neither use it (if I use NFS or even are logged in over ssh, the machine crashes) nor downgrade to ROCm 1.6.

We run ASUS x99 machine with FIJI and Vega10 now with Haswell based I7.  It is the X99-E WS,  So we know it not Intel Extreme Edition issue nor x99 Chipset issue.   We need to retest with your particular motherboard when we get 1.7.1 out.

Thanks for the feedback. Is there anything more I can do to facilitate the testing? Nightly builds would be useful for that.

@VincentSC  @gstoner Just an update from my side.
I had to disable Secure Boot while installing a fresh Ubuntu to get rocm 1.7 working.Here's what I did 👍  Mine is an Asus PC and doing a F2 while booting led me to the Boot Menu.
Where I selected 'Advanced Options' within which I selected "Boot".
And then , I found the Secure Boot to be enabled.
So I did a "Clear all Saved Keys" which disabled the Secure Boot.
Then I did a fresh Ubuntu 16.04.3 install which contained :
linux-image-4.10.0-28-generic &
linux-image-4.13.0-32-generic
I did a rocm 1.7 installation as described here : Rocm 1.7 install
Rebooted the system and everything works fine now.

Maybe a section "current limitations" can be added, where "no/limited support for secure boot" can be listed.

Just installed ROCm 1.8 and my dmesg is still full of " e1000e: eth0 NIC Link is Down" followed by process hung messages when my process tries to write to NFS.
This is getting problematic, we've spent ~5 months hoping for a fix with temporary dev machines and time-consuming debugging and workarounds. Can you please advise me whether there is a solution in the pipeline or we should just forget about this platform/machine?

Also, did you look on Intel site about the Ethernet controller I am seeing an issue with MSI-X in the readme note https://downloadcenter.intel.com/download/15817  There is a newer driver at Intel site.

I've now tried the latest e1000e drivers:
$ modinfo -F version e1000e
<IP_ADDRESS>-NAPI

but as soon as I plugged the card and started a run and some network activity concurrently the NIC link went down. As I was in the server room with the display connected to the Vega GPU I noticed that the screen started to flicker and went blank. Found these in the kern.log:
May 31 19:17:40 dev-haswell-gpu01 kernel: [  977.050305] nfs: server fs.tcblab not responding, still trying
May 31 19:17:55 dev-haswell-gpu01 kernel: [  991.744164] [drm] SADs count is: -2, don't need to read it
May 31 19:18:04 dev-haswell-gpu01 kernel: [ 1001.044417] [drm] SADs count is: -2, don't need to read it
May 31 19:18:09 dev-haswell-gpu01 kernel: [ 1006.144562] [drm] SADs count is: -2, don't need to read it
May 31 19:18:15 dev-haswell-gpu01 kernel: [ 1011.864726] [drm] SADs count is: -2, don't need to read it
May 31 19:18:19 dev-haswell-gpu01 kernel: [ 1016.094837] [drm] SADs count is: -2, don't need to read it

Any update?
The issue still persists; the last thing I tried is installing the 1.173.1 linux-firmware, but installing it on Ubuntu 16.04 with 4.15 kernels makes clinfo not report any devices (but the kernel does initalize them and rocm-smi displays them). Is this expected?

Thanks @pszi1ard
As its very old issue, and no updates for the last 2 years, this issue is going to be closed.
Request to open a new ticket, if you found any.
Thank you.


Update gd32vf103-pac dependency

I've updated the dependency on gd32vf103-pac due to a dependency conflict with the bare-metal crate:
-cargo build
    Updating crates.io index
error: failed to select a version for `bare-metal`.
    ... required by package `gd32vf103-pac v0.3.0`
    ... which is depended on by `gd32vf103-hal v0.0.5 (/home/users/david/gits/gd32vf103-hal)`
versions that meet the requirements `=0.2.4` are: 0.2.4

all possible versions conflict with previously selected packages.

  previously selected package `bare-metal v0.2.5`
    ... which is depended on by `riscv v0.6.0`
    ... which is depended on by `gd32vf103-hal v0.0.5 (/home/users/david/gits/gd32vf103-hal)`

Also, is there any chance you might be able to push a new release up to Crates.io?

Thanks! That would be a nice update.

@sciguy16 Version 0.0.6 is now released


chore(deps): upgrade swagger-ui-react to 4.11.1

Mitigate the current XSS vulnerabilities (https://www.npmjs.com/advisories/1070339)
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Could you run prettier on the file as well? See the build error.

Alright I made a fixup on top, let's see if it goes green


adds a class to export graph to png image

This is a class to export graph to png image...
It is from reference to issus

@HimangshuYadav I have not reviewed your PR yet. Why did you close it?

@jrobinAV This is my new PR
Please review it.


Pylance doesn't handle type hinting overloading/unions/NoReturn correctly

Environment data

Language Server version: Pylance  v2022.2.5-pre.1
OS and version: Ubuntu 20.04
Python version (& distribution if applicable, e.g. Anaconda): Cpython 3.9.7

When using NoReturn with unions/overloading pylance should not warns about branches that aren't possible.
Expected behavior is that the call to error where raise_error is True should be handled like raise Exception.
from __future__ import annotations
from typing import NoReturn, overload, Literal

@overload
def error(msg, raise_error: Literal[True]) -> NoReturn: ...

@overload
def error(msg, raise_error: Literal[False]) -> None: ...

@overload
def error(msg, raise_error: bool) -> NoReturn | None: ...

def error(msg, raise_error: bool) -> NoReturn | None:
    ...

# Expected behaviour : This block should function like the block below
did_error = False
b = 1
if did_error:
    b = None
    error("Some error", raise_error=True) # Detects proper type NoReturn
b.bit_length # "bit_length" is not a known member of "None" Pylance[reportOptionalMemberAccess]

did_error = False
b = 1
if did_error:
    b = None
    raise Exception("Some error")

b.bit_length # Works fine, no complaints

This is a known limitation within the current implementation of pyright, the type checker that powers pylance. A NoReturn call affects the code flow graph, but the code flow graph is required for type evaluation, and type evaluation is required to determine whether a call returns NoReturn. This circular dependency is handled by performing "lightweight" type evaluation of call expressions that doesn't rely on the power of the full type evaluation engine. This lightweight mechanism is able to handle all common cases, but it can't deal with complexities like overloads where some of the overloads return NoReturn and some do not.
This issue is related to this open issue in pyright's issue tracker.
I don't have a suggested workaround at this time other than to avoid using an overload that returns NoReturn for a subset of signatures.

Closing in favor of the other issue.

So the linked issue relates to general support for NoReturn, but this particular case where some overloads are NoReturn (Never) seems to still be an issue. Should I open a new issue in pyright?


kserve-controller-manager doesn't have enough CPU to run at scale

This ticket has been duplicated from https://github.com/opendatahub-io/opendatahub-operator/issues/499.
Describe the bug
While running the KServe scale test, we observed that the kserve-controller-manager is unable to answer the queries in due time:
2023-08-30 10:33:43,425 p=1878 u=psap-ci-runner n=ansible | <stderr> Error from server (InternalError):
- error when creating "/mnt/logs/004__watsonx_serving__deploy_model/src/inference_service.yaml":
- Internal error occurred: failed calling webhook "inferenceservice.kserve-webhook-server.defaulter":
failed to call webhook:
- Post "[https://kserve-webhook-server-service.redhat-ods-applications.svc:443/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s](https://kserve-webhook-server-service.redhat-ods-applications.svc/mutate-serving-kserve-io-v1beta1-inferenceservice?timeout=10s)":
- context deadline exceeded

To Reproduce
Steps to reproduce the behavior:

Deploy a large number of models (300) in a short timeframe
Query the InferenceService objects regularly
Observe that the KServe webhook is unable to answer the requests

Expected behavior
The KServe webhook is always able to answer the requests
Additional context
The issue likely comes from the low amount of CPU limit given to the kserve-controller-manager:
                        "resources": {
                            "limits": {
                                "cpu": "100m",
                                "memory": "300Mi"
                            },
                            "requests": {
                                "cpu": "100m",
                                "memory": "200Mi"
                            }
                        },

Workaround
I ran the same scale test with

the RHODS operator turned off
the test passed with the CPU and memory limit increased to these values:

    rhods.operator.customize.kserve.cpu: 500m
    rhods.operator.customize.kserve.memory: 500Mi

        run.run(f"oc get deploy/kserve-controller-manager -n redhat-ods-applications -ojson "
                f"| jq --arg mem '{mem}' --arg cpu '{cpu}' '.spec.template.spec.containers[0].resources.limits.cpu = $cpu | .spec.template.spec.containers[0].resources.limits.memory = $mem' "
                f"| oc apply -f-")

This is the manifests : https://github.com/opendatahub-io/kserve/blob/master/config/default/manager_resources_patch.yaml#L13-L14

https://github.com/opendatahub-io/kserve/issues/126
      - name: manager
        resources:
          limits:
            cpu: 500m
            memory: 500Mi


Send timeout metric, handle restarts after timeouts, and send metrics when logs are disabled

What does this PR do?

Send the aws.lambda.enhanced.timeouts metric when a function times out.
Make the extension resilient to being restarted by persisting the current function ARN and request ID in a file when shutting down. When the function starts, it will restore these values from the file and allow it to pick up where it left off. Without this, we could drop logs and metrics due to not having these values available right away, as logs could arrive before we receive the next invocation.
Always collect logs, even when logs_enabled == false. We need these logs to generate enhanced metrics. Instead, when logs are disabled, extract metrics but do not send them to the Datadog intake.

Motivation

Handling timeouts is a requirement for the Lambda Extension.
Restarting the extension, which happens naturally after a timeout, should not result in lost logs.
The current behavior of not submitting some enhanced metrics when logs are disabled is misleading.

Describe your test plan
I added unit tests and am also conducting manual testing.

@DarcyRaynerDD @remeh I have updated the caching logic to cache both the ARN and Request ID in a single JSON file, and to only do this one time, when the extension shuts down. I did not add a version field because I didn't see a need -- if we ever change the format of the persisted data or add new metadata, that would mean a new version of the extension, which would entail the Lambda platform creating new execution environments. That is, I don't think it's possible to have a situation where we would ever have a new version of the extension reading a file created by an older version of the extension. Let me know if I'm missing something there!


[feature request/iOS] swipe to previous/next article vertically

With NetNewsWire a horizontal swipe works. This way you don’t have to read to the end to get to the next article 👍


feature request: nirvana log should parse flag

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

/kind feature
What happened:
cc @kdada @ddysher
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Done by #195


github tests are failing

CI: https://github.com/threefoldtech/js-sdk/runs/1727616463
Branch: development

Verified, and codcov works
on development branch

Verified, and codcov works
on development branch


Runchecker job optimization

Put jobs that are more likely to fail to on pull request CI.
To compensate move some less likely to fail jobs to on push and daily CI jobs.

Depends on #21333

Merged to master branch. Thank you for the reviews.


fix: memory leak of multi initialization.

When initializing desc the memory will be allocated. But it will allocate
again when loading the quantized weights. So one piece of memory will
lost which will make the app memory leaking.

LGTM


Removing Azure Deployment Credentials

By accident i created Deployment Credentials with a user/password so i could deploy by FTP.
Since i'm using Gitlab there's no need to deploy by FTP. How would i be able to remove the Deployment Credentials from Azure? Since deploying is broken now...

Deployment credentials exist as an Azure Web App concept that is separate from Kudu (e.g. they're also used for FTP), so it's not the right place to report. Can you start a thread on https://social.msdn.microsoft.com/Forums/azure/en-US/home?forum=windowsazurewebsitespreview instead, and point to it here? I'll try to get someone to respond there.


AtlasEngine rendering wide Nerd Font glyphs incorrectly

Windows Terminal version
1.16.2523.0
Windows build number
10.0.19044
Other Software
UbuntuMono Nerd font installed from https://github.com/ryanoasis/nerd-fonts/releases/download/v2.2.2/Ubuntu.zip
WSL, running Ubuntu 20.04.1 LTS. SSHing into a RHEL server
The linux server is running tmux with custom status bar with "double wide" icon characters
Steps to reproduce
Use UbuntuMono Nerd Font and configure some double wide character in status bar or print them in terminal
Issue is seen with new AtlasEngined enabled(which is default with new version). Disabling AtlasEngine will bring back old behaviour
Expected Behavior
Double wide characters such as clock, calender which are available in NerdFond are to be rendered as below

Actual Behavior

same here

I gave this issue a title that will hopefully make it easier to find in the future. 🙂
FYI I'm currently working on a version of AtlasEngine that solves this issue fundamentally. My prototype is already capable of handling all Nerd Font glyphs correctly. Unfortunately however it comes with its own set of downsides and is a large change, so the jury is still out on when and in what shape we'll fix this issue. Don't worry though: Until it's been fixed, the old text renderer will not go away.

I gave this issue a title that will hopefully make it easier to find in the future. 🙂
FYI I'm currently working on a version of AtlasEngine that solves this issue fundamentally, by going with a more traditional text rendering approach, allowing for freely overlapping glyphs. My prototype is already capable of handling all Nerd Font glyphs correctly. Unfortunately however it comes with its own set of downsides (slightly slower, more complex, doesn't support user-defined text shaders), so the jury is still out on when and in what shape we'll fix this issue. Don't worry though: Until it's been fixed, the old text renderer will not go away.

You could probably do that in two passes.
First pass with the usual shader rendering standard cells, second pass rendering the overlapping cells if necessary.
That is probably optimal and avoid unnecessary overhead.

You could probably do that in two passes.
First pass with the usual shader rendering standard cells, second pass rendering the overlapping cells if necessary.
That is probably optimal and avoid unnecessary overhead.

That would mean I'd have to keep both, the complexity of our current approach and add the complexity of the new approach for fallback. That would probably make maintainability more difficult than a larger one time change. An idea I had to keep some of the current benefits was to just composite all text into a viewport-sized offscreen texture and blend it onto the swap chain in a single final shading pass, similar to how we do it now.
BTW to give some context on the "slightly slower" / overhead I mentioned: The new approach I've prototyped runs within my test setup at ~200us per frame, whereas the old one needs ~100us per frame. Sure, that's twice as slow, but I'm not even using instancing yet to render glyph quads (or Nvidia's QuadFillMode), nor are we anywhere close to the 500-1000us that the old renderer needs. 😅
I still got quite a number of kinks to iron out, but once that's done I'll discuss with everyone on the team how to best integrate such changes.

I don't think you need to fall back on per glyph rendering to solve the special wide glyphs needed for proper nerdfont icons rendering.
I understand that the speed difference is not significant, IMHO your solution is more complex than doing two passes with shader on a quad.
First pass as already done. (Ignoring wider glyphs)
Second pass only on "special" glyphs with wider cells.
It might even be possible to do everything in a single pass shader, but that should be tested.

When we render we need to conceptually draw in "layers" from bottom to top (including things that are upcoming):

1st pass:

background color
selection (variant 1)
cursor (variant 1 and 2)
glyphs
text decorations (overline, underline, strikethrough, etc.)
sixels, etc.
selection (variant 2)

This can be done in a single compute shader pass. But in order to draw wide glyphs in between we don't have to draw in 2 passes, but in 3, since things like sixels or selections are "on top" of the lower contents. From what I can see it basically turns into:

1st pass:

background color
selection (variant 1)
cursor (variant 1 and 2)
glyphs
† text decorations (overline, underline, strikethrough, etc.)
† sixels, etc.
† selection (variant 2)

2nd pass (optional):

wide glyphs
sixels, etc.

3rd pass ‡:

‡ text decorations (overline, underline, strikethrough, etc.)
‡ sixels, etc.
‡ selection (variant 2)

† optional if no 2nd pass
‡ required if 2nd pass
This is my new approach:

1st pass:

background color
selection (variant 1)

2nd pass:

glyphs
text decorations (overline, underline, strikethrough, etc.)
sixels, etc.
selection (variant 2)

Additionally it actually reduces the amount of code required for text rendering by ~12% (it's just that the remaining code requires more intimate knowledge about DirectWrite and Direct3D). As such right now I personally don't agree that keeping both approaches simultaneously offers a strong benefit.
I'm open to any ideas how to not draw individual quads and I'd be happy to be convinced otherwise, but even if you're right that it's simpler and better, given my knowledge I just wouldn't know how that would work.

The more I think about it the more I think that the whole rendering can be entirely done in one single shader pass.
But that does require a bit of preprocessing and adding metadata for each cell to handle all the cases.
That would mostly be a few special case flags to tell the shader to look for more information in adjacent cells (top, left or bottom)
But of course, given that performance gains are not critical (the optimal solution would be a bit more power efficient) you should simply follow your guts and go for the solution that is the simpler to implement for you.

Thanks for your input! I'll definitely try my hardest to come up with something decent. Nothing is set in stone so far. 🙂

I seem to have a similar problem, except that version 2523 is ok, but the most recent 2642 is broken. I'm using MesloLGM NF at size 9.0 (tried 8.5 and 9.5 as well and those were much worse).
2523 on top, 2642 on bottom:

Is this the same or a different issue?

You can disable the new atlas renderer in the settings, if that solves your issue then it is related.

Yeah, disabling Atlas fixes the problem. Welp, it worked for almost 14 days with the prior version. It had a good run :)  Will try Atlas again once this issue here is all fixed.

@jessey-git I'm sorry I broke your terminal! 😔
I hope you don't mind me saying this, but your font is... weird. 😄
It looks beautiful of course, but it handles its block characters in a very unusual manner. That character (U+E0B0) works in all other Nerd Fonts I got installed (for instance Fira Code), just not with this Meslo variant, which is already a bit weird. Additionally my understanding is that block characters are expected to have approximately the same size as the font's advance width and height. While most Nerd Fonts variants are slightly incorrect in that regard, Meslo in particular is really bad about this. This particular glyph for instance is almost 40% taller than the advance height it specifies which causes it to look like that. The only difference between build 2523 and 2642 is how those glyphs are vertically centered. In both screenshots you're missing more than half of that glyph - it's actually supposed to be a perfect triangle like this:

Basically, IMO Nerd Fonts should stop making block glyphs taller than the font's advance height.
In either case I'm going to simply revert the change that causes your issues: #14085


[Bug]: App saving state frequently ends up in an error state

Is there an existing issue for this?

[X] I have searched the existing issues

Description
App saving state frequently ends up in an error state (yellow icon) instead of saving successfully
Steps To Reproduce

Go to app at this location
Drag and drop widgets/ create queries/ objects and observe the save state turn yellow at some point

Public Sample App
No response
Version
Cloud

@riodeuno @rohitagarwal88 can we triage this? I've seen this occur frequently as well

@yaldram Please triage this issue.


Popped out components are still rendered after closing popout window

Components being popped out remain mounted when the popout window is closed.
When the same component is popped out again, a new copy is created.
The popped out components needs to be unmounted when the Popout component is unmounted, or the popout window is closed.
Reproduction Steps:

Popout a component
Close the popout window
Verify that the popped out component still exists on React DevTools
Repeat 1-2
Verify that a new copy of the popped out component is created on every button click

Sandbox: https://codesandbox.io/s/awesome-silence-0ekjs?file=/src/App.js:0-852
Component gets copied 3 times and doesn't get unmounted, for the above sandbox

It appears the closeChildWindowIfOpened is missing ReactDOM.unmountComponentAtNode(this.container); before closing this.child

this repo seems to be abandoned, will just fix this on our own fork


Change osmomath.Pow to be logarithm based

We currently implement fractional exponentiation using Maclaurin series. We compute x^a by splitting it into x^b * x^c for integer b and 0 <= c < 1, computing the integer component the straight forward way.
We then use the Maclaurin series (1 + y)^a = sum_{k=0^infinity} Binom(a, k) y^k, for the continuation of Binom over the reals.
This only has good convergence bounds for |y| <= 1, implying that 0 < x < 2. (We make the substitution that x = 1 + y).
Hence we have this restriction in the code, of requiring the exponentiation base to be <= 2. Its been pointed out in some of the confio wasm tests, that there are use cases within balancer that necessitate bases > 2.
Its low priority to solve, but does feel like something that should eventually be solved. A few approaches to this:

Do some transformation on the base, e.g. sqrt and square. Measure computation time difference to assess whether a gas difference is needed
If we only need to support small numbers in practice, could use (1 + k + x)^a = (k + x)^a sum_(j=0)^∞ (k + x)^(-j) binomial(a, j) for abs(k + x)>1. This seems like a bad idea though.
Use the logarithm approach to computing x^a. E.g. compute e^(a ln(x)) or 2^(a log_2(x)). There should be lots of literature for how to compute this using precompute tables, and what can be done generally fast. One post on e^x, Balancer logic

This is a good idea, but no longer high impact to justify the state break


Spring Cloud Kubernetes 2.0.2 pulls outdated io.kubernetes dependency

Spring Cloud Kubernetes 2.0.2 pulls an outdated dependency that contains a known vulnerability:
org.bouncycastle:bcprov-ext-jdk15on:jar:1.66
org.bouncycastle:bcpkix-jdk15on:jar:1.66
A newer version of the io.kubernetes client has the newer 1.68 version.
https://snyk.io/vuln/SNYK-JAVA-ORGBOUNCYCASTLE-1052818

@ryanjbaxter do you think this will be fixed in 2.0.3?

@Alos which version are you looking at specifically?

Spring Cloud Kubernetes 2.0.2 pulls io.kubernetes:client-java:11.0.1:

Sorry I mean which version of io.kubernetes had the updated dependencies?

https://github.com/kubernetes-client/java/blob/master/pom.xml

@Alos I am going to delete this issue because its security related, please email me at rbaxter[at]vmware.com

Understood


Service.HeaterCooler is not supported by iOS10

Hello,
I'm building a small heater controller device based NodeMCU and RasPI. And I've been trying for a while to make Service.HeaterCooler work, but failed. May be somebody had more luck and can advice me on this service.
I use HAP-NodeJS v0.4.21.

Looks like the set of supported Services is small
Apple Docs: Accessory Service Types

That list looks like the first version for ios8, we know that there are much more by now.


adding support for aws internet_vip in vpc and tgw sites

Add support for enable_internet_vip in was vpc and tgw sites, which got added in volterra 0.11.18

give me a minute, need to fix something. Wait for another commit

Issue I'm having is, simply setting enable_internet_vip = true isn't sufficient. I also need to enable 'disable_internet_vip'. there are 2 booleans that control this feature.

      + aws_parameters {
          + aws_certified_hw     = "aws-byol-multi-nic-voltmesh"
          + aws_region           = "us-west-2"
          + disable_internet_vip = false
          + enable_internet_vip  = true

needs more work ...


Analyzer top level type inference doesn't support block closures

(We have known we needed to fix this for a long time, but I can't find a specific issue for it, so I'm filing one now)
The analyzer does not correctly infer the types of fields and variables outside of method bodies when their initializers contain block-bodied closures.
For example:
var x = [1, 2, 3].map((x) { return x.toString(); }).toList();

Type inference should infer a type of List<String> for x.  But the analyzer infers a type of List<Null>.

Another case is described in #37422.

The example code no longer errors, and if I change the type of x be List<int> I get an error:
List<int> x = [1, 2, 3].map((x) { return x.toString(); }).toList();

A value of type 'List<String>' can't be assigned to a variable of type 'List<int>'.


spoc merge: add --check

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a --check flag to spoc merge. This can be used to ensure that (automatically generated) profiles are subsets of a (hand-authored) profile in CI. This is better than manually calling diff as we ignore non-essential syntax such as comments.
Which issue(s) this PR fixes:
None
Does this PR have test?
Not yet.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
`spoc merge` now has a `--check` flag to ensure that a profile is a superset of other profiles.

/ok-to-test

Codecov Report
Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 41.12%. Comparing base (11d77f4) to head (b7715e3).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
- Coverage   45.50%   41.12%   -4.38%
==========================================
  Files          79      107      +28
  Lines        7782    15540    +7758
==========================================
+ Hits         3541     6391    +2850
- Misses       4099     8678    +4579
- Partials      142      471     +329

Fixing the CI in https://github.com/kubernetes-sigs/security-profiles-operator/pull/2242

/test all

@mhils please rebase on top of main to get the latest CI fixes in.

/lgtm


Module not found while importing from node-cache-manager-ioredis

I'm trying to use node-cache-manager-ioredis but struggling on importing from the package, as described in the readme:
import { ioRedisStore } from '@tirke/node-cache-manager-ioredis';

gives me the following error:
Error: Module not found: Error: Package path . is not exported from package [...]/node_modules/@tirke/node-cache-manager-ioredis (see exports field in<EMAIL_ADDRESS>
The project is pretty much standard:

Node: 16.14.2
TS: 4.7.4

Any advice?

removing
"exports": {
    ".": {
      "require": "./src/index.js"
    }
  }

from the installed node module package.json would solve the issue, but this isn't really an option.

narrowing down a bit more: using require syntax works, but this doesn't fit for my project.
So, updating the "exports" section in package.json to the following makes it work, when using import {...} from ...:
  "exports": {
    ".": {
      "require": "./src/index.js",
      "import": "./src/index.js"
    }

it would be great if using import syntax could also be properly supported.

Hello @vz-tl, as you can see all the examples in docs are using the import syntax, so it works well, can you link your tsconfig or the way you are compiling / using your typescript?

This is an Angular Universal project, where your module is being imported in the express server part.  The project is compiled via regular Angular server build target, based on webpack.
Below related tsconfig.server.json output using tsc --showConfig:
{
    "compilerOptions": {
        "rootDir": ".",
        "baseUrl": ".",
        "target": "es2016",
        "module": "es2020",
        "typeRoots": [
            "node_modules/@types"
        ],
        "lib": [
            "es2018",
            "dom",
            "es2018.asynciterable"
        ],
        "moduleResolution": "node",
        "downlevelIteration": true,
        "sourceMap": true,
        "declaration": false,
        "emitDecoratorMetadata": true,
        "experimentalDecorators": true,
        "forceConsistentCasingInFileNames": true,
        "importHelpers": true,
        "skipLibCheck": true,
        "skipDefaultLibCheck": true,
        "resolveJsonModule": true,
        "esModuleInterop": true,
        "allowJs": true,
        "paths": {
          // removed for brevity
        },
        "types": [
            "node"
        ],
        "outDir": "./out-tsc/server"
    },
    "files": [
        "./src/main.server.ts",
        "./server.ts",
         // rest removed for brevity
    ],
    "include": [
      // removed for brevity
    ],
    "exclude": [
        "jest.config.ts"
    ]
}

@vz-tl Publish 3.2.0 that should expose a CJS and an ESM build can you try with this new version?

@Tirke , works perfectly! Thx a lot!


Cloud blob store changes for serving data

This PR makes CloudBlobStore compatible with BlobStore.
Also makes changes in CloudBlobStore with respect to validations and functionality required for serving data.

I think many of the places you added exception throws for live traffic will break the VCR. The tests don't seem to capture that since a dummy validator is passed to AzureCloudDestination. (We don't really have a CloudBlobStore integration test which is a current gap.)

After closer review, fixed the cases where validations could break VCR.

Codecov Report

Merging #1517 into master will decrease coverage by 0.04%.
The diff coverage is 57.04%.

@@             Coverage Diff              @@
##             master    #1517      +/-   ##
============================================
- Coverage     73.63%   73.58%   -0.05%
- Complexity     8146     8165      +19
============================================
  Files           572      572
  Lines         44684    44769      +85
  Branches       5645     5672      +27
============================================
+ Hits          32901    32942      +41
- Misses        10123    10163      +40
- Partials       1660     1664       +4

Impacted Files
Coverage Δ
Complexity Δ

...va/com/github/ambry/replication/ReplicaThread.java
85.24% <ø> (-0.82%)
109.00 <0.00> (-1.00)

...java/com/github/ambry/cloud/CloudBlobMetadata.java
87.59% <20.00%> (-2.01%)
48.00 <7.00> (+5.00)
:arrow_down:

...ithub/ambry/cloud/azure/AzureBlobDataAccessor.java
77.71% <25.00%> (-1.39%)
26.00 <0.00> (ø)

...in/java/com/github/ambry/cloud/CloudBlobStore.java
74.05% <55.55%> (-10.16%)
109.00 <27.00> (+9.00)
:arrow_down:

...ithub/ambry/cloud/azure/AzureCloudDestination.java
75.13% <78.26%> (-0.43%)
36.00 <2.00> (+1.00)
:arrow_down:

...java/com/github/ambry/store/CompactionManager.java
89.88% <0.00%> (-2.39%)
25.00% <0.00%> (ø%)

.../main/java/com/github/ambry/store/ScanResults.java
81.25% <0.00%> (-1.57%)
16.00% <0.00%> (-1.00%)

...rc/main/java/com/github/ambry/store/BlobStore.java
86.43% <0.00%> (-0.51%)
128.00% <0.00%> (ø%)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62264b...5c9b48f. Read the comment docs.

I can merge this after the conflicts are resolved.

Will merge once CloudBlobStoreTest test is fixed.


make server threads configurable with server.properties file

Description
Fixes: https://github.com/apache/cloudstack/issues/9161

Types of changes

Enhancement (improves an existing feature and functionality)

Feature/Enhancement Scale

Minor

How Has This Been Tested?

Tested manually by building and running the server.
How did you try to break this feature and the system with this change?

@blueorangutan package

@blueorangutan test

Ideally max thread could be 4 or 8 times the number of CPUs, need to explore how jetty connection pooling works - in which case we may only want to configure the max threads (min can be set to 4 or 8 times number of CPUs).


Update Azure keyvault task in all dnceng owned repositories

We are starting to see warnings in our builds that the AzureKeyVault@1 task needs to be updated. We should examine all our repos for usage and update, including the shared infrastructure in arcade.
Sample build showing the warnings: https://dnceng.visualstudio.com/internal/_build/results?buildId=2515530&view=results

[ ] Helix-service
[ ] Helix-machines
[ ] Dnceng
[ ] Dnceng-shared
[ ] Arcade
[ ] Arcade-validation
[ ] Arcade-extensions

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

PR for arcade release/8.0 branch: https://github.com/dotnet/arcade/pull/15017

This ended up not being needed.


Log viewer fix

Log viewer could be broken because of site_date() function omitting default values. Some minor improvements added.

Rebased, pushed, I hope I got it right this time :)


How to list the method_name(s) in a experiment

I cannot find the docs about listing the methods in Backdoor or else ?
The convention is like
backdoor.linear_regression
but, I don't know the list of the methods.

The list of methods are:

DoWhy:

Each file in the folder causal_estimators corresponds to a method. You can call it by replacing class name, e.g., PropensityScoreMatchingEstimator with its _ separated lowercase version: propensity_core_matching

EconML:

Any method that is defined in EconML as an estimator. You need to provide the full, qualified class name as the method_name. See the conditional effects notebook for examples.


IBM Z: Add vectorized CRC32 implementation

While DFLTCC takes care of accelerating compression on level 1, others
can be sped up too by computing CRC32 using various vector instructions.
The code for that was taken from the Linux kernel, its original author
(Hendrik Brueckner) works for IBM and has allowed reusing the code under
zlib license.

A few minor improvements:

Fixed the following annoying configure warnings on x86:

ls: cannot access '/home/spujb/myrepos/zlib-ng/arch/x86/*.s': No such file or directory
ls: cannot access '/home/spujb/myrepos/zlib-ng/arch/x86/*.s': No such file or directory

Updated the documentation.
Added a Travis CI configuration.

Trying to fix the following:
  Could not find compiler set in environment variable CC:

  clang-6.0.

in Ubuntu 16.04 Clang  by using clang instead.

Yay, this helped:
@@ -250,7 +260,7 @@ jobs:
           - name: Ubuntu 16.04 Clang
             os: ubuntu-16.04
             compiler: clang-6.0
-            # note: github preinstalls compilers now, see https://github.com/actions/virtual-environments/pull/369/
+            packages: clang-6.0

           - name: Ubuntu Clang
             os: ubuntu-latest

Now we have:
The C compiler identification is Clang 6.0.0

and the build is successful and the tests pass.

Rebased, fixed a clang and a -m31 issue.

Needs a rebase

I'm not a fan of using assembly code as all the rest of our code is in C.

All code using assembly code should be converted to using compiler intrinsics if possible.

I've rewritten the code with intrinsics, now it's even slightly faster than the asm version.

Add separate s390.c/s390.h files for feature detection.
Move -mzarch/-fzvector detection from Makefile.in to configure.
Simplify the copyright comment.
Move s390_crc32_vx() implementation to arch/s390.
Do not save the original crc32 function, just call crc32_big for small and misaligned buffers.
Clean up inconsistencies between vx-crc32 / crc32-vx: it's crc32-vx everywhere now.

Rebased, resolved add_option -> option conflict.

@iii-i don't forget it must be added at the bottom of CMakeLists.txt in add_feature_info.

Refactored feature detection in CMakeLists.txt and configure.

Sorry, this needs another little rebase.

Rebased.

@Dead2 thanks for having a look!
@mtl1979 @nmoinvaz is there anything else that needs to be improved here?

Make it ON by default, change the new CI jobs to OFF.
Fix printing the feature list when the toolchain does not support the vector intrinsics.
Add NOLTOFLAG (like other arches).

LGTM


merge from template-arlac77-github

package.json

chore(deps): add ^7.25.8 remove ^7.25.7 (devDependencies.npm-pkgbuild)

.github/workflows/ci.yml

chore(deps): add 16.14.0 remove 16.13.2 (jobs.test.strategy.matrix.node-version)
chore: add 16.14.0 (jobs.release.steps.with.node-version)

.github/workflows/codeql_analysis.yml

chore: add 16.14.0 (jobs.analyze.steps.with.node-version)

:tada: This PR is included in version 1.10.51 :tada:
The release is available on:

v1.10.51
GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Deploy Checklist: New Expensify 2023-11-08

Release Version: 1.3.97-0
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[ ] https://github.com/Expensify/App/pull/24178
[x] https://github.com/Expensify/App/pull/27399
[x] https://github.com/Expensify/App/pull/28269
[ ] https://github.com/Expensify/App/pull/28308
[ ] https://github.com/Expensify/App/pull/28361
[ ] https://github.com/Expensify/App/pull/28469
[x] https://github.com/Expensify/App/pull/28703
[x] https://github.com/Expensify/App/pull/28789
[ ] https://github.com/Expensify/App/pull/28793
[ ] https://github.com/Expensify/App/pull/28840
[ ] https://github.com/Expensify/App/pull/29037
[x] https://github.com/Expensify/App/pull/29169
[x] https://github.com/Expensify/App/pull/29226
[ ] https://github.com/Expensify/App/pull/29248
[ ] https://github.com/Expensify/App/pull/29264
[ ] https://github.com/Expensify/App/pull/29522
[x] https://github.com/Expensify/App/pull/29559
[ ] https://github.com/Expensify/App/pull/29561
[x] https://github.com/Expensify/App/pull/29580
[ ] https://github.com/Expensify/App/pull/29584
[ ] https://github.com/Expensify/App/pull/29636
[ ] https://github.com/Expensify/App/pull/29742
[ ] https://github.com/Expensify/App/pull/29755
[ ] https://github.com/Expensify/App/pull/29781
[x] https://github.com/Expensify/App/pull/29857
[ ] https://github.com/Expensify/App/pull/29907
[ ] https://github.com/Expensify/App/pull/29988
[ ] https://github.com/Expensify/App/pull/30050
[x] https://github.com/Expensify/App/pull/30072
[ ] https://github.com/Expensify/App/pull/30074
[ ] https://github.com/Expensify/App/pull/30077
[ ] https://github.com/Expensify/App/pull/30106
[ ] https://github.com/Expensify/App/pull/30193
[ ] https://github.com/Expensify/App/pull/30201
[ ] https://github.com/Expensify/App/pull/30231
[ ] https://github.com/Expensify/App/pull/30242
[ ] https://github.com/Expensify/App/pull/30245
[ ] https://github.com/Expensify/App/pull/30279
[ ] https://github.com/Expensify/App/pull/30302
[ ] https://github.com/Expensify/App/pull/30354
[ ] https://github.com/Expensify/App/pull/30355
[ ] https://github.com/Expensify/App/pull/30358
[ ] https://github.com/Expensify/App/pull/30412
[ ] https://github.com/Expensify/App/pull/30434
[x] https://github.com/Expensify/App/pull/30443
[ ] https://github.com/Expensify/App/pull/30459
[ ] https://github.com/Expensify/App/pull/30480
[ ] https://github.com/Expensify/App/pull/30502
[ ] https://github.com/Expensify/App/pull/30515
[ ] https://github.com/Expensify/App/pull/30516
[ ] https://github.com/Expensify/App/pull/30524
[ ] https://github.com/Expensify/App/pull/30553
[ ] https://github.com/Expensify/App/pull/30557
[ ] https://github.com/Expensify/App/pull/30562
[ ] https://github.com/Expensify/App/pull/30580
[ ] https://github.com/Expensify/App/pull/30597
[ ] https://github.com/Expensify/App/pull/30627
[x] https://github.com/Expensify/App/pull/30633
[ ] https://github.com/Expensify/App/pull/30638
[ ] https://github.com/Expensify/App/pull/30642
[ ] https://github.com/Expensify/App/pull/30653
[ ] https://github.com/Expensify/App/pull/30657
[ ] https://github.com/Expensify/App/pull/30661
[x] https://github.com/Expensify/App/pull/30667
[ ] https://github.com/Expensify/App/pull/30669
[ ] https://github.com/Expensify/App/pull/30670
[ ] https://github.com/Expensify/App/pull/30675
[ ] https://github.com/Expensify/App/pull/30688
[ ] https://github.com/Expensify/App/pull/30694
[ ] https://github.com/Expensify/App/pull/30700
[ ] https://github.com/Expensify/App/pull/30701
[ ] https://github.com/Expensify/App/pull/30705
[ ] https://github.com/Expensify/App/pull/30711
[ ] https://github.com/Expensify/App/pull/30713
[ ] https://github.com/Expensify/App/pull/30714
[ ] https://github.com/Expensify/App/pull/30715
[ ] https://github.com/Expensify/App/pull/30716
[ ] https://github.com/Expensify/App/pull/30717
[ ] https://github.com/Expensify/App/pull/30718
[ ] https://github.com/Expensify/App/pull/30719
[x] https://github.com/Expensify/App/pull/30722
[ ] https://github.com/Expensify/App/pull/30723
[ ] https://github.com/Expensify/App/pull/30735
[ ] https://github.com/Expensify/App/pull/30745
[ ] https://github.com/Expensify/App/pull/30748
[ ] https://github.com/Expensify/App/pull/30751
[ ] https://github.com/Expensify/App/pull/30754
[ ] https://github.com/Expensify/App/pull/30772
[ ] https://github.com/Expensify/App/pull/30773
[ ] https://github.com/Expensify/App/pull/30779
[x] https://github.com/Expensify/App/pull/30784
[ ] https://github.com/Expensify/App/pull/30785
[ ] https://github.com/Expensify/App/pull/30787
[ ] https://github.com/Expensify/App/pull/30808
[ ] https://github.com/Expensify/App/pull/30810
[ ] https://github.com/Expensify/App/pull/30814
[ ] https://github.com/Expensify/App/pull/30816
[ ] https://github.com/Expensify/App/pull/30818
[ ] https://github.com/Expensify/App/pull/30820
[ ] https://github.com/Expensify/App/pull/30822
[ ] https://github.com/Expensify/App/pull/30828
[ ] https://github.com/Expensify/App/pull/30830
[ ] https://github.com/Expensify/App/pull/30831
[ ] https://github.com/Expensify/App/pull/30845
[x] https://github.com/Expensify/App/pull/30852
[ ] https://github.com/Expensify/App/pull/30853
[ ] https://github.com/Expensify/App/pull/30857
[ ] https://github.com/Expensify/App/pull/30862
[ ] https://github.com/Expensify/App/pull/30872
[ ] https://github.com/Expensify/App/pull/30876
[ ] https://github.com/Expensify/App/pull/30881
[ ] https://github.com/Expensify/App/pull/30887
[ ] https://github.com/Expensify/App/pull/30899
[ ] https://github.com/Expensify/App/pull/30916
[ ] https://github.com/Expensify/App/pull/30918
[ ] https://github.com/Expensify/App/pull/30923
[ ] https://github.com/Expensify/App/pull/30926
[ ] https://github.com/Expensify/App/pull/30928
[ ] https://github.com/Expensify/App/pull/30959
[ ] https://github.com/Expensify/App/pull/30962
[ ] https://github.com/Expensify/App/pull/30965
[ ] https://github.com/Expensify/App/pull/30970
[ ] https://github.com/Expensify/App/pull/30978
[ ] https://github.com/Expensify/App/pull/30995
[ ] https://github.com/Expensify/App/pull/31011
[ ] https://github.com/Expensify/App/pull/31014
[ ] https://github.com/Expensify/App/pull/31025
[ ] https://github.com/Expensify/App/pull/31044
[ ] https://github.com/Expensify/App/pull/31048
[ ] https://github.com/Expensify/App/pull/31063

Deploy Blockers:

[ ] https://github.com/Expensify/App/issues/31078
[ ] https://github.com/Expensify/App/issues/31080

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Checking off the following PRs from the past builds:
#24178
#28308
#28361
#28469
#28793
#28840
#29037
#29248
#29522
#29561
#29584
#29636
#29742
#29755
#29781
#29907
#29988
#30050
#30074
#30077
#30106
#30193
#30201
#30231
#30242
#30245
#30279
#30302
#30354
#30355
#30412
#30434
#30459
#30480
#30502
#30515
#30516
#30524
#30553
#30557
#30562
#30580
#30627
#30638
#30642
#30653
#30657
#30661
#30669
#30670
#30675
#30688
#30700
#30701
#30705
#30711
#30713
#30714
#30715
#30716
#30717
#30718
#30719
#30723
#30735
#30745
#30748
#30751
#30754
#30772
#30773
#30779
#30785
#30787
#30810
#30814
#30816
#30818
#30820
#30822
#30828
#30830
#30831
#30845
#30853
#30857
#30862
#30872
#30887
#30899
#30916
#30918
#30923
#30926
#30928
#30959
#30965
#30995
#31011
#31014

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.97-0 :rocket:

Regression is at 77%.

https://github.com/Expensify/App/issues/31098 fixed in staging

@puneetlath in which build should we test the cps which are unchecked?

@kavimuru when the cp is completed there should be a comment on the pr with the release number in which the change was deployed in

@mountiny Thanks ! It has been 18 hours and I don't see the release number #31079. So I wanted to double check.

@puneetlath Regression is completed.
Open Blockers:
#31069
#31085
#31091
#31103
#31106
#31108
#31114
#31139
#31143
#31149

Thanks @kavimuru!

We are waiting for the release version of the build to validate the cps.

The latest staging version is 1.3.97-4

The commenting on the PRs is broken for some reason, looking into that.

@puneetlath can we go ahead and validate all the 3 cps in 1.3.97-4 build?

Yes please!

:shipit:


Release .31.40 to the Linux stable branch

This version's features are an early implementation of the features that will be released till version .40

This release should be quite stable so if anyone wants to use this version of FalconXOS-Linux, they can do so by checking out this pull request(FalconXOS is no longer updated or is currently not being worked on so I won't be merging this pull request into the main branch)


error about obj_models in "val/02876657/d3b53f56b4a7b3b3c9f016d57db96408"

Dear author, thank you for releasing such a wonderful work!
I met a problem when running shape_data.py to preprocess the object models.
The info is as follows.
Traceback (most recent call last):   File "/home/user/object-deformnet/preprocess/shape_data.py", line 217, in <module>     save_nocs_model_to_file(obj_model_dir)   File "/home/user/object-deformnet/preprocess/shape_data.py", line 33, in save_nocs_model_to_file     model_points = sample_points_from_mesh(path_to_mesh_model, 1024, fps=True, ratio=3)   File "../lib/utils.py", line 147, in sample_points_from_mesh     points = uniform_sample(vertices, faces, ratio*n_pts, with_normal)   File "../lib/utils.py", line 100, in uniform_sample     faces = vertices[faces] IndexError: arrays used as indices must be of integer (or boolean) type
It seems that the obj.model in "obj_models/val/02876657/d3b53f56b4a7b3b3c9f016d57db96408" is not correct. How can I solve this problem?

same questions

Could you tell me how you solve it ?

 Can you tell me?

I skip this instance, then run train_ae.py and train_deform.py and evaluate.py, it doesn't seem to have any effect compared to the author's model.


Fix Update for preview

Description
Changes proposed in this pull request:

fix update process for preview

The implementation of update steps were expecting RuntimeState with reconciler input and a kyma version. The problem is that preview does not creates it.
The problem could be seen here: https://status.build.kyma-project.io/log?container=test&id=1595718914791182336&job=skr-preview-dev
Related issue(s)

/hold

/unhold


iOS: Gestures in vertical scrolling

I'd like to see two story-wide interactive gestures in vertical scrolling mode:

Swiping right takes you back to the story list. This should be interactive, like dragging on the left-mode edge.
Swiping left takes you to the next story, just as scrolling down beyond the bottom of the story would. We need a gesture to skip long stories.

For the swipe left gesture, that next story can look like it's being added to the stack. See the Inoreader iOS app and how it handles swiping to the next story. I think that's a clean look and means we don't need to build in new UI to handle that.

I don't have that app, and couldn't find a video showing that; can you show a screen recording or other video? Fancy animations aren't my forte, but I can see what I can do.

Here's a video: https://share.icloud.com/photos/0KQvOOCqYJIa2MKzZ-Uq0iGAg

I have a plan for this as part of the Catalyst improvements; see #817 for more info.

This is pretty much done in the Catalyst branch. I won't close it yet, as there may be some tweaks, but you can scroll between stories either horizontally or vertically, without needing to change any settings, so can be scrolling vertically then horizontally to skip a story.

This is now un-done. See #817 for commentary. I'll need to come up with another solution for this request. I have some ideas noted. I'll defer work on this till more important changes are done.

This is now un-done. See #817 for commentary. I'll need to come up with another solution for this request. I have some ideas noted. I'll defer work on this till more important changes are done.