[NO QA] [TS migration] Migrate LinkPreviewer component to TypeScript

Details
Migration of 'LinkPreviewer' to Typescript. This cannot be tested by QA because link preview permission is globally set to false. If you want to test it, set Permissions.canUseLinkPreview() to return True and send links in chat.
Fixed Issues
$ https://github.com/Expensify/App/issues/31948
PROPOSAL: N/A
Tests

[x] Verify that link previews function properly in chat(to allow showing LinkPreviews you have to edit Permissions file and set canUseLinkPreview to return true).
[x] Test main flows of the app(sending messages, logging, requesting money)

Offline tests
N/A
QA Steps
N/A This issue cannot be currently tested without hacking the Permissions in app. At this moment link previews permission is set to false. I've set this to true in code and made sure the LinkPreview works as expected, but someone that cannot change the codebase won't be able to test this.
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/88395093/e2d70af2-0576-4739-927d-454ca430c310

Android: mWeb Chrome
https://github.com/Expensify/App/assets/88395093/6ca022c1-5e60-4729-be62-5b89dd110900

iOS: Native
https://github.com/Expensify/App/assets/88395093/ce85d353-2061-4918-ba3f-f077665cb9fc

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88395093/4b3d4af2-d8ba-409f-ab2f-0a37ae25e7f0

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88395093/b7dee319-3533-4aaa-8b1b-844343f6b610

MacOS: Desktop
https://github.com/Expensify/App/assets/88395093/ee0a4695-63c1-43a8-88fb-79d41d3c9c63

@SzymczakJ please resolve conflicts and I think you should remove [No QA] prefix from PR title

Can you merge main here?

@shubham1206agra merged main

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/58412969/10520e4f-e565-46c4-944e-f8d81731049b

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/58412969/647183d5-d67d-41e0-8483-7461f62b104e

MacOS: Desktop

@bondydaa Looks like this PR needs your approval

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


feat: Add long columns in status card

Description
Changes proposed in this pull request:

Add long columns in status card

Related issue(s)

Definition of done

[x] The PR's title starts with one of the following prefixes:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
refactor: A code change that neither fixes a bug nor adds a feature
test: Adding tests
chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.

[x] Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
[x] Explain clearly why you created the PR and what changes it introduces
[x] All necessary steps are delivered, for example, tests, documentation, merging

my proposal: maybe we can remove the type property and change it to fullWidth: true


Ensure we convert mongoose models to regular objects. Closes #110.

Do we want to do that? This change might have weird side effects for people that are using models (e.g. with getters etc.). We could make a breaking release that sets lean: true by default or only calls toObject in those methods if lean: true (but then it should do remove as well).

I had a similar thought as @daffl, are there implications / side effects to doing this?

@daffl @corymsmith no it's not an issue or at least no worse than what currently happens. Right now, we're not calling save on the data object. If this was a mongoose model and we did this that is what would trigger pre and post mongoose hooks. Since we're not doing that, it's just treated as a normal JS object and mongoose will return a mongoose model after the DB call (unless you're using lean: true).
Currently if you pass a mongoose model it just blows up. Hence #110.

Oh sorry... I totally read that wrong. All good, :shipit:


Get-OfficeMRU.ps1

Acquires Microsoft Office MRU from registry
and reformats on the target as tsv output.

Output directive removed. The script returns an object with Methods and Properties. Error handling removed.

Pull request merged. Thanks!
Date: Tue, 24 Nov 2015 08:04:29 -0800
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [Kansa] Get-OfficeMRU.ps1 (#141)
Output directive removed. The script returns an object with Methods and Properties. Error handling removed.
—
Reply to this email directly or view it on GitHub.


special character issue fixed.

Special characters change the endpoint URLs when the enums are converted to lowercase in the request. The response of Instagram is 404 in this situation. This happens when the device language is different than English. (i.e: Turkish)

@jvogit 6


Make service status badges hyperlinks to the pipelines

cc @denelon
Microsoft Reviewers: Open in CodeFlow

Nice touch!


Fix 352 url

Overview
Refactoring of the IOHandler class to handle urls.
I got carried away here and refactored the class instead of adding a bunch of if clauses all over the place. The main difference from the previous implementation is that once a ComplexInput sets a property (file, data, url, stream), it won't be possible to set another attribute. Other properties can however be read, that is
h = IOHandler()
h.data = 'test'
f.file = 'test.txt' # will raise an error but
print(h.file) will work.

So URLs can now be set and won't trigger a download unless explicitly requested by accessing the file attribute.
h = IOHandler()
h.url = 'http://...' # Mixes the instance with the UrlHandler class.
h.file # Fetches the data and copies to a local file
h.data # Reads the content from h.file

Related Issue / Discussion
Email threads on pywps-dev
https://github.com/geopython/pywps/issues/352
Additional Information

This will help support opendap mimetype.
birdhouse/master is behind the upstream repo.
Very few modifications were done to tests, so these changes should be backward compatible, except for cases where IOhandler instances set different properties (which is probably a bad idea anyway).

Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

[x] I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
[x] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Yes, but I'd like you to take a look before I make an official PR to the repo to make sure I'm not doing something stupid.

@huard I have merged this PR to a new branch:
https://github.com/bird-house/pywps/tree/dev-issue-352-url
I have fixed pep8 and the tests (python 2/3 encoding issues).

@huard I would set config defaults in the configuration module. For tests we might want a special config ... I think you tried this in PR #1. /tmp as allowedinputpaths does not work on macOS (using /var/):
https://github.com/bird-house/pywps/blob/4ba73cfdc0e29d70784cdb7ed486f9e35d78c0ab/pywps/inout/basic.py#L170

@huard I tried this PR with Emu and my chomsky process complains:
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/app/Process.py", line 200, in _run_process
    self.handler(wps_request, wps_response)  # the user must update the wps_response.
  File "/Users/pingu/Documents/GitHub/birdhouse/emu/emu/processes/wps_chomsky.py", line 159, in _handler
    response.outputs['output'].file = fout.name
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/inout/basic.py", line 277, in fset
    setattr(s, kls.prop, value)
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/inout/basic.py", line 295, in file
    self._validate_file_input(path)
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/inout/basic.py", line 370, in _validate_file_input
    raise FileURLNotSupported()
pywps.exceptions.FileURLNotSupported: 400 FileURLNotSupported: File URL not supported as input.

The allowedinputpath check also runs for outputs ... probably useful. We need to make sure that pywps temp folders are always allowed.

@huard ... I allowed all outputs but I run then into another exception, something went wrong with setting the outputs:
2018-08-03 17:53:43,280] [ERROR] line=229 module=Process Process error: wps_chomsky.py._handler Line 159 [Errno 2] No such file or directory: '/Users/pingu/Documents/GitHub/birdhouse/emu/out.txt' -> '/var/folders/5f/t661zdnd181ck1dv429s4p8r0000gn/T/pywps_process_pu8rotdd/out.txt'
2018-08-03 17:53:43,287] [ERROR] line=45 module=exceptions Exception: code: 400, locator: Writing Response Document failed with : [Errno 2] No such file or directory: '/var/folders/5f/t661zdnd181ck1dv429s4p8r0000gn/T/pywps_process_pu8rotdd/out.txt', description:
Traceback (most recent call last):
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/app/Process.py", line 200, in _run_process
    self.handler(wps_request, wps_response)  # the user must update the wps_response.
  File "/Users/pingu/Documents/GitHub/birdhouse/emu/emu/processes/wps_chomsky.py", line 159, in _handler
    response.outputs['output'].file = fout.name
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/inout/basic.py", line 277, in fset
    setattr(s, kls.prop, value)
  File "/Users/pingu/Documents/GitHub/birdhouse/pywps/pywps/inout/basic.py", line 297, in file
    os.symlink(path, self._tmpfilename)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/pingu/Documents/GitHub/birdhouse/emu/out.txt' -> '/var/folders/5f/t661zdnd181ck1dv429s4p8r0000gn/T/pywps_process_pu8rotdd/out.txt'

@huard This PR comes with a lot of code changes. Though they look meaningful I can't oversee them. We should also ask for a review by the original pywps code authors (Jachym and Luis).
In this PR you have the following:

clean up of code
introducing a new URL property
refactoring of IOHandler.

It might be easier to get this into pywps with 2-3 PRs.

Thanks for the review, will do 1, 3, 2.

Not clear to me what I should do about the allowed input path configuration. Should the test loader modify the config ?

I can't reproduce the bug you see with emu on linux. I suspect it has something to do with the allowedinputpath. Should I set the default to outputpath ?

Wait, I've done a pull on master and now I get the same error. Investigating.

So I think the bug has to do with the fact that I'm using the same code for inputs and outputs. If I restrict the file setter code to ComplexInput, it works. Now it's not clear to me how I should handle outputs.

Looks like you figured it out :)

Yes an no. I simplified the Handler classes by removing the code that reproduced the logic in app/Service.py and which was specific to input handling. It makes the PR simpler and less error prone. I still think the Service.py logic could be moved into the ComplexInput class, but that will be for another day.

Add to pywps: https://github.com/geopython/pywps/issues/352
Closing now.


xml.parsers.expat.ExpatError: no element found

If I want to use the tool I just get this error message:
Traceback (most recent call last):   File "Main.py", line 250, in <module>     Main()   File "Main.py", line 105, in __init__     xmldoc = minidom.parse(self.proxyListFile)   File "/usr/lib/python3.6/xml/dom/minidom.py", line 1958, in parse     return expatbuilder.parse(file)   File "/usr/lib/python3.6/xml/dom/expatbuilder.py", line 911, in parse     result = builder.parseFile(fp)   File "/usr/lib/python3.6/xml/dom/expatbuilder.py", line 211, in parseFile     parser.Parse("", True) xml.parsers.expat.ExpatError: no element found: line 304, column 0
I use Python 3.6.7 and pip 19.0.3.
I have really no idea what I could do now. Could someone help me?

Its most likely an error due to the XMLParser not able to parse the ProxyListFile. Even if you could do that, I would say of that most of the proxies in that list will not work as the developer is inactive


[Bug]: Relationships not working with SWA

What happened?
Relationships are not working for me with GraphQL and SWA.
Here is what my graphql schema looks like:
type Submission @model {
  id: ID!
  personId: ID!
  condition: String!
  tests: [Test]
  history: [Timestamp]
}

type Person @model {
  id: ID!
  condition: String!
}

I want to make a relationship with the Person and submission, so I added this to my database config file:
    "Person": {
      "source": "participant-container",
      "permissions": [
        {
          "actions": ["*"],
          "role": "anonymous"
        }
      ],
      "relationships": {
        "submissions": {
          "cardinality": "many",
          "target.entity": "Submission",
          "source.fields": ["id"],
          "target.fields": ["personId"]
        }
      }
    },

Using this test query:
    query getPersons {
      people {
        items {
          id
          condition
          submissions {
            items {
              id
            }
          }
        }
      }
    }

I get this result:
graphql.error.graphql_error.GraphQLError: Cannot query field 'submissions' on type 'Person'
Why isn't the relationship working? I shouldn't need to make any changes to my gql schema, right? The DAB docs show how to add a relationship but I haven't seen anything similar in SWA. I would assume it works exactly the same though, the only change necessary is in the config file, right?
To clarify, I am testing on the swa dev server, not the deployed SWA app.
Version
0.7.6+61de247acf65280d93783072226f695536591ffb
What database are you using?
CosmosDB NoSQL
What hosting model are you using?
Static Web Apps (SWA)
Which API approach are you accessing DAB through?
GraphQL
Relevant log output
[swa] POST http://localhost:5000/graphql (proxy)
[dataApi] info: Microsoft.AspNetCore.Hosting.Diagnostics[1]
[dataApi]       Request starting HTTP/1.1 POST http://localhost:4280/graphql application/json 1415
[dataApi] info: Microsoft.AspNetCore.Routing.EndpointMiddleware[0]
[dataApi]       Executing endpoint 'Hot Chocolate GraphQL Pipeline'
[dataApi] info: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]
[dataApi]       Executed endpoint 'Hot Chocolate GraphQL Pipeline'
[swa] POST http://localhost:4280/graphql - 200
[dataApi] info: Microsoft.AspNetCore.Hosting.Diagnostics[2]
[dataApi]       Request finished HTTP/1.1 POST http://localhost:4280/graphql application/json 1415 - 200 - application/json;+charset=utf-8 3.3330ms

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey @atyshka, at the moment, relationships are not supported for CosmosDB NoSQL. Relationships are applicable only for SQL database types.
To be able to successfully execute the query you have mentioned in your example, the Submissions entity needs to be embedded within the People entity. Cosmos DB Data Modeling
The schema file definition would look something like this
type People @model(name:"People") {
    ...
    submissions: [Submission]
}

type Submission @model(name: "Submission"){
   ...
}

@atyshka, the @model directive is utilized to establish a correlation between the GraphQL object type in the schema you provide and the corresponding entity name in the runtime config.
The directive is formatted as: @model(name:"<Entity_Name>").
The name parameter for the @model directive represents the name of the entity in your configuration file.
It is only required if you were the name of your entity differs from the name of the corresponding GraphQL object type.
For e.g., in your case if your entity Person were to have GraphQL type as Pupil your type definition would change as follows assuming the config stays the same:
type Pupil @model(name:"Person") {
    ...
    submissions: [Submission]
}

with the config entry:
"Person": {
      "source": "participant-container",
      "permissions": [
        {
          "actions": ["*"],
          "role": "anonymous"
        }
      ]


Get number of learned cards

How can I use this API to get number of learned cards?

You can't, so far the api just supports adding new notes.
There's a low-level API as well, you can see if that does what you want, if not you can make a pull request


why not using python builtin html unescape

[x] I've verified and I assure that I'm running youtube-dl 2016.04.19
[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar - [ ] Bug report (encountered problems with youtube-dl)
[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

moved from https://github.com/rg3/youtube-dl/commit/9e6dd238761e6628d7bd0b6bdb7a997604de3757#commitcomment-17012611.
why the html unescape that came with python http://stackoverflow.com/a/2360639 is not used it can handle two cases that the unescapeHTML can't(' and the ones that start with &#X) and it was improved in the last version(handle HTML5 named character references).

I guess a reason is mentioned in #329:

_unescapeHTML did the same thing as htmlentity_transform but using the undocumented HTMLParser.unescape

it can handle two cases that the unescapeHTML can't(' and the ones that start with &#X)

if the code is the same thing. it whould give the same result.

The problem is undocumented. I guess it's OK as CPython is the de facto standard. Other Python implementations, such as PyPy and Jython, are moving towards using the same set of standard libraries. Ideas from other developers needed, though.

This function is really old. As long as the tests pass (we may need to add some to cover calling it with None and b'123'), feel free to replace its implementation. Note as @yan12125 , we should only use public python interfaces.

If one day youtube-dl supports Python 3.4+ only, we can use it: https://docs.python.org/3/library/html.html#html.unescape. Closing now.
Something not directly related to this topic but also interesting: http://bugs.python.org/issue27032

Since 55b2f099c0c820d6c4b46609b175a44a6d7f97bf and 9631a94fb5e5ee9b92135f938df00866535fc6c6 HTML5 entities are recognized. It works fine for Vporn. Are there other websites using HTML5 entites?


ALOGIT data file must only contain one type

Input data files for ALOGIT must only contain one kind of number data (real or integer).

Upon testing, it seems that mixed integers and reals are accepted, at least when free format is used.


Send message to user by socketID

Hi,
I know it is possible to create a "bob-channel" for achieving what I need, but I have a public channel with ~ 200k users and I can't create 200k private channels for sending data to a specific user only.
Is there any way (I am storing the socket-id inside of redis) to use that ID for sending data from server (it's a welcome message) to that user only? Currently I am using exchange.publish, what other options do I have? Thanks!

If it's a welcome message couldn't you trigger an event when the user subscribes to the channel?

Yeah but the message content is specific (based on several facts). I can see if that user subscribed to the channel, but I tried to do something like this:
scServer.clients[socket.id].emit('foo', mySpecialObject); but there was no way for me to receive that answer. For now, I've ended up "subscribing' (on client) to .subscribe('private_uniqueUserId').watch().
This if working, but I don't know how much overhead this is. Actually, I would love to just listen in my already existing channel "foo".

you can use emit method of SCSocket (Client)/SCSocket (Server), check document here for SCSocket client https://socketcluster.io/#!/docs/api-scsocket-client same for the SCSocket (Server) https://socketcluster.io/#!/docs/api-scsocket-server and find emit Method for example find https://socketcluster.io/#!/docs/handling-failure

@Hirbod Why can't you have 200K private channels?
SC doesn't impose any hard limits on the total number of channels that you can have (or even on the rate of creation of new channels). Also the cost of each channel is negligible.

@jondubois as I don’t know the internals I thought the overhead will be much more.
We ended up creating a hidden private channel to achieve what we want.

Thanks everybody!


Clarification on onRowSelect option

Fixes #163
Clarifies the meaning of the second parameter to onRowsSelect to imply that it is all of the rows selected.

Coverage remained the same at 78.067% when pulling 44de9bfd008e4980993da71dcc1750a4b05c38e5 on brianpmaher:onRowSelected-clarification into 37a82f41f710675d7d382a025fd3fb5215b81d9e on gregnb:master.

Looks good. Thanks for the PR!


garbled year on credit card form?

User reports in private email that they're entering "2015" for the year on the credit card page and are getting an error, 400: Invalid field [expiration_year] - "201517" must be <= 9999.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8915427-garbled-year-on-credit-card-form?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Slight correction (not sure that it matters) on the entered year and the returned year:
I am entering "2017" for year, but it is returning, "400: Invalid field [expiration_year] - "202017" must be <= 9999"

Oooooh. I tried to alter the details to maintain your privacy but I altered them wrong. :-)

I thought that might be the case (that you were maintaining privacy), but I
didn't think it was too risky! Thanks!
On Wed, Feb 25, 2015 at 9:35 AM, Chad Whitacre<EMAIL_ADDRESS>wrote:

Oooooh. I tried to alter the details to maintain your privacy but I
altered them wrong. :-)
—
Reply to this email directly or view it on GitHub
https://github.com/gratipay/gratipay.com/issues/3203#issuecomment-75969508
.

That's an easy one, the form is expecting only the last two digits of the year, and blindly prefixes it with 20, so if you enter the four digits of the year like 2017, we send 202017 to Balanced, which returns an error.

Origin of the bug: 42cd006aae932c9e8e23b35d142c178f013b1566.

So, I was autofilling this form, which explains why, while the form was
only asking for YY, my autofiller was filling in YYYY.
What about asking for YYYY, or, if you want to add "20", forcing only two
digits as entry?
On Wed, Feb 25, 2015 at 10:14 AM, Changaco<EMAIL_ADDRESS>wrote:

Origin of the bug: 42cd006
https://github.com/gratipay/gratipay.com/commit/42cd006aae932c9e8e23b35d142c178f013b1566
.
—
Reply to this email directly or view it on GitHub
https://github.com/gratipay/gratipay.com/issues/3203#issuecomment-75977322
.

I've deployed #3204. Mind trying again, @jdhtwo?

I was able to fix the credit card info manually before you deployed #3204.

Ah, okay. !m @jdhtwo


File Name Save Option?

Is there a way to save the .txt files as a specific format? Such as (name) (date). etc?

On the subject of file naming, it would be really useful if the name of the model used for the transcription was automatically added to the text file name. It would save the need for manual editing afterwards.

Sure, can take a look.


display commit-filepath as edits on frontend

@kayladavis Is this still something that I should do? I'm not sure if it makes sense to rename a data-type on the front end only.

Yes. I think it's still needed. As a dev, I think having the name "commit_filepath" is useful since you don't have to think about what it is in the db. But for the normal reader, it might be confusing, so "edit" makes sense.

Makes sense to me!


#4420: eager EnqueueHostToDeviceTransfer impl

@razorback3

getting failures @arakhmati https://github.com/tenstorrent-metal/tt-metal/actions/runs/7940176867/job/21681122239


[BUG] Footer Link not working

Description
Footer links not working
pls assign me under label gssoc-ext, hacktoberfest-accepted
@mdazfar2
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Firefox, Chrome, Microsoft Edge
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@rupeshv2121 I have been observing for some time. You are raising issues again and again. That's not a good way to work on open source. Why don't you raise and describe everything in a single issue?


undefined is not an object (evaluating 'ViewPropTypes.style')

react-native: 0.39.0
<EMAIL_ADDRESS>

same issuse

same issue with react-native: 0.50 and<EMAIL_ADDRESS>

resolve
It seems that this is a definite bug

same issue with react-native: 0.51 and<EMAIL_ADDRESS>


Build error on OS-X

I've cloned the repository on OS-X 10.9.5 and tried compiling with clang 3.7.0. I get the following error:
/System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h:16:45: error: expected '}' before 'attribute'
I have the '.../atom/build/npm-debug.log' file but I don't see a way to upload it.

Which command did you run to build Atom? Does your system satisfy the listed requirements? You can upload the debug log into a gist and post a link here.

I used the recommended command for OS-X:
script/build
Yes, my system meets the requirements. The version of node.js I'm using is (via MacPorts):
nodejs @0.12.0_0+python27+ssl
Here is the error:
https://gist.github.com/63548782f43fadc84a66.git

I don't think this is an Atom issue, looks like a core library file /System/Library/Frameworks/Foundation.framework/Headers/NSUserNotification.h is corrupt somehow or was misconfigured, closing this out.


Facility displaying strangely: VN2019085T4CW14

Overview
The formatting of this particular facility is displaying strangely. So far, we are not able to find this behavior reproduced beyond this specific facility: https://openapparel.org/facilities/VN2019085T4CW14

cc @katieashaw

@lederer Thinking you may be able to suggest a quick fix for this. The inspector shows our text block extending outdise the bounds of its containing element

Looks like the name and address both contain a number of  's instead of conventional spaces. When I change them to conventional spaces, it wraps as expected.

Thanks for that detective work, Soctt. I see those  's i in the inspector. I think the next step is to determin if the name and address were acutally submitted that way of if they are getting plugged in by our code somehow.

Any connection to issue #1573 ?

@mariel-oar This was resolved with EP. Feel free to close.


0.9.8 - What Happened to the bead BrowserResizeHandler

The bead BrowserResizeHandler was available in 0.9.7, but a recent nightly download shows that it is no longer available in 0.9.8.  Do we need to make other arrangements for knowing when the browser resizes???

It was renamed to BrowserResizeListener.

On Jan 31, 2021, at 4:45 AM, Bilbosax<EMAIL_ADDRESS>wrote:
The bead BrowserResizeHandler was available in 0.9.7, but a recent nightly download shows that it is no longer available in 0.9.8. Do we need to make other arrangements for knowing when the browser resizes???
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/apache/royale-asjs/issues/1071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAVQFBF245PA3NQRY6G33S4S73RANCNFSM4W24VTNQ.

It was renamed to BrowserResizeListener.

On Jan 31, 2021, at 4:45 AM, Bilbosax<EMAIL_ADDRESS>wrote:
The bead BrowserResizeHandler was available in 0.9.7, but a recent nightly download shows that it is no longer available in 0.9.8. Do we need to make other arrangements for knowing when the browser resizes???
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/apache/royale-asjs/issues/1071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAVQFBF245PA3NQRY6G33S4S73RANCNFSM4W24VTNQ.


Junit restdriver tests

JUnit tests against mock server with rest-driver-client
Implement POST /run
command line integration tests

For running JUnit 4 Test with ant-junit see also https://bugzilla.opensuse.org/show_bug.cgi?id=915686

Thanks for your pull request! I will give you some feedback later today after reviewing the code and trying it out.

Ok, here is some feedback after a first review of your proposed changes:
I am willing to try out that library that you are suggesting for the tests, even though I don't really like the fact that it brings in so many (testing) dependencies. Can we maybe omit some of the jars since we only want to use the client part of that library or do we need to have them all around?
Anyways, I have some problems testing your changes:

The "testreports" folder apparently needs to be created manually for the first time (should be created in "init-tests" target instead and removed with "clean").
I get a Building MANIFEST-only jar warning for the "dist-tests" target and the test actually fails for me. Please make sure that ant on the commandline just works. (BTW: thanks for the link to the bug report, I was suffering from it this morning!)
Please fix all the errors that were pointed out in my previous line comments, I wonder how it can work for you. Maybe you forgot to push some commits?

Apart from that here are some general (but important) remarks. Please fix your patch accordingly:

Your indentation settings seem to be messed up: Please never use tabs, indentation should be 4 spaces!
Lines should not be longer than 92 characters, feel free to break lines and indent 8 spaces after a line break.

Apologies for the sloppiness, and thanks for taking the time to review this PR anyway. I hope I have caught all problems now.
Ant build: I don't know what the exact problem was, but changes in the tests only made it into the actual jar after running dist-tests twice. Most of the time. I was obviously confused when to include or exclude main and test subdirectories, so I refactored build.xml to more clearly handle main and test artifacts. I hope it is easier to understand now what's going on.
I did not, however follow this pattern and create lib/main and lib/test instead of lib and testlib -- I didn't want to break the convention of having one top-level lib directory for all run-time dependencies.
I have considered adding a dist-sources-no-tests target as well, without test sources and dependencies, but this would have meant having two build files, or putting a build.xml with non-working targets into the source tarball, so I stopped there -- this is just a rough proposal after all.
Dependencies: I have stripped them down as much as possible. Another alternative might be MockServer, which has a similar API and is (optionally) distributed in one jar file containing all dependencies -- this would then be only one file to track, but it is about twice as large as the libraries I use now.
REST-driver is only distributed in separate jar files through Maven central (and source of course), and dependencies are meant to be handled by Maven.
Also, I haven't looked at all possible HTTP server mocking solutions out there. There might well be something better and more light-weight which I missed. If this is the direction you'd like to take, I could do more research...
(From a textbook perspective I wouldn't even call these tests unit tests, as they test the full implementation from method call to HTTP request, response and back. It was the most interesting aspect to test, though ;-), so I started with that, and being able to automate it with JUnit is helpful whatever the textbooks say.)

Thanks for the fixes, it looks good! I would want to merge some of your changes, but I'm not yet decided what is the best library to use for the tests. May I ask you to make several smaller pull requests (rebased to the current master), so we could merge the other changes right away?
Separate pull requests could be:

The changes to build.xml
The implementation of run()
Tests using your preferred library

Thank you in advance!

Will do, thanks for the feedback!

What I think should be tested is that we are sending out the right requests and that we get results (objects) as expected for given JSON examples according to the salt API documentation. If this is  combined we have rather an integrational roundtrip than a traditional unit test.
BTW: In the past we used http://www.simpleframework.org/ and we really liked it, see https://github.com/susestudio/susestudio-lib-java/pull/10/files.


Bind to Unix socket

I'd like to request the feature to bind to unix sockets.
Technical background for this feature request:

Master Caddy-server handling SSL-certificates running under www-data, connecting to unix sockets as proxies
Per-User Caddy-instances running under the user account with sockets being accessible to www-data:www-data

Following things would be great for bind configuration:

bind <host>

Binds to TCP

bind unix://path : umask

Binds to Unix path with owner being user:group with permission umask. This feature is only available to Unix-like systems as Windows does not allow sockets.
Using Unix sockets should automatically disable all HTTPS-functionality.
As I'm not comfortable with Go I cannot add this functionality by myself.

There are actually 2 main parts here:

Using Caddy as a client. For example, dialing into a Unix socket
Start a Caddy server instance and bind to Unix Domain Socket

Is this what you're looking for? https://caddyserver.com/docs/net

It's not actually the same as Unix Domain Sockets bind with permissions also. But the approach to have a host or server directive is flexible as it will allow binding to different types of connections.

Binding to unix socket is possible with Caddy 2.


Activity list empty after connecting to and unlocking remote lnd node

Description
If you connect to a remote lnd node that is locked, you are prompted to enter the wallet password to unlock the wallet prior to connecting. Once the wallet has been unlocked and you are taken to the wallet screen with the correct balance showing, the correct channel list showing, but an empty activity list.
This is only an issue of the node is locked prior to connecting to it. If the node is already unlocked, the activity list is correctly populated when you connect to it.
Expected Behavior
The activity list should be populated when the wallet first shows.
Actual Behavior
It requires a manual click of the refresh button before the activity list shows correctly.
Possible Fix
Review how/when fetchTransactions etc is called and ensure it is called after unlocking remote wallet.
Steps to Reproduce

Start up remote lnd node but DO NOT unlock it/
Connect to the node using Zap
Unlock the node from Zap
Note that the activity list is blank
Hit the refresh button and note that the activity list is now correctly populated

Context
Connecting to remote lnd node that is locked.
Your Environment

Zap Desktop version: 0.3.2
Operating System and version: Mac, latest

Currently investigating this issue


De-foodify karrot further

Branch deployment: change-defoodify.dev.karrot.world
What does this PR do?
As part of the generalization effort, I found some more references to food to switch to be more general, things like:

the about dialog
the package.json description
the play store description
the hello developer console thing

... also in this the "you've saved x kg of food" has the food bit removed now, could be x kg of anything
Links to related issues
Checklist

[ ] added a test, or explain why one is not needed/possible...
[x] no unrelated changes
[ ] asked someone for a code review
[x] joined chat.foodsaving.world/channel/karrot-dev
[ ] added an entry to CHANGELOG.md (description, pull request link, username(s))
[x] tried out on a mobile device (does everything work as expected on a smaller screen?)

The pictures in the AmountPicker are quite clearly referencing to food, by the way. Though I would assume that the feedback weight option is mostly used for food purposes anyway...


Improve ol.control.Rotate.prototype.resetNorth_ performance

Changing. resetNorth_ function from O(n) to O(1).
To reproduce this issue, open the developer console and execute:
map.getView().setRotation(5000000000);

Then click on the rotation button. Before the commit, it takes a few
seconds, after this commit it is instantaneous.
In addition, due to limited floating point precision, the previous code
calculates a different value from this one.
Note: I've written this pull request directly in the browser, but I tested it locally.

Nice improvement, thanks!


fix: Drop support for Python 3.9

closes https://github.com/ansys/pyfluent/issues/2847, https://github.com/ansys/pyfluent/issues/3169

Drop support for Python 3.9.
Update doc.
Set main Python version to 3.10.

I'm looking to drop support for 3.9 in PySystemCoupling and was wondering exactly how other repos had handled it. I notice here that pyproject.toml hasn't been changed, so as far as I can tell it still allows Python 3.9. Was that an oversight or is there a reason for this? I'd like to be consistent with what others are doing. @hpohekar @seanpearsonuk

I'm looking to drop support for 3.9 in PySystemCoupling and was wondering exactly how other repos had handled it. I notice here that pyproject.toml hasn't been changed, so as far as I can tell it still allows Python 3.9. Was that an oversight or is there a reason for this? I'd like to be consistent with what others are doing. @hpohekar @seanpearsonuk

@iboyd-ansys Yes, we have updated the pyproject.toml now. It should be 3.10. Thank you.


Update Module.txt

Spelling and language corrections

Hi @psenechal, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@psenechal, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


Implement strict-concurrency control and default to "minimal"

Replace -warn-concurrency with a more granular option
-swift-concurrency=, where the developer can select one of three
different "modes":

minimal disables Sendable checking for most cases. (This is the Swift
5.5 and Swift 5.6 behavior, and the default for now)
targeted enables Sendable checking within code that has adopted
Swift concurrency.
complete enables Sendable and other concurrency checking throughout
the module. (This is equivalent to -warn-concurrency now).

Implements rdar://91930849.

@swift-ci please test


(bug) Code copy icon floats over website header

Code copy icon floats over the website header because z-index: 1000 is hardcoded in <copy-button> directive. The fix is to remove .l-layer-5 from .main-nav and add z-index: 1001 to it.

Hi @webmaxru, this unfortunately misses the nav bar in smartphone mode:

#769 resolves this in a more elegant way (in my opinion), as it changes the copy-button’s z-index property only and thus is less invasive.

closed in favor of #769


why prepAscat always get a value 0 for germline-logR ?

Describe the issue
All values from normal-logR are zero, however, the example data from ASCAT dosn't have so much 0 Germline_LogR.txt
Command
Please post your commands and the output (errors or any unexpected output)
maftools::prepAscat(t_counts = "11T.cs.rmdup.sort_nucleotide_counts.tsv",
                    n_counts = "11N.cs.rmdup.sort_nucleotide_counts.tsv",
                    sample_name = "11")

""      chr     pos     logR
1:820888        1       820888  0
1:822463        1       822463  0
1:853460        1       853460  0
1:853464        1       853464  0
1:861659        1       861659  0
1:878665        1       878665  0
1:878767        1       878767  0
1:879229        1       879229  0
1:879231        1       879231  0
1:879314        1       879314  0
1:880083        1       880083  0
1:880193        1       880193  0
1:1477854       1       1477854 0
1:1565717       1       1565717 0
1:1645377       1       1645377 0
1:1645704       1       1645704 0
1:1647600       1       1647600 0
1:1664099       1       1664099 0
1:1688786       1       1688786 0
...

Session info
Run sessionInfo() and post the output below
R version 4.1.3 (2022-03-10)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: CentOS Linux 7 (Core)

Matrix products: default
BLAS/LAPACK: /dellfsqd2/ST_LBI/USER/panxiaoguang/app/miniconda3/envs/biosoft/lib/libopenblasp-r0.3.12.so

locale:
 [1] LC_CTYPE=zh_CN.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=zh_CN.UTF-8        LC_COLLATE=zh_CN.UTF-8
 [5] LC_MONETARY=zh_CN.UTF-8    LC_MESSAGES=zh_CN.UTF-8
 [7] LC_PAPER=zh_CN.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=zh_CN.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] maftools_2.12.05

loaded via a namespace (and not attached):
 [1] compiler_4.1.3     Matrix_1.4-1       DNAcopy_1.68.0     tools_4.1.3
 [5] RColorBrewer_1.1-3 survival_3.4-0     splines_4.1.3      grid_4.1.3
 [9] data.table_1.14.2  lattice_0.20-45

Hello,
Is it possible to share the counts file?

Hello, Is it possible to share the counts file?

of course , you can find the files from the link, link

Thanks. I will have a look later today.

Thanks. I will have a look later today.

Have you received the example file ?

Thanks. I will have a look later today.

oh~ Maybe it's because the data. ps. I use the method from ascat to calculate the logR， it's also o.


TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'

This error originated from a custom integration.
Logger: icloud3
Source: custom_components/icloud3/support/pyicloud_ic3.py:1437
Integration: iCloud3 v3: iDevice Tracker (documentation, issues)
First occurred: 6:36:26 PM (58 occurrences)
Last logged: 6:45:01 PM
unsupported operand type(s) for *: 'NoneType' and 'int'
Traceback (most recent call last):
File "/config/custom_components/icloud3/support/pyicloud_ic3.py", line 1437, in update_device_location_data
rawdata_battery_level = round(_RawData.device_data.get(ICLOUD_BATTERY_LEVEL, 0) * 100)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'

Closing this issue with the release of v3.0


JOSS Paper Submission

📚 Documentation

At SciPy2023, we found that many researchers needed GeoVista. We propose to submit this project to JOSS so that researchers will have no trouble using GeoVista as a reference in the future.
The Journal of Open Source Software is a developer friendly, open access journal for research software packages.
Feel free to :+1: this issue if you want to see this happen (@bjlittle)

[ ] Update the CITATION.cff with the JOSS citation when it lands

@tkoyama010 Yup, this is high on my todo list. Thanks for the reminder :+1:

I'd be keen to be help with this!

Let me know if I can play a supporting role here! I would love to see this submitted to JOSS!


2022.02: migrate to core GoodWe integration

Connection is currently not possible. Might need to upgrade the firmware: https://www.home-assistant.io/integrations/goodwe/

https://gathering.tweakers.net/forum/list_message/68305034#68305034

Fixed this a while back


Tests: improve performance of the sniff tests

Description
The Fixer::generateDiff() method uses shell_exec() with the diff command to generate a file diff.
Using this command is slow, in particular on Windows.
This commit introduces a preliminary check in the test logic to see if a diff is even needed and skips generating the diff if no differences are expected.
I don't know whether and if so, how much this will make a difference for *nix users, but on Windows, it makes a significant difference when running the sniff tests.
A run of just the sniff tests (vendor/bin/phpunit tests/AllTests.php --filter Standards --no-coverage) for PHPCS without this fix takes > 1 minute (~01.03.701 last time I ran it).
With this fix, the run time of the sniff tests is brought down to ~8 seconds.
So let's call this a quality of life improvement for all devs which regularly need to run sniff tests for either PHPCS itself or for external standards which base their test suite on the PHPCS native test framework.
👉🏻 Request for testing:
Based on the test runs in CI, this change should make no significant different on *nix systems, but I'd love to have some people test it and post their with and without timing results.
Suggested changelog entry
Performance improvements for the sniff tests. Should be most notable for Windows users.

Based on the test runs in CI, this change should make no significant different on *nix systems, but I'd love to have some people test it and post their with and without timing results.

I tested this on my Ubuntu machine using the command vendor/bin/phpunit tests/AllTests.php --filter Standards --no-coverage, and I saw a small improvement. I did only a few runs on the main branch and on this branch. On the main branch, it takes around 5.4 seconds for the command to finish. On this branch, it takes around 4.7 seconds.

Rebased without changes. Merging once the build passes.


[W5][W14-2] Tay Zhan Peng

Added a quickhelp command.

Good job on the simplified help command. May be able to work on more advanced enhancements in the future.


OCPBUGS-8993: Sync 2023 08 24

/lgtm

/hold

Please coordinate with @stevekuznetsov xref #547

/close

Closing in favor of https://github.com/openshift/operator-framework-olm/pull/547. OCPBUGS-8993 isn't required for 4.14.


Add completion command

This commit introduces the ability to pack command to create an autocomplete script with all the commands from pack

Acceptance tests are fixed on master now. Travis will likely pass if you rebase.

@ekcasey was there anything stopping this PR from being merged?

@joaopapereira after running the specified command I get a signal: broken pipe
Output:
┌─[javier.romero][Javiers-MacBook-Pro][±][add-autocompletion {2} ?:2 ✗][~/dev/pack]
└─▪ . <(go run cmd/pack/main.go completion)
┌─[javier.romero][Javiers-MacBook-Pro][±][add-autocompletion {2} ?:2 ✗][~/dev/pack]
└─▪ signal: broken pipe

In case it matters:
└─▪ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)
Copyright (C) 2007 Free Software Foundation, Inc.


Tag pane resizes when typing in command box

The command is not yet executed, enter is not pressed, just typing stuff in the command box causes the tags pane increase its height.

I don't have this issue. Could it be due to your changes to the reminder UI?

The is a real problem. Not only the tags pane resize unexpectedly, the other panes in the sidebar resizes


Reconcile relays with balance ledgers occasionally

Currently there are two ledgers in the postgres database, PaymentLedger and RelayLedger. Payment ledger is CREDITed when a user burns ERC-20 via event watcher, this increases the balance on the account. As relays are used the RelayLedger is CREDITed to indicate usage (also refers to app and chain (endpoint) for reference. We need a process that occasionally (daily, weekly, etc) DEBITs both ledgers with the corresponding tx to balance them. Basically a DEBIT to the PaymentLedger will show up on the accounting page as ledgers used. The DEBIT on the relay ledger will indicate that those relays have been accounted for.
I'm not sure where is the best place for this process to live as it is a sort of admin function that we don't have in our stack currently. It should be as simple as a SQL query, so perhaps we program it into the backend and have an external process call it on whatever cadence we wish. Thoughts?

I'm thinking a good place for this until we find something better will be a backend endpoint (we'll want some authorization).


Improving documentation

Include all parameters in documentation
Input file description
Better usage description
Short description about RNAseq experimental design

Usage.md will be finished in Pull Request #31

I'll be working on Output.md

solved by PR #46


diagnostics page region error when issue on miner container

If miner container doesnt load, we get this printed to diagnostics page for region:
<_InactiveRpcError of RPC that terminated with: status = StatusCode.UNAVAILABLE details = "DNS resolution failed for helium-miner:4467: C-ares status is not ARES_SUCCESS qtype=A name=helium-miner is_balancer=0: DNS server returned answer with no data" debug_error_string = "UNKNOWN:DNS resolution failed for helium-miner:4467: C-ares status is not ARES_SUCCESS qtype=A name=helium-miner is_balancer=0: DNS server returned answer with no data {created_time:"2023-04-12T19:37:39.622545593+00:00", grpc_status:14}" >

We should instead catch this error and throw an error message...

possibly related to #521


The layout of FlowLayout & Chips has some problem.

As shown below:

You seem to be using RTL layouts. Am I right?
What version of Android are you using?

I didn't modify any code.The version of Android is 5.1.1.

fixed


frr: 9.1 -> 10.0

Description of changes
Release notes: https://github.com/FRRouting/frr/releases/tag/frr-10.0
Breaking changes:

per-daemon config files no longer supported -> only when writing, not possible with configs in read-only store paths
noprefixroute flag for interface prefixes with NetworkManager -> routes with noprefixroute set no longer inserted into advertised set, should be no real issue
-n is required for mgmtd -> currently netns-based VRFs are not supported in the module. I'd ignore this until someone needs it explicitely.
Enable enforce-first-as by default for BGP -> likely breaks Route Reflector/Route Server Setups -> mention in release notes?
Deprecate ConfD -> confd is deprecated by its developing company tail-f

Currently WIP, opened for possible discussion.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The "breaking changes" have to be understood. https://github.com/NixOS/nixpkgs/pull/274425 has to be reviewed/merged.

@woffs What's your opinion regarding the breaking changes list?

Probably need some movement on this because of
CVE-2024-31948
CVE-2024-31949
CVE-2024-31950
CVE-2024-31951

Actually I notice the respective PRs for two of those CVEs haven't even been merged yet..

@woffs What's your opinion regarding the breaking changes list?

per-daemon conf has to be replaced by unified config. this has to be reworked in the module, but seems to simplify things.

@woffs What's your opinion regarding the breaking changes list?

per-daemon conf has to be replaced by unified config. this has to be reworked in the module, but seems to simplify things.

FRR 10.0 also works fine with per-daemon config files in the NixOS setting. It is just not able to write them back to disk after changes in vtysh (which is nevertheless not possible on NixOS due to read-only config out of the store). I'd not change anything in the module for 10.0. Unifying the config to a single frr.conf will at least break user configs with the same route-map of prefix list names in different per-daemon config.
Let's justs state multiple config files as deprecated and unify them in the future otherwise it IMHO breaks config without necessity.

Seems OK to me, but needs a release note if enforce-first-as is now the default for BGP. The note can then refer to the upstream changelog for other breaking changes, stating they do not impact users of the NixOS module (?)

Done

@thillux What's the plan to address the security issues in 23.11?

The plan is to address the security issues in 23.11 and unstable/24.05 when they have landed upstream. See e.g. https://github.com/FRRouting/frr/pull/15674 which is an unmerged fix for CVE-2024-31951


Misaligned status register read fails on FreeBSD

There’s some code in processDVSec which tries to read 32 bits from byte offset 6 in configuration space. This presumably works on Linux, but the FreeBSD PCI driver rejects this. The following patch fixes this.
diff --git a/src/pci.h b/src/pci.h
index ec44e99..d7c0326 100644
--- a/src/pci.h
+++ b/src/pci.h
@@ -261,8 +261,8 @@ void processDVSEC(MatchFunc matchFunc, ProcessFunc processF>
         // std::cerr << "Intel device scan. found " << std::hex << group << ":>
         uint32 status{0};
         PciHandleType h(group, bus, device, function);
-        h.read32(6, &status); // read status
-        if (status & 0x10) // has capability list
+        h.read32(4, &status); // read status
+        if (status & 0x100000) // has capability list
         {
             // std::cerr << "Intel device scan. found "<< std::hex << group <<>
             VSEC header;

The current source base is also missing some minor tweaks necessary to build on FreeBSD (mostly the cpu_set_t / cpuset_t definition), but those are trivial.

thank you for reporting the issue with the alignment. As you noted these work on Linux. Will fix asap as recommended to make it work on FreeBSD.
With regards to the cpu_set_t: could you please suggest a change? For some reason our FreeBSD builds are not failing due to this: https://github.com/intel/pcm/actions/workflows/freebsd_build.yml


Webpack 5 issues with missing 'path' module.

I have installed twig.js via npm. The first file I try to import it on produces the following error:
ERROR in ./node_modules/twig/twig.js 435:17-32

Module not found: Error: Can't resolve 'path' in 'C:\Users\****SENSITIVE INFORMATION OMMITTED****\node_modules\twig'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.

This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
        - install 'path-browserify'
        -
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "path": false }

I installed path-browserify, but it did not fix anything.

Alright, I should have waited about 5 minutes before posting this. I have resolved the issue!
I added this to my webpack config file:
	resolve: {
		alias: {
			path: require.resolve('path-browserify'),
		},
	},


bug the responsive login form

can I solve this bug I will make it responsive and solve it on this screen and I will make a scroll bar at the same color of the background?

I am a GSSOC participant, please assign me this issue. @harshita2216?

@MennaMagdy2019 this page has 2 signup forms, we only need one. Please fix that as well.

@MennaMagdy2019 I am sorry but we already have this issue assigned to someone.


Overview figure

We could prepare a overview figure of the workflow and refer to the specific sections.

Great idea!

Also, a timetable as you had in your lab talk, summarising the functionality in MSnbase, pRoloc and pRolocGUI.

Maybe a simplified version of something like this?

Nice!

Could you add a file to Data export, like the one at the beginning.
Will look at the figure when reading the paper again, and see how well the figure guides the reader.

We need to see if this fits in somewhere. It would be nice to include it.


Deps vs DevDeps

Now that Next.js has moved to a universal webpack solution, are we forced to put our JS compilation (eg: @zeit/next-typescript) as a dependency instead of devDependency?
The next-typescript package installation section would indicate yes:
yarn add @zeit/next-typescript typescript

Is this correct thinking, or is the above a typo (missing -D) and not required as a dep?

It's needed when building the app. In theory you'd only need typescript / next-typescript when building the app.
In the next canary release (not out yet) you'll be able to use this:
https://github.com/zeit/next.js#custom-configuration
A config function to conditionally load modules per phase, this way you can distinguish between build / development / production / export.
I'm not planning to update this section of the readme since the provided way is required for eg now.sh deployments.


[Similarity search] Add documentation guides (or maybe a mini tutorial for data deduplication)

Thanks, I will take a look at this next week.

@davidberenstein1957 I'll take this one and request advice and reviews from you

Also, provide text for the helper button within the UI

Helper modal:
Max 600 caracteres, title included

@leiyre this is the text to be included in the helper modal:
Similarity search
Since 1.2.0 Argilla supports adding vectors to Argilla records which can then be used for finding the most similar records to a given one.
This feature uses vector or semantic search combined with more traditional search (keyword and filter based). Vector search leverages machine learning to capture rich semantic features by embedding items (text, video, images, etc.) into a vector space, which can be then used to find "semantically" similar items.
To benefit from this feature, your data team must include vectors associated with each record when they create the dataset.
To learn more about this feature you can visit the documentation page

Pending thing to close this issue:

[ ] @leiyre and @Amelie-V send some screenshots to @dvsrepo to add them to the reference for Argilla UI once we have something. You can use the datasets from dev

@leiyre Please remove the last sentence from the help. "To learn more about this feature you can visit the documentation page"
We already have the CTA linked to the doc and the destination is the same.

@Amelie-V if you can send me one or two screenshots I can include them in the docs and close the first version of the full doc changes. It can be a general screenshot to at least show the overall feat or several screenshots with a user flow

@frascuchon let's leave this one as the main doc issue. As mentioned before, I won't do more work on the docs


Documentation: minor typo in the Window guide

The last paragraph in the "Full screen windows" section states as follows:

By default, the original video mode of the monitor will be restored and the window iconified if it loses input focus, to allow the user to switch back to the desktop. This behavior can be disabled with the GLFW_AUTO_ICONIFY window hint, for example if you wish to simultaneously cover multiple windows with full screen windows.

I believe last words were meant to be written as

cover multiple monitors with full screen windows.

instead of

cover multiple windows with full screen windows.

Cheers, and thanks for all your work! You are doing great things here.

Well spotted, thank you! This should be fixed now with 66c0394ae19c24483a5228eeaa179945206768ab.


Wrong selection coordinates in bar chart

Description
Apparently for bar charts the selection coordinates received by selection event handler are off. I was able to calculate proper coordinates by taking into account w.globals.barPadForNumericAxis when determining the selection offset (see linked codepen).
I noticed no such problem with line charts, the selection coordinates match the visuals there.

Steps to Reproduce

Visit https://codepen.io/xemlock/pen/MWvJKdj
Use selection tool to select range
Observe incorrect selection coordinates received by selection event handler

Expected Behavior
The selection coordinates received by selection event handler match what was selected on the plot
Actual Behavior
The selection coordinates received by selection event handler don't match what was selected on the plot
Screenshots

Reproduction Link
https://codepen.io/xemlock/pen/MWvJKdj

same issue +1
When the mouse leave the charts,
The minimum value is replaced with the value at the time of the first mouse click, and the maximum value is replaced with the value where the mouse leave.
Is there a solution to the problem?

Similar or same issue with the line chart. However, I notice that if you click within the chart area after making a selection, the min/max values are not replaced when the cursor is moved out.

Due to the Firefox selection issue #1981 I've had to drop using the selection event. Not sure if it will help anyone, but I am now using the dataPointSelection event - when I get two points, I create a block annotation which gives me the same effect I am after.  If I get more than two points, I discard the first points, clear the block annotation and start again.

Looks that the bug only appears until the next user click event to the chart.
If once selection is done you click anywhere inside the chart (including resizing the selection), you can  leave the chart without being affected by this issue.
My findings:
Once the selection is done, a click event is raised so maybe there is a race problem with this event., Maybe it is called too early so the detection feature does not know that the user selection is already done (unless you click again).
My workarround is to store the selection value but only use it when the click event is raised. By using this method, the last "change" when you leave is ignored. I am using angular and this is my code:
events: {
        selection: (chartContext, {xaxis, yaxis}) => {
          // Store the value but not use it yet
          chartContext.lastSelection = xaxis
        },
        click: function(event, chartContext, config) {
          if(chartContext.lastSelection != null) {
            // Use the value here
            // mySuperFunction(chartContext.lastSelection)
            console.log(chartContext.lastSelection)
            chartContext.lastSelection = null
          }
        }
      },

I will take a look on the code in order to find the problem and send you a pull request with a fix


Fix incorrect code generated for statics

Summary or solution description
The code generator was generating different static slots for the same static variable that is used in different files due to failing to get the internal unique id of this variable.

Task linked: CU-861mucfzd incorrect code generated for statics


Proposal of a work-around for ES2015 issue with class property declaring

When using Backbone/Exoskeleton from ES2015 one faces an issue with assigning class properties. ES2015 doesn't allow to set class properties declarative way (http://wiki.ecmascript.org/doku.php?id=strawman:maximally_minimal_classes). Well, we have to use constructor. However,  in a constructor of ES2015 class this context isn't available until calling  super (http://www.ecma-international.org/ecma-262/6.0/#sec-function-environment-records-getthisbinding), (http://www.ecma-international.org/ecma-262/6.0/#sec-ecmascript-function-objects-construct-argumentslist-newtarget). Some of properties in Backbone (like this.events, this.defaults) can be without constructor by using functions ( events(){ return {..} } ). But properties like this.idAttribute  we have to set like this:
class FooModel extends Backbone.Model {
 constructor( attrs, options ){
   super( attrs, options );
   this.idAttribute = "email";
 }
}

The problem here that super invokes Backbone.Model constructor and it happens before we set this.idAttribute. So we won't have this value in this.id because the constructor isn't even aware of our intend.
I propose a work-around - simple and straightforward. Constructors of View/Model/Collection/Router call properties function of it's available in the context. Developer uses this function to set Backbone class properties:
class FooModel extends Backbone.Model {
 properties(){
   this.idAttribute = "email";
   this.localStorage = new Backbone.LocalStorage( "app" );
 }
}

This is currently being discussed at jashkenas/backbone#3560. Feel free to weigh in there (your properties method is similar to Justin's preInitialize method). We should try to ensure that both projects arrive at the same solution so we don't have compatibility issues.

Sorry, I didn't find that discussion. Thanks for the reference.


core-fellowship: promote dev-dependencies to regular dependencies

These pallets are not just required for tests, but also for the runtime-benchmarks feature.
CI is currently failing on master due to this.

bot merge cancel

This is wrong.
The proper solution is this: paritytech/releng-scripts#37

In this particular case, an optional regular dependency actually seems more accurate to me than a dev-dependency -- as far as I can see, those pallets aren't required by the tests, just by the runtime benchmarks.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2563447

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2563448

@altaua did you used rebase merging?

Master branch:

How can this happen, since it is not enabled in this repo?

How can this happen, since it is not enabled in this repo?

I disabled it afterwards :P

How can this happen, since it is not enabled in this repo?

I disabled it afterwards :P

Okay :+1:
Does that also reject merge commits from the CLI? Or is this setting only for the Website?

I have no idea :P


Timesheet - 05/05/2021 - Justin Kim

Task 1
Meeting with Bucky Kristy and Muhammad about Development Process
Proof of Work

https://docs.google.com/document/d/1mZBvBEwynj-78A_8xHmebIkaU6e76ynwh1wpMUWYJdE/edit

Time Spent
2 hours

Task 2

Work on Projects PR
review our current situation of Projects, and notice that no projects have been approved. Send a message to auditing channel

Proof of Work

https://github.com/thenewboston-developers/Website/pull/1753
Audit Channel

Time Spent
1.5 hours

Total Time Spent
3.5 Hours
Account Number
67077b2397f99fb6c63185af25cdf49d43736b22b7ea5dd68089a04cd4dbf8cf

Approved


BUG: the .ipynb in the scripts directory throws two exceptions

When running skedm_examples.ipynb, everything ran fine except for two AttributeErrors, which were thrown because of misnamed functions:

In 2D section: X = data.chaos2D(sz=256) throws AttributeError (module skedm.data has no attribute chaos2D) -- should be chaos_2d and not chaos2D
Attribute error: module 'skedm.data' has no attribute 'voronoiMatrix' (should be voronoi_matrix).

Thanks John. These are resolved in the following commit:
https://github.com/nickc1/skedm/commit/b063c5c81ab48bba179991cccc933f10ef8695bf


Support more Aura products

It'd be good to handle the following:

[ ] GPUs
[ ] Non-addressable RGB LED strips
[ ] Keyboards
[ ] Mice

As I understand it the protocol is completely different, annoyingly.
For example my motherboard (Z370-I) doesn't use i2c, its USB, so is not supported either.
Its really annoying how not only have each motherboard vendor done this completely differently from each other, but they aren't even consistent between their own hardware.

Hi,
Unfortunately, I haven't had much time to work on Borealis, so things have stagnated. You might have better luck with CalcProgrammer1's OpenAuraSDK, which has seen more active development.


Not working in Release mode but working in Debug Mode

When I run in the android emulator in debug mode it works completely fine. As I run or build with release mode it just pops as a notification and no incoming call UI is seen.

incomming call only shows when on lock screen or off screen (android)

incomming call only shows when on lock screen or off screen (android)

Hey Thanks for the Package and reply but the issue is solved using @pragma('vm:entry-point') on BackgroundMessageHandler function.


Live

Docs Build status updates of commit f9e3790:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Test PR


feat(http-client-csharp): bump to tcgc 0.47.4

upgrade tcgc to 0.47.4
upgrade cadl-ranch to latest version

resolve #4938

double confirmed that tcgc 0.47.4 fixes duplicated nullable types and union types.

API change check
API changes are not detected in this pull request.

This PR is blocked by problematic typespec definition of Language.Conversation service. I've notified the service team to fix the problem

PR to fix the spec: https://github.com/Azure/azure-rest-api-specs/pull/31416


TODO

[ ] Rename puke to something "nicer".
[ ] Move the package manager to its own repository.
[ ] Allow multiple repositories to be used.

[ ] Have a variable similar to $PATH.

[ ] Proper dependency resolver.

The goal is to avoid things like circular dependency in the packages themselves.

[ ] Allow multiple packages to be interfaced with at once.
[ ] Add a contrib repository for smaller example scripts to interface with the repository.

Moved to https://github.com/kissx/kiss


[Bug] suggest COORDINATOR_QUOTA_DEFAULT_APP_NUM turned off by default

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
coordinator start with default value same application will Fail to access cluster.
I suggest to turn off this quota by default
[2023-08-29 14:34:08.267] [WARN] [main] [org.apache.spark.shuffle.DelegationRssShuffleManager] >>> Fail to access cluster Coordinator grpc client ref to xxx:29999 using etl_spark for Request to access cluster Coordinator grpc client ref to xxx:29999 is denied using etl_spark for Denied by AccessQuotaChecker => User: u_dw, current app num is: 6, default app num is: 5. We will reject this app[uuid=897411780-5229].
[2023-08-29 14:34:08.277] [WARN] [main] [org.apache.spark.shuffle.DelegationRssShuffleManager] >>> Fail to access cluster Coordinator grpc client ref to xxxx:29999 using etl_spark for Request to access cluster Coordinator grpc client ref to xxxx:29999 is denied using etl_spark for Denied by AccessQuotaChecker => User: user1, current app num is: 7, default app num is: 5. We will
.....
[2023-08-29 14:34:31.736] [WARN] [main] [org.apache.spark.deploy.yarn.Client] >>> Application report for application_1693203805432_17544 (state: ACCEPTED)
[2023-08-29 14:34:32.737] [WARN] [main] [org.apache.spark.deploy.yarn.Client] >>> Application report for application_1693203805432_17544 (state: ACCEPTED)
[2023-08-29 14:34:33.738] [WARN] [main] [org.apache.spark.deploy.yarn.Client] >>> Application report for application_1693203805432_17544 (state: ACCEPTED)
[2023-08-29 14:34:34.740] [WARN] [main] [org.apache.spark.deploy.yarn.Client] >>> Application report for application_1693203805432_17544 (state: RUNNING)
[2023-08-29 14:34:34.740] [WARN] [main] [org.apache.spark.deploy.yarn.Client] >>>
client token: Token { kind: YARN_CLIENT_TOKEN, service: }
diagnostics: N/A
ApplicationMaster RPC port: -1
final status: UNDEFINED
tracking URL: http://xxx:8042/proxy/application_1693203805432_17544/
user: u_dw
[2023-08-29 14:34:35.567] [ERROR] [main] [org.apache.spark.SparkContext] >>> Error initializing SparkContext.
org.apache.spark.SparkException: Dynamic allocation of executors requires the external shuffle service. You may enable this through spark.shuffle.service.enabled.

Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[x] Yes I am willing to submit a PR!

@smallzhongfeng WDYT? I'm ok.

@smallzhongfeng WDYT? I'm ok.

Of course no problem, or we can make the default value bigger? @xumanbu

@smallzhongfeng WDYT? I'm ok.

Of course no problem, or we can make the default value bigger? @xumanbu

make a larger value as the default is ok. other way, we can set the default value as -1 to indicate no quota check.

It's ok for me to set the default value as -1. Could you raise a pr for this issue?

make a larger value as the default is ok. other way, we can set the default value as -1 to indicate no quota check.

+1 for this change!

@smallzhongfeng WDYT? I'm ok.

Of course no problem, or we can make the default value bigger? @xumanbu

make a larger value as the default is ok. other way, we can set the default value as -1 to indicate no quota check.

It's ok for me to set the default value as -1. Could you raise a pr for this issue?

ok


Multiple issues in the new GraphQL transformer migration process.

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14.17.5
Amplify CLI Version
7.6.2
What operating system are you using?
Windows 10 / Ubuntu 20.04 WSL
Amplify Categories
api
Amplify Commands
push
Describe the bug
So I'm working on migrating to the new GraphQL transformer and I've been hitting a series of issues. I've run amplify migrate api and made the recommended changes after running amplify api gql-compile until the schema compiles.
When running amplify push I was first hit with a new issue surrounding the maximum number of IAM policies per role. This was not the case before the migration to the new transformer version. I requested an increase for IAM Managed Policies per Role from 10 to 20 and it was approved within a couple of minutes. I ran amplify push again to see another error...
The next error I hit was surrounding Only one resolver is allowed per field. Reading through GitHub issues, someone mentioned trying to run amplify push again. That resolved that issue, onto the next...
Data source with name NONE_DS is now preventing amplify push from succeeding. I'm going to try and delete the NONE_DS data source in the AppSync console and see if that unblocks me.
In short, there are multiple issues with the migration process that need some attention. None of these issues happened before the migration. amplify api gql-compile succeeds so if there transpires to be issues with the schema, then the compilation logic should probably be improved to prevent these issues from occuring.
🤞🏼 that deleting the NONE_DS data source will unblock me.
Expected behavior
As above.
Reproduction steps

As above.

GraphQL schema(s)
No response
Log output

# Put your logs below this line

Additional information
No response

Update:
I cannot delete the NONE_DS data source as Error: Data source is still in use by functions..

So I've managed to get past this issue by going to the 9 individual AppSync functions that were still using the NONE_DS data source and changing the data source to a different NONE type data source.
It has failed again with a different error... This time nothing verbose is displayed in the Cloudformation logs so waiting for Cloudformation to finish now to see . 🤦🏼♂ It's been stuck on functionAdminQueries for some time now....

So it took a while but finally completed the rollback. I haven't got a specific error to go by now. All I've got is:
The following resource(s) failed to update: [ResourceTheme, EmailTranslation, ResourceTag,.......]

@Straubulous @marcvberg @sundersc - any idea on what's causing these issues? We can't make use of the new features/improvements in v2 until we can get these resolved. Thanks in advance!

Hi @kylekirkby,
I'm getting into this today, to replicate this could you describe which directives/features you were using with your API with the V1 transformer? I'm going to try to put together a V1 schema that replicates your issues above

We've used field-level auth rules, field-level function resolvers, custom mutations, many-to-many connection tables, multiple auth rules, custom @key's etc. Let me know if you need more details.

I'll look into this - in the meantime, have you reviewed the migration guide? The overall announcement is here: https://docs.amplify.aws/cli/migration/transformer-migration/
and referenced within this page are the things that require manual migration: https://docs.amplify.aws/cli/migration/transformer-migration/#what-are-the-breaking-changes-and-how-do-i-migrate
Custom mutations come into the custom resolvers category, so if you're relying on amplify migrate api to complete the migration and have your resources ready it won't be able to get everything

@marcvberg - thanks... but I've already read the migration guide and migrated my schema.graphql file accordingly prior to creating this ticket.

I've recently checked out my main environment and now upon trying to checkout my develop env I'm getting an error. This hasn't happened on the previous CLI version.
amplify env checkout develop
⠼ Initializing your environment: develop
Could not initialize 'develop': undefined

I was about to send over my amplify folder.. any ideas?

It looks like my environment is changing since when I run amplify status it shows the environment I've just checked out. However, all resources are showing "Create" instead of "No change" etc.

@marcvberg - I'm now in a fully blocked state.
An error occurred during the push operation: null

I cannot push any changes or checkout different environments.

There's currently an AWS outage causing many amplify commands (among other things) to fail

Hello @marcvberg, I added a custom query for a type, and updated customResources.json file, push is not working. I am continuously getting only one resolver is allowed per field ( still after 3 retries, as suggested in many comments), so I decided to migrate to v2.
I renamed my each resolver which was under /api/<name/resolvers/ from .req|res.vtl to .postAuth.1.req|res.vtl, this is  what I need to do right? Do I need to do the same with pipeline resolvers?  does pipeline resolver also requires slot value{init, preAuth, auth, postAuth, preDataLoad}?
one more thing I want to clarify, do I need to also update CustomResources.json under /api/stack/ for both cases?

Hi @hackrx ,
Could you please create a separate issue for your issue?
Thanks,
Kyle

Hi @kylekirkby - Can you try to pull the project to a new folder and email us the amplify folder to<EMAIL_ADDRESS>

Hi @marcvberg
We are having same issue, after using "amplify Migrate api"  the schema.graphql gets migrated to V2  But upon using amplify push we to get the same error. Data source with name NONE_DS already exists
"CREATE_FAILED      GraphQLAPINONEDS95A13CF0            AWS::AppSync::DataSource    Tue Dec 14 2021 08:51:02 GMT+0000 (Coordinated Universal Time) Data source with name NONE_DS already exists (Service: AWSAppSync;
Status Code: 400; Error Code: BadRequestException; Request ID: 8228de85-74c3-49bb-bf88-1be495278f96; Proxy: null)"
We do not have any custom resolvers.
Do we have any solution for this issue.
Regards,
Prafulla

Hi @prafullatandel - Can you post your schema so that we can try to reproduce it on our end? Also, let us know the cli version.

I get the same issue which seems to be due to having DataStore enabled

Have the same issue after changing schema to v2, amplify push isn't working

@frankclaassen @skorobahatko - Could you share the graphql schema?

Doubt it will help you if I send my amplify folder as I have managed to get past this issue mostly, just stuck with an error now which I will post further down. To overcome most issues, I had to update auth first and push, then go onto the appsync console to manually update all resources pointing to NONE_DS, delete NONE_DS datasource, run api migrate and push.
Now I am getting the below error with the migrated schema:
✖ An error occurred when pushing the resources to the cloud
🛑 ["Index: 0 State: {"deploy":"waitingForDeployment"} Message: Resource is not in the state stackUpdateComplete"]
DeploymentError: ["Index: 0 State: {"deploy":"waitingForDeployment"} Message: Resource is not in the state stackUpdateComplete"]
at /usr/local/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/iterative-deployment/deployment-manager.ts:159:40
at Interpreter.update (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/interpreter.js:265:9)
at /usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/interpreter.js:110:15
at Scheduler.process (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/scheduler.js:69:7)
at Scheduler.flushEvents (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/scheduler.js:60:12)
at Scheduler.schedule (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/scheduler.js:49:10)
at Interpreter.send (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/interpreter.js:104:23)
at actor.id (/usr/local/lib/node_modules/@aws-amplify/cli/node_modules/xstate/lib/interpreter.js:1010:15)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:93:5)

The above is on the latest version of the cli

@frankclaassen The error 'Resource is not in the state stackUpdateComplete' usually pops when there is an ongoing update on your stack. Can you check the status of your application stack in cloudformation (aws console) and make sure it is 'UPDATE_COMPLETE'? Then try amplify pull, make the necessary updates and do amplify push.

Hi all,
So we are back to trying to migrate to the new version of the GraphQL transformer. I'm still hitting the issue regarding:
Data source with name NONE_DS already exists

I'm on version 7.6.12 of the CLI.
Any help would be appreciated since we need to migrate now to use new authorization features that exist in the latest version.
Thanks in advance,
Kyle

Update:
I thought I was on to a workaround using the CDK overrides for the AppSync API to change the name of the NONE_DS DataSource to e.g NEW_DONE_DS.
However, according to the Amplify docs, this should be possible by doing something like:
import { AmplifyApiGraphQlResourceStackTemplate } from '@aws-amplify/cli-extensibility-helper';

export function override(resources: AmplifyApiGraphQlResourceStackTemplate) {
	resources.api.GraphQLAPINONEDS.addPropertyOverride('Properties.Name', 'NEW_DONE_DS');
}

But even after deleting my build/ folder for my API and generating an entirely new build with amplify api gql-compile my NONE DataSource is named: GraphQLAPINONEDS95A13CF3. Thus resulting in a typescript error and yet another failed stack deployment.

@kylekirkby - Could you include the graphql schema in the issue template?

@sundersc - Just to confirm, I emailed this over last night.

Discussed offline. Here are the steps followed to resolve the issue.

Update the schema to V1 schema and do amplify push, wait for it to complete.
Go to AppSync console and open the api. For all the functions using NONE_DS datasource, manually change it to NONE.
Delete the NONE_DS datasource.
Update the schema to v2 and push again.

Closing this issue now. Feel free to reopen if you encounter the same issue again.

Discussed offline. Here are the steps followed to resolve the issue.

Update the schema to V1 schema and do amplify push, wait for it to complete.
Go to AppSync console and open the api. For all the functions using NONE_DS datasource, manually change it to NONE.
Delete the NONE_DS datasource.
Update the schema to v2 and push again.

Closing this issue now. Feel free to reopen if you encounter the same issue again.

is there an update to the AppSync AWS Console? there is no NONE option.


Warn: Cannot read property 'toCommandArgument' of undefined

Environment data
VS Code version:  1.19.3
Python Extension version:  2018.1.0
Python Version:   3.6.4
OS and version:    macOS High Sierra 10.13.3
Actual behavior
Warn: Cannot read property 'toCommandArgument' of undefined
For some time now I have had a key binding within VS Code that runs the python script I am working on in the terminal.
This has so far been working without issues, until today when I start getting the following error:
Warn: Cannot read property 'toCommandArgument' of undefined
And it is my pythonPath:
"python.pythonPath": "/Users/ryze/anaconda3/envs/tensorflow/bin"
Expected  behavior
Steps to reproduce:

Logs
Output from Python output panel

Output from Console window (Help->Developer Tools menu)

Duplicate of #689


Update Sphinx version to 5.0.0

Fixes #8
Update Sphinx version in pyproject.toml to resolve github-pages deployment failure.

Change Sphinx version from "^4.2.0" to "^5.0.0" in the [tool.poetry.group.dev.dependencies] section of pyproject.toml.

For more details, open the Copilot Workspace session.

Update Sphinx version in pyproject.toml

Change Sphinx version in [tool.poetry.group.dev.dependencies] section to ">7.2.0" from "^5.0.0"

Update Sphinx version in pyproject.toml

Change Sphinx version requirement to ">=4.2.0" in the [tool.poetry.group.dev.dependencies] section


fix: main test single delegate

tx commands require --chain-id. This really shouldn't be required for --generate-only since the --chain-id is only used during signing, but fixes the issue.
Also updates CI so that test and build jobs only run once per branch push for PRs.

I cherry-picked 9d6a317 into main. Let's deal with the CI bits separately.