[BEAM-7499] unskip ReifyTest.test_window

Unskip to test if ReifyTest.test_window works as intended.
This is related to BEAM-7499

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

The test ReifyTest.test_window passes in the python pre-commit.

Run Portable_Python PreCommit

R: @pabloem @lukecwik

Run Portable_Python PreCommit

All tests passed :champagne:
@lukecwik PTAL

@lukecwik ping : )

nevermind. this lgtm.


Support unix socket

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No
Describe the solution you'd like
A clear and concise description of what you want to happen.
Support unix socket
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
use localhost loopback
Additional context
Add any other context or screenshots about the feature request here.
can be a bit faster without tcp overhead, not strictly necessary but nice to have.

Hello,
so what you're requesting is that you have something serving traffic on unix socket and we simply forward traffic to it, so you don't need to start any other proxy between loophole and your unix socket? Do I understand that correctly?


directconnect: MACsec associate/disassociate + LAG create/describe

Additional features for Direct Connect

LAG create (aws directconnect create-lag)
LAGs describe (aws directconnect describe-lags)
MACsec associate (aws directconnect associate-mac-sec-key)
MACsec disassociate (aws directconnect disassociate-mac-sec-key)

Corrected minor variable typo (connnection_id vs connection_id)
Tests added to cover new functionality
Linter checks passed locally
Tests passed locally

Notes

Scaffolding tool (scripts/scaffold.py) was used to generate code stubs
MACsec associate/disassociate works for both "normal" connections and LAGs.

Fixed (hopefully) python 3.8 lint issue.  The change works fine with 3.11 (don't have 3.8 readily available)

Checks seem to be ephemeral failures and also unrelated to the changes.

Merged main in yesterday.  Github workflows haven't ran yet...

Merged main in yesterday. Github workflows haven't ran yet...

Hi @ptgeorge, the workflow has to be approved by a maintainer for new contributors, and I hadn't gotten around to it yet.
Having said that: Welcome to Moto, and thank you for contributing these features!

Ah sorry first time here -- it seemed nearly automatic yesterday 😁 Thanks @bblommers !


Investigate multiple inserts into attestations table

Wrote an integration test to test anti-slashing protection of multiple simultaneous attestations and wasn't able to insert more than one attestations for a target_epoch.
Whilst I wasn't able to get this to happen in my testing, having this prevented at a database level my re-instating the unique is would provide an additional level of security against slashing. So recommend that we make the change to the schema to add the unique constrain back and adjust the import as needed.


chore(deps): rm unused tracing-futures

Closes #827

Codecov Report

Merging #830 (5c708dc) into main (4460dc7) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   73.06%   73.14%   +0.08%
==========================================
  Files         275      275
  Lines       28692    28692
==========================================
+ Hits        20963    20986      +23
+ Misses       7729     7706      -23

Flag
Coverage Δ

unit-tests
73.14% <ø> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/net/network/src/session/active.rs
84.67% <0.00%> (+0.18%)
:arrow_up:

crates/transaction-pool/src/pool/txpool.rs
59.37% <0.00%> (+0.50%)
:arrow_up:

crates/transaction-pool/src/test_utils/mock.rs
59.70% <0.00%> (+6.59%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add missing unit test for memory backend

Need to add unit tests for each nodes in the in-memory backend

Types
AssignedTo

artifact
@pxp928

builder
@pxp928

certifyBad

certifyGood

CertifyScorecard

CertifyVexStatement

CertifyVuln

CVE
@jeffmendoza

GHSA
@jeffmendoza

hasSBOM

hasSLSA

hasSouceAt

hashEqual

isDependency

isOccurrence
@jeffmendoza

isVulnerability

osv
@jeffmendoza

path

package
@pxp928

pkgEqual

source

Please assign yourself or comment on which ones you are going to tackle.

I'll do csv/osv/ghsa next

I'll to isvuln, certify vuln, certifyvex next.

Next for me: certify{good/bad/scorecard}


JSON schema validation should support defining the problem severity

Currently all schema problems are flagged as warnings. Would be cool if I can control this and sometimes make them errors.

@dbaeumer Can you give an example on which validation issues would be an error and which ones a warning?

For example if I define additionalProperties: false and someone adds a not defined property I would expect an error. Showing this as a warning is IMO confusing since for example deprecations are shown as a warning as well.


Question: MSVC Undefined GL Identifiers

I'm getting alot of undefined identifiers on windows in LVTK.  As of now, the setup only uses <pugl/gl.h> for GL-including purposes.  the nanovc*.c files below were modded to use pugl/gl.h as well.
The first thing I did was build pugl by itself and run the examples.  obviously this isn't a pugl problem.
Do you remember seeing things like this in the past:
libnanovg.a.p/nanovg_gl.c.obj "/c" ../src/nanovg/nanovg_gl.c
../src/nanovg/nanovg_gl.c(394): error C2065: 'GL_VERTEX_SHADER': undeclared identifier
../src/nanovg/nanovg_gl.c(395): error C2065: 'GL_FRAGMENT_SHADER': undeclared identifier
../src/nanovg/nanovg_gl.c(402): error C2065: 'GL_COMPILE_STATUS': undeclared identifier
../src/nanovg/nanovg_gl.c(409): error C2065: 'GL_COMPILE_STATUS': undeclared identifier
../src/nanovg/nanovg_gl.c(422): error C2065: 'GL_LINK_STATUS': undeclared identifier
../src/nanovg/nanovg_gl.c(710): error C2065: 'GL_GENERATE_MIPMAP': undeclared identifier
../src/nanovg/nanovg_gl.c(748): error C2065: 'GL_CLAMP_TO_EDGE': undeclared identifier
../src/nanovg/nanovg_gl.c(753): error C2065: 'GL_CLAMP_TO_EDGE': undeclared identifier
../src/nanovg/nanovg_gl.c(978): error C2065: 'GL_INCR_WRAP': undeclared identifier
../src/nanovg/nanovg_gl.c(979): error C2065: 'GL_DECR_WRAP': undeclared identifier
../src/nanovg/nanovg_gl.c(1151): error C2065: 'GL_TEXTURE0': undeclared identifier
../src/nanovg/nanovg_gl.c(1175): error C2065: 'GL_ARRAY_BUFFER': undeclared identifier
../src/nanovg/nanovg_gl.c(1176): error C2065: 'GL_ARRAY_BUFFER': undeclared identifier
../src/nanovg/nanovg_gl.c(1176): error C2065: 'GL_STREAM_DRAW': undeclared identifier
../src/nanovg/nanovg_gl.c(1209): error C2065: 'GL_ARRAY_BUFFER': undeclared identifier
ninja: build stopped: subcommand failed.

If so, is there some flag I'm missing for windows + gl that you know of I can try to fix this?  Wouldn't mind knocking it out while the day job has me doing alot of windows stuff.
LVTK doesn't check for GL whatsoever.  It just uses pugl-gl's pkg-config or subproject.

Don't think I've seen that, but these are relatively new symbols as far as GL goes.  That usually comes up at runtime though (because you need to jump through quite a few hoops on Windows to get a context with modern GL features).
What version of windows / drivers / etc?

On second thought you probably need glad or a similar loader for this stuff.  I'm not sure you can expect them to be available in the Windows headers, and even if they were, it wouldn't work because they need to be dynamically loaded anyway.  See e.g. pugl_shader_demo.

Setup pretty good over here :)  I was hoping glad wouldn't be needed.  no biggie.

Also hooked in to an HDPI monitor.  System is dual boot windows 10 and ubuntu 20.  I'm expecting there to be hurdles to overcome in multiple monitor setups.  i.e. the mixing of HDPI and non-HDPI displays.

I imagine there definitely will be when moving things between screens.
I added some DPI things recently and I knew it was sketchy, but, ahem, someone convinced me that was fine so I punted on it for now.  I'm pretty sure screen DPI and anything similar needs to be added to configure events to do this at all correctly, but haven't worked on that yet.  It's a bit annoying since you need to know which screen you're going to display on, which means the view needs to be realized, but people want to set things up and know the DPI before then.  I doubt that's really possible without adding a whole monitor API, but we'll see.
That aside, for programs it should magically just work fine.  For plugins, the host is responsible for calling SetProcessDPIAware or doing the equivalent thing in the application manifest or whatever.

I was hoping glad wouldn't be needed

Not really a thing at all these days, unfortunately, unless you're writing prehistoric fixed function pipeline code, which is terrible.
Personally I just gave up and am all-in on Vulkan.

Will see what this vulkan thing is all about: never heard of it until a few weeks ago.  Might be a good idea and bite the bullet early.
NanoVG + GL is seems to work with glad though.

If you're working through an abstraction layer like nanovg and it has support, worth checking out.
Using Vulkan directly/manually is very brutal though.  It's technically a million times better, but the cost in explicit verbosity is very high.

https://github.com/jpbruyere/vkvg  gonna try that one.

I added some DPI things recently and I knew it was sketchy, but, ahem, someone convinced me that was fine so I punted on it for now. I'm pretty sure screen DPI and anything similar needs to be added to configure events to do this at all correctly, but haven't worked on that yet.

talking about puglGetScaleFactor?  This is all that's needed for a GUI to convert back and forth between logical and physical pixels....  assuming that Pugl never tries to do internal coordinate scaling.... personally I don't think it should.

View converts all incoming pugl events to logical pixels before passing along to widgets.
https://github.com/lvtk/lvtk/blob/v3/hidpi/src/ui/view.cpp
LowLevel context uses same scaling as the View.
https://github.com/lvtk/lvtk/blob/v3/hidpi/src/ui/nanovg.cpp
The user facing Surface and Graphics API is all in logical coordinate space.

Oh and by the way.  Apparently mix-matched dual monitors "just works".  At least it does over my way.

Even with different DPIs?  Hm.  Well, that's nice, if surprising.  What pugl is doing now definitely has problems, I think (interface is flawed, I merged it anyway to get on with things), but maybe it's Good Enough for 90% of cases.
I do have laptops and an external display with wildly different pixel densities, so I'll get around to trying one of these days, but I don't actually use multiple monitors myself so it's a bit of a chore to bother.

Yep.  Seemed to just work with a 4k + standard 1080p.  With my setup there were differences in behavior between linux and windows.  Linux needs "Fractional Scaling" enabled, whereas windows "just worked".
A Pugl Window Split between two monitors
On Linux a split window looked as you expect, same perceived magnification.  On windows, one-or-the-other scale factors would be applied on both monitors.  e.g. One side looks normal while the other is either zoomed in, or squished.
I normally don't use multi monitors either, but was motivated in my last binge of LVTK to try the mix matched DPI scenario.   Knowing the scale factor via puglGetScaleFactor is IMHO essential.  With this information alone, toolkit devs can do the logical <=> physical pixel conversions without toolkit end-users having to even think about it.
--

On windows, one-or-the-other scale factors would be applied on both monitors. e.g. One side looks normal while the other is either zoomed in, or squished.

Yeah, this is what I expect (like, in current reality, not ideally of course).  I'm on the fence as to whether an accessor like this should even exist at all (ideally not, it encourages exactly this kind of brokenness), but it's clearly not sufficient.  All things related to "configuration" need to be conveyed in configure events for things to work properly.

related to this, on macOS the experience is different. on a setup with 2 different scale factor displays, unless the application supports something custom (dont know what that API is) only half the window appears when it is placed in between the screens. when most of the window is moved to another screen, that is the screen where it appears visible on, with the other part then becoming hidden.

Hm.  Odd since MacOS is (I think?) always indirectly rendered anyway.
Although windows not fully displaying when simultaneously on two different displays with different pixel densities isn't the end of the world (it's not like you could really use the UI like this anyway), but hopefully that's an easy fix because it'll look janky when dragging them at least.


add description for NP probe type NHP

I'd greatly appreciate having a test for this; do you think you could manually stub the example file they shared down to < 10 MB (or as small as you want really) and send it to the GIN folks + add to the S3 bucket?
Also changelog


Autogenerate service controllers from prow cluster

Issue #, if available: https://github.com/aws-controllers-k8s/community/issues/908
Description of changes:

Add script in cd/auto-generate for autogenerating service controllers from prow cluster.
Adds a new docker image which will execute auto-generate-controller.sh script in prowjob.

Sample issue will look like : https://github.com/vijtrip2/ecr-controller/issues/13
Sample PR will look like: https://github.com/vijtrip2/dynamodb-controller/pull/12
Tested locally using docker run command and ack-bot personal access token.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm


Fix pr_body text of update-sqlite workflow

The latest version of the repo-sync/pull-request (v2) action parses template text differently.
Previously backticks had to be escaped, but not anymore. Backslashes are removed so the backticks won't be parsed as literals in the PR body, as seen in the following screenshot.

thanks!


Updating win module share language

Fixes #4811
@mikefantini asked me to write out share language for the win module. I'm gonna go with:
"23,519 Playbooks Sent! Thanks to everyone for rocking this campaign with @dosomething. Let’s keep it up!"
This PR implements that new language.

:+1:


Minor Upgrade

Mistakes for the past pull request.
Modifications:

Version bump from 4.0 to 4.1
Gem dependency upgrade (see history.md)
Added versions to dev dependencies
Testing for bleeding edge ruby (2.4.0-dev) in travis

I at least would like to look into becoming one of the maintainers of this project.


macOS support

Brief feature description
Having the possibility to use iceoryx on macOS
Detailed information
Needed for ROS2 tier 1 support
ROS2 Tiers

Mac OS works!


[DOC-56] Developers Section

Based off of: https://hackmd.io/bDu2QwveRdKeXQBOH7h4yg

@fameal The only instances where I found .md files that I would rather redirect to a URL are ones that will exist once this repo replaces the current live docs. There will need to be a larger effort to resolve URLs at that point & probably can wait until then. (imo)

@philburrrt I agree 100%.

Broken links here
./versioned_docs/version-0.4.2/GETTING-STARTED.md

Is missing


user permissions error

Hi,
I have created ad domain services TF module and integrated with Core. It picks it up and terraform validate works when I run make deploy-core but fails at last hurdle with below error.  Which user is it referring to as I can't find it on AD
I have done AZ login before hand and I can create ad domain services over the Portal so it seems to be using some different account

Thanks

I have checked all the User IDs and Enterprise Application IDs but can't find that user it's referring to

Firstly I would avoid modifying core, and try to use shared services or create a feature request to and make discuss making changes upstream. The reason being your changes can block upgrades to future releases we make.
Where are you executing the command from? Unless you have ARM_CLIENT_ID set terraform should use your Azure CLI login. Are you searching for the object ID in the correct tenant?

Thank you for your response
That does make sense about core, that did cross my mind. Our challenge is that TRE will be deployed to a new Subscription but will need to make use of an existing AD Domain Services (due to AVD). So not sure at what extent it needs to be integrated into the TRE framework or can it stay completely out of its scope
In regards to error, 'ARM_CLIENT_ID' pointed me to the correct Service Principal, thanks again

In this scenario I'd keep ADDS completely separate, typically part of the customer landing zone. the TRE networks can peer to to the network that ADDS sits in. The peer can be added  in separate TF state.
We do similar in our workspaces: https://github.com/microsoft/AzureTRE/blob/b63e7eeda3b8690c4fff9961b067dec615adb6cd/templates/workspaces/base/terraform/network/network.tf#L45-L67
Ass for AVD. I don't believe ADDS is a prerequisite any more,  it will work with Azure AD.
He had this set up as a PoC - see pull request here - https://github.com/microsoft/AzureTRE/pull/1865
This is in Bicep, we would likely use terraform going forward to be consistent.
 Also AVD does not support AD guests (researchers are usually guests), or Linux VMs.
If you want to try do a PR to integrate AVD, happy to help as something that often comes up.


chore(merge-back): 2.37.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: b04e3b8df9f583633a34f3eee4fa283cd52159c6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


#6638 one-to-one association is unexpectedly refreshed when using findBy or findOneBy repository methods

Failing test case for #6638
Both findBy and findOneBy have the same effect where the relation suddenly returns.
Using either find or a DQL query work as expected (e.g. the relation remains null after)

Notes to self:
Did some initial digging: the issue is only reproducible with a bidirectional one-to-one association, as the reset to null is applied due to it being the inverse side of the association. The owning side of the association here is the source of truth.
So far, I traced it down to this location in the code
The ORM sees null on a field, so it decides to hydrate the association regardless of the correctness of the state.

Not sure of this matters for this issue, but in my initial example i set both sides of the relation to null (which i forgot to do here).
When i apply to following diff, in the end, both sides of the relation are refreshed.
diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH6638Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH6638Test.php
index 50f5d09df..afb672f8c 100644
--- a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH6638Test.php
+++ b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH6638Test.php
@@ -32,16 +32,20 @@ final class GH6638Test extends OrmFunctionalTestCase
         $repository = $this->_em->getRepository(GH6638Customer::class);

         $customer = $repository->find($initialCustomer->id);
+        $cart = $customer->cart;

         $this->assertInstanceOf(GH6638Cart::class, $customer->cart);

         $customer->cart = null;
+        $cart->customer = null;

         $this->assertNull($customer->cart);
+        $this->assertNull($cart->customer);

         $repository->findBy(['id' => $initialCustomer->id]);

         $this->assertNull($customer->cart);
+        $this->assertNull($cart->customer);
     }
 }

Does this change anything? Do you want me to update the PR with this diff?

both sides of the relation are refreshed.

That's no good either.
What seems to happen is that the hydrator ignores the fact that the entity already is hydrated, and therefore keeps hydrating even if the Query::HINT_REFRESH is not given.

I wish i could be of more help, but most of the doctrine internals seems like black magic to me. If you told me it works by sacrificing an intern every monday i'd believe you.
Regardless, i've been trying to understand the issue a little better...
So far i've found out that you CAN recreate this using dql. In my earlier tests i did SELECT c FROM Doctrine\Tests\Functional\Ticket\GH6638Customer, but because of reasons beyond my understanding a findBy will do a fetch join on the one-to-one relationship.
When i do a dql query with a fetch join like this SELECT c, cc FROM Doctrine\Tests\Functional\Ticket\GH6638Customer c LEFT JOIN c.cart cc it has the same effect as findBy and will refresh the relationship.
Unfortunately, i'm unable to figure out what the exact effect of a fetch join is on the hydration process.

@johanderuijter the problem is quite simple: the ObjectHydrator (among its complexity, which is mind-boggling) has a design flaw.
Given a query like following:
SELECT a, b FROM A a JOIN a.b b

And a resultset like following:
a_id, a_field1, b_id
1, "foo", 2

And an in-memory entity (registered as managed) new A(1, "foo", null /* this is where B should be */)
It will loop over the resultset and fetch the current fields of the A instance.
The problem is specifically with null: if the hydrator detects that the field b is null in the following check:
https://github.com/doctrine/doctrine2/blob/61404e2d6d71a6d46331f2fa1771dad121e49058/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php#L434
It will overwrite the field, as if it was never loaded.
This check is too naive, as the correct check would be "is this entity already loaded or built by someone else, or did I build it?".
That  ! $reflFieldValue expression needs to become something like if ($this->didIReallybuildThis($parentObject)) {

This is really just an edge-case with null: this behavior would be perfectly OK with $this->_hints[Query::HINT_REFRESH] being set, but it is not when the field is simply null

By the way: sacrificing interns works too, I just don't have one available right now.

@johanderuijter I found an intern to sacrifice and I started work on https://github.com/doctrine/doctrine2/pull/6649: can you please try it out?
It is not an acceptable patch as-is, but it's a start, as it correctly identifies the issue.

I wont be able to test it in my original use case until monday, but i tried it out in a different setting and as far as i can tell this fixes the problem. For all use cases i could find (findBy, findOneBy and a DQL query with a fetch join) the one-to-one relation is no longer refreshed.
Thank you for looking into this so swiftly and taking the time to explain the problem to me in more detail!


Added image type response from viber bot

Fixes issue #18
Changes:
Added image type response from SUSI Viber bot.
Screenshots for the change:

@Manveer695 @saurabhjn76 @betterclever Kindly review this PR.

@betterclever Yes I am raising this issue in susi_server and as soon it gets implemented in server then it will like map i.e we will just check for the type of response.

please resolve the conflicts.

@AliAyub007 as said by Chatan, please resolve the conflicts.


Fix: S3 cache creation conflicts

Description
When using this terraform to create GitLab Runners in AWS, I ran into issues with creating the S3 cache bucket using the cache module.  The issues were around conflicting conditional operations currently in progress, and they happened after repeated runs.  I received the follow errors:
Error: error updating S3 Bucket (<account id>-gitlab-runner-cache) tags: error setting resource tags (<account id>-gitlab-runner-cache): OperationAborted: A conflicting conditional operation is currently in progress against this resource. Please try again.
Error: error putting S3 server side encryption configuration: OperationAborted: A conflicting conditional operation is currently in progress against this resource. Please try again.
Each time the status code was 409.  I did some research and came across this issue with the AWS Terraform provider: https://github.com/hashicorp/terraform-provider-aws/issues/7628
The workaround suggested there was to add depends_on to some of the S3 resources.  I made this change and now the S3 cache bucket is able to be created successfully.
Migrations required
NO
Verification
I ran the terraform from my fork successfully in my AWS account; the cache bucket was created successfully without any conflicting operation errors.
Documentation
N/A

Sorry missed the PR, will have look in the next days

Can you run a rebase with develop please

@npalm Certainly.  Rebase is done 😃

According to the linked issue the problem has been solved with 3.67 of the AWS provider.
I think this PR can be closed.

@npalm Any objections to close the PR? Should have been solved with the newer AWS provider.


EACCES: permission denied, scandir

Build/Submit details page URL
No response
Summary
When running build command expo-cli seems to be trying to access directors it likely has no right accessing
EACCES: permission denied, scandir  '/a/directory/outside/the/root/dir/that/eas.json/is/in'

Why is it trying to scandir directories outside the root folder in which eas.json resides.  How can I fix it.
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: Linux 5.4 Ubuntu 20.04.6 LTS (Focal Fossa)
Shell: 5.0.17 - /bin/bash
Binaries:
Node: 18.14.0 - ~/.nvm/versions/node/v18.14.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v18.14.0/bin/yarn
npm: 9.4.2 - ~/.nvm/versions/node/v18.14.0/bin/npm
SDKs:
Android SDK:
API Levels: 28, 29, 33, 34
Build Tools: 30.0.3, 33.0.2, 34.0.0
System Images: android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-33 | Google APIs Intel x86_64 Atom, android-33 | Google Play Intel x86_64 Atom
npmPackages:
expo: ^49.0.8 => 49.0.8
react: 18.2.0 => 18.2.0
react-native: 0.72.4 => 0.72.4
Expo Workflow: managed
Error output
[Error: EACCES: permission denied, scandir '/a/directory/outside/the/root/dir/that/eas.json/is/in'] {
errno: -13,
code: 'EACCES',
syscall: 'scandir',
path: ''/a/directory/outside/the/root/dir/that/eas.json/is/in"
}
Error: build command failed.
Reproducible demo or steps to reproduce from a blank project
create a project with directory structure
--A
----C <=== make this folder not accessible to currently logged in user.
----B
------eas.json
rn project is located in folder B.  Try to build project.  It will try to scan C and give error. Is that expected? C has no relation to rn project in B which contains the entire rn project.

Just here to say that '/a/directory/outside/the/root/dir/that/eas.json/is/in' is hilarious 😆

I came across this gem
https://github.com/expo/fyi/blob/main/eas-build-archive.md#how-can-i-upload-files-to-eas-build-if-they-are-gitignored
Very helpful
So the root directory is not the directory with the "eas.json" but with the ".git" folder.
I used the "easignore" (although not recommended) but eas was not processing "gitignore" how I expected but "easignore" did.
One thing that I missed is that it goes into the folder where ".git" lives and not necessarily where the "eas.json" lives


Add --examples Argument for Fine-Grained Task Evaluation in lm-evaluation-harness. This feature is the first step towards efficient multi-prompt evaluation with PromptEval [1,2]

This PR introduces a new --examples argument to the evaluation pipeline in lm-evaluation-harness, enabling users to evaluate specific examples across multiple tasks. This enhancement extends the functionality of the --limit argument by allowing users to control which examples are included in the evaluation. Users can specify task examples via a JSON file containing a dictionary where keys are task names and values are lists of example indices. For instance, a JSON file might look like this:
{
  "mmlu_astronomy": [0, 3, 6],
  "mmlu_anatomy": [1, 4, 7, 10],
  "mmlu_econometrics": [2, 5, 8, 11, 14]
}

To use this feature, for example, you could save the dictionary to a file (e.g., /path/to/examples.json) and run the following command:
lm_eval \
  --model hf \
  --model_args pretrained=Qwen/Qwen1.5-0.5B \
  --tasks mmlu_astronomy,mmlu_anatomy,mmlu_econometrics \
  --device cuda:0 \
  --log_samples \
  --output_path "/path/to/output" \
  --examples "/path/to/examples.json"

If we do not specify the examples for a task, all examples will be evaluated.
This new feature has multiple applications. It allows practitioners to evaluate models on specific subsets of interest, such as critical edge cases or benchmarks. It also supports multi-prompt evaluation using PromptEval [1,2] by enabling the evaluation of a few selected examples for each prompt template, followed by performance distribution estimation. As part of the future roadmap, we plan to integrate PromptEval functionality directly into lm-evaluation-harness to provide a seamless evaluation experience.
References
[1] Maia Polo, Felipe, Ronald Xu, Lucas Weber, Mírian Silva, Onkar Bhardwaj, Leshem Choshen, Allysson Flavio Melo de Oliveira, Yuekai Sun, and Mikhail Yurochkin. "Efficient multi-prompt evaluation of LLMs." arXiv preprint arXiv:2405.17202 (2024).
[2] https://github.com/felipemaiapolo/prompteval

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


What is the behavior of concurrency locks around restarts?

Hi,
We're considering using this gem to enforce concurrency limits. I'm trying to understand the behavior of these limits on jobs that have to be "hard shutdown" during a restart.
Question: Do locks from killed processes remain until the lock's expiration?
My understanding is that jobs that are killed without finishing on their own (and thus not hitting the middleware) will continue to be "locked" and count against the concurrency limit until their TTL expires. Is that correct?
Example Scenario:
We restart our sidekiq processes with a 20 second shutdown grace period.
A long-running job does not finish during the grace period. So, the job's worker is hard-killed by sidekiq and the whole process shuts down shortly after.
In this case, would the job id that the process was running still remain in the set of locked jobs?

Yes. If clean-up middleware was not triggered (e.g. in case when worker was hard-killed then concurrency lock will be hold until expiration (15 mins by default).

Thanks for the quick response. I don't need any further information.
Should I close this out?

Sure. One note though - it's possible to reset locks from sidekiq web ui.


Readme spell-checking

Hi,
This looks like a great project, I will definitely try it when I get the chance!
I've read the Readme and changed a few things.
You might want to consider organizing some of the explanations and tutorials in a Wiki section, or maybe create a starter "Hello world" project. This will help shorten the Readme, and make this project less imposing for newcomers like me.

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   91.82%   91.82%
=======================================
  Files          27       27
  Lines        1077     1077
=======================================
  Hits          989      989
  Misses         55       55
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c11214...7d1bde5. Read the comment docs.

Thank you, I will def consider that!


Add extra keys

implemented methods to manipulate extra data
closes #72

Codecov Report

Merging #94 (d5a7b87) into feature-wallet (f909e1f) will increase coverage by 0.02%.
The diff coverage is 95.00%.

@@                Coverage Diff                 @@
##           feature-wallet      #94      +/-   ##
==================================================
+ Coverage           84.74%   84.77%   +0.02%
==================================================
  Files                  86       86
  Lines                7501     7521      +20
==================================================
+ Hits                 6357     6376      +19
- Misses               1144     1145       +1

Impacted Files
Coverage Δ

neo3/wallet/wallet.py
84.90% <95.00%> (+6.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f909e1f...d5a7b87. Read the comment docs.

What about just having an extra instance variable that is typed as Dict[str, any] and in to_json we do:
if len(self.extra) == 0:
   "extra": None
else:
   "extra": self.extra


Support for Customize folder icons

It would be much better If you guys added the ability to customize folder icons.

You can change icon in the windows explorer, they would appear normally in files app.

You can change icon in the windows explorer, they would appear normally in files app.
I can do everything in windows file explorer, then why do we need this Files UWP app.

So, you basically need an option to customize the folder icon within "Files UWP" (i.e. to select the folder's icon from an *.ico or *.dll or *.exe), right?
If Files could already extract the custom icon and apply it, then this could indeed be possible.
Perhaps they could add a "Select Icon" button or something like that to the Folder Properties window.

Thanks for responding.
Yes, I do.
I organize my folders by changing their icons which makes the interface
more user friendly to work. It becomes easy to identify the folders using
visual representation. The best way that this facility can be integrated is
by clicking on the folder properties window. Then as one can rename the
files by clicking on the file title, in the similar manner, it would be
great to change the icon just by clicking over it. No separate button would
be required to do that.
On Mon, Dec 7, 2020 at 6:26 PM Shankar<EMAIL_ADDRESS>wrote:

So, you basically need an option to customize the folder icon within "Files
UWP" (i.e. to select the folder's icon from an *.ico or *.dll or *.exe),
right?
If Files could already extract the custom icon and apply it, then this
could indeed be possible.
Perhaps they could add a "Select Icon" button or something like that to
the Folder Properties window.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/2534#issuecomment-739901639,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR7T7KW3LLGCXJUJUPPB6Y3STTGJPANCNFSM4UM3NCSQ
.

--
Prakhar Singhal
+919428781648

Duplicate of #1015.


Radix

Blocked until dialog trigger as dropdown menu item can be composed, see https://github.com/radix-ui/primitives/issues/634

Waiting for stitches@1 release and radix update, checking whether it is possible now (with current implementation) to nest dialogs and dropdown menus and other things https://github.com/radix-ui/primitives/pull/818


KTOR-5744 Documentation for Support loading multiple configuration files

Maybe we also need some sample, but I'm not sure how to add it


Add the meta primary to wash find

The meta primary represents a predicate made on the entry's meta attribute, which represents the portion of the entry's metadata returned by the plugin's List API endpoint (e.g. DescribeInstances for EC2 instances; ListObjects for S3 objects, etc.). This primary is useful for people who want to filter specific entries via a predicate that isn't captured by the existing wash find primaries (e.g. for EC2 instances, the meta primary can be used to filter out EC2 instances marked by a specific tag).

With the meta primary, filtering out the right EC2 instances for the AWS reaper should reduce to something like
wash find aws/eso/resources/ec2/instances -meta Tags[].Key = termination_date -a -meta Tags[].Value < $(date)

(Of course the end result will likely be different, but ^ should illustrate the general idea. Note that < and = are part of wash find's args).
There's some things we'll need to figure out here.
If the user specifies the meta primary, should we automatically restrict wash find to run on a depth of 1 (outputting the appropriate directory that the user should search under if their cwd doesn't have entries whose meta schema matches what wash find specified?

Have some ideas around 3. We could modify the List endpoint to return a JSON object that's something like:
{
  meta_schemas: [
    { "name": "schema1", "schema": <hash representing the metadata's schema>}
  ],
  entries: [
     <bunch of ListEntries here, but they'd include an additional `schema` key specifying their meta attribute's schema>
  ]
}

The schema doesn't need to be a full-blown JSON schema, but something that's simple enough to convey the right information. That information would probably include the existing JSON types, but also some additional primitive types like time, mode for convenience so the munging's less ambiguous. We could compute this information in the API since for each entry, we tend to know the type of it's meta struct (e.g. for AWS EC2 instances, this would be *ec2Client.Instance).

Hmm, we may need a way for the user to tell us the type of value they're comparing. Looks like EC2 tags can be any arbitrary string, so in order to properly handle the AWS reaper use-case, we may need to introduce something like
-meta Tags[].Key = termination_date -a -meta Tags[].Value -time < $(date)

where -time would tell wash find that we're comparing two time-values. Maybe properly designing that's simple enough that we don't need any of the schema stuff I mentioned in my earlier comment. However, the schema stuff could be useful if we decide to allow only depth 1 for the meta primary b/c then wash find in its error message could output directories along the traversed paths whose meta attributes satisfy the specified schema. So something like
wash find aws -meta Tags[] ...

could yield something like
Error: Entries in AWS' meta attribute does not have the specified schema. However, the following subdirectories' entries do:
aws/<profile1>/resources/ec2/instances
aws/<profile2>/resources/ec2/instances
...

We should also consider renaming Entry.Metadata to something else, maybe DetailedMetadata or Inspect. The reason for the rename is that Metadata and meta could contain two separate things. The latter should contain the (partial/raw) metadata returned by the plugin's List endpoint, while the former is the entry's full metadata (e.g. for a Docker container, Metadata would include the container's platform while List does not; for an S3 object, Metadata contains much more information about the object than what List returns, so there are good use-cases for keeping the Metadata method).

I think we should look to normalize tags/labels somewhat. It's much easier to query {"termination_date": "..."} than {"Key": "termination_date", "Value": "..."}, and there's no good reason the latter needs to be used. We could do this either on AWS metadata, or as a new type of common attribute.

Doing this on the AWS metadata as an initial start makes sense to me, because labels is a generic enough concept that it's too early to make it a common attribute. Only concern with the AWS metadata is losing the raw information, but we could add a custom key to handle that (or we could try normalizing it and if people complain, then consider the custom key route). However, the plugin author will still need to provide some type information when invoking the meta primary in order for find to parse the right thing.
We may still need to handle querying an array of hashes for more complicated structures (e.g. like if you have an array of structs), but I think we can figure out a clean, DSL'ey way to do it.

Tag values are just strings, so the API doesn't give us any clues about their contents either.

Oh, by type information, I meant that the wash find user will likely know the tag value's type. That means we can enable something like -meta Tags.termination_date --type date --lt $(date) where --lt => <.

Oh, yes. Agreed.


Symbol not found using OSX Monterey 12.6.9

Describe the bug
Unable to run envoy on OSX Monterey
To Reproduce
On MAC OSX Monterey, run the following: func-e run
Expected behavior
Envoy to start
Environment (please complete the relevant information):

OS: Mac OSX Monterey 12.6.9
Envoy Version: 1.28.0
func-e Vrersion: 1.1.4

Additional context
This has been reported in the past and stated that mac-11 is no longer supported.
I'm running on mac-12
Here is the output:
> func-e run
1.28.0 is already downloaded
starting: /Users/cheese/.func-e/versions/1.28.0/bin/envoy --admin-address-path /Users/cheese/.func-e/runs/1698160720031589000/admin-address.txt
dyld[30500]: Symbol not found: (__ZNSt3__18to_charsEPcS0_d)
  Referenced from: '/Users/cheese/.func-e/versions/1.28.0/bin/envoy'
  Expected in: '/usr/lib/libc++.1.dylib'

Could you try to install envoy using brew?
brew install envoy

Probably we need to check our scrapper to get envoy for the lowest os.

brew install envoy and running the envoy command directly works

i did try it out but did not work - still receiving the same error.
func-e run --config-yaml "admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}}"
looking up the latest patch for Envoy version 1.29
1.29.3 is already downloaded
starting: /Users/user/.func-e/versions/1.29.3/bin/envoy --config-yaml admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}} --admin-address-path /Users/erekhron/.func-e/runs/1713950572982785000/admin-address.txt
dyld[15209]: Symbol not found: (__ZNSt3__18to_charsEPcS0_d)
  Referenced from: '/Users/user/.func-e/versions/1.29.3/bin/envoy'
  Expected in: '/usr/lib/libc++.1.dylib'

We don't have builds for different versions of os/x, and it is possible that the one we are using no longer supports monterey. Can you verify that's the version of OS/x you are using? I tried on sonoma and had no issues:
$ uname -a
Darwin MacBook-Pro.local 23.4.0 Darwin Kernel Version 23.4.0: Fri Mar 15 00:12:49 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_T6020 arm64

$ sw_vers -productVersion
14.4.1

$ func-e run --config-yaml "admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}}"
looking up the latest patch for Envoy version 1.29
1.29.3 is already downloaded
starting: /Users/adrian/.func-e/versions/1.29.3/bin/envoy --config-yaml admin: {address: {socket_address: {address: '<IP_ADDRESS>', port_value: 9901}}} --admin-address-path /Users/adrian/.func-e/runs/1714349420928367000/admin-address.txt
--snip--

yeah, I can confirm I am seeing the same in the regression build, any idea where does 1.29.3 comes from?
https://github.com/Homebrew/homebrew-core/actions/runs/10441704006/job/28913177524
  ==> /opt/homebrew/Cellar/func-e/1.1.4/bin/func-e run --version
  dyld[7763]: Symbol not found: (__ZNSt3__18to_charsEPcS0_d)
    Referenced from: '/private/tmp/func-e-test-20240818-7747-6z0sev/.func-e/versions/1.29.3/bin/envoy'
    Expected in: '/usr/lib/libc++.1.dylib'


Performance downgrade introduced with Mail::Utilities.to_crlf/to_lf change

I'm seeing a big performance downgrade with this PR and would propose reverting it. The original benchmark shows very positive results because the test string consist only of new line characters that is never the case with real email content.
Here's my benchmark:
require 'benchmark'

CRLF = "\r\n"
CRLF_REGEX = /\n|\r\n|\r/

line = 'a' * 100
string = "#{line} \n\r\n\n" * 100
number_of_samples = 10000

Benchmark.bm do |x|
  x.report('regexp:') do
    number_of_samples.times do
      string.gsub(CRLF_REGEX, CRLF)
    end
  end

  x.report('encode:') do
    number_of_samples.times do
      string.encode(:universal_newline => true).encode!(:crlf_newline => true)
    end
  end
end

Results:
regexp:  1.190000   0.030000   1.220000 (  1.231583)
encode:  1.510000   0.070000   1.580000 (  1.578965)

Now, it becomes more interesting when lines are longer, with 'a' * 200
regexp:  1.690000   0.020000   1.710000 (  1.711932)
encode:  2.990000   0.020000   3.010000 (  3.033241)

Or even 'a' * 1000 (that usually could be more with inline html):
regexp:  5.690000   0.100000   5.790000 (  5.864328)
encode: 14.250000   0.270000  14.520000 ( 14.601885)

I see performance downgrade of ~ 100% in my tests when benchmarking base64 encoded attachments where I originally noticed this issue.
The boundary where encode performs better vs regex would be when new line characters sequence appears after every 55 character which I would say is not frequent especially where this matters that is attachments and lots of content.

Ouch. Good catch and diagnosis.
On latest master we're no longer doing newline conversion on body parts. Do you think it makes this performance issue moot?

The performance downgrade I'm seeing in my benchmarks with that change is:
30 attachments of ~ 10MB each:   4.757560 sec -> 9.101804 sec
10000 html parts of ~ 40KB each: 8.909483 sec -> 10.272647 sec

It's the big emails (attachments) where this change is slowing things for 100%.
Also, my test suite time with this "improvement" is 1.62 sec and without it 1.48 sec. :) You can check out locally by disabling that change.

Ah, because we're still calling to_crlf in 8bit and base64 encodings…

Please do open a revert PR to address this 👍


Outline form field prefix wrong position

Reproduction
StackBlitz: https://stackblitz.com/edit/angular-bn3lcp
Steps to reproduce:

Press Random Prefix to get prefix tag text
See Outline form field top legend

Similar to https://github.com/angular/components/issues/15027
but its for dynamic changing text prefix
Expected Behavior
I want to make a search input with a starting (prefix) dynamic tag.
I would like either to stay the legend at starting position (top-left)
either the border to render at new position of legend
Actual Behavior
when the text of tag change i see blank space and wrong positioning to label
Environment

Angular: 7
CDK/Material: 7
Browser(s): any
Operating System: win

https://stackblitz.com/edit/angular-bn3lcp-ksnvaw?file=app/form-field-appearance-example.html

thanks! i will handle it with updateOutlineGap its an acceptable solution! 🎉

@nicholasp, to be clear, the solution updateOutlineGap is to a different problem.  The prefix position on an outlined form field is still broken.

This issue is actually worse because matSuffix doesn't align correctly with text on an outlined form field either.
https://stackblitz.com/edit/angular-bn3lcp

The solution is to remove this class EXCEPT when .mat-form-field-prefix or .mat-form-field-suffix have mat-icon children.  In other words, removing the css below solves the problem but creates the same issue when icons are used.
 .mat-form-field-appearance-outline .mat-form-field-prefix, .mat-form-field-appearance-outline
 .mat-form-field-suffix {
      top: .25em;
 }

will post an update on #12803


✨ feat(tests): PUSH*

🗒 Description
Introduces tests for PUSH* opcodes ported from ethereum/tests.
🔗 Related Issues
closes #974
✅ Checklist

[x] All: Set appropriate labels for the changes.
[ ] All: Considered squashing commits to improve commit history.
[ ] All: Added an entry to CHANGELOG.md.
[ ] All: Considered updating the online docs in the ./docs/ directory.
[x] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
[ ] Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
[ ] Tests: Included the type and version of evm t8n tool used to locally execute test cases:  e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
[x] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

I don't understand how the contents of converted-ethereum-tests.txt is ordered. Do I just add this at the end of the file?

This would even allow us to create a dedicated section in the docs, for example, that lists tests ported from ethereum/tests.
Yep! This would be really nice.

Open to suggestions on this. I think the only source of ported tests would be ethereum/tests? But we could think about adding other metadata tags such as "fuzz", "gentest", "bug", etc.

Perhaps we can add a generic "meta" marker that lets you add arbitrary metadata?

@raxhvl: Sometimes it can be tricky to get coverage parity, please reach out to @winsvega if you can't see anything obvious and need some pointers.
An example, although not applicable here, is if you port a YAML test with Yul Code to a Python test using Opcodes. In this case solc can optimize stack items increasing the "coverage" of the YAML-based test:
https://github.com/ethereum/execution-spec-tests/blob/5cf1f24b39ddef259470f58413337b81bda081a6/tests/homestead/coverage/test_coverage.py#L16-L29

Thanks @danceratopz
Let me give it a shot. I'm sure this will take some time, but I hope to pick up some learnings for future reference. If I get to a standstill, I will reach out to @winsvega.

I spent last week trying to understand how coverage works, and why its failing here.
TL;DR: The current test uses fewer opcodes to achieve the same result.
Previous strategy
The base test is parameterized using calldata. Here is a simplified pseudocode of how it works:
for calldata in [0..1f]:
    call(
        gas=gas(), address=add(0x1000,calldata(4)), value=0, argOffset=0, argSize=0,
        returnOffset=0, returnSize=0
    )

In this setup, the each calldata is mapped to a contract address, which focuses on a single PUSH opcode. The to address then routes each test case to the appropriate contract.
Current strategy
In the current approach, a unique contract is deployed for each PUSH opcode at the to address, eliminating the need for routing. Parameterization is handled directly by pytest.
Why coverage fails
The absence of a routing mechanism in the current test causes coverage failures. The simplified structure of the test means that opcodes like CALL, ADD, and CALLDATALOAD are no longer required. For example, the following coverage failure occurs due to the missing calldataload call:

This is inherently because of the difference in strategy test strategies: parameterization using EVM vs parameterization using pytest.
Larger picture
The base test employs a relatively complex strategy. Two areas of complexity include:

The calldata includes a function selector that is never used.
The calldata computes the destination contract address dynamically using an offset, which could be simplified by hardcoding the address.

Moreover, we should aim to test with a minimal set of opcodes—in this case, PUSH* and SSTORE—which would simplify the tests, make them faster, and avoid any potential unintended side effects.
With pytest now handling parameterization, the complex routing logic is no longer necessary.
cc: @winsvega @danceratopz  @marioevz

Yes, we have already some basic coverage that is applied by default. In test_all_opcodes.py.
But the goal of coverage here is to check that at least no lines lost after converting the test.
Reading the coverage report already helped me to find out a few bugs where I relied that code works, but it didn't


TypeError when using Zabbix Problems visualization

Describe the bug
After successfully adding the Zabbix data source (via API), I'm trying to create a new dashboard and add a Zabbix Problems type of visualization, but I'm getting a JS error message and no data is displayed. None of the Zabbix Plugin dashboards display any data.
The Zabbix user has adequate privileges (I also tried debugging with the Admin user) and CLI API calls can be successfully completed.
Expected behavior
A list of active Zabbix problems appearing via the visualization element.
Screenshots

Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

Grafana v11.3.1 (9225f4a1cb)
7.0.5
4.5.7

It was a permission error for the API user.


Is JSON the business of credential?

Is it really necessary to have the JSON.parse/stringify business in this module? It seems rather arbitrary to me. If using a store like MongoDB it makes little sense to save it as a string - and then I would be able to do lookups of potentially weak passwords (in the sense of iterations).
If it's an interface thing, we might just as well use array.join and string.split - not that that's any better.
A backwards compatible approach might be to return the object, but attach a prototype with a toString method that's basically JSON.stringify. It would be fairly easy to have verify support both formats. Of course I'd rather see a breaking change and complete strip of the stringifying and parsing.

My thinking was that if we leave JSON handling in userland, that's a potential attack vector if the library user screws it up. I'm not entirely convinced that I didn't screw it up, though. Particularly for the parse errors case.
I'm open to reversing course on this issue.

JSON.parse should always deal with "own" data, so I don't think error handling is necessary.
You're right, it is a potential user-screw-up.
I guess I think, there should be a really easy API, that suits 90 % of users, including those, that don't want to read more than the first two examples - like the current does.
I think it's more a naming thing to me.. The .hash method returns something that isn't really a hash, looks like an object, but is not, but can of course be used like an old-day hash.
Another method (documented last) could be returning the object, and .hash could simply be wrapping this with stringify.

By the way, I'm sorry for being this eager to do all kinds of changes, breaking and not :stuck_out_tongue: I just really want a proper secure module without oddities to put in my node-toolbelt.

I think it's more a naming thing to me.. The .hash method returns something that isn't really a hash, looks like an object, but is not, but can of course be used like an old-day hash.

"Hash" in this case refers to the one way cryptographic hash, not to the return value.

BTW, this would be a breaking change, so we need a more compelling reason than "gee, it would be nice if this returned something different". The only reason I'm even willing to consider this one is because currently, it could potentially return an error, instead of  the expected object, and that could be a (potentially serious) security problem if users of the lib fail to check for the error case.

I think using a stringified JSON is just fine. By definition it's just a string, you shouldn't care about its content. Strings are easy to store, JSON is supported by the language, we don't have to invent our own serialization format.

I still think we need better handling for the error case.

Agreed, let's close this for now.
I'll do a JSON.parse/stringify in my application for now.

:+1:

Looks like I was worried for no reason anyway. Credential already behaves appropriately if the stored hash can't parse correctly.


New Installer needs Kustomize support for the injection template

Wanting to modify the injection template is a fairly common task, but as far as I know we can't use Kustomize to modify it.
We should either:

Document how to kustomize it if it is possible
Try to find a way to kustomize it or some alternative

You mean the template of the configmap istio-sidecar-injector located at kustomize/istio-control/istio-autoinject.yaml, right?
Shouldn't it be possible to have an own kustomization.yaml referring to the existing files and patching the template property? Would that be an option?

yeah but the template is just a string, the templating is done in the injector at runtime. So I don't think Kustomize can handle that - if it can that would be great though

I don't know how the modifications to the template normally look like. Do you have an example. Right now, I see options:

Overwriting the whole template string in an overlay. This is already now possible, but there is no reuse of the existing template.
Introducing a template-patch property which is by default empty and will be merged after the templating is done. So this property can be overwritten. Would this be an option or do the modifications normally involve the use of template parameters? I wouldn't think so.

I guess 1) is not enough (hence this issue). @howardjohn Do you think 2) is an option? The implementation should't be to much and keep it compatible (if there is no template-patch, nothing is done.

I don't think there is any strong demand for this


[ospp] add push style collector

What's changed?

add push style collector.
Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[x]  I have added the necessary unit tests and all cases have passed.

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

👍

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

The code logic has been roughly modified according to the requirements mentioned by Tom last week, the database has been cached, and some fragmentary todos have been completed.
At present, the database still uses jpa, which is not connected to the warehouse and cannot use the time series database. If there is no need to rush to complete this recently, I can continue to do it after ospp.

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Brother Zheng and Brother Tom said during the discussion last week that due to the time field design and abstractCollect interface design of collectRep, it is currently impossible to collect multiple records at the same time, so a compromise solution was used. If I consider modifying this later, I can continue to finish it. After all, I am quite familiar with this part of the code.


Create and add shortcode for including CI badges on patterns

This PR creates and adds a new shortcode for including CI badges on patterns

/lgtm


Update CUDA and ROCm Ray images in notebooks

Description

Update CUDA and ROCm Ray images in notebooks to use Python 3.11 as the default Python version
How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

These haven't been updated to python 3.11 so these shouldn't be changed.
quay.io/rhoai/ray:2.35.0-py39-cu121-torch24-fa26
quay.io/rhoai/ray:2.35.0-py39-rocm61-torch24-fa26

Actually, that'll be the right time to rebuild and re-push these images with the Python 3.11 upgrade. WDYT?

We should also update these demo notebooks in line with the most recent updates to codeflare sdk, maybe we could create a separate jira/PR for this.

@oksanabaza could you please resolve the conflict?


Unable to update hassio 0.73.2 to 0.74

Home Assistant release with the issue:
0.73.2
Unable to updated to 0.74
Last working Home Assistant release (if known):
0.73 updated successfully to 0.73.2
Operating environment (Hass.io/Docker/Windows/etc.):
Raspberry Pi 3 B+
hass.io 115
Resin OS 2.3.0+rev1
Connected via WiFi
Component/platform:
Upgrade
Description of problem:
Attempting to upgrade to 0.74 from the UI or via the hassio command line fails.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
https://github.com/shortbloke/home_assistant_config
Traceback (if applicable):
# hassio ha update
ERROR
panic: interface conversion: interface is nil, not string

goroutine 1 [running]:
panic(0x2c7050, 0x1070a920)
        /home/travis/.gimme/versions/go1.7.6.linux.amd64/src/runtime/panic.go:500 +0x33c
github.com/home-assistant/hassio-cli/command/helpers.DisplayOutput(0x107cc200, 0x24, 0x200, 0x0)
        /home/travis/gopath/src/github.com/home-assistant/hassio-cli/command/helpers/common.go:118 +0x3c8
github.com/home-assistant/hassio-cli/command/helpers.ExecCommand(0x2f6f83, 0xd, 0x7ecb2e60, 0x6, 0x0, 0x0, 0x76500, 0x0, 0x0, 0x0, ...)
        /home/travis/gopath/src/github.com/home-assistant/hassio-cli/command/helpers/common.go:155 +0x308
github.com/home-assistant/hassio-cli/command.CmdHomeassistant(0x107864d0)
        /home/travis/gopath/src/github.com/home-assistant/hassio-cli/command/homeassistant.go:48 +0x540
github.com/urfave/cli.HandleAction(0x2af768, 0x324b14, 0x107864d0, 0x0, 0x0)
        /home/travis/gopath/src/github.com/urfave/cli/app.go:503 +0xf0
github.com/urfave/cli.Command.Run(0x2f6f83, 0xd, 0x0, 0x0, 0x40bd10, 0x1, 0x1, 0x301e4d, 0x2f, 0x0, ...)
        /home/travis/gopath/src/github.com/urfave/cli/command.go:165 +0x6b8
github.com/urfave/cli.(*App).Run(0x107b2380, 0x1070a120, 0x3, 0x4, 0x0, 0x0)
        /home/travis/gopath/src/github.com/urfave/cli/app.go:259 +0x8b0
main.main()
        /home/travis/gopath/src/github.com/home-assistant/hassio-cli/main.go:22 +0x108

Checking hassio su logs shows:
18-07-21 20:34:30 INFO (SyncWorker_5) [hassio.docker.interface] Update docker 0.73.2 with homeassistant/raspberrypi3-homeassistant:0.74.0
18-07-21 20:34:30 INFO (SyncWorker_5) [hassio.docker.interface] Pull image homeassistant/raspberrypi3-homeassistant tag 0.74.0.
18-07-21 20:34:41 ERROR (SyncWorker_5) [hassio.docker.interface] Can't install homeassistant/raspberrypi3-homeassistant:0.74.0 -> 404 Client Error: Not Found ("no such image: homeassistant/raspberrypi3-homeassistant:0.74.0: No such image: homeassistant/raspberrypi3-homeassistant:0.74.0").

Additional information:
Update to 0.74 is advertised in the hass.io Dashboard

exactly same problem here - except trying to upgrade from 0.72.1

A 404 Client Error: Not Found thrown by Docker can be either of the following things:

The container images do not exist.
You don't have enough disk space left to complete the operation.

It isn't the first option, so you probably are experiencing the second.
PS: Seems like a weird message to receive, but this is actually documented by Docker.

Could it be the trailing "." at the end of the version number, or is that just message formatting?
Pull image homeassistant/raspberrypi3-homeassistant tag 0.74.0.

Might be something specific to Resin OS based Hassio. I've just spent this creating a new SD card using HassOS 1.7 (64bit). This started as 0.74, restoring my snapshot took it back to 0.73.2, ran the update from the command line and it's now successfully running 0.74.0. Admittedly I switch from 32bit to 64bit and from  Resin OS to HassOS, so at least two things changed.

Yes, the docker version on ResinOS have some times troubles. I don't know why but we support now only HassOS

As mentioned I made the move from Resin OS to HassOS and it wasn't too difficult, followed:
https://www.home-assistant.io/blog/2018/07/11/hassio-images/
Only thing I noticed was that the dropbox addon I was using, disappeared during the migration. Might have been something I did, or maybe because it was from a non-standard repo?
But sounds like people who are having this issue should consider moving to HassOS.

Yeah, look like there is a timing bug on restore snapshot. I will look into that soon


Remove the aspnet/Configuration submodule

React to aspnet/Configuration merging into aspnet/Extensions.
See https://github.com/aspnet/Extensions/pull/464
FYI @HaoK @muratg

cc @ajcvickers

This is ready to go, we're clear on the ProdCon side of things now.


Display Generated GIF in Reverse

How do you display the gif in reverse? Im struggling with this. If anyone can help that would be awesome thanks!

This library doesn't currently provide a way to reverse gifs. Depending on the display library you use, you might be able to just display it in reverse there (although the one I'm using doesn't appear to support that).


setting up locale

In Xamarin.Plugins there is an option to define the Locale/Language of Speech. It would be nice to have this option in nativescript.

This is definitely on my TODO list - not sure when I will have the time, probably a week or two away.
Always open to pull requests in the meantime :)

fixed by PR #3


Release 0.3.22

Fix Sync impl of BiLockGuard (#2570)
Fix partial iteration in FuturesUnordered (#2574)
Fix false detection of inner panics in Shared (#2576)
Add Mutex::lock_owned and Mutex::try_lock_owned (#2571)
Add io::copy_buf_abortable (#2507)
Remove Unpin bound from TryStreamExt::into_async_read (#2599)
Make run_until_stalled handle self-waking futures (#2593)
Use FuturesOrdered in try_join_all (#2556)
Fix orderings in LocalPool waker (#2608)
Fix stream::Chunk adapters size hints (#2611)
Add push_front and push_back to FuturesOrdered (#2591)
Deprecate FuturesOrdered::push in favor of FuturesOrdered::push_back (#2591)
Performance improvements (#2583, #2626)
Documentation improvements (#2579, #2604, #2613)

Oh, the nightly I used is a bit old as miri is not available on the latest nightly. As a result this release is affected by https://github.com/rust-lang/cargo/issues/10954.


1:1 typescript migration of the core

Fixed #1 #2 #3
This is a 1:1 port of the typescript version. No graphics at all.
After merged anyone can work on providing a libgdx rendered and fix remaining issues.

Thanks a lot for your contribution. :+1:
Would you mind to become the dragonBones JAVA managers? :stuck_out_tongue_winking_eye:

Where i can find documentation?))

No documentation now. Also i just ported the backend. A proper frontend implementation is still needed to be able to render it


HoloLens 2 Apps starting in deadlock on Unity 2020.3.32f1

Describe the bug
The application starts and shows loading animation forever. Downgrading to Unity 2020.3.31f1 allows the same application to load.
To reproduce
Steps to reproduce the behavior:
Create an MRTK project with OpenXR
Expected behavior
The application should load a scene.
Your setup (please complete the following information)

Unity 2020.3.32f1
MRTK v2.7.3

Target platform (please complete the following information)

HoloLens 2
OpenXR

Additional context
I have not tested with any other settings, but I am providing a log file for the running project. The ending line states that a deadlock may occur.
UnityPlayer.log

Same problem confirmed for Unity 2021.2.17f1 as opposed to 2021.2.16f1 which runs without problems.

Same problem here. Downgrading to 2020.3.28f1 worked for the same application.

Oof. Just ran into this as well, previously Unity 2020.3.17 and MRTK 2.7.2 worked fine.
Interestingly, when setting up an empty project with Unity 2020.3.32 and MRTK 2.7.3 I could not reproduce the bug. It only happens in our application which was upgraded from a previous Unity release. Super weird.

Oof. Just ran into this as well, previously Unity 2020.3.17 and MRTK 2.7.2 worked fine.
Interestingly, when setting up an empty project with Unity 2020.3.32 and MRTK 2.7.3 I could not reproduce the bug. It only happens in our application which was upgraded from a previous Unity release. Super weird.
Might just be luck/timing though. The log is full of this:
GfxDeviceD3D11Base::WaitForLastPresentationAndGetTimestamp() was called multiple times in a row without calling GfxDeviceD3D11Base::PresentFrame(). This may result in a deadlock.

I have to admit my original project had a little more than nothing in it. Very small test project. Could be specific to one of the services running or lucky timing as you suggested.

Yep, this is an issue on the Unity side.
As a workaround, if you have a pro license, disable the splash screen in your UWP settings.
Unity has found a fix for the issue and is working on getting it released.

Same problem, while Unity is fixing it, I was able to deploy successfully using 2020.3.27f1

Yep, this is an issue on the Unity side.
As a workaround, if you have a pro license, disable the splash screen in your UWP settings. Unity has found a fix for the issue and is working on getting it released.

Is there an item on Unity's issue tracker for this?

Also, apparently it's fixed with .33, did anyone verify this?

Yep, I verified it! There's now a non-blocking follow-up bug that the Unity splash screen doesn't show up at all, but the app still launches.

The app does launch in .33 but it becomes really laggy and fills the unitylog with errors would not recommend
.28 is the way to go

The app does launch in .33 but it becomes really laggy and fills the unitylog with errors would not recommend
.28 is the way to go

Can you post a snippet of the errors in the log please? I hadn't been able to repro.

The app does launch in .33 but it becomes really laggy and fills the unitylog with errors would not recommend
.28 is the way to go

Can you post a snippet of the errors in the log please? I hadn't been able to repro.

Sure !
It goes on normally then I get this error each call :
GfxDeviceD3D11Base::WaitForLastPresentationAndGetTimestamp() was called multiple times in a row without calling GfxDeviceD3D11Base::PresentFrame(). This may result in a deadlock.
This started to happen when I updated the project from .13 to .33 and when I went back to .28 it stopped


Name of glb changed to MESH

I found that the internal names of the 3D models compressed with GLTFPACK have been changed to MESH. How can I keep these names unchanged and keep the original names.

gltfpack should preserve node names, but not mesh names - it doesn't generate any names by itself, so if you see the name change this likely means that it was omitted from the output. Can you use node names instead? They should be preserved by default on a best-effort basis, and if you pass -kn gltfpack will preserve all of them.

In the past, I used the grid name to help me identify the grid to be replaced, so that I could accurately replace the grid. But now after compression by GLTFPACK, the name becomes MESH, I have no way to change the mesh. I don't know if there is any way to accurately replace the mesh after compression.

-kn I tried to keep the nodes, but the name of the grid is still changed. But I like GLTFPACK very much, its decoding speed is very fast.

Right, but the mesh must be attached to a node, and that node probably has a name as well? In the source glTF file you should see mesh objects and node objects; typically both would have a name, gltfpack preserves the names for nodes (and when -kn is specified you should be able to replace the node / objects attached to the node the same way).
The issue is that gltfpack reprocesses the scene geometry and doesn't actually keep track of the original objects, so it might be hard to just keep the names of meshes - whereas for nodes this is already taken care of.

Now the names are all MESH_*, I am not sure if the node is the one I want to replace.
What I want to do is to replace a part of it in a 3D model-A, A1-is similar in shape to A, you can replace A, if the name is the same, I might replace B with A1. And A1 and B are The difference is that the entire model becomes deformed after replacement. I wonder if there is any way to achieve the function I want?

The MESH can already be replaced, thank you!

Right, but the mesh must be attached to a node, and that node probably has a name as well? In the source glTF file you should see mesh objects and node objects; typically both would have a name, gltfpack preserves the names for nodes (and when -kn is specified you should be able to replace the node / objects attached to the node the same way).
The issue is that gltfpack reprocesses the scene geometry and doesn't actually keep track of the original objects, so it might be hard to just keep the names of meshes - whereas for nodes this is already taken care of.

The MESH can already be replaced, thank you!


icons motion is not correct with RTL direction

icons motion is not correct with RTL direction

Hey @BlueSoftec Did you find the solution?


Update pom.xml

@nagarjuna33 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.


deploy_environment does not describe how to deploy to production

The documentation does a great job explaining how to deploy to a new "environment".
However, it does not describe how to deploy to the Production environment:

Do we have to exclude the deploy_environment setting?
Is there a magic string (e.g. - Prod, production, ???) that directs the deployment to Production?

Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38017fbb-c9a0-c285-c20a-191072b161a2
Version Independent ID: 92e4b322-3285-53ea-9937-6877392b43ae
Content: Create named preview environments in Azure Static Web Apps
Content Source: articles/static-web-apps/named-environments.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@dougclutter Thanks for the feedback! We are currently investigating and will update you shortly.

@dougclutter Thank you for sharing this feedback. After review, this information does not appear to be available in any other document as well so we have assigned this issue to the doc author to determine if clarity can be added around the life cycle of using preview environments.

@BryanTrach-MSFT Glad to help.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


[brotli] find_package causes unknown CMake command

Describe the bug
When installing Brotli via vcpkg and using with CMake, the call to find_package(unofficial-brotli CONFIG REQUIRED) causes a configuration error in CMake: Unknown CMake command "_add_library"
Environment

OS: Ubuntu 22.04 x64 (also tested on Windows x64 too)

To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/microsoft/vcpkg
cd vcpkg
./bootstrap-vcpkg.sh
vcpkg install brotli:x64-linux
An example CMakeLists.txt file that triggers the issue:

cmake_minimum_required(VERSION 3.16)

project(
  ExampleProject
  VERSION 1.0
  LANGUAGES CXX)

set(VCPKG_ROOT "/path/to/vcpkg/" CACHE PATH "vcpkg root directory")
set(CMAKE_TOOLCHAIN_FILE ${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake CACHE STRING "Vcpkg toolchain file")
set(CMAKE_PREFIX_PATH "${VCPKG_ROOT}/installed/x64-linux" CACHE STRING "Vcpkg installed targets")

find_package(unofficial-brotli CONFIG REQUIRED)

Expected behavior
Brotli should be included in the project successfully and not trigger the unknown CMake command error
Failure
CMake Error at /path/to/vcpkg/installed/x64-linux/share/unofficial-brotli/unofficial-brotli-config.cmake:8 (_add_library):
  Unknown CMake command "_add_library".
Call Stack (most recent call first):
  CMakeLists.txt:13 (find_package)

Additional context
The file unofficial-brotli-config.cmake contains calls to the non-existant CMake command _add_library instead of add_library.
Manually changing the _add_library calls to add_library in the file /path/to/vcpkg/installed/x64-linux/share/unofficial-brotli/unofficial-brotli-config.cmake allow the project to find and include Brotli successfully.
Tested on Linux and Windows, and both experience the same fault.

User error.
You must set CMAKE_TOOLCHAIN_FILE before project is called the first time. (IMO it doesn'belong into project files at all.)

In my project build directory, when I do
cmake -DCMAKE_TOOLCHAIN_FILE=C:/repos/vcpkg/scripts/buildsystems/vcpkg.cmake ..
It still fails with
CMake Error at C:/repos/vcpkg/packages/brotli_x64-windows/share/unofficial-brotli/unofficial-brotli-config.cmake:4 (_add_library):
  Unknown CMake command "_add_library".
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.26/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  C:/repos/vcpkg/packages/cpprestsdk_x64-windows/share/cpprestsdk/cpprestsdk-config.cmake:7 (find_dependency)
  CMakeLists.txt:50 (find_package)

Any idea what I'm doing wrong?

I guess you didn't supply -DCMAKE_TOOLCHAIN_FILE=C:/repos/vcpkg/scripts/buildsystems/vcpkg.cmake on the first call to cmake. Restart with a clean build dir.

Thank you!

I have the same issue on Windows with Visual Studio 2022 after upgrading vcpkg (Unknown CMake command "_add_library") and I don't seem to be able to solve it. I started from scratch, so there is no old cache. Before I upgraded vcpkg everything worked fine.
I installed a clean version of vcpkg:
C:\> q:
Q:\> git clone https://github.com/Microsoft/vcpkg.git
Q:\> .\vcpkg\bootstrap-vcpkg.bat -disableMetrics
Q:\> cd vcpkg
Q:\vcpkg> vcpkg integrate install
Q:\vcpkg> vcpkg install cpprestsdk:x64-windows
Q:\vcpkg> vcpkg install argon2:x64-windows

I did a complete clone of my project and I have the following CMakePresets.json file:
{
  "version": 2,
  "cmakeMinimumRequired": {
    "major": 3,
    "minor": 20,
    "patch": 0
  },
  "configurePresets": [
    {
      "name": "x64-Debug",
      "displayName": "Windows x64 Debug",
      "description": "Sets Ninja generator, compilers, build and install directory, debug build type",
      "generator": "Ninja",
      "binaryDir": "${sourceDir}/out/build/${presetName}",
      "cacheVariables": {
        "VCPKG_ROOT": "Q:/vcpkg",
        "VCPKG_TARGET_TRIPLET": "x64-windows",
        "CMAKE_BUILD_TYPE": "Debug",
        "CMAKE_INSTALL_PREFIX": "${sourceDir}/out/install/${presetName}",
        "CMAKE_C_COMPILER": "cl",
        "CMAKE_CXX_COMPILER": "cl",
        "CMAKE_C_FLAGS": "/DWIN32 /D_WINDOWS /W3 /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake",
        "CMAKE_CXX_FLAGS": "/DWIN32 /D_WINDOWS /W3 /GR /EHsc /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake"
      },
      "vendor": {
        "microsoft.com/VisualStudioSettings/CMake/1.0": {
          "hostOS": [ "Windows" ]
        }
      }
    } ],
  "buildPresets": [
  ]
}

And my CMakeLists.txt file is:
set(NBS_TARGET NBS.API.Article)

cmake_minimum_required (VERSION 3.8)

set(CMAKE_CXX_STANDARD 20)

add_compile_definitions(NBS_API_PLUGIN_EXPORTS)

add_library(${NBS_TARGET} SHARED
  "../Generic/Include/Generic.h"
  "../Generic/Include/GenericCppRest.h"
  "../Generic/Include/NBS.API.HttpGeneric.h"
  "../Generic/Include/NBS.API.HttpListener.h"
  "../Generic/Include/NBS.API.HttpRequest.h"
  "../Generic/Include/NBS.API.HttpResponse.h"
  "../Generic/Include/NBS.API.Plugin.h"
  "../Generic/Include/NBS.PluginController.h"
  "../Generic/Include/NBS.API.PluginHttpListener.h"
  "../Generic/Include/NBS.API.RequestMethodFunctions.h"
  "../Generic/Include/NBS.API.RequestMethodHandlers.h"
  "../Generic/Include/ODBC.h"
  "../Generic/Include/OSDependent.h"
  "./Include/NBS.API.RequestMethodHandlersSpecific.h"
  "../Generic/Src/Generic.cpp"
  "../Generic/Src/GenericCppRest.cpp"
  "../Generic/Src/NBS.API.HttpGeneric.cpp"
  "../Generic/Src/NBS.API.HttpListener.cpp"
  "../Generic/Src/NBS.API.HttpRequest.cpp"
  "../Generic/Src/NBS.API.HttpResponse.cpp"
  "../Generic/Src/NBS.API.Plugin.cpp"
  "../Generic/Src/NBS.PluginController.cpp"
  "../Generic/Src/NBS.API.PluginHttpListener.cpp"
  #"./Src/NBS.API.PluginCMake.cpp"
  "../Generic/Src/NBS.API.RequestMethodFunctions.cpp"
  "../Generic/Src/NBS.API.RequestMethodHandlers.cpp"
  "../Generic/Src/ODBC.cpp"
  "../Generic/Src/OSDependent.cpp"
  "./Src/NBS.API.RequestMethodHandlersSpecific.cpp"
)

#add_library(NBS.API.PropertyGroup SHARED
#  "../Generic/Include/OSDependent.h"
#  "../Generic/Src/OSDependent.cpp"
#  "../Generic/Include/Generic.h"
#  "../Generic/Src/Generic.cpp"
#  "./Include/NBS.API.PluginCMake.h"
#  "./Src/NBS.API.PluginCMake.cpp"
#)

target_include_directories(${NBS_TARGET} PRIVATE
  "./Include/"
  "../Generic/Include/"
#  "../NBS.API.REST.SVR/Include/"
if(NOT WIN32)
  "/usr/include"
endif()
)

if(NOT WIN32)
  set_target_properties(${NBS_TARGET}
    PROPERTIES PREFIX ""
    LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/../bin/"
    RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/../bin/"
)
else()
  set_target_properties(${NBS_TARGET}
    PROPERTIES PREFIX ""
    RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/../bin/"
)
endif()

message("VCPKG_TARGET_TRIPLET = ${VCPKG_TARGET_TRIPLET}")

set(ZLIB_INCLUDE_DIR ${VCPKG_ROOT}/installed/${VCPKG_TARGET_TRIPLET}/include/)
if (MSVC)
  set(ZLIB_LIBRARY ${VCPKG_ROOT}/installed/${VCPKG_TARGET_TRIPLET}/lib/zlib.lib)
else()
  set(ZLIB_LIBRARY ${VCPKG_ROOT}/installed/${VCPKG_TARGET_TRIPLET}/lib/libz.a)
endif()

if(NOT WIN32)
  set(CMAKE_THREAD_LIBS_INIT "-lpthread")
  set(CMAKE_HAVE_THREADS_LIBRARY 1)
  set(CMAKE_USE_WIN32_THREADS_INIT 0)
  set(CMAKE_USE_PTHREADS_INIT 1)
  set(THREADS_PREFER_PTHREAD_FLAG ON)
  set(Boost_INCLUDE_DIR ${VCPKG_ROOT}/installed/${VCPKG_TARGET_TRIPLET}/include)
  find_package(Boost)
  if (Boost_FOUND)
    include_directories(${Boost_INCLUDE_DIR})
    add_definitions( "-DHAS_BOOST" )
  endif()
endif()

set(cpprestsdk_DIR ${VCPKG_ROOT}/packages/cpprestsdk_${VCPKG_TARGET_TRIPLET}/share/cpprestsdk/)
if(WIN32)
  set(unofficial-brotli_DIR ${VCPKG_ROOT}/packages/brotli_${VCPKG_TARGET_TRIPLET}/share/unofficial-brotli/)
endif()

message("cpprestsdk_DIR = ${cpprestsdk_DIR}")
#message("ZLIB_INCLUDE_DIR = ${ZLIB_INCLUDE_DIR}")
#message("ZLIB_LIBRARY = ${ZLIB_LIBRARY}")
#message("CMAKE_TOOLCHAIN_FILE = ${CMAKE_TOOLCHAIN_FILE}")
#message("CMAKE_MODULE_PATH = ${CMAKE_MODULE_PATH}")
#message("CMAKE_PREFIX_PATH = ${CMAKE_PREFIX_PATH}")
#message("unofficial-brotli_DIR = ${unofficial-brotli_DIR}")
#find_package(ZLIB REQUIRED)
#if(NOT WIN32)
#  find_package(OpenSSL REQUIRED)
#endif()

find_package(cpprestsdk REQUIRED NAMES cpprestsdk cpprest)
if(NOT WIN32)
  find_package(ODBC REQUIRED)
endif()

if(WIN32)
target_link_libraries(${NBS_TARGET} PRIVATE
                      cpprestsdk::cpprest
                      #cpprestsdk::cpprestsdk_zlib_internal
                      cpprestsdk::cpprestsdk_brotli_internal
                      odbc32
#                      odbccp32
)
else()
target_link_libraries(${NBS_TARGET} PRIVATE
                      cpprestsdk::cpprest
                      #cpprestsdk::cpprestsdk_zlib_internal
                      #cpprestsdk::cpprestsdk_brotli_internal
                      #OpenSSL::SSL
                      #OpenSSL::Crypto
                      odbc
)
endif()

I still get the following error:
1> [CMake] VCPKG_TARGET_TRIPLET = x64-windows
1> [CMake] cpprestsdk_DIR = Q:/vcpkg/packages/cpprestsdk_x64-windows/share/cpprestsdk/
1> [CMake] CMake Error at Q:/vcpkg/packages/brotli_x64-windows/share/unofficial-brotli/unofficial-brotli-config.cmake:4 (_add_library):
1> [CMake]   Unknown CMake command "_add_library".
1> [CMake] Call Stack (most recent call first):
1> [CMake]   C:/Program Files/Microsoft Visual Studio/2022/Professional/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.25/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
1> [CMake]   Q:/vcpkg/packages/cpprestsdk_x64-windows/share/cpprestsdk/cpprestsdk-config.cmake:7 (find_dependency)
1> [CMake]   NBS.API.Article/CMakeLists.txt:112 (find_package)
1> [CMake] -- Configuring incomplete, errors occurred!
1> [CMake] See also "F:/SharedFolder/Development/NBS.API.REST.SVR/out/build/x64-Debug/CMakeFiles/CMakeOutput.log".
1> 'C:\windows\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PROFESSIONAL\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DVCPKG_ROOT:STRING="Q:/vcpkg" -DVCPKG_TARGET_TRIPLET:STRING="x64-windows" -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:STRING="F:/SharedFolder/Development/NBS.API.REST.SVR/out/install/x64-Debug" -DCMAKE_C_COMPILER:STRING="cl" -DCMAKE_CXX_COMPILER:STRING="cl" -DCMAKE_C_FLAGS:STRING="/DWIN32 /D_WINDOWS /W3 /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake" -DCMAKE_CXX_FLAGS:STRING="/DWIN32 /D_WINDOWS /W3 /GR /EHsc /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PROFESSIONAL\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "F:\SharedFolder\Development\NBS.API.REST.SVR" 2>&1"' execution failed with error: ''C:\windows\system32\cmd.exe' '/c "%SYSTEMROOT%\System32\chcp.com 65001 >NUL && "C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PROFESSIONAL\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe"  -G "Ninja"  -DVCPKG_ROOT:STRING="Q:/vcpkg" -DVCPKG_TARGET_TRIPLET:STRING="x64-windows" -DCMAKE_BUILD_TYPE:STRING="Debug" -DCMAKE_INSTALL_PREFIX:STRING="F:/SharedFolder/Development/NBS.API.REST.SVR/out/install/x64-Debug" -DCMAKE_C_COMPILER:STRING="cl" -DCMAKE_CXX_COMPILER:STRING="cl" -DCMAKE_C_FLAGS:STRING="/DWIN32 /D_WINDOWS /W3 /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake" -DCMAKE_CXX_FLAGS:STRING="/DWIN32 /D_WINDOWS /W3 /GR /EHsc /D_CRT_SECURE_NO_WARNINGS /DVCPKG_TARGET_TRIPLET=x64-windows /DCMAKE_TOOLCHAIN_FILE=Q:/vcpkg/scripts/buildsystems/vcpkg.cmake"  -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PROFESSIONAL\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "F:\SharedFolder\Development\NBS.API.REST.SVR" 2>&1"' returned with exit code: 1'.

@zoenie123 Your CMakeLists.txt lacks the project command. It should be after cmake_minimum_required.


Initial packaging

From<EMAIL_ADDRESS>This can't really fit in our packing infrastructure because there's no source code, just a binary script. This is ok, we can have these "special" packages like this, as they're mostly slow-changing.
Related-to: TCCP-21

Hi, sorry for being a little late for the party.
I tried to build the package via the regular sbuild and got no luck:
sbuild log
dpkg-buildpackage
-----------------

Command: dpkg-buildpackage --sanitize-env -us -uc -rfakeroot
dpkg-buildpackage: info: source package libgpuperfcnt
dpkg-buildpackage: info: source version 6.4.3
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Leonardo Held<EMAIL_ADDRESS> dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
 dpkg-source -b .
dpkg-source: warning: no source format specified in debian/source/format, see dpkg-source(1)
dpkg-source: info: using source format '1.0'
dpkg-source: info: building libgpuperfcnt in libgpuperfcnt_6.4.3.tar.gz
dpkg-source: info: building libgpuperfcnt in libgpuperfcnt_6.4.3.dsc
 debian/rules build
dh build
 fakeroot debian/rules binary
dh binary
 dpkg-genbuildinfo -O../libgpuperfcnt_6.4.3_amd64.buildinfo
dpkg-genbuildinfo: error: binary build with no binary artifacts found; .buildinfo is meaningless
dpkg-buildpackage: error: dpkg-genbuildinfo -O../libgpuperfcnt_6.4.3_amd64.buildinfo subprocess returned exit status 25
--------------------------------------------------------------------------------
Build finished at 2024-01-16T13:38:18Z

I saw the workflow to build the package is working, so I wonder what was the build command that made it work for you - it would be nice to document it in a README.Debian file.

You can get rid of the debian/compat file declaring a build dependency on debhelper-compat (=13) in the debian/control file.

A long description in debian/control is a nice to have, though completely superfluous in this case. Something in the lines of the pkgconfig would work "Abstraction library used to retrieve HW counter values, and registers from Vivante/VSI GPU drivers".

Declaring source package level 3 compatibility is important (creating debian/source/format with 3.0 (quilt)) is important because it defaults to version 1.0 (which is very much legacy by now) when nothing is declared.

Usually on Debian we break down libraries in two packages, a -dev with the header files and .so symlink and another ending with the major so version. In this case would be libgpuperfcnt1 and libgpuperfcnt-dev packages.

Are we having the symbols files for this one?

the pkgconfig provided by NXP seems buggy, should/do we care?


GH-5050: add netty dependency management to fix CVEs

GitHub issue resolved: #5050
Briefly describe the changes proposed in this PR: add dependency management for netty dependencies

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@barthanssens PR is approved a few days ago. Feel free to merge a PR when it's been approved :)


[Relay][VM] Fix constant folding issue in VM compiler

This speeds up mxnet resnset18 by 4x because it fixes constant folding. Now vm is just
1.4x slower than relay graph runtime.

allow pass params when compile a module
enhance profiler robustness

cc @jroesch @zhiics @icemelon9

Is the performance now caused by pass or vm related things, like dispatching and memory allocation?

Is the performance now caused by pass or vm related things, like dispatching and memory allocation?

Yes. Most of the time spent other than packed function execution are AllocTensor and LoadConst. @icemelon9 told me to switch to pooled allocator and it improved the 2 instruction significantly(by 5x).

@wweic That's sounds cool at some extent. @jroesch's memory pass should help.


AttainmentGrade vs CourseResult

Evaluate whether CourseResult is necessary and whether it could be replaced by AttainmentGrade completely.

CourseResult could be changed into a smaller table referencing the grade of a root attainment with any extra information needed for the final grade.


[Event Request] table 5965  "Service Contract Header" - OnBeforeCheckContractLinesExist

Hello, would it be possible to add OnBeforeCheckContractLinesExist,  event to table 5965  "Service Contract Header", like this:
        field(7; "Customer No."; Code[20])            trigger OnValidate()
...
              begin
                 Cust.Get("Customer No.");
                 if "Customer No." <> xRec."Customer No." then begin
                     IsHandled := false;
>                     OnBeforeCheckContractLinesExist(Rec, IsHandled); //New Event
                     if not IsHandled then
                         if ContractLinesExist() then
                             case "Contract Type" of
                                 "Contract Type"::Contract:

     [IntegrationEvent(false, false)]
     local procedure OnBeforeCheckContractLinesExist(var ServiceContractHeader: Record "Service Contract Header"; var IsHandled: Boolean)
     begin
     end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10531.


Scroll position not working correctly

I know that the Length of dataTabs and dataSections must equal. I am using the simple example provided but the tabs are actually scrolling to child elements position and not the sections. Any ideas why? Thanks.

I don't understand what your problem is. Can you provide more detail,
Remember to include your react native, expo, scrollable-tabstring version you are using.
Happy hacking !

Hi @faisalhok,
Please be more specific. I don't understand what your problem is.

Same to me, using react native 0.63 and more than 2 tabs, the calculation simple does not work.


Add Swift Argument Parser 1.3.0

https://github.com/apple/swift-argument-parser/releases/tag/1.3.0

Hello @keith, @jpsim, modules you maintain (swift_argument_parser) have been updated in this PR. Please review the changes.

I assume apple/swift-argument-parser needs to provide a stable source code archive as part of their release first ...

we can use the label added here to skip that check instead. I think trying to change the apple release process for these libraries is probably too hard to be worth it.


[Bug] CRUD operation configs do not fall back to vendor value?

Bug report
What I did
When testing https://github.com/Laravel-Backpack/CRUD/pull/3616 I noticed that if you are missing an operation config value in config/backpack/crud.php, but it's present in vendor/backpack/crud/src/config/crud.php, it will NOT fall back to the one in the vendor.
Rephrased:

app config file does NOT have create.warnBeforeLeaving
vendor config file DOES have 'create.warnBeforeLeaving' => true
the result of $crud->get('warnBeforeLeaving') seems to be false

What I expected to happen
The result of $crud->get('warnBeforeLeaving') to be true
What happened
Maybe something got broke when falling back to the default config? Maybe it doesn't nest deep enough?
What I've already tried to fix it
Nothing yet, currently deep into other stuff - should investigate.
Backpack, Laravel, PHP, DB version
4.2

Ouch - turns out that Laravel's mergeConfigFrom() in the BackpackServiceProvider is where it all goes wrong. It only falls back in level-one... which actually makes sense, because there's no way to know if an array of configs is... an array of stuff (['one', 'two', 'three']), or just a subset configuration (['do_that' => true, 'do_something_else' => false]).
We can do two things to fix this:

OPTION 1) use our own logic instead of mergeConfigFrom(), where we tell it WHERE to go deeper than level one; but that would make the config files less intuitive;
OPTION 2) move each operation config into its own file:

config/backpack/operations/list.php
config/backpack/operations/create.php
config/backpack/operations/update.php
config/backpack/operations/show.php
config/backpack/operations/reorder.php

I think OPTION 2 is the one to go with. Not sure if we should do this in 4.2 or 5.0... If it's a MUST or a SHOULD at this point in time.

Ok so I've decided we should do this now (4.2.0), and I've put together a PR - see https://github.com/Laravel-Backpack/CRUD/pull/3986
@pxpm / @promatik I'm pretty sure of the implementation, but I'd love if one of you could take a look, maybe you spot something I didn't, or see a reason why we shouldn't do this 🤷♂


[GA] [installer] rpm - package ballerina-platform-0.970.0.beta19-1.x86_64 (which is newer than ballerina-platform-0.970.0-1.x86_64) is already installed.

Description:

installer beta19 has already installed
install ballerina as below => log prints

[root@ballerinaonrethat3 ballerina]# rpm --install ballerina-platform-linux-installer-x64-0.970.0.rpm
package ballerina-platform-0.970.0.beta19-1.x86_64 (which is newer than ballerina-platform-0.970.0-1.x86_64) is already installed

Env:
rhel 7.3 | oracle jdk 1.8.0_161
ballerina-platform-linux-installer-x64-0.970.0.rpm

Outdated hence closing


Fix variable expansion in CreateLink

Pass data in as-is, instead of calling .ToString() to allow enumerable and dictionary handling
Simplified the URI template class to reduce nesting and treat all objects not otherwise handled as a string
Added unit tests for a bit more of the bizzare behaviour when using invalid data, so at least we know it's happening

Thanks for this update, merged in now


Map not displaying anymore...

Hey, I have been using this template for a while, thank you btw I love it. All of a sudden the map stopped displaying, instead it is just the background grey colour. This isn't due to a change I have made, this problem exists in your template. Maybe Google changed something?

Hello, I think there was an issue with Google map, it's working fine now, do check from your end. I would also suggest you generate your own Google map API key to use on your website, there are too many request made from the included demo key and it might exceed the daily usage limit of Google map API without warning.

Yes the first thing I did was generate my own API key because I thought that might have been the issue. It's seems to be working fine now, must have been Google's issue. Thanks for taking a look.