Home Assistant live streaming no longer working with new rRTSPServer v0.1.5

Hi @roleoroleo,
I have an issue with the new rRTSPServer that comes with release v0.1.5 with my y21ga camera.
Home Assistant live streaming no longer working with the Home Assistant app, Google Chrome, Brave but DO works with Firefox Browser.
Enough just to replace rRTSPServer from v0.1.4 and everything works correctly.
Please, let me know how can I help to resolve this bug.
Thanks a lot for your hard work!
p.s. If it helps... I have also 4 MStar cameras that also running the latest v0.4.0 release and they are working fine.
So seems like Allwinner-v2 specific issue.

I have a problem too with RTSP in HA:
https://github.com/roleoroleo/yi-hack-Allwinner-v2/issues/116#issuecomment-808949830

@mcanteri ONVIF itself works fine for me.

@mcanteri ONVIF itself works fine for me.

I don't use ONVIF, what is the relevant benefit of use it since down under it uses RTSP anyway ?

I am also not using ONVIF with HA but an FFmpeg camera integration.

Me too, as you can read my configuration in the other thread, some comment above:
https://github.com/roleoroleo/yi-hack-Allwinner-v2/issues/118#issuecomment-808950616
Simple ffmpeg integration that let you configure and fine tune with all the option available :+1:

There are a many NVRs where you can't set rtsp input but only onvif.
Getting back to the problem, I can't reproduce it as described here: https://github.com/roleoroleo/yi-hack-Allwinner-v2/issues/116#issuecomment-808957611

I move forward by attempts.
With this beta release you can remove timing info (added in the last versione) from stream.
Please try if it works:
rRTSPServer.gz

Thanks @roleoroleo!
Just have tried, same result, playing in Firefox, not playing in Chrome/Brave/etc...
Do I need to use some flags to run it?
Currently i am testing it by just dropping new beta into the bin folder and running ~/bin# ./rRTSPServer_beta1

No, default is without timing info.

Could try this binary?
I fixed a little bug.
Uploading rRTSPServer.gz…

@roleoroleo same issue. :(

Please try again adding -s option.
And "-d 3" option to increase the log.

I've attached two logs.
Same code base v0.1.5 different rRTSPServer servers (latest beta that you sent beta_2 and from v0.1.4 release).
beta_2.log.zip
0.1.4.log.zip

The logs are ok.
I don't understand.

let me try to find ffmpeg options that HA running with so you will be able to reproduce it yourself.

@roleoroleo (for info) I've just restarted manually the original rRTSPServer on the second cam (AllWinner-v2) and I got a segmentation fault as below :
1617046444098: frame detected - frame_len: 8 - frame_counter: 58345 - frame_counter_last_valid: 58345 - resolution: 1080
1617046444098: frame_len: 8 - cb_current->size: 262144
1617046444098: frame_len: 8 - frame_counter: 58345 - resolution: 1080
1617046444098: frame_write_index: 31 - cb_current->output_frame_size 42
1617046444098: frame detected - frame_len: 16408 - frame_counter: 58346 - frame_counter_last_valid: 58346 - resolution: 1080
RTSP doGetNextFrame() whole frame - fFrameSize 855 - counter 58343 - fMaxSize 262140 - fLimitNumBytesToStream 0
RTSP doGetNextFrame() - whole frame completed
RTSP doGetNextFrame() start - fFrameSize 262140 - fMaxSize 262140 - fLimitNumBytesToStream 0 - fPreferredFrameSize 0
RTSP doGetNextFrame() read_index == write_index
1617046444124: frame_len: 16408 - cb_current->size: 262144
1617046444124: frame_len: 16408 - frame_counter: 58346 - resolution: 1080
1617046444124: frame_write_index: 32 - cb_current->output_frame_size 42
1617046444124: frame detected - frame_len: 812 - frame_counter: 58344 - frame_counter_last_valid: 58344 - resolution: 360
1617046444124: frame_len: 812 - cb_current->size: 49152
1617046444124: frame_len: 812 - frame_counter: 58344 - resolution: 360
1617046444124: frame_write_index: 29 - cb_current->output_frame_size 42
1617046444124: SPS   detected - frame_len: 19 - frame_counter: 58345 - frame_counter_last_valid: 58345 - resolution: 360
1617046444124: frame_len: 19 - cb_current->size: 49152
1617046444124: frame_len: 27 - frame_counter: 58345 - resolution: 360
1617046444124: frame_write_index: 30 - cb_current->output_frame_size 42
1617046444124: frame detected - frame_len: 8 - frame_counter: 58346 - frame_counter_last_valid: 58346 - resolution: 360
RTSP doGetNextFrame() whole frame - fFrameSize 808 - counter 58344 - fMaxSize 262140 - fLimitNumBytesToStream 0
RTSP doGetNextFrame() - whole frame completed
RTSP doGetNextFrame() start - fFrameSize 262140 - fMaxSize 262140 - fLimitNumBytesToStream 0 - fPreferredFrameSize 0
RTSP doGetNextFrame() whole frame - fFrameSize 23 - counter 58345 - fMaxSize 262140 - fLimitNumBytesToStream 0
Segmentation fault (core dumped)

I will try to use your AllWinner-v2 patched rRTSPServer  in debug (3) mode. I keep you informed

Ok I've found the way to reproduce it with FFmpeg.
Download this Chrome extension, so you will be able to play HLS natively in Chrome/Brave Browser: https://chrome.google.com/webstore/detail/play-hls-m3u8/ckblfoghkjhaclegefojbgllenffajdc
Run Following FFmpeg command:
./ffmpeg -rtsp_transport tcp -i rtsp://username:password@<IP_ADDRESS>:554/ch0_0.h264 -vcodec copy -acodec aac -movflags +faststart -master_pl_name master_playlist.m3u8 -hls_segment_type fmp4 -hls_list_size 2 -hls_init_time 1 -hls_time 1 -hls_flags delete_segments -hls_segment_filename "segments/%d.m4s" "segments/playlist.m3u8"
Run some kind of HTTP server, I am using Mac and running the following command python -m SimpleHTTPServer 8080 from the folder where FFmpeg creating segments.
After that try to play master_playlist.m3u8 in Chrome/Brave.
http://localhost:8080/segments/master_playlist.m3u8
You will see that browser will retrieve the first 2 chunks and after that will continue retrieving only playlist.m3u8 but not chunks.
Once you will return to rRTSPServer from v0.1.4 everything will run smoothly.
I hope it helps.

It was an option of the live555 library.
Probably the Chrome extension is not so "standard".

@roleoroleo I don't think it's related to the extension itself, Chrome, Safari, and HA iOS app was not able to play. Maybe something related to AppleWebKit HLS implementation. Firefox not using it.
Latest MStar version using the same live555 version as Allwinner-v2? Because my 4 MStar cameras are running fine.

Is the same version of the lib but MStar doesn't use FramedSource and, in this case, the option is not available.
MStar will work without this problem.

Please try this binary:
rRTSPServer.gz

Tested and is working for me too, thank you @roleoroleo !

@roleoroleo the new rRTSPServer works perfectly on my cam too 👍  Thanks !

Home Assistant live streaming again no longer working with new update v0.1.6
(This issue was fixed before, in 0.1.5, with the binary you attached)

@DaniJulia working fine for me with v0.1.6.

The fix is correctly committed and compiled.

Only out of curiosity: After "on-line" upgrade, indeed, all cameras stop sending video to Home Assistant.
However, after a "clean" install of the new firmware, everything is Ok.
Thank you SO MUCH for you work!!

BTW, @roleoroleo, please forgive me because I know that this is not the place where to ask this... if you can, please delete this message as soon as you read it (I will anyway).
I want to ask you if you have any kind of profile place, with any kind of patreon, paypal, or similar, to accept contributions? I really would like to buy you a beer from time to time.

The upgrade procedure is a complex task. Sometimes maybe something goes wrong.
There is a paypal link in the main page of this repo.
A beer is greatly appreciate .


Parse arbitrary RLPs.

Decompose an arbitrary RLP into a list of items.
Additionally, fix two bugs in decompose_rlp_array_phase0() and decompose_rlp_array_phase1(), and add several tests.

Replaced by https://github.com/axiom-crypto/axiom-eth/pull/24


Wikipedia (or possibly other web-pages) as new source-type: Frontend

Separate source for loading Wikipedia sources (similar to youtube)

Completed and merged


update to new schema

Fixes # .
Changes proposed in this PR:

I will add more compute tests shortly

since this is not needed for our push, let's keep it until I will fix the provider for compute


Dcarpente/small samples fix compressed

This change changes GetNextSample to only enforce minimum duration for uncompressed samples. Combining multiple packets for compressed samples can result in loss of data. This should fix issue #161.

@dcarpente,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks @dcarpente

@dcarpente,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Fix virtualenv-clone with Python 3.12

virtualenv-clone has a list of Python versions that it uses for its tests. That list does not include Python 3.11 or 3.12. The upstream repo has a fix for that issue - but the project hasn't made a new release with that change. There was already a fix for Python 3.11 - we just extend the fix to include Python 3.12.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@natsukium Thanks! I think I addressed the issue with the commit message.


chore: update snippets to v7.0.0

Update snippets for Maps SDK for iOS and Places SDK for iOS v 7.0.0 release

Are you still working on a fix for the failing test?


Probes and PDB support

Adds support for readiness and liveness probes
Adds support for PDB

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

30 of 39 (76.92%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 68.008%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

controllers/instance/instance_controller.go
1
3
33.33%

controllers/instance/pod_disruption_budget.go
27
34
79.41%

Totals

Change from base Build<PHONE_NUMBER>6:
0.2%

Covered Lines:
1318

Relevant Lines:
1938

💛  - Coveralls

lgtm


Develop/web 12393: Fix broken tests + add sync + send in tracker emitter

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


Replace rubocop with cookstyle in lint

This change will execute cookstyle tests instead of rubocop in the lint phase, provided that cookstyle is installed on the builder/runner. If it is not, the rubocop functionality will occur instead.
Fixes #24

After further review, I realized that we need to have cookstyle be opt-in (at least for a while) since this change will cause a lot of people's pipelines to start failing (since they may not have been running rubocop already). I am going to close this PR, add the config capability, and will re-submit.


400 on single change creation

Interesting nobody reported this, even in production (gasp).
When adding multi mode, I created a problem by making the form field multi on /a/changes/new mandatory, making it fail in a weird way (400 somehow). This was already fixed in f4f90be, so this bug is purely housekeeping.
The production clients had this rolled out immediately after discovery (version 1.1.2b), so if you weren't, a bugfix release is coming.

:tada:


[Legacy DB] Drop Site log tables (more in desc)

Drop these table, not being used anymore

site_log_files
site_event_log
site_data_log_tech_types
site_data_log_plug_types
site_data_log_health_types
site_data_log
site_connection_types
site_connection_log
site_aggrs

Approved!


No Matches Found / Loading

Please make sure that you have checked the boxes:

[x] Review the Quickstart guide
[x] Search for both open and closed issues regarding the problem you are experiencing
[x] For permissions issues (Access Denied and credential related errors), please refer to the requisite docs before submitting an issue:
AWS, GCP, OpenStack, GitHub

Description of issue:
I done all setup of "security_monkey" on aws but its showing "No matches found" at all places or "Loading" on dashboard. Attached screenshots. I've already gone through above Quickstart multiple times but didn't find any solution. How would I ensure I've it's all setup correctly?

This is the same issue that I have encountered. Try monkey run_api_server.

@Leectan I've already tried it (attached PoC)

monkey run_api_server

I believe it has to do with the scheduler and supervisor not fetching any data, I'm figuring this out as well.

I would suggest the autostart guide, I was able to run the monkey run_api_server command after the guide.

@cloudtrace the last step of quickstart guide pretty much sums up everything to automatically fetch the data (although I'm having an issue myself calling monkey run_api_sever), but after you run
 you should be able to see the status of the supervisor that says running.

I noticed that it takes time to fetch data in security monkey. After setup, make sure to wait for sometime and you will notice data (if all is setup). Closing issue. thanks @Leectan for quick help.

@cloudtrace np, glad you got that figure out.  It's almost been 24 hours for me and I've not seen a single data coming yet.

@Leectan Did you run monkey find_changes? Does that fetch anything?
Also, enable debug logging (see the troubleshooting guide) and verify the configuration of your scheduler and workers.


Bug Report: Camera zoom not going back

When the camera zoom to the beat is on, it doesnt go back to its previous position. making it infinitely zoom in.

known bug. Ill fix in a few hours or less

ok because i actually want to play around with this engine and maybe make amod with it

play the actions build once its done


On open channel spinner my fan is going crazy

Thanks for filing a bug report :-)
Steps to Reproduce

Navigate to https://lightclient.raiden.network/staging/
Select a hub
Enter deposit
Click on "Open Channel"

Expected Result

My computer stays silent

Actual Result

My fan is running and GPU is at ~95%

Maybe the spinner (Vue-Component?) is killing the GPU?

Additional Infos (Optional)
- Firefox

Definitely a thing :) #1434

Hey @nephix! Nice to see you being around ☘

Assuming that this is caused by the animation indeed, I don't see how we could fix it other than removing the progress spinner.

Would be fine for me to either delete or replace it.

My experience so far is that animations of any kind will not perform properly on the web, depending on the combination of hardware and software. You can see a couple of people opening similar issues in Vuetify's repo.
Deleting it would not make sense. we still have to show something to the user when they are waiting. But if we go with animated content there is an absolute certainty that they won't work properly everywhere.
One idea would be to use some kind of animated image with transparency instead. But rasterized animated content with transparency can be tricky to get right.

We could show the following
Waiting for the transactions to be confirmed - Block Number: ####
The Block Number would increment and would show the user that something is happening.
In the future we could do something like we did for the transactions.

As a quickfix we could use the bar, which we have on the transfer in progress modal
(I wasn't quick enough taking a screenshot)


Support ECDSA private keys in addition to RSA keys.

Description
The cookbook currently supports only RSA private keys when importing private key credentials into Jenkins. This PR allows the use of ECDSA private keys in addition to RSA private keys.
Care has been taken to ensure that the cookbook behaves in a backwards-compatible manner should it be presented unexpected input - specifically, it will fall back to the assumption of an RSA key even if an RSA key is not specified.
Issues Resolved
None
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@don-code

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Regarding the checklist:

Integration tests pass against the last non-2.x Jenkins LTS (1.651.3). As said tests don't pass off a clean master otherwise, this seems out of scope for this PR.
I don't consider this documentation-worthy for the README, as it's not explicitly called out that only RSA keys are suppored by the cookbook despite ECDSA keys being supported within Jenkins.

Thanks for adding this


LE Audio: Use bt_codec_data data and size_t data_count in codec.c

Is your enhancement proposal related to a problem? Please describe.
When receiving a base in broadcast samples I want to be able to use the functions described in codec.c to get codec information like frequency, frame_duration etc, but the functions there all require bt_codec to be sent. As far I've seen, the bt_codec is not necessarily populated for a given subgroup, only the bis_data is.
Describe the solution you'd like
To avoid having duplicated code for getting this information these functions should accept bt_codec_data *data and size_t data_count.

Closing as the new API from https://github.com/zephyrproject-rtos/zephyr/pull/58331 and https://github.com/zephyrproject-rtos/zephyr/pull/58079 indirectly fixed this


Issue #ALL-000 fix: Updated correct image.

Summary by CodeRabbit

New Features

Enhanced audio playback management to prevent simultaneous tracks.
Updated asset references for correct answer images.

Bug Fixes

Improved error handling for missing audio elements.

Refactor

Streamlined game outcome handling and audio playback logic.

Documentation

Updated PropTypes for the MainLayout component.

Need to correct the image issue in next build - merging for now


Publish a CWU opportunity without a GitHub url

Current: Any text in the GitHub repository field will allow an opportunity to be published. The first time you are denied and get a notification that you can't publish because the repo url is wrong, but if you hit publish again it publishes.

We can talk about this one on what's right

This issue has been resolved


Same IP of HostOnly Controller after restart

Docker Toolbox 1.9d
Docker version 1.9.0, build 76d6bc9
docker-machine.exe version 0.5.1 (7e8e38e)
Windows 8.1 64bit
I followed exactly the tutorial to get a multi host network: https://docs.docker.com/engine/userguide/networking/get-started-overlay/
First time everything worked fine, but after I stopped and started all there machines again every machine created a new host-only controller and all get the same IP.
docker-machine ls
NAME         ACTIVE   DRIVER       STATE     URL                                    SWARM
demo-master    -        virtualbox   Running   tcp://<IP_ADDRESS>:2376   demo-master (master)
demo-node01   -        virtualbox   Running   tcp://<IP_ADDRESS>:2376   demo-master
keystore            -        virtualbox   Running   tcp://<IP_ADDRESS>:2376
I think this is a bug! Maybe anyone else could test this
update: I maybe have a explanation why this happens. I have multiple HostOnly Adapters and the machines where first time started with HostOnly#5. At restart the machines don't use this Adapter they created a new for every single machine.
And I get this error:
Error running connection boilerplate: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:3376": dial tcp <IP_ADDRESS>:3376: i/o timeout
You can attempt to regenerate them using 'docker-machine regenerate-certs name'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

Fixed in https://github.com/docker/machine/pull/2797


#214 - remove references to Cocoapods 0.39

I signed it!

Hello, thanks for sending this PR. Could you elaborate on the reason behind it? Is this in reference to https://github.com/google/EarlGrey/issues/214 ?

Did you try:

If you don't want a gem dependency, replace require 'earlgrey' with load 'configure_earlgrey.rb' and manually copy configure_earlgrey.rb from the gem into the same directory as the Podfile.

@gurgeous, thanks for this, but we don't want to remove the old Podfile section just yet. Remember, you can still use EarlGrey with your 0.38 or so, just without the gem.
I'd recommend adding a change similar to what @bootstraponline stated in Point 2 here -
https://github.com/google/EarlGrey/blob/master/docs/install-and-run.md#step-2-add-earlgrey-as-a-framework-dependency
You could change it to -

Because EarlGrey must be embedded within the app under test, we need to add certain Build Phases and Scheme changes to the Test Target. We recommend using our earlgrey gem to install any dependencies if you're using a CocoaPods version from 1.0.0 onwards. Run gem install earlgrey. You need to require this gem in a post_install hook using the project's name, the test target's name, and the name of the xcscheme file as is shown in the below example for 1.0.0

You can move this passage to above the 0.39.0 example -

Since the earlgrey gem is supported only beyond CocoaPods 1.0.0 or if you don't want a gem dependency, replace require 'earlgrey' with load 'configure_earlgrey.rb' and manually copy configure_earlgrey.rb from the gem into the same directory as the Podfile.

How about this?

better?

Looks good. :+1:

Merging this. Thanks Adam!


Creation of backup-instance for Blob Storage Containers needs clarification

Type of issue
Missing information
Feedback
The issues mentioned in https://github.com/Azure/azure-cli-extensions/issues/7499 can be avoided in the future by providing guidance on how to chain the commands az dataprotection backup-instance initialize-backupconfig and az dataprotection backup-instance initialize when setting up vaulted backups for blob storage containers.
The current docs mention
--backup-configuration
Backup configuration for backup. Use this parameter to configure protection for AzureKubernetesService.

The docs could mention how to generate the backup-configuration for blob containers. The fact that AzureKubernetesService are mentioned explicitly suggests to the reader that this parameter is not relevant for other use-cases.
Page URL
https://learn.microsoft.com/en-us/cli/azure/dataprotection/backup-instance?view=azure-cli-latest#az-dataprotection-backup-instance-initialize-backupconfig
Content source URL
https://github.com/MicrosoftDocs/azure-docs-cli/blob/main/latest/docs-ref-autogen/dataprotection/backup-instance.yml
Author
@dbradish-microsoft
Document Id
463aa6af-5d08-2929-b244-6abfc9baf3b2

@Salazander
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

@AbhishekMallick-MS, In looking for az dataprotection backup-instance%, it looks like you have written the following conceptual articles that use this command prefix:

https://github.com/microsoftdocs/azure-docs-pr/blob/main/articles/backup/azure-kubernetes-service-cluster-backup-using-cli.md
https://github.com/microsoftdocs/azure-docs-pr/blob/main/articles/backup/azure-kubernetes-service-cluster-restore-using-cli.md
https://github.com/microsoftdocs/azure-docs-pr/blob/main/articles/backup/backup-blobs-storage-account-cli.md
https://github.com/microsoftdocs/azure-docs-pr/blob/main/articles/backup/backup-managed-disks-cli.md
https://github.com/microsoftdocs/azure-docs-pr/blob/main/articles/backup/backup-postgresql-cli.md
https://github.com/microsoftdocs/azure-docs-pr/blob/main/includes/blob-backup-prepare-request-cli.md

The only doc that uses az dataprotection backup-instance initialize-backupconfig is for AKS. Can you please implement the customer request for one of the Azure Blob articles?

@Salazander, your request has been passed to the PM group for az dataprotection backup-instance. I've also created a GitHub issue in Azure/azure-cli 30499 requesting more reference examples, specifically for blob containers. Please place additional comments in this new GitHub issue so the engineering team can be automatically notificed.


Router version bump

Saw a few outdated package while reading the code
-cached = { version = "0.44.0", optional = true }
+cached = { version = "0.45.0", optional = true }
-lru = { version = "0.10", optional = true }
+lru = { version = "0.11", optional = true }
NB gloo_net needs updating but that would take bigger refactoring as the raw response is now private.

Thanks very much!


fix typescript installation note

Typescript does not recognize the type if it's imported in a JavaScript file. Therefore tests/test-helper.js has to be renamed to tests/test-helper.ts.
Fixes #108

Wasn't sure how to review your PR - I've added my own which I think says the same thing more succinctly.


more coverage

start_vent_collector was not fully covered, try-except was hiding some failures.

Codecov Report

Merging #391 into master will increase coverage by 0.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   97.15%   97.51%   +0.36%
==========================================
  Files          25       25
  Lines        1653     1653
  Branches      100      100
==========================================
+ Hits         1606     1612       +6
+ Misses         26       20       -6
  Partials       21       21

Impacted Files
Coverage Δ

poseidon/poseidonMonitor/poseidonMonitor.py
94.69% <100%> (+2.35%)
:arrow_up:

poseidon/poseidonMonitor/test_poseidonMonitor.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e5df2...97e8948. Read the comment docs.


Fix first app startup: Get nextPhaseTimestamp once before we subscribe to it.

Closes #1152

This fixes the integration tests for #1111. However, I don't understand why this is suddenly a problem. According to my understanding the integration tests should have been broken ever since.

This was actually a bug that was only introduced in #1111


Timeout for WinRM

Ran the script overnight, and both vmware-iso and virtualbox-iso timed out waiting for WinRM.

@luciusbono The script can't read the product key from the autounattend.xml file.  I've tried 3 different autounattend.xml files and none of them will work.

@luciusbono Welp, now it still times now waiting for WinRM

Thanks for bringing this up, and sorry for the long delay (this is a side project for me). Turns out the Autounattend.xml file was totally borked, but it's all fixed up now.


Feature Recommendation: Cache Prefetchers

This pull request is a proof of concept looking for an opinion on whether MapProxy should provide prefetchers as a feature. If by the end of this pull request the feature seems like a good fit, I’ll gladly edit, document, and test the code before any merge into MapProxy.
What is a prefetcher: A prefetcher sits between a request and a cache in MapProxy. It modifies incoming requests to request additional tiles. A very simple prefetcher, like expander in this pull request, ensures that all tiles surrounding a requested tile are cached. More advanced prefetchers like Previous K Movements (PKM), and Retrospective Adaptive Prefetch (RAP) use heuristics to cache predicted future tiles based on previous tile requests. Many additional algorithms also exist with varying degrees of success.
Why use a prefetcher: There are several common tile prefetching algorithms that all attempt to minimize tile cache misses. Depending on workflow and source latency, prefetchers can provide the requesting client with a huge increase in responsiveness. Research shows that in common map tasks, such as navigation and web map interaction, requests are quite predictable. I simulated a prefetcher known as Global User-Driven Prefetching and Caching (GUCD) and found for a multiuser tile-cache with MapProxy I experienced a 15% speedup (I’m happy to share the data/code if you are interested).
Why should MapProxy support prefetchers: Integrating prefetchers into MapProxy would give users an easy way to improve performance under many common use cases. In addition, with the way prefetchers are currently setup in the pull request, existing configurations don’t change if a user doesn’t want any prefetchers.
Pull Request Summary:
At this stage there is one implemented prefetcher, expander. Expander’s expansion_amount determines the radius of tiles from the requested tile that should be cached when a tile request is made. A prefetcher can be configured to effect multiple caches and any cache can have multiple prefetchers. If this seems like something good for MapProxy just let me know and I’ll start writing tests, documentation, and additional prefetcher options.
Working Sample Configuration: pastebin

Thanks for your work. However, I'm not convinced that this feature is worth the added complexity.
The "expander" will always load 9 tiles instead of 1 tile for WMTS requests, right? The client needs to wait if one of the tiles is missing, even if it is not the requested tile.
For missing tiles, MapProxy already does some kind of "expanding" with the meta tile feature.
Also, more advanced prefetchers are hard to implement because MapProxy uses multiple processes when run with mod_wsgi, gunicorn, etc. and these processes can't directly share state.

closing due to inactivity, feel free to reopen


added support for binary sockets

we added support for binary websocket, we hope it meets your approval, in case there are any concerns please let us know and we will revert

sorry forgout to push the latest commit


Unable to access boards

Looking at the documentation on Boards - https://docs.jiracli.com/#general_boards there is nothing clear on how to access a particular board. As it stands the jira command on lists all issues without the ability to filter based on status and I think that being able to view by boards would be useful.

@apowell656 you're right, I'll find some time next month to add the pending new features including this one :)


Make the user have an option of whether they want magicseaweed or swellinfo forecasts

They can choose between the two. This only changed the forecasts tab view, not the live page

No option, getting rid of swelling


A fourth breakpoint.

Can this lib. by any means supports more than 3 breakpoints (including the one before all of them xs) ?

It's now possible in 1.0.0! 🎉 Use breakpoints prop in <Grid.Provider>.
According to README:
breakpoints: { key: [int, int] } - structure: { name: [min, max]}
Defining breakpoints gives you strong control over the way your content is rendered at various screen sizes. Any property that can be set on Grid.Box can be set per-breakpoint. Here's a few things to keep in mind when defining breakpoints:

Breakpoints can be named whatever you'd like (with a few exceptions laid out in the next section)
When defining breakpoints, you must pass an array object containing only two values: the min and max (both must be integers)
Breakpoints can have overlapping values. Use responsibly though, as it's possible to produce unexpected results when setting conflicting values on a Grid.Box with overlapping breakpoints. i.e. if mobile and tablet have overlapping pixels, don't make a Grid.Box hide on mobile and show on tablet.

@mandriv I gotta update that part of the readme, there's actually a different syntax for breakpoints.
An example would look like this:
<Grid.Provider breakpoints={{ mobile: "-500", laptop: "750-1000'", wide: "+1200" }}></Grid.Provider>

The language is basically:

-500 == 500px or less
750-1000 == 750px - 1000px
+1200 == 1200px or greater

Horay!! Thanks a lot guys, appreciate the good work so much ❤

@yasserhennawi if you upgrade to hedron@next and run into any issues, either open an issue here or open a thread on the spectrum chat. I'm doing a lot of testing over the weekend and will release an official 1.0.0 on Monday :smile:


Ability to export in .md tables

Issue
ASVS has asked for an export of CRE to ASVS mappings as .md tables.
It's a feature that other users are likely to want to use.
Let's create a small exporter which given at least one standard export the standard and the CRE mappings of said standard.
AC:
CRE-id is a link to opencre.org/cre/
it supports more than one standards to CRE mapping. (similar to the spreadsheet export)

https://mdutils.readthedocs.io/en/latest/examples/Example_Python.html

done in #201


[DevOps] Switch AirGap Provisioning Nodes LVM/VG/PV/etc. entirely off of very slow spinning disks to NVMe to combat brittleness of provisioning

We need to switch the node that runs the airgap pipeline off of spinning disks.
So much I/O is used during provisioning and leveraging the NVMe, would create more stability.
This will require surgery on the node, juggling LVM commands to reduce, resize and re-allocate the physical volumes etc.

closing as single host airgapping is too resource intensive and pivot has been made to #967


Add section to call out different behavior of windows server container and hyperv container.

We should call out this behavior difference between windows server container and hyperv container, in regarding default RAM and CPU count.  Windows sever container will be able to leverage unlimited resources if --memory and --cpus are not specified, while hyperv container will be allocated memory = 2GB and CPUs =2 by default, if they are not specified.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd671d15-cd2f-d3a0-298a-83b3b5375589
Version Independent ID: bff76cf7-b868-e30c-bc1a-fa6e4d06a11f
Content: Implementing resource controls
Content Source: virtualization/windowscontainers/manage-containers/resource-controls.md
Service: windows-containers
Product: windows-containers
GitHub Login: @taylorb-microsoft

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


No drives shown on Free Play

This issue has been happening off and on and the cause needs investigation. My first question is if the right number is being pulled into the server. I added a printout (first hit when I play a song) and it says
Nov 21 00:44:37 sloppy floppy-control-app[19481]: NaN floppy drives have been attached.
Huh.

—
Reply to this email directly or view it on GitHub
https://github.com/dstelljes/umm-floppy-choir/issues/16#issuecomment-158596247
.

Maybe try lib/floppyController.js, lines 155ff. If that's firing often, the problem is probably in the Arduino code.

Also likely fixed with the interface refactor, maybe c74d8d3? Haven't been able to reproduce the issue since, but reopen if necessary.


how to connect to jetson nanos together

I need to know how to connect 2 jetson nano development kits together without the carrier board
is there a special file for this? I connected them with USB and nothing happens

Probably the fastest/easiest way would be over gigabit ethernet

And will it show up 2 nanos in system resources?

Thank you very much for your fast support

Please Dusty I need your help I connected just using ethernet but it doesn't work it does not share any resources and I tried Gary explains and I only got as far as it says 2 nodes passed the example but in reality nothing is shared

Using Simple MPI

Please help as soon as possible

Your help is the only thing I have

I am asking as nicely as possible and you decide not to answer

I really appreciate your previous help but now this is unacceptable

Sorry I am away on vacation, and your question is unrelated to this repo or even the Jetson in particular.  It is the same as if you were connecting two PCs or two computers over ethernet.  MPI can be used to distribute workloads but they are still two separate computers with separate resources - for example, you can't directly control the GPU from another machine.

From: Gianni2045 @.>
Sent: Thursday, June 3, 2021 5:43:03 PM
To: dusty-nv/jetson-inference @.>
Cc: Dustin Franklin @.>; Comment @.>
Subject: Re: [dusty-nv/jetson-inference] how to connect to jetson nanos together (#1076)
I really appreciate your previous help but now this is unacceptable
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/1076#issuecomment-854200482, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVEGK3HR5R5HNEMPUXB6A3TQ7ZOPANCNFSM45VXXLNQ.

It was posted as jetson cluster super computer by Jerry explains, thank you for making me feel like I ask dumb questions unrelated to reality. I really appreciate your response even though on vacation I apologize for insulting you without knowing you were busy. Since it was talking specifically about connecting jetson nanos it is obvious why I would think it is related to jetson nano

Gary Explains on github is misleading

No worries @Gianni2045 - you can post general questions about Jetson Nano on the Nano forum here:   https://forums.developer.nvidia.com/c/agx-autonomous-machines/jetson-embedded-systems/jetson-nano/76


Search bar at the top right corner can be added

Search bar at the top right corner can be added for easy search and finds for the users

hii @AyushShukla3466 @apu52 , please add level.
I'm GSSoC'24 contributor , I have experience in the designing animated search bars so, please assign this issue to me.

I would like to work on this project.Please assign it to me.

@AyushShukla3466 this is a good issue. Just want to suggest you to raise your issues with the help of issue templates already present in the repo. Sorry to close this isssue


Remove puaf_smith option on 15.x

puaf_smith is currently completely broken on iOS 15.
While fixing it would probably be a better solution on paper, puaf_smith is extremely difficult to troubleshoot, not to mention better exploits exist for 15.x (puaf_physpuppet for 15.0-15.7.3, and puaf_landa for 15.7.4-15.8.1), making any efforts to fix it have almost zero value.

Obsolete, 2.1 will fix smith on iOS 15


CAMEL-18260: debugger - Reflect exchange changes on BacklogTracerEventMessage

fixes https://issues.apache.org/jira/browse/CAMEL-18260
Motivation
While investigating on https://github.com/camel-tooling/camel-idea-plugin/issues/734, I realized that is was actually due to the fact that when a change is made on an exchange, the corresponding backlog tracer event message is not modified such that the change is not reflected in the debugger variables.
Modifications:

Adds the new method refreshBacklogTracerEventMessage to refresh the content of the message when the exchange is modified
Fixes warnings raised by IntelliJ (not related to the issue)

Result
The changes are reflected directly on the BacklogTracerEventMessage as we can see in the screenshot below:

@oscerd Does it worth a backport in the 3.18 branch?

Yes, it makes sense to me


ajv standaloneCode() produces empty output with 2020/12 schema

What version of Ajv are you using? Does the issue happen if you use the latest version?
8.6.3
Ajv options object
{ code: { source: true } }

JSON Schema
Taken from https://json-schema.org/learn/miscellaneous-examples.html.
{
  "$id": "https://example.com/person.schema.json",
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "title": "Person",
  "type": "object",
  "properties": {
    "firstName": {
      "type": "string",
      "description": "The person's first name."
    },
    "lastName": {
      "type": "string",
      "description": "The person's last name."
    },
    "age": {
      "description": "Age in years which must be equal to or greater than zero.",
      "type": "integer",
      "minimum": 0
    }
  }
}

Your code
https://runkit.com/proteriax/615a679fdea26e0008143877
Result
"use strict;"

What results did you expect?
Not an empty JavaScript file.
Are you going to resolve the issue?

Please put the full code sample that produced this result - or check out the tests where it works.

You either have to use addSchema, if you want all schemas in the instance included, or to pass the compiled validation function as the second parameter.
https://runkit.com/esp/615a9b817db8bc0008b25f00
It's not specific to 2020-12 draft - did you try with others?


Don't titlecase group name for ADMIN_MENU_ORDER

Since the group title is user-specified it is counterintuitive to apply titlecase to it since it will display differently than what was specified in settings.

Thanks!


Find name of sprite that sprite transform applies to

In the Spriter software, sprites in animations are always associated with a named sprite object that shows up in the timeline. As far as I can tell, those are represented in the timeline information in SpriterDotNet's SpriterAnimation structure as well, in the .Timelines array, specified as entries with ObjectType "Sprite". Of course, only for available keyframes.
But when I want to update sprites after updating an animation, either by reacting to it in ApplySpriteTransform or by manually checking the latest FrameData, the library tells us (in the form of SpriterObjects) which images are used in the latest frame (via folder&file id), where they are and so forth, but not which sprite in the animation that image actually belongs to. Is there any way to reconstruct that information in the available data?

After a quick look around the source code, the information is definitely there and available, it just isn't handed around to be API consumers. I was able to hack it in for my specific use case, but I'm not comfortable enough with the codebase or have the time to implement it to make sure it works all over the codebase. Here's what I did:
In FrameDataCalculator.GetFrameData (at line 120) there's a loop that interpolates the objects between the keyframes. These objectRefs have a timelineID, which can be used to retrieve the timeline the object belongs to, which in turn contains the name of the sprite (or bone in the case of bones) that the resulting SpriterObject references.
Just to get it working I added a name field to SpriterObject and just set it in that loop right then and there. It's probably wasteful though, you could just give the SpriterObject the timelineID or something similarly small and compact so you can retrieve the name that way later.

(my fork's commit in question is https://github.com/Heishe/SpriterDotNet/commit/a931b97cc06def29274bfae098c2788680a95c84#diff-80ac421ada1d8569e29d129ed036b8a2 , but I also deleted all projects I don't need from there so the changes might be hard to find. it's in FrameDataCalculator.cs and SpriteModel.cs)

By the way, the reason this is useful at all is because a 'retained' way of dealing with the sprite objects is just more efficient. If you do extra stuff with the sprites at runtime, like changing the pictures for others (for dynamic equipment), or applying different materials to them, you want to minimize the amount of switching that happens because especially rendering related stuff can have quite some overhead, which can be problematic if you're trying to display a lot of spriter-animated stuff at once.
So in Unity for example you always want to apply the same 'ApplySpriteTransform'  and whatever you do in there to the same GameObject in the background that you allocate at startup time from all the object definitions in (SpriterEntity).ObjectInfos.

Hey, thanks for reporting and analysing it in detail. I'll implement it as soon as I get back to it.


Allow to start and stop the effects programmatically

Having the option to manually start and end the effects allows for more use-cases.
Right now, this is only possible by manipulating the alpha of the effects which is not ideal in terms of both user- and developer-experience.
The idea is to have a .start() and .stop() functionality for all effects. Although different implementations would be necessary for the SpriteKit and CAEmitterLayer based effects, the API has to be the same for making it a streamlined effort for developers to integrate.

I was looking to pass a Binding to start/stop the effect.
Yes, as you said, it's necessary.

That's one approach for sure @Dave181295!
So, what you always can do, is to have a @State property that's conditionally showing the respective effect.
Something in the realm of:
@State private var showingEffect = true
/// ...
if showingEffect {
    ConfettiView()
}
/// ...
.onAppear {
    DispatchQueue.main.asyncAfter(deadline: .now() + 2) {
        withAnimation {
            showingEffect = false
        }
    }
}

But that would just be a workaround for now, we'll find a better way and expose that in one of the upcoming versions! If you have wishes for the functionality, feel free to add them here! :)


add timestamp to zip archive name

Loaders should be ready now. Would merge it after @dawidxc approves


Azure extension fails to install because zip cannot be deleted

We're using a RM template to set up a Windows VM including the VSTS agent extension. However, the whole step fails because the zip cannot be deleted after successful setup of the extension. So the agent is starting properly and the VM is showing up in the deployment group.
The error message is as follows:
VM has reported a failure when processing extension 'VSTS-Agent'

Error message: "The Extension failed to execute: The process cannot access the file 'C:\\VSTSAgent\\agent.zip' because it is being used by another process..

More information about the failure can be found in the logs located under 'C:\\WindowsAzure\\Logs\\Plugins\\Microsoft.VisualStudio.Services.TeamServicesAgent\\<IP_ADDRESS>' on the VM."

Our guess is that the setup is faster than Defender checking the content of the ZIP. What might be a possible solution?

@chshrikh is this a deployment group extension?
@sibbl the easiest solution would be add a Try-Catch or don't delete the download zip.

@TingluoHuang yes, that would be a great idea but nothing a user of the extension can do ;) Here's a link to the description of which extension exactly we're using: https://gallery.azure.com/artifact/20161101/microsoft.vsts-agent-windows-arm.1.0.0/Artifacts/MainTemplate.json

@sachinma to help sibble

The VM extension does not delete agent zip package after configuration. It only deletes the package when new package is downloaded next time.
@sibbl can you please provide full logs from 'C:\WindowsAzure\Logs\Plugins\Microsoft.VisualStudio.Services.TeamServicesAgent\<IP_ADDRESS>'. on the VM. You will need to get the logs for correct timestamp when this error happened. Or repro the issue again and get the latest logs.

@bishal-pdMSFT we can reproduce it during the setup of a new VM.
Please find the logs in this vsts-agent-logs.zip. It seems that the enable.cmd does not wait for the install.cmd to complete and both run at the same time?

Thanks @chandlerkent
@chshrikh @bishal-pdMSFT
please check the log.

Hi all,
we have fixed this issue and published a new extension version. Please let us know if the issue persists.
@chshrikh can we close this issue after waiting for a few days?

I am going to close the issue for now, please reopen if needed.


Creating UUID for each rule

Thanks a lot for the project, it's great. Would you add UUID for each rule? We would like to import the rules to make those available on cycat.org.

The rules meta are using https://github.com/CybercentreCanada/CCCS-Yara, it can generate a id on the fly if enabled. That could be an option.


TQ card needs to handle new TSV spec

TQ cards should handle the newest TSV spec:
The final spec for TSVs is here:
https://forum.door43.org/t/parascriptural-tab-separated-value-format-specification-v2/870
An example of the TSV for TQ is here: https://git.door43.org/unfoldingWord/en_tq/src/branch/newFormat

Aren't these are already handled?

This is handled by create-app#124

@cckozie This should be fixed in build v0.2.0 build dbfbebc
@elsylambert

v0.9.0 build ab13659
The new TQ tsv format looks good in the TQ card and works fine.

v0.9.0 build 736dc08
TQ card looks good.

How can we test this? I'm seeing markdown in the tQ files in both test_org and test_org2.

@mannycolon is going to make a test_org3 that includes TQ in TSV format.

This is blocked until we have a proper repo to test from. (test_org3 has problems)

v0.9.0 build 008141c
tQ card is properly handling the new format as in test_org3

v0.9.0 build 008141c
TQ card is looking fine in the new format in test_org3.


libv4l: 1.16.5 -> 1.16.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/v4l-utils/versions.
meta.description for libv4l is: '"V4L utils and libv4l, provide common image formats regardless of the v4l device"'.
meta.homepage for libv4l is: '"https://linuxtv.org/projects.php"

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.16.6 with grep in /nix/store/gbcbg6vvgzkvabjlnijwr6kv61gfiylb-v4l-utils-1.16.6
directory tree listing: https://gist.github.com/2fc3e94992e3ebb2b3dde56d67972a6a
du listing: https://gist.github.com/852db018e3a9fb538951e9c9d070406b

Rebuild report (if merged into master) (click to expand)

1009 total rebuild path(s)
349 package rebuild(s)
349 x86_64-linux rebuild(s)
338 i686-linux rebuild(s)
11 x86_64-darwin rebuild(s)
311 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
adapta-gtk-theme
ahoviewer
alarm-clock-applet
aravis
arc-theme
audio-recorder
baresip
beets
blink
brasero
brasero-original
byzanz
cantata
chrome-gnome-shell
clementine
clementineUnfree
colord
colord-gtk
corebird
cozy
cutegram
darktable
denemo
digikam
discover
dragon
dvdstyler
eaglemode
ekiga
electrum
empathy
enlightenment.econnman
enlightenment.efl
enlightenment.enlightenment
enlightenment.ephoto
enlightenment.rage
enlightenment.terminology
epiphany
epkowa
evince
farstream
fbida
feedreader
ffmpeg-full
fgallery
freerdp
freerdpUnstable
fswebcam
fwupd
gImageReader

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gbcbg6vvgzkvabjlnijwr6kv61gfiylb-v4l-utils-1.16.6 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libv4l https://github.com/r-ryantm/nixpkgs/archive/ea36e9260eb756366d7419e3ee6f9ebedd84e15c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gbcbg6vvgzkvabjlnijwr6kv61gfiylb-v4l-utils-1.16.6
ls -la /nix/store/gbcbg6vvgzkvabjlnijwr6kv61gfiylb-v4l-utils-1.16.6/bin

cc @codyopel for testing.

Changelog: https://git.linuxtv.org/v4l-utils.git/plain/ChangeLog?id=v4l-utils-1.16.6


feat: do not propagate pretty printer errors through messages

This PR makes all message constructors handle pretty printer errors.
Prior to this change, pretty printer errors in messages were not uniformly handled.  In core, some printers capture their errors (e.g.,  ppExprWithInfos and ppTerm ) and some do not (e.g., ppGoal and ppSignature) propagate them to whatever serializes the message (e.g., the frontend).
To resolve this inconsistency and uniformly handle errors, the signature for  ofLazy now uses BaseIO.  As such, all printers been adapted to capture any errors within them and print similar messages to ppExprWithInfos and ppTerm on such errors.

I guess this needs master merged into into it (or rebaesd onto master) to unblock CI. Sorry for that.

Looking through the Mathlib/Std failures, there are some direct replications of ppSignature code in core which are causing errors now. To make fixing easier, a split this into a separate MessageData helper ofSignature (like ofSyntax and ofExpr) that the downstream use cases can utilize. The other failures are just signature fixes and places were Mathlib/Std should now catch potential pretty-printer errors and handle them properly as well.
@semorrison Should I make PRs to the Mathlib/Std testing branchs or is this something you can handle?

@semorrison Should I make PRs to the Mathlib/Std testing branches or is this something you can handle?

Sorry, missed this earlier. Could you rebase onto nightly-with-mathlib (which should be quite recent), and then I can take a look.

@tydeu, would you be able to rebase this onto nightly-with-mathlib?

@kim-em I can certainly try! :-)

@kim-em The PR is now updated and rebased on the latest  nightly-with-mathlib. i haven't investigated the Mathlib failure yet, though.

Mathlib fix looks straightforward, hopefully CI will agree.

@kim-em LGTM! Should I throw it on the queue?


Handle invalid Uri in HttpSeeds

Working with some torrents from archive.org I'm seeing they have an invalid absolute Uri in their torrent file. E.g. this torrent  https://archive.org/download/latinmass2/latinmass2_archive.torrent has an entry for /8/items/ which throws an exception in  MonoTorrent.Client.Modes.Mode.DownloadLogic.
      Unexpected main loop exception: System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at System.Uri..ctor(String uriString)
   at MonoTorrent.Client.Modes.Mode.DownloadLogic(Int32 counter)
   at MonoTorrent.Client.Modes.Mode.Tick(Int32 counter)
   at MonoTorrent.Client.Modes.DownloadMode.Tick(Int32 counter)
   at MonoTorrent.Client.ClientEngine.LogicTick()
   at MonoTorrent.Client.ClientEngine.<.ctor>b__77_0()
      MonoTorrent.Client.MainLoop.<>c__DisplayClass10_0.<QueueTimeout>g__Callback|0(Object state)
…     MonoTorrent.Client.MainLoop.Loop()

I could create a PR that uses Uri.TryCreate but I'm not sure if the best place to put the logic would be in the DownloadLogic to just ignore these entries, or in the torrent loading logic.

I suspect GH ate part of your comment there when talking about the List. I was going to assume you were thinking about exposing it as a List<Uri> rather than a List<string>. I already created a PR that tidies up HTTP list with #429 but I could change this to a List<Uri> pretty easily. Doesn't look like there would be much of a change internally, but this would obviously be a breaking change. I guess now's the time for that if you want to go that route

Yup, you're exactly right. GH seems to have tried treating it as html or some nonsense. Oops!
Breaking API and exposing it as a List of Url would be ideal. This will roll into v2 which has far larger breaking changes already :)
Thanks for the PR!

I'll get the PR updated. 👍

Pushed the change to IList<Uri>. Left it as two commits because I kind of felt like they were doing two different tasks. Feel free to squash away if needed.

Great stuff. I just merged that in! Thanks for taking the time to make those changes


Support inlay hint double click gesture

We should support the double click gesture on inlay hints and connect it with some "primary command". That would allow for nice interactions like making the corresponding code change when clicking etc

This happened. With vsocde.InlayHint.command the default (dbl-click) gesture can be set

To verify

use the sample https://github.com/jrieken/test-inlayhints/
run npm i
press F5 to debug
open a markdown file, type "foo" and "bar",  both words will be decorated with an inlay hints
ensure you can dbl-click the hints and see a notification

Works nicely -> verified. Filled follow up issue https://github.com/microsoft/vscode/issues/143740

Re-opening after further discussion (https://github.com/microsoft/vscode/issues/143740 and related). The current API allows to give a command for the hint as well as for hint label parts. Tho, the former command is meant to be a "accept" command and we should model the API accordingly. That would allow us to show specific UI, like "double click to accpet"

API idea
export class InlayHint {

  // optional edit that is performed when the default gesture is triggered
  edit?: TextEdit | WorkspaceEdit;
}


Mock and/or wait for Emulator block height to run test commands

Issue To Be Solved
For testing purposes, it would be helpful to have the ability to wait until a certain block to execute a command.
Context
Working on tests & setting conditionals on getCurrentBlock().height and finding it difficult to setup tests to properly account for all cases without the ability to wait for a certain block or mock emulator block height.

It's possible to mock specific block height 😉
Here's example on how to do it:
https://github.com/onflow/flow-js-testing/blob/master/examples/07-block-offset.test.js


chore(docs): fix wrong function name in examples

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.923%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3308

Relevant Lines:
3344

💛  - Coveralls

Thanks! rebase needed.

Here you go!


fix: Fixed Lint/Format Errors

Follow up to #329

I would like @RajeshThallam to look over the change to matching_engine.py since he created it in #70
Was there a particular reason for creating a custom LangChain class for MatchingEngine?
Has the LangChain implementation been updated since to serve the same use cases?

@holtskinner the existing langchain integration does not support a few features that the use case/notebook refers to. E.g. streaming indexes, full data point retrieval. I am working on the langchain PR to add these features along with new vector search features that were launched.

Thanks @RajeshThallam that makes sense. I'll leave that file alone for this PR.


Clean up unused or unnecessary dependencies

Removes most of the dependencies identified by depcheck as being unused.
The depcheck tool also identified some missing dependencies, including tslint. Tslint is now deprecated in favour of eslint, so this also converts the project to eslint. No linting is done as part of any build scripts or pipelines, but there is now an npm script to run it manually. I'll create a separate issue to enable automated linting.
The utils dependency was there to support the 'promisification' of node's fs library. This is now unnecessary thanks to the inbuilt fs/promises library.
This also removes some redundant processing from the webpack configuration.

💡 This looks great to me, I can surely take a look bit more, but just for idea sake, shall we merge this after tcpDump work - and cut a separate release branch and then merge this.


Add option to insert tap notes

This adds an option to insert tap notes. Tap notes are any notes with a length of 0.0625 or less, so I just set the length to that value. Lower values make notes harder to hit and reward less score, so it's best to stick with this value.
I've also noticed a regression that breaks note placement unrelated to this commit if you'd like me to open an issue for it (I know you've been busy making some internal changes so I'm not sure if you're already aware of it).

Nice. I noticed tap notes after updating and had been meaning to look into how they worked but this week I've actually been busy with a completely unrelated project (and will be for most of the remainder of the month, unless it crashes and burns, lol). I'll take a look at this today, though.

I've also noticed a regression that breaks note placement unrelated to this commit if you'd like me to open an issue for it (I know you've been busy making some internal changes so I'm not sure if you're already aware of it).

By all means, go ahead. I'd at least like to know the nature of the regression; I did do some intentional messing with how initial note placement worked in order to prevent creating notes that went past the end of the chart (I did do a fair bit of informal testing to make sure that the new overlap check I switched to in that edit worked right, though) but it could also be due to the restructuring of the Note class, and particularly the drag logic, so without more to go off I don't really know what to look for.

Posted an issue about it #15.

Just messing around with it, the one thing that immediately occurs to me is that there really should be some visual feedback for whether a note is a tap or not. I'm messing with just hiding portions of the note, but I'm not sure if I like it...

Also, not like this wasn't an issue of its own before, but maybe with tap notes it's finally something relevant enough to fix: the end handle can get trapped behind and become impossible to move independently. probably should check for this and bring it to the front. (this is at max zoom level, so it really is impossible to recover the handle)

I think the only way to properly represent a tap note is to just hide the tail altogether, or to only show the tail if the note is highlighted.

the second one seems like the right approach, plus it gives note focus something to do besides the delete hotkey(s), so i'm all for it. i'll merge this and put changes i made to this effect on top


Can't import tensorboard summary and FileWriter

In https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/understanding_vanish_gradient.ipynb:
from tensorboard import summary
from tensorboard import FileWriter
Fails
I tested it on Amazon Ubuntu.
@zihaolucky

Did you installed tensorboard already? And could you provide the error log/info for me? Thank you!

The tensorboard package isn't packed with MXNet yet, so we have to install tensorboard to use it, we're working on providing a pip/wheel solution for this.

ImportError                               Traceback (most recent call last)
 in ()
3 import os
4 import numpy as np
----> 5 from tensorboard import summary
6 from tensorboard import FileWriter
7
ImportError: No module named tensor board
Tensorflow is installed. I checked dict-package under python2.7 and find tensorboard is also installed under tensorflow/python.
Then I tried "from tensorflow.python.tensorboard import summary", summary is imported.
However, I can't find a way to import FileWriter.

Sorry, it's my bad.
The tensorboard in the tutorial is an ongoing project to make a stand-alone version of tensorboard for MXNet, where we strip the tensorboard out of TensorFlow. https://github.com/dmlc/tensorboard
It's an independent project, and currently, we have to build it from source.

OK. Thank you!

Could you add the instructions on how to install the custom tensorboard version?
Otherwise, maybe the notebook should be removed then? It is confusing to have a notebook which can only run after building a custom tensorboard...

@geoalgo I suppose this particular notebook requires dmlc-tensorboard.


Placing items in lockers is hard

When you place an item in a locker using click, the item can be placed outside the locker BB, wich makes it get out when closing the locker. The intended behavior is that when you place a item in a containter, it gets automatically placed in the middle

Closing in favor of #2596


TFVC Build Tasks check in changes not working

Hi,
I have to check in one file during VSTS build process. During the VSTS build, one of the task is updating one of the file and we have to check in that file in the repository.
We are using GIT to check in and check out.
I have added 'TFVC Build Tasks' in our build definition.
Below is the log details of this task:

2017-11-18T04:17:28.0218394Z ##[section]Starting: Check changes into source control
2017-11-18T04:17:28.0218394Z ==============================================================================
2017-11-18T04:17:28.0218394Z Task         : TFVC - Check-in changes
2017-11-18T04:17:28.0218394Z Description  : Checks in any files changed in the repository.
2017-11-18T04:17:28.0218394Z Version      : 1.2.4
2017-11-18T04:17:28.0218394Z Author       : Jesse Houwing
2017-11-18T04:17:28.0218394Z Help         : Version: 1.2.4. More Information
2017-11-18T04:17:28.0218394Z ==============================================================================
2017-11-18T04:17:28.0288430Z Preparing task execution handler.
2017-11-18T04:17:36.7798778Z Executing the powershell script: d:\a_tasks\TFVCCheckin_31f040e5-e040-4556-878a-59a47c7128bd\1.2.4\TfvcCheckin.ps1
2017-11-18T04:17:38.1626312Z ##[warning]Only TfsVersionControl source providers are supported for TFVC tasks. Repository type: System.Collections.Hashtable
2017-11-18T04:17:38.2386446Z ##[section]Finishing: Check changes into source control

I have attached a screenshot of TFVC task.
Please suggest what I am missing.

Tfvc tasks only support tfvc repositories. I have no support for git
repositories in these tasks and they're not intended to.
On Nov 21, 2017 12:41, "SdnaMunish"<EMAIL_ADDRESS>wrote:

Hi,
I have to check in one file during VSTS build process. During the VSTS
build, one of the task is updating one of the file and we have to check in
that file in the repository.
We are using GIT to check in and check out.
I have added 'TFVC Build Tasks' in our build definition.
Below is the log details of this task:
2017-11-18T04:17:28.0218394Z ##[section]Starting: Check changes into
source control
2017-11-18T04:17:28.0218394Z ==============================
2017-11-18T04:17:28.0218394Z Task : TFVC - Check-in changes
2017-11-18T04:17:28.0218394Z Description : Checks in any files changed in
the repository.
2017-11-18T04:17:28.0218394Z Version : 1.2.4
2017-11-18T04:17:28.0218394Z Author : Jesse Houwing
2017-11-18T04:17:28.0218394Z Help : Version: 1.2.4. More Information
https://github.com/jessehouwing/vsts-tfvc-tasks/wiki/Check-in
2017-11-18T04:17:28.0218394Z ==============================
2017-11-18T04:17:28.0288430Z Preparing task execution handler.
2017-11-18T04:17:36.7798778Z Executing the powershell script:
d:\a_tasks\TFVCCheckin_31f040e5-e040-4556-878a-59a47c7128bd\1.2.4
TfvcCheckin.ps1
2017-11-18T04:17:38.1626312Z ##[warning]Only TfsVersionControl source
providers are supported for TFVC tasks. Repository type:
System.Collections.Hashtable
2017-11-18T04:17:38.2386446Z ##[section]Finishing: Check changes into
source control
I have attached a screenshot of TFVC task.
Please suggest what I am missing.
[image: tfvc]
https://user-images.githubusercontent.com/33772332/33070692-e59be3f4-cede-11e7-8201-76a4d2d07a41.PNG
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jessehouwing/vsts-tfvc-tasks/issues/56, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AD-uSxQockKbRqOutJpTKv6OGbVwJzX8ks5s4rbkgaJpZM4QltCf
.

Thanks for you reply.
Do you have any idea which task support for git repositories?


Width of columns in Excel File

Is it possible to set width of columns in excel file to fit content?
Or how can i set column width in excel file?

Please consult the documentation of https://github.com/dynamicreports/dynamicreports (I wasn't able to find the wanted functionality quickly) or write your own Format as we did in the example here.


Can view map in SVG (client-side)

Hi Scott,
I am afraid this change cannot be merged. Rendering maps server-side is much more important than rendering them in the client - especially because one of the next features is sharing maps and making them embeddable (twitter, emails, webpages, wikis). They must be served from the server, and I have absolutely no assumptions about the client...

I have used your code and created https://github.com/cdaniel/wardleymapstool/pull/18, but it is still not complete.
I'll keep that open because you've made a lot of useful improvements - which I will incorporate after basic server-side rendering will be done.

Agree that we want server side export, But what's the issue w/ merging this in as is?

I will merge those improvements today. That's what I meant in my previous comment.
There is just a small issue with the 'boolean bug' - at some point in time I've made a terrible mistake of storing those values in the mongo as strings, and as a consequence simple checks like if(var) don't work - 'true' and 'false' are always true. Merging this part will take a bit longer, because I will have to edit a production database and check literally every place where those variables are used.


Modify many id to be able to get identity from HSM

We should have an easy way to get the identity from the HSM

Feature implemented. Depends on #28.


Link crt statically on Linux

Note that regardless of what platform we build these on, we should be testing them on x86-linux-gnu, because we need to make sure that our binaries work on systems that have glibc on the system (and do not have musl on the system).
It's fine to test on x86_64-linux-musl, as long as we also test on x86_64-linux-gnu.

Right now I'm under the impression that we can either link glibc or musl statically. If that holds for all the platforms, which one should we chose? glibc somehow seems the safer option to me, or not?

The original suggestion for all of this from @SaadiSave had the following additional arguments:
-Clto=fat -Cembed-bitcode=yes

@SaadiSave should we use those? It is not clear to me what they do :)
The other open question is: are we ok to just statically link glibc here? Would there be any benefit in using musl instead? @DilumAluthge any thoughts on that?

I'm far from an expert here, but it was my understand that glibc cannot be linked statically without breaking some things.

The original suggestion for all of this from @SaadiSave had the following additional arguments:
-Clto=fat -Cembed-bitcode=yes

@SaadiSave should we use those? It is not clear to me what they do :)

lto is link-time-optimization
embed-bitcode is required for lto to work
It's not really required, that's just what I use when building locally. But it might provide a speed boost because the compiler will be able to inline more and eliminate more dead code and unused branches. Upto you whether you want to use it.

The other open question is: are we ok to just statically link glibc here? Would there be any benefit in using musl instead? @DilumAluthge any thoughts on that?

My original suggestion had the target x86_64-unknown-linux-**musl**. Static linking doesn't work well with glibc, while musl is designed for static linking.

Merged a different version of this on main.


Code to fetch the SVHN dataset

SVHN is very similar to MNIST. I added code that will download and create datasets for train and test samples the same way get_mnist() does.
This code requires scipy in order to read the matlab format that files are officially provided in.

Thank you for the PR!
I have two comments.

Please add get_svhn in __init__.py (https://github.com/rcalland/chainer/blob/b1cb12d726078589bf99b31ab66f553a1ab717a9/chainer/datasets/init.py)
It seems label i corresponds to the number i+1 in the image and it is confusing.

The SVHN website says:
10 classes, 1 for each digit. Digit '1' has label 1, '9' has label 9 and '0' has label 10.
which I guess is less confusing, how about switching to that system?

I just realised I misunderstood slightly the label definitions on the website, and so simply setting digit "0" from label 10 to 0 makes everything sensible!

Thank you for the update.
It seems there are some flake8 errors in init.py and svhn.py.  Could you fix them?

There are still following flake8 errors

.\chainer\datasets_init_.py:6:1: H306  imports not in alphabetical order (chainer.datasets.svhn, chainer.datasets.ptb)
.\chainer\datasets_init_.py:21:1: H306  imports not in alphabetical order (chainer.datasets.svhn.get_svhn, chainer.datasets.ptb.get_ptb_words)

My version of flake8 didn't show those errors. Fixed.

Sorry for late reply, current CI is failing because scipy is not in the default dependency.
Could you add scipy availability check like this? https://github.com/cupy/cupy/blob/d7ad0d34f77de5b111807c0c1998176e9ab7e59a/cupy/sparse/csc.py#L1

Thank you for fixing and sorry for late reply.
LGTM!


ktk.TimeSeries.sort_events sometimes miss duplicate events

Describe the bug
Normally, the behavior of ktk.TimeSeries.sort_events is to remove duplicate events (unique = True). However, if for some reasons there are duplicate events that are at a same time but that is numerically different (rounding error), then these events are not unified.
In any case, we should use isclose rather than == to compare floats.

It's not only using np.close. The whole duplicate finding method fails if there are events with different names (but same time) between events with same names (and same time).

Closed by #120


OAuth2 ClientCredentials not working in SwaggerUI

Hello guys
I want use ClienCredentials flow for auth in my web api, but not working, server return 400 Bad Request
in Postman works currectly:
POST http://localhost:5050/connect/token
Content-Type: application/x-www-form-urlencoded
BODY:
client_id=my_client_id
client_secret=my_client_secret
grant_type=client_credentials

I have application with Identity Server 4 like https://github.com/IdentityServer/IdentityServer4/tree/main/samples/Quickstarts/1_ClientCredentials/src/IdentityServer
and I have client asp.net core 3.1 application with Swashbuckle.AspNetCore 5.6.3
options.AddSecurityDefinition("Bearer", new OpenApiSecurityScheme
{
    Name = "Authorization",
    Type = SecuritySchemeType.OAuth2,
    Scheme = "Bearer",
    BearerFormat = "JWT",
    In = ParameterLocation.Header
    Flows = new OpenApiOAuthFlows
    {
        ClientCredentials = new OpenApiOAuthFlow
        {
            TokenUrl = new Uri("http://localhost:5050/connect/token")
        },
    }
});

options.AddSecurityRequirement(new OpenApiSecurityRequirement
{
    {
        new OpenApiSecurityScheme
        {
            Reference = new OpenApiReference
            {
                Type = ReferenceType.SecurityScheme,
                Id = "Bearer"
            },
            Name = "Bearer"
        },
        new string[] {}
    }
});

I think I'm not alone
https://stackoverflow.com/questions/63341836/bearer-token-doesnot-pass-on-swagger

This functionality def works do must be something in your setup. Please create a minimal app (i.e. start from empty project) that repro's the issue and post to github so I can pull down and troubleshoot.

This functionality def works do must be something in your setup. Please create a minimal app (i.e. start from empty project) that repro's the issue and post to github so I can pull down and troubleshoot.

Hold off on that - at a quick glance you're Swagger OAuth config looks wrong to me - let me try something and get back to you

Hold off on that - at a quick glance you're Swagger OAuth config looks wrong to me - let me try something and get back to you

same project: https://github.com/ionepaul/dotnet-api-with-identity-server
I resolved by add cors configuration on IdentityServer side
app.UseCors(b =>
{
  b.AllowAnyOrigin()
   .AllowAnyMethod()
   .AllowAnyHeader();
});

same project: https://github.com/ionepaul/dotnet-api-with-identity-server
I resolved by add cors configuration on IdentityServer side
app.UseCors(b =>
{
  b.AllowAnyOrigin()
   .AllowAnyMethod()
   .AllowAnyHeader();
});

can the issue be closed then?

can the issue be closed then?

yeap, thx :)

yeap, thx :)


Add a verify:binaries task to check function results over time

One nice property of both compilation outputs (both the secp256k1 build and the hashes build) is that their algorithms are supposed to be deterministic. So as long as we're fully testing both, consumers can be reasonably-sure that I haven't poisoned them. Probably the most important example: all produced signatures are themselves deterministic (both Schnorr and ECDSA signatures) so we can randomly test inputs to confirm they match expected outputs. This is done for the hashes too. The only current weakness is that currently, we're not testing against another BCH-style Schnorr implementation, so until we have something else there to test against, that could be subverted. (Not to mention, the implementation we're compiling from could be subverted itself. It has had far less review so far than the secp256k1 implementation.)
As long is we're aggressively, randomly testing inputs and validating outputs, most poisoning issues are likely to be discovered. Even if I did something like secretly leak some private key material after every 1,000,000 signatures, that can be detected in about 5 minutes of random testing.
So: we should add a verify:binaries task which runs random tests until it's stopped. Then if you're building an application which is likely to use these binaries millions of times, you can run a test for whatever length of time needed to guarantee accurate results for the duration of your use-case. If you've run the randomized tests for 10M signatures, you're safe to use the tested binary for up to that many signatures before re-initializing the WASM instance. (Assuming your inputs are cryptographically-random. If you're somehow signing non-uniformly-random message hashes, I could be more clever about hiding a leak – e.g. only after 1M signatures over message hashes in which the first 3 bits are 0. To catch that in random testing, you need an average of 1B signatures, which would take about 3.5 days on my machine. So if you're signing bitcoin block hashes, test that properly too.)

If we need to touch the binaries again, we'll make sure their deterministically built.


Add tags for saved melodies

I want to be able to give a melody a name so I can find it easily. The tag column in the database is set up for this, but right now it doesn't do anything. I would like for some kind of drop-down menu of existing tags to show up, as well as a way to enter a new one.

I plan to do this as "hashtags". Since a melody can have multiple hashtags, and a hashtag multiple melodies, this will require some changes to the database schema.

These could be hierarchical, with steps in the hierarchy separated by colons.
For instance, we could have #bach:organ, #bach:flute, and so forth. This would enable searching for all of the elements rooted by an element of the hierarchy.


Use ClusterFirstWithHostNet for nginx dnsPolicy

The nginx ingress pod is created with hostNet: true. This means that
it does not, by default, have access to kuebdns. We need that so that
the ingress controller can map things like ExternalName services to
internal services.
This fixes the problem by setting the dnsPolicy to
ClusterFirstWithHostNet.
Fixes #339

Hi @klarose, I am +1 to this. Would you ming rebasing so we can get a green build from travis. Thanks.

Done. Sorry it took so long; I was travelling.

Thank you. It should be available on v1.13.5.


[BUG] No matching files on filenames with brackets

Description
This is related to Next.js new dynamic routes feature.

Steps to reproduce

Use this configuration in package.json:

  …
  "husky": {
    "hooks": {
      "pre-commit": "lint-staged --debug"
    }
  },
  "lint-staged": {
    "*.{js,css,json,md}": [
      "prettier --write",
      "git add"
    ],
    "*.js": [
      "npm run lint:eslint",
      "git add"
    ]
  …

Try to commit a filename with brackets [].

Debug Logs

expand to view

husky > pre-commit (node v12.6.0)
2019-07-30T23:23:07.320Z lint-staged:bin Running<EMAIL_ADDRESS>2019-07-30T23:23:07.697Z lint-staged:find-bin Loaded package.json using `process.cwd()`
2019-07-30T23:23:07.847Z lint-staged Loading config using `cosmiconfig`
2019-07-30T23:23:07.852Z lint-staged Successfully loaded config from `OMMITED/package.json`:
{
  '*.{js,css,json,md}': [ 'prettier --write', 'git add' ],
  '*.js': [ 'npm run lint:eslint', 'git add' ]
}
2019-07-30T23:23:07.853Z lint-staged:cfg Normalizing config
2019-07-30T23:23:07.855Z lint-staged:cfg Validating config
Running lint-staged with the following config:
{
  linters: {
    '*.{js,css,json,md}': [
      'prettier --write',
      'git add'
    ],
    '*.js': [
      'npm run lint:eslint',
      'git add'
    ]
  },
  concurrent: true,
  chunkSize:<PHONE_NUMBER>740991,
  globOptions: {
    matchBase: true,
    dot: true
  },
  ignore: [],
  subTaskConcurrency: 1,
  renderer: 'verbose',
  relative: false
}
2019-07-30T23:23:07.863Z lint-staged:run Running all linter scripts
2019-07-30T23:23:07.863Z lint-staged:run Resolved git directory to be `OMMITED`
2019-07-30T23:23:07.884Z lint-staged:run Loaded list of staged files in git:
[ 'services/enrola-webapp/pages/CRM/sales/[saleId]/index.js' ]
2019-07-30T23:23:07.884Z lint-staged:gen-tasks Generating linter tasks
2019-07-30T23:23:07.884Z lint-staged:cfg Normalizing config
2019-07-30T23:23:07.899Z lint-staged:gen-tasks Generated task:
{
  pattern: '*.{js,css,json,md}',
  commands: [ 'prettier --write', 'git add' ],
  fileList: [
    'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
  ]
}
2019-07-30T23:23:07.900Z lint-staged:gen-tasks Generated task:
{
  pattern: '*.js',
  commands: [ 'npm run lint:eslint', 'git add' ],
  fileList: [
    'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
  ]
}
Stashing changes... [started]
2019-07-30T23:23:07.935Z lint-staged:git Stashing files...
2019-07-30T23:23:07.935Z lint-staged:git Running git command [ 'write-tree' ]
2019-07-30T23:23:07.961Z lint-staged:git Running git command [ 'add', '.' ]
2019-07-30T23:23:07.984Z lint-staged:git Running git command [ 'write-tree' ]
2019-07-30T23:23:08.002Z lint-staged:git Running git command [ 'read-tree', '8abe2bba7ffe8916312b195969cc19039ca8658e' ]
2019-07-30T23:23:08.086Z lint-staged:git Running git command [ 'checkout-index', '-af' ]
2019-07-30T23:23:08.694Z lint-staged:git Done stashing files!
Stashing changes... [completed]
Running linters... [started]
Running tasks for *.{js,css,json,md} [started]
Running tasks for *.js [started]
2019-07-30T23:23:08.696Z lint-staged:make-cmd-tasks Creating listr tasks for commands [ 'prettier --write', 'git add' ]
2019-07-30T23:23:08.697Z lint-staged:find-bin Resolving binary for command `prettier --write`
2019-07-30T23:23:08.702Z lint-staged:find-bin Binary for `prettier --write` resolved to `OMMITED/node_modules/.bin/prettier`
2019-07-30T23:23:08.703Z lint-staged:task ✔  OS: darwin; File path chunking unnecessary
2019-07-30T23:23:08.703Z lint-staged:find-bin Resolving binary for command `git add`
2019-07-30T23:23:08.704Z lint-staged:find-bin Binary for `git add` resolved to `/usr/local/Cellar/git/2.22.0_1/libexec/git-core/git`
2019-07-30T23:23:08.704Z lint-staged:task ✔  OS: darwin; File path chunking unnecessary
2019-07-30T23:23:08.704Z lint-staged:make-cmd-tasks Creating listr tasks for commands [ 'npm run lint:eslint', 'git add' ]
2019-07-30T23:23:08.704Z lint-staged:find-bin Resolving binary for command `npm run lint:eslint`
2019-07-30T23:23:08.705Z lint-staged:find-bin Binary for `npm run lint:eslint` resolved to `/usr/local/bin/npm`
2019-07-30T23:23:08.705Z lint-staged:task ✔  OS: darwin; File path chunking unnecessary
2019-07-30T23:23:08.705Z lint-staged:find-bin Resolving binary for command `git add`
2019-07-30T23:23:08.705Z lint-staged:find-bin Resolving binary for `git` from cache
2019-07-30T23:23:08.705Z lint-staged:task ✔  OS: darwin; File path chunking unnecessary
prettier --write [started]
npm run lint:eslint [started]
2019-07-30T23:23:08.705Z lint-staged:task bin: OMMITED/node_modules/.bin/prettier
2019-07-30T23:23:08.706Z lint-staged:task args: [
  '--write',
  'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
]
2019-07-30T23:23:08.706Z lint-staged:task opts: { reject: false }
2019-07-30T23:23:08.710Z lint-staged:task bin: /usr/local/bin/npm
2019-07-30T23:23:08.710Z lint-staged:task args: [
  'run',
  'lint:eslint',
  'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
]
2019-07-30T23:23:08.710Z lint-staged:task opts: { reject: false }
prettier --write [failed]
→
Running tasks for *.{js,css,json,md} [failed]
→
npm run lint:eslint [completed]
git add [started]
2019-07-30T23:23:11.725Z lint-staged:task bin: /usr/local/Cellar/git/2.22.0_1/libexec/git-core/git
2019-07-30T23:23:11.725Z lint-staged:task args: [
  'add',
  'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
]
2019-07-30T23:23:11.725Z lint-staged:task opts: { reject: false }
git add [completed]
Running tasks for *.js [completed]
Running linters... [failed]
Updating stash... [started]
Updating stash... [skipped]
→ Skipping stash update since some tasks exited with errors
Restoring local changes... [started]
2019-07-30T23:23:11.739Z lint-staged:git Restoring working copy
2019-07-30T23:23:11.739Z lint-staged:git Running git command [ 'read-tree', 'e0a3ad899b52438b4a0f11eadce45c90d21c1936' ]
2019-07-30T23:23:11.769Z lint-staged:git Running git command [ 'checkout-index', '-af' ]
2019-07-30T23:23:12.375Z lint-staged:git Restoring index
2019-07-30T23:23:12.376Z lint-staged:git Running git command [ 'read-tree', '8abe2bba7ffe8916312b195969cc19039ca8658e' ]
Restoring local changes... [completed]

✖ prettier --write found some errors. Please fix them and try committing again.

[error] No matching files. Patterns tried: OMMITED/webapp/pages/CRM/sales/[saleId]/index.js !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
husky > pre-commit hook failed (add --no-verify to bypass)

Environment

OS: macOS Mojave 10.14.5 (18F132)
Node.js: v8.15.0
lint-staged: 8.1.7

To me it looks like the error happens during the linter task, since the path seems to be working fine:
2019-07-30T23:23:08.705Z lint-staged:task bin: OMMITED/node_modules/.bin/prettier
2019-07-30T23:23:08.706Z lint-staged:task args: [
  '--write',
  'OMMITED/webapp/pages/CRM/sales/[saleId]/index.js'
]
prettier --write [failed]

If you run the command directly, does it work? prettier --write OMMITED/webapp/pages/CRM/sales/[saleId]/index.js? To me this sounds like prettier is treating the input filepath as a glob instead of a direct string, and is thus failing to match anything.

Doesn't work
prettier --write ./path/to/[file].js

prettier --write ./path/to/\[file\].js

Work
prettier --write "./path/to/\[file\].js"

It seems like prettier is treating the input filepath as a glob instead of a direct string, and is thus failing to match anything.

Yeah that's what I think too & maybe the issue should be in prettier instead.

Thanks for the input. I'll continue the discussion on the prettier repo.

From the prettier issue:

How could I fit escaped brackets on this glob? *.{js,css,json,md}

As @ahmedelgabri replied:

@zomars you can't. I know that in the other thread I said, it might be a prettier issue but now I think this might actually be handled on lint-staged instead. Especially after reading the prettier docs
Don't forget the quotes around the globs! The quotes make sure that Prettier expands the globs rather than your shell, for cross-platform usage. The glob syntax from the fast-glob module is used.
https://github.com/prettier/prettier/blob/master/docs/cli.md

Regarding quotes, this issue is relevant: https://github.com/okonet/lint-staged/issues/635. Maybe it should get another look.

I found temp workaround:
.lintstagedrc.js
const quote = require('shell-quote').quote;

module.exports = {
    '*.{js,jsx,ts,tsx}': filenames =>
        filenames.reduce((commands, filename) => {
            commands.push(quote(['prettier', '--write', filename]), quote(['git', 'add', filename]));

            return commands;
        }, [])
};

@langovoi maybe you can try to do this here quoting the filelist https://github.com/okonet/lint-staged/blob/710be313809901e6fe3275c476b6f82241093989/src/generateTasks.js#L67 & see if it works, if it does maybe you can open a PR?

@langovoi quoting seems to work for prettier but break stylelint

This is how I currently deal with the issue: https://github.com/okonet/lint-staged/issues/635#issuecomment-526110562.
Not sure how to best solve it on the lint-staged side generically. There would probably need to be some detection that the command being executed is prettier and do some custom stuff for it.

What's the status here? Running<EMAIL_ADDRESS>w/ node 10.15.3, but when i try the workaround https://github.com/okonet/lint-staged/issues/676#issuecomment-518850249, I get:

I just created  PR https://github.com/okonet/lint-staged/pull/698 for escaping certain characters from the file paths, and it works for prettier+brackets at least (in the integration test).

I was using something similar to https://github.com/okonet/lint-staged/issues/676#issuecomment-518850249 but I feel this was broken by #706 (> lint-staged 9.2.5).

@millette that PR shouldn’t have affected task behaviour, only the generated title. If you can reproduce the regression, I can try to fix it.

@iiroj Thanks,but I only know enough about lint-staged to be dangerous. I probably wrote my workaround wrong but too busy with other stuff to dig deeper right now.

Hello there!
I'm currently using workaround like this.
.lintstagedrc.js
const escape = require('shell-quote').quote

function listQuote(filenames) {
  return filenames.map((filename) => `'${filename}'`)
}

function listEscape(filenames) {
  return filenames.map((filename) => escape([filename]))
}

module.exports = {
  '**/*.{js,ts,tsx}': (filenames) => [
    `eslint --fix ${listQuote(filenames).join(' ')}`,
    `prettier --write ${listQuote(listEscape(filenames)).join(' ')}`,
    `git add ${listQuote(filenames).join(' ')}`,
  ],
}

Main problem is..
Prettier need escapes and quotes filenames, but eslint and git add are not.
And, using these commands for all staged files are cause massive cli logs.
I just want to use like 'lint-stagedfield onpackage.json`, so I wrote workaround above.

Or how the Next.js team handles this issue https://github.com/zeit/next.js/blob/canary/lint-staged.config.js

I'd love us to hide this complexity but we'd need a really comprehensive test suite for that. Ans also since it's tool related, maybe we could provide the function with escaped file names arguments.
@iiroj thoughts?

@okonet maybe a special command to scape characters? Image something like this on package-json
  "lint-staged": {
    "--escape *.{js,jsx}": [
      "prettier --write",
      "git add"
    ],
    "*.{js,jsx}": [
      "npm run lint:eslint",
      "git add"
    ]

the --escape is basically saying to escape any special characters before giving it to prettier, but I'm afraid this would work for prettier --write but will fail for git add.
Or maybe:
  "lint-staged": {
    "*.{js,jsx}": [
      "--escape",
      "prettier --write",
      "npm run lint:eslint"
      "git add"
    ]

In this case, the --escape on the command chain would just be saying to escape the input before the next command.
Just brainstorming. The former could open doors for some other commands. I fixed my problem by following the suggestion in https://github.com/okonet/lint-staged/issues/676#issuecomment-553598068

Neither of above worked for us. We've found out that it's possible to bypass this problem by wraping square brackets with square brackets (matcher of any char in seq):
lint-staged.config.js
const escape = require('shell-quote').quote;
const isWin = process.platform === 'win32';

module.exports = {
	'**/*.{js,jsx,ts,tsx,json}': filenames => {
		const escapedFileNames = filenames
			// this will wrap all "[" "]" square brackets with glob seq pattern: [abc] so [...customer].tsx will be processed to [[]...customer[]].tsx
			.map(filename => `"${isWin ? filename.replace(/\[|\]/g, '[$&]') : escape([filename])}"`)
			.join(' ');
		return [
			`prettier --with-node-modules --ignore-path='./.gitignore' --write ${escapedFileNames}`,
			`eslint --no-ignore --max-warnings=0 --fix ${filenames.map(f => `"${f}"`).join(' ')}`,
			`git add ${escapedFileNames}`
		];
	},
	'**/*.{json,md,mdx,css,html,yml,yaml,scss}': filenames => {
		const escapedFileNames = filenames.map(filename => `"${isWin ? filename : escape([filename])}"`).join(' ');
		return [
			`prettier --with-node-modules --ignore-path='./.gitignore' --write ${escapedFileNames}`,
			`git add ${escapedFileNames}`
		];
	}
};

This has been fixed in v2 of Prettier. Closing.

it's not only prettier issue, it should escape correctly

@thomaszdxsn Feel free to open a PR, any help is appreciated! So far we haven't been able to find a consistent cross-platform method for escaping paths that works with execa, with or without using shell.

If someone still impacted by this especially on Windows, take a look at this example:
https://github.com/belgattitude/nextjs-monorepo-example/blob/951c75f3c5ef0ccca511dd0519984754053857cd/lint-staged.config.base.js
It's basically escaping the filenames using shell-quote:
const escape = require('shell-quote').quote;
const { CLIEngine } = require('eslint');

const cli = new CLIEngine({});
const isWin = process.platform === 'win32';

const escapeFileNamesForPrettier = (filenames) =>
  filenames
    .map((filename) => `"${isWin ? filename : escape([filename])}"`)
    .join(' ');

module.exports = {
  '**/*.{js,jsx,ts,tsx}': (filenames) => {
    return [
      `eslint --rule 'react-hooks/exhaustive-deps: off' --max-warnings=25 --fix ${filenames
        .filter((file) => !cli.isPathIgnored(file))
        .map((f) => `"${f}"`)
        .join(' ')}`,
    ];
  },
  '**/*.{json,md,mdx,css,html,yml,yaml,scss}': (filenames) => {
    return [`prettier --write ${escapeFileNamesForPrettier(filenames)}`];
  },
};


Some cursor themes are not scaled correctly

Some cursor themes  converted from xcursor like https://www.gnome-look.org/p/2113061 are not scaled correctly, which makes the cursor appear abnormally small on high-resolution screens

that'd be an issue with xcur2png tho no?

that'd be an issue with xcur2png tho no?
I don't think so, because it's also a problem when using the XCursor mouse theme under GTK applications

maybe its a problem with the theme then? if only select themes are affected

maybe its a problem with the theme then? if only select themes are affected

In fact all themes in this category suffer from these problems. It seems that highly colorful, pixelated and dynamic mouse themes will fail to scale properly, but vector graphic mice in general are not affected.


Update Test.py for Python3 compatibility

This is not performance critical code anyways.
Partially addresses #2272, I'd really like the CMake magic that is going on in there (folders that get reused but have their names somehow hard-coded and handed over in a nameless list of lists...) to go away, but that probably has to wait for another day.

Codecov Report

Merging #2273 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2273      +/-   ##
===========================================
+ Coverage    70.11%   70.12%   +<.01%
===========================================
  Files          689      689
  Lines        50800    50800
===========================================
+ Hits         35617    35621       +4
+ Misses       15183    15179       -4

Impacted Files
Coverage Δ

src/ripple/app/misc/SHAMapStoreImp.cpp
78.92% <0%> (-1.03%)
:arrow_down:

src/ripple/protocol/impl/Serializer.cpp
70.3% <0%> (+0.34%)
:arrow_up:

src/ripple/protocol/impl/STVar.cpp
88.31% <0%> (+2.59%)
:arrow_up:

src/ripple/server/impl/BaseHTTPPeer.h
90.06% <0%> (+3.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafe18c...35cccce. Read the comment docs.

Thanks. :-)
Looking at the Travis build failure by the way, it seems as if Travis is constantly re-compiling boost because you never had a successful run since changing the boost version. You could just make 2 pseudo-commits where one finishes the build successfully as soon as the bin/ci/ubuntu/install-dependencies.sh script has finished (to warm the cache) and a second one that reverts this change but that should then finish the build, since you have ~13 minutes more of actual build time for the build.
Alternatively you could use a compiled version of boost from a PPA or Debian (https://packages.debian.org/search?keywords=libboost-all-dev&searchon=names&suite=all&section=all)...

Merged as 5a9c3c797c1ee2be7e38f226bf7f831f43c024c1


Show mounted engines routes

Sextant shows only the main app's routes, which forces users to use rake routes to list engines' routes. A hack is used to reterive engines' routes because RouteInspector doesn't have an accessor for @engines variable.

This got merged into Rails so I don't really maintain the standalone gem anymore.