Tests for Postgres schemas and tables with capital letters

Following the discussion on: https://github.com/looker-open-source/malloy/pull/500
Lloyd mentioned using temporary tables for the tests, but unfortunately sounds like it doesn't work for schemas:

Temporary tables exist in their own unique schema, so you can’t assign a schema name when you create this kind of table.

My idea is create the tables in an idempotent way before the tests. They are created on the first run and no-op subsequently, so concurrent test runs should not step on each other.

/gcbrun


Fix order-dependent calls for faces() and attr()

While considering https://github.com/hughsk/gl-geometry/issues/14, I noticed that @TatumCreative encountered rendering artifacts while calling faces() before attr(). He accordingly added a note in README.md warning that faces() should be called last.
He was kind enough to provide me with a way to reproduce the issue (running example 3 from glam while swapping calls in this file), so I studied this in more details.
It appears the issue was due to an ambiguity in the use of _length. Indeed it was both used to store faces and attributes size, which led to feeding the draw call with an improper value when calling faces() before any attr(). Hence the artifacts.
This PR provides a fix to this behavior by using distinct fields for both kinds of length, and building draw call parameters accordingly.
I also took the liberty of:

adding a test case for "faces() first" in test.js,
naming existing test cases (using HTML title),
simplifying simplicial complex processing by moving it from normalize.js to index.js,
adding a sanity check at the end of attr() to ensure that all attributes have the same length.

I feel the last one is a good practice, but I may have missed a situation where different-length attributes would be legit when using gl-geometry. Please, let's discuss this if you reckon such a case is possible.
That last point excepted, I believe this PR does not break compatibility with existing code. So, should it be merged, I'd suggest a patch-level increment for gl-geometry version number.
This code was tested with gl-geometry test cases, the aforementioned glam example and bunny-walkthrough.
Regards,
Olivier.

Thanks a ton @oparisy! Nice work :D
Would you like me to add you to stackgl on github/npm? I'm gonna move this repo into the org too for consistency :)

I'd be honored if you did!
But should this provide me with merge rights, I'll still ask you (or other members of stack.gl) to review and merge any future PR I may submit. Many eyeballs and all that...

Great! I'll do that now :grin: We generally take the approach of PRs + reviews for anything non-trivial so that's no trouble at all :)


feat(type annotation): added type info

Any types aren't necessary and we've got more specific types available we could use. Closing for now.


Moving the checks critical and failing the testcase

Following up with Manikandan to get more clarity on this issue.

This has been added to internal Jira under CEADETT-129

Jira ticket
https://jira-eng-sjc4.cisco.com/jira/browse/SDWANAURA-47


⚠ ClamAV has degraded performance

In f02b98f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 442 ms

Resolved: ClamAV performance has improved in 1816a98.


Taxonomy Individuals should retain taxonomy node ID (AKA accession) as short form.

Dependency - we need an IRI pattern - one that works for new ontologies following CCF2.
Options:

Use PURL under PCL space (as owners of PCL, we have control of this), e.g.
purl.obolibary.org/obo/pcl/CCN201810310_1

Something BICAN specific? - or do we want this to be broader?

just a heads up - for now ODK doesn't do overly well with non obolibrary purls -> this will change with the new update apparently, but not sure when that will be fully released.
I don't think it will overly affect this, but just something to be careful about I guess.
Should also be careful with products that deal with base, or any sparql stuff that assumes native = ID space

We were previously using accession IDs for IRIs, so don't think it will be a problem.
By the way, we also represent taxonomy itself as an individual (https://www.ebi.ac.uk/ols/ontologies/pcl/individuals?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FPCL_0011000). Should we use accession id for those as well?

By the way, we also represent taxonomy itself as an individual (https://www.ebi.ac.uk/ols/ontologies/pcl/individuals?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FPCL_0011000). Should we use accession id for those as well?

Yes.  Definitely.


Reposition nodes on Collapsible Radial Tree Canvas when browser resizes

Issue: When the browser window is resized the nodes in a tree canvas do not reposition themselves based on the new dimensions of their canvas. This forces the user to reload the browser to reposition the tree.

This doesn't appear to be an issue still. Can't reproduce.


fixing behavior of transformers tokenizer for all chars and words

Hi, I was finally able to work on the code over the weekend, and I found the cause of the error, which was due to a tokenizer problem.
In many languages, including my language (Persian), there are words and characters (abbreviations) that the tokenize() method in the tokenizers class is not able to identify, so in the face of such inputs, an empty list of word pieces is returned. In the next step, the offsets array will be expanded (by [1]) even if no word piece was identified, which eventually leads to errors in the training and evaluation process.
For example, the word  ۖ indicates sanctity for religious figures, which is seen in many writings but can not be identified.

tokenizer = AutoTokenizer.from_pretrained("bert-base-cased", use_fast=False)
add "use_fast=false" in parameters. more details on this link.


Create TowerOfHanoi.java

What type of PR is this? (check all applicable)

[ ] 🚀 Added Name
[ ] ✨ Feature
[x] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Hey @keshavsingh4522 ,
Can you pls assign this issue to me, would like to work on it ...


Job FOlder links have been modified to smb://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent

Esko SC Script issue
Affected script

Name: ServiceCloud Local Links
Version: 7

OS

Name: Mac
Version: 10.9.5
Language: Irrelevant

Browser

Name: FireFox
version: 44.0.2
language (if different from OS): -

Short summary if your issue
To overcome connection issues to smb://esko-graphics.com/globalstorage/CC-SW-Problemlog-Gent - like many of us had on Mac), IT has replaced the JobFolder Mac & Windows using a new logical name "CC-SW-Problemlog-Gent", so:
smb://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent/00605000-00605999/00605151
file://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent/00605000-00605999/00605151
As a consequence, this script fails to resolve the link OK (at least on my Mac, but that could also be because I again don't have access to smb://esko-graphics.com/globalstorage/CC-SW-Problemlog-Gent).
Steps to reproduce the issue
Click the Job Folder link.
Other details:
Note, Also JDF URLs will have to be adjusted (IT- work), and Poolserver mapped network drives & Containers (Poolbabes). I'll inform both.

@tuxfre

Hi @andsesko,
I just got a mail from @korinapieters telling me as well. I'll have to adapt the script. Maybe this afternoon.
I'm currently fighting the skills matrix, it may take some time.

@andsesko & @korinapieters
I just pushed a new version (v8) (see b3d475140439821dbcef28e125281b97fcceaed5).
Tried it quickly on my machine (OSX, with Safari) and it seems ok. Can you confirm?
Thanks

@tuxfre & @korinapieters ,
Works OK, thanks for the swift action!
Kind Regards,
Andy

Hi Benjamin,
I installed the new version but as I use Google Chrome (and not Firefox) the Local Link script doesn’t work.
When I click the link nothing happened.
<EMAIL_ADDRESS>The jobfolder link itself I copy pasted to Windows Explorer and this works!
Kr,
Korina
Korina Pieters  |  Service Business System Engineer  |  Esko
T. +32 (0)9 216 90 19
[Description: Description: esko-logo-mail]
Kortrijksesteenweg 1095
B-9051 Gent, Belgium
From: Benjamin<EMAIL_ADDRESS>Sent: Tuesday, March 22, 2016 12:48 PM
To: tuxfre/esko-SC-scripts
Cc: Pieters, Korina
Subject: Re: [esko-SC-scripts] Job FOlder links have been modified to smb://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent (#9)
@andseskohttps://github.com/andsesko & @korinapietershttps://github.com/korinapieters
I just pushed a new version (v8) (see b3d4751https://github.com/tuxfre/esko-SC-scripts/commit/b3d475140439821dbcef28e125281b97fcceaed5).
Tried it quickly on my machine (OSX, with Safari) and it seems ok. Can you confirm?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/tuxfre/esko-SC-scripts/issues/9#issuecomment-199776375

@korinapieters
Please remember that due to Chrome's security model, the support for the local links in Chrome comes with some limitations (see Notes Regarding Google Chrome).
Try installing the "LocaLinks"extension and see if, at least, it shows the correct folder.

Hi Benjamin,
Yes, it does show the correct folder. This is tested ☺.
Kr,
Korina
Korina Pieters  |  Service Business System Engineer  |  Esko
T. +32 (0)9 216 90 19
[Description: Description: esko-logo-mail]
Kortrijksesteenweg 1095
B-9051 Gent, Belgium
From: Benjamin<EMAIL_ADDRESS>Sent: Tuesday, March 22, 2016 1:50 PM
To: tuxfre/esko-SC-scripts
Cc: Pieters, Korina
Subject: Re: [esko-SC-scripts] Job FOlder links have been modified to smb://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent (#9)
@korinapietershttps://github.com/korinapieters
Please remember that due to Chrome's security model, the support for the local links in Chrome comes with some limitations (see Notes Regarding Google Chromehttps://github.com/tuxfre/esko-SC-scripts/wiki/*-Scripts-*-Local-Links#notes-regarding-google-chrome).
Try installing the "LocaLinkshttps://chrome.google.com/webstore/detail/locallinks/fkkidcgelfcjmebocoaicnelkbnpgpmm"extension and see if, at least, it shows the correct folder.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/tuxfre/esko-SC-scripts/issues/9#issuecomment-199796278

@korinapieters
ok, so it's limited by Chrome.
I fear there is nothing else I can do, unfortunately :cry:. Unless esko decides to create their own build of Chromium without this security feature.
So let's close this issue!

Sure!
Thanks for looking into this.
Korina Pieters  |  Service Business System Engineer  |  Esko
T. +32 (0)9 216 90 19
[Description: Description: esko-logo-mail]
Kortrijksesteenweg 1095
B-9051 Gent, Belgium
From: Benjamin<EMAIL_ADDRESS>Sent: Tuesday, March 22, 2016 2:00 PM
To: tuxfre/esko-SC-scripts
Cc: Pieters, Korina
Subject: Re: [esko-SC-scripts] Job FOlder links have been modified to smb://CC-SW-Problemlog-Gent/CC-SW-Problemlog-Gent (#9)
@korinapietershttps://github.com/korinapieters
ok, so it's limited by Chrome.
I fear there is nothing else I can do, unfortunately [Image removed by sender. :cry:] . Unless esko decides to create their own build of Chromium without this security feature.
So let's close this issue!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/tuxfre/esko-SC-scripts/issues/9#issuecomment-199801325


Odometry dataset support

Hey, I added support for odometry datasets and changed few things. This is my first pull request ever, so excuse any silly things I might have done. I tried to keep the original style and functions as much as possible.
So the highlights;

The original argument handling was tailored for raw datasets only. I imported argparse to create a nicer command line interface. I changed the way kitti2bag accepts arguments to be able to select different dataset types.
The new command line interface is as follows;

usage: kitti2bag [-h] [-t DATE] [-r DRIVE]
                    [-s {00,01,02,03,04,05,06,07,08,09,10,11,12,13,14,15,16,17,18,19,20,21}]
                    {raw_synced,odom_color,odom_gray} [dir]

Convert KITTI dataset to ROS bag file the easy way!

positional arguments:
  {raw_synced,odom_color,odom_gray}
                        KITTI dataset type
  dir                   base directory of the dataset, if no directory passed
                        the deafult is current working directory

optional arguments:
  -h, --help            show this help message and exit
  -t DATE, --date DATE  date of the raw dataset (i.e. 2011_09_26), option is
                        only for RAW datasets.
  -r DRIVE, --drive DRIVE
                        drive number of the raw dataset (i.e. 0001), option is
                        only for RAW datasets.
  -s {00,01,02,03,04,05,06,07,08,09,10,11,12,13,14,15,16,17,18,19,20,21}, --sequence {00,01,02,03,04,05,06,07,08,09,10,11,12,13,14,15,16,17,18,19,20,21}
                        sequence of the odometry dataset (between 00 - 21),
                        option is only for ODOMETRY datasets.

So for example to convert a raw dataset;
kitti2bag raw_synced -t 2011_09_26 -r 0002

or
kitti2bag raw_synced <directory that contains 2011_09_26/> -t 2011_09_26 -r 0002

And for a gray scale odometry dataset;
kitti2bag odom_gray <directory that contains sequences/> -s 00

Both color and gray odometry datasets are supported. The stereo images and dynamic tf are being exported.
The accepted types right now are raw_synced, odom_color and odom_gray.

Does this work with the docker image as well?


Shallow size and retained size are equal for all objects

Take a heap snapshot from the 'Profiles' tab. The retained size and shallow size are similar for all kinds of objects. I expected retained size to be larger at least in some nodes.

node-inspector version: 0.12.5
node-version: 4.2.1
os: OS X El Capitan (10.11)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28976402-shallow-size-and-retained-size-are-equal-for-all-objects?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

I'm also seeing this - makes debugging memory leaks rather awkward.
node-inspector v0.12.5
node v4.2.2
Windows 7

I don't know how to fix this bug at current time. It's not a bug of node-inspector itself.


:bookmark: Fix: add tevm-run to prerelease

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1347  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


Add simple docs to various iterators with links.

closes: #246 #245 #243 #242 #241 #240 #239 #238 #237

This is awesome. Thanks!


Inconsisten CIGAR fields

Dear authors,
I came to this repository by the paper in Bioinformatics. The run-time looks really impressive, but I am having a hard time making sense of the output because the CIGAR fields are often wrong even on a low level. I have run the aligner on simulated E.coli data, but in more than half of the output SAM lines I get the cigar M/I/S/=/X (not sure you use = or X) operations do not add up to the length of the query sequence as they should. Any help on that would be appreciated.
Best regards,
German

Hi German,

The Cigar field of rHAT doesn't use = or X
I guess you might have used the release version of rHAT, the source code has been changed, I haven't packaged yet. you could take advantage of "git clone" command and clone source files to local and compile them, and it might work.

Yours,
Dengfeng

Hi Dengfeng,
thank you for your quick reply. The latest version in the master branch in fact does not seem have the problem of CIGAR strings inconsistent with the read length. Concerning the operations used you might consider introducing = and X as those are required by PacBIO's new BAM specifications (see http://pacbiofileformats.readthedocs.io/en/3.0/BAM.html under CIGAR conventions).
Best,
German

Hi German,
Thanks for your suggestion, I will modify rHAT to introduce = and X into cigar field. It might take a bit more time.
Best,
Dengfeng


Remove unnecessary html_theme_path option

See https://github.com/Qiskit/qiskit-finance/pull/244 for the motivation.
I built the docs locally on main vs this branch and could find no differences between the two, as expected.

Since #571 passed yesterday I am re-running that to see if the failure might be related to a change in a library or dependency. I tried looking at versions but the spelling checker etc seem the same versions.

It has to be something that changed very recently but not what was done by this PR. The sparse TorchConnector PR #571 that passed yesterday ok, fails today the same way as this PR now having just re-run it.

Oh, I see now. Then you are right, something has been changed very recently.

It seems to be the class names at the end of the long class paths in the deprecation messages that it did pull off and check before. Not sure why now. Would any alteration to the message , say putting the whole path say in singles/double quotes stop it as a alternative to adding it to spell checker - something we'd have to try I guess if we don't want to add those class names to the dict.

I was wondering why Nature did not hit this since it has a lot of deprecations. With QuantumKernel here that is failing the class names are directly in the message (string) here versus in params of a decorator. Maybe both can go in the new name string parameter of a decorator rather than as currently done as a different option.

At the first glance, I have not spotted the difference between two setups: when CI failed and when CI checks were successful. Looks like the library versions are identical.

Now the failure here with the spelling in QuantumKernel its using a Terra decorator - that was just changed and now includes the deprecation message into the doctring which the spelling ends up seeing. So its not its presence in the source I think more that it gets injected into the docstring. You can see the result in the html built

Perhaps, this commit https://github.com/Qiskit/qiskit-terra/pull/9790 introduced that behavior. I will check it out later.

Yes, Eric has been working on improving the decorators. The problem in Optimization is related but a bit different. Hopefully we can figure what the best way forward is given that it was recognized it would be very helpful for the deprecation info to be in the docs too for an end user and for it to be automated,


A licencing question.

In looking for RDF libraries to use from Rust, this package caught my attention. However, I also noticed that it uses a GPL-incompatible licence, which sort of excludes it from consideration for me. Is this by design?

Short answer is "no", it was not by design.
As a French civil servant, I chose a license endorsed by French institution, and I chose the one that was presented as similar to the BSD and Apache  licenses. But apparently, the FSF considers it to be still incompatible with GPL, which I didn't know...
If Sophia was double-licensed as CeCILL-B and Apache V2, would this solve your problem?

Yes, entirely. Also, I am myself wary of the US-centric nature of most free software licences, so I completely understand your reason for going with a more local one.


bump corepack to fix freezes

What are you trying to accomplish?
There was some kind of freeze in Corepack that was reproducible if you gave it a registry that would 404:
$ script/dependabot update npm_and_yarn a/b --debug
$ export COREPACK_NPM_REGISTRY=https://npm.pkg.github.com/
$ corepack install npm@8 --global --cache-only
Internal Error: Server answered with HTTP 404 when performing the request to https://npm.pkg.github.com/npm; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
    at ClientRequest.<anonymous> (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:42205:23)
    at Object.onceWrapper (node:events:633:26)
    at ClientRequest.emit (node:events:518:28)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:702:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17)
    at TLSSocket.socketOnData (node:_http_client:544:22)
    at TLSSocket.emit (node:events:518:28)
    at addChunk (node:internal/streams/readable:561:12)
    at readableAddChunkPushByteMode (node:internal/streams/readable:512:3)
    at Readable.push (node:internal/streams/readable:392:5)

☝ The process would not exit from there. It just hangs.
I noticed our version was out of date, so bumping it fixed the problem.
Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?
We should be able to also verify that it fixes the issue in production with a live test.

Checklist

[x] I have run the complete test suite to ensure all tests and linters pass.
[x] I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
[x] I have written clear and descriptive commit messages.
[x] I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
[x] I have ensured that the code is well-documented and easy to understand.

Related:

https://github.com/dependabot/dependabot-core/pull/9324

Some interesting Corepack related failures in the Specs. I don't have the time to track those down. Anyone is welcome to pick this up before I can get to it.

@jeffwidman nice, seems like there's now multiple reasons to bump Corepack!

Some interesting Corepack related failures in the Specs. I don't have the time to track those down. Anyone is welcome to pick this up before I can get to it.

Yes. When corepack installing locally it is expecting to have packageManager field and returning warning instead of the version. So I am cleaning up the version to return version instead of the warning which is causing malformed version error.


Docker genration failing on libmagic dependency

Got an error while building the docker image, using: docker build --tag=haros .
#### Running command: "cmake /root/haros/src -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCATKIN_DEVEL_PREFIX=/root/haros/devel -DCMAKE_INSTALL_PREFIX=/root/haros/install -G Unix Makefiles" in "/root/haros/build"
####
####
#### Running command: "make -j8 -l8" in "/root/haros/build"
####
Traceback (most recent call last):
  File "/usr/local/bin/haros", line 5, in <module>
    from haros.haros import main
  File "/usr/local/lib/python2.7/dist-packages/haros/haros.py", line 107, in <module>
    from .data import HarosDatabase, HarosSettings
  File "/usr/local/lib/python2.7/dist-packages/haros/data.py", line 33, in <module>
    from .metamodel import Location, Resource
  File "/usr/local/lib/python2.7/dist-packages/haros/metamodel.py", line 29, in <module>
    import magic as file_cmd
  File "/usr/local/lib/python2.7/dist-packages/magic.py", line 181, in <module>
    raise ImportError('failed to find libmagic.  Check your installation')
ImportError: failed to find libmagic.  Check your installation
The command 'bash -c source /opt/ros/kinetic/setup.bash; cd ~/haros/src; catkin_init_workspace; cd ~/haros; catkin_make -DCMAKE_EXPORT_COMPILE_COMMANDS=1; source ~/haros/devel/setup.bash;  haros init' returned a non-zero code: 1

Adding
RUN apt-get install -y libmagic-dev

The generation of the image completes

@aremazeilles thanks a lot for the report.
Oh sorry, I have an updated version of the docker configurations in other repository https://github.com/ipa320/ros-model-cloud, I will compare both and if possible merge and migrate the configuration to a single place. I will keep you posted.

Ok
This issue may also hold for haros, as the dockerfile  is pretty similar (but I did not test it). Once you have checked it, we could bring that change suggestion to this repo as well.

@aremazeilles thanks! I have updated the Dockerfile, the scripts and the extractor (which solves https://github.com/ipa320/ros-model/issues/106 ) and moved everything to the ros-model-cloud repository.
The related changes can be found here[https://github.com/ipa320/ros-model-cloud/pull/34] and the PR is already merged, you can directly go to the documentation https://github.com/ipa320/ros-model-cloud/tree/master/docker_local_configuration where you have 2 different configurations, for kinetic and melodic. These docker can be used to extract the Ros models of the nodes. My idea is  update them to support also local workspaces, apart of clone from github the repository to be analyzed.
The melodic version has the same HAROS and clang version than my cloud system http://ros-model.seronet-project.de/ , however I tested there you dummy package and it doesn't work it seems there is an issue with the global scope of the clang compiler (-> HAROS problem), I have to check the issue using the source code version of HAROS and for the concrete case of your code. I hope I can find some time by the beginning of next week.
Thanks and have a great weekend!
P.S. I will also send a PR to HAROS, the Dockerfile should be almost the same because we created both together

Thanks @ipa-nhg for taking care of this.
Following my attempt in using your model extractor, I added an issue to ros-model-cloud. More than an issue, I am trying t see how I could rely on your component.
Should we close that issue then?

@aremazeilles thanks! I have updated the Dockerfile, the scripts and the extractor (which solves #106 ) and moved everything to the ros-model-cloud repository.

I tried the other docker file you mention, and now the image generation works, but the docker file in this repository  remains unchanged, is that correct?

Thanks @ipa-nhg for taking care of this.
Following my attempt in using your model extractor, I added an issue to ros-model-cloud. More than an issue, I am trying t see how I could rely on your component.
Should we close that issue then?

I will close it and point to the new one in ros-model-cloud for further discussions

@aremazeilles thanks! I have updated the Dockerfile, the scripts and the extractor (which solves #106 ) and moved everything to the ros-model-cloud repository.

I tried the other docker file you mention, and now the image generation works, but the docker file in this repository remains unchanged, is that correct?

no, I open the PR on Friday but forgot to merge it, now is clean https://github.com/ipa320/ros-model/pull/107


Doesn't display complete type information

👋🏻
Just a quick comment to say I've realised this plugin (great as it is) doesn't, in Go at least, display the complete type information.
So for example...

So unless I actually K over the method I won't know what w actually is.
In other examples, I also noticed the output type isn't presented...

So for this ^^ the output from the method is a boolean (hence it's used inside of an if condition) but it's not shown at all, only the input for the method is hinted.
Not sure if there's a configuration issue on my side that's causing this?
https://github.com/Integralist/nvim/blob/main/lua/plugins/lsp.lua#L110-L115
Thanks for any help/guidance you can give me.

I'm having the same issue when configuring with mason / lsp-zero (v3.x).
local lsp_zero = require("lsp-zero")
local ih = require("lsp-inlayhints")
ih.setup()

require("mason-lspconfig").setup({
    ensure_installed = { <snip>, "gopls"},
    handlers = {
        lsp_zero.default_setup,
       <snip>
        gopls = function()
            local go_opts = {}
            go_opts["on_attach"] = function(client, bufnr)
                ih.on_attach(client, bufnr)
            end
            go_opts["settings"] = {
                gopls = {
                    hints = {
                        assignVariableTypes = true,
                        compositeLiteralFields = true,
                        constantValues = true,
                        functionTypeParameters = true,
                        parameterNames = true,
                        rangeVariableTypes = true
                    }
                }
            }
            require("lspconfig").gopls.setup(go_opts)
        end
    }
})

Might be a duplicate of https://github.com/lvimuser/lsp-inlayhints.nvim/issues/11 ?


Fix inline styling breaking CSPs

Hiya 👋 We're currently using govuk-react on a project with a strict Content Security Policy (CSP). The CSP directive style-src has been causing us some grief due to the fact that there were three instances (Document Footer Metadata, Spinner and SVGBase) of inline styling in this library.
I've replaced these inline styles with styled-components styling 💅 which you use everywhere else. There should be no change to the behaviour of any of the components, visual or interactive.
Thank you. Big fans of this library! 😄 💯
Checklist:

[X] Documentation - N/A
[X] Tests
[X] Ready to be merged

Codecov Report
Base: 99.06% // Head: 99.07% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1ae7971) compared to base (d2027f1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   99.06%   99.07%
=======================================
  Files         112      112
  Lines         860      863    +3
  Branches      245      245
=======================================
+ Hits          852      855    +3
  Misses          8        8

Impacted Files
Coverage Δ

components/document-footer-metadata/src/index.tsx
100.00% <100.00%> (ø)

packages/icons/src/SVGBase/index.tsx
100.00% <100.00%> (ø)

packages/icons/src/Spinner/index.tsx
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Looks like it's disappeared some of the svg icons. Will fix that now

Forgot to update the snapshots following the fix to SVGBase 🤦 CI (hopefully) should pass now

@tomvaughan77 thanks very much for the PR! I’ll try get a release out this week


[Bug]: GPU_HUNG when both encoder and decoder

Which component impacted?
Decode, Encode
Is it regression? Good in old configuration?
Yes, it's good in old version
What happened?
CPU: 12th Gen Intel(R) Core(TM) i7-12700
kernel: Linux tvu-desktop 5.15.0-69-generic #76~20.04.1-Ubuntu SMP Mon Mar 20 15:54:19 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
vpl: 2023Q1(https://github.com/oneapi-src/oneVPL-intel-gpu/releases/tag/intel-onevpl-23.1.5)
Reproduction steps：
console1：
/opt/intel/media/share/vpl/samples/_bin/sample_decode h265 -i v3_1080i5994.h265 -o /dev/null -timeout 10000
console2：/opt/intel/media/share/vpl/samples/_bin/sample_encode h264 -i cnn.yuv -o /dev/null -w 1920 -h 1080 -timeout 10000 -nv12
[ERROR], sts=MFX_ERR_GPU_HANG(-21), SynchronizeFirstTask, SyncOperation fail or timeout at /opt/src/vpl-dispatcher_src/tools/legacy/Sample_encode/src/pipeline_encode.cpp:178
[ERROR], sts=MFX_ERR_GPU_HANG(-21), GetFreeTask, m_TaskPool.SynchronizeFirstTask failed at /opt/src/vpl-dispatcher_src/tools/legacy/Sample_encode/src/pipeline_encode.cpp:2239
[ERROR], sts=MFX_ERR_GPU_HANG(-21), Run, m_pmfxENC->EncodeFrameAsync failed at /opt/src/vpl-dispatcher_src/tools/legacy/Sample_encode/src/pipeline_encode.cpp:2487
[ERROR], sts=MFX_ERR_GPU_HANG(-21), main, pPipeline->Run failed at /opt/src/vpl-dispatcher_src/tools/legacy/Sample_encode/src/Sample_encode.cpp:1970
What's the usage scenario when you are seeing the problem?
Immersive Media
What impacted?
After testing, we found that:
When decoding H264/H265 encoded by intel msdk or vpl and encoding at the same time, it can work;
When decoding H265 encoded by our other platform (Amba H2) and encoding at the same time, it is easy to have GPU_HUNG
v3_1080i5994.zip
Debug Information

Do you want to contribute a patch to fix the issue?
Yes, I'm glad to submit a patch to fix it

Kernel version 5.15 is too old for 12th Gen.
Install the latest linux-firmware and update kernel to 6.1 and try again.
https://github.com/intel/media-driver#known-issues-and-limitations

I had update kernel to 6.1.0-1015-oem and linux-firmware to 20220329 and get the sample result.
Another finding: even without encoding and decoding only, there is the problem of decoding hang.
like this, decoded 4830 frames and hang....

I used another cpu(12th Gen Intel(R) Core(TM) i9-12900H)
ubuntu 22.04
kernel:  6.1.0-1015-oem and the latest linux-firmware
cmd: /opt/intel/media/share/vpl/samples/_bin/sample_decode h265 -i v3_1080i5994.h265 -o /dev/null -timeout 10000
Just decoding the H265 file encoded by Amba H2(v3_1080i5994.h265) platform will show the error(no encode at the same time) MFX_ERR_DEVICE_FAILED(-17). please see the log
mfxlib_Pid2426_Tid140450659272512.log
Also I can decode H265 files normally when I use intel msdk encoding(v2_500k_1080i5994.h265)
Please compare the difference between these two files for decoding.
v3_1080i5994.zip
v2_500k_1080i5994.zip

No issue with ffmpeg qsv decoder (built with onevpl). I think it should be a sample_decode issue.
ffmpeg -hwaccel qsv -hwaccel_output_format qsv -c:v hevc_qsv -i ~/Videos/v3_1080i5994.h265 -an -sn -f null -
ffmpeg version 6.0-Jellyfin Copyright (c) 2000-2023 the FFmpeg developers
  built with gcc 13.1.1 (GCC) 20230429
  configuration: --prefix=/usr/lib/jellyfin-ffmpeg --target-os=linux --extra-version=Jellyfin --disable-doc --disable-ffplay --disable-ptx-compression --disable-shared --disable-libxcb --disable-sdl2 --disable-xlib --enable-gpl --enable-version3 --enable-static --enable-gmp --enable-gnutls --enable-chromaprint --enable-libfontconfig --enable-libass --enable-libbluray --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libmp3lame --enable-libopus --enable-libopenmpt --enable-libtheora --enable-libvorbis --enable-libdav1d --enable-libwebp --enable-libvpx --enable-libx264 --enable-libx265 --enable-libzvbi --enable-libzimg --enable-libshaderc --enable-libplacebo --enable-vulkan --enable-opencl --enable-vaapi --enable-amf --enable-libvpl --enable-ffnvcodec --enable-cuda --enable-cuda-llvm --enable-cuvid --enable-nvdec --enable-nvenc
  libavutil      58.  2.100 / 58.  2.100
  libavcodec     60.  3.100 / 60.  3.100
  libavformat    60.  3.100 / 60.  3.100
  libavdevice    60.  1.100 / 60.  1.100
  libavfilter     9.  3.100 /  9.  3.100
  libswscale      7.  1.100 /  7.  1.100
  libswresample   4. 10.100 /  4. 10.100
  libpostproc    57.  1.100 / 57.  1.100
[hevc @ 0x557611b8ec80] PPS id out of range: 0
    Last message repeated 1 times
[hevc @ 0x557611b8ec80] Error parsing NAL unit #3.
[hevc @ 0x557611b8da00] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from '/home/nyanmisaka/Videos/v3_1080i5994.h265':
  Duration: N/A, bitrate: N/A
  Stream #0:0: Video: hevc (Main), yuv420p(tv, progressive), 1920x540 [SAR 1:1 DAR 32:9], 59.94 fps, 59.94 tbr, 1200k tbn
libva info: VA-API version 1.19.0
libva info: Trying to open /usr/lib/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_19
libva info: va_openDriver() returns 0
libva info: VA-API version 1.19.0
libva info: Trying to open /usr/lib/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_19
libva info: va_openDriver() returns 0
Stream mapping:
  Stream #0:0 -> #0:0 (hevc (hevc_qsv) -> wrapped_avframe (native))
Press [q] to stop, [?] for help
[hevc_qsv @ 0x55761217a900] More data is required to decode header
Output #0, null, to 'pipe:':
  Metadata:
    encoder         : Lavf60.3.100
  Stream #0:0: Video: wrapped_avframe, qsv(tv, top coded first (swapped)), 1920x540 [SAR 1:1 DAR 32:9], q=2-31, 200 kb/s, 59.94 fps, 59.94 tbn
    Metadata:
      encoder         : Lavc60.3.100 wrapped_avframe
frame= 1199 fps=0.0 q=-0.0 Lsize=N/A time=00:00:19.98 bitrate=N/A speed=40.8x    0x
video:562kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown

Using the bitstream filter hevc_metadata of ffmpeg can fix your v3 clip.
ffmpeg -i v3_1080i5994.h265 -bsf:v hevc_metadata -c:v copy -y v3_fixed.h265
/usr/bin/vpl-sample_decode h265 -i v3_fixed.h265 -o /dev/null -timeout 10000

Hi @nyanmisaka Thanks for your help. I did some test and have more infomation about  this issue.
I used the vpl version:2022q2 and found this verion have no this issue, then I used the vpl version:2022Q3 and found this isuue.
I contine replace intel-driver to 22.4.4 when use the vpl 2023Q1 and found it can work too.
So I think this is a issue in intel-driver after version > 22.4.4. Can you provide a patch to fix it ? Thanks.

Hi @nyanmisaka I see that you are using libva version 2.19 for ffmpeg 5.0, may I ask what version of libva media-driver and vpl you are using?
In 2023Q1, the libva is 2.18

Hi @nyanmisaka I saw your libva version is libva info: Found init function __vaDriverInit_1_19
What version of vpl are you using? I think if we use the different libva media-driver will have different result. Thanks

Libva version is not related to this issue. I'm testing the latest tag intel-onevpl-23.3.0.
Also I can't test media-driver 22.4.4 since it's too old to support my Arc discrete GPU.
I'm not from intel and probably can't help you fix this.
Since the regression seems to be caused by media-driver, you can open a ticket over there.

Hi @nyanmisaka Thanks for your help. I did some test and have more infomation about this issue. I used the vpl version:2022q2 and found this verion have no this issue, then I used the vpl version:2022Q3 and found this isuue. I contine replace intel-driver to 22.4.4 when use the vpl 2023Q1 and found it can work too. So I think this is a issue in intel-driver after version > 22.4.4. Can you provide a patch to fix it ? Thanks.

Hi Dave.
What's the test scenario of your above effort? Decode v3_1080i5994.h265 + Encode cnn.yuv? Or just decode test on your i9-12900H platform?
The error returned is MFX_ERR_GPU_HANG(-21) or MFX_ERR_DEVICE_FAILED(-17)?

Q1:Decode v3_1080i5994.h265 + Encode cnn.yuv
Q2: Both 12900H and 12700

Hi @chenhao5-Intel
I have also reproduced the decoding failure problem MFX_ERR_DEVICE_FAILED(-17) using 2022q2, but it seems to be more difficult to reproduce, I haven't found a stable way to reproduce it yet, I'm working on it.

Q1:Decode v3_1080i5994.h265 + Encode cnn.yuv Q2: Both 12900H and 12700 Q3:MFX_ERR_GPU_HANG(-21)

You mean you can reproduce the encode hang issue: "[ERROR], sts=MFX_ERR_GPU_HANG(-21), SynchronizeFirstTask, SyncOperation fail or timeout at /opt/src/vpl-dispatcher_src/tools/legacy/Sample_encode/src/pipeline_encode.cpp:178" on both 12900H and 12700?

Hi @DaveHu-TVU @nyanmisaka
I have successfully reproduced this issue on both i7-12700 and i9-12900H + Ubuntu 22.04 env.
There are two issue scenarios: (On both i7-12700 and i9-12900H)

When just decode v3_1080i5994.h265 which is encoded by Amba H2, sample_decode will report GPU_HANG:
`Decoding started
Frame number: 260541, fps: 2394.031, fread_fps: 0.000, fwrite_fps: 0.000
[ERROR], sts=MFX_ERR_GPU_HANG(-21), RunDecoding, DecodeFrameAsync returned error status at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/pipeline_decode.cpp:1980
Frame number: 260542, fps: 2394.034, fread_fps: 0.000, fwrite_fps: 0.000
[ERROR], sts=MFX_ERR_GPU_HANG(-21), RunDecoding, Unexpected error!! at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/pipeline_decode.cpp:2100

[ERROR], sts=MFX_ERR_GPU_HANG(-21), main, Pipeline.RunDecoding failed at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/sample_decode.cpp:904
`
Driver log shows no related errors reported and VPL log shows cm_mem_copy.cpp[Line: 3115]CopyVideoToSys: returns MFX_ERR_GPU_HANG. Analysis WIP.

When decoding v3_1080i5994.h265 and meanwhile encoding cnn.yuv, both decode and encode will report GPU_HANG:
For decode:
`Decoding started
Frame number: 1586, fps: 57.032, fread_fps: 0.000, fwrite_fps: 6847.8366
[ERROR], sts=MFX_ERR_GPU_HANG(-21), RunDecoding, DecodeFrameAsync returned error status at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/pipeline_decode.cpp:1980
Frame number: 1587, fps: 57.068, fread_fps: 0.000, fwrite_fps: 6849.847
[ERROR], sts=MFX_ERR_GPU_HANG(-21), RunDecoding, Unexpected error!! at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/pipeline_decode.cpp:2100

[ERROR], sts=MFX_ERR_GPU_HANG(-21), main, Pipeline.RunDecoding failed at /opt/src/sources/oneVPL-disp/tools/legacy/sample_decode/src/sample_decode.cpp:904
For encode:Processing started
Frame number: 1600
[ERROR], sts=MFX_ERR_GPU_HANG(-21), SynchronizeFirstTask, SyncOperation fail or timeout at /opt/src/sources/oneVPL-disp/tools/legacy/sample_encode/src/pipeline_encode.cpp:178
[ERROR], sts=MFX_ERR_GPU_HANG(-21), GetFreeTask, m_TaskPool.SynchronizeFirstTask failed at /opt/src/sources/oneVPL-disp/tools/legacy/sample_encode/src/pipeline_encode.cpp:2239
[ERROR], sts=MFX_ERR_GPU_HANG(-21), Run, m_pmfxENC->EncodeFrameAsync failed at /opt/src/sources/oneVPL-disp/tools/legacy/sample_encode/src/pipeline_encode.cpp:2487
[ERROR], sts=MFX_ERR_GPU_HANG(-21), main, pPipeline->Run failed at /opt/src/sources/oneVPL-disp/tools/legacy/sample_encode/src/sample_encode.cpp:1970
Frame number: 1680
Encoding fps: 324
Analyzed log and found that LibVA will report:[LIBVA]:CRITICAL - StatusReport:261: Something unexpected happened in HW, return error to application`
As for MFX_ERR_DEVICE_FAILED(-17), it may be a duplicate issue of GPU_HANG.
So next step let us focus on decoding v3_1080i5994.h265 scenario first as it may affect the two other issue.
If you have any question, please let me know. Thanks.
BRs,
Hao

I tried to decoder 1080p5994 from Amba H2 and found this error:
root@tvu-MS-TX-i9-12900H:~/test# /opt/intel/media/share/vpl/samples/_bin/sample_decode h265 -i /tmp/v3_1080p5994.h265 -o /dev/null
CONFIGURE LOADER: required implementation: hw
CONFIGURE LOADER: required implementation mfxAccelerationMode: MFX_ACCEL_MODE_VIA_VAAPI
libva info: VA-API version 1.18.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /opt/intel/media/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_18
libva info: va_openDriver() returns 0
libva info: VA-API version 1.18.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /opt/intel/media/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_18
libva info: va_openDriver() returns 0
libva info: VA-API version 1.18.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /opt/intel/media/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_18
libva info: va_openDriver() returns 0
[ERROR], sts=MFX_ERR_MORE_DATA(-10), InitMfxParams, m_FileReader->ReadNextFrame failed at /opt/src/vpl-dispatcher_src/tools/legacy/sample_decode/src/pipeline_decode.cpp:768
[ERROR], sts=MFX_ERR_MORE_DATA(-10), Init, InitMfxParams failed at /opt/src/vpl-dispatcher_src/tools/legacy/sample_decode/src/pipeline_decode.cpp:562
[ERROR], sts=MFX_ERR_MORE_DATA(-10), main, Pipeline.Init failed at /opt/src/vpl-dispatcher_src/tools/legacy/sample_decod
v3_1080p5994.zip
e/src/sample_decode.cpp:863

Hi @chenhao5-Intel
We are using VPL2023Q1, so the version I compiled is oneVPL GPU Runtime 2023Q1 Release - 23.1.5 (libmfx-gen.1.2.8)
I have reproduced the issue on 12900H with different video formats 1080p5994 1080i5994 720p5994 and put the console log in the attachment.
Also I've intercepted the video of the same clip with different encoding and put it in the github comments.
The one starting with msdk is generated with media sdk encoding and the one developed by amba is generated with amba h2 encoding.
Uploading msdk_1080p5994.zip…
[amba_720p5994.zip](https://github.com/oneapi-src/
msdk_720p5994.zip
amba_1080p5994.zip
msdk_1080i5994.zip
oneVPL-intel-gpu/files/12093848/amba_720p5994.zip)
amba_1080i5994.zip

Hi @DaveHu-TVU  and all,
We have root-caused this issue. We have updated the codes and will open source it soon.
To check this at your side, please test it on i9-12900H, run "export INTEL_MEDIA_RESET_WATCHDOG=0" first and then run sample app commands. There should be no issues.
For Linux i7-12700, please refer to this known issue: https://community.intel.com/t5/Media-Intel-oneAPI-Video/GPU-hangs-when-decoding-2-HEVC-UHD-streams-444-10-bits-Y410/td-p/1431771

OK, Thanks for your help, @chenhao5-Intel


Sui Doc Bug: Make it clear that sui needs to be running in order to run this command

What are the existing URLs containing the issue, if any?
https://docs.sui.io/build/install#sui-tokens
How would you describe the issue? (What needs changing?)
Unable to get client address if sui isnt running.
Too many authority errors were detected: [(k#4f8400704ad774a27ba16f87c60c7f558bf488f71a877e8c25fbe2008293b43b, RpcError("error trying to connect: tcp connect error: Connection refused (os error 61)")), (k#f6a0807f14b123b69868e09a3dddb4e0738c799719677391133eb53ab2e1158d, RpcError("error trying to connect: tcp connect error: Connection refused (os error 61)")), (k#e9a5df473b367e33c889fe6f026a7a6281feedf6ccc44f848a762406425c7db0, RpcError("error trying to connect: tcp connect error: Connection refused (os error 61)"))]

Where should this information land if new? (Learn, Build, Explore, Contribute.)

include sui start to the instructions.

What changes are needed to support this new feature or product? (A simple overview, detailed procedures?)
Who is the audience for that information? (App developers, investors, creators, validators, someone else?)
What precisely must they do with it? (Configure a new service? Process some output?)

Great report! We've started a fix in:
https://github.com/MystenLabs/sui/pull/3503
Thank you!

Thanks again for the input, @Genysys ! This should be resolved. Please reopen if you have additional input.


Merge folders "script" and "help_scripts"

Is your feature request related to a problem? Please describe.
Folders "script" and "help_scripts" have the same purpose.

@TheChristophe, can you do this? I am not sure if I change it how it will impact your environment.

Done in e95566ade703b7846f3e2c0962c17049185e71a0


Permission denied (publickey)

Hello,
Every time I try to connect to my vm i get this error message :
my_name@azure_vm_ip Permission denied (publickey).
How can I fix this?
Thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59b972fe-1a9d-33b3-bb75-5d3c6e0b3466
Version Independent ID: 65cbe522-9ec5-be49-cbf1-76bbda994473
Content: Connect to a Windows Server VM - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/connect-logon.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

@nykekana Sorry to hear that you are facing the login problem.
Can you please share more details on this issue, that can help in assisting you better.

Were you able to login to the VM before without facing issue, when did the issue start?
Did you perform any changes on the VM config?
What is the OS version?
Are you taking backup of the VM?

Hello!
Thanks for getting back to me!
I am able to login to the VM now! I didn't realize it was mandatory to have a username and a password as well as an ssh key.

@nykekana A password isn't required if you use a username + SSH key. Are you trying to log on to a Windows machine or a Linux machine?

I was logging onto Linux machine

@nykekana Glad to hear that the issue is resolved.
For logging into the Linux VM, you either need SSH Key or the Password. You don't need both as you mentioned.
While you deploy the VM, you can give the username and ssh key as show below, this will allow you to ssh into the Linux machine with they ssh key you generated.

Or if you give username and password then you can ssh into the VM with username and password:

However, if you wish to allow both ssh key and password logins to Linux VM, then you can have to change the /etc/ssh/sshd_config config file and restart the sshd service as shown in below screenshot.

sudo systemctl restart sshd
If you deployed the VM with password authentication, then you have to ssh into the VM and in the home directory of the user, you have to add the public key in ~/.ssh/authorized_keys . Allow the modify the config file to allow PublicKey Auth as mentioned above and restart sshd service.
With this you can SSH to VM with both Password and SSH key.

@nykekana
Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.


optimizations for bundle size

removed moment in favor of date-fns (fixes #36)
convert lodash includes to require individual methods (fixes #17)
further webpack lodash optimizations
removed unused babel-lodash plugin
removed unused client-side yaml helper
removed moment helper (and aliased it to formatLocalDate (which uses date-fns)

BUNDLE SIZES:

moment (no locale hack) - 812kB
moment w/ locale hack (what we had before) - 640kB
lodash individual requires - 772kB
lodash w/ module replacement - 764kB
date-fns - 488kB
no client-side yaml helper - 444kB

Coverage remained the same at 100.0% when pulling f5286b77cfd03a81c3b38e1b006b48586841de2b on date-fns into fe928af8c7751ccb0d1c66c39896cff02c259907 on master.


Option flags based on position in argv

I'm trying to port an old CLI interface to sywac and running into an edge case that's tricky.
This configuration tool has options that do different things depending on whether they are before or after commands.  For example:
slalom query -l 'retired' -i '10.11.*' update -l 'Retired'

There's a bunch of options (imagine -l, --label, -n, --name, etc.), but they mean "look for" in the first half of the CLI and "update" in the second half.  I've been playing with nested command blocks and setting up options, but it looks like there is no way to get at the value of the first -l (it is overwritten by the second globally).
Is this just a Sywac thing, where all "options" for the command line are considered global?  If so, I'll probably have to drop down to manually parsing args directly.

@elliot-nelson Hi - sorry I've been so AWOL on providing help with sywac!
My immediate thought would be to interpret -l as an array type (so it can hold multiple values) and then use the 1st element as the "look for" value and the 2nd element as the "update" value.
Otherwise, we might need to plug in a custom type for either the -l flag (to hold multiple values in a more suitable way) or for the command type (to override how "local" flags do or do not override "global" flags - which I'm not entirely sure is possible at the moment, but we could probably figure out something).
To plug in your own type, you can either use sywac.registerFactory(nameString, factoryFunction) or sywac.custom(typeInstance).

@elliot-nelson Here's a super naive/minimalistic example of what I was describing:
require('../sywac')
  .configure({ name: 'slalom' })
  .command('query', {
    setup: sywac => {
      sywac
        .array('-l')
        .string('-i')
        .command('update', {
          run: argv => {
            console.log(`look for ${argv.l[0]} in ${argv.i} and update to ${argv.l[1]}`)
          }
        })
    }
  })
  .showHelpByDefault()
  .parseAndExit()

$ node issue45.js query -l 'retired' -i '10.11.*' update -l 'Retired'
look for retired in 10.11.* and update to Retired

Does something like that make sense for your use-case?

Thanks for the example!  That does make sense, but in reality I probably couldn't rely on it - because there are many fields that can be used as query, update, or both, the array would not always be 2 elements long.
For each field that is 1 element long, there's no way to tell whether the value is supposed to be a query or an update, because the params aren't actually attached to the command in any way.
(And maybe they shouldn't be - not every command line tool should be represented.  Imagine trying to represent a CLI like ImageMagick for example - totally different paradigm.)

Yeah. I'll admit that your example is not something I've seen in a CLI before, and sywac is probably not a good choice for that use-case at the moment.
Thanks for reporting!


[REVIEW] Adding knn demo cuml notebook back into a dask_cuml directory

This was removed for some reason. Note that this knn_demo is different than the knn_demo notebook that lives within the cuml directory.

for organization purposes to not blow up the number of folders, wouldn't it be better to have the dask-cuml folder under cuml? Otherwise its at least 3 extra folders in the repo root

I believe the fix for the dask-cuda issue is to install an older (0.7 or before) version of the conda package. This notebook should be ready to merge.

Looking back over this notebook, it needs some markdown work in order to introduce the cells. I will try to get to this next week.

Closing this. Will get notebook together for dask-cuml k-means. dask-knn notebook should be added back when we release MNMG KNN.


Slightly improve types of map-obj

Not sure how much it'll actually help in practice, but I read an article by @thejameskyle and this kept bugging me in my head.

Ha! This is the right level of obsessiveness.

Looks like Travis fails due to some NPM Problem (ECONNRESET)
Gonna restart Tests once thats resolved. If they pass its a merge.


Improve CI; Add rustfmt & clippy jobs

Closes #198, closes #143. Also applies clippy suggestions and formats all documents, so it is recommended to review on a per-commit basis.

The ones left to my knowledge were impossible to solve without breaking the interface.