The checkpoint feature may not have successfully saved and restored some data.

Describe the bug
The checkpoints are malfunctioning.
Affects version
Commit bae34876780dfb2bc22b9151bfda1d39ee80cfb1 (HEAD -> stable, tag: v<IP_ADDRESS>, origin/stable, origin/HEAD)
gem5 Modifications
None
To Reproduce

Gem5 build

git clone https://github.com/gem5/gem5
sudo apt install build-essential git m4 scons zlib1g zlib1g-dev \
    libprotobuf-dev protobuf-compiler libprotoc-dev libgoogle-perftools-dev \
    python3-dev libboost-all-dev pkg-config python3-tk
# Modify the configuration to make PROTOCOL="MESI_Three_Level" take effect.
scons build/RISCV/gem5.{variant} -j {cpus}

Keystone deployment

sudo apt install autoconf automake autotools-dev bc \
bison build-essential curl expat jq libexpat1-dev flex gawk gcc git \
gperf libgmp-dev libmpc-dev libmpfr-dev libtool texinfo tmux \
patchutils zlib1g-dev wget bzip2 patch vim-common lbzip2 python3 \
pkg-config libglib2.0-dev libpixman-1-dev libssl-dev screen \
device-tree-compiler expect makeself unzip cpio rsync cmake ninja-build p7zip-full
git clone --recurse-submodules https://github.com/keystone-enclave/keystone.git
make buildroot-configure   # Modify the bootloader configuration, check the option to include the kernel as the payload.
make -j`nproc`

Directory structure

.
├── checkpoints
├── gem5
├── keystone
├── m5out
├── riscv-fs.py

Configuration script

import m5
from m5.objects import Root

from gem5.components.boards.riscv_board import RiscvBoard
from gem5.components.memory import DualChannelDDR4_2400
from gem5.components.processors.cpu_types import CPUTypes
from gem5.components.processors.simple_processor import SimpleProcessor
from gem5.isas import ISA
from gem5.resources.resource import  KernelResource,DiskImageResource,CheckpointResource,BootloaderResource
from gem5.simulate.simulator import Simulator
from gem5.utils.requires import requires

requires(isa_required=ISA.RISCV)

from gem5.components.cachehierarchies.ruby.mesi_three_level_cache_hierarchy import (
    MESIThreeLevelCacheHierarchy,
)

cache_hierarchy = MESIThreeLevelCacheHierarchy(
    l1d_size="32kB",
    l1d_assoc=8,
    l1i_size="32kB",
    l1i_assoc=8,
    l2_size="256kB",
    l2_assoc=4,
    l3_size="16MB",
    l3_assoc=16,
    num_l3_banks=1
)

# Memory: Dual Channel DDR4 2400 DRAM device.

memory = DualChannelDDR4_2400(size="3GB")

# Here we setup the processor. We use a simple processor.
processor = SimpleProcessor(
    cpu_type=CPUTypes.ATOMIC, isa=ISA.RISCV, num_cores=2
)

# Here we setup the board. The RiscvBoard allows for Full-System RISCV
# simulations.
board = RiscvBoard(
    clk_freq="3GHz",
    processor=processor,
    memory=memory,
    cache_hierarchy=cache_hierarchy,
)

# Set the Full System workload.
# Use the object file on your machine to specify the arg local_path
board.set_kernel_disk_workload(
    kernel=KernelResource(local_path="./keystone/build-generic64/buildroot.build/images/fw_payload.elf"),
    disk_image=DiskImageResource(local_path="./keystone/build-generic64/buildroot.build/images/rootfs.ext2"),
    # checkpoint=CheckpointResource(local_path="./checkpoints/last_end"), # not at first boot
)

simulator = Simulator(  board=board,
                        full_system=True,
                        )
simulator.run()

simulator.save_checkpoint("./checkpoints/last_end")

Run

./gem5/build/RISCV/gem5.fast ./riscv-fs.py
m5term localhost 3456         # Open a new terminal and execute this command.Wait until the login prompt appears, use the username 'root' and password 'sifive'.
modprobe keystone-driver
/usr/share/keystone/examples/hello.ke # It should execute successfully if gem5 is started from 0 tick.
# Press Ctrl + C to terminate gem5 and wait for the checkpoints to be written.
# Restore from the last checkpoints.
/usr/share/keystone/examples/hello.ke # Run the command again, and it fails to execute.

Terminal Output
src/arch/riscv/pmp.cc:136: warn: pmp access fault.
src/arch/riscv/pmp.cc:136: warn: pmp access fault.
src/arch/riscv/pmp.cc:136: warn: pmp access fault.

Expected behavior
I want to recover from checkpoints, executing the secure program should not result in PMP access error loops. Checkpoints may have lost some crucial data
Host Operating System
Ubuntu 22.04
Host ISA
X86
Additional information
Add any other information which does not fit in the previous sections but may be of use in fixing this bug.

Sounds like PMP register state isn't saved at the checkpoint. Thanks for the detailed bug report!
Feel free to contribute a change to fix this! I can't give an estimate for when someone on my team will be able to take a look, but it will be at least a week or more.

I have added serialization and deserialization code for PMP. After restoring from a checkpoint, I did not encounter PMP access errors during the subsequent execution of the secure program. However, a new issue emerged, and here is the terminal output.

At this point, the TTY has become unresponsive, and attempting to save the checkpoint and restore results in an inability to proceed in the terminal. How can I locate and resolve this issue. More specifically, how can I overview what data is stored in the checkpoint and which data can be omitted to reduce overhead。

You can look at the .cpt file to see all of the data that's stored.
To debug this, here's what I'd do:

Use the Exec debug flag after you take the checkpoint for the next few thousand instructions and then do the same thing on the checkpoint restore. I would compare these traces and look for anything that seems "off"
My first guess is that there's something missing in the takeOverFrom function somewhere in the RISC-V ISA.

I think resolving this issue might be a major undertaking. I saw in the gem5 documentation under the checkpoints section as
shown in the figure below.

Unfortunately, in my configuration, I am using the Ruby memory model while also using the MESI protocol. I don't quite
understand what the relationship is between checkpoints and cache protocols.
I see that the serialization and deserialization methods are defined in the base class Serializable, and SimObject is a subclass of
Serializable. At the same time, almost all components (including storage components, temporary ones, and those that are commit
targets) inherit from SimObject. Not all storage components implement serialization and deserialization methods, right? So why
would different cache protocols affect checkpoints? These questions might seem silly, but I need to emphasize that I am a
beginner with gem5, and I am already frazzled by the extremely slow simulation speed.


PDF be vertical rather then horizontal scrolled in preview section

What feature or improvement do you think would benefit Files?
1.) PDF  preview to be vertical  (PIC 2 )  rather then horizontal scrolled (PIC 1 )in preview section (PIC1 is current, PIC 2 is what we can have)

) Also increase the resolution of PDF preview.

(PIC 1)

(PIC 2)

Requirements

This proposal will accomplish X
This proposal will accomplish Y
This proposal will accomplish Z

Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3208
Comments
No response

PDF preview to be vertical (PIC 2 ) rather then horizontal scrolled (PIC 1 )in preview section (PIC1 is current, PIC 2 is what we can have)

Thank you for your feedback, is vertical better than horizontal for your use case or is this just because File Explorer has it like this?

vertical allows for better reading experience . It feels like a continues reading flow as I can read continuously and scroll up and down between pages. This makes it more continuous and maintains the flow.
In horizontal I only have one page and have to scroll  to read more which is not continuous and breaks continuity, when reading a big document.

PDF preview to be vertical (PIC 2 ) rather then horizontal scrolled (PIC 1 )in preview section (PIC1 is current, PIC 2 is what we can have)

Thank you for your feedback, is vertical better than horizontal for your use case or is this just because File Explorer has it like this?

I would say so yes - however, how well this works with a landscape PDF is less good.
Would it make sense to use Pagination controls, instead of a scrolling list?

We could have borders show up top or bottom as your scroll to hide the cut off

We could have borders show up top or bottom as your scroll to hide the cut off

I find that both concepts are very beautiful but personally I prefer the first.

I find that both concepts are very beautiful but personally I prefer the first.

If by the first you mean the first scrolling design?  Then it may not be possible to achieve the clean closing lines of the cut off items, and so we need to adjust the design.

If by the first you mean the first scrolling design? Then it may not be possible to achieve the clean closing lines of the cut off items, and so we need to adjust the design.

Yes, I'm talking about the first design without the closing lines. I prefer this design because the other disturbs me a little with the lines that protrude on the side. After all, that's just my opinion.

This is how it would look without the lines

I like both of them there: (but I still prefer the one without the lines)

I like both of them there: (but I still prefer the one without the lines)

As do I, but I am not sure it is achievable, especially when you get to the end of an item as it goes out of view

As do I, but I am not sure it is achievable, especially when you get to the end of an item as it goes out of view

There may be workarounds to have this design and that we can navigate the document without having any worries.

This feature is implemented in main and will be included in the next release.


LegacyVersion removed from packaging.version

In https://github.com/pypa/packaging/pull/407 the LegacyVersion class was removed from packaging, which means this module can no longer be used (without pinning packaging back).
This has the flow on effect of breaking simpleindex, even though it shouldn't need to. Can we make the use of LegacyVersion optional by delaying the import? (Or remove the dependency from simpleindex is fine by me, too.)

Since packaging added parse_wheel_filename and parse_sdist_filename, this package can probably be retired altogether. I’ll need to look into it.

I released simpleindex 0.4.0 to switch to the util functions from packaging. If that works for you, I’ll archive this project.

Yep, that worked fine for me 👍


Update the --seed description

In addition to making the test examples order deterministic, --seed also seeds the Random class, making various random generators deterministic.
I tried to find where exactly this change is applies so I could make the description as accurate as possible. I think it happens here, but I'm not 100% sure. In any case though, I think the CLI options should indicate that it makes more things deterministic than just the examples ordering.

Afair, the random number generator is seeded here, and it depends on the configuration if --seed affects it or not.

@JonRowe this change was intentionally made to the CLI options. I was looking for how to set the random number seed and I though it was --seed, but running rspec --help and looking at --seed made me second-guess myself instead of confirming it. That's why I made this PR.
@pirj Ah, that makes sense. I didn't realize it was config dependent. 🤔  I suppose that means this chance won't be true 100% of the time (eg if someone changes that config to use something else for Kernel.srand. But with the default config (which I would venture to say most people are probably using for this one), the --seed CLI option controls the ruby random number generator, and I think this change would help clarify it for people in a quick way.

I was looking for how to set the random number seed and I though it was --seed, but running rspec --help and looking at --seed made me second-guess myself instead of confirming it. That's why I made this PR.

Ah ok, --seed is not intended for that, it is only intended for seeding our random spec ordering.

@JonRowe Hmm... but in the default configs, it does also do that, and the name implies as much.

The CLI help text is explicit, it is the same as the implementation for it. It literally sets options[:order] = "order:#{seed}".
You can also set the kernel seed to the same, but that is secondary, and optional. Any consequences of that should be documented there, not in the CLI. If you wish to expand the documentation in that direction feel free to open another PR, but I won't merge a change to the CLI help text.


Temporary env is not removed if terminal is not properly exited

If a temporary environment is created using pew mktmpenv, it has to be properly exited (e.g. using either exit or CTRL+D) for the environment to be removed.
If the terminal is "improperly closed" (e.g. by using the "close window" icon), then the temporary environment is not removed and must be manually removed (and that's not always easy without autocompletion given the name they can have! ;-))
I realised this when I discovered more than 20 temporary environments with pew ls...
Is there something that can be done about this? I don't think it's easy to detect that a temporary environment is not used anymore, but we can maybe warn the user when a new temporary environment is created that existing ones are still there?

Yeah, I guess that we could print a warning.
for this purpose, we'd probably have to pick a new naming convention (which would also help to delete them), to quickly list them.
Maybe that another possibility would be to overwrite WORKON_HOME with the system temporary directory. That way (usually upon reboot), they'd be cleaned even if the shell had been killed, and they wouldn't litter the usual WORKON_HOME.
The downside is that this would be a subtle behavior change, and the /tmp directory might have more lax read/write permissions than your usual WORKON_HOME (which could be a security liability)... maybe we could create a subfolder of /tmp and restrict permissions?

That could be a possibility. Is there any equivalent of /tmp on Windows?
If we're going to automatically remove temporary environments, we should perhaps add an option to make a temporary environment "persistent" (the workflow being "I would like to test something, I create a tmpenv, I realize I need more tests, I want to keep the environment for later"). Another possibility for that use case is to rely on pew cp, even if it has backwards.


tash: improve replacements handling

These changes are to achieve
diff --git a/task/source-build-oci-ta/0.1/source-build-oci-ta.yaml b/task/source-build-oci-ta/0.1/source-build-oci-ta.yaml
index 716ef4b..dea3257 100644
--- a/task/source-build-oci-ta/0.1/source-build-oci-ta.yaml
+++ b/task/source-build-oci-ta/0.1/source-build-oci-ta.yaml
@@ -45,7 +45,7 @@ spec:
   stepTemplate:
     env:
       - name: BASE_IMAGES_FILE
-        value: /var/source-build/base-images.txt
+        value: /var/workdir/base-images.txt
       - name: BINARY_IMAGE
         value: $(params.BINARY_IMAGE)
     volumeMounts:

Currently, the recipe removes the /var/source-build volume mount and replaces it with /var/workdir, but doesn't do so in the environment variables (causing the task to fail when trying to create a file in a non-existent directory).
Tested by running hack/generate-ta-tasks.sh in build-definitions. The diff pasted above was the only change.

PTAL @zregvart


[TINY] Revert "Fixing build break"

This reverts commit 242d53cfc49dd40932ff3b5cdc0639893d729ad6.
Adding in the missing "Microsoft." that caused the build to break. Not really sure why this only started failing recently since the code has been like this for a while.

:shipit:


New version: TuringBenchmarking v0.3.0

Registering package: TuringBenchmarking
Repository: https://github.com/TuringLang/TuringBenchmarking.jl
Created by: @torfjelde
Version: v0.3.0
Commit: 8f536d6a4d985065993a40e8827da0b58a5d0402
Reviewed by: @torfjelde
Reference: https://github.com/TuringLang/TuringBenchmarking.jl/commit/8f536d6a4d985065993a40e8827da0b58a5d0402#commitcomment-127536424

nooooooo!


Target Group Attachment

When you add Target Group Attachment support?
or how can I add target instances now?

You have to use resources with the output from this module. For eg:
resource "aws_lb_target_group_attachment" "workers" {
  target_group_arn = module.alb.target_group_arns[0]
  target_id        = aws_instance.scheduler.id
  port             = 80
}

I have no immediate need for this feature myself, so I don't have plans to add it to this module. If anyone has time and understanding - PR is welcome.

It appears this merge has made terraform >=13.1 a requirement for ~> 5.0. As documentation states 12.x is supported by ~> 5.0, I would have imagined this would have triggered a major version number update (ie 6.0).  Not sure if this was expected or just missed.


Hardhat and Truffle output different contract sizes

I can deploy contract using Truffle, but not Hardhat. i don't know which one is true.
it's truffle output

it's Hardhat output

Check compiler settings, particularly optimizer runs.  Because this is a Hardhat plugin, it has been tested only with compilation via Hardhat.
Hardhat configuration example: https://github.com/solidstate-network/solidstate-solidity/blob/18744f757fcdf8d9e65803d2723a66b1a1c0461d/hardhat.config.ts#L16-L20


NGX not translating

I'm submitting a ...  (check one with "x")
[X ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[ ] feature request

Current behavior
When i try to use NGX-translate on this current Ionic3 project, neither instant, nor the pipe, nor the get work, i'm always retrieving the key, and i don't know why.

this is my log output. you can see that when i print the .use("ca") output, it prints the translated stuff, but then  i tried translating "accept", whose value should be "acceptar", and it prints the key.
ionic info output:
sh-3.2# ionic info
cli packages: (/usr/local/lib/node_modules)
ionic/cli-utils  : 1.9.2
ionic (Ionic CLI) : 3.9.2

global packages:
Cordova CLI : 7.0.1

local packages:
ionic/app-scripts : 2.1.4
Cordova Platforms  : android 6.2.3 ios 4.4.0
Ionic Framework    : ionic-angular 3.5.3

System:
Android SDK Tools : 26.0.2
ios-deploy        : 1.9.0
ios-sim           : 5.0.13
Node              : v6.9.2
npm               : 5.3.0
OS                : macOS Sierra
Xcode             : Xcode 8.3.3 Build version 8E3004b

ngx version
"ngx-translate/core": "^7.2.0",
"ngx-translate/http-loader": "^1.0.2",
angular version
"angular/common": "4.1.3",
"angular/compiler": "4.1.3",
"angular/compiler-cli": "4.1.3",
"angular/core": "4.1.3",
"angular/forms": "4.1.3",
"angular/http": "4.1.3",
"angular/platform-browser": "4.1.3",
"angular/platform-browser-dynamic": "4.1.3",

Found the error.
rolled back to  "@ngx-translate/http-loader": "^0.1.0", and it worked-

ngx-translate/http-loader requires the new HttpClient provided by Angular 4.3+.

Ionic 3.X doesn't run over angular 4.3+ for now, is there any way to,ehm, fix this?

not really, you can just use the old version until ionic updates its dependencies

what is the latest version that did work 1'00% fine with 4.1.3?

v0.1.0

Thank you very much


[SPARK-30497][SQL]  migrate DESCRIBE TABLE to the new framework

What changes were proposed in this pull request?

Use the new framework to resolve the DESCRIBE TABLE command.
The v1 DESCRIBE TABLE command supports both table and view. Checked with Hive and Presto, they don't have DESCRIBE TABLE syntax but only DESCRIBE, which supports both table and view:

https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DescribeTable/View/MaterializedView/Column
https://prestodb.io/docs/current/sql/describe.html

We should make it clear that DESCRIBE support both table and view, by renaming the command to DescribeRelation.
This PR also tunes the framework a little bit to support the case that a command accepts both table and view.
Why are the changes needed?

This is a part of effort to make the relation lookup behavior consistent: SPARK-29900.
Note that I make a separate PR here instead of #26921, as I need to update the framework to support a new use case: accept both table and view.
Does this PR introduce any user-facing change?

no
How was this patch tested?

existing tests

Test build #116609 has started for PR 27187 at commit 0b729b9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21390/
Test PASSed.

cc @imback82 @yaooqinn @viirya  @HyukjinKwon

Test build #116611 has started for PR 27187 at commit 4e0e8c1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21393/
Test PASSed.

Test build #116611 has finished for PR 27187 at commit 4e0e8c1.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #116609 has finished for PR 27187 at commit 0b729b9.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116609/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116611/
Test FAILed.

retest this please

Test build #116614 has started for PR 27187 at commit 4e0e8c1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21395/
Test PASSed.

Test build #116614 has finished for PR 27187 at commit 4e0e8c1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116614/
Test FAILed.

Test build #116627 has started for PR 27187 at commit 7dcd69b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21408/
Test PASSed.

Test build #116627 has finished for PR 27187 at commit 7dcd69b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116627/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21421/
Test PASSed.

Test build #116643 has started for PR 27187 at commit 234b091.

Test build #116643 has finished for PR 27187 at commit 234b091.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116643/
Test PASSed.

Test build #116706 has started for PR 27187 at commit 7654a20.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21484/
Test PASSed.

Test build #116707 has started for PR 27187 at commit 8ed967c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21485/
Test PASSed.

Test build #116707 has finished for PR 27187 at commit 8ed967c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116707/
Test FAILed.

Test build #116708 has started for PR 27187 at commit 7654a20.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21486/
Test PASSed.

Test build #116706 has finished for PR 27187 at commit 7654a20.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ResolvedView(identifier: Identifier) extends LeafNode

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116706/
Test FAILed.

Test build #116715 has started for PR 27187 at commit 1919054.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21492/
Test PASSed.

Test build #116715 has finished for PR 27187 at commit 1919054.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ResolvedView(identifier: Identifier) extends LeafNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116715/
Test PASSed.


Windows Error: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x92 in position 0: invalid start byte

Good afternoon,
Receiving the following exception on Windows Python 3.7
Traceback (most recent call last):
  File "c:\Program Files (x86)\Python37-32\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\Program Files (x86)\Python37-32\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "c:\dl\udemy\udemy-dl.py", line 1445, in <module>
    main()
  File "c:\dl\udemy\udemy-dl.py", line 1441, in main
    udemy.course_download(path=options.output, quality=options.quality, unsafe=options.unsafe)
  File "c:\dl\udemy\udemy-dl.py", line 515, in course_download
    self.download_lectures_and_captions(lecture_best=lecture_best, lecture_title=lecture_title, inner_index=inner_index, lectures_count=lectures_count, lecture_subtitles=lecture_subtitles, lecture_assets=lecture_assets, filepath=filepath, unsafe=unsafe)
  File "c:\dl\udemy\udemy-dl.py", line 431, in download_lectures_and_captions
    self.download_subtitles(lecture_subtitles=lecture_subtitles, filepath=filepath, unsafe=unsafe)
  File "c:\dl\udemy\udemy-dl.py", line 385, in download_subtitles
    self.convert(filename=filename)
  File "c:\dl\udemy\udemy\_vtt2srt.py", line 87, in convert
    content = self._vttcontents(fname=filename)
  File "c:\dl\udemy\udemy\_vtt2srt.py", line 45, in _vttcontents
    content = [line for line in (l.strip() for l in f)]
  File "c:\dl\udemy\udemy\_vtt2srt.py", line 45, in <listcomp>
    content = [line for line in (l.strip() for l in f)]
  File "c:\dl\udemy\udemy\_vtt2srt.py", line 45, in <genexpr>
    content = [line for line in (l.strip() for l in f)]
  File "c:\Program Files (x86)\Python37-32\lib\codecs.py", line 714, in __next__
    return next(self.reader)
  File "c:\Program Files (x86)\Python37-32\lib\codecs.py", line 645, in __next__
    line = self.readline()
  File "c:\Program Files (x86)\Python37-32\lib\codecs.py", line 558, in readline
    data = self.read(readsize, firstline=True)
  File "c:\Program Files (x86)\Python37-32\lib\codecs.py", line 504, in read
    newchars, decodedbytes = self.decode(data, self.errors)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x92 in position 0: invalid start byte

Sorry I don't know python, but if I put the line in around 369 it bypasses the error, unsure if that is indeed a terrible fix or not:
filename = bytes(filename, 'utf-8').decode('utf-8', 'ignore')

EDIT: Sorry the error still occurs after this change.

@monstermorphic can you please follow the issue reporting guideline i cannot reproduce.

Hello,
Thank you for your beautiful app.
I'm receiving this error too. The workaround is to disable subtitles with '--skip-sub'.
I believe the root cause is when there's a "Translated by Google" option in the lecture's subtitles.
https://i.imgur.com/Eg3avSV.png
Another workaround to download that specific course and lecture number (there is likely a utf-16 character in that google link)
If I may trouble you with a feature request, it would be the option to download English only. I believe that would bypass this bug.
Thanks again for your continuous support!


Add constants for built-in animations

Is your feature request related to a problem? Please describe.
I often use the built-in assets in my demo games as they typically serve as prototypes. While the built-in animations have names associated with them when you hover over them in the asset manager (e.g., sprites.castle.heroWalkLeft), those constants do not appear to be accessible in JavaScript or Python.
Describe the solution you'd like
I would like to see named constants exported and accessible to the typing languages in the editor.
Describe alternatives you've considered
I can create my own constants and assign an array of images to them (using the existing named constants for the images). It works, but it feels clumsy.
Additional context
I can create a PR to add these named constants pretty easily. Just let me know if you want the names to stay in the sprites namespace (just as they already appear in the asset manager), or if you want me to put them in the animation namespace instead (or anywhere else that you'd like).
I also am unsure of the syntax. I see the following code in libs/device/sprites.castle.ts:
namespace sprites.castle {
    //% fixedInstance jres blockIdentity=images._image
    //% tags="people"
    export const heroFrontAttack1 = image.ofBuffer(hex``);
    //% fixedInstance jres blockIdentity=images._image
    //% tags="people"
    export const heroFrontAttack2 = image.ofBuffer(hex``);
    //% fixedInstance jres blockIdentity=images._image
    //% tags="people"
    export const heroFrontAttack3 = image.ofBuffer(hex``);
    //% fixedInstance jres blockIdentity=images._image
    //% tags="people"
    export const heroFrontAttack4 = image.ofBuffer(hex``);
    //% fixedInstance jres blockIdentity=images._image
    //% tags="people"
   ...
}

I also see the associated animation name in libs/device/sprites.castle.jres:
{
   ...
    "heroFrontAttack": {
        "mimeType": "application/mkcd-animation",
        "dataEncoding": "json",
        "data": "{\"frames\":[\"sprites.castle.heroFrontAttack1\",\"sprites.castle.heroFrontAttack2\",\"sprites.castle.heroFrontAttack3\",\"sprites.castle.heroFrontAttack4\"],\"flippedHorizontal\":false}"
    },
   ...
}

What would the constant and the annotations look like?

hmmm.... this is not supported today. animations are different than images in that they are actually just references to other images. you can see it in the jres you posted; the data doesn't actually contain any image data, just a list of qualified names. when we emit the animations for the project in images.g.ts we produce some code that looks like this:
    helpers._registerFactory("animation", function(name: string) {
        switch(helpers.stringTrim(name)) {
            case "myAnim":
            case "anim1":return [
                img`.`,
                img`.`
             ];
        }
        return null;
    })

that factory function then constructs the array at runtime when you call assets.image`anim` .
we could theoretically declare it like this:
namespace sprites {
    //% whenUsed
    export const heroWalkLeft = [sprites.castle.heroWalkLeft1, sprites.castle.heroWalkLeft2]
}

but this would be confusing the semantics of animations a bit. for example, consider these two snippets:
sprites.heroWalkLeft.splice(1)
assets.image`heroWalkLeft`.splice(1)

these look very similar but would have confusing/different results to the end user if they were referenced in multiple places. subsequent calls to sprites.heroWalkLeft would all have the first frame missing while calls to assets.image`heroWalkLeft`  will return a new array each time.

we also can't just do a super factory function that handles reference for all of the gallery assets because that would thwart the tree-shaking our compiler does to reduce code size.
when we compile projects, we only include assets that are actually referenced by the code in the compiled image; this prevents us from including every asset in the gallery for every compiled project. if we were to emit a factory function that references every gallery asset, then they would all be compiled every time because they are now referenced by a piece of code (the factory function).

Continuing to pick your brain, then, about how assets would be included in a compiled project.
Say I want to create an avatar selection mechanism. I'm thinking about something like this:
interface Avatar {
    name: string
    image: Image
    animation: Image[]
}

const AVATARS: Avatar[] = [
    {
        name: 'Hero',
        image: sprites.castle.heroWalkSideLeft1,
        animation: [
            sprites.castle.heroWalkSideLeft1,
            sprites.castle.heroWalkSideLeft2,
            sprites.castle.heroWalkSideLeft3,
            sprites.castle.heroWalkSideLeft4,
        ]
    },{
        ...
    }
]

// Players' selected avatars.
let playerAvatars: number[] = []
playerAvatars[0] = 0 // First player is using the Hero avatar
playerAvatars[1] = 8 // Second player is using some other avatar that I've defined :-)

Will the compiler shake the tree correctly and only use the assets that I've declared in AVATARS, or should I be using these constants differently to help the compiler along?

that should work just fine!

You're the best! Thanks, @riknoll ! I'll close this issue.


Test the second one created in github

[](https://linear.app/clusterix-pm/issue/PRO-11/hello-there-where-are-you-assigned)

https://linear.app/clusterix-pm/issue/PRO-11/hello-there-where-are-you-assigned


Bug Fixes Round 2

Based off of the list in Slack. I'll update this before tackling new issues so that we can stay in sync
Changes

[x] Transformation in filter screen should be “Aggregation”
[x] Bin gets cut off in the filter tab
[x] Change the active state of history entry to be a bold dark primary left border
[x] Filter screen labels should be closer to their corresponding inputs.
[x] Purple plus button in edit menu
[x] Round bottom corners of Sidebar
[x] Move X button over to the right in filter screen
[x] Assign position relative on the checkbox input fields
[x] On small viewport fix bug where filter screen disappears
[x] Take out duplicate 3 dot menu generated by Vega
[x] Eliminate facet recommendations in recommended charts
[x] Set max height on help menu and make overflow scroll to stop content from being cut off
[x] Move help menu from the Chart chooser to the column selector

Fixes #112


Revert "[SPARK-36038][CORE] Speculation metrics summary at stage level"

This reverts commit 73747ecb970595d49c478b0eb65f5132c8b0bf02.
See the comment.

This PR just reverts the previous change so I'll merge this soon.

Merged to master.


fix: create export image parsing

replaced by https://github.com/luzmo-official/luzmo-sdk-nodejs/pull/20


README.md

Shouldn't pip install git+https://github.com/brain-score/brain-score be pip install git+https://github.com/brain-score/vision given that the repo name was changed and that https://github.com/brain-score/brain-score redirects to https://github.com/brain-score/vision?

Never mind I just saw #432.


Fix typo

Codecov Report

Merging #11 into master will increase coverage by 0.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     88.75%   89.18%   +0.43%
- Complexity       63       69       +6
============================================
  Files            10       10
  Lines           169      185      +16
  Branches         19       20       +1
============================================
+ Hits            150      165      +15
- Misses           10       11       +1
  Partials          9        9

Impacted Files
Coverage Δ
Complexity Δ

...tx/ext/web/handler/sse/impl/SSEConnectionImpl.java
85.71% <0%> (-1.39%)
28% <0%> (ø)

...xt/web/handler/sse/impl/EventBusSSEBridgeImpl.java
100% <0%> (ø)
3% <0%> (+1%)
:arrow_up:

...vertx/ext/web/handler/sse/impl/SSEHandlerImpl.java
96.55% <0%> (+0.39%)
8% <0%> (+2%)
:arrow_up:

...ertx/ext/web/handler/sse/impl/EventSourceImpl.java
91.22% <0%> (+1.86%)
18% <0%> (+3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65eb4f...096c801. Read the comment docs.

Thanks a lot for the PR.


Management: Project Manager, Program Manager, and Portfolio Manager

Difference between manager roles

@monotykamary please help to take a review on this one mate

@janrvu please help me to have another review, had updated the wrong typo


Add download_logs.sh

Now we can download node logs from download_logs.sh script. It will download logger/logs/8080 & error_logs.txt

Thanks for reviews! Merging


Alt-Keypress not marked as handled when rectangular selection is done

In my application, I use AvalonEdit as text editor, whilst also having a third-party Ribbon control. That Ribbon control shows keyboard shortcuts when the user presses the Alt-Key. In general this works.
However, when doing a rectangular selection using the mouse (i.e. press Alt, drag with mouse, release Alt), the Alt-KeyUp event is not marked as handled by AvalonEdit. This results in the Ribbon incorrectly showing the keyboard shortcuts (since it seems that user simply pressed and released the Alt-Key).

I was able to make a workaround, via handlers for PreviewMouseLeftButtonDown and KeyUp (essentially trying to check if a rectangular selection had occurred). A better solution would be to fix this in the code (I can send a PR), but I don't know if you want such a change.

When creating a rectangular selection you first press [Alt] and then use the mouse or the keyboard to select text. When [Alt] is first pressed, we can't and shouldn't mark the key press as handled by AvalonEdit because it might be intentional to show the accessor keys. On the other hand it is impossible to go back in time and change our decision once selection via mouse or keyboard starts.
If you have a pull request/solution for this, you are welcome to provide it. However I don't see how we could fix this because we would end up eating all Alt key-presses.
Other editors like Notepad++ behave the same. The accessor keys in menu bars are simply less visible and therefore you never notice them while editing text.


Fix tests/cmd/iac/test_scan.py tests using modified cassette output

Description
As found out in #302, 3 tests use a modified cassette output to simulate errors:

tests/cmd/iac/test_scan.py::test_iac_scan_error_response
tests/cmd/iac/test_scan.py::test_iac_scan_json_error_response
tests/cmd/iac/test_scan.py::test_iac_scan_unknown_error_response

Keeping cassettes unaltered makes it possible to detect when the test expectations diverge from the real server behavior by regularly running tests without cassettes.
If the code cannot be tested without altering the cassettes then the tests should use a different way of simulating the wanted behavior.
TODO
Rewrite these tests so that they do not rely on modified cassettes, either by simulating the error with a real server call or by mocking at a different level, for example using MockerFixture. This is what tests/cmd/iac/test_scan.py::test_iac_scan_error_response_read_timeout does.

Fixed by #370


Welcome message fix

Fixes #20

Changes proposed
Fixed #20

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagarised content.
[x] The title of my pull request is a short description of the requested changes.

This is fixed with some more updates and is currently under beta testing. It would be rolled out soon. Thanks for the contribution though. :)


DOC: Improved documentation for jax.numpy.roll

Part of https://github.com/google/jax/issues/21461

Thanks @jakevdp for a quick review!
Comments fixed.


KAFKA-12897: KRaft multi-partition placement on single broker

https://github.com/apache/kafka/pull/10494 introduced a bug in the KRaft controller where the controller will loop forever in StripedReplicaPlacer trying to identify the racks on which to place partition replicas if there is a single unfenced broker in the cluster and the number of requested partitions in a CREATE_TOPICS request is greater than 1.
This patch refactors out some argument sanity checks and invokes those checks in both RackList and StripedReplicaPlacer, and it adds tests for this as well as the single broker placement issue.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

< JDK 11 test seems to have failed with 20 failures. Are they related to this PR?
Thanks for the review, @junrao.  Those failures are unrelated -- they are due to https://issues.apache.org/jira/browse/KAFKA-12892.

For example, here's one of the 20 failures:
[2021-06-05T02:12:18.820Z] AuthorizerIntegrationTest > testDeleteGroupApiWithDeleteGroupAcl() STARTED
[2021-06-05T02:12:18.820Z] kafka.api.SslAdminIntegrationTest.testAclUpdatesUsingSynchronousAuthorizer() failed, log available in /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10823/core/build/reports/testOutput/kafka.api.SslAdminIntegrationTest.testAclUpdatesUsingSynchronousAuthorizer().test.stdout
[2021-06-05T02:12:18.820Z]
[2021-06-05T02:12:18.820Z] SslAdminIntegrationTest > testAclUpdatesUsingSynchronousAuthorizer() FAILED
[2021-06-05T02:12:18.820Z]     org.apache.zookeeper.KeeperException$InvalidACLException: KeeperErrorCode = InvalidACL for /kafka-acl


Does not work on node < 4.5.0

Summary
Your package.json specifies a node version of >=4 however one of your dependencies has a version of >4.5.0 (hawk)
https://github.com/hueniverse/hawk/blob/master/package.json
Simplest Example to Reproduce
var request = require("request")

Current Behavior
This causes the following error when requiring request on older node versions such as 4.2.0
Uncaught Exception Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:414:25)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at require (/Users/username/app/node_modules/hawk/lib/index.js:1:258)
    at Object.<anonymous> (/Users/username/app/node_modules/hawk/lib/index.js:5:33)

Possible Solution
Either bump the minimum supported node version, or get hawk to loosen up.
Context

Your Environment

software
version

request
2.82.1

node
4.2.0

npm
2.14

Operating System
Ubuntu

Closing as duplicate of several other issues.

@mikeal I can't seem to find these duplicate issues. Could you please link them so we can track them easier? (and if someone finds this issue through a search)

They are all closed. Look at the recent closed issues. We cut support for EOL Node.js versions almost a year ago.


Your requirements could not be resolved to an installable set of packages.

Your requirements could not be resolved to an installable set of packages.
Problem 1
- brainmaestro/composer-git-hooks[v2.8.0, ..., v2.8.2] require symfony/console ^3.2 || ^4.0 -> found symfony/console[v3.2.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev] but the package is fixed to v6.1.5 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
- brainmaestro/composer-git-hooks[v2.8.3, ..., v2.8.5] require symfony/console ^3.2 || ^4.0 || ^5.0 -> found symfony/console[v3.2.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev, v5.0.0-BETA1, ..., 5.4.x-dev] but the package is fixed to v6.1.5 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
- Root composer.json requires brainmaestro/composer-git-hooks ^2.8 -> satisfiable by brainmaestro/composer-git-hooks[v2.8.0, ..., v2.8.5].
Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require brainmaestro/composer-git-hooks:*" to figure out if any version is installable, or "composer require brainmaestro/composer-git-hooks:^2.1" if you know which you need.
Installation failed, reverting ./composer.json and ./composer.lock to their original content.
How can I solve this problem in laravel 9 and php 8?

Can you try v3.0.0-alpha.1

I ran into this too.  Tried the alpha release as requested, and it installed without error.
composer require --dev brainmaestro/composer-git-hooks:v3.0.0-alpha.1

Hey, there are any foresight for a stable release that covers this error?

I can report that that once I install this alpha and run composer update, it doesn't seem to create the expected files inside .git/hooks so basically the package has no effect.


JobSubmitter stuck on vocms0116.cern.ch

I am not sure what is wrong. I figured I just restarted everything but it is still red. It does not look like it is disk issue.

JobSubmitter process was gone, shown as "Not running" in the status and logs dead since ~4h ago:
2017-03-09 05:02:13,578:140490717083392:INFO:JobSubmitterPoller:Have 5 packages to submit.
2017-03-09 05:02:13,579:140490717083392:INFO:JobSubmitterPoller:Have 1000 jobs to submit.
2017-03-09 05:02:13,579:140490717083392:INFO:JobSubmitterPoller:Done assigning site locations.


G2H RTSP

Hello. Can you please help me: how to enable the sound by RTSP?

try /13, ie. rtsp://[your ip]:554/13 (the port number is not necessary if you are using default one)

try /13, ie. rtsp://[your ip]:554/13 (the port number is not necessary if you are using default one)

There is no sound in 13

Can confirm 15 has sound on mine. Try them all...


Payment - Preview is not shown when deleting paypal.me payment method

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #8025
Action Performed:

Open app in mobile/ use expensify in desktop web and decrease the screen size
Go to Settings -> Payment
Add paypal account in add payment method
Select Paypal.me
Click on Paypal.me above delete button

Expected Result:
I can see Payment preview
Actual Result:
I do not see Payment preview
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:  1.1.42-3
Reproducible in staging?: Y
Reproducible in production?: Y (New feature)
Email or phone of affected tester (no customers<EMAIL_ADDRESS>/ w323052760We
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
Issue was found when executing #8025

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Except of the issue which is already linked (which I am not sure if is causing this problem), there is also this PR which made changes to this:
https://github.com/Expensify/App/blob/d05c56eb375b4d9042dce964022cdc87fed271c8/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L228
so it might be causing the anchorPositionTop to not be zero on desktop if there is only the paypal me option (I see in the Pr that the tests were usually with more options).
Also not sure if this needs to be deployblocker if it also occurs in Production. Can users use Paypal.me now in N6? They cant use IOU yet.

@mountiny the changes that I did only kept the position of the menu while the window resize on the desktop which was the same logic to set position before. Nothing changed in the menu UI or show/hide logic.
https://github.com/Expensify/App/blob/d05c56eb375b4d9042dce964022cdc87fed271c8/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L93-L105
I thought the payment preview was only shown for the mobile site because the delete button on the desktop is right under the Paypal payment item.
Thus, I am quite sure that the change in the PR is not linked to this issue.

@phivh Thank you very much for looking into this 🙇

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Slack thread summary, this is already how it is on production and seemed to have been introduced by this PR: https://github.com/Expensify/App/pull/7741
Since it's on prod it shouldn't block the deploy, but we should fix the preview once we determine how it should be.

Upwork post here

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

Triggered auto assignment to @marcaaron (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Proposal
We show the preview if isPopoverBottomMount is true, if we wanna show the payment preview in all the cases then we can just remove this check
https://github.com/Expensify/App/blob/3696074348ee1e3be83f0b5ec5d7d2590d589a73/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L305-L309
also we aren't using isPopoverBottomMount anywhere else so I think we can also remove it from here -
https://github.com/Expensify/App/blob/3696074348ee1e3be83f0b5ec5d7d2590d589a73/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js#L228

@marcaaron
Showing preview would look redundant, as the popup is close to the selected payment method.

Can you confirm on this do we need this change?

@marcaaron
If we need this change we are good to go with @thesahindia proposal https://github.com/Expensify/App/issues/8097#issuecomment-1068253075
🎀👀🎀 C+ reviewed

I don't really get this issue at all or understand why we need a preview for this. Seems extremely low value to me.

@madmax330 says

we should fix the preview once we determine how it should be.

I think it should be exactly how it is now. If anyone disagrees feel free to reopen.


chore: Update package description

Make it a bit longer so that pub.dev is happy...

#90
#89  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Mr-Pepe and the rest of your teammates on  Graphite

LGTM


python310Packages.pyvicare: 2.16.4 -> 2.17.0

Description of changes
Update to latest upstream release  2.17.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 191656 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.vicare
python310Packages.pyvicare
python39Packages.pyvicare


docs: add changelog 4.2.12

Description

add docs for 4.2.12

Checklist:

[x] Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[x] User guide updated
[] Conforms to style guide

Added two bug fixes.


updated vpc module version in examples

@jatalocks Merge, please. I hope this will be the last change.


[Question] Pre 1.13 Seed Cracking

Will pre 1.13 server versions every be added? If its not impossible, I think it would be cool if the SeedCracker was able to crack the seed of ex: 1.12.2 worlds

KaptainWutax has said that he wont be doing it in one of the first issues as it was originally intended for 1.14.4

Np, I already found a fork that adds 1.8-1.16 support to the seedcracker

Can you link it here. Thanks

https://github.com/19MisterX98/SeedcrackerX


How to execute something after rejecting incoming call ?

@SayedShalan
please using event CallEvent.ACTION_CALL_DECLINE
also make sure FlutterCallkitIncoming.onEvent.listen on app widget

@hiennguyen92 Yes, but it isn't called if app is terminated

@SayedShalan Once you receive the pushkit/VoIP the app will automatically be reactivated.

It's imperative for IOS that you incorporate pushkit.

@hiennguyen92 Thank you for your response, I mean I have incoming call from fcm, I need when I Reject the incoming call then the callback will work. It is called if app is on foreground or terminated but not work if app terminated, Just it cancel the call.

When you receive VoIP, the app will automatically activate from terminated state. So, FlutterCallkitIncoming.onEvent.listen will working.

@SayedShalan How did you solve this?


fixed swift swiftUI errors

🚀 Deployed on https://65f4e922db100255158990a5--cozy-fox-0defec.netlify.app


first problem

Description

Why

Possible Implementation & Open Questions

Is this something you're interested in working on?

[ ] YES
[ ] NO

finally kuch


Python path doesn't include current directory when running 'banana dev'

The python path doesn't include the current directory when running 'banana dev', so you can't import packages or modules from the current folder.
To reproduce:
mkdir banana-import-bug-test
cd banana-import-bug-test
banana init

testmod.py
print("hello world")

app.py
[...]
import testmod

import sys
print(sys.path)
[...]

Works:
$ python app.py
['[...]/banana-import-bug-test', [...]]
Hello world
------
Starting Potassium Server 🍌
Running init()
[...]
Serving at http://<IP_ADDRESS>:8000
------

Errors:
$ banana dev
------
Starting server 🍌
['[...]/banana-import-bug-test/venv/bin', [...]]
Traceback (most recent call last):
[...]
ModuleNotFoundError: No module named 'testmod'

The dev server has been removed in the latest versions of the CLI. Running python app.py is the canonical way moving forward. 👍


Update information about Xcode for Xamarin and links

@jamesmontemagno : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @jamesmontemagno - This pull request was opened in the public repo. The content has a private repository, and PMs generally should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

@ktoliver for sure, i can move it over. I usually do that for xamarin stuff, but didn't know for vs.

Thanks @jamesmontemagno


GH-41978: [Python] Fix pandas tests to follow downstream datetime64 unit changes

Rationale for this change
Pandas changed the default unit used in certain cases for the datetime64[unit] dtype. This causes some failures in our test suite when tested with pandas 3.0.0.dev

GitHub Issue: #41978

@github-actions crossbow submit test-conda-python-3.10-pandas-nightly


Edit review section and conflicts resolved

Fixes:  #55
I have resolved all the conflicts. Please have a look

I have resolved all the conflicts. Please check from your side

@Bhum-ika Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution to GSSOC'24 EXTENDED! 🎉

Thank you priya!


Custom top value and empty chart data

Hello. First of all I want to thank you for this amazing library.
Currently I have two problems. I want to show a time based chart(minutes per days in a week period)

The library generates startAxis values itself. Is there any way to customize it? I want to step every row by 1 hour.

For example in this case steps should be 1h, 2h and 3h.
note that inputs are per minute.

How can I cut the line when entered value is 0? In the above sample the line should stop in Tuesday.

Thank you.

Thanks for your passion.
For 2nd problem, I mean Tuesday because the is no data available for Friday, Saturday, and Sunday(the values are 0.0 for these days). I want the final chart to look like this:

In that case, I’d suggest not adding entries with a y-axis value of zero to the entry list to begin with. For example, if you have a list of numbers that you map to ChartEntry instances, you can use .filter { it != 0f } before map.

Thanks.


Escape XML reserved characters so that we don't create invalid xml

Added an escapeXmlEntities function to escape XML reserved characters and use it wherever labels are being added to xml.  Otherwise we end up with invalid XML.

Thanks @kyrrigle !


InvalidArgumentError: Graph execution error

Hello,
I am trying to run a model and getting this error where Tensorflow is trying to use the CUDA-based CudnnRNN operation, which is not available because I'm running TensorFlow with DirectML, not CUDA. I have a NVIDIA Geforece RTX 3070 that I am trying to use as the GPU.  Anyone come across this issue before that can assist?
Here is the error:
WARNING:tensorflow:AutoGraph could not transform <function Model.make_train_function..train_function at 0x00000296030349D8> and will run it as-is.
Please report this to the TensorFlow team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output.
Cause: 'arguments' object has no attribute 'posonlyargs'
To silence this warning, decorate the function with @tf.autograph.experimental.do_not_convert
WARNING: AutoGraph could not transform <function Model.make_train_function..train_function at 0x00000296030349D8> and will run it as-is.
Please report this to the TensorFlow team. When filing the bug, set the verbosity to 10 (on Linux, export AUTOGRAPH_VERBOSITY=10) and attach the full output.
Cause: 'arguments' object has no attribute 'posonlyargs'
To silence this warning, decorate the function with @tf.autograph.experimental.do_not_convert
InvalidArgumentError: Graph execution error:
No OpKernel was registered to support Op 'CudnnRNN' used by {{node CudnnRNN}} with these attrs: [seed=0, dropout=0, T=DT_FLOAT, input_mode="linear_input", direction="unidirectional", rnn_mode="lstm", seed2=0, is_training=true]
Registered devices: [CPU, GPU]
Registered kernels:

 [[CudnnRNN]]
 [[sequential_3/lstm_4/PartitionedCall]] [Op:__inference_train_function_15221]

I ran into a similar issue a few weeks ago whilst trying to get TF>2.10 to use a GPU on Windows.
I resorted to compiling TF and TFDM from source and debugging it - so far as I could see the DirectML plugin does not register the 'CudnnRNN' OpKernel and hence the error. It appears this is an optimized kernel for vanilla LSTMs with parameters constrained as per TF docs. If you deviate from these params then I found that TF doesn't use the 'CudnnRNN' kernel and will use a non-optimal kernel(s) that do work - for example if you add a non-zero 'recurrent_dropout" to the LSTM layer.
I noticed there is a branch which looks like it will include the 'CudnnRNN' OpKernel, but downloading and compiling that, it looks very much like a work in progress - you need to fix a few bugs to get it out of the starting blocks but it clearly needs work.
I didn't find much help on this issue myself, so I hope my comments are of some use!

If I or anyone want to wait for it to be fixed, how long will I or anyone have to wait?

Who's to say? This is the branch I was referring to (https://github.com/microsoft/tensorflow-directml-plugin/tree/user/wumaggie/cudnn-kernels) at this time it's 9 months old - so sad to say this project appears low priority or at worst dead,

I think I understand now that problem. But i didn't understand how this can be fixed? I can downgrade TF and that can be fixed or any other way to fix that?

I noticed there is a branch which looks like it will include the 'CudnnRNN' OpKernel, but downloading and compiling that, it looks very much like a work in progress - you need to fix a few bugs to get it out of the starting blocks but it clearly needs work.

Maybe I stupid or my english so bad but I didn't understand where i need fix a few bugs (honestly, I'm not even sure I could fix a few bugs if I knew exactly where to do it)

I apologize for the delay. We had to pause the development of this plugin until further notice. For the time being, all latest DirectML features and performance improvements are going into onnxruntime for inference scenarios. We'll update this issue if/when things change.


Install same lib again but different versions doesn't work

Version: 2.0.4
Platform: Linux work 4.3.3-3-ARCH #1 SMP PREEMPT Wed Jan 20 08:12:23 CET 2016 x86_64

npm behavior:
npm install jquery@3 -> node_modules/jquery =<EMAIL_ADDRESS>then
npm install jquery@2 -> node_modules/jquery =<EMAIL_ADDRESS>ied behavior:
ied install jquery@3 -> node_modules/jquery =<EMAIL_ADDRESS>then
ied install jquery@2 -> node_modules/jquery =<EMAIL_ADDRESS>(doesn't change)
The installed jquery in node_modules/jquery didn't be changed since the first/clean install, is this a bug? Thanks!

This is kind of by design. Problem is in the local resolve mechanism:
https://github.com/alexanderGugel/ied/blob/master/src/install.js#L69

Just fixed this in a375f38, I've only added semver check for explicit install to minimize the performance hit & since I'm not sure it should be needed otherwise.

Still not work for me on v2.0.5. (BTW, v2.0.5 version tag is missing in git repo)

Thanks, will this be shipped on a new version soon? Just asking, thanks.

Yup, this will be included in the next version.

Okay, thanks.


Improve docs: ES6 usage example

First, thanks for great work!
Second, I followed the example and struggled for a few minutes to get this to work in ES6 before I realising that I needed to do import * as d3 from 'd3' instead of `import d3 from 'd3', as per this thread.
@Olical, do you have any plans to update the docs to include some ES6 usage example, or should I do a simple PR with an ES6 example?

Ah, that's a sneaky one that caught me out too. Not the first time I've been angry at the JavaScript module system (or JavaScript in general). It'd definitely be worth documenting it, even though D3 isn't a hard requirement for this project it's something that will catch people out again and again.
Maybe add a section to the readme just after installation that shows ES5 and ES6 import styles with the D3 caveat. Maybe even a script tag for the CDN version too. One quirk about the CDN file (which I don't use, some people requested it, I think you should depend on it and build it into your main script) is the name it's exported with. It's accessed by window['react-faux-dom'] not window.ReactFauxDOM as you'd expect.
Could be worth mentioning that too. I can do it but if you had some time and wanted to write up a little readme section I'd be happy to merge it :smile:

I am new to all this, but here is an attempt: #65 .
I only covered basic D3+ES6 usage, and not other issues you mentioned.


GPU particles don't work in GLES2

Godot 3.2 beta2
Windows 10 64 bits
OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2
Steps:

Create a Particles node
Assign a new default ParticlesMaterial
Add a draw pass with cubes: nothing shows up so far.

The same steps in Godot 3.1.1 successfully show falling cubes.
The same issue happens with Particles2D.

Why are you closing?

Because I didn't realize I was actually trying this using the GLES2 renderer. I got the OpenGL version wrong in the report.

I wonder if we should print an error message when instancing a Particles or Particles2D node when using the GLES2 renderer. This would complement the existing node configuration warning, which may be missed when instancing nodes at run-time.


Create static.yml

Allows you to publish your static html to a custom page for your repo. I haven't configured this file at all.

:shipit:


ForcedHotWaterMode

In majority I'm using melcloud app only to check temperature of hot water tank and if it's "low" (for my wife) I'm forcing pump to heat the water. I'd like to do the same from NodeRed. Unfortunately by sending command: "ForcedHotWaterMode": true, it doesn't work. Any chances to make it working?

Same for "SetHeatFlowTemperatureZone1" please so it would be possible to change the parameter based on other sensors in HA. Thank you.


Update Board Columns

This of course might be in a different document but no mentioned here. I struggled finding a way of why my bug didn's show up. It was because I missed to update the Board Columns in the setting section. This won't happen for the Definition of Done default columns but it will for those updated ones.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c85fc76f-6cf3-2b74-0d50-cd8500b56679
Version Independent ID: 84fce3ee-5f76-6529-8e97-1ccf0ab68344
Content: Resolve backlog issues
Content Source: docs/work/backlogs/resolve-backlog-reorder-issues.md
Product: devops
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

Hi MarcoDeJesus! Would it help if the documents were more clear about how to get bugs to show up on boards?


Update NYKO Airflo EX mappings to match upstream.

These were fixed upstream 3 years ago (#200) but I forgot to submit the corrections here. Sorry! :(
The upstream macOS mapping seems to have found its way here separately so I didn't change it.

Thanks!


added test for aimsun struct

Pull Request Test Coverage Report for Build 2933

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 88.636%

Totals

Change from base Build 2932:
0.3%

Covered Lines:
7644

Relevant Lines:
8624

💛  - Coveralls


Some lidar timestamps are not synchronized to seven ring cameras.

I find that when using the SensorDataloader, some lidar timestamps are not synchronized to seven ring cameras. Some only give six synchronized imageries. Is the tolerance of synchronization too strict?

Yes, when I tried to find the closest images from the point cloud samples, the longest ineterval between an image and its closest point cloud is 147 ms. It seems that some of the images are lost


Wildcard version warnings generated for local file dependencies

PR #227 seems to generate wildcard warnings when using standard path dependencies and specifying no version (as one is using the local file version), don't think that should generate warnings.
Such as:
[dependencies]
telemetry = { path = "../telemetry" }

Think we should only generate wildcard warnings when one is explicitly using the version field for the crates.io version.
Note that one can also use both a path depependency and a version dependency, where building locally uses the path dependency and building from a crates.io published dependency uses the specific version, then the wildcard warning should still trigger if using wildcard version:
[dependencies]
telemetry = { path = "../telemetry", version = "*" }

cc @khodzha @Jake-Shadle

i dug around a bit and couldnt find a way to distinguish { path = "../telemetry", version = "*" } and { path = "../telemetry" } based on cargo metadata output :disappointed:

Ouch that is unfortunate, this we do have to have some solution for as it is very common, hmm

I don't think that's possible because not even cargo knows that. (At least their metadata output)

This relates a bit to #136, where the intention would be to actual properly parse Cargo.toml manifests for doing error reporting, so having that utility (probably in a separate crate eg krates probably) would mean you could query both the cargo metadata, but also the actual entry in the manifest to distinguish between them for special cases such as this.

It would be nice if I could configure cargo-deny to only warn on / error on wildcard registry dependencies (not git or path dependencies), regardless of whether it was specified explicitly or not.


Package constraints and stack?

Was trying to pull this into a project that I'm working on, which uses stack, but ran into dependency constraints. Can I just fork this repo and remove all version constraints in the cabal file? Will anything terrible happen?
Using configuration file: stack.yaml
Using cabal packages:
- webservice.cabal
- opaleye-helpers/opaleye-helpers.cabal

Using resolver: nightly-2017-03-01
Using compiler: ghc-8.0.2
Asking cabal to calculate a build plan...
Trying with packages from nightly-2017-03-01 and 9 external packages as hard constraints...
Attempt failed.

>>>> Cabal errors begin
Warning: cannot determine version of /usr/bin/strip :
""
cabal: Could not resolve dependencies:
trying: webservice-<IP_ADDRESS> (user goal)
next goal: liquid (dependency of webservice-<IP_ADDRESS>)
rejecting: liquid-<IP_ADDRESS>, <IP_ADDRESS> (conflict: lens==4.15.1, liquid =>
lens>=4.14 && <4.15)
trying: liquid-<IP_ADDRESS>
next goal: vector (dependency of webservice-<IP_ADDRESS>)
rejecting: vector-<IP_ADDRESS> (global constraint requires ==<IP_ADDRESS>)
rejecting: vector-<IP_ADDRESS> (conflict: liquid => vector>=<IP_ADDRESS> && <0.12)
rejecting: vector-<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>,
<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, 0.10, 0.9.1, 0.9, 0.8,
0.7.1, <IP_ADDRESS>, 0.7, <IP_ADDRESS>, <IP_ADDRESS>, 0.6, 0.5, 0.4.2, 0.4.1, 0.4, 0.3.1,
0.3, 0.2, 0.1, <IP_ADDRESS>, <IP_ADDRESS> (global constraint requires ==<IP_ADDRESS>)
Dependency tree exhaustively searched.
<<<< Cabal errors end

Retrying with packages from nightly-2017-03-01 and 9 external packages as preferences...
Attempt failed.

>>>> Cabal errors begin
Warning: cannot determine version of /usr/bin/strip :
""
cabal: Could not resolve dependencies:
trying: opaleye-helpers-<IP_ADDRESS> (user goal)
rejecting: opaleye-helpers-<IP_ADDRESS>:!test (global constraint requires opposite
flag selection)
trying: opaleye-helpers-<IP_ADDRESS>:*test
next goal: th-opaleye (dependency of opaleye-helpers-<IP_ADDRESS>:*test)
fail (unknown package: th-opaleye)
Dependency tree exhaustively searched.
<<<< Cabal errors end

*** Failed to arrive at a workable build plan.

Solver could not resolve package dependencies.
You can try the following:
    - Update external packages with 'stack update' and try again.
    - Tweak stack.yaml and try again
        - Remove any unnecessary packages.
        - Add any missing remote packages.
        - Add extra dependencies to guide solver.

Nothing terrible will happen. It needs bumping to the latest stackage. If you want to do a PR I'll try to deploy it as soon as I can. Otherwise, I'll try to get to bumping the version constraints myself soon.

Thanks for the prompt response. Let me try and get back to you tomorrow. Leaving for the day 👍

I can confirm that removing version bounds completely works as expected!

Great. If you'd like to submit a PR - I'll try to upload to hackage as soon as I can.