Unify ConstraintGraph change tracking with SavedTypeVariableBindings

I'd like to get rid of all the state that's inside SolverScope today, and instead record a trail of changes to individual data structures. This is a preliminary PR which moves the ConstraintGraph change tracking into a new CSTrail.cpp, which defines a SolverTrail. I also refactored the existing logic for saving and restoring the fixed types of type variables to use SolverTrail.
For now, there's a hack in there to preserve the previous behavior where type variable bindings are restored before all constraint graph changes. Once I untangle some other issues I will streamline this. Next steps after that are converting all other state tracking to use the new mechanism, which will hopefully reduce memory usage and improve performance.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please smoke test

@swift-ci Please test source compatibility


useElementSize renders 3 times

useElementSize is causing multiple re-rendering. It renders components three times at the first load.

Hi @Nishchit14, please could you create a minimal reproduction of your problem, by example in a codesandbox.

You can see it using the react dev tools with the provided example code.
Maybe the problem with this component is the self management of the ref. What about receiving the ref by parameter? With this approach maybe we could fix #196 as well. WDYT?

Hi, useElementSize has been deprecated and should be replaced by useResizeObserver.


Update high_entropy_strings.py

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added

[ ] Docs have been added / updated

[ ] All CI checks are green

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Other information:

Did you have a chance to make this change in checkov in-place and try to run tests against it?
It has a high risk for regression.


[Bug] Make Website Bandwidth Calculator responsive

Description
It should be responsive
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Go ahead @agastya3636


docs(design): explain why we use secrets instead of CRDs

@bacongobbler That was my first EVER PR from a Windows machine!

😱


Add NetBSD compatibility code

I have tested this version of codes in NetBSD 7.0. zmap can be compiled successfully.

Thanks for submitting this! I'm glad to hear that this is working on netBSD with these changes.


Nominate Jason Kridner (jadonk) as Collaborator

Background
The TSC Project Roles defines the main roles for the Zephyr Project, including
Maintainer, Collaborator, and Contributor.
By default anyone that contributes code or documentation is a Contributor, but
with the lowest GitHub Permission Level of Read. For example, Contributors
with Read permission do not have the permission to add reviewers to a pull
request.
Use this template to nominate a GitHub user for the Contributor role with
Triage permission level, which allows the user to add reviewers to a pull
request and be added as a reviewer by other users.
Nomination
GitHub User
Provide the following information about the GitHub user:

Full Name : Jason Kridner
GitHub username : @jadonk
Organization (optional) : BeagleBoard.org Foundation

Supporting Documents
Add links to 3-5 GitHub pull requests, in the Zephyr project, authored or
reviewed by the GitHub user that demonstrate the user's dedication to the
Zephyr project.
https://github.com/zephyrproject-rtos/zephyr/pull/55488
https://github.com/zephyrproject-rtos/zephyr/pull/66400
Reviews:
https://github.com/zephyrproject-rtos/zephyr/pull/64718
https://github.com/zephyrproject-rtos/zephyr/pull/66389
https://github.com/zephyrproject-rtos/zephyr/pull/73724
https://github.com/zephyrproject-rtos/zephyr/pull/73801

https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml#L267

Added as a maintainer since @jadonk is already listed as one in the MAINTAINERS file.

Added as a maintainer since @jadonk is already listed as one in the MAINTAINERS file.

I do not think a person can get a maintainer role just by being listed in the MAINTAINERS file. Collaborator would be the necessary requirement. But even the Contributor role seems to go too far.

Added as a maintainer since @jadonk is already listed as one in the MAINTAINERS file.

I do not think a person can get a maintainer role just by being listed in the MAINTAINERS file. Collaborator would be the necessary requirement. But even the Collaborator role seems to go too far.

@jfischer-no If a person does not qualify for maintainer or collaborator role, the person should not have been added to the MAINTAINERS file. As far as the operations go, MAINTAINERS file is the single and only source of truth.

Added as a maintainer since @jadonk is already listed as one in the MAINTAINERS file.

I do not think a person can get a maintainer role just by being listed in the MAINTAINERS file. Collaborator would be the necessary requirement. But even the Collaborator role seems to go too far.

@jfischer-no If a person does not qualify for maintainer or collaborator role, the person should not have been added to the MAINTAINERS file. As far as the operations go, MAINTAINERS file is the single and only source of truth.

There may be questionable records, like this one. https://github.com/zephyrproject-rtos/zephyr/pull/67841
Since commit 251670133b1d320baf0d8b32354293991520592d, there is a note in https://docs.zephyrproject.org/latest/project/project_roles.html#maintainer:
"Candidates who are neither Contributors nor Collaborators must be approved by the TSC before they can assume the role of Maintainer."
An there is another one that looks suspicious: https://github.com/zephyrproject-rtos/zephyr/issues/71018, https://github.com/zephyrproject-rtos/zephyr/pull/79365

What is the process for TSC approval? I'd like to serve whatever role necessary to make sure Beagle users have a good development experience with Zephyr.

Maintainer eligibility verification and approval should happen before people are added as Maintainers in the MAINTAINERS file.
We should be more careful when reviewing PRs adding Maintainers. cc @MaureenHelm @nashif
As for those who are "ineligible", as per https://github.com/zephyrproject-rtos/zephyr/commit/251670133b1d320baf0d8b32354293991520592d, yet added as Maintainers in the MAINTAINERS file, I am not sure what to do here -- maybe someone should send a PR to remove the erroneous entries from the MAINTAINERS file.

@jadonk please do accept the GitHub invite you should have gotten to become a collaborator in the zephyrproject-rtos org. This is needed for your +1's to actually start counting as approvals.
That's of course unless @stephanosio ended up not adding you after all following the discussion above

Not sure what this means...

@nashif @stephanosio could you please maybe re-issue the invite?

Thank you for your contribution to the Zephyr project.
An invite was sent to you to join the project. You can find the invite here: https://github.com/zephyrproject-rtos/zephyr/invitations.
Note that further access and permissoins to the project will be provided following the project guidelines.


Finished: Sequence interface exercise

closed #385

Same here, my lint doesn't complain even without eslint props.

I see that some conflicts appear in that branch,
Could I ask you to re-create branch with that exercise ?
Looks like it because you have created branch before I've merged pre-hook, so you have two ways to solve this issue:

Merge that branch with exercise branch
Re-create branch from exercise and copy  your code there


Extremally disconnected: remove T2 assumption

Remove T2 assumption from P49.
As discussed in https://github.com/pi-base/data/pull/357#issuecomment-1646738969.

The proof of https://topology.pi-base.org/theorems/T000045 uses the assumption that these spaces are T2. I thought about it a bit and it seems to be pretty necessary: https://math.stackexchange.com/questions/4742443
In particular, without $T_2$ this isn't really a "disconnected" property. So I'm of the opinion that a better move would be to add a separate property "Closures are open" that when paired with $T_2$ is equivalent to "extremally disconnected".

Yeah, I had not checked the theorems.  You are absolutely right that T45 would need the Hausdorff assumption.  And it's hard to argue that something like an indiscrete space or other connected space examples that you mention in mathse are some form of "disconnected".
On the other hand, at least three respectable sources don't make the Hausdorff assumption in the definition: Willard, Gillman & Jerison, Anhangelskii & Ponomarev.
Engelking includes Hausdorff, but he includes Hausdorff in all kinds of other things as well (regular, normal, compact, zero-dim, etc, etc), just for convenience, so that does not say much.
Encyclopedia of General Topology (Hart, Nagata, Vaughan):
https://books.google.com/books?id=JWyoCRkLFAkC&printsec=frontcover&dq=Encyclopedia+of+general+topology&hl=en&newbks=1&newbks_redir=0&sa=X&ved=2ahUKEwjb3vPL46qAAxXRF1kFHZaKA1wQuwV6BAgGEAk#v=onepage&q=extremally disconnected&f=false
has some mentions without extra condition (e.g., p. 225 in the "Connectedness" section), and some mentions with extra conditions. For example the main section about "Extremally disconnected spaces" (p. 345) assumes regular (but not T2) (unless regular = T3, not sure).
It seems a little redundant to have to introduce "Closure of open is open" as a property nearly synonymous with "extremally disconnected" in most cases of interest.  I agree it may sound weird that a space can at the same time be extremally disconnected and connected for example. But what about compact and anticompact at the same time?  One can get used to it.
What's the most commonly used definition in papers?
I'd be curious to know others' opinion (@ccaruvana, @lyengulalp, ...).

I haven't studied P49 myself. Though with a bit of further thought, as long as I parse its name correctly ("extremally disconnected", not "extermely disconected"), I think I can handle a P49 space that's also connected.
So instead, I think I'd approve this PR once we update T45 to add the Hausdorff requirement.

For example the main section about "Extremally disconnected spaces" (p. 345) assumes regular (but not T2) (unless regular = T3, not sure).

My guess is they mean $T_3$ (they say "mainly Tychonoff spaces are discussed here").

See https://mathoverflow.net/questions/431616/extremely-disconnected-or-extremally-disconnected in this respect.
Without Hausdorff, [hyperconnected  ==> extremally disconnected], which again sounds weird (see https://math.stackexchange.com/questions/4742443).  But maybe ok.
Before you approve, can we get Chris or Lynne's opinion also?

Sure. You could add those theorems from https://mathoverflow.net/questions/431616/extremely-disconnected-or-extremally-disconnected which will help complete the non-Hausdorff examples as well.

As far as I recall, I've seen the notion "extremally disconnected" exactly once. In that source, the detail they used was that the collection of semi-open subsets of an extremally disconnected space forms a topology. The authors did not assume any separation axioms in their discussion (see the first sentence of Preliminaries and Lemma 4.22 of http://bims.iranjournals.ir/article_1078_9fad6d520d7acfc75e636817ab29dff9.pdf) - though they use "extremely disconnected" without defining the term, I'm quite sure they mean "extremally disconnected."
This is only one example, however, and the paper they cite where it is shown that SO(X) is a topology iff X is extremally disconnected does not seem to be easily accessible online. So I'm not sure I can comment on what is most standard, but it may suggest that at least some circle of mathematicians working with the notion don't require separation axiom assumptions (along with the important examples pointed out by @prabau already).

Thanks for the reference.  So it seems it's more general and not a bad idea to not have Hausdorff as part of the definition.  Feel free to approve if you don't have other objections.

@prabau If you're fine with 4fe4261 then this is ready to merge.

Looks good.  Please approve.


Connect label with textarea

I treid to connect by htmlFor a label with your TextareaAutosize, but I can't.
Maybe exist a method to do it?
I'm using version 8.3.3
I have Ubuntu system 21
I'm testing with chrome

What have you tried? Can you include your code?

I just try it and it seems work, maybe the problem is only on linux.
Below is my test
https://codesandbox.io/s/keen-hertz-quiwqy?file=/src/App.js
I close che issue


feat: minimum block latency

Problem
There are times when you want to slow the chain. The "natural" way is to have a higher workload, but sometimes the ideal spot is not on the workload-latency curve (e.g. when you're on a laptop or cheap hardware).
Solution
Add a config for how many seconds to sleep in between blocks.
There's a problem with this patch, and that is that it's coupled to saving blocks. But what if we save blocks in batch later? Ideally we would sleep immediately before/after applying. But how do we want to inject config into the Chain module?

Where ever we add this in the end, we don't want it to slow down actual block application. I.e, applying blocks should go as fast as possible - it's only when we're trying to advance the chain that we should potentially slow down.
Which makes me think maybe we sleep before producing blocks instead of before applying..


$0 doesn't save in the Receipt required amount field in Workspaces

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.76-12
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @zsgreenwald
Slack conversation (hyperlinked to channel name): expensify_bugs
Action Performed:

Enable Rules under more features in a controlled workspace
Navigate to Rules in LHN
Click Receipt required amount field and enter $0 as amount
Click Save

Expected Result:
User able to save the amount. (In Classic, an admin has the ability to set the Receipt required amount to $0 to effective set a requirement on all imported CC transactions)
Actual Result:
User unable to save the $0 as amount
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/1ee34edc-20d9-43f6-965b-2bc60d3040dc
https://github.com/user-attachments/assets/7bb0dae4-c971-435b-a101-0be4fbe42108
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
$0 doesn't save in the Receipt required amount field in Workspaces
What is the root cause of that problem?
When displaying we are returning empty string if the maxExpenseAmountNoReceipt is falsy here
https://github.com/Expensify/App/blob/4b0f250c71d4cc214107ff84797b24365964a5d0/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L91-L92
but 0 is falsy
What changes do you think we should make in order to solve the problem?

We should use
        if (policy?.maxExpenseAmountNoReceipt === CONST.DISABLED_MAX_EXPENSE_VALUE || typeof policy?.maxExpenseAmountNoReceipt !== 'number') {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
$0 doesn't save in the Receipt required amount field in Workspaces
What is the root cause of that problem?
We are checking if !maxExpenseAmountNoReceipt, !maxExpenseAmount, and !maxExpenseAge, then return ''. Therefore, if the value is 0, these will return '' based on this condition.
https://github.com/Expensify/App/blob/d5aa1bd2e9f6cc297fe15808e313223c8dd6014d/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L91-L93
https://github.com/Expensify/App/blob/d5aa1bd2e9f6cc297fe15808e313223c8dd6014d/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L99-L101
https://github.com/Expensify/App/blob/d5aa1bd2e9f6cc297fe15808e313223c8dd6014d/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L107-L109
https://github.com/Expensify/App/blob/286b679b8a7453fac97f327f7d64806fcc683b85/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx#L37-L40
https://github.com/Expensify/App/blob/286b679b8a7453fac97f327f7d64806fcc683b85/src/pages/workspace/rules/RulesMaxExpenseAmountPage.tsx#L37-L40
What changes do you think we should make in order to solve the problem?

So we shouldn’t accept a 0 value when the user inputs it. We should validate the form and return an error like ‘Invalid amount’ if the value is 0. Something like this:
https://github.com/Expensify/App/blob/286b679b8a7453fac97f327f7d64806fcc683b85/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx#L41
Add this function:
    const validate = useCallback(
        (values: FormOnyxValues<typeof ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM>) => {
            const errors: FormInputErrors<typeof ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM> = {};
            const maxExpenseAmountNoReceipt = values[INPUT_IDS.MAX_EXPENSE_AMOUNT_NO_RECEIPT];

            if (maxExpenseAmountNoReceipt === '0') {
                errors.maxExpenseAmountNoReceipt = translate('workspace.rules.individualExpenseRules.errors.invalidAmount');
            }

            return errors;
        },
        [translate],
    );

https://github.com/Expensify/App/blob/286b679b8a7453fac97f327f7d64806fcc683b85/src/pages/workspace/rules/RulesReceiptRequiredAmountPage.tsx#L57
update ScreenWrapper to:
      <FormProvider
          style={[styles.flexGrow1, styles.ph5]}
          formID={ONYXKEYS.FORMS.RULES_REQUIRED_RECEIPT_AMOUNT_FORM}
          onSubmit={({maxExpenseAmountNoReceipt}) => {
              PolicyActions.setPolicyMaxExpenseAmountNoReceipt(policyID, maxExpenseAmountNoReceipt);
              Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
          }}
          submitButtonText={translate('workspace.editor.save')}
          enabledWhenOffline
          validate={validate}
      >

We can apply this solution to other similar cases, such as maxExpenseAmount ...

POC

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We created a test for validate to check if the amount is 0. If it is, then errors.maxExpenseAmountNoReceipt should have a value. Otherwise, if the amount is not 0, the error should be {}.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
User unable to save the $0 as amount
What is the root cause of that problem?
When we enter 0 or 0.00, the parsedMaxExpenseAmountNoReceipt is 0
https://github.com/Expensify/App/blob/154a485f35609cb51e655aad3dca9e3131f3b23e/src/libs/actions/Policy/Policy.ts#L3520
Then we display an empty string here because !policy?.maxExpenseAmountNoReceipt is true
https://github.com/Expensify/App/blob/154a485f35609cb51e655aad3dca9e3131f3b23e/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L91-L93
What changes do you think we should make in order to solve the problem?
We can simply remove !policy?.maxExpenseAmountNoReceipt since maxExpenseAmountNoReceipt will never be undefined
https://github.com/Expensify/App/blob/154a485f35609cb51e655aad3dca9e3131f3b23e/src/pages/workspace/rules/IndividualExpenseRulesSection.tsx#L91-L93
We can do the same for maxExpenseAmount here and maxExpenseAge here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Proposal
Please re-state the problem that we are trying to solve in this issue.
User unable to save the $0 as amount
Root Cause
The root cause lies in the conditional logic for rendering the field's value. Specifically:

The logic does not distinguish 0 (a valid amount) from null or CONST.DISABLED_MAX_EXPENSE_VALUE (invalid states).
As a result, 0 is treated as if no value were provided, leading to an empty field display.

What changes do you think we should make in order to solve the problem?
To address this issue, we propose optimizing the conditional logic in the maxExpenseAmountNoReceiptText function to:

Explicitly check for null and CONST.DISABLED_MAX_EXPENSE_VALUE as invalid states that return an empty string.
Treat 0 as a valid value and pass it through CurrencyUtils.convertToDisplayString for proper formatting.

#### What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
To prevent reintroducing this issue in the future, the following scenarios should be covered in automated tests:

1. **Saving `$0` in the Field:**
   - Verify that saving `0` in the "Receipt Required Amount" field displays `$0` correctly.

2. **Saving Valid Non-Zero Values:**
   - Ensure that valid amounts (e.g., `$50`) are displayed correctly after saving.

3. **Blank or Disabled Field States:**
   - Test that saving a blank field or a value equivalent to `CONST.DISABLED_MAX_EXPENSE_VALUE` results in an empty display.

4. **Currency Formatting:**
   - Confirm that the amount is correctly formatted based on the policy’s currency (e.g., `$0` for USD, €0 for EUR).

5. **Edge Cases:**
   - Test edge cases, such as `null`, extremely large values, and invalid characters, to ensure robustness.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~017b8a07b451b96ff0


remove deprecated code

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [quanjielin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
41a943426abec5b9232516e2629520ddc6823af7
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
acdeb0c2529af9a5f52381cdb7c4e4d2f51217e0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

iam.go contains ExchangeToken, does that mean citadel agent no longer exchanges token with Google? How does it get credential then?

/hold

no, exchange token still there, just switched to a different api interface long time ago, this pr just remove deprecate code.

Thanks. I just want to ensure we're still doing token exchange ourselves, not relying on k8s, which is crucial.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incfly, quanjielin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: incfly, quanjielin
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
acdeb0c2529af9a5f52381cdb7c4e4d2f51217e0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
acdeb0c2529af9a5f52381cdb7c4e4d2f51217e0
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@quanjielin: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
acdeb0c2529af9a5f52381cdb7c4e4d2f51217e0
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
acdeb0c2529af9a5f52381cdb7c4e4d2f51217e0
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


fix(assign-pr): Add REVIEWERS based on product even when PCX owner opens a PR

This adds REVIEWERS based on product even when PCX owner opens a PR.
Currently, if non-PCX owner opens a PR, it adds REVIEWERS based on product, but if PCX owner opens a PR, it will only add all PCX OWNERS (up to 10), but not REVIEWERS.
10 reviewers limit is removed, as it seems like it allows more reviewers fine (may need to add it back later if it's not).
This is an enhancement on the change to add REVIEWERS:

https://github.com/cloudflare/cloudflare-docs/pull/5612
https://github.com/cloudflare/cloudflare-docs/pull/5618

I don't know exact reason of current behavior, but I think non-PCX owner product reviewers should still be added as reviewers when a PR is opened by PCX owner, when there's a change for their product.


Fix code scanning alert - Semgrep Finding: javascript.browser.security.eval-detected.eval-detected

Tracking issue for:

[ ] https://github.com/serifegnll/juice-shop/security/code-scanning/124

Part of juice shop challenges


Alignment of Integration with IAM BB

for initial Q2 delivery we agreed (see https://eoepca.slack.com/archives/C07KHPXA1AP/p1727176651575429)  to

neither protect the adapted workspace-api (v2.0 will just expose bucket and harbor credentials - see https://github.com/EOEPCA/workspace/issues/24 incl. comments - as other functionality provided by different means)
nor the workspace-ui

and just not expose these endpoints via public ingress, i.e. the endpoints are not protected but only reachable within cluster and at least not publicly
signoff: during Q3 a concept with the IAM BB must be aligned encompassing protection for above endpoints (similar as done with gluu/keycloak in past), still being adaptable/pluggable so that it can be applied to DLR Terrabyte cluster in same manner

see https://eoepca.slack.com/archives/C078J079YLR/p1731403162670619 with follow-up item

following discussion 21.11.2024 with @rconway and the IAM BB team

[ ] https://github.com/EOEPCA/workspace/issues/34
[ ] https://github.com/EOEPCA/workspace/issues/35
[ ] https://github.com/EOEPCA/workspace/issues/36


Added pole figure plotting capabilities to ExaCA app and make pyebsd optional dependency

This adds some features for plotting pole figures using the pyebsd package to calculate the Cartesian grid location of the poles. It also creates an exaca optional dependency group and moves the import statements to make the pyebsd dependency optional.
Added functions:

The plot_poles() function uses the existing pyebsd.ebsd.plot_PF() function with minor formatting changes
The plot_pole_density() function uses pyebsd.ebsd.plot_PF() to get the location of the poles in Cartesian coordinates and then uses added contouring and plot formatting to generate the pole figure.

To dos's before re-review:

[ ] Rebase on main to handle merge conflicts with refactor
[ ] Correct ExaCA optional dependency error checks

I have a draft of a Gaussian smoothing method for the pole figure plotting, but will leave that for a separate PR.


Error with _timestamp when dumping from one instance to another

I am encountering an error related to a _timestamp field which I'm not sure how to resolve. It seems like old data that has been migrated along but is now causing issues when trying to copy it. How can I resolve this?
Versions
$ npx elasticdump --version
6.0.0
$ node -v
v8.15.0

Version
Env

5.6.9
prod

5.6.14
local

Command
  npx elasticdump \
    --input=$PROD_ES_URL \
    --output=$LOCAL_ES_URL \
    --type=mapping

Example Data
If I dump to a file as output instead then I get this, essentially:
{
	"example": {
		"mappings": {
			"teams": {
				"_timestamp": {
					"enabled": true
				},
				"properties": {
					"exampleId": {
						"type": "string"
					}
				}
			}
		}
	}
}

Error
Thu, 02 May 2019 21:16:43 GMT | Error Emitted => {"root_cause":[{"type":"illegal_argument_exception","reason":"[_timestamp] is removed in 5.0. As a replacement, you can use an ingest pipeline to add a field with the current timestamp to your documents."}],"type":"illegal_argument_exception","reason":"[_timestamp] is removed in 5.0. As a replacement, you can use an ingest pipeline to add a field with the current timestamp to your documents."}
Thu, 02 May 2019 21:16:43 GMT | Total Writes: 0
Thu, 02 May 2019 21:16:43 GMT | dump ended with error (set phase)  => [object Object]

ES 5.0 deprecated _timestamp & _ttl. as written here. https://github.com/taskrabbit/elasticsearch-dump/blob/master/lib/transports/elasticsearch.js#L22
You can use the transform property to remove the field.
--transform="delete doc.example.mappings.teams._timestamp;

Thanks @ferronrsmith
If teams is actually variable, how can I handle that?

Is the syntax just javascript being eval'd?

For posterity I solved this by dumping to a file, running it through jq and then pushing into the next machine from the cleaned data.

npx elasticdump \
  --input=$PROD_ES_URL \
  --output=mapping.json \
  --type=mapping

cat mapping.json | jq -r '."collection-field".mappings[]|=with_entries(select(.key|test("_timestamp")|not))' > cleaned.mapping.json

npx elasticdump \
  --input=cleaned.mapping.json \
  --output=$LOCAL_ES_URL \
  --type=mapping

Is the syntax just javascript being eval'd?

Yes it being eval'd
https://github.com/taskrabbit/elasticsearch-dump/blob/master/elasticdump.js#L57


Feature Request: User-Prompted Dialogue Box for Viewing Active Services on a Submission

Background:
Currently, users are required to remain on the submission page until a dialogue box appears, indicating which services are still actively processing their submission. This passive approach can lead to inefficiencies and potential user frustration, especially if there's a delay or unknown services are stuck in processing.
Request:
Implement a feature that allows users to actively prompt a dialogue box on demand. This dialogue box will display the services currently running on their submission, giving users the ability to view and, if necessary, stop any services that seem to be stuck or taking longer than anticipated.
Use Case:
A user submits content for processing and wants to check on its progress after some time. Instead of waiting passively for the system to inform them, they can click a button or use a specific prompt to call up a dialogue box. This box lists all the services currently processing their submission, allowing the user to take appropriate action if any service seems stalled.

We don't have to wait for no messages to be received for a while and could always pull at a given interval for which services we are waiting for...


Updating the props to meet what EE needs

Closes

What changed?
Updates the Props for ReconciliationGraph and ReconciledObjectsTable to be more readable and easy to use in EE .

Why was this change made?

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@joshri @TheGostKasper Hey guys, I'm just working on a small PR (https://github.com/weaveworks/weave-gitops-enterprise/pull/2645) to update the flags and reconciledObjectsAutomation in EE as we need to do a release tomorrow and we weren't sure when the nav + layout branch would be merged. In the process of doing this, I noticed that this PR is breaking EE (specifically, it's the removal of the objects from reconciledObjectsAutomation). In EE, we have our own function to retrieve the objects as Core doesn't have the concept on GitOpsSet.

This gets tricky since there's now a more optimized way of getting the inventory - OSS doesn't use getReconciledTree anymore. I don't know how this actually effects GitOpsSets, but maybe for the release Enterprise could use the FluxObjectsTable instead of the ReconciledObjectsTable (essentially the table without the request). @TheGostKasper had the idea of moving the api request down into the tab level to try to have it run less often. Maybe these tab components need to stay w/o requests?

Export Graph component from OSS
Replace ReconciledObjectsTable by

<FluxObjectsTable
                  className={className}
                  objects={objects || []}
                  onClick={setDetailModal}
                  initialFilterState={initialFilterState}
                />
                {/* <ReconciledObjectsTable
                  reconciledObjectsAutomation={reconciledObjectsAutomation}
                /> */}

Replace ReconciliationGraph by

<Graph
              className={className}
              reconciledObjectsAutomation={reconciledObjectsAutomation}
              objects={objects || []}
            />
            {/* <ReconciliationGraph
              reconciledObjectsAutomation={reconciledObjectsAutomation}
            /> */}


fix: return failed instead of success when no container status

We have a product named ManagedArgoWorkflows in AlibabaCloud use eci (virtual-kubelet).
Sometimes the pod failed for some reason (no stock、timeout、schedulerFailed and more than these)，in these conditions, the pod mightly not has containerstatus/condations/messages,  and then the pod will marked success and caused mistake.
So I think we should return failed when the pod is Failed and we can't find message and status in the pod.
Maybe this problem will also occur in other public cloud platforms.

This feels like a very dangerous assumption to make. How do we know that the status won't get updated later to something more successful?

This feels like a very dangerous assumption to make. How do we know that the status won't get updated later to something more successful?

I think if it get update later from failed to successeed.  the workflow will reconicle. if the pod failed, it may be retry. if it marked successed(but actually never run )，we made a mistake. This is what I encountered


increasing precision

I'd like to use this library with the 'quantities' crate to do some quantum mechanics work.
Planck's constant is 6.62607015 × 10−34 , so I'd like about 42 digits of precision.
Is forking this library the only way to increase the precision?
(Fork and adjust the MAX_N_FRAC_DIGITS constant defined here: fpdec-core/src/lib.rs)
Thanks!

Sorry, I read the exponent min/max wrong. fp64 is fine so I don't need any fpdec changes.
Thanks for making fpdec!

Fyi fp64 has an accuracy ~= 16 digits after the decimal.

fpdec.rs uses an i128 to store the coefficient. This gives room for 38 decimal digits. 42 digits is definitely out of scope.

The original requirement is targeted at the quantities.rs crate. That crate can use different types for the numerical part of a quantity value, so maybe the solution could be another numerical type as optional dependency.
Please see there.

Closing this as "will not implement".


Implement object navigation and the functions jn:keys and jn:null wit…

…h test cases

Reformat your commit message to have a title (line 1) less then 50 characters, followed by a line break and complete details of the commit. Similar to an e-mail subject and body.


AttributeError: module 'dash_table_experiments' has no attribute 'DataTable'

Setup:

Jupyter Lab Version 0.32.1 and
PyCharm 2018.1.4 (Community Edition)
Build #PC-181.5087.37, built on May 24, 2018
JRE: 1.8.0_152-release-1136-b39 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0
Python 3.6.5

Relevant Library Versions:

chardet==3.0.4
click==6.7
Cython==0.28.2
dash==0.21.0
dash-core-components==0.22.1
dash-html-components==0.10.0
dash-renderer==0.12.1
dash-table-experiments==0.6.0
decorator==4.3.0
nbformat==4.4.0
numpy==1.14.2
pandas==0.22.0
pandas-datareader==0.6.0
plotly==2.5.1
python-dateutil==2.7.2
pytz==2018.4
requests==2.18.4
urllib3==1.22
Werkzeug==0.14.1

When I run any code in Pycharm or Jupyter involving dt.DataTable() I get the following error:

AttributeError: module 'dash_table_experiments' has no attribute 'DataTable'

Steps I have taken:

Tried the code on Jupyter Lab IDE to see if it was an IDE problem
Uninstalled and reinstalled dash-table-experiments
pip install [package_name] --upgrade for the following libraries:

dash                      0.21.1
dash-core-components      0.23.0
dash-html-components      0.11.0
dash-renderer             0.13.0
dash-table-experiments    0.6.0
plotly                    2.7.0

None of these 3 steps helped to resolve the problem.
Does anyone know how I can fix this so that I can begin to use this amazing package?

 If I could delete this "issue" I would. Please excuse my stupidity.


Use a fallback for reference filters for unpublished content

Description
Since the intl plugin for whatever reason adds the intl fields (_intl: en_GB) on publishing for the base language, we need a fallback to be able to filter references for unpublished content. Could we just use the base language as the fallback if there's no _lang value? (We will then need a more robust way to define the base language)

Examples of the errors I see
Runtime error (will add a guard here)

Mix of Norwegian and English references

Ask Simeon in the weekly meeting about this

We made a fallback in the landingPage.ts, I think we might just do it as simple as this...? Because the translated document will have the language information added when it's created, and not when it's published as with the base language :(

@wenche, can you take a look at this? :)

Test
News

[ ] Internal link News EN -> reference to EN route and EN news

[ ] Internal link News NO -> reference to NO route and NO news

[ ] More on this topic link News NO -> reference to NO route and NO news

[ ] More on this topic News EN -> reference to EN route and EN news

[ ] Internal link Text block Topic EN -> reference to EN route and EN news

[ ] C2a link Text block Topic EN -> reference to EN route and EN news

[ ] Teaser link  Topic EN -> reference to EN route and EN news

[ ] Accordion internal link  Topic EN -> reference to EN route and EN news

[ ] Internal link Text block Topic NO -> reference to NO route and NO news

[ ] C2a link Text block Topic NO -> reference to NO route and NO news

[ ] Teaser link  Topic NO -> reference to NO route and NO news

[ ] Accordion internal link  Topic NO-> reference to NO route and NO news

Except for the gotcha with the translated document that does not respect the filters, this look really good :thumbsup:


[tooling] Maintenance required re: automatic context fixes

What happened? Describe the problem that occurred.
When reviewing the Fix content issues automatically guidance in Contributing.md, commands are not working as expected.

npm run test-and-fix does alert to formatting issues, but does not automatically fix them as the script name implies.

the fix:all script is documented, but when run, an error returns that it doesn't exist.

What did you expect would happen? Describe the expected result/output.
For 1 - I expect formatting issues to be found AND fixed via Prettier.
For 2 - I expect that running npm run test-and-fix results in a found script that runs without errors.
Additional context: anything else you can think about that would be helpful.
Output error for 1:
The following output appeared for me when I ran npm run test-and-fix:

% npm run test-and-fix
test-and-fix
npm run seq -- check fix:dict fix:filenames
seq
bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' -  "check" "fix:dict" "fix:filenames"
check
npm run seq -- $(npm run -s _list:check:*)
seq
bash -c 'for cmd in "$@"; do npm run $cmd || exit 1; done' -  "check:filenames" "check:format" "check:links" "check:markdown" "check:spelling" "check:text"
check:filenames
test -z "$(npm run -s _ls-bad-filenames)" || npm run -s _filename-error
check:format
npm run _check:format || (echo '[help] Run: npm run fix:format'; exit 1)
_check:format
npx prettier --check .
Checking formatting...
[warn] content/en/docs/security/otel-collector-configuration-best-practices.md
[warn] Code style issues found in the above file. Run Prettier to fix.
[help] Run: npm run fix:format

Output error for 2:

npm ERR! Missing script: "fix:all"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR!   npm run

Thank you for raising this issue. I was facing this problem as well and worked around it by running fix:format first and then test-and-fix, but this shouldn't be the way how it works I guess, maybe we need to do something like "fix:all, check, fix:all"


it's not working.

Hi. I tried to use your plugin but it's not working. The dialog isn't showed. when i builded a emty app with the plugin, the app goes out after calling request permission function. Can your help me fix this issue?

Hi rbauer1186,
Thank you for the report. I'll try to fix it.
So, would you tell me more information about your environment?
・Unity version
・Permission you want to permit
・your android device name
・your android device OS version
tanks,

Hi. Thank you for helping me. I  use Unity version 5.3.5f1. i request permission WRITE_EXTERNAL_STORAGE.
i use a huawei phone with android 6.0.

my phone is rooted. maybe it causes the error.

I am facing same error, I have new phone not rooted
Android OS 13
Google Pixel 6A
permission: WRITE_EXTERNAL_STORAGE
unity : 2020.3.26f
Same error, please help me to figureout
AndroidJavaException: java.lang.ClassNotFoundException: net.sanukin.PermissionManager
	java.lang.ClassNotFoundException: net.sanukin.PermissionManager
		at java.lang.Class.classForName(Native Method)
		at java.lang.Class.forName(Class.java:536)
		at com.unity3d.player.UnityPlayer.nativeRender(Native Method)
		at com.unity3d.player.UnityPlayer.access$300(Unknown Source:0)
		at com.unity3d.player.UnityPlayer$e$1.handleMessage(Unknown Source:95)
		at android.os.Handler.dispatchMessage(Handler.java:103)
		at android.os.Looper.loopOnce(Looper.java:232)
		at android.os.Looper.loop(Looper.java:317)
		at com.unity3d.player.UnityPlayer$e.run(Unknown Source:20)
	Caused by: java.lang.ClassNotFoundException: net.sanukin.PermissionManager
		at java.lang.Class.classForName(Native Method)
		at java.lang.Class.forName(Class.java:536)
		at com.unity3d.player.UnityPlayer.nativeRender(Native Method)
		at com.unity3d.player.UnityPlayer.access$300(Unknown Source:0)
		at com.unity3d.player.UnityPlayer$e$1.handleMessage(Unknown Source:95)
		at android.os.Handler.dispatchMessage(Handler.java:103)
		at android.os.Looper.loopOnce(Looper.java:232)
		at android.os.Looper.loop(Looper.java:317)
		at com.unity3d.player.UnityPlayer$e.run(Unknown Source:20)
		at UnityEngine.AndroidJNISafe.CheckException () [0x00000] in <00000000000000000000000000000000>:0
		at UnityEngine.AndroidJNISafe.FindClass (System.String name) [0x00000] in <00000000000000000000000000000000>:0
		at UnityEngine.AndroidJavaClass._AndroidJavaClass (System.String clas


iOS masonry iOS works OK in iOS 8 , but crash in iOS 7

iOS masonry iOS works OK in iOS 8 , but crash in iOS 7

Probably at least one of the constraints in the following list is one you don't want. Try this: (1) look at each constraint and try to figure out which you don't expect; (2) find the code that added the unwanted constraint or constraints and fix it. (Note: If you're seeing NSAutoresizingMaskLayoutConstraints that you don't understand, refer to the documentation for the UIView property translatesAutoresizingMaskIntoConstraints)
(
"<MASLayoutConstraint:0x1784b7d00 UIView:0x17817d580.height == 1>",
"<MASLayoutConstraint:0x1784b8480 UIView:0x17817d640.height == 1>",
"<MASLayoutConstraint:0x1784b7ca0 UIView:0x17817d580.top == UITableViewCellContentView:0x17817d4c0.top + 85>",
"<MASLayoutConstraint:0x1784b7e80 UILabel:0x1281d5060.top == UIView:0x17817d580.bottom + 17>",
"<MASLayoutConstraint:0x1784b80c0 UILabel:0x1281d51a0.top == UILabel:0x1281d5060.bottom + 5>",
"<MASLayoutConstraint:0x1784b8360 UIView:0x17817d640.top == UILabel:0x1281d51a0.bottom + 10>",
"<MASLayoutConstraint:0x1784b8960 UIView:0x17817d7c0.top == UIView:0x17817d640.bottom + 50>",
"<MASLayoutConstraint:0x1784b8a80 UIView:0x17817d7c0.bottom == UITableViewCellContentView:0x17817d4c0.bottom>",
"<NSAutoresizingMaskLayoutConstraint:0x178a944b0 UITableViewCellContentView:0x17817d4c0.height == 44>"
)
Will attempt to recover by breaking constraint
<MASLayoutConstraint:0x1784b8480 UIView:0x17817d640.height == 1>
Break on objc_exception_throw to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.

Can you give a bit more information? We have Masonry in our project that has support for iOS 7 and it doesn't crash in our app. Maybe you should move this to stackoverflow with a little more detail about the crash? i.e. stack trace and snippet of the code.

Closing due to inactivity


example is incorrect- Lock_level_order is broken

At least in VS2017, the given snippet does not produce any Code Analysis warning.
Also, this document is wrong, in that the annotation Set_lock_level_order(a,b) has been replaced by Lock_level_order(a,b). (I assume, given the evidence)
It was very useful, however, that this document specified what relationship Set_lock_level_order(A,B) implied between A and B, as the main SAL locking annotation document does not: https://docs.microsoft.com/en-us/visualstudio/code-quality/annotating-locking-behavior?view=vs-2019

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ee573a6-7960-da77-2362-78f207f18b3d
Version Independent ID: b2dd782b-f622-cb9c-f24a-c9948f95259e
Content: C26105 - Visual Studio
Content Source: docs/code-quality/c26105.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @mikeblome
Microsoft Alias: mblome

investigating

These annotations apply to Concurrency Check. Can we ask the customer to enable one of the following rules and retry?

Microsoft All Rules
Concurrency Rules
Concurrency Check Rules

BTW, Microsoft Native Recommended and Microsoft Minimum Rules do not generate concurrency warnings.
I would expect customers who are interested in Concurrency warnings know how to run the analysis to get concurrency warnings. If that is not a proper assumption, we may want to add some template text to all concurrency checker related documentations.

BTW, here are the example warnings:
Source3.cpp(25): warning C26105: Lock order violation. Acquiring lock 'gMutex' with level "MutexLockLevel" causes order inversion.
Source3.cpp(26): warning C26105: Lock order violation. Acquiring lock 'pTunnel->cs' with level "TunnelLockLevel" causes order inversion.
Source3.cpp(28): warning C26165: Possibly failing to release lock 'gMutex' in function 'OrderInversion'.

As for the reference to "Set_lock_level_order" in the description should be changed to Lock_level_order as pointed out by the customer.

Hi. Thank you for pointing out that I was using the wrong ruleset. On "Microsoft All Rules", the code snippet produces the expected warnings. I am very satisfied now that I can begin to annotate my legacy codebase with locking levels.
I would strongly agree with adding some template text on concurrency checker documentation. I approached these concurrency annotations through the more general SAL documentation (rather than through knowledge of the code analyser), and I'll admit I may not have read it closely enough, but I certainly don't remember the SAL documentation saying specific rulesets needed to be active. I would also have expected to read, on the C26105 warning page itself, which rulesets would generate the warning, much like the C++ warnings say which warning level they generated by.
One more thing to consider, a source of my confusion was probably that more basic concurrency warnings are generated by "Microsoft Native Recommended Rules". The following code will generate a "warning C26110: Caller failing to hold lock '& l2' before calling function 'Lock_2::use_self'." under "Microsoft Native Recommended Rules" in VS2017:
#pragma region test2
struct Lock_2
{
Acquires_lock(this)
void aquire_self()
{
}
_Releases_lock_(this)
	void relenquish_self()
{
}

_Requires_lock_held_(this)
	void use_self()
{
}

};
void test2()
{
Lock_2 l2;
//l2.aquire_self();
l2.use_self();
}
#pragma endregion test2
Thanks for your time.

thanks @tyotypic for your helpful feedback. I have updated the topics you refer to and will update the individual warning topics when I get a list of which ones require the Concurrency rule sets. Fix should be live in a couple of days.


Add Release to S3 as part of the Release Pipeline

Is your feature request related to a problem? Please describe
Not all organizations are allowed to use GitHub, meaning they cannot download H2O Wave to their workstations. We have manually added H2O Wave 0.19.0 to s3 and created a landing page here:
https://h2o-wave.s3.us-east-1.amazonaws.com/releases/index.html

Describe the solution you'd like

[ ] Add the process of releases going to s3 to part of the release pipeline
[ ] In s3, move this release from the releases folder to a 0.19.0 folder
[ ] Add an index at releases that shows all available releases as links and takes you to that page's index
[ ] Automate / parameterize the index file for each release
[ ] Change the PyPi and Conda links from the general H2O_Wave URL to version specific ones
[ ] Optionally: backfill previous releases (I'm not sure this is worth the time)

Describe alternatives you've considered
Manually add releases to s3 - this would need to be assigned to someone

https://h2o-wave.s3.amazonaws.com/releases/index.html
@mtanco @lo5 I went for a more flat structure (instead of putting every release into its own folder) - basically very similar to what GH does. Also Both Anaconda and Pypi have their own mechanisms for browsing various versions so having a general link to these repos is fine.
Please let me know what you think about ^^.

Can we move the documentation above the links? My only concern with the flat structure is that in a few releases the docs will be hidden.
Looks great otherwise!!

@mtanco see this PR on the idea of how it looks, the one in this issue is out of date already. Also, there is one question for you in the PR.


added the user-role clusterrole

The ClusterRole should actually be on the Hub Cluster (https://github.com/dana-team/rcs-ocm-deployer) and not here since the user is only aware of the Hub Cluster (at best). It can be here too, but we'd have to create a RoleBinding automatically for each user that has permissions on the namespace on the Hub Cluster.


feat: add simple random forest classifier for metal classification

cheers

Looks very nice and I agree with all the comments @mlederbauer make regarding possible features we could expand on in the future :D


send_later: Add keyboard navigation to scheduling modal.

This PR aims to add keyboard navigation to the message scheduling modal.
Fixes: #25404.

Looks good to me in manual testing!

This looks good, merged, thanks @shameondev!
A nice follow-up would likely be to have the keyboard focus appear on the first element if you opened the modal via hitting Enter to select "scheduled message" in the compose box \vdots menu (but not if you opened the scheduling modal via a mouse click). I'm not sure how annoying the plumbing for that will be, but I think it's the experience keyboard users want.


GL and canvas features don't redraw when their draw methods are called.

Rather than calling draw on a layer or feature, you have to call draw on the whole map.  This fixes the issue.  Resolves issue #470.
Fix the hurricanes example's line highlight.
Fix the picking example (though keep it disabled).

[Current coverage][cc-pull] is 74.03%

Merging [#585][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master       #585   diff @@
==========================================
  Files            83         85     +2
  Lines          7316       7371    +55
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           5417       5457    +40
- Misses         1899       1914    +15
  Partials          0          0

Powered by Codecov. Last updated by [878ecc7...d3f9deb][cc-compare]
[cc-base-branch]: https://codecov.io/gh/OpenGeoscience/geojs/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/OpenGeoscience/geojs/compare/878ecc7751dd5d1c8f4f82ba4fca49a259774073...d3f9deb1fa5c09142618a9281b8517f14edc8651
[cc-pull]: https://codecov.io/gh/OpenGeoscience/geojs/pull/585?src=pr

thanks @manthey, i will have a closer look for review.

@manthey LGTM 👍


Cluster is stuck in Unavailable state on an upgrade of Rancher

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Deploy a cluster in 2.5.8 - AWS RKE1, 1 etcd/control and 1 worker node (2 node cluster)
Upgrade the setup to latest master - commit id: 54d4afc
The downstream cluster is stuck in Unavailable state
Errors in rancher logs:

2021/06/16 14:54:08 [ERROR] error syncing 'c-fr4fs': handler cluster-deploy: Get "https://ip:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing
2021-06-16 14:54:18.989251 I | mvcc: store.index: compact 393349
2021-06-16 14:54:19.027723 I | mvcc: finished scheduled compaction at 393349 (took 37.11259ms)
2021/06/16 14:54:29 [INFO] Stopping cluster agent for c-fr4fs
2021/06/16 14:54:29 [ERROR] failed to start cluster controllers c-fr4fs: context canceled
2021/06/16 14:54:54 [ERROR] error syncing 'c-fr4fs': handler cluster-deploy: Get "https://ip:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing
2021/06/16 14:56:19 [INFO] Stopping cluster agent for c-fr4fs
2021/06/16 14:56:19 [ERROR] failed to start cluster controllers c-fr4fs: context canceled
2021/06/16 14:56:55 [ERROR] error syncing 'c-fr4fs': handler cluster-deploy: Get "https://ip:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing

Expected Result:
Downstream cluster should come up Active
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head - commit id: 54d4afc
Installation option (single install/HA): Single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): AWS RKE1
Kubernetes version (use kubectl version):

1.20.6 (Any)

On another setup - upgrade from 2.5.8 to latest master a11f947

cluster agent on the master node of the downstream cluster logs:

time="2021-06-20T02:07:28Z" level=error msg="Remotedialer proxy error" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"
time="2021-06-20T02:07:38Z" level=info msg="Connecting to wss://server/v3/connect with token <>"
time="2021-06-20T02:07:38Z" level=info msg="Connecting to proxy" url="wss://server/v3/connect"
time="2021-06-20T02:07:38Z" level=error msg="Failed to connect to proxy. Empty dialer response" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"
time="2021-06-20T02:07:38Z" level=error msg="Remotedialer proxy error" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"

This issue is also seen on an RKEv1 cluster with the following steps:
Bring up a cluster with rke up using RKE v1.3.0-rc7. Single node, all roles.
On Rancher v2.5.8, import the cluster.
Upgrade the setup to latest master - commit id: bfdeb22
The downstream cluster is stuck in Unavailable state
Rancher logs:
2021/06/28 22:24:30 [ERROR] error syncing 'clusters.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/06/28 22:24:30 [ERROR] error syncing 'machinesets.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/06/28 22:24:30 [ERROR] error syncing 'machines.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/06/28 22:24:30 [ERROR] error syncing 'machinehealthchecks.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/06/28 22:24:34 [ERROR] error syncing 'c-nfxps': handler cluster-deploy: Get "https://:443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing

Cluster agent logs on the cluster:
time="2021-06-28T22:22:26Z" level=error msg="Remotedialer proxy error" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"
time="2021-06-28T22:22:36Z" level=info msg="Connecting to wss://server/v3/connect with token 6b65dx...."
time="2021-06-28T22:22:36Z" level=info msg="Connecting to proxy" url="wss://server/v3/connect"
time="2021-06-28T22:22:36Z" level=error msg="Failed to connect to proxy. Empty dialer response" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"
time="2021-06-28T22:22:36Z" level=error msg="Remotedialer proxy error" error="x509: certificate is valid for <IP_ADDRESS>, <IP_ADDRESS>, not server"

Removing the blocker label, as I dont see this issue anymore on latest master 5aa95f23. Though errors are seen in logs for a few downstream clusters, I do not see the cluster stuck in Unavailable state.
2021/07/08 22:30:12 [ERROR] failed on subscribe daemonSet: Get "https://<>:6443/apis/apps/v1/daemonsets?resourceVersion=0&timeout=30m0s&timeoutSeconds=1800&watch=true": cluster agent disconnected
2021/07/08 22:30:15 [ERROR] failed on subscribe job: Get "https://<>:6443/apis/batch/v1/jobs?resourceVersion=0&timeout=30m0s&timeoutSeconds=1800&watch=true": cluster agent disconnected

On master-head ad099ee, after upgrading from v2.5.8:

All the downstream clusters are stuck in Unavailable state for exactly 10 minutes with the following logs seen in the rancher server
After 10 minutes, status of the clusters is changed to Active state :

2021/07/12 20:58:23 [ERROR] error syncing 'git-webhook': handler apiservice: failed to create fleet-system/steve-aggregation /v1, Kind=Secret for apiservice git-webhook: namespaces "fleet-system" not found, requeuing
2021/07/12 20:58:39 [ERROR] error syncing 'c-7pjbn': handler cluster-deploy: Get "https://<IP_ADDRESS>:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing
2021/07/12 20:57:54 [INFO] Stopping cluster agent for c-t2b4g
2021/07/12 20:57:54 [ERROR] failed to start cluster controllers c-t2b4g: context canceled

I see this issue in rancher server logs and Webhook is not deployed in local cluster
2021/07/16 04:25:31 [ERROR] error syncing 'validating-webhook-configuration': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:31 [ERROR] error syncing 'mutating-webhook-configuration': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:48 [ERROR] error syncing 'c-jj72l': handler cluster-deploy: Get "https://<>:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing
2021/07/16 04:25:51 [ERROR] error syncing 'machinehealthchecks.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:51 [ERROR] error syncing 'machinesets.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:51 [ERROR] error syncing 'machines.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:51 [ERROR] error syncing 'machinedeployments.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing
2021/07/16 04:25:51 [ERROR] error syncing 'clusters.cluster.x-k8s.io': handler need-a-cert: services "webhook-service" not found, requeuing

Noticed, on Creating a new cluster, brings the other cluster back to Active state after Upgrade.

Noticed issue is not seen with clusters on HA server when upgraded from v2.5.7 to master-head d3ad5d3 via helm

Do not see this issue on an upgrade from 2.5.8 to master-head in a HA setup.

This issue only happens on docker single node installs with node ip as rancher server url. We don't see if rancher server url is fqdn.
On upgrade, I don't see dynamicListener creating a new cert for the server url anymore so agents fail to connect.
Workaround: Restarting an agent fixes the issue.

Also see error in rancher logs after an upgrade of rancher from 2.5.9 to master-head commit id: 21ab02c
2021/07/28 23:57:19 [ERROR] failed to start cluster controllers c-pstr5: context canceled
2021/07/28 23:57:47 [ERROR] error syncing 'c-pstr5': handler cluster-deploy: Get "https://<>:6443/apis/apps/v1/namespaces/cattle-system/daemonsets/cattle-node-agent": cluster agent disconnected, requeuing
2021/07/28 23:57:56 [ERROR] Unknown error: users.management.cattle.io "provisioning/fleet-default/c-pstr5" not found

On an upgrade from 2.5.8 to master-head commit - 8397837e

Single node install - docker install
The clusters were in active state, agents upgraded to master
cluster did not go to Unavailable state.


"Emoji font" option? Class based?

Is it possible to choose Noto Color Emoji as the only emoji flag class? Would be a great addition to circumvent Windows flag emojis limitation, as Noto Color Emoji overrides other text fonts.

For now, it only supports one webfont at a time.


HTM-1285: Fix code scanning alert no. 351: Server-side request forgery

Fixes https://github.com/Tailormap/tailormap-api/security/code-scanning/351
To fix the SSRF vulnerability, we need to validate the user-provided URL against a whitelist of allowed URLs or ensure that the constructed URL is limited to a particular host or more restrictive URL prefix. This can be achieved by adding a validation step in the buildWMSUrl method to check if the URL belongs to an allowed set of domains.

Create a list of allowed domains.
Validate the constructed URL against this list.
If the URL is not valid, throw an exception or return an error response.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Alert dismissed.


Update nrf_modem_os_sem_take()

Update nrf_modem_os_sem_take() to send 1 millisecond (1000 us) to the busywait function which takes microseconds not milliseconds.  The current version can prematurely timeout, specifically, during modem init.

Thanks for finding this!


[Question]: Any known issues that might cause delay of exactly 100 s. of starting a job execution after receiving it?

Describe your question
We experience delay between queuing and initializing a job of 100 s. (1:40 min) when executing the same pipeline on self-hosted agent on Linux ( on CentOs and Debian).
2023-03-23T14:06:16.0676904Z ##[section]Starting: Job
2023-03-23T14:07:56.4086577Z ##[section]Starting: Initialize job

On Microsoft hosted agents it is nearly instantaneous.
Part of the agent worker log when it happens:
[2023-03-23 11:52:19Z INFO HostContext] Well known directory 'Root': '/home/ladmin/myagent'
[2023-03-23 11:52:19Z INFO HostContext] Well known directory 'Work': '/home/ladmin/myagent/_work'
[2023-03-23 11:52:19Z INFO HostContext] Well known directory 'Bin': '/home/ladmin/myagent/bin'
[2023-03-23 11:52:19Z INFO HostContext] Well known directory 'Root': '/home/ladmin/myagent'
[2023-03-23 11:52:19Z INFO HostContext] Well known directory 'Work': '/home/ladmin/myagent/_work'
[2023-03-23 11:52:19Z INFO JobServerQueue] Try to append 1 batches web console lines for record '12f1170f-54f2-53f3-20dd-22fc7dff55f9', success rate: 1/1.
[2023-03-23 11:52:34Z INFO JobServerQueue] Stop aggressive process web console line queue.
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Bin': '/home/ladmin/myagent/bin'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Root': '/home/ladmin/myagent'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Work': '/home/ladmin/myagent/_work'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Tools': '/home/ladmin/myagent/_work/_tool'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Bin': '/home/ladmin/myagent/bin'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Root': '/home/ladmin/myagent'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Work': '/home/ladmin/myagent/_work'
[2023-03-23 11:53:59Z INFO HostContext] Well known directory 'Temp': '/home/ladmin/myagent/_work/_temp'

The pipeline description is probably irrelevant as we also tried extremely simple ones.
The problem does not stem from waiting on agents in a pool.
Any idea why this might be happening or if it is a known issue?
Thanks!
Versions
Agent version is 2.218.1.
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Operation system
CentOs 8, Debian 11
Version controll system
git
Azure DevOps Server Version (if applicable)
No response

https://github.com/microsoft/azure-pipelines-agent/pull/4166/files seems like a likely candidate
Is there any way of turning the telemetry off completely?

downgrading to v2.217.2 has fixed the delay in our environment

Hi @tvachev, thanks for reporting! We will take a look

@blushingpenguin Hi Mark. This is also hitting us. Many thanks for reporting.
What is the procedure to downgrade to an older agent version? I could not find any good information.

@mmunte-impeo
Remove the newer version
Disable the auto update from azure devops
Install an old version - @blushingpenguin suggests 2.217.2
I can confirm it works (Strangely enough we don't see the problem when running newer agent versions on Windows)

We are also having this issue.

Same issue with self hosted 3.xxx.x on macOS

Same issue here, exactly 1.40 each time a pipeline runs, Azure Self hosted agents.

Same issue.
Agent Version 2.218.0/3.218.0
Looks to me that there is a connection that doesn't use the proxy.
If I understand well the code the file src/Agent.Sdk/Util/PlatformUtil.cs at line 325 is making a connection without the context.
HttpResponseMessage response = await httpClient.GetAsync(serverFileUrl);
The same file at line 28 creates an object without context
private static HttpClient httpClient = new HttpClient();
In other part of the code I see (src/Agent.Listener/Configuration/ConfigurationProvider.cs line 359/260):
using (var handler = HostContext.CreateHttpClientHandler())
using (var httpClient = new HttpClient(handler))
Hope this helps.

Downgrading worked for me too. Running in a docker container based on:  https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/docker?view=azure-devops#linux
In that setup, to downgrade, make the following change in the start.sh script, then rebuild the image and redeploy the container(s):
#curl -LsS $AZP_AGENT_PACKAGE_LATEST_URL | tar -xz & wait $!
curl -LsS https://vstsagentpackage.azureedge.net/agent/2.217.2/vsts-agent-linux-x64-2.217.2.tar.gz | tar -xz & wait $!

The route via capabilities did not work for me, perhaps I'm doing something wrong there.
Hope this helps people like me coming from google upon this issue.

downgrading by using curl directly with previous version doesn't seem to work for me. Bizarre how if I target the latest version, it's all cool. Any ideas??

Look in the /azc/_diag folder logs for error messages, e.g.:
docker container list # find container name
docker exec -it $CONTAINER_NAME /bin/bash
    cd /azp/_diag/
    cat Agent_*
    exit

If you are hitting a bug that is fixed in the newer versions then I guess you are kinda out of luck on this one, unless there is an easy workaround there.

i believe this is a bug at this point, do we know when this will be resolved

downgrading by using curl directly with previous version doesn't seem to work for me. Bizarre how if I target the latest version, it's all cool. Any ideas??

Make sure your target host / container is linux-x64. If not, you may need to tweak the curl link.
I was able to downgrade successfully using a Linux Docker container. With v2.217.2 no more delay in the agent. I'll set it back to latest version once I confirm this issue is resolved.

@kirill-ivlev This issue is causing tremendous slowdowns in our builds and releases. When is this going to be fixed? It has been 3 weeks with no update.

Facing the same issue. Was using 3.218.0 and discovered this issue. Downgrading to 2.218.1 made no difference. Downgrading further to 2.217.2 works, for now.

downgrading by using curl directly with previous version doesn't seem to work for me. Bizarre how if I target the latest version, it's all cool. Any ideas??

Figures this might be related to Ubuntu 22.04 and the way it uses SSL. Downgrading to Ubuntu 20.04 allowed me to downgrade the agent version to 2.217.2.

Facing the same issue in 3.218.. When it's gonna be fixed?

We are having the same issue on all our linux agents with 3.218. Downgrade didn't work for us because of some SSL exception. When this will be fixed?

If you don't want to use iptables, you can also work around this by adding a blackhole route:
sudo ip route add blackhole <IP_ADDRESS>

It does not persist across reboots, so you need to handle that.

The blackhole trick worked on our servers.
Does this maybe have to be rettaged as BUG - instead of QUESTION?
Might this be the reason why this is not moving forward.

@tfabraham We are working on the fix now, and expect that it will be delivered with the next version

At my company we are facing the same issues!
If the mentioned PR is the solution, I would strongly suggest to provide a feature  to completely turn this telemetry thing off.
Thing is self host agents are usually behind the companies firewall which will eventually block or throttle this (in my case)
So I beg you, please provide a feature to turn this off

At my company we are facing the same issues! If the mentioned PR is the solution, I would strongly suggest to provide a feature to completely turn this telemetry thing off. Thing is self host agents are usually behind the companies firewall which will eventually block or throttle this (in my case)
So I beg you, please provide a feature to turn this off

This helps  >> sudo ip route add blackhole <IP_ADDRESS>

At my company we are facing the same issues! If the mentioned PR is the solution, I would strongly suggest to provide a feature to completely turn this telemetry thing off. Thing is self host agents are usually behind the companies firewall which will eventually block or throttle this (in my case)
So I beg you, please provide a feature to turn this off

This helps >> sudo ip route add blackhole <IP_ADDRESS>

Just a hotfix but works thank u!

Running our agents as docker containers made downgrading complicated. Instead we blocked <IP_ADDRESS> on the host using iptables.
iptables -I DOCKER-USER -d <IP_ADDRESS> -j REJECT

Important to add it to the chain DOCKER-USER or it will not have effect inside the containers. Using REJECT (and not DROP) will cause the http request to fail instantly.

this solved my problem. I think it is very interesting that the problem is still not permanently resolved.

Any update on this one? it's causing a lot of waiting time in our pipelines.

Seeing the same behaviour with this specific version on Ubuntu 22.

We host our pipeline agents in Ubuntu 22.04 containers. Seeing this same behavior; jobs get assigned an agent then freeze for 100s before continuing.
When will we see a fix for this issue?

Same issue. Lots of wasted build time. Following for fix.

FYI everyone the release that contains the fix just came out four hours ago (May 4, 2023 7:42 AM EDT). I will be deploying tonight.
https://github.com/microsoft/azure-pipelines-agent/releases/tag/v3.220.1

FYI everyone the release that contains the fix just came out four hours ago (May 4, 2023 7:42 AM EDT). I will be deploying tonight.
https://github.com/microsoft/azure-pipelines-agent/releases/tag/v3.220.1

I just updated my agent to 3.220.1 and the issue still persists.
Only thing that helps is blocking the IP as @SabareeshGC stated above with sudo ip route add blackhole <IP_ADDRESS>

How can I tell my agent to go and update to the pre-release version?

Running our agents as docker containers made downgrading complicated. Instead we blocked <IP_ADDRESS> on the host using iptables.
iptables -I DOCKER-USER -d <IP_ADDRESS> -j REJECT

Important to add it to the chain DOCKER-USER or it will not have effect inside the containers. Using REJECT (and not DROP) will cause the http request to fail instantly.

Unfortunately that didn't help. I ran it on the host, not in the agent container.

How can I tell my agent to go and update to the pre-release version?

if you're updating them from devops server, throw the zip/tar into "$env:programdata\Microsoft\Azure DevOps\Agents"

I am running the agents as linux containers. I can recreate them but then they autoupdate to the most recent release anyway and the issue persists.

the update capability checks that folder for latest agent builds. just dump them there. it will override the build from latest tag as the build number is larger

Version 3.220.1 has been released on May 4th. However, our Azure DevOps environment still hasn't listed it as available. The README in this repo states (if I understand correctly) that a new agent should normally be available after at most 6 to 8 days.
Is there some delay in the release process or should we do something to make the latest (pre-release) version available?
I know we can force install the agent by specifying the install-url manually, but we'd rather use the latest agent that is presented through the '_apis/distributedtask/packages/agent' REST endpoint

@HumanPrinter its a beta release you need to apply it manually as per posts above.

@HumanPrinter its a beta release you need to apply it manually as per posts above.

I don't think that is correct. According to the readme and issue https://github.com/microsoft/azure-pipelines-agent/issues/4221 pre-release only means that the version is still in the process of gradually being made available to all Azure DevOps organisations. Once all organisations have the version available, the release should be labeled 'Latest'. According to the readme this should normally take 6 to 8 days.

Well then you have answered your own question.

How can I tell my agent to go and update to the pre-release version?

if you're updating them from devops server, throw the zip/tar into "$env:programdata\Microsoft\Azure DevOps\Agents". The default ones used are the "vsts-agent" files.

@desmondkung @turowicz The post above specifies for a windows machine. That environment variable doesn't appear to exist for a Linux machine. How do we force the update on Linux?

I don't recall devops server can be installed in a Linux machine. Agent yes, server no.

How can I tell my agent to go and update to the pre-release version?

if you're updating them from devops server, throw the zip/tar into "$env:programdata\Microsoft\Azure DevOps\Agents". The default ones used are the "vsts-agent" files.

@desmondkung @turowicz The post above specifies for a windows machine. That environment variable doesn't appear to exist for a Linux machine. How do we force the update on Linux?

I don't recall devops server can be installed in a Linux machine. Agent yes, server no.

I am using AzureDevops and self-hosted Linux agents. Currently there seems no way to run a pre-release version of the agent.

If you're using Azure DevOps Services (the online offering), you're stuck until MS updates the backend.

If there's no way of running a pre-release version, why is it available? Seems pretty counterintuitive. There's got to be some way to update this manually without completely uninstalling it first.

@turowicz what about spinning up a Linux VM and installing the agent there manually as a temporary workaround? Command to link it back to Azure DevOps Services is identical to adding a new agent. Probably add a new capability to differentiate it from other agents in the same pool or create a new agent pool.

I use the self-hosted agent in a Linux container, as documented here. I updated the start.sh file that the docs talk about by adding these lines right after the existing AZP_AGENT_PACKAGE_LATEST_URL=... line.
AZP_AGENT_PACKAGE_LATEST_URL=https://vstsagentpackage.azureedge.net/agent/3.220.1/vsts-agent-linux-x64-3.220.1.tar.gz
export AZP_AGENT_DOWNGRADE_DISABLED=true

This works. I will of course have to remove those lines once 3.220.1 or later becomes "latest" so that the agent can auto-upgrade in the future.

@twinter-amosfivesix that script change helped, thank you so much!

It seems that version v3.220.1 was skipped and version v3.220.2 is the new latest, which fixed the delay issue 👍


How to find the Agent_IP_Adress

For the publisher_wifi_udp.ino sketch
How do i find the agent address ?
#define AGENT_IP   "AGENT_IP_ADDRESS"
Is it the address of the Host computer running the agent ?  (Note that ROS2 and the agent are in a docker)
Additionnal questions
I have used publisher_wifi_udp.ino sketch with a esp32, is it supposed to work.
After i have started the agent and received a feed back that look good
Press CTRL+C to exit
[1608501506.414674] info     | UDPv4AgentLinux.cpp | init                     | running...             | port: 2018
 ROS2 topic list     does not give /arduino_chatter_chatter as a topic
 ROS2 echo /arduino_chatter     gave Could not determine the type for the passed topic

 ROS2 node list is empty

Other problems
I have resinstalled the hole thing localy on my machine in order to test the serial option with tty/USB0 used in my machine.
I have the same result bad results
 An other thing
 After the agent installation setup, i can only run ./MicroXRCEAgent .....   with the console that i used to make the installation
 ( when a close the console and try to run in a new console i get the bash: ./MicroXRCEAgent: No such file or directory)
 I also had this problem with the docker

The AGENT_IP address is the IP of the machine that is running the MicroXRCEAgent service. When the esp32 has made a connection to ros2 you should see an output similar to the following lines.
[1614605288.607592] info | UDPv4AgentLinux.cpp | init | running... | port: 2018
[1614605331.310721] info | Root.cpp | create_client | create | client_key: 0xAABBCCDD, session_id: 0x81
[1614605331.310796] info | SessionManager.hpp | establish_session | session established | client_key: 0x2864434397, address: "IP address of your esp32":47138


[AutoNLP] setup log to file function by adding a trainer integration

PR types

PR changes

Description

lgtm


Not able to display Body Frame or Joints (labs 5 and 6)

Hi,
I am following the code and have even tried to run the provided solution with the full code but I am not able to display the body frame or the joints when I launch the application.
Any way to fix it ?
Thank you !

Also i have same problem, any solutions?

Did you stand back so the camera can see your whole body?