Fix dependencies and compilation

I'm opening this one because I'm interested in experimenting with blink, but had to make some changes to the dependencies to get this one to compile.
I'm interested in your feedback if this is the right direction to get blink working:

Remove dependency on trail: it had a transitive dependency on atacama v0.0.5, which does not seem to exist. It was only using Frame.ml from trail, which I've copied over (it could be moved to its own library and shared to avoid duplication)
Add missing dependencies and remove unused ones: digestif, bitstring, etc. were missing from the dune-project / opam file. cohttp was included but not used
Fix versions on some dependencies: the 5.3.1 version of httpaf was added, but I can't find a version higher than 0.7.1 in the official version or any obvious fork
Disable websocket test: this test seems to fail because its expecting a server to be running on :8080 - if its an example it probably should be moved to an examples folder

With these changes, I'm now able to get it compiling from scratch with a fresh switch using opam switch create ..

Thanks for the PR @chris-armstrong! ✨ Sorry it took so long, this fixed the CI and also makes Blink easier to deploy :)

Thanks @leostera. Not sure if I'll continue working on blink at the moment, but may jump on it again in the future.


[CWS] fix ttl field time.Duration unmarshaller

What does this PR do?
https://github.com/DataDog/datadog-agent/pull/31718 introduced an issue where you can't unmarshal a simple integer into a time.Duration anymore.
This PR fixes the issue by adding a new type that can unmarshal from both a human readable time (like 10s) and an integer.
Motivation
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


qgis: 3.28.3 -> 3.32.2

Description of changes
Update QGIS to the latest release.
List of new features is quite massive because we skipped one major release - 3.30.
List of changes:

https://changelog.qgis.org/en/qgis/version/3.30/
https://changelog.qgis.org/en/qgis/version/3.32/

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@offborg build qgis

Result of nixpkgs-review pr 250717 run on x86_64-linux 1

2 packages built:

qgis
qgis-ltr

@ofborg build qgis

Manually tested:

running built binary with test project from QGIS source code

@timlinux , please test if you can. Thank you

@markuskowa ,
thank you very much for approval.
I was not sure setting variable like this is a good idea. What do you think ?
  preBuild = ''
    export QT_QPA_PLATFORM_PLUGIN_PATH=${qtbase.bin}/lib/qt-${qtbase.version}/plugins/platforms
  '';

I was not sure setting variable like this is a good idea. What do you think ?
  preBuild = ''
    export QT_QPA_PLATFORM_PLUGIN_PATH=${qtbase.bin}/lib/qt-${qtbase.version}/plugins/platforms
  '';

I am not sure if it is the best solution, but it seems plausible to me to make it work consistently. Just grepping there are a few other packages that use the same trick.

Thank you very much @markuskowa

Shall I merge?

@matthiasbeyer , please wait for more testing from @timlinux.

@imincik Thank you - I have been testing and it all seems good so far. Some thoughts on the build definition:

I think building the tests is pretty wasteful of natural resources (electricity etc) since most likely no user will use them and we don't actually run them to verify our build is good (I don't think that is needed).
QGIS Server - again I think we should probably disable this and make separate package for it
Application shortcuts - in my tweaked version I made symlinks in the post build step to link qgis -> qgis-latest and qgis -> qgis-ltr so that if you install both packages you can launch them without having to figure out their absolute path in the store. Similarly it would be nice to generate discrete .desktop files for each build profile so they can be launched easily from the users WM.

I tested with SAGA and that seems to work nicely (using the newish SAGA python plugin). Could you clarify what is needed to have a build with GRASS support - and also perhaps consider enabling GRASS by default?

Thanks so much for completing my NixOS experience with this patch!
Tim

Thank you very much for testing @timlinux.

I think building the tests is pretty wasteful of natural resources (electricity etc) since most likely no user will use them and we don't actually run them to verify our build is good (I don't think that is needed).

Yes, if tests are not executed a part of build process, we can try to enable them them or disable them completely using
"-DENABLE_TESTS=False"

QGIS Server - again I think we should probably disable this and make separate package for it

Yes, I agree with this. Would you please create issue for that ?

Application shortcuts - in my tweaked version I made symlinks in the post build step to link qgis -> qgis-latest and qgis -> qgis-ltr so that if you install both packages you can launch them without having to figure out their absolute path in the store. Similarly it would be nice to generate discrete .desktop files for each build profile so they can be launched easily from the users WM.

Yes, I think we can do this. Would you please create issue for that ?

I tested with SAGA and that seems to work nicely (using the newish SAGA python plugin). Could you clarify what is needed to have a build with GRASS support - and also perhaps consider enabling GRASS by default?

GRASS support should be enabled by default using withGrass parameter which is true by default.

Thanks so much for completing my NixOS experience with this patch!

You are welcome. And as I already said, you are welcome to be a part of Nix Geospatial team.

@matthiasbeyer , please merge now.

:tada:


Version 3.0.0 on Laravel Framework 5.5.21

Prerequisites

[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[X] Checked that your issue isn't already filed.
[X] Checked if no PR was submitted that fixes this problem.

Versions

PHP version:  7.1.19
Laravel version:  5.5.21
Package version:  currently 2.1.0, trying to upgrade to 3.0.0

Description

I'm trying to upgrade the package version from 2.1 to 3.0
Steps to Reproduce

Try to upgrade the Laravel Excel package on a Laravel 5.5 project.
Expected behavior:
I expect to be able to upgrade my Laravel Excel package version from 2.1 to 3.0 since my system requirements are met (as shown above)

Actual behavior:

Laravel Excel 3.0.0 requires illuminate/support 5.6 but Laravel 5.5 doesn't have this.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

3.0.* supports Laravel 5.5 too. You are trying to install 3.0.0 specifically, you'll have to loosen up the constraint to 3.0.* to allow the latest patch version to be installed or ^3.0 to allow the latest minor version to be installed.


[PE-D][Tester D] Confusing message when cancelling makeup lesson

Before entering command:
￼
After entering command:

￼
When cancelling a makeup lesson, the message should say "Cancelled makeup lesson..." instead of "Cancelled lesson ..." because that will confuse users if a regular lesson was cancelled

Labels: type.FunctionalityBug severity.Low
original: rithanisk/ped#2

I don't think this is an issue, since the cancellation should be intentional. If anyone has anything to weigh in


Emit scroll event in QuantityInput

Not against this PR per se but scroll event is quite a ticking bomb. Basically it emits scroll events on desktop with pace of 30/s and in mobile it's 100/s (which brought down Twitter once: https://johnresig.com/blog/learning-from-twitter/). I have been going around deleting onscroll handlers in our codebase these days.
Can you explain why this is needed and for what?

Not against this PR per se but scroll event is quite a ticking bomb. Basically it emits scroll events on desktop with pace of 30/s and in mobile it's 100/s (which brought down Twitter once: https://johnresig.com/blog/learning-from-twitter/). I have been going around deleting onscroll handlers in our codebase these days.
Can you explain why this is needed and for what?

This scroll event is needed to load more results upon scroll. (just like what we've in the lookup component). normally, only 12 results are loaded first time and only the first six results are shown. then when the user scrolls down, we make a request to the API and load more results.
and the scroll event is only tied to the lookup part (not the entire page). so i think we're fine....for now

Not against this PR per se but scroll event is quite a ticking bomb. Basically it emits scroll events on desktop with pace of 30/s and in mobile it's 100/s (which brought down Twitter once: https://johnresig.com/blog/learning-from-twitter/). I have been going around deleting onscroll handlers in our codebase these days.
Can you explain why this is needed and for what?

This is usually debounced by the consumer application.

okay then. Please debounce and throttle (if making API requests).


fix: update link to example code in book testing page

The current link here 404s - this just fixes the link in the book markdown

Thanks!


[init.js] Support ChromeHeadless in validateBrowser

Looks like this was missed in #3096.

I signed it.


Add linux support to site_blocker script/

Where you stuck -
Frankly ask your question (We're also in learning phase :p )
I have added the site_blocker script. At present the script only works for windows OS and I want to add linux feature to it.
What you want to do?
I want to add linux support for the script
Any other remark/screenshot etc.

Please assign this issue to me so that I can contribute.


Storage release 2024-12-09

Storage release 2024-12-09
Please merge this Pull Request using 'Create a merge commit' button

Reviewed for changelog


Migrate with Swift 3 of XCode 8.

Now its time to upgrade calender with swift 3.

WWCalendarTimeSelector.swift.zip
Added explicit type annotation, updated deprecated M_PI with Double.pi - Xcode 8.3.3 Swift 3.2

#51

#51 check this out for Swift 3.2 ver


implement postscript string type

should have semantics similar to array (0 based, elements iterator), that way it can be used with the forall operator.
Could possibly be implemented as an Array, but that's a bit heavy duty considering it only stores characters, not any type like array does.

implemented with a luajit ffi char[?] internally

initial implementation.  Might become basis for other basic string/binary types in the future


Blocked version of Cholesky gradients

Summary:
Update our Cholesky differentiation algorithm from Giles' to Murray's:
https://arxiv.org/pdf/1602.07527.pdf
Description:
Current algorithm doesn't use memory locality to its advantage, yielding a slower algorithm than is possible with blocking.
Current Version:
v2.11.0

That would be awesome.

see here https://github.com/stan-dev/math/blob/a182f8cc7da99d6e74b9dc97347aaf7621ad99bc/stan/math/rev/mat/fun/cholesky_decompose.hpp
Any chance you could take a look and tell me if you see any obvious efficiency gains? I used this branch plus the new cov_exp_quad to estimate an N = 1280 GP in 35 mins last night on a compute-intensive AWS over the weekend, so this seems to be quite a bit faster than the current version. Not sure we'd even be able to estimate the N = 1280 GP with the current version.

Forgot to add, I ran the N=1280 one-dim GP for 500 warmup iterations and 500 post-warmup iterations

Can we open an issue to recruit Iain Murray to contribute to Stan?

I think that would be great, I was going to reach out to him anyway to see if he wanted to take a look at this branch.

@betanalpha @avehtari
N = 1280, AWS c4.2xlarge:
Ran 2 instances at @syclik's behest to see whether there were any timing differences between boxes, both runs are below. I generated 1280 data points from a GP where length scale = sqrt(3) (length in the inferences below) and amplitude = 0.5 (alpha in the inferences below). All chains were run from the same seed 383281.
Inference for Stan model: stan_new_code_model
4 chains: each with iter=(500,500,500,500); warmup=(0,0,0,0); thin=(1,1,1,1); 2000 iterations saved.

Warmup took (1082, 1087, 1087, 1087) seconds, 1.2 hours total
Sampling took (1051, 1050, 1050, 1050) seconds, 1.2 hours total

                 Mean     MCSE   StdDev        5%    50%    95%  N_Eff  N_Eff/s    R_hat
lp__             2268  3.1e-02  1.0e+00   2.3e+03   2268   2269   1116  2.7e-01  1.0e+00
accept_stat__    0.87  3.8e-03  1.7e-01   4.8e-01   0.95    1.0   1947  4.6e-01  1.0e+00
stepsize__       0.61  7.8e-16  1.1e-15   6.1e-01   0.61   0.61    2.0  4.8e-04  1.0e+00
treedepth__       1.9  1.6e-02  6.2e-01   1.0e+00    2.0    3.0   1440  3.4e-01  1.0e+00
n_leapfrog__      5.2  4.9e-02  2.1e+00   3.0e+00    5.0    7.0   1788  4.3e-01  1.0e+00
divergent__      0.00  0.0e+00  0.0e+00   0.0e+00   0.00   0.00   2000  4.8e-01     -nan
energy__        -2267  5.2e-02  1.7e+00  -2.3e+03  -2267  -2264   1028  2.4e-01  1.0e+00
beta              1.5  1.4e-02  4.4e-01   8.1e-01    1.4    2.3   1081  2.6e-01  1.0e+00
length            1.5  5.0e-03  1.6e-01   1.2e+00    1.5    1.7   1057  2.5e-01  1.0e+00
delta           0.010  1.3e-05  3.8e-04   9.6e-03  0.010  0.011    906  2.2e-01  1.0e+00
alpha            0.98  6.4e-03  2.4e-01   6.2e-01   0.97    1.4   1346  3.2e-01  1.0e+00

Currently running N = 5120 right now for 150 warmup, 150 samples on each box

Maybe have two kinds of plots.
For each parameter plot the 5-95 interval minus the true value as a band vs N,
then overlay the median minus the true value as a line vs N.  This will verify
that for each N we’re recovering a reasonable posterior.
Then on a single graph plot Neff/s (or s/Neff) as a function of N for each
parameter to see the performance scaling.
On Sep 6, 2016, at 8:41 PM, Rob Trangucci<EMAIL_ADDRESS>wrote:

Currently running N = 5120 right now for 150 warmup, 150 samples on each box
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

closed with #497


Move ER Gateway swagger spec inside of vWAN definition to fix documen…

…tation issues
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Can one of the admins verify this patch?

Hi @vinayada1 is the content of this PR only to move the content in expressRouteGateway.json to virtualWan.json without any changes? because it is hard to identify changes on this PR.
And please fix those CI failures. I suppose there may be some additional changes otherwise the CI should pass.

Hi @vinayada1 is the content of this PR only to move the content in expressRouteGateway.json to virtualWan.json without any changes? because it is hard to identify changes on this PR.
And please fix those CI failures. I suppose there may be some additional changes otherwise the CI should pass.

Yes, that is the only intention. Looks like the documentation is generated and for expressRouteGateway, it is currently not getting generated under vWan as needed

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

I am getting errors when I run prettier locally (errors with prettier itself). Could you please help me fix the prettier errors? Tried with oav tool on a different machine but that did not flag any errors.

/azp run

Please retarget to network-march-release as January branch was already released

/azp run automation - sdk

Why are all CIs gone? Weird. @NullMDR could you please take a look?

/azp run


add codecov to CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c498284). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage          ?   74.18%
=========================================
  Files             ?       37
  Lines             ?     2468
  Branches          ?      607
=========================================
  Hits              ?     1831
  Misses            ?      406
  Partials          ?      231

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c498284...0f393d4. Read the comment docs.


Changes to the document to include web UI time out configuration

Signed-off-by: Kallol Roy<EMAIL_ADDRESS>:nut_and_bolt: Description: What code changed, and why?
Web UI session timer is set by default  as "3m" if SAML is not configured as connector.
In case SAML is configured as connector the session timer is "24h"
This configuration can be set from the config.toml too but it is not documented anywhere in the docs nor in the output of:
chef-automate

:chains: Related Resources
:+1: Definition of Done
The document
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Closing this as we are covering it differently.


TouchID dialog sometimes get hidden

React Native: 0.57.8
react-native-keychain: 3.0.0
react-native-touch-id: 4.4.1
Build: Release
The TouchID dialog sometimes get hidden somewhere. This happens for both Android and iOS but the behavior has more impact on iOS. On iOS, opening the App Switcher using the Accessibility button does not work because the dialog is still active. If you tap the home button on iOS, the dialog will show up for a bit then get dismissed. I can also enter the PIN manually during this quirky behavior of the dialog.

Hi,
Sorry for the delay.
I have troubles reproducing this. I'll keep on trying but I hope someone else will be able to reproduce it :)
Cheers,
Jeremy

I've experienced this issue but it seems fixed in the latest version.


Invalid page warning

Right now neon frequently reports invalid page error for FSM pages:
"invalid page in block 2 of relation base/13010/16384_fsm; zeroing out page". As far as I remember we assume it to be expected warning and postgres can allocate space without FSM. But at least such warning should not be visible by users (and right now if you execute queries in psql, you will see them).
Also I start looking why it is produced and do not understand the reasons, taken in account that

wal_log_hints = on
We have rewritten fsm_extend function to initialize FSM  pages through buffers (rather than using SMGR API).
zenith_wallog_page always wal log FSM pages (as well as VM pages).

Concerning 3) - there is invalid comment in pagestore_smgr.c:
		/* FSM is never WAL-logged and we don't care. */

We actually do care and code for FSM and VM pagesis exactly the same, so that two id branches can be combined.

Fixed by #1657


Add open/close and dehumidify command

Proposing to add Open Close Command and Dehumidify Command.

Open Close Command is a specific type of On Off Command, typically used for controlling dampers and valves.
Dehumidify Command is a command used to initiate the dehumidification process.

Due to rebase, tests are failing for unknown reason. Applied a patch to a new branch: https://github.com/BrickSchema/Brick/pull/611


Add Ubuntu 18.04/20.04 support

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

puppet 5 / ubuntu 20.04 failures are expected due to missing packages.


fix: added retries to handle flaky github behavior on large monorepos

This is a collection of attempts to fix #1379. So far I've been able to get it to work partially, sometimes. However, I have yet to get a full successful run on the google-cloud-ruby monorepo (~300 packages in a single manifest).
This PR is more of a discussion starting point than a true PR. What I've done:

Added the retry plugin to get certain calls to retry (in particular, the pagination iterator inside the tagIteration call). This seemed to be necessary to get tag iteration to succeed on google-cloud-ruby which has >4000 tags.
Added the throttling plugin to get backoff that respects the throttling headers. It's unclear to me whether this helped, but it may have.
In mergeCommitsGraphQL() in github.ts I added a safe-dereference to handle failures when the response can be undefined.
I updated the "custom" graphql retry code to retry a few more times and delay longer. I also added code that detects ETIMEDOUT (see #1379). However, this code may be obsolete with the retry plugin.
I increased the page size for iterating over tags. This was necessary to get tag iteration to succeed on google-cloud-ruby; otherwise it would iterate >100 pages which eventually caused the API to kick us off, even with retry.
I modified some logic to remove a needsBootstrap check that I think is incorrect. However, it's unclear to me how needsBootstrap is set and why it's used in this way. As it is, needsBootstrap is always true for google-cloud-ruby, not because the manifest hasn't been initialized yet (it has), but because the logic assumes that you can read the first 400 releases and cover all packages, and that just isn't true for google-cloud-ruby.

Even with all this, I am unable to get a full release-please against the manifest to run. I know the basic logic works because I can limit the run to a single package in the manifest (by providing the --path= command line argument) and get it to work. I believe the issues are related to scaling GitHub API usage for the size of the repository and the number of packages, commits, tags, etc. contained therein. When run against the full manifest, it fails in various places, usually with an ETIMEDOUT that persists even through 3-4 retries. Sometimes this happens in the mergeCommitIterator step, and sometimes later when pulling additional information needed to assemble pull requests.
Additional notes:

The logic that iterates over recent commits looking for commits that should participate in a release, currently has a hard-coded max of 500 commits on the query. I'm concerned that actually should be unbounded. In a large monorepo, it's possible for a large number of commits to come in rapidly: if we have a batch of just one commit per package that get autogenerated and automerged, that's 300 already for us. And in general, I think there are a few other hard-coded maxResults values that may be causing behavior to become incorrect at scale.

A general comment, there seem to be a number of steps that are using the GitHub API heavily to get information that can be obtained locally from a clone of the repo (e.g. enumerating commits, enumerating tags). I wonder if there's a way to leverage the local clone, if available, to reduce the API load.
As a corollary, one solution I'm considering for google-cloud-ruby is actually to use the local clone for the initial determination of which packages may have releases, and then iterate over that (usually small) number of packages and call release-please with each individual package, which I know works. In other words, I'd effectively be reimplementing part of the release-please logic in my own scripts external to release-please. I hope it doesn't come to that, but as it stands, releases in google-cloud-ruby are currently effectively blocked by #1379 and I need to get them unblocked soon.

Closing after further discussion.


better file opening & preview

Opening file from explorer gives bad experience.  Sometimes it display preview mode, sometimes opening file at new tab.
I hope i can control those two easier in coming version.
Like this:
Single click for preview
Double click for opening file at new tab

It was sort of bug. My double click couldn't pin new tab and I thought vs code lack that feature. After checking doc, I found there is that function already. After reload, the double click worked back so I close this issue.


[Feature][doc] Rewrite doc "quick start" and move deployment into the tail of sidebar

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
We should add standalone server into quick star, and start dolphinscheduler before we create users or tenants, and then add  process definition and run it.
BTW, we should move the deployment section to the tail of the sidebar
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

remove stale


about translate and decode

When I use context-level model to decoding and test, is parameter MODEL-PATH a folder that include all models or a model file that is one model? if it is former，when decoding , Do it use averge checkpoint base on all models in the folder to decoding ?

One model. You can manually average the checkpoints with scripts/checkpoint_averageing.py


Control margins/padding in charts

I haven't found a way to control the margins/padding of charts. For most cases, that's not needed, but in some scenarios my charts are not centered in the panel, as can be seen below:

Sometimes the charts are also cropped (where parts of the visual elements are going beyond the panel margins), as can be seen below:

I have been playing around with the grid option, but it does not seem to do anything when it comes to margins/padding tweaking. Is it something that could be done to allow users to properly center charts in Grafana panels and avoid cropping charts (with visual components hidden outside of the panel area)?

@evertoncolling In ECharts, various visualization use different options to control margins and padding:
  calendar: {
    top: 120,
    left: 30,
    right: 30,
    cellSize: ['auto', 13],
    range: '2016',
    itemStyle: {
      borderWidth: 0.5
    },
    yearLabel: { show: false }
  },

We have not migrated Calendar to https://echarts.volkovlabs.io yet. Meanwhile, you can check it at https://echarts.apache.org/examples/en/index.html#chart-type-calendar. There is a cheat sheet for all visualization you can use to find the correct options: https://echarts.apache.org/en/cheat-sheet.html.
Let me know if it works for you.

Same for Sankey:
   {
      type: 'sankey',
      left: '2%',
      top: '2%',
      right: 150,
}

I was not aware of this way to manipulate the margins/padding. It works perfectly fine with both Sankey and Calendar charts. Thanks for the tip!
Ideally it would still be great if the charts would align to the center of the panel automagically, but I understand that this is a challenging endeavour (specially, if the positioning of the charts is controlled individually for each chart type).
Since it's possible to adjust padding/margins, I'm closing this issue.


Unable to use reference image

Hi there,
When i try to use a reference image i get the error:
PhotoMaker currently does not support multiple trigger words in a single prompt. Trigger word: img, Prompt: anime artwork illustrating driving on highway, festival billboards. created by japanese anime studio. highly emotional. best quality, high resolution.
I usually upload the image and then add 'man img' to the description.
Please how can this be fixed?

Hi, Whether you use the [NC] symbol,  the ref mode is not supported [NC] yet, I am modifying the code as soon as possible.

Hi there,
Ok thanks for that!
Thanks,
Babs
On Sun, 5 May 2024, 18:18 Yupeng Zhou, @.***> wrote:

Hi, Whether you use the [NC] symbol, the ref mode is not supported [NC]
yet, I am modifying the code as soon as possible.
—
Reply to this email directly, view it on GitHub
https://github.com/HVision-NKU/StoryDiffusion/issues/27#issuecomment-2094883105,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFMRRLOXDLU33CTEOOT7AY3ZAZSUZAVCNFSM6AAAAABHHYLZEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHA4DGMJQGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have support [NC] in ref image mode now! Please git pull the lastest code.
This is an example.

Hi Yupeng Zhou,
Amazing thanks!
Thanks,
Babs
On Tue, 7 May 2024, 20:55 Yupeng Zhou, @.***> wrote:

I have support [NC] in ref image mode now! Please git pull the lastest
code.
This is an example.
image.-.2024-05-08T033055.535.png (view on web)
https://github.com/HVision-NKU/StoryDiffusion/assets/49511209/6cc7bb10-8bae-4249-8f4b-89a3b95c605d
—
Reply to this email directly, view it on GitHub
https://github.com/HVision-NKU/StoryDiffusion/issues/27#issuecomment-2099194572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFMRRLNXD7I3AZWD4QGDN5DZBEWSLAVCNFSM6AAAAABHHYLZEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGE4TINJXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have support [NC] in ref image mode now! Please git pull the lastest code.我现在在参考图像模式下支持 [NC]！请 git pull 最新的代码。
This is an example.这是一个例子。

I want to generate a cartoon of Cristiano Ronaldo practicing his shooting skills. The cartoon drawn does not look like Cristiano Ronaldo, but your Iron Man cartoon does look like the Iron Man actor.


Bump Go to version 1.5.3

Signed-off-by: Tibor Vass<EMAIL_ADDRESS>

Mind including the files in contrib/builder too? :smile:

@tianon for you, I don't mind :)
I ran the generate.sh files, it changed a SECCOMP envvar. Hope thats fine

Oh hmm, that'll actually fail to build. :cry:

@tianon ok so i'll remove the seccomp change and will let you and/or @jfrazelle deal with that

Ok, sounds good. :+1:

LGTM

LGTM

windows seems to be red only because go version differs with the CI... weird

i fixed for future til we update all servers :)


fix(notify): add some template translate

What this PR does / why we need it:

[ ] Smoke testing completed
[ ] Unit test written

Does this PR need to be backport to the previous release branch?:
If no, just write "NONE".
If don't know, write "UNKNOWN", and let the reviewer decide.
If yes, write the release branches name in the below format and submit the related cherry-pick PR:

release/3.9

/cc @ioito @zexi @swordqiu
/area notify

/lgtm

/lgtm


Support Japanese manifest

I think Japanese language support would improve googlability.

https://developer.chrome.com/docs/extensions/reference/i18n/

I think Japanese language support would improve googlability.

@miyaoka I don't know much about it, but does that mean that translating here will change the way it appears in the Chrome Web Store and help improve Google's search results?


Extend cache options for start using ttl param for caching

Storyblock SDK is using apix/cache.
this package gives possibility to defile TTL for cached items.
These changes extends Cache option and gives possibility to use cache expire functionality.

Many thanks for your contribution @yehor-kapten-son ! I'll be closing this for now, since with our new version we swapped apix/cache for symfony/cache. Although no implementation for TTL was made yet, this feature is already on our roadmap.


Add abc.Awaitable, abc.Coroutine and abc.Generator classes to asyncio

I think we could package in a fallback module for collections.abc (similarly to what we do with selectors.py) to have better support for generators & coroutines compiled with Cython.

See also http://bugs.python.org/msg245776

I updated the backports_abc package. It now has an explicit installation procedure. I also added a pure-ABC implementation of inspect.isawaitable() as there is no other way to produce an Awaitable in pre-3.5 CPython versions than by implementing __await__().
I think it's ready to become a dependency of the asyncio backports now.


funbuff

the pair of numbers stored and everything must be INTS, cyclone is accepting floats, which is bad!!!
insert a warning for a copy/cut command without prior select, it should say: "no data to copy"
a paste command without anything copied should post the error: "clipboard empty" instead of "bad input (no input) -- no data to set"

funbuff is using "loud" for errors, right? could we get rid of that?
I find this one particularly annoying: "funbuff_read: funbuff.txt read successful"
there;s no need for a "funbuff_read", at least for "_read" - lets make it at least just "funbuff"

it looks like "set" overwrites? so if there were values for x:1-5, and you're setting for x = 1, you'll end up with 1 element in your funbuff? at least in the code as it is for funbuff_set (which i didn't modify i think), clear is called each time, meaning the old contents are erased. does this mean "paste" should overwrite too? anyways, for undo, it looks like i'll have to be writing a new non-clearing set

yep, it overwrites in cyclone, but it shouldn't - in Max it doesn't clear, so it only adds!
guess we found a bug ;)

there's placeholder code for funbuff_reduce, get rid of it? can't find docu on it

GET RID!!!

seems we got rid of warnings, but we should keep and add these:

insert a warning for a copy/cut command without prior select, it should say: "no data to copy"
a paste command without anything copied should post the error: "clipboard empty"


Can this code reproduce the results in the paper?

How long does it take to train?  It seems I cannot get the results given in the paper?

Yes, is there any problem?


v0.1.14 breaks streaming response rendering from Claude 3.5 Sonnet

We picked up v0.1.14 in our project today and noticed streaming responses from Claude via Bedrock are no longer rendered as chunks are delivered. The message from the model remains empty until a new reply is entered, then the message is rendered.
Reverting to v0.1.13 fixes the issue.
After entering a reply

After entering one more reply

The message not being renedered would be a response to:
ConversationChain(
        llm=ss.llm,
        verbose=True,
        memory=ConversationBufferWindowMemory(
            k=ss.configs['models']['llm'][model]['memory_window'],
            ai_prefix="Assistant",
            chat_memory=StreamlitChatMessageHistory(),
        ),
        prompt=llm_prompt,
    ).predict(
        input=input_text, callbacks=[StreamHandler(st.empty())]
    )

Hey @radu-malliu ! Any chance you have a piece of code that reproduces this? I'm running the following which is streaming successfully:
%pip install -qU langchain-aws==0.1.14

from langchain_aws import ChatBedrock

bedrock = ChatBedrock(model_id="anthropic.claude-3-5-sonnet-20240620-v1:0")
for chunk in bedrock.stream("hi"):
    print(chunk.content, end="|", flush=True)

hey @efriis, thanks for taking a look! I suspect it's related to the star rating we add to replies. Trying to whip something up to repro.

Hi there, I am on 0.1.15 and I am facing a similar issue. Just by taking this sample code from the documentation I am able to reproduce this. The chunks do not stream, instead it is as if I have used .invoke over .stream in terms of the perception to the user.

from typing_extensions import Annotated, TypedDict
from langchain_aws.chat_models.bedrock import ChatBedrock
import logging

logging.basicConfig(level=logging.INFO)

class AnswerWithJustification(TypedDict):
    '''An answer to the user question along with justification for the answer.'''
    answer: Annotated[str,...]
    justification: Annotated[str,...]

llm =ChatBedrock(
    model_id="anthropic.claude-3-5-sonnet-20240620-v1:0",
    model_kwargs={"temperature": 0.001},
    region_name="us-east-1",
    streaming=True
)  # type: ignore[call-arg]
structured_llm = llm.with_structured_output(AnswerWithJustification)

for chunk in structured_llm.stream("What weighs more a pound of bricks or a pound of feathers"):

    print(chunk)

Similar issue. Streaming callback handler is not working properly with ChatBedrock. This code should reproduce the problem:
from langchain_aws import ChatBedrock
from langchain.callbacks.streaming_stdout import StreamingStdOutCallbackHandler

chat_model = ChatBedrock(model_id="anthropic.claude-3-5-sonnet-20240620-v1:0", streaming=True, region_name='us-east-1')
system_message = ""
chat_model.model_kwargs = {
            "system": system_message,
            "max_tokens": 10,
            "top_k": 50,
            "top_p": 1,
            "temperature": 0.1,
        }

chat_model.callbacks = [StreamingStdOutCallbackHandler()]
response = chat_model.invoke([
            ("human", "Hello")
        ])
# streaming response should be streamed to stdout, but it's not.

Hi all, I was facing the same issue and I shared a mitigation here: https://github.com/langchain-ai/langchain-aws/pull/144#issuecomment-2273087241
If you are using the old LLMChain.run method, you can fix it by doing so:
        chain = LLMChain(prompt=prompt, llm=sonnet_llm, llm_kwargs={"stream": True}) # <---- THIS
        chain.run(name="Jane")

Thanks @hourliert but we've been using LCEL in our codebase and so this LLMChain is not a solution that solves the streaming issue for us.

Answered in #217. Also, streaming support is best for LCEL chains, look at this page for a LCEL conversation chain with memory support.
https://python.langchain.com/v0.3/docs/how_to/message_history
Closing as duplicate.


Vue3 snackbar memory leak

There is an issue with vue3-snackbar above v2.2.0
I have reported the issue here: https://github.com/evo-mark/vue3-snackbar/issues/12
So you should pin the version by adding:
"vue3-snackbar": "2.2.0"
to your package.json

Alright, I had to reset my PC so will soon start working on this.

Fixed in latest v1.1.0 update


Adds ability to add event listeners for content+ads ended, not just c…

Fixes FR from issue #97

LGTM


Feature: DynamoDB: transact_write_items

Fixes #2424
Implements: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.transact_write_items
Missing from the implementation:

The ReturnValuesOnConditionCheckFailure input parameter is completely ignored
Meaningful response - we're not computing the ConsumedCapacity or ItemCollectionMetrics yet

Error scenarios covered (taken from the docs):

[x] A condition in one of the condition expressions is not met.
[ ]  An ongoing operation is in the process of updating the same item.
[ ] There is insufficient provisioned capacity for the transaction to be completed.
[x] An item size becomes too large (bigger than 400 KB),
[ ] a local secondary index (LSI) becomes too large, or a similar validation error occurs because of changes made by the transaction.
[ ] The aggregate size of the items in the transaction exceeds 4 MB.
[x] There is a user error, such as an invalid data format.

Coverage increased (+0.005%) to 94.301% when pulling 54f51fc7c159d2f6993d3cce1561ccaba2bf3e9a on bblommers:feature/dynamodb_transact_write_items into 3b9717d5b1c8517b82a81177bfac899ca84aab96 on spulec:master.

Thanks!


Type predicate can sometimes result in different type than type discrimination

Bug Report

🔎 Search Terms

predicate, discrimination
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about 4.5.2. Test in 4.0 and nightly as well.

⏯ Playground Link

Playground link
💻 Code

function test(x: unknown) {
	if (typeof x === "string" || x === 0) {
		x
		if (x === "hello" || x === 0) {
			x
		}
	}

	if (check1(x)) {
		x
		if (check2(x)) {
			x
		}
	}
}

function check1(x: unknown): x is (string | 0) {
	return typeof x === "string" || x === 0;
}

function check2(x: unknown): x is ("hello" | 0) {
	return x === "hello" || x === 0;
}

🙁 Actual behavior
In the first set of nested scopes, typeof x is narrowed to string | 0 by the first if, and then "hello" | 0 by the second if. This behavior is correct.
In the second set of nested scopes, typeof x is narrowed to string | 0 by the first if, but is narrowed to 0 by the second if.
🙂 Expected behavior
"hello" is a valid part of the subset of string, and should be included in the union type. The types derived from these two methods should be identical.

I believe this to be a duplicate of #31156.

Behavior dates back to at least 3.3... I'm surprised this hasn't been noticed before (I suppose a union UDTG is weirdish).


[QA] First person view is not forced when playing Ratscape

Build version:
0.41.0
0.42.0 (not released yet)
Issue Description:
When teleporting to Metadynelabs the first person view is not forced and the teleport gun is never given to the user making it unable to play any type of levels on Ratscape
STR:

Open 0.42.0
Teleport to Metadynelabs
Validate that when the level loads...the first person view is never forced and the teleport gun is never given to the user

❌ Actual Result:
When teleporting to Metadynelabs the first person view is not forced and the teleport gun is never given to the user making it unable to play any type of levels on Ratscape
✔ Expected Result:
First person view must be forced in order to play properly
Repro Index:
10/10
Evidence:
https://github.com/user-attachments/assets/e5ebacbf-8617-4e81-b7f6-b6f0f7846a7a
Additional Notes:
This issue happens on Windows and Macos

Fixed at https://github.com/decentraland/unity-explorer/pull/2859

You rock! thank you Pravus!!!!!!


@at-root problem

I have problem to compile @at-root with "&" code SCSS
sample:
.class-name {
	color: blue;
	@at-root {
		.parent & {
			color: red;
		}
	}
}

and scssphp will result:
.class-name {color: blue}
.parent {color: red}

correct result:
.class-name {color: blue}
.parent .class-name {color: red}

This has been fixed within #593

I can confirm this is no more an issue


Condition in custom property mapping is not working

Hi
Condition in custom property mapping is not working - or at least it is not working as expected. The documentation says:

If the condition is not met, the mapping is skipped altogether.

So as I understand it, if the condition is not met, the value in target property should not be changed. But the behavior is this:

If the condition is met, mapping is performed as usual.
If the condition is not met, the mapping is not skipped, but default value for target property type is used. This effectively nulls reference types, zeroes numbers etc.

Example
public enum TestEnum
{
    DoNotMap = 0,
    Value1 = 1,
    Value2 = 2,
}

public class TestClass
{
    public TestEnum EnumVal { get; set; }
    public string StringVal { get; set; }
}

public static void TestMapster()
{
    TypeAdapterConfig<TestClass, TestClass>.NewConfig()
        .Map(dest => dest.EnumVal, src => src.EnumVal, src => src.EnumVal != TestEnum.DoNotMap)
        .Map(dest => dest.StringVal, src => src.StringVal, src => src.StringVal != "lorem");

    var testSource = new TestClass() { EnumVal = TestEnum.DoNotMap, StringVal = "lorem" };
    var testDestination = new TestClass() { EnumVal = TestEnum.Value1, StringVal = "ipsum" };

    Console.WriteLine(testDestination.EnumVal); // Value1
    Console.WriteLine(testDestination.StringVal); // ipsum
    TypeAdapter.Adapt(testSource, testDestination);
    Console.WriteLine(testDestination.EnumVal); // DoNotMap (0) - but should be Value1
    Console.WriteLine(testDestination.StringVal?? "* NULL *"); // null - but should be "ipsum"
    Console.ReadLine();
}

Stano

Hi again
I just looked at the source code and according to tests, this behavior is correct. So I have two issues with this:

I think, the documentation should be changed. For me the sentence the mapping is skipped altogether really means, that nothing is going to be done. And not that destination is going to be nulled out.
My personal opinion is, that it really would be helpful to have some mechanism to skip mapping of a property, based on a condition. And I recommend that in this conditional function is available not only source object, but also the destination object. So the condition can be based even on destination values.

Stano

document has been updated, thank you for reporting.
rather than enum DoNotMap value, how about just assign null, and add setting IgnoreNullValues

You are welcome. :smile:
It is not that easy, because that is not just one property and we should make all those properties Nullable, which is not what we want. For now, we just map these manually.

I will take some time and will try to implement it and send pull request.

Hi @satano,
Another solution just came up. AfterMapping could solve this issue.
TypeAdapterConfig<TestClass, TestClass>.NewConfig()
    .Ignore(dest => dest.EnumVal)
    .AfterMapping((src, dest) => {
        if (dest.EnumVal != TestEnum.DoNotMap) dest.EnumVal = src.EnumVal;
    });


Scrollbar

Hello , I am a GSSOC contributor
I would like to work on the scrollbar in the lorem ispum custom scrollbar repo  .
looking forward to useful contributions ...
Thankyou.

I would like to contribute in this project Please assign this to me


Add mysql example

And update readme
On create_schema

changed utf8 to UTF8MB4 to
avoid warnings
commented the drop if exist and create schema

ok


Extract EditorResourceConversionPlugin into its own source files and clean up editor includes

property_editor.h/cpp are files that contain property editors that predate the inspector and its new property editing widgets. While still in use in visual scripting and visual shaders (something that I'll rectify at some point), this file was included in a bunch of places for no good reason. It also contained EditorResourceConversionPlugin, just because.
So I've removed EditorResourceConversionPlugin from there and put it into its own files in editor/plugins. I've also removed all the unnecessary includes of property_editor.h from the codebase. These two actions unveiled that a lot of places were functioning on the mere fact that property_editor.h was included in editor_node.h. A significant chunk of editor codebase included editor_node.h and property_editor.h alongside it, and as a result it also included editor_settings.h, for example. Which I had to properly include in every case.
Even worse, some of the UI tools relied on the fact that property_editor.h included things like separators and trees, and by osmosis they could use them without proper chain of dependency. So I had to fix that too.
It builds, and it runs. I shouldn't have broken anything with this, and maybe some includes are now a bit cleaner and builds are a bit faster.
PS. Unfortunately, this doesn't remove property_editor.h from every place that shouldn't need it (VSes aside). We also have property_selector.h/cpp, which actually relies on property_editor.h and CustomPropertyEditor. It would have to wait for a proper PR that deprecates all this obsolete code.
PPS. File should really be called custom_property_editor.h/cpp because it defines CustomPropertyEditor, but since it's on its way out, I've ended up not touching that.

Thanks!


add  and  tag support for op_return tool

I'm not really sure how OP_RETURN is supposed to work, but I feel like tags usually have closing tags

@marceloneil  the SLP branch is in very early stages.   Can I kindly request you save your code review until its a bit farther along?

Oh sorry, didn't know this was a different branch. I get notifications for anything on this repo


Null-Dereference bug at message.c

I found a Null-Dereference bug at message.c.
When the alloc() at message.c:2588 fails and returns NULL, the variable buf in msg_puts_printf() will become NULL. And then the memcpy() will copy data to a space beginning at NULL, and cause crashes.
To fix this bug, it should be checked whether the buf is NULL after alloc().

@brammool


"zsh: command not found: norminette"

after install norminetteV3 like they said in the instruction, after reset iterm session and reload the pc, I try to use command "norminette" they say me "zsh: command not found: norminette" any issue to this?

Hello,
Please contact your campus staff for that kind of issues.


Custom element dom tweaks

Couple of tweaks to dom that could make using/creating custom elements a little bit nicer:

export a slot element for use.

import {div, slot} from '@cycle/dom';

div([
  slot()
])

export the createTagFunction from hyperscript-helpers.

import {div, createTagFunction} from '@cycle/dom';
customElements.define('fancy-button', FancyButton);
const fancyButton = createTagFunction('fancy-button');

div([
  fancyButton('Hello')
])

What do you think?

Maybe a step towards support for custom elements would be a step away from element functions (div, span, etc.)?
What about #467.

Can you elaborate? What does slot do?

I also don't know what slot is.
Also, a central concept to Cycle.js is that side-effects are in drivers. Defining custom elements is a side effect in the DOM.
It seems that the concept of custom elements is a bit at odds with some of the main concepts in Cycle.js, because custom elements couple component behavior with the DOM itself, by extending native DOM objects. any thoughts?

It seems that the concept of custom elements is a bit at odds with some of the main concepts in Cycle.js, because custom elements couple component behavior with the DOM itself, by extending native DOM objects. any thoughts?

Rather correct, but so is the native <select> dropdown not simply a "view", it has interaction too. I think as long as we play along with the rest of the DOM, these kind of "cheats" are ok.

Heres a quick example (look at the HTML and the JS):
https://esnextb.in/?gist=afb7928001c196040685e9bc6afb1343
basically you define a custom element called <story-list>
class StoryList extends HTMLElement {
  constructor() {
    super();

    let shadowRoot = this.attachShadow({mode: 'open'});
    shadowRoot.innerHTML = `

          <slot name="breaking"></slot>

          <slot></slot>

    `;
  }
}
window.customElements.define('story-list', StoryList);

Notice the shadowDOM has two slots in it <slot></slot> and a named slot <slot name="breaking"></slot>
Now if you nest elements inside the <story-list>, by default elements will be placed inside <slot></slot>.
e.g.
A story
, will go inside slot.
But if you give the element a slot attribute, it will go to that slot instead.
e.g.
A breaking story OMG

So this:
<story-list>

A story

A breaking story OMG

SUPER IMPORTANT STORY

Another story

Yet another story

</story-list>

Would end up with two lists like this (ish):
<story-list>

A breaking story OMG

SUPER IMPORTANT STORY

A story

Another story

Yet another story

</story-list>

In the case of cycle.js it can be clunky to nest multiple components inside a component, as we have to pass the props and sources along with them and deal with it all hence collection and onionify etc...
But if we had a <todo-list> custom element, with a <slot> inside it. and a <todo-item> custom element.
you could do this:
const todoList = createTagFunction('todo-list');
const todoItem = createTagFunction('todo-item');

return div(
  todoList([
    todoItem('1'),
    todoItem('2'),
    todoItem('3'),
    todoItem('4')
  ])
)

Very rough idea there above: and you wouldn't want to make everything into a custom-element.
But imagine creating a library of ui elements eg. material-ui-elements that have nicely styled and functioning UI elements created in cycle and turned into custom elements via something like your customElementify.
They take properties, attributes, emit custom events whenever they need to.
This library could be used by any framework, and you wouldn't need to invent <new-framework>-material-ui for every new framework that comes out.
You would consume the elements, and write the actual app logic around those elements in whatever framework you desire.
More info here:
https://developers.google.com/web/fundamentals/getting-started/primers/customelements
https://developers.google.com/web/fundamentals/getting-started/primers/shadowdom

Slots are part of the Shadow Dom spec, not the custom element spec, though it would be great to have support for boths specs...
It's not necessary that a custom element uses a Shadow Dom, but it can be attached via var shadowroot = element.attachShadow(shadowRootInit);.
A Shadow Root has it's own encapsulated DOM tree (ShadowRoot.innerHTML) independent of the host elements element.innerHTML Custom Elements can be used without Shadow Dom...
Slots are nothing more than insertion points to merge an element's own DOM tree into the Shadow DOM tree.
The goal with custom elements is to make them behave as much like native elements as possible (i.e. attributes/properties in, dom events out), So I don't think you'd want them to be "self-contained" cycle.js applications unless you're dispatching the dom events via a driver.

Due to these nice explanations, I'm raising the priority from maybe to should.

Let's please have some progress on this. I'm dying to be able to use Custom Elements v1 with Cycle.js. Finally "Plug and Play" with a nice decoupled messaging infrastructure, much like Micro Services on the backend.
PS: The built-in HTML elements can be viewed as "out of the box" custom elements, in fact I believe they also (essentially) extend HTMLElement.

I think Cycle.js support for custom elements (as part of a web component) could be really awesome. Since Web Components may use a Shadow DOM to encapsulate their own markup, presentation, and perhaps fire custom events as well; I would think that they would fit nicely into the pluggable architecture that Cycle.js provides. Looking forward to how these ideas progress here :)

I managed to use custom element v1 with CycleJS. You can have a look to this repo. I used the API to manipulate directly the DOM as explained in the cycle documentation

@issuehuntfest has funded $40.00 to this issue. See it on IssueHunt


From the go2RTC access camera to the homekit, it seems that it is not an Apple security video function, and it is not possible to play back video in the home

Looks like you finish with #606
Go2rtc haven't support HKSV yet.


Gracefully handle Electrum errors

It now shows a system notification if it fails.
Fixes #187

This doesn't currently work as it seems Marketmaker blocks enabling other Electrum servers when one of them is not responding correctly.
I'm just getting this logged after 20 seconds:

Even though it's only KMD that has invalid Electrum servers.
@lukechilds Any thoughts on what we should/can do?

Testing now, I may have an idea.

The issue is that you're timing out after 20 seconds, but it takes way longer than that for mm to time out. And mm processes all requests serially, so the first request to fail will block all future requests meaning they all take longer than 20 seconds (but do complete successfully).

Instead of implementing our own timeout, we need to check the mm response.
Failures respond with:
{"ipaddr":"sindresorhus.com","port":10001,"error":"couldnt connect to electrum server"}

successes respond with:

Just realised, this is already handled by the api:
return responses.filter(response => response.result === 'success') > 0;

Working on a fix.

And mm processes all requests serially, so the first request to fail will block all future requests meaning they all take longer than 20 seconds (but do complete successfully).

I had a feeling it would be something like that.

but it takes way longer than that for mm to time out.

How long? We don't want it to be too long. That just creates a bad user-experience if the login takes forever just because of one non-working Electrum server.

How long?

It looks like not resolving to DNS takes about 5ms (my force.fail example).
However if I use a real domain that just isn't an Electrum server it seems to consistently take 1.3 mins 😬

That just creates a bad user-experience if the login takes forever just because of one non-working Electrum server.

Agreed.
@jl777 is the 1.3 min timeout hardcoded into marketmaker? If so is it possible to reduce it? Realistically, if an Electrum server is running slow, we probably don't want to connect to it anyway. It might reduce the chance of successful swaps. I think something like 5 seconds is more than enough.

I think something like 5 seconds is more than enough.

5 seconds might too short. Especially in countries with generally slower networks. I think 10 seconds would be good.

electrum timeout is set to a relatively low value. 7 or 13 seconds. I think it is just getting stuck returning from a tcp connect. Not sure why it is taking over one minute...

does this happen if you use IP address? if so, then the issue is DNS

electrum timeout is set to a relatively low value. 7 or 13 seconds. I think it is just getting stuck returning from a tcp connect. Not sure why it is taking over one minute...

@jl777 would it be possible to just implement a timer in marketmaker? If a connection hasn't been established successfully after the time has elapsed for whatever reason just abort everything and return an error.

does this happen if you use IP address? if so, then the issue is DNS

Yeah, just tried with <IP_ADDRESS> (Google's IP) and it took 1.3 minutes

how to abort a pending connect() call? maybe there is a way, but I am not sure how to do it in any OS independent way

reproduced the issue, I will see what I can do

all the time is in the connect() system call
    printf("call connect sock.%d\n",sock);
    result = connect(sock,(struct sockaddr *)&saddr,addrlen);
    printf("called connect result.%d lag.%d\n",result,(int32_t)(time(NULL) - starttime));

I have an idea to fix this programmatically, but no idea if it will work or not

how to abort a pending connect() call?

If there's no support for it in the system, you can just abstract the call, set a timer, when the timer runs out, fail the method, and when the response comes back from connect(), just ignore it. That's how we do it in the JS world with Promises that cannot be canceled.

the issue is that mm is single threaded for processing and what you say is easy, requires implementing a totally async calling structure, which wont be until mm2.0
i am experimenting with changing socket from sync to async to sync

Thanks James

pushed a version that times out in 5 seconds for the invalid electrum ipaddr above, it seems to still work ok in unix, we are testing in windows which of course behaves differently

@jl777 This is working for me now (timing out after 5s)
@sindresorhus I think this is ok to merge, the timeout issue is unrelated to HyperDEX and even without this PR it will still delay for ages, they just won't get any feedback.


OpenJSCAD throws fs.js error under node.js 7.0.0

When running OpenJSCAD from the command line under node.js 7.0.0 the following error is thrown:
note: this is after applying the suggested fix in issue: #197.

~/OpenJSCAD.org$ openjscad examples/example001.jscad
converting examples/example001.jscad -> examples/example001.stl (STereoLithography, ASCII)
Blob: type [application/sla] size [386566]
fs.js:50
throw new TypeError('"options" must be a string or an object, got ' +
^
TypeError: "options" must be a string or an object, got number instead.
at getOptions (fs.js:50:11)
at Object.fs.writeFile (fs.js:1184:13)
at Object. (/usr/local/bin/openjscad:261:4)
at Module._compile (module.js:573:32)
at Object.Module._extensions..js (module.js:582:10)
at Module.load (module.js:490:32)
at tryModuleLoad (module.js:449:12)
at Function.Module._load (module.js:441:3)
at Module.runMain (module.js:607:10)
at run (bootstrap_node.js:382:7)

Removing the 0, at the end of line 261 in openjscad fixes the problem.
I suspect this is caused by a node API change because the exact same line works in node v0.10.23, but I haven't been able to find when the API changed.
OpenJSCAD version:
~/OpenJSCAD.org$ git show
commit ea91305cf486c88553e03962514c996a9c1c39ef
Merge: 8269eff 1b94f54
Author: Z3 Development<EMAIL_ADDRESS>Date:   Sun Sep 11 11:08:52 2016 +0900
Merge pull request #171 from fischman/patch-1

Unbreak intersection() & difference() for CAGs.

node version:
~/OpenJSCAD.org$ node -v  v7.0.0
Ubuntu version:
~/OpenJSCAD.org$ lsb_release -a No LSB modules are available. Distributor ID:	Ubuntu Description:	Ubuntu 14.04.3 LTS Release:	14.04 Codename:	trusty

@mrsimicsak Thanks for the information.
There's a major re-organization happening now. Do you think this is important enough for making a patch to 0.5.2?

@mrsimicsak did you also try under one of the LTS versions of Node ?
node.js 7.0.0 has a lot of issues from what I heard
Also the way OpenJscad installs itself is not very standard , so that might also mess with how things are behaving.
FYI when I run the openjscad CLI directly (NOT using the install, as I have no system wide Node.js, only via NVM) there is not issue for me in 6.9.0

@kaosat-dev I ended up on version 7.0.0 by installing node and npm and then installing 'n' and running 'sudo n stable'.
I actually wasn't aware that there were LTS versions of node.
Using 'n' to install the LTS version I ended up with version 6.9.2. reverting my change, and running openjscad again I don't have the problem.
I just tried node 7.2.1 and the problem exists in that version as well.
Based on this https://github.com/nodejs/node/pull/7165 it looks like a change introduced in 7.0.0.

@mrsimicsak thanks for the infos !
this will be fixed together with the huge codebase restructuring , fix was trivial :)
https://github.com/Spiritdude/OpenJSCAD.org/pull/205/commits/f90a4990a7edaa0af5a6f5c0ff79d0861329f1c2

@mrsimicsak  this should be completely fixed, as we have node 7.x as part of the tests on TravisCI, could you please check if it works for you ?

After installing node v7.10.0 via nvm and the latest cli using the instructions on the github repo page, everything appears to be working fine.

Ok great , thanks @mrsimicsak ! Closing this, will reopen if needed


Task - New Taxon Name - original combination genus

If I create original combination from the current classification (For example "Aus bus"). Combination is properly created. If I move the genus to subgenus. It perfectly moves. But the genus name is blocked after. You can search for a new genus name, but the selection does not save

I think this was a bug related with flexbox, pushed a fix.


Question about validation and testing

Hello,
I wonder if there is a train-validation-test split or a train-test split only. I'm asking because during the dataset generation train-* and test-* files are generated, but no valid-* files. Then later, during pre-training, distributed_pretraining_dataset.py searches for valid-* files rather than test-* files (line 164). There are no such files and therefore, training crashes...
Thanks a lot!
David

Hi @peerdavid, thanks for finding this issue. We only have train-valid sets (or train-test).
I'll fix this (or you can go ahead and PR this😎 )
Thanks

Thanks a lot for your answer - sure I will open a PR :)

@peerdavid I'm having the same problem.
Let me know if you need a hand or tester.

@peerdavid I'm having the same problem.
Let me know if you need a hand or tester.

PR #7 should fix this issue - for me pre-training is no running on the bookcorpus + wiki dataset :)

@peerdavid I'm having the same problem.

Let me know if you need a hand or tester.

PR #7 should fix this issue - for me pre-training is no running on the bookcorpus + wiki dataset :)

Awesome!
I got pretraining running Yesterday without validation on the wiki dataset. Now I want to get it running with validation enabled and with the bookcorpus.

Thanks a lot for your answer - I will open a PR :)

Thanks!


contrib: fix windows archive creation in release script

It would create an empty archive since it didn't recurse down the directories..

ACK a0404e5d69e895467a5a51621e728b78140eae8e


[DO-NOT-MERGE] Compiled PropertyPath for setters

Currently intended for use in animations.
@jmacato
For now they are quite simple, but already support syntax like
(Visual.RenderTransform):=ScaleTransform.ScaleX
MyProperty :> MyModelType .Foo.Bar
MyProperty as MyModelType .Foo.Bar
Where :> and as are cast operators, and := is type ensuring operator
Type ensuring is needed for animations to be able to switch a property value type somewhere along the path
E. g. if RenderTransform isn't a ScaleTransform, set RenderTransform to a fresh instance of ScaleTransform
Casts are needed for bindings to ensure that property has a correct type to continue.
IPropertyInfo and ClrPropertyInfo provide reflection-free access to regular CLR properties. This is backed by compile time property accessor generation. ReflectionClrPropertyInfo uses provides same interface via reflection and is not used by compiler.
I've also made AvaloniaProperty to implement IPropertyInfo for convenience purposes

What's the purpose of the ChildTraversal element in the property paths? Since it can only legally be followed by a Property element and has no state, it should not be represented in the PropertyPath element list and the . that it represents should be handled exclusively by the parser. That way, there's less possibilities for an invalid PropertyPath and a cleaner API for manipulating them.

We can remove the child traversal element. I was thinking that it might be useful for type enforcement operator := to keep track of the traversal point, but it's not really required.

closing due to inactivity.


Possible security flaw, leaking access token

Hey, thank you for this awesome extension! 🎉
My concern is; we need to add our github access token with repo permission to configuration file. So that any extension can read it. As a result of this, an evil extension developer can take our personal access token and breach into our private repository.
What do you think about this problem, can there be a more secure way to authenticate the extension?

@ergunsh thanks for your feedback. Putting tokens in the configuration is not a perfect solution, we will visit this while pushing this extension forward.
At this moment, github.accessToken is a not must. If your local git credential manager (the one ships with Git) already remembers your credentials, we will use that when there is github.accessToken available. The only catch here is, if you don't have saved credentials and no github token, we don't have a way to do authentication yet.

Thanks for your information.


winafl: use exe_name instead of the preferred name

This PR modifies winafl so that it uses the executable name as the name of the module - as opposed to the "preferred" name. The preferred name can be found in the PE headers of the executable in the Debug directory for some of them.
One example is to take 'test.exe', to rename it to 'foo.exe'; winafl will still consider the module 'foo.exe' as 'test.exe' which is super annoying and confusing.

I agree this can be pretty annoying. Thanks!


Task - Keyboard blinks when the delete task confirmation pop-up appears

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/32575
Action Performed:

Create or open any task from any chat
Tap on the three dots on top right > Delete

Expected Result:
There's no blinking or pop over of the keyboard when deleting a task
Actual Result:
The keyboard opens and closed for a moment when tapping to delete task and the transition is not smooth
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/16c502e3-44bf-4f53-8112-b5c73c472f1e
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp
CC @quinthar

Reproducible. Seems to be a known issue with a fix in review already, and it doesn't prevent from deleting the task, so we won't hold the deploy on this.


DSSP fails with generated cif file

I am using DSSP to some cif file generated by BioStructures.jl, the cif file looks like
data_6GC4_ba1.cif
#
loop_
_atom_site.group_PDB
_atom_site.id
_atom_site.type_symbol
_atom_site.label_atom_id
_atom_site.label_alt_id
_atom_site.label_comp_id
_atom_site.label_asym_id
_atom_site.label_entity_id
_atom_site.label_seq_id
_atom_site.pdbx_PDB_ins_code
_atom_site.Cartn_x
_atom_site.Cartn_y
_atom_site.Cartn_z
_atom_site.occupancy
_atom_site.B_iso_or_equiv
_atom_site.pdbx_formal_charge
_atom_site.auth_seq_id
_atom_site.auth_comp_id
_atom_site.auth_asym_id
_atom_site.auth_atom_id
_atom_site.pdbx_PDB_model_num
ATOM 73085 N N   . ALA ? ? ? ? 185.887 176.406 181.621 1.00 0.01   ? 1   ALA 0 N   1
ATOM 73086 C CA  . ALA ? ? ? ? 186.542 177.528 182.277 1.00 0.01   ? 1   ALA 0 CA  1
ATOM 73087 C C   . ALA ? ? ? ? 186.071 178.842 181.677 1.00 0.01   ? 1   ALA 0 C   1
...

the output looks like
DSSP: ==== Secondary Structure Definition by the program DSSP, NKI version 4.4.0                         ==== DATE=2023-09-19        .
│ REFERENCE W. KABSCH AND C.SANDER, BIOPOLYMERS 22 (1983) 2577-2637                                                              .
│ HEADER    xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx            6GC4                                                             .
│ COMPND                                                                                .
│ SOURCE                                                                                .
│ AUTHOR                                                                                .
│     0  1  0  0  0 TOTAL NUMBER OF RESIDUES, NUMBER OF CHAINS, NUMBER OF SS-BRIDGES(TOTAL,INTRACHAIN,INTERCHAIN)                .
│      0.0   ACCESSIBLE SURFACE OF PROTEIN (ANGSTROM**2)                                                                         .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(J)  , SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS IN     PARALLEL BRIDGES, SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS IN ANTIPARALLEL BRIDGES, SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I-5), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I-4), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I-3), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I-2), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I-1), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+0), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+1), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+2), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+3), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+4), SAME NUMBER PER 100 RESIDUES                              .
│     0  nan   TOTAL NUMBER OF HYDROGEN BONDS OF TYPE O(I)-->H-N(I+5), SAME NUMBER PER 100 RESIDUES                              .
│   1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30     *** HISTOGRAMS OF ***           .
│   0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0    RESIDUES PER ALPHA HELIX         .
│   0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0    PARALLEL BRIDGES PER LADDER      .
│   0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0    ANTIPARALLEL BRIDGES PER LADDER  .
│   0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0    LADDERS PER SHEET                .
└   #  RESIDUE AA STRUCTURE BP1 BP2  ACC     N-H-->O    O-->H-N    N-H-->O    O-->H-N    TCO  KAPPA ALPHA  PHI   PSI    X-CA   Y-CA   Z-CA

May I know what header information the cif file must have?
For PDB file I just add one line like HEADER    XXXXXXXXXXXXXXXXXXXXXX                  25-DEC-23   XXXX               and it works.

Could you send us the full cif-file so we can check what is missing?

Sure, here is the link. The file I want to process is 6GC4_ba1_m1.cif. Thanks for your help!

This file you try to process is a bit stripped down. There's only the atom_site category. A valid file would have contained much more.
If you look at the contents of the other file you have in your google drive, it contains much more data.
It is possible to reconstruct a somewhat valid cif file for your input file. If you install the cif-tools you can do a cif2pdb and then convert that pdb into cif again using pdb2cif. The pdb file as well as the converted cif file are accepted by mkdssp.
We will eventually change our code to accept these crippled files, but perhaps it is best to complain with the authors of BioStructures.jl for writing out such invalid data.


"#import" with latest version not working

Question from a newby:
#import "@preview/polylux:0.3.1": *
does not work for me, whereas
#import "@preview/polylux:0.2.0": *
works
It seems that this is the version that typst supports (https://typst.app/docs/packages/).
How can I upgrade?
I use typst with an editor (vs code).

Which version of typst do you use?

Just wait a bit, v0.3.1 hasn't been merged into the package registry, yet :)

If you can't wait you can clone the repository to your local package directory.
git clone --depth=1 https://github.com/andreasKroepelin/polylux.git "{data-dir}/typst/packages/local/polylux/0.3.1"

where {data-dir} is

$XDG_DATA_HOME or ~/.local/share on Linux
~/Library/Application Support on macOS
%APPDATA% on Windows

Reference: https://github.com/typst/packages#local-packages

Thanks everyone for your help!
@chengluyu solution is great. I didn't use the command line, but manually downloaded the main branch. Then only had to add "preview" instead of "local" to my local path (so I used "{data-dir}/typst/packages/preview/polylux/0.3.1") on Windows.

Sorry for the wait everyone, it's merged now!


How to Add IMS subscription

Hi Herle,
I have followed instruction from Open5GS doc website in sub section: Add IMS subscription use in FoHSS as follows from the Web GUI.
And already at these steps:
And, finally add these IMPUs as implicit set of IMSI derived IMPU in HSS i.e<EMAIL_ADDRESS>as follows:

Goto to IMPU<EMAIL_ADDRESS>In "Add IMPU(s) to Implicit-Set" section give IMPU Identity created above to be added to this IMPU

What is the meaning of this instruction: In "Add IMPU(s) to Implicit-Set" section give IMPU Identity created above to be added to this IMPU...???
Here is the screenshot at hss web console:

Please inform the next step. Thanks

What is the meaning of this instruction: In "Add IMPU(s) to Implicit-Set" section give IMPU Identity created above to be added to this IMPU...???

The IMPUs you created tel:xxx and sip:xxx for this particular IMPI, you need provide then in section "Add IMPU(s) to Implicit-Set" above "List IMPUs from Implicit-Set" section as seen in above picture and press "Add" one by one.

Thanks for your explanation.
Could you please check the following settings? Is this correct:

Thanks again

Looks good. Send me a screenshot of list of IMPUs as well

How to display the list of IMPUs?
Yes, i believe i can use any valid telephone number, i will try for the next subscriber

Go to User Identities --> Public User Identity --> Search --> Press on Search button

Is this ok?

All good

thanks


NFD does not label the  arria10 fpga following the operator README

Hi guys,
I am trying to provision fpga support on our K8s cluster. I mainly follow the operator README but no success

https://github.com/intel/intel-device-plugins-for-kubernetes/blob/main/cmd/operator/README.md

After NFD and the NodeFeatureRules have been installed, I don't see my FPGA node gets labeled as expected.
I0706 02:13:11.213981       1 nfd-worker.go:155] Node Feature Discovery Worker v0.10.1
I0706 02:13:11.214076       1 nfd-worker.go:156] NodeName: 'r640-1-10.local'
I0706 02:13:11.214440       1 nfd-worker.go:423] configuration file "/etc/kubernetes/node-feature-discovery/nfd-worker.conf" parsed
I0706 02:13:11.214500       1 nfd-worker.go:461] worker (re-)configuration successfully completed
I0706 02:13:11.215027       1 base.go:126] connecting to nfd-master at nfd-master:8080 ...
I0706 02:13:11.215083       1 component.go:36] [core]parsed scheme: ""
I0706 02:13:11.215110       1 component.go:36] [core]scheme "" not registered, fallback to default scheme
I0706 02:13:11.215150       1 component.go:36] [core]ccResolverWrapper: sending update to cc: {[{nfd-master:8080  <nil> 0 <nil>}] <nil> <nil>}
I0706 02:13:11.215166       1 component.go:36] [core]ClientConn switching balancer to "pick_first"
I0706 02:13:11.215171       1 component.go:36] [core]Channel switches to new LB policy "pick_first"
I0706 02:13:11.215317       1 component.go:36] [core]Subchannel Connectivity change to CONNECTING
I0706 02:13:11.215451       1 component.go:36] [core]Subchannel picks a new address "nfd-master:8080" to connect
I0706 02:13:11.215567       1 component.go:36] [core]Channel Connectivity change to CONNECTING
W0706 02:13:12.219934       1 component.go:41] [core]grpc: addrConn.createTransport failed to connect to {nfd-master:8080 nfd-master:8080 <nil> 0 <nil>}. Err: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:8080: connect: connection refused". Reconnecting...
I0706 02:13:12.219981       1 component.go:36] [core]Subchannel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:12.220056       1 component.go:36] [core]Channel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:13.220337       1 component.go:36] [core]Subchannel Connectivity change to CONNECTING
I0706 02:13:13.220438       1 component.go:36] [core]Subchannel picks a new address "nfd-master:8080" to connect
I0706 02:13:13.220516       1 component.go:36] [core]Channel Connectivity change to CONNECTING
W0706 02:13:14.223652       1 component.go:41] [core]grpc: addrConn.createTransport failed to connect to {nfd-master:8080 nfd-master:8080 <nil> 0 <nil>}. Err: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:8080: connect: connection refused". Reconnecting...
I0706 02:13:14.223694       1 component.go:36] [core]Subchannel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:14.223749       1 component.go:36] [core]Channel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:16.141036       1 component.go:36] [core]Subchannel Connectivity change to CONNECTING
I0706 02:13:16.141096       1 component.go:36] [core]Subchannel picks a new address "nfd-master:8080" to connect
I0706 02:13:16.141230       1 component.go:36] [core]Channel Connectivity change to CONNECTING
W0706 02:13:17.144054       1 component.go:41] [core]grpc: addrConn.createTransport failed to connect to {nfd-master:8080 nfd-master:8080 <nil> 0 <nil>}. Err: connection error: desc = "transport: Error while dialing dial tcp <IP_ADDRESS>:8080: connect: connection refused". Reconnecting...
I0706 02:13:17.144101       1 component.go:36] [core]Subchannel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:17.144156       1 component.go:36] [core]Channel Connectivity change to TRANSIENT_FAILURE
I0706 02:13:20.157894       1 component.go:36] [core]Subchannel Connectivity change to CONNECTING
I0706 02:13:20.157957       1 component.go:36] [core]Subchannel picks a new address "nfd-master:8080" to connect
I0706 02:13:20.158158       1 component.go:36] [core]Channel Connectivity change to CONNECTING
I0706 02:13:21.163224       1 component.go:36] [core]Subchannel Connectivity change to READY
I0706 02:13:21.163282       1 component.go:36] [core]Channel Connectivity change to READY
E0706 02:13:21.182977       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:13:21.183117       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:13:21.183245       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:13:21.258538       1 nfd-worker.go:472] starting feature discovery...
I0706 02:13:21.259297       1 nfd-worker.go:484] feature discovery completed
I0706 02:13:21.259320       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:14:21.322843       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:14:21.323017       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:14:21.323174       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:14:21.398657       1 nfd-worker.go:472] starting feature discovery...
I0706 02:14:21.399335       1 nfd-worker.go:484] feature discovery completed
I0706 02:14:21.399375       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:15:21.443092       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:15:21.443307       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:15:21.443525       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:15:21.511411       1 nfd-worker.go:472] starting feature discovery...
I0706 02:15:21.511724       1 nfd-worker.go:484] feature discovery completed
I0706 02:15:21.511736       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:16:21.552463       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:16:21.552585       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:16:21.552702       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:16:21.619316       1 nfd-worker.go:472] starting feature discovery...
I0706 02:16:21.619634       1 nfd-worker.go:484] feature discovery completed
I0706 02:16:21.619647       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:17:21.669180       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:17:21.669361       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:17:21.669508       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:17:21.737414       1 nfd-worker.go:472] starting feature discovery...
I0706 02:17:21.738601       1 nfd-worker.go:484] feature discovery completed
I0706 02:17:21.738638       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:18:21.782309       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:18:21.782542       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:18:21.782741       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:18:21.856019       1 nfd-worker.go:472] starting feature discovery...
I0706 02:18:21.856357       1 nfd-worker.go:484] feature discovery completed
I0706 02:18:21.856372       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:19:21.895301       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:19:21.895817       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:19:21.895933       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:19:21.963640       1 nfd-worker.go:472] starting feature discovery...
I0706 02:19:21.963893       1 nfd-worker.go:484] feature discovery completed
I0706 02:19:21.963906       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:20:22.006854       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:20:22.006973       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:20:22.007072       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:20:22.081057       1 nfd-worker.go:472] starting feature discovery...
I0706 02:20:22.081383       1 nfd-worker.go:484] feature discovery completed
I0706 02:20:22.081397       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:21:22.130792       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:21:22.131019       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:21:22.131219       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:21:22.194025       1 nfd-worker.go:472] starting feature discovery...
I0706 02:21:22.194342       1 nfd-worker.go:484] feature discovery completed
I0706 02:21:22.194374       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:22:22.243773       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:22:22.243994       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:22:22.244192       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:22:22.305896       1 nfd-worker.go:472] starting feature discovery...
I0706 02:22:22.306170       1 nfd-worker.go:484] feature discovery completed
I0706 02:22:22.306183       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:23:22.361385       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:23:22.361611       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:23:22.361808       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:23:22.430638       1 nfd-worker.go:472] starting feature discovery...
I0706 02:23:22.431378       1 nfd-worker.go:484] feature discovery completed
I0706 02:23:22.431403       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:24:22.478980       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:24:22.479102       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:24:22.479202       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:24:22.556206       1 nfd-worker.go:472] starting feature discovery...
I0706 02:24:22.556538       1 nfd-worker.go:484] feature discovery completed
I0706 02:24:22.556553       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:25:22.599371       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:25:22.599496       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:25:22.599620       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:25:22.669471       1 nfd-worker.go:472] starting feature discovery...
I0706 02:25:22.669724       1 nfd-worker.go:484] feature discovery completed
I0706 02:25:22.669736       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:26:22.716209       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:26:22.716331       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:26:22.716439       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:26:22.783646       1 nfd-worker.go:472] starting feature discovery...
I0706 02:26:22.784187       1 nfd-worker.go:484] feature discovery completed
I0706 02:26:22.784203       1 nfd-worker.go:565] sending labeling request to nfd-master
E0706 02:27:22.832694       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em1/speed: invalid argument
E0706 02:27:22.832923       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em2/speed: invalid argument
E0706 02:27:22.833120       1 network.go:145] failed to read net iface attribute speed: read /host-sys/class/net/em3/speed: invalid argument
I0706 02:27:22.899538       1 nfd-worker.go:472] starting feature discovery...
I0706 02:27:22.899851       1 nfd-worker.go:484] feature discovery completed
I0706 02:27:22.899863       1 nfd-worker.go:565] sending labeling request to nfd-master

We are running K8s 1.23.0 version and the FPGA node has IAS installed.
Cheers
Derrick

Hi Derrick,
Thank you for reporting this issue.
You can see current labelling rules for Arria10 here
Can you show lspci output for your devices please?
Here is how it looks on our system with two Arria10 cards:
> sudo lspci -vn |grep -iA2 09c4
3b:00.0 1200: 8086:09c4
	Subsystem: 8086:0000
	Flags: bus master, fast devsel, latency 0, IRQ 62, NUMA node 0
--
5e:00.0 1200: 8086:09c4
	Subsystem: 8086:0000
	Flags: bus master, fast devsel, latency 0, IRQ 70, NUMA node 0

Another guess is that you're not using dfl driver.
In any case if you can describe your setup in more details we'll be happy to update the rules.

yes, you're using 3rd party kernel module and that's the reason why that labelling rule didn't work.
Can you check if this one works for you:
    - name: "intel.fpga-arria10"
      labels:
        "intel.feature.node.kubernetes.io/fpga-arria10": "true"
      matchFeatures:
        - feature: pci.device
          matchExpressions:
            vendor: {op: In, value: ["8086"]}
            device: {op: In, value: ["09c4"]}
            class: {op: In, value: ["1200"]}
      matchAny:
        - feature: kernel.loadedmodule
            matchExpressions:
              dfl_pci: {op: Exists}
        - feature: kernel.loadedmodule
            matchExpressions:
              intel_fpga_pci: {op:Exists}

Thanks for providing the insight! I gave your code a quick touchup and it works!
    - name: "intel.fpga-arria10"
      labels:
        "intel.feature.node.kubernetes.io/fpga-arria10": "true"
      matchFeatures:
        - feature: pci.device
          matchExpressions:
            vendor: {op: In, value: ["8086"]}
            device: {op: In, value: ["09c4"]}
            class: {op: In, value: ["1200"]}
      matchAny:
        - matchFeatures:
            - feature: kernel.loadedmodule
              matchExpressions:
                dfl_pci: {op: Exists}
        - matchFeatures:
            - feature: kernel.loadedmodule
              matchExpressions:
                intel_fpga_pci: {op: Exists}

I also want to mention that this documentation states both DFL and OPAE drivers are supported by the plugin:

https://intel.github.io/intel-device-plugins-for-kubernetes/cmd/fpga_plugin/README.html?highlight=dfl+driver

The current code seems to be supporting DFL only? But your quick fix allows me to progress to the next step! Thanks!

@klin938 thank you for confirming that updated rules work for you. I'll submit a PR today.
The current code should support both drivers.


How can a Rails engine be adapted to support both Propshaft and Sprockets based installations

With the release of Rails 8 and new apps having Propshaft instead of Sprockets, How are Rails engines being made to work for both styles? For example many gems contains a Web UI which is a Rails engine.
So far whats been suggested is using /public for assets and using CDN script/link tags for external assets. This is mostly an approach I have already been using.
Im hoping there should be a better story than this.
So far this is the only sprockets configuration that may be relevant to this conversation. Just including it here for completeness.
  initializer "foo_app.assets.precompile" do |app|
    app.config.assets.precompile << "foo_app_manifest.js" ### manifest file required
    app.config.assets.precompile << "foo_app/favicon.ico"

    ### Automatically precompile assets in specified folders
    ["app/assets/images/"].each do |folder|
      dir = app.root.join(folder)

      if Dir.exist?(dir)
        Dir.glob(File.join(dir, "**/*")).each do |f|
          asset_name = f.to_s
            .split(folder).last # Remove fullpath
            .sub(/^\/*/, '') ### Remove leading '/'

          app.config.assets.precompile << asset_name
        end
      end
    end
  end

Also posted this question to reddit: https://www.reddit.com/r/rails/comments/1gtin65/how_can_a_rails_engine_be_adapted_to_support_both/

Propshaft doesn't use config.assets.precompile at all, it adds asset folders from gems to the load path and assumes the folder structure conventions are followed.
If you're not using vanilla CSS and Javascript, and you need to precompile from Sass or some other language supported in Sprockets, some options you have for now are either:

Precompile assets into app/assets/builds for the gem as part of the workflow to publish the gem - propshaft will be able to use these assets
Add a Gem.post_install hook that runs the precompilation for the gem

Option 1 should work fine for gems installed from Rubygems, but I assume you don't want to push your build artifacts to Github, so any gems installed with git will not have the prebuilt assets.
Option 2 should work for both scenarios, but will probably require the consumer to install more runtime dependencies.
builds folders should be given higher priority in the load path, so any asset that is precompiled and named the same in two locations will be served as the builds variant.
Now that Propshaft is stable, and Rails 8 is release, I can write some documentation for gem authors that wants to add support for Propshaft.