Fix bool logic in portfolio_history config.enabled

resolves #6
Are you a current Fivetran customer?
Jeremy Cohen @ dbt Labs
What change(s) does this PR introduce?
Fixes a faulty config!
Did you update the CHANGELOG?

[ ] Yes — not yet

Does this PR introduce a breaking change?

[ ] Yes (please provide breaking change details below.)
[x] No  (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[ ] Yes

Is this PR in response to a previously created Bug or Feature Request

[x] Yes — #6
[ ] No

How did you test the PR changes?

[ ] Buildkite
[x] Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

[ ] BigQuery
[ ] Redshift
[x] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Provide an emoji that best describes your current mood

:dancer:
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Thanks so much for being so quick and opening this PR @jtcohen6! We actually caught this earlier in the morning and opened PR #5 to address the issue. We should be releasing it shortly 😄

@fivetran-joemarkiewicz My bad for not thinking to look at the one open PR!


[SPARK-47630][BUILD] Upgrade zstd-jni to 1.5.6-1

What changes were proposed in this pull request?
This PR aims to upgrade zstd-jni to 1.5.6-1.
Why are the changes needed?
This release has the following memory-leak bug fix.

https://github.com/luben/zstd-jni/releases/tag/v1.5.6-1

https://github.com/luben/zstd-jni/pull/303

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Thank you, @yaooqinn !

Merged to master for Apache Spark 4.0.0.


Feature Request - Make-Specific Endpoints

Relevant documentaiton
As an example, here are the Tesla specific endpoints, that aren't yet supported by the rust SDK.
https://smartcar.com/docs/api#tesla-specific-endpoints

Make Specific Endpoints are supported via the general purpose vehicle request method


Two unique IDs convert back to the same integer

Hi there -- I've found a case were two unique ids decode to the same integer.
As far as I can tell this won't cause any problems for me, I'd just like to understand why this is possible and if it's expected.  I've tested the opposite direction (running through a integers to a very high value to ensure there are no conflicts when encoding)
Unfortunately, not sure how to reproduce it here without posting what the integers convert to on my side and the salt I use.

Can you please check whether this also happens with the JS implementation.
To be completely honest, I haven’t looked at the code in quite some time, and don’t have any idea what could be wrong from the top of my head.


interval value for last point sampled on ray?

Hi,
What do you set the interval value to for the last sampled point on each ray. Using a large term (1e10) as a substitute for infinity make the loss term very large.

I left them constant (1/num_of_pts_on_a_ray) in my training.
BTW, you should use the normalized distance instead of the Euclidean distance (see Eq.11 in mip-nerf 360 paper).

I left them constant (1/num_of_pts_on_a_ray) in my training.
BTW, you should use the normalized distance instead of the Euclidean distance (see Eq.11 in mip-nerf 360 paper).

could I just leave it as zero? many thxs


Version number

Hi,
I just packaged web.go as an unofficial Arch Linux package.
However, I'm having difficulties finding the version number for web.go. Is it 1.0? 0.1? 3.141592653589793? :)
Could you please include a version number in the readme file?
The version number for the branch/tag of web.go that is selected at install time by "go get" would be great.
Thank you.

I believe subsequent versions of Go are going to support some kind of package management system. I'll defer this until that happens :)


pod add should return the deployment id

@kensipe there are some unit tests that will fail due to your changes. Please make sure to update them to test the new behavior.
Also, the CI builds don't exercise the pod integration tests by default, but we have a non-triggered build specifically for pods, which I just started manually: https://teamcity.mesosphere.io/viewLog.html?buildId=443018&buildTypeId=DcosIo_DcosCli_CliAgainstLatestDcOsWithPods&guest=1

@cruhland thanks!  looking at it now.

@tamarrow @kensipe for consistency, should we output Created deployment ... instead of Deployment-id: ...? A number of marathon commands already use that wording, e.g. https://github.com/dcos/dcos-cli/blob/master/cli/dcoscli/marathon/main.py#L664

good question regarding deployment id...

I think I like the Deployment-id: over Created deployment.     doesn't the : make the output more parsable?    I strongly agree with consistency.    I can change to Created deployment if that is the consensus.

the fail test isn't related... :(

@kensipe those tests are flaky, so I've restarted the builds. We've been working on improving them but haven't had time to get to all of them yet.

@kensipe lets stick with Created deployment. Consistency is always the least confusing.

2 is quorum :)   SGTM   updated and ready to go assuming tests pass.

thanks @kensipe. These integration tests needs to be updated with the new stdout: https://github.com/dcos/dcos-cli/blob/master/cli/tests/integrations/test_marathon_pod.py#L34
and
https://github.com/dcos/dcos-cli/blob/master/cli/tests/integrations/test_marathon_pod.py#L47

@kensipe Marathon updated their endpoint name, so the pods tests will fail until this gets merged: https://github.com/dcos/dcos-cli/pull/809

@cruhland ah... that explains it.  thanks!!


Added version support to Razor parser

#1678
@rynowak

Added Version property to RazorParserOptions
Added an internal RazorParserFeatureContext that contains a flag for all features we want to enable/disable in the parser
Reason for having a centralized location is so we don't have to look at the version every time we want to decide whether to light-up a feature
I'll send a separate PR that will use AllowMinimizedBooleanTagHelperAttributes to enable/disable that feature.

🆙 📅

🆙 📅


chronograf 0.2.0

New recipe here! It's a new version of a product we had previously released without an official OSX build.
Let me know if you've got any questions!

This seems to just be failing CI on El Capitan with no messages. Any chance we could still get this merged?

The console output for El Capitan does have one error line:

Error: No available formula for formulae require at least a URL

A cursory Google search for that error didn't turn up much.

Probably a bot hiccup; I re-queued it.

@dunn thanks! looks like it passed this time - anything we can do to help this get merged?

:+1: Please merge :)

Looks like tests all pass. Any chance this can be merged soon?

@dunn good catch - fixed!

Merged in a98d9fcb6bde0bd44d278341d3cb8ff52d3e2863, thanks!


Removing -uri- format from website property in account Organization

Please link to the issue #…

Reviewed and looks good to me.


Typst Reference Formatting

Hi quick issue (I got the typst document to render) but it looks like the references are missing hanging indents

Nevermind. Its working now. Might have been my computer


Remove / deprecate ->icon, ->class feature

Disclaimer: I understant I open theme that can be controversal.

I suggest:

Deprecate this feature,
and remove it from doc, replace it with proper method calls (setIcon, setClass, addXyz)

Motivation:

It's magic (which causes everything I mention below),
does not provide typehint in IDEs,
cannot be checked by static syntax analyzers (code-sniffers),
leads to mistakes and typos.

Well, just don't use it? Its not mandatory to do it like this.

Magic is not good for new users, makes bad habits.
Copy & paste from docs is harder (IDE yaps about it, refactoring is needed).

I agree.
What do you suggest me to do with existing projects? I do not want to release v3 two days after v2 because of just one BC break.
Options:
1, Create methods ::class(), ::icon, etc and throw @deprecated exception within them
2, Right, release v3
Any other idea?

I suggest:

remove it from documentation and replace it with non-magic method there. This will fix most of problems. Nobody know, nobody uses. :)
add it to v3 release, which can be releases anytime in the future (with some other BC breaks and feature, etc...)

Right.


Sharing environments

How can I share an enviroment with a team/other users?

As of now, you need to export the environment as JSON / GitHub gist and share them with your team. Collaborative environment sharing in our roadmap. Stay tuned for product updates.


fix: Add loggercheck linter

Why the changes were made
Fixes #85
How to test the changes made
Check CI logs, linters check should pass with new linter.

/lgtm


Feature Requests: Reactive StreamBridge

Hi,
The upcoming Spring Cloud Stream 4.0.0 contains the new spring-cloud-stream-binder-kafka-reactive binder which works great for consuming messages - personally this is one of the flag ship features :-)
The issue is sending messages via StreamBridge as StreamBridge is not reactive: public boolean send(String bindingName, Object data) .  This means, when combined with spring cloud function AWS, the message is never sent:
public class MessageSenderFunction implements Function<Flux<Map<String, String>>, Flux<String>> {

  private StreamBridge streamBridge;

  @Override
  public Flux<String> apply(Flux<Map<String, String>> flux) {
    return flux.flatMap(v -> {
      Object kafkaEvent = ...
      if (streamBridge.send("test-out-0", kafkaEvent)) { // message never sent!!
        return Mono.just("OK");
      } else {
        return Mono.error(new RuntimeException("event publishing failed"));
      }
    });
  }
}

There are two current ways around this:

Don't use the reactive kafka binder

Add a delay when using StreamBridge

      if (streamBridge.send("test-out-0", kafkaEvent)) {
        log.info("Message sent to binding = {}", kafkaEvent);
        return Mono.just("OK").delayElement(Duration.ofSeconds(1));
      }

Both are poor options.
Would it be possible to add a reactive StreamBridge or the ability to send messages where polling (i.e. @PollableBean) is not an option?   Reactor kafka has a KafkaSender class which has implemented this as:
<T> Flux<SenderResult<T>> send(Publisher<? extends SenderRecord<K, V, T>> records);
Could we have something similar to the above or a way to get a handle on the above in Spring Cloud Streams?
Thanks

Am I right in assuming we can use the "sendResult" message header for this purpose?
I.e. do something like this (very basic example)?
  @Autowired
  private StreamBridge streamBridge;

  public Mono<Void> reactiveSend() {
    return Mono
        .just(new AtomicReference<Mono<RecordMetadata>>())
        .doOnNext(handle -> {
          var message = MessageBuilder.withPayload("Hello ")
              .setHeaderIfAbsent("sendResult", handle)
              .build();

          streamBridge.send("test-out-0", message);
        })
        .flatMap(AtomicReference::get)
        .then();
  }

Looking inside ReactorKafkaBinder, this does seem to do what we want...
		@Override
		protected void handleMessageInternal(Message<?> message) {
			Object sendResultHeader = message.getHeaders().get("sendResult");
			Sinks.One<RecordMetadata> sink = Sinks.one();
			if (sendResultHeader instanceof AtomicReference result) {
				result.set(sink.asMono());
			}
			if (this.sender != null) {
				UUID uuid = UUID.randomUUID();
				@SuppressWarnings("unchecked")
				SenderRecord<Object, Object, UUID> sr = SenderRecord.create(
						(ProducerRecord<Object, Object>) converter.fromMessage(message, topic), uuid);
				Flux<SenderResult<UUID>> result = sender.send(Flux.just(sr));
				result.subscribe(res -> sink.emitValue(res.recordMetadata(), null));
			}
			else {
				sink.emitError(new IllegalStateException("Handler is not running"), null);
			}
		}


The 'Validator#setup' instance method is deprecated and will be removed on Rails 4.2...

Running Rails 4.1.7, Mongoid 4.0.0, and the latest mongoid-encrypted-fields.
I get:
DEPRECATION WARNING: The `Validator#setup` instance method is deprecated and will be removed on Rails 4.2. Do your setup in the constructor instead:

class MyValidator < ActiveModel::Validator
  def initialize(options={})
    super
    options[:class].send :attr_accessor, :custom_attribute
  end
end
. (called from initialize at /Users/jean/.rvm/gems/ruby-2.0.0-p247/bundler/gems/mongoid-encrypted-fields-87ad45cc36b0/lib/mongoid-encrypted-fields/mongoid4/validatable/uniqueness.rb:15)

It's not obvious to me how to refactor the setup method to fit into what Rails is suggesting, because I'm worried about the klass parameter being passed into the method.

thanks!

@jerryclinesmith, thanks for the changes.  I'm still getting the deprecation warning because the setup method still exists: https://github.com/KoanHealth/mongoid-encrypted-fields/blob/master/lib/mongoid-encrypted-fields/mongoid4/validatable/uniqueness.rb#L19
Can I remove it, now that klass is being set in the initialize method?


PodBuilder can now set pod affinity

Description
Review Checklist

[x] Code contains useful comments
[x] (Integration-)Test cases added (or not applicable)
[x] Documentation added (or not applicable)
[x] Changelog updated (or not applicable)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for your contribution! I've just kicked off a CI run.

The changes look good to me, thanks! I'd be happy to merge this once the CI errors are sorted out.

thanks! Please let me know if this looks good enough, it may get uglier down the line when anti-affinity is added

Hi @andlaz, unfortunately there are still some clippy & rustfmt issues.
Would you mind updating the PR?

yes, thanks, let me have a quick look

Thank you, there's only one rustfmt issue left :)
Almost there!

Thank you @andlaz, ill go ahead and merge

bors merge


parse error when running ggt node info | jq

following the docs, getting the error:
parse error: Expected value before ',' at line 1, column 1774

when running ggt node info | jq.
I have jq installed -- worth noting that when I ran this, the subnet creation failed (related to #3  )

If this happens, try running the command with the | jq pipe to see what the underlying problem is.


go back to tag

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Header as a component has no spacing

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
No margin on iOS
Expected behavior:
Proper margin on iOS
Steps to reproduce:
Create a header component and use it on your app
When you create a header component and then use it in your app, there is no margin/padding on iOS so it looks close to the top of the page.
I had
<ion-header>
  <header></header>
</ion-header>

in the page and you can insert the header from the documentation inside the header component:
<ion-header>
  <ion-navbar>
    <ion-title>Page1</ion-title>
  </ion-navbar>

  <ion-toolbar>
    <ion-title>Subheader</ion-title>
  </ion-toolbar>
</ion-header>
```

Thanks, I can confirm this as well.
Seems to be related to how we set the padding here

Can you post in what version this bug will be fixed and if there is a release date?
Thanks

Hi again. I'm assuming there are no nightly build where this issue is solved right? I'm eager to have this fixed on iOS. Thanks

just updated ionic and the issue is still there:
Cordova CLI: 6.5.0
Ionic Framework Version: 2.1.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.1
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.9.2
Xcode version: Xcode 8.2.1 Build version 8C1002

Hi @ix-xerri.
Yes, we have not done any yet as this is a rather complicated issue.
It would require a lot of refactoring of the css to make sure it works for every single use case.
That being said, it works right now without using custom components for headers, which we think is ok.
This is something that is indeed on our radar, but cannot be done right away.
I will be locking this to avoid any unnecessary distractions.


Cohesive elements at grain boundreies

Hi Kristoffer,
I trying to create cohesive elements at the grain boundaries. As a start point I am currently using the polycrystal generated using the Neper. Till now I don't have any success. Here I am attaching the code I am using for generating the cohesive elements (files in text file format
n10-id1.txt
n10-id1_coh.txt
). Could you please let me know where I am doing mistake.
Thanks in advance.
`from phon.io_tools.read.read_from_abaqus_inp import read_from_abaqus_inp
from phon.io_tools.write.export_to_abaqus import export_to_abaqus
from phon.mesh_tools.create_cohesive_elements import create_cohesive_elements
inputfile = "n10-id1.inp"
mesh = read_from_abaqus_inp(inputfile, verbose=0)
create_cohesive_elements(mesh, 3)
export_to_abaqus("n10-id1_coh.inp", mesh, write_2d_elements=False)`

It is your Neper inp file problem.
Your inp file did not include FACEx.

这是你的 Neper inp 文件的问题。 你的 inp 文件没有包含 FACEx。
Hello, what should I do to include FACEx in the .inp file?


IXR6 , no routes on Show BGP

Hi @mohamadrahhal
this is not a containerlab issue, for SR Linux related questions you can ask stuff in our Discord - https://discord.gg/tZvgjQ6PZf
The reason you have this issue is probably because you run IXR6 with an older SW version (show version to check). The afi-safi container was introduced in 23.3 if I remember correclty

hello , hellt thank you for your reply: this is what i get when i put show version , moreover i have asked on discord also.


Support Envoy "az" (availability zone)

Envoy supports an optional "az" field for zone.  Documented at https://lyft.github.io/envoy/docs/configuration/cluster_manager/sds_api.html
If pods run on nodes with label failure-domain.beta.kubernetes.io/zone that label should be propagated to the Envoy "az" field.
The change seems small but may "require a bunch of design stuff."

Need to plug this info into SDS and serve it up to Envoy

@liamawhite AZ information needs to be pulled from pod annotations in Kube and supplied via the tags.az field in Envoy SDS API.

@esnible @rshriram Just read through the various docs and cant seem to find an explicit answer to this question... This is at a node level so how is this information propagated up to the pod level. Does kube automatically add a label to each pod that says this pod is in region "az1"?

There should be some kube API to fetch pods in an AZ right? Or atleast the
pod to node association and the node to AZ association.
On Sat, Jul 8, 2017 at 5:14 AM Liam White<EMAIL_ADDRESS>wrote:

@esnible https://github.com/esnible @rshriram
https://github.com/rshriram Just read through the various docs and cant
seem to find an explicit answer to this question... This is at a node level
so how is this information propagated up to the pod level. Does kube
automatically add a label to each pod that says this pod is in region "az1"?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/pilot/issues/737#issuecomment-313844749, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd1leD9bGDdI0YjFU_VVi49jPCj9lks5sL0h3gaJpZM4NZXj8
.

--
~shriram

@liamawhite Each pod has an annotation like nodeName: minikube.  platform/kube/controller.go keeps a podCache.  My guess is that it will also need to keep a "nodeCache".  It will have to look up the nodeName in the nodeCache to find the pod's AZ.

This issue is solved. A further issue has been raised here, in order to make zone aware load balancing configurable. Some work needs to be done on the envoy side before it can be completed.


Don't print socket transport error in console

Description
Avoid forwarding stack error when testhost disconnects unexpectedly. This error steals developer focus from the other more important error, which is either the testhost error message, or simply "testhost crashed" without any additional info.
Related issue
Fix #4461
Kindly link any related issues. E.g. Fixes #xyz.

[x] I have ensured that there is a previously discussed and approved issue.

/azp run


Is there no JTAG module? Can we only load the programs into spi-flash to run them?

(1) There is no JTAG module as part of picorv32
(2) You can store your programs wherever you want. SPI flash is just one option. Many people just use block rams.


replace clickText with clickNestedText implementation

Replaces #409, after resolving various conflicts.

I've ran this against our 105 web-based tests and everything's fine.


PR: Release fixes

Fixes #46

This looks good to me but I don't understad why our tests are failing,


Fix CVP pipeline issues.

Signed-off-by: Petr "Stone" Hracek<EMAIL_ADDRESS>

[test]

@zmiklank Rebased and add more descriptive commits.

[test]


Soft deprecate file_path for SpikeGLXRecordingInterface and SpikeGLXNIDQInterface

As this is an important change, we are giving it  a year instead of our typical six months.
Should close #978

lgtm


chore: add default user/team/project/env

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1310  👈
#1309
#1308
#1307
#1306
#1305
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Enforce oneofs with client-side validation

What
For an example proto request message:
message SeekRequest {
  string subscription = 1;
  oneof target {
    google.protobuf.Timestamp time = 2;
    string snapshot = 3;
  }
}

We should enforce in our GAPIC client code that no more than one field in oneof target is allowed to be passed into a method.
Why
We currently allow the service to enforce this, but the quality of the error message returned by the service might vary across APIs. We can do a better, more consistent job of telling the user what they did wrong in our GAPIC client libs.
Some languages might have an even worse status quo. We think Python arbitrarily selects the last field in a oneof block that the user specified. This is undefined behavior that appears to work right now, but that we could "break" at some point post-GA. It would be better to tighten this up to be defined behavior.
Languages

[ ] NodeJS
[ ] PHP
[x] Python (#1069)
[ ] Ruby

Language leads: if this issue does not apply to you, then please remove the label and bullet point above for your language.

We don't put one of fields in parameter lists in Java currently.

ProtoBuf.js reports errors when both of oneof are specified. I don't think GAPIC layer should do something for Node.

Removed C#:

The protobuf message handles oneof appropriately (it only stores a single value, and remembers which field it's associated with, then serializes appropriately)
So long as we never create a flattening with more than one field from the oneof in, we'd never be generating anything that leads to a problem

My main concern is that the user either gets a helpful error message when they define more than one field in a oneof block, or that the GAPIC surface for a language makes this impossible.
It sounds like C# is the latter, is that correct @jskeet? @garrettjonesgoogle Is the same true for Java?
@jmuk Is the ProtoBuf.js error message is helpful enough for the user? If so, then I agree we don't need to do anything for Node.

Assuming the GAPIC config has been done separately, it is indeed the latter for C#, and I'd assume that's the case for Java too.

@jskeet Do you think you can resolve https://github.com/googleapis/toolkit/issues/1057 without introducing the possibility that multiple field in a oneof block can be defined by the user?

@bjwatson: I don't understand your comment, I'm afraid - but it's a somewhat separate issue to this one, so should probably be discussed there. Note that while we could avoid ever specifying any oneof-related fields in flattenings, that would be bad in terms of usability.

It's actually a concern on both issues, but I think it's easier to discuss in the context of this one. My understanding is that for the proto in my description above, you generate overloaded C# methods like this:
        public static void CreateAsync(String subscription, google.protobuf.Timestamp time) ...
        public static void CreateAsync(String subscription, String snapshot) ...

There's no risk here of the user specifying both time and snapshot. However, it's not clear to me what you would do if the proto defined both fields to be string. For example:
  oneof target {
    string time = 2;
    string snapshot = 3;
  }

In this case, you cannot overload CreateAsync() like this:
        public static void CreateAsync(String subscription, String time) ...
        public static void CreateAsync(String subscription, String snapshot) ...

One way to solve this is to combine them together, but that raises the problem addressed in this issue:
        public static void CreateAsync(String subscription, String time = null, String snapshot = null) ...

I was just wondering what you had in mind to deal with this?

We had previously considered creating a TargetOneof type, and make that the parameter. You'd then call it with something like:
client.CreateAsync(TargetOneof.FromTime(...));
client.CreateAsync(TargetOneof.FromSnapshot(...));

Then it's fine to add more fields to the oneof later - nothing needs to change.

I can confirm that Python silently ignores one of the arguments:
>>> pubsub_pb2.SeekRequest(subscription='foo', time=ts, snapshot='bar')
subscription: "foo"
time {
  seconds:<PHONE_NUMBER>
}

Okay, that's fair. ProtoBuf.js's error message is indeed not quite friendly: Error: Illegal value for Message.Field .google.cloud.speech.v1beta1.SyncRecognizeRequest.audio: .google.cloud.speech.v1beta1.RecognitionAudio (Error: Illegal value for Message.Field .google.cloud.speech.v1beta1.RecognitionAudio.content of type bytes: object (proto3 field without field presence cannot be null))
Another considerations might be the documentation comment -- Node doesn't say any oneof restriction.

@jskeet I see. You're wrapping the parameter to ensure that it's a unique type. That sounds great, and I have not concerns in this regard for C#.
@garrettjonesgoogle @pongad Can you confirm that you're doing the same for Java and Go, or are you doing something different for oneof?
@lukesneeringer Thanks for confirming. That's a good question about the cardinality. If we had a way of saying the entire oneof block is required in the GAPIC config, then it could have "one of and exactly one of" semantics. However, I don't think that's currently possible, so we have "zero or one of" semantics for all oneof blocks. Does this fit your understanding @geigerj and @garrettjonesgoogle?
@jmuk Gross! :) We have a separate issue for the documentation concerns.

@bjwatson re: cardinality, I agree with your assessment.

To be clear - we're not doing that yet. That's what our best thinking was back when we were looking at resource names. Implementing that is how we fix #1057.

@bjwatson for Java: If someone configures one-of parameters to be flattened, as things stand now, the client would be broken. We are intending on following the strategy that @jskeet mentioned, where a one-of type will be generated and used as the parameter type, so new one-of variants won't break anything.

I have a WIP branch here (just pending unit tests and more testing of pubsub).
Other language leads might want to wait until I get this tested and merged, so they can use methodConfig.getOneofs().

@jskeet @garrettjonesgoogle No worries. If you're implementing these one-of types, it sounds like you won't have this issue by time we go GA for the Logging client.

Thanks @lukesneeringer!

Python is merged.

Removed Go. Details below.
Go uses composite literal to initialize the request object. (Example not checked, but shouldn't too far off)
&SeekRequest{
  Subscription: "foo",
  Target: &SeekRequest_Snapshot{
    Snapshot: "bar",
  },
}

It is never possible to set the oneof multiple times the same way it is impossible to set any field to multiple values.

So, you get an exception if you do:
&SeekRequest_Snapshot{
  Snapshot: "bar",
  Time: timestamp,
}

@lukesneeringer That code doesn't compile, because SeekRequest_Snapshot type doesn't have a Time member. If you want to use a timestamp:
&SeekRequest_Time{
  Time: timestamp,
}

Go protobuf essentially created the oneof type for us, so we don't have to.

Got it.

Python GAPICs with this change are all released. Removing the Python label.

@alexander-fenster @geigerj @michaelbausor Is this still relevant to your languages?

I've just confirmed Ruby is in the same situation as Python was before the fix. That is, the proto runtime allows attempting to set multiple subfields of a oneof, and ignores all but the last. As such, I think Ruby should do the same thing as Python for validation.
2.2.6 :002 > Google::Protobuf::ListValue.new(values: [string_value: "abc", number_value: 2])
 => <Google::Protobuf::ListValue: values: [<Google::Protobuf::Value: null_value: :NULL_VALUE, number_value: 2.0, string_value: "", bool_value: false, struct_value: nil, list_value: nil>]>
2.2.6 :003 > Google::Protobuf::ListValue.new(values: [number_value: 2, string_value: "abc"])
 => <Google::Protobuf::ListValue: values: [<Google::Protobuf::Value: null_value: :NULL_VALUE, number_value: 0.0, string_value: "abc", bool_value: false, struct_value: nil, list_value: nil>]>

PHP is similar to Ruby, and should be fixed in the same way.

Implementing https://github.com/googleapis/gapic-generator/pull/2516 would solve this issue.

Obsolete.


How do I get sparse representation using dictionaries？

I got some dictionaries representation with onlinecdl.OnlineConvBPDNDictLearn, but now i do not know how to get sparse representation use the dictionaries representation which was learned.

Because the method is online, it doesn't store the coefficient maps for each training image. If you need the sparse representations you'll need to first learn the dictionary and then compute them using class sporco.admm.cbpdn.ConvBPDN or one of the other classes in module sporco.admm.cbpdn. If you don't specifically need to use the online CDL class, consider using one of the the batch CDL classes since they do allow you to access the coefficient maps computed during dictionary learning.

D : dictonary
S : image
lmbda = 0.2
d = cbpdn.ConvBPDN(D, S, lmbda)
x = d.solve()
so x is sparse representation?

Correct, except that you usually want S to be a highpass filtered version of the image rather than the image itself. See this example for details.


run shfmt and shellcheck on shell scripts

LGTM, provided green and that https://github.com/weaveworks/build-tools/pull/44 is included (github doesn't seem to show contents of git-tree updates)

@paulbellamy Are you still working on this or you gave up? :)

Sidetracked on other things.

@paulbellamy Still planning to work on this?

No


[BUILD] Disable parallelization in dist

Why are the changes needed?

Seems that maven-shade-plugin has some issue with parallelization, #1149 stuck w/o this change.
For refererence: https://github.com/apache/spark/pull/23061
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Thanks, merging to master


more relationships to consider  for phenotype filtering

from
I noticed that
"decreased punctate nuclear protein localization"
is not present when the "localization phenotype " filter is set. I think it might be missing a parent?
https://github.com/pombase/fypo/issues/2983
==
This is because the parent, mislocalized protein during vegetative growth, has the link output_of FYPO:0000443 ! abnormal protein localization during vegetative growth (not is_a or part_of). To get the behavior you want, Kim will have to have the filters use the output_of relation for FYPO, and probably also has_output.

I thought you did that already though?

I thought you did that already though?

The filter configuration wasn't using all the relations.  I've fixed it and simplified the config.  The localization phenotype filter works correctly for "decreased punctate nuclear protein localization" now.


update Complex Options ident block per #1150

per #1150 removing info past new T>... about ident as anyone looking to migrate from this point on should be on webpack >= v2.2.1 but leaving the tip just to clarify for any curious during migration.
thoughts @michael-ciniawsky & @skipjack?

Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.
Make sure your PR complies with the writer's guide.
Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
Remove these instructions from your PR as they are for your eyes only.

will rebase if necessary for silly extra commit, just lemme know. otherwise this closes #1154

@rouzbeh84 #1154 is a pull request that should close #1150, does this add something to #1154?

@rouzbeh84 closing but feel free to re-open if you want to tweak something added in #1154

nope sorry, didn't see there was a PR on it already. all good 👍


Added administration.config

Test coerage is a 99% as per the report. Please recheck and add the missing test

sir missing test cases added


Bug 1887745: Listing All Events with Chunking

Using chunking/pagination to LIST all events from the API Server.

/cc @adambkaplan, @gabemontero, @coreydaley

/retest

/hold
Without a re-list, can't the unidling controller miss a "NeedPods" event that it ultimately is looking for?
That said, watching events itself feels like an anti-pattern for a controller. We've come a long way in the past 5 years in terms of understanding and best practices...

That said, watching events itself feels like an anti-pattern for a controller. We've come a long way in the past 5 years in terms of understanding and best practices...

Note that getting rid of this controller or completely re-working its mechanics is beyond the scope of this bug fix.
Bump @mfojtik @deads2k

/test e2e-aws

/retest

@adambkaplan we had a successful CI run (unit, e2e-aws and e2e-aws-upgrade) using only 3 events per request. I'm moving it back to default limit.

@sttts, @adambkaplan Would you please consider latest commit using client-go Pager? It implements the chunking logic on List function.

/test unit

/hold
Maintaining the hold because it appears that there's an upstream bug that is preventing this PR from working correctly (events endpoint is not respecting resourceVersion=0, and is returning all events instead of the chunked list). Once that's been filed IMO we can merge this PR (it does zero harm).

Maintaining the hold because it appears that there's an upstream bug that is preventing this PR from working correctly (events endpoint is not respecting resourceVersion=0, and is returning all events instead of the chunked list). Once that's been filed IMO we can merge this PR (it does zero harm).

To clarify, the events endpoint is respecting the Storage Cache rules, as we can read on the comment (pointed out by @sttts). Sorry for the misinformation early on.
So, the purposed approach is to replace resourceVersion=0 with empty string, to make sure the controller will employ chunking on bootstrap and resync periods, at the expense of avoiding the storage cache.

/test unit

/retest

/retest

/test e2e-aws

/lgtm

/test e2e-aws-upgrade

/cherry-pick release-4.6


Game of life bundle

@Alexendoo When I tested on my own with a static server from npm I got MIME type errors even though Firefox's debugger showed the type to be "wasm". The problem was that the server appends  ; charset=utf-8 to Content-Type and that is not shown in Firefox so I thought I might add a warning here.

I don't think it needs such a prominent warning personally, it's certainly a bug that should be filed with http-server though

Oh, I was a bit unclear. I meant that people have to be careful because it is not obvious that charset=utf-8 will cause an error.

Yeah, it was just a concern about how much attention it draws, i.e. the quote (> ...). It shouldn't be relevant to most people since configuring MIME types on servers is usually handled separately from charset. If other people use http-server or other applications with bugs they might run into it, but that's more of a concern for http-server IMO.


Error with structured records with timestamps from standalone plugin

Bug description
In a pipeline with a source using a standalone connector and with records with timestamp fields, an error occurs and causes the pipeline to stop. Here's what the logs says:
2023-02-08T11:07:30+00:00 ERR node stopped error="node pipeline1:source1 stopped with error: source stream was stopped unexpectedly: error reading from source: read stream error: error converting payload: error converting after: proto: invalid type: time.Time" component=pipeline.Service node_id=pipeline1:source1 stack=[{"file":"/home/haris/projects/conduitio/conduit/pkg/pipeline/lifecycle.go","func":"github.com/conduitio/conduit/pkg/pipeline.(*Service).runPipeline.func1","line":515},{"file":"/home/haris/projects/conduitio/conduit/pkg/pipeline/stream/source.go","func":"github.com/conduitio/conduit/pkg/pipeline/stream.(*SourceNode).Run","line":124},{"file":"/home/haris/projects/conduitio/conduit/pkg/pipeline/stream/source.go","func":"github.com/conduitio/conduit/pkg/pipeline/stream.(*SourceNode).Run.func2","line":100},{"file":"/home/haris/projects/conduitio/conduit/pkg/plugin/standalone/v1/client.go","func":"github.com/conduitio/conduit/pkg/plugin/standalone/v1.unwrapGRPCError","line":160}]

This does not happen with built-in connectors. This has originally been found here.
Steps to reproduce

Build the generator plugin
Copy conduit-connector-generator into Conduit's connectors directory (./connectors by default)
Start Conduit with the following pipeline:

---
version: 1.0
pipelines:
  pipeline1:
    status: running
    name: pipeline1
    description: 'Standalone generator source, file destination'
    connectors:
      source1:
        type: source
        plugin: standalone:generator
        name: source1
        settings:
          recordCount: "-1"
          readTime: "1s"
          format.options: "testField:time"
          format.type: "structured"
      destination1:
        type: destination
        plugin: "builtin:file"
        name: destination1
        settings:
          path: /tmp/file-destination.txt

Expected results:
Pipeline starts successfully. Records are generated and written to the file destination.
Actual results:
Pipeline fails with described error.
Version
{"version":"v0.6.0-nightly.20230207-4-g69f4265", "os":"linux", "arch":"amd64"}

Issue is being discussed here.


Fix discovery.yml env var names

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/815
Originally created by @iroussos on 2019-07-18 14:18:46

The environment variable names for some of the entries in discovery.yml are not set correctly for some of the Taps and Targets supported in Meltano.
That results in at least tap-google-analytics and tap-csv not working properly when the parameters are set using the .env.
This bug also breaks some of our tutorials and the documentation we provide for how to use those Taps/Targets
Update discovery.yml and set the proper env variable names when they can not be inferred properly using the namespace and the settings' name.

View 3 previous comments from the original issue on GitLab


RD2: Fixed length Validation

Critical Changes
Changes
Enhanced Recurring Donation Changes

Add support and validations for Fixed Length Recurring Donations
Automatically close a Fixed Length RD when the Number of Paid Installments reaches the Number of Planned Installments

Issues Closed
Community Ideas Delivered
New Metadata
Custom Labels:

RD2_NumberInstallmentsRequiredWhenFixed
RD2_NumberInstallmentsNotAllowedWhenOpen
RD2_NumberPlannedInstallmentsCannotBeLessThanPaid

Deleted Metadata

Changes made @sam-knox

**lurch: attach W-038499

**lurch: attach W-038718

Tracking W-038499

**lurch: attach W-038718

Tracking W-038718

@RadSFDeveloper All code changes made. Ready for rereview.

@RadSFDeveloper Thanks again for the great code review. Changes made.

QE testing is complete for this PR and corresponding WI.  Tests have passed.
For further information, see:
https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000001HqTqQAK/view
https://foundation.lightning.force.com/lightning/r/agf__ADM_Work__c/a2x1E000001HquNQAS/view
https://salesforce.quip.com/zXELAaEnIuOj
The error that was observed in the last build has been posted within the RelEngSupport chat room for further investigation.
Merging PR and will set corresponding WIs to Closed once post-merge builds complete and are successful.


Extension Table 5075 – Logged Segment

Compare requirements Table 5065 …

Hi @KaiSwitalla,
We all want to spend less time on navigating through multiple requests searching for actual content.
You could help us if you would:

put all required information into each request, not just mention another one;
If you mention another request, you can put a direct link into text;
add the label name as a prefix to your request name. So this one could be "[event-request] Table 5075 – Logged Segment"

Thank you.

No reply, closing

Hello all,
here is the Link to my post mentioned
https://github.com/microsoft/ALAppExtensions/issues/2804
The "event request" label is allready added.
The prefix is added to the name.

Hello,
based on my phone call with jared hall last week, here is a better definition for this function. I also added an description of the event(s) needed.
Additionally i developed the events by my own. Take a look at the C/AL  object i'va added.
Here you can see the exact publishers, parameters, function name etc.
My Code is documented like:
// A/ Event Request
OnBeforeSomething...
// E/ Event Request
Requested Event in CU 5052 - Function "ProcessDeliverySorter"

OnBeforeToggleCanceledCheckmark(Rec,Handled);

Tab 5075 Logged Segment.txt


makeCitation with citationsPre and citationsPost arguments in v.3

Citations in document context used to be created by
List<Citation> makeCitation(CSLCitation citation, List<CitationIDIndexPair> citationsPre, List<CitationIDIndexPair> citationsPost)
Will this be included in v.3 or am I misunderstanding something essential about how it now works?
Thanks and all best,
S.

Are you talking about the makeCitation method itself or only about the variant that accepts citationPre and citationPost? There will be a makeCitation method in v3, but I have to admit that I didn't fully understand the purpose of citationPre and citationPost and don't know how to correctly implement them in the new pure Java processor. That's the reason why I deprecated these parameters for the time being.
I would be very happy if you could send me an example where these parameters are used, so I can understand them and correctly implement them. Thanks!

I'm talking about the variant with citationPre and citationPost.
These are indispensable for correctly formatting the references in the context of a document. E.g., some styles (I guess mainly in the Humanities) use backward references such as 'op. cit.' and therefore each reference needs to know which references came before (and often in which footnote, information the software might have to supply). I think this is done in CSL (mainly?) with the position attribute within the clauses in a choose element. That' also where near-note-distance comes into play.
Does this help?
Here's how CSL developers noticed this would be required: https://discourse.citationstyles.org/t/op-cit/456


Ensure openshift-cluster-csi-drivers exists

This pull request includes two changes and apply to preview mode.

For some configurations (new version of CRC), the  openshift-cluster-csi-drivers namespace is missing, due to the Storage capability not being enabled.  This pull request enables the storage capability which creates the namespace.  The namespace is used by the pipelines service as it installs a csi driver.
On CRC/WSL there are issues reading from /dev/stdin  for the patch-file due to windows/wsl interactions so this change updates the install script to workaround the issue via an intermediate temp file for the patch-file parameter.

Shared secrets which were using CSI driver were removed in #1836, closing this PR since it should not be needed anymore.


Send 500 on Service Worker middleware error

Resolves fusionjs/fusionjs#261
Previously we just logged the error.
I spent too long trying to write a test for this but it's actually really hard to get it to fail without editing non-test code.

reverted


Have an error while trying to send a property with a space character inside

In iOS SDK when I try to send a custom user property with a space character inside like "Push Enabled" I get an error: WootricSDK [Error]: (update end user): Error Domain=NSURLErrorDomain Code=-1002 “unsupported URL” UserInfo={NSLocalizedDescription=unsupported URL, NSUnderlyingError=0x604000444ef0 {Error Domain=kCFErrorDomainCFNetwork Code=-1002 “(null)“}}
as you don't encode this space it in WTRPropertiesParser, but in Android everything works right ...

Same for this issue! We will start working on this and update the SDK next week.

This is fixed in latest version. I verified in 0.21.1 and it working with space character in custom end user property.


TSV-918 - GA events

I think the general strategy is to ignore the error when sending a GA event fails. With the current implementation it makes the personal details validation to fail.


Guid queries on table returns all rows without value

Which service(blob, file, queue, table) does this issue concern?
Table
Which version of the Azurite was used?
3.25, 3.25.1 or 3.26. No problem with Azurite 3.24 or lower
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
DockerHub and npm
What's the Node.js version?
14.21.3
What problem was encountered?
Doing a query with a specified guid returns all rows with the specified guid, but also all rows where there is no value in the column.
On Table storage and on Azurite < 3.25, only the rows with the specified guid were returned.
Steps to reproduce the issue?
Create a table. Add some rows only with a partition key and row key. Do a query on any empty column with any guid like this: AnyColumn eq guid'43a29cc9-cc32-4f6c-a40b-1ada7f4bc0b0'. You receive all rows of the table.
If possible, please provide the debug log using the -d parameter, replacing <pathtodebuglog> with an appropriate path for your OS, or review the instructions for docker containers:
-d "<pathtodebuglog>"

Please be sure to remove any PII or sensitive information before sharing!
The debug log will log raw request headers and bodies, so that we can replay these against Azurite using REST and create tests to validate resolution.
Have you found a mitigation/solution?
Yes, using Azurite 3.24
Edit: I Fixed an error with Azurite version. The issue appeared with Azurite 3.25, not Azurite 3.25.1

@notheotherben
I can repro this issue.
It looks the issue related with the recent table query PR from you.
The problem looks in function compare(): https://github.com/Azure/Azurite/blob/fa485cd10f6c4f407be915cc16810d6e52c015bb/src/table/persistence/QueryInterpreter/QueryNodes/GuidNode.ts#L25
When "otherValue" is undefined, "thisValue < otherValue" and "thisValue > otherValue" both are not true, so finally 0 will be returned which means "thisValue" equals to "otherValue", which is also not correct.
However, when "otherValue" is undefined, it looks return -1, 0, 1 in function compare() are all wrong (since all comparison should fail in this case, include eq, gt, lt, ge, le, ne). So not sure how to fix this issue, looks any return value from the function compare() is not correct.
We might should do some null check in function evaluate()  before call function compare(). But this fix will impact all kinds of value node, I am little worry about the regression risk.
@notheotherben
Would you please help to look at this issue and fix it?
Feel free to let me know if any assistance from us needed.

Thank you @FranceyD and @blueww for reporting and investigating the cause of this, I've made the relevant changes to the compare() implementation in #2173 and these should be localized to the GUID implementation (and DateTime, which follows the same pattern) to ensure we avoid the risks associated with changes to evaluate(). I've expanded the test suite both to reproduce this issue (prior to the patch) and to confirm that the changes do not introduce any other problems based on the current test suite's coverage.

@notheotherben
Thanks for the quick fix!
The fix PR generally looks good to me. Just a suggestion for test case raised.


Filtering TASK ... WHERE ... completion.striptime < date("2022-04-01") is always true

What happened?
I am trying to filter tasks completed in a time range.  The < test always returns true, so all completed tasks are showing.
I can't find anything in the documentation for how to filter. I see some tests in the source code for it.
Test query below filter for tasks completed before April 2022.

Here is a task completed in May:
- [x] rugen ✅ 2022-05-09
I've also tried using dataview completed annotation: - [x] rugen ✅ 2022-05-09 [completed::2022-05-09]
I've tried completion.day instead of completion.striptime
Filtering for tasks completed AFTER has the same behavior:
TASK
WHERE completed
  AND completion != null
   AND completion.day >= date("2022-07-01")

shows all completed tasks
TASK
WHERE completed
  AND completion != null
   AND completion.striptime >= date("2022-07-01")

returns no results
If this isn't a bug then I think https://blacksmithgu.github.io/obsidian-dataview/queries/query-types/#task-queries could show the correct way to do this.
Thank you for dataview and all of your hard work!
DQL
TASK
WHERE completed
  AND completion != null

  AND completion.striptime < date("2022-04-01")

JS
No response
Dataview Version
0.5.47
Obsidian Version
1.1.9
OS
MacOS

Using dataviewjs  works correctly:
let start = dv.date("2022-05-01")
let end = dv.date("2022-06-01");
dv.taskList(dv.pages().file.tasks .where(t => {
  const ok = t.completed && t.completion && t.completion >= start && t.completion < end;
  if(ok) console.log(t)
  return ok;
}))
``

Hello,
What exactly should completion.striptime evaluate to? There is no striptime attribute on date objects. completion.striptime shoudl therefore evaluate to null in my understanding, and null < somedate is true.
If you want to use the function striptime you need to use it like specified in the documentation, meaning striptime(completion). Does that fix it for you?

Ah, that's my mixup!
I've found it tricky from the documentation to figure out what fields and functions there are and what their types are.
Generally I'm finding javascript easier to work with because I can use console.log to inspect what the object is.
"completion" isn't mentioned here: https://blacksmithgu.github.io/obsidian-dataview/queries/query-types/#task-queries I only found it in an example somewhere. I guessed it was a Luxon.js date, but for some reason I copied .striptime as a method from somewhere.
I think it would be useful to list all the available fields predicates for TASK ... WHERE <predicate> at https://blacksmithgu.github.io/obsidian-dataview/queries/query-types/#task-queries
Thanks!

Hello,
thanks for your feedback! No, the implicit fields are listed here: https://blacksmithgu.github.io/obsidian-dataview/annotation/metadata-tasks/. The documentation went through a quite extensive rework that will hopefully be online soon. I hope this will be clearer then.


Question regarding global manul installation

I'm making my own custom neovim package and and I'm trying to install this globally.
It should be as simple as putting "https://raw.githubusercontent.com/ap/vim-buftabline/master/plugin/buftabline.vim" in usr/share/nvim/runtime/autoload/ right ? Because I can't seem to get it to work.
It works without problems when I use something like vim-plug.

No. You are putting plugin/buftabline.vim in autoload/buftabline.vim. Scripts in <runtimedir>/plugin/ are always sourced on startup. Scripts in <runtimedir>/autoload/ only get sourced when any of their functions are called from another script.


arch: x86: Fix x86 linking

Summary

I noticed that qemu-i486:nsh can not start
Finally, I found that the issue was introduced by 4910d43ab0
Actually, nuttx_elf was linked dynamically
This commit fixes this issue

Impact

Affects x86 (32bit) only

Testing

Tested with qemu-i486:nsh

@xiaoxiang781216

LGTM.

@btashton
Could you backport this PR to 10.0.0?


Consider lowering required Java version to 8

As for now, Java 11 is the oldest version supported by the library. As JUnit 5 targets Java 8+, it might be worth downgrading the library codebase to Java 8. Yet, the implementation relies on some newer APIs (like java.util.regex.Matcher#results()) that will require proper replacement. Additionally, as the usage of versions < 11 drops, such effort may not be worth it.

There were no complaints about Java 11+ requirements so far. As most of the upcoming major frameworks versions (like Quarkus 3 and Spring Boot 3) will require at least Java 11 as well, it feels like a good idea to leave it as a baseline here as well.


[http] Use browser cookies

I'd like reqwest on the rust side to be able to send a request to the server as the webview's browser: meaning automatically including the webview's cookies.
In addition, it would be interesting if, when a request is made to /something, the default domain was the one of the actual webpage (like the javascript fetch).

reqwest can have its own cookie store, you can enable its feature flag
tauri-plugin-http = { version = "2.0.0-beta", features = ["cookies"] }

However we can't get the webview cookies and send them, so if you used the webview built-in fetch to set the cookie, you can't send it with the plugin fetch

In addition, it would be interesting if, when a request is made to /something, the default domain was the one of the actual webpage (like the javascript fetch).

I will open a PR for that

tauri-plugin-http-2.0.0-beta.7/src/commands.rs
if matches!(
name,
// forbidden headers per fetch spec https://fetch.spec.whatwg.org/#terminology-headers
header::ACCEPT_CHARSET
| header::ACCEPT_ENCODING
| header::ACCESS_CONTROL_REQUEST_HEADERS
| header::ACCESS_CONTROL_REQUEST_METHOD
| header::CONNECTION
| header::CONTENT_LENGTH
| header::DATE
| header::DNT
| header::EXPECT
| header::HOST
| header::ORIGIN
| header::REFERER
| header::TE
| header::TRAILER
| header::TRANSFER_ENCODING
| header::UPGRADE
| header::VIA
) {
continue;
}
Why don't cookies allow customization?


Support for TrueColors

From termbox.go:122f it appears that supporting TrueColor would be possible. I'm happy to have a first stab at a PR, but would appreciate some context around the ui architecture…
There is fatih/color, termbox, termui, gocui would it be possible to get an explanation and overview how these interact, from first glance this isn't apparent from the code.

Great question!

The TUI view rendering is handled by the gocui package. The gocui package is responsible for creating, moving, resizing, and rendering the views. Adding color to view borders and view background is done by modifying attributes on gocui instance. The pkg/ui is a wrapper for gocui views.
The termui package is only used for generating chart data points as runes. This data points are passed as a string to the chart view to render.
The fatih/color package is used for highlighting text. The sprintf methods are used for adding foreground and background color to text. The colorscheme.go file contains helper wrappers for colorscheme.
The termbox package is utilized by the termui package. Cointop doesn't use the termbox package directly.

Hope this clarify things a bit. It may be very possible that TrueColor support can be added to cointop colorschemes but I haven't dug too deep since last time I checked to see if it was doable.
Let me know if you need help!
@afh

Thanks for the clarification, @miguelmota, I think this will help me navigate the code-base.

Anything is possible!

There is full support for 24-bit colors in themes since #232 .  Use #rrggbb as a color in your theme file.  Also, X11-colors are supported by name.


In spacceleratoraddon, update existing nav component: remove unused nodes and pages

In spacceleratoraddon, remove unused nodes and pages.
We're left with this for now, in this order:

Orders
Addresses
Payment Methods
Sign Out

There will be an 'account profile' home page that leads to modular functionality. We'll add back what we need. New pages will be added as needed when we do account profile topic.

can we control the order? would like to see:

Orders
Addresses
Payment Methods
Account Profile
Sign Out

Don't want to see close account, email, etc.

PR: https://stash.hybris.com/projects/C3PO/repos/spacceleratorsamplesaddon/pull-requests/14/overview
After initialization, the My Account menu should look like this:


Status changes to Received (automated)

User Story
As an applicant
I want my submitted applications to be received by NetworkBC
so that my application will be assessed.
Acceptance Criteria

[ ] Status changed to Received
Given that an application status is Submitted
When the current date & time are after intake closing date & time (or current DateTime-TimeTravel feature)
Then the date & time are recorded in the database
And the status is changed to Received.

Note: Will need to handle scenarios here where the intake close date changes. Updates to the job will be required if the closing date changes.
Dev notes

[x] add receive_applications() function that adds a 'Received' status for every application that is submitted and where the intake is closed.
[x] create ccbc_job_executor role in the DB
[x] ccbc_job_executor can see all applications, intake, application statuses, etc...
[x] ccbc_job_executor can insert application_status
[x] configure cronjob in helm chart to call psql -d ccbc -c 'set role ccbc_job_executor; select ccbc_public.receive_applications();' twice a day at 9am/pm PST
[x] cronjob should be run with ccbc_app user and ccbc_job_executor role
[x] add received status type for applications

Are the newest changes in test?

They are, yes. To run this in the test environment, we need to:

manually update the intake close date
manually trigger the cron job

thanks was just making sure :)


can we train and see the clusters with unlabeled data?

Hi
I am currently working on clustering of my custom textual data, in which i don't have any pre-defined labels.So i just have tried with code which is available,where i have done few changes in the code for not to consider labels. while making input for the training,put it gave below error.
File "pretraining.py", line 83, in main
'nepoch':nepoch, 'lrate':[args.lr], 'wdecay':[0.0], 'step':step}, use_cuda, trainloader, testloader)
File "pretraining.py", line 171, in pretrain
train(trainloader, net, index, optimizer, epoch, use_cuda)
File "pretraining.py", line 192, in train
outputs = net(inputs_Var, index)
File "/home/tiru/Desktop/topicmodel/topicmodel/local/lib/python2.7/site-packages/torch/nn/modules/module.py", line 357, in call
result = self.forward(*input, **kwargs)
File "/home/tiru/Desktop/topicmodel/DCC/pytorch/SDAE.py", line 34, in forward
inp = x.view(-1, self.in_dim)
RuntimeError: invalid argument 2: size '[-1 x 2000]' is invalid for input with 324864 elements at /pytorch/torch/lib/TH/THStorage.c:37
So is it possible to train on text data which is not having any labels.if yes how can we train and test the same.

First of all the clustering algorithm and its module in the code do not require any label input. Please see,
https://github.com/shahsohil/DCC/blob/00d420d41e5f9de38d8defde5820e77e4ce914b2/pytorch/DCC.py#L246-L248
As you can notice here,
https://github.com/shahsohil/DCC/blob/00d420d41e5f9de38d8defde5820e77e4ce914b2/pytorch/DCC.py#L290-L291
labels were utilized only during the evaluation and that too during the last few epochs of the total DCC training.
Secondly, DCC code can complete the run even without label input and without modifying a single line of code. Just fill up dummy labels i.e., all zeros/ones/random for the target variable in the input file pretained.mat
Finally, coming to the error you are noticing - it seems to me that your input is of dimension 1,269 instead of 2,000. Please verify your input file.

Thank you
On Fri, Mar 16, 2018, 8:52 PM Sohil Shah<EMAIL_ADDRESS>wrote:

First of all the clustering algorithm and its module in the code do not
require any label input. Please see,
https://github.com/shahsohil/DCC/blob/00d420d41e5f9de38d8defde5820e77e4ce914b2/pytorch/DCC.py#L246-L248
As you can notice here,
https://github.com/shahsohil/DCC/blob/00d420d41e5f9de38d8defde5820e77e4ce914b2/pytorch/DCC.py#L290-L291
labels were utilized only during the evaluation and that too during the
last few epochs of the total DCC training.
Secondly, DCC code can complete the run even without label input and
without modifying a single line of code. Just fill up dummy labels i.e.,
all zeros/ones/random for the target variable in the input file
pretained.mat
Finally, coming to the error you are noticing - it seems to me that your
input is of dimension 1,269 instead of 2,000. Please verify your input file.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/shahsohil/DCC/issues/1#issuecomment-373747325, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALpUV4niUddm_GdL8O45-RPk3HBmOZd5ks5te9i9gaJpZM4StVKV
.


Update Composer dependencies (2021-09-11-00-05)

Visual regression test passed!
View the visual regression test report


define is not defined

i have copied the examples and tried everything but i keep getting this error in the console and the iframe will not resize, any ideas?
Uncaught ReferenceError: define is not defined(anonymous function)
@ sizer.js:1078(anonymous function)
@ sizer.js:1082
size.js  is the iframeResizer.contentWindow.min.js file

You should remove test code from the bottom of "iframeResizer.contentWindow.min.js"

Use the version in the JS folder not SRC folder.


Build failed

I try to make the deployed and I can not, I attached the error.
https://github.com/GoogleCloudPlatform/getting-started-ruby.git

Closing as there isn't enough information to follow-up. Apologies for the delay.


Administrative District region missing

The "Region" type location "Administrative District" is missing from the map. It's located at the east side of NLA. I believe the same is true for the "Residential District".

I think only the continents are marked as regions right now. So all of the NLA regions include all the districts are missing.


Convert Conjugate gradient to single precision

We need to copy the device float array x2_f into the managed double array x2. Because this is CUDA a simple x2_f[i]=(float)x2[i] won't cut it. One option is to change x2_f to be managed too. Need to see where the managed array is used though and who that'll affect memory performance.

So far so good for congradq. Still need to work on congradp

Removing bug label for now as Congradp does calculate correctly in DP

We may need to look at the CUDA version of Congradp again at a later date


NullPointerException in DoInvoke because of null receiver

机型华为LIO-AL00,安卓10
NullPointerException in DoInvoke because of null receiver
com.yanzhenjie.album.app.album.NullActivity.onCreate(Native Method)
NullPointerException in DoInvoke because of null receiver
com.yanzhenjie.album.app.camera.CameraActivity.onCreate(Native Method)

Same question


Prevent ClassCastException from putAll

Looking into this it seems what is happening is the PutMap command is being retried and this is causing the context to be populated from a remote retrieval from another node. This is causing this line to be hit and this comment to not be true
https://github.com/infinispan/infinispan/blob/main/core/src/main/java/org/infinispan/container/impl/EntryFactoryImpl.java#L226
Looking closer this also seems wrong https://github.com/infinispan/infinispan/blob/main/core/src/main/java/org/infinispan/interceptors/distribution/BaseDistributionInterceptor.java#L855
It should not always pass false, but rather send command instanceof WriteCommand

It looks like the steps to reproduce may be:
3 node cluster (N1, N2, N3)
Invoking putAll(k1, v1)
k1 owners are N1 primary and N3 backup
When N3 goes away N2 becomes new backup
PutAll is retried with N2 as backup
N2 is a write backup only and not a read backup yet and therefore the wrapping doesn't wrap the entry in the context
The last line here causes the CCE as any write command should have the entry as an MVCCEntry in the context.

Replaced by https://github.com/infinispan/infinispan/pull/11467


Stack upgrade problem with volumes-from and host scheduling

Rancher Version:
v1.1.3
Docker Version:
1.12.1
OS and where are the hosts located? (cloud, bare metal, etc):
RancherOS 0.6.1-rc1
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node rancher
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
cattle
Steps to Reproduce:
upgrade a stack with sidekicks
Results:
container moves to another host and volumes-from setting lost sometimes
Expected:
upgrade shouldn't break volumes-from / host scheduling

Volumes-from setting lost on upgrade has been fixed in Version - v1.2.0-pre2.  bug #3914.
Also to ensure your containers go to the same host, you have to set the Run all containers on a specific host.  Did you set that in the scheduling tab of the service?  I've tried multiple times to recreate your host issue in 1.2.0 bug am unable to.

Yes, but host scheduling lost / changed during upgrade. I'll test it with the pre version. Thanks

Yes, but host scheduling lost / changed during upgrade. I'll test it with the pre version. Thanks

@ahoeg if you can reproduce this on a 1.2.x version please reopen.


Output pipeline summary

Relating to https://github.com/jenkinsci/github-checks-plugin/issues/89
Very much a draft, as I've bent a lot of plumbing to get this working, which I'll fix if it's felt this is something worth pursuing.
This piggy-backs on the logic from the FlowGraphTable to generate a simple textual representation of the pipeline graph.
It produces an output that looks something like:

In progress

Simple Stage (61 ms)
In parallel (running)

p1 (running)

p1s1 (43 ms)
Unstable: something went wrong
p1s2 (running)

p2 (44 ms)

Complete

Simple Stage (61 ms)
In parallel (0.25 sec)

p1 (10 ms)

p1s1 (43 ms)
Unstable: something went wrong
p1s2 (17 ms)

p2 (44 ms)

Fails (41 ms)
Error: hudson.AbortException: something went very wrong

Note that I've removed the checkout listener, as that will now be handled by the graph listener.

I've just realised those URLs are API urls - I'll work out where the display urls are hidden.

I've removed links for now, until we can work out how to make them useful.

I've removed links for now, until we can work out how to make them useful, as there doesn't appear to be a way to easily deep link to a flow node.

Tests failure example here:
https://github.com/timja-org/junit-attachments-test/pull/4/checks?check_run_id=1627758985
Compilation failure:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1627774960
Example for inspiration of how the CloudBees SCM reporter shows failures:
https://github.com/cloudbees-sticky-dev/dow/pull/2/checks?check_run_id=925770699

it would be good if we could get the script that caused the failure in there

Should be easy enough, will have a play tomorrow.
Even bumping to 1.3.0, revapi is unhappy about removal of a public class (which was only public because @Extension) and reduction of ctor visibility (because checkstyle/spotbugs/someone told me to).
Not that the version fettling particularly matters right now, but it'd be nice to get something green.

Should be easy enough, will have a play tomorrow.
Even bumping to 1.3.0, revapi is unhappy about removal of a public class (which was only public because @Extension) and reduction of ctor visibility (because checkstyle/spotbugs/someone told me to).
Not that the version fettling particularly matters right now, but it'd be nice to get something green.

I think you can add an exclusion for that

For the table view, maybe you'll need: https://github.github.com/gfm/#tables-extension-

To be honest I’m not sure the Graph is terrible interesting, in larger pipelines it will be huge, aren’t we just interested in failed steps? And the input and output of those steps. Along with the stage / branch it failed on

This new design will push the full tree view into ChecksOutput text, and summarise results in the summary:
Summary
In parallel / p1 / p1s1 / Set stage result to unstable
Warning in unstable step, with arguments something went wrong.
something went wrong

Fails / Archive the artifacts
Error in archiveArtifacts step.
No artifacts found that match the file pattern "oh dear". Configuration error?

Stack trace
hudson.AbortException: No artifacts found that match the file pattern "oh dear". Configuration error?
	at hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:258)
	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Text

Simple Stage (50 ms)
In parallel (0.25 sec)

p1 (5 ms)

p1s1 (44 ms)
Unstable: something went wrong
p1s2 (18 ms)

p2 (45 ms)

Fails (0.28 sec)
Error: No artifacts found that match the file pattern "oh dear". Configuration error?

I'll need to check limits on output sizes...

Once again, thwarted by revapi :(

Junit has some code around limiting the output if you check it’s publisher

Once again, thwarted by revapi :(

When you are developing a new feature you should increase the minor version in pom.xml. Patch versions are reserved for bug fixes that do not change the API.

Once again, thwarted by revapi :(

When you are developing a new feature you should increase the minor version in pom.xml. Patch versions are reserved for bug fixes that do not change the API.

👍
That’s fine, but my frustration is that revapi passes locally!

revapi still not happy :(

You are exposing a new external dependency in the checks API. Is this ok? Then we can add an ignore rule, see https://revapi.org/revapi-site/faq.html#_how_to_deal_with_external_class_exposed_in_api

I'm not sure it's necessary; I could probably do some minor refactoring to avoid it - but I can't validate it because revapi is happy on my machine

It fails on my machine:
➜  checks-api-plugin git:(graph-listener) mvn clean install
[ERROR] Failed to execute goal org.revapi:revapi-maven-plugin:0.12.2:check (run-revapi) on project checks-api: The following API problems caused the build to fail:
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.actions.ErrorAction: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: enum org.jenkinsci.plugins.workflow.flow.FlowDurabilityHint: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.flow.FlowExecution: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.flow.FlowExecutionOwner: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: interface org.jenkinsci.plugins.workflow.flow.GraphListener: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.graph.BlockEndNode<START extends org.jenkinsci.plugins.workflow.graph.BlockStartNode>: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.graph.BlockStartNode: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: class org.jenkinsci.plugins.workflow.graph.FlowNode: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR] java.class.externalClassExposedInAPI: interface org.jenkinsci.plugins.workflow.graph.GraphLookupView: A class from supplementary archives is used in a public capacity in the API. (breaks semantic versioning) [org.jenkins-ci.plugins.workflow:workflow-api:jar:2.40]
[ERROR]
[ERROR] Consult the plugin output above for suggestions on how to ignore the found problems.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
➜  checks-api-plugin git:(graph-listener)

Thanks for confirmation, I'll try deleting more things until it fails.

It can be excluded,
  "exampleUseChainInNewApi": "org.jenkinsci.plugins.workflow.flow.GraphListener is used as parameter in method void org.jenkinsci.plugins.workflow.flow.FlowExecution::addListener(org.jenkinsci.plugins.workflow.flow.GraphListener) <- org.jenkinsci.plugins.workflow.flow.FlowExecution is used as parameter in method void org.jenkinsci.plugins.workflow.graph.BlockStartNode::<init>(org.jenkinsci.plugins.workflow.flow.FlowExecution, java.lang.String, java.util.List<org.jenkinsci.plugins.workflow.graph.FlowNode>) <- org.jenkinsci.plugins.workflow.graph.BlockStartNode is used as a type parameter or type variable bound on method java.lang.Iterable<org.jenkinsci.plugins.workflow.graph.BlockStartNode> org.jenkinsci.plugins.workflow.graph.FlowNode::iterateEnclosingBlocks() <- org.jenkinsci.plugins.workflow.graph.FlowNode is used as parameter in method void io.jenkins.plugins.checks.status.BuildStatusChecksPublisher.ChecksGraphListener::onNewHead(org.jenkinsci.plugins.workflow.graph.FlowNode) (method void io.jenkins.plugins.checks.status.BuildStatusChecksPublisher.ChecksGraphListener::onNewHead(org.jenkinsci.plugins.workflow.graph.FlowNode) is part of the API)",

it's referring to the new listener

🥳

Still spotbugs issue, looks like a few others checks annotations to look at as well

Hurrah. Marking this as ready for review on the basis that it's green, and it roughly does what it says on the tin. Expecting to continue to refine the output based on feedback, and add some less integration-y tests.

And happy new year!

And happy new year!

Almost :tada:

Compilation failure example could do with some improvements:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1631766639
Stacktrace for step failure is not useful to a user.
Build log would be good in that case.
Also the see more link takes you to the job page, it should take you to the run imo
Test failures is looking better:
https://github.com/timja-org/junit-attachments-test/pull/4/checks?check_run_id=1631766657
would be good to update the summary text to something better though

Also the see more link takes you to the job page, it should take you to the run imo

Does it not? http://localhost:8081/job/junit-attachments/job/PR-7/4/display/redirect looks like a run link to me.

Also the see more link takes you to the job page, it should take you to the run imo

Does it not? http://localhost:8081/job/junit-attachments/job/PR-7/4/display/redirect looks like a run link to me.

Also the see more link takes you to the job page, it should take you to the run imo

Does it not? http://localhost:8081/job/junit-attachments/job/PR-7/4/display/redirect looks like a run link to me.

ah it's the run details page, I expected the logs page, WDYT?

Also the see more link takes you to the job page, it should take you to the run imo

Does it not? http://localhost:8081/job/junit-attachments/job/PR-7/4/display/redirect looks like a run link to me.

ah it's the run details page, I expected the logs page, WDYT?

I think it probably depends on the build status - if it's success/unstable, then the logs page isn't much use (as for unstable the failure may be quite a long way up); for failure/abort then the interesting bits will be at the bottom.

I think it probably depends on the build status - if it's success/unstable, then the logs page isn't much use (as for unstable the failure may be quite a long way up); for failure/abort then the interesting bits will be at the bottom.

Junit has some code around limiting the output if you check it’s publisher

I've added https://github.com/jenkinsci/checks-api-plugin/pull/66/commits/157203bbe3acce18571d1ac2dd8728c12aa08c5d which hopefully other consumers can use, to reduce duplication. Arguably this formalises the existing leaking of some of GitHub's restrictions into the checks-api, but that seems a reasonable compromise for now.

Junit has some code around limiting the output if you check it’s publisher

I've added https://github.com/jenkinsci/checks-api-plugin/pull/66/commits/157203bbe3acce18571d1ac2dd8728c12aa08c5d which hopefully other consumers can use, to reduce duplication. Arguably this formalises the existing leaking of some of GitHub's restrictions into the checks-api, but that seems a reasonable compromise for now.

would be good to get some of the missing lines covered by tests that codecov is complaining on

would be good to get some of the missing lines covered by tests that codecov is complaining on

would be good to get some of the missing lines covered by tests that codecov is complaining on

Will do. A lot of them appear to be exception handling IOExceptions, which will be fun.

would be good to get some of the missing lines covered by tests that codecov is complaining on

Will do. A lot of them appear to be exception handling IOExceptions, which will be fun.

would be good to get some of the missing lines covered by tests that codecov is complaining on

Will do. A lot of them appear to be exception handling IOExceptions, which will be fun.

I wouldn't worry too much about those ones if they aren't ever really possible

would be good to get some of the missing lines covered by tests that codecov is complaining on

Will do. A lot of them appear to be exception handling IOExceptions, which will be fun.

I wouldn't worry too much about those ones if they aren't ever really possible

Any other planned work? I'll try test it out soon

Any other planned work? I'll try test it out soon

Nothing planned for now

Nothing planned for now

New lines don't seem to be working for the build log / some issue:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?sha=b438cc8ff4005d214221edeaf94474572d44c165
also see what happens with ansi colours:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1801300909
tbh I think it might just be a spacing issue with the markdown needing another new line

New lines don't seem to be working for the build log / some issue:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?sha=b438cc8ff4005d214221edeaf94474572d44c165
also see what happens with ansi colours:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1801300909
tbh I think it might just be a spacing issue with the markdown needing another new line

Yep, missing a trailing newline...I think just that...

Yep, missing a trailing newline...I think just that...

Didn't seem to fix it
https://github.com/timja-org/junit-attachments-test/pull/7/checks?sha=b438cc8ff4005d214221edeaf94474572d44c165

Didn't seem to fix it
https://github.com/timja-org/junit-attachments-test/pull/7/checks?sha=b438cc8ff4005d214221edeaf94474572d44c165

Fixed with another new line:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1801505585

Fixed with another new line:
https://github.com/timja-org/junit-attachments-test/pull/7/checks?check_run_id=1801505585

Could we set a better message on the failure reason on the check?

failed in 'stage' or sh step failed in 'stage' ?
or another suggestion

Could we set a better message on the failure reason on the check?

failed in 'stage' or sh step failed in 'stage' ?
or another suggestion

If you prefer we ship we can do that and create a new issue for the above ^^

If you prefer we ship we can do that and create a new issue for the above ^^

Ahh the mysteries of GitHub flavoured markdown

Ahh the mysteries of GitHub flavoured markdown

@mrginglymus https://github.com/jenkinsci/checks-api-plugin/pull/66#issuecomment-770398991 ?

@mrginglymus https://github.com/jenkinsci/checks-api-plugin/pull/66#issuecomment-770398991 ?

Could we set a better message on the failure reason on the check?

failed in 'stage' or sh step failed in 'stage' ?
or another suggestion

include both stage and step name would be greate

Successful build! 🚀
I'm looking forward to updating this plugin in Jenkins.

I'll need to check limits on output sizes

FYI https://github.community/t/undocumented-65535-character-limit-on-requests/117564/5?u=jglick

I'll need to check limits on output sizes

FYI github.community/t/undocumented-65535-character-limit-on-requests/117564/5?u=jglick

ended up being implemented here btw: https://github.com/jenkinsci/github-checks-plugin/pull/101
and API side: https://github.com/jenkinsci/checks-api-plugin/pull/68


Configurable thread count for file uploads

A customer wants to configure the thread count used for file uploads, because they have an application that polls the uploaded files continuously and the application throws an error when the file is not written to sequentially.
Current workaround is to change the parameter DefaultParallelOperationThreadCount in the FlobManager.js to 1.

Closing. This is basically implemented with the various AzCopy settings we have now.


Galal hussein storage class tasks

Initial draft of storage documentation

https://github.com/rancher/docs/issues/374


Can't connect to flying squid server with prismarine-web-client

Please see https://github.com/PrismarineJS/flying-squid/issues/591
There seems to be an issue with the playerlist_overlay.js file in prismarine-web-client when connecting to a flying squid server, in that https://github.com/PrismarineJS/prismarine-web-client/blob/master/lib/menus/components/playerlist_overlay.js#L106 is called too early.
connecting to <IP_ADDRESS> 20565 with kf106
index.js:220 bot spawned - starting viewer
index.js:226 6
viewer.js:34 Using version: 1.16.1
index.js:393 Done!
playerlist_overlay.js:106 Uncaught TypeError: Cannot read properties of undefined (reading 'uuid')
    at PlayerListOverlay.init (playerlist_overlay.js:106:1)
    at Hud.init (hud.js:215:1)
    at EventEmitter.<anonymous> (index.js:395:1)
    at Object.onceWrapper (events.js:242:1)
    at EventEmitter.emit (events.js:158:1)
    at Client.<anonymous> (health.js:13:1)
    at Object.onceWrapper (events.js:243:1)
    at Client.emit (events.js:158:1)
    at FullPacketParser.<anonymous> (client.js:91:1)
    at FullPacketParser.emit (events.js:153:1)

I have managed to get it working by wrapping a couple of things in hud.js in a bot.on('spawn' ...) but as I've only looked at the code for about an hour, I'm guessing I shouldn't be the one to make the change.
Here are the changes:
line 215 of ./lib/menus/hud.js:
    bot.on('spawn', () => playerList.init(bot, host))
lines 254-263 of ./lib/menus/hud.js:
    bot.on('spawn', () => {
      this.shadowRoot.querySelector('#xp-bar-bg').style.display = bot.player.gamemode === 1 ? 'none' : 'block'
      this.shadowRoot.querySelector('#xp-bar-bg').firstElementChild.style.width = `${182 * bot.experience.progress}px`
      xpLabel.innerHTML = bot.experience.level
      xpLabel.style.display = bot.experience.level > 0 ? 'block' : 'none'
      healthbar.gameModeChanged(bot.player.gamemode, bot.game.hardcore)
      healthbar.updateHealth(bot.health)
      foodbar.updateHunger(bot.food)
      // breathbar.updateOxygen(bot.oxygenLevel ?? 20)
      hotbar.init()
    })

Having the same issue.


don't show 'add removal reason' if sub has no reasons and 'empty removal reason' is disabled.

Because there are no reasons to add.
Empty reason setting: https://www.reddit.com/#?tbsettings=rreasons&setting=alwaysshow

Fixed with 012727f0f0608d72f54415777293b6ad9516e870.


Add new candidates on the Board page

Description
Board add candidates subcomponent created to post the new component to DB
Fixes #92
How to test?
npm run dev
Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

Very good!
This component uploads a new candidate.
Once it has uploaded it changes the state of the context it resides in. This will cause the Board Component to re-render and show the new list.
Lets go over the details tomorrow.
Make sure you don't have spaces in folder names :
BoardPageComponents

Hi Niels,
Thanks for the review. I deleted the space in the folder name.


Question: How to create a table in postgres with time column set to "timestamp without time zone"

I define a model like so:
type Table struct {
	ID              uuid.UUID        `json:"id" bun:"id,pk,type:uuid"`
	CreatedAt       time.Time        `json:"created_at" bun:"created_at,nullzero,notnull,default:current_timestamp"`
	UpdatedAt       time.Time        `json:"updated_at" bun:"updated_at,nullzero,notnull,default:current_timestamp"`
}

And I create the table with this:
_, err = bundb.NewCreateTable().
	Model((*Table)(nil)).
	IfNotExists().
	Exec(context.Background())

Here is the resulting table schema:
      Column      |           Type           | Collation | Nullable |      Default
------------------+--------------------------+-----------+----------+-------------------
 id               | uuid                     |           | not null |
 created_at       | timestamp with time zone |           | not null | CURRENT_TIMESTAMP
 updated_at       | timestamp with time zone |           | not null | CURRENT_TIMESTAMP

How can I get the type for created_at and updated_at to say timestamp without time zone ?
I couldn't find anything in the documentation that mentioned options for time zone.

Just add type:timestamp to CreatedAt and UpdatedAt under bun tag:
bun:"created_at,nullzero,notnull,default:current_timestamp" -> bun:"created_at,type:timestamp,nullzero,notnull,default:current_timestamp"
https://bun.uptrace.dev/guide/models.html#struct-tags

@svekko That worked!
However, the link provided to the struct-tags table doesn't show the type:timestamp type. At least I can't find it. The docs should be updated IMHO to show that explicitly.


Added Hyperlink to RFC7468

This PR added a Hyperlink to RFC7468 in certificate-signing-request
Fixes: #37358

/assign @tengqm
PTAL.

/approve


accounts db/background store

Problem
Extend the idea of https://github.com/anza-xyz/agave/pull/575
We can do readonly cache "store" in background.
I think this will save us all the store time shown in the graph.

Summary of Changes

move read-cache store to background
wait for background thread to fix test

Fixes #

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (6fedfe5) to head (7812caf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage    81.8%    81.8%
=======================================
  Files         851      851
  Lines      230450   230459    +9
=======================================
+ Hits       188710   188726   +16
+ Misses      41740    41733    -7

Experiment with mnt shows that there is not improvment on storing timing for this PR, ie. move store to background. Probably, sending the pubkey, slot and account over the crossbeam channel takes as much time as storing them into the cache.
Therefore, I am closing the PR.


pytest-3.8: error: unrecognized arguments: --flake8 --numprocesses=auto

I'm trying to upgrade pydyf from 0.1.2 to 0.2.0 and run into trouble in the test suite for python 3.8, as I receive the above error. flake8 is installed.
python38-pytest is version 7.1.2
Any idea?

Hello!
You probably didn’t install pydyf with its test dependencies. You can do this with this syntax: pip install pydyf[test].

Well, as I'm using OBS ( https://build.opensuse.org/package/show/home:DocB:branches:devel:languages:python/python-pydyf ) I'm not interacting with pip directly. Installation is handled by a macro. Currently trying to find out how this is handled for [test]
Here is the full error message:
[    9s] + PYTHONPATH=/home/abuild/rpmbuild/BUILDROOT/python-pydyf-0.2.0-0.x86_64/usr/lib/python3.8/site-packages
[    9s] + PYTHONDONTWRITEBYTECODE=1
[    9s] + pytest-3.8 --ignore=_build.python38 --ignore=_build.python39 --ignore=_build.python310 -v tests/test_pydyf.py
[    9s] ERROR: usage: pytest-3.8 [options] [file_or_dir] [file_or_dir] [...]
[    9s] pytest-3.8: error: unrecognized arguments: --flake8 --numprocesses=auto
[    9s]   inifile: /home/abuild/rpmbuild/BUILD/pydyf-0.2.0/pyproject.toml
[    9s]   rootdir: /home/abuild/rpmbuild/BUILD/pydyf-0.2.0

OK, then you can:

either install these dependencies, or
remove this line from pyproject.toml

Well, I tried both options, the second worked well, while the first throws still an error:
[    9s] _________________________________ FLAKE8-check _________________________________
[    9s] [gw1] linux -- Python 3.8.13 /usr/bin/python3.8
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:161: in load_plugin
[    9s]     self._load()
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:138: in _load
[    9s]     self._plugin = self.entry_point.load()
[    9s] /usr/lib64/python3.8/importlib/metadata.py:79: in load
[    9s]     return functools.reduce(getattr, attrs, module)
[    9s] E   AttributeError: module 'pycodestyle' has no attribute 'missing_whitespace_after_import_keyword'
[    9s]
[    9s] During handling of the above exception, another exception occurred:
[    9s] /usr/lib/python3.8/site-packages/pluggy/_hooks.py:265: in call
[    9s]     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
[    9s] /usr/lib/python3.8/site-packages/pluggy/_manager.py:80: in _hookexec
[    9s]     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
[    9s] /usr/lib/python3.8/site-packages/_pytest/runner.py:174: in pytest_runtest_call
[    9s]     raise e
[    9s] /usr/lib/python3.8/site-packages/_pytest/runner.py:166: in pytest_runtest_call
[    9s]     item.runtest()
[    9s] /usr/lib/python3.8/site-packages/pytest_flake8.py:120: in runtest
[    9s]     found_errors, out, err = call(
[    9s] /usr/lib/python3.8/site-packages/py/_io/capture.py:150: in call
[    9s]     res = func(*args, **kwargs)
[    9s] /usr/lib/python3.8/site-packages/pytest_flake8.py:203: in check_file
[    9s]     app.find_plugins(config_finder)
[    9s] /usr/lib/python3.8/site-packages/flake8/main/application.py:163: in find_plugins
[    9s]     self.check_plugins.load_plugins()
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:422: in load_plugins
[    9s]     plugins = list(self.manager.map(load_plugin))
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:309: in map
[    9s]     yield func(self.plugins[name], *args, **kwargs)
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:420: in load_plugin
[    9s]     return plugin.load_plugin()
[    9s] /usr/lib/python3.8/site-packages/flake8/plugins/manager.py:168: in load_plugin
[    9s]     raise failed_to_load
[    9s] E   flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "pycodestyle.missing_whitespace_after_import_keyword" due to module 'pycodestyle' has no attribute 'missing_whitespace_after_import_keyword'.
[    9s] ------------------------------ Captured log call -------------------------------
[    9s] ERROR    flake8.plugins.manager:manager.py:163 module 'pycodestyle' has no attribute 'missing_whitespace_after_import_keyword'
[    9s] Traceback (most recent call last):
[    9s]   File "/usr/lib/python3.8/site-packages/flake8/plugins/manager.py", line 161, in load_plugin
[    9s]     self._load()
[    9s]   File "/usr/lib/python3.8/site-packages/flake8/plugins/manager.py", line 138, in _load
[    9s]     self._plugin = self.entry_point.load()
[    9s]   File "/usr/lib64/python3.8/importlib/metadata.py", line 79, in load
[    9s]     return functools.reduce(getattr, attrs, module)
[    9s] AttributeError: module 'pycodestyle' has no attribute 'missing_whitespace_after_import_keyword'
[    9s] CRITICAL flake8.plugins.manager:manager.py:167 Flake8 failed to load plugin "pycodestyle.missing_whitespace_after_import_keyword" due to module 'pycodestyle' has no attribute 'missing_whitespace_after_import_keyword'.
I updated pytest-pycodesyle to latest version, but that did not fix it

It’s a nightmare to get Pytest’s plugins working together when one of its dependencies is updated. We’ve hit pytest-flake8#87 recently, this one may be another.
You can safely remove the line from pyproject.toml if you don’t use pip.


Add attention op insertion code

This replaces the bmm -> _softmax -> bmm sequence with scaled_dot_product_attention. It accounts for some view-like unary ops in between (view, _unsafe_view, expand) but the list isn't exhaustive - it might need to be expanded for future model support.

Also, try running the standalone fx script and see whether this generates a correct image.

Also, try running the standalone fx script and see whether this generates a correct image.

Good idea, I'll post the results once I've gotten them.

I've verified that the fx graph before and after my code produces the same output for a call to forward(). Haven't tested image generation, but it should also be fine. I'll let you know once the IREE changes land how the results of that test go.

I've verified that the fx graph before and after my code produces the same output for a call to forward(). Haven't tested image generation, but it should also be fine. I'll let you know once the IREE changes land how the results of that test go.

Sounds good, according to my speculation this will solve the 768x768 black image generation issue - Please if you could verify the fx graph that would be great.


Installer config added to regression config

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

Run the qa_org_2gp against a prerelease org shape.
Confirm that the K-12 Architecture Kit app is in the app launcher for System Administrator.

QA passes, K12 app now displays and is default for the SysAdmin profile - Merging

Task has been cleanly added to the regression flow and happy path testing works. Approved.