[image_picker]fix touches event through UIImagePickerController down to Flutter Widgets

Description
In a Flutter widget and present image_picker to take a photo, after shot and touch the photo, the touch event will be passed through UIImagePickerController. If there's a TextField in flutter under the UIImagePickerController, the keyboard will be presented.
Related Issues
https://github.com/flutter/flutter/issues/32896
https://github.com/flutter/flutter/issues/54251
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot I fixed it.

Looks like a clean (temporary) fix, but maybe somebody with more iOS experience should verify this.
Note that also somebody else is working on this to fix for Flutter in general as this is a problem for all viewcontrollers: https://github.com/flutter/flutter/issues/14720#issuecomment-862709250

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!


SASS/SCSS autocomplete doesn't work properly

Prerequisites

[ x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
when i start to write variable or include mixin in atom suggestions list(autocomplete) doesn't work properly.

suggestion list(autocomplete) doesn't show any of variables should show in list to for autocomplete that happening with include too when i trying to use mixins.
Steps to Reproduce

write $ or @include
autocomplete not work properly.

Expected behavior: when i write "$" or "@include" suggestion list show with my correct variables or mixins.
Actual behavior: suggestion list(autocomplete list) doesn't show project variables or mixins.
Reproduces how often: all the time
Versions
OS windows 10 pro v.16299 x64
Atom    : 1.22.1
Electron: 1.6.15
Node    : 7.4.0
apm  1.18.8
npm  3.10.10
node 6.9.5 x64
git 2.13.3.windows.1
Additional Information
this problem start to happen after update atom to latest version.

Hey @AmirFawzy - I'll close this as a duplicate of your original issue https://github.com/atom/atom/issues/16158.   The fix will be available in an upcoming release as mentioned in the comments https://github.com/atom/atom/issues/16158#issuecomment-347021959.


No Owl Eggs

Issue Description:
Owls are having hard time laying Owl Eggs there literally not plopping out reported this 10,000 times on discord but no fixes and no anwsers
What happens:
well nothing happen no eggs come out of owls lol
What you expected to happen:
Owl egg should be laying
Steps to reproduce:

Owls should plop out eggs

...

Affected Versions (Do not use "latest"):

EnderIO: latest builds on Nightly
EnderCore: latest
Minecraft: 1.12.2
Forge: 2854
SpongeForge? nope
Optifine? nope
Single Player and/or Server? both

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]

For anyone who'll find that in the future: Owls need to be sitting on leaves to lay eggs.


How can we enable Case Insensitive Properties

Hi,
We can set the ODataOptions case sensitive value manually but there does not appear to be a way to set the value if we are using the built in Model Binding.
Is there something I am missing?

You can still set the IsCaseSensitive property before you touch any of OData properties.

Hi,
I don't think I explained myself very well, or perhaps I am missing something.
If I use the sample in the repo hitting the controller with
http://localhost:58334/?$filter=Id eq 1
works fine as I would expect, if I use
http://localhost:58334/?$filter=ID eq 1
then I get
$exception	"Could not find a property named 'ID' on type 'Moon.AspNetCore.OData.Sample.Entity'."	Microsoft.OData.ODataException

with the stack trace
   at Microsoft.OData.UriParser.EndPathBinder.GeneratePropertyAccessQueryForOpenType(EndPathToken endPathToken, SingleValueNode parentNode)
   at Microsoft.OData.UriParser.EndPathBinder.BindEndPath(EndPathToken endPathToken)
   at Microsoft.OData.UriParser.MetadataBinder.Bind(QueryToken token)
   at Microsoft.OData.UriParser.BinaryOperatorBinder.GetOperandFromToken(BinaryOperatorKind operatorKind, QueryToken queryToken)
   at Microsoft.OData.UriParser.BinaryOperatorBinder.BindBinaryOperator(BinaryOperatorToken binaryOperatorToken)
   at Microsoft.OData.UriParser.MetadataBinder.Bind(QueryToken token)
   at Microsoft.OData.UriParser.FilterBinder.BindFilter(QueryToken filter)
   at Microsoft.OData.UriParser.ODataQueryOptionParser.ParseFilterImplementation(String filter, ODataUriParserConfiguration configuration, ODataPathInfo odataPathInfo)
   at Microsoft.OData.UriParser.ODataQueryOptionParser.ParseFilter()
   at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Lazy`1.CreateValue()

I think this takes place in the model binding
if I add
Type type = model.GetType();

PropertyInfo prop = type.GetProperty("IsCaseSensitive");

prop.SetValue(model, false, null);

to the BindModelAsync function than it works as expected.
I'm happy to submit a PR with some neater code.
Lastly thanks for a great project and your help so far.

I see now. ASP.NET checks values of all properties when model binding happens. I will accept the PR, thank you!

Cheers, PR created #5
let me know if it needs any changes

The PR you merged should have fixed this now


Try to see the the intermediate results of the Rasa_nlu pipeline

Rasa-nlu version:0.14.6
rasa-core version:0.13.4
Python version: 3.6.5
Operating system (windows, osx, ...):windows 10
Issue:
I want to study the NLU pipeline, and output the intermediate results of each step of the pipeline. For example, I want to get the results after tokenizer or the component about feature extraction, and directly analyze the intermediate results, what should I do?
Content of configuration file (config.yml):

Content of domain file (domain.yml) (if used & relevant):

Please ask these kind of questions in our forum

OK. Thank you for your reply. I have downloaded the code of rasa_nlu from github. And I directly modify the source code to output the intermediate results. This issue has been resolved now.


2913 new fv screens

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:

[ ] PR title matches follow: (Feature|Bug|Chore) Task Name
[ ] My code follows the style guidelines of this project
[ ] I have followed all the instructions described in the initial task (check Definitions of Done)
[ ] I have performed a self-review of my own code
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I have added reference to a related issue in the repository
[ ] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request (for frontend tasks)
[ ] I have pasted a gif showing the feature.
[ ] @mentions of the person or team responsible for reviewing proposed changes

1. dont use 'px' units

what should I use instead of 'px'?

2. why do you use isBrowser a lot?

it was there from version A of the component

3. AB should be a  function,  otherwise we get the same result for all screens. either user sees version A of all screens or B. no mix.
   at the top of the file outside the component you should have something like
   `const AB = randomAB()` this will run once and persist during user session

the random is consistent throughout the lifetime of the app

1. dont use 'px' units

what should I use instead of 'px'?

2. why do you use isBrowser a lot?

it was there from version A of the component

3. AB should be a  function,  otherwise we get the same result for all screens. either user sees version A of all screens or B. no mix.
   at the top of the file outside the component you should have something like
   `const AB = randomAB()` this will run once and persist during user session

the random is consistent throughout the lifetime of the app

@omerzam

look in the code
dont use if not required, i'm not sure why it is tthere, maybe to make it fit small mobiles
the problem is that there's no MIX. same AB is shared in all screens

@omerzam

look in the code
dont use if not required, i'm not sure why it is tthere, maybe to make it fit small mobiles
the problem is that there's no MIX. same AB is shared in all screens


Update README.md

Added kaggle resource for ML basics

Hello, thank you for your effort but this ground is already covered.


Disable server-side API requests

The Explorer's backend is performing a high volume of requests to the API and is a blocker for adjusting our API rate limiting.
AFAIK this is a nextjs server-side rendering process which needs to be tweaked.

Related https://github.com/hirosystems/explorer/issues/620

Does this remain a relatively urgent issue? Or have we improved performance otherwise enough that this is now more of a nice-to-have?

@markmhx

is a blocker for adjusting our API rate limiting

We were able to get around this blocker, but Explorer traffic makes up the single-most highest source of traffic for our APIs. So any effort that goes towards reducing server-side API requests from the Explorer will have a significant effect.

This will be partially mitigated by my PR https://github.com/hirosystems/explorer/pull/777
With this PR most pages will make only 1 api call server-side per page request (instead of 6 for some pages)
We are exploring some other solutions

either full client-side
use direct db connection for perform SSR https://github.com/hirosystems/explorer/issues/783

@beguene I've added this to the board to close it when we move to full client-side

The next step is to remove SSR from the Microblocks page, and delete the old tx component

:tada: This issue has been resolved in version 1.39.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Terraform to Lint list

Name of an extension you are adding
vscode-terraform
Why do you think this extension is awesome?
It doesn't only highlight and validate the syntax, but also can tell us how many resources reference to the certain resource.
Make sure that:
[ ] Screenshot/GIF included (to demonstrate the plugin functionality)
[x] ToC updated

LGTM. @viatsko or @jschr, if you agree, feel free to merge it.

Thanks!


sadostic.pl

Original, good, valid domain is sadistic.pl
I made typo i > o and weird ads redirect shows.

Thank you Tomasz @FadeMind.  Merging.


Non-SRD monsters should be removed

A few monsters are present in the database but should be removed.
So far I could only spot the Ancient Blue Dracolich, but I suspect more are present. I'll check this deeper in the following days.

what's the reason for why they need to be removed?

@Alex-frazer Because they're part of the MM, which is entirely proprietary. Only the SRD is subject to the OGL which allows us to put that data in this project. If it's in the SRD, we can put it here. If it's in any other D&D publication, we may not because of copyright laws.

I really hate that this is a thing but yeah you're right. @ogregoire If you're going to do this, can you updated the README to say something about things only subject to OGL, which is mostly just SRD?

Agree, for legal reasons anything not explicitly SRD should not be included.  The repo should be canonical only.
Now, there is nothing stopping people from forking the repo and adding their own separate JSON files of the same format with homebrew, etc. monsters.

Seems documents like this could be helpful for understanding legal requirements:
https://github.com/benjaminapetersen/open5e-api/blob/master/data/creature_codex/document.json

Also Roll20 seems to do well with SRD content.  They have a number of public repos, such as https://github.com/Roll20/roll20-api-scripts.
But I don't know where they get their data.

Referencing issue #114 as a possible way to verify before changes.


checks invalid X type for y multivariate and univariate

if the estimator has the tag scitype:y = multivariate, the test example should have 2 columns and should have 1 column if univariate.

Reopen


Capture in non-stop manner into ping-pong buffer ?

I try to implement the method in your library to do that.
How can you transfer the value from ADC to buffer on ram ?
I have reading some documents for weeks, but still not coding yet. Can you help me a little?

Have you figured this out?
If I remember correctly, this requires co-operation between Assembly PRU code and C code.
Current code does this:

PRU writes to the RAM buffer
when buffer is filled out, it raises interrupt and halts
C library waits for interrupt. When detected, it clears interrupt, then reads RAM and unpacks as Python array

You will need to modify it to have two (or more) buffers in RAM. At step (2) PRU should not halt, but
instead switch to writing to the other buffer.
Watch for buffer overrun conditions. It is possible that Python code takes too much time to process the buffer and by the time PRU wants to write to it it is still in-use by Python.
Good luck

A separate project implements streaming ADC capture, see:
https://github.com/pgmmpk/bbb_pru_adc


hplip: "ImportError: No module named scanext"

Issue description
A very similar issue to https://github.com/NixOS/nixpkgs/issues/279
I'm trying use an hp scanner on NixOS. If I try to use a scanner tool like simple-scan or xsane they complain about missing drivers. I've installed the hplip package and followed the instructions on the wiki here.
hplip comes with a tool called hp-scan. If I run it it complains 'hplip: "ImportError: No module named scanext"'. This can be worked around by modifying the PYTHONPATH env variable to point into the hplip python directory in /nix/store. However if I do that it then complains "error: No device selected/specified or that supports this functionality". If I specify the device on the command line it says "error: 'DeskJet_3630' device doesn't support this feature (or) Invalid printer name".
Any idea what to do about this? The package clearly isn't setup properly if I need to fiddle with paths to make things run, but I don't know if that's causing the larger issue of it not finding the scanner.

System: 17.03.git.09e4b78 (Gorilla)
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: 17.03.git.09e4b78

Should be related to #19469.

the issue should be solved if you're on the nixpkgs-unstable channel. Could you check it?

I don't get the python import error anymore but it still doesn't detect the scanner. I tried it on my gentoo box and it worked fine.
Closing because I have no idea whether this is a nixpkgs issue and because the import error is fixed.

I'm afraid I can't help you with that.

I figured as much. Thanks for fixing this though.


Error trying to have multiple projects that use project_options

There's a decent chance this is pure user error and I don't understand how to compose project_options properly, but I'm getting configure-time errors when trying to have multiple projects using project_options, specifically:
[cmake] CMake Error at build/_deps/_project_options-src/src/Index.cmake:125 (add_library):
[cmake]   add_library cannot create target "project_options" because another target
[cmake]   with the same name already exists.  The existing target is an interface
[cmake]   library created in source directory
[cmake]   "/home/mcoding/Projects/project_options_multiple_include_mwe".  See
[cmake]   documentation for policy CMP0002 for more details.

The project structure is like this:
project/
    apps/
        CMakeLists.txt
        main.cpp
    CMakeLists.txt
    external/mylib/
        CMakeLists.txt
        include/mylib
            mylib.hpp

Both project and the submodule mylib use project_options, which explains why cmake thinks project_options is being multiply defined, because both project and mylib do indeed define their own set of project options. Is this a situation where project_options should be defining target names that depend on the project name like ${PROJECT_NAME}_project_options instead of a global name project_options? Or is there some way to have project_options scoped to a namespace like mylib::project_options? Or should only the top-level project be defining project options (using an if TARGET guard before including it) with subprojects modifying the options using dynamic_project_options?
Any guidance here would be appreciated.
Here are the relevant list files for the minimal working example:
Top level CMakeLists.txt:
cmake_minimum_required(VERSION 3.16)

include(FetchContent)
FetchContent_Declare(_project_options URL https://github.com/aminya/project_options/archive/refs/tags/v0.24.1.zip)
FetchContent_MakeAvailable(_project_options)
include(${_project_options_SOURCE_DIR}/Index.cmake)
include(${_project_options_SOURCE_DIR}/src/DynamicProjectOptions.cmake)

project(myproject LANGUAGES CXX C)

dynamic_project_options()

add_subdirectory(external/mylib)

add_subdirectory(apps)

apps/CMakeLists.txt
add_executable(main main.cpp)
target_link_libraries(main PRIVATE project_options project_warnings)

target_link_system_libraries(
  main
  PRIVATE mylib
)

external/mylib/CMakeLists.txt
cmake_minimum_required(VERSION 3.16)

include(FetchContent)
FetchContent_Declare(_project_options URL https://github.com/aminya/project_options/archive/refs/tags/v0.24.1.zip)
FetchContent_MakeAvailable(_project_options)
include(${_project_options_SOURCE_DIR}/Index.cmake)
include(${_project_options_SOURCE_DIR}/src/DynamicProjectOptions.cmake)

project(mylib LANGUAGES CXX C)

dynamic_project_options()

add_library(mylib INTERFACE)
target_link_libraries(mylib INTERFACE project_options project_warnings)

set(INCLUDE_DIR "include")
target_include_directories(mylib INTERFACE "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/${INCLUDE_DIR}>"
                                          "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>")

One solution would be, the every project_options- cmake cache variable and interface library must be prefixed with the ${PROJECT_NAME}.
@mCodingLLC by the way, your project names should be different!

We also need to check if project_options is a target, and if it is we realize it is a multi-project.

I made a pull request to fix this issue. #150

Wow very fast fix, much appreciated!
Since I'm the first to bring this up, has this not been an issue before because you don't generally use/recommend submodules within a repo as the place to store dependencies? If so, where do you keep your dependencies? Install them and always use find_package?

Released in v0.25.0

Since I'm the first to bring this up, has this not been an issue before because you don't generally use/recommend submodules within a repo as the place to store dependencies? If so, where do you keep your dependencies? Install them and always use find_package?

I recommend using vcpkg. See
https://github.com/aminya/cpp_vcpkg_project


Not guaranteed order of calling onCarinaAfterMethod  method from IAbstractTest as last afterMethod

if add afterMethod to the interface (nor does this interface inherit the IAbstractTest interface) and specify it above the class at the same level as IAbstractTest, then the order of calling onCarinaAfterMethod as the last afterMethod is not guaranteed.
So it is not guaranteed in such situation that driver will be available.

wontfix. Working as designed


Type definitions doesn't work with latest version of popper.js

"popper.js" type definitions have been updated recently and they are braking "react-popper"  type definitions. I am getting:
Namespace ''popper.js'' has no exported member 'Placement'.
Namespace ''popper.js'' has no exported member 'Modifiers'.

They have introduced braking changes in 1.11.1. Why don't you lock your "popper.js" to "1.11.0"?

This is addressed in PR #51 awaiting to be merged.
In the time being, you can work around it writing a module augmentation:
declare module 'popper.js' {
    /* This augments the popper.js module, because in the installed version
    Placement and Modifiers interfaces are exported under the default exported value,
    but react needs the declaration as it is defined here. */

    import PopperJS from "popper.js";

    export type Placement = PopperJS.Placement;
    export type Modifiers = PopperJS.Modifiers;
}

And save it to a file like: popper-augmentation.d.ts where your source files are.
Or locking to<EMAIL_ADDRESS>in your own package.json and reinstalling from scratch to make npm dedupe that dependency.

I think this is fixed in the latest release with this PR https://github.com/souporserious/react-popper/pull/51 please feel free to reopen this issue if not.

Thanks! Already tried it, seems to be working just fine.


Bare repos are ignored

I try to open a folder with .git extension which a bare repo. But it's not visible in browser. show_hidden doesn't do anything. Is there any way to configure git bare repos support?

Figured out - this should be configured through telescope itself and not telescope-file-browser:
defaults.file_ignore_patterns = {...}


Support for Java 17 / Java 21?

The current release requires Java 22 or above, which means that this package cannot be used on systems running Java 17 or Java 21 (the two most recent LTS releases). Is there any way to use this kernel on such systems?

Currently the only way is to rebuild it for 17 version and change the compiler options in kernel.json. I had put the latest version because I enable preview features, which I use in a library that I own. But actually there is no need for such constraint.
In order to make things easy I will create a new release which will allow an optional auto installer. I will see how low I can go with java release. Thank you for trying, I will solve this issue in the following days. Hope that helps.

Dear @padreati, that would be great, thanks a lot!

I have implemented the changes for enabling Java 17 and above. In order to facilitate using custom setups I have created also an installer profile. The default profile runs clean, as expected. There are two additional profiles, preview22 and preview23 which creates kernel.json files configured for using preview features with java 22 and 23. This will catch the next release which will come soon.

Resolved. To be released in 2.2.0

Great, thank you very much! I'll provide feedback once the release is out.

Works flawlessly for me, thanks!


dApp mobile: Raiden Wizard integration research

User Story
As Chris I want to get started making payments right away by using a similar onboarding wizard as the Python client.
Acceptance criteria
Clear idea of the desired outcome of integrating the Wizard and a good estimation of the efforts required.
Tasks

[ ] @taleldayekh Get a better understanding of what is expected with having the wizard integrated in the LC.

Quick chat with Talel: it probably makes no sense to invest any time here as it should not be possible to find any easy integration here. He will have a final word on this with Kamal tomorrow and then probably close the issue then.

The Raiden Wizard is not really relevant for the Light Client since the Light Client already have an onboarding process for acquiring most of the necessary tokens to get started making transfers. A user cannot acquire ETH and DAI but this could be solved by i.e. Ramp Network integration.


Fix the plain page size is too large when writing a large batch

Proposed changes
The original code logic will save all the write data of a batch in the same plain page, which makes the seek performance bad.
Types of changes
What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
[ ] Code refactor (Modify the code structure, format the code, etc...)
[ ] Optimization. Including functional usability improvements and performance improvements.
[ ] Dependency. Such as changes related to third-party components.
[ ] Other.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
[x] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If these changes need document changes, I have updated the document
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

This PR has not been updated for a long time.
There could be many reasons.
If it's caused by there are no maintainers to push or ignore this PR, I'm sorry.
If you contact maintainer or want to continue this PR, feel free to @me or @other maintainers.


tf.concat returns a list not Tensor, is it a bug?

My code is below
from __future__ import print_function
import tensorflow as tf
import numpy as np
import shutil
import os

class Model(object):
    def __init__(self, input_length, input_dim=10, filter_nums=[3,4,5], window_sizes=[2,3,4]):
        self.filter_nums = filter_nums
        self.window_sizes = window_sizes

        # placeholder
        self._inputs = tf.placeholder(tf.float32, shape=[None, input_dim,
        input_length], name="inputs")

    def _conv2d(self, inputs, filter_num, window_size, init_scale=0.1, data_format="NHWC", name="conv2d"):
        # Implement a conv2d for nlp task, which in_heigth = filter_height.
        # assume inputs dim is 4.
        with tf.variable_scope(name):
            if data_format == "NHWC":
                filter_height = int(inputs.get_shape()[1])
            else:
                filter_height = int(inputs.get_shape()[2])
            in_channels = int(inputs.get_shape()[-1])
            W = tf.get_variable("W", shape=[filter_height, window_size,
            in_channels, filter_num],
            initializer=tf.random_uniform_initializer(-init_scale, init_scale))
            conv = tf.nn.conv2d(inputs, W, [1,1,1,1], "VALID")
            return conv

    def _max_pool(self, value, name="max_pool"):
        with tf.variable_scope(name):
            pool_width = int(value.get_shape()[-2])
            maxpool = tf.nn.max_pool(value, [1,1,pool_width,1], [1,1,1,1], "VALID")
            return maxpool

    def multi_conv_pool(self):
        pooled = []
        expanded_inputs = tf.expand_dims(self._inputs, -1)
        for filter_num, window_size in zip(self.filter_nums,
        self.window_sizes):
            conv = self._conv2d(expanded_inputs, filter_num, window_size,
            name="conv2d_width_%d" % window_size)
            maxpool = self._max_pool(conv)
            pooled.append(maxpool)
        concat_pooled = tf.concat(3, pooled)
        return concat_pooled

    @property
    def inputs(self):
        return self._inputs

def main():
    logdir = 'logdir'
    if os.path.exists(logdir):
        shutil.rmtree(logdir)

    model = Model(input_length=9, input_dim=4)
    concat_pooled = model.multi_conv_pool()

    data = np.random.randn(3, 4, 9)

    sess = tf.Session()

    summary_writer = tf.train.SummaryWriter(logdir, graph=sess.graph)

    sess.run(tf.initialize_all_variables())
    outputs = sess.run([concat_pooled], feed_dict={model.inputs: data})
    print("data(shape = (3, 4, 9)):")
    print(data)
    print("after multi conv and pool, its output should be (3, 1, 1, 12):")
    print(outputs)
    print("outputs' type:", type(outputs))

if __name__ == '__main__':
    main()

Run it and gets a list. outputs here is the return value of tf.concat(). It should be an array but now it's a list. Could anyone tell me why? Thanks!

Solved it. Here is the explanation from tf.Session().run() doc.

Returns:
Either a single value if fetches is a single graph element, or
a list of values if fetches is a list, or a dictionary with the
same keys as fetches if that is a dictionary (described above).


Needed Support for implementing Google Picker API In Flutter

I have Found official support for Google Drive and not for Google Picker. (Link Provided below)
https://pub.dev/packages/googleapis
Currently able to upload and see files in my drive on authentication with drive scope using the google sign-in package.
From official google docs for google picker API, support provided for JS
https://developers.google.com/drive/picker/guides/overview#gdata
Is there any way to implement google picker API in flutter?

I think you'll have to implement it yourself – or see if anyone has built something on pub.dev

Hi Kevmoo,
I'm in need of  some support for own implementation .
From official google docs for google picker API, support provided for JS
https://developers.google.com/drive/picker/guides/overview#gdata
Note that JS were only supported by Flutter Web and not on Flutter Mobile.  Can you please assist ?
Currently there are no package available to pick on pub.dev for google picker API .


Improve how users of different operating systems use the tutorials

What
Improve how users of different operating systems use the tutorials
Why
The instructions are more tailored to mac users.
As a windows user, I want to see more windows specific options, so that I can easily set my prototype up
Who needs to work on this

Content designer
Developer
Interaction designer

Done when

[ ] All the changes needed for windows users are identified
[ ] It is as easy for a windows user to follow the tutorials as a mac user

https://github.com/alphagov/govuk-prototype-kit-docs/tree/operating-systems

@ruthhammond @joelanman @alinagraham @JonJMagee  I've split out the journeys for Windows and Mac within the branch above. I've only got a Mac, so I'm not able to follow the Windows tutorial to see what works and what doesn't. Do we have any ideas on how to tackle this?

@joelanman @ruthhammond I think we've done this, so I'll close the ticket.


Binaries for v13.3.1 Node 16 (v93)

Hi, looking at https://supabase-public-artifacts-bucket.s3.amazonaws.com/ tha last version uploaded is v13.3.0.
Would you mind adding v13.3.1 for Node 16 v93, both linux x64 and arm64?
Also v14.0.0 and v15.0.0 would be ideal.
This is preventing me to upgrade some dependencies.
Thanks in advance

13.3.1 has been uploaded. The pre-built binaries are an optimization, and should not be a blocker for upgrades--it'll fall back to compiling from source if needed.


Consistent display of time values

Describe the solution you'd like
Currently there is a wide diversity for displayed time values:

Alert Create Time Diff - rounded to one unit
Alert Timeout - seconds without unit
Heartbeat Latency - milliseconds with unit
Heartbeat Timeout - seconds with unit
Heartbeat Since - minutes and seconds with unit
maybe others
This is really inconsistent and also sometimes hard to understand. (How much are "129600 seconds" or "903 minutes 9 seconds"?)

Describe alternatives you've considered
Nice would be the display of the 2 highest possible units and maybe the other smaller ones as tooltip.

Are you aware that you can change the date formats? See https://docs.alerta.io/en/latest/configuration.html#web-ui-settings Does that help?
But I agree, there could be more consistency with things like "time since". Either way, I like the suggestion.

Yes, I know. But currently not possible for time diffs.

I'll add it to the backlog. Thanks for the feedback.


AutoSave when app looses focus

When working with automatic rebuild/refresh tools (e.g. in web development) it would be handy if vscode would save all modified files as soon as its window looses the focus when switching to another application.
There is an option files.autoSave: onFocusChange. There should be another option onWindowDeactivation or something like that.
JetBrains' line of IDEs has this option. IMHO it's very handy.

Btw, "files.autoSave": "onFocusChange" and "afterDelay" are mutually exclusive currently and that is bad. You can't have both enabled.
I would like to suggest following changes:

value of "files.autoSave" to "on" / "off"
add "files.autoSaveOnFocusChange": "currentFile" / "allFiles"

Added a new onWindowChange option for auto save 👍


[Diagnostics] When checking AssignExpr properly diagnose destination

Currently if destination is unresolved instead of trying to re-typecheck
it again and diagnose structural problems which led to such outcome, it
gets completely ignored in favor of trying to type-check source without
contextual type. That leads to missed diagnostic opportunities, which
results in problems on AST verification and SIL generation stages, and
generally missleading errors e.g. .x = 0.
Resolves SR-3506.

/cc @rudkx @slavapestov @jtbandes
This also resolves a SIL crasher which has incorrect destination and correct source just like SR-3506.

@jtbandes I've made it so source expression is going to be type-checked if for some reason re-checking of the destination didn't produce the diagnostic, which covers all the possible scenarios now.

@slavapestov @jtbandes I've resolved conflict after merging #6492 and force pushed.

@swift-ci Please smoke test


int packed version of datetime.date

Coverage decreased (-0.5%) to 78.446% when pulling aa98bb9c45f538ea5dcd067ca9428819addbf48f on packed_datetime_date into 355488db860e410f02f2ebf73966003bb185031c on master.


Theme switch doesn't work correctly in settings page

PR includes

[x] Bug Fix

Related issues
Resolve #955

https://github.com/user-attachments/assets/16c1dd33-6602-4534-8abb-2f6266f01913

https://github.com/user-attachments/assets/65d87b99-b948-48ea-bc6a-1d16db1306f5


Counting filter doesn't remember Item ID when replacing existing item with drag/drop

LaserIO version
1.4.2
Minecraft Version
1.18.2
Forge Version
1.18.2-forge-40.1.69
Modpack & Version
Direwolf20 1.18
Do you have optifine installed?
No
Describe the issue
Replacing Items in Counting filter with Drag/Drop updates the count, but not the item ID
Steps to reproduce
Get Default Counting Filter and two items
Place # of items in slot 1 & 2
Close/Reopen the Counting Filter and try to replace with # 2 and a different item.
Close/Reopen the Counting Filter and you see that the # is correctly modified, but not the item.
Expected behaviour
The interface should keep what is done when you update it.
Additional information
No response

Confirmed, I'll look into fixing this for 1.19 -- For now just remove the itemstack from the filter before adding a new one.
Thank you for reporting it :)

Resolved. Thank you :)


AS-SET "expands to" doesn't show source IRR DB

In the legacy irrexplorer, there's a "source" column that shows the DB (e.g. radb, altdb, arin, etc.) that the included object exists in. This is useful, for example, in a case where an AS-SET has a member that exists in multiple places. Then we can see it listed twice with the origin (and contents) of each object. But it looks like this version of irrexplorer does not show that info, and in fact does not show multiple copies of objects that share a name in multiple DBs.
If you want to see a real-life example, check out AS-INFORELAY, which has the member AS-ARPNETWORKS. AS-ARPNETWORKS exists in both altdb and ripe with different members.

Thanks, this is now merged and deployed on the beta instance on irrexplorer.dashcare.nl
(Although it seems AS-ARPNETWORKS is now consistent between both sources)

yes 😅 they corrected the discrepancy. But thank you for adding this!

FYI, I can't get https://irrexplorer.dashcare.nl/ to load. I tried Chrome and Firefox, from home (Verizon AS701) and elsewhere (Fork Systems AS25682). In both cases it just spins forever and the page never loads.
I did curl -v https://irrexplorer.dashcare.nl/ and got the following:
*   Trying 2001:678:d44:65::4...
* TCP_NODELAY set
* Expire in 149769 ms for 3 (transfer 0x558d9438cfb0)
* Expire in 200 ms for 4 (transfer 0x558d9438cfb0)
* Connected to irrexplorer.dashcare.nl (2001:678:d44:65::4) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: none
  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: CN=irrexplorer.dashcare.nl
*  start date: May 18 20:18:41 2021 GMT
*  expire date: Aug 16 20:18:41 2021 GMT
*  subjectAltName: host "irrexplorer.dashcare.nl" matched cert's "irrexplorer.dashcare.nl"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.
> GET / HTTP/1.1
> Host: irrexplorer.dashcare.nl
> User-Agent: curl/7.64.0
> Accept: */*
>
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing

and it just sits there and goes no further.


GEN-21: Create a Wikipage for Conventions

What's up?
We've been using some conventions for issues (namings, contents and so on) for a while although we didn't really feel the necessity to document them in detail. Since the number of conventions we have to comply with increases, it's important to create a separate wiki page to document them.
To Do

[ ] Create a wikipage for general conventions and development practices.
[ ] Attach the wikipage to the proper subtitle in sidebar (Project subtitle seems to be the correct position)
[ ]  Content of this page may include but not is limited to:

Issue conventions (naming, content of the issues, reviewer policies etc.)
Code conventions (formatting and so on - this part will be filled by the development teams throughout the implementation)
Git conventions (branch naming conventions etc. - haven't talked yet, but we'll talk about this in the next meeting)

Deadline
16.10.2022 @18.00
Additional Information
No response
Reviewers
@MustafaEmreErengul

Deadline has passed. Can I kindly remind you take necessary actions?

Since all conventions mentioned above are written in the Wiki page now, no further action is required. Revision is done, closing the issue.


Team lead Can Edit Requests

Follows #1822
Team leads should be able to edit a request when it belongs to an itinerary they manage. This will allow them to modify the address details and update the notes field as necessary.
We should be careful to ensure that a team lead can only view requests which belong to itineraries they are currently set as team lead.

I'm working on a pre-requisite PR to support easier authorization of such actions

@stevejgordon @tonysurma This can be closed as per my comments in #1787.


chroot: install busybox applets for non-existent commands only

When I enabled chroot_very_small_image on eewiki_minfs_ubuntu_focal_armhf.conf,
sshd did not enabled automatically, due to dpkg-reconfigure failure.
The blocker was busybox's readlink.
This patch refactors the installation of busybox applets instead of just removing /usr/local/bin/readlink.

Looks good @AtsushiNemoto , the busybox binary has been fun to deal with between debian releases...


FEATURE: Adding Email Validator App

Is your feature request related to a problem? Please describe.
This is the new feature I want to add to this GGExtension
Describe the solution you'd like
This app takes the email and validate is it correct or not / Valid or not
This is very good Project and give good effect to your GGExtension project

Hi @Sulagna-Dutta-Roy
Can you please assign me this issue #290?

hi @Sulagna-Dutta-Roy
I have created pull request #305.
Can you please merge it so that I can add more features to this GGExtensions projects


No window rendering since version 11

Trying and passe to versions 11 for Avalonia,
without template, I had to remove the App Style setup (FulentTheme not being ported),
the App launches, but only window decorations are visible.
Steps to reproduce the behavior:

choose any Avalonia 11.* App to check under Debian
See the transparent window rendering, instead of your app

Expected behavior
The hello Avalonia 11.x window under Debian
Screenshots
TODO

OS: Debian 11 x64
Version 11.*

Additional context
TODO : find an example to build from the HEAD of the main branch (I've got to submit and close my session)

FluentTheme needs to be included. Or any alternative theme.
See https://github.com/AvaloniaUI/Avalonia/wiki/Breaking-Changes#avaloniathemesfluent-and-simple

sorry, a bad click certainly ...

thanks a lot!


[TextField] Doesn't apply color from inputStyle prop

Problem description
With 0.18.3 version my TextFields lose custom colors. After downgrading to 0.18.2 colors work as expected.
As I see, it's related to #7065
Link to minimal working code that reproduces the issue
https://www.webpackbin.com/bins/-KnEbDVKdLKisHPScLox
Versions

Material-UI: 0.18.3
React: 15.5.4
Browser: Chrome 58.0.3029.110 (64-bit) (windows 10)

I think that it's a duplicate of #7089. We will release the fix by the end of the week.


Support usb mass storage device for esp32s3?

Support usb mass storage device for esp32s3?

I'm guessing it would be similar to using an SD card. If you can mount the device on the file system, you can access it using FTP. Have a look at the SD card example and see if that might get you to your goal of using a USB flash drive.


Markdown preview inconsistent with rendered text

See screenshots of input/preview and rendered result.

This actually seems to be a more general issue that what is rendered in the preview panel is not what ends up in the final result. In fact, when looking at issue #3415 I noticed some inconsistencies between the preview of a new annotation and what gets displayed in the annotation tooltip text.
Do you mind if I change the title of this issue to something like: "Markdown preview inconsistent with rendered text" and I'll look into the cause sometime in the future.

This should be fixed now.


support swift 2.0

Hello.
He started to develop the application. Really liked the implementation of DrawerController. When will support Swift 2.0?

@REZ1DENT3
Hi,
Thunk you!
It is scheduled to be implemented at the end of this week.
Please wait a moment.

@REZ1DENT3
Hello.
supported swift2.0. Please try! :+1:
https://github.com/ykyouhei/KYDrawerController/releases/tag/1.1.0-bata.3

Hello. Thank you very much!


Audit templates for improper owner checks

Might be easier to merge this now and fix the conditions.hbs style regressions later when I have to prod in there again for afflictions anyways.


[Marking Mode: None]: Crash: Attempt to use cleared object reference

Please, provide the details below:
Via crashlytics we have been getting reports of crashes of the type
com.tns.NativeScriptException: Attempt to use cleared object reference id=48048(com.tns.NativeScriptException: Attempt to use cleared object reference id=48048     com.tns.Runtime.getJavaObjectByID(Runtime.java:893)
Did you verify this is a real problem by searching Stack Overflow and the other open issues in this repo?
Other closed bugs reference the same or similar issues (latest was closed for 3.0.0).
Please provide the following version numbers that your issue occurs with:

CLI: 3.2.1
Cross-platform modules: 3.2.0
Runtime(s): 3.2.0
Plugin(s):

nativescript-angular: 4.4.1

nativescript-fabric: 0.3.1

nativescript-pro-ui: 3.2.0

nativescript-google-maps-sdk: 2.3.3

Built using webpack (npm run ns-bundle --android --build-app --snapshot --clean  --release)
Also using in app/package.json:
  "android": {
    "v8Flags": "--expose_gc",
    "markingMode": "none"
  }

Did the error happen while the app was being constructed? (buildtime error)
No
Did the error happen while the app was executing? (runtime error)
Yes, but I haven't reproduced it myself. Just numerous similar stack traces being sent via crashlytics/fabric.
e.g.
#0. Crashed: main: 0 0 0x0000000000000000
       at .Error: com.tns.NativeScriptException: Attempt to use cleared object reference id=48048(com.tns.NativeScriptException: Attempt to use cleared object reference id=48048
    com.tns.Runtime.getJavaObjectByID(Runtime.java:893)
    com.tns.Runtime.callJSMethodNative(Native Method)
    com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1084)
    com.tns.Runtime.callJSMethodImpl(Runtime.java:966)
    com.tns.Runtime.callJSMethod(Runtime.java:953)
    com.tns.Runtime.callJSMethod(Runtime.java:937)
    com.tns.Runtime.callJSMethod(Runtime.java:929)
    com.tns.gen.java.lang.Runnable.run(Runnable.java:10)
    android.os.Handler.handleCallback(Handler.java:751)
    android.os.Handler.dispatchMessage(Handler.java:95)
    android.os.Looper.loop(Looper.java:154)
    android.app.ActivityThread.main(ActivityThread.java:6780)
    java.lang.reflect.Method.invoke(Native Method)
    com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1496)
    com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1386):1)
       at . ... (repeats with slight differences)

full trace at https://pastebin.com/JEGTYrpx
Please tell us how to recreate the issue in as much detail as possible.
Unknown. Possibly random.

Hi @daveware-nv, we're going to be able to better assist you if you provide steps to reproduce, with the minimal code required or a small repo for us to check out.
Having said that, can you give us the content of your projects' package.json so we can check out the plugins you're using.
The problem occurs when a javascript object with a native counterpart isn't taken care of by the developer, since marking mode=none doesn't check which js objects have a native counterpart and should survive GC and which don't.

As mentioned I don't know when it occurs as I haven't observed it myself, nor as a result do I know what the minimal code required to reproduce would be.
snippets from the package.json:
  "dependencies": {
    "nativescript-angular": "~4.4.1",
    "nativescript-angular-snapshot": "3.0.0-5.5.372.32",
    "nativescript-couchbase": "custom-see-below",
    "nativescript-fabric": "^0.3.0",
    "nativescript-google-maps-sdk": "^2.3.2",
    "nativescript-pro-ui": "~3.2.0",
    "nativescript-svg": "^1.1.3",
    "nativescript-theme-core": "~1.0.2"
},
"devDependencies": {
    "nativescript-css-loader": "~0.26.0",
    "nativescript-dev-android-snapshot": "0.*.*",
    "nativescript-dev-typescript": "~0.4.0",
    "nativescript-dev-webpack": "^0.8.0",
    "nativescript-worker-loader": "~0.8.1",
}

notes:

Despite nativescript-svg being present I don't think we're actually actively using it.
For nativescript-couchbase we're using a custom version derived from 1.0.17
We also have a purely custom plugin for doing some bluetooth interaction
There's probably also direct references to android bits here and there in the application itself, including producing some uuid's using java.util.UUID.randomUUID().toString().

Is there some detailed documentation on what 'taken care of by the developer' means in you above post? The only reference I've seen to markingMode: none is the 3.2 announcement blog post and it wasn't detailed enough on what is required to prevent markingMode: none causing problems.
We have a lot of data going into and out of couchbase, so depending on what care needs to be taken with which kinds of java objects that may be the first place for me to look once I know what to look for.

@daveware-nv

...once I know what to look for

The simplest way for me to explain what to look for. Consider this scenario in your code or in some native plugin you're using (there's a big chance the problem is in the plugin, as the currently available plugins aren't meant to be used in conjunction with markingMode: none.
problem
var implementor = new android.native.Implementor()
var callback = new android.native.NCallback({
	getMessage: function() {
		implementor.getMessage()
	}
})
android.native.Executor.printWithDelay(callback, 3s)

pseudo code

android.native.Implementor : native class
android.native.NCallback : native interface

The implementor is enclosed by the callback implementation, but with markingMode: none enabled we no longer take care of finding that connection out. So when GC happens implementor instance is GC`ed.
solution
to fix the previous example you must keep implementor from being GC'ed, by attaching it to the global object which is not being GC'ed ever, or some other long-lasting object, exported module or wherever you see fit. (implementor is attached to global is just for the sake of the example).
var implementor = new native.Implementor()
global.implementor = implementor
var callback = new native.NCallback({
	getMessage: function() {
              global.implementor.getMessage()
	}
})
native.Executor.printWithDelay(callback, 3s)

pseudo code

summary
Every native object instantiated in JS:
var implementor = new android.native.Implementor()
which is enclosed by a function of an extended class, or enclosed up it's prototype chain:
...
	getMessage: function() {
		implementor.getMessage()
	}
...

needs to be managed by the developer. You should decide when it should be not used anymore and can be let go for GC.

We haven't got a blog post about it because it's an experimental flag, and we're still contemplating on trying it out. We wanted to check out what kinds of problems developers would encounter, so we get a better understanding of the user scenarios.

Thanks. If that is the extent of it, then it should be less of a problem to track things down in my code than I expected.  Less easy are nativescript-pro-ui since it does not have source available.  And nativescript-angular since my app is an angular one this will be used heavily by every screen (and a quick look though the stacktrace I posted above reveals EmulatedRenderer.NativeScriptRenderer.insertBefore, which I believe corresponds to this line https://github.com/NativeScript/nativescript-angular/blob/42e438ce4b206ff96fb2fe31e9968fcfc555f5a6/nativescript-angular/renderer.ts#L101)
Unfortunately markingMode: none makes a huge difference. Otherwise I would have never deployed with it in the first place, and could simply turn it off now. The random multi-second (and sometimes minutes) long UI freezes did not make for a good user experience.

@daveware-nv, did you manage to fix your issue or are you still trying to figure out where the problem is?

Unfortunately I haven't had time to complete my sweep yet.  And I probably wont know for sure whether any changes made fixed everything until we make another release, since the crashing hasn't really shown up during test usage.
I have established some candidates to clean up however:

There's one that looks especially fishy in the couchbase plugin.
I've got some nativescript -> java interface implementations in my bluetooth plugin. But it doesn't reference java objects that aren't passed as parameters (are JS objects fine here? I'd assume at he very least the error would be different).
There's also some java objects being returned from the bluetooth plugin that I'll have to trace the path of more thoroughly.
I still have yet to look at the google maps plugin.

And of course then there is nativescript-angular` and nativescript-pro-ui, which I wouldn't know where to start looking, do you know if these have been vetted similar to tns-core-modules``?

Both plugins are usable with the current version of the android runtime, but they are not compatible with markingMode: none at least not yet.

That is unfortunate, that probably makes my efforts (and yours) here moot for the time being. So I'll probably have to advise the project owner that markingMode: none isn't supported for our applications dependencies, and see if they want to persist here or not. Do you know what the timeframe (if any) for supporting markingMode: none for those plugins is?

It doesn't really matter if the javascript objects with the native counterparts are passed as a parameter or not, except for their life duration. Unfortunately, the error you saw, will be the same no matter if the parameters are passed as arguments to a function or not.

I was mostly implying that since they are passed as parameters there must be a reference to them somewhere else (not just the method where I'm defining my interface implementation) on the stack, and hence where responsibility for managing the references to the native object are.  The other thing I was asking was whether pure javascript objects can also get GC'd early across this boundary?

Do you know what the timeframe (if any) for supporting markingMode: none for those plugins is?

We've not settled on using markingMode:none by default yet, because we're still trying out GC algorythms that wouldn't ask the developer to take care of the objects' lifetime and still be more performant than what we currently have. Unfortunately I can't give you a timeframe, because it's a very fundamental matter and needs a measure of trial and error.

The other thing I was asking was whether pure javascript objects can also get GC'd early across this boundary?

Pure js objects are dealt with entirely by V8's GC. If V8 decides it's time to GC an object, it does usually because it can't reach it in the object graph. I haven't seen cases where the pure js object is being collected early, thus causing errors. This happens only for js objects that have native counterparts like var nativeButtonInstance = new android.widget.Button() because, in the ideal scenario, the runtime needs to take care of their garbage collection.

I am getting a similar error.
Setup:

"dependencies": {
"nativescript": "^3.4.0",
"nativescript-angular": "^5.0.0",
"nativescript-drop-down": "^3.2.0",
"nativescript-local-notifications": "^2.0.2",
"nativescript-plugin-firebase": "^5.0.5",
"nativescript-pro-ui": "^3.2.0",
"nativescript-theme-core": "~1.0.2",
"nativescript-toast": "^1.4.6",
"reflect-metadata": "~0.1.8",
"rxjs": "^5.5.6",
"tns-core-modules": "^3.4.0",
"zone.js": "^0.8.18"
},
"devDependencies": {
"babel-traverse": "^6.26.0",
"babel-types": "^6.26.0",
"babylon": "^6.18.0",
"lazy": "^1.0.11",
"nativescript-dev-typescript": "^0.6.0",
"typescript": "^2.6.2"
}

Error:

com.tns.NativeScriptException: Attempt to use cleared object reference id=2263
at com.tns.Runtime.getJavaObjectByID(runtime.java:897)
at com.tns.Runtime.callJSMethodNative(Native Method)
at com.tns.Runtime.dispatchCallJSMethodNative(runtime.java:1088)
at com.tns.Runtime.callJSMethodImpl(runtime.java:970)
at com.tns.Runtime.callJSMethod(runtime.java:957)
at com.tns.Runtime.callJSMethod(runtime.java:941)
at com.tns.Runtime.callJSMethod(runtime.java:933)
at com.tns.gen.com.telerik.widget.list.ListViewAdapter_frnal_ts_helpers_l58_c38__ListViewAdapter.onCreateViewHolder(com.telerik.widget.list.listviewadapter.java)
at com.telerik.widget.list.ListViewWrapperAdapter.onCreateViewHolder(listviewwrapperadapter.java:459)
at com.telerik.widget.list.ListViewWrapperAdapter.onCreateViewHolder(listviewwrapperadapter.java:20)
...
at org.nativescript.widgets.CommonLayoutParams.measureChild(commonlayoutparams.java:262)
at org.nativescript.widgets.MeasureHelper.measureChildFixedColumnsAndRows(gridlayout.java:1055)
at org.nativescript.widgets.MeasureHelper.measure(gridlayout.java:865)
at org.nativescript.widgets.GridLayout.onMeasure(gridlayout.java:279)
at android.view.View.measure(view.java:21121)
at org.nativescript.widgets.CommonLayoutParams.measureChild(commonlayoutparams.java:262)
at org.nativescript.widgets.ContentLayout.onMeasure(contentlayout.java:32)

Closing due to lack in activity.

@Plamen5kov - I'm not sure this should be closed; as the issue still exists.
And by the way, is in the onCreateViewHolder of the ListViewWrapperAdapter,  and that actually is in the Nativescript-Pro-UI --- not his code...    So in this case the error is 100% a Telerik/Progress issue; not something he can easily fix...

@NathanaelA
It is also (most likely) due to "markingMode": "none", which is not really a supported feature. So I would say whether or not this should be left open should be related to what the future plans are regarding "markingMode": "none"

@daveware-nv -- Well, I tend to think it should stay open as long as the bug exists.  Just because markingmode:"none" causes it to happen more often doesn't mean that the normal GC doesn't cause it to happen in other timing.     I still get reports of random GC caused crashes; it isn't happening as much as it was; but once a month for a low use app is still too much.
In addition since markingmode:none hasn't been depreciated (but still in consideration(?) for a solid release); then this bug has should at a minimum stay open until it is fixed or markingmode:none is removed from the engine.

@NathanaelA
Just because markingmode:"none" causes it to happen more often doesn't mean that the normal GC doesn't cause it to happen in other timing.
That's incorrect. When marking mode is set, it changes the way GC works, so any related GC issues will be completely different.
And by the way, is in the onCreateViewHolder of the ListViewWrapperAdapter, and that actually is in the Nativescript-Pro-UI --- not his code... So in this case the error is 100% a Telerik/Progress issue; not something he can easily fix...
It's really unfortunate that you found the problem in nativescript-pro-ui, if that's really where the problem resides, but we haven't planned to make the plugins compatible with markingMode: "none", at least not yet since it's only an experimental feature, and it should be respected as such as @daveware-nv already mentioned.
In addition since markingmode:none hasn't been depreciated (but still in consideration(?) for a solid release); then this bug has should at a minimum stay open until it is fixed or markingmode:none is removed from the engine.
I closed the issue, just as I said "because of the lack in activity". We'd be happy to reopen it, should the need occur. For now it hasn't, because there's no new development on our side, nor on the current issue.
@NathanaelA If you figured out, something we haven't please share your knowledge or better yet do a PR, as you're knowledgeable enough to provide assistance to the plugin authors.

@NathanaelA

Just because markingmode:"none" causes it to happen more often doesn't mean that the normal GC doesn't cause it to happen in other timing.

That's incorrect. When marking mode is set, it changes the way GC works, so any related GC issues will be completely different.

Actually I would tend to disagree with you; I do realize the M:N totally changes the way the GC works; but if something is being collected too soon under M:N; that doesn't mean under the normal GC the issue retaining the value may also still exists and the normal GC might collect it too soon also under different memory loads.   If their isn't a proper ref to hold it; then it can be GC'd under both engines.    This was my only point; without knowing why M:N collected it too soon, doesn't mean that the normal GC won't collect it too soon also.  I still see reports weekly on the  Attempt to use cleared object reference id in the normal GC engine; so unfortunately there are still premature GC collection issues in the normal GC engine also...

I closed the issue, just as I said "because of the lack in activity".

Closed to me says nothing is going to happen with it or invalid report.
See this is where I totally disagree with this stance, you are closing a VALID bug report w/o anything done on it.   I know it looks good to management; but it is imho totally wrong stance.  This issue isn't magically resolved by you closing it; and the bug is 100% valid issue UNTIL M:N is either depreciated and removed or the bug itself is fixed.    Since M:N is still a valid experimental feature; the valid bugs that go with it should also be retained  ;-)

I'm reopening the issue as the problem is real and is not resolved. Our plans for after the 4.0 release are to focus on making plugins maintained by NativeScript compatible with markingMode: none. Cases like this one will be useful for us to validate whether we have covered all cases.

There is a pattern:
 at .    com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1386)(com.tns.NativeScriptException: Attempt to use cleared object reference id=48048
If you collect the messages between  at . and (com.tns.NativeScriptException ... it looks like:
Error: com.tns.NativeScriptException: Attempt to use cleared object reference id=48048
    com.tns.Runtime.getJavaObjectByID(Runtime.java:893)
    com.tns.Runtime.callJSMethodNative(Native Method)
    com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1084)
    com.tns.Runtime.callJSMethodImpl(Runtime.java:966)
    com.tns.Runtime.callJSMethod(Runtime.java:953)
    com.tns.Runtime.callJSMethod(Runtime.java:937)
    com.tns.Runtime.callJSMethod(Runtime.java:929)
    com.tns.gen.java.lang.Runnable.run(Runnable.java:10)
    android.os.Handler.handleCallback(Handler.java:751)
    android.os.Handler.dispatchMessage(Handler.java:95)
    android.os.Looper.loop(Looper.java:154)
    android.app.ActivityThread.main(ActivityThread.java:6780)
    java.lang.reflect.Method.invoke(Native Method)
    com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1496)
    com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1386)

    at Label.ViewBase._setupUI (<embedded>:57858:49)
    at StackLayout.ViewBase._addViewCore (<embedded>:57782:18)
    at StackLayout.ViewBase._addView (<embedded>:57760:14)
    at StackLayout.LayoutBaseCommon.addChild (<embedded>:65654:14)
    at ViewUtil.insertToLayout (<embedded>:54934:20)
    at ViewUtil.addToVisualTree (<embedded>:54915:18)
    at ViewUtil.insertChild (<embedded>:54883:18)
    at EmulatedRenderer.NativeScriptRenderer.insertBefore (file:///data/data/org.nativescript.redacted/files/app/bundle.js:45438:23)
    at execRenderNodeAction (<embedded>:9407:22)
    at visitRenderNode (<embedded>:9378:13)

Longer stack traces?

This is relevant, from the comments in the https://panayotcankov.github.io/nativescript-3.2.0-memory-management/
@gsmedley
Thanks for this clear and detailed description of NS memory management. Do you have any advice for tracking a "can't find object with id" issue?
@pana-cc
Are you using markingMode: "none" in app/package.json?
@gsmedley
Yes. I don't think there is any choice really, due to the page navigation delays without it. I'm in a couple of discussions about this on github and I've seen that there is an effort to make plugins compatible with markingMode: "none" in 4.1. In the meantime, I would like to find and fix as many of these issues as possible myself, but the stack traces I get are not really useful. So, I was looking for advice on locating the sources of the problem. The issue I'm using to report this is: https://github.com/NativeScript/android-runtime/issues/986
Thanks
@pana-cc
It is complicated, if we proceed with the execution, all errors should include piece of JavaScript callstack. The markingMode: none will keep all Java instances strong, as long as the JavaScript instances are not collectable by GC. After a JavaScript instance is collectable though, it will "revive" the JavaScript instance until the Java instance is collected. This ensures that transitions from Java to JavaScript are always possible, and crashes due to prematurely collected Java instances will always happen by executing piece of JavaScript.
How do you collect your error traces?
They don't have any JavaScript callstacks.
I have attached an image with an example error that happens due to Java instance prematurely collected, you can se the JS trace.
It is possible that there are paths that throw these "Attempt to use cleared object reference" that are not handled well, we will have to work on better error reporting for them before we can execute the markingMode: none. For example if there is any JavaScript callstack associated we should be able to display it too along the Java stack.
@gsmedley
Thanks for this. I am getting better stack traces now, and I've posted one to the issue above.
I haven't seen that particular stack trace yet. The ones I get are "com.tns.NativeScriptException: Attempt to use cleared object reference id" and "com.tns.NativeScriptException: No weak reference found. Attempt to use cleared object reference id=".
@gsmedley
Just so I'm clear about the risks of using "markingMode: none" I have a plug-in for scanning an id using the camera. I allocate a java object and pass a callback into it:
var scl = new com.kanayo.idscanner.ScannerListener(scanListener)
let scanner = new com.kanayo.idscanner.IdScanner()
scanner.startScan( application.android.foregroundActivity, view, scl );
return scanner;

Is it possible that the com.kanayo.idscanner.IdScanner object will be collected prematurely? How would I prevent it?
@pana-cc
Yes, absolutely! The JavaScript object holding ScannerListener is no longer referenced from JavaScript as long as you return the scanner, so the JavaScript instance may be collected by V8, and then anything kept in scanListener's properties or closures will be eligible for collection.
There are pretty much 3 cases I've met so far:

Global listeners that are assigned and expected to be alive for the lifetime of the application. (Like listening for push notifications) These listeners are best kept in module variables, and these variables should be accessed by exported member of the modules. (this has room for improvement, it would have been better to keep these on the module., but currently the runtimes hold only the exports object alive).
{N} View classes - any native views or listeners should be kept in private properties on your View class so the lifetime of its native objects will be tied to the JavaScript View instance.
Short living listeners (like the one in your case). When you create such listeners you have to store them in a Map or Set that is kept alive in a variable in the module and this variable is accessed in exported module member. Then when the listeners fire (like the setTimeout implementation), or if they are no longer observed (you can create observable and override add/remove listener, so when javascript event listener is added you can create the native listener and when all JavaScript listeners are remove - remove the native listener form the Map/Set), or are explicitly stopped (like the implementation of setTimeout/clearTimeout) - unsubscribe the native listeners and clear them from the map.
I can give you further directions if you share the public API of this scanner module. Does it export an observable or perhaps a start() stop() pair?

@gsmedley
Thank you - this is really great information!
The scanner's Java API, it's Android-only, looks like this:
public interface ScannerListener {
void success( String scannedId );
void error( String errorMessage );
}
public class IdScanner {
public void startScan(Activity activity, View view,
ScannerListener listener,
String candidateExpression, String verifyExpression,
String checkSumClassName,
String direction, String flashMode );
public void stopScan();
public String changeCameraDirection();
public String toggleFlash();
}

You call startScan() - it shows the camera in the view, then calls back when it scans an id. From there you call stopScan(). We have a couple of buttons on the page to toggle the flash and switch the camera and cancel the scan.
To protect the ScannerListener JS objects we could put them in an array that is exported from the module, then return the array index to the caller. When the caller calls stopScan() it should have the index as a parameter so we know which listener to free up. Does that sound right?
Would it work to return the scanner and the listener together, like:
return { scanner: scanner, listener: scl }
Thanks again for all your help with this.
@pana-cc
Great, pretty much that's it.
One last thing, simply returning the scanner and listener will move the responsibility for the lifetime of these from the module developer to the application developer. Plugin developers must avoid this.
In your particular case it would be nice to create and return a good object model when "start" is called, it can have the scanned and listener in private fields, expose stop, changeCameraDirection, toggleFlash etc. but also keep that returned object in array in the module until its "stop" is called, where the listener and scanner are stopped and safely disposed.
That way app developers don't have to worry about object lifetimes and will continue writing JavaScript care free the way they were used to, limiting the impact of markingMode: none to plugin developers only.
@gsmedley
Thanks so much for the advice! I've converted our plugins to follow this model and have not seen a "can't find object with id" crash yet.
I've been running monkey tests pretty much non-stop, but haven't gotten past 2 days continuous running due to a couple of crashes.
There is one very odd crash we are seeing in the RadChartView and I'm wondering if it is related to your point #2 "({N} View classes)" above. After running thousands of the same graphs there is suddenly a ClassCastException in code that for which that looks impossible. It's this issue: https://github.com/telerik/...
@pana-cc
I don't have access to the pro-ui code at the moment, I have to reset some two way authentication tokens to get it. But the error seem to be thrown in pure Java code, something like wrong type cast. I've talked with some people internally to rise that issue's priority.
@gsmedley
Thanks so much for doing that! At the moment this is our only blocker. With the graphs excluded we've been running monkey tests for 4 continuous days without a crash.

After 5.1 all plugins owned by the NativeScript Team should be compatible with the markingMode: none option in their latest versions. I see that the app in question is using the nativescript-pro-ui, so upgrading to the latest packages of the nativescript-ui-* might help partially for this issue as well.

I see Attempt to use cleared object reference often as well.
I am using these:
        "nativescript-angular": "~7.1.0",         "nativescript-exit": "^1.0.1",         "nativescript-ng-shadow": "^2.1.0",         "nativescript-orientation": "^2.2.1",         "nativescript-svg": "^1.3.7",         "nativescript-theme-core": "~1.0.4",         "nativescript-ui-dataform": "^3.10.0",

Is there anything useful in the stack traces for these crashes?

Sorry for the delay I was absent for a few weeks.
I have an update how the issue was solved on my end. I upgraded native script/angular/ts to the latest ones as describe in here: https://docs.nativescript.org/releases/upgrade-instructions and the issue was magically solved.
Now instead of app breaking and "attempt to use cleared object reference" exceptions I am receiving different exceptions very benign ones: JS: Error in downloadBitmap - java.io.InterruptedIOException: thread interrupted

I has the same error message:

Error in downloadBitmap - java.io.InterruptedIOException: thread interrupted

My package.json:
"nativescript-angular": "^7.2.1",
"tns-core-modules": "^5.2.0"
My app has a List which contains posts, post will have image. So when scroll down and up quickly, this error will show.
I did some searching and see that it may relate to http requests in java code. Here's one the results I found: https://github.com/square/retrofit/issues/844. Not sure relate to this or not.

You can try with android@next if you can easily reproduce the error to see whether the pull request above fixes it.

@jpierront Please notice that before NS 5.3 this exception occurred after short period of time after the app launch (2-3 minutes). Now it occurs after longer period, maybe after 15 minutes of the app working.

@jpierront - Is their an option we can add to the Android engine to actually track what type or what declared the missing object.    So in the debug version of the engine, we have a tracking table that sets object 1511 =  Android.Context:35:main.js  -- I realize this table could become large; but if it cleans itself up say 10 minutes after the item is freed it would help track down what exactly is not being retained....      So when this error is thrown (1511 reference is not found) it can print out what the reference was support to be to, to help debug the issue.

The table will not become too large as it has to keep trace of what is the JavaScript class and where it is declared for a Java instance. So when the JS instance is collected you have to write up in the table debug information for the Java instance. That information can be stored in weak dictionary for example that will be cleared when the Java instance is collected.

Well, to be honest; I would prefer the table to stay around a bit longer than when the java object is collected; because we don't know when the reference for that object will be attempted, and that is when we need to be able to print off the info for the reference.  ;-)
Seems like 10 minutes is probably a safe number, but it could be something that is configured maybe in the json to allow this table to grow forever or x number of minutes it is cleared.   Because their might be reference items that get cleared and for some reason don't get hit for more than 10 minutes...   Or maybe it is just a special version of the runtime (that I have to compile w/ extra flags) that enables the table; w/o any clearing of objects.        I have these popup in my app; and 99% of the time I haven't a clue what reference it could be talking about...  :-(
This in my mind is currently the hardest crashing issue in NS to debug...

When Java is calling a method and a reference is passed that... the Java instance has been collected? That throws null reference exception, right? It will not try to marshal it to its JavaScript instance. But I agree that we need very good error reporting. When these errors occurs we often have the Java instance and can provide information from it as well as full stack trace sandwich and if possible the JS class source...

You probably know better than me; I haven't looked at that section of the code for years.  :)
I thought what was happening is that:
Marshaling occurs; it created a new java object; this object is stored in an Java holding object map and then the id of the object is then tagged onto the JS object that is returned back to JS.   When something that uses that JS object gets passed back into the Java side; it looks up the ID -- and somehow this id has now been cleared by a GC pass at some point.  And this is where the issue occurs is that the ID (Java side of the variable) is now gone...    So, bam  Attempt to use cleared object reference id=1511 occurs.   Have I been misunderstanding what this error message means?

@NathanaelA gentle reminder, in case you've had a chance to look at this.

@NathanaelA I would also love to see this resolved since NS is so awesome!

@NathanaelA error still exists.

@ivandejesus See https://github.com/NativeScript/NativeScript/issues/7867 for a possibly working hack if you are in this case :)

Great... !!! I also encountered this kind of bug using one image inside each item of a RADListView while scrolling fast up or down... Is there a way of handling image differently to avoid this kind of error ? Or just don't use RadListView anymore ? Thanks for help.

@lostation provide a demo application that reproduces the issue so we could investigate further.  Simply using a RadListView with a lot of images is not reproducing the issue on my side - are you sure you are not using other elements/layouts/plugins inside the item templates?

Hi,
Thanks for your reply.
No unfortunately, I’m not authorized to put a demo example.
But really it’s nothing fancy at all… it’s a regular RadListView as described into Nativescript docs for Angular.
I’ve just added a  tag into the list item into a GridLayout, there’s no external plugin or whatever.
If I remove the image it works just fine…so it’s clearly linked to a nullable element at mobile platform side.
If I turn markingMode to full it also not crash anymore…but indeed poor performance after some times.
I’ve also tried using a simple ListView component (not radlist)… but it’s the same scroll behavior behind…If a scroll too fast..then randomly it will crash the app.
BUT,… If a put a simple Gridlayout as a wrapper around the Image tag with a *ngIf directive to verify if src can be fulfilled it seems to not crash anymore.
So If no src data … no Image element into the template and no link to android glide or Picasso adapter or something.
I will continue with that fix…and let you know If I get other JNI crash from android.
Thanks anyway.
Lo.

Le 17 févr. 2020 à 10:39, Nick Iliev<EMAIL_ADDRESS>a écrit :
@lostation https://github.com/lostation provide a demo application that reproduces the issue so we could investigate further. Simply using a RadListView with a lot of images is not reproducing the issue on my side - are you sure you are not using other elements/layouts/plugins inside the item templates?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/NativeScript/android-runtime/issues/887?email_source=notifications&email_token=ACX5G6WPDYHXZWDKH3UWLIDRDJLMZA5CNFSM4EFXU3VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL5WUHY#issuecomment-586902047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACX5G6WUZJN5DTPV5HX4WE3RDJLMZANCNFSM4EFXU3VA.


[DOC] Workaround for long inlined code sample in config page

:mag: Description
Issue References 🔗

Describe Your Solution 🔧
Workaround to fix the display issue of long inlined code sample on config page.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:

Behavior With This Pull Request :tada:

Related Unit Tests

Checklists
📝 Author Self Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[x] Pull request title is okay.
[x] No license issues.
[x] Milestone correctly set?
[ ] Test coverage is ok
[x] Assignees are selected.
[x] Minimum number of approvals
[x] No changes are requested

Be nice. Be informative.

Thanks for fixing up, merged to master


Add access token validator support

Tests are failing, but I've gotta go pick my daughter up from her ski camp, so I'll get them passing on Linux on Monday.


Number validation

Makes it so that negative numbers cannot be entered during Item Create or Item Edit, and the Quick Changes do not go past 0.
Closes #3

I don't quite like how the modal doesn't pop over the main window, but will need to figure that out at another time. Keeping the quantity at or above 0 is most important.


Seek for cooperation

Recently I'm working on my thesis,and I'm desperately for joining thuml,seek for cooperation in my thesis,if it's convenient for you(It's up to you~)

If it's convenient for Mr.wu,I leave a message at you Zhihu,and hope for deeper communication.

Hi, you can connect with my advisor Mingsheng Long (http://ise.thss.tsinghua.edu.cn/~mlong/) for details.

appreciate for your response.


Specify 0 vs 1 based indexing within BIDS

Problem
The  sample column in events.tsv encodes the following:

OPTIONAL. Onset of the event according to the sampling scheme of the recorded modality (i.e., referring to the raw data file that the events.tsv file accompanies).

As identified by @robertoostenveld, we do not specify whether we use 0-based or 1-based indexing
This should be clarified.
potential solution
I feel like going with 1-based indexing would make sense if most recommended data formats that also encode samples go with it. For example, most EEG data formats have a representation of "samples".
(BrainVision uses 1-based sample indexes in their datafiles (page 14 in the spec)
How about data formats in iEEG and MEG? ... is this relevant for MRI or other data types?
There is also the argument that many people are not familiar with 0-based indexing.

It could be relevant to MRI, though it's unusual. I would interpret this as a "volume index" instead of event onset in seconds, and so I would be heavily inclined toward 0-indexing because that would be how you index a multidimensional array in pretty much everything but MATLAB.
My top criterion would be consistency. Within the standard, we should either always use 0-indexing or 1-indexing. I don't know that we currently have a situation where we impose one or the other, but if we do, we should stick with it. If we don't, again I would advocate 0-indexing for simplicity's sake.

just some fyi: run and echo have indices but no base is specified. most datasets i have seen use 1+. there is mention of slice index 0 in a piece of bids.

Most iEEG datasets I have used are also 1-based sample indexes.

Re @satra's comment:
Right, the <index> values in filename entities are just numerical. They aren't even required to be sequential, so I wouldn't consider them to be precedent for either option.
Here's the "slice index zero" text:

A - sign indicates that the contents of SliceTiming are defined in reverse order - that is, the first entry corresponds to the slice with the largest index, and the final entry corresponds to slice index zero.

I think this could be changed to "the slice with the smallest index" without losing any specificity, as we encode a series of values and not their indices, so I also wouldn't consider this precedent.

Hi all, chiming in on this issue to say I would love it if the BIDS spec was explicit about the starting position for the onsets sample column. Given that this is described as an onset, I think it should start at 0 not 1. If we had an event at time 0seconds the resulting onset in the units of a functional MRI would be 0 as well. At least, this is convention when modelling data using onsets in "scans" in SPM.

Triggered by @VisLab's comment in #1043, I am reading this again. There are two problems:

the concrete problem of how to interpret the optional sample column in events.tsv
the general problem that nowhere in the BIDS spec do we specify a consistent rule of which indexing to use (0+ or 1+)

Regarding 1.:

OPTIONAL. Onset of the event according to the sampling scheme of the recorded modality (i.e., referring to the raw data file that the events.tsv file accompanies).

Reading this again, I think our current rule means that the same indexing is to be used as in the raw data file. For example BrainVision EEG data files use 1+ indexing (section 4.3, second sentence in their data format specification), so obviously having a 0 in the sample column of an events.tsv file that is paired with a BrainVision EEG file does not make any sense.
However, this is still problematic when the events.tsv file is relevant to multiple neuro (or physio / beh) data files, if they use different indexing styles (0+ or 1+)
And furthermore it does not address the general problem that we don't declare an indexing style across BIDS. I am not sure whether we could even do that in a backwards compatible way. Perhaps the most we can do would be to introduce a new metadata field at some meaningful level that could advertise 0+ vs 1+ indexing, and RECOMMEND that field.
It's all a bit unsatisfactory.


Feat/old nano walletconnect

Please go the the Preview tab and select the appropriate Pull Request template:

Feature Branch - Use this template when you are creating a feature branch pull-request
Version Bump - Use this template when you are creating a version bump pull-request
Release Candidate - Use this template when you are starting a new release-candidate process

This is the old hathorplay, it is now in hathorplay-base


SQL source support

Add functionality to load data from SQL database like Spark DataFrame API.
The API should be like seq.sql(con, sql_query)

I first added initial test implementation for only SQLite3 since it does not depend on external library.
I can add support for many SQL databases with SQLAlchemy but is it OK to add additional dependencies?

Current coverage is 100.00%

Merging #55 into master will not affect coverage as of b19cd32

@@            master     #55   diff @@
======================================
  Files            9       9
  Stmts         1365    1393    +28
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1365    1393    +28
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of b19cd32

Powered by Codecov. Updated on successful CI builds.

Thanks @lucidfrontier45! Great work for using SQL!
Few changes (I'll comment in diff too)

If we create the connection, we should clean it up using the with context manager
It would be a good idea to pass additional arguments on to the function itself as are done with the other input streams. Might need to use a combination of *args and **kwargs to catch everything. Hard to tell from the docs if all the extra parameters are named or not without testing it.
Pure bonus, but showing off the feature in the README would be cool.

On adding SQLAlchemy, in general it would be nice to be able to access any database. It is however a big dependency and most of the time it wouldn't be used. Fortunately, I think there is a relatively easy way around this.
For example, Spark lets users do to_df to write a Dataframe to Pandas Dataframes, but doesn't enforce a hard dependency: https://github.com/apache/spark/blob/962e9bcf94da6f5134983f2bf1e56c5cd84f2bf7/python/pyspark/sql/dataframe.py#L1329-L1341
I would propose using extras_require to define a sql extra dependency list. To improve the user experience a little I would also catch the ImportError, print something to the effect of "To use SQL run pip install scalafunctional[sql]", then re-raise the error.
In any case, I would keep this PR to adding just sqlite3 since its almost good to go. If you are interested in adding support for SQLAlchemy, then create an issue for it, copying anything relevant from here, then create a new PR. I would also be curious on how easy it is to write to sqlite3. Seems like with cursor.execute() it would only require passing a valid SQL statement and sequence of tuples that match the ? parameter list.

@EntilZha
I modified my PR according to your advice.
Writing to sqlite won't be complex if we can supply insertion SQL like below.
the_seq.to_sqlite3("db_path", "insert into test_table (id, name) values (?, ?);")

However, API without query like pandas' to_sql needs some work.
the_seq.to_sqlite3("db_path", "table_name")

For inserting, the first example seems fine to me. The reason Pandas can do the second one is that it works with structured data for which it knows the types/names. The second query would get translated to something like insert into table_name (col1,col2....) values (?.....); where the columns come from the DataFrame's columns.
The second call could be fairly useful and not too difficult to write. Since we don't keep track of columns, in order to do something like this we would have to enforce that the sequence is a sequence of Tuple/namedtuple/List/dict of the same length/form (for dict this would require a scan to determine all dict fields since that is more friendly than every dict having every column, for list it would require getting max length list). Following that, we could do our best to infer the names of the columns for insert into test_table (id, name) values (?, ?) (from namedtuple._fields or scanning for dict fields) or give up and use insert into test_table values (?, ?).
The second requirement would be to check the input string against a table name regex to determine what should be done.
PR looks good to me to merge. Great work! Think you might work on the to_sqlite3 or SQLAlchemy ideas?

I'll work on to_sqlite3 first. Maybe start with looking in to_csv. CSV is also a fixed column data type as sql.


Timing Description [IG]

Once the examples have been updated, add further description to the IG on the manner in which the Timing class and Instance class operate
See comments in JIRA tickets:

JIRA DDF-453
JIRA DDF-452

@dih-cdisc : created UML picture for timeline:

@BSnoeijerCD looks good, nice and compact

Updated UML to align with IG on referencing epoch. See IG which is updated and ready for review: https://wiki.cdisc.org/display/USDMIGv3/Study+Timing


Removing download

Steps to reproduce
https://user-images.githubusercontent.com/86203009/198891006-4aedc944-7280-4cf9-8f0f-a151e16c31cf.mp4

Download a chapter
Remove downloaded chapter

Expected behavior
Immediately download should only be seen when downloading a chapter.
Actual behavior
Immediately download also appears when removing a chapter.
Crash logs
No response
Neko version
2.11.3
Android version
Android 10
Device
Oppo A5s
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to the newest version Latest.
[X] I have filled out all of the requested information in this form.

2.11.5

Bug still happening on the recent update
https://user-images.githubusercontent.com/86203009/201073688-fe98262d-ce07-46a9-b06a-2939ae1a2c35.mp4

should be good in 2.11.6


The same content in new Editor component (use many editors on the page).

I have a problem with using many Editor components on the same page. The problem is with the content of editor. I have one, page component, which has content as an array in the state. Every time when I change the text inside a Draft Editor I use UpdateState for updating my content and paste new text for the existing array key value.
Also, I have a push-button, which creates a new array element and inserts it with the splice JS method to the place where it has been previous editor (so new editor gonna be first and previous editor gonna be on second position in the array).
After creating a new array element it calls Update state also to update and rerender array.map function and call extra new Editor components for each iteration.
Every editor component works great but I have difficulties with content: every new editor has exactly the same default content as the previous components.
Can I do a hard rerender of all components when the content state is changed or something? Because I think its problem with state, existing content have old content inside state and after I changed something in the content array and call new editors - previous is still have old content in their state and not update it with given props (as the default value).

I find out, it was a problem with React, not with Editor. I give an array key as key property to JSX component inside array.map function, so after my array changes - indexes were the same and state content was the same for each component.


Support alternative crate registries

Implementing #57.
Currently, this is a breaking change for users of AsyncClient::with_http_client() and a change to types::User::url.
@theduke, is making this a breaking change acceptable and are you happy with the API changes I am proposing in this PR?
I've added support for authenticating via a token with an alternative crate registry.

@theduke Would you be able to look at the PR and review my proposed method of implementing alternative registries?


WIP: dokka upgrade

Can't do this upgrade until this issue is fixed: https://github.com/Kotlin/dokka/issues/1405
Even with the memory settings in this PR, attempting to dokkaGfm fails with metaspace/OOM.

This PR combines the Kotlin 1.5 upgrade as well as they are intertwined.


refactor(elements|ino-switch): remove color-scheme prop

Closes #707
Proposed Changes
-removes the color-scheme property of the ino-switch component

One thing I noticed: The height of the disabled and non-disabled ino-switch is minimally different. See:

We should set a fixed height (the height of the disabled one), to prevent these jumps. Could you do that in this PR as well?


Outdated modules of multus-cni test

Bug Report

Multus-cni's test go module still refers to some outdated modules. We better remove the outdated modules and use the latest ones.
Expected Behavior
Remove outdated modules

Steps to Reproduce the Bug

go mod tidy will generate a diff for the modules related file

Screenshots or additional information and context

Environment Details

Build version (tanzu version):
version: v1.4.0
buildDate: 2021-08-30
sha: c9929b8f
Deployment (Managed/Standalone cluster):
Infrastructure Provider (Docker/AWS/Azure/vSphere):
Operating System (client):

Diagnostics and log bundle

Related - #2453


Sticky Headers

Any plans to implement sticky headers, so when you scroll you still see the column/group headings?

Hopefully yes! Ill keep this open for now as a reminder that I need to implement this :smile_cat:

This has been release with v1.0.0-beta.0. Feel free to test it out 😸
Please note that there have been some structural changes and there might be even more in the near future (hence the beta)