Set a height equivalent to a grid items width before its content loads

This should fix the jump on load issues with the playlist JPGs.
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

[ ] PR title accurately summarizes changes
[ ] New tests were added for isolated methods or new endpoints
[ ] I opened an issue for any logical followups
[ ] If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

[ ] Update title and description to account for additional changes
[ ] All tests green
[ ] Booted up the branch locally, exercised any new code
[ ] Percy changes are purposeful or explained
[ ] Css changes are happy on mobile (via Percy is ok)

WOo!


Browser New Tab Extension?

Hi there, just wondering if there's been thought about turning this into a browser extension? It would be pretty helpful if every time a new tab is opened I can jump to my Linkdash list immediately.
Or even better, somehow incorporate it as part of the address bar?

Hi @thebrucecgit - glad you've thought about bookmarking linkdash! (I'm honoured to hear that!).
Thinking version one - the quickest way is to output the html file, open it with your browser and set tabs to open to that url (or host it for free on https://zeit.co) so you can add a bit of logic to your links.
I'll do a bit of research to see possible options, it would be  to have a context-aware browser extension. I could imagine importing bookmarks, adding on the fly and even sharing your lists with others. Thanks for the thought!


docs: Update cockroach to v23.1.11

Sample docker-compose does not work until cockroach is updated to v23.1.11.
https://discord.com/channels/927474939156643850/1166399185021567106
Definition of Ready

[x] I am happy with the code
[x] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[x] No debug or dead code
[x] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[x] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

The latest updates on your projects. Learn more about Vercel for Git ↗
Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 24, 2023 5:17pm

Verified that yaml is rendering as expected at relevant page.

Thanks for the fix @epvanhouten :rocket:
Not sure why, but I can't check out your PR branch.
Would you mind updating following occurences, too?

https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/deploy/loadbalancing-example/docker-compose.yaml#L45
https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/deploy/macos.mdx#L14
https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/deploy/linux.mdx#L15
https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/deploy/macos.mdx#L14
https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/manage/configure/docker-compose.yaml#L22
https://github.com/zitadel/zitadel/blob/1fafefc2c1f89b7f1aefee4f5454cf0217218383/docs/docs/self-hosting/manage/configure/docker-compose.yaml#L39

Closing this PR in favor of https://github.com/zitadel/zitadel/pull/6803


reconsider x hackery

We still have some hackery for the x element from the earliest days.
https://github.com/AmerMathSoc/texml-to-html/blob/964ecee31024a57580a666f904aca8972ccb0951/lib/elements/x.js#L23-L24
(which will change slightly in #443)
Let's consider mapping x to some HTML element and let downstream delete those it doesn't like.

With texml generating more x elements, we need to move on this. In particular, statement titles will now wrap their parens in x elements - and we don't want to loose those in articles.

Besides some lingering texml issues, I'm running into trouble dealing with x inside tex-math, i.e. ref/cite in math mode.
Right now, downstream journal content wants everything removed but the comma inside cite-detail. We could preserve enough markup but then our tex-math output will not be straight forward to use with MathJax (then again, it formally isn't right now either since we don't provide delimiters). Otherwise, we'd need to keep hacking x elements here (i.e., look up xml nodes).
So

expose cite-detail and x elements inside tex-math (and move a small bit further away from a mathjax-compatible output)

then downstream adjusts those as needed

add tex-math specific logic for x elements, including our custom needs for journals

Right now I'm leaning towards option 1.


[QUESTION] Does DS support  supplementary data by hour or minute?

Describe the question
Does ds support  supplementary data by hour or minute?
I  find nothing in relase notes , bug list and feature list  but this pr https://github.com/apache/incubator-dolphinscheduler/pull/1811, but I don't know which version I can use this feature.

@zixi0825 , could you answer this issue?

In the dev branch, if you do not have a scheduled task online, the complement will only be based on the date. For example, if you choose the range from 2020-04-01 to 2020-04-10 to complement, then the complement will be from 2020-04 -01 00:00:00 starts to 2020-04-10 00:00:00 ends. If you have a scheduled task online, the cron expression of your scheduled task will be parsed, and the corresponding execution time will be generated. For example, your cron is 5 6 * * *? *, And the date selection range is 2020-04-01 to 2020-04-10, then the execution time is 2020-04-01 01:06:05. 2020-04-01 02:06:05, 2020-04-01 03:06:05. . . Until the end
在dev分支，如果你没有上线定时任务的话，那么补数只会根据日期来，例如你选择了2020-04-01到2020-04-10这个范围来补数，那么补数会从2020-04-01 00:00:00开始到2020-04-10 00:00:00结束。如果你上线了定时任务，那么会解析你的定时任务的cron表达式，然后生成相应的执行时间，例如你的cron是5 6 * * * ? *，，日期选择范围为2020-04-01到2020-04-10，那么执行时间就是2020-04-01 01:06:05。2020-04-01 02:06:05，2020-04-01 03:06:05。。。直到结束

Thanks, dev branch can't use in product enviorment, expecting the next release

version 1.3.2 had solved the problem


Initial seeds sometimes not traced correctly

The feedback bitmap obtained from qemu is sometimes empty. When starting with only a few seeds, the corresponding inputs are discarded and we end up with an empty queue and execution is stalled.
kafl_fuzz.py will detect and warn about this behavior. Simple workaround is to manually copy the desired seed to $workdir/imports/ where it will be picked up and imported as a new seed on the next scheduler iteration.
The behavior seems sporadic and often disappears after a few attempts to debug.. :-/

Better workaround. Still not pretty but better than throwing random seeds at the target and hoping that something lands in the queue. Still not clear why this is happening..
diff --git a/kAFL-Fuzzer/common/qemu.py b/kAFL-Fuzzer/common/qemu.py
index 1a5d379..834536f 100644
--- a/kAFL-Fuzzer/common/qemu.py
+++ b/kAFL-Fuzzer/common/qemu.py
@@ -466,6 +466,10 @@ class qemu:
                 self.shutdown()
             return False

+        self.set_payload(b'')
+        res = self.send_payload()
+        assert(res.is_regular()), "Target failed to execute an empty payload. Please fix the harness."
+
         return True

     def __qemu_handshake(self):
diff --git a/kAFL-Fuzzer/fuzzer/state_logic.py b/kAFL-Fuzzer/fuzzer/state_logic.py
index 2a3d802..5dbb56d 100644
--- a/kAFL-Fuzzer/fuzzer/state_logic.py
+++ b/kAFL-Fuzzer/fuzzer/state_logic.py
@@ -158,6 +158,7 @@ class FuzzingStateLogic:

     def handle_import(self, payload, metadata, retry=0):
         _, is_new = self.execute(payload, label="import")
+        _, is_new = self.execute(payload, label="import") # try again?

         # Inform user if seed yields no new coverage. This may happen if -ip0 is
         # wrong or the harness is buggy.


Feature/6 vendor libs

PR contains few CMakeLists.txt changes:

Now cmake requires the Boost 1.74 or newer;
Also cmake automatically downloads and links nlohmann_json with our project.

P. S. CI fails due to incorrect image on DockerHub.

P. S. CI fails due to incorrect image on DockerHub.

Fixed


Debugging Wave Output Without Scope

I'm trying to send out a square wave using pigs and don't appear to be getting the right output.  Is there a way within pigpio to see what is happening, without having to connect an oscilloscope of some kind?
This is working for me to generate a square wave, which is audible as a noise as I hear my device on a relay rapidly toggling:
for ((i=0; i<100; i++)); do pigs w 4 1; pigs w 4 0; done

This is not working for me; I do not hear the device toggling, which indicates the timing is not what i expect:
pigs wvag 4 0 25000 0 4 25000
pigs wvcap 50
pigs wvtxr 0

Additionally, this is not working for me; I do not see any output while either of the other commands are running:
pigs no
pigs nb 0 0xffff
pigs2vcd /dev/pigpio0

I have built pigs and pigpiod from git master.

For a visual use piscope.
http://abyz.me.uk/rpi/pigpio/piscope.html
For a listing look at monitor.py
http://abyz.me.uk/rpi/pigpio/examples.html#Python_monitor_py
When using waves make sure you set any GPIO you use to outputs.
N.B. waves use bits to identify the GPIO (remember multiple GPIO may be set/cleared in each wave triplet).
pigs m 4 w
pigs wvag 16 0 25000 0 16 25000
Generally for GPIO x.
G=((1<<x))
pigs wvag $G 0 25000 0 $G 25000

Thanks so much, it was totally using bits in the wave generation.

@joan2937 so you know, monitor.py also does not work on output pins.  it seems it is best to do some wiring if debugging on output pins is needed.

@xloem monitor.py works on all GPIO regardless of their mode.  Why do you think it does not work on output GPIO?

I received no output for pins set to output, when I drove them, same as the behavior of the notification events above.

@xloem If you have time can you give an example showing the problem.  I'll try it on my Pi.


Generate systemd scripts

This will be most useful for finishing off an install.

Check the config for a redis backend, and look for the associated redis service
Global vs local service scripts -- how to name?

We will leave it to the user to install the service files. At a later point, if we do debian packages, those can install the scripts for the user.

Added proof of concept in 57c3829. Seems to work well so far.


Support additional criteria in store.delete to support (hash_key, sort_key) type models

This PR makes Store.delete() behave more like our default Store.retrieve() in allowing optional additional criteria.
This is needed in DynamoDB land where tables which employ both a hash_key and a sort_key always require both for
look up on a specific row.

LGTM


Rename the file 'how_to_see_documenation.txt' to 'how_to_see_documentation.txt'

No more info here.

Done


[mux] A monitor for wistia_77 has not been initialized.

I am getting the following error: [mux] A monitor for wistia_77 has not been initialized.
Nuxt.js is the frontend tech that we are using. I have reached out to Mux and received the the following response.

Wistia uses our product to track the performance of their player and system, and that is a result of some of their code trying to track a specific event in the player, without first initializing our library correctly. The player may work fine, but something in their player is not working like they expect it to. Sorry to bump you over to Wistia, but without access to their player code, there's not much I can do.

Please let me know how to move forward on how to resolve this issue.

Hi @cory4patriots, I asked our support team if they received a report on this at<EMAIL_ADDRESS>and they said yes. I'm closing this GitHub issue because it's not related to our wistia-api ruby gem, but you should expect a response to this issue in your email. Thanks!

@MaxPower15 Any chance you can share the solution, please? I am getting the same issue

@pm-radu I didn't track that ticket myself and don't know what the ultimate solution was. That said, having very little context, my suspicion is that it is caused by rapid re-renders in the virtual DOM. When that happens, the Wistia video elements get clobbered and cause it to reinitialize before it finishes setup. It can be solved in frameworks like React (and I assume Vue, too) by wrapping the video in a component that prevents updates, i.e. shouldComponentUpdate() { return false; }. If that doesn't sound like it would be related to your situation, I'd recommend also sending an email to<EMAIL_ADDRESS>They'll be able to take a closer look at your specific situation and escalate to engineers like me if they need to.


Simplify multiple devcontainer creation process. Allow multiple devcontainer.json ,we should be able to select any json and create dev container.

Currently it allows a single devcontainer.json file per .devcontainer folder.
This will give limitation of creating one devcontainer. Multiple devcontainer
Instead in .devcontainer folder allow to have multiple devcontainer.json file. Also provide the menu option by right clicking json files we should be able to create devcontainer.
For example , consider below as the folder structure
.devcontainer
    devcontainer.json
    devcontainer_2.json   (it will have different dockerfile)
    devcontainer_3.json  (it will have another different dockerfile)
    devcontainer_n.json  (it will have another different dockerfile)

devcontainer.json ->  This is default one which will be used to created dev container when we click 'Reopen in container' menu.
devcontainer_2/3/n ->  If we right click, there should be a menu showing option 'Create devcontainer'. If I click it then devcontainer enviornment should be prepared using this file. In this file I would point to different dockerfile which contains my proxy settings and extra packages and softwares required for testing.
So multiple container creation process would be simple.

It should be much more coherent with Github Codespace. And also cleaner than one repository for each at the root level.
Github Codespace recommends the following structure:
(or one per subfolder, but default container must directly under .devcontainer)

Then, Github Interface allows choosing a container:

Or in VS Code:

But it's impossible with Visual Studio Dev Container, only the default container is allowed.

Tracked as https://github.com/microsoft/vscode-remote-release/issues/7548. Thanks.


steam-small: init

A steam variant without game specific libraries to have a smaller
footprint on systems where people don't need or want the full blown fhs.

[ ] run nixpkgs-review
[x] open and update steam

Result of nixpkgs-review pr 216972 run on x86_64-linux 1

13 packages built:

kodiPackages.steam-launcher
lutris
minigalaxy
playonlinux
protontricks
steam
steam-run
steam-small
steam-tui
steamcmd
wpsoffice
wpsoffice-cn
xivlauncher


feat(Result): Expose value or error if it is save to expose

This PR proposes two Type-Guards, allowing to safely access error or value of a Result.
This should improve the Ergonomics of the Result-API.
hasValue
// instead of
if (result.isSuccess) {
  const value = result.getValueOrThrow();
}

// do
if (result.hasValue()) {
  const value = result.value; // value is accessible because the type-guard has been executed before
}

hasError
// instead of
if (result.isFailure) {
  const error = result.getErrorOrThrow();
}

// do
if (result.hasError()) {
  const error= result.error; // erroris accessible because the type-guard has been executed before
}

Some notes

I needed to introduce two new Methods because Type-Guards are not usable with Getters (reference: https://github.com/microsoft/TypeScript/issues/7150#issuecomment-186357555)
Changing the existing getters isSuccess and isFailure to methods would introduce a breaking change.
Personally, I would love to use isSuccess() directly. Maybe this could be a breaking change for the next major release.

Thanks for the contribution! I'll get a new release pushed out soon.


Is there a way to use the generated views in a super class of the Context?

We have a DB first context like AcmeContext : DbContext, which is automatically created. We then have a superclass of this with our customisations SuperAcmeContext : AcmeContext. However, the superclass cannot access the generated views because they are sealed.
I think if the views were not sealed OR the DbMappingViewCacheTypeAttribute allowed for a parameterised type then it would work. For example [assembly: DbMappingViewCacheTypeAttribute(SuperAcmeContext,...)
Any ideas if there is a workaround?

@andrewrimmer Interesting issue.
DbMappingViewCacheTypeAttribute is part of EF, rather than part of this solution, but also there are some other issues around this, I think.
Unless your SuperAcmeContext had no other views applicable, then the hashvalue of that context wouldn't match, and thus the ViewCache class, sealed or not, wouldn't apply.
Also, the code that maps an entity set to the view, probably wouldn't have the same extentName (EntitySetBase.EntityContainer.Name), so the lookup for GetView wouldn't return the view for the extent.
If the above 2 statements aren't true - that is to say the viewcache actually could be applied to the super context, then simply copying the generated assembly line should work.
You can find the generated class in obj/{Configuration}/{Framework}/EntityViews/{ContextName}.Views.cs
In the sample, you could copy
[assembly: DbMappingViewCacheTypeAttribute(
    typeof(NETFrameworkConsoleApp.Models.SchoolContext),
    typeof(Edm_EntityMappingGeneratedViews.ViewsForBaseEntitySetsaab09e5eb90351ea824967d0dbafd1ab1e408f8dabd87afd5f62c4ce1ef9def7))]

out of the generated file and into your SuperSchoolContext
[assembly: DbMappingViewCacheTypeAttribute(
    typeof(NETFrameworkConsoleApp.Models.SuperSchoolContext),
    typeof(Edm_EntityMappingGeneratedViews.ViewsForBaseEntitySetsaab09e5eb90351ea824967d0dbafd1ab1e408f8dabd87afd5f62c4ce1ef9def7))]

The fact that the class is sealed shouldn't make any difference here - you are not altering the class in any way as it is an assembly level attribute.
The only other alternatives I can see, are:
To use a technique like the samples do, to dump the edmx for the super class, and generate the views for that instead.
Or if there is a way to override the way your AcmeContext is 'automatically created'?
If you could make that class a partial class then you wouldn't need your super class, you could move all your SuperAcmeContext code into a partial class file that wouldn't be overwritten by your generation step, and it would merge on compile.

@andrewrimmer
Just did a very quick check and the context name is included in the EntityContainer, the Views include the context name, and the hash is different for a super class with no other code in it, so I don't think there is a way to share the views between them.
I would suggest you go with dumping the super-class's edmx and generate the views for that.
The only other suggestion I have, would be to use the package EFInteractiveViews which allows you to cache the views to disk after they are first generated at runtime. This means a slow start-up on the first run of a new instance, or after an update (when the hashes won't match), but will be of a similar speed to this method there-after.
Depending on how often you update or spin up new instances of your application, this might work better for you.
There is a mechanism to persist the views to a sqlserver, so you could share them between instances in that case, or you could maybe create a persistance mechanism (it is extensible) to pull from an embedded resource, and copy the latest cache file into your project on update.

@CZEMacLeod thanks so much for taking the time to respond with such thorough comments. They have been very helpful and are much appreciated.
We already have a t4 template to generate our DbContext (as it is DB first), so I have refactored this to generate the DbContext as we want it which means we no longer need the super class. This all works great.
I put the ms build task into our solution which all worked fine, until it got to our release pipeline which uses "dotnet publish" for a couple of our apps which is a mix of .net core 3.1 and .net framework 4.7 and it didn't like it. I haven't had time to look into this yet, so for the time being I have created a console app which uses your library to generate the mapping views at design time. This seems  like a reasonable workaround, although does rely on developers remembering to regenerate the mapping views when they make a schema change.

@andrewrimmer Glad you got a solution.
If you find an issue specifically with this package on netcore/dotnet cli, please feel free to open a new issue.
I did a quick check of the sample applications (both the net5 and net48 ones) using dotnet publish and it seems to work fine.
I will admit I haven't checked a net core 3.1 or a net47 project specifically, but have no reason to suspect it wouldn't work as the dotnet command line version of MSBuild should just use the netstandard 2.1 version of the files. Maybe you need to check which SDKs you have installed for the build process?


Event "Complite" calling before "Send" when async: false

maybe it's okay but still it's odd and i cant use events step by step.
for example i try block screen before pjax was finished but it going wrong.
test controller & view.zip

Fixed with https://github.com/yiisoft/jquery-pjax/pull/72


Adds option to use credentials file to pass in credentials

This allows passing in a credentials file for authentication without breaking cli parameter usage.
Unfortunately I do not have a porkbun account, so I was just able to test up to the actual challange execution, where the authentication fails. But it does work up to that point.
Fixes #1 .

Very good work.
An adjustment with the hint to the argument and the PR is ready for the next release v0.2.


Add support for Swift Package Manager

I needed to use 2 forks for dependencies to support SwiftPM (once they are merged, we can go back to the original repos).
Also, I had some linking issues with the current structure, so I had to flatten the files.
I'm sure it's fixable somehow by specifying options in the config, but didn't have the time to figure it out.

This is wild, thanks for the PR! I'll need some time to look through and see what the impact is from the restructure.


Implement Deserializer for Value

Just had this idea, so I thought I could implement it.

Oh right :+1:


betting.active_market_types endpoint requires non-existent field

The active_market_type endpoint requires an active field in the response from the API when we have removed this field. This is a change that can be seen when hitting the staging API service with our latest endpoints that are yet to hit production. This is why the endpoint continues to work when targeting production, however we need to be ready for when this is deployed. This issue also hinders integrating users who start on the staging API service.

It has been decided that with our new endpoints we will make sure they return the same style response as the original endpoints in order to make the transition seamless. Therefore the decision to drop the active field will instead be implemented at a later date and the response has been altered to make this endpoint work again. Issue no longer present.


Implement ping loop between peers

As it stands right now, the idle time for a peer is set to one minute. This can create some issues, as the consensus step timer can greatly exceed that amount of time if it fails to converge on a block a few times. If there is nothing else going on in the network, it means that nodes will timeout with each other after the 4th failed attempt (as the step timer is then set to 80 seconds).
My first instinct was to increase the timeout to the maximum consensus step time (5120 seconds), but implementing a ping loop that probes a node every 30 seconds or so seems more elegant.

I reviewed the Kademlia paper to see if they have any suggestions about the time to query other peers. And they don't.
But why instead of making PING we don't do something similar to FIND_NODE and if it does not return any peers (timeout), then we PING just to make sure that the peer is down and then we delete it from our buckets.


Can't launch clear bdsx

Describe the bug (Required)

To Reproduce (Required)
just clean installation of wine and wine:i386
Expected behavior
working bdsx server
Error logs
upper
Environment

OS: Ubuntu 24.04
node.js Version v18.19.1
npm 9.2.0

Additional context
same situation after deleting ~/.wine and reconfiguring

when i go to bedrock_server directory and do wine bedrock_server.exe bds starts up

what version of wine are you using?

Which version of wine are you using?

wine-9.0 (Ubuntu 9.0~repack-4build3)

notify me if you have new information


interpolate %(changed)s in action string even if it is empty list

Action string may include %(dependencies)s, %(targets)s and %(changed).
The values of variable dependencies, targets and changed are provided as strings from respective lists separated by a space.
In case of changed, it may happen, that when the value is None, the value for changed is not set in dictionary and string interpolation using %(changed)s will fail with KeyError due to missing keyword.
See the line:
https://github.com/pydoit/doit/blob/master/doit/action.py#L273
Proposal: in case of None (no changed input files), interpolate %(changed)s by empty string. This will make the behaviour consistent with other two keywords and more stable.

Agree.

How to reproduce this problem?
The problem is that changed is None it means it was not initialised (you did not call get_status()).

I guess you got this problem by using doit internals without doit command...
So, I added an assert to make sure the API is being properly used.

Actually I will revert this change... The problem is that doit clean also uses expand_args but changed is not computed. So it will still raise an exception if you try to use changed where it is not supported.


Update API Reference

The API Reference is missing some definitions:

findRelatedTests CLI option (http://facebook.github.io/jest/blog/2016/10/03/jest-16.html#upgraded-cli)

"a --findRelatedTests   cli option was added to run tests related to the specified files. This is especially helpful as a pre-commit hook if you'd like to run tests only on a specified set of files that have tests associated with them."

moduleNameMapper (linked from http://facebook.github.io/jest/docs/tutorial-react-native.html#modulenamemapper)

Updated issue description with more information. The API Reference is missing some things that have been recently added. For example, findRelatedTests is mentioned in a blog post from October but it is not documented.

Would love for this to be automated from JSDoc comments inside the projects so that it's really difficult to get out of date.

Yeah that would be ideal but my understanding is @cpojer totally hates using JSDoc :P

Actually, no that's not it. But there isn't really any place in the code where this API is clearly expressed because there is a bunch of meta-programming and because of how Jest sandboxes/virtualizes the runtime the code is run in. These docs would be scattered across jest-matchers, jest-runtime, jest-jasmine but would not be in jest-cli.

(btw. jest.clearAllMocks was removed; but we intent to bring it back eventually).

I see. React has a similar problem - too little of the API is defined directly to make jsdoc stuff make sense.

Yeah, that makes a lot of sense 👍

Hmm it seems like hardly any command line arguments are documented right now

For that, the website generation script could require this file: https://github.com/cpojer/jest/blob/master/packages/jest-cli/src/cli/args.js#L49 and then just use the options field.
You can require it from packages/jest-cli/build/cli/args and make sure that yarn run build was ran before deploying the website. This is to make sure the node version you are using can understand the file, because of flow types.

OK. I think step 1 is to separate out command line args from the runtime stuff because it kinda seems like they should be documented on different pages.

Sounds great! One thing: jest-runtime and jest-repl have their own cli and cli args. We mostly use it at FB and people outside don't really need it so much (unless they use @providesModule and want to build tools that use this) so I think it is fine to keep them undocumented.

Hm I didn't realize there was so much stuff there. The only thing I'd expect to have its args documented is the plain old jest executable.

It's missing about 30 command line options unfortunately 😡 OK I think CLI stuff might need to go into its own area of reference

Also FWIW moduleNameMapper goes into "configuration" not API and it's already there, the link was jsut broken. PR incomgin

https://github.com/facebook/jest/pull/2368


How to use the rules in Webstorm

Hello, I'm using "tslint": "5.11.0" and "rxjs-tslint": "0.1.5",
And I'd like to show as errors in webstorm the rules.
{
  "rulesDirectory": [
    "node_modules/rxjs-tslint"
  ],
  "rules": {
    "rxjs-collapse-imports": true,
    "rxjs-pipeable-operators-only": true,
    "rxjs-no-static-observable-methods": true,
    "rxjs-proper-imports": true
  }
}

I added that rules to my tslint.json but nothing happens, am I doing something wrong?
Thanks

The current set of rules is intended for migration. You should run them once against your project in order to migrate your source code to rxjs@6.


throw new Error ('euclidianDistance: arr1.lenght !== arr2.length');

I'm trying to put faceDescriptor previously computed un JSON file.
But there's this error when I'm trying to use findBestMatch
Can anyone help me?

Just resolved my problem, I've used the detection object instead of detection.descriptor


Contact Journal: Place duration (Std.) not translated

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[ ] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository. Not yet known.
[X] Bug is not already reported in another issue

Technical details

Device name: Samsung Galaxy A5 (2017) SM-A520F
Android version: 8.0.0
App version: 1.14.3

Describe the bug
The abbreviation for hours in the overview of the Contact Journal for a Place entry appears in German when the locale is set to English.

All other text on this page is shown in English.
Steps to reproduce the issue

Set the device locale to English (United Kingdom)
Open CWA
Tap Journal at the bottom of the screen
If this is the first time using the Contact Journal, first tap "OPEN JOURNAL"
Tap the calendar entry for today
Tap PLACES
Tap + PLACE
Enter "Test" in Description field
Tap "SAVE"
In Duration field time picker select any non-zero duration e.g. 00:15, tap OK
Tap Back button
Note that the place is displayed with
Test
00:15 Std.

Expected behavior
When the locale is set to English (United Kingdom) then all text shown in the Contact Journal should be shown in English.
Possible Fix
Translate the string "Std." into other supported languages, including English.
Consider using "hrs:min" for the English translation.

Internal Tracking ID: EXPOSUREAPP-5809

@MikeMcC399 Thanks.

Internal Tracking ID: EXPOSUREAPP-5809

PR: https://github.com/corona-warn-app/cwa-app-android/pull/2617

Looks good on 1.15.0-RC3.
Now 00:15 h is displayed.

In the released version 1.15.1, with locale set to:

English (United Kingdom) the place duration is shown with the abbreviationhrs
Deutsch (Deutschland) the place duration is shown with the abbreviationStd.

So the translation issue has been successfully fixed.

@MikeMcC399 Thanks for checking. Forwarded to internal ticket.


Update plugin cookiecutter

@steff456, could you explain why this change is needed?

@ccordoba12, the circleCI template for the new repo has the circle.yml file that is not used now. So I just changed the circleCI template to the folder .circleci with the config.yml that is used nowadays.


Page experience: FID issue possibly caused by @ampproject/pull/34028

Details
We had gotten a report in slack about a possible FID regression caused by the img changes in https://github.com/ampproject/amphtml/pull/34028
Hello,
I work on a few sister sites that share the same code base and AMP template. Since May 28th they have been experiencing Core Web Vitals issues on AMP pages, specifically First Input Delay. However, we haven’t made any code changes to AMP recently and these are blog pages there are no interactive features that should trigger FID to be measured.
The only user interactive function I can think of is that images on AMP have a lightbox feature but this is bundled into AMP by default. I checked the AMPHTML changelogs and there is a change to AMP images and lightbox at the end of April. CrUX data has a 28-day collection period so seeing the issues being reported at the end of May lines up with this change.
Can any AMP devs comment on the possibility this change being related to FID issues? and would be able to investigate/report it to the appropriate channel?

Components in use:
"amp-bind", "amp-ad", "amp-analytics", "amp-social-share", "amp-iframe", "amp-youtube", "amp-twitter", "amp-instagram", "amp-facebook", "amp-brightcove", "amp-sidebar", "amp-sticky-ad", "amp-video", "amp-fx-collection", "amp-auto-lightbox", "amp-lightbox-gallery"

/cc @ampproject/wg-performance

@issababble had a few questions:

"Since May 28th they have been experiencing Core Web Vitals issues on AMP pages" - is this still the case? we saw a slight dip of our FID performance in april and may 2021 but have been seeing a large improvement since june (going to figure out what we changed for the improvement). I just want to line up the dates to narrow down.

is https://bit.ly/3woT5V4 still a good example page that demonstrates the issue?

@erwinmombay Yes I still see "needs improvement" FID pages for two sites I work on (same AMP templates as they are sister sites). On one site, it started May 28, and on the other site it started June 9. The pages have not decreased on either site since they began.
However, I know Google groups pages that may not have field data so I did a quick analysis of a sample of 21 pages from each site (these are the pages reported in Search Console). There are 7 pages that are still still having FID issues in the field data. There is 1 page that is now green/good for FID. The rest of them no longer have field data. So it's possible there have been slight improvements but 7 pages out of my sample have had issues in the last 28 days.
Yes, that page is one of the 7 and it gets consistent visits so it should continue to be a good example. Here is another one from the sister site: https://bit.ly/3fzqu94
If you think of other questions, I'm happy to answer!


feat: various checks related to inheritance

Closes partially #543
Summary of Changes
Show an error if a class

inherits from multiple types,
inherits from something that is not a class, or
inherits from itself.

:tada: This PR is included in version 0.2.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


fixed_modules causes training issues

When I train with fixed_module empty I am able to train and visualize the model successfully with the latest code commit, however when I train with the default values model:
fixed_modules: ['input_conv', 'unet', 'output_layer', 'semantic_linear', 'offset_linear']
I get the errors below
(softgroup2) shrijan_pf@BQ-DX1100-CT2:~/Desktop/SoftGroup$ ./tools/dist_train.sh configs/softgroup_s3dis_fold5.yaml 1 --skip_validate
2022-05-09 22:25:31,199 - INFO - Config:
model:
  channels: 32
  num_blocks: 3
  semantic_classes: 3 #changed, original 13
  instance_classes: 3 #changed, original 13
  sem2ins_classes: [0,1]
  semantic_only: True
  ignore_label: -100
  grouping_cfg:
    score_thr: 0.2
    radius: 0.04
    mean_active: 300
    class_numpoint_mean: [1823, 7457, 6189]
    npoint_thr: 0.05  # absolute if class_numpoint == -1, relative if class_numpoint != -1
    ignore_classes: [-99]
  instance_voxel_cfg:
    scale: 50
    spatial_shape: 20
  train_cfg:
    max_proposal_num: 200
    pos_iou_thr: 0.5
  test_cfg:
    x4_split: True
    cls_score_thr: 0.001
    mask_score_thr: -0.5
    min_npoint: 100
  fixed_modules: ['input_conv', 'unet', 'output_layer', 'semantic_linear', 'offset_linear']

data:
  train:
    type: 's3dis'
    data_root: 'dataset/s3dis/preprocess_mint' # changed, original 'dataset/s3dis/preprocess'
    prefix: ['Area_1'] # changed, original ['Area_1', 'Area_2', 'Area_3', 'Area_4', 'Area_6']
    suffix: '_inst_nostuff.pth'
    repeat: 20
    training: True
    voxel_cfg:
      scale: 10 # changed, original 50
      spatial_shape: [128, 512]
      max_npoint: 250000
      min_npoint: 5000
  test:
    type: 's3dis'
    data_root: 'dataset/s3dis/preprocess_mint' # changed, original 'dataset/s3dis/preprocess'
    prefix: 'Area_2' #changed, original 'Area_5'
    suffix: '_inst_nostuff.pth'
    training: False
    voxel_cfg:
      scale: 10
      spatial_shape: [128, 512]
      max_npoint: 250000
      min_npoint: 5000

dataloader:
  train:
    batch_size: 2 #changed; original was 4
    num_workers: 4
  test:
    batch_size: 1 #changed; original was 1
    num_workers: 1

optimizer:
  type: 'Adam'
  lr: 0.004

save_cfg:
  semantic: True
  offset: True
  instance: False

fp16: False
epochs: 5
step_epoch: 0
save_freq: 2
pretrain: 'work_dirs/softgroup_s3dis_backbone_fold5/latest.pth'
work_dir: ''

2022-05-09 22:25:31,199 - INFO - Distributed: True
2022-05-09 22:25:31,199 - INFO - Mix precision training: False
Traceback (most recent call last):
  File "./tools/train.py", line 185, in <module>
    main()
  File "./tools/train.py", line 153, in main
    model = DistributedDataParallel(model, device_ids=[torch.cuda.current_device()])
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 542, in __init__
    "DistributedDataParallel is not needed when a module "
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 674, in _log_and_throw
    raise err_type(err_msg)
RuntimeError: DistributedDataParallel is not needed when a module doesn't have any parameter that requires a gradient.
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 1) local_rank: 0 (pid: 22482) of binary: /home/shrijan_pf/anaconda3/envs/softgroup2/bin/python
Traceback (most recent call last):
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/bin/torchrun", line 33, in <module>
    sys.exit(load_entry_point('torch==1.11.0', 'console_scripts', 'torchrun')())
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 345, in wrapper
    return f(*args, **kwargs)
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/distributed/run.py", line 724, in main
    run(args)
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/distributed/run.py", line 718, in run
    )(*cmd_args)
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 131, in __call__
    return launch_agent(self._config, self._entrypoint, list(args))
  File "/home/shrijan_pf/anaconda3/envs/softgroup2/lib/python3.7/site-packages/torch/distributed/launcher/api.py", line 247, in launch_agent
    failures=result.failures,
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
============================================================
./tools/train.py FAILED
------------------------------------------------------------
Failures:
  <NO_OTHER_FAILURES>
------------------------------------------------------------
Root Cause (first observed failure):
[0]:
  time      : 2022-05-09_22:25:35
  host      : BQ-DX1100-CT2
  rank      : 0 (local_rank: 0)
  exitcode  : 1 (pid: 22482)
  error_file: <N/A>
  traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

When I do this, the model trains without issues
fixed_modules: []
Would you know what would be causing the issue?

For me, when I have the fixed modules
fixed_modules: ['input_conv', 'unet', 'output_layer', 'semantic_linear', 'offset_linear']

I get the same error as above from @SijanNeupane49
With input_conv removed;
fixed_modules: ['unet', 'output_layer', 'semantic_linear', 'offset_linear']

I'm able to train, test and visualize. What would be causing this issue with input_conv?

@theshapguy it is expected. If you fix all the module, then you cannot train the model.

If you are finetuning the backbone, you should set fixed_modules = []


Feature request - it would useful to create Hyperlinks right on diagrams.

This request is buried in issue #322, but it was a sentence that didn't seem to be captured in the follow up to the original statement made.
One area that I would find really useful, is the ability to create hyperlinks directly from objects on the diagram. It works great for linking between diagrams in Archi as is now, but when I need to point to something that is external (ie, sitting as a defined process, or activity diagram or sequence diagram) somewhere else on our quality system, I have to create an object, add some documentation, and then put the hyperlink in there. People have to know to look for it, and then go down to it. That's a valid scenario in some instances, but in others, it's faster just to point to the external object directly. Make sense?
For example, right now, I'm using Archi to model our overall organization, and the high level processes. When I click down into the detail of the processes, sometimes what I need is really is a type of diagram that Archi doesn't support, because Archimate doesn't. Ie, some type of BPMN diagram, like an Activity Diagram, Sequence Diagram, etc. It would be great if I could do that, and provide those links directly from the visual map that Archi so kindly provides.
For now, I'll keep going the way I'm going, but thanks for whatever feedback you might provide.

Do you mean that you would like a link from the diagram node to somewhere else? i.e you would double-click on a node it would open up the linked URL? Can you be more detailed in the work flow?

I can think of a couple.

Create a weblink type icon on the diagram, and be able to associate it to other parts of the diagram. That weblink, on double click in the HTML report or HTML preview, would allow to you bring up that external link.

Allow a weblink to be associated with an object in the diagram, so that when you do the HTML report or HTML preview, and click on it, the objects details come up (like currently), but if you  double click on it, the external link is opened.

Something like that?

To add a bit to the subject, since the addition of the Label features, it could be use via labels.
Unfortunately at the moment, the link rendered is not clickable

I support this feature request. It would be very useful create a direct link to external documentation.

Any advance?
I still have the usecase that I would like to create clickable a link from my objects in archi to the correponding page in our helpdesk/cmdb-tooling.

Any advance?

Yes, it has been implemented !
No sorry, I'm joking. Because Phil and I are the only ones working on Archi (for free) and we have other priorities, this is not on our roadmap. But the good news is that Archi is opensource so anyone (including you) can work on it for the benefit of the whole user community.

Oh yes, I appreciate all the effort you invest, and can easily understand
you have other priorities...
But sorry, I've not been into real developing myself for more than 20
years... Wouldn't know where to look in the source, and how to compile.
Kind regards, Mikis
Op do 21 sep. 2023 17:49 schreef Jean-Baptiste Sarrodie <
@.***>:

Any advance?
Yes, it has been implemented !
No sorry, I'm joking. Because Phil and I are the only ones working on
Archi (for free) and we have other priorities, this is not on our roadmap.
But the good news is that Archi is opensource so anyone (including you) can
work on it for the benefit of the whole user community.
—
Reply to this email directly, view it on GitHub
https://github.com/archimatetool/archi/issues/344#issuecomment-1729852596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AR5FFKUO5JQUIDGZFYZT6PLX3ROYHANCNFSM4EOZMEQQ
.
You are receiving this because you commented.Message ID:
@.***>

Keen on this feature, and also the ability to follow the links from elements in a view.  Looking at this possibly being my first code contribution.
I went looking at the RCP docs (what little there are) and found references to org.eclipse.ui.menu as being the place to "add new menu items".  It seems like Archi either isn't using this or has abstracted it to a much higher level.
I've got as far as finding the code for "Set Concept Type" in com.archimatetool.editor/src/com/archimatetool/editor/actions/SetConceptTypeExtensionContributionFactory.java, and the entries in it's sibling Messages.java and messages.properties, but don't understand the menu framework it's using.  Some pointers to docs that could help me understand this would be awsome - not sure if I'd have the time to reverse engineer the whole thing through reading code.


error：we cannot find mlc-chat-config.json

❓ General Questions
(mlc-chat-venv) D:\Llama\prebuilt>mlc_chat_cli --model Llama-2-7b-chat-hf-q4f16_1
[09:28:41] C:\Miniconda\envs\mlc-llm-build\conda-bld\mlc-chat-cli-nightly-package_1693804235111\work\cpp\cli_main.cc:339: The model folder provided does not seem to refer to a valid mlc-llm model folder. Specifically, we cannot find mlc-chat-config.json, a required file. You should provide a path that contains the file. According to your input Llama-2-7b-chat-hf-q4f16_1, we looked at folder(s):

Llama-2-7b-chat-hf-q4f16_1
dist/prebuilt/Llama-2-7b-chat-hf-q4f16_1
dist/Llama-2-7b-chat-hf-q4f16_1/params
dist/prebuilt/mlc-chat-Llama-2-7b-chat-hf-q4f16_1
Stack trace not available when DMLC_LOG_STACK_TRACE is disabled at compile time.

Maybe you can try to place chatglm2-6b-q4f16_1 under the /mlc-llm/dist/ path, and execute mlc-chat-cli under the /mlc-llm path.

I am using the Windows 11 operating system. How is the path planning appropriate under the Windows system?

@wangxu569 Hello, could you please help me see how to solve this problem? Thank you!

@wangxu569 Hello, could you please help me see how to solve this problem? Thank you!

Maybe you can take a look : https://mlc.ai/mlc-llm/docs/get_started/try_out.html

@linjie830914 if you have not figured it out yet ....

You want to create a D:\mcl-chat\dist   directory, then move the prebuilt directory (and all its contents) over.
After that, change directory into D:\mlc-chat  and then run your command again.  It should work.

Thank you, I'll give it a try.

After modifying the path, the model can be loaded, but new issues have been encountered

Is it out of memory?

Hi @linjie830914, based on the log, it does seem to be an OOM issue. Would you mind sharing the amount of memory you have?
Or perhaps you could try Llama-2-7b-q3f16_1, which is smaller due to int3 quantization as opposed to int4.
Alternatively, perhaps a smaller model like RedPajama-INCITE-Chat-3B-v1-q4f16_1, which has 3B parameters as opposed to 7B.

Closing for now due to inactive status, feel free to open new ones

Hi, did you solved your question? I meet the same situation, my graphic card is 4060ti 16G,  I don't know how to solve the same question like
Stack trace not available when DMLC_LOG_STACK_TRACE is disabled at compile time.

Hi @csy94cfy, the workflow described in this issue is deprecated as we no longer auto-lookup mlc-chat-config.json. Please refer to the most up-to-date documentation:

Python Runtime: https://llm.mlc.ai/docs/deploy/python.html
CLI Runtime: https://llm.mlc.ai/docs/deploy/cli.html
Compile time: https://llm.mlc.ai/docs/compilation/compile_models.html


Ensure circle buttons maintain shape

MUMMNG-2986: Just added a min-height to circle-buttons to ensure they don't warp when there are two lines of text

Coverage remained the same at 39.149% when pulling 1deb72acf4b2a2b61fb0982b2e8ed151e1e2fe3b on thevoiceofzeke:icon-button into 004fd7f8a1bfcc1cf8eede4eea1c0fe68af70ec7 on UW-Madison-DoIT:master.


purple and black textures

BrawlRPlast.zip - Resourcepack
latest.log - log
Yesterday we switched to 1.20.1 and use Axiom instead of WorldEdit, we had to download alternatives optifine to load textures normally, but faced the problem that half of the textures - normal, and half black and purple.

There are a lot of issues in that pack but the one that sticks out the most is using textures/blocks/ instead of textures/block/ for textures.
This would've been fine in older versions but in newer versions the folders for textures have to be set in the blocks atlas json.


tests: repeated arg-less calls to create_test_user throw error

Calling testutils.py:create_test_user without any arguments twice cause an error to be thrown as it attempts to create a second user with the default email address.
Fix: generate random email address when none is given instead of using a static default.

Proposal
Make email argument required.

What if, instead of completely random and different between each test run, we use a static seed for the RNG (reset between each test) so that the the nth generated email is always the same?

What is the difference if I write users =<EMAIL_ADDRESS>for i in range(10)]?

Between your example and users = [create_test_user() for _ in range(10)] where the emails are generated from a statically seeded rng? The produced lists will contain different email addresses.

Some comments:

making email address mandatory when creating a user seems good;

using numerical IDs works just as well as using RNG, so I'd prefer its simplicity;

it's better to use example.org than example.com here and elsewhere.

Generation suggestion:

email = "testuser{0}@example.org".format(var)

where var is 1 if the number of users in the datastore is 0, or the largest user id currently in the datastore plus 1.

Why I favor automatic email generation:

It's a testing utility, meant to make writing tests easier and less of a chore. Making the email parameter required increases the amount of effort needed to write tests.
The email address is only relevant to the test if its value is expected to alter the outcome of the test (e.g. tests for the email validation system or when testing user registration with already registered emails).


Fix FEC integration tests to a single year.

The new annual edition for FEC's been released, which causes an integration
test failure (as the integration tests cover 2016). Have the integration tests
explicitly verify 2016 rather than whatever the latest is. We can update tests
to 2017 once they are verified.

Coverage increased (+0.001%) to 91.941% when pulling 528d552f2a3bd44b37dc542fdfd39a0fc7a64497 on cmc333333:fix-fec-year into 6faf9e75c2ed620cf7681922fcb672b518681d25 on eregs:master.


Workaround - Graceful Shutdown of ECS Tasks

User Story - Business Need
Minimize the risk of data loss and ensure the continuity of the application's services during the task termination process. By implementing a deregulation delay of 25 seconds we should be able to ensure the currently running Fargate tasks are not receiving new tasks when we receive the SIGKILL, so we would effectively no longer terminate in the middle of task execution. This does not gracefully shut down the running tasks. The end-goal is to provide a more reliable and stable user experience. This will ultimately improve customer satisfaction and trust in the application.
User Story(ies)
As a DevOps Engineer
I want tasks to not receive work when they shouldn't
So that we avoid losing data when tasks are terminated
Additional Info and Resources

Deregistration delay
Graceful shutdowns with ECS

Engineering Checklist

[ ] Ensure we have the option to set Deregistration for Fargate
[ ] Set an appropriate Deregistration delay for our tasks
[ ] Ensure new tasks are fully operational before the deregistration delay finishes

Acceptance Criteria

Deregistration delay is setup and we do not see new requests on those deregistered tasks
The new tasks should start receiving requests before the old tasks are terminated

Additional Notes

All the documentation seen revolved around ECS, but we use Fargate within ECS. First thing should be making sure we have that level of control over Fargate. Also, ensure an understanding of how Fargate shuts down. The graceful shutdown doc was specific to ECS and we need to make sure it's applicable to Fargate as well.
QA Considerations
For QA to populate. Leave blank if QA is not applicable on this ticket.
Out of Scope

Non-ECS related optimizations

@ldraney  @k-macmillan How will we know this criteria has been met?

Deregistration delay is setup and we do not see new requests on those deregistered tasks
The new tasks should start receiving requests before the old tasks are terminated

Are there specific log files we should not be seeing anymore?

Resolved, per Kyle.


direnv-mode tries to parse direnv errors

I've been experiencing a direnv configuration error, beyond the scope of this report. (FYI, "direnv export json" is erroring out for me with:  Couldn't find a configuration directory for direnv)
When this happens, the problem is compounded by direnv--export trying to parse the stderr output. The symptom is that re-search-backward can't find "^{".
Does it make sense to refrain from parsing when exit-code is nonzero?

hmmm, maybe. if the problem happens the exit code is nonzero, but maybe direnv will output unsetting of variables if it came from another directory?

Okay, but arguably it should never try to parse stderr.
On Wed, 24 Apr 2019, 20:43 wouter bolsterlee<EMAIL_ADDRESS>wrote:

hmmm, maybe. if the problem happens the exit code is nonzero, but maybe
direnv will output unsetting of variables if it came from another
directory?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wbolster/emacs-direnv/issues/41#issuecomment-486376852,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXBZYD3463HUD7UDI4GSMDPSCSZJANCNFSM4HIBZE3Q
.

correct. also, stderr is only inserted into the *direnv* buffer if the exit code is nonzero, which is also not ideal.
would you be comfortable trying to come up with a pull request to improve this?

How about I put the JSON-encoded stderr into direnv if there is any?
Yes, I'm just about comfortable with that level of elisp hacking.
On Wed, 24 Apr 2019 at 21:37, wouter bolsterlee<EMAIL_ADDRESS>wrote:

correct. also, stderr is only inserted into the direnv buffer if the
exit code is nonzero, which is also not ideal.
would you be comfortable trying to come up with a pull request to improve
this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wbolster/emacs-direnv/issues/41#issuecomment-486395540,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABXBZYD2NSOIVRTBNYHAINLPSCZF7ANCNFSM4HIBZE3Q
.

cool :+1:
i think stderr is never json encoded, only stdout is. so i think this flow would work:

run process, stdout goes into buffer
if not empty, this should contain only json
append a newline to the buffer
insert stderr (could be empty, but no need to check for it)


Pattgen v1

action items from V1 review
Action item1: - Pattgen_alert test is not needed, also remove the alert_cg coverpoint
What is done: - Removed the alert test
Action item2: - Change all reset to re-enable in test description
What is done: -Changed reset to re-enable
Action item3: -In the description remove the reference to reset injection
What is done - Removed reference to stress injection
Action item4: -Instantiate the intr_cg in pattgen_env_cov
What is done -Intr_cg is defined in cip_base_env_cov and
referenced in pattgen_scoreboard
Action item5: -When the environment was built, it would be
better to build on channel and instantiate as many as design defined
What is done: -Built coverage in a channel and instantiated
for two channels
Action item6: -Shell we cross the length, prediv and reps?
Please document the cross
What is done: -Validated the existence of cross between
length, prediv and reps
Action item7: -Do we need a cross of both channels' enable
signals with all other coverpoints
What is done: -Removed the cross of both channels
Action item8: -Might need a transition covergroup to capture
the value change
What is done: -Verified the code has already transition coverage
Action item9: -In the middle of pattern change the settings
via TLUL interface, and check the pattern is not affected.
What is done: -Generated stimulus to check that the pattern
is not affected and updated compare logic in the scoreboard
to make comparison correct

@alexsapozhnikov Hi Alex you want to squash these two commits into one as they are covering the same thing.
you can keep the first commit message
before you make the PR ready for review- you should write a description of what is in the commits.
you could list each action item - and mention what was done about it!

Hi Rasmus,
Should this description be a separate document, or attachment to existing draft, or I should paste the description to the leave comment box?
Will I still keep the draft as a draft?
Alex.
From: rasmus-madsen @.>
Sent: Thursday, November 18, 2021 6:25 AM
To: lowRISC/opentitan @.>
Cc: Alex Sapozhnikov @.>; Mention @.>
Subject: Re: [lowRISC/opentitan] Pattgen v1 (PR #9186)
CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.
@alexsapozhnikovhttps://github.com/alexsapozhnikov Hi Alex you want to squash these two commits into one as they are covering the same thing.
you can keep the first commit message
before you make the PR ready for review- you should write a description of what is in the commits.
you could list each action item - and mention what was done about it!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/lowRISC/opentitan/pull/9186#issuecomment-972913246, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD4ZUVAW2K35GXHNCUNF7GDUMUEFBANCNFSM5H3SUPCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@alexsapozhnikov just paste it in the description

Paste into the box at the bottom of draft? Do I keep it as a draft?
From: rasmus-madsen @.>
Sent: Thursday, November 18, 2021 10:11 AM
To: lowRISC/opentitan @.>
Cc: Alex Sapozhnikov @.>; Mention @.>
Subject: Re: [lowRISC/opentitan] Pattgen v1 (PR #9186)
CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.
@alexsapozhnikovhttps://github.com/alexsapozhnikov just paste it in the description
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/lowRISC/opentitan/pull/9186#issuecomment-973128345, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD4ZUVEU2VEQPVR7A56JK4TUMU6R7ANCNFSM5H3SUPCQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@rswarbrick @sriyerg @cindychip @martin-lueker
this is a short PR could you review asap so we can checkoff Pattgen V1

@alexsapozhnikov CI failed - could you fix the lint errors please :D

Hi Alex,
I re-ran the CodeWhisper FGPA test for CI (which was previously stalling you).
-Martin


[SPARK-41950][PS][BUILD] Pin mlflow to 2.0.X

What changes were proposed in this pull request?
After MLflow 2.1 release (https://github.com/mlflow/mlflow/releases), the unittest in pandas API on Spark is broken.
from mlflow.tracking import MlflowClient, set_tracking_uri
from sklearn.linear_model import LinearRegression
import mlflow.sklearn
from tempfile import mkdtemp
d = mkdtemp("pandas_on_spark_mlflow")
set_tracking_uri("file:%s"%d)
client = MlflowClient()
exp_id = mlflow.create_experiment("my_experiment")
exp = mlflow.set_experiment("my_experiment")
train = pd.DataFrame({"x1": np.arange(8), "x2": np.arange(8)**2,
                      "y": np.log(2 + np.arange(8))})
train_x = train[["x1", "x2"]]
train_y = train[["y"]]
with mlflow.start_run():
    lr = LinearRegression()
    lr.fit(train_x, train_y)
    mlflow.sklearn.log_model(lr, "model")
from pyspark.pandas.mlflow import load_model
run_info = client.search_runs(exp_id)[-1].info
model = load_model("runs:/{run_id}/model".format(run_id=run_info.run_id))
prediction_df = ps.DataFrame({"x1": [2.0], "x2": [4.0]})
prediction_df["prediction"] = model.predict(prediction_df)
print(prediction_df)

https://github.com/apache/spark/blob/06ec98b0d6a51e0c3ffec70e78d86d577b0e7a72/python/pyspark/pandas/mlflow.py#L134-L202
File "/__w/spark/spark/python/pyspark/pandas/mlflow.py", line 172, in pyspark.pandas.mlflow.load_model
Failed example:
    prediction_df
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib/python3.9/doctest.py", line 1336, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest pyspark.pandas.mlflow.load_model[18]>", line 1, in <module>
        prediction_df
      File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 13322, in __repr__
        pdf = cast("DataFrame", self._get_or_create_repr_pandas_cache(max_display_count))
      File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 13313, in _get_or_create_repr_pandas_cache
        self, "_repr_pandas_cache", {n: self.head(n + 1)._to_internal_pandas()}
      File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 13308, in _to_internal_pandas
        return self._internal.to_pandas_frame
      File "/__w/spark/spark/python/pyspark/pandas/utils.py", line 588, in wrapped_lazy_property
        setattr(self, attr_name, fn(self))
      File "/__w/spark/spark/python/pyspark/pandas/internal.py", line 1056, in to_pandas_frame
        pdf = sdf.toPandas()
      File "/__w/spark/spark/python/pyspark/sql/pandas/conversion.py", line 208, in toPandas
        pdf = pd.DataFrame.from_records(self.collect(), columns=self.columns)
      File "/__w/spark/spark/python/pyspark/sql/dataframe.py", line 1197, in collect
        sock_info = self._jdf.collectToPython()
      File "/__w/spark/spark/python/lib/py4j-<IP_ADDRESS>-src.zip/py4j/java_gateway.py", line 1322, in __call__
        return_value = get_return_value(
      File "/__w/spark/spark/python/pyspark/sql/utils.py", line 209, in deco
        raise converted from None
    pyspark.sql.utils.PythonException:
      An exception was thrown from the Python worker. Please see the stack trace below.
    Traceback (most recent call last):
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/worker.py", line 829, in main
        process()
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/worker.py", line 821, in process
        serializer.dump_stream(out_iter, outfile)
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/sql/pandas/serializers.py", line 345, in dump_stream
        return ArrowStreamSerializer.dump_stream(self, init_stream_yield_batches(), stream)
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/sql/pandas/serializers.py", line 86, in dump_stream
        for batch in iterator:
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/sql/pandas/serializers.py", line 338, in init_stream_yield_batches
        for series in iterator:
      File "/__w/spark/spark/python/lib/pyspark.zip/pyspark/worker.py", line 519, in func
        for result_batch, result_type in result_iter:
      File "/usr/local/lib/python3.9/dist-packages/mlflow/pyfunc/__init__.py", line 1253, in udf
        yield _predict_row_batch(batch_predict_fn, row_batch_args)
      File "/usr/local/lib/python3.9/dist-packages/mlflow/pyfunc/__init__.py", line 1057, in _predict_row_batch
        result = predict_fn(pdf)
      File "/usr/local/lib/python3.9/dist-packages/mlflow/pyfunc/__init__.py", line 1237, in batch_predict_fn
        return loaded_model.predict(pdf)
      File "/usr/local/lib/python3.9/dist-packages/mlflow/pyfunc/__init__.py", line 413, in predict
        return self._predict_fn(data)
      File "/usr/local/lib/python3.9/dist-packages/sklearn/linear_model/_base.py", line 355, in predict
        return self._decision_function(X)
      File "/usr/local/lib/python3.9/dist-packages/sklearn/linear_model/_base.py", line 338, in _decision_function
        X = self._validate_data(X, accept_sparse=["csr", "csc", "coo"], reset=False)
      File "/usr/local/lib/python3.9/dist-packages/sklearn/base.py", line 518, in _validate_data
        self._check_feature_names(X, reset=reset)
      File "/usr/local/lib/python3.9/dist-packages/sklearn/base.py", line 451, in _check_feature_names
        raise ValueError(message)
    ValueError: The feature names should match those that were passed during fit.
    Feature names unseen at fit time:
    - 0
    - 1
    Feature names seen at fit time, yet now missing:
    - x1
    - x2

https://github.com/apache/spark/actions/runs/3871715040/jobs/6600578830
Why are the changes needed?
To recover the broken test.
Does this PR introduce any user-facing change?
No, test-only (for now).
Maybe a regression but from MLflow.
How was this patch tested?
CI in this PR should test it out.

See also https://github.com/apache/spark/actions/runs/3869770926/jobs/6596152018#step:9:56 and https://github.com/apache/spark/actions/runs/3872798855/jobs/6603071801#step:9:57 for rationale of pinning the version

Python CIs seems to fail still. Could you re-trigger the failed ones?

cc @xinrong-meng since she is the release manager for Apache Spark 3.4.0.

All tests passed.
Merged to master.

Thanks!!!

I was able to reproduce the issue.
The root cause is this line:
https://github.com/mlflow/mlflow/blob/d2ae53af1af2b7908d294749996fc30866af3bd2/mlflow/pyfunc/__init__.py#L1055
        if pdf is None:
            print(args)
            args = list(args)
            if input_schema is None:
                names = [str(i) for i in range(len(args))]
            else:
                names = input_schema.input_names()
                if len(args) > len(names):
                    args = args[: len(names)]
                if len(args) < len(names):
                    raise MlflowException(
                        "Model input is missing columns. Expected {} input columns {},"
                        " but the model received only {} unnamed input columns"
                        " (Since the columns were passed unnamed they are expected to be in"
                        " the order specified by the schema).".format(len(names), names, len(args))
                    )
            pdf = pandas.DataFrame(data={names[i]: x for i, x in enumerate(args)}, columns=names)  👈👈👈 this line
            print(pdf)

This line creates a dataframe with columns that look like ["0", "1", ...] unless input_schema is specified.

@HyukjinKwon Is it possible to add a name to each pd.Series that iterator?
    # MLflow's pandas_udf looks like this:

    @pandas_udf(result_type)
    def udf(
        iterator: Iterator[Tuple[Union[pandas.Series, pandas.DataFrame], ...]]
    ) -> Iterator[result_type_hint]:
        # iterator yields a pd.Series
        ...


Incorrect newline in Revelation 22:21

When querying for rev22:21 in KJV, bible_api incorrectly places a line break in the middle of the verse.
Thank you for this API. Keep up the noble work, and God bless you.

I think this is the same problem as #32, but I'll leave the issue open so we can check that it's fixed when we get around to fixing #32. Thanks!

On second thought, let's just make a list on #32. Closing this...


GdbStub get_mem_region bug

Describe the bug
When analyzing a core dump, the get_mem_region function in gdbstub.py currently will return a given memory region if the desired address is equal to the "end" of the memory region. A valid memory region should only be returned if the given address is less than the "end". Otherwise we won't be able to read the value at "addr". Additionally, a different memory region may have that "addr" as its "start" and would be a more appropriate selection.
Please also mention any information which could help others to understand
the problem you're facing:

What target platform are you using?
I was using RISC-V, but the issue would reproduce on any platform where coredump is supported
What have you tried to diagnose or workaround this issue?
I am still able to directly examine a single memory address in gdb, but some commands that would require reading memory from two memory regions return inaccurate data.
...

To Reproduce
Steps to reproduce the behavior:

Add multiple memory regions to a core dump using a coredump device (or some other means) where the second region has a start address equal to the first region's end address
Write some unique expected values into the memory regions
Force a crash
Load the dump into gdb
Attempt to read from the start of the second memory region

Expected behavior
GDB prints actual data captured at that memory
Impact
Annoyance, as examining memory in a crash dump sometimes reports inaccurate data
Logs and console output
Environment (please complete the following information):

OS: Linux
Toolchain: Zephyr SDK

Additional context
@cfriedt , here's an issue for the backport

Fixed by https://github.com/zephyrproject-rtos/zephyr/pull/42711


bug(sidenav,chips): Using chip list in a sidenav results in an unavoidable horizontal scroll bar

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When using the stock Angular Material sidenav, and then adding a mat-chip-list into it, a horizontal scroll bar is always visible even if the content more than fits.
Reproduction
Steps to reproduce:

Add an empty mat-sidenav-container with a mat-sidenav and mat-sidenav-content
In the mat-sidenav, add a mat-chip-list and at least one mat-chip with text
Observe the horizontal scroll bar visible at the bottom. In the StackBlitz, I also see a vertical scroll bar, but this is not happening in my personal project.

StackBlitz
Expected Behavior
The chips should fit in the sidenav with no issue and no scroll bar should be visible unless a max width was imposed.
Actual Behavior
The chips cause a horizontal scrollbar to appear. Removing the chips or using other content causes the scrollbar to go away - it is only present when chips are also present.
A vertical scroll bar also seems to appear in the provided StackBlitz but my personal project has not hit this issue, only the horizontal one.
Environment

Angular: CLI 14.2.4
CDK/Material: 14.2.3
Browser(s): Chrome, Edge
Operating System (e.g. Windows, macOS, Ubuntu): Windows (WSL 2), whatever StackBlitz uses

The negative margin is likely the culprit here.

Hi @zarend - I see the "Fixed in MDC" label and found the PR moving chips to use MDC. Is that change pulled into a release yet so I can grab it?

Hi @CrowhopTech ,
The MDC components will be available in the upcoming v15 release. If you would like to use them sooner, they're available in the rc and next releases.
-Zach

Tested with MDC based components, the scroll bar does not appear anymore


Add tests

Codecov Report

Merging #54 (9c00258) into main (b353626) will increase coverage by 8.49%.
The diff coverage is 31.50%.

@@            Coverage Diff            @@
##            main      #54      +/-   ##
=========================================
+ Coverage   8.95%   17.44%   +8.49%
=========================================
  Files         43       44       +1
  Lines       5262     5365     +103
=========================================
+ Hits         471      936     +465
+ Misses      4791     4429     -362

Flag
Coverage Δ

oasysgh
10.77% <3.42%> (+8.93%)
:arrow_up:

unitnumber
9.48% <28.08%> (+2.22%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

OasysGH/Units/DefaultUnits.cs
91.48% <0.00%> (+4.25%)
:arrow_up:

OasysGH/Units/Helpers/RhinoUnit.cs
6.45% <0.00%> (+6.45%)
:arrow_up:

OasysGH/Units/Helpers/FilteredUnits.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Codecov Report

Merging #54 (fbb67ab) into main (b353626) will increase coverage by 30.56%.
The diff coverage is 31.50%.

@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   8.95%   39.51%   +30.56%
==========================================
  Files         43       26       -17
  Lines       5262     1622     -3640
==========================================
+ Hits         471      641      +170
+ Misses      4791      981     -3810

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

GH_UnitNumber/Properties/Resources.Designer.cs

...GH/ComponentAttributes/Bool6ComponentAttributes.cs

OasysGH/ComponentAttributes/Colours.cs

...H/ComponentAttributes/ButtonComponentAttributes.cs

OasysGH/Units/Helpers/FilteredUnits.cs

... and 17 more

Codecov Report

Merging #54 (fc81acd) into main (b353626) will increase coverage by 32.73%.
The diff coverage is 31.50%.

@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   8.95%   41.68%   +32.73%
==========================================
  Files         43       22       -21
  Lines       5262     1528     -3734
==========================================
+ Hits         471      637      +166
+ Misses      4791      891     -3900

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

...H/ComponentAttributes/ButtonComponentAttributes.cs

OasysGH/Parameters/GH_OasysPersistentParam.cs

...ysGH/Parameters/GH_OasysPersistentGeometryParam.cs

OasysGH/Units/UI/MainMenu.cs

OasysGH/Parameters/GH_OasysGeometricGoo.cs

... and 21 more

Codecov Report

Merging #54 (bdf6fdb) into main (b353626) will increase coverage by 33.09%.
The diff coverage is 31.50%.

@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   8.95%   42.04%   +33.09%
==========================================
  Files         43       21       -22
  Lines       5262     1515     -3747
==========================================
+ Hits         471      637      +166
+ Misses      4791      878     -3913

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

OasysGH/Parameters/GH_OasysGoo.cs

...ComponentAttributes/DropDownComponentAttributes.cs

.../Components/OBSOLETE/ConvertUnitNumber_OBSOLETE.cs

OasysGH/Properties/Resources.Designer.cs

...H/ComponentAttributes/SliderComponentAttributes.cs

... and 22 more

Codecov Report

Merging #54 (3a3e8f3) into main (b353626) will increase coverage by 33.45%.
The diff coverage is 31.50%.

@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   8.95%   42.40%   +33.45%
==========================================
  Files         43       18       -25
  Lines       5262     1455     -3807
==========================================
+ Hits         471      617      +146
+ Misses      4791      838     -3953

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

OasysGH/Utility.cs

...H/ComponentAttributes/ButtonComponentAttributes.cs

...sysGH/ComponentAttributes/ThreeButtonAtrributes.cs

...H/ComponentAttributes/SliderComponentAttributes.cs

OasysGH/Parameters/GH_OasysGoo.cs

... and 25 more

@tlmnrnhrdt it seems like GH_UnitNumberTests doesn’t get any coverage on codecov like previously for GsaGH - do you remember what we did?

@tlmnrnhrdt it seems like GH_UnitNumberTests doesn’t get any coverage on codecov like previously for GsaGH - do you remember what we did?

I think you fixed it by making all test projects actually using Rhino.Inside? With GsaGH we had one test project that didn´t really use it for a long time..

Codecov Report

Merging #54 (3349932) into main (b353626) will increase coverage by 8.49%.
The diff coverage is 31.50%.

@@            Coverage Diff            @@
##            main      #54      +/-   ##
=========================================
+ Coverage   8.95%   17.44%   +8.49%
=========================================
  Files         43       44       +1
  Lines       5262     5365     +103
=========================================
+ Hits         471      936     +465
+ Misses      4791     4429     -362

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.06% <65.07%> (+59.06%)
:arrow_up:

OasysGH/Units/DefaultUnits.cs
91.48% <0.00%> (+4.25%)
:arrow_up:

OasysGH/Units/Helpers/RhinoUnit.cs
6.45% <0.00%> (+6.45%)
:arrow_up:

OasysGH/Units/Helpers/FilteredUnits.cs
100.00% <0.00%> (+100.00%)
:arrow_up:

Codecov Report

Merging #54 (0bce4c8) into main (4a24400) will increase coverage by 32.06%.
The diff coverage is 11.11%.

:exclamation: Current head 0bce4c8 differs from pull request most recent head 51c7ae4. Consider uploading reports for the commit 51c7ae4 to get more accurate results

@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   8.89%   40.95%   +32.06%
==========================================
  Files         44       19       -25
  Lines       5297     1509     -3788
==========================================
+ Hits         471      618      +147
+ Misses      4826      891     -3935

Impacted Files
Coverage Δ

GH_UnitNumber/Components/CreateUnitNumber.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Components/TestInputComponent.cs
0.00% <0.00%> (ø)

GH_UnitNumber/Parameter/GH_UnitNumberParameter.cs
0.00% <0.00%> (ø)

OasysGH/Units/Helpers/UnitsHelper.cs
86.99% <41.66%> (+68.38%)
:arrow_up:

OasysGH/Components/Helpers/Input.cs
59.53% <71.42%> (+59.53%)
:arrow_up:

OasysGH/Properties/Resources.Designer.cs

.../Components/OBSOLETE/ConvertUnitNumber_OBSOLETE.cs

...ysGH/Parameters/GH_OasysPersistentGeometryParam.cs

...GH/ComponentAttributes/Bool6ComponentAttributes.cs

...ComponentAttributes/ReleasesComponentAttributes.cs

... and 25 more


Changes not being triggered on Docker

I have this simple setup for testing purposes:
Dockerfile:
FROM node:11.2.0-alpine
WORKDIR /usr/src/app
RUN yarn

docker-compose.yml:
version: "3.7"
services:
  server:
    build: .
    command: yarn start
    ports:
      - 4000:4000
    volumes:
      - .:/usr/src/app

index.js:
const express = require("express");

const app = express();

app.get("/", (req, res) => {
  res.send("hello world");
});

app.listen(4000, () => console.log("The server is listening on port 4000"));

In  my package.json I have a script that is:
"scripts": {
  "start": "onchange -i -k **/*.js -- node index.js"
}

It does work locally in my computer, however when running in a Docker container it doesn't detect the changes and nothing happens.

@zefexdeveloper So the file watcher is chokidar. I didn't find much on Docker, but I did find https://github.com/paulmillr/chokidar/issues/590. Have you had any luck with chokidar directly or any other file watchers for node.js?

@blakeembrey I haven't tried chokidar directly on docker to be honest. I was using nodemon with the legeacy watcher but I'm having a lot of problems with it and for that reason I'm looking for an alternative, I tried to use onchange (hoping it would work) but for some reason it doesn't.

@zefexdeveloper Can you try https://github.com/Qard/onchange#poll--p-ms---poll-ms as a workaround for now? It might be an issue with the mounted directory in Docker so polling would be a workaround (I know Windows mounted partitions have a similar issue).

@zefexdeveloper It's having the same problem as I was having with nodemon, it seems to not be closing the process and trying to open another one.

Error: listen EADDRINUSE: address already in use :::4000

https://github.com/remy/nodemon/issues/1477

@zefexdeveloper You're saying it isn't closing the previous process before starting a new process? That seems odd since it listens for exit on the process before spawning another, but I'll have to give it a go to replicate. Do you have a simple repo with the above configuration to get started there? I can do it myself too, but it may take a bit longer to get around to is all 😄

@blakeembrey Yes, it's really weird, but it's like opening a new process and that is why it's saying that the port is already in use.
I don't have a repo with the configuration I sent, I can do that later (it's 4AM for me right now), or you can try in the mean time. (if possible)

@blakeembrey It was fixed in nodemon, the problem ps tree a module based on node-kill-tree, the same module you are using. That is how it was fixed:
https://github.com/remy/pstree/commit/5f58daf1e13038b279d6e79e608040eb5e07a36e


color palette overflow

Hello,
I've used a translator, so please understand if the tone comes across as impolite.
I use the terminal at a quarter of its original size. The color palette looks weird if it goes beyond its designated area.
Is there a way to display the output in two lines, similar to how neofetch does it?

there is no way to display the colour in two lines right now but i could possibly implement it, let me see what i can do

working on something

my environment- windows terminal- powershell 7.3.8Sent from my iPhoneOn Oct 25, 2023, at 1:56 AM, nepnep @.***> wrote:
working on something
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

fixed in v1.2.1 (might take a day or two for Microsoft to approve though)


Consider duplicated commandID as different ones for command combination

Today it’s treated as the one for the map of string to Boolean. May change to map of string to int in decider triggerer.go
and anyCom doesn’t require uniqueness today https://github.com/indeedeng/iwf/blob/82afa3d6167b2dbc98014a9090498055c093c85c/service/interpreter/activityImpl.go#L125

https://github.com/indeedeng/iwf/compare/fix-any-com-2?expand=1


Fix a few issues in the readme

This fixes:

Broken git clone links
Spelling of Vim as VIM

The git clone links use SSH which is good for working on a repository but publicly sharing the SSH link will lead to a "Permission denied" error for anyone that uses it.

Wow, that's great! could you keep the question about the m part of Vim ? I'm not quite sure I have anything that's Vim specific

Alright, done.

And now, ladies and gentlemen, I present you, the first merged pull request! In my reps, of course.
Thank you, stranger! It does not seem like much, but it's a milestone nonetheless


Consider moving BlockedParams to paramfilter

nice, if we're going to add the tests here, then we might want to move the actually params to block here as well. super duper optional tho
Originally posted by @evan-forbes in https://github.com/celestiaorg/celestia-app/pull/3007#pullrequestreview-1839913987

@evan-forbes is the proposal to move https://github.com/celestiaorg/celestia-app/blob/cd0a1cdbb2b06c9e3e89bbdaa54cfbfbb23a5c6d/app/app.go#L733-L746 from the app package to the paramfilter package? I think that's API breaking but do-able.

yeah, I think that would close this issue. I'm still of the opinion that its super optional. I don't see that much benefit either way.
we could explore other refactors as well. in the context of versioning and migrations, there might be a small benefit to moving the module. It could also make it worse if we have to import a bunch of modules with their own go mods there just to name them

kk if super optional, let's close as won't do for now. Please reopen if there's a compelling reason to do this


Smart Versions Based on level

An extension to the Smart Versions Based on Talents?#336 discussion.
As a multiboxer, leveling new teams, I would like to be able to make one macro that operates for my character through to max level. I've been achieving this by doing simple talent checks but it's not ideal for all classes.
GSE would swap to a new version of the macro when the character hits the specified level.
TIA
Bnet: Jabberie#2394
Discord: Jabberie#1275

Hi Jabberie
I have been looking into this and am not going to do this at this time.  BfA changes will make this much more achievable.


feat: add versioning on cli

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 74.568%

Files with Coverage Reduction
New Missed Lines
%

common/src/tap/checks/deny_list_check.rs
1
97.35%

Totals

Change from base Build<PHONE_NUMBER>6:
-0.01%

Covered Lines:
5354

Relevant Lines:
7180

💛  - Coveralls


Records have been deleted automatically in Kong 1.0.3 with a postgresql WAL ha

Summary
I have configured kong on kubernetes 1.13.3 today, and use postgresql 11 as database, the postgresql is an HA cluster using Streaming Replication with 3 nodes.
After initialize the kong database use docker pod, I have created service and route items by calling kong api. And I can searched out the data on postgresql shell:
kong=# select * from services;
                  id                  |       created_at       |       updated_at       | name  | retries | protocol |    host    | port | path | connect_timeout | write_timeout | read_timeout
--------------------------------------+------------------------+------------------------+-------+---------+----------+------------+------+------+-----------------+---------------+--------------
 93d32b78-cb52-4a7f-9363-8d13ea6f043d | 2019-03-07 20:22:56+08 | 2019-03-07 20:22:56+08 | konga |       5 | http     | konga.kong | 1337 | /    |           60000 |         60000 |        60000
(1 row)

But I don't know why the service record has been deleted automatically after a while:
kong=# select * from services;
 id | created_at | updated_at | name | retries | protocol | host | port | path | connect_timeout | write_timeout | read_timeout
----+------------+------------+------+---------+----------+------+------+------+-----------------+---------------+--------------
(0 rows)

I have tried multiple times, the record always been deleted.

Kong version (1.0.3)
PostgreSql 11
Kubernetes 1.13.3 with OVN

Is it possible that the nodes running the database were not using persistent storage and were restarted, thus the data was lost?

@p0pr0ck5 Thanks reply.
I am using external pgsql

Is the auto-deletion executed by kubernetes-ingress-controller? I have used the all-in-one-postgres.yaml to deploy kong.
The auto-deletion behavior disappears after I remove deployment "kong-ingress-controller".

@hbagdi any thoughts on this?

yes the deletion is because of ingress controller afaik.

When using Kong's Ingress Controller alongside Kong, it takes care of managing all entities in Kong's database. You should not use Kong's Admin API to configure Kong in that case but use k8s's Ingress resource and custom resources provided by the Ingress Controller to configure Kong.
Any entity created manually using Kong's Admin API will be deleted by the Ingress Controller if the corresponding resource doesn't exist in Kubernetes.

I have exactly the same problem BUT with Cassandra.
curl -v -i -X POST \
   --url http://ab9d295417d5011e9a0c4065c4345677-107646778.eu-west-1.elb.amazonaws.com/admin/services/ \
   --data 'name=football-service' \
  --data 'url=http://sport-stats-service.default.svc.cluster.local:9000/apirest/football'

And my ingress is routing properly to the ingress controller, so my question is if we want to add our apis to our gateway how do that? Because if every is getting moro complicated perhaps is better use Kong without kong ingress controller and use for example nginx. I don't know .. any advise ?

I've seen this issueConsumers created via Kong Administrative API are deleted  have you solved this problem?
Our consumers(users of apis) are created in other graphics interfaces and make calls to the KONG admin Api. It's means add consumers, routes, subscriptions, request token etc .. so what is our choice in this case?

If you are using Kong with Ingress Controller, any entity created via the Admin API will be automatically deleted by the Ingress Controller.
With Kong Ingress Controller v0.5.0 (not released yet), adding consumers via the Admin API and managing Kong's configuration using Ingress definitions will be possible.

That's a problem for us, meanwhile Can we'll put any other ingress controller  like nginx ingress controller or any other? we've try installing kong-dist-kubernetes  version and we refactored the services type from LoadBalancer -> ClusterIP  + nginx ingress controller + ingress but always get a - { "message": "Not found" } when request admin api..  all of this is until you release Kong Ingress Controller v0.5.0 .

All of this is until you release Kong Ingress Controller v0.5.0 .

The rc0 is out.

we've try installing kong-dist-kubernetes version and we refactored the services type from LoadBalancer -> ClusterIP + nginx ingress controller + ingress but always get a - { "message": "Not found" } when request admin api. Is there any guide for routing kong api (admin+proxy) behind nginx ingress controller?

There is no guide that we have but this should not be any different than exposing a regular service in k8s. It seems to me that the 404 response you are seeing is indeed coming from Kong (and not nginx ingress controller), can you post the request you are sending through?

Finally I solved my problems with ambassador + kong. I have to try with Kong Ingress Controller v0.5.0 expecting use Kong Api an if it work we gonna remove Ambassador Ingress Controller  and put the Kong Ingress Controller ..

how to delete data from kong using sql query in nodered may using function or another?


Problems with System.Private.CoreLib

I'm getting an FileNotFoundException when I try to load assembly with Blazor.
System.IO.FileNotFoundException: Could not load file or assembly 'System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e' or one of its dependencies

Note that I generate the assembly myself with Roslyn so the problem may be there, but it works well on .NET Core. I have tried to not reference the System.Private.CoreLib but the build fails with errors like: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Private.CoreLib....
Would you have an idea how to solve the problem?
EDIT: I have also tried adding the System.Private.CoreLib assembly to src/mono/incoming/bcl, but then it fails with "System.TypeLoadException: Could not find method due to a type load error"... which seems like that this does not work ;(

It sounds like you're trying to load a netcoreapp assembly. You can only use netstandard assemblies with Mono for WebAssembly.
If this is not the case and you can provide a repro, please let us know!


mutiple zone

may i know if it support mutiple CF_ZONE_ID ?

To get logs from multiple zones, deploy individual Helm charts release: one per zone.

expired


Terraform aws_eks_node_group doesn't set a correct group name

I have issues
aws_eks_node_group doesn't set a correct group name from value node_group_name to Auto Scaling Groups
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Auto Scaling Groups after creation by aws_eks_node_group have random name (like eks-0eb97841-2793-dbd5-f6a9-c0dfe217a049 )
If this is a bug, how to reproduce? Please include a code sample if relevant.
resource "aws_eks_node_group" "stage-worker" {
cluster_name    = aws_eks_cluster.wchess-stage.name
node_group_name = "stage-worker"
node_role_arn   = aws_iam_role.stage-node.arn
subnet_ids      = aws_subnet.wchess-stage[*].id
disk_size       = 20
instance_types  = ["t3.medium"]
scaling_config {
desired_size = 1
max_size     = 2
min_size     = 1
}
labels = {
purpose = "worker"
}
depends_on = [
aws_iam_role_policy_attachment.stage-node-AmazonEKSWorkerNodePolicy,
aws_iam_role_policy_attachment.stage-node-AmazonEKS_CNI_Policy,
aws_iam_role_policy_attachment.stage-node-AmazonEC2ContainerRegistryReadOnly,
]
}
What's the expected behavior?
Auto Scaling Group name must be equal value from node_group_name. I.E. "stage-worker".
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version:
OS:
Terraform version:

Any other relevant info

Hi. This is a feature of how the AWS Managed Node Groups system works. The ASG name is generated by AWS's systems. This is not something the module can have any control over. I would hazard a guess thatthis is to work around any potential issues with naming conflicts. But I can't speak for the AWS container team as I have no relationship with them.
I can't see any existing request on their board about this. https://github.com/aws/containers-roadmap/issues?q=is%3Aissue+is%3Aopen+label%3A"EKS+Managed+Nodes"+