Bst each should return enumerator

Ruby's core collections all have #each return an enumerator when the method doesn't get a block. Bst should do the same, so I updated the tests and example.rb to reflect this.

If you are enforcing this in the test, are you removing the discussion from the solution?
Up until your test, I don't see any tests that check for "type".
If it must be tested for, I am glad it is the last test.  But in having them solve for the return, the discussion of "why" may be lost on the website.
You also seem to be testing Ruby itself, in lines 99 and 101, on a built in class, that it will raise StopIteration, as spec'ed in the language itself.  If Ruby breaks, hopefully we find out about it, but not through this test.
I think the entire test could be expressed as:
  def test_each_returns_enumerator_if_no_block
    skip
    assert_kind_of Enumerator, Bst.new(4).each
  end

If you are enforcing this in the test, are you removing the discussion from the solution?

Maybe, but I find that virtually nobody on exercism is aware of the idiom of returning an enumerator and as a result almost nobody is mentioning it in the discussions. My reasoning is that adding it to the tests is at least going to raise that awareness.

Up until your test, I don't see any tests that check for "type".

Yeah I wasn't keen on the check for Enumerator. I took some time browsing through the mini test assertions for some alternatives, but I couldn't find anything decent. I considered that you might only want to check for the duck type and leave out the test for assert_kind_of, but I was worried that people might not understand the concept of enumerators.

You also seem [...]

The problem of doing:
def test_each_returns_enumerator_if_no_block
  skip
  assert_kind_of Enumerator, Bst.new(4).each
end

is that it's possble to return an arbitrary enumerator. The only way to check if it's the right enumerator is to see if returns the same values and raises the StopIteration exception at the right point. I've actually been bitten by this when I thought it was so trivial and not worth testing. Then you add up quickly typing the wrong method name in enum_for(:method) and boom!

Checking that it returns an enumerator and checking that it returns the right enumerator are two different tests though.
But you aren't testing Bst's each in that test, you are testing Array's .each in that test.  This is why it was so trivial to toss that test out, it was testing the wrong object.
I think then, that it is your calling to give feedback on using and returning each when the review happens.  By doing this, you also give that same knowledge to others, and they start to do the same thing in their feedback.
Rather than a test to enforce implementation details, I think we need to think about how to introduce the feedback.
With the test, perhaps they implement to pass the test, but still don't get that information that you want to impart, as to the why.

But you aren't testing Bst's each in that test, you are testing Array's .each in that test. This is why it was so trivial to toss that test out, it was testing the wrong object.

I don't think I understand you. How so? The example doesn't even use an array.

Rather than a test to enforce implementation details, I think we need to think about how to introduce the feedback.

I feel very strongly that returning an enumerator is not an implementation detail. It is the intended observable result of the method.
But if you feel equally strongly about this, I can close the pull.

(1..7).each { |x| assert_equal(x, each_enumerator.next) } is what I am talking about as to the testing the Array.
I think it is fine being open for a while, I need to think about how this will effect discussions in the code submissions, if having it there accomplishes the goal you have in mind, which is to make the 'best practice' known.
If it is accepted, but doesn't accomplish your goal, then it is counter productive to take it in.  That is the only concern I have for it.
However, with that said, it is useful to have the example.rb show this in the code, even perhaps with a comment.  It isn't something that normal exercist reviewers see, but it is there for us to see, as a reminder when we go to touch the exercise again.

OK, so here's a completely different direction... what if Rikki automatically commented about it if the bst each wasn't following the idiom?

It is good, because it leaves it open to make the solution as they would, and remembers to always mention it so we don't have to.
And I like that. :)

I like putting it in the rikki since it brings up a discussion point, but I still feel that having an enumerator is the method's observable behaviour. It's part of the expected functionality. Not returning an enumerator is so non-standard that I would expect a client to specify it as required behaviour.
If you do decide to put it in the rikki than I suggest making it specific to #each, not just Bst#each (although I'm not aware of any other exercism requiring an #each method).

If you do decide to put it in the rikki than I suggest making it specific to #each, not just Bst#each

Agreed. Even if other exercises don't require an each, if someone does implement one it would be the perfect time to bring up the idiom.

What's the status of this PR? If @remcopeereboom still wants to merge it let's get it back on track!

@kytrinyx are we waiting on Riki issue exercism/rikki#16 or should we merge it now?

No, rikki-'s going to take its sweet old time, I'm afraid. Let's merge this.

Thanks @remcopeereboom for the patience and hard work on this.


refactor(L2GFeatureMatrix): streamline feature matrix management

✨ Context
Rewrite of all the logic to generate features. Not all previous features are available (more below); I want to know if this POC is good to keep working.
L2GFeatureMatrix.from_features_list will be the main entry point. It reads a list of feature names from the config and instantiates the FeatureFactory. FeatureFactory.generate_features is the responsible of iterating over this feature list.
A schema of the new design is here:

https://excalidraw.com/#json=FSOwgU37GReVJuRGCjE6f,LAfIi3o_VJ635XCHNBmG7g
🛠 What does this PR implement
Feature Factory changes:

L2GFeatureMatrix is no longer a dataset subject to schema validation
L2GFeature is an abstract class with 2 attributes: study_loci_to_annotate and feature_dependency_type and one key method compute. study_loci_to_annotate is the gold standard or the study locus object on which the feature will be based, and feature_dependency_type is the type(s) of the objects required to compute that evidence
Addition of L2GFeatureInputLoader, a class in feature factory that generates a dictionary with the dependencies to compute features. The key is the name of the dependency, the value is the content. It is generated reading kwargs.
Colocalisation changes:
Rewrite of the colocalisation feature factory for the local features. Even though the coloc features are split by method and QTL type, I was able to abstract most of the core business inside Colocalisation.extract_maximum_coloc_probability_per_region_and_gene. The code we have to write per feature is now minimal.
Addition of Colocalisation.append_right_study_metadata to bring the study type and the gene info from the right association

Other:

Addition of StudyLocus.build_feature_matrix to call within the step
Addition of L2GGoldStandard.build_feature_matrix to call within the step
The feature matrix is now written during the training step. It makes more sense to dump the dataset that produced the model.
Unit and integration tests (the semantic ones in coloc are commented out)

🙈 Missing

Should I split the feature_factory.py module per feature group?
Not all previous features are available:

The local ones extracted from colocalisation are ready.
The neighborhood ones extracted from colocalisation are not there (these are derived from the local)
The ones derived from distance are pending to be included (and parsed from the variant index). I didn't want this PR to become even larger.

🚦 Before submitting

[ ] Do these changes cover one single feature (one change at a time)?
[X] Did you read the contributor guideline?
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you make sure there is no commented out code in this PR?
[X] Did you follow conventional commits standards in PR title and commit messages?
[X] Did you make sure the branch is up-to-date with the dev branch?
[X] Did you write any new necessary tests?
[X] Did you make sure the changes pass local tests (make test)?
[X] Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@xyg123 please review it too

Oveall the solution looks nice, for now on adding new features should be straight forward. @xyg123 please check the feature implementations, as I do not have so much experience with the distance features.

All looks good, didn't see the distance features on this PR, but the coloc features looks consistent with what we had before

I had to make changes after adding semantic tests for extract_maximum_coloc_probability_per_region_and_gene and realising there was a problem when the input dataset to annotate was of type L2GGoldStandard.
The problem was that when I wanted to annotate a gold standard with the maximum colocalisation score from a eQTL for a gene, I was only calculating it for those study loci present in the gold standard. For example:
sample_gold_standard.df.show()
+------------+---------+-------+------+---------------+----------+
|studyLocusId|variantId|studyId|geneId|goldStandardSet|   sources|
+------------+---------+-------+------+---------------+----------+
|           1|     var1|  gwas1|    g1|       positive|[a_source]|
+------------+---------+-------+------+---------------+----------+

sample_colocalisation.df.show()
+----------------+-----------------+----------+--------------------+--------------------------+---+
|leftStudyLocusId|rightStudyLocusId|chromosome|colocalisationMethod|numberColocalisingVariants| h4|
+----------------+-----------------+----------+--------------------+--------------------------+---+
|               1|                2|         X|               COLOC|                         1|0.9|
+----------------+-----------------+----------+--------------------+--------------------------+---+

sample_study_index.df.show()
+-------+---------+------+---------+
|studyId|studyType|geneId|projectId|
+-------+---------+------+---------+
|  gwas1|     gwas|  null|       p1|
|  eqtl1|     eqtl|    g1|       p2|
+-------+---------+------+---------+

This function has a step where it adds the study type and the gene from the QTL study (the right side). Because the gold standard doesn't have all possible study loci, when I run the function the metadata is blank:
sample_colocalisation.append_right_study_metadata(sample_gold_standard, sample_study_index, ["studyType", "geneId"]).show()
+-----------------+------------+--------------+-----------+----------------+----------+--------------------+--------------------------+---+
|rightStudyLocusId|rightStudyId|rightStudyType|rightGeneId|leftStudyLocusId|chromosome|colocalisationMethod|numberColocalisingVariants| h4|
+-----------------+------------+--------------+-----------+----------------+----------+--------------------+--------------------------+---+
|                2|        null|          null|       null|               1|         X|               COLOC|                         1|0.9|
+-----------------+------------+--------------+-----------+----------------+----------+--------------------+--------------------------+---+

The solution was to pass study locus as a dependency of the colocalisation feature factories.

@xyg123 @project-defiant Sorry it took me a while to merge. Thank you for your suggestions! There is no major change in the logic, so I'll merge unless you say otherwise.


Add Offcanvas menu component

Added a left offcanvas d60b4731294c40959a137b423cab5a41e2393ce7
Still need to tweek the full screen on small screen option so it doesn't flicker when resizing and make one for the right size

Removed the need for Javascript. Everything is done with CSS only.
Fixed the flickering.
Added a right offcanvas menu
Added some styling


Update PPP format issues

Indented numbers not registering as a proper number list.

Codecov Report

Merging #261 (0b24f98) into master (0d6776e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage     67.46%   67.46%
  Complexity      694      694
=========================================
  Files           122      122
  Lines          2330     2330
  Branches        275      275
=========================================
  Hits           1572     1572
  Misses          638      638
  Partials        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb40ec5...0b24f98. Read the comment docs.


Use Vitepress

Problem
The current documentation is typedoc, which is not user-friendly as a guide.
Solution
Use Vitepress as a document generator so that we can provide more human-readable guides about installing, running the server, configuring, etc.
Further works
How can we integrate both typedoc and vitepress?
Currently, there are two options:

Generate markdown or Vue code from typedoc JSON output.
Use a subdomain, like api.seia.dev and provide a direct link to typedoc from vitepress.

Generate markdown or Vue code from typedoc JSON output.

Maybe we can use typedoc-plugin-markdown to generate markdown code?


add "repository" field to package.json

Add the "repository" field to the package.json based on https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

Thanks @hzrd149 !


Relax activesupport dependency to support Rails 5

👏  thanks for getting this merged. I hope we get a new release with this soon?

Yep, in 20 hours.
2016-10-25 23:06 GMT+03:00 Chris Beer<EMAIL_ADDRESS>
👏 thanks for getting this merged. I hope we get a new release with this
soon?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bluepill-rb/bluepill/pull/46#issuecomment-256160307,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAG3hGFZ2QjaZuB0WsNF1Gf9BuwUOPhgks5q3mFRgaJpZM4KfEVe
.

Wonderful, thank you.

Sorry to nag -- any update on the release schedule for this?

Does anyone have this working with activesupport 5?  I pointed my gemfile at bluepill's master branch and am getting the following error:
/usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/specification.rb:2285:in `raise_if_conflicts': Unable to activate bluepill-0.1.2, because activesupport-5.0.2 conflicts with activesupport (< 5, >= 3.2) (Gem::ConflictError)
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/specification.rb:1408:in `activate'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems.rb:196:in `rescue in try_activate'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems.rb:193:in `try_activate'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:125:in `rescue in require'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `block in require'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:259:in `load_dependency'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `require'
	from /Users/keithjohnson/play/fleet/models/vehicle.rb:1:in `<top (required)>'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:120:in `require'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:120:in `require'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `block in require'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:259:in `load_dependency'
	from /usr/local/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `require'
	from /Users/keithjohnson/play/fleet/vehicle.rb:3:in `<top (required)>'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/Cellar/ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from test.rb:1:in `<main>'

Just released 0.1.3


Ngrx Store not receiving cached response from Observable from interceptor

In GitLab by @lakhoune on Oct 19, 2020, 11:04
Location: effects.ts file on fetchCards and fecthLectures actions
Description: The interceptor creates an Observable from the cached response, but the the response is not passed on in the service, nor in the effects pipe chain
Expected behaviour: effect makes a call to the service, which will load the cards from the server. This call is intercepted by the http interceptor which will look up if there is a cached response. If there is one it will return an observable of the response and not make an http call to the server. The observable is returned by the service and the store gets the response and updates its data
Steps to reproduce: Go to a lecture. Refresh the page. The cards will be undefined

In GitLab by @lakhoune on Oct 19, 2020, 11:06
about ngrx store effects: Guide
about http interceptors: Docs , Guide

In GitLab by @lakhoune on Nov 2, 2020, 17:11
Stackoverflow issue

In GitLab by @lakhoune on Jan 27, 2021, 16:44
mentioned in commit 6fb4b4f40fff837421b8cc831b8f519b7c731f20

In GitLab by @lakhoune on Jan 27, 2021, 16:48
It seems like the issue happends only if the component has not yet been initialized. The behaviour can be observed when doing the following:

delete the lectures from localstorage
refresh (here cards will be loaded from server)
navigate to a route and then navigating back home using the button in the navlist.
The lectures are now correctly loaded from cache. However when refreshing the page it does not work


Validator Version 4

Validator was originally written when I was learning Swift (Swift 2) and has been adapted for Swift 3 and Swift 4. Now feels like a good time to update the code to honour the latest SDKs and Swift conventions.
Goals:

Eliminate that horrible Objective-C run time stuff.

Make the ValidationResult a monoid and follow functional programming conventions over those dodgy merge style methods.

More 'Swifty' APIs where possible.

Add CI support with Travis.

Do not forget to fix #113, it is a widely used rule. Actually, I'm not sure why you use generics in the first place; this is a text field, its input type will be String one or the other way.
P.S. I would like to work with you in this. You might contact me at<EMAIL_ADDRESS>if you like.

Make the ValidationResult a monoid and follow functional programming conventions over those dodgy merge style methods. Can't transform empty values in the validation enum.

TODO:

[ ] Travis
[ ] Eliminate that horrible Objective-C run time stuff.
[ ] swift-package
[ ]

Just a thought for version 4, sometimes when using the validate function you also need to get a list of rules which validation succeeded on, not just errors. For example: if I input "qwerty" as my password and I have 3 rules, length x 8, uppercase x 1, lowercase x 1, I might display to the user 2 rules as error messages, but also show that they have satisfied the lowercase condition. Under a text field it would look like this:

|qwerty    |

✅at least one lowercase
❌at least one uppercase
❌at least 8 characters
This becomes harder to do unless individual models are returned with validation status, or if in addition to errors we also received unused errors or something to that effect.
Maybe version 4 can address this?

Do not forget to fix #113, it is a widely used rule. Actually, I'm not sure why you use generics in the first place; this is a text field, its input type will be String one or the other way.
P.S. I would like to work with you in this. You might contact me at<EMAIL_ADDRESS>if you like.

Actually, I use validator quite a lot without UI and therefore validation for numbers are quite useful.

@piv199, then a separate number validation should be implemented. But "textview" says it's a UI for text. It's input is string at the first place. To make the code more flexible, trashing the scope is not a good idea.
For the coupling between error and message, I do not understand what you really mean. What I understand is the need of creating custom Error's with messages. If it is what I understand, there is no better and basic approach since Swift's Error is an interface without any initializers or etc.


(refactor)types: include application kind into chaosengine spec

Signed-off-by: ksatchit<EMAIL_ADDRESS>
What this PR does / why we need it:

Includes information about application resource type in the chaosengine schema (deployment, statefulset, daemonset). This will aid filtering the application chaos candidates and deriving the application UUID.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[ ] Fixes #
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has upgrade related information
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] Labelled this PR & related issue with documentation tag

The changes to handle different resource types will be made in a new PR


versions: Add tilde to clap dependency

Add tilde to the clap version as we only want to allow patch level updates, not minor versions as a ^4.2.7 does

With the previous code, generating the Cargo.lock from (which happened as we don't check it in here), resulted in the version being bumped:
$ cat Cargo.toml | grep clap
clap = "4.2.7"
$ cargo generate-lockfile
    Updating git repository `https://github.com/krustlet/oci-distribution.git`
    Updating crates.io index
    Updating git repository `https://github.com/kinvolk/azure-cvm-tooling`
    Updating git repository `https://gitee.com/anolis/csv-rs`
    Updating git repository `https://github.com/virtee/kbs-types`
    Updating git repository `https://github.com/occlum/occlum`
warning: skipping duplicate package `init` found at `/Users/stevenh/.cargo/git/checkouts/occlum-09e22bc8c2a4bfe1/b5a32a8/demos/remote_attestation/azure_attestation/maa_init/init`
warning: skipping duplicate package `init` found at `/Users/stevenh/.cargo/git/checkouts/occlum-09e22bc8c2a4bfe1/b5a32a8/demos/runtime_boot/init`
    Updating git repository `https://github.com/intel/SGXDataCenterAttestationPrimitives`
warning: skipping duplicate package `app` found at `/Users/stevenh/.cargo/git/checkouts/sgxdatacenterattestationprimitives-d6934a418e6beae0/71557c7/SampleCode/RustSGXQuoteGenerationSample`
    Updating git repository `https://github.com/mdaffin/loopdev`
    Updating git repository `https://github.com/sigstore/sigstore-rs.git`
$ cat Cargo.lock | grep clap
 "clap 4.4.1",
 "clap 4.4.1",
 "clap 4.4.1",
 "clap 2.34.0",
name = "clap"
name = "clap"
 "clap_builder",
 "clap_derive",
name = "clap_builder"
 "clap_lex",
name = "clap_derive"
name = "clap_lex"
 "clap 4.4.1",
 "clap 4.4.1",
 "clap 4.4.1",

with the tilde requirement, it can only update the patch level:
$ cat Cargo.toml | grep clap
clap = "~4.2.7"
$ cargo generate-lockfile
    Updating git repository `https://github.com/krustlet/oci-distribution.git`
    Updating crates.io index
    Updating git repository `https://github.com/kinvolk/azure-cvm-tooling`
    Updating git repository `https://gitee.com/anolis/csv-rs`
    Updating git repository `https://github.com/virtee/kbs-types`
    Updating git repository `https://github.com/occlum/occlum`
warning: skipping duplicate package `init` found at `/Users/stevenh/.cargo/git/checkouts/occlum-09e22bc8c2a4bfe1/b5a32a8/demos/remote_attestation/azure_attestation/maa_init/init`
warning: skipping duplicate package `init` found at `/Users/stevenh/.cargo/git/checkouts/occlum-09e22bc8c2a4bfe1/b5a32a8/demos/runtime_boot/init`
    Updating git repository `https://github.com/intel/SGXDataCenterAttestationPrimitives`
warning: skipping duplicate package `app` found at `/Users/stevenh/.cargo/git/checkouts/sgxdatacenterattestationprimitives-d6934a418e6beae0/71557c7/SampleCode/RustSGXQuoteGenerationSample`
    Updating git repository `https://github.com/mdaffin/loopdev`
    Updating git repository `https://github.com/sigstore/sigstore-rs.git`
$ cat Cargo.lock | grep clap
 "clap 4.2.7",
 "clap 4.2.7",
 "clap 4.2.7",
 "clap 2.34.0",
name = "clap"
name = "clap"
 "clap_builder",
 "clap_derive",
name = "clap_builder"
 "clap_lex",
name = "clap_derive"
name = "clap_lex"
 "clap 4.2.7",
 "clap 4.2.7",
 "clap 4.2.7",
$

Apologies for missing this in round 1


New Theme: Anne Pro 2

Anne Pro 2 is a mechanical keyboard:
https://github.com/gildasio/anne-pro-2

Hey, that's very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉


feat: pr template

closes #1813

:tada: This PR is included in version 1.212.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix boxing in async func

Part of https://github.com/gtk-rs/gir/issues/807
cc @GuillaumeGomez , @sdroege

Seems it depends on https://github.com/gtk-rs/gio/pull/232

Restarted CI

Strange error repeated, I don't understand why it was not in gio travis.
Also this code on line 478
  --> /home/travis/.cargo/git/checkouts/gio-a4b825b310a073b9/1b2740a/src/auto/app_info.rs:863:25

    |

863 |         let uris = uris.map(ToOwned::to_owned);

    |                         ^^^

    |

    = note: the method `map` exists but the following trait bounds were not satisfied:

            `&mut &[&str] : std::iter::Iterator`

            `&mut [&str] : std::iter::Iterator`

I restarted CIs.

CI passed

👍
cc @sdroege

:+1: Also as green as it goes, @GuillaumeGomez

Thanks @EPashkin !


Add jenkins for deploys

Migrated Jenkins over from the Digital Marketplace challenge.
Jenkins configuration needs to happen per project on GUI differently depending on the needs of the project.
Not sure if we need to merge this branch because not all projects need it and it still would require configuration and just keep it alive as a PR/Branch 🤷♂
Looking for feedback/questions/concerns.
Part of deploying this, we also need two servers (lightsail instances are recommended) and some configuration around those as well. I dont think that's relevant to the documentation because it has nothing to do with deployments or Jenkins. I can try to make the instructions as verbose as possible but if someone who has never done Jenkins/deployments picks it up and somehow manages to deploy following hand held instructions. They would have no clue what to do at the sign of first error

Logged WEB-89 to track the leftover renaming/sanitization changes :) Looks good to go!


Sync: TraitObject Lifetime

Description

Sync the values in the Synced list below.
Create an end to end (E2E) tests for this lifetime sync (1 from the server side and 1 from the client side. Client test should not create object)
Create a command to create and delete (if applicable) the synced object see similar command

Also see additional information at the bottom for more information and templates
Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#collection-patching
Lifetime Sync Dataflow

Location

Create a branch based from development
Related Issues

N/A
Requirements

N/A
Additional information

Using the GameInterface Service Tempale create commands to test the synced values.
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit E2E tests exist for every synced collection on the server (and client if applicable)
[ ] Each collection has a command for each type of synced update

TraitObjects are set on start, thus already exists on all clients and never change. No sync needed.


"Not a valid value"

Describe the bug
When I try to start the add-on, I get a dialog with "Go to configuration not a valid value"
When I try to save the configuration, I get,
Failed to save add-on configuration, not a valid value. Got {'updateInterval': 300, 'babelLocale': 'en_CA', 'TZ': 'America/Toronto', 'debug': False, 'mqtt': {'broker': '********', 'port': ****, 'username': '*****', 'password': '*****'}, 'volvoData': {'username': '******', 'password': '******', 'vin': '******', 'vccapikey': '*******', 'odometerMultiplier': 1, 'averageSpeedDivider': 1, 'averageFuelConsumptionMultiplier': 1}}

(private information replaced by *****)
It would be really helpful if there could be useful information on what's wrong with the configuration. Nothing appears in the logs.
To Reproduce:
Steps to reproduce the behavior:

Go to add-on info page
Click on Start
notice dialog
Click Edit config
Click Save
Notice error message

Expected behavior:
I expect my previously working config to continue working, or for useful diagnostic messages to be able to guide me to a resolution.
Screenshots:
If applicable, add screenshots to help explain your problem.
Version info:
Volvo2mqtt 1.7.5
Home Assistant 2023.7.1
Supervisor 2023.07.1
Operating System 10.3
Frontend 20230705.1 - latest
Logs:
Logs in the UI are empty
If you are using the HA Addon the log location is \\<Your HA Host IP>\addons\volvo2mqtt\log\volvo2mqtt.log

Ah, this appears to be related to https://github.com/Dielee/volvo2mqtt/issues/51 - adding quotes around the port number fixed it. I would argue it's still a bug that there's no useful error message or migration path though.

Jep, I know this is a breaking change. Unfortunately there is no way to edit the error message from the addon.
Adding a migration path is an option, but this change is still a few days old. So most people are using a version >= 1.7.0.
And this change is also documented in the addon changelog!

I had missed that, as my frontend was inaccessible for a few days of updates while I tried to convince Google my instance was not a phishing site.


[Event Request] Record::"Customized Calendar Entry" - Function GetCaption OnAfterGetCaption

As we have some more Tables that use Cust. calendars, we need a possibility to control the caption accordingly. Therefore an event like "OnAfterGetCaption" (or OnBefore or something else) is needed.
[EventSubscriber(ObjectType::Table, Database::"Customized Calendar Entry", 'OnAfterGetCaption', '', true, true)]
local procedure "Customized Calendar Entry_OnAfterGetCaption"
(
    var CustomizedCalendarChange: Record "Customized Calendar Change";
	CustomizedCalendarEntry: Record "Customized Calendar Entry"
)
begin

end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Icons/Images not shown for word add-in under the developer addin section

Hi Team,
The icons are not visible under the word addin

but the icons under the ribbon are visible that were added as part of Group Tag, not sure why the icons are not visible under that developer add-in section.
we have added the below tags also
 <IconUrl DefaultValue="https://localhost:5001/assets/logo-32.png"/>
 <HighResolutionIconUrl DefaultValue="https://localhost:5001/assets/logo-64.png"/>

the add-in that show under developer add-in section picks the name from the below tag
  <DisplayName DefaultValue="Test dev"/>
But I am not sure if we need a separate Icon tags, that is added for other ribbons/Group buttons just like this.
                 <Icon>
                    <bt:Image size="16" resid="Icon.16x16"/>
                    <bt:Image size="32" resid="Icon.32x32"/>
                    <bt:Image size="80" resid="Icon.80x80"/>
                  </Icon>

Can you please help me in finding a solution to resolve the issue.
Thanks in advance.

Hi @UMAMAHESHWARIG,
I'm sorry you're having this display issue. Which sample project are you using?

Hi @AlexJerabek please find the sample link  as per my observation the icons are not getting displayed irrespective of the manifest that I have used to test again and again

Hi @UMAMAHESHWARIG,
Thank you for the context. I was unable to reproduce the issue in the Word tutorial sample. I'm going to transfer this issue to the office-js repo, where product issues are reported and investigated.


Fix IP Detection

Previously it detected the ip addresses from within a container, so wouldn't get all the machine interfaces

This was fixed in 0.5.2 by adding the --host flag to the databox start command


PR: Update conda-based installers

Description of Changes

Added StartupWMClass to Linux desktop file. This obviates the need to change the name of the desktop file in the post-install script.
Added installer tests for Linux and Windows
Minor CI workflow updates

@dalthviz @ccordoba12 I'm having trouble getting the Windows test to work properly; perhaps you guys have some insight.
The following should execute the exe installer from the bash command line in silent mode:
$ cmd.exe /C start /wait "<path to exe>" /S

I've successfully tested on my Windows VM (with bash shell), but can't get it working in CI. From the logs it appears that cmd.exe is executed but the executable path is not resolved properly: the cmd.exe banner is printed but the installer does not run.

The following should execute the exe installer from the bash command line in silent mode

I can see that you're not using a Bash shell to run the installer tests on Windows (i.e. there's no shell: bash in the Test Installer Application step). And I think the default shell used by Github Actions on Windows is cmd.

I can see that you're not using a Bash shell to run the installer tests on Windows (i.e. there's no shell: bash in the Test Installer Application step). And I think the default shell used by Github Actions on Windows is cmd.

Hmm. For the build-installers job I am using a default shell defaults: run: shell: bash -l {0}, and the Test Application Bundle step is a bash script. And in the same step I've confirmed [[ -e "$PKG_FILE" ]] && echo "Installer exists" || echo "Installer does not exist" successfully reports that the $PKG_FILE exists while running in Windows.

Ok, sorry for the noise.

Ok, sorry for the noise.

No worries, thanks for looking at it.


useDebugValue dummy function for compatibility with react-jss 10.0.0

Hi,
this implements a dummy useDebugValue for compatibility with react-jss 10.0.0.

Coverage increased (+0.005%) to 94.378% when pulling 68edd9a6fbfc09a2c8af7dace617def2a375e348 on janbiedermann:useDebugValueDummy into e9e7d6d501ef16a839cbb891f61bb13dfada2054 on NervJS:master.


How to import component style ?

Hi. This is a great template ! But, I'm really lost in webpack config. I need to customize the appearance of my component, and test responsive layouts. How can I do it? Simply import ../../dist/<component>.css inside the test spec doesn't work. It says I need a loader. Fine! But how ? Where ? Thanks a lot if you can help.

Hello, I'm glad you like it.
You need to add a css-loader in the webpack.config.base.js
But I really recommend you to keep the CSS in the Vue component style or include it with
<style src='component.css'></style>

Thanks for answering quickly. I am sorry, I completely missed the point of my actual question... too much work, probably.
I wanted to know how to import css inside tests specs !
In fact, I am testing a navbar fixed on top, and when running tests, it doesn't seem to take the inclyded

It should appear in the visual tests but I don't know if it is possible to write tests for the actual styles, sorry 🙁

Actually, this is my problem: it doesn't appear in the visual tests.


Added a function to split the data into n folds

This pr solves a part of issue #1068 . Will be creating another pr to solve the other parts.

@pdxjohnny I have created a file as discussed in the meeting. Let me know if any change needs to be done.

@pdxjohnny I have added the test for split method. Currently working on accuracy part.


[Feature] Fractal Generator Calculator

Description
A Fractal Generator Calculator is a tool that allows users to create and visualize complex geometric patterns known as fractals. Here’s a brief overview of its input and output:
Input:
Fractal Type: Selects the type of fractal to generate (e.g., Mandelbrot set, Julia set).
Parameters: Adjusts parameters specific to the selected fractal type (e.g., scaling factor, rotation angle).
Resolution: Sets the resolution or detail level of the fractal image.
Output:
Fractal Image: Generates a visual representation of the selected fractal.
Interactive Exploration: Allows users to zoom in/out and navigate through different parts of the fractal for detailed exploration.
Color Palette: Optionally, applies color schemes to enhance visual appeal and distinguish different elements of the fractal.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@Rakesh9100 this issue can be assigned.
@ananyag309 keto the ui similar to the already existing website

@Rakesh9100 sir please assign this issue to me under gssoc

Pls go ahead @ananyag309


Add Metadata for OpenEXR

Description
Add Metadata for OpenEXR
Checklist:

[x] I have read the contribution guidelines.
[x] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[ ] If I added or modified a C++ API call, I have also amended the
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
[x] My code follows the prevailing code style of this project. If I haven't
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.

Hi, thanks for this effort, but I think you might misunderstand what this table is.
OIIO is meant to make a common API for reading and writing image files, regardless of format, so we strive to make it so that for most ordinary operations, the app doesn't need to know or care what type of image file it is. But one problem from that is that different image formats have different conventions about what to call certain metadata. We don't want every app to need to understand all these details -- for example, that the same information may be called "ImageDescription" for TIFF, "comments" for OpenEXR, or "caption" for IPTC, etc. So for certain common metadata, we picked a single canonical name for users of the OIIO APIs, and the readers/writers will automatically rename it coming in or going out to the files.
You can see the list of these canonical names in the documentation: https://openimageio.readthedocs.io/en/v<IP_ADDRESS>/stdmetadata.html
So what that table is in exroutput.cpp (and there are corresponding ones for input in exrinput.cpp and exrinput_c.cpp that you didn't modify) is the translation key -- the list of the canonical "OIIO" names for certain common metadata, and the names that OpenEXR says they should use when saving to OpenEXR files.
Any metadata that doesn't appear in this list doesn't need an entry in the table, because it doesn't have a conventional OIIO name that must be automatically kept the same across all file formats.
If a metadata name is not in the table, it doesn't mean that it can't be saved in an OpenEXR file. It just means that it'll keep whatever name you give it.
Some of the entries you put in the table, like "CameraTint", are definitely not listed in that metadata chapter of the docs and appear nowhere in the code base, so no translation of the names is needed, thus it doesn't need to be in the table. Other items you put in the table, such as "CameraMake" already IS in that chapter, so should be using the canonical name we already chose, i.e., I think that should read
ExrMeta("Make", "cameraMake", TypeString),

which means "metadata having the conventional OIIO name of 'Make' should be written to exr files with the name 'cameraMake', and when reading exr, rename 'cameraMake' to 'Make' so that OIIO applications will know to look for it in the OIIO-standard place."
Is this making things a little more clear now?
So here's what we really need to do:

If there are "EXR standard" metadata names that correspond to OIIO canonical metadata and those names are different, there needs to be entries in the tables of exrinput.cpp, exrinput_c.cpp, and exroutput.cpp. We should definitely add any that are missing (lots have been added to the exr docs recently, so it's easy for me to believe that this needs some adjustment on the OIIO side).
If we think that some of the EXR standard metadata names (that are not currently documented by OIIO) should be elevated to be "OIIO standard metadata", we should add them to the OIIO documentation in src/doc/stdmetadata.rst. If we use the EXR/SMPTE names for these "new" metadata, then they don't need to be in the exr tables, since no name translation is necessary. But we may need to do translation in other format readers/writers and to make sure it gets saved correctly if in Exif or IPTC if it seems to correspond to things that those give specific names to!
Everything else can just stay as-is, because the exr writer will already save all named metdata with its original name by default.

Please stop making small changes to this PR.
Let's step back, take a deep breath, and start with a (non-code) discussion about what you are trying to accomplish here.
If we're going to change any of the naming of OIIO standard metadata names, let's do it for real, starting with a principled proposal for how we want to move forward with the various competing standards and potentially doing full overhaul. The fact that late this summer we are bumping to "OIIO 3.0" implies that we can make the kind of compatibility breaks that we ordinarily do not allow except for once every 5+ years. This is the ideal time to change or fix our metadata conventions, but we're not going to do it without a real discussion and consensus on the way forward.

This PR is not ready to review because:

It contains NO discussion of what the goal is, so it's hard to evaluate whether the code achieves it. What is the problem that this tries to solve? How does the code meet that goal?
It seems to be implementing a policy change about how we should handle standard metadata names, but we have not received any proposal for such a new metadata strategy that can be used to achieve consensus of the project leadership.
Parts of the PR are inexplicable and without any apparent justification, despite multiple review comments, revisions, and many pleas for more information. Why make entirely new standard metadata that are named or capitalized differently than the way we want them stored in OpenEXR files?


Build is not signing

My android build signing is failing now. Below is the debug log
Preparing to sign key @ bin/Debug with signing key
Found 2 release files.
Verifying alignment of bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed.apk (4)...
Verification succesful
---
/bin/cp bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed.apk bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-aligned.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/apksigner sign --ks bin/Debug/signingKey.jks --ks-key-alias *** --ks-pass pass:*** --out bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-signed.apk --key-pass pass:*** bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-aligned.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/apksigner verify bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-signed.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/zipalign -c -v 4 bin/Debug/com.vermaru.xamarinandroidcicddemo.apk
Verifying alignment of bin/Debug/com.vermaru.xamarinandroidcicddemo.apk (4)...
---
Verification FAILED
Error: The process '/Users/runner/Library/Android/sdk/build-tools/29.0.3/zipalign' failed with exit code 1

Ideally It should do verification for non signed apk files i.e. com.vermaru.xamarinandroidcicddemo.apk
The same was working fine till 3days back. I guess this is happening due to https://github.com/r0adkll/sign-android-release/pull/49
Note: - I'm creating single apk.

@r0adkll , Please have a look in this. I'm block currently due to this issue. Let me know if any other information needed.
Thanks

Hmmm, you could try overriding the build tools version in your yaml configuration, so something like:
README.md

env:
      # override default build-tools version (29.0.3) -- optional
      BUILD_TOOLS_VERSION: "30.0.2"

or you could try pointing this task to the old version via @v1.0.4

I tried overriding build tools version in yaml configuration but that didn't work. Time being i'm point it to 36fdfa1361ee106737f5bd9004298b08e7055dc4 for unblocking my team.

So why is this caused? Trying to sign already-signed apk?

Just ran into the same issue and I can't seem to figure out why it is happening. I have tried all proposed solutions, but nothing is working for me.


OIDC with Azure blog post

Description
Well, a new blog post.
Hemingway grade 7 ;)
Checklist:

[x] I have reviewed the style guide.
[x] If blogging, I have reviewed the blogging guide.
[x] I have manually confirmed that all new links work.
[ ] I added aliases (i.e., redirects) for all filename changes.
[ ] If making css changes, I rebuilt the bundle.

this is well-written!! you should write more blog posts!! 💜
left a few comments, pls ignore any you disagree with.

Thank you @susanev! I applied the suggestions.


build on configurable architecture

Overview
Support multi-arch builds of charms and images
Details
In light of the new better-builder which plans builds and integration tests, I'd like to propose we allow the workflows to be called from multiple architectures.
I have charms which need to be built for ARM64 and AMD64... and while they could be planned together, the better-builder does not yet support that.  Like-wise, to run the integration tests on the resultant charms, the integration tests require different architectures as well.  This proposal introduces a builder-runner-label which defaults to ubuntu-latest but can also be set to ARM64 to engage the self-hosted runners in the organization to build the arm64 version of the charms.  Then using the self-hosted-runner-label, I can have integration tests ALSO run on each architecture.
Lastly, using the new identifier field, i can identify the plans with either an amd64 or arm64 architecture.
Replaces work done for: https://github.com/canonical/operator-workflows/pull/293

@weiiwang01 @arturo-seijas @cbartz
I hope this works is clear for enabling arm64 builds of charms.  I do like the build plan feature and i've tried to incorporate it here:
https://github.com/canonical/k8s-operator/pull/94

/canonical/self-hosted-runners/run-workflows 23599d022a3489bad04054b75156e227913af54c

@arturo-seijas why did this get closed?   Disregard 👍🏻


Test file

test

test

report

test from jenkins

test

report

report

report

report

report

run test

run test

run test

run test

run test

run test

run test

run test

run test

run test

test

test

test

ok to test

test

test

ok to test

ok to test

ok to test

ok to test

ok to test.

ok to test.

test 123

ok to test.

ok to test

ok to test.

ok to test

ok to test

ok to test

ok to test

ok to test test this please

ok to test

add to whitelist.

add to whitelist.

add to whitelist

ok to test.

add to whitelist

ok to test.

from jenkins

add to whitelist

ok to test

run tests.

run tests.

run tests.


Runtime option does not seem to do anything

Hi,
what does the runtime option actually do? I tried it with runtime set to true and to false but it doesn't seem to change anything. The transpiled file has the schema definition embedded as a string both times. I would have expected a different result when it is true.
This is my schema:
type Query {
    test: String
}

This is the transpiled file, both when runtime is true and when it's false:
"use strict";

var test = "\r\n\r\ntype Query {\r\n    test: String\r\n}";

Importing at runtime could be great for hot reloading in development environments.
Can you explain why it is the same both times?
Thanks for your help.
-Moritz

same here. and it is inlined as text instead of ast :(


[release-2.6] Trigger rebuild to pick up base OS CVE fixes

Signed-off-by: Subbarao Meduri<EMAIL_ADDRESS>

/approve
/lgtm

Closing this PR. As discussed with sec-engineering, the image scans will only run against the latest release branch; therefore, we don't need to rebuild the previous release streams.


Undefined WP_ENVIRONMENT_TYPE

Checking the logs to find code that could be causing slow performance i found this message related to an undefined constant used in production-config, it is a warning now but that will fire an error in future PHP version.
[14-Apr-2023 09:56:10 UTC] PHP Warning:  Use of undefined constant WP_ENVIRONMENT_TYPE - assumed 'WP_ENVIRONMENT_TYPE' (this will throw an Error in a future version of PHP) in /code/wp-content/mu-plugins/the-world-site-config/configs/production/production-config.php on line 19

@gtenaschuk @rpeterman-gp Do we need separate configs for 'staging'? We have global and production, so I'll remove the staging file in PR.


User data directory

It is difficult to manage user data like profiles when they have a custom file name at the root level of the app directory. It would be helpful to put user data in a dedicated sub-directory named like Profiles or something.
I am thinking in terms of package management, e.g. I want to make a scoop manifest with persistent data.

thats a very good point. I have changed it so in the next update, all profile yaml files are saved in a Profiles subfolder.
All existing settings are moved there on the first run.
Will keep this open until the update.

This is now in the new version. Existing profiles are automatically moved on first run.


Remove unused proc initializer params

Remove juttle and pname parameters from proc initializers.
Fixes #132.

@mstemm
@demmer Is Program#get_stats removal OK with you?

The changes look good to me. I'll let @demmer also chime in.

The test failure is unrelated to the change and caused by #152.

I'm good with removing Program#get_stats and the rest of the code looks good to me as well.

Rebased to resolve a conflict, will merge on green.


Add Event streamer struct

Signed-off-by: Ashish Tiwari<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

👀
Error: kuma/kuma.go:122:17: unnecessary use of fmt.Sprintf (S1039)


Install docker from binaries

We previously installed docker from the Amazon Linux 2023 repos. However, that version is was 20.23.0. This installs 24.0.4 using binaries from the docker releases.

We might keep this up ourselves, but relying on the docker rpm in the official repos seems like a better bet for long term stability.


GPC-NONE: Add 0 reserved concurrent executions

What's this for?

This can be set globally and overridden if needed https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-specification-template-anatomy-globals.html

Doesn't reserved concurrency of zero mean the function can never run? Or does 0 have a special meaning?

Ahh yes, I was treating reserved concurrency as the prewarmed amount which is wrong, I need to think of a better value for this


[CTD-529] quote variable to preserve linefeed so UID and password are…

… not corrupt

I tested this by dropping modified connectd_control on top of 2.4.26.  It worked.  Approving PR.

OK post build CI passed.


Login - Two messages displayed after tap on back button

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Put you new email address in Sign in page
Tap Continue
Tap twice on Resent Link button
Go back to you email and find email from Expensify Concierge
Should arrived a several emails due to hitting Resent link twice
Tap on first one(oldest one), which is invalid already
Type password
Hit Set Password several times
Tap on back button

Expected Result:
Should be no error messages at all
Actual Result:
Two messages (Link has been re-sent and Password link invalid error message) displayed after tap on back button
Workaround:
Unknown
Platform:

Where is this issue occurring?

Android

Version Number: 1.2.4-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/191617891-d0894441-6a38-4351-9dcd-87bdf9bcee24.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

I have a fix for this here

Working on a PR to fix this today!

I see that we had the same issue reported here and it was already fixed here, but it can use some cleanup.


submission unlinked from project

Describe the bug
discovered by @ipediez
To Reproduce
Steps to reproduce the behaviour:

start with an existing project - autoimported
update project info
created a submission by uploading spreadsheet
notice submission is not linked to project

Expected behaviour
Submission should be linked to project
Screenshots / Logs

If applicable, add screenshots or log files to help explain your problem.

Links

If applicable, link to relevant docs or Slack conversations.

Environment

[x] prod
[ ] staging
[ ] dev

Browser

[ ] Chrome
[x] Safari
[ ] IE
[ ] Other (please specify)

Project 1
https://contribute.data.humancellatlas.org/projects/detail?uuid=cd61771b-661a-4e19-b269-6e5d95350de6
Submissions:

https://contribute.data.humancellatlas.org/submissions/detail?uuid=7b1f1a8d-4aa6-4d2d-a675-5b0589ed2d65
This one, by 11:47 13.01.22 is still linked. Only the spreadsheet has been uploaded.

https://contribute.data.humancellatlas.org/submissions/detail?uuid=4bc044b2-aa53-4c8f-8d5e-a40e5b6c4cf1
In this one, the spreadsheet was uploaded and the files were also uploaded to the s3 bucket. All the metadata was valid, and after hitting the "Validate Submission" button for graph validation it showed the following error message and was unlinked,

Project 2
Submissions (older to newer):
https://contribute.data.humancellatlas.org/submissions/detail?uuid=1c82779c-6feb-4824-86c4-6648f8b63167
https://contribute.data.humancellatlas.org/submissions/detail?uuid=0b443736-0ac1-4e3c-aeef-ba9c0c7e1302
https://contribute.data.humancellatlas.org/submissions/detail?uuid=163719fe-ebbf-4b0f-a1f8-80198da44166
https://contribute.data.humancellatlas.org/submissions/detail?uuid=83644ebc-099e-4e96-90af-2201465235e4
https://contribute.data.humancellatlas.org/submissions/detail?uuid=1cb5a259-7f06-46b1-a33d-2b23467c0a79
In all the cases, the only step performed was to upload the spreadsheet to create a submission.

I think I might be facing the same problem, at least with one project
Project 3
https://contribute.data.humancellatlas.org/projects/detail?uuid=d71c76d3-3670-4774-a9cf-034249d37c60&tab=upload
Submissions
Oldest to newest, in both cases I only uploaded the spreadsheet

https://contribute.data.humancellatlas.org/submissions/detail?uuid=981498d4-ff17-495d-9bb9-f9076d25fbf9
https://contribute.data.humancellatlas.org/submissions/detail?uuid=7e44319e-f382-4116-8b5d-9c9395643c8a

@aaclan-ebi has a suspicion on what the error is, she will investigate (After #616)

It seems that I've unintentionally changed the behaviour on when the submission will be linked to the project as part of my changes in ebi-ait/dcp-ingest-central#549
https://github.com/ebi-ait/ingest-client/compare/d5654ab..04e6d5e?diff=split#diff-2617875dbb190b4041551953a829be7e70dc9172d66c8b63df7fb46d079d6c71L77-L79
Before:  The linking of submission to project will happen AFTER creating the new entities in the submission and BEFORE the linking of entities
Now: The linking of submission to project will happen AFTER creating the new entities and linking of entities
However, this shouldn't cause the 401 errors that happened on the @ipediez's and @idazucchi 's submissions.
It seems that this is an issue when the token expires during importing. There's an issue filed in 2020 related to this ebi-ait/dcp-ingest-central#549.  This can happen when

spreadsheets are large
user uploads spreadsheet after being logged in for some time and token is about to expire

For project 1, submission 2 (with uuid 4bc044b2-aa53-4c8f-8d5e-a40e5b6c4cf1) the submission is not that large, I suspect the spreadsheet was uploaded after some time of being logged in.
@ipediez Do you want to delete project 1's submission 1 (with uuid 7b1f1a8d-4aa6-4d2d-a675-5b0589ed2d65) and link submission 2 to that project ? I could do that so that you'll be able to submit that valid submission.
It seems that all other submissions that Irene and Ida noted are bigger and have more linkings. We need to fix the issue ebi-ait/dcp-ingest-central#549 to unblock the other submissions.

@aaclan-ebi yes, it would be perfect if you could link that submission, which is already graph valid. Thanks!

New ticket has been created but it seems the Project overwrite has changed the behaviour of the submission linking.
@amnonkhen and @aaclan-ebi will discuss after standup how to unblock projects exporting.

1 - 7b1f1a8d-4aa6-4d2d-a675-5b0589ed2d65 total count of entities 722
error: no error, this submission is linked to project HumanColonRewiringUlcerativeColitis and needs to be deleted
2 - 4bc044b2-aa53-4c8f-8d5e-a40e5b6c4cf1 , total count: 722
error: failed in linking submission to project because of expired token
Received an HTTP 401 from http://<IP_ADDRESS>/submissionEnvelopes/61dff94e7701fb51a5c2b974:<PHONE_NUMBER>473401UnauthorizedUnauthorized/submissionEnvelopes/61dff94e7701fb51a5c2b974

action:
I’ll manually link the submission to project HumanColonRewiringUlcerativeColitis
3 - 1c82779c-6feb-4824-86c4-6648f8b63167 , total count of entities : 98868
error:
Received an HTTP 401 from http://<IP_ADDRESS>/submissionEnvelopes/61c2fc5df358643c2eb2faf8:<PHONE_NUMBER>113401UnauthorizedUnauthorized/submissionEnvelopes/61c2fc5df358643c2eb2faf8

4 - 0b443736-0ac1-4e3c-aeef-ba9c0c7e1302 , total count: 98868
No error but it didn't finish creating all entities nor linking them - submitted last dec 22 - so this might be the one breaking the broker pod
5 - 163719fe-ebbf-4b0f-a1f8-80198da44166 , total count: 98868
Received an HTTP 401 from http://<IP_ADDRESS>/submissionEnvelopes/61c5f00634592953c85e00db:<PHONE_NUMBER>644401UnauthorizedUnauthorized/submissionEnvelopes/61c5f00634592953c85e00db

6 - 83644ebc-099e-4e96-90af-2201465235e4 , total count: 1566
This error is related to issue in Rachel’s dataset , the fix was promoted jan 12, the submission was created jan 10 - this can be retried
Received an HTTP 500 from http://<IP_ADDRESS>/processes/61dc749bc2be115bdc97ba8a/protocols: http://<IP_ADDRESS>/processes/61dc749bc2be115bdc97ba8a/protocolsUnexpected server error

action: I believe we can retry uploading the spreadsheet
7 - 1cb5a259-7f06-46b1-a33d-2b23467c0a79 , total count: 98868
error: It created all entities but nothing was linked because of 401 error in finding the project uuid
Received an HTTP 401 from http://<IP_ADDRESS>:80/projects/search/findByUuid?uuid=165dea71-a95a-44e1-88cd-b2d9ad68bb1e:<PHONE_NUMBER>925401UnauthorizedUnauthorized/projects/search/findByUuid

To summarise, there are 4 unique submissions noted above that are blocked:

submission 2
submission 9
submission 6 - owned by UCSC
submission with 98868 entities

Unblocked @ipediez and @idazucchi on their submissions
submission 2 - https://contribute.data.humancellatlas.org/projects/detail?uuid=cd61771b-661a-4e19-b269-6e5d95350de6&tab=upload
submission 9 - https://contribute.data.humancellatlas.org/projects/detail?uuid=d71c76d3-3670-4774-a9cf-034249d37c60&tab=upload

Dev notes:
commands ran manually to link submission to project and delete submission errors:
$ TOKEN='insert-jwt-token-from-ui'
# link submission to project
$ curl -X POST -H "Authorization: Bearer $TOKEN" -H "Content-Type: text/uri-list" -d https://api.ingest.archive.data.humancellatlas.org/submissionEnvelopes/<insert-submission-id> https://api.ingest.archive.data.humancellatlas.org/projects/<insert-project-id>/submissionEnvelopes
# delete submission errors
$ curl -X DELETE -H "Authorization: Bearer $TOKEN" https://api.ingest.archive.data.humancellatlas.org/submissionEnvelopes/<insert-submission-id>/submissionErrors

I'll work on the fix on the importer code next to make sure linking of submission to project happens first when importing.

PR ready, review needed


error

i am getting issue like this

Follow This
Implementation of Gantt chart.
Github link : https://github.com/dalestone/angular2-gantt
Getting Started
Step 1 :Clone the Project into your workspace
https://github.com/dalestone/angular2-gantt
Step 2: First make a component named ganttchart
ng g component ganttchart
Step 3: Install Angular 2 Gantt (Webpack only)
npm install ng2-gantt --save
Step 4: Goto github link
https://github.com/dalestone/angular2-gantt/tree/master/src
Step 5: Copy lib folder and paste it inside app folder.
Step 6: Import the ng2-gantt NgModule into your app module
import { GanttModule } from './lib';
// other imports
@NgModule({
imports: [ GanttModule ]
})
export class AppModule { }
Step 7: Go to src folder of the cloned project and copy the contents of demo-app.component.html and paste it inside ganttchart.component.html
Step 8:Go to src folder of the cloned project and copy the contents of demo-app.component.ts and paste it inside ganttchart.component.ts
Step 9: Start the local server by writing npm start in your console
A Gantt chart, commonly used in project management, is one of the most popular and useful ways of showing activities (tasks or events) displayed against time. On the left of the chart is a list of the activities and along the top is a suitable time scale. Each activity is represented by a bar; the position and length of the bar reflects the start date, duration and end date of the activity. This allows you to see at a glance:
Angular2 Gantt PROJECT contains a tabular form which contains Id, Name,TreePath,Percent complete,Start Date and End Date. Input Texts  are Two Way Binded where you can change the text and it will be reflected in Gantt Chart Table
Angular 2 Gantt Playground contains Task status containing error,warning, information and completed in dropdown option. It contains 3 buttons

Create Task
When you click on create task button a new task will be created with a id generated,name generated,tree path generated and percentage complete generated as 0% by default also start date and end date is also generated . We can change the fields as it is two way binded.
createTask(element: any) {
const selectedStatus = element.options[element.selectedIndex].value;
const parentTask = {
'id': 'parent_task_' + Math.random(),
'parentId': 'parent_task',
'treePath': 'parent_task',
'name': 'parent_task',
'percentComplete': 0,
'start': new Date('2017-01-01T03:30:00.0Z'),
'end': new Date('2017-01-01T12:45:00.0Z'),
'status': selectedStatus
}
this.project.tasks.push(parentTask);
const childTask = {
'id': 'child_task_' + Math.random(),
'parentId': 'ea2a8d86-1d4b-4807-844d-d5417fcf618d',
'treePath': 'parent 1/child3',
'name': 'child3',
'percentComplete': 0,
'start': new Date('2017-01-01T03:30:00.0Z'),
'end': new Date('2017-01-01T12:45:00.0Z'),
'status': selectedStatus
}
this.project.tasks.push(childTask);
}
2.Update Tasks Percent Complete
When you click this button the task will be updated till 100%.
updateTasks() {
for (let i = 0; i < this.project.tasks.length; i++) {
let task = this.project.tasks[i];
let progress = setInterval(function () {
if (task.percentComplete === 100) {
task.status = 'Completed';
clearInterval(progress);
} else {
if (task.percentComplete === 25) {
task.status = 'Warning';
} else if (task.percentComplete === 50) {
task.status = 'Error';
} else if (task.percentComplete === 75) {
task.status = 'Information';
}
task.percentComplete += 1;
}
}, 200);
}
}
3.Load big dataset
When you click this button large number of big dataset will be loaded based on the limits set on it.Here it is set upto 1000
loadBigDataSet() {
var tasks = [];
for (var i = 11; i < 1000; i++) {
var task = {
id: parent${i},
name: 'task testing',
percentComplete: 0,
start: new Date(),
end: new Date(),
status: ''
}
tasks.push(task);
}

If you have installed the package with npm (npm install ng2-gantt --save) you don't have to download the library separately. But then you do have to change the imports in the demo demo-app.component.ts : change "import ... from './lib';" to "import ... from 'ng2-gantt';" .
(BTW this is the first project that i installed and got working within 15 minutes, chapeau!)


Update index.html

CREATED THE FORM AS SPECIFIED IN THE ISSUE #276,I HOPE THIS CODE WILL HELP <>

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Version 1.90.0 weird characters

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.0
OS Version: MacOS 14.4.1

Steps to Reproduce:

Open VScode.
Not happening on 1.89.1

Can you see if it still reproduces when disabling the GPU support in VSCode? You can do that by running VSCode from the command line like this: code --disable-gpu
If that helps, you can permanently configure this option via:

Command Palette search for "Configure Runtime Arguments"
Set disable-hardware-acceleration: true
Restart

Can you also test with --disable-blink-features=FontMatchingCTMigration and confirm if the issue persists.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


MIP45 post-audit updates

Still a WIP; feedback/contributions welcome.

Also needs:
[ ]  Add links to the IPFS documentation
[ ] getId() was removed update the documentation
[ ] updust must be added to the documentation
[ ] Some previously mentioned inconsistencies from PwC haven't been fixed yet
[ ] A mention of ExponentialDecrease contract
[ ] Possibly point to reference implementation of clipperCallee and the keeper from INT.

Copying the list @godsflaw posted above so that I have one I can edit and add to:
[ ] Add links to the IPFS documentation
[x] getId() was removed update the documentation
[x] updust must be added to the documentation
[ ] Some previously mentioned inconsistencies from PwC haven't been fixed yet
[ ] A mention of ExponentialDecrease contract
[ ] Possibly point to reference implementation of clipperCallee and the keeper from INT.
[ ] Mention PwC informational finding 8.2 ("Creation of Many Small Auctions") in section on incentive farming

@gbalabasquer is suggesting we make the English description of cut more clear.
if cut is 1%, it means we take a 1% drop every step seconds.  Even though we specify the parameter as 0.99 WAD, we should make it easier to reason about for risk and governance.

This is at a point where it can be reviewed--the only remaining changes are trivial and blocked on actions outside my control (adding links to final audit reports and the example DEX bidding integration).

Looks good to me, format-wise.
@CPSTL would be good for you to look it over as well before we merge.

This is at a point where it can be reviewed--the only remaining changes are trivial and blocked on actions outside my control (adding links to final audit reports and the example DEX bidding integration).

SGTM - I'm holding off on merging this PR until we get those final additions in plus a final sign-off from a member of the Smart Contract domain team.

Linked to all finalized audit reports we have received to date. If there's a strong desire to merge this, we can go ahead, and will add the link to the last audit report in a separate PR.

Linked to all finalized audit reports we have received to date. If there's a strong desire to merge this, we can go ahead, and will add the link to the last audit report in a separate PR.

SGTM. Merging in updates 👍


Notional Validaton Gentx

Notional Validation Gentx

Please make sure your node is up and running now. Join #validators on Discord for help: https://discord.gg/QeJWCrE.


error-reporting: Publish nodereport on SIGTERM

nodereport is a great package for getting crucial diagnostic info from a node process. We should publish that information to ER on SIGTERM so users get better visibility into the state of the process when the instance crashes (other than when the app itself is crashing).
This issue has been migrated from the cloud-errors-nodejs issue #83.

This issue was moved to https://github.com/googleapis/nodejs-error-reporting/issues/10.


special characters response issue.

var str= "✈ From Osaka to Okinawa 🎌";
return new TextResponse(str,"text/html");
result
?? From Osaka to Okinawa ??

I just tested the following:

New console application
Install Microsoft.Owin.SelfHost
Install Nancy.Owin
Run the following code:

public static class Program
{
    public static void Main(string[] args)
    {
        using (WebApp.Start("http://localhost:8080", app => app.UseNancy()))
        {
            Console.ReadLine();
        }
    }
}

public class Module : NancyModule
{
    public Module()
    {
        Get["/"] = _ => new TextResponse("✈ From Osaka to Okinawa 🎌", "text/html");
    }
}

Sending a request to http://localhost:8080/ results in the following response:

HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/html
Server: Microsoft-HTTPAPI/2.0
Date: Wed, 19 Aug 2015 23:48:03 GMT
✈ From Osaka to Okinawa 🎌

This is not a Nancy error or bug, it's probably the way your browser handles encoding or something.

im running on Microsoft.Owin.Host.SystemWeb

I'm seeing the same results with the systemweb host. If I change the response to include Encoding.Unicode then it works in IE but not in FF or Chrome. If I put the text in a razor view it shows fine in all browsers.
Trying this as middleware produces the same results. After playing with it some I was finally able to get it to work in all browsers with this.
app.Use((ctx, next) =>
{
    ctx.Response.ContentType = "text/html; charset=utf-16";
    ctx.Response.Write(Encoding.Unicode.GetBytes("✈ From Osaka to Okinawa 🎌"));

    return Task.FromResult(0);
});

This lead to trying it in Nancy again like so, which does work in all browsers.
Get["/test"] = _ => new TextResponse(
    "✈ From Osaka to Okinawa 🎌",
    "text/html; charset=utf-16",
    Encoding.Unicode);

The key to getting it to work was manually including ; charset=utf-16. If you use an encoding other than UTF8 the TextResponse isn't appending that to the content type like it should be.

According to the W3C

It is very important to always label Web documents explicitly. HTTP 1.1 says that the default charset is ISO-8859-1. But there are too many unlabeled documents in other encodings, so browsers use the reader's preferred encoding when there is no explicit charset parameter.

It looks like IE will try to auto select a character set when one isn't set, while the other browsers don't and stick to the default.

So there might actually be something we can do about this, then?

@khellang when using TextResponse we can append the charset if it's not UTF8. The supplied encoding is how we get the string's bytes but if you're not using UTF8 the browser won't know. This change would be similar to the JsonResponse and XmlResponse.

:cool: Submitted #2020 :grin:

nice work chaps

i tried manually including charset=utf-16 / utf-8 , Encoding.Unicode /etc...
still not working for me....
in webapi there are no issues with this...it just works.
i'll dig in later today, i suspect the problem is buried somewhere deep.

ok so i got xt0rteds code working after saving the document in utf-8 encoding (vs2013).
still didnt find a solution for json response;
im getting facebook posts from the graph api, those posts contain special chars, im trying to pass the json to the client;
 var postsJson = await GetPosts(token); // json from facebook
 var jObject = new JObject { { "posts", postsJson } }; // newtonsoft json JObject
 // in the debugger i see that all is good up until this point

 var responseContent = Encoding.Unicode.GetBytes(jObject.ToString());

  return new Response()
                  {
                      ContentType = "application/json; charset=utf-16",
                      StatusCode = HttpStatusCode.OK,
                      Contents = stream => stream.Write(responseContent, 0, responseContent.Length)
                  };

  //result
   message: "✈㼏 From Osaka to Okinawa 㼼㼿"
   ........................................................................................
   suppose to be "✈ From Osaka to Okinawa 🎌"

i tried appending charset=utf-8 and Encoding.UTF8 , doesn't work.


add reply method options

nock allows .reply to use a function as first argument in reply.  Added the line to support that for these examples in nock README

You can also return the status code and body using just one function:
var scope = nock('http://www.google.com')
   .filteringRequestBody(/.*/, '*')
   .post('/echo', '*')
   .reply(function(uri, requestBody) {
     return [
       201,
       'THIS IS THE REPLY BODY',
       {'header': 'value'} // optional headers
     ];
   });

or, use an error-first callback that also gets the status code:
var scope = nock('http://www.google.com')
   .filteringRequestBody(/.*/, '*')
   .post('/echo', '*')
   .reply(function(uri, requestBody, cb) {
     setTimeout(function() {
       cb(null, [201, 'THIS IS THE REPLY BODY'])
     }, 1e3);
   });

If you're using the reply callback style, you can access the original client request using this.req  like this:
var scope = nock('http://www.google.com')
   .get('/cat-poems')
   .reply(function(uri, requestBody) {
     console.log('path:', this.req.path);
     console.log('headers:', this.req.headers);
     // ...
   });

Looks great. Seems like cb isn't always required though? What do you think about splitting those definitions apart so it's either return the triple or use the callback? Do you think we could document that triple a little better too? [number, any] | [number, any, Object] perhaps?


feat: support more loadbalance algorithm

支持更多的负载均衡算法

random
roundRobin
consistentHash

另外也支持自定义负载均衡

Codecov Report

Merging #7 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   98.83%   98.91%   +0.07%
==========================================
  Files          25       30       +5
  Lines        1204     1290      +86
==========================================
+ Hits         1190     1276      +86
  Misses         14       14

Impacted Files
Coverage Δ

lib/client/consumer.js
100% <ø> (ø)
:arrow_up:

lib/client/loadbalancer/base.js
100% <100%> (ø)

lib/client/loadbalancer/index.js
100% <100%> (ø)

lib/client/loadbalancer/random.js
100% <100%> (ø)

lib/client/metric/health_counter.js
100% <100%> (ø)
:arrow_up:

lib/client/scheduler.js
100% <100%> (ø)
:arrow_up:

lib/client/metric/rolling_counter.js
100% <100%> (ø)
:arrow_up:

lib/client/loadbalancer/weight_rr.js
100% <100%> (ø)

lib/client/loadbalancer/consistent_hash.js
100% <100%> (ø)

lib/client/utils.js
100% <100%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa47a9...67acef4. Read the comment docs.

+<EMAIL_ADDRESS>


Adds model doctests and related refactorings/fixes

Aims to address #1392 and #396

Great work, thanks @Copper-Head!

@Copper-Head – I'll deploy this to the website soon. How complete would you say these doctests are now?

I'd say they cover all of the API intended for "public" use. The unit test coverage is less thorough, in case that's relevant.

@Copper-Head could you do some unit stress test? E.g. no. of tokens vs the NgramCounter size? I think a normal user might start breaking their own machines if NgramCounter is maxing out their RAM when they feed a sizable corpus to it.

Sure thing!
I've never done something like this before though, so I have a couple of questions regarding how to go about this.

Is the stress test explicitly part of the suite (i.e. will it be present in test_model.py)?
What is the intended output of this test? Do we want an approximate mapping from no. of tokens to NgramCounter size? For instance, I cound run this on all the largest NLTK corpora and put the results in a table for folks to extrapolate from, no?
Just to make sure I understand, size is in binary storage units (MB, GB, etc), right?

Location of Stress Test

I am not sure where a stress test should be placed, but i would expect nltk/nltk/test/unit/ to be a good place. And if it's necessary creating a directory within that like how the nltk/nltk/test/unit/translate/ is located might be appropriate.

Intended Output of Stress Test

In web dev, i think they do load testing to make sure that their site can handle heavy flow (e.g. http://locust.io/). I think for MT and LM, it might be appropriate to warn/predict/estimate how much resources might be used to be the model, especially when we're talking about phrase table of tens to hundreds of GB and for LM it can go up to TBs of space required.
I think lmplz, does some estimations after speed-optimized counting and then if user's machine cannot save the size of the LM, it will throw and system exit. I'm not sure how we should do it in NLTK though but using the several NLTK corpora on ngram order of 1 to 5 would be good. At least, we can also take some time estimation as well as record how big the models get.
Then possibly, users should read this table of speed/memory tests in the docs before using the NgramCounter, just in case someone tries an NgramCounter with sizeable corpus and a large ngram order and start crashing their machines =)

Size in binary storage units? Yep, i think it can get up to TB if you do something like http://data.statmt.org/ngrams/

Ok, I'll take a shot at this in my next window of opportunity. Honestly, I didn't really have any real world applications in mind when writing this code, since anyone who's training big models these days is gonna probably work with neural networks to begin with. Or write custom code in a truly "optimized" language like C++.
The primary intended audience as I understood were students and people who didn't need to work with "big data". But maybe times have changed and these audiences don't exist anymore...

I think training 5-grams model on Europarl can lead to some big numbers in terms of RAM usage if it's fully loaded, so you have to be careful when testing too.
I would expect the first thing NLTK users would do is to learn 5,6,7-grams on Europarl =)

Haha, ok. Any pointers for largest nltk corpora in terms of sheer numbers of tokens? Parses/metadata/transcriptions/translations shouldn't matter in this case.

Maybe these would be a good start, https://github.com/nltk/nltk/blob/develop/nltk/corpus/europarl_raw.py. I would expect the different languages giving different sizes too but they should be similar or at least linearly correlated in terms of no. of token and size of model across languages. Testing on 1 to 5-grams for several languages would be good.
Another good "baseline" to test on would be to also try on nltk.corpus.brown.
Maybe someone else have other suggestions to test on too.
@Copper-Head Thanks for all the work on Ngram model!! Maybe we'll try to piece it up with the other translate code once we get stabilize the other translation related features in NLTK =)


Create a FSM ( Finite State Machine ) handling bike transition states

Keep track of various transitions. From a start state to a  pause for example.
For now we will transition between READY, START, PAUSE, STOP, and  ERROR states.
STATE DIAGRAM: Coming soon

We require some actions to change our machine state. The easiest way is to send and handle these actions as broadcasts using a BroadcastReceiver.
Here are the intents to listen to. We will add more as the need arises.
  <intent-filter>
    <!--  start the machine and put the tracker in a correct state -->
    <action android:name="tracker.action.initialize" />
    <!--  start recording trip -->
    <action android:name="tracker.action.start" />
    <!--  pause recording trip -->
    <action android:name="tracker.action.paused" />
    <!--  resume recording trip -->
    <action android:name="tracker.action.resume" />
    <!--  stop recording trip -->
    <action android:name="tracker.action.stop" />
    <!--  disable tracking: should this be in a config file?-->
    <action android:name="tracker.action.disable" />
    <!--  enable tracking -->
    <action android:name="tracker.action.enable" />
  </intent-filter>

We require some actions to change our machine state. The easiest way is to send and handle these actions as broadcasts using a BroadcastReceiver.
Here are the intents to listen to. We will add more as the need arises.
  <intent-filter>
    <!--  start the machine and put the tracker in a correct state -->
    <action android:name="tracker.action.initialize" />
    <!--  start recording trip -->
    <action android:name="tracker.action.start" />
    <!--  pause recording trip -->
    <action android:name="tracker.action.paused" />
    <!--  resume recording trip -->
    <action android:name="tracker.action.resume" />
    <!--  stop recording trip -->
    <action android:name="tracker.action.stop" />
    <!--  disable tracking: should this be in a config file?-->
    <action android:name="tracker.action.disable" />
    <!--  enable tracking -->
    <action android:name="tracker.action.enable" />
  </intent-filter>


optionally add +/- buttons to the sliders

or maybe arrows?

ideally with would need an equivalent matplotlib widget option


bytewax: 0.15.1 -> 0.16.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 229466 run on x86_64-linux 1

2 packages built:

python310Packages.bytewax
python310Packages.bytewax.dist

@ofborg build python310Packages.bytewax

I'll leave the work on darwin to ZHF.


AAD consent permissions don't match the screenshot

It looks like the SharePointPnP.ProvisioningApp.Site has reduced the number of AAD permissions it is asking for and no longer matches the screenshot.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1c36be4-dad8-cd58-8f1c-b4fa9150b79f
Version Independent ID: 509c4fe6-99fe-906c-bf6a-a3544c807fc9
Content: Provision the Custom Learning site
Content Source: CustomLearning/custom_provision.md
GitHub Login: @pkrebs
Microsoft Alias: pkrebs

Ah, I see what happened. The screenshot shows the consent request when adding the CLO365 template to a tenant. The current documentation shows one consent request for first use and seems to be missing the second consent request.


Add conditional stages example to readme

Since there has been some confusion about how to do this, I thought it could be nice to add it to the readme

Thank you for your contribution.
We merged your exemple into master.


Add $Arguments feature for extracting function call signature

Now, it is impossible to extract the function call signature. There are some libraries, like flow/Arguments which provide types for extracting arguments but they don't support functions where min_aritiy != arity.
Problem example:
declare function arguments<A>(() => any): []
declare function arguments<A>((A) => any): [A]
declare function arguments<A, B>((A, B) => any): [A, B]
declare function arguments<A, B, C>((A, B, C) => any): [A, B, C]

type Arguments<F> = $Call<typeof arguments, F>

declare function extractReturn<R, F: (...any[]) => R>(F): R;

type Return<F> = $Call<typeof extractReturn, F>;

function decorate<F: Function>(f: F): (...Arguments<F>) => Return<F> {
	return (...args) => f(...args);
}

const foo = (arg1: string, arg2?: number) => {};

foo('s');
foo('s', 0);

const bar = decorate(foo);

bar('s');
bar('s', 0); // error is thrown here

Try Flow

We now have Parameters


[fluentd chart] Add nodeSelector to the DaemonSet template

Currently the DaemonSet doesn't have the possibility to use the nodeSelector feature.
The is necessary to avoid pods running on nodes that it is not required for my use case.
I know there is the possibility to use tolerations but even with that I have a scenario where nodes with no taint settings will have pods running.
I am willing to make a PR if this is a contribution that maintainers agree with it.

Hey @bartier thank you for the feedback.


@JsonView ignored for subclasses

I am having a parent class with subclasses. I am using different @JsonView annotations where the classes are used for request bodies and response bodies.
When generating a schema from the parent class for a given @JsonView, the schema generated for the child class contains an incorrect selection of the classes' fields.
public class Demo {

	public interface Input {}

	public interface Output {}

	@JsonTypeInfo(use = NAME)
	@JsonSubTypes({
		@JsonSubTypes.Type(value = A1.class),
	})
	public static abstract class A {
		@JsonView(Input.class)
		public String a_in;
		@JsonView(Output.class)
		public String a_out;
	}

	public static class A1 extends A {
		@JsonView(Input.class)
		public String a1_in;
		@JsonView(Output.class)
		public String a1_out;
	}

	private static final JsonView VIEW_OUTPUT = new JsonView() {
		public Class<? extends Annotation> annotationType() {
			return JsonView.class;
		}
		public Class<?>[] value() {
			return new Class[] {Output.class};
		}
	};

	public static void main(String[] args) {
		ResolvedSchema resolvedSchema = ModelConverters.getInstance()
			.resolveAsResolvedSchema(
				new AnnotatedType(A.class).resolveAsRef(true)
					.jsonViewAnnotation(VIEW_OUTPUT));
		resolvedSchema.referencedSchemas.forEach((name, schema) -> dumpSchema(schema, ""));
	}

	private static void dumpSchema(Schema<?> schema, String indent) {
		if (schema.get$ref() != null) {
			System.out.println(indent + "$ref: " + schema.get$ref());
		}
		if (schema.getName() != null) {
			System.out.println(indent + "Schema: " + schema.getName());
		}
		if (schema.getType() != null) {
			System.out.println(indent + "Type: " + schema.getType());
		}
		if (schema.getAllOf() != null) {
			System.out.println(indent + "All of:");
			schema.getAllOf().forEach((allOfSchema) -> dumpSchema(allOfSchema, indent + "  "));
		}
		if (schema.getProperties() != null) {
			System.out.println(indent + "Properties:");
			schema.getProperties().forEach((propName, propSchema) -> {
				System.out.println(indent + propName);
				dumpSchema(propSchema, indent + "  ");
			});
		}
	}
}

This is the actual output:
Schema: A1
Type: object
All of:
  $ref: #/components/schemas/A_Output
  Type: object
  Properties:
  a_in
    Schema: a_in
    Type: string
  a1_in
    Schema: a1_in
    Type: string
  a1_out
    Schema: a1_out
    Type: string
Schema: A_Output
Type: object
Properties:
a_out
  Schema: a_out
  Type: string

What I would expect instead:
- Schema: A1
+ Schema: A1_Output
Type: object
All of:
  $ref: #/components/schemas/A_Output
  Type: object
  Properties:
-  a_in
-    Schema: a_in
-    Type: string
-  a1_in
-    Schema: a1_in
-    Type: string
  a1_out
    Schema: a1_out
    Type: string
Schema: A_Output
Type: object
Properties:
a_out
  Schema: a_out
  Type: string

I have pushed a minimal reproducible example to GitHub.
swagger-core version: ~2.2.2~ 2.2.4
jackson-core version: 2.13.3
Java, OpenJDK <IP_ADDRESS>

Dear maintainers, I have opened a pull request with a proposed fix. Is there anything I could do in order to expedite it getting reviewed and possibly merged? Thank you!

@frantuma is there anything I could do to help you with reviewing and incorporating this fix? Please let me know if anything needs to be improved.

We are facing the same problem. When will the pull request be merged?


doesn't work with hover states

This doesn't seem to work with hover states.
Do I need to add something to the config or is it not supported in the plugin?

The purpose of this plugin is that we can change border gradients in the state to make an appealing component (e.g button)
Here an example from one of my projects:
border-gradient-br-syself-600-syself-200 hover:border-gradient-tl-syself-600-syself-200 gradient-border-2

of course you need to define that in your tailwind config:
snippet from tailwind.config
  theme: {
    extend: {
      linearBorderGradients: ({ theme }) => ({
        colors: {
          'syself-50': [colors.cerise[50], colors.orange[50]],
          'syself-100': [colors.cerise[100], colors.orange[100]],
          'syself-200': [colors.cerise[200], colors.orange[200]],
          'syself-300': [colors.cerise[300], colors.orange[300]],
          'syself-400': [colors.cerise[400], colors.orange[400]],
          'syself-500': [colors.cerise[500], colors.orange[500]],
          'syself-600': [colors.cerise[600], colors.orange[600]],
          'syself-700': [colors.cerise[700], colors.orange[700]],
          'syself-800': [colors.cerise[800], colors.orange[800]],
          'syself-900': [colors.cerise[900], colors.orange[900]],
        },
        background: theme('colors'),
        borders: {
          1: '1px',
          2: '2px',
          3: '3px',
          4: '4px',
        },
      }),
  plugins: [
    require('tailwindcss-border-gradient-radius')
  ],


Allow getting access token from environment variable

- Do you want to request a feature or report a bug?
Request a feature
- What is the current behavior?
The CLI gets it's access token from ~/.netlify/config.  This can be overridden with the --access-token flag.
- What is the desired behavior?
It would be helpful if the access token could be set with an environment variable.
Why?  Because on the CI server, the config file won't be available so you need other means of passing the access token.  I can use the cli flag, --access-token $NETLIFY_TOKEN but that means my build script will fail when running locally because the environment variable won't be available.
- Please mention your node.js, and operating system version.
Not relevant.

Development on netlify-cli by netlify is basically over - all effort going into netlifyctl these days.  However as a workaround, how about if in CI you did something like this?
if [ ! -z "$ACCESS_TOKEN" ] ; then
  netlify deploy --access-token $NETLIFY_TOKEN
else
  netlify deploy
fi

This has the added benefit that you can just turn off netlify deploy entirely by replacing the else clause for local development.
If that feels too dirty to you, we'll still accept PR's to add features to netlify-cli.


Feature Request

It would be very helpful if NoSquint color selections could be DISABLED on a per-site basis, instead of having all sites default to the Global Settings. Some sites, such as eBay listings, use dark colored backgrounds for some text. There are NO combinations of colors available in NoSquint that work with both the dark backgrounds and the light backgrounds on the same page; that is, either the text is practically invisible in the dark box or too light to see on the background. Attached is the best combination of light and dark colors that I could find after half an hour of trying.

I second this request.
It would also be very useful to have the addon distinguish the dark backgrounds/white fonts and not colour those fonts black.


h() can not render el-carousel

Vue version
3.3.4
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-xvnunz?file=src%2Fcomponents%2FHelloWorld.vue,src%2FApp.vue,src%2Fmain.js&terminal=dev
Steps to reproduce

open the /src/components/HelloWord.vue
Uncomment the annotated code in 'renderCarousel' and annotate '223'
you'll find a bug where the dom is present but not displayed

What is expected?
Can display normally
What is actually happening?
I don't know
System Info
No response
Any additional comments?
No response

Please provide a reproduction without third party libraries. In this case you should open an issue in element-plus if you believe the problem is related to el-carousel.


Texecom Component

This is a component that allows home assistant to communicate with Texecom Premier alarm panels. it receives data via the serial port and decodes it into the respective zones. Only zones are supported as binary sensors.
The user can configure the required number of zones, names and types.
Sorry if there are any mistakes or errors this is my first component. It is working well at home
Example Config
texecom:
    port: /dev/ttyV0
    uuid: 1234
    zones:
      1:
       name: 'Front Room'
       type: 'motion'
       panelzone: '1'
      2:
       name: 'Dining Room'
       type: 'motion'
       panelzone: '5'
      3:
       name: 'Kitchen'
       type: 'motion'
       panelzone: '20'

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Could not find a related documentation PR, therefore, added the docs-missing label.


Cache modelMaterialsCommon results

For #3241
@rahwang
Brought up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/laA723va6gI
This applies to both Models and 3D Tiles. For models that use the khr_materials_common extension the same shader construction logic will occur every time.
Instead, the materials going through here can be stringified and act as keys to the generated gltf sections - techniques, shaders, and programs. I imagine gltf 2.0 will benefit from a similar strategy.
Most of the code changes will actually belong in https://github.com/AnalyticalGraphicsInc/gltf-pipeline since modelMaterialsCommon is built from there: https://github.com/AnalyticalGraphicsInc/gltf-pipeline#building-for-cesium-integration.

Are we sure this is worth it?  I suspect it is not.  The shaders will still be in the shader cache and this will be almost completely irrelevant and an extra thing to deal with when we add PBR for glTF 2.0 and potentially separate materials for sharing across many tiles in a future version of 3D Tiles.

Ok, it may not be worth it in a glTF 2.0 world. Closing.


Sync api from karmada repo based on v0.7.0

This PR synced API from karmada-io/karmada repo.
cc @pigletfly

/assign @kevin-wangzefeng

Suggest making a tagged release after this PR, such as v0.7.0.

should create a v0.6.0 tag before this PR getting merged

/lgtm
/approve


How to identify boss hits?

Hey, I noticed on Twitter that you used reward shaping using boss hits.  How are you able to identify when a boss hit has occurred?
Thanks

I was able to find the HP for all bosses using the integration UI.


Integrate ICU Analysis plugin into upgraded search

While upgrading elasticsearch to 6.x in #4211, we skipped integrating the ICU Analysis plugin integration.
This plugin need to be integrated with the upgraded code.
This need to be fixed before #2328
@ericholscher Should we use ICU plugin as analyzer or you have any other in mind?

@safwanrahman We use ICU for extended unicode support. I don't believe there is another module that we should be using to do that. It will mostly matter for Asian languages, so we can likely put off the ICU work until we start testing those languages.

@ericholscher the default analyzer has lowe case token filter, which already implements case insensitive search functionality.  So if we dont add ICU plugin, we already have case insensitive search in the upgraded code. I suspect it will be complex to implement case insensitive search with Elasticsearch ICU plugin.

@safwanrahman it looks like you can add the lowercase filter to it if we want, as noted in this example: https://www.elastic.co/guide/en/elasticsearch/plugins/current/analysis-icu-folding.html

I think we can leave out the ICU stuff for now, and we can come back to it as an added feature. Once we get english text working well, we can add in ICU & tests for Asian languages, and confirm that the normal english tests don't break around case insensitivity. I think it's added complexity for now that we don't need yet!