On Div hover Highlight Marker and Circle Issue

Hello everyone, i have implemented angular2-google-maps in my application and displaying user's locations on Map and their range by using sebm-google-map-circle , But now i want to highlight specific user's marker and its circle on div hover. Can anyone help me that how can i do that ?

At first you need a marker reference in your component like this:
export class MapComponent {
    ...
    markers:Marker[] = [];
    ...

and two function for mouseOver and mouseOut event handling:
circleOut(marker) {
  marker.fillColor = "#EC407A";
}

circleOver(marker) {
  marker.fillColor = "#ff0057";
}

}
In this case my marker object looks like this:
export class Marker {
    constructor(public latitude:number,
            public longitude:number,
            public fillColor:string,
            public fillOpacity:number,
            public radius:number,
            public zIndex:number,
            public strokeColor:string,
            public strokeOpacity:number,
            public strokeWeight:number
           ) {
    }
}

The template looks like this:
<sebm-google-map-circle
    *ngFor="let marker of markers"
    (mouseOut)="circleOut(marker)"
    (mouseOver)="circleOver(marker)"
    [latitude]="marker.latitude"
    [longitude]="marker.longitude"
    [fillColor]="marker.fillColor"
    [fillOpacity]="marker.fillOpacity"
    [radius]="marker.radius"
    [zIndex]="marker.zIndex"
    [strokeColor]="marker.strokeColor"
    [strokeOpacity]="marker.strokeOpacity"
    [strokeWeight]="marker.strokeWeight"
    [strokePosition]="marker.strokePosition">
</sebm-google-map-circle>

So you can see the magic are in these two lines:
*ngFor="let marker of markers"
    (mouseOut)="circleOut(marker)"
    (mouseOver)="circleOver(marker)"

I catch the mouseOut and mouseOver events and trigger a function with the marker reference as parameter. So you can change the properties of the marker representation and the view will be updated automatically.
Happy Coding!

@parav01d thanks for your time! I'm closing this as this no bug or feature request.

Hi @parav01d
This is possible on new version "agm-map"?


IStaticDataSource with AES 256 Encryption

Steps to reproduce

Define a simple data source that implements the IStaticDataSource interface:

public class CustomStaticDataSource : IStaticDataSource
{
	private Stream _stream;

	// Implement method from IStaticDataSource
	public Stream GetSource()
	{
		return _stream;
	}

	// Call this to provide the memorystream
	public void SetStream(Stream inputStream)
	{
		_stream = inputStream;
		_stream.Position = 0;
	}
}

Use this data source to add a new ZIP entry to a ZipFile whose password is set using this method:

void Add(IStaticDataSource dataSource, ZipEntry entry);
Where the entry has the desired name and entry.AESKeySize is set to 256.
Expected behavior
Zip file is produced that is password protected using AES encryption.
Actual behavior
Zip file is produced, but using weaker ZipCrypto encryption.
Version of SharpZipLib
1.2.0 (for .NET Core)
Obtained from (only keep the relevant lines)

Package installed using NuGet

ZipFile is missing some pieces it needs to support AES encryption of entries (was it actually possible to request it to prior to 1.2.0?).
I started looking at filling in the holes, but haven't had time to get it done.

@piksel As long as ZipFile doesn't support the creation of entries with AES encryption, would it be better if the (IStaticDataSource dataSource, ZipEntry entry) version of Add threw when you tried to add such an entry instead of silently not using AES?

Yeah, I agree.

I am closing this as it should have been fixed by #420. Note that ZipFile still doesn't support AES, but at least now it won't silently use another encryption.


talk to Mike about integrating netlabelguide.com with funkwhale instance

@wjmaggos I can join the call if you set one up with Mike, but you have a vision, so I think you should handle this and I am going to assign it to you.

I hate how the button is "assign yourself" and not just "assign"....

@wjmaggos Reach out. Definitely curious about what you have inmind.


Fix VERSION, CHANGELOG.md and fix params

Signed-off-by: chaoxinhu<EMAIL_ADDRESS>Summary

Concisely describe the issue and your solution:
Link to existing issue (type "#" to check):
Specify the tests done so far:

Solutions (Optional)
Please describe the details of your solution if it might be too complicated for reviewers.

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/1.6.5@ce48fb9). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/1.6.5     #251   +/-   ##
================================================
  Coverage                 ?   39.50%
  Complexity               ?     1529
================================================
  Files                    ?      233
  Lines                    ?    13255
  Branches                 ?     1669
================================================
  Hits                     ?     5237
  Misses                   ?     7375
  Partials                 ?      643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce48fb9...e150399. Read the comment docs.


chore: remove excess pb-ws logs

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1370  👈 (View in Graphite)
#1369
#1368
#1367
#1366 : 1 other dependent PR (#1363 )
#1365
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Update email-top-100-domains.txt

added missing mail domain (@online.de)

Source?

German 1&1 Provider

Thank you!

youre welcome


make nowValuer public / exported

So apps using the influxql library can use NowValuer when calling influxql.Reduce.

:+1:


Issue related how to trace current run and attache the feedbacks

Hi
I am working on the LLM application and It is programmed base on RAG archituctre by using LangChain features. I used Streamlit for my front end.
Now I want to use LangSmith for tracing each answer and take a feedback and score from users. I already connected my project with LangSmith dashboard with API and I can see each prompt that the user enters. But unfortunately, I could not attach the feedback to the answer. I have a feature for thumb up and thumb down by using streamlit feedback packages. And also I found the run_id by running traces in the longchain. but whenever I want to assign this run_id to create_feedback() function, I faced to this error :
TypeError: Client.create_feedback() missing 1 required positional argument: 'run_id'
I checked LangSmith and Langchain documentation but I could not find anything related to this issue.
Thanks for your help in advance
st.write("Initialize Retriever")
vector_storage_dir = "./vectorstorage/English/faiss"

retriever = get_standard_retriever(dir=vector_storage_dir)

if "qachain" not in st.session_state:
    st.session_state["qachain"] = initialize_qa_chain(retriever)

status.update(label="Initialization complete!", state="complete", expanded=False)

with st.chat_message("assistant"):
    response = st.session_state["qachain"](prompt,callbacks=[run_collector]) # ONLY FEATURE USED FROM RAG

    with tracers.context.collect_runs() as cb: #collect data for each run
        run_id=(run_collector.traced_runs[0]).id
        client = Client

    message_placeholder = st.empty()
    text = ""
    for chunk in response["result"] :
        text += chunk
        message_placeholder.markdown(text + "▌")
        time.sleep(0.015)  # Adjust the delay time (in seconds) as needed

    if run_id:
        client.create_feedback(
        run_id,
        key="feedback-key",
        score=1.0,
        comment="comment"
        )

        # Define score mappings for both "thumbs" and "faces" feedback systems
        score_mappings = {
            "thumbs": {"👍": 1, "👎": 0},
            "faces": {"😀": 1, "🙂": 0.75, "😐": 0.5, "🙁": 0.25, "😞": 0},
        }

        # Get the score mapping based on the selected feedback option
        scores = score_mappings["thumbs"]

st.session_state.messages.append({"role": "assistant", "content": response["result"]})`

`

maybe someone can enlighten me what a feedback-key means ?

Hard to describe without being circular.
key is the name associated with this feedback type /metric.
So it would be "correctness" or "user_score" or "accuracy" or "my-cool-name".
Then all feedback with that key is aggregated as metrics.
it looks like you're trying to send a request without authentication there

To OP - you're never actually creating a client:
client = Client

Should be
client = Client()


active flag not respected by various login handler

Admin can set active flag on users/groups, but they are not respected by the login handler.
This is related to https://github.com/perfsonar/meshconfig-admin/issues/32

I've updated so that user.check() is performed at common.createClaim() which is called by various auth handler to issue jwt token.


make translation more native

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Information received payment
Payment receipt information
#1 Sacombank MC debit card account
5174 1600 0467 4140
NGUYEN THI HONG HA
#2  Visa debit card account Sacombank
4221 5104 8320 6390
#3 paypal account
ID<EMAIL_ADDRESS>


Finalize refactor of v0 cltk.tokenize pacakge

Some context at #74

I have looked at this again and got feint hearted. @diyclassics you wrote most of this; @todd-cook you know it and have helped; and I have stubbed out how I imagine this being done once refactored (here).
What do you guys think about the entire issue?

FYI @free-variation is looking into this one today

I have ideas about refactoring the Latin tokenizer. I don't have strong opinions about the packaging or organization, so I'm curious to see what John thinks.

Thx Todd. I gave a rundown this evening, to get him up to speed. Says he'll work on it tomorrow. How about we see what he comes up with?

 Refactor sentence and word tokenization.


Fix up environment for next release

Drop ansible ao-logs
Update CSV based on new operator.yaml changes

This should be merged before https://github.com/infrawatch/service-telemetry-operator/pull/183


⚠ Bofrost.be has degraded performance

In ca1595f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: Bofrost.be performance has improved in 990e735.


XCode shader debugging not working when using RenderStatePackager

When using XCode frame capture for debugging shaders, double clicking on the shader shows an XCode error message which says source code / debug symbols are not available.
The following is the config .json file I'm using:
{
"Metal": {
"CompileOptionsiOS": "-sdk iphoneos metal -g -gembed-source -gline-tables-only -frecord-sources"
}
}
I am not seeing the source code embedded in the PSO binary files.

A possible solution is that -frecord-sources command line option may allow embedding debug information into the metal lib. It is not however clear if this option works for the library as the example shows how to use it with AIR files. If this is the case, it is possible to embed debug information directly into the archive when the STRIP_REFLECTION flag is not used.
Another solution may be feasible: It appears that shader symbol files should be generated separately and then loaded by the XCode shader debugging tool (NOTE: this option is only stated to be supported by XCode 13 or later). It also appears that XCode allows specifying a path to the folder containing shader debug symbol files. In this case a solution is for the render state packager to output shader symbol files to a specified folder. The path to the folder will be provided to the packaging tool as an optional parameter (SerializationDeviceMtlInfo::DebugSymbolPath) and corresponding option will be added to the render state packager JSON configuration file.

I think the -frecord-sources would work best for us. How can we manipulate the STRIP_REFLECTION flag?

STRIP_REFLECTION flag affects Vulkan/SPIRV. For Metal you can directly provide all flags through the command line and STRIP_REFLECTION does not have effect.
STRIP_REFLECTION can be set in the archiver using the strip_reflection option.

So it turned out that XCode tells exactly which command line options should be used to enable shader code debugging:

Adding -gline-tables-only -MO to the command line options make the XCode show the shader source code.
You can use the following config file:
{
    "Metal": {
        "CompileOptionsMacOS": "-sdk macosx metal -gline-tables-only -MO",
        "CompileOptionsiOS": "-sdk iphoneos metal -gline-tables-only -MO"
    }
}

@speedym Can you try these options and see if they work for you?

Hmm, interesting. This dialog changed from the last time I saw it (it specifies different options now). Which XCode version are you using?
I have tried the options from the previous version of the dialog, and they didn't work. Have you perhaps tried those new ones out with Diligent examples?

Yes, I tried and these options work with our examples. Without these options, XCode shows the dialog above.

I tested with XCode 12.4 (12D4e). I would be shocked if they changed the command line options in newer version.

Just for reference this is the dialog I was seeing (I tried adding options from this dialog, but they didn't work):

What about the options that my XCode suggests?

On XCode 13.2.1 our app is getting stuck on the following screen:

I'll try it out with XCode 12.4.

I managed to resolve the above XCode getting stuck error by upgrading iOS to latest (15.3.1).

In the good news, It turned out shader profiling is now working on our side as well! :)

The config file which works for latest XCode (13.2.1) is the following:
{
    "Metal": {
        "CompileOptionsMacOS": "-sdk macosx metal -gline-tables-only -frecord-sources",
        "CompileOptionsiOS": "-sdk iphoneos metal -gline-tables-only -frecord-sources"
    }
}

@TheMostDiligent Another note on this one: When compiling shaders with iOS deployment target == 11, shader profiling fails to work even though flags are set up correctly. The workaround for this is to increase the deployment target by using CMAKE_OSX_DEPLOYMENT_TARGET & XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET, and what worked for me is 13.6. I haven't tried other deployment targets. Maybe it's worth printing a warning during Diligent CMake init about this Apple bug. Also, note that I haven't tested this on MacOS, only on iOS.

Just a small addition, earliest deployment target which works for shader profiling is 14.0. Previous deployment (<= 13.6) targets only show the shader sources.


Immediate crash under python 3.7

Description of issue / feature request
Locust crashes immediately after launching under python3.7.  The errors appear to have something to do with greenlet or gevent.
Expected behavior
It should work normally
Actual behavior
Immediate crash.  Output:
> locust -f infrastructure/locust/locustfile.py

<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
<env_path>/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: greenlet.greenlet size changed, may indicate binary incompatibility. Expected 144, got 128
  return f(*args, **kwds)
[2018-07-26 16:45:01,586] L08125.local/INFO/locust.main: Starting web monitor at *:8089
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr: Traceback (most recent call last):
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr: File "<env_path>/bin/locust", line 11, in <module>
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr: sys.exit(main())
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,587] L08125.local/ERROR/stderr: File "<env_path>/lib/python3.7/site-packages/locust/main.py", line 430, in main
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr: main_greenlet = gevent.spawn(web.start, locust_classes, options)
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr: File "src/gevent/greenlet.py", line 538, in gevent._greenlet.Greenlet.spawn
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr: File "src/gevent/greenlet.py", line 213, in gevent._greenlet.Greenlet.__init__
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr: File "src/gevent/_hub_local.py", line 80, in gevent.__hub_local.get_hub_noargs
[2018-07-26 16:45:01,588] L08125.local/ERROR/stderr: File "<env_path>/lib/python3.7/site-packages/gevent/hub.py", line 390, in __init__
[2018-07-26 16:45:01,589] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,589] L08125.local/ERROR/stderr: WaitOperationsGreenlet.__init__(self, None, None)
[2018-07-26 16:45:01,589] L08125.local/ERROR/stderr:
[2018-07-26 16:45:01,590] L08125.local/ERROR/stderr: File "src/gevent/_greenlet_primitives.py", line 42, in gevent.__greenlet_primitives.TrackedRawGreenlet.__init__
[2018-07-26 16:45:01,590] L08125.local/ERROR/stderr: SystemError
[2018-07-26 16:45:01,590] L08125.local/ERROR/stderr: :
[2018-07-26 16:45:01,590] L08125.local/ERROR/stderr: Objects/dictobject.c:1439: bad argument to internal function
[2018-07-26 16:45:01,590] L08125.local/ERROR/stderr:

Environment settings (for bug reports)

OS: macos Sierra (10.12.6)
Python version: 3.7.0
Locust version: 0.8.1

Steps to reproduce (for bug reports)

Create a virtualenv with python 3.7
activate the virtualenv
pip install locustio
make a locustfile (The quickstart one is fine)
run locust -f <path_to_locustfile>

Edit: the package name is locustio, not locust :p

I'm working around this by running locust in a python:3.6 docker container.

To be fair, https://github.com/locustio/locust#supported-python-versions doesn't list 3.7

http://www.gevent.org/changelog.html#unreleased

1.3.6 (unreleased)
gevent now depends on greenlet 0.4.14 or above. gevent binary wheels for 1.3.5 and below must have greenlet 0.4.13 installed on Python 3.7 or they will crash. Reported by Alexey Stepanov in issue #1260 and pkittenis in issue #1261.

My fresh install of locustio on Py3.7 gave me:

gevent [required: >=1.2.2, installed: 1.3.5]
greenlet [required: >=0.4.13, installed: 0.4.14]

installing and pinning greenlet==0.4.13 fixed it for me

:+1: I'll give that a try tomorrow!

I had the same issue:

Running Docker Python3.7 on Google Cloud Kubernetes.
Gunicorn, Greenlet and Gevent newest versions

Issues: Workers were timing out, after some fixing, the Runtime Error.
Fixed:

Changed Base Image to Python3.6
gunicorn==19.9.0
gevent==1.3.4
greenlet==0.4.13

Thanks for your help!

Working fine under python 3.7 for me with the pinned gevent and greenlet versions above

this is working work now.. I just merged #885


new file: Python/other/merge_interval.py

Have you read the Contributing Guidelines on Pull Requests?
Yes I read it
Description
Take an empty list and then apply a condition set of the list the last element is greater, lesser, equal to the number or not. when it equal it will add to the new list and then and then print the non-overlapping  intervals
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
The issue is related to #5224

@HarshCasper sir PR policy is changed?


Add License

This is super useful! Could you add a license? This guide should help. Let me know if you have any questions!

Thanks boss, all squared away.

o7


TS Sanity

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.53%. Comparing base (e7c30d6) to head (540c0a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #317   +/-   ##
=======================================
  Coverage   99.53%   99.53%
=======================================
  Files          23       23
  Lines         214      214
  Branches       63       65    +2
=======================================
  Hits          213      213
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Respect east/west const in function hover

Defining a function using East const, when hovering on it in the code it is always shown as West const.
It would be nice to have it shown respecting the order used in the declaration/definition since for whom uses the East const this is quite ugly and confusing.
Example below.

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


bug: E5113: Error while calling lua chunk: /usr/share/nvim/runtime/lua/vim/treesitter/language.lua:103: no parser for 'vimdoc' language

When entering Kitty's scrollback history with <C-S-h> and either: yanking, pressing i or a, I keep getting the following error:
Error detected while processing FileType Autocommands for "*"..function <SNR>1_LoadFTPlugin[20]..script /usr/share/nvim/runtime/ftplugin/help.lua:
E5113: Error while calling lua chunk: /usr/share/nvim/runtime/lua/vim/treesitter/language.lua:103: no parser for 'vimdoc' language, see :help treesitter-parsers
stack traceback:
        [C]: in function 'error'
        /usr/share/nvim/runtime/lua/vim/treesitter/language.lua:103: in function 'add'
        /usr/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:113: in function 'new'
        /usr/share/nvim/runtime/lua/vim/treesitter.lua:64: in function '_create_parser'
        /usr/share/nvim/runtime/lua/vim/treesitter.lua:131: in function 'get_parser'
        /usr/share/nvim/runtime/lua/vim/treesitter.lua:468: in function 'start'
        /usr/share/nvim/runtime/ftplugin/help.lua:2: in main chunk
        [C]: in function 'nvim_set_option_value'
        ...itty-scrollback.nvim/lua/kitty-scrollback/footer_win.lua:60: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Then the yanked content appears in kitty-scrollback window and I can perform the regular actions (Execute / Paste). If toggling mappings twice with g?, the error occurs again.
Note that I can't reproduce on my Arch Linux VM with similar setup (NVIM v0.10.0-dev-1988+g1ef60ea65-dirty, same Kitty and kitty-scrollback.nvim config). Only occurs on my main system with Gentoo.
Could it be an issue with dev-libs/tree-sitter package specifically on Gentoo?
Maybe this has nothing to do but I do have the vimdoc parser installed:

:checkhealth nvim-treesitter

nvim-treesitter: require("nvim-treesitter.health").check()

Installation ~
- WARNING `tree-sitter` executable not found (parser generator, only needed for :TSInstallFromGrammar, not required for :TSInstall)
- OK `node` found v20.6.1 (only needed for :TSInstallFromGrammar)
- OK `git` executable found.
- OK `cc` executable found. Selected from { vim.NIL, "cc", "gcc", "clang", "cl", "zig" }
  Version: cc (Gentoo 13.2.1_p20230826 p7) 13.2.1 20230826
- OK Neovim was compiled with tree-sitter runtime ABI version 14 (required >=13). Parsers must be compatible with runtime ABI.

OS Info:
{
  machine = "x86_64",
  release = "6.1.67-gentoo-custom",
  sysname = "Linux",
  version = "#11 SMP PREEMPT_DYNAMIC Tue Dec 26 18:38:12 CET 2023"
} ~

Parser/Features         H L F I J
[...]
  - vimdoc              ✓ . . . ✓

I tried to reinstall it with :TSInstall vimdoc but it doesn't make any difference, the error persits.

:KittyScrollbackCheckHealth:

==============================================================================
kitty-scrollback: require("kitty-scrollback.health").check()

kitty-scrollback: Neovim version 0.9+ ~
- OK NVIM 0.10.0-dev+dirty

kitty-scrollback: kitty-scrollback.nvim version ~
- OK        `|`\___/`|`       *kitty-scrollback.nvim* @ `v3.0.0`
           =) `^`Y`^` (=
            \  *^*  /       If you have any issues or questions using *kitty-scrollback.nvim* then
            ` )=*=( `       please create an issue at
            /     \       https://github.com/mikesmithgh/kitty-scrollback.nvim/issues and
            |     |       provide the `KittyScrollbackCheckHealth` report.
           /| | | |\
           \| | `|`_`|`/\
            /_// ___/     *Bonus* *points* *for* *cat* *memes*
               \_)

kitty-scrollback: Kitty remote control ~
- OK `kitty @ ls` exited with code *0*

kitty-scrollback: Kitty data ~
- OK Kitty data available
  >lua
  {
    columns = 157,
    cursor_x = 13,
    cursor_y = 25,
    kitty_config_dir = "/home/xfzv/.config/kitty",
    kitty_opts = {
      allow_remote_control = "yes",
      listen_on = "unix:/tmp/kitty",
      scrollback_fill_enlarged_window = false,
      scrollback_lines = 2000,
      scrollback_pager = { "less", "--chop-long-lines", "--RAW-CONTROL-CHARS", "+INPUT_LINE_NUMBER" },
      scrollback_pager_history_size = 0,
      shell_integration = { "enabled" }
    },
    kitty_path = "/usr/bin/kitty",
    kitty_scrollback_config = "ksb_builtin_checkhealth",
    kitty_version = { 0, 31, 0 },
    ksb_dir = "/home/xfzv/.local/share/nvim/lazy/kitty-scrollback.nvim",
    lines = 35,
    scrolled_by = 0,
    window_id = 1,
    window_title = "nvim"
  }

kitty-scrollback: Kitty version 0.29+ ~
- OK kitty 0.31.0

kitty-scrollback: clipboard ~
- OK Clipboard tool found: *xsel*

kitty-scrollback: sed ~
- OK `sed -E -e s/$//g -e s/\[\?25.\[.*;.*H\[.*//g` exited with code *0* and stdout `expected`
     `sed: /usr/bin/sed`

kitty-scrollback: Kitty debug config ~
- OK `kitty0.31.0` created by ``Kovid Goyal``
     Linux gentoo-desktop 6.1.67-gentoo-custom #11 SMP PREEMPT_DYNAMIC Tue Dec 26 18:38:12 CET 2023 x86_64

     This is gentoo-desktop (Linux x86_64 6.1.67-gentoo-custom) 18:08:52

     DISTRIB_ID="Gentoo"
     Running under: `X11Frozen:` False
     `Paths:  kitty:` /usr/bin/kitty
     `  base dir:` /usr/lib64/kitty
     `  extensions dir:` /usr/lib64/kitty/kitty
     `  system shell:` /bin/zsh
     `Loaded config files:`
       /home/xfzv/.config/kitty/kitty.conf

     Config options different from defaults:
     allow_remote_control       yes
     bell_path                  /usr/share/sounds/freedesktop/stereo/service-login.oga
     bold_font                  JetBrainsMono NF Bold
     bold_italic_font           JetBrainsMono NF Bold Italic
     close_on_child_death       True
     copy_on_select             clipboard
     cursor                     None
     cursor_beam_thickness      1.0
     cursor_shape               2
     cursor_stop_blinking_after 0
     disable_ligatures          1
     enabled_layouts            ['splits']
     font_family                JetBrainsMono NF Medium
     font_size                  10.5
     italic_font                JetBrainsMono NF Italic
     listen_on                  unix:/tmp/kitty
     `modify_font:`
         underline_position 18
         underline_thickness 1
     mouse_hide_wait            0.0
     paste_actions              frozenset({'quote-urls-at-prompt'})
     selection_background       None
     selection_foreground       None
     shell_integration          frozenset({'enabled'})
     strip_trailing_spaces      smart
     tab_bar_edge               1
     tab_bar_margin_height      TabBarMarginHeight(outer=1.0, inner=1.0)
     tab_bar_margin_width       1.0
     tab_bar_style              powerline
     tab_powerline_style        slanted
     url_style                  1
     visual_bell_duration       1.5
     window_margin_width        FloatEdges(left=1.0, top=1.0, right=1.0, bottom=1.0)
     window_padding_width       FloatEdges(left=1.0, top=1.0, right=1.0, bottom=1.0)
     `Added mouse actions:`
     	ctrl+left release grabbed →  mouse_handle_click link
     	ctrl+left release ungrabbed →  mouse_handle_click link
     `Changed mouse actions:`
     	ctrl+shift+right press ungrabbed →  combine : mouse_select_command_output : kitty_scrollback_nvim --config ksb_builtin_last_visited_cmd_output
     `Added shortcuts:`
     	alt+0x01000000 →  scroll_page_down
     	alt+end →  scroll_end
     	alt+home →  scroll_home
     	ctrl+c →  copy_or_interrupt
     	ctrl+kp_add →  change_font_size all +2.0
     	ctrl+kp_subtract →  change_font_size all -2.0
     	ctrl+v →  paste_from_clipboard
     	ctrl+w →  close_tab
     	f2 →  set_tab_title
     `Changed shortcuts:`
     	kitty_mod+g →  kitty_scrollback_nvim --config ksb_builtin_last_cmd_output
     	kitty_mod+h →  kitty_scrollback_nvim
     	kitty_mod+j →  move_tab_forward
     	kitty_mod+k →  move_tab_backward
     	kitty_mod+w →  detach_tab
     `Colors`:
     	active_border_color        #a6e3a1
     	active_tab_background      #505052
     	active_tab_foreground      #cdd6f4
     	background                 #1e1e20
     	color0                     #45475a
     	color1                     #f38ba8
     	color10                    #a6e3a1
     	color11                    #f9e2af
     	color12                    #89b4fa
     	color13                    #b4befe
     	color14                    #94e2d5
     	color15                    #a6adc8
     	color2                     #a6e3a1
     	color3                     #f9e2af
     	color4                     #89b4fa
     	color5                     #b4befe
     	color6                     #94e2d5
     	color7                     #bac2de
     	color8                     #585b70
     	color9                     #f38ba8
     	foreground                 #cdd6f4
     	inactive_border_color      #a6adc8
     	inactive_tab_background    #262626
     	inactive_tab_foreground    #cdd6f4
     	url_color                  #89b4fa

     `Important environment variables seen by the kitty process:`
     	PATH                                `/usr/local/sbin:/usr/local/bin:/usr/bin:/opt/bin:/usr/lib/llvm/16/bin`
     	LANG                                `en_US.UTF-8`
     	EDITOR                              `/bin/nano`
     	SHELL                               `/bin/zsh`
     	DISPLAY                             `:0`
     	USER                                `xfzv`
     	XDG_CONFIG_DIRS                     `/etc/xdg`
     	LC_ADDRESS                          `en_US.UTF-8`
     	LC_NAME                             `en_US.UTF-8`
     	XDG_DATA_HOME                       `/home/xfzv/.local/share`
     	XDG_CONFIG_HOME                     `/home/xfzv/.config`
     	LC_MONETARY                         `en_US.UTF-8`
     	XDG_SEAT                            `seat0`
     	XDG_SESSION_TYPE                    `tty`
     	LC_PAPER                            `en_US.UTF-8`
     	XDG_CACHE_HOME                      `/home/xfzv/.cache`
     	XDG_SESSION_CLASS                   `user`
     	LC_IDENTIFICATION                   `en_US.UTF-8`
     	LC_TELEPHONE                        `en_US.UTF-8`
     	LC_MESSAGES                         `en_US.UTF-8`
     	LC_MEASUREMENT                      `en_US.UTF-8`
     	XDG_VTNR                            `1`
     	XDG_SESSION_ID                      `1`
     	XDG_STATE_HOME                      `/home/xfzv/.local/state`
     	XDG_RUNTIME_DIR                     `/run/user/1000`
     	LC_TIME                             `en_US.UTF-8`
     	LC_COLLATE                          `C.UTF-8`
     	XDG_DATA_DIRS                       `/usr/local/share:/usr/share`
     	LC_NUMERIC                          `en_US.UTF-8`

@xfzv interesting. The footer is using the filetype help for the highlights. Can you try :TSInstall vim ?
I think it uses vim instead of vimdoc. To be honest, I am not sure what the difference is.

@xfzv how are you installing Neovim, are you building from source? I was able to reproduce by manually removing vimdoc.so in neovim/build/lib/nvim/parser/. (I build Neovim from source).

Edit: I found neovim/neovim#26379, maybe related

@xfzv good find! I subscribed to that issue. I'll keep this open for a little while in case anyone else has something similar 👍.

Note: I just saw this on the nightly CI build.
E5113: Error while calling lua chunk: ...ghtly/share/nvim/runtime/lua/vim/treesitter/language.lua:103: no parser for 'vimdoc' language, see :help treesitter-parsers

https://github.com/mikesmithgh/kitty-scrollback.nvim/actions/runs/7601066405

Closing this bug. https://github.com/neovim/neovim/issues/26379 is closed as completed in https://github.com/neovim/neovim/pull/28226

Hey @xfzv, I'll try and see if I can play around a bit to reproduce. I'm on a Mac so I'll probably use UTM to install Gentoo. I've been a little busy of late so may take a few days to get around to it. Thanks!

@xfzv thanks for the additional info! I'll try to carve out some time to investigate this. Feel free to post more info as you find it.

@xfzv awesome! I actually tried installing arch on UTM yesterday and couldn't figure out how to get a desktop environment working :joy: so I'm glad it is sorted out


Exception on WebView2 with WinUI 3 Preview 4

Hi, I'm Martin from Windows Template Studio Team.
We've updated WinUI Templates to Preview 4 and we are having an issue with the WevView2 control that we didn't have on the preview 3.
Describe the bug

WebView2 control throws an exception while debugging. The app does not crash and if you press F5 on the exception details view, the app continues running and the webview content is shown.
Steps to reproduce the bug

Run the app with F5 (debugging)
See the app crash
Press F5 on the exception details in VS and keep using the app.

Screenshots

Version Info
NuGet package version:
[Microsoft.WinUI 3.0.0-preview4.210210.4] If you seeing your issue in older previews, please try preview4.

Windows app type:

UWP
Win32

-
Yes

Windows 10 version
Saw the problem?

October 2020 Update (19042)
Yes

Device form factor
Saw the problem?

Desktop
Yes

I forgot to attach the minimum repro app.
WebViewIssueWinUIApp.zip

winui3-preview3 is ok.
but winui3-preview4: webview2 will throw Exception: WinRT originate error - 0x80070490 : 'Element not found.'.

if i unistall webview2 runtime  and keep  microsoft edge brower throw exception :WinRT originate error - 0x80070002 : 'The system cannot find the file specified.'.

Microsoft.UI.Xaml.Controls.dll!winrt::throw_hresult(struct winrt::hresult)
Microsoft.UI.Xaml.Controls.dll!winrt::impl::consume_Windows_UI_ViewManagement_IAccessibilitySettings<struct winrt::Windows::UI::ViewManagement::IAccessibilitySettings>::HighContrastChanged(struct winrt::auto_revoke_t,struct winrt::Windows::Foundation::TypedEventHandler<struct winrt::Windows::UI::ViewManagement::AccessibilitySettings,struct winrt::Windows::Foundation::IInspectable> const &)
Microsoft.UI.Xaml.Controls.dll!WebView2::TryCompleteInitialization(void)

According to the Known Issues for Preview 4, the AccessibilitySettings.HighContrastChanged event is no longer supported in Desktop apps.

just to mention: (same environment as @mvegaca)
Exception thrown at 0x00007FFA6C11D759 (KernelBase.dll) in Downloader.exe: WinRT originate error - 0x80070490 : 'Element not found.'.
onecore\com\combase\winrt\error\restrictederror.cpp(1016)\combase.dll!00007FFA6D0BC8D3: (caller: 00007FFA6D0C65A9) ReturnHr(4) tid(280c) 8007007E The specified module could not be found.
Exception thrown at 0x00007FFA6C11D759 in Downloader.exe: Microsoft C++ exception: winrt::hresult_error at memory location 0x000000CFBFD7C690.

This issue is solved after updating to Project Reunion 0.5 Preview

The fix is indeed in the Project Reunion 0.5 Preview. Thanks for confirming, @sibille!


gtk: fix missing immodules.cache

Description of changes
This adds an additional step to the postBuild hook which generates the immodules.cache file and puts it into the build. This is necessary for support of input method editors in gtk apps on some setups. It used to be generated by gtk's own post-install script, but this was changed recently – see #172406.
I'm not happy with how this looks (the line is way too long, the gtk module path ${out}/lib/gtk-3.0/3.0.0) is duplicated, and the 3.0 and 3.0.0 version numbers are already hardcoded further up in the file, for the clean-immodules-cache.sh hook, but they're not accessible from that scope). I'm not really sure how to actually make this nicer though, so I'd appreciate some feedback here.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable: not sure what to do here?

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". no, that's way too many. I have tested gedit and firefox though

[ ] Tested basic functionality of all binary files (usually in ./result/bin/) not really applicable, this is a library?

22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Oh, and this needs to target staging due to the huge number of rebuilds.

needs to target staging

Do I need to to something specific for that?

Should be gated to not break cross-compilation (or even better, use the application from the native platform). Ok with the first option though, I can look into fixing it properly later.

Should be gated to not break cross-compilation (or even better, use the application from the native platform). Ok with the first option though, I can look into fixing it properly later.

How do you mean exactly? Something with the stdenv.isDarwin clause?

Something like lib.optionalString (stdenv.buildPlatform == stdenv.hostPlatform) '' bash code here '';.
In that case it's only executed when native compilation is done.
For cross it should use the tool that's built for the host platform, but I can take care of that later.

@Mindavi I did it the way you suggested, thank you very much!

@ofborg build gtk3


Explorer: Shift+right click not working on first time

Steps to Reproduce:

open a workspace with a single empty folder
as the very first action Shift+right-click on the empty folder

=> the Delete action shows up normally
When you then select the folder and try again it works nicely.

I can not reproduce this with latest vscode insiders both on os x and on windows. Both when doing shift + click and alt + click.
Do you still see this?

@isidorn yes reproduces, in the video I started Code-Insiders freshly. The folder is collapsed and empty:

@bpasero the state of the folder should have no affect on this. Can you repro for any folder?
Can you please just put some console log or breakpoint here just so we check if the keydown event is passed
Can you also repro on mac?
I can also just come to your machine if you prefer that.

@isidorn your suspicion seems right, only the second time I get something printed so it looks like that event handler is not triggered.

@bpasero might it be an electron issue that we are missing a keybinding? How to proceed here?

@isidorn I do not think so, it looks like the listener is not being installed until I opened the menu once, could that be the issue?

@bpasero you are correct I only create the AlternativeKeyEmitter once the actions are being filled for the first time. So there is your corner case.
Ideally the AlternativeKeyEmitter would be a workbench contribution, but I can not do that due to layering (he is in platform).
Another approach is for it to be an anonyimous class like before which has no contrustor arguments. I like that approach but the issue is that I still need the contextMenuService because I am missing keys when the context menu is shown. This might be solved with electron 2.0 and async menus and that might simpllify this issue.
For now pushing it to on-deck. Suggestions are welcome also.

@bpasero weirdly we have electron 2.0 but the menus are still async and I do not get any event while a context menu is shown. Why is that? Am I misunderstanding the concept?

@isidorn are you using custom or native menus? It could well be that even though the menus are async, we still do not get the event.

@bpasero native menus on the mac


Fixes bug that never checked result of test in check_smoke.sh

Some tests were using the 'make run' command to encode a more complex command for testing. This would never trigger a test failure in check_smoke.sh as it relies on the 'make check' rule.
This patch fixes this for some tests.
I don't know if more tests in smoke show this behavior.

I was going through all Makefiles that have their on run rule defined and added this change. This made some smoke tests fail again.
I'd like @estewart08 to comment on the approach first anyway.

I moved this to a draft so that it is not merged accidentally and breaking any CI.

Yeah I like the idea, just need to make sure everyone is informed.

I think this PR requires first accepting these PRs, which all move tests back into smoke-fails.
Tests in 474 and 475 need to be looked at and see what is the expected output.
For 476, I have opened a Gerrit review that addresses this bug.

https://github.com/ROCm-Developer-Tools/aomp/pull/474
https://github.com/ROCm-Developer-Tools/aomp/pull/475
https://github.com/ROCm-Developer-Tools/aomp/pull/476

Rebased to current aomp-dev, should be ready to merge.


VSCode on Windows 10 + Docker: Wrong build path

VSCode Version: 1.8.1 (stable)
OS Version: Windows 10 Build 14393

Steps to Reproduce:

Install Docker for Windows
Install VSCode
Add Docker extension
Create an empty Folder (eg MicroServiceTemplate) and open it in VSCode
Generate a Dockerfile from the command palette with default settings
Run Docker: Build from the command palette

Here the questions are already filled with the wrong values, like selecting the Dockerfile, it shows e\Dockerfile
The Build fails then with C:\Users\max06\OneDrive\Dokumente\Develop\MicroServiceTemplate>docker build -f e\Dockerfile -t e:latest e unable to prepare context: unable to evaluate symlinks in context path: GetFileAttributesEx C:\Users\max06\On eDrive\Dokumente\Develop\MicroServiceTemplate\e: Das System kann die angegebene Da tei nicht finden.
When I try to build it manually with correct parameters, it works.

I could reproduce the problem on a second windows machine, but not on an ubuntu system.

I could reproduce the problem on a second windows machine, but not on an ubuntu system.

@max06 I think we can start investigation from the docker extension.

This issue was moved to Microsoft/vscode-docker#51


A lot of crashes with android 7.0

I have k9 installed on some devices, but the only one with android 7.0 suffers of crashes which do not happen in android 4.4.
Expected behavior
Tell us what should happen
Actual behavior
Tell us what happens instead
Steps to reproduce

Environment
K-9 Mail version:5.206
Android version:7.0
Account type (IMAP, POP3, WebDAV/Exchange):imap

I'm having this problem too with a new Moto G5 with android 7; the crash happens fairly randomly while I'm reading an email, and then going back to the list of emails in a folder.
I've attached a debug log and a screenshot showing my firmware version.
k9-log_170715.txt

Hopefully this is some help in finding the bug.
Thanks for your help,
Roger V.

debug 170716.txt

Closing because no further information was provided.


Minimum alternative to Prior class

Seems like only objects with create_variable method and dims property can be used as well

I believe #381 would be easy with this abstraction

One of the difficult aspect here is that the serialization will be different for object. So there will need to be a way to distinguish between objects when they come from serialization.

Closed by
https://github.com/pymc-labs/pymc-marketing/pull/1292


Better Material Editor and conversions

Right now the current material workflow can be really frustrating, due to the lack of several options that could potentially improve user usability, some useful functions could be:
1. Select a material from a mesh and convert it to the desired material, instead of having to setup a whole new material. (A dedicated window just for materials could be a good idea too, so we can select and convert multiple ones to whatever shader we want (if applies).)

2. Change shader materials dynamically

3. Auto Render Bucket values for shader materials, (example: non zero BR values for cutout_fence, cutout, decal, etc.)

4. Detect if there's something linked to the alpha node and then when doing the material conversion it became something like decal or cutout/cutout_fence, ask the user or whatever.
5. Convert Sollumz material to standard ones, so the models can be exported outside Blender properly

Each shader is so unique it would almost be impossible for me to be able to to know what textures to assign which texture parameters from when converting to a sollumz shader or converting to a different sollumz shader... so 1, 2, 4 are pretty much outta the picture. As for auto setting render bucket it is something I am going to look into. as far as materials not exporting correctly when they are not a sollumz shader Im not sure I know what you mean? also this kinda is in the same category as 1,2,4 because each shader is so unique. Ill leave this here for now maybe I can think of a way to do it.

There is no need to know the parameter as they all have exactly the same name for each parameter if it exists in the other shader in the first place. For example:
If we need to change a shader that is decal_tnt to normal, ignoring the part where we don't have a BumpSampler, we still have the DiffuseSampler in both shaders, it just has to take from one shader to another the Samplers/Parameters which exists, I think that you just have to bring the Samplers, and everything should be default values to make it simpler.

With (5.) I meant to use Blender as a proper bridge to bring V assets elsewhere, not to back to V, since I tried to do so but for some reason, the UV maps were not existent.

I know how it would work lol, its just that some shaders dont have a diffuse sampler but a texture sampler for the main texture etc.. anyway like I said I may think of a way to do it. hm uvs should always be existent unless you delete them they are created just how you would create any other model for any other game / engine so sounds like you made an error somewhere maybe in the export settings?

Latest commit added some of these features :)


Webpack support

All the files in the v86 npm package seem to want to import fs when run in node. This means that my webpack build fails if I include V86.
Is there a way to import the browser libv86.js in node without manually managing the files?

I'd be surprised if Webpack didn't have a way to support this scenario.
We could move the code into a separate file and conditionally include it in the build process. I'm not enthusiastic, but I'd probably accept a PR. Any other suggestions?

I ran into a similar issue with a different build tool. This may seem a bit hacky, but I was able to get it working by re-compiling libv86.js with SWC.
npx \
  --package=@swc/cli \
  --package=@swc/core \
  -- swc \
    -C jsc.target=es2020 \
    -C jsc.transform.optimizer.globals.typeofs.window=object \
    -C jsc.transform.optimizer.globals.typeofs.require=undefined \
    -C jsc.transform.optimizer.globals.typeofs.XMLHTTPRequest=function \
    -C jsc.transform.optimizer.globals.typeofs.process=undefined \
    --out-file=libv86-web.js \
    libv86.js

It might be better to do this with Closure Compiler (if it has a similar feature) since that's what is being used to build libv86.js.


Embedded Tooltips - Multiple Boon Stats Hard to Read

See picture - Stability is hard to read stack count it gives out.

can you give me a specialisation id for this for testing?

Spec: 27 Trait: 31765


added school name

@Szczotsonn Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please start requesting the licenses in about an hour, to let the changes to propagate through our system.


Publish docs not being published and failing silently

JS SDK docs are not being published correctly and fail silently. See here
This issue is about making sure the docs get publish and also that it does not fail silently again.

Should be fixed with a fresh key in

#493


Example for using Google benchmark library with Charm++

Original issue: https://charm.cs.illinois.edu/redmine/issues/1532

The attached code shows how to use Google's benchmark library with Charm++. It's nice because it automatically does enough iterations of the measured routine to provide a reasonably stable output. We should add some version of this to our contrib or examples directory.

Original author: Dong Hun Lee
Original date: 2018-01-19 20:39:45

~~https://charm.cs.illinois.edu/gerrit/#/c/3540/~~ https://github.com/UIUC-PPL/charm/commit/2a557041d88d7e4dd2631d9f601b8a22992d6cf4


Multi user bug in clients.py

clients.py references users[0]['privateKey'] so when you're trying to do transactions on USER_2 etc it's using USER_1's private key and it fails. So if I try to send in a team from USER_2 it says I am not the owner because it's using USER_1's private key.
src/common/clients.py
privateKey=users[0]["privateKey"],

Hi @gmalca , and welcome to the community!
Multi user is not supported yet, please see https://github.com/coccoinomane/crabada.py/issues/62 for more details.
It is one of the next couple of features that will be implemented :-)
Cheers,
Cocco


Generate build JAR for each module

At the moment, build JARs are generated but they are not generated properly. Their names lack a "ketill" prefix, a version indicator, and are not easily acessible for download in Jenkins.

Completed in commit ab67d148d02161760943c2fed941f810a599b067.


Cache checked files in fs

Summary
For the same path, the function fs.statSync can call many times. The more test files, the more often it will be called for the same file or directory.
I just added hash table to avoid repeated call for fs.statSync.

Test plan

Codecov Report

Merging #8388 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8388      +/-   ##
==========================================
+ Coverage   62.34%   62.36%   +0.01%
==========================================
  Files         266      266
  Lines       10738    10743       +5
  Branches     2611     2612       +1
==========================================
+ Hits         6695     6700       +5
  Misses       3460     3460
  Partials      583      583

Impacted Files
Coverage Δ

packages/jest-resolve/src/defaultResolver.ts
66.66% <100%> (+2.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3c712...29a8f4a. Read the comment docs.

I also think some perf numbers would be great. Caches (esp. those that are never invalidated) can cause problems, so I think we should only introduce this extra complexity for a good reason.

I created some function performer for testing isFile function.
function perfDecorator(fn) {
  const results = [];
  function printResult() {
    console.log('Perf result start:');
    console.log('Total calls:', results.length, ' ');
    console.log('Min time:', Math.min(...results));
    console.log('Max time:', Math.max(...results));
    console.log(
      'Average time:',
      results.reduce((acc, next) => acc + next, 0) / results.length,
    );
    console.log(
      'Sum time:',
      results.reduce((acc, next) => acc + next, 0),
    );
    console.log('Uniq paths:', typeof checkedPaths === 'Object' ? Object.keys(checkedPaths).length) : '';
    console.log('Perf result end');
  }
  return function(path) {
    let time = process.hrtime()[1];
    const fnResult = fn(path);
    time = process.hrtime()[1] - time;
    results.push(time);
    if (results.length === 4500) {
        printResult();
    }
    return fnResult;
  };
}

isFile = perfDecorator(isFile);

I tested it in my some project.
Total calls isFile: 4500
Uniq paths: 3697
About 20% calsl got from cache.

Woah, that's great!
Only thing I'm worried about is if the path starts pointing to a different file or it's a file instead of a directory - do we do any cache invalidation here?

I'd think that cache invalidation is mostly a problem in watch mode. You could simply bypass the cache in that case.
Apart from watch mode, the only other sources of file changes during runtime I could think of are:

Newly generated snapshot files
Jest internal cache files
If a user changes something while jest is running.

I tested the first scenario by deleting and re-populating all our snapshots (>200) without any problems. The created files match perfectly according to git. With respect to number 3, jest is already running into problems with weird errors, so I don't think this PR matters in that respect. Though it might make future improvements harder.
With respect to number 2, you know better if jest-resolve is even used in those cases.

It's watch mode I was thinking of, yes. Maybe we could just clear the map when starting a new test run?

Should the cache perhaps be in Resolver itself instead of the default resolver impl? That would probably make resetting a lot cleaner as well.

BTW testing this on a company React app test suite showed about 8% reduction in total time. Pretty good 👍

It's watch mode I was thinking of, yes. Maybe we could just clear the map when starting a new test run?

I tried run with --watch mode. This patch doesn't effect it because defaultResolver re-required after change files in project. So map refreshed. You can check it just print console.log(checkedPaths.size) inside module. Well, or I do not understand something ((.
const checkedPaths = new Map<string, number>();
console.log('We are here and we have clear Map', checkedPaths.size);

And after run test with --watch, and after try to change your tests.
@SimenB

@scotthovestadt @Connormiha The change seem to breaking Jest watch mode me. Here is a simple test:

start a simple failing test that imports an inexistent modules in watch mode,
add the module while in watch mode,
the test is still failing:

@ArtemGovorov Patch arrived with 24.9.0.


Isaas strategy

Hi all, may I ask you to review the first proposal of iSaaS strategy/selection (chapter "Selection of iSaaS" of the ReadMe)? Key points to review:

A priori feasibility?
Does it make sense in general?
Could we further simplify some aspects?

Section: Detailed as-is process description, including an as-is process model

BPMN process model:

Supplier is a black box. Change the actual pool to "empty pool".
start event should be named in a past form
end events should be named in a past form
tasks should be named in an active form starting with a verb (e.g. preselection of supplier --> preselect supplier)
as you use the task type manual, I would suggest defining the types for all the tasks (e.g. user tasks)
best practice for process modeling: use XOR-join-gateway and don't connect multiple sequence flows to one task (e.g. use XOR gateway before this task: Send requirements profile and manufacturing description)
best practice for process modeling: the input is coming from the left side and the output goes to the right side of one task. e.g. preselection of supplier the output should be on the right side and then it goes down to the next task and should be connected to the next task in the way as it is in the moment - input is coming for the left.


Missing file frontend/build/static/js/mode-rego.js

I'm getting the following errors when using the code editor
2024-10-03 01:22:53.654 ComponentRequestHandler: GET /opt/homebrew/lib/python3.11/site-packages/code_editor/frontend/build/static/js/mode-rego.js read error
Traceback (most recent call last):
File "/opt/homebrew/lib/python3.11/site-packages/streamlit/web/server/component_request_handler.py", line 56, in get
with open(abspath, "rb") as file:
^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/opt/homebrew/lib/python3.11/site-packages/code_editor/frontend/build/static/js/mode-rego.js'

Hi, I will try to look into this today, but my guess here is that you are trying to use an unsupported language/mode called "rego." Or it could be an issue with mismatching versions where the mode name/file got renamed.


IsSignatureValid always false

Hi,
I'm testing this framework with a Sagepay test account but apparently the signature is always invalid:
if (!sagePayResponse.IsSignatureValid(sagePayPayment.SecurityKey, SagePayMvc.Configuration.Current.VendorName))
When debugging, the Hash that is generated is different from the one received from the server.
Any ideas on I might be missing?
Thanks!

Hi, this was a change made by SagePay in the latest version of their protocol. They've changed how their signature is generated, and have provided no documentation on this, so there's no way to verify the signature anymore.
SagePay's own integration kits no longer perform signature checking, so I'd suggest removing the check completely.

Okay, thanks for the very quick reply !

Digging around a bit I've found this:
http://stackoverflow.com/questions/23480263/sagepay-server-integration-verify-signature
It seems that the MD5 now takes into account
DeclineCode + ExpiryDate + FraudResponse + BankAuthCode.

Just to confirm that worked.
I modified SagePayBinder.cs to add in the additional strings:
const string DeclineCode = "DeclineCode";
const string ExpiryDate = "ExpiryDate";
const string FraudResponse = "FraudResponse";
const string BankAuthCode = "BankAuthCode";
and the constructor
response.DeclineCode = GetFormField(DeclineCode, bindingContext.ValueProvider);
response.ExpiryDate = GetFormField(ExpiryDate, bindingContext.ValueProvider);
response.FraudResponse = GetFormField(FraudResponse, bindingContext.ValueProvider);
response.BankAuthCode = GetFormField(BankAuthCode, bindingContext.ValueProvider);
and then SagePayResponse.cs - 4 new properties
public string DeclineCode { get; set; }
public string ExpiryDate { get; set; }
public string FraudResponse { get; set; }
public string BankAuthCode { get; set; }
Followed by updating GenerateSignature
builder.Append(DeclineCode);
builder.Append(ExpiryDate);
builder.Append(FraudResponse);
builder.Append(BankAuthCode);

Having done this I can't help but thing it's a bit redundant!  I can't see that it actually provides any additional security.  In fact the only thing it seems to do is check that the data you've received is correct.  However given that HTTP should be error checked in any case... I'm not sure of it's purpose...
Would be curious to know otherwise!

I agree - it's a bit redundant. Still, I'll make the fix.


Updated node-inspector

Allows me to use shrinkwrap.
See:
https://github.com/npm/npm/issues/8523
Verified it's working.

@vesparny LMK if you have any questions. Thank you!

@michaelBenin thanks I'll merge it asap

+1

@vesparny bump


[19.09] signal-desktop: 1.29.0 -> 1.29.1 (backport)

(cherry picked from commit 8d5f5e7e3e73ff185b5cb88952cdafb81042c7f6)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test signal-desktop


Automated cherry pick of #2776: fix: 1. nil pointer panic error when accessing resource pool and storagecache 2. support multiple disk format

Cherry pick of #2776 on release/2.10.0.
#2776: fix: 1. nil pointer panic error when accessing resource pool and storagecache 2. support multiple disk format

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@ae0b931). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #2791   +/-   ##
================================================
  Coverage                  ?   7.62%
================================================
  Files                     ?     411
  Lines                     ?   64587
  Branches                  ?       0
================================================
  Hits                      ?    4923
  Misses                    ?   59241
  Partials                  ?     423

Flag
Coverage Δ

#aFlag
7.62% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/hosts.go
0.39% <0%> (ø)

pkg/compute/models/cloudsync.go
0% <0%> (ø)

pkg/util/esxi/virtualmachine.go
0% <0%> (ø)

pkg/util/esxi/vdisk.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0b931...c21f997. Read the comment docs.


chore: bump @libp2p/interface-connection-encrypter

We changed the interface here: https://github.com/libp2p/js-libp2p-interfaces/pull/293 and now need to update the dep here so that we can properly pass in Noise as a connection encrypter (types are currently mismatched).

Ci is broken until https://github.com/libp2p/js-libp2p/pull/1398 is in

https://github.com/libp2p/js-libp2p/pull/1403 🤷🏻♂

Superseded by #1406


component calendar

We could have a calendar like this for input type data http://www.material-ui.com/#/components/date-picker

Duplicate of #782


deCONZ - support for power plugs

Description:
This PR moves some devices (power plugs) that identifies themselves as lights to the switch platform. This also enables other types of devices to be added, like sirens, ventilation controllers and curtain controllers.
Breaking change:
Power plugs that are of type "On/Off plug-in unit" and "Smart plug" (Osram and Innr among others) will now be switches instead of lights. Entities will be found as switch.entity_id instead of light.entity_id.
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.github.io#5937
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable.
[x] New dependencies are only imported inside functions that use them.
[x] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Could not find a related documentation PR. Adding docs-missing label.

The PR should be enough. I got two plugs today. Verified to work 👍🏻

Might be my "testing" setup, too. Looking forward to the official release 👍

@MartinHjelmare I think coverage is ok, except for methods in entities which are not tested today.

It's ok to add coverage calculation if the coverage for each module included is at least 95%. You can eg start by including the deconz component package modules.
But only if it's ready. You decide.

Allright, I'll take a look at this and create a separate PR for it.

Yes, you can check it via the command line with the pytest coverage plugin that home assistant already requires:
https://pypi.org/project/pytest-cov/

Please add a paragraph in the description about the breaking change for the release notes.

@MartinHjelmare done

Awesome! Thanks @MartinHjelmare


Is there a way to render a path like you would using SVG?

Wondering if this library supports more than the basic straight line and would support something like:
<path d="M10 10 C 20 20, 40 20, 50 10" />

Hi @heavysixer ,
Unfortunately, no.  The OOXML/PPT spec doesn't support this type of drawing that i'm aware of.  SVG images can be added to a presentation, but Microsoft doesn't render them - even in PowerPoint Online.

@gitbrent Thank you for the prompt reply, I am curious how are the shapes you do support generated, i.e. the squares, triangles and the like. I see reference to them in the source but they don't seem to be actually building the shapes themselves... are they referencing some sort of built in functionality with powerpoint?

Sure.
Shapes are defined using the Open Office XML Presentation spec: Shapes


Added documentation for developers. Initial commit: debugging rancher 2.

Hi,
today I created documentation and scripts for a debugging workflow with GOLAND.

creates a docker container with volume bound source code and compiled binary
delve is also volume bound into this container
GOLAND starts this container, starts a script which starts delve loading the rancher binary
the rancher binary compiled outside of the container is volume bound to /usr/bin/rancher
after a restart of the debug session, GOLAND kills delve in the container and restarts the container and delve, reconnects itself to delve.

I'm able to edit code, compile and debug rancher without leaving the GOLAND IDE. That makes me very happe. Hopefully it will do so for you :-)
This should also work together with Visual Studio Code but yesterday as I tried it out, I had severe performance issues with the current GO plugin for VSCode. Therefore I switched to GOLAND.
Most of the scripts (at least in /rancher/packages/debugger) are copy/paste because the Dockerfiles need scripts from rancher/packages and I saw no need to not reuse them for the debugger container.
Rancher Agent debugging currently is not addressed by this pull request. This is tbd.
The developer community must be supported with more documentation about this project.
I'm eager to get feedback from you.
Greetz,
Josef

This is a pretty epic PR. Sorry it never got the attention it deserved. Honestly, I think we didn't address this because it isn't the workflow of rancher devs and we probably didn't want to take on scripts and docs that we didn't know intimately and could actively support.
I'm going to close this. Thanks for submitting.


options in incoming message

The ability to pass options in an incoming message, such as in a drop-down list, is sorely lacking.
Is it possible to implement this functionality?
Thanks!

Hi @servim,
I can indeed understand that this might be useful in lots of cases.
However I think it might result in quite some work.  Especially because we spent already lots of time to get a grip on the messages that are being replayed by the dashboard framework (both server side replay and client side replay), in all kind of cases.
New messages like this will also be replayed by the dashboard, so everything has to be checked again.
And both @hotNipi and I have little of spare time at the moment ...
Bart

Expect quite of fighting with replayMessages and unexpected situations at the select after change. Those nodes are not similar in behavior. Implementing this may lead to significant drop of the reliability.

I'm understood, thank you!


Searchable directive with @auth generates confusing resolver

Describe the bug
I'm not sure if this is a bug, but several issues are posted regarding to this problem.
(related issues: #5795 #5009 #2822)
Basically I faced some problems below when running search query with certain limit.

it returns incorrect length of items
It returns wrong length of total count
it doesn’t return nexttoken even though there’re still data

After investigation, it turned out those were caused by the same reason.
Seeing the implementation, the search resolver filters the results based on the @auth directive, which leads to unexpected result especially when there's no filtered data as a result. to be clear, I explain this in the repro section.
Amplify CLI Version
4.31.1
To Reproduce
let's say you have a  Bool type with @model, @auth and @searchable
type Book
  @model
  @searchable
  @auth(
    rules: [
      {allow: owner, ownerField: "owner", operations: [create, update, delete, read]}
    ]
  )
{
  id: ID!
  title: String!
  owner: String
}

then you want to retrieve all of the books owned by current user, whose title contains “Harry Potter”, so query will be like
searchBooks({
  limit: 5,
  sort: {direction: desc, field: "createdAt"},
  filter: { title: { match: "Harry Potter" } }
})

It searches in elastic search like this
GET book/doc/_search
{
  "size": 5,
  "sort":  [ { "createdAt": { "order": "desc" }  }]
  "query": {
     "title": { "match": "Harry Potter" }
  }
}

As this query doesn't includes owner field, it'll search every books in elastic search, no matter who own them.
This shouldn’t be a problem as long as the search result only contains current-user’s book.
But what if it contains other users book?
In the next step, res.vtl handles that response, checking if the items belong to their owners.
    #set( $items = [] )
    #foreach( $item in $es_items )
      #set( $isLocalOwnerAuthorized = false )
      #set( $allowedOwners0 = $util.defaultIfNull($item.uid, []) )
      #set( $identityValue = $util.defaultIfNull($ctx.identity.claims.get("username"), $util.defaultIfNull($ctx.identity.claims.get("cognito:username"), "___xamznone____")) )
      #if( $util.isList($allowedOwners0) )
        #foreach( $allowedOwner in $allowedOwners0 )
          #if( $allowedOwner == $identityValue )
            #set( $isLocalOwnerAuthorized = true )
          #end
        #end
      #end
      #if( $util.isString($allowedOwners0) )
        #if( $allowedOwners0 == $identityValue )
          #set( $isLocalOwnerAuthorized = true )
        #end
      #end
      #if( ($isLocalDynamicGroupAuthorized == true || $isLocalOwnerAuthorized == true) )
        $util.qr($items.add($item))
      #end
    #end
    #set( $es_items = $items )

Here, if result doesn’t contains current owners data, it obviously returns empty data with total count 0, and nextToken is going to be null as well.
So as a result, developers might be confused because there're still matched data.
to solve this issue, I added owner field check to the filter
searchBooks({
  limit: 5,
  sort: {direction: desc, field: "createdAt"},
  filter: {owner: {eq: "XXXXXXXXXXXXXXXXXX"}, title: {matchPhrase: "Harry Potter"}}
})

It works but it's not intuitive. In addition, there're two similar filtering logic in elastic search and res.vtl which is wasteful.
Expected behavior
It might should filter only on the request side (elastic search side) when auth rule is applied.
Desktop (please complete the following information):

OS: Mac
Node Version v12.16.0

I updated code example because there's some mistakes.
I want to left a suggestion:
Since filter twice is redundant implementation, amplify-cli should create request-side owner filtering logic. And I'm not sure if it's a appropriate way but it should return error if non current owner id is set on owner field (say, 'access denied' or 'authorization error'). I tried to implement this once but couldn't because toElasticsearchQueryDSL is not open sourced.

Hi @taneba this should be addressed with the new GraphQL transformer v2. @-mention me if this doesn't address your concerns: https://docs.amplify.aws/cli/migration/transformer-migration/


Tailwindcss not working with esbuild (scss)

Which @angular/* package(s) are the source of the bug?
core, Don't known / other
Is this a regression?
Yes
Description
Creating a new project (standalone) with V16, and installing TailwindCSS, does not seem to work when switching to EsBuild.
Please provide a link to a minimal reproduction of the bug
https://github.com/spock123/angular-tailwind-esbuild.git
Please provide the exception or error you saw
Clone repository, which is a basic new angular application, created with pnpm package manager.
TailwindCSS is then installed and configured.
pnpm install
npm run start

Tailwind classes are applied, both from inline classes and using @apply in the .scss file.
Now change to ESBuild in angular.json
Tailwind classes are no longer applied from the scss file.
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 16.0.3
Node: 18.15.0
Package Manager: pnpm 8.1.0
OS: darwin arm64

Angular: 16.0.0
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1600.3 (cli-only)
@angular-devkit/build-angular   16.0.3
@angular-devkit/core            16.0.3 (cli-only)
@angular-devkit/schematics      16.0.3 (cli-only)
@angular/cli                    16.0.3
@schematics/angular             16.0.3 (cli-only)
rxjs                            7.8.0
typescript                      5.0.2

Anything else?
Updating to ng16.0.5 did not help.

This is a duplicate of #25169 and has been implemented in #25279, which will be available in 16.1.

@JoostK I*m sorry I did not see this. Thank you so much for the update. Cheers


use clarity grammar and docs from clarity repo in code editor

https://github.com/hirosystems/clarity-repl/blob/1282a1e2d5a6d759e0df923f4bb30a13b27ea124/src/clarity/docs/mod.rs
https://github.com/hirosystems/clarinet/blob/develop/components/clarity-vscode/syntaxes/clarity.tmLanguage.json

PR is open for fetching the grammar, code completion is a little more complex.
Discussed w/ @hugocaillard an approach to create a clarity-completion JS package and publish it to NPM, which would include all the CompletionItems usable in Monaco. Will follow up on that in the future.


angle measuring error

please revise:
a   = [angle_vectors_xy(uv[i], _uv[i]) for i in range(len(edges))]
to:
a   = [angle_vectors_xy(uv[i], _uv[i], deg=True) for i in range(len(edges))]
otherwise, flipped edges are not properly accounted for in:
for u, v, attr in form.edges(True):
e = uv_e[(u, v)]
attr['l'] = l[e, 0]
attr['a'] = a[e]
if a[e] < 90:
attr['f'] = _l[e, 0]
attr['q'] = q[e, 0]
else:
attr['f'] = - _l[e, 0]
attr['q'] = - q[e, 0]

solved in 52fa2af


Request for a new feature: Own Cycling Power Estimation by stravistix

Strava is using its own cycling power calculation when no power sensor is used for the activity.
see here: https://support.strava.com/hc/en-us/articles/216917107-How-Strava-Calculates-Power
However, not all parameter can be changed by the user in strava  app (e.g. rolling resistance or wind resistance).  But my experience is, that they do not allways fit very well. For example, when I use my mountain bike only on roads, the strava estimated power is far too high.
So since stravistix has access to the activity raw data, i.e. speed, altitude as function of time of a cycling activity, an own calculation of the estimated power could be implemented. Individual parameters for the calculation could be then changed under stravistix setting.

I agree with Chrisx68.
It would also be more complete if in the calculation weather conditions would have been taken into account. As far as I know weather underground should have API available to retrieve wind speed and direction ,for example


Add DuckDNS

I want to add DuckDNS support so I don't have to run to separate services.
Here's how I want to do it:
I'll create a process to start up automatically with NSSM, I might use a modified C# Updater as the process executable

Well, I just found out that Caddy has a DuckDNS plugin, adding it to my todo list

So I guess this is the caddyfile we will use
example.duckdns.org {
        tls {
                dns duckdns (DuckDNS token)
        }
        reverse_proxy localhost: 8096
}

So here's how this is going to be planed out:
In the Visual Basic code: When it asks for domain & address of the JF server, there will be a third box along the lines of
MSG BOX Input("Do you want to add DuckDNS support")
IF Yes
   PRINT "ENTER DuckDNS token"
   DuckDNStoken ---> INPUT ( )
   WRITETOFILE({Same for the the normal one but with the tls {
                dns duckdns (DuckDNS token)
        }} part)
End IF

Sorry for the Pseudocode it helps me plan things out.

OK so this is nearly implemented, making. Pull request soon. 😁


custom errors not possible?

Steps to reproduce
On the feathers server create a custom error, like the example in the docs and throw it in a hook afterwards
const { FeathersError } = require('@feathersjs/errors');

class UnsupportedMediaType extends FeathersError {
  constructor(message, data) {
    super(message, 'unsupported-media-type', 415, 'UnsupportedMediaType', data);
  }
}

in my hook
throw new UnsupportedMediaType('Not supported');

Actual behavior
On the client side you will have an error:
Not supported at convert (feathers.js?83e6:1571)

where the following line throws an the error, I suppose https://github.com/feathersjs/errors/blob/master/lib/index.js#L240
Expected behavior
Custom Errors should be possible, and correctly parsed
System configuration
Module versions "@feathersjs/errors": "3.3.0"
NodeJS version: v9.5.0
Operating System: mac OSX High Sierra
Browser Version: latest chrome

sorry, my fault, it was a little bit confusing, that FeathersError was showing differently serialized in the console.log, then my custom error, but this is only, because my custom error was transformed, to a real javascript error, and therefore being displayed differently on a console.log...


[fixes #23000] Update the Python SDK harness state cache to be a loading cache

Also record statistics for the cost of performing a load.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @ryanthompson591

Is this still being changed? There were a couple outstanding questions I had, but I think they were simple.  Overall this looked pretty good to me.

Yes, I got sidetracked and was unable to push up the latest changes.

Latest changes up now. Thanks for pinging me.

Had to rebase to resolve conflicts, PTAL