fix is_bare_metal

This makes cross usable with other bare metal targets (e.g. mips, riscv) with a custom image. Without this change, cross will always fallback to host cargo because needs_docker returns false.

Thumb is not necessarily bare metal, it can also be windows/linux/android:
thumbv7a-pc-windows-msvc
thumbv7a-uwp-windows-msvc
thumbv7neon-linux-androideabi
thumbv7neon-unknown-linux-gnueabihf
thumbv7neon-unknown-linux-musleabihf

But thumb bare metal targets are -none-eabi or -none-eabihf.

thanks!
bors r+

bors retry

The error is unrelated to this PR:
#6 [2/2] RUN eval "apt-get update && apt-get install -y libc6 g++-x86-64-linux-gnu libc6-dev-amd64-cross"
#6 8.006 Get:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease [265 kB]
#6 8.527 Get:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease [114 kB]
#6 8.689 Get:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease [108 kB]
#6 8.816 Get:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease [114 kB]
#6 10.65 Get:5 http://ports.ubuntu.com/ubuntu-ports focal/multiverse arm64 Packages [139 kB]
#6 10.94 Get:6 http://ports.ubuntu.com/ubuntu-ports focal/universe arm64 Packages [11.1 MB]
#6 25.76 Get:7 http://ports.ubuntu.com/ubuntu-ports focal/restricted arm64 Packages [1317 B]
#6 25.76 Get:8 http://ports.ubuntu.com/ubuntu-ports focal/main arm64 Packages [1234 kB]
#6 26.69 Get:9 http://ports.ubuntu.com/ubuntu-ports focal-updates/main arm64 Packages [2274 kB]
#6 28.36 Get:10 http://ports.ubuntu.com/ubuntu-ports focal-updates/multiverse arm64 Packages [9072 B]
#6 28.42 Get:11 http://ports.ubuntu.com/ubuntu-ports focal-updates/restricted arm64 Packages [5457 B]
#6 90.35 Ign:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.35 Ign:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.35 Ign:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.35 Ign:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.35 Ign:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.35 Ign:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.35 Ign:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.35 Ign:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.35 Ign:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.35 Ign:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.35 Ign:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.35 Ign:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.35 Ign:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.36 Ign:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.36 Ign:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.36 Ign:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.36 Ign:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.36 Ign:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.36 Ign:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.36 Ign:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.36 Ign:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.36 Ign:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.36 Ign:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.37 Ign:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.37 Ign:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.37 Ign:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.37 Ign:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.37 Ign:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.37 Ign:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.37 Ign:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.37 Ign:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.37 Ign:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.37 Ign:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.37 Ign:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.38 Ign:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.38 Err:12 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 Packages
#6 90.38   Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out [IP: <IP_ADDRESS> 80]
#6 90.38 Err:13 http://ports.ubuntu.com/ubuntu-ports focal-backports/universe arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.38 Err:14 http://ports.ubuntu.com/ubuntu-ports focal-backports/main arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.38 Err:15 http://ports.ubuntu.com/ubuntu-ports focal-security/multiverse arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.38 Err:16 http://ports.ubuntu.com/ubuntu-ports focal-security/main arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.38 Err:17 http://ports.ubuntu.com/ubuntu-ports focal-security/universe arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.38 Err:18 http://ports.ubuntu.com/ubuntu-ports focal-security/restricted arm64 Packages
#6 90.38   Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 90.46 Fetched 15.4 MB in 1min 30s (171 kB/s)
#6 90.46 Reading package lists...
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-updates/universe/binary-arm64/Packages  Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-backports/universe/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-backports/main/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-security/multiverse/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-security/main/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-security/universe/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/focal-security/restricted/binary-arm64/Packages  Unable to connect to ports.ubuntu.com:http: [IP: <IP_ADDRESS> 80]
#6 94.72 W: Some index files failed to download. They have been ignored, or old ones used instead.
#6 95.03 Reading package lists...
#6 99.25 Building dependency tree...
#6 99.78 Reading state information...
#6 99.93 libc6 is already the newest version (2.31-0ubuntu9.9).
#6 99.93 Some packages could not be installed. This may mean that you have
#6 99.93 requested an impossible situation or if you are using the unstable
#6 99.93 distribution that some required packages have not yet been created
#6 99.93 or been moved out of Incoming.
#6 99.93 The following information may help to resolve the situation:
#6 99.93
#6 99.93 The following packages have unmet dependencies:
#6 100.1  g++-x86-64-linux-gnu : Depends: gcc-x86-64-linux-gnu (= 4:9.3.0-1ubuntu2) but it is not going to be installed
#6 100.1                         Depends: g++-9-x86-64-linux-gnu (>= 9.3.0-3~) but it is not going to be installed
#6 100.2 E: Unable to correct problems, you have held broken packages.

I'm unsure why this is happening, I'm able to replicate it locally with
$ cd cross
$ ./ci/test-foreign-toolchain.sh

it seems to work now on a retry, lets hope it persists! Suspecting issues at ports.ubuntu.com
bors retry


When run exe nothing happens

When I run the exe nothing happens I’m on windows  11 using a onexplayer with amd 4800u

When I run the exe nothing happens I’m on windows 11 using a onexplayer with amd 4800u

Same for me using onexplayer  with intel  1195G7

this software is not being supported anymore. find my latest here:
https://github.com/project-sbc/Power-Control-Panel-v2


Typo

I signed it!

Throughout the docs, the term most commonly used is "isolate scope", so I think it's best to leave it as is.
Thx for taking the time to submit a PR, though. Keep them coming :smiley:


Bad synthesis results when reading phone numbers（读取电话号码时合成结果不佳）

Checks

[X] This template is only for usage issues encountered.
[X] I have thoroughly reviewed the project documentation but couldn't find information to solve my problem.
[X] I have searched for existing issues, including closed ones, and couldn't find a solution.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Environment Details
torch                         2.3.0
torchaudio                    2.3.0
Steps to Reproduce
When there is a phone number in gen_text, there is an undesirable pause in the synthesized result, hopefully the phone number should be concatenated.
当 gen_text 中有电话号码的时候，合成结果中会出现不应该有的停顿，希望的是电话号码应该是连起来读的
! python inference-cli.py \
--model "F5-TTS" \
--ref_audio "tests/lyn-f5tts_test.wav" \
--ref_text "那到时候再给你打电话，麻烦你注意接听" \
--gen_text "你好，我这边是XXX的工作人员，请问你的号码是幺幺幺八八八七三三七七吗？" \
--ckpt_file "/home/repository/audio/F5TTS_Base/model_1200000.safetensors" \
--output_dir "tests/lyn_out.wav"

✔ Expected Behavior
Smooth reading of phone numbers
流畅的读电话号码
❌ Actual Behavior
Phone numbers are not synthesized well and there are unwanted pauses
电话号码合成效果不好，会出现不应该有的停顿

Yes, the problem exists. finetuning will help or train with more phone number reading data
the model still lacks these practices.
是的，电话号码模型还不太6，需要在相关数据上再训下微调啥的


Support to create a new file/folder using an inline action

Default features is enough good for creating new files and folder with in the vs code.  But it can still improve. As show in below gif.

This is a fair feature request, however it is not currently on our plan thus assigning to backlog canddiates


bug: I'm trying to get JAN on avx with ERROR AVX2.

Describe the bug
I'm trying to get JAN on avx.
I downloaded nitro-0.3.21-win-amd64-avx-cuda-12-0.tar.gz and extracted it into the jan extender folder.
In log:
2024-05-09T09:41:28.532Z [NITRO]::Debug: Nitro is ready
2024-05-09T09:41:28.533Z [NITRO]::Debug: Loading model with params {"cpu_threads":5,"ctx_len":2048,"prompt_template":"<|system|>\n{system_message}<|user|>\n{prompt}<|assistant|>","llama_model_path":"S:\\JAN\\models\\tinyllama-1.1b\\tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf","system_prompt":"<|system|>\n","user_prompt":"<|user|>\n","ai_prompt":"<|assistant|>","ngl":100}
2024-05-09T09:41:28.542Z [NITRO]::Debug: 94m                            \__\/         \__\/
20240509 09:41:28.323000 UTC 2916 INFO  Nitro version:  - main.cc:50
20240509 09:41:28.324000 UTC 2916 INFO  Server started, listening at: <IP_ADDRESS>:3928 - main.cc:54
20240509 09:41:28.324000 UTC 2916 INFO  Please load your model - main.cc:55
20240509 09:41:28.324000 UTC 2916 INFO  Number of thread is:8 - main.cc:62
20240509 09:41:28.540000 UTC 3768 ERROR AVX2 is not supported by your processor - llamaCPP.cc:546

2024-05-09T09:41:28.551Z [NITRO]::Debug: Load model success with response {}
2024-05-09T09:41:28.555Z [NITRO]::Debug: 20240509 09:41:28.554000 UTC 3508 ERROR Model has not been loaded - llamaCPP.cc:52

2024-05-09T09:41:28.556Z [NITRO]::Debug: Validate model state with response 409
2024-05-09T09:41:28.556Z [NITRO]::Error: Validate model status failed
2024-05-09T09:41:28.556Z [NITRO]::Debug: Validate model state failed with response "Conflict"
2024-05-09T09:41:31.653Z [NITRO]::Debug: Request to kill Nitro

Why i have ERROR AVX2 is not supported by your processor - llamaCPP.cc:546
if i use nitro-0.3.21-win-amd64-avx-cuda-12-0.tar.gz
win10x64/1660super/cudatk12.4

I tried running nitro-0.3.21-win-amd64-avx-cuda-12-0.tar.gz via command line and this is what came out! I don't understand why I'm being asked for AVX2!
λ curl http://localhost:5000/inferences/llamacpp/loadmodel   -H 'Content-Type: application/json'   -d '{"cpu_threads":5,"ctx_len":2048,"prompt_template":"<|system|>\n{system_message}<|user|>\n{prompt}<|assistant|>","llama_model_path":"S:\\JAN\\models\\tinyllama-1.1b\\tinyllama-1.1b-chat-v1.0.Q4_K_M.gguf","system_prompt":"<|system|>\n","user_prompt":"<|user|>\n","ai_prompt":"<|assistant|>","ngl":100}'
{"message":"AVX2 is not supported by your processor, please download and replace the correct Nitro asset version"

Last version nitro-0.3.18-win-amd64-avx-cuda-12-0.tar.gz without avx2 error
but exit
20240509 10:09:47.865000 UTC 9568 INFO  Nitro version:  - main.cc:50
20240509 10:09:47.867000 UTC 9568 INFO  Server started, listening at: <IP_ADDRESS>:5000 - main.cc:54
20240509 10:09:47.867000 UTC 9568 INFO  Please load your model - main.cc:55
20240509 10:09:47.867000 UTC 9568 INFO  Number of thread is:8 - main.cc:62
{"timestamp":1715249390,"level":"INFO","function":"LoadModelImpl","line":646,"message":"system info","n_threads":5,"total_threads":8,"system_info":"AVX = 1 | AVX_VNNI = 0 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | SSSE3 = 0 | VSX = 0 | MATMUL_INT8 = 0 | "}

curl: (56) Recv failure: Connection was reset

Last version nitro-0.3.18-win-amd64-avx-cuda-12-0.tar.gz without avx2 error but exit
20240509 10:09:47.865000 UTC 9568 INFO  Nitro version:  - main.cc:50
20240509 10:09:47.867000 UTC 9568 INFO  Server started, listening at: <IP_ADDRESS>:5000 - main.cc:54
20240509 10:09:47.867000 UTC 9568 INFO  Please load your model - main.cc:55
20240509 10:09:47.867000 UTC 9568 INFO  Number of thread is:8 - main.cc:62
{"timestamp":1715249390,"level":"INFO","function":"LoadModelImpl","line":646,"message":"system info","n_threads":5,"total_threads":8,"system_info":"AVX = 1 | AVX_VNNI = 0 | AVX2 = 1 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | FMA = 1 | NEON = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 0 | SSE3 = 1 | SSSE3 = 0 | VSX = 0 | MATMUL_INT8 = 0 | "}

curl: (56) Recv failure: Connection was reset

Could I get the request body?

This should be address after Jan is migrated to Cortex backend instead of Nitro. @vansangpfiev to double check  and close this issue :)

Follow up here #634


UI main wireframe

Should we use something similar as Discord app?

Butch has provided screenshots and wireframe drawings.


feat: impersonate flow activation/connection

Purpose
Resolves #47. Allows the use of an application user when connecting/activating flows.
Approach
Uses the LicensedUsername runtime setting to impersonate a user that owns the connections and is licensed for flows.
TODOs

[x] Automated test coverage for new code
[ ] Documentation updated (if required)
[x] Build and tests successful

@ewingjm thanks for the contribution. None of your PRs are small...
Don't worry about the 10 code smells, lets discuss that elsewhere since it's not regarding this PR.
A couple of thoughts:

with the move to the new `Execute method, I think some methods have become redundant which should be removed. The code coverage shows this and should improve this to the 80% target.
since there are two uses of trying the given username and falling back to the deployment user, might I be a good idea to add a shared method for that?

Hey, @tdashworth. I think the 10 code smells was due to my change - I added a Fields static class that sat above the individual entity classes for common fields. I wasn't actually using it, so I took it out. I've refactored so that the fallback logic is shared and removed the redundant ExecuteMultiple extension method.
The low code coverage is coming from the CrmServiceAdapter which already has pretty low coverage as we haven't been able to mock CrmServiceClient. It's complaining about the negative testing and error handling, so I think we need a new integration test fixture for CrmServiceAdapter that doesn't rely on deploying the package successfully to test these negative scenarios.

Just updating the README now @tdashworth and should be good to go.


Invalid credentials returning EOF

When we initialize the client with invalid client credentials:
package main

import (
	"fmt"
	"os"
	"repo.incognia.com/go/incognia"
)

func main() {
	client, err := incognia.New(&incognia.IncogniaClientConfig{
		ClientID:     "client-id",
		ClientSecret: "client-secret",
		Region:       incognia.US,
	})
	if err != nil {
		fmt.Println(err.Error())
		os.Exit(0)
	}

	assessment, assessmentError := client.RegisterPayment(&incognia.Payment{
		InstallationID: "installation-id",
		AccountID: "account-id",
	})
	if assessmentError != nil {
		fmt.Println(assessmentError.Error())
		os.Exit(0)
	}
	fmt.Println(assessment.RiskAssessment)
}

The error returned by calling the RegisterPayment method is simply EOF. This can make debugging a little bit trickier on our client's side, and I think it would be nice if we could return a more informative message.

Solved https://github.com/inloco/incognia-go/pull/24


Add 0000-01-02-misoormoon.md

created a branch, created a file and made a commit, and opened a pull request


Add a current monitor function for window mode windows.

This PR adds logic to compute the current monitor for non-full screen windows. The monitor that contains the upper left origin is returned.

@JeffM2501 Great! Thanks for the review!


Doc example RequestAuthentication not working

Bug description
Example of path based RequestAuthentication from the docs (last example) is not working. I still get a 403 for /healthz
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Select a workload via label and except some paths from RequestAuthentication e.g. we have some paths on our ingress gateway which provide a opaque Access Token e.g. Authorization: Bearer dsf5sd7f6d7fsdjkfh which needs to be except from token verification.
Steps to reproduce the bug
Follow the docs
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
istioctl version --remote
client version: 1.7.3
control plane version: 1.7.0
data plane version: 1.7.0 (1 proxies)`
kubectl version --short
Client Version: v1.18.6
Server Version: v1.18.6

How was Istio installed?
Istio Operator
Environment where bug was observed (cloud vendor, OS, etc)
OnPrem Cluster
Additionally, please consider attaching a cluster state archive by attaching the dump file to this issue.

I see the same issues using a keycloak server as the provider.
apiVersion: "security.istio.io/v1beta1"
kind: "RequestAuthentication"
metadata:
  name: "keycloak-authentication"
  namespace: istio-system
spec:
  selector:
    matchLabels:
      istio: ingressgateway
  jwtRules:
  - issuer: "http://keycloak:8080/auth/realms/istio"
    jwksUri: "http://keycloak:8080/auth/realms/istio/protocol/openid-connect/certs"

I access directly through the IP of the workload, request authentication is valid.
But I access directly through the endpoint of the istio-ingressgateway, request authentication is useless.
The reason may be that the gateway connection to the payload fails to match the filterchain or the filterchain ends before matching the JWT chain
I want to know how to solve it


test: HACBS-1132-Based-on-the-e2e-test-happy-path-Add-releasePlan-and-ReleasePlanAdmissions

HACBS-1132-Based-on-the-e2e-test-happy-path-Add-releasePlan-and-ReleasePlanAdmissions
Description
Added ReleasePlan, ReleasePlanAdmission and supported functions to make the happy-tests test follow-up
Issue ticket number and link
https://issues.redhat.com/browse/HACBS-1132
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have updated labels (if needed)

/assign @johnbieren

Just recreated a new forked branch and PR
Rebase succeeded
Added Added ReleasePlan, ReleasePlanAdmission and supported functions to make the happy-tests test follow-up
Besides ReleasePlan, ReleasePlanAdmission and supported functions , I updated CreateReleaseStrategy, CreateRelease
Also added happy-path in a new release.go test file to support testing the ReleasePlan, ReleasePlanAdmission and supported functions as they support the happy-path test

/retest

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/retest

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/retest

/retest

Hi @johnbieren
Have replaced release.go file with test_snippets.go file with same code

Hi @johnbieren Have replaced release.go file with test_snippets.go file with same code

I see all you did was rename the test file. My suggestion was to use the functions you add here https://github.com/redhat-appstudio/e2e-tests/pull/200/files
So like import them or call them directly, whatever, so that lines like
				Expect(err).NotTo(HaveOccurred(), "Error when creating namespace '%s': %v", managedNamespace, err)

are in just one file, not two

Hi @johnbieren

The functions you mentioned are defined in framework.CommonController (CreateTestNamespace, DeleteNamespace)
Let's talk to sync

Hi @johnbieren
The functions you mentioned are defined in framework.CommonController (CreateTestNamespace, DeleteNamespace) Let's talk to sync

The only benefit I see to those test_snippet functions is to be able to call them in other tests, like defined in this PR. If we cannot do that, I don't know why they were added in the other PR

/retest

/retest

/cc @jkopriva

/retest

/retest

/cc @johnbieren
Hi Johnny, please recheck the PR

Hi @naftalysh  ,
the CI configuration in main branch of e2e-tests repository was recently updated and it no longer uses pre-kcp branch of infra-deployments for bootstrapping appstudio on OCP cluster. Now it uses main branch, which leverages kcp.
Since appstudio/hacbs services are not fully integrated with kcp yet, lots of tests implemented in this repo can't be run successfully against it.
To address this, a branch "pre-kcp" was created in e2e-tests repo and can be used for adding/updating tests that can be run against "pre-kcp" version of appstudio.
Once we are able to run e2e tests for all appstudio/hacbs services successfully, the plan is to merge back all changes done in pre-kcp branch back to main.
If your PR is intended to update test used for "pre-kcp" version of appstudio, please update the base branch in your PR like this:

Thanks!

/cc @johnbieren Hi Johnny, please recheck the PR

@naftalysh we already met and all decided that this PR would not be updated or reviewed until after @kasemAlem 's PR is merged. Why are you asking me to check it again?

@naftalysh @kasemAlem any update on this PR? It has gotten a lot of reviews and it has been siting here for while. Is it still valid? If so, lets get it merged?


httpcore.ConnectError: [Errno 61] Connection refused

After running through the instructions here I receive the following error while querying via the UI:
2024-08-05 09:51:11.750 Uncaught app exception
Traceback (most recent call last):
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpx/_transports/default.py", line 69, in map_httpcore_exceptions
    yield
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpx/_transports/default.py", line 233, in handle_request
    resp = self._pool.handle_request(req)
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_sync/connection_pool.py", line 216, in handle_request
    raise exc from None
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_sync/connection_pool.py", line 196, in handle_request
    response = connection.handle_request(
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_sync/connection.py", line 99, in handle_request
    raise exc
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_sync/connection.py", line 76, in handle_request
    stream = self._connect(request)
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_sync/connection.py", line 122, in _connect
    stream = self._network_backend.connect_tcp(**kwargs)
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_backends/sync.py", line 213, in connect_tcp
    sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/contextlib.py", line 135, in __exit__
    self.gen.throw(type, value, traceback)
  File "/Users/dpeck/Library/Python/3.9/lib/python/site-packages/httpcore/_exceptions.py", line 14, in map_exceptions
    raise to_exc(exc) from exc
httpcore.ConnectError: [Errno 61] Connection refused

Did you do?
ollama run llama3.1
It makes sure that the model is running on your local machine.


Qt 4 does not support ECMA5-compatible Function.prototype.apply

When using Javascript against Qt 4.x Function.prototype.apply does not work correctly with array-like arguments (tested with Qt: 4.8.7 / WebKit: 534.34 / QtWebKit: 2.2.4)
This can result in seeing the JS error message:
"TypeError: '[object Object]' is not a valid argument for 'Function.prototype.apply'"
This is fixed in Qt 5.x.
While this is not a capybara-webkit bug, I wanted to document the issue here in case other people see the same issue against Qt 4.x since 4.x is currently still the default Qt installation on Mac homebrew.
This is the same issue described in https://bugs.webkit.org/show_bug.cgi?id=109307

Closing since this is fixed in Qt 5.x


Speed up RTS database startup

As discussed in meeting today; Investigate why acton programs take so long to start up with the database backend.
For example, try the simple count program we have: https://github.com/actonlang/acton/blob/main/examples/count.act
A description for how to run the database and program is in the header of that file!
The slow function is remote_read_full_table_in_txn at https://github.com/actonlang/acton/blob/main/rts/rts.c#L1329
Why is it slow on an empty (just started) system?
Why is it slow for a small system, like when we just have a single actor, shouldn't this run in "no time at all"?

@aagapi I think we briefly talked about this but I don't we reached a conclusion. Did you look into why this is taking so long?

Somewhat interestingly, it seems it can take "0 seconds". We have seen this when running CI tests in GitHub Actions. Locally on my machine though, there is always a 2-3 second delay.
For example in https://github.com/actonlang/acton/runs/4775624746?check_suite_focus=true we see:
-- Round 1
make[3]: Entering directory '/__w/acton/acton/test'
../dist/bin/actonc --cpedantic --root main test_db_app.act
Tue Jan 11 13:10:43 UTC 2022
pkill actondb
make[3]: [Makefile:38: test_db_one] Error 1 (ignored)
../dist/bin/actondb -p 32000 -m 34000 -s <IP_ADDRESS>:34000 >db1.log 2>&1 &
./test_db_app --rts-verbose --rts-ddb-host <IP_ADDRESS> --rts-ddb-replication 1
**RTS** Detected 2 CPUs: Using 4 worker threads, due to low CPU count. No CPU affinity used.
**RTS** Using distributed database backend replication factor of 1
**RTS** Using distributed database backend (DDB): <IP_ADDRESS>:32000
**RTS** Checking for existing actor state in DDB... **RTS** done
**RTS** No previous state in DDB; Initializing database...**RTS** done
Creating Foo() instance<PHONE_NUMBER>
Scheduling after 0<PHONE_NUMBER>
Calling cb_method()<PHONE_NUMBER>
In final method, exiting...<PHONE_NUMBER>
pkill actondb
Tue Jan 11 13:10:43 UTC 2022
make[3]: Leaving directory '/__w/acton/acton/test'

Note the timestamp at the start and end, which are both Tue Jan 11 13:10:43 UTC 2022, thus this whole test runs under 1 second.

@aagapi I'm pretty sure it is this select that is taking time: https://github.com/actonlang/acton/blob/main/backend/client_api.c#L199
Here's a normal run of the test:
kll@Boxy:~/terastream/acton/test$ time make test_db_app
../dist/bin/actonc --cpedantic --root main test_db_app.act
./test_db.py --db-nodes 3 --test-app
2022-01-26 22:02:19,169: test_db    INFO     -- Round 0
2022-01-26 22:02:19,170: test_db    DEBUG    Starting database servers
2022-01-26 22:02:19,172: test_db    DEBUG    Starting instance 1
2022-01-26 22:02:19,175: test_db    DEBUG    Using Membership info from Db0 as expected
2022-01-26 22:02:19,175: test_db    DEBUG    Membership info for Db1 is as expected
2022-01-26 22:02:19,175: test_db    DEBUG    Starting instance 2
2022-01-26 22:02:19,177: test_db    DEBUG    Using Membership info from Db0 as expected
2022-01-26 22:02:19,177: test_db    DEBUG    Membership info for Db1 is as expected
2022-01-26 22:02:19,177: test_db    DEBUG    Membership info for Db2 is as expected
2022-01-26 22:02:19,177: test_db    DEBUG    Starting application: ./test_db_app --rts-verbose --rts-ddb-replication 3 --rts-ddb-host <IP_ADDRESS>:32000 --rts-ddb-host <IP_ADDRESS>:32001 --rts-ddb-host <IP_ADDRESS>:32002
2022-01-26 22:02:19,178: test_db    INFO     App output: #RTS# Detected 32 CPUs: Using 32 worker threads for 1:1 mapping with CPU affinity set.
2022-01-26 22:02:19,178: test_db    INFO     App output: #RTS# Using distributed database backend replication factor of 3
2022-01-26 22:02:19,178: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32000
2022-01-26 22:02:22,182: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32001
2022-01-26 22:02:22,182: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32002
2022-01-26 22:02:22,182: test_db    INFO     App output: #RTS# Checking for existing actor state in DDB.
2022-01-26 22:02:22,182: test_db    INFO     App output: #RTS# No previous state in DDB; Initializing database...
2022-01-26 22:02:22,182: test_db    INFO     App output: #RTS# Database intialization complete.
2022-01-26 22:02:22,182: test_db    INFO     App output: Creating Foo() instance
2022-01-26 22:02:22,183: test_db    INFO     App output: Scheduling after 0
2022-01-26 22:02:22,184: test_db    INFO     App output: Calling cb_method()
2022-01-26 22:02:22,186: test_db    INFO     App output: In final method
2022-01-26 22:02:22,204: test_db    INFO     App output: exiting...
2022-01-26 22:02:22,204: test_db    INFO     App stderr:
2022-01-26 22:02:22,204: test_db    INFO     End of process...
2022-01-26 22:02:22,204: test_db    INFO     p.communicate():
2022-01-26 22:02:22,204: test_db    DEBUG    application exited successfully
2022-01-26 22:02:22,205: test_db    DEBUG    Stopping database servers

real	0m3.270s
user	0m0.218s
sys	0m0.070s

and then I tried modifying the timeout that the select() uses to 4 seconds and I get:
./test_db.py --db-nodes 3 --test-app
2022-01-26 22:03:25,801: test_db    INFO     -- Round 0
2022-01-26 22:03:25,801: test_db    DEBUG    Starting database servers
2022-01-26 22:03:25,804: test_db    DEBUG    Starting instance 1
2022-01-26 22:03:25,807: test_db    DEBUG    Using Membership info from Db0 as expected
2022-01-26 22:03:25,807: test_db    DEBUG    Membership info for Db1 is as expected
2022-01-26 22:03:25,807: test_db    DEBUG    Starting instance 2
2022-01-26 22:03:25,810: test_db    DEBUG    Using Membership info from Db0 as expected
2022-01-26 22:03:25,810: test_db    DEBUG    Membership info for Db1 is as expected
2022-01-26 22:03:25,810: test_db    DEBUG    Membership info for Db2 is as expected
2022-01-26 22:03:25,810: test_db    DEBUG    Starting application: ./test_db_app --rts-verbose --rts-ddb-replication 3 --rts-ddb-host <IP_ADDRESS>:32000 --rts-ddb-host <IP_ADDRESS>:32001 --rts-ddb-host <IP_ADDRESS>:32002
2022-01-26 22:03:25,811: test_db    INFO     App output: #RTS# Detected 32 CPUs: Using 32 worker threads for 1:1 mapping with CPU affinity set.
2022-01-26 22:03:25,811: test_db    INFO     App output: #RTS# Using distributed database backend replication factor of 3
2022-01-26 22:03:25,811: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32000
2022-01-26 22:03:25,811: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32001
2022-01-26 22:03:25,811: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32002
2022-01-26 22:03:29,816: test_db    INFO     App output: #RTS# Checking for existing actor state in DDB.
2022-01-26 22:03:29,816: test_db    INFO     App output: #RTS# No previous state in DDB; Initializing database...
2022-01-26 22:03:29,817: test_db    INFO     App output: #RTS# Database intialization complete.
2022-01-26 22:03:29,817: test_db    INFO     App output: Creating Foo() instance
2022-01-26 22:03:29,817: test_db    INFO     App output: Scheduling after 0
2022-01-26 22:03:29,818: test_db    INFO     App output: Calling cb_method()
2022-01-26 22:03:29,819: test_db    INFO     App output: In final method
2022-01-26 22:03:29,838: test_db    INFO     App output: exiting...
2022-01-26 22:03:29,838: test_db    INFO     App stderr:
2022-01-26 22:03:29,839: test_db    INFO     End of process...
2022-01-26 22:03:29,839: test_db    INFO     p.communicate():
2022-01-26 22:03:29,839: test_db    DEBUG    application exited successfully
2022-01-26 22:03:29,839: test_db    DEBUG    Stopping database servers

real	0m4.300s
user	0m0.243s
sys	0m0.077s
kll@Boxy:~/terastream/acton/test$

so is the select missing to select on some FD so we miss the event that should wake it up?

Ah yes, I'm pretty sure this happens before we have connected to the DB nodes. From rts.c
    if (ddb_host) {
        GET_RANDSEED(&seed, 0);
        rtsv_printf(LOGPFX "Using distributed database backend replication factor of %d\n", ddb_replication);
        db = get_remote_db(ddb_replication);
        for (int i=0; i<ddb_no_host; i++) {
            char *host = strdup(ddb_host[i]);

            int port = ddb_port;
            char *colon = strchr(host, ':');
            if (colon) {
                *colon = '\0';
                port = atoi(colon + 1);
            }

            rtsv_printf(LOGPFX "Using distributed database backend (DDB): %s:%d\n", host, port);
            add_server_to_membership(host, port, db, &seed);
        }
    }

And checking against a log with some more printfs:
2022-01-26 22:21:32,686: test_db    INFO     App output: #RTS# Using distributed database backend replication factor of 3
2022-01-26 22:21:32,686: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32000
2022-01-26 22:21:32,686: test_db    INFO     App output: BEFORE SELECT...
2022-01-26 22:21:32,686: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32001
2022-01-26 22:21:32,686: test_db    INFO     App output: #RTS# Using distributed database backend (DDB): <IP_ADDRESS>:32002
2022-01-26 22:21:32,686: test_db    INFO     App output: #RTS# Checking for existing actor state in DDB.
2022-01-26 22:21:36,686: test_db    INFO     App output: AFTER SELECT...
2022-01-26 22:21:36,686: test_db    INFO     App output: Listening to server socket <IP_ADDRESS>:32000..
2022-01-26 22:21:36,686: test_db    INFO     App output: Listening to server socket <IP_ADDRESS>:32001..
2022-01-26 22:21:36,686: test_db    INFO     App output: Listening to server socket <IP_ADDRESS>:32002..
2022-01-26 22:21:36,686: test_db    INFO     App output: BEFORE SELECT...

There's a commented "Listening to server socket..." printf in client_api.c. I uncommented it and as we can see, on the first select() iteration, there are no "listening" messages at all, so we are not selecting on any FDs at all, just waiting for the timeout.
I'm guessing we simply haven't connected yet? the RTS does say "Using distributed database backend", after which it calls adds_server_to_membership. I guess the select fires before the FD is added to the readset.
Can we have a wakeup pipe? That way we can always signal the comm thread if something interesting is happening. That's what we have in the RTS already...


Issue#1 - Add filtering by process id or thread id

Added support for event filtering using --where verb, example:
--kernel Process --event --where ProcessName=""
--kernel Process --event --where ThreadId=""
--kernel Process --event --where ProcessId=""
However, the filters doesn't depend one on another, for exmple:
--kernel Process --event --where ProcessId="" ThreadId=""
will generate the same output as
--kernel Process --event --where ProcessId=""

Because it will match ProcessId is both filters.

Does this functionality required?

Are the quotes required? I.e. can I do --where ProcessId=4428? Regarding whether filters are any-of or all-of, let's stay with the current functionality, but it can be a potentially interesting addition.

Also would be nice to add an example showing the new functionality (e.g. filtering by process name).

Quotes not required --where ProcessId=4428 is identical to --where ProcessId="4428" (+examples added)


[apis/Google.Cloud.Bigtable.V2] Update bigtable grpc service config

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/1f7f8215-6857-4413-889f-ac6970a3dcbc/targets
PiperOrigin-RevId: 312479172
Source-Link: https://github.com/googleapis/googleapis/commit/cdf59a76184d5ddc24531f41567cf2411ae74593

I'll ask about whether these should affect the manual layer as well.


cannot find npm module when running npm install in monterey

for some reason when running the npm install feature in monterey it can't find the npm module ( Cannot find module 'npm')

Problem
We use electron-remote to execute commands which spins up a different process and therefore does not block the UI.
let myCommands = requireTaskPool('./my-commands');
myCommands.doSomethingCPUIntensive();

where requireTaskPool is a function from electron-remote.
Inside my-commands.js we used const npm = require('npm') which resulted in the cannot find npm module error. After reading the docs of electron-remote there seems to be a better require instance to use in files that are called by requireTaskPool.
after changing const npm = require('npm') to const npm = require('electron').remote.require('npm'); it worked fine again


CLOUDP-167803: Migrate containers store & unit tests to v2 client

Proposed changes

Migrate containers store to v2 client.
Jira ticket: CLOUDP-167803

Checklist

[x] I have signed the MongoDB CLA
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
[ ] I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
[ ] I have updated test/README.md (if an e2e test has been added)
[x] I have run make fmt and formatted my code

Further comments

Needs rebase


MistralCausalLMPreprocessor.from_preset docs mistakenly refer to BERT

https://keras.io/keras_hub/api/models/mistral/mistral_causal_lm_preprocessor/#:~:text=a built-in,BertTextClassifierPreprocessor.from_preset().

It appears this way because it's picking up the docstring from the base class.
https://github.com/keras-team/keras-hub/blob/5180e785fe477ede2b085cdd3c08c53b2832f08d/keras_hub/src/models/preprocessor.py#L145-L148
It's not reasonable to customize this docstring for each class just to change the model name.


Add PolyTruncateComposite

Closes #412

Codecov Report

Merging #421 into master will increase coverage by 0.14%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   93.14%   93.28%   +0.14%
==========================================
  Files          44       44
  Lines        2887     2904      +17
==========================================
+ Hits         2689     2709      +20
+ Misses        198      195       -3

Impacted Files
Coverage Δ

dimod/testing/asserts.py
96.87% <ø> (-0.04%)
:arrow_down:

...imod/reference/composites/higherordercomposites.py
93.8% <94.73%> (+5.38%)
:arrow_up:

dimod/serialization/json.py
94.39% <0%> (-0.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbbac73...49b3e9f. Read the comment docs.


Define template for recording bags of markers

Based on pattern used in
Tan, Shawn Zheng Kai, Huseyin Kir, Brian D. Aevermann, Tom Gillespie, Nomi Harris, Michael J. Hawrylycz, Nikolas L. Jorstad, et al. 2023. “Brain Data Standards - A Method for Building Data-Driven Cell-Type Ontologies.” Scientific Data 10 (1): 50. https://doi.org/10.1038/s41597-022-01886-2.
Needs slot for species context.
Also see PCL for example.
Can probably be done in ROBOT, but also easy to use DOSDP.

I would also like to have a template for this.  But I would also like to make a distinction between a "bag of markers" and a set of markers that can serve as the necessary and sufficient axioms for defining a cell type class.

@scheuerm @dosumis Richard, I believe David's "bag of markers" is his jargon that means the same thing.
I agree with you that I prefer this nomenclature to be explicitly stated as "a set of markers that can serve as the necessary and sufficient axioms for defining a cell type class."

@scheuerm - agree we need to maker those we believe to be necessary and sufficient, but we also need to be careful about the use of OWL:EquivalentTo here - which is the strict logical way to assert necessary and sufficient conditions.  In PCL, even with NS-Forest we ended up with incorrect automated classification of some rare cell types  - IIRC this was because the NS-Forest algorithm was working on confidence of classification of single cells across a population.   So - we may want a less formal way to assert this.

@dosumis yes, we just modified/modularized the NS-Forest code so that we can provide any set of markers along with a clustered cell x gene expression matrix and quantify classification performance.  I've attached a comparison between NS-Forest marker performance on the performance using the markers reported in the Sikkema et al. paper for the HLCA lung atlas.  The NS-Forest markers dramatically outperform the Sikkema markers for many of the clusters.

Existing BDSO template:
https://github.com/obophenotype/brain_data_standards_ontologies/blob/master/src/patterns/dosdp-patterns/taxonomy_marker_set.yaml
Example input TSV:
https://github.com/obophenotype/brain_data_standards_ontologies/blob/master/src/patterns/data/default/CCN201912131_marker_set.tsv
This template already groups markers and records confidence and provenance. We need to add species and tissue context.

TODO:
[ ] Pull across template to CL branch
[ ] Make draft modifications for review - including adding context for species and tissue.

https://github.com/obophenotype/cell-ontology/issues/2397 is overlapping this ticket.


New Element Should Be Enabled/Disabled keywords

Originally submitted to Google Code by @pekkaklarck on 7 Jan 2011

Selenium API has is_editable method for verifying is an input element enabled or disabled. This functionality should be exposed in the library.
We need to test does the method work only with elements created with <input> tag or are <button>:s also supported.

Originally submitted to Google Code by @jrantanen on 16 Jan 2011

Implementation and tests in Revision 1c4a455b56.

Originally submitted to Google Code by @pekkaklarck on 16 Jan 2011

There's no tests for buttons other than <input type="submit"> yet. I'm pretty sure also <input type="button"> works if other <input>s work, but <button disabled="disabled">Text</button> should be tested separately.
There are also many other <input> types that aren't tested, but as I wrote above I'm pretty sure all they work if other <input>s work. For a full list of different types see e.g. http://www.w3schools.com/TAGS/att_input_type.asp

Originally submitted to Google Code by @jrantanen on 17 Jan 2011

Added tests for <button> and also <input> when there is readonly attribute used. Updated documentation and changed keyword names to "Element Should Be Enabled/Disabled". See Revision 7964d1dad9.

Originally submitted to Google Code by suram.sr... on 14 Mar 2014

Hi Team,
In my project we have a div or link elements where those will be in disabled/enabled mode. Where i am using the code as
Run Keyword And Return Status  Element Should Be Enabled  //table[@id='viewUsers']/tbody/tr[${i}]/td[9]/div/div/a
It is always throwing the error.
Please let know is this "Element Should Be Enabled" keyword is applicable for Buttons only? or all elements?


Broken links in docs

Now we're hosting our own docs there are a few broken links due to it being at https://materializecss.github.io/materialize/ instead of https://materializecss.github.io/ (The easiest examples are the "get started" button and clicking on the materialize logo). I'm happy to open a PR to fix these or we could make a few changes (I'll open a PR for this too) and move it over. Third option: we get a custom domain which also would solve this.

I'm also happy to change the build script to publish at https://materializecss.github.io/ but that would require making another repo.


Support question, possible to implement master on embedded system, i.e. not on Linux

Hi,
I have a question, what are the steps to perform to run the CANopen master on an embedded CPU (STM32 in my case). Is that easily feasible: has somebody realized that before?
We have 4 STM32 based processor boards of which one should act as the CANopen master node. We have requirements on having LSS, futher some low speed request responses between the master and slave nodes (all initiated by the master), without any realtime or throughput requirements. Further the required messages sized are small (<= 8 bytes) .
Br
Carl.

Hi,
I don't use the LSS features but i'm always using one of my embedded nodes
as a master, when used with my own nodes and other 3rd party can nodes.
Think i've been up to about 30 nodes on the biggest systems. In the
simplest terms to get it to work every time the process i always follow is
:-

Set all slave nodes to start in pre-operational mode, and save this to
their eeprom or how ever you set them up
Switch on the system. in the master node you may need a delay here to
allow time for every slave to boot
From the master send a NMT_CommunicationsReset() (you may need to be
careful you don't catch this signal on the master as well and reset
yourself!)

Send a NMT_Start() to all nodes

This procedure will ensure all PDOs are only sent when the NMT_Start is
issued so everything is synchronized at start up. The above is very simple
to be implemented on embedded system, just ensure the master bit on object
0x1F80 is set in the object dictionary and if using the EDS editor this
will ensure the NMT_MASTER functions are available to send the
communications reset/start bus etc,. Failing to do the CommunicationsReset
will result in possibly unpleasant error messages related to Bus Off / TX
Passive so if you also monitor emergency messages, this is a signal to
clear everything after the typically unclean cold boot where there is
always one node who sees a passive bus as they won the power on race
first.
There are a number of other choices for the startup where you may wish to
ping each node via SDO to ensure its alive before issuing the NMT_Start()
or you may wish to start certain nodes before others, but if you do this be
very careful of who is sending and listening to PDOs as you could miss the
initial messages which may or may not affect your system.
LSS is just an earlier stage in the boot sequence, but i've never even
tried to use that bit so can offer no advice on that.
Robin
On Wed, 3 Feb 2021 at 18:59, Carl<EMAIL_ADDRESS>wrote:

Hi,
I have a question, what are the steps to perform to run the CANopen master
on an embedded CPU (STM32 in my case). Is that easily feasible: has
somebody realized that before?
We have 4 STM32 based processor boards of which one should act as the
CANopen master node. We have requirements on having LSS, futher some low
speed request responses between the master and slave nodes (all initiated
by the master), without any realtime or throughput requirements. Further
the required messages sized are small (<= 8 bytes) .
Br
Carl.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CANopenNode/CANopenNode/issues/264, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG2GGJRP5DOPU5CNSFQM3S5GJKVANCNFSM4XBKK6QA
.

Hi Robin,
thanks for your valuable input,
Br
Carl

There is 309/CO_gateway_ascii, which should work on microcontroller with ascii interface. This could be used for rich service access with LSS, NMT, SDO, etc., as described in gettingStarted.md or LSSusage.md.
Othervise modules can be used separately LSS master, NMT master (quite simple) or SDO master (old example for blocking usage is here: https://github.com/CANopenNode/CANopenSocket/blob/7b8b45fcd2e2d6fa5a9a55d8f3aa8b54ce81a98b/canopend/src/CO_master.c)


Noble for Node.js >=10

Since Noble appears to be abandoned, switched the Noble reference to @abandonware/noble in order to support Node.js >= 10.0.0

@churchs19 Thanks for the PR. @abandonware/noble is already including the native macos binding see https://github.com/abandonware/noble/pull/8 so there is no point to switch to @abandonware/noble


Fix Es::SUB_ONE_GROUPING translations

Some of the translations were wrong (e.g. 'veinte- tres' should be 'veintitres', or 'uno ciento diecisiete' should be 'ciento diecisiete').

Thank you!

Glad I could help. Could we please have a gem release of 2.4.2?
Thanks in advance.

Done.


BigTable asynchronous row handling

Is there a way to asynchronously handle rows with a BigTable range query? What I'm trying to do is something like this:
table.getRows().on('data', async row => {
  await doSomeExpensiveWork(row);
});

What about something like this?
table.getRows()
  .pipe(through.obj((row, _, next) => {
    doSomeExpensiveWork()
      .then(() => next(null), next);
  });

Yep, that's what I would say. It will not pull more data from the stream until you're done processing the last result.
In case users of other APIs see this, this will work for any object stream from our APIs.


[SMALLFIX] Update YARN to work with new tarball format

This updates the YARN integration to work with our new distribution tarball format.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18964/
Test PASSed.

@aaudiber Thanks for fixing this!


25 update readme

In general I like this .. I will try it out right away

Ok, I will add LICENSE.md and CONTRIUTING.md ...
in parallel I just followed the commands on my laptop .. it is currently building...
I would say, once the build is done .. I will execute the commands in "Deployment" to be sure they work ... and then we can merge ... ok? might take ... say 2hours.


SvelteKit 2 Warning - Svelte Field

Since upgrading to SvelteKit 2, I get this error:
8:53:29 PM [vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no
exports condition for svelte.

<EMAIL_ADDRESS>
Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.

You have specified a baseUrl and/or paths in your tsconfig.json which interferes with SvelteKit's auto-generated
 tsconfig.json. Remove it to avoid problems with intellisense. For path aliases, use `kit.alias` instead:
https://kit.svelte.dev/docs/configuration#alias

J

Does the problem still persist?


Add slack, forum, and twitter buttons

Add links to sites including Slack, Twitter, and OMP Forum. Addresses zowe/docs-site#863
Preview:

Closing to reopen with DCO addressed.


Forms within a modal don't work properly

Try putting this in a modal:
<form action="/">
  <label for="test">Test</label>
  <input type="text" name="test" id="test" required>
  <button type="submit">Submit</button>
</form>

There are a couple problems that occur due to the fact that event.preventDefault() is in the onClick handler:

Clicking the label does nothing (it should move the focus to the input).
The form cannot be submitted. You can easily test this by simply leaving the field blank and clicking the "Submit" button. You'll see that nothing happens. I would expect the browser's built-in functionality to kick in and notify you that you left the field blank.

Thanks for submitting this issue. Will look into it.

Closed in #22

#22 does not fix the case where you would open a new tab based on form data.
<form target="_blank" ...>
    <button data-micromodal-close/>
</form>

You can close the modal but the form won't submit.
@ghosh Whats the motivation to call preventDefault() anyway?


Pull recent updates

Some small fixes while I work on migrating this website to the other repo.
Also one point of confusion: the use case text for Arkisto, WfExS, and WorkflowHub seems to have changed, but I can't figure out when or where this happened (can't find it in the commit history). @a-mile @nsjuty or @stain which version should be used?
Arkisto: original new
WfExS: original new
[edited to add] WorkflowHub original new

Think we can keep the new text in ro-2024 - don't see any update as such


Refactor JTreeRenderer

Refactor JTreeRenderer class to see the feasibility of adding the class inside the NavigationPane class

ok ! i wana work with issue first.  please can you explain the task ?

The JTreeRender class overrides swing default cell renderer to show the correct name since an object is being sent to the tree view component. I was thinking of adding this class inside of the navigation pane class. I am not completely positive it will work, but I think it will make the code a bit cleaner

ok. Is there any document to understand the project well? Because I am an beginner - intermediate java developer .

Unfortunately, I haven't yet created a lot of documentation for this project yet. It was just started in the last few days. The quick run down of how everything works:

On the first run, when the config.json has true set for firstRun. The System will create the database, and books, and chapters tables and installs the KJV bible.

The Data Structure:  -   Bible Table is a list of the bibles installed contains version, year, language, copyright info

Books contains all the books
Chapters are chapters 1- 150
Verses is the verse number and verse text
BibleLinks - is the linking table the links the Bible, book, chapter, and verse

The reader pane displays the select book by chapter, is uses an HTML document to load in a JScrollPane.

The navigation pane lists all the books and chapters when a chapter is clicked it passes the book chapter to the application then to the reader pane to display the page.

I know it is kinda a lot of information, but I hope that gives an idea of how it is constructed.

ok . let me go thorough the project thoroughly . If i need to know to anything i will ask you . For today bye. Good night

i have pushed the solution in the new branch. please check and let me know is it working fine or not. If anything need to change

Looks great, Thank you!!

welcome


Add Emanuale Giaquinta as repo maintainer

@exg please let me know if you'd like me to add your email as well.

@exg please let me know if you'd like me to add your email as well.

It is fine as is, thanks. BTW, there is a typo in my first name in the commit message :)

@exg please let me know if you'd like me to add your email as well.

It is fine as is, thanks. BTW, there is a typo in my first name in the commit message :)

Sorry about it, lmk if it's okay now and approve if I can merge


Error when using Dict[str, Any] as type in dataclass

I'm getting an error when trying to use Dict[str, Any] as a type in a dataclass, see example below.
from dataclasses import dataclass
from dataclasses_jsonschema import JsonSchemaMixin
from typing import Dict, Any

@dataclass
class Feature(JsonSchemaMixin):
    id: int
    properties: Dict[str, Any]
    geometry: Dict[str, Any]

feature = Feature(
    id=1,
    properties={"a": 1, "b": "xyz"},
    geometry={"type": "Point", "coordinates": [1.2, 3.4]}
)

# round-trip
assert feature.to_dict() == Feature.from_dict(feature.to_dict()).to_dict()

The exception is:
/home/snorf/.local/share/virtualenvs/my-project-cQlQitVM/lib/python3.6/site-packages/dataclasses_jsonschema.py:219: UserWarning: Unable to create schema for 'None'
  warnings.warn(f"Unable to create schema for '{field_type_name}'")
Traceback (most recent call last):
  File "bug.py", line 20, in <module>
    assert feature.to_dict() == Feature.from_dict(feature.to_dict()).to_dict()
  File "/home/snorf/.local/share/virtualenvs/my-project-cQlQitVM/lib/python3.6/site-packages/dataclasses_jsonschema.py", line 171, in from_dict
    schema_validate(data, cls.json_schema())
  File "/home/snorf/.local/share/virtualenvs/my-project-cQlQitVM/lib/python3.6/site-packages/jsonschema/validators.py", line 541, in validate
    cls(schema, *args, **kwargs).validate(instance)
  File "/home/snorf/.local/share/virtualenvs/my-project-cQlQitVM/lib/python3.6/site-packages/jsonschema/validators.py", line 130, in validate
    raise error
jsonschema.exceptions.ValidationError: 'xyz' is not of type 'object'

Failed validating 'type' in schema['properties']['properties']['additionalProperties']:
    {'type': 'object'}

On instance['properties']['b']:
    'xyz'

Tested on Python 3.6 on Linux.

Perhaps this is related to lack of support for Union?


Allow JavaScript Code Hints only in its context

Fixes a regression I made in #11245 where JavaScript code hints were globally available in a PHP document. This will make sure they are only available inside script tags.

Looks good. Merging.


The set-output command is deprecated and will be disabled soon.

Hi!
There is currently a warning produced by this action:
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Any plans to fix this issue?
(If the action indeed eventually stops working, I'll be happy to try to fix it myself, but right now I sadly don't really have the time to learn the ins and outs of the actions api)

Awesome, thank you!

Confirmed. The warning is gone with the new version. Thank you!


description of Gene trees has a wrong URL for one of the linkouts

@LucaFumis @d0choa, both QA and WWW have orthologies in the description of the Gene tree tab pointing to Ensembl Plants, rather than Ensembl.
Can we change that please? Also change the "orthologies" to "homology types" so that is the same as the title of the Ensembl page?
This is the page to link out to:
https://www.ensembl.org/info/genome/compara/homology_types.html
In summary, we would have:
"Phylogenetic tree showing the history of the human gene APP based on protein sequences from Ensembl. All branches in this tree have the same length (unscaled branches). You can also view the branches in different lengths based on the number of evolutionary changes in the tree (select scaled branches) All species are shown by default, but you can prune it to a subset of species by unticking the species accordingly. Check Protein trees and homology types for further details."

Thanks @deniseOme. "Homology types" is more appropriate than "orthologies" and the link was also the wrong one. I'll create a different issue for the React app

Updated in mini-release  v3.13.2 on 04Jul2019.


Fixed dead link inside plugins.md

this takes care of the broken link to this exact branch
this fixes #4899
have fun
same changes as in #4900

Thanks, that's better :)
But still the link itself should point to master and inside docs/ instead of the root of gh-pages* :)

facepalms himself
Yea you're right


Add the fact that the author field is mandatory in the documentation

Hello,
I've made a small plugin to open anything in a browser using Google's Feeling Lucky. It works fine in development mode so I thought that I could publish it (hain-plugin-go on npm).
However, after publishing it, Hain does not seem to want to install it using /hpm install :
2016-12-03T01:19:43.826Z - debug: Installing hain-plugin-go
2016-12-03T01:19:45.593Z - debug: hain-plugin-go TypeError: Cannot read property 'name' of undefined

I unfortunately don't have more details on the error, but I do know that it happens in the installPackage function of the hpm plugin code (index.js:251).
As you can see on the code here : https://github.com/natinusala/hain-plugin-go the plugin is well-formed, and actually works well in dev mode. What is causing this issue ?
Thanks !

Turns out that the author field is required, otherwise it causes this error. It should be added to the documentation.

@natinusala Thanks for the investigation! 😄  I'll add it to the documentation.

Resolved at 9eb8eca2b811fc22300c0af675b0789be3abc55f, Thanks!


Update hostnames and ordering for draft CSV previews

We are currently routing all requests for draft-assets to the live instance of Frontend first.
These requests should go to the draft Frontend instance instead.
Therefore updating the ordering so draft-frontend has higher priority and specifying a specific hostname for the draft Frontend instance so we match only draft requests.
Trello card

I started looking into the decoupling of these into two load balancers, but we don't have a draft instance of Asset Manager (it's the same app serving both live and draft).

I started looking into the decoupling of these into two load balancers, but we don't have a draft instance of Asset Manager (it's the same app serving both live and draft).

Ohh, yeah of course — sorry my bad.


Global Service Endpoints with Private Endpoint secured Storage accounts?

Does the Global vNet Service endpoint on Storage accounts support also using Private Link?
Service endpoints normally need to access the regional dns for the storage account to egress onto the Azure Backbone, but this is thwarted by the Private DNS override for Private link on Storage accounts in the same region, which forces line of sight routing.
If vNet A in North Europe has a storage account secured with Private Link, can I access a Storage account in vNet B (West Europe) over a Global Service Endpoint if the Storage Account in vNet B is also secured with Private link?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2632af75-7664-b79b-ac5b-c7c17e6a609a
Version Independent ID: 6ecf71b6-77c4-3ab6-8ec9-353ea407d70f
Content: Configure Azure Storage firewalls and virtual networks
Content Source: articles/storage/common/storage-network-security.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@JohnD76, Thanks for the question! We are taking a look into this and will get back to you soon.


build error on Solaris: no variant or associated item named Xcb found for enum RawWindowHandle

   Compiling gfx-backend-vulkan v0.6.5 (/builds/psumbera/VULKAN/gfx/src/backend/vulkan)
error[E0599]: no variant or associated item named `Xcb` found for enum `RawWindowHandle` in the current scope
   --> src/backend/vulkan/src/lib.rs:594:30
    |
594 |             RawWindowHandle::Xcb(handle)
    |                              ^^^ variant or associated item not found in `RawWindowHandle`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `gfx-backend-vulkan`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Seems to be caused by:
https://github.com/gfx-rs/gfx/commit/a498b475003c03319d9d79ce2eae0c1d3f1e9813
Following  seems to fix the issue:
diff --git a/src/backend/vulkan/src/lib.rs b/src/backend/vulkan/src/lib.rs
index c5f27e73..cd378eb3 100644
--- a/src/backend/vulkan/src/lib.rs
+++ b/src/backend/vulkan/src/lib.rs
@@ -586,6 +586,7 @@ impl hal::Instance<Backend> for Instance {
                 Ok(self.create_surface_from_xlib(handle.display as *mut _, handle.window))
             }
             #[cfg(all(
+                feature = "xcb",
                 unix,
                 not(target_os = "android"),
                 not(target_os = "macos"),

We no longer have the "xcb" feature, so we can't follow your suggested fix.
However, what we should do is just mirroring RawWindowHandle feature flags when checking for Xlib. See https://github.com/rust-windowing/raw-window-handle/blob/73a41ea28907b0f261816136b1b3f39cfdd791f3/src/lib.rs#L121-L125

Started the discussion about BSD configs on the rust-internals forum...

Ok. Shall I wait with submitting following fix?
index c5f27e73..22afacbe 100644
--- a/src/backend/vulkan/src/lib.rs
+++ b/src/backend/vulkan/src/lib.rs
@@ -589,7 +589,8 @@ impl hal::Instance<Backend> for Instance {
                 unix,
                 not(target_os = "android"),
                 not(target_os = "macos"),
-                not(target_os = "ios")
+                not(target_os = "ios"),
+                not(target_os = "solaris"),
             ))]
             RawWindowHandle::Xcb(handle)
                 if self

if you can instead make a PR with the configuration used by RawWindowHandle code, that would be great!

if you can instead make a PR with the configuration used by RawWindowHandle code, that would be great!

Sorry I think I'm still missing what change I should prepare.  Can you please more elaborate what and where I should put.

I believe the match arms for RWH in gfx-rs have to be gated the same way as they are in RWH definition itself, see the link I provided earlier. For Xcb in particular, this would be:
        cfg(any(
            target_os = "linux",
            target_os = "dragonfly",
            target_os = "freebsd",
            target_os = "netbsd",
            target_os = "openbsd"
        ))

There is actually one year old pull request for that. Can you please have look at it?
https://github.com/rust-windowing/raw-window-handle/pull/44

Thank you! Let's see how they respond now that you pinged them.

@psumbera: Is this still an issue we should resolve here?

No, we can close the issue now.


backport action: run only when the label starts with 'backport'

I haven't tested this, but it looks like it should work.

The zeebe docs suggest that the label selector should be done differently.
          # Optional
          # Regex pattern to match github labels
          # Must contain a capture group for target branchname
          # label_pattern: ^backport

That's orthogonal, it allows us to define what label is interpreted as valid backport label. The linked issue will still reproduce.

@domenkozar
Seems this label condition stopped working at some point, now it is running for every merged PR.
e.g.
https://github.com/NixOS/nixpkgs/pull/182370
https://github.com/NixOS/nixpkgs/runs/7498116953
@winterqt You may be interested in taking a look at it?


Theme for Python documentation

Get a basic theme with out branding for generating the documentation of Python projects.

this can be closed


FMUv1 Deprecation Notice and removal from source tree.

PR to follow, that will remove support for FMUv1 HW from PX4

Remove from QGC flash as well? @DonLakeFlyer FYI

Or just keep the last stable hanging around and change all versions to that?

In this cause I don't think the px4fmu-v1 has been functional for at least months. So unless someone wants to go back and find the last acceptable version I think we'll need to drop it completely.
Going forward that would be a good way to deprecate though.

Ok, I'll pull it.

Here is the plan:
I will do the PR removing the FMUv1 from the PX4 code base ASAP.
The PR will state that it is the notice of the FMUv1 Deprecation and will be merged in 30 days.
From the documentation side.  2 PR should be done:

ASAP: Add an announcement of the end of support in 30 day of FMUv1 where FMUv1 is referenced on px4.io  and in readme.

BY SEP-9 the: Removal of FMUv1 where FMUv1 is referenced on px4.io and in readme.

@hamishwillee Please let me know if you re the correct person to do the documentation PRs?

@hamishwillee Please let me know if you re the correct person to do the documentation PRs?

Anyone can do changes to the docs, but yes, I am happy to take care of this.

ASAP: Add an announcement of the end of support in 30 day of FMUv1 where FMUv1 is referenced on px4.io and in readme.

Is there a need for a blog post or official PX4 tweet on this? I'm guessing not.

Often this is mentioned as "PX4FMU-v1+PX4FMU" Do I need to concern myself with mentions of PX4IO?
E.g. https://docs.px4.io/en/advanced_config/parameter_reference.html#BAT_V_SCALE_IO

do you mean "PX4FMU-v1+PX4IO" ?

No, I mean PX4IO "stand alone" (I would deal with "PX4FMU-v1+PX4IO"). I assume not - PX4IO support is completely separate from FMU support"

In STM32 Bootloader > Run the JLink GDB server it says:

FMUv1:

JLinkGDBServer -select USB=0 -device STM32F405RG -if SWD-DP -speed 20000

Would this be "Any FMU version" - Ie could I change FMUv1 to FMUvX or should I delete that option?
{the reason I ask is because this is the ONLY FMU version specified}

FMUv1
JLinkGDBServer -select USB=0 -device STM32F405RG -if SWD-DP -speed 20000

Would become
FMUv2

JLinkGDBServer -select USB=0 -device STM32F427VI -if SWD-DP -speed 20000

I think the
AeroFC:

JLinkGDBServer -select USB=0 -device STM32F429AI -if SWD-DP -speed 20000

Is wrong - the CPU listed in the build is a CONFIG_ARCH_CHIP_STM32F427V
It may be more helpful to give a list of targets FMUv2,FMUv3,FMUv4... and the SoC that follow the word
-device

FYI, https://github.com/PX4/px4_user_guide/pull/48 will finish all user guide work for this. I hope to get it reviewed soon.

Done in #7769


Adding an extension in dynamic forward proxy config to further process the returned address

Title: Adding an extension in dynamic forward proxy config to further process the returned address
Description:
After DFP resolves an target and get the address[es], sometimes application may want to further process the address, for example, perform an address conversion for the IPv4 address based on certain network requirement, and return that converted address to DNS cache manager.
[optional Relevant Links:]

Any extra documentation required to understand the issue.

/assign @htuch

I think this makes sense, CC @envoyproxy/api-shepherds.The idea would be a DFP resolver plugin performs the moral equivalent of what an EDS address resolver would do. Basically, wherever we have a socket address, whether it comes from xDS or is resolved via DNS, we might want an opportunity to apply a local resolver.


Cache-Control policy for repo images

Hey all,
Al here. I just started using OpenCollective for a Github project of mine.
Yesterday I had a new sponsor join and was a little confused because it took a number of hours for their image to show up on the repo, and in the meantime the "Become a Sponsor" link was redirecting to that sponsor's page rather than to http://opencollective.com/libpostal#sponsor. It looks like Github caches images from OpenCollective, which have Cache-Control: public; max-age=7200 set (and I'm not even sure Github is respecting that because it took much longer than 2 hours, more like 6, for the image to appear after the donation went through).
A second effect is that when the new sponsor's image shows up, the "Become a sponsor" image disappears (another instance of the same issue, just that it's caching the one-pixel transparent placeholder instead of pulling https://opencollective.com/libpostal/sponsor/2/avatar.svg).
Looking at https://github.com/github/markup/issues/224, it seems like it's generally a best practice for badges, etc. is to set "Cache-Control: no-cache" and use ETag headers to limit bandwidth, etc. Is it possible to implement something like that instead of the TTL?
Thanks in advance,
./al

Thanks for the thorough debugging here!
We are sending a 300s cache control:
https://github.com/OpenCollective/opencollective-website/blob/master/server/controllers/banner.js#L124
So it looks like Cloudflare is overriding this.
Let me dig into this.

We have a new backer since three days now and it doesn't show up on the GitHub page as yet.

Are you sure that the backer has set an avatar? If there is no avatar we don't show it on github.
To add an avatar, the backer can login on OpenCollective.com with just their email and edit their profile.

No it seems that the backer hasn't setup an avatar. Why does the backer don't get the default OpenCollective avatar assigned for GitHub? On the GitHub page it shows:
Backers: 0
Sponsors: 1
But that's not true!

They do but since we can't show the name in the list of backers on GitHub, there is no way to differentiate them visually. And a bunch of default avatars doesn't look great in the mosaic of avatars. That's why we don't show them.
Good point on the badge. We can fix that.

Here is a PR for fixing the counter: https://github.com/OpenCollective/opencollective-website/pull/566
Should be deployed soon. Thanks for reporting the issue!


how to show  the exif_data  with multiple selected photos

i am successfully using blueimp_to_upload photos to the server. now i would like how to extract and show exif metadata (example ExifIFDPointer). i saw that the new version allows you to view the exif_data for single photos only. How can I view the exif_data of multiple selected photos?
Kind regards

Please have a look here on how to use the library:
https://github.com/blueimp/JavaScript-Load-Image#usage


In cabal files moving using 'w' skips over '.'

This makes it hard to edit module namespaces.
To move through Cow.Horse.Sheep
I have to use f. and then to say change Horse to Donkey I have to do ct. this is inconvenient as it basically puts cabal files in a different editing mode from every other kind of file.
I read https://superuser.com/questions/741422/vim-move-word-skips-dot
and then ran :verbose set iskeyword? in the cabal file
gives (notice the '.' in there):
 iskeyword=@,48-57,_,192-255,-,.,*
        Last set from ~/.vim/plugged/haskell-vim/after/ftplugin/cabal.vim

Is there any reason you are doing that?
Could you change it?
I think I can probably remove the '.' using an autocmd on filetype but was wondering if that has any other consequences?
Cheers
Jonny

Yep it's a bit distracting but I've did that for a reason (can't recall what exactly it was though). I should improve the cabal portion of the plugin at some point. It's still very hacky.


Added a function to deep merge a JSON object into another JSON object…

… destructively and non-destructively.
I added two new functions merge(other: JSON) and merged(other: JSON) -> JSON. Merging a JSON into another JSON adds all non existing values to the original JSON which are only present in the other JSON.
If both JSONs contain a value for the same key, mostly this value gets overwritten in the original JSON, but there are two cases where it provides some special treatment:

In case of both values being a JSON.Type.array the values form the array found in the other JSON getting appended to the original JSON's array value.
In case of both values being a JSON.Type.dictionary both JSON-values are getting merged the same way the encapsulating JSON is merged.

mergemutates the original JSON, whereas merged works non-destructively on a copy.
I found this to be an issue due to a stackoverflow.com post and posted my answer there, but also think that this functions might be a good addition to the SwiftJSON project in general.

@danielkiedrowski Awesome!  Thank you so much for contributing to SwiftyJSON, this is a great feature. Merging now.

Thank you @ldiqual! It was great working with you.


thai2fit dictionary update

words_th_thai2fit_201810.txt is now almost two years behind words_th.txt - should consider update the dictionary and related models.

It is in progress.

It is in progress.


Download POST request

Thanks for the wonderful initiative.
Can this library support download for POST request (response as attachment/deposition) download header types?
Thank you.

@shivasurya you can set header with setHeader().

I still hoping how to perform POST request method ? any ideas

Currently for that you will have to use this library.

How to use setHeader ?

how can i add header or token for downloading file using PRDownloader?


Update patches/stripbuildinfo.patch

This change is required since bitcoin/bitcoin#21366 was merged.

cr ACK 6fbbc3985be992d3c74e6bf5447387af003191bd
didn't test

این تغییر از زمان ادغام بیت کوین / بیت کوین شماره 21366 لازم است .


Question regarding sampling technique in EAGLE papers

Hello,
Thank you for your excellent work on EAGLE and EAGLE-2. I have been reading both papers, as well as Medusa.
The accept rate and speed-up metrics from the various experiments in the paper are valuable.
However, I have a question regarding the sampling method you used. I’m curious whether you applied rejection sampling or the typical acceptance scheme proposed by Medusa.
The papers typically show a 10-15% difference in accept rate, aside from the sampling method. It would be helpful to understand which method you used in your experiments.
Thank you

Thank you for your interest. We employ strict speculative sampling to ensure lossless results, rather than using the typical acceptance scheme found in Medusa.

Ah, so it is rejection sampling. Thank you for your answer.


Run GitHub Actions tests on multiple MATLAB versions

In particular, also test latest, so we quickly understand if there are problems with newer MATLAB versions even before we updated our machines.

@singhbal-baljinder thanks, feel free to merge.


LiZi cannot create a new project entry

LiZi cannot create a new project, reasons unknown.
Track down and fix.

@jdossett - I pushed the "no github repos" fix to master.bestpractices.coreinfrastructure.org.  If you could test it with the stub user you created earlier that'd be great.


add ability to create css file per stylex.create

Describe the feature request
With React 19 https://react.dev/blog/2024/04/25/react-19#support-for-metadata-tags
being able to dedupe link tags this could be a pretty powerful feature by only ever including the exact styles you need for a page
with remix, it could apply each to a page via import buttonSheet from './components/button.style.css and then add each component's css to the links function

I don't think that feature has any benefits for stylex, and that way of using it isn't really the intended use case. You still don't want new css getting loaded before different bits of ui can render, from the client or server

Just wanted to chime in and say that with atomic styles the total size of the CSS is already nearly ideal so you wouldn't actually gain any performance improvements with what you're asking for.
And atomic styles are required to make half the features of StyleX work.

Sure, it was just an idea. If you don't think chiming in on this kind of stuff I'll refrain from suggestions in the future.


OCR Barcode

Tesseract does not read the numbers below the barcode and only shows the letter T that is missing from the image.
Is it possible to read the barcode numbers?

Environment

Tesseract Version: Latest
Platform: Angular

Current Behavior: Latest
Expected Behavior:
Suggested Fix:

Please respect guidelines for posting issue: we do not provide support for 3rd party projects.
Reproduce your problem with resent version of tesseract executable and provide input image for reproducing error.
Make sure your read documentation.


document plot extensibility

There are a few todos… it's a lot of prose, and a bit of code.
depends on #1811

An initial thought…
Actual difficulty is unique to each reader because it depends on the reader’s own experience and way of thinking. Regardless of what we estimate to be easy or hard, each reader will feel differently, and if our estimations don’t match, it can be discouraging or alienating.
So instead of classifying by difficulty, how about we classify by commonness or expected relevance? How likely is it that the reader will want to extend it? If we rate things by how rare or common they are, we can put the common stuff at the top to prioritize what is more likely to be relevant. It’s okay, even expected, if readers are interested in uncommon things. For example, a scale transform, bin reducer, channel transform, and custom interval implementation might all be the same assumed level of difficulty 🌶, but I expect that the scale transform and bin reducer will be more common.
Another approach would be to group extensibility by topic area: data transformations, visual encoding, mark rendering, interaction, etc. Then within these groups, we can try to order by commonness. The current flat list feels a bit daunting!

Yeah I don't think there should be so many 🌶, it was more a manner of mapping these in my head.
Maybe we could keep just one emoji when something can be deemed more difficult, like Knuth does in the TeX book with curvy road signs:

The topic/commonness structure seems more natural and allows to find what you're looking for more quickly — then you look for the simplest solution that might help in that category.


[security] audit repository tooling

The security SIG is looking to ensure that security tooling is setup consistently across the organization. As a result, we're asking maintainers to ensure the following tools are enabled in each repository:

[x] CodeQL enabled via GitHub Actions
[ ] Static code analysis tool (the collector uses govulncheck [https://pkg.go.dev/golang.org/x/vuln] on every build)
[x] Repository security settings

[x] Security Policy ✅
[x] Security advisories ✅
[x] Private vulnerability reporting ✅
[x] Dependabot alerts ✅
[x] Code scanning alerts ✅

Parent issue: https://github.com/open-telemetry/sig-security/issues/12

Hello @codeboten I am Ogbodo Esther Oluomachukwu, an Outreachy applicant I  want to contribute by ensuring security tooling is setup.

Given that the demo isn't a production application, and the wide number of languages, we'd like to opt-out of the static analysis. Let me know if this is a problem @open-telemetry/sig-security-maintainers


How can we emit word confidence while decoding?

I am trying to estimate word confidence while doing CTC decoding, one of the simplest ways I could think of is just multiplying the associated character probabilities at that particular time step to get an approximation.
However, a lot of people have been using the concept of posterior probabilities and lattice to get the word confidence.
Is there a simplified way to have word confidence estimation during decoding?

https://github.com/PaddlePaddle/DeepSpeech/blob/develop/deepspeech/decoders/swig/ctc_beam_search_decoder.cpp#L138 this is for lm rescore.


We should have a style guide for LWKD

It would help contributors to LWKD to have a style guide.
While we can borrow some things (mainly about project/tool naming) from the Docs style guide, we need some guide materials that are peculiar to LWKD.

hii, can you explain what do you have in mind regarding the style?

This is the Kubernetes docs style guide:
https://kubernetes.io/docs/contribute/style/style-guide/
An LWKD style guide would include the elements that are relevant to us from that style guide, plus the other aspects of "LWKD" style, such as brevity, how we do merge entries, how links are handled, etc.


How does it work ?

Hello your plugin for VScode looks great but the autocompletion doesn't work with me.
Please explain how it works.
(Thanks in advance for your answer)

Hello,
Thank you :) Unfortunately the extension doesn't support auto completion, only syntax highlighting

Thank you very much for your answer. (do you know a plugin that supports it? Or how else to enable autocompletion)
Thank you for your reply!!!
PS: But I'll come back to you when yours is ready !!!

You're welcome and will be happy to see you use Sk-VSC soon :D
Probably all the current Skript extensions are not outdated but I know this one that should have auto-completion

Thank you very much for your answer. (do you know a plugin that supports it? Or how else to enable autocompletion)
Thank you for your reply!!!
PS: But I'll come back to you when yours is ready!!!

Thanks a lot


Adding water features connected to hydro power generation

I see that a lot of the new pipelines being rendered are a part of hydro power plants. Was that intended, or was the intended theme more about drinking water being distributed to people?
If it was about drinking water, you can remove all pipelines and canals that have usage=headrace;tailrace;penstock. Also, water=reservoir is more often than not connected to power generation and not water supply (although sometimes both). Maybe we need a usage tag on reservoirs.
Personally, I would be delighted to see a map targeted at hydro power plants, but I have a feeling this wasn't it.

I might change this later (and I guess move headraces/tailraces/etc to the power layer), but at the moment I'm happy with them on the water layer.

Then maybe, for consistency, add canals that have usage=headraces/tailraces, because right now it looks unfinished to me. You might have a pipeline headrace, then a canal headrace, and in the end pipeline penstock. And you just see a hole in the middle because, if I'm correct, canals are never rendered.

and I guess move headraces/tailraces/etc to the power layer

It would clutter the power layer. I suggest to make a distinction inside water features instead.
See https://map.infos-reseaux.com/#14.87/45.20579/6.57187/H,L


Reopening of #84

https://github.com/pisi/Reel/issues/84
@pisi Not sure if you only check the opened issues but I couldnt reopen this issue above.
Cheers,
Tom

Reopened myself.


Destroying orphaned vault

Hello,
I have trouble to setup gringotts.
I can create a vault by putting a sign on a chest with [Vault], but then when i use a command like: gringotts:balance,
the sign pop off and the vault is destroying.
The only specific message i have in the console is [Gringotts] Destroying orphaned vault
I am using paper 1.19.2 and this plugin list : AureliumSkills, BKCommonLib, Chunky, CMI, CMILib, Gringotts, Lands, LevelledMobs, LuckPerms, My_Worlds, Vault, WorldEdit
Thanks for your help

I removed all the plugins except those 3 : gringotts, luckperms, vault and still have the issue

Ok i found the issue:
i had vault_pattern: '[^\[]*\[(\w*) ?Vault\]' in my config file.
But in src/main/java/org/gestern/gringotts/AccountChest.java
You have String line0 = lines[0].toLowerCase().trim();
So event if i was writing the first line with [Vault] on my sign, respecting the case on the V, you are lower casing the sign first line everytime before comparing it with regex. So if the regex has an upper case, it will always fail.

That is really interesting. Thank you for providing all the steps to reproduce it. <3 I'll have a look to see if I can reproduce it and possible fix it <3


Authenticating to ACR using az credentials / managed identity

Hi,
I'm trying to build and push images to an Azure Container Registry without having docker as an explicit dependency. The image is being built correctly, but pushing it to a remote registry is not working without an explicit docker login.
Ideally I would like to be able to auth and push the image to an ACR by using:

the az login and az acr login -n <registry> commands locally
a managed identity in the ADO build agents

Any roadmap or potential workarounds for using the Azure Default Credentials to directly push to a private ACR specified by the <ContainerRegistry>$(registryName)</ContainerRegistry> property during dotnet publish?

Hi @mbkrafft - this is a duplicate of #425 which our team is currently investigating. We do want to support Managed Identity as a first-class options, and we do currently support authenticating to ACR using

admin credentials,
non-admin token credentials, and
Azure OIDC credentials (using az acr login, per their docs on how to use this inside a CI pipeline)

You can see some examples of these methods on this GitHub Actions run.
Thanks!

Sorry about the duplicate and thanks for the swift response. Will look into it!


Add enough useful information in CR status

User Story
As a user submitting a Custom Resource (CR), I want the operator to report back any relevant information to the CR status, So that I can have a better understanding of my resources. This can be useful in inspecting potential reconciliation issues or knowing if everything is fine from the operator's perspective.
Acceptance Criteria

[ ] When there are issues, it should return meaningful messages about the reason (like the status of the Backstage/PostgreSQL pods, e.g., ImagePullBackOff, CrashLoopBackOff, ...)
[ ] It should report whether the application is Ready or not
[ ] If Route is enabled in the CR, it should report the application route /URL once available
[ ] ...

Notes:

Kubernetes API Conventions about status: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

possible things to expose:

crashloopbackoff (status)
image name that can't be pulled (status)
failure reason (from console log) ?
application route/URL (once available) ?

for a currently failing Backstage pod:
status:
  conditions:
    - lastTransitionTime: '2023-12-21T13:39:37Z'
      message: Runtime in unknown status
      reason: Unknown
      status: Unknown
      type: RuntimeRunning

possible things to expose to better address problems with deployment:

crashloopbackoff (status)
image name that can't be pulled (status)
failure reason (from console log) ?
application route/URL (once available) ?

Thanks. I've updated the description of the issue accordingly.

Postponing this issue.. For now, we could document how to troubleshoot common issues. We can come back to this later to have proper messages added to the CR status. And it is always possible to look at the resources states and logs in the cluster.

I think it is more important to set the necessary reconciliation status in the Backstage CR for the resource deployment (for instance, if there are errors during reconciliation).
The application status can be monitored by the corresponding deployment & statefulset or pod status first. Having operator to set this status in the CR requires the operator to watch all the resources it deployed and will occur additional resource consumption for the cluster.

Yes, I am not sure if we really want to duplicate the statuses of all runtime objects in the Backstage CR status.
At least until we have a real feedback.
I do not think resource consumption is my reason though. I believe, operator already watching the resources in OwnRuntime mode.
I am just think we need to find proper format to not to overload CR.status in one hand and give reasonable set of information (i.e. "enough useful information") in other hand.
We probably can start with showing the name of corresponding Backstage and LocalDb (if any) pods:

name - it is fairly simple and would help to understand where to get important details and enable some automation for the client
we can add some integral state as well, for example taking from the pod's status Ready condition.
In addition we can consider showing URL where Backstage exposed (Service | Route | Ingress)

IMO it would be useful until we have feedback from the fields

Yes, I am not sure if we really want to duplicate the statuses of all runtime objects in the Backstage CR status. At least until we have a real feedback. I do not think resource consumption is my reason though. I believe, operator already watching the resources in OwnRuntime mode. I am just think we need to find proper format to not to overload CR.status with (not as important) duplicating info in one hand and give reasonable set of information (i.e. "enough useful information") in other hand. We probably can start with showing the name of corresponding Backstage and LocalDb (if any) pods:

name - it is fairly simple and would help to understand where to get important details and enable some automation for the client
we can add some integral state as well, for example taking from the pod's status Ready condition.
In addition we can consider showing URL where Backstage exposed (Service | Route | Ingress)

IMO it would be useful until we have feedback from the fields

IMO,  the RHDH operator's main responsibility is to deploy/sync the backstage configuration (CR and configmaps) with the cluster.  Showing runtime object status in the CR is something nice to have, and it sounds a good idea to me too to defer and wait for feedback from customers after the operator is released.

Let me clarify my thoughts from the previous comment with some implementation details I have in mind.
As discussed (and agreed in general):

Status should be informative enough to use/debug
Status should not be long

According to this, my proposals:

One Condition which reflects runtime running state, i.e. RuntimeRunning or so - True means all the objects are deployed as expected and workload is running. False means something goes wrong and message should contain enough information to identify failed object(s) (kind, name) and some information regarding the reason (quality and quantity of this information will be improved in time).
One Condition which reflects Backstage configuration state, i.e. whether all the CMs, Secrets are applied succesfully (the most typical problem is CM/Secret YAML is invalid). False should be accompanied with detaild info like Runtime condition. Note1: we do not validate it by operator, that's what K8s does trying to deploy. Note2: it may or may not impact on Runtime status, i.e. they do not duplicate each other. This condition needs some additional consideration, I would not be in hurry with it. but the idea is: to make it able to warn user about the configuration problem which cause unexpected Backstage behavior (even if container is up and running)
URL which exposes Backstage . The most straightforward option is to show Route state, in more general case existence/correctness this URL is not guaranteed.

Related topic: I propose to to remove OwnsRuntime option, making CR always be synchronized (owning) the objects and so remove SyncStatus.

Overall, this proposal looks good to me. A couple of more questions/comments below.

Let me clarify my thoughts from the previous comment with some implementation details I have in mind.
As discussed (and agreed in general):

Status should be informative enough to use/debug
Status should not be long

According to this, my proposals:

One Condition which reflects runtime running state, i.e. RuntimeRunning or so - True means all the objects are deployed as expected and workload is running. False means something goes wrong and message should contain enough information to identify failed object(s) (kind, name) and some information regarding the reason (quality and quantity of this information will be improved in time).

We need to define what "the workload is running" really means. Is it sufficient to check if the backstage application pod is up and running?

One Condition which reflects Backstage configuration state, i.e. whether all the CMs, Secrets are applied succesfully (the most typical problem is CM/Secret YAML is invalid). False should be accompanied with detaild info like Runtime condition. Note1: we do not validate it by operator, that's what K8s does trying to deploy. Note2: it may or may not impact on Runtime status, i.e. they do not duplicate each other. This condition needs some additional consideration, I would not be in hurry with it. but the idea is: to make it able to warn user about the configuration problem which cause unexpected Backstage behavior (even if container is up and running)

Yes, we can implement something basic and evolve it later if needed.

URL which exposes Backstage . The most straightforward option is to show Route state, in more general case existence/correctness this URL is not guaranteed.

It is helpful to show the URL, but I do not see the importance to show the route state.

Related topic: I propose to to remove OwnsRuntime option, making CR always be synchronized (owning) the objects and so remove SyncStatus.

Agreed - it should be removed. It is enforced in the current operator and removing it making our code cleaner.