Rpi 4 support

Question
Hi - is there any plan to make this available for  Raspberry Pi 4 as well?
System Information
Raspberry Pi 4

Hi @lessandro-ugulino
Thank you for this issue.
Zora is made to run inside a Kubernetes cluster.
Do you run a Kubernetes cluster on Raspberry Pi?
If yes, It should work installing Zora on this cluster. The installation method would be the same.

@lessandro-ugulino
Your question is related to this issue? https://github.com/undistro/zora/issues/200

@matheusfm Yes, this is related.
Apologies for not sending all details.
Also, I've applied the parameters suggested but it looks like the worker image for the cronjob doesn't support ARM architecture. I created my own image by changing the file Dockerfile.worker to support ARM, and now it works.

@lessandro-ugulino
So I will close this issue as duplicate and we can focus the conversations on the https://github.com/undistro/zora/issues/200, ok?
Please tell us about your tests, what do you change in Dockerfile.worker.

Duplicate of https://github.com/undistro/zora/issues/200


Reduce unused CSS

Resolves #3  (reduce unused CSS)

Added config for PurgeCSS as per this article and official PurgeCSS docs:

In client directory, run npm i --save-dev @fullhuman/postcss-purgecss glob-all purgecss-webpack-plugin
In package.json, add to the scripts section "postbuild": "purgecss --css build/static/css/*.css --content build/index.html build/static/js/*.js --output build/static/css"
Run npm run eject
In config/webpack.conf.js, add to imports section:

// import PurgeCSS webpack plugin and glob-all
const PurgecssPlugin = require('purgecss-webpack-plugin')
const glob = require('glob-all')

In the same file, directly above new ManifestPlugin(...), add:

new PurgecssPlugin({
  paths: [paths.appHtml, ...glob.sync(`${paths.appSrc}/**/*`, { nodir: true })]
}),

To confirm, run npm run build and verify that the contents of build/static/css contain only the used CSS

Build successfully tested
Reduced size of CSS from ~10kb to ~4kb

Could you explain more about the configuration changes you have done?

Sure thing! I edited my comment with detailed steps of exactly what I did as per the articles.

No, I'm asking about the changes you have done in frontend/config

Ah I see, all of that is automatically added as part of the eject process for Create React App needed to configure PurgeCSS. Sorry for the confusion. If you change your mind about ejecting, I can look into configuring Purge without it.

Ok. I feel that it will be better to not use the eject process to configure PurgeCSS


Format of releases.json is changing

I don't know if you're aware, but I spotted this issue over in the dotnet/core repo:  dotnet/core#1960
It looks like they're going to change the format of the data feed that your scripts use to find new package versions.

Thanks Martin. I'll be posting a deprecation announcement as soon as the format is through review. The summary is that we'll continue to update the existing file (v1) for 6 months to give folks ample time to adopt the new format.

Awesome, thanks Lee.

Looks like this was maybe partially resolved by #34, but then might have caused #35.

Also note that there's now an sdks collection - https://github.com/dotnet/core/issues/3114

The releases.json parsing code seems to be working correctly.


Allow pars escaped surrogate pairs

Surrogate pairs are parsed as two 16bit chars instead of one 32bit char.
For example this Json contains two 32bit emojis:
[ {   "id" : "1",   "message" : "\uD83D\uDE0B\uD83C\uDF70" } ]
We'r using java faster xml lib on one side https://github.com/FasterXML/jackson-core/issues/223 and nodejs jsonparse on the other side.
There is a diff with fix:
diff.txt

I can make a clean pull request. The diff is just for inspiration how to solve it.
@creationix

Could you please make a pull request?  Thanks.

https://github.com/creationix/jsonparse/pull/33

@creationix Thanks for merge https://github.com/creationix/jsonparse/pull/33. When we can expect the new version?

It's live!  Published to github and npm


[SMALLFIX] Use static imports for standard test utilities in class CopyFromLocalCommandIntgerationTest

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17745/
Test PASSed.


Yesterday's release broke some mdx syntax highlighting for me

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
vscode-mdx
Link to runnable example
No response
Steps to reproduce
Install the latest version of vscode-mdx
Open a markdown file with some markdown, even simple markdown will do. Here are some examples:
# Hello world

This **should** be highlighted

import Comp from './comp'

<Comp prop={34} prop2="hi">
  This: `should be syntax highlighted`.
</Comp>

## This should be highlighted

And _this_ should be too...

This is a list:

- why
- are
- these
- hyphens
- green?

No big deal, just kinda surprised...

Expected behavior
Things like headings, strong, italics, and inline code blocks should be highlighted.
Actual behavior
The colors are either non-existent or different from what I was used to before. The components look great though 👍
I'm using Night Owl, but these behaviors show up in others as well. I guess what I would really like is if my MDX highlighting looked as close to the regular markdown highlighting as possible.
Here's what the examples above look like with regular markdown highlighting in Night Owl:

(Yeah, MDX does better on this one for sure)

This could just be a case of "someone moved my cheese," but I do think there could be something wrong with the highlighting of the headings, strong, italics, and text in the back-tics.
Thanks!
Runtime
Node v18
Package manager
npm v9
OS
macOS
Build and bundle tools
No response

Hi Kent! Thanks for taking the time to test it out and provide feedback!
I’m going to move this to https://github.com/wooorm/markdown-tm-language. That’s where the code is. This grammar will also be used in other places, with other users, so it’s useful to have the discussions there.
There’s also a demo there: https://wooorm.com/markdown-tm-language/. Which is useful to compare. Because everyone’s themes are different.

I’m closing this issue in favor of the upstream one.


Command not found NPM

every time I try to install npm I get a comman not found message on VS. please help !
sadiki@Sadikis-MacBook-Pro generative-art-opensource-main % npm install zsh: command not found: npm sadiki@Sadikis-MacBook-Pro generative-art-opensource-main %

someone please help with this

npm install
npm audit fix
npm install canvas
node index.js


error in uploading apis to AWS Beanstalk

Hi I am uploading parse-server-example.zip to my AWS Beanstalk.
I have attached my zip file.
They said;
"Environment health has transitioned from Severe to Degraded. 100.0 % of the requests are failing with HTTP 5xx. Impaired services on all instances." and I failed every time.
parse-example.zip
Please let me know if I can get this fixed.
Thank you.

Hi Morewin!!, Did you fix it?


Question about getting started

Hi. At the first start, it gives me this message: interface address subnet should be /32 for IPv4 and /128 for IPv6. How to fix it?

Do you mind sending your wireguard / wireproxy config?

Wireguard conf:
[Interface]
PrivateKey = mNyqzNAlyK+93******
Address = <IP_ADDRESS>/24
DNS = <IP_ADDRESS>
[Peer]
PublicKey = Gj89agY+2Q5b4Q******
PresharedKey = e/y8yhQG7mU******
Endpoint = 87.120******:4129
AllowedIPs = <IP_ADDRESS>/0, ::0/0

Change Address = <IP_ADDRESS>/24 to Address = <IP_ADDRESS>/32

Thank you, can you tell me what to do with this?
Handshake did not complete after 5 seconds, retrying (try 2)

Thank you, can you tell me what to do with this?
Handshake did not complete after 5 seconds, retrying (try 2)

This means that wireproxy cannot connect to your wireguard peer. Check your keys and endpoints to see if they are correct.

The problem may be that the server is working via udp?

The problem may be that the server is working via udp?

Wireguard uses udp only so I'm not sure what you mean.

Ok. How to fix this problem?
socks: Failed to process the request: Failed to send a response: write tcp <IP_ADDRESS>:9652-><IP_ADDRESS>:29670: wsasend: The established connection was interrupted by the software on your host computer.


Update ElasticsearchEngine.php

fix score order and pagination

Can you make the test pass again so I can merge this?

Sadly this is still failing. I cannot merge until the test is fixed

Sadly this is still failing. I cannot merge until the test is fixed

Well tbh it's my first contrib on github and I didnt know why the test fail.
I checked on my branch and the return is :
Array
(
    [index] => scout
    [type] => table
    [body] => Array
        (
            [query] => Array
                (
                    [bool] => Array
                        (
                            [must] => Array
                                (
                                    [0] => Array
                                        (
                                            [query_string] => Array
                                                (
                                                    [query] => *zonda*
                                                )
                                        )
                                    [1] => Array
                                        (
                                            [match_phrase] => Array
                                                (
                                                    [foo] => 1
                                                )
                                        )
                                    [2] => Array
                                        (
                                            [terms] => Array
                                                (
                                                    [bar] => Array
                                                        (
                                                            [0] => 1
                                                            [1] => 3
                                                        )
                                                )
                                        )
                                )
                        )
                )
            [track_scores] => 1
            [sort] => Array
                (
                    [id] => Array
                        (
                            [order] => desc
                        )
                )
        )
)

for the test :
    public function test_search_sends_correct_parameters_to_elasticsearch()
    {
        $client = Mockery::mock('Elasticsearch\Client');
        $client->shouldReceive('search')->with([
            'index' => 'scout',
            'type' => 'table',
            'body' => [
                'query' => [
                    'bool' => [
                        'must' => [
                            ['query_string' => ['query' => '*zonda*']],
                            ['match_phrase' => ['foo' => 1]],
                            ['terms' => ['bar' => [1, 3]]],
                        ]
                    ],
                ],
                'track_scores' => 1,
                'sort' => [
                    ['id' => ['order' => 'desc']]
                ]
            ]
        ]);

If you have an idea of why test test fail I take it :)


[iOS Release] Doesn't show incoming call in iOS release mode but works in debug mode.

I am using FCM form sending signals. Everything works fine in Android  (debug and release) and iOS debug mode. But not getting call in background and terminated state in release mode. I am getting notification but showCallkitIncoming not showing any call.
And also getting call in foreground as expected
@hiennguyen92 please have a look on this issue
/// For fcm background message handler.
@pragma('vm:entry-point')
Future<void> _firebaseMessagingBackgroundHandler(RemoteMessage message) async {
  await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform);
  await notificationService.setupFlutterNotifications();

  if (message.data['id'] == "calling") {
    await notificationService.registerToCallkitEvent();
    notificationService.showCallkitIncoming(
      message.data['callId'] ?? message.messageId!,
      message.data['userName'],
      message.data['userPhoto'],
      message.data['groupName'],
      message.data['channelName'],
      message.data['userId'],
      type: message.data['video'],
      callerDevicetoken: message.data['callerDevicetoken'],
      // callToken: message.data['callToken'],
    );
  } else if (message.data['id'] == "call_declined") {
    log("Caller Declined the call");
    final callId = message.data['callId'];

    await FlutterCallkitIncoming.endCall(callId);
  } else if (message.data['id'] == "messaging" &&
      message.notification == null) {
    notificationService.showFlutterNotification(message);
  }
}

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform);

  // Set the background messaging handler early on, as a named top-level function
  FirebaseMessaging.onBackgroundMessage(_firebaseMessagingBackgroundHandler);
  if (!kIsWeb) {
    await notificationService.requestNotificationPerission();
    notificationService.setupFlutterNotifications();
  }
  runApp(const MyApp());
}

Closing the issue as after more investigation we found that the problem is nit on flutter_callkit_incoming. It’s because of firebase_messaging not working properly on iOS #9381.
We shifted to flutter Push which is better performing.

How push helped can you share any code or help?
I am having same issue and can not solve it for 3 months now :(
On iOS the onBackgroundMessage function from Fcm does't trigger at all. The notification arrive on time but the function doesn't trigger to start the incoming call screen :(
Somebody please share the solution.
thanks

hyy @Jazzykhan how to solved this issue.

@Technozer  hi i solved by using there example code and reading everything carefully. I think the issue was in the swift file.


'rocm devices are not available.' on UI startup on Windows

Getting 'rocm devices are not available' for 7900 XTX, and indeed it is not listed in the webui. Has worked previously. Adrenalin drivers are 23.11.1
(shark.venv) PS C:\develop\SHARK> shark-run --iree_rocm_target_chip=gfx1100
dd37c26 (HEAD -> main, upstream/main, origin/main, origin/HEAD) Update brevitas quant api (#1975)
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
shark_tank local cache is located at C:\Users\skapusniak\.local/shark_tank/ . You may change this by setting the --local_tank_cache= flag
gradio temporary image cache located at C:\develop\SHARK\shark_tmp/gradio. You may change this by setting the GRADIO_TEMP_DIR environment variable.
No temporary images files to clear.
vulkan devices are available.
metal devices are not available.
cuda devices are not available.
rocm devices are not available.
local-sync devices are available.
local-task devices are available.
Running on local URL:  http://<IP_ADDRESS>:8080

To create a public link, set `share=True` in `launch()`.

iree dump devices gives the following error:
(shark.venv) PS C:\develop\SHARK> iree-run-module --dump_devices=rocm
# ============================================================================
# Enumerated devices for driver 'rocm'
# ============================================================================

FLAGS ERROR: (Ôò»┬░Ôûí┬░)Ôò»´©Áƒæ╗
D:\a\iree\iree\c\runtime\src\iree\hal\driver_registry.c:319: NOT_FOUND; no driver 'rocm' registered

hipinfo:
--------------------------------------------------------------------------------
device#                           0
Name:                             AMD Radeon RX 7900 XTX
pciBusID:                         12
pciDeviceID:                      0
pciDomainID:                      0
multiProcessorCount:              48
maxThreadsPerMultiProcessor:      2048
isMultiGpuBoard:                  0
clockRate:                        2371 Mhz
memoryClockRate:                  1250 Mhz
memoryBusWidth:                   0
totalGlobalMem:                   23.98 GB
totalConstMem:<PHONE_NUMBER>
sharedMemPerBlock:                64.00 KB
canMapHostMemory:                 1
regsPerBlock:                     0
warpSize:                         32
l2CacheSize:                      4194304
computeMode:                      0
maxThreadsPerBlock:               1024
maxThreadsDim.x:                  1024
maxThreadsDim.y:                  1024
maxThreadsDim.z:                  1024
maxGridSize.x:<PHONE_NUMBER>
maxGridSize.y:                    65536
maxGridSize.z:                    65536
major:                            11
minor:                            0
concurrentKernels:                1
cooperativeLaunch:                0
cooperativeMultiDeviceLaunch:     0
isIntegrated:                     0
maxTexture1D:                     16384
maxTexture2D.width:               16384
maxTexture2D.height:              16384
maxTexture3D.width:               2048
maxTexture3D.height:              2048
maxTexture3D.depth:               2048
isLargeBar:                       0
asicRevision:                     0
maxSharedMemoryPerMultiProcessor: 64.00 KB
clockInstructionRate:             1000.00 Mhz
arch.hasGlobalInt32Atomics:       1
arch.hasGlobalFloatAtomicExch:    1
arch.hasSharedInt32Atomics:       1
arch.hasSharedFloatAtomicExch:    1
arch.hasFloatAtomicAdd:           1
arch.hasGlobalInt64Atomics:       1
arch.hasSharedInt64Atomics:       1
arch.hasDoubles:                  1
arch.hasWarpVote:                 1
arch.hasWarpBallot:               1
arch.hasWarpShuffle:              1
arch.hasFunnelShift:              0
arch.hasThreadFenceSystem:        1
arch.hasSyncThreadsExt:           0
arch.hasSurfaceFuncs:             0
arch.has3dGrid:                   1
arch.hasDynamicParallelism:       0
gcnArchName:                      gfx1100
peers:
non-peers:                        device#0

memInfo.total:                    23.98 GB
memInfo.free:                     23.86 GB (99%)

Thanks, I think I see this issue too. What version of IREE are you using?

20231113.707 apparently
(shark.venv) PS C:\develop\SHARK> pip show iree-compiler
Name: iree-compiler
Version: 20231113.707
Summary: IREE Compiler API
Home-page:
Author: IREE Authors
Author-email<EMAIL_ADDRESS>License: Apache-2.0
Location: C:\develop\SHARK\shark.venv\Lib\site-packages
Requires: numpy, PyYAML
Required-by:

Thanks. We got backed up on SRT releases. should be fixed tonight.

Fixed by the latest SRT pre-release.  https://github.com/nod-ai/SRT/releases/tag/candidate-20231116.585


add wiring diagram

adding a wiring diagram for the Dingo

yes, i am trying to procure all required items and replicate your work, can you please add the wiring diagram, it helps a lot for us

adding a wiring diagram for the Dingo

done! Apologies for the delay


Mk docs are not updated

Content of generated documentation site should be refined and updated.

Resolved with PRs #16 and #17


Support Spain region

For some reason, I can't load my highlights on https://read.amazon.com/notebook (.com), but it's working in the spanish one. So adding the support here will enable those cases.

That's awesome. Thank you for making the change. I wish there was an easy way to discover all the other regions that Amazon provides to support them all immediately.
I will update the README file and package version number of the plugin and will make a release shortly

This has been released now in 0.2.16.
FYI - I had to make some subsequent fixes after this PR.


Fixed incorrect handling of FPS for OpenCV cameras.

Fix for https://github.com/kivy/kivy/issues/5408

ref #5311

Tracking at https://github.com/kivy/kivy/issues/5146.


[Bug]: Creating web pixel extension fails

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Extension
Expected behavior
It should create a web pixel extension associated with my app
Actual behavior
It fails with the following message:
⭑ Fix the errors and run shopify extension create again.
Stack trace
No response
Reproduction steps

Run shopify extension create
Select an app
Select Web Pixel Extension

Operating System
Mac OS Ventura
Shopify CLI version (check your project's package.json if you're not sure)
2.7.1
Shell
No response
Node version (run node -v if you're not sure)
v16.15.0
What language and version are you using in your application?
No response

Hi @CoolTechYT !
Looks like you are using CLI 2.x, i'm afraid web pixel extensions are only supported on CLI 3.x.
Here is a guide to migrate your app to CLI3


Ikenna

Done with the "Dashboard saved file" first web-page.

Has some merge conflicts, will pull into my branch fix them and them push to frontend-work


info: sort HEAD keys by install date

This makes a lot more sense than sorting alphabetically by commit hash,
the previous behaviour.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Thanks again @alyssais!


VSCode Extension

Do you have any plans on releasing an IDE extension on top of htmllint? I'm up to the challenge of doing so for vscode, but I better double check if some work is being developed already.

I'm not aware of anyone doing that. Go for it!

Hey @croso-df - did you make any progress on this? I'd love to see a VSCode extension for this...

I'd also love to hear more!

I've just published the exension 🎉 https://marketplace.visualstudio.com/items?itemName=kamikillerto.htmllint

I'll consider this resolved then. Thank you, and feel free to raise more issues if there is anything that would be helpful on the linter side.


Quickstart with SQLite yields error: relative URL without a base

I'm trying to follow the quickstart with SQLite:
// in .env, DATABASE_URL=/absolute/path/to/database.db

struct ResultStruct;

async fn reproduce_bug() -> Result<(), sqlx::Error> {
    let pool = SqlitePoolOptions::new().max_connections(5).connect("/absolute/path/to/database.db").await;

    sqlx::query_as!(
		ResultStruct,
		"
    SELECT *
    FROM table
    "
	)
	.fetch_all(&pool)
	.await?;

    Ok(())
}

This fails to build with:
error: relative URL without a base
...
 = note: this error originates in the macro `$crate::sqlx_macros::expand_query` (in Nightly builds, run with -Z macro-backtrace for more info)

SQLx: 0.5.13
SQLite3: 3.31.1
libsqlite3-sys: 0.24.2

Using sqlite3 directly, I'm able to open the database as expected, so I'm confident it's not a copy/paste error in the path.

It looks like maybe SQLx is expecting the URL to be prefixed with "sqlite://"? Is this documented somewhere?
E.g. DATABASE_URL=sqlite://db/production.db (where db/production.db is the relative path to my SQLite database) looks to get me different errors that seem further along.

Found the documentation here: https://docs.rs/sqlx/latest/sqlx/sqlite/struct.SqliteConnectOptions.html.
The SQLx docs state:

A value of SqliteConnectOptions can be parsed from a connection URI, as described by SQLite.

The SQLite docs state:

SQLite uses the "file:" URI syntax to identify database files.

This is some of where my confusion arose. Is this a potentially misleading doc (difference between the file: scheme SQLite expects and the sqlite: scheme SQLx expects), or SQLx bug/design decision?

run this and try again:
export DATABASE_URL={db_protocol}://{user}:{password}@{host}:{port}/{database}
in my case, inside a docker compose cluster with dns resolution:
export DATABASE_URL=postgres://admin:admin@database:5432/ssleo

Superceded by #3099


I want to build this project under esp-idf,what can i do

hi,i want to build this under esp-idf

I can't use esp-idf driver the lcd

I cannot provide code that can be run directly The IDF example directory contains related examples of spi lcds. Please refer to their implementation methods

but under ardunio ,what project can i open ?

哥们，能不能加个微信？

哥们，微信能不能加一个？
郁闷少年O(∩_∩)O~~
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "Xinyuan-LilyGO/T-QT"                                                                                @.>;
发送时间: 2023年3月30日(星期四) 上午7:00
@.>;
<EMAIL_ADDRESS>主题: Re: [Xinyuan-LilyGO/T-QT] I want to build this project under esp-idf,what can i do (Issue #24)
哥们，示例我全部更新过了，你重新克隆仓库吧。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Issue parsing nasm rc versions

The version parser cannot handle the format of nasm RC builds (e.g. from nasm git)
  cargo:warning=This version of NASM is too old: NASM version 2.16rc0 compiled on Jan 10 2022
  . Required >= 2.14.0

Fixed with commit 3c50ba4 update to version 0.2.3 on crates.io


Can't get RedirectSubscriber to work

Using Symfony2. I'm sure I'm doing this wrong, but I have simply registered the RedirectSubscriber in my services.yml tagged as a kernel.event_subscriber. I am attempting to access a site that 301's from http://www.example.com to http://example.com, and am using a basic CurlHttpAdapter, but I'm just getting the 301 back instead of following it.

Can you copy/paste some code?

Will do. Might take me a couple of days as I transitioned to a different project for a few days, but hope to be back on this soon.

After reading your original post, I realize you maybe doing it wrong. First of all, how do you use the library (standalone or via the bundle)? If you use it as standalone be sure th event subscriber used by the library is the one used by the kernel. If you use it via the bundle, I need to rework it as it is a little be late comparing to the library...

I'm using the stand-alone (didn't realise there was a bundle too). My service is added like this:

ivory.redirect:
class: Ivory\HttpAdapter\Event\Subscriber\RedirectSubscriber
tags:
- { name: kernel.event_subscriber }

I'm using this in conjunction with fxmlrpc. I create a new CurlHttpAdapter, with a for now empty new Configuration, and pass that to the fxmlrpc Client through their included HttpAdapterTransport. Code looks like this:

$curl = new CurlHttpAdapter(new Configuration());
$client = new Client($website, new HttpAdapterTransport($curl));

Non-redirected sites work just fine, so it looks like I did something right, but getting the redirect to work has me stumped.

Ok so you don't use the bundle. I would recommend you to use it (that will ease your use of the library) but for now, it is not up to date with the lib... If you want to use the event Symfony2 event dispatcher in the library you must use the event dispatcher http adapter (See https://github.com/egeloen/ivory-http-adapter/blob/master/doc/adapters.md#event-dispatcher)

Ah so there is a wrapper to put around my CurlHttpAdapter that also requires the event dispatcher to be passed in? Not sure how I managed to miss that part of the docs, thanks! I'll try it out sometime soon - maybe someday I'll manage to get back to this project :\

I switched over to the bundle and got everything configured. Once I determined I needed to require strict RFC compliance (page only accepts POST), everything worked perfectly. Thanks!!


[SPARK-22716][SQL] Replace addReferenceObj to reduce the number of global variables

What changes were proposed in this pull request?
We have two methods to reference an object addReferenceMinorObj and addReferenceObj . The latter creates a new global variable, which means new entries in the constant pool.
The PR substitutes  addReferenceObj with addReferenceMinorObj where considered safe.
How was this patch tested?
added UTs.

Test build #84575 has started for PR 19916 at commit 3004a69.

Test build #84575 has finished for PR 19916 at commit 3004a69.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84575/
Test PASSed.

Merged build finished. Test PASSed.

https://github.com/apache/spark/blob/e98f9647f44d1071a6b070db070841b8cda6bd7a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala#L1123

@viirya thanks but that is going to be fixed by #19908, that is why I haven't changed it here. Thanks.

Yea, I noticed that. Thanks.

LGTM with one minor comment.

Actually I think addReferenceObj is not a strong use case for global variable, how hard it is to remove all of them?

I also have the same feeling when I just looked at addReferenceObj. Seems no necessary reason to have a global variable for such reference object.

my only concern about this PR and about removing addReferenceObj is that we are saving a cast every time. I am not sure about how much this can affect performances, but I am planning to make some tests. Actually after this patch, the only place where it is used is for metric terms.
WDYT?

I am reporting the result of my tests. I run:
Object a = new Integer(1);
   long start = System.currentTimeMillis();
   for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     Integer b = ((Integer)a) + 1;
   }
   long end = System.currentTimeMillis();
   System.out.println("Time for casting: " + (end-start));
   long start1 = System.currentTimeMillis();
   Integer ai = (Integer) a;
   for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     Integer b1 = ai + 1;
   }
   long end1 = System.currentTimeMillis();
   System.out.println("Time without casting: " + (end1-start1));

In the compiled code there is an additional operation checkcast (both with janinoc and javac), but the performance result of running this seems telling that there in not a significant impact:
➜  janino_tests java A
Time for casting: 305
Time without casting: 311
➜  janino_tests java A
Time for casting: 305
Time without casting: 302
➜  janino_tests java A
Time for casting: 309
Time without casting: 293
➜  janino_tests java A
Time for casting: 291
Time without casting: 312
➜  janino_tests java A
Time for casting: 297
Time without casting: 294

What do you think given these results? Should I go on with the PR and remove also the remaining addReferenceObj?
Thanks.

Thanks for the test! Yea lets' remove all of them!

Test build #84651 has started for PR 19916 at commit 29c92c0.

Test build #84651 has finished for PR 19916 at commit 29c92c0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84651/
Test PASSed.

@mgaido91 Thank you for running the benchmark. I have two questions.

Did you confirm that you measured only the jitted code. This is because this benchmark may not include warm-up run.
Did you have chance that loop body is not eliminated? This is because local variable b and b1 are not read anywhere. Thus, an optimizing compiler may delete an store and related operations.

thanks for your answer @kiszk. I included the code in a main function and run it with the command I showed in the previous comment.
The loop is not eliminated, I checked the java bytecode as said, and the only difference between the two loops is an additional operation checkcast.
For reference I can report here the bytecode:
         0: new           #2                  // class java/lang/Integer
         3: dup
         4: iconst_1
         5: invokespecial #3                  // Method java/lang/Integer."<init>":(I)V
         8: astore_1
         9: invokestatic  #4                  // Method java/lang/System.currentTimeMillis:()J
        12: lstore_2
        13: lconst_0
        14: lstore        4
        16: lload         4
        18: ldc2_w        #5                  // long<PHONE_NUMBER>l
        21: lcmp
        22: ifge          48
        25: aload_1
        26: checkcast     #2                  // class java/lang/Integer
        29: invokevirtual #7                  // Method java/lang/Integer.intValue:()I
        32: iconst_1
        33: iadd
        34: invokestatic  #8                  // Method java/lang/Integer.valueOf:(I)Ljava/lang/Integer;
        37: astore        6
        39: lload         4
        41: lconst_1
        42: ladd
        43: lstore        4
        45: goto          16
        48: invokestatic  #4                  // Method java/lang/System.currentTimeMillis:()J
        51: lstore        4
        53: getstatic     #9                  // Field java/lang/System.out:Ljava/io/PrintStream;
        56: new           #10                 // class java/lang/StringBuilder
        59: dup
        60: invokespecial #11                 // Method java/lang/StringBuilder."<init>":()V
        63: ldc           #12                 // String Time for casting:
        65: invokevirtual #13                 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
        68: lload         4
        70: lload_2
        71: lsub
        72: invokevirtual #14                 // Method java/lang/StringBuilder.append:(J)Ljava/lang/StringBuilder;
        75: invokevirtual #15                 // Method java/lang/StringBuilder.toString:()Ljava/lang/String;
        78: invokevirtual #16                 // Method java/io/PrintStream.println:(Ljava/lang/String;)V
        81: invokestatic  #4                  // Method java/lang/System.currentTimeMillis:()J
        84: lstore        6
        86: aload_1
        87: checkcast     #2                  // class java/lang/Integer
        90: astore        8
        92: lconst_0
        93: lstore        9
        95: lload         9
        97: ldc2_w        #5                  // long<PHONE_NUMBER>l
       100: lcmp
       101: ifge          125
       104: aload         8
       106: invokevirtual #7                  // Method java/lang/Integer.intValue:()I
       109: iconst_1
       110: iadd
       111: invokestatic  #8                  // Method java/lang/Integer.valueOf:(I)Ljava/lang/Integer;
       114: astore        11
       116: lload         9
       118: lconst_1
       119: ladd
       120: lstore        9
       122: goto          95
       125: invokestatic  #4                  // Method java/lang/System.currentTimeMillis:()J
       128: lstore        9
       130: getstatic     #9                  // Field java/lang/System.out:Ljava/io/PrintStream;
       133: new           #10                 // class java/lang/StringBuilder
       136: dup
       137: invokespecial #11                 // Method java/lang/StringBuilder."<init>":()V
       140: ldc           #17                 // String Time without casting:
       142: invokevirtual #13                 // Method java/lang/StringBuilder.append:(Ljava/lang/String;)Ljava/lang/StringBuilder;
       145: lload         9
       147: lload         6
       149: lsub
       150: invokevirtual #14                 // Method java/lang/StringBuilder.append:(J)Ljava/lang/StringBuilder;
       153: invokevirtual #15                 // Method java/lang/StringBuilder.toString:()Ljava/lang/String;
       156: invokevirtual #16                 // Method java/io/PrintStream.println:(Ljava/lang/String;)V
       159: return

Did I answer properly to your questions?

Thank you for checking Java bytecode. I am talking about native code, not about bytecode. Hotspot compiler may eliminate statements.
I think that this elapsed time includes interpreter execution, JIT compilation, and native code execution. It would be good to add warm-up.
I think that it is not the best to write a long-running loop in main() method since it leads to on-stack-replacement. It would be good to put the long-running target loop into a callee.
I think that it would be good to store a result into a global variable unlikely to eliminate unused variables and related operations.
WDYT?
Integer globalVar g;
void targetMethod() {
   Integer b;
   for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     b += ((Integer)a) + 1;
   }
   g = b;
}
// warm up
for (int i = 0; i < 10000000; i++) { targetMethod();}

long start = System.currentTimeMillis();
targetMethod();
long end = System.currentTimeMillis();}

sure, I can make the test as you suggested, I'll report here the results in few minutes, thanks.

Thank you again very much for your comment @kiszk! Results are different now and they show a difference in performance.
The code I am running is:
public class A {
 private static Long g;

 public static void main(String[] args){
   A a = new A();
   long start = System.currentTimeMillis();
   a.testWithCast();
   long end = System.currentTimeMillis();
   System.out.println("Time for casting: " + (end-start));
   long start1 = System.currentTimeMillis();
   a.testWithoutCast();
   long end1 = System.currentTimeMillis();
   System.out.println("Time without casting: " + (end1-start1));

 }

 public void testWithCast() {
 	Object a = new Long(1);
 	Long b = 0L;
 	for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     b += ((Long)a);
   }
   g = b;
 }

 public void testWithoutCast() {
 	Object a = new Long(1);
 	Long al = (Long) a;
 	Long b = 0L;
 	for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     b += al;
   }
   g = b;
 }
}

and the results now are:
➜  janino_tests java A
Time for casting: 3650
Time without casting: 3360
➜  janino_tests java A
Time for casting: 3682
Time without casting: 3399
➜  janino_tests java A
Time for casting: 3671
Time without casting: 3347
➜  janino_tests java A
Time for casting: 3743
Time without casting: 3411

Thus the time needed for casting is visible now. I am not sure, then, that replacing the old method is the right thing to do. WDYT?

In a real application I think the difference is much smaller than 2.4%. So I think it's ok to remove addReferenceObj.
One problem is readability of the generated code, may be we can generate
(MyClass) reference[3] /* variableNane */

@cloud-fan thanks for your answer. I don't think that something like:
((MyClass) reference[3] /* variableName */).doSomething();

would be readable. But it is just my opinion. Do you want me to add a local variable to generate more readable code? Or if you think that adding the comment is the right thing to do, I can do that.
Thanks.

adding a local variable to generate more readable code is better, but that needs a lot of caller-side change, which may not worth.

@cloud-fan I think a lot of caller-side changes would be needed as well, since now we are not passing any variable name when we are referencing with addReferenceMinorObj. I am not sure that adding a new argument to addReferenceMinorObj only for the comment is the right way to go.
Sorry for this additional comment, I just want to make sure that I am providing you all the details to choose the best option. I swear that now if you say, let's add the comment, I'll do.

I think a lot of caller-side changes would be needed as well, since now we are not passing any variable name

I mean something like
def addReferenceObj(name: String, obj: Any, className: String = null): String = {
  val idx = references.length
  references += obj
  val clsName = Option(className).getOrElse(obj.getClass.getName)
  val comment = Option(name).map(n => s"/* $name */").getOrElse("")
    s"(($clsName) references[$idx] $comment)"
  }

def addReferenceMinorObj(obj: Any, className: String = null): String = {
  addReferenceObj(name = null, obj, className)
}

Then no caller side change is needed.
In the future we can also remove addReferenceMinorObj as it's always better to have a name.

@cloud-fan  thanks I am doing this. Actually I already removed addReferenceMinorObj in this PR. Thanks.

I have a question about benchmark. What is the purpose of this warmup? Why does this code perform warmup run for a loop will not be measured?

@kiszk sorry, may I please ask you to elaborate a bit more what you meant? Thanks.

Test build #84716 has started for PR 19916 at commit bfa3bae.

Test build #84716 has finished for PR 19916 at commit bfa3bae.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84716/
Test FAILed.

Test build #84762 has started for PR 19916 at commit 9bbfe2a.

Test build #84762 has finished for PR 19916 at commit 9bbfe2a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84762/
Test FAILed.

Jenkins, retest this please

Test build #84767 has started for PR 19916 at commit 9bbfe2a.

LGTM, pending jenkins

Test build #84767 has finished for PR 19916 at commit 9bbfe2a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84767/
Test FAILed.

Looks like a valid test failure.

Test build #84771 has started for PR 19916 at commit 8c6dfb1.

@viirya it is caused by the fact that the generated code now is bigger and it triggered reduceCodeSize for ScalaUDF. I fixed the UT. Thanks.

@mgaido91 I am asking the following code. This code will be translated to the native code. However, this code does not make any affect to testWithCast and testWithoutCast.
Did you confirm that this measurement does not include the JIT compilation time?
   // warmup cycle
   Long b = 0L;
   for(long i = 0; i <<PHONE_NUMBER>; ++ i){
     b += al;
   }

@kiszk, yes, sorry, I see now that the code I pasted is not updated. I will update it immediately. I am calling the tho methods instead of that fake warmup cycle. Sorry, my bad. I am updating my previous comment with the right code, sorry.

Test build #84771 has finished for PR 19916 at commit 8c6dfb1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84771/
Test PASSed.

thanks, merging to master!


[feature] Request type file

now no type file or @types/better-opn.  and typescript report error

Hi @chenxxzhe, I would be more than happy for you to contribute and open a PR if it is really critical to you.


BUG: Large space in the list of 'more' icon

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Their is a large space in the list of 'more' icon. I can solve this issue.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 @huamanraj @RishabhDhawad Sir please assign this issue to me.

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


github corner

Use github corner https://tholman.com/github-corners/

Sorry for merging too late.
thank you for contribution.


Add PLUGGED information.

Such as :
PLUGGED_AC
PLUGGED_USB
PLUGGED_WIRELESS

Is helpful information.

It would be doable, but can you describe your usecase? I previously decided against it because I couldn't come up with a usecase where it wasn't largely redundant info. For example, I already know that it's charging via USB because I physically plugged it into USB.

Its more of a trouble shooting issue. For example I was having some issues with the USB port on my phone. sometimes I see its plugged in as USB and other times AC. When it is plugged in as USB its barely charging. Pulls something over 1 Watt at 4 volts. And when over AC it goes up to 6 Watts.

Its entirely up to you whether you want to add or not.

Makes sense. I'll take a look when I have some time.

This was added in 0c07292096e42b93cee2b568d27b39e67cd0947e.

This was released in v1.18. You can get it from the releases page, or F-Droid and Play Store should pick it up in the next few days.
Feel free to re-open this issue if the release doesn't resolve your concern.

@dubrowgn Nice thanks.

That's a very nice feature.
I mainly use Wattz to check my aging battery (show voltage while not loading).
Because my phone decides to show like 50+ % capacity even when it's battery is at 3.3 V only, f.e., shortly before going off.
I tried battery calibration tools, but none did work sadly, so the % stays inaccurate, while the runtime is like 3 hours with screen on still.

Now it would be nice to have the possibility to show both V and W optionally.
I also have different cables, chargers and wanna see if it's loading with 0.5 A or more like 1.8 A, f.e. (which is maximum for my phone). This f.e. is needed in the car / on the bike when navigation is on and the battery drain usually is much higher than loading with the wrong cable (too much resistance, not only length is important! I have many long cables which are better than short ones also) or low amp chargers.
Thx for this great app!


What is UsizeConversions trait?

In PhysAddr doc:

The UsizeConversions trait can be used for performing conversions between u64 and usize.

I googled it but no information about it found. What is this?

See https://docs.rs/usize_conversions/0.2.0/usize_conversions/
I don't remember why we're mentioning that crate/trait, probably we re-exported it at some point. So we should probably remove that sentence from the docs.

Thank you for your reply. Now that the conversions between u64 and usize can be done with TryFrom or TryInto, I think just changing UsizeConversions to TryFrom (or TryInto) is enough. If so, I'll create a PR.

Sounds good to me!


Fix setup.py and some other bugs, add a new background image, change how background images are handled.

I got setup.py to work! To install, run python setup.py bdist_wheel
and then run pip install path, where path is the final path of the
.whl file (should be in dist/)
I fixed a bug in slither where it couldn't find the snakey.png image.
I made a better background picture for bgTest.py
I made slither scale background images to fill the entire background.
I updated .gitignore to ignore the nppBackup folder (created by
notepad++) and Thumbs.db (mad by Windows)

Do you think you can make an 800x600 version of that background?
Other than that, looks good!

At first I thought that the slither stage was 480 by 360, so that is what resolution I used. I make  new image.

I created a higher res bg image.

I'm going to make a new branch for any other features I want to add.

OK. In the meantime I'll merge this, it looks good.

Great!


🦟[Bug Report]  Explorer URLs are broken

Replace "https://insight.litecore.io/api/addrs/utxo"
Replace:  "https://testnet.litecore.io/api/addrs/utxo"

No.we will have the issue is the same for both platforms. We will have to push releases. But thanks for the heads up!(Just confirmed the URLs in Android and iOS need to change) Thanks u/losh11
Describe the bug

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots

Observed Environment

OS version [e.g. iOS 13.0]:
Litewallet Version [e.g. v3.4.0]:
Device model:[e.g. iPhone 11]:

Additional context or information

cc: @losh11
Can you drop in the output from the taken down endpoints?
 mainURL = "https://insight.litecore.io/api/addrs/utxo"
 fallbackURL = "https://insight.litecore.io/api/addrs/utxo"
 testnetURL = "https://testnet.litecore.io/api/addrs/utxo"


[BUG] 0.64 Prevents tests running

Describe the bug
Updated to 0.64
1 ."Test Flask" tool bar icon shows lists of robot files in the TESTING pane, but only hover-icon available is 'go to test' - the 'play' and 'debug' icons don't exist.

When viewing a .robot file, the play icon is in the line-number column, and clickable, but the 'Test Results' panel just shows 'Test Run at [Date/Time]' with a circle icon, and the tests haven't been run.

Back rev to 0.63 and all is OK
To Reproduce
Steps to reproduce the behavior:

Update to 0.64.  Reload VSCode (and stop/start app)
'Flask' side-bar icon, all files no longer show test-run icons
'Explorer' side-bar icon, test run icons exist in line-number column, but don't seem to run.
ALL robot files are the same.

Expected behavior
A clear and concise description of what you expected to happen - work as 0.63
Screenshots/ Videos
If applicable, add screenshots or videos to help explain your problem.

Logs
Copy the messages from VSCode "Output" view for RobotCode and RobotCode Language Server for the specific folder/workspace.
Desktop (please complete the following information):

VS Code Version 1.84,2
RobotCode Version 0.64.0
OS: Windows 11 / Windows 10
Python Version  3.11.4
RobotFramework Version 6.1.1

Additional context
Add any other context about the problem here.

This is fixed in 0.64.1 please update

All working fine with 0.64.1 - thanks for the quick response! 🥇


Add Docs: How to communicate with the distributor? How to send a proper CloudEvent?

While writing https://github.com/ChristianKreuzberger/keptn-service-template-python I had some issues with sending CloudEvents back to Keptn (via the Distributor).
I used the documentation provided here: https://keptn.sh/docs/0.8.x/integrations/custom_integration/#send-a-started-event

Option 1 does not work for me, as I am running within the Keptn Kubernetes Cluster and I want to communicate via the distributor.
Option 2 does not work either, as sending the CloudEvent to  <IP_ADDRESS>:8081 did not work. I had to send it to http://<IP_ADDRESS>:8081/event (please mind the protocol http, and the path /event!)
Furthermore, it was really really troublesome in creating a CloudEvent that would eventually be mapped to the correct sequence in Keptn:

It needs to have the correct shkeptncontext
It needs to have the correct triggeredid
It needs to have the correct data.project, data.stage and data.service properties set

I believe these things might be addressed in the Keptn spec / CloudEvents, but we should add a note about that so future devs have a reference.
Anyway, one more problem occurred (and that's part of Keptn Core): In case I miss any of these attributes, I will not get an error message or anything else, I'm just lost and I have to do some reverse engineering (I actually had to look at the distributor Source Code). This should be reasoning enough to provide a better documentation.
Proposal

[ ] Change the custom integration docs to provide the proper URL for sending CloudEvents via the Distributor
[ ] Add a separate page about the distributor, and which endpoints it provides (reference to existing Swagger UIs if possible)
[ ] Add a note to show which parts of a CloudEvent are required for Keptn to map it, link to spec for more details
[ ] Describe error log propagation via distributor as well (general-purpose cloudevents)

outdated


Use of model_files

Hi,
Very nice effort, I am having doubt in model_files. Inside that directory I was seen two files with the extension .model. Can you please tell me what that files actually having and how to view those file.

One is for intent classification, its a scikit learn SVM model.Other is for Entity recognition and its a CRFsuite model. We use them for prediction, you can't view them but they can be rebuilt using the framework.


fix: do not use a remote svg image in preview

Do you think we can use one of the react icons here?

Yeah we can, but we're changing the src value dynamically so I kept the local image.
We can conditionally render icon vs image, but changing the image src dynamically makes more sense i believe

I think we should swap out the element because for SVGs rendering them in an img element isn't entirely right.  react-icons runs all the svgs through SVGR which places the svg directly on the page


Add support for a data-display-as attribute that specifies an alternate display value for select options

These changes add support for a data-display-as attribute that specifies an alternate display value for select options.  For example, when setting an alarm on iOS when the user sets the repeat days, the select shows values like "Every Monday", but on the main alarm page the value is displayed as "Mon".
A smart select set up to work similarly with these F7 changes might be defined as:

      <select name="repeat" multiple>
       <option value="0" data-display-as="Sun">Every Sunday</option>
       <option value="1" data-display-as="Mon">Every Monday</option>
       <option value="2" data-display-as="Tue">Every Tuesday</option>
       <option value="3" data-display-as="Wed">Every Wednesday</option>
       <option value="4" data-display-as="Thu">Every Thursday</option>
       <option value="5" data-display-as="Fri">Every Friday</option>
       <option value="6" data-display-as="Sat">Every Saturday</option>
      </select>

Repeat

VALUE

This is the first pull request I have ever submitted, so if I've missed a step or done something wrong please let me know.

Also, I have tested this with simple and multiple selects.  It works in both cases.

Thanks, merged! I also added additional check as dataset not supported everywhere


Dialog Content Transition Prop Type Update

Describe the feature in detail (code, mocks, or screenshots encouraged)
To make the Transition prop of the Dialog Content component more flexible, you could change the type of the prop to Transition | null | undefined.
What type of pull request would this be?
None
Provide relevant links or additional information.
No response

I don't see a good reason not to, so let's do it!

With Svelte 5, we're dropping the various transition* props as it is possible to accomplish in user land with much less overhead, so I'll be closing this issue as not planned.


Support plain string as a message value in webhook subscription

Support plain string as a message value in webhook subscription.
Observed behavior
When putting a plain string in the value field of a FireFly message, the HTTP request body on the received webhook is an empty object
Expected behavior:
If a message is accepted by a FireFly node, whatever is in the value field should be put in the HTTP request body for a webhook subscription
Before Changes:
POST /test HTTP/1.1
Host: ff-meera.requestcatcher.com
Accept: application/json
Accept-Encoding: gzip
Content-Length: 2
Content-Type: application/json
User-Agent: go-resty/2.6.0 (https://github.com/go-resty/resty)
{}
After Changes.
POST /test HTTP/1.1
Host: ff-meera.requestcatcher.com
Accept: application/json
Accept-Encoding: gzip
Content-Length: 20
Content-Type: application/json
User-Agent: go-resty/2.6.0 (https://github.com/go-resty/resty)
{"value":"hello456"}

Codecov Report

Merging #225 (870cfe2) into main (69c845f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          206       206
  Lines        11159     11163    +4
=========================================
+ Hits         11159     11163    +4

Impacted Files
Coverage Δ

internal/events/webhooks/webhooks.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c845f...870cfe2. Read the comment docs.


use Iterator::sum() for summing instead of fold

Just makes it a little more idiomatic. Nothing important.

Looks good, thanks!
I think I wrote that when sum was still unstable, and forgot to come back to it.


corrected docstring for find_beautiful_languages exercise

replaced is_beautiful? with :is_beautiful? to be consistent with expected output in spec

I've committed your requested change. Thanks @rlmoser99 ! :)


Errors were encountered while processing:openssh-client  ssl-cert

Enabling module authz_groupfile.
Enabling module authn_file.
Enabling module authz_host.
Enabling module reqtimeout.
Setting up apache2-mpm-prefork (2.2.22-1ubuntu1.11) ...
invoke-rc.d: policy-rc.d denied execution of start.
Setting up apache2 (2.2.22-1ubuntu1.11) ...
Setting up liberror-perl (0.17-1) ...
Setting up git (1:<IP_ADDRESS>-1ubuntu0.3) ...
Setting up libapache2-mod-php5 (5.3.10-1ubuntu3.26) ...
debconf: unable to initialize frontend: Dialog
debconf: (TERM is not set, so the dialog frontend is not usable.)
debconf: falling back to frontend: Readline
debconf: unable to initialize frontend: Readline
debconf: (This frontend requires a controlling tty.)
debconf: falling back to frontend: Teletype
Creating config file /etc/php5/apache2/php.ini with new version
invoke-rc.d: policy-rc.d denied execution of restart.
Setting up php5 (5.3.10-1ubuntu3.26) ...
Processing triggers for libc-bin ...
ldconfig deferred processing now taking place
Errors were encountered while processing:
openssh-client
ssl-cert
E: Sub-process /usr/bin/dpkg returned an error code (1)
The command '/bin/sh -c apt-get install -y git curl apache2 php5 libapache2-mod-php5 php5-mcrypt php5-mysql' returned a non-zero code: 100

@sungine did you manage to fix that? Just ran into it today.

I fixed it after disablind selinux and firewall on centos host


Navigation suggestion

On the new SharePoint admin center tab, click Access control - should be On the new SharePoint admin center tab, click Policies, then Access control.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1209ea6-15c8-1bb5-9837-608db57688b9
Version Independent ID: b02e1c55-5398-9a38-ba79-037f2b2a49f3
Content: Increased Microsoft 365 security for your Microsoft 365 Enterprise test environment - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/increased-o365-security-microsoft-365-enterprise-dev-test-environment.md
Service: o365-solutions
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

@challengelogic The article has been updated. Thanks for letting us know.


Log markdown for a run to Notes field or similar?

wandb --version && python --version && uname

Weights and Biases version: 0.9.2
Python version: 3.7.7
Operating System: Darwin

Description
Feature Request
I'd like the ability to programmatically log some markdown for a run.  Preferably, I'd like a way to log markdown information with the run as a whole, instead of associated with a step or other x-axis unit.   Notes are only available via the UI that I can tell, but I'd like to be able to generate some notes programmatically as markdown during the run and have them saved and displayed in the info pane of the run.
What I Did
I attempted to manually render some markdown containing the JSON definition of of my model and log it.
model_markdown = f"```json\n{model.json()}\n```"
wandb.log(
{"Model Definition": wandb.Html(markdown.markdown(model_markdown))}, step=0
)

The HTML entry is created, but not displayed very well.   All new lines and indents from the code block are removed.

I would rather standard code block rendering like so:
{
    "MLP": {
        "output_dim": 2,
        "layers": [
            {
                "Linear": {
                    "w": "shape=(10, 2)",
                    "b": "shape=(10,)",
                    "activation": "tanh"
                }
            },
            {
                "Linear": {
                    "w": "shape=(10, 10)",
                    "b": "shape=(10,)",
                    "activation": "tanh"
                }
            },
            {
                "Linear": {
                    "w": "shape=(10, 10)",
                    "b": "shape=(10,)",
                    "activation": "tanh"
                }
            },
            {
                "Linear": {
                    "w": "shape=(2, 10)",
                    "b": "shape=(2,)",
                    "activation": "identity"
                }
            }
        ],
        "input_dim": 2
    }
}

@sullivancolin the notes field accepts valid markdown.  You can pass it to wandb.init with the notes attribute.  Or you can run this after calling wandb.init:
wandb.run.notes = "# My Markdown"
wandb.run.save()

I've tried this work around, but keep running into
wandb: ERROR Error while calling W&B API: permission denied (<Response [401]>)
wandb: ERROR Invalid or missing api_key.  Run wandb login

when I get access the run object
run.notes = content
run.save()

Have you run wandb login from the command line?

We fixed the double login command for wandb login in version 0.9.4, you should be able to get it by upgrading.  Calling login should write a file to your home directory ~/.netrc with your credentials which wandb will then read.  If you're able to provide a simple example script that reproduces this issue that would help on our end.  This is really odd, if you're able to log metrics to the cloud you're definitely logged in so I'm not sure why saving is triggering an authentication issue.

I found the reason for the error accessing the run object.  It is a collision between the variable name run and the run command when using Pdb or iPdb debugger.  Changing the variable name of the run object, prevents that spurious error.
Upgrading to 0.9.4 solved the repeated login issue, thanks very much.
However run.save() throws an error
except handle
Traceback (most recent call last):
  File "test.py", line 15, in <module>
    run.save()
TypeError: save() missing 1 required positional argument: 'path'

I've can't find any documentation on that function.
I tried using the current run path which successfully ends, but I don't see the Notes displayed anywhere in the UI
Here is a complete script
import wandb

my_config = {
    "batch_size": 8,
    "learning_rate": 0.01,
}

run_obj = wandb.init(config=my_config, project="test_project")

run_obj.notes = "# My Markdown Header\n##Subheader"

#replace with hard-coded entity_name
path = f"<entity_name>/{run_obj.project_name()}/{run_obj.id}"

run_obj.save(path)

Also run.entity and run._entity both return None  but if I print out run.__dict__ I can see that the correct entity name is displayed.  It would be nice to be able access the entity property so I can re-use code elsewhere.

That error is really strange.  The save method for the run object is here.  There is no path argument to the save method.  I think you're using one of the release candidate builds for the new client library.  Try running pip install wandb-ng, then pip install wandb==0.9.4.

 Both these errors, were my fault!  So my setup.py had wandb>=0.9.4 and my Pipfile had allow_prereleases = true to install black and it installed a release candidate 0.10.0rc1.
Everything works now!  Thanks for the help!

Wow that did it!  Both errors were my fault.  I had setup.py with wandb>=0.9.4 and my Pipfile with allow_prereleases = true which installed the release candidate.
Everything works great now.  Thank you for all the help.


Can we make scanBatchSize as a configurable variable

In some cases, we can determine the number of KVs that need to be scanned in advance.
But now scanBatchSize is encoded as a constant:
const (
	scanBatchSize = 256
        ...
)

This is unnecessary and will increase scan time.
So, can we use scanBatchSize as a field of KVSnapshot and provide an API for users to set?

Duplicate issue, see #191


The new Directory show when we logout / login of Azure Portal

In the the point 4 of that documentation https://docs.microsoft.com/en-ca/azure/active-directory/fundamentals/active-directory-how-subscriptions-associated-directory, it mentions that it takes some time before new Directory appears in the Switching interface. After a few minutes after nothing showing up, I tried to logout / login of Azure Portal and my new Directory was in the Switching interface. Maybe it's a normal behavior and it should be documented in that page.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da261ee4-3348-b520-a27c-98f9d9ef40cc
Version Independent ID: 13d12189-ee46-8058-dd99-058adc69f1c5
Content: Add an existing Azure subscription to your tenant - Azure Active Directory
Content Source: articles/active-directory/fundamentals/active-directory-how-subscriptions-associated-directory.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @msaburnley
Microsoft Alias: ajburnle

@tremblaysimon
Thanks for your feedback! We will investigate and update as appropriate.

I agree that it would be useful to have a note here about sometimes needing to log out and log back in. I've made a pull request to add this.
Thanks for the suggestion, @tremblaysimon ! https://github.com/MicrosoftDocs/azure-docs-pr/pull/84232
@msaburnley


Fixing performance_ex1to work with triangles and tetrahedrons [perf-with-tri-fix]

This PR fixes

a crash when trying to run performance_ex1with matrix assembly and the hpc bilnearform, i.e. with flags -asm -perf, and
a crash when using a TPiecewiseConstCoefficient in the same example.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#4206
@aschaf
@v-dobrev
@YohannDudouit + @v-dobrev
3/26/24
4/9/24
⌛due 4/16/24

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

Thanks for the fixes @aschaf!
Please add the label ready-for-review if/when this is ready for review.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


chore(aesop_cat): remove unused configuration

Removes configuration for aesop_cat that is apparently unused.

This is dependent?

bors merge


Chinese: realease notes index

Add release notes

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rootsongjc
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [rootsongjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Allow customers to list their own orders

Closes #142

Codecov Report
Base: 97.81% // Head: 97.81% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (ccf3be9) compared to base (62cf95c).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head ccf3be9 differs from pull request most recent head 262b716. Consider uploading reports for the commit 262b716 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   97.81%   97.81%
=======================================
  Files         174      174
  Lines        2883     2886    +3
  Branches      156      156
=======================================
+ Hits         2820     2823    +3
  Misses         52       52
  Partials       11       11

Impacted Files
Coverage Δ

src/sales/orders/orders.controller.ts
100.00% <100.00%> (ø)

src/sales/orders/orders.service.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[DOC] Google search finds old doc page rather than latest

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[ X] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Google search for [opensearch term level query] finds the 2.1 version doc; [opensearch vector performance] finds the 1.2 version doc. I assume that there are similar problems with other pages.
How can we convince Google to prefer the current page?
There seem to be several problems with the current setup:

https://opensearch.org/sitemap.xml doesn't mention /docs/ at all. Putting new pages there makes it more likely that they will be crawled soon, and it also provides a place to communicate the last-modified date to Google.
on the page https://opensearch.org/docs/1.2/search-plugins/knn/performance-tuning/, the metadata says <meta property="article:published_time" content="2024-01-10T00:19:39+00:00" /> and the ld+json block shows the same for dateModified and datePublished. At the same time, https://opensearch.org/docs/2.11/search-plugins/knn/performance-tuning/ shows dates of 2024-01-19, only 9 days later. Surely 1.2 was published long before 2024.
There's the pink warning box that it's an old version at the top of these pages, with a link to "the current documentation". But for https://opensearch.org/docs/2.1/opensearch/query-dsl/term/, that's a link to the top level of the current documentation -- shouldn't it go to the latest version of the current page, as it does for example on https://opensearch.org/docs/1.2/search-plugins/knn/performance-tuning/?

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

Thanks, Stavros! We are currently working on a solution to address issues just like this. If you find anything else odd, please add it to this issue.

Closed by #7436, #7438, #7439, #7440, #7442, #7443, #7444,  #7445, #7446, #7448, #7449, #7450, #7451, #7453, #7454, #7455, #7456


Bug fixed at GraphCRF User Guide example.

Thanks :)

My pleasure!
El jue., 19 nov. 2015 a las 15:37, Andreas Mueller (<
<EMAIL_ADDRESS>escribió:

Merged #160 https://github.com/pystruct/pystruct/pull/160.
—
Reply to this email directly or view it on GitHub
https://github.com/pystruct/pystruct/pull/160#event-469516655.


Fix urllib3 version to 1.26.15

What does the code in this PR do / what does it improve?
Because from 2.0.0 urllib3 does not support OpenSSL versions older than 1.1.1. So triggered this failure: https://readthedocs.org/projects/straxen/builds/20440356/. Reference: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#what-are-the-important-changes.
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

Coverage: 93.469% (+0.02%) from 93.447% when pulling 2c9a1cc2a28c50acfcb9cfc51f4d646a62ef806d on fix_urllib3 into 306d98edeb597ebcf0a1b078e3750f57dc0aea8f on master.


add git metadata to Nunjucks

... so we can do conditional infra changes based on branches

implemented in 2894119a20e9d2d22e8063cc99cfa8cbe82b86b4


ROS 2 docs organization difficult to navigate

ROS 2 docs are difficult to navigate for several reasons:

Hundreds of pages in a mostly flat hierarchy (e.g. "Tutorials" – not enough subfolders)
Related items that aren’t grouped together meaningfully (i.e. info on a particular concept like ROS params is scattered across multiple sections and pages, Roadmap and Feature status/ideas are all separate pages, etc.)
Content is often duplicated across multiple pages in different sections (i.e. Tutorials vs. How-To Guides cover similar content in different ways)
Grounding info that helps users get the lay of the land is also spread across multiple pages (home page + Docs Guide page)
General copy editing – Large blocks of text, obsolete or deprecated information, not enough lists or subsections to help the user break up the huge amount of information, etc.

Short-term goal:

Rethink the hierarchy, ordering, and organization of the existing content to be easier to navigate and digest
Copy edit these existing pages for conciseness and clarity
Consolidate duplicated content across pages

Long-term goal:

Remove obsolete or irrelevant content
Consolidate more duplicated content across pages
Move less relevant content off to more appropriate sites in the ROS ecosystem
Consolidate sections that contain duplicated content (e.g. Tutorials and How-To Guides are not different enough to warrant an artificial separation)
Determine what content can be moved off into a “Miscellaneous” folder

Proposed 1st phase for making docs easier to navigate:

Tackle the introductory pages, Installation section, and Tutorials section.
Group the "Roadmap", "Feature status", and "Feature ideas" pages into one section

Proposed tasks for this phase:

Home and Docs Guide pages should be consolidated into one page and heavily copy edited for conciseness and clarity
docs.ros.org and home page should be explicitly added to the sidebar for easy discovery (not immediately obvious that the home icon or ROS logo gets you back to the home page)
Add explanatory subfolders where needed and revise page names to be less verbose / repetitive
Basic copy editing and formatting for conciseness and clarity

Tentative outline:

Introduction (current home page)
Installation

Introduction (combination of current “Installing the latest ROS 2 development” + “Maintaining a source checkout…” + “Alternative Installation Sources for Testing” pages)

Linux (subfolder)

Ubuntu Linux
Fedora Linux

Debian Packages (subfolder)
macOS (subfolder)
RHEL (subfolder)
DDS (subfolder)

Tutorials

Configuring your environment
Understanding the ROS 2 graph

Prerequisite: Setup with turtlesim + rqt
Nodes, topics, and services (consolidate these pages)
Parameters

Using parameters in a class

C++
Python

Monitor changes

C++

Actions

Creating an action
Writing an action server and client

C++
Python

Viewing logs
Launch

Introduction (Current “Introducing ROS 2 launch”)
Rest of pages in Launch Tutorials

Recording and playback

Recording a bag from your own node

C++
Python

Creating workspace _ first ROS 2 package
Writing a publisher and subscriber

C++
Python

Writing a service and client

C++
Python

ROS 2 Security

Introduction
Understanding the keystone
Across machines
Network traffic
Access Controls

[[OTHER PAGES AS IS]]

[[OTHER SECTIONS AS IS]]
Current status and roadmap

Features status
Roadmap (will include feature ideas)

Would be happy to open a PR for this, if this outline and direction look good.

In general, a reorganization of the information to make it easier to navigate is long overdue.  So thanks for starting the conversation.
I have specific quibbles with your outline, however, particularly around the Installation pages (the "development setup" should probably be the last thing in the list, not in the Introduction), and around the Tutorials (the general idea is we want to steer people towards the "Beginner" tutorials as a group to start with, and then direct them to specific tutorials for other things).  That said, I'm happy to review pull requests towards something like the above, and I can point out my specific quibbles in the individual pull requests.
I have a couple of general comments when opening pull requests to move towards the following:

Make sure to open, small, bite-sized pull requests to make the changes you want.  If you open one giant one, it's going to be impossible to review and much more likely to introduce regressions.
If you move the URLs of pages around, make sure to put redirects in them.  An example of doing this is https://github.com/ros2/ros2_documentation/blame/rolling/source/How-To-Guides.rst#L1 , where we make sure to redirect from https://docs.ros.org/en/rolling/Guides.html (the old name) to https://docs.ros.org/en/rolling/How-To-Guides.html .  This goes for removing pages as well; if you remove a page, make sure to add a redirect-from on the page that contains the de-duplicated content.

But besides that, I welcome these changes and look forward to your help!

@esthersweon We've now merged in a lot of your great work to help fix this:

https://github.com/ros2/ros2_documentation/pull/2453
https://github.com/ros2/ros2_documentation/pull/2455
https://github.com/ros2/ros2_documentation/pull/2461
https://github.com/ros2/ros2_documentation/pull/2465

Looking at the state of the current site, I think the last two things would be to somehow organize "How-to Guides" as well as "Concepts".  Both of those are a little harder as there are no clear lines around which to organize, but maybe we could do something.
@esthersweon Are you interested in trying out those two?  Or are you happy enough with the site as it is to leave it be and to close this issue?
(as I've said before, thanks so much for your work here)

So we did end up revamping the Tutorials, thanks to the work of @esthersweon .  We also have an open PR to reorganize the Conceptual documents in https://github.com/ros2/ros2_documentation/pull/3732 .
Beyond that, I don't have a concrete plan for more reorganization.  I'm going to close this one out, and we can always consider rearranging more in the future.


Ensure upcp and backups cannot run at the same time as ELevate.

Case RE-138: This commit makes it so scripts/upcp and bin/backup are removed early in stage 2 so cron or another entity cannot run them during the ELevate process.
Changelog: Ensure upcp and backups cannot run at the same time
as ELevate.
By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf

This is replaced by #399


fix: reconcile Pooler imagePullSecret

This patch ensures that, in case we own the Pooler ìmagePullSecret, we keep it with the contents contained in the operator imagePullSecret.

/test limit=local

/test limit=local

/test limit=local


Move generation to a single executable

I open this PR with some initial ideas so we can start discuss on the solution.

[x] Depends on #1113
[x] Depends on #1136
[x] Depends on #1144
[x] Depends on #1151
[ ] Depends on #1158

@swift-ci Please test


Listen for events on particular element or control, outside ScreenController?

As the title says, is it possible?
Something like this:
Button button = screen.findNiftyControl("myButton", Button.class);
button.addEventListener(new SomeInterface() {
    public void click() {
        System.out.println("Clicked myButton!");
    }
});

No, it's not possible. All event handling is done in a Controller ( as far I can tell ). In this issue #290 I was addressing something similar but now I don't have time to work in nifty, unfortunately :cry: .

If you would be willing to use the EventBus then it would be possible. The Nifty manual describes this on Page 81 how to listen for EventBus events on any instance:
You'll need to call nifty.subscribeAnnotations() with an instance of your class.
Nifty will then scan the given instance for all @NiftyEventSubscriber annotations
and subscribe all of them with the EventBus.

If you don't need your object anymore you should call nifty.unsubscribeAnnotations()
with the instance again to unsubscribe all annotated methods.

With the basic event handling, the interact methods, I think relu91 is right. Theoretically you could try to attach a ElementController to the element in question though. This way all interact methods will be first looked up on the ElementController and second on the ScreenController. This is explained in the manual as well. I think this will work for basic elements.
However the controls, like the Button control in your example already use this feature to add their own event handling to themself already. I'm not sure what happens when you add your own EventController on top of that :smile: Might work but I'm not sure. In retrospect a lot of Nifty is awkward :wink:
I'd suggest going the event way tho.

Looks like @void256 and @relu91 have sufficiently answered this question. Reopen if there are any further issues.


Multiline comments

Hi
Q: Is it possible to comment on multi lines while reviewing?

Hi @isgj, currently this is not possible, but there's an open feature request for this: https://github.com/microsoft/vscode-pull-request-github/issues/1376


[feature] Export User Account [OSF-8196]

Purpose

Adds a management command for exporting user accounts.

Exports all of the projects, preprints, and registrations for which a user is a contributor.
For each node, wikis, files, and basic metadata will be exported.

Side Effects

This could be horrendously slow, depending on how many nodes/files the user has.

Ticket

OSF-8196

Also got this error when trying to export my own account:

PROJECTS[==================================================] 100.0% ... 70

Traceback (most recent call last):------------------------------] 8.8% ... 34
  File "manage.py", line 21, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/django/core/management/__init__.py", line 363, in execute_from_command_line
    utility.execute()
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/django/core/management/__init__.py", line 355, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 264, in handle
    user_id=options['user'],
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 234, in export_account
    export_nodes(registrations_to_export, user, registrations_dir, 'registrations')
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 158, in export_nodes
    export_node(node, user, current_dir)
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 131, in export_node
    export_node(child, user, current_dir)
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 123, in export_node
    export_files(node, user, current_dir)
  File "/Users/sloria/projects/cos-projects/osf/osf/management/commands/export_user_account.py", line 92, in export_files
    .format(node._id, response.status_code, response.json())
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/requests/models.py", line 886, in json
    return complexjson.loads(self.text, **kwargs)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/simplejson/__init__.py", line 505, in loads
    return _default_decoder.decode(s)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/Users/sloria/miniconda/envs/osf/lib/python2.7/site-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.scanner.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

please investigate


BitVecDeque?

I love BitVec, but really need something like a BitVecDeque so I can have an efficient bit queue (push back, pop front).  Is this possible with BitVec as it is, or would this be an enhancement?

It is immediately available with this hack: pop_front is .rotate_left(1).pop(), and push_front is .push().rotate_right(1). I have not yet looked at VecDeque in any depth, and so have not made any plans for its API to be ported.
Implementation details of BitSlice pointers allow any object using them to move their starting position up and down inside an element without any cost. BitVec does not currently expose an API to push or pop at the front, though there is no underlying restriction on doing so as long as you are willing to accept that when these events depart the base allocation address, the vector must move its buffer contents within the allocation.
I do not plan to make a channel equivalent at this time, so BitVec alone cannot be split across threads for concurrent add/remove operations.
I can add push/pop front methods in a future release. In the meantime, let me know if the behavior of the described workaround is sufficient.

The workaround is fine for now, thank you!

The implementation I assumed I had in play when I wrote this reply is a behavior that I scrapped in favor of a simpler, safer, but  more naïve version. BitVec can play much more fast-and-loose with its buffer than BitSlice can, so I'll write an actually-intelligent version of push_front and pop_front in the near future.
.rotate_left(1) moves every bit in the slice; this is not necessary in most cases. If it's a reasonably small vec, it'll still be pretty quick, but I can do better.


[BUG] ConductorConfig.class:getFullAppPath() throws error if appFile ends in .app

The problem
The new logic in the getFullAppPath() method checks the appFile specified in the yaml, and checks if the appFile is a directory. Files that end in .app are being interpreted as directories and causing an error when we try to list the files in the directory.
Environment

Conductor-Mobile Version: 0.19.0
Last Conductor-Mobile version that did not exhibit the issue (if applicable): 0.18.0
Desktop OS/version used to run Conductor-Mobile:
Mobile platform/version under test: iOS 11
Real device or emulator/simulator: simulator
appium-doctor results are passing []: yes

Details
I'm not sure why .app files are returning true for isDirectory(), but we should figure out why that is and either use a different method, or add an extra condition for seeing if the app/directory file ends in .app
Link to Appium/Conductor-Mobile logs
Create a GIST which is a paste of your full Stacktrace, Appium logs, and config.yaml contents. Link them here.
Do NOT paste your full logs here, as it will make this issue very long and hard to read!
If you are reporting a bug, always include Relevant logs, please!
Code To Reproduce Issue [ Good To Have ]
public String getFullAppPath() {
        if (this.appFile == null) {
            return null;
        } else {
            File dir = new File(this.appFile);
            Path path = Paths.get(this.appFile);
            if (dir.isDirectory()) {
                try {
                    String expectedFileExtension = this.platformName == Platform.ANDROID ? ".apk" : ".app";
                    File[] files = dir.listFiles((dir1, name) -> {
                        return name.toLowerCase().endsWith(expectedFileExtension);
                    });
                    if (files != null && files.length == 1) {
                        File fileFoundMatchingExtension = files[0];
                        return Paths.get(System.getProperty("user.dir"), fileFoundMatchingExtension.toString()).normalize().toString();
                    }

                    throw new IllegalArgumentException();
                } catch (IllegalArgumentException var7) {
                    Logger.error(var7, "Unable to find a valid application in specified appFile directory: {} . Make sure there is only ONE unique file extension in {}, or else you must specify an absolute path. Also, double check that there is indeed an application with a valid extension in the specified appFile directory. ERROR", new Object[]{dir, dir});
                }
            } else if (this.appFile.startsWith("sauce-storage:") || path.isAbsolute()) {
                return this.appFile;
            }

            try {
                new URL(this.appFile);
                return this.appFile;
            } catch (MalformedURLException var6) {
                return Paths.get(System.getProperty("user.dir"), path.normalize().toString()).normalize().toString();
            }
        }
    }

appFile: ./apps/IOS/IOS.app

@aaron-goff
Oh! I think it's because .app files are actually directories hahaha, they have all those files in them.

I had so many tests for this and was really confused why it wasn't working! Turns out my test app was not as true as it should have been.

Also throws error if using sauce storage. Fixing this.