Space in date format throws error in 7.0.1

My tests are failing when updating to v7.0.1 seems to be an issue with spaces in the date format:
Works:
export default Ember.Controller.extend({
  today: new Date(),
  niceToday: format('today', 'MMDDYYYY')
});

Fails:
export default Ember.Controller.extend({
  today: new Date(),
  niceToday: format('today', 'MM DD YYYY')
});

The failing version spits out the error:
Brace expanded properties cannot contain spaces, e.g. "user.{firstName, lastName}"
I wasn't able to get ember-moment to install in a twiddle, but this is pretty easy to reproduce.  I can submit a failing test PR if desired.  Just need some guidance on where it belongs - can I put it in the smoke tests?

7.0.1 was a bad release, are you still seeing issues on 7.1.0

@kellyselden good call.  I just reverted your commits, wrote a test to cover this in the future, and versioned 7.1.1.

Closing as this is resolved in 7.1.1, we'll open a new issue for tracking adding back the computed helpers.

I wasn't seeing a failure when adding the test into format-test.  I assume because the actual CP goes through layers, but the unit test just runs against the function itself. That is pure speculation, but it is where I gave up.

@jrjohnson master is fixed and I wrote a test to cover this in the future.
Reverting the revert and running the tests currently should fail:
not ok 68 PhantomJS 2.1 - controller:test-subject: can contain spaces in the format argument
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/vendor.js:23019
        message: >
            Died on test #1 testWrapper@http://localhost:7357/assets/test-support.js:7165:16
            test@http://localhost:7357/assets/test-support.js:7179:44
            http://localhost:7357/assets/tests.js:654:24
            exports@http://localhost:7357/assets/vendor.js:132:37
            requireModule@http://localhost:7357/assets/vendor.js:32:25
            require@http://localhost:7357/assets/test-support.js:6945:14
            loadModules@http://localhost:7357/assets/test-support.js:6937:21
            load@http://localhost:7357/assets/test-support.js:6967:33
            http://localhost:7357/assets/test-support.js:6850:22: Assertion Failed: Brace expanded properties cannot contain spaces, e.g. "user.{firstName, lastName}" should be "user.{firstName,lastName}"
        Log: |
    ...

Hmm... Wonder why I was getting a failure there.  Doesn't matter - just wanted to make sure you were so tests would actually cover the issue.  Thanks for the quick response to this.


Default settings dialog should say "would like" instead of "needs" wrt il2cpp

Overview
When running on Unity 2018, there is no requirement to use IL2CPP (.NET backend still exists, MRTK is compatible with the .NET backend), so technically MRTK does not need to switch backends.
This will also make the language more consistent with the prompt at the bottom of the dialog ("Would you like to make this change?").
When 2019 is detected, this dialog should not be shown as that version of Unity does not contain the .NET backend.
Unity Editor Version
2018.3.12f1
Mixed Reality Toolkit Release Version
v2 RC1

Does this still matter after this change?
https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/3964

it may not be. i will pull the latest and double check whether or not this is a duplicate

closing as a duplicate


Support for data-month? or even data-day

Does this plugin drill down to month or day level?

Not in it's current version. Feel free to contribute and make a pull request.


⚠ TorrentLeech has degraded performance

In 71506dc, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 6405 ms

Resolved: TorrentLeech performance has improved in 03be1d5 after 7 minutes.


removed unnecessary label on Tab component

Fixes Issue

closes #9521
Changes proposed
Removed a unnecessary label on Tab component
The Tab component is used on two places SubNav  and UserTabs component

Check List (Check all the applicable boxes)

[X] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests passed.
[X] This PR does not contain plagiarized content.
[X] The title of my pull request is a short description of the requested changes.

Screenshots

Before changes:

After changes:

Note to reviewers

How about renaming the label and centering it and calling it may be🤔;

Choose a category
or
Filter by Interest
or
3.Select a Section


Install APT repository tools and https support

To support Docker installation: sudo apt-add-repository 'deb https://apt.dockerproject.org/repo ubuntu-xenial main'
Fixes #7.

Ready to merge - apologies for the hassle.

Looks good - merging!


DSA 2.1 Binary Strings (Problem 2) - Documentation

Description
Given a binary string str, how can you remove the minimum number of characters from the given binary string such that the characters in the remaining string form a sorted order.
Important: Do not use assign command for this issue.
Task

[ ] Documentation

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

can you assign this issue to me?
Raj Madhu
Batch - 6

@nimisha-yadav
Kindly assign this to me.
Motasim (Batch 01)

@nimisha-yadav Kindly assign this to me.
Motasim (Batch 01)

Assigning this issue to you @motasimmakki, all the best!

@nimisha-yadav
Kindly review PR #4428


Doesn't support rubocop -x flag

nnoremap <leader>rc :w<CR>:RuboCop<CR>
nnoremap <leader>rcf :w<CR>:RuboCop -x<CR>

The second mapping runs RuboCop but the output is always empty. -x does quick fixes like -a does, but only formatting fixes.

I'm no longer able to replicate this for some reason. Closing.


⚠ Bofrost.com has degraded performance

In 8be2f6c, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 803 ms

Resolved: Bofrost.com performance has improved in 0acd332.


Open Page UI - Search field

Search Field instruction:
"Enter the name, address, ID or any other keyword of the entity you are looking for. "


Enabling NSG Flow logs will cause a dependency failure

Describe the bug
Enabling NSG Flow logs will cause a dependency failure
To Reproduce
Steps to reproduce the behavior:
1.In the Networking Details tab
2. Enable "Limit Ingress/Egress subnets with Network Security Groups (NGS's)"
3. Enable "Capture NSG Flow Logs with Network Watcher"
4. Causes the dependency error below
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
  "details": [
    {
      "code": "ResourceGroupNotFound",
      "message": "Resource group 'NetworkWatcherRG' could not be found."
    }
  ]
}

Expected behavior
Enabling both NSG option would not cause a dependency issue.
Screenshots

Looked into this. First investigation showing no issues. Deployed with both options ticked and no issues caused. I will reach out to Adrian for further details to see if I can replicate the issue.

I think it depends on if the subscription already uses Network Watcher in that region.


Errors in the output of C implementation

I found that the two embeddings generated by the c implementation are same. I think the last line of code is not correct. Should be saveEmbedding(embedding, FLAGS_emb2);

Bug Fixed.


Try multiple commands to find windows version

Signed-off-by: David Gageot<EMAIL_ADDRESS>

Bringing some code from me back from the dead... LGTM


Add MaaS Alarms for swift replication time

Add a rate increase alarm for object/container/account replication
Add an average time threshold alarm for object/container/account
replication.
Closes-Issue: #655
(cherry picked from commit 108b00f7e2dcc5d1241f0b44b640e063c8da47a9)
Signed-off-by: Matthew Thode<EMAIL_ADDRESS>

recheck

notmyfault?

:+1:


[Suggestion] Add support for wsrv.nl image proxy.

wsrv.nl is an open source image proxy, it can resize items easily.
It is open source (https://github.com/weserv/images) and is extremely easy to use. I would implement this myself as it would be pretty easy to implement (a few changes in url arguments), but I'm really bad at go.

@Hellscaped  Curent resizer works very well its alos  uses libvips underhood

@Hellscaped Curent resizer service works very well its also uses libvips underhood

Yes, but there are many wesrv public instances that one can use instead of running their own of your implementation.

That is true but it will not work on local instance of teldrive  if teldrive is deployed on public server then it could work

@Hellscaped Curent resizer service works very well its also uses libvips underhood

Which service currently works with teldrive? I was trying to find what to put in the Image Resizer Host but couldn't see any info.


Getting error for "AWS Account ID not allowed"

Hi I have an issue trying to run this out of the box - I get the error AWS Account ID not allowed:
After some digging around I understood that I need to change account.hcl
I was wondering about two things -

Should this be added to the README as it is not mentioned anywhere except the comment in the file itself?
Is there a way to inject this var using an environment variable or something like that, so it wouldn't be necessary to change the files?

Thanks

Should this be added to the README as it is not mentioned anywhere except the comment in the file itself?

Yes please! Would you be up for a quick PR to add this?

Is there a way to inject this var using an environment variable or something like that, so it wouldn't be necessary to change the files?

There is, but you most likely won't want to. The main use of the account ID is to ensure you're deploying to the right account. Hard-coding that value in a file provides that protection (albeit at the cost of a little extra work up front). Reading that value from an environment variable makes it too likely you'll happen to have the wrong value set.


Trace fix

Ability to push an new TraceComponent into a TraceDB list property. Support for pushAll operator as that fits our usage better.

Change service impl to update without upsert whenever possible

Testing -

With 5 and 10 actionrunners started off the same workflow with nested workflows multiple time (10 or so). Passed in the same trace_id to the execution in order to guarantee writing to the same trace thus causing contention and previously seen racing behavior. All workflows passed and trace was updated properly.

Ready for review but I still need to stress test the change. Also, change will be added to next patch

LGTM

Ignoring scrutinizer


Please add git tag

It's better to use semantic versioning with git tags - dep and go mod will automatically fetch tags as available versions.
Tag is immutable (until force push used), so it's more reliable to avoid pulling breaking changes when library updates.
Can you please add tag v1.0.0 or v1.0 to this repository?
git tag
git tag v1.0
git push origin v1.0

ping @tomasen


Support Grails 3

given Grails-3.0.0 just reached M2 and a final is planned to be released soon, it would be nice to see this plugin work with Grails 3 :)
(similar issue for grails-cxf here: https://github.com/Grails-Plugin-Consortium/grails-cxf/issues/45)
thanks, zyro

Will be working on it soon along with a cxf upgrade.  Working on redis plugin now.

Any updates on the Grails 3 migration? We are looking to update and depend on this plugin. Thanks.


Make this a built-in skin?

Have you considered sending a pull request to cactbot for this, like https://github.com/quisquous/cactbot/pull/4805?

That would be the smart thing to do, wouldn't it xD Thank you! I'll do it this week.
And sorry for the tardy reply, I only just checked my notifications (in 3 months! yikes)

Completed in https://github.com/quisquous/cactbot/pull/5193


StoreReader not working after version update

Problem Description
After the update on MacOS Sequoia, we had to update the package version of verge to the latest version. Previously in our app, we used the @StoreObject wrapper together with StoreReader in SwiftUI and we could use this for live updating the state. After the version update, the state updates are only reflected within the UI after the app is pushed to the background or out of focus. Do you  have any idea, why this might happen? There were two changes we noticed that we adapted:

DispatcherType was replaced by StoreDriverType
primitiveState was replaced by state.primitive

Versions
Verge: 12.5.0
MacOS: 14.6.1 (23G93)
XCode: Version 16.0 (16A242d)

I see. I can see it later but can you make a project for reproduction?


Fix color coding issue on details tab and make openedAt and closedAt human readable

The reporting boolean is required on the details tab in order for the entries to be color coded. Added reporting to the entities sent for rendering.
The openedAt and closedAt time stamps were returned as epoch integer. Changed the output format to date strings to make them more readable.

@bobj82 it looks like you've submitted the package-lock.json file in this PR, can you remove that from the PR? this is resulting in a change of over  + 13,708 lines of code

Ready to merge.

@zstix just let me know if this ok to merge in.

RTM


[Bug]: Filter CO-data attribute search function not working

Steps to reproduce the bug
1. Want to search COs from Mayotte using Data Attributes
2. Scroll down to Data Attributes
3. Under Predicate, type country
4. Add Mayotte
5. Filter
Zero results filtering for any data attribute under Predicate
...

Screenshot

Expected behavior
When I filter collection objects using data attributes, I would expect results similar to those in the CE filter.
Filtering data attributes work in the CE filter but it is an extra step to then filter the CEs to COs.
Additional Screenshots
No response
Environment
Production
Sandbox Used
No response
Version
v0.40.0
Browser Used
Chrome Version 123.0.6312.86

I can't replicate this.

My data are not the same as production (I've been messing with it offline), but see:

Those are filter results for the CE records I believe. The CO filter is not returning results.

Oh, I see. The data attributes there are for CollectionObjects, country is a Predicate used on CollectingEvents, so that's why you see nothing here.  The DataAttribute search only searches on Predicates used on this object type, not on predicates linked through other object types.  You'll have to search on CEs first, then pass that here.

It would be extremely valuable to have all of the predicates linked to the COs as well so we do not have to do a two-step filter. One of our most used filters would be finding COs for countries. The GA sort of works but our country predicate is more accurate with regards to filtering.
@bpescador

We added a note via the orange ? help to clarify this function of facet.  At this time, as we don't plan to extend this functionality further becaused of the conceptual and implementation complexity it would introduce I'm going ot close this.


reactor async send handle

reactor async send handle will be use the same one

the send message have be used the same async handle!


cargo-miri: better error message when RUSTC is not set

Currently, when running cargo-miri instead of cargo miri you get a very confusing.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NotPresent', src/tools/miri/cargo-miri/src/main.rs:83:41

error. This replaces that with a message telling them to use cargo miri

Thanks, that should certainly be better!
We will still do something very confusing if people happen to have set RUSTC in their environment, but that is less likely I guess.
@bors r+

:pushpin: Commit 28d25d0f30ff62de17f314c3480589e4a1a1f619 has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 28d25d0f30ff62de17f314c3480589e4a1a1f619 with merge 181a04a32b74a2d811225a1eed5e7ca00dab4d69...


Auto detect backend type in converters and interfaces

From https://github.com/catalystneuro/neuroconv/pull/802#discussion_r1590171140

Looks good!


Deserializer error : Expecting data with Confluent Schema Registry framing. Magic byte was 48, expecting 0

Description
When using the AvroDeserializer class to deserialize a message with a defined schema in the schemaregistry, I get the following error:
Value deserialization error
Expecting data with Confluent Schema Registry framing. Magic byte was 48, expecting 0
The schema registry being used is Apicurio Registry by the upstream Java application. I used avrogen to generate the classes used for deserialization.
Any suggestion or sample code to solve the issue?

AvroDeserializer expects avro serialized data with specific framing (magic byte of 0, then schema id). it looks like however you produced the message data did not also produce the framing expected by AvroDeserializer.

The producer application is a java based application and the settings at their end are :
spring.kafka.consumer.key-deserializer=org.apache.kafka.common.serialization.StringDeserializer
spring.kafka.consumer.value-deserializer=io.apicurio.registry.serde.avro.AvroKafkaDeserializer
spring.kafka.consumer.properties.apicurio.registry.use-specific-avro-reader=true
spring.kafka.consumer.properties.apicurio.registry.url=${kafka.schema.registry.url:}
The error being received is in .NET consumer application

@insighter1 if this is still an issue can you add more details?


Git file content

This PR contains a better,stable algorithm for getting file content from version control (git).

bad PR, too many artefacts. conflict with other PR


Replace Betcha menu with Finalize Submission button.

Fixes https://github.com/source-academy/cadet-frontend/issues/356.

Pull Request Test Coverage Report for Build 822

2 of 3 (66.67%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 25.831%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/assessment/index.tsx
2
3
66.67%

Totals

Change from base Build 821:
0.04%

Covered Lines:
896

Relevant Lines:
2940

💛  - Coveralls

PS C:\Projects\cadet-frontend> yarn update-ui-snapshots
yarn run v1.9.4
$ jest --updateSnapshot
No tests found
In C:\Projects\cadet-frontend
51 files checked.
testMatch: /tests//.js?(x),**/?(.)(spec|test).js?(x) - 0 matches
testPathIgnorePatterns: \node_modules\ - 51 matches
Pattern:  - 0 matches
error Command failed with exit code 1.
Possibly windows folder separators.

@blackening I've invited you to the organization, please make a branch off master in this repo and I can help you with updating the tests

Closing, converting to pull request from local branch.


Update dates helper test

Here are the tests for this pull request

https://github.com/bullet-train-co/bullet_train-core/pull/182

I deleted some of the assertions because we deleted the following over in there:
if local_time(timestamp).to_date == local_time(Time.now).to_date
  "Today at #{display_time(timestamp, custom_time_format)}"
# yesterday?
elsif (local_time(timestamp).to_date) == (local_time(Time.now).to_date - 1.day)
  "Yesterday at #{display_time(timestamp, custom_time_format)}"
else
  # ...
end

@gazayas If we close https://github.com/bullet-train-co/bullet_train-core/pull/182 in favor of https://github.com/bullet-train-co/bullet_train-core/pull/334 then do we still need this PR?

@jagthedrummer Now that I'm looking over these PRs again, I'm thinking I want to leave https://github.com/bullet-train-co/bullet_train-core/pull/182 and this PR open for the time being. The reason being that, these PRs display time objects as is (i.e. - "Wed, 02 Aug 2023 10:51:29 +0000") whereas https://github.com/bullet-train-co/bullet_train-core/pull/334 changes how the time objects are processed but doesn't change the strings themselves such as "Today at 12:00 P.M." which can be seen in the dates helper, so I want to wait until https://github.com/bullet-train-co/bullet_train-core/pull/334 is merged to see how things play out. Sorry! 🙇♂

No problem @gazayas, that sounds totally reasonable. I'll see what I can do about reviewing and merging https://github.com/bullet-train-co/bullet_train-core/pull/334 and then we can take it from there.

Hey @gazayas I just merged https://github.com/bullet-train-co/bullet_train-core/pull/334. Will be interested to see what you decide about this PR and https://github.com/bullet-train-co/bullet_train-core/pull/182.

I suspect that the tests might be failing due to them relying on changes made in https://github.com/bullet-train-co/bullet_train-core/pull/182.
@gazayas, if you can push this branch into the main starter repo (instead of your own fork) then both the starter repo and the core repo should be able to find the dependent branches and then hopefully tests will pass on both.

I suspect that the tests might be failing due to them relying on changes made in bullet-train-co/bullet_train-core#182.
@gazayas, if you can push this branch into the main starter repo (instead of your own fork) then both the starter repo and the core repo should be able to find the dependent branches and then hopefully tests will pass on both.

@jagthedrummer Sure thing, I'm having some trouble trying to push it directly, so I'll submit a new PR!


vsr: preallocate reads for commits

There are two reasons to read prepares from the journal:

commit path via commit_journal_next and primary_repair_pipeline
repair path via on_request_prepare

Previously, the two paths shared read IOPS, so repair might actually starve commit (in a situation with a sole replica and a bunch of standbys, that actually triggered an erroneous panic, see the VOPR seed).
Now, we reserve one IOP for commit path, so that it can always proceed normally.
SEED:<PHONE_NUMBER>9551265853
Closes: #739
Pre-merge checklist
Performance:

[X] I am very sure this PR could not affect performance.

Interesting, it looks like assert(journal.reads_commit_count <= journal.reads_commit_count_max); is triggered in the Cluster tests: https://github.com/tigerbeetledb/tigerbeetle/actions/runs/4833199625/jobs/8612910133?pr=740

Interesting, it looks like assert(journal.reads_commit_count <= journal.reads_commit_count_max); is triggered in the Cluster tests: https://github.com/tigerbeetledb/tigerbeetle/actions/runs/4833199625/jobs/8612910133?pr=740

Yeah, see the second commit. This actually a pre-existing perf issue -- we release the read in defer, after we invoke callback, so the callback doesn't get as much available iops as we can give to it.


Add logged in user route to internal.yaml

Description
Add a route to get user information for the logged in user to internal.yaml
Reviewer Notes
I'd love suggestions for a better name for a user that is allowed to view/edit a service member's profile/move than "Designated Backup"
The idea behind the type field is that when a user is created (which happens when someone logs in with login.gov for the first time) it is in the UNKNOWN state. We will then at some point designate them as either a SERVICE_MEMBER or a DESIGNATED_BACKUP which will show different UI and probably give a slightly different route to the service member id and current move id.
Code Review Verification Steps

[ ] All tests pass.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
[ ] There are no aXe warnings for UI.
[ ] This works in IE.
[ ] Any new third party client side dependencies (e.g., login.gov, google analytics, CDN libraries, etc.) have been communicated to @willowbl00.
[ ] Request review from a member of a different team.
[ ] (TRIAL) Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

What about USER_PROXY?


Allow Specifying Additional PodMonitor Labels

Hi!
I'd like the ability to provide additional labels that are added to a Cluster's PodMonitor when it's created.
In my cluster, I'm using the Prometheus Operator to set up scraping, and the Prometheus instance is set up with specific PodMonitor or ServiceMonitor labels to specify which Prometheus instance should scrape it.
I had some thoughts about something like:
monitoring:
  podMonitor:
    enabled: true
    additionalLabels:
      someLabel: withValue

But that would duplicate the existing enablePodMonitor value, so I thought I'd create this and see what you all think!

I have a similar situation. In my case, I need to specify the prometheus release name in the PodMonitor labels it it won't get scraped. My case requires the following:
My case is:
monitoring:
  podMonitor:
    enabled: true
    labels:
      release: prometheus

P.S. I suggest calling it just labels as opposed to as that's what most charts use.

@aphistic @itay-grudev hi!
What about following the same behavior like the one described here or you think that the PodMonitor will require their own specific labels?

@sxd Oh! Are those labels also applied to PodMonitor (or any resource related to the cluster)? If that's the case, I don't think there needs to be a separate set of options, but it might make things cleaner by avoiding superfluous labels.
In my case, the labels I apply are something like metrics.mydomain.com/scrapeScope=cluster or metrics.mydomain.com/scrapeScope=postgres if I want a different Prometheus instance ("cluster" vs. "postgres") to scrape the metrics. These labels are set, for example, via the podMonitorSelector in the Prometheus Operator's Prometheus CRD.
Those labels could be added to the cluster, but then you might have metrics.mydomain.com/scrapeScope=postgres on the StatefulSet where it wouldn't be needed/might add confusion.

@aphistic well, yes the labels are inherited by the podmonitor object too https://github.com/cloudnative-pg/cloudnative-pg/blob/main/controllers/cluster_create.go#L817 can you try this feature and check if that works for you ?
We don't use a StatefulSet so, no it will not hit any StatefulSet =)
Please let us know, in the meantime I'm turning this into a discussion!
Regards,


📃: Next.js Image to Text website project

:red_circle: Title : Image to Text website project
:red_circle: Aim :
:red_circle: Tech Stack Used :  Next.js
Screenshots 📷

:white_check_mark: To be Mentioned while taking the issue :

Full name : Utsav Ladia
What is your participant role? (Mention the Open Source Program name. Eg. GSSOC, SSOC, JWOC, etc.)
GSSOC

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

@Utsavladia go ahead.

What's the update?


Proposal for even simpler sampling controls

In the vein of making the controls easy for beginner users and then allowing them to go more advanced, I'm proposing making the sampling panel even more simple in "Easy mode".
Here's how we could do it:

The render type would change integrators and settings like caustics, etc.  Quality/Time slider would drive the max samples and pixel variance.
Vray does something similar:
https://www.youtube.com/watch?v=buTEc5mrURg

Thoughts?

Looks promising.  It will certainly help make RenderMan a bit less scary for people.  Actually those settings would make it more straightforward to use than Cycles.....
Only snag I could see is the numbers in the Quality/Time slider.  It's possible some might associate that with actual time (minutes, etc....) instead of a 'quality percentage'.  not sure if you can really get around this though, it's just nit picking.

Certainly could be labeled however you want.  Ideally, you'd like to give a time "estimate" for a given quality level.   I have some ideas how to do that...

That'd be interesting to see.  I'll admit I'm really curious how you would tackle that.

Actually i see no point in this. There are only 4 values in general.
I would spend more time for viewport textures and shaders display.
Also, material nodes need more love i think.

Its aimed at someone with less experience than you.  What do you mean by
"material nodes need more love".
On Tue, Aug 25, 2015 at 11:39 PM, mifth<EMAIL_ADDRESS>wrote:

Actually i see no point in this. There are only 4 values in general.
I would spend more time for viewport textures and shaders display.
Also, material nodes need more love i think.
—
Reply to this email directly or view it on GitHub
https://github.com/bsavery/PRMan-for-Blender/issues/121#issuecomment-134859793
.

--
<EMAIL_ADDRESS>508-274-8700

PrPatterns are too big and i think it could b splitted to more groups like in Cycles.
Like:
Texture
Color
Vector
etc.

Also, I did not find RGB Curves node which is super cool for RGBA tweaks. Is it possible to add it?

You bring up a good point with the categories.  I'm going to split that to another issue to keep this discussion on track.  RgbCurves might be a bit more difficult but let me think about it.  It's basically a spline...

Brian,
Have you thought about this one further?  My list of projects is kinda bare so I'd be happy to tackle it.


Add .pep8 and .pylintrc, for #282

Here is what the defaults would look like to make the generated project pass most of the strict checking.
With these .rc files, prospector shows only 8 violations currently, all minor and easy to clean up.

Are we supporting prospector in any ways. These seem to be me duplicate configurations and will also add blot to project. @pydanny @luzfcb ?
I'm happy adding things to setup.cfg, where flake8 rules are already added[1].
[1] https://github.com/pydanny/cookiecutter-django/blob/master/{{cookiecutter.repo_name}}/setup.cfg#L1-L4

The two files are not specifically for prospector, they are for pep8 and pylint respectively, in their default locations ( prospector is just a convenient wrapper to run a long suite of of the linting tools easily, but is not related to these config files )
Maybe a configuration-time question to which linting tools to pre-configure, to avoid bloat ? "use linting:" and a choice of flake8, pylint and pep8 ?

@theskumar Normally I'm against any kind of duplication, but since this one is designed for coders using a set tools to check code-smell, it might be worth including.
As for including a question about which files to include at generation time, I would be all for that BUT windows breaks when you use logic in cookiecutter template or directory names. :unamused:

I not use prospector directly, but only via landscape.io
I still prefer flake8.
the configuration I'm using now is https://github.com/luzfcb/django_documentos/blob/master/setup.cfg
and to landscape.io ( prospector ) https://github.com/luzfcb/django_documentos/blob/master/.landscape.yml

Any strong opinions about this one? Just want to know if we should merge or not. I lean yes, but want input from @luzfcb and @theskumar.

+1 on this. Even with the overlap, I like the ability to run more linting tools. :shipit:
But before merging, we ought to document this in a docs/linters.rst file. (We should document our current flake8 setup as well, but that's a separate issue)

I merged this and then:

Moved the rules from .pep8 into setup.cfg. This didn't affect the workings of pep8 or prospector.
Documented it in docs/linters.rst (feel free to improve this)

Anyone know if/how it's possible to put pylint rules into setup.cfg as well? @theskumar? I left the pylint rules in .pylintrc because I couldn't find any info on this.

@audreyr apparently, the idea was rejected: https://bitbucket.org/logilab/pylint/issues/617/search-pylint-configuration-in-setupcfg

@luzfcb Oh, that's too bad. I guess we'll stick with having a .pylintrc then.

i suppose that flake8 wrap all pylint configuration, then .pylintrc may be
not necessary.
@luzfcb https://github.com/luzfcb Oh, that's too bad. I guess we'll stick
with having a .pylintrc then.
—
Reply to this email directly or view it on GitHub
https://github.com/pydanny/cookiecutter-django/pull/283#issuecomment-143502752
.

The additional .pylintrc gives us the ability to:

Run prospector
Run pylint

Which means we get a lot more visibility into code quality. I think it's alright to have another dotfile in the project.


Skip "magic trailing comma" when formatting with black

The "magic trailing comma" is a comma at the end of bracketed list that forces black to format the list entries on separate lines, even if they would fit on one line. For example, if you write:
foo(a, b,)

black will see that trailing comma and format this as:
foo(
    a,
    b,
)

But with the skip-magic-trailing-comma setting enabled this will format on a single line instead
foo(a, b)

IME the trailing commas are almost always unintentional, e.g. left over from other refactos, and result in wasted vertical space. I suggest we enable this flag.

For an example of how this changes the formatting, see https://github.com/quantumlib/Cirq/pull/5171.

Curious if other @quantumlib/cirq-maintainers have opinions here. @MichaelBroughton is skeptical, based on his comments on #5171.

Amazing to see how many places people put trailing commas when they aren't really a good idea (other PR).
My main objection to this is that making black more and more configured means that I have to constantly switch between different black configs across different repos.  Typically I use virtual envs so this isn't a problem, but my IDE has a global black (reasons sigh) for running on save.
One question: if you turn the trailing commas back on does black add them back in?  i.e. could we just do a cleanup of this and try to start enforcing better standards?

if you turn the trailing commas back on does black add them back in? i.e. could we just do a cleanup of this and try to start enforcing better standards?

If you format with skip-magic-trailing-comma = true, then turn the option off again the formatting will not change, so yes, one can turn on the option locally and reformat and the format check will still pass in CI. black never inserts a magic trailing comma on it's own (that's why they're magic), but it does insert trailing commas in expressions that are too long to fit in a single line (long lists, tuples, arg lists, etc), and this is where hysteresis can enter in to the formatting:

black reformats a long line and adds a trailing comma.
subsequent refactor shortens the code so the expression would fit on a line.
s-m-t-c=true would reformat this to a single line again, while the default s-m-t-c=false will consider the comma originally added by black as "magic" and leave the multi-line expression.

but my IDE has a global black (reasons sigh) for running on save.

As noted above, you could set skip-magic-trailing-comma = true globally, and black with either configuration will accept it (of course there could be other differences in black configuration that will not work globally like this, such as line length or string normalization).

Ping @MichaelBroughton; thoughts on this?

Are we going to do a global format or just fix these as we go around, just got hit by this :)

I would vote for global format. Since we have .git-blame-ignore-revs this doesn't affect blame too much. I did cirq-google in https://github.com/quantumlib/Cirq/pull/5171.


Add google cloud function rule

The name of this rule is google function to be a bit more brief. http google cloud function seemed like a mouth full. Any preference.

This breaks if you have a region with a - in it due to a bug in the control api. Nothing we can do about it here.

The name of this rule is google function to be a bit more brief. http google cloud function seemed like a mouth full. Any preference.

My preference is the same as yours. I've dropped the http bit on rules that I've worked on.


Move developer availability display to a view component

AvailabilityComponent
This caught my eye and I couldn't help myself. I guess I'm your View Components guy

Hey @lsparlin, great idea utilising a view component. I've cherry-picked your change onto https://github.com/joemasilotti/railsdevs.io/pull/58 to replace the partial I introduced earlier today. I had to make a few other tweaks, ie passing the developer to the component to utilise the availability logic I've added to the developer model.

Thanks for this, @lsparlin! I'm going to close this once #58 is merged in.


Functions are including devDependencies on upload

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14
Amplify CLI Version
latest
What operating system are you using?
MacOS
Amplify Categories
function
Amplify Commands
push
Describe the bug
devDependencies are included in the zip file uploaded to lambda.
Expected behavior
no dev dependencies should make it to aws...
Reproduction steps
add some dev dependencies to a function, and push
GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

It sounds like we need to add --production when invoking npm.


export Format interface

I've added an export to the Format interface, I would like to be able to import and use it in my code

sure :smile:
Just out of curiosity, could you tell me a bit about your project? :smile:

I'm creating a wrapper component around numbro, which reads the locale from a react-18next instance
something like
numbro.setLanguage(this.props.i18n.language)
return <span>{numbro(this.props.value).format(this.props.format)}</span>

in numbro 2.1.0


Reproduce definition extraction results

When trying to reproduce 88 true positives and 337 false negatives for the description extraction I kind of hit a wall.
With alpha = beta = 1, gamma =0.1 and threshold = 0.6 as in the paper I recieve
fn:	140 fp:	835	 tp:	89	 prec	: 9,63 	recall: 38,86	f1: 15,44
for the strict matching.
After playing with the parameter threshold and not getting better results I realized that the total number of Identifiers for me is (tp + fn) for me is 229. When I looked at the goldstandard I was able to extract 359 definitions, which is less than the (88 + 337=) 425 definitions extracted in the paper. I am really confused right now. Also I found 217 Wikidatalinks, compared to 174 the paper mentions. How does that all make sense? To me it seems as if I'm working on the wrong goldstandard.

I'll look into this. But first. I noticed that there is one difference in the identifier recoginition. @leokraemer did you trace down which identifier that is?

I cannot trace that down, because I don't know which ones it is supposed to find. The paper only states the numbers, not what was found.

@leokraemer I tried to run
ran com.formulasearchengine.mathosphere.mlp.cli.CliMainTest#testEval without the _sample suffix. I get the impression that this works fine
com.formulasearchengine.mathosphere.mlp.cli.CliMainTest#testEval and the results look quite ok. Maybe you can give some more details about which program you are running and which results you get on your secreen?

Yes, I do basically the same. At first I analysed the system.err output but now I switched to try to compute the fp, fn and tp on the fly the same way that is done for the Identifiers. Code can be seen at https://github.com/leokraemer/mathosphere/ and the results do not match. I'll compare with https://github.com/TU-Berlin/mathematicalnamespacediscovery/tree/master/paper/eval/q***.csv to figure out where the problem is.
Also: I noticed that the combined 377 false negatives and 88 true positives stated in the paper add up to a total of 425 definitions. But the gold standard only contains 359 definitions, so I am expecting 66 more definitions in the goldstandard.
Also: Of these definitions 217 have a field like "W": [{"Q7913892": "Van der Waerden number"}] which is a wikidata link (the Q7913892 part) but the paper states that there are only 174 of those, this lead me to believe that there was something wrong with the gold standard.

@leokraemer look here
https://github.com/TU-Berlin/mathosphere/blob/40651e80b1679fd788b42e4f0f5dcf0786fbf370/mathosphere-core/src/main/java/com/formulasearchengine/mathosphere/mlp/FlinkMlpRelationFinder.java#L83-L168
how the evaluation works. If you have suggestions on improving it this more than welcome.
Especially
https://github.com/TU-Berlin/mathosphere/blob/40651e80b1679fd788b42e4f0f5dcf0786fbf370/mathosphere-core/src/main/java/com/formulasearchengine/mathosphere/mlp/FlinkMlpRelationFinder.java#L116-L124
defines how the fp, fn, and tp values are calulated.

Please also have a look at #105
However, there are still problems with that PR. Can you add the missing files and try to make the tests work on your machine?

Finally obtained a usable result using #105:
Threshold 0.8 has to be used and getNamespaceData(...) and selfMerge(...) must be deactivated.
Overall identifier evaluation
fp:58
fn:16
tp:294
Overall definition evaluation
fp=339; fn=222; tp=88

Still need to investigate where the 2 new fp come from though.

Also I can explain why the number of "false negatives" in the paper is completely unexplainable, it should read "false positives". About the Wikidata-links I still have no clue.

Overall identifier evaluation
fp:57
fn:16
tp:294
Overall definition evaluation
fp=337; fn=222; tp=88
I think reverting the mathqueryenerator 909011d did the trick.
with "-t", "0.8"


feat: Sync from noir

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat: place return value witnesses directly after function arguments (https://github.com/noir-lang/noir/pull/5142)
fix(experimental elaborator): Fix frontend tests when --use-elaborator flag is specified (https://github.com/noir-lang/noir/pull/5145)
chore: Remove unused new_variables argument from resolve_type_inner (https://github.com/noir-lang/noir/pull/5148)
chore: Remove hir to ast pass (https://github.com/noir-lang/noir/pull/5147)
fix(experimental elaborator): Fix definition kind of globals and tuple patterns with --use-elaborator flag (https://github.com/noir-lang/noir/pull/5139)
chore: default to using bn254 in noirc_frontend (https://github.com/noir-lang/noir/pull/5144)
fix(experimental elaborator): Fix impl Trait when --use-elaborator is selected (https://github.com/noir-lang/noir/pull/5138)
fix: wrapping in signed division (https://github.com/noir-lang/noir/pull/5134)
chore(ci): don't raise MSRV issue if workflow cancelled (https://github.com/noir-lang/noir/pull/5143)
fix: use predicate for curve operations (https://github.com/noir-lang/noir/pull/5076)
fix(experimental elaborator): Fix global values used in the elaborator (https://github.com/noir-lang/noir/pull/5135)
fix(experimental elaborator): Clear generics after elaborating type aliases (https://github.com/noir-lang/noir/pull/5136)
fix(frontend): Resolve object types from method calls a single time (https://github.com/noir-lang/noir/pull/5131)
feat: Separate runtimes of SSA functions before inlining (https://github.com/noir-lang/noir/pull/5121)
chore: run all test programs in brillig as well as ACIR (https://github.com/noir-lang/noir/pull/5128)
END_COMMIT_OVERRIDE

@guipublic fyi regression_5045 is failing to prove/verify in bb.

Benchmark results
Metrics with a significant change:

proof_construction_time_poseidon_hash_30_ms (1): 1,819 (+20%)
batch_insert_into_append_only_tree_32_depth_ms (1024): 730 (+55%)
batch_insert_into_append_only_tree_32_depth_hash_ms (1024): 0.683 (+55%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail): 1,781 (-18%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
6,113 (+7%)
1,549
738 (+4%)
762 (+1%)
772

proof_construction_time_sha256_30_ms
13,237 (+12%)
3,177 (+1%)
1,443 (+3%)
1,454 (+2%)
1,473

proof_construction_time_sha256_100_ms
47,235 (+6%)
12,113 (+1%)
5,713 (+1%)
5,609 (+1%)
5,619 (+2%)

proof_construction_time_poseidon_hash_ms
77.0 (-1%)
34.0
35.0 (+3%)
58.0 (+2%)
87.0

proof_construction_time_poseidon_hash_30_ms
:warning: 1,819 (+20%)
417
201 (+1%)
233 (+4%)
263

proof_construction_time_poseidon_hash_100_ms
5,722
1,576
745 (+2%)
776 (-2%)
792 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,452
9,440

l1_rollup_execution_gas
610,285
610,273
610,261

l2_block_processing_time_in_ms
716 (+3%)
1,284 (-1%)
2,720 (+11%)

l2_block_building_time_in_ms
24,737 (+12%)
46,225 (+2%)
92,311 (+6%)

l2_block_rollup_simulation_time_in_ms
24,626 (+12%)
45,876 (+2%)
91,917 (+6%)

l2_block_public_tx_process_time_in_ms
21,449 (+13%)
42,394 (+2%)
88,634 (+6%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
5,918 (-1%)
8,504 (-1%)

node_database_size_in_bytes
9,494,608
12,718,160

pxe_database_size_in_bytes
9,242
15,127

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.1 (+7%)
17.7 (+5%)
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.644 (+7%)
0.544 (+5%)
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
50.0 (+3%)
95.6 (+25%)
133
246 (-1%)
:warning: 730 (+55%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
288
543
1,055
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.510 (+3%)
0.590 (+25%)
0.456
0.446 (-1%)
:warning: 0.683 (+55%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
61.8 (+4%)
138 (+22%)
185 (+1%)
354 (-1%)
700
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
108
208
355
691
1,363
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.526 (+4%)
0.622 (+23%)
0.490 (+1%)
0.480 (-1%)
0.480
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
61.8 (+3%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
103

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.573 (+4%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
79,470
665,267

Transaction size based on fee payment method
| Metric |  |
| - |  |


Support for a user autocmd?

paq-nvim is almost everything I've been looking for: an easy to use, fast and simple package manager. I was wondering if you'd take a pull request that adds a custom user autocmd that's invoked at the end of operations?
Basically thinking of bootstrap here: if I wanted invoke something like paq:sync() and then exit neovim once it's done. I'd need a way to exist for the async processes to finish before quitting.

@fsouza I finally added this feature! The autocommands are listed in :help paq-autocommands, and I also added a section on bootstrapping to the docs (although it's somewhat bare-bones at the moment).


Allow unbuckling crit/dead people from vehicles

About the PR

This fix annoying bug yes yes
Why / Balance

Getting a dead person out of a wheelchair/any vehicles requires you to break their vehicle to get em out. This will let you unbuckle em if they are crit.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/34938708/7b943442-2ed3-4d14-8371-e25e0d68a7c3
Changelog

:cl: Vasilis

tweak: Made it so you can unbuckle players from Vehicles IF they are in crit or dead.
fix: You can no longer unbuckle while you are dead or crit.

Just got told you could also unbuckle on crit/death. Might as well do it in here.

Are you sure that actually works? As I pressed "Unbuckle" and nothing happened. Also my server just freezes when pressing unbuckle after dying. Unsure it's related https://github.com/space-wizards/space-station-14/assets/46868845/7862aa10-b125-4ff3-90a7-3e9857895e48

It should? I had tested it even. I will test it again when I have time

Are you sure that actually works? As I pressed "Unbuckle" and nothing happened. Also my server just freezes when pressing unbuckle after dying. Unsure it's related space-wizards/space-station-14/assets/46868845/7862aa10-b125-4ff3-90a7-3e9857895e48

huh you are right... seems like it broke with my other fix

In my case my server did not seem to freeze so i dunno what your case was about. The part of your video where you took control of the urist while it was dead and tried to unbuckle is intentional. A dead person should not be able to get off the seat by themselves


[STORM-636] Faster, optional retrieval of last component error

We want to speed up interactions with the topology that call getTopologyInfo, including the Topology Page in the UI.
Before change:

Errors written to /errors/topo-id/comp-name/eN, where N is a sequence number.
getTopologyInfo grabs all /errors/topo-id// errors from ZK

After this change:

Errors written to /errors/topo-id/comp-name/eN, where N is a sequence number. (unchanged)
Errors also written to /errors/topo-id/comp-name-last-error (this means there is an extra ZK write per error)
New Nimbus thrift interface method getTopologyInfoWithOpts

Only option right now is how many errors to retrieve from ZK: 0, 1, or all.

For testing this I did the following:
I modified the ExclamationTopology as follows:

bolts report a new RuntimeException  via reportError on each call to execute
changed topology.max.error.report.per.interval: 100 (default 10), so each executor/thread will write up to 100 errors to ZK every 10 seconds.  This is a quick-and-dirty way of increasing write load on ZK for testing.
Replicated the Exclamation bolt an additional ~450 times, so there are many more bolts in the topology.

Procedure:

Launch the topology in Inactive state, wait for it to get assigned and stable
go to the topology page and activate the topology (at this point the load time is on the order of seconds)
Refresh the topology until I see fresh errors reported for each bolt
Wait a a minute
Refresh the page and record load times from the Firefox network inspector.
Repeat 4 more times

Results:
Before patch (median about a minute):

57s
1m13s
55s
51s
1m34s

With patch (median about 10s)

12s
6s
8s
13s
10s

I did not know we only stored 10 errors, makes sense to not go with pagination if its hardcoded to 10. I will take a look at the complete PR today.
Not to derail the discussion but personally, I would much rather not store errors in zk at all if its just for rendering the errors in UI. If the spouts/bolts could just store this in memory with some expiration that should suffice and we could expose  an API at worker layer to get this information directly from it. If the host dies you lose some errors but that does not seem like a big deal. The only downside will be ui would now have to make requests against worker hosts to get erros but that seems ok to me, you would also get parallelism as all these worker calls can be made in parallel. I haven't thought this through completely and its probably much more work but I would love to hear your opinion.

Not to derail the discussion but personally, I would much rather not store errors in zk at all if its just for rendering the errors in UI.  If the spouts/bolts could just store this in memory with some expiration that should suffice and we could expose an API at worker layer to get this information directly from it. If the host dies you lose some errors but that does not seem like a big deal. The only downside will be ui would now have to make requests against worker hosts to get erros but that seems ok to me, you would also get parallelism as all these worker calls can be made in parallel. I haven't thought this through completely and its probably much more work but I would love to hear your opinion.

Yeah, we were thinking about distributing things this way too.  We figured that the bigger problem is the heartbeats, and if we could get an improvement with less effort here, it would be worth it.  It would be a much bigger change to distribute the errors out of ZK, yet maybe it is not a bad idea.  (Also, I think it is good to persist the errors anyway, not just in memory.  Users would like to see errors on the UI even if there was some issue that brought the supervisor down—like a rolling upgrade of the cluster.)  Maybe we could file a JIRA for better gathering of errors.
This change was intended to be small in scope and just give a way to get errors more efficiently when a topology has many, many components.  It was prompted by seeing topology page load times of minutes from one of our customers.  Plus, this may be less of a problem once heartbeats (and their metrics) are no longer getting sent around, but still it may not a bad idea to use a more distributed model like you suggest.

I agree that ZK is not the ideal place to storm most things, but it is by far the most convenient.  As such unless it is shown that it is causing a significant load on ZK I would rather leave it there until we can find/build a better place to put it.

The code looks fine to me +1.  Although I want to wait for @Parth-Brahmbhatt to finish his review before merging anything in.

Agreed, I would like a review from @Parth-Brahmbhatt first if possible.

I am +1 too, the code looks good to me.


CHW/ANC - Extract vital signs observations and encounter using StructureMap

Origin Issue #528
Sample Observation:
https://www.hl7.org/fhir/observation.html
https://www.hl7.org/fhir/observation-example.json.html
http://hl7.org/fhir/us/core/2021Jan/Observation-blood-pressure.json.html
https://www.hl7.org/fhir/observation-example-f001-glucose.json.html
https://www.hl7.org/fhir/observation-example-satO2.json.html
CC: @f-odhiambo

Extract Encounter with either of the following:

[ ] Weight observation
[ ] Height observation
[ ] Blood Oxygen Level observation
[ ] Blood pressure observation
[ ] Pulse rate observation
[ ] Blood glucose observation


Style lines

Is it possible to style the lines on a line chart? In particular I want some lines to be dashed or dotted. TIA

I agree that dotted lines would be useful. Under the hood this library uses nvd3. I'm looking into whether that library allows for dotted datapoints on line charts, and if it's easy will make a pull request.

We did find our way to a partial solution.
It just so happened that our charts have lines in pairs (expected and actual values). Using that fact we created some css...
#attachmenttimes .nv-groups .nv-series {
stroke-dasharray: 3, 3;
}
#attachmenttimes .nv-groups .nv-series-1 {
stroke-dasharray: 3, 3;
}
#attachmenttimes .nv-groups .nv-series-3 {
stroke-dasharray: 3, 3;
}
etc.
The numbered .nv-series classes are generated by nvd3. We are relying on these being odd numbered and our paired lines. So this works for us but is not a general solution.

Thanks! These also seem to work:
http://stackoverflow.com/questions/18530459/nvd3-js-bigger-points-in-a-line-chart
http://stackoverflow.com/questions/27892806/css-styling-of-points-in-figure

Those are handy too. Thanks.
In our solution I am a bit concerned that we are relying on an implementation detail i.e. the series numbering convention. We do not get any control over the values so are susceptible to change. It works but I'm not proud of it :-.
Cheers,
Paul B.


add modern style button

Done:

Modify the recessed style of the filter panel to a modern etched frame
Change the native button style (raised or recessed border) to a modern style (change the background color)
Some small string bugs
ToDo:
After the menu button is clicked and popMenu appears, the frame of the button will disappear
You can consider adding a rounded corner button

What do you mean that "the frame of the buttion will disappear". Can you give a more specific example (something like a gif?)

What do you mean that "the frame of the button will disappear". Can you give a more specific example (something like a gif?)

Sorry，it should be “the border of the button”. Just like setting the border of the button is 3px, some menu use this button which combined two images. When we click the menu button to open the popMenu, the menu button's border disappear, in other word, it's border size is set from 3px to 0px, this bug should be solved from studying the code about menu later!
This another solution , directly setting the border for 0px, but the UI will be ugly , the button is  so small!


Torque control and motor rebooting

I'd really like to add the ability to enable and disable the torque at runtime as well as reboot a motor if a fault is detected. I was thinking a parameters would be a nice way to do the torque and a service/subscription for reboot but hardware_interface::SystemInterface does not allow this ability. Do you have any suggestions for how to implement this and still keep only one instance of DynamixelWorkbench?

Hi, I also need to add the option for rebooting motors. Have you found a solution for your work?
Thanks!


Unable to change pop animation (on back pressed animation ) of FlutterActivity in an add-to-app scenario.

Steps to Reproduce

Followed the steps provided in the add to app documentation.
MainActivity.java file :

code snippet
import androidx.appcompat.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import io.flutter.embedding.engine.FlutterEngine;
import io.flutter.embedding.engine.FlutterEngineCache;
import io.flutter.embedding.engine.dart.DartExecutor;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        FlutterEngine flutterEngine = new FlutterEngine(this);
        flutterEngine.getDartExecutor().executeDartEntrypoint(
                DartExecutor.DartEntrypoint.createDefault()
        );
        FlutterEngineCache
                .getInstance()
                .put("my_app", flutterEngine);
        Button myButton = findViewById(R.id.button);
        myButton.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                startActivity(
                        CustomFlutterActivity
                                .withCachedEngine("my_app")
                                .build(MainActivity.this)
                );
                MainActivity.this.overridePendingTransition(0, 0);
            }
        });

    }
}

CustomFlutterActivity.java file:

code snippet
import io.flutter.embedding.android.FlutterActivity;
public class CustomFlutterActivity extends FlutterActivity {
    @Override
    public void onBackPressed() {
        super.onBackPressed();
        this.overridePendingTransition(0,0);
    }

}

Expected results:
Switch from flutter activity to main activity without animation on back button pressed.
Actual results:
Resulting in a swipe animation from flutter activity to main activity.
1.I am trying to implement a part of my flutter application that has a bottom navigation bar with one page completely written in native android. I want to switch between flutter activity and android activity without animation so that the user  have the experience of bottom navigation.

I followed a different approach. I tried bottom navigation with navigation code written in native android and each bottom navigation item to contain a  fragment of type both native fragment and flutter fragment. In this case a native fragment that holds a flutter fragment results in a plugin missing exception. I can start flutter activity which has no problem with any plugins.

Overall, I am trying to build a hybrid application with few screens written completely in native android (screens with recycler view and  AdMob ads ) and all the other screens written completely in flutter.

HI @Kabilan21
The pop animation is probably from the Flutter module, you can try overriding  buildTransitions
See https://stackoverflow.com/a/53503738

I was able to solve the issue by using flutter inside a fragement.


scoping.keep(): not sure how it works?

Could you provide a working example of how to use scoping.keep() in the README.md?

Nevermind, I can't read...

Just in case anyone searched for and ended up on this page:
from scoping import scoping
a = 2
with scoping():
    assert(2 == a)
    a = 3
    b = 4
    scoping.keep('b')  #The name of variables to be "kept" needs to be passed as a string to keep()
    assert(3 == a)
assert(2 == a)
assert(4 == b)


this.echo( div, { typing: true, delay: 100 }) does not work

Hello
I took your example to display html content, and added the "typing" effet which works with pure text but NOT with html
           var div = $('
Hello World
')

            this.echo( div, { typing: true, delay: 100 });

this does nothing. Is it normal ?
ps:but    this.echo( div); works
thanks
philippe

This is not a bug you can echo HTML code like this. You need to use raw option and animation doesn't work with animation. There would need to be HTML parser inside jQuery Terminal. Raw option is only when you don't want to use jQuery Terminal features (Formatting syntax), so you disable them completely.

But I should probably give a warning of something and update the documentation that animation is only for strings.

HI
ok thanks well noted.  I understand it is impossible with complex html but what about a single text to animate ? that will allow so set at least font-size, background or color, would be nice.
ps: yes maybe a warning would be nice as it took me a while before I found that it was the problem.

No, it will not be good idea because I will need to have full HTML parser after a while.
And you can make font size background and color with jQuery terminal only not with bare HTML.
Example:
term.echo('[[;red;]text to animate]');

The syntax is not very intuitive but it's meant to be used mostly by machines. You can do everything that HTML has you can add basic style, color, and background. But if you want you can add HTML attributes as well like style if you want.

And to make the jQuery Terminal syntax simple to use there is XML formatting that allows using HTML-like code inside jQuery Terminal where you don't need to worry about stuff like XSS, because there is only limited number of tags.

There is also a lot of CodePen demos that show how to use the library.
If you think the docs are bad, I know they could be better (Wiki is not ideal) but if you have any suggestions on how to improve docs, I'm all ears.

thanks. it was just a small defailt. the doc is excellent !! and the codepen examples also ! thanks.


BUILD-1199: Bump shipwright-io/operator to Latest

Update shipwright-io/operator dependency to bring in the upstream fix that adds default pruner settings in the generated TetkonConfig object.

Reran EC test as logs were not available for the previous one.

The EC errors are due to outdated tasks.

/retest

EC checks should not block merge of pull requests. They are meant to block release!

Merging this, EC errors not related to this. Will fix EC error in followup PRs.


Failed to refresh token

Recreantly i start getting this error when trying to use 2 different named cashes at once

First cash always  works correctly second one almost never. :(

Interesting it happens only when trying to reuse token for Exchange Online we troubleshoot Last time

Can you give an example of code that uses different caches at once, to reproduce the issue?

First one

second one (always works)

Could this be related to different client ID ?

Are you running these in order, in the same powershell session?

Yes
First is azure then exo

You don't need to create different caches for them. I will look into the problem with different caches, but once you've gotten a token you should be able to get another with the same cache for another resource, so this isn't a necessary pattern for scripts or same-session work.

Ok, Good to know :)

I'll create a separate issue on improving the documentation with examples to reduce possibly confusion with how to use the module 👍

Ok, Good to know :)

actually just verified that i need to use different cache name otherwise i am not able to connect to EXO at all since i always get token with scopes of AAD token

Are you specifying the correct resource and scopes when getting the token the second time?

Are you specifying the correct resource and scopes when getting the token the second time?
By default, the token will be for Graph.

Hmm actually that could be the case

Hello @PalmEmanuel,
you were right as you can see on my screens. i did not understanded how AzAuth cache mechanic works. and forgot to include Resource  on first load in try part of both functions and since graph resource is the default  graph api token always worked. mastery resolved :D

Happy to hear that!

Hmm.... issue seems prevailing but not so often

once in while i get this error 🆙
But if i run script again no authentication nothing is needed and everything works as expected

Can you post the code (or most of it) and describe when you see the error? Are you working with one or multiple caches, and is it in the same or different PowerShell sessions?

Unfortunately the code is quiet wast.
Multiple cashes name the same session
But not doing something extra special.
Just calling the exchange online API in 2 minute loop with get-exomailbox.

Can you describe the order of commands you're using, or some type of pseudo-code?
For example:

Get-AzToken -Interactive -TokenCache 'MyCache1'
Get-AzToken -TokenCache 'MyCache1'
Get-AzToken -DeviceCode -TokenCache 'MyCache2' -Resource 'https://outlook.office.com'
Get-AzToken -TokenCache 'MyCache2' -Resource 'https://outlook.office.com'

If it's in the same session, the module does its best to keep the authentication record for interactive authentications so that you don't need to specify cache, which I'm suspecting may cause the problems here, but I need some more understanding to be able to verify. Also, are you using any parallelization, such as ForEach-Object -Parallel?

Get-AzToken -TokenCache 'MyCache1' -Resource 'https://outlook.office.com' -ClientID '' -Username '' - Is most fitting
hoever i think i found the root cause when token is returned from cache is not refreshed even when

is many minutes in past:

souled be token refreshed on return from cash if is expired ? could this be the issue ?

I don't see any immediate issue with the code. Maybe you could run Get-Error of the Failed to refresh access token error and give me the full stack trace?
I would also like to know in which order you get the tokens, not just the one where it fails. First you have to get it interactively and save it as a token somewhere, that's what I was requesting with the pseudocode.

Token get order:

Graf API token
Exchange token

i am trying to to implement this  workeround:

I'm having trouble replicating the issue. The problem with the above code is that you catch all possible errors that might happen the first time you try to get a token, and get a new one interactively instead. It would be useful to see more information about your errors.
To understand the scenario, I think you will need to give me some pseudo-code or at least the steps involved with the different parameters. I only need to understand the order of your Get-AzToken commands and if they are interactive, or different caches.
If it's a lot of code, can you give me a full order in something like this? I mainly need to understand which order you use the module and how.

Unless I get a better understanding of the order that you're getting the tokens and using the cache(s), I'm not sure I can replicate it and fix it if it's a bug.

Another way to go about it is if you can describe your process and what you're trying to achieve with your solution / script, in that case I can suggest how I would get tokens, and you can compare to see what you've implemented.

HI, sorry for later reply i just simply implemented workaround that i manually check, that if token is expired, i just manually run auth function again and it work :)


APP-1179/APP-1180 : IB APIs to search for Jira users / assign new ticket to user

Can one of the admins verify this patch?

Codecov Report

Merging #73 into dev will increase coverage by 3.4%.
The diff coverage is 92.81%.

@@            Coverage Diff            @@
##              dev      #73     +/-   ##
=========================================
+ Coverage   86.45%   89.85%   +3.4%
=========================================
  Files          26       37     +11
  Lines         893     1055    +162
  Branches      109      124     +15
=========================================
+ Hits          772      948    +176
+ Misses         87       71     -16
- Partials       34       36      +2

Impacted Files
Coverage Δ

...ration/jira/exception/InvalidJiraURLException.java
100% <100%> (ø)

...tegration/jira/webhook/JiraWebHookIntegration.java
93.47% <100%> (+52.93%)
:arrow_up:

...tion/jira/exception/IssueKeyNotFoundException.java
100% <100%> (ø)

...on/jira/services/SearchAssignableUsersService.java
100% <100%> (ø)

...tion/jira/api/JiraApiResourceExceptionHandler.java
100% <100%> (ø)

...s/integration/jira/services/UserAssignService.java
100% <100%> (ø)

...tion/jira/exception/JiraUserNotFoundException.java
100% <100%> (ø)

...ration/jira/exception/JiraUnexpectedException.java
100% <100%> (ø)

...ira/authorization/oauth/v1/JiraOAuth1Provider.java
96.29% <100%> (+0.14%)
:arrow_up:

...ion/jira/exception/JiraAuthorizationException.java
100% <100%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fced9...f5134b9. Read the comment docs.


HoloJSWebViewer issue in a webgl bundle app (webpack)

Hi,
Thanks for the great work! I tried some THREEJS app in the Hololens and it works perfectly!
A single but important issue for me, I have a webgl geospatial application (github.com/itowns/itowns) and I try to use it with HoloJsWebViewer but it doesn't work, it's a module problem I think, let me explain:
iTowns is a web mapping app using THREEJS. It's built with webpack (we get THREEJS and others from npm). So the Main.js we have looks like
import * as THREE from 'three';  export { THREE };  export { default as proj4 } from 'proj4'; ...
When creating an app using itowns, we can normally access THREE through itowns.THREE but it seems we can't in HoloJsWebViewer, although it works with Edge Browser in the Hololens.
I did a json with itowns.js and a simple test.js (just to test THREE) and incorporated the ThreeJS patches (shaderchunk transpose) and the HolographicCamera directly in my code after doing var THREE = itowns.THREE;
Opening it with Edge browser on the Hololens works fine but not with HoloJsWebWiewer. But if I replace itowns.js by three.js in the json it works fine in both.
Do you have any idea? It would be so perfect to be able to use the geospatial app in Hololens (with some easy homography transformations)
The json and html js are here:
http://www.whenistheweekend.com/itowns/holo/samples.html
Thanks!

If that can help:
I launched the app on HoloJsWebWiewer through Visual Studio with the Hololens emulator and I got:
TypeError: Invalid operand to 'in': Object expected at Anonymous function ( http://whenistheweekend.com/itowns/holo/itowns.js:5:174270) at e (....)

@nosy-b The THREEJS app and the Viewer both rely on the HoloJS project which does not implement HTML and DOM model. You can not for instance use jQuery.
So you have to work only with JavaScript...

@Reda-S I'm actually using only Javasript, what do you mean?

As @reda-s mentioned, the DOM model covers Canvas, Image, Video and a minimum set of methods for document, window. There is no HTML parser or building a DOM from HTML.
That being said, we can investigate a bit to see what would be required to make your project work. Can you provide a non-minified version of itown.js?
To debug scripts, in Visual Studio start the viewer app in Debug mode and with the script debugger enabled:

Thanks for your help :)
Alright I've unminified itowns.js
Code for the small test using itowns is here
and the json
I've run it in debug with the emulator and got
TypeError: Invalid operand to 'in': Object expected
at Anonymous function (http://whenistheweekend.com/itowns/holo/itowns.js:54782:10)
at webpack_require (http://whenistheweekend.com/itowns/holo/itowns.js:65:12)
at Anonymous function (http://whenistheweekend.com/itowns/holo/itowns.js:69523:1)
at webpack_require (http://whenistheweekend.com/itowns/holo/itowns.js:65:12)
at Anonymous function (http://whenistheweekend.com/itowns/holo/itowns.js:68778:1)
at webpack_require (http://whenistheweekend.com/itowns/holo/itowns.js:65:12)
at Anonymous function (http://whenistheweekend.com/itowns/holo/itowns.js:45056:1)
at webpack_require (http://whenistheweekend.com/itowns/holo/itowns.js:65:12)
at Anonymous function (http://whenistheweekend.com/itowns/holo/itowns.js:47304:1)
at webpack_require (http://whenistheweekend.com/itowns/holo/itowns.js:65:12)
Looks like there in itowns.js  @l:54782:
// IE8-
  } else if (ONREADYSTATECHANGE in cel('script')) {
    defer = function (id) {
      html.appendChild(cel('script'))[ONREADYSTATECHANGE] = function () {
        html.removeChild(this);
        run.call(id);
      };
    };
// Rest old browsers
  } else {

If I got this right, cel('script') tries to create a script DOM element. As HoloJS has very limited DOM support, document.createElement('script') returns null and the 'in' operator does not like it.
Look at HoloJS\HoloJsHost\ScriptingFramework\DOM.js, line 80, for a list of element types handled currently.
There are a couple of options:

Extend DOM.js in HoloJS to support the script element, and other element types required by the library
Make those elements optional in your library such that the script can operate in a limited DOM environment.

Ok I see, thanks! I'm gonna check the two different possibilities.
By the way what is the roadmap for HoloJS, is it going to be 'replaced' by a WebVR implementation with a Edge support?

I managed to find a more complete, pure JavaScript DOM implementation. See https://github.com/andreasgal/dom.js/
I forked it and made some minor experimental changes to make it suitable for HoloJS:
https://github.com/Almost-Done/dom.js
I pushed out a HoloJS branch with a dom.js DOM. See develop/experimental-dom. I added the iTowns sample and it loads and renders:

Note: there is no spatial input in this experimental branch; with a more standard DOM we'll have to create more suitable events for it.

Oh, I just see your post now, that's great thanks Cristi!
I'll try as soon as I can.

I merged the experimental DOM in master to at least fix the issues mentioned above. Please let me know what other problems you're encountering.


Target Electron 6 - 8

This targets Electron major versions 6, 7, and 8.
Some older versions of Electron are no longer targeted in this build, and older versions of this package will have to be used for those versions.
It also bumps the sqlcipher version from 4.2.0 to 4.3.0 and sqlite from 3.28.0 to 3.31.0.

This will fix #22


Go template help

I know the issues section of this project isn't really for troubleshooting but I've never used Golang and don't really understand how this all works.
I have a modified .tmpl file from another project and I'm having trouble with getting another env to work. I would like to use VHOST="example.com" just like the nginx one uses but I also need TLS_OFF to be an option so I can get this working with caddy without SSL being enabled.
Is there an issue with what I'm doing here?
This is what I modified.
{{ range $host, $containers := groupByMulti $ "Env.VIRTUAL_HOST" "," }}
{{ if Env.TLS_OFF }}
  {{ $host:80 }} {
      tls off
{{ else }}
  {{ $host }} {
{{ end }}
  {{ range $index, $value := $containers }}
    {{ $addrLen := len $value.Addresses }}
    {{ if eq $addrLen 1 }}
      {{ with $address := index $value.Addresses 0 }}
      proxy / {{ $address.IP }}:{{ $address.Port }} {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
      }
      {{ end }}
    {{ else if $value.Env.VIRTUAL_PORT }}
      {{ range $i, $address := $value.Addresses }}
        {{ if eq $address.Port $value.Env.VIRTUAL_PORT }}
        proxy / {{ $address.IP }}:{{ $address.Port }} {
          header_upstream Host {host}
          header_upstream X-Real-IP {remote}
          header_upstream X-Forwarded-For {remote}
          header_upstream X-Forwarded-Proto {scheme}
        }
        {{ end }}
      {{ end }}
    {{ else }}
      {{ range $i, $address := $value.Addresses }}
        {{ if eq $address.Port "80" }}
        proxy / {{ $address.IP }}:{{ $address.Port }} {
          header_upstream Host {host}
          header_upstream X-Real-IP {remote}
          header_upstream X-Forwarded-For {remote}
          header_upstream X-Forwarded-Proto {scheme}
        }
        {{ end }}
      {{ end }}
    {{ end }}
  {{ end }}
}
{{ end }}

I don't fully understand what you are trying to do, but maybe this snippet might help:
{{/* group all the containers into a map[VIRTUAL_HOST] = []Container */}}
{{ $vhostGroups := groupByMulti $ "Env.VIRTUAL_HOST" "," }}

{{/* iterate over each group */}}
{{ range $vhost, $containers := $vhostGroups }}

	{{/* set $tls to containers where TLS=true and */}}
	{{ $tls := where $containers "Env.TLS" "true" }}

	{{/* set $noTls to containers where TLS env var is not set */}}
	{{ $noTls := whereNotExist $containers "Env.TLS" }}

	{{/* iterate over the tls enabled hosts */}}
	# tls {{ $vhost }}
	{{ range $j, $container := $tls }}
	   {{ $container.Name }}
	{{ end }}

	{{/* iterate over the non-tls enabled hosts */}}
	# no tls {{ $vhost }}
	{{ range $j, $container := $noTls }}
	   {{ $container.Name }}
	{{ end }}
{{ end }}

There are other template function helpers with example tests that you can also use within templates.

What I was trying to do is separate the hosts like with nginx but then separate out the ssl and non ssl containers since I'm using caddyserver and it requires tls off inside of the host section and not the proxy one.
Ideally I'd end up with something like this.
tls_true.com {
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
}
tls_false.com {
    tls off
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
}
tls_env_missing.com {
    tls off
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
    proxy / <IP_ADDRESS>:80 {
        header_upstream Host {host}
        header_upstream X-Real-IP {remote}
        header_upstream X-Forwarded-For {remote}
        header_upstream X-Forwarded-Proto {scheme}
    }
}

By running these.
docker run -d -e VIRTUAL_HOST="tls_true.com" -e TLS="true" tutum/hello-world
docker run -d -e VIRTUAL_HOST="tls_true.com" -e TLS="true" tutum/hello-world
docker run -d -e VIRTUAL_HOST="tls_false.com" -e TLS="false" tutum/hello-world
docker run -d -e VIRTUAL_HOST="tls_false.com" -e TLS="false" tutum/hello-world
docker run -d -e VIRTUAL_HOST="tls_missing.com" tutum/hello-world
docker run -d -e VIRTUAL_HOST="tls_missing.com" tutum/hello-world

So I managed to get somewhere with this but I think the tls var isn't working as I expected it to.
Using the docker run stuff from above this is what I got.
{{/* group all the containers into a map[VIRTUAL_HOST] = []Container */}}
{{ $vhostGroups := groupByMulti $ "Env.VIRTUAL_HOST" "," }}

{{/* iterate over each group */}}
{{ range $vhost, $containers := $vhostGroups }}

	{{/* set $tls to containers where TLS=true and */}}
	{{ $tls := where $containers "Env.TLS" "true" }}

	{{/* set $noTls to containers where TLS env var is not set */}}
	{{ $noTls := whereNotExist $containers "Env.TLS" }}

	{{/* iterate over the tls enabled hosts */}}
	{{ $vhost }} {
        {{ range $j, $container := $tls }}
            {{ with $address := index $container.Addresses 0 }}
                proxy / {{ $address.IP }}:{{ $address.Port }} {
                    header_upstream Host {host}
                    header_upstream X-Real-IP {remote}
                    header_upstream X-Forwarded-For {remote}
                    header_upstream X-Forwarded-Proto {scheme}
                }
            {{ end }}
        {{ end }}
    }

    {{/* iterate over the non-tls enabled hosts */}}
    {{ $vhost }} {
        {{ range $j, $container := $tls }}
            {{ with $address := index $container.Addresses 0 }}
                proxy / {{ $address.IP }}:{{ $address.Port }} {
                    tls off
                    header_upstream Host {host}
                    header_upstream X-Real-IP {remote}
                    header_upstream X-Forwarded-For {remote}
                    header_upstream X-Forwarded-Proto {scheme}
                }
            {{ end }}
        {{ end }}
    }
{{ end }}

This is the CaddyFile being generated.
	tls_false.com {
    }
    tls_false.com {
    }
	tls_missing.com {
    }
    tls_missing.com {
    }
	tls_true.com {
                proxy / <IP_ADDRESS>:80 {
                    header_upstream Host {host}
                    header_upstream X-Real-IP {remote}
                    header_upstream X-Forwarded-For {remote}
                    header_upstream X-Forwarded-Proto {scheme}
                }
    }
    tls_true.com {
                proxy / <IP_ADDRESS>:80 {
                    tls off
                    header_upstream Host {host}
                    header_upstream X-Real-IP {remote}
                    header_upstream X-Forwarded-For {remote}
                    header_upstream X-Forwarded-Proto {scheme}
                }
    }


Make wise init more human readable

For enhancements
--- Settings: ---
{
  "wisePath": ". (/tmp)",
  "configPath": "./config.yml (/tmp/config.yml)",
  "rulesPath": "./rules.yml (/tmp/rules.yml)",
  "syncedBlockNumPath": "./synced-block-num.txt (/tmp/synced-block-num.txt)",
  "username": "adfkjhasdflkja",
  "savePostingKey": false,
  "postingKey": ""
}
------

The feature:
It is important for me because:
It is important for steem because:

Fixed in https://github.com/noisy-witness/steem-wise-cli/commit/725b16593cf86a446be3cdf06e4244187b1f9244


Rule status "looperror"

Rule status can be "looperror", but api throw
"ApiError: Value 'looperror' is not one of the allowed values [enabled,disabled,resourcedeleted]
at ChoiceType._convertToType (/Users/mac/Projects/NodeProjects/hue-project/node_modules/node-hue-api/lib/types/ChoiceType.js:27:13)"

Fixed in 4.0.2 that is now in npm registry


Documenting return types

Given that we have decided to create a Result object that contains a return code along with the actual contents returned by the function, how should this be documented in the function headers?
It seems redundant to have the function say "returns a Result object", but incorrect to say it returns anything but. Maybe instead of saying return: [bool] it could say return contents: [bool] or something like that

Response object has been removed


MediaFile: use older text encodings in ID3v2.3 mode

I am trying to create an auto-tagging configuration in which my tags are saved in ID3v2.3 (as 2.4 lacks compatibility with some players I use) and I like the cover art to be embedded in each music file. However, the cover art of the output files is not recognised by OS X 10.9.4 (i.e. in Finder) or iTunes.
Here is a simple configuration with which the problem occurs:
directory: /mnt/data/home/Music

plugins: mbsync fetchart embedart
per_disc_numbering: yes
id3v23: yes

import:
    copy: yes
    write: yes

paths:
    default: $albumartist/$album%aunique{}/$disc-$track $title

When I comment the id3v23: yes option the covers of the output files are correctly recognised in Mac.
The cover art of the ID3v2.3 output files is recognised in Windows, so it seems a Mac-specific issue. Strangely enough, the input files I used already have ID3v2.3 tags and embedded cover art and are correctly recognised in Mac. Below you have a diff of the ID3v2.3 tags (sorted by name) between an input and an output file taken with mid3v2:
1c1,2
< APIC= (image/jpeg, 32205 bytes)
---
> APIC= (image/jpeg, 111083 bytes)
> COMM=iTunNORM='eng'= 00001700 00001700 00003981 00003981 00000000 00000000 00008187 00008187 00000000 00000000
3a5,6
> TBPM=0
> TCMP=0
5a9
> TLAN=eng
12a17,19
> TXXX=Album Artist Credit=The Beatles
> TXXX=ALBUMARTISTSORT=Beatles, The
> TXXX=Artist Credit=The Beatles
14a22
> TXXX=MusicBrainz Album Comment=UK mono
17c25
< TXXX=MusicBrainz Album Status=official
---
> TXXX=MusicBrainz Album Status=Official
27a36
> USLT=[unrepresentable data]

Hi @sampsyo! Is there any update about this issue? For now I'm applying the hack you mentioned here every time I update beets, but it would be nice if this had a proper solution.
From what I understood from the discussion a revamp of the architecture would be the most elegant way to do that, but isn't there anything you can do to allow users to manually override the encoding in the configuration for now, even if it seems somewhat strange / specific for this problem?

Sorry, no update to speak of. Contributions would be very welcome here! (There's no shortcut, alas.)


fix(options): fully reset options on watch change + opportunistic linting

Ran into an issue where re-assigning options would only append new values, not reset as expected.
Also did some opportunistic linting (no formatting changes).

hey @machineboy2045 - wondering if you saw this PR yet. let me know if you have any questions!

Thanks for the PR! I plan on going through your's and a couple others this
afternoon.
On Thu, Jan 15, 2015 at 9:16 AM, Brent<EMAIL_ADDRESS>wrote:

hey @machineboy2045 https://github.com/machineboy2045 - wondering if
you saw this PR yet. let me know if you have any questions!
—
Reply to this email directly or view it on GitHub
https://github.com/machineboy2045/angular-selectize/pull/28#issuecomment-70122224
.

Is there a way to do this without completely re-building the options each time they change? I'm worried that might degrade performance.

Not to my knowledge. The current watch will only fire if the reference is changed, so it seems like that should be the expected behavior. FWIW - I wrapped that re-assignment around console.time(label) / console.timeEnd(label) statements and found that it averaged 0.32ms on my MacBook and 1.2ms on my Android S4. So ... probably not too much of a concern.  =]

look good @machineboy2045 ?

I think the performance is affected when there are a large number of options. I created a plunkr using your version of angular-selectize. Look at the console.time() output when adding options. http://plnkr.co/edit/3S8Y66?p=preview
I think your idea is a good one. And I'm trying to think of how to do it in a way that doesn't add overhead. So I'm leaving this conversation open.

Yeah, I'm not really sure how else to go about it. it's the same overhead that would occur upon initializing the component in the first place, so i think if you're doing so with 10,000 records, you should be anticipating that sort of performance hit. In situations where you find yourself using excessively large data providers, you should probably be reconsidering your approach anyhow.

One optimization I can think of is preventing the complete rebuild when an
option is added.
On Wed, Jan 28, 2015 at 10:57 AM, Brent<EMAIL_ADDRESS>wrote:

Yeah, I'm not really sure how else to go about it. it's the same overhead
that would occur upon initializing the component in the first place, so i
think if you're doing so with 10,000 records, you should be anticipating
that sort of performance hit. In situations where you find yourself using
excessively large data providers, you should probably be reconsidering your
approach anyhow.
—
Reply to this email directly or view it on GitHub
https://github.com/machineboy2045/angular-selectize/pull/28#issuecomment-71893155
.

Unfortunately, you're not going to get a lot of insight from watchCollection as to what's changed without manually comparing the old / new array values. You'd have to implement your own wrapper around the array to broadcast collection change events as necessary (see also: http://beta.plnkr.co/edit/dGJFDhf9p5KJqeUfcTys). But in that case, you're deviating pretty heavily from expected use. Dunno


(Passive) BLE Scan missing a lot of advertisments

First of all: Thx for this awesome project!
I just migrated my project from the standard lib to NimBLE-Arduino and in general it works fine, but unfortunatelly I noticed that a lot of advertisments are missing.
I'm using the following code to do a endless passive scan and gather data from Xiaomi BLE sensors:
pBLEScan = BLEDevice::getScan();
pBLEScan->setAdvertisedDeviceCallbacks(new MiDeviceCallbacks());
pBLEScan->setActiveScan(false);
pBLEScan->start(0);

Using the standard lib one minute results in this:

Friday, June 26 2020 08:34:51: Wohnzimmer Humid: 57
Friday, June 26 2020 08:34:52: Guave Light: 375
Friday, June 26 2020 08:34:56: Guave Moisture: 41%
Friday, June 26 2020 08:34:56: Wohnzimmer Temp: 24.6
Friday, June 26 2020 08:34:58: Wohnzimmer Temp: 24.6
Friday, June 26 2020 08:35:04: Guave Conductivity: 41
Friday, June 26 2020 08:35:16: Guave Temp: 23.2
Friday, June 26 2020 08:35:16: Wohnzimmer Temp: 24.6
Friday, June 26 2020 08:35:21: Wohnzimmer Humid: 57
Friday, June 26 2020 08:35:22: Wohnzimmer Temp: 24.5
Friday, June 26 2020 08:35:23: Wohnzimmer Humid: 57
Friday, June 26 2020 08:35:24: Guave Light: 356
Friday, June 26 2020 08:35:29: Wohnzimmer Humid: 57
Friday, June 26 2020 08:35:32: Wohnzimmer Temp: 24.6
Friday, June 26 2020 08:35:34: Guave Moisture: 41%
Friday, June 26 2020 08:35:44: Guave Conductivity: 41
Friday, June 26 2020 08:35:44: Wohnzimmer Temp: 24.6
Friday, June 26 2020 08:35:54: Guave Temp: 23.2

while one minute using NimBLE results in:

Friday, June 26 2020 08:38:54: Guave Moisture: 41%
Friday, June 26 2020 08:38:58: Wohnzimmer Temp: 24.5
Friday, June 26 2020 08:39:38: Wohnzimmer Humid: 57
Friday, June 26 2020 08:39:41: Guave Moisture: 41%

Hardware is the same and did not move, so "traffic" should be about the same in both cases.
About 80% of the advertisments seem not to be reported to my callback.
Full source of my Program is available here ( https://github.com/TheNitek/MicroHome/blob/master/MicroHome.ino ).
Is that a problem with NimBLE or did I miss any NimBLE specific parameters that I have to set/change?

Im not saying its the case here, but some ble sensors increase delay between advertising data for better power usage, so it may be it is more often after it is powered then less often, usually after 30 sec.

The sensors are broadcasting quite regularly. I have been monitoring the for a while now and the frequency of advertisement does not change significantly over time.

Hi @TheNitek thank you for reporting this issue.
I think it may be caused by this line, if you could test by setting that value to 0 and report back it would be greatly appreciated.

Looks much better, thx! Funny thing is: If this flag is the reason, it does not work properly, because I am still getting multiple advertisment packages from the same device (and source address)

Great, I’ll make the change in the library as well.
Yes it certainly seems that it doesn’t do what the description says, might be a  timer that resets it or could be bugged.

I found the reason that filter_duplicates appears to not work. From ESP IDF Controller manual:

Note that scan duplicate list will be automatically cleared when the maximum amount of device in the filter is reached the amount of device in the filter can be configured in menuconfig.

Just thought I'd share that for anyone watching.
Also I just pushed the change in commit aaf42f8 .

I don't think this explaination fits. In my logs "Wohnzimmer" und "Guava" are two sensors (delivering multiple data points) and they are still reported multiple times.
Regarding the fix: Wouldn't it make sense to change setAdvertisedDeviceCallbacks to take the second parameter again? Currently wantDuplicates is just commented out there

I don't think this explaination fits. In my logs "Wohnzimmer" und "Guava" are two sensors (delivering multiple data points) and they are still reported multiple times.

You're correct, it seems it also resets the filter every ~45 seconds, but I have not seen any documentation to indicate such.

Regarding the fix: Wouldn't it make sense to change setAdvertisedDeviceCallbacks to take the second parameter again? Currently wantDuplicates is just commented out there

Yes, that is still incomplete, a decision has not been made on the implementation of this as we don't duplicate the devices anymore, simply update the advertised data instead. The original library made a new addition to the vector (map) for the same device if found more than once while scanning with that value set to true, We try to avoid that here and just update the data we have of it. Perhaps, as your code shows, it may be advantageous to save the device and data more than once if that is set to true so the user can get the data from multiple advertisements if required.
The reason for filter_duplicates = 1 previously is that was a something I changed for testing at one point and accidentally pushed it into the master code.

In my specific case I don't even care about "other" devices/advertisments. I just need the callback to process the data and that's it. I even had to add a clearResults() at the end of my callback to avoid memory issues.
In a perfect world (and for what I am doing right now) the library would neither care about duplicates nor about storing device it has previously found. (I'm not saying it has to be implemented like this, just want to make my use case as clear as possible)

@TheNitek I understand your use case, it just highlighted an issue that may come up for others. Such as gathering advertisement data in a specified duration so they may need multiple advertisements from a device if not using the callback.


feeTooSmall error when mustBeSignedBy not used

See here. When the mustBeSignedBy is not included, the following error is thrown when submitting the tx:
Error: `submit` call failed. Error from Ogmios: [{"feeTooSmall":{"actualFee":146700,"requiredFee":156800}}]
    at Object.exports.error (/home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Exception/foreign.js:8:10)
    at Object.$$throw [as throw] (/home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Exception/index.js:18:45)
    at /home/calum/code/mlabs/seabug/seabug-contracts/output/Contract.Transaction/index.js:139:105
    at /home/calum/code/mlabs/seabug/seabug-contracts/output/Control.Monad.Reader.Trans/index.js:108:34
    at run (/home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Aff/foreign.js:278:22)
    at /home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Aff/foreign.js:348:19
    at drain (/home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Aff/foreign.js:120:9)
    at Object.enqueue (/home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Aff/foreign.js:141:11)
    at /home/calum/code/mlabs/seabug/seabug-contracts/output/Effect.Aff/foreign.js:339:27
    at __do (/home/calum/code/mlabs/seabug/seabug-contracts/output/QueryM/index.js:533:139)

Reproduce using this utxo distribution:
( withStakeKey (wrap privateStakeKey)
          [ BigInt.fromInt 1_000_000_000
          , BigInt.fromInt 2_000_000_000
          ]
      ) /\
        [ BigInt.fromInt 2_000_000_000 ]

Also see comment by @klntsky in https://github.com/Plutonomicon/cardano-transaction-lib/pull/838#discussion_r937631251

This is intended behavior -- the number of expected signatures affects the fee calculation by adding the PKHs to TxBody.requiredSigners

@ngua why then we don't use mustPayToPubkey in any of the plutip tests and still everything works?

Because we're only signing it once. The code that @rynoV linked signs the tx twice