nixos-unstable hasn't updated for 14 days

The last successful update occurred on May 15, commit f93a8ee1105f4cc3770ce339a8c1a4acea3b2fb6.
http://hydra.nixos.org/job/nixos/trunk-combined/tested seems to suggest that vm-test-run-installer-simpleLabels is the culprit, but there might be more.

All installer tests fail.

Installer tests fail due to missing nixos-manual, see 2a1c34288795c245718ea9ac9b12f3dfee5144c4
gnome3 tests fail /cc @lethalman
nfs tests fail due to failing rpcbind http://hydra.nixos.org/build/22585878

more at http://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents

I'm not able to reproduce the hydra installer failure because it fails for another reason locally:
machine# error: cannot download Encode-Locale-1.03.tar.gz from any mirror
machine# builder for ‘/nix/store/0w5ys792xq16h5hy1zr91c1m7bw14mif-Encode-Locale-1.03.tar.gz.drv’ failed with exit code 1
machine# building path(s) ‘/nix/store/zf623b7jii31xibgrxpm0g77zyvpfsvv-File-Listing-6.04.tar.gz’
machine# cannot build derivation ‘/nix/store/igahvagn5xfb06fpqcbyv06q69riipf5-perl-Encode-Locale-1.03.drv’: 1 dependencies couldn't be built
machine# building path(s) ‘/nix/store/rk0701i7ayb291p9nbn39s0j3a1lc4i1-curl-7.42.1.tar.bz2’
machine# cannot build derivation ‘/nix/store/bd31ar98z54j7awlj43rsb1a9fhnl9kv-perl-libwww-perl-6.05.drv’: 1 dependencies couldn't be built
machine# building path(s) ‘/nix/store/ava4sza6rwykliwqymc52klx6zcfs1gr-gettext-0.19.4.tar.gz’
machine# cannot build derivation ‘/nix/store/rv19b42ixd8lbdjk4z714qjf1zqvyliz-nss-cacert-3.19.1.drv’: 1 dependencies couldn't be built
machine# cannot build derivation ‘/nix/store/pfp7mqhl4y16q9a036hfgicxyy3dqsh7-nixos-artwork-e71b684.drv’: 1 dependencies couldn't be built
machine# building path(s) ‘/nix/store/ix4x3nnl2cn6j93vb1czg7arhcsy3j9k-nixos-checkout’
machine# cannot build derivation ‘/nix/store/4nkz2kfxhmy40l86m3mrzv6bnc76h932-grub-config.xml.drv’: 1 dependencies couldn't be built
machine# cannot build derivation ‘/nix/store/8wbi1l0dzjlz991hcvk87yw3qagfga9c-install-grub.sh.drv’: 1 dependencies couldn't be built
machine# cannot build derivation ‘/nix/store/kxw6my91yxa8dkg3i5h1h5g8ppz295aa-nixos-15.06pre-git.drv’: 1 dependencies couldn't be built
machine# error: build of ‘/nix/store/kxw6my91yxa8dkg3i5h1h5g8ppz295aa-nixos-15.06pre-git.drv’ failed
machine: exit status 1
machine: output:
error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
cleaning up

Anyway my fix to that would be:
--- a/nixos/modules/installer/cd-dvd/installation-cd-minimal.nix
+++ b/nixos/modules/installer/cd-dvd/installation-cd-minimal.nix
@@ -1,11 +1,14 @@
 # This module defines a small NixOS installation CD.  It does not
 # contain any graphical stuff.

-{ config, pkgs, ... }:
+{ config, pkgs, lib, ... }:

 {
   imports =
     [ ./installation-cd-base.nix
       ../../profiles/minimal.nix
     ];
+
+  # Enable in installer, even if minimal profile disables it
+  services.nixosManual.enable = lib.mkOverride 999 true;
 }

cc @edolstra

I think that error is due to 1e98da6d992522ae26bc37bb670b09805f44b762

I've enabled the nixos-manual in the minimal iso.

But now installer tests are failing elsewhere: http://hydra.nixos.org/build/22822134/log#line-1562

All X11 tests are failing due to (EE) no screens found: http://hydra.nixos.org/build/22825473. I think that might be because of https://github.com/NixOS/nixpkgs/commit/0307c27219ba43cc0a78cd370f825deca16eeaa2, as it blacklisted bochs-drm:
[tmtynkky@nixvm:~]$ diff -u /nix/store/i10g64jh97izwy51x9clc0dsbklgsnlp-kmod-blacklist-3ubuntu1/modprobe.conf /nix/store/2q84nh0a6nq043rrwly9lvw6xbpcdagj-kmod-blacklist-18-3ubuntu1/modprobe.conf
--- /nix/store/i10g64jh97izwy51x9clc0dsbklgsnlp-kmod-blacklist-3ubuntu1/modprobe.conf	1970-01-01 02:00:01.000000000 +0200
+++ /nix/store/2q84nh0a6nq043rrwly9lvw6xbpcdagj-kmod-blacklist-18-3ubuntu1/modprobe.conf	1970-01-01 02:00:01.000000000 +0200
@@ -35,6 +35,7 @@
 # never load them automatically.
 blacklist aty128fb
 blacklist atyfb
+blacklist bochs-drm
 blacklist radeonfb
 blacklist cirrusfb
 blacklist cyber2000fb

... and in the previous working build (http://hydra.nixos.org/build/22779539/log/raw) bochs-drm was getting loaded:
machine# [   10.307559] [   10.316560] bochs-drm 0000:00:02.0: fb0: bochsdrmfb frame buffer device
machine# [   10.318086] bochs-drm 0000:00:02.0: registered panic notifier
machine# systemd[1]: Starting System Initialization.
machine# [   10.338183] [drm] Initialized bochs-drm 1.0.0 20130925 for 0000:00:02.0 on minor 0

Thanks; "registered panic notifier" doesn't look like a good sign :-) But better discuss bochs-drm separately, e.g. at the commit 0307c27.

The channel is at e1af50c4c4c0332136283e9231f0a32ac11f2b90. Thank you very much for your efforts!


Invalid parameter(s): license_key

Hey! Themes are working and key is valid, but when trying to use any plugin, as wps mass embedder im getting a problem that says:
All videos may have been already imported for the current search
Then if I go to logs, you can see Error Invalid parameter(s): license_key
No matter what plugin, even WP Script core gets that problem, is there anything wrong??
Anyways, thanks for everything!!!

hi, i just tested the wp-script plugin (2.1.9) and its plugins such as wps mass embedder and they seem to work fine in the latest version of wordpress, what version of wp-script do you have?

Im working with WordPress6.1.1

Im working with wordpress 6.1.1 and WP-Script core 2.2.7

Okay, just reinstalled the WP-Script,  to downgrade to 2.1.9 to test and now everything works... The problems comes when you update to 2.2.7, so as long as you stay at 2.1.9 everything is okay
Thanks!!!

well, create a new issue when any plugin except wp-script stops working or fails in something,
to update the whole api to the latest version.


Multithreading mismatched image header fix

Got this working about 2 weeks back. Been on break so wasn't able to submit a PR.
For my setup, it seemed to work as wanted, but it could definitely use more testing. Potential point of change is line 625 with the +1 if header still doesn't match up.

Oh sorry! I hadn't read your message carefully enough and didn't realize you wanted me to delete it.
Done.


Jitpack version badge displaying "invalid response data"

Are you experiencing an issue with...
shields.io
🐞 Description
I am trying to get the following jitpack version badge for my jitpack build but am getting a grey badge displaying "invalid response data", I have not had this issue previously with other repos on jitpack so am a little confused why this one is buggy
🔗 Link to the badge
https://img.shields.io/jitpack/version/com.github.cooldcb/GardeningTweaks
💡 Possible Solution
No response

The API request we make for the JitPack badge is the latest successful build endpoint: https://docs.jitpack.io/api/#latest-build
For your package, https://jitpack.io/api/builds/com.github.cooldcb/GardeningTweaks/latestOk returns an 200 OK with an empty object (which is why it is failing validation).
If I try another package, this works as expected
https://jitpack.io/api/builds/com.github.jitpack/maven-simple/latestOk
I'm not really that familiar with JitPack. Any ideas why we get this response? Maybe your project exists, but doesn't have any successful builds? If this is unexpected, this might be an issue with the upstream API.

Ahh I see what you mean, I'll go ahead and make an issue in jitpack's github, one thing that might be relevant is that I deleted and reran the build a couple times under the same release name, I wonder if this affects it at all

Issue has been resolved on jitpack's side, no further information was given unfortunately


Read only specific time segments?

I was wondering if it would be useful to be able to read only specific time segments (as opposed to the entire data), WDYT? This is probably a very niche feature, but I'm bringing it up because if we ever wanted to use edfio as a reader in MNE, then we'd need this functionality (and this would be a separate discussion on its own).

I think this would be a good addition! There might need to be different options to handle segment limits which do not coincide with sample times for all signals (in Edf.slice_between_seconds we currently take the easiest way by failing if that is the case). Would you be willing to create a PR for this?

I don't have the time to implement this feature currently. It is also not urgent at all, I just wanted to know if you were open to this addition in principle – so thanks, great 👍. If MNE devs decide that it would be worth having edfio replace or supplement their own reader, I can tackle this of course (but feel free to beat me to it if you want/need this feature earlier).

This would be a nice feature as well if we ever wanted to implement a viewer or read partial data from a network location for machine learning purposes.

I also think this would be very helpful! I am sometimes given cumbersome (~100GB) clinical iEEG data files that I only need a small time window and select channels from. Additional slicing functionality would be awesome!

As I'm not sure if #58 applies to your use cases @cbrnr and @jtmiles, I'll reopen this for now

I think this looks good for now 👍! If there is anything still missing for an MNE reader using edfio, I'll let you know 😄 (I don't have time to implement it in the near future).


Publish api and portal docker images to docker hub

Motivation
Need to be able to publish our api and portal images to hub.docker.com/vinyldns
Scope of change
Content trust should be enabled, more details can be found here: https://docs.docker.com/engine/security/trust/content_trust/
Care should be taken that when creating keys for the content trust signing process, that they are securely stored
There should be a process for publishing images to docker hub, including bumping the version number of our images. This will likely have to be done with first a pr to update build.sbt, as the version seems to be immutable

Blocking until we have a strategy for managing the secrets that is more robust than having them on a single developer's machine


[Question] how to use another translation?

I have these 2 messages:

appName: pretty clear, the application name. Used in various places such as headers
welcome: A welcome statement that should include the app name.

How does one combine these 2?
Option A: Duplicate the app name in the translation, and put it once in 'appName' on it's own, and once in 'welcome' where it needs to be.
Option B: Have the 'welcome' message get an argument, and in the app get the appName message, then pass it to the welcome message.
Option A sounds mostly terrible if you want to change the appName. While that may not happen frequently, this is just an example and I'm looking for a more guidelines/experienced question.
Option B sounds a bit better, but it feels weird to get a translation just to give it to another translation. I could be completely wrong though?
This is more of a guideline question since I'm not too familiar with translations in general, but I think it can also be benefit to other (probably new) people.

stackoverflow.com or other forums might be better suited for this kind of general question, which is not limited to package:intl or even Dart.
I personally think there is nothing wrong with Option B.


Makefile: enable backslash escapes for echo

Minor fix to enable interpretation of backslash escapes for echo
Signed-off-by: Nirmoy Das<EMAIL_ADDRESS>

test-me-please

@nirmoy thanks a lot for the commit!


Nodes multi selection doesn't work with selectNodesOnDrag disabled

Describe the Bug
I notice that nodes multi selection doesn't work when selectNodesOnDrag  is false, both in Controlled and Uncontrolled mode. It doesn't seems to be the right behavior as is doing a different functionality compared to nodes selection on drag.
Your Example Website or App
https://codesandbox.io/s/sandpack-project-forked-3l48jx?file=/App.js
Steps to Reproduce the Bug or Issue
Select a node, then click a second node with Meta/Command pressed
Expected behavior
All nodes should be selected and not only the last one
Screenshots or Videos
No response
Platform

OS: macOS
Browser: Chrome
Version: v10

Additional context
No response

I can confirm this has something to do with this line of code: https://github.com/wbkd/react-flow/blob/3548891b8e4f6ffbb9de1fbbef582d8eb55304c7/src/components/Nodes/wrapNode.tsx#L115
If you comment it out, you'll be able to multiselect nodes. However the logic here is too complicated to be simply disable this because this function guarantees when you drag another node, the previous selected nodes will be deselected.

I made a PR to fix this issue: https://github.com/wbkd/react-flow/pull/1988


Add --cafile command line option.

R=@rvagg?

A bit smelly, I understand that it's hard to do much better without a more heavy refactor. Things I don't like:

the use of cb only for errors, the fact that it has a cb argument at all in fact
the fs.readFileSync() to read the cert file

A begrudging lgtm since I understand the challenges of doing a better job, I would prefer the cb thing be handled but if you feel strongly enough that the way you've implemented it is good enough then go ahead.
Yet another refactor for the future I suppose.

I added a commit that lets the exception bubble up.  I'm a bit on the fence on whether it's an improvement; let me know what you think.

I'm happy with the clarity of the changes, but generally unhappy with the structure of the call chain but that's a matter for another day! lgtm


Short solution needed: "Array join query example" (clickhouse)

Please help us write most modern and shortest code solution for this issue:
Array join query example (technology: clickhouse)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Array join query example


DeviceButton is not present on Type definitions for Phaser 2.4.3

The type definitions doesn't match with the lib

DeviceButton is in the defs in the dev branch, unless you mean there is something wrong with the def itself?

I´m sorry. I mean in the definition for TypeScript (phaser.d.ts)

I understand, I meant did you check the defs in the dev branch? That is where we work on them when preparing the new build, and I can see DeviceButton in there.

Ahh ok, that´s rigth! I check´d the last release. Thank´s!


missing Ang 0918-0922 json

These angs are included in the 0917.json file. This is done because of the way the database segregates "sections" or "subsections" of bani. In this case if a shabad or such goes over multiple angs, it is included in the previous json file.
See here for example 0918.json file where it says source_page (meaning "ang") 922: https://github.com/ShabadOS/database/blob/dev/data/Sri Guru Granth Sahib Ji/0917.json#L10043


Merge pull request #1 from mybatis/master

pull request

是

是

是

是

Please do tests in your own repository. Thanks.


WIP: Read ~/.aws/config and use region from there

I am always using the [default] section of the config file.  If I should use the specific profile (as passed via --profile on the cli) then I need to add that in, so I marked this as WIP.

@kapilt - Should remove our default of us-east-1 now that we are reading from ~/.aws/config?
I checked how the aws command line tool works, and it doesn't seem to have a default if I don't supply a region:
$ AWS_CONFIG_FILE=/nonexistent aws ec2 describe-instances
You must specify a region. You can also configure your region by running "aws configure".

the question to me is does it break extant deploys, afaics instance iam role usage still pulls from metadata server, but instance iam user creds could potentially suffer. i think i'd like to see a env, config, fallback approach for the lookup still.

@kapilt - this was labeled WIP because it didn't yet read the specific profile section in the config file.  It sounds like that is necessary (based on a conversation on the SFU call this morning) so I'll submit another PR for that.

doh, my bad.

this is quite complex actually (DEFAULT vs default, sections, profile inheritance, etc), i'm thinking we just need to bite the bullet on temporary pain though and get the default region out of our code, and let the sdk do determination on this.


Router resolver

Created from https://github.com/angular/angular/issues/11607
Resolving doesn't whork if resolver returns not closed observable
resolve():Observable<any> | Promise<any> | any {
        let subject = new BehaviorSubject<number>(777);

        return subject.asObservable(); //won't work
        return subject.asObservable().first(); //will work
}

Please, document it somewhere. May be even here

Same issue: https://github.com/angular/angular.io/issues/2358

Same issue: #2358

No need to post duplicate issues, please close this one


Split App.svetle to smaller components

@all-contributors please add @davidnguyen179 for code, doc, design, ideas, infra, maintenance, review, test


Support for profile / cProfile

I can imagine getting a lot of use out of recipy when I'm optimizing code in a profile / tweak / profile tweak cycle. Would anything new need adding to support this?

Just to note our discussions at the sprint: it looks like the dump_stats method would need patching - and that should be all that is needed.

I'd be happy to have a bash at that. I should have a chance at some point in the next few days.


feat: Add getBalance to contracts and getContractBalance to providers

Closes #696
Marking this PR as draft until I figure out how to add tests for both of these new functions. (Please ignore some test code that I have pushed right now, I forgot to not include changes to those files before pushing)

[...] until I figure out how to add tests for both of these new functions

I'm not sure if isolating all e2e's apart from their source code is the best approach, but in the current setting, I believe these tests should go inside the package/fuel-gauge — a package solely dedicated to e2e stuff. I assume you'd need to deploy a contract and transfer funds to it first.
You might have to add things to the chainConfig as you did; my only concern is how we can keep this file documented since it is tough to read, and it can become increasingly hard to keep track of which test is using what. Currently, the chainConfig has many accounts with balances, aiming at the possibility of running tests in parallel, which we do not currently do. You can find some docs about this initial_state config here.
Although I'm trying to give you some thoughts on this matter, please know that I'm unfamiliar with these e2e tests, and I'm looking forward to seeing how you'll address this.
You might get better guidance from @camsjams on this one.

@arboleya Agreed. That's the approach I am going with now. I wrote an e2e test inside the fuel-gauge package and came across an issue (possibly) with our GraphQL API. Slack convo


Zenith doesn't work with Citus extension

Reported by @gchiappe on discord channel:
Hi again, I'm trying to do columnar operations using citus on zenith, I alrady loaded the extension but when I try to create a simple columnar table, server crashes, here is the pg.log output
2022-01-24 22:28:17.431 GMT [63916] CONTEXT:  Citus maintenance daemon for database 13010 user 10
2022-01-24 22:28:17.435 GMT [63622] PANIC:  Page 0 of relation 1663/13010/25126.0 is evicted with zero LSN
2022-01-24 22:28:17.435 GMT [63622] STATEMENT:  CREATE TABLE events_columnar (
	  device_id bigint,
	  event_id bigserial,
	  event_time timestamptz default now(),
	  data jsonb not null
	)
	USING columnar;
2022-01-24 22:28:17.446 GMT [63603] LOG:  sending message len 4144 beginLsn=0/1B520F0 endLsn=0/1B53120 commitLsn=0/1B520F0 truncateLsn=0/1B520F0 to localhost:5454
2022-01-24 22:28:17.451 GMT [63603] LOG:  sending message len 0 beginLsn=0/1B53120 endLsn=0/1B53120 commitLsn=0/1B53120 truncateLsn=0/1B53120 to localhost:5454
2022-01-24 22:28:17.635 GMT [63596] LOG:  server process (PID 63622) was terminated by signal 6: Aborted
2022-01-24 22:28:17.635 GMT [63596] DETAIL:  Failed process was running: CREATE TABLE events_columnar (
	  device_id bigint,
	  event_id bigserial,
	  event_time timestamptz default now(),
	  data jsonb not null
	)
	USING columnar;
2022-01-24 22:28:17.635 GMT [63596] LOG:  terminating any other active server processes
2022-01-24 22:28:17.636 GMT [63919] FATAL:  the database system is in recovery mode
2022-01-24 22:28:17.643 GMT [63596] LOG:  all server processes terminated; reinitializing
2022-01-24 22:28:17.856 GMT [63921] LOG:  [ZENITH] found 'zenith.signal' file. setting prev LSN to 0/18A7238
2022-01-24 22:28:17.856 GMT [63921] LOG:  database system was interrupted; last known up at 2022-01-24 22:26:48 GMT
2022-01-24 22:28:17.856 GMT [63921] LOG:  starting with zenith basebackup at LSN 0/18A90F0, prev 0/18A7238
2022-01-24 22:28:17.857 GMT [63921] LOG:  database system was not properly shut down; automatic recovery in progress
2022-01-24 22:28:17.857 GMT [63921] LOG:  redo starts at 0/18A90F0
2022-01-24 22:28:17.858 GMT [63921] LOG:  [ZENITH_SMGR] libpqpagestore: connected to 'postgresql://no_user:@<IP_ADDRESS>:64000'
2022-01-24 22:28:17.891 GMT [63921] LOG:  invalid record length at 0/1B53170: wanted 24, got 0
2022-01-24 22:28:17.891 GMT [63921] LOG:  redo done at 0/1B53120 system usage: CPU: user: 0.00 s, system: 0.01 s, elapsed: 0.03 s
2022-01-24 22:28:17.891 GMT [63921] LOG:  Continue writing WAL at 0/1B53170
2022-01-24 22:28:17.933 GMT [63921] PANIC:  Page 2 of relation 1663/13010/1259.1 is evicted with zero LSN
2022-01-24 22:28:17.933 GMT [63921] CONTEXT:  writing block 2 of relation base/13010/1259_fsm
2022-01-24 22:28:18.107 GMT [63596] LOG:  startup process (PID 63921) was terminated by signal 6: Aborted
2022-01-24 22:28:18.108 GMT [63596] LOG:  aborting startup due to startup process failure
2022-01-24 22:28:18.143 GMT [63596] LOG:  database system is shut down

Here is psql output:
psql -h <IP_ADDRESS> -p 55432 -U zenith_admin postgres
psql (14.1 (Ubuntu 14.1-2.pgdg20.04+1))
Type "help" for help.

postgres=# create extension citus;
CREATE EXTENSION
postgres=# CREATE TABLE events_columnar (
postgres(#   device_id bigint,
postgres(#   event_id bigserial,
postgres(#   event_time timestamptz default now(),
postgres(#   data jsonb not null
postgres(# )
postgres-# USING columnar;
PANIC:  Page 0 of relation 1663/13010/25126.0 is evicted with zero LSN
server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
!?>
```

This little patch to citus fixes it:
diff --git a/src/backend/columnar/columnar_storage.c b/src/backend/columnar/columnar_storage.c
index f5a35c1cf..c38182325 100644
--- a/src/backend/columnar/columnar_storage.c
+++ b/src/backend/columnar/columnar_storage.c
@@ -186,17 +186,17 @@ ColumnarStorageInit(SMgrRelation srel, uint64 storageId)
 	phdr->pd_lower += sizeof(ColumnarMetapage);

 	PageSetChecksumInplace(page, COLUMNAR_METAPAGE_BLOCKNO);
-	smgrwrite(srel, MAIN_FORKNUM, COLUMNAR_METAPAGE_BLOCKNO, page, true);
 	log_newpage(&srel->smgr_rnode.node, MAIN_FORKNUM,
 				COLUMNAR_METAPAGE_BLOCKNO, page, true);
+	smgrextend(srel, MAIN_FORKNUM, COLUMNAR_METAPAGE_BLOCKNO, page, true);

 	/* write empty page */
 	PageInit(page, BLCKSZ, 0);

 	PageSetChecksumInplace(page, COLUMNAR_EMPTY_BLOCKNO);
-	smgrwrite(srel, MAIN_FORKNUM, COLUMNAR_EMPTY_BLOCKNO, page, true);
 	log_newpage(&srel->smgr_rnode.node, MAIN_FORKNUM,
 				COLUMNAR_EMPTY_BLOCKNO, page, true);
+	smgrextend(srel, MAIN_FORKNUM, COLUMNAR_EMPTY_BLOCKNO, page, true);

 	/*
 	 * An immediate sync is required even if we xlog'd the page, because the

In a nutshell, the citus table creation bypasses the buffer manager, and writes the initial pages directly with the smgrwrite function. The pages it writes out have 0 as the LSN, which triggers the PANIC with Zenith. It's a safety check in Zenith to make sure that everything is WAL-logged, because any write that is not WAL-logged is lost with Zenith. In this case, the modification is in fact WAL-logged, by the `log_newpage' call, but the write already happened before that. So  the check in Zenith is a bit over-zealous in this case, and if you just disabled that PANIC in the Zenith code, it would work fine.
We could perhaps make the sanity check in Zenith smarter to try to catch safe patterns like that, if there are a lot of extensions out there that do that. Looking at Citus, it only does that in the above table initialization code. I'm going to submit that little patch to Citus, let's see if they're interested in merging it. IMHO it's a bit sloppy even without Zenith, as the pages are written to disk with LSN 0 even though they are WAL-logged, although it doesn't break anything with vanilla PostgreSQL.

creation of the table seems ok after the patch, but when trying to insert anything the Zenith postgres extension print this error: ERROR:  unknown relpersistence '                                 ', looking the Zenith extension source, it comes from pagestore_smgr.c@642. When looking at pg.log it shows the same but the blank spaces are shown as this: 2022-01-25 17:08:20.733 GMT [28990] ERROR:  unknown relpersistence '' (Hex: 0B, line tabulation?)

Ok, it worked for me. Did you compile Citus against the Zenith sources? 'SMrRelation.relpersistence' is a field that was added in Zenith codebase. If Citus was compiled against vanilla Postgres header files, that might explain it.

Ok, it worked for me. Did you compile Citus against the Zenith sources? 'SMrRelation.relpersistence' is a field that was added in Zenith codebase. If Citus was compiled against vanilla Postgres header files, that might explain it.

Ohhhh, I did not, I will build again against Zenith's postgres and try again

This was fixed in citus, closing. Thanks for the report!


Default precision on getting_started doesn't match example

I'm going through and using the getting started page and influxdb for the first time (new set of eyes). I noticed that the first select example (SELECT "host", "region", "value" FROM "cpu") returns the time as rfc3339, but when I did it on my Mac with the latest and greatest, I got ms. I had to enter precision rfc3339 to get it to match the example
URL for relevant page?
https://docs.influxdata.com/influxdb/v1.1/introduction/getting_started/
What products and version are you using?
Influx 1.1 for MacOS 10.11.6
Where did you look before opening the issue?
Nowhere

Thank you for pointing this out, @GeoffNicholls! We've added how to get that precision to the Getting Started.


Resolve dangling commits in master branch

Right now it's like this:

I've seen a few places where people have assumed that the stuff on master is important somehow and needs to be incorporated, like in this PR, and they have merged it in potentially causing conflicts. I think people will continue to assume that about master since it's one of git's fundamental branches.
I suggest that it somehow be indicated that these commits have been resolved. One way would be to merge master into dev as a true merge commit. Yes, it would make for an uglier commit history, and I prefer to rebase, but the alternative is I guess to leave these dangling commits there forever, which may be confusing.
Interestingly, even though there are duplicates on master and dev, the merge completes without conflicts (tried it locally).

I think I'll be rebasing master on dev for release, until we start pushing release branches we probably won't see many merges.
Maybe after this upcoming release we'll start moving to a more git-flow-esque style.

The dangling commits (EarlyStoryVisibleTimeoutPatch) are now on dev, and master is rebased on dev;

@Tyler-IN Fair enough.
As long as we're here, would you mind resetting master to get rid of those 2 commits? And just have it equal to where dev is now I guess? Idc if it's left there for the rest of time, it's just that the commits added were already in dev, but have re-added some junk to the *.csproj it looks like.
Perhaps you could reset master to 2 commits ago 929817c ? (Add Feats section and snow detection fix to README)

Check out the PR to sync master first - do we need to discard that?

I think we're good now.


The Open Documentation options have inconsistent effects, some options can't open custom doc.

Godot version
4.0beta1, 4.0beta2
System information
Windows 10
Issue description
godot 4 supports the GDScript documentation generation system. So I tried to create a custom document:
class_name CustomNode extends Node

## Custom node property description
@export var custom_var = 1

But with the exception of F1 Search Help, you can only open a custom doc by clicking the Open Documentation option in the export variable field(The green box in the picture). When you try to click on the red box in the pictures — the node's context menu option in scene dock and the button on top right corner of inspector dock — you will open the documentation for the base class(Node) instead of the user-defined document(CustomNode in this case).

I don't know if it's a bug, I do think it is.
Steps to reproduce
omitted
Minimal reproduction project
No response

So some thoughts: if you right-click a node, I believe it may make sense to open the documentation related to that node type. Otherwise it's harder to access that part of the docs!
So this is maybe less of a bug and more of a feature request? We could add a "Open Attached Script Documentation" option, or allow right-clicking the little script icon itself?

My initial thought was: since right-clicking on a Node2D doesn't open the doc for its parent Node, the same should apply to a CustomNode, especially when I have crafted document and icon for the node, like this:

When other users use my plugin, they would definitely want to open the doc for the gear icon node, rather than its parent class doc.
@anvilfolk But your comment reminded me that my thought was one-sided - not all nodes are like plugin nodes. Most of the time users just want to open the parent class doc of the node rather than the node's own document.
So "adding an Open Attached Script Documentation option" is a good solution. And I have more ideas:

Only open the doc of a script if it uses documentation comment syntax ##, otherwise open its parent class doc. This solution wouldn't require any additional options or buttons.

Clicking on the title in the inspector with a left-click or right-click menu option to open its documentation:

I think I finally understand what you were saying in the first place (about CustomNodes)! Thank you for clarifying! :)
So in that case there are 3 layers of things that people might want access to the documentation, right?

Attached script docs
CustomNode docs
Base node docs

I think since accessing each of these could be a big part of the workflow for using documentation, we want to do some serious thinking about how to access them in a consistent, intuitive manner.
I really like option 2. above! Perhaps each of those could have a little "Doc" icon to the right that opens the relevant documentation. That way it's super visible & easily accessible. Also, I believe the attached script shows up there as well, so that would give us access to everything, visually and intuitively!
I'm not so certain about 1., because sometimes it'd open one thing, sometimes another, and it'd depend on whether documentation exists - which users shouldn't have to be aware of. So I think it would be confusing! If the custom node is in GDScript, I believe #72095 will create a stub that you can use to access the base class. But I'm not super certain because I haven't tested it with custom nodes!


Import webpack using "* as webpack" syntax.

Otherwise curtain typescript configuration might complain during "tsc --noEmit" with the following error:
node_modules/fork-ts-checker-webpack-plugin/lib/ForkTsCheckerWebpackPlugin.d.ts:1:8 - error TS1259: Module '"/Users/apepper/repos/scrivito_js/js/node_modules/@types/webpack/index"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

1 import webpack from 'webpack';
         ~~~~~~~

  node_modules/@types/webpack/index.d.ts:49:1
    49 export = webpack;
       ~~~~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

node_modules/fork-ts-checker-webpack-plugin/lib/logger/LoggerFactory.d.ts:1:8 - error TS1259: Module '"/Users/apepper/repos/scrivito_js/js/node_modules/@types/webpack/index"' can only be default-imported using the 'allowSyntheticDefaultImports' flag

1 import webpack from 'webpack';
         ~~~~~~~

  node_modules/@types/webpack/index.d.ts:49:1
    49 export = webpack;
       ~~~~~~~~~~~~~~~~~
    This module is declared with using 'export =', and can only be used with a default import when using the 'allowSyntheticDefaultImports' flag.

Found 2 errors.

At stale bot: I think this PR is still valid and should be reviewed/merged.

Thanks for the PR, Solved by #699 :)


Add alias for yarn remove

Adds a simple alias that maps yr to yarn remove, also removes extra whitespace from y alias.

Looks good to me @figitaki :+1: . I have this https://github.com/robbyrussell/oh-my-zsh/pull/6635 waiting to be merged as well.


https gateway with credentialName causes pilot tls error.

Bug description
Created this gateway and k8s secret
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: core-gateway
  namespace: istio-system
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - "*"
    port:
      number: 443
      name: https
      protocol: HTTPS
    tls:
      mode: SIMPLE
      credentialName: test-cert
  - hosts:
    - '*'
    port:
      name: http
      number: 80
      protocol: HTTP
    tls:
      httpsRedirect: true

Pilot spits out this error
	* gateway listener <IP_ADDRESS>_443 validation failed: invalid Listener.FilterChains[0]: embedded message failed validation | caused by: invalid FilterChain.TlsContext: embedded message failed validation | caused by: invalid DownstreamTlsContext.CommonTlsContext: embedded message failed validation | caused by: invalid CommonTlsContext.TlsCertificates[0]: embedded message failed validation | caused by: invalid TlsCertificate.CertificateChain: embedded message failed validation | caused by: invalid DataSource.Filename: value length must be at least 1 bytes

If i choose to use privateKey and serverCertificate instead of credentialName this works.
I use the same secret and gateway in a istio 1.1.8 cluster and it works great.
Affected product area (please put an X in all that apply)
[X] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version)
istio = 1.2.4
kubernetes = v1.13.7
How was Istio installed?
helm template helm/istio --name istio --namespace istio-system  --set global.mtls.enabled=true --set global.controlPlaneSecurityEnabled=true --set global.outboundTrafficPolicy.mode=ALLOW_ANY --set gateways.istio-ingressgateway.enabled=true --set gateways.istio-egressgateway.enabled=false --set tracing.enabled=true --set grafana.enabled=true --set mixer.enabled=true --set prometheus.enabled=true --set kiali.enabled=true  --set global.k8sIngress.enableHttps=true > istio.yaml
Environment where bug was observed (cloud vendor, OS, etc)
AKS

Same here
$ istioctl version --remote
client version: 1.3.0-rc.3
control plane version: 1.2.5
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

This is a duplicated issue of https://github.com/istio/istio/issues/12761. You need to enable ingress sds --set gateways.istio-ingressgateway.sds.enabled=true.


Firefox Add-on?

Description
Can this be also ported to work as a Firefox add-on?
Can it somehow take advantage of the containers feature in firefox?
Other information
No response
Acknowledge

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

Hi @raghuvv, thank you for your issue!
Actually, Firefox add-on is already available.
https://addons.mozilla.org/ja/firefox/addon/aws-peacock-management-console/

Thanks for adding the link to README - sorry I assumed there was no Firefox add-on


[CLI] Logging dataframe  will rasie an exception

Description
Logging a table with DataFrame will casue an exception in wandb 0.10.30 ( but version 0.10.11 is ok ):
Code:
data = [
    {"c": 1},
    {"c": 2},
]
df = pd.DataFrame(data)

wandb.log({
    "table": wandb.Table(dataframe=df)
})

Exception:
wandb: ERROR Problem finishing run
Traceback (most recent call last):
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 1543, in _atexit_cleanup
    self._on_finish()
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 1679, in _on_finish
    self.history._flush()
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_history.py", line 59, in _flush
    self._callback(row=self._data, step=self._step)
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 846, in _history_callback
    self._backend.interface.publish_history(
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/interface/interface.py", line 217, in publish_history
    data = data_types.history_dict_to_json(run, data, step=step)
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 2067, in history_dict_to_json
    payload[key] = val_to_json(run, key, val, namespace=step)
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 2141, in val_to_json
    return val.to_json(run)
  File "/home/my/.local/lib/python3.8/site-packages/wandb/data_types.py", line 492, in to_json
    json_dict = super(Table, self).to_json(run_or_artifact)
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 500, in to_json
    artifact_entry = self._get_artifact_reference_entry()
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/data_types.py", line 258, in _get_artifact_reference_entry
    self._artifact_target.artifact.wait()
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_artifacts.py", line 631, in wait
    return self._logged_artifact.wait()
  File "/home/my/.local/lib/python3.8/site-packages/wandb/sdk/wandb_run.py", line 2474, in wait
    assert isinstance(self._instance, ArtifactInterface)
AssertionError

Wandb features
wandb.log()
Environment

OS: Ubuntu 20.04
Python Version: 3.8.5

@myaisv this is an error with the way we're passing around settings.  Are you running this against our cloud hosted server or a server that you're running yourself?  This generally happens if you call wandb.login() from within jupyter notebook instead of logging in the host machine.  Can you try running wandb login from the command line to configure the machine and see if this error is still occuring.
You can also set the WANDB_API_KEY environment variable, and the WANDB_BASE_URL environment variable if you're using a server that you're running yourself.


Support For WebM

By any chance this allows me to save videos in Google's WebM format? also is there any ways that I can use FFMPEG to have custom formatting options?

Varun Raj <notifications<EMAIL_ADDRESS>şunları yazdı (21 Oca 2017 12:05):
By any chance this allows me to save videos in Google's WebM format? also is there any ways that I can use FFMPEG to have custom formatting options?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/lwansbrough/react-native-camera/issues/561, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAoZ3965K_to0CWln0qtQtOAAZW1IrP2ks5rUcpdgaJpZM4LqA4z.


ProjectionEndpoint delivery tests

This PR adds tests for ProjectionEndpoint delivery strategy.
Also, it fixes a minor code duplication — all ...Endpoint classes now use own static of method to create new instances instead of explicit new ...Endpoint<> calls.
The framework version left intact.

@alexander-yevsyukov PTAL.


Rendering Offsets With Custom Model Data- Feature Request

Is there anyway to get more options for offsets when it comes to configuring non-vanilla "tools"? In particular, custom model data items. Generally, things like sticks and bones are assigned custom model data to look like swords/bows. If we could have more customization of adding "items" to backtools, that would be great. If not, no worries!

I wasn't sure if I should submit an issue for this, but I couldn't find any other contact. <3

Hello and thanks for submitting this issue.
Currently I don't have the time to work on more features on my own. However i don't have any problems if  other contributors would like to see this feature in the game.  I'm going to ping the one that has helped me keeping the mod up to date in case he is able to help @FireInstall.

Could you be more specific about what you need? Then I can take a look into the code and tell you what is possible for me and what isn't.

Just make it customizable in the config or does it need to be ingame?
The belt or the back items or both?
Rotation around what axis?
Offset what directions?
Or do you need presets for something like bows...?
Anything else?

Sure!

Config options would be totally sufficient!
The issue for us is really just with the belt option.
It's less of rotation and more of shifting the item to be closer/further from the players side.
Either side of player (+/-), sort of like closer to their hip vs further away (side to side, not backwards and forwards).
No need for bows, they seem to offset correctly with custom model data!
Nope! Thank you so much! <3

Ok, I will add this to my todo list and report back soon™

I'm reporting back with a success: unofficial 1.20.4-1
I added an offset to the config, where you can optionally specify Nbt data. There you can add your CustomModel ID.
Please test and tell me your thoughts about it!

Sweet, this looks perfect!
I'm swamped with Uni so don't have much time to test atm....I'll get back to you ASAP!
Thanks again <3

With the new components of the 1.20.5 the syntax will be {"minecraft:custom_model_data": 1}

Well, any updates @SpringToger ?

So sorry, I completely forgot to reply!! This is perfect!! Thank you again!!

Nice, thank you for your suggestion and testing.
Now we wait for @luisdanieldlcg to merge this.
If you need a 1.21 version say a word I just did update the rest of this mod.

Newer versions are always appreciated! No worries if you're busy!

Don't worry yourself, it was pretty fast to merge the two branches. Here you go: inoffical 1.21 + offsets


The site has a video of an empty chair, with little to no sound for 30 minutes

It's an empty chair, with inaudible talking amongst conference goers.  There is no content in this video.  What is the procedure to remove this video?
http://pyvideo.org/pygotham-2016/creating-a-bittorrent-client-using-asyncio.html

Ha, good catch! just send a PR removing the corresponding JSON file

This can be closed ( @Daniel-at-github , @lgh2 )


Update VS Code paths to detect user-scoped installs

VS Code now supports being installed into a user directory instead of Program Files (to avoid needing Admin permissions for updates etc.). Since we have hard-coded default install paths for flutter doctor to detect VS Code/extensions, we should add the new default paths to it.
(There's some info on this in the GH Desktop repo, which is having a similar change).

Fixed by #21070, thanks @SevereCloud!


Turn off rootless gateways

Gateways running as rootless can crash new gateways. There are atleast
two unique crash signatures.
Partially-Fixes: https://github.com/istio/istio/issues/26690
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@sdake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
508815683f4b9cbce078fdacb7da6d2eb4ac49cc
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

https://github.com/istio/istio/issues/27566

@howardjohn I used the helm manifests directly - no operator involved.

But 100% of our users following our documentation will not use helm directly and will therefor get unexpected results when transitioning from rootless to non-rootless upon upgrading with this patch.

oh, you mean to indicate there is an additional defect in the patching logic of the operator that will trigger upgrade problems?

Related: https://github.com/istio/istio/pull/27403, https://istio.slack.com/archives/C014RC64VD4/p1600357953076200

@howardjohn thanks for the slack context and bug tracker. I am not sure if you took a look at the issue I filed - the problem I was looking at was related to canary gateway deployments. Are you (or is someone else) already implementing this work?
If so, no need for me to solve it twice.
Cheers,
-steve

I fully agree with your conclusion of "At this point, I recommend disabling RunAsNonRoot by default in the gateway charts, and will be submitting a PR that does this.", as was agreed in Env WG a week or 2 ago. However, I do not know how to actually do this because of the operator issues, so I am no longer working on this.

@howardjohn thanks, I am a bit out of the loop. I have missed the last two env wg meetings for personal reasons. I will have someone take a look at fixing the operator as it seems @ostromart is busy atm 👍
Cheers,
-steve

@sdake: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cc/ @istio/wg-user-experience-maintainers

I spoke with @costinm . He was going to do this work but handed off to me. thanks Costin!
Cheers,
-steve

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test release-notes_istio

gencheck_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test release-notes_istio

gencheck_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test gencheck_istio

unit-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible - I have updated the description for easier review.
Cheers,
-steve

@sdake I'm feeling a bit slow today.
Suppose I have installed Istio 1.7.0.  Can you suggest the commands I would use to add a canary of master, with and withing canaried ingress?  I'd like to try it out.

@sdake I'm feeling a bit slow today.
Suppose I have installed Istio 1.7.0. Can you suggest the commands I would use to add a canary of master, with and withing canaried ingress? I'd like to try it out.

Great request. When I did the implementation work here, part of my workflow involved sed. and I used only the native helm charts (with template). I will sort out an example workflow (using the basic building block helm commands first) - that way - the workflow is a little more understandable for those implementing the layers on top of helm.
Thank you for making the request.
Cheers,
-steve

@howardjohn @sdake I have opened an issue for disabling the RunAsNonRoot by default in the gateway charts: https://github.com/istio/istio/issues/27755
I can work on that from the operator's perspective.

@houshengbo the change is within this PR to do the work. Our operator code simply renders the helm charts in the repository via helm template and then applies the results. You are free to pull out the runasroot change in this PR if you like.
It is blocked on a different issue, which @ostromart may have finished by now.
Cheers,
-steve

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test release-notes_istio

gencheck_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test gencheck_istio

unit-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test unit-tests_istio

integ-helm-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn I have read your awesome RFC for this work - and think its superior to the RFC I produced (based upon ideas from you Costin and Lin). Are you interested in taking over this work?

@howardjohn I have read your awesome RFC for this work - and think its superior to the RFC I produced (based upon ideas from you Costin and Lin). Are you interested in taking over this work?

I can continue the lifecycle management work for gateways. But have some questions before I can take over.
@sdake

Do we want to do both this revision based gateways and John's injection based approach? which one should come first?
What's the current status of this PR? any other blockers other than https://github.com/istio/istio/issues/27755?

@elfinhe I don't have a great answer to your question about both. I prefer one solution in general to any problem, although if both are needed, both are needed. It would be great to work with you on this if you want to join forces.
Do you believe both are needed?
This PR was just a simple prototype. I have an unapproved RFC that needs editing attention. Feel free to add yourself as a co-author to the RFC. If we can achieve approval, then this work should continue.
My understanding is the blocker above has been fixed by @dgn in PR https://github.com/istio/istio/pull/28268.
The Istio RFC: Revision Gateway Upgrade describes the approaches considered for gateway upgrades in this PR.
I also noticed you have an RFC that is empty in the team drive here Istio RFC: Multi-Revision Lifecycle Management.
I will create an enhancement request in the enhancements repository to capture the gateway revision upgrades. I'll link that here when I get done creating the request (in a few hours).
Whatever we do as a group, the work should be well considered and correct the first time - as the upgrade approach churn frustrates Istio's customers.
Cheers,
-steve

@elfinhe I don't have a great answer to your question about both. I prefer one solution in general to any problem, although if both are needed, both are needed. It would be great to work with you on this if you want to join forces.
Do you believe both are needed?
This PR was just a simple prototype. I have an unapproved RFC that needs editing attention. Feel free to add yourself as a co-author to the RFC. If we can achieve approval, then this work should continue.
My understanding is the blocker above has been fixed by @dgn in PR #28268.
The Istio RFC: Revision Gateway Upgrade describes the approaches considered for gateway upgrades in this PR.
I also noticed you have an RFC that is empty in the team drive here Istio RFC: Multi-Revision Lifecycle Management.
I will create an enhancement request in the enhancements repository to capture the gateway revision upgrades. I'll link that here when I get done creating the request (in a few hours).
Whatever we do as a group, the work should be well considered and correct the first time - as the upgrade approach churn frustrates Istio's customers.
Cheers,
-steve

i'd say given the fact that we found some issues in revision based upgrade and there are new updates from istio itself (e.g,. external istiod), we may need to step back to re-visit the requirements for revisions.
Here is the doc that we can talk in tomorrow's WG meeting:
Istio RFC: Revisioned Istio Lifecycle Requirements.

@sdake: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test release-notes_istio

gencheck_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test gencheck_istio

unit-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test unit-tests_istio

integ-helm-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
93fb5763fffeaabb15e77427cb0e9fbbc2a2870c
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Upsert Error code

Everytime I try to upsert I get the following error :
[TypeError: Cannot construct a Request with a Request object that has already been used.]
Environnement
"next": "13.2.4"
"typescript": "4.9.5"
"pinecone-client": "^1.1.0"
$ node -v
v18.12.1

Source code
import { PineconeClient } from "pinecone-client";

export type Metadata = { userId: string; text: string;};

export const pinecone = new PineconeClient<Metadata>({
  apiKey: process.env.PINECONE_API_KEY,
  baseUrl: process.env.PINECONE_BASE_URL,
  namespace: process.env.PINECONE_INDEX
})

await pinecone.upsert({
    vectors: [
    {
      id,
      values: vectorEmbedding,
      metadata: { userId: user.id, text },
    },
  ],
})

vectorEmbedding is a 1536 dimension vecteur of type number[]
(Returned from openAI embeddings)

This is an issue with the fetch Request object. It means something else is modifying the Request.
Are you using the new Next.js app directory or edge functions?

I am using the nextJS app directory, but no edge functions ...
I also have a auth-middleware in place.
next.config.js
/** @type {import('next').NextConfig} */
const nextConfig = {
  experimental: {
    appDir: true
  },
}

module.exports = nextConfig

middleware.ts
import { withAuth } from "next-auth/middleware"
import { NextResponse } from 'next/server'
import { getToken } from 'next-auth/jwt'

export default withAuth(
  async function middleware(req) {
    const token = await getToken({ req })
    const isAuth = !!token

    if (isAuth) {
      return NextResponse.next()
    }

    const loginUrl = new URL('/api/auth/signin', req.url)
    loginUrl.searchParams.set('from', req.nextUrl.pathname)

    return NextResponse.redirect(loginUrl)
  }
)

I changed my auth middleware and there is no problem anymore.
Thanks for pointing me in the right direction.

I have deleted the middleware but the error is still there.
The error happens everytime I use pinecone-client (here an exemple on the delete-index api endpoint)
async function handler(req: NextApiRequest, res: NextApiResponse) {

  const session = await getServerSession(req, res, authOptions)

  if (!session || !session?.user) {
    return res.status(403).end()
  }

  if (req.method === "DELETE") {
    const id = req.query.id as string
    try {
      // Find item in Database
      const item = await db.library.findFirst({
        where: { id: id, userId: session.user.id }
      })

      if(!item)
        return res.status(400).end()

      // Remove index from Pinecone -- ERROR HAPPENS HERE. IF COMMENTED OUT, NO PROBLEM
      await pinecone.delete({
        ids: [item?.embeddingId]
      })

      // Remove entry from Database
      await db.library.delete({
        where: {
          id: id
        },
      })

      return res.status(204).end()
    } catch (error) {
      console.log(error)
      return res.status(500).end()
    }
  }
}

Have you tried running the code outside of Next? This error is usually caused because they patch the global fetch for caching in a suboptimal way that causes all kinds of issues. You'll see similar issues with any other libraries that use fetch.

I didn't find any way to make it work with nextJS.
It was quicker to write my own code which works.
I think it is caused somewhere around your fetch-api.ts line 20 👍
const body = await response.clone().json();
My own Module (working with nextjs)
export type PineconeMetadata = { userId: string; text: string;};

type PineconeConfigOpts = {
  apiKey?: string;
  baseUrl?: string;
  namespace?: string;
}

export type PineconeVector = {
  id: string;
  values: number[];
  metadata: PineconeMetadata;
}

type TPineconeError = {
  code: number,
  message: string,
  details: [
    {
      typeUrl: string,
      value: string
    }
  ]
}

type PineconeUpsertResponse = {
  upsertedCount: number;
}

type PineconeQueryResponse = {
  matches: Array<{
    id: string,
    score: number,
    values: number[],
    metadata: PineconeMetadata
  }>;
  namespace: string;
}

type PinceconeUpsertArgs = {
  vectors: PineconeVector[]
}

type PineconeQueryArgs = {
  topK: number,
  includeValues?: boolean,
  includeMetadata?: boolean,
  vector?: number[]
}

type PineconeDeleteArgs = {
  ids?: string[],
  deleteAll?: boolean,
}

export class PineconeClient {
  apiKey: string;
  baseUrl: string;
  namespace?: string;

  constructor(config: PineconeConfigOpts) {
    const apiKey = config.apiKey || process.env.PINECONE_API_KEY
    const baseUrl = config.baseUrl || process.env.PINECONE_BASE_URL
    if(!apiKey) {
      throw new Error('Missing Pinecone API key. Please provide one in the config or set the PINECONE_API_KEY environment variable.');
    }

    if(!baseUrl) {
      throw new Error('Missing Pinecone base URL. Please provide one in the config or set the PINECONE_BASE_URL environment variable.');
    }

    this.apiKey = apiKey;
    this.baseUrl = baseUrl;
    this.namespace = config.namespace;
  }

  async upsert({ vectors }: PinceconeUpsertArgs) {
    return fetch(`${this.baseUrl}/vectors/upsert`, {
      method: "POST",
      headers: {
        'Api-Key': this.apiKey
      },
      body: JSON.stringify({
        vectors,
        namespace: this.namespace
      })
    }).then(async (res) => {
      const result = await res.json();
      if(!res.ok) throw new PineconeError(res.status, result as TPineconeError)
      return result as PineconeUpsertResponse
    })
  }

  async query({topK, includeValues, includeMetadata, vector}: PineconeQueryArgs) {
    return fetch(`${this.baseUrl}/query`, {
      method: "POST",
      headers: {
        'Api-Key': this.apiKey
      },
      body: JSON.stringify({
        topK,
        includeValues,
        includeMetadata,
        vector,
        namespace: this.namespace
      })
    }).then(async (res) => {
      const result = await res.json()
      if(!res.ok) throw new PineconeError(res.status, result)
      return result as PineconeQueryResponse
    })
  }

  async delete({ ids, deleteAll }: PineconeDeleteArgs) {
    return fetch(`${this.baseUrl}/vectors/delete`, {
      method: "POST",
      headers: {
        'Api-Key': this.apiKey
      },
      body: JSON.stringify({
        ids,
        deleteAll,
        namespace: this.namespace
      })
    })
    .then(async (res) => {
      const result = await res.json()
      if(!res.ok) throw new PineconeError(res.status, result)
      return result
    })
  }
}

export class PineconeError extends Error {
  public err: TPineconeError;
  public status: number;

  constructor(status: number, err: TPineconeError) {
    super(err.message);

    // Ensure the name of this error is the same as the class name
    this.name = this.constructor.name;

    // Set stack trace to caller
    if (Error.captureStackTrace) {
      Error.captureStackTrace(this, this.constructor);
    }

    this.err = err
    this.status = status;
  }
}

I looked into it further and this is being caused by Next.js caching interfering with the Request object. You should file this as a bug in the Next.js repo.


Specify in the documentation that component that holds props.initialize should be a class

First of all keep in mind that I'm a react newb. I wasted a good bit of time before realizing that props.initialize() can't be used inside function component, is it really the case?
As react leans more towards function components I feel like it should be stated somewhere in the docs that this package will only work with class holding the initializer and that the function will not work.
Which versions of react and react-localize-redux are you using?
react - 16.8.6
reat-localize-redux - 3.5.3

Not sure what issue exactly you were having but when I tried this within a function component in Typescript I was getting this error.
I managed to get around this by placing the initialize call in a useEffect() hook:
import * as React from "react";
import { renderToStaticMarkup } from "react-dom/server";
import { withLocalize, LocalizeContextProps, Translate } from "react-localize-redux";
import * as enTrans from "../translations/en.json";
import * as nlTrans from "../translations/nl.json";

export interface AppProps extends LocalizeContextProps {
}

const App: React.FC<AppProps> = ({ initialize, addTranslationForLanguage }) => {
    React.useEffect(() => {
        initialize({
            languages: [
                { name: "English", code: "en" },
                { name: "Dutch", code: "nl" }
            ],
            options: { renderToStaticMarkup }
        });

        addTranslationForLanguage(enTrans, "en");
        addTranslationForLanguage(nlTrans, "nl");
    }, []); // <-- this empty array stops the hook being called every time the comp rerenders

    return (
        <div>
            <Translate id="greeting" />
        </div>
    );
}

export default withLocalize(App);

I'm fairly new to hooks myself so there might be a preferred implementation, but this at least got my app working

There is no dependency that requires you to use class components vs functional components. Following the current docs you would just use the withLocalize HOC, which is demonstrated in the docs using both class and functional components.


[SPARK-46513][PS][TESTS] Move BasicIndexingTests to pyspark.pandas.tests.indexes.*

What changes were proposed in this pull request?
Move BasicIndexingTests to pyspark.pandas.tests.indexes.*
Why are the changes needed?
test code clean up
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

ci: https://github.com/zhengruifeng/spark/actions/runs/7328874410/job/19957763795

Merged to master.


KHR_texture_transform

Hi, is there support for KHR_texture_transform. I tried injecting the extensions, but I don't think it works.
If it isn't supported, do you plan on supporting in future?
Thanks!

The extension is fully supported (https://github.com/rdeioris/glTFRuntime/blob/master/Source/glTFRuntime/Private/glTFRuntimeParserMaterials.cpp#L135) but notice that very few exporters have it.

Thank you Roberto. I will play with a little more; I didn't get expected results the first time, but I might be just doing something wrong. My intention is to post-process gltf files after export using some Python api like pygltflib. But for now, I was just manually inserting the key-values. Thanks again!


Directions on pin not showing up on Swift 3

Hello,
I just converted the code to Swift 3 and unable to see the directions when clicking on the selected pin nor does the image of the car show up.

func getDirections(){
if let selectedPin = selectedPin {
let mapItem = MKMapItem(placemark: selectedPin)
let launchOptions = [MKLaunchOptionsDirectionsModeKey : MKLaunchOptionsDirectionsModeDriving]
mapItem.openInMapsWithLaunchOptions(launchOptions)
}
}
The func getDirections is in the Viewcontroller.swift but it doesn't show up on the simulator. Is there a way to get it to work?
Thanks

me too

Try this. I got mine to work:
extension ViewController : MKMapViewDelegate {
func mapView(_ mapView: MKMapView, viewFor annotation: MKAnnotation) -> MKAnnotationView?{

    guard !(annotation is MKUserLocation) else { return nil }

    let reuseId = "pin"

    if let pinView = mapView.dequeueReusableAnnotationView(withIdentifier: reuseId) as? MKPinAnnotationView {

        return pinView

    } else {

        let pinView = MKPinAnnotationView(annotation: annotation, reuseIdentifier: reuseId)

        pinView.pinTintColor = UIColor.orange
        pinView.canShowCallout = true
        let smallSquare = CGSize(width: 30, height: 30)
        let button = UIButton(frame: CGRect(origin: CGPoint.zero, size: smallSquare))
        button.setBackgroundImage(UIImage(named: "car"), for: UIControlState())
        button.addTarget(self, action: #selector(ViewController.getDirections), for: .touchUpInside)
        pinView.leftCalloutAccessoryView = button

        return pinView
    }
}

}


Remove degenerate triangles from collision mesh

Fixes #1084. Using the same condition found in TriangleMeshImplicitObject.cpp, this PR prevents degenerate triangles from being added to the collision mesh. Doesn't seem to have a performance hit.

@joseph-kaile I had to change UE_SMALL_NUMBER to an actual number because it wasn't compiling, but this seems to work well! I can't trigger the debug asserts in 03_CesiumDenver anymore, and the framerate does not noticeably hitch when I leave the cube.

@j9liu just to confirm: are you still able to reproduce the hitches in main, but not in this branch?

Yep. I see this lovely view in debug mode:

and in release it freezes up, then prints all these degenerate triangle warnings to the console:

So this PR is a major improvement.

Thanks @j9liu! BTW, that lovely view will become much more useful if you install the (enormous) debug symbols for UE. Once you get your new laptop. :)

@joseph-kaile can you take a look at the build failures on macOS / Linux / Android? Once those are fixed, I think we're ready to merge this.

Thanks @joseph-kaile !


AMQP Connection Factory automaticRecoveryEnabled Property

Spring AMQP prefers this setting to be false (Spring AMQP has had its own recovery mechanism since day 1).
Over the years we have fixed corner cases where, when the setting is true, problems result because of conflicts with the built-in recovery.
Since 4.0, the rabbit client now sets this to true by default; Spring AMQP disables it by default, unless the connection factory is built externally.
Since the connectors project provides an "external" com.rabbitmq.client.ConnectionFactory it defeats Spring AMQP's default behavior.
Please consider setting this property to false when creating the factory. Also consider using the RabbitConnectionFactoryBean to create the factory (it will set the property to false by default).

Fixed via #234


Simplify models

@Muennighoff should we get this PR merged in?

Ran a test on some of the models, merged with main and added a minor fix for #1115 - have enabled auto-merge as well.


Initial performance measurements

We know there's a penalty for task local lookups -- since it's a thread local, but this is inherent to swift concurrency.
We should measure how much it costs -- preferably in a more real app than a synthetic benchmark where it'll just dominate everything.

done!


Bug: The 'Drives' widget displays inaccurate information about free space on drives.

Description
When you move, copy, or delete files, the 'Drives' widget on the 'Home' page does not update information about free space on the disks.
Steps To Reproduce

Open 'Files' and select a drive.
Copy, move (to another drive), or delete files.
Navigate to the 'Home' page and check the free space on the selected drive.
Compare it with the free space displayed in Windows Explorer or Windows Settings.
Bug: The 'Drives' widget shows inaccurate information about free space on drives.

Requirements
The 'Drives' widget displays accurate information about free space on drives.
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3930
Log File

Thanks for the feedback, We're tracking this in #6182 . You can check there or click subscribe in the right sidebar for updates.


Clarify issue template wrt UI bug reports

I noticed on chat and otherwise we are telling people the same things. Maybe changing the template can help.

excellent suggestions @jorgheymans


Font::operator bool

Description
This change eases calling code of Font that depends on the state of whether Font has actually loaded a font internally. I am aware there are simple workarounds, such as keeping a bool next to a Font. However that approach makes calling code a bit less readable, in my opinion. Adding an operator bool will make the class feel more elegant to use, for the use-case I described above.
Tasks

[x] Tested on Linux
[ ] Tested on Windows
[ ] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

How to test this PR?
sf::Font font;
std::cout << "Font loaded: " << (font ? "yes" : "no") << '\n'; // no
font.loadFromFile(...);
std::cout << "Font loaded: " << (font ? "yes" : "no") << '\n'; // yes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 51.899%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
10475

Relevant Lines:
19003

💛  - Coveralls


[WIP][Do Not Submit] Experimental gRPC-Swift support

looks promising! Just a few comments/questions on library structure for now.

Thanks for the review! This is far from ready though, I am mostly hacking something together quick and dirty.


Pass --all-files flag to the command being run during the hook

:zap: Summary
In #120, --all-files flag was introduced. However, when some hook executes a command, the latter has no way to determine if the flag was passed or not because lefthook does not preserve it / does not do anything to tell the command about this flag.
Value
Some programs are designed to support only-changed mode, when the program is applied only to the files which have been changed. Calling such a program from lefthook's run invocation without any sign of --all-files being passed (that is, all the files being processed by the program, not only changed ones) leads to a) extra work in the program, b) conflict between the lefthook running with all files and the program running with only changed ones.
Passing --all-files or any equivalent of the flag would help some programs to save some time and not get into conflict with lefthook. That would eliminate the ambiguity and make results coincide with the expectations.
Behavior and configuration changes
Lefthook should pass --all-files or an equivalent to the program being called, if the mentioned flag is passed to lefthook itself.

Hi @mrexox!
Forgot to say that there may be a script (e. g. a linter) that checks only changed lines inside only changed files. It uses information from git about changes and tries to find those changed lines. But it is sometimes useful to do a check for all the lines in all files, regardless of changes. This is where --all-files (and some sign of it being passed) becomes helpful. Without the flag / an equivalent, there will be the conflict I described above because custom program will check only changed lines in all files, but we expect it to check them all. And it seems that there is no way to avoid this conflict rather than creating 2 different commands and putting {push_files} to the first and {all_files} to the second one. This leads to copy-pasting commands and thus is not convenient.

It looks like you have two cases:

You run the linter over the changed files in a pre-push hook. The hook is being executed implicitly on git push
You want to run the linter over all files by manually calling lefthook run pre-push --all-files

My vision is that your case is very special. Lefthook does the replacement of templates but can't pass something else to a command. Instead I'd suggest you to use a different local-only hook, like this:
lint-all:
  commands:
    run: yarn run lint --all-files

If you want to reduce duplication you could use YAML anchors:
pre-push:
  commands: &commands
    ...
    lint:
      run: yarn lint {staged_files}

lint-all:
  commands:
    <<: *commands
    lint:
      run: yarn lint --all-files

In this example you only overwrite the commands you want to run differently. And since you run the hook manually you don't have to stick with pre-push. You can name the hook whatever you want.
Does this look helpful?

I think this is what I need for my case. @mrexox, thanks for your help!


ARCHER2 fixes from MOSRS

This pull-request represents all changes on branches/dev/adrianhill/r8166_archer2_fix on MOSRS relative to our master branch

Closing this as I had fetched the wrong branch from MOSRS. The correct branch is in pull request https://github.com/Leeds-MONC/monc/pull/38


Ignore StyleSheets that are destructured

There was a StyleSheet that was immediately destructured, like so:
const {dimensions} = StyleSheet.create({
    dimensions: {
        height: ...,
        width: ....,
    },
});

This caused stylecleanup to crash as it has no valid binding for the file.
Test Plan:
I tested my change against a file that had this syntax in it and it didn't crash (it also didn't analyze the StyleSheet, but I think that's ok since this is a pretty non-traditional situation).

Awesome, this looks great for now. Thanks!


🐛 [Bug] Encountered bug when using Torch-TensorRT

Bug Description
It can't create a torch_tensorrt::ts::CompileSpec instance, where it throws this bug:
/usr/bin/ld: CMakeFiles/fuck_pytorch.dir/main.cpp.o: in function `main':
/workspace/fuck_pytorch/main.cpp:27: undefined reference to `torch_tensorrt::torchscript::CompileSpec::CompileSpec(std::vector<c10::ArrayRef<long>, std::allocator<c10::ArrayRef<long> > >)'
/usr/bin/ld: /workspace/fuck_pytorch/main.cpp:27: undefined reference to `torch_tensorrt::torchscript::compile(torch::jit::Module const&, torch_tensorrt::torchscript::CompileSpec)'

By the way, the documentation of Torch-tensorrt C++ getting started didn't update code since the Torch-TensorRT V1.0.0 release.
To Reproduce
Steps to reproduce the behavior:

CMake file:

find_package(PythonInterp REQUIRED)
cmake_minimum_required(VERSION 3.13)
project(fuck_pytorch)

set(CMAKE_CXX_STANDARD 14)
set(CMAKE_PREFIX_PATH /workspace/libtorch)
find_package(Torch REQUIRED)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TORCH_CXX_FLAGS} -D_GLIBCXX_USE_CXX11_ABI=0")

#include_directories(/workspace/torch_tensorrt/include /workspace/libtorch/include)
link_directories(/workspace/torch_tensorrt/lib)
add_executable(fuck_pytorch main.cpp)
target_link_libraries(fuck_pytorch "${TORCH_LIBRARIES}")
target_include_directories(fuck_pytorch PUBLIC /workspace/torch_tensorrt/include)
target_include_directories(fuck_pytorch PUBLIC /workspace/libtorch/include)
#target_link_directories(fuck_pytorch PUBLIC /workspace/torch_tensorrt/lib)
#set_property(TARGET fuck_pytorch PROPERTY CXX_STANDARD 11)

main.cpp

#include <torch/script.h> // One-stop header.
#include "torch_tensorrt/torch_tensorrt.h"

#include <iostream>
#include <memory>

using namespace std;

int main(int argc, const char* argv[]) {
  torch::jit::Module module;
  try {
    // Deserialize the ScriptModule from a file using torch::jit::load().
    module = torch::jit::load("/workspace/model/ssd_300_traced.jit.pt");
  }
  catch (const c10::Error &e) {
    std::cerr << "error loading the model\n";
    return -1;
  }

  std::cout << "ok\n";

  module.eval();
  module.to(at::kCUDA);
  auto in = torch::randn({1, 1, 32, 32}, {torch::kCUDA});
  std::cout << in.sizes();
  auto trt_mod = torch_tensorrt::ts::compile(module, torch_tensorrt::ts::CompileSpec(std::vector<c10::ArrayRef<int64_t>> {in.sizes()}));

//  auto out = trt_mod.forward({in});

}

Expected behavior
successfully run.
Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Pytorch docker: 21.06
Torch-TensorRT Version : libtorchtrt-v1.0.0-cudnn8.2-tensorrt8.0-cuda11.3-libtorch1.10.0.tar.gz
PyTorch Version: libtorch: libtorch-cxx11-abi-shared-with-deps-1.10.2+cu113.zip
CPU Architecture: amd64
OS (e.g., Linux): ubuntu 20.04
How you installed PyTorch (conda, pip, libtorch, source): libtorch
Build command you used (if compiling from source):
Are you using local sources or building from archives:
Python version: 3.8
CUDA version: 11.3.1
GPU models and configuration: 3090
Any other relevant information:

Additional context

I think I had a similar issue the other day, I guess that using the Pre-cxx11 ABI version of libtorch (that you can download here) may solve your problem.

Can you try following this https://nvidia.github.io/Torch-TensorRT/tutorials/getting_started_with_cpp_api.html#compiling-with-torch-tensorrt-in-c instead?
auto trt_mod = torch_tensorrt::CompileGraph(mod, std::vector<torch_tensorrt::CompileSpec::InputRange>{{in.sizes()}});

Can't find InputRange in Torch-TensorRT V1.0.0

Can't find InputRange in Torch-TensorRT V1.0.0

Can you try following this https://nvidia.github.io/Torch-TensorRT/tutorials/getting_started_with_cpp_api.html#compiling-with-torch-tensorrt-in-c instead?
auto trt_mod = torch_tensorrt::CompileGraph(mod, std::vector<torch_tensorrt::CompileSpec::InputRange>{{in.sizes()}});

Can't find InputRange in Torch-TensorRT V1.0.0

The API was renamed to Input in 0.4.0


Added clone mode for gitlab, use token mode as default

added clone_mode parameter for gitlab
added strategies to generate .netrc file

I have move hash method to separate package, because it used in gitlab package too

looks good


Fixes to operator CSV

Changes

Update ShipwrightBuild YAML example
Add OLM annotations for categories, description, repo, and support
Update README to fix incorrect YAML
Copy Usage section from README into the CSV description
Add links to documentation and Shipwright Builds

Makes progress on #21
/kind documentation
/kind cleanup
Submitter Checklist

[x] Includes tests if functionality changed/was added
[x] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Update operator CSV to include image, operatorhub.io category, improved example, and improved description.

Screen grab of how the CSV is used in OpenShift's OperatorHub. Similar formatting is used for operatorhub.io.

/lgtm


chore: release 1.2.0

:robot: I have created a release *beep* *boop*
1.2.0 (2019-06-06)
Features

add statistics about storedInfoType version (#301) (4482d02)
support apiEndpoint override in client constructor (#299) (663545c)

Release is at https://github.com/googleapis/nodejs-dlp/releases/tag/v1.2.0


Seems cannot locate the templates folder

Hi Kilerd,
I got an error like this when I was trying it on my Mac,
thread 'actix-rt:worker:0' panicked at 'called Result::unwrap() on an Err value: Error { kind: TemplateNotFound("homepage.html"), source: None }', src/libcore/result.rs:1188:5
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace.
thread 'actix-rt:worker:1' panicked at 'called Result::unwrap() on an Err value: Error { kind: TemplateNotFound("homepage.html"), source: None }', src/libcore/result.rs:1188:5
thread 'actix-rt:worker:2' panicked at 'called Result::unwrap() on an Err value: Error { kind: TemplateNotFound("homepage.html"), source: None }', src/libcore/result.rs:1188:5
thread 'actix-rt:worker:3' panicked at 'called Result::unwrap() on an Err value: Error { kind: TemplateNotFound("homepage.html"), source: None }', src/libcore/result.rs:1188:5
It seems it cannot find the templates folder. Do I need to config env file or something else?
Thank you.

Did you run it in Docker or just in your mac barely? it seems that the application cannot find template homepage.html. could you please check whether the template is included in your templates folder?

Yes, all the html files are there.
I didn't use Docker, just created a .env file for the DATABASE_URL and ROCKET_SECRET_KEY. Maybe because I didn't config the backend properly?

sorry, I can't reproduce this issue on my own mac.
could you please print your rust version using rustc -Vv and  rustup show, and project rubble folder's structure would be necessary using the command tree or some commands like that.
and please make sure you have the latest version of rubble and clean the cargo cache before running rubble.

I moved the Rubble folder out, from /Documents/GitHub/rubble to the users folder directly. Now it works.
But when I log in with admin/password, I get "{"message":"invalid jwt token"}". I've cleaned cookies, history, etc. Any idea?
Thank you.

for the api /admin/password, it is protected with JWT which can be provided by cookies or header.
if you are browsing the page in the browser, you must go to /admin for logging in which would detect your JWT  automatically.
or if you are using api, before changing the password of admin, you can get the JWT from the API  POST  /user/token
the JWT authentication logic is in here, you can pass the JWT token in two ways:

Header named Authorization  with value JWT YOUR_TOKEN_HERE
Cookie named Authorization  with value YOUR_TOKEN_HERE

and the API  POST /user/token would pass back the JWT in http reponse payload as JSON, login in /admin would store the JWT in Cookies.

Hi Kilerd, I'm trying to input the password in the browser on the admin/login page. The password seems correct. The cookie was created successfully and the browser was going to "admin/panel" page. but only showing a blank page with {"message":"invalid jwt token"}. I'm a little bit confused...

it seems that it fail to decode JWT token, you can set TOKEN_KEY to your .env file like that:
TOKEN_KEY=00000000000000000000000000000000

zero-token is very easy to reproduce issues.
if it occurs again, pls paste your JWT here, and I would try to reproduce it( PLEASE MAKE SURE YOU SET TOKEN TO ALL ZERO).

I've set TOKEN_KEY to all zero as you say, but It still didn't change. The JWT is
JWT eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpYXQiOjE1ODU4MTkwNzQsInN1YiI6IkxPR0lOX1RPS0VOIiwiZXhwIjoxNTg2NDIzODc0LCJpZCI6MSwidXNlcm5hbWUiOiJhZG1pbiJ9.SaAWMT3m4PtNe3mqMXw1r4xrLefw4ZL3RNoJnqkMQS4
Thank you.

with the same payload, the JWT token i sign is eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpYXQiOjE1ODU4MTkwNzQsInN1YiI6IkxPR0lOX1RPS0VOIiwiZXhwIjoxNTg2NDIzODc0LCJpZCI6MSwidXNlcm5hbWUiOiJhZG1pbiJ9.OOuCqTbqmcs9X9WOeIWYo8k05fEPfxQ1rCO_c0CAffc(link) (it seems that you are not using the all-zero-token to sign the JWT)
maybe you need to delete your cookies and try again? 😂

Yes, the token_key value was not passed through. It seems that it takes time to refresh values in .env.  I had tried a whole day on everything(change names, values, restart, etc). The DATABASE_URL works properly, but the std::env::var("TOKEN_KEY") just showed Err(NotPresent), which is very weird. Then suddenly it started working. I still have no idea why that happened. But anyway, I can keep going now.
Thank you very much!

seems that you've solved the problem, then I closed this issue.
and have fun with rubble.


Mock server doesn't respond with headers

Description
When running in mock server mode with an OpenAPI 3 API definition, response headers aren't returned.
Expected behaviour
Headers defined in responses section should be included in response.
Actual behaviour
Only a few standard headers like Content-Type and Content-Length are included.
Steps to reproduce

Add any header to an OpenAPI 3 response definition. Something like:

  /Endpoint:
    get:
      responses:
        '200':
          headers:
            cache-control:
              schema:
                type: string
                example: public
          content:
            application/json:
              ...

Start connexion with connexion run your_api.yaml --mock=all
Request the endpoint with an HTTP client, such as curl -v
Observe that the header is not included in the response.

Additional info:
Output of the commands:

python --version
Python 2.7.15rc1

pip show connexion | grep "^Version\:"
Version: 2.2.0

I see you added the enhancement tag to this issue. I'd be happy to look at putting together a pull request if you can point me in right direction. I haven't dug into this codebase before.

Hi @alangibson-philips ,
I'm happy to hear you would be willing to send a PR. What kind of direction are you looking for? How could I help you?


Format all files

Relates to #1610.
As it was shown in #1668, many files are not correctly formatted as per our current prettier default setup.
This makes it hard to contribute when you try to do everything right by running npm run format before committing.

We should probably add a precommit hook for this a la https://github.com/11ty/eleventy/blob/8f95fac1c4220d2b19dbc959861cd3d3e3650a21/package.json#L70-L74

Shipped!


[FLINK-26180] Update docs to introduce the compaction for FileSink.

What is the purpose of the change
This pull request update docs to introduce the compaction for FileSink.
Brief change log

docs/connectors/datastream/filesystem is updated with a section introducing the compaction for FileSink.

Thanks @pltbkd for the update! LGTM~ The failed test should be irrelevant~


Release v0.13.0

Introduce more specific exceptions, like NotFound, AlreadyExists, BadRequest, PermissionDenied, InternalError, and others (#376). This makes it easier to handle errors thrown by the Databricks API. Instead of catching DatabricksError and checking the error_code field, you can catch one of these subtypes of DatabricksError, which is more ergonomic and removes the need to rethrow exceptions that you don't want to catch. For example:

try:
  return (self._ws
    .permissions
    .get(object_type, object_id))
except DatabricksError as e:
  if e.error_code in [
    "RESOURCE_DOES_NOT_EXIST",
    "RESOURCE_NOT_FOUND",
    "PERMISSION_DENIED",
    "FEATURE_DISABLED",
    "BAD_REQUEST"]:
    logger.warning(...)
    return None
  raise RetryableError(...) from e

can be replaced with
try:
  return (self._ws
    .permissions
    .get(object_type, object_id))
except PermissionDenied, FeatureDisabled:
  logger.warning(...)
  return None
except NotFound:
  raise RetryableError(...)

Paginate all SCIM list requests in the SDK (#440). This change ensures that SCIM list() APIs use a default limit of 100 resources, leveraging SCIM's offset + limit pagination to batch requests to the Databricks API.
Added taskValues support in remoteDbUtils (#406).
Added more detailed error message on default credentials not found error (#419).
Request management token via Azure CLI only for Service Principals and not human users (#408).

API Changes:

Fixed create() method for w.functions workspace-level service and corresponding databricks.sdk.service.catalog.CreateFunction and databricks.sdk.service.catalog.FunctionInfo dataclasses.
Changed create() method for w.metastores workspace-level service with new required argument order.
Changed storage_root field for databricks.sdk.service.catalog.CreateMetastore to be optional.
Added skip_validation field for databricks.sdk.service.catalog.UpdateExternalLocation.
Added libraries field for databricks.sdk.service.compute.CreatePolicy, databricks.sdk.service.compute.EditPolicy and databricks.sdk.service.compute.Policy.
Added init_scripts field for databricks.sdk.service.compute.EventDetails.
Added file field for databricks.sdk.service.compute.InitScriptInfo.
Added zone_id field for databricks.sdk.service.compute.InstancePoolGcpAttributes.
Added several dataclasses related to init scripts.
Added databricks.sdk.service.compute.LocalFileInfo dataclass.
Replaced ui_state field with edit_mode for databricks.sdk.service.jobs.CreateJob and databricks.sdk.service.jobs.JobSettings.
Replaced databricks.sdk.service.jobs.CreateJobUiState dataclass with databricks.sdk.service.jobs.CreateJobEditMode.
Added include_resolved_values field for databricks.sdk.service.jobs.GetRunRequest.
Replaced databricks.sdk.service.jobs.JobSettingsUiState dataclass with databricks.sdk.service.jobs.JobSettingsEditMode.
Removed a.o_auth_enrollment account-level service. This was only used to aid in OAuth enablement during the public preview of OAuth. OAuth is now enabled for all AWS E2 accounts, so usage of this API is no longer needed.
Added network_connectivity_config_id field for databricks.sdk.service.provisioning.UpdateWorkspaceRequest.
Added a.network_connectivity account-level service.
Added string_shared_as field for databricks.sdk.service.sharing.SharedDataObject.

Internal changes:

Added regression question to issue template (#414).
Made test_auth no longer fail if you have a default profile setup (#426).

OpenAPI SHA: d136ad0541f036372601bad9a4382db06c3c912d, Date: 2023-11-14

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9ba48cc) 51.62% compared to head (9747f59) 51.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage   51.62%   51.62%
=======================================
  Files          38       38
  Lines       22266    22266
=======================================
  Hits        11495    11495
  Misses      10771    10771

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Integration tests have passed, so let's ship this.


Restore default excludes from the configuration cache

Ant's default excludes affect Gradle's up-to-date checking and file walking behaviour. They are currently used from org.apache.tools.ant.DirectoryScanner.getDefaultExcludes.
Our current suggestion is to change the default excludes very early in the build, so best in settings.gradle, if you want to have your build using them. Even that does not necessarily work well right now, see https://github.com/gradle/gradle/issues/2986.
Expected Behavior
When default excludes have been changed in settings.gradle, a new daemon which has a configuration cache hit should use the same default excludes.
Current Behavior
Configuration caching does not take default excludes into account.

This is still relevant.

Is there a known/recommended workaround for this? I've been working in the openapi-generator project that has many .gitignore files in their test resources directory. Following the current recommendation of adding DirectoryScanner.removeDefaultExclude("**/.gitignore") to settings.gradle.kts breaks the configuration cache on subsequent runs.


[BEAM-6113] Small changes to avoid user errors around beam.Init()

Making some small changes that will help prevent users from forgetting
or not knowing about calling beam.Init(). Making sure all examples
include a call to beam.Init(), and that the direct runner (which
currently runs if beam.Init() is not called) contains a warning about
it.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


Bugs found in LeftJoinProfTest in ontop-docker-tests

I am working on porting the new tests inLeftJoinProfTest done for H2 to the other DBs.
The new tests can be found in the branch https://github.com/martinkarbon/ontop/tree/feature/lj-prof-test-docker .
Here are some problems found:

[x] DESC is missing in ORDER BY for SQL Server
[ ] Minus tests return empty results for MySQL
[x] Boolean CASE expressions are not translated correctly for Oracle and SQL server (equalities to 0/1 are missing)
[x] SQL server and DB2 returns an integer for AVG() over integers
[x] Exception form testPreferences:
com.ibm.db2.jcc.am.SqlSyntaxErrorException: DB2 SQL Error: SQLCODE=-214, SQLSTATE=42822, SQLERRMC=V1...;ORDER BY;2, DRIVER=4.15.113

To run these tests, one needs to use the novel DB Docker images that are in the branch https://github.com/ontop/ontop-dockertests/tree/lj-prof

MySQL (5.7) seems to have semantics issues with the encoding of MINUS as a left-join (filter is-null combined with a left-join).


[Bug]: Different responses from two queries with identical evaluated value

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Here is my SQL query that is causing me trouble. It pulls items from an inventory Postgres database that match the MFGPartNumber and Condition Value.
SELECT *
FROM public."formatted_list"
WHERE "MFGPartNumber" ILIKE '{{searchBar.text}}'
AND "Condition" IN ({{conditionSelect.selectedOptionValue}})

Here is its evaluated value:
SELECT *
FROM public."formatted_list"
WHERE "MFGPartNumber" ILIKE '003-1436-001'
AND "Condition" IN ('R','N','Z')

When run, nothing is returned:

Yet, when I replace ({{conditionSelect.selectedOptionValue}}) with ('R','N','Z') I get a response with an accurate matching item:

Here is the query that gets a response (identical to the evaluated value of the first query shown):
SELECT *
FROM public."formatted_list"
WHERE "MFGPartNumber" ILIKE '003-1436-001'
AND "Condition" IN ('R','N','Z')

Here are the options in the conditionSelect widget:
[
{
    "label": "Any",
    "value": "'R','N','Z'"
  },
  {
    "label": "Refurbished",
    "value": "'R'"
  },
  {
    "label": "New",
    "value": "'N'"
  }
]

Is this a problem with assigning multiple strings within the value of the "Any" option? Or is there something more going on here?
I'd be happy to provide more context if required, I'm new to this bug report process so forgive me if this is lacking in detail.
Steps To Reproduce

Request table data from Postgres server connection
Integrate multi-option widget with a value of separated chars within one string ("'R','Z','N'" as per my config)
Create query that searches through Postgres table based on the values set in the multi-option widget.
Profit??

Environment
Production
Version
Cloud

I tried turning off Prepared Statements as I saw in https://github.com/appsmithorg/appsmith/issues/11259. Now the code runs, but I would still like to get this resolved.

@micahgrinnell agreed we should solve this. I'm closing this issue as this will be solved in #11259


Remove duplicates in a Linked List

Submission Title
Remove duplicates in a Linked List
Submission Type
Data Structure
Submission Description
The task is to remove all duplicate nodes from a linked list
Submission Directory
algo_ds_101/Data_Structures/Linked_List/Singly_Linked_List/
Contributors

[ ]  C++ -
[ ]  C -
[ ]  Python -
[ ] Java -
[ ] JavaScript -
[ ] TypeScript -
[ ] Golang -
[ ] Ruby -
[ ] php -
[ ] Swift -
[ ] C# -

I want to work on this issue in java😊

please assign this to me.. i will solve this using c++

Please assign this to me for Python

Can you assign this to me...I'll help in C++?

@nehalgupta8501 can I do it in java? An easy and quick way

Hi @ahampriyanshu please assign me for this issue in c language

please this to me in c language

thanks everyone :v:

hey this already contains contains C code. Should i develop a C++ code for this project

hey I have added c++ code for removing duplicates pls verify it asap