$redis->set fails, exits with no output or error

Good afternoon, I'm using Predis with composer as part of a Herbert structured Wordpress plugin. Predis says that it is correctly connected to the datastore but the set command exits without any information or error and when using the redis-cli no data is stored.

version of Predis: 1.1
version of Redis: 3.2.8
version of PHP: 5.6
name and version of the operating system: Ubuntu 14.04.2 LTS through Vagrant on Mac OS X El Capitan 10.11.6 host
when possible, a small snippet of code that reproduces the issue.:

<?php namespace RedisTestPlugin\Services;

use \WP_CLI;

class Redirect {

  public function testRedis() {

    var_dump('here');

    \Predis\Autoloader::register();

    // since we connect to default setting localhost
    // and 6379 port there is no need for extra
    // configuration. If not then you can specify the
    // scheme, host and port to connect as an array
    // to the constructor.
    try {
        $redis = new \Predis\Client(getenv('BFR_REDIS_CONNECTION_STRING'));

        echo "Successfully connected to Redis";
    }
    catch (Exception $e) {
        echo "Couldn't connected to Redis";
        echo $e->getMessage();
    }

    $redis = new \Predis\Client(getenv('BFR_REDIS_CONNECTION_STRING'));

    var_dump('here');

    $redis->set("hello_world", "Hi from php!");

    var_dump('$redis->set');

    $value = $redis->get("hello_world");
        var_dump('$redis->get');
    var_dump($value);

    echo ($redis->exists("Santa Claus")) ? "true" : "false";

    // Set then get the set key
    die(var_dump(self::$redis->set($from, $to)));
  }

}

new Redirect(); // Create class and connect to Redis

Output I get:
/vagrant/web/app/dev/redis-test-plugin/app/Services/Redirect.php:66:string 'here' (length=4)
Successfully connected to Redis
/vagrant/web/app/dev/redis-test-plugin/app/Services/Redirect.php:87:string 'here' (length=4)

Nothing else with all error reporting on.
If you need any more information let me know.

Not really sure what you are trying to attempt in that snippet but I removed the class wrapping and the last die() and it works as expected I'd say, no errors whatsoever. Try connecting to your Redis server using the redis-cli utility in the command line and issue a MONITOR command, then execute your scripts and you should see the exact commands sent to Redis by PHP.

It doesn't even hit Redis, it just dies without error or output. I'll investigate and let you know what I find.

It was an incorrect connection string I would have expected an error from the client or from a command but instead I got silence.

The connection to Redis is not established when doing new Predis\Client(); but when the first command is executed or when $client->connect() is invoked explicitly. That said, if the connection string is wrong and points to a wrong host/port pair then you should indeed see at least an exception if the connection fails when trying to execute the first command. If it's not the case the I guess there's something in your code that swallows exceptions.


[A11y bug] participant joined/left announcement

What

Introduces Narrator strings and the Announcer to the MediaGallery.
Why

Allows for Narrator users to know when participants have left and joined the call through announcements.

https://skype.visualstudio.com/SPOOL/_workitems/edit/3007443
How Tested

Validated on windows and android that the announcements happen at the correct time.

Is this ready for another round of reviews?

closing this PR, the work stream is being picked up in this one with some fancy tests: https://github.com/Azure/communication-ui-library/pull/2546


Getting postrender events before anything gets drawn

Hi,
I'm doing some integration of ol3 in the osgjs 3D scenegraph. It works quite well so far (http://webkeux.com/openlayers3). I just getting canvases in a postrender event and stick them to my 3D tiles. Controls: Mouse wheel to zoom, left button to rotate and right button to pan.
But I'm having an awkward issue:
In the initialization of the map I'm getting postrender events before the map is painted. I had to "hack" the code to check that the first pixel is not transparent, to continue requesting that tile image. This is not a very good solution because I probably need to paint transparent tiles too.
This is the URL without the check and some debug info painted in each tile(http://webkeux.com/openlayers3-error/). As you can see some tiles are drawn transparent because the postrender events fires before the map is painted.
Any idea of why I'm getting postrender events before the map gets painted?
Relevant code I used:
var postRender = function ( event ) {
                var viewport = that.map.getViewport();
                var canvas = viewport.getElementsByTagName( "canvas" )[ 0 ];
                that.map.unByKey( key );
                var canvasCopy = cloneCanvas( canvas );
                defer.resolve( canvasCopy );
            };

var key = this.map.once( 'postrender', postRender );
view.fit( extent, [ 128, 128 ], { constrainResolution: false } );

The postrender event is emitted at the end of each render/animation frame (executed in a requestAnimationFrame callback). When postrender is emitted there may be tiles that are still being loaded for a layer. Not fully sure this answers your question.

@elemoine thanks for your answer. So is there a method to know when the map is totally rendered? I tried also with moveend event.

There are no map-level events at the moment. There are layer-level events though. See http://openlayers.org/en/master/examples/tile-load-events.html and http://openlayers.org/en/master/examples/image-load-events.html for examples.

@elemoine It seems tileloadend also arribes before it should. http://webkeux.com/openlayers3-error/  Maybe I'm doing somehting wrong...

Umm ok I was not doing it right, I need to check that every tile inside the map has ended.

Anyway it would be very nice to have an event when the map has completed the render.

@jtorresfabra Did you find any solution to this?


Add captureMethod to createPaymentIntent on iOS

Summary
We can now call createPaymentIntent({ captureMethod: 'automatic', ... }) from RN
Motivation
Related to the discussion here https://github.com/stripe/stripe-terminal-react-native/issues/439#issuecomment-1461871447
Testing

[x] I tested this manually
[ ] I added automated tests

I called createPaymentIntent({ captureMethod: 'automatic', ... }) in RN and saw the API request being made in stripe dashboard with capture_method set to automatic
Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[ ] This PR does not result in any developer-facing changes.

This is great, thanks. If you're feeling ambitious, we'd appreciate support for adding an automatic/manual picker to our example and dev apps.

I added for dev-app here https://github.com/stripe/stripe-terminal-react-native/commit/d760bf123376b5a31058b8dcd092227c087fd2f5, for example-app you need to publish a new package version. I didn't get a chance to test yet, so if you can that would be great!

@mihaildu -- this is great, thanks again. I appended a few more commits to add Android support and opened a new PR https://github.com/stripe/stripe-terminal-react-native/pull/447 (because I don't think I can ~easily push commits to this branch/PR).

Closing this PR, now that #447 has landed.


My 4th PR

Description
Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

Screenshot

👍

PR looks fine!
@shekhar10feb
* You can add description and screenshots in the description area point_down
  ![image](https://user-images.githubusercontent.com/72256599/97321402-d6a07b00-1894-11eb-97dc-b14dc901a0b0.png)

PR looks fine!
@shekhar10feb
* You can add description and screenshots in the description area point_down
  ![image](https://user-images.githubusercontent.com/72256599/97321402-d6a07b00-1894-11eb-97dc-b14dc901a0b0.png)

I will do it....thank you


Update kubernetes version to 1.7 or newer.

All of the 1.7 kubernetes can works well with istio CRD resources,
we should update it to avoid confuse.
/cc @linsun

Jenkins job istio.github.io/presubmit passed

@ldemailly what is the reason of 1.7.2 does not work, at least it works for 1.7.3 in my env.

I forget but there was an issue - going to close this for now

@ldemailly I think that we need to update kubectl version to 1.7.3 as 1.7.3 also works, I got some question from customers about the version who is using 1.7.3, so better update to 1.7.3

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Updating to 1.7.3 is fine with me given Guang has tested it and we didn't recall any issue but we picked 1.7.4 given it was the latest.

I am pretty sure there is a bug with older than 1.7.4 but maybe it was only initializer related ? or was it about validation hooks ? @andraxylia do you remember?

@ldemailly We have a wechat group for istio in China and I got some questions for the kubernetes version for istio, and some people are using 1.7.3 and they also did some test and found istio works well. I think that we should update the document so as not bring confuse, comments?

sorry to keep repeating the same thing but I'm sure there was a reason (it's not that we picked the latest at the time) - maybe if you go over the release notes it may show up but I hope @andraxylia or @ayj or someone remembers

I don't recall the reason. Maybe a GKE specific requirement since they bump up the latest minor version frequently and make previous minor versions unavailable for new clusters?

I searched a bit and didn't find except that we put 1.7.4 for the first time in 0.2.2
https://github.com/istio/istio/wiki/v0.2.2
I guess go ahead and merge and we'll see if we get reports/errors

Jenkins job istio.github.io/presubmit passed

Thanks for digging around, I'll merge it.


no-op: add GOEXPERIMENT var

Pull Request Motivation
This will enable easy testing of different GOEXPERIMENT variables, such as loopvar to test the upcoming changes there.
Note that I've confirmed that this change is a no-op. The binaries we build are identical after this change.
I used the following patch to allow me to hardcode versions:
diff --git a/make/git.mk b/make/git.mk
index 27a523880..18a266b78 100644
--- a/make/git.mk
+++ b/make/git.mk
@@ -12,9 +12,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

-RELEASE_VERSION := $(shell git describe --tags --match='v*' --abbrev=14)
+RELEASE_VERSION ?= $(shell git describe --tags --match='v*' --abbrev=14)

-GITCOMMIT := $(shell git rev-parse HEAD)
+GITCOMMIT ?= $(shell git rev-parse HEAD)

 IS_TAGGED_RELEASE := $(shell git describe --exact-match HEAD >/dev/null 2>&1 && echo "true" || echo "false")

Then I ran the following on master:
$ make RELEASE_VERSION=v1 GITCOMMIT=abc123 controller
...
$ sha256sum _bin/server/*
74b620ceffc2c526cf0753a8e4318533dab98fee23cb29606c85b578fee31043  _bin/server/controller-linux-amd64
92ad4121028e1740cbe8d1fe7b41effad7ad46e4fcc4c2135859b44dc65d7dd3  _bin/server/controller-linux-arm
6cab4bfb22e58e9ac29fe2f69a450eb2a11a5382c11c9beb6d9c479063bbacec  _bin/server/controller-linux-arm64
9641ffc1af4dcc4ce857c8c734310f2b01b9927953b66fba928657659bd140ac  _bin/server/controller-linux-ppc64le
57ffa3c16046e44cf220663d3d3ee38b7bba4eaa828bbfcd1d8fa4b471a4292e  _bin/server/controller-linux-s390x

I then wrote this PR, ran rm _bin/server/* and then ran the same build and sha256sum again and got the same output.
I tested this so we could be confident that backporting this change to currently supported versions will have literally no effect if GOEXPERIMENT is not set.
Kind
/kind feature
Release Note
NONE

/cherry-pick release-1.12


MSSQL addColumns weird behaviour

I'm attempting to reverse generate the schema of a MSSQL database. For this purpose I'm using the following yaml file:
dbname:
    adapter: mssql
    classname: Propel\Runtime\Connection\ConnectionWrapper
    dsn: "dblib:host=123.456.789.012;dbname=dbname"
    user: username
    password: password
    attributes:

However, when I run it, it throws the following error:
[Propel\Generator\Exception\EngineException]
Column "" declared twice in table "Status"

This error is thrown here:
https://github.com/propelorm/Propel2/blob/master/src/Propel/Generator/Model/Table.php#L499
The table obviously does not contain any real columns without a name ( :-) ). Whenever I delete this table, it simply returns the same error for the next table. The table Status simply is the first on the list it loops through to add columns for.
So I went digging and found that it goes wrong here:
https://github.com/propelorm/Propel2/blob/62859fd0ed3520b7d7afbbdeac113edaf160982b/src/Propel/Generator/Reverse/MssqlSchemaParser.php#L124
protected function addColumns(Table $table)
    {
        $dataFetcher = $this->dbh->query("sp_columns '" . $table->getName() . "'");
        foreach ($dataFetcher as $row) {
            $name = $this->cleanDelimitedIdentifiers($row['COLUMN_NAME']);

$table->getName() correctly returns the right table name, however when I print $row it contains the following array:
Array(
    [0] => My DBname
    [1] => My DBprefix
    [2] => Status
    [3] => uid
    [4] => 4
    [5] => int identity
    etc.

The array contains no string indices, hence $row['COLUMN_NAME'] and others will be empty. Why is this?

Well dataFetcher uses per default PDO::FETCH_NUM. We should extend DataFetcher class to be able to set a different fetch type.

Doesn't that imply that it always fails in the MSSQL schema parser as it always returns numeric indices..?

Yes, that implies that MSSQL is at the moment obviously completely broken.

Hi all, I wanted to try out the reverse engineering capabilities for a project using SQL server but noticed the missing support in propel2. My pull request is the initial step to (re-)enable reverse-engineering, diff-ing and building sql scripts.

PR seems merged


Fixed the segfault which can happen after address.option("connectionOrder") return nullptr

Added check if the connectionOrder receives nullptr and not a valid string. This can be a case if address.option("connectionOrder") returns nullptr.

https://github.com/CopernicaMarketingSoftware/AMQP-CPP/commit/21a431d8a83c824e3f37dd5c0cd0c5d5b2aca4df#commitcomment-44233922

Great, thanks


HADOOP-15999. S3Guard: Better support for out-of-band operations

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
983
trunk passed

+1
compile
34
trunk passed

+1
checkstyle
24
trunk passed

+1
mvnsite
34
trunk passed

+1
shadedclient
711
branch has no errors when building and testing our client artifacts.

+1
findbugs
45
trunk passed

+1
javadoc
25
trunk passed

_ Patch Compile Tests _

+1
mvninstall
30
the patch passed

+1
compile
29
the patch passed

+1
javac
29
the patch passed

+1
checkstyle
19
the patch passed

+1
mvnsite
33
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
741
patch has no errors when building and testing our client artifacts.

+1
findbugs
47
the patch passed

+1
javadoc
17
the patch passed

_ Other Tests _

+1
unit
279
hadoop-aws in the patch passed.

+1
asflicense
23
The patch does not generate ASF License warnings.

3162

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-624/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/624

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux f4304e1c482e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c9e50c4

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-624/1/testReport/

Max. process+thread count
445 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-624/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

This test is working for me standalone, but when run in a parallel set, its failing
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.121 s - in org.apache.hadoop.fs.s3a.ITestS3AMiscOperations
[INFO] Running org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardToolLocal
[ERROR] Tests run: 12, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 54.988 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations
[ERROR] testListingSameLengthOverwrite[0](org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations)  Time elapsed: 2.906 s  <<< FAILURE!
java.lang.AssertionError: Authoritative is enabled, so metadata is not updated in ms, so mod_time won't match. Expecting different values for raw and guarded filestatus. Raw: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-5dc16452-d51a-4a34-8250-54e140797390/file-1-5dc16452-d51a-4a34-8250-54e140797390; isDirectory=false; length=8; replication=1; blocksize=33554432; modification_time=1553098862000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE Guarded: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-5dc16452-d51a-4a34-8250-54e140797390/file-1-5dc16452-d51a-4a34-8250-54e140797390; isDirectory=false; length=8; replication=1; blocksize=33554432; modification_time=1553098862000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE. Actual:<PHONE_NUMBER>000
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failEquals(Assert.java:185)
	at org.junit.Assert.assertNotEquals(Assert.java:199)
	at org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations.overwriteFileInListing(ITestS3GuardOutOfBandOperations.java:349)
	at org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations.testListingSameLengthOverwrite(ITestS3GuardOutOfBandOperations.java:214)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:745)

[ERROR] testListingLongerLengthOverwrite[0](org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations)  Time elapsed: 2.897 s  <<< FAILURE!
java.lang.AssertionError: Authoritative is enabled, so metadata is not updated in ms, so mod_time won't match. Expecting different values for raw and guarded filestatus. Raw: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-d2e314e4-c20c-4228-9e4f-07f7f8a2a44b/file-1-d2e314e4-c20c-4228-9e4f-07f7f8a2a44b; isDirectory=false; length=15; replication=1; blocksize=33554432; modification_time=1553098875000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE Guarded: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-d2e314e4-c20c-4228-9e4f-07f7f8a2a44b/file-1-d2e314e4-c20c-4228-9e4f-07f7f8a2a44b; isDirectory=false; length=8; replication=1; blocksize=33554432; modification_time=1553098875000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE. Actual:<PHONE_NUMBER>000
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failEquals(Assert.java:185)
	at org.junit.Assert.assertNotEquals(Assert.java:199)
	at org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations.overwriteFileInListing(ITestS3GuardOutOfBandOperations.java:349)
	at org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations.testListingLongerLengthOverwrite(ITestS3GuardOutOfBandOperations.java:219)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:745)

Assumption: some FS sharing/caching is still going on

and I've managed to do it in a single test run. There's some intermittent issue going on here. It could just be timestamp race conditions.
[INFO]
[ERROR] Failures:
[ERROR]   ITestS3GuardOutOfBandOperations.testListingLongerLengthOverwrite:236->overwriteFileInListing:366->Assert.assertNotEquals:199->Assert.failEquals:185->Assert.fail:88 Authoritative is enabled, so metadata is not updated in ms, so mod_time won't match. Expecting different values for raw and guarded filestatus. Raw: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-27967cf9-e744-4732-9d3a-3ae754684ae2/file-1-27967cf9-e744-4732-9d3a-3ae754684ae2; isDirectory=false; length=15; replication=1; blocksize=33554432; modification_time=1553108035000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE Guarded: S3AFileStatus{path=s3a://hwdev-steve-ireland-new/dir-27967cf9-e744-4732-9d3a-3ae754684ae2/file-1-27967cf9-e744-4732-9d3a-3ae754684ae2; isDirectory=false; length=8; replication=1; blocksize=33554432; modification_time=1553108035000; access_time=0; owner=stevel; group=stevel; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE. Actual:<PHONE_NUMBER>000

Given I've seen the failure in a standalone run, it's not FS caching somehow meaning raw has picked up a DDB table. Though I've added a way to query S3A FS instance for its auth status to make sure we know what's going on in inside
Possible causes then

writes are so close together they share the same timestamp
the rawFS.getFileStatus() call after a read is picking up the out of date value
the check for modtime is a bit brittle, especially given for all writes using different length files, we can just check the file length.

See PR #630 for the patch addressing these issues
@bgaborg to get the changes I've done, look at the "command line instructions" at the bottom of the list, add my repo, do a git fetch and then cherry pick the commit 5aba1e4738b050fde1b2c45c21ed59320869be53 into this PR

I'll do another check on your modifications, run some test with local and ddb, and get back with the results.

I never got any issues with running ITestS3GuardOutOfBandOperations (just with local and because of the reference on the cache), but running it with your commit gave me the following error:

[ERROR]   ITestS3GuardOutOfBandOperations.testListingLongerLengthOverwrite:251->overwriteFileInListing:399->verifyFileStatusAsExpected:439->Assert.assertNotEquals:199->Assert.failEquals:185->Assert.fail:88 File length in authoritative table with
Raw: S3AFileStatus{path=s3a://cloudera-dev-gabor-ireland/dir-fcd509ca-0db4-426a-9c4f-b972a4949a5d/file-1-fcd509ca-0db4-426a-9c4f-b972a4949a5d; isDirectory=false; length=15; replication=1; blocksize=33554432; modification_time=1553182592000; access_time=0; owner=gaborbota; group=gaborbota; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE
Guarded: S3AFileStatus{path=s3a://cloudera-dev-gabor-ireland/dir-fcd509ca-0db4-426a-9c4f-b972a4949a5d/file-1-fcd509ca-0db4-426a-9c4f-b972a4949a5d; isDirectory=false; length=15; replication=1; blocksize=33554432; modification_time=1553182592000; access_time=0; owner=gaborbota; group=gaborbota; permission=rw-rw-rw-; isSymlink=false; hasAcl=false; isEncrypted=false; isErasureCoded=false} isEmptyDirectory=FALSE. Actual: 15

The second run succeeded, no errors.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
28
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

0
mvndep
58
Maven dependency ordering for branch

+1
mvninstall
1063
trunk passed

+1
compile
1074
trunk passed

+1
checkstyle
213
trunk passed

+1
mvnsite
142
trunk passed

+1
shadedclient
1064
branch has no errors when building and testing our client artifacts.

+1
findbugs
148
trunk passed

+1
javadoc
87
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
72
the patch passed

+1
compile
928
the patch passed

+1
javac
928
the patch passed

-0
checkstyle
188
root: The patch generated 3 new + 6 unchanged - 0 fixed = 9 total (was 6)

+1
mvnsite
115
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
643
patch has no errors when building and testing our client artifacts.

+1
findbugs
169
the patch passed

+1
javadoc
86
the patch passed

_ Other Tests _

+1
unit
555
hadoop-common in the patch passed.

+1
unit
273
hadoop-aws in the patch passed.

+1
asflicense
39
The patch does not generate ASF License warnings.

6837

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-624/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/624

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux cca3c80700fe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 9f1c017

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-624/2/artifact/out/diff-checkstyle-root.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-624/2/testReport/

Max. process+thread count
1358 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-624/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

I think there's still a race condition.
Can you use LambdaTestUtils.eventually() to give a longer interval for things to stabilise?
eventually(20_000,
  () -> assert(...)),
  new LambdaTestUtils.ProportionalRetryInterval(50, 1000));

that will exit fast on success, but retry until there's stability

OK, updated the test to use eventually(); please check my branch for that patch.
If you can run it and the tests work, all is well. If they fail, then we may have more insight as to what is wrong

Looks like this should be closed since #630 was merged?

It's already committed so closing this.


maintain/disabled should handle aria-disabled on ancestry-siblings

It does not make sense to disable the interactive components of a sub-tree without also marking the entire sub-tree as disabled. Therefore the module maintain/disabled (formerly focus/disable) should also engage and disengage aria-disabled. A refactoring of get/ancestry-siblings may be necessary to allow multiple context and filters.
var ancestrySiblings = getAncestrySiblings({
  context: dialog,
});
ancestrySiblings.forEach(function(element) {
  element.setAttribute('aria-disabled', 'true');
});

You may want to disable elements without hiding them and vice versa. as such, the functionality may not be merged, but must be made available separately.


"project": missing name for module "index" for jfrog/project provider

Looks like some variation of failure to infer the right prefix?
❯ pulumi package add terraform-provider registry.terraform.io/jfrog/project
error: failed to get schema: parameterize: rpc error: code = Unknown desc = 1 error occurred:
	* resources:
1 error occurred:
	* "project": missing name for module "index"

Not quite. The provider has a resource called project. The mapper assumes that each TF resource token is of the form <prefix>_<module? + name>. It doesn't handle <prefix> correctly.


Syntax section is not addressing the right data type

Syntax section is not addressing the right data type as it is talking about Date and Time format, but not DateTime. Please correct this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5b8b5aed-979e-b1fe-845f-06008cff98e0
Version Independent ID: 12bd4c37-f88b-3429-dd9b-d7a2d8fa4002
Content: DateTime Data Type - Business Central
Content Source: dev-itpro/developer/methods-auto/datetime/datetime-data-type.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for catching this. Will be fixed with the next doc refresh.


Reduce size of libCaffe2.a

Hi,
I wonder if there is any way to reduce the size of package libCaffe2.a. Does Caffe2 offer any method, like a customizing compilation, to select what you need in addition to the basic components?
Any suggestion will be appreciated.
Best Regards.

you can use the white.list to include the files you want to build in CMakeLists.txt

@lzx1413
Thanks for your help!
I found that almost the unnecessary modules needed by the android package are switched off in the caffe2/scripts/build_android.sh. Does this script work for the whitelist? If so, is there any way more to reduce the package size for Android platform?
Thanks again!

I am trying to deploy CNN model, like MobileNets, on Caffe2. And I removed the following components for the cmake system to reduce the size of libCaffe2.a.


Bump version to 1.2.0

I can't see version 1.2.0 on pub.dev. Maybe you forgot publishing it?

Ah, just saw it was retracted.


CCE-544: All starter pages now with the toolbar without margins

I added some spacing below the toolbar as it looked pretty tight after going full width with the toolbar. looks good.


Scroll dev 0714

TODO:

evm can process empty circuit (mock prove fails, real prove works now)
rlc commitment of state circuit

Moved to 0801


dev: use range operator in for loop

https://github.com/kkrt-labs/kakarot-ssj/blob/5352614daf538136ec421ef71a9ae95e64983d29/crates/evm/src/precompiles.cairo#L37-L47
In this function, we use a while loop with a manual increment of the counter i.
A more idiomatic approach would be to simply use the range operator documented in the Cairo Book

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
hi

I am applying to this issue via OnlyDust platform.
My background and how it can be leveraged
My name is Fabricio Robles, I work as a full stack dev since 3 years ago. Also I have been involved in web3 where I have contributed successfully to projects like dojo engine, Concrete and this great project creating some testings. I have experience working with Rust, Cairo, Go, Python and Javascript, I am sure that experience would help me delivering a quality solution for this project
How I plan on tackling this issue

I would do a control + find in cairo files searching for while loops
Understand the context of those loops and analyze if they can be refactored with new loop syntax using ranges (for i in 0..N)
Apply the refactor
Run test suite to make sure everything is working.
PR

superceded by https://github.com/kkrt-labs/kakarot-ssj/issues/978


Bar disappears in a couple seconds and doesn't always appear

I'm running Spigot 1.8.4 and can't seem to get the bar to display for very long or consistently.

According to the barAPI comments, the boss bar (in 1.8 or above) only shows up if the player sees the dragon. It's difficult to place the dragon somewhere the player actually sees it directly. (Related to https://github.com/confuser/BarAPI/issues/48)
The orginal author implemented the feature that the bar will disappear after specifc time, but I could change it that the dragon follows the movements of the player and so stay shown.

Would this create potential lag due to the use of the hidden Dragon?

Dragons cannot be hidden in 1.8, but yes it would take some performance effects if the dragon has to follow the player in order to keep the boss bar show up.
As far as I know this behaviour isn't intended and will be fixed in 1.9

Ok thanks for the info.. I like the idea of using the bar for mcMMO skills but sounds like it's better to wait until 1.9

Alright, then I close this.


Whereabouts of project Starlane empire (was on gna.org)?

It was at https://gna.org/projects/starlane/
Does anyone has a copy of the source (and binary)?
https://web.archive.org/web/20170206060318/https://gna.org/projects/starlane/

Would have to checkout https://archive.org/details/Gna_code_hosting

Somewhere inside https://archive.org/download/Gna_code_hosting/gna__rem___synscopev.tar

There is definitely CVS and SVN data included. Need to access it further.

Converted CVS and SVN to Git. SVN contained only the website and CVS code. Will combine both, upload to Gitlab and create entry for it.


Title

Collecting and rendering titles to Pretext

Closing for now. We'll pick this up another time.


IndexError on cloud_sync()

Encountered this failure on node2:
uploading a candidate: "8513bec_5._Gold.flac"
Traceback (most recent call last):
  File "./cloudsync.py", line 70, in <module>
    cloud.cloud_sync()
  File "/root/pyenv/local/lib/python2.7/site-packages/cloudmanager/cloudmanager.py", line 91, in cloud_sync
    self.RedundancyLevel)
  File "/root/pyenv/local/lib/python2.7/site-packages/plowshare/plowshare.py", line 59, in upload
    return self.multiupload(filename, self.random_hosts(number_of_hosts))
  File "/root/pyenv/local/lib/python2.7/site-packages/plowshare/plowshare.py", line 151, in multiupload
    multiprocessing.dummy.Pool(len(hosts)).map(f, self._hosts_by_success(hosts))
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 251, in map
    return self.map_async(func, iterable, chunksize).get()
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
    raise self._value
IndexError: list index out of range

Either it's just a problem of the local settings on that node or a real bug.

Could be a parallelization issue too. Maybe one thread/process was trying to access an item in an array that another process had removed?


feat: Replace framework-info with build-info

🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes https://github.com/netlify/pod-dev-foundations/issues/540

For us to review and ship your PR efficiently, please perform the following steps:

[ ] Open a bug/issue before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved.
[ ] Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
[ ] Update or add tests (if any source code was changed or added) 🧪
[ ] Update or add documentation (if features were changed or added) 📝
[ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

While pairing with @lukasholzer on this, we identified a bug where build-info emits the wrong commands when running detection from packages/nextjs in https://github.com/lukasholzer/aaa.

The new release candidate can be tested with: npx<EMAIL_ADDRESS>

@codebyuma maybe you can take a look at the added flags and review the description for them.

I'm going to skip the failing tests on the CI as the functionality is working and the tests are passing locally will investigate in a follow up:


RFC: specify redirections with JS object parameters

I proposed this idea a while ago, but I can't remember where. I'm looking for comments/feedback.
The basic idea is to replace this:
shell.grep('foo', 'file.txt').to('other.txt');

with
shell.grep('foo', 'file.txt', { '>': 'other.txt' });

What does this fix?
It's currently not possible to mute echo() with redirection, which is kind of awkward. With this syntax, we can add support in src/common.js to temporarily add shell.config.silent = true. Then we just need to write echo() to respect that value. Voila.
New features?
This opens the door to some cool new features. Some ideas:
shell.rm('missing-file.txt', { '2>': 'error.log' }); // redirect stderr
shell.cat('first.txt', { '>>': 'second.txt' });
shell.cp('-r', 'src', 'out', { '2>&1': /* not sure what should go here :( */ });
shell.tail('file.txt', { '>': 'stdout.txt', '2>': 'stderr.txt' });

A downside to this design is that we cannot support multiple redirects (e.g. echo foo > file1.txt > file2.txt).
Alternate ideas for syntax
shell.rm('missing-file.txt', { 2: 'error.log' }); // '2' instead of '2>'

Idea: use an array instead of an object:
shell.grep('foo', 'file.txt', ['>', 'other.txt']); // redirect to other.txt
shell.rm('missing-file.txt', ['2>', 'error.log']); // redirect stderr
shell.cat('first.txt', ['>>', 'second.txt']);
shell.cp('-r', 'src', 'out', ['2>&1']); // here, we don't need a second value
shell.tail('file.txt', ['>', 'stdout.txt', '2>', 'stderr.txt']); // this still makes sense, since two values would be pulled at once
shell.echo('foo', ['>', 'file1.txt', '>', 'file2.txt']); // multiple redirects also works

Another alternative is to use the same method that the Map constructor uses, nested arrays:
shell.grep('foo', 'file.txt', [['>', 'other.txt']]); // redirect to other.txt
shell.rm('missing-file.txt', [['2>', 'error.log']]); // redirect stderr
shell.cat('first.txt', [['>>', 'second.txt']]);
shell.cp('-r', 'src', 'out', [['2>&1']]); // here, the redirect doesn't need a second value
shell.tail('file.txt', [['>', 'stdout.txt'], ['2>', 'stderr.txt']]); // each redirect is enclosed in its own array
shell.echo('foo', [['>', 'file1.txt'], ['>', 'file2.txt']]); // same here, multiple redirects still works

In fact, arrays make sense here for another reason: redirects are ordered:
$ echo foo 2>&1 1>foo.txt

has a different meaning than
$ echo foo 1>foo.txt 2>&1

Arrays are ordered, where objects are not.

For redirects, at least, bash will only treat the destination as a file descriptor address if there are no spaces in the redirect:
$ echo foo 1>2& # redirects stdout to stderr
$ echo foo 1> 2\& # redirects to file with name "2&"

In our case, this is could be solved by separating the elements in the array:
shell.echo('foo', [['1>2&']]); // redirects stdout to stderr
shell.echo('foo', [['1>', '2&']]); // redirects to file with name "2&"

Passing this off to @freitagbr to finalize the design.

Are we making progress with this?
If the primary use is shell.echo(), couldn't we add an option like -s for silent?

I have a simple work-around for my limited use:
const samplesFile = 'tests/samples'
const to = str => new shell.ShellString(str + '\n').to(samplesFile)
const toEnd = str => new shell.ShellString(str + '\n').toEnd(samplesFile)

So possibly this is not as big a deal as I thought. But I'd prefer a "silent" option.

Progress is stalled. Using new ShellString() is the recommended workaround at the moment.

Progress is stalled

Which means this issue is available. If folks are interested in working on this, I'll invest some time to scope out the project and guide on how we can break this work into small, manageable chunks.

Just as a preference, I'd avoid the exotic redirect syntax. ShellJS is wonderfully simple and clean.
If echo is the 90% use, a simple -s or similar would be fine. Or possibly a new "utility" function like the ShellString stunt. Or if the stunt is not documented, just do that.


Immediately detach from devices with claimed but broken IPP over USB support

Some printers announce presence of the 7/1/4 interfaces, but IPP over USB doesn't work due to their firmware errors. At least two of such devices already known:
HP Inc. HP Laser MFP 135a
HP Inc. HP Laser 107a

The proposed solution from here:
https://bugs.launchpad.net/ubuntu/+source/ipp-usb/+bug/1970055
@tillkamppeter

Alexander, as ipp-usb starts to communicate with the printer as soon as it attaches to it, you could perhaps add a mechanism that somehow finds out whether the printer is actually driverless or not, and if not, unattach ipp-usb immediately to give way for classic access (CUPS backend or Printer Application).

Basically, I agree with the following comments:

There will be possible race condition between failed attempt of the ipp-usb to initialize the device and CUPS attempt to claim the device. If device looks like taken by the ipp-usb, CUPS should retry within a some reasonable time
Some visibility is required that ipp-usb has rejected the device due to initialization error, to simplify processing of users' bug reports. Should such a device still be advertised on Avahi on some special manner, so CUPS/sane-airscan will ignore it, but it still can be listed with avahi-browse?

Some visibility is required that ipp-usb has rejected the device due to initialization error, to simplify processing of users' bug reports. Should such a device still be advertised on Avahi on some special manner, so CUPS/sane-airscan will ignore it, but it still can be listed with avahi-browse?

My answer to myself here is the newly added ipp-usb status command, which prints actual status of all attached/recognized 7/1/4 devices, including those of them which are ignored by the ipp-usb either due to the explicit blacklisting, or because device initialization failed.

Done in 0.9.22


Bounds clamping on zoom and pan

This PR adds proper bounds clamping to the map navigation.  The clamping is enforced on pan, zoom, and resize.  This behavior can be disabled by setting the map option clampBounds to false.
Depends on #285.  See here for changes added by this PR.

Do you have a live link for (lazy) me to try out this change?

http://<IP_ADDRESS>:8083/examples/osm/

Rebased on master.

Nearly works. The edge case I'm seeing is that the initial load (on a large screen) seems to allow the map to be out of bounds, which gets fixed after the first interaction. This may be a bit tricky to solve, since you will need to resolve this by finding the nearest "good" view based on the user's initial request, which may involve a pan and possibly a zoom if the zoom level requested is too zoomed-out to fill the viewport.

I tried to handle that... I'll take another look at it.  :weary:

@jeffbaumes Try it again.  I think I got it this time. :pray:

Huzzah! Seems to be working for me. Can't really speak to implementation details but the result LGTM.

Great!  Thanks for the QA.

LGTM :+1:


Refactor get_typing_notification_recipients() (in lib/actions.py) so that do_send_messages() can use it

The idea is that since get_typing_notification_recipients() is based on code from do_send_messages(), it's possible to have just one method that is used by both do_send_messages() and do_send_typing_notification().
Hopefully these links work :)
get_typing_notification_recipients()
https://github.com/zulip/zulip/blob/6e1674aca5a9e9427d410b25db8e18bf711c2302/zerver/lib/actions.py#L821
do_send_messages()
https://github.com/zulip/zulip/blob/6e1674aca5a9e9427d410b25db8e18bf711c2302/zerver/lib/actions.py#L657
do_send_typing_notification()
https://github.com/zulip/zulip/blob/6e1674aca5a9e9427d410b25db8e18bf711c2302/zerver/lib/actions.py#L849

Cool, thanks for opening an issue; I've labeled it.

Working on this on https://github.com/zulip/zulip/pull/2109

Fixed via #2109.  @arpith FYI, if you put Fixes #2095. in the commit message, GitHub will auto-close the issue when the commit is merged.


cmd+click to go to definition doesn't work on mac anymore

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.81.0-insider (Universal), Commit: f8782370c90ec98467dc3590bcfa2eeb1f218107
OS Version: 13.4.1 (22F82)

Steps to Reproduce:

Open any JS project with a couple of files that import each other like https://github.com/preactjs/preact
cmd+click on a function callsite to jump to its definition -> nothing happens

This only occurs in the insiders build and not in the stable release line. Disabling all extensions doesn't help either.

Please share a specific code location that demonstrates the issue

@mjbvz Click on any function call or any variable usage in the project. I can reproduce it with all of them.

https://github.com/microsoft/vscode/assets/12821956/db7469fd-cb95-4442-ad5a-dd9c1349f568
What if you run go to definition from the command palette? Did you perhaps disable the built-in TypeScript / JavaScript extension?

Found the culprit. For some reason "editor.multiCursorModifier": "ctrlCmd", was set. Changing that back to the default resolved it for me. 🙈


Hello

Hello,
Do you have any contact info? just want to ask you some questions, if that's possible.
Thanks

Hi Alex
<EMAIL_ADDRESS>
From: Alexh100 @.>
Sent: Saturday, April 17, 2021 11:23:32 PM
To: rnwood/smtpserver @.>
Cc: Subscribed @.***>
Subject: [rnwood/smtpserver] Hello (#138)
Hello,
Do you have any contact info? just want to ask you some questions, if that's possible.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/rnwood/smtpserver/issues/138, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKEGF47MMMT4ZZD5OOFV7LTJIC6JANCNFSM43DQSUPQ.


Call plant methylation using hg002 trained model？

Hi Dr. Peng Ni，
Could I use your trained hg002 model to call methylation in Arabidopsis or other plants ?
Best wishes,
Bo Wang

Hi Bo, I did not test that, but our HG002 CpG model should work in CpG methylation detection in Sequel II CCS data of Arabidopsis or other plants.
Best,
Peng

Thanks.


return specific type when getting scene and T is provided

Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)

Fixes a bug

Describe the changes below:
return the expected class  when using scene.get<T>()

Thank you for spending time contributing to the Phaser TypeScript Defs; I really appreciate it. However, I'm afraid I cannot merge your PR. The reason is that you've edited the Phaser defs file directly. Our defs file is generated automatically as part of our build process; it works by running a custom parser across the Phaser source code, extracting the JSDoc blocks, and then building the types from those. This means that if we were to merge your PR, your changes would be instantly lost the next time the defs are generated.
To fix the defs permanently, you need to edit the underlying JSDocs in the source code, causing the defs error. Sometimes, the error results from a limitation in the TS parser, but mostly because of incorrectly typed JSDocs. Please look at the command npm run help to see the options available to you for building and running our TS parser for yourself so you can edit the JSDoc blocks, run the parser, and see if the end result is resolved or not.

thanks rich, I'll see what I can do!
On Wed, 30 Oct 2024, 13:56 Richard Davey, @.***> wrote:

Thank you for spending time contributing to the Phaser TypeScript Defs; I
really appreciate it. However, I'm afraid I cannot merge your PR. The
reason is that you've edited the Phaser defs file directly. Our defs file
is generated automatically as part of our build process; it works by
running a custom parser across the Phaser source code, extracting the JSDoc
blocks, and then building the types from those. This means that if we were
to merge your PR, your changes would be instantly lost the next time the
defs are generated.
To fix the defs permanently, you need to edit the underlying JSDocs in the
source code, causing the defs error. Sometimes, the error results from a
limitation in the TS parser, but mostly because of incorrectly typed
JSDocs. Please look at the command npm run help to see the options
available to you for building and running our TS parser for yourself so you
can edit the JSDoc blocks, run the parser, and see if the end result is
resolved or not.
—
Reply to this email directly, view it on GitHub
https://github.com/phaserjs/phaser/pull/6936#issuecomment-2447058392,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARV7IO3T7VSHO5JXY3AI4TLZ6DJRFAVCNFSM6AAAAABQ3YFEAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGA2TQMZZGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Move all preprocessing steps to the same module

@timonmerk
Right now part of the preprocessing steps are happening in nm_run_analysis, and notch-filtering is performed in nm_features. I would suggest to at least also move notch-filtering to nm_run_analysis. Maybe it would be even more elegant to move preprocessing steps to a module called e.g. nm_preprocessing. That way, we can simplify the code in the run function and just call the entire preprocessing pipeline like:
ieeg_batch = nm_preprocessing.preprocess(ieeg_batch, settings)
On another note, I think the best order for preprocessing raw data would be:

re-referencing
re-sampling
notch-filtering
band-stop filtering (for stimulation artifacts)
normalization (so that normalization is performed at the very end

What do you think?

Hey @richardkoehler, thanks for raising those points.
I setup a 'refactor' branch where I started to implement a new software design. So far I specified the nm_stream abstract class, and refactored the settings for more intuitive handling using realtime and bids data analysis (still work in progress).
The preprocessing points are well taken! Separating them in a separate file definitely makes sense. I would not agree with having the rereferencing as the first step, since rereferencing is a samplewise operation which would yield exactly the same result when resampling would have been made beforehand; and thus would save computational cost.
BandStop Filtering is not implemented so far, it would be definitely a necessary preprocessing step.
Maybe having in the nm_settings.json the preprocessing ordering as a provided list could be reasonable, since the ordering effect on e.g. performance is not that known / evaluated


Build errors when configured for Python wrapping

Description
ITK build incomplete due to errors when wrapping with Python.

Actual behavior
itkAdditiveGaussianNoiseMeshFilter: warning(4): ITK type not wrapped, or currently not known: itk::MeshToMeshFilter< itk::Mesh< float, 2, itk::DefaultDynamicMeshTraits< float, 2, 2, float, float, float > >, itk::Mesh< float, 2, itk::DefaultDynamicMeshTraits< float, 2, 2, float, float, float
/Users/mseng/ITK-build-no-legacy/Wrapping/Typedefs/itkAdditiveGaussianNoiseMeshFilter.i:124: Warning 401: Nothing known about base class 'itk::MeshToMeshFilter< itk::Mesh< float,3,itk::DefaultDynamicMeshTraits< float,3,3,float,float,float > >,itk::Mesh< float,3,itk::DefaultDynamicMeshTraits< float,3,3,float,float,float > > >'. Ignored.
/Users/mseng/ITK-build-no-legacy/Wrapping/Typedefs/itkAdditiveGaussianNoiseMeshFilter.i:124: Warning 401: Maybe you forgot to instantiate 'itk::MeshToMeshFilter< itk::Mesh< float,3,itk::DefaultDynamicMeshTraits< float,3,3,float,float,float > >,itk::Mesh< float,3,itk::DefaultDynamicMeshTraits< float,3,3,float,float,float > > >' using %template.
make[2]: *** [Wrapping/Modules/MeshNoise/itkAdditiveGaussianNoiseMeshFilterPython.cpp] Error 4 make[2]: *** Deleting file Wrapping/Modules/MeshNoise/itkAdditiveGaussianNoiseMeshFilterPython.cpp' make[1]: *** [Wrapping/Modules/MeshNoise/CMakeFiles/MeshNoisePython.dir/all] Error 2
Versions
Latest release of ITK python package.
Latest release of ITK (master branch) on Github.
Environment
Done on a Mac. Python 3.7 used in virtual environment.

@mseng10 I tried to reproduce this with the described CMake options, ITKPythonPackage, and ITK Git master on a Mac with Python 3.7. Did you try a clean build? Any other changes in your build?

@thewtex I have isolated the problem. In a separate build directory I enabled the module: Module_MeshNoise which subsequently downloaded the remote repository to my local source ITK. On my current build, this configuration was turned OFF, but MeshNoise was still part of my local repository. When attempting to build, I got the errors stated earlier.
I attempted a clean build, and created a new build directory, but neither worked. My understanding is the lone presence of the MeshNoise directory caused CMake to look for something that was not configured to be there, hence the error. Since removing the MeshNoise directory I have gotten a clean build. Thank you for checking on the issue, much appreciated!

I can't build it on Windows neither.
error MSB6006: “cmd.exe”has exited with code 4

Please describe your problem in more detail, and do it either in a new issue, or a new topic on the forum.


Using the icon drawer is challenging without a fixed height.

the other:

Thanks for reporting!
Fixed. It now remembers last height and prevents content from jumping down.


Refactoring of Media module

Added Image Manager for AJAX dialogs
Updated UI of Media module
Refactoring of bluz.ajax.js
Fixed RedactorJs for support jQuery 3.x
Fixed critical issue with upload
Fixed edit forms for Options and Pages modules

Coverage decreased (-0.3%) to 40.465% when pulling d637b13b8e875547d7cb1e7f068665d4380b566d on AntonShevchuk:master into 62da74ab088334712e693f03170b92a0ecc5ade7 on bluzphp:master.

Coverage increased (+0.5%) to 41.271% when pulling b15a67edb1f084ff3f2257040e19de90386de5eb on AntonShevchuk:master into 62da74ab088334712e693f03170b92a0ecc5ade7 on bluzphp:master.


img2img?

is img2img with minimal steps possible?

For ComfyUI users, img2img/vid2vid is already implemented: https://github.com/0xbitches/ComfyUI-LCM#img2img--vid2vid
I have opened #16 to keep track of webui extension's progress.


ImportError: No module named mesos

When I get to last step of Exercise 3 and try to bring up the mesos ps I get a python import error.
[vagrant@node1 mesos]$ mesos ps --master=$MASTER
Traceback (most recent call last):
  File "/usr/bin/mesos-ps", line 10, in <module>
    from mesos import http
ImportError: No module named mesos

I have my path setup as follows:
# ~/.bash_profile
export PYTHONPATH=${PYTHONPATH}:/usr/lib/python2.7/site-packages/

Any ideas? It appears python is unaware of where to find the packages. Maybe I overlooked something?

Update it appears running the following fixes:
# install pip on node1 then run:
sudo pip install mesos.cli

I met the some issue, too.
I fixed it with pip from EPEL.
[vagrant@node1 ~]$ sudo yum install -y epel-release
[vagrant@node1 ~]$ sudo yum install -y python-pip
[vagrant@node1 ~]$ sudo pip install pip --upgrade
[vagrant@node1 ~]$ sudo pip install mesos.cli
[vagrant@node1 ~]$ mesos ps

"-- master=$MASTER" is not required for new mesos.cli.


feat: download: support resuming

hi, a random noob here
this is my first time trying to write code in golang, so it may have some mistakes
only tested on linux, it seems to work for me, but i'm still testing for bugs

this may be relevant to #18

probably should store file hash inside .pikpakclidownload, in case the file is changed before it can resume

Thank you for your contribution to this project.


Unable to compile Typescript with --esModuleInterop enabled

Environment
Knex version: 0.17.0-next3
Node version: 10.15.3
Typescript version: 3.4.5
Bug
When I try to compile a Typescript app using Knex, the following error occurs with the --esModuleInterop TS compiler option:
node_modules/knex/types/index.d.ts:1328:13 - error TS2430: Interface 'ChainableInterface<T>' incorrectly extends interface 'Bluebird<T>'.
  Types of property 'asCallback' are incompatible.
    Type '(callback: Function) => this' is not assignable to type '{ (callback: (err: any, value?: T | undefined) => void, options?: SpreadOption | undefined): this; (...sink: any[]): this; }'.
      Type 'this' is not assignable to type 'this'. Two different types with this name exist, but they are unrelated.
        Type 'ChainableInterface<T>' is not assignable to type 'this'.

1328   interface ChainableInterface<T = any> extends Bluebird<T> {

@jsonmaur Thanks for reporting this. This has been addressed in https://github.com/tgriesser/knex/pull/3209. In the meanwhile you can consider using version 0.16.5 which should not have this issue.

Trying to build my app I realised it builds using 0.17.0-next, but starting with 0.17.0-next2 it fails with this error.

Fix released in<EMAIL_ADDRESS>Please try it out!

@kibertoad have in mind that @latest is still next3 so people are hitting it because of this

Strange, I unpublished it a couple of hours ago. Could you please check if that's still the case?

@kibertoad yeah, it still shows as latest in my yarn info knex and also here: https://www.npmjs.com/package/knex

Thanks for the quick fix! 0.17.0-next4 seems to solve it. But 0.17.0-next3 is still published under the latest tag on npm (next4 is under the next tag.)

Will look into it, thanks. For some reason unpublish didn't work?..

Looks like second time did the charm, seems gone now. Thank you for bringing it up!


Update mtree_cwm instruction

Update mtree_cwm instruction to better correspond with the mtree_set format change from #646,  [d, i, R, V', ...] -> [R', V, R, ...].
Follow up to https://github.com/0xPolygonMiden/miden-vm/pull/652#pullrequestreview-1266746611

This has been done by https://github.com/0xPolygonMiden/miden-vm/pull/655


Update README.md

Fix typo
Description
Fixes #Issue Numbers.
Changes

Added this
Updated that
Removed those

Request Reviews

@alienideology
...

Changes should have proper description :)
Good job tho!


python38Packages.django-allauth: 0.40.0 -> 0.43.0

Motivation for this change
Fixes a Django 3.x breakage.
Things done

[ x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ x ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 103206 run on x86_64-darwin 1

7 packages marked as broken and skipped:

mailman-web
python37Packages.django-mailman3
python37Packages.mailman-web
python37Packages.postorius
python38Packages.django-mailman3
python38Packages.mailman-web
python38Packages.postorius

2 packages built:

python37Packages.django-allauth
python38Packages.django-allauth

Result of nixpkgs-review pr 103206 run on x86_64-darwin 1

7 packages marked as broken and skipped:

mailman-web
python37Packages.django-mailman3
python37Packages.mailman-web
python37Packages.postorius
python38Packages.django-mailman3
python38Packages.mailman-web
python38Packages.postorius

2 packages built:

python37Packages.django-allauth
python38Packages.django-allauth


Use electron-builder instead of electron-packager?

Electron-builder is much more useful than electron-packager. For example, it can pack deb, appimage and so on.

Also, maybe later we can use autoupdater.

You can view it on my fork

Have you tested the built package? @mzwing  We found a flickering problem with the built package.


KAFKA-13772: Unevenly distribute topic partitions for threads after resizing thread number

*More detailed description of your change,
Fix bug of unevenly distribute topic partitions for threads after resizing thread number
*Summary of testing strategy (including rationale)
Unit test
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@yufeiyan1220 Thanks for the PR. That is an interesting case. I will take a deeper look at it next week.
My current understanding is that we don’t migrate partitions of some fetcher threads because we miss them while iterating over the map while the map is altered. Did I get it right?

@yufeiyan1220 Thanks for the PR. That is an interesting case. I will take a deeper look at it next week.
My current understanding is that we don’t migrate partitions of some fetcher threads because we miss them while iterating over the map while the map is altered. Did I get it right?

Exactly!

@yufeiyan1220 Could we update the title of the PR? Something like this: Partitions are not correctly re-partitioned when the fetcher thread pool is resized . Could you also update the description to explain the bug and how we have fixed it?

Merged to trunk and to 3.2.


Cannot create PRs

Hi, I'm using latest F-Droid version of Stringlate on Android 7.1.2 and I cannot create PRs, meanwhile I can create bug reports.
I tried to give adb logcat -s io.github.lonamiwebs.stringlate in order to give help but only
--------- beginning of crash
--------- beginning of system
--------- beginning of main

is shown. What should I do to send a log? ^^'

Which version of Stringlate are you using? Maybe too, which repo doesnt work?

Hi, same issue here, it forks without issues but then no pull requests or even a stringlate branch is added to the forked repo.
Details :

OS LineageOS 14.1 (Android 7.1.2), latest update
Phone Model Motorola XT1676 armeabi-v7a (Moto G5)
Repos impacted Tried several, it won't work (KeepassDX, SimpleMobileTools/*)
Logcat logcat_stringlate.log

i've let a KeepassDX repo as forked by Stringlate @ https://github.com/julianaito/KeePassDX
Hope this helps :)

Logcat guide update: Maybe take a look at https://gsantner.net/android-contribution-guide/?packageid=io.github.lonamiwebs.stringlate#logcat (has already filled out the right package id)

Fixed through #186. Sorry for the huge delay.


08.01.01

As an approver, I want to view a list of all the expense claims that were submitted for approval, which have their claim status as submitted, showing for each claim: the claimant name, the starting date of travel, the destination(s) of travel, the claim status, total currency amounts, and any approver name.

This is a UI/View test.


Topic/cython

This PR moves the bindings from a pybdingen solution to a Cython solution.
The benefits/changes are:

native conversion to/from numpy arrays (no shared memory)
support operations between Eigen objects and return Eigen objects according to the operation
slice access to Eigen objects (returns a copy of the "slice")
add bindings for Eigen::AngleAxisd (minimal: construction and conversion to matrix)

A cmake script is provided to build the bindings in CI setting but the recommended manual way is to go simply use the setup.py script
@haudren FYI, this PR includes topic/useCythonMemoryView

Nice! I would maybe add a small warning that the Eigen <-> Numpy can be expensive at big sizes because of the change in storage orders.
Reminder of the times:
>>> import numpy as np
>>> import eigen

>>> A = np.random.random((2000, 50))
>>> B = eigen.MatrixXd(A)
>>> %timeit eigen.MatrixXd(A)
10000 loops, best of 3: 107 µs per loop
>>> timeit np.array(B)
10000 loops, best of 3: 53.1 µs per loop

Oh and it might be nice to slightly rebase before merging ;)

Wow ~20k fewer lines?! that's impressive

I've added some info on the timing.

Oh and it might be nice to slightly rebase before merging ;)

I will "Squash and merge" as I find this leads to the cleanest tree in the end.

Wow ~20k fewer lines?! that's impressive

The bulk of it is probably from the removal of the cmake folder. Cython tends to be more verbose than pybindgen unfortunately.

Unfortunately yes :( But I don't think it would have been possible to do an as efficient numpy conversion in pure pybindgen.

ah I see, nonetheless thanks for adding this!


Update to new PyPy3 version.

First, thanks for the base and the actual tox package. It enabled me to use my usual tox configuration directly with docker images. That's excellent work!
Now I have request and a question of understanding:
We are currently at a version 5.8.0  for PyPy3 which actually is compatible with CPython 3.5. It would be nice to have that included here. Unfortunately I do not understand where the python-versions.txt is somehow read or included in the build process. Is it just the change of the version number in this file?

Are you sure that you use version 3.8.0 of PyPy3? The pyenv project lists "pypy3.5-6.0.0" and  "pypy-5.7.1" as the latest PyPy versions.

This is now fixed by #6 and #7.

Thanks for merging! :+1:
However, there seems to still be an issue with the image. The builds for pypy3 are building with Python 3.7. See this build output, which I get on both GitLab CI and Codeship:
$ tox -e pypy3
pypy3 create: /builds/painless-software/painless-continuous-delivery/.tox/pypy3
ERROR: invocation failed (exit code 1), logfile: /builds/painless-software/painless-continuous-delivery/.tox/pypy3/log/pypy3-0.log
ERROR: actionid: pypy3
msg: getenv
cmdargs: ['/.pyenv/versions/3.7.0/bin/python', '-m', 'virtualenv', '--python', '/.pyenv/shims/pypy3', 'pypy3']

Using base prefix '/.pyenv/versions/pypy3.3-5.5-alpha'
New pypy executable in /builds/painless-software/painless-continuous-delivery/.tox/pypy3/bin/pypy3
Also creating executable in /builds/painless-software/painless-continuous-delivery/.tox/pypy3/bin/pypy
Installing setuptools, pip, wheel...
  Complete output from command /builds/painless-sof....tox/pypy3/bin/pypy3 - setuptools pip wheel:
  DEPRECATION: Python 3.3 supported has been deprecated and support for it will be dropped in the future. Please upgrade your Python.
Looking in links: /.pyenv/versions/3.7.0/lib/python3.7/site-packages, /.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv_support
Collecting setuptools
  Using cached https://files.pythonhosted.org/packages/7f/e1/820d941153923aac1d49d7fc37e17b6e73bfbd2904959fffbad77900cf92/setuptools-39.2.0-py2.py3-none-any.whl
Collecting pip
Collecting wheel
wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 3.3.5
----------------------------------------
...Installing setuptools, pip, wheel...done.
Traceback (most recent call last):
  File "/.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv.py", line 2343, in <module>
    main()
  File "/.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv.py", line 712, in main
    symlink=options.symlink)
  File "/.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv.py", line 947, in create_environment
    download=download,
  File "/.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv.py", line 904, in install_wheel
    call_subprocess(cmd, show_stdout=False, extra_env=env, stdin=SCRIPT)
  File "/.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv.py", line 796, in call_subprocess
    % (cmd_desc, proc.returncode))
OSError: Command /builds/painless-sof....tox/pypy3/bin/pypy3 - setuptools pip wheel failed with error code 1
Running virtualenv with interpreter /.pyenv/shims/pypy3

ERROR: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('/.pyenv/versions/3.7.0/bin/python -m virtualenv --python /.pyenv/shims/pypy3 pypy3 (see /builds/painless-software/painless-continuous-delivery/.tox/pypy3/log/pypy3-0.log)', 1)
___________________________________ summary ____________________________________
ERROR:   pypy3: Error creating virtualenv. Note that some special characters (e.g. ':' and unicode symbols) in paths are not supported by virtualenv. Error details: InvocationError('/.pyenv/versions/3.7.0/bin/python -m virtualenv --python /.pyenv/shims/pypy3 pypy3 (see /builds/painless-software/painless-continuous-delivery/.tox/pypy3/log/pypy3-0.log)', 1)
ERROR: Job failed: exit code 1

The builds are using the painless/tox image, which refers to themattrix/tox-base as a dependency. Is tracing this dependency not enough for rebuilding the image correctly? It should be, shouldn't it?
Or is Tox mistakenly interpreting the PyPy3 version for a CPython version, and this makes the build fail? As of:
...
Installing setuptools, pip, wheel...
  Complete output from command /builds/painless-sof....tox/pypy3/bin/pypy3 - setuptools pip wheel:
  DEPRECATION: Python 3.3 supported has been deprecated and support for it will be dropped in the future. Please upgrade your Python.
Looking in links: /.pyenv/versions/3.7.0/lib/python3.7/site-packages, /.pyenv/versions/3.7.0/lib/python3.7/site-packages/virtualenv_support
...

This line makes me wonder:
Using base prefix '/.pyenv/versions/pypy3.3-5.5-alpha'

The updated image should be using pypy3.5-6.0.0. Not pypy3.3-5.5-alpha.

This is absolutely weird. I've removed all Docker images named "tox" from my machine, and then ran the commands below afresh. Here's what the output now is:
$ docker run --rm painless/tox:latest pyenv global
2.6.9
2.7.15
3.3.7
3.4.9
3.5.6
3.6.6
3.7.0
pypy3.3-5.5-alpha
pypy3.5-6.0.0
pypy-5.7.1

$ docker run --rm painless/tox:latest pypy3 --version
Python 3.3.5 (ea9979b550eeae87924dc4bef06070e8f8d0e22f, Oct 13 2016, 11:32:23)
[PyPy 5.5.0-alpha0 with GCC 6.2.0]

versus
$ docker run --rm themattrix/tox:latest pyenv global
2.6.9
2.7.13
3.3.6
3.4.5
3.5.2
3.6.0
pypy3.3-5.2-alpha1
pypy-5.4.1

$ docker run --rm themattrix/tox:latest pypy3 --version
Python 3.3.5 (27fa55f3a61023d76af3b38f34d1401b0b186076, May 31 2016, 17:54:15)
[PyPy 5.2.0-alpha0 with GCC 4.9.2]

Why does the painless image have newer PyPy version than themattrix one, when it's really just inheriting from it and installing Git?
Do we have to change the order in the python-versions.txt file to make pypy3 be pypy3.5 by default?

@themattrix Can you see this, too? Do you happen to know what the problem could be?

Ah...so here's what was going on: The tox image was still using an outdated tox-base image. I've rebuilt themattrix/tox and it seems to be working now. Let me know if that fixes the issue on your end!

Here's the current list:
$ docker run --rm themattrix/tox:latest pyenv global
2.6.9
2.7.15
3.3.7
3.4.9
3.5.6
3.6.6
3.7.0
pypy3.3-5.5-alpha
pypy3.5-6.0.0
pypy-5.7.1

The unfortunate part is that pypy3 refers to pypy3.3-5.5-alpha and not pypy3.5-6.0.0 (as you've pointed out). I'll see what I can do about that...
$ docker run --rm themattrix/tox:latest pypy3 --version
Python 3.3.5 (ea9979b550eeae87924dc4bef06070e8f8d0e22f, Oct 13 2016, 11:32:23)
[PyPy 5.5.0-alpha0 with GCC 6.2.0]

I think I've figured it out. pyenv does its own lexical sorting of the installed versions. It stores this list in /.pyenv/version. This list is identical to /python-versions.txt but is simply in a different order. When I replace /.pyenv/version with /python-versions.txt, pypy3 suddenly refers to pypy3.5-6.0.0 and python3 switches to 3.7.0.
I will update themattrix/pyenv to perform this replacement, and I expect this to solve the ordering issue.

Hooray! How does this look, @bittner?
$ docker run --rm themattrix/tox:latest pyenv global
3.7.0
3.6.6
3.5.6
3.4.9
3.3.7
2.7.15
2.6.9
pypy-5.7.1
pypy3.5-6.0.0
pypy3.3-5.5-alpha

$ docker run --rm themattrix/tox:latest pypy --version
Python 2.7.13 (1aa2d8e03cdfab54b7121e93fda7e98ea88a30bf, Apr 04 2017, 12:21:42)
[PyPy 5.7.1 with GCC 6.3.0]

$ docker run --rm themattrix/tox:latest pypy3 --version
Python 3.5.3 (fdd60ed87e94, Apr 24 2018, 06:10:04)
[PyPy 6.0.0 with GCC 6.2.0 20160901]

$ docker run --rm themattrix/tox:latest python3 --version
Python 3.7.0

$ docker run --rm themattrix/tox:latest python2 --version
Python 2.7.15

Thanks for your effort and attention to detail! :+1:
One last thing: While totally unnecessary and only of esthetic make, you could put pypy at the end of the list.
This way we would have all the Python versions (visually) ordered from the latest to the oldest version.
As I said, optional.


UI Redesign

Redesign the UI to allow for more advanced effects, while remaining easy to understand.

[x] Include a layer manager, allowing users to reorganize layers, edit individual layers, and add/remove new ones. (This will replace the current "tabs" system)
[x] Split every current tab into their own Layers.

[ ] Include a "basic" and "advanced" modes. Basic will be similar to what Aurora offers right now. Advanced will allow users to add & edit layers.
[ ] [Not Sure] Split up the virtual keyboard into 3 sections: Keyboard, Mouse/Peripheral, Extra lights
[ ] [Not Sure] Add ability to overlay the debug image over the virtual keyboard. (Will allow for easier debug and a good visual alternative to current design)

Here's a small demo of the layers. The CPU and RAM usages are their own "Percent Layers" with transparent background colors. There are two interactive layers, one is for Key Wave and other is Key Wave (filled) creating this "Circle with a boundary" effect.

These layers will work with all profiles.

Completed.


Fix Nil deserialization #38 + fixed type variable name

Merged on top of master and fixed the variable name

Thanks!

@luben Anything else to be done before release? If not, I could publish it tomorrow on Sonatype.

@romix I can't think of anything. Ship it!


toList from iterator is little to specific

I think return type of toList on Iterator require you match the variable to be of List type. Generally I would expect it to be able to return higher type like Seq so that anyone can change the implementation for the custom iterator to his own types instead of limited to List. Other more compelling reason is I think is that Iterator is more generic interface not tied to any specific implementation of Seq.
At the minimum I think iterator should have toSeq method as well.
This is the idea  almost in all interfaces in java  e,g stream.collect

Thank you, I will take it into account when modularizing Vavr 1.0. The specific conversion methods will disappear or replaced by a generic conversion method, like
<C extends Traversable<T>, T> to(Class<C> type)

to(Class<C> type) seems a bit ugly to me as it involves reflection to create an instance of that class. Isn't Value.collect() enough for this?

@nfekete yes, nice suggestion! In the case of Traversables Value.collect() is sufficient.
I had a more general conversion method in mind that also works for the single-valued Value implementation (like Option, Try, ...). Driver is modularization. Once we split modules, the base module io.vavr.core will not depend on collections, controls etc. anymore. Then the specific toOption(), toTry(), etc. methods will disappear.
However, when looking at Value I think, I will remove it completely. Without the conversion methods, there will not be much that remains:
 * Basic operations:
 *
 *

 *
{@link #get()}

 *
{@link #getOrElse(Object)}

 *
{@link #getOrElse(Supplier)}

 *
{@link #getOrElseThrow(Supplier)}

 *
{@link #getOrElseTry(CheckedFunction0)}

 *
{@link #getOrNull()}

 *
{@link #map(Function)}

 *
{@link #stringPrefix()}

 *

 *
 * Equality checks:
 *
 *

 *
{@link #corresponds(Iterable, BiPredicate)}

 *
{@link #eq(Object)}

 *

 *
 * Iterable extensions:
 *
 *

 *
{@link #contains(Object)}

 *
{@link #exists(Predicate)}

 *
{@link #forAll(Predicate)}

 *
{@link #forEach(Consumer)}

 *
{@link #iterator()}

 *

 *
 * Side-effects:
 *
 *

 *
{@link #out(PrintStream)}

 *
{@link #out(PrintWriter)}

 *
{@link #peek(Consumer)}

 *
{@link #stderr()}

 *
{@link #stdout()}

 *

 *
 * Tests:
 *
 *

 *
{@link #isAsync()}

 *
{@link #isEmpty()}

 *
{@link #isLazy()}

 *
{@link #isSingleValued()}

 *

The getXxx() methods will be revisited (Vavr vs. Java vs. Scala), removed from the Traversables and moved to Option, Try, ...
map-only makes no sense without flatMap, which is not possible in Java. Namely, we are not able to abstract over Monads towards For-Comprehensions. In Java we have to implement it for each type separately (using method overloads). See API.For, #1629, #2216
stringPrefix() is (more or less) the same as getClass().getSimpleName(). I will remove it from Vavr 1.0.
Equality checks corresponds and eq were a mistake. We don't need yet another notion for equality in Java. With the upcoming native Java value types we will get deep quality.
we don't really need Iterable extensions for single-valued types. There are workarounds. Some methods might be moved to Traversable. Most Vavr types will extend Iterable directly.
All side-effects (but peek()) will be removed. These are basically console outputs.
The tests are not needed IMO. Characteristics should be made explicit by using the according types, i.e. Iterator or Stream for the lazy case, Future for the async case, etc. Of course isEmpty() is still needed.

Regarding the conversion method for single-valued types, we need 'another layer of indirection' in order to make types convertible. More specifically, we need to be able to access the state of a monad somehow.
Examples:

this
to
result

Some(t)
Try
Success(t)

None
Try
Failure(NoSuchElementException)

Some(t)
Future
Future(Success(t))

None
Future
Future(Failure(NoSuchElementException))

Some(t)
Either
Right(t)

None
Either
Left(Void) ?

Some(t)
Validation
Valid(t)

None
Validation
Invalid(Void) ?

We need also convert Try, Future, Either and Validation to all other types.
All these types have in common that they have dual states and all operations are biased to one of the states. We could solve the conversion issue by adding an interface Convertible<T, U> that is able to check the state and pull out one of the two values (according to the state).
What we need is a type constructor. We could build one the following way:
public interface Try<T> extends Convertible<T, Throwable> {

    static <T, U> Try<T> cons(Convertible<T, U> convertible) {
        if (convertible instanceof Try) {
            return (Try<T>) convertible;
        } else {
            return convertible.isDefined() ? Try.success(convertible.get()) : Try.failure(new NoSuchElementException());
        }
    }
}

However, we would not be able to preserve specific state, like an exception when we convert an Either to a Try.
But maybe we don't need these conversions at all. Maybe we should convert in a first step

Option <-> Try
Either <-> Validation

...and that's it.

We align to Scala. Additionally to Java's collect(Collector), our collections will also have the toXxx() methods.
When redesigning Iterator for 1.0, we will align to Scala...
scala> val i: Iterator[Int] = Set(1, 2, 3).iterator
i: Iterator[Int] = <iterator>

scala> i.toList
res1: List[Int] = List(1, 2, 3)

scala> i.toSeq
res2: Seq[Int] = List()

On help let's discuss it first.

Since the Iterator# List toList() is already present, the actual alignment would involve just the addition of toSeq methods on Iterator?

@pivovarit Hold your horses. I'm not sure about that. I will come back in 1 hour...

@pivovarit Let's only cover toSeq in this issue.
In Scala, a List implementation is returned by toSeq. (I thought it would be Vector because it is general purpose but List is more efficient for few elements).

If we decide to add other methods, like toSet, we will create separate PRs...


License Missing

Could you please add a license, I would be happy to use elements of this!

@pgonzaleznetwork having 290+ unlocked packages and implementing flags für real continuous delivery - you solved the test mocking very interesting so I am very happy that you are sharing your code as MIT :)
I have also added some flow support to it via invocable, if you want i can also contribute this back here.

@con242 I would love to see your contribution. Please do!


Support for python virtualenv

It would be nice t have support for python virtualenvs.

https://github.com/slomkowski/bash-full-of-colors/pull/8 or check my fork in which i add this feature


Chakrabarti Plot

Create MHKIT-MATLAB function for creating a Chakabarti Plot

closed in https://github.com/MHKiT-Software/MHKiT-MATLAB/commit/2d27a3dcc785c5f94ea69f4bbd0644cc778116ca


Blank screen in Flet App When Packed into APK

Description:
When running my Python GUI framework, Flet, in web view or normal window mode, the app displays correctly  However, after packing it into an APK using the provided GitHub workflow and .yml file, the app exhibits a light-black gray color instead. No errors occur during the build process.
Expected Behavior:
The app's appearance should remain consistent whether running in web or normal window with the apk version
Additional Information:
Flet version: 0.21.1 (also tested on 0.20.0)
Flutter version: 3.16.8
Python version: 3.11.6

Workflow .yml File:
name: Python and Flutter Build
on:
push:
branches:
- main
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout code
  uses: actions/checkout@v2

- name: Set up Python 3.11.6
  uses: actions/setup-python@v2
  with:
    python-version: 3.11.6

- name: Install dependencies
  run: |
    python -m pip install --upgrade pip
    pip install -r requirements.txt

- name: Set up Android SDK
  uses: android-actions/setup-android@v2

- name: Set up Flutter
  uses: subosito/flutter-action@v2
  with:
    flutter-version: '3.16.8' # La versión de Flutter que estás utilizando

- name: Build with Flet
  run: |
    flet build apk --template https://github.com/KeimaSenpai/Flet-template-build.git

- name: Create Release
  id: create_release
  uses: actions/create-release@v1
  env:
    GITHUB_TOKEN:  ${{ secrets.token}}
  with:
    tag_name: v1.0.1
    release_name: Release 1.0.1
    body: |
      This is the first release.
    draft: false
    prerelease: false
- name: Upload Release Asset
  id: upload-release-asset
  uses: actions/upload-release-asset@v1
  env:
    GITHUB_TOKEN: ${{ secrets.token}}
  with:
    upload_url: ${{ steps.create_release.outputs.upload_url }}
    asset_path: ./build/apk/app-release.apk
    asset_name: app-release.apk
    asset_content_type: application/zip

A mi también me sucedía esto. Intenté de varias maneras y la única que me sirvió fue usando en el .yml el servidor de macos en vez del de Ubuntu asi:
build-android:
runs-on: macos-latest
steps:
- uses: actions/checkout@v3

- name: Set up JDK 18
  uses: actions/setup-java@v3
  with:
    java-version: '18'
    distribution: 'temurin' # Eclipse Adoptium

- name: Install Android Command Line Tools
  run: |
    brew install --cask android-commandlinetools

- name: Accept Licenses
  run: yes | sdkmanager --licenses

- name: Install Android SDK and Tools
  run: |
    sdkmanager "cmdline-tools;latest" "platforms;android-33" "emulator" "tools" "platform-tools" "ndk;25.2.9519653"

- name: Install Python and Flet
  run: |
    pip3 install flet
    pip3 install<EMAIL_ADDRESS>    pip3 install --upgrade cython

- name: Set up p4a
  run: |
    export ANDROID_SDK_ROOT="/Users/runner/Library/Android/sdk"
    export NDK_VERSION=25.2.9519653
    export SDK_VERSION=android-33
    ( echo "Y"; while true; do echo "N"; done ) | p4a create --requirements python3 --arch arm64-v8a --arch armeabi-v7a --arch x86_64 --sdk-dir $ANDROID_SDK_ROOT --ndk-dir $ANDROID_SDK_ROOT/ndk/$NDK_VERSION --dist-name mydist
    export SERIOUS_PYTHON_P4A_DIST=$HOME/.python-for-android/dists/mydist

- name: Set up Flutter
  uses: subosito/flutter-action@v2
  with:
    channel: 'stable'

- name: Build APK
  run: flet build apk -vv

- name: Archive APK
  run: |
    zip -r (el nombre de tu app)-android.zip ./build/apk/*.apk

- name: Upload APK to GitHub Release
  run: |
    gh release upload ${{ github.event.release.tag_name }} (el nombre de tu app)-android.zip
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

No activity here, cool...
Have the same problem - blank screen

Does anyone EVER succeded with apk build on ubuntu??

Na i wasted god know how many days at last shifted to react native


Timer bugfix: set current player before updating tick values

SUMMARY
This PR fixes a bug in the Timer class related to multiplayer games and persisted tick values. This bug would trigger variable updates and events using the wrong player number, which could create unexpected downstream effects.
DETAILS
When added to a mode, a Timer instance sets self.player = player to track the current player—which it uses for saving the tick values as player variables, to be consumed by many others.
There is a bug where the self.player value is set at the end of the mode setup logic, after the various timer values and ticks have been set. In a multiplayer game, this means that the values are being written to the previous player, instead of the current one.
This PR fixes the bug by setting self.player = player at the top of the mode setup logic, so that all subsequent calls will use the correct player.

Thanks for debugging and fixing this! Do you got a testcase or example which we can use to regression test this?

Now with more test!

Awesome. Thanks!


can not see the error message in the User Input page.

Describe the bug
I can not see my error messages in the  User Input page.

Version

Browser

[x] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

addressed via #2540


Remove deprecated Ember.K

This PR was generated automatically using ember-k-codemod

This is now the definitive PR.

This is now the definitive PR.


Method from Proxies versus Fields from proxies

JSIL adds to type all fields that was defined in Proxies, but skip such methods (so, only methods that was defined in original class will go to output).
Why does it work so?

Because it's broken, probably. It used to work but I guess I didn't have sufficient test coverage.
I hit some other related bugs in proxies when working on the FNA stuff, I need to fix them.

Thanks, so I'll try to write proper DCE analyze as if we could add new methods through proxy (pretty sure it still won't work initially, but at least it will be simpler fix it).
I also have a question - what is "recommended" way to implement proxy if we need to cast it back to original type (to pass it to some other function)? Should we declare proxy as derived type to proxied type? As I understand we also could convert it through object (ProxiedType)(object)this. Do we have any other options?

The way proxies should work:
Proxies formally work as an overlay onto the type they proxy. Any reference to the proxy should be translated into a reference to the type it's overlaid onto. As such, you should be able to overlay additional fields, properties, methods and events onto the target type, and they will be compiled as if they were a part of the original type.
In that sense, the proxy shouldn't inherit from anything and it should never be visible once compilation is finished. There are a few bugs I know of right now that break this rule.

Ok, lets see an example. Here is source types:
public class SomeClass : Attribute
{
    public void TestMethod()
    {
    }
}

public static class SomeClassHelper
{
    public static void Helper(this SomeClass c)
    {
        Console.WriteLine("SomeClass passed to this method");
    }
}

Let's implement proxy for SomeClass.TestMethod that will run SomeClassHelper.Helper with current instance. I see two options right now:

ProxyClass inherit SomeClass

[JSProxy(typeof(SomeClass))]
public class ProxyClass : SomeClass
{
    public void TestMethod()
    {
        this.Helper();
    }
}

Cast ProxyClass  through an object

[JSProxy(typeof(SomeClass))]
public class ProxyClass
{
    public void TestMethod()
    {
        ((SomeClass)(object)this).Helper();
    }
}

Looks like both options are work normal currently. So, my question - what is recommended way to do it? If I missed some other options?

If memory serves, the way this SHOULD work is that you define a proxy for the extension method that accepts your proxy type, and then call it. JSILc should swap out the proxy type in the arglist of the extension method proxy, and then the extension method itself will be replaced with a reference to the real one.
(This requires you to make the extension method proxy marked as NeverReplace so it doesn't replace the real extension method.)
I don't know if it works for extension methods, though. I've only done it with normal methods.

Cool, I like it! Unfortunately it is broken currently, but let's put it here for reference/future test adding:
using System;
using JSIL.Proxy;

public static class Program
{
    public static void Main()
    {
        new SomeClass().TestMethod();
    }
}

public class SomeClass : Attribute
{
    public void TestMethod()
    {
    }
}

public static class SomeClassHelper
{
    public static void Helper(this SomeClass c)
    {
        Console.WriteLine("SomeClass passed to this method");
    }
}

[JSProxy(typeof(SomeClassHelper))]
public static class SomeClassHelperProxy
{
    [JSNeverReplace]
    public static void Helper(this ProxyClass c)
    {
    }
}

[JSProxy(typeof(SomeClass))]
public class ProxyClass
{
    public void TestMethod()
    {
        this.Helper();
    }
}

When I thought about last example I see that it will have problem with identifying source class of Helper method:
using System;

using JSIL.Meta;
using JSIL.Proxy;

public static class Program
{
    public static void Main()
    {
    }
}

public class SomeClass : Attribute
{
    [JSDeadCodeEleminationEntryPoint]
    public void TestMethod()
    {
    }
}

public static class SomeClassHelper
{
    public static void Helper(this SomeClass c)
    {
        Console.WriteLine("SomeClass passed to this method");
    }
}

public static class AnotherClassHelper
{
    public static void Helper(this SomeClass c)
    {
        Console.WriteLine("SomeClass passed to this another method");
    }
}

[JSProxy(new [] {typeof(SomeClassHelper), typeof(AnotherClassHelper)})]
public static class SomeClassHelperProxy
{
    [JSNeverReplace]
    public static void Helper(this ProxyClass c)
    {
    }
}

[JSProxy(typeof(SomeClass))]
public class ProxyClass
{
    [JSDeadCodeEleminationEntryPoint]
    public void TestMethod()
    {
        this.Helper();
    }
}

What method from ProxyClass.TestMethod have we called: SomeClassHelper.Helper or  AnotherClassHelper.Helper?
Really, I have nearly same problem in DCE when I tried to implement full proxy support there - how can we check what original member reference we have, when we meet proxy member reference?

I'm not really sure. Maybe proxies should be restricted to a single type, and to proxy multiple types you need multiple proxies?

Probably yes, at least some types of proxies - on other side JSIL currently use multi-type proxies at least for  IntegerProxy/NumberProxy. But right now, I'm not sure what is definition of this border line.

Maybe if proxies can inherit from other proxies, that solves the issue while keeping the 'specific proxy per specific type' upside

@kg, I don't understand your last suggestion :(

You'd have Int32Proxy and Int64Proxy, but they both inherit all their actual methods from NumberProxy. Then the method on Int32 is from Int32Proxy so you can map perfectly in either direction without being uncertain where it came from

Still don't understand how it solves our problem.
It looks that type can be proxy for more than one type while it doesn't reference other proxy types in any form (as field, generic argument, method argument or return type).
Probably we should also restrict using any non-single proxy from any other proxy.
All other cases looks fine. We also need introduce resolving original MemberInfo/MemberDefenition by proxied MemberInfo.

Looks like I understand you. You suggest something like:
public class NumberProxy
{
  public void ProxyForSomeMethod()
  {
  }
}

[JSProxy(typeof(int))]
public class Int32Proxy : NumberProxy{
}

[JSProxy(typeof(int))]
public class Int64Proxy : NumberProxy {
}

Right now, as I already mention, it is possible to derive proxy type from original type - in this case it will be a little bit easier access protected member of original type - you don't need to declare it in proxy :)
Today I've also think about defining all mappings right on proxy. In my example it could be something like:
[JSProxy(new [] {typeof(SomeClassHelper), typeof(AnotherClassHelper)})]
public static class SomeClassHelperProxy
{
    [JSNeverReplace]
    public static void Helper(this ProxyClass c)
    {
    }
}

[JSProxy(typeof(SomeClass))]
[JSProxyMapping(typeof(SomeClassHelper),typeof(SomeClassHelperProxy))]
public class ProxyClass
{
    public void TestMethod()
    {
        this.Helper();
    }
}

Really I'm still not sure last idea is really possible and I don't like it very much, restriction on references only single-type proxy looks better for me now. Probably I will try to do something on it tomorrow as I have a problem with creating some new proxies (I'm trying to get rid of most BCL classes implementation in Libraries*.js and use all of them translated). So right now I have:

Expression.Constant (static method) calls ConstantExpression.Make (internal, static method).
I need to create proxy for Expression.Constant that will still do call to Make, but remove some checks. Right now, it is possible to achieve only with [JSExternal] or using Verbatium inside proxy.


⚠ Bofrost.at has degraded performance

In 3b5e6dc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1598 ms

Resolved: Bofrost.at performance has improved in 9aebc30 after 9 minutes.


Adding docs

Short installation guide in README.md
The directory /docs was added where all additional markdown files were placed.

@s1m0000n review please

There are changes in .md files only, therefore workflows were cancelled


Feature request: Additional field Cluster in Release object

Hi, I want to add Release.Cluster field, which can get by running kubectl config get-contexts,  to avoid duplicating the value among clusters.
I'm using helm on GKE with multi-cluster environment.
When I start using helm, I have a single cluster and there is no problem with that.
However, if I deploy the same chart with different clusters, I'm having the problem of duplicated resource on GCP.
For instance, I deploy ingress with annotation kubernetes.io/ingress.global-static-ip-name to reserve static ip on GCP, duplicated name is not allowed, so we have to change their name for each clusters.
Currently I workaround by renaming annotation value for each cluster.
If I have the Cluster field in Release object, the resource name will not duplicated.
annotations:
  kubernetes.io/ingress.global-static-ip-name: "{{ .Release.Cluster }}-app"

Duplicate of #2055

@katsew This looks like a duplicate of #2055. Have a look at that issue and add your comment to it.
I am going to close this as a duplicate. It can be re-opened if need be.


[BUG] outdated PrioritizedSliceSampler implementation

Hi @vmoens, I encountered the bug described in issue #1969 again. I am using the same TDMPC code and the bug-fixed version (2024.3.26) of torchrl. The only difference is that I am using PrioritizedSliceSampler instead of SliceSampler.
To Reproduce
Please refer to the same reproduction method as described in issue #1969, but replace SliceSampler with PrioritizedSliceSampler.
Expected Behavior
PrioritizedSliceSampler should not fail when at capacity, just like SliceSampler.
Reason and Possible Fixes
The original bug was effectively addressed by commits e835770 and 6fb16a2. However, the changes made to fix the bug in SliceSampler have not been applied to PrioritizedSliceSampler. Specifically, SliceSampler uses the updated _sample_slices() method for sampling, but PrioritizedSliceSampler does not.
Checklist

[x] I have checked that there is no similar issue in the repo (required)
[x] I have read the documentation (required)
[x] I have provided a minimal working example to reproduce the bug (required)

Thanks for reporting!

Thank you for the quick response and the fix! I will test the commit and provide feedback soon.

My code works well with commit #2194, thanks for the fix!


Handle route prefix with comments

Issue describing the changes in this PR
resolves #2707
Pull request checklist

[x] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[x] My changes should not be added to the release notes for the next release

[ ] Otherwise: I've added my notes to release_notes.md

[x] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[x] I have added all required tests (Unit tests, E2E tests)

Additional PR information

@microsoft-github-policy-service agree

/azp run extensions.http.aspnetcore.public

/azp run extensions.http.aspnetcore.public

@BigDyma can you merge main into your branch? This change needs to be present to run the pipeline correctly. Thanks!