Scoping SCSS under a different body class breaks some components

To preview experimental carbon in carbon-components-angular we generate two preview.scss files and import carbon under two different containing classes (.carbon and .experimental).
As expected some tweaks are required to make this work (manually scoping the reset and fonts for example) ... but strangely enough some component styles also break (mainly padding/margins) ... see these lines for what I mean. It doesn't appear to be an issue for X, but it's definitely unexpected behavior.

For sure! I'll make some time to look into it closer and see if there's a reasonable fix

So I seem to have narrowed it down: if & is used as a second level selector, it inherits the entire  first level selector. So .#{$prefix}--structured-list-row becomes .carbon .bx--structured-list-row and
.#{$prefix}--structured-list--selection &:hover:not(.#{$prefix}--structured-list-row--header-row)

becomes
.bx--structured-list--selection .carbon .bx--structured-list-row:hover:not(.bx--structured-list-row--header-row)

instead of
.carbon .bx--structured-list--selection .bx--structured-list-row:hover:not(.bx--structured-list-row--header-row)

This isn't an issue for most & situations, where you absolutely do want to retain the entire selector. It also isn't an issue (as far as I can see) if you're using & in a third level selector from a second level selector with no misplaced &.
I'll open a PR for the 3 cases I'm aware of right now


Prepare next release (v0.1.0)

Trash the old releases. Change the package structure to something more like ryser, vizing etc ...
Add a NEWS.md.

Use pytest and poetry.


Expose a Zarr interface to Tiled

We could add a dedicated route, like /zarr/v3/ that exposes Tiled's contents as Zarr, such that fsspec would "just work" with it.
Open questions:

What to do about structures like table, sparse, and awkward that do not (yet, at least) fit cleanly into Zarr's data model?
While small container structures map perfects onto Zarr groups, Tiled also supports extremely wide containers (~1M entries) and exposes a paginated API. Is there an analog in Zarr?

To start, one option is to simple filter out nodes that do not map cleanly into Zarr, exposing only those nodes that do.

Inspired by discussion with @joshmoore at SciPy 2023, but I think not written down until now.

What to do about structures like table, sparse, and awkward that do not (yet, at least) fit cleanly into Zarr's data model?

My assumption is that these would be "layouts" of zarr arrays. @ivirshup can say more on sparse and likely awkward. table I assume could be columnar style with the number of arrays matching the number of columns.

While small container structures map perfects onto Zarr groups, Tiled also supports extremely wide containers (~1M entries) and exposes a paginated API. Is there an analog in Zarr?

I don't think I know understand well enough what you mean by wide containers. If this would be 1M zarrays in a single zgroup, that's doable, but you would never want to list the zgroup. Is this where pagination comes in? If it's a wide array, then I don't think there's a particular issue, because the pagination would map to chunking, right?

I think I actually talked with @danielballan a bit about this in Seattle in May. In anndata, we've got on disk formats for tables and sparse built on top of hdf5/ zarr (description).
Tools like vitessce can provide nice visualizations based on these formats.
IIRC, tiled's sparse support is based off of chunks which each contain sparse data in COO format? That's not quite how we've been doing sparse in anndata, but I would like to support something more like this, but with support for at least CSR, CSC. I've written up a bit of my thoughts on this here: https://github.com/GraphBLAS/binsparse-specification/issues/16.
Our awkward storage isn't to developed. We only have read and write, no partial access.
@trevormanz has also been interested in the idea of a server-backed zarr store.

OK, so a "layout" is a standard Zarr on-disk format with a special interpretation layered on top---i.e. "You should interpret this group of arrays as a table and assume that they have equal length?" Does Zarr have an official way to encode a layout?
Yes, "wide contianers" would be like 1M zarrays in a single zgroup---too large to list in a single request. Tiled provides filtering (search) and paginated access to make that tractable.
Yes, tiled's sparse support is has chunked-array semantics (like dask.array) where each chunk is transmitted as a table of COO data. We have built in a path for other sparse layouts (CSR, CSC) but not yet implemented.
Isaac meant to tag @manzt, I think.

@trevormanz has also been interested in the idea of a server-backed zarr store.

Yes! Thanks for tagging me. I made simple-zarr-server to expose any Python Zarr store (MutableMapping) over HTTP. Would be really valuable to have an even wider Zarr-compat layer with something like bluesky.

Nice! I don't think I'd seen that one yet. I'm working on a branch to update on our docs on "How Tiled Fits Into the Ecosystem". I'll include simple-zarr-server in the list of data services we know about. This looks like a great lightweight option. (Aside: Do you use websockets? I see it in the CLI help string but could not immediately find it in the source. We should chat.)
Yes, we do go the other way: exposing a Zarr store with Tiled's existing endpoints, layering on the things that Tiled gets you for the extra weight:

Fast search on top-level metadata (which is copied into a SQL database)
AuthN/AuthZ if you need it
Transcoding --- e.g. access a slice of array as PNG or JSON

Aside: Do you use websockets? I see it in the CLI help string but could not immediately find it in the source. We should chat.

It doesn't, oops! I just copied the CLI from uvicorn since it just forwards args to creating the server. Sorry for the confusion.

We should chat.

Definitely! Let's find a time.

Fast search on top-level metadata (which is copied into a SQL database)
AuthN/AuthZ if you need it
Transcoding --- e.g. access a slice of array as PNG or JSONTranscoding --- e.g. access a slice of array as PNG or JSON

Wow, awesome. It's been a while since I check in on things here. The transcoding is something I've always wanted access to from a web app.
One thing I've been thinking about for a while is letting a zarr client "request" "preferred" encodings through something like request headers or query params.
# cat a basic zarr store
curl -sL https://my-zarr-service.com/data.zarr/.zarray
# { "dtype": "<u8", "shape": [10000, 10000], "chunks": [1024, 1024], "compression": ... }

# provide "preferred" overrides
curl -sL https://my-zarr-service.com/data.zarr/.zarray?dtype=<u2&chunks=[256,256]&compression="gzip"
# { "dtype": "<u2", "shape": [10000, 10000], "chunks": [256, 256], "compression": { "codec_id": "gzip" ...} }

Isaac meant to tag @manzt, I think.

😅, yes. Thanks for figuring that out.

OK, so a "layout" is a standard Zarr on-disk format with a special interpretation layered on top---i.e. "You should interpret this group of arrays as a table and assume that they have equal length?" Does Zarr have an official way to encode a layout?

anndata defines this for itself. This has been discussed a bit around zarr, but nothing has been formalized yet: https://zarr.dev/zeps/draft/ZEP0004.html.

@manzt We have exactly the same vision. Choosing the format and compression encoding works now, via HTTP content negotiation headers, e.g.
curl -H 'Accept: application/json' 'https://tiled-demo.blueskyproject.io/api/v1/array/full/generated/medium_image?slice=:5,:5

We also support a custom query parameter ?format for contexts where headers cannot be set, like shareable links.
curl 'https://tiled-demo.blueskyproject.io/api/v1/array/full/generated/medium_image?format=json&slice=:5,:5'

We have not addressed re-chunking or requesting a coarser dtype, but these ideas have been raised and are certainly in scope.
I've sent you an email.
Thanks for the reference, @ivirshup. That ZEP was not yet on our radar.
I like the idea of specified higher-level interpretations for Zarr data. It would cover some of our use cases, though not all of them. For example, we sometimes handle very wide tables---a snapshot of the state of a large amount of scientific hardware before and after an experiment---which can be 2 rows long and hundreds of columns wide. I believe this is not a good fit for a Zarr group, performance-wise, but it's a great fit for Arrow or Parquet.

For example, we sometimes handle very wide tables---a snapshot of the state of a large amount of scientific hardware before and after an experiment---which can be 2 rows long and hundreds of columns wide. I believe this is not a good fit for a Zarr group, performance-wise, but it's a great fit for Arrow or Parquet.

This is like pd.DataFrame(np.random.rand(2, 10_000))?
With my understanding of parquet and arrow, this would also be a bad case since there's an overhead per column. However, using a DirectoryStore with anndata's tabular encoding would definitely be far worse. I think if it was a ZipStore or something it may not be so different. I have also been wondering if we could shard across zarr arrays, letting anndata's table representation have something more like parquet's row-groups.

Actually I think this may be relevant. If we expose Tiled as "a Zarr", i.e. add a /zarr/v3/{path} endpoint that is Zarr-like, what should we do with tables? If we expose them as Zarr groups, will they be so slow it would be better just to omit them?
df = pd.DataFrame(np.random.rand(2, 1000))

%timeit df.to_parquet('test.parquet')
66.9 ms ± 1.69 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

g = zarr.open_group("test.zarr", "w")
%timeit for column in df: g[str(column)] = np.asarray(df[column])
740 ms ± 50.8 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

But I don't want to dwell too much on what may be an edge case. A best-effort that we can kick the tires on may be the place to begin.
Thanks for https://github.com/GraphBLAS/binsparse-specification/issues/16, by the way, a great overview of options. I believe Tiled is doing "Logical chunking of sparse arrays" at the API level. Internally, for the one mode of storage we currently support, we are also doing "Logical chunking of storage arrays", but this not a strongly-held design choice, and alternatives could be added without any major changes.

Honestly, 10x performance drop is way better than I was expecting 😆
But also, this case is another order of magnitude faster to write to json, so I strongly think its an edge case.
In [10]: %time df.to_json("test.json")
CPU times: user 1.69 ms, sys: 1.63 ms, total: 3.32 ms
Wall time: 3.53 ms

If we expose them as Zarr groups, will they be so slow it would be better just to omit them?

I think it would be fine to expose them. The way anndata does tables will only be reasonable for columnar access (or pretty large chunks of contiguous rows) once you have larger number of rows.

Thanks for https://github.com/GraphBLAS/binsparse-specification/issues/16, by the way, a great overview of options.

Thanks!

I believe Tiled is doing "Logical chunking of sparse arrays" at the API level.

Am I remembering correctly that you were doing global indices as opposed to chunk local indices + an offset? And was that at storage or API level?

Yeah, that's fair enough, for sure.

At an API level, we support:
/array/full?slice=...  # global indices

or
/array/block?block=0,0,0&slice=...`  # block-local indices

where block is a block index like dask array has.
Storage uses block-local indices within each Parquet file. There is a convenience constructor for building local blocks from a global reference frame.
Did that answer your question? It's been awhile since sparse has been on the "front burner" of my brain.

Reading more through the anndata links, I see how it shows clear patterns for presenting all of the structure families currently supported by Tiled as Zarr. This seems like a great place to start. Thanks for doing all the work. :-D

As we dip our toes into zarr we would love to have an endpoint that could serve zarr directories and files in a similar fashion as a plain old web server could, enforces tiled authN/authZ, while still also exposing those data sets in the tiled ArrayCleint.

Great. I think that is exactly what we intend with this issue.


grub: fetch from HTTPS instead of FTP; update meta

HTTPS is unlikely to be worse and is often better than FTP. Aside from being
faster, there are many networking setups where outgoing FTP traffic is blocked.
sha256 is unchanged; no rebuilds.

Failure on aarch64-linux (full log)
Attempted: grub
Partial log (click to expand)
copying path '/nix/store/982nk0a8fcagwidl4y2d5cj0dcm1xd8d-libtool-2.4.6' from 'https://cache.nixos.org'...
copying path '/nix/store/rynqllcbcbnbls7qsbmf8gfqf5shln6g-stdenv-linux' from 'https://cache.nixos.org'...
copying path '/nix/store/775s79mrfir78c8rzlfvg2ickyf7sfsw-hook' from 'https://cache.nixos.org'...
building '/nix/store/bynl1zzpp3g29ls31gpfnwlavk82s8dq-grub-0.97-73.drv'...
unpacking sources
unpacking source archive /nix/store/51f2q2iqx39csvnib6y435f1g3a4w34w-grub-0.97.tar.gz
source root is grub-0.97
/nix/store/rynqllcbcbnbls7qsbmf8gfqf5shln6g-stdenv-linux/setup: line 916: /nix/store/3krhn1yx15f348mnfrbnklj43kp9813n-coreutils-8.30/bin/chmod: cannot execute binary file: Exec format error
builder for '/nix/store/bynl1zzpp3g29ls31gpfnwlavk82s8dq-grub-0.97-73.drv' failed with exit code 126
error: build of '/nix/store/bynl1zzpp3g29ls31gpfnwlavk82s8dq-grub-0.97-73.drv' failed

Success on x86_64-linux (full log)
Attempted: grub
Partial log (click to expand)
these paths will be fetched (5.99 MiB download, 23.62 MiB unpacked):
  /nix/store/a2lmjk0b8lzm7qgj3mv51ihi8hqa3yrx-glibc-2.27
  /nix/store/fr027v1qi71rh35y3vjr9bink8lhzlvr-grub-0.97-73
copying path '/nix/store/a2lmjk0b8lzm7qgj3mv51ihi8hqa3yrx-glibc-2.27' from 'https://cache.nixos.org'...
copying path '/nix/store/fr027v1qi71rh35y3vjr9bink8lhzlvr-grub-0.97-73' from 'https://cache.nixos.org'...
/nix/store/fr027v1qi71rh35y3vjr9bink8lhzlvr-grub-0.97-73


Refactored the script into functions

I added three more packages that I had to install manually on my Debian:

x11-xserver-utils, compton and python-yaml

I warned users not to run this script with root privileges.
I added the basic configuration for Compton as part of the installation of i3wm-themer.
And also I splitted the script into functions.

I am still unsure whether it uses python or python3, in any cases I made it install things related to python only.

Very nice work sir,
I will have to review it (probably later this week) and do a test run to check if everything works as intended and merge it after. Thanks for the contribution!

I'll have to test it too because I installed your themer on a very lean
installation of Debian, so I assumed most of the packages are not installed
yet. If you find any problems please let me know.
Em qui., 13 de fev. de 2020 às 10:45, Stavros Grigoriou <
<EMAIL_ADDRESS>escreveu:

Very nice work sir,
I will have to review it (probably later this week) and do a test run to
check if everything works as intended and merge it after. Thanks for the
contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/unix121/i3wm-themer/pull/89?email_source=notifications&email_token=AH2YWZT22IBCA6JUGT6OYZTRCVFJJA5CNFSM4KUH2ANKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELVABDQ#issuecomment-585760910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH2YWZRBARNVP4HNVHSIXZDRCVFJJANCNFSM4KUH2ANA
.


matplotlib warning in Docker environment

2021-11-25 05:10:12,028 WARNING [matplotlib:476] Matplotlib created a temporary config/cache directory at /home/runner/.config/matplotlib because the default path (/tmp/matplotlib-oztl_yui) is not a writable directory; it is highly recommended to set the MPLCONFIGDIR environment variable to a writable directory, in particular to speed up the import of Matplotlib and to better support multiprocessing.

Closed in deploy repo by setting MPLCONFIGDIR.


Item selection in ItemsControl is not handled on PreviewMouseLeftButtonUp when multiple selection is enabled

Steps to reproduce

Place a ListBox inside a TabControl and enabled drag & drop for both controls.
Enable multiple selection for the ListBox.
Select multiple items in the ListBox (e.g: press and hold CTRL key and click on the items in ListBox).
Release CTRL key and click on one of the already selected items in the ListBox.

Example
<Window
    x:Class="gong_wpf_dragdrop_multiselect.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:dd="urn:gong-wpf-dragdrop">
    <TabControl dd:DragDrop.IsDragSource="True" dd:DragDrop.IsDropTarget="True">
        <TabItem>
            <ListBox
                dd:DragDrop.DragMouseAnchorPoint="0.5,0.5"
                dd:DragDrop.IsDragSource="True"
                dd:DragDrop.IsDropTarget="True"
                SelectionMode="Extended">
                <ListBoxItem Content="Item 1" />
                <ListBoxItem Content="Item 2" />
                <ListBoxItem Content="Item 3" />
                <ListBoxItem Content="Item 4" />
                <ListBoxItem Content="Item 5" />
            </ListBox>
        </TabItem>
    </TabControl>
</Window>

Expected behavior
"Reset" the selection to the already selected item in the ListBox only (e.g: de-select the other selected items).
Actual behavior
The selection does not change. The already selected items remain in that state until one item that is not selected is clicked or unless the user presses and holds the CTRL key and clicks on each item.
Findings
There exists a specific case in which the drag & drop is handled for ItemsControl elements. This occurs on PreviewMouseLeftButtonDown. However, PreviewMouseLeftButtonUp is not handled correctly.
I believe that the event PreviewMouseLeftButtonUp should be handled by the original element that set PreviewMouseLeftButtonDown's event to Handled = true.
https://github.com/punker76/gong-wpf-dragdrop/blob/bf73cb4bae0debd46fd88ffc19c95b69b195ca75/src/GongSolutions.WPF.DragDrop/DragDrop.cs#L377-L384
Environment
GongSolutions.WPF.DragDrop v2.x.x
Windows 10
Visual Studio 2019
.NET Framework 4.6

@punker76 Am I correct that all that needs to be done is to update line 458 in DragDrop.cs?
Specifically changing this:
https://github.com/punker76/gong-wpf-dragdrop/blob/00410077786bd7209abb16c17f1d885c3a01f603/src/GongSolutions.WPF.DragDrop/DragDrop.cs#L458
To this:
if (dragInfo?.VisualSource is ItemsControl itemsControl && _clickSupressItem != null && _clickSupressItem == dragInfo.SourceItem)

I've tried to fix this issue because I've been working with nested WPF data grids, and found that aside from the correct row not being selected when clicked within an existing selection, but that it would also try to set the SelectedItem of the parent DataGrid to the source item of the RowDetails DataGrid, which would result in System.Windows.Data Error: 23.
In testing the above change, everything seems to work fine, however as I am not fully familiar with the code it's always possible that I've overlooked something important.
If you think this is change is fine then I'll happily submit a pull-request with this change (assuming this project is not dead, as I see that the last commit was in November 2020, and there are pending pull requests dating back years).

As a followup to this, I have some further feedback here that may be of use to others working with nested ItemsControls and drag-drop.
I have recently been working with a DataGrid which has a RowDetailsTemplate containing a DataGrid.  I have custom functionality in place for SelectionChanged events to handle various selection scenarios.
First, I noticed that because the GongSolutions.WPF.DragDrop code prevents default selection handling in DragSource_PreviewMouseLeftButtonDown (as mentioned in their source code comment), when programmatically setting the selection, other selection behaviour for ancestor ItemsControls won't run.
For example, in the following image there are two parent rows, each with a nested DataGrid, the first of which has one selected row, the second of which has two selected rows:

If I click on the row Two-Two, although Two-Three will be deselected, row One in the parent row will not be deselected.
To address this, I have modified the else if condition (https://github.com/punker76/gong-wpf-dragdrop/blob/cd432f23e0f3a2ae5568216b013c8e51d1e2ef50/src/GongSolutions.WPF.DragDrop/DragDrop.cs#L464) to be the following:
else if ((Keyboard.Modifiers & ModifierKeys.Shift) == 0)
{
    itemsControl.SetSelectedItem(dragInfo.SourceItem);

    if (sender != itemsControl && sender is ItemsControl ancestorItemsControl)
    {
        var ancestorItemContainer = ancestorItemsControl.ContainerFromElement(itemsControl);

        if (ancestorItemContainer != null)
        {
            var ancestorItem = ancestorItemsControl.ItemContainerGenerator.ItemFromContainer(ancestorItemContainer);

            if (ancestorItem != null)
            {
                ancestorItemsControl.SetSelectedItem(ancestorItem);
            }
        }
    }
}

This only goes up one level however as I'm only using the sender.  To go up n-levels, it's possible that a solution using VisualTreeExtensions.GetVisualAncestor() may be better.


[SQL Migration] New Help and Support Dialog

In order to have consistency cross the extensions, we are redesigning  the help and support tab similar to other migration extension.
New links added in the dialog -
Documentation  -  https://aka.ms/dms-overview
QnA - https://aka.ms/DMSqna
Support Request - https://portal.azure.com/#blade/Microsoft_Azure_Support/HelpAndSupportBlade/newsupportrequest (Same as before)
Bug Link - https://dev.azure.com/msdata/Database Systems/_workitems/edit/2774419

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.007%) to 41.58%

Files with Coverage Reduction
New Missed Lines
%

extensions/sql-database-projects/src/common/httpClient.ts
1
66.18%

extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts
2
52.03%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
30789

Relevant Lines:
69355

💛  - Coveralls


server: fix the race condition of region heartbeats from different re…

…gions (#2198)
Signed-off-by: youjiali1995<EMAIL_ADDRESS>
What problem does this PR solve?
Cherry-pick #2198

/run-all-tests

/run-all-tests


[MinimalLib] Add number of heavy atoms to descriptors

Hi,
thanks a lot for the new MinimalLib CFFI bindings, this is a really great initiative.
I am experimenting with the bindings to interface with Rust and this is working great so far.
When looking through the available descriptors, I was missing the number of heavy atoms,
Would it be possible to add this property to the list of descriptors?
Many thanks to all who contribute to the awesome RDKit project.
Kind regards,
Axel

So I found out, that the number of heavy atoms can be retrieved from the output of get_json, by counting the number of atoms in the molecule:
e.g., in Rust:
json["molecules"][0]["atoms"].as_array().unwrap().len();
Please let me know if I should close this issue or if it is still worth considering to put it in the descriptors, since e.g. ' NumHeteroatoms' are also part of them.
KR Axel

Hi @apahl : I agree that this should be one of the descriptors that's part of the standard set. Since it's otherwise easy to calculate this from python we've just never added it, but that can be fixed. :-)

This was added in #4200


AlphaFold multiuser error

I am having an issue about the situation that is mentioned below. Could you please help me about it.
2023-08-14 17:58:29,948 Running on GPU
2023-08-14 17:58:29,950 Found 4 citations for tools or databases
2023-08-14 17:58:29,950 Query 1/1: test_914f5_0 (length 1641)
COMPLETE: 100%|██████████| 450/450 [elapsed: 00:02 remaining: 00:00]2023-08-14 17:58:32,213 Could not get MSA/templates for test_914f5_0: invalid literal for int() with base 10: 'DUMMY'
Traceback (most recent call last):
File "/content/colabfold/batch.py", line 1377, in run
= get_msa_and_templates(jobname, query_sequence, a3m_lines, result_dir, msa_mode, use_templates,
File "/content/colabfold/batch.py", line 817, in get_msa_and_templates
a3m_lines = run_mmseqs2(
File "/content/colabfold/colabfold.py", line 303, in run_mmseqs2
M = int(line[1:].rstrip())
ValueError: invalid literal for int() with base 10: 'DUMMY'
2023-08-14 17:58:32,214 Done

Hi, did you find a way to fix it?

Hey, I'm running colabfold locally instead of alphafold2 but I got the exact same error.
2024-04-27 18:43:37,124 Running colabfold 1.5.2 (8c745219964d6bfb878dd6fb53b5a2a05b009391)
2024-04-27 18:43:45,887 Running on GPU
2024-04-27 18:43:47,089 Found 7 citations for tools or databases
2024-04-27 18:43:47,089 Query 1/1: ProteinA__ProteinB (length 1818)
2024-04-27 18:43:47,162 Could not get MSA/templates for ProteinA__ProteinB: invalid literal for int() with base 10: 'DUMMY'
Traceback (most recent call last):
  File "/users/software/miniconda/envs/colabfold/lib/python3.8/site-packages/colabfold/batch.py", line 1370, in run
    = get_msa_and_templates(jobname, query_sequence, result_dir, msa_mode, use_templates,
  File "/users/software/miniconda/envs/colabfold/lib/python3.8/site-packages/colabfold/batch.py", line 761, in get_msa_and_templates
    a3m_lines_mmseqs2, template_paths = run_mmseqs2(
  File "/users/software/miniconda/envs/colabfold/lib/python3.8/site-packages/colabfold/colabfold.py", line 298, in run_mmseqs2
    M = int(line[1:].rstrip())
ValueError: invalid literal for int() with base 10: 'DUMMY'
2024-04-27 18:43:47,169 Done

I managed to solve this error by changing the width of my input fasta file to the canonical 60 amino acids per line.  For sake of compaction in the terminal window I set each line to 110 amio acids but this deviation from the convention gave me this error.
Hope this helps.
Nicco


Support API Key Auth

          > @zhaohuabing can we reuse the same Envoy Filter for API key auth ?

The problem is, unlike HTTP Basic Auth, API key auth is much more flexible, the key can be in the header, path, or even body. I think we will need a dedicated envoy filter in Envoy if we want to support API key auth, we can follow the open API specs: https://swagger.io/docs/specification/authentication/api-keys/#:~:text=API keys are supposed to,mechanisms such as HTTPS%2FSSL.
Originally posted by @zhaohuabing in https://github.com/envoyproxy/gateway/issues/1660#issuecomment-1814974031

blocked on upstream implementation in envoy

@arkodg do you know the upstream implementation envoy tracking?

I think this can be easily implemented by header or query matching right?

cc @zhaohuabing

@arkodg  @zufardhiyaulhaq It should be a simple Envoy Filter. I can pick it up when I get some bandwidth.

/assign

API Key Auth is also often related to a set of APIs that is accessible with that Key. Often stored elsewhere to determine if the resource (API) being accessed is allowed to be accessed with this Key.
What is the main purpose of this feature? To capture API key values for rate limiting only? Or to do AuthZ enforcement?
And how would we differentiate dynamically if an API key is subscribed to a higher rate limit than another API key?

@missBerg it is very essential feature for us stopping the adoption of envoy gateway. The primary idea is to use it as AuthZ. Regarding rate limits - we can support different scenarios. Probably starting from separate rate limit for each API key.

And how would we differentiate dynamically if an API key is subscribed to a higher rate limit than another API key?

It should not be an issue.
When the basic rate limiting would be implemented, complex scenarios could be considered (like common rate limit for API keys from one user).

looks like the upstream feature is in, is this something we can get in for v1.3 @sanposhiho ?

Yeah, how do we deal with the compatibility between gateway and envoy? Can we just introduce any latest features immediately or do we have to wait for envoy to cut a new release?

Okay, I found:
https://gateway.envoyproxy.io/news/releases/matrix/
So, we can just start this implementation now, do I understand right?

yeah @sanposhiho, gateway main is based off proxy main

you'll also need to go getgithub.com/envoyproxy/go-control-plane@<latest>

+1 to this feature/issue. This is an important feature for me. My use case:
I have OpenTelemetry data that I am ingesting from several sources (https://github.com/Sage-Bionetworks-Workflows/eks-stack/blob/ca523c66abc8d9b91e796c838f5d3c24784048cc/modules/signoz/main.tf#L252-L278 & https://github.com/Sage-Bionetworks-Workflows/eks-stack/blob/ca523c66abc8d9b91e796c838f5d3c24784048cc/modules/signoz/resources-otel-ingress/security-policy.yaml#L1-L13). I am currently enforcing that all incoming requests provide a JWT bearer token, however, I am limited with a monthly quota for the number of tokens that can be created per month via Auth0.
If I can swap to using an API key instead then I will be able to on-board more projects without the concern of filling up my monthly quota. This is also combined by the fact that the AWS supported OTEL collectors (For ECS and Lambda functions) have not implemented https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/oauth2clientauthextension


Fix query params

I noticed urls with a query param weren't valid
For example:
https://github.com/remarkjs/remark-validate-links/blob/master/test/fixtures/examples/image.jpg?raw=true
I put together a failing test 👍

Thanks Jonathan! I inverted L3 of the fixture, because the query string must come before the hash!
Much appreciated!


Push drawer on top of navigations header

I'm using React Navigation which provides a header on each page. In the header I have included a hamburger menu to toggle the drawer. The problem is that the drawer does not overlap the header. I have already tried to set the drawer's and/or the sidemenu's style to position:absolute with a high zIndex, but this does not work.
The picture shows the drawer below the header. I want it to go over the header.
Does anyone have a idea? Is this even possible?

Try with:
<Drawer
type="static" or "displace"
>

Unfortunatly, this did not solve the problem

Maybe if you set a negative zIndex for the children of your Drawer . Can you share your render method , where you render your drawer

@Maxeh Do you mind sharing how you enabled the toggling?  I'm working on something very similar but haven't been able to get anything like that working.

@awreese I switched to drawerNavigation of react-navigation.
This comment shows you how to use it in combination with stackNavigator
However, if you just want to toggle how I did it above, you just have to add a hamburger icon as iconLeft, and save a function in navigationParams which you can call from the navigationOptions function.
componentDidMount() {
    this.props.navigation.setParams({
      toggleMenu: this.toggleMenu
    });
}

static navigationOptions = ({ navigation }) => ({
   headerLeft:
      <Button
        transparent style={{marginLeft: 5}}
        onPress={() => navigation.state.params.toggleMenu()}
      >
        <Text style={{color: '#FFF'}}>menu</Text>
      </Button>
});

@Maxeh Thanks, I'll give that a shot later.  I was using a drawer navigator originally, but I didn't really need more navigation, I just needed a slide out menu for app options/settings/etc...  My current setup is to wrap my page in a drawer with a rn material ui header rendered at the top of the page which has a menu button to open/close the drawer.  Perhaps with your solution I can move the header element into the navigation header and render the drawer under it instead of over (which honestly wasn't a huge deal as that seems to be how most android menus work anyway).  I can report back if the change is satisfactory.  Thanks again.

@Maxeh, I have also faced that problem on Android, fixed by adding some elevation in drawer styles
<Drawer
    style={{
        drawer: { elevation: 5 } // or another high value
    }}
>
{...}
</Drawer>

The above worked but with one tiny correction. It should be styles, not style. Plural.

The above worked but with one tiny correction. It should be styles, not style. Plural.

It didn't work for me.


CNDB-10731: Add support for index analyzers to RowFilter

Make RowFilter aware of index analyzers, so : and = CQL operators can operate according to any underlying analyzers even if the index is not selected.
This can happen for example with OR expressions where one expression has an analyzing index and the other doesn't have any index:
CREATE TABLE t (k int PRIMARY KEY, x int, y text);
CREATE CUSTOM INDEX ON t(y) USING 'StorageAttachedIndex' WITH OPTIONS = {'index_analyzer': 'standard'};
INSERT INTO t (k, x, y) VALUES (0, 0, 'a');
SELECT * FROM t WHERE x=1 OR y:'a' ALLOW FILTERING;

In this case, the index won't be used and both restrictions will be filtered. When the RowFilter sees the ANALYZER_MATCHES expression on the y column it fails because the CQL operator cannot work without knowledge of the index.
This PR adds a new Index.getAnalyzer method that the CQL operators can use. That way the ANALYZER_MATCHES operator can work without direct index intervention.
As a bonus, this mechanism can also be used by replica filtering protection to re-apply the row filter in the coordinator when there are conflicting results coming from the replica. So this would supersede the mechanism provided by Index.Searcher#filterReplicaFilteringProtection.
Please note that the general assumption here is that when we create an analyzed index in a column we are redefining how the : and = operators work when querying those columns, regardless of whether the index data structures are used or not.

Good catch. We'll fail back to manual PR approval by verbal agreement :)
I've added a fix for CQLSSTableWriterClientTest, I think we only need it to initialize the Keyspace instance.
I'm also removing a Stream usage in the LWT-with-analyzer warning, since we don't allow them anymore.

The change make sense to me. As it is a test fix and the test passes now, I think it is safe to say this is ready even before CI completes :slightly_smiling_face:


Can this able to drop the image in another view not in the list of draggable flatlist

@computerjazz  I need to drag a box and need to arrange it in a another view. Can we able to do like this using this package.

nope, sorry!


Trying to connect to Influxdb even when such access is disabled in config file

When   Butler-SOS.influxdbConfig.enableInfluxdb is set to false, no connection to an Influxdb database should be attempted.
Right now the code will not write any data to Influx when the config setting is set to false, but an initial conneciton attempt is still made.

Fixed by #48


Integrate plugin with buf cli

Is your feature request related to a problem? Please describe.
Our team is using the buf cli to manage protobuf builds because
managing protoc calls can be clunky.
Describe the solution you'd like
I'd like this plugin integrated with the CodeGeneratorRequest so that a Dockerfile can be implemented that will allow a custom plugin to be implemented.
Additionally, this will facilitate adoption by Buf to make it a hosted plugin, which will likely increase adoption of this plugin.
Describe alternatives you've considered
The alternative is to use the CLI as documented. However, buf generate is a much friendlier interface to using this.
Additional context
https://github.com/bufbuild/plugins/issues/589

Is your feature request related to a problem? Please describe. Our team is using the buf cli to manage protobuf builds because managing protoc calls can be clunky.
Describe the solution you'd like I'd like this plugin integrated with the CodeGeneratorRequest so that a Dockerfile can be implemented that will allow a custom plugin to be implemented.
Additionally, this will facilitate adoption by Buf to make it a hosted plugin, which will likely increase adoption of this plugin.
Describe alternatives you've considered The alternative is to use the CLI as documented. However, buf generate is a much friendlier interface to using this.
Additional context bufbuild/plugins#589

I'm sorry this is my first experience with buf cli and it will take some time to get used to it.
But the concept of buf cli is great and i will implement it sonn.

Currently,some changes that need to be made to make it compatible with the buf cli. Until then, you can use protobuf-to-pydantic via buf-cli with the instructions below.
Let's assume that the project is now structured as follows:
├── proto-demo
│   ├── buf.yaml  # gen by `npx buf mod init`
│   ├── common
│   │   ├── p2p_validate.proto
│   │   └── validate.proto
│   └── demo.proto
├── buf.gen.yaml
├── plugin_config.py
└── pyproject.toml

Among them, p2p_validate.proto and validate.proto cloned from github to proto-demo/common.
The contents of the other documents are as follows:

demo.protosyntax = "proto3";

package demo;

import "common/p2p_validate.proto";
import "common/validate.proto";

message p2p_demo{
  int32 a = 1[(p2p_validate.rules).int32.default=1];
}

message validate_demo{
  string b = 1[(validate.rules).string.max_len=3];
}

plugin_config.pyfrom typing import List

# Ignore files to prevent program errors
ignore_pkg_list: List[str] = ["validate", "p2p_validate"]

buf.gen.yamlversion: v1beta1
plugins:
  - name: protobuf-to-pydantic
    out: proto_out
    opt:
      - paths=source_relative
      - config_path=plugin_config.py

pyproject.toml...

[tool.poetry.dependencies]
python = "^3.8"
protobuf-to-pydantic = "^<IP_ADDRESS>"
grpcio-tools = "^1.59.0"
pydantic = "^2.4.2"
mypy-protobuf = "^3.5.0"
toml = "^0.10.2"

...

All the files are ready, install 'protoc' and 'buf' on the system.
Finally, can execute the 'protobuf-to-pydanitc' plugin  via buf-cli in the terminal.
# Set the current directory to the working directory to load the plugin_config.py
export PYTHONPATH=$PYTHONPATH:.
# Poetry can be used to load information into the current Python environment
poetry run npx buf generate proto-demo

If 'poetry' is not installed, can directly activate the current python environment and execute the command, as follows
# Set the current directory to the working directory to load the plugin_config.py
export PYTHONPATH=$PYTHONPATH:.
# Suppose the path of the current python program is '.venv/bin/python'
source .venv/bin/activate
npx buf generate proto-demo


feat: add relationship with commit files and its components

Summary
This PR is related to issue953.
First, I create a table component and user can input file component relationship by operating this table including component name ,repoid,component regexp
like

Then I changed the primarykey in commit_files table  from (commit_sha,filepath) to id(commit_sha+":"+filepath)
like:

Then, I create a new table to records which component every commit_file_id belongs to.

When user run a pipeline  using gitextractor plugin, lake gets the relationship in components table and match by regexp. Then update the commit_file_component during storing commit_files
Does this close any open issues?
Please mention the issues here.
closed #953
Other Information
Really thanks to Klesh for the guidance TwT！

@xgdyp Please fix the commit message by following https://www.conventionalcommits.org/en/v1.0.0/#summary

@xgdyp Please fix the commit message by following https://www.conventionalcommits.org/en/v1.0.0/#summary

OK, I think it will squash it.

@xgdyp Please fix the commit message by following https://www.conventionalcommits.org/en/v1.0.0/#summary

OK, I think it will squash it.

Yes, we will. But the original commit messages will be kept inside that squashed commit.

I'll fix it later

I fix it, please review it, thanks! @klesh

@xgdyp Nice work. However, there is a conflict that needs to be dealt with.

@xgdyp Nice work. However, there is a conflict that needs to be dealt with.

I'll resolve it now

hi Klesh, please review again@Klesh


WIP | Fixing issue with ignoreSniOpenTimeout in NetCore

While working on #1126  I noticed in NetFx:
SqlInternalConnectionTds at line 1762 and 1766
Boolean disableTnir = ShouldDisableTnir(connectionOptions);
Boolean isParallel = connectionOptions.MultiSubnetFailover || (connectionOptions.TransparentNetworkIPResolution && !disableTnir);

Basically, isParallel is mostly coming true if we do not disable TransparentNetworkIPResolution default value.
further in the code, we attemp  AttemptOneLogin we pass the value for bool ignoreSniOpenTimeout as !isParallel comes to false and in result when we get to TdsParserSafeHandles we ignore the part for timeout = Timeout.Infinite;
However, in Net Core since there is no TransparentNetworkIPResolution we only check for connectionOptions.MultiSubnetFailover  and by sending !connectionOptions.MultiSubnetFailover  we set the timeout to Timeout.Infinite. This will cause the expected exception  not to happen even if the connection timeout is set to some values lower than 15 seconds.
I am looking for tests to add as this needs to stop SqlServices as the repro suggests.
Changes in NetFx are only some simplifications as I was looking into them.

There are some differences between netcore and netfx like this where I don't think the code differences are helpful. In this situation I think the code for netfx was correct and if it were used on netcore where MultiSubnetFailover can never be set it would have given the correct behaviour, is that right do you think? If so is it worth updating the netcore code to be the same as the netfx code?

There are some differences between netcore and netfx like this where I don't think the code differences are helpful.

I agree. Existing of TransparentNetworkIPResolution makes the nature of SqlInternalConnectionTds in netfx different than the one in netcore. Mostly all f its objects are considered as parallel where in netcore it is not the case. there are several cases in netfx in the very same class that it checks for if (isParallel) which in netfx we enter the if statement but in netcore we do not.  In my opinion we do not need that variable, ignoreSniOpenTimeout , at all. In netfx if you look a bit upper that in the code around line 1839 there is a comment which says:

//  for non-failover, non-MSF scenarios to avoid breaking changes as part of a QFE.  Consider fixing timeout
//  handling in next full release and removing ignoreSniOpenTimeout parameter.

I am strongly against making netcore as same as netfx, without deep investigations

Agreed. If it is done it must be carefully and well tested. Having a single shared implementation may be better for maintenance. Something to consider in the future and not this PR.

I think we need to understand MultiSubnetFailover cases with failover cluster setup before confirming this is the right change here. I'm also curious to know why they added "ignoreSniOpenTimeout" at the first place that's being applied by default! I agree TNIR broke the deal in NetFx but "ignoring lower timeout" has always been a problem case also in NetFx whenever it comes to action. So before we change it to reverse, we need to what adverse affects it could have when someone connects with MultiSubnetFailover enabled. It will then cause timeout issues there.


Floating element support in StarML

After having gone through and converted a few mods to the Framework, I think this is valuable to add, at least for the more "detail-oriented" authors.
As opposed to overlays, which are very niche, floating elements are almost always the best tool for titles, sidebars, footers, etc., any "extended" content that shouldn't affect the alignment of the main content view and wants to be independently sized. The alternative is always hacky stuff like negative margins or counter spacers.
I believe this can be achieved with another structural attribute and microsyntax, i.e.
<panel *float="aboveParent; 0, -16" ...>

would create a left-aligned panel whose bottom is 16px above the parent's top, i.e. a header.
Since all layout views support floating elements, this syntax would be valid essentially anywhere, even inside a single-element container like a frame that already has a non-floating child, and any number of floats can be added to any container.
Also, handily, FloatingPosition already has a [DuckType] decoration, so this attribute could support a data binding if necessary.

Implemented, per spec above, except using shortened position names without "parent",, e.g. just above, below, before and after.
Needs documentation before closing. There is no documentation on floating elements at all, except in the reference section, so this needs both markup/spec documentation and behavior documentation (i.e. what is a float).


Every Issue

N < 30
console.log(JSON.stringify(later.parse.recur().every(10).second(), null, 2));

{
  "schedules": [
    {
      "s": [
        0,
        10,
        20,
        30,
        40,
        50
      ]
    }
  ],
  "exceptions": []
}

N > 30
console.log(JSON.stringify(later.parse.recur().every(45).second(), null, 2));

{
  "schedules": [
    {
      "s": [
        0,
        45
      ]
    }
  ],
  "exceptions": []
}

N >= 60
console.log(JSON.stringify(later.parse.recur().every(75).second(), null, 2));

{
  "schedules": [
    {
      "s": [
        0
      ]
    }
  ],
  "exceptions": []
}

e.g. how to set a task run every 90 seconds?

Short answer is that you don't.  Later is a very basic constraint solver where you create a schedule object that defines which times Later should consider valid.  You do this by defining valid values for each of the different constraint types.  Later then searches for a time that meets all of the constraints.
For example, telling Later that seconds [0, 10, 20, 30, 40, 50] are valid means Later will consider any time with those particular seconds valid.  So 9:20:00, 13:29:40, etc.  You can get fancier by adding more constraints like minutes [0, 15].  Now times like 10:00:10 and 4:15:50 would be valid.  In your example, since 90 is not a valid seconds value, it's ignored.
If you just need to run a task every 90 seconds, just use the default interval function instead of Later. Later was meant for scheduling tasks at the human time scale (every 4th friday at 11am type stuff).


[BUG] No more dashboard after update - me-eaf.el probably missing ?

Describe the bug
After upgrading Minemacs, dashboard and theme are not displayed. The buffer showns is "pscratch".
Emacs version
GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-19 Windows version.
The bug exists too in Linux version (fresh install for testing)
Checkup list

[X ] You've tested disabling your config.el using MINEMACS_IGNORE_CONFIG_EL=1 emacs?

To Reproduce
Steps to reproduce the behavior:

Update or Install Minemacs
Waiting launch
See error

Expected behavior
Dashboard and theme are shown correctly.
Backtrace
⛔ Warning (initialization): An error occurred while loading ‘c:/Users/big04/.emacs.d/init.el’:

: [MinEmacs:Error] Cannot load "c:/Users/big04/.emacs.d/modules/me-eaf.el", the file doesn’t exists.

To ensure normal operation, you should investigate and remove the
cause of the error in your initialization file.  Start Emacs with
the ‘--debug-init’ option to view a complete error backtrace.

look file   skel/module.el     me-eaf.el move to  modules/obsolete/me-eaf.el
but the dashboard can not open still


feat(maven): build artifacts to maven

:tada: This PR is included in version 0.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add a benchmark for computing hashCodes.

Computing hash codes is incredibly slow in the current Dart protobuf implementation. We have in-product cases where computing a hash code for a message is nearly as slow as parsing that message from JSON. I'm working on some improvements, so I'm adding a benchmark to track these improvements.

I will update README and add this benchmark to golem.


TypeError: 'map' object is not subscriptable

Can dumpSTR be run using python/3.7.3/.
I'm getting error: 'TypeError: 'map' object is not subscriptable' when I input my vcf file...
Help?
Thanks.

I resolved this by changing the map objects to list (map) in filter.py and utils.py


Add TextChangedT

It is the port of https://github.com/neovim/neovim/pull/20567.
It is useful to create the auto completion plugin for the terminal.

It is the port of https://github.com/neovim/neovim/pull/20567.
It is useful to create the auto completion plugin for the terminal.

Please extend the test with some nasty things that an autocommand can
do:

Have the terminal update while the current buffer is another window.
Does it get the right buffer?
Have the autocmd change to another window.
Have the autocmd close the terminal (should fail, I suppose).

Probably a few more things.  If you look at wheren EVENT_TEXTCHANGEDI is
triggered it uses aucmd_prepbuf() and aucmd_restbuf(), perhaps something
like that is needed?  We can probably assume the terminal is visible in
a window (oh, make sure to not trigger when it isn't).   Maybe b_locked
needs to be set, like it is in parse_osc().
Sorry that this may seem like a lot of comments for a simple change, but
we know that autocommands have created bugs and crashes in the past, we
need to at least try to prevent that when adding a new event.
--
TALL KNIGHT: When you have found the shrubbery, then you must cut down the
mightiest tree in the forest ... with a herring.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Sorry that this may seem like a lot of comments for a simple change, but
we know that autocommands have created bugs and crashes in the past, we
need to at least try to prevent that when adding a new event.

OK.  I will add them.

Does it get the right buffer?

It is the bug.  I have fixed it.
I have added the tests.


Fix cards on landing page

Put .card and .card-body elements into each column so that we get a bordered look.

Current
Proposed

Nice, thank you!


[patch] lexer grammars for parser generators: ANTLR, Ragel

(Original issue 345 created by ananelson on 2008-07-06T15:07:08+00:00)
I have attached a new parsers.py file which contains pygments lexers for ANTLR and Ragel parser generators.
I have tested this on a large number of example files (http://ananelson.com/tmp/). If you would like to add examples for this to your test directory let me know what license you require them to be and I will look for something suitable.
I have not changed the copyright notice on whichever lexer file I copied as a template.
I'm sure there are a few edge cases that will need tweaking, so you might want to put my contact info in this file for people to get in touch with me directly if you decide to add it to pygments.

(Original issue was assigned to thatch)
(Original issue 345 last updated on 2009-02-22T21:04:32+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by thatch on 2009-02-22T21:04:32+00:00)
Since the patches have landed, let's call this fixed.

(Original comment by ananelson on 2009-01-03T21:18:16+00:00)
This is great, thanks. :-)
ANTLR has an explicit language statement which is mandatory. Grammars are Java by default, any other language must be stated explicitly, e.g. "language=Python;" (there can be whitespace in there)
Here are the statements for the available languages I found on the ANTLR website's documentation:
language=Python;
language=Ruby;
language=ActionScript;
language=JavaScript;
language=CSharp2;
language = Perl5;
language = C;
http://www.antlr.org/wiki/display/ANTLR3/ANTLR+v3+documentation
As with Ragel, this will only be reliable if you happen to be parsing a full file since a fragment might not contain this.

(Original comment by thatch on 2009-01-03T19:37:46+00:00)
This is mostly merged in [http://code.timhatch.com/hg/pygments-tim my branch] now.  I found two locations of roundtrip errors, which are now fixed.  The example file for Ragel is now explicitly using the ragel-cpp lexer (the examplefiles test can use <lexer>_<filename> to work around things like this).
When this ticket was opened, analyse_text was only used when pygmentize -g was specified.  Since #355, it is now used whenever there are multiple lexers for the same extension as well.
Ana, can you see any good way to infer the file type for the source inside Antlr files?  Anything else you would like addressed?

(Original comment by thatch on 2008-12-31T03:16:48+00:00)
Georg, will you have time to look at the roundtrip issue for incorporation for 1.1?

(Original comment by ananelson on 2008-08-24T13:46:50+00:00)
Okay, one example each for ANTLR and Ragel have been uploaded. Authors of both are happy for them to be distributed under BSD with the rest of Pygments.
Although the Ragel example works for me when I invoke it directly with:
pygmentize -l ragel-cpp tests/examplefiles/rlscan.rl
it's not cooperating too well with "make test".
I know that the last few lines of code, 281-289, cause a problem with the C++ parser. I left them in, just in case the C++ maintainer wants to take a look at them. I'm happy for these lines to be deleted, though, since I don't think the syntax in question is that common or likely to be syntax highlighted.
I have deleted L281-289 in my tests/examplefiles/rlscan.rl
When I ran "make test" after adding this file, I got an error saying that an error token had been generated. I eventually guessed this was due to the wrong lexer being used, so I changed L46 of test_examples.py to help troubleshoot:
self.failIf(type == Error, 'lexer '+lx.class.name+' generated error token for '+absfn)
This confirmed that Pygments was trying to use the RagelJavaLexer instead of the RagelCppLexer. I worked around this by making the RagelCppLexer last in the list of lexers, that seems to be the one that Pygments chooses when there are multiple lexers which handle a given filename extension.
This fixed the error token, but now I am getting a round trip error. (sigh) I'm not sure why. I will take a look when I get time.
I was a bit confused in development as to whether analyse_text() is automatically invoked in the situation when you have multiple lexers claiming to handle, e.g. .rl files, as in this case. There is an informal ragel convention to put something like @lang = c++ in a comment at the top of your file, and I could have analyse_text look for something like this and use that lexer if it finds it. Otherwise I think it's fine to have to specify the -l option. But, is analyse_text used in this situation?
I will try to figure out what's happening with the round trip error. It might be a few days before I get a chance though.

(Original comment by ananelson on 2008-08-16T15:24:01+00:00)
I have made the suggested changes to parsers.py and formatted it so now "make check" doesn't report any errors.
I am working on obtaining suitably licensed examples for testing.

(Original comment by ananelson on 2008-08-16T15:02:23+00:00)
Re item no. 4, I intermittently get the lexer roundtrip error, but other times the tests run perfectly. I find that a "make mapfiles" does something which seems to fix the error.
I tried removing AntlrActionScriptLexer and then I started getting the roundtrip error on the previous lexer in the file, AntlrJavaLexer, so whatever the issue might be I don't think it's related to that particular lexer.

(Original comment by ananelson on 2008-08-14T21:05:09+00:00)
My apologies for not replying sooner! I wasn't subscribed to the feed or email notifications. I have done so now.

Yes, absolutely right. Not sure how this worked without the comma.
How many example files do you want to include? I suggest just 1 each for ANTLR + Ragel.
I will take a look at this and see if I can find anything. We can delete this lexer combo in the mean time if the problem can't be identified.
I started to do this at one point. Can you suggest an easy way to test analyse_text?

I will post updated file and examples for testing shortly.

(Original comment by thatch on 2008-07-26T15:41:05+00:00)
Line 388 also needs to be changed from * to + otherwise it can have an infinite loop on malformed input (x[ for example).

(Original comment by thatch on 2008-07-24T07:58:00+00:00)
Reset type.

(Original comment by thatch on 2008-07-24T07:56:43+00:00)
Hi Ana,
Looks great.  I'm working on integrating this into the Pygments codebase this week.  Here are my thoughts having spent about an hour looking at the code:

line 149 of the parsers.py doesn't have a comma, but seems it should.  Can you confirm?
Yes, contact info would be helpful for the copyright line and AUTHORS file.
Yes, we'll need example files for the automated tests to run on.  The rest of Pygments is BSD-licensed.
I haven't tracked the issue down yet (might be the other lexer) but the !AntlrActionScriptLexer doesn't roundtrip properly and is failing the automated tests.
Be thinking of how analyse_text can be implemented to quickly detect whether it's a match for your lexers (at least the lexers likely to be used in the wild)

Could you go ahead and reformat the file to fit the coding conventions enforced by the 'make check' target (basically max line length around 80 chars, and it's Cpp instead of CPP)?


Minor edits to tests & minor addition to schedule

As above, doesn't do much but I'm gonna abandon the add tests for now so might be a good idea to merge these in first.
Ready for review
@leeyimin, @inaba1231 , @jia1
//Edit:
also sneaks in a small bugfix in the last commit. Read commit msg for more info.

Oops.. give me a min, there's smth I'd like to fix. Forgot about it.

Changes Unknown when pulling 9ad439eab7c68dd1f9f1a0cbb1af70e1a7beec8f on fix/minor_edits_to_tests into ** on master**.

omg i think i screwed up stuff when rebasing
I'll fix that.. lol

Changes Unknown when pulling a4b09614ee719ceddd53856a5303d34d182c705c on fix/minor_edits_to_tests into ** on master**.

Changes Unknown when pulling a4b09614ee719ceddd53856a5303d34d182c705c on fix/minor_edits_to_tests into ** on master**.


ipt installation problems

I got this error when trying to open the IPT in Tomat. Did not give me  any other problems, it was deployed correctly.

Thanks. I'm working on an update of the IPT, so I will ask you to test.
The very latest test versions are in http://repository.gbif.org/content/repositories/gbif/org/gbif/ipt/ , but I think they will give the same problem.

From https://issues.apache.org/jira/browse/WW-4869 the issue is Struts and Java 9.

Thanks for your help. The problem seems like was in java but since no don't know java coding I install everything and re installed everything including java.
Not sure was was but it worked

To make this easier to search, I'm copying the error into a message:
.nio.file.InvalidPathException: Illegal char <:> at index 3: jar:file:\C:\myWebProject\tomcat\webapps\ipt1\WEB-INF\lib\struts2-core-2.3.34.jar


Crash on startup due to voice commands features

G'day, my friend is currently having an issue with the mod crashing. It suddenly happened after we had been playing a small modpack I had assembled for us to play. just one night it just eventually had enough and started giving us this crash report constantly:
crash-2019-06-08_23.19.31-client.txt
She says it happens during phase 7 of the game loading process. do you know what it's related to and anything we can attempt to get rid of this crash? so far all we can do is take the mod out but that spaghettifies the controls and stuff.

I'm sorry for never answering. I don't know why, but GitHub never notfied me about this issue.
Since this issue is 2 years old I will simply close this issue for now. In case this is still relevant please let me know.

well, being as old as it was, we of course moved onto other things, can't remember what happened to the bug or what we did about it. so I guess not relevant anymore.


Submit to CRAN

At some point in the future, not now, now is not the time.

Before you can submit to CRAN you will have to request them to add the prerequisites on their Debian servers, otherwise you can't pass the incoming checks.
I think the best way is to send an email to<EMAIL_ADDRESS>requesting to add the libgrpc++-dev and protobuf-compiler-grpc packages to their server. The other deps are already there, see this list.

Sent

I suspect the we'll need to fix this as well: https://github.com/meztez/bigrquerystorage/actions/runs/7168946042/job/19518216883#step:8:125
Files which contain pragma(s) suppressing diagnostics:
  'src/google/api/annotations.pb.h' 'src/google/api/client.pb.h'
  'src/google/api/field_behavior.pb.h' 'src/google/api/http.pb.h'
  'src/google/api/launch_stage.pb.h' 'src/google/api/resource.pb.h'
  'src/google/cloud/bigquery/storage/v1/arrow.pb.h'
  'src/google/cloud/bigquery/storage/v1/avro.pb.h'
  'src/google/cloud/bigquery/storage/v1/protobuf.pb.h'
  'src/google/cloud/bigquery/storage/v1/storage.pb.h'
  'src/google/cloud/bigquery/storage/v1/stream.pb.h'
  'src/google/cloud/bigquery/storage/v1/table.pb.h'
  'src/google/rpc/status.pb.h'

E.g. by porting the fix from the old configure.R before Jeroen's PR.

I didn't see these warnings on winbuilder so they may not be checked on Windows: https://win-builder.r-project.org/0GJ2L4z4Zm9u/

CRAN has added libgrpc++-dev and protobuf-compiler-grpc: https://github.com/r-devel/rcheckserver/commit/380349aa02c76a0c3565aaf4f696e74413eeabea
I think your package is ready to be submitted.
Note that it may still take a while, the first submission will be scheduled for manual review by a cran assistent which takes a while and sometimes requires a few rounds of resubmitting to some requests.

@jeroen @gaborcsardi
Got this answer from CRAN. I'll look into it after the holidays.

Prof Brian Ripley<EMAIL_ADDRESS>06 h 10 (il y a 2 heures)
à Bruno, CRAN, Tomas
This downloads pre-compiled software on macOS, contrary to the CRAN
policy (and Dr Ligges confirms permission was not given).
The README says
'Windows
The package will automatically download a static build of the system
requirements during installation.'
although that is not clear from the check log.  That too would be a
policy violation.
The package has been removed from CRAN.

Ugh, I guess you have to ask them for permission to download libs (grpc is not available on their mac/win servers)

@jeroen Oh, well I guess I'll ask for permission then. Thanks for the input, it gives me confidence to follow up with CRAN. I don't know if I would have taken that step by myself.

Well it is not certain they will agree. Uwe Ligges is usually helpful and but Brian Ripley can be very unreasonable. So the best path is probably to ask Uwe and explain him the grpc library is available on their Mac or Windows servers.

the grpc library is available on their Mac or Windows servers.

not available, you mean?
Btw. I just opened https://bugs.r-project.org/show_bug.cgi?id=18641

Yes sorry typo 🤦
By the way, in the mean while users can install binary packages from: https://meztez.r-universe.dev/bigrquerystorage

I sent this:

Hi Dr Ligges,
In your opinion, what would be the best way forward to respect CRAN policy and get the package published?
Happy holidays to you and the people in your life.
Bruno
Context :
Some members of the R community have communicated to me their wish to see package bigrquerystorage (https://github.com/meztez/bigrquerystorage) published to CRAN. Github users -jeroen, -gaborcsardi and -hadley have helped
me with compatibility on all platforms. (https://github.com/r-dbi/bigrquery/pull/425, https://github.com/r-dbi/bigrquery/issues/381)
It is a companion package to bigrquery that uses the BigQuery Storage API based on their gRPC protocol instead of their regular REST API. It provides better performance for larger datasets.
Unfortunately, it has a dependency (gRPC) that is not yet available on Windows and Mac CRAN servers, as Jeroen tells me. To remedy that, I understand the configure script was modified to install precompiled binaries for Mac and Windows. I was advised to ask for explicit permission after receiving Dr Ripley's communication.
On Mac https://github.com/meztez/bigrquerystorage/blob/b377ea879efb33b8a33a3e276667a40ae207e81d/configure#L45):
On Windows https://github.com/meztez/bigrquerystorage/blob/main/tools/winlibs.R
  url <- if(grepl("aarch", R.version$platform)){
    "https://github.com/r-windows/bundles/releases/download/grpc-1.51.1/grpc-1.51.1-clang-aarch64.tar.xz"
  } else if(grepl("clang", Sys.getenv('R_COMPILED_BY'))){
    "https://github.com/r-windows/bundles/releases/download/grpc-1.51.1/grpc-1.51.1-clang-x86_64.tar.xz"
  } else if(getRversion() >= "4.3") {
    "https://github.com/r-windows/bundles/releases/download/grpc-1.51.1/grpc-1.51.1-ucrt-x86_64.tar.xz"
  } else {
    "https://github.com/rwinlib/grpc/archive/refs/tags/1.33.2-2.tar.gz"
  }
  download.file(url, basename(url), quiet = TRUE)

@meztez https://bugs.r-project.org/show_bug.cgi?id=18641 has been fixed and Rtools43 has grpc now. So we could try to give this another go, if you can gather the strength for another submission.
We would need to update the build process on Windows slightly, and then re-submit. I can submit a PR for the changes.
Also, if you don't have strength to do it, I completely understand. In this case I can do the first submission, and then once it is safely on CRAN, pass the package to you in the next submission.

Note that arrow may be removed from CRAN soon (apache/arrow#39806).
Perhaps you would prefer to make your submission after the arrow issue is resolved.......
It might also be an interesting improvement to remove arrow from the required dependencies and replace it with nanoarrow.

@eitsupi

Note that arrow may be removed from CRAN soon (apache/arrow#39806). Perhaps you would prefer to make your submission after the arrow issue is resolved.......
It might also be an interesting improvement to remove arrow from the required dependencies and replace it with nanoarrow.

The arrow dependencies that would have to be replaced are:
https://github.com/meztez/bigrquerystorage/blob/d2f5c0dd8067560a9e80dd110cc9af2d0b5aec16/R/bqs_download.R#L112,
https://github.com/meztez/bigrquerystorage/blob/d2f5c0dd8067560a9e80dd110cc9af2d0b5aec16/R/bqs_download.R#L123,
https://github.com/meztez/bigrquerystorage/blob/d2f5c0dd8067560a9e80dd110cc9af2d0b5aec16/R/bqs_download.R#L116
I've taken a look at nanoarrow and could not find drop in replacement at first glance. Would you have further suggestion on how this could be done?
What would be the benefits of using nanoarrow in this instance?
Thank you

What would be the benefits of using nanoarrow in this instance?

The biggest advantage is that there is no need to have the huge and time-consuming to build arrow package as a dependency. The R ADBC-related packages and the Arrow-related methods of the DBI package are all based on nanoarrow.
https://arrow.apache.org/adbc/current/r/index.html
https://dbi.r-dbi.org/articles/DBI-arrow.html

I've taken a look at nanoarrow and could not find drop in replacement at first glance. Would you have further suggestion on how this could be done?

The correspondence between the objects of the arrow package and those of the nanoarrow package may be understood from this file.
https://github.com/apache/arrow-nanoarrow/blob/a41fb2be59f44b6bd6bf5a014aef253041fdc10f/r/R/pkg-arrow.R
Since the Table equivalent object exists only in Apache Arrow's C++ implementation, I believe nanoarrow uses the struct type nanoarrow_array_stream to exchange data in Table format.

@eitsupi I've tried to work out how to use a two elements raws list (schema, data) and turn into a data.frame using nanoarrow. I cannot figure it out at the moment, I'm sorry.
> dt <- as_nanoarrow_array(raws[[2]], schema = infer_nanoarrow_schema(raws[[1]])) |> as.data.frame()
Error in as.data.frame.nanoarrow_array(as_nanoarrow_array(raws[[2]], schema = infer_nanoarrow_schema(raws[[1]]))) :
  Can't convert array with type uint8 to data.frame()
>

@paleolimbot may be able to help here

@paleolimbot What exactly do you mean by "IPC reader"? Does that basically mean reading the data from a socket?
Maybe we could do something simple, like writing all the data out to disk, and then reading it from there?

Could we push directly to an nanoarrow object instead of doing this C++ vector push to R raws to arrow table?
I'm thinking pushing directly into a nanoarrow object could save some time?
But if we need arrow anyway to convert back into an R data.frame. I'm not sure it is best way forward.

Until arrow is back on CRAN, I think we will have to hold.
https://win-builder.r-project.org/incoming_pretest/bigrquerystorage_1.0.0_20240217_202902/Debian/00check.log
https://github.com/apache/arrow/issues/39806

In the meanwhile, it seems like arrow is back on CRAN [1], so we can also submit the current version, and then later switch to nanoarrow.
[1] https://fosstodon.org/deck/<EMAIL_ADDRESS>

In the meanwhile, it seems like arrow is back on CRAN [1], so we can also submit the current version, and then later switch to nanoarrow.
[1] https://fosstodon.org/deck/<EMAIL_ADDRESS>
Let's hope third time is the charm.

Thanks,
on its way to CRAN.
Best,
Benjamin Altmann


[Deprecation] SVGPathElement.getPathSegAtLength

In Chrome 60.0.3112.90, there is a deprecation warning:

matter.js:7433 [Deprecation] SVGPathElement.getPathSegAtLength is deprecated and will be removed in M62, around October 2017. See https://www.chromestatus.com/features/5638783282184192 for more details.

Chrome 62 deprecated this API, but using the latest version pathseg can solve this problem

Thanks for the report, please refer to #196 for this issue which I will reopen.


add comment to warn interested windows users

In my opinion toga should be more open about the state of the implementation.
Hidden explanations in issues do not help to get more native Windows users on board.
That might sound a bit harsh, but it was my experience. Strange logo, no demo  - only a fun project of some kids.
I now know that this not the case. But it will really need some help and convincing. Please...

PR Checklist:

[ ] All new features have been tested
[ ] All new features have been documented
[ ] I have read the CONTRIBUTING.md file
[ ] I will abide by the code of conduct

@freakboy3742 is it only the tone - then thre surely is a good reprase by a native speaker. But I get the impression, that you do not like this at all. I will close the pull request.
@danyewa thanks for the invitation as I understand it support would mean win32 or .net which is not my line of interest.


Remove notifications fix

Hi,
I've added a couple of features.
First of all I made that when you remove a notification it actually disappears from the dom, it gets delete from the notifications array. This is needed because if an app is running for hours then you could have thousands notifications in background, in your DOM, which is not good.
The second thing I've added is a way to click the notification, or disable the clicking, since I noticed that the list was not disabled so it seemed you could click it.
Instead of that I did that if you pass an onClick it will be clicked and once you click the notification will also disappear while if you don't pass an onClick the list will be disabled so it won't look like you can click on it.

@DevAlien wow 😆 that was fast I'll review these changes and make a release with them

on an initial read seems fine will test and get back to you on this 🥂

@puranjayjain is this released on npm?

its not released yet.


Dev use citation

Background:
If the plugin developer has defined a CITATION.cff file, this file has author information present, which we should source for author information, favoring it over information gathered from pypi. However, if the authors also have a config.yml file, we should prioritize that information instead.
Changes:
I added the ability in github.py to use citation author information defined a CITATION.cff file to override data from pypi if it exists
Testing Approach:
I added unittests for the get_github_metadata method. These tests used a new style of mocking to allow me to  test different combinations of presence and absence of the CITATION.cff and config.yml. The tests were run locally and remotely. I also pushed my changes to a remote development branch and was checked to make sure that the search results for people in the OME team (who have a CITATIONS.cff file) no longer appeared and were replaced by the individual team members.
A picture of what the plugin now looks like in hapari-hub is attached

@potating-potato the CITATION.cff format is more granular than other formats and actually has explicit fields for given name and surname. The logic here is great, IMHO: it is consistent w/ the de facto community standard for PyPI and results in author names formated consistently regardless of where they are sourced.


Connections more than maximumPoolSize created

Environment
HikariCP version: 2.4.11
JDK version     : openjdk version "1.8.0_121"
Database        : Oracle
Driver version  : 11.2

We have the following properties configured for HikariCP
spring.datasource.hikari.maximumPoolSize 5
spring.datasource.hikari.minimumIdle 4

But we see that there are more than 5 i.e around 12 connections established to the DB.
We are running RHEL 7 which uses chrony to sync with NTP time
Reference ID    : <IP_ADDRESS> (<IP_ADDRESS>)
Stratum         : 2
Ref time (UTC)  : Mon Apr 17 06:09:18 2017
System time     : 0.000036245 seconds slow of NTP time
Last offset     : -0.000049425 seconds
RMS offset      : 0.001551040 seconds
Frequency       : 9.721 ppm slow
Residual freq   : -0.003 ppm
Skew            : 0.705 ppm
Root delay      : 0.006208 seconds
Root dispersion : 0.005149 seconds
Update interval : 778.9 seconds
Leap status     : Normal

But the same application with the same configuration on RHEL 6 works fine i.e it doesn't create more than 5 connections.
One of the log messages seen:
WARN 8852 --- [HikariPool-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Thread starvation or clock leap detected (housekeeper delta=15m59s115ms143?s997ns).
Also gets hung at: HikariPool-1 - Close initiated... when we stop the spring boot service

@sanaulla123 It is hard to tell exactly what is happening, but I can take a guess.  For some reason, Connection.close() is taking an inordinate (unexpectedly) long time.
The housekeeper thread closes idle connections.  It generally uses an executor to close Connections asynchronously, but the size of the executor queue is equal to the maximumPoolSize.  This means that after that queue fills up, the executor will run new requests on the caller thread -- in this case the housekeeper.
The clock leap reported by the housekeeper indicates that 5 close requests were already in the queue, and so the housekeeper thread itself was used -- and it took +15 minutes to close that single connection.
The hang at shutdown also indicates that close is taking an excessively long time.
Why is it taking so long?  I have no idea.  You might try enabling debug logging to see if it reveals anything, but honestly I don't expect it will.  I'm not sure how to troubleshoot the issue other than something like tcpdump/wireshark.

I guess the hang during the shutdown is related to the number of SQL connections established by CP. As I mentioned in my original issue - the number of connections created are crossing the maximumPoolSize. So due to this few other connections are being closed in the housekeeper thread.
The last two paragraphs of the issue were just for providing more information. My original issue is: "But we see that there are more than 5 i.e around 12 connections established to the DB."
And I have seen the same library running in the same app on RHEL 6 using JDK 7 has so far created only 4 connections which is our minimumIdle. But the same application on RHEL 7 using JDK 8 created around 13 connections.

@sanaulla123 As soon as a Connection is enters into the close connection phase, it is removed from the pool immediately -- but still has an active connection to the DB until Connection.close() completes.  So, if Connections are taking minutes to close, you could have (in theory):

5 connections in the close queue (but not yet closed)
5 live connections in the pool (immediately replacing those in the close queue)
1 connection still alive but being closed by the housekeeper
... and in theory up to 5 more being close by user threads if evictions are occurring due to 08xxx SQLState exceptions.

As of today, I am having the problem that I get more open connections than the allowed maximum. My PostgreSQL Database has got by default 100 connections available and Hikari's maximumPoolSize=10. Soon I run out of DB-connections. My statistics show that the limit of 100 connections was reached and I get the following exception:
[error] Caused by: com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: FATAL: tut mir leid, schon zu viele Verbindungen
[error]   Ort: Datei: proc.c, Routine: InitProcess, Zeile: 340.
[error]   Server SQLState: 53300
[error]     at com.zaxxer.hikari.pool.HikariPool.checkFailFast(HikariPool.java:512)
[error]     at com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:105)
[error]     at com.zaxxer.hikari.HikariDataSource.<init>(HikariDataSource.java:71)
[error]     at play.api.db.HikariCPConnectionPool$$anonfun$1.apply(HikariCPModule.scala:58)
[error]     at play.api.db.HikariCPConnectionPool$$anonfun$1.apply(HikariCPModule.scala:54)
[error]     at scala.util.Try$.apply(Try.scala:192)
[error]     at play.api.db.HikariCPConnectionPool.create(HikariCPModule.scala:54)
[error]     ... 83 more

I think this might be related. I am pretty sure, I release all connections when I finish using them. They are being handled by the Play Framework.

@eluchsinger It looks like the pool is being recreated and destroyed frequently.  I feel like I've seen this somewhere before with Play.  I recommend enabling debug logging.  You might also try asking on stackoverflow.


Individual aggregation tests

Adds individual command tests, for cross-plaform aggregator testing. These are taken from the evaluation scripts.

These tests might take a lot of time to run, we need to check before adding them to the CI workflow.

You are correct, there are total 199 tests (20.sh seems to be missing).
test-123 seems to take a lot of time to complete:
cat $PASH_TOP/evaluation/tests/input/10M.txt |  xargs -n 2 > out

whereas the rest of the suite needs 1m11.373s in total

There are already some unit tests in /runtime/agg/cpp/tests which are ran from run_tests.sh. A quick search seems to show though, that currently run_tests.sh isn't executed from anywhere anymore. Does it make it obsolete? How do the old unit tests relate to the new tests introduced in this PR?

The CI checks are expected to fail since they are running on the old configuration

@nvasilakis Should we also remove the all.sh file since we already have the testing infrastructure available?

@nvasilakis Should we also remove the all.sh file since we already have the testing infrastructure available?

@dkarnikis Sure, this works! I just want to be able to run aggregator tests separately—say, when developing on other platforms such as BSD or MacOS. Is this possible with the current testing infrastructure available?

@nvasilakis Should we also remove the all.sh file since we already have the testing infrastructure available?

@dkarnikis Sure, this works! I just want to be able to run aggregator tests separately—say, when developing on other platforms such as BSD or MacOS. Is this possible with the current testing infrastructure available?

Yes it is! Just export PASH_TOP and then ./run.sh should do the trick!


Ignore unsupported datatypes by default

Missing functionality
If a dataframe passed to pandas_profiling.ProfileReport includes a column with an unsupported datatype, an error occurs, e.g :
AttributeError: 'GeometryArray' object has no attribute 'value_counts'
Proposed feature
Avoid crashing with an error in that scenario. Instead write the error as a message in the profile report.
Alternatives considered
I've coded around this using drop (example below), but in some scenarios this would be guesswork.
pandas_profiling.ProfileReport(input_gdf.drop('geometry',axis=1))
Additional context
GeoPandas is a popular package for handling spatial data. It's GeoDataFrames are built on pandas dataframes, but always include a geometry column which will bump into this issue.

Hi Mike. This is exactly the kind of problem that motivated the creation type-system-software visions.
@ieaves, might be relevant for #505.

I can probably include the proposed fix in #505.
The transition to visions will be rolling out in stages @Mike-Honey but we've already got custom geometry types prepared for geopandas users to begin leveraging.

I have this issue too. Can this be re-opened?


[Core] put population TX_INIT transaction to cache

in order to prevent subsequent cache miss/MapStore.load() for missed initiating transaction

done it in better way: bypass visibilitry check for TX_INIT transaction


Difficult NixOS installation if you want to customize btrfs subvolumes

Describe the bug
I recently installed NixOS using the graphical installer and it worked pretty well.
Now I'm trying to install on another machine where I want a slightly more customized disk layout, which is similar to https://wiki.nixos.org/wiki/Btrfs#Configuration
The graphical installer has no notion of btrfs subvolumes, and thus it becomes very complex to configure.
Expected behavior
Some graphical way to configure btrfs subvolumes during nixos install.
Additional context
As a comparison, the Fedora installer makes this much easier. It is based on Blivet-GUI, not on Parted. FWIW there's no Blivet GUI package on NixOS.

Add a :+1: reaction to issues you find important.

Ah! Do you have permissions to transfer this issue there?


Support @Null and @Ignore for objects (and Primitives)

@Null causes the field to be filled with null
@Ignored keeps the field from being overwritten

done


Store ClusterShell using a ManagedAtomicLazyReference

This is the continuation of what was done in #857 (see also #855) : ManagedAtomicLazyReference is used to protect the _cluster: ClusterShell property as well against memory level race conditions.

Excellent, thank you :-)

I think we're done with https://github.com/apple/swift-distributed-actors/issues/855 for now even 🤔
resolves https://github.com/apple/swift-distributed-actors/issues/855


Tutorial improvements.

Various suggested improvements to the tutorial for clarity.

"#  variables t1, t2 and t3 are examples of tasks created by instantiating operators"
Also we should keep the file airflow/example_dags/tutorial.py in sync with this rst file

Thanks. :) The term constructor threw me for a loop, any ideas for being more explicit about that?

Apart from the confusion around constructor everything looks much better than it did before, thanks for taking the time.
nit: this whole PR probably should be a single commit (or 2 since there's comment history), note that you can --amend between pushes

Glad you think so! I'd really like to use AirFlow in production --- it fulfills an immediate need, so I'd like to contribute where I can. 10-4 on the verbose commits. I'll be sure to squash them before I submit next time.

![img] (http://media.giphy.com/media/IB9foBA4PVkKA/giphy.gif)


Shorten precomputed_sine_table

let table: Vec<f32> = (0..TABLE_LENGTH_USIZE)
    .map(|x| ((x as f32) * 2.0 * PI * (1. / (TABLE_LENGTH_F32))).sin())
    .collect();

This computes the full sine wave from t=0 to t=2PI.
We can use the symmetries of the sine wave to store only the part of t=0 to t=PI/2 and derive the other ranges from it:
https://www.electronics-notes.com/images/waveform-sine-wave-02.png
This will reduce the general memory usage so we can utilize the caches for other things which may improve the libs performance

Good point, so I put some effort in a branchless version: https://godbolt.org/z/9Yhs6hPoh
I'm no assembly hero, but I think we can see it is branchless because there are no labels and jump instructions present.


Generalize Haskell lemmas in tests/specs/lemmas.k and tests/specs/benchmarks/verification.k

I plan to have this PR ready for review as early as I can tomorrow


Use proper millisecond format for iso timestamp

Description
The approved on timestamp of a payment request returned invalid date for some timestamps.  Upon further inspection locally and on staging it seemed to be an error in the millisecond format that was getting parsed.
Reviewer Notes
Test has been updated with the millisecond precision
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make db_dev_e2e_populate
make server_run
make office_client_run

Login in to the office app as a TIO
Approve the service items for the pending payment requests and authorize payment
Return to the payment request after its status changes to review
The approved on message should give the current date string and not 'Invalid Date'

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Fails

:no_entry_sign:
Yarn Audit Issues Found:
high - Remote Code Execution
Package serialize-javascript
Patched in >=3.1.0
Dependency of react-scripts
Path react-scripts > terser-webpack-plugin > serialize-javascript
More info https://npmjs.com/advisories/1548
1 high vulnerabilities and 0 critical vulnerabilities found

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 2c42ca1a40eb35f2bedc273cd0a7e3c4f5bf38af


installer incorrectly supports C: drive as an external drive

Environment
Windows build number: Microsoft Windows [Version 10.0.18362.900]
PowerToys version: https://github.com/microsoft/PowerToys/releases/tag/v0.19.0
PowerToy module for which you are reporting the bug (if applicable): installer

Steps to reproduce
run the installer with the default settings
Expected behavior
the power-toys installer installs power toys to the correct location
Actual behavior
the installer reports the local c: drive as not a local drive.
Screenshots

@enricogior anyone on your team able to look at this?

@Jake-Barwell
can you please run the following command from a command prompt?
msiexec /i PowerToysSetup-0.19.0-x64.msi /l*v "install.log"

i will do when i next access that PC on Wednesday.

install.txt
here is the log file from the command above, renamed to suit github's upload filter

@Jake-Barwell
thanks for the log file, unfortunately I don't see any useful error.
Can you try to uninstall PowerToys from Windows 10 Settings -> Apps -> Apps & features
and then try to install it again.
Thanks.

The app doesn't show up in control panel, and I don't have a folder in C:\program files\ where the installer says it will install powertoys.

@crutkas
I don't see how we can fix this in 0.20 given there is no indication there is anything wrong with our MSI, it seems like a Windows bug. Do you want to escalate it to the Windows team?

Actually looks like this is #1970 as well.  Lets combine and do there

@Jake-Barwell could your user account be locked down for some reason?

I don't think so, I'm the only one using the laptop and my account is the administrator.


fix router_test.go to handle Content-Type in header

https://github.com/golang/go/commit/fd29d03f70238abf460f56209a2ccc76dec6509e sets the Content-Type header in redirects, which breaks this test.

Thanks a lot!


[MWPW-121159] Gnav Search dropdown positioning

Description
This PR ensures proper alignment between the search input and the results dropdown. Both from a positioning perspective and a border continuity one - if the input is not populated, all of its corners will be rounded. If it is populated, then the results dropdown will be shown and thus the input's bottom corners will not be rounded anymore, to ensure continuity. Additionally, the bottom borders of the search results dropdown element have been updated to match those of the input.
Screenshots

Before
After

JIRA issue
MWPW-121159
Test URLs

Before: https://main--milo--adobecom.hlx.page/drafts/ramuntea/hello-milo?martech=off
After: https://121159-search-dropdown-positioning--milo--overmyheadandbody.hlx.page/drafts/ramuntea/hello-milo?martech=off

@overmyheadandbody why do not merge?

I question the amount of comments added. Isn't it preferable for the code to speak for itself? Perhaps some variables could be renamed to improve clarity

We're trying to figure out a process of how these changes could go through QA before merging. I don't think we're at a point where we can just count on automated tests to ensure nothing breaks. If you feel like this isn't the right approach, we're definitely open to some suggestions

Thanks for this. I guess our process is confusing, because you're definitely not the only one that has done this.
The absence of the verified or trivial label is exactly what you are trying to achieve with do not merge. This is why we have it in our checks (Enforce PR labels):

If the PR has not been verified by a human, it should not be merged.
If someone doesn't deem the PR trivial it should not be merged.

The above is covered at https://github.com/adobecom/milo/wiki/PR-Labels#labels, but we could probably do a better job there.
Based on what we saw in Dexter land, everyone should be doing E2E QA. We do not want to go back to a world where we dump our code on QEs.
Let me know your thoughts.

Thanks, @auniverseaway! This makes sense now, although not so obvious initially. PR has been verified; it's my understanding that just the Milo admins can provide binding approvals and merge to the main branch, so feel free to review further or merge if everything looks good.
And yes, we, the developers, also perform E2E testing. But right now we're also involving our QA team so everyone is up to speed with the project and see what process makes sense for all parties.


PROD-10363 : Automate creation of adt instance

BABYLON AZURE ADT
Allow communication with Azure Digital Twin
Usage:
bash
babylon azure adt [OPTIONS] COMMAND [ARGS]...

Options:

Name
Type
Description
Default

--help
boolean
Show this message 👆 and exit.
False

Subcommands
instance: Subgroup dedicate to Azure digital twins instance management
model: Subgroup dedicate to Azure digital twins models management
BABYLON AZURE ADT INSTANCE
Subgroup dedicate to Azure digital twins instance management
Requires key azure_subscription in the platform config file.
Usage:
bash
babylon azure adt instance [OPTIONS] COMMAND [ARGS]...

Options:

Name
Type
Description
Default

--help
boolean
Show this message 👆 and exit.
False

create: Create a new ADT instance in current platform resource group
delete: Delete a ADT instance in current platform resource group
get: Get an azure digital twins instance details
list: Get all azure digital twins instances
babylon azure adt instance create
Create a new ADT instance in current platform resource group
Requires key resources_location in the platform config file.
Requires key resource_group_name in the platform config file.
Usage:
bash
babylon azure adt instance create [OPTIONS] ADT_INSTANCE_NAME

Options:

Name
Type
Description
Default

--help
boolean
Show this message 👆 and exit.
False

babylon azure adt instance delete
Delete a ADT instance in current platform resource group
Requires key resource_group_name in the platform config file.
Usage:
bash
babylon azure adt instance delete [OPTIONS] ADT_INSTANCE_NAME

Options:

Name
Type
Description
Default

-f, --force
boolean
Don't ask for validation before delete
False

--help
boolean
Show this message 👆 and exit.
False

babylon azure adt instance get
Get an azure digital twins instance details
Requires key resource_group_name in the platform config file.
Usage:
bash
babylon azure adt instance get [OPTIONS] ADT_INSTANCE_NAME

Options:

Name
Type
Description
Default

-o, --output_file
path
Write full output of the adt api in target file
None

--help
boolean
Show this message 👆 and exit.
False

babylon azure adt instance list
Get all azure digital twins instances
Requires key resource_group_name in the platform config file.
Usage:
bash
babylon azure adt instance list [OPTIONS]

Options:

Name
Type
Description
Default

-o, --output_file
path
Write full output of the adt api in target file
None

-f, --fields
text
Fields witch will be keep in response data, by default all
None

--help
boolean
Show this message 👆 and exit.
False

Note
It is not necessary to review azure adt model commands i just moved them form babylon->azure->adt->commands to  babylon->azure->adt->groups->model->commands


Refactor/dev more cleanup plus unnamed semaphores

~This PR/MR should not be merged until after PR/MR #39 is merged.~
Ready to go!

Thanks @sanfords for putting it together.
There seems to now be a conflict due to merging #39 into dev.
I'm also stalling a little bit, I'd like to find time to grep-patrol through cacao and milk and check for breaking changes (and how many of those...) in pre-ISIO-API code.

rebased this branch, conflicts have been resolved

I'm also stalling a little bit, I'd like to find time to grep-patrol through cacao and milk and check for breaking changes (and how many of those...) in pre-ISIO-API code.

Take your time!

See also https://github.com/milk-org/milk/pull/10 and https://github.com/cacao-org/cacao/pull/23 that port compliance to these changes in extensions.

See also milk-org/milk#10 and cacao-org/cacao#23 that port compliance to these changes in extensions.

we could/should also eliminate all direct references, in milk and cacao, to ...{IMAGE}.semptr[semindex] that use system sem_* routines, and replace them with to ImageStreamIO_sem* interface routines.

Any movement on this?

Since this is structurally changing, I propose to increment version number to 2.0. @oguyon

Also, I think merging #44 has caused a conflict.

FYI, Ideally, I'd like to deploy this in prod on July 12.

FYI, Ideally, I'd like to deploy this in prod on July 12 (sorry for the long wait).

No problem, thanks for getting into this.  I'll sort outthe conflicts.

I am working on this some more to address the non-shared issues that Olivier raised.  It should be done well before mid-July.
Brian Carcich

Update:  hold off on this PR until PR #47 is resolved

Could we consider to merge #49 directly into your branch ?
I don't see any issue to merge it here, it simply adds a placeholder for the cudaMalloc. This placeholder is only for the internal computations in the GPU (loopcounter, timestamp, ...) to avoid code them in the image (and therefore degrade it).
However, as it's really a minor modification which no impact if you keep the value to 0, it could be done afterwards.

Apologies that it took 3 months. I believe the day has finally cometh.

I'm gonna make sure I compile jointly with https://github.com/milk-org/milk/pull/10 and https://github.com/cacao-org/cacao/pull/23.
Then I'm gonna deploy on one of the scexao server.
And then confirm the merge.


Show Formviolations for additionalAddressFields

1. Why is this change necessary?
Right now when you make an additionalField required on registration and the frontend validation is disabled no error message will be show.
2. What does this change do, exactly?
Show error messages for additionalFields when te backend validation fails.
3. Describe each step to reproduce the issue or behaviour

Make additionalAddressField1 required in the administration (Login/Registration)
Go to the signup page
Remove the 'required' attribute from the additionalAddressField1 input field
Submit the form
No error will be shown.  (And it should say: additionalAddressField1 is required)

4. Please link to the relevant issues (if any).
5. Checklist

[x] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-13269
Please use this issue to track the state of your pull request.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-13269
Please use this issue to track the state of your pull request.

Hey @alessandroaussems thanks for your work. your PR has just been merged : )

Hey @alessandroaussems thanks for your work. your PR has just been merged : )

Happy to contribute! 🤩

Happy to contribute! 🤩