As a CIF user, whenever I change any attributes of a project, the changes are recorded as I type

Description:
As a CIF user, whenever I change any attributes of a project, the changes are recorded as I type
Acceptance Criteria:
Given there is an existing project in the system
When I edit this project's metadata (title, description, ...)
Then the changes are saved in a pending state, as I type
Given there is an existing project in the system with pending changes
When I edit this project
I can see the pending changes and alter them
Given I am on the edit project page
When I type edits
The edit request to the server is debounced to a max of 1 request per 250 millisecond
Given I am on the edit project page
When I type edits
I can see an indicator whether the changes are saved or not
Developer checklist

[ ] a client network middleware to debounce mutations (similar to ciip) - so optimistic updates work out of the box
[ ] a react component that shows "saving" and "saved"

This ticket assumes #81 created a very basic edit page and an edit mutation for a project

Hey team! Please add your planning poker estimate with ZenHub @matthieu-foucault @pbastia

Adding applicable Personas to the ticket
Program Development Team - CIF Persona
Operations Team - Persona
Tech Team - CIF Persona

Thank you @matthieu-foucault! Dylan gave me a demo and highlighted how this feature works. Let me know if you want to go over anything in more detail. I like the react component that has been included that shows users when the system is "saving" and "saved".


Cljdoc git import failed

See Cljdoc page dawran6/emoji
This requires a <scm> tag in the pom.xml to fix. See How do I set SCM info for my project?

Fixed in 0.1.2, by 4f9beeb34d43e11cb02ccfcd8e5222209cd8ff7b


Bug 2115480: Reconcile immediately after timeout

After timing out on a batch we should reconcile immediately
If we don't we will just waste 5 minutes of timeout waiting for the next loop

/bugzilla refresh

/cherry-pick release-4.11

/cherry-pick release-4.10


feat: removed aes-ccm dep cos Node 10+ now support it in crypto module

Purpose of this pull request is to enable the use of cose-js in a browser environment. #22
The main problem with a browser environment, is aes-ccm dep which is a C++ addons for NodeJS. NodeJS 10+ now supports aes-ccm by default, so i think is possible to remove aes-ccm dependency.
Unfortunately, webcrypo doesn't support aes-ccm algorithms, so i have added a runtime check to control the environment. If the library is running in a browser, fallback to No implementation for algorithm exception.
All unit test have passed in my local environment.

Coverage increased (+0.2%) to 89.796% when pulling 048d116d901f08c69f9cda19116ae7ac27f0b805 on mancioshell:feature/aes-ccm into 6bade143df9f9a2351c84fa94a6da11e3656258f on erdtman:master.


[Android] Implement captureBitmapAsync to capture visible content

Use this to capture the visible content of web page. Note: XWalkGetBitmapCallback
happens at the same thread as captureBitmapAsync, usually the UI thread.
Also enable the zero parameter constructor support in reflection layer.
BUG=XWALK-5110,XWALK-2233
(cherry picked from commit 55eceb4d089e516ea2b754a61c942cf393841374)

@fujunwei @lincsoon @XiaosongWei @wuhengzhi

In the comment, (cherry picked from commit 55eceb4) could be removed.

LGTM

@lincsoon

LGTM


Create objects for missing RCT1 trains

Requires modification in OpenRCT2 to allow 16 frames per rotation first.
Ported:

[x] Ladybird trains
[x] Log trains
[x] Rocket Cars

Designs to port:

[ ] Steel Roller Coaster Train
[ ] Steel Roller Coaster Train (backwards)
[ ] Spinning Cars (Steel Mini)
[ ] Inverted RC Train

Up for discussion:

[ ] Wooden Roller Coaster Train
[ ] Wooden Roller Coaster Train (backwards)

@Gymnasiast are you able to provide JSON objects for these first?

@Gymnasiast are you able to provide JSON objects for these first?

Hm, what do you mean by "first"? What would be the next step then?

Hm, what do you mean by "first"? What would be the next step then?

Before changing the code to allow 16 frames per rotation, we need a JSON object to test it on. The JSON object will need to state that it has 16 frames per rotation and reference the CSG sprites.

Before changing the code to allow 16 frames per rotation, we need a JSON object to test it on. The JSON object will need to state that it has 16 frames per rotation and reference the CSG sprites.

That's a bit of a catch-22: it's very hard to pick the RCT1 sprites in the correct order. Hard enough that you'd want OpenRCT2 to support 16 frames per rotation first.

I wouldn't say it's hard per say, Just really time consuming and tedious.
I can share my rct1 ladybird json object i made awhile back and showed in the openrct2 discord server.
I can't confirm if the order is 100% correct due to the currently missing 16 frames flag.
And it's missing the guest sprites as i would like to do them once i know the main sprites are correct.
But it should suffice for implementing a fully fledged 16 rotational frames flag or something similar.
It currently already uses vehicle entry flag 11 which is normally used by boat hire boats and it makes the vehicle use 16 rotational frames only for it's flat sprites so that'd likely be a place to start.
For now though here is the json, hopefully it will suffice.
rct1.ride.ladybird.json.zip

@ZeeMajora There are quite a few empty frames at the end in your file. What is the reason you left them empty?

Doesn't RCT2 already have a 16-bit rotation flag in ride objects?

@spacek531 I have actually been working on porting the RCT1 Wooden RC. The only issue I had was picking the correct sprites from CSG1.DAT - I know they’re all there, but the order is different.
If you’d like to finish it, please let me know and I’ll rebase and push the branch.

Although the wooden is stopped by the track sprites, other RCT1 vehicles can be ported to a future version of OpenRCT2. I have done so and am creating my own repository of RCt1 vehicle ports here: https://github.com/spacek531/RCT1Vehicles
This OpenRCT2 branch solves the waste of sprites for the most part, and is the branch against which the current vehicles are created:
https://github.com/spacek531/OpenRCT2/tree/frames-rotation-count-part-1
The vehicles in my repository could be merged with this repository after some tasks are complete, see the issues section of my repository for more details.
Although it is relatively simple to load appropriate RCT1 vehicles only when necessary, users loading a park that has been touched originally by a linked version of OpenRCT2 will not see any sprites. This may or may not be an issue.

The fallback images could be determined algorithmically since the sprite orders are the same, there's just fewer sprites in one vs the other

As of objects release 1.4.0, the only RCT1 ride objects which are missing are:

Steel Mini Spinning Cars (Needs enhanced spinning animation system or new hard coded spinning animation)
Lay-Down Coaster Trains (Needs option to override offsets when loading images from dats due to them being rendered too high in OpenRCT2)
Classic Stand-up Trains (PR to add the train is open, needs classic stand-up ride type to be implemented in develop before the trains can be implemented)
Classic Wooden Twister Trains (Needs classic wooden twister ride type to be implemented in develop before the trains can be implemented.)


overflow inside cards

Hey! I've been using this project for a little bit (thanks so much!) from github.
I did a fresh npm install today and noticed this
https://www.dropbox.com/s/tse9y9qk5c4y01j/Screenshot 2016-02-12 14.17.39.png?dl=0
I tried to find what commit caused it but I didn't quite find it.
anyway i just thought I'd bring it to your attention, I'm going to take another stab at finding out the cause sometime over the weekend.

I'm not clear what the problem is in that screenshot - could you be more specific?

Oh, is the problem that elements which try and overflow get clipped at the card border?

Yeah sorry here's a better screen
https://www.dropbox.com/s/31wsj8181eaj50b/Screenshot 2016-02-22 16.01.03.png?dl=0
top one has height set on the div that is passed to devcard()
bottom one is default
the component has a popover element which is cut off by the end of the card.
I think that it wasn't doing this before, and an update caused it.
Thanks again.

Should be fixed in febba74


Spark + Yarn + Livy Server - Not releasing or stopping the Application Master

Every time I go to the Spark Query Editor in Hue (even in the same session switch back and forth between Spark and some other application), its creating a new Application Master in Hadoop/Yarn and not releasing or cleaning them up after I execute my Spark/Scala code. This blocks resources in Hadoop cluster.
It would be nice to be able to:

Reuse the application master when switching between applications in Hue in the same session.
Be able to stop the Application Master from the Spark Query Editor.
Automatically stop the Application Master after some period of in-activity.

@erickt, I though we had # 3 already?
We are going to make # 2 more obvious (right now the user needs to go in Job Browser). Normally when you leave the notebook, it sends a call to close the notebook sessions.

Normally when you leave the notebook, it sends a call to close the notebook sessions.

When you send a call to close the notebook session, does it suppose to terminate/kill the application master? If so, it's not doing it now (in Hue 3.8.1).
Thanks.

Yes it should, I see the ajax call going to close_notebook in Hue but need to check on the Yarn mode if then Hue send the close to Livy and Livy understands it

I tried to trace the network calls in my chrome and I don't see a call going to the server about stop/shutdown/destroy. Can you please tell me how the call looks like? Thanks.

I forgot about https://issues.cloudera.org/browse/HUE-2651!
Signal to close
https://github.com/cloudera/hue/blob/master/apps/spark/src/spark/api.py#L205
Sent to Spark but doing nothing :)
https://github.com/cloudera/hue/blob/master/apps/spark/src/spark/models.py#L411
We should call:
https://github.com/cloudera/hue/blob/master/apps/spark/src/spark/job_server_api.py#L89

Reusing Application Masters would be awesome, but it'll be probably non-trivial to implement (HUE-2833).
@spaztic1215 is currently working on (2) in https://review.cloudera.org/r/5423/.
We do time out the spark sessions, but the timeout is an hour. This does need to be configurable (HUE-2832).

Can Spark dynamic allocation be of help here? It wouldn't kill AM but at least will time out and remove executors.

FYI, HUE-2832, which makes session timeout configurable, has landed. The default is still to shutdown idle sessions after an hour.
@Tagar: that would be an interesting idea to spin down executors if a session has gone temporarily idle. I've filed HUE-2931 to track it.

Hi, can i swich off, this function?
If i go away from notebook, session stil working.


Add missing LdapDn field in Users class

I signed it!

Did you run your code through gofmt?

Did you run your code through gofmt?

No, how do I do that?

https://golang.org/cmd/gofmt/
gofmt -w filename.go

You don't need to edit the two auto-generated files... please see the go generate ./... section of CONTRIBUTING.md.

You don't need to edit the two auto-generated files... please see the go generate ./... section of CONTRIBUTING.md.

oh okay, my bad. i think i fixed the issue

LGTM. Merging.


Incorrect TS types for

Seems like the TextStyle type isn't forwarding the text keys. Not sure why.

I'm still experiencing the same issue? Why this was closed though?
<MotiText
	// @ts-ignore reason: types are not properly defined on the moti package
	from={{ color: '#797979' }}
	animate={{
		@ts-ignore reason: types are not properly defined on the moti package
		color: activeButtonBasedOnControlled === button
			? colorScheme === 'dark'
			? 'black'
				: 'white'
			: '#797979',
	}}
	transition={{ duration: 200, type: 'timing' }}
	className="font-inter font-normal"
	numberOfLines={1}
>
	{button}
</MotiText>

Have to tsignore to opt out of ts errors.

you probably need to delete types/react-native from your repo and upgrade moti

I'm using expo SDK 50... don't have @types/react-native installed in the repo and also on the latest release of moti version 0.28.1


The documentation platform needs a better way of generating navigation

Currently navigation in the documentation platform is a manual process. site-structure.json defines the structure with groupings, titles, and URLs. This structure is very fragile because:

If the titles do not match the titles in the documents, an active indicator will not appear in the sidebar navigation.
If the URL is incorrect in the site-structure.json file, you will no know there is a problem until manually encountered.

A more robust or automatic method of generating navigation should be used. Consider using 11ty's navigation and/or collections.
Additional context or notes
Originally filed as FLUID-5721 by @jhung on July 28, 2015.

@jobara I might be able to look at this in August.

@jobara I might be able to look at this in August.

That'd be great. I was thinking it might make sense along side an update to 11ty 3.0 but it could happen earlier too.

Relates to #191 and #307


Push shared CA certs to all clusters

This is broken out from #22106

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

lint_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test lint_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

integ-distroless-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-security-k8s-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-security-k8s-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-security-k8s-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

integ-security-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-security-k8s-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test unit-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
cb23680f61f029e8f823a49c93d8e1034a6363ee
link
/test integ-mixer-k8s-tests_istio

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test lint_istio

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test unit-tests_istio

integ-mixer-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

integ-conformance-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-conformance-k8s-tests_istio

unit-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test unit-tests_istio

integ-mixer-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-mixer-k8s-tests_istio

lint_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-mixer-k8s-tests_istio

lint_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test lint_istio

unit-tests_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
d76d5862a51f2ef48bdff6282c2312cc60664090
link
/test integ-mixer-k8s-tests_istio

lint_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test lint_istio

unit-tests_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5bfd5e62ce0141933c0fca8c1285bd91107bd447
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d97cb5fe6167cc28eda255a208ca237f41d2225f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
1fe360f8af2840dcea5d866b7b9f1c2be5cc3187
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
af9c74985eee42e0dd063902ebef330cfa3a071f
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
296554cc0a66ea158eb558095f0fa515e54fe017
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
24aad53d9f22147fd6eb5d8754b80681e1980ff0
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
b9e9bff78433e9911a663f624fe675a6e111647a
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
b9e9bff78433e9911a663f624fe675a6e111647a
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
dcb28ba513fe0c61ab8847034c012c5a5db7827b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
dcb28ba513fe0c61ab8847034c012c5a5db7827b
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
dcb28ba513fe0c61ab8847034c012c5a5db7827b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
37be921ad5d7cbe7ddf9435db34a2e6c7288c1ba
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
37be921ad5d7cbe7ddf9435db34a2e6c7288c1ba
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
14226082abfe920eecb0f53912f7e87413315dc5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
14226082abfe920eecb0f53912f7e87413315dc5
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
14226082abfe920eecb0f53912f7e87413315dc5
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

approved with hold since there are some potentional follow ups but LGTM

@nmittler: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
d41e73356cada15e081a0a7d5b52d70b0c80dcc5
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn PTAL

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
d41e73356cada15e081a0a7d5b52d70b0c80dcc5
link
/test integ-conformance-k8s-tests_istio

lint_istio
06c04319362f41bca2f6364699baf7fa3df4b398
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
06c04319362f41bca2f6364699baf7fa3df4b398
link
/test lint_istio

unit-tests_istio
06c04319362f41bca2f6364699baf7fa3df4b398
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Pure scrolling annoyingly expands menu items

When scrolling through the docs on my iPhone, menu items are expanded. The shall not be expanded by touchdown/up when scrolling, only when clicking. It is extremely annoying and makes the docs almost unreadable in terms of user experience.
Problem description

Problem location

I saw a problem on the following URL:

I couldn't find the information I wanted. I expected to find it near the following URL:

Other:

Project version(s) affected

Suggestions for a fix

Thinking aloud: I'm pretty sure the necessary JS here would:

Trigger an "I got touched" event onMouseDown for the node that sets a global variable ("hasScrolled") to false
If the user scrolls the window after touching a node, assume it's inadvertent and set "hasScrolled" to true
onMouseUp, only open the node if "hasScrolled" is false

Why not simply use 'click' instead of 'mouseup'/'touchend'? I have created a pull-request with this fix. If you want to test how it works, my fork with that fix applied runs here: https://enselic.github.io/
I have only done some quick sanity testing and the fix at least fixes the super-annoying bug reported in this issue. I have not found any other problems, but then again: I have not performed extensive testing.


support sum/avg agg for decimal, change sum(float32) --> float64

Which issue does this PR close?

part of https://github.com/apache/arrow-datafusion/issues/122
The result data type for decimal case (closes https://github.com/apache/arrow-datafusion/issues/1418)
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

PTAL @alamb @houqp

In the comments, @alamb gives some comments about the precision or scale for the result data type.
I want to follow the guidance document https://www.postgresql.org/docs/8.2/functions-aggregate.html at first but can't find some useful suggestions.
So I follow the behavior in the spark sun and avg.

I want to follow the guidance document https://www.postgresql.org/docs/8.2/functions-aggregate.html at first but can't find some useful suggestions.
So I follow the behavior in the spark sun and avg.

As I mentioned above, i think following the behavior of spark is fine, but I think we should use symbolic constants (largely as a way to document why those particular constants were picked)

As I mentioned above, i think following the behavior of spark is fine, but I think we should use symbolic constants (largely as a way to document why those particular constants were picked)

Ok, I will refine this pull request.

👁


Error with cmr

Hi Norm
I am on version 0.24.1 I am getting this error

I have _cmr no params on a form view I do not have any page rules on the modal or the background page.
Craig

Should be fixed now.
Try Beta or Dev version.
Norm

Thanks Norm


assert_eq_size!() doesn't work with type paramenters

In version 0.3 it was possible to have a assert_eq_size!() inside a function, and refer to the type parameters of that function.
In version 1.0.0 that is no longer possible:
fn foo<T>() {
    static_assertions::assert_eq_size!(Rc<T>, Arc<T>);
}

error[E0401]: can't use generic parameters from outer function
   |
   | fn foo<T>() {
   |    --- - type parameter from outer function
   |    |
   |    try adding a local generic parameter in this method instead
   |     static_assertions::assert_eq_size!(Rc<T>, Arc<T>);
   |                                           ^ use of generic parameter from outer function

assert_not_impl_any! also doesn't work from inside a function, which is very annoying since negative trait bounds are not supported...


Nested wayland backend broken in wlroots 0.9.0

When running wlroots compositors with the wayland backend, an invisible window is created and it simply does not work. It was working before https://github.com/swaywm/wlroots/pull/1797

Fixed in https://github.com/swaywm/wlroots/pull/1977


[BUG] System backup should validate empty backup target

Describe the bug (🐛 if you encounter this issue)
Create a system backup when the backup target is empty succeed.
To Reproduce
Steps to reproduce the behavior:

Set the backup target empty.
Create a system backup.
System backup created.

Expected behavior
Should show an error.
Log or Support bundle
None
Environment
N/A
Additional context
The issue was raised while testing for https://github.com/longhorn/longhorn/issues/5047.

UI should also show the error as backup target is empty as it shows for volume backup creation.

Validation - Pass on v1.4.x-head


Update devices list search

Implemented search for devices list:
https://user-images.githubusercontent.com/17521730/153055060-a707fdc9-d12b-4a67-9f26-6d53575a63bf.mov

Looks like there's a conflict. Can you please fix it. Otherwise looks good.

Merged, thank you.


Wave eq csv output

Hi @amartinhuertas @davelee2804 I've just opened this pull request to discuss saving output data to .csv. This can either be merged and used in the NSWE code or we can use this as the starting point for work on the diagnostics

Hey @cbladwell , thanks for doing this. Your approach looks good to me. I will emulate this in the shallow_water_explicit branch as well

No worries. Should we move these functions into DiagnosticTools.jl and you merge into your shallow water branch?

Yes, I think that is a good Idea. Will add these to the diagnostics tonight

Nice work! @cbladwell ... just a couple of additional comments

Remove png and data files from the repo.
Tests are failing, why? Solve it.
I think it is better to leave write_results=false by default so that we do not generate the data in Github actios CI (I am not sure if this can cause trouble).

Hey @cbladwell , I have one comment. It looks like you are writing the csv file at the end of the time step iteration. I think it is better if the file is instead appended each time step. The reason is that if the code crashes (or we hit wall time on the HPC) before the end of the time step loop we will not have any diagnostics data to inspect. Could you move the code to append the file at each time step? Does that sound ok?

Hey @cbladwell , I have one comment. It looks like you are writing the csv file at the end of the time step iteration. I think it is better if the file is instead appended each time step. The reason is that if the code crashes (or we hit wall time on the HPC) before the end of the time step loop we will not have any diagnostics data to inspect. Could you move the code to append the file at each time step? Does that sound ok?

hi @davelee2804 ... I agree this would be desirable, however, I am not sure if this is possible with CSV.jl. Perhaps @cbladwell can tell better.

It looks like you are writing the csv file at the end of the time step iteration. I think it is better if the file is instead appended each time step. The reason is that if the code crashes (or we hit wall time on the HPC) before the end of the time step loop we will not have any diagnostics data to inspect. Could you move the code to append the file at each time step? Does that sound ok?

Yes I agree, it would be computationally better to write at each output interval (as with the .vtus) rather than storing the fields in memory. I think it is possible to do this with CSV.jl

Tests are failing, why? Solve it.

I think this error is in the Williamson tests. I can investigate the error further but I think it is fixed in the most recent Williamson test code

Thanks for your work @cbladwell !

I think this error is in the Williamson tests. I can investigate the error further but I think it is fixed in the most recent Williamson test code

Notet that now (latest commit) you have a different error: https://github.com/gridapapps/GridapGeosciences.jl/runs/3532983666#step:6:224
The error that you had before was different:
https://github.com/gridapapps/GridapGeosciences.jl/runs/3529272826?check_suite_focus=true#step:6:724
I think this latter one is caused because write_results=true, which in turns triggers the plot command that generates an error because there is no X terminal to connect to.
I am aware there are errors in other tests, but these are puzzling me ... it is like everthing failed!

I am aware there are errors in other tests, but these are puzzling me ... it is like everthing failed!

Ok, I know what it is failing. Your Manifest.toml file is wrong:
https://github.com/gridapapps/GridapGeosciences.jl/blob/wave_eq_csv_output/Manifest.toml#L325
it should point to a particular branch of Gridap.jl. Look how this file looks like at master
https://github.com/gridapapps/GridapGeosciences.jl/blob/master/Manifest.toml#L312

See also changes to manifold.toml in this branch
https://github.com/gridapapps/GridapGeosciences.jl/pull/17/files#diff-6d1205e03b7a43c01ed2ac8b8c83eb58c6f3a3b1360769e18644245abee8c565R325

Codecov Report

Merging #17 (8c27036) into master (fcfc72c) will decrease coverage by 1.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   46.35%   44.72%   -1.63%
==========================================
  Files          10       10
  Lines         302      313      +11
==========================================
  Hits          140      140
- Misses        162      173      +11

Impacted Files
Coverage Δ

src/DiagnosticTools.jl
7.69% <0.00%> (-5.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfc72c...8c27036. Read the comment docs.

it should point to a particular branch of Gridap.jl. Look how this file looks like at master

Thanks! There were a couple of errors in the Manifest I have updated now.
@davelee2804  sorry for the delay, you should be able to write to csv now


Convert md to html

When prompt Ctrl+Shift+p, what am I supposed to enter as information in console area appearing as parsers can operate?

Sorry, I finally understood what was my issue. My brain is slow, and my eyes don't read everything. There's maybe a connection by the way. Thanks. And sorry again.

you're not stupid, the documentation can be confusing and you're invited to improve it if you can :)
Ctrl+Shift+p opens the sublime text palette where you can execute builtin commands, and plugins too
From there, just type "markdown" and select "markdown preview: preview in browser"

(See my comment above) Thanks for your answer.

By the way... You put as NOTE crucial information actually. That's what confused me actually. I mean it's essential to understand that output, or conversion, has to be throught GitHub. So the process is easier to understand later on.

it doesnt have to be, you have the choice between github parser or builtin markdown parser


Phoebemirman/ch11703/red exclamation points in dispute market

Clubhouse Story
Submitter checklist

[ ] Test covering functionality added/fixed in
Check the linked story includes the following:

[ ] Steps to reproduce
[ ] Screenshot (If applicable)

Reviewer Checklist

[ ] Test/lint pass

I requested a couple small changes on the CH ticket, so this shouldn't be merged in yet.

Changes look good to me. Still approved


Iphone 5s - cursor is not in the right place, screen jumps around

How to recreate:

Open tripplanner.vta.org
Select a to address place

Expected Behavior:
Blinking bar
Actual Behaviour:
Cursor in the wrong place, jarring movement.

Fixed in this pr


[ISSUE #6073] remove static reference

Make sure set the target branch to develop
What is the purpose of the change
close #6073
Brief changelog
remove static reference
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #6074 (05a0e5b) into develop (c8e22a6) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6074      +/-   ##
=============================================
- Coverage      43.33%   43.23%   -0.10%
- Complexity      8837     8841       +4
=============================================
  Files           1093     1094       +1
  Lines          76857    77102     +245
  Branches       10013    10055      +42
=============================================
+ Hits           33303    33333      +30
- Misses         39390    39606     +216
+ Partials        4164     4163       -1

Impacted Files
Coverage Δ

...org/apache/rocketmq/store/DefaultMessageStore.java
46.50% <0.00%> (-6.41%)
:arrow_down:

...controller/impl/DefaultBrokerHeartbeatManager.java
82.27% <0.00%> (-3.80%)
:arrow_down:

...ent/impl/consumer/DefaultLitePullConsumerImpl.java
67.55% <0.00%> (-1.10%)
:arrow_down:

...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java
63.43% <0.00%> (-0.33%)
:arrow_down:

...ache/rocketmq/store/config/MessageStoreConfig.java
58.41% <0.00%> (-0.27%)
:arrow_down:

...e/rocketmq/client/impl/consumer/RebalanceImpl.java
31.35% <0.00%> (-0.22%)
:arrow_down:

.../java/org/apache/rocketmq/common/BrokerConfig.java
27.92% <0.00%> (ø)

.../org/apache/rocketmq/proxy/config/ProxyConfig.java
44.65% <0.00%> (ø)

.../apache/rocketmq/proxy/grpc/GrpcServerBuilder.java
0.00% <0.00%> (ø)

...protocol/http2proxy/Http2ProtocolProxyHandler.java
0.00% <0.00%> (ø)

... and 13 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Move passes options to their own thing

Potential solution to #1346

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

looks like another shared object build failure; this one though looks addressable. i'll investigate locally and push an update soon.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

merge conflicts resolved

See also PR #1363

Can one of the admins verify this patch?

Going to go with #1363 so closing this PR without committing.


AttributeError: module 'signal' has no attribute 'SIGUSR1'

https://github.com/v-iashin/SpecVQGAN/blob/8ab6981535ab70fad3531688e0f630f1ce3b834f/train.py#L738
I am running on windows and this error occurs AttributeError: module 'signal' has no attribute 'SIGUSR1'as if windows does not support the sig directive , it coms from https://docs.python.org/3/library/signal.html#signal.SIGUSR2

Just comment out these two lines, and it works


fix: show key-value pair examples for objects

fix: #1053
Problem
Currently, the generated example for objects is not consistent.

It does not generate key-value pair examples
The object example is always generated with the type from additionalProperties (e.g. If the additionalProperties field has type: string definition, then the generated example will be myObject: ""

Explanation
This happens because the getExampleFromSchema function bubbles up the type from additionalProperties when overwriting the response.
Solution
With this PR:

The getExampleFromSchema function is changed to:

return null example for nullable properties;
add an example of key-value pair examples when the object has additionalProperties;
do not overwrite response with additionalSchema.

The getExampleFromSchema test is changed to:

assert if a key-value pair example is added;
assert if a null example is added.

The getRequestBodyFromOperation test is changed to:

assert that examples for object schemas are generated correctly for each OpenAPI type.

Note: decided to go with early return to avoid making the response type nullable (Record<string, any> | null), what would break the property xml tag access (response[propertyXmlTagName ?? name]). Please, let me know if it is not aligned with the codebase patterns.

🚨Still not working for nested objects with type definitions in the additionalProperties field🚨

Any ideas on how to solve it?

amazing contribution! excited to try this out :) Will have a review EOD

How to generate a changeset?

pnpm changeset

then it should be an interactive step by step process on whats being changed ✨

Love it, great contribution! 🤝


Marker color

closes #590
addresses #517

composite field for marker.color
have all colors in constants
JS warning fixes
css fix for field within field scenario

ok, well, looks good to me...
when it's merged, i'll do the multivalued portion of it, thanks!

💃

@dmt0 could you rebase please and merge :)

What do you mean by multivalued portion? It's done


optimize: Generated instances that were not actually used when the class was loaded

…aded

Ⅰ. Describe what this PR did
optimize: Generated instances that were not actually used when the class was loaded
Ⅱ. Does this pull request fix one issue?

#2350
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2364 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #2364      +/-   ##
=============================================
- Coverage       51.6%   51.59%   -0.02%
+ Complexity      2693     2688       -5
=============================================
  Files            517      517
  Lines          16734    16733       -1
  Branches        2039     2039
=============================================
- Hits            8636     8633       -3
  Misses          7290     7290
- Partials         808      810       +2

Impacted Files
Coverage Δ
Complexity Δ

.../datasource/undo/parser/FastjsonUndoLogParser.java
90% <100%> (ø)
5 <3> (ø)
:arrow_down:

...atasource/undo/parser/ProtostuffUndoLogParser.java
54.71% <100%> (+0.87%)
5 <2> (ø)
:arrow_down:

...source/undo/mysql/keyword/MySQLKeywordChecker.java
98.91% <100%> (-0.01%)
5 <0> (-1)

...tasource/sql/struct/cache/MysqlTableMetaCache.java
82.55% <100%> (ø)
10 <0> (ø)
:arrow_down:

...o/postgresql/keyword/PostgresqlKeywordChecker.java
89.52% <100%> (ø)
7 <0> (-1)
:arrow_down:

...rce/sql/struct/cache/PostgresqlTableMetaCache.java
79.54% <100%> (ø)
10 <0> (-1)
:arrow_down:

...m/datasource/undo/parser/JacksonUndoLogParser.java
71.95% <100%> (ø)
8 <3> (+1)
:arrow_up:

...urce/undo/oracle/keyword/OracleKeywordChecker.java
96.99% <100%> (-0.03%)
11 <0> (-1)

...o/seata/server/coordinator/DefaultCoordinator.java
54.35% <0%> (-0.52%)
28% <0%> (-1%)

...in/java/io/seata/server/session/GlobalSession.java
84% <0%> (-0.45%)
72% <0%> (-1%)


Day412

Resolves #832.

Pull Request Test Coverage Report for Build 1576

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1566:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


Timeline Endpoint

Timeline endpoint returns the commit and deploy data sorted by time

Defines some structs to send to the web as json instead of encoding manually.

The query is, despite returning the proper data, giving this error:

2022/07/21 17:24:49 /home/jorringe/platform-changelog-go/internal/db/queries.go:124 sql: Scan error on column index 12, name "id": destination not a pointer; sql: Scan error on column index 12, name "id": destination not a pointer
[0.206ms] [rows:2] SELECT timelines.id,timelines.timestamp,timelines.service_id,timelines.commit_id,timelines.deploy_id,commits.id,commits.timestamp,commits.repo,commits.ref,commits.author,commits.message,commits.merged_by,deploys.id,deploys.timestamp,deploys.repo,deploys.ref,deploys.namespace,deploys.cluster,deploys.image FROM "timelines" LEFT JOIN commits ON timelines.commit_id = commits.id LEFT JOIN deploys ON timelines.deploy_id = deploys.id WHERE timelines.service_id = 3 ORDER BY timelines.Timestamp desc

Further Changes

Removed the Commits and Deploys models in favor of a Timelines models.
Queries.go got cluttered; it's now separated into multiple files.
Added get calls with reference parameters.
Further updated the openapi.


Exception thrown when calling whenPivotLoadedAs when preventAccessingMissingAttributes is active

Laravel Version: 9.36.1
PHP Version: 8.1.6
Database Driver & Version: not applicable

Description:
Having Model::preventAccessingMissingAttributes(true); and trying to make use of a JsonResource whenPivotLoadedAs() method results in a Illuminate\Database\Eloquent\MissingAttributeException. Is this an expected behaviour? Shouldn't the whenPivotLoadedAs method check for the relation existence by calling relationLoaded instead of trying to access the relationship directly?
I could do a PR with that change.

I think you are right. My tests are failing because this too :)

I'm also seeing issues. I think part of the problem is that Laravel loads foo_id as pivot_foo_id and gets confused because it's not foo_id.

I'm having the exact same issue in a JSON resource where I am using whenPivotLoaded to decide whether or not to include pivot fields.

This has been fixed in v9.38.0, see https://github.com/laravel/framework/pull/44792

Thanks all.


Ui improvements

As suggested in #1189.

This was more massive than we thought this morning.

But I am very proud of it now :)

@Integral how do you like this colour? ;)

@Integral everything seems to be working. Now we need to fix styles. And also still left is hiding inactive groups from the 'Edit' dropdown.

👍

I would say it is now in a good shape, but want to discuss one tiny detail.


tooltip position wrong for custom tooltips

Hi, I have a issue that tooltip position is calculated wrong when I use custom tooltips. You can reproduce this problem very easily, just add or edit lines in tooltip.body[0] the tooltip stays on the same position as if the change was not done. Which causes it to overflow out of graph area or have the caret on the wrong position. Note that I am using mode: x-axis as well (didn't tested another modes - i need this mode).
I change the y/x values of tooltip to "fix" it but it is not working very well and tooltips are just not as well positioned as they would be when automatic positioning is in place... Are there any options to call the automatic positioning after i change the tooltip?

Duplicate of #2636


Appstudio update test-custom-default-branch-qixl

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-annotations-mwia-on-pull-request-
creating pipelinerun test-annotations-mwia-on-pull-request- in namespace build-e2e-chaz-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


codefix: Remove declaration for local in destructuring assignment breaks code.

TypeScript Version:  2.8.0-dev.20180302

Search Terms: "remove declaration for" remove declaration destructuring
Code
--noUnusedLocals needs to be on.
The "remove declaration for" quick fix for unused locals is broken:
function f() {
	const {abs, floor, ceil} = Math
	const {sin, cos, tan} = Math
}

Expected behavior:
After code fix on abs:
function f() {
	const {floor, ceil} = Math
	const {sin, cos, tan} = Math
}

After code fix "fix all":
function f() {
}

Possible side effects of the RHS are ignored by the const abs = Math.abs quick fix, so this should be mirrored here.
Actual behavior:
function f() {
	const {, floor, ceil} = Math
	const {sin, cos, tan} = Math
}

After code fix "fix all":
function f() {
	const {,,} = Math
	const {,,} = Math
}

screencast: https://gfycat.com/SleepyEnchantingArcticfox
Related Issues:

PRs welcomed!

IMO noUnusedLocals  need some change:
error on (parameter, variable declaration)list node if all item is unused

Fixed by #23805 and #23819


Major Bug: Losing items from Heavy Duty Workspace 1.6d/1.6e

Replication Instructions:
Place down a HDW bench,
Put in a recipe (for example the reactor casing one)
Then come off the table without making it and leaving the items in the table
From the 12 plates and 4 ingots used to make the recipe it only drops 4 plates and 2 ingots on the ground
Place those 4 plates and 2 ingots in the HDW and come off the table and you get back just 1 of each.
Place those 1 plate and 1 ingot in the table, come off the table gui and you get nothing back
Edit: It seems to give you only 9 items back if you fill the entire grid, so maybe that's related to normal crafting table?

Aha! You were right about it being related to the vanilla crafting table - it was only dropping the first 9 items from the grid on closing the GUI - fixed now ;)

Hi turbo, do you have a jenkins I can pull a dev build from?

I don't, unfortunately - I can just give you this, though...
https://www.dropbox.com/s/ful13aqvpl8aphz/NuclearCraft-1.7dev--1.7.10.jar?dl=0

Thanks


Strict Mode check not take account of $ref

What version of Ajv are you using? Does the issue happen if you use the latest version?
8.11.2
Ajv options object
strict: true

Reproduce code:
    new Ajv({
            strict: true,
        })
            .addSchema({
                $schema: 'http://json-schema.org/draft-07/schema#',
                $id: 'my-defs.json',
                definitions: {
                    Foo: {
                        type: 'object',
                        properties: {
                            foo: {
                                type: 'string',
                            },
                        },
                    },
                },
            })
            .compile({
                $schema: 'http://json-schema.org/draft-07/schema#',
                type: 'object',
                properties: {
                    nested: {
                        $ref: 'my-defs.json#/definitions/Foo',
                        additionalProperties: false,
                        // type: 'object', <=== add redundant type def will make error go away
                    },
                },
            })

Your code

Validation result, data AFTER validation, error messages
Got   strict mode: missing type "object" for keyword "additionalProperties" at "#/properties/nested"

What results did you expect?
no error
Are you going to resolve the issue?

Yes, this is by design, you can see it as a limitation, but it is a useful one - it leads to a more modular schema design. $ref can be used in multiple contexts but it may be compiled into a separate validation function, so whatever restrictions that strict mode has will be applied to $refs in isolation of the containing schemas.
Also, you cannot really use additionalProperties like that because it only takes into account properties defined in the same schema object - additionalProperties: false in your case prohibits all properties. What you want can be achieved with unevaluatedProperties defined in draft-2019 of JSON Schema (you need to use different ajv import to use it, it won't change how strict mode treats refs though)


HLS with SNAP Howto: Simple docu for beginners

Frank: Connection host/action, prepare/define SNAP job
Bruno: Examples tidy up, MMIO interface to receive job
How to generate vhdl from C/C++ HLS code automtically?

Documents in box -https://ibm.box.com/s/gl7olerjf46tnqce1ivmei6jp17yvg9g
I will add them to git when all done and reviewed


ticket_32519

Adds a JSONSet Function which can be used in a queryset.update(json_field=JSONSet(field="json_field", fields={"$.hello": Value("world")})

sqlite supported
postgresql partially supported
oracle untested
mysql/mariadb untested

I wasn't able to login via github on the trac website. ( nvm, i had a browser extension turned on )
I'm also wondering where in the code the "__" key and transforms occur, looking into that. Something like this could be wired into json field updates/queries, something akin to RawSQL and Q and F, possibly.
TODO: JSONRemove, less redundant interface on the kwargs
related:

https://code.djangoproject.com/ticket/32179
https://code.djangoproject.com/ticket/32519

@allen-munsch Thanks :+1: Feel-free to send a new PR, if you find time to keep working on this.
Closing due to inactivity.

@felixxm Thanks for the reminder on this one. If I can find some time, I'll do that.


chore: remove deprecated steps

What is the motivation for this pull request?
Remove deprecated steps:

I see input has value
I see element has attribute equals
I see element has attribute containing
I see input has value containing
I see textarea has value
I see textarea has value containing

Checklist:

[x] Conventional Commits
[ ] Tests
[ ] Documentation

https://github.com/remarkablemark/cypress-cucumber-steps/pull/465#issuecomment-1738318094


Fast nearest neigbor lookup with KDTree

For very large number of sensors, above 10,000, the distance matrix calculation gets pretty slow (something like 30 sec for 10,000 sensors against themselfs, if I recall correctly) and this scales quadratically (I guess...). Hence we might also want to provide the option to calculat nearest neighbors with scipy.spatial.KDTree, since we typically only use sensors within a certain distance (max. some tens of kilometers) which means that most parts of the distance matrix is not used if our domain is large e.g. for country-wide data in Germany.
Originally posted by @cchwala in https://github.com/OpenSenseAction/poligrain/issues/15#issuecomment-1924644621

Note that there is also the option in scipy to calculate a sparse distance matrix using KDTree.
Maybe we could make it an option to use this sparse version in the current function for the calculation of the distance matrix.
We might hover, also switch to the simple nearest-neigbor lookup via KDTree.query because this is most often the use case, e.g. for QC with neighboring stations as we do it in pypwsqc.

It should be fairly easy to use the sparse distance calculations. We just have to exchange the code in https://github.com/OpenSenseAction/poligrain/blob/5832645bd88122ad812cecc6df27eab99bc71204/src/poligrain/spatial.py#L113
with the sparse version.
We would still need to decide if we want a function that simply returns a list of nearest neighbors for a specific point using KDtree and query. Maybe it is enough to have the sparse distance matrix with nice axis labels based on IDs of the stations that have been used.

Some notes based on preliminary tests:

The "empty" portions of a sparse matrix are treated as zeros when converting to a dense matrix. Hence, there is no way to distinguish between zeros from distance calculation between equal coordinates and distance calculations that have not been carried out because distance > max_distance. If one is aware of that peculiarity, that will not cause problems, but if somebody would not exclude all IDs with zero distance (which also contains IDs from far-away sensors) this might results in undesired behavior of code that works okay with a dense distance matrix calculations.
While a distance matrix is nice to get an overview of all distance with a clear relationship between all locations in an easy 2D matrix layout, there is no direct need to use a distance matrix in any of our functions. There is currently a distance matrix being used in the indicator correlation code (see code snippet here), but we might also use a KDTree nearest neighbor lookup here since only the neighbors within a certain distance are considered.
Apparently, as written in https://github.com/OpenSenseAction/poligrain/issues/15#issuecomment-2009301516, we already decided during the meeting in Prague that the KDTree neighbor lookup is more important than the sparse distance matrix calculation.

Conclusion: Priorities KDTree neighbor lookup for points. Maybe add sparse distance matrix calculation, too.

The way to return the data from the KDTree.query() could be done like in #43, specifically like the code here https://github.com/OpenSenseAction/poligrain/pull/43#discussion_r1591489036


Export types engine default features

Motivation
Include default features of engine types in rpc-types meta crate.

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

I think we can do 'default = ["alloy-rpc-types-engine/default"]'?


Refactor donut metric summary

Description
Refactor the donut API so that DonutSummary is its own component. In a future PR, I will break out ArcLabel into its own component.
Related Issue
https://github.com/adobe/react-spectrum-charts/issues/218
https://github.com/adobe/react-spectrum-charts/issues/180
Motivation and Context
This cleans up the API and also makes the summary optional
Stories
Donut > DonutSummary
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

This is a breaking change but it is on an alpha component so we are safe.
I'll update the docs when I finish up the productionization of donut.


Errors being written to Output in 0.5.0

I noticed some errors being written to output while editing an MXML file:
The following error happened when I added initComplete="init()" to the component before I created the init() function
[Error - 11:16:39 AM] Request textDocument/signatureHelp failed.
Message: Internal error, please look at the server's logs.
Code: -32603
And this is the entry in the log:
https://paste.apache.org/KLAG
The second error happened while moving my mouse between the same file and the Output pane:
[Error - 11:19:19 AM] Request textDocument/hover failed.
Message: Internal error, please look at the server's logs.
Code: -32603
With this log entry:
https://paste.apache.org/OEO1

Thanks! I can reproduce this issue.


Fix Apollo cache

LIIKUNTA-439 HH-297.
Critical fix to the Apollo-client cache that didn't persist.
Steps to test:

Make a search (in Events / Hobbies / Sports, venues or events)
Click a result card to navigate to the details page
Click back arrow or browser back button
→ The browser should not make a new query but scroll to the card that was clicked earlier, but instead it makes a new query

LIIKUNTA-432
Fixed the locations selected module in the article page.
Needed also to update the CMS content related to the languages (Wordpress PolyLang):

https://liikunta.hkih.stage.geniem.io/wp-admin/admin.php?page=mlang
https://liikunta2.content.api.hel.fi/wp-admin/admin.php?page=mlang

The error boundary should be tested!

[ ] Test that the error boundary is still working. E.g use local router and shut it down in middle of the browsing.
[ ] Investigate why the args in dependency array did not work. Does the args change too often?

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr273.dev.hel.ninja :rocket::rocket::rocket:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://harrastukset-pr273.dev.hel.ninja :laughing::tada::tada::tada:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://tapahtumat-pr273.dev.hel.ninja :crying_cat_face::anger::boom::boom:

TestCafe result is success for https://liikunta-pr273.dev.hel.ninja :laughing::tada::tada::tada:

It seems like there are some issues with the ErrorBoundary still, but they have been there also before the changes done in this pull request

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr273.dev.hel.ninja :rocket::rocket::rocket:

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://harrastukset-pr273.dev.hel.ninja :laughing::tada::tada::tada:

Sports-Helsinki branch is deployed to platta: https://liikunta-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://tapahtumat-pr273.dev.hel.ninja :crying_cat_face::anger::boom::boom:

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://liikunta-pr273.dev.hel.ninja :laughing::tada::tada::tada:

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr273.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is failed for https://tapahtumat-pr273.dev.hel.ninja :crying_cat_face::anger::boom::boom:


Added a powershell example for the key in service endpoint cli

@ShachafGoldstein : Thanks for your contribution! The author(s) have been notified to review your proposed change.


chore(dropdown): add more unit tests

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


TS is Stripping Trailing "OneOfType" Types from Storybook Docs

In the following example, declaring label: React.ReactNode | string; in the interface will result in the following output in Storybook, leading the consumer to believe that the prop only accepts a node.

 Typescript props not matching proptypes


fix(sql): Sort columns alphabetically so that it works properly

There's a very specific bug with this library - the DO UPDATE SET part of the generated query has the fields ordered as the user specified them, whereas the replacement is set based on the key (i.e. they're alphabetically ordered).
This PR just fixes that bug, plus makes that subset of the code slightly more maintainable.
I am not entirely sure if this has introduced another bug or not, but it seems to work so it's probably fine.

As a side effect, the order of fields should now be irrelevant. Yay for usability!

Thanks, could you also add some kind of test-case scenario, so we can track changes related to this part of impl? :)

https://github.com/reposilite-playground/exposed-upsert/blob/main/src/test/kotlin/net/dzikoysk/exposed/upsert/spec/UpsertSpecification.kt

I guess this is related to #6

It most likely is related, at a guess.
I added a test case for it (although I'm unsure if it's correct or not), which makes all records in statisticsRepository have a count equal to one and have any xyz in their URI substituted with abc.

Looks like the test failed on CI for SQLiteUpsertTest 🤔

java.lang.ArrayIndexOutOfBoundsException: Index 4 out of bounds for length 4

I debugged the code I wrote and I realised the problem: update statements cannot update any key in indexColumns, which caused a problem when I tried to update uri.

Thanks! Sorry for late response, I'm slightly busy lately 😅 I'll release 1.2.0, so it should be available within an hour on Maven Central :)


feat: Upgrade to angular 8

Hi, since https://github.com/manfredsteyer/angular-oauth2-oidc/pull/568 is pretty difficult to merge from the lot of changes, i tried an upgrade to Angular 8 minimizing the changes.
I have tested it with a local registry (Verdaccio) and it is working for me with Angular 8.0.2.
Thanks

thx


Update sbt-mima-plugin to 0.9.0

Updates com.typesafe:sbt-mima-plugin from 0.8.1 to 0.9.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe", artifactId = "sbt-mima-plugin" } ]

labels: sbt-plugin-update, semver-minor

Significant Changes

    Ignore package private classes #53 / #583 by @dwijnand
    Initial Scala 3 support (i.e. make the existing test suite pass when using the Scala 3 compiler) #587 by @dwijnand

Less Significant Changes

    source change necessitated by upcoming 2.12.13 change #580 by @SethTisue
    Get latest sbt-extras #605 by @dwijnand

lgtm


Better way to type a string property as a union of string subtypes?

Hi, I don't know if I'm missing something and there's already a less boilerplatey way to do this, than my workaround below?
I have type Status = 'shipped' | 'processing'; and a field:
@Fields.string({allowNull:true})
status?: Status | null = null;

This gives me a Type error: Type 'string' is not assignable to type '"shipped" | "processing" | null | undefined'
My workaround required using the object field type with a valueConverter that just prevents it from being converted to JSON:
  @Fields.object({
    allowNull: true,
    valueConverter: { fromDb: (val) => val || null, toDb: (val) => val || null }
  })
  status?: Status | null = null;

Hi @SpeedoPasanen I tried this in code sandbox and it seems to work well - checkout:
https://codesandbox.io/p/devbox/brave-roentgen-lsdrjp?file=%2Fsrc%2Fshared%2Ftask.ts
I do have some more features planned around this, but I didn't run into the problem that you've run into.
Can you create a small reproduction with the issue you had so that I can see it?
import { Entity, Fields } from "remult";

export type Status = "shipped" | "processing";

@Entity("tasks", { allowApiCrud: true })
export class Task {
  @Fields.cuid()
  id = "";
  @Fields.string({ allowNull: true })
  status?: Status | null = null;
}

Actually now that I try again, I never got a build error, just VSCode intelli.
 Maybe it's something in this:
module.exports = {
    parser: "@typescript-eslint/parser",
    parserOptions: {
      project: "apps/api/tsconfig.json",
      sourceType: "module",
    },
    plugins: ["@typescript-eslint/eslint-plugin"],
    extends: [
      "plugin:@typescript-eslint/recommended",
      "plugin:prettier/recommended",
    ],
    root: true,
    env: {
      node: true,
      jest: true,
    },
    ignorePatterns: [".eslintrc.js"],
    rules: {
      "@typescript-eslint/interface-name-prefix": "off",
      "@typescript-eslint/explicit-function-return-type": "off",
      "@typescript-eslint/explicit-module-boundary-types": "off",
      "@typescript-eslint/no-explicit-any": "off",
    },
  };

Unable to resolve signature of property decorator when called as an expression.
  Argument of type 'ClassFieldDecoratorContext<Party, "locked" | "visitedOpen" | "visited" | "makingOrder" | "ordered" | null> & { name: "status"; private: false; static: false; }' is not assignable to parameter of type 'string | ClassFieldDecoratorContextStub<Party, string | undefined>'.
    Type 'ClassFieldDecoratorContext<Party, "locked" | "visitedOpen" | "visited" | "makingOrder" | "ordered" | null> & { name: "status"; private: false; static: false; }' is not assignable to type 'ClassFieldDecoratorContextStub<Party, string | undefined>'.
      The types of 'access.set' are incompatible between these types.
        Type '(object: Party, value: "locked" | "visitedOpen" | "visited" | "makingOrder" | "ordered" | null) => void' is not assignable to type '(object: Party, value: string | undefined) => void'.
          Types of parameters 'value' and 'value' are incompatible.
            Type 'string | undefined' is not assignable to type '"locked" | "visitedOpen" | "visited" | "makingOrder" | "ordered" | null'.
              Type 'undefined' is not assignable to type '"locked" | "visitedOpen" | "visited" | "makingOrder" | "ordered" | null'.

I think I know what it is - and it's probably a bug, I'm looking into it now.
My guess is that in the tsconfig used by vscode to check this file,  you do not "experimental" decorators - and it tests the decoratos based on ts5 decorators (that are not yet supported by many esbuild tools) and it does an extra type check.
Let me work somethong out and get back to you

@SpeedoPasanen we've added a built-in field type for it called @Fields.literal
https://remult.dev/docs/field-types.html#literal-fields-union-of-string-values
Checkout the latest version - https://github.com/remult/remult/releases/tag/v0.26.0


Feature: Normalization API

Problem
When building a text editor, it's common to want to enforce some normalizations and constrains, e.g. merging adjacent lists together, disallowing certain heading levels, or establishing a max indentation for some blocks. Currently, in Lexical, some of these constrains can be enforced with techniques like registering node transforms, editor update listeners or commands that undo or modify certain updates before they happen.
However, there are some fundamental problems with this approach that make it a leaky and incomplete solution:

Registering a command works as long as all plugins use that command for a certain operation (e.g. insert a heading node), but that's not the case. For example, some transforms in the markdown shortcuts plugin don't use these commands, and therefore the updates are allowed.
Normalization isn't always required only on updates, sometimes you'll want to apply it on the initial state, which AFAIK doesn't fire commands or node transforms.
Having to take into account these many APIs for each normalization is tedious and prone to bugs, and it's easy to miss some instances.
In some cases, it's also necessary to enforce these constrains outside of the lifecycle of the editor itself, for example in the server when storing a lexical state in a database. Ideally the headless package could be used to run the normalization server-side.

Proposal

Implement a proper normalization API like Slate's: https://docs.slatejs.org/concepts/11-normalizing
This could be very useful, even for core plugins and built-in constrains, see related comment: https://github.com/facebook/lexical/issues/2800#issuecomment-1221143560
A highlight of this API is the multi-pass system that makes it easier to write constrains: https://docs.slatejs.org/concepts/11-normalizing#multi-pass-normalizing

cc @acywatson

Related https://github.com/facebook/lexical/issues/1338

Lexical already normalizes basic text nodes. We could expose a way for user controlled normalization too. However, I feel the better approach is to improve the scheme of nodes, in that plugins and core better align with methods that define hierarchy or relationships between types of nodes and their position in the tree.

@trueadm not sure what that would look like, and what the difference would be with a normalization API?

@trueadm not sure what that would look like, and what the difference would be with a normalization API?

I think this is sort of the crux of it - there isn't much of a difference, save for whether the logic is centralized in one place or spread across and encapsulated within individual node classes. Historically, we have tended towards the latter, enforcing a sort of proto-schema via methods on the node base classes that define their behavior with respect to each other.
The issue with that setup is that these methods are just called all over the place in different modules and utilities, making it hard to reason about the actual behavior in different scenarios. It can also be hard to debug - I see this come up a lot on discord. The alternative, more "imperative" approach of defining a schema centrally and having it enforced consistently in a single place ameliorates that, but comes with it's own trade-offs, I guess.

We plan on incorporating normalization into schemas. Closing for now.

@trueadm is there information about schemas anywhere that I could check? Link? :pray:

@DaniGuardiola Not right now. Bear with us, we're still exploring this space before sharing it widely.

Curious if there is an indication on when this might be availlable. Is this part of a roadmap?


Icon position question

I've seen tripnary has the title and body on top of the icon. Is that custom dev work they did or do you support that?

Yeah I believe that involved some modifications on their end.

Thanks!

Yes it did @jugutier let me know if you have any questions!


Add coinmarketcap max rank "requirement" to Altrank

Is your feature request related to a problem? Please describe.
Currently I'm using the Altrank script. But there are also pairs like "SPELLBUSD" for example that only exists since 7-12-2021.
I don't want to have those kind of coins because they can go "to zero".
I think when we add an extra filter to the coin selection, for example Coinmarketcap rank < 150 then we can assume that they don't go to zero because of the total marketcap.
Describe the solution you'd like
What I described above. Since we already have the API around. I hope it can be easily added to the lunarcrush_pairs function where we also check for volume, altrank rank etc.

Do you mean the cmc ranking value is in the lunarcrush data, or using the seperate data from coinmarketcap? The last one means we need to make it optional.
A bit short on time to check lunarcrush data set, so any help is welcome :)

I'm looking for the same feature as well. The script now chooses the coins based the altrank value and then the top x coins. What I would like to see is that it also chooses those coins, but then only if they are in the top x of the coinmarketcap order. So that a coin in the altrank is number 1, but in the coinmarketcap number 5000 i.e. that it wouldn't added that coin to the bot.

For this to work, the different datasets need to be combined. So input from Altrank, GalaxyScore, CoinmarketCap ed needs to be collected, and then the user should be able to put in some configuration to get the desired list of pairs as output.
As these are currently all seperate scripts, and we have a lot of other requests/stuff already going on, it's not something I see happening in a short timeframe. Yes, I understand the value and it would be a good addition. Time however....