Fix oneof primitive types decoding

This PR Fixes #1608

I checked Test_Merge and realized that it works with oneof fields. So I think the problem is my own code (which I was using decoder for capturing values in #1505).
I think we can close this PR and its related issue as my problem solved with changing my code implementation and without any necessary addition in generated codes.


[CALCITE-786] Enhancing detection of MV to rewrite queries.

This is first submission for CALCITE-786. As seen in UTs added it can handle many interesting cases now. There are still many cases which needs to be handled though and we will get to that soon in future. Submission introduces basic structure now which will enable us to extend it in future:

New Substitution visitor (MaterializedSubstitutionVisitor) which introduces rules for rewriting queries in non-trivial cases. Currently one rule is introduced and it can be extended by adding more rules as and when required.
RexImplicationChecker. This checks if one condition implies another and is the basis of the algorithm. This now handles few kind of operators and datatypes. It can be easily extended for more.

Hi Julian,
I have take care of all your comments.
MVSubstitutionVisitor has been added old rules of substitution, thus we would can only the new visitor now.
However, we did not see any test failures, nor were there any build failures (not just me but even others who are using this code in our fork). But if the test is still failing for you, then we can @Ignore it as it only depicts false positive which can be worked on and not the false negative.
Thanks,
Amogh


[FEATURE] PR Template in .yml format

Description
Pull Request Template means when someone opens a Pull Request, they will have a template that they can edit making it easier for maintainers of the project to review PR and make sure that no PR is submitted without proper description.
Screenshots
No response
Additional information
No response

@Rakesh9100 Please assign me this under GSSoC 23

Low priority issue, but will be good addition tbh.
Thoughts @Rakesh9100 ?

PR template is already present. Pls work on other issues.


Signup feature

I have finished the signup feature I promised.  Please review and merge if happy!  If you have any questions you can contact me anytime<EMAIL_ADDRESS>

@runia1 I am cleaning up some old Pull Requests here.  Looks like this one targets the old SDK, which is so different from the new one that I'm not sure this PR could be saved without a huge amount of work.
Thank you for your contribution, we really appreciate when people take the time to send PRs.  if you want to pursue this going forward, start the conversation in an issue and we can decide how to proceed.


Custom CRS Problem

We have created a custom CRS where the pixel “x” direction is not aligned with the Latitude direction.
As a result, we have found two places (so far) where this causes a problem including the Map.fitBounds function and when instantiating the L.Circle class.
We believe these break down because these functions assume Latitude and pixel “x” are in the same direction.
Is this an implicit assumption in the CRS support?

The CRS/projections code is a bit big and I cannot remember all of it right now, but it's certainly possible that such assumptions occur throughout the code.
If you could share your custom CRS and some of the cases that make the problems show up, that'd be much more helpful, as we could trace the code and have a proper look at the problem.

I know that Leaflet is used with projections where the X axis isn't aligned with latitudes, so it should work in general, although there might of course be places where this is a problem. An example of the issues you're seeing is best, like @IvanSanchez says.
In general, anything involving LatLngBounds (like fitBounds) can be problematic with such projections, since the bounds of a dataset in lat/lng space no longer necessarily correspond to the same bounds in projected space. This is the downside of the otherwise handy/elegant convention of using lat/lng throughout the API.

Expanding on the two examples I referenced in my initial post:
Line 82 and 83 of Circle.js:
this._radius = isNaN(lngR) ? 0 : Math.max(Math.round(p.x - map.project([lat2, lng - lngR]).x), 1);
this._radiusY = Math.max(Math.round(p.y - top.y), 1);
In line 82, it takes a vector in the Longitude direction and assumes the x component of it gives the entire length. When this is not true, the circle radius comes back as too small.
Line 787 of Map.js
boundsSize = L.bounds(this.project(se, zoom), this.project(nw, zoom)).getSize(),
The rotated bounds would be determined by the minimum and maximum x,y coordinates. This line assumes the SouthEast and NorthWest corners are the extreme points which might not be true after rotation.

@marioatmicello ok, yes I see the problem with the circle implementation, and you're correct in your initial observation that there are places where Leaflet is still a bit too closely tied to its default projection.
As I see it, there's no way to calculate a circle's radius for a generic CRS without more information about it, and in fact the current implementation is only an approximation even for the default CRS - a circle on the round surface of the earth will not project to an actual circle in mercator, although the result is close for small radii.
Long term, we could improve this by delegating the radius calculation to the CRS instance, to make it possible to override its implementation, but this will not help you right now. A workaround would be to create your own circle class with a better radius calculation for your CRS.
The other example is what I talked about earlier: extreme points in lat/lng space will not map to extreme points in projected space for arbitrary CRS, so bounds calculations with Leaflet's lat/lng API will not work for these. I don't see how we could fix this without at the same time imposing more complexity/worse performance for the common use case (transforming bounds from one CRS to another is complex).
What could be improved is the documentation of this fact and how you can work around it. It might even be possible to write a plugin to make working with this easier.

@perliedman Thanks for your thoughtful response. You were most helpful. We see the same issues as you have outlined here. We are going to investigate using other CRS (like, potentially, Game) to figure out how to offer rotation. We might revisit our custom CRS in the future as we have learned quite a bit.

When CRS did not use CRS.EPSG3857 ,the _containsPoint() count is wrong. It not consider radiusY.


updating podspec for tvos

Recent branches of CocoaPods support tvos as a platform:
CocoaPods/Core#263

Added already =)


Add an ability that notification-observer know which reachability it belongs

there exists one problem [AFNetworkReachabilityManager shareManager] is singleton，but it also support that create other AFNetworkReachabilityManager by method ‘managerForDomain’ or ’managerForAddress‘. the two case is opposite.
so if network change, trigger posting AFNetworkingReachabilityDidChangeNotification , receiver can not know which is the actully sender，it will get multiple notification，then the receiver notification method would call multiple times, maybe cause continuously unexpectedly result.

Codecov Report

Merging #4248 into master will decrease coverage by 0.03%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #4248      +/-   ##
==========================================
- Coverage   87.75%   87.72%   -0.04%
==========================================
  Files          46       46
  Lines        5732     5734       +2
==========================================
  Hits         5030     5030
- Misses        702      704       +2

Impacted Files
Coverage Δ

AFNetworking/AFNetworkReachabilityManager.h
100% <ø> (ø)
:arrow_up:

AFNetworking/AFNetworkReachabilityManager.m
76.19% <71.42%> (-1.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009e3bb...06079ad. Read the comment docs.

@SlaunchaMan  ~ has update

@SlaunchaMan ~ has update,


Project wide code cleanup: Fix all SA1401 occurrences + copyright header consistency

Fixes #2826

Pull Request Test Coverage Report for Build 85473

0 of 0   changed or added relevant lines in 0 files are covered.
249 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.2%) to 76.561%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.Dialogs/DialogContainer.cs
1
85.71%

/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/BotFrameworkHttpAdapter.cs
17
46.9%

/libraries/Microsoft.Bot.Builder/Streaming/BotFrameworkHttpAdapterBase.cs
41
36.05%

/libraries/Microsoft.Bot.Builder/BotFrameworkAdapter.cs
190
39.18%

Totals

Change from base Build 85466:
-1.2%

Covered Lines:
8424

Relevant Lines:
11003

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


More explicit error message when missing .d.ts files

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Bumping the package due to the https://github.com/egoist/rollup-plugin-esbuild/issues/27 , was failing the CI build


When using keras, it writes all executions in same graph 'training'

Directory path is hardcoded as 'training', right?
training_log_dir = os.path.join(log_dir, 'training')

I just rewrote the init method for that. It's a really simple fix but it helps a lot when comparing executions.
class TensorBoardColabCallback(TensorBoard):
def init(self, tbc=None, write_graph=True, name=None, **kwargs):
# Make the original TensorBoard log to a subdirectory 'training'
    if tbc is None:
        return

    log_dir = tbc.get_graph_path()

    training_log_dir = os.path.join(log_dir, 'training_{}'.format(name))
    super(TensorBoardColabCallback, self).__init__(training_log_dir, **kwargs)

    # Log the validation metrics to a separate subdirectory
    self.val_log_dir = os.path.join(log_dir, 'validation_{}'.format(name))


[WIP] some bug fixes and required basic functionalities

Why we need this PR
Setting this operator for a community release, mainly focusing on it's integration with NHC
Changes made

use NHC timeout remediation
adding permissions for NHC to it's remediation and template
fixing generation of label name
extra logs
leftover name changes

Which issue(s) this PR fixes
there is no issue capturing these changes
Test plan

/test ?

/test openshift-e2e


Performance

For now we're only doing async in the scans and it hardcoded to make 10 requests in parallel, to avoid problems (ie: open too much sockets). We have to research on it, implement a timer in the modules and compare it with Nmap, SIPVicious and MassCan.

This is done in wushu, not here.


DS Campaign: Move query functions into inc file

Open to discussion, but there are so many campaign query type functions in the dosomething_campaign.module. Thinking of adding a file like dosomething_campaign.query.inc or a similar name, to house all these functions here:

[ ] _dosomething_campaign_get_recommended_base_query
[ ] _dosomething_campaign_get_recommended_query_nids
[ ] dosomething_campaign_get_recommended_published_nids
[ ] dosomething_campaign_get_recommended_staff_pick_nids
[ ] dosomething_campaign_get_recommended_nids_by_term
[ ] dosomething_campaign_get_recommended_campaign_nids
[ ] dosomething_campaign_get_staff_picks
[ ] dosomething_campaign_get_scholarships

@weerd did this with reportbacks, it's much cleaner


Darwin - Add pam_reattach.so to sudo file

Describe the bug
The pam-reattach module for darwin does not work without more configuration. In particular, the following line must be added to /etc/pam.d/sudo:
auth       optional       /path/to/pam_reattach.so

Currently, I mitigate this with:
  # Hack to make pam-reattach work
  environment.etc."pam.d/sudo_local".text = ''
    # Written by nix-darwin
    auth       optional       ${pkgs.pam-reattach}/lib/pam/pam_reattach.so
    auth       sufficient     pam_tid.so
  '';

However, it is probably better done natively and like pam does:
https://github.com/LnL7/nix-darwin/blob/550340062c16d7ef8c2cc20a3d2b97bcd3c6b6f6/modules/security/pam.nix#L24-L36
Steps To Reproduce
Steps to reproduce the behavior:

Enable pam: security.pam.enableSudoTouchIdAuth = true;
Add pam-reattach

Expected behavior
pam-reattach should work without any more configuration
Additional context
This is because pam-reattach is never inserted into the sudo authentication system. See https://github.com/fabianishere/pam_reattach?tab=readme-ov-file#usage
Notify maintainers
@lockejan
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.2.0, macOS 14.2.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Describe the bug
The pam-reattach module for darwin does not work without more configuration. In particular, the following line must be added to /etc/pam.d/sudo:

auth       optional       /path/to/pam_reattach.so

Currently, I mitigate this with:

  # Hack to make pam-reattach work

  environment.etc."pam.d/sudo_local".text = ''

    # Written by nix-darwin

    auth       optional       ${pkgs.pam-reattach}/lib/pam/pam_reattach.so

    auth       sufficient     pam_tid.so

  '';

However, it is probably better done natively and like pam does:
https://github.com/LnL7/nix-darwin/blob/550340062c16d7ef8c2cc20a3d2b97bcd3c6b6f6/modules/security/pam.nix#L24-L36
Steps To Reproduce
Steps to reproduce the behavior:

Enable pam: security.pam.enableSudoTouchIdAuth = true;

Add pam-reattach

Expected behavior
pam-reattach should work without any more configuration
Additional context
This is because pam-reattach is never inserted into the sudo authentication system. See https://github.com/fabianishere/pam_reattach?tab=readme-ov-file#usage
Notify maintainers
@lockejan
Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"

 - system: `"aarch64-darwin"`

 - host os: `Darwin 23.2.0, macOS 14.2.1`

 - multi-user?: `yes`

 - sandbox: `no`

 - version: `nix-env (Nix) 2.18.1`

 - channels(root): `"nixpkgs"`

 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Hey, you are right about the current state of pam-reattach, but pkg configuration should be part of nix-darwin not nixpkgs anyway. There have been several attempts made to add such to nix-darwin, but nothing that enough people could agree on. I can't recall the exact issues and PRs in nix-darwin. Sry.
If you'd like to push this topic, I'd suggest you do so in the nix-darwin repo.✌


Python file icon

(not really sure if this is a bug)
Describe the bug
The Atom .py file icon doesn't show in the file explorer.
To Reproduce

Install the plugin
Done.

Expected Behavior
I thought that the Atom icon would display in the file explorer as well.
Environment

OS: Windows 10
Plugin version: Most recent as of 2/5/2021
Screenshots
Right now this is what shows:

Strangely, in the tabs, the Atom python icon shows just fine:

Hey! So I have a quick work around at the moment (I think).
Download doki-theme-jetbrains-12.5.3.zip and install it manually using
Preferences > Plugins > ⚙ > Install plugin from disk...
That should work. JetBrains is changing how they load classpath resources, so something is amiss when I built it with the latest platform SDK.

BTW, it's bugging me that i cant tell if you are using Ishtar's or Darkness's theme :sweat_smile:

Uh, I think ever since I installed it the icon doesn't seem to show.
(also this is darkness's theme)

@SansPapyrus683
Thanks for the update!  If you want, you could probably install https://github.com/mallowigi/a-file-icon-idea . It is maintained by somebody who actually uses that feature, so it might not have this issue :smile:
Just to manage your expectations, I'll see what I want to do with this issue after I finish adding more themes https://github.com/doki-theme/doki-master-theme/milestone/2 (as if I don't already have enough). So I'll probably get around to this sometime when I am also ready to work on #324 . Thanks for your patience and understanding! (Also thanks solving the mystery theme for me too! I thought it might be Darkness, but wasn't sure :)

I think this issue got fixed with the newest release, so I'll close it.

:thinking: It still an issue but it is not an issue with Material Atom Icons.
Doki File Icons

Material Atom Icons

When I work on the new set of themes this month, I'll see if I cant fix this feature (Removing it is also a fix :smile: )


Crash when opening Crafting Grid

Issue description:
When I go to open the Crafting Grid to get something out it CTDs. Not sure if it's you or Galacticraft 4, the first 2 lines mention them and the next several mention you and it is only when I go to view the crafting grid that it CTDs. https://github.com/micdoodle8/Galacticraft/issues/2868 - The same issue on the GC 4 github.
What happens:
When I go to open the Crafting Grid to get something out it CTDs.
What you expected to happen:
To not CTD when opening the Crafting Grid but show me my items in storage
Steps to reproduce:

Load up Minecraft
Load up my world
Open Crafting Grid
...

Version (make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: 1.10.2-<IP_ADDRESS>6
Refined Storage: 1.2.26

Does this issue occur on a server? [yes/no]
No idea, I am playing single player.
If a (crash)log is relevant for this issue, link it here:
[https://pastebin.com/Bc1usRNh]

It's Galacticraft.

Ok, so, in the above issue posted to here and Galacticraft, you both blame the other mod. So. They say your mod is broken, you say their mod is broken. Would someone please figure out the problem and fix it, I really don't care who. :( To quote the above linked issue -
" It's not a bug in our mod! It's something wrong with the item.
Refined Storage is attempting to draw a Tier 1 Rocket item with an item damage value of 7.
That's a damage value which doesn't exist for Galacticraft rockets. There is no way that Galacticraft can make that item, and you won't find it in JEI for example. For rockets, the allowed damage values are 0 through 4 only. "

Yeah RS doesn't do that on its own, I guess your some external mod inserted an invalid stack in the RS system.

So how do I find it? Since I've crafted nothing for GC4, can't be that. I can't even get into the Crafting Grid with out a CTD so I've been unable to do anything. :( I mean, I might be able to narrow it down to one of the drives as long as what ever it is is contained in one drive and not scattered across two or three. But if viewing that one drive is going to cause a CTD then how do I know what item in that drive is the issue? O.o

Remove drives until you no longer have the crash.

Right, that's what I am saying, but once I find the drive, how do I find what is in that drive is the problem? O.o

The crash happens on a ItemTier1Rocket. Black-list that with compare NBT and damage off.

Ok, so, no idea what it was, but I backed up my world, uninstalled GC4, reloaded the world, clicked "Yes" to the "Missing Blocks" , went over everything to find all invalid patterns (I had Advanced Rocketry installed before but decided to switch to GC4, a better documented mod. >.< ) that I might have missed when I removed all the AR items from the game prior to uninstalling AR, shut down, reenabled GC4, and it seems stable so far. Freaking weird. I could have sworn I uninstalled AR and loaded my world before installing GC4 to be sure everything AR related was gone. O.o


Improve error messages when transformer plugins fail to load

What steps will reproduce the problem?

Create two projects A and B
B depends on A
Create a transformer in project A
Add it to B's pubspec.yaml
'pub serve' project B

What is the expected output? What do you see instead?
Expecting 'pub serve' not to crash. Instead, it crashes (stderr output from pub --trace 'serve' attached).
What version of the product are you using? On what operating system?
barback 0.11.1
Tried two Dart VM versions:
1.3.0-dev.0.0 (Wed Feb 26 07:39:42 2014) on "macos_x64"
1.2.0-dev.5.15 (Mon Feb 24 02:12:58 2014) on "macos_x64"

Attachment:
barback-sterr.log (146.37 KB)

This issue has been moved to dart-lang/pub#896.


flag provided but not defined: -test.timeout

What version of Go are you using (go version)?

$ go version
go version go1.13rc1 darwin/amd64

Does this issue reproduce with the latest release?
Yes, on the release candidate but not on Go 1.12.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOOS="darwin"

What did you do?
Wrote a small test for code which contains flags being parsed inside an init function. All the test does is t.Skip().
foo.go:
package main

import (
	"flag"
	"fmt"
)

var foo string

func init() {

	flag.StringVar(&foo, "foo", "foo", "foo")
	flag.Parse()
}

func main() {
	fmt.Println("vim-go")
}

foo_test.go:
package main

import "testing"

func TestFoo(t *testing.T) {
	t.Skip()
}

What did you expect to see?
No errors.
What did you see instead?
➜  flag-test go test
flag provided but not defined: -test.timeout
Usage of /var/folders/c_/zhpj7wdd3dgb52c4zpy3vj840000gn/T/go-build238457999/b001/flag-test.test:
  -foo string
    	foo (default "foo")
exit status 2
FAIL	_/Users/shawn/flag-test	0.005s

See the Go 1.13 release notes:

Testing flags are now registered in the new Init function, which is invoked by the generated main function for the test. As a result, testing flags are now only registered when running a test binary, and packages that call flag.Parse during package initialization may cause tests to fail.

Duplicate of #31859


curious about camera parameters

I find cameras_hd.npz in your data  is different from MVSnet or VIs-Mvsnet, can you tell me how do you generate camera.npz ?

Hi @MaybeOjbk, we follow the IDR convention: https://github.com/lioryariv/idr/blob/main/DATA_CONVENTION.md
The world_mat is just the composition of the intrinsic and extrinsic, and scale_mat controls the bounding box that you might need to determine for each scene

OK，thanks a lot, but I have few questions about evaluation.

when you run eval.py you can get generate mesh, and how to get chamfer distance ? Do I need to sample points from mesh and then run your scripts? and also we don't need to calculate points that far from gt points, (there may be threshold when calculate chamfer distance).
Do you know how to use colmap to generate mesh? Is there any scripts we can use ?
After using colmap to generate mesh, do I need some post-process such as  alignment  to align mesh from colmap and gt point cloud?

You can use DTU's official matlab code or my evaluation code (https://github.com/jzhangbs/DTUeval-python). Both support mesh inputs
(and 3) You can use the given cameras to do sfm and mvs in colmap (https://colmap.github.io/faq.html#reconstruct-sparse-dense-model-from-known-camera-poses). The result should also be aligned with the ground truth

thanks a lot,

After using your code, I found the score is much more worse than your reported, after I use trimesh.sample.sample_surface, and I sample around 10 millions points in mesh, then I get close scores. But I have another question about  NeuS(if you know) which trained without mask, how to evaluate the mesh without mask (have superfluous meshs such as the white plane )？ And in your paper, I have noticed you use mesh cut to cut these unnecessary meshes

The reported numbers are from the trimmed meshes, while the others (like NeuS) directly evaluate the untrimmed ones. Our follow up work RegSDF (https://arxiv.org/abs/2206.03087) also evaluate the untrimmed mesh. But all these experiments use mesh sampling from official evaluation script or my re-implementation, you do not need to manually do that.


First PR allowing to have custom yaml paths as well as supporting default paths

Addresses #5

That's needed to have support for multiple manifests in one branch, as you can see here #4
We immediately need it for ffmpeg, webkitgtk and the eclipse snap

I see two different functionality types:

A heuristic that searches all default paths (the default option) https://github.com/snapcrafters/ci/issues/5
Custom path as an optional input (for repos that have multiple snaps in a single repo) https://github.com/snapcrafters/ci/issues/4

I think we need to support both. This will also make it easier to, for example, create a repo that tracks snapcraft updates and builds all our snaps to test the new snapcraft version.

Yup, we're doing the changes

Done


Timezone Errors in Unit Tests

Unit tests are failing, apparently related to timezones https://github.com/NeonGeckoCom/skill-date_time/runs/6033022688?check_suite_focus=true

Possibly related to https://github.com/NeonGeckoCom/neon-utils/pull/438 ?


Chrome RDP fails to connect

I am trying to connect to xrdp from my chromebook and it is failing on the connection.  It looks like something is happening near this part:
Sat Dec 17 16:37:51 2016 - RdpManager::ReceiveDemandActivePdu()
Sat Dec 17 16:37:51 2016 - DemandActivePdu::Parse Unknown Capabiliy Set;
Sat Dec 17 16:37:51 2016 - Did not receive DemandActivePdu
Sat Dec 17 16:37:51 2016 - ChromerdpInstance::RdpManager_Status() status -1
Sat Dec 17 16:37:51 2016 - ChromerdpInstance::RdpManager_Status Failed
Sat Dec 17 16:37:51 2016 - ChromerdpInstance::UserModal(UserInputModal* modal, bool sendMsgPopUpClose)
Sat Dec 17 16:37:51 2016 - ChromerdpInstance::CloseConnection()
Sat Dec 17 16:37:51 2016 - RdpManager::CloseConnection()
Sat Dec 17 16:37:51 2016 - Closing socket connection...

I have attached the full log:
rdp_log.txt
I can confirm that mstsc and freerdp work properly.

ChromeRDP is another client that doesn't support drawing orders (like MS RDP client for Android).
That means xrdp should be built using ./configure --enable-painter.
Additionally, I found the following problems which causes ChromeRDP client drop the connection:

xrdp doesn't advertise TS_VIRTUALCHANNEL_CAPABILITYSET which considered a mandatory cap set.
we advertise some non-Microsoft cap set, ChromeRDP drops the connection when getting unknown caps.
we send an incorrect TS_FP_UPDATE_SYNCHRONIZE pdu, I can push a fix.

Regarding 1+2: In my opinion its more of an ChromeRDP issue, since the server is not assumed to support those caps by protocol. Also, any other clients is fine with that - client should assume its unsupported / use default values.
Iv'e pushed a branch which contains the necessary changes for ChromeRDP to connect; Feel free to test it. (https://github.com/speidy/xrdp/commits/chromerdp)

I think 2 is defensible and I can submit a bug report to them.  Since 1is considered a mandatory cap set I think that they will not fix that one.

Number 3 is fixed now.
pushed the fix to devel a96c91b38e68e189e6861dfdf3df5852881ad470

This seemed to work for a long time but has broken again.  I had not used their app lately, so I don't know when it regressed.  The dying wish from chromerdp is:
min.js:155 Thu Apr  4 20:14:55 2019 - DemandActivePdu::Parse Unknown Capabiliy Set;
min.js:155 Thu Apr  4 20:14:55 2019 - Did not receive DemandActivePdu``` I am also trying a support ticket with them, but it seems they are not so responsive.

Is this still an issue?


3.0 test

just checking
ref #5829

Coverage remained the same at 92.196% when pulling 217e492ef64b81b2c560ad0058be5769f252b160 on keradus:3.0_test into 26e17c4386952ad301f7fdc367ca7dbb83138d49 on FriendsOfPHP:3.0.


Interstate 84

Topic: Interstate 84  is an Interstate Highway in the Northeastern United States that extends from Dunmore, Pennsylvania to Sturbridge, Massachusetts.
Folder Location: taxonomy/knowledge/geography/highways/interstate_84
Downloads:

qna.yaml: interstate_84.txt
attribution.txt

Wiki link: https://en.wikipedia.org/wiki/Interstate_84_(Pennsylvania–Massachusetts)

taking


Breaking changes not documented

The Flux project had a hard time today bumping go-gitlab to its latest version because https://github.com/xanzy/go-gitlab/commit/f49ba027968b5a34c4f925e885c91a09e50a16df apparently broke the API as the original HTTP error isn't returned anymore.
I would like to start a discussion on documenting such breaking changes somewhere going forward. Many projects do this in the release notes, others in a dedicated CHANGELOG.md file.

Hi @makkes, I'm sorry this change caused issues for you 😞
I fully understand its not cool to ship breaking changes without people being able to easily see what changed so they can update the relevant bits without having to investigate issues themselves.
So I'm open to start using releases instead of just tags and add some bits to indicate any breaking changes that might be in that release. Hope that will improve things going forward...

I'm not 100% sure I got all the breaking changes in the v0.108.0 release, but will try to keep track of any breaking changes that are getting merged from now on...

Thank you so much @svanharmelen!


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
0a5cc32 -> a1178ba

github.com/gruntwork-io/terratest
require
patch
v0.43.6 -> v0.43.9

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.10.8 -> v1.10.13

Release Notes

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.43.9
Compare Source
Modules affected

test-structure

Description

Added function SaveTerraformOptionsIfNotPresent

Special thanks

Special thanks to the following users for their contribution!

@bt-macole

Related links

https://github.com/gruntwork-io/terratest/pull/1319

v0.43.8
Compare Source
Modules affected

terraform

Description

Added public ParsePlanJSON function to terraform module.

Special thanks

Special thanks to the following users for their contribution!

@mdb

Related links

https://github.com/gruntwork-io/terratest/pull/1309

v0.43.7
Compare Source
Modules affected

azure

Description

Added support for Azure SQL Managed Instance

Special thanks

Special thanks to the following users for their contribution!

@sweanan

Related links

https://github.com/gruntwork-io/terratest/pull/1307

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.10.13
Compare Source
Bug Fixes

deps: update gomod (#584) (faa3056)

v1.10.12
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.41.0 (#582) (77a309d)

v1.10.11
Compare Source
Bug Fixes

deps: update module github.com/gruntwork-io/terratest to v0.43.8 (#581) (5b1468a)

v1.10.10
Compare Source
Bug Fixes

fixed a bug in upgrade test (#579) (8d18919)

v1.10.9
Compare Source
Bug Fixes

deps: update module golang.org/x/crypto to v0.11.0 (#578) (7d3a4ef)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add aws secret and pass id & key to worker as env. vars

See packit/packit-service#1325

recheck

The ansible-lint passes for me locally. Merging and will debug it in another PR :-)


[PDI-18303] Transformation Step: Get Sub folder names fails to retrie…

…ve any folders if user does not have access to a sub folder
@pentaho-lmartins @ssamora @bcostahitachivantara

:white_check_mark: Build finished in 23m 34s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 5018, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Make it possible to read from a file like object

and not just a file on a path.

Agreed!

Closed via #231.


Wash the face of the C decoder

As requested by the almighty @tmm1.
I added a thousand internal consistency checks (mostly type checking, buffer overflows & tuple arity), and made it slightly faster to offset the time wasted on extra checks (god forbid us from running slow code).
Worth noting is the new bignum decoding, which is 300x times faster thanks to internal serialization!
Love and ponies.

:metal:


Upgrade dependencies

Coverage remained the same at 97.552% when pulling a79d5df2719c4bfca69c2797577b0413f793d074 on upgrade-dependencies into 073f36df2259270689ebe5bd582e2a191f0dbb59 on develop.

Coverage remained the same at 97.552% when pulling a79d5df2719c4bfca69c2797577b0413f793d074 on upgrade-dependencies into 073f36df2259270689ebe5bd582e2a191f0dbb59 on develop.


requirements.txt does not exist

Refer to https://mriqc.readthedocs.io/en/stable/install.html#bare-metal-installation-only-python-3,
requirements.txt file does not exist. Maybe we need to update the documentation.
In the meantime, did you used to have the packages mentioned in dockerfile in requirements.txt ?

cc @sbouix @mglyons

Maybe we need to update the documentation.

Correct - could you send a PR?

In the meantime, did you used to have the packages mentioned in dockerfile in requirements.txt ?

Those are indirect dependencies, which in principle, can be pinned to specific versions to give more reliability to the container images and save time when building them. Also, there's interest in pulling the packages from conda instead of pypi, as they usually come more optimized from the former.

The main documentation on https://mriqc.readthedocs.io/en/latest/install.html points users to install python requirements from a file as shown here:
pip install -r https://raw.githubusercontent.com/poldracklab/mriqc/master/requirements.txt
But it appears the requirements are now located here:

https://raw.githubusercontent.com/poldracklab/mriqc/master/docs/requirements.txt

@hfxcarl This issue seems to have been resolved in<PHONE_NUMBER>45847b41fc5c2b2c006a417c15a0bd, however, the documentation site seems to have been last built using commit b3a581627ef4c58f7e418fb184157aba19c85c09 from January 2019.
@oesteban can this issue be closed? Also, should the documentation site be rebuilt?

Okay, the documentation is now updated, and the requirements.txt removed (as we are moving towards PEP 518 installations).


bug: unable to delete a CR from an APIBinding/APIExport when the APIExport is gone

Describe the bug
I ran test/e2e/apibinding TestAPIBinding. The test passed. But content was stuck deleting infinitely. One of the cowboy resources is still there (among other things). It looks like the WebhookDispatcher is failing closed if it knows the GroupResource is from an APIBinding/APIExport, but the APIExport can't be found.
Steps To Reproduce

Run some e2e tests that use APIBindings
See them pass
Watch the kcp server logs to see content being deleted over and over with no success

Expected Behaviour
Content is eventually fully deleted
Additional Context
I am able to GET the cowboy just fine:
$ k --user shard-admin --server https://localhost:6443//clusters/2sbv945iawtyharh get cowboy/cowboy-consumer-2-bound-against-1
NAME                                AGE
cowboy-consumer-2-bound-against-1   93m

But delete fails:
$ k --user shard-admin --server https://localhost:6443//clusters/2sbv945iawtyharh delete cowboy/cowboy-consumer-2-bound-against-1
Error from server (NotFound): apiexports.apis.kcp.io "root:e2e-workspace-jftmt:service-provider-1:today-cowboys" not found

The error is coming from https://github.com/kcp-dev/kcp/blob/9358474affa117ae6615f2eca684b8499b0d1017/pkg/admission/webhook/generic_webhook.go#L169

@sttts @stevekuznetsov @vincepri should we skip trying to run any webhooks if the APIExport is gone?

Stefan & I chatted about this and would like to do the following:

Add a field to APIBindingStatus that stores the logicalcluster.Name for the APIExport.
Change the webhook code that looks up the APIExport to use this new field

Possible future follow-ups could include storing a list of all the webhooks on the APIBindingStatus and making sure they all exist when invoking webhook admission. If anything is missing ... wait (eventual consistency).

I don't think this is fully fixed, as it appears that a cowboy CR isn't getting deleted. This fails 100% on my local machines.
When running go test ./test/e2e/apibinding -use-default-kcp-server, I still see looping deletes for a namespace and cowboy within a logical cluster, though the errors aren't the same as what was seen previously.
I0126 10:41:22.698931 2424223 httplog.go:131] "HTTP" verb="DELETE" URI="/clusters/23c6jjzy63m23w6p/apis/apis.kcp.io/v1alpha1/apiconversions" latency="2.3808ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kcp-logicalcluster-deletion" audit-ID="7fe42c7b-3e6e-4026-a38a-8ac7c3130b98" srcIP="[::1]:42554" resp=200
I0126 10:41:22.700246 2424223 httplog.go:131] "HTTP" verb="LIST" URI="/clusters/313t0ban5tbqyj3p/api/v1/namespaces/default/limitranges" latency="1.990171ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kube-namespace-controller" audit-ID="c5b71bb8-cf93-4f5b-bba4-3e932bd82d3e" srcIP="[::1]:42554" resp=200
I0126 10:41:22.700876 2424223 namespaced_resources_deleter.go:598] namespace controller - deleteAllContent - namespace: default, estimate: 0, errors: unexpected items still remain in namespace: default for gvr: wildwest.dev/v1alpha1, Resource=cowboys
I0126 10:41:22.700899 2424223 namespace_controller.go:181] Finished syncing namespace "313t0ban5tbqyj3p|default" (94.466998ms)
E0126 10:41:22.700928 2424223 namespace_controller.go:163] deletion of namespace 313t0ban5tbqyj3p|default failed: unexpected items still remain in namespace: default for gvr: wildwest.dev/v1alpha1, Resource=cowboys
I0126 10:41:22.701925 2424223 httplog.go:131] "HTTP" verb="LIST" URI="/clusters/23c6jjzy63m23w6p/apis/apis.kcp.io/v1alpha1/apiconversions" latency="1.979745ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kcp-logicalcluster-deletion" audit-ID="6f159f56-091e-4be0-9d83-e9e8df44275f" srcIP="[::1]:42554" resp=200
I0126 10:41:22.705638 2424223 httplog.go:131] "HTTP" verb="DELETE" URI="/clusters/23c6jjzy63m23w6p/apis/apis.kcp.io/v1alpha1/apiexports" latency="2.437265ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kcp-logicalcluster-deletion" audit-ID="24ae6636-97b7-4d08-87da-7cbc563888d5" srcIP="[::1]:42554" resp=200
I0126 10:41:22.708823 2424223 httplog.go:131] "HTTP" verb="LIST" URI="/clusters/23c6jjzy63m23w6p/apis/apis.kcp.io/v1alpha1/apiexports" latency="1.988936ms" userAgent="kcp/v0.0.0 (linux/amd64) kubernetes/$Format/kcp-logicalcluster-deletion" audit-ID="9b917784-5540-4168-ae81-36d71360aca2" srcIP="[::1]:42554" resp=200
E0126 10:41:22.709522 2424223 logicalcluster_resource_deletor.go:446] "resource remaining" component="kcp" reconciler="kcp-logicalcluster-deletion" key="23c6jjzy63m23w6p|cluster" logicalcluster.workspace="23c6jjzy63m23w6p" logicalcluster.namespace="" logicalcluster.name="cluster" logicalcluster.apiVersion="" operation="deleteAllContent"
E0126 10:41:22.709653 2424223 logicalcluster_deletion_controller.go:193] "content remaining in logical cluster after a wait, waiting more to continue" err="some content remains in the logical cluster, estimate 5 seconds before it is removed: Some resources are remaining: apibindings.apis.kcp.io has 1 resource instances, namespaces. has 1 resource instances; Some content in the logical cluster has finalizers remaining: apis.kcp.io/apibinding-finalizer in 1 resource instances" component="kcp" reconciler="kcp-logicalcluster-deletion" key="23c6jjzy63m23w6p|cluster" duration="95.99679ms" waiting="3s"

The cowboy still exists in the namespace.
❯ k --user shard-admin --server https://<IP_ADDRESS>:6443/clusters/23c6jjzy63m23w6p get cowboys/testingkfw8l -o yaml
apiVersion: wildwest.dev/v1alpha1
kind: Cowboy
metadata:
  annotations:
    kcp.io/cluster: 23c6jjzy63m23w6p
  creationTimestamp: "2023-01-26T15:41:09Z"
  generateName: testing
  generation: 1
  name: testingkfw8l
  namespace: default
  resourceVersion: "2815"
  uid: b5640fae-6ba3-4182-8f3c-a7f92b6fe717
spec: {}

And the APIBinding still exists.
❯ k --user shard-admin --server https://<IP_ADDRESS>:6443/clusters/23c6jjzy63m23w6p get apibindings/cowboys -o yaml
apiVersion: apis.kcp.io/v1alpha1
kind: APIBinding
metadata:
  annotations:
    kcp.io/cluster: 23c6jjzy63m23w6p
  creationTimestamp: "2023-01-26T15:41:07Z"
  deletionGracePeriodSeconds: 0
  deletionTimestamp: "2023-01-26T15:41:09Z"
  finalizers:
  - apis.kcp.io/apibinding-finalizer
  generation: 2
  labels:
    internal.apis.kcp.io/export: 1KCHLI13ki4Z0lNYDHwjQk1z5ZexffsgnMGltt
  name: cowboys
  resourceVersion: "2866"
  uid: 6d3311c6-357d-4c19-9709-c72f27de70a1
spec:
  reference:
    export:
      name: today-cowboys
      path: root:e2e-workspace-gp7fh:e2e-workspace-djz9z
status:
  apiExportClusterName: 263j8kn0a04lwrxs
  boundResources:
  - group: wildwest.dev
    resource: cowboys
    schema:
      UID: 29c1da18-1634-4f2f-a05d-63656a71f616
      identityHash: 46d6f8ea8b57644d086dcf0a19be74b96e352b3d6badbe57b5f271ce1cb6fb6d
      name: today.cowboys.wildwest.dev
    storageVersions:
    - v1alpha1
  conditions:
  - lastTransitionTime: "2023-01-26T15:41:07Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-01-26T15:41:10Z"
    message: APIExport root:e2e-workspace-gp7fh:e2e-workspace-djz9z|today-cowboys
      not found
    reason: APIExportNotFound
    severity: Error
    status: "False"
    type: APIExportValid
  - lastTransitionTime: "2023-01-26T15:41:10Z"
    message: 'Some resources are remaining: cowboys.wildwest.dev has 1 resource instances'
    reason: SomeResourcesRemain
    severity: Error
    status: "False"
    type: BindingResourceDeleteSuccess
  - lastTransitionTime: "2023-01-26T15:41:07Z"
    status: "True"
    type: BindingUpToDate
  - lastTransitionTime: "2023-01-26T15:41:07Z"
    status: "True"
    type: InitialBindingCompleted
  - lastTransitionTime: "2023-01-26T15:41:07Z"
    status: "True"
    type: PermissionClaimsApplied
  - lastTransitionTime: "2023-01-26T15:41:07Z"
    status: "True"
    type: PermissionClaimsValid
  phase: Bound

What happens when you manually issue a delete as shard admin?

nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k --user shard-admin --server https://<IP_ADDRESS>:6443/clusters/23c6jjzy63m23w6p delete cowboys/testingkfw8l

Error from server (NotFound): APIExport.apis.kcp.io "today-cowboys" not found

nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k --user shard-admin --server https://<IP_ADDRESS>:6443/clusters/23c6jjzy63m23w6p delete apibindings/cowboys

apibinding.apis.kcp.io "cowboys" deleted
(hangs)

The APIExport appears to be gone; cluster name taken from the APIBinding in the previous comment.
nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k --user shard-admin --server https://<IP_ADDRESS>:6443/clusters/263j8kn0a04lwrxs get apiexports

No resources found

To add further, the APIExport's cluster was deleted, too.
nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k ws root:e2e-workspace-gp7fh:e2e-workspace-djz9z
Error: workspace "root:e2e-workspace-gp7fh:e2e-workspace-djz9z" not found

nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❮ k ws root:e2e-workspace-gp7fh
Current workspace is "root:e2e-workspace-gp7fh".

nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k get workspace
NAME                  TYPE        PHASE   URL                                                    AGE
e2e-workspace-jmsdb   universal           https://<IP_ADDRESS>:6443/clusters/23c6jjzy63m23w6p   96m

nrb in e200-8d in kcp on  main via 🐹 v1.19.4
❯ k ws 263j8kn0a04lwrxs
Error: workspaces.tenancy.kcp.io "263j8kn0a04lwrxs" not found


Issues with "Dart" spell

There's an issue with dragging the Dart spell to the character sheet. An "Unrecognized identifier" exception is shown. With the dev tools, I was able to see that the exception is thrown in actor-wfrp4e.js when evaluating the formula "+0+ willpower bonus" in the calculateSpellDamage(formula, isMagicMissile) method.
In this method + willpower bonus is added to the formula, but imho it should be resolved to a number.
IMHO this seems to be an issue with all magical missles.

Ok i found it. In the while loop, the if condition has to be adapted to use WFRP4E instead of the actor data.
  calculateSpellDamage(formula, isMagicMissile)
  {
    let actorData = this.data
    formula = formula.toLowerCase();

    if (isMagicMissile) // If it's a magic missile, damage includes willpower bonus
    {
      formula += "+ willpower bonus"
    }

    // Iterate through characteristics
    for(let ch in actorData.data.characteristics)
    {
      // If formula includes characteristic name
      while (formula.includes(WFRP4E.characteristics[ch].toLowerCase()))
      {
        // Determine if it's looking for the bonus or the value
        if (formula.includes('bonus'))
          formula = formula.replace(WFRP4E.characteristics[ch].toLowerCase().concat(" bonus"),  actorData.data.characteristics[ch].bonus);
        else
          formula = formula.replace(WFRP4E.characteristics[ch].toLowerCase(),  actorData.data.characteristics[ch].value);
      }
    }

    return eval(formula);
  }

I fixed it locally for me and can prepare a PR if wanted. IMHO it needs further testing.

Yeah because the actor template had these values hard coded previously, my update to the template to support translation doesn't affect old actors. A solution to this is to just duplicate the actor, but users don't know that, so using the config object would fix this issue, feel free to submit that PR.

I'm not sure about the duplication workaround. I have a brand new installation and added new chars when I encountered the bug. PR is coming up later today.

Hmm I think this is obsolete with https://github.com/CatoThe1stElder/WFRP-4th-Edition-FoundryVTT/commit/40724fee47f64422eef926dd07739de2e06ae9e8. Good!

Ah now I think what you meant with the "old actor"... I will provide a PR.

Hi @alphec is this issue resolved?


deployment - usecases Fix endpoint configuration bash scripts

commit message should start with a verb in present simple

please rename files directory to smth more meaningful

Fixed review comments


relative::LockTime should be convertable to Sequence and/or have a consensus_u32 encoder

Right now once you parse out a relative locktime you are stuck with it. You should be able to round-trip it from a u32 or at least a sequence number.

I think Sequence::MAX is excluded? But yes, it should have conversions. It appears nobody used this API yet so nobody noticed they are missing.

Agreed, it seems nobody has used it yet. I am starting to use it now in https://github.com/rust-bitcoin/rust-miniscript/pull/654


Rustup: Compiles on nightly 2016-01-26

Compiles on 2016-01-26, tests run (Almost no tests, but docs pass)

:+1:


Template improvements

Pull Request Test Coverage Report for Build 946237070

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.657%

Totals

Change from base Build 857126990:
0.0%

Covered Lines:
265

Relevant Lines:
286

💛  - Coveralls


Automatic reload of certificates

I've seen SslReloadBundle, but that seems like it places the burden of noticing that certificates have changed on some external daemon, when it might as well be handled internally.
In my use case, as I suspect many others, certificates are rotated by an external daemon such as cert-manager that simply replaces the certificates when they are about to expire and that daemon doesn't particularly have a need to know about the consumer of the certificate.
The true Kubernetes way to consume certificates would be to use the API server to watch the certificate resource and reload it when it changes, but that comes with a somewhat heavy burden of having to depend on the k8s api, when that might not otherwise be needed.
I think the simplest solution is to simply mount the TLS secret in the filesystem and load the certificates from the file system and then periodically poll the files for changes.
For my own dropwizard-kubernetes-https module I've implemented a very simple automatic ssl reloader that does not need an external daemon to poke the server to reload the certificates and I wonder if something like this is a candidate for core?
https://gitlab.com/dren.dk/dropwizard-kubernetes-https/-/tree/main/src/main/java/dk/dren/dw/k8s/https/reloader

@dren-dk This sounds like an interesting idea. But as you have found a solution for yourself, I think this is more sort of a discussion instead of an issue. We could firstly determine, if there would be interest in having this in the framework and how this should be integrated then.


Is there a way to manage xrdp sessions for multiple users?

I'm wondering if there's a way in xrdp to be able to look at session info for multiple users for xrdp. Things like, kicking users, see who's connected, how many logins currently, etc. Is this possible?

xrdp-sesadmin utility is what you're looking for.
On Mon, Jul 17, 2017 at 8:46 AM BloodyIron<EMAIL_ADDRESS>wrote:

I'm wondering if there's a way in xrdp to be able to look at session info
for multiple users for xrdp. Things like, kicking users, see who's
connected, how many logins currently, etc. Is this possible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/820, or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1Exe9Xny3_GIOQ9W-W6wpiNsDxNPks5sOvU4gaJpZM4OZkaV
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18

It looks like xrdp-sesadmin doesn't have the working functionality to kill sessions. There is a parameter available, but documentation (and testing) shows that it doesn't work.
I'm on 0.9.0 and I don't see anything relevant to this in the release notes for newer versions.
 Are there any plans for this?

This doesn't seem to be implemented: cmndKill() in xrdp/sesman/tools/sesadmin.c is empty.
Presumably it needs to be added to the scp (sesman protocol).

That's correct. seems like we need to keep Xorg pid as well.
On Wed, Jul 19, 2017 at 11:36 PM Ben Cohen<EMAIL_ADDRESS>wrote:

This doesn't seem to be implemented: cmndKill() in
xrdp/sesman/tools/sesadmin.c is empty.
Presumably it needs to be added to the scp (sesman protocol).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/820#issuecomment-316509304,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1JSkLHWoQonJ-C8OAURBSK5DDPpOks5sPmjigaJpZM4OZkaV
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18

How hard do you see this being to implement?

I think this sort of thing is easier with my shared memory change (pull request #819).  We could add fields for the Xorg pid (and the wm pid if you like) and the session instance process of xrdp-sesman can set them in session_start_fork().  Then the daemon instance can see those pids to kill them.  (Otherwise it will have to walk the processes tree in /proc.)
Btw I think it would be a good idea for each xrdp-sesman session instance (and descendants) to get a new Linux session (SID).

 After looking at the output of 'ps axjf' i wrote a little tool for that:
#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>
#include <sys/types.h>
#include <signal.h>
void main(int argc, char **argv) {
pid_t pid, pgid;
pid = atoi(argv[1]);
pgid = getpgid(pid);
printf("pid = %i, pgid = %i\n", pid, pgid);
if(kill(-pgid, SIGTERM) == SUCCESS) {
printf("pgid killed\n");
}
};
Basically the idea is to get the process group pid of the sesman process and send TERM to every process in this process group. It seems to work, everything started by sesman including sesman was terminated.
sid could work too, but i'm no expert.

I would also like to have xrdp-sesman list me all users having a session.
When I am sure I don't have a session and check with xrdp-sesman -u=me -p -c=list it lists me two sessions, but I'm
in no way logged in as that "me" user, invisible with loginctl and who
I have found this useful to check the logs:
zcat $(ls -1d /var/log/xrdp-sesman.log*|sort -Vr) |grep "++"
The used xrdp versions are: xrdp <IP_ADDRESS>-1ubuntu1 and xorgxrdp 1:0.9.19-1ubuntu1

It's on the list of improvements I want to make to xrdp-sesadmin. I want to be able to add some users as admin users who will have visibility of all xrdp sessions.
#2745 (which fixes #1302) will be merged as soon as we've got GFX working reliably. That's a main priority for us at the moment.

i've got some loginctl interface with a xrdpctl, if you're interested?

Thanks @alexmyczko
By all means post it - it may well be useful to other users.

Ok it wasn't written yet, but this works for me. Enjoy!
https://github.com/alexmyczko/autoexec.bat/blob/master/xrdpctl


Rebuilding on any package install

I think the current scripts are too aggressive with rebuilding this library. If I have this package as a dependency, any time I add any other package I have to sit through it recompiling, which can take minutes.
We're looking to bundle this package in https://github.com/serverless-stack/serverless-stack and we don't want our users to be impacted in this way.
Any suggestions?

I think our next step should be to look into distributing pre-compiled binaries as part of the RIC's release to remove some of the responsibilities (eg. compiling and build-time dependencies) from consumers.
This would help also greatly reduce time spent installing the package as reported in this issue.

That would be great. Although I recently figured out that MacOS isn't supported and that doesn't work for our use case. At quick glance it doesn't seem like anything is particularly difficult about compiling it on Mac but not sure

Revamping this issue 1 year after.. Do you have any updates?
It's very annoying to have to recompile everytime.
Our docker build is taking a good 150 seconds more every time as it seems docker doesn't cache the step.

We are building on a macbook m1 and the build time was 900 seconds. Reducing build times / increasing cache-ability in any way would be extremely beneficial.


Unittests

This PR has tests for Steph's scripts on the R group decomposition. This is in one script inside the tests directory and has an accompanying dummy .csv file. I've also attempted to set up some CI for testing.

Merged since there were no conflicts with master


Database Withou any scripts

Hello @DirtyCajunRice  , thanks for you work with this
im having a problem , wondering if you can help ... the influx db is empty , and nothing in coming from the scripts .... i have other docker containers that are working fine with influx db , incluing a docker for plex stats ... i have created a new DB called plex , and have re done all like you explain in the configuration . but still nothing in the Db, can u please see if im doing anyhting wrong , the logs only  have this :

my config is this :
########################### INFLUXDB CONFIG ###########################
influxdb_url = <IP_ADDRESS>
influxdb_port = 8086
influxdb_username =
influxdb_password =
############################ SONARR CONFIG ############################
sonarr_server_list =   [
('https://sonarr1.domain.tld', 'xxxxxxxxxxxxxxx', '1'),
('https://sonarr2.domain.tld', 'xxxxxxxxxxxxxxx', '2'),
#('https://sonarr3.domain.tld', 'xxxxxxxxxxxxxxx', '3')
]
sonarr_influxdb_db_name = 'plex'
############################ RADARR CONFIG ############################
radarr_server_list =   [
('https://radarr1.domain.tld', 'xxxxxxxxxxxxxxx', '1'),
('https://radarr2.domain.tld', 'xxxxxxxxxxxxxxx', '2'),
#('https://radarr3.domain.tld', 'xxxxxxxxxxxxxxx', '3')
]
radarr_influxdb_db_name = 'plex'
############################ OMBI CONFIG ##############################
ombi_url = 'https://ombi.domain.tld'
ombi_api_key = 'xxxxxxxxxxxxxxx'
ombi_influxdb_db_name = 'plex'
########################## TAUTULLI CONFIG ############################
tautulli_url = http://<IP_ADDRESS>:8181
tautulli_api_key = xxxxxxxxxxxxxx
tautulli_failback_ip = <IP_ADDRESS>
tautulli_influxdb_db_name = plex
tautulli_verify_ssl = False

Run the scripts manually from the command line and verify there are no errors. I would suggest you run one at a time and validate there is data being populated in the DB.
You must have something misconfigured.

@samwiseg00 thanks for the help , i think have run the script right ... here is the error

Dont have any script configured yet .. .want to get this going fist ....

it gives an error in the script in the first lines

You need to run the script with python3 tautulli.py
You need to set the proper config in configuration.py

You removed the quotes. Please refer to the example and only replace what is inside the quotes

@samwiseg00  thank you so much .. .really tought the '' where to remove ... its working know ... sorry for all the trouble . and thanks for the help again

No problem


highlight not defined

I'm experiencing a subtle bug when using marked in conjunction with highlight.js. I am using your double-escaping workaround for code highlighting to great effect: optional escape #6, but when I attempt to begin a markdown string with code, as opposed to the other semantic tags, I get an Uncaught ReferenceError: highlight is not defined. Here is the code that I am using:
$(function(){
  var _marked;

  // Set highlighting options for marked
  marked.setOptions({
    highlight: function (code) {
      return hljs.highlightAuto(code).value;
    }
  });

  _marked = marked;

  // Rewrite marked to prevent double-escaping of code blocks
  window.marked = function(text) {
    var tokens = _marked.lexer(text),
        l      = tokens.length;

    for (var i = 0, tok = tokens[i]; i < l; i++) {
      if (tok.type === "code") {
        tok.text = highlight(tok.text, tok.lang);
        tok.escaped = true;
      }
    }

    return _marked.parser(tokens);
  };
});

As an example,  the following markdown will be rendered properly, and without incident:
# Some header
```
puts 'hello'
```

whereas this throws an error:
```
puts 'hello'
```

Any thoughts on what the problem might be here?

#983


Non-ThreadAgnostic Layouts/Renderers Being Rendered On Wrong Thread?

Type: Bug?
NLog version: 4.4.1
Platform: .Net 4.5
As per discussion on #1136, I believe I've found a possible bug, though I'm not 100% sure what the expected behavior ought to be. I was having some difficulty with non-thread-agnostic layouts being rendered on the wrong thread where they no long have the correct CallContext data. In experimenting, some things appeared to be fixed at first, but it looks like the behavior is different depending on the root layout format? I've uploaded a LINQPad script I was using to Prototype this here (if you don't have LINQPad, the file can be opened as plain text and the code is there, but I'd at least recommend giving LINQPad if you haven't). The script has two primary layout configurations, one of which is commented out. I've included output from both configurations with async turned on and off (all of this is changed simply by commenting/uncommenting existing lines). The test runs three separate tests for methods we have prototyped for contextual diagnostic data, each of which differs a little bit, but even in the most simple form using MDLC there is a pretty curious difference in the output between the CsvLayout and JsonLayout; JsonLayout appears to lose a fair bit of context, though not all of it in all cases. The last 2/3 columns/properties are all thread-contextual and I'm a bit confused why some configurations work as expected under async and some don't, even simultaneously.
As an additional sidenote, it appears that using the async wrapper costs quite a bit of performance, which is the opposite of what my expectation was. If this holds true for our main application we'll likely just use synchronous writes anyway, but I thought it was worth asking if something is broken or if I'm doing something wrong?

I think this is the same issue
https://github.com/NLog/NLog/issues/254
I really like to fix this, but dunno how

I will try to look at your tesr script soon

Since some layouts work better than others I wonder if it isn't the object graph exploration is just missing something? I don't know well enough how that code works, but it almost feels like it's not making it to some property that contains a non-agnostic layout when it's searching to find objects without the attribute?

Thanks for the LINQpad script. I have LINQPad (but never use it ;))
Unfortunately the testscript is too large for me. I don't have time to debug 750 lines. Is it possible to provide a smaller testcase, and preferred as unit tests? (PR with unit tests also nice)

I'm a little backed up at work at the moment, but I will try to put something smaller and more fitting together for you when I get caught up.

thanks!

NLog 4.4.2 includes the PR #1925 that improves the async-handling for JsonLayout.

Ahhh, ok, first I'll try with an updated package (I thought I was on most recent) and see if the issues are already resolved.

Yup, that's what it was. Sincerely sorry for wasting your time, I thought I was up-to-date. Thanks very much for the assistance.

@TheXenocide The bug has been there since the dawn of the JsonLayout, and has just been resolved 2 weeks ago. Glad you can also confirm it as fixed :)

\o/

Thanks @snakefoot !


IntrusiveQCellOwner?

We don't suppose it'd be possible to have something along these lines?
struct IntrusiveQCellOwner<T: ?Sized> {
  inner: Arc<QCell<T>>,
}

// impl<T: ?Sized> !Clone for IntrusiveQCellOwner<T>;

impl<T> IntrusiveQCellOwner {
  fn new(value: T) -> Self {
      Arc::new_cyclic(|arc| {
        QCell { owner: QCellOwnerID(arc.as_ptr() as *const () as usize), value: UnsafeCell::new(value) }
      })
    }
  }
}

impl<T: ?Sized> IntrusiveQCellOwner {
  fn id(&self) -> QCellOwnerID {
    self.inner.owner
  }

  // the usual stuff, rw etc.

  fn clone_inner(&self) -> Arc<QCell<T>> {
    self.inner.clone()
  }

  // in fact, might aswell just use Deref and DerefMut for these.
  //fn mut_inner(&mut self) -> &mut T {
    // ...
  //}
  //fn get_inner(&self) -> &T {
    // ...
  //}
}

The main use-case would be the same as #16 except without a separate "owner".
pub struct ConfigManager {
    resources: Vec<Resource>,
}

pub struct AddConfigSource<'a, T: DataSourceBase + Send + Sync + 'static> {
    resource: &'a mut Resource,
    source: Arc<QCell<T>>,
}

struct Resource {
    // actual resource
    base: IntrusiveQCellOwner<dyn DataSourceBase + Send + Sync>,
    // views of the actual resource
    title: Option<Arc<QCell<dyn DataSource<InstanceTitle> + Send + Sync>>>,
    url: Option<Arc<QCell<dyn DataSource<InstanceBaseUrl> + Send + Sync>>>,
    repolist: Option<Arc<QCell<dyn DataSource<RepoListUrl> + Send + Sync>>>,
}

impl ConfigManager {
    pub fn add_source<T>(&mut self, source: T) -> AddConfigSource<'_, T>
    where
        T: DataSourceBase + Send + Sync + 'static,
    {
        let base = IntrusiveQCellOwner::new(source);
        let arc = base.clone_inner();
        self.resources.push(Resource::new(base));
        AddConfigSource {
            resource: self.resources.last_mut().unwrap(),
            source: arc,
        }
    }
}

impl<'a, T: DataSourceBase + Send + Sync + 'static> AddConfigSource<'a, T> {
    pub fn for_title(self) -> Self where T: DataSource<InstanceTitle> {
        let arc = &self.source;
        self.resource.title.get_or_insert_with(|| {
            arc.clone()
        });
        self
    }
    pub fn for_base_url(self) -> Self where T: DataSource<InstanceBaseUrl> {
        let arc = &self.source;
        self.resource.url.get_or_insert_with(|| {
            arc.clone()
        });
        self
    }
    pub fn for_repo_lists(self) -> Self where T: DataSource<RepoListUrl> {
        let arc = &self.source;
        self.resource.repolist.get_or_insert_with(|| {
            arc.clone()
        });
        self
    }
}

This isn't going to work. As you say, the owner is the cell itself. However to borrow mutably from the cell you need a &mut on the owner. But behind an Arc you can only get a & reference. So to be correct (i.e. sound), your cell-type would only be capable of ro type borrows, i.e. immutable borrows. To get a &mut behind an Arc, you need a Mutex or RwLock. So this intrusive-cell isn't helping at all. You might as well just have an Arc<Mutex<T>>.
The whole point of these cell types is to temporarily "transfer" mutability from one thing to something else that has only immutable access. In this case (plain Arc), you don't have anywhere with mutable access available. Does this make sense?

This is sound. It's just kinda (read: very) weird.
The mutability would be held by the "original Arc". We manage the "original Arc" by encapsulating an Arc::new_cyclic inside an !Clone type - the lack of Clone prevents making new "owners" that hold the same Arc, such that no two IntrusiveQCellOwner ever point to the same object.

I'm still having trouble figuring out what you're trying to do.
So I think what you're saying is that the "original Arc" is the owner, and so accessing through the "original Arc" would allow modification of the cell contents. You say you're not going to allow cloning, but in your example code you have clone_inner. Those Arc clones are going to be useless, as you can't get access (not even immutable access) to the inside of the cell without having access to the owner (the "original Arc").  If you did allow immutable access through the Arc clones, then that would be a soundness failure, because somewhere else might be doing mutable access through the "original Arc".
However if the only Arc will be the "original Arc" (i.e. cloning is forbidden), then it doesn't need to be an Arc -- it could just be a Box. Still perhaps I have not really understood what you're trying to do.
(Also, if the "original Arc" needs to be the owner, then you either need to Box it or Pin it, so that its address is stable.)
Perhaps I would understand better if you could explain what advantage this approach has compared to the original code which used a QCellOwner.

The clone_inner is -> Arc<QCell<...>>, not -> IntrusiveQCellOwner. The advantage is that this avoids an unnecessary allocation.

Arc::as_ptr gives the address of the data inside the Arc (i.e. the data pointed to), not the address of the Arc itself (the pointer). The code as above is not going to work, but I'm trying to understand what you're trying to do to see if there is a way it could work.
If you try to code up the IntrusiveQCellOwner using safe code and QCellOwner maybe that would make more sense of things. It would mean that you couldn't access the T from an Arc<QCell<T>> without also having a reference to the IntrusiveQCellOwner. If this isn't what you expect, then I suspect that you've overlooked some problems with this arrangement.

The code as above is going to work. And the data inside the Arc is a QCell - which has a QCellOwnerID in it so it's never zero-sized anyway.
In fact, the get_inner just needs to be:
  fn get_inner(&self) -> &T {
    self.ro(self.inner)
  }

The mut_inner can't just be:
  fn mut_inner(&mut self) -> &mut T {
    self.rw(self.inner)
  }

because self.rw borrows &mut self. Except this isn't unsound, it just requires copying the fn rw into mut_inner, as rw doesn't actually touch the QCell contents. Note that you can't just clone the Arc, as in:
  fn mut_inner(&mut self) -> &mut T {
    self.rw(self.inner.clone())
  }

because the cloned Arc would get dropped at the end of the scope - there's no lifetime that satisfies this.

The idea seems (probably) sound to me. But it might be a bit much new API for fairly little benefit (saving a single allocation). It’s also quite Arc-specific (without declaring so in the naming).

I can see that you can put an owner in IntrusiveQCellOwner and make access through the IntrusiveQCellOwner work.  The problem is the Arc<QCell<T>> returned by clone_inner(). Those QCells can't be accessed without accessing them through the IntrusiveQCellOwner. But in Resource, you're keeping them right next to one another. So you do have the owner available. So I can kind of see how this would work now.
So this would be equivalent to putting a QCellOwner or a QCellOwnerPinned in the Resource. The optimisation will save a usize in memory (compared to QCellOwnerPinned).
If this was going to be made into a general-purpose owner type, it's not necessary to use QCell. It could be its own type. So you'd have ArcOwner<T> and ArcCell<T>.  The T in the ArcCell<T> can't be accessed without having a &mut or & on the ArcOwner<T>. This checks that the as_ptr() on the two Arcs points to the same data. So there is no ID overhead. This is mostly useless (if you have access to the ArcOwner then why do you need to access through the ArcCell?) but in your case you're getting different vtables, which is the only thing you're really interested in.
Really the ideal situation would be to keep a Box<T> and a bunch of vtable pointers, and reconstruct the dyn pointers. But there is no safe or approved way to do this yet, although deconstructing and reconstructing a fat pointer is commonly done in various crates. For example I use it in Stakker to store a FnOnce in a flat list.
Anyway, I think ArcOwner and ArcCell as I've described are too special-purpose to add to this crate. I can't think of any use apart from this work-around for not being able to store multiple vtables in any other way. Or can you see a more general-purpose way of implementing this that might be useful for other things?

The original IntrusiveQCellOwner fully supports being used with "unrelated" QCells. Yes, our use-case is purely to carry multiple VTables around, and clone_inner is pretty much limited/designed for that use-case, but the rest of the API isn't.
We do understand if this would be a better fit for a separate crate.

It’s also quite Arc-specific (without declaring so in the naming).

It's hard to make APIs like these generic. Something that could support Arc, Rc and Box would be nice, but IntrusiveQCellOwner<X<QCell<T>>> is... verbose... and you don't want to support arbitrary Deref. you'd want some sort of unsafe trait DerefPinned: Deref or something.

Personally I'd skip straight to the desired end-point, i.e. try to store vtable pointers directly. I had a quick look to see if there had been any progress, and actually yes there has! Simon Sapin's RFC proposal was accepted last year. Discussion about the implementation is progressing here and there seems to be a preliminary implementation here. So maybe you can implement something using this crate. If it's of interest, my own code in Stakker that deconstructs and reconstructs fat pointers is here.

We can't think of a way to carry Option<VTable>'s with a BaseObject that isn't inherently unsound. Arc<QCell> works. the thing is that regardless of how you do it, you still need to decouple the underlying mutability from each of the VTables, like QCell.

honestly closing this as we believe it's handled by #37 / selfref


Scores from words file are not used for ql_textscore computation

Looks like, when doing text search with ql:contains-entity and ql:contains-word, ql_textscore_* variable has simply number of matching documents per entity, but it doesn't take score column from words file into account.
From the documentation:

The SCORE(?text) returns the number of matching records (sums of the score in the wordsfile, see above).

For me looks like a bug, because ordering by "real" score is extremely useful. What is the expected behavior?

@NickG-1  is currently working on a thorough refactoring of the text index, that also exports the real score.
However we currently (at least temporarily) will drop the TEXTLIMIT feature (it doesn't quite fit in the SPARQL standard and we also don't find ourselves using it very often).
Would that be an issue for you?

@joka921 thank you for the update! That is good know.
I didn't use it so far exactly because it is non-standard SPARQL extension and all our tooling expects standard sparql on various levels of the system. So having it specified with magical predicate is much more preferable then with non-standard TEXTLIMIT.
In my view something like text limit is necessary to have at some point in time for sure, because otherwise one can get into troubles with search queries that returns too many documents.
For example in our dataset about works of art queering for "anonymous" author or "Madonna" artworks will produce too many matched documents. But it is definitely not a showstopper.
Also just to add that when working with bigger documents, I think it is more convenient to get not the whole document text back, but rather just a matched document ID.


Fix PDF Bookmarks

See commit messages. :-)

I don't get the forced \clear… thingies. I suspect there might have been  a better variant added in KOMA over the years…

I don't get the forced \clear… thingies. I suspect there might have been a better variant added in KOMA over the years…

At least they do not change the visual result as far as I can tell. I googled for ~1 hour and this was the best I could find. :sweat_smile:

pom pom pom.
I have to go over these when I find  time

what about \setchapterpreamble[o]{\pdfbookmark{Second Chapter}{2nd}}  (https://tex.stackexchange.com/a/484441)

@krono Sorry for the late reply!

what about \setchapterpreamble[o]{\pdfbookmark{Second Chapter}{2nd}} (https://tex.stackexchange.com/a/484441)

Looks interesting, I tried this out, and then reproduced the comment under this answer:

the linked position varies a bit with respect to an original chapter

So "list of figures" and "introduction" will be scrolled differently far down with this approach, which I would find aesthetically slightly unpleasant (but still better than the status quo where the heading is not in the initial view at all). But it's up to you to decide :)
(I also did not find a way to move the bookmark further up manually, \put(0,0) is not allowed within \BeforeTOCHead)

I'm still conflicted :(


RTL attribute disables font name!

I create a style to use it for my paragraphs. when I change the RTL attribute to TRUE, the text is not written with the font I've specified and when it sets FALSE, the code works properly and font name is correct. the text is a mix of Persian and English.
my style is like this:
word_document = docx.Document()
style_rtl = word_document.styles.add_style('NormalRTL', WD_STYLE_TYPE.PARAGRAPH)
style_rtl.font.name = 'Noto Naskh Arabic'
style_rtl.font.rtl = True
paragraph = word_document.add_paragraph('.سلام new آخر')
paragraph.style = style_rtl
I try several ways to solve this but still no answer. anyone knows what's the problem?

Better have a look at the XML produced by python-docx and compare it to that produced by Word when it's doing what you want. opc-diag is handy for that job. The XML in question will be in the document.xml part. A super-short test document makes this a lot easier.
I wouldn't be surprised if it had something to do with specifying a cursive font. Those elements usually start with 'cs', like <w:csBold/>.
There is some background information on fonts in the documentation here:
http://python-docx.readthedocs.io/en/latest/dev/analysis/features/text/font.html
This is in the pre-development analysis section, so not everything you see there is necessarily implemented.

I've changed the font using for my document to this font but no difference in result.
NotoNaskhArabic
I've updated the first post and put the complete test code. also I upload the output document here.
Can you check what's wrong with it?
new.docx

The bug still exists:
`from docx import Document
from docx.shared import Pt
doc = Document()
def set_font(run, font_name="David", size=14):
run.font.name = font_name
run.font.size = Pt(size)
run.font.rtl = True
paragraph = doc.add_paragraph()
run = paragraph.add_run("טקסט בעברית.")
set_font(run, "David", 14)
doc.add_page_break()
doc.save('example.docx')`

I've been playing around with this issue a bit on my own. Opening up the document.xml inside the zip, what I see is that, when <w:rtl/> is present, the other properties of the font are ignored. For example, a document created would have run properties:
<w:rPr><w:rFonts w:ascii="Arial" w:hAnsi="Arial"/><w:rtl/></w:rPr>
From a manually-created document, I see that the Hebrew text actually has run properties:
<w:rPr><w:rFonts w:ascii="Aharoni" w:hAnsi="Aharoni" w:cs="Aharoni" w:hint="cs"/><w:lang w:val="en-US"/></w:rPr>
If I manually edit the document.xml above and add w:cs and w:hint as in the manual document, it looks like it actually keeps the properties we're trying to set:
<w:rPr><w:rFonts w:ascii="Aharoni" w:hAnsi="Aharoni" w:cs="Aharoni" w:hint="cs"/><w:rtl/></w:rPr>
I do not understand enough about the specific attributes in the Word XML format to really understand what I've done here, but perhaps this can move us forward? This would also affect #973 and #510 , I think.


Invalid X-Requested-With header using Okta

I am using Istio as an ingress gateway and trying to setup okta within a sidecar proxy but keep running into a 'Invalid X-Requested-With header' error. istio holds the self-signed cert to my app https://myapp.com that gateway has mTLS enabled to my service via TCP 7000 which then communicates with a nodejs app using http://www.passportjs.org/packages/passport-okta-oauth/
Okta is setup as follows:
Login redirect: https://myapp.com/api/auth/okta/handler/frame
Logout: https://myapp.com/api/auth/okta/logout
Initiate Login: https://myapp.com/api/auth/okta/start
App logs:
GET https://myapp.com/api/auth/okta/refresh?optional&env=development
GET https://myapp.com/api/auth/okta/start?scope=openid email profile offline_access&env=development
App Setup:
clientId/clientSecret/audience is set to https://my-domain.oktapreview.com
Front end error to user who has access is: Authentication failed, Failed to obtain access token
Front end error to user who does not have access: Authentication rejected, User is not assigned to the client application

This seems highly okta specific. Unfortunately, we are not okta experts, so there isn't enough info here. if there is some way we can reproduce this or troubleshoot further please open an issue following the issue template. Thanks!


Nested relations with Tupleable

Is it possible to model nested relations with Haskell types? I've tried
data Blog = Blog
  { title :: Text
  , comments :: [Comment] -- and  :: Set Comment
  } deriving (Generic, Tupleable)

data Comment = Comment
  { authorName :: Text
  , comment :: Text
  } deriving (Generic, Tupleable, Show, Eq, Binary, NFData, Atomable)

but [Comment] and Set Comment are converted to ConstructedAtom instead of RelationAtom.

It is possible to use nested relations with Tupleable but not with the generically-derived instance. The issue is that generics don't provide sufficient type information to marshal a RelationAtom back-and-forth.
However, you can easily hardcode the type information yourself into the Tupleable instance- just implement toTuple, fromTuple, and toAttributes.
Historical note: the original Tupleable instance did contain sufficient type information to marshal RelationAtoms, but the additional type information made it a burden on all other types, so I removed it.

Let me know if an example would be helpful. It would probably be useful to others, as well.

An example would be great, you could extend https://github.com/agentm/project-m36/blob/master/docs/tupleable.markdown with it.

Can I implement Atomable [Comment] and use generics for Tupleable Blog and Tupleable Comment instead?

@koenigmaximilian , please take a look at the new example.
Let me know if you have any questions.

@agentm Thanks!

@agentm Thank you!

hi @agentm
I am looking generic ways to make nested relations too.

Historical note: the original Tupleable instance did contain sufficient type information to marshal RelationAtoms, but the additional type information made it a burden on all other types, so I removed it.

What if typeclass Atomable turns a record type (whose fields have selector names) into a RelationAtom. In this way, typeclass Tupleable will generically turn a record field with Atomable typeclass into a RelationAtom.
It's intuitive to me since a type whose fields with selector names kind of matches a relation with attribute names. ConstructedAtom seems lose some information about selector names.
I would like to hear some opinion of yours. What do you think about this idea? Is it reasonable to make it deafult?
What I can think of is ...
one of (very odd) case is when two record types makes each other its own field. In this way there will be infinite RelationAtoms. So do ConstructedAtoms. But it seems still worth to generically model nested relations from Haskell types.

I think I wasn't thinking it through.
A RelationAtom is a Relation that can has many tuples.
However, a field of record type can only be a relation with only one tuple.
A RelationAtom is more like a field of a list of record type in haskell rather than a field of record type.
An Atom is more like a sum type.
And a Relation is more like a product type.
RelationAtom seems used in group senario.
I guess I'll go with the custom Tupleable example.

Indeed, the nesting is tricky to represent generically. There are a few options:

provide an optional hook in Tupleable for RelationAtoms (with a default of no support)
provide a NestedTupleable instance which looks like the old one but supports nesting
offer more complex typeclass gymnastics which are probably beyond my abilities to represent

None of the options are particularly appealing, which I why I simply chose to force users to implement their own Tupleable instance for this unusual case.
Please let me know if you gain any further insight into how this could be represented better.

Thanks for the advice! After further thinking, I come to this conclusion.
My scenario is storing DbRecord a of project-m36-typed in project-m36.
It saves additional information about a haskell value/ a m36 tuple.
I can:

make it a one big, flat relation.
make it two relations. The record one has a foreign key for the entity one's identifier.
I guess option 2 is better, formal way to use relational algebra to implement a database. Since it use foreign key and join.

Nested relations seems more like statistics report, which needs aggregation operation, afterwards. So I think, too, it is not necessary to implement a haskell value-to-nested relation internally.


Overlay: You can touch an element outside the overlay but not click it

Bug type
Component
Component name
MudOverlay
What happened?
An opened overlay will stop you from clicking on any other elements outside of it, but you can still touch them if you use a phone.
stopPropagation is enabled but not preventDefault.
Expected behavior
I believe you should be able to touch and hover elements outside the popover overlay no matter what pointer device you're using.
Reproduction link
https://mudblazor.com/docs/overview
Reproduction steps

Go to the docs overview
Open the search panel
Try to click a button on the page (it will just close the popover)
Now try the same thing but touch (it will close the popover AND click the element)

Relevant log output
No response
Version (bug)
6.19.1
Version (working)
No response
What browsers are you seeing the problem on?
Edge
On which operating systems are you experiencing the issue?
Windows
Pull Request

[X] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

You can see this really annoying behavior when you have the search panel open on the docs and you try to refocus to the search box.
https://github.com/MudBlazor/MudBlazor/assets/7112040/b2a7c16b-5675-427b-b651-68df74b1b66f

Essentially need to use pointer-events: none but still capture the click event

Don't overlays usually prevent you from interacting with elements that are visible behind the overlay? If anything, allowing passthrough should be configurable in some way if required.

Don't overlays usually prevent you from interacting with elements that are visible behind the overlay? If anything, allowing passthrough should be configurable in some way if required.

@Anu6is See this for my problem https://github.com/MudBlazor/MudBlazor/issues/8644#issuecomment-2048986188

Yeah, I watched it. And it may be a case for the configurable passthrough. I just think that the expected behavior with overlays is that you can't interact with the things behind it by default.

Closing since GitHub, MUI, and Twitter work like the current behaviour. AntBlazor works like I imagine it but I probably need to work on a more specific issue, namely for the search.


[ISSUE #3275]test common: add unit test cases

Add unit test cases (#3275) for org.apache.shenyu.common.concurrent

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project shenyu-common: You have 11 Checkstyle violations. -> [Help 1]

@Albertsirius
Hi, this pr has some code formatting errors, you can use checkstyle locally to check and correct.
https://shenyu.apache.org/zh/community/code-suggestions
There are configuration files for checkstyle in this link. It is recommended to use the idea plug-in for formatting checking, and the version of checkstyle can be 8.11.

Codecov Report

Merging #3371 (f8a2767) into master (24b299b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3371      +/-   ##
============================================
- Coverage     65.23%   65.19%   -0.04%
- Complexity     5240     5256      +16
============================================
  Files           760      760
  Lines         21224    21224
  Branches       1932     1932
============================================
- Hits          13846    13838       -8
+ Misses         6090     6087       -3
- Partials       1288     1299      +11

Impacted Files
Coverage Δ

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
70.00% <0.00%> (-13.34%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
74.79% <0.00%> (-8.95%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-8.52%)
:arrow_down:

...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java
66.66% <0.00%> (-5.56%)
:arrow_down:

.../logging/rocketmq/utils/LogCollectConfigUtils.java
71.11% <0.00%> (-4.45%)
:arrow_down:

...in/response/strategy/NettyClientMessageWriter.java
69.56% <0.00%> (-4.35%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b299b...f8a2767. Read the comment docs.


Include stdint.h for int64_t

[X] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

coverage: 89.864% (-0.2%) from 90.024%
when pulling 2772234d99489e061d42b801672431a65ce9bc8f on brianquinlan:clang
into 6793812a5363bbec8462b08535100bb8e11f3ef7 on dart-lang:main.


Update readme.md with info on Safari support

Compliments #234
#234 also changes the Safari logo from b&w to colored.

I think you got confused with Safari Technology Preview, which does support copy/cut:
https://webkit.org/blog/6017/introducing-safari-technology-preview/
Safari 9.1 still don't have this feature implemented: https://developer.apple.com/library/mac/releasenotes/General/WhatsNewInSafari/Articles/Safari_9_1.html
Thanks for your pull request anyways ;)


Refactored version

@chollier Great work in porting this library to react. I took some time and refactored your code greatly as it currently lacks a lot of functionalities the original plugin has. I added custom icons, locale features (#58, #80, #96, #126, #130), 24 hours support (#105), minDate and maxDate support (#114, #115), better positioning (#95, #131, #137), toolbar (#103) and transitions using react-overlays, added decade view and probably many more. Still it needs some more work to implement all the original options but most is done. I didn't rewrite any of the tests yet.
Check out my fork and tell me what do you think. Maybe we could merge it together and make a major version upgrade and work on this together from now on?
https://github.com/LKay/react-bootstrap-datetimepicker
EDIT:
I followed the original documentation while implementing features so the component will accept the same options as here http://eonasdan.github.io/bootstrap-datetimepicker/Options/ with pretty much same format (few imporvements added). I also renamed (and deprecated) dateTime and size to value and bsSize to be more coherent with react-bootstrap naming (the old ones will still work as before).

@LKay I just tried your fork, but it appears that the ES6 import functionality has regressed. e.g. this stopped working: import DateTimeField from 'react-bootstrap-datetimepicker';

I think it may be because the npm-build setting has been removed from his package.json, so if you pulled down his version through npm, it's not creating the library

Ah, thanks for the explanation @shadowii - I ended up switching back to this repo and didn't look into it any further. That would also explain some of the other errors I saw when I ran webpack.

@mohanzhang It's not yet PR ready so you can import it straight to your project by downloading files via npm. This is more like a preview version right now as build script has to be automated. For now if you want to test the component in your app then you have to clone my fork and run npm run build-npmwhich will create you libdirectory with ES6->ES5 transpiled files which you can import to your project (package.json has already defined mainproperty pointing to ìndex.jsfile inside lib` directory).
If you want just preview (a very simple one for now) clone the form and run npm start and open localhost:8080in your browser.
@shadowii The name doesn't matter as main component is returned by export defaultso you can name it anything in your import.

@mohanzhang I added build scripts and builded files to the repo so try to fetch my fork and see if it works fine now if you replace it in your package.json file.

@LKay pulling it from NPM now works, thanks.
Unfortunately DateTimePickerLayoutInput seems to depend on the browser and I can't seem to run it with a isomorphic js setup.
The line in question is 141 in input.js: DateTimePickerLayoutInput.defaultProps = {     container: global.document.querySelector("body") };

Maybe my fork is better for issues in my code.
Anyway picker doesn't entirely depend on browser, yet it's most common and preferred way of use the plugin, though. I added support for property widgetParent in which you can specify the React compatible node to act as an container for popover so it doesn't have to be an actual DOM node but an other React component for example.
By default,I assumed the code is run in the browser so default container should be document's root element for positioning.

@LKay I really like the changes you've made to the library, I definitely encourage you to make a pull request so it can be merged into upstream.  I've created a couple of issues and a pull request to your fork, but hasn't gotten any feedback from you. If you have abandoned the project, please let us know

@vakopian I have not abandoned the project, yet a I was busy with some other work and lack time recently. I was not getting github notifications for some reason either... I'll take a look at the issues there but about merging it to the main branch I'd like to first add some tests before that.

sadly there seems to be no progress here :-(


About training

Hi! Thanks for the great work.
Did you train BSD_2ms16ms and BSD_3ms24ms on 1ms8ms pretrained model?

No, we didn't.


Don't break Firefox on Android

Fixes #52
For https://github.com/refined-github/refined-github/pull/7480

This technically also adds support for the menus permission which Firefox aliases to contextMenu internally