AsyncTelegram2 and other https reliant libraries

Hi, I'm having a hard time trying to merge two projects into one, take for example the lightbot example in the library, and another example, in my case, the thingspeak IOT library (https://github.com/mathworks/thingspeak-arduino) This library allows making HTTP or HTTPS connections to update sensor values on the Thingspeak site.
Is it possible for AsyncTelegram2 to connect and update while in the same app updating the other library? Tried HTTP and HTTPS in the thingspeak library and either AT2 doesn't connect or TS fails at updating.
Thanks

Hi @pablopeu
I'm trying to work with mathworks ThingSpeak IOT library, but with ESP32 seems not working also the included example WriteSingleFieldSecure.ino as is (using HTTPS).
No problem with HTTP connection indeed, even togheter with AsyncTelegram2, but using two distinct client (WiFiClientSecure for AsyncTelegram2 and WiFiClient for ThingSpeak).

Hi @cotestatnt thanks for the reply.
Based on your suggestion to use nonsecure thingspeak as this example works, here is the code I made merging you echobot code (sans the your public channel update and LED) with the thingspeak example.
Both of these run alone work as expected, but when merged only thingspeak. The telegram bot is not updated but is properly detected. Not even the welcome message is sent.
Testing on esp32
I'm sure botching something LOL but can't see it.
`/*
WriteMultipleFields Library Example
Description: Writes values to fields 1,2,3,4 and status in a single ThingSpeak update every 20 seconds over secured HTTPS connection.
Hardware: ESP32 based boards
!!! IMPORTANT - Modify the secrets.h file for this project with your network connection and ThingSpeak channel details. !!!
Note:

Requires installation of EPS32 core and WiFiClientSecure library. See https://github.com/espressif/arduino-esp32/blob/master/docs/arduino-ide/boards_manager.md for details.
Select the target hardware from the Tools->Board menu
This example is written for a network using WPA encryption. For WEP or WPA, change the WiFi.begin() call accordingly.

ThingSpeak ( https://www.thingspeak.com ) is an analytic IoT platform service that allows you to aggregate, visualize, and
analyze live data streams in the cloud. Visit https://www.thingspeak.com to sign up for a free account and create a channel.
Documentation for the ThingSpeak Communication Library for Arduino is in the README.md folder where the library was installed.
See https://www.mathworks.com/help/thingspeak/index.html for the full ThingSpeak documentation.
For licensing information, see the accompanying license file.
Copyright 2020, The MathWorks, Inc.
*/
/*
Name:        echoBot.ino
Created:     26/03/2021
Author:      Tolentino Cotesta<EMAIL_ADDRESS>Description: a simple example that check for incoming messages
and reply the sender with the received message.
The message will be forwarded also in a public channel
anad to a specific userid.
*/
/*
Set true if you want use external library for SSL connection instead ESP32@WiFiClientSecure
For example https://github.com/OPEnSLab-OSU/SSLClient/ is very efficient BearSSL library.
You can use AsyncTelegram2 even with other MCUs or transport layer (ex. Ethernet)
With SSLClient, be sure "certificates.h" file is present in sketch folder
*/
#define USE_CLIENTSSL true
#include <AsyncTelegram2.h>
// Timezone definition
#include <time.h>
#define MYTZ "CET-1CEST,M3.5.0,M10.5.0/3"
#ifdef ESP8266
#include <ESP8266WiFi.h>
BearSSL::WiFiClientSecure client;
BearSSL::Session   session;
BearSSL::X509List  certificate(telegram_cert);
#elif defined(ESP32)
#include <WiFi.h>
#include <WiFiClient.h>
#if USE_CLIENTSSL
#include <SSLClient.h>
#include "tg_certificate.h"
WiFiClient base_client;
SSLClient client(base_client, TAs, (size_t)TAs_NUM, A0, 1, SSLClient::SSL_ERROR);
#else
#include <WiFiClientSecure.h>
WiFiClientSecure client;
#endif
#endif
// #include <WiFi.h>
#include "secrets.h"
#include "ThingSpeak.h" // always include thingspeak header file after other header files and custom macros
// used secrets.h from the thingspeak  WriteMultipleFields example to put all secret values there
char ssid[] = SECRET_SSID;   // your network SSID (name)
char pass[] = SECRET_PASS;   // your network password
int keyIndex = 0;            // your network key Index number (needed only for WEP)
WiFiClient  cliente;
unsigned long myChannelNumber = SECRET_CH_ID;
const char * myWriteAPIKey = SECRET_WRITE_APIKEY;
// Initialize our values
int number1 = 0;
int number2 = random(0,100);
int number3 = random(0,100);
int number4 = random(0,100);
String myStatus = "";
AsyncTelegram2 myBot(client);
// bot definitions const char* token and int64_t userid = moved to secrets.h for sharing code purposes
void setup() {
Serial.begin(115200);  //Initialize serial
WiFi.mode(WIFI_STA);
WiFi.begin(ssid, pass);
delay(500);
while (WiFi.status() != WL_CONNECTED) {
Serial.print('.');
delay(500);
}
ThingSpeak.begin(cliente);  // Initialize ThingSpeak
#ifdef ESP8266
// Sync time with NTP, to check properly Telegram certificate
configTime(MYTZ, "time.google.com", "time.windows.com", "pool.ntp.org");
//Set certficate, session and some other base client properies
client.setSession(&session);
client.setTrustAnchors(&certificate);
client.setBufferSizes(1024, 1024);
#elif defined(ESP32)
// Sync time with NTP
configTzTime(MYTZ, "time.google.com", "time.windows.com", "pool.ntp.org");
#if USE_CLIENTSSL == false
client.setCACert(telegram_cert);
#endif
#endif
// Set the Telegram bot properies
myBot.setUpdateTime(2000);
myBot.setTelegramToken(token);
// Check if all things are ok
Serial.print("\nTest Telegram connection... ");
myBot.begin() ? Serial.println("OK") : Serial.println("NOK");
Serial.print("Bot name: @");
Serial.println(myBot.getBotName());
char welcome_msg[128];
snprintf(welcome_msg, 128, "BOT @%s online\n/help all commands avalaible.", myBot.getBotName());
// Send a message to specific user who has started your bot
myBot.sendTo(userid, welcome_msg);
}
void loop() {
TBMessage msg;
// if there is an incoming message...
if (myBot.getNewMessage(msg)) {
// Send a message to your public channel
String message ;
message += "Message from @";
message += myBot.getBotName();
message += ":\n";
message += msg.text;
Serial.println(message);
// myBot.sendToChannel(channel, message, true);

// echo the received message
myBot.sendMessage(msg, msg.text);

}
// set the fields with the values
ThingSpeak.setField(1, number1);
ThingSpeak.setField(2, number2);
ThingSpeak.setField(3, number3);
ThingSpeak.setField(4, number4);
// figure out the status message
if(number1 > number2){
myStatus = String("field1 is greater than field2");
}
else if(number1 < number2){
myStatus = String("field1 is less than field2");
}
else{
myStatus = String("field1 equals field2");
}
// set the status
ThingSpeak.setStatus(myStatus);
// write to the ThingSpeak channel
int x = ThingSpeak.writeFields(myChannelNumber, myWriteAPIKey);
if(x == 200){
Serial.println("Channel update successful.");
}
else{
Serial.println("Problem updating channel. HTTP error code " + String(x));
}
// change the values
number1++;
if(number1 > 99){
number1 = 0;
}
number2 = random(0,100);
number3 = random(0,100);
number4 = random(0,100);
delay(20000); // Wait 20 seconds to update the channel again
}
`

small update, if I change  #define USE_CLIENTSSL true to false I get the welcome message, but not the echo

it was the delay(20000)... replaced it with a timer and received all the replies at once LOL
here is the code, I'm sure will help someone else:
`/*
WriteMultipleFields Library Example
Description: Writes values to fields 1,2,3,4 and status in a single ThingSpeak update every 20 seconds over secured HTTPS connection.
Hardware: ESP32 based boards
!!! IMPORTANT - Modify the secrets.h file for this project with your network connection and ThingSpeak channel details. !!!
Note:

Requires installation of EPS32 core and WiFiClientSecure library. See https://github.com/espressif/arduino-esp32/blob/master/docs/arduino-ide/boards_manager.md for details.
Select the target hardware from the Tools->Board menu
This example is written for a network using WPA encryption. For WEP or WPA, change the WiFi.begin() call accordingly.

ThingSpeak ( https://www.thingspeak.com ) is an analytic IoT platform service that allows you to aggregate, visualize, and
analyze live data streams in the cloud. Visit https://www.thingspeak.com to sign up for a free account and create a channel.
Documentation for the ThingSpeak Communication Library for Arduino is in the README.md folder where the library was installed.
See https://www.mathworks.com/help/thingspeak/index.html for the full ThingSpeak documentation.
For licensing information, see the accompanying license file.
Copyright 2020, The MathWorks, Inc.
*/
/*
Name:        echoBot.ino
Created:     26/03/2021
Author:      Tolentino Cotesta<EMAIL_ADDRESS>Description: a simple example that check for incoming messages
and reply the sender with the received message.
The message will be forwarded also in a public channel
anad to a specific userid.
*/
/*
Set true if you want use external library for SSL connection instead ESP32@WiFiClientSecure
For example https://github.com/OPEnSLab-OSU/SSLClient/ is very efficient BearSSL library.
You can use AsyncTelegram2 even with other MCUs or transport layer (ex. Ethernet)
With SSLClient, be sure "certificates.h" file is present in sketch folder
*/
#define USE_CLIENTSSL false
#include <AsyncTelegram2.h>
// Timezone definition
#include <time.h>
#define MYTZ "CET-1CEST,M3.5.0,M10.5.0/3"
#ifdef ESP8266
#include <ESP8266WiFi.h>
BearSSL::WiFiClientSecure client;
BearSSL::Session   session;
BearSSL::X509List  certificate(telegram_cert);
#elif defined(ESP32)
#include <WiFi.h>
#include <WiFiClient.h>
#if USE_CLIENTSSL
#include <SSLClient.h>
#include "tg_certificate.h"
WiFiClient base_client;
SSLClient client(base_client, TAs, (size_t)TAs_NUM, A0, 1, SSLClient::SSL_ERROR);
#else
#include <WiFiClientSecure.h>
WiFiClientSecure client;
#endif
#endif
// #include <WiFi.h>
#include "secrets.h"
#include "ThingSpeak.h" // always include thingspeak header file after other header files and custom macros
char ssid[] = SECRET_SSID;   // your network SSID (name)
char pass[] = SECRET_PASS;   // your network password
int keyIndex = 0;            // your network key Index number (needed only for WEP)
WiFiClient  cliente;
unsigned long myChannelNumber = SECRET_CH_ID;
const char * myWriteAPIKey = SECRET_WRITE_APIKEY;
unsigned long thingtimer=millis()+20000;
// Initialize our values
int number1 = 0;
int number2 = random(0,100);
int number3 = random(0,100);
int number4 = random(0,100);
String myStatus = "";
AsyncTelegram2 myBot(client);
// bot definitions const char* token and int64_t userid = moved to secrets.h for sharing code purposes
void setup() {
Serial.begin(115200);  //Initialize serial
WiFi.mode(WIFI_STA);
WiFi.begin(ssid, pass);
delay(500);
while (WiFi.status() != WL_CONNECTED) {
Serial.print('.');
delay(500);
}
ThingSpeak.begin(cliente);  // Initialize ThingSpeak
#ifdef ESP8266
// Sync time with NTP, to check properly Telegram certificate
configTime(MYTZ, "time.google.com", "time.windows.com", "pool.ntp.org");
//Set certficate, session and some other base client properies
client.setSession(&session);
client.setTrustAnchors(&certificate);
client.setBufferSizes(1024, 1024);
#elif defined(ESP32)
// Sync time with NTP
configTzTime(MYTZ, "time.google.com", "time.windows.com", "pool.ntp.org");
#if USE_CLIENTSSL == false
client.setCACert(telegram_cert);
#endif
#endif
// Set the Telegram bot properies
myBot.setUpdateTime(2000);
myBot.setTelegramToken(token);
// Check if all things are ok
Serial.print("\nTest Telegram connection... ");
myBot.begin() ? Serial.println("OK") : Serial.println("NOK");
Serial.print("Bot name: @");
Serial.println(myBot.getBotName());
char welcome_msg[128];
snprintf(welcome_msg, 128, "BOT @%s online\n/help all commands avalaible.", myBot.getBotName());
// Send a message to specific user who has started your bot
myBot.sendTo(userid, welcome_msg);
}
void loop() {
TBMessage msg;
// if there is an incoming message...
if (myBot.getNewMessage(msg)) {
// Send a message to your public channel
String message ;
message += "Message from @";
message += myBot.getBotName();
message += ":\n";
message += msg.text;
Serial.println(message);
// myBot.sendToChannel(channel, message, true);

// echo the received message
// myBot.sendMessage(msg, msg.text); //no anda
myBot.sendTo(userid, msg.text);

}
// myBot.sendTo(userid, "Mande fruta al 2020");
if (millis() > thingtimer) thingspeak();
}
void thingspeak(){
thingtimer=millis()+20000;
// set the fields with the values
ThingSpeak.setField(1, number1);
ThingSpeak.setField(2, number2);
ThingSpeak.setField(3, number3);
ThingSpeak.setField(4, number4);
// figure out the status message
if(number1 > number2){
myStatus = String("field1 is greater than field2");
}
else if(number1 < number2){
myStatus = String("field1 is less than field2");
}
else{
myStatus = String("field1 equals field2");
}
// set the status
ThingSpeak.setStatus(myStatus);
// write to the ThingSpeak channel
int x = ThingSpeak.writeFields(myChannelNumber, myWriteAPIKey);
if(x == 200){
Serial.println("Channel update successful.");
}
else{
Serial.println("Problem updating channel. HTTP error code " + String(x));
}
// change the values
number1++;
if(number1 > 99){
number1 = 0;
}
number2 = random(0,100);
number3 = random(0,100);
number4 = random(0,100);
}
`


show crates.io search errors to the user without logging them

We are using the crates.io search API to power our own crate-search.
Sometimes the crates.io API returns 4xx or 5xx errors because of wrong queries or timeouts.
These errors can be shown to the user, but there is no need to report them to sentry or log them as errors.
We could add a new metric to track the amount of errors.

instructions:

web::releases::get_search_results fetches the search results, it's used in web::releases::search_handler
our logging config would send everything that is logged with tracing::error! to sentry, and also every server error
so either the handler or the method have to be changed so we don't generate a server error any more, but just a warning.

@rustbot claim


Examples on http://leafletjs.com/examples/wms/wms.html are not working anymore

The wms examples on the site
http://leafletjs.com/examples/wms/wms.html
are not working anymore.
I hope this is the right place to communicate this issue.

Hi! Thanks for reporting, this is indeed the right place to do so.
However, this is a duplicate of #5540, so I'm closing this now!


variables.tf question

Is there any reason why ams1 is commented in this file? https://github.com/webplates/terraform-jmeter/blob/master/variables.tf#L34

According to the UI you can't create droplets in the AMS1 region at the moment:


DNSproblem

when i run test scripts, it shows following bug:
srun: error: resolve_ctls_from_dns_srv: res_nsearch error: Unknown host
srun: error: fetch_config: DNS SRV lookup failed
srun: error: _establish_config_source: failed to fetch config
srun: fatal: Could not establish a configuration source

How about simply remove all the content related to srun?


add additional chart pull options

How to categorize this PR?

/area usability
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR adds additional possibilities to reference a helm chart in the helm deployer.
Before it was only possible to specify a oci artifact that complies to the helm oci artifact spec.
Now it is also possible to specify helm charts via

base64 encoded gzip tarball
url that returns a gzip tarball
component descriptor resource (localOCIBlob or ociRegistry)

I also added a simple integration test that test if the tutorial ingress chart is successfully reconciled.
This change is needed in order to support pure inline blobs.
The tutorial will be adjusted as soon as all components support inline blobs
Special notes for your reviewer:
@hendrikKahl @MrBatschner with your change of the inline component descriptor, we may also need to adjust the fromResource struct.
Release note:

[Helm Deployer] It is now possible for specify the helm chart that is deployed by the helm deployer deployer either
- with a oci artifact ref
- as base64 encoded gzip archive
- from a remote url
- or from a component descriptor resource of type `helm` or `helm.io/chart` (preferred)

/invite @Diaphteiros @MrBatschner @hendrikKahl

/invite @Diaphteiros @MrBatschner @hendrikKahl


How to call javascript method from my plugin file (iOS-platform)

I created a cordova-plugin for my ionic-1 app (iOS Platform). I want to call method that has been created in js file of my ionic project, from native iOs class in objective-c file of my cordova-plugin.

Unfortunately this repository is only for issues about cordova-docs, the website and documentation itself. Your question is more fitting for the Cordova Slack (slack.cordova.io), JIRA issues for cordova-ios (issues.cordova.io) or even the Ionic forum at forum.ionicframework.com. Thank you.


[docs][base] FocusTrap not focusing back to the Box in Firefox

Fixes https://github.com/mui/material-ui/issues/37866#issue-1794776081
Description
The reason why in Firefox, doesn't focus back / bring the relevant component in view in the docs section is rather how the focus() event works in Firefox. For reference check this video on how the focus works when we manually bring an element into view -

Firefox

https://github.com/mui/material-ui/assets/40322760/1ac1de8a-70e6-4deb-9564-28ead1918e62

Chrome

https://github.com/mui/material-ui/assets/40322760/bf9efd9f-7b2b-4116-9711-3d93fb520e0e
Solution - 1
In my fix I've broken down the focus in 2 parts

First we scroll the element into the view, which is centered
Then we focus it with preventScroll to reset the focus

Solution - 2
Since, this is a desired outcome of Firefox, instead of this fix we can instead, also update the documentation highlighting the fact that this is expected in Firefox.

[x] I have followed (at least) the PR section of the contributing guide.

@michaldudak Do let me know once you get some time to take a look :eyes: into this PR, and have any concerns or questions for the same.

Thanks for the PR. I tested and found one issue. See the screen recording below:
FocusTrap.Base.UI.issue.mp4
When it is clicked just below the demo box it snaps back into view, whereas in the production version it does not.
Also, the unit test failed.

Hey, @ZeeshanTamboli This was expected behavior and it happens, because scrollIntoView centers the element in the screen and for this fix to work in Firefox, it would be needed since focus() works a bit differently in it.
We can assert if the element is visible in the viewport, if yes, then we will only focus it, if not then we'll scroll into view and then focus it. Thoughts on it?

@divyammadhok The screen recording I shared above was captured on Google Chrome browser, so it should function the same way as the production documentation.

We can assert if the element is visible in the viewport, if yes, then we will only focus it, if not then we'll scroll into view and then focus it. Thoughts on it?

I don't think it's worth it to have such calculations. Perhaps a solution could be to only scroll into view for the Firefox browser?

@divyammadhok The screen recording I shared above was captured on Google Chrome browser, so it should function the same way as the production documentation.

We can assert if the element is visible in the viewport, if yes, then we will only focus it, if not then we'll scroll into view and then focus it. Thoughts on it?

I don't think it's worth it to have such calculations. Perhaps a solution could be to only scroll into view for the Firefox browser?

Will look into it @ZeeshanTamboli Should we implement different behaviors in different browsers though? Isn't it very possible that some other browser may implement .focus() differently? We can check how this works in Safari.

Upon reflection, since it's a native behavior in Firefox, we won't be able to have a proper solution on our side to adjust it on Firefox browser. We should let Firefox handle it. Thanks for the PR. I am closing the issue.

Looks like the right way to go at the moment. Thanks.


CoreTextServicesManager.GetForCurrentView() throws exceotion in WinUI3 for Desktop preview 4

When running the following code
 var manager = CoreTextServicesManager.GetForCurrentView();
The following exception is thrown

System.Runtime.InteropServices.COMException: 'The application called an interface that was marshalled for a different thread. (0x8001010E (RPC_E_WRONG_THREAD))'

The calling thread is the ui thread. Looks like a bug.

As of preview 4 api's which require a core window now throw, these are largely the API's that have CurrentView in their title likeGetForCurrentView() @anawishnoff Do we have documentation for this issue?  It is strange that we are throwing a wrong thread exception.. @Austin-Lamb Should we look at the exception we throw for this?

As @StephenLPeters said, this is an expected issue of Preview 4 - most GetForCurrentView() methods are no longer supported in Desktop apps. You can see more info in this doc (which is getting regularly updated as we identify more APIs and their workarounds).

I found that doc helpful, for other issues, but I don't find any replacement for CoreTextServicesManager. Did I miss something?

Hi @arivoir , I actually expect CoreTextServicesManager.GetForCurrentView() to work fine in this context.  I've tried it in a simple WinUI 3 Preview 4 Desktop app and it doesn't throw.  Would you be willing to share a larger sample of your repro so I could have a look?

The issue can be easily reproduced by executing that code in a custom control constructor
public sealed class CustomControl1 : Control
{
    public CustomControl1()
    {
        this.DefaultStyleKey = typeof(CustomControl1);
        var manager = CoreTextServicesManager.GetForCurrentView();
        var editContext = manager.CreateEditContext();
    }
}

And then in xaml
       <local:CustomControl1 />

There it is the repro sample
App4.zip

Ah, thanks @arivoir  -- turns out this is only working in insider Windows builds, unfortunately all the shipping versions of Windows are failing in the way you've mentioned.  We'll add this to the list.  Sorry for the oversight and thanks for letting us know.

@Austin-Lamb why was this closed. Is there any way to use text services now?

This bug is still happening in WinUI3 version 0.8
I updated the repro sample
App4.zip

@JesseCol any update on the support for CoreTextServicesManager? Last we looked, it was only working on Insider builds.

Confirmed this is fixed in Win11.
@arivoir - Since this is an OS fix, do you have need to service this back to Win10?

I need it everywhere WinUi3 runs, so yes, I need it in Win10 too

Hi @andrewleader and @AdamBraden , I would need it for Windows 10 1809 IoT Enterprise LTSC

Hi @andrewleader and @AdamBraden , are there any updates about this issue?
Can the fix be backported to Windows 10 1809 IoT Enterprise LTSC please?

The exception is no longer thrown, but the TextUpdating event is not raised for English keyboard. is this expected?


highlights.scm errors

A report this morning in editor-support in discord had me reinstalling/recompiling tree-sitter-nu. I was presented with errors.

This changed stopped the errors but I'm not sure it's a valid change.
;(long_flag ["="] @punctuation.special)
;(short_flag ["="] @punctuation.special)

I think your highlights.scm is the latest while the grammar is not up-to-date.

TSUpdate nu says "Parsers are up-to-date!"

TSUpdate nu says "Parsers are up-to-date!"

Yes, because neovim-ts has its own copy of the parser, which is several days behind this repo.

ah, that makes sense. sorry i'm such a noob on this nvim stuff. trying to get up to speed.

3 solutions here:

remove tree-sitter-nu completely, use all files hosted by neovim-ts
manually specify to use the local version (which is my config for debugging) here:

    config = function(_, opts)
      local parser_config = require("nvim-treesitter.parsers").get_parser_configs()
      parser_config.nu = {
        install_info = {
          url = "~/.config/nushell/tree-sitter-nu", -- local path or git repo
          files = { "src/parser.c" }, -- note that some parsers also require src/scanner.c or src/scanner.cc
          branch = "pr", -- default branch in case of git repo if different from master
          generate_requires_npm = false, -- if stand-alone parser without npm dependencies
          requires_generate_from_grammar = false, -- if folder contains pre-generated src/parser.c
        },
        filetype = "nu", -- if filetype does not match the parser name
      }
      require("nvim-treesitter.configs").setup(opts)
    end,

simply wait for some days, and they will sync :-).

ah, that makes sense. sorry i'm such a noob on this nvim stuff. trying to get up to speed.

This nvim-ts config is really confusing, I still don't know how to specify local queries in install_info, and updating the grammar locally is also weird.
And please keep this issue open for others facing the same problem.

After doing step 2, I still get the error. So, I copied the scm files to nvim-data and things seem to be working fine. Is there a way to tell what version of tree-sitter-nu I'm running?

@fdncred Sorry for not making it clear, actually these are exclusive solutions, not steps to follow.
If you choose method 2, you still need to install tree-sitter-nu (using a plugin manager or as a dependency of nvim-ts) for its latest highlights.scm. Otherwise you're using grammar > highlight.scm, which will also cause similar problems.
And I suppose even after they upgrade the nu parser, method 1 will become problematic since it still use old highlights.scm, I may need to create a PR to nvim-ts for the change.

ya, i understood that they weren't steps. I did option 2 and got it working after i copied the scm files.

@fdncred that's weird, if you don't remove tree-sitter-nu, it should work fine without requiring to manually copy the scm files. Manually copying just solves everything though.

I'm still hitting this, although it may be something "slightly" different
Error in decoration provider treesitter/highlighter.win:
Error executing lua: /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 194:2. Invalid node type "long_flag_equals_value":
(long_flag_equals_value ["--"] @punctuation.delimiter)
 ^

A few times I thought it was fixed, but it always seems to come back.  Any workaround?

Maybe what I'm seeing isn't even teh same issue?  I have this problem even on latest commit of tree-sitter-nu
Error in decoration provider treesitter/highlighter.win:
Error executing lua: /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:252: Query error at 194:2. Invalid node type "long_flag_equals_value":
(long_flag_equals_value ["--"] @punctuation.delimiter)
 ^

stack traceback:
        [C]: in function '_ts_parse_query'
        /usr/share/nvim/runtime/lua/vim/treesitter/query.lua:252: in function 'fn'
        /usr/share/nvim/runtime/lua/vim/func/_memoize.lua:58: in function 'fn'
        /usr/share/nvim/runtime/lua/vim/func/_memoize.lua:58: in function 'get'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:28: in function 'new'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:243: in function 'get_query'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:191: in function 'fn'
        /usr/share/nvim/runtime/lua/vim/treesitter/languagetree.lua:491: in function 'for_each_tree'
        /usr/share/nvim/runtime/lua/vim/treesitter/highlighter.lua:178: in function 'prepare_highlight_states'
        /usr/share/nvim/runtime/lua/vim/trees

where I've installed latest with
local parser_config = require("nvim-treesitter.parsers").get_parser_configs()
parser_config.nu = {
  install_info = {
    url = "https://github.com/nushell/tree-sitter-nu",
    files = { "src/parser.c", "src/scanner.c" },
    branch = "main",
  },
  filetype = "nu",
}

Haven't been able to figure out any way around this without disabling treesitter entirely.


Remove the requirement to mock templates.

It shows a warning in the console instead of throwing an error.

This PR removes the requirement of using mock_template.
Related comment and CZO discussion.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@tnmkr ready for review from you.

@zulipbot add "buddy review".

This technical change looks okay -- I did not test.

@zulipbot remove "buddy review".
@zulipbot add "mentor review".

I'm going to move the content into the docs before merging.

I added a comment documenting mock_template in the node tests documentation, and also cleaned up the implementation to use the actual rendering code if a template was not mocked, since that fits what anyone would expect; returning "" is a very weird behavior for a template that hadn't been explicitly mocked.


Update publish.yml

Codecov Report

Merging #90 (f65ca40) into master (5ac3a87) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #90   +/-   ##
=========================================
  Coverage     91.04%   91.04%
  Complexity       38       38
=========================================
  Files             3        3
  Lines            67       67
=========================================
  Hits             61       61
  Misses            4        4
  Partials          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ac3a87...f65ca40. Read the comment docs.


tls.enabled flag not passed to es-index-cleaner

Describe the bug
Since v1.34.0 Jaeger the tls.enabled=true flag is mandatory if other tls.* flags are used: https://github.com/jaegertracing/jaeger/pull/3030
But the Operator does not seem to pass the tls.enabled flag from the es config to the es-index-cleaner CronJob
To Reproduce
Steps to reproduce the behavior:

Create Jaeger instance with a secured connection to Elasticsearch

...
    storage:
      elasticsearch:
        name: elasticsearch
      esIndexCleaner:
        enabled: true
        numberOfDays: 10
        resources: {}
        schedule: 55 22 * * *
      options:
        es:
          num-replicas: 0
          num-shards: 5
          server-urls: https://jaeger-es-http:9200
          tls:
            ca: /es/certificates/tls.crt
            enabled: true
...

Wait for execution of es-index-cleaner Job and observe the following error:

> kubectl logs jaeger-instance1-es-index-cleaner-1653346500-9zsp2 -n instance1
Error: es.tls.* options cannot be used when es.tls.enabled is false
Usage:
  jaeger-es-index-cleaner NUM_OF_DAYS http://HOSTNAME:PORT [flags]

Flags:
      --archive                       Whether to remove archive indices. It works only for rollover
      --es.password string            The password required by storage
      --es.tls.ca string              Path to a TLS CA (Certification Authority) file used to verify the remote server(s) (by default will use the system truststore)
      --es.tls.cert string            Path to a TLS Certificate file, used to identify this process to the remote server(s)
      --es.tls.enabled                Enable TLS when talking to the remote server(s)
      --es.tls.key string             Path to a TLS Private Key file, used to identify this process to the remote server(s)
      --es.tls.server-name string     Override the TLS server name we expect in the certificate of the remote server(s)
      --es.tls.skip-host-verify       (insecure) Skip server's certificate chain and host name verification
      --es.username string            The username required by storage
  -h, --help                          help for jaeger-es-index-cleaner
      --index-date-separator string   Index date separator (default "-")
      --index-prefix string           Index prefix
      --rollover                      Whether to remove indices created by rollover
      --timeout int                   Number of seconds to wait for master node response (default 120)

2022/05/23 22:55:22 es.tls.* options cannot be used when es.tls.enabled is false

Expected behavior
I expected the tls.enabled flag to be passed by the Operator, just like it's described here:

The connection configuration is derived from the storage options.

Version (please complete the following information):

Jaeger version: 1.34.0
Deployment: Kubernetes

hi, could you please share the output of kubectl describe pod jaeger-instance1-es-index-cleaner-1653346500-9zsp2 ?

hi, could you please share the output of kubectl describe pod jaeger-instance1-es-index-cleaner-1653346500-9zsp2 ?

Name:         jaeger-instance1-es-index-cleaner-1653346500-9zsp2 Namespace:    instance1 Priority:     0 Node:         79462fd7-0bfb-4b78-9436-7b8295881783/<IP_ADDRESS> Start Time:   Tue, 24 May 2022 00:55:16 +0200 Labels:       app=jaeger               app.kubernetes.io/component=cronjob-es-index-cleaner               app.kubernetes.io/instance=jaeger-instance1               app.kubernetes.io/managed-by=jaeger-operator               app.kubernetes.io/name=jaeger-instance1-es-index-cleaner               app.kubernetes.io/part-of=jaeger               controller-uid=68caa012-35dd-4a81-b9fd-3b484489ce8d               job-name=jaeger-instance1-es-index-cleaner-1653346500 Annotations:  kubernetes.io/psp: pks-privileged               linkerd.io/inject: disabled               prometheus.io/scrape: false               sidecar.istio.io/inject: false Status:       Failed IP:           <IP_ADDRESS> IPs:   IP:           <IP_ADDRESS> Controlled By:  Job/jaeger-instance1-es-index-cleaner-1653346500 Containers:   jaeger-instance1-es-index-cleaner:     Container ID:  docker://115257c0008656578a9c9d9a0de3f8c88a10390a3f8ae8bd618644207bf9e062     Image:         remote-docker.artifactory.swisscom.com/jaegertracing/jaeger-es-index-cleaner:1.34.1     Image ID:      docker-pullable://remote-docker.artifactory.swisscom.com/jaegertracing/jaeger-es-index-cleaner@sha256:741cbfce11f27631fd166fded6333889e96a3a986c8070afa29b19b3a7ec249a     Port:          <none>     Host Port:     <none>     Args:       10       https://jaeger-es-http:9200     State:          Terminated       Reason:       Error       Exit Code:    1       Started:      Tue, 24 May 2022 00:55:22 +0200       Finished:     Tue, 24 May 2022 00:55:22 +0200     Ready:          False     Restart Count:  0     Environment Variables from:       jaeger-secret  Secret  Optional: false     Environment:       ES_TLS_CA:  /es/certificates/tls.crt     Mounts:       /es/certificates from es-tls (rw)       /etc/kafka from kafka-tls (rw)       /var/run/secrets/kubernetes.io/serviceaccount from jaeger-instance1-token-c5246 (ro) Conditions:   Type              Status   Initialized       True    Ready             False    ContainersReady   False    PodScheduled      True  Volumes:   es-tls:     Type:        Secret (a volume populated by a Secret)     SecretName:  jaeger-es-http-certs-public     Optional:    false   kafka-tls:     Type:        Secret (a volume populated by a Secret)     SecretName:  jaeger-kafka-tls-cert-secret     Optional:    false   jaeger-instance1-token-c5246:     Type:        Secret (a volume populated by a Secret)     SecretName:  jaeger-instance1-token-c5246     Optional:    false QoS Class:       BestEffort Node-Selectors:  <none> Tolerations:     node.kubernetes.io/not-ready:NoExecute op=Exists for 300s                  node.kubernetes.io/unreachable:NoExecute op=Exists for 300s Events:          <none>

Thanks for reporting, iam on it.

Don't know if it matters, but the instance was updated from 1.33 to 1.34. But describing the jaeger resource shows that the parameters are set correctly for es, so I don't think it's the cause.

I think i know what causes the issue. Let my quickly test few things and i share my thesis.

Summary
As far as I understand there is no flag --es.tls but only --es.tls.*.
So probably we only need to change the name of the env variable from {flag: "es.tls", envVar: "ES_TLS"} to {flag: "es.tls.enabled", envVar: "ES_TLS_ENABLED"}.
Let's see if this solves the problem. :flamingo:
cc @iblancasa
Details
It doesnt contain any Args entry. In the package itself the assignment of the arguments looks a bit strange.
https://github.com/jaegertracing/jaeger-operator/blob/98aa7ebe3f84cfc6c31d1a72ae155c4874a1a27e/pkg/cronjob/es_index_cleaner.go#L24
https://github.com/jaegertracing/jaeger-operator/blob/98aa7ebe3f84cfc6c31d1a72ae155c4874a1a27e/pkg/cronjob/es_index_cleaner.go#L80
But this values are expected: jaeger/cmd/es-index-cleaner/main.go#L49
It seems options are transmitted as environment variables.
// Get has the behavior of returning the value associated with the first
// place from where it is set. Viper will check in the following order:
// override, flag, env, config file, key/value store, default

https://github.com/jaegertracing/jaeger-operator/blob/98aa7ebe3f84cfc6c31d1a72ae155c4874a1a27e/pkg/cronjob/es_rollover.go#L194-L217
See jaeger/pkg/config/tlscfg/flags.go#L28


Is it possible to use it with project local composer.phar?

Curious as well.

what does the question even mean

Good question. In each project, I have composer binary (composer.phar) and run my commands like ./bin/composer update. So, prestissimo can be installed and used locally?

@akalongman what do you have composer.phar in each project for if you run ./bin/composer?

@kubawerlos

what do you have composer.phar in each project for if you run ./bin/composer?
I have bin/composer (file renamed from composer.phar)

OK, so what is the problem with using prestissimo with it?

prestissimo is installed typically as composer global, so it doesn't matter where your composer.phar or bin/composer is, prestissimo will be loaded from $COMPOSER_HOME/vendor, which is typically $HOME/.composer/vendor.
and if it's installed as project dependency it will be vendor/ in your project.

https://getcomposer.org/doc/03-cli.md#composer-home


CI is not working during XML tests

CI seems to be unsuccessful due to some issues during XML tests.
See log: https://github.com/eclipse-aas4j/aas4j/actions/runs/4104140616/jobs/7079228073

Fixed by @arnoweiss


Support for 'H' as a randomization parameter

I think this will work fine, but not sure if it needs unit tests (or what the best way to test it would be).  It seems like the only thing worth testing is whether or not the range passed to Intn() gets incremented so it becomes inclusive - thoughts?

I think the way to test it would be to replace the "random" variable with a random source with a specified seed. Tests are worth it, IMO

So, I did get pretty far down the testing path and ended up abandoning it when I ran into some issues:

I can construct a rand.Source to ensure the same seed is used during tests, but the numbers returned by rand.Intn() would still be a pseudo-random.  I could hardcode tests assuming same stream comes back every time, but that seems brittle?
In the end, if I controlled the random values, it seems like all I would be testing is that the range I'm passing to the Intn function is correct (accounting for half-open range, for example).

Anyway, I struggled with whether that was worth testing or how contrived it would be.  I got as far as mocking rand.Intn() and then validating that given a range {0, 60}, the rand function received {0, 59}.  That seemed pretty silly though, so I dropped it.

I'm quite sure that you are guaranteed that the pseudo-random sequence will not change given the same seed, across different runs of the program. e.g. http://play.golang.org/p/HICPQ5ay90
If you want to control the random numbers provided, declaring a
type rand interface { Int31() int32 }

doesn't seem so bad either.
I do think adding a new feature like this needs some sort of test coverage and documentation update

Any interest in continuing this PR?

@robfig @mhupman Maybe I can take over this PR?

@crazy-max sounds good!


Add pending test count in test summary.

Update TestSummaryForCase  add Pending number.

@harz566 It looks good, but do you have any change test log?

02/08/2020 06:05:04 : [INFO ] End of testing: WALA-VERIFY-HOSTNAME with result: PASS
02/08/2020 06:05:04 : [INFO ] PASS    - 1
02/08/2020 06:05:04 : [INFO ] SKIPPED - 0
02/08/2020 06:05:04 : [INFO ] FAIL    - 0
02/08/2020 06:05:04 : [INFO ] ABORTED - 0
02/08/2020 06:05:04 : [INFO ] PENDING - 1
02/08/2020 06:05:04 : [INFO ] (2/2) testing started: WALA-VERIFY-MNT-RESOURCE-README

Let me check some conditions and come back here. Please keep open this a while.


Modification on cvat-ui doesn't apply when restarting the docker

My actions before raising this issue
I want to disable the image downloading the annotation so i modify some code :
https://github.com/opencv/cvat/blob/master/cvat-ui/src/components/export-dataset/export-dataset-modal.tsx
line 126 : "values.saveImages," changed to "false,"
line 136 : "const resource = values.saveImages ? 'Dataset' : 'Annotations';" changed to "const resource = 'Annotations';"
But unfortunately when i restart the docker (docker compose down then docker compose up) the modification didn't apply.
Could you help me to apply the modification please?
Steps to Reproduce (for bugs)
modify some code in :
https://github.com/opencv/cvat/blob/master/cvat-ui/src/components/export-dataset/export-dataset-modal.tsx
here are the changes :
line 126 : "values.saveImages," changed to "false,"
line 136 : "const resource = values.saveImages ? 'Dataset' : 'Annotations';" changed to "const resource = 'Annotations';"
Expected Behaviour
To Disable indefinitly the checkbox "Save Images" when exporting annotation
Current Behaviour
No Change in the code

@AgapeGithub
You need to restart docker images if you did changes with --build.
Also do not forget to include docker-compose.dev.yml file.

I will close the issue.

Thank you very much everyone, sorry i was off till now so i didn't see your message,
@bsekachev  could you please give me the exact command to execute?
i tried with
docker compose build docker-compose.dev.yml
but it didn't work

Exact command depends on modules you enabled in your CVAT build.
In general it might be like: docker compose -f docker-compose.yml -f docker-compose.dev.yml up -d --build

when i execute it send me this error, could you help me what's wrong in it please?

@zhiltsov-max
Datumaro can't be fetched. Any ideas?

As I see, the building process can't reach github.com. It can happen because of many problems, including internet proxy settings (if proxy is used), and because GitHub can be down (can be checked here).  Please make sure github is reachable during the build.


Flashing step is skipped for nucleo_F429zi platform

Hello :crab: ,
I tried to build and flash the hello_world example to my NucleoF429ZI board, but the flashing stage is entirely skipped.
It seems that currently tools/flash.sh entirely skips the flashing stage for certain platforms.
Is there a workaround to flash a Rust program to my board?
May I ask for advice on how to change the tools/flash.sh script to work for my platform? (NucleoF429ZI)?
Thank you for checking out this issue :+1: :+1:

Terminal output

lonelyjoe@lonelyjoe-desktop:~/workspace/libtock-rs$ make nucleo_f429zi
PLATFORM=nucleo_f429zi cargo build --release --target=thumbv7em-none-eabi --examples
   Compiling libtock v0.2.0 (/home/lonelyjoe/workspace/libtock-rs)
    Finished release [optimized + debuginfo] target(s) in 1.95s
lonelyjoe@lonelyjoe-desktop:~/workspace/libtock-rs$ make flash-nucleo_f429zi EXAMPLE=hello_world
PLATFORM=nucleo_f429zi cargo run --release --target=thumbv7em-none-eabi --example hello_world
   Compiling libtock v0.2.0 (/home/lonelyjoe/workspace/libtock-rs)
    Finished release [optimized + debuginfo] target(s) in 1.09s
     Running `/home/lonelyjoe/workspace/libtock-rs/./tools/flash.sh target/thumbv7em-none-eabi/release/examples/hello_world`
++ basename target/thumbv7em-none-eabi/release/examples/hello_world
+ artifact=hello_world
+++ dirname target/thumbv7em-none-eabi/release/examples/hello_world
++ cd target/thumbv7em-none-eabi/release/examples/../..
++ pwd -P
+ rust_target_folder=/home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi
+ '[' -z 1024 ']'
+ '[' -z 1024 ']'
+ case "${PLATFORM}" in
+ tockloader_flags=
+ binary_name=cortex-m4.elf
+ tockload=n
+ libtock_target_path=/home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world
+ elf_file_name=/home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world/cortex-m4.elf
+ tab_file_name=/home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world.tab
+ mkdir -p /home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world
+ cp target/thumbv7em-none-eabi/release/examples/hello_world /home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world/cortex-m4.elf
+ elf2tab -n hello_world -o /home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world.tab /home/lonelyjoe/workspace/libtock-rs/target/thumbv7em-none-eabi/tab/nucleo_f429zi/hello_world/cortex-m4.elf --stack 2048 --app-heap 1024 --kernel-heap 1024 --protected-region-size=64
+ '[' n == n ']'
+ echo 'Skipping flashing for platform "nucleo_f429zi"'
Skipping flashing for platform "nucleo_f429zi"
+ exit 0

Tockloader doesn't support flashing this platform. You will need to flash it manually, check the Tock Makefile for how to do this.

Thank you!


Can't return wanting type of data

Hello, I want to build a function that can return the most common permutation of six "R" letters plus six "B" letters, the list may looks like this:

I want to write a loop of this function to simulate the most common distribution of these strings. I did write a for loop with python and it did work, but after I import cython to accelerate this function, something goes wrong, here is the error:

What kind of data should I return to accelerate my simulation, please?

This is more a user support issue that should be asked in the mailing list.


feat: Sign up request with the country and the language of the user

Hi everyone!
Currently, all users are registered with the "world" website, and they receive the newsletter in English.
Before implementing a way to change the language dynamically, we now ensure to send the user's language and country to fit 95% of cases.

Codecov Report

Merging #4329 (4b5adc8) into develop (5a72a46) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4329      +/-   ##
===========================================
- Coverage    10.54%   10.54%   -0.01%
===========================================
  Files          290      290
  Lines        14293    14295       +2
===========================================
  Hits          1507     1507
- Misses       12786    12788       +2

Impacted Files
Coverage Δ

...th_app/lib/pages/user_management/sign_up_page.dart
49.78% <0.00%> (-0.44%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Bug]server responded 500 for the crud-page API in automation runs

Steps:
1.Create a DS need for your use case.[postgres in this case]
2.Then while creating a new page, when we tap on Generate New Page we are getting internal server issue.
PFA

Also logs :
Failed to load resource: the server responded with a status of 500 (Internal Server Error)
URL: https://dev.appsmith.com/api/v1/pages/crud-page/61090b949f8bc421c86fadc9

@Rishabh-Rathod I have pushed a fix for this. If everything is working fine on release we can close this issue.

Closing this as TC is passing on release


Add info about /jira webhook to admin jira config for contractual help

The admin Jira config UI has a section providing an example of a jra webhook.

It would be helpful in inform the user that they can use /jira webhook to see the current hook.
This info may also be valuable to add in the instructions ephemeral post when /jira install has been used.

3 parts to this request:

change the text in https://github.com/mattermost/mattermost-plugin-jira/blob/d776dd30b9ad8beae03d9f74535c5d989c9e710b/plugin.json#L91 to recommend the use of /jira webhook to see the fully expanded URL;
change the output of /jira install to include the webhook URL
(bonus) change the output of jira uninstall to include the reminder to remove the Jira-side webhook, and a link to do so.


Eliminated TargetCoverage in favor of ReadCountCollection.  Closes #397.

@LeeTL1220 As written this replaces the "name contig start stop" format with "NAME CONTIG START END" internally and in all output.  I forgot what the spec for this issue was and can easily change this.  Is it supposed to:

do this
switch to the lowercase CGA format everywhere
do this but have some command line tools for format conversion
none of the above
?

@LeeTL1220 All output files are now in the lowercase header format (i.e. unchanged).  No changes to pipeline scripts will be necessary.  Can I assign you to review?

I have lots of comments.  Some things I did not understand, so I may just need an explanation.
I really do not think that you can mess with the column headers (even to change the lower case upper case) and still have the tools work in the workflow.  That may have changed at some point, but the real test is whether we can run a workflow.  If you already ran the workflow and everything was fine, then you can disregard those comments.

@LeeTL1220 So the main messages I get are 1) run the workflow!!!! and 2) try to give ReadCountCollection some of the capabilities of TargetCollection, and 3) check that downstream CLIs properly check for multiple samples.  I think 2) is worthwhile but not in this PR.  The rest I either changed or explained.  If you don't buy any explanation I will revisit.  Now I must run the workflow and hope nothing blows up.

@davidbenjamin It is going to blow up.

@LeeTL1220 You were right, of course.  It blew up, but it seems like into not so many pieces.  What I overlooked was that CalculateTargetCoverage in gatk-public uses uppercase column headers.  I am testing the following pragmatic solution: copy it into gatk-protected under the name CalculateTargetCoverageCopy and change to lowercase.  I have modified the pipeline to invoke the copy but otherwise left it unchanged.  If this works I would then submit a PR to gatk-public to change CalcualteTargetCoverage and then delete the copy in gatk-protected.
I will know by the morning if this works.

@LeeTL1220 It works!  Everything is in /dsde/working/davidben/formats.  Every output file is as it should be.  The orientation is as follows:

Full run of both PoN creation and ACNV.
10 LUAD tumor bams w/ 10 paired normals -- LUAD_tumors.txt and LUAD_normals.txt, respectively.
49 agilent bams -- agilent_pon_bams.list -- for the PoN.
Create PoN pipeline results in pon/ directory.
Case sample pipeline results in cases/ directory.
running db_format branch of gatk-protected.
running db_format branch of recapseg-hb-eval, which is identical to master but using the copy of CalculateTargetCoverage.
invoking ./test.sh produces all output.

I believe it's back to you now.  Let me know if any of my answers to your comments were in fact nothing more than evasions.

@davidbenjamin You have failing unit tests and coverage decreased by a lot....  please address

@LeeTL1220 Okay, for some reason I don't undersand commenting out the override annotation for onTraversalEnd() in the copied class fixed the problem.  BTW, it compiled fine without this hack locally and on gsa5.  As for the coverage, as discussed offline I believe the drop in coverage is solely due to refactoring some highly-covered classes out of existence.  This PR does not add new functionality and I can't think of anything that is no longer covered by tests.  Therefore, I think it's back to you for real.

@LeeTL1220 Did everything we discussed in this repo, need to merge accompanying PR in gatk-public and re-run the pipeline.

@droazen the build is failing due to UnsatisfiedLinkErrors in PairHMM.  Do you know anything about this?

@davidbenjamin The problem is we got overly excited about a multi-threaded version of the PairHMM, and turned it on before we had a graceful fallback in place in the case where the correct version of the required libraries are not available. We are going to revert this in public until such a fallback has been implemented, and publish a new snapshot.

@droazen Thanks for the explanation.  I would have gotten overly excited too.

@davidbenjamin I've released a new snapshot that reverts the PairHMM changes -- you should rebase this branch onto master once https://github.com/broadinstitute/gatk-protected/pull/509 is merged.

Strike that -- since tests won't pass using the latest gatk-public without the changes here, you should take the one-line change in https://github.com/broadinstitute/gatk-protected/pull/509 and incorporate it directly into this branch.

@LeeTL1220 I did everything we discussed, revved gatk-public, and reran the pipeline on the server as above.  Everything is fine.  Ready for your final review.

Would be good to get this in soon, as it's blocking several other branches that require the new gatk-public snapshot.

@davidbenjamin Only one small change that came from @samuelklee

Right, I think renaming ReadCountRecord.SingletonRecord and getting rid of the TRIVIAL_TARGETS if possible are the only issues left.
At some point I think it would be good to make sure we treat coverages and allelic counts identically and consistently.  For example, we use List, TargetCollection<ReadCountRecord.SingletonRecord>, ReadCountCollection, etc. and List, TargetCollection, AllelicCountCollection, etc.  If we do eventually give ReadCountCollection some of the capabilities of TargetCollection, as mentioned above, we should probably do the same for AllelicCountCollection (or have them both inherit them).

Actually, I think I might still have some reservations about the vector vs. matrix issue too...something to keep in mind for future refactorings.


Public developer guide

Creating a client-side dev guide

@richrines1 I think all your comments are implemented now!


Streaming connections (ie file downloads) using HTTP/2 client and HTTP/1.1 backend are not properly aborted.

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
We have a chain of services constructing large files for users to download. Sometime somewhere along the chain a timeout might occur half-way during such a stream, and the download within end-users' browser should be aborted.
It seems that when using a HTTP/2 connection to Traefik, from both Chromium and Firefox, with a HTTP/1.1 backend (in this case NodeJS/express) Traefik correctly detects that the connection has been aborted and calls its Recovery middleware. This however does not seem to properly signal the client (over HTTP/2) that the download is to be aborted, and subsequently the users' browser assumes the file is finished.
I had hopes that passing a Content-Length instead of Transfer-Encoding would solve the problem on the browsers' end; unfortunately it seems at least Chromium and Firefox do not consider a download failed if the received length is lower at this point.
If I use a client with only HTTP/1.1 support, then the file is marked as failed as expected.
I think this behaviour is not something Traefik can directly influence easily; at least as so far I have looked into the Recovery middleware it seems that it uses net/http Go library which seems to be quite high-level compared to net/http2.
I am curious if anybody has faced the the same problem and managed to come up with a workaround. I have already disabled all middlewares and used a bare-bones configuration.
Also happy to provide a reproduction case if necessary.
What did you see instead?
Streams over HTTP/2 with a HTTP/1.1 backend are not properly aborted in case an upstream abort is detected.
What version of Traefik are you using?
3.0.3
What is your environment & configuration?
<not relevant>

Traefik 3.0.3 on Kubernetes using k3d; but should be pretty irrelevant.
If applicable, please paste the log output in DEBUG level
No response

Hello @koenfaro90,
Thanks for reporting this!

Also happy to provide a reproduction case if necessary.

Sure, please share it here, it would help anyone wanting to tackle this.


Braintree errors not displayed properly

https://gratipay.freshdesk.com/helpdesk/tickets/2130

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/14681443-customers-created-but-no-card?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Closed in #3418.


Near cache demo that uses JMS to data grid cache events to near caches

Near cache demo, see README file for more info.

Sanne, updated.


Linear to Logarithmic conversion

Hi,
Great looking project!
Can you tell me where in your code do you convert from linear to logarithmic scale? Or can you describe how to do this?
Thanks.

Hello
This is done in visualizer.cpp in visualizer_c::run function. There are actually two different types of bars that can be selected from the code. The default is 1 that is a fixed width bar whose code starts on line 61. Bar 2 is the variable width bar and its code starts on line 104.
If you are trying to understand how this works I suggest you to look at the bar 2 code first because there are some actual calls to the log function.


OLS-378: Use user ID retrieved from auth middleware

Description
Use user ID retrieved from auth middleware
Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #OLS-378

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

/lgtm

/approve


Gathering Ritual Chest Search Box Off by One

Similar to #379, which still isn't fixed in the latest release btw, the Gathering Ritual chest search box is off by one.
https://github.com/MysticMods/Roots/blob/4b8636b60b60c210e463410986fa19810fe3827e/src/main/java/epicsquid/roots/entity/ritual/EntityRitualGathering.java#L18
Should be:
 new AxisAlignedBB(-1, -1, -1, 2, 2, 2);

Damn it, why does AxisAlignedBB work like that? It's supposed to be 0-indexed.
And yes, it looks like I committed it to 3.1 but didn't cherry-pick it into the 3.0 branch -- sorry about that.

Its because blocks have a bounding box from 0,0,0 to 1,1,1.
So to expand it, you have to subtract and add an equal value to both points.

Ohhh. Of course, thanks for the explanation. I do generally struggle with relational positioning and have been persistently applying my array-based "0-index" logic to everything in the world, which doesn't necessarily work as in this case.


Support rerunning evaluation step

I have had the evaluation step canceled (because of low priority VM), and when I try to rerun it the python script crashes with
Traceback (most recent call last):
  File "evaluate/evaluate_model.py", line 100, in <module>
    run_id = run.parent.id
AttributeError: 'NoneType' object has no attribute 'id'

It seems that the run-parent information is maybe not properly propagated through reruns? IDK.

Where you able to work around this? We will try to reproduce this error on our end

If there's no update, I'll go ahead and close this issue. Let us know if you run into any more bugs


Download Raw

Allow to install a file from a repository without releases.
Usefull for scripts.

Thought about this in the past but if we don't have a "standard" way to check for updates, what's the reason to use bin at all?
I guess that raw could only work as long as the owner publishes updated files in the exact same URL. Do you have an example?


Provide a means to filter OTel Signals

This ticket is written in support of the ability to optionally disable data transmission on a specific device. The central configuration option of recording is not sufficient because it controls whether all devices are transmitting.
The exact methodology to provide this functionality has yet to be decided after several options are examined:

provide an API to set a processor for each signal.
This option would allow direct access to the Otel Processor interface, and would have the least amount of restrictions, but more possible to accidentally disrupt the processor -> Exporter chain. Additionally, the metric API doesn't use processors, but a similar construct does exist. This means a higher level of expertise is necessary to implement a solution.
Provide filter callbacks for each processor.
This could be an extension to the existing Elastic signal processors. It would be easier to interface with for the customer, but less powerful.
Is it possible to simply provide documentation using the existing open telemetry API?
other options?

implemented with #167


Optimize checking for signatures with control flow effects

Use NodeCheckFlags to record checks and eliminate effectsSignature property in NodeLinks.

@typescript-bot perf test this

Closing as there is no appreciable effect on performance.


Popup window Peer to Peer code Review

Please make the following changes in your Popup window

I would suggest you change the Layout to the details of the popup window. because your detail of the project is just moved to the bottom when you Popup the window.

** ♻  Changes required 🔴  **

Kindly can you improve your popup windows, Because there ara a blank space in the right position. You can note this at 950px of resolution. Thank you and your UI is awesome 🥇 💯

Thank you a lot


Updated outcome for leaseholders

Added more information to reassure leaseholders who may have to pay that there is help available.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

TRELLO:
ZENDESK:
Not sure how this didn't save as I thought I'd already raised it. More updates to outcomes for cladding smart answer created by Ed Kerry. Will discuss at storytime.


Event storming session on update customer master data

The purpose of this is to look into the update customer master data process and identify user stories.

Hey team! Please add your planning poker estimate with ZenHub @CBrohus @kft @Korgath @Mathiesen


[feature] Windows support

problem
windows can't handle the path regExp
command
$ npx doxdox './src/**/*.js' --layout markdown --output testDOCU.md
result
Invalid regular expression: /^(C:\xampp\htdocs\projects\viewar\viewar-docu/|./)/: Invalid escape

Same here it looks like it might be an issue with this --> https://github.com/nodejs/node/issues/8237

This should no longer be an issue as of doxdox v4.0.0-preview.2


Gradle 4.1+ executes tasks in the wrong order

I have a composite build, and I want some tasks to propagate to subbuilds: clean, test, build.
I also have a task that creates a binary distribution, which includes jars and other artifacts (scripts, etc).
Everything worked fine in Gradle 4.0, but now if I run clean distro, clean runs last.
Expected Behavior
clean runs first, then distro
Current Behavior
clean runs after distro
Steps to Reproduce (for bugs)
I managed to create a little project to reproduce the problem here gradle-4.1-task-order-bug.
CD to main and run:
./gradlew clean distro
You'll see the distro under build/distributions/main-distro
Than modify gradle/wrapper/gradle.properties to use a 4.1+ version.
Run it again.
The build directory will be removed.

You're running into the same problem as reported here: https://github.com/gradle/gradle/issues/2488

Seems very similar, yes.
I do have other side-effects in my original build, like additional artifacts not being built before the distro task, essentially ignoring the dependsOn (again, works in 4.0), but I thought it's all related.

If modeled task relationships (such as dependsOn or mustRunAfter) are not being honored, then that's likely a different (and more serious) problem.  Does your example project above exhibit this behavior in some way?

I have a similar problem.
I need to run my build with tasks in specified order: clean, assemble, crashlyticsUpload.
This configuration always results in build failure due to missing apk file.
In fact, crashlyticsUpload is always performed before assemble and after clean task.

My original build does indeed seem to mess up dependencies. If I call only distro it calls lib:clean right before it. However I was unable to reproduce it in my example.

Any updates on this?

@bartoszwilk does crahslyticsUpload have proper dependencies in place? If that task needs the APK, then it should depend on the task that creates it.

I have the same problem. I run command: gradlew clean  assembleRelease crashlyticsUploadDistributionRelease and see next order:

clean
crashlyticsUploadDistributionRelease
assembleRelease

Just tried it, adding --max-workers=1 doesn't do the trick here.

OK, thanks.
With Gradle 2.x and 3.x, were the tasks run in the order they were stated on the command line?

This particular example used to work until 4.0.2, and git bisect points to ea6c002

You probably don't want to declare dependencies in clean though.
Perhaps have a mustRunAfter, but it's pretty annoying to have to put that everywhere.

@idlsoft I wasn't talking about your issue, which is the reason this ticket exists. I was explaining to the others that they are not facing this issue, but a faulty plugin.

@oehme you're right, the two are unrelated.

This format used to work great for me on Gradle 3
task cleanAssembleBuildPublish(type: GradleBuild) {
    tasks = ['clean', 'assembleRelease', 'publish', 'anotherTask', 'lastTask']
}

Gradle 4+ ruined this simplicity. Seems crazy that ordering tasks isn't just a case of lining them up like above. I guess a quick work around is to just write a bash script that calls each gradle task in sequence.

@thevolcanomanishere Can you please provide a reproducible example project? This should work just fine, there is only a corner case with composite builds.

Closing this as a dupe of https://github.com/gradle/gradle/issues/2488


Windows test framework fixes

First round of fixes to the test framework to make tests basically run on Windows. With this, the remaining failing tests are:
In test/test-custom-transfers.sh:
test: custom-transfer-upload-download ...                          FAILED

In test/test-fetch-include.sh:
test: fetch: include first matching file ...                       FAILED
test: fetch: include second matching file ...                      FAILED

Running tests in AppVeyor will be enabled in a separate PR once these tests are fixed and https://github.com/appveyor/ci/issues/1022 is deployed.

Hey @sschuberth, thanks so much for this. As you can probably tell, most of us don't use Windows much, so this helps a lot. Apparently I don't use bash often either, not sure why I didn't export GIT_CONFIG_NOSYSTEM :trollface:
I can merge this once you take care of the small change I mentioned.
I'm traveling this week, so I can't look at the 3 remaining windows failures. I'll take a look when I get home to my windows machine.

@technoweenie Done. I was planning to look at the remaining Windows failures myself, but I still wanted to get these fixes in already, just in case others want to have a look at the failures, too.

I've pushed some more commits on top, which among others fix test: custom-transfer-upload-download. However, on my Windows 10 machine I'm now seeing more failing tests than before:
test: env with no remote ...                                       FAILED
test: env with origin remote ...                                   FAILED
test: env with multiple remotes ...                                FAILED
test: env with other remote ...                                    FAILED
test: env with multiple remotes and lfs.url config ...             FAILED
test: env with multiple remotes and lfs configs ...                FAILED
test: env with multiple remotes and lfs url and batch configs ...  FAILED
test: env with .lfsconfig ...                                      FAILED
test: env with .gitconfig ...                                      FAILED
test: env with environment variables ...                           FAILED
test: env with bare repo ...                                       FAILED
test: env with skip download errors ...                            FAILED
test: env with extra transfer methods ...                          FAILED
test: fetch: include first matching file ...                       FAILED
test: fetch: include second matching file ...                      FAILED
test: fsck default ...                                             FAILED
test: submodule env ...                                            FAILED
test: track ...                                                    FAILED
test: track representation ...                                     FAILED
test: git worktree ...                                             FAILED

I'll try to look into these one by one ...

Added more fixes, now failures on my Windows 10 machine are down to:
test: fetch: include first matching file ...                       FAILED
test: fetch: include second matching file ...                      FAILED
test: track ...                                                    FAILED
test: track representation ...                                     FAILED

@ttaylorr @technoweenie Even if this does not fix all tests on Windows yet, can we get the current state merged? I have more local commits in the works, but I'd prefer to get in what I have so far to clean things up a bit.

Sure, I don't see a problem with merging this in an incremental state since we're not predicating our merges on Windows tests in any way. I want to make sure this is cool with @technoweenie too, so I'll defer to his judgement on this one. 😄

@ttaylorr I guess @technoweenie's thumbs-up to your post means we are good to merge? If so, please have another look at the diff to double check, and hit the merge button if all is good! :-)


Gitea returns import path for organization

Gitea version (or commit ref): 1.9.2
Git version: 2.22.0
Operating system: Manjaro 18.0.4
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Description
To quote:

In module mode in Go 1.13, the go command checks all possible module paths in parallel for the requested package.

Gitea returns a non-valid Git fetch URL for e.g. https://try.gitea.io/test, as seen in the example below. This makes it impossible to use Go modules pulling dependencies from a private Gitea instance, because Go 1.13 expects no clone URL if it is not a valid repository path (see GitLab behavior). This issue is related to golang/go#34075. See that issue for more information.
$ curl https://try.gitea.io/test/?go-get=1
<!doctype html>
<html>
        <head>
                <meta name="go-import" content="try.gitea.io/test git https://try.gitea.io/test/.git">
                <meta name="go-source" content="try.gitea.io/test _ https://try.gitea.io/test/src/branch/master{/dir} https://try.gitea.io/test/src/branch/master{/dir}/{file}#L{line}">
        </head>
        <body>
                go get try.gitea.io/test
        </body>
</html>

But test is an organization and this information should not be added, as it makes it impossible to retrieve dependencies using go get in Go 1.13.

There is some code which could be used in https://github.com/profects/gitea/tree/fix-go1.13-invalid-import-path, and I will probably create a merge request sometime soon. It would be nice if this issue could be fixed in a 1.9 minor release.

@rutgerbrf Please.

Just a + here to increase the pressure! ;)

@rutgerbrf I can confirm that your patch works.


Bug on complete address

Used config:
queries = [
{
"keyword": "bar delphi",
"select": ["title", "main_category", "phone" , "complete_address" "categories"],
},
]
number_of_scrapers = 16
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-packages/bose/base_task.py", line 220, in run_task
result = self.run(driver, data)
File "/Users/xx/Documents/xx/Google Maps Scraper/google-maps-scraper-pro-master/src/scrape_google_maps_links_task.py", line 302, in run
new_results = clean(fetched_results, data)
File "/Users/xx/Documents/xx/Google Maps Scraper/google-maps-scraper-pro-master/src/scrape_google_maps_links_task.py", line 142, in clean
new_results = [sort_dict_by_keys(x, keys) for x in new_results]
File "/Users/xx/Documents/xx/Google Maps Scraper/google-maps-scraper-pro-master/src/scrape_google_maps_links_task.py", line 142, in
new_results = [sort_dict_by_keys(x, keys) for x in new_results]
File "/Users/xx/Documents/xx/Google Maps Scraper/google-maps-scraper-pro-master/src/scrape_google_maps_links_task.py", line 100, in sort_dict_by_keys
new_dict[key] = dictionary[key]
KeyError: 'complete_addresscategories'

Config is wrong, Should be
queries = [
    {
        "keyword": "bar delphi",
        "select": ["title", "main_category", "phone", "complete_address", "categories"],
    }
]


Publishing: Register publishes without copying them

Feature
For some types it is better to just register new version with OpenPype without copying it to final destination. For large caches, editorial stuff or even renders that are rendered directly there.
Solution
The easiest way to do it would be to  add new template to anatomy, called original location or source or whatever. The you would set it for specific families via Settings or in the new publisher whether to use this or not. Publish will process it only by registering, maybe checking if its root is known - to prevent cases of publishing stuff that's only on artists computer. We already have concept of originalBasename token in Tray Publisher. We need to add it to the collectors dealing with already existing files (like editorial collectors and render collector on Deadline) plus adding originalDirname to the instance so template like {originalDirname}/{originalBasename}.{ext} could be used. With this, nothing else would need to be changed, loader should pick it up as usual.
[cuID:33vde1j]

I think new schema is too late as during Create Variant from UI is created for subset creation. Which would be fine only for published items with Main in its name.
I think there should be new flag denoting that dragged item(s ?) is already in proper location with proper name. From this context could be parsed >> subset used >> publishable instance created. No need to select context from left column.
If toggle would be checked and dragged in file is in wrong location/wrong name/unable to parse/version already existing, instance will be created marked that is invalid. These instances would need to be dropped, file renamed, dragged again, recreated.
(Or maybe instance is not created, but dialog with list of broken items is provided).

(And I am talking about Tray Publisher and creators from Settings for now.)

Resolved by https://github.com/ynput/OpenPype/pull/4157


[TS migration] Migrate SettingsProfileContacts page to TypeScript

Details

Migrate SettingsProfileContacts page to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/25218
PROPOSAL:
Tests

Open Settings >> Profile >> Contact methods
Add a new contact method
Enter wrong validation code
Verify error appears
Enter correct validation code
Verify it is added
Remove a contact method
Verify it is removed

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Open Settings >> Profile >> Contact methods
Add a new contact method
Enter wrong validation code
Verify error appears
Enter correct validation code
Verify it is added
Remove a contact method
Verify it is removed

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/113963320/2a40cff3-e07b-4771-9500-f9ecb8c6b14a
https://github.com/Expensify/App/assets/113963320/9bd24754-37f0-4968-b5e0-43feb73ba68d
https://github.com/Expensify/App/assets/113963320/fe018db1-3815-4a1d-9a18-15899a438bc0
https://github.com/Expensify/App/assets/113963320/6e479525-7501-472a-af07-5e4d921a2b1d

MacOS: Desktop

https://github.com/Expensify/App/assets/113963320/2a40cff3-e07b-4771-9500-f9ecb8c6b14a
https://github.com/Expensify/App/assets/113963320/9bd24754-37f0-4968-b5e0-43feb73ba68d
https://github.com/Expensify/App/assets/113963320/fe018db1-3815-4a1d-9a18-15899a438bc0
https://github.com/Expensify/App/assets/113963320/6e479525-7501-472a-af07-5e4d921a2b1d

@kubabutkiewicz would you like to give this a final review?

Will do that today!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Implement Cypher Queries in Parser

PgPool-II import the parser from PostgreSQL, parser need to be updated for AGE supported queries.

Hello everyone!
I am looking forward to working on this project!

Hello, Moeed here. I'll be working on this task.

Hi, I am the new Operations Manager Jayden from Vancouver Team.

Hi, I am the new Operations Manager Steve from Vancouver Team.

Hello, I'm Zahid and I'll be working on this task.

Hi, I will soon be working on this project.

Hi Guys
Excited to work on this project.

Hi! I'm excited to work on this project!

Hi! I am Abdullah. Excited for this project !!

Hi! I am Waleed, excited to work on this project

@eyab  project was completed, issue can be closed.


Sbfactory2021

Pending review and testing.

Interesting work around for cheese ids. I'm pondering if maybe using existing json only endpoint on server for looking up cheese id is better, but this works.

I hate this and want to change how convertible submissions works - look up by name if we don't have an id. Create a new id starting at some high number (50K?) within convertible_intake if we have something with a new name.


Added CICO JMeter script for Orchid release

Thanks for checking in many scripts here.

Please delete "_release" from the name. Calling it "Nolana" or "Fameflower" is good enough. We all know what it means.
I believe we agreed to delete loans/jmeter-supported-data folder and its credentials file.
What happens to the existing CICO JMeter script? Is it being renamed and moved into one of these dir's?  We want to preserve it as it has a lot of history.

Done
Yes, we agreed to delete loans/jmeter-supported-data
I replaced existing CICO JMeter script to \check-in-check-out\Honeysuckle folder according to the release name.


Cannot trade

Would not allow me to trade, even with 5 wheat. Other trade configurations were also tried, and none succeeded.

Was an intersection selected when you tired to trade?


edit test to allow for flexible attribute placement and accompanying …

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #53394
Some pictures to demonstrate that the tests now function as desired:

Hey @jayAardvark,
there's no need to keep updating PR branch with new changes from main. Unless there are merge conflicts, PR will be merged without any issues. All that it does at this point is basically starting once again CI checks.


fix: allow directions mode without source in apple map

According to the Apple Map Links Doc, the saddr param is not required.
So we should handle directionsMode the same way as the Google Maps. Otherwise we could not enter directions mode in Apple maps with user's current location as the starting point.

Hi @meteorlxy, thanks for your contribution, this looks good!
Could we add a unit test for this behaviour? I want to make sure we don't inadvertently break this in the future when we change how the URL is built.

@tschoffelen unit tests added


"hot patching" is used where "hot reload" should be used

s/"hot patching"/"hot reload"

Where's the text showing up?

preferences page

I believe that's an old preference entry.


Can AirspeedVelocity be uninstalled?

The installation instructions mention that running
julia -e 'using Pkg; Pkg.add("AirspeedVelocity"); Pkg.build("AirspeedVelocity")'

builds two executables. Can AirspeedVelocity be uninstalled afterwards or do you expect it to stay in the global (@v1.X) environment?

I guess you could just do julia -e 'using Pkg; Pkg.rm("AirspeedVelocity")'? Though it doesn't remove the script in ~/.julia/bin. I guess that might be an issue to post on https://github.com/comonicon/Comonicon.jl or on Julia itself?

Sure, I was just wondering why the installation instructions don't suggest running
julia -e 'using Pkg; Pkg.add("AirspeedVelocity"); Pkg.build("AirspeedVelocity"); Pkg.rm("AirspeedVelocity")'

and I therefore assumed the package must stay in the global environment.
I see how this issue wasn't clearly phrased, my question was not about uninstalling ASV from ~/.julia/bin.


Add support for @With tag

Short description
@With annotation shows compile error.
Expected behavior
@With annotation should compile. The plugin seems to only support deprecated @Wither
Intellij 2019.2.3

Duplicate of #673. New plugin version will be probably released this week.


release preparation

It would be nice to include a K 3-to-4 migration guide in this.

@radumereuta, could you add a bit of information about the parser here? I can do it otherwise.

@cos, done, have a look.

@radumereuta, looks good. only made a small change.

You are right, it sounds better.

return-object.kool is flaky... it consistently works on my computer but fails intermittently on codeship. As this PR does not touch code, disregard that error for now.

Looks good.  Merging.


License conflict

Which packages are impacted by your issue?
@graphprotocol/graph-cli
Describe the issue
I'm no license expert, but it appears that web3-eth-abi dependency licensed under LGPL-3, might be incompatible with MIT license. Just a heads-up.
Reproduction
N/A
Steps to Reproduce the Bug or Issue
N/A
Expected behavior
N/A
Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
NodeJS: [e.g. 18.5.0]
@graphprotocol/* version(s): [e.g. 2.6.2]

Subgraph Manifest
No response
Subgraph GraphQL Schema
No response
Additional context
No response

I am also not a license expert, but I can't find any sources which suggest that an MIT project can't have an LGPL-3 dependency (assuming no modifications). Did you find something to the contrary @YaroShkvorets ?

I got this warning from fossa.com tool: https://fossa.com
But looks like you are right, shouldn't be an issue.

got it - thanks for taking a look!


[5.4] Testing Mailable - no way to access body of email

Laravel Version: 5.4
PHP Version: 7.1
Database Driver & Version: Mysql 5.7

Description:
I'm using Mail::fake() and Mail::assertSent() to test emails sent by the application. It's important that I be able to test the body of the email (i.e. search for a specific string). There are calls for things like hasTo() and hasCc(), and there is a public property for $subject, but there is no way to access the message body.
I concede I may be doing this the wrong way, in which case I would welcome advice on how to do it correctly. If this is just missing functionality, then I can try to put together a pull request if this is a feature you'd like to have
Steps To Reproduce:
Mail::fake()
// Do stuff that sends email
Mail::assertSent(TheMailableThing::class, function($mail) {
    // Nothing like $mail->hasBodyContents($string) exists
});

can you please open an issue in https://github.com/laravel/internals repo? It's the place we keep suggestions and requests.


Adding ACI endpoint regularly gives an error

Bug description
Adding ACI endpoint regularly gives an error. But retrying “Add endpoint” works.
Expected behavior
ACI endpoint should successfully be added.
Portainer Logs
http error: Unable to authenticate against Azure (err=Post https://login.microsoftonline.com/34d4c73d-4fff-4352-9ce2-df14c8d839f5/oauth2/token:
net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)) (code=500)

Steps to reproduce the issue:

Add a new Endpoint
Use Azure and fill in the details
”Add endpoint” results in an error

Technical details:

Portainer version: 2.1.1
Platform (windows/linux): Linux
Command used to start Portainer (docker run --name portainer -d -p 8000:8000 -p 9000:9000 --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ce):
Browser: Firefox 85.0.2

It seems that this issue could be related to user environment (timeout).
We could try to increase the timeout value or add a retry policy.


ACM-8680 Update node labels

https://issues.redhat.com/browse/ACM-8680

/cherry-pick release-2.9

/cherry-pick release-2.8


Pretty-print mode to replace glob imports with a precise list of names

 Issue by bstrie
Monday Feb 04, 2013 at 19:05 GMT
For earlier discussion, see https://github.com/rust-lang/rust/issues/4786
This issue was labelled with: A-pretty, A-resolve, I-wishlist in the Rust repository

13:58 < bstrie> is there a pretty-print mode to replace a glob import with a
                precise list of names?
13:59 <@pcwalton> bstrie: no unfortunately
13:59 <@pcwalton> good idea though

So if I have a file with this:
use foo::*;

...and of all the things that foo provides, I only ever end up using bar and baz, then it should rewrite the import to:
use foo::{bar, baz};

I have a tool for this: https://github.com/nick29581/deglobber WIP

With deglob refactoring in RLS, can this be closed?

Per Scott's comment in https://github.com/rust-lang/rfcs/issues/617#issuecomment-325185375 I'm closing this.


Use the released version of manageiq-loggers

Version 0.3.0 is currently master so this shouldn't change anything.

cc @simaishi

Ivanchuk backport details:
$ git log -1
commit 2b4aa51b373a7796badc2e2757fa0bc398206985
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Tue Jul 23 16:56:44 2019 -0400

    Merge pull request #19039 from carbonin/use_released_manageiq_loggers

    Use the released version of manageiq-loggers

    (cherry picked from commit 51d358027341d022a334057b16a8918f8e3df9cd)


Can't get scavenger working

I can't get scavenger working for some reason. I followed all steps, and have the requirements installed.
This is the log:
Beginning quick scavenge
Beginning run
Locating Discord token
Token located at 'C:\Users\idieg\AppData\Roaming\discord\Local Storage\https_discordapp.com_0.localstorage'
Extracting token

Unhandled Exception: System.IO.IOException: The file 'C:\Users\idieg\AppData\Roaming\discord\Local Storage\https_discordapp.com_0.localstorage.tmp' already exists.
   at System.IO.Win32FileSystem.CopyFile(String sourceFullPath, String destFullPath, Boolean overwrite)
   at System.IO.File.InternalCopy(String sourceFileName, String destFileName, Boolean overwrite)
   at System.IO.FileInfo.CopyTo(String destFileName)
   at EmoteScavenger.Program.ExtractToken(FileInfo dbf) in C:\Users\Mateusz\Documents\Visual Studio 2017\Projects\EmoteScavenger\EmoteScavenger\Program.cs:line 63
   at EmoteScavenger.Program.Main(String[] args) in C:\Users\Mateusz\Documents\Visual Studio 2017\Projects\EmoteScavenger\EmoteScavenger\Program.cs:line 30

You ran it twice. Delete the file it points to and try again.


google-cloud-cli -> google-cloud-sdk in rhel sap byos images

rhel sap byos uses a different gcloud package than the rest of enterprise linux, which throws a wrench in our package testing. If there's a preference for one or the other we can switch to either but we should make it consistent to make our testing easier.
/assign @zmarano

/hold

This actually should be the other way around. We should accept both cases- but be moving to google-cloud-cli as the package name.