Send platform info when making api requests

Context
Master tracking issue here. This PR is one of three PRs necessary to send a hash along with a validation SMS message to Android device for auto-fill of magic code upon user sign in.
Deployment schedule
App, Auth (this PR) -> Web-E
This PR can be deployed independent of other PRs.
Details
We only need to add a hash when the user is trying to sign in from an android device. To determine what device the user is using on the server side, we need to pass platform information along with the request.
Fixed Issues

$ GH_LINK  https://github.com/Expensify/App/issues/15342
Tests

Internal QA

In Web-Expensify, update api.php and add the following line somewhere in the beginning of the file (maybe line 35):Log::info("Platform: ".($_REQUEST['platform'] ?? 'Idk dude'));

The WAF rule is already set for platform parameter in the current Web-E code. So you can test with the main code.
2. Open a chat in NewDot
3. Open your terminal and start tailing logs with ../script/tail.sh "Platform:"
4. Sign into a NewDot (we want to send the BeginSignIn command as this is the command on which the new parameter is added). If you're already sign in, log out to sign in from the beginning.
5. Make sure you see a log for the Platform and it matches the platform you tested

Offline tests
N/A

QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
N/A

I marked this PR and other related PRs ready for review. But I cannot still confirm automatic sms validation behavior on the emulator (the magic code is not automatically extracted and passed to the input field).
Please share ideas how we can test on a real device or or what might be the reason for the behavior not being observed on the Web-E PR.

@paulogasparsv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@paulogasparsv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Please hold reviews now. I'll implement the change suggested here.

ready for review now

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Hey @hayata-suenaga I think we need to update the test steps right?
Maybe we can do the following for testing:

In Web-Expensify, update api.php and add the following line somewhere in the beginning of the file (maybe line 35):Log::info("Platform: ".($_REQUEST['platform'] ?? 'Idk dude'));

Open a chat in NewDot
Open your terminal and start tailing logs with ../script/tail.sh "Platform:"
Send a message in the chat
Make sure you see a log for the Platform and it matches the platform you tested

I'll do that here but if those don't match the final test steps I'll re-test here : )

@PauloGasparSv thank you for suggesting test steps 🙇🏻♂. These steps look good to me. I just added a few details on sending BeginSignIn command specifically and posted the steps on the initial comment. You don't have to redo the test.
Also I updated some old comments in the initial comment.

Hey @hayata-suenaga I forgot to mention: I think we may also have to change the Internal QA Steps as people won't be able to add that Log in prod and staging!

@PauloGasparSv I added the step 6. thank you for pointing that out

If internal QA tests are needed, can people pull staging and production branches?

I don't think so @hayata-suenaga!
I think both QA stages (staging and prod) are done without having the source code or running anything locally but instead it's all done either direcly in https://staging.new.expensify.com/ or https://new.expensify.com/ or the Staging/Prod builds for Desktop, Android and iOS!
BTW, here is an example of how QA is done in staging: https://github.com/Expensify/Expensify/issues/268894
And another in for prod: https://github.com/Expensify/Expensify/issues/268122
IMO sometimes it's a bit hard to come up with valid QA steps because we can't do certain things in staging or prod that we can locally (a good example is creating and validating a VBA, that's pretty easy in dev but requires some extra steps in staging/prod)

@PauloGasparSv thank you for the info on internal QA. I checked this SO. So internal QA checklists are automatically created when the PR with the label internalQA is merged to staging?

I made a staging section in QA testing steps in the original comment.

@PauloGasparSv I just realized the production NewDot might be already sending platform info. I'll double check on this. Please don't merge this PR. I'll mark this PR as draft.


Posting Command

Hi, I am new here,
and I am having trouble posting the ad. I was able to generate the yml file, but now if I run the command python kijiji_repost_headless post item.yml on the python shell, it tell me kijiji_repost_headless invalid syntax.
I am guaranteed that I am doing this wrong, so if anyone can guide me the right way.
Thank You

The commande line is:
python kijiji_repost_headless -u your-username -p your-password post item.yml

Don't run this in a python shell, run it in a regular (eg. bash) shell.

but my file exists... i even tried going to the directory and using the command but does not work.
Thank You in advance.

The shell is saying that the folder kijiji_repost_headless doesn't exist. Are you certain that folder is within the current directory C:\Users?

@ArthurG you can probably close this one. He hasn't responded back in about a month now. I believe it is just user error.


fix(ci) correct latest push

What this PR does / why we need it:
Fixes the latest push job.
Which issue this PR fixes:
The job was failing:
Run git checkout latest
  git checkout latest
  git reset --hard v2.11.0
  git push latest
  shell: /usr/bin/bash -e {0}
Switched to a new branch 'latest'
branch 'latest' set up to track 'origin/latest'.
HEAD is now at 46f0739c chore(deploy) bump manifest versions
fatal: 'latest' does not appear to be a git repository
fatal: Could not read from remote repository.

Changes are what I ran locally to handle it outside CI.
Special notes for your reviewer:
Git indicated that my latest, after resetting to v2.11.0, was missing commits from origin/latest. I'm not sure if this should be the case (the succession of latests should be entirely linear unless we accidentally pushed a backport to it), but I can't think of any reason we'd not want it to be an exact replica of the tag, so I don't think there's any reason not to force push.
PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[ ] ~the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR~

the succession of latests should be entirely linear unless we accidentally pushed a backport to it

Well we're just re-pointing the branch pointer each time so it's not really linear right? It's just: set it to this tag and push.


Ghost cannot find templates in Windows

Issue Summary
Reposting, because issue has not been tested.  It obviously occurs in Windows but not in Linux.
A summary of the issue and the browser/OS environment in which it occurs.
According to the documentation, Ghost will pick up a template of the form page-[whatever].hbs and use this instead of the default page for slug [whatever]. It does this for one of several such templates, but not for the others. In other words, one slug gets its template from page-whatever.hbs, whereas the others get it from page.hbs.
To Reproduce
Create several identical templates, e.g., page-1.hbs, page-2.hbs, etc.
Create slugs in the Ghost navigation with names 1, 2, etc.
Create posts converted into pages through the Ghost editor, pointing at slugs 1,2,3.
Any other info e.g. Why do you consider this to be a bug?
Given that the documentation is opaque on this matter, it could be a 'feature' instead of a bug. However, it would obviously be hugely helpful if it worked.
Ghost Version: 2.6.0
Node Version: 8.11.3
Browser/OS: Chrome 70.0.3538.102 (Official Build) (64-bit)
Database: default (presumably MySQL).

@pkail if this is in reference to an earlier issue that you raised, please update that issue with the missing info rather than opening a new one, the very reason that we close bugs that aren't reproducible is to reduce clutter and noise so that our devs can see what needs their attention.


HTML5 video display frequently freezes after recent updates

I'm using Firefox from 48f49a730ed8a4759f6780899053e702f1f3945b to play Youtube videos. With that version, the video output freezes every couple of seconds until I move my mouse around a bit -- then video resumes. Audio continues all the while; it's just the video display that doesn't update anymore. This happens in both full-screen and embedded mode. Versions of Firefox prior to @wkennington's gstreamer-1 switch didn't have that issue.

This should be fixed by reverting those changes.
5711761622ceccc1fb2c97c965150fa8495546fc
54dee45402634e06491042edc01c377d08bb589d

I'm not sure whether the gstreamer update really is the culprit for this issue: I've re-built Firefox after those reverts, and the video problems still exist.
I see that meanwhile Firefox was also updated; I'll try the latest version ASAP.

Issue still exists in ac8f239, which has Firefox 40.0.2, but it's occurring much more rarely than before. Not sure what this means. I reckon, the reason for these freezes is Firefox's new HTML5 video player; I don't think gstreamer-1 had anything to do with it.

Well, it should be easy enough to unrevert those commits. However I had
reproducible issues with gstreamer-1 and Firefox that went away when I
removed it. Maybe this is a two part issue.
On Thu, Aug 20, 2015, 03:41 Peter Simons<EMAIL_ADDRESS>wrote:

Issue still exists in ac8f239
https://github.com/NixOS/nixpkgs/commit/ac8f2391f322e5c058dd08b8911d18c1e19fbcd9,
which has Firefox 40.0.2, but it's occurring much more rarely than before.
Not sure what this means. I reckon, the reason for these freezes is
Firefox's new HTML5 video player; I don't think gstreamer-1 had anything to
do with it.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9304#issuecomment-132969394.

This might be an old bug resurfacing: https://bugzilla.mozilla.org/show_bug.cgi?id=1100000
I haven't seen any signs that it was conclusively resolved.

I have seen manifestations of 1100000 in the range of FFearly3x-FF41, with the following caveats:

outside of NixOS
wonky hardware with unstable hardware timers

This issue is no longer present in recent versions of Firefox as distributed on master. If someone else still has it, please re-open.


fix: Prevent bouncing pending message

SBISSUE-15149
Fix

Remove highlighted message system
Set animated message id with null instead of 0

ChangeLog

Prevent bouncing pending message

Could you check if there are any side effects in the Channel module?


Animation not working when Progress.Circle is in use in ListHeaderComponent in FlatListView

animation is not working when the progress updates I think it have something regarding pure components- investigating

Any luck finding a solution for this one?


Fix static initialization of godot binding classes

static var test : godot.variant.StringName = "crash"; will crash since Haxe's static initialization happens before Godot-Classes are registered. We need to some macro handler to deal with these static fields and do the initialization upon successful class registration

For the moment we added a compiler warning, but we want a proper handler for this

Should be fixed in https://github.com/HxGodot/hxgodot/commit/9ea230ad65dcc5d347e332f108af10da16163718
We run a custom routine now.
package example;
import godot.variant.StringName;
import godot.variant.NodePath;

class HxOther extends godot.Node {

    // the following will use new static initialization routine
    static var someStringName:StringName = "test2";
    static var someNodePath = new NodePath();

    override function _ready() {
        trace(someStringName);
    }
}

Review in case of ScriptLanguageExtension


This loss of value is correct it？

I run the file of rnn_train.py,get the loss value of the model。
This loss of value is correct it？

Thank you ！

I think it's correct value. cause loss is keep decreasing
Thanks!


Feature/hapticfeedback

I added a haptic feedback functionality for FreePIE, please confirm that there are no problems with the implementation.
Thank you for your great app!

Looks good to me.
I'm sorry for leave it for a long time.

I have locally rebased and pushed.
But Github is saying to resolve conflict. I don't know how to fix it. Sorry.


Unable to reconnect to mqtt server.

Expected Behavior
Application should able to reconnect to the mqtt  after restarting mqtt server
Actual Behaviour
Application unable to reconnect to the mqtt  after restarting mqtt server
Steps To Reproduce

Run the micronaut application
restart the mqtt server
Application is unable to reconnect to mqtt

configuration
mqtt:
client:
enabled: true
client-id: abcd
server-uri: uri
user-name: username
password:
manual-acks: true
automatic-reconnect: true
max-reconnect-delay: 120
Environment Information
Jdk image:    openjdk:17
micronaut mqtt version 3.0.0
Example Application
No response
Version
4.3.8

Solved  using following configuration params
automatic-reconnect: true
clean-session: false


Feature: Coverage support on templates

Support of coverage on jinja2 would be useful for testing  projects that heavily rely on templates. As the docs state, templates might  contain some logic, and coverage support would provide the tools to make sure that the logic is correctly tested.
There is https://github.com/MrSenko/coverage-jinja-plugin, but unfortunately it does not work well.
This has also been  (sometimes indirectly) discussed in  #674  #673 #581 #408 . @atodorov had different ideas on #674 .
I am not familiar with the internals of jinja2 enough to know if this is possible or not. So,  I am asking, could this be feasible?

Yes, it's feasible. Some combination of the issues you linked would be needed. Closing this as a duplicate of those.

So, without understanding much, I see two approaches: Using get_corresponding_lineno, which from #673 seems to be a no go, but who knows the state now. The other is  using the debug approach mentioned in #674 . Which one makes more sense?


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89768

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93921

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/97488

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/109333

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116569

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116578


HBASE-23631 : Backport HBASE-23350 (Make compaction files cacheonWrit…

…e configurable based on threshold)  to branch-1

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 43s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 48s
branch-1 passed

+1 :green_heart:
shadedjars
2m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 51s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 49s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 54s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 50s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
127m 22s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

174m 19s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1256/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1256

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 27431eb4665b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1256/out/precommit/personality/provided.sh

git revision
branch-1 / 1931714

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1256/1/testReport/

Max. process+thread count
4215 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1256/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Fix /etc/resolv.conf permission issue

The container's /etc/resolv.conf permission was getting setup
as 0600 while it should be 0644 for every user inside the
container to be able to read it. The tempfile that we create
initially to populate the resolvconf content is getting created
with 0600 mode. Changed it to 0644 once it is created since there
is noway to pass mode option to ioutil.Tempfile
Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM

LGTM


fix: Traefik dynamic config middleware assignment

How to use/test:

create a ddev project with ddev config
copy/rename /project/traefik/.traefik-dynamic-config-extensions-template.yaml.example to remove .example extension
Likewise for ~/.ddev/traefik/static_config.plugins.yaml`
ddev start
Check that routers and middleware are loading and working properly at http://localhost:10999/dashboard/#/
Do the same for a 2nd project and check to see that separate middleware has been created per router
Feel free to try defining other middlewares in both of those files, or changing the router assignments. Make sure to follow the same formatting, particularly with the {{ .App.Name }}- prefixes

TODO

[ ] Move the verbose comments in the template files to documentation, and generally write/improve the documentation
[ ] I don't believe that existing projects will receive the /project/traefik/.traefik-dynamic-config-extensions-template.yaml.example file, as it is created with ddev config so that the file would be available prior to the first ddev start. Should that stay there, but also add some conditional logic to traefik.go to check for its existence, creating it if it doesn't exist?

Looks like the next hurdle is just TestCmdRestartJSON, https://buildkite.com/ddev/ddev-macos-arm64-mutagen/builds/8124#01907be5-07b3-4384-a0e9-aa1b1b01f567/15650-15654

failed to unmarshal logLine='Failed to read Extension YAML file. Probably doesn't exist: open /Users/testbot/tmp/ddevtest/TestCmdWordpress192791668/.ddev/traefik/.traefik-dynamic-config-extensions-template.yaml: no such file or directory'

Looks like a secondary failure, first the .traefik-dynamic-config-extensions-template.yaml doesn't exist, second the output of that causes the TestCmdRestartJSON to fail.
You can run tests manually really easily in vscode, just click the little arrowhead. Since this is a TestCmd test, make sure you have the correct built version of ddev in path.

I don't understand why you didn't fill in the PR template here. Please update it to explain. (But thanks for the manual testing instructions!)
Please edit the OP with the required information:
## The Issue
Explain there why this PR is necessary,
`## How this PR solves the problem.
## Automated Testing Overview

Please improve the testing instructions above. I took a look at the example file and it has all kinds of go templating in it.
{{ $webEnv := .App.WebEnvironment }}
middlewareAssignments:
  {{ .App.Name }}-web-80-http:
      - {{ .App.Name }}-redirectHttps
      - {{ .App.Name }}-my-fail2ban
  {{ .App.Name }}-web-80-https:
      - {{ .App.Name }}-my-fail2ban

Do we expect users to be able to do that? Or was the example file supposed to have been processed?

Your comments say

Finally, you can debug it by going to http://localhost:10999/dashboard/ and seeing if there were any errors for Routers or Middleware. You can click on any that are red to see the error message

Shouldn't ddev start have failed long before you can see router or middleware failures here?

You don't have to create a new PR. Just edit the OP. Pull down the little editor in the upper right of the OP :)

Congrats on tests passing!

I gave specific instructions at the places they belong. If you want to talk we can look at them together. It's always possible I don't understand something, but I explained that you need to create the config file after all the processing is done, not before.

I hope to get a look today. Github's ideas of "Changes requested" is pretty mechanical and not very useful. It has no idea what's been addressed. The reality is that "a lot of water under the bridge and it has to be looked at again" :)

The definitions will merge just fine, but the assignments from the 2nd one will override the 1st

Isn't that the intended behavior?

I think what you're describing is the intended override behavior. In config.yaml we have two modes. The first (default) is merging, so config.yaml and config.*.yaml are all merged. Direct hits are overridden, but things like arrays (your case) are merged. For the explicit override case we have a special override_config directive, https://ddev.readthedocs.io/en/stable/users/configuration/config/#override_config, which makes it work as an explicit replacement instead of merge.

I have decided not to accept this PR, mostly because of the explicit threat. I wish you well on your journey, and am sorry that this was such a difficult process.


Poor calander pop-up

Expected behavior: Allow the user/operator may/can choose year and month separately.
Actual behavior: User/operator needs to click unwanted arrow buttons repeatedly, entering date of birth :-(
Steps to reproduce: Try adding a new patient and enter her/his date of birth
Screenshots (if applicable): Not required
OS and Browser: Most of the java-script enabled browsers have nothing to do with it.

@bdheeman The popup calendar was supposed to allow you to click on the month and/or the year to change them.  At some point this broke.  I have a fix forthcoming that will allow the month and year to be changed via clicking on them.


queries are not being added to database

The "things" being searched are not added to the database..........

the condition inside this if is wrong.

in the above screen shot the databases are not actually made since the mongoDB doesn't create a database until and unless something is inserted to it...........
i would like to update the code so that it starts adding the searched queries to database

@treeJoker Please open a new Issue and Explain more in detail.


Question: SEO and google ?

Is there a way to make the datas visible in the HTML ?
Thanks.

google can handles ajex request using # tags. i.e #offers. If you desing your url like which shows current filtering data then google can handle.
i.e http://test.com#offers.


Support in Vcpkg

Can mruby support in vcpkg?

It may help laying down which steps would be necessary for that. What steps would be necessary for mruby to be available via vcpkg as well?

https://learn.microsoft.com/zh-cn/vcpkg/examples/packaging-github-repo
https://learn.microsoft.com/zh-cn/vcpkg/examples/packaging-zipfiles
like this ?

It may help laying down which steps would be necessary for that. What steps would be necessary for mruby to be available via vcpkg as well?

Thank you for the suggestion. Unfortunately, I don't know anything about vpkg. Actually, I have never programmed on Windows. If you (or anyone) send me a pull-request, I'd love to merge.

It's use cmake ...

Please note that I have never used vcpkg or written a cmake file, so this is all speculation.
As far as I can see, the vcpkg repository receives a pull request for build instructions for an arbitrary package.
The cmake file would be placed on the vcpkg side.
:crying_cat_face: No ports/ruby, so here's a link to python: https://github.com/microsoft/vcpkg/blob/2023.06.20/ports/python3/portfile.cmake
Also, it seems that cmake has a function to call external commands.
Therefore, it may be possible to use rake DESTDIR=... install from the vcpkg side.
In addition, it seems that vcpkg-specific patches for mruby can also be placed on the vcpkg side.
To sum up:

Probably no work needed in the mruby repository.
Probably someone interested will send a pull request to vcpkg (probably as ports/mruby).
Probably interested parties will update ports/mruby on the vcpkg side with a pull request.

Please note that I have never used vcpkg or written a cmake file, so this is all speculation.
As far as I can see, the vcpkg repository receives a pull request for build instructions for an arbitrary package. The cmake file would be placed on the vcpkg side. 😿 No ports/ruby, so here's a link to python: https://github.com/microsoft/vcpkg/blob/2023.06.20/ports/python3/portfile.cmake
Also, it seems that cmake has a function to call external commands. Therefore, it may be possible to use rake DESTDIR=... install from the vcpkg side.
In addition, it seems that vcpkg-specific patches for mruby can also be placed on the vcpkg side.
To sum up:

Probably no work needed in the mruby repository.
Probably someone interested will send a pull request to vcpkg (probably as ports/mruby).
Probably interested parties will update ports/mruby on the vcpkg side with a pull request.

Correct!


migrate to new architecture

This issue is reserved for participants of Welcome to Open Source, Atlanta.
If it’s still available after April 2nd, it’s all yours :)

:bug: The Bug
In the setup section of this repository’s README we tell the user to clone the repository using git clone git@github.com:hoodiehq/hoodie-store-server.git. But GitHub itself recommends the https:// protocol instead of the git@ which is SSH (see which remote should I use).
:dart: The Goal
Replace the git clone git@github.com:hoodiehq/hoodie-store-server.git with https://github.com/hoodiehq/hoodie-store-server.git in the README
:clipboard: Step by Step
If this is your first, welcome :tada: :smile: Here is a great tutorial on how to send a pull request

[ ] claim this issue (comment below)
[ ] Clone the repository to your computer
[ ] Edit the README.md file.
[ ] Commit the change docs(README): fixed git clone URL
[ ] Start a Pull Request.  Mention closes #36 in the description of the pull request
[ ] Done :+1: Comment below to ask for a review :)

Ping us in the Hoodie Chat or on Twitter if you have any questions :)

Claiming...


Make SSD character fall asleep

About the PR

If entity is SSD, it got asleep with force (cannot be awaked)
When entity no longer SSD, it can be awaked
Resolves #21906
Why / Balance

Cool
Technical details

no
Media

https://github.com/space-wizards/space-station-14/assets/124214523/2568d015-849c-456e-858a-547c0bb6ef3a

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: SSD character now will fall asleep until they are no longer SSD.

test are failing because of changes, im powerless here

test are failing because of changes, im powerless here

Add a check to make sure the entity isn't terminating before adding the component.

Omg, he is died

Thanks for the PR. Per the discussion on the original "Show SSD Indicator" CVar (I can link those if you can't find them), this behavior should probably also be controlled by the same CVar, i.e. not fall asleep if the CVar is disabled.

Thanks for the PR. Per the discussion on the original "Show SSD Indicator" CVar (I can link those if you can't find them), this behavior should probably also be controlled by the same CVar, i.e. not fall asleep if the CVar is disabled.

Tried to add check for the cvar but on ghost i got
[ERRO] con: localhost@JoeGenero: ExecuteError - ghost :
Robust.Shared.Configuration.InvalidConfigurationException: Trying to get unregistered variable 'ic.show_ssd_indicator'

for server and
[INFO] CON: > ghost
[INFO] CON: There was an error while executing the command: Robust.Shared.Configuration.InvalidConfigurationException: Trying to get unregistered variable 'ic.show_ssd_indicator'

for client

revenant buff real

is this still being worked on?

is this still being worked on?

its working, i just wait for the issue to be resolved, because i have no clue how to resolve it and as Tayrtahn said its not my problem, i just add the code that cause the issue to happen

Hello! The PR was put up to a maintainer vote which concluded with the following result: Merge, but with changes.
Maintainers think it's a neat idea, but that immediately falling asleep would be too punishing. This is due to the existence of revenants, who can kill a character who is sleeping, and also an antag DCing and finding themselves asleep even upon an immediate reconnect.
The PR has maintainer approval if there is a timer before the sleep happens. This delay should be controlled by a cvar so that it's easily adjustable on a server-to-server basis.
An exact time wasn't settled upon but there were suggestions ranging from 10 to 20 minutes.

The PR has maintainer approval if there is a timer before the sleep happens. This delay should be controlled by a cvar so that it's easily adjustable on a server-to-server basis.
An exact time wasn't settled upon but there were suggestions ranging from 10 to 20 minutes.

OOooOoo, It would be nice to have the ability to identify if people have been SSD for a while and they should be moved to cryo. One of my biggest fears of putting a yellow text SSD person in cryo is that they just DC'ed and had been gone for only a few minutes. This also means not dropping and breaking everything in your hand if you happen to lose connection while walking with a jug of chems or something.

An exact time wasn't settled upon but there were suggestions ranging from 10 to 20 minutes.

wow, it looks pretty long, i'll do 10 for now, someone else can change it later

i've looked into it a little, and it's too complicated for me right now
closing, maybe will come back later
if anyone wants to take it, you are welcome


Allow Launching of VI Even If LabVIEW Is Open

Need to handle:

LabVIEW is open but VI isn't - currently it does open but we lose our process reference so CLI stops prematurely.
VI is already open in LabVIEW - Not sure if this is detectable or handleable. If it can be, a suitable warning should be given.

Fixed with version 2.0


jdbc URL template example

Currently, I'm using a template like this
jdbc:couchbase://{host::localhost}?[:{port::8093}][/?][\?<&,user={user},password={password},{:identifier}={:identifier}>]

but when trying to execute a query with a valid user/password I get something like
[13014] User does not have credentials to run SELECT queries on the mkpremium bucket. Add role query_select on mkpremium to allow the query to run.
Could you please point me in the right direction

This example shows how to use credentials:
https://github.com/jdbc-json/jdbc-cb/blob/master/examples/UseCredentials.java
You need to create a user who has the Query Select role for the bucket you are trying to access, and provide that user's id and password. You can create a user and assign them roles on the "Security" tab.

Let me add that how we handle security has changed. We used to have a separate password for each bucket, so you needed to provide credentials for each bucket. Now we assign access credentials to users, so you need to create a user with the right permissions, and include that user and their password in the credentials object.

Right now I'm trying to use this not from code. I'm using a tool that support .jar drivers for connect to different databases

jdbc-json is not currently being supported. I recommend you try to use one of the commercial CDATA JDBC drivers.
https://docs.couchbase.com/server/current/connectors/odbc-jdbc-drivers.html


Shareable links should get preloaded by default

When user takes a screenshot or imports files via OS integration, we copy a shareable link to clipboard.
However, the content is not present on gateway node until someone requests it, and that leads to bad UX (https://github.com/ipfs-shipyard/ipfs-desktop/issues/1604#issuecomment-707274675).
IPFS Companion sends HTTP HEAD request to trigger data preload.
I believe Desktop should do the same by default, but there needs to be an option to disable preload,
in case user wants to avoid non-IPFS traffic coming from their machine.

"Preload Shareable Links" in the prefs menu could look like below. Note that this mockup also contains the other cube menu amendments currently outstanding in the Desktop issue queue ... that menu is getting a bit lengthy but doesn't seem criminal.


Question: Why do binary names contain uppercase letters?

Uppercase named binaries on Linux seem wrong, why do verge binaries contain uppercase letters?

seem? wtf

there isnt any issue with any case letters in any filename, do you have a actual problem or just a preference ? you can easily mod the code to poop out lowercase letters if you prefer, or just , dno , rename them?

I'm trying to package this for Arch Linux. I'm just wondering why the decision for uppercase letters was made.  I'll make the package with uppercase letters if that's what the verge community decided on.

imho, make the package lowercase, install uppercase binaries, so it at least follows the norm
that way, when git changes caps in future, the AUR would aswell?

It should be fine either way, I'll just submit lowercase package name and edit the package as things change. Thanks @buzztiaan

thanks @ShapeShifter499 and @buzztiaan i just woke up, i checked it out and its perfect


Plugin needs update

Plug-in currently not working due to needing an update.

I think that's what #43 is about. The author is aware.

Thanks for the notification. This is however a duplicate of #43, so I will close this issue.


recon_alloc stats

I'm interested in adding some of the recon_alloc output as statistics that vmstats could gather, such as memory/1 and fragmentation/1 - do you see any issues with using recon_alloc in this way, and would you be interested in a PR if I went ahead and added support?

I see no problem with it, but you'd have to make sure the format and calls are compatible with multiple Erlang versions. I think that presently everything in version OTP-17 and above is supported.


Add attributes to image and listing

add height and width to image object
add shop_section to listing

Thanks so much!


Disable tslint in generated file

Excluding files in TSLint via tslint.json is not supported and when using this tool TSLint may fail because of incompatibility.
Auto-generated code shouldn't pass thru TSLint so this change adds tslint-disable statement to the generated file and makes it safe to use with any TSLint configuration.

@brettjurgens fixed, thanks for the quick reply


Incorrect examples

Incorrect examples
On the page https://docs.microsoft.com/en-us/microsoft-365/compliance/keyword-queries-and-search-conditions?view=o365-worldwide at very bottom in Search tips and tricks section it is mentioned "You can use only prefix searches; for example, \cat* or \set*. Suffix searches (cat), infix searches (ct), and substring searches (cat) are not supported." But the examples in brackets are wrong. Prefix should be *cat or *set and suffix should be \cat* or \set*.
Thanks
Awaneet
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e83b77e5-e3ec-6a5f-1f09-e232e2dda483
Version Independent ID: 0b263c72-95a2-d111-20a7-68857f288369
Content: Keyword queries and search conditions for eDiscovery - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/keyword-queries-and-search-conditions.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@awaneet Thanks for feedback. But earlier in this same topic, we define prefix searches (also call prefix matching) and use the same examples as the ones you cite. AFAIK, these are correct. Here is link to section in SPO KQL documentation about prefix matching, where asterix comes at the end; https://docs.microsoft.com/en-us/sharepoint/dev/general-development/keyword-query-language-kql-syntax-reference#wildcard-operator


extra_failure_lines are wrapped with blank lines multiple times for aggregated failures

Subject of the issue
RSpec::Core::Formatters::ExceptionPresenter#extra_failure_lines wraps lines with unexpected blank lines. Number of wrapped blank lines equals to an index of an aggregated failure.
Your environment

Ruby version: ruby 3.0.2p107 (2021-07-07) [x86_64-linux]
rspec-core version: 3.12.0

Steps to reproduce
Code in online IDE<EMAIL_ADDRESS># frozen_string_literal: true

begin
  require 'bundler/inline'
rescue LoadError => e
  warn 'Bundler version 1.10 or later is required. Please update your Bundler'
  raise e
end

gemfile(true) do
  source 'https://rubygems.org'

  gem 'rspec', '3.12.0'
end

puts "Ruby version is: #{RUBY_VERSION}"
require 'rspec/autorun'

class ExampleListener
  def example_failed(notification)
    example = notification.example
    exception = example.exception

    return unless exception

    lines = example.metadata[:extra_failure_lines] = Array(example.metadata[:extra_failure_lines])

    lines << 'booom'

    # lines are appended only once
    # Uncomment and execute to double-check
    # puts "extra_failure_lines appended"
  end
end

RSpec.configure do |c|
  c.reporter.register_listener ExampleListener.new, :example_failed
end

RSpec.describe 'blank lines on aggregated failures with extra_failure_lines', :aggregate_failures do
  it 'fails' do
    (1..10).each do |_i|
      RSpec::Expectations.fail_with 'tadaa'
    end
  end
end

Expected behavior
extra_failure_lines are wrapped once per example.
     1.3) Failure/Error: RSpec::Expectations.fail_with 'tadaa'
            tadaa

          booom

          # rspec_report.rb:39:in `block (3 levels) in <main>'
          # rspec_report.rb:38:in `each'
          # rspec_report.rb:38:in `block (2 levels) in <main>'

     1.10) Failure/Error: RSpec::Expectations.fail_with 'tadaa'
             tadaa

           booom

           # rspec_report.rb:39:in `block (3 levels) in <main>'
           # rspec_report.rb:38:in `each'
           # rspec_report.rb:38:in `block (2 levels) in <main>'

Actual behavior
extra_failure_lines are wrapped number of times equals to the number of aggregated failures. Number of wrapped blank lines equals to an index of an aggregated failure.

     1.3) Failure/Error: RSpec::Expectations.fail_with 'tadaa'
            tadaa

          booom

          # rspec_report.rb:39:in `block (3 levels) in <main>'
          # rspec_report.rb:38:in `each'
          # rspec_report.rb:38:in `block (2 levels) in <main>'

     1.10) Failure/Error: RSpec::Expectations.fail_with 'tadaa'
             tadaa

           booom

           # rspec_report.rb:39:in `block (3 levels) in <main>'
           # rspec_report.rb:38:in `each'
           # rspec_report.rb:38:in `block (2 levels) in <main>'

Fix released in 3.12.1

It was released on the 3rd of Feburary.


Remove bundler/rubygems omnibus defs

Ruby includes built-in rubygems and bundler now so we're just installing
these over again. It makes the packages larger and makes it so we have
to keep the bundler release in the overrides file in sync with the
version that ruby ships in the ruby package.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2458#fed56cf2-af8c-431e-a6fc-a0fa44e80943


[Bug] Pulsar 3.0.3 client doesn't work with Flink connector: IllegalArgumentException: lookupTimeout must not be negative

Search before asking

[X] I searched in the issues and found nothing similar.

Version
Pulsar client 3.0.3
Minimal reproduce step
Configure Pulsar connector in Flink and use Flink SQL.
What did you expect to see?
No exceptions
What did you see instead?
[ERROR] Could not execute SQL statement. Reason:
java.lang.IllegalArgumentException: lookupTimeout must not be negative

Caused by: java.lang.IllegalArgumentException: lookupTimeout must not be negative
	at org.apache.pulsar.shade.com.google.common.base.Preconditions.checkArgument(Preconditions.java:143)
	at org.apache.pulsar.client.impl.ClientBuilderImpl.lookupTimeout(ClientBuilderImpl.java:169)
	at org.apache.flink.connector.pulsar.common.config.PulsarClientFactory.lambda$createClient$1(PulsarClientFactory.java:116)
	at org.apache.flink.connector.pulsar.common.config.PulsarConfiguration.useOption(PulsarConfiguration.java:101)
	at org.apache.flink.connector.pulsar.common.config.PulsarConfiguration.useOption(PulsarConfiguration.java:91)
	at org.apache.flink.connector.pulsar.common.config.PulsarClientFactory.createClient(PulsarClientFactory.java:115)
	at org.apache.flink.connector.pulsar.sink.writer.topic.MetadataListener.open(MetadataListener.java:102)
	at org.apache.flink.connector.pulsar.sink.writer.PulsarWriter.<init>(PulsarWriter.java:120)
	at org.apache.flink.connector.pulsar.sink.PulsarSink.createWriter(PulsarSink.java:134)
	at org.apache.flink.connector.pulsar.sink.PulsarSink.createWriter(PulsarSink.java:83)
	at org.apache.flink.streaming.runtime.operators.sink.StatelessSinkWriterStateHandler.createWriter(StatelessSinkWriterStateHandler.java:39)
	at org.apache.flink.streaming.runtime.operators.sink.SinkWriterOperator.initializeState(SinkWriterOperator.java:149)
	at org.apache.flink.streaming.api.operators.StreamOperatorStateHandler.initializeOperatorState(StreamOperatorStateHandler.java:122)
	at org.apache.flink.streaming.api.operators.AbstractStreamOperator.initializeState(AbstractStreamOperator.java:274)
	at org.apache.flink.streaming.runtime.tasks.RegularOperatorChain.initializeStateAndOpenOperators(RegularOperatorChain.java:106)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restoreGates(StreamTask.java:753)
	at org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.call(StreamTaskActionExecutor.java:55)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restoreInternal(StreamTask.java:728)
	at org.apache.flink.streaming.runtime.tasks.StreamTask.restore(StreamTask.java:693)
	at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:953)
	at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:922)
	at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:746)
	at org.apache.flink.runtime.taskmanager.Task.run(Task.java:562)
	at java.base/java.lang.Thread.run(Unknown Source)

Anything else?
This broke with #22023 changes.
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Maybe we should revert the fix at the old branch.
The disabled/default value for lookupTimeout being 0 should be reasonable. However, these checks indeed affect the previous logic and should not be cherry-picked.

Maybe we should revert the fix at the old branch. The disabled/default value for lookupTimeout being 0 should be reasonable. However, these checks indeed affect the previous logic and should not be cherry-picked.

I think that the behavior of -1 and 0 for lookupTimeout should be consistent across master branch and older branches. If this isn't the case, it is a breaking change to Pulsar clients as the example of Flink Pulsar connector demonstrates.

I think that the behavior of -1 and 0 for lookupTimeout should be consistent across master branch and older branches. If this isn't the case, it is a breaking change to Pulsar clients as the example of Flink Pulsar connector demonstrates.

This means we should not add parameter checks to the already released interface. We should reverse this PR in the master branch.

This means we should not add parameter checks to the already released interface. We should reverse this PR in the master branch.

I'm fine with reverting #22023 completely in all branches to reduce the risk of regressions.


required properties is not supported

https://github.com/hosseinmd/swagger-typescript/pull/12
Schema has a required property which specified which property of Properties is not nullable. There is confusion because every property also has a nullable property.
I solved that v 3.3.4-next1. @rodrigozoff @tbowmo

By default, all object properties are optional. You can specify the required properties in the required list.
In my case I use this list for this.

Haven't looked at the required property yet, but will do when I get the time (off grid for the weekend though, so will be next week before I get around to it..)

Haven't looked at the required property yet, but will do when I get the time (off grid for the weekend though, so will be next week before I get around to it..)

I changed @rodrigozoff PR and published to 3.3.4-next1. Check it out.

https://github.com/hosseinmd/swagger-typescript/commits/required

Hi! In my fork, I did many changes, Improvements for me.

Use operationid over convention for the servicename.
Replace interfaces for classes that extends DtoBase for custom implementations.
Support to required list.
First letter of name of documents in upper case.
Add format, min, max, pattern, maxLength to the JDOC.

In my project, my custom implementation of DtoBase, have a method that Validate using the definition in models in OAS and return a list of invalidations.
Please, if you considen that all chages are improvements, I make a pull request after test all.
Sorry for my English, I know is bad.

All right, thank you, please create a PR, I think we should discuss them.

I think a single function is so beautiful to use, a group of tags is not seemed handsome (maybe just for JavaScript developers). We chose to call it just a single function, instead of an object. for example: postUsuario(params) is so better than Apis.usuario.postUsuario(params)
So about Operationid, we added methodName to swagger.config.json to customize the name of the method,(Added in Readme).

I just did the pullrequest.
About

" for example: postUsuario(params) is so better than Apis.usuario.postUsuario(params) "

In ours  implementations:

import { Apis } from "../services";

const apiLugarPasajero = Apis.LugarPasajero;
const apiUsuario = Apis.Usuario;
const apiPasajero = Apis.Pasajero;

Then use like this
let response = await apiPasajero.getPasajero({ id: this.controller.IdUsuario });
One import.

@rodrigozoff at could also be accomplished with the following
import * as api from ". /services'
I like the possibility to only include what's needed, and nothing else.

Importing a single function has a benefit for webpack, it can delete another function which was never used.

In ours case, for now, we have 900 operations, in the future more. Finding them is slowest that using the [tag].[operationid] like sawgger ui. I will working about that (Functional Programmig maybe is the solution)

In ours case, for now, we have 900 operations, in the future more. Finding them is slowest that using the [tag].[operationid] like sawgger ui. I will working about that (Functional Programmig maybe is the solution)

I have another suggestion about that. We can separate methods into files based on tags.
For example:
currently
import {getAccount} from './dir/services'

to
import {getAccount} from './dir/account'` <-- account is tag

or
import * as Account from './dir/account';
Account.getAccount();
``

@hosseinmd that sounds like an excellent plan, to split things into multiple files, based on tags.
But what if an operation has multiple tags?

Maybe combine them together, for example tags are: ["foo","bar"] we are combining them and make a file name fooBar.ts, but I am not sure if the tags are stable.

And tags is not required. What about services that don't have tags?

If they don't have a tag, then put them in the "unknown" bucket: services.ts?

All right, it can be done.

Perhaps this "tags" thing is suitable to split into a new issue (since the original required property is solved)?


Flow stuck in seemingly infinite loop while initializing.

Testing out flow on an existing (large) project, but have only marked one file with /* @flow */, and have excluded npm and jspm module directories:
.flowconfig
[ignore]
./node_modules/
./jspm_packages/

[include]
./src/account/account-constants.js

[libs]

[options]

Here is what I'm seeing:

$ flow
Launching Flow server for C:\Projects\MyProject
Spawned flow server (pid=10124)
Logs will go to C:\Users\Josh\AppData\Local\Temp\flow\CzCzBProjectszBMyProject.log
Launching Flow server for C:\Projects\MyProject
Spawned flow server (pid=9008)
Logs will go to C:\Users\Josh\AppData\Local\Temp\flow\CzCzBProjectszBMyProject.log
Launching Flow server for C:\Projects\MyProject
Spawned flow server (pid=18292)
Logs will go to C:\Users\Josh\AppData\Local\Temp\flow\CzCzBProjectszBMyProject.log
Launching Flow server for C:\Projects\MyProject
Spawned flow server (pid=8232)
Logs will go to C:\Users\Josh\AppData\Local\Temp\flow\CzCzBProjectszBMyProject.log
Launching Flow server for C:\Projects\MyProject
Spawned flow server (pid=8352)
Logs will go to C:\Users\Josh\AppData\Local\Temp\flow\CzCzBProjectszBMyProject.log
flow is still initializing; this can take some time. [merging inference] -

The log is mostly empty:

[2017-03-16 16:24:47] Initializing Server (This might take some time)
[2017-03-16 16:24:47] executable=C:\Users\Josh\AppData\Roaming\npm\node_modules\flow-bin\flow-win64-v0.41.0\flow.exe
[2017-03-16 16:24:47] version=0.41.0
[2017-03-16 16:24:47] Parsing

Not sure how to debug this further.

I suspect this is related to the multiflow change regarding rest args introduced in 0.39. I'm seeing something similar. See #3370 and #3443 for a very minimal reproduction.
If you're using ...args without type declarations anywhere in your code, try adding them and see if the problem goes away.

May be related, may be not - I had this endless spawn loop when I had an invalid .flowconfig that included directories that didn't exist (I had changed the project structure and forgot to change the Flow config file).

Hello. Is there a way to determine what causes hanging flow?
We had flow-bin v0.30.
At some moment running flow just resulted in infinite initialization wit high CPU load:
Launching Flow server for /Users/dev/Transient/ws/project
Spawned flow server (pid=66740)
Logs will go to /private/tmp/flow/zSUserszSdevzSTransientzSwszSproject.log
flow is still initializing; this can take some time. [parsing] \

Logs contain:
[2017-04-19 17:02:26] Initializing Server (This might take some time)
[2017-04-19 17:02:26] executable=/Users/dev/Transient/ws/project/node_modules/flow-bin/flow-osx-v0.44.2/flow
[2017-04-19 17:02:26] version=0.30.0
[2017-04-19 17:02:26] Parsing

I have updated to 0.44.1 - same hanging.

@andrejs-sisojevs-accenture Have a look at the log?

How long did you wait? How much source code is there? It appears to be busy parsing, how do you know it hangs?

@lll000111 it used to initialise in a second.
Now it hangs for 5 minutes with overheating CPU until I kill process.
Project is not big - 10k lines of code.

I'm sorry - I guess it was some corruption on my side.
I've erased flow-bin, then fully reinstalled it - now it works properly.

Hey guys,
I also faced this issue, and after few (really) frustrating night, I was able to create a file that always fails (Now we can start debugging 👍  !)
Running this on the flow 0.44.2 gets stuck with flow is still initializing; this can take some time. [local inference]
Notice something interesting - it only gets stuck with 4 of these methods -> 3 and it works fine!
// @flow

type Iface = {
  fn1: (arg: string) => Iface,
  fn2: (arg: string) => Iface,
  fn3: (arg: string) => Iface,
  fn4: (arg: string) => Iface
};

function t(): Iface {

    const context = function (...args): any {
    };

    context.fn1 = (arg: string) => {
      return context;
    };

    context.fn2 = (arg: string) => {
      return context;
    };

    context.fn3 = (arg: string) => {
      return context;
    };

    context.fn4 = (arg: string) => {
      return context;
    };

    return context;
}

I forgot to say that i am using OSX.
AND (fun fact) I was able to cause flow's website to stackoverflow with this code!
https://flow.org/try/#0PTAEAEDMBsHsHcBQiAuBPADgU1ASUgIYDGOAvKAN6KiiQB2AjAFygAUBATgOYsDOKHAJZ0uASlCkAfHkIkANNVp0ATC3bc+A4WInT8xLApr0AzGs49Q-ISPFSZBo0oAs5jVa23dDkogC+ANzIkACudEQogrB0oCisoiz6JJTINDRE0fygGXQoWAAeKBK0YRFRMawAdNUWvAmgBHRoKWmggciK6dF5hZX0DMXqltbadtJUrTQcWCghHDE5PShBre2d2d0FKH0qgxaaNjr2E5PTs-MbuVsraWuti1s7JnvuI17H61MzcwubhTc0O5pB69ejOF7DTxHcafUBnH6XJYAtpBdbwi4g5b+IA

A workaround is to use interface:
interface Iface {
  fn1: (arg: string) => Iface,
  fn2: (arg: string) => Iface,
  fn3: (arg: string) => Iface,
  fn4: (arg: string) => Iface
}

Some checks are blowing up in the original version but are optimized with interfaces. Bringing those optimizations back to vanilla object types will take a while.

@nadav-dav We've identified the cause of your issue. I created a separate issue to in #3849, which you can subscribe to if you want to be notified when a fix lands. Thanks for sharing a small repro case! I'm sorry we caused you to burn so much time. The repro made it much easier to find the underlying cause.

Thanks @sam for the response! Rock on:)

@samwgoldman I wonder if you could add some kind of guard-construction, which would detect hanged parsing and log where it failed?

I'm getting the same kind of behavior when type checking this code:
let createRelationshipPaths = (path = "", rels = []) => {
  return rels.length
    ? rels.reduce((acc, [name, nested]) => {
        return [
          ...acc,
          ...createRelationshipPaths(path ? `${path}.${name}` : name, nested)
        ];
      }, path ? [path] : [])
    : [path];
};

let createRelationshipPaths = (path = "", rels = []): string[] => {
// This fixes it --------------------------------------^
  return rels.length
    ? rels.reduce((acc, [name, nested]) => {
        return [
          ...acc,
          ...createRelationshipPaths(path ? `${path}.${name}` : name, nested)
        ];
      }, path ? [path] : [])
    : [path];
};

@JoshMcCullough is your issue gone with 0.47?

Another repro taken from some production code:
https://flow.org/try/#0PTAEAEDMBsHsHcBQiAuBPADgU1ARQK5YBOaA8higJawB2AzqALygDeiooA2gNZZoBcoOiiKUaAcwC6g4aImgAPqBr4AtgCNii0OtixoWAIY1tbDhx58ZIsVOtzx2lRq1KAgkSKG0AHlm2nNU0iAD4AGnZQAF8IqORIfBoAYypaUHEsFAAxSmgUYjos2CIcrGgAEwAKSEoy8oA5Q1UsMNAauoA1Q2hCVpq84kbmugBKVkiiTPwiE378oiGsOgA6SfL8JKxK6tqKtySkvtz5xbHGEPHzUCTaYVAAN27CJjbd8q6erE45waasSUiHBu9BQrwGRAAyjZ5MwAAYAfXhABIWD8Fn8orDAddbqDHp8oQ4Xh4vGhlpQ6CTvJV8YQxgB+B5PLDLABWsDElQA5GEuWNBLSsMgrpRIKBKgBCQWE2xjMxXUCTFDTWZvfZJbFxbFKlVcbEcZaG9p7A4RBWgWEo40NDFW47EGUSKKMFFYZKwcpYACqACUAJIAYVgqgwtDdKEqjvENOZUZGI0xZvMAI4MS4khGiC1wLuAEdCCQoy9KvniAI8AWyBRqPQXiwomcLvKc6DrQxmKR1KysCllrw0HQS5XMxwQIqsKpYPcAlTfP4JBd4LloNdDPg6DgYAhQChYKAABbGRyVdREBAbog7wzqUBL6ArpJeOj7kc4kFg+azl5t1ZYdabbY0ToQRZz8aFxHCV46kbS5zBbKCKg+Z5mFLEhvjeAFsVFcV0GwWAxWtJCcAlRhmC5WAux7FA+Vgq4dRmLhDWWIDWktVE3mdV13U9X1A2DUMaHDSNwJ2TpmXjTEU3MLUrngtFFnbUBO27Xt+0HQjxOxOT7SIQpilKCoXgybIdL0ko3lEiojjEz4jnBBTM21KYGM4JiWNANzTKKcy6iktNOAzYVx2VBi0VnZYDAkFB91ARlYXpO1wXC9lOS5AAyPlMVAQQuS5LNkCAA

Folks, in my case (I'm on Windows 10) the issue were resolved by running watchman watch-del-all and then uninstalling watchman (or removing it from the PATH). It seems just weird but anytime I install watchman flow doesn't work.

I was getting the infinite loop problem on Flow 0.56.0. Downgrading to 0.55.0 worked.

I'm getting this infinite loop as well. I've tried killing and reinstalling the Flow server and wiping and reinstalling node_modules without success. Here are my logs:
[2017-11-03 09:49:30] Initializing Server (This might take some time)
[2017-11-03 09:49:30] executable=/Users/trevordmiller/repos/snout/apps/snout_web/assets/node_modules/flow-bin/flow-osx-v0.50.0/flow
[2017-11-03 09:49:30] version=0.50.0
[2017-11-03 09:49:30] Parsing
[2017-11-03 09:49:37] Building package heap
[2017-11-03 09:49:37] Loading libraries
[2017-11-03 09:49:40] Resolving dependencies
[2017-11-03 09:49:41] Running local inference
[2017-11-03 09:49:42] Calculating dependencies
[2017-11-03 09:49:42] Merging

Per my last comment, I finally found the file causing the infinite "merging inference" by removing /* @flow */ comments directory by directory, then file by file until finding which file was causing flow to hang. The culprit looked like this:
const getJsonFields = (parsedBody: any, prefix: string = '') =>
  Object.keys(parsedBody).reduce((memo, key) => {
    const value = parsedBody[key]

    if (Array.isArray(value)) {
      return memo
    } else if (value !== null && typeof value === 'object') {
      return [...memo, ...getJsonFields(value, prefix + key + '.')]
    } else {
      return [...memo, prefix + key]
    }
  }, [])

Adding explicit types on the reduce arguments ((memo: Array<string>, key: string) fixed the problem for me:
const getJsonFields = (parsedBody: any, prefix: string = '') =>
  Object.keys(parsedBody).reduce((memo: Array<string>, key: string) => {
    const value = parsedBody[key]

    if (Array.isArray(value)) {
      return memo
    } else if (value !== null && typeof value === 'object') {
      return [...memo, ...getJsonFields(value, prefix + key + '.')]
    } else {
      return [...memo, prefix + key]
    }
  }, [])

I got the same issue as @trevordmiller. Infinite loop on OS X but not in CI running Linux.
How is that even possible ? 😂
The culprit was also a reduce function that returned arrays using the spread operator. Fixed by adding types to the arguments of the arrow function.
z$ ./node_modules/.bin/flow version
Flow, a static type checker for JavaScript, version 0.57.3

@jomi-se Try to update to the latest 65 version and run killall flow

I tried out version 0.65.0, flow still gets stuck in the same file on OS X
Please wait. Server is initializing (merged files 215/237 (90.7%)): |

Adding type to all reduce functions arguments in this file fixes it though. I also was able to reproduce it locally with a single file containing
// @flow
const getJsonFields = (parsedBody: any, prefix: string = '') =>
  Object.keys(parsedBody).reduce((memo, key) => {
    const value = parsedBody[key]

    if (Array.isArray(value)) {
      return memo
    } else if (value !== null && typeof value === 'object') {
      return [...memo, ...getJsonFields(value, prefix + key + '.')]
    } else {
      return [...memo, prefix + key]
    }
  }, [])

reduce is pretty common in javascript, this is a really big deal
any plans to fix this?

@sibelius It's not about reduce itself. Just about recursion with it.

Had the same issue, the reason was dist folder, which was created after 'npm run build'.

I got the same problem with reduce. Adding type annotations to the functions did the trick.


ModuleIsLoaded() Errors if Golang is from snap

With golang installed from a snap, ModuleIsLoaded() always exited with status 1 - I think because it doesn't have permission to run the pacmd command. Using "normal" golang (downloaded from the go website) does not have the same problem.
I'm not sure what the answer is, a line in the README to warn users maybe? But I wanted to mention it in case anyone else hit the same thing.

This doesn't make sense. Go is a compiler, and as such it is only concerned about build-time stuff, not runtime stuff.
Were you running your compiled binary inside a sandbox as well? That could explain it, but it has nothing to do with the programming language or the compiler.


[BAT] Drone

Coverage remained the same at 54.431% when pulling ffd81cc37456d115d0ba1a50a87c6cb461859ad4 on wy65701436:drone into 5692f8eea6eb8e119a2412cfa6817ead2a2455ef on vmware:drone.


Rows can probably be made an IntoIterator

Hi there @jgallagher ! Very neat library, I'm glad to have access to a simple and feature-rich Rust API to manage SQLite3 databases, this is very much appreciated.
~I noticed how you mentioned that Rows cannot be made an iterator, but actually I think it can: since you only ever send a reference to the internal row once, so you could actually send that row, using Option.take.~
~I tried the following code within row.rs and it compiled without trouble, so it might be worth looking into that:~
impl<'stmt> Iterator for Rows<'stmt> {
    type Item = Result<Row<'stmt>>;
    fn next(&mut self) -> Option<Self::Item> {
        match self.advance() {
            Err(e) => Some(Err(e)),
            Ok(_) => self.row.take().map(Ok),
        }
    }
}

~Taking ownership of Row is not a big deal anyway, since it only wraps a reference, which means once the compiler does its magic there is probably not much difference between &Row and Row anyway.~
EDIT: Okay, I think I got why this is not possible, but there is probably a way around this without breaking anything, as described below.
I'm happy to send a PR with proper tests if that's something you'd want to include in the code base. Cheers!

Or i guess this is related to #150, but then I think there is probably way to at least implement an IntoIterator trait using an proxy iterator with a lifetime bound to the lifetime of the rows, e.g.
impl<'a, 'stmt> IntoIterator for &'a Rows<'stmt'> {
   ...
}

See impl<'stmt> FallibleStreamingIterator for Rows<'stmt> and fallible_streaming_iterator.

More broadly, an iterator isn't allowed to yield items that are borrowed from the iterator itself. This is a known problem (https://docs.rs/streaming-iterator/0.1.5/streaming_iterator/ has a decent overview of the problem -- the fallible- crate just tweaks the definition for better ergonomics), there isn't really a way to make it compatible.
Note that https://docs.rs/rusqlite/0.21.0/rusqlite/struct.AndThenRows.html is able to be an iterator, if that works for your case.


is_bot property is not implemented well

@property
    def is_bot(self):
        return True if self.device.family == 'Spider' else False

Is it okay to update current implementation of is_bot property? Have any idea?

Any suggestions? :)

Here the full bot list: http://www.robotstxt.org/db/all.txt

I have a supporting test from a corpus of 211,000 UA strings. This is a rare 'miss', but, the attached shows a case where the word 'bot' in a user agent string correlates with bots that aren't caught by the parser.
agents_not_is_bot.txt
Also, code review on the function:
return True if self.device.family == 'Spider' else False
can be written as:
return self.device.family == 'Spider'

Has there been any more thought about this?
Do you (we) consider this to be the appropriate place for building out more accurate bot detection or is it the responsibility of ua_parser (and the regexes in uap-core)?
How about an attempt to integrate https://pypi.python.org/pypi/robot-detection in some way? It should be reasonably simple. The only difficulty I see is reconciling what ua-parser considers a 'spider' with what robot-detection considers a bot; No doubt they will diverge. Is that a problem?

Bump on this would be nice if this was something that was configurable so we can register our own bots.


[Informations - English] Upgrading to macOS Sonoma

ℹ Ce guide est aussi disponible en Français ici
Contents

What's changing in macOS Sonoma ?

Discover all the new features of the new release
Apple drops support for some SMBIOS
Hackintosh Broadcom cards are no longer officially supported

How to upgrade ?

Discover all the new features of the new release
You can learn more about the new features of macOS Sonoma by visiting Apple's official website.
Apple drops support for some SMBIOS
As Apple drops support for some older Macs, some SMBIOS are not supported anymore by macOS Sonoma (see more).
The iMac18,1 and iMac18,3 SMBIOS, that were previously used by this EFI, are no longer supported and you need to regenerate your entire SMBIOS (SystemProductName, SystemSerialNumber, MLB and SystemUUID) because these SMBIOS correspond to the 2017 iMac models.
Hackintosh Broadcom cards are no longer officially supported
While macOS Sonoma drops support for some older Macs, the drivers allowing support for the Broadcom cards present in these Macs have been removed from macOS system files.
Thus, the only Broadcom cards that are still supported by macOS Sonoma are soldered to the logic board of the Macs supported by macOS Sonoma and are therefore not available for purchase at the moment, as was the Fenvi T919.
How to upgrade
First, you need to understand that by upgrading to macOS Sonoma today, you will lose some features due to the drop of support for Hackintosh Broadcom cards (as said earlier). After the upgrade, the following features will no longer work :

Wi-Fi
AirDrop
AirPlay and AirPlay to Mac
Apple Watch Unlock
Location Services
Wireless Continuity Camera
Wireless Continuity Markup
Wireless Continuity Sketch
Instant Hotspot
Sidecar
Universal Control

ℹ The support for current Hackintosh Broadcom cards may be restored in a future EFI update
This thread will be updated in case an update repairs the functionality of Hackintosh Broadcom cards.

If you still want to upgrade, you need to check what SMBIOS you are using right now :

Download ProperTree by clicking here
Mount your EFI
Launch ProperTree and open the config.plist file present in EFI > OC
Check the value in Generic -> SystemProductName

If the value is iMac18,3 and you're using a dedicated GPU (AMD), we're sorry but your configuration is no longer supported by this EFI. If you want to continue using this EFI and upgrade to macOS Sonoma, we invite you to switch to a iGPU only configuration.

If the value is Macmini8,1 make sure to update your EFI to the latest version. Once the update is complete, you're ready to upgrade to macOS Sonoma.

If the value is iMac18,1 you will need to update your SMBIOS as this iMac model is no longer supported.
Follow these steps in order to update your SMBIOS :

Sign out of iCloud, iMessage and FaceTime
Update your EFI to the latest version
Download GenSMBIOS and extract it.
Launch the program by executing GenSMBIOS.bat if you're on Windows or GenSMBIOS.command if you're on macOS.
Once the script is running, pick the option 1 for downloading MacSerial.
Pick option 3 for selecting the SMBIOS and enter Macmini8,1 (case sensitive).

This will give you an output similar to the following :
  #######################################################
 #              Macmini8,1 SMBIOS Info                 #
#######################################################

Type:         Macmini8,1
Serial:       C07LNUYMJYVX
Board Serial: C07345500CDKXPGJC
SmUUID:       C58DD217-9C50-439D-9D72-E81D99DBB062
Apple ROM:    903C92E450A1

Check the generated serial number on Apple Check Coverage. You want to get this message back : "We’re sorry, we’re unable to check coverage for this serial number". If you don't get it, you need to regenerate another serial.
Using ProperTree, modify your config.plist file using the output given by GenSMBIOS :

The Type part gets copied to Generic -> SystemProductName.
The Serial part gets copied to Generic -> SystemSerialNumber.
The Board Serial part gets copied to Generic -> MLB.
The SmUUID part gets copied to Generic -> SystemUUID.
Don't use the Apple ROM part !
For Generic -> ROM, we use the MAC Address of the network interface, in all lowercase, and without :

ℹ For example :

MAC : 00:16:CB:00:11:22
ROM : 0016cb001122

Save your config.plist and you can reboot using your new EFI.
When the system is booted, click on the Apple Menu  (at the top left of your screen) then click on "About this Mac". If the window displays a Mac mini 2018, the SMBIOS update is successful.
You can now re-sign in to iCloud, iMessage, FaceTime and upgrade to macOS Sonoma.

⚠ NOTE AND WARNINGS :

You need to have the latest version of Python installed to run GenSMBIOS.
 Dortania, me and any other guides are not held accountable for what you do.

Hackintosh Broadcom cards are functional again with the new v3.01 version !
A temporary fix for Broadcom cards has been made available by the Dortania team through OpenCore Legacy Patcher but this fix requires disabling of some macOS security features and post-install patching.

How this fix working ?
This fix is working by porting the macOS Ventura Broadcom drivers to macOS Sonoma but for this fix to work, we had to put macOS System Integrity Protection in a less secure state. We also had to completely disable Apple Mobile File Integrity and SecureBootModel.

⚠ WARNINGS :

These changes reduce the security of macOS and allow any application running with administrator privileges to have full access to macOS system files.
Keep in mind that incremental system updates will no longer work once you applied root patches. Instead the complete macOS installer will be downloaded (≈ 13 GB). There's a workaround that allows incremental updates to work temporarily and we explain it below.

How to bring back support for Hackintosh Broadcom cards :

Update your EFI to the latest version
Download the latest nightly build of OpenCore Legacy Patcher
Extract and open the downloaded file
Click on the Post-Install Root Patch button
Click on the Start Root Patching button
When the patching is finished, it will prompt you to reboot, do it

Your Broadcom card is now fully functional again

Workaround to get back incremental updates
Incremental macOS system updates are disabled when the macOS system seal is altered.
By applying root patches, you tamper with macOS system seal. So you need to revert those root patches in order to restore macOS system seal and get incremental system updates back.
Here are the steps to follow for incremental updates to work temporarily :

Launch OpenCore Legacy Patcher (Applications -> OpenCore-Patcher.app)
Click on the Post-Install Root Patch button
Click on the Revert Root Patches button
When the operation is finished, it will prompt you to reboot, do it
Open macOS System Settings and proceed to the update
Once the software update is finished, launch OpenCore Legacy Patcher once again
Click on the Post-Install Root Patch button
Click on the Start Root Patching button
When the patching is finished, it will prompt you to reboot once again, do it

You have now successfully updated macOS and you can still use your Broadcom card.

ℹ NOTE :

After reverting the root patches, Wi-Fi will no longer work. So you will have to rely on Ethernet to update macOS.
Before updating macOS, always make sure your EFI is updated to the latest version and that this version is compatible to the version of macOS you're updating to.


Non-final fields in Dart structs.

Use the #[frb(non_final)] attribute on a field in a Rust struct to
make the corresponding field in the Dart struct non-final.

Looks good! Except for a bit of change

By the way I am confused: why no code is added to frb_example/pure_dart/rust, i.e. no rust test code added?

LGTM. Will merge when CI passes

Somebody already added a test case, but the feature was never implemented.

See pure_dart/rust/src/api.rs line 389.

CI seems to be failing due to other reasons, i.e. lib/main.dart:50:20: Error: 'Size' is imported from both 'dart:ffi' and 'dart:ui'.

🎉


Simplify missing to use the has() method

Bit DRY-er...
But meh. I could take it or leave it.
D

perfect, thanks

@all-contributors please add @davidpiesse for code


https://scratch.mit.edu/projects/224379312/

https://scratch.mit.edu/projects/224379312/
https://phosphorus.github.io/#224379312
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
it cant upload my game.

Doesn't exist ¯_(ツ)_/¯


Memory never dropped if captured inside host function closure

Hi, I'm using wasmtime = 0.21 and run into a bug where the Memory is never dropped if moved inside a closure passed to Linker::func.
Here is a minimal example:
use wasmtime::*;

struct MyMemory {}
unsafe impl LinearMemory for MyMemory {
    fn size(&self) -> u32 {
        0
    }

    fn grow(&self, _delta: u32) -> Option<u32> {
        None
    }

    fn as_ptr(&self) -> *mut u8 {
        std::ptr::null_mut()
    }
}

impl Drop for MyMemory {
    fn drop(&mut self) {
        println!("Dropped!")
    }
}

struct MyMemoryCreator {}
unsafe impl MemoryCreator for MyMemoryCreator {
    fn new_memory(
        &self,
        _ty: MemoryType,
        _reserved_size_in_bytes: Option<u64>,
        _guard_size_in_bytes: u64,
    ) -> Result<Box<dyn LinearMemory>, String> {
        Ok(Box::new(MyMemory {}))
    }
}

fn main() {
    let mut config = Config::new();
    config.with_host_memory(std::sync::Arc::new(MyMemoryCreator {}));
    let engine = Engine::new(&config);
    let store = Store::new(&engine);
    let mut linker = Linker::new(&store);
    let memory_ty = MemoryType::new(Limits::new(1, None));
    let memory = Memory::new(&store, memory_ty);
    let captured_memory = memory.clone();
    linker
        .func("", "", move || {
            let _ = captured_memory;
        })
        .unwrap();
}

MyMemory and MyMemoryCreator are added here only for the purpose of printing out on drop, but the same behaviour is observed with the default Memory.
In this example "Dropped!" is never printed out, but if I comment out let _ = captured_memory; it is. I assume there is somewhere a cycle in reference counting.
I'm also aware that the instance memory can be accessed through the first argument (Caller), but because of some other design decisions I prefer capturing some memories this way. Would this be considered a bug or a Memory should never be captured like this?

This is unfortunately expected behavior right now, albeit one we may want to investigate fixing with additional APIs. The problem is that you're creating a cycle of Rc (Store owns Func data which owns Memory which owns the same Store) which never gets freed. This is a known drawback of Rc in Rust, but currently a design decision in Wasmtime.
Ideally if you can the best fix would be to use the Caller structure which handles this correctly. Otherwise we may need to provide "weak" forms of things like Memory so you can close over the weak verisons without inducing a reference cycle.

This is unfortunately expected behavior right now, albeit one we may want to investigate fixing with additional APIs. The problem is that you're creating a cycle of Rc (Store owns Func data which owns Memory which owns the same Store) which never gets freed. This is a known drawback of Rc in Rust, but currently a design decision in Wasmtime.
Ideally if you can the best fix would be to use the Caller structure which handles this correctly. Otherwise we may need to provide "weak" forms of things like Memory so you can close over the weak verisons without inducing a reference cycle.

I tried to replicate this bug on 0.32.0, but it seems to be fixed! I had to update example above, but i am sure logic didn't change:
use wasmtime::*;

struct MyMemory {}
unsafe impl LinearMemory for MyMemory {
    fn byte_size(&self) -> usize {
        0
    }

    fn grow_to(&mut self, _new: usize) -> anyhow::Result<()> {
        anyhow::bail!("cannot grow memory")
    }

    fn as_ptr(&self) -> *mut u8 {
        std::ptr::null_mut()
    }

    fn maximum_byte_size(&self) -> Option<usize> {
        Some(0)
    }
}

impl Drop for MyMemory {
    fn drop(&mut self) {
        println!("Dropped!")
    }
}

struct MyMemoryCreator {}
unsafe impl MemoryCreator for MyMemoryCreator {
    fn new_memory(
        &self,
        _ty: MemoryType,
        _minimum: usize,
        _maximum: Option<usize>,
        _reserved_size_in_bytes: Option<usize>,
        _guard_size_in_bytes: usize,
    ) -> Result<Box<dyn LinearMemory>, String> {
        Ok(Box::new(MyMemory {}))
    }
}

fn main() {
    let mut config = Config::new();
    config.with_host_memory(std::sync::Arc::new(MyMemoryCreator {}));
    let engine = Engine::new(&config).unwrap();
    let mut store = Store::new(&engine, ());
    let mut linker = Linker::<()>::new(&engine);
    let memory_ty = MemoryType::new(1, None);
    let memory = Memory::new(&mut store, memory_ty).unwrap();
    let captured_memory = memory.clone();
    linker
        .func_wrap("", "", move || {
            let _ = captured_memory;
        })
        .unwrap();
}

I tried to replicate this bug on 0.32.0, but it seems to be fixed! I had to update example above, but i am sure logic didn't change:
use wasmtime::*;

struct MyMemory {}
unsafe impl LinearMemory for MyMemory {
    fn byte_size(&self) -> usize {
        0
    }

    fn grow_to(&mut self, _new: usize) -> anyhow::Result<()> {
        anyhow::bail!("cannot grow memory")
    }

    fn as_ptr(&self) -> *mut u8 {
        std::ptr::null_mut()
    }

    fn maximum_byte_size(&self) -> Option<usize> {
        Some(0)
    }
}

impl Drop for MyMemory {
    fn drop(&mut self) {
        println!("Dropped!")
    }
}

struct MyMemoryCreator {}
unsafe impl MemoryCreator for MyMemoryCreator {
    fn new_memory(
        &self,
        _ty: MemoryType,
        _minimum: usize,
        _maximum: Option<usize>,
        _reserved_size_in_bytes: Option<usize>,
        _guard_size_in_bytes: usize,
    ) -> Result<Box<dyn LinearMemory>, String> {
        Ok(Box::new(MyMemory {}))
    }
}

fn main() {
    let mut config = Config::new();
    config.with_host_memory(std::sync::Arc::new(MyMemoryCreator {}));
    let engine = Engine::new(&config).unwrap();
    let mut store = Store::new(&engine, ());
    let mut linker = Linker::<()>::new(&engine);
    let memory_ty = MemoryType::new(1, None);
    let memory = Memory::new(&mut store, memory_ty).unwrap();
    let captured_memory = memory.clone();
    linker
        .func_wrap("", "", move || {
            let _ = captured_memory;
        })
        .unwrap();
}

Ah yes indeed, this has been fixed!


Remove unused class AlterTableReplaceColumnsDeltaCommand

Signed-off-by: Andrew Vine<EMAIL_ADDRESS>Description
Remove unused class AlterTableReplaceColumnsDeltaCommand
Resolves #1189

LGTM, @andrewvine Could you please amend the commit with correct email id? Currently the commit has a private email<EMAIL_ADDRESS>This is against Linux Foundation guidelines.

LGTM, @andrewvine Could you please amend the commit with correct email id? Currently the commit has a private email<EMAIL_ADDRESS>This is against Linux Foundation guidelines.

Thanks. Are contributors still required to sign their commit?... If so what should the email be?
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md#sign-your-work


I test the new version but...

@martinfekete10
I tested and i totally!!! love it! i found a bug tho! when i select hidden or app icon at menu bar icon the sonf info details shrinks and moves even if i use 300 pixels at song info width, the only way to fix this and stay unmoved is to use album art at menu bar icon.
The show song info I menu bar whe it's on when playing keep showing up open Apple Music when not supposed to, needs to be hidden. The workaround I use is the pause the Apple Music and quit it then it stays hidden, if I quit Apple Music without pause stays at menu open and says open Apple Music.
can you check this behaviour if you have time? beside that works great and the app feels smoother! thank you for you work!

Thanks for reporting, found a root cause and will release a new version soon

Thanks for reporting, found a root cause and will release a new version soon

You are the best!!!!!!!!!

New version was just released 🎉

New version was just released 🎉

Hellyeah!!! I will test it soon as I get home! And I will report if I find any other issue!

@martinfekete10
I test the new version and works!
The only issue I have is when I quit Apple Music the menu show a text open Apple Music.
When I pause the Apple Music and the quit the message stays hidden.
Can you fix that too please?


Update README

This change along with other code documentation should be done before the 1.0.0 release


Feature request: support for FORECAST_TWICE_DAILY

Some weather integrations to not use FORECAST_DAILY but rather FORECAST_TWICE_DAILY and/or FORECAST_HOURLY.  In my case NWS does not support FORECAST_DAILY.

This has been added to the dev branch and will be included in the 1.9.0 release.
Once released and updated, you can set it to use the twice daily forecast by setting the weather.useTwiceDaily option to true.


Compatibility issues with jQuery 3+ and jQuery UI prior to ver 12.0

Hello. I am getting this error on colsole when clicking on pulldown menu on RailsAdmin. The pulldown items are rendered but in the wrong place out of the default scope of the window.
Uncaught TypeError: elem.getClientRects is not a function

I believe this is due to incompatibility between jQuery 3+ and jQuery UI prior to version 12.0. RailsAdmin is dependent on jquery-ui-rails (~> 5.0), and the latest 5.0.x is bundled with jQuery UI 1.11.4.
The details of this compatibility issue is described here.

+1 I'm getting this same error on Chrome


Mac os platform

Added Support For Mac OS Platform
linked zmq library

Closes #30

@enwi @wajahat414, will this be merged?

This branch needs to be rebased and I need to still test it 😅


Change the Style and Behavior of the Table Collapsible Button

Proposed Changes
Multiple rows can be opened at the same time (easier to compare)
Clicking on the row selects it but doesn't open it
Clicking on the collapse button doesn't select the row but toggle its collapsed state
Opened rows doesn't have a different background anymore
Potential Breaking Changes
Different behavior but usage stays the same
Acceptance Criteria

[x] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[x] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1352 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1352      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%
=========================================
  Files         370     370
  Lines        9233    9242       +9
  Branches     2235    2233       -2
=========================================
+ Hits         9178    9187       +9
  Misses         55      55

Impacted Files
Coverage Δ

...r/src/components/collapsible/CollapsibleToggle.tsx
100% <100%> (ø)
:arrow_up:

...por/src/components/table-hoc/TableRowConnected.tsx
98.79% <100%> (+0.06%)
:arrow_up:

.../components/table-hoc/reducers/TableRowReducers.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cb313...43446ae. Read the comment docs.

There is some background color glitch on the collapsible toggle.

There is some background color glitch on the collapsible toggle.

@gdostie you mean the white background? It's expected, we want to clearly show that it's a clickable button


Update client-go to v1.18.4

Update to use client-go v1.18.4. This is needed such that we can include it in the e2e tests for https://github.com/zalando-incubator/kubernetes-on-aws/pull/3281

@mikkeloscar we discussed this internally, but had no decision yet, right?
I am fine if we don't break the e2e test for the current v1.17 :)

I am fine if we don't break the e2e test for the current v1.17 :)

Yes, it will NOT break of v1.17 tests :)

:+1:


addPoint is not working

Whenever I call addPoint, I get an error stating 'this.drawChartDebounced is not a function'
Looking through the code, it looks like your function is actually called _drawChartDebounced
Can you please fix this

Fixed in v1.4.6.


Gitignore public-cypress folder

Description

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

[ ] The developer has manually tested the changes and verified that the changes work
[ ] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

I inadvertently created this PR under the mistaken assumption that Cypress had been added to the incubation. Please ignore this.