KAFKA-15608: Assign lastet leader eopch and offset checkpoint to future log when replacing current log

Recently, I encountered a issue that there was always 1 partition having only 1 ISR (no produce traffic on this topic). The bug is related to altering log dir. When replacing current log with future log, broker doesn't copy the leader epoch checkpoint cache, which records the current leader epoch and log start offset. The cache for each partition is updated only when appending new messages or becoming leader. If there is no traffic and the replica is already the leader, the cache will not be updated any more. However, the partition leader will fetch its leader epoch from the cache and compare with the leader epoch sent by follower when handling fetch request. If the former one is missed or less than the latter one, the leader will interrupt the process and return an OffsetOutOfRangeException to follower. The follower might be out of sync over time.
Take the following case as an example, all the key points are listed in chronological order:

Reassigner submitted a partition reassignment for partition foo-1.

{
    "topic": "foo",
    "partition": 1,
    "replicas": [
      5002,
      3003,
      4001
    ],
    "logDirs": [
      "\\data\\kafka-logs-1",
      "any",
      "any"
    ]
  }

Reassignment completed immediately due to there is no traffic on this topic.
Controller sent LeaderAndISR requests to all the replicas.
Newly added replica 5002 became the new leader and the current log updated the leader epoch offset cache. Replica 5002 successfully handled the LeaderAndISR request.
Altering log dir completed and the newly updated current log didn't have leader epoch offset information.
Replica 5002 handled fetch requests (include fetch offset and current leader epoch) from followers and returned OffsetOutOfRangeException due to leader epoch offset cache hadn't been updated. So, the replica 5002 couldn't update the fetch state for each follower and reported ISRShrink later. The followers 3003 and 4001 would repeatedly print the following log:

WARN [ReplicaFetcher replicaId=4001, leaderId=5002, fetcherId=2] Reset fetch offset for partition foo-1 from 231196 to current leader's start offset 231196 (kafka.server.ReplicaFetcherThread)
INFO [ReplicaFetcher replicaId=4001, leaderId=5002, fetcherId=2] Current offset 231196 for partition foo-1 is out of range, which typically implies a leader change. Reset fetch offset to 231196 (kafka.server.ReplicaFetcherThread)

This issue arises only when all the three conditions are met:

No produce traffic on the partition.
Newly added replica become new leader.
LeaderAndISR request is handled successfully before altering log dir completed.

Kindly ping @hudeqi

I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current isr is [2,0,1], I will submit a reassign, and the isr is [2,0,1] , 2 of which logdir changes. Finally execute reassign. Please confirm whether my testing process is different from yours? Thanks @drawxy

I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current isr is [2,0,1], I will submit a reassign, and the isr is [2,0,1] , 2 of which logdir changes. Finally execute reassign. Please confirm whether my testing process is different from yours? Thanks @drawxy

I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current isr is [2,0,1], I will submit a reassign, and the isr is [2,0,1] , 2 of which logdir changes. Finally execute reassign. Please confirm whether my testing process is different from yours? Thanks @drawxy

Hi @hudeqi, in your test, the replica 2 already was the leader and it aleady kept the fetch state of the other followers. And the ISR set wouldn't shrink without produce traffic due to there was no lag from leader and follower (the leader replica 2 was aware of the log end offset of other followers). For example, 1. you can create a topic with 1 partition and the assignment list is [0,1] (make replica 0 to be the leader); 2. produce some messages to the partition and stop; 3. submit a partition reassignment [2,1]; 4. submit a log dir alter for replica 2. After that, you can see the log file is fullly filled.
Btw, I close this PR by mistakes, could you help to reactive it, thanks!

I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current isr is [2,0,1], I will submit a reassign, and the isr is [2,0,1] , 2 of which logdir changes. Finally execute reassign. Please confirm whether my testing process is different from yours? Thanks @drawxy

Hi @hudeqi, in your test, the replica 2 already was the leader and it aleady kept the fetch state of the other followers. And the ISR set wouldn't shrink without produce traffic due to there was no lag from leader and follower (the leader replica 2 was aware of the log end offset of other followers). For example, 1. you can create a topic with 1 partition and the assignment list is [0,1] (make replica 0 to be the leader); 2. produce some messages to the partition and stop; 3. submit a partition reassignment [2,1]; 4. submit a log dir alter for replica 2. After that, you can see the log file is fullly filled.
Btw, I close this PR by mistakes, could you help to reactive it, thanks!

Can you pull the latest trunk branch and reproduce it? The relevant logs you mentioned have been modified on the latest trunk. And I tested it multiple times based on the steps you gave based on the trunk branch, and everything seems to be normal.

I tested this process on the latest trunk branch and it did not reproduce. My process is: create a topic with 1 partition, then write traffic and stop writing. For example, the current isr is [2,0,1], I will submit a reassign, and the isr is [2,0,1] , 2 of which logdir changes. Finally execute reassign. Please confirm whether my testing process is different from yours? Thanks @drawxy

Hi @hudeqi, in your test, the replica 2 already was the leader and it aleady kept the fetch state of the other followers. And the ISR set wouldn't shrink without produce traffic due to there was no lag from leader and follower (the leader replica 2 was aware of the log end offset of other followers). For example, 1. you can create a topic with 1 partition and the assignment list is [0,1] (make replica 0 to be the leader); 2. produce some messages to the partition and stop; 3. submit a partition reassignment [2,1]; 4. submit a log dir alter for replica 2. After that, you can see the log file is fullly filled.
Btw, I close this PR by mistakes, could you help to reactive it, thanks!

Can you pull the latest trunk branch and reproduce it? The relevant logs you mentioned have been modified on the latest trunk. And I tested it multiple times based on the steps you gave based on the trunk branch, and everything seems to be normal.

Thanks for your verification, @hudeqi ! I found this issue on Kafka version 3.1 and didn't find the solution from Internet. I will try to reproduce it with latest trunk branch.


PatternAnalyzer and PatternTokenizer should accept an array of RegexFlags

Because it's expected that multiple RegexFlags may be used in PatternAnalyzer and PatternTokenizer, the flags property should be an array of RegexFlags that de/serialize as a |-delimited string.

Why was this closed? Did you fix it with a PR? Please link them.

https://github.com/Azure/azure-sdk-for-java/commit/55d9fa87fac5052b6012dcce1b5d972d952dec22

https://github.com/Azure/azure-sdk-for-java/pull/9203


R6S insta-crashes upon splash screen load

Title.
Steps to reproduce:

Launch cmd.exe as sysadmin
Initiate command splendid_implater.exe yourfile.dll R6Game
Game loads, console shows .dll inject and exits.
Game crashes when it gets to splash screen (e.g. 'Press Any Button')

Fixed.


Remove deprecated error codes. Some still remain - question asked in …

Signed-off-by: TRodziewicz<EMAIL_ADDRESS>Description
Remove deprecated error codes, which can be found using `git grep -i 'MBEDTLS_ERR.*deprecated'.
Fixes: #4283
Status
IN DEVELOPMENT
Requires Backporting
NO
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog updated

Question about this task has been asked in the originating issue: https://github.com/ARMmbed/mbedtls/issues/4283#issuecomment-818232901


selfhost: Add is None operator

First step towards being able to doing is checks on optionals as if they were enums.

Welp looking at the errors I realize I made a mistake. This breaks naming variants in your own enum None and is'ing on them.

I'm done with isSome as well 🎉 I did it optimistically on top of this branch, so we can either merge this one, and I follow it up with an isSome PR or I can push here - whatever you prefer.

In the future, please squash fixups into the relevant preceding commit instead of adding them as new commit :)


Always sets automaticRestart to false in dev_appserver.

Removes that setting from the UI too.
Fixes #972

@joaoandremartins seems like the new version of the library is not released yet.

@patflynn yep, I'm in the process of releasing it for the first time, but being caught up in a bunch of micro stuff

Can you also add a note to the release notes? This should be the main thing the user is aware of being fixed when they update.

Yes, I'll do so in this PR.

Actually, just noticed this isn't done in a PR.
Added the following to the 16.10.4 release notes:
Fixed issue with debug session being aborted when HotSwap occurs. (#1027)

Current coverage is 25.00% (diff: 0.00%)

No coverage report found for master at 959be24.

Powered by Codecov. Last update 959be24...105d486


Add a breadth-first search algorithm over any tree

Description
Adds a breadth-first search algorithm that can be applied to any tree structure. This is useful for traversing tree data structures that appear all over our apps, like the hierarchies for views, layers, view controllers, windows, and more.
Detailed Design
Traverse a tree in breadth-first order by providing the root of the tree, and a closure that returns the children of a given node.
let tree = Node(element: 1, children: [
	Node(element: 2, children: [
		Node(element: 5, children: [
			Node(element: 9),
			Node(element: 10),
		]),
		Node(element: 6),
	]),
	Node(element: 3, children: [
	]),
	Node(element: 4, children: [
		Node(element: 7, children: [
			Node(element: 11),
			Node(element: 12),
		]),
		Node(element: 8),
	]),
])

let elements = BreadthFirstTreeSequence(root: tree, children: { $0.children })
// Array(elements) == [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]

Open Questions

[ ] API Design and Future Considerations
I’d like to consider how other tree traversal algorithms—namely depth-first search—would work and see how that may influence the API and implementation. Would there be shared code between the two?

[ ] Naming
The majority of the additions in swift-algorithms are functions based on Sequences and Collections. Since there is no formal tree data structure in Swift, there isn’t really an existing structure to extend, thus the creation of a new structure. The structure represents a tree flattened into a sequence in breadth-first order. I think “breadth-first” should definitely be included in the name, although the term “search” doesn’t always apply. The sequence is great at searching, but it isn’t limited to that. You may want the breadth-first ordering of something without necessarily searching for one element in particular.

[ ] Documentation
I’d love to improve the documentation on how this works, particularly after the API settles down. I’m unsure how much depth to go into in how breadth-first search works as an algorithm versus assuming the reader is familiar with this well-known algorithm.

Documentation Plan

Added BreadthFirstSearch.md
Added BreadthFirstTreeSequence to README.md
Added inline documentation to implementation and unit tests

Test Plan
Adds many unit tests for:

Empty tree
Simple tree
Complex tree
The number of times a closure is called during iteration of early termination algorithms, like first(where:)

Source Impact
This is purely additive.
Checklist

[x] I've added at least one test that validates that my change is working, if appropriate
[x] I've followed the code style of the rest of the project
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary

Thanks for opening this PR, @mdznr!
This is an area where we need some design exploration about how to express graphs before we get into algorithms like BFS. Is there a design for a Graph protocol that would enable this and other algorithms? We may want to think about how and whether we'd want to express weighted vs unweighted graphs, directionality, and other properties of a graph and its nodes.
To start out, we'll need to work up some example algorithms (like this one) and graph implementations (adjacency lists, generated graphs, etc) to find the right patterns before moving on to actual API.

In the announcement blog post we said:

The immediate focus of the package is to incubate a pragmatic set of algorithms generalized over the Sequence and Collection family of protocols for eventual inclusion in the Swift standard library

I think it's still too early for the Algorithms package to expand its focus to algorithms over non-linear data structures.


Nice and Non-conflicting Name for Vagrant VM

When vagrant up is run and the VM is provisioned, the VM shall receive a nice nickname such as fcc-vm-1. This is to make it much easier to search the box inside vagrant global-status and delete it by name instead of a hash code.
There should be no conflict of names when multiple environments are setup. If there are more than one VM on the same local machine, then change the name of the VM subsequently using a numbering or sequence system. The system is yet to be determined but should be automatic.

@alayek I think we should put this for the next release and not this one. What do you think?

This is a nice feature but not important. We may leave it to later.

And the name shoudl be fcc-box-- or fcc--box- or whatever with the language in addition to a number

I think box is redundant, how about just fcc--, where number will distinguish multiple instances of zeus vm. Let's call multiple sessions instances. So if you launch vagrant with zeus, then you create an instance of a zeus vm or something like that just for our jargon...


Add support for 2018 edition crate renaming

Parse cookies = { package = "cookies_rs", version = "0.1" } as being
the cookies_rs crate, version 0.1 instead of looking for the cookies
crate.
Fixes #32

Tests would be fixed by #31

Hi there, thank you for your PR!
The project is now in the process of becoming maintained again. Parts of #44 solved the issue you addressed with your Pull Request, so I will close this. Thank you nonetheless for your input! If you want, we'll be happy to welcome you as contributor to the project. Just give us a heads up at #40!


Fix rho feature for 2DAR documentation

See issue #249.

Advise not to use rho with 2DAR as it's not properly implemented
Remove rho parameter lines from example tables

Thanks.  Can we say "not implemented", rather than "incorrectly"


Schreyer Reports

Good morning- In the reports we can generate from EHT, there is a field for Advisor Name but no field for Thesis Supervisor.  Could you add that as a field that's reported in the CSV file? That would let us skip the very cumbersome step of cross-referencing our internal (and sometimes dated) records when we make the graduation program.
Thanks-
Richard Stoller

Would it be easier to list out all the committee members with their role in the report?

I think that might be too much.


Pg/dynamic regularization

Adds dynamic regularization functionality.
Adds functionality to allow in-place modifications to matrix entries in their post-ordered positions.
Modifies update_diagonal! so that it does not refactor on its own. Now requires a subsequent call to refactor!.

Note to @migarstka : the change here to update_diagonal! may be breaking for COSMO since the current version has an automatic forced call to refactor!.   I have removed this since it may be useful on occasion to make multiple modifying calls to the entries of a matrix before refactoring, so refactor! is best called once by the user once all modifications are in place.
TL;DR : I think this will necessitate call to refactor! here.

Codecov Report

Merging #6 (6bb6bf4) into master (500d0bd) will decrease coverage by 4.68%.
The diff coverage is 76.27%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   95.77%   91.09%   -4.69%
==========================================
  Files           1        1
  Lines         213      247      +34
==========================================
+ Hits          204      225      +21
- Misses          9       22      +13

Impacted Files
Coverage Δ

src/QDLDL.jl
91.09% <76.27%> (-4.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500d0bd...6bb6bf4. Read the comment docs.


feature(integrationDetailHistoryListView)

Opening this as a WIP/Draft Pull Request as I have some questions before I make this ready for review. Will also try to add the other sections of the Details tab if possible.
Changes:

Add IntegrationDetailHistoryListView component and story.
The history section, slightly confusingly, includes a row for Draft options, and then a series of rows for History items, see this example in staging. So, I have moved the Draft row of options to this here List View component and story (from the List View Item), as it made it easier to work with the data.

Questions:

Is it possible to extract data for stories that would like to reference the same data item? For example, some integration properties (e.g. version, updatedAt) are used in multiple integration detail-related stories, so at the moment I just copy and paste them into each story.

More questions to come.. ;P

Is it possible to extract data for stories that would like to reference the same data item? For example, some integration properties (e.g. version, updatedAt) are used in multiple integration detail-related stories, so at the moment I just copy and paste them into each story.

sure, we could add a data folder inside the stories one where commonly used data can just be placed in ready to be used.

sure, we could add a data folder inside the stories one where commonly used data can just be placed in ready to be used.

Cool! I can do that in this PR or a separate one and create an issue for it, depending what you'd prefer. Let me know.

Getting incredibly annoyed with the space above the first list item, this didn't seem to be happening when I had this in the full detail page. I could use CSS to remove the margin-top, but probably not worth it, going to see if I can make any minor changes that would help.


Replace consistency check with routine for checking traces

In #388, we found that consistency check was no longer necessary due to the changes of #383. Currently, consistency check won't run do to the adherence to the invariant that EVCs with a current_path are considered active. Due to this Consistency check as it currently exists is unnecessary. What we should consider doing now is replacing it with a routine that will periodically check the traces on EVCs to ensure they are active. It is possible, though unlikely that mef_eline may produce a bad flow, and that flow would need to be removed. If we periodically check trace the flows, we can detect these issues, and fix them.

Additionally #438 Is now deferring the the sync operation from link down events, so it is possible that an EVC may be in an inconsistent state after a restart. In this case running a trace would be helpful for identifying the inconsistency.

@viniarck Here's what I'm thinking about doing with consistency check:
This is a general guide on how consistency should be maintained within kytos, with EVCs as an example of a potential implementation. This guide is missing details on what to do when the system is in an inconsistent state.
First ensure that the expected sub-components exist, are consistent, and that no unexpected sub-components exist. To check for unexpected sub-components, this will require a reference back to the parent object. After the sub components have all been verified, the functionality of the parent object needs to be validated.
To perform consistency checks with EVCs, the following must be done:

Get the list of all flows owned by the EVC on flow manager.
Confirm that the list of flows matches the list expected by the EVC.
If flows are missing, deploy them.
If additional flows exist, remove them.
If any modifications have been made, do not proceed, wait until next consistency check cycle to restart this process.
If no flow modifications have been made, run a sdntrace/sdntrace_cp on the flow to validate its functionality.

@Ktmi, good start; This deserves to also highlight all the existing problems and what will be enhanced such as performing on active EVCs, just so these problems can be confirmed they've been solved. I'll wait for you to document that and then clarify how that gets solved, and let's turn this into a blueprint doc since a major part of it it's application networking related, in the meantime, here are a few points for you to think about:

Consistency check should be configurable an run periodically, initially enabled by default like flow manager does. Maybe only on settings is sufficient for now?
No false positives when consistency is making a decision and performing a side effect. Should consistency acquire each evc.lock when running the consistency? Certainly, only considering an EVC if it hasn't recent changed flows will be key, but let's also ensure that  preemption wouldn't impact on this process if consistency starts making a side effect and then other mef_eline handlers or API concurrently do it too. Good thing that eventually, it should stabilize, but let's try to minimize potential false positives or conflicting concurrent operations. On flow_manager's consistency this ended up slightly simpler due to the fact that the compared switches FlowStats flows don't change mid execution until a next iteration (but here a new mef_eline concurrent operation can change the expected flows can you'd be comparing against).
sdntrace_cp has been prefered over sdntrace for consistency checks related (which also minimizes network latency packet-in/outs), sdntrace has its advantages checking the data plane too, but network engineers have asked before to use sdntrace_cp, and then sdntrace they typically only use it on demand when they need. Also, notice that when running sdntrace_cp currently it's getting all installed flows, we might need a way to also parametrize to run sdntrace_cp passing the stored flows upfront, meaning the flows that you've considered as stable (or not recent changed). Here coordinating the concurrency will be key too, ideally doing in bulk.
If the expected flows are there, but sdntrace_cp trace doesn't suceed will it do? Is it always going to redeploy?
Flow queries should minimize DB round trip, querying with cookie ranges and installed flow state
Let's take the opportunity to also reasses and clean up left overs from the prior consistency check. We can probably also nuke @listen_to('kytos/flow_manager.flow.removed'), since querying flows won't be that frequent, and querying for a range of cookies can also save some DB round trips.
Will it need to ignore certain flows? On flow_manager consistency check it can ignore by cookie ranges and/or table ranges. At the moment, I don't see conflicts here, but as you were discussing with @italovalcy, if any other NApps change mef_eline flows this will be a problem. Now the question is should other NApps change other NApps flows? The only coordinated way we have this is how of_multi_table does, but it also lets the NApps know that it's table has been updated (so it's not behind their backs). Mirroring could do something similar publishing to mef_eline new flows to be aware, but once it also starts changing flows especially when/if adding new higher priority ones, it can also slows down network convergence depending where it's located at, so developers need to be aware of this. This is something to briefly document in the blueprint, and when newer NApps will be implemented (or even think if a new NApp is also needed) then it can be refined, it's probably not a problem to be solved by our team for now, but whoever will develop or contribute needs to understand and be aware of existing design choices and compromises.


[TB] Fix CodeQL scan findings

Problem/Concern
It looks like there are issues being reported by CodeQL in GitHub (https://github.com/finos/a11y-theme-builder/security/code-scanning) that we need to investigate and resolve.  The high severity ones seem to suggest that we should be using rate-limiting middleware to prevent filesystem requests triggered by APIs to possibly cause a denial of service if they are triggered too frequently.
Maybe not a huge issue since Netlify is just serving our static urls so it won't affect those deployments, but may/will affect anyone deploying the code using Docker, etc.
Proposed Solution

Hello @aaronreed708, Taking into consideration how this might affect UI/UX, I would a dynamic rate limiter(IP based) middleware in express that only applies to requests that are not from the same origin. This approach will involve setting environment variables(Default values can be specified in main program). A Fixed Window Counter with Retries(Exponentially backed off) should be okay for the rate limiter. Also there will be a need to include a Retry-After header in response

Hi @eliblurrtt, your approach sounds good.  Is this what you are looking to use?  https://www.npmjs.com/package/express-rate-limit.  I saw a couple of tutorials online showing how to use it.  Or do you have a different one in mind?  How do you propose to test it?

A contributor in today's call suggested that maybe this is better handled by the entities deploying theme builder to do the rate limiting.

Hello @aaronreed708 - I'd like to take a look at this but do not have access to this link:  https://github.com/finos/a11y-theme-builder/security/code-scanning - can you help?

@PaulaPaul @TheJuanAndOnly99 has asked us to use<EMAIL_ADDRESS>for access requests. Please try that avenue and let me know if that runs into an issue.


responses without Content-Length always close the connection

WSGIRequestHandler from werkzeug.serving has the following lines of code:
https://github.com/pallets/werkzeug/blob/2f5268966428fcfdc76d2311864a7c43cf826c93/werkzeug/serving.py#L171-L173
Basically, when writing out any response, if the Content-Length header is missing, the request handler forcibly closes the connection.  There are several valid types of HTTP/1.1 responses that don't have to and often should not include a Content-Length header, but where it's unnecessarily wasteful to tear down the connection afterwards.
Section 3.3.3 of the HTTP/1.1 RFC describes the process for determining the message length and lists these cases where Content-Length isn't needed or considered.
Specifically for Werkzeug, some relevant ones that could come up are:

HEAD request responses
204 NO CONTENT responses
304 NOT MODIFIED responses
Responses using Transfer-Encoding

Note that for 304 responses, Werkzeug's standard get_wsgi_headers() implementation will actually strip out an existing Content-Length header, making the out-of-box behavior that 304 responses always terminate the connection: https://github.com/pallets/werkzeug/blob/9f294937fe8c5cd1fe2d5ca04375dca82aad098a/werkzeug/wrappers.py#L1245-L1246
Section 4.1 of the HTTP/1.1 Conditional Requests RFC implies that you SHOULD NOT include a Content-Length header with a 304 unless you're trying to prompt the browser to update cached metadata (which makes no sense in the case of Content-Length, really), so I think get_wsgi_headers() is showing reasonable behavior here.
A fix to this would be either to make WSGIRequestHandler smarter about when it forcibly closes the connection, or to put that behavior behind some user-controllable setting (or Response variable) so that it can be disabled if it's generating many needlessly closed connections.

This only affects the development server which does not support keep-alive anyways so that's not really something we need to fix. However more important Transfer-Encoding is not supported by the werkzeug server going out and a WSGI app is not permitted to emit it.
This leaves the 204/304/HEAD requests which I'm not sure about how HTTP keepalives work with it. I would need to investigate this. But closing this issue anyways because the internal server is not intended for these cases anyways.


Pydantic Module Version

With the switch to Prefect 1 to 2, it appears this move has caused some issues in this module. The newer version of Prefect is now using Pydantic v2 and prefect-fivetran uses pydantic v1. This causes unexpected issues when trying to use prefect-fivetran in the new Prefect 2. Could the pydantic dependency in prefect-fivetran be bumped to v2?

I believe this is the cause of #15.

Try using this, it works for me for Pydantic v2. I'll open a PR for it, since it's so short.
https://github.com/japerry911/prefect-fivetran/tree/japerry911/imp/pydantic-2-compatible
I opened PR as well #17


MGDOBR-1211: Add BridgesAPIV2, ErrorsAPIV2 and CloudProviderAPIV2

Insert JIRA Issue number and update link
PR owner checklist
Please make sure that your PR meets the following requirements:

[ ] Your code is properly formatted according to this configuration.
Run mvn clean verify -DskipTests so that imports are correctly set.
[ ] Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-1] - $clear_explanation_of_what_you_did"
[ ] The layers in the kustomize folder have been updated accordingly.
[ ] All new functionality is tested
[ ] Pull Request title is properly formatted: MGDOBR-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

[ ] Check if code and Github action workflows have been modified and if the modification is safe
[ ] If the modification is safe, add the safe to test label

How to trigger pipelines and use the bots:

Run the end to end pipeline
Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

Rebase the pull request
Comment with: /rebase.

Deploy BOT
Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

BridgeResponseV2DTO` object name must follow PascalCase.

So... BridgeResponseVTwoDTO is is then :rofl:

@r00ta If you want to see a green PR you need to do the following:

Push r00ta:MGDOBR-1211-2 to 5733d9e2be6485d52ffa08870cabdee0:MGDOBR-1211-2
Add a new commit to 5733d9e2be6485d52ffa08870cabdee0:MGDOBR-1211-2 updating the CI scripts to use branch MGDOBR-1211-2
Create a new "mock" PR (modifying a pom.xml adding a blank line/comment etc) targeting 5733d9e2be6485d52ffa08870cabdee0:MGDOBR-1211-2.

The "mock" PR will build 5733d9e2be6485d52ffa08870cabdee0:MGDOBR-1211-2 containing your code changes for MGDOBR-1211-2 with the corrected CI configuration (to build branch MGDOBR-1211-2). When green; this PR can be merged and the "mock" one deleted.
See #1308 and #1309 as an example.

tested green here https://github.com/5733d9e2be6485d52ffa08870cabdee0/sandbox/pull/1322


x/blog: freenet

Please rewrite a https://freenetproject.org library to go.
java is very dificult and unsecurity platform. Many people dont use java for security project.

This does not appear to be in scope for the Go project, see also https://golang.org/doc/faq#x_in_std


Fixed validation of settings for mutally exclusive credentials

This fixes the validation of settings to account for the service account and client credentials being mutually exclusive.

What does src/mitol/google_sheets_refunds/py.typed do?

It's a marker file that informs the packaging system the package has typings that it should export.


admin_email is required

Hi,
maybe you should include the admin_email in the example, because its mandatory.

@dyipon You are right. Fixed in https://github.com/FoxyRoles/ansible-dkim/commit/8eaab4f043957f3e5888776047bd668972d92327


Fill in BitMap class ref.

This fills in the following for the BitMap class:

Brief description
Description
All method descriptions

Indentation issues. Please rebase and use tabs to indent.

It was actually superseded by #11139. Feel free to make a PR with improvements to the current status if this PR had some better docs.


ENOENT: no such file or directory when rename dir on TypescriptRenameFile

When I want to move the file to the new dir (rename the path with non-existent folder)  I get ENOENT: no such file or directory. Is there any way to fix that?
For now I have to create the proper dir before running :TypescriptRenameFile

We could theoretically handle this by changing the code so that it gets the parent directory of the new file and runs mkdir on it. PR welcome!

Rather new option but should make it easier: https://github.com/neovim/neovim/pull/20835

Would this be as simple as adding a :!mkdir -p <parent_of_filename> before sending the rename executeCommand? Do we care if the server denies the rename and we are left with extra dirs?


Add std.math.quantize() for rounding to a multiple of some number.

This is a generalization of @jamadagni 's PR #3759 . Changes:

I flipped the sign for prec / exp.
Very large and very small values are handled correctly.
NaN and infinities are handled correctly.
The base is now a parameter; it is not locked to 10 any more.
The rounding function is a parameter, to allow reusing the same logic with floor(), ceil(), and nearbyint(). It defaults to rint(), since that seems to be the fastest method which respects the current rounding mode.
A couple of overloads were added to allow optimizations when the base (and possibly exp) are known at compile time. In particular, I wanted to use ldexp() to speed up the case where base is a power of two. This is not currently implemented though, because so much of std.math doesn't work at CTFE yet.

:grimacing: snapto :grimacing:
I wouldn't like to come just to bikshed but seriously this function is called quantize everywhere. :

@BBasile Updated: snapto -> quantize

I flipped the sign for prec / exp.

Is it a prevalent convention? What other languages/systems do?

Name addition cc @andralex , also needs a changelog entry

@DmitryOlshansky

I flipped the sign for prec / exp.

Is it a prevalent convention? What other languages/systems do?

I don't know. BBasile is the one who said this function is called quantize "everywhere", not me. @BBasile , could you give us some links to the docs for quantize() in some other libraries, for comparison purposes?
The only examples I've found so far:

Python has a quantize() function whose first parameter serves as a sort of pattern for the output; it is most similar to the first overload in this PR, which does not have a separate exp parameter.
.NET has a round() overload which takes the number of fractional decimal places to round to as a positive integer. I don't think its a good example to follow though, since it doesn't accept negative "place numbers" at all; it just throws an exception.

Neither of those is really the same as this PR anyway, because they both seem to be locked to base 10.

Updated to accept any floating-point type.

I added a changelog entry.

If std.math.isPowerOf2 is pulled first, I can implement my planned optimizations for power-of-two bases: https://github.com/dlang/phobos/pull/4327

Rebased.

Ping @andralex .

Ping @andralex .

@andralex is hard to reach via Github - just ping him shortly via mail ;-)

alrighty then

thx!

Auto-merge toggled on


Adding tests for addon health

A draft PR for testing addon health

/ok-to-test

@Ankit152 thanks a lot for working on this! This PR looks great to me.
Would you mind squashing the commits into one before we merge it? Thanks :)

/lgtm

/approve
/lgtm


tf.cond within vectorized_map results in unknown output shape

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Colab version
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): Colab version
TensorFlow version (use command below): v2.4.1-0-g85c8b2a817f 2.4.1
Python version: Colab version
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: NA

Describe the current behavior
When using tf.cond from within tf.vectorized_map, the output shape is lost and the result has a None batch shape. This results in memory exploding at backpropagation time.
Describe the expected behavior
The output shape should be retained when the shapes of the two possible cond outputs are the same.
Standalone code to reproduce the issue
https://colab.research.google.com/drive/1ydXdSe0_jJqtJLYGXgkCxywjC9gFANwv?usp=sharing

@AdrienCorenflos
If you comment @tf.function then the code works as expected. Please, find the gist here.Is there any particular reason that you want to use @tf.function.
Thanks!

Hi,
I probably should have mentioned that this only happened within a tf.function indeed.
This code is actually a (very) simplified version of my original code (akin to this one), it needs to be compiled for speed reasons.
Adrien

Was able to reproduce the issue in TF v2.5,please find the gist here..Thanks !

To perform the tf.cond operation inside graph mode you need to follow excecution of OPS in a Tensorflow graph flow. Refer this answer for more details.


Make systemd logs persistent

in /etc/systemd/journald.conf add:
[Journal]
Storage=persistent
...

@eskombro can you precise your issue please? :)
How can we solve it?

The idea was to make a configuration in which MeiliSearch logs would be stored in a log file instead of being printed to the console. I don't know if this is something that can be considered to make it easy to access to logs.


solarus[-quest-editor]: 1.4.5 -> 1.5.3

Motivation for this change
#45960 has solarus-quest-editor failing.
This is (with at least another failure) fallout from Qt 5.10 -> 5.11 from June.
The update may not be strictly necessary to fix the issue, but:

It needed to be updated.
It allows using patches from upstream.

It'll need cherry-picking to release-18.09
Things done

✔ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

✔ NixOS
⬜ macOS
⬜ other Linux distributions

⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
⬜ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
🌶 Tested execution of all binary files (usually in ./result/bin/)
⬜ Determined the impact on package closure size (by running nix path-info -S before and after)
✔ Fits CONTRIBUTING.md.

#44047 stops me from testing this :/.

Success on aarch64-linux (full log)
Attempted: solarus, solarus-quest-editor
Partial log (click to expand)
-- Installing: /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3/share/applications/solarus-quest-editor.desktop
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3
shrinking /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3/bin/solarus-quest-editor
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3/bin
patching script interpreter paths in /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3
checking for references to /build in /nix/store/aimy6s9qzn7hfmj0fxkq7fikphqz25kn-solarus-quest-editor-1.5.3...
postPatchMkspecs

backport: 508608d5726 and dd1afaab7d7


lottie-android 1.5 support in react native?

I was really excited to hear that pre-compositions and images are now supported in the last version of Lottie for Android.
However, introducing the new update (1.5.2) through both my app's build.gradle or the lottie-react-native build.gradle in node_modules leads to a null object exception in the parseLayers method of LottieComposition.java
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int org.json.JSONArray.length()' on a null object reference                                                                      at com.airbnb.lottie.LottieComposition$Factory.parseLayers(LottieComposition.java:200)                                                                      at com.airbnb.lottie.LottieComposition$Factory.fromJsonSync(LottieComposition.java:194)
I tried the new update with my animations in a pure Android app and it works totally fine.
Is this error due to lottie-react-native being behind lottie-android? When do you think an update will come? Or am I doing something wrong?

Would also like to know when the RN version is going to catch up with native Lotties :-)
Is there something blocking the upgrade or just a lot of work?

I would also like to know the status of this upgrade. Not using precomps or image layers while still integrating this preferable animation solution would require my designers to redo their work without those features, which I'd rather not have them do

@lelandrichardson any comment? :-)

I debugged this a bit and seems like lottie-react-native is somehow bugged. It doesn't pass correct JSON data to lottie-android which results jsonLayers always to be null.

As you can see in the screenshot, jsonLayers is null. You can also see method argument json is ReadableNativeMap. It should be JSONObject as shown in the screenshot below which is taken from lottie-android LottieAndroid example app.

Ok, seems like <Animation source={require(...)} /> is bugged when bumping the version manually.
So <Animation source="asset-filename.json" /> works in lottie-react-native when using compile 'com.airbnb.android:lottie:1.5.3' (tested only in Android, dunno about iOS).

@jdpigeon did you have your JSON file in app/src/main/assets/ folder?

Of course! Moved my jsons there and It works now
I guess your workaround sneakily avoids lottie-react-native processing the JSON before it gets to the android library. It definitely makes sense in that case to store the app in the Android source.
Hopefully we've identified some issues that can be fixed for everybody in an upcoming update :slightly_smiling_face:

Note: image support through lottie-react-native with this workaround is probably still impossible because it's impossible to call the setImageAssetsFolder function that the android library requires.


Fix release message promote-assembly

The first parameter of sendReleaseCompleteMessage is a dict.
This issue will also be fixed by https://github.com/openshift/aos-cd-jobs/pull/2894


[BUG] Accessibility: Admiralty Logo fails WCAG 1.1.1, 2.5.3

Describe the bug
The ALT description for the Admiralty logo is currently "Admiralty Stacked Logo" which does not sufficiently describe its purpose or include all the text visible in the image.
Expected behavior
My thoughts are the preferred solution would be to change the Admiralty Logo and UK Hydrographic Office Logo to be link elements with either 'Admiralty Maritime Data Solutions' or 'UK Hydrographic Office' as its text. They can be styled to look as they currently do with CSS and any icons being an SVG element that's non-focusable.
But at a minimum to pass WCAG the ALT text for the Admiralty logo will need to be change to 'Admiralty Maritime Data Solutions | UK Hydrographic Office'. As there are multiple links to the same destination on a page, Admiralty Logo in the header and UK Hydrographic Office Logo in footer they should have the same description.
Screenshots

Additional context
Level A 1.1.1 - All non-text content that is presented to the user has a text alternative that serves the equivalent purpose.
F30: Failure of Success Criterion 1.1.1 and 1.2.1 due to using text alternatives that are not alternatives (e.g., filenames or placeholder text)
Level A 2.5.3 - If the non-text content is an image of text, then the name contains the text that is presented visually.
F96: Failure due to the accessible name not containing the visible label text.

although we accept this is an issue, are hands are tied due to marketing constraints at this time

KP discussed with LT - this is just to change the ALT text so should not be an issue - if not we should escalate to Bruce as this is an accessibility requirement so something does need to change.

KP discussed with LT - this is just to change the ALT text so should not be an issue - if not we should escalate to Bruce as this is an accessibility requirement so something does need to change.

@KatiePUX what do we want the alt text to say?
Luke kindly suggested 'Admiralty Maritime Data Solutions' or 'UK Hydrographic Office'
Our Logo just says ADMIRALTY now. Should our alt text just say 'ADMIRALTY'?

I've just noticed:

Level A 2.5.3 - If the non-text content is an image of text, then the name contains the text that is presented visually.
F96: Failure due to the accessible name not containing the visible label text.

In Luke's message, guessing that means it must say ADMIRALTY then.

Yeah I agree with you, lets not complicate it - say what is seen! Shall we just confirm in the morning at SU?

Will have to be Tuesday for me @KatiePUX !


-Wundef - no default for OPENTHREAD_ENABLE_VENDOR_EXTENSION/OPENTHREAD_EXAMPLES_SIMULATION

Describe the bug
When using the -Wundef flag the following flags show up to have no default:

OPENTHREAD_ENABLE_VENDOR_EXTENSION
OPENTHREAD_EXAMPLES_SIMULATION
OPENTHREAD_CONFIG_PLATFORM_BOOTLOADER_MODE_ENABLE

Blocks using -Werror in a build + currently these flags need to be added as dummy 0 in a config .h
To Reproduce Information to reproduce the behavior, including:

Was added a very long time ago
IEEE 802.15.4 hardware platform - any
Build steps - normal build with none of the mentioned flags in the configuration header
Network topology - NA

Expected behavior
Build does not throw 'undefined' warning
Additional context
There is no default for  the mentioned flags defined in code. The define is only generated in CMake options - also no fallback there to 0. Adding a #if !defined construction as done for other config's in the common headers would fix this

Is it an option to enable this -Wundef by default with warnings as errors so these get fixed immediately when new flags are added?


Bash @ Win10 support

http://www.theverge.com/2016/3/30/11331014/microsoft-windows-linux-ubuntu-bash

Has anyone had any luck with this? It seems to be very, very nearly working in Bash on Ubuntu on Windows - the only issue is that when I select an item from the history it doesn't actually get executed / output to the command line. It feels like the kind of thing that might just need a config tweak or something to get it working...

@nickautomatic thank you for giving it a try! I didn't have a Windows machine, but I bought one to my family members recently. If I'm able to enable Ubuntu on Windows 10 edition it's there, then I will fix that. BTW, code used to insert a command to console (to be executed) is based on ioctl(0, TIOCSTI, &buf[i]); - see hstr_utils.c. I will check whether it works on Windows, and if not a conditional compilation w/ different Windows specific working code might be a solution.

@dvorka No problem! Thanks for the response.
Let me know if there's anything you'd like me to try. I have no experience of C, so probably can't help there, but am very happy to try things in Bash (change settings, etc) if there's anything more you'd like to know.

@nickautomatic I just want to let you know that I installed the program and reproduced the problem. I'm in the process of writing test(s) in order to find a working solution/workaround.

It might be that TIOCSTI is not supported, Windows ioctl() is used or Bash is not running in pseudo terminal... or something completely different - will see: https://github.com/Microsoft/BashOnWindows/issues/1863

I've built hstr with the Creators Update and I can confirm it's not supported yet, as confirmed by @threalkenc in the BashOnWindows issue discussion.
Anyway, I'm eager to see a fix from MS and will be happy to test with their Ubuntu 16.04 environment.

https://github.com/junegunn/fzf is able to add text to the terminal somehow.  It's a golang program, and I'm not sure what the runtime is doing.

@chappjc thank you for pointing out fzf - I will definitely check that!

See #164 which brought workaround for Cygwin where TIOCSTI is missing :-)

@dvorka The workaround from #164 could be adapted to not check for Cygwin using #ifdef __CYGWIN__ but instead check for TIOCSTI with #ifndef TIOCSTI. TIOCSTI is not defined on platforms where it is not implemented.

PR with possible fix here: https://github.com/dvorka/hstr/issues/217
But it needs to be tested under Windows 10 (I don't have a Win 10 machine):
git clone https://github.com/jmiserez/hstr
cd hstr
git checkout windows-fix
cd dist
./1-dist.sh
cd ..
./configure
make
make install
hh --show-configuration >> ~/.bashrc

Then open a new Bash and test it.

@jmiserez thank you for your experiments and summary - it helps! I tried a number of things to find a workaround, but I was not successful. I pretty sure that with #164 + my experiments results + your summary I will be able to deliver hh for WSL.

Stupid and ugly hack ideal: 1-dist.sh to check /proc  and create /tmp/hh-on-wsl file > configure.ac to check for hh-on-wsl existence using AC_CHECK_FILE (file, [action-if-found], [action-if-not-found]) and define AC_DEFINE([MICROSOFT_WSL], 1,[Define to enable WSL conditional compilation])

Unfortunately variable-based Cygwin workaround doesn't work for me on Win10:
         "\nfunction hstr_cygwin {"
         "\n  offset=${READLINE_POINT}"
         "\n  READLINE_POINT=0"
        "\n  { READLINE_LINE=$(</dev/tty hstr ${READLINE_LINE:0:offset} 2>&1 1>&$hstrout); } {hstrout}>&1"
         "\n  READLINE_POINT=${#READLINE_LINE}"
         "\n}"
         "\nif [[ $- =~ .*i.* ]]; then bind -x '\"\\C-r\": \"hstr_cygwin\"'; fi"

I will try temporary file version and debug the script command by command to find out where's the problem...

@dvorka Did you see that there is a typo in the temp-file based variant in the commit by @riedel? The last line should use READLINE_LINE not just READLINE.
I ran into that during testing, maybe check that?

@jmiserez Actually both variants work for me now - I forgot to add conditional compiled code in hstr_utils.c. Thank you for all the suggestions :wink:

@dvorka Did you see that there is a typo in the temp-file based variant in the commit by @riedel? The last line should use READLINE_LINE not just READLINE.
I ran into that during testing, but it should only affect the cursor position, not put the output above the current prompt. Both variants are not Cygwin specific and should work on any Bash prompt. The tempfile based variant only uses basic redirection features, and should really work...

thanks for tagging me XD i moves over and put all my homeassistant in synology dockers instead and now use a rasp. pi for hyperion. Really preciate the tagging :)

@dvorka Did you see that there is a typo in the temp-file based variant in the commit by @riedel? The last line should use READLINE_LINE not just READLINE.
I ran into that during testing, but it should only affect the cursor position, not put the output above the current prompt. Both variants are not Cygwin specific and should work on any Bash prompt. The tempfile based variant only uses basic redirection features, and should really work...

thanks for tagging me XD i moves over and put all my homeassistant in synology dockers instead and now use a rasp. pi for hyperion. Really preciate the tagging :)

This is really off-topic. I appreciate the sentiment, but it's odd tracking people down like this on an different Github issue. In the future consider replying on the original Github issue instead (https://github.com/cantino/mcfly/issues/25) or just email me.


Fix invalid jumps?

I get many of these invalid jumps in my jumplist. Not sure why?

Never mind, its good.


Add npm release script

I'm guessing my changing "postinstall" to "bootstrap" broke the build.  I'll put that back and see what happens.


Please update for Angular 8

Describe the bug
I'm getting this error while installing packages on my app that's recently been updated to Angular 8:

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^7.0.0 but none is installed. You must install peer dependencies yourself.

To Reproduce
Install current ngx-papaparse on a new or upgraded Angular 8 project

npm install ngx-papaparse --save

Expected behavior
No warnings or errors
Software and platform

OS: Windows 10
Browser: Chrome
Version: 74.0.3729.169
Angular version: 8.0.0 / 8.0.2
Angular CLI version: 8.0.3
Node version: 12.4.0

Thanks. I have just released version 3.0.3, which should solve this.

Thanks for the quick response! All set. Greatly appreciated :)


[PECO-832] Make e2e tests automatically discoverable to VSCode

This pull request makes life easier developing this repository in VSCode or any visual debugger:

Moves the staging ingestion tests into a separate file so they don't try to run automatically whenever you run PySQLCoreTestSuite
Renames driver_tests.py -> test_driver.py to match Python / unittest / pytest convention
Adds pytest-dotenv dependency so we can read auth credentials from test.env

Before this change it wasn't possible to run the e2e tests or debug them using VSCode.

I rebased onto main to incorporate the redacted logging fix in #153.


Open Link in New Tab (target="_blank")

When clicking a link where target="_blank" the resultant page loads in the current tab.
EG:
GitHub
GitHub
The expected/conventional behaviour is to open such links in a new tab.
Can the app either adhere to the conventional behaviour or provide the ability to enable/disable it via the options menu?

@subsymbolic I don't mean to chase, just curious to know if PR #511 hasn't been reviewed because no one has had time to do so or whether you have no intention of reviewing it?

@thecliguy it's a good suggestion and we are tempted to make the change but still discussing the pros and cons internally as it can be abused by sites and many users find the new tab launch unexpected. I'll update this issue again once we have made a decision.

It could be a setting to allow opening of new tabs, so the user can decide what he actually wants.

@donfuxx definitely - that's one of the options we are considering.

A lot of users are asking for this so we have decided to add it. We'll start by honoring the default behavior without a toggle but may introduce one if we need to later.

This final fix for this is now merged and will be available in the next release. Thanks for reporting it @thecliguy and for helping us solve it @donfuxx.


Decide on version scheme

We should decide on the version scheme that we should use. I collected some former comments:
@frostedoyster:

Thanks for the comments! I'm not sure about 1, I would do every change to main with an automatic date update. Something like 2024.03.10 (and 2<IP_ADDRESS>, 2<IP_ADDRESS>, ... if needed).
Regarding 2, IIRC, only stable models are required to have PyPI-installable dependencies, right?

@Luthaf

Here is a list of things that need to happen before we can release on PyPI:

have a discussion with everyone for the release cadence & version numbers

I actually like the idea of YEAR.major.minor. The big MD packages are now doing  this as well. I like the fact that users see directly how old their used version is. Other opinions?

During the meeting, we decided to go toward YEAR.patch as a version number, i.e. the first release in 2024 would be 2024.0, the next one 2024.1, then 2024.2, and so on.


Shift+V up does not work with plugin enabled

To select multiple lines in Visual mode, I typically do Shift+V <up> (or <down>). The CSV plugin breaks this functionality. When I press <up> the current line is un-selected and I am put back in Normal mode. If I use j or k instead of <up> or <down> everything works as expected.

I cannot reproduce this. What is the output of :verbose :xmap <up> or :verbose :vmap <up>?

:verbose :xmap <up> and :verbose :vmap ` both output the same:

        *@:call 46_MoveCol(0, line(".")-v:count1)
Last set from ~/.vim/ftplugin/csv.vim

Hm, this is obviously mapped in CSVMappings(), however I still cannot reproduce this. Oh well, let's just remove the mapping in visual mode. Should be fixed now.

It works, thank you!


Unclear what impact the TranslucencyMode property has

The screenshot looks (to me) like all 3 possible values of TranslucencyMode result in the same look:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a52cd5e-2cc8-0398-dcb3-db2607f11c1b
Version Independent ID: c2586399-6b8c-78c6-e0da-fa3e35adb00a
Content: TabbedPage translucent tab bar on iOS - Xamarin
Content Source: docs/xamarin-forms/platform/ios/tabbedpage-translucent-tabbar.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @darshanrampatel
I see your issue - all three screenshots look the same at a glance. I ran the sample the page links to and when cycling through the translucency modes you can see that the Opaque mode is different. Now I've done that, the screenshot looks different to me - the background of the tab bar in Opaque mode looks white, while it's slightly grey for Default and Transparent.


How to retrieve file size?

How can the size of the file be retrieved (without actually downloading it)?
Would be especially helpful to determine if a download with chunking is required (i.e. size > 16MB).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8026a170-f2e5-9d5f-3c7b-0fcfaca0d71c
Version Independent ID: 7b8e643b-ad4a-2032-ef27-413ed7e8f97a
Content: File attributes (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/file-attributes.md
Service: powerapps
GitHub Login: @phecke
Microsoft Alias: pehecke

It appears that the GetFileSasUrl Function returns the file size, and also allows you to download without chunking. :)

@DanielBruckhaus You can obtain the file size using the SDK API with InitializeFileBlocksDownloadResponse.FileSizeInBytes. For the Web API, send the GET request and look at the response header. However, do not then download the body contents unless you want to.


Consistency between the views of chrome extension and stacks wallet

User notices that when viewing a specific account for an e.g
Account #5 Receive screen view on chrome extension and when user selects the stacks wallet ,account #5 is populated but just not the same receive view but the general account 5 main view.
Attaching the video for better comprehension
https://user-images.githubusercontent.com/38872890/125671628-0d726ff6-908d-4e7c-9709-b5d898bb31f8.mov

This seems like expected behavior in that the extension popup doesn't need to load the same currently viewed state or page as the extension full-screen window.


[WIP] Format code according to prettier

[x] Modify .prettierrc
[ ] Add a pre-commit hook

printWidth: 80 sets the rule for a line to not exceed 80 character limit.
I will add the pre-commit hook after the configuration is approved so that all the changes in formatting of JS files are committed too.
Fix #318

@shcheklein @mroutis

I have added the prettier hook. I am looking for a hook which will format markdown files as well. But I think the markdown linter shouldn't be strict enough since, sometimes, markdown gets rendered wrongly if formatted correctly.
Next, I will commit the JS files with formatting.
This will require changes in contribution guide for which should a separate PR be opened?

@algomaster99 Thanks! And yes, let's create a PR to the contributing guide that explains how this pre-commit hook can be installed and how to run it.


Remove Projects (0) from repo navigation

Since GitHub has introduced projects there is this Projects tab on every repo. I am yet to see a repository using them. So I'd suggest removing the tab if there are 0 projects. It would reduce clutter and you will only see it when a repository is actually using projects.
That said I understand why GitHub did it like that - showing it for every repository even though nobody is using it at first - they want people to know about the feature, to open the tab and see the intro copy there. However I think users of Refined GitHub are heavy GitHub users and already know about it.
Implementation should be fairly easy as GitHub already show the number of projects in the tab button.

👍

If we take out the navigation then how else will people discover Projects? We'd be kneecapping the discovery of a new feature that people worked hard on. 😢

@paulmolluzzo We don't have to do it right now, but eventually I'd like to see it gone when unused.

@paulmolluzzo We don't have to do it right now, but eventually I'd like to see it gone when unused.

OK, I'm just offering a counterpoint. Again, I don't want to take away the opportunity for all the GH people that worked on this feature to have their work gain traction.

@paulmolluzzo It's a good point. I just assumed everyone knew about it from the blog post, but I'm sure that's only a small portion of users.

@paulmolluzzo I get your argument, but I don't think we're actually preventing people to know about it. Here are the two use cases I think about:

People using the extension already: They are certainly heavy users of GitHub, they might have even read the blog post or watched the GitHub Universe keynote. They certainly look at GitHub repositories at least a few days a week. I assume they already know about the projects feature, because they are used to how the tabs are ordered there. They saw that Refined GitHub has removed Pulse and added Releases. So they have also noticed the Projects tab and clicked it to look around. If they have started using it, this change would not affect the repositories where they already have projects.
People who are yet to install the extension: If they are heavy GitHub users arguments for 1. apply for them as well. If they are new to GitHub they would spend quite some time dealing with GitHub and repository pages before finding and installing Refined GitHub extension. I wouldn't entertain the idea that they would discover GitHub through the extension or they'd install it in the first few days of GitHub usage. I'm quite certain that most users of the extension would have become GitHub regulars before installing any GitHub extension and especially one such as Refined GitHub which changes a lot of things in a lot of different places.

In both cases however the thing which actually concerns me is that even if people know about projects would not be easily able to create a new project. They could either guess the URL, disable the extension to create the project, copy the URL from another repo with projects, but none of these are straightforward.  Perhaps we shouldn't do this change or at least should add a button for adding a new project. I haven't found a good solution to this yet.
I just know that I won't use the projects feature for the foreseeable future - excluding the cases where someone is using them on an open-source repository I'm interacting with, but that case won't be affected. So I wanted to suggest this change and see what others think about it. I'm glad there's a discussion :)

If we decide to go for this, we could simply add a button in the Settings page that points to https://github.com/sindresorhus/refined-github/projects/new. That's really where GitHub should have put the button, instead of littering the main nav with something most repos won't use.

FWIW this is the first repo I've seen to use projects and I admit their use case is quite nice: https://github.com/algolia/instantsearch.js/projects
I've used Trello boards almost since the launch of Trello and I'm a big fan of such layouts, but what I don't understand is why GitHub launched this in addition to milestones instead of upgrading milestones to that.
</rant>

I think user should be allowed to disable the projects tab just like the Wiki tab. I don't mind if it's left it on by default, but allow users to turn it off like you already do for wiki/issues, etc.

allow users to turn it off like you already do for wiki/issues, etc.

To clarify disabling of wiki and issues is functionality provided by GitHub. This is just a browser extension changing the DOM on the page.

@hkdobrev Sorry, you're right, I'm posting in the wrong repo. ;)

GitHub added a setting to disable projects just like issues and wiki: https://github.com/blog/2339-disabling-projects-on-repositories 🎉

So we can close this issue then?

@paulmolluzzo No, it only works if everyone disables it if they don't use it, which very few will.

@paulmolluzzo No, it only works if everyone disables it if they don't use it, which very few will.
I just don't want unnecessary noise in general, and maybe 1 out of 1000 repos I visit actually use Projects.

@sindresorhus Fair point and you're probably right that most people won't bother disabling it.

I'm marking this issue as pull request welcome. We can add a Create Project button in the the Settings where you can turn off Projects.

@sindresorhus you think we need to remove the good for beginner label? I think this is still pretty accessible for a beginner and we have a lot of info in this issue for someone to use in the solution. Just a 💡 .

I guess


Handle TableOps exists() issues

This method has concurrency issues, mainly due to cacheing and the distributed environment of Accumulo.  For example, one process could create a table and this method could return false for another process because it's zookeeper cache doesn't have the table ID yet.  Another example... one process calls exists, gets true then performs an action on that table but the table is deleted before the process can perform the action on that table.  We seem to have to explain this to users quite often.  At the very least, we should document this in javadoc.

It appears that this could be a race condition with the changes made in 1.9.  Specifically here.


Sticky header broken in experiments table view

After scroll:

This is strange because we have a story for scrolling which doesn't appear to be broken.

Caused by https://github.com/iterative/vscode-dvc/commit/be2adc3880b4239aa778de705fa42501ffc56542#diff-b07cda7c57ea3d44e77847455b8a5fd5ec51ca179223b797e1324e095dd78bcfR3


Tracking reminder keeps sending notification even when lid is closed

user reports:

If I close the lid and the timer is not running, after I open my laptop, there are a lot of notifications about if I didn't forget to start the timer.

desk case: 303186

Closely related to https://github.com/toggl/toggldesktop/issues/1889

Fixed with #2673


[TA] update azure core test version

Since we are releasing the TA package, it can't not depends on the un_release dependency.
The release pipeline failed at the un_release dependency error: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1174080&view=logs&j=da35a07f-f2a0-5802-21eb-2343f475d719&t=af6d8dee-9549-53ad-9314-7d016295d5e6

/check-enforcer override


Fix ItemPlacer

This is going to lead to many entities being ticked unnecessarily and performance problems.
Resolves https://github.com/space-wizards/space-station-14/issues/21159

what were the performance problems, it seems that it would only affect things currently on hotplates/grills/analyzers which doesnt sound bad

nvm dont have to revert you just dum dum


ES6Promise.Promise.prototype.finally does not behave according to spec

According to draft 4 of the Promise.prototype.finally spec , the callback parameter is kind of optional. When it is not a Callable, then should be invoked with the callback "as is", e.g. something like this:
if ( isFunction(callback) ) {
    // (old) invoke callback and return new promise, retaining result/reason
    return promise.then(value => constructor.resolve(callback()).then(() => value),
                       reason => constructor.resolve(callback()).then(() => { throw reason; }));
}

// (new) don't fail when callback is not callable; also return a new promise
return promise.then(callback, callback);

I understand that it doesn't seem to be reasonable to use finally without a callback.
But generic code that receives some callback as parameter and propagates it to a Promise.prototype.finally now additionally has to check it for being a function.
And I guess, a polyfill in general should be as close to the spec as possible.
Chrome 68, Firefox 61, Safari 11.1 all don't fail when executing
Promise.resolve(5).finally().then(console.log, console.log);
Promise.reject(5).finally().then(console.log, console.log);

Good catch! As a spec reviewer I am embarrassed this slipped past my implementations.
I’ll accept a PR, I should have time in the next day or so to fix myself if someone else doesn’t beat me to it

-> PR #339.
Credits for the finding go to @ThomasChadzelek and @PeterBuchholz.

released as v4.2.5 🎉


Unable to Debug Files

First time contributor here. Am not sure where is best to ask how to debug Files in Visual Studio as I am facing some trouble. I hope it is fine to raise it this way; if not please do let me know where is more appropriate.
I am using Visual Studio 2022 with the UWP development  workload, and the C++ v143 build tools.
However when launching the app (x64) in VS I get a InvalidOperationException when accessing any property on the ApplicationData object.
I've followed the instructions here: https://files.community/docs/contributing/building-from-source
Can't find any obvious StackOverflow posts explaining why I get this error and how to resolve it. Am new to UWP development.
Am looking forward to picking up a 'good-first-issue' and would be grateful for some help!

Hi thanks for your interest in Files! Please make sure you have set "Files.Package" as startup project (point 3). If you still have trouble please let us know. You can also reach us on Discord.


How to handle ETIMEDOUT?

If requested server is unreachable then node process dies with Error: connect ETIMEDOUT. How to handle the exception? Tried wrapping with try{}catch() but that did not work.
try{
  request.get('http://someserverthatisdown').pipe(res);
}catch(e){
  res.send();
}

might be crazy, but if I am reading this correctly, this means you have to catch errors from a request in two different places? once in the err callback, and then once by calling .on('error') and handling the emitted event.

looking in the tests, it seems like either method will catch timeouts..

@amitava82 i do not understand, why use two different way to catch the err?  can you explain the point of your  solution. thanks

@kazaff it's been over 3 years, I don't recall the details 😕

@amitava82 fine, thanks for your reply~~

@amitava82 You can try to run killall node from terminal


v1.30.2+k3s2: 502 bad gateway when trying to get pod logs or exec

Environmental Info:
K3s Version:
k3s version v1.30.2+k3s2 (faeaf1b0)
go version go1.22.4
Node(s) CPU architecture, OS, and Version:
Linux prd-server 5.4.0-190-generic #210-Ubuntu SMP Fri Jul 5 17:03:38 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:
3 servers, 1 control node, 2 agent nodes
Describe the bug:
After changing binding address from default and switching to using internal network addresses, can't use logs/exec commands it results with 502 Bad Gateway error. After reading multiple threads, considered it is related to the proxy settings, that I didn't change. However, even applying NO_PROXY configuration, the issue persisted.
Steps To Reproduce:

Recently upgraded from 1.22.2 to 1.30.2
Decided to make stricter networking rules in my cluster and allow only internal communication. In particular:

On control node in /etc/systemd/system/k3s.service added to ExecStart --bind-address <IP_ADDRESS> --tls-san PUBLIC_IP --kubelet-arg="address=<IP_ADDRESS>"
... later during troubleshooting, additionally added --kubelet-arg "node-ip=<IP_ADDRESS>"
On agent nodes in /etc/systemd/system/k3s-agent.service added Environment="K3S_URL=https://<IP_ADDRESS>:6443" before ExecStart and argoments to ExecStart --kubelet-arg "address=<IP_ADDRESS>"  --kubelet-arg="node-ip=<IP_ADDRESS>" (and .3 for the third node)
Added firewall to restrict traffic to <IP_ADDRESS>/24 for 6443 and 10250 (on control) and 10250 (on agent nodes)
Communication on this ports from different nodes checked - this is the first thing I considered when got the error.
Reloaded daemon and k3s (on control) and daemon + k3s-agent (on agents)

(after several attempts to troubleshoot, found a similarity to #10547, #10444 and #6123 and attempted the following)
5. Added into /etc/systemd/system/k3s.service.env (on control) and /etc/systemd/system/k3s-agent.service.env (on agent nodes):
NO_PROXY='localhost,<IP_ADDRESS>,<IP_ADDRESS>/24'
Also tried to add into a non-existent before /etc/systemd/system/k3s.env
6. Reloaded, Restarted. No effect.
Expected behavior:
Logs and exec into a pod working as it was working right before changing bind-address and making configuration stricter to inter-cluster comms only. It worked on 1.30.2
Actual behavior:
Trying to get logs, i.e.: kubectl logs -l app.kubernetes.io/name=traefik -n kube-system
Error from server: Get "https://<IP_ADDRESS>:10250/containerLogs/kube-system/traefik-68f9c8f94b-gjpgq/traefik?tailLines=10": proxy error from <IP_ADDRESS>:6443 while dialing <IP_ADDRESS>:10250, code 502: 502 Bad Gateway
Or trying to get into a pod container: *kubectl exec -n product --stdin --tty -c front front-8698f4b8fd-nfbnj -- /bin/bash
error: Internal error occurred: error sending request: Post "https://<IP_ADDRESS>:10250/exec/product/front-8698f4b8fd-nfbnj/front?command=%!F(MISSING)bin%!F(MISSING)bash&input=1&output=1&tty=1": proxy error from <IP_ADDRESS>:6443 while dialing <IP_ADDRESS>:10250, code 502: 502 Bad Gateway
Additional context / logs:
k describe nodes no challenges, besides these warnings.
Events:
  Type     Reason               Age    From     Message
  ----     ------               ----   ----     -------
  Warning  FreeDiskSpaceFailed  8m40s  kubelet  Failed to garbage collect required amount of images. Attempted to free<PHONE_NUMBER>6 bytes, but only found 66083171 bytes eligible to free.
   Attempted to free<PHONE_NUMBER>6 bytes, but only found 0 bytes eligible to free.
   Attempted to free<PHONE_NUMBER>6 bytes, but only found 0 bytes eligible to free.

In journalctl, no other errors besides the one I described in the beginning.

Recently upgraded from 1.22.2 to 1.30.2

You stepped through the intermediate minor versions, right? It is not supported to skip minor versions when upgrading.

On agent nodes in /etc/systemd/system/k3s-agent.service added Environment="K3S_URL=https://<IP_ADDRESS>:6443" before ExecStart and argoments to ExecStart --kubelet-arg "address=<IP_ADDRESS>"  --kubelet-arg="node-ip=<IP_ADDRESS>" (and .3 for the third node)

Don't do that. K3s expects the kubelet to be available on the loopback address as well as the node IP. If you explicitly bind it to only the IP, communication between the apiserver and the kubelet will not function properly.

Thanks for not removing the comments from the thread this time @brandond. At least I can report that I've just updated to v1.30.3+k3s1 and confirming that the issue is resolved ;)
Great work! Thank you.

You stepped through the intermediate minor versions, right? It is not supported to skip minor versions when upgrading.

No I haven't @brandond. I did the RTFM, and updated minor by minor version, testing everything after each upgrade.

Use the k3s --bind-address flag instead of hardcoding it via a kubelet arg. If you poke at the kubelet args directly, k3s won't know what address the kubelet is listening on.

@brandond can you please advise whether I need to open another issue or it's still relevant? What I noticed, if a pod is scheduled on another node (in this case - agent node), when I try to get logs executing it on the control node, I am getting this:
Get "https://<IP_ADDRESS>:10250/containerLogs/myservice/myservice-8698f4b8fd-sbg28/mycontainer?follow=true&tailLines=1000&timestamps=true": net/http: TLS handshake timeout


Assignment 3

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Analyse the accessibility, reproducibility, and equitable quality of the visualizations.
What did you learn from the changes you have made?
The aesthetic appearance of a graph and its functionality do not necessarily overlap.
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No
How were these changes tested?
Giving reasons for considering a visualization as being or not being accessible, reproducible and equitable.
A reference to a related issue in your repository (if applicable)
No
Checklist

[x ] I can confirm that my changes are working as intended

A3 complete


added soldeer docs

Added soldeer documentation to the book, i tried to mimic the dependencies section.

you need to add it to summary.md as well otherwise it wont be rendered in the book:)

Ah correct, thanks, corrected!


Update URLs

Reflect new package name

Thank you! I have to update this information in a couple other corners as well :)

Great! Pleased to see development continuing on this wonderful app.


The Items won't show

I cant get anything to show

SAME!!! I have no idea why nothing is showing! I tried doing the whole Ctrl + o as well but nothing is showing! It worked like a charm until 3 weeks ago

Check if you have ThinkBigCore, that mod was the reason NEI was not showing up at least for me.


conda: command not found

I've run into a problem during the installation of SageMath.
After running the WSL install command as administrator I was successful installing Ubutu and setting up a username and password on UNIX.
Following the instructions in the Sage Installation Guide under Windows and No Development I have successfully executed through the command:
$ bash Miniforge3-$(uname(-$uname -m).sh
When I execute the command:
$ conda create -n sage sage python=3.11
I get the error message:
conda: command not found
Can you please help me resolve this?
I am installing on a desktop PC with Windows 11.  After this I will install on a laptop with Windows 10.
Thank you for your help.
Jack

I had this same issue, I had to install bzip2
sudo apt install bzip2

Thank you.
Did that and still get:
conda: command not found
Then I tried: sudo apt install conda
and got unable to locate package conda
Maybe I need to install conda somehow, but I don't know how.
Thank you for your help.

When you install conda, make sure to type yes to all the questions you'll be asked. I was getting the same problem and then I tried answering yes to the last question.

Thank you.  That works.  That was the problem.
 Best regards,Jack
In a message dated 9/14/2024 10:29:00 AM Eastern Daylight Time, @.*** writes:

When you install conda, make sure to type yes to all the questions you'll be asked. I was getting the same problem and then I tried answering yes to the last question.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

That was my problem which I solved.
I believe that it's after the command:$ bash Miniforge3-$(uname)-$(uname -m).sh(I believe that was the place)after printing a stream of output it stops at a place waiting for input.The tendency is to just hit Enter, but that will lead to the error.  Instead, you need to type yes at that spot.When the next input prompt appears, do not continue.Instead exit the shell and open Ubuntu again.At that point you should be able to successfully enter:$ conda create -n sage sage python=3.11 The instructions provided are both unclear and incomplete. That's how I fixed it at my end.Good luck.
In a message dated 9/24/2024 10:11:24 AM Eastern Daylight Time, @.*** writes:

hi
I typed yes to all the questions I've been asked and still doesn't work. When I type
$ conda create -n sage sage python=3.11
i get the error message:
conda: command not found
I don't know what to do...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

That was my problem which I solved. I believe that it's after the command:$ bash Miniforge3-$(uname)-$(uname -m).sh(I believe that was the place)after printing a stream of output it stops at a place waiting for input.The tendency is to just hit Enter, but that will lead to the error.  Instead, you need to type yes at that spot.When the next input prompt appears, do not continue.Instead exit the shell and open Ubuntu again.At that point you should be able to successfully enter:$ conda create -n sage sage python=3.11 The instructions provided are both unclear and incomplete. That's how I fixed it at my end.Good luck. In a message dated 9/24/2024 10:11:24 AM Eastern Daylight Time, @.*** writes:    hi I typed yes to all the questions I've been asked and still doesn't work. When I type $ conda create -n sage sage python=3.11 i get the error message: conda: command not found I don't know what to do... — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

It worked!! Thank you.
You are right about the instructions.

I tried everything every each one of you said, but I still get "conda: command not found"
What can I do?

What happens when you type ‘conda —version’?
On Fri, Oct 18, 2024 at 8:48 PM GiorgosP33 @.***> wrote:

I tried everything every each one of you said, but I still get "conda:
command not found"
What can I do?
—
Reply to this email directly, view it on GitHub
https://github.com/conda-forge/sage-feedstock/issues/101#issuecomment-2423458184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMUZQKKEEZSJGJNUDTTXO4TZ4G27FAVCNFSM6AAAAABN3SCLP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGQ2TQMJYGQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

conda 24.7.1

What can i do , if someone can help me?

This 'What happens when you type ‘conda —version’?' save me thanks.

I also encounter this annoying problem and it might be helpful to check this page https://stackoverflow.com/questions/53805965/windows-subsystem-for-linux-conda-command-not-found on stackoverflow.
As conda would be installed in home/{your user name}/miniforge3 by defult, type cd home/{your user name}/miniforge3/bin and run, then run ./conda init. And remember to replace {your user name} with your user name in wsl2.
Reopen the console and you could see there is a (base) before the user name like "(base) yourusername@computername:~$", then conda command can be used.
And as hearot said, just simply reinstall again and answer yes for all questions, especially for the last question which asks "Do you wish to update your shell profile to automatically initialize conda? blablabla~~~ You can undo this by running conda init --reverse $SHELL? [yes|no]" , then things should be done.


Make _.iteratee docs more explicit

_.iteratee contains a huge amount of power/magic, and based upon my personal experience, it is one of the most underused aspects of Underscore.
The issue of _.iteratee's functionality being hard to discover has been raised before (#2052).
Hopefully this more explicit documentation can help. Additionally it lays groundwork for documenting _.iteratee as user definable if #2480 ends up getting merged.
To aid in review, you can see my proposed version here: http://rawgit.com/captbaritone/underscore/iteratee-docs/index.html#iteratee

Coverage remained the same at 96.867% when pulling 15f10acf2b9a2b2df3a30551f87e67c095202908 on captbaritone:iteratee-docs into 6a2c2ee882dd20dd9411275f7e6a1c9831318621 on jashkenas:master.

@megawac I'd be happy to cherry-pick this over to gh-pages if you want.

@megawac I went ahead and cherry-picked.


[Courier] I received this message even when the status was not updated (only comment added).

no longer needed while the courier will no longer add in transit messages


Fix OpenSLES cleanup on Android

Fixes the following error output:

I'm not sure if this is critical. This happens when the app is terminated via the "BACK" button. On Android, however, the app is not completely terminated, the app is still in the app list in the background and can be restarted.

See also:

https://github.com/godotengine/godot/pull/85955

I think it can be closed here, the extensions from @PierceLBrooks look more extensive.
destroy

We recommend that you explicitly set both the primary object interface and all associated interfaces to NULL as part of your object destruction sequence, which prevents the accidental misuse of a stale interface handle.

Pierce did that too

--> https://github.com/godotengine/godot/pull/85955


[BUG]

I have installed multiple PHP versions setup and using parallelly. It's working perfectly fine. Now I want to set up webhook requests in my project, I have installed a local tunnel in docker PHP 8, but it is going to redirect docker PHP 74. I did not understand why.
added code in docker file
# Install npm
RUN curl --silent --location https://deb.nodesource.com/setup_16.x | bash -
RUN apt-get install -y nodejs
RUN echo "Node: " && node -v
RUN echo "NPM: " && npm -v
RUN npm install -g localtunnel

Running a command in the docker container
 lt --port 80
All changes are done in cc-lamp-php8.
But still, it is redirected to a site hosted for php74.
Can you please help me?

Thanks

maybe provide a title to the bug report?

Hey there, this is not directly related to code of the stack itself, So I will close this issue.


Bug: Environment development

Describe the bug
The development environment has an error configuring it in .env as shown in the image below:

CodeIgniter 4 version
CI 4.1.3
Expected behavior, and steps to reproduce if appropriate
Download the project manually or via composer, then configure the .env
Context

PHP version 7.4

I was giving somes F5 and the error disappeared, why he is showing the error I don't know, maybe some ngix cache.

Error reappeared, could be something with ngix.
However I use the Docker, only with the codeigniter this is giving a problem :(

This would be hard to tell if a bug with CodeIgniter considering that the shutdown handler catches the fatal error.
However, I am led to believe this is not a bug with the framework since the fatal error tells us an empty filename in Unknown. For one, I can see that error message if there is a misconfiguration in the php itself, perhaps wrong ini settings or misconfigured extensions. If you can check this against non-Docker environments and/or different servers aside from nginx, then we'll see if the problem still persists.
For now I'll be closing this but feel free to continue the conversation if you found anything.


lt5227-修改更新gitbook至最新版内容。

将之前gitbook内容更新修改成当前最新版的内容。

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

最新内容将发布在黄山版.pdf，gitbook我们会适时更新。

最新内容将发布在黄山版.pdf，gitbook我们会适时更新。


Parallelize wfmash

PR checklist

[x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/pangenome branch on the nf-core/test-datasets repository.

[x] Make sure your code lints (nf-core lint .).
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

This PR parallelizes the wfmash process so it can scale on a whole cluster. This is possible with the https://github.com/ekg/wfmash/blob/master/scripts/split_approx_mappings_in_chunks.py script thanks to @AndreaGuarracino!

[x] Added process wfmashMap which only runs the approximate mapping step of wfmash.
[x] Added process splitApproxMappingsInChunks which divides the approximate .paf into chunks of equal problem size.
[x] Added process wfmashAlign which performs the base-level alignment step of wfmash for each chunk in parallel process submissions.
[x] The --wfmash_only parameter stops the pipeline after the wfmash step. This makes it possible for user to scale only wfmash across a whole cluster.
[x] Updated tests, JSON schemas, etc.

As expected, only the nf-core linting is failing. Ready to merge :)


readme autowatch hint

just added a hint to the autowatch <folder> section

@m1well This PR will be merged when I am ready to push up the new core updates.

Closing this PR as implementation of next major version of NotePlan plugin API will change and this functionality will be different.


Hero section Branch

I tried to do my best.
In this project I :

chose template number 3, in the link provided with the project here
began with NavBar and the Welcome Section, and I am almost finished with them.
made a responsive layout by making a hamburger menu button appear on mobile view, and made a suitable view for mobiles.

I'm very sorry, it was already many mistakes that are not overlooked.
this time I did more things which makes my portfolio prettier.
In this Review I :

Changed the Readme File.
Used a header tag and nav tag.
changed alignments of all texts to be as same as the template.
adjusted the size of the hamburger button to match the template.
used  tag to show the bio

After all, I really appreciate your efforts and help.

I changed the Licence in ReadMe File.
So this is the last request review I have. I hope there is nothing to change.
Thank you.

Notice:
Hi @KareemWilson
Please make sure you make the above changes before merging your pull request


Add the ability to ignore <header> and <footer> tags in partition_html

The goal of this issue is to all users to optionally ignore <header> and <footer> when using partition_html. This should be as simple as using this optionindoc_after_cleanerswithinpartition_html`. See this comment for details.

Closed by #1013


Entity Component System

Implement Entity-Component-System, with basic ready to use:
Entities:

[x] GameEntity (base class)
[x] TransformEntity (entity with transform)

Components:

[x] GameComponent  (base class)
[x] TransformComponent (for position, rotation, scale)
[x] SpriteComponent (for drawing Texture with Rectangle)
[x] FigureComponent (for drawing primitives)

[x] RectangleComponent
[x] CircleComponent
[x] LineComponent
[x] PolygonComponent
[x] PointComponent

[x] AudioEffectPlayerComponent (for playing audio)
[x] SongPlayerComponent (for playing ambients)

System:

[x] GameSystem (base system)
[x] RenderSystem
[x] LogicSystem

Done


Add session.Options values to cookie

Just like the original implementations below, options (MaxAge, Path, etc...) should be set to the cookie.
https://github.com/gorilla/sessions/blob/9cb0b0a3e38d07f41143f03013eaf0a3243fb474/store.go#L102
https://github.com/gorilla/sessions/blob/9cb0b0a3e38d07f41143f03013eaf0a3243fb474/store.go#L210
This pull request solves #1.

@googlebot I signed it!

Hi! Will any revision be done?


wrong group for IsNonNull & powSeries

IsNonNull is not combining multiple series of a wildcard into a single series, so this should be moved to group Transform.
https://github.com/graphite-project/graphite-web/blob/2f133192ed6c459dfa741c42c08d0627747df5ac/webapp/graphite/render/functions.py#L4572

powSeries is combining two or more series into a single result so it should be moved to group Combine
https://github.com/graphite-project/graphite-web/blob/2f133192ed6c459dfa741c42c08d0627747df5ac/webapp/graphite/render/functions.py#L1522

looks like this was fixed and can be closed


Docs: clockpro

Add 'clockpro' to the docs, and fix typo in filename

@econtal Thanks for the contribution 🙏