Investigate discrepancy between non-BLAS and BLAS versions of linfa-linear

According to the benchmark results from this comment, linfa-linear is faster with BLAS than without. The OLS algorithm isn't too different with 5 features and is only slightly slower with 10 features, but GLM is significantly slower without BLAS. We should profile and investigate the difference between the BLAS and non-BLAS performance.

Flamegraphs from profiling attached. I haven't studied profiling or flamegraphs to build a firm foundation yet so I can't provide any insights.
Linfa_linear.zip

did a quick review. 10 feets GLM 100_000 samples is spending most of its CPU time at this step ndarray::zip::Zip<(P1,P2),D>::for_each this is called twice. Both calls share an ancestor of argmin::core::executor::Executor<O,S>::run
One flow has <argmin::solver::linesearch::morethuente::MoreThuenteLineSearch<P,F> as argmin::core::Solver<O>>::next_iter called before their common <linfa_linear::glm::TweedieProblem<A> as argmin::core::ArgminOp>::gradient operation.
This fork in processing leads to the ndarray::zip::Zip<(P1,P2),D>::for_each being called twice.
A screenshot of the graph is attached.

ed.

Also if we use the rayon backend we could look into using par_azip instead of zip. It is the parallel version.

for_each is being called by general_mat_vec_mul_impl, which is the pure Rust matrix multiplication routine from ndarray. AFAIK it's the only difference between BLAS and non-BLAS for GLM, since BLAS uses a different matrix multiplication routine. The only way to improve this is to call the multiplication less often. Maybe we can enable the matrixmultiply-threading feature on ndarray to improve the matrix multiplication speed. Do we also know if the BLAS version has the same bottlenecks?

I think calling multiplication less often would likely be the bigger performance boost. I can locally test enabling the matrixmultiply-threading feature.
I didn't profile the BLAS version. Is this desirable or just out of curiosity?

Would be useful to see if multiplication is also the bottleneck for BLAS, since BLAS also calls multiplication in two places.

Okay I'll 2 more. One with blas and one with that the matrixmultiply feature.

Blas flamegraph a lil different then the other

The fact that gradient appears twice in the first benchmark is likely due to a sampling inconsistency, not different behaviour. The second flamegraph also has two instances of gradient. The interesting thing is that first few calls to dot perform similarly in both graphs, but the final dot in gradient is where it slows down. Dimensionally, that dot is a matrix-multiplication of y and X, which means it linearly combines each feature column (which have 100k elems). I think the non-BLAS dot doesn't scale well for inputs of that size.


FreeBSD & st

This is not really an issue, I just wanted to tell you that I tested fakesteak on FreeBSD with the vanilla st terminal, and it works fine.

That's fantastic news and valuable information, thank you so much!
I'll amend the README accordingly.


get_post_stage_version restores the initial branch

@jupierce this removes any side-effects from get_post_stage_version
Signed-off-by: Michail Kargakis<EMAIL_ADDRESS>

Nice. lgtm.


pano tool - Unable to open file '/tmp/tmp.4VL5Wv4sQr/split-0.tif'

Hi! I'm running you tool in Windows 10. yes!! :)
Im using cygwin, Hugin for windows installer and dependencies.
$ export PATH=$PATH:/cygdrive/c/Program\ Files\ (x86)/Hugin/bin
But there is an error on running gear360pano.sh
$ ./gear360pano.sh 360_0001.JPG
Splitting input image
Processing input images
caught exception:
Precondition violation!
Unable to open file '/tmp/tmp.4VL5Wv4sQr/split-0.tif'.
(d:/Works/vigra-1.11.0/src/impex/codecmanager.cxx:203)

Error when running nona

So, the solution I found is simple:
$ diff gear360pano.sh.ori gear360pano.sh
41c41,42
< TEMPDIR=`mktemp -d`
---
> if [ ! -d ./tmp ] ; then mkdir ./tmp; fi
> TEMPDIR=`mktemp -d -p ./tmp`

Can you include this change? Thanks a lot!
Excelent tool !!!

Hi!
I added Windows compatibility (slightly modified your patch) plus you don't need to add Hugin to your path. Temporary directory is now created in local directory - not super elegant, but if it helps Hugin for Windows... The problem was that cygwin path was not accepted by Hugin, the modification makes the temporary path relative which works.


Read as well as Execute needed in order to reach file from Azure Storage Explorer

The doc says that "if you are granting permissions by using only ACLs (no RBAC), then you need to grant a security principal read or write access to a file, you'll need to give the security principal only 'Execute' permissions to the container, and to each folder in the hierarchy of folders that lead to the file".
But when I tested this using Azure Storage Explorer the principal required also 'Read' permissions on all folders in the hierarchy of folders that lead to the file in order to get to the file. Am I missing something? Is this an Azure Storage Explorer issue?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d29fd9c-d764-3d15-bff3-2d61ec9f757f
Version Independent ID: 58503de5-d10f-eb43-34f9-6f72a0fa1f9b
Content: Overview of access control in Azure Data Lake Storage Gen2
Content Source: articles/storage/blobs/data-lake-storage-access-control.md
Service: storage
Sub-service: data-lake-storage-gen2
GitHub Login: @normesta
Microsoft Alias: normesta

Thanks for the feedback @tomas-gottwald! We are currently investigating and will update you shortly.

@tomas-gottwald  It's not required 'Read' permissions Storage Explorer,

Additional information:  Storage Explorer App not via Portal (alternative via Azure CLI + storage preview extension). When adding Read + Execute Permission to the root of the container.
However If you still face any issue, make sure you are running the  latest version of Azure Storage Explorer and check for this status, if the issue still persist, I'd recommend posting your question in https://docs.microsoft.com/en-us/answers/products/azure?product=storage since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Hi @SumanthMarigowda-MSFT,
I think I understand how does it work now. As per the table above R-X permissions on the root folder (container) and any other folder leading to the file are required because in order to traverse to Data.txt one needs to perform list operation on the root folder (and any other folder leading to the file). However if you enter the URL of the file you will be able to access it but you won't be able to traverse to it. Might be worth calling this out in the docs so it's more clear.
Thanks,
Tom


Schuffling the multiple scenes when created under the new branch develop/MyNewExperience

If I have multiple unity scenes (Scene1.unity, Scene2.unity) under the new branch MyNewExperience. How do you make sure which scene is presented first?
I guess, PilotRegistry.cs does not exist anymore.

@ashutosh3308 please check that the documentation update is clear enough and close of so.


Add scroll to bottom for request/send money flow

@deetergp and @aimane-chnaif pr is ready for review.
Details
App does not scroll to bottom when request / send money flow is done.
Fixed Issues
$ https://github.com/Expensify/App/issues/15540
PROPOSAL: https://github.com/Expensify/App/issues/15540#issuecomment-1451797803
Tests

Open the app
Open any report
Scroll chat above (any amount of scroll is okay)
Click on + to the left of the compose box then click on request money / send money
Enter any amount and click on continue to perform request or send money flow.
Once you send money or request money verify that chat scrolls to bottom.

[x] Verify that no errors appear in the JS console

Offline tests

Open the app
Open any report
Turn off internet connection
Scroll chat above (any amount of scroll is okay)
Click on + to the left of the compose box then click on request money / send money
Enter any amount and click on continue to perform request or send money flow.
Once you send money or request money verify that chat scrolls to bottom.

QA Steps

Open the app
Open any report
Scroll chat above (any amount of scroll is okay)
Click on + to the left of the compose box then click on request money / send money
Enter any amount and click on continue to perform request or send money flow.
Once you send money or request money verify that chat scrolls to bottom.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/7823358/224231124-428d628f-adf6-4d4b-a959-737d5a67481e.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/7823358/224231260-44635fae-d86a-49dc-adda-8d989bb50b4a.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/7823358/224231397-12f31fb5-5ddd-4500-86b8-07afb34674f6.mp4

Desktop
https://user-images.githubusercontent.com/7823358/224231363-c815c795-621f-4b89-87b8-10b15ce79ba1.mp4

iOS
https://user-images.githubusercontent.com/7823358/224231468-f9a41d47-a61f-47a8-9a69-477071404fc3.mp4

Android
https://user-images.githubusercontent.com/7823358/224231523-68597bd4-e93b-4ebe-80f3-cb2c73333d6f.mp4

@deetergp @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

🚀 Deployed to staging by https://github.com/deetergp in version: 1.2.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.82-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


trim down legorel.owl

go-lego, used for inference in Noctua, imports both all of RO as well as legorel.owl. legorel.owl duplicates a lot of axioms from RO, which may become stale. We should see what is unique in legorel.owl and just retain that (for example linking up to http://purl.obolibrary.org/obo/LEGOREL_0000000, which I think is used by Noctua.

Can we not use a single 'non-standard' ontology (go_rel /legorel /ropending )?

Totally agree, hopefully we can get rid of this.

The published legorel.owl file seems to be legorel-edit.owl, merged with its imports (RO). The only content in legorel is a list of relations asserted to be subproperty of LEGOREL_0000000 ("lego relation"). This term is passed to Minerva at startup as "important relation parent". I'm not sure yet whether Noctua still relies on this information.


Window focus cannot follow the cursor.

Hyprland Version
 System/Version info
OS: Arch Linux
Hyprland Version:(use hyprctl version)
Hyprland, built from branch  at commit fe7b748eb668136dd0558b7c8279bfcd7ab4d759  (props: bump version to 0.39.1).
Date: Tue Apr 16 16:01:03 2024
Tag: v0.39.1, commits: 4460

Bug or Regression?
Bug
Description
I do something on one window, and then I move the cursor to another window, but the keyboard action is still mapped to that window (the non-focused window, which is the previous window)
How to reproduce
It's not hard to reproduce this problem. First you open a code editor (e.g. neovim), then you open a browser (e.g. Firefox), you type some text in the browser, and then switch to the editor to reproduce the problem, as evidenced by the video:
https://github.com/hyprwm/Hyprland/assets/76607157/0147a9ca-744a-41f1-8a28-e4b81716ad82
Crash reports, logs, images, videos
I found some config in Wiki, they is:
misc {
  always_follow_on_dnd = true
  layers_hog_keyboard_focus = true
}

By the way, they not work maybe.

I can't reproduce like your video, but I experienced this in latest release as well, I use win + workspace number to switch between firefox and neovim. When I switch to neovim (workspace 1) the keyboard focus still in firefox (workspace 2), it not always happen but quite frequently. Weird thing is the mouse focus is working, I can click the mouse to move the cursor in neovim but not the keyboard.
I think I can reproduce this when open wofi and close fast, notice I can click mouse but cannot type anything (I don't have screenkey but I actually typing)
https://github.com/hyprwm/Hyprland/assets/13571960/279a7410-3db4-42db-9f40-5df5c9642f27

#5763

it is like the 10 other dupes


No release date for 2.15.0 in changelog

Hi @mit-mit fyi - Dart changelog entry for 2.15.0 is missing release date.
https://github.com/dart-lang/sdk/blob/master/CHANGELOG.md#2150
thanks

cc @athomas

https://dart-review.googlesource.com/c/sdk/+/223424


Improve usability of --p2p-private-key-file

Description
Specifying a specific private key file is too hard with teku.  A couple of improvements we should make:

Automatically trim whitespace from the file before trying to parse as hex (currently it fails if there's a newline in the key file)
Change the teku peer generate subcommand to be more directly useful.  It should write the private key to a file in the format required to be used with --p2p-private-key-file and just print the public key and peerId to the console.  It should always generate a single key rather than multiple and have a more sensible default output file (probably just private-key.txt).

Some clarification.
With space/new-line in the end of the hex string this error is displayed:
Teku failed to start: java.lang.IllegalArgumentException: Invalid odd-length hex binary representation

With incorrect key length:
Teku failed to start: com.google.protobuf.InvalidProtocolBufferException: While parsing a protocol message, the input ended unexpectedly in the middle of a field.  This could mean either that the input has been truncated or that an embedded message misreported its own length.

Both errors give no information to the user. It's even not clear it's linked to the peer key


if readonly is open, read from master when slave is loading data

I meet a problem in cluster; When slave failover, other slave will resync data from new master, if readonly is open, service can't get data in some minute. So I suggest to get data from new master in the sync duration.

Thanks. Though we can probably do better and remeber that node is loading and remove it from the list fro a minute or so. Going to do it in separate PR.

Thanks for your advise.


Not accounting for data-premailer='ignore'?

Premailer allows you to set a data-premailer='ignore' attr on link/style tags. I added this to a <link type="text/css" rel="stylesheet" href="//fast.fonts.net/cssapi/[key].css" data-premailer="ignore"/> line to leave the link tag in and load our custom fonts from fonts.com.
I was surprised to find out that our tests started breaking though because premailer-rails was making network requests to try to download that CSS file presumably so it could be inlined even though it is set to be ignored by premailer.
I'm not sure I totally understand why premailer-rails is going out of its way to do this type of work. I thought it was just hooks to run emails through premailer when sending through ActionMailer but this is doing quite a bit more than just passing it through premailer. What is the reasoning for including cache/file/asset/network request lookup bit in premailer-rails?
I forked the gem and modified the selector to match what premailer itself uses "link[@rel='stylesheet']:not([@data-premailer='ignore'])" so it skips links that should be ignored but without more context around this behavior I am not sure whether I should submit a PR for this or not.

premailer-rails works by reading the linked styles into a string and passing the HTML and the CSS string to premailer for inlining. premailer's CSS loading is not compatible with the asset pipeline, nor with development mode. Further, premailer-rails caches CSS files. As you see, it's not "just" a thin wrapper.
Having said that, I agree with you that the data-premailer="ignore" attribute should be honored. PR welcome :blush:


chore(ui): UI improvements

Describe your changes :

Issue : #9819

Type of change :

[x] Bug fix
[x] Improvement

Frontend Preview (Screenshots) :
Issue :

https://user-images.githubusercontent.com/66266464/220607887-b31e50f5-f8aa-4cc6-a34b-29cedbda573c.mov
https://user-images.githubusercontent.com/66266464/220608139-f4865ccb-e137-4b74-8382-de7e4d3e9cfb.mov
Resolved :

https://user-images.githubusercontent.com/66266464/220594389-ffb73fa3-25b5-4c4f-83d2-0cf221252cff.mov
https://user-images.githubusercontent.com/66266464/220594405-37c88d59-0d18-4dcf-ac95-d0c528c68307.mov

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
@open-metadata/ui

@chirag-madlani changes made as per comments!


[1.13.4] Small Upgrades for Stats Watcher

Small features for Stats watcher migration to typescript.

Ran npm publish offline


Fix: Internal error in regexp_replace() for some StringView input

Which issue does this PR close?

Closes #12150 & #11912
Rationale for this change

What changes are included in this PR?

This adds some data type coercion for when there is a [Utf8View, Utf8, Utf8] input that does not return a Utf8View output.
Are these changes tested?

Are there any user-facing changes?

Closing this pull request and re-opening.


TXT output format

Running dalfox on a remote xterm (with putty client, so without gui) on Ubuntu 18.4 we have a issue with TXT output format:
...
^M^[[37m[] ^[[0mStart static analysis.. xx
^M^[[37m[] ^[[0mStart parameter analysis.. xx
^M^[[37m[*] ^[[0mGenerate XSS payload and optimization.Optimization.. xx
...

This "strange" characters is because dalfox put colors in output to make easier to visualization, maybe in future would have a "-n" or "-nc" to let user decide if want or not have colorized screen.
In any case you can remove it by now using:
sed 's/\x1b\[[^\x1b]*m//g' YOUR_FILE.txt

@alfonsocaponi  @bsysop
Thank you for your opinion! I'm aware of that, but I'm still thinking about how to deal with it. I'll patch it before this weekend!

Hi @alfonsocaponi , @bsysop
I fixed this issue, please update dalfox v1.0.3-dev.
go get -u github.com/hahwul/dalfox

Oh, the data is a little different in the image  from 123 file, but it's because I did another test before taking a screenshot. Keep that in mind!
If there is a wrong move, please re-open it!


McCall exercise solution index

Hello,
For the exercise solution for Job Search I: The McCall Search Model (mccall_model.ipynb), I'm wondering if the index is off when generating the random wage causing the estimated means to be off. The code segment is below
# Generate a wage draw
        w_val = w[rand(dist)]

Since support(dist) is in 0,...,50 shouldn't it be w_val = w[rand(dist)+1] so that it matches the indices of w which go from 1,...,51?

From having taken a look at the notebook I believe that is correct. Thanks for reporting it!
I saw that you had made a fork of the repository. The fix should be as you described (i.e., w_val = w[rand(dist)+1]). Would you like to open a PR with the fix?

Thanks! Opened a PR. First one, hope I did it correctly.

@wkeahi thanks so much! I am waiting for Julia 1.6 to be released, them am planning on updating support and merging a bunch of these sorts of changes


[DOCS]: Reorganize docs from packages to features

Update the side menu and pages to list Analog features instead of a collection of separate packages. The only standalone package is the Astro / Angular integration.
The rest of the plugins are going to be rolled under the @analogjs/platform package.

Fixed in https://github.com/analogjs/analog/pull/241


light-client-verifier: 🌱 restore verify_commit() interface

in #1410, alterations were made to the PredicateVerifier<P, C, V> to improve performance when verifying commits.
specifically, a call to
verify_commit_against_trusted(untrusted, trusted, options) will now make use of new internal interfaces that check validator signatures and signer overlap at the same time.
this is a worthwhile performance improvement, but in the process, it made changes to the public interface of PredicateVerifier<P, C, V> that breaks some use cases. as i understand it, there is no strict need to remove the other public interface from the verifier. those that call verify_commit_against_trusted can still receive a performance boost, but calling verify_commit on just the untrusted state should still work after those changes.
so, this commit restores verify_commit(untrusted), and keeps verify_commit_against_trusted(untrusted, trusted, options) under its previous name.
<!--

Thanks for filing a PR!

Before hitting the button, please check the following items.  Please note that
every non-trivial PR must reference an issue that explains the changes in the
PR.

Please also make sure you've targeted the correct branch with your PR. See the
contributing guidelines for details.

fixed nightly regression in #1424, i'll rebase when that lands.

Looks good me, agree we should have been careful not to break the existing API.
@mina86 How does that sound to you?

@cratelyn Can you please add a ch age log entry while you're at it? 🙏

@cratelyn Can you please add a ch age log entry while you're at it? 🙏

@romac sure thing. c0e0f65 :scroll:

Thanks! Will wait for @mina86 to take a look before merging.

LGTM


Pass custom request headers to fetch

Discussed in https://github.com/katspaugh/wavesurfer.js/discussions/2922
Allow passing custom fetch options.

Is it possible to set fetchParams when using WaveSurferEvents: { load: [url: string]; }


fix: compile errors in tests

What this PR changes/adds
Fixes some compile errors after recent changes in the connector repo.
Why it does that
nightly builds failed
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists

Codecov Report
Patch and project coverage have no change.

Comparison is base (da6bfa1) 68.82% compared to head (7c09092) 68.82%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##               main      #38    +/-   ##
==========================================
  Coverage     68.82%   68.82%
- Complexity        0      106   +106
==========================================
  Files            26       26
  Lines           648      648
  Branches         22       22
==========================================
  Hits            446      446
  Misses          199      199
  Partials          3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MNIST and FashionMNIST now have their own 'raw' and 'processed' folders

Addresses https://github.com/pytorch/vision/issues/599.

Ready.


Migrating admin CLI commands to reql admin

I believe 1.16 will no longer have rethinkdb admin. It would be very useful to have a migration guide to help convert rethinkdb admin commands to use the new admin API in 1.16.

rethinkdb admin has been gone for a while, and nobody has asked about this as far as I know. Closing.


Cool resources

Glyphduino library - library with pre-made glyphs

Adding this and other resources to readme.


ID3v2: Fix conversion of user defined frames when using Tag writing interface

fixes #140

Works perfectly using the code and test file I provided in #140 :partying_face: thanks for fixing!

Awesome, thanks for confirming! :slightly_smiling_face:


Add API Generated Docs

Description
The initial implementation of API Generated docs. This implementation is not complete, and gated under the flag api_generated_docs_enabled, enabled in dev/browser tests. See #5262 for remaining TODOs.
Release notes
None.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Followed steps to internationalize new strings
[x] Wrote browser tests using the validateAccessibility method
[ ] Tested on mobile view. See mobile device mode

Not applicable for admin views.

[x] Manually tested at 200% size
[x] Manually evaluated tab order

New Features

[x] Add new FeatureFlag env vars to server/conf/helper/feature-flags.conf
[x] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Only on

Instructions for manual testing
If you want to test it, open CiviForm, seed the sample programs, and open the API docs tab from CiviForm Admin or Program Admin mode.
Issue(s) this completes
Initial implementation of #5262. Fixes #4872.

@avaleske some test failures came up, will send back to you once resolved.

@avaleske some test failures came up, will send back to you once resolved.

There's one more test I can't quite figure out, but it's minor and I can resolve it later. Feel free to start reviewing.


Standalone Setup on NON-Docker server

Hi Team,
Can you please share a detailed steps to install "kafka-minion" project on non-docker server?
I am planning to use this project to export Kafka metrics to prometheus and use grafana for monitoring.
It would be great if you share it at earliest.

Install Go
git clone https://github.com/cloudworkz/kafka-minion && cd kafka-minion
CGO_ENABLED=0 go build

Once you have the compiled binary you can run it like any another Linux program, you configure it using environment variables(refer to README)
Here's my systemd unit file:
[Unit]
Description=Prometheus Kafka Minion
After=network-online.target

[Service]
Type=simple
User=kafka-minion
Group=kafka-minion
Environment=TELEMETRY_PORT=9999
Environment=KAFKA_BROKERS=YOUR_BROKER_HERE:9092
Environment=VERSION=1.0.0
ExecStart=/usr/local/bin/kafka-minion
SyslogIdentifier=kafka_minion
Restart=always

PrivateTmp=yes
ProtectHome=yes
NoNewPrivileges=yes

ProtectSystem=strict
ProtectControlGroups=true
ProtectKernelModules=true
ProtectKernelTunables=yes

[Install]
WantedBy=multi-user.target

You are supposed to cimpile the binary on your own (as described by @godwhoa) because we don't release/upload binaries as of now (feel free to submit an issue for that though). Now that we have GitHub actions this should be quite easy to do.

Hi Team,
Thanks for your quick response. I have followed your above steps and getting below error :
Any thoughts?
$ CGO_ENABLED=0 go build
go<EMAIL_ADDRESS>Get<EMAIL_ADDRESS>proxyconnect tcp: tls: first record does not look like a TLS handshake

Hi,
Please ignore above comment , i am able to build "kafka-minion" and able to integrate with prometheus. I am getting only below metrics for kafka consumer .  Where can i find additional kafka metrics for consumer offsets?
-- prometheus metrics
net_conntrack_dialer_conn_attempted_total{dialer_name="kafka-minion-222"} 36
net_conntrack_dialer_conn_closed_total{dialer_name="kafka-minion-222"} 1
net_conntrack_dialer_conn_established_total{dialer_name="kafka-minion-222"} 2
net_conntrack_dialer_conn_failed_total{dialer_name="kafka-minion-222",reason="refused"} 34
net_conntrack_dialer_conn_failed_total{dialer_name="kafka-minion-222",reason="resolution"} 0
net_conntrack_dialer_conn_failed_total{dialer_name="kafka-minion-222",reason="timeout"} 0
net_conntrack_dialer_conn_failed_total{dialer_name="kafka-minion-222",reason="unknown"} 34
prometheus_target_scrape_pool_sync_total{scrape_job="kafka-minion-222"} 1
prometheus_target_sync_length_seconds{scrape_job="kafka-minion-222",quantile="0.01"} 3.5452e-05
prometheus_target_sync_length_seconds{scrape_job="kafka-minion-222",quantile="0.05"} 3.5452e-05
prometheus_target_sync_length_seconds{scrape_job="kafka-minion-222",quantile="0.5"} 3.5452e-05
prometheus_target_sync_length_seconds{scrape_job="kafka-minion-222",quantile="0.9"} 3.5452e-05
prometheus_target_sync_length_seconds{scrape_job="kafka-minion-222",quantile="0.99"} 3.5452e-05
prometheus_target_sync_length_seconds_sum{scrape_job="kafka-minion-222"} 3.5452e-05
prometheus_target_sync_length_seconds_count{scrape_job="kafka-minion-222"} 1
/var/log/messages
Mar 13 04:23:25 "hostname" systemd: Started Prometheus Kafka Minion.
Mar 13 04:23:25 "hostname" systemd: Starting Prometheus Kafka Minion...
Mar 13 04:23:25 "hostname" kafka_minion: {"level":"info","msg":"Starting kafka minion version1.0.0","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"address":"<IP_ADDRESS>:9868,<IP_ADDRESS>:9868","level":"info","module":"cluster","msg":"connecting to kafka cluster","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"address":"<IP_ADDRESS>:9868,<IP_ADDRESS>:9868","level":"info","module":"cluster","msg":"successfully connected to kafka cluster","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"address":"<IP_ADDRESS>:9868,<IP_ADDRESS>:9868","level":"info","module":"offset_consumer","msg":"Connecting to kafka cluster","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"address":"<IP_ADDRESS>:9868,<IP_ADDRESS>:9868","level":"info","module":"offset_consumer","msg":"Successfully connected to kafka cluster","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"count":50,"level":"info","msg":"Starting '50' partition consumers","time":"2020-03-13T04:23:25-07:00","topic":"__consumer_offsets"}
Mar 13 04:23:25 "hostname" kafka_minion: {"count":50,"level":"info","msg":"Spawned all consumers","time":"2020-03-13T04:23:25-07:00","topic":"__consumer_offsets"}
Mar 13 04:23:25 "hostname" kafka_minion: {"level":"info","msg":"Listening on: '<IP_ADDRESS>:9999","time":"2020-03-13T04:23:25-07:00"}
Mar 13 04:23:25 "hostname" kafka_minion: {"level":"info","module":"storage","msg":"Registered 50 __consumer_offsets partitions which have to be consumed before metrics can be exposed","time":"2020-03-13T04:23:25-07:00"}

As the last log message described Kafka Minion first has to process all partitions which contain the consumer offsets. This should take roughly 1-10 minutes depending on the number of consumer offsets and the available resources/throughput Kafka Minion has.
If this takes longer or you suspect an issue with that please turn on debug logs. There's an issue which has been reported by a few users that Kafka Minion never finishes to consume the metrics initially. Maybe you are experiencing the same problem? Unfortunately I haven't figured out what's the reason for this as the logic seems to be fine and I am not able to reproduce this in any of my kafka clusters.

Binaries have been added, see: https://github.com/cloudhut/kminion/releases/tag/v2.0.0


Cronos Play Unreal Plugin v0.0.10-alpha Updates

address field can be blurred or erased?

What address fired does you refer to?

address field can be blurred or erased?

What address fired does you refer to?

wallet address, but it's ok


Avoid regressing in progress reporting in resource load

Given how the dependency tree is discovered (on the go), the way the load progress is computed can make it to get lower. This PR simply avoids it by not allowing to report a lower value than the maximum of those already given.

Thanks!

Is this just about how the import looks visually, i.e. the behavior of the progress bar?

Yes. For a proper approach that doesn't need this band-aid in the first place, resource loading should happen quite differently.

Cherry-picked for 4.2.2.


Dead link in README

There is a dead link in the README pointing to https://github.com/exercism/docs/blob/master/language-tracks/configuration/exercises.md

Well spotted. It seems the 3 links in the image are invalid. We might want to just keep a link to Exercism Docs: config.json,
Feel free to open a PR fixing this.


Add Powerlevel10k theme

Powerlevel10k is a 10-100 faster reimplementation of the popular Powerlevel9k theme. It renders the same prompt when given the same configuration options but does it faster. If an existing user of powerlevel9k replaces zstyle :prezto:module:prompt theme powerlevel9k in their .zpreztorc with zstyle :prezto:module:prompt theme powerlevel10k, their prompt will get blazingly fast while still looking the same as before.
Obligatory screenshot:

This PR was tested in a pristine Ubuntu environment:
docker run -e LANG=C.UTF-8 -e LC_ALL=C.UTF-8 -e TERM=$TERM -it --rm ubuntu bash -uexc '
  apt update && apt install -y zsh git
  git clone --recursive -b powerlevel10k https://github.com/romkatv/prezto.git ~/.zprezto
  zsh -ec "
    setopt EXTENDED_GLOB
    for rcfile in ~/.zprezto/runcoms/^README.md(.N); do
      ln -s \$rcfile ~/.\${rcfile:t}
    done
  "
  echo "zstyle :prezto:module:prompt theme powerlevel10k" >> ~/.zpreztorc
  echo "
    # Your prompt configuration goes here.
    POWERLEVEL9K_LEFT_PROMPT_ELEMENTS=(root_indicator dir_writable dir vcs)
    POWERLEVEL9K_RIGHT_PROMPT_ELEMENTS=(status command_execution_time background_jobs time)
    POWERLEVEL9K_PROMPT_ON_NEWLINE=true
  " >> ~/.zshrc
  cd ~/.zprezto  # more fun here because it is a git repo
  zsh -i
'

Thanks for your submission! I've been watching the development of this and was curious if someone would submit it eventually. Unfortunately, we're not accepting new themes in prezto core, but I'd be happy to merge this into https://github.com/belak/prezto-contrib.

Unfortunately, we're not accepting new themes in prezto core...

Oh, it's a shame. Your users get an offer to use powerlevel9k while there is a strictly better option. FWIW, if you repoint powerlevel9k submodule URL to powerlevel10k, all user configs will still work.

I'd be happy to merge this into https://github.com/belak/prezto-contrib.

I'll take what I can. What do I need to do? Send another PR against that repo?

Yeah, one of the things I've been strongly considering is moving all external themes to contrib... then people who want to use just the core can easily do so.
Yep, just submit a PR against that repo. There are already a number of themes in the contrib-themes module. There should be instructions in the repo root for getting contrib working with prezto.

@belak: It would be wonderful to add Powerlevel10k to the core -- especially since it's highly optimized, is a drop-in replacement for Powerlevel9k, and is becoming very popular: https://www.reddit.com/r/zsh/comments/ay6ny7/powerlevel10k_goes_instant_50_times_faster_than/

I'm probably going to catch flak for this... and it's a slippery slope adding any new themes to this repo... however, one of my original worries is that this was going to be a temporary project. That doesn't seem to be the case. You've shown that you're up for continuing to maintain this, so I'm willing to merge this in.
Thanks for your patience and for submitting this in the first place.

To anyone else submitting a theme who stumbles across this issue: there would need to be a very good reason for inclusion. The maintainers of pl10k have given multiple valid reasons - this is a faster reimplementation of another theme already included with a fair amount of support behind it. I just want to be clear that this is an exception to the rule and not the new norm.


ruby: remove invalid paths from RbConfig::CONFIG

Ruby gems are build using the LDFLAGS from
RbConfig::CONFIG['LDFLAGS'] and this string contains paths from $baseRuby which have been modified by remove-references-to so that they are invalid.
Building gems or using Makefiles generated by mkmf in any capacity leads to linker warnings like
ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ruby-2.7.6/lib'

This commit removes the corresponding -L options from rbconfig.rb, fixing these warnings.
Fixes: #177130
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm running nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" now. It seems to be copying or downloading 25 GB of packages so this is taking a while.


Arguments don't work in Powershell

I'm using Mask on Windows 10 and have a task in my maskfile.md that accepts an argument, however this seems to be empty when tested in the script. I've tested both the legacy Powershell that ships with the system (some flavour of 5.1) and the current preview release of the modern Powershell and in both cases Powershell will just output an empty line.
OS: Windows 10 21313.1000
Shell: Powershell 5.1.21313.100, Powershell 7.2.0-preview.3
# Powershell example
## powershell legacy (value)
> 5.1.21313.100
~~~powershell
Get-Host | Select-Object Version
Write-Output "${value}"
~~~

## powershell modern (value)
> 7.2.0-preview.3
~~~pwsh
Get-Host | Select-Object Version
Write-Output "${value}"
~~~

Hmmm, I don't know too much about powershell, but I think you might need to access env variables like this?
param (
    $maskfile_command = $env:maskfile_command,
    $value = $env: value
)

I'm not 100% certain though. I just grabbed this from our maskfile.md which includes powershell blocks for Windows:

If this works, let me know and I can probably improve the README documentation with an example!

Aha, right! It totally went over my head that they're environment variables and that they need to be addressed as such! For some reason, I was thinking they were being passed as params. Thanks for the clarification, and sorry to distract you with a misunderstanding on my part!


Put Orbit on Maven Central

https://central.sonatype.org/pages/requirements.html

Orbit doesn't have any javadocs which is a requirement of Maven Central so we won't be able to easily upload older versions.


Multi touch

Most apps let you compare ranges with two fingers. Maybe we could have tooltip IDs, similar to the paths?
https://user-images.githubusercontent.com/13172299/142957971-286a2842-74ed-460a-86ce-8b852ab06cb8.MOV

This should be easier now with gesture handler v2


webcam.js not working in Chrome: Webcam is not loaded yet

I cannot use the demo locally on Chrome. I get: Webcam is not loaded yet
On Firefox, the demo works

The screenshot was with chrome version: 47.0.2526.73-1
The problem remains with google-chrome-stable

52.0.2743.82-1

Has this been fixed? I also get the message with latest stable chrome.

Chrome requires https to use webcam:
https://github.com/jhuckaby/webcamjs#important-note-for-chrome-47

getUserMedia will only work on a server (e.g. localhost), and not directly from a file (e.g. file://)

I'm on localhost. Still facing same error.

@carlosrberto it's worth noting that it WILL work on localhost without https

Yes
Thanks for sharing information.

@jhuckaby this issue can be closed. The issue was due to loading from file://

Ah, thanks!

Buenas a mi me aparece este error y estoy trabajando en localhost. Primeface 6.0. Solo me funciona en Internet explorer

I cannot use the demo locally on Chrome. I get: Webcam is not loaded yet
On Firefox, the demo works

I am also getting this

@Vish-was WebcamJS doesn't work using local files on disk, meaning, if your URL says file:// it will not work.  You need to host the HTML on an actual web server, so the URL reads https://.


Add comments to TokenValidationParameters describing parameters

For example, users may not realize that setting: ValidateIssuer = false, opens the door for a forwarding attack.
Each of the parameters: ValidateActor, ValidateAudience, ValidateIssuer, ValidateLifetime, ValidateIssuerSigningKey, ValidateSignature
Should describe what is the result of modifying the defaults. We need comprehensive docs trying these to delegates, for example ValidateActor should reference ActorValidator as a way to perform custom validation. Users sometimes turn these validation parameters off when developing or testing.

Merged into KDev https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/commit/827af47924248cee0a7c44c51e8fa7722cde2015


Talent scanning is too spaced out, skipping talents

When running character scan, the talent scan is moving too high to begin with and jumping too much between entries; the cursor usually hits the first and third talents on screen. Doesn't seem to be dependent on resolution.

Found the issue, was due the way i fixed to Xianyun. should be fixed by today.

Release v0.4.5 should fix the issue. Let me know


Improve support to a11y

Hey folks,
I was reviewing the TodoMVC a11y features and I saw you improved colors already, but there are some more improvements possible.
This MR is improving on:

Updating some color contrasts
Including outline on elements (https://github.com/tastejs/todomvc-app-css/issues/35)
Updating screenshot for the Readme file

I also wrote a couple of articles in Medium about what I did:

TodoMVC and a11y — part 1 (Colors)
TodoMVC and a11y — part 2 (Keyboard navigation)

While it's good to improve contrast, this looks too ugly.
Before:

After:

To name a few things:

No green color on checked todo item.
The placeholder color was already ok. A placeholder is not meant to have a big contrast.
I'm ok with increasing contrast on the SVG's, but I think you did it a tad too much.
The border around "All" is too dark.
There should not be a focus ring on the input field. It's already clear it's focused based on seeing the caret.

While it's good to improve contrast, this looks too ugly.
Before:

After:

To name a few things:

No green color on checked todo item.
The placeholder color was already ok. A placeholder is not meant to have a big contrast.
I'm ok with increasing contrast on the SVG's, but I think you did it a tad too much.
The border around "All" is too dark.
There should not be a focus ring on the input field. It's already clear it's focused based on seeing the caret.

Hey @sindresorhus ,
Thanks for the feedback!
I believe the perception of how it looks is mostly a matter of opinion. Nonetheless, I would agree that it could be better.
I have a few counter points about your comments though.

No green color on checked todo item.

I didn't understand this point. Could you expand on it?

The placeholder color was already ok. A placeholder is not meant to have a big contrast.

Could you expand on that? As I understand, not having the big contrast means it's not accessible, as that's the "label" for the field as well.
According to the WebAim contrast checker that is not enough contrast.
Personally I would even go further, as that font is really thin, but I didn't want to change it too much.

I'm ok with increasing contrast on the SVG's, but I think you did it a tad too much.

That was based on WebAim contrast checker and the background used in that block. Do you have some source to check the color, or some extra information on why it shouldn't be that much?

The border around "All" is too dark.

How you suggest a better approach should be?

There should not be a focus ring on the input field. It's already clear it's focused based on seeing the caret.

I see what you mean, and that's an interesting comment. I believe browsers wouldn't have implemented it as a default behavior if the caret was enough though, there is not a lot of highlight to it. We need to also remember that accessibility is for those with low vision that might not see the caret, as it's quite subtle. Also some people might be using using screen magnifier that are not covering the whole screen and not find the focus.
Moreover:
https://github.com/w3c/wcag/issues/1014
https://github.com/w3c/wcag/issues/680

The updated screenshot should have the same dimensions and DPI as the previous one.

I can do that, for sure. Out of curiosity, give this is not being applied in a fixed layout and the image seems to have enough quality to see it clearly (at least for me), could you explain why that is important?

I didn't understand this point. Could you expand on it?

The checkmark should be green.

Could you expand on that? As I understand, not having the big contrast means it's not accessible, as that's the "label" for the field as well.

Accessibility is not binary. We can improve it without extreme contrast. A placeholder is not meant to be as readable as normal text. We can instead make the font slightly less thin. However, in the future, we could consider supporting the upcoming high-contrast media query.

How you suggest a better approach should be?

Slightly darker than the current.

Regarding the input field. We could maybe do a shadow. Something that looks more pleasing.

I can do that, for sure. Out of curiosity, give this is not being applied in a fixed layout and the image seems to have enough quality to see it clearly (at least for me), could you explain why that is important?

It looks blurry on high-DPI screens.

Hey @sindresorhus,
Sorry for the delay in sending this changes, I had a few very busy weeks.
I'm pushing some update based on your comments. I hope you consider this better, but we can do some more adjustments if you find it necessary.
Before:

After:

The checkmark should be green. (on completed items)

I'm colorblind and I missed that 😅 . I don't think we need to fix that in terms of a11y though.

We can instead make the font slightly less thin. (placeholder text)

I made it 400 (before was 300), In my opinion it was better with 300 and slightly darker. Let me know if this is ok, or you prefer to revert back to the original.

However, in the future, we could consider supporting the upcoming high-contrast media query.

I like that idea. Although my only concern left would be the placeholder, and just because it is currently serving as a label as well.

Slightly darker than the current. (border around the filters)

I reviewed the colors I implemented there and turns out I got it a little bit off tone. Finding the right tone I managed to get "base" a little bit ligther.
The thing is :hover has that base color and .selected was a bit darker. I compromised here setting :hover with that new "base" and made .selected have 1.5 contrast ratio from that, half of the recommended ratio for UI components.
What do you think?

Regarding the input field. We could maybe do a shadow. Something that looks more pleasing.

That was a very nice suggestion. I think it looks a lot nicer now!

I also implemented one more change on the toggle-all focused state, to like a bit nicer.

It looks blurry on high-DPI screens.

Does this look ok now?

The "check all" button is not vertically aligned with the individual checkboxes.
The "clear completed" button is not horizontally aligned with the others.
The checkbox buttons should be slightly lighter when not checked.
The focus state for the remove button is not centered around the button (I would also round the focus state to make it look better):

Thanks :)


EC: Switched over to new proxy service

<blink>Don't merge</blink>
Motivation
A few other groups needed this external service, so I did that here: https://github.com/UW-Madison-DoIT/json-proxy-service, and I needed to test to make sure it worked, so i did that here. :)
What Changed?
This PR "eats our own dog food", but the end result is nothing changed.
Reason for pending merge
I would like to get a real release of the proxy service in maven central before pushing this so it doesn't break the build as it currently isn't deployed anywhere.

:+1: . Agree with preference for depending on a real release rather than a SNAPSHOT.
I love the eating own :dog2: :pizza: .  I also love the factoring out much smaller cohesive pieces of the solution as their own versioned artifacts in their own repos.  This is an incredibly healthy, necessary, important refactoring, one that enables re-use, makes tooling more effective, and makes it easier to understand what software is using this utility how.  Hurray for refactoring and its enabling agility.


Access session in BeforeMiddleware panics

Hi. I'm trying to access the session in a BeforeMiddleware, in order to check if the request is authenticated. This is my middleware:
struct SessionMiddleware<C: Connection> {
    connection: Arc<C>
}

impl typemap::Key for User {
    type Value = User;
}

impl<C: Connection + 'static> BeforeMiddleware for SessionMiddleware<C> {

    fn before(&self, req: &mut Request) -> IronResult<()> {
        use ::entities::Session;
        use iron_sessionstorage::{SessionRequestExt,Value};
        if let Some(session) = try!(req.session().get::<Session>()) {
            let sess: String = session.into_raw();
            let connection = self.connection.clone();
            let valid_seconds = ::CONFIG.read().unwrap().get_int("sessions.duration");
            if let Ok(Some(user)) = connection.verify_session(&sess, valid_seconds) {
            req.extensions.insert::<User>(user);
            }
        }
        Ok(())
    }
}

This is causing a panic here: https://github.com/iron/iron-sessionstorage/blob/master/src/lib.rs#L131
Is there any way to do what I'm attempting to do, or will I have to move this to the Handlers? I'd rather not put it in the Handlers, since I want to do this for every request, which seems to be pretty much the entire point of BeforeMiddlewares. I suspect that the fact that sessionstorage is an AroundMiddleware makes it impossible to access Sessions in a BeforeMiddleware?

Since AroundMiddleware.around returns a handler, you can call my_sessionstorage.around(my_chain) and give the result to Iron.

Maybe I'm not understanding what's going on, but I'm getting the same thing I believe. Could you clearify the answer above? Here's some of my implementation:
pub struct Authentication;

impl typemap::Key for Authentication { type Value = u64; }

impl BeforeMiddleware for Authentication {

	fn before(&self, req: &mut Request) -> IronResult<()> {
		let session = req.session();    ///Panics here
		if let Some(session) = try!(session.get::<Login>()) {
			let sess: String = session.into_raw();
			//Continue
		}
		Ok(())
	}
}

//Usage in main:
let mut chain = Chain::new(router);

chain.link_around(SessionStorage::new(SignedCookieBackend::new(my_secret)));
chain.link_before(Authentication);

Iron::new(chain).http("localhost:3000").unwrap();

I understand that the provided examples are quite poor, or the API is. The
problem is that you need to wrap the authentication middleware around the
entire chain, like this:
chain = ...
chain.link_before(Authentication);
chain = SessionStorage.new(..).around(Box::new(chain));

Iron.new(chain)...

Either the examples need to be fixed or the API adjusted... Patches welcome. I
myself don't really use this software much today unfortunately.
On Wed, Nov 01, 2017 at 09:36:09PM +0000, aetsoftware wrote:

Maybe I'm not understanding what's going on, but I'm getting the same thing I believe. Could you clearify the answer above? Here's some of my implementation:
pub struct Authentication;

impl typemap::Key for Authentication { type Value = u64; }

impl BeforeMiddleware for Authentication {
  fn before(&self, req: &mut Request) -> IronResult<()> {
  	let session = req.session();    ///Panics here
  	if let Some(session) = try!(session.get::<Login>()) {
  		let sess: String = session.into_raw();
  		//Continue
  	}
  	Ok(())
  }

}
//Usage in main:
let mut chain = Chain::new(router);

chain.link_around(SessionStorage::new(SignedCookieBackend::new(my_secret)));
chain.link_before(Authentication);

Iron::new(chain).http("localhost:3000").unwrap();

--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/iron/iron-sessionstorage/issues/6#issuecomment-341250486


Incorrectly extends Interface when overwriting Interface Property Function Argument Type to interface that extends argument

Bug Report
🔎 Search Terms
extend function argument types incorrectly extends interface
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about Common Bugs

⏯ Playground Link

This does not work
But this does work
💻 Code

interface baseA {
  prop?: number;
}

interface extendA extends baseA {
  prop: number;
}

interface baseB {
  propA: (arg: baseA) => void
}

interface extendB extends baseB {
  propA: (arg: extendA) => void
}

🙁 Actual behavior
Error on Line 13:
Interface 'extendB' incorrectly extends interface 'baseB'.
Types of property 'propA' are incompatible.
Type '(arg: extendA) => void' is not assignable to type '(arg: baseA) => void'.
Types of parameters 'arg' and 'arg' are incompatible.
Type 'baseA' is not assignable to type 'extendA'.
Types of property 'prop' are incompatible.
Type 'number | undefined' is not assignable to type 'number'.
Type 'undefined' is not assignable to type 'number'.(2430)
🙂 Expected behavior

TypeScript recognizes that the two types are compatible and lets me extend the interface

This is expected behavior.  See https://stackoverflow.com/questions/30365846/why-are-input-parameters-contravariant-in-methods.

This is the correct behaviour, but you can work around it by using methods instead of function properties.
See this note
playground

Thanks for the explanation and sorry for the useless issue!


Can you help to solve this?

You could probably use this as an example. The small background dots don't do much at all, so with minimal preprocessing you can just set the exact characters to 5 and probably get pretty good results.


can not perform batch search

Using the genome finder page, I can create a genome group by pasting in a list of genome ids. I can do this in about three mouse clicks.
I can't do this on alpha.
1408180.3
1088720.3
1318634.3
1236940.3
568704.3
1078018.5
525361.3
1381116.3
1286405.4
1408205.4

#896

Spoke with Rebecca.  This is not needed for the Florida WS, bumping it to fix other bugs.

Now you can do this by selecting search option "Any Term"


How can I  call the method by the name of method?

Steps to reproduce
Tell us about your environment:

Puppeteer version:1.6.1
Platform / OS version: macOS 10.12.6
URLs (if applicable):
Node.js version: v8.5.0

What steps will reproduce the problem?
In my case，I want call the function by the name of method, but it throws UnhandledPromiseRejectionWarning
var func = page["goto"] ;   func(url);
or
var func = page.goto;   func(url);
(node:42051) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property '_networkManager' of undefined
(node:42051) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm a learner of  NODEJS，How can I make it like "page.goto(url)"，Thanks
What is the expected result?
I want it work like "page.goto(url)"
What happens instead?
(node:42051) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property '_networkManager' of undefined
(node:42051) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It seems `` needs its this preserved. You can use binding:
var func = page["goto"].bind(page);

See:
Function.prototype.bind()
Pitfall: Losing this When Extracting a Method


Fix SpatieTranslatable classes

Remove exact copies of original methods
Remove classes that are empty after duplicate removal
Update remaining method signatures so they match the original ones
Update HasTranslations to more closely follow the one from spatie/laravel-translatable

Remove custom create and update overrides so any changes in the laravel database core will not break the package
Instead handle the translation of attributes inside the setAttribute method

If the attribute key is 'locale' use it to call setLocale (in line with the removal of the 'locale' attribute inside the 'create' and 'update' methods
Otherwise if the attribute is not translatable forward it to the parent

CHECK: spatie/laravel-translatable also forwards arrays to the parent, not yet sure if this will break other features (fake fields/translatable arrays for example) so I kept this out of the current commit

Otherwise set the translated attribute

Update all variations of \Request::input('locale', \App::locale()) (and similar) to use $this->getLocale() instead (minimizes code duplication and makes it easier to update it (if required in the future))

Update Sluggable to check if the HasTranslations trait is included AND if the field is actually translatable
Update SluggableScopeHelpers

Check if the HasTranslations trait is included AND if the field is actually translatable
Use the getSlugKeyName method to return the translated attribute name instead of inlining it in scopeWhereSlug, this way other (future and custom) methods should get the correct (translated) slug attribute

Update composer.json so the dev dependencies of phpunit and orchestra/* do not break the installation of cviebrock/eloquent-sluggable:^4.3

WARNING this update only supports laravel 5.5+ using cviebrock/eloquent-sluggable:^4.3 running on PHP7+ and is made because of breaking changes in the most recent release of the sluggable package

Like the warning says it is a breaking change (it will probably have to wait for the next major release). Thing is without this the package is broken with respect to the translations/slugs if using the latest version of the sluggable package.
Maybe (for now) just use/see this as a preliminary testbed/example for the translation feature when using cviebrock/eloquent-sluggable:^4.3

Regarding the unit tests on the upgrade branch, me and @tabacitu discussed it and created an issue for it. I'll get on it as soon as I can.

@chancezeus , I'm sorry but I don't think we're going to merge this.
Thank you so much for taking the time to put together this PR, but unfortunately it doesn't seem like it's needed. In the two years that have passed, people have been successfully using the translation feature, without many issues. So it doesn't look like this refactoring is worth pursuing. As I understand it, it's a breaking change for no real benefits.
Again, very sorry, really grateful you've taken the time to submit the PR.
Cheers!


Where can I download coco_map.json? It's not mentioned in prepare_data.md.

Sorry for missing that.
You can download this from https://drive.google.com/file/d/1j19P2RNREfmtkKy9nE2-T4m-6850xCz3/view

@Lechatelia
Thank you


Access token issue.

I don't find any possibility to get access tokens anymore. Related to the updated tweepy, i didn't see mentioned the new way to get the access token.
When I have
verifier = request.GET.get('oauth_verifier')
try:
    oauth.get_access_token(verifier)
except tweepy.TweepError:
    print "Error, failed to get access token"

It always goes on exception part.

No solutions to this?

What version are you using?
Are you getting the key and secret from the request token correctly?
Show us how you are setting the values to "oauth.set_request_token" before that and verify the content of the variables too.
Regards,
Martin.

Yes, I get the keys correctly.
Which command should I use to see the version of tweepy?
https://gist.github.com/marius92mc/309ec53acbed0042c4e6

To get the current version you can do :
➜  ~  ipython
In [1]: import tweepy
In [2]: tweepy.version
Out[2]: '3.2.0'
Let me know the version that you are using and we will be able to help you.
Regards,
Martin

Hm, looks like it doesn't work to output the tweepy version.
'''
In [1]: import tweepy
In [2]: tweepy.version
AttributeError                            Traceback (most recent call last)
 in ()
----> 1 tweepy.version
AttributeError: 'module' object has no attribute 'version'
'''

Still no ideas for the issues presented by me above?

Does someone know a solution to the presented issue?

do you have your Code Posted on github?
remove the try catch statement and run the code and copy me the error?

Here You can set,
        get_token = oauth.get_access_token(session['verifier'])```
``` print(oauth.access_token)```
``` print(oauth.access_token_secret)```
if these are present then you are all set
this because oauth.request_token is not set properly.

I've rewritten the authentication documentation with https://github.com/tweepy/tweepy/commit/f9a722bae8cce368b9f8fd447c418e1034c32178, which should hopefully answer this question.
You can refer to the 3-legged OAuth section.
You can use pip show or tweepy.__version__ to check your version of Tweepy.


html2pdf Blank Page issue - Chrome

Hi @eKoopmans, html2pdf fails to detects DOM elements and i was trying to download the pdf file and the pdf has only blank pages. This is happening on latest Chrome Version it seems but not on any other browsers. Please help me out with this

Try to remove the Grammarly extension, jsPdf has some issues while generating the PDF when using Grammarly.

Hi, @rajathegde98 any other solutions? I cant tell all of our customers to remove their chrome extensions.

 //content is the angular child elem reference (if not, use **document.** methods to access div or class)         html2canvas(content,{           allowTaint:true,           useCORS:true,           scale:1         }).then(canvas=>{          // document.body.appendChild(canvas)           var width = canvas.width;           var height = canvas.height;           var img = canvas.toDataURL("image/png")           var doc = new jsPDF();           doc.addImage(img,'PNG',0,0,600,200)           doc.save()         })
    This looks fine. It's working for me, update the hardcoded values(width, height).
    I am using jsPDF and html2canvas instead.

    hope this helps you.

In the end, I took the following approach, removed the HTML tag that was injected by Grammarly & restored it after the creation of the PDF.

@danielgutin thanks daniel, It's working for me but all the contents are present except images.


NAIP request

Hello,
I had a request from foresters working on Collaborative Forest Landscape Restoration Programs in the US to use the tool. Can we add in the NAIP imagery feed as a default option (or should we as the USFS institution set this up?)

You should add new imagery feeds to your institutions. It looks like a lot of the site-wide public imagery is going to disappear soon after the talks in Rome.


执行mlc_chat指令时总是报错

帮忙解答下，感谢
Traceback (most recent call last):
File "/opt/miniconda3/envs/torch-gpu/bin/mlc_chat", line 33, in
sys.exit(load_entry_point('mlc-chat', 'console_scripts', 'mlc_chat')())
File "/opt/miniconda3/envs/torch-gpu/bin/mlc_chat", line 25, in importlib_load_entry_point
return next(matches).load()
File "/opt/miniconda3/envs/torch-gpu/lib/python3.9/importlib/metadata.py", line 86, in load
module = import_module(match.group('module'))
File "/opt/miniconda3/envs/torch-gpu/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 972, in _find_and_load_unlocked
File "", line 228, in _call_with_frames_removed
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/Users/lijieer/projects/github/mlc-MiniCPM/python/mlc_chat/init.py", line 5, in
from .chat_module import ChatConfig, ChatModule, ConvConfig, GenerationConfig
File "/Users/lijieer/projects/github/mlc-MiniCPM/python/mlc_chat/chat_module.py", line 20, in
from . import base as _
File "/Users/lijieer/projects/github/mlc-MiniCPM/python/mlc_chat/base.py", line 28, in
_LIB, _LIB_PATH = _load_mlc_llm_lib()
File "/Users/lijieer/projects/github/mlc-MiniCPM/python/mlc_chat/base.py", line 23, in _load_mlc_llm_lib
return ctypes.CDLL(lib_path[0]), lib_path[0]
File "/opt/miniconda3/envs/torch-gpu/lib/python3.9/ctypes/init.py", line 382, in init
self._handle = _dlopen(self._name, mode)
OSError: dlopen(/Users/lijieer/projects/github/mlc-MiniCPM/build/libmlc_llm_module.dylib, 0x0006): Symbol not found: __ZN3tvm7runtime7NDArray10CreateViewENS0_10ShapeTupleE10DLDataType
Referenced from:  /Users/lijieer/projects/github/mlc-MiniCPM/build/libmlc_llm_module.dylib
Expected in:      /opt/miniconda3/envs/torch-gpu/lib/python3.9/site-packages/tvm/libtvm.dylib

Please update to the latest TVM and MLC commit and rebuild everything. This issue happens when you are using mismatched TVM and MLC versions.

BTW, we have already renamed mlc_chat into mlc_llm. It looks like you are using a really old version of MLC-LLM, please try upgrading. Also, please send issue to the related project If you are using any downstream project (e.g. mlc-MiniCPM)

ok , thanks a lot


Http4s Testing Documentation

In our documentation we are lacking examples and demonstration of using http4s-testing to create unit tests for our services. We have some implementations in http4s.g8, but we should have more concrete examples that show a consensus that people can work from in the Website documentation.

@ChristopherDavenport Could you point me to http4s-testing when you have a chance? I can't seem to find it.

It's the testing subproject.  It gets published as:
"org.http4s" %% "http4s-testing" % Http4sVersion

We have Http4sMatchers, which help with Specs2.  If you search our tests for the methods therein, you'll find examples of their use.  (Aside: it's not great that our testing module has a dependency on specs2.  I think we should consider whether that's the right home.)
Other interesting things in there are the ArbitraryInstances, which go nicely with Scalacheck.  We have also started adding some laws that go well with discipline.  I suspect these are more useful inside http4s than outside, though I can imagine them being used in more advanced testing scenarios.

@rossabaker Awesome, I will play around with that! Thank you!

I've been looking around at this a little bit, one thing i'm unclear on is where these docs are supposed to live. In the docs/ folder?

Definitely seems good enough to close out this issue. If we want we can revisit arbitraries and law testing at some point in the future.


feat: UI testing framework (WIP)

WIP

Where's your thoughts on this today? Do you still want to pursue?

I've stolen some of this and put it onto the ui-v3 branch as I needed a way to test some of the complex functions. These are in *.ts files, no support for *.tsx ported.


Trinity can't connect to Parity on Ropsten in "full" mode

Systems' info
Trinity node:

py-evm: v0.2.0-alpha.6-1049-ge0864ea (although e0864ea is tagged as v0.2.0-alpha.18 - go figure!)
OS: Arch Linux
Python: CPython 3.6.5
Environment: gist

Parity node:

Parity version: Parity/v1.10.1-unstable-45c29a2-20180413/x86_64-linux-gnu/rustc1.24.0
OS: Ubuntu 16.04.4 LTS (Xenial Xerus)
Rust: rustc 1.24.0 (4d90ac38c 2018-02-12)

What is wrong?
PR #638 introduced a "full" (geth-like "fast") sync mode in Trinity. Previously, using the LES sub-protocol meant that lasting connections would be made to geth nodes exclusively; now, compatibility with other nodes should be considered.
I have tried short-circuiting the hard-coded nodes' list to force connection to a Parity node under my control (so I can get the log).
A snippet from the Trinity side (I've replaced the DEBUG log-level message with XXXXX for debug-prints not present in master):
% trinity --network-id=3 --sync-mode=full --log-level=debug

DEBUG p2p.peer.PeerPool 2018-05-18 15:51:48,992 - Connecting to <Node(0x17c1@<IP_ADDRESS>)>...
XXXXX p2p.protocol.Protocol 2018-05-18 15:51:49,006 - Sending ETH/Hello msg: {'version': 4, 'client_version_string': 'Trinity', 'capabilities': [('eth', 63)], 'listen_port': 30303, 'remote_pubkey': b'\xbd\xd6\x7f\x99U\x10\xd3sIrH\xf6/\x05\xc5&\r\xc5\xe5$\r\xf9Xc\xe3\xc4\x96:2\t\x03\x13B\x0e\xad\x08\xc1\x01s\xbf\x18\x03\x9eq<\xbc\xea\xf4\xc7":0\x89\xa9\x86\x92\xfbH\x14\x82\x9f\x16\x940'}
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,006 - Sending msg with cmd_id: 0
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,006 - Waiting for 32 bytes from <Node(0x17c1@<IP_ADDRESS>)>
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,007 - Waiting for 192 bytes from <Node(0x17c1@<IP_ADDRESS>)>
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,007 - Got msg with cmd_id: 0
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,008 - Successfully decoded Hello (cmd_id=0) msg: {'version': 5, 'client_version_string': 'Parity/v1.10.1-unstable-45c29a2-20180413/x86_64-linux-gnu/rustc1.24.0', 'capabilities': (('eth', 62), ('eth', 63), ('par', 1), ('par', 2), ('pip', 1)), 'listen_port': 30303, 'remote_pubkey': b'\x17\xc1d\x19I`\x84c^\xb5TcS\xff\x91\xd0\x11\x1f\xa5\xab\x12\xd4\xd5\x1dE\xb1\x8eD(\xcd\xe6\xf6E\xcc\xa2M\xabU\xcf\tW\xf8_\xfda\x8bx\x87\xf4W(\xac\x8f\x9e4\xf8\x18G\xef\xb5\x99\xdb$\xfa'}
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,009 - Finished P2P handshake with <Node(0x17c1@<IP_ADDRESS>)>, using sub-protocol (eth, 63)
XXXXX p2p.peer.Peer 2018-05-18 15:51:49,009 - DEBUGME
DEBUG p2p.eth.ETHProtocol 2018-05-18 15:51:49,017 - Sending ETH/Status msg: {'protocol_version': 63, 'network_id': 3, 'td': 1048576, 'best_hash': b'A\x94\x10#h\t#\xe0\xfeMt\xa3K\xda\xc8\x14\x1f%@\xe3\xae\x90b7\x18\xe4}f\xd1\xcaJ-', 'genesis_hash': b'A\x94\x10#h\t#\xe0\xfeMt\xa3K\xda\xc8\x14\x1f%@\xe3\xae\x90b7\x18\xe4}f\xd1\xcaJ-'}
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,018 - Sending msg with cmd_id: 16
DEBUG p2p.peer.Peer 2018-05-18 15:51:49,018 - Waiting for 32 bytes from <Node(0x17c1@<IP_ADDRESS>)>
DEBUG p2p.peer.PeerPool 2018-05-18 15:51:49,018 - Could not complete handshake with <Node(0x17c1@<IP_ADDRESS>)>: PeerConnectionLost("ConnectionResetError(104, 'Connection reset by peer')",)
DEBUG p2p.peer.PeerPool 2018-05-18 15:51:51,021 - Last node discovery lookup too long ago, triggering another
DEBUG p2p.peer.PeerPool 2018-05-18 15:51:51,022 - Connecting to <Node(0x17c1@<IP_ADDRESS>)>...

Parity's side is very hard to debug due to it being at the TRACE level - here's a snipped segment from a much earlier run (same happens now):
% parity --chain=ropsten --no-color  --logging="network=trace" --log-file=network-trace.log

2018-05-11 20:39:52  IO Worker #0 TRACE network  Accepting incoming connection
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Initiating session None
2018-05-11 20:39:52  IO Worker #0 TRACE network  Expect to read 307 bytes
2018-05-11 20:39:52   TRACE network  connection register; token=Token(8)
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Read 64 of 307 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Read 128 of 307 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Read 256 of 307 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Read 307 of 307 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  Received handshake auth from "<IP-V4-SNIPPED>:44786"
2018-05-11 20:39:52  IO Worker #0 TRACE network  Sending handshake ack to "<IP-V4-SNIPPED>:44786"
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Sending 210 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  Expect to read 32 bytes
2018-05-11 20:39:52  IO Worker #0 TRACE network  8: Sending 224 bytes
2018-05-11 20:39:52   TRACE network  connection reregister; token=Token(8)
2018-05-11 20:39:52   TRACE network  connection reregister; token=Token(8)
2018-05-11 20:39:52   TRACE network  connection reregister; token=Token(8)
2018-05-11 20:39:52  IO Worker #1 TRACE network  8: Wrote 210 bytes
2018-05-11 20:39:52   TRACE network  connection reregister; token=Token(8)
2018-05-11 20:39:52  IO Worker #1 TRACE network  8: Wrote 224 bytes
2018-05-11 20:39:52   TRACE network  connection reregister; token=Token(8)
2018-05-11 20:39:52  IO Worker #1 TRACE network  Accepting incoming connection
...
2018-05-11 20:39:52  IO Worker #2 TRACE network  8: Read 32 of 32 bytes
2018-05-11 20:39:52  IO Worker #2 TRACE network  Session read error: 8:Some(bdd67f995510d373497248f62f05c5260dc5e5240df95863e3c4963a32090313420ead08c10173bf18039e713cbceaf4c7223a3089a98692fb4814829f169430) (Ok(V4(<IP-V4-SNIPPED>:44786))) Error(Auth, State { next_error: None, backtrace: None })
2018-05-11 20:39:52   TRACE network  connection deregister; token=8

How can it be fixed
As @gsalgado mentioned on gitter - likely by implementing some more up-to-date handshake and/or sub-protocol. As also seen from the logs above, Trinity sends a Hello with 'version': 4; it may be that Parity only supports the (sub?)-protocol that has 'version': 5.
The documentation on these is notoriously non-specific. Documents often lack version identifiers, or assume prior knowledge.
Maybe useful links
Related issues:

#429 - Implement p2p discovery v5

Docs:

devp2p wire protocol on the EF wiki;
eth wire protocol on the EF wiki;
RLPx doc in ethereum/devp2p repo.

Approximate locations in impl-ns:

geth's eth/peer;
parity's handshake.

Cute animal pic
"Does Trinity pass the Parity test?.."

(source: Animal Cognition)

although e0864ea is tagged as v0.2.0-alpha.18 - go figure!

Eventually, py-evm and trinity will be split into separate repos, but they are already split into separate pypi release versions. So there will be weirdness in the tagging until the repos are split

@carver you likely refer to

py-evm: v0.2.0-alpha.6-1049-ge0864ea (although e0864ea is tagged as v0.2.0-alpha.18 - go figure!)

This is actually a peculiarity of git: I ran git describe without --tags, which only uses tags that have annotations.


station-delay-resource throws "Internal Server Error"

As in #1 there are changes within the API, which have to be fixed.
Pending.

Fixed by e1abe0d


Typo in example

https://hackage.haskell.org/package/testcontainers-<IP_ADDRESS>/docs/TestContainers-Docker.html#v:waitForLogLine
wairForLogLine Stdout ("Ready to accept connections" `isInfixOf`)

I think this should be waitForLogLine (t instead of r). 😺

Ah, what I forgot: Thanks a lot for crafting this library! It helps a lot with creating e.g. integration tests.

Thanks for reporting, Sven. Fixed on master!


Drag and drop: setting DragUIOverride.Caption after async code triggers a COM exception

Describe the bug
Drag and drop: setting DragUIOverride.Caption after async code triggers a COM exception that has no message.
Exception thrown: 'System.Runtime.InteropServices.COMException' in WinRT.Runtime.dll
An exception of type 'System.Runtime.InteropServices.COMException' occurred in WinRT.Runtime.dll but was not handled in user code

Without the async call it works fine. Actually, if I catch the exception, the caption is set, however the drag and drop becomes broken and works only once. The subsequent times I try to drop a file, the DragOver is called, but setting values does nothing and the file is not accepted.
Tried with release and prerelease Nuget package.
Maybe I misunderstand how to filter the file type that can be dropped and there is a way of doing it without an async call?
Steps to reproduce the bug

Create a new blank WinUI app
In MainWindow add any element (StackPanel, RelativePanel...) with AllowDrop="True" and DragOver="DragOver"
In the DragOver event handler paste the following code:

if (e.DataView.Contains(StandardDataFormats.StorageItems)
    && (await e.DataView.GetStorageItemsAsync()).FirstOrDefault() is StorageFile file
    && (file.FileType == ".xlsx" || file.FileType == ".xls"))
{
    e.AcceptedOperation = DataPackageOperation.Copy;
    e.DragUIOverride.Caption = "TEST";
}

Try dragging over an Excel file, the e.DragUIOverride.Caption = "TEST" statement will throw a COM exception

Expected behavior
The drag and drop should work without exceptions and multiple times.
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.4.4: 1.4.231219000
Windows version
Windows 10 (21H2): Build 19044
Additional context
Actual OS build: 19045.3930

Use DragEnter instead of DragOver.
The DragOver event gets dispatched many times per second until the drag stops. You are starting many instances of the handler that are all awaiting e.DataView.GetStorageItemsAsync and setting the drag properties at the same time, which is resulting in a problem somewhere.

I tried with DragEnter and setting the AcceptedOperation is not reliable, most of the time it doesn't work and the file drop isn't accepted. Also the COM exception still happens sometimes if you enter - exit - enter.
I also tried using DragOver with a semaphore to limit the number of instances of the handler to one and it didn't fix anything, the exception is still occurring.

This was interesting to play with.
After testing I came to the same conclusions as found here #8108, which describes the issue and what is happening at a lower level.
The final reply states this is "by design". I don't think that is a great way to word it, but rather this is just what happens due to how the event processing system interacts with the DataExchangeHost.
Using a synchronous handler synchronous with e.DataView.GetStorageItemsAsync().GetAwaiter().GetResult() makes the problem go away, and also results in DragEnter working reliably so you aren't processing extra events.

.GetAwaiter().GetResult() fixes the exception for me. You can close this issue if you don't need it for following up.

Closing as dup of #8108


Ansible playbook error vm_create_windows.yml

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

edited playbook with resource group name as Ansible then run playbook vm_create_windows.yml in ansible

Any log messages given by the failure

TASK [create Azure virtual network in resource group] **************************
fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'Ansible' is undefined\n\nThe error appears to be in '/var/lib/awx/projects/_14__azure_infrastructure_test/vm_create_windows.yml': line 33, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n  - name: create Azure virtual network in resource group\n    ^ here\n"}
Expected/desired behavior

success creation of virtual network
OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
ansible is on linux, linked azure to ansible and was to create a windows server 2016 in azure

Versions

Ansible 2.8
Mention any other details that might be useful
adding existing resource group fails, creating new resource group also fails

Thanks! We'll be in touch soon.

@dennopro Thank you for taking the time to report this problem! It is known from your error message that an unknown variable caused the error. Can you provide your playbook for me to try? Thank you very much!

Hello Fred,
I managed to fix this by renaming the resource group declared variable in
the playbook form "{{resource_group}}"" to "resource_group" this was in the
play book vm_create_windows.yml
and this worked out well, thanx for the followup
regards
Andrew
On Thu, Dec 5, 2019 at 3:38 AM Fred-sun<EMAIL_ADDRESS>wrote:

@dennopro https://github.com/dennopro Thank you for taking the time to
report this problem! It is known from your error message that an unknown
variable caused the error. Can you provide your playbook for me to try?
Thank you very much!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/ansible-playbooks/issues/78?email_source=notifications&email_token=AB6TESB2MOWCBMBBF4XYS4LQXBSQ3A5CNFSM4JUUXSE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7IPFQ#issuecomment-561940374,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6TESCUIZ73N2HZQMAALLDQXBSQ3ANCNFSM4JUUXSEQ
.

@dennopro Ok, thank you for your reply. If there is no other problem, can this problem be closed?

This can be closed
Regards
Andrew
On Fri, Dec 6, 2019, 03:03 Fred-sun<EMAIL_ADDRESS>wrote:

@dennopro https://github.com/dennopro Ok, thank you for your reply. If
there is no other problem, can this problem be closed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/ansible-playbooks/issues/78?email_source=notifications&email_token=AB6TESBMZVXN4VU4YL25ZZ3QXGXHZA5CNFSM4JUUXSE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGCYXFQ#issuecomment-562400150,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6TESE2OJ3AYNDHKIBYJO3QXGXHZANCNFSM4JUUXSEQ
.

close_me


Fixes User-Role being removed

The user-role was removed when a user edited his profile.
Fixes #3010 and fixes #2451
Problem introduced in #2931

I can confirm that this fix solves the issue! Thanks @emptynick!

It fixes #2451 but it brings back bug #2931 solved: not being able to reset the field.

No, #2931 is still implemented.

But it won't work for user_belongsto_role_relationship, try to remove all additional roles after you add one.

still getting this error, i assume composer doesn't have an updated package?

@AskAlice Try: composer require tcg/voyager:1.1-dev

@jpolive The problem started in the first place because role field was removed so that users can't change their role, even if that was only a cosmetic change since there is no check on the controller side, so that's still possible but just hidden.
So if you add an hidden field you can solve the problem of role not being removed but still there is no check that it's not being changed.
I hope my PR #3016 will be considered.

New installation according to the instructions and when changing the language in the profile error
Symfony\Component\Debug\Exception\FatalThrowableError thrown with message "Call to a member function relationLoaded() on null"
Stacktrace:
#0 Symfony\Component\Debug\Exception\FatalThrowableError in C:\Server\OSPanel\domains\laravel.dev\vendor\tcg\voyager\src\Traits\VoyagerUser.php:121

Just wanted to drop a line to say sorry for introducing this bug in #2931. Normally I'd fix it myself, but since I am on holiday without internet for the coming two weeks I don't think I can be of much use.


Files not Syncing - NFS.output shows "unable to send RPC reply"

cat /usr/local/Cellar/dinghy/4.5.0/local/var/dinghy-NFS.output
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply
unable to send RPC reply

$ dinghy version
Dinghy 4.5.0

Nothing relevant in logs
docker@dinghy:~$ cat /var/log/* |grep nfs
docker@dinghy:~$

Why? How can I debug?

Not sure, but I think I got to see 2 nfs process running at the same time on my mac host when this was happening. Once I restarted and there was a single process, it seemed to work properly again.

 Were both NFS processes the unfs3 daemon or was one system NFS?

I must admit it has been quite stable since last time... Maybe it is some usage pattern. I hit it more often when I run a webserver deployment with several containers (incldue dbs etc) but it is more stable when I just run a simple comtainer with a CLI tool.
Anyway, if it happens again I will check that. I seem to recall they were 2 unfs processes, but I can't be quite sure now.

Happened again, here is the ps dump:
$ ps aux |grep nfs
josvaz           23592   0,0  0,0  2465752    736   ??  S    18abr18   0:34.84 /usr/local/sbin/unfsd -e /Users/josvaz/.dinghy/machine-nfs-exports-dinghy -n 19930 -m 19930 -l <IP_ADDRESS> -p -d
josvaz            3738   0,0  0,0  2465752   4580   ??  S     7abr18  11:10.09 /usr/local/sbin/unfsd -e /Users/josvaz/.dinghy/machine-nfs-exports-dinghy -n 19299 -m 19299 -l <IP_ADDRESS> -p -d
josvaz           94844   0,0  0,0  2442376   2472 s001  S+    6:54PM   0:00.01 grep nfs

I may be encountering the same issue. I see the same log output (unable to send RPC reply). I noticed this issue because webpack-dev-server wasn't picking up file changes.
My dinghy status shows everything is running, and I see nothing out of the ordinary when starting dinghy.
Interestingly, if I invoke fsevents_to_vm alongside dinghy while it's running, webpack-dev-server works great. I know of at least one other person encountering the same problem currently. I am on dinghy 4.6.5.

Perhaps you've hit a state where the fsevents_to_vm daemon is still running but not functioning... do you see any relevant log output at /usr/local/Cellar/dinghy/4.6.5/local/var/dinghy-FsEvents.output?

From a fresh dinghy start (with fsevents_to_vm not running separately), there's nothing interesting in the FsEvents log. Just this:
=== Starting FsEvents at 2019-04-24T11:27:59-07:00 ===
Triggering some events doesn't produce any log output.
If I do run fsevents_to_vm separately, I do get output in that process showing all the files that have been touched.

That's expected that you won't see touched files in the log, fsevents_to_vm is silent by default and only prints touch events if you pass --debug. That's too bad that there's no relevant crash information though. I don't have a great theory for why the daemon process wouldn't work but a manually-run process would.
Maybe I should add an option to dinghy to pass the --debug option through to the daemon process. In the meantime you could modify /usr/local/Cellar/dinghy/4.6.5/cli/dinghy/fsevents_to_vm.rb and add --debug to the args array near the bottom, then dinghy restart. That should print touch events to FsEvents.output and we can at least verify if events are being generated.

Good thinking. Can confirm that with --debug output in the dinghy fsevents process, I'm seeing output for touched files. (Also verified I'm still seeing the same behavior)

hmm if it's logging the file touches but not logging any errors, I really don't know how it could be failing in a way that wouldn't also affect an independently-run process. Is the problem consistent, or does it sometimes work on the affected macs?
Also, how long did you watch the log output for? I'm just thinking that I'm not entirely sure what the default timeout is for Net::SSH if it is having trouble connecting. Could be 30-60 seconds or something.


server settings wont save

whenever I install the plugin and put in the Home Assistant Server URL and Access Token it connects properly and lets me see my entities. However when I hit save at the bottom, it does not save. It simply does nothing. Then when I go back to the button, all the settings are gone.
Help please!

Also seeing the same behavior.

Which OS and SW Version are you using?

Sorry, that would help. Streamdeck version is 6.3.1 (18954) and os is 13.5.1 (22G90)

@mistermist8 are you using macOS, too?

yes, Ventura 13.5.1 (22G90). I also tried on a windows 11 PC and the plugin wouldn't install from streamdeck marketplace. Other plugins install fine.

I just completely removed StreamDeck and deleted all related folders and registry keys. After reinstalling StreamDeck, downloading the plugin from the marketplace and entering valid URL and Token, it works as expected. :/
Unfortunately i have no mac to try this.