Add missing session.commit()

Includes #341
Once #341 merged, can merge main to reduce diff.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

106 of 131 (80.92%)  changed or added relevant lines in 10 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.09%) to 86.007%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/dependencies.py
1
2
50.0%

app/routers/applications.py
27
28
96.43%

app/routers/guest/applications.py
29
31
93.55%

app/routers/downloads.py
1
4
25.0%

app/aws.py
11
15
73.33%

app/routers/users.py
11
25
44.0%

Files with Coverage Reduction
New Missed Lines
%

app/routers/users.py
2
55.45%

app/routers/downloads.py
2
42.86%

app/routers/applications.py
4
93.71%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.09%

Covered Lines:
1807

Relevant Lines:
2101

💛  - Coveralls

FYI while testing this I noticed e96197a

Yeah, looks like I introduced that during a refactoring in https://github.com/open-contracting/credere-backend/commit/ed62ef03c4d8bac3c22d637e0019f90aafb39665


Added session authentication to sync

Motivation
Securing the sync requests with session validation.

@paolobueno Small PR. Time for a review?

Going to go ahead and publish these to the cluster once again!


[REQ] Fritter on Apple Devices

Today I installed Fritter for the first time ever on my Android device, and it couldn't be better! I like how it allows me to use Twitter in a more private, less-distracting way. I recently bought an iPhone and in a few days won't have access to my Android device anymore. I wish Fritter was available on iOS, I liked the app so much I was thinking about donating frequently, but it won't be possible if an iOS version don't come out.

Please see issue #55. There's a fair bit of discussion on it there - the main points being that I don't have any Apple devices to develop or test on.
I'm definitely open to releasing Fritter for iOS, and have written the application with as much platform-independent code as possible, but there are some hurdles to get over first!


Website: size of fonts

Hello,
I'd just like to say that the font-size of the homepage (https://stimulusjs.org/) is way too big.

Plus, the unzoom/zoom only works on a part of the website, this one:

Stimulus is a JavaScript framework with modest ambitions. It doesn’t seek to take over your entire front-end—in fact, it’s not concerned with rendering HTML at all. Instead, it’s designed to augment your HTML with just enough behavior to make it shine. Stimulus pairs beautifully with Turbolinks to provide a complete solution for fast, compelling applications with a minimal amount of effort.

The rest of the website is (un)zoomable.
It could be great to use (r)em for the font-size and adjust this to the resolution of the screen. :)

Thanks, we made a few adjustments.

I'd just like to say that the font-size of the homepage (https://stimulusjs.org/) is way too big.

Ditto for your browser window!

Thank you @javan :)


[HW] Adesh Bhosale

Name: Adesh Bhosale
Email<EMAIL_ADDRESS>/<EMAIL_ADDRESS>Linkedin Profile: www.linkedin.com/in/adesh-bhosale-b0b344140
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:
-- image removed by team --
Thank you for the amazing Session lot to learn in these session please try to do more session in future also,
thanks a lot @DatastaxDevelopers @Datastaxdevs

Hey Adesh Bhosale, great job! Congrats!  Please delete your token from the Astra UI so there are no security issues.

Thank you for the amazing Session lot to learn in these session please try to do more session in future also,
thanks a lot @DatastaxDevelopers @datastaxdevs
Thank you very much for the kind words. We will definitely have more sessions coming in the future. Anything in particular you are interested in seeing?


Problem of building own dataset

Hi, I'm trying to build a xarray dataset with mine own data, and the code is as following:
`numpy_array = data
lons = np.linspace(-180, 180, 73)
lats = np.linspace(87.5, -87.5, 71)

# mydatetime=
# dims = ('batch', 'time', 'channel', 'longitude', 'latitude')
times = pd.to_timedelta([f'{i:2d}:00:00' for i in range(data.shape[1])])
datetimes = pd.date_range(start=f'{start_year}-01-01', end=f'{end_year}-12-31 23:00:00', freq='H')

coords = {
    'batch': range(data.shape[0]),
    'time': ('time',times),
    'channel':[0],
    'lon': ('lon', lons),
    'lat': ('lat',lats),
    'datetime': (('batch','time'), [datetimes])
}

data_vars = {'Temp': (('batch', 'time', 'channel', 'lat', 'lon'), numpy_array[:, :, 0:1, :, :])}
xr_dataset = xarray.Dataset(data_vars=data_vars, coords=coords)`

but  in the result dataset ,
the coord "datetime" which type is xarray.DataArray has own coords and dims "batch" and "time" , such like:
<xarray.DataArray 'datetime' (batch: 1, time: 17544)> Size: 140kB
array([['2020-01-01T00:00:00.000000000', '2020-01-01T01:00:00.000000000',
        '2020-01-01T02:00:00.000000000', ...,
        '2021-12-31T21:00:00.000000000', '2021-12-31T22:00:00.000000000',
        '2021-12-31T23:00:00.000000000']], dtype='datetime64[ns]')
Coordinates:
  * batch     (batch) int64 8B 0
  * time      (time) timedelta64[ns] 140kB 00:00:00 ... 730 days 23:00:00
    datetime  (batch, time) datetime64[ns] 140kB 2020-01-01 ... 2021-12-31T23...

However if I load the example dataset "source-era5_date-2022-01-01_res-0.25_levels-37_steps-01.nc", whose coord "datetime" has "batch" and "time" dims  ,but only the "time" coord.  such like ：
<xarray.DataArray 'datetime' (batch: 1, time: 3)> Size: 24B
array([['2022-01-01T00:00:00.000000000', '2022-01-01T06:00:00.000000000',
        '2022-01-01T12:00:00.000000000']], dtype='datetime64[ns]')
Coordinates:
  * time      (time) timedelta64[ns] 24B 00:00:00 06:00:00 12:00:00
    datetime  (batch, time) datetime64[ns] 24B 2022-01-01 ... 2022-01-01T12:0...
Dimensions without coordinates: batch

So my question is how to remove the coord "batch" of the datetime in my dataset?
Thanks a lot!
Sincerely, Qc

Try to use .squeeze() on your dataset, it should remove the dependence.

Try to use .squeeze() on your dataset, it should remove the dependence.

Thank you for your reply!
I have tried by run:
xr_dataset.coords["datetime"].squeeze()
The result is no changed.
There's the coord 'batch in the  "datetime"
if I run the : xr_dataset.squeeze() , it will remove all the dims=1 , which is not my option
Qc


Update samples/template to top-level statements

PR Details

Description
This PR applies top-level statements to samples and template generator to generate less boilerplate code
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

I would keep the namespace though.
It can be a single line as well, for instance:
using Stride.Engine;

namespace SimpleAudio;

using var game = new Game();
game.Run();

I have been removing gradually namespaces from everywhere in my all C# projects start up files. I haven't had yet the need to reverse or wonder what namespace should be there.
Empty end line should be consistent across solution, that's right.

@Kryptos-FR Done and its ready to merged 😊

Thanks !


Upload to Mihin

Updated fhir_at_rest, and added new version
Still uploads to Hapi
Still saves local copy
Still displays saved questionnaireResponse
It will save to Mihin, but only one at a time
I can upload each QuestionnaireResponse individually, but not all together as a bundle

Just some updating. When save button pressed, gives option to upload to hapi or mihin, or saves yaml locally, and then displays it.

Just some updating. When save button pressed, gives option to upload to hapi or mihin, or saves yaml locally, and then displays it.

So I tried something different. I created a controller for the services. It creates snackbars alerting you to the progress, but only that it's been started, and then if there's an error or it's completed successfully (not the multiple others that Ryan suggested - that seemed overly complicated for now). I can change it to alert in another way, but all of the services now return something to let you know if it's successful.

So I tried something different. I created a controller for the services. It creates snackbars alerting you to the progress, but only that it's been started, and then if there's an error or it's completed successfully (not the multiple others that Ryan suggested - that seemed overly complicated for now). I can change it to alert in another way, but all of the services now return something to let you know if it's successful.


Docker

I wish there were directions to docker compose file and image on the Devhub i.g. for quick checks or for those who build on the top of a node: smart contracts or front ends

Closing because this is not totally actionable. Would the docker image be just for running a node or for developing on it. If just running, then which node would it run. Feel free to re-open in the new cms repo.


Use the raw_lines field in stackprof for more precise lines

Since https://github.com/tmm1/stackprof/pull/213 the actual source line within the method, not just the method start line, should be available.
From the existing simple.rb:
https://github.com/jlfwong/speedscope/blob/d69f3d0eec29d1d1aeb725b97de3a5209f85447a/sample/programs/ruby/simple.rb#L32-L34
On main, it just gives the method start line:

With this patch, we get the actual line number of the call:

I've added some rhudimentary tests, to cover both older stackprof files that are missing raw_lines, and newer ones that have it. I basically just walked "children[0]" manually until i found a node with a line. Since the file is checked in, i think this is fine.
EDIT: addressing frame collisions
As called out in https://github.com/jlfwong/speedscope/pull/483#issuecomment-2406515797, my first commit could lead to collisions due to frames that were not identical using the same key.  This is addressed in 136dd990ba0447608ec366fd7db1f7dd14a6de5c
Looking at the following code:
https://github.com/jlfwong/speedscope/blob/d69f3d0eec29d1d1aeb725b97de3a5209f85447a/sample/programs/ruby/simple.rb#L3-L10
On main, we only see the frame info showing a calling from line 4:

But now, we have two different frames for a, one with line 5, and one with line 8:

In a more pathological example, I modified simple.rb to insert a sleep on line 16 to show how previously we would in fact lose information. Here is a graph on main:

Here it is with the patch:

We can see that with the patch, it correctly shows the call sight of "sleep" and is able to distinguish these code paths, one for line 16 where sleep is actually called, and one for line 13 for the other code path and indeed another on line 14 for the other instance of b. Previously these would all have had the same value. The graph has more nodes, and we are able to have different instances of the "b" frame.

Hi @dalehamel! Thanks for the patcH
It looks like the new test file wasn't checked in:
Summary of all failing tests
FAIL src/import/stackprof.test.ts
  ● reads correct line numbers › uses the most precise iseq line if raw_lines is available

    ENOENT: no such file or directory, open './sample/profiles/stackprof/wall_with_raw_lines.json'

      at Object.openSync (node:fs:596:3)
      at readFileSync (node:fs:464:35)
      at src/import/stackprof.test.ts:64:37
      at src/import/stackprof.test.ts:8:71
      at Object.<anonymous>.__awaiter (src/import/stackprof.test.ts:4:12)
      at Object.<anonymous> (src/import/stackprof.test.ts:63:80)

Oh hm, one consideration here: other profile imports intentionally use the line number of the method definition, not the line of the invocation. This prevent things from getting confusing when e.g. you have stacks that look like:
a;b
a;c

If a() calls b() on line 7, and a() calls c() on line 8, what should be displayed here? Speedscope considers frames with the same key to be identical for display, and collapses them into a single entity

It looks like the new test file wasn't checked in:

Whoops, i amended the commit but forgot to push.

One possible solution would be to include the line number as part of the key. Looks like it accepts a string, so a quick and dirty way to prevent the collisions would be to append the line number to the frame id, eg:
diff --git a/src/import/stackprof.ts b/src/import/stackprof.ts
index bd20c5d..e4cd7f5 100644
--- a/src/import/stackprof.ts
+++ b/src/import/stackprof.ts
@@ -39,8 +39,9 @@ export function importFromStackprof(stackprofProfile: StackprofProfile): Profile
       if (frameName == null) {
         frameName = '(unknown)'
       }
+      const key = id.toString(10) + "_" + lineNo.toString(10);
       const frame = {
-        key: id,
+        key: key,
         ...frames[id],
         line: lineNo,
         name: frameName,

This addresses some weirdness I was seeing in one of my profiles which I think was what you called out. This is one solution to ensure that they are keyed differently. I'll get into a bit more detail about this in a bit.

@jlfwong please take another look - i updated the description to address the collision issue you pointed out. I believe I have come up with a keying strategy that should resolve this.
Unfortunately it changes the key from a number to a string, as a general rule I prefer integers for performance reasons but in this case due to number only permitting 53 bits, there is no way to stuff all the info in without the possibility of truncation. So use a similar trick as in https://github.com/tmm1/stackprof/pull/213 to stuff the frame and line number together, but have to convert the result to a string.
If we were to update https://github.com/jlfwong/speedscope/blob/d69f3d0eec29d1d1aeb725b97de3a5209f85447a/src/lib/utils.ts#L46-L49 to permit BigInt in addition to string and number, we can avoid this conversion but I'm not sure if there might be unintended consequences to this. For now, since the keyed set accepts strings, I just use convert the resulting BigInt to its base 10 string representation.

@jlfwong last ping I'll give, when you are able to take a look let me know but I'm moving on to other work and running a forked version for now.

Hey, sorry I've been MIA
Only have a couple minutes right now, but I think I may not have communicated my concern here correctly.

Oh hm, one consideration here: other profile imports intentionally use the line number of the method definition, not the line of the invocation. This prevent things from getting confusing when e.g. you have stacks that look like:
a;b
a;c
def a
b
c
end
If a() calls b() on line 7, and a() calls c() on line 8, what should be displayed here? Speedscope considers frames with the same key to be identical for display, and collapses them into a single entity

When I was describing the problem here, my concern is that, IMO, we want these two "a" frames to be collapsed. If I understand this change correctly (which I might now), then it would treat those two "a" frames as distinct by giving them different keys since their line numbers will be different if we use their invocation sites of b & c respectively rather than using the definition line of a in both cases.
This has minor annoyances for visual display, but creates bigger problems for aggregate statistics. For example, if this was the whole trace, then the sandwich view would read "50% a, 50% a" instead of "100% a".
Am I misunderstanding the nature of this change?

IMO, we want these two "a" frames to be collapsed

FWIW I rolled this out internally a couple of weeks ago, and the response has been positive - developers that I work with seem to prefer to be able to follow the execution more precisely by having the actual call sites in the graphical views.

then it would treat those two "a" frames as distinct by giving them different keys since their line numbers will be different if we use their invocation sites of b & c respectively rather than using the definition line of a in both cases.

Yes

This has minor annoyances for visual display, but creates bigger problems for aggregate statistics. For example, if this was the whole trace, then the sandwich view would read "50% a, 50% a" instead of "100% a" for total time.

Yes, this does happen. They are displayed with the same name, but then on clicking on them, you can see there are different line numbers. I agree this messes up the "top table" part of the sandwich view, as a frame that has multiple call sites can now be showed below a frame that only has one, but actually has a lower total overall weight. Perhaps the top table code could be amended to just use the frame names as the "key" when performing the aggregation in the table, but show the distinct call sites in the actual sandwich graphical view.
In the "pprof" format, it is possible to store both the method definition line as well as the actual call line. Perhaps a compromise would be to amend the data structures to be able to store both, and have an option to toggle exact line numbers, or line numbers of the method definition only.

developers that I work with seem to prefer to be able to follow the execution more precisely by having the actual call sites in the graphical views.

Ah I see. I hadn't understood that this was an intentional behavioral change, not just an update to which number is displayed in the interface (i.e. this actually produces structurally different flamegraphs, not just flamegraphs with different line number labels).
I'm afraid that I'm uncomfortable merging this PR as-is then. The rest of speedscope assumes that the line number is the line number of the function definition, not the line number of the invocation. It's interesting that the developers you've been working with have appreciated the change, but I would personally be quite bothered by this (especially if it was inconsistent depending on what file format was imported).
The thing I could easily get on board with is for speedscope profiles to contain both the function definition line and the call site line. But that's a different change than this.
In that world, the function definition line lives, as it does today, in Frame. The call site line, which would be newly introduced, would live in CallTreeNode. Frames correspond to functions, and are reused at many places in flamegraphs. CallTreeNode instances on the other hand correspond 1:1 with flame graph nodes.
Depending on the circumstance, we would use one v.s. the other. The only view that seems to me like it should unambiguously use the call site line number is the back trace view that's shown when you click on a rectangle in the time ordered view


sap_install_media_detect: fix incorrect detection of the file type of file SWPM20SP16_0-80003424.SAR

With the file command, version 5.33 (as present in RHEL 8), the file type of file SWPM20SP16_0-80003424.SAR is displayed as:
DIY-Thermocam raw data (Lepton 3.x), scale 12345-12345, spot sensor temperature 0.000000, color scheme 123, calibration: offset<PHONE_NUMBER>1234567890123456789012345678.123456, slope<PHONE_NUMBER>12345678901234567890123.123456
(I replaced the actual numbers by generic ones).
So we need to make the role independent of this behavior of the file command.
The file type of file SAPCRYPTOLIB_32-10010845.SAR is displayed as SAPCAR archive data. All other sapcar files I tested are displayed with the file type of data.
The file command, version 5.11 (as present in RHEL 7) and the file command, version 5.39 (as present in RHEL 9) are both displaying file type of file SWPM20SP16_0-80003424.SAR as: data.
The file command, version 5.44 (as present in Fedora 39) is displaying the type of file SWPM20SP16_0-80003424.SAR as: SAPCAR archive data.

As long as it's just this file SWPM20SP16_0-80003424.SAR, we can solve the problem by creating the swpm subdirectory whenever the role parameter sap_install_media_detect_swpm is set.
But we also should modify the file type detection of sapcar files inside the sapcar tool, to avoid an erroneous behavior of the role due to the wrong file type detection of future sapcar files by the file utility.

Solved in #522 and #526.


HHH-10186 - Session.load enhanced entity with eager collection loadin…

…g mapping failded with PropertyAccessException reproducing test.
The issue is already fixed in the meantime, so it can be closed. Maybe this unit test is important for regress

@VladoKuruc reported the issue fixed, and the test uses features of Hibernate that have been removed in the meantime.


Fix crash when stopping Stream if IEX wasn't enabled

The following line in the current code is problematic:
https://github.com/Ladinn/algotrader/blob/492b9fa4732a0bbba74313733c4db1711bb838ce/objects/data/Stream.js#L114
This is because, unless the Stream object was created with iex enabled, the socket will not be initialized, as shown:
https://github.com/Ladinn/algotrader/blob/492b9fa4732a0bbba74313733c4db1711bb838ce/objects/data/Stream.js#L98-L106
This PR checks to see if this.iex is set before attempting to disconnect the socket, preventing the crash.

Thanks for catching this! I really appreciate the support!


Call view and target komapper entity

Use case
Sometimes, we want to create a view with the same structure as a Komapper Entity.
However, instead of creating another Komapper Entity to interact with the view, it will be nice to give the name of the targeting view and return a Komapper Entity
Describe the solution you'd like
Something  like :
@KomapperEntity
@KomapperTable("guild_member")
@Serializable
public data class GuildMember(
    @KomapperId
    val guildId: Int,
    @KomapperId
    val entityId: String,
    @KomapperCreatedAt
    @Serializable(with = InstantSerializer::class)
    val createdAt: Instant = Instant.EPOCH,
)

fun getMembers(guildId: Int): Flow<GuildMember> {
    val meta = _GuildMember.guildMember

    val query = QueryDsl.from("guild_members_with_owner", meta).where {
        meta.guildId eq guildId
    }

    return database.flowQuery(query).filterNotNull()
}

The structure of guild_members_with_owner must match the structure of the Komapper  entity
Versions

Komapper: 1.8
Kotlin: 1.8.10
JVM: 17
JDBC Driver or R2DBC Driver: R2DBC
Database: Postgres

You can use the clone function.
Try the following code:
fun getMembers(guildId: Int): Flow<GuildMember> {
    val meta = _GuildMember.guildMember.clone(table = "guild_members_with_owner")

    val query = QueryDsl.from(meta).where {
        meta.guildId eq guildId
    }

    return database.flowQuery(query).filterNotNull()
}


can't build app for windows if the app uses netconf driver

Hi Carl
this is the follow-up issue I've described in the issue 54
the next issue I ran into - I can't build my app for windows platform
to be honest I've never tried it before so maybe I'm doing something wrong
this is what i was trying to do and the result
> GOOS=windows GOARCH=amd64 go build clear_ipsec.go
# github.com/scrapli/scrapligo/driver/base
../../driver/base/new_windows.go:43:22: d.TimeoutSocket undefined (type *Driver has no field or method TimeoutSocket)
../../driver/base/new_windows.go:44:22: d.TimeoutTransport undefined (type *Driver has no field or method TimeoutTransport)

my code
       d, _ := netconf.NewNetconfDriver(
		"<IP_ADDRESS>",
		base.WithAuthStrictKey(false),
		base.WithAuthUsername("clear_ipsec"),
		base.WithAuthPassword("strongpassword"),
		base.WithPort(22),
		//base.WithTimeoutTransport(20),
		//base.WithTimeoutSocket(20),
		base.WithTransportType(transport.StandardTransportName),
	)

	d.Open()

as you can see I've tried to play with Timeouts (commented out) but with no success

:wave:
Hey Nikolay!
I'll respond to the other issue probably this weekend, but this one was easy enough 😁
You're lucky this was an easy one since I don't care at all about windows hahah. Anyway, just pushed a commit to main branch that should sort it out. Basically was just some cruft that was left over from overhauling some of the transport stuff a few months back. Since I don't care about/test/support windows (and never will!!!!! 🤣 ) it got missed.
Let us know if this commit sorts it out. Basically just setting the defaults instead of assigning from driver object -- then the options get applied toward the end of that function.
Carl

Hi Carl
Yes it does work now
Thx
p.s I like your attitude to windows :)

Awesome, thanks for confirming!


Node SDK Sync - Bump for 65551e0 - v0.10.0

Going to close this PR out while we wait for a fix to the deno stuff and then we can push a clean 0.10.0


Move tests to one location

Current we have tests in the following locations:
test/
tests/
test-errors/
libs/lang-test0
libs/format-test

We should move them to one place and name them a little more clearly.

Yes!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Richard Knoll<EMAIL_ADDRESS>Sent: Tuesday, October 4, 2016 7:41:14 PM
To: Microsoft/pxt
Subject: [Microsoft/pxt] Move tests to one location (#422)
Current we have tests in the following locations:
test/
tests/
test-errors/
libs/lang-test0
libs/format-test
We should move them to one place and name them a little more clearly.

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F422&data=01|01|jhalleux%40microsoft.com|67cb0372c066429562aa08d3ecc9136d|72f988bf86f141af91ab2d7cd011db47|1&sdata=kHwQPCWxUWksWpdUW8eFMLLIgGnh4WE6gV6B1A6Ig%2BM%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4Kasb7uzdSMhpeiiykGnpvzn0yXPiks5qww5KgaJpZM4KOXX6&data=01|01|jhalleux%40microsoft.com|67cb0372c066429562aa08d3ecc9136d|72f988bf86f141af91ab2d7cd011db47|1&sdata=VSz0qE1mMHf3Eb35JZhB3mXuoGdw%2Bm1gHA2MwOa7hAA%3D&reserved=0.

Closing. Important issue but need not be tracked as a issue


I2C interfering with SimpleFOC ?

Okay i added my I2C-Client code to my Split_Hoverboard_SimpleFOC and it runs :-)
But the motor now heavily stutters :-(
I guess the SimpleFOC::I2CCommander has not yet been tested with the GD32-Arduino Core ?
Will investigate the next days. @Candas1 if this does not interest you this might be an Issue for my repo and @robcazzaro might like to also contribute to the final step of making a user friendly hoverboard firmware.
https://github.com/RoboDurden/Split_Hoverboard_SimpleFOC/blob/main/include/Pilot.h
https://github.com/RoboDurden/Split_Hoverboard_SimpleFOC/blob/main/src/PilotI2c.cpp
main.cpp
#include "Hoverboard.h"
#include "PilotI2c.h"

Hoverboard oHoverboard;
PilotI2c oPilot(oHoverboard);  // Pilot will call Hoverboard::Move(float fTarget)

setup()
{
  oHoverboard.Init();
  oPilot.init(8);   // iI2cAdress of hoverboard split board
}

This function in twi.cpp::i2c_init(i2c_t *obj, PinName sda, PinName scl, uint8_t address) is causing the problem:
    /* I2C address configure */
    i2c_mode_addr_config(obj->i2c, I2C_I2CMODE_ENABLE, I2C_ADDFORMAT_7BITS, address);

void i2c_mode_addr_config(uint32_t i2c_periph, uint32_t mode, uint32_t addformat, uint32_t addr)
{
    /* SMBus/I2C mode selected */
    uint32_t ctl = 0U;

    ctl = I2C_CTL0(i2c_periph);
    ctl &= ~(I2C_CTL0_SMBEN);
    ctl |= mode;
    I2C_CTL0(i2c_periph) = ctl;
    /* configure address */
    addr = addr & I2C_ADDRESS_MASK;
    I2C_SADDR0(i2c_periph) = (addformat | addr);
}

If i comment the last line I2C_SADDR0(i2c_periph) = (addformat | addr); , the motor is spinning nicely again.
And that is nothing but
#define I2C_SADDR0(i2cx)              REG32((i2cx) + 0x00000008U)      /*!< I2C slave address register 0*/
Don't understand how the hardware i2c can block the SimpleFOC.
No matter if i use my IrqMotor or the BLDCMotor.
As you @Candas1 like that SimpleFOC::I2CCommander, will you test this soon ?

More respect please. Some of the people that worked on this might end up reading this.

More respect please. Some of the people that worked on this might end up reading this.

short answer: WWTDD (What would Tyler Durden do)
the long answer would take at least ten pages and already by page 2 would it be clear that you do not want to understand anyway.
I fear the stuttering again is a interrupt priority issue.
I might want to derive a HallSensor without GD32-Arduino Interrupts that simply checks the three hall states from the 16 kHz IrqMotor ADC_CMP_IRQHandler -> pIrqMotor->IrqHandler()
I also do not like that general SmoothingSensor which makes use of the lowpass filter in BLDCMotor. With my own HallSensor i could add the smoothing with less code bytes i guess.
But decreasing the I2C interrupt priorities has only little effect:
  nvic_irq_enable(I2C0_EV_IRQn, 3, 3);
  nvic_irq_enable(I2C0_ER_IRQn, 3, 3);

So i am not sure that the stuttering comes from the HallSensor callbacks not getting called immediately.
Increasing my IrqMotor from 3,3 to 2,1 also did not do much.
But upping to nvic_irq_enable(ADC_CMP_IRQn, 1, 3) made the stuttering less evil.
But i can only experiment at T4 (target 4.0 Volt) !

But when stuttering, the speed does not get so crazy with my IrqMotor than with BLDCMotor running in the loop():
BLDCMotor (the high loop times are also strange. I2C seems to take a long time..)
v: 3.81         loop us: 313
v: 10.75        loop us: 9110
v: 18.43        loop us: 9184
v: 17.02        loop us: 9095

IrqMotor:
v: 3.68 loop us: 10437
v: 3.52 loop us: 10740
v: 3.52 loop us: 10749
v: 3.56 loop us: 2061

So getting nice time delays again might only show that the higher priority of my IrqMotor at least made the motor running smoother (less stuttering) again.
But when i pull the usb cable from my notebook that powers the ESP32, the motor gets super smooth again :-/
Ideas welcome !

Okay i had the oPilot.init(8); coming after oHoverboard.Init() :-(
And of course the I2C priorities should be reset in PilotI2c:
void PilotI2c::init(byte iI2cAdress)
{
	pPilotI2c = this;
	Wire.begin(iI2cAdress);                // join i2c bus with address #8
	// ArduinoCore:	nvic_irq_enable(I2C0_EV_IRQn, 1, 3);
	// 				nvic_irq_enable(I2C0_ER_IRQn, 1, 2);

	nvic_irq_enable(I2C0_EV_IRQn, 3, 3);	// to not block IrqMotor nvic_irq_enable(XY_IRQn, 1, 2);
	nvic_irq_enable(I2C0_ER_IRQn, 3, 3);

	Wire.onReceive(ReceiveEventPilotI2c); // receiveEvent called when data from master received
	Wire.onRequest(RequestEventPilotI2c); // called when master requests data from this slave
}

Now my IrqMotor is again spinning nicely with I2c communication running :-)
@Candas1 , The BLDCMotor however still heavily stutters !
Next step is finding a future-proof I2c protocol and publish a demo arduino .ino file to spin the motors forward and backwards.

Now ESP32 is controlling via I2C:
https://github.com/RoboDurden/Split_Hoverboard_SimpleFOC/blob/main/arduino examples/ESP32_Mini_S2_I2c_Master/ESP32_Mini_S2_I2c_Master.ino
  if (iTimeHoverReady)
  {
    oMaster2Slave1.iCmd = CMD1_Speed;
    oMaster2Slave1.fValue = 0.10 * (ABS( (int)(((iNow-iTimeHoverReady)/20+100) % 400) - 200) - 100);   // repeats from +5.0 to -5.0 to +5.0 :-)
    OUT2T("\tiCmd",oMaster2Slave1.iCmd);
    byte iError = HoverSend(I2C_SLAVE_ADDR,oMaster2Slave1);
    if (iError != 0)
    {
      OUT2N("arduino: i2c transmission failed, timeout error code",iError)
    }
  }

  if (HoverRequest(I2C_SLAVE_ADDR,oSlave2Master))
  {
    if (!iTimeHoverReady && (oSlave2Master.iStatus & HOVERSTATUS_Ready)  )
      iTimeHoverReady = iNow;

    OUT2T("iCmdLast",oSlave2Master.iCmdLast);
    OUT2T("fRpm1",oSlave2Master.fRpm1);
    OUT2N("fCurrent1",oSlave2Master.fCurrent1);
  }
  else
  {
    OUTN("\narduino: CRC fail or too less received");
  }

https://github.com/RoboDurden/Split_Hoverboard_SimpleFOC/blob/main/src/PilotI2c.cpp#L81
I have defined 3 structs for communication:
#define CMD1_Speed 1
struct __attribute((__packed__)) Server2Hover1
{
  uint16_t iCmd = 0;
  float fValue = 3.14;
} ;

struct __attribute((__packed__)) Server2Hover2
{
  uint16_t iCmdType = 0;
  float fValue1 = 3.14;
  float fValue2 = 42.0;
} ;

#define HOVERSTATUS_Ready 1
struct __attribute((__packed__)) Hover2Server
{
  byte  iVersion = 0;
  uint16_t iCmdLast = 0;
  byte  iStatus = 0;
  float fCurrent1 = 0;
  float fRpm1 = 0;
} ;

So there can be future commands to set the battery voltage or 2-value commands to set speed+steer
Problem still is that when the ESP is restarted, Hoverboard must also restart otherwise the I2C communication hangs.
Restarting the Hoverboard is okay, after 3 seconds calibration time, the incoming ESP comands get accepted again.
I am going to continue this issue on my https://github.com/RoboDurden/Split_Hoverboard_SimpleFOC/issues
I think Candas does not want to do a general hoverboard firmware. Which is okay as he wants to focus on the SimpleFOC library for his robot projects :-)
@Candas1 would be nice if you update your main branches in the next days.
Ideas welcome.

No it has nothing to do with the robotic project.
Position control and encoder support is already available in Simplefoc.
I want to focus on things where I add more value, improving the motor control.
Now any developer can use my work and build whatever firmware he wants.
I spent enough time supporting a firmware.
The next version of SimpleFOC is supposed to go out any time soon. I want to include all the latest fixes when I deploy to the main branch.
I haven't touched the GD32 branch in a while as it's only for the drivers, and I don't have feedback about the arduino-gd32 issues. If I add new features to Simplefoc, I will do it first on stm32, then only I will add it to the GD32 dev branch.

Yes i am happy if you stay focused on the SimpleFOC libray !
And i am happy that you took the EFeruFOC firmware upon you !
Have you made some critical updates to the GD-Ardruino-Core that is not going to be merged ?
Then my firmware can not access it with some added #xy to
platform = https://github.com/CommunityGD32Cores/platform-gd32.git
platform_packages = framework-arduinogd32@https://github.com/CommunityGD32Cores/ArduinoCore-GD32.git

??

The only work pending there on the drivers is depending on the fixes from the arduino-gd32 project.
But of course I will have to synchronize any fixes from the simpleFOC project to the gd32 branch.

The latest SimpleFOC changes were just released to their Master branch.
I synched all my branches, I only tried to compile, didn't do more tests.

I will continue working on the dev branch, and push improvements to dev-gd32.
I haven't updating this repository yet, I don't think anybody is using it.

Great, thank you.
I will test your main arduino-foc.. branches today :-)
Your repo he will be important for me to see your init parameters in main.cpp.


Rename vendored folder from "vendor/_nuts" to "internal"

Currently nut vendors source code to "vendor/_nuts". As discussed in this thread, let's standardize it to "internal". The following changes are needed:

rename the folder to "internal"
don't pull in Go tests for dependencies

The second changes will get go test ./... to work without running dependencies' tests.

why not let the user decide on the package name using a command line flag BTW?  you can default to internal

why not let the user decide on the package name using a command line flag BTW?

As you may read from the discussion linked in the issue, we're trying to standardize the folder of the vendored dependencies across all vendoring tools. I'm afraid this is a hard requirement. The point is that other tools will still work.

I agree that this should be the default but there isn't really a reason not to let people override it if they have a good reason to do it. Anyway it's no big deal either way.

Did this in #11 - no config, just hard coded


Adding support for non-static MAC learning entry

NewOfpFlowModAddNonStatic() - Adding support for flow entry 'idle_timeout' second.

It is already covered in IdleTimeout argument in NewOfpFlowModAdd() existing gofc. So I am closing this issue.


Questions: does Winds have a limit on the age of unread items?

I'm currently looking into Winds as a replacement/enhancement for Inoreader.
Overall I like Inoreader, but one thing that really bothers me with it is that items are automatically marked as read after 30 days or so. I have some feeds that I like to binge through only very infrequently (every few months), so this causes me to lose track of their items.
Does Winds have this limitation?
Also, do you have a suggestion on how I can integrate Winds with Inoreader to get the best of both?
Thanks!

Right now Winds doesn't set articles read/unread status, but it's a planned feature and functionality is partially implemented.
Articles never expires in Winds, so you have access to all of your feeds data.
If Inoreader allows you to export your feeds as an OPML file, you can easily import all of your feeds into Winds

Is there an issue where I can get notifications on the progress of the read/unread feature?
Winds looks great, but not tracking the read/unread status is a blocker for me.
Thanks


fix(select): fix mobily styles specificity

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.006%) to 84.517%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
9363

Relevant Lines:
10247

💛  - Coveralls


Change default install location for Win

Hi there,
It's not apparent, but is it possible to change the default installation location? I don't have anymore space on C and need it on a different drive.

@papagunit right now, it is not possible. It was in times, when our installer was a bit more complex.
Basically, we could revert to the "old style" installer which is not click once to install. You'd need to go through a few 'Next's but then you could choose the path.
Maybe useful: IPFS Desktop's installer is a NSIS installer. If there's any flag you could pass to a NSIS installer to change the installation path, then you might be able to do so with our installer. I'm not aware of any.

The biggest question here for the installer is: simplicity vs customization?

Possible now!

Christmas came early!


Update Tmax to computationally sound limit

About the PR
Makes the Atmospherics.Tmax slightly higher, from 200kK to 262kK due to how floats work.
Why / Balance
Might as well go the full forte with defining the domain of calculation. This is the largest number that an epsilon of 1/64 = 0.015625K can exist, and any larger epsilon will probably be unacceptable at SS14's tickrates. In hindsight, I think this should be made a CCVar, however, I'm not currently capable of doing that due to physical GPU-ending reasons (fuck you nvidia)
Technical details
https://float.exposed/0x48800000 (fiddle with Raw Hexadecimal Integer Value)

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
None.
Changelog
no cl no fun (it's literally a constant change)

Aww, not even a little magnetic confinement?


Better way to display currently selected item from a list

I have a list of items and I want to display the list and also some text citing the currently selected item. To do this I have defined the following messages:
{
    "item1": "apple",
    "item2": "banana",
    "item3": "carrot",
    "selected_item": "Selection: {text, select, item1 {apple} item2 {banana} item3 {carrot} other {unknown}}"
}

Is there a way to do this that avoids having the translations for each item in two places?

I think what I was really after was a way to invoke another message from a message but I don't think that's catered for (or necessarily that desirable). I'm going to approach this differently and close this. Sorry for the noise.


Some way to track command usage

How many commands are used every week? Any commands not used?

Oh I was just thinking about doing something like this yesterday. LET ME HARVEST ALL THE DATA mwahaha

I regret this idea already ;-;


DPMR

Hello, I see the Chip is possible to listen to dpmr, is there a way to add this later?

no.
The radio is not capable of any kind of digital audio communications, CPU under powered, CPU has no access to the audio paths, no CODEC chip.


writeable -> writable

Nick Black points out that in many places we have used "writeable", which
is (depending on which dictionary you check) is either a less commonly
used variant of "writable", or just an outright misspelling.
Even charitably interpreting it as an alternate spelling, let's standardize
on the more common variant.
There's only one API function where this comes into play, so to preserve
link compatibility, we'll have both ImageBuf::make_writable() and
make_writeable() as a deprecated synonym that will eventually disappear.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

@dankamongmen


[5.7][IRGen] Use existential AnyObject throughout IRGen.

Cherry-pick of https://github.com/apple/swift/pull/59760

Explanation: Previously, some places in IRGen used getAnyObjectConstraint and others used getAnyObjectType. This inconsistency could cause crashes in IRGen when emitting metadata for types with AnyObject properties.
Scope: Affects the representation of AnyObject in IRGen.
Risk: Low.
Testing: Manually built modules where the crash manifested (with no luck in isolating a test case).
Reviewer: @slavapestov

Resolves: rdar://95945015

@swift-ci please test


Review summaries are ignored

It seems that the review summaries introduced by Github in "A whole new Github universe: Code better with reviews" are ignored by carsonbot.
See https://github.com/symfony/symfony/pull/20418#pullrequestreview-7846023 for instance.

Note that we will have to wait for GitHub to expose review comments one way or the other through their API so that the KnpLabs library can be updated if needed.

@ogizanagi : In the meantime, could you change the status to reviewed using the traditional comment? :smile: Thank you!

@yceruto : Now that the issue is reported, for sure! 😅


Update database.json

Adding deno_aws_sign_v4

@silver-xu  please merge with master

Closing because red. Start a new PR if you want to get this in.


Add dataplane-operator docs

Adds docs about the high level design of the dataplane-operator CRD's
and how they are used.
Also reorganizes the docs a bit and cleans up some of the README.md by
moving the contributing content to the dedicated contributing.md.
Signed-off-by: James Slagle<EMAIL_ADDRESS>

/test dataplane-operator-build-deploy-kuttl

recheck

/test dataplane-operator-build-deploy-kuttl

recheck

recheck

/lgtm

/test dataplane-operator-build-deploy-kuttl

recheck

/test dataplane-operator-build-deploy-kuttl

recheck

I think we can merge

recheck
/test dataplane-operator-build-deploy-kuttl
/lgtm

recheck

/test dataplane-operator-build-deploy-kuttl

/test dataplane-operator-build-deploy-kuttl

/lgtm


Readme issue - Usage with multiple files in one Request does not have $receiver defined

I have been playing with your package and since I am trying to figure everything out I am following the instructions for the multiple files upload in one request.
In your readme $receiver is not defined or am I missing anything?

Hi @Chinese1904 , sorry for the missing docs - bad merge on my side.
You can construct the the FileReceiver with a UploadFile object instead of passing an index in request.
    // Loop sent files
    foreach ($files as $file) {
        // Instead of passing the index name, pass the UploadFile object from the $files array we are looping

        // Create the file receiver via dynamic handler
        $receiver = new FileReceiver($file, $request, HandlerFactory::classFromRequest($request));
        // or via static handler usage
        $receiver = new FileReceiver($file, $request, ContentRangeUploadHandler::class);


Fix warnings reported while building container images

What this PR does / why we need it:
Fixes the warnings reported while building container images
Which issue this PR fixes(if applicable):
fixes #2691
Special notes for reviewers:

Release note:

NONE

/ok-to-test

/lgtm
/approve

/retest-required


Provide events consumer smart gateway deployment

Provides an events consumer smart gateway configuration. Allows for connection
to an ElasticSearch pod within the sa-telemetry namespace.
Deployment can be validated with the following manifest:
apiVersion: smartgateway.infra.watch/v1alpha1
kind: SmartGateway
metadata:
  name: events
spec:
  size: 1
  amqp_url: qdr-white.sa-telemetry.svc.cluster.local:5672/collectd/notify
  debug: "true"
  container_image_path: <IP_ADDRESS>:5000/sa-telemetry/smart-gateway
  service_type: "events"

 Deploy Smart Gateway Operator for events-consuming Smart Gateway

Not worth blocking on since nothing looks dangerous or broken, but I do wonder if that events service will work properly without a selector. If I get a chance to test this myself I might approve if I find it works.

Not worth blocking on since nothing looks dangerous or broken, but I do wonder if that events service will work properly without a selector. If I get a chance to test this myself I might approve if I find it works.

I'm going to investigate and see if I can clean this up. I knew some of this was coming, but wanted to get the PR pushed in a known working state. I'm going to iterate on it some more and see if we can get it closer to our idealized state. Thanks!


Authentication fail

Hello. Thanks for putting this together.
I am trying to use it with a free account but I am getting a authentication error.
Here is how I create the container...
docker create \
--name=ProtonProxyUS \
--restart=always \
-p 8318:8080 \
-e PVPN_USERNAME=**** \
-e PVPN_PASSWORD=****\
-e PVPN_TIER=1 \
-e PVPN_CMD_ARGS="connect us-free-01" \
walt3rl/proton-privoxy

...And here is the errors...
Connecting to US-FREE#1 via UDP...
[!] Authentication failed.
[!] Please make sure that your Username and Password is correct.
Device "proton0" does not exist.
Failed to bring up VPN :(

I wonder what I am doing wrong?
I am using the login details that I use to log in to the site.

I'm a paying ProtonVPN user and haven't used the free service at all, so my knowledge about the differences between them are limited. That said, I'm pretty sure your problem lies here:

I am using the login details that I use to log in to the site.

You're looking for the OpenVPN credentials associated with your account. For my account it takes the shape of random strings of 24 characters for both the username and password.


The keep-exp flag is not compatible with PerWorldInventory

The keep-exp flag doesn't work together with the PerWorldInventory plugin.  But if the flag keep-inventory is active at the same time, the EXP will also be restored.
Since PerWorldInventory is a widely used inventory management plugin, it would be aweseome if you could make it compatible. Of course I also reported the bug at PerWorldInventory (https://github.com/EbonJaeger/perworldinventory-kt/issues/228).
Steps to reproduce the behavior:

Install Worldguard + WorldguardExtraFlags + PerWorldInventory
Create a region.
Set the the flag keep-exp to true for the region.
Die inside the region -> you will lose your EXP
Try it without PWI -> you will keep your EXP

Plugin versions
PerWorldInventory 2.3.2 (https://github.com/EbonJaeger/perworldinventory-kt)
WorldGuardExtraFlags 4.1.4
Worldguard 7.0.5-SNAPSHOT build 2084
Server version
Paper 1.16.4 - 319
Additional context and logs
PWI config: https://pastebin.com/nk97p9nY
PWI world settings: https://pastebin.com/iDfFPiQH
There are no errors in the log.

This is a bug on the PerWorldInventory side.

Fixed in https://www.spigotmc.org/resources/beta-worldguardextraflags-reborn.96894/ 👍


not working well in tabs (ui.bootstrap.tabs)

When chosen is used in a tab and that tab is not the 1st tab of the tabset, the widget does not show.

Hi, first of all I'd like to apologize for the big delay. This project was abandoned and I'm the new maintainer (Read more #162)
I've got a fix for #179 which probably resolves the same issue with ui-bootstrap tabs and probably any other accordion.
I'm using $timeout and this fix will be launched at the next release.
There's a plunker here http://plnkr.co/edit/tVZX6s?p=preview
Make sure you use width="'100%'" for better results as responsive as well.
This fix can be used from the branch /tree/176-ng-if-breaks-inherit-select-classes

Fixed on release 1.4.0


fix: allow AddressData to be properly serialized using Amino

Description
This PR fixes a bug that currently makes it impossible to properly serialize an AddressData value using Amino.
Currently the AddressData interface has two implementations that are serialized as follows when using Amino:

Base32Address{
  "prefix": "",
  "value": ""
}

Bech58Address{
  "value": ""
}

However, since it is an interface, it should have been registered properly and should be serialized as follow:

Base32Address{
  "type": "desmos/Bech32Address",
  "value": {
    "prefix": "",
    "value": ""
  }
}

Base58Address{
  "type": "desmos/Base58Address",
  "value": {
    "value": ""
  }
}

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[x] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[x] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[x] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

I guess this is needed if we want to use ledger to create chain-links right? @RiccardoM


Added filtering to the other Reports based off the documentation

There are more filtering options that need to be added first.

would you mind checking this ? https://github.com/log0ymxm/node-harvest/tree/query_parameters
i'm working to implement plainobjects queries


Create Posts “how-does-a-gfci-outlet-work”

Automatically generated by Netlify CMS

👷 Deploy Preview for monetaboot processing.
🔨 Explore the source changes: cd152cf62154d1ea56611745b3fed17501259928
🔍 Inspect the deploy log: https://app.netlify.com/sites/monetaboot/deploys/614baf5c67f6090007d20c2d


Add ability to set repository method on listeners

When retrieving object from the SyncIndexWithObjectChangeProcessor it use a lot of non optimized query to retrieve all relations from the retrieved object, this PR allow to set a custom repository_method in the listener configuration :
enqueue_elastica:
    doctrine:
        queue_listeners:
            -
              index_name: app_index
              type_name: user
              model_class: App\Entity\User
              repository_method: findOneWithJoins

NB : Sorry I cannot find how to propose patch for this feature. So I open a pull request on this, let me know how to contribute and I will do it after that.

Any chance of adding SQS support to this bundle?

@jandom sqs should work fine

Thanks for your pull request! We love contributions.
However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package.
If you want to contribute, you should instead open a pull request on the main repository:
https://github.com/php-enqueue/enqueue-dev
Thank you for your contribution!

@makasim I sorry for that but, I did not find where the code is located on the main repository.

@alOneh true, this repo is an exception. sorry about that. Let me review and get it merged.

PR is updated.

@alOneh thank you for contribution

@makasim do you plan to make a new release with this ?


Reverse displayed endianness of transaction and block hashes

Replaces https://github.com/ZcashFoundation/zebra/pull/1056

Cherry picked commit from @vramana where the hard work was done, hope this is ok.
Fixed the test cases where it was failing.
Fixed zebra-checkpoints binary.

Todo:

[x] Get a new checkpoint list for mainnet and testnet. This will be done by @teor2345. I think we can just push the list once done into this PR.

Should close https://github.com/ZcashFoundation/zebra/issues/1031 when/if merged.

@oxarbitrage @yaahc I also found a few more places that needed updates:

9ab06709aed0a1c731180391c3a86224693cdc80 - zebrad-hash-lookup script
5c91a895a061c3eee7a8fdcd530f52a868ccc17e - fixed hash in transaction::Hash tests
2476f616897e8d17f819160a3e0b54ad7aeae263 - hash order comment
cc0c1988df38b57e4855a617c434727cd3e3d6fa - TransactionHash to transaction::Hash from #905

included in this PR because it conflicts with the other transaction changes

I also checked the list of tasks in #1031, and I'm running zebrad start on mainnet and testnet.

I tried to test this change using zebrad start, but bugs in the sync, state, and network code prevented a full sync. See #1181, #1182, and #1183.
I still think we should merge this change, it's a low-risk improvement, and the bugs aren't likely to be related to this change.

@oxarbitrage Thanks for picking up the PR. I was on vacation and couldn't find the time to finish the PR.


Add disable cross namespace read flag

The main change is adding the flag --disable-cross-namespace-read so reads behave the same way as writes and only reads from the topics for the same namespace is allowed plus any topics specified with --read-allowed-cross-namespace-topics.
Also remove empty file and format the code with black.

It would be nice if you could separate the reformatting to a separate commit next time

Ok. Lgtm!
Den mån 5 okt. 2020 11:12David Haglund<EMAIL_ADDRESS>skrev:

@daha commented on this pull request.
In charts/knuto/values.yaml
https://github.com/niradynamics/kafka-namespaced-user-topic-operator/pull/5#discussion_r499452459
:

dev:
deletion_enabled: true
allowed_non_namespaced_topics: []

cross_namespace_read_allowed: true

I think it is better to make that kind of configuration when using the
chart, as the convention in KNUTO is to allow read from all namespaces:
"On the permissions/ACL side, it is assumed that a KafkaUser in any
namespace is allowed to read data in all topics in the Kafka cluster, but
only a KafkaUser in the namespace associated with a topic (i.e where the
topic name is prefixed with the namespace name) is allowed to write to a
topic. "
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/niradynamics/kafka-namespaced-user-topic-operator/pull/5#discussion_r499452459,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA72Q7A43LGUZ5XTDUDTZTSJGEZPANCNFSM4SBVDO3Q
.

Renamed some of the arguments and internal variables to make it more consistent between read and write...

@maxjoh Added descriptions to the config now


You are mentioned in official manual!

Hello!
I just received my JK BMS and your repo was mentioned in official manual. I'd like to congratulate you! 🎉

Totally justified :) Love this project. It just works for me. Kudos!

Yeahh!!!!

Thanks for the flowers! I close this issue for better overview / to keep the open issues as low as possible. :-)


If the FormDialog choice values have numbers and/or parentheses in them, the form does not accept the choice

The title is pretty self explanatory, but essentially we're facing an issue where if the choices for a particular FormDialog field have numbers and/or parentheses in them, the FormDialog will not accept them as valid choices.
Interestingly enough, when our choices had values like "Foobar (ABC123-2)" it would take the "-2" as a positional argument and take the second choice on the list...

I am guessing C# ?

@danmarshall sorry, I forgot to mention. Yes, this is for the C# version of the SDK.

Are you saying that your descriptions at like "Foobar (ABC123-2)" or that your terms look like that?  If terms, they are regular expressions so you would need to escape them, i.e. "Foobar (ABC123-2)".  Otherwise it will not match "Foobar (ABC123-2)" because the parens will not match.  Let me know if this fixes your issue.

Actually digging into this a bit further, there is a bug for terms that start of end with a non-word character like () that will prevent matching on the whole expression.  I will go ahead and fix that and it should be in the next release.


Improve documentation for Resource Processor

PR for issue https://github.com/microsoft/AzureTRE/issues/1709
What is being addressed
Update the developer doc on resource processor to cover common scenarios that arise during development.
How is this addressed

Similar to API doc, there are now sections on local debugging and working cloud instance (later on, the troubleshooting doc will have references to these sections)
To a section "implementation detail", added information on Porter, and on how the input arguments are passed to Porter (mentioned it being location agnostic)
Removed section on manually sending messages to Service Bus as I couldn't get it to work when testing locally (we have added a lot of new fields since this section was written)

/test-force-approve

/test-force-approve


Centering first paragraph causing render outside window bounds

When using center /center on first body paragraph, causes rendering outside the pygame_html pop-up window boundaries.  For example, given an 800x800 pygame playfield, calling a pygame_html popup window of 320x224, and using this code, results in rendering outside the popwindow (below this example is an example of correct rendering):

Hello, World!

Inproper rendering:

This code results properly rendering inside the popup window:

Hello, World!

Rendering here:

Thanks for this issue, this was the result of a bigger bug that I found out while testing later, and this issue has been fixed as of now, If any such problems occur again, this issue can be re-opened.


dragOver is not fired

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
Do you want to request a feature or report a bug?

Report a bug

What is the current behavior?

When I move an element in a list (I use a sortable list), onDragOver isn't fired.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar.

Just create a little list and move elements to see the bug (nothing appear) :
export class AppComponent {
    private datas = [
        {label:'test'},
        {label:'test2'},
        {label:'test3'},
        {label:'test4'},
        {label:'test5'},
    ];

    dragOver(event) {
        alert(event)
    }
 }

<ul dnd-sortable-container [sortableData]="datas" [dropZones]="['test']">
    <li *ngFor="let data of datas; let i = index" dnd-sortable [sortableIndex]="i" (onDragOver)="dragOver($event)">{{data.label}}</li>
</ul>

What is the expected behavior?

Event must be fired

Please tell us about your environment:
Angular version: 2.0.0-rc.6 (I've also tried on rc.5)
Browser: Chrome 52.0.2743.116
Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
I've searched a solution, and if I remove this._elem != this._sortableDataService.elem in this file https://github.com/akserg/ng2-dnd/blob/master/src/sortable.component.ts#L134 event is fired but this._elem and this._sortableDataService.elem are identical...

Is that a bug, or did I do something wrong ?

Is this issue still not fixed, because I have the exact same problem

Same problem here.
Still no fix for this?


[Xcode] Don’t use a bridging header in a framework target

Oops, that was not intended to work, and in fact it produces warnings in clients.
Instead, change _sa_retain_n and _sa_release_n to Swift calling convention and call them using _silgen_name trickery when in single-module configuration.
Resolves rdar://110860922
Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've verified that my change does not break any existing tests.
[ ] I've updated the documentation if necessary.

@swift-ci test


Question about duplication semantics

What are the semantics of "duplicate" assertions? If I assert e.g. (is ball red) multiple times I get multiple results when I match on it, which indicates that the individual atoms are not "interned" or deduplicated in any way -- they are fully distinct. But when I remove-atom just once, they all disappear, which would indicate a kind of interning/deduplication.
(is ball red)
(is ball red)
(is ball red)
(is ball red)
(is ball red)

! (match &self (is ball $color) $color)

! (remove-atom &self (is ball red))

! (match &self (is ball $color) $color)

[red, red, red, red, red]
[()]
[]

Can you clarify what is happening?

Currently MeTTa doesn't specify this behavior, and it is implementation specific. Other implementation of the space can have different behaviour. As far as I know nobody relies on the current behavior of the default in-memory atomspace in hyperon-experimental. I agree it doesn't look very uniform, but on the other hand it allows doing manual deduplication easily.
I raised #799 to change it to more uniform. If @Necr0x0Der agree we can change this behavior. But I would like to emphasize one more time - you cannot rely on this.

understood -- thank you!

Closing it, @nasser please feel free to reopen if you have further questions on this.


Retry guidance: Rewording Cosmos DB retry guidance

I work on the Cosmos DB SDK team, the current retry guidance is not completely correct and it's covering only one case.
We have a more detailed document that guides customers to create resilient applications covering different retry scenarios and would be best to link to that one.

@ealsur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ealsur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ealsur: I'm sorry - only the author of this article, @EdPrice-MSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ckittel - I made a few edits for minor style issues. Could you review and add a #sign-off if the commits are ready to merge?

@ckittel: I'm sorry - only the author of this article, @EdPrice-MSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Upgrade to molinillo's master

The reason for this PR is that I was adding some comments about the current state of our vendored dependencies as requested in https://github.com/bundler/bundler/pull/7200, and I noticed that we are currently using the latest commit in molinillo's master but not some prior work.
What was the end-user problem that led to this PR?
This is not necessarily a problem, but it might be better to include the whole upstream repo as it is on its master branch now, because it gets us ready to support a future release.
What is your fix for the problem, implemented in this PR?
My fix is to include the latest changes in molinillo's master in our vendored copy.
Why did you choose this fix out of the possible options?
Another option would be to do nothing here and just wait for the next molinillo's release. Maybe molinillo is even ready to actually release its master branch.

We should only be using releases of Molinillo, rather than pulling straight from master

I also agree with @segiddins. But continuous integration is helpful for us. Can we add the master branch of molinillo to CI matrix?

Yeah, I agree too in general.
In this particular case, I cherry-picked the require_relative changes because they seemed to fix issues with bundler installed as a default gem, and also seemed safe.
What's the state of current molinillo's master? Would it be possible to make a new release that the next version of bundler can use? As I recall, there were only some changes for better error reporting.


[Explore][Time Picker] Tooltip should have a top and bottom border

Description
Currently the time picker help text tooltip does not have a top and bottom border, resulting this weird look:

We should add a padding to the tooltip content wrapper (the one with black background) and let the content itself scroll instead.
cc @zhaoyongjie

This is likely fixed by now, and is quite outdated if not. If people are still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.


Fix memory URL parsing

Why

https://github.com/meta-llama/llama-models/blob/43fcc08422a9a2105aeae7a5f09f3404dc478c5c/models/llama3/api/datatypes.py#L29
URL is defined as a string type in OpenAPI spec, client do not have a way to specify URL v.s. raw content.
This causes an issue where URL strings passed to server is indistinguishable from raw content or we should read from URL.

Fix

Check content against URL pattern match to determine whether URL is needed.

Test

test with memory SDK client

python sdk_examples/memory/client.py

Before Fix:

Score: 0.8463434066929127
Chunk:
========
Chunk(content='https://raw.githubusercontent.com/pytorch/torchtune/main/docs/source/tutorials/llama3.rst', document_id='num-2', token_count=22)
========

Score: 0.6421850715500633
Chunk:
========
Chunk(content='https://raw.githubusercontent.com/pytorch/torchtune/main/docs/source/tutorials/lora_finetune.rst', document_id='num-5', token_count=23)
========

Score: 0.5757617875215492
Chunk:
========
Chunk(content='XRvciBMaWNlbnNlIEFncmVlbWVudCAoIkNMQSIpCkluIG9yZGVyIHRvIGFjY2VwdCB5b3VyIHB1bGwgcmVxdWVzdCwgd2UgbmVlZCB5b3UgdG8gc3VibWl0IGEgQ0xBLiBZb3Ugb25seSBuZWVkCnRvIGRvIHRoaXMgb25jZSB0byB3b3JrIG9uIGFueSBvZiBNZXRhJ3Mgb3BlbiBzb3VyY2UgcHJvamVjdHMuCgpDb21wbGV0ZSB5b3VyIENMQSBoZXJlOiA8aHR0cHM6Ly9jb2RlLmZhY2Vib29rLmNvbS9jbGE+CgojIyBJc3N1ZXMKV2UgdXNlIEdpdEh1YiBpc3N1ZXMgdG8gdHJhY2sgcHVibGljIGJ1Z3MuIFBsZWFzZSBlbnN1cmUgeW91ciBkZXNjcmlwdGlvbiBpcwpjbGVhciBhbmQgaGFzIHN1ZmZpY2llbnQgaW5zdHJ1Y3Rpb25zIHRvIGJlIGFibGUgdG8gcmVwcm9kdWNlIHRoZSBpc3N1ZS4KCk1ldGEgaGFzIGEgW2JvdW50eSBwcm9ncmFtXShodHRwOi8vZmFjZWJvb2suY29tL3doaXRlaGF0L2luZm8pIGZvciB0aGUgc2FmZQpkaXNjbG9zdXJlIG9mIHNlY3VyaXR5IGJ1Z3MuIEluIHRob3NlIGNhc2VzLCBwbGVhc2UgZ28gdGhyb3VnaCB0aGU', document_id='num-0', token_count=512)

After Fix:

Score: 1.085271610677067
Chunk:
========
Chunk(content=' of :code:`lora_model` and\n:code:`base_model`, would show that they are both instances of the same :class:`~torchtune.modules.TransformerDecoder`.\n(Feel free to verify this for yourself.)\n\nWhy does this matter? torchtune makes it easy to load checkpoints for LoRA directly from our Llama2\nmodel without any wrappers or custom checkpoint conversion logic.\n\n.. code-block:: python\n\n  # Assuming that base_model already has the pretrained Llama2 weights,\n  # this will directly load them into your LoRA model without any conversion necessary.\n  lora_model.load_state_dict(base_model.state_dict(), strict=False)\n\n.. note::\n    Whenever loading weights with :code:`strict=False`, you should verify that any missing or extra keys in\n    the loaded :code:`state_dict` are as expected. torchtune\'s LoRA recipes do this by default via e.g.\n    :func:`validate_state_dict_for_lora() <torchtune.modules.peft.validate_state_dict_for_lora>` or\n    :func:`validate_missing_and_unexpected_for_lora() <torchtune.modules.peft.validate_missing_and_unexpected_for_lora>`.\n\nOnce we\'ve loaded the base model weights, we also want to set only LoRA parameters to trainable.\n\n.. _setting_trainable_params:\n\n.. code-block:: python\n\n  from torchtune.modules.peft.peft_utils import get_adapter_params, set_trainable_params\n\n  # Fetch all params from the model that are associated with LoRA.\n  lora_params = get_adapter_params(lora_model)\n\n  # Set requires_grad=True on lora_params, and requires_grad=False on all others.\n  set_trainable_params(lora_model, lora_params)\n\n  # Print the total number of parameters\n  total_params = sum([p.numel() for p in lora_model.parameters()])\n  trainable_params = sum([p.numel() for p in lora_model.parameters() if p.requires_grad])\n  print(\n    f"""\n    {total_params} total params,\n    {trainable_params}" trainable params,\n    {(100.0 * trainable_params / total_params):.2f}% of all params are trainable.\n    """\n  )\n\n<PHONE_NUMBER> total params,\n  4194304 trainable params,\n  0.06% of all params are trainable.\n\n.. note::\n    If you are directly using the LoRA recipe (as detailed :ref:`here<lora_recipe_label>`), you', document_id='num-5', token_count=512)
========

Score: 1.1161195066066212
Chunk:
========
Chunk(content=".. _lora_finetune_label:\n\n============================\nFine-Tuning Llama2 with LoRA\n============================\n\nThis guide will teach you about `LoRA <https://arxiv.org/abs/2106.09685>`_, a parameter-efficient finetuning technique,\nand show you how you can use torchtune to finetune a Llama2 model with LoRA.\nIf you already know what LoRA is and want to get straight to running\nyour own LoRA finetune in torchtune, you can jump to :ref:`LoRA finetuning recipe in torchtune<lora_recipe_label>`.\n\n.. grid:: 2\n\n    .. grid-item-card:: :octicon:`mortar-board;1em;` What you will learn\n\n      * What LoRA is and how it saves memory during finetuning\n      * An overview of LoRA components in torchtune\n      * How to run a LoRA finetune using torchtune\n      * How to experiment with different LoRA configurations\n\n    .. grid-item-card:: :octicon:`list-unordered;1em;` Prerequisites\n\n      * Be familiar with :ref:`torchtune<overview_label>`\n      * Make sure to :ref:`install torchtune<install_label>`\n      * Make sure you have downloaded the :ref:`Llama2-7B model weights<download_llama_label>`\n\nWhat is LoRA?\n-------------\n\n`LoRA <https://arxiv.org/abs/2106.09685>`_ is an adapter-based method for\nparameter-efficient finetuning that adds trainable low-rank decomposition matrices to different layers of a neural network,\nthen freezes the network's remaining parameters. LoRA is most commonly applied to\ntransformer models, in which case it is common to add the low-rank matrices\nto some of the linear projections in each transformer layer's self-attention.\n\n.. note::\n\n    If you're unfamiliar, check out these references for the `definition of rank <https://en.wikipedia.org/wiki/Rank_(linear_algebra)>`_\n    and discussion of `low-rank approximations <https://en.wikipedia.org/wiki/Low-rank_approximation>`_.\n\nBy finetuning with LoRA (as opposed to finetuning all model parameters),\nyou can expect to see memory savings due to a substantial reduction in the\nnumber of parameters with gradients. When using an optimizer with momentum,\nlike `AdamW <https://py", document_id='num-5', token_count=512)
========

Score: 1.0961540886504595
Chunk:
========
Chunk(content='.. _llama3_label:\n\n========================\nMeta Llama3 in torchtune\n========================\n\n.. grid:: 2\n\n    .. grid-item-card:: :octicon:`mortar-board;1em;` You will learn how to:\n\n      * Download the Llama3-8B-Instruct weights and tokenizer\n      * Fine-tune Llama3-8B-Instruct with LoRA and QLoRA\n      * Evaluate your fine-tuned Llama3-8B-Instruct model\n      * Generate text with your fine-tuned model\n      * Quantize your model to speed up generation\n\n    .. grid-item-card:: :octicon:`list-unordered;1em;` Prerequisites\n\n      * Be familiar with :ref:`torchtune<overview_label>`\n      * Make sure to :ref:`install torchtune<install_label>`\n\n\nLlama3-8B\n---------\n\n`Meta Llama 3 <https://llama.meta.com/llama3>`_ is a new family of models released by Meta AI that improves upon the performance of the Llama2 family\nof models across a `range of different benchmarks <https://huggingface.co/meta-llama/Meta-Llama-3-8B#base-pretrained-models>`_.\nCurrently there are two different sizes of Meta Llama 3: 8B and 70B. In this tutorial we will focus on the 8B size model.\nThere are a few main changes between Llama2-7B and Llama3-8B models:\n\n- Llama3-8B uses `grouped-query attention <https://arxiv.org/abs/2305.13245>`_ instead of the standard multi-head attention from Llama2-7B\n- Llama3-8B has a larger vocab size (128,256 instead of 32,000 from Llama2 models)\n- Llama3-8B uses a different tokenizer than Llama2 models (`tiktoken <https://github.com/openai/tiktoken>`_ instead of `sentencepiece <https://github.com/google/sentencepiece>`_)\n- Llama3-8B uses a larger intermediate dimension in its MLP layers than Llama2-7B\n- Llama3-8B uses a higher base value to calculate theta in its `rotary positional embeddings <https://arxiv.org/abs/2104.09864>`_\n\n|\n\nGetting access to Llama3', document_id='num-2', token_count=512)
========

Score: 0.9733073447702968
Chunk:
========
Chunk(content="_7b <torchtune.models.llama2.lora_llama2_7b>` alone will not handle the definition of which parameters are trainable.\n    See :ref:`below<setting_trainable_params>` for how to do this.\n\nLet's inspect each of these models a bit more closely.\n\n.. code-block:: bash\n\n  # Print the first layer's self-attention in the usual Llama2 model\n  >>> print(base_model.layers[0].attn)\n  MultiHeadAttention(\n    (q_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (k_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (v_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (output_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (pos_embeddings): RotaryPositionalEmbeddings()\n  )\n\n  # Print the same for Llama2 with LoRA weights\n  >>> print(lora_model.layers[0].attn)\n  MultiHeadAttention(\n    (q_proj): LoRALinear(\n      (dropout): Dropout(p=0.0, inplace=False)\n      (lora_a): Linear(in_features=4096, out_features=8, bias=False)\n      (lora_b): Linear(in_features=8, out_features=4096, bias=False)\n    )\n    (k_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (v_proj): LoRALinear(\n      (dropout): Dropout(p=0.0, inplace=False)\n      (lora_a): Linear(in_features=4096, out_features=8, bias=False)\n      (lora_b): Linear(in_features=8, out_features=4096, bias=False)\n    )\n    (output_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (pos_embeddings): RotaryPositionalEmbeddings()\n  )\n\n\nNotice that our LoRA model's layer contains additional weights in the Q and V projections,\nas expected. Additionally, inspecting the type of :code:`lora_model` and\n:code:`base_model`, would show that they are both instances of the same :class:`~torchtune.modules.TransformerDecoder`.\n(Feel free to verify this for yourself.)\n\nWhy does this matter? torchtune makes it easy to load checkpoints for LoRA directly", document_id='num-5', token_count=512)
========

Score: 1.1386078582408372
Chunk:
========
Chunk(content="8B uses a larger intermediate dimension in its MLP layers than Llama2-7B\n- Llama3-8B uses a higher base value to calculate theta in its `rotary positional embeddings <https://arxiv.org/abs/2104.09864>`_\n\n|\n\nGetting access to Llama3-8B-Instruct\n------------------------------------\n\nFor this tutorial, we will be using the instruction-tuned version of Llama3-8B. First, let's download the model from Hugging Face. You will need to follow the instructions\non the `official Meta page <https://github.com/meta-llama/llama3/blob/main/README.md>`_ to gain access to the model.\nNext, make sure you grab your Hugging Face token from `here <https://huggingface.co/settings/tokens>`_.\n\n\n.. code-block:: bash\n\n    tune download meta-llama/Meta-Llama-3-8B-Instruct \\\n        --output-dir <checkpoint_dir> \\\n        --hf-token <ACCESS TOKEN>\n\n|\n\nFine-tuning Llama3-8B-Instruct in torchtune\n-------------------------------------------\n\ntorchtune provides `LoRA <https://arxiv.org/abs/2106.09685>`_, `QLoRA <https://arxiv.org/abs/2305.14314>`_, and full fine-tuning\nrecipes for fine-tuning Llama3-8B on one or more GPUs. For more on LoRA in torchtune, see our :ref:`LoRA Tutorial <lora_finetune_label>`.\nFor more on QLoRA in torchtune, see our :ref:`QLoRA Tutorial <qlora_finetune_label>`.\n\nLet's take a look at how we can fine-tune Llama3-8B-Instruct with LoRA on a single device using torchtune. In this example, we will fine-tune\nfor one epoch on a common instruct dataset for illustrative purposes. The basic command for a single-device LoRA fine-tune is\n\n.. code-block:: bash\n\n    tune run lora_finetune_single_device --config llama3/8B_lora_single_device\n\n.. note::\n    To see a full list of recipes and their corresponding configs, simply run ``tune ls`` from the command line.\n\nWe can also add :ref:`command-line overrides <cli_override>` as needed, e.g.\n\n.. code-block:: bash\n\n    tune run lora", document_id='num-2', token_count=512)
========

Score: 0.8992728724432936
Chunk:
========
Chunk(content="_7b <torchtune.models.llama2.lora_llama2_7b>` alone will not handle the definition of which parameters are trainable.\n    See :ref:`below<setting_trainable_params>` for how to do this.\n\nLet's inspect each of these models a bit more closely.\n\n.. code-block:: bash\n\n  # Print the first layer's self-attention in the usual Llama2 model\n  >>> print(base_model.layers[0].attn)\n  MultiHeadAttention(\n    (q_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (k_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (v_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (output_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (pos_embeddings): RotaryPositionalEmbeddings()\n  )\n\n  # Print the same for Llama2 with LoRA weights\n  >>> print(lora_model.layers[0].attn)\n  MultiHeadAttention(\n    (q_proj): LoRALinear(\n      (dropout): Dropout(p=0.0, inplace=False)\n      (lora_a): Linear(in_features=4096, out_features=8, bias=False)\n      (lora_b): Linear(in_features=8, out_features=4096, bias=False)\n    )\n    (k_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (v_proj): LoRALinear(\n      (dropout): Dropout(p=0.0, inplace=False)\n      (lora_a): Linear(in_features=4096, out_features=8, bias=False)\n      (lora_b): Linear(in_features=8, out_features=4096, bias=False)\n    )\n    (output_proj): Linear(in_features=4096, out_features=4096, bias=False)\n    (pos_embeddings): RotaryPositionalEmbeddings()\n  )\n\n\nNotice that our LoRA model's layer contains additional weights in the Q and V projections,\nas expected. Additionally, inspecting the type of :code:`lora_model` and\n:code:`base_model`, would show that they are both instances of the same :class:`~torchtune.modules.TransformerDecoder`.\n(Feel free to verify this for yourself.)\n\nWhy does this matter? torchtune makes it easy to load checkpoints for LoRA directly", document_id='num-5', token_count=512)
========

Score: 0.875921749979012
Chunk:
========
Chunk(content=' support for all our models, and also use the ``lora_`` prefix, e.g.\nthe :func:`torchtune.models.llama3.llama3` model has a corresponding :func:`torchtune.models.llama3.lora_llama3`.\nWe aim to provide a comprehensive set of configurations to allow you to get started with training with LoRA quickly,\njust specify any config with ``_lora`` in its name, e.g:\n\n.. code-block:: bash\n\n  tune run lora_finetune_single_device --config llama3/8B_lora_single_device\n\n\nThere are two sets of parameters to customize LoRA to suit your needs. Firstly, the parameters which control\nwhich linear layers LoRA should be applied to in the model:\n\n* ``lora_attn_modules: List[str]`` accepts a list of strings specifying which layers of the model to apply\n  LoRA to:\n\n  * ``q_proj`` applies LoRA to the query projection layer.\n  * ``k_proj`` applies LoRA to the key projection layer.\n  * ``v_proj`` applies LoRA to the value projection layer.\n  * ``output_proj`` applies LoRA to the attention output projection layer.\n\n  Whilst adding more layers to be fine-tuned may improve model accuracy,\n  this will come at the cost of increased memory usage and reduced training speed.\n\n* ``apply_lora_to_mlp: Bool`` applies LoRA to the MLP in each transformer layer.\n* ``apply_lora_to_output: Bool`` applies LoRA to the model\'s final output projection.\n  This is usually a projection to vocabulary space (e.g. in language models), but\n  other modelling tasks may have different projections - classifier models will project\n  to the number of classes, for example\n\n.. note::\n\n  Models which use tied embeddings (such as Gemma and Qwen2 1.5B and 0.5B) for the\n  final output projection do not support ``apply_lora_to_output``.\n\nThese are all specified under the ``model`` flag or config entry, i.e:\n\n.. code-block:: bash\n\n  tune run lora_finetune_single_device --config llama3/8B_lora_single_device  \\\n  model.apply_lora_to_mlp=True \\\n  model.lora_attn_modules=["q_proj","k_proj","v_proj"]\n\n.. code-block:: yaml\n\n  model:\n    apply_lora_to_mlp: True\n    model.lora_attn', document_id='num-0', token_count=512)
========

I think we need to take a closer look at our type system to get this fixed properly.

URL is defined as a string type in OpenAPI spec, client do not have a way to specify URL v.s. raw content.

this seems to be the problem? we have a URL(uri=...) way of specifying a URL maybe @json_schema_type annotation around that is causing problems.

this seems to be the problem? we have a URL(uri=...) way of specifying a URL maybe @json_schema_type annotation around that is causing problems.

Yes, this is the problem. The URL is of type "string". We could either change the json_schema_type annotation, or do this workaround. Depends on how we want client to handle the contents. This is a fastest solution to unblock @hardikjshah .
@json_schema_type(
    schema={"type": "string", "format": "uri", "pattern": "^(https?://|file://|data:)"}
)
class URL(BaseModel):
    uri: str

    def __str__(self) -> str:
        return self.uri

OK I will approve this, but we need to file a task and fix this in our type system because that's the root of the issue. Otherwise it will trip us up in more horrible ways later.


FullScreen icon is not showing

Thanks for the great plugin. I've integrated this plugin into my angular project and it is working well. However, the icon is not showing on the map (just an empty box).
I tried to override the CSS and add the background image from the assets folder but no use.
.fullscreen-icon {
    background-image: url(../../../assets/favicon.png);
}

Any idea on how to fix this?

Sorry but i can't see how i could help you on this since i can't access to a demo of the bug in your environment.

Ahh okay. I'll create a new work environment and test this plugin.

Any news about this one ? Is the bug still present on your side ? Can we close this issue ?

No feedback, closing, feel free to comment if needed.

This may happen because cdnjs not longer includes images in the most recent few versions of leaflet.fullscreen
cf https://cdnjs.com/libraries/leaflet.fullscreen/2.4.0
If you load the css from there, then image will try to load from cdnjs too


tests: Fix HA tests

Enhancement:

Remove extrainvocation of read-scale test
Add example inventories
Run configure_ha_cluster_reaad_scale test only when invntory has 3 nodes and zero witness nodes

[citest]

[citest]

[citest]

[citest]

[citest]


initialization failures with 7.0.4

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

IBM Spectrum Scale system type:

[ ] IBM Spectrum Scale classic cluster.
[ ] IBM Spectrum Scale Container Native Storage Access (CNSA).
[ ] IBM Elastic Storage Server (ESS).

IBM Spectrum Scale cluster version:
IBM Spectrum Scale bridge for Grafana version:
Grafana version:
OS Grafana is installed on:

Additional context
Add any other context about the problem here.

with GPFS -> gpfs.base-5.1.1-4.x86_64 CNS
and <>
python/3.6.10
CherryPy 18.6.1
log displays ....
port=4242
protocol=http
server=localhost
serverPort=9980
apiKeyName=scale_grafana
includeDiskData=False
logPath=/var/log/ibm_bridge_for_grafana
logLevel=5
logFile=zserver.log
2022-10-30 13:13:11,449 - bridgeLogger - DEBUG    - readSensorsConfigFromMMSDRFS attempt to read /var/mmfs/gen/mmsdrfs
2022-10-30 13:13:11,450 - bridgeLogger - DEBUG    - __do_RESTcall invoke __ params: perfmon/topo GET None
2022-10-30 13:13:11,450 - bridgeLogger - DEBUG    - createRequestDataObj __ created request
2022-10-30 13:13:11,452 - bridgeLogger - MOREINFO - Server internal error occurred. Reason: can't set attribute
2022-10-30 13:13:11,452 - bridgeLogger - ERROR    - Metadata could not be retrieved. Check log file for more details, quitting
===
?
pmcollector is running and mmperfmon from the node queries just fine.

on the pmcollector node please execute the following commands and paste the output here.

mmdiag --version
mmperfmon config show

I discovered the issue late Sunday. There was a typo in the config file,.
V6 of the code didn’t return the metadata collection error until the program
was killed, V7 returned the metadata collection error in the log.
We are a bit behind the curve version wise on this particular system.
Thanks.
On Nov 1, 2022, at 11:49 AM, Helene Wassmann<EMAIL_ADDRESS>wrote:
on the pmcollector node please execute the following commands and paste the output here.

mmdiag --version
mmperfmon config show

—
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIBM%2Fibm-spectrum-scale-bridge-for-grafana%2Fissues%2F74%23issuecomment-1298962046&data=05|01|jkaitschuck%40nvidia.com|a41b423f37244408f16908dabc39c77e|43083d15727340c1b7db39efd9ccc17a|0|0|638029253598839635|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=MM85suNWEMIc8qJCD3YZYgZYaQum0%2BKaAquX1m%2BPiBY%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA346VJ6ZXMHNQGXURHDZOCDWGFQ2ZANCNFSM6AAAAAARSO65ZM&data=05|01|jkaitschuck%40nvidia.com|a41b423f37244408f16908dabc39c77e|43083d15727340c1b7db39efd9ccc17a|0|0|638029253598839635|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=sK6NT%2FuNF3sbUgI95P3zrWkqY4gS6BVAGRuWWUqNKaA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Can we close this ticket?

yes … and thank you.
On Nov 1, 2022, at 11:56 AM, Helene Wassmann<EMAIL_ADDRESS>wrote:
Can we close this ticket?
—
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIBM%2Fibm-spectrum-scale-bridge-for-grafana%2Fissues%2F74%23issuecomment-1298970566&data=05|01|jkaitschuck%40nvidia.com|50c4cf710e774989e0c708dabc3accf8|43083d15727340c1b7db39efd9ccc17a|0|0|638029257988055996|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=aDjq0yuO4FIrPW%2FidU0azTuTF8GxvrVrciJq1euM5%2Fg%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA346VJ2CZPR5D5G5NN4DMVLWGFRWFANCNFSM6AAAAAARSO65ZM&data=05|01|jkaitschuck%40nvidia.com|50c4cf710e774989e0c708dabc3accf8|43083d15727340c1b7db39efd9ccc17a|0|0|638029257988055996|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=7MN0pFYfGRPrWzea3ncl4%2BlZfMfg7YEM254Y8IGGDfM%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Medical Charges Analysis for Smokers and Non-smokers

Have you read the Contributing Guidelines ?
Medical Charges Analysis for Smokers and Non-smokers
Description
This Data analysis and data visualization project consists of the fact that the average medicine charges can be changed for smokers and non-smokers.
Conclusion :
1.The impact of smoking on medical care use was examined in a 30-month prospective population-based cohort study in Japan (N = 43 408).
2.Male smokers incurred 11% more medical costs than ‘never smokers’ but for female smokers and never smokers the costs were almost the same.
3.This difference was mainly attributable to the increased use of inpatient medical care among smokers, especially in males, where per month cost of inpatient care was 33% higher in smokers.
Checklist

[x] I've read the contribution guidelines.
[ ] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#169

Please check @SamarpanCoder2002 @Kushal997-das

LGTM @suy1968 ... you can merge @Kushal997-das ....

LGTM @suy1968 ... you can merge @Kushal997-das ....

Thanks @SamarpanCoder2002

@Kushal997-das  this project is copied from the following project, even the README.md file is barely copied. The documentation, codebase and even the images the copied from the following project which was uploaded way back in October, 2020.
Main project repository : https://github.com/abhisheks008/Medicine-Charges-for-Smokers-and-Non-Smokers-Analysis
This is really against the ethics of Open Source. PA please take a look into that:)

@Kushal997-das this project is copied from the following project, even the README.md file is barely copied. The documentation, codebase and even the images the copied from the following project which was uploaded way back in October, 2020.
Main project repository : https://github.com/abhisheks008/Medicine-Charges-for-Smokers-and-Non-Smokers-Analysis
This is really against the ethics of Open Source. PA please take a look into that:)

Sorry for the inconvenienced cost . Yes this is against the ethics . Gonna delete this and in future we never accept these types of folks PR . Thanks for the info. 👍

Thanks for the needful work! 👍

Thanks for the needful work! 👍

@abhisheks008 Done 👍

@suy1968 Don't send again PR here , this is the warning from our side. You just spoil developer community nothing else .


Asking how to send variable along with a SQL query.

When I'm trying to put a variables into write SQL query after convert them to strings, I got a compile error in the below attached arduino file.
Arduino code

Hello @SupulP,
Can you provide the error message as well?

@SupulP
I believe you're trying to bind variables to a query, see the following example for how to do so:
https://github.com/mustafakemalgilor/tdslite/blob/main/examples/arduino/05-query-with-parameters/05-query-with-parameters.ino#L259

I got this earlier. And I have insert it to my code.Can you check my code whether I'm right or not?

Please guide me how to send my query as I declared as "x" in my code to the SQL server. I have attached full code and  ss of particular part of problem. Please give me some solution as soon as possible. Thanks
https://drive.google.com/drive/folders/1FnakqYvI_1lq9m5ue19BHRH8f_PnfxN-?usp=sharing

Error Message.txt

Code -
https://drive.google.com/file/d/1JiIe0E-Gdn10n4XbosDFUusPfkvffBS3/view?usp=share_link

Dear Sir, I have put a message in GitHub with my problem. Please help to
solve it. If you can edit a particular coding part of my Project I'll be
grateful to you.
Thanks & Best Regards
On Thu, Apr 27, 2023 at 7:56 PM Mustafa Kemal GILOR <
@.***> wrote:

@SupulP https://github.com/SupulP
I believe you're trying to bind variables to a query, see the following
example for how to do so:
https://github.com/mustafakemalgilor/tdslite/blob/main/examples/arduino/05-query-with-parameters/05-query-with-parameters.ino#L259
—
Reply to this email directly, view it on GitHub
https://github.com/mustafakemalgilor/tdslite/issues/7#issuecomment-1525794832,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7O6LBWH4H3HTH26IKTSYMDXDJ6XRANCNFSM6AAAAAAXN5ZMEE
.


2.2-fixes-Fix backupConfig is undefined when upgrade form 2.1.7

Proposed changes

When upgrade form 2.1.7. Radio button value change cluster.rancherKubernetesEngineConfig.services.etcd.snapshot to cluster.rancherKubernetesEngineConfig.services.etcd.backupConfig.enabled.
It makes backupConfig is undefined, so it needs to init when edit cluster.
Types of changes

Bugfix (non-breaking change which fixes an issue)

Linked Issues
https://github.com/rancher/rancher/issues/19122

Further comments

Close in favor of https://github.com/rancher/ui/pull/2800


improve datetime support

Currently the ability to use datetime in kandy-lets-plot (using it as a datatype as well as customisation of scales, guides, etc.) is limited due to the lack of full support in Lets-Plot engine. It is necessary to close all the problems in it.

https://github.com/JetBrains/lets-plot-kotlin/issues/174

https://github.com/JetBrains/lets-plot-kotlin/issues/129

https://github.com/JetBrains/lets-plot/issues/678

https://github.com/JetBrains/lets-plot-kotlin/issues/231


Added support for CentOS 7-8

I have added support for CentOS 7-8. My testing confirms that the changes work as expected.
There is one issue: The WireGuard service fails to start as a reboot is required to load the Linux Kernel module. I believe this would also be an issue with the role as it currently exists? I presume rebooting the machine is beyond the scope of the role?

Thanks for contributing these changes, I will do some quick testing later and create a new release.
Yes for now I wanted to not handle reboots in this role, it might be a good idea to mention this in the readme.

LGTM, thanks again for contributing


This extension is obsolete, as it is no longer supported

vscode:
Version: 1.74.2 (user setup)
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:29:14.590Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: No

What to do?

I made a "manual workflow" that is working so far. This workflow does not provide many features, but it allows me to use a regular repository (not a gist), which I think is better, and also to sync extensions files. If you want use it, I put the steps in this instruction. Hope it helps someone.


role commands

Summary
Add role control command with the bot.
Reasoning
We recently overhauled our server due to a very large number of roles. These roles were mostly for fun, however many serve a specific purpose.
Execution
The execution of this command needs to be discussed further. Generally it would allow a user to enter the command and a role id and add that role.
Perhaps we could consider a reaction-based command where an embed lists all the roles available to be added and a user's reaction/un-reaction gives them the role.
Concerns
This could easily cause a rate limit if someone decides to spam emote, we would need to see what the rate limit is for this sort of reaction check and make sure it is handled appropriately.
We cannot allow the bot to automatically allow all roles to be accessible. This bot has very serious permissions and can do very serious damage to a server. Every role will likely need to be manually added to the bot by someone with admin permissions.
one example: the bot should not even be capable of granting a role with admin permissions, so admin roles should not be available.
Another concern is: we have roles used to protect privacy of certain channels as well as age-restrict some channels, these cannot be given to users by a command, unless we decide they should be self opt-in. Remember that this applies to ALL servers, Friendo is used/is meant for many servers, so this cannot be hard-coded to use our default roles. The setup should also be as painless as possible.
Maybe consider some sort of setup embed that allows admins/owners to select which roles on their server are included/excluded
Conclusion
Please discuss the use, purpose, and execution of this command on this issue. We need to figure out how this will be done exactly.

I would like to add that we could have our OWN role based system. We can allow the bot to completely manage it's own roles, utilizing our backend to store roles for servers. These roles would only exist within our backend and the bot, they would be completely separate from the actual discord client.

@AI-Pree @Akarys42 Your input here would be greatly appreciated.