Actual demand in the enterprise environment

Each port should be supported for control, such as turning off a USB, SD card slot, shutting down Bluetooth separately, AND NFC.
These needs are the real focus of enterprises, should increase support to improve competitiveness to meet user needs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 507f76f4-8665-4e41-8981-8c68a9b61cb3
Version Independent ID: 2cf4cee5-62ea-584b-9ee7-07eca2f15922
Content: Intune management of Surface UEFI settings
Content Source: devices/surface/surface-manage-dfci-guide.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Hello, @goxia
The issues section of this repository is intended for documentation and content related issues.
Please consider sending your input via the Feedback Hub so that it gets addressed via the proper channels:
Send feedback to Microsoft with the Feedback Hub app
Thank you.


fixed singlePlayer and multiPlayer screen disappearance after enabling Animated Menus option

Fixes disappearance of buttons that should come after clicking Singleplayer and Host Game buttons in main menu.
#2762 partially fixed already in pr 2772 and completely fixed after this
Contains
Fixes #2762
How to test

Enable animated menus in settings > video
go back to main screen
click Singleplayer or Host Game button
click Back
click any among the Singleplayer or Host Game button

Can one of the admins please verify this patch?

@Halamix2 @Malanius could either of you try this out please? :-) Seems simple enough, but need to watch out for unexpected consequences.
@GooeyHub: ok to test

Hooray Jenkins reported success with all tests good!

It's working, I didn't have any problems now
Hooray Halamix2 reported success with no unexpected consequences :D
(tested with animated menus turned on and off)

I can also confirm it works as expected now. I haven't found any side effects.
Good work, @0shine0 !

Thanks for confirming! And thanks for the PR @0shine0 - added you to credits, got you a contributor badge in the forum, etc :-)


Vaesen RPG V1.0, includes PC and NPC sheets

Changes / Comments
Submitting initial build of a character sheet for the Vaesen RPG by Free League.
Includes Tab switching PC/NPC sheets
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[Yes] Does the pull request title have the sheet name(s)? Include each sheet name.
[No] Is this a bug fix?
[Yes] Does this add functional enhancements (new features or extending existing features) ?
[Yes] Does this add or change functional aesthetics (such as layout or color scheme) ?
[No Changes, new sheet ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[Yes] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

I noticed someone else also submitted a Vaesen character sheet this week. See #7160

Hey there, looks like we both ended up working on Vaesen sheets independently. I don't mind there being 2 versions of the sheet as long as Roll20 is okay with it -- someone may find one version more useful than the other (such as our different approaches to handling bonus dice). Either that or we could work together on one version. I know Free League has stated that they plan on releasing their own version at some point -- obviously these are both just stop-gaps for players to use until the official sheets come out.
Just wanted to point out a couple issues I noticed in this sheet that might be worth looking into:

Conditions are not a progression, i.e. you don't always start with Exhausted then go to Battered and then Wounded before Broken. You can be Wounded but not Exhausted, for example. The only real progression is that players only become broken when taking a fourth condition.
Is the intent that players manually add negative bonus dice by hand to factor in conditions? If so, there might need to be a check to ensure players always roll at least 1 die on skill checks, since the book states that you can always roll at least 1 die no matter how many conditions you have.
It would be nice to have a field for players to record a weapon's range for easier reference (e.g. 0-2).

Thanks for starting the convo @dodgepong . I'm going to merge both sheets in for now. It would be awesome if you both could collab together and make one awesome Vaesen sheet for the community! :D

@dodgepong Hey there!  I haven't had a chance to check your sheet out.  I am new around these parts, just grabbing a pro-sub and wanting to try out sheet creation, and seeing no Vaesen and wanting to run it soon I got to work!  I added you on Twitter as well.
Conditions: I didn't really view this as a progression system, but after your comment and a quick re-read, I would be better off to change this.  I had misread this or misremembered this, as you only had 1 condition at a time, which is clearly not true.
Condition Dice, negative dice: I think I set the dice to not allow going to below 0 early in the build and only thought of this, this morning, but yes, at this time that was my intention.  It was a thing that allowed dice to be modified easily.  I'll probably end up renaming it as well.  It grew out of a way to apply equipment bonuses to a roll.  Good catch on the at least 1 die, something to look at.
Weapon Range: yes, just never got around to fitting it in as I was building the sheet, I modified the layout so I could fit more in and just ran out of time to get that added in.
NPC sheet:  I intend to rename this to "Vaesen" as it is really aimed at representing a Vaesen, not any generic NPC, as they have slightly different stats and unique conditions.
HQ Sheet: Certainly something I intend to add, but it seemed like a nice to have and wasn't necessary for what I needed this for initially, so I had planned on adding it to the next version of the sheet.

I spent a bit of time thinking about NPCs this morning, and I actually do think there's value in having a player-controllable NPC sheet, because players can create characters as upgrades to the castle (recruits, guards, and the coachman).
I admit I've avoided reading the chapters on Vaesen and NPCs in general since my GM forbade me from it 😅 So if that could be useful for some players/GMs, then it could certainly have value. I've clearly approached this more from the perspective of a player and thinking about what a player might find useful, and it sounds like you've been putting thought into what a GM might find useful.
I'm also new to creating character sheets too, and got a pro sub as part of Free RPG Day. I've played a lot of John Harper's games/FitD games on Roll20 (Blades in the Dark, Band of Blades, Agon) and always been impressed by those sheets, so I ended up taking a lot of inspiration from that.

Nice.  I also got the sub from Free RPG Day!
Most of my time on roll20 has been setting up games from a free perspective since quarantine, the biggest was John Carter.  Other than that I've looked at a few (Conan 2d20 and Alien), but I didn't take much inspiration from them tbh, some syntax here and there.
I have 100% approached this from the idea of what a GM might need to run this as a one-shot, and although I could have simply kept the files and run them custom, it seemed like a better idea to share them with the community, but I recognize I have missed things and have upgrades.  Just this morning I realized I didn't have an attack roll button!
As for player-controlled NPC sheets, the question comes out to, what differences are there between a human NPC and a human PC stat-wise?  Can they just use the PC sheet, or is something more roster-like more useful.

It looks like the primary difference between PCs and NPCs is that NPCs have physical/mental "toughness" in place of condition slots. NPC sheets could probably be simplified to name, occupation/NPC archetype, attributes, skills, physical/mental toughness, and then a text box for any additional notes. I suppose if NPCs are intended to follow rules for equipment (armor and weapons) it might be worthwhile to have sections for those, too.

Yes, just looking at the characters in the included adventure.  Should be able to create a pretty simple sheet to handle them.  In Truth, I would probably find it handy for what I want to run.

Having a simplified NPC sheet is likely a good idea. And when possible, having the NPC sheet use the same attribute names as the PC side would make it easier to switch between the two and avoid unnecessary duplicates of sheet attributes.
Great to see you two hit it off with ideas and to collaborate on a single sheet. I'll be unsubscribing from the discussion, but remember that you can stop by the Character Sheet Forums if you want input/ideas/help from other sheet authors or to copy stuff from other sheets.


Change let module Foo into module Foo.

Related to #26.
Note that I chose to use module instead of the proposed mod keyword as I think it's more descriptive and clear. Of course if we want to use mod anyway I can still change it into that.

why do we want module over let module?

Yeah, module over mod.
@jaredly I guess it's kinda how it's type foo rather than let type foo? Not much opinion on this though.

I guess it alights with module type

Looks good.
Could you make this "let" work optional instead? This way we can have backward compatibility given that we don't have a good upgrade story for npm yet.

@yunxing Done, you can now use let module also.

Cool, I like this improvement. Nice job on the backwards compat too!
@jaredly:

I guess it alights with module type too

Good point!

@jordwalke Yeah, that would also be my preference - I think with some shuffling around of LET it should be possible.
I don't think moving to different syntax should be a big issue, the current changes are not that different from the old situation.

Seems moving to LET UIDENT is even simple!

Cool, glad to move forward quickly with this one especially since you've got the backwards compat. If noone objects, I'll merge first thing in the morning (or yunxing, feel free to when you see this).
the let ModuleName has an issue in that it conflicts with let None = None, but we can work that out way later. Really happy with this for now.

@jordwalke Guess I was a bit too optimistic - I now have a weird mixture of modules and functions.
I think we need to do something similar as with the objects PR - which is creating a production to decide if it's a module or variable based on LET UIDENT and LET LIDENT (including all the variations).

the let ModuleName has an issue in that it conflicts with let None = None, but we can work that out way later.

A disadvantage to this approach is that it makes accurate syntax highlighting harder. In my vscode extension, I highlight module names differently than data constructors in patterns. But with such a change there'd be no way to distinguish them syntactically in general without backtracking, which textmate style grammars do not support.

To give a bit more context to my previous comment, this is how I am currently highlighting things in the vscode extension:

So perhaps another point to consider is that with the current grammar there is a nice symmetry between let prefixed items corresponding roughly to definitions with some sort of runtime significance, e.g., functions, modules, objects, etc. The items that do not have a let prefix, like {class, module} type correspond more to items with static significance, e.g., types, module signatures, or classes.
Removing the let from let module would break this symmetry and there would also be no way to highlight the module keyword in module M and module type T differently in a robust way (e.g., works even with line breaks) due to the limitations of textmate grammars. Emacs probably has the same issue but it's been awhile since I wrote a higlighter for it so I don't remember exactly what it's capable of.
I'm not trying to suggest this current change shouldn't be made btw. I don't really have a strong opinion about it (especially as long as backward compatibility is there). But I do think that syntax changes should be made with the potential to highlight them effectively kept in mind, since there are a lot more limitations on what can be recognized there than in the actual language parser.

One other thing: I think the fact that we currently have let module for modules but class type and module type for classes and signatures kind of obscures the symmetry I was talking about. It would be more apparent if we also had type class C = … and type module T = ….

This is a great PR. Backwards compat and everything.
@freebroccolo's point about taking it even further with let ModuleName is a good one. We can discuss that later (it would require a different syntax for let None, such as let (None) which is not out of the question - but we can discuss later).

@freebroccolo's other point:

there would also be no way to highlight the module keyword in module M and module type T differently in a robust way

Is this really the case? It seems highlighting is seriously underpowered!

Is this really the case? It seems highlighting is seriously underpowered!

@jordwalke Unfortunately, yes. The problem stems from the fact that textmate grammars do the tokenization pass line-by-line for efficiency purposes (easy but crude) and textmate grammars do not support multi-line regexes. What this means is that you effectively only have backtracking up to what is possible within a single-line regex.
You can specify that a syntactic entity has a start and end pattern and that entity can span across multiple lines. But once a start pattern matches, that's it. You can't back up and try another if the end pattern fails to match. The highlighting will just fail for the rest of the document in that case.
So for accurate highlighting you always need to be able to determine which parsing contexts will come next before you finish the line, or just try to do some sort of approximate parsing.
So when I say "robust" what I mean is that you could highlight the module keyword in module M and module type T differently but only if type always occurs on the same line as module, otherwise the highlighting will just fail.
In practice it may not be a big deal but I personally find it pretty annoying when highlighting is fragile like that. So I've gone to great lengths to ensure almost all parts of the current syntax highlighting are stable even when the tokens for a syntactic entity are broken across lines.

(Notified in discord) Despite the increase in difficulty in highlighting, I think the syntax itself shouldn't be dragged down (to a certain degree) by it. I'm merging this; Apologies to @freebroccolo for the harder syntax highlighting, and thanks for your work so far. Really appreciate it.


⚠ Bofrost.be has degraded performance

In f17255d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2634 ms

Resolved: Bofrost.be performance has improved in c813c30.


Add how-to guides section on the sidebar

In order to add how-to guide example to Terra, we need to add a new section on the documentation side bar so that users can discover it.

are you looking for contributors for this issue? I'd like to help!

closing this as it is covered by work in https://github.com/Qiskit/qiskit_sphinx_theme/issues/70


Add contributions better

Where else should we credit developers ?
Who are the other (older) developers ?
How do we mention the sources ?

Usually the list of contributors appears in a file called CREDITS (see pywikibot-core)
It would be nice for the readme to indicate this package was derived from http://git.wikimedia.org/log/pywikibot%2Fpycolorname.git , which was extracted out of http://git.wikimedia.org/log/pywikibot%2Fcompat.git .  The fun part would be finding where the code was in the compat repo. (git log -S ... can probably help find where & when the code was removed)
We only know of older/other contributor DrTrigon (the addition of .gitreview was not relevant), however in the compat repo we may find that other people also contributed to the code.


Quick Start Guide for basic,pvc,hpa

Motivation
Quick Start Guide folder is outdated so I restructured the folder and added 3 new features.
This adds documentation so it does not need tests
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Unit tests pass locally
[ ] FVT tests pass locally
[ ] If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

Melissa Flinn will create a new PR regarding Quick Start Guide doc so I will merge it now.


doubtfully, blubber

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,d]

/trunk merge


Not able to deploy on vercel

I am getting error while deploying on vercel please guide me which build and install command should I input to deploy on vercel.

Go to settings and  change npm install to npm install --force


[JOSS-Review][Third-Party guidelines] Add guidelines on how to seek support

JOSS Reviewer checklist item
JOSS Review Issue: https://github.com/openjournals/joss-reviews/issues/7489
Are there clear guidelines for third parties wishing to:

Contribute to the software: CONTRIBUTING.md
Report issues or problems with the software : README.md
Seek support: Currently, README/CONTRIBUTING doesnt state how should someone ask for help? Are there any dedicated slack channels/discord server? Mailing list? Should someone open github issue?

Minor Nitpick[Non Blocking]
I would appreciate if the details about software issues could be moved to CONTRIBUTING.md. I have a habit to skim through the things. Consider Q# style, brief in README, expands in CONTRIBUTING: https://github.com/microsoft/qsharp?tab=readme-ov-file#contributing.
This is just a minor suggestion, not too binding, since this repository contains good issue, bug and PR templates.

@Manvi-Agrawal, I have added a section in CONTRIBUTING.md instructing users to simply raise a GitHub issue in case of questions.


Unable to extend custom component's style

I have created this example
http://www.webpackbin.com/NJ2MWWxGG
WorkingButton.js exports a styled.button with custom style.
Button.js exports a styled(MyButton) with the same custom style.
In main.js

the former can be extended with some more styling to create ButtonBlue. The rendered style for ButtonBlue is a merged version of the 2 styles.
the latter can't be extended. Styles stop working as I would expect.

I can't visit the webpack bin (it's set to live mode, you need to un-live mode it), but I reckon the issue is that you're not attaching the passed in class name to your MyButton. See this doc page: https://github.com/styled-components/styled-components/blob/3e5d63fd71ad06c37cfb5fe6bc8e77553ddc0fb2/docs/existing-css.md#styling-normal-react-components
Let me know if that fixes the issue!

do you still see it in live mode ?

I think all of these issues will actually be fixed by #227?


Update of Diffusion Algorithm

Sparse matrix optimization

scikit-learn adaptation for their new check_array function.

probably time to write a couple of tests :)

Sounds good!
Any advice of tutorials etc.?


BitcoinCore RPC interface to access wallet balance

I'm not sure whether this is something that fits into XChange or not but I wanted something that would fetch a BitcoinCore wallet balance in the same way as an exchange. Thoughts?

Yeah, this is great!


Need an additional custom class to select2-container

We need an additional custom class to select2-container container to easily override the inner classes styles.
Like
$("#e2").select2({
customClass: "Myselectbox",
});

So that corresponding container will formed as
<div class="Myselectbox select2-container select2-container-multi">

So that I can override an inner classes like .Myselectbox .select2-choices in CSS.
Generally this will  help to override the textbox(ul.select2-choices) style.

I am using version 4.0.2. And on using containerCssClass it adds class to select2-selection. I guess the class is supposed to be added to the main wrapper select2-container.

The issue @imlunek mentioned still persists in 4.0.3. Is it intentional?

The containerCssClass thing seems to work properly with stable version.

@imlunek is there a way to add css class to the select2-container element? the containerCssClass adds the class to select2-selection

same issue

If you're using data attributes:
        $('[data-container-css-class]').each(function() {
           var className = $(this).attr('data-container-css-class');
           var container = $(this).next('.select2-container');
           container.addClass(className);
           container.find('.select2-selection').removeClass(className);
        });

Is there any difference between containerCssClass and dropdownCssClass?
For me it looks like a bug..
Please fix the containerCssClass if it's realy doing the same thing as dropdownCssClass!
doing it with js is so ugly...

Facing the same problem; using containerCssClass adds the class to select2-selection, not select2-container .

This will do the trick:
$('select').select2().data('select2').$dropdown.addClass('my-container');

add class to the main wrapper select2-container

Since this appears to be a fairly common request, I'm going to reopen this as a feature/documentation request.

@andrejpavlovic you should not call .select2() before chaining it with .data('select2').$dropdown as this causes issues with default select2 events.
e.g., calling $('select').select2() in an event handler on a single select with allowClear = true will prevent the empty option to be removed from the dropdown list, and the clear icon won't be displayed either.

@imlunek is there a way to add css class to the select2-container element? the containerCssClass adds the class to select2-selection

In case anyone was wondering, there's hacky approach to do this, requires using the theme option.
$('my-select').select2({
    theme: 'default your-container-class'
});

We don't have immediate plans to provide this. We are focused to fix some major UI bugs (that are majority of issues and PR's). But if you open a PR with unit tests, I will be glad to review and approve if everything is ok :+1:

I understand the requirement in principle, however it did end up working better on the selection than on the container, at least for me.
I got weird behaviour when styling the container, e.g. giving it button styles and clicking on it would highlight the internal selection element instead of the whole button.
Whereas if I styled the selection as a button the behaviour was as expected.

Hi everyone i need help
Currently search in dropdown textbox is based on name , i want tomake it search based on id nad name both:

@pedrofurtado This issue should be reopened -- like others above, I'm having to do all sorts of horrible tacky css workarounds due to an inability to style the base container. I've put in a PR for adding a class to the container.

Locking this as resolved, not because we added a new option to Select2 to support this but because the current official stance is that we will not be adding a native option for this. We have started to remove some of these extra options because they start to add up over time, so we're continuing to not add this one since it's an edge case that people have managed to work around as-needed.


Revert "[Autolink Extract] Keep a set of linker flags instead of vector"

Reverts apple/swift#58800
@compnerd brought up a good issue with this approach. Going to try something else shortly.

@swift-ci please smoke test


slice/skip: atomize SkipList.num operations

Hello there,
I needed to check the size of the skip list at some moments, it'd race otherwise.
Under heavy loads Len() can falsely return 0 on 50% of the requests !!
Cheers !

Raven
Number of Findings: 0

+1. Thank you!

+1


fix: SEPERATOR should be one EOL

also fix nsp check security warning

Coverage remained the same at 100.0% when pulling c5f4d8f63f0e3e1596db1501b184545c0632c976 on fix-double-eol into 61f56ae3bced4f0cd2ad80f6001c746489e6698f on master.

依赖 https://github.com/node-modules/logfilestream/pull/6

Coverage remained the same at 100.0% when pulling 4f95f8812e0de3a550222b94e643c14c8e670a10 on fix-double-eol into 61f56ae3bced4f0cd2ad80f6001c746489e6698f on master.

Coverage remained the same at 100.0% when pulling 7ff346ec4083cd5df49d014d486c8d5546b6d103 on fix-double-eol into 61f56ae3bced4f0cd2ad80f6001c746489e6698f on master.

@dead-horse 只改成修复安全问题，seperator 我在 cnpmjs.org 配置

Coverage remained the same at 100.0% when pulling 7425812e8249c19db9f977516c7878c168c04ae6 on fix-double-eol into 61f56ae3bced4f0cd2ad80f6001c746489e6698f on master.

Coverage remained the same at 100.0% when pulling 7b834372842808f6054dbc85a9c119cc74e6f43f on fix-double-eol into 61f56ae3bced4f0cd2ad80f6001c746489e6698f on master.

+1

1.1.1


Fix #1854: avoid using llvmpy wrappers in cgutils

Based on PR #1871.

[Current coverage][cc-pull] is 87.50%

Merging [#1886][cc-pull] into [master][cc-base-branch] will increase coverage by +<.01%

@@             master      #1886   diff @@
==========================================
  Files           292        292
  Lines         51981      52164   +183
  Methods           0          0
  Messages          0          0
  Branches       5368       5392    +24
==========================================
+ Hits          45461      45641   +180
+ Misses         5603       5601     -2
- Partials        917        922     +5

Powered by Codecov. Last updated by [1c6d133...3d0cac7][cc-compare]
[cc-base-branch]: https://codecov.io/gh/numba/numba/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/numba/numba/compare/1c6d1338da4635646ca769f24802fff442922b98...3d0cac775119cbc82363dcc710b20c890a212a41
[cc-pull]: https://codecov.io/gh/numba/numba/pull/1886?src=pr

@sklam: Can you review this?


NotPixel internal error

[!] Enter 1 For Adding Account and 2 for start mine + claim: 2
Warning! Most airdrops utilize UTC detection to prevent cheating, which means they monitor your sleep patterns and the timing of your tasks.
[x] NotPixel internal error. wait 5 minutes...
[+] Auto claiming started.
[x] NotPixel internal error. wait 5 minutes...

open notpixel manually 1 time.


[WIP] Nested file types, JS part

Coverage increased (+0.7%) to 99.078% when pulling 94c58e376923b9ebd4d880f1798604751b0b2d98 on aviav:nested-file-types into ebd202f2ce96cea53dc4fc84bc5ca6f17cd885f4 on tf:nested-file-types.

Coverage increased (+0.7%) to 99.078% when pulling 405a3b4044eae7837fc90fd6c8d80db8a249bef1 on aviav:nested-file-types into ebd202f2ce96cea53dc4fc84bc5ca6f17cd885f4 on tf:nested-file-types.

Coverage increased (+0.7%) to 99.078% when pulling 405a3b4044eae7837fc90fd6c8d80db8a249bef1 on aviav:nested-file-types into ebd202f2ce96cea53dc4fc84bc5ca6f17cd885f4 on tf:nested-file-types.


fix: remove minification on bundled code

Greasyfork doesn't tolerate minified code

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

:tada: This PR is included in version 1.5.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[SPARK-14277][CORE] Upgrade Snappy Java to <IP_ADDRESS>

What changes were proposed in this pull request?
Upgrade snappy to <IP_ADDRESS> to improve snappy read/write performance.
How was this patch tested?
Tested by running a job on the cluster and saw 7.5% cpu savings after this change.

Can one of the admins verify this patch?

Jenkins, this is ok to test.

LGTM pending Jenkins. Thanks!

Test build #54663 has started for PR 12096 at commit e5a35fc.

(Can you remove the "(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)" section from the PR Description?)

Test build #54663 has finished for PR 12096 at commit e5a35fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54663/
Test PASSed.

Merging to master. Thanks!
(By the way, please keep reporting these hotspots that your profiling is uncovering; this is very useful feedback.)

@JoshRosen - Thanks a lot for helping out on this. We are trying to port some of our large hadoop jobs to Spark and we are seeing these performance bottlenecks. We will definitely keep reporting them as we discover more.


Disable(/Enable) rules from code in keyword/test case block

It should be possible to disable/enable rules on Keyword and Test Suite level so that they are only applied inside that scope.
(like in PyLint)
F.g. If I would add following line:
# robocop: disable=too-many-calls-in-keyword
Inside keyword (after the settings) it would be valid only for that keyword.
These lines inside Keywords/Test Cases should be applied to rules for:

Keyword/Test Case name
Keyword/Test Case settings
Keyword/Test Case code

Hi, That is not exactly what I was looking for.
So in bellow code all the rules would affection the whole keyword and ONLY the keyword.

Rule1 could be a rule about the keyword name related issues
(This was in my original request but in fact this doesn't seem to work in pylint either so can be forgotten.)
Rule2 could be (in this case Documentation and Argument related issues
Rule3 could be about code lines before
Rule disables only affect in scope of this keyword and are automatically enabled when testing other parts of the file.

Connect Monitor
    [Documentation]    Connects to monitor.
    [Arguments]    ${timeout}=${None}
    # robocop: disable=rule1
    # robocop: disable=rule2
    # robocop: disable=rule2
    &{data} =    Connect To Monitor    ${IP_ADDRESS}    ${PORT}    connection_timeout=${timeout}
    _Set SW Tags    &{data}
    RETURN    &{data}

In pylint you can have this:
    def wait_alarm_audio(self, al_types, priorities=None, volume=None, repeat=None, timeout=2, no_wait=False):
        # pylint: disable=too-many-arguments
        """Waits for audio alarm"""

and it only silences too-many-arguments in that method.

With current implementation do they work normally if the lines:
 # robocop: disable=rule1
are inside a keyword implementation?

Ah, I see. So let's say you usually want to have missing-doc-keyword enabled but for sometimes you want to disable it. Right now you can do it using disablers in following way:
# robocop: disable=missing-doc-keyword
Connect Monitor
    [Arguments]    ${timeout}=${None}
    &{data} =    Connect To Monitor    ${IP_ADDRESS}    ${PORT}    connection_timeout=${timeout}
# robocop: enable

or
Connect Monitor  # robocop: disable=missing-doc-keyword
    [Arguments]    ${timeout}=${None}
    &{data} =    Connect To Monitor    ${IP_ADDRESS}    ${PORT}    connection_timeout=${timeout}

But you also want to be able to:
Connect Monitor
    [Arguments]    ${timeout}=${None}
     # robocop: disable=missing-doc-keyword
    &{data} =    Connect To Monitor    ${IP_ADDRESS}    ${PORT}    connection_timeout=${timeout}

Programmatically it can be done (we need to iterate through the node children to see any possible disabler comments) but it's still some extra effort required. We need to think if it'll be good addition or not. Main advantage is that the disablers comments are defined only right under the keyword and they are not in the same line as keyword name (which can decrease readability). The disadvantage would be more complications in our code and performance hit (albeit tiny).

That sums it up about right.
I use that all the time with pylint and I was thinking about what's the benefit compared what we have now.
At least one good use case came to my mind.
With the suggested feature the lines to disable/enable rule would follow the code when doing refactoring and moving keywords around and to other files.
With current way you will end up having multiple (extra) comment lines and you will need to track where are these disable/enable instructions, and copy or move those as well.
BTW.
Is there some recommended way to put those comment lines after keyword settings?
I noticed that Robotidy does this.
I'm not sure it should be forced. I personally would leave comments right after a keyword name, before settings.
Maybe it should be configurable option.
In fact, I would sort comment lines before/after settings at all.
Let's say this feature would be implemented and I would want to disable some rule that checks keyword(or test case) settings.
If I would use Robotidy which moves comments after the settings then they would not be disable the at right time.

No, there is not any recommended way. You probably refer to https://robotidy.readthedocs.io/en/stable/transformers/OrderSettings.html behaviour. It in fact first recognize setting lines, and order them accordign to the defined order. Comments are recognized as part of the keyword and moved as well. This may be good idea for feature request to ignore comments when sorting (or allow to configure it).
That being said, if we were to implement for such disablers in the Robocop, it would not matter where you place disabler comment. We would just iterate top level node children and seek comments. This will allow to accept both forms, depending on the user preference:
Keyword
    [Arguments]    too  many
    # robocop: disable=the-rule-with-too-many arguments

Keyword
    # robocop: disable=the-rule-with-too-many arguments
    [Arguments]    too  many

I have created issue in the Robotidy https://github.com/MarketSquare/robotframework-tidy/issues/468

Anywhere in the code section, but on the first level (not checking for,
if). But it would only apply to few rules disablers like missing doc, too
mamy arguments etc that check some specific block of code like test case or
keyword. Other rule disablers would work only for lines starting from where
they were define to the end of code block or next enabler.
wt., 21 lut 2023, 11:47 użytkownik jylind @.***>
napisał:

Thanks for creating the issue.
Just to clarify what do you mean by this sentence.
if we were to implement for such disablers in the Robocop, it would not
matter where you place disabler comment.
Are you referring to a situation where they are define in above/bellow
settings section, or as well, in general anywhere in the code section?
I was just wondering that when added inside the code section, there it
should still be possible to enable & disable depending on the code. Like
bellow.
Keyword
# robocop: disable=the-rule-with-too-many arguments
[Arguments]    too  many
Some keyword call
# robocop: disable=some-rule
Other keyword call
# robocop: enable=some-rule
and some more
—
Reply to this email directly, view it on GitHub
https://github.com/MarketSquare/robotframework-robocop/issues/777#issuecomment-1438259782,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBDAYXSET6GRGQ2FHSCUN3WYSMMTANCNFSM6AAAAAAVA6I2R4
.
You are receiving this because you commented.Message ID:
@.***>

I revisited this issue and these sentences sum the pros/cons quite well...
According to what you @bhirsz wrote here:

Main advantage is that the disablers comments are defined only right under the keyword and they are not in the same line as keyword name (which can decrease readability). The disadvantage would be more complications in our code and performance hit (albeit tiny).

Also, what @jylind wrote:

With the suggested feature the lines to disable/enable rule would follow the code when doing refactoring and moving keywords around and to other files.
With current way you will end up having multiple (extra) comment lines and you will need to track where are these disable/enable instructions, and copy or move those as well.

So there are some benefits for this enhancement. Not sure really how this will affect the performance, but from the feature point of view, I think it improves the overall experience, though not that much, since there are not many users applying for this change.
@bhirsz What do you think about this issue? Are we going to implement it?

Yes, it's valid request and we should implement it.

It's actually two issues:
One if that if rule is reported for the node, it doesn't detect disablers inside the node:
Keyword  # rule is reported here and does not detect following disabler
    # robocop: disable=too-many-arguments
    [Arguments]    too-many-arguments

And second is that disablers are working only with raw lines, not statements. In following example:
Keyword
    # robocop: disable=too-many-arguments
    [Arguments]    too-many-arguments

Keyword 2
    # robocop: disable=too-many-arguments
    [Arguments]    too-many-arguments

too-many-arguments will be reported for Keyword but not Keyword 2 since the disabler was added in previous keyword and never called off. It could be common misconception that disablers work only inside the scope of the node - similar as it's done in the Robotidy.
I will see if I can combine both and actually automatically reenable the rules that were disabled in given scope (when leaving the scope, ie going to different keyword) and allow to disable selected rules inside the node it's reported for.

One of the reason why it works that way is to integrate disabler feature seamlessly with RawFileCheckers and external rules (so the users don't need to configure anything extra to get disablers working).

In following example:
Keyword
    # robocop: disable=too-many-arguments
    [Arguments]    too-many-arguments

Keyword 2
    [Arguments]    too-many-arguments

too-many-arguments will be reported for Keyword but not Keyword 2 since the disabler was added in previous keyword and never called off.

You sure you didn't mean that "it will be reported both for Keyword and Keyword 2, since the disabler was added in the previous keyword and never called off"?

No, it will be reported for Keyword because disabler inside keyword is not detected. Then disabler is in use until its called off, thats why Keyword 2 will not be reported. The goal would be to have robocop disabler work only inside the scope they were defined (ie. if there is disabler inside for loop it should work there, not after the loop).

No, it will be reported for Keyword because disabler inside keyword is not detected. Then disabler is in use until its called off, thats why Keyword 2 will not be reported. The goal would be to have robocop disabler work only inside the scope they were defined (ie. if there is disabler inside for loop it should work there, not after the loop).

No, it will be reported for Keyword because disabler inside keyword is not detected. Then disabler is in use until its called off, thats why Keyword 2 will not be reported.

Oh, I get it, you're right.
That, what you described, would be more user-friendly, I guess.

Solved both issues in the branch https://github.com/MarketSquare/robotframework-robocop/compare/disablers_in_block?expand=1 I will raise PR later, which will be part of the upcoming 4.0.0 release.
I have rewritten disablers class completely from analysing the raw lines to visiting the Robot Framework file like a model (so it works the same as rules). Thanks for this disablers are now scope-aware.
As for too-many-arguments and similar rules, surprisingly we already had the solution in place. It is possible to configure additional lines that should be checked when checking if the line is disabled (ext_disablers). When creating the rule that is reported for parent node it needs to be properly configured.


Adding Taplytics

Hi @aglazer can you add a company profile for Talytics please?

Clearing off these older PRs, if you're able to complete a company profile in future for this company or another, please just open a new PR :+1:


Nuclear Accelerator should be banned from enemies because they can't use it anymore

The item was reworked and now works for enemies, therefore it will not be banned. Closing.


media picker is very slow on some queries

If I type 'partisan' into the search box for 'search all collections', it takes around a minute to return anything, with only the spinny thing indicating that anything is happening.

thanks for the super helpful profiling.  without looking at the code, my
guess is that the problem is that we're doing a like '%name%' search on the
tags tale, which use to be a few tens of thousands of rows and is suddenly
now millions.  I'll add a git issue to add a postgres fts index to the tags
table and change the api call to use it.
-hal
On Sun, Mar 4, 2018 at 8:48 AM, rahulbot<EMAIL_ADDRESS>wrote:

I think you're being polite - most searches are too slow. I did some quick
profiling on my machine (with caching disabled). Results:
Source Searching
I searched for "india" in the Explorer's media picker under "Search All
Sources":

0 secs: loading args
1 secs: searching - ie. a call to mediaList (with just a search_str)
adding in source count on first page (for first 40 sources):

~11 seconds if done serially
~1 second if done in parallel (with a Pool.map cal, pool size=10l)

0 secs: sorting by source count

Collection Searching
I searched for "partisan" in the Explorer's media picker under "Search All
Collections" (local url
http://localhost:5000/api/mediapicker/collections/search?media_keyword=partisan&which_set=5%2C1959%2C15765102
):

0 secs: loading args
~17 secs: searching - ie. a call to tagList with multiple tag_sets_id
(5-collections, 1959-partisanship, 1576102-geo) and a search_str
adding in source count on first page (for first 20 collections):

~47 seconds if done serially
~14 seconds if done in parallel (with a Pool.map call)

0 secs: sorting

31 (17+14) seconds doesn't quite equal a minute, but it sure is slow.
Turning off the source count sucks because it really helps you pick between
collections, but is worth it for results in half the time. So I should
probably do that.
Any way we can make those two queries faster (tagList with multiple
tag_sets_id args & mediaList with a tags_id arg)? Are there appropriate
indexes on those two tables to support these (super common) queries?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mitmedialab/MediaCloud-Web-Tools/issues/885#issuecomment-370234855,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvvT8E5Zfgs6zlBm1DjzdwxU47Wa_LLks5ta_7HgaJpZM4SbIcf
.

--
Hal Roberts
Fellow
Berkman Klein Center for Internet & Society
Harvard University

I have deployed changes that have speeded up many but not all queries.   Progress here: https://github.com/berkmancenter/mediacloud/issues/349


Modify Japanese translation file for editor

I modified Japanese translation mistake. Currently Japanese translation of "Selection to Subflow" is "サブフローの選択"("Select subflow"). "Selection to Subflow" should be "選択部分をサブフロー化"("Create subflow from selected flow").

Great - thanks!

Coverage decreased (-3.5%) to 83.777% when pulling 01a177adfb0bd9cf492d4c7a254cc99cfe060b63 on kazuhitoyokoi:master into 052b5e0ea8979f29bfa39a6434b41949cce17481 on node-red:master.

Coverage decreased (-3.5%) to 83.777% when pulling 01a177adfb0bd9cf492d4c7a254cc99cfe060b63 on kazuhitoyokoi:master into 052b5e0ea8979f29bfa39a6434b41949cce17481 on node-red:master.

Coverage decreased (-3.5%) to 83.777% when pulling 01a177adfb0bd9cf492d4c7a254cc99cfe060b63 on kazuhitoyokoi:master into 052b5e0ea8979f29bfa39a6434b41949cce17481 on node-red:master.


Fix/use template from temp llm config

Description
This depends on #589 so please merge that first
As described in the doc strings, LlmConfig can be assigned to app.llm.config for persistency. Alternatively, it can be provided as an argument to query or chat to be used for once function call only.
The problem with that was that the temporary assignment didn't always work as intended and some methods still used the actual app.llm.config.
With this change, the previous config is saved through serialization, then the temporary config is dropped in as a complete attribute replacement, getting assigned to app.llm.config. Finally, after the method has generated an answer the pervious config is deserialized.
This should be the safest way to assign the temp config, and it shouldn't be possible for any part of the code to ignore the temp config now.
If the method fails, for whatever reason, there's a try-finally block that should still restore the previous config.
If no custom config is used, none of this applies (no serialization or deserialization - no loss in speed).
The same logic could be used in retrieve_from_database, but we haven't encountered any issues there.
Fixes #584
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.

[X] Unit Test
[X] Test Script (please provide)

from string import Template

from embedchain import App
from embedchain.config import LlmConfig

einstein_chat_bot = App()

einstein_chat_template = Template(
    """
        You are Albert Einstein, a German-born theoretical physicist,
        widely ranked among the greatest and most influential scientists of all time.

        Use the following information about Albert Einstein to respond to
        the human's query acting as Albert Einstein.
        Context: $context

        Keep the response brief. If you don't know the answer, just say that you don't know, don't try to make up an answer.

        Human: $query
        Albert Einstein:"""
)

llm_config = LlmConfig(template=einstein_chat_template, system_prompt="You are Albert Einstein.")
query = "Where did you complete your studies?"
response = einstein_chat_bot.query(query, config=llm_config, dry_run=True)
print(response)
response = einstein_chat_bot.query(query, dry_run=True)
print(response)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules
[X] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@cachho : can you fix the merge conflict?
also can you add the example mentioned in PR to the docs?


Update README.md

Hey this is a new PR

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command
Blueprint environment

/qovery  preview aa190093-9b25-4c7c-8cbf-2c59eec4929d
blueprint-x

/qovery  preview c4b0fdf2-52b6-425d-8f36-9a2c978afbad
cloned-env

/qovery  preview {all|UUID1,UUID2,...}
To preview multiple environments

This comment has been generated from Qovery AI :robot:.
Below, a word from its wisdom :

Take rest sometimes

/qovery preview aa190093-9b25-4c7c-8cbf-2c59eec4929d

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
:point_right: [PR] blueprint-x - Update README.md - 2023-09-25T09:17:16Z
Another comment will be posted when deployments are terminated

Your preview environment has been successfully deployed !
Click on the link below to open your service:
:point_right: API Gateway
:point_right: Backend
:point_right: Backend 2
:point_right: Core Backend
:point_right: Frontend
:point_right: Dashboard
:point_right: SQS


Using various flags in huffman only and deflate compresssion/decompression

#include <fstream>
#include <memory>
#include <vector>

#include "qpl/qpl.h"

constexpr size_t MB = 1024 * 1024;
constexpr size_t MAX_FILE_SIZE = 100 * MB; // 100 MB in bytes

auto main(int argc, char* argv[]) -> int {
    if (argc != 2) {
        std::cerr << "Usage: " << argv[0] << " <input_file.bin>\n";
        return 1;
    }

    const char* input_file = argv[1];

    // Open input file
    std::ifstream file(input_file, std::ios::binary | std::ios::ate);
    if (!file) {
        std::cerr << "Error opening file: " << input_file << "\n";
        return 1;
    }

    // Get file size
    size_t file_size = file.tellg();
    if (file_size > MAX_FILE_SIZE) {
        std::cerr << "File size exceeds maximum allowed size of 100 MB.\n";
        return 1;
    }
    file.seekg(0, std::ios::beg);

    // Read file into source vector
    std::vector<uint8_t> source(file_size);
    if (!file.read(reinterpret_cast<char*>(source.data()), file_size)) {
        std::cerr << "Error reading file: " << input_file << "\n";
        return 1;
    }
    file.close();

    // Prepare destination and reference vectors
    std::vector<uint8_t> destination(file_size);
    std::vector<uint8_t> reference(file_size);

    std::unique_ptr<uint8_t[]> job_buffer;
    uint32_t size = 0;

    // Job initialization
    qpl_status status = qpl_get_job_size(qpl_path_software, &size);
    if (status != QPL_STS_OK) {
        std::cout << "An error " << status << " occurred during job size getting.\n";
        return 1;
    }

    job_buffer   = std::make_unique<uint8_t[]>(size);
    qpl_job* job = reinterpret_cast<qpl_job*>(job_buffer.get());

    status = qpl_init_job(qpl_path_software, job);
    if (status != QPL_STS_OK) {
        std::cout << "An error " << status << " occurred during job initializing.\n";
        return 1;
    }

    // Performing a compression operation
    job->op            = qpl_op_compress;
    job->level         = qpl_default_level;
    job->next_in_ptr   = source.data();
    job->next_out_ptr  = destination.data();
    job->available_in  = static_cast<uint32_t>(source.size());
    job->available_out = static_cast<uint32_t>(destination.size());
    job->flags         = QPL_FLAG_FIRST | QPL_FLAG_LAST | QPL_FLAG_OMIT_VERIFY;
    job->huffman_table = NULL;

    // Compression
    status = qpl_execute_job(job);
    if (status != QPL_STS_OK) {
        std::cout << "An error " << status << " occurred during compression.\n";
        return 1;
    }

    const uint32_t compressed_size = job->total_out;

    // Performing a decompression operation
    job->op            = qpl_op_decompress;
    job->next_in_ptr   = destination.data();
    job->next_out_ptr  = reference.data();
    job->available_in  = compressed_size;
    job->available_out = static_cast<uint32_t>(reference.size());
    job->flags         = QPL_FLAG_FIRST | QPL_FLAG_LAST;
    job->huffman_table = NULL;

    // Decompression
    status = qpl_execute_job(job);
    if (status != QPL_STS_OK) {
        std::cout << "An error " << status << " occurred during decompression.\n";
        return 1;
    }

    // Freeing resources
    status = qpl_fini_job(job);
    if (status != QPL_STS_OK) {
        std::cout << "An error " << status << " occurred during job finalization.\n";
        return 1;
    }

    // Compare reference functions
    for (size_t i = 0; i < source.size(); i++) {
        if (source[i] != reference[i]) {
            std::cout << "Content wasn't successfully compressed and decompressed.\n";
            return 1;
        }
    }

    std::cout << "Content was successfully compressed and decompressed.\n";
    std::cout << "Input size: " << source.size() << " bytes (" << source.size() / MB << " MB)"
              << ", compressed size: " << compressed_size << " bytes (" << compressed_size / MB << " MB)"
              << ", compression ratio: " << (float)source.size() / (float)compressed_size << ".\n";

    return 0;
}

The following code reads a file input of binaries and does the compression/decompression similar to the deflate compression/decompression example. When I run the code without the QPL_FLAG_DYNAMIC_HUFFMAN flag II get error code 217. How can I run a fixed block encoding and decoding program as I seem to be using the right combination of flags.

Hey @rohitpreddy07 , could you share the binary file that you are using for this? The compression/decompression job seems to be set up correctly, I wasn't able to reproduce this issue (Error Code 217). Could you also share which version of QPL you are using?

Hey @rohitpreddy07 , could you share the binary file that you are using for this? The compression/decompression job seems to be set up correctly, I wasn't able to reproduce this issue (Error Code 217). Could you also share which version of QPL you are using?

I am using QPL Version 1.6.0. Attached is the file that I am trying to execute the job on the following attached file.
model.layers.0.input_layernorm.weight[4096].zip

I tried to run your example, with your input. the only issue I encountered was that the file was not compressible, and as a result the destination size was too small.
The compressed size of the binary was 8197 while the non compressed size was 8192. Once, I extended the destination size, the reproducer didn't generate the 217 error code.


[Bug]: FAQ Page needs improvement

Give a brief about the bug ✍
Description
The FAQ page needs improvement in footer. There is a horizontal scroll bar which is not needed.
Irregular Orange colour box which should not be there. Footer does not matches the theme.
What is the expected behavior? 🤔
Description
Align the page perfectly
Improve footer
Avoid scrolling
Irregular objects needs to be removed
Provide step by step information reproduce the bug 📄
Description
Footer will made according to the theme
Removing unnecessary scroll
Remove Orange div
New Feature: when on faq is opened, others should be automatically close.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Also the orange div is present in about and contributors page as well. @ayush-t02


Tracksuit should be multi-tenant so we can have TrAAS

prs welcome

No CONTRIBUTING - don't know where to start

no


String.empty will still result in capturing NodeName and RoleInstance of computer

List of NuGet packages and version that you are using: 2.15.0
Runtime version (e.g. net461, net48, netcoreapp2.1, netcoreapp3.1, etc. You can find this information from the *.csproj file): 2.20.0
Hosting environment (e.g. Azure Web App, App Service on Linux, Windows, Ubuntu, etc.): Windows, Linux, Mac.

Describe the bug
We noticed we were unintentionally collecting computer node name in our PowerShell telemetry. We did a fix back in the fall and had the values for Context.GetInternalContext().NodeName and Context.Cloud.RoleInstance as string.Empty. This however did not fix the issue as expected and was recently brought to our attention. We created a new fix that can be seen here in this PR. https://github.com/PowerShell/PowerShell/pull/16981/files
We wanted to be sure you were aware of this regression and if there is any plans to add validation to ensure we do not regress again?
cc: @SteveL-MSFT, @JamesWTruher, @TravisEz13

If you populate a non-empty string to role/instance, then the built-in initializers does not override them.


ReactorContext should not expect input.getContext() to be GraphQLContext

The ReactorContextManager is expecting input.getContext() to always return a GraphQLContext, which can't be guaranteed. https://github.com/spring-projects/spring-graphql/blob/main/spring-graphql/src/main/java/org/springframework/graphql/execution/ReactorContextManager.java#L58
This is related to the discussion about GraphQLContext being extendable or not, and integration with DGS.
I think this code should use getGraphQLContext instead of getContext.
This might require the next version of graphql-java, since it's related to this PR: https://github.com/graphql-java/graphql-java/pull/2368/files

Yeah, I guess for now we can use it conditionally, only if it is an instance of GraphQLContext but it does mean that it won't be able to propagate context.

@paulbakker as discussed offline, I'll re-purpose this to be an upgrade to version 17 (or rather the current, pre-17 master build) and I'll change our code to use the new getGraphQLContext method. Is that OK with you?

yes please!

The main branch is now using the new getGraphQLContet().


update date

Hi @duongau - This PR was opened in the public repo. We'll merge the PR, but would you make future updates in the private repo? Thanks. (I assume you intended to use today's date, so I edited the year to 2021.)


Extension has recently started causing playlist pages to go into an "infinite loading loop"

Issue has only started recently (last few days!)
To replicate: Load any playlist page on YouTube. The page keeps trying to load. Might be connected to disable polymer in the URL?
Disabling the extension causes the issue to stop, but obviously the extension cannot be used when its disabled

Yes I am having this problem as well.


Paratext step text has a "/fig" instead of a "\fig"

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Manual fix in process


UI - Pipeline publish catalog app text validate result error

Steps to reproduce:

Edit pipeline configuration, add a step
Step type selection "publish catalog app"
Set configuration information

Result:

Git URL starts with HTTP but prompts an error message

Select the ssh protocol and select the correct secret(deploy_key), but an error message will be prompted

Tested with version -2.2 master 12/27

The verification prompt information of Git URL is correct.
DEPLOY_KEY is case sensitive and the check is correct


Prometheus parsing error

Hi,
I'm having trouble with parsing metrics in prometheus.
When I start prometheus, I get the following error:
target=http://localhost:59404/metrics-text msg="append failed" err="invalid metric type "GAUGE"
This probably has to do with the metric type being in upper case instead of lower case as prometheus expects: # TYPE application_httprequests_apdex GAUGE
After looking for the at the DataContract.cs for prometheus it seems that the enum MetricType is the culprit:
    [global::ProtoBuf.ProtoContract(Name = @"MetricType")]
    public enum MetricType
    {

        [global::ProtoBuf.ProtoEnum(Name = @"COUNTER", Value = 0)]
        COUNTER = 0,

        [global::ProtoBuf.ProtoEnum(Name = @"GAUGE", Value = 1)]
        GAUGE = 1,

        [global::ProtoBuf.ProtoEnum(Name = @"SUMMARY", Value = 2)]
        SUMMARY = 2,

        [global::ProtoBuf.ProtoEnum(Name = @"UNTYPED", Value = 3)]
        UNTYPED = 3,

        [global::ProtoBuf.ProtoEnum(Name = @"HISTOGRAM", Value = 4)]
        HISTOGRAM = 4
    }

actually, that's something they introduced in 2.4.0  and Prometheus 2.3.2 still works with current format


Error when creating DB schema with composite primary key

I try to mock a large DB model with Effort. During the creation of the DB scheme (Effort.EntityConnectionFactory.CreateTransient) an error is thrown with the error message: InvalidOperationException: There is no coersion operator defined between the System.Int64 and System.String types. I've debugged this error to find out if there is somewhere a type missmatch in the data model.
What I found out is that this error is caused by two tables which are linked with a composite primary key (pk fields are: EntranceId, ServiceType, DiversionId). The data types of of the primary key fields are long, string and string. Inside the method Configure (class RelationConfiguration) two IKeyInfo objects are created with the two primary keys. This is done with a call to RelationConfiguration.EnsureKey -> here a tuple is created with the pk members and its datatypes. Unfortunately this methods generates two different tuples for the two composite primary keys. On tuple with the type Tuple<string,string,long> and the other with the type Tuple<long,string,string>. I guess this is why the above mentiond exception is thrown from the method CreateConverter (class RelationConfiguration).
Any hint to workaround this problem or a fix would be highly appreciated. Thx!
Here is the complete callstack:
System.Reflection.TargetInvocationException : Ein Aufrufziel hat einen Ausnahmefehler verursacht.
----> System.InvalidOperationException : Zwischen den Typen "System.Int64" und "System.String" ist kein Koersionsoperator definiert.
bei System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
bei System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
bei System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
bei Effort.Internal.DbManagement.Schema.Configuration.RelationConfiguration.CreateConverter(MethodInfo converterMethod, IKeyInfo primaryKeyInfo, IKeyInfo foreignKeyInfo, IRelationContraint[] relationConstraints)
bei Effort.Internal.DbManagement.Schema.Configuration.RelationConfiguration.Configure(AssociationInfo associationInfo, DbSchemaBuilder builder)
bei Effort.Internal.DbManagement.Schema.Configuration.RelationConfigurationGroup.Configure(AssociationInfo associationInfo, DbSchemaBuilder builder)
bei Effort.Internal.DbManagement.Schema.DbSchemaFactory.CreateDbSchema(StoreItemCollection edmStoreSchema)
bei Effort.Internal.DbManagement.DbContainer.b__0(StoreItemCollection sic)
bei Effort.Internal.Caching.DbSchemaStore.<>c__DisplayClass1.b__0()
bei System.Lazy1.CreateValue()    bei System.Lazy1.LazyInitValue()
bei System.Lazy1.get_Value()    bei Effort.Internal.Caching.ConcurrentCache2.Get(TKey key, Func1 factory)    bei Effort.Internal.Caching.DbSchemaStore.GetDbSchema(StoreItemCollection metadata, Func2 schemaFactoryMethod)
bei Effort.Internal.DbManagement.DbContainer.Initialize(StoreItemCollection edmStoreSchema)
bei Effort.Provider.EffortProviderServices.<>c__DisplayClass4.b__3(DbConnection x)
bei Effort.Provider.EffortProviderServices.Wrap[T](DbConnection connection, Func2 action)    bei Effort.Provider.EffortProviderServices.DbCreateDatabase(DbConnection connection, Nullable1 commandTimeout, StoreItemCollection storeItemCollection)
bei System.Data.Entity.Core.Common.DbProviderServices.CreateDatabase(DbConnection connection, Nullable1 commandTimeout, StoreItemCollection storeItemCollection)    bei System.Data.Entity.Core.Objects.ObjectContext.CreateDatabase()    bei Effort.EntityConnectionFactory.CreateEntityConnection(MetadataWorkspace metadata, DbConnection connection)    bei Effort.EntityConnectionFactory.CreateTransient(String entityConnectionString, IDataLoader dataLoader)    bei Effort.EntityConnectionFactory.CreateTransient(String entityConnectionString)    bei Hexagon.SI.CH.Cad.Utils.CadEntities.CadContextTests.Test() in D:\Hexagon.SI.CH.Cad.Utils\Hexagon.SI.CH.Cad.Utils.Tests\CadEntities\CadContextTests.cs:Zeile 12. --InvalidOperationException    bei System.Linq.Expressions.Expression.GetUserDefinedCoercionOrThrow(ExpressionType coercionType, Expression expression, Type convertToType)    bei System.Linq.Expressions.Expression.Convert(Expression expression, Type type, MethodInfo method)    bei NMemory.Common.KeyExpressionHelper.CreateKeyConversionExpression(Expression source, MemberInfo[] toMembers, Int32[] mapping, IKeyInfoHelper from, IKeyInfoHelper to)    bei NMemory.Tables.RelationKeyConverterFactory.CreateConversion[TFrom,TTo](IKeyInfo1 fromKeyInfo, IKeyInfo1 toKeyInfo, Int32[] mapping)    bei NMemory.Tables.RelationKeyConverterFactory.CreatePrimaryToForeignConverter[TPrimaryKey,TForeignKey](IKeyInfo1 primaryKey, IKeyInfo`1 foreignKey, IRelationContraint[] constraints)

Hello @rolphes ,
Do you think you could provide us a test project with this issue?
It will make easier/faster for my developer to getting started for investigating it.
We now always ask for a project since we found out that most issues are missing some essential information or are resolved by the requestor when creating it
(Even if the issue seem very easy to reproduce, by getting a test project, it allow us to give a faster support and better experience for the support of all our free libraries)
Best Regards,
Jonathan

Performance
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Bulk Operations •  Dapper Plus •  LinqToSql Plus
Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

Hi Jonathan
Thanks for your feedback. The framework I'm trying to mock is a third party library from a commercial product. So I cannot submit you an example project with this referenced assemblies. But I hope I can extract the relevant parts into a project where the error can be reproduced.
Regards,
Rolf

Hi Jonathan
Finally I was able to isolate and reproduce the bug in a simple test project with three related entities (see attachment EffortTestCompositeKeys.zip). To reproduce the bug just build the project and execute the contained unit test "CreatingEffortConnectionForCompositeKeysShouldWork".
Since I forked the source code from GitHub I could actually find the reason for the bug. But first lets hav a look at the db scheema of the test entities:

The entity "EntranceServiceDiversion" has a composite primary key built form three properties and has a relation with the entity "EntranceServiceDiversionHis". Additionally the entity "FacilityAuditLog" is referenced with the same entity with its primary key (ChangeId). So the entity "EntranceServiceDiversionHis" has a composite key built from four properties.
A consequence of this constellation is that the IKeyInfo is generated in two different ways:

One time with the  method tableBuilder.FindKey -> here the properties are ordered alphabetically by name to create the tuple
One time with the method CreateKeyInfo -> here the properties are not ordered
This different implementations lead to the described bug

One important aspect of this issue is that the properties building the referntial constraint in the CSLD and SSDL definitions must not be in alphabetical order -> otherwise the bug cannot be reproduced. I realized that the model designer from Visual Studio 2017 will reorder this properties when the db schema is recreated. So I had to manually change the order of the properties to produce the error. But this bug is still crucial because it also occource with the used third party libray where I cannot change the order of the properties.

I guess fixing this bug shouldn't be that hard. I was able to temporary fix the problem on my fork by ordering the members in the method EnsureKey.
       `  if (keyInfo == null)
        {
            members = members.OrderBy(m => m.Name).ToArray();
            keyInfo = KeyInfoHelper.CreateKeyInfo(tableBuilder.EntityType, members);
            tableBuilder.AddKey(keyInfo, unique);
        }`

I hope that you can reproduce and fix this issue soon. Just ask if you have any questions.
Best regards,
Rolf

Thank a lot @rolphes ,
We will add the request to our to-do list for the next week.
Best Regards,
Jonathan

Hello @rolphes ,
Just to let you know that we started to investigate the issue.
We discovered there is one major problem for the composite key with different type since some expression built doesn't have the right type order.
We started to fix it in some methods but we found out that the issue is in multiple methods.
We will continue to check it but it seems the issue is bigger than we first thought.
Best Regards,
Jonathan

Any news concerning this issue?

Hello @rolphes ,
Sorry for the very big delay,
The v1.3.10 has been released which should fix this issue.
If you have the chance to test it again, let me know if that works correctly.
Best Regards,
Jonathan

Great ;)


example: remove usage of the Restorer interface

Fix #174
This interface has been removed in PR #130, it shouldn't be used
anymore.

The test failure is clearly not due to this PR, looks like megacheck was updated, and we're not pinning the version used in CI.

we're not pinning the version used in CI.

I would argue that is a good thing @pdf since it found a real issue I think 😃

Feel free to send a PR to add yourself to https://github.com/gopherjs/vecty/blob/master/CONTRIBUTORS if you'd like @tbruyelle :)


[NetAppFiles] fix default in volumeproperties

This if fixes a problem with a default value for defaultUserQuotaInKiBs and defaultGroupQuotaInKiBs in volumeProperties  did not match the default for "same" in  volumePatchProperties .
The original PR was merged short while ago no SDK's have been generated from it.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@raych1 We would like this addressed quickly the original PR was https://github.com/Azure/azure-rest-api-specs/pull/15011
And was just merged few hours ago Aug 18 2021.

As the previous RP just merged a couple of hour ago, it won't cause any impact to end user, so add the label of approved breaking change.


fix:global css isnt the same in  component-test and website

What is it?

[x] Feature / enhancement
[x] Bug
[x] Docs / tests
[x] Other

Why is it needed?

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[ ] I have add necessary docs (if needed)
[ ] Added new tests to cover the fix / functionality

it will effect that i'm developing component,
because global css can't work


Chart: explicitly set default fsType to EXT4

This allow Kubernetes to properly changes the volume ownership
and permissions when user specify fsGroup in workload pod
longhorn/longhorn#2964

Quick question: If the filesystem type is not set in the CSI provisioner, does adding this field in StorageClass work?

Yeah. CSI provisioner check and see that the SC has fsType so it use it regardless of whether we set the default fs in csi provisioner

Quick question: If the filesystem type is not set in the CSI provisioner, does adding this field in StorageClass work?

Yeah. CSI provisioner checks and see that the SC has fsType so it uses it regardless of whether we set the default fs in csi provisioner

Great. Then please:

mention this as a workaround in both https://github.com/longhorn/longhorn/issues/2964#issuecomment-910969543 and the Slack channel.
Update the default StorageClass and the example StorageClass

@shuo-wu we discussed in Slack that we don't want to recommend user to change longhorn SC so we don't want to mention this workaround.
I will update the SC example.


optimize: channel alive check

[x] I have registered the PR changes.

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes #4002
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #4013 (21d7dae) into develop (f028831) will increase coverage by 0.03%.
The diff coverage is 43.15%.

@@              Coverage Diff              @@
##             develop    #4013      +/-   ##
=============================================
+ Coverage      49.34%   49.37%   +0.03%
- Complexity      3721     3724       +3
=============================================
  Files            692      692
  Lines          23419    23377      -42
  Branches        2902     2853      -49
=============================================
- Hits           11555    11543      -12
+ Misses         10701    10652      -49
- Partials        1163     1182      +19

Impacted Files
Coverage Δ

...io/seata/core/rpc/netty/AbstractNettyRemoting.java
14.28% <0.00%> (ø)

...a/io/seata/discovery/registry/RegistryService.java
0.00% <0.00%> (ø)

...source/exec/mysql/MySQLInsertOrUpdateExecutor.java
31.42% <ø> (-0.04%)
:arrow_down:

...urce/exec/postgresql/PostgresqlInsertExecutor.java
43.75% <0.00%> (ø)

...seata/rm/datasource/undo/AbstractUndoExecutor.java
66.90% <0.00%> (ø)

...ta/spring/boot/autoconfigure/StarterConstants.java
0.00% <ø> (ø)

...figure/properties/registry/RegistryProperties.java
37.50% <0.00%> (-22.50%)
:arrow_down:

.../src/main/java/io/seata/server/env/PortHelper.java
0.00% <0.00%> (ø)

...ure/properties/server/store/StoreDBProperties.java
28.07% <25.00%> (-0.24%)
:arrow_down:

server/src/main/java/io/seata/server/Server.java
75.00% <33.33%> (-5.00%)
:arrow_down:

... and 49 more


Unexpect exception (allocate memory failed) on fast interpreter mode

Build commands
I compile the code with commit id 92bf8547aa64dddad2ecd387a352f89bbc475c88.
Platform: Ubuntu 20.04
CPU: amd64
compile:
export CC=/usr/lib/llvm-16/bin/clang
export CXX=/usr/lib/llvm-16/bin/clang++
cd product-mini/platforms/linux/;rm -rf build
cmake  -DWAMR_BUILD_INTERP=1 -DWAMR_BUILD_REF_TYPES=1 -DWAMR_BUILD_SIMD=1 -DWASM_ENABLE_BULK_MEMORY=1 -DWAMR_BUILD_AOT=0 -DCMAKE_BUILD_TYPE=Release -DWAMR_BUILD_FAST_INTERP=1 -DWAMR_BUILD_LIBC_WASI=0 -DWAMR_BUILD_LIBC_BUILTIN=1 -Bbuild

execute:
iwasm --heap-size=0  <tc_name>

Cases
iwasm_fast_interp_unexpected_exception2.zip
Actual behavior:
Exception: allocate memory failed

Expected behavior:
No exception
0x16006d52ce3ebd1a:i64

Thanks for reporting this, we've fixed in https://github.com/bytecodealliance/wasm-micro-runtime/pull/2974

Close this issue since it was fixed.


[CARBONDATA-1305] Add limit for external dictionary values

Analysis: During dictionary creation the dictionary values are kept in a HashSet. When the size of hashset reaches more than 500000000 this exception is thrown.
Solution: Limit the dictionary values to 10000000

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Build Failed with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/462/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3050/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3051/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/463/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/471/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3060/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3078/

Build Failed with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/489/

Build Failed with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/490/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3079/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3081/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/492/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/590/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3185/

Build Success with Spark 1.6, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/591/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3186/

Can one of the admins verify this patch?

SDV Build Success with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/327/

SDV Build Success with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/336/

retest this please

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/489/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/501/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/508/

SDV one failure is common across other PRs

LGTM


Provisioner Wizard Validation

enforce unique cluster name

enforce required fields

cidr regex

order regions and azs by name

validate machine configuration

add style to stepper next and back focus

Coverage remained the same at 60.027% when pulling 4230fd80ed6123e602256a763a667eb3adc05829 on josephkane:pro-wizard-validation into cac16faf18ec6e9aee1cd0574fb89a64567bede9 on supergiant:master.


Locker

Is your feature request related to a problem? Please describe.
Users often struggle to manage and organize their favorite items across multiple websites, leading to cluttered tabs and difficulty finding specific items when needed.
Describe the solution you'd like
Develop a browser extension called "Locker" that aggregates and organizes users' wishlists from various websites into one centralized platform. This extension should allow users to browse, save, share, and recommend their favorite items across thousands of brands and websites, making it easier to keep track of and manage their preferences.
Describe alternatives you've considered
One alternative could involve integrating similar functionality into existing bookmarking or shopping management apps that users already use regularly. Additionally, users could have the option to customize their preferences and categorize their saved items into collections for easier organization and sharing with friends.
Additional context
The goal of this feature is to streamline the process of managing and accessing favorite items across multiple websites by providing users with a centralized platform for organizing their wishlists. Completion of this feature can be evaluated based on user feedback regarding the effectiveness of the platform in simplifying the wishlist management process and improving overall shopping experience. Additionally, monitoring any changes in user engagement or satisfaction with the platform while using the extension can help assess its impact on overall user experience and retention.

@Sulagna-Dutta-Roy  PLEASE ASSIGN ME THIS ISSUE

Contributor has received the limited points.


Plan telemetry for crash logging and user interaction logging

Issues:

Needs to work off line
Needs to adapt to privacy-conscious users
Use a library if possible
Have some idea of what questions we want to have answered using data from the system

See notes on paper (Rasmus's note book) from meeting with Jason from Rumie, July 19, 2018.

See https://github.com/pg-irc/pathways-frontend/issues/177


Add a philosophy section

Also expand the example class a little bit to stress that we're not just
about data containers.
This is kind of a response to questions and concerns that come up in issues – and places that shall not be named –  frequently.
I’d some love feedback from people who understand attrs and what it stands for.   Ideally also from people who have better words than I.
I really just want to link there and drop the mike in the future.
cc  @hawkowl @glyph @cyli @econchick @Tinche @cournape @mithrandi

Current coverage is 100% (diff: 100%)

Merging #73 into master will not change coverage

@@           master   #73   diff @@
===================================
  Files           8     8
  Lines         395   395
  Methods         0     0
  Messages        0     0
  Branches       87    87
===================================
  Hits          395   395
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update ce0f82a...833e045

👍

If by 'places that shall not be named' you mean Hacker News like was mentioned on Twitter, I don't go there so I don't know exactly what their complaints are.
I use attrs a lot for what you call 'data-only' containers (Java folks would call these DTOs I guess, or data transfer objects), maybe with some properties or helper methods mixed in. You make a point of attrs not being only for this kinds of classes, but I find 1) attrs works best for these kinds of classes and 2) it's actually in your best interest to have many of these kinds of classes. So I like the fact attrs is opinionated (as much as it is) and I like its opinions :) I'm not sure how to turn this paragraph into an actionable item for the philosophy section :)
Another thing I love about attrs is that it's declarative. It's a damn shame we've had to wait this long to get proper declarative classes into Python (with an API I actually want and like to use). An anecdote: I work in mobile games. We use Python on the backend and, nowadays, C# for the games themselves. There is data that's shared between the client and the server, things like request and response formats, the player save game, and game data itself (every game has a database of domain-specific data, for example a cooking game might have a list of food, ingredients, appliances, restaurant furniture etc). Recently I've started using attrs for some of these classes on the backend, where before they used to be pure dictionaries. Now that we have this data in a declarative format in code, I'm seriously considering generating C# classes from them, so we'd have to define our data only once and save a bunch of manual labor. attrs makes this possible and easy.
Maybe another thing we could touch on is structured data vs unstructured data, and how attrs classes are superior to dictionaries. For example, when you turn your unstructured data into classes, there's validation at the point of conversion instead of point of use, which is exactly what you want. Type checking becomes possible (I don't know how well mypy handles attrs, but PyCharm handles them just fine with extra type hints, and I rely on this daily, for correctness and autocomplete).
I'm not sure this is material for the philosophy section, more for the "why" section. My philosophy would be 'use attrs for what it's great for, and reap the massive benefits it brings, even if you have to change your thinking a little'.

I’d wish to expand the “why not dicts” section but I’m tired and out of words.  if someone could write something coherent, that would be really greeeeat. ;)


Revert "build(deps): bump docutils from 0.17.1 to 0.18 (#133)"

This reverts commit 68c63aca82f6fc6635f45fc4b4a8177946a7941d.

Codecov Report

Merging #134 (68c63ac) into master (68c63ac) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 68c63ac differs from pull request most recent head 45a2a7f. Consider uploading reports for the commit 45a2a7f to get more accurate results

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   93.53%   93.53%
=======================================
  Files          19       19
  Lines        2678     2678
=======================================
  Hits         2505     2505
  Misses        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c63ac...45a2a7f. Read the comment docs.


docs: update CRD note in upgrade guide

Fixes #N/A
Description
Updates the CRD upgrade description to emphasize the link between CRD version and provider version, and codifies the recommendation to use the independent CRD chart.
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.022%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
5733

Relevant Lines:
8817

💛  - Coveralls


post-css-next custom-media doesn't work with @import or inheritance

I am not sure, it's problem of vuejs-templates, but maybe it worth to report for some user.
Anyway, here is my structure.
project-root > src > App.vue
project-root > src > variables.css
project-root > src > components > Header.vue

Working Case
At this case, vue file has @custom-media and it's consumer @media, works just fine.
<style>
@custom-media --md (width >= 768px) and (width <= 991px);
.title {
  font-size: 2rem;
  @media (--md) {
    font-size: 1.5rem;
  }
}

@import Case
/* variables.css */
@custom-media --md (width >= 768px) and (width <= 991px);

// App.vue

<style>
@import "./variables.css"

.title {
  font-size: 2rem;
  @media (--md) {
    font-size: 1.5rem;
  }
}
</style>

If I try @custom-media to outside file then import in the vue file, it does not work. There is no error message neither browser nor console. In the browser, seems not to render whole @media phrase.
Inheritance Case
// App.vue
<template>
  <header></header>
</template>

<style>
@custom-media --md (width >= 768px) and (width <= 991px);
</style>

// Header.vue
.title {
  font-size: 2rem;
  @media (--md) {
    font-size: 1.5rem;
  }
}

Expect to render @media(width >= 768px) and (width <= 991px) but same as @import case.
Any clues here?

A couple things:

CSS variables should to be set in :root { } http://cssnext.io/features/#custom-properties-var (that won't help your situation though)
Header.vue and App.vue aren't exactly aware of each other. What I do is have a shared.css that I @import in components that need access to the same variables (I just have a strict rule not to allow anything to actually output anything in here).

Here's my vue-cli template that sounds like it's set up very similar to what you'd like: https://github.com/crswll/vue-starter/ might be easier to just vue init crswll/vue-starter whatever and take a look at what it outputs.

I had the same problem! So, i just tried to put this plugin with the others: https://github.com/postcss/postcss-import
And in my code, I do:
<style>
@import 'shared.css';

@media (--phone) {
... code
}
</style>

And works!


Missing Python3 support

On http://couchdbkit.org/download.html
you can read for a really long time:
Couchdbkit requires python2.x >= 2.5.4 to work. python 3.x will be supported soon.

But there still seems to be no Python3 support. Are there any news - anything to try or test?

Hey @benoitc, is it likely to go ahead any time soon? I have a project that I can't upgrade to python 3 without it... I can see there is a relevant PR for restkit, what's the showstopper? Happy to help if I can.


allow TriggerDagRunOperator implementors to update dag id at runtime

Make sure you have checked all steps below.
JIRA

My PR addresses the following [AIRFLOW-1975]

Description

[ ] This exposes the dag id to be triggered so that implementors may update it at runtime

Documentation

TBD

Please follow the commit guidelines

hi @fokko I would be happy to comply when I have time. please  consider that current airflow code is a hot mess and the emphasis on "Guidelines" will lead to slower improvement and very very small upside in terms of commit quality.

@andy-d improving hot mess starts with properly described commits and the upside is mucher larger than you seem to be assuming. Improving hot mess also starts with having tests against functionality you are adding.


fips should print an error message when run outside the "expected" directory.

See this issue for details: https://github.com/floooh/fips/issues/239

...it actually works as intended on macOS and Linux, since those run the fips python script directly. But on Windows, the fips.cmd wrapper is run, which looks like this:
@python fips %*

What this actually tries to run is the fips directory as a python script, thus the error.


Additional popupbox styles

Support for IsEnabled on PopupBox and styles for use when combining MaterialDesignFlatButton with PopupBox

:+1: thanks!


Can't install extensions for WSL2 (Ubuntu 20.04)

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.56.0
OS Version: Windows_NT x64 10.0.18363
WSL Version: Ubuntu 20.04.02

Steps to Reproduce:

Open a new remote window in WSL
Try to install any extension using install in WSL

I was trying to install cpptools extension for my WSL Ubuntu system. When I click the "install in WSL: Ubuntu-20.04" button, the button's text turned into "installing" and nothing else happend. Then the fan of my laptop started to running heavily. After about half an hour, the progress stopped and it says "Can't reconnected. Please reload the window.". Whatever I chose "Reload" or "Cancel", nothing changed.
I have tried several times, including install manully from "cpptools-linux.vsix", or install other extensions. It just failed in similar situation. But I can install extensions for the Windows 10 host system.

vscode log window.txt
vscode log remote server.txt

I tried on another laptop and changed network too. It STILL didn't work.
But I found an alternative solution. That is using Remote SSH other than Remote WSL. And treat WSL as an remote Linux system.
I turned sshd server on by sudo service ssh start in WSL, and configured RSA login for windows. Then add that to Remote SSH configuration of VsCode. Finally it worked.
But I still hope someone can tell me why Remote WSL didn't work on my laptop.

Enable log level to trace using command F1 > Set Log Level and please provide following logs while installing the extensions?
- Help -> Toggle Developer Tools -> Console
- View -> Command Pallette... -> Toggle Shared Process -> Console
- View -> Open View… -> Log (Shared)
- View -> Open View… -> Log (Window)
- View -> Open View… -> Log (Remote Server)

I started to install Docker extension at 4:30. The process lasted about half an hour, my laptop was getting much hotter. And It finally Disconnected from WSL.
Please check the log files.
Console:
log_console.txt
Shared Process Console:
log_shared_process_console.txt
Log (Shared):
log_shared.txt
Log (Window):
log_window.txt
Log (Remote Server):
log_remote_server.txt

Looks like there is connection issue
   at FileReader.E._fileReader.onload (workbench.desktop.main.js:634)
workbench.desktop.main.js:627   ERR [remote-connection][Management   ][ca878…][reconnect] A permanent error occurred in the reconnecting loop! Will give up now! Error:
workbench.desktop.main.js:627   ERR Error: Connection error: Unknown reconnection token
    at W (workbench.desktop.main.js:634)
    at workbench.desktop.main.js:634
    at l.fire (workbench.desktop.main.js:60)
    at o.fire (workbench.desktop.main.js:76)
    at i._receiveMessage (workbench.desktop.main.js:76)
    at workbench.desktop.main.js:76
    at l.fire (workbench.desktop.main.js:60)
    at u.acceptChunk (workbench.desktop.main.js:76)
    at workbench.desktop.main.js:76
    at workbench.desktop.main.js:634
    at l.fire (workbench.desktop.main.js:60)
    at FileReader.E._fileReader.onload (workbench.desktop.main.js:634)
workbench.desktop.main.js:627 TRACE DialogService#show Cannot reconnect. Please reload the window.
workbench.desktop.main.js:2710 Extension host terminated unexpectedly.  Canceled
workbench.desktop.main.js:627  INFO Trying to download 'ms-azuretools.vscode-docker' extension locally and install
workbench.desktop.main.js:627   ERR Canceled: Canceled
    at Object.g [as canceled] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:8:1157)
    at Object.call (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:1927)
    at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:76:7092
    at async c.downloadCompatibleAndInstall (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2710:87589)
    at async c.doInstallFromGallery (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2710:87369)
    at async c.installFromGallery (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2710:86746)
    at async Promise.all (index 0)
    at async Object.G [as settled] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:68:21704)
    at async ss.installFromGallery (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2705:18824)
workbench.desktop.main.js:627   ERR [remote-connection][ExtensionHost][a9613…][reconnect] permanent failure occurred while running the reconnecting loop.

Assigning to @alexdima and @aeschli for further investigation

When you install, do you get to the point where the C++ install progress appears?
e.g.

Can you check the Output / C++ view if you see this:
Updating C/C++ dependencies...

Downloading package 'C/C++ language components (Linux / x86_64)' (10575 KB)  Done!
Downloading package 'ClangFormat (Linux / x86_64)' (868 KB)  Done!
Downloading package 'Mono Framework Assemblies' (5368 KB)  Done!
Downloading package 'Mono Runtime (Linux / x86_64)' (1862 KB)  Done!

Installing package 'C/C++ language components (Linux / x86_64)'
Installing package 'ClangFormat (Linux / x86_64)'
Installing package 'Mono Framework Assemblies'
Installing package 'Mono Runtime (Linux / x86_64)'

Finished installing dependencies

Also, can you install an older version of the extension?
In the extensions view, in the gear, choose Install Another Version.

@sandy081 I couldn't figure out what exactly the connection issue is. Arn't WSL and Windows host machine in the same network? But I can install extensions for Windows host machine with no errors......
Or are there any COMMANDS I can test in WSL manually to confirm?
Sorry I can't provide more information.  If there are not enough information to handle this weird issue by now, I think maybe I just close it.

@aeschli I didn't see anything you mentioned. It's not just c/c++, I tried many other extensions and they all failed with no obvious outputs. I just saw the memory of my laptop rising intensely. But in Windows host machine they all were installed smoothly. I also tried install extension from a vsix file, it failed in the same behaviour.
Sorry I can't provide more information except the log files above.

Sorry that I was not clear. By connection issue I mean VS Code connecting to VS Code server installed in WSL.