Reformat source code for consistent use of whitespace.

Fixes #147.
I created a code style for Intellij IDEA (checked in at etc/IntelliJ IDEA Code Style.xml) and ran Reformat Code.  All source code changes should be whitespace and braces only.

Coverage decreased (-0.8%) to 62.13% when pulling 9293243d4d14631983eec859ee88ea183f5ab341 on heuermh:reformat-source-code into 710cfc84ea703113780fde7968038d24735d6f64 on HadoopGenomics:master.

+1!

Thanks for doing this @heuermh!
The code style and particularly the whitespace is particularly inconsistent in this codebase, so I'm +1 on fixing it. I think we should do it in a major release, though, since it's quite a disruptive change.
Also, I think we should enforce the style by using checkstyle or similar. I started writing a PR a while ago to do this, it's incomplete, but you can see the idea here: https://github.com/HadoopGenomics/Hadoop-BAM/compare/master...tomwhite:checkstyle?expand=1
What do you think?

Also, I think we should enforce the style by using checkstyle or similar.

I agree, and as an example have it configured here
https://github.com/heuermh/dishevelled/tree/master/compress/src/build/conf
https://github.com/heuermh/dishevelled/blob/master/parent/pom.xml#L315
We would need to sync the configuration in the source code formatter with that enforced by checkstyle.
ADAM formats source on the fly as part of the build, I think that might be more trouble than it is worth.

Great!

ADAM formats source on the fly as part of the build, I think that might be more trouble than it is worth.

Agreed.

+1

Coverage decreased (-0.8%) to 62.539% when pulling 3a534d0e21327323faf96d1d82da22c17b309843 on heuermh:reformat-source-code into e4224ab7b3b1ecc463e34252ab340f223d8e3acb on HadoopGenomics:master.

Rather than choosing our own formatting preferences, I would rather choose an existing style guide to use. The Google Java Style Guide looks like the one that is most used these days (the old Sun one has not been updated since 1999).
At first I thought we should use Checkstyle to enforce the style, but after playing with the Google checkstyle settings I found that they produce lots (hundreds) of warnings even for source code that has been formatted to adhere to the Google Java Style Guide. For example, it produces lots of warnings about there not being blank lines between import groups even though the guide says there shouldn't be blank lines.
So I think it would be preferable to use a tool that checks if the source is formatted correctly according to the Google Java Style Guide, and fail the build if it's not. This is such a tool: https://github.com/coveo/fmt-maven-plugin, and it's easy to integrate with the Maven build. The source can also be manually reformatted using mvn fmt:format if needed.
I've produce a  patch to do this here: #182. Please take a look!

The Google Java Style Guide looks fairly reasonable to me.
The only thing I don't like is the missing newline after }, I prefer
return () -> {
  while (condition()) {
    method();
  }
};

return new MyClass() {
  @Override public void method() {
    if (condition()) {
      try {
        something();
      }
      catch (ProblemException e) {
        recover();
      }
    }
    else if (otherCondition()) {
      somethingElse();
    }
    else {
      lastThing();
    }
  }
};

to
return () -> {
  while (condition()) {
    method();
  }
};

return new MyClass() {
  @Override public void method() {
    if (condition()) {
      try {
        something();
      } catch (ProblemException e) {
        recover();
      }
    } else if (otherCondition()) {
      somethingElse();
    } else {
      lastThing();
    }
  }
};

I could of course could be outvoted.  :)

+1 to using the Google Java style guide.

Closing as WontFix


feat: makes Miri test happy for all codes

closes https://github.com/cloudwego/sonic-rs/issues/61

thanks a lot. There are lots of unsafe codes here...
Sorry for this pr. I will refactor some relative codes later and will also solve the Mir problem, so there is no need for duplicated work.
I closed the pr, thanks for your contribution.


Add Mesh utilities

Consider adding bounding box, center of gravity, center of bounding box, etc to meshes.

Apparently this is already there, and I just forgot that I added it.


docs: update script command

I tried generating a project with  below commands like the documentation.
rye init --script my-project
cd my-project

However,  the next step occurs an error.

The pyproject.toml will be generated with a [project.scripts] section named hello that points to the main() function of __init__.py. After you synchronized your changes, you can run the script with rye run my-project.

rye sync
rye run my-project
error: invalid or unknown script 'my-project'

I checked the available commands.
rye run

hello
python
python3
python3.12

I don't think there is a project's name command.
That's why I updated rye run hello syncing the last command.
rye sync
rye run hello

While you are right that the docs are wrong here, it's actually the template that should generate a script by the name of the project.


How to disable model and state logs

Is there any way to disable initiation logs below? Setting suggested params did not seem to help
whisper_init_from_file_with_params_no_state: loading model from 'models/ggml-medium.bin'
whisper_model_load: loading model
whisper_model_load: n_vocab       = 51865
whisper_model_load: n_audio_ctx   = 1500
whisper_model_load: n_audio_state = 1024
whisper_model_load: n_audio_head  = 16
whisper_model_load: n_audio_layer = 24
whisper_model_load: n_text_ctx    = 448
whisper_model_load: n_text_state  = 1024
whisper_model_load: n_text_head   = 16
whisper_model_load: n_text_layer  = 24
whisper_model_load: n_mels        = 80
whisper_model_load: ftype         = 1
whisper_model_load: qntvr         = 0
whisper_model_load: type          = 4 (medium)
whisper_model_load: adding 1608 extra tokens
whisper_model_load: n_langs       = 99
whisper_model_load:      CPU buffer size =  1551.93 MB
whisper_model_load: model size    = 1551.57 MB
whisper_init_state: kv self size  =  132.12 MB
whisper_init_state: kv cross size =  147.46 MB
whisper_init_state: compute buffer (conv)   =   25.54 MB
whisper_init_state: compute buffer (encode) =  170.21 MB
whisper_init_state: compute buffer (cross)  =    7.78 MB
whisper_init_state: compute buffer (decode) =   98.25 MB

What are the suggested params you tried to set?

These ones that are in the examples but I think they do not affect this part.
// Disable anything that prints to stdout.
params.set_print_special(false);
params.set_print_progress(false);
params.set_print_realtime(false);
params.set_print_timestamps(false);

I guess we should update that comment to note that doesn't disable everything. It's impossible to disable whisper's log output afaik entirely, but 0.11 comes with either whisper_rs::whisper_sys_log::install_whisper_log_trampoline or whisper_rs::whisper_sys_tracing::install_whisper_tracing_trampoline depending on your use case. You should be able to use one of those and disable them.


pkg lock for base packages

Hello,
Please lock base packages to prevent accidental deletion by users.
When update-station update/upgrade base packages should be unlocked and relocked after update/upgrade.
Thank you !

Command to lock:     sudo pkg lock -xy os-generic
Command to unlock: sudo pkg unlock -xy os-generic
Comand to list locks: pkg lock -l

The problem I have with locking the base packages is if we lock the base packages they will not show on the list of pkg to update. pkg upgrade -n does not show any os-generic-* I tested this. That also means that every time update-station will look for updates it would have to unlock os packages. This feature is starting a whole lot of issues.
A user that does not know that his os packages is locked will end up with big problems if he uses a pkg upgrade.
ericbsd@ericbsd-ghostbsd-pc ~ [70]> sudo pkg upgrade -n
Password:
Updating GhostBSD repository catalogue...
GhostBSD repository is up to date.
All repositories are up to date.
Checking for upgrades (16 candidates): 100%
Processing candidates (16 candidates): 100%
Checking integrity... done (0 conflicting)
Your packages are up to date.
ericbsd@ericbsd-ghostbsd-pc ~> sudo pkg upgrade os-generic-kernel
Updating GhostBSD repository catalogue...
GhostBSD repository is up to date.
All repositories are up to date.
ericbsd@ericbsd-ghostbsd-pc ~ [70]> sudo pkg upgrade -f os-generic-kernel
Updating GhostBSD repository catalogue...
GhostBSD repository is up to date.
All repositories are up to date.
ericbsd@ericbsd-ghostbsd-pc ~ [70]> sudo pkg -d upgrade -f os-generic-kernel
DBG(1)[47330]> pkg initialized
Updating GhostBSD repository catalogue...
DBG(1)[47330]> PkgRepo: verifying update for GhostBSD
DBG(1)[47330]> Pkgrepo, begin update of '/var/db/pkg/repo-GhostBSD.sqlite'
DBG(1)[47330]> Request to fetch http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/meta.conf
DBG(1)[47330]> opening libfetch fetcher
DBG(1)[47330]> Fetch > libfetch: connecting
DBG(1)[47330]> Fetch: fetching from: http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/meta.conf with opts "i"
DBG(1)[47330]> Request to fetch http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/meta.txz
DBG(1)[47330]> opening libfetch fetcher
DBG(1)[47330]> Fetch > libfetch: connecting
DBG(1)[47330]> Fetch: fetching from: http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/meta.txz with opts "i"
DBG(1)[47330]> Request to fetch http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/packagesite.txz
DBG(1)[47330]> opening libfetch fetcher
DBG(1)[47330]> Fetch > libfetch: connecting
DBG(1)[47330]> Fetch: fetching from: http://pkg.us.ghostbsd.org/unstable/FreeBSD:12:amd64/latest/packagesite.txz with opts "i"
GhostBSD repository is up to date.
All repositories are up to date.
DBG(1)[47330]> want to get an advisory lock on a database
DBG(1)[47330]> release an advisory lock on a database
ericbsd@ericbsd-ghostbsd-pc ~ [70]>

I am really resistant to add a future that could cause problems due to kernel mismatch.

I am closing this issue it does not worth the trouble that it causes for updates.

I am closing this issue it does not worth the trouble that it causes for updates.


Built-in script errors should automatically open related scene

Godot version:
3.1 alpha
Issue description:
If you have a node with built-in script and it happens that an error pops there and the scene is closed, you will correctly get an error what happened and at which line, but at the same time, a warning appears that "Built-in scripts can only be edited after opening their scene".
Debugger will correctly highlight the error line if the scene is opened, but since you can have many such scenes and error might appear in a one you don't have opened, Godot should automatically open the corresponding scene on error.
Minimal reproduction project:
TestProject.zip
Just press F5 and behold the warning.

Yeah that warning message is really annoying and makes working with built-in scripts a pain.


'Undefined is not a function' when reading an image (missing 'sgtest.decodeJpegBuffer')

After re-installing 'aminogfx-gl' (https://github.com/joshmarinacci/aminogfx/issues/10) under node 0.12 in a PI 2 with Raspbian Wheezy (libjpeg8-dev and libpng-dev are installed), and using some code from https://github.com/joshmarinacci/aminogfx/blob/master/demos/slideshow/slideshow.js I get:
TypeError: undefined is not a function
at Object.gl_native.decodeJpegBuffer (/home/pi/amino/node_modules/aminogfx-gl/main.js:294:61)
at Object.gl_native.loadImage (/home/pi/amino/node_modules/aminogfx-gl/main.js:288:40)
at /home/pi/amino/node_modules/aminogfx-gl/node_modules/aminogfx/src/primitives.js:187:37
at Array. (/home/pi/amino/node_modules/aminogfx-gl/node_modules/aminogfx/src/amino.js:31:13)
at Function.prop.set (/home/pi/amino/node_modules/aminogfx-gl/node_modules/aminogfx/src/amino.js:42:30)
at ImageView.prop [as src] (/home/pi/amino/node_modules/aminogfx-gl/node_modules/aminogfx/src/amino.js:16:25)
at /home/pi/amino/slideshow.js:46:9
...
slideshow.js46:9 is     iv1.src(files.next());
Problem seems to be that 'sgtest.decodeJpegBuffer' binding does not exist. Any idea why?
Thanks,
Berto

I removed the native jpeg decode a while ago to reduce native dependencies. It should be using a pure js version now. Thanks bug implies there is somewhere else I need to update the code. I'll look at it tonight.

@joshmarinacci Many thanks!! Looking forward to it!

this is fixed now.


WIP: Multi-arch hosts support

@imikushin There are two modes we run rancher/server in CATTLE_USE_LOCAL_ARTIFACTS=true or CATTLE_USE_LOCAL_ARTIFACTS=false.  true is the default.  Can you test your code change against CATTLE_USE_LOCAL_ARTIFACTS=false to?  Meaning run docker run -e CATTLE_USE_LOCAL_ARTIFACTS=false rancher/server.
What false does is that the agents will download the assets from the CDN URL and not from rancher server directly.  I'm concerned this mode will not work with your changes.

@ibuildthecloud from rancher-agent logs, it looks cattle-global.properties URLs are indeed used to download the binaries:
INFO: Updating configscripts
INFO: Downloading http://<IP_ADDRESS>:8080/v1//configcontent//configscripts current=&arch=arm
INFO: Running /var/lib/cattle/download/configscripts/configscripts-1-779a2b9e18687e6355ae911fdf248f6266c988eea14f2574ef1ce40627459625/apply.sh
INFO: Sending configscripts applied 1-779a2b9e18687e6355ae911fdf248f6266c988eea14f2574ef1ce40627459625
INFO: Updating pyagent
INFO: Downloading http://<IP_ADDRESS>:8080/v1//configcontent//pyagent current=&arch=arm
INFO: Running /var/lib/cattle/download/pyagent/pyagent-1-9e3dcab12585149a65d818082279708965cd826df1937a55b24f48428f8f0c065013e2bd046ea82e358d87d3d345bbab/apply.sh
INFO: Updating host-api-arm
INFO: Downloading https://github.com/imikushin/host-api/releases/download/v0.32.0_arm/host-api_arm.tar.gz current=&arch=arm
INFO: Running /var/lib/cattle/download/host-api-arm/8af523b779bb0942e1ac0d8e4272e3e4/apply.sh
INFO: Updating python-agent
INFO: Downloading https://github.com/rancher/python-agent/releases/download/v0.81.0/python-agent.tar.gz current=&arch=arm
INFO: Running /var/lib/cattle/download/python-agent/74079d5d5ffe805bd17f8e4f581ea710/apply.sh
INFO: Updating cadvisor-arm
INFO: Downloading https://github.com/imikushin/cadvisor-package/releases/download/v0.22.0-1_arm/cadvisor_arm.tar.gz current=&arch=arm
INFO: Running /var/lib/cattle/download/cadvisor-arm/37c45d0b6f05e14eaefa388e4d983f5f/apply.sh

@imikushin Perfect, thanks for checking that out.

I'm updating the binaries' build scripts and then this PR soon.


[TASK][UI] support volume backup policy

What's the task? Please describe
Support volume backup policy ("if-not-present", "always", "disabled") when creating the Longhorn system backup.
Describe the items of the task (DoD, definition of done) you'd like

Please use a task list for items on a separate line with a clickable checkbox https://docs.github.com/en/issues/tracking-your-work-with-issues/about-task-lists

[ ] Ability to select  from list of volume backup policies when creating the Longhorn system backup.

Additional context
https://github.com/longhorn/longhorn/issues/5011

cc @smallteeths

Verified pass in longhorn master (longhorn 985634, longhorn-manager 663185, longhorn-ui 51e912)
Volume backup policy of UI verified in https://github.com/longhorn/longhorn/issues/5011#issuecomment-1573083532


Issues with cancellation

I am trying to cancel request using redux actions, but facing an issue. All the subsequent requests are then automatically cancelled. pretty sure i am doing something stupid, any help is appreciated.
//actions.js

...

const CancelToken = axios.CancelToken
const source = CancelToken.source()

export const cancelRequest = () => {
	source.cancel('Operation canceled by the user.')
	return ({
		type: constants.CANCEL_ANALYSIS
	})
}

export const fetchRequest = (data) => {
	const requestConfig = {
		method: 'POST',
		url: constants.Api,
                data: data
		headers: {
	             'Accept': 'application/json',
	            'Content-Type': 'application/json',
	        },
		crossDomain: true,
		cancelToken: source.token
	}

	return ({
		type: constants.FETCH_REQUEST,
		payload: axios(requestConfig)
	})
}

Once cancelRequest() is fired it successfully cancels the request. But any other requests made in future using fetchRequest() are also cancelled (even though cancelRequest() is never called again).
I tried creating an instance and intercepting the instance for adding cancel token in cancelRequest method but had no luck.

You only create a single source of cancel tokens, which means that all requests are given the same cancel token. With source.cancel('...'), all requests created with that source's token are canceled. You need to create a new source for every request, and use that same source to cancel that request.

You only create a single source of cancel tokens, which means that all requests are given the same cancel token. With source.cancel('...'), all requests created with that source's token are canceled. You need to create a new source for every request, and use that same source to cancel that request.

@dlakata Ahh alright, i understand. knew there was something silly. Thanks for the help.

@dlakata how do you fixed this problem???

There is no option as crossDomain inside the Axios. Please study the source-code before giving/using wrong clues.


Are there any plan to add support for repeat unit with IUPAC nucleotides?

Thanks for developing NanoRepeat. From my own testing, it seems to be doing much better than straglr.
However, I find that NanoRepeat doesn't support IUPAC nucleotides in repeat unit but straglr does. It would be great if IUPAC support is added.
If that's too much to ask, is it possible to support poly-alanine repeat which has a repeat unit of GCN?
It occurs in PHOX2B gene and is a well documented trinucleotide repeat disorder.
https://academic.oup.com/hmg/article/13/suppl_2/R235/619705
Thanks a lot in advance.

Sure. I'm happy to add support for GCN.
Thanks for requesting this.
Li

Any updates on this feature?


Include symbol role information in semantic highlighting (fxes #787)

This allows clients to e.g. color references differently from
declarations.

Review ping?


[feat]: Add copy icon for AxonOps Workbench version

Is your feature request related to a problem? Please describe.
When rasing bugs we need to add the app version, we can not copy the text from about

Describe the solution you'd like
Add a copy icon to copy the buid version or make the text selectable

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Enterprise Admin API: Fix broken formatting

Where is the problem?
https://docs.konghq.com/enterprise/2.5.x/admin-api/db-encryption/
What happened?
Check out the broken formatting:

https://docs.konghq.com/enterprise/2.5.x/admin-api/db-encryption/#import-exported-keyring
https://docs.konghq.com/enterprise/2.5.x/admin-api/db-encryption/#import-key

Both the notes and tables are broken.
What did you expect to happen?
For the formatting to not be broken.
Code of Conduct and Community Expectations

[X] I agree to follow this project's Code of Conduct
[X] I agree to abide by the Community Expectations

/assign

Fixed in https://github.com/Kong/docs.konghq.com/pull/3521


[TEST ISSUE]

Steps to reproduce
.
Expected behavior
.
Actual behavior
.
Crash logs
No response
Yōkai version
.
Android version
.
Device
.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I am reporting an issue exclusive to this fork. I have also checked that is not an issue on the main version of Tachiyomi
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.7.11.
[X] I have updated all installed extensions.
[X] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I have filled out all of the requested information in this form.

@null2264 this issue was automatically closed because:

You have not carefully read the acknowledgements.


[Feature Request] Refactor moreh_bmm_backward

Is your feature request related to a problem? Please describe.
moreh_bmm_backward was deprecated along with tt_dnn. Please port it to the ttnn package.
Describe the solution you'd like
Refactor the moreh_bmm_backward codebase to align with the current ttnn operation style.
Describe alternatives you've considered
None
Additional context
None

I'll close this issue, as it will be resolved at this issue.


Fix to clean!

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e67a349). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   98.78%
=========================================
  Files             ?        7
  Lines             ?      165
  Branches          ?        0
=========================================
  Hits              ?      163
  Misses            ?        2
  Partials          ?        0

Impacted Files
Coverage Δ

src/MLJModelInterface.jl
100% <ø> (ø)

src/data_utils.jl
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67a349...5f104db. Read the comment docs.


Input attachments shown with LOAD DONT CARE despite loadOp=LOAD

Description
Take the following framebuffer:

Attachment 0 MSAA loadOp=DONT_CARE, storeOp= DONT_CARE

Attachment 1 loadOp=LOAD, storeOp=STORE

Subpass 0:

Color Attachment 0: Attachment 0
Input Attachment 0: Attachment 1

Subpass 1:

Color Attachment 0: Attachment 0
Resolve Attachment 0: Attachment 1

In Subpass 0, there's a draw call that initializes the MSAA attachment from the input attachment (which is the same as the resolve attachment used in Subpass 1). There's an appropriate subpass dependency in between the two.
Looking at RenderDoc on said draw call, it shows the contents of Attachment 1 as LOAD DONT CARE, even though loadOp for this attachment is LOAD and the contents are valid.
Steps to reproduce
Take the following capture file: https://drive.google.com/file/d/1KuahchxMsZ-KDMSCji3YtMTuCUUuvkyR/view
In the above capture, there's a similar scenario to the above (except there are two pairs of attachments, 2 color and 2 input/resolve).
Observe at EID 21 (after first render pass) that Color Attachment 363 is valid (and red). Click on EID 26 (first subpass of second render pass), and in Texture Viewer look at Inputs. Observe that both inputs (including Color Attachment 363) show LOAD DONT CARE. Expected behavior is to see colors resolved to these attachments in the first render pass.
Environment

RenderDoc version: b1c12ce1a
Operating System: Linux (Ubuntu 20.04)
Graphics API: Vulkan
cmake arguments: -DCMAKE_BUILD_TYPE=Release -Bbuild -H. -DENABLE_GLES=OFF -DENABLE_GL=OFF
GPU: NVIDIA GTX 970, driver 440.100

This looks to be caused by a bad interaction between renderdoc's replay and the renderpass (legally) having a self dependency where it outputs to one of its own inputs.
RenderDoc isn't deliberately filling the attachment with LOAD_DONT_CARE, but when it tries to break the renderpass apart to display a draw from part way through the first subpass, the LOAD_DONT_CARE hasn't yet been overwritten and still gets resolved out as an accidental byproduct of the partial renderpass. That then becomes the input when the draw itself is replayed, leading to the incorrect inputs. If you had two draws in the first subpass for example, the second one would see the resolved input from the first one even though the resolve hasn't happened yet.
The same thing causes the more benign behaviour that a renderpass without this kind of self dependency will show the resolve target as 'partially updated' when selecting a draw mid-way through a renderpass, because the resolve action still takes place even when inspecting part-way through a renderpass.
I'll need to find a way to patch up the renderpass to not perform resolve actions when it's being broken apart like this, so this will probably take a little while to fix.

Wow, I didn't even remember this myself! You're right, with the MSRTSS extension I don't do this anymore. In fact, we basically never need multipass render passes.
We do however use single-subpass render passes with a self-dependency where the attachments are simultaneously both color and input attachments (emulating GL's framebuffer fetch). I recall that doesn't work well with RenderDoc either, but your change might have fixed that use case too.


Documentation for paper-button has a reference to core-icon istead of iron-icon

https://elements.polymer-project.org/elements/paper-button
<paper-button>
  <core-icon icon="favorite"></core-icon>
  custom button content
</paper-button>

Fixed by https://github.com/PolymerElements/paper-button/commit/e27704da98be3c10908814cf0211da399c1004ab


NEW: Add trim_mean from scipy.stats to cupyx

This PR aims to add a single function, trim_mean, from scipy.stats to cupyx.
It is a trivial port because it only requires swapping numpy for cupy in the import headers. However, the scipy implementation does not work on cupy arrays because the first step in the scipy implementation is to convert the input to a numpy array.
Everything (including tests) are copied almost verbatim from the scipy source.

Thanks! Let me merge this after CI pass, then let me rewrite the test so that it is checked against SciPy's result. CuPy's test should have a consistency check against NumPy/SciPy counterparts, but I don't think you need to learn how to write that only for this PR.

pfnCI, test this please.

@kmaehashi Would you approve the changes for your change request?


Costa Rica phone number +506 20100800 returns invalid

The documentation for Costa Rica:
http://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000300001PDFE.pdf
On p. 7, it lists the range 20000XXX to 21999XXX as Fixed telephony services, in reserve for allocation. Apparently, they have been allocating them. The VillasSol beach resort, for example, has a phone number of 2010-0800. I just called this number and it is a working number.
Some other numbers:
2010-1111, Teatro Nacional Costa Rica
2010-6000, Radisson San Jose-Costa Rica
The regexp validating numbers starting with 2 is:
'2[24-7]\d{6}'
in the code, so it will not validate a number starting with 20.

Thank you for your email. It looks like the prefix 2010 has now been allocated, do you have any evidence that any other prefixes/ranges between 20000XXX to 21999XXX have been allocated?
Best to change the library to validate 2010 prefix for the moment.
In addition to the links above I do not see any ITU updated documentation for example reflecting this. Do you have any other documentation that shows that this range has now been allocated?
Thanks
Brendan

This will be fixed in the next version.

Fixed by release 7.0.11.


Crashing while opening.

STLVault-20-06-20-22-11-29.zip

I've added in a ton of stl files into my collection of various sources. I can't get the application to stay open for more than a few seconds before it crashes.

Hi @mcenal - I'll take a look and will get back to you. Thanks for reporting!

So strange things happening, I think it is related to the ram usage/GPU usage/CPU thread usage. I'm not sure why, but I rebooted my computer and started loading a folder at a time and then exiting after each successful import and it is no longer crashing. So maybe it has to do with resource use. I would suggest that you include a bit more detail in the crash/report and or try to catch the crash error better without closing the application. Perhaps have a log of the file that crashed and then skip and move on or end the import.

First of all: Thanks for following up in the discord and for trying to help me reproduce the problem. It's indeed quite a strange crash and I might need to add some additional logging and profiling so we can track this down.

try to catch the crash error better without closing the application

I'd love to do that - but some errors are unrecoverable. In this case the log showed an access violation. That's usually a thing that happens when you write or read memory that doesn't belong to a process (anymore). When this happens, the process memory is in an unexpected state. The way STLVault is built I don't think I can do a lot to handle these - the Unity runtime will force a shutdown when one of these occurs. The reason for that is, that it is usually the right thing for a process to do.
So what this means is that the only way to prevent those crashes is to not have code that does this. I'm not certain in this case, where exactly things go wrong (which is why we need improved tracing or better dumps).
This could totally be my doing: I have some "unsafe" code in the STL-Parser. There is a chance that it reads out of bounds. In that case it should crash regardless of how you import the files, because those errors would be based on the content of the imported files. Now that not being the case, this might well be an error in the Unity runtime.
And those might well be harder to track down. I have some work planned to move the parsing and most of the library stuff out of process. This means that it should be a lot easier to track down issues like this and the overall memory pressure and busy times of the vault will become a lot smaller.
If you do come across a reproducable failure while importing a fixed set of models again, let's take a look. Because I still hope the error is on my side. That would be a lot easier to fix.


pod install failed on mac os

pedding on:
Installing pdfrx (0.0.1)
mac version:
M2.
14.4.1

Could you give me more detail about your failure? such as the logs from flutter build <something> --verbose and flutter doctor -v ?

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.1, on macOS 14.4.1 23E224 darwin-arm64, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.89.1)
[✓] Connected device (3 available)
[✓] Network resources

Timeout...
It took too long.

I guess you're in China and access to github releases are blocked by GFW.
So, if only the releases are the cause of problems, I can introduce some mechanism to switch the URL to other (by introducing some environment variable); I mean you somehow manually downloads these files and then host them on somewhere on your side and then the script runs without such blocking issues...
I don't know about your situation but if you have any such realistic suggestion, please ask me anything.


'[!]' in flutter doctor looks too much like an error state

Flutter Doctor
C:\>flutter doctor -v
[√] Flutter (on Microsoft Windows [Version 10.0.16299.248], locale en-US, channel beta)
    • Flutter version 0.1.4 at C:\flutter
    • Framework revision f914e701c5 (9 days ago), 2018-02-19 21:12:17 +0000
    • Engine revision 13cf22c284
    • Dart version 2.0.0-dev.27.0-flutter-0d5cf900b0

[√] Android toolchain - develop for Android devices (Android SDK 27.0.0)
    • Android SDK at C:\Users\zowhair\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[√] Android Studio (version 3.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[!] Connected devices
    ! No devices available

! Doctor found issues in 1 category.

Hi @zowhair, can you clarify what the issue is?

Is looks like there are no available devices to run on. Have you looked at the steps for running on an android emulator or devices? https://flutter.io/setup-windows/#android-setup

@jcollins-g, the:
[!] Connected devices
! No devices available

I think indicates more of an error condition than this is. Previously we had an intermediate state to represent 'not fully complete', but not an error condition. This was represented as a dash (-) for a bullet point item, and as [-] in the summary rollup. We may want to re-introduce this other state.

@devoncarew   Not fully complete is currently represented by the [!], and informational only messages are bullet points.    I'd be against using the dash for intermediate states as that looks very similar to the bullet point used for informational messages and OK sub-items.

@mit-mit tackled this issue raise because there was no device to run on.
Thanks All 👍

Hmm, this issue I see is that [!] looks too much like an error state, when it really should indicate that there's room for improvement, or things aren't fully complete. I understand there's been a lot of bike shedding in this area, but it would be good to iterate a bit more. There are a whole range of chars that might work besides dashes :)

@devoncarew This issue of [!] being interpreted as an error state came up in another thread and I definitely agree more iteration could benefit us.  I think we may want to branch out into other alterations of doctor output besides character selection; if we can structure the output data better we might not hinge as much on the interpretation of a single character.

Friendly ping


chore(main): release 2.1.0

An automated release has been created for you.
2.1.0 (2023-12-15)
Features

Add jitter option to throttle function (#26) (7991f91)
Add a new macro for throttling with timer based work (#28(https://github.com/stordco/buffy/commit/3810aec90efa47ec5d2f7665965550bcdf35ea94)

Bug Fixes

Debounce should be throttle (#30) (c0cd187)

Miscellaneous

Sync files with stordco/common-config-elixir (#23) (68bdd18)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/stordco/buffy/releases/tag/v2.1.0 :sunflower:


[FR] Reduce the auto-play next episode wait time, without skipping it entirely.

Sorry for all the feature requests - I'm really excited about this plugin.
I was thinking for the kids I don't mind them having to wait 5 seconds between episodes (e.g. to decide if they're hungry or something), but the last 5 or so seconds of the 15 seconds wait seems to drive them nuts.

Right after I posted this I had the thought to set the "command" offset to 5000. Not sure if that's quite what it's intended for, but it had the desired effect - even though the countdown timer starts for 15 seconds, it skips to the next episode when it gets to about 10.
I suppose as a side-effect, I would need to correspondingly decrease the start and end offsets if I re-enabled skip intro/credits, but didn't want them also delayed by 5 seconds.


Syntax Highlighting for Docs

Would it be possible to get syntax highlighting for the docs?

When will js-data-angular be released roughly? I also find current documentation without syntax higjlighting painful to read. My eyes aren't that great.

js-data-angular is ready to go. It's only in beta for beta's sake. As soon as I release 1.0 I'll migrate the project and get it tagged in bower/npm. js-data's docs are much better.
I don't have the desire nor time to spend on the syntax highlighting. Luckily this is open source and can accept contributions...

I understand. Especially since js-data-angular replaces angular-data soon.

The new docs are a billion times better. I'm not going to expend any effort on syntax highlighting for the old docs.


Initialize m_enabled to true in PPHolonomicDriveController

We are currently using PathPlanner for our robot, we are testing the code using a Gazebo simulation. The simulated robot didn't seem to turn at all, while the real robot did it without issue. We looked into it and found that the m_enabled check in PPHolonomicDriveController was failing, we believe it is because the variable is not assigned anything, leaving the compiler to decide its value. On Java the variable is set to true when its declared.

Huh. Don't know why I never noticed that. Can you move the initialization to the constructor in the cpp file here instead of the h file? I like to keep it all in the same place.

Actually nvm, that's fine in the h file

When this gets merged, I'm just going to replace the current 2024.1.5 release with the new build since I just pushed 2024.1.5 today. So, if you are already updated to that version you'll have to delete it from your gradle cache.

Okay, thanks!


Repo sync for protected CLA branch

The pull request is created from live637334264957867379 to live to fix git push error for protected CLA branch

@opbld15 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


add ping utility

What this PR does / why we need it:
add ping utility in docker image
Which issue(s) this PR fixes:
Fixes https://github.com/gardener/ops-toolbelt/issues/24
Special notes for your reviewer:
Release note:
Ping utility is now available in image

tested locally


Region Events: Add Image flickers with PIN code

Description:
Add image works, but showed me the PIN input screen about 2 or 3 times while I was selecting the image. The PIN overlay appeared, then disappeared again without me entering a PIN.
Same for replace image - after the image picker returns a PIN screen appears
After image editor goes away, PIN screen appears.
Steps:
1 - Create a new event, click through until the image screen
2 - Add an image - cancel
Expected:
Add image is canceled
Actual: PIN entry screen shows
Steps:
3 - Add an image
Expected:
Image editor opens
Actual:
Pin entry screen shows briefly, then image editor opens
4 - hit Done on image editor
Expected:
Image is added
Actual:
PIN entry screen briefly shows, then image is added.
Try the same with replace image - same thing, see recording
Screenshots:
https://user-images.githubusercontent.com/65412/170253781-a0c16fd0-dea6-4998-8f8d-59971dae13ea.mov

@RaulUrtecho @gguij004 cannot reproduce. will need @n13 to test this.

Test Case 1

Go to Explore > Regions.
Tap the + button to create a new event.
Go through the steps.
Once the image selection screen, tap + Add picture.
5.Tap Cancel.
Tap + Add picture again.
Select an image and tap Done.
Observe no PIN entry screen appear anywhere during the process of selecting the image.


Improve logging across the library

#327 added logging support to the library.
There are numerous ways to improve logging across the library:

[x] Turn existing warnings into logger.warn
[ ] Write logger.info messages where ever a user might be interested in progress that is happening
[ ] Write logger.debug informations where developers might be interested in what is happening
[ ] Equip more apps with a logging output widget, see pipeline_tuning for how it is done

This should be an ongoing effort going into the future.


e2e (AWS): Allow env var to override creds file

Resolve a long-standing TODO which allows AWS environment variables AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be used when present, even if a credentials file exists, as the gods intended.
hiveutil already uses the appropriate logic such that, if a creds file is not supplied, it looks for the env vars. We just needed to fix it so we don't pass that arg in at all if the env vars are set.
(This was an incidental requirement of HIVE-2234: the AWS credentials from the hypershift installation were taking precedence for managed DNS, which then bounced because the expected hosted zone is in a different account.)

/test e2e-azure
/test e2e-gcp

/assign @dlom

/assign @abutcher

/lgtm

Overriding freeze issue. This is test-only, so no SD impact, and I want to be able to move forward with https://github.com/openshift/release/pull/39941


⚠ BCR Bot has degraded performance

In 080d6e1, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1735 ms

Resolved: BCR Bot performance has improved in e0f82b9.


[CI] Use torch 2.2.0 nightly build dev20231106

Tying up loose ends :-)
@tridao

nvcr 24.01 is out and still uses torch2.2.20231106. I'll merge this and fix that later.

Originally posted by @tridao in https://github.com/Dao-AILab/flash-attention/issues/793#issuecomment-1915919111

Hmm, I don't think 1106 is still available. I just tried a pip install and looked at the nightly build mirror
https://download.pytorch.org/whl/nightly/torch/
... only 1010 is still around before 1205 so 1130 should not work any longer either.
I suppose we wait with this change until just before the next release of flash-attention (2.5.1) to pick a nightly build that will still be around then?

I think I figured out how to install torch 2.2.0.dev20231106. Let's see if flash-attn 2.5.1 builds successfully.

flash-attn 2.5.1 wheels build successfully. Thanks @ckadner !


Update Composer dependencies (2021-09-14-00-08)

Visual regression test passed!
View the visual regression test report


migration rollback while removing package

is there migration rollback function? or I have to delete it manually?

Of course there is a rollback. Just call migrate rollback with artisan
Sent from my iPhone

On Mar 4, 2017, at 12:53 PM, yeh<EMAIL_ADDRESS>wrote:
is there migration rollback function? or I have to delete it manually?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Initial aria test util docs

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
RSP

TODO: JSDOCs

If you want to look at the new utils aka tabs/listbox/tree (thanks @snowystinger!) more closely feel free to look at https://github.com/adobe/react-spectrum/pull/7505. That PR also had a bunch of consistency updates and stuff so I just merged it in


How to conduct the inductive learning setting?

Hi,
Thanks for sharing your codes in Pytorch for us.
I note that in your paper, you also conduct the inductive learning setting.
While the released codes do not support the inductive setting.
Would you like to release the codes that support the inductive setting? Or give us some advice?
Thanks
Best Regards.
Xu.

sit and wait


bug: Apisix ingress controller does not update upstream when endpoint update

Current Behavior
if apisix ingress controller is started before the target service, it may create an upstream with an empty node "[]".
after the endpoint is updated, apisix ingress controller does not update the upstream.
        {
            "createdIndex": 27,
            "key": "/apisix/upstreams/4405a246",
            "value": {
                "name": "apis_sa-front-service_80",
                "id": "4405a246",
                "type": "roundrobin",
                "nodes": [],
                "timeout": {
                    "send": 60,
                    "connect": 60,
                    "read": 60
                },
                "scheme": "http",
                "labels": {
                    "managed-by": "apisix-ingress-controller"
                },
                "desc": "Created by apisix-ingress-controller, DO NOT modify it manually"
            },
            "modifiedIndex": 27
        },

➜  ~ kubectl -n apis get ep sa-front-service
NAME               ENDPOINTS        AGE
sa-front-service   <IP_ADDRESS>:80   18m

Expected Behavior
apisix ingress controller can monitor the endpoint change and update upstream accordingly
Error Logs
No response
Steps to Reproduce

install apisix ingress controller
install target service

Environment

APISIX Ingress controller version (run apisix-ingress-controller version --long)
Kubernetes cluster version (run kubectl version)
OS version if running APISIX Ingress controller in a bare-metal environment (run uname -a)

I've observed a similar issue. For now, I've worked around this by setting the resolveGranularity to service so that the ingress controller doesn't need to take care of updating the upstream.

I've observed a similar issue. For now, I've worked around this by setting the resolveGranularity to service so that the ingress controller doesn't need to take care of updating the upstream.

Hi  @sereneshikari ,
Could you please share how did you config it? I only find it on ApisixRoute config https://apisix.apache.org/docs/ingress-controller/concepts/apisix_route/#service-resolution-granularity
Can we set it on Ingress resource?

I don't think it is possible to set this field on the Ingress resource. You can see the list of annotations we can use to customize settings for the Ingress resource here. Unfortunately, none of them mentions anything about the service resolution granularity.

I don't think it is possible to set this field on the Ingress resource. You can see the list of annotations we can use to customize settings for the Ingress resource here. Unfortunately, none of them mentions anything about the service resolution granularity.

Thanks @sereneshikari , are you creating ApisixRoute directly in k8s cluster?

You can see the list of annotations we can use to customize settings for the Ingress resource here. Unfortunately, none of them mentions anything about the service resolution granularity.

Related: https://github.com/apache/apisix-ingress-controller/pull/2181

thank @sereneshikari, I also met this issue while using cluster with spot instance.

@SuperBo, I don't think resolveGranularity is applicable for the Ingress resource. It's only applicable for the ApisixRoute resource.


Adding wrapper query, requirement for spring reactive

Description
I'm trying to port spring reactive to opensearch for one of our projects, it uses wrapper queries.
This is missing from the opensearch-java library.
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

If someone could explain how to modify the "source" of the generated code I couldn't find it.

@ls-urs-keller thanks for the fix, please add the test case for it (probably java-client/src/test/java/org/opensearch/client/opensearch/integTest/AbstractRequestIT.java is the best place right now), thank you

@ls-urs-keller Thank you for the changes! Want to finish this PR?
The code is not generated anymore and the related comments have been removed from the code. You can merge in the latest changes from the main branch.


[Incubator][VC] allow vn-agent to forward request to super master if kubelet-client-crt is not available

translate the  url for super master
parse URL.Rawquery for streaming connection
create serviceaccount vn-agent to access pod and related subresources (log, exec, portforward)
use the bearer token of the vn-agent's serviceaccount to connect to super master

/ok-to-test

/lgtm

/lgtm
/approve


TestKitFunctionalTestSpockBuildCache Sample Never Hits The Cache If The Output Is A Directory

Specific build commands run in a specific sequence in a command line build results in cache hits for a custom task as and when expected. Yet those exact same build commands run in the exact same sequence programmatically in a Spock/TestKit functional test, fail to produce build cache hits for the exact same task code that successfully produces cache hits from the command line.

This issue has led me to suspect that there could be some kind of defect either in TestKit or the User Guide's sample code.
Expected Behavior

FROM_CACHE outcome
Current Behavior

UP_TO_DATE outcome
Context

I'm working on a custom @CacheableTask for a custom plugin.

I am trying to accomplish the automation of functional testing for that @CacheableTask.
The task has @Inputs and @Outputs, etc. More specifically, it has a directory that is annotated as an @OutputFile. In normal operation I can build the project directly from the command line and get cache hits under the expected conditions. For example, I can do:

gradle build and get an UP_TO_DATE outcome.

rm -fr to delete the output directory or just do a gradle clean build and I get the expected FROM_CACHE outcomes whenever I want.

Steps to Reproduce

Here is a self-contained custom plugin project with a cacheable task. It contains a Spock/TestKit functional test in which the reported issue occurs.

The steps that led me to the issue are:

I copied the sample Groovy code to a file within my existing project.

I copied the plugin DSL block, the dependency block, the task configuration, etc., from my project's build.gradle

I pasted that into the User Guide sample test's buildFile

I followed the User Guide's instructions to the letter

Your Environment

Java 11
Gradle version 5.3.1
Linux

Due to Privacy concerns, I'd rather not publicize the information build scans reveal.

@lingocoder Thank you for reporting. I did run the test locally, and for the first run I saw this in the info log:
Caching disabled for task ':execjar' because:
  Gradle does not know how file 'jaxrs.out' was created (output property 'watchOutDir'). Task output caching requires exclusive access to output paths to guarantee correctness.

So caching was disabled since something else placed the jaxrs.out file in the output directory. The task itself didn't work on my machine with this message:
Task ':execjar' is not up-to-date because:
  No history is available.
Cannot run program "java": error=2, No such file or directory
java.io.IOException: Cannot run program "java": error=2, No such file or directory

The task does not fail though... It probably also doesn't create any output, that's why it is up-to-date on the second run.
All in all, this doesn't seem to be a problem with testkit.

Hey Thanks @wolfs for investigating that. And thanks for keeping me in the loop.

...The task itself didn't work on my machine...

Thanks. When did you clone/download it by the way? There have been a lot of changes since I first reported this a few months ago. But I'll investigate and see if I can make it fail the way it did on your machine.
Do you remember what you did to make it fail?


self.createActor() with globalName from inisde an ActorTypeDispatcher increases size of self

Environment:
Linux ikeh2 5.13.0-27-generic #29~20.04.1-Ubuntu SMP Fri Jan 14 00:32:30 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Python 3.8.10
thespian==3.10.6
Calling self.createActor(..., globalName='some_named_actor') from within an ActorTypeDispatcher correctly returns the address of some_named_actor if it exists. But every call increases the size of self. Specifically, it looks likes _myRef._addrManager._managed seems to get a new thespian.actors.ActorAddress every call, even when some_named_actor exists.
Running the attached example:
~/thespian_leaktest/$ python3 example.py
Wakeup #1; asize(self) = 22712 bytes
Wakeup #2; asize(self) = 24304 bytes
Wakeup #3; asize(self) = 25168 bytes
Wakeup #4; asize(self) = 26096 bytes
[...]
Wakeup #19; asize(self) = 39248 bytes

Also attached is similar output with a recursive memory inspection of the ActorTypeDispatcher instance after each wakeup, which calls createActor() with the same globalName. Note the memory size info requires the Pympler package.
Is this behaviour expected? If so, is there a way to get the address of a named actor from within an ActorTypeDispatcher instance without calling createActor()? Or is there a more suitable pattern for sharing access to a globally-referencable actor to other, less-persistent actors? My concern with simply storing the address of the global actor is that if it crashes (and is revived by some supervisory process), then the stored address will be invalidated with no way to know.
leaktest.tar.gz

Hi @gerowam , thanks for the report and the corresponding analysis.  I can confirm that I see just over 800 bytes of consumption for each createActor() call with a globalName specified.
The increased memory consumption is a necessity of the distributed nature of the Actor environment.  In concordance with your concern about storing the global address locally, the Thespian implementation must check with the Admin each time a "new" address is requested, and there must be local storage associated with this new address; any attempt to locally cache that information would suffer the same out-of-date issue you noted.
Probably a better way to address this situation is to have an Actor that provides management capabilities for other Actors (let's call this the "Maker" actor in the following discussion, and the term "Global" refers to the corresponding global actor, while the term "Client" refers to an actor wishing to communicate with the global actor).  In this configuration, the Thespian globalName is not necessarily needed, and the system will operate as described below:

Client needs to communicate to Global, so Client issues a (user-defined) "GetGlobalAddress" message to Maker.  In this situation, Maker may have a globalName that identifies it, but since the functionality provided by Maker is very limited, it is fairly safe and not expected to crash or otherwise fail, thus the client can issue a single createActor(Maker, globalName = "maker") call and save the resulting address on self.
When Maker receives the "GetGlobalAddress", it checks an internal dictionary (on self) to see if it has an address for Global.  Initially, it does not, so it will then issue a createActor(Global) call (here no globalName is needed).  It then adds the address obtained from that createActor to the internal dictionary and then returns the address to the Client in the response to the "GetGlobalAddress" message.
The Maker also records in another self dictionary the address of each Client that it gave the global address to.
Subsequent Client "GetGlobalAddress" calls can be handled directly by the Maker from the main self dictionary.
If the Global Actor crashes or otherwise exits, the Maker will handle the ChildActorExited message by removing the self dictionary entry containing the address of Global.  It may optionally send a (user-defined) "GlobalAddressNoLongerValid" message to the Client actors that were registered in the secondary self dictionary; this is optional but can make recovery faster, since this tells the Client actors that they should also flush any local copies of the Global actor address they are maintaining.
The next time a Client issues a "GetGlobalAddress" to the Maker, the self dictionary will not contain an address for Global, so it will re-perform the createActor process for Global to get a new instance.
If the Client Actors have cached the Global actor address, and the "GlobalAddressNoLongerValid" is not used, the clients will eventually receive a PoisonMessage on their attempts to send to the (no longer running) Global.  At that point they should discard their local address for Global and re-issue a "GetGlobalAddress" to Maker.

In the above scenario, Maker is a very simple implementation, but since Maker also acts as the parent actor for Global (or any number of Global actors), it will actively know when Global exits and another version needs to be created.  The Client actors require a slightly longer protocol to get the address of Global from Maker, but they don't need any additional complexity.  In this scenario, the growth of memory needed for actor address management should be limited to only those cases where the Global actor exits and needs to be re-created.


Updated code snippet to fix callback position

Description of the change

Fixed the issue highlighted here: https://github.com/rudderlabs/rudder-sdk-js/issues/232

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

Can you also add a note to stress that all API calls should follow load call when the SDK is loaded asynchronously?

Added this as a tip.


Add wavernn example pipeline

This is a reference example using WaveRNN model to train on LJSpeech. The structure will be inspired by #632  and WaveRNN.
There are at least a few more things to do:

[x] Add bg_iterator and README.
[ ] Add torchaudio transforms on mel-spectrogram.

Related to #446
Stack:
Add MelResNet Block #705, #751
Add Upsampling Block #724
Add WaveRNN Model #735
Add example pipeline with WaveRNN #749
cc @cpuhrsch @zhangguanheng66
internal

btw, can you add a README.md to discuss the pipeline?

It'd be nice to get a baseline by comparing the error you get here to the output obtained by Griffin-Lim, say, and in other norms too L^1, L^2 for instance.

Since this is not the original WaveRNN model, I'd recommend renaming it as "FatchordWaveRNN" or something similar.

There are at least a few more things to do:

[x]  Add bg_iterator and README.
[ ]  Add torchaudio transforms on mel-spectrogram.

What is the second item?

There are at least a few more things to do:

[x]   Add bg_iterator and README.
[ ]   Add torchaudio transforms on mel-spectrogram.

What is the second item?

This is to replaced the LinearToMel function. I remove it since we don't need it now.


Roll engine 7ea8b9968dce..22522c0b3e69 (1 commits)

https://github.com/flutter/engine/compare/7ea8b9968dce...22522c0b3e69
git log 7ea8b9968dce..22522c0b3e69 --no-merges --oneline
22522c0b3 Roll src/third_party/skia f03d4eaa2487..932759e9b414 (2 commits) (flutter/engine#6497)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Auto-roller completed checks. About to merge.


Added support for proxies in /etc/default/docker config, and downloads

It would be better to refactor the network_plugins so that they are not responsible for setting the /etc/defaults/docker file.. they could tweak the docker_options .. and next step we would setup Docker..
would that make sense ?

hmm.. what if, instead we populated /etc/environment with the right proxies, and sourced . /etc/environment in each of those default docker files ?  It would avoid duplication, and would propagate the environment variables to all the processes running on the host.. which, if you really need to use the proxies, will be there for everyone..

I prefer not touching the Docker defaults file if possible. Let's try to make it an env file like the Docker docs suggest: https://docs.docker.com/engine/admin/systemd/

Could you please use the solution proposed by mattymo @abourget ?

So actually.. I've seen that if I write an /etc/environment file.. and put the relevant http_proxy settings in there, the docker daemon will pick them up without tweaks to its /etc/defaults/docker file.. rendering most of this thing useless (except the download step).
What about simply creating a /etc/environment as part of kargo deploys ? Any objections ?

so I was fooled to believe it was solved, but we'd still need:
. /etc/environment
export http_proxy https_proxy no_proxy

in each /etc/default/docker for it to really work.
Which direction you think is best ?

Also, note, I'm using the upstart scripts from Ubuntu/Debian docker installs.. so the systemd approach might be good for CoreOS and friends, but won't cut it for my install...
Although, I don't mind adding some lineinfile to /etc/defaults/docker only for Debian installs, after the fact (after network plugins that is), and use the EnvironmentFile for systemd-based installs.
What do you think?

This may be obsoleted by https://github.com/kubernetes-incubator/kargo/pull/584

I think this is still needed to just get the files if nodes are running behind a proxy.

@galthaus The proxy configuration was handled by #584 but upstart/sysvinit support was later dropped entirely by #846. Proxies are supported in the remaining systemd config. We should be able to close this.

@chadswen - thx.  I'm in favor of closing and opening specific issues as we need to address them.


Unnatural Early termination of episodes with java.lang.StackOverflowError message

I observed some problematic episodes from RunHistory files while training DRRN models on many tasks for simplification_str="". I am attaching handful episodes from Task20
task20_problematic_episodes.txt
There are many instances when the episodes terminate prematurely (isComplete=1) with a score of -1, without a logical reason.
They are accompanied by a java.lang.StackOverflowError message in the freelook, inventory, observation entries.
This seems to happen in runs when  with simplification_str="", but not when  with simplification_str="easy".

I was training on a handful of tasks, and here are two tasks 13, and 20 where I encountered such logs:
https://drive.google.com/drive/folders/1djeLJjt99VY74h3egIbIufB25bqgH2g_?usp=sharing
Yes, it looks like these errors crop up during or after an electrical connection action.

@hitzkrieg can you try https://github.com/allenai/ScienceWorld/pull/41 and see if that solves the issue for you?


Some toasts that are "success" messages are rendered like "errors"

Currently our "error" toasts and "success" toasts look identical and they both look like errors (red). We should display happier looking toasts for success messages.

There are 4 different types of toast messages alert, error, success, warning. The problem is that we never send an indicator to the views as to the severity of the issue so we're pretty much always just rendering them as errors.
Typically, our toast messages are created using a String or Optional passed from the controller.
    if (message.isPresent()) {
      htmlBundle.addToastMessages(ToastMessage.error(message.get()).setDismissible(false));
    }

If we can differentiate message severity (by having a more complex message object?) we could have:
   for (Message message : messages) {
     htmlBundle.addToastMessages(
         ToastMessage.create(message.text, message.severity).setDismissible(false));
   }

To summarize this task: As @AWBaumann mentioned, we already have the ability to use the "success" toasts that look green and successful. The problem is that in some cases we use the error toast when it should be a success toast.

Can you give an example of a case where the error toast is being used instead of a success toast. It looks like all instances at present are using the right toast message.


Need a way to link to today's note

I tried [[Journal/Day/{{today}}]] but it does not work. I also tried embedding:
```template
page: "[[Journal/Day/{{today}}]]"

That doesn't work either. Only way to get to the note is with Alt-shift-d.

```template
[[Journal/Day/{{today}}]]
```

Should work though?


Fix home icon for xmas theme.

Or you know, just use the dedicated setting for it...
https://cdn.discordapp.com/attachments/843169959608844308/917530742186188880/unknown.png
This has absolutely nothing to do with the rebranding at this point.

Or you know, just use the dedicated setting for it... https://cdn.discordapp.com/attachments/843169959608844308/917530742186188880/unknown.png This has absolutely nothing to do with the rebranding at this point.

The seasonal theming uses the rebranded logo, so yes it does.

Closing as no longer needed / etc


Resolving #311

The chosen setting of the bounds to the higher value imitates cobrapy's logic in the case that the given lower bound is higher than the upper bound.

Obsolete/Now unneccessary due to #315


Update daily.yml

debugging the cvc4 daily test
Motivation
To fix the issue of the nightly test for Prover with cvc4
Have you read the Contributing Guidelines on pull requests?
yes

/canary

/canary

/canary

:sunny: Canary successful


invalid login details bug

while invalid credentials it also called refreshToken while login.
this.tokenStorage.getRefreshToken

Hi there, could you give me an example of the app so I can reproduce this issue? For me it seems like you have implemented wrong refreshShouldHappen method, which determines, whether refresh request should be executed or not.

Hey Serhiisol,
Thanks
I solved the issue using refresh should happen function by default false.


FluxNinja plugin not loading properly because of build problem

FluxNinja plugin is not being loaded properly with the following error:
Happened with 2b44c03c version for Controller but not for Agent:
{"level":"warn","service":"aperture-controller","error":"plugin.Open(\"/opt/aperture/aperture-controller/plugins/aperture-plugin-fluxninja\"): plugin was built with a different version of package k8s.io/kube-openapi/pkg/internal/third_party/go-json-experiment/json","plugin":"aperture-plugin-fluxninja","time":"2023-02-02T16:58:00Z","caller":"pkg/plugins/plugin-registry.go160","m
essage":"unable to open plugin"}

Happened with 433894f4 version for Agent, but not for Controller:
{"level":"warn","service":"aperture-agent","error":"plugin.Open(\"/opt/aperture/aperture-agent/plugins/aperture-plugin-fluxninja\"): plugin was built with a different version of package k8s.io/kube-openapi/pkg/internal/third_party/go-json-experiment/json","plugin":"aperture-plugin-fluxninja","time":"2023-02-03T09:20:52Z","caller":"pkg/plugins/plugin-registry.go160","message":"unable to open plugin"}

This seems to be deterministic:
First build with cache, so basically the same image as built from main:
$ g lo -1
433894f4 (HEAD -> main, origin/main, origin/HEAD) Added support for applying policy on Kubernetes conditionally via aperturectl and use of custom blueprints (#1264)
$ docker build -t agent:1 -f cmd/aperture-agent/Dockerfile .
<snip>
 => CACHED [stage-3 2/5] RUN apt-get update  && apt-get install -y --no-install-recommends ca-certificates  && apt-get clean  && rm -rf /var/lib/apt/lists/*                             0.0s
<snip>
 => CACHED [builder 1/1] RUN --mount=type=cache,target=/go/pkg/   --mount=type=cache,target=/root/.cache/go-build/   CGO_ENABLED=1 TARGET="/aperture-agent" PREFIX="aperture" SOURCE=".  0.0s
<snip>
$ docker run agent:1
<snip>
{"level":"warn","service":"aperture-agent","error":"plugin.Open(\"/opt/aperture/aperture-agent/plugins/aperture-plugin-fluxninja\"): plugin was built with a different version of package k8s.
io/kube-openapi/pkg/internal/third_party/go-json-experiment/json","plugin":"aperture-plugin-fluxninja","time":"2023-02-03T09:51:36Z","caller":"pkg/plugins/plugin-registry.go160","message":"u
nable to open plugin"}

Second build without cache, so both agent and plugins are built from scratch:
$ docker build --no-cache -t agent:2 -f cmd/aperture-agent/Dockerfile .
<snip>
 => [builder 1/1] RUN --mount=type=cache,target=/go/pkg/   --mount=type=cache,target=/root/.cache/go-build/   CGO_ENABLED=1 TARGET="/aperture-agent" PREFIX="aperture" SOURCE="./cmd/  325.3s
 => [plugins-builder 1/1] RUN --mount=type=cache,target=/go/pkg/   --mount=type=cache,target=/root/.cache/go-build/   /bin/bash -c   'set -euo pipefail;   shopt -s nullglob;   for p  148.3s
<snip>
$ docker run agent:2
<snip>
{"level":"warn","service":"aperture-agent","error":"plugin.Open(\"/opt/aperture/aperture-agent/plugins/aperture-plugin-fluxninja\"): plugin was built with a different version of package k8s.
io/kube-openapi/pkg/internal/third_party/go-json-experiment/json","plugin":"aperture-plugin-fluxninja","time":"2023-02-03T10:04:17Z","caller":"pkg/plugins/plugin-registry.go160","message":"u
nable to open plugin"}

What is interesting, some random changes to build scripts fix that:
$ g d
diff --git a/pkg/info/build.sh b/pkg/info/build.sh
index 7b7fd39b..7952c68a 100755
--- a/pkg/info/build.sh
+++ b/pkg/info/build.sh
@@ -24,7 +24,9 @@ LDFLAGS="\
     -X 'github.com/fluxninja/aperture/pkg/info.Prefix=${PREFIX}' \
 "
 if [ -z "${RACE:-}" ]; then
+    echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
     go build --ldflags "${LDFLAGS}" -o "${TARGET}" "${SOURCE}"
 else
+    echo "????????????????????????????????????????????"
     go build --race --ldflags "${LDFLAGS}" -o "${TARGET}" "${SOURCE}"
 fi
diff --git a/pkg/plugins/build.sh b/pkg/plugins/build.sh
index f31570cd..63948780 100755
--- a/pkg/plugins/build.sh
+++ b/pkg/plugins/build.sh
@@ -20,7 +20,9 @@ LDFLAGS="\
     -X 'main.GitCommitHash=${GIT_COMMIT_HASH}' \
 "
 if [[ -z "${RACE}" ]]; then
+    echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
     go build -buildmode=plugin --ldflags "${LDFLAGS}" -o "${TARGET}" "${SOURCE}"
 else
+    echo "????????????????????????????????????????????"
     go build -buildmode=plugin --race --ldflags "${LDFLAGS}" -o "${TARGET}" "${SOURCE}"
 fi

$ docker build --no-cache -t agent:3 -f cmd/aperture-agent/Dockerfile .
$ docker run agent:3
<No error as above>


feat[graphqlite-bridge]: improve remote schema permissions state processor

…essor.

Codecov Report

Merging #92 (b6f0436) into main (33a1fc7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #92   +/-   ##
=========================================
  Coverage     94.33%   94.33%
  Complexity      571      571
=========================================
  Files           119      119
  Lines          2294     2296    +2
=========================================
+ Hits           2164     2166    +2
  Misses          130      130

Flag
Coverage Δ

phpunit
94.33% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ridge/src/RemoteSchemaPermissionStateProcessor.php
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a1fc7...b6f0436. Read the comment docs.


Parallel Processing/Execution

File to refer: https://github.com/blobcity/autoai/blob/main/blobcity/modelSelection.py
      modelScore={m:cvScore(models[m][0](),X,Y,k) for m in best }

The following line of code sequentially trains different machine learning models from the dictionary object (variable: best ). Instead of this sequential execution of for loop, execute the above step in parallel considering all the CPU cores in the system.

Can I work on this issue?


Update release notes for CP 182.1

Update release notes for CP 182.1

Hi @cenkiravul ,
Is this the same issue as was fixed on 1 December (one of the ticket numbers is the same)? If so, I'd use the same wording as on 1 December, as it is clearer exactly what issue we are talking about.
If it is different, is there additional info we could add to say exactly where this is happening?
Release tomorrow, I assume.

Hi @MarkvanMents ,
This is a different issue, which led the users to not be be able to see Technical Contact information under Settings > General section.
The release is scheduled for tomorrow, still pending approval.

@cenkiravul - is this now live?

@MarkvanMents - It is live now, We had release it today morning!


Just a suggestion: for Operation

Reported by @cimba007  at https://forum.mysensors.org/topic/4431/mycontroller-0-0-3-alpha2-released/15

Send notification would include all further kinds of notifications you might include but grouping this is not that important. The current way it is is already very easy to understand so a change might not be necessary.
Send payload might be better split into three different points as it would be very clear from the beginning what you are dealing with.

Dealing with Resources (manipulating stuff that is only known to the controller )
Manipulating Devices (reboot etc. .. this is more like a "command")
Update Sensor variables is an 1:1 mapping of the request/set concept of mysensors

Hello, on my current configuration the rules system does not show any meaningfull values on "autocomplete".

Althrough I have one node with 2 sensors which I would like to check against some threshold.

Am I doing something wrong?! I can't select operations based on these 2 sensor values neither.

I noticed the option to enable/disable operations via operations is not possible. With this I would very conveniently enable/disable my notification mechanism.

Rule and Timer is possible, Operations is missing.

I tried a workaround with scripts but I have no idea how to list all operations with their correspondig ID so I could use a script to disable the specific operation via scripting.
Could you provide a very small example on how to list all operations with ID and how to disable/enable an operation? Thank you in advance!

@cimba007

Rule and Timer is possible, Operations is missing.

Operations inside operation might create recursive loop, hence I disable that option.

Could you provide a very small example on how to list all operations with ID and how to disable/enable an operation?

To list operations on Dashboard.
Script: JavaScript
var myImports = new JavaImporter(java.io, java.lang, java.util);

with(myImports) {
  var filters = new HashMap();
  filters.put("orderBy", "name");
  filters.put("order", "asc");
  filters.put("pageLimit", new Long(10));
  //Get operations data
  var operations = mcApi.operation().getAll(filters);
}

Template:

    {{ 'STATUS' | translate }}
    {{ 'ID' | translate }}
    {{ 'NAME' | translate }}
    {{ 'OPERATION' | translate }}
    {{ 'LAST_EXECUTION' | translate }}

    <#list operations.data as item>

          <#if item.enabled>

          <#else>

          </#if>

        ${item.id}
        ${(item.name)!}

    </#list>

To enable/disable list of operations:
JavaScript
Script bindings: {options:{name:"operation-name", enable:false}}
Important: It is important to pass Script bindings when executing this script. In the binding you can include your operation name to filter. Please note in Mycontroller all filters are working with case sensitive. In the name filed you can put any words where operation name contains.
For example I want to enable or disable following operations,

my send email notification operation
notification: pushbullet

In the above names I have notification word in common. So I can use this name in filter to get these operations exactly.
To disable:
{options:{name:"notification", enable:false}}
To enable:
{options:{name:"notification", enable:true}}
var myImports = new JavaImporter(java.io, java.lang, java.util);

with(myImports) {
  var filters = new HashMap();
  var names = new ArrayList();
  names.add(options.name);

  filters.put("orderBy", "name");
  filters.put("order", "asc");
  filters.put("pageLimit", new Long(10));
  filters.put("name", names)

  //Get operations data
  var operations = mcApi.operation().getAll(filters);

  var operationIds = new ArrayList();
  for(var count =0 ; count<operations.data.length;count++){
    //You can do some filter here
     operationIds.add(operations.data[count].id);
  }

  if(options.enable){
   mcApi.operation().enableIds(operationIds);
  }else{
   mcApi.operation().disableIds(operationIds);
  }
}

Thank you very much. This looks much more refined as my little "hack" :D

I now successfully implemented enabling/disabling operation via switch thanks to your excellent example code:

@cimba007 great! This is awesome!

@jkandasa: I think your example is very elaborated and very good. If you/I close this issue the information would be "Lost" for other users. Maybe you could add this and the statistics example from earlyer to the documentation?! It would help a lot to get a quickstart for custom widgets for other users!

Yes, you are right I will create entry on http://forum.mycontroller.org and close this one.

To disable these notifications at night it would be possible to disable every rulde which leads to a notification. I thought it would be much easyier to disable the notification, leaving all rules intact.

Yes, for that reason I gave an option for operations also. We may use operations on timer, rule(multiple places). When disabling operation directly never get executed by any rules, timers.
If you have only requirement that, want to disable operations on night time, simple schedule a cron, other other timer to execute enable/disable operations script.

If you create the entry on the forum please add a link to the forum post to the documentation too!
http://www.mycontroller.org/#/documents/user/0.0.3.Alpha2.html => Script examples
People will most likely have a look at the documentation first so this would ensure this valuable information can be easylie found.

updated in forum, http://forum.mycontroller.org/topic/46/control-display-operations-via-script

If you create the entry on the forum please add a link to the forum post to the documentation too!
http://www.mycontroller.org/#/documents/user/0.0.3.Alpha2.html => Script examples

Sure, I will add this on 0.0.3.Final release document.

I even thought if it would be usefull to include the example in the actual mycontroller version as EXAMPLE_SCRIPT with the disabled flag set. It would be even easier to find a quickstart to scripting ;-)


Ubuntu host, installed Wireguard + tools, wg-gen-web not working

I must be missing a step. I used to have PiVPN (Wireguard) installed and created configs with that, everything worked.
Now I uninstalled PiVPN, uninstalled wireguard (which also removes wireguard-tools), deleted /etc/wireguard.
After a reboot,, I do sudo apt install wireguard which also installs tools automatically.
Then run my docker-compose up -d:
  vpn-server-ui:
    image: vx3r/wg-gen-web:latest
    container_name: vpn-server-ui
    restart: always
    networks:
      - management
    environment:
      WG_CONF_DIR: /data
      WG_INTERFACE_NAME: wg0.conf
      SMTP_HOST: $SMTP
      SMTP_PORT: 587
      SMTP_USERNAME: $SMTPUSER
      SMTP_PASSWORD: $SMTPPASS
      SMTP_FROM: $EMAIL
    volumes:
      - /etc/wireguard:/data
    ports:
      - "5100:8080"

I can access the webui on port 5100 just fine.

Server configuration:
Public Key: ....
Listen port: 51822
Server interface addresses: <IP_ADDRESS>/24
Client Configuration:
Public endpoint: mydomain.cloud:51822
DNS server: <IP_ADDRESS>
Default allowed: 0.0.0/0, ::/0
No values for MTU and keepalive

I create a client:

email address: my address
Addresses: <IP_ADDRESS>/32
Allowed IP addresses: 0.0.0/0, ::/0
No values for MTU and keepalive

After saving, I do:
sudo systemctl start<EMAIL_ADDRESS>Reload doesn't work because wg hasn't been started before.
Then I scan the QR code with my Android phone and try to connect: nothing. 0 bytes received, some bytes send.
What am I missing?
EDIT: I can access my server LAN IP! Just no internet. Perhaps a DNS issue?
But I simply used <IP_ADDRESS> for testing.. would expect that to work.

probably MASQUERADE is missing check out https://www.cyberciti.biz/faq/how-to-set-up-wireguard-firewall-rules-in-linux/

Still no luck after:
sudo iptables -t nat -I POSTROUTING 1 -s <IP_ADDRESS>/24 -o eth0 -j MASQUERADE
sudo iptables -I INPUT 1 -i wg0 -j ACCEPT
sudo iptables -I FORWARD 1 -i eth0 -o wg0 -j ACCEPT
sudo iptables -I FORWARD 1 -i wg0 -o eth0 -j ACCEPT
sudo iptables -I INPUT 1 -i eth0 -p udp --dport 51822 -j ACCEPT
sudo sysctl -w net.ipv4.ip_forward=1

And finally: sudo systemctl reload<EMAIL_ADDRESS>Disconnected/reconnected on my phone.

WORKS!
eth0 is ofcourse not correct, should be eno1 :)
Thanks!
I did notice one bug: for some reason I can no longer fill in a DNS address in Server Settings > Global Clients Configuration. Whenever I hit Save or Apply Globally, the field is emptied..

please share wg gen web logs after saving the modifications

Will do and then I'll create a new issue. Let's close this one :)


why redisson start up  error   Caused by :NoSuchMethodError

context:property-placeholder/
context:annotation-config/
<redisson:client name="redisson">
<redisson:single-server address="1xx.xx.xx:6379"/>
<redisson:list key="phone"></redisson:list>
</redisson:client>
redisson 3.2.4  netty 4.1.8  jackson 2.7.6  tomcat 7.0.73
jdk 1.7.0_80
Caused by: java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.ObjectMapper.addMixIn(Ljava/lang/Class;Ljava/lang/Class;)Lcom/fasterxml/jackson/databind/ObjectMapper;
at org.redisson.codec.JsonJacksonCodec.init(JsonJacksonCodec.java:148)
at org.redisson.codec.JsonJacksonCodec.(JsonJacksonCodec.java:95)
at org.redisson.codec.JsonJacksonCodec.(JsonJacksonCodec.java:80)
at org.redisson.codec.JsonJacksonCodec.(JsonJacksonCodec.java:55)
at org.redisson.config.Config.(Config.java:101)
at org.redisson.Redisson.(Redisson.java:113)
at org.redisson.Redisson.create(Redisson.java:154)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:162)
... 37 more

Check your classpath to ensure about jackson version. seems it's too old and not 2.7.4

thank you  due!
but  connections timeout to redis 3.0.7  .   im not sure connections  vmware centos 6.5  redis  server?
ping <IP_ADDRESS>  ok
Caused by: org.redisson.client.RedisConnectionException: Can't init enough connections amount! Only 0 from 10 were initialized. Server: /<IP_ADDRESS>:6379
Caused by: io.netty.channel.ConnectTimeoutException: connection timed out: /<IP_ADDRESS>:6379

It seems that the port is not accessible. Can you try it with redis-cli ?

sure  redis-cli  -h<IP_ADDRESS> -p 6379 No problem

Is it possible that you are running the redis-cli inside the vm while the Redisson is running on your host machine?

yes  redisson on my  win7 running    redis server in the vm
i  Can't  do that?

I think the problem is your win7 host can't access the vm on port 6379. Can you try and use a telnet program from your win7 host to connect to the redis running inside the vm?

I am ever so grateful to you for ask to me    thank you

Thank you for choosing Redisson!

Hello
Were you able to solve the first exception reported?
I'm having the same issue: [java.lang.NoSuchMethodError].  java.lang.NoSuchMethodError: com.fasterxml.jackson.databind.ObjectMapper.addMixIn(Ljava/lang/Class;Ljava/lang/Class;)Lcom/fasterxml/jackson/databind/ObjectMapper;
How can a i force a compatible version for jackson libraries?

@ddpa Hi! You should update jackson lib to 2.7.x and ensure that you're not mixing two different versions in classpath

@ddpa How can update jackson version? Do we need update in Glassfish or Dependency in pom.xml?


Transform Class Hierarchy

Okay.. so the current hierarchy looks like this
- data_to_data
  - heavy
  - light
- data_to_feature
  - heavy
  - light

Do we want to think about a reorg to something like?
- data_to_data
  - heavy
  - light
  - lambdas
  - step_functions
- data_to_feature
  - heavy
  - light
  - lambdas
  - step_functions

This might help bootstrap AWS deployments if the code is structured in a way that encourages 'promotion' from Python Classes to Lambdas to StepFunctions

okay.. this has already been reorganized (see https://github.com/SuperCowPowers/sageworks/blob/main/docs/sageworks_classes_concepts.md)


Implement plugins

Is your feature request related to a problem? Please describe.
This should be done based on the climetlab implementation. In the end earthkit-data should even support plugins written for climetlab.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Organisation
ECMWF

@tlmquintino
Some questions arise concerning the earthkit-data  plugins:

do we want to support the dataset plugins? At the moment, datasets are not part of earthkit-data. They are loaded in climetlab with load_dataset(name, *args)
do we require the plugins to be namespace packages (within the earthkit namespace)?


GPTJAttention.forward() got an unexpected keyword argument 'token_idx'

System Info
Optimum habana main branch, Synapse version 1.15, docker image 1.15.0:474 (RC)

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
Follow the steps in examples/language-modeling https://github.com/huggingface/optimum-habana/tree/main/examples/language-modeling#multi-card-training-with-deepspeed-gpt-j
and run the following cmd:
python ../gaudi_spawn.py \
    --world_size 8 --use_deepspeed run_clm.py \
    --model_name_or_path EleutherAI/gpt-j-6b \
    --dataset_name wikitext \
    --dataset_config_name wikitext-2-raw-v1 \
    --per_device_train_batch_size 4 \
    --per_device_eval_batch_size 4 \
    --do_train \
    --do_eval \
    --output_dir /tmp/test-clm-xl-1 \
    --gaudi_config_name Habana/gpt2 \
    --use_habana \
    --use_lazy_mode \
    --gradient_checkpointing \
    --use_hpu_graphs_for_inference \
    --throughput_warmup_steps 3 \
    --deepspeed path_for_deepspeed_config

Here, the path_for_deepspeed_config is acquired from DeepSpeed Zero-2 config, e.g. https://github.com/huggingface/optimum-habana/blob/main/tests/configs/deepspeed_zero_2.json
Then the flow keeps running and crashes with the TypeError: GPTJAttention.forward() got an unexpected keyword argument 'token_idx'

Expected behavior
The expected behavior is to finish the training and evaluation successfully without any error

@IT-Forrest Are you still encountering this error? It works on my side on Synapse 1.14 and I don't think version 1.15 changes anything here.
Have you modified the run_clm.py example?

Hi @regisss, thanks for your reaching out. The issue of missing "token_idx" is walked around by downgrading the transformer version from the latest 4.39.3 to 4.38.2, e.g. pip install transformers==4.38.2 and downgrade pytest version from 8.1.1 to 7.4.4
The reason that my Transformers version is 4.39.3 is that, after pip install latest dependencies, I'll hit the following pytest error when launching the run_clm.py

pip install git+https://github.com/huggingface/optimum-habana.git  (latest version 1.15)
pip install git+https://github.com/HabanaAI/DeepSpeed.git  (latest version 1.11)
pip install -r examples/language-modeling/requirements.txt

With further analysis, the pytest error could be resolved by downgrading pytest version from 8.1.1 to 7.4.4.
Here, pytest 8.1.1 is preinstalled in the latest docker image e.g. vault.habana.ai/gaudi-docker/1.15.0/ubuntu22.04/habanalabs/pytorch-installer-2.2.0:latest
Further check the optimum-habana/setup.py,  it shows the pytest version < 8.0.0, however, this requirement didn't take effect during the pip install and thus lead to the pytest issue.

Anyway, the solution to this ticket is to install the transformers with a consistent version. and I'll close this ticket. Thanks for the help

pytest 8.1.1 is preinstalled in the latest docker image e.g. vault.habana.ai/gaudi-docker/1.15.0/ubuntu22.04/habanalabs/pytorch-installer-2.2.0:latest

Indeed, that is why we added recently pytest version < 8.0.0.
However, pytest is not installed with the regular lib because we usually only need it for tests. To have pytest installed following the < 8.0.0 requirement, you'll have to run
pip install "optimum-habana[tests] @ git+https://github.com/huggingface/optimum-habana.git"

This command enables to install the lib directly from source  and to specify the [tests] extra.

Hi @regisss , thanks for your info. Could you please move pytest version < 8.0.0 into INSTALL_REQUIRES?
I can confirm that, pytest version < 8.0.0 in INSTALL_REQUIRES could force pytest downgrade from 8.1.1 to 7.4.4, while in TESTS_REQUIRE can't help
Please let me know if you want me to git push a fix to optimum-habana-fork and then optimum-habana? E.g. the diff file is as follows:
$ git diff
diff --git a/setup.py b/setup.py
index c822c41..70f6de6 100644
--- a/setup.py
+++ b/setup.py
@@ -34,10 +34,10 @@ INSTALL_REQUIRES = [
     "torch",
     "accelerate < 0.28.0",
     "diffusers >= 0.26.0, < 0.27.0",
+    "pytest < 8.0.0",
 ]

 TESTS_REQUIRE = [
-    "pytest < 8.0.0",
     "psutil",
     "parameterized",
     "GitPython",

Arf yes, I always test installing the lib with the "tests" extra so I've never encountered this error...
I'm going to apply the fix you suggested as a workaround but ultimately pytest should not be installed in the Habana Docker image.

@IT-Forrest The fix has just been merged into main. It will also be part of our next patch release which will be out soon.


Remove unused AccessKey and SecretAccessKey from code

Issue #, if available:
There are unused AccessKey and SecretAccessKey in game logic.
Remove Legacy codes from source.
Description of changes:
Remove member variables
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

수정해도 이상 없는 부분 확인하고 PR 드립니다. 그래도 크로스체크 요청하겠습니다 ㅋㅋ


Refactor Push-Pull for Mainstream Artifact Lifter

TODO

finish the angr port for the new push_artifact and pull_artifact