Replace all hardcoded arch strings with variable

Description

Replace all arml7 strings with the defined variable archARM7
Define a new variable archDarwinARM64 to replace all existing arm64 strings.

Motivation and Context

We have hardcoded the arch string in the testing files even though we already have pre-defined variables.
Should follows the variable approach to make it easily maintain.

[ ] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Run the make command to ensure we can pass all existing stages.
-> % make
CGO_ENABLED=0 go test github.com/alexellis/arkade github.com/alexellis/arkade/cmd github.com/alexellis/arkade/cmd/apps github.com/alexellis/arkade/cmd/kasten github.com/alexellis/arkade/cmd/system github.com/alexellis/arkade/cmd/venafi github.com/alexellis/arkade/pkg github.com/alexellis/arkade/pkg/apps github.com/alexellis/arkade/pkg/archive github.com/alexellis/arkade/pkg/config github.com/alexellis/arkade/pkg/env github.com/alexellis/arkade/pkg/get github.com/alexellis/arkade/pkg/helm github.com/alexellis/arkade/pkg/k8s github.com/alexellis/arkade/pkg/types -cover
?       github.com/alexellis/arkade     [no test files]
ok      github.com/alexellis/arkade/cmd (cached)        coverage: 18.1% of statements
ok      github.com/alexellis/arkade/cmd/apps    (cached)        coverage: 2.0% of statements
?       github.com/alexellis/arkade/cmd/kasten  [no test files]
?       github.com/alexellis/arkade/cmd/system  [no test files]
ok      github.com/alexellis/arkade/cmd/venafi  (cached)        coverage: 3.2% of statements
?       github.com/alexellis/arkade/pkg [no test files]
?       github.com/alexellis/arkade/pkg/apps    [no test files]
?       github.com/alexellis/arkade/pkg/archive [no test files]
ok      github.com/alexellis/arkade/pkg/config  (cached)        coverage: 18.2% of statements
?       github.com/alexellis/arkade/pkg/env     [no test files]
ok      github.com/alexellis/arkade/pkg/get     (cached)        coverage: 49.0% of statements
ok      github.com/alexellis/arkade/pkg/helm    (cached)        coverage: 6.2% of statements
?       github.com/alexellis/arkade/pkg/k8s     [no test files]
?       github.com/alexellis/arkade/pkg/types   [no test files]
go build
mkdir -p bin
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -a -installsuffix cgo -o bin/arkade
CGO_ENABLED=0 GOOS=darwin go build -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -a -installsuffix cgo -o bin/arkade-darwin
CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 go build -a -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -installsuffix cgo -o bin/arkade-darwin-arm64
CGO_ENABLED=0 GOOS=linux GOARCH=arm GOARM=6 go build -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -a -installsuffix cgo -o bin/arkade-armhf
CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -a -installsuffix cgo -o bin/arkade-arm64
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -ldflags "-s -w -X github.com/alexellis/arkade/cmd.Version=0.8.18-24-g85a2bc1 -X github.com/alexellis/arkade/cmd.GitCommit=85a2bc143e8f89b9ce23bf5806cc1b6f09d216bc" -a -installsuffix cgo -o bin/arkade.exe
rm -rf bin/*.sha256 && ./hack/hashgen.sh

Are you a GitHub Sponsor (Yes/No?)

[ ] Yes
[x] No

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[ ] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

[x] I have tested this on arm, or have added code to prevent deployment

@Shikachuu please could you give your review on this?

Thank you for improving @hwchiu
If you're not a GitHub Sponsor yet, please consider it as it helps me to fund time on arkade


[sketch] Sketches aren't in sync between deck planks

Repro: Create a sketch in a collection then open it in a separate deck plank. Edit in either side. they don't sync across.
https://github.com/dxos/dxos/assets/27258/7ccbf903-2d13-476d-b3da-230890085128

Closed by #7178


[WIP] feature: payment customization sample app

What does this PR do
This PR adds a new sample app that focuses on showcasing the use of the Payment Customization API.
Important
We'll need to update the function after the  API for presentmentCurrencyRate is fixed.
At the moment the admin doesn't recognize our payment customization app and because of that it doesn't enable the "native" UI for us to redirect users to like the Discounts example does. So the UI is completely custom right now.
https://user-images.githubusercontent.com/1956448/194645133-680a471c-7dae-48ed-9129-d9d409b93421.mov

Alright team, after fighting with Rust and types for a while this is now working from end-to-end! 🎉
There a few more details I need to work on:

Update README with proper instructions and notes
Clean the backend, lot of copy and paste atm

There are also a couple things to note:

I left a TODO comment about the changes that will need to be made after the api is fixed for presentmentCurrencyRate
ATM the admin doesn't recognize our payment customization app and because of that it doesn't enable the "native" UI for us to redirect users to like the Discounts example does.

Thanks for the updates Marlon! Just 🎩 and it looks like 1 and 2 are resolved. The save button at the top of the edit page still seems to do nothing though.

Thanks for the updates Marlon! Just 🎩 and it looks like 1 and 2 are resolved. The save button at the top of the edit page still seems to do nothing though.

My bad. That should be fixed now.


drivers: adc: sam0: Fix driver and sample

The adc_sam0 driver previously expected sequence->channels == 1, which is not compatible with the ADC sample, and might be unexpected. In an attempt to avoid breaking changes, I have revised this to require a single bit set (with no confirmation as to whether it is the correct bit). The input channel for this driver needs to be set using the "configurable inputs" API instead - differential or not.
I have also revised adc_sam0 so that it supports devices with MCLK, but only one ADC. This will be important for SAML21 support (see #41308).
Finally, I have revised the drivers/adc sample so that it will operate the "configurable inputs" API correctly.
This PR is split out from #41308.

Codecov Report

Merging #41319 (f076540) into main (5fda6a3) will increase coverage by 0.03%.
The diff coverage is 59.13%.

:exclamation: Current head f076540 differs from pull request most recent head 05a0acd. Consider uploading reports for the commit 05a0acd to get more accurate results

@@            Coverage Diff             @@
##             main   #41319      +/-   ##
==========================================
+ Coverage   51.24%   51.27%   +0.03%
==========================================
  Files         605      606       +1
  Lines       70878    71042     +164
  Branches    16333    16364      +31
==========================================
+ Hits        36318    36425     +107
- Misses      28572    28607      +35
- Partials     5988     6010      +22

Impacted Files
Coverage Δ

include/device.h
84.61% <ø> (ø)

include/net/ethernet.h
51.28% <ø> (ø)

subsys/net/ip/ipv6.c
56.75% <0.00%> (ø)

subsys/net/ip/net_shell.c
6.67% <0.00%> (-0.04%)
:arrow_down:

subsys/net/lib/sockets/sockets_packet.c
36.76% <0.00%> (-0.28%)
:arrow_down:

subsys/net/ip/ipv6_nbr.c
33.49% <41.17%> (+0.42%)
:arrow_up:

subsys/net/ip/route.c
56.10% <64.70%> (+5.13%)
:arrow_up:

kernel/userspace.c
87.50% <75.00%> (-0.27%)
:arrow_down:

lib/os/heap_listener.c
88.23% <88.23%> (ø)

lib/libc/newlib/libc-hooks.c
52.41% <100.00%> (+0.38%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fda6a3...05a0acd. Read the comment docs.

@nandojve thanks for your comments.
I didn't consider a fixup.h, as I didn't know they existed... I'm not convinced it's the correct approach here, as we'd need to set it up for all supported parts... this way the driver targets the three known implementations (i.e: SAML2x, SAMD2x, SAME5x). If there become more possibilities, then it might become sensible, but in the interest of keeping changes small to avoid breaking things, I think I'd pick this route.
Regarding your 4x remaining comments, I hope my reasoning stands. If not, I'll do what I think you're after...

@nandojve I believe I have now implemented an adc_fixup.h as requested. I've left this as a separate patch, as it's quite far-reaching...

@nandojve I've now re-worked the fixup header.
The SAML21 support is added transparently, as I felt this was acceptable and easiest... it won't be usable until #41308 is merged (unless another existing part has the same shape ADC).
I've also rebased on main

I have some more fixes for the ADC driver coming - are is it okay for me to roll them into this PR, or would a new PR be preferred?

REFCTRL is enable-protected on the SAML21, meaning that the ADC needs to be disabled before changing it.

Docs indicate that this is probably true for SAMD21 too (along with the "discard next sample after reference change")
SAME54 seems to not have this restriction

On SAML21, the reference mapping is different

Zephyr's ADC_REF_VDD_1_2 -> ASF's ADC_REFCTRL_REFSEL_INTVCC1
Zephyr's ADC_REF_VDD_1 -> ASF's ADC_REFCTRL_REFSEL_INTVCC2
I'd propose putting this into a new per-soc fixup header.

Hi @anangl , @stephanosio , @mnkp,
Should this fix be at v3.0?

Rebase


add Polymorphic relations without embedding inline properties to type

Elqoent has polymorphic-relationships , some times developer wants to create  polymorphic models ( type, id ) without embedding them into a table, you know like centralized table, ex  :
translate table that mapped to
locale
key
value
translatble_type
translatble_id
and User, Category, ...
use them without having properties themselves, I think the Embeddable in mikro-orm is a powerful tool but needs to have this feature

Closing as duplicate of #706


Add Observable.Map for simple observable transformations.

Codecov Report
Base: 99.03% // Head: 99.12% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (613fe69) compared to base (db30217).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   99.03%   99.12%   +0.09%
==========================================
  Files          18       19       +1
  Lines         723      804      +81
==========================================
+ Hits          716      797      +81
  Misses          7        7

Impacted Files
Coverage Δ

src/TinkState/Runtime/Internal/Dispatcher.cs
100.00% <ø> (ø)

...TinkState/Runtime/Internal/ObservableDictionary.cs
100.00% <ø> (ø)

src/TinkState/Runtime/Internal/ObservableList.cs
100.00% <ø> (ø)

src/TinkState/Runtime/Observable.cs
100.00% <ø> (ø)

src/TinkState/Runtime/Internal/AutoObservable.cs
100.00% <100.00%> (ø)

src/TinkState/Runtime/Internal/Binding.cs
98.43% <100.00%> (+0.22%)
:arrow_up:

src/TinkState/Runtime/Internal/ConstObservable.cs
100.00% <100.00%> (ø)

src/TinkState/Runtime/Internal/State.cs
100.00% <100.00%> (ø)

.../TinkState/Runtime/Internal/TransformObservable.cs
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


cant see recipes in JEI

I cant see ammo recipes in JEI for all anti gravity, silver, tungsten and mini nuke bullets,

Hi there is currently no recipe added in this mod :)

Hi you can obtain most items through trading now.

Hi you can obtain most items through trading now.


There is no documentation around few parameters

Hi Team,
When we see the Dataverse search on MDA executed there are extra attributes in the payload however they are not documented here. And I believe because of these the results in MDA are way different than we are getting in API. Also the Search connector is build around the existing documented params only .

Regards
Pavan

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2524b4fe-020f-5067-97c9-2cf440281838
Version Independent ID: 134dc37f-d1cf-7c65-b1cd-aadeb4463acd
Content: Search across table data using Dataverse search - Power Apps
Content Source: powerapps-docs/developer/data-platform/webapi/relevance-search.md
Service: powerapps
Sub-service: dataverse-developer
GitHub Login: @mspilde
Microsoft Alias: mspilde

Thanks for your comment, @pavansarma93. This issue has been assigned to the doc author for review.

@pavansarma93
Thanks for your input.
Adding @AnimeshAngrish
I'm also noting the other issue you have opened about search api in #4612. Looking for confirmation from you about that issue.
@mspilde and @AnimeshAngrish: Can you comment on this?

@pavansarma93
Since you opened this issue we released documentation about the search 2.0 endpoint. See Search for Dataverse records, and the documentation is much better than what is now called the Dataverse search (legacy).
We aren't going to invest more in the legacy search documentation.
Not sure what your goal is, but perhaps you can use the newer search API instead of the one used by MDA or the connector?


Clarify PII concerns in the TAG security doc.

Addresses https://github.com/MicrosoftEdge/MSEdgeExplainers/issues/542

@caraitto PTAL. Thanks!


chore: update all the git submodules

Signed-off-by: feng-tao<EMAIL_ADDRESS>
Summary of Changes

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely, including a title prefix.
[ ] PR includes a summary of changes.
[ ] My commits follow the guidelines from "How to write a good git commit message"

update submodules, will merge as it is


Make incremental checks compare against merge base with chosen revision

Updated both coverage and format checks.
Prevents changes being merged into master turning into extra formatting errors on an unrelated branch.

Fixes https://github.com/quantumlib/Cirq/issues/1598

Automerge cancelled: A status check is failing.

Automerge cancelled: A required status check is not present.
Missing statuses: ['Travis CI - Pull Request']


Egeria lab notebooks failing in master - servers not starting

All servers reporting
                       error message is: OMAG-ADMIN-400-012 The OMAG server cocoMDS2 has been passed an invalid admin services class name org.odpi.openmetadata.accessservices.securityofficer.server.admin.admin.SecurityOfficerAdmin for access service Security Officer

during startup
cc: @mandy-chessell

Sorry about that - I'll have a look at it

Sorry about that - I'll have a look at it

Are you using an old config file?  Trying to work out where the class name is coming from.  The correct class name is
org.odpi.openmetadata.accessservices.securityofficer.server.admin.SecurityOfficerAdmin and the code uses
SecurityOfficerAdmin.class.getName()

to set it up.  So a bit puzzled.  This class name has not changed in the recent restructure either.

Are you using an old config file?  Trying to work out where the class name is coming from.  The correct class name is
org.odpi.openmetadata.accessservices.securityofficer.server.admin.SecurityOfficerAdmin and the code uses
SecurityOfficerAdmin.class.getName()

to set it up.  So a bit puzzled.  This class name has not changed in the recent restructure either.

Ah... that's possible... as I've been working with persistent storage in k8s..  So you are right that I may well have an old config file! Will cleanup and check.
Do we say anything about version compatibility of config files? I wonder if we need to make it clear they need recreating?

Ah... that's possible... as I've been working with persistent storage in k8s..  So you are right that I may well have an old config file! Will cleanup and check.
Do we say anything about version compatibility of config files? I wonder if we need to make it clear they need recreating?

Your suggestion was correct. I had enabled persistence (which was working). So in terms of the failure to start, that is user error. The only question is whether a user could fall into this trap generally, and whether we need to document

Your suggestion was correct. I had enabled persistence (which was working). So in terms of the failure to start, that is user error. The only question is whether a user could fall into this trap generally, and whether we need to document

Security Officer OMAS is in developement state so it is legitimate that it changes

Security Officer OMAS is in developement state so it is legitimate that it changes

Agreed. Will close. (longer term we should consider testing with prior version config files - to ensure no regressions in released areas)

Agreed. Will close. (longer term we should consider testing with prior version config files - to ensure no regressions in released areas)


Prevent Entering Factory while Moving Downward (Or Flying?)

If it possible, it would be nice if you couldn't enter the factory while moving downwards, or possibly while flying if you can check for that.
The mech armor is very prone to entering factories by accident when you are flying over them.

Sorry, I will not do this. The mech armor factory entrance code has already gone through many revisions. It "works" well enough for now. I don't want to look at it anymore.


Projects in DCP not in catalogue

Description of the issue
There are 38 projects in the the data portal that do not appear in the project catalogue. From these, 4 are not in ingest either, so they are probably datasets from lattice.
List of the 34 remaining projects:

https://contribute.data.humancellatlas.org/projects/detail?uuid=8a40ff19-e614-4c50-b23b-5c9e1d546bab
https://contribute.data.humancellatlas.org/projects/detail?uuid=403c3e76-6814-4a2d-a580-5dd5de38c7ff
https://contribute.data.humancellatlas.org/projects/detail?uuid=d3446f0c-30f3-4a12-b7c3-6af877c7bb2d
https://contribute.data.humancellatlas.org/projects/detail?uuid=7880637a-35a1-4047-b422-b5eac2a2a358
https://contribute.data.humancellatlas.org/projects/detail?uuid=71436067-ac41-4ace-be1b-2fbcc2cb02fa
https://contribute.data.humancellatlas.org/projects/detail?uuid=d012d476-8f8c-4ff3-89d6-ebbe22c1b5c1
https://contribute.data.humancellatlas.org/projects/detail?uuid=78b2406d-bff2-46fc-8b61-20690e602227
https://contribute.data.humancellatlas.org/projects/detail?uuid=faeedcb0-e046-4be7-b1ad-80a3eeabb066
https://contribute.data.humancellatlas.org/projects/detail?uuid=3e329187-a9c4-48ec-90e3-cc45f7c2311c
https://contribute.data.humancellatlas.org/projects/detail?uuid=376a7f55-b876-4f60-9cf3-ed7bc83d5415
https://contribute.data.humancellatlas.org/projects/detail?uuid=e77fed30-959d-4fad-bc15-a0a5a85c21d2
https://contribute.data.humancellatlas.org/projects/detail?uuid=e526d91d-cf3a-44cb-80c5-fd7676b55a1d
https://contribute.data.humancellatlas.org/projects/detail?uuid=414acced-eba0-440f-b721-befbc5642bef
https://contribute.data.humancellatlas.org/projects/detail?uuid=3cfcdff5-dee1-4a7b-a591-c09c6e850b11
https://contribute.data.humancellatlas.org/projects/detail?uuid=dbcd4b1d-31bd-4eb5-94e1-50e8706fa192
https://contribute.data.humancellatlas.org/projects/detail?uuid=ad04c8e7-9b7d-4cce-b8e9-01e31da10b94
https://contribute.data.humancellatlas.org/projects/detail?uuid=34cba5e9-ecb1-4d81-bf08-48987cd63073
https://contribute.data.humancellatlas.org/projects/detail?uuid=b9484e4e-dc40-4e38-9b85-4cecf5b8c068
https://contribute.data.humancellatlas.org/projects/detail?uuid=56e73ccb-7ae9-4fae-a738-acfb69936d7a
https://contribute.data.humancellatlas.org/projects/detail?uuid=8dacb243-e918-4bd2-bb9a-aac6dc424161
https://contribute.data.humancellatlas.org/projects/detail?uuid=da2747fa-2921-42e0-afd4-39ef57b2b88b
https://contribute.data.humancellatlas.org/projects/detail?uuid=dd7f2436-0c56-4709-bd17-e526bba4cc15
https://contribute.data.humancellatlas.org/projects/detail?uuid=8999b456-6fa6-438b-ab17-b62b1d8ec0c3
https://contribute.data.humancellatlas.org/projects/detail?uuid=9bab0f03-a725-4a13-9ab1-196e46cd80ed
https://contribute.data.humancellatlas.org/projects/detail?uuid=4af795f7-3e1d-4341-b867-4ac0982b9efd
https://contribute.data.humancellatlas.org/projects/detail?uuid=79b13a2a-9ca1-42a4-97bd-70208a11bea6
https://contribute.data.humancellatlas.org/projects/detail?uuid=20f37aaf-caa1-40e6-9123-be6ce8feb2d6
https://contribute.data.humancellatlas.org/projects/detail?uuid=50151324-f3ed-4358-98af-ec352a940a61
https://contribute.data.humancellatlas.org/projects/detail?uuid=504e0cee-1688-40fa-b936-361c4a831f87
https://contribute.data.humancellatlas.org/projects/detail?uuid=3c27d2dd-b180-4b2b-bf05-e2e418393fd1
https://contribute.data.humancellatlas.org/projects/detail?uuid=a80a63f2-e223-4890-81b0-415855b89abc
https://contribute.data.humancellatlas.org/projects/detail?uuid=602628d7-c038-48a8-aa97-ffbb2cb44c9d
https://contribute.data.humancellatlas.org/projects/detail?uuid=65858543-530d-48a6-a670-f972b34dfe10
https://contribute.data.humancellatlas.org/projects/detail?uuid=8d566d35-d8d3-4975-a351-be5e25e9b2ea

Acceptance criteria

[ ] Identify which of the 34 projects in the DCP are duplicated in ingest
[ ] Delete the duplicates
[ ] Set the isIncatalogue flag to true for the submitted projects and curate the project description

I believe we already covered this through other tickets at least with regards to the Projects that are in DCP, and were submitted by EBI. So I will close this ticket. We probably still need some clean-up on the UCSC front.


⚠ Bofrost.de has degraded performance

In a10193c, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1198 ms

Resolved: Bofrost.de performance has improved in 2be0dd4 after 6 minutes.


LPC11xx_v6.svd has multiple enumerated values with the same name

So far we have been correcting names of things in extention files in order to not mess with the SVD (in order to stay open to drop in improvements from the vender), however since the extention files index things by name ambiguities are impossible to correct.
The offending tag is <name>COUNTER_MODE_TC_IS_</name> which occurs three times in the CTM field of the CTCR register all with different values.
What should we do to fix this?

Just an idea... maybe you could append the value into the name. Either in a separate post-process step or in all cases where the last character of the name is "_".
COUNTER_MODE_TC_IS_1
COUNTER_MODE_TC_IS_2
COUNTER_MODE_TC_IS_3

good idea, maybe we could also make an alternative indexing mode in the extension files too. I'm a little reluctant to make too many changes because of this because in my mind it is simply an NXP error. I'm also considering just changing the svd file in this case.

Hi all!
I know this is an old issue/thread, but seemingly nobody is tending to it.
Most  NXP LPC SVD's are obviously autogenerated from the docs, with truncating, so this issue is present in them. Either the header generator won't eat them, or their output is unchecked, and won't work.
I made corrections in LPC82X.svd - which is not in this repo by the way - and will definitely do the same for some others.
So if no objections, I would like to hijack this issue, and document here the progression.

go for it, glad to here someone is working on it!


Update README.md

Huggingface -> Hugging Face

Hi @eltociear, thanks for your PR! While we appreciate your attention to detail, we're currently prioritizing PRs that affect the functionality of our code. We're not planning on merging typo fixes at this time, but we'd love to see more contributions from you in the future, especially those addressing bugs or suggesting enhancements. Thanks again for your involvement in our project.


feat: Add support for EnableApiVersioningHeader option for servers v8+

We have upgraded Elastic server to version 8.1.3 and experienced errors. After reading https://www.elastic.co/guide/en/elasticsearch/client/net-api/7.17/connecting-to-elasticsearch-v8.html#enabling-compatibility-mode and https://github.com/elastic/elasticsearch-net/issues/6154 we tried setting the ELASTIC_CLIENT_APIVERSIONING environment variable which fixed it.
One of our applications, though, connects to two different Elastic servers, one for logging and one for a search index. The search index server is on version 7.10 which does not yet support ApiVersioningHeader, and we cannot upgrade it yet. Thus we need NLog target to run with EnableApiVersioningHeader and the other client without.
This PR adds support for enabling ApiVersioningHeader just for the NLog target from config.
A limitation is, that it will not work when enabling it for servers running <7.13 (as per https://github.com/elastic/elasticsearch-net/issues/6154#issuecomment-1095182360) but I think that could be adequately explained in documentation.
Checklist

[x] My commits follow Conventional Commits
[ ] documentation is updated

It was the following low level error:
Invalid NEST response built from a successful (200) low level call on POST: /_bulk
# Invalid Bulk items:
  operation[0]: index returned 201 _index: x-2022.04.21 _type:  _id: vUmiS4ABsXhEMlfGFdaJ _version: 1 error:
# Audit trail of this API call:
 - [1] PingSuccess: Node: https://x/ Took: 00:00:00.2103319
 - [2] HealthyResponse: Node: https://x/ Took: 00:00:00.3831254
# Request:
<Request stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>
# Response:
<Response stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>

@markmcdowell Think all 3 pull-requests #156 + #159 + #160 should be merged, and then release NLog.Targets.ElasticSearch ver. 7.8


Background Color Picker is not working - ui_dashboard

Describe the bug
Background color selector is not working in ui_dashboard.html
To Reproduce
Steps to  ui_dashboard.html:

Go to home page, click on "Explore"
From dashboard.html, click on "pages" on the top menu
click on "UI DASHBOARD"
In the ui_dashboard.html file, try to add a box and change the background color.
You would observe that the change in color is not applied to the box.

Expected behavior
upon changing the color picker, the color of the box or shape in the development environment is suppose to change too.
Additional context
This feature is going to be added to the dashboard.html file and many more color selection areas.

Hi! I want to work on this bug.

hello @Himanshu-Vishwas I observed that you showed interest in solving a lot of issues but for sake of credibility and accountability, I would only assign two to you at the moment. Hopefully we can assign more to you in the future. Thank you and happy contributing.

I have solved it. Let's move on...


Firstgraph

Renders a couple sample graphs on the main page

I fixed the inconsistent formatting, and also figured out how to get Django working from within Jupyter.  I think this can be merged with the main branch now, because the next things I want to do no longer fit in the scope of the "first graph".


Allow mocking a function that isn't linked into the exe

When linking a test executable, we sometimes don't want to link it with all the libraries that are used in production. Mocking is very useful for this - if you mock all functions in a library, you don't need to link with the library itself. But C-mock searches for the real function with dlsym, and fails if it doesn't exist. So you have to link with it.
In my company linkage is a mess, so we have a local change that checks if the function exists only if we actually try to call it. This is very useful for us.
You can see the code in a branch in my clone.
But this changes behavior unconditionally, so I don't think it's appropriate for merge.
The only difficulty is how can we make it conditional. There are may alternatives, such as:

Compile time switch (e.g. make ALLOW_MISSING=1).
A separate set of macros (e.g. CMOCK_MOCK_FUNCTIONn_ALLOW_MISSING).
When using a mock class, a variation of CMockMocker (e.g. CMockMockerAllowMissing).
A macro defined by used before defining mocks (e.g. #define CMOCK_ALLOW_MISSING 1).

Can we add this functionality?
Thanks.

Sorry for late reply. I would opt for alternative approach. A lazy loading of a real function. As long as a given function is not mocked no error will be thrown even if it's not available.

A situation in which you call a function which you neither linked with or mocked I see as a bug. I would make a lazy loading the default behaviour.

Thanks. I'll prepare the code and submit a pull request.
On Mon, May 7, 2018, 2:33 PM Hubert Jagodziński<EMAIL_ADDRESS>wrote:

A situation in which you call a function which you neither linked with or
mocked I see as a bug. I would make a lazy loading the default behaviour.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hjagodzinski/C-Mock/issues/11#issuecomment-387037346,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ8EVh18S7twlA9iOhS1_wph7_YZVO_Jks5twDD-gaJpZM4TX74-
.

👍

Submitted pull request. CI passed.
BTW, C-Mock now fails to compile with latest Google Mock.
The problem is with the old macros, which rely more heavily on Google Mock
internals than the old ones.
On Mon, May 7, 2018 at 2:52 PM, Hubert Jagodziński<EMAIL_ADDRESS>
wrote:

👍
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hjagodzinski/C-Mock/issues/11#issuecomment-387041120,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ8EViwFAQahJumerDgQKpBOG1Yj3SHyks5twDVngaJpZM4TX74-
.

Can you create an issue on that so we can address it as a distinct problem?

I'm not sure what you see as a distinct problem.
On Mon, May 14, 2018, 11:38 AM Hubert Jagodziński<EMAIL_ADDRESS>wrote:

Can you create an issue on that so we can address it as a distinct problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hjagodzinski/C-Mock/issues/11#issuecomment-388740332,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ8EVh_8YNyWgAR1hUojit_clLTKPlqYks5tyUKQgaJpZM4TX74-
.

I have in mind C-Mock now fails to compile with latest Google Mock.

Ah, sure
On Mon, May 14, 2018, 12:09 PM Hubert Jagodziński<EMAIL_ADDRESS>wrote:

I have in mind C-Mock now fails to compile with latest Google Mock.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hjagodzinski/C-Mock/issues/11#issuecomment-388749153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ8EVn1Magr6j3fTC2A4rIYDVGbBOlfXks5tyUnkgaJpZM4TX74-
.


Items no longer display appropriate colours (Foundry v9, Custom Rarities & Currencies v1.0.0)

The items no longer seem to display the appropriate colours, except when displayed in the directory.

That is a feature of the Rarity Colors module which has not been updated for V10.


Routing to another page does not load external scripts

Bug Report or Feature Request (mark with an x)

[x] bug report
[ ] feature request

Versions
Node: v10.7.0
npm 6.1.0
Angular CLI: 6.0.8
Angular: 6.1.6
Repro steps
https://github.com/cactusjack66/ScriptRouteTest.git
Desired functionality
The collapse button on the top right corner of the box collapses the box on page1 after the page has been loaded. After clicking the redirect button to page2 it does not work any longer. You have to reload the page to make it work again. I have added all neccessary scripts and styles to the angular.json file.
Mention any other details that might be useful
After checking out use npm install @angular-devkit/build-angular to get it work.

Thanks for reporting this issue. However, this issue is a duplicate of #11044. Please subscribe to that issue for future updates.


Elasticsearch index backup

The script backs up and uploads the specified indices.  At the moment I have the named the elasticsearch repo to kibana-dashboards but we could name it something more generic in case we wanted to use this script to backup other indexes on other hosts in future. The fact that a specified index may not exist will not cause the command to fail and it should just continue.

@MatMoore can we use this ^ for search indices?

@tijmenb in theory yes, this PR is doing is the same thing as our rummager code.
For more info about what we did, see the rummager implentation and the previous PR against puppet
The complications we ran into were around pruning old snapshots, and ensuring that multiple snapshot operations (create and delete) don't run concurrently.
If you don't prune the snapshots, then I think the time taken degrades over time. Some discussion of this here: https://groups.google.com/forum/#!msg/elasticsearch/cXl9UrqgwBI/et56xPUqwGkJ
The things that will differ for rummager:

There is currently nginx server between rummager and the elasticsearch cluster - I think this introduces some issues with request timeouts, since the api requests can take a long time to complete
The code doesn't exist yet, but if we add tools for restoring snapshots, the name of the index matters even if its aliased

Will the configuration of the ES repository be handled by puppet as well?

I think the code looks good.

Will the cron job have a passive icinga alert associated with it?

Yes, I can add the passive check.

Couple of comments but other than that it looks OK. Probably merge when ready and test in Integration.

Retiring this one in favour of this https://github.com/alphagov/govuk-puppet/pull/4637


Line Graph - Smoothed Line - Feature Requst

Hi.
Please could you tell me if there is a way to enabled the "Smoothed Line" feature on a line graph.
Thanks in advance.

Good question, don't know. Please post a screen shot how you do that in the Excel UI.

I think, he means something like that.
It can be done in that way
$chart = Add-ExcelChart ....... $chart.Series[0].Smooth = $true

Thanks for the snippet!


Bevy cannot run in the background on Android

Bevy version
main (b61397e32bca34958e57198c0969359da647eafa) and last releases
What you did
Run the android example on a real device (Samsung Galaxy S10+). Now press the home button to minimize the app, then open it back up.
What went wrong
The App quits (at least logs do not indicate a crash) and will start from the beginning when reopened.
Additional information
This is a known problem (see some general discussion about life cycle handling in #86), but I couldn't find an open issue for it.

android drops the gl/vulkan context when an app is suspended. To fix it Suspend and Resume winit events need to be handled, suspending rendering pipeline on Suspend and rebuilding wypu context on Resume

at the moment this is handled by just closing the app whenever it's suspended
https://github.com/bevyengine/bevy/blob/b88ff154f24314539fc7f03572215bd0283d98ee/crates/bevy_winit/src/lib.rs#L663-L674

Summarizing some investigation into this: it appears to require fixes upstream in winit.
Bevy needs to receive and handle both the pause and stop event from Android, but winit does not forward this to us.
Related issues: https://github.com/rust-windowing/winit/issues/2736, https://github.com/rust-windowing/winit/issues/2337

Summarizing some investigation into this: it appears to require fixes upstream in winit.
Bevy needs to receive and handle both the pause and stop event from Android, but winit does not forward this to us.
Related issues: rust-windowing/winit#2736, rust-windowing/winit#2337

Why is stop evt required to fix this if surface gets destroyed after pause?

@mfrancis107 is this issue complete? If not, what's left?

I believe this is finished: feel free to open new issues for remaining problems.

It's not complete at all, we're unable to run in background

If not, what's left?

To run in background, we need to be able to run the main app while skipping part of the rendering app.
We can't interact with the GPU in the background, but we need to not miss events to change rendering assets and play them when the app comes back in the foreground

Any progress?


[Automation] Generate Fluent Lite from Swagger databoxedge#package-2019-08

[Automation] Generate Fluent Lite from Swagger databoxedge#package-2019-08

API change check
API changes are not detected in this pull request.


Add request for code coverage

Code coverage is a valuable tool used to show that code is not dead or included hidden functionality.

I agree code coverage can be valuable.  I expect we'll hear some opposition about this from Greg KH (a key Linux kernel developer).  He agrees that testing is valuable, but believes that measuring code coverage focused on the wrong things (I'm paraphrasing here).  I also worry about all the "slippery" requirements (there are already some others) - where possible I'd like these criteria to be so crisp that people can clearly show they're true or false.
I'd like to hear from others about this proposal!

There's a lot of controversy on this.  In particular, some programs (like the Linux kernel) are notoriously difficult to thoroughly test, and it's often easy to create really BAD tests that still achieve high coverage.  However, it's certainly worth consideration.  So here's my attempt to resolve it.
I've added 80% branch coverage as a potential criteria (commit 7b57b4d88ff81), but not included it in any particular place.  80% coverage is also a permitted way to implement dynamic testing, though not the only way to do that.  There's a 100% coverage requirement in the early draft "gold" criteria.  I hope that at least starts to capture things.


[Knack] Monitor module conversion.

Closes #4938.  Tests will be re-enabled in subsequent PR.

View a preview at https://prompt.ws/r/Azure/azure-cli/5125
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.


High resolution metrics in CloudWatch

Is your feature request related to a problem? Please describe.

I need to graph estimated TPS for a 3rd party api. We have a TPS rate limit that must be monitored closely using Count/Second metrics. The current implementation aggregates metrics at a 1 minute interval even if the "CountPerSecond" unit is specified. I recognize metrics are grouped together under one timestamp, which might make this feature request a lower priority.
Describe the solution you'd like

Parameter to enable "High-Resolution Metrics" for 1 second intervals
Describe alternatives you've considered

Rest API / Cloudwatch SDK for these metrics.
Additional context

Official Docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/publishingMetrics.html#high-resolution-metrics

I'm gonna close this now since we added this as a feature request for the CloudWatch EMF team


feat: script to manage ownership

Script to manage ownership for all contracts that inherit the SDK Ownable.sol as per AXE-1594:
https://axelarnetwork.atlassian.net/browse/AXE-1594

https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/contracts/interfaces/IOwnable.sol
This interface implements both:

transfer ownership in a single tx
2 step transfer: Propose and accept

Why have we implemented both options?

https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/contracts/interfaces/IOwnable.sol
This interface implements both:

transfer ownership in a single tx
2 step transfer: Propose and accept

Why have we implemented both options?

My understanding is that it provides more flexibility. There may be some circumstances where we want to perform a single step ownership transfer, but other instances where it would be more secure to perform a 2-step transfer where the proposed owner has to accept the ownership role. Not only for us, but also for developers using our SDK.


test-branch/execute-job/comment-from-wrong-user-on-pr/e5026754-18dc-4847-a33f-0e89278ffa88

PR for testing c92c22a9c0408e172225b41a4274962ea339b757

/canonical/self-hosted-runners/run-workflows c92c22a9c0408e172225b41a4274962ea339b757


Sensitivity to scale of target function

First, I apologise if this isn't the forum for what's probably a usage problem than a bug but I couldn't find anywhere else to ask a question like this.
I'm experimenting with Bayesian optimisation to optimise model parameters using a simulation code that takes ~10-60 minutes per evaluation. Modulo a small amount of (deterministic) numerical noise, I expect the target function to roughly be a correlated χ², so I've been testing scikit-optimize on a toy problem before I invest effort in the full-blown thing. As a simple example, this works reasonably well:
import numpy as np
import matplotlib.pyplot as pl # most people use plt but I'm a monster
import skopt
from skopt import plots

space = np.array([[-2.,2.]])*np.ones((5,1))

A = np.random.rand(5,5)
A = A.dot(A.T)   # guarantees positive definite A

def f(x):
    return np.dot(x, A.dot(x))

res = skopt.gp_minimize(f, space, verbose=True, n_calls=50)
ax = plots.plot_objective(res)

If I rescale the covariance matrix, however, things don't go so well...
A *= 100
res = skopt.gp_minimize(f, space, verbose=True, n_calls=50)
ax = plots.plot_objective(res)

Although I think I understand the principles of Gaussian Processes, I'm still a beginner. I expect that there are some prudent parameter choices that would resolve this but I haven't managed to find them in the documentation or any of the presentations/talks I've found about Bayesian optimisation.

I've also experienced a similar behavior, leading me to always normalize the values before feeding them to skopt (I usually divide everything for the first value i try).
My guess on this is that with huge numbers the covariance grows bigger (as you did in your example) and to account for this we would need to put the ard to very low values, but skopt places some limits while optimizing them.

Is there a rule of thumb about whether and how we should change the values of 'xi' and 'kappa' depending on the scale of the target function? Also, did you try scaling the values as @stefanocereda suggested? My target function is actually the execution time of an application. Should I pass the values to skopt in seconds or minutes to reduce the scale?


99 - Confu for config schemas

fixes #99
note - this contains the changes of #108 - for easy reviewing should wait until #108 has been merged to master

Codecov Report

Merging #112 (c282e04) into master (f9c1a22) will increase coverage by 3.32%.
The diff coverage is 87.72%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   69.26%   72.58%   +3.32%
==========================================
  Files          16       17       +1
  Lines         924     1058     +134
==========================================
+ Hits          640      768     +128
- Misses        284      290       +6

Impacted Files
Coverage Δ

src/vaping/cli.py
76.36% <0.00%> (ø)

src/vaping/plugins/command.py
0.00% <0.00%> (ø)

src/vaping/plugins/fping_mtr.py
93.61% <ø> (ø)

src/vaping/util.py
50.00% <ø> (ø)

src/vaping/io.py
52.38% <52.38%> (ø)

src/vaping/plugins/__init__.py
63.44% <82.22%> (ø)

src/vaping/config/schema.py
89.47% <89.47%> (ø)

src/vaping/daemon.py
57.55% <91.42%> (ø)

src/vaping/__init__.py
100.00% <100.00%> (ø)

src/vaping/config/__init__.py
100.00% <100.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3b3094...c282e04. Read the comment docs.


chore: upgrade to yarn 2

Description
Migrates Composer to Yarn 2. Addresses some issue with Yarn > 1.18 not being able to add a dependency in a workspace.
Task Item
#minor

Love to see we are moving to yarn2 and have to say sorry that i merged two PRs that updating some dependencies causing the conflicts. Can you resolve the conflicts? (probably have to re-generate the lock file)
I will wait this PR to get in before taking changes to package.json and locks, there were some security issues i'd like to resolve.

@boydc2014 no worries. Still working on getting everything operating smoothly.

I have not been able to make this work in our CI and cannot find any resources to help. Tabling this work until Yarn 2 matures some and the migration path is easier.


AWS Stack Test

add sqs-record, docker-compose that mount localstack and zipkin-aws

@jcchavezs Hi, here you have the recorder and the docker-compose.yml if you want to review 😄. Thanks for all!!

This is great stuff. Please if you need any help or want to discuss any issue around zipkin-js we are happy to help.  Feel free to come by the issue list in case you want to do more contributing.
Keep the great work!

@llinder @beckje01 @annuraga in case you are interested, SQS on the js side!


MongoDriver liveness

Without this fix, if MainDriver loses connectivity, it will stop updating the in-memory state until the next BoskDriver method call. In some applications, this could take an unlimited time; in fact, some applications might not call the driver ever.
It turned out to be pretty easy to add a background task that periodically reconnects if it finds the driver has been disconnected.
We unit test this by changing almost all flush() calls to sleeps.
Fixes #27

Hey @gradycsjohnson what do you think?

Hey @gradycsjohnson what do you think?

Sorry I couldn't get to this sooner. Yeah I think it makes sense to Fonz it for now.

Oh no problem! It's all good. I just got excited and merged it.
I just had a better idea here though.


Setting Windows agent API key in EU site

Output of the info page (if this is a bug)
(Paste the output of the info page here)

Describe what happened:
Invalid API key, too complicated to correct from datadoghq.com to datadoghq.eu after installation with the .msi. The installer removes 'site: ' setting from the datadog.yaml file during installation. Difficult to correct without turning to the docs and/or find the link to the example datadog.yaml in the repo.
Describe what you expected:
Checkbox or radio button for choosing endpoint in the installers API key window.
Steps to reproduce the issue:
Install Windows agent with a EU based account/API key.
Additional environment details (Operating System, Cloud provider, etc):
Windows Server 2016

Hi @beloken,
Thanks for reporting this issue! We're currently working on adding the site parameter to the graphical Windows installer. Here is the relevant PR: https://github.com/DataDog/datadog-agent/pull/4858.

Hi @beloken,
I'll close this issue, as the option to specify the site parameter during the Windows install (implemented in #4858) is included in versions 6/7.18.0 and above of the Agent. Don't hesitate to re-open it if you face any new issues with this new feature.

Still facing the same issue.


Use explicit memory settings for Java cookie cutters

Hi all - I just used "java" cookie cutter today and noticed that it had a very long cold start (14 seconds.) After a quick bit of investigation I realized it was using the default MemorySize of 128MB, which is barely sufficient for JVM Lambdas. I recommend setting this explicitly, e.g. to 512 or 1024 for the Java and Gradle cookie cutters.

This issue was probably resolved by #1340.
Released in v0.21.0.
https://github.com/awslabs/aws-sam-cli/releases

Resolving this issue as the PR is merged and I confirmed that on creating new sam cli project default memory allocated is 512 MB.


"params.script" is not configurable

There seems no way to set the script option. If you would change params.script top options.script it would be possible to define a router script to handle the requests.

Just updated README.md with the rewrite option.

Closing this issue for now. Thanks!

Thanks for updating the readme. But this doesn't handle my use case. I need to point every request to a router script (e.g. index.php) so it's necessary to set the SCRIPT_FILENAME and the SCRIPT independently. I could provide a PR if you like.

Please feel free to submit a PR.

PR #3 merged

\o/ 🎉


FreezeTopRow

There is a bug in Export-Excel.ps1 on Line 497. It should be $ws.View.FreezePanes(3, 1). I would make a pull request, but I can't on the company computer I'm on and my laptop is broken at the moment.

Thanks! I hope your dog didn't eat your homework too 😆

Could you post a short script that repros this?

I call the function like this. Row 1 has the Title, and row 2 has the headers for the table. Without changing the line above to 3, 1, only the Title is locked. The header rows disappear when I scroll.
Export-Excel -InputObject $Data -Path $OutputFile -TableName $SheetName.Replace(' ', '_') -WorksheetName $SheetName -AutoSize -FreezeTopRow -TableStyle $TableStyle -Title $SheetName -TitleBold -TitleSize 18
Funny you mention a dog... He's the reason my laptop is broken. He has no boundaries.

Lol, that is hilarious, sorry, and not funny. Those pooches ...
Thanks for the repro, I will take a look.

I'll take a deeper look when I can.
You can use -FreezePane 3, 1 instead.
$data = ConvertFrom-Csv @"
Region,State,Units,Price
West,Texas,927,923.71
North,Tennessee,466,770.67
East,Florida,520,458.68
East,Maine,828,661.24
West,Virginia,465,053.58
North,Missouri,436,235.67
South,Kansas,214,992.47
North,North Dakota,789,640.72
South,Delaware,712,508.55
"@

$xlfile = ".\test.xlsx"
Remove-Item $xlfile -ErrorAction SilentlyContinue

$data | Export-Excel $xlfile -AutoSize -FreezePane 3, 1 -TableName "Test" -Title "Test" -TitleBold -TitleSize 18 -Show


Create a Contributing.md file

It seems your project doesn't contain a contributing.md file. Having that file would be really helpful for beginners to know how to contribute to the project.
The repository requires general instructions about how people can contribute to this project.
General instruction:
How to set up the project.
How they can communicate through issues.
How to create pull requests etc (Make sure to create pulls to the master branch only)

kinda new to ocktoberfest..would be good way to start for me. Can you assign me this issue? @qaidjoharj53

@Akshith-S @kclalit64
This issue is being assigned to both of you.
PR will be merged on the basis of quality of work you did.
Just do this task and give your best 100%.

@Akshith-S @kclalit64
Since you both are not working on this issue, It may be assigned to someone else.
So complete this issue fast if you are interested.

sorry, was afk for last few days. will work on it

Sorry @kclalit64 and @Akshith-S  but We Cant Wait More.

Hi @jayesh2474 , you might have missed my PR for this issue  yesterday #17 .


Update to include most recent Fall-term 1-Semester Ret data

Updated EXTRACT(YEAR FROM ADD_MONTHS(SYSDATE,0)) code on three lines to set the ADD_MONTHS second argument value to 0 from -12 (retention institution and system numerator 1-semester calculations) and -24 (at the WHERE clause).

Hi @be1ink,
This is basically the same thing I did but I don't want to change it here in the syntax library because this is the public databook version of the SQL.  The internal version is a bit different and we include things that are not in the public version.  That is the one that I updated that matches your numbers.  Probably I should add the SQL for all the different versions in GitHub, but I didn't want to confuse anyone too much.  Thanks for trying to make a contribution to the syntax library though!  Keep it coming!

@betsyrosalen ah, that makes sense! I appreciate you reviewing the proposed code. Glad that the push request got through!


Enhance alluxio helm charts

To handle #9615
Features:

Modularize the directory structure
Java and docker natively integration(Consider memory, https://developers.redhat.com/blog/2017/03/14/java-inside-docker/)
Two choices to decide short circuit: copying from directory directly or unix socket
simplify tiered storage (Combine alluxio properties and Persistent volume)
Use init container to do format /no format with intelligence
Make more configurable, like node selector, tolerance
Fuse daemonset

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5672/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5729/
Test PASSed.

@cheyang do you need any discussion / input from us to make progress? thx

Thanks a lot @cheyang for your contribution! The major comment I have is that the changes from @jiacheliu3 in the following PRs need to be merged:

https://github.com/Alluxio/alluxio/pull/9832/files
#9898

After this PR is merged we will need to update helm-generate to generate the specification yamls with the legacy directory structure for backwards compatibility

Can we create another PR to address this feature? Thanks.

@cheyang do you need any discussion / input from us to make progress? thx

I'm just back from the business travel, will handle this soon. Thanks.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5828/
Test PASSed.

Thanks a lot @cheyang for your contribution! The major comment I have is that the changes from @jiacheliu3 in the following PRs need to be merged:

https://github.com/Alluxio/alluxio/pull/9832/files
#9898

After this PR is merged we will need to update helm-generate to generate the specification yamls with the legacy directory structure for backwards compatibility

Can you open an other feature request and assign to me to address this?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5829/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5830/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5831/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5832/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5833/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5834/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5835/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5836/
Test PASSed.

@cheyang I created an issue here https://github.com/Alluxio/alluxio/issues/10011 to address the merge. I see a couple of pending comments on this PR that still need to be addressed. Let me know if we need a discussion. Thanks for addressing the previous comments.

@cheyang I created an issue here #10011 to address the merge. I see a couple of pending comments on this PR that still need to be addressed. Let me know if we need a discussion. Thanks for addressing the previous comments.

I've updated again. And you can reach me in the slack.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5883/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5884/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5885/
Test PASSed.

Thanks @cheyang. I have only one remaining comment, otherwise this looks good to merge. Do you think we can get rid of the fuse specific configMap and use ALLUXIO_FUSE_JAVA_OPTS instead for fuse specific options?

I've remove the fuse specific configMap. Pls review again.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5919/
Test PASSed.

alluxio-bot, merge this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5920/
Test PASSed.


Improve test coverage

Test coverage could be improved for some key classes. See the "Test coverage" column here:
https://scrutinizer-ci.com/g/woohoolabs/yin/code-structure/master?elementType=class&orderField=test_coverage&order=asc&changesExpanded=0

As a Test Engineer, I'd love to work on this :) I'll open a PR tomorrow with a few classes.

I would be really-really happy if you could help as I didn't really have time for this lately :/ Feel free to reach out to me if you need any guidance where to start!

@jmauerhan @kocsismate
If you need more help on this, ping me I can take over few classes too.

I would be very happy if you could help!
Any method that's not yet covered and implements more logic than returning/setting a value definitely needs more testing. But I have found errors when testing getters/setters so you can choose whatever you prefer to test. :)

@kocsismate Ok.
I was thinking to start with Negotiation/MessageValidator.php
I noticed that in lintMessage we have new JsonParser() which makes us hard to mock it.
Same in validateMessage  with new RefResolver and new Validator
Do you plan to use some DI or I should unit test this class as is now.

Yeah, not long ago I was thinking about this problem too, but finally I didn't change the current implementation because I considered those 3rd party classes as implementation details. I don't usually do this, but here I felt that it is much simpler to leave them as-is than introducing a level of indirection.
So I would prefer test it as is now. :)

The new JsonParser can be mocked with Mockery if it needs to be. I haven't had a chance to start adding any tests yet, but I'll do a small PR with some examples.


extension changelog page markdown display incorrectly

extension changelog page markdown display incorrectly in vs code after installed, but it display correctly in marketplace or github

VSCode Version:
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T15:04:31.999Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 3.13.0-157-generic

OS Version:

ubuntu 14.04 x64
win7 x64

Steps to Reproduce:

install extension lua-tags
switch to changelog page

the lua code block is display incorrectly
-- v is show as
local V -> X.Y = true

Oped https://github.com/markedjs/marked/issues/1592 to track root cause issue
If you are interested in fixing this, please look into contributing upstream


CreateContainerConfigError due to secret

Post deployment task errors due to CreateContainerConfigError with this event:
Error: couldn't find key SECURE_DATA in Secret default/deno-demo-secret

As far as I can see from this docs page, it looks like I'm using it correctly...
Step 1: Create secret that holds foo: bar
apiVersion: v1
kind: Secret
metadata:
  name: deno-demo-secret
  namespace: default
type: Opaque
data:
  foo: YmFyCg==

Step 2: Validate it exists
kubectl -n default get secrets

Step 3: Post deploy Job Fails
Name:             klc-post-deployment-hello-723-81089-rkjtf
Namespace:        default
Priority:         0
Service Account:  default
Node:             ************
Start Time:       Thu, 12 Jan 2023 04:17:11 +0000
Labels:           controller-uid=2aa67fa3-a622-40d8-8e55-fc21949c27fc
                  job-name=klc-post-deployment-hello-723-81089
Annotations:      <none>
Status:           Pending
IP:               *.*.*.*
IPs:
  IP:           *.*.*.*
Controlled By:  Job/klc-post-deployment-hello-723-81089
Containers:
  keptn-function-runner:
    Container ID:
    Image:          ghcr.io/keptn/functions-runtime:v0.4.1
    Image ID:
    Port:           <none>
    Host Port:      <none>
    State:          Waiting
      Reason:       CreateContainerConfigError
    Ready:          False
    Restart Count:  0
    Environment:
      DATA:         {"url":"https://********"}
      CONTEXT:      {"workloadName":"fib3r-app-fib3r","appName":"fib3r-app","appVersion":"","workloadVersion":"0.0.13","taskType":"","objectType":"Workload"}
      SECURE_DATA:  <set to the key 'SECURE_DATA' in secret 'deno-demo-secret'>  Optional: false
      SCRIPT:       /var/data/function.ts
    Mounts:
      /var/data/function.ts from function-mount (ro,path="code")
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-c6hnv (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             False
  ContainersReady   False
  PodScheduled      True
Volumes:
  function-mount:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      keptnfn-deployment-hello
    Optional:  false
  kube-api-access-c6hnv:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   BestEffort
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason     Age                From               Message
  ----     ------     ----               ----               -------
  Normal   Scheduled  15s                default-scheduler  Successfully assigned default/klc-post-deployment-hello-723-81089-rkjtf to ***
  Normal   Pulled     14s (x2 over 15s)  kubelet            Container image "ghcr.io/keptn/functions-runtime:v0.4.1" already present on machine
  Warning  Failed     14s (x2 over 15s)  kubelet            Error: couldn't find key SECURE_DATA in Secret default/deno-demo-secret

I'm not sure if this is the way things are designed (in which case the docs need to be re-written) or whether it is a bug but I got it working by replacing the key foo with SECRET_DATA:
apiVersion: v1
kind: Secret
metadata:
  name: deno-demo-secret
  namespace: default
type: Opaque
data:
  SECURE_DATA: YmFyCg==

Then:
apiVersion: lifecycle.keptn.sh/v1alpha1
kind: KeptnTaskDefinition
metadata:
  name: deployment-hello
  namespace: "default"
spec:
  function:
    secureParameters:
      secret: deno-demo-secret
    inline:
      code: |
        console.log("Deployment Hello Task has been executed");

        let foo = Deno.env.get('SECURE_DATA');
        console.log(foo);
        Deno.exit(0);

I'm leaving this open until one of the core team can comment on whether this is expected behaviour or not.

The behavior is intended, but I agree that the documentation was misleading in that case. I have addressed this in #959


Is there anyway to avoid 720p, but only start download when it's 1080p?

Hi, I've been using this thing about a half year now, and I noticed that
'when the stream starts, it begins with 720p, and then goes up to 1080p.'
It feels really bad when I finds my files were downloaded in 720p.
Even if I put the refresh rate on 5 minutes, there are some unlucky (or should I say I was extremely lucky that refresh timing and the beginning of streaming was on the exact time) moments.
So I'm wondering If there's anyway not to start downloading when the best output is 720p, make the program waits for a few moments, and then download when 1080p is available?
Thanks for your help in advance! I totally love this! It saves my live as an editor several times.

Weird, I haven't ever had that issue. Is "best" quality set in the config? Also did you try downloading the program again and reconfiguring it?

       # user configuration         self.username = config.username         self.quality = "best"
Yes it's definitely on "best" quality.
What I was wondering is that 'when the stream just started, the best output is at 720p for a few moments.' so, I know that the real 'best' output is always 1080p.
So maybe is there's any ways to make the program not starts downloading when it's at 720p, and make it wait until it re-recognize the available output is at 1080p?
I don't really think it's a matter of redownload and re-configure the program

If the value self.quality is fixed, the recording should only take place then.
self.quality = "1080p"
However, should the stream for some reason only take place in 720p or another resolution because, for example,
the resolution for a game was reduced, nothing is recorded.

So, I tested the program with the quality on "1080p"
Apparently, when the stream is available with 60fps, you have to write "1080p60"
So yeah, It worked! Thank  you so much!


[RHOAIENG-4859] Fix for showing correct models in project overview

Closes RHOAIENG-4859
Description
Fixes an issue where models from all projects are being shown in the models section of the overview page. The fix is to pass the project name to the models list rather than incorrectly using the current project namespace field.
How Has This Been Tested?
Manually tested and verified that models from other projects no longer show in the cards list.
Test Impact
None.
Request review criteria:
Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)

@jeff-phillips-18 please rebase

/lgtm
/approve
requires rebase

/lgtm


Power Shell Execution Policy Getting Altered To "Unrestricted"

With SystemInformation 5.9.4 we see that the PowerShell execution policy is getting Altered to "Unrestricted". This is the PowerShell command getting executed - "powershell.exe -NoLogo -InputFormat Text -NoExit -ExecutionPolicy Unrestricted -Command -"
When using SystemInformation 4.34.17, we did not see a similar behavior. Why is Systeminformation 5.9.4  requiring the policy to be altered to "Unrestricted". Why specifically does SystemInformation 5.9.4 require unrestricted policy - does it need unrestricted policy to run a certain script or get certain info?
We would like to get an understanding of why SystemInformation 5.9.4 requires the "Unrestricted" policy for security purposes? Thank you.

@Omair-Abdul Thank you for asking and reporting! I will check the situation - the reason for this was issues with some commands that I discovered. Will come back later when the situation is clear on my side.

Thank You @sebhildebrandt!

@Omair-Abdul ... I checked the code and my powershell implementation always had  -ExecutionPolicy Unrestricted (since it was introduced in September 2018). But anyway I do not really see a reason why this is necessary. I removed this flag and published a new version 5.11.4

@sebhildebrandt I am using a project (HomeBridge) that uses this library, and it took me what to find out this was the source of the "powershell.exe -NoLogo -InputFormat Text -NoExit -ExecutionPolicy Unrestricted -Command -" wat was showing up in my process list every 5 seconds or so.  Anyway, why was the -Execution Policy added back in?  I didn't see it mentioned in the changelog after the line for 5.11.4.  I took it back out on my local copy of the library and it seems fine.  The "Unrestricted" had me unnerved.


Exception when run the same sub-parser in different places.

What's the reason of this line?
throw new ParseException(i.Memos[p].ToString());
It broke my parser. When I changed it to
return (IResult<T>)i.Memos[p];
everything started work as expected.

Hi! We might need some more context - where's that line, and what is your parser doing? What's the exception look like? Cheers!

Hello.
This line is here:
https://github.com/sprache/Sprache/blob/a286cb382e1daeb721df94b3381bc78659dcda16/src/Sprache/Parse.cs#L391

I experienced the same error. My case was using Ref inside an Or like .Or(Parser.Ref(() => ...
This threw an exception along the lines of "Successful parsing of ".
Modifying the above line fixes the error (i.e. no longer throws exceptions on successful parsing).

Why was this closed? The above error has not been fixed?

This is what I had to do to allow all tests to pass (at the position @3da provided):
if (i.Memos.ContainsKey(p))
{
    var pResult = i.Memos[p] as IResult<T>;
    if (pResult.WasSuccessful)
        return pResult;
    throw new ParseException(pResult.ToString());
}

Great, thanks @r1sc - think I misread your reply above, when I closed this :+1:


Conditioning on y_cond

Hi, thanks for the awesome codes :)
One question for the inpainting task:
Looking at the following snippet from your code in networks.py, I cannot understand why you are conditioning your model on y_cond if you are already modifying your y_noisy based on the y_0 image using the expression "y_noisy*mask+(1.-mask)*y_0"?
Shouldn't concatenating with y_cond be redundant in this case? Your model is already seeing the ground truth parts of the image in the modified version of the y_noisy.
    def forward(self, y_0, y_cond=None, mask=None, noise=None):
        # sampling from p(gammas)
        b, *_ = y_0.shape
        t = torch.randint(1, self.num_timesteps, (b,), device=y_0.device).long()
        gamma_t1 = extract(self.gammas, t-1, x_shape=(1, 1))
        sqrt_gamma_t2 = extract(self.gammas, t, x_shape=(1, 1))
        sample_gammas = (sqrt_gamma_t2-gamma_t1) * torch.rand((b, 1), device=y_0.device) + gamma_t1
        sample_gammas = sample_gammas.view(b, -1)

        noise = default(noise, lambda: torch.randn_like(y_0))
        y_noisy = self.q_sample(
            y_0=y_0, sample_gammas=sample_gammas.view(-1, 1, 1, 1), noise=noise)

        if mask is not None:
            noise_hat = self.denoise_fn(torch.cat([y_cond, y_noisy*mask+(1.-mask)*y_0], dim=1), sample_gammas)
            loss = self.loss_fn(mask*noise, mask*noise_hat)
        else:
            noise_hat = self.denoise_fn(torch.cat([y_cond, y_noisy], dim=1), sample_gammas)
            loss = self.loss_fn(noise, noise_hat)
        return loss

Hi, thanks for this great question, and I think there are two potential considerations for this:

Keep the consistency between training and inference over all tasks. The model samples from random noise and y_cond in the inference stage.
y_cond can distinguish between the mask and unmasked areas since y_t may not be straightforward enough when t is small.

Hi, thanks for this great question, and I think there are two potential considerations for this:

Keep the consistency between training and inference over all tasks. The model samples from random noise and y_cond in the inference stage.
y_cond can distinguish between the mask and unmasked areas since y_t may not be straightforward enough when t is small.

Thanks for the kind reply. This makes sense, though it is worth trying the second reason. I will post here if I realized something different.

Feel free to reopen the issue if there is any question.

@PouriaRouzrokh I have opened a separate issue on it. But I am in urgent need of a solution, so I just wanted to check with you .
In my inpainting case, during the inference only the  y_cond and mask images are given. In that case, may I know  how to do a inference?
In the network.py script, for the inpainting task the below line will be executed as part of the restoration function. As y_0 is None for me, I am not sure how to deal with this line. If I skip the below line then the results are very bad (just only some whitish kind of image is generated). Also, in the Process.png image I can notice that for each step the noise level is increasing rather than decreasing.
if mask is not None:
    y_t = y_0*(1.-mask) + mask*y_t

Any idea on how to proceed?

In my inpainting case, during the inference only the  y_cond and mask images are given. In that case, may I know  how to do a inference?
In the network.py script, for the inpainting task the below line will be executed as part of the restoration function. As y_0 is None for me, I am not sure how to deal with this line. If I skip the below line then the results are very bad (just only some whitish kind of image is generated). Also, in the Process.png image I can notice that for each step the noise level is increasing rather than decreasing.
if mask is not None:
    y_t = y_0*(1.-mask) + mask*y_t

@Janspiry  Why not just set the mask as y_cond?  for consistency among all tasks?


Add gitter link in contribute page

Fixes #159

@armudgal plz review.

Hi, looks like there was some confusion. Duplicate of #160, please look through other issues. Thanks for the contribution


Bidirectional LSTM error

The following throw ValueError: All input arrays must have the same shape. when return_state=True on jax backend, but works fine on torch backend.
import os
os.environ["KERAS_BACKEND"] = "jax"
import keras
import jax
import jax.numpy as jnp
input = jnp.ones([10, 2])
keras.layers.Bidirectional(keras.layers.LSTM(4, return_sequences=True, return_state=True))(input[None])

Thanks for the report! There was in fact a bug in Bidirectional with return_state=True. I have fixed it at HEAD. Please check that it works for you.


Isolation problem ?

The template below is mostly useful for bug reports and support questions.
Feel free to remove anything which doesn't apply to you and add more information where it makes sense.
Required information

Distribution: Ubuntu
Distribution version: 17.04
driver: lxc
driver_version: 2.0.7
kernel: Linux
kernel_architecture: x86_64
kernel_version: 4.10.0-11-generic
server: lxd
server_pid: 3680
server_version: "2.11"
storage: zfs
storage_version: <IP_ADDRESS>-2

Issue description
0
down vote
favorite
I am playing with LXD containers, and fail to completely understand what is happening with isolation. Here is my scenario:
create a 16.04 container

$lxc launch ubuntu:16.04 mycontainer
install firefox within it
$lxc exec mycontainer /bin/bash
$apt install firefox
create a user with the same name as my main system user
$adduser myuser
ssh-copy-id to that user
$ vi /etc/sshd_config to allow ssh with password, then from main session ssh-copy-id myuser@mycontainer-ip
ssh -X into the container and launch firefox
$ ssh -X myuser@mycontainer-ip and $firefox
If I have no Firefox opened in my main session, an isolated Firefox pops up: no access to my main session files, no plugin, etc...
But, if Firefox is already running in my main session, launching FF from my ssh -X session in the container opens another FF window that is not isolated and runs as my main user (with my plugins, access to files, etc...).
What is happening ?

I've not used firefox in a long time, but I believe they have code to find and interact with an existing firefox through X properties.
Since you pass "-X", your container has access to your X server and so can query/set X properties, list all running windows, ... which is most likely how firefox detects an existing firefox session and has it open a new window rather than spawn a new process.
I'd expect there to be a command line option to firefox to have it not do that.

  --no-remote        Do not accept or send remote commands; implies
                     --new-instance.


Add ClusterSecretStore resource

Closes https://github.com/external-secrets/external-secrets/issues/7
Moved to multi-group and broke meta out into its group.

Hi @mcavoyk, thanks for the PR ✨
I a question regarding the changes, just to understand the why of things (I'm not too much experienced with kubebuilder heh)

Why do we need to use a multigroup project? AFAIK it only changes the file structure, but I believe this project is simple enough to maintain everything inside one api/<version> folder. Even though we have a meta type package, it's also quite simple. Are there any big benefits for this?
Also, if we indeed break it into a multigroup project, should we also break apart the controllers folder?

Thanks mate!

Hi @mcavoyk, thanks for the PR ✨
I a question regarding the changes, just to understand the why of things (I'm not too much experienced with kubebuilder heh)

Why do we need to use a multigroup project? AFAIK it only changes the file structure, but I believe this project is simple enough to maintain everything inside one api/<version> folder. Even though we have a meta type package, it's also quite simple. Are there any big benefits for this?
Also, if we indeed break it into a multigroup project, should we also break apart the controllers folder?

Thanks mate!

Why do we need to use a multigroup project? AFAIK it only changes the file structure, but I believe this project is simple enough to maintain everything inside one api/<version> folder. Even though we have a meta type package, it's also quite simple. Are there any big benefits for this?

ExternalSecrets may be able to be maintained in a single api, but I find its a bit more robust/forward-compatible to use multi-group layout now that it has support in kubebuilder. Single group is the default for backward compatibility reasons is my understanding.

Also, if we indeed break it into a multigroup project, should we also break apart the controllers folder?

Yeah my recommendation would be to have a SecretStore controller which reconciles for SecretStore and ClusterSecretStore resources, and a separate ExternalSecret controller, with those split out between pkg/controllers/secretstore and pkg/controllers/externalsecret

Why do we need to use a multigroup project? AFAIK it only changes the file structure, but I believe this project is simple enough to maintain everything inside one api/<version> folder. Even though we have a meta type package, it's also quite simple. Are there any big benefits for this?

ExternalSecrets may be able to be maintained in a single api, but I find its a bit more robust/forward-compatible to use multi-group layout now that it has support in kubebuilder. Single group is the default for backward compatibility reasons is my understanding.

Also, if we indeed break it into a multigroup project, should we also break apart the controllers folder?

Yeah my recommendation would be to have a SecretStore controller which reconciles for SecretStore and ClusterSecretStore resources, and a separate ExternalSecret controller, with those split out between pkg/controllers/secretstore and pkg/controllers/externalsecret

Thanks for your reply @mcavoyk!
Before we merge, could you separate the controllers into their respective group folders as well?
Thanks!

Thanks for your reply @mcavoyk!
Before we merge, could you separate the controllers into their respective group folders as well?
Thanks!


use observable to display new chirrup from the front end

for the post-new-chirrup service, our original design is to first, post it in the back-end using a service, and notify the chirrup-list to re-fetch new data get from backend. So we don’t include any data, only need to inform subscribers that this event has happened. But this will have some latency if we always fetch data from backend.

another way of doing this is to just emit the new chirrup and chirrup-list will listen to it and add it to the chirrups we get from the backend and stored in the front-end when initialized. The benefit of doing so is that change is immediately reflected in the view.

the difference between void and undefine:

Observable:The subscribers to this observable are only interested in the fact that an event occurred.
Observable / : used on situations where an expected value is missing or, deliberately been set to a clear state.

I am not using this shared service anymore


[TASK-5] Create components for authentication screens

What happened
Create components for authentication screens - Feature Card
Insight

[x] Background Layout
[x] Logo
[x] Logo sub text
[x] Input text
[x] Button
[x] Alert

Proof Of Work
CI should pass with test codes.

Fails

:no_entry_sign:

🃏 FAIL in index.test.js

renders label with props

     Email

Full message

Error: Unable to find an element by: [data-testid="input-label-test"]

          Email

    at Object.getElementError (/home/runner/work/surveyor/surveyor/node_modules/@testing-library/dom/dist/config.js:34:12)
    at /home/runner/work/surveyor/surveyor/node_modules/@testing-library/dom/dist/query-helpers.js:71:38
    at getByTestId (/home/runner/work/surveyor/surveyor/node_modules/@testing-library/dom/dist/query-helpers.js:54:17)
    at Object. (/home/runner/work/surveyor/surveyor/src/tests/components/Auth/InputText/index.test.js:22:31)
    at Object.asyncJestTest (/home/runner/work/surveyor/surveyor/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/runner/work/surveyor/surveyor/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/runner/work/surveyor/surveyor/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/runner/work/surveyor/surveyor/node_modules/jest-jasmine2/build/queueRunner.js:73:41

  Generated by :no_entry_sign: dangerJS against c036f82627ae4939cef6d0f5b112eb928bed03dd

@rafayet-monon I'm just curious about how you divide authentication screen into small components like input and button. Can you explain more about the benefit of separating them into small components instead of having just one form component ? 🙌

@rafayet-monon I'm just curious about how you divide authentication screen into small components like input and button. Can you explain more about the benefit of separating them into small components instead of having just one form component ? 🙌

@carryall The benefit I will get is, I can use them in every auth screens. i.e. Login screen, Forgot password screen, Reset password screen.


Perform boundary checks before searching to prevent security vulnerabilities

The current str.find doesn't perform boundary checks, which can lead to a crash or even security issues.
A simple way to reproduce this bug: "hello".find('lo', -100000)
Instead, -1 should be returned in this case.

Does cpython return -1 for this case?

Oh it doesn't. But CPython doesn't actually try to access that memory.

Not correct. cpython treat start and end as slice arguments. So -1 means the last char not 0.
However, we don't want to make this complicated. The optimal fix is to raise a ValueError.

Yeah you are right.

Thank you for your work :)


Hand-in

[x] Make sure everything is re-read twice
[x] Prepare a zip containing: the report, a separate document containing a PDF of the reflection
[x] Hand in to www.eksamen.ruc.dk

@kimmeyera ❤ 🎉 🥳 🎆 🍾 🍻


App crasing while opening character files

MCDSaveEdit crashes without warning when I open .dat file
Here is my .dat file
F4D940AE49F7D25350CA5B87F33D0126.dat.zip
You need to delete the ".zip" at the end of the filename.

It seems to open and work just fine with MCDSaveEdit <IP_ADDRESS>. Let me know if this is still an issue.


Add explicit .NET Standard 2.0 support

Description
Having .NET Standard 1.3 in the list of target frameworks: https://github.com/vers-one/EpubReader/blob/32e60dfdab027d8ebaf63c92bca9adbef2470cbf/Source/VersOne.Epub/VersOne.Epub.csproj#L3 lets the library to be used in projects targeting some older frameworks (e.g. .NET Core 1.0). However, this also leads to an excessive list of unnecessary package dependencies when the library is imported in a project targeting a newer framework (e.g. .NET 6):
Microsoft.NETCore.Platforms.1.1.0
Microsoft.NETCore.Targets.1.1.0
runtime.native.System.4.3.0
runtime.native.System.IO.Compression.4.3.0
System.Buffers.4.3.0
System.Collections.4.3.0
System.Diagnostics.Debug.4.3.0
System.Diagnostics.Tracing.4.3.0
System.Globalization.4.3.0
System.IO.4.3.0
System.IO.Compression.4.3.0
System.Reflection.4.3.0
System.Reflection.Primitives.4.3.0
System.Resources.ResourceManager.4.3.0
System.Runtime.4.3.0
System.Runtime.Extensions.4.3.0
System.Runtime.Handles.4.3.0
System.Runtime.InteropServices.4.3.0
System.Text.Encoding.4.3.0
System.Threading.4.3.0
System.Threading.Tasks.4.3.0

Proposed solution
Adding an explicit .NET Standard 2.0 support should prevent unnecessary package dependencies.
Additional context
From https://docs.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-1-3#which-net-standard-version-to-target:

If you need to support .NET Standard 1.x, we recommend that you also target .NET Standard 2.0. .NET Standard 1.x is distributed as a granular set of NuGet packages, which creates a large package dependency graph and results in developers downloading a lot of packages when building.

Implemented in PR #52.


missing tags

your missing tags from items in 1.16.2 and its refusing to create worlds cause of this

I need some actual information- world creation works fine under normal conditions.
Logs? Actual messages? How were you trying to make a world that failed? Which Crossroads version are you using? Where are you getting 'missing tags from items' from?

I'm closing this because there was so little information given, I can't even tell if they actually experienced a bug. I've also not reproduced any bug meeting this description.


How to select Exchange other than default while using RabbitMQ as broker?

#Issue:
I am using RabbitMQ as message-broker and want to send data through multiple devices. I am able to send data to a specific routing key (Queue) but it must be bind with default "Exchange". I want to send data to "Exchange" of my choice. I am able to select routing key/ queue through

client.connect("khan", mqtt_user, mqtt_pass)

and

client.publish("khan",jsonStr,2);

but I am unable to find any method to select an exchange.
I have also studied PubSub client documemtation but could not get any useful information in this regard.
I am using
ESP32 using Arduino IDE
Broker: RabbitMQ
#include <WiFi.h>
#include <PubSubClient.h>
#include <ArduinoJson.h>

const char* ssid = "XXXXXXXX";
const char* password = "XXXXXXXX";
const char* mqtt_server = "XXX.XX.X.XX";
const char* mqtt_user = "XXXX";
const char* mqtt_pass= "XXXX";
//Stream str[15];
unsigned int x;

WiFiClient espClient;
PubSubClient client(espClient);

void callback(char* topic, byte* payload, unsigned int length) {
  // delay(1000);
  Serial.print("Message arrived [");
  Serial.print(topic);
  Serial.print("] ");
  Serial.println();

  //Publish the updated payload
  //client.publish("mq2_mqtt", "My Message from CB",true);

}

void setup_wifi()
{
  // Connecting to a WiFi network
  WiFi.begin(ssid, password);
  while (WiFi.status() != WL_CONNECTED) {
    delay(500);
    Serial.print(".");
  }
  Serial.println("WiFi connected");
  Serial.println("IP address: ");
  Serial.println(WiFi.localIP());
  //client.beginPublish("khan",x,true);
}

void reconnect()
{
  // Loop until we're reconnected
  Serial.println("In reconnect...");
  while (!client.connected()) {
    Serial.print("Attempting MQTT connection...");
    // Attempt to connect
    if (client.connect("khan", mqtt_user, mqtt_pass))
    {
      Serial.println("connected");
    }
    else
    {
      Serial.print("failed, rc=");
      Serial.print(client.state());
      Serial.println(" try again in 5 seconds");
      delay(5000);
    }
  }
}

void setup()
{
  x=60;
  Serial.begin(115200);
  setup_wifi();
  client.setServer(mqtt_server, 1883);
  //client.beginPublish("khan",x,true);
  //client.subscribe("khan");

}

void loop()
{
  if (!client.connected()) {
    reconnect();
  }
  client.loop();

  delay(5000);
  DynamicJsonDocument doc(1024);
  JsonObject obj=doc.as<JsonObject>();
  float temp=25.05;
  //float humid=dht.readHumidity();
  doc["Temp"]= temp;
  //doc["Humid"]= humid;
  char jsonStr[60];
  serializeJson(doc,jsonStr);
  Serial.print(jsonStr);
  Serial.println();
  client.publish("khan",jsonStr,2);
  delay(100);

}

There is no concept of an 'exchange' in mqtt - that is specific to RabbitMQ. You'll have to check their documentation on how to do what you want with a plain mqtt client, rather than a RabbitMQ client. I have never used rabbit, so cannot help.


add env var TRAIN_BATCH_SIZE for training flexibility

Environment variable TRAIN_BATCH_SIZE setting for fine-tuning job, default to 1

Setting it to "1" and not a placeholder variable like "V_TRAIN_BATCH_SIZE" is going to make it difficult to programmatically change.

Trying to keep it 1 and always working, but in the docs guide is this fun'ness
-i -e "/TRAIN_BATCH_SIZE/{n;s/1/${TRAIN_BATCH_SIZE}/}" \

I think for consistency we should just use the placeholder variable. In the README you can set TRAIN_BATCH_SIZE=1 and add a -i -e "s|V_TRAIN_BATCH_SIZE|${TRAIN_BATCH_SIZE}|" \

sure, np, trying to make it hands off unless you explicitly want to change it, but it's in the table so we should be good.


Remove contact method page from parental consent

At the moment the service won't be able to honour this if set.
This also removes the form page and validation, since they're easy to re-add, but leaves the db field in case we want to populate it another way at some point.

I'm in two minds about this; if we were to rip everything out, we should also remove stuff like Consent#parent_contact_method_other. An alternative could be to feature flag this and roll forward to complete the feature in future – the feature flag will remind us that it's incomplete.

Yeah, maybe let’s feature flag it. Make it off by default to save us the admin of going in and updating the envs.


tune down the max multi-get limit to 50

Description
Limit the max multi-get return number. This helps reduce the load on system for each request and risk of resources starvation.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Nvm, please update this to 50 as well
https://github.com/MystenLabs/sui/blob/main/crates/sui-indexer/src/handlers/checkpoint_handler.rs#L51


patch sc93.1 display name

I was about to make a comment in https://sagebionetworks.jira.com/jira/servicedesk/projects/NFOSI/queues/custom/7/NFOSI-25 that the term should be available, but then I noticed the slight capitalization difference in the display name, which I missed in my review of #90, my bad.
If this change looks good to you I'll push it to the data curator app today!

Good catch! I need to turn annoying autocaps off or actually use a code editor.


Add non-carrier Note9 model number

This works fine on carrier Note9 firmwares, but not on phones flashed with the U1 firmware.

The string for the verified boot key that it gets matched against also needs to be updated to include this model.

I haven't gone through all the samples and dealt with them all for a while so we're very behind on device support right now.

I'm not sure how to get the part in AttestationProtocol.java but I submitted a sample for you to have a look when you can.

Not going to have time to expand device support for the foreseeable future, unfortunately. Need someone to help with making tooling to make it easier and to help with adding the devices with it. Can't add this without testing.


build(release): add schedule

This will release on a weekly schedule all changes or on-demand fixes.

Coverage remained the same at 100.0% when pulling 297ee768aace86138ff1cf381205e504a23b9616 on build-release-add-schedule into 1576651d7f8de9f07e22deedb944b6755e14e074 on main.

Resolves #78

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


⚠ File access (beta) has degraded performance

In 99fe8cc, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 4263 ms

Resolved: File access (beta) performance has improved in b233572 after 8 minutes.


Hi, @lukewrites! Thanks for opening this PR!

In the file tdvt/tdvt/tdvt.py:

Line 443:121: E501 line too long (178 > 120 characters)

For reference: Error Code Reference, PEP8, Python code style


Turned into the correct shape of directory separator

if set value with slash for --model option, repository which created have syntax error !
php artisan make:repository name  --m=Models/ModelName --imp
replace \ and / with Directory Separator

u must use model directory in string format like --m='\Models\ModelName'


Rework of CI-related commits

See individual commit messages

@gmarull @nvlsianpu see https://projecttools.nordicsemi.no/confluence/display/NCS/Upmerges#Upmerges-Outoftreepatches