Tests failing on latest SDK

https://travis-ci.org/dart-lang/dart2_fix/builds/410955962
Are things broken on SDKs w/out the old constants, @devoncarew ?

...right. And set the SDK constraint and the travis config accordingly?
On Thu, Aug 2, 2018 at 6:23 AM Devon Carew<EMAIL_ADDRESS>wrote:

Yes, looking at this:

we don't try and update code with analysis errors
we key off the places in code where the analysis server reports
deprecation messages

Removing the deprecated constants from the SDK breaks both of those
assumptions. We should update the docs for this tool to state that it can
only be run on an sdk after the depreciations were introduced, and before
the constants were removed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/dart2_fix/issues/40#issuecomment-409924318,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCivLfYzsXBIU87aUTUvxh_WY7LGvCks5uMv08gaJpZM4VrjAa
.


Add Focuses belt

A Trinket item, which could reuse code from the Assortment pouch, for storing and picking focuses without having to have them in your inventory directly

 Add Focuses belt


Outline collapse element on focus

Updated CSS for a minor Accessibility improvement. When navigating a colllapsible nav using a keyboard, the arrow SVG should be outlined on focus

I'll merge this now, but since it's such a small change, I wouldn't be inclined to package up a new release just for this one.
I'd suggest we plan to release 5.3.3 once Bootstrap 5.3 lands, so we can also include #42.
@jason-fox Does that sound like the right approach, or do you need this released before DITA-OT Day next week?

No rush for anything.


"fetcher is not a function" - React

Description
After having wired up my React JSS to my Sitecore instance, I tried fetching data from it like the documentation said but I encountered an error "TypeError: fetcher is not a function" within node_modules/@sitecore-jss/sitecore-jss/dist/dataApi.js:90.
Expected behavior
Feteching datas from my Sitecore instance.
Steps To Reproduce
Nothing more than a default HelloWorld React app made with
jss create my-first-jss-app react

Then I added a basic React class component and added the very same lines (different token though) as the documentation within a componentDidMount function.
Your Environment

Sitecore Version: 9.0.1
JSS Version: 11.0.2
Browser Name and version: Chrome 75.0.3770.100 (Build officiel) (64 bits)
Operating System and version (desktop or mobile): MS Windows Server 2016 (10.0.14393)

The React default fetcher is defined here and then passed into the layout data api here. The fetcher allows you to customize the library used to make HTTP calls to Sitecore.
It sounds like your fetcher is null or not a function in the RouteHandler.js.

Am I supposed to implement it on my side?

No, it should be wired up out of the box and work fine. But that is the mechanism you seem to be having trouble with so I'm trying to point you to the right places to be troubleshooting the problem.

I checked that my setup provides the same code as you pointed me to and it does
I tried reinstalling my node_modules but the error is still there

It seems like the dataApi.js file is expecting me to provide a fetcher attribute inside the fetchOptions object described in the documentation page linked above, however it doesn't speaks about it

@MikyStar  This issue was described by merging #306. If you feel that additional information is needed, feel free to reopen this issue or create a new one.


Update README.md

Fixed indentation of bullets with GFM.
Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions.

Description of the Change
Documentation update

Alternate Designs
It's just docs.

Why should this be in core?
README is more readable on GitHub.

Benefits
README is more readable on GitHub.

Possible Drawbacks
README might be less readable with some other flavor of Markdown. Who knows?

Applicable issues
n/a

Coverage increased (+0.05%) to 89.927% when pulling e37239684a369ecbd5575f76b9a4667b25540624 on leedm777:patch-1 into 1bb6b3977a482c144a61d68ea2e499b22a7db01b on mochajs:master.

appveyor only fail on node4 , it's weird.

Thanks, good catch! The CI failures really shouldn't happen at all considering this only changes documentation; going to ignore them and merge this.


Add autoflush property to HBaseClient

Add autoflush property to HBaseClient. It enables to turn on or off auto flush flag of HTable.

We should try to make the configuration of this behavior common between the 1.0 and pre-1.0 clients.
The relationship between HTable.autoflush in pre-1.0 and BufferedMutator in 1.0 is explained in the client section of the hbase reference guide.
It looks like right now the 1.0 binding uses a property called "clientBuffering". Can we do the same in the older api? They should also probably both default to not doing client buffering.

OK, I renamed the property to clientbuffering, the same name as that of the 1.0 client, and changed their default value to false.

Thanks for the improvement!


read how web works repo

https://github.com/vasanthk/how-web-works

that's a good one it will help us a lot


Update authorization.md

Added description of how to add the needed details for a permission.

Codecov Report

Merging #192 (78d2f0d) into main (cf81de9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   69.33%   69.33%
=======================================
  Files         179      179
  Lines        3248     3248
  Branches      412      412
=======================================
  Hits         2252     2252
  Misses        863      863
  Partials      133      133

Flag
Coverage Δ

appcommon
58.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Keyboard Remapper By Specific Device

Currently the Keyboard Remapper feature only allows remapping keys for all attached keyboards. I would value a feature that remapped keys from only a specific keyboard. This would have uses for gaming, CAD, OBS and other media/mixing, MIDI uses, macro keyboards for common strings, and so forth.
There are many times I'd like to have a global keyboard shortcut to actuate something in OBS, for example, so I can't use per-app mapping. However, it seems every reasonable keyboard shortcut is used by some app or the other, leaving only the crazy shortcuts like Ctrl-Alt-Shift-Win-P and the like, which I'd much rather remap to a single button on a second keyboard or number pad.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

See https://github.com/microsoft/PowerToys/issues/1460

See https://github.com/microsoft/PowerToys/issues/1460


Remove get_db of engine_traits::Snapshot

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
I want to remove type parameter KvEngine for  engine_trait::Snapshot, because too many type parameters will make our program more complex, and I hope to implement  KvEngine for different kind of WriteBatch.
Related changes
Check List
Tests

No code

/tests

/merge


Add unselected option to select widget when no default is set

- Summary
Add a "not selected" option to the select widget when there is no default set. Closes #562.

- Test plan
Tested manually.

- Description for the changelog
Add unselected option to select widget when no default is set.

- A picture of a cute animal (not mandatory but encouraged)

@tech4him1, @erquhart this is finished and r2r.


running ejected expo app within xcode is broken

Running metro run:ios successfully ejects/generates xcode project files and runs successfully outside of xcode. Inside however, metro paths become incorrect.
I believe it's related to this issue https://github.com/facebook/metro/issues/605. My guess is that react-native and workspaces do not get along.
Any advice on getting it to run without expo-go on a device would be greatly appreciated.

Try out rnx-kit: https://github.com/microsoft/rnx-kit

I don't like expo too.


open variants are unsupported

Hi
  type knownEvents('a) = ..;

  type knownEvents('a) +=
    | Session(([< | `start | `endSession] as 'a));
  [@genType]
  let dispatch = e =>
    switch (e) {
    | Session(name) => Js.log(name)
    | _ => ()
    };

output
var Session = Caml_exceptions.create("D.Session");

function dispatch(e) {
  if (e.RE_EXN_ID === Session) {
    console.log(e._1);
    return ;
  }

}

dispatch({
      RE_EXN_ID: Session,
      _1: "start"
    });

/* TypeScript file generated from D.re by genType. */
/* eslint-disable import/first */

// tslint:disable-next-line:no-var-requires
const DBS = require('./D.bs');

export const dispatch: (e:knownEvents<"endSession" | "start">) => void = DBS.dispatch;

https://github.com/rescript-lang/rescript-compiler/issues/4634

@Coobaha extensible variants such as knownEvents are kind of niche, rarely used.
I have not completely understood the rationale for making them available to JS.
Also, I'm not sure how one would reconcile the fact that the types have different definitions at different places, when they appear e.g. in multiple exported functions where they are extended in different ways.


Fix "cache component" link in README

Currently "cache component" link leads to 404. It's "wik" instead of "wiki".

thank


Update package requirements for CDI branch?

I was building the cdi branch using the selectWMSelevation branch of terriajs, but now it's been merged into master: https://github.com/TerriaJS/terriajs/commit/a86f74f30370f2e41418176e1e7a57c01c71a7c3
So I changed my TerriaMap cdi branch package.json from
    "terriajs": "git://github.com/TerriaJS/terriajs#selectWmsElevation",

to
    "terriajs": "git://github.com/TerriaJS/terriajs",

but after building, something is clearly wrong:

I'm thinking that there are more package updates required than just this line?
https://github.com/TerriaJS/TerriaMap/blob/cdi/package.json#L58

@rsignell-usgs I believe we resolve this today (it turned out to be an npm problem; removing node_modules and reinstalling fixed it), so I'm closing it.

Indeed, we fixed it thusly:
* edit package.json to use master
* run npm install
* run gulp sync-terriajs-dependencies
* rm -rf node_modules
* npm install
* gulp


gzip: implements WriteHeader

This patch fixed #23

@streadway
This PR has been staying for a while, please let me know if any changes are needed.


Include service ID with Virtual Machines

Issue type
[X ] Feature request
[] Bug report
[ ] Documentation
Environment

Python version: 2.7
NetBox version: v2.2-beta1

Description
I'm running 2.2beta and I'm trying to pull out virtual machine information from the API. I would like a service id included as part of the return from a virtual-machines API request.
When I submit this request:
curl 'http://localhost/api/virtualization/virtual-machines/16/'
I get the following results:
{"id"=>16, "name"=>"db-b", "status"=>{"value"=>1, "label"=>"Active"}, "cluster"=>{"id"=>1, "url"=>"http://localhost/api/virtualization/clusters/1/", "name"=>"KVMSQL1"}, "tenant"=>nil, "platform"=>{"id"=>2, "url"=>"http://localhost/api/dcim/platforms/2/", "name"=>"Centos", "slug"=>"centos"}, "primary_ip4"=>3, "primary_ip6"=>nil, "comments"=>"", "custom_fields"=>{}}
From these results there is no mention of the existing service that is attached to this virtual machine:

As with devices, services aren't included in the API representation of a virtual machine: you'll need to retrieve and filter those via the services endpoint:
GET /api/ipam/services/?virtual_machine_id=123
However, we are missing the filter to accomplish this. I'll add it.

Fixed in 0ea58ab


soundd: use common sig handler

This timeout was always getting hit with soundd since it didn't send a response signal upon Ctrl+C'ing manager (the cloudlog.info(f"killing {self.name} with SIGKILL") branch). Shutdown is now fast! No effect on falling edge of ignition as soundd is never usually killed
https://github.com/commaai/openpilot/blob/758a9d7c24e4736dd94cfbab127ab1414b3423a0/selfdrive/manager/process.py#L132-L149

Hmm, it's still hanging when running many times in a row


Add contribution docs on adding component configuration options

I noticed yesterday that, although we've seemingly settled on a method of adding configuration options (including localisation strings) to components, we had only documented how to use the ones we added from an end user's perspective.
Here's some scratchy documentation on how to add new configuration options and guidelines for naming them.

We should still re-visit this, it's useful
But will need to catch up with:

https://github.com/alphagov/govuk-frontend/pull/3771
https://github.com/alphagov/govuk-frontend/pull/3820
https://github.com/alphagov/govuk-frontend/pull/4011

@querkmachine I've given it a rapid work-in-progress refresh, something along these lines?

@romaricpascal Just a double check over my quick edits?
Aware that lots of the examples given will fail due to missing JSDoc though, should we include it?
Will also need a big update once we fix how components set up their options after https://github.com/alphagov/govuk-frontend/issues/4230

@romaricpascal It's been a while so I'm definitely not sure of how accurate parts of it are at this point, but better to have something that we can iterate upon rather than sitting on it for much longer.

Going to merge this on the basis that having something to iterate upon is probably better than letting this languish and grow outdated again.


Impossible to apply styles to XAxis/YAxis component 'ticks'.

Hello! First off, let me say: nice work with React Vis. It is an excellent library and have served me well.
There is just one teeny, tiny problem:
Currently, the Axis component, as well as the XAxis and YAxis components both accept a style object as a prop.
The style object is comprised of several objects that are applied to different elements within the axis. It currently accepts root styles, line, title and ticks.
The problem lies with the ticks object. The name implies that it will style the ticks element - i.e. the container of all the ticks that the axis contains.
Unfortunately, however, the 'ticks' style object is applied to every tick within the container, and not the container itself.
Looking further into the code, I noticed that no prop styles are applied to the container:
Path: react-vis/src/plot/axis/axis-ticks.js:
return (
      <g
        transform={`translate(${x}, ${y})`}
        className="rv-xy-plot__axis__ticks"
      >
        {ticks}
      </g>
    );

As a result, the only way to style the above <g> element is via an external stylesheet. In cases where CSS-in-JS is exclusively used in a given project, this can be cumbersome to deal with.
I propose that the ability to pass an additional style object to the Axis component to style the ticks container is implemented.
I would have suggested that the style object be called ticks and what is currently ticks be renamed to tick, but I appreciate that would cause back-compatibility issues. Perhaps ticksContainer would be apt?
Thanks!

Styling  elements is not possible. Styles you apply to it will be appended to all child elements, so that would just get the same result as how it is now.
See an example here https://codepen.io/anon/pen/dLXyLx?&editable=true


Handle metadata (rough)

If no metadata found, start new
If metadata found, load last imageset and append new run to the existing imageset

@afflom @estroz Notes here from our discussion. Will have a metadata file (stat file) that maintains all pertinent information instead of a managed data directory. The data will be ephemeral instead and the metadata will track a history of what is on the disconnected side. This will be passed to the Archiver to determine what to pack. Sound right?


French localization

Add French localization, courtesy of brother Nadim Sohail, may Allah
reward him greatly!

Deployed to: http://staging.quran.com:32773

+1 on @naveed-ahmad

Deployed to: http://staging.quran.com:32781

rebuild

Deployed to: http://staging.quran.com:32782

@mmahalwy ready for merge

jazakAllah khairan for the fixes i missed

Thanks for merging! :)


note for issue #308

note for issue #308 for C-ABI Trampoline Code comment 12

issue #308 was closed with pull #344.


Worker only on a specific path (not using a subdomain)

I'm hoping someone here has done this which is to use Notion to host a page for a specific path.
For example
website.com is currently hosted on an S3 bucket (Static HTML)
website.com/blog should be the Notion Page
The Fruition configuration builder doesn't seem to have this configuration parameter and assumes it's either a subdomain or the full domain.
Has anyone customized the configuration for this kind of use case?

Same issue here. I have being playing around for 3 hours to setup /blog instead of blog. without much luck 😅


Add NO_WCHAR_T build option to CMake

Some usage scenarios build the library with /Zc:wchar_t- but mix both unsigned short* and wchar_t* client usage. For this opt-in build scenario, the library will link with both the non-native and native wchar_t.

Also fixes some Code Analysis warnings as you can't use _In_opt_ with std::function<>.

Note that after completing this one, I'll need to make sure the same adapter is in place for the Xbox extensions.


which brand and reference of smd oven you use in your project?

Dear @dekuNukem
which brand and reference of smd oven you use in your project?
Best Regards,
Youssef

I used a T962 oven from ebay. It is a very popular and low-cost model from china, and seems to work well enough for my projects with 63-37 leaded solder paste.


Fix show the detail in lua table array part

In lua, we need to use both indexed and named filter which to get the detail of table

This looks like it requests all variables using the paged api which is explicitly not supported by this client and is broadcast to the adapter with supportsVariablePaging: False. If you want to support paging you should add support for it not request all variables using filters and paged requests.
What adapter are you trying to support? This adapter is off spec and should be fixed on the adapter side

Here is the relevant parts of the protocol.
  /**
   * Filter to limit the child variables to either named or indexed. If omitted,
   * both types are fetched.
   * Values: 'indexed', 'named'
   */
  filter?: 'indexed' | 'named';

  /**
   * The index of the first variable to return; if omitted children start at 0.
   * The attribute is only honored by a debug adapter if the corresponding
   * capability `supportsVariablePaging` is true.
   */
  start?: number;

  /**
   * The number of variables to return. If count is missing or 0, all variables
   * are returned.
   * The attribute is only honored by a debug adapter if the corresponding
   * capability `supportsVariablePaging` is true.
   */
  count?: number;

All these values can be omitted.


add isinscope; add Trans; add yml; add demoTransport

All tests pass, but still working on demoTransport
To do:
generalisation of Branch and Bound
Make use of pgmpy varaible elimination

manage to replicate demoTransport (see the plots)


fix "''resp' referenced before assignment"

(this occurs on both 1.20 and master, I presuming fixing in master is best)
What do these changes do?
I'm getting an error
Traceback (most recent call last):
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp/web_server.py", line 61, in handle_request
    resp = yield from self._handler(request)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp/web.py", line 249, in _handle
    resp = yield from handler(request)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/middlewares.py", line 59, in toolbar_middleware
    toolbar = DebugToolbar(request, panel_classes, global_panel_classes)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/toolbar.py", line 30, in __init__
    panel_inst = panel_class(request)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/panels/routes.py", line 21, in __init__
    self.populate(request)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp_debugtoolbar/panels/routes.py", line 33, in populate
    "source": inspect.getsource(route.handler)
  File "/usr/lib/python3.5/inspect.py", line 944, in getsource
    lines, lnum = getsourcelines(object)
  File "/usr/lib/python3.5/inspect.py", line 936, in getsourcelines
    return getblock(lines[lnum:]), lnum + 1
  File "/usr/lib/python3.5/inspect.py", line 916, in getblock
    for _token in tokens:
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/tokenize.py", line 550, in _tokenize
    elif line[pos] == '\t':
KeyboardInterrupt

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp/server.py", line 261, in start
    yield from self.handle_request(message, payload)
  File "/home/samuel/code/purge_cloudflare/env/lib/python3.5/site-packages/aiohttp/web_server.py", line 88, in handle_request
    resp._task = None
UnboundLocalError: local variable 'resp' referenced before assignment

I think the KeyboardInterrupt is caused by aiohttp-devtools trying to restart the app in the middle of a request.
Are there changes in behavior for the user?
Only if they were getting an error similar to above.
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[ ] Documentation reflects the changes
[x] Add yourself to CONTRIBUTORS.txt

The format is <Name> <Surname>.
Please keep alphabetical order, the file is sorted by names.

[ ] Add a new entry to CHANGES.rst

Choose any open position to avoid merge conflicts with other PRs.
Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

Current coverage is 98.91% (diff: 100%)

Merging #1527 into master will not change coverage

@@             master      #1527   diff @@
==========================================
  Files            30         30
  Lines          6987       6987
  Methods           0          0
  Messages          0          0
  Branches       1162       1162
==========================================
  Hits           6911       6911
  Misses           37         37
  Partials         39         39

Powered by Codecov. Last update 0e7ea65...d6afa8d

i am not sure about BaseException
i think line 88 is wrong place for sexting _task to None

@asvetlov we should move resp._task = None to place where we actually set it

@asvetlov what was the reason for _task in first place?

fixed in master?
@asvetlov WTF resp._task?


docker build error

https://hub.docker.com/r/binux/pyspider/builds/bfw3eukrqxtsbxyltueat48/
Build failed: The command '/bin/sh -c pip install http://cdn.mysql.com//Downloads/Connector-Python/mysql-connector-python-2.1.3.zip#md5=710479afc4f7895207c8f96f91eb5385' returned a non-zero code: 1
have no idea to fix this, maybe change it to another address?

Thanks for report, error: option --single-version-externally-managed not recognized needs a newer version of setuptools, will upgrade it soon

fixed via 0d0c9d68913f9feba86739034bb57e3eb7c6f829


Better formula for leap.

Makes more sense to take 3% of the users mass instead of almost all of it.

*Almost a quarter of it.


Add onFulfill and Alias onResolve

Since v6.x is using the Promise spec terminology, I think we should add onFulfill callback to take the place of onResolve. Since v6.x has already been released, onResolve can be an alias or fallback if onFulfill is not present. Or both callbacks could be called if present.
Thoughts?

Technically, resolve and reject are the names of the Promise executor callbacks, so I think onResolve makes sense. This is exactly what confused me most about the Promise spec. A promise can resolve with either a value, causing it to become fulfilled, or with another Promise, causing it to continue executing that Promise.
Needless to say, in this case onResolve will always fulfill, because we don't pass it a Promise.

Okay. That makes sense. Resolving is the action that takes the promise to the fulfilled state. It could resolve to a synchronous value or to an asynchronous value via a new Promise which will eventually get fulfilled with a synchronous value. And likewise, rejecting is the action that takes the promise to the rejected state.
As I was responding, I thought of something and I'd like to throw it out as another suggestion. You probably have already thought of it and I am not sure if there is a strong need or desire for it but I wonder if an onStatusChange or onStateChange callback would be useful. It can go along with the new status API. I can open another issue if specific to it if you want and maybe gather feedback from the community.
Thanks again for the well-thought out library.
(I hope you are not getting tired of all the suggestions from the community.)

I haven't considered a state change callback yet, but I have considered adopting the state reducer pattern. Let's open a new issue to discuss if this makes sense.
I'm really happy with the feedback I'm getting now. Sure I've thought about many of these things but it never hurts to reconsider or look at things from another angle. Going back and forth a couple times helps iron out the rough edges. The whole status thing actually originated from a colleague who wanted state-specific types in TypeScript in order to avoid optional types. I never felt the need for it myself because I'm not using TypeScript in my current projects.
Please keep the feedback coming.

Closing since the reasoning behind name choice is very sound.


soc: espressif: Simple boot validity

Fix the condition which defines the simple boot validity.

@carlescufi  can you ptal?


Getting started steps

Hi!
I was working with the examine_synthetic_data notebook to get started, and I wanted to clarify/point out a few things that could potentially be improved:

The guide does not mention it seems to work only for linux (or unix/osx) given the use of environment variables (not bad, but maybe good to clarify)
Perhaps also mention that you need to supply environment variables: $PROJECT_DIR, $PYTHON_PATH
The first line in build_dataset.py points to a default Python location, which is not what most people would be using if they use virtual environments. It could also be a mistake on my end.

Perhaps consider splitting up the Jupyter Notebook (and the read the docs) into a tutorial with multiple parts and/or making the file a little less verbose, which could help users get started. This might especially help interdisciplinary folks. I was a bit overwhelmed, and it made getting started daunting. I could also help you once I get more familiar with the pipeline.
The package looks great so far, and it is clear you have put a lot of thought into everything :).

Thanks for the recommendations @rvandewater, definitely good ideas! Not sure of the timeline on fixing these, but they are good suggestions for sure.


betaWeb Fix undefined index 'table' on getFrom method

Fix  PHP Notice:  Undefined index: table in /var/www/html/listeBio/vendor/jstayton/miner/src/Miner.php on line 916 error on getFrom method.

@betaWeb I'm very sorry for never responding to you here. As my silence likely hinted, I stopped maintaining this project long ago. I'm now officially deprecating it to make that clear.
If you'd like to continue supporting a forked version, please reach out on Twitter (@kidjustino) to have it listed in the README.


FEA Add interpolation join

For now it is implemented with pandas. I have a polars version that I can integrate once #733 is merged. It is fairly straightforward to implement with the current specification of the dataframe api, but it seems polars and pandas implement an older specification

InterpolationJoin is a generalization of Joiner. Should we expose both methods

I think that we should expose the two methods. "InterpolationJoin" is further away to a join then the typical definition in DB (if there are only exact matched, Joiner boils down to a standard join).

should Joiner inherit from InterpolationJoin?

I would say: only if it simplifies the codebase.

I think that we should expose the two methods. "InterpolationJoin" is further away to a join then the typical definition in DB (if there are only exact matches, Joiner boils down to a standard join).

Oh right, I see the nuance now, you couldn't reproduce Joiner results based on InterpolateJoiner directly. How could we make this simpler for the user though? I'm not super comfortable with exposing these two transformers because it creates complexity.

I would say: only if it simplifies the codebase.

With Jerome's implementation, it could be worth making a POC of Joiner using InterpolateJoiner. My intuition is that we can make the codebase of Joiner simpler while keeping the same logic. WDYT?

The errors seem unrelated to this PR; rather, I have the impression that numpydoc is choking on non-ascii characters in the SimilarityEncoder's docstring (“”) on Windows

The errors seem unrelated to this PR; rather, I have the impression that numpydoc is choking on non-ascii characters in the SimilarityEncoder's docstring (“”) on Windows

You can now rebase on main to remove this error.

as we don't have a consensus on Join vs Joiner (vs  :Joine.), shall I rename it InterpolationJoiner for now?

You have a docstring error on your estimator:
 - GL03: Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings

in both cases the prediction is at chance level (probably because I kept very few features from the flights dataset). it makes the example run slower.

That's not good. We do not want unconvincing examples.
On that specific dataset, I have in mind that the spatial join was helpful in the example that we had. Am I wrong?

On that specific dataset, I have in mind that the spatial join was helpful in the example that we had. Am I wrong?

ok let me rerun it on the full dataset with all features then

One thing we haven't discussed is what to do when fitting or querying an estimator raises an exception. This can happen for a variety of reasons we may not be able to fully anticipate, as the user is allowed to choose the estimators. I added a on_estimator_failure parameter which can be "warn" (default) "raise" or "pass" and has the meaning described here . LMK if that seems reasonable or if you would like it handled some other way

I also wonder if for this one it would make sense to use the min hash rather than gap encoder in the TableVectorizer. I have in mind min hash works well with decision trees (thus the default predictors we use here) and is faster. But I don't have much experience using either. WDYT?

One thing we haven't discussed is what to do when fitting or querying an estimator raises an exception. This can happen for a variety of reasons we may not be able to fully anticipate, as the user is allowed to choose the estimators. I added a on_estimator_failure parameter which can be "warn" (default) "raise" or "pass" and has the meaning described here .

That's interesting and important.
I think that we should consider a "skrub.set_config" setting for this.

I probably missed some discussions; why choose the MinHashEncoder as default?

Ah yes sorry, we talked about it in yesterday's meeting. As the default estimator is the gradient boosting, minhash might be a good choice because it is faster than GAPEncoder and is supposed to work well with models based on decision trees. So we decided to use it for now. We could always change it if we see that it performs worse on some example datasets. I don't have much experience using minhash nor the gap encoder so I don't really have an opinion.

We need to address @jovan-stojanovic's remark before merging this PR

We need to address @jovan-stojanovic's remark before merging this PR

I agree but I'm not sure what we decided in the end?

Let's fix the conflict and merge then :)

I also changed the way default sub-estimators are managed to be consistent with TableVectorizer and #814 , ie the default is now an estimator instead of None. This makes the parameter list a bit more scary in the doc :D but probably not a big deal

see also this note

but maybe I should use the default DatetimeEncoder, WDYT? I figured it might be a bit surprising that the closest date representations do not correspond to the closest dates, but maybe it's not important for the InterpolationJoiner and users who want a more predictable behavior would just use the Joiner

but maybe I should use the default DatetimeEncoder, WDYT?

I changed it to use the default DatetimeEncoder, now the only TableVectorizer parameter we set is the high cardinality transformer (to use the hashing vectorizer)
I guess users can always override datetime encoding (as is done in one of the tests) with
InterpolationJoiner(aux, key="key").set_params(vectorizer__datetime_transformer__resolution=None)

although the fact that you can't set it in __init__ but only with set_params and that it's 2 levels of sub-estimator deep + the set_params double underscore syntax makes it unlikely that they will ...

Merging, thank you @jeromedockes!


[Issue #73] Don't render attribute on nil value

Since https://github.com/msaraiva/surface/pull/80 seems to have been under construction for more than 2 months with no recent updates I propose a similar solution in this PR with fixed tests.

Hey @edgarmiadzieles!
Thanks so much for this PR. I need to ask you to put this on hold since we're about to replace the current translator with a new compiler. Unfortunately, the changes in this PR will not work with the new changes. The good news is that the new model provides a much more consistent way for handling this kind of features. The work is already being reviewed and should be merged anytime today. In case you still want to contribute and add this feature after we merge the compiler, please let me know, I'll be glad to give you some directions so you can implement it using the new model.
Cheers.

Hey @edgarmiadzieles!
Thanks so much for this PR. I need to ask you to put this on hold since we're about to replace the current translator with a new compiler. Unfortunately, the changes in this PR will not work with the new changes. The good news is that the new model provides a much more consistent way for handling this kind of features. The work is already being reviewed and should be merged anytime today. In case you still want to contribute and add this feature after we merge the compiler, please let me know, I'll be glad to give you some directions so you can implement it using the new model.
Cheers.

Thanks for the feedback @msaraiva . I would definitely like to see this feature in the near future so I will definitely take a look at the changes and try to implement this in the new codebase.


Error: Invalid connection info

Description of the problem
I downloaded new server files (Development) and now while connection I receive this
[16:33:43][Error] Error: Invalid connection info
I updated client as well.
Reproduction steps

Start server in dev mode
Start client in dev mode (debug: true)
Connect to the server

Expected behaviour
Successful connection as it used to be, receiving connection info
Additional context
---- > server.cfg
name: 'alt:V Server'
host: <IP_ADDRESS>
port: 7788
players: 10
#password: ultra-password
announce: false
debug: true
gamemode: Freeroam
website: example.com
language: en
description: 'alt:V Sample Server'
modules: ['js-module', 'csharp-module']
resources: ['chat', 'BetterNoClip', 'my_gamemode']
deps: []
---- > alt.cfg
branch: 'dev'
crashReporterEnabled: 'true'
debug: 'true'
earlyAuthTestURL: ''
gtapath: 'C:\GAMES\Grand Theft Auto V'
lang: 'en'
lastip: '<IP_ADDRESS>:7788'
name: 'admin'
netgraph: 'true'
promotedOnTop: 'false'
streamerMode: 'false'
useExternalConsole: 'false'
voiceActivationEnabled: 'false'
voiceActivationKey: '78'
voiceAutoInputVolume: 'true'
voiceEnabled: 'true'
voiceInputSensitivity: '20'
voiceInputVolume: '100'
voiceNoiseSuppression: 'true'
voiceVolume: '100'
Operating system
Windows 10
Version
altmp/altv-issues#10.0-DEV16

Are you using the connection queue or beforePlayerConnect event? And if yes, show the code how you use it

Are you using the connection queue or beforePlayerConnect event? And if yes, show the code how you use it

Sorry for a mistake. Ofc I use alt.on('beforePlayerConnect', player_connecting);

Show that function

Please close the topic.
The issue was how I used it in timeout with 0 delay but it was too late to receive data.


x/tools/cmd/gorename: using '.' as -from package causes panic

Don't know if using a '.' as the -from package is supposed to be legal but I ran into a panic doing so.
$ cd $GOPATH/src/foo
$ ls
hello.go
$ cat hello.go
package main

func sayHello() {
}

func main() {
}
$ gorename -from '".".sayHello' -to 'sayGoodbye'
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x4a6812]

goroutine 1 [running]:
golang.org/x/tools/refactor/rename.findObjects(0x0, 0xc8200aea10, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/eric/src/golang.org/x/tools/refactor/rename/spec.go:419 +0x352
golang.org/x/tools/refactor/rename.findFromObjects(0xc82001a800, 0xc8200aea10, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/eric/src/golang.org/x/tools/refactor/rename/spec.go:292 +0x1ed
golang.org/x/tools/refactor/rename.Main(0x88bd00, 0x0, 0x0, 0x7ffeacf52f39, 0xc, 0x7ffeacf52f4a, 0xa, 0x0, 0x0)
	/home/eric/src/golang.org/x/tools/refactor/rename/rename.go:253 +0x625
main.main()
	/home/eric/src/golang.org/x/tools/cmd/gorename/main.go:49 +0x337

This is using the latest checkout of golang/tools.

I think the command shouldn't crash and I would consider this a bug.

It looks like the loader is loading the package just fine, but findFromObjects does map lookup using the package name "." here producing a nil *loader.PackageInfo

Fixed by https://go-review.googlesource.com/#/c/18453


LeadTwo chevron

Draw also second car indicator from LeadTwo Data

@pd0wm
do you really want
if ((scene->lead_status2) &&(fabs(scene->lead_d_rel - scene->lead_d_rel2)>0.1)||(fabs(scene->lead_y_rel - scene->lead_y_rel2)>0.1))) {
as condition?

@pd0wm
do you really want
if ((scene->lead_status2) &&(fabs(scene->lead_d_rel - scene->lead_d_rel2)>0.1)||(fabs(scene->lead_y_rel - scene->lead_y_rel2)>0.1))) {
as condition?

There needs to be some check that they are different otherwise might be a lot of almost overlapping chevrons. Could also just do distance maybe (fabs(scene->lead_d_rel - scene->lead_d_rel2)>3)


Layout: main class

The current usage:
<main role="main" class="container">

Remove "container" class
I would not recommend using bootstrap's container class on the root node of page content. Suggesting to nest it inside the <main> tag:
<main role="main">
    <div class="container">
    </div>
</main>

Remove role="main"
There is a great tool for HTML5 proper markup validation. When uploaded our index.html we get a following error:
Warning: Element `main` does not need a `role` attribute.

I think this is because there can be only one <main> tag in the whole document. ARIA specification attributes were provided before roles were natively supported by HTML5.
Usage of HTML5 markup should be supported, since it is not even a new feature as for 2016.

It should be also discussed whether we really need to nest div class="container"> inside <main>.
What about instances when nested content has fluid container? Maybe it is better to define container in each block macro extension?

This depends on project. IMHO this is quite easy task and we don’t need to show best practice here.

@janpanschab then I will create a pull request with the changes I currently have.


[BUG] - Error using isVirtualized prop in Select Component with VirtualizedListbox

NextUI Version
2.6.8
Describe the bug
When using the isVirtualized prop in the Select component, the VirtualizedListbox fails to access the properties of the selectors, resulting in the following error

Your Example Website or App
https://stackblitz.com/edit/vitejs-vite-ttgk5xfz?file=src%2FSelectAvatarDecoration.tsx
Steps to Reproduce the Bug or Issue

Use the Select component with the isVirtualized prop enabled (isVirtualized={true})
Attempt to interact with the component
Observe the error in the console

Expected behavior
The Select component should work correctly with the isVirtualized property enabled, without throwing any errors and displaying the elements.
Screenshots or Videos
https://github.com/user-attachments/assets/9e802ba6-d52a-46b8-b859-9bf805c7c88e
Operating System Version
Windows
Browser
Chrome

Thank you for reporting the issue. I am taking a look at this!

+1


[Script]: Guided ChatBOt

Aim
They guide you about the exam preperation and meaning of taking the exam
Details
Just use the Open AI apI or may be prompt Engineering
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

/assign


arXiv links normalization and HTML detection

PDF links should normalize to abs links:

HTML links are not detected:

HTML links should also be normalized to abs links

Updated the regex to https?:\/\/arxiv\.org\/(abs|pdf|html)\/(?<id>[0-9.]+(v[0-9]+)?) to address html case.

Need to fix on frontend to take the link @swh00tw


Collect use cases for custom groupings

Some questions that people might want to answer:

how do my custom group of CCGs as a whole compare to national trends?
how do my combined custom group of practices compare to the CCG as a whole and to the country as a whole?
I want to see how all of the practices in my custom group of CCGs compare against each other

@HelenCEBM @alexwalkercebm @richiecroker @brianmackenna Please add to this list!

I want to download headline figures for every practice in the grouping
I want to download deciles computed at practice level nationally for comparison

Are we talking about measures pages and analyse pages?

here is an email from a CCG about it:

option to create groups of CCGs or practices to look at the overall indicators and opportunities.  We contract with our practices via a LIS to deliver Meds Op (allowing them to employ pharmacists) and within that we expect them to reduce variation; I think openPrescribing would be a useful tool for them to use to identify their group opportunities and be alerted to new/emerging areas.

i'm a big CCG split into 2 areas, 3 localities, and a shared team across one locality with another CCG.  I also have a number of GP federations within that.  I want to be able to use OpenPrescribing as if any of these groups were like a CCG.

@HelenCEBM that's a good question. I think we'd been thinking mainly about measures pages, but longer term it should be both.
@richiecroker in your use cases, let's focus on a locality - are you mainly wanting to compare individual measures on the 3 localities? (e.g. on a single measure page, seeing the three localities?)
On a single locality page you'll want to see all measures I guess; but is it also important to be able to see the measures with both variation by locality within  your CCG? etc etc. (I'm interested in the most useful ways of slicing the data, rather than all the possible ones)
Important to get alerts for each locality? What would that mean? Because "compared with other localities" doesn't mean a lot when there are only 3 localities.
Data download: for each practice in each locality? Something else? etc

Custom groupings
So I'm a GP federation (with 15 practices) and I want to look at individual measures. I select the measure and I expect to see my 15 practice side by side with the national average. I'm picturing a bar graph with a red line across for national median.
Not sure is this the right place for it but new groupings that are already defined
So I'm NHS England London Region team. I want

See how the 33 London CCGs are "performing" at a CCG level (perhaps bar graph)
See how my region compares to other NHS England regions (As there are 4 regions this could be similar to All England page but with 4 red lines?)

So I'm a STP CEO

See how the 5  CCGs are "performing" at a CCG level
See how my region compares to other STPs

@sebbacon the problem with big CCGs' data is that they obscure variation within areas of that CCG.  So, focusing on the one locality issue - I'd want to isolate all the practices in that locality and compare measures.  I hadn't thought about seeing three localities on one page - is that a possibility, to have multiple things (e.g. CCGs) on one measures page (like we can on analyse)?
In general, i'd say locality performance against national

E-Mail alert for STPs/Regions will probably be very different to our normal alerting system. Example alert
Example of stuff to include in a regional email/dashboard
In the last month/quarter £xxxx was spent on medicines which NHS England say are low priority. This is a change of x% compared with the last quarter.
Insert barchart of spend comparing CCGs
There were xxxx amount of PPU Savings
Insert barchart of spend comparing CCGs
Drug Tariff Watch (subject to new feature)
In London there was an unexpected spend of xx due to NCSO in August and this is predicted to be xxx in October.

New GP contract announcements include the direction that practices must form networks and importantly those networks will employ staff. Therefore this staff group (including pharmacists) will want to see their data! It looks like there will be approximately 1000 networks across the country.
I imagine at some point there will be an official list but prior to that it would be advantageous to have custom groupings so people locally can create the network on OP.

It seems that AHSNs don't necessarily overlap with STPs or NHSE regions and so they may want a different group of CCGs

We have internally discussed the idea of dymamic, rules-based groupings that update each month.
e.g. (all made up by me, may be clinically meaningless!)

Top 10 practices with demographics most like mine
All practices using EMIS
All practices with a prison setting
All practices within the GL5 postcode area
Top quartile of practices prescribing antipsychotics per 1000 patients

Recent CCG mergers have prompted an email which could be solved with custom organisation groupings

I have seen that the SELCCG merger has taken effect on the search - this is a problem for me as I use your search tool to compare the 5 GP practices with nursing homes to other Lambeth GP practices, but this now very difficult to do as SELCCG contains a huge number of practices over a large geographical area with very different populations.
Is it possible to reinstate the ability to search by South East London borough please?

This is still true with "place"


Can't consistently use x-functions-key and x-functions-clientid headers instead of query string parameters

Use of the x-functions-key and x-functions-clientid headers seems temperamental
Repro steps

Create a generic webhook function

Create two new keys, a function key called client1 and an admin key called admin2

Verify that the function can be called using /api/MyWebhook?clientid=client1&code=client1code

Verify that the function can be called using /api/MyWebhook?clientid=admin1&code=admin1code

Now try to do the same thing using the x-functions-key and x-functions-clientid headers

Expected behavior
The function can be called successfully using headers instead of query string parameters
Actual behavior
A message is received saying "The WebHook verification request must contain a 'code' query parameter"
Known workarounds
It is possible to use just the master key in x-functions-key.
It is also possible to use the code query string and the x-functions-clientid header together
If the function type is a HTTP Trigger rather than a webhook, you can use the admin1 keys in x-functions-key and specifying x-functions-clientid seems not to be necessary

@mathewc - could we handle this in the generic WebHook case?

Yes this is an issue with WebHooks only currently - they don't support the x-functions-key header. This is because the code query parameter is pulled from the request not by us, but by the underlying WebHooks library we're using (e.g. code here).
Some options for us would be to clone the request and inject the param from the header before dispatch, or to find a way to wrap the receiver so we can intercept and override.


Add few sites.

Checkio :- Online Python game.
CodeEval :- General Coding challenges.

Interesting sites! Thanks @prabhath6 :)

No problem @hkasera


[Functional] Prohibit self-transfer

I can send XDAG to myself. This should be prohibit. This should be filtering by XDAG-Pro before submit to network.

As the logic of giving the transfer itself is valid. Also RPC supports this, so the client should not disable this.
In this case, I will warn the user in red font in the panel before the transaction. Or I will add a text warning later.

👍


Evaluate Banshee anomaly detection

When collecting metrics from services that are being proxied, it would be nice to do anomaly detection to catch problems.
One possible tool to look in to: https://github.com/eleme/banshee

great idea, let's also investigate:
https://www.elastic.co/blog/implementing-a-statistical-anomaly-detector-part-1
https://elastalert.readthedocs.io/en/latest/elastalert.html
https://prometheus.io/blog/2015/06/18/practical-anomaly-detection/


[Bug] Do not look for bindings in property paths that are not dynamic

Description
Today, we search for dynamic bindings in property paths that aren't supposed to be dynamic.

fixed with #2537

fixed with #2537


I completed any step that give us but its not working

Please if someone get this problem I need help

Hey Msani02,
the compiled code for the Browser is in the dist directory, not in src.
Ideally the the dist directory is the root of your webserver or vhost.
Regards Valentin


cli: make create-github-app available and deprecate backend:build-image

Some CLI housekeeping. The backend:bundle command has been around for a long time now and seen widespread use, so confident in deprecating the old backend:build-image command.
The create-github-app command has been around for a long time now, although hidden in the CLI help it's been documented and has likely seen use too, although afaik we don't have any clear feedback on it. If we want to rename it I feel we should do that now, and otherwise just ship as is.

Should the create-app template be updated? Probably k8s docs, FAQ that reference build-imagetoo 🤔


New Extension: DevToys

Description
A Swiss Army knife for developer.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @tuanpham-dev. Did you notice this extension DevUtils in the store?

Hi @koinzhang - Yes I did. However that extension opens paid external tools, while my extension leverages Raycast Form UI to do the job.

What about this extension ToolBox?


add try catch and attempt to grab specifically the json

This fixes #3750. There are edge cases that we weren't handling for parsing the tests. This adds a try-catch as well as attempts to pull out the json from any output that came from before the json object.
@benschreiber FYI.

Already approved, only a merge conflict. Merging.


Incomplete implementation of dictset.__getattr__

https://github.com/ramses-tech/nefertari/blob/master/nefertari/utils/dictset.py#L29 fails when request for non-existent attribute is done.
In some situation the problem may be hidden by using simplejson with installed speedups.
PR https://github.com/ramses-tech/nefertari/pull/143 resolves the problem.

hey @vlcinsky thanks for the PR!
can you provide some steps to reproduce this?

Is https://github.com/ramses-tech/ramses-example/issues/59 sufficient?

Missed that. Did you install following these steps inside a virtualenv?

Yes, to manage virtualenvs I use tox from which I request installation of packages listed in requirements.txt. Tested for Python 2.7.12 and 3.5.2 on Ubuntu 16.04.

Simple test is:
>>> from nefertari.utils.dictset import dictset
>>> dset = dictset({"a": 11, "b": 22})
>>> dset["a"]
11
>>> dset["b"]
22
>>> dset.a
11
>>> dset.b
22
>>> dset.c
KeyError                                  Traceback (most recent call last)
<ipython-input-10-08661f5a730b> in <module>()
----> 1 getattr(dset, "c", None)

/home/javl/devel/kamelot/kamelot-api/.tox/py27/local/lib/python2.7/site-packages/nefertari/utils/dictset.pyc in __getattr__(self, key)
     28
     29     def __getattr__(self, key):
---> 30         return self[key]
     31
     32     def __setattr__(self, key, val):
KeyError: 'c'
>>> getattr(dset, "a", None)
11
>>> getattr(dset, "b", None)
22
>>> getattr(dset, "c", None)
KeyError                                  Traceback (most recent call last)
<ipython-input-10-08661f5a730b> in <module>()
----> 1 getattr(dset, "c", None)

/home/javl/devel/kamelot/kamelot-api/.tox/py27/local/lib/python2.7/site-packages/nefertari/utils/dictset.pyc in __getattr__(self, key)
     28
     29     def __getattr__(self, key):
---> 30         return self[key]
     31
     32     def __setattr__(self, key, val):
KeyError: 'c'

Note the last error: asking for value of non-existent attribute using getattr shall not fail with KeyError, but shall provide the default value.


Please help, the distutils is required

Before submitting a bug report...

[X] This bug wasn't already reported.
(I have checked every bug report on GitHub)

Title

[X] The title is no longer "[BUG] Title" and I edited it with the right error name.

Describe the bug
it says it requires distutils, i also did the requirement pip install but it didnt, i also tried pip install distutils but doesnt work aswell. i need help. as you can see the screenshot i sent
Copy and paste your error

Screenshots

Value of dashboard variable
idk whats this

Use Python 3.11. distutils was removed in 3.12

Use Python 3.11. distutils was removed in 3.12

or you can install setuptools?

Use Python 3.11. distutils was removed in 3.12

or you can install setuptools?

idk why but after installing setuptools bot is not working it is stuck on "Writing Password" earlier it was stuck after completing 3 desktop searches


[13:21:42][DBG] Switching identity to UID='0' and GID='0' (username: root).
[13:21:42][INF] File /etc/sysrepo/data/ietf-yang-library.running.lock is already locked by this session
[13:21:42][DBG] Switching identity to UID='0' and GID='0' (username: root).
[13:21:42][INF] File /etc/sysrepo/data/nc-notifications.running.lock locked by other process
[13:21:42][DBG] Switching identity to UID='0' and GID='0' (username: root).
[13:21:42][INF] File /etc/sysrepo/data/nc-notifications.running.lock is already locked by this session
[13:21:42][DBG] Switching identity to UID='0' and GID='0' (username: root).
[13:21:42][DBG] Timestamp for the model gwtt-device matches, ops will be skipped
[13:21:42][DBG] Usage count gwtt-device incremented (value=4)
[13:21:42][DBG] Loaded module gwtt-device: mtime sec=1579411287 nsec=0

Hi,
whatever performance problems you have with the old sysrepo (version 0.7.x) you must put up with, its development is finished. You should use the new sysrepo by now (latest release 1.4.2 or current devel 1.4.7) which have significantly improved the performance (up to 500x faster based on benchmarks).
Regards,
Michal

The following line is setting ipsec.
[13:21:40][INF] Set item request candidate datastore, xpath: /gwtt-ietf-ipsec:ipsec/proposal/ipsec-proposal[name='IpsecProposal_1']

Hi Michal:
thanks for your reply.

Now  use sysrepo1.4.2,Netopeer2-1.1.7 to set .


[PQL Deprecation] Do not compile PQL broker request for SQL query

Description
Remove the step of converting PinotQuery to BrokerRequest for SQL query compilation.
Also modify the tests and tools to not access the BrokerRequest fields for SQL query.

Codecov Report

Merging #6855 (57d9162) into master (043172c) will decrease coverage by 8.02%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #6855      +/-   ##
============================================
- Coverage     73.83%   65.81%   -8.03%
  Complexity       12       12
============================================
  Files          1424     1424
  Lines         69678    69689      +11
  Branches      10086    10088       +2
============================================
- Hits          51450    45865    -5585
- Misses        14824    20544    +5720
+ Partials       3404     3280     -124

Flag
Coverage Δ
Complexity Δ

integration
?
?

unittests
65.81% <77.77%> (-0.02%)
12.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043172c...57d9162. Read the comment docs.


The GetFileSize and GetFileSizeAsync functions always return 0

FTP Server OS: Any
FTP Server Type: Any
Client Computer OS: Windows
FluentFTP Version: 46.0.2
Framework: .NET 6
The GetFileSize and GetFileSizeAsync functions always return 0.  Since the progress reporting uses these functions to determine file sizes, it can not report progress properly.  If these are too difficult to implement, can we just use the file size of the FtpResult or FtpListItem passed to the download functions?  Perhaps we add a TotalFileSize (or ExpectedFileSize) to the FtpProgress class and use that to pass the knownFileSize to DownloadFileToFileAsync?  (If the FtpProgress.WhateverTheNewPropertyIs turns out to be zero when passed to the DownloadFileToFileAsync function, then do the expensive call to GetFileSize) It would be nice to have the expected file size in the progress reports anyway.

		/// <summary>
		/// Perform server-specific file size fetching commands here.
		/// Return the file size in bytes.
		/// </summary>
		public virtual long GetFileSize(FtpClient client, string path) {
			return 0;
		}

		/// <summary>
		/// Perform server-specific file size fetching commands here.
		/// Return the file size in bytes.
		/// </summary>
		public virtual Task<long> GetFileSizeAsync(AsyncFtpClient client, string path, CancellationToken token) {
			return Task.FromResult(0L);
		}

The GetFileSize and GetFileSizeAsync functions always return 0

A very bold statement.
First of all, show a log that "proves" your statement, please.
For me, progress works fine.
Second, show your code that corresponds to the log of the failure. Maybe you are doing something wrong.
So always is not true.
Therefore, "sometimes might be better?
Beyond that, the code snippet you show belongs to the BaseClient. Search some more for GetFileSize and you will see...
		public virtual long GetFileSize(string path, long defaultValue = -1) {
			// verify args
			if (path.IsBlank()) {
				throw new ArgumentException("Required parameter is null or blank.", nameof(path));
			}

			path = path.GetFtpPath();

			LogFunction(nameof(GetFileSize), new object[] { path });

			// execute server-specific file size fetching logic, if any
			if (ServerHandler != null && ServerHandler.IsCustomFileSize()) {
				return ServerHandler.GetFileSize(this, path);
			}

			if (!HasFeature(FtpCapability.SIZE)) {
				return defaultValue;
			}

			var sizeReply = new FtpSizeReply();
			lock (m_lock) {
				GetFileSizeInternal(path, sizeReply, defaultValue);
			}
			return sizeReply.FileSize;
		}

Add the full FTP logs. Check the logging section how to do that.

Seems to have resolved itself by itself :-)


CONTRIBUTING: Document restriction regarding jQuery event alias methods

Refs #19192.
CC: @hnrch02 @patrickhlauke

:+1:

And perhaps in https://github.com/twbs/bootstrap/blob/ad5e6565cc854e7d36aa5875cd93a387f01b143a/js/tests/index.html#L11-L48 we should set them to canary methods that throw an informative error instead of being undefined.


Vertical lines to show connection between nodes

Hi. Is it possible to make a tree which contains vertical lines connected between nodes with the current implementation?
F.e. add some flag to toggle the structure of items from renderProps  to the "nested tree" type. Every item will have a childNodes property ?
 [
  {
    "index": 0,
    "parent": "",
    "level": 0,
    "key": "1",
    ....otherInjectedProps
  },
  {
    "index": 1,
    "parent": "",
    "level": 0,
    "key": "2",
      ....otherInjectedProps
  },
  {
    "index": 1,
    "parent": "2",
    "level": 1,
    "key": "2/7",
      ....otherInjectedProps
  },
  {
    "index": 2,
    "parent": "",
    "level": 0,
    "key": "4",
  }
]

to
[
  {
    "index": 0,
    "parent": "",
    "level": 0,
    "key": "1",
    ....otherInjectedProps
  },
  {
    "index": 1,
    "parent": "",
    "level": 0,
    "key": "2",
    childNodes: [
       {
         "index": 1,
         "parent": "2",
         "level": 1,
         "key": "2/7",
         ....otherInjectedProps
       }
   ],
      ....otherInjectedProps
  },

  {
    "index": 2,
    "parent": "",
    "level": 0,
    "key": "4",
  }
]

And than use some sort of component recursion
const TreeItem = ({data}) => (

    {data && data.map(item => (

        {item.label}
        {item.childNodes && <TreeItem data={item.childNodes} />}

    ))}

);

Hello, I'm not sure if I understand your question. This library flattens your data into one-level array, and provide props like level and parent for you to know how to style the component. You can add your custom styling to show the relationship among all the nodes with all the given props.
Are you suggesting keeping the nesting structure and get rid of the flattening?

@iannbing Hi. F.e. my case. I would like to have something like:

item

       Item 2

 // horizontal line with setting border here

item 3

item 4

      </ul

instead of calculating padding/margins for every separate node:

.......more elements

With current implementation I have to convert flattened data to treeData one more time:
 <TreeMenu data={treeData} debounceTime={125}>
      {({ items }) => {
          const treeList = arrayToTree(items, { id: 'key', parentId: 'parent', dataField: null, childrenField: 'childNodes' });
          return <TreeView.Items data={treeList} />;
      }}
 </TreeMenu>

@iannbing  And another problem is difficulties with collapse/expand animations. Flattened items from render-props doesn't include child nodes of parent elements that is not opened. Their appearance in items is controlled by calling 'toggleNode' func that produces changing of 'children' property ,f.e., in some custom TreeViewItem component.  If TreeViewItem component renders child nodes in animated container it will cause a problem: how to determine the range of height to animate ?,  animation is started running on changing of isOpen property(need to call toggleNode func), but in the same time  'children' is disappeared/appeared even if animation is already started. It produces a flash effect .
Is it possible to  to keep even not opened nodes in 'items' ? I can't see any disadvantages of this.

What you have said about the flattened ul structure is correct. That's the trade-off I made when I designed this component. What I wanted to achieve is simplicity and flexibility. User of this library can manipulate items as much as they want, just like what you've achieved there.
With regards to hiding the collapsed children instead of removing them, I prefer clean DOM structure over hiding elements using CSS. A possible solution is to provide a customToggleNode prop that allows you to customize the behavior, e.g. add a delay.
Something like this:
<TreeMenu
    data={treeData}
    customToggleNode={toggleNode => {
        triggerAnimation();
        setTimeout(toggleNode, 250);
    }}
/>

What do you think?

@iannbing  It will not force users to hide childNodes using css.  U can print childNodes in DOM only if parent is opened. It is just an implementation. My suggestion is to inject  in item a boolean  property which will mean: "this item must not be visible for this time". Call of 'toggleNode'  on the parent component will not cause unmounting of childNodes, because their creation is depends ONLY on the fact their data representation is included into items array. I can create a sandbox with a problem related to this.
Duration will be  useful  for delay-based animations. But ,f.e., react-spring use 'spring physics' . As I understood, time of collapsing/expanding  is depends on the count on nodes => the occupied height. F.e." expanding" of 3 nodes and 40 nodes can not take the same time. So, there is no way to calculate delay.


Bug: Require additional Root Management Group permissions

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform: hashicorp/setup-terraform@v2
azure provider:

registry.terraform.io/Azure/caf-enterprise-scale/azurerm 4.2.0
Finding hashicorp/time versions matching ">= 0.7.0"...
Finding hashicorp/random versions matching ">= 3.1.0"...
Finding azure/azapi versions matching ">= 1.3.0"...
Finding hashicorp/azurerm versions matching ">= 3.0.0, >= 3.54.0"...
Installing hashicorp/time v0.9.1...
Installed hashicorp/time v0.9.1 (signed by HashiCorp)
Installing hashicorp/random v3.5.1...
Installed hashicorp/random v3.5.1 (signed by HashiCorp)
Installing azure/azapi v1.10.0...
Installed azure/azapi v1.10.0 (signed by a HashiCorp partner, key ID 6F0B91BDE98478CF)
Installing hashicorp/azurerm v3.81.0...
Installed hashicorp/azurerm v3.81.0 (signed by HashiCorp)

module: 0.0.7
Description
Describe the bug
Received the permission error below when deploying to GitHub.
│ Error: authorization.RoleAssignmentsClient#Create: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client '265b04b7-8db1-49e1-849a-688a74515809' with object id '265b04b7-8db1-49e1-849a-688a74515809' does not have authorization to perform action 'Microsoft.Authorization/roleAssignments/write' over scope '/providers/Microsoft.Management/managementGroups/3a54772d-fb8a-4d83-888a-fc2073fdfed7/providers/Microsoft.Authorization/roleAssignments/8cef976a-171f-c052-300b-bdd870297836' or the scope is invalid. If access was recently granted, please refresh your credentials."
		│
		│   with module.azure.azurerm_role_assignment.alz["plan_management_group"],
		│   on ..\modules\azure\managed_identity.tf line 51, in resource "azurerm_role_assignment" "alz":
│   51: resource "azurerm_role_assignment" "alz" {

Steps to Reproduce

Follow Phase 1 steps for GitHub.  Assign "Management Group Contributor" to SPN.

Follow Phase 2 2.2.2 steps.
Fails on step 8 with error above.
Giving SPN Owner permission on the root management group allowed me to continue

Screenshots
Additional context

Thanks for reporting, will follow up on this.

@terrymandin Good spot, somehow managed to overlook this during testing. My testing accounts must already have owner access rights. Will update the docs accordingly.

Resolved and published.

Awesome, thanks Jared!

Just tested, and additional permissions were not required.  Thank you for the fix @jaredfholgate


[model] how to initialize the parameter like caffe does?

these days I begin use mxnet to train model.
Can anyone help me that how to initialize the parameter like caffe does?

layers {
name: "fc8"
type: INNER_PRODUCT
bottom: "fc7"
top: "fc8"
blobs_lr: 1
blobs_lr: 2
weight_decay: 1
weight_decay: 0
inner_product_param {
num_output: 1000
weight_filler {
type: "gaussian"
std: 0.01
}
bias_filler {
type: "constant"
value: 0
}
}
}

layers {
name: "conv5"
type: CONVOLUTION
bottom: "conv4"
top: "conv5"
blobs_lr: 1
blobs_lr: 2
weight_decay: 1
weight_decay: 0
convolution_param {
num_output: 256
pad: 1
kernel_size: 3
group: 2
weight_filler {
type: "gaussian"
std: 0.01
}
bias_filler {
type: "constant"
value: 0.1
}
}
}

This is not yet supported in current initializer. You can however, implement your own initializer to support initializing by the name of the weight


Update request: papers 45.0-unstable-2024-03-27 → 46.1

Package name: papers
Latest released version: 46.1

Current version on the unstable channel: 45.0-unstable-2024-03-27
Current version on the stable/release channel: 45.0-unstable-2024-03-27

[x] Checked the nixpkgs pull requests

Notify maintainers

Sorry for pinging so many people, but the gnome team is listed as maintainers and I didn't just want to randomly pick one.
@Jo-Blade @bobby285271 @hedning @jtojnar @dasj19

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Should be resolved when #320100 is merged.


Add find username by access token

Needed in several places, most of the validation is done by having a valid access token in the Authorization HTTP header, but the username is more static.
The UM needs a POST /api/v1/userinfo (with Authorization HTTP header like Bearer eyJhbGciOiJSkxX0NpUUhmTm9nIn0...), and will return {"sub":"8031545e-d4da-4086-8cb2-a417f3460de2", "name":"myName myLastName", "preferred_username":"tester01", "given_name":"myName", "family_name":"myLastName"<EMAIL_ADDRESS>The needed field is preferred_username

Closed by PR #661


[SUGGESTIONS] Create a (better) Fallback Search than mine

Details
I'd like to conveniently call Keyboard Maestro macro by name as default fallback. My current implementation is adding a Fallback Search trigger and connecting it to Script Filter like this:

However, I'd like to trigger the closest match when I hit the KM fallback option, if possible.
I have no experience in Go, with little experience with AppleScript. Open to discussion, and might help if I can.

Can you share what you added to the fallback search ?

Sorry, I don't use Alfred anymore. closing this


[drone] take a list of repositories for export and migrate

harness-migrate drone export and harness-migrate drone migrate should support taking a list of repositories, rather than pulling all repositories from the provided drone namespace.
This will help with demos and test migrations, or when the user only wants to export/migrate a subset of repos.
The default behavior should still be to export/migrate everything in the namespace.
It should be a comma-separated list, or maybe read from a file (or maybe support both?).
Example:
harness-migrate drone migrate --namespace example --repository-list repo-one,repo-two,another-repo

PR raised: https://github.com/harness/harness-migrate/pull/58/files

This can be closed?

Yup! thanks


kmeans: split select function by blocks

This splitting is necessary to support huge datasets in KMeans

/intelci: run

/intelci: run

/intelci: run


[docs]: update JavaScript tutorial according to the upcoming SDK v3

Signed-off-by: 0x009922<EMAIL_ADDRESS>Upcoming SDK PR:

https://github.com/hyperledger/iroha-javascript/pull/124

@6r1d,

Are API and telemetry endpoint URLs both actually equal?

Nope, this is a typo.


sql: add catalog tests.

Current coverage is 56.23% (diff: 100%)

Merging #79 into master will increase coverage by 1.08%

@@             master        #79   diff @@
==========================================
  Files            33         33
  Lines          1291       1291
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            712        726    +14
+ Misses          534        520    -14
  Partials         45         45

Powered by Codecov. Last update 92c1449...b8e15ad


Make database schema configurable

I implemented the support of database schema's.
It is now possible to configure the default schema used by the document store:
options.DatabaseSchemaName = "other";
It is also possible to override the database schema per document:
options.MappingFor(typeof(User)).DatabaseSchemaName = "yet_another";
And it is possible to put the eventstore db objects in a different schema:
options.Events.DatabaseSchemaName = "event_store";
It also ensures that a database schema is created if it doesn't exist yet. Any feedback welcome!

@tim-cools Wow, that looks like a lot of work. I might be a little slow getting this in, gimme until Monday night at least.

@jeremydmiller sure no problem. I know it is pita to review :-)
I hyink I forgot the configuration from MartenRepository. I will look into this later...

@tim-cools Hey, so there's no surprises later, I'm reversing some of the small stylistic things here. I'm putting DocumentMapping.For<T>() back. I'm not wild about having the static factory classes. Mostly me being Linus here though;).
I'm working through this now. Might be later today before I can push though.

Pulled in w/ a rebase first.

@jeremydmiller no problem, you are the owner :-)
I removed the DocumentMapping.For because it is only used in Test code and I don't think consumers of the Marten API needs to call it directly. I would even argue that they should not be able to call it at all....
I noticed you are quit flexible about styling etc which I understand and many people probably appreciate. But it might be useful to document the preferred style briefly in a GitHub wiki page, even if it  only used as a guideline. I'm very pragmatic about the used style, but I like it when the same style is used in the same project/code-base. Just a suggestion :)


Increase default user conf sync interval

Original 3sec is too frequent.

@chcn can you update the description for the reason behind changing it?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6153/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.1 please


Improved UI/UX of alien_shooters

PR Description 📜

Added start screen, now the player need to click once to start the game
Added 'A' and 'D' keys functionality to move horizontally
Added an endscreen with options like retry and quit
Fixes #2930

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[ ] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Moracus ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @Moracus , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


og:title is not changed when titleTemplate is changed in nuxt.config.ts

Describe the bug
When titleTemplate is changed in nuxt.config.ts , the value of <meta property="og:title"> tag is not changed. The value of the <title> tag will be changed correctly.
If titleTemplate is changed using useHead , the value of og:title also seems to change correctly.
The following documents were used as references.
https://nuxtseo.com/nuxt-seo/guides/title-templates#changing-title-template
Reproduction
https://stackblitz.com/edit/nuxt-starter-ca65wt
System / Nuxt Info
------------------------------
- Operating System: Linux
- Node Version:     v18.18.0
- Nuxt Version:     3.8.1
- CLI Version:      3.9.1
- Nitro Version:    2.7.2
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      app, devtools, modules
- Runtime Modules<EMAIL_ADDRESS>- Build Modules:    -
------------------------------

Thanks for reporting and sorry for the delay, should be fixed in next RC.


Feat( eos_designs, eos_cli_config_gen): Add "disabled" option to "local_users"

Change Summary

Add disabled key to local_users datamodel
Related Issue(s)
Fixes #2254
Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

Modified templates to include a disabled key. When disabled=true, the template renders:
no username <name>

Updated documentation to include a "Disabled" column to reflect the status of the user
How to test

See molecule facts
Checklist
User Checklist

N/A

Repository Checklist

[x] My code has been rebased from devel before I start
[x] I have read the CONTRIBUTING document.
[x] My change requires a change to the documentation and documentation have been updated accordingly.
[x] I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista I adjusted this PR bit some checks are failing on an unrelated issue I think...

@ClausHolbechArista @tgodaA pls review, should be ready now.

Please update the schema fragment for local_users (see #2256) and then run molecule build_schemas_and_docs. Or if you prefer I can add it to your PR.

Added updates to eos_designs python module base.py and molecule test included from #2256


[stable/*] Create and document charts policy for breaking change upgrades

Hi everyone,
After @unguiculus reached started a Slack Charts maintainers DM about #5576, an unresolved problem emerged. We don't have a kubernetes/charts policy for how to handle breaking change upgrades.
Considerations
That PR made it clear we have two main choices:

Add logic to the templates for every possible upgrade step (from every past to new version of an app).

🚫 This was deemed to be not only an inelegant way to handle this problem on the whole, but also would make charts more difficult to maintain in the future.

Follow semver to denote breaking changes (bump MAJOR version, even if the upstream project's appVersion itself did not), and somehow clearly communicate the required upgrade steps to chart users who are upgrading from relevant previous versions to the current one (the steps themselves will vary by application and old/new version).

✅ This is the preferred option.

Next steps
We plan to meet about determining some helpful guidelines about this. Possibilities discussed were UPGRADE_NOTES/CHANGELOG files for charts, or adding a new section to the README (perhaps under new section header such as Upgrading, just above Installing the chart so users are more likely to see it?).
The ultimate goal of this issue is to track how we decide upon and document a consistent strategy for communicating additional info about breaking changes to users who want to upgrade from past versions of a chart.

@unguiculus @viglesiasce @prydonius @mattfarina @lachie83 please let me know if I missed anything.

We should keep this open till we document how to handle these.

Here is an issue where several charts are affected and need breaking changes: https://github.com/helm/charts/issues/7680

Hi @scottrigby
I agree with adding the instructions on a new Upgrading section. We can use sth like:
## Upgrading

## To Y.Y.Y

Backwards compatibility is not guaranteed unless you modify the labels used on the chart's deployments.
Use the workaround below to upgrade from versions previous to Y.Y.Y:

<Workaround here>

I tried this workaround before upgrading and fixed it:
kubectl patch deployments <deployment-name> --type=json -p='[{"op": "remove", "path": "/spec/selector/matchLabels/chart"}]'

I tried this workaround before upgrading and fixed it:
kubectl patch deployments <deployment-name> --type=json -p='[{"op": "remove", "path": "/spec/selector/matchLabels/chart"}]'

I've just tried it on a v1beta2 Statefulset (rabbitmq), and the outcome is still the same:

The StatefulSet "my-rabbitmq" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden.

Was your Deployment using >=v1beta2 as well?

Let me find the StatefulSets equivalent

And after checking, I confirm that it does NOT work either on Deployment apps/v1beta2 and later

I've tried to do a PR for redis as an example, with its own "how to upgrade" in its readme.
https://github.com/helm/charts/pull/7686

In these charts where deployments use deployments <= apps/v1beta2, the patch command works so the guide written in #7813 and #7785 are applicable

I should close this - we've adopted the README policy. I'll update the summary above.

Eh, review guidelines need to be updated


GPG key email verification no longer case sensitive (#2661)

surround every mail in https://github.com/go-gitea/gitea/blob/master/models/gpg_key.go#L405
with strings.ToLower(email)

Codecov Report

Merging #2663 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #2663   +/-   ##
=======================================
  Coverage   27.13%   27.13%
=======================================
  Files          86       86
  Lines       17061    17061
=======================================
  Hits         4629     4629
  Misses      11754    11754
  Partials      678      678

Impacted Files
Coverage Δ

models/gpg_key.go
30.28% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b62f04...5e2210c. Read the comment docs.

LGTM

LGTM. Thanks for doing it.


Cannot open directory inside already nested directory

Steps to reproduce:

Open Filer in build or in dev environment
Open any folder from sidebar
Open folder inside folder
Attempt to open folder in that folder and have it not work

It appears that the useEffect hook of the ActualFileList component is not getting called when entering nested directories, for some strange reason.

I think I am going to re-write the file list to use dynamic routing (ie; react router) instead of trying to screw with state for all eternity.


Dynamically update dropdown default value in the plugin errors window

🚀 Feature

It would be nice if the default value of the drop-down menu for the plugin errors menu changed to reflect the last plugin that threw an error.
Also, maybe we can add some text to the empty field under "select a plugin" that also tells you to, well, select a plugin. The little dropdown box is small and not-especially obvious (at least to me, the first time I saw it).
Motivation

It's disconcerting to open the list of plugin errors and see a blank screen, especially when you know something went wrong. It would improve the convenience and usability of the tool if it updated which plugin was selected in the dropdown based on which plugin was the last one to record an error. Probably 90% of the time that'll be the right guess, no input needed from the user.

Love it

@GenevieveBuckley If you get a chance, (or anyone else) could you provide a screenshot of the current state? Or alternatively how to reproduce to get the view you describe? I am not sure how to view it myself, presumably I'd have to have a plugin which was making an error(s)...? Thanks!

yeah, basically, someone just needs to update line 82 here
https://github.com/napari/napari/blob/f1b3be15b33ddd141575d56dd315f5f5676c1d94/napari/_qt/dialogs/qt_plugin_report.py#L77-L82

yeah, basically, someone just needs to update line 82 here

@tlambert03 do you mean do that to fix the main issue @GenevieveBuckley described about defaulting to the plugin?
In reference to:

Also, maybe we can add some text to the empty field under "select a plugin" that also tells you to, well, select a plugin. The little dropdown box is small and not-especially obvious (at least to me, the first time I saw it).

It'd still be helpful for me to see a screenshot (or know how to create for myself) the view, to help out from design perspective. Thanks!

open Plugin > Plugin Errors and you'll see this:

The point is that if there are plugins available to select, the first one isn't auto-selected (it still says "select plugin" either way).


cli.py:59-63: Implement chain of csv transformation. We...

The puzzle 19-b3973cba from #19 has to be resolved:
https://github.com/h1alexbel/samples-filter/blob/10d01f5605ec49ca3d7986a779a2524a16df3575/objects/cli.py#L59-L63
The puzzle was created by @rultor on 17-Apr-24.
Estimate: 45 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 19-b3973cba has disappeared from the source code, that's why I closed this issue.


Allow to return flag value as original type

Hello,
currently the Value interface always returns flag value as string:
type Value interface {
	String() string
	Set(string) error
	Type() string
}

But sometimes would be handy to return value as original type. In the example bellow I would like to set value directly as zerolog.Level type to avoid, later in the code, second conversion of the same string by calling zerolog.ParseLevel(level) again.
// LogLevel struct allows custom validation of log-level flag
type LogLevel struct {
	Level zerolog.Level
	DefValue string
}

func (l LogLevel) String() string {
	return l.Level.String()
}

func (l *LogLevel) Set(level string) error {
	// zerolog.ParseLevel returns true for custom levels, but we don't support them. Custom level is defined as
	// a number from some range stored in string.
	_, err := strconv.Atoi(level)
	if err == nil {
		return fmt.Errorf("unknown log-level value: '%s'", level)
	}

	if validLevel, err = zerolog.ParseLevel(level); err != nil  {
		fmt.Errorf("unknown log-level value: '%s'", level)
	}

	l.Level = validLevel
	return nil
}

func (l *LogLevel) Type() string {
	return "zerolog.Level"
}

It would be nice to see Value interface as this:
type Value interface {
        Get() {}interface
	String() string
	Set(string) error
	Type() string
}

I know that this is not a simple change as it may looks, because anyone will need to update their Value interface implementation. So, maybe there is a better option? :-)

Why not simply add another method (or a function) that allows you to set the value directly?  An interface determines what methods a type requires, but that does not mean you are limited to the method set of the interface.
And a Get() interface{} method would be expected to return a copy of the value, not a pointer to the value, as documented in the Getter interface of the standard flag package.  That means any modification to the value returned would have no effect.

Why not simply add another method (or a function) that allows you to set the value directly?
The problem is not with setting a value, but how to get the value as original type.
An interface determines what methods a type requires
You are right. My point is to have declared the name (so it's unified) and that anyone can rely that the method exists. It can be then used in other package like viper.
The method can be named as GetOriginal, OriginalType or just Original...

The problem is not with setting a value, but how to get the value as original type.

I apologize for misinterpreting what you meant by "set zerolog.Level directly", but you can still declare a Get() interface{} method to return a copy of the log level, even if it is not in the method set of Value.

My point is to have declared the name (so it's unified) and that anyone can rely that the method exists. It can be then used in other package like viper.

// Get returns the log level as a zerolog.Level value.
func (l *LogLevel) Get() interface{} {
	return l.Level
}

And any other package that wants to use the Get method can now use it.
The method does not need to be in the method set of Value.

But what about packages using this package already?

Adding a new method will not affect packages that use this package.  For example, adding a Get method (or whatever you call it) does not suddenly make it incompatible with Value: all of the methods required by the Value interface are still implemented, so existing functionality is not impacted.
Removing or changing behavior of existing functionality breaks compatibility, and that is when other packages start having trouble.

Adding a new method will not affect packages that use this package. For example, adding a Get method (or whatever you call it) does not suddenly make it incompatible with Value: all of the methods required by the Value interface are still implemented, so existing functionality is not impacted.

I agree with you. From my point of view, the ideal way is to have this method part of this package so it is somehow "standardized". Your suggestion is not applicable to this package, or am I missing something?
What about update the Flag struct and add attribute OrigValue {}interface? There is already DefValue :thinking:

I guess what i am wondering is why you believe it is important that pflag add such functionality.  You used the word "standardized", but it can just as easily be a "standard" part of your own package without adding another requirement to the pflag package.

It's not a problem to create own package, but the same would be needed also for viper package for example. So, because this package is used by other packages like viper, cobra, ... it makes sense to me to have it here. It simplifies the work in other packages and it comes handy when you do custom validation. It's not uncommon to have a validation method that returns a particular struct.
And a Get() interface{} method would be expected to return a copy of the value, not a pointer to the value, as documented in the Getter interface of the standard flag package. That means any modification to the value returned would have no effect.
I am sorry I somehow missed this info. But this is exactly what I am looking for. The point here is to get the original type. So it should be enough to implement Getter interface:
// Getter is an interface that allows the contents of a Value to be retrieved.
// It wraps the Value interface, rather than being part of it, because it
// appeared after Go 1 and its compatibility rules. All Value types provided
// by this package satisfy the Getter interface, except the type used by Func.
type Getter interface {
	Value
	Get() any
}

Btw we can close this issue in favor of this https://github.com/spf13/pflag/issues/320. It describes one of the needs for this change.

Btw we can close this issue in favor of this https://github.com/spf13/pflag/issues/320. It describes one of the needs for this change.

I agree #320 is a better place to discuss this.  Feel free to close this issue.


navbar: Fix UI bugs in right column of nav header.

Fixes the click target for the gear icon by providing
a proper rectangular area around it.
Minor UI adjustments of gear icon for small size
devices.
Fixes: #15222
Desktop

Mobile

The point mentioned in #15222 regarding right margin to the "Users" dropdown icon is actually not an issue
After toggling to the mobile view if we reload the page that margin get fixed
I guess CSS calc recalculate the middle column width after refreshing the page but not sure about that.

Ah. I was just reviewing #15233.

@YashRE42 do you have some better approach for Tim's comment?

Ok, I've checked this out locally and the end result is better than #15233, although the approach is different... long term, I'd say #15233 would lead to cleaner styles.
(I don't like the reliance on absolute and negative values).

Ah. actually this doesn't look right between 780px and 1665px, Please change that too.

can you review @timabbott

Merged as aefd8f0de27f2721649872a18ff76c5b1bbc0cb5 after the change detailed above, thanks @SiddharthVarshney!
I still wish we replaced all the random numbers with math based on variables; every time we make a change like this that fixes the visuals but doesn't improve the code, I'm a little sad because the next change to this widget will be just as much work as this one was to understand.

Bad html does tend to lead to bad css


Add WebGPU support

I'm implementing the WebGPU backend over here: https://github.com/hugoam/bgfx
I thought I'd open this issue to keep track of where I'm at, in a similar way you did for Vulkan
Here are the examples I've got working so far (so far the web builds at each link work in Chrome canary on Windows or OSX):

[x] 00-helloworld
[x] 01-cubes
[x] 02-metaballs
[x] 03-raymarch
[x] 04-mesh
[x] 05-instancing
[x] 06-bump
[ ] 07-callback
[ ] 08-update

can't update cube texture
compute update fails

[x] 09-hdr
[x] 10-font
[x] 11-fontsdf
[x] 12-lod
[x] 13-stencil
[x] 14-shadowvolumes
[x] 15-shadowmaps-simple
[x] 16-shadowmaps
[x] 17-drawstress
[x] 18-ibl
[x] 19-oit
[x] 20-nanovg
[x] 21-deferred

sampling depth textures not supported

[x] 23-vectordisplay
[x] 24-nbody
[ ] 25-c99

infinite main loop does not work with emscripten (stall)

[ ] 26-occlusion

missing occlusion queries

[x] 27-terrain
[x] 28-wireframe
[x] 29-debugdraw
[x] 30-picking
[ ] 31-rsm

sampling depth textures not supported

[x] 32-particles
[ ] 33-pom

crash on loading shader (unable to unroll loop ?)

[x] 34-mvs
[x] 35-dynamic
[x] 36-sky
[ ] 37-gpudrivenrendering

missing draw indirect

[x] 38-bloom
[ ] 39-assao
[x] 40-svt
[ ] 41-tess

missing draw indirect

20-nanovg
error - Buffer subdata size must be a multiple of 4 bytes

This sounds exactly like Metal requirement. See Metal renderer for fix: https://github.com/bkaradzic/bgfx/blob/e7b86061467253ef8532a7e807cf30c68bf1bb27/src/renderer_mtl.mm#L2563-L2564

Hi, I am not able to run any of the demos due to (Chrome and Firefox):

The WebGPU API has changed in the past few years and most likely bgfx needs a lot of updates as I don't think it's been worked on in a long time. Additionally Chrome and Firefox haven't quite finished reaching parity yet. If you're developing please use the latest Chrome Canary / Firefox Nightly.
This particular issue says navigator.gpu must not be available. WebGPU hasn't shipped yet. Make sure you're enabling WebGPU either with a chrome Origin Trial or chrome://flags/#enable-webgpu-developer-features or firefox about:config (dom.webgpu.enabled and maybe gfx.webrender.all).
Also note webgpu requires a secure context (https or localhost).

Yep, it's just experimental. We'll look into it once browsers get WebGPU by default, without turning on "developer" features.

I am actuallu using latest browser versions and enabled developer mode for webgpu on chrome. Are you sauing it should work?

Apologies I pasted the wrong flag name. It's not enable-webgpu-developer-features, it's enable-unsafe-webgpu.
chrome://flags/#enable-unsafe-webgpu
Fixed above

Apologies I pasted the wrong flag name. It's not enable-webgpu-developer-features, it's enable-unsafe-webgpu. chrome://flags/#enable-unsafe-webgpu
Fixed above

no problem and thank you for fast response, it indeed helped with my issue but generated a lot of new errors so I guess the time isn’t right just yet for webgpu

WebGPU is ready, but bgfx needs lots of work :)

WebGPU is ready, but bgfx needs lots of work :)

As of 3/8/2023 not available in any browser by default:
https://caniuse.com/?search=webgpu
Anyhow WebGPU is experimental in bgfx. Work on it will resume once all relevant desktop browsers (Chrome, Firefox, Safari) enable it by default. Until then there won't be any work on it. WebGL is fully functional...

Right. Chrome is aiming to release in 113 or 114 (early may or june in stable). The implementation is very well ready for development, so now is a good time if anyone out there happens to want to bring bgfx up to date to have it working around the time Chrome ships.
But of course it shouldn't have urgent priority for bgfx developers, since WebGL is working. Probably more of an idea for an external contributor if any want to pick it up :)

Hi, is someone currently working on implementing WebGPU. The standard seems to be implemented in Chrome and I want to try and tackle its implementation in BGFX?

@kainino0x As development of WebGPU took a while, we won't rush either just because one browser supports it. Once it's in Safari, and Firefox, without any developer flags we'll consider it again. One of things we need to figure out before port is tooling how to translate shaders from bgfx shaderc into WGSL (Tint or Naga).