Fix Docker Release GitHub Action

Apparently docker buildx flags --load and --push cannot be used at the same time currently. So this change switches load to happen when doing a normal, native architecture build. But allows for pushes when doing multiarch builds.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@259e6c9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1079   +/-   ##
=======================================
  Coverage        ?   99.99%
=======================================
  Files           ?      307
  Lines           ?    20329
  Branches        ?        0
=======================================
  Hits            ?    20327
  Misses          ?        2
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


"Viewing large files in pull requests" section is not correct

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/repositories/working-with-files/managing-large-files/collaboration-with-git-large-file-storage#viewing-large-files-in-pull-requests
What part(s) of the article would you like to see updated?

GitHub does not render Git LFS objects in pull requests.

But it does render them (images, at least) just fine. For example, consider this PR: https://github.com/FerretDB/FerretDB/pull/1368/files You can see that it uses LFS: https://patch-diff.githubusercontent.com/raw/FerretDB/FerretDB/pull/1368.patch
Additional information
No response

@AlekSi Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

Thanks @AlekSi, I chatted with the team about this, and it sounds like Git LFS objects are sometimes rendered and sometimes not. Rather than trying to explain the complicated criteria, let's just update that note to say this:

GitHub does not render some Git LFS objects in pull requests.

You or anyone else is welcome to open a PR doing so!

hey @lecoursen i would love to work on this 😀

@MahendraBishnoi29 - You or anyone else is welcome to work on this 🎉

Hello, created PR for the fix https://github.com/github/docs/pull/22740
Thank you


chore: general minor tweaks

Description
Added some tweaks from the "General" section of Andrea's "Web Tweaks" notions

Tysm Pablo for the tweak 🙌, Merging this


renderer fixes

The sdf_renderer.py example from the README.md is currently broken, this PR attempts to apply an ad-hoc fix to re-enable this app.
Seems like the app is outdated compared to the training example in main.py, in particular:

Renderer() requires a tracer arg (and missing from lib.tracer import * at the top, so SphereTracer can be constructed).
Renderer.eval() is called, but the class is not a torch module
fv parameter -> fov

Thanks for this fix. The changes look good- I'll fix the rest of the issues today.


Constant-time EC point multiplication (Montgomery ladder) implementation

Description
The mulPointScalar method is implemented with the regular square and multiply algorithm, which is prone to timing attacks due to the fact that the number of EC point additions depends on the number of 1's in the binary expression of the scalar.
With this implementation (called Montgomery Ladder) this is avoided by maintaining the number of additions depending only on the length of the binary representation of the scalar.
As documented in my implementation of the method, the algorithm works because of the following invariant: At each step, R0 will be r_0*base where r_0 is the prefix of e written in binary and R1 will be (r_0+1)*base. In other words: at iteration i of the loop, r_0's binary representation will be the first i+1 most significant bits of e. If the upcoming bit is a 0, we just have to double R0 and add R0 to R1 to maintain the invariant. If it is a 1, we have to double R0 and add 1*base (or add R1, which is the same as (r_0+1)*base), and double R1 to maintain the invariant.

Related Issue(s)
Fixes #324

Other information
Aside from the new implementation of the mulPointScalar method, I added some tests to automatically check basic behaviors such as EC point additions, EC point multiplications, and the orders of the generating/base points used in the protocol.
These tests are independent of the new implementation of the multiply method and are intended to make the test base more robust.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have run yarn style without getting any errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks @ChinoCribioli and @artwyman!

Perhaps @cedoor is willing to do so, or can suggest someone to double-check here.

I'm also not competent enough to check the logic out here. I'll ask other people to review it.
@ChinoCribioli Is this a breaking change?

@chancehudson I just pushed most of the changes you requested. My only doubt now regarding any possible remaining timing vulnerability lies on the lines e %= order and if (e & mask). Mostly the latter, since I don't know if the evaluation of an if statement in an integer is implemented in constant time.

Comments on the latest changes. I'm still curious about relative performance of this implementation vs. the previous one.

I've run the tests of the baby-jubjub and eddsa-poseidon packages (which are the main packages affected by this PR) with both implementations and these are the results:

on the lines e %= order and if (e & mask). Mostly the latter, since I don't know if the evaluation of an if statement in an integer is implemented in constant time.

The if statement should be fine as long as e is always the same size. This branch is specifically designed so that each codepath is equal time (this is the Montgomery ladder strategy). We just need to make sure the condition evaluation is constant time as well, which i suggested a change to try and ensure.
Again though, this is best effort. Regardless we're going to have some timing leakage from the BigInt implementation.

I've run the tests of the baby-jubjub and eddsa-poseidon packages (which are the main packages affected by this PR) with both implementations and these are the results:

I think this needs a more direct test of the affected operations (repeated in a loop to avoid fixed overhead and caching effects) to make the differences more clear.  It does look to me like the test times are uniformly slower, though, which isn't very pleasing.  I submitted an issue requesting to make it faster (which looks like it may be met by a WASM implementation implemented in Rust).  The utest which targets small values in particular is expected to get slower for a constant-time algorithm, but I assume the eddsa-poseidon tests are operating on more typical values.
I'm not entirely sure of the right trade-off here.  Speaking for the Zupass use case, I think we probably care more about performance than timing attacks right now, but that's not a universal choice I expect to apply to everyone.

I've run the tests of the baby-jubjub and eddsa-poseidon packages (which are the main packages affected by this PR) with both implementations and these are the results:

I think this needs a more direct test of the affected operations (repeated in a loop to avoid fixed overhead and caching effects) to make the differences more clear. It does look to me like the test times are uniformly slower, though, which isn't very pleasing. I submitted an issue requesting to make it faster (which looks like it may be met by a WASM implementation implemented in Rust). The utest which targets small values in particular is expected to get slower for a constant-time algorithm, but I assume the eddsa-poseidon tests are operating on more typical values.
I'm not entirely sure of the right trade-off here. Speaking for the Zupass use case, I think we probably care more about performance than timing attacks right now, but that's not a universal choice I expect to apply to everyone.

I get that for some projects performance is more important than

I've run the tests of the baby-jubjub and eddsa-poseidon packages (which are the main packages affected by this PR) with both implementations and these are the results:

I think this needs a more direct test of the affected operations (repeated in a loop to avoid fixed overhead and caching effects) to make the differences more clear. It does look to me like the test times are uniformly slower, though, which isn't very pleasing. I submitted an issue requesting to make it faster (which looks like it may be met by a WASM implementation implemented in Rust). The utest which targets small values in particular is expected to get slower for a constant-time algorithm, but I assume the eddsa-poseidon tests are operating on more typical values.
I'm not entirely sure of the right trade-off here. Speaking for the Zupass use case, I think we probably care more about performance than timing attacks right now, but that's not a universal choice I expect to apply to everyone.

I get that for some use cases performance is more important than safety, I honestly don't know which are the main projects that use this library. However, I think that any implementation of a rather complex cryptographic protocol must have a strong focus on security and, as you said, the performant variant may not be the best option for a lot of uses this library might have.

However, I think that any implementation of a rather complex cryptographic protocol must have a strong focus on security and, as you said, the performant variant may not be the best option for a lot of uses this library might have.

I think security should have priority over performance, but I would wait for a full review by the audit team.
One solution might be to release a new major if the security benefits are substantial and continue to maintain version 1 anyway.

One solution might be to release a new major if the security benefits are substantial and continue to maintain version 1 anyway.

@chancehudson @artwyman any thoughts?

One solution might be to release a new major if the security benefits are substantial and continue to maintain version 1 anyway.
@chancehudson @artwyman any thoughts?

I have thoughts in two directions.  First general thoughts on maintaining 2 versions:
It's workable, but definitely has a cost in maintenance burden and confusion.  Either both versions need to be kept up to date with future patches, or else v1 will slowly become less useful, and potentially even insecure.  I historically have a preference for "develop on main" workflows since the code everyone looks at and uses the code which will remain up-to-date and workable.  I realize this is a preference, though, not a clear-cut definition of "best".
If you're going to support multiple algorithms for a significant time period, it may be better to keep them both in the code separately.  They could be separate packages, separate functions within the package, or configurable via an "options" parameter.  That keeps them both "on main" so they should benefit from ongoing work, unit testing, etc.
2nd, thoughts on the specifics of the security vs. performance tradeoff here:
Given bigint arithmetic isn't constant-time anyway, this algorithm isn't a complete solution to the security problem.  That makes me personally de-prioritize it vs. performance, but that's a call reasonable people can make differently.  I would defer to someone with more security expertise, and who has specific threat models in mind to make the call on whether a constant-time algorithm built on variable-time bigint math reduces timing attack risk by enough of a margin to be worth prioritizing.
Calling the current implementation the "performant variant" is admittedly a bit of a stretch, since any pure-JS implementation of cryptography isn't going to be very performant.  A preferable alternative would be to solve this problem fully as part of a more optimized implementation (probably wasm) which is fast enough to be an improvement to performance even with a constant-time algorithm.  Such an implementation could improve both performance and security at once . I'm not sure how soon that's likely to happen, though, so there may need to be trade-offs or provide multiple options in the near term.


how to implement helm command "helm dependency update" with pyhelm

some command like  "helm dep update"
how to implement this function?

@flaper87
hello  falper87
from helm docs， We see 'Note: The dependencies: section of the Chart.yaml from Helm Classic has been completely removed.'
https://docs.helm.sh/developing_charts/
and your code is old....
https://github.com/flaper87/pyhelm/blob/master/pyhelm/chartbuilder.py#L201
so can you update it when you are free?

pyhelm does not extract dependencies from Chart.yaml. You are (currently) required to build the chart object you pass to ChartBuilder to contain the dependency definitions in order for them to be used by the library.

And regarding your first question, I'm not sure I understand.
Are you asking how to replicate the functionality of the helm dependency update command? If so, this is not implemented as part of pyhelm, but as pyhelm doesn't use the on-disk mirrors of the dependencies it doesn't affect it.

@yanivoliver
yeah... I mean replicate the functionality of the helm dependency update command as part of pyhelm
Because I  use ansible helm module, and find this module can not work the functionality of the helm dependency update command

Gotcha. pyhelm does not replicate most of the client-side logic of Helm, including not implementing the functionality of the dependency update command.
Can you elaborate on your full use-case? What is your need of this functionality in pyhelm? If you install Charts using pyhelm you don't need this functionality, as we load the dependency straight from source instead of taking the .tgz version under Charts subdirectory.

@yanivoliver  OK...
here is my case:
A chart named kube-prometheus, it has requirements.yml and contains other chart.
the architecture looks like this:
kube-prometheus:
|__ charts/
|__ Chart.yml
|__ requirements.yml
|__ values.yml
|__ templates/
|__ prometheus/
|__ xx_exporters/
|__ yy_exporters/
In shell command:  when to deploy this chart， need to use helm dep update command to generate some exporters.tgz  in  charts directory, then use helm install to deploy the whole chart.
but when I use pyhelm.  It does not work.
if it is hard to implement this function, I need to separate this chart. thanks @yanivoliver

Sorry for the (very very) late response. Is this still relevant?

@yanivoliver yes this issue is still relevant. It would be great to see this function implemented in PyHelm project. Otherwise, could you provide an implementation guide?
By the way, is there any relation with issue #52 ?
Thanks a lot.


index out of range on node insert

Installed an official docker of redisgraph, and latest redisgraph_py==1.7 from pypl.
Inserting a single node fails on commit, because result does not have statistics (response[1]) - len(response) == 1:
(Pdb) response
[[b'Nodes created: 1', b'Query internal execution time: 0.548200 milliseconds']]
File "/orbital/base/user_service/src/py/v2/engine/redis_folder_graph.py", line 65, in add_folder
g.commit()
File "/opt/conda/lib/python3.6/site-packages/redisgraph/client.py", line 136, in commit
return self.query(query)
File "/opt/conda/lib/python3.6/site-packages/redisgraph/client.py", line 158, in query
statistics = response[1]

Hi @jrozentur,
Unfortunately for the time-being (until RedisGraph 2.0 is released) the official RedisGraph-py package (PYPI) isn't compatible with the latest docker image of RedisGraph, please install RedisGraph-py directly from github.

@jrozentur
I'm closing this issue, as we are past the release of RedisGraph 2.0.
If you still encounter problems please re-open this issue.


Idea request

Hi.
If I send Image1 and then Image2 to the h264 encoder and save to file as h264 movie.
Now i have Image3 but i know for 100% that image3 is equal to image2 (same image).
Instead of calling h264 EncodeFrame func  what can write to the file instead of calling the EncodeFrame func?
I just trying to make some optimization.
Thanks!

Why not call h264 encoder when input image3? you can write bitstream that all MBs are skipped by yourselves.


json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Ever since the new character ai website update I cannot use this library anymore and I get this error:
Exception has occurred: JSONDecodeError
Expecting value: line 1 column 1 (char 0)
StopIteration: 0
During handling of the above exception, another exception occurred:
File "D:\Python\Instagram Bot\main.py", line 17, in
chat = client.chat.get_chat(char)
^^^^^^^^^^^^^^^^^^^^^^^^^^
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I think this was due to the tls fingerprint from tls_client losing to cai cloudflare. So I used a different tls fingerprint library, curl_cffi. Here is my solution:
First download the library
pip install curl_cffi
In characterai.py, add the following import
from curl_cffi import requests

Find and change the session initializer
# self.session = tls_client.Session(
#     client_identifier='chrome112'
# ) # session using tls_client
self.session = requests.Session() # session using curl_cffi

Find and change the header initializer in the function request
headers = {
            'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36',
            'Accept': 'application/json, text/plain, */*',
            'Accept-Language': 'en-US,en;q=0.5',
            'Referer': 'https://beta.character.ai',
            'Authorization': f'Token {key}',
            'Origin': 'https://beta.character.ai',
        }

I don't know why it works but if it works, it works

They started using cloudflare to fight against bots. Simple fetching won't work anymore.

Fixed in the new version


Add support for non-power of 2 widths

Version 2.0.0 of crc-catalog added support non-power of 2 width CRC algorithms. This makes it possible to implement every possible algorithm in this crate.

Benchmarked locally, and performance impact is negligible:
crc8                    time:   [1.5108 ms 1.5113 ms 1.5120 ms]
                        thrpt:  [630.72 MiB/s 631.03 MiB/s 631.25 MiB/s]
                 change:
                        time:   [+0.1241% +0.2477% +0.3780%] (p = 0.00 < 0.05)
                        thrpt:  [-0.3766% -0.2471% -0.1240%]

crc16                   time:   [1.7226 ms 1.7226 ms 1.7227 ms]
                        thrpt:  [553.59 MiB/s 553.61 MiB/s 553.63 MiB/s]
                 change:
                        time:   [-0.0448% -0.0308% -0.0187%] (p = 0.00 < 0.05)
                        thrpt:  [+0.0187% +0.0308% +0.0448%]

crc32                   time:   [1.7263 ms 1.7265 ms 1.7268 ms]
                        thrpt:  [552.28 MiB/s 552.37 MiB/s 552.43 MiB/s]
                 change:
                        time:   [-0.0393% -0.0126% +0.0147%] (p = 0.35 > 0.05)
                        thrpt:  [-0.0147% +0.0126% +0.0393%]

crc40                   time:   [1.7233 ms 1.7234 ms 1.7235 ms]
                        thrpt:  [553.33 MiB/s 553.36 MiB/s 553.39 MiB/s]

crc64                   time:   [1.7235 ms 1.7237 ms 1.7238 ms]
                        thrpt:  [553.23 MiB/s 553.29 MiB/s 553.33 MiB/s]
                 change:
                        time:   [+0.0014% +0.0179% +0.0338%] (p = 0.02 < 0.05)
                        thrpt:  [-0.0338% -0.0179% -0.0014%]

crc82                   time:   [1.7233 ms 1.7234 ms 1.7234 ms]
                        thrpt:  [553.35 MiB/s 553.37 MiB/s 553.39 MiB/s]

LGTM, I think it would be a good idea to increase test coverage before publishing next release. Maybe compare checksums on large data sets against a reference implementation.


Accept application/zip files from front-end

The front-end cannot know the type of all files inside a ZIP archive, and, indeed, there may be many types, rather than a single type. Further, by HTTP spec, the content type of the request must necessarily be the content type of the content, not the content of files inside the decoded content.
For these reasons, the backend will need to encode and decode whatever metadata it requires into and out of the ZIP archive that it generates.
If we switch to using EJSON, this may have a straightforward solution. Otherwise some hack may be required, such as creating a hidden .quasar-metadata.json file which contains metadata annotations for all flat children in a directory.

/cc @garyb

It seems like the zip format has some support for metadata, but it’s not very well specified, so I think it's probably safer to add the suggested magic dot-file with the information we need.
So here's the plan:

[ ] make sure Content-Type is application/zip in both directions.
[ ] add .quasar-metadata.json at the root of the zip archive, containing whatever additional info is needed to write the files.
[ ] parse, validate, and use the metadata when uploading
[ ] add some tests for alternative formats
[ ] test upload with heterogenous formats (hand-assembled zip)

The metadata file will look something like this (not that anyone apart from quasar will need to understand it):
{
  "foo": {
    "Content-Type": "application/ldjson; mode=\"precise\""
  },
  "bar/baz": {
    "Content-Type": "application/ldjson; mode=\"precise\""
  }
}

This could provide a path to saving / restoring mounts, too.

Fixed by #1883


Broken Documentation Links

Link sin the new documentation are broken.
Current version of Webpack documentation file (as for 716e124) contains
[Install bootstrap]({{ site.baseurl }}/docs/{{ site.docs_version }}/getting-started/download/#npm)

which is producing (and leading to a 404 page)
Install bootstrap

instead of
Install bootstrap

Thanks for reporting it 😄  It was fixed here:
https://github.com/twbs/bootstrap/commit/537b5f012771069b182aabab651eff9723d785b0

Cool! How long would it take to impact on https://getbootstrap.com/docs/4.0/getting-started/webpack/ ? It has been more than a month since that has been merged, but links are still broken

@santiph when beta-2 gets release it'll impact the website

oh, nice...
Is there any release schedule published?

I don't know. This might help https://github.com/twbs/bootstrap/projects/4


Perhaps, Would be better for Pint to support blade file

I was using folio and livewire volt.
I was able to style file in resources/views when change file extension from blade.php to php.
Would be better if pint can support blade file also.
-use function Livewire\Volt\{state, rules, mount, boot, on};
  +use function Livewire\Volt\boot;
  +use function Livewire\Volt\mount;
  +use function Livewire\Volt\on;
  +use function Livewire\Volt\rules;
  +use function Livewire\Volt\state;

Hope for pint also ignore and not refactor [[ use function Livewire\Volt{state, rules, mount, boot, on}; ]] also.

Duplicate of #64


Add "Apply to all future frames" including non-visited frames

Add "Apply to all future frames" including non-visited frames:

Rename "Apply to all future frames" to "Apply to all VISITED frames (recommended)"
Add "Apply to all future frames"

Changes that are propagated (hence will require testing):

Delete ID
Edit ID
Exclude cell from analysis
Annotate cell as dead

I tested this in combination with "Remember my choice and do not show this message again"
On the initial cell I deleted, it worked but later I deleted some cells which were then not deleted on all future frames

I'm closing this because it seems to be working now.


RC test: Coulomb's Law 1.0.0-rc.9

Final spot check, hopefully.
@KatieWoe, @arouinfar, @jessegreenberg, @ariel-phet  coulombs-law/1.0.0-rc.9 is ready for a final spot RC check. Document issues in https://github.com/phetsims/coulombs-law/issues and link to this issue.
There are a few issues discovered from the last RC that won't be addressed prior to this publication. They are noted below.
Assigning @ariel-phet for prioritization & QA team (this will hopefully be a quick check).

General RC Test

What to Test

Click every single button.
Play with the sim normally.
Try to break the sim.
Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
Complete the test matrix.
Check this LoL spreadsheet and notify AR if it not there.

Issues to Verify
These issues should have the "status:fixed-pending-testing" label. Check these issues off and close them if they are fixed. Otherwise, post a comment in the issue saying that it wasn't fixed.

[ ] Text goes off screen
[ ] Force Values should display a magnitude
[ ] [Atomic Scale] Use MathSymbols.TIMES in scale bar readout
[ ] Keyboard nav issue when starting after charge slider

iOS crashing is apparently no longer an issue, but we should still check to ensure it doesn't arise again.

[ ] Crash on iOS 10

Link(s)

Simulation
iFrame
XHTML
Test Matrix
Legends of Learning Harness

Accessibility (a11y) RC Test

What to Test

Specific instructions can be found below.
Make sure the a11y feature doesn't negatively affect the sim in any way.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).

Link(s)

a11y View
Simulation
Test Matrix

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

[ ] Win10 Chrome
[ ] Win10 FF
[ ] Win10 Edge
[ ] Mac 10.14 Chrome
[ ] Mac 10.14 FF
[ ] Mac 10.14 Safari
[ ] iOS 12
[ ] iOS 10
[ ] Chrome OS
[ ] Win 7 IE
[ ] Win 7 Chrome
[ ] Mac 10.11 Safari
[ ] Mac 10.11 FF

Looks good @mbarlow12!

Thanks, @lmulhall-phet !


Assume a nonnull MD5 digest.

This PR helps with using this project in Swift by allowing the type system to infer that the MD5 digest is non-nil.

Thanks for doing this! Two quick comments and we should be good to go!

@keith How’s this? (And let me know if you’d prefer this squashed into one commit)

This looks good to me! I'm fine leaving these separate in case we ever find a need for the expanded macros.

Thanks for this, going to push a CocoaPods update.

:+1: Thanks for merging!

No problem! Thanks for the contribution! 1.1.0 is now pushed to CocoaPods.


A way to turn off parallel execution (for easier comparison)

Would be neat if you could toggle the parallel execution on and off, to better demonstrate the performance difference that it implements.
Would happen in this code that calls gather(): https://github.com/simonw/asyncinject/blob/47348978242880bd72a444158bbecc64566b0c55/asyncinject/init.py#L114-L123

Implemented most of this in #9 - but it needs tests and documentation.

Will be easier to write tests for this if I solve #7 first.


[spk] delete a ring

As a:
spk user
I want:
to be able to delete a ring
So that:
i can have remove a ring i no longer need
Describe the solution you'd like:
a new spk ring delete <ring-name> command to delete a ring from a spk managed project.
Acceptance Criteria:

[ ] Create a new command spk ring delete <ring-name>
[ ] Command removes the ring from the bedrock.yaml
[ ] For all services linked in bedrock.yaml, remove the new ring from the trigger branches in the service's build pipeline
[ ] This command will not allow the deletion of the default ring. Users must first change the default ring before deleting the current default ring. Setting default ring is captured here: https://github.com/microsoft/bedrock/issues/972

Does this require updates to documentation?:
Yes

Same comment

@mtarng thanks for creating this. Would love to see this in a user guide as mentioned in #955 before implementing.

@mtarng sam e question here about sizing? Can others take this on?


Cluster-autoscaler: fix problems with GCP access from GCE master.

Ref: #968

@mwielgus Is it done? btw - it'd be great if you could be more descriptive next time. People should be able understand what a given issue is about.

Done.


Dialog: change to dialog element

According to https://github.com/dequelabs/axe-core/blame/develop/lib/commons/aria/index.js#L279
an alertdialog should be of element type dialog or section.
Closes #1288

I'm not sure that this is the right place, maybe it suited better at mdc, they specify the html

In their docs they're using div element (which is also wrong, but not aside), so this shouldn't be aligned with mds? https://github.com/material-components/material-components-web/tree/master/packages/mdc-dialog

Well I guess the dialog doesn't break anything right? The only problem it that you should also create a PR against 2.0 because we already split them off.

ummm doesn't dialog have its own functionality for showing a modal?

Yes, it have. My bad. Shall we use section instead?

Hmm I didn't know that dialog had that ability, I thought it's just some made up tag

Why not div with proper aria?
I know mdc web takes care of accessibility so I don't think it's s problem

According to https://github.com/dequelabs/axe-core/blame/develop/lib/commons/aria/index.js#L279 it's not allowed, which gives me problem in my nightwatch-accesibility tests (built upon axe-core).

Hmm then may section of the second best option.


WebSocketError not gracefully caught when client closes socket

On a local development server, I've recently noticed that I get the following traceback if a socketio-enabled page is refreshed, closed, or I navigate somewhere else - basically, if the browser closes the underlying websocket connection:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 390, in run
    result = self._run(*self.args, **self.kwargs)
  File "/usr/src/gevent-socketio/socketio/transports.py", line 241, in send_into_ws
    websocket.send(message)
  File "/usr/src/gevent-websocket/geventwebsocket/websocket.py", line 350, in send
    return self.send_frame(message, self.OPCODE_TEXT)
  File "/usr/src/gevent-websocket/geventwebsocket/websocket.py", line 314, in send_frame
    raise WebSocketError('The connection was closed')
WebSocketError: The connection was closed
<Greenlet at 0x467ff50: send_into_ws> failed with WebSocketError

Since gevent-websocket is probably correct in raising WebSocketErrror at line 314 of geventwebsocket/websocket.py (and may depend on that exception elsewhere), I think that gevent-socketio should catch that exception and gracefully dismiss it.
I have a feeling that this behaviour has only been in the last couple of weeks and wonder if it's related to recent commits. What seems a bit puzzling is that line 214 of socketio/transports.py is in the connect() method of WebsocketTransport. How can it be in the connect phase, if the socket has just been closed?

Apologies for the lack of response. I haven't used gevent-socketio for many years, and it appears that the project is dormant / dead anyway. Feel free to re-open this issue if it sputters back to life and the problem still persists.


Props null when calling components with Jsx

Imagine the following code:
const Hello = ({ name = 'world' }, children) => {
  return
Hello {name}!

}

app({
  view: () => <Hello />
})

When ran, it throws an error because undefined cannot be destructured into { name = 'world' }.
This can be fixed by changing h.js:
return typeof tag === "string"
    ? // ...
    : tag(props = {}, children)

Is this a bug or is it an intentional design decision?

@Mytrill : tag(props || {}, children)
Yes, you found a bug! 😄 🏄

Will try to push a fix now.


Add logging support in Player

Added logging support in Player through flag in initialization
If logging is desired, then we initialize it and set it in PlayerWorld (to avoid passing to the many places where logging is needed)
I've added all logging as error and using the place of the fail as the case name and name.

⚠ For this logging names and messages, I've followed a pretty simple approach, using the name of the place, and not a big message. For the ones with error, we will send the error description. I've added all as errors. We can discuss one by one in this PR and decide the level, pick another level for all or leave as it is and update as we go and as we see it. We still need to have agreement on guidelines, so we can also postpone the decision after those are decided.
⚠ For simplicity and consistency, I've followed same approach as in Auth, with a flag and the logger being instantiated inside the sdk. We may discuss if at any point it would make sense to inject a logger, giving the decision of the configuration of the logger to the user of the sdk.
⚠ Already pointed out in the past, seems like the failing tests are not always reported. It was missing from last PR a fix for tests, and the CI didn't report failure.
⚠ Another point is in which part of the flow the error is logged. In some cases, we get an error but create another one. For this first step, I've literally added logs in all levels of such flows - everywhere we had a catch. I'd prefer to add more now to start with, observe, and later get rid of what doesn't make sense. But if we already notice some places where it doesn't make sense, please point it out and we can already address those.

This pull request introduces extensive logging improvements across various modules to better handle and trace errors. The primary change is the addition of logging statements using the PlayerWorld.logger to capture errors in different parts of the codebase.
Logging Enhancements:

Authentication Module:

Added logging for failed attempts to get bearer token credentials and to convert credentials to a bearer token in CredentialsProvider. ([Sources/Player/Common/Authentication/CredentialsProvider+Player.swiftR16-R21](diffhunk://#diff-bd58f9fbf2a2a8e53fdc8f4a92425e4517ce46457abbfde37bd28aa6cf959acaR16-R21))

DRM Handling:

Added logging for failures in fetching licenses and processing content key requests in FairPlayLicenseFetcher, StoredLicenseLoader, and StreamingLicenseLoader. ([[1]](diffhunk://#diff-5e6ac44115d32c3000091124c15de6b878eaadb027622d1963e8170163017037R116-R117), [[2]](diffhunk://#diff-e4f018472818bcc484360d609feee78b8cbedcabfb950ee16a123acb1849060fR35), [[3]](diffhunk://#diff-e4f018472818bcc484360d609feee78b8cbedcabfb950ee16a123acb1849060fR49), [[4]](diffhunk://#diff-e34124f5ea781d42872d3e575597c3fb7d4367c795664d03401ee8c5a9b89f67R46))

HTTP Client:

Added logging for payload encoding/decoding failures and request handling errors in HttpClient and URLSession. ([[1]](diffhunk://#diff-789a68be9c0928fb27c866719c9ce8ccae0eccfefda14049d2b8264d42a8bc95R168), [[2]](diffhunk://#diff-789a68be9c0928fb27c866719c9ce8ccae0eccfefda14049d2b8264d42a8bc95R177), [[3]](diffhunk://#diff-789a68be9c0928fb27c866719c9ce8ccae0eccfefda14049d2b8264d42a8bc95R236))

Offline Engine:

Added logging for download failures, license fetching failures, and item deletion errors in DownloadTask, Downloader, LicenseDownloader, and OfflineEngine. ([[1]](diffhunk://#diff-b50645adbd7e57968139bc1048f2c4fa12db73e54e45e90d109373a1e08458fcR116), [[2]](diffhunk://#diff-b50645adbd7e57968139bc1048f2c4fa12db73e54e45e90d109373a1e08458fcR137), [[3]](diffhunk://#diff-14533cbb2dc8b962963699f85044a8dff91daa2a8ec925fd6c8d75df9ca42863R63), [[4]](diffhunk://#diff-bc4cd2c6898affe73d605cdbf55cb93b1606ac51b1cb6dbf5effba04d8c636b9R43), [[5]](diffhunk://#diff-bc4cd2c6898affe73d605cdbf55cb93b1606ac51b1cb6dbf5effba04d8c636b9R63), [[6]](diffhunk://#diff-c25638cfdf9a5799584b59c57b4e374a03e64536da9e6dd5db37c53a33605ec8R98))

Playback Engine:

Added logging for playback metadata reading failures in AVQueuePlayerWrapper. ([Sources/Player/PlaybackEngine/Internal/AVQueuePlayer/AVQueuePlayerWrapper.swiftR462](diffhunk://#diff-b75f24d9a1db1bbe79fed5b71b9fd741a62df41c29d49643af0db04b36fe6985R462))

New Logging Definitions:

New PlayerLoggable Enum:

Introduced a comprehensive PlayerLoggable enum to define various loggable error cases for different modules. ([Sources/Player/Common/Logging/PlayerLoggable.swiftR1-R347](diffhunk://#diff-241c41ad3dff9ee36736f5b5fc913320fd065b24ed9aeba7e1016bcf2345ef49R1-R347))

Integration with PlayerWorldClient:

Added a logger property to PlayerWorldClient to facilitate centralized logging. ([[1]](diffhunk://#diff-e93ff12ff899401df71646980605ab0bc4a489ffe43087ad2d8ff199515b9bb4R16), [[2]](diffhunk://#diff-e93ff12ff899401df71646980605ab0bc4a489ffe43087ad2d8ff199515b9bb4L26-R28))*

This is outstanding @ceciliasaraiva!! It should help us quite a bit (as long as Firebase UI collaborates with us 😅 )
I don't see any issues with all of these, as they are all errors / exceptions, and it is not modifying the logic flow in any way.
We will need more planning and guidelines for other info, trace logs we might want to add, but I´m not sure how useful those would.. Do you know if we can see the history of logs for a given user / session at the same time? (to follow the trace)
Also, Do you have examples of the formatting and how they would appear on firebase?

We can discuss this offline since it's responsibility of the consumer of the sdk. Regarding guidelines, we will come up with proposal and have a general agreement.


CHEBI:133968, please replace structure with the attached

Hi,
CHEBI:133968, 5'-(N(7)-methyl 5'-triphosphoguanosine)-(purine-ribonucleotide) (3-) residue.
The current structure is not in accordance with the usual way of drawing nucleotide residues as the 3'-phopshate group is included (c.f. CHEBI:74269, GMP(1−) residue). I would therefore be grateful if you would replace it with the attached mol file (saved as txt to be able to attach it here).
Cheers,
Kristian
CHEBI_133968.txt

Hi Kristian,
Now sorted.
Best regards,
Gareth


[WEB] Need more PageTransitionTheme for web transition

Use case

Proposal

    pageTransitionsTheme: PageTransitionsTheme(builders: {
      TargetPlatform.iOS: CupertinoPageTransitionsBuilder(),
      TargetPlatform.android: OpenUpwardsPageTransitionsBuilder(),
    }),

Web transition doesn't need those of
-FadeUpwardsPageTransitionsBuilder
-OpenUpwardsPageTransitionsBuilder
-CupertinoPageTransitionsBuilder
I think TranisitionBuilder for web should be supported,
such as NoAnimationTransitionBuilder..

This looks like a design language question. It also applies to desktop platforms. I'm removing platform-web tag.

/cc @HansMuller


Register seller - create a new seller

I would like to work on this

Please what constraints am I to consider? @victoria-igbobi65 @raphdoo @Skywonda


filter state: register DFP objects

Commit Message: Continue https://github.com/envoyproxy/envoy/pull/29030, for DFP cluster to support https://github.com/envoyproxy/envoy/issues/29251.
Additional Description:
Risk Level: low
Testing: done
Docs Changes: yes
Release Notes: none

/assign @envoyproxy/envoy-maintainers

/assign-from https://github.com/orgs/envoyproxy/teams/envoy-maintainers

/assign-from @envoyproxy/envoy-maintainers

@alyssawilk for senior maintainer pass.

/docs


Add redux tests

These tests are supposed to complement the redux testing section in ngCourse2:
https://github.com/rangle/ngCourse2/pull/86
I am not sure if mockStore (got it from blue-j) is bullet proof but it works.

Seems reasonable to me.  I agree the mockStore has a bit more logic than I'd like but I understand the reasons for it.
I wonder if there's a way to at least remove the expect from inside the mockStore: I'd prefer that the tests be able to control their own expectations more directly.
Perhaps if you used sinon to spy on the dispatch method, you could verify that it was called with the relevant actions in the test function itself.

a11efd6
I just had getState and dispatch passed into mockStore. I tried spying on dispatch but it doesn't pick up on the dispatches fired in the thunk, plus wasn't sure if done could be called. I tried stubbing dispatch after the store's created but that overrides the middleware logic, plus createStore is called in applyMiddleware so can't really stub dispatch before the apply... and there's the thing where reducer initial states override the initial state handed to createStore. So mocking the whole createStore turns out to be pretty clean :eyes: .

https://github.com/rangle/rangle-starter/issues/20

:shipit: then.  Is this something that can apply to the other starters (they all use redux).

Fixes https://github.com/rangle/rangle-starter/issues/20

@SethDavenport Yes the action + reducer tests apply to just redux. Those are separate from stuff that happens with ng2-redux or react-redux.


Fix CSS issues with cookie overlay

Fixes some usability problems with the cookie overlay:

Makes it easier to see by adding a border and making the button higher-contrast
Prevents it from covering the left nav and making items unclickable
Makes the close button a little bigger and margins and padding consistent

Fixes #12072.

Looks fixed to me.


[BUG]Can't create opensearch_index_template

What is the bug?
A clear and concise description of the bug.
How can one reproduce the bug?
Steps to reproduce the behavior.
tf as below:
resource "opensearch_index_template" "template_1" {
name = "test"
body = <<EOF
{
"index_patterns": [
"logs*"
],
"template": {
"settings": {
"number_of_shards": 2,
"number_of_replicas": 2
},
"mappings": {
"properties": {}
}
}
}
EOF
}
terraform could apply the change, but can't find the corresponding template in OpenSearch-Index Management-Template menu.
What is the expected behavior?
A clear and concise description of what you expected to happen.
What is your host/environment?
Operating system, version.
Do you have any screenshots?
If applicable, add screenshots to help explain your problem.
Do you have any additional context?
Add any other context about the problem.

Hey @Wyifei, I have a PR for provider 2.x support https://github.com/opensearch-project/terraform-provider-opensearch/pull/62, I made some code changes related to index templates, is there a way you can test this please?
Thank you


inkcut: init at 2.1.0

Motivation for this change
Wanting to use inkcut
Draft PR for early feedback if anyone is interested, not tested in depth yet
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

corona doesn't let me near the vinyl cutter anyway


python3Packages.httpx: 0.17.0 -> 0.17.1

Motivation for this change
Update to latest upstream release 0.17.1
Change log: https://github.com/encode/httpx/releases/tag/0.17.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116541 at 159f5670 run on x86_64-linux 1

14 packages built successfully:

datasette (python38Packages.datasette)
home-assistant
python38Packages.PyRMVtransport
python38Packages.axis
python38Packages.elmax
python38Packages.entrance
python38Packages.entrance-with-router-features
python38Packages.fastapi
python38Packages.httpx
python38Packages.pytest-httpx
python38Packages.pytest-sanic
python38Packages.respx
python38Packages.sanic
python38Packages.sanic-auth


[release-2.10] Use entitled Dockerfile for Konflux

Also updates ubi8 --> ubi9
Contains cherry-pick from:

#287

ref: https://issues.redhat.com/browse/ACM-10739

/retest


Test Proxy Migration for Storage Common

Description
Migrating existing Groovy tests to extend new TestProxyTestBase.

API change check
API changes are not detected in this pull request.

PR still not done


refactor: split transpiled code

Thanks to guidance on the TSTL repo, I've figured out how to properly split transpiled Lua code in a Neovim-friendly way. This has a few advantages:

It's now possible to load individual modules (currently unnecessary but potentially useful in the future)
Startup speed should improve, since we don't load a single gigantic Lua file as soon as a user calls require("typescript")
It's easier to match source files to their Lua equivalents, making it easier to debug issues

The solution depends on a simple TSTL plugin, which I plan on publishing as a separate package. Adding a TypeScript file that won't get transpiled required other structural changes as well.

[x] Figure out why some tests are failing (ended up running tests sequentially, which is more reliable, and deleting a redundant test)
[x] Clean up code action source
[x] Update documentation

Given the random test failure, I want to be paranoid and daily drive this for a bit before merging, but otherwise I think this is good to go.

I think you need to  add ts-node to package json, otherwise I get this error when building
error TSTL: To load "./plugins/fix-require-path.ts" plugin it should be transpiled or "ts-node" should be installed.

I think you need to add ts-node to package json, otherwise I get this error when building
error TSTL: To load "./plugins/fix-require-path.ts" plugin it should be transpiled or "ts-node" should be installed.

Great catch, thanks.


feature: would like the ability to apply, but not update certain resources

Feature Description
kubestellar syncer overwrites all resources that it manages.  Would like the option (a label) to indicate that syncer should not overwrite the specific resource.  This label will be part of the individual resource or part of an edgeplacement (indicating that all resources should not be synced for this specific 'what' predicate).
Proposed Solution
add support for a label to come from the edgeplacement and/or the specific resource
Want to contribute?

[ ] I would like to work on this issue.

Additional Context
No response

What is the use case where this is needed?

this is the case where KubeStellar syncs a resource initially - like a secret that contains no sensitive information.  The operator of the WEC needs to update the secret to have the information necessary to connect to some service, and therefore ks should not overwrite it.  This is useful in a situation where 2 different parties own the hub and spoke and we do not want credentials stored or transferred to a customer, and a customer does not want the hub to know the credentials they use.  However, the workload depends on the existence of the secret.  So, create the secret from hub to spoke, and then let owner of the spoke update it.

@clubanderson thanks for the elaboration. This overlaps enough with what I am hearing from Nick Mitchell that I think we should address the more general form, stated in #1112 .

I have a couple of comments on this feature, even without considering what Nick wants.

As a general rule we do not favor putting KubeStellar control bits into workload objects, to support use cases where the workload objects are authored by a third party and kept in sync (e.g., by a GitOps tool) with the third-party-authored source. So the bit here should go in a KubeStellar control object rather than a workload object.
The definition here is more operational than stated in state-based management terms. I would say that this feature is about giving the user a way to say that for certain downsynced objects what propagates from core to WEC is not what is ordinarily considered the desired state but rather the mere existence of the object.  BTW, I think an alternate definition that supports the use case here is to give the user a way to say that for a certain downsynced object the WDS does not define the whole of the desired state that will appear in the WEC but rather supplies some desired state that is merged into the desired state at the WEC.

@MikeSpreitzer this is overthinking the issue.  We simply need a label that says - "downsync-overwrite: false". default value without the label is true.  This is not part of another set of state that needs to be recorded somewhere.

right now I am labelling namespaces.  In the near future I would be enumerating those namespaces in the edgeplacement.  Edgeplacement is becoming more and more a manifest of objects.  It will include a list of namespaces, a list of nonnamespaced objects (already has this), and now directives on what to place but not overwrite...  I see your point, but how is this any better than non-native kubernetes workload such as a bundle?
that said, if that's the only option provided, then I guess it has to be that way.  I think edgeplacement should be as automated as possible and only include exceptions like what is being proposed here.
Atop of this, it would be really good to know, somehow, definitively, what is being transferred to the syncer.  This is being discussed in a separate issue, but it is related.

Fixed by @yana1205. Thank you. Will test in upcoming release.

Reopening to allow for a test first with upcoming release.

@yana1205 I have tested and it appears the fix is not working.
For some reason, the ks syncer is not recognizing that the SA is satisfied and continues to make secrets over and over.  I cleaned up all 4 WECs and then I turned the replicaset to 0 for all 4 syncers. @yana1205 can you investigate why a serviceaccount continues to create secrets on the openshift clusters where they are deployed?  You can login to wec1,2,3 or 4 and then increase the replicaset to '1'.  The syncer will spin up and start syncing.  You can watch the following namespaces for secrets - "mcad", "default", "kuberay-operator", and "data-science" for the creation of multiple secrets stemming from applying a service account.  We won't lose clusters since I have paused the syncers for now.  If you start a syncer for testing, please make sure you turn it off when you are done.
did some testing  - I used the edge.kubestellar.io/downsync-overwrite: "false" in the annotation of each of the 4 service accounts that were causing multiple secrets to be created.  In each of the 4 cases, when i started the syncer (replicaset to 1) - the annotation was overwritten and the secrets started getting created again.  So, the annotation is great, but the annotation itself is being ignored for some reason.  If we can get this annotation to a) be applied automatically to any non-default service account and, b) be honored by the syncer and not overwritten, then I think we have a solution to our problem.  For now, I have put the syncer RS back to 0 for all WECs.

service accounts in the MB

this behavior seems to affect any service account that is not 'default' that are being synced by kubestellar.   I think we should set 'downsync-overwrite' to 'false' for any service account that fits this criteria.

works like a charm - Thank you @yana1205


Modify Contributors in README

As there was one point in PR template that added yourself as a contributor in readme so that I've made it in tabular format and comment is also there if someone wants to add.

Don't add the project admin section again.
Update only the contributors section.

Don't add the project admin section again.
Update only the contributors section.

Sure

Should I update it.. I'll not add it again, just few changes..

Okk

Don't change pic


How to compile with python API in release mode?

I tried to compile with python API on RPI like this:
pi@raspberrypi:~/dlib $ sudo python setup.py install --compiler-flags "-O3 -mfpu=neon --config Release"
running install
running bdist_egg
running build
Detected Python architecture: 32bit
Detected platform: linux2
Configuring cmake ...
-- The C compiler identification is GNU 4.9.2
-- The CXX compiler identification is unknown
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- broken
error: cmake configuration failed!

Not sure what is wrong?

--config Release isn't a gcc compiler switch.

Thanks for your REALLY quick reply..
How can I compile in Release mode?

The -O3 flag does that basically.
On Wed, 28 Jun 2017, 12:47 Open Source Hardware<EMAIL_ADDRESS>wrote:

Thanks for your REALLY quick reply..
How can I compile in Release mode?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/issues/662#issuecomment-311624719, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAu7nW9egSMqmg4z5-VaXdvSGld8w9aWks5sIi8rgaJpZM4OHy4J
.

Thanks a lot!


Do not load 'this' explicitly for class expression call target

We had a special case for when a class expression is emitted as a call
target which tried to load the 'this' value for the enclosing function.
Sometimes enclosing function has no 'this' binding (as in global
function or global lambda) which would mean there is no 'this' symbol
for us to load leading to null dereference.
Since class constructor cannot be called without the new keyword and we
always construct the value assigned to 'this' during function prolog,
there doesn't seem to be any reason at all to even load the 'this' value
here.
Fixes:
https://microsoft.visualstudio.com/OS/_workitems?id=14256595&_a=edit

Thanks, Tom.


Fix misc_beam collision

Send mins/maxs to client + fix the incorrect origin for the beam start, was using the origin of the misc_beam entity, when it should have used the origin of the entity marking the start of the beam. Fixes dodgy movement around Railgun cranes mostly.
This is not perfect as it only works for straight axial lines but I don't think it's possible to get an inline model registered for this so it cannot work correctly on arbitrary angles, it just gets a solid rectangle bbox always.
It also doesn't quite work perfectly in Railgun when the cranes start moving, but at least the collision box is now actually correct and somewhat accurate.

Seems to collision issue with Railgun cranes once they start moving is due to the fact that ent->s.pos.trBase doesn't get updated every frame, but only when the movement direction of the crane changes, need to figure out why that's the case.


feat(forecastle): update to v1.0.103

Align manifests with upstream
Update documentation
Add maintenance guide

Image synced in: https://github.com/sighupio/fury-distribution-container-image-sync/commit/2afb441bd30fc7c547c73da3e316787484a7c0db

closed in favour of #84


Update zio-1.0.10 zio-rs-1.3.5 scala-2.13.6

@jczuchnowski please review and merge.
thanks in advance

@jczuchnowski the changes were made
please feel free to merge it.
Thanks in advance.


Register on Bower

So as brought up by @diagramatics PR #34 , there is currently already a package register on bower under the name boneless, rish/boneless, and it appears as though the owner is just name-squatting.

Not necessarily only name-squatting, but just registering the name before getting a working version to publish with. That said, I'm not certain if package names are case-sensitive but we can try and register Boneless for now, name confusion and all.
The README.md should be updated to show the Bower installation procedures as bower install whatsnewsaes/Boneless for now before this issue gets closed.

We could go with boneless-framework or boneless-css
Also, I believe bower requires all names to be lowercase

I'd suggest against boneless-css as this isn't css but Sass, Would it be worthwhile sending rish a message to see if we can get the name off them????

That would be best if the name stays later on.

And this reminds me, I have to question about the use of -D or --save-dev as opposed to --save. Bower's devDependencies are rarely used since the packages are going to be bundled on the finished site later on. Any specific reason about this?

I use -D as apposed to --save with my Sass libraries, as imho there isn't any point of bundling up my sass source code, together with my finished site that I deploy to the server. To me Sass is a development dependency, not a dependency of the project when actually running on the web. So that is kind of the reasoning behind it.
as an example my bower.json files often look like this
  "devDependencies": {
    "breakpoint-sass": "~2.5.0",
    "skeleton-scss": "*"
  },
  "dependencies": {
    "angular": "~1.3.15",
    "angularfire": "~1.0.0"
  }

as angular & angularfire are "true" dependancies of the project (ie project doesn't work without them), and needs to be moved with everything else to the server, but skeleton-scss & breakpoint-sass are just things I use in development, and don't need to be brought across to the server.
Hopefully that explains my reasoning, behind the use of -D.

Ah, fair enough. I rarely see people using devDependencies in Bower, but that seems like a valid reasoning.

Yeah I don't see it happening a lot either, and I don't really get why (it's not used that is).

Ah, one more thing about the Bower file. We need a "main" on bower.json to define the main files to use from Boneless, which would be both boneless.scss and the mixins file?

@diagramatics have made some updates to the bower.json file in this commit 6971561ec24a599e82ee803cb4838ffb45099988 for now have only added boneless.scss to the "main" tag.

This is now registered on bower as of commit 7ebf295d66cbf1f9c35bbe1e8d8d96f312a565c0 and can be installed through bower install boneless-framework


Search for build.gradle within app_folder_name

Current globbing has the problem that it is not strict enough. In a React Native project for example, defining android/app as app_folder_name, it finds all build.gradle files contained in any android/app directory structure.
For example:

android/app/build.gradle
node_modules/node_modules/react-native-calendar/example/android/build.gradle

Ruby 2.2 returns:

android/app/build.gradle
node_modules/node_modules/react-native-calendar/example/android/build.gradle

Ruby 2.1 returns:

node_modules/node_modules/react-native-calendar/example/android/build.gradle
android/app/build.gradle

and therefore fastlane-plugin-increment_version_code modified the wrong build.gradle (it takes only the first result).
This PR tries to fix that, by globbing WITHIN app_folder_name.

any comment on this @Jems22?

Hello.
Thanks for your comment and your proposition.
I've tested your solution on my own project, but unfortunately, it doesn't work on my architecture (and probably not on the common Android architecture.)
I can add an optionnal property to the plugin to specify a unique gradle file to use. Do you think this solution could help you ?

Just out of curiosity, what is your environment/architecture? - we've tested it on macOS Sierra and Ubuntu 14.04.
An option to explicitly specify a build.gradle file would be another valid solution (and maybe the better one).

Hi.
After all this time, I have finally added the gradle_file_path property in the actions that let you set the relative path to the gradle file you want to modify.
Sorry for the long delay.


missing train.x train.y valid.x valid.y

After having runned stage 2:
python recasepunc.py tensorize input.case+punc input.case+punc.x input.case+punc.y --lang $LANG
I can't run stage 3 cause I didn't get train.x train.y valid.x valid.y
python recasepunc.py train train.x train.y valid.x valid.y checkpoint/path --lang $LANG
How can I get this files?

You have to create a train/valid/test Split and run the command on each of the subset.


v0.7.2

Setting up for bug fixes and other updated for v0.7.2
The primary fix in this release is for:

#1435 - updates to golang broke new installations.

Other fixes/improvements include:

#1429
#1419 various node/npm improvements
fix for #1436
#1443 to use compression when sending data to NS
#1438 convert_bg (for mmol/L users) in console.error logs

TODO before release:

[ ] Revert https://github.com/openaps/oref0/pull/1433/commits/21620183a582c395bd2255a0458684b9a93a6651

I guess I'd use wget to fetch a copy from GitHub directly.
On Sun, Sep 18, 2022, 4:31 AM Scott Leibrand @.***>
wrote:

@.**** commented on this pull request.
 What's the
proper way to do this now that go get is deprecated?
—
Reply to this email directly, view it on GitHub
https://github.com/openaps/oref0/pull/1433#pullrequestreview-1111508343,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALZHRO74EORHEPFGOD2DMTV63HPNANCNFSM5ZFUPWJA
.
You are receiving this because you were mentioned.Message ID:
@.***>

This should be ready for release now, to fix installs from master, unless anyone knows of any blockers.


Add the ability of ESO to reconcile only in scoped namespace

By default ESO reconciles Kind=ExternalSecret across every namespace
in a k8s cluster. With the new flag --nameespace we can scope the
reconciling only to the provided namespace.
Ticket: #289

@moolen have a look

/ok-to-test sha=49247d2

this LGTM! Looking at the AC of the issue it seems done also. Gonna mark it as approved and wait if moolen can also have a look. If he is unavailable until next week I merge this on Monday or Tuesday.

/approve

/ok-to-test sha=5e3b2a0

Hey, sorry i was sick the past 2 weeks :/
This looks good to me, thank you for picking this up!
For the future we may want to have dedicated RBAC roles for a ESO when using scopedNamespace that restrict reading/updating secrets to a particular namespace. But it is totally fine for now to have one ClusterRole.

/merge

/merge

:thinking:

+1 to have dedicated RBAC role configuration for scoping ESO to specific namespaces


IRS2 web service to expose results in different formats

.. e.g. similar to the existing text search API.

Done as api.py (except for #6)


Disable internal FXAA mod makes map cave icons not show up for newly discovered caves

Mod list:

The map cave icons are not showing up whenever I discover a new cave. After some troubleshooting, i found that the internal FXAA disable mod is the culprit. Without it the icons show up. With only it the map icons don't. Game ver 1.1.0
mods from the 1.5.4 release save for the LOD mod, which's from the 1.5.5 release

thanks you for report, while you have too much mods i can't add it as a known bug
i'm not supposed to support piracy, the file of your rom is clearly a crack
anyway FSR sharpener disabler is useless alone

yeah using by itself does make the icons not show up

yeah using it by itself makes the icons not show up
I understand the stance on piracy. I do own the game however i'm not really confortable doing all the shit to get it on pc, and i hate how it runs on og hardware
the FSR thing I don't get, i have both the sarpener and downscaling disabler, am i missing another fsr mod cause i don't see it on the zips

Are you using yuzu or ryujinx!

yuzu

Let me add this is also the case for me on Yuzu, tried with no mods and it works fine, tried with the Disable Internal FXAA mod on and new locations are no longer discovered and they do not show up on the map/minimap. This is quite annoying and borderline make it unusable unless you have already discovered all the locations. This happens to all new locations too, not just caves.

I can also confirm that my map was not updating until Disable internal FXAA was removed. I have tested with only this mod enabled and the problem persists until I disable the mod again.
Game version 1.1.1
Yuzu 3599

Thank you for the reports, I've updated the FXAA mod to a new version. My testers found no issues with it anymore. Please open a  new issue if you do find another bug. Thank you!

@Dark-talon Can I ask which method you used to resolve this? I cannot replicate the problem but I've been getting the same reports with one of my mod releases.


Fix usage of PlainSerializer with builtin types

Change Summary

Related issue number
Fixes #9447
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @alexmojaki

Please review

@Viicos, looks like some tests are failing?

@sydney-runkle On PyPy, inspect.signature is able to get the signature of str:
<Signature (object=<no value>, encoding=<no value>, errors=<no value>)>
As the _serializer_info_arg function does not really take into account arguments with default values, it fails to determine if the info argument is required. I'll open a new issue with a clear example, in the meanwhile I disabled the test on PyPy so that this one can be merged.


Identifier Splitting & Measurement Normalization

Overview
This pull request adds the ability to split identifiers into sections and then insert the default database and retention policy as needed. This does not include the functionality to "guess" at databases or policies yet. That will come in a future PR.
Identifier Splitting
Identifiers are now split up into segments. A segment can either be a quoted string or a bare identifier. A bare identifier is unquoted and can only use alphanumeric characters and underscores.
For example, the following is a mix of string and bare ident segments:
"my_db"."raw".cpu  -> []string{"my_db", "raw", "cpu"}

Empty sections between dots can be used instead of an empty string too:
"db"..cpu -> []string{"db", "", "cpu"}

Measurement Normalization
The Measurement objects in a statement can be normalized by the Server. This process involves the following steps:

Expand identifiers to exactly 3 segments: db, policy & measurement
Use default database, if not specified.
Use default policy on database, if not specified.

Once the measurements are normalized, the VarRef nodes in the AST are updated to use the new prefix. For example, this statement:
SELECT cpu.value FROM cpu

would get normalized to this (assuming the default database is mydb and that database's default policy is myrp):
SELECT cpu.value FROM "mydb"."myrp"."cpu"

then the prefix of the cpu.value would also get updated:
SELECT "mydb"."myrp"."cpu"."value" FROM "mydb"."myrp"."cpu"

Caveats
This pull request doesn't update the parser to join dot-separated strings/idents together. That will come in a future PR.

LGTM, just that one Temp part that I was curious about.


Prisma bumped to 2.9.0, Vulnerability Fixed

Bumped Prisma version to 2.9.0.
Ran npm audit fix, to fix a vulnerability.

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


I can't link the release version after update to the new svgren version

Hi,
after the update to the new version I had to change some parameter names (why is the bgra option removed).
The debug version runs fine and at the first view I couldn't find any differences to the cairo based version.
With linking the relase version of our software I get this error:
LINK : fatal error C1047: The object or library file 'K:\sae\nfs\software\packages\zlib_static.<IP_ADDRESS>\build\native\..\..\\build\native\lib\Win32\v142\Release\MultiThreadedDLL\zlib.lib' was created by a different version of the compiler than other objects like 'K:\sae\nfs\software\packages\libcssdom.0.1.10\build\native\..\..\\build\native\lib\Win32\v142\Release\MultiThreadedDLL\libcssdom.lib'; rebuild all objects and libraries with the same compiler
Please help to get this fixed. Otherwise I have to revert to the old version of svgren.
Thanks!

Looks like I need to rebuild the zlib_static nuget package with updated SDK version, will do this today evening.
The BGRA option was removed because it seems like it is out of the API's scope.
If you need to convert to BGRA image this can easily be done as follows:
auto res = svgren::render(*dom, params);

// swap red and blue channels
for(auto& c : res.pixels){
    c = (c & 0xff00ff00) | ((c << 16) & 0xff0000) | ((c >> 16) & 0xff);
}

Ok, I remember that this is what you did inside of render and to save a double swap you introduced the BGRA option.
I already do the swap right now.
Would be great to solve the link problem. I use version 16.8.2 from VS2019.

I have rebuilt the zlib_static and libpapki packages against latest SDK version. Please update your packages and try again.
New package versions:
zlib_static: <IP_ADDRESS>
libpapki: 1.0.85
The rest of the packages are already built against latest SDK.
Let me know if it helps or not.
I could not reproduce exact your problem, but I could reproduce something very similar with my project, and unfortunately, rebuilding those packages did not solve it. I will continue investigation.

Hi Ivan,
thank you very much for your great support. Your changes worked for me, everything looks fine now!
I can swap to the new agg based library now.

That's great that it worked for you! Thanks for reporting the problem!

Just for information, I got this message on a VS2019 Installation with 16.7.7 Version on ist:
LINK : fatal error C1900: Il mismatch between 'P1' version '20200803' and 'P2' version '20190715' [E:\sae\nfs\jenkins\trunk\software\workspace\Setit.vcxproj]
  LINK : fatal error LNK1257: code generation failed [E:\sae\nfs\jenkins\trunk\software\workspace\Setit.vcxproj]

After updation to the actual version 16.8.2 everything linked fine


Leakage during Heap StackTrace construction for a deep-stack application

If your application has 16-function deep (or deeper) of a backtrace or more, then this one is for you.
When the stacktrace gets outputted into the STDERR file by application's libtcmalloc library, sometimes the stacktrace get truncated at 800 character per program address' worth of backtraces. Sometime, maybe 16 to 18 lines of stacktrace with the last line were truncated. If it gets truncated, this appears to be a live memory leak caused by gperftools.
I fixed this by expanding the kBufSize in heap-profile-table.cc:590 by changing from the 10 value into an 11. :
static const int kBufSize = 2<<11;

Rebuild and reinstall, then restart my app again. No more leak by gperftools. Of course, this leakage only occurs when doing formatting of backtraces requiring more than 2<<10 of string space.

Can you please provide sample program ? I'm unable to see how size of that buffer may affect leaking.

Well, the sample is a production software using Bro.
But one should be able to recreate it by a small test C source code having some 50 functions, all with at least 24 characters each.
I should point out that the leakage is only occurring during the backtrace printing of its very deep stack.
Steve

On Oct 10, 2015, at 14:04, Aliaksey Kandratsenka (aka Aliaksei Kandratsenka<EMAIL_ADDRESS>wrote:
Can you please provide sample program ? I'm unable to see how size of that buffer may affect leaking.
—
Reply to this email directly or view it on GitHub https://github.com/gperftools/gperftools/issues/729#issuecomment-147113174.

That's fine. But in order to help I'll need at a bit more details. What makes you think it's leaking ?

Closing stale ticket.
Please reopen of you're able to provide more info.


[Muhammad Hassan]

Profile screenshot

Closure Notice: This profile is being closed either because it has already been added or because no PR has been created. Please feel free to reopen and initiate a PR if the profile has not been added yet.


[WIP] Cgo support (base on Go compiling workflow)

Implement "Approach 2: Reuse Go compilation process, implement LLGo as a GO's compile tool" of Proposal: LLGo-CGo Implementation

[ ] go build workflow

[x] build.sh for prototype
[ ] rewrite with go

[ ] port and rewrite cgo command

[x] port cgo command code
[ ] rewrite output template
[ ] runtime/cgo

[ ] wrap LLGo as command command

[x] support -pack
[x] support -asmhdr (mocking for asm compiling)
[ ] support -+

[x] link command
[ ] solve conflicts

[ ] llgen work with overlaps and patches
[x] patch std

try another way.


[Audit Logging] End2end test for audit logging in authorization policy

I generated a new client key and cert where a Spiffe ID is added as the URI SAN. As such, we are able to test the audit log contains the principal correctly.
As for the test strategy, a test logger is registered to check the log count only and the log content is verified in details via the built-in stdout logger.

Bazel RBE Windows Debug C/C++ has been consistently failing and it seems like the captured stdout failed to be unmarshaled into a valid json. This is difficult to troubleshoot as I don't have a windows machine (and running RBE Windows locally needs it as well).
I think I will switch to use the test logger to verify the log content and have to ditch stdout logger here.

Would it make sense to name it authz_audit_logging_utils?

We have public headers simply named grpc_audit_logging.h or audit_logging.h so I don' think it's strictly necessary. But let me know if you feel strongly about making this clear and I am open to changing it accordingly. @erm-g

Would it make sense to name it authz_audit_logging_utils?

We have public headers simply named grpc_audit_logging.h or audit_logging.h so I don' think it's strictly necessary. But let me know if you feel strongly about making this clear and I am open to changing it accordingly. @erm-g

Yeah in this case I think I'm fine


Callum Elder ViT Model

This is an initial inspection, no action is required at this point
Difficulty: Hard
Readme:
Need to show what the model performance is in numbers
Commit messages: Excellent, detailed.
Code:

Uses Vision transformer
Well commented
Good model design

Functionality/Performance:

No test result plot or text explained in the readme
Preprocssing data correctly
Model is underfitting, need to train more.
Did patient level split.
Well done

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage, no test plot -1
Module present
Commenting
No Data leakage
Difficulty: Hard
Commit Log
Meaningful commit messages sometimes -1
Progressive commits used
Documentation
ReadMe acceptable/good
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description missing -2

Merging requires restoring repo README. Does not affect grade only merge

No feedback attempt and no feedback marks lost.


Adding pod configuration file with names

Adding pod configuration file with pod and container name. This shows an example of names and how it looks like in YAML.

/approve
/lgtm


UnicodeDecodeError: 'ascii' codec can't decode byte 0x85 in position 0: ordinal

Typing class Test(object<tab> :

class Test(objectTraceback (most recent call last):
  File "C:\Python27\Scripts\ptpython-script.py", line 9, in <module>
    load_entry_point('ptpython==0.4', 'console_scripts', 'ptpython')()
  File "C:\Python27\lib\site-packages\ptpython\entry_points\run_ptpython.py", line 62, in run
    no_colors=no_colors, startup_paths=startup_paths)
  File "C:\Python27\lib\site-packages\ptpython\repl.py", line 208, in embed7.8
    repl.start_repl(startup_paths=startup_paths)
  File "C:\Python27\lib\site-packages\ptpython\repl.py", line 51, in start_repl
    on_exit=AbortAction.RAISE_EXCEPTION)
  File "C:\Python27\lib\site-packages\prompt_toolkit\interface.py", line 290, in read_input
    next(g)
  File "C:\Python27\lib\site-packages\prompt_toolkit\interface.py", line 356, in _read_input
    loop_result = self.eventloop.loop()
  File "C:\Python27\lib\site-packages\prompt_toolkit\eventloop\win32.py", line 44, in loop
    keys = self._console_input_reader.read()
  File "C:\Python27\lib\site-packages\prompt_toolkit\terminal\win32_input.py", line 121, in read
    key_presses = self._event_to_key_presses(ev)
  File "C:\Python27\lib\site-packages\prompt_toolkit\terminal\win32_input.py", line 141, in _event_to_key_presses
    result = KeyPress(ev.AsciiChar.decode('ascii'), ev.AsciiChar.decode('ascii'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0x85 in position 0: ordinal
not in range(128)

I'm a windows with a french locale with Python 2.7. Remember, for your software to deal with non ascii characters :

use utf8 for all files;
use "from future import unicode_literals" for all files
when you got an input, use your_input.decode(input_encoding). User input, sql query, file reading, downloads are all inputs.
when you got an ouput, use your_ouput.encode(output_encoding). Terminal printing, sqlquery, writting in a file, HTTP post are all outputs.

Thanks for reporting! (And the explanation!)
I have to improve Windows support indeed. If you are able to write a patch, that's much appreciated.
Otherwise, I will try to figure this out myself, because it really is important.

Hi Jonathan,
@darkig has been looking into this issue from the pgcli side (https://github.com/dbcli/pgcli/issues/171) and got as far as this:

Last time I tried looking into this, I got as far as this. It's calling ReadConsoleInputA, specically requesting an ascii character. According to this (linked in the comments there), it should be possible to replace that call with ReadConsoleInputW instead, but I got in over my head there with C types and gave up.

Thought it might help you narrow this down further.

Thanks @amjith and @darikg,
I hope to find some time this weekend to fix this issue.
ReadConsoleInputW could indeed be the answer.
Jonathan

I think this is fixed now: https://github.com/jonathanslenders/python-prompt-toolkit/commit/35045205fcdb5389d99ef83a716ffdb8e8b4ff03
Windows is weird. The output encoding is cp437 while the input encoding is cp1252. But it seems to work now. It doesn't handle all unicode characters (I think the windows console doesn't even support it), but é works fine for instance.

Hi all,
This should be fixed, so I'm closing it.
A new Pypi release has been done. Please reopen or create a new issue when this still occurs.
Jonathan


@interface type references do not always link correctly.

TypeDoc's type convert doesn't appear to always capture symbols related to types when converting references.
Search terms
zod, type reference, inferred type
Expected Behavior
The produced Bar interface should have a member whose type is Color, which is linked to the enum.
Actual Behavior
The produced Bar interface contains a member whose type is Color, without a link to the Color enum.
Steps to reproduce the bug
export enum Color {
    BLUE = "Blue",
    RED = "Red",
}

type TypeOf<T> = {
    [K in keyof T]: T[K][keyof T[K]];
};

type Foo = {
    color: typeof Color;
};

/** @interface */
export type Bar = TypeOf<Foo>;
//   ^?

Environment

Typedoc version: 0.25.8
TypeScript version: 5.3.2
Node.js version: 20
OS: Fedora

Initial investigation here indicates that TypeDoc is doing the right thing. Tossing that into https://ts-ast-viewer.com, clicking on Bar, and running checker.getTypeOfSymbolAtLocation(checker.getPropertiesOfType(type)[0]) returns a ts.Type whose aliasSymbol is not set.
TypeScript obviously knows what the type should be named here though, so I've asked in the #ts-compiler-api channel on the TS discord, maybe one of the TS devs will tell me what incantation is necessary to extract this info.


Add setting to turn on MFA

This PR adds the setting for MFA to the settings page; see https://github.com/inventree/InvenTree/pull/2221

@matmair could you also please add:

A note to release/0.6.0.md referencing this new feature
A small section documenting the 2FA feature (screenshots, how to, etc)

Just a couple of small spelling changes :)

@matmair good to go, or you want to add more?

@matmair good to go, or you want to add more?

@SchrodingersGat still testing/fixing some fringe cases for MFA. Would only merge after MFA is merged into the main codebase.

@SchrodingersGat should b good to go!


Allocation profiling crashes on Azul Platform Prime

Hello Async profiler developers!
async-profiler version: at least 2.8.3
Prime (Zing) version: 22.07 JDK11+
We observe a crash in our internal testing with the following backtrace:
0  0x00007f63f3354f47 in raise () from /lib/x86_64-linux-gnu/libc.so.6
1  0x00007f63f33568b1 in abort () from /lib/x86_64-linux-gnu/libc.so.6
2  0x00007f63f0e46f2f in os::abort (dump_core=dump_core@entry=true, out_of_memory=out_of_memory@entry=false) at src/os/linux/os_linux.cpp:3248
3  0x00007f63f1775162 in VMError::report_and_die (this=this@entry=0x7f63e9dfead0) at src/share/utilities/vmError.cpp:1119
4  0x00007f63f174506b in report_vm_error (file=file@entry=0x7f63f2494ff0 "src/azshare/gc_implementation/shared/lvb.hpp", line=line@entry=202, error_msg=error_msg@entry=0x7f63f2494fb0 "assert0((!VerifyJVMLockAtLVB) || verify_jvm_lock()) failed",
detail_msg=detail_msg@entry=0x7f63f2494f78 "[(!VerifyJVMLockAtLVB) || verify_jvm_lock() expected]", error_type=error_type@entry=INTERNAL_ERROR) at src/share/utilities/debug.cpp:257
5  0x00007f63f17449b2 in report_vm_error (file=file@entry=0x7f63f2494ff0 "src/azshare/gc_implementation/shared/lvb.hpp", line=line@entry=202, error_msg=error_msg@entry=0x7f63f2494fb0 "assert0((!VerifyJVMLockAtLVB) || verify_jvm_lock()) failed",
detail_msg=detail_msg@entry=0x7f63f2494f78 "[(!VerifyJVMLockAtLVB) || verify_jvm_lock() expected]", error_type=error_type@entry=INTERNAL_ERROR) at src/share/utilities/debug.cpp:259
6  0x00007f63f0a7890a in LVB::lvb<(OopHelper::EncodingHint)1> (addr=0x7f63e9dffa58) at src/azshare/gc_implementation/shared/lvb.hpp:202
7  LVB::lvb<(OopHelper::EncodingHint)1> (addr=0x7f63e9dffa58) at src/azshare/gc_implementation/shared/lvb.hpp:80
8  lvb_methodOop_stack_addr (addr=0x7f63e9dffa58) at src/azshare/gc_implementation/shared/lvb.hpp:174
9  frame::interpreter_frame_method (this=) at src/share/runtime/frame.inline.hpp:98
10 0x00007f63f148d680 in vframe::method (this=0x7f63e9dfed40) at src/share/runtime/vframe.inline.hpp:153
11 JvmtiEnvBase::get_stack_trace (this=this@entry=0x0, java_thread=java_thread@entry=0x620000000000, start_depth=, max_count=max_count@entry=2048, frame_buffer=frame_buffer@entry=0x7f62b40f91b0, count_ptr=count_ptr@entry=0x7f63e9dff1b0)
at src/share/prims/jvmtiEnvBase.cpp:896
12 0x00007f63f1478734 in JvmtiEnv::GetStackTrace (this=0x0, java_thread=0x620000000000, start_depth=0, max_frame_count=2048, frame_buffer=0x7f62b40f91b0, count_ptr=0x7f63e9dff1b0) at src/share/prims/jvmtiEnv.cpp:1806
13 0x00007f63e93ddf6d in Profiler::recordSample(void*, unsigned long long, int, Event*) () from /src/work/agents/async-profiler-2.8-linux-x64/build/libasyncProfiler.so
14 0x00007f63e93de7ec in ObjectSampler::recordAllocation(_jvmtiEnv*, int, _jclass*, long) () from /src/work/agents/async-profiler-2.8-linux-x64/build/libasyncProfiler.so
This backtrace is from debug build of Prime. On release builds it is also reproducible.
Root cause is getJavaTraceInternal called in a wrong thread state. This API assumes thread state to be "in VM" while when thread comes from object allocation sampling jvmti callback its state is "in native".
getJavaTraceJvmti is the right API for this state.

getJavaTraceInternal was intended for HotSpot only.
It is a bug that it's called in Zing, I'll fix that.

Thanks for reporting. The fix is committed.


Homework 2

Drift video link - https://video.drift.com/v/abQURMqvQG6d8fY0shLY6xJ4IBB7LSV1WSA99B5UOMsCM/
The topics covered were :-
-> packages
-> strings
-> logger
Below are the screenshots of the log info that I recieved upon running the scripts

![Screenshot 2024-01-09 232600](https://github.com/kirtipadhi0kickdrum/kdu-coursework/a

ssets/155990562/5872006f-eb85-4a6d-9a91-a858b2081360)

Metric
Value

alert_status
:x: ERROR

bugs
0

code_smells
54

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Its actually doing the sonal analysis of project 1 automatically, where i have changed the workflow also

Metric
Value

alert_status
:white_check_mark: OK

bugs
2

code_smells
32

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:white_check_mark: OK

bugs
2

code_smells
32

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


[WIP] kernel : make build reproducible

Set kernel build variables and configs to static value to make kernel build bit by bit reproducible.
This is prerequisite to make #3116 happen.
When this is pruned and accepted, I will add to this PR another commit with similar changes for new-kernel.

Looks like some variable is empty since the build fails with
time="2023-04-18T16:43:53Z" level=fatal msg="Failed to extract kernel image and tarball: Could not pull image docker.io/library/-arm64: error getting manifest for trusted image docker.io/library/-arm64: GET https://index.docker.io/v2/library/-arm64/manifests/latest: unexpected status code 404 Not Found: 404 page not found\n"
(Notice "/-arm64".)

make pkgs eve

just works fine locally, looking into it...

I compared it with another kernel build on github and everything seems similar except the that one succeeds, @deitch any idea why linuxkit fails?

not sure, is test fail related to my PR or it just fails anyway?

not sure, is eden test fail related to my PR or it just fails anyway?

Kicking them again, but a more basic problem is that the build fails on your PR. See https://github.com/lf-edge/eve/actions/runs/4752404302/jobs/8445069777?pr=3157

There is complain about missing build.yml on make eve in github report (thanks @rouming for pointing it out), the problem is in my local build the yaml file generate at make pkgs will remain on disk for the next stage, but in github build is not the same, so need to generate the kernel build.yml for make eve too.

@eriknordmark if this is acceptable, I will send another commit for new-kernel.

there is also cpio mtime which I need to set to fixed value, I will add another commit to this PR for that.


SAK-33278 spring 4.3.10

https://jira.sakaiproject.org/browse/SAK-33278

cglib 3.2.5 is neded for this version of spring.


Improve developer experience of one-time setup in Windows environment

The utility scripts using Azure CLI are written in bash, which may often require additional hurdles in Windows. For example, Git Bash will not work with default Azure CLI configuration, and not all users opt for WSL (which itself may not work out-of-the-box). Hence, it makes sense to provide the scripts also in PowerShell.

Good point. Especially considering that many of the people using this would be windows users. How about we make a docker container with all dependencies baked in? That will prevent toolchain installation completely and we don't have to then maintain two versions of essentially same commands. Docker on windows have improves substantially so that should be ok.


Custom Renderer and RT

Currently when rendering the default pass we do setTarget(null), which prevents to override render in the following way:
override function render() {
        var target = allocTarget("tmp");
        setTarget(target);
         // render to target
        super.render();
         // post process
 }

We need instead to manage the RT in a better way, for instance each pass should switch back to the previous RT when finished. In order to minimize the actual number of RT switches, some optimizations are required at the driver level.

Agreed. that what we do manually.
2015-03-14 12:25 GMT+01:00 Nicolas Cannasse<EMAIL_ADDRESS>
Currently when rendering the default pass we do setTarget(null), which
prevents to override render in the following way:
override function render() {
var target = allocTarget("tmp");
setTarget(target);
// render to target
super.render();
// post process
}
We need instead to manage the RT in a better way, for instance each pass
should switch back to the previous RT when finished. In order to minimize
the actual number of RT switches, some optimizations are required at the
driver level.
—
Reply to this email directly or view it on GitHub
https://github.com/ncannasse/heaps/issues/98.

--
David Elahee

Done in 6b9fab120b4191aae0c26dcb73e453dc983fa40a

Awesome !
2015-11-22 12:17 GMT+01:00 Nicolas Cannasse<EMAIL_ADDRESS>
Done in 6b9fab1
https://github.com/ncannasse/heaps/commit/6b9fab120b4191aae0c26dcb73e453dc983fa40a
—
Reply to this email directly or view it on GitHub
https://github.com/ncannasse/heaps/issues/98#issuecomment-158748002.

--
David Elahee


Simplest change to support multi-column sorts a la react-datagrid (cy…

…cle through ascending, descending, no sort, independently for each column).

Can you fix those linting errors and write basic docs (docs/sorting_table.md)?

Thanks, will do tomorrow.
-Jeff
On Fri, Jan 29, 2016 at 2:20 PM, Juho Vepsäläinen<EMAIL_ADDRESS>wrote:

Can you fix those linting errors and write basic docs (docs/
sorting_table.md)?
—
Reply to this email directly or view it on GitHub
https://github.com/bebraw/reactabular/pull/127#issuecomment-176920166.

I addressed the lint and doc issues - please let me know if there's something else to update.

Thanks! Just published a new version with the feature in it.
Over longer term this logic might go to a package of its own as it's not tied to Reactabular itself. That will bring down the size of the dist build a notch as well. Now the minified version is around 13.7k which isn't too bad.

Thanks, that makes sense. I appreciate the quick review / approval on the
pull request!
-Jeff
On Sun, Jan 31, 2016 at 1:18 PM, Juho Vepsäläinen<EMAIL_ADDRESS>wrote:

Thanks! Just published a new version with the feature in it.
Over longer term this logic might go to a package of its own as it's not
tied to Reactabular itself. That will bring down the size of the dist build
a notch as well. Now the minified version is around 13.7k which isn't too
bad.
—
Reply to this email directly or view it on GitHub
https://github.com/bebraw/reactabular/pull/127#issuecomment-177569333.


Int value properties for NSNumbers, in Swift

Feature Request
One thing I love about Mogenerator for ObjC is the auto generated primitive properties that unwrap NSNumbers
Are you planning on doing this for Swift? Ive started doing the following in the 'human' classes, but it'd be great to have it automatically built into the machine classes
    var identifierValue: Int? {
        get {
            if let identifier = self.identifier as NSNumber? {
                return identifier.integerValue
            }
            else {
                return nil
            }
        }
        set {
            if let intVal = newValue as Int? {
                self.identifier = NSNumber(int: Int32(intVal))
            }
            else {
                self.identifier = nil
            }
        }
    }

See ticket #302 for a bit of discussion on this. I have been a bit stuck with other responsibilities to deal with it lately, but we're trying to find a way to make mogen a better Swift player.

Thanks


General Image handling

[ ] Sorting images
[x] deleting images
[ ] Thumbnail generation on save
[x] Setting new saved images to visible

requires #15

Closing this with separate issues for #31 and #32


Provide feature to edit m4s video file

I want to extract frames from m4s file and edit them before it send to client please respond quickly
<EMAIL_ADDRESS>

Extracting a frame is not the scope of this project!

Can you give me information to how to do it
On Sun, 25 Oct, 2020, 8:55 PM Amin Yazdanpanah<EMAIL_ADDRESS>wrote:

Extracting a frame is not the scope of this project!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aminyazdanpanah/python-ffmpeg-video-streaming/issues/39#issuecomment-716165558,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP54EYHP52CTRQI4BMGDIGTSMQ7NXANCNFSM4RUJZ6PQ
.

Run the following command in your terminal:
ffmpeg -i path/to/video.mp4 -r 1/1 $filename%03d.jpg

see the link below for more information:
https://ffmpeg.org/ffmpeg-formats.html#image2-2


Add support for Windows 11

In Windows 11, old icons look out of place.

Can you add support for Windows 11, please?

Right okay, a new/different icon set.
I'll have to add support for it.

Give the 1.2.0 release a shot.

checking it out

Works like a charm. Thanks a bunch 😄


Gh 1003 required annotation

Codecov Report

Merging #1004 into develop will increase coverage by 10.07%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             develop    #1004       +/-   ##
==============================================
+ Coverage      63.58%   73.65%   +10.07%
+ Complexity      1041       78      -963
==============================================
  Files            500      141      -359
  Lines          14602     4886     -9716
  Branches        1644      562     -1082
==============================================
- Hits            9284     3599     -5685
+ Misses          4608     1055     -3553
+ Partials         710      232      -478

Impacted Files
Coverage Δ
Complexity Δ

...mulostore/operation/hdfs/operation/SplitTable.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...n/javardd/ImportKeyValueJavaPairRDDToAccumulo.java
89.47% <ø> (ø)
8 <0> (ø)
:arrow_down:

...ation/hdfs/operation/SampleDataForSplitPoints.java
98.21% <100%> (+0.03%)
0 <0> (ø)
:arrow_down:

...va/uk/gov/gchq/gaffer/data/element/Properties.java

...mplementation/raw/CompactRawIntegerSerialiser.java

...ain/java/uk/gov/gchq/gaffer/data/element/Edge.java

...inaryoperator/RBMBackedTimestampSetAggregator.java

...sketches/theta/binaryoperator/UnionAggregator.java

...java/uk/gov/gchq/gaffer/mapstore/impl/MapImpl.java

...ffer/rest/mapper/GafferRuntimeExceptionMapper.java

... and 334 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a0da32...b812d21. Read the comment docs.


landscape.io

this needs to be setup so that the badge works and we get notifications regarding code health.

Done


Added VersaPlayer to Video section

Added VersaPlayer to Video section
Project URL
https://github.com/josejuanqm/VersaPlayer
Category
Video
Description
Added VersaPlayer to Video section
Why it should be included to awesome-ios (mandatory)
This is a new versatile AVPlayer implementation for iOS, able to extend via VersaPlayerExtension
Checklist

[x] Only one project/change is in this pull request
[x] Has unit tests, integration tests or UI tests
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 4 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 3 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

1689
301
https://github.com/VirgilSecurity/virgil-foundation-x redirects tohttps://github.com/VirgilSecurity/crypto-x

2048
404
https://github.com/shubh10/JustHUD

2629
301
http://holko.pl/2016/01/05/typed-table-view-controller/ redirects tohttps://holko.pl/2016/01/05/typed-table-view-controller/

  Generated by :no_entry_sign: Danger

Hey @josejuanqm, congrats on the lib and thanks for contributing! Unfortunately we cannot merge your PR yet because VersaPlayer doesn't have unit or UI tests. Feel free to contact us if you need any help with the tests and reopen the PR once the tests are done.

Hi @lfarah thanks for the feedback, ive created a few simple unit tests, would that be enough?


doubling underscores in URLs

metamath-knife produces an error on the following:
    $( A singleton is linearly independent iff it does not contain a torsion
       element.  According to Wikipedia ("Torsion (algebra)", 15-Apr-2019,
       ~ https://en.wikipedia.org/wiki/Torsion_(algebra) ):  "An element m of a

The error is:
warning: Invalid escape character
      --> set.mm:740600:47
       |
740600 |        ~ https://en.wikipedia.org/wiki/Torsion_(algebra) ):  "An element m of a
       |                                               - This escape character should be doubled
       |
       = note: This character has special meaning in this position, but it was not interpretable here.
       = note: Use ~~ or [[ or `` if you mean to include the character literally

However, underscores don't need to be doubled in URLs, do they? At least, if I use the metamath-exe SHOW STATEMENT/ALT_HTML to produce a web page, the undoubled underscore turns into an underscore here, and the doubled underscore turns into a doubled underscore (which is not what we want).

According to @digama0's comment in #129, basically, underscores in URLs should be doubled.
Then this would not be an issue.


Troubleshooting guide FAQ version

Description
Update the troubleshooting guide to include specific problems and their solutions in a Q&A format.
explain about some common troubleshooting scenarios, as FAQ
for eg:
a. I send a search request from BAP, but did not get a response, how do i troubleshoot the issue
b. I send a search request i got a NACK
c. i send a search request, i got a schema validation error

The troubleshooting guide is available here https://github.com/beckn/missions/blob/main/docs/troubleshoot.md