adds check for 0.29 MainApplication.java

rnpm aka react-native link is broken with Android 0.29 - #8603
This gets it back to working again by checking for new MyApplication.java file, and curtailing the path when needed.

By analyzing the blame information on this pull request, we identified @grabbou to be a potential reviewer.

note, the methodology for checking the file is the latest method: http://stackoverflow.com/questions/4482686/check-synchronously-if-file-directory-exists-in-node-js

cc @Kureev

Hi @GantMan! Thanks for proposing this PR! I have a few small questions in order to process it faster :)
As I see, you're checking for a MainApplication.java and "roll back" to MainActivity.java in a case if it's not found. But taking into account that rnpm is now a part of react-native cli, I think we don't have any cases to support any previous versions. Does it make any sense?

Hi @Kureev!   My guess use case where someone would care is this:  "I created project X in RN 0.28 and I created project Y in 0.29".   I should be able to still work on my 0.28 project and even use react-native link to add new features to it.   It shouldn't break functionality on my non-updated project.   I might have good reason for not bringing it to 0.29 just yet.

May be support old versions for few releases and then drop the support.

Yeah, ideal would be 3 phases.

this goes through as hotfix.
deprecate, and warn
remove

I'm happy to help with all 3 steps.

@GantMan For your case with 0.28 & 0.29: if I understand correctly, app scaffolded by 0.28 will have a<EMAIL_ADDRESS>with current react-native link implementation under the hood. Same is fair for 0.29: it'll have a new 0.29 react-native with new link for MainApplication. The only controversial point is about react-native upgrade. Does it convert your MainActivity to MainApplication? If so, then I don't see a reason why we need prev. versions.
If 0.28 to 0.29 migration by using react-native upgrade wouldn't rename MainActivity to MainApplication, then we need to add it as a part of the migration (which is a desired behavior imo) or support N releases behind the last one (for react-native link).

if I understand correctly, app scaffolded by 0.28 will have a<EMAIL_ADDRESS>with current react-native link implementation under the hood

@Kureev is right. I forgot that the cli just forwards the commands to locally installed react-native. So we should not need check for older versions in the code.

I will update accordingly, you'll see code soon :)

@Kureev  and @satya164 -  Thanks for the feedback.
I wasn't sure what the userConfig variable should be, but I figured consistency with the internal name would be best.   We don't want users setting userConfig.mainActivityPath and thinking that's correct.
I did a quick test, and upgrade from 0.28-> 0.29 does NOT create the application file.  It's set as manual steps in the release: https://github.com/facebook/react-native/releases/tag/v0.29.0

@GantMan Can you also update the commit title to reflect the actual change?

@GantMan Yes, react-native upgrade doesn't work for 0.28 - 0.29 and it'll probably be very complex to fix this since we're using yeoman for this.

@satya164 - title is updated.
Hah yes, yeoman is quite tricky.  Fortunately it's a separate concern. I was just checking for @Kureev as he seemed to inquire specifically on this upgrade path.   Let me know if there's more on this ticket that needs attention.

I don't think there is anything else. Seems you covered everything, @GantMan 😉

So, I'm going to check it on my local machine today and if everything is fine, I'm about to merge it

Great work! I like it. Another thing is that we remove mainActivityPath now, which could potentially break plugins, but since there's no need to use main activity anymore on the Android side, I think it's fine.

@facebook-github-bot shipit

@grabbou we'll notify users in the release notes 👍 Good catch!

Thanks for importing. If you are an FB employee go to Phabricator to review.

@mkonicek shall we release a 0.29.1 and also cherry-pick that into 0.30rc? @Kureev

@grabbou There was a bug in InteractionManager which we should also include. cc @sahrens

@satya164 into the 0.29 or 0.30 branch?

@grabbou Both

Ping me on Messagner later just in case

Sorry, still waiting on review. If you need to patch locally, the fix is a one-liner, just change the filter call in TaskQueue#cancelTasks from .filter((queue) => queue.tasks.length > 0); to:
.filter((queue, idx) => (queue.tasks.length > 0 || idx === 0));

We missed one change here! Since we renamed mainActivityPath to mainFilePath, it should be also changed in the userConfig object. Want to hotfix, @GantMan?

Seems this is a real scope of the change: https://github.com/facebook/react-native/search?utf8=✓&q=mainActivityPath. Hopefully, it's just about find . -type f -exec sed -i 's/mainActivityPath/mainFilePath/g' {} +

see referenced PR for more info.

Glad to know I wasn't insane. When are you guys going to finish fixing this?

Looks good @Kureev.
@rclai - look at PR #8807
Let me know if I can help any further.


Remove unnecessary hierarchies

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 5 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.05%) to 92.015%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
2420

Relevant Lines:
2630

💛  - Coveralls


merge from template-coveralls

package.json

chore(deps): add ^8.3.21 remove ^8.3.20 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 5.0.105 :tada:
The release is available on:

npm package (@latest dist-tag)
v5.0.105
GitHub release

Your semantic-release bot :package::rocket:


Migrate react-toolkit-form-summary to TypeScript

Related issue
Reference to the issue
#394
Description of the issue

Migrate the package react-toolkit-form-summary to TypeScript.
Bump TypeScript and TSLint to their latest versions. I also removed two rules from tslint.json. They are deprecated and were displaying a warning.
Some minor fixes

Person(s) for reviewing proposed changes
@samuel-gomez-axa / @guillaumechervetaxa

I created my PR against master but I think it would be better to have a branch feature/migrateFormToTS which will have all the PR in order to merge everything at once.


MyPy plugin doesn't work with MyPy 0.750

Bug
Please complete:

OS: Debian Linux & MacOS
Python version import sys; print(sys.version): 3.8
Pydantic version import pydantic; print(pydantic.VERSION): 1.1, 1.2

MyPy 0.750 has just been released and it looks like it has changed plugin system, causing plugin to error:
mypy misago --ignore-missing-imports --show-traceback
/Users/rafalpiton/github/misago-starlette/venv/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/typing.pyi:146: error: INTERNAL ERROR -- Please try using mypy master on Github:
https://mypy.rtfd.io/en/latest/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 0.750
Traceback (most recent call last):
  File "mypy/semanal.py", line 4656, in accept
  File "mypy/nodes.py", line 939, in accept
  File "mypy/semanal.py", line 1029, in visit_class_def
  File "mypy/semanal.py", line 1106, in analyze_class
  File "mypy/semanal.py", line 1115, in analyze_class_body_common
  File "mypy/semanal.py", line 1173, in apply_class_plugin_hooks
  File "mypy/plugin.py", line 818, in get_base_class_hook
  File "mypy/plugin.py", line 830, in _find_hook
  File "mypy/plugin.py", line 818, in <lambda>
  File "mypy/plugin.py", line 743, in get_base_class_hook
  File "/Users/rafalpiton/github/misago-starlette/venv/lib/python3.8/site-packages/pydantic/mypy.py", line 79, in get_base_class_hook
    if any(base.fullname() == BASEMODEL_FULLNAME for base in sym.node.mro):
  File "/Users/rafalpiton/github/misago-starlette/venv/lib/python3.8/site-packages/pydantic/mypy.py", line 79, in <genexpr>
    if any(base.fullname() == BASEMODEL_FULLNAME for base in sym.node.mro):
TypeError: 'str' object is not callable
/Users/rafalpiton/github/misago-starlette/venv/lib/python3.8/site-packages/mypy/typeshed/stdlib/3/typing.pyi:146: : note: use --pdb to drop into pdb```

Thanks for reporting this. This is a noted breaking change in mypy. I’ll submit a patch PR shortly.
Any suggestions about how we could better handle breaking changes in mypy going forward would be appreciated!

In particular, it would be easy to log a warning if using a version of mypy that is not one against which the pydantic plugin has been tested. Would this be desirable?

No opinion here. I'm just happy with value provided by Pydantic for me and reported this issues so you can fix the plugin when you have time for that :)

A note in the docs page for the mypy plugin page noting the incompatibility would be helpful.

I guess we should just release a new version, I'll merge what I can and do a release soon.


Add improved error message for non standard node funcs #274

Reference Issues/PRs
#274
What does this implement/fix? Explain your changes
What testing did you do to verify the changes in this PR?
Pull Request Checklist

[ ] Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
[ ] Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
[ ] Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
[ ] Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
[ ] Checked for style issues by running black . and isort .

Codecov Report
Patch coverage: 49.52% and project coverage change: +5.17 :tada:

Comparison is base (8123f42) 40.27% compared to head (755798d) 45.44%.

:exclamation: Current head 755798d differs from pull request most recent head f8d5de1. Consider uploading reports for the commit f8d5de1 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   40.27%   45.44%   +5.17%
==========================================
  Files          48      111      +63
  Lines        2811     7131    +4320
==========================================
+ Hits         1132     3241    +2109
- Misses       1679     3890    +2211

Impacted Files
Coverage Δ

graphein/ml/diffusion.py
0.00% <0.00%> (ø)

graphein/ml/metrics/__init__.py
0.00% <0.00%> (ø)

graphein/ml/metrics/gdt.py
0.00% <0.00%> (ø)

graphein/ml/metrics/tm_score.py
0.00% <0.00%> (ø)

graphein/ppi/graph_metadata.py
0.00% <0.00%> (ø)

graphein/ppi/visualisation.py
0.00% <0.00%> (ø)

graphein/protein/analysis.py
0.00% <0.00%> (ø)

graphein/protein/features/utils.py
27.77% <0.00%> (ø)

graphein/protein/folding_utils.py
0.00% <0.00%> (ø)

graphein/protein/tensor/data.py
30.37% <ø> (ø)

... and 92 more

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Does TopologyProposal use positions?

Does TopologyProposal actually make use of old_positions or new_positions?  I don't think we actually use these anywhere since we split out the geometry engine.
Can we eliminate these?

We would still need positions passed to GeometryEngine.propose(), but it could be a separate argument:
new_positions, geometry_logp  = self.geometry_engine.propose(topology_proposal, old_positions)

Again, this was for the possibility of position-dependent proposals.

We can leave it for now, but it leads to really weird constructs that require us to replace the positions in TopologyProposal:
https://github.com/choderalab/perses/blob/master/perses/tests/test_sampler.py#L151-L166

Oh that is weird, you're right. I hadn't thought about that.

We could change the NCMC API, but I'm not sure which is better.

Better to change the ProposalEngine I think.

Addressed in #106


Utils of @pdf/schemas not exported

Is your feature request related to a problem? Please describe.
Greetings Kyohei,
I am trying to implement some custom schemas (inputs and checkboxes that keep editable in the generated PDF -> Creating PDF-Forms with pdfme) and want to use the functions of the utils.ts but those are not exported. Some of the provided utils are pretty handy for use with custom schemas. e.g. the Color-transformations.
Same goes for the helpers.ts of the most complex schema of "text"... There are a lot of needy translations you can use for other schemas as well.
Is there a reason why you aren't exporting all functions from utils? That would lead to a more standardised way of creating custom schemas for the whole community.
All the Best from Berlin!
Describe the solution you'd like
packages/schemas/src/index.ts:
import multiVariableText from './multiVariableText/index.js'
import text, { readOnlyText } from './text/index.js';
import image, { readOnlyImage } from './graphics/image.js';
import svg, { readOnlySvg } from './graphics/svg.js';
import barcodes from './barcodes/index.js';
import line from './shapes/line.js';
import table from './tables/index.js';
import { modifyTemplateForTable, getDynamicHeightForTable } from './tables/dynamicTemplate.js';
import { rectangle, ellipse } from './shapes/rectAndEllipse.js';
import { convertForPdfLayoutProps, rotatePoint, hex2PrintingColor, hex2CmykColor, hex2RgbColor, isEditable, readFile, createErrorElm } from './utils.js';
import {getBrowserVerticalFontAdjustments, getFontDescentInPt, heightOfFontAtSize, widthOfTextAtSize, getFontKitFont, getSplittedLines, calculateDynamicFontSize} from '../src/text/helper';

const tableBeta = table;

const builtInPlugins = { Text: text };

export {
  multiVariableText,
  text,
  readOnlyText,
  image,
  readOnlyImage,
  svg,
  readOnlySvg,
  barcodes,
  line,
  tableBeta,
  modifyTemplateForTable,
  getDynamicHeightForTable,
  rectangle,
  ellipse,
  builtInPlugins,
  convertForPdfLayoutProps,
  rotatePoint,
  hex2PrintingColor,
  hex2CmykColor,
  hex2RgbColor,
  isEditable,
  readFile,
  createErrorElm,
  getBrowserVerticalFontAdjustments,
  getFontDescentInPt,
  heightOfFontAtSize, widthOfTextAtSize, getFontKitFont, getSplittedLines, calculateDynamicFontSize
};

Describe alternatives you've considered
Creating own functions with same logic... but this seems a bit odd...
Additional context
thanks for the great library btw.
Also, I've been feeling uncomfortable for a while about the fact that helper functions and the plugin itself are being exported from the same directory.
How about doing something like this, for example?
import {
  multiVariableText,
  text,
  image,
  svg,
  barcodes,
  line,
  tableBeta,
  rectangle,
  ellipse,
} from '@pdfme/schemas';

import {
  builtInPlugins,
  modifyTemplateForTable,
  getDynamicHeightForTable,
  convertForPdfLayoutProps,
  rotatePoint,
  hex2PrintingColor,
  hex2CmykColor,
  hex2RgbColor,
  isEditable,
  readFile,
  createErrorElm,
  getBrowserVerticalFontAdjustments,
  getFontDescentInPt,
  heightOfFontAtSize,
  widthOfTextAtSize,
  getFontKitFont,
  getSplittedLines,
  calculateDynamicFontSize
} from '@pdfme/schemas/helpers';

Thanks for your quick reply.

Also, I've been feeling uncomfortable for a while about the fact that helper functions and the plugin itself are being exported from the same directory.
How about doing something like this, for example?
import {
  multiVariableText,
  text,
  image,
  svg,
  barcodes,
  line,
  tableBeta,
  rectangle,
  ellipse,
} from '@pdfme/schemas';

import {
  builtInPlugins,
  modifyTemplateForTable,
  getDynamicHeightForTable,
  convertForPdfLayoutProps,
  rotatePoint,
  hex2PrintingColor,
  hex2CmykColor,
  hex2RgbColor,
  isEditable,
  readFile,
  createErrorElm,
  getBrowserVerticalFontAdjustments,
  getFontDescentInPt,
  heightOfFontAtSize,
  widthOfTextAtSize,
  getFontKitFont,
  getSplittedLines,
  calculateDynamicFontSize
} from '@pdfme/schemas/helpers';

That makes sense though.
Also what about the default-constants? maybe a third export-path would make sense like "@pdfme/schemas/constants"?


[Keyboard Navigation- Bot Framework Web Chat- Video]: Maximize and more option controls in video section are not accessible using keyboard

Is it an issue related to Adaptive Cards?
No.
What is the PWD impact?
User Experience:
Users who rely on the keyboard will be affected if the controls are not accessible with the keyboard. Keyboard users cannot perform the action as the control doesn't get accessible with the keyboard. Keyboard users will be affected as they cannot use this functionality.
Note:
User credentials should NOT be included in the bug.
What browsers and screen readers do this issue affect?
Windows: Edge with Windows Narrator
Are there any code-based customization done to Web Chat?
No, I am using Web Chat without any customizations except "styleOptions".
What version of Web Chat are you using?
Latest production
Which area does this issue affect?
Keyboard navigation
What is the public URL for the website?
https://compulim.github.io/webchat-loader/
How to reproduce the issue?

Open URL: https://compulim.github.io/webchat-loader/ and sign in using valid credentials.
Navigate to web chat page and select 4.18.1-main.20240927.ea7a875 (30/9/2024) version and then select mockBot link under present label and then select open web chat in new window link at bottom.
Navigate to white label experience chat page and type Video word in type your message text box.
Navigate to the search results.
Verify the controls are accessible using keyboard or not.

What do you expect?
Maximize and more option controls in video section should be accessible using keyboard.
What actually happened?
Maximize and more option controls in video section are not accessible using keyboard.
Observation:
using mouse maximize and more option controls are accessible.
Do you have any screenshots or recordings to repro the issue?

https://github.com/user-attachments/assets/35202172-e145-4505-8855-37ca8ea5a1a8
Did you find any DOM elements that might have caused the issue?
No response
MAS reference
MAS 2.1.1 – Keyboard
WCAG reference
2.1.1 – Keyboard
WAI-ARIA reference
No response
Adaptive Card JSON
No response
Additional context
No response

#A11yMAS;#A11ySev1;#Accessibility;#AILimited;#Benchmark;#BotFrameworkWebChat-Oct24;#HCL;#MAS2.1.1;#Win11-Edge(Chromium);


incomplete aux field and negative mapq?

I'm getting an odd error with some HiFi data I was trying to align. When I pipe the output straight from ngmlr to samtools sort, it crashes with something along the lines of:
[E::sam_parse1] incomplete aux field
samtools sort: truncated file. Aborting

If I write out the SAM output first and try to samtools view it, it's instead
[W::sam_read1] Parse error at line 3870
[main_samview] truncated file.

Looking at the actual offending read in question, it's clear something went awfully wrong, since there's a negative mapping quality:
m64034_200304_183416/148374403/ccs	2064	chr13	65543216	-2147483648	17925S54M1D23M	*	0	0	[long sequence string] [long quality string]	AS:i:142	NM:i:2	XI:f:0.9744	XS:i:0	XE:i:142	XR:i:77	MD:Z:54^T1T21	SV:i:2	SA:Z:chr13,21240689,-,6S5022M1D1956M1D32M1D834M1I5928M6I3152M1I791M1D156M1I39M77S,60,39;	QS:i:17925	QE:i:18002	CV:f:0.427730

It looks like an integer overflow issue, but I have no idea why it's suddenly happening to some reads. I'm running ngmlr 0.2.7 and samtools 1.10
There's nothing particularly weird about the data, it's human data aligned to hs38DH and I used --bam-fix (although that doesn't seem to apply in this case).
Without having to write some kind of intermediate parser to strip out bad alignments, is there an easy fix to this?

Thanks @kautto for reaching out. Just to check the obvious. These reads have been already collapsed with the pacbio ccs program?
Other than that I would need some examples to be able to see if I can help you..
Thanks
Fritz

Hi Fritz,
yeah, they're actual HiFi/CCS reads, run through SMRTLink 8.
As a bit more detail, the reads are a subset of reads extracted from an already aligned BAM, i.e.

HiFi/CCS reads were aligned to hs38
A subset of reads were extracted for further analysis (samtools view followed by samtools bam2fq)
When realigning the reads to the same reference, a small number of them have a problem like that.

Step 2 isn't actually changing anything - I checked to make sure the FASTQ records stayed the same.
I just noticed that step 1 was done with ngmlr 0.2.7 and htslib/samtools 1.9, and step 3 (where it fails) is with htslib/samtools 1.10.
If I take the failing reads and attempt realignment in a conda environment with htslib 1.9, it works again - but as soon as I switch to 1.10 it fails. So it looks like some kind of incompatiblity with the newest version of htslib?
It only affects a small subset of reads, 36 out of about 280k, all which are supplementary (flag 2048 or 2064). I'll email you a FASTQ with some example reads so you can try to reproduce it.
Best,
Esko

In case others run into this issue, it seems to be related to the new samtools/htslib version (1.10). Reverting back to 1.9 works fine, so that's my workaround for now.


Remove mutating global state in monitoring mixins imports

Same as #857 but for monitoring mixins.
Part of #566.
This is a total WIP. At the moment of creating this PR, code changes present only a basic method to remove the global state when importing mixins. Idea is to move mixins imports directly into each component and not gather them in global config.

I get a circular dependency between working more on refactoring how mixins are included and https://github.com/prometheus-operator/kube-prometheus/pull/869. My plan right now is to do following:

merge this PR as is
rebase and merge https://github.com/prometheus-operator/kube-prometheus/pull/869
refactor again to include monitoring mixins in each of the component (multiple PrometheusRule)

The last bit would be good to tackle after the following PRs are merged: https://github.com/prometheus-operator/kube-prometheus/pull/870, https://github.com/prometheus-operator/kube-prometheus/pull/869, https://github.com/prometheus-operator/kube-prometheus/pull/868, this one.

I get a circular dependency between working more on refactoring how mixins are included and https://github.com/prometheus-operator/kube-prometheus/pull/869. My plan right now is to do following:

merge this PR as is
rebase and merge https://github.com/prometheus-operator/kube-prometheus/pull/869
refactor again to include monitoring mixins in each of the component (multiple PrometheusRule)

The last bit would be good to tackle after the following PRs are merged: https://github.com/prometheus-operator/kube-prometheus/pull/870, https://github.com/prometheus-operator/kube-prometheus/pull/869, https://github.com/prometheus-operator/kube-prometheus/pull/868, this one.

Rebased after merging #868

Rebased after merging #868

This is ready for review. Ping @prometheus-operator/kube-prometheus-reviewers

This is ready for review. Ping @prometheus-operator/kube-prometheus-reviewers

Rebased and fixed copy-paste issues.

Rebased and fixed copy-paste issues.

lgtm :+1:

lgtm :+1:


Corrects vehicle_state running comments

Going to close this in favor of correcting all the example headers for text.

@tcr3dr Absolutely. You'll note that I did this for vehicle_state.py in #184 which I submitted yesterday.


Do you think it looks big in 100% scaling?

You can change pretty much all of that with variables.
There are two variables inside of Fluent.theme.css which control the channels/member lists.
And you've got these to mess around with: https://github.com/DiscordStyles/Fluent/blob/main/src/_root.scss
Just copy the variables to the :root of your Fluent.theme.css.
I seem to forgot to add the chat bubble variables which will allow you to reduce padding, margin and background colour.

Ah, seems like it was good now, thanks. I have no suggestions for now because this is the best Fluent theme for Discord already! Have a nice day!


SlickGrid - Advanced Export. Any ETA?

Hey guys!
I am seeing that Advanced Export is planned to do, but anyone know about any estimated completion date on this one? Is there anything that I could help?
I am in need of exporting grouped data from slickgrid but currently we only gives possibility of export "raw" data to excel/pdf from grid.
Thanks!

Alternatively you can create a method in your endpoint, and afterwords call it.
You can use for instance EPPLUS and make the export what you wan't.


Example missing in basic js - word blanks

Describe your problem and - if possible - how to reproduce it
In the description of the exercise at the end of the first paragraph, I think there should be an example according to the last sentence.
Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/word-blanks
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version: 66.0.3359.181
Operating System: Windows 10 Home 1803

If possible, add a screenshot here

Yeah, it will work. If you’re free you may work on it.

@Nirajn2311 I was free so, I have created a PR #19. Let's see what maintainers think about this issue.


filter submit None Error

see image:

Error:
sqlalchemy.exc.DataError: (DataError) invalid input syntax for integer: ""
LINE 3: WHERE lending_project_plan.period = ''
I fund code(https://github.com/mrjoes/flask-admin/blob/master/flask_admin/contrib/sqla/view.py#L729):
don't check value Null

Filters have changed a lot since 2014, and I believe this should be fixed now. Please reopen if this is still an issue.


Move/Hold order icons should only appear if you're wearing a marine headset

Parity
Mainly for HvH, so SPP can't see that you're buffed for example

example: ShowMarineIconsComponent


ValueError: Could not find a backend to open graph.png with iomode ri.

Got the following error while running Semantic Graph Prior Inference with --draw_scene_graph flag to generate and visualise the scene graph PNG:
Exception has occurred: ValueError
Could not find a backend to open `graph.png`` with iomode `ri`.
Based on the extension, the following plugins might add capable backends:
  pyav:  pip install imageio[pyav]
  opencv:  pip install imageio[opencv]
  File "/home/cto_auraml_com/Development/InstructScene/src/utils/visualize.py", line 407, in draw_scene_graph
    img = imread(output_filename)
  File "/home/cto_auraml_com/Development/InstructScene/src/generate_sg.py", line 605, in main
    image = draw_scene_graph(
  File "/home/cto_auraml_com/Development/InstructScene/src/generate_sg.py", line 641, in <module>
    main()
ValueError: Could not find a backend to open `graph.png`` with iomode `ri`.
Based on the extension, the following plugins might add capable backends:
  pyav:  pip install imageio[pyav]
  opencv:  pip install imageio[opencv]

Command:
generate_sg.py configs/bedroom_sg_diffusion_vq_objfeat.yaml --tag bedroom_sgdiffusion_vq_objfeat --fvqvae_tag threedfront_objfeat_vq
vae --sg2sc_tag bedroom_sg2scdiffusion_objfeat --checkpoint_epoch -1 --cfg_scale 1.0 --sg2sc_cfg_scale 1.0 --n
_scenes 2 --visualize --verbose --resolution 1024 --draw_scene_graph

Was able to resolve this issue by installing graphviz using following command:
sudo apt-get install graphviz


[Feature Request] Frame by frame view

If you grab animations which are already online as .bm , it's hard to see them. This sorts it out for you and it's great for visualizing the animations. However, when you're grabbing animations online they might be glitched, have a few extra frames or a poor order.
If there was a way to go through an animation, frame by frame, it would be easier to track down these glitches and remove them.
Also helps just in case you want to trim it down but want to make sure it won't affect the animation's quality.

It's a great idea. I was thinking of adding the following to the fullscreen animation window:

a play/pause animation button
a slider to navigate through all the steps of the animation.


Develop a library for reading the NIS code with low-level commands

Each card has an unique number (NIS) which can be read easily, without the need for the more complex middleware and also without entering the card PIN. It would be very useful to provide a minimal and portable (?) SDK for reading such code using low-level commands. The SDK could be easily embedded in applications and devices.
The NIS code can be mapped to the person's Codice Fiscale just by querying a web service operated by the Government (not available yet). Such feature allows third parties to use CIE cards for access turnstiles (offices, gyms, etc.) because users can be mapped to a local database using the Codice Fiscale.
Example code for this task is available: https://github.com/italia/cie-middleware/blob/master/EsempioPCSC/EsempioPCSC.cpp
We basically need to turn it into a library.
Useful resources:

the chip manual

Nota da @fottavi:

Le specifiche IAS richiedono il supporto delle APDU a chunk. L'implementazione attualmente in uso per le CIE supporta anche le APDU estese. Il middleware invia solo APDU a chunk per facilitare il riuso su Android su cui le APDU estese danno problemi.


After forking the mainnet, how do I get the outgoing transaction logs or trace immediately before the next block?

Component
Anvil
Describe the feature you would like
With interval mining currently enabled, I wonder if I can get the logs or trace of the transaction I am simulating immediately before mining
Additional context
No response

@2547881370 could you please provide more details re scenario you are trying to accomplish? Please reopen with such, thank you!


Zap maintenance

Problem
Upgrade to latest zap
Change overview

Update the submodule pointer
Change the require mechanism: 'dist' is now required because of TypeScript change
Reformat many files to adopt the 'prettier' configuration that zap has for the custom helpers
Update the overridables to fully detach from zap internals (which have changed, so they broke the regen)

Testing

full regen
full rebuild
applications were NOT tested and executed against the new hardware

Caveat
1.) @vivien-apple : this PR includes a change you did in zap to change the length byte or something in the generation of the default string types, commit 98518c5 in zap repo.
You tell me: is there anything else on the main SDK that needs to go along with this? Should this PR be accepted in conjunction of something else?
2.) There is more bugfixes coming to zap itself to deal with several generation issues: some non-determinism, the struct ordering for dependencies, etc., that were reported by @bzbarsky-apple, @mrjerryjohns , and others. I plan to keep working on the PR adding commits until it will be approved at some point, when I'll switch to a new PR.

@tecimovic please restyle :)

@tecimovic also regen issues.
It seems we also need to wait for @vivien-apple to confirm the extra null byte is intended and desirable (it does seem to increase RAM footprint)

Making this un-stale. @vivien-apple @andy31415 ?

Making this un-stale. @vivien-apple @andy31415 ?
#9533 also updated zap - is this PR still needed? @tecimovic


don't start rule on new page

Task: #???
When merged, this PR will:

???

@sujato Sorry, I just noticed these PRs, do they still need to be merged?


Enhance Snake_Water_Gun_Game

File path: projects/snake_water_gun_game/Snake_Water_Gun_Game.py
I want to change the if-else ladder to nested if-else.
I want to change some variable names and change some print statements to make it more beautiful.
Also, I can use the rich library to make it more cool if you would like.
Please Assign me this issue under hacktoberfest.
Thanks in advance.

Sure go for it

File path: projects/snake_water_gun_game/Snake_Water_Gun_Game.py
Hey this is Abhay can you please assign me this issue  I can be your best pick as I have solved leetcode que in python as also have star on hackerrank
I can code it in most efficient manner
Feature I can added if i get this
I can make it more easy to understand for other mean making code more readable
use ternary operators to do the job for more reliableless
and enhancing variable name to more understanding

Please check the PR  #529  I fixed it


Sync oculy forked GitHub repo using a reverse Pull Request

Synchronised Forked Repository

To sync your fork you can simply pull locally main from this remote and force push to your fork.

To sync your fork you can simply pull locally main from this remote and force push to your fork.

👍


sql: Fix Zones are returned in a random order (#3934)

Description
This PR updates sort_key to id if sort_key of all zones are 0 (including removed zones, which means sort_key is not set by customers), so zones will be ordered by id in listZones response.
Fixes: #3934

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2424

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3240)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4494-t3240-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File


[Snyk] Upgrade inversify from 6.0.2 to 6.1.5

Snyk has created this PR to upgrade inversify from 6.0.2 to 6.1.5.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 14 versions ahead of your current version.

The recommended version was released 24 days ago.

Release notes

Package name: inversify

6.1.5 - 2024-11-29Changed

Updated library to import reflect-metadata. Importing reflect-metadata before bootstraping a module in the userland is no longer required.

Fixed

Updated ESM build to provide proper types regardless of the ts resolution module strategy in the userland.
Fixed container to properly resolve async .toService bindings.
Fixed .toService binding to properly disable caching any values.

6.1.5-beta.2 - 2024-11-29Fixed

Updated ESM bundled types to solve circularly referenced types.

6.1.5-beta.1 - 2024-11-29Fixed

Updated ESM build to provide proper types regardless of the ts resolution module strategy in the userland.

6.1.5-beta.0 - 2024-11-26Changed

Updated library to import reflect-metadata. Importing reflect-metadata before bootstraping a module in the userland is no longer required.

Fixed

Fixed container to properly resolve async .toService bindings.
Fixed .toService binding to properly disable caching any values.

6.1.4 - 2024-11-13Changed

Updated planner with better error description when a binding can not be properly resolved.

Fixed

Updated container to allow deactivating singleton undefined values.
Updated ESM build to be compatible with both bundler and NodeJS module resolution algorithms.

6.1.4-beta.1 - 2024-11-13Fixed

Updated container to allow deactivating singleton undefined values.
Updated ESM build to be compatible with both bundler and NodeJS module resolution algorithms.

6.1.4-beta.0 - 2024-11-12Changed

Updated planner with better error description when a binding can not be properly resolved.

6.1.3 - 2024-11-12Fixed

Updated ESM build with missing types.

6.1.2 - 2024-11-12Changed

Updated package.json to include the exports field for better bundler support.

Fixed

Updated fetch metadata flows with better error descriptions.

6.1.2-beta.1 - 2024-11-12Changed

Updated package.json to include the exports field for better bundler support.

6.1.2-beta.0 - 2024-11-08

6.1.1 - 2024-11-07

6.1.0 - 2024-11-07

6.0.3 - 2024-10-23

6.0.2 - 2023-10-20

    from inversify GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.19%. Comparing base (17ea0b4) to head (efe2513).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   92.19%   92.19%
=======================================
  Files          18       18
  Lines         525      525
  Branches       97      104    +7
=======================================
  Hits          484      484
  Misses         40       40
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP neg(MIN) for ints fix

I'm leaving this WIP to address the rest of https://github.com/rust-lang/stdsimd/issues/54
I have to leave for a bit so I'm just opening this for now and will be back briefly to shape it up.
I'm doing this to get started with the contributing workflow and to test out my initial idea of just adding a panic! if any of the lanes match the int::MIN.
There's a lot of moving parts and I probably missed a lot of easy stuff, so please, all feedback is welcome.

Thanks @thomcc !
This is my first contribution to the project so I'm still picking things up.
Concretely, is your comment proposing an API for future contributions, or to ammend this PR?

Thanks @thomcc !
This is my first contribution to the project so I'm still picking things up.
Concretely, is your comment proposing an API for future contributions, or to ammend this PR?

I'm mostly noting it for future reference.

I'm mostly noting it for future reference.

Awesome. Thanks to @workingjubilee for inspecting the Travis failures on the webassembly builds #51 .

Awesome. Thanks to @workingjubilee for inspecting the Travis failures on the webassembly builds #51 .

Given that it's not UB, that SIMD is a performance-oriented API, and that we don't panic for int overflow on adds and such (I think? or we'd have solved this already), it seems worth kicking the overflow checking in debug mode down the road a bit.

Given that it's not UB, that SIMD is a performance-oriented API, and that we don't panic for int overflow on adds and such (I think? or we'd have solved this already), it seems worth kicking the overflow checking in debug mode down the road a bit.

and that we don't panic for int overflow on adds and such

This was my other question here.  If neg is implemented in terms of sub, then it arguably should have already been doing the right thing (if perhaps with a suboptimal message).
But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd, and define all the +/-/etc to always be wrapping.  (I don't immediately know whether that's the right answer, but I assume you'll make a persuasive case for whichever direction you pick.)

and that we don't panic for int overflow on adds and such

This was my other question here.  If neg is implemented in terms of sub, then it arguably should have already been doing the right thing (if perhaps with a suboptimal message).
But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd, and define all the +/-/etc to always be wrapping.  (I don't immediately know whether that's the right answer, but I assume you'll make a persuasive case for whichever direction you pick.)

and that we don't panic for int overflow on adds and such

This was my other question here. If neg is implemented in terms of sub, then it arguably should have already been doing the right thing (if perhaps with a suboptimal message).
But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd, and define all the +/-/etc to always be wrapping. (I don't immediately know whether that's the right answer, but I assume you'll make a persuasive case for whichever direction you pick.)

and that we don't panic for int overflow on adds and such

This was my other question here. If neg is implemented in terms of sub, then it arguably should have already been doing the right thing (if perhaps with a suboptimal message).
But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd, and define all the +/-/etc to always be wrapping. (I don't immediately know whether that's the right answer, but I assume you'll make a persuasive case for whichever direction you pick.)

But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd

Yeah, I'd argue in favor of this, mostly because checked_add and stuff would be viable performantly (returning [Option<i32>; 4]...). I also think in practice people are more likely to want wrapping behavior on SIMD than normal integers. I think it should be a deliberate decision though.

But I also thing that it would be fine for you as a WG to decide that checked-in-debug isn't worth doing for simd

Yeah, I'd argue in favor of this, mostly because checked_add and stuff would be viable performantly (returning [Option<i32>; 4]...). I also think in practice people are more likely to want wrapping behavior on SIMD than normal integers. I think it should be a deliberate decision though.

While we're likely going to settle the issue regarding Neg some other day, that leaves the rest of issue #54, if you wish to continue to take this on. To recap, in the Zulip, I said:
"apply_binary_scalar_rhs_lanewise" is doing scalar ops, which of course panic.

so when that is removed and only the SIMD op is compiled in, running that test instead gets something like:

process didn't exit successfully: ~/projects/stdsimd/target/debug/deps/ops-6770e1bc9a8f6e58 (signal: 8, SIGFPE: erroneous arithmetic operation)

So the tests should be updated to not include the scalar comparisons, and instead just run the ops without checking the results, since we're only looking for a "successful" panic at runtime, not that the arithmetic results of the SIMD operation would match the arithmetic results of a comparable scalar operation.

While we're likely going to settle the issue regarding Neg some other day, that leaves the rest of issue #54, if you wish to continue to take this on. To recap, in the Zulip, I said:
"apply_binary_scalar_rhs_lanewise" is doing scalar ops, which of course panic.

so when that is removed and only the SIMD op is compiled in, running that test instead gets something like:

process didn't exit successfully: ~/projects/stdsimd/target/debug/deps/ops-6770e1bc9a8f6e58 (signal: 8, SIGFPE: erroneous arithmetic operation)

So the tests should be updated to not include the scalar comparisons, and instead just run the ops without checking the results, since we're only looking for a "successful" panic at runtime, not that the arithmetic results of the SIMD operation would match the arithmetic results of a comparable scalar operation.

Tests now all pass, but the branch is still requesting a review from @workingjubilee from a resolved convo.
Re-requesting review.

Shoutout to Mario Carneiro for spotting a missing conditional.


Bugfix/cleaning comments + readme update

Ignore all the commits of the readme, didn't know you could preview it :)


Looks like we are getting failing jobs each time we deploy

on 2016/01/29 there were about 600 errors
There were around 20 on the other days.
Not sure what all the errors are about but it seems bad that there were so many.  Does anyone else remember?
Worker
ssjobs1prod:14923 on id_based at 2016/01/29 09:32:15 -0500
Retry or Remove
Class
Sufia::Resque::MarshaledJob
Arguments
--- 'BAhvOhNTaGFyZU5vdGlmeUpvYgY6CEBpZEkiDngzNDZkbjU0cAY6BkVU
'
Exception
Timeout::Error
Error
execution expired
ssjobs1prod:32718 on id_based at 2016/02/14 07:27:04 -0500
Retry or Remove
Class
Sufia::Resque::MarshaledJob
Arguments
--- 'BAhvOhNTaGFyZU5vdGlmeUpvYgY6CEBpZEkiDjg2MjNqNzUzagY6BkVU
'
Exception
NoMethodError
Error
undefined method `fetch' for #Net::LDAP::Entry:0x007fb479906e58
ssjobs1prod:8990 on id_based at 2016/04/04 07:26:14 -0400
Retry or Remove
Class
Sufia::Resque::MarshaledJob
Arguments
--- 'BAhvOhNTaGFyZU5vdGlmeUpvYgY6CEBpZEkiDjg2MjNqNzUzagY6BkVU
'
Exception
NoMethodError
Error
undefined method `fetch' for #Net::LDAP::Entry:0x007f66f0f49300

@cam156 the fetch error is for a user whose email doesn't resolve when going to SHARE.

It looks like LDAP may be getting cranky being hit too much, becuase if I run these jobs individually they run.

Weird. Why would they fail on the same record? Can you get the job to run with https://scholarsphere.psu.edu/files/8623j753j ?


osbuild-mpp: Fix error on python < 3.11

The change in commit ed3386943069e138b346eef75ac64d9874a07810 to use hashlib.file_digest breaks with older python, because it was added in 3.11.
This change reverts back to hashing all the data in the case where file_digest doesn't exist.

Would it make sense to call something like make test-data or similar in the GH-action "Unittest" python-matrix to check for regressions like this?
(…we need to be root for this? 🤔)


Option to tolerate diacritics

It would be very helpful if an option could be set so that fuzzy would return strings with and without diacritics.
e.g.: The user searches for "Lumiere"
The result should also include "Lumière":
Lumière
Lümière
Lumiere
Lůmière
Lúmière
You won't find "Lumiere" in this official example:
http://htmlpreview.github.io/?https://github.com/mattyork/fuzzy/blob/master/examples/disney.html

I got diacritics to be included in searches by changing 2 places in fuzzy.js where comparisons are done...
Line 50:
-    , compareString =  opts.caseSensitive && str || str.toLowerCase()
+    , compareString =  opts.caseSensitive && str || str.toLowerCase().normalize("NFKD").replace(/\p{Diacritic}/gu, "")
     , ch;

-  pattern = opts.caseSensitive && pattern || pattern.toLowerCase();
+  pattern = opts.caseSensitive && pattern || pattern.toLowerCase().normalize("NFKD").replace(/\p{Diacritic}/gu, "");

String.prototype.normalize() documentation.
Unicode Property Escapes in regex (\p{Diacritic}/u) documentation.


Replace custom path handling in MRT

also removed custom build configurations in mrt build task.

/azp run


Add weekly review 039

Feel free to edit it. Thanks. ;-)

Thanks @kianmeng
https://perlweeklychallenge.org/blog/review-challenge-039/


What is recommended way to work locally with flynn

I've go app with several microservices. I'd like to mirror 1:1 my infrastructure on production with my local machine (exluding database data). Also, I'd like to be able to iterate without re-deploying after every file-save.
My current workflow (without flynn) locally is:

I test my API
I see some bug
I fix bug in the code and save file
I CTRL+C, node server.js (re-start server)
I'm able to see bug fixed (or no, and being able to re-iterate in under 10 seconds)

A also need all services to be able to communicate with each other locally as they depend on each other.
I've checked vagrant image, but it looks more like demo (even domain is set to https://dashboard.demo.localflynn.com) so I bet it's more like quick-demo than way to work locally with flyyn

Read this https://github.com/flynn/flynn/issues/4345
For local development you may use current variant, but, if you want true-microservices use Docker with Flynn. It help you to relocate your app to other solution or paas like Flynn. If it will be needed.

I usually do not test flynn locally. Its not really needed.
The app should behave live the same as its locally, its a isolated Heroku style buildpack. So yes, there is no real need to run a local cluster for testing.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


Add B11R Tool

(closes #625)
What was wrong?
The specs currently do not have a block builder utility like the b11r tool on go-ethereum
Related to Issue #625
How was it fixed?
Implement the b11r tool. Run the evm tools (t8n and b11r) on the existing set of test fixtures to ensure that they pass.
A couple of points to be noted here

The b11r tool in this PR does not yet support sealing the block with Ethash or Clique. This functionality will be explored as part of another issue. (See #755)
The general state tests are run for all forks except Shanghai. The spec tests for Shanghai are currently not up to date and the evm tools tests will also have to be updated along with the usual tests. (See #753 )
The evm_tools tests do take almost the same amount of time as the regular state transition tests. This PR configures them to be run only in the pypy environment in order to optimise Github checks time.

Cute Animal Picture

Codecov Report
Patch coverage: 55.26% and project coverage change: -10.56 :warning:

Comparison is base (4478ef9) 82.48% compared to head (c2359e6) 71.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #756       +/-   ##
===========================================
- Coverage   82.48%   71.92%   -10.56%
===========================================
  Files         570      570
  Lines       31571    31557       -14
===========================================
- Hits        26040    22697     -3343
- Misses       5531     8860     +3329

Flag
Coverage Δ

unittests
71.92% <55.26%> (-10.56%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/ethereum/arrow_glacier/fork.py
0.00% <0.00%> (-50.38%)
:arrow_down:

src/ethereum/gray_glacier/fork.py
0.00% <0.00%> (-50.38%)
:arrow_down:

src/ethereum/london/fork.py
91.41% <90.00%> (-0.81%)
:arrow_down:

src/ethereum/paris/fork.py
92.78% <100.00%> (-1.45%)
:arrow_down:

src/ethereum/shanghai/fork.py
83.40% <100.00%> (ø)

... and 118 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@SamWilsn @petertdavies Found and fixed the EVM tools tests memory leaks :)


pull request for e2e test at 12/13/2016 00:56:02

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


FixFix test_mysql_jdbc_catalog_nereids p2 test case.

Fix test_mysql_jdbc_catalog_nereids p2 test case.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Add benchmarks using ModSecurity for comparison

While working on performance, it will be helpful to be able to compare how coraza performs vs ModSecurity. This ports the existing CRS benchmarks to use ModSecurity via cgo.
In the future, it could be good to make a benchmark harness abstraction to share between the benchmarks for the two engines.
Unfortunately there is no well maintained cgo wrapper for modsecurity. I had to add (just a few) modifications to my own fork. I'm glad to have been able to make it easy to install with homebrew.
https://github.com/anuraaga/go-modsecurity

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:

[X] My code includes positive and negative tests.
[X] I have an appropriate description with correct grammar.
[X] I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR :heart:
Preparing CRS...
CRS PATH: /var/folders/vx/38td0k79201f9zn_myzbqx_40000gn/T/crs2213765132
Loading 23 profiles
goos: darwin
goarch: arm64
pkg: github.com/corazawaf/coraza/v3/testing
BenchmarkCRSCompilation-10               	      19	  59127658 ns/op
BenchmarkCRSSimpleGET-10                 	     903	   1177443 ns/op
BenchmarkCRSSimplePOST-10                	     511	   2205603 ns/op
BenchmarkModSecurityCRSCompilation-10    	      14	  78964220 ns/op
BenchmarkModSecurityCRSSimpleGET-10      	    1509	    762728 ns/op
BenchmarkModSecurityCRSSimplePOST-10     	    1098	   1065481 ns/op
PASS

In the future, it could be good to make a benchmark harness abstraction to share between the benchmarks for the two engines.

It's not a benchmark tester, but there is a(n unreleased) tool, which can be used for this:
https://github.com/digitalwave/ftwrunner/tree/v1.0/dev
This branch can use both engine, and can run almost the whole CRS test suite. Perhaps we can extend it for benchmark too...
But the Coraza's CGO has some issue, eg. the logging callback does not work - which is a very important feature to get the log about all transactions.

Thanks @airween - I think benchmarking with ftw could be interesting. But I think go benchmarks are helpful to have a target during development. It's tough for any external tool to match the smoothness of making code changes and rerunning the native benchmarks all in the IDE based on my experience. So it's probably good to have go-based benches, and maybe the external one too in the future.

This is an interesting topic. I think FTWRUNNER has a lot of value for people migrating from modsecurity. Once we have a stable libcoraza it should be brought into our CI
Can we confirm that including a CGO dependency that won't be included without the tags won't affect compilations of coraza with CGO_ENABLED=0 ?
If that's the case, then it looks good to me

Can we confirm that including a CGO dependency that won't be included without the tags won't affect compilations of coraza with CGO_ENABLED=0 ?

Yup can confirm that the build tags makes sure that default builds without setting the tag run fine with cgo disabled.


hoogle data attempt to create its database in the nix store

ghci>:hoogle map
Could not find some databases: default
Searching in:
  .
  /nix/store/rk4d6qaq2xiprifrskwhfnyl6c24p0rg-haskell-hoogle-4.2.41/share/i386-linux-ghc-7.10.1/hoogle-4.2.41/databases

There are no available databases, generate them with: hoogle data

$ hoogle data
hoogle: /nix/store/rk4d6qaq2xiprifrskwhfnyl6c24p0rg-haskell-hoogle-4.2.41/share/i386-linux-ghc-7.10.1/hoogle-4.2.41/databases: createDirectory: permission denied (Read-only file system)

I would have expected the database to be created in a dot file under $HOME.
Should I expect instead a immutable hoogle database in the nix store? I would be surprised.
Maybe of use: when installing the hoogle package, had the following warning:
Warning: haddock-interfaces: /nix/store/0h09r04ir4py88l61pa6jpikmg1i2v9n-haskell-bytestring-builder-<IP_ADDRESS>.0/share/doc/i386-linux-ghc-7.10.1/bytestring-builder-<IP_ADDRESS>.0/html/bytestring-builder.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/0h09r04ir4py88l61pa6jpikmg1i2v9n-haskell-bytestring-builder-<IP_ADDRESS>.0/share/doc/i386-linux-ghc-7.10.1/bytestring-builder-<IP_ADDRESS>.0/html doesn't exist or isn't a directory
Warning: haddock-interfaces: /nix/store/5yf53rhc56cvv1w8k8lmrx7bpb2qjcpm-haskell-nats-1/share/doc/i386-linux-ghc-7.10.1/nats-1/html/nats.haddock doesn't exist or isn't a file
Warning: haddock-html: /nix/store/5yf53rhc56cvv1w8k8lmrx7bpb2qjcpm-haskell-nats-1/share/doc/i386-linux-ghc-7.10.1/nats-1/html doesn't exist or isn't a directory

Please see http://nixos.org/nixpkgs/manual/#how-to-install-a-compiler-with-libraries-hoogle-and-documentation-indexes.

Ha. Nice approach. Good job and thanks for the quick response.


Implement ability to list addresses in the wallet layer, API and CLI

Issue Number

#220
Overview

[ ] I have implemented the ability to list addresses in the wallet layer, API and CLI

Comments

This would make it easier for @piotr-iohk and us to write some integration tests for the transaction API. We could have derived addresses by hand, but this achieves to complete the high-priority endpoints of the API.
NOTE: It's a "partial" implementation which for now, ignores the filtering based on the address state (?state=used or ?state=unused). This can be implemented later.
:warning: I recommend looking at the change commit by commit ;)

bors r+


Replace size-limit action with own metrics-report action

This is to improve the size reporting and in preparation for #253 which I might to some time later.

Test test


[Feature Request] make an update script

Describe the Feature
A suggestion on Discord by @shr00mie was to create an update script for zenbot.  He suggested makeing a ./zenbot.sh update command.
This would probably really help out a lot of support issues.

I'm just so happy with your usage.

Here is a windows version if anyone wants to use it.  Basically the same except for the remove node_modules directory command
git checkout package.json package-lock.json
git pull

rd /q /s node_modules
npm install && npm update && npm dedupe


NPX download time

npx @codeshift/cli --packages<EMAIL_ADDRESS>.temp/src/Avatar.tsx
Running codeshift/cli via npx takes FAR too long to be worthwhile..
We need to investigate how to speed that up. Most likey, we'll need to cut down on bundlesize.

Hello!
Maybe bumping jscodeshift to version 0.15.1 would help? According to Bundlephobia the size of the package has been reduced quite a bit. It would also remove from deprecation messages from Micromatch version 3 (That jscodeshift 0.13.1 depends on). I would create a PR but I can't run 'yarn' on the project because I get 401 from the packages that are resolved to an Atlassian npm remote.

Fantastic, thanks so much for raising this with me!

I can't run 'yarn' on the project because I get 401 from the packages that are resolved to an Atlassian npm remote.
Whoops that's my bad! I'll fix that up 🤦


Nested queries support

Encryption and decryption should be targeted better.
This PR adds support for precise control over which fields should be encrypted on write operations, and which fields should be attempted to be decrypted (ie: not all string leaves).
Why ?

Some nested queries may introduce leaf nodes with identical names, some encrypted, some not.
The path matching behaviour of v1.0.x was flaky and wouldn't match the intricacies of Prisma's nested writes
On the decryption side, some fields that appear to be encrypted could very well be encrypted using keys outside of the app's control (eg: E2EE apps like Chiffre.io).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

102 of 105 (97.14%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+32.08%) to 90.612%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/index.ts
9
10
90.0%

src/matchers.ts
44
46
95.65%

Totals

Change from base Build<PHONE_NUMBER>:
32.08%

Covered Lines:
144

Relevant Lines:
153

💛  - Coveralls


Raise upper bound of bifunctors

@reinerp Can you release the new version? I'm going to add this package to the dependencies of one of my package already published on Stackage.


[system] Add empty interfaces to fix issue with typescript module augmentation

fix for #43855 to allow typescript module augmentation

[x] I have followed (at least) the PR section of the contributing guide.

Changed the zIndex type from Record<string, number> to a more generic interface: The original type was causing conflicts with @mui/material's createTheme function.
Renamed zIndex to ZIndex: to comply with the linting rules that enforce PascalCase naming conventions.

hey @Janpot,
i tried to figure out why the argos ci step failed, but with no success, maybe you have some insights for me on how to fix this?


TS Server not working for Typescript notebooks

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Latest
OS Version: Mac M1

Steps to Reproduce:

Open a notebook and add a Typescript cell (e.g. test.ipynb)
Import anything (e.g. import fs from 'fs')

See https://github.com/DonJayamanne/typescript-notebook/issues/79#issuecomment-1603446569

This bug has been fixed in the latest release of VS Code Insiders!
@nthh, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 862fa13002d8018c328931ee1edccfd4ca76447d of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!


Adjusted hqmf_version_number to be a String

In a clean database this works fine.  My concern is what happens when we upgrade the existing database with all the data that is already Int.


C-span

Checklist

[x] I'm reporting a broken site support
[ ] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[ ] I've checked that all provided URLs are alive and playable in a browser
[ ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ ] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
Youtube-dl won't download videos from C-span, it gives me:
C:\Users\user\Downloads\youtube-dl>youtube-dl https://www.c-span.org/video/?175131-1/iraq-war-terrorism
[CSpan] 175131: Downloading webpage
[CSpan] 115590: Downloading JSON metadata
[CSpan] 115590: Downloading XML
[CSpan] 115590: Downloading m3u8 information
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 639
[download] Destination: Iraq and the War on Terrorism-115590.mp4
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 1 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 2 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 3 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 4 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 5 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 6 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 7 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 8 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 9 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 1 (attempt 10 of 10)...
[download] Skipping fragment 1...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 2 (attempt 1 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 2 (attempt 2 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 2 (attempt 3 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 2 (attempt 4 of 10)...
[download] Got server HTTP error: HTTP Error 403: Forbidden. Retrying fragment 2 (attempt 5 of 10)...
and continues without downloading anything

Use --referer as a workaround for the time being.
youtube-dl https://www.c-span.org/video/?175131-1/iraq-war-terrorism -f hls-369 --referer https://www.c-span.org/video/?175131-1/iraq-war-terrorism


Any interest in adding Prometheus endpoint?

Environment

Python version:  yes
Peering Manager version: yes

Proposed Functionality
/metrics endpoint provided by django-prometheus with a config flag

Use Case
We have peering-manager deployed at ~Packet~ Equinix, and we track apps through Prometheus.  Would you be interested in a PR with a config switch to enable this in peering-manager?  Netbox does the same thing via METRICS_ENABLED.  It's a trivial change, but I'm open to input before I go hacking on it.  😄

External Dependencies
django-prometheus

Feel free to proceed 👍🏻


shell action helper nvim 0.8 compatibility

Not sure what changed with neovim 0.8 but it causes shell actions to print an additional error to stderr.
Run the below code with the nightly:
local fzf = require("fzf").fzf
local raw_action = require("fzf.actions").raw_action

local raw_act_string = raw_action(function(args)
  return "selected: ".. args[1]
end)

coroutine.wrap(function()
  fzf({1, 2, 3, 4}, "--preview-window=nohidden --preview " ..
    vim.fn.shellescape(raw_act_string))
end)()

And you will see an additional error message in the preview as such:

This is actually theaction_server_address (our RPC server), the reason for this error is the way the shell helper works by utilizing slots 1-2 in the arglist for the server address and function ID, with neovim 0.8 it will attempt to open the temp pipe and fail thus printing the error in the screenshot.
I recently solved this in fzf-lua (https://github.com/ibhagwan/fzf-lua/issues/409) so I figured I'd save you a couple of hours of banging your head against neovim :-)
This PR changes the way the shell helper command is structured, instead of using luafile it uses lua loadfile(<file>)().fnc(<args>) {fzf_field_expression}, this way neovim never attempts to open the RPC pipe and fails.

Thanks for the pull request! I have reverted to neovim stable so I did not notice this issue.
The problem is that nvim --headless interprets the arguments it has been passed as files in neovim 0.8, while neovim 0.7 did not do this. An strace into nvim reveals that it calls the stat() syscall on the argument. When the file doesn't exist, there is no problem, but when the file exists, it opens it the wrong way. We shouldn't be passing data that way either, so I think the approach taken in this PR is a nice way to do it.
One note about the PR, I worry that it will cause issues with paths with ']]' in their names. I know that this is very unlikely, but you never know how nvim will be used, and how lack of escaping might result in a rm -rf / being executed. The way to solve this issue would be to create a lua string escaping function that converts a string like testing ]] 1 2 to lua code like this [[testing]] .. "]]" .. [[ 1 2]]. This will then allow us to insert the string directly the way you have done it.
I don't have time to get to this soon as it is academic conference season, however I will get to it eventually it you haven't already!

Ty @vijaymarupudi looks great :)

@vijaymarupudi, I did some testing with your lua_escape function and it fails when the string ends in a ]:
print(lua_escape("test]"))
-- results in the invalid string "[[test]]]"
-- trying to use this string will result in:
:lua print([[test]]])
E5107: Error loading lua [string ":lua"]:1: ')' expected near ']'

I think there's a simpler solution to that by using lua nested quotes, which are achieved by wrapping the string with [=[<string>]=] or [==[<string>]==] (instead of  [[]]):
:lua print([=[test]]=])  -- prints "test]"
:lua print([=[test]]]=])  -- prints "test]]"
:lua print([==[test]]==])  -- prints "test]"

Change this:
https://github.com/vijaymarupudi/nvim-fzf/blob/5ca0732c3437d7ac3857823962910e5634799ca3/lua/fzf/actions.lua#L61-L67
To this:
local call_arg_table_string = ("{ action_server=[==[%s]==], function_id=%d }"):format(
    action_server_address, id)

local action_helper_vim_cmd = vim.fn.shellescape(("lua loadfile([==[%s]==])().rpc_nvim_exec_lua(%s)")
    :format(nvim_fzf_directory .. "/action_helper.lua", call_arg_table_string))

Good catch! I just pushed a fix for that here https://github.com/vijaymarupudi/nvim-fzf/commit/d0b4d60704f27eddaa96b921f10a4a2a20f1b20e
I think the problem with the nested quotes solution is that you'd have a problem with strings like "test]==". Then that would become [==[test]==]==] which is invalid lua code. I think the escaping solution implemented now, thanks to your testing, doesn't have any such limitations.


Dragging an item does not scroll the container

In the demo example, dragging an item does not scroll the container.
See https://youtu.be/SHO-s7GOS2k (run in Chrome 57.0.2987.133)

Hi, are there any plans to fix it? Thanks.

It is probbably caused by change in GC https://bugs.chromium.org/p/chromium/issues/detail?id=588448

Proposed fix. Needs improvements...
patch.diff.txt


Camel JBang shell command

A simple shell command which will enter a REPL loop with nice completion and help.

How much other dependencies does jline bring in?
I wonder as camel run should ideally be without too much clutter. And maybe we need to find a way for jbang to be able to dynamic select DEPS based on the command. The DEPS is a bit too static for us.

Also can you update the jbang docs, as this seems like a great feature for users to learn and play with camel-jbang and its worth to have in the docs. See under docs root folder there is a camel-jbang.adoc file.

How much other dependencies does jline bring in?

There's no required dependency at all in JLine.  They are all either optional or test deps:
https://repo1.maven.org/maven2/org/jline/jline/3.27.1/jline-3.27.1.pom

I wonder as camel run should ideally be without too much clutter. And maybe we need to find a way for jbang to be able to dynamic select DEPS based on the command. The DEPS is a bit too static for us.

@gnodet did you get time to look at this - can we avoid DEPS to keep the file as before - there are also some camel jbang code that runs a custom camel version that creates a .java source that would break if this file now have extra deps instead of just in the pom.xml

@gnodet did you get time to look at this - can we avoid DEPS to keep the file as before - there are also some camel jbang code that runs a custom camel version that creates a .java source that would break if this file now have extra deps instead of just in the pom.xml

I'll have a look at it today.


Using --end with time only on a log file containing multiple days stops at first day

Context
pgbadger version 11.4 on Debian Buster. I think this is the same problem viewed in #613 but I preferred to open a new issue with full information.
Expected behaviour
When I pass --end without a date (time only), I expect pgbadger to end the parsing at this time, ignoring log lines from this time to 23:59:59, for each day present in the file.
Observed behaviour
Pgbadger applies the end time constraint on the first day only.
The behaviour for --begin seems correct (see below).
Steps to reproduce
Sample log file
The sample contains 8 connection sessions:

2021-02-14 01:34:02
2021-02-14 08:00:02
2021-02-14 20:29:52
2021-02-14 21:48:40
2021-02-15 01:20:04
2021-02-15 08:07:45
2021-02-15 20:29:06
2021-02-15 21:02:06

It is conveniently named test.log, simulating a weekly rotated log file (I think this is the default in Debian):
2021-02-14 01:34:02 CET [30291]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-14 01:34:02 CET [30291]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-14 01:34:02 CET [30291]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.007 user=postgres database=template1 host=[local]
2021-02-14 08:00:02 CET [28538]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-14 08:00:02 CET [28538]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-14 08:00:02 CET [28538]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.007 user=postgres database=template1 host=[local]
2021-02-14 20:29:52 CET [3202]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-14 20:29:52 CET [3202]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-14 20:29:52 CET [3202]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.017 user=postgres database=template1 host=[local]
2021-02-14 21:48:40 CET [22313]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-14 21:48:40 CET [22313]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-14 21:48:40 CET [22313]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.007 user=postgres database=template1 host=[local]
2021-02-15 01:20:04 CET [1974]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-15 01:20:05 CET [1974]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-15 01:20:05 CET [1974]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.008 user=postgres database=template1 host=[local]
2021-02-15 08:07:45 CET [12772]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-15 08:07:45 CET [12772]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-15 08:07:45 CET [12772]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.004 user=postgres database=template1 host=[local]
2021-02-15 20:29:06 CET [23197]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-15 20:29:06 CET [23197]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-15 20:29:06 CET [23197]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.007 user=postgres database=template1 host=[local]
2021-02-15 21:02:06 CET [13032]: db=[unknown],user=[unknown],app=[unknown],client=[local] LOG:  connection received: host=[local]
2021-02-15 21:02:06 CET [13032]: db=template1,user=postgres,app=[unknown],client=[local] LOG:  connection authorized: user=postgres database=template1 application_name=psql
2021-02-15 21:02:06 CET [13032]: db=template1,user=postgres,app=psql,client=[local] LOG:  disconnection: session time: 0:00:00.007 user=postgres database=template1 host=[local]

First run without times
First we do not pass --begin and --end, to validate the parsing of the whole file:
/usr/bin/pgbadger --quiet --prefix "%t [%p]: db=%d,user=%u,app=%a,client=%h " --outfile - test.log | grep -E '^(Log start from|Total number of sessions:)'

Log start from 2021-02-14 01:34:02 to 2021-02-15 21:02:06
Total number of sessions: 8

This matches the first and last lines in the sample, and the total number of sessions is correct.
Second run with --begin
Then we apply a begin time, to filter out all sessions from 00:00:00 to 07:29:59:
/usr/bin/pgbadger --quiet --prefix "%t [%p]: db=%d,user=%u,app=%a,client=%h " --begin "07:30:00" --outfile - test.log | grep -E '^(Log start from|Total number of sessions:)'

Log start from 2021-02-14 08:00:02 to 2021-02-15 21:02:06
Total number of sessions: 6

This matches the first line after 2021-02-14 07:30:00 and the last line of the sample, which is correct and the number of sessions seems correct too as it should match:

2021-02-14 08:00:02
2021-02-14 20:29:52
2021-02-14 21:48:40
2021-02-15 08:07:45
2021-02-15 20:29:06
2021-02-15 21:02:06

It seems to ignore the sessions at 2021-02-14 01:34:02 and at 2021-02-15 01:20:04 which is the expected behaviour.
Third run with --end
When I pass --end 20:30:00 to the command above, we can see in the Global Information section the parsing ending at 2021-02-14 20:29:52 (last line before 20:30 on the 14th), ignoring all log lines in the 15th:
/usr/bin/pgbadger --quiet --prefix "%t [%p]: db=%d,user=%u,app=%a,client=%h " --end "20:30:00" --outfile - test.log | grep -E '^(Log start from|Total number of sessions:)'

Log start from 2021-02-14 01:34:02 to 2021-02-14 20:29:52
Total number of sessions: 3

This matches the first line in the sample and the last line before 2021-02-14 20:30:00, ignoring lines for 2021-02-15.
The total number of session is incorrect, it seems to match the following sessions:

2021-02-14 01:34:02
2021-02-14 08:00:02
2021-02-14 20:29:52

But it should be 6 because it should match the following ones:

2021-02-14 01:34:02
2021-02-14 08:00:02
2021-02-14 20:29:52
2021-02-15 01:20:04
2021-02-15 08:07:45
2021-02-15 20:29:06

Fouth run with both parameters
The last run seems to confirm the "stop on first day" behaviour:
/usr/bin/pgbadger --quiet --prefix "%t [%p]: db=%d,user=%u,app=%a,client=%h " --begin "07:30:00" --end "20:30:00" --outfile - test.log | grep -E '^(Log start from|Total number of sessions:)'

Log start from 2021-02-14 08:00:02 to 2021-02-14 20:29:52
Total number of sessions: 2

We see pgbadger stopping on first day, and this is confirmed by the number of sessions.
It seems to match:

2021-02-14 08:00:02
2021-02-14 20:29:52

And should be matching (and having a total number of sessions equal to 4):

2021-02-14 08:00:02
2021-02-14 20:29:52
2021-02-15 08:07:45
2021-02-15 20:29:06

Conclusion
The --end parameter when defined with a time only seems to stop the whole parsing instead of continuing and just ignore the lines out of the range as --begin does.

Commit 878d6e6 fixes this issue. Thanks a lot for the test case it was very helpful. I have added this test in the regression  test.

Thank you very much!


install loop on password a

I was syncing the blockchain for the first time when randomly I got the i2c /dev entries driver issue. I flashed to a new sd card and got past the i2c issue, but then it tried to recover my previous setup. It has me entering a Password A, then forcing a reboot, then enter Password A, then force a reboot. On and on like this.

Running in to various problems, but after re-flashing, this is no longer one of them.


Add target filtering

The targets = [] configuration can be used to specify one or more
targets you intend the project to build for, removing any target specific
crates from the graph that don't match at least 1 of the specified targets.
Resolves: #63

There isn't much documentation for this feature, I plan on adding it as part of #94 before doing a proper release.


Change video quality in progressive download sources

Paella 7 lost the ability to change video quality for progessive download sources. This is confirmed by the docs in the section "Features lost since Paella Player 6.x" (second paragraph there).
This is slowly coming up as an issue for a couple of our clients to the point where it is blocking them from upgrading. Yes, HLS might be the future, but not everyone is there yet, plus many institutions still have large collections of media published as progressive download that they would like to continue to offer without having to republish and/or -encode everything.
Accordingly, we consider this a rather essential feature for the standard Opencast player, and my question is: Are there any plans to reintroduce it? And if not: Would you be opposed to someone from ELAN trying their hand at contributing the feature?

I totally agree with Julian. At the University of Bern we currently have over 75000 videos in Opencast, encoded in three different resolutions. We are currently using Paella Player 6 and progressive download to play the videos.
In order to provide the same service with three different resolutions, we would have to re-encode each of the 75000+ videos.
We would love to migrate to Paella 7 and also to HLS streaming. But ideally we could offer all the old videos as progressive download (all 3 resolutions) and only the newly uploaded videos as HLS.

HI Julian and Sascha
At Valencia we have a similar issue with the legacy videos, and we do have a plugin that allows Paella Player 7 to work with progressive downloads.
However, it has several issues, most of them related to changing resolution while playing a video. In the current state, changing the resultion does a full reload of the interface and goes back to the beggining. Also, going to fullscreen may trigger the same effect if there is a resolution change involved.
We didn't found a good solution for those, and because of that we dropped support of progressive downloads in PP7.
Of course we may share the plugin, and you will be welcome to improve it. However, we are not eager to provide long-term support of it.
Maybe we may set up a meeting next week to discuss options

Meeting sounds good. 😄 I'll just email you with a few suggestions for an appointment if that's ok with you.

Unfortunately, I'll be on holiday next week. But of course I'll be interested in the outcome of your discussion.

Dynamic quality change in progressive download videos was abandoned in paella-core because of the problems it caused. In the current context it is even impossible to implement on some platforms, due to the restrictions imposed by browsers with autoplay videos.
To make this resolution change, the video source must be replaced, playback must start and jump to the previous time instant. There are several actions that must be done asynchronously, and although the main action is triggered by the user, after the first asynchronous response it is usual that the browser blocks the action.
This is detailed in the presentation document:
https://paellaplayer.upv.es/#/doc/paella_player_7_presentation.md
Because of all this, this feature will never be officially implemented, but remember that in case you don't mind dealing with all these problems, you can implement your own video plugin:
https://paellaplayer.upv.es/#/doc/video_plugin.md


Save the output file somewhere logical

The .md file is not created inside the project folder, so I get a VS error when I attempt to save.
Options:

Create a new folder called flow-vis or something at the project root
Just put the files in the project root
Give a settting to determine where the visualizations should be stored, relative to the project root.

wrong repo, sorry


Online Demo please?

Sounds great -- would it be possible to get a demo online? Would like to add to react.rocks... thanks!

@winkler1 it should be easy enough to add a gh-pages branch since there's already a demos directory/build.
i'm currently on holiday so i won't be able to get to it for a week or so, if anyone else wants to take the lead.

I might be able to help with this. Let me see if I can work on getting a PR for this. :smiley:

@winkler1 i've added a link to the demos build in the latest readme.

:+1:


why i cannot run boot2docker while vboxmanage works well on my win7x64 system?

this  issue is a complement to issue 698, i create new one, because it maybe more clear to show some main point without reading to much details.
now the point is, i can run vboxmanage, and can get information of vms using vboxmanage, but why i failed when using boot2docker? does the error happen in the porcess when go invoke vboxmanage? (i am using administrator priviledge to run these commands)
the screenshot is as follows:

some suspection:
my system is not win7 sp1, and i cannot install vs 2013 on my system, does this issue have something to do with this?
or doest boot2docker hard code some path which is defaut to system? this environment variable maybe changed by me which may lead to this issue?

very odd. I've just managed to do exactly the same thing on a just installed windows box.
I have, however, not tested on a windows system that isn't up to date.


End of task bar doesn't reach the end date

The end of task is December 31, 2024
But the bar ends in October

roadmap.set_title("Title")
roadmap.set_timeline("M", start="2023-01-01", number_of_items=34)

group = roadmap.add_group("Group")

task = group.add_task("Task", "2023-01-01", "2024-12-31", fill_colour='#00FF00')
roadmap.draw()
roadmap.save("demo01.png")```

Thanks for letting me know. It will be fixed.

@antmanin This is now fixed in the latest version 1.3.2.

@csgoh it works, thanks!


test trigger

Type of change
Select the type of your PR

Bugfix
Enhancement / new feature
Refactoring
Documentation

Description
Please describe your pull request
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

/perf

/perf

/perf

/perf

/perf

/perf

/perf

/perf


Added stats for Blocks #3112

Signed-off-by: Kunal Kushwaha<EMAIL_ADDRESS>Partially fix #3112

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
Added stats:

Last Refresh
Total Number of Blocks
Total Number of Blocks in Each Group (Hover)

Also, it'll be nice if you can add some tests :)

This PR contains a lot of unrelated commits, maybe something went iffy during rebase? Anyways the outcome looks solid and I'd definitely want to merge it. @kunal-kushwaha can you clean up the PR so that we can get this merged? Let me know if you need any help with this.

This PR contains a lot of unrelated commits, maybe something went iffy during rebase? Anyways the outcome looks solid and I'd definitely want to merge it. @kunal-kushwaha can you clean up the PR so that we can get this merged? Let me know if you need any help with this.

Oops, will send an update soon.

@prmsrswt Just need to update the tests now. Been getting this error:
Summary of all failing tests
 FAIL  src/thanos/pages/blocks/Blocks.test.tsx
  ● Blocks › when data is returned › renders sources

    expect(received).toHaveLength(expected)

    Expected length: 8
    Received length: 0
    Received object: {}

      29 |
      30 |       const sourceViews = blocks.find(SourceView);
    > 31 |       expect(sourceViews).toHaveLength(8);
         |                           ^
      32 |     });
      33 |
      34 |     it('fetched data with different view', async () => {

      at Object.<anonymous> (src/thanos/pages/blocks/Blocks.test.tsx:31:27)

  ● Blocks › when data is returned › fetched data with different view

    expect(received).toHaveLength(expected)

    Expected length: 8
    Received length: 0
    Received object: {}

      40 |
      41 |       const sourceViews = blocks.find(SourceView);
    > 42 |       expect(sourceViews).toHaveLength(8);
         |                           ^
      43 |     });
      44 |   });
      45 |

      at Object.<anonymous> (src/thanos/pages/blocks/Blocks.test.tsx:42:27)

 FAIL  src/thanos/pages/blocks/SourceView.test.tsx
  ● Blocks SourceView › encountered a declaration exception

    The target 'countToolTip' could not be identified in the dom, tip: check spelling

      20 |   };
      21 |
    > 22 |   const sourceView = mount(<SourceView {...defaultProps} />);
         |                      ^
      23 |
      24 |   it('renders a paragraph with title', () => {
      25 |     const title = sourceView.find('div > Tooltip').first();

@prmsrswt all greeeeeen

@prmsrswt @bwplotka Ready for review 😄

@onprem requested changes made

Waiting for last approve from @onprem

It automatically "dismissed stale reviews" when I pushed new commits 👀

Oh looks like we missed updating bindata.go, Can you run make assets and then push the changes?

Hey @onprem
Been getting this error, tried resolving it by changing dependency versions but no luck.
$ react-scripts build
Creating an optimized production build...
Failed to compile.

./src/utils/index.ts
  Line 0:  Parsing error: Cannot read property 'map' of undefined

Can you maybe check if make assets is working for you with the PR when you get time?

@onprem requested changes made, all greeen ✅

@onprem Let me know when we can merge this I'll then resolve the merge conflicts 👍

Hey, sorry of all the delay :sweat:
Can you rebase it now? Let's get this in as we are planning to do a release soon.
One interesting thing to keep in mind during rebase is that now we have Dark Mode in the UI, so you might want to verify your styles stay consistent with the theme.

@onprem resolved merge conflicts

@onprem Is there still interest to get this in?


Fixes incident type plugin metadata UI

Pulled the PR locally. Getting none is not an allowed value when trying to save. Also, the + button to add an item does not work.

Looks like the PluginMetadata Pydantic model expects slug but we're not providing it:
{"detail":[{"loc":["body","plugin_metadata",0,"slug"],"msg":"none is not an allowed value","type":"type_error.none.not_allowed"}]}


Diag sub matrix

Here is a much simpler but surprisingly slower version of the iterator (at least on my system).
I suspect it has been slowed down by MatrxSlice initialisation, but I can't see why exactly, perhaps we're doing something wrong elsewhere.
This is not intended to be merged but I wanted to show a simpler alternative without using pointers.

Forgot to mention that I had to change get_unchecked(_mut) function to make it work (I believe this particular change should actually go in master anyway)

Yes that's exactly that. This is what is done for slices in particular.
On 30 Sep 2016 14:39, "Andreas Borgen Longva"<EMAIL_ADDRESS>wrote:

@Andlon commented on this pull request.
In src/matrix/slice.rs
https://github.com/AtheMathmo/rulinalg/pull/61#pullrequestreview-2318278
:

@@ -66,7 +66,9 @@ pub trait BaseMatrix: Sized {
}

 /// Get a reference to a point in the matrix without bounds checking.

unsafe fn get_unchecked(&self, index: [usize; 2]) -> &T {

unsafe fn get_unchecked<'a>(&self, index: [usize; 2]) -> &'a T

   where T: 'a

{

I don't understand what the explicit lifetime parameter here does. Would
you mind explaining it to me?
Could it be that in the first case, the compiler automatically thinks that
the reference has the lifetime of the struct, but in the second case you
tell it that it explicitly has a different lifetime...? I'm confused, and
very curious!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AtheMathmo/rulinalg/pull/61#pullrequestreview-2318278,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHAszo9wb31KLyI7Kpc2NXSD898QaDUzks5qvQMdgaJpZM4KLBGj
.

Very nice!
I hacked up some benchmarks based on your code:
test linalg::iter::mat_diag_iter_100_100           ... bench:         152 ns/iter (+/- 0)
test linalg::iter::mat_diag_iter_100_500           ... bench:         152 ns/iter (+/- 2)
test linalg::iter::mat_diag_iter_10_10             ... bench:          32 ns/iter (+/- 0)
test linalg::iter::mat_diag_iter_10_50             ... bench:          33 ns/iter (+/- 1)
test linalg::iter::mat_diag_iter_500_500           ... bench:         685 ns/iter (+/- 4)
test linalg::iter::mat_diag_manual_100_100         ... bench:         109 ns/iter (+/- 0)
test linalg::iter::mat_diag_manual_100_500         ... bench:         100 ns/iter (+/- 1)
test linalg::iter::mat_diag_manual_10_10           ... bench:          30 ns/iter (+/- 0)
test linalg::iter::mat_diag_manual_10_50           ... bench:          30 ns/iter (+/- 0)
test linalg::iter::mat_diag_manual_500_500         ... bench:         685 ns/iter (+/- 1)

As you can see, for larger matrices, they seem to perform almost exactly the same, but for whatever reason, in the 100x100 example the diagonal iterator performs a fair bit worse than manual. Not sure what's going on here!

Yeah, I'm not an expert in profiling and I don't know what's happening either.

From my understanding this is an unsafe change - as detailed in my other comment.
To give a slightly higher level reasoning. We cannot safely have an iterator which can return more than one mutable reference to the same structure. The reasoning is that rustc has no way to determine that the pointers are indeed to different locations - we could collect our iterator and have break borrowing rules. This is why we need unsafe code and pointers to do this. We have to manually enforce the borrow rules ourself by ensuring that each of the returns &mut T references are to unique items.

From my understanding this is an unsafe change - as detailed in my other comment.
To give a slightly higher level reasoning. We cannot safely have an iterator which can return more than one mutable reference to the same structure. The reasoning is that rustc has no way to determine that the pointers are indeed to different locations - we could collect our iterator and this would break borrowing rules. This is why we need unsafe code and pointers to do this. We have to manually enforce the borrow rules ourself by ensuring that each of the returned &mut T references are to unique items.

I'm slightly confused about this. That it needs to be unsafe is clear, but I don't understand why it needs to be implemented with pointers. In either case we are manually enforcing the borrow rules. In some sense, the two approaches are equivalent in that way. Could you elaborate on what the difference is...?

An easier way to convince ourselves this change is unsafe:
fn next(&mut self) -> Option<Self::Item> {
    unsafe { Some(self.square_matrix.$get_unchecked([0, 0])) }
}

This code change will still compile and would let us collect an iterator that has multiple mutable references to the same point: diag_iter.take(5).collect::<Vec<_>>().
Our users could also do this outside of this iterator using just the get_unchecked_mut function.

It took me some time to digest.
Sorry for the pull request and thanks for the review!
I still don't fully understand why we are "allowed" to do some stuff with unsafe pointers but not with other unsafe methods.

It took me some time to digest.

It may have taken longer as I'm still trying to figure out some of the reasoning myself...

Sorry for the pull request and thanks for the review!

There is no need to apologise! I should be thanking you - it is always good to discuss these things and I'd hate to miss out on any other suggestions in future :)

I still don't fully understand why we are "allowed" to do some stuff with unsafe pointers

I think the only good answer to this is that raw pointers are nasty. Once we enter raw pointer land we lose all information about lifetimes and origin of the data. That is why dereferencing the pointers is unsafe. Because of this whenever we interface over raw pointers we have to be careful that we enforce all of the various borrowing and lifetimes rules ourselves.

@tafia Am I ok to close this now?

Because of this whenever we interface over raw pointers we have to be careful that we enforce all of the various borrowing and lifetimes rules ourselves.

I think this means that we need a way to test for lifetimes. Not saying we need to figure that out for the case of diagonal iterators, but this is something that can very subtly break in future changes without anyone noticing.

Let me iterate once more, I'll remove the unsafe get_unchecked
modification.
I think having the range instead of the pos_end is simpler to understand.
On 30 Sep 2016 17:30, "James Lucas"<EMAIL_ADDRESS>wrote:

@tafia https://github.com/tafia Am I ok to close this now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AtheMathmo/rulinalg/pull/61#issuecomment-250775448,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHAszs6vohE9g4U5x3ePdqNmXRlRTAQmks5qvSsagaJpZM4KLBGj
.

@Andlon I think that perhaps this is another case where the compilefail crate would be handy. I'm not sure how else to test this other than writing a bunch of not-allowed things and ensuring they remain not-allowed.
I agree it is very valuable though - much of the MatrixSlice work is very unsafe. We may well find a few errors when writing these tests...

I think having the range instead of the pos_end is simpler to understand.

I think so too - hopefully this is not the source of the performance regression.

@AtheMathmo: yeah, we'll definitely need something like compiletest at some point. Still haven't got any response to the issue I posted there though.

Reverted to a safe state. Unfortunately the perf regression is still here. I tried using a simple counter instead if a range iterator but it didn't improve. If someone has an idea of where it can come from I'd be very interested.

This build is failing as we need to merge the latest master in - there is a conflict with newer version of the num-crate (we needed a feature before it was released there).
Also I'm of the opinion that we should go for performance even if the implementation is a little more complex. I'm not really sure why the regression is there and haven't been able to tweak it out - I have a few more ideas but if none work I think we should stick with the existing version.
(Although I agree with your change to the benchmarks - it is a fairer comparison)

Although this is a much nicer implementation I'm closing due to the performance regression. Hopefully in future we can find a way to make this work!


Take into account privacy levels when resolving URL’s

Looks good, all straight forward. Noted where this should be using constants, +1 otherwise