Fix InputParser

What current issue(s) does this address, or what feature is it adding?

addresses #954

parse nested lists correctly

How did you solve this problem?
trial and error
How did you make sure your solution works?
manual testing and make test
Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

[x] Did you add any tests?
[x] Did you run make lint?
[x] Did you run make test?
[x] Are you making a PR to a feature branch or development rather than master?
[x] Did you add an entry to CHANGELOG.rst? (if not, please do)

Coverage increased (+0.008%) to 85.113% when pulling 5eee8c1701fa9ce202871a2c7c5587c2eb854a3a on jseagrave21:fix-inputparser into 69a1ef53378888b564bc838fbb795f6875f5478a on CityOfZion:development.

@ixje I haven't been able to figure out the issue yet. If you run this test:
def test_nested_lists_3(self):
        command, arguments = self.input_parser.parse_input('sc build_run sc.py False False False 0210 01 3 ["notused",["notused",["helloworld"]]]')
        self.assertEqual(command, "sc")
        self.assertEqual(arguments, ['build_run', 'sc.py', 'False', 'False', 'False', '0210', '01', '3', '["notused",["notused",["helloworld"]]]'])

it passes.
This is the error that is causing the problem.
neo> sc build_run /mnt/c/users/jseag/neo/smartcontracts/ParseListTest.py False False False 0210 01 3 ["notused",["notused",["helloworld"]]]
Saved output to /mnt/c/users/jseag/neo/smartcontracts/ParseListTest.avm
Could not execute command: argument should be bytes, buffer or ASCII string, not 'list'
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/venv/bin/np-prompt", line 11, in <module>
    load_entry_point('neo-python', 'console_scripts', 'np-prompt')()
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/bin/prompt.py", line 380, in main
    loop.run_forever()
  File "/usr/lib/python3.7/asyncio/base_events.py", line 521, in run_forever
    self._run_once()
  File "/usr/lib/python3.7/asyncio/base_events.py", line 1738, in _run_once
    handle._run()
  File "/usr/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/bin/prompt.py", line 232, in run
    traceback.print_stack()
Traceback (most recent call last):
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/bin/prompt.py", line 218, in run
    cmd.execute(arguments)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/Commands/SC.py", line 44, in execute
    return self.execute_sub_command(item, arguments[1:])
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/CommandBase.py", line 75, in execute_sub_command
    return self.__sub_commands[id].execute(arguments)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/Commands/SC.py", line 80, in execute
    tx, result, total_ops, engine = BuildAndRun(arguments, PromptData.Wallet)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/Commands/BuildNRun.py", line 72, in BuildAndRun
    debug_map=debug_map, invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/Commands/BuildNRun.py", line 95, in DoRun
    invoke_attrs=invoke_attrs, owners=owners, enable_debugger=enable_debugger)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/Prompt/Commands/Invoke.py", line 519, in test_deploy_and_invoke
    sb.push(subsub)
  File "/mnt/c/users/jseag/neo/neo-python-jseagrave21/neo/VM/ScriptBuilder.py", line 110, in push
    buf = binascii.unhexlify(data)
TypeError: argument should be bytes, buffer or ASCII string, not 'list'

Do you see what is wrong? I will keep working on it.

https://github.com/CityOfZion/neo-python/blob/7e292275298794d6286b755f32297132528af107/neo/VM/ScriptBuilder.py#L91
push() does not seem to know how to handle a list as its last resort is to treat it like a bytearray. Maybe there is a good reason for that, can't quickly tell. Try looking at C#'s ScriptBuilder and see what they do with arrays, perhaps they already have a way of dealing with them.

@ixje okay, how about now?

thanks!

100 points

https://neoscan.io/transaction/589328c622e101065f6717d61a332f93aac71cc68b665e194ef8c874a7e26669

Hello, when this fix will be available in master?

We are currently auditing the Mainnet to ensure correctness with the latest neo-cli version as used in the consensus nodes. Once that is done we will do a new master release. Unfortunately I can't give an exact time frame, but it's around 70% done.

In the meantime you could cherry pick this PR


Merge from grantami-bomanalytics-private

Incorporate all development from private fork
Obviously there's a huge number of commits here, that represent the complete development of the sustainability portion of this package. I have gone through the workflow files and cleaned out any private-specific additions though, so hopefully CI will complete.

Updated all relevant secrets, CI seems to be passing.

It looks reasonable from a quick spot check on some files.
Codacy raises valid points that we should eventually address. CI is failing when cloning the repo, which would go away if we switched back to using a dependency from PyPI

Updated to use the v2.0.0 of bomanalytics-openapi
See #388 for some codacy fixes. The others are either not real errors or more difficult to fix at this point

I think we'll have to put back the steps to allow long paths in CI. Filenames in the openapi package are just too long, even when the dependency is sourced from PyPI

Merging as-is, the codacy issues are acceptable.


The pane toggle command throws Uncaught TypeError: Cannot read property 'dispatch' of undefined

When pressing cmd+k, cmd+g

Atom Version: 1.7.2
System: Mac OS X 10.11.3
Thrown From: go-debug package, v0.1.8
Stack Trace
Uncaught TypeError: Cannot read property 'dispatch' of undefined
At /Users/rokche/.atom/packages/go-debug/lib/commands.js:63

TypeError: Cannot read property 'dispatch' of undefined
    at atom-workspace.action (/Users/rokche/.atom/packages/go-debug/lib/commands.js:63:28)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:580:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:388:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:98:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands
     -0:09.2.0 find-and-replace:find-previous (atom-text-editor.editor.mini.is-focused)
     -0:06.1.0 core:cancel (div.panels)
     -0:01.0 go-debug:toggle-panel (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "audioBeep": false,
    "disabledPackages": [
      "angularjs",
      "angularjs-helper",
      "angularjs-snippets"
    ],
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store"
    ],
    "themes": [
      "atom-dark-ui",
      "monokai"
    ]
  }
}

Installed Packages
# User
autocomplete-go, v1.0.6
autocomplete-paths, v1.0.2
bootstrap-3-snippetset, v0.0.6
bootstrap3-snippets, v0.1.2
builder-go, v1.0.0
emmet, v2.4.3
go-config, v1.1.4
go-debug, v0.1.8
go-get, v1.0.3
go-plus, v4.1.0
go-quick-import, v0.2.0
go-signature-statusbar, v1.0.2
godoc, v0.2.0
gofmt, v1.1.6
gometalinter-linter, v1.1.0
gorename, v1.0.2
gotests, v0.2.5
linter, v1.11.4
linter-golint, v0.3.0
linter-golinter, v1.2.0
linter-gotype, v0.1.0
linter-govet, v0.1.5
minimap, v4.22.1
monokai, v0.18.0
navigator-godef, v1.0.3
remote-sync, v4.0.1
robin-language-php, v0.9.0
tester-go, v1.0.4

# Dev
No dev packages

fixed in b1f0607bff615db61c7f3a23fb374b1e7fcbffe1

Got the same issue.

do you have the most recent version (0.1.11)?

Sure - https://infinit.io/_/RBHUTE4.png

you still have 0.1.8... you have to click the update button...

Oops, you right. Update solves the problem, thanks.


Update to MC game version 1.19.3

Update forge and mappings to support a build for MC 1.19.3

I am currently waiting on parchment mappings to be updated, this is on review on their end so hopefully it won't be too long.

Busy working on other things for the next week or so. Will get back to this soon.


Implement logging for moderation events

Description

To send metrics from the Django API to AWS CloudWatch where they will be visualised, the metrics will be sent as structured logs that can be parsed by AWS Logs Insights.
Add logging for moderation events when Report and Decision models are created/modified. The logging should be emitted from save method on these models.
Additional context

https://github.com/WordPress/openverse/issues/3432
Implementation plan

The addition of logging to ModerationDecision is tightly coupled with #3636 and can be implemented simultaneously or after that issue is resolved.

This is blocked on #3432.

Reprioritised as per https://github.com/WordPress/openverse/issues/383#issuecomment-2151103330

Closing as won't do as per https://github.com/WordPress/openverse/issues/383#issuecomment-2153354643


RTSP on WEB

Any plans to support RTSP urls on WEB?
Thanks.

Ask the developers of your web browser.


transformers 4.21.3 doesn't support load_in_8bit

Using transformers version 4.21.3, I see this error:
Using `load_in_8bit=True` to use quanitized model
Traceback (most recent call last):
 File "bloom-accelerate-inference.py", line 115, in <module>
   model = AutoModelForCausalLM.from_pretrained(model_name, **kwargs)
 File "/disk1/srahnamoon/llm/.lvenv/lib/python3.8/site-packages/transformers/models/auto/auto_factory.py", line 446, in from_pretrained
   return model_class.from_pretrained(pretrained_model_name_or_path, *model_args, config=config, **kwargs)
 File "/disk1/srahnamoon/llm/.lvenv/lib/python3.8/site-packages/transformers/modeling_utils.py", line 2113, in from_pretrained
   model = cls(config, *model_args, **model_kwargs)
TypeError: __init__() got an unexpected keyword argument 'load_in_8bit'

upgrading to 4.22.0 resolved the issue. Maybe the documentation for HF Accelerate solution needs to be corrected?

Yes, I am aware of this. I think we can leave it as it is.
The current release doesn't provide LLM.int8() support.
Its better to build transformers from source.


add german translation de_de.json

adds the translation file de_de.json
if you want to I can also open pull requests for the other versions/branches

i also approve of this, i just don't know how erdragh did that

i also approve of this, i just don't know how erdragh did that

Go to the files changed tab, then on the top right review


Fix one typo in the comments

Signed-off-by: Hao Ziyu<EMAIL_ADDRESS>

👍 @hzy001  Can you sign http://druid.io/community/cla.html

@fjy done


Grunt Build in SAP Web IDE

Hi,
thanks for making CachebusterInfo.json available in @sap/grunt-sapui5-bestpractice-build": "1.3.50.
Building outside WebIDE there is currently an issue inside task devx-updateNeoApp!
The path is only correctly resolved on windows and not on Linux!
On windows my neo-app.json
"welcomeFile": "/webapp/index.html",
will be correctly changed to
"welcomeFile": "/index.html",
but this does not work for our CI/DI on Linux!
Maybe inside
var sSourceFolderRelativePath = "/" + grunt.config.data.dir.appFolder;
the appFolder is not relative on Linux and therefore this does not work.
It would be great to get that fixed, because we are developing locally and building/deploying it to MTA using git pipeline.
BTW: Do you have any info how to use the new feature

task for building an HTML5 module inside full-stack projects. The build results are stored as part of the .mtar file.

Please let me know the fixed version number.
Thanks
Holger

I guess this problem resides in getComponentParent / getRootDir / isComponentInCurrentFolder.
getComponentParent already has some special support for absolute paths but does this only for very special cases (webide?).
Whap happens is, that appFolder (which is set to componentParentDir) happes to be something like this on linux: /home/user/code/customer/project/webapp/.
devx-updateNeoApp tries to replace that whole thing in oNeoAppJsonContent.welcomeFile, which does not work since welcomeFile is something like /webapp/index.html.
In previous versions appFolder (was then called webapp) was fixed to /webapp which is why it worked in this case.
I have not found the exact point where the path resolution failes but getComponentParent is where I would start tracing the issue.

Hi Holger,
This is a good point. I have observed more places in the grunt best practices that don't treat correctly the path resolution. We need to use Path.join() instead concatenation. I will open an internal ticket for that and let you know as soon as we release a fixed version.
Thanks,
Alex

Hi Holger,
A fix is available with @sap/grunt-sapui5-bestpractice-build version 1.3.55
Regards,
Gaia

Hi Gaia,
it is working as expected!
Thank you.
Currently the sap-ui-cachebuster-info.js is not generated if i deploy using SAP Web IDE Full-Stack.
Is SAP aware of this bug?
Regards Holger

Hi Holger,
What do you mean "deploy using SAP Web IDE Full-Stack"? Do you mean deploy multi-target project (mta) project?
Thanks,
Alex

Hi Alex,
if i am building locally, it works for me.
Trying to deploying using the SAP Web IDE Full-Stack means i am using the new SAP Web IDE Full-Stack app inside SAP Cloud Plattform that uses build from grunt.loadNpmTasks("@sap/grunt-sapui5-bestpractice-build");
Since i am using the IDE integrated build process, i know that there is a special switch/case inside the grunt-sapui5-bestpractice-build. Doing it this way, there is no sap-ui-cachebuster-info.js  build/deployed to the corresponing html5 app.
Inside the Web IDE Full Stack the formerly integrated build/deploy process have been removed/reworked by using more public node/grunt process (the same way i am using locally), but the generated/handled artifacts in the target html5 container differ from the one generated locally (in this case the missing sap-ui-cachebuster-info.js.
I hope, this is understandable.
Regards Holger

Hi Holger,
I am not sure if I understood you right. But, I also success to build it locally and it worked for me (the cache buster file successfully created for me). If you do that from the Full Stack Web IDE (the build process) it also builds it correctly but you can't see the sap-ui-cachebuster-info.js file since this is very hidden file and therefore you can't see it in the file structure. The only way to see it is to export the project to your downloads and to open the archive file and then you will see it under the dist folder.
Thanks,
Alex

Hi Alex,
first of all thanks for the hint, that even when selecting show hidden fields option in Web IDE, the cachebuster will not be shown (for whatever reason ;-)
If i export the project from web ide, i can see that /dist/sap-ui-cachebuster-info.js is part of the archieve,
but it seems to be missing in the scp deployed version.
An example for the issue is my current youtube control
https://github.com/hschaefer123/youtube
If i deploy this with Web IDE to SCP HTML5
https://youtube-p1940953245trial.dispatcher.hanatrial.ondemand.com/index.html
you will get an 404 eror on
https://youtube-p1940953245trial.dispatcher.hanatrial.ondemand.com/sap-ui-cachebuster-info.json?sap-ui-language=en
So i think, the Web IDE hide feature for special file extensions maybe hide/excludes this file also on deployment?!? ;-) From my point that can be the only reason for this, because build seems ok (even not seeable on IDE) but deployment of this file misses.
Local deployment using
neo-java-web-sdk/tools/neo deploy-mta deploy-mta.properties
is working as expected!
Can you confirm this, or did you get a Web IDE using CacheBuster on SCP running this way?
Regards Holger

@avizov Can you respond or close this issue? Thanks.

Hi Holger,
I succeed to reproduce the issue the same as you described. Update you as soon as possible.
Thanks,
Alex

@jhornik Can you investigate this?

@thecodester Better if @avizov responds. He is probably on vacation until next week.

hi,
i can confirm that this has been fixed in the meantime.
Right now, i am using cachebuster feature in my deployed ui5 projects.
This was not recognized formerly because flp also has a custom cache feature.
Regards Holger

Hi Holger,
So, can you close the ticket?
Thanks,
Alex


Implement execute_dpe_cmd to reduce duplication in RT tests

This command takes in a DPE command and returns a DPE response. It reduces duplication in INVOKE_DPE calls in RT testing significantly.

Updated the DPE commit.


The efficiency of Get will decrease if too many Set  are executed

It's caused by the RWLock for the thread-safe. How about using sync.Map? It can increase the efficiency of Get.

I don't think sync.Map would be a good default choice.
Caches are gerenally read much more freaquently that updated.
Also, sync.Map is not as magical as you might think.
I would suggest sending your cache updates to a channel and recieving from it periodically in a loop (select with timeout) and updating the cache.


feat: Adding ComponentNotifier API

Description
This adds a proposal for a new API for flame, the ComponentNotifier.
This API offers the user change notifiers classes that are tied to FlameGame and its components so the user can be notified when a component is added, removed or updated.
This will enable users to:

Take the benefit of reactive programming inside the game
Have a simple way of watching certain states from the game, on Flutter Widgets

One important note here is that this proposal does not mean to replace integrations like flame_bloc, but rather provider an simple and out of the box solution, without any need of additional packages, since change notifiers are provided by flutter itself.
Opening this as draft for now to get feedback on the implementation, will write tests and docs once we have the final implementation.
Demo of the example:
https://user-images.githubusercontent.com/835641/188513760-e9f87e43-55e5-495e-8109-c16f07180a02.mov
Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

Breaking Change

[ ] Yes, this is a breaking change.
[x] No, this is not a breaking change.

Related Issues

I like this! Does this mean that I can do something like the following?
class Entity extends PositionComponent with Notifiable {

  Color _color = Color(0xffffffff);

  Color get color => _color;

  set color(Color value) {
    _color = value;
    notifyChanges();
  }
}

And then the UI can be like the following?
Widget build(context) {
  // I am probably butchering provider's API here, but hopefully you get the idea.
  final color = context.select<ComponentsNotifier<Entity>, Color>((e) => e.color);

  return Container(
    color: color,
    child: Text(entity.name),
  );
}

I like this! Does this mean that I can do something like the following?
class Entity extends PositionComponent with Notifiable {

  Color _color = Color(0xffffffff);

  Color get color => _color;

  set color(Color value) {
    _color = value;
    notifyChanges();
  }
}

And then the UI can be like the following?
Widget build(context) {
  // I am probably butchering provider's API here, but hopefully you get the idea.
  final color = context.select<ComponentsNotifier<Entity>, Color>((e) => e.color);

  return Container(
    color: color,
    child: Text(entity.name),
  );
}

Yes! Exactly


NetworkInformation.downlinkMax

https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation/downlinkMax

Presumably already covered by http://caniuse.com/#feat=netinfo

Available at https://caniuse.com/#feat=mdn-api_networkinformation_downlinkmax


Replace full manifest with compact manifest

The full manifest is confusing because it omits the artificially generated sequencing_process.provenance.document_id field which is included in the metadata of DCP generated matrices.
The short term solution is to replace the full manifest with the compact one for the project metadata download links.
The long term solution is to implement DataBiosphere/azul#2693.

Our short-term solution is to make the project manifest use the compact manifest format. However, the compact manifest file names are not user-friendly in the single project case. We are waiting for DataBiosphere/Azul#3077 to push this.

Thanks will check it out.
D


Unnecessary split of struct enum variant in match

input:
fn main() {
    match event {
        Event::KeyPressed { code: Key::Space, .. } => {
            println!("Space pressed");
        }
    }
}

output:
fn main() {
    match event {
        Event::KeyPressed {
            code: Key::Space, ..
        } => {
            println!("Space pressed");
        }
    }
}

If you replace Key::Space with Key::Spa to reduce the width from 55 columns to 53, rustfmt leaves it alone.
Is 54 columns the arbitrary width limit at which we must split? Shouldn't it be closer to the actual width limit, which is 100 by default?

The actual heuristics value involved here is struct_lit_width, which is set to 18 by default.
fn main() {
    match event {
        Event::KeyPressed {
            code: Key::Space, ..
        //  ^^^^^^^^^^^^^^^^^^^^ 20 characters
        } => (),
        Event::KeyPressed { code: Key::Spa, .. } => (),
                         // ^^^^^^^^^^^^^^^^^^ 18 characters
    }
}

The actual heuristics value involved here is struct_lit_width, which is set to 18 by default.

Well, if the consensus is that struct literals over 18 columns are unreadable, then I won't argue against it, but I would personally like to increase this limit in my project.
Is this configurable in rustfmt.toml? Rustfmt can't recognize struct_lit_width.

It's automatically set to about 18% of max_width. Configurability was removed for simplicity (https://github.com/rust-lang-nursery/rustfmt/commit/dd1fbca99a9518c6a0dfedd77300d0856c9d4a21).
https://github.com/rust-lang-nursery/rustfmt/blob/8b709c0019244d8554c0799084815146a5ce800a/src/config/options.rs#L377

You can try setting width_heuristics to Off or Max and see if that gives the look you want.
Closing since other than stabilising how width_heuristics is specified, there is no actionable change.

@nrc Is it possible to set it in rustfmt.toml? width_heuristics = "Max" gives
Error: Decoding config file failed:
invalid type: string "Max", expected struct WidthHeuristics for key `width_heuristics`
Please check your config file.

sorry, you should set use_small_heuristics not width_heuristics

you should set use_small_heuristics

Thanks, that works!


Couple tweaks to sharing

I would humbly suggest making the following changes to sharing:

Rename "Share item link" when selecting the comments thread to "Share Comments page" or something else that makes it more clear what the "item link" is. I get confused when doing this :)
I use trello a lot to save links and I notice that you save the URL as the title. This messes with trello cards. Taking a peek at your code I am 85% sure the solution is to use the "subject" optional argument in the share package to put in the title of the link.
Thanks so much!

Thanks for the suggestions! They've been implemented in 0aa079463b32796b3330e13efbca5ab178afb48a and 76f5656b0b70b75f942104a5e40eac56b3338b83, respectively. What do you think, is "Share thread link" clear enough? I don't like mentioning "comments" too much because it can technically contain more than that, like poll options.

I think "Share thread link" sounds great! Thanks for making these changes.


Crashes on startup on Fedora 38

Happy to drop logs or whatever is helpful.

Maybe we can try fixing it ourselves if our issues overlap? I have never developed for electron so it is definitely a new adventure for me.

When you try to start it from the CLI, can you get the logs an post them?  Often that will give some insight to why it's crashing.

Electron's autoUpdater does not support the 'linux' platform
[149465:0509/164404.584139:FATAL:gpu_data_manager_impl_private.cc(415)] GPU process isn't usable. Goodbye.
[1]    149465 trace trap (core dumped)  wiregui

Unfortuntaly, this does not give super much info. Is there some way I can extract this dumped core for you? If this would help of course.

For what it's worth, I also have two-ish GPUs (a discrete nvidia and the in-CPU one of the 7800X3D).
I'm actually about two do a fresh install of Fedora (from 38 Workstation to 38 Silverblue) so will have a look at any success under that and report back.

I mean, tbf, there's now built-in support for WG in Gnome 44, so the need for wiregui is a little less, but the lack of support for .conf files in Gnome 44 makes the conversion process not just difficult, but undocumented, so wiregui most definitely still has a place.


Make provenance printing optional

Also fix some docstrings.
@jburos

Coverage increased (+0.04%) to 59.733% when pulling 48173d8f2ce4ec30cee16fe89588c0a92f38a8fd on optional_provenance into 687b2b3330c149b7e9d2f8fc05579a723479380d on master.

Thanks @tavinathanson - just one minor suggestion, but otherwise looks good to me. Thanks for updating the docstrings

One comment - this makes me want to know, in which scenarios you'd like to turn off the data source summary?
Please LMK (or maybe create issues) if there are modifications that should be made to that process (ie to check but not print, or to print but not warn, to exclude certain packages from the summary, etc).

I have notebooks that initialize Cohorts inside a loop, and I don't want so many summaries printed. Open to smarter ways of handling this, though this seemed like a simple bandaid for starters. Will make an issue!

Coverage increased (+1.02%) to 60.71% when pulling 205f57af00fb5ca0940df11b028780b8820268ce on optional_provenance into 687b2b3330c149b7e9d2f8fc05579a723479380d on master.


chore: avoid Coe.coe in Data.Multiset.Functor

This was ported incorrectly from mathlib3.

Thanks, that did end up cleaner.
bors merge


[BUG] When adding repository to HACS it fails with error "Repostitory structure for master is not compliant"

When adding repository to HACS it fails with error "Repostitory structure for master is not compliant".  All other custom repositories I have tried work with no issues.

It's not a HACS repository, so yeah, that won't work, that's not a surprise or a bug.  This is an addon, not a custom integration, so you should add it as a repository to the native addon store.


Upgrade to Python 3.11

Codecov Report

Merging #13 (9d84a59) into master (313eddd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           13        13
  Lines          337       337
=========================================
  Hits           337       337

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Multiple users working on same document seem to break

save settings toggles seem to get out of sync if 2 users change the settings (so for instance a custom sheet now can only be added to the export if you UNCHECK its radio-button) and the Replace existing file(s) button if selected breaks the export if 2 different users try and export the same document - it just spins indefinitely. unchecking the box allows export

Are the users changing the export options live at the same time, or is one user making a change, exporting, then another user opens the sheet and makes changes then exports? Also, if one person makes a change and exports, then the other reopens the ESD sidebar, do the settings match?
Not sure if this indicates the parameters are being loaded incorrectly, or if they are simply overlapping. Though in the latter case I would think the last user's settings would be set as the sheet's parameters.


airs-bp3/apps/untill/airsbp: vpm compile panics if APPLICATION is removed

IMPORT SCHEMA 'github.com/untillpro/airs-scheme/bp3' AS untill;
IMPORT SCHEMA 'github.com/untillpro/airs-bp3/packages/air';

APPLICATION airsbp ( <-- remove this one
	USE untill;
	USE air;
);

duplicate of #1193


Lagging after last update

homebridge-ewelink v2.24.0
homebridge-config-ui-x v4.26.0 on Docker
devices sonoff mini , Dual, 4ch po and s20 plugs
the Lan mode is enabled on all of my devices they respond after 2-3 seconds , Using Homeassistant also this lag is not  happening  there .
I know that now its by default lan then ws .. not really sure why this is happening

Hi,
Sorry taken a few days for me to reply, I'm away at the moment so it's more difficult to get on a computer.
Are you still having lag issues?

Well its gone for now 😄

Appreciate what you are doing really.  Thank you

not lagging now , I guess it was HB related , closing it


Enhanced RDoc for CSV

@kou, Something's terribly wrong here.  The file doc/argument_io.rdoc is not here.  I  thought it was already merged, along with references to it.  How to resolve?


[REQ] Use thread local memoization for filters

Describe your feature request
Is your feature request related to a problem?
The current filter should be reasonable performant for not too complex filter configs.
However, if several LogIds and modules are set, but the global level is restrictive (e.g. error), logs with lower prio would always go through all checks, because they might get "allowed" by a later rule.
This is especially bad for debug/trace logs, because they will mostly not be allowed, but occur most often in code.
Describe the solution you'd like
Safe if a logid/addon was allowed by the filter or not to speed up further log filtering.
Since this probably requires a hashmap, it should be thread_local to prevent the need for RwLock on the global filter.
Problem is now how to notify threads, when the filter got changed and should be updated.
A solution could be to add a counter that is incremented by 1 every time a new filter is set. A thread should store this counter, and if it changed must reset the map (trying to be smart and check existing entries if filter rule still holds is probably too expensive).
Using a counter instead of flag is important, since it might take some time until all threads get notified, and it is not really possible to detect, when the flag could be reset.
However, wrap-around for the counter should be fine if the counter is big enough, and threads listen on changed instead of increased.
Considering #18 , memoization should also be added to the handler filter.
For the handler, the map could be local to the handler thread, since filtering on handler side will probably be done on receive-side rather than send-side. In this case, an AtomicBool could be used as flag to tell the thread to reset the map on filter change, since memoization is only local to this thread.
Describe alternatives you've considered
Global memoization inside LOGGER, but this would require Arc<RwLock<>>, and create many write locks, which has significant impact on performance.

Creating and updating maps has an impact on performance, this should be put behind a feature flag.


Let users could specify docker daemon start up environment variables

But I got this error and don't know how to fix:
task path: /home/shenghan/Codes/docker.ubuntu/tasks/main.yml:195
fatal: [ubuntu-1204]: FAILED! => {"failed": true, "msg": "The conditional check '(_pip_install_docker or pip_install_docker_compose) and _pip_docker_package_name == 'docker'' failed. The error was: {{ 'docker-py' if _pip_version_docker | version_compare('1.10.6', '<=') else 'docker' }}: Version comparison: unorderable types: str() < int()\n\nThe error appears to have been in '/home/shenghan/Codes/docker.ubuntu/tasks/main.yml': line 195, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n# See vars/main.yml for more information on this.\n- name: Clean previous docker-py package if installing docker.\n  ^ here\n"}

@wy193777 can you try your change with latest master? I saw some recent fix getting rid of ubuntu-12.04 support
also your PR might need adaption to use new daemon.json config


@azure/core-http isNode function will mistake electron for node

<EMAIL_ADDRESS>For now it is :
const isNode = typeof process !== "undefined" &&
    !!process.version &&
    !!process.versions &&
    !!process.versions.node.

maybe this make more sense as electron is more like a browser than Node.
const isNode = typeof process !== "undefined" &&
    !!process.version &&
    !!process.versions &&
    !!process.versions.node&&
    !process.versions.electron;

@jeremymeng can you look into this and also see what React-Native does?
/cc @mpodwysocki for Deno

@EmmaZhu suggested to add a browser version of isNode that just return false: https://github.com/Azure/azure-sdk-for-js/issues/21110#issuecomment-1537066462.
One interesting thing for Electron is that it is also kinda of Client and there's some option nodeIntegration that can enable node usage.

@mpodwysocki is this issue resolved in the latest core-util?

@amrit-moomie can you confirm what version of @azure dependencies you are using?

hi @xirzec
Actually I am using the latest release 12.17.0
I am running an angular project inside Electron shell (desktop app)
I started getting this issue recently https://github.com/Azure/azure-sdk-for-js/pull/20095#issuecomment-1125748196
I believe isNode function is not returning properly here, that is the root cause

@amrit-moomie if I understand you correctly, this is something you're experiencing with @azure/storage-blob and Electron? @mpodwysocki @jeremymeng

Yes.


Is there a way to reset the heading values at some point?

Hi Richard,
I'm using an MINI-Imu v9 with the magnetometer disabled, So every time I start the IMU, the heading is around 0.
Is there a way or function which I can use to reset at any point this initial heading?
E.g. To start fresh at any time if the IMU has moved and the yaw value is any value.
Best,
Isaac

If you just want to reset it to zero, you could call fusion.reset(). Would that work for you?

Yes. Thanks!


[RESTEASY-2176]:Client-side SSL - HostnameVerificationPolicy.STRICT s…

…houldn't accept wildcard certificates

@jimma, Chapter 50.3. "Apache HTTP Client 4.x and other backends" of the Resteasy doc refers to the HostnameVerifier. Maybe a note about the default behavior?

@jimma, Chapter 50.3. "Apache HTTP Client 4.x and other backends" of the Resteasy doc refers to the HostnameVerifier. Maybe a note about the default behavior?

Never mind. There are so many options in ResteasyClientBuilder ...


What are saved to "TRAIN_IMAGES_flickr8k_5_cap_per_img_5_min_word_freq.hdf5" file?

When I run the create_input_files.py, it saved 7 json files and 3 hdf5 files.
When I read, I understand the json files but I don't know what are the values of hdf5 files.
May I know what is saved in hdf5 files.
Best Regards,

just set breakpoint while save files, you can see it


Turn on background app refresh

Although there is no guarantee at what interval this will run, it would still be nice to try and pull any new observations.

This relates to #53


Standup written not in Latin gets accepted, but is not stored in DB.

When user writes standup using Latin letters, comedian replies with "Standup is accepted" but in fact stand up is not accepted and it does not get into DB. While everything written in Latin gets into DB correctly.

When creating DB should use this command: CREATE DATABASE db_name DEFAULT CHARACTER SET utf8 collate utf8_general_ci; this will allow to store utf8 chars.


Fix HistoricForeignKey when used together with prefetch_related()

Description
This fixes behaviour of HistoricForeignKey when used together with prefetch_related().
The following is sufficient to reproduce the bug:

models:

from django.db import models
from simple_history.models import HistoricalRecords, HistoricForeignKey

class Poll(models.Model):
    question = models.CharField(max_length=200)

    history = HistoricalRecords()

class Choice(models.Model):
    poll = HistoricForeignKey(Poll, on_delete=models.CASCADE)
    choice = models.CharField(max_length=200)
    votes = models.IntegerField()

    history = HistoricalRecords()

code:

from poll.models import Poll, Choice

why_poll = Poll.objects.create(question="why?")
how_poll = Poll.objects.create(question="how?")

Choice.objects.create(poll=why_poll, votes=0)
Choice.objects.create(poll=how_poll, votes=0)

for poll in Poll.objects.prefetch_related("choice_set").all():
    print(poll.choice_set.all())

# expected result:
# <QuerySet [<Choice: Choice object (1)>]>
# <QuerySet [<Choice: Choice object (2)>]>

# actual result:
# <QuerySet [<Choice: Choice object (1)>]>
# <QuerySet []>

Related Issue
#1152
Motivation and Context
Property related_manager_cls is defined in HistoricReverseManyToOneDescriptor. This property returns a function call of create_reverse_many_to_one_manager function and passes it HistoricRelationModelManager as an argument. However, create_reverse_many_to_one_manager defines RelatedManager, which subclasses the manager passed as an argument and returns this RelatedManager class.
When prefetch_related is used, get_prefetch_queryset method of RelatedManager is called.
The problem lies in the fact that it bypasses RelatedManager.get_queryset method which does filtering to instance (_apply_rel_filters) by calling super().get_queryset(). But due to inheritance, it gets evaluated to HistoricRelationModelManager.get_queryset which does the same filtering as well.
This SQL is generated then (notice the "poll_choice"."poll_id" = 1 condition):
SELECT "poll_poll"."id", "poll_poll"."question" FROM "poll_poll"
SELECT "poll_choice"."id", "poll_choice"."poll_id", "poll_choice"."choice", "poll_choice"."votes" FROM "poll_choice" WHERE ("poll_choice"."poll_id" = 1 AND "poll_choice"."poll_id" IN (1, 2))

Removing _apply_rel_filters call from HistoricRelationModelManager.get_queryset solves this problem.
On the other hand, since create_reverse_many_to_one_manager returns RelatedManager, rather than HistoricRelationModelManager, the only way to access HistoricRelationModelManager.get_queryset is by calling super().get_queryset() from RelatedManager. This call can be found:

in RelatedManager.get_prefetch_queryset where it is undesired,
in RelatedManager.get_queryset where _apply_rel_filters is called right after super().get_queryset().

Therefore, I believe it is safe to remove it.
How Has This Been Tested?
Added new tests.
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have run the pre-commit run command to format and lint.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] I have added my name and/or github handle to AUTHORS.rst
[x] I have added my change to CHANGES.rst
[x] All new and existing tests passed.

Plans to review/merge this?
(I'm in the process of integrating this package for the first time and I spent a few hours chasing around a bug until I realized it was caused by this issue.)
cc: @ddabble ?

any progress?

Any reason why this is not getting merged? We are also having the same issue

I'm happy to help. If there is anything I can do, please let me know.


Don't start if user has no home directory

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

If the user doesn't have a defined home dir (env var HOME,
USERPROFILE or HOMEPATH) and the userDir is not passed on the
command line then we shouldn't start as we don't know where to copy the
default settings.js file to or where to store flows
fixes #3539
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.03%) to 68.644% when pulling 889f0e15694a4cb86860305ed309aed71b685764 on hardillb:no-home-dir into 3a26c5cd651224f5c0a0366d184db050d7dc8ebd on node-red:master.

Should the Linux installer also flag this ?

It is possible with storage plugins to not actually need a userDir (if you supply a path to a settings.js) but we should still fail none are provided and we try and copy the default settings file to the default userDir location. So I've removed the test to see if a userDir is set
@dceejay  I don't think the install needs to check at this time as the install could still be valid.


Highlight on last selected item from main menu persists

There's a TODO for this, but here's a bug to go with it :)
To reproduce:

Select Menu -> Open
Select Cancel
Open Menu again

The Open item has a dark selection highlight
Expected: no dark highlight, and [enhancement]: a light highlight only while hovering over a menu item

Fixed in 3142e70e4e07a3a881ca2816864c65151cf30791


Unautharized error in jobman images

jobman images and jobman image-details -i [image-name] return "Unable to load repositories from [harbor -link] [ERROR]: Unauthorized"
This error did not occur the last time I used it on 26/05/2023.

@sophiasw Can you please re-deploy the desktop (delete the one that you have right now and create a new one through kube apps) and test again?

Yes, it works again!

@sophiasw all right, thanks for trying it out :)


Spec reset state and refactorings

What was the end-user problem that led to this PR?
The problem was that while working on #6713, I noticed several issues like order dependent failures, situations hard to debug, or specs doing too much and taking longer than they should.
What was your diagnosis of the problem?
My diagnosis was that:

Sometimes specs leak settings and env variable modifications.
When a hang happens inside a subprocess, it's hard to debug because logging is not printed out anywhere.
Some specs create unnecessary gemfiles and run bundle install multiple times unnecessarily.

What is your fix for the problem, implemented in this PR?
My fix for state leaks is to reset state after each spec, for the hangs is to reorder some lines in the sys_exec helper (https://github.com/bundler/bundler/commit/b305a5b2524a6457b05a9d39e9526f75c98a0752), and for the unnecessary operations, to refactor the specs to avoid them.
Why did you choose this fix out of the possible options?
I chose this fix because it seems like the best way to alleviate the issues found.

Now I'm not sure any more but I'm sure that the changes in #6713 definitely surfaced state leakage between specs. I should have probably tracked which changes fixed which problem, but unless there's something in the commit messages, I didn't. Anyways, the kind of leakage I saw was:

Specs failing due to order.
Specs leaving a .bundle folder in the root of the repo.
Current working directory change not happening at the right time. I was using around hooks, and the directory would change in the middle of the spec for some reason, I finally tracked that down to https://github.com/rspec/rspec-core/issues/2544 and I think I fixed that by not using around hooks.

I figured I could open a PR since in my opinion these changes in general make the specs more robust and improve readability, no matter what external hooks there are in place to globally reset the state.
Anyways, what I'm going to do is remove these changes from #6713, and see the exact issues that surface. And then come back here.

Ok, so I did what I said and... no issues. So it seems that all the problems I found during the development of #6713 where specific to some intermediate state but are not present in the final version...
I removed the env variable and current workding directory resets since, as you pointed out, are already reset after each spec :+1:.
Let me know your thoughts about the other commits!
Thanks @segiddins!

Sorry for the back and forth. This PR in its current state does fix an issue when running specs in #6713. If these changes are not applied, specs leave around a .bundle/config with the following content:
---
BUNDLE_NO_INSTALL: "true"
BUNDLE_MIRROR__HTTPS://RUBYGEMS__ORG/<EMAIL_ADDRESS>
I'm guessing the state leakage has been always there but didn't really matter before, since config was generated in the folder of the Gemfile in the temporary app (tmp/bundled_app or something like that). In any case, the changes here should fix it.

@segiddins Shall I move forward with this?

lgtm!


Readaseggdf

Following changes to the SkyTEM1D.jl code within the HiQGA package, we did a trial test for running Occam inversion on one AEM line. The process involves three steps:

01_read_data_aseggdf.jl
02_set_options.jl
04_plot.jl
The change in 01_read_data_aseggdf.jl includes introducing *.dfn and electronics_halt.jl file then setting up all the required column names that are going to be extracted from the *.dfn file.
The function called read_survey_files is the function that contains all the changes in recent development for directly reading the *.dfn files and populating the column numbers associated with each column name.

Best to remove files not necessary before pull request (PBS output files etc.) and I also made sure that it creates the .hdr file if it doesn't exist by running dfn2hdr internally.


Migrate buildSrc to composite build

Ref https://github.com/detekt/detekt/pull/4090
https://docs.gradle.org/7.5.1/userguide/composite_builds.html

@melix @paulk-asert I'm not an expert on Gradle, could you review the PR?

It does mostly look good (apart from an import or two which popped above the license header which are certainly fixable later). I just wanted to check it doesn't cause issues for the release process and we should check there are no adverse impacts when using IDEA and Eclipse. It will probably be a couple of weeks before I get to do such checks - the PR is certainly much appreciated and not forgotten.

Just revert 969d8b24ffaa9e1ca2fc226979a7385f1057e70a now, maybe we should do it in a follow up.

Merged. Thanks. I spotted a few things I was going to try to fix but looks like you found one already - I'll await for the CI checks and merge that too.
If you have some time, it would be super useful to get "rat" and "dependencyUpdates" to work on the build-logic directory!

Thanks, will take a look.

Also, sync'ing in IntelliJ currently gives me:

I presume we should just point to:
https://repository.apache.org/content/repositories/snapshots/

Yeah, should be picked from mavenLocal if you already published to local.

Could you add mavenLocal back to dependencyResolutionManagement and try again on you device?

It is easy to add that back in but in the interests of repeatable setup for all committers, I think pointing to the snapshot site would be better.

Make sense.

Let's not worry about the sync issue for now, it works fine for me on Linux, just Windows has the problem and we can track that down as a separate activity.


Fix flaky admin users system spec

Doesn't resolve any issue. Relate to flaky specs issue (#4557).
Description
Example build failure: https://github.com/rubyforgood/human-essentials/actions/runs/12431427850/job/34708824591
Example output:
Failures:

  1) Admin Users Management While signed in as an Administrative User (super admin) adds a role
     Failure/Error: expect(page.find('.alert')).to have_content('Role added')
       expected to find text "Role added" in "Couldn't find Partner without an ID"

     [Screenshot Image]: /home/runner/work/human-essentials/human-essentials/tmp/capybara/failures_r_spec_example_groups_admin_users_management_while_signed_in_as_an_administrative_user_super_admin_adds_a_role_214.png

     # ./spec/system/admin/users_system_spec.rb:56:in `block (3 levels) in <top (required)>'

Theory behind flakiness, this line in the test:
find('.select2-search__field', wait: 5).set("Partner ABC")

is filling in the select2 input field as if a human would (letter by letter). Every time you input a letter, another request is sent to filter those resources (which could be done locally instead of over a request but that's another topic).
This ends up sending a bunch of requests as seen in the test logs:
Started GET "/admin/users/resource_ids?resource_type=partner&_type=query" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "_type"=>"query"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=P&_type=query&q=P" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"P", "_type"=>"query", "q"=>"P"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Pa&_type=query&q=Pa" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Pa", "_type"=>"query", "q"=>"Pa"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Par&_type=query&q=Par" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Par", "_type"=>"query", "q"=>"Par"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Part&_type=query&q=Part" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Part", "_type"=>"query", "q"=>"Part"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Partn&_type=query&q=Partn" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Partn", "_type"=>"query", "q"=>"Partn"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Partne&_type=query&q=Partne" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Partne", "_type"=>"query", "q"=>"Partne"}
Started GET "/admin/users/resource_ids?resource_type=partner&term=Partner%20ABC&_type=query&q=Partner%20ABC" for <IP_ADDRESS> at 2024-12-20 05:36:09 -0800
Processing by Admin::UsersController#resource_ids as JSON
  Parameters: {"resource_type"=>"partner", "term"=>"Partner ABC", "_type"=>"query", "q"=>"Partner ABC"}

I think these requests create a race condition.
So instead of inputting the text, we just select the option. And it seems to fix the flakiness.
Type of change

Internal

How Has This Been Tested?
I ran this test locally 20 times before and after the changes. Before it failed 4 times, after it failed 0 times.

Thanks!


Command: insert_snippet

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1197673-command-insert_snippet?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

Migrated to limetext/lime-backend#53.


Fix gauge animation

Purpose

Fix gauge animation to rotate every 1 percent change

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

I scrolled one time using the arrow keys and this happened.

@lucaasrojas fixed!


Hard to install the program probably

Do you thing 4 ways you are using for installing this command line tools are hard to follow, undocumented?

Hey @huy-le . What exactly do you find hard to follow and what issues do you have installing Sourcery?

I eventually got Sourcery installed properly, but the instructions were pretty unhelpful - the README notes that, for Cocoapods installation, you "just need to add" the following as a run script phase:
$PODS_ROOT/Sourcery/bin/sourcery {source} {templates} {output}

However, my project wouldn't compile until I added this:
"${PODS_ROOT}/Sourcery/bin/sourcery" --sources "${SRCROOT}/SourceryTests" --templates "${SRCROOT}/Templates" --output "${SRCROOT}/CodeGenerated"

Even the example project needed the script to be changed before it would compile. I get that {source} {templates} {output} is pseudocode, but it's totally unclear that needed arguments are omitted, or that the file paths need to be structured in a particular way. The README could be much more clear on this front.
(btw, Sourcery is otherwise an amazing tool, once it's set up property - thanks for your work!!!)

Thanks for your feedback @worthbak! Indeed those instructions should be more clear and they are in fact out of date with the latest versions of the tool. We will fix that.

Hi @huy-le @worthbak check the updated documentation in master and let us know if it becomes clearer 😄

@Antondomashnev looks better! My only suggestion would be to provide a full example, as --sources <sources path> might seem a bit ambiguous to new users (especially because Sourcery makes heavy use of the `<<>>`` syntax in its regular usage). Or, perhaps just link to the relevant line in your example project's scheme - that was useful for me when getting it up and running 👍 thanks!!


fix: Mock guppy decorator during sphinx builds

Fixes #583
The problem was that sphinx autodoc got confused by @guppy decorated functions. Now, we mock the decorator when we detect that sphinx is running.

Codecov Report
Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Project coverage is 91.40%. Comparing base (45a460f) to head (f1841bd).

Files with missing lines
Patch %
Lines

guppylang/decorator.py
48.48%
17 Missing :warning:

guppylang/module.py
70.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   91.65%   91.40%   -0.26%
==========================================
  Files          60       60
  Lines        6448     6489      +41
==========================================
+ Hits         5910     5931      +21
- Misses        538      558      +20

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Move all CUDA Functions to Alpaka

Timing:

Note: Still need to move a few CUDA_CONST_VAR's over eventually.

Is this indeed ready to merge? I see a note in the description about moving more cuda stuff. Is this something to be dealt with in this PR, a leftover or mention for a future PR? I haven't checked the whole PR thoroughly but I see some inconsistencies in the changes, examples of which I will leave in separate comments below.
A more general comment: I can see the alpaka header included in a whole bunch of files, while the same files have includes that again include the alpaka header. Can we perhaps simplify on this point?
Finally, do we want to merge this before we merge #212, which will be the basis for us moving to alpaka 0.7, using a branch I have already developed? Apart from the fact that you were worried about conflicts, I am wondering if moving to the new version affects how you have implemented everything in this PR.

Is this indeed ready to merge? I see a note in the description about moving more cuda stuff. Is this something to be dealt with in this PR, a leftover or mention for a future PR? I haven't checked the whole PR thoroughly but I see some inconsistencies in the changes, examples of which I will leave in separate comments below.

Yes, those will be dealt with in a subsequent PR. Those are constants defined with the device prefix, so they don't fall under functions that should be moved in this PR. I made the note since there are only a few of them, so we don't forget about it.

A more general comment: I can see the alpaka header included in a whole bunch of files, while the same files have includes that again include the alpaka header. Can we perhaps simplify on this point?

This is a good point, but I'm not sure what best practice is here. If a file used Alpaka functions, I figured it was best to explicitly include alpaka in that file (even if it included a different file from SDL that also had the alpaka include). If you have a suggestion for a better approach though, I can change that in another commit.

Finally, do we want to merge this before we merge #212, which will be the basis for us moving to alpaka 0.7, using a branch I have already developed? Apart from the fact that you were worried about conflicts, I am wondering if moving to the new version affects how you have implemented everything in this PR.

The prefixes haven't changed from 0.5 to 0.7, so everything in this PR should be the same (I think).

Timing -

I will update this comment with validation plots soon.


unmarshal to workflow struct failed,if outputs.parameters.value is a number

Summary
What happened/what you expected to happen?
The conversion of Workflow YAML to Argo Workflow Struct failed，error is：
json: cannot unmarshal number into Go struct field Parameter.status.nodes.outputs.parameters.value of type string

Below is the Workflow I specified for the output，the outputs.parameters.value is displayed as a number in YAML
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  creationTimestamp: "2020-09-29T03:54:31Z"
  generateName: test-client-
  generation: 5
  labels:
    workflows.argoproj.io/completed: "true"
    workflows.argoproj.io/phase: Succeeded
  name: test-client-pdzbm
  namespace: default
  resourceVersion: "72569130"
  selfLink: /apis/argoproj.io/v1alpha1/namespaces/default/workflows/test-client-pdzbm
  uid: ef76c688-71ed-4683-a43c-35e6706784f5
spec:
    ......
status:
  conditions:
  - status: "True"
    type: Completed
  finishedAt: "2020-09-29T03:55:12Z"
  nodes:
    test-client-pdzbm-3099866031:
      boundaryID: test-client-pdzbm
      displayName: create-appstack
      finishedAt: "2020-09-29T03:55:10Z"
      hostNodeName: bjrz-rs2569.lf
      id: test-client-pdzbm-3099866031
      inputs:
        parameters:
        - name: body
          value: '{"isCreateService":false}'
      name: test-client-pdzbm.create-appstack
      outputs:
        exitCode: "0"
        parameters:
        - globalName: service-A-Id
          name: serviceId
          value: 1017125                                 // output is a number
          valueFrom:
            path: /result/serviceId
      phase: Succeeded
      resourcesDuration:
        cpu: 70
        memory: 70
      startedAt: "2020-09-29T03:54:31Z"
      templateName: create-service-A
      templateScope: local/test-client-pdzbm
      type: Pod
  outputs:
    parameters:
    - name: service-A-Id
      value: 1017125                      // output is a number
  phase: Succeeded
  resourcesDuration:
    cpu: 70
    memory: 70
  startedAt: "2020-09-29T03:54:31Z"

but in workflow struct，output type is *string.
// Parameter indicate a passed string parameter to a service template with an optional default value
type Parameter struct {
    ......

    // Value is the literal value to use for the parameter.
    // If specified in the context of an input parameter, the value takes precedence over any passed values
    Value *string `json:"value,omitempty" protobuf:"bytes,3,opt,name=value"`

    ......
}

The failure because wait container to save the output value without escaping it.
Diagnostics
What version of Argo Workflows are you running?
# argo version
argo: v2.10.1
  BuildDate: 2020-09-02T22:53:49Z
  GitCommit: 854444e47ac00d146cb83d174049bfbb2066bfb2
  GitTreeState: clean
  GitTag: v2.10.1
  GoVersion: go1.13.4
  Compiler: gc
  Platform: linux/amd64

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Can you add a sample workflow to reproduce this issue please? I would also try upgrading to 2.11.1 and seeing if that fixes the issue

Parameters must be string - maybe quote them?

@simster7 I'm seeing too many parameters must be a string. Maybe we should change them to item? Thoughts?

Is there a chance this workflow that there is a mismatch between the controller and CLI versions?

This is impacting too many people so I will take action to fix it.

Relates to #3960

No longer planning to fix this.

Since this is the first thing that comes up when googling the error I add my solution.
My script template looked like this:
  - name: task-template
    inputs:
      parameters:
        name: text
    script:
      image: python:3.8
      command: [python]
      source: |
        print("{{inputs.parameters.text}}")

And should have been:
  - name: task-template
    inputs:
      parameters:
        - name: text
    script:
      image: python:3.8
      command: [python]
      source: |
        print("{{inputs.parameters.text}}")

The parameters name key was not a list.   name: text vs   - name: text

No longer planning to fix this.

@alexec For  a particular node, we need to supply/set an outputParameter that is not a String (but rather a number or an object consisting of multiple fields). Is this currently still not possible?
I'm getting this error message when supplying an object for example to the outputParameters field in the body of the /set endpoint:
"unable to parse output parameter set request: json: cannot unmarshal object into Go value of type string"
and this one when attempting to provide a number:
"unable to parse output parameter set request: json: cannot unmarshal number into Go value of type string"
Is there no way of defining the type of the output parameter? Kindly, advice on what's the best approach to tackle this.

Try quoting the number?

Try quoting the number?

@alexec  Quoting the number would work of course but it's a workaround that I was trying to avoid having to apply since we're calling this programmatically after serializing a POJO object to JSON.
Also, there are more complex cases when the output parameter is a JSON object (and not just a string). That JSON object could also have encapsulated objects which adds more to the complexity. Are there no plans to support such use cases? Only String OutputParameters will be supported then? Any other ideas?

@alexec I also noticed that the issue boils down to the fact that escaped double quotes are not allowed within the outputParameters String.
Currently (v 3.3.0), providing outputParameters like this:
"outputParameters": "{"result": "{"foo": "bar", "foo1": "bar1"}"}"
Results in an error:
{
"code": 2,
"message": "unable to parse output parameter set request: invalid character 'f' after object key:value pair"
}
Because the escaped double quotes inside the output parameter's ("result") value get treated just like the ones wrapping the whole value.
Is there any way that I am missing to supply/escape double quotes within the outputParameters String?


feat(AlgebraicTopology/SimplicialSet): paths and the strict segal condition

A path in a simplicial set X of length n is a directed path comprised of n 1-simplices.
An n-simplex has a maximal path, the spine of the simplex, which is a path of length n. A simplicial set X satisfies the StrictSegal condition if for all n, the map X.spine n : X _[n] → X.Path n is a bijection.
Examples of StrictSegal simplicial sets are given by nerves of categories. Future work will show these are the only examples: that a StrictSegal simplicial set is isomorphic to the nerve of its homotopy category.
Co-Authored-By: Mario Carneiro and Joël Riou

This version contains the 2-coskeletality proof at the back of the StrictSegal file. I'm happy to move that to
(a) a separate file, called SimplicialSet/2Coskeletal.lean?
(b) a separate file in a separate PR
Just let me know.
-->

@joelriou here is one of the breakout PRs you requested. I wasn't sure whether you wanted the proof of 2-coskeletality to live here or not. I'm happy to move it or cut it.
If we keep it here, then this is really the vast majority of the content of #16782, so most of the work of that PR is now here. On the other hand, this showcases which results about strict segal simplicial sets are used (relatively little).

@mo271 thanks for these suggestions. May I ask how you found the simpler proofs? As you can see, this was much more painful for me...

@mo271 thanks for these suggestions. May I ask how you found the simpler proofs? As you can see, this was much more painful for me...

Really nothing special, I didn't use some special tool, just manual shuffling them around a bit.
One anti-pattern that was present here is the following:
have : long_statement := by exact short_proof_term
rw [this]

which can simply be replaced with
rw [short proof term]

Another one is combining simps in one lines, so instead of
simp only [foo]
simp only [bar]
simp only [baz]

just write
simp only [foo, bar, baz]

when it works.
In general this pattern with lots of  have can often be streamlined using convert, apply or refine. However, I think one should keep the proof readable and don't overgolf them.
One thing that is encouraged is to prefer simple tactics instead of more involved ones when possible, this is why I suggested to use rfl instead aesop in one place. Similarly, when rw works, I would prefer it over simp only or simp. But of course this presupposes knowing what tactics are more involved/expensive/powerful.
I'm sure all these types of remarks are written down somewhere, but I looked a bit for a link and didn't find it.

Thanks @mo271. I believe I understand all of this except the convert tactic, which is new to me. Googling took me to some discussion of conv => lhs/rhs which I have seen before. Were you referring to that or something else?
I have a vague memory that convert might be similar to show or suffices---two other tactics I haven't yet really figured out how to use...

I meant this:
https://leanprover-community.github.io/mathlib4_docs/Mathlib/Tactic/Convert.html#Mathlib.Tactic.convert

@jcommelin I thought this might interest you. Following a suggestion of @joelriou, @digama0 and I refactored our proof that nerves of categories are 2-coskeletal through the strict segal condition (that the map from the n-simplex to the path of vertices along its spine is a bijection). It occurs to me that your proof that nerves of categories are quasi-categories could be refactored similarly (and I just suggested this to someone in hopes they would adopt your wombat PR).

@joelriou here is one of the breakout PRs you requested. I wasn't sure whether you wanted the proof of 2-coskeletality to live here or not. I'm happy to move it or cut it.
If we keep it here, then this is really the vast majority of the content of #16782, so most of the work of that PR is now here. On the other hand, this showcases which results about strict segal simplicial sets are used (relatively little).

My suggestion was to focus on the most basic properties, so that the main result in the Coskeletal file would come later in a separate PR.

While you're here @joelriou do you have thoughts about @jcommelin's suggestion of making StrictSegal a typeclass with spineToSimplex as a structured equivalence? I was planning to implement this last, in case we want to undo.

I don't know what "Post PR summary comment / build" failure means.

While you're here @joelriou do you have thoughts about @jcommelin's suggestion of making StrictSegal a typeclass with spineToSimplex as a structured equivalence? I was planning to implement this last, in case we want to undo.

It seems a good idea!

While you're here @joelriou do you have thoughts about @jcommelin's suggestion of making StrictSegal a typeclass with spineToSimplex as a structured equivalence? I was planning to implement this last, in case we want to undo.

It seems a good idea!

I like the change that resulted to Nerve.strictSegal (though it's still non-computable).
PS: I just reverted the apply Hom.ext_one_left <;> simp <;> omega which I think caused the build failure. If the CI agrees, then this version should be ready to review. (Apologies for removing the flag too early: the build failure didn't happen -- for some reason I don't understand -- until I bumped mathlib.)

The recent mathlib bump caused a weird build error which broke the proofs of mkOfSucc_subinterval_eq and diag_subinterval_eq. I rewrote the proofs to something which compiles, but something weird seems to be going on.
Specifically the goal
↑(match 0 with
      | 0 => i✝.castSucc
      | 1 => i✝.succ) +
    j =
  ↑(match 0 with
    | 0 => ⟨j + ↑i✝, ⋯⟩
    | 1 => ⟨j + ↑i✝ + 1, ⋯⟩)

does not simplify. Though I am able to rw [add_comm]; rfl.


قلب  output is left-to-right arabic script

Hi, I'd never heard of قلب before looking around riju; thanks for adding it!
There is a problem with the output, however; the arabic letters go from left to right and are not connected, as arabic usually is:

The first word, مرحبا, is displayed essentially "اب ح رم"; it should look how it looks on the source pane side (and be the word the furthest to the right, since it's the start of the right-to-left line).

Yeah, that's fair, it would be a bit tricky to fix this since we don't fully control the terminal output (that's from xterm.js), but worth a try.


The content server has rejected the request with: BadRequest

I followed the instructions for setting up a static web app (react). Everything worked except for the deployment actions part of the Github Actions flow. That part fails on the "Build and Deploy" step due to the content server rejecting the request because the content is too large.
I followed the instructions closely. The only deviation was that I did not clone from the template Github repo. In my case, I already had a project that I've made real progress on and I did not want to start from a skeleton template. From what I can tell, your template is basically the create-react-app template which is what I used already. I pointed my static web app deployment to my frontend folder  which should be functionally equivalent to using your template. Anyway, I can see that the build step in Github Actions builds my app correctly in the logs. It's the upload step that is failing.
Zip archive with Github actions logs

---End of Oryx build logs---
Function Runtime Information. OS: Linux, Functions Runtime: v3, Node version: 12.X
Finished building function app with Oryx
Zipping App Artifacts
Done Zipping App Artifacts
Zipping Api Artifacts
Done Zipping Api Artifacts
The content server has rejected the request with: BadRequest
Reason: The size of the function content was too large. The limit for this static site is 30000000 bytes.

For further information, please visit the Azure Static Web Apps documentation at https://docs.microsoft.com/en-us/azure/static-web-apps/
If you believe this behavior is unexpected, please raise a Github issue at https://github.com/azure/static-web-apps/issues/
Exiting

Hi @luisnaranjo733 so this error implies that the size of your Azure Function is too large. Do you have an Azure Function in your project?

I figured it out.
The problem was that my .vscode/settings.json was misconfigured and caused the static web apps VS code extension to fail.
I had this field set to a non empty string, even though I did not have an Azure Function in my project yet.
"staticWebApps.apiSubpath"
When I set that field to an empty string, deleted my static web app, and then re-deployed via the extension, everything worked great.
So the root cause here was user error, but still, it seems weird that this misconfiguration would cause the deployment to fail. Maybe this is a symptom of another issue? I

I saw same error message when deploying my static web app with function app codes.

My function app code includes chromium binary via puppeteer or playwright such as following repo.
https://github.com/anthonychu/functions-headless-chromium
When this binary is included, the size of deployment package might be over 100mb, which is known quota.
https://docs.microsoft.com/en-us/azure/static-web-apps/quotas

But the error message says The limit for this static site is 30000000 bytes..
What is the 30000000 bytes limit?

Hey @luisnaranjo733 thats pretty interesting. From the log you posted above it looks like we detected and ran npm install on an 'api' folder. What is the api location in your GitHub Action workflow configured to? Does that directory exist in your project?

Hey @horihiro, so currently we have 2 size limits: one for you app (that is the well documented 100 MB limit), the other limit is for the total size of your function. It seems you are hitting the function size limit (30 MB).
We need to update our docs to include this limit. cc @craigshoemaker
In general we are looking at ways to make these limits less restrictive.

Thanks @miwebst
Do we have a plan to extend the limitation about both of package sizes until GA?

@miwebst I think the function app size limit is now 100MB. Can you confirm? Perhaps we can add this to docs. @craigshoemaker

Closing due to inactivity. Feel free to reopen if required!


dac loss would be nan/inf after some train steps

audio sr：16000
other params not change

I have not tested the model at a 16 kHz sample rate. The current configuration is optimized for 24 kHz. To support 16 kHz, you may need to adjust the model's hyperparameters accordingly, including the downsampling rate, discriminator settings, and other relevant factors.

same error+1, change to 16khz and adjust downsampling rate to [8,5,4,4], and get nan after 20k train steps in mixed language dataset, but can success in train libritts

+1

Could you please let me know which dataset you are using? I may be able to run an experiment to investigate the issue. Additionally, have you tried using the same settings with the WavTokenizer repository?

same error +1，and I encountered the same error while using the quantization method in my own model framework.

same error +1，and I encountered the same error while using the quantization method in my own model framework.

note：trained in mandarin dataset

@kunsung Hi, could you please let me know which dataset you are using? I need more information to reproduce the issue. In my opinion, the discriminator module might be responsible for the NaN problem.

I figured gradient clipping helps.

@erogol Glad to see the success! The gradient clipping seems to indicate instability in the discriminator module to me.

with gradient clipping, it took longer but val DAC disc losses and grad_norm of the generator layers started to go up.  Still training but I think it's not gonna work

Hi, this is the tensorboard log of my experiment with a codebook size of 65k for your reference.

@kunsung Hi, could you please let me know which dataset you are using? I need more information to reproduce the issue. In my opinion, the discriminator module might be responsible for the NaN problem.

I used a private dataset, which is a mixture of Chinese and English data and tens of thousands of hours in size. I think the problem is not with the discriminator, because the gradient explosion also occurs when I only use the generator with reconstruction loss. I have tried using learning rates of different sizes, but none of them worked. At the same time, I tried two steps training, first without quantization, reconstructing the continuous vector, and then adding quantization training, but it also did not solve the problem. I think the effectiveness of the method may still need to be verified on large-scale data.

@kunsung Hi, could you please let me know which dataset you are using? I need more information to reproduce the issue. In my opinion, the discriminator module might be responsible for the NaN problem.

I used a private dataset, which is a mixture of Chinese and English data and tens of thousands of hours in size. I think the problem is not with the discriminator, because the gradient explosion also occurs when I only use the generator with reconstruction loss. I have tried using learning rates of different sizes, but none of them worked. At the same time, I tried two steps training, first without quantization, reconstructing the continuous vector, and then adding quantization training, but it also did not solve the problem. I think the effectiveness of the method may still need to be verified on large-scale data.

I succeeded all experiments with various codebook size on imagenet (large enough I think) and libritts (I provide the log above). I am open and glad to help figure out the issues, but the private dataset you claimed and the model framework you implemented cannot be reproduced by anyone. If you don't provide us with a reproducible environment, there is nothing we can do to assist you in this setting.
I recommend starting your tests using our code and dataset without making any modifications and check the results.

Thanks for sharing the loss curves. I'd say it is similar to my curves but it is still interesting to see the mod collapse of the discriminators even in your logs. Do you know why it happens and doesn't interfere with the generator?

it maybe about the order of updates though. In general, you need to update the discriminator first but in your code it is reversed.

This issue also appears in Open-MAGVIT2. When I train on my own dataset for about 20 epochs or 400,000 steps, the model crashes and all the weights become NaN.

I meet the same issue, how to make the commit loss stable?

Here is my training log of commit_loss. What's the value of commit_weight in your experiment?

1000.0

Hi, all. When I implemented the streaming version of SimVQ on audio data, I encountered the Nan issue as well, which seems to occur randomly. I’m still investigating the cause.
I remove the attention layer in the wavtokenizer architecture, since it does not make sense to me for the "semantic" purpose. So far, the NaN issue has not reappeared. The codebook utilization converges a little bit slower, but it can still achieve 100%.
I’ll share more details about the solution as I make further progress.


didn't work! The atom version is 1.19.7,terminal plus version is 0.14.5

Operate system is win10_64 .The atom is latest version,installed node-gyp,changed shell override too.
but when open the terminal ,it couldn't intput anything!

Same problem here

G'day guys,
Terminal plus isn't being maintained any more. There are two supported forks that I'm aware of: Termination (my fork) and platformio-atom-ide-terminal.


Style NdOverlays &co. (and their legends) by kdim instead of by Element

When doing e.g. an NdOverlay, the legend has an entry for each Element (see below). For 2 or more key dimensions, this quickly becomes a lot. It would be really nice if instead of listing every single Element, we could style the NdOverlay by setting different Cycle options along the different key dimensions, e.g. along kdim1 we vary line width, along kdim2 the color, along kdim3 the opacity, ... As far as styling the Element goes, this would mostly be a convenience, but it could make the associated legends much clearer.
E.g. this is what it currently looks like:

What the legend could instead look like is that there's a thick line (no colour) for "measured", a thin one for "representative", a blue patch for "overturning", an orange one for  "perennial" (no variation in thickness), and so on.
Or is this too complicated to generalize?
Also, unsure if this is related: #1161

It would be great if we could have a simple way to construct arbitrary legends as needed. E.g. for datashader, we constructed this legend by adding fake invisible points, just to be able to show the color code:

Being able to do that more explicitly but conveniently would be a great help.  I don't have any immediate API suggestions other than that it would take some ordered dictionary of some visible item and a text description.

The code snippet shared in #3026 for adding a legend manually to a GridMatrix may also be useful here.

This is now possible by using style mappers, e.g.:
df = pd.DataFrame({
    'Time': np.tile(np.arange(100), 9),
    'y': np.random.randn(900).cumsum(axis=0),
    'gridsize': np.repeat([0, 1, 2, 0, 1, 2, 0, 1, 2], 100),
    'turbulence': np.repeat([0, 0, 0, 1, 1, 1, 2, 2, 2], 100)})

df['label'] = ['Gridsize: %s, Turbulence: %s' % (r.gridsize, r.turbulence) for i, r in df.iterrows()]

curves = hv.Dataset(df, ['Time']).to(hv.Curve, 'Time', ['y', 'gridsize','turbulence'], 'label')
curves.overlay('label').opts(
    opts.Curve(color=dim('gridsize').categorize({0: 'red', 1: 'blue', 2: 'green'}),
               line_dash=dim('turbulence').categorize({0: 'solid', 1: 'dashed', 2: 'dotdash'})),
    opts.NdOverlay(width=900, legend_position='right'))

I'd like to add a cycle method on dim though so you don't have to provide an explicit mapping.

I'd like to add a cycle method on dim though so you don't have to provide an explicit mapping.

Sounds like a great idea.

Thanks @philippjfr, I learned about dim().categorize a bit later (and .cycle would be even better!). The problem of mapping this into a less bloated legend would remain though.

By now you can even use dim transforms on kdims of NdOverlays! https://nbviewer.jupyter.org/github/poplarShift/pyviz-recipes/blob/master/notebooks/styling_by_attribute.ipynb
Changing title to reflect that.


Use Unreleased Lightning Version to Fix Launch on Cloud

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
There is a bug when passing the 'info' argument to 'LightningApp()' which prevents the app from starting in the cloud. Switching to an unreleased version of the Lightning Framework to see if it resolves the issue.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
 This won't take long.
Traceback (most recent call last):
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/runners/multiprocess.py", line 37, in dispatch
    self.app._update_index_file()
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/core/app.py", line 181, in _update_index_file
    MultiProcessRuntime(self).dispatch()
  File "<string>", line 16, in __init__
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/runners/runtime.py", line 108, in __post_init__
    LightningFlow._attach_backend(self.app.root, self.backend)
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/core/flow.py", line 222, in _attach_backend
    backend._wrap_run_method(app, child_work)
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/runners/backends/backend.py", line 78, in _wrap_run_method
    if work.run.__name__ == "_dynamic_run_wrapper":
AttributeError: 'functools.partial' object has no attribute '__name__'. Did you mean: '__ne__'?

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/__main__.py", line 39, in <module>
    cli.main()
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 430, in main
    run()
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/adapter/../../debugpy/launcher/../../debugpy/../debugpy/server/cli.py", line 284, in run_file
    runpy.run_path(target, run_name="__main__")
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 321, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 135, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/home/alec/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/lib/python/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_runpy.py", line 124, in _run_code
    exec(code, run_globals)
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/debug.py", line 6, in <module>
    MultiProcessRuntime(app).dispatch()
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/runners/multiprocess.py", line 111, in dispatch
    self.terminate()
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/runners/runtime.py", line 131, in terminate
    frontend.stop_server()
  File "/home/alec/work/Lightning-AI/LAI-Echo-App/venv/lib/python3.10/site-packages/lightning/app/frontend/web.py", line 57, in stop_server
    raise RuntimeError("Server is not running. Call `StaticWebFrontend.start_server()` first.")
RuntimeError: Server is not running. Call `StaticWebFrontend.start_server()` first.


Issue with k8s.io/docs/setup/

btertber

Hi @godunddome - this looks like you opened this issue accidentally. Since this isn't a docs issue, I'm going to close it - please re-open with relevant details if there is a documentation issue to address.


Set minimal coverage to 0

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fb7f7c4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   99.06%
=========================================
  Files             ?        5
  Lines             ?      107
  Branches          ?        0
=========================================
  Hits              ?      106
  Misses            ?        1
  Partials          ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Improve memtrack

What problem does this PR solve?
Issue Number: close #5609
Problem Summary:
What is changed and how it works?
Solve the following problems which may cause memory quota not working, in order to reduce OOM cases.
1.Track some kind of object was not tracked before, such as object generated by Protobuf.
2.Fix a bug in memtracker, which causes memory quota not working.
3.Fix bugs in our MPPTask construct/destruct logic, which cause memtracker can‘t be propagated into MPPTunnel & ExchangeReceiver
4. Use a background thread to collect RSS metric periodicaly and check how much it exceed the user setting limit in mem tracker. And throttle when it's too large, to control those un-trackable memory such as: cache used by Allocator 、stack allocated by threads.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/rebuild

Can we add gtests for memory tracker on linux OS to check the basic behavior?

good idea

Can we add gtests for memory tracker on linux OS to check the basic behavior?

gtest added

/rebuild

/rebuild

/merge

/rebuild

/run-all-tests

/merge

/run-all-tests

/merge


how to add scroll event on modal?

https://github.com/fomantic/Fomantic-UI/issues/858#issuecomment-509420980


Issues with converting multiplied linebreaks

Hi!
It's seems like i can't convert double newline into markdown native format.
I need to wrap line like
Up/n/nDown.
Expecting

Up

Down

Got

Up
\n
Down

My code:
import markdown

line ="Up/n/nDown"
markdown.markdown(line, extensions=['markdown.extensions.nl2br'])

Replacing \n with newline with two leading spaces returns the same result.
I will appreciate any assistance.
Thank you!

This is exactly how it should work.  Blocks are separated by two new lines in Markdown:
I'm a
block

I'm a different
block

But what Markdown normally does when rendering in HTML is this:

I'm a block
\n
I'm a different block

What nl2br does is turn single newlines within a block to
 (there may be \n in the actual HTML output, but I am just approximating):

I'm a
block
\n
I'm a different
block

So in your example, you have two distinct, separate blocks, so no
 tags where injected, and you just get:

Up
\n
Down

I agree with @facelessuser.
If you want to include multiple blank lines within a single block (paragraph), then you would need to use raw HTML to insert the
 tags yourself. Perhaps like this: Up

Down.
As there is no bug here, I'm closing this.


Istio with go

This PR adds Istio support to the go pack. It is a safe addition because all the changes are within a conditional that uses istio.enabled value that is by default set to false. I tested it quite a few times (manually) and I could not find any issue. If the PR is approved, I plan to create new ones soon. They would first add the same to other packs. After that, I'll add changes that will allow canary and blue-green deployments as well as other Istio-specific features.

@garethjevans
Can you review and approve this PR?

@rawlingsj Can you review/approve this PR?

Is there any special reason for this not to be merged. It's a safe addition that should not affect anyone.

This would be an awesome feature addition to have.

Will come with a better PR


websocket connect failed after modify webSocketURL

Bug report

What is the current behavior?
websocket connection failed.
If the current behavior is a bug, please provide the steps to reproduce.
Add config of webSocketURL will cause this problem, like this:

The connection can not establish:

And if I change the websocket path to "/ws", everything will be fine.

But for some reason, I cannot use "/ws" for the websocket path.
My webpack versions are:
    "webpack": "5.74.0",
    "webpack-bundle-analyzer": "4.5.0",
    "webpack-cli": "4.10.0",
    "webpack-dev-server": "4.11.1",
    "webpack-manifest-plugin": "^5.0.0",
    "webpack-rtl-plugin": "2.0.0"

What is the expected behavior?
Websocket connection can work correctly after I modify webSocketURL config.

Other relevant information:
webpack version:  5.74.0
Node.js version: 14.19.2
Operating System: macOS Monterey 12.6 with Apple M1
Additional tools:

Ok, I think I've found a solution, just add a "webSocketServer" config which is not on the webpack document.


Missing source for scriptexecute.img

The provided scriptexecute.img appears to be an XZ compressed initrd produced by buildroot, however the source to build this has not been provided.

Lives in a different repo
https://github.com/raspberrypi/scriptexecutor


Adding solc optimizer to the command set

This repo appears to have gone stale or hasn't had any releases in some time. @dmuhs Any updates as to when this could or the other open PRs could be reviewed?

Hi @dmuhs! Thanks for your response! Hopefully, someone @ConsenSys's GitHub org will take over the CLI tool's maintenance soon, and the tool will no longer be in this in-between state without active maintenance.


Create 0000-01-02-CrystallineButterfly.md

Added a description with helpful instructions, during a course on GitHub about collaboration and exchange of info, if you have more info, its all yours

fantastic


Bump Workbench Version to 2022.12

bump workbench version to 2022.12.0
switch workbench and r-session-complete to use and build from product-base-pro images
remove install-vs-code helpers (no longer present)
add README.md section highlighting how images inherit / relate to one another
bump to the new daily build line for workbench

Ultimately, we should do some testing with the newly built dev- images before we merge this, as there are a fair number of changes here.

Something weird is still broken for azure

Queued up to merge on Tuesday!

Did some rudimentary testing. More to commence, and we will fix forward any issues!


Display all emapis layers int the catalog

@AFoletti waht is the status of emapis layers are they all available in your branch of chsdi?

yep, each eMapis layer should be available in this branch:
https://github.com/geoadmin/mf-chsdi3/compare/kan_chsdi_emapis_entwaesserung

perfect @kandre can you add those int the catalog?


[Hydrogen docs]: Version 0.16.0 release

This PR:

Makes some minor tweaks to the docs associated with Hydrogen version 0.16.0

@jplhomer No worries at all! Just doing a little round of very minor tweaks! ❤


add-dist-cassandra-elasticsearch-profile and support GS

add-dist-cassandra-elasticsearch-profile
update elasticsearch version
support GS typeDef

@mohamed-a-abdelaziz any idea what are the steps required to run atlas with local cassandra and local elastic search? Don't seem to find anything in docs.

@mohamed-a-abdelaziz any idea what are the steps required to run atlas with local cassandra and local elastic search? Don't seem to find anything in docs.

just follow these steps
#download cassandra
wget https://mirrors.gethosted.online/apache/cassandra/3.11.7/apache-cassandra-3.11.7-bin.tar.gz
tar -xzf apache-cassandra-3.11.7-bin.tar.gz
#set start_rpc: true  on apache-cassandra/conf/cassandra.yml file
#run cassandra locally
<path-to-cassandra>/bin/cassandra -f &
#download elasticsearch
wget https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-7.8.1-linux-x86_64.tar.gz
tar -xzf elasticsearch-7.8.1-linux-x86_64.tar.gz
#run elassticsearch
<path-to-elasticsearch>/bin/elasticsearch &
#run kafka
wget https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka_2.12-2.5.0.tgz
tar -xzf kafka_2.12-2.5.0.tgz
<path-to-kafka>/bin/zookeeper-server-start.sh config/zookeeper.properties &
<path-to-kafka>/bin/kafka-server-start.sh config/server.properties &
#clone atlas from my fork if you didn't yet :)
#set atlas.kafka.zookeeper.connect=localhost:2181 and  atlas.kafka.bootstrap.servers=localhost:9092 on distro/src/conf/atlas-application.properties (or your own ports)
#build atlas
cd <atlas-path>
mvn clean -DskipTests package -Pdist,cassandra-elasticsearch
cd distro/target/apache-atlas-2.1.0-server/apache-atlas-2.1.0
#run atlas
./bin/atlas_start.py
#open your browser and type localhost:21000/
#user/pass : admin/admin

@mohamed-a-abdelaziz I've tried those earlier and again clean installed everything(cassandra, es) to follow your steps. But still I get 503-problem accessing /. because of service unavailable. I don't see anything in logs too apart from Apache atlas server started. Can you help me here please?

@mohamed-a-abdelaziz thanks. This worked for me. I checked out onto your branch and was able to build this. Any idea when this PR will be merged to master?


Quotation marks within a sentence

As discussed in the meeting on May 25th, there should be a method for adding quotation marks within a Sentence that will work for both SRS and HTML documents.
Note: I tried using " and this did indeed work for both .tex and HTML, so this might not be a real issue.

We will need a means for adding quotation marks. This is low priority for the time being though. The main problem is that TeX open quotation should be `` whereas HTML would use ".

Done.


index: add basic collecting/saving logic

Very basic experimental functionality for cloud versioning POC.

I don’t think I like the Meta changes to be honest.


fix(dropdown): use flex for split button check label to fix spacing

fixes https://github.com/patternfly/patternfly-next/issues/2223

PatternFly-Next preview: https://patternfly-next-pr-2224.surge.sh

:tada: This PR is included in version 2.31.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: