Internationalisation (i18n, multi-language support)

First of all I real like the library approach that makes it useable for multiple frameworks. The one option I real miss is some kind multi-language support. Have you thought about adding these feature?
I think the simples and sufficient fix would be to add option that turns messages into codes (like 'VALIDATEJS.ERROR.REQUIRED'). So people can handle translation on their own. What do you think about such improvement?
Ps. sorry for weird title but I want the topic to be easy to find for others.

i18n is definitely something that is lacking in this library.
What you describe is already possible actually.
All included validators support overwriting the default options.
So you could do this:
validate.validators.presence.options = {
  message: "VALIDATEJS.ERROR.REQUIRED"
};
validate.options = {fullMessages: false};
validate({}, {name: {presence: true}});
// => {"name": ["VALIDATEJS.ERROR.REQUIRED"]}

But if you have a concrete suggestion I'd be happy to consider it!

Thanks for this @ansman

@ansman Thanks for the answer and temporary fix.
I'll take a closer look at the source code and hopefully propose more specific solution along with a PR.

@jakubrohleder I would recommend that you describe your solution before implementing it in case it is in another direction than the library is heading.
This could potentially be added in a separate file that could be included after validate.js which would set the default messages when included validate-i18n.js for example, maybe even as a separate library with official support.

@ansman I think that library that modifies another library is too hackish and can cause potential problems in the future. In my opinion the best solution would be something that is built in, yet optional.
I'll describe my idea here before making a PR.

I fail to see the need for validate.js to do anything around this?
import i18n from 'mythical-i18n-library';
import en from 'i18n/en';
import jp from 'i18n/jp';

let {translate} = i18n({lang: 'en', locales: {en, jp});

let constraints = {
  username: {
    presence: true,
    message: translate('you must provide a username')
    }
  };

validate({}, constraints);

@airtonix Technically validate.js already supports this but some things could be nicer.
The whole idea of prefixing the message with the attribute name needs to be rethought if translations should feel like a first class citizen.
For example I've been playing around with the idea that instead of always prefixing that the message will have to contain a marker (such as %{attribute} for lowercase and %{Attribute} for upper case.). But this will still require the attribute to be translated before inserting.
It's not high priority but it's definitely something that needs to be looked at before 1.0

@ansman ,
The one issue when my i18n process is that username is never changed in @airtonix 's code.
Of course actually that is an ease. But when considering i18n it is an issue.
Sample outputs
in Swedish: Username krävs. However the placeholder seems as Användarnamn
in English: Username is required.
Have a good day...
ps: Forgive me please if my Swedish words are wrong. I've used Google Translate.

@ansman I still feel like translation is really not the scope of validate.js.
It is sufficiently designed to allow a project integrator to use other libraries dedicated to i18n.

@airtonix Exactly, validate.js shouldn't support i18n in itself but it should make it easy to implement.

@ansman @airtonix how one should do it? is there a proper hook points? I've looked at documentation and found validator.prettify, but seems like it also prettifies values. What libs do u recommend to use for i18n? Btw, idea with %{attribute} looks promising :).

@ansman That %{attribute} / %{Attribute} would be extremely helpful for getting started on translations. Sending %{attribute} can't be blank" to a translator is a lot more approachable than trying to send English fragments like can't be blank to them.

Any updates with this? I did the workaround proposed for @ansman in https://github.com/ansman/validate.js/issues/74#issuecomment-145609665, but for validators that involves variables as "is too short (minimum is 8 characters)" is too ugly to translate a general message

I think a new error format like validate.options = {format: "code"} where the message returned would be codes (ex: { message: 'VALIDATION.LENGTH_BETWEEN', value: [5, 30] }) instead of English messages could help.

import Validator from "validate.js";
import I18n from "react-native-i18n";
/**
 * need to add pronis if async is required
 * need to add format and parse method for date and date time
 */
export default class ValidatorJS {
  constructor(translateFn = I18n.t.bind(I18n)) {
    this.translate = translateFn;
    this.Validator = Validator;
    this.Validator.formatters.custom = this.overloadFormatFunc;
    this.Validator.convertErrorMessages = this.convertErrorMessages;
    this.overloadErrorMessages();
  }
  /** adapters */
  bindRequiredToPresence = (constraints) =>
    Object.entries(constraints).reduce(
      (acc, [key, { required, ...ObjVal }]) => {
        acc[key] = { presence: required, ...ObjVal };
        return acc;
      },
      {}
    );
  /** binds default messages */
  overloadErrorMessages = () => {
    this.Validator.validators.date.options = {
      message: "DATE_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.datetime.options = {
      message: "DATETIME_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.email.options = {
      message: "EMAIL_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.equality.options = {
      message: "EQUALITY_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.exclusion.options = {
      message: "EXCLUSION_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.format.options = {
      message: "FORMAT_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.inclusion.options = {
      message: "INCLUSION_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.length.options = {
      message: "LENGTH_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.numericality.options = {
      message: "NUMERICALITY_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.presence.options = {
      message: "PRESSENCE_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.url.options = {
      message: "URL_VALIDATOR_ERROR_MSG",
    };
    this.Validator.validators.type.messages = {
      array: "ARRAY_VALIDATOR_ERROR_MSG",
      boolean: "BOOLEAN_VALIDATOR_ERROR_MSG",
      date: "DATE_VALIDATOR_ERROR_MSG",
      integer: "INTEGER_VALIDATOR_ERROR_MSG",
      number: "NUMBER_VALIDATOR_ERROR_MSG",
      object: "OBJECT_VALIDATOR_ERROR_MSG",
      string: "STRING_VALIDATOR_ERROR_MSG",
    };
  };

  convertErrorMessages = (errors, options) => {
    options = options || {};
    var ret = [];
    errors.forEach((errorInfo) => {
      var error = this.Validator.result(
        errorInfo.error,
        errorInfo.value,
        errorInfo.attribute,
        errorInfo.options,
        errorInfo.attributes,
        errorInfo.globalOptions
      );

      if (!this.Validator.isString(error)) {
        ret.push(errorInfo);
        return;
      }

      if (error[0] === "^") {
        error = error.slice(1);
      } else if (options.fullMessages !== false) {
        error = error;
      }
      error = error.replace(/\\\^/g, "^");
      error = this.Validator.format(error, {
        value: this.Validator.stringifyValue(errorInfo.value, options),
      });
      ret.push(this.Validator.extend({}, errorInfo, { error: error }));
    });
    return ret;
  };
  /** uses translate with formatfunc */
  overloadFormatFunc = (errors) =>
    errors.reduce((acc, { validator, attribute, value, error }) => {
      acc[attribute] = this.translate(error, {
        validator,
        attribute,
        value,
        prettified: this.Validator.capitalize(
          this.Validator.prettify(attribute)
        ),
      });
      return acc;
    }, {});
  /** overrides */
  validate = (data, constraints, options = { format: "custom" }) => {
    // console.log("validatingData:", data);
    // console.log("validatingconstraints:", constraints);
    return this.Validator(
      data,
      this.bindRequiredToPresence(constraints),
      options
    );
    // console.log("validatedRes:", res);
    // return res;
  };
}
// usage
export default class ValidatorAdapter {
    constructor(formCtx,validator=ValidatorJS,translate){
        this.validator = new validator(translate);
        this.formCtx = formCtx;
    }
    validate = () => this.validator.validate({...this.formCtx.state.values},{...this.formCtx.elements});
}
FORM extends React.Component{
constructor(props) {
    super(props);
    this.state = {values: {}, options: {}, errors: {}, isVisible: false};
    this.validator = new ValidatorAdapter(this,props.validator, props.translate);
  }.......
_handleSubmitAndValidate = (key="_handleSubmit")=>(e)=>{
    let {values,errors} = this.state;
    let valid = this.validator.validate();
    if(!valid){
      /** this means no error at all */
      this.setState({errors:{}})
      this[key](e,values,errors);
    }else{
      errors = {...errors, ...valid}
      this.setState({errors})
    }
  }
.....
}


#6805: Replace ttnn.split_query_key_value_and_split_heads with correct sharded implementation

This also addresses issue #6712

Passing pipelines (except ttnn unit tests on wormhole): https://github.com/tenstorrent-metal/tt-metal/actions/runs/8653317689/job/23728475828


still sometimes the code on initial load does not re-execute

this happens w webapp not tauri which I believe seems to work pretty well now

I've not noticed this in a long time and just double-checked. I'm guessing got scooped up with the xstate migration.


Add patrol prepare command which installs debug artifacts and sets up port forwarding

The problem
Running native automators in debug mode is annoying.
For Android, we have to execute the debugcopy script in AutomatorServer/android which also builds both artifacts (not always needed).
Port forwarding has to be set up manually.
Additionally, patrol drive uninstalls both .apks, so the whole process has to be repeated across patrol drive invocations.
IGL, the whole process should be streamlined.
Benefits
This will:

save me a reasonable amount of time
make it much easier for future contributors to work on the native automators

No longer relevant since patrol drive has been removed in #915.


Twitch Button

I think that a Twitch button (similar to discord one) that would take you to a livestream tab where you can see all Supreme Commander streams that are live right now would significantly effect the growth of the viewer base for high level 1vs1 Custom/Ladder, Seton's, other team games as well as Official FAF tourneys.

Don't think we want this, certainly not in such a prominent place

we have it now? close?


Limited network life: future areas to consider

This is not a mainnet-proper problem as we won't be rebooting frequently, but:

Right now if we intentionally shut down the network, and a validator unstakes on Ethereum between resets, and then the network starts up, that isn't a problem because the validator set is fixed and unchanging and there are no own stake requirements
In the distant future when we don't reset the network ever again, this is fine as the proper mechanisms will be in place to change validator sets

However between those two points, there are some points that aren't well covered at the intersection of the Limited Network Life & Staking specs

If we do implement minOwnStake (see research paper) to require that a validator has its own stake, and that validator is expected at Genesis and has no stake, what happens?
If the network shuts down, and before the network starts up again one of the validators disappears from the internet, what is the process for starting up?
If the network shuts down and 50% of the validators decide to try to start up different networks from the same checkpoint, what problems does that present? Presumably they can't allow withdrawals from the asset pool (as they wouldn't have sufficient control of the multisig contract to sign a bundle), but that could prevent anyone from withdrawing from the pool? I guess the network would also not start up.

Note: These are mostly @peterbarrow's, I'm just filing the issue.

Solution in these extreme cases will probably have to be manual.
We also don't expect LNL to be used anymore now we have protocol upgrade spec https://github.com/vegaprotocol/specs/blob/master/protocol/0075-PLUP_protocol_upgrades.md


Start converting explorer to GRC.

Updated README for GRC.
Created GRC-specific settings file.
Updated icons and logos.
Updated various files to work with GRC.

Forcing merge.

Closes #3
Closes #4
Closes #2
Closes #1


Any example to add javascript to a store?

Hi @ohmybrew or any who know this can advise me on how to add your javascript to a store?
Thank you.

You mean a ScriptTag (https://help.shopify.com/api/reference/online_store/scripttag)?
Have a look at your shopify-app.php config
    /*
    |--------------------------------------------------------------------------
    | Shopify ScriptTags
    |--------------------------------------------------------------------------
    |
    | This option is for defining scripttags.
    |
    */
    'scripttags' => [
        /*
            [
                'src' => env('SHOPIFY_SCRIPTTAG_1_SRC', 'https://some-app.com/some-controller/js-method-response'),
                'event' => env('SHOPIFY_SCRIPTTAG_1_EVENT', 'onload'),
                'display_scope' => env('SHOPIFY_SCRIPTTAG_1_DISPLAY_SCOPE', 'online_store')
            ],
            ...
        */
    ],

@tobiasdalhof Yes, you are right. I will test it. Thank you.

Is it still working in local?

It works locally with a http tunnel like ngrok.io

Okay, thank you. I will try to figure it out.

@ardnor Yes, this is the correct way. List the scripts there and a job process will install them on authentication. Ngrok does some odd things, so I can not guarentee it will work but through Homestead and Valet, it is working for me via (https://localhost.local) I have setup.
I'll close for now, but if you run into a bug, feel free to make an issue :)

@ohmybrew Thank you for your comment. I am using Windows machine right now.

Hi @ohmybrew
I installed the app in my Shopify store and added the script tag in the shopify-app.php file, but in fronend, it won't display.
Here is my code
'scripttags' => [
            [
                'src' => env('APP_URL')."/js/crawlapps-cli-offer.js",
                'event' => env('SHOPIFY_SCRIPTTAG_1_EVENT', 'onload'),
                'display_scope' => env('SHOPIFY_SCRIPTTAG_1_DISPLAY_SCOPE', 'online_store')
            ],
    ],

Please guid me where I'm wrong.
Thank you.


Move annotation filters higher up

Context: users in UXR studies would miss the Annotations Metadata filters because it's below the fold)

move the Annotation Metadata to the section below Sample and Experiment Conditions and above Hardware on the following pages

Browse all datasets
Single deposition page

Note: Other pages will not require this move since the Annotation Metadata section is visible upon page click and not hidden below the fold
cc: @kandarpksk

FYI @Janeece for masterfile updates at some future point

For consistency, I wonder if we should also move the annotation filters above tilt series filters on the single run page.


Add One-Time Password sensor (OTP)

Description:
Adds a sensor that generates One-Time Passwords (OTP) compatible with most OTP generators, e.g. Google Authenticator. This can be used with custom security solutions to implement time based codes.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#2929
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: otp
    token: JBSWY3DPEHPK3PXP

Checklist:
If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[X] New dependencies have been added to the REQUIREMENTS variable (example).
[X] New dependencies are only imported inside functions that use them (example).
[X] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

I think that is calling TOTP ?

Currently only TOTP is implemented, yes. But I was planning on maybe adding HOTP in the future. I guess that I can of course rename this to totp and create hotp later on, but it felt a bit excessive with two platforms for such small features?

I'm with @postlund on this one, let's combine them. It's tiny.


Example App crashes on iOS 10.0 - Thread 1: EXC_BAD_ACCESS (code=1, address=0x50)

  public init(metadataObjectTypes types: [AVMetadataObject.ObjectType], captureDevicePosition: AVCaptureDevice.Position) {
    metadataObjectTypes = types
    previewLayer        = AVCaptureVideoPreviewLayer(session: session) - CRASHED LINE

    super.init()

    sessionQueue.async {
      self.configureDefaultComponents(withCaptureDevicePosition: captureDevicePosition)
    }
  }

I have no device with iOS10. Could someone help?

@yannickl I downloaded iOS 10.0 in Xcode and run it in simulator

@artoymsd but you can't use the camera with the simulator? Have you checked the permissions and the camera availability before?
try QRCodeReader.supportsMetadataObjectTypes()


Missing Usage

File: datacenter/ucp/2.1/reference/cli/backup.md, CC @joaofnfernandes
Missing Usage for UCP Backup; unclear from this page how to use the backup command. See DTR Backup for how page should look.

These docs are auto-generated so right now we don't have a way to link from this page to https://docs.docker.com/datacenter/ucp/2.1/guides/admin/backups-and-disaster-recovery/ 😞


[FEATURE] JRTB-7: As a User, I want to remove group subscription from my subscriptions

https://github.com/JiLaRiAtIoN/javarush-telegrambot/pull/23


Bug: ID from Google Analytics 4 doesn't work

Info

Tool
Version

Plugin
v2.x.x

Vue
v2.x.x

The ID generated on Google Analytics 4  is not supported because the ID starts only with G and the regex that validates the ID only supports ID starting with GTM
Input
Environment variable
VUE_APP_GTM_ID=G-XXXXXXXXX
Vue.use(VueGtm, {
  id: process.env.VUE_APP_GTM_ID,
  vueRouter: router
});

Output or Error
Uncaught Error: 'G-XXXXXXXXX' is not a valid GTM-ID (/^GTM-[0-9A-Z]+$/). Did you mean 'GTM-XXXXXXXXX'?

if it's just a matter of the regex that validates the ID maybe the next regex will fix it:
^(GTM|G)-[0-9A-Z]+$

Ok, but Google analysts is telling me to configure Google Tags using the G-XXXXXX it seems Google analytics 4 is unified with Google tags?

Ok, but Google analysts is telling me to configure Google Tags using the G-XXXXXX it seems Google analytics 4 is unified with Google tags?

If that's how it is, then we might need to fork this repo or setup a complete new one 🤔
I historically took this repo just over to maintain it (fix bugs and fix vulnerabilities and such)
But I have too much other stuff to do and I'm not involved in using GTM or GA for my self at all, so I don't benefit (anymore) from it
I'm not sure if just changing the RegEx will solve your issue because the handling of e.g. tracking events or anything like that could potentially be totally different.
But I'm not interested into digging into that because of the upper written reasons.
If everything is the same and nothing needs to be changed drastically AND it's only for Vue 3+, then I'm open to PRs and can review them.


Service Timeouts

pm2-hooks seems to be working properly (running commands, outputting logs), but each time GitHub sends out webhook to it, the website (Github)  shows a nasty error message:

"We couldn’t deliver this payload: Service Timeout"

Is this a configuration issue? Or expected behavior?

Hi @Setherizor! Seems github can get to your server, I don't think this has nothing to do with the server itself!
I think you can test some things:

It's your url correct? The url is something like this http://{host}:{port}/{appName}. Be sure you have the correct port, etc.
Is the server running? if you open the url in your browser, you get the response, see the log, etc? Maybe you are behind a firewall? maybe your port is closed on your machine?
It's the server accessible online? If you open the url from your phone, from another network (to discard issues with the dns and cache)

That is what is so strange:

the server is functioning and accessible
the logs show activity and what I would expect from GitHub webhook payloads

Everything is functioning, except the status message from GitHub saying if the request went through.

Mmm strange!
I just read github has a 10 seconds timeout for webhooks. Is your server answering in that time?
I just realized pm2-hooks waits until the command to end before returning the response, and I am pretty sure this is an issue, because in the command you can put some heavy duty work and it can be run for more than 10 seconds!
I will make a fix for that, maybe this solve your issue

Hi @Setherizor, I just published the version v1.1.14 which (I hope) fixes your issue. The only difference is that now I don't wait the command to end, I return a response to the webhook as soon as possible.
I tested it with the old version, running the command sleep 15s and as expected github said "Service Timeout", but after updating pm2-hooks to the last version everything worked fine.
I hope this fixes your issue. Please let me know if everything works now or keeps failing. Thanks!

Everything is working wonderfully and GitHub is now showing green checks! Thank you for such a wonderful project!


"Sticky hover" for collection-item on mobile with  tag

When hovering over collection-item like in the provided codepen, it highlights it, and moving the mouse away also removes the "greyed" hover effect.
On mobile, if you click on a collection-item, it stays highlighted until you click something else.
I would like to find a way to "unhover" this. (As an example, the user presses on the area, it lights up grey, 300ms later it fades back to the original colour).
I've tried loads of different jQuery methods, and it seems the main problem stems from that it has a ":hover" (css) attached to it, and mobiles don't have mice.
https://codepen.io/ExoMemphiz/pen/YeWZVX
Best Regards

This is a common problem with hovers on mobile and I don't see how this is a problem with collection-item. You can remove the :hover style on mobile devices but I don't think there is a clean programmatic way of removing the "hover" state

@acburst Is it possible you could fork my codepen to show how you could remove the hover style for mobile devices?
Thanks in advance!


Tenant Remote PowerShell - Teams

With Client Access Rules, it is possible to block PowerShell remoting to Exchange Online.
Does Teams PowerShell have a similar construct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33613b2d-d607-ec47-1254-ae540d07ad59
Version Independent ID: aba728f0-0d3c-73fd-c7fe-68e69b6a753f
Content: Security guide for Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-security-guide.md
Service: msteams
GitHub Login: @MSFTTracyP
Microsoft Alias: tracyp

@jebalert Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


Previewing branches with changes to multiple files

While the branch query param is great when previewing PRs that change just a single file, we often create PRs that change multiple files. Writers, managers, reviewers, collaborators, and repo maintainers need to be able to seamlessly click through the preview site and see all the changes. Currently, every time you click a link or select an item from the left nav, the branch query param is stripped, and you need to manually add it back to the URL. This can become tedious.
This is a common enough use case that we'd like to fix it/find a good solution.
Related test case
Previewing a newly added file.

Add a new file to the repo.

Add it to book.yml.

Commit your changes, push to GitHub. (example branch: ian-add-file)

Preview the site, but go to a file that already exists in the repo (link).
Result: If you expand the "Phases" section, you can see the new topic "Test" in the left nav

Click the new topic in the left nav.
Result: You get redirected to this URL (https://main--prisma-cloud-docs-website--hlxsites.hlx.page/prisma/prisma-cloud/en/compute/not-applicable/ops-guide/getting-started/getting-started), and only the page chrome loads

@icaraps @maxakuru Just some perspective: getting this right is critical to the success of this project. Quick, full-fidelity previews with minimal fuss is a primary motivator for ditching our current CMS.

Just some perspective: getting this right is critical to the success of this project. Quick, full-fidelity previews with minimal fuss is a primary motivator for ditching our current CMS.

@iansk I understand. I've worked on the preview GH action to display preview URLs when adoc or book changes are made and submitted as PR in the https://github.com/hlxsites/prisma-cloud-docs repo.
The output looks like following:

The warning is displayed when there is a reference to adoc files in a book that is missing in the repository.
Navigation should also be working now in preview mode. Next I'm looking into https://github.com/hlxsites/prisma-cloud-docs-website/issues/69.
Please let me know if you find issues with the GH action to preview content.


Bump razzle to razzle 3.2 (canary)

This is testing version of razzle. See razzle release page for the basics. The biggest would be experimental support for react-refresh.

For some reason tests no longer run successfully with yarn test, but they do run with yarn jest. The answer is probably somewhere here: https://github.com/jaredpalmer/razzle/blob/canary/packages/razzle/scripts/test.js

@tiberiuichim "yarn jest"? WTF? :)

@tisto: yarn jest is the same as running node_modules/.bin/jest, in my case my shell is not configured for node_modules integration

Superseded by #1967


Improved quantization and testing (merged PR)

In place of https://github.com/xenova/transformers.js/pull/127 and https://github.com/xenova/transformers.js/pull/128

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


PATH dos not atribute

Operating system and version:
nvm debug output:

nvm ls output:

How did you install nvm?

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
What steps did you perform?
ubuntu 22.04 lts
What happened?
=> Appending nvm source string to /home/micuit-cuit/.bashrc
main: ligne 432: /home/micuit-cuit/.bashrc: Permission non accordée
=> Appending bash_completion source string to /home/micuit-cuit/.bashrc
main: ligne 439: /home/micuit-cuit/.bashrc: Permission non accordée

What did you expect to happen?
add PATH
Is there anything in any of your profile files that modifies the PATH?

no

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

*   Trying 2606:4700:10::6814:172e:443...
* Connected to nodejs.org (2606:4700:10::6814:172e) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
* TLSv1.0 (OUT), TLS header, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS header, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS header, Finished (20):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.2 (OUT), TLS header, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: CN=*.nodejs.org
*  start date: Jan 11 00:00:00 2022 GMT
*  expire date: Feb 11 23:59:59 2023 GMT
*  subjectAltName: host "nodejs.org" matched cert's "nodejs.org"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
*  SSL certificate verify ok.
* Using HTTP2, server supports multiplexing
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* Using Stream ID: 1 (easy handle 0x56070984de80)
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
> HEAD /dist/ HTTP/2
> Host: nodejs.org
> user-agent: curl/7.81.0
> accept: */*
> accept-encoding: deflate, gzip, br, zstd
>
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* Connection state changed (MAX_CONCURRENT_STREAMS == 256)!
* TLSv1.2 (OUT), TLS header, Supplemental data (23):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
* TLSv1.2 (IN), TLS header, Supplemental data (23):
< HTTP/2 200
HTTP/2 200
< date: Wed, 26 Oct 2022 11:08:21 GMT
date: Wed, 26 Oct 2022 11:08:21 GMT
< content-type: text/html
content-type: text/html
< last-modified: Wed, 26 Oct 2022 11:05:11 GMT
last-modified: Wed, 26 Oct 2022 11:05:11 GMT
< cache-control: max-age=14400
cache-control: max-age=14400
< cf-cache-status: HIT
cf-cache-status: HIT
< age: 83
age: 83
< vary: Accept-Encoding
vary: Accept-Encoding
< strict-transport-security: max-age=31536000; includeSubDomains; preload
strict-transport-security: max-age=31536000; includeSubDomains; preload
< x-content-type-options: nosniff
x-content-type-options: nosniff
< server: cloudflare
server: cloudflare
< cf-ray: 7602bbc7ea45f160-CDG
cf-ray: 7602bbc7ea45f160-CDG
< content-encoding: br
content-encoding: br

<
* Connection #0 to host nodejs.org left intact

I don't speak French, but it seems like $HOME/.bashrc isn't writable by your user. Can you confirm the permissions on that file?


FEAT: Add support for samesite attribute to session cookies

Relates to #9440.
Expected behaviour
Silverstripe CMS should support the new SameSite cookie attribute for all cookies, as well as session cookies.
Observed behaviour
Silverstripe CMS doesn't properly support this attribute. There are two issues:

The Cookie::set() logic doesn't have support for the SameSite attribute.
Even if the above is fixed, Silverstripe CMS has some logic that sets the session cookie on every HTTP request, which means that until this fix is in place, you can set the samesite attribute via ini_set() but it only works for the very first Set-Cookie header - from then on the framework sets the cookie without the flag.

I think this fix is backwards compatible. It allows the attribute to be set, but only on PHP 7.3+ because it can't be set on older versions of PHP than that (without manually setting HTTP headers).
This doesn't take on any of the complexity that #9548 discussed, just the simplest possible thing to ensure that the samesite attribute is consistently set on session cookies.

@madmatt @emteknetnz @matt-in-a-hat It'd be great if this PR could be fixed up so it can be merged. Incorporating it requires very little changes but makes SilverStripe a lot more flexible in headless environments :)
Happy to fork it and open a new PR, but I just thought I'd give this a push because it looks like it's nearly there.

Closing in favour of #10335 which avoids breaking changes this PR would introduce.


[windows] failed with exit code 1. 'rm' is not recognized

consider replacing rm -rf with rimraf for crossplatform compatibility
> rm -rf dist && pnpm package-cjs && pnpm package-esm && pnpm package-types && pnpm package-types-aliases

 ELIFECYCLE  Command failed with exit code 1.
'rm' is not recognized as an internal or external command,
       operable program or batch file.

maybe also consider using cross-env too, to avoid stuff like this
> NODE_ENV=cjs pnpm transpile --out-dir dist/cjs --source-maps

'NODE_ENV' is not recognized as an internal or external command,
       operable program or batch file.
        ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

    ×  nx run users-contracts:package
       ><EMAIL_ADDRESS>package C:\git\yb\swarmion-full-stack\contracts\users-contracts
> rimraf dist && pnpm package-cjs && pnpm package-esm && pnpm package-types && pnpm package-types-aliases

You're right, this would be a good improvement!


Which volume is this referencing, consensus data or execution data or something else?

https://github.com/eth-educators/eth-docker-docs/blob/c17a0a289e0454e26c7c3cee67e4cba58d0913fc/website/docs/Support/Moving.md?plain=1#L54

Neither. This is for the validator client that holds the keys.

So, for example, which of these is the volume for the validator?
local     eth-staker_grafana-config
local     eth-staker_grafana-data
local     eth-staker_jwtsecret
local     eth-staker_loki-data
local     eth-staker_nm-eth1-data
local     eth-staker_prom-data
local     eth-staker_promtail-data
local     eth-staker_teku-data

eth-staker_teku-data because you are using Teku, which doesn't distinguish.
I've changed the instructions to make this a lot easier.


deps: bump k8s dependencies to 1.24

Bumps all k8s-* dependencies to 1.24.
Closes #397

Unfortunately, go mod tidy fails with the following:
github.com/operator-framework/rukpak/internal/convert imports
	github.com/operator-framework/operator-registry/pkg/registry tested by
	github.com/operator-framework/operator-registry/pkg/registry.test imports
	github.com/operator-framework/operator-registry/pkg/lib/bundle imports
	github.com/operator-framework/api/pkg/validation imports
	github.com/operator-framework/api/pkg/validation/internal imports
	k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/validation imports
	k8s.io/apiserver/pkg/util/webhook imports
	k8s.io/component-base/traces imports
	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp imports
	go.opentelemetry.io/otel/semconv: module go.opentelemetry.io/otel@latest found (v1.7.0), but does not contain package go.opentelemetry.io/otel/semconv
github.com/operator-framework/rukpak/internal/convert imports
	github.com/operator-framework/operator-registry/pkg/registry tested by
	github.com/operator-framework/operator-registry/pkg/registry.test imports
	github.com/operator-framework/operator-registry/pkg/lib/bundle imports
	github.com/operator-framework/api/pkg/validation imports
	github.com/operator-framework/api/pkg/validation/internal imports
	k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/validation imports
	k8s.io/apiserver/pkg/util/webhook imports
	k8s.io/component-base/traces imports
	go.opentelemetry.io/otel/exporters/otlp imports
	go.opentelemetry.io/otel/sdk/metric/controller/basic imports
	go.opentelemetry.io/otel/metric/registry: module go.opentelemetry.io/otel/metric@latest found (v0.30.0), but does not contain package go.opentelemetry.io/otel/metric/registry

I believe this is due to the operator-registry relying on an old version of the open-telemetry project

Can we manually vendor anything we use from the registry here? It looks like it's a single type definition that we can inline into this repository, and cut out that dependency entirely.

Yes agreed -- that sounds much nicer, and will avoid a lot of pain going forward.

We should also bump the kind tool dependency to make sure we pick up a the kind version that deploys a 1.24 cluster by default. Looks like that's 0.14.0 at the moment.

Yes, definitely. I wanted to split the tooling bumps in a separate commit. Since the current issue with the e2e (#423)  is likely to be resolved in a standalone PR and this PR will then be rebased, I think it's fine to add that change now.

Moving this out of WIP since the PR now does what is required: all direct dependencies and tooling are moved to 1.24 versions of kubernetes.
Seeing two e2e failures, both seemingly unrelated:
[FAIL]plain provisioner bundleinstance embedded bundle template [It] should generate a Bundle that contains the correct labels
/home/runner/work/rukpak/rukpak/test/e2e/plain_provisioner_test.go:740

This is due to the non-determinism in the hash output per #423
[FAIL]bundle api validating webhook the bundle name is too long [It] should fail the long name bundle creation
/home/runner/work/rukpak/rukpak/test/e2e/webhook_test.go:85

I believe this is due to the webhook getting bypassed for some reason? I may have seen a failure like this before in prior e2e runs. cc @akihikokuroda

I believe that the validation error message must be changed.  The test needs to be changed to match to the new error message.
The webhook_test.go:85 must be changed to:
Expect(err).To(MatchError(ContainSubstring(fmt.Sprintf("Bundle.core.rukpak.io %q is invalid: metadata.name: Too long: may not be longer than 40", bundle.GetName()))))

I believe that the validation error message must be changed. The test needs to be changed to match to the new error message.
The webhook_test.go:85 must be changed to:
Expect(err).To(MatchError(ContainSubstring(fmt.Sprintf("Bundle.core.rukpak.io %q is invalid: metadata.name: Too long: may not be longer than 40", bundle.GetName()))))

We can update the string in the error message, but I'm having a hard time seeing why updating from 1.23 to 1.24 would cause the error message to change? In both cases, the Bundle creation fails due to the Bundle CRD schema validation right? The core webhook is no longer doing Bundle name length checks.
Looking at the existing e2e test, we expect that something like should be at most 40 chars long is emitted, but I can't tell where that's coming from?

The validation has been moved from the webhook to the CRD definition patch. The message is not from the rukpak code.  It's from kubernetes (I guess).


Local actions in .github/actions/ are not checked

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
github-actions
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
No response
dependabot.yml content
version: 2
updates:

package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"

Updated dependency
No response
What you expected to see, versus what you actually saw
When directory is set to "/", I expect that local actions located in .github/actions/ are also checked.
This is not the case.
You need to add a new item in the config file to allow Dependabot to check a specific action
  - package-ecosystem: "github-actions"
    directory: "/.github/actions/deployment-tools"
    schedule:
      interval: "weekly"

Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
No response
Smallest manifest that reproduces the issue
No response

Hei @benoitchantre! Did you find .github/actions documented anywhere? I did find one mention at https://docs.github.com/en/actions/creating-actions/about-custom-actions#choosing-a-location-for-your-action, is that the advice you followed when you put your actions at a .github/actions folder?

Yes, the location I choosed was influenced by the documentation.

If you plan to combine action, workflow, and application code in a single repository, we recommend storing actions in the .github directory. For example, .github/actions/action-a and .github/actions/action-b.

Source: https://docs.github.com/en/actions/creating-actions/about-custom-actions#choosing-a-location-for-your-action

Moving comment from:
https://github.com/dependabot/dependabot-core/issues/7495#issuecomment-1729129950

I have been running into the same issue.
I took a look at the code. It also looks for action.yml and action.yaml in the directory specified. Which means, there is workaround, a bit painful, but it works.
.github/dependabot.yml
  - package-ecosystem: "github-actions"
    # Workflow files stored in the
    # default location of `.github/workflows`
    directory: "/.github/actions/a_reusable_workflow"
    schedule:
      interval: "daily"

It means you will need to add an entry in dependabot.yml for every single .github/actions folder.

@deivid-rodriguez
The change to add support for scanning .github/actions does not look too bad. Should we look for just action.*(yaml|yml) files or all *.(yaml|yml) files in .github/actions?
https://github.com/dependabot/dependabot-core/blob/0997935bfe7531a9f623c432eb3004846b369621/github_actions/lib/dependabot/github_actions/file_fetcher.rb#L48-L67

I guess just action.ya?ml for now? It seems that's the documented name at https://docs.github.com/en/actions/creating-actions/about-custom-actions#types-of-actions.

Any update on this? The workaround is particularly annoying because it seems using a glob doesn't work:
  - package-ecosystem: "github-actions"
    directories:
      - "/.github/workflows"
      - "/.github/actions/*"

The problem is that the actions schema is different enough from the workflows ones. They share a lot of similarities but they are not compatible. The code needs to be able to read and update both.

The problem is that the actions schema is different enough from the workflows ones. They share a lot of similarities but they are not compatible. The code needs to be able to read and update both.

I don't think this is the problem of this issue. This issue is about needing to be explicit about local action paths. If the problem was a schema issue, then it shouldn't work to check local actions at all, regardless of how they are specified (which was #4327).

There is a work around as described above.
I wrote an action that will update the .github/dependabot.yml file to include files found in .github/actions: https://github.com/streetsidesoftware/actions/tree/main/public/update-dependabot-github-actions
Here is an example of where it is used: https://github.com/streetsidesoftware/cspell-dicts/blob/main/.github/workflows/update-dependabot.yml


linuxPackages.rtl8814au: 2021-05-18 -> 2021-10-25

Fixes build with Linux 5.15.
ZHF: #144627
@NixOS/nixos-release-managers
I can't test this because I don't have the hardware.

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Uh sadly I don't have the hardware with me to test this. But if it builds I guess its fine :D


Test reverting to OS 1.3.14

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/CAFapi/job/CAFapi~opensuse-opensearch1-image~mb-test1314~CI


Various updates

Fixes #42
Fixes #37
Fixes #36
Fixes #3

Also worked on the following

cleaned up components so they all follow same syntax/standards
added Storybook to start documenting components (more work to document this will come in future PR)
cleaned up CSS a bit
moved data to separate folder so it's easier to view

Need to migrate docs from wiki to storybook but then we should be good!

You’re amazing! Thanks for doing all this! 👌🏽🙌🏽 Learning so much by
looking at what you did! 👩🏽💻
On Sat, May 27, 2023 at 4:47 PM Frances Coronel @.***>
wrote:

Merged #44 https://github.com/Latina-Dev/latina-dev/pull/44 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/Latina-Dev/latina-dev/pull/44#event-9358785852, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AZFXIFZ4OGCKSN43TS6KI6DXIJY5XANCNFSM6AAAAAAYKDHSPQ
.
You are receiving this because your review was requested.Message ID:
@.***>


(PUP-4635) Fix pacman provider to handle failure on group queries.

Installing packages with pacman fails when the package is not in a
group.
This is fixed by allowing a non-zero exit code for some of the pacman calls.

CLA signed by all contributors.

works like a charm :+1:
master:
# pacman -R xclip --noconfirm
# puppet apply test.pp
Notice: Compiled catalog for arch64 in environment production in 0.78 seconds
Info: Applying configuration version '1432877782'
Error: /Stage[main]/Default_packages/Package[xclip]: Could not evaluate: Error while getting installed groups
Notice: Applied catalog in 0.41 seconds
# which xclip
which: no xclip in (/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl)

this branch:
# pacman -R xclip --noconfirm
# puppet apply test.pp
Notice: Compiled catalog for arch64 in environment production in 0.80 seconds
Info: Applying configuration version '1432877692'
Notice: /Stage[main]/Default_packages/Package[xclip]/ensure: created
Notice: Applied catalog in 15.31 seconds
# which xclip
/usr/bin/xclip

This needs to be retargeted to stable.

Closed in favor of #3989.


⚠ PrivateHD has degraded performance

In d25a910, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2107 ms

Resolved: PrivateHD performance has improved in 1e78beb.


Add Vitalije as diplomat for sr (Serbian)

Coverage remained the same at 63.678% when pulling 1a5a40820333e25fe94461be10e5a21f0fdd622d on vitalije:patch-1 into 8281b32d6aadc169cbe1ade47c9188a6e91a63aa on codecombat:master.


ImportError: cannot import name '_ext' from 'smoke' (unknown location)

Hi,
I tried to use pretrained weight to predict images on Google Colab but got error ImportError: cannot import name '_ext' from 'smoke' (unknown location).
I ran "!python setup.py build develop" and "!python setup.py install" before.
!python setup.py build develop

!python setup.py install

My code:

I encountered the same mistake. I solved it by rebuild the DCNv2.

can you provide me the rebuild DCNv2 that you are using ... i couldnt solve the issue


Use an alternative to convertSwagger2markup for openapi spec (v3)

https://github.com/OpenAPITools/openapi-generator/tree/master ?
https://openapi.tools/

Fixed by #954


Make show task present the output to the build window

remove mandatory json output
replace json search for deletions with regexmatch

@charleszipp any thoughts? Happy Thanksgiving!

This should also fix #171

@charleszipp, when time permits, could you please have a look at this?

@alex-goncharov should we abandon this PR in favor of the other two you have in progress?

I believe this can be closed now in favor of #179. @alex-goncharov let me know if this should be re-opened.


Beta tidy & fix spell list builder

this is incorrect. when used on subs the spell list builder is offering level 1 spells as cantrips [sleep]


DBZ-1753 Refactor common code between SQL Server and DB2

https://issues.redhat.com/browse/DBZ-1753

Applied. Thanks!


Why not allow multiple URL input at a time?

My bad. It's there :3

hey there, glad you found it! closing this one


recyclerView height change animation

to work 100% users need to call SearchView#setAdapter() only if the recyclerView.getAdapter() returns null (in my project there was a problem with back navigation and recycling).


[WIP, BUG] Updated Current Source Density

Addresses https://github.com/mne-tools/mne-python/issues/7862.
Passes all tests and matches example from https://github.com/alberto-ara/Surface-Laplacian but testing data needs to be added to mne-testing-data and some code review would be appreciated. I think the for loops could or mostly all be changed to matrix multiplication or called through numpy/scipy but I'll need to look into that. Thanks @mservantufc for bringing this to attention. It appears as if the previous version was not working.
Maybe @larsoner and/or @jasmainak might have a minute to review since they were nice enough to help me with the original PR :) ?

@alexrockhill can you touch the example file to we see how it looks now on the circleci artifact?

Happy to help make it more efficient, etc. but we need to get the test files over to mne-testing-data first. If you want, you can just email them to me and I can do it

Oh wait, I see ... actually these are small enough that they can probably just stay here. I'll fix the code

can you compress the files a bit? maybe ship them as npz?

can you compress the files a bit? maybe ship them as npz?

Oof actually I didn't realize that test_eeg.csv is 30 MB. This should indeed be moved to mne-testing-data. I can do this quickly

(I will probably also just save it as .mat for ease of cross-platform loading)

+1

@alexrockhill I pushed a commit to:

Vectorize everything
Move test files to .mat in mne-testing-data
Touch the CSD example

The CSD example looks bad now. Also, I noticed that the norm of the matrix G is about six orders of magnitude different between the EEG-file test and the FIF-file test, which suggests that there is some scale factor problem going on (maybe a units problem, everything radius/pos should be done in meters, maybe one at some point is in mm?
On master the norm of G appears to be around 0.001, whereas on this PR it's much larger. This effectively changes the usefulness of lambda2 quite a bit. We're going to need to fix this -- perhaps we should always use lambda2 * linalg.norm(G) or so, which will make it more invariant to these sorts of scale changes. We'll also need to adjust the default from 1e-5 to something much higher (0.05? maybe set by eye) to match the new norm levels.

@alexrockhill I pushed a commit to:

Vectorize everything
Move test files to .mat in mne-testing-data
Touch the CSD example

The CSD example looks bad now. Also, I noticed that the norm of the matrix G is about six orders of magnitude different between the EEG-file test and the FIF-file test, which suggests that there is some scale factor problem going on (maybe a units problem, everything radius/pos should be done in meters, maybe one at some point is in mm?
On master the norm of G appears to be around 0.001, whereas on this PR it's much larger. This effectively changes the usefulness of lambda2 quite a bit. We're going to need to fix this -- perhaps we should always use lambda2 * linalg.norm(G) or so, which will make it more invariant to these sorts of scale changes. We'll also need to adjust the default from 1e-5 to something much higher (0.05? maybe set by eye) to match the new norm levels.

Thanks so much, I am definitely not as skilled at vectorizing.
I think maybe pos * 1e-3 can be added with sphere updated accordingly and it should still pass the tests. I can check.

Pushed one more efficiency commit, no more redundant lpn calculations, or unnecessary diagonal ones.
This might make it more difficult to debug, though, so feel free to go back to your old code for _calc_G_H for testing and iteration if you need to. I can easily restore the more efficient version later (or feel free to copy-paste it back in once you have everything working).

But radius also shows up in a later calculation. I guess this means that it's not scale invariant...?

BTW you can see in the output of this example that something is broken (and that lambda2 does not currently matter):
https://20396-1301584-gh.circle-artifacts.com/0/dev/auto_examples/preprocessing/plot_eeg_csd.html#sphx-glr-auto-examples-preprocessing-plot-eeg-csd-py

Hmmm yeah changing to mm and then changing 85 radius to 0.085 didn't work, I agree on it not being scale invariant. Not sure what's going on here though.

Although the tests are passing and the evoked data is the same, when I went back and plotted this example https://github.com/alberto-ara/Surface-Laplacian/blob/master/surface laplacian example.ipynb the topomap it was uniform... I think the tests aren't covering the issue for some reason

Maybe the atol is wrong/meaningless. Does the topomap look okay with your code?
Also, is it possible that the electrode locations are supposed to be projected onto a sphere? They currently are not, unless by happenstance you are using a spherical montage with zero origin.

... based on code comments for the old _calc_g, indeed it looks like cos_dist should be between 0 and 1 because it's meant to be "cosine of angles between pairs of points on a spherical surface". So really it shouldn't be calculated using the squared euclidean distance, but rather directly via the dot product of unit vectors. I'll see if it fixes the FIF data...

Okay this might have fixed things, let me push...

Ahh I think you're right the the error tolerance is meaningless. The scale of the example data is 1e-6 to 1e-7 so etol would have to be much lower.

If I go back to c2586be (when you opened the PR) and fix the path problems and use a sensible atol, you can see things are already broken there:
>       assert_allclose(epochs_csd.average().data, csd, atol=1e-7)
E       AssertionError:
E       Not equal to tolerance rtol=1e-07, atol=1e-07
E
E       Mismatched elements: 38831 / 40960 (94.8%)
E       Max absolute difference: 1.23793879e-05
E       Max relative difference: 9.19420201
E        x: array([[-3.616917e-10, -7.107747e-10, -6.617863e-10, ..., -7.082218e-10,
E               -6.186906e-10, -7.052339e-10],
E              [-3.351042e-10, -7.403796e-10, -7.674658e-10, ...,  1.577782e-10,...
E        y: array([[-1.023747e-06, -5.399796e-07, -1.163600e-06, ..., -1.681479e-06,
E               -1.770453e-06, -1.318637e-06],
E              [-8.542492e-07, -5.915384e-07, -1.396437e-06, ...,  9.873015e-07,...

So maybe go back to that commit and fix things first? Then you can force-push and I can cherry-pick my commits on top...

We can update the testing data to fix it, if you want to work from c2586be and push-force over my changes I can fix the testing data. But we should wait until we have something that works with a reasonable atol first

If the CSV you pushed is the one to compare against and it passes on c2586be, I can take care of the rest of the annoying steps.

... with that file on top of c2586be I get:
mne/preprocessing/tests/test_csd.py:84: in test_csd_matlab
    assert_allclose(epochs_csd.average().data, csd, atol=1e-10)
E   AssertionError:
E   Not equal to tolerance rtol=1e-07, atol=1e-10
E
E   Mismatched elements: 40960 / 40960 (100%)
E   Max absolute difference: 4.65739658e-05
E   Max relative difference: 4.92637861
E    x: array([[-3.616917e-10, -7.107747e-10, -6.617863e-10, ..., -7.082218e-10,
E           -6.186906e-10, -7.052339e-10],
E          [-3.351042e-10, -7.403796e-10, -7.674658e-10, ...,  1.577782e-10,...
E    y: array([[ 3.122692e-06,  6.683897e-06,  9.506682e-06, ..., -2.452742e-05,
E           -2.426614e-05, -2.801882e-05],
E          [ 7.973345e-06,  9.962245e-06,  1.211932e-05, ..., -9.860589e-06,...

So hopefully there is more to come and I just should have been more patient :)

I can go back and fix tests, sorry I may need a bit of time to clean it all up from where it worked

Sounds good, as I said feel free to force push over my changes, it's possible that my calculations are not equivalent since I was assuming the tests would tell me if something broke. Once you have something that matches, knowing the efficiency bits and the project-to-sphere-for-cosine-distance things I think I can reincorporate my stuff fairly easily!

@alexrockhill nice commit message :) just let me know when you want me to take a look

Sorry give me a bit more time, I'll send you a message, just writing more commits so it's easier to go back than before

Ok @larsoner, if you have time to optimize at all, that would be fantastic. I have to leave this for now and pick it up tonight but it has a working test and I triple checked that it replicates the example from https://github.com/alberto-ara/Surface-Laplacian/blob/master/surface laplacian example.ipynb. There is still a lot of optimizing to do and the data needs to be updated in mne-testing-data. I can get to those later and send another message then but if you did have some time to give it a pass over that might save me optimizing it and then realizing I don't know how np.clip etc. works and that that would work much better. Either way, I'll work on it more tonight. Again, really sorry for the faulty test script!!

Again, really sorry for the faulty test script!!

Don't sweat it! Figuring out there was a problem cost less time than actually doing the optimizations, and now that I've done them they should be easy to put back. I'll see if I can fix things without too much effort, and hand it back to you when I get stuck :)

(Plus the bonus of social coding is that it's not just your fault that a test you coded did not work, but also mine as a reviewer because I should have looked more carefully / caught it and told you to fix it, or fixed it myself, before even going down the optimization route... yay shared responsibility!)

PR vs master

Here is the relevant code from the original MATLAB source as far as I can tell
% CSD - Current Source Density (CSD) transformation based on spherical spline
%       surface Laplacian as suggested by Perrin et al. (1989, 1990)
%
% (published in appendix of Kayser J, Tenke CE, Clin Neurophysiol 2006;117(2):348-368)
%
% Usage: [X, Y] = CSD(Data, G, H, lambda, head);
%
% Implementation of algorithms described by Perrin, Pernier, Bertrand, and
% Echallier in Electroenceph Clin Neurophysiol 1989;72(2):184-187, and
% Corrigenda EEG 02274 in Electroenceph Clin Neurophysiol 1990;76:565.
%
% Input parameters:
%   Data = surface potential electrodes-by-samples matrix
%      G = g-function electrodes-by-electrodes matrix
%      H = h-function electrodes-by-electrodes matrix
% lambda = smoothing constant lambda (default = 1.0e-5)
%   head = head radius (default = no value for unit sphere [µV/m²])
%          specify a value [cm] to rescale CSD data to smaller units [µV/cm²]
%          (e.g., use 10.0 to scale to more realistic head size)
%
% Output parameter:
%      X = current source density (CSD) transform electrodes-by-samples matrix
%      Y = spherical spline surface potential (SP) interpolation electrodes-
%          by-samples matrix (only if requested)
%
% Copyright (C) 2003 by Jürgen Kayser (Email<EMAIL_ADDRESS>% GNU General Public License (http://www.gnu.org/licenses/gpl.txt)
% Updated: $Date: 2005/02/11 14:00:00 $ $Author: jk $
%        - code compression and comments
% Updated: $Date: 2007/02/07 11:30:00 $ $Author: jk $
%        - recommented rescaling (unit sphere [µV/m²] to realistic head size [µV/cm²])
%   Fixed: $Date: 2009/05/16 11:55:00 $ $Author: jk $
%        - memory claim for output matrices used inappropriate G and H dimensions
%   Added: $Date: 2009/05/21 10:52:00 $ $Author: jk $
%        - error checking of input matrix dimensions
%
function [X, Y] = CSD(Data, G, H, lambda, head)
[nElec,nPnts] = size(Data);            % get data matrix dimensions
if ~(size(G,1) == size(G,2)) | ...     % matrix dimension error checking:
   ~(size(H,1) == size(H,2)) | ...     % G and H matrix must be nElec-by-nElec
   ~(size(G,1) == nElec) | ...
   ~(size(H,1) == nElec)
   X = NaN; Y = NaN;                   % default to invalid output
   help CSD
   disp(sprintf(strcat('*** Error: G (%d-by-%d) and H (%d-by-%d) matrix', ...
                       ' dimensions must match rows (%d) of data matrix'), ...
                       size(G),size(H),nElec));
   return
end
mu = mean(Data);                       % get grand mean
Z = (Data - repmat(mu,nElec,1));       % compute average reference
Y = Data;  X = Y;                      % claim memory for output matrices
if nargin < 5; head = 1.0; end;        % initialize scaling variable [µV/m²]
head = head * head;                    % or rescale data to head sphere [µV/cm²]
if nargin < 4; lambda = 1.0e-5; end;   % initialize smoothing constant
for e = 1:size(G,1);                   % add smoothing constant to diagonale
  G(e,e) = G(e,e) + lambda;
end;
Gi = inv(G);                           % compute G inverse
for i = 1:size(Gi,1);                  % compute sums for each row
  TC(i) = sum(Gi(i,:));
end;
sgi = sum(TC);                         % compute sum total
for p = 1:nPnts
  Cp = Gi * Z(:,p);                    % compute preliminary C vector
  c0 = sum(Cp) / sgi;                  % common constant across electrodes
  C = Cp - (c0 * TC');                 % compute final C vector
  for e = 1:nElec;                     % compute all CSDs ...
    X(e,p) = sum(C .* H(e,:)') / head; % ... and scale to head size
  end;
  if nargout > 1; for e = 1:nElec;     % if requested ...
    Y(e,p) = c0 + sum(C .* G(e,:)');   % ... compute all SPs
  end; end;
end;

% function [G,H] = GetGH (M, m)
%
% Modification of GetCSD.m to obtain the G- and H-matrices, which are
% invariant for a given EEG montage, which are then used as input with
% the EEG/ERP data to the CSD.m routine
%
% Usage: [G,H] = GetGH (M, m)
%
% Input parameter:
%         M = a MatLab structure for an EEG montage consisting of <n> sites
%             as returned by the function ExtractEEGMontage.m;
%             M consists of:  <n> cell string array 'lab'
%                             <n> double 'theta'
%                             <n> double 'phi'
%                             <n * 2> double matrix 'xy'
%                             ('xy' values are not used in this function)
%         m = positive integer constant that affects spherical spline flexibility
%             values of m can be:    2 - most flexible interpolation
%                                    3 - medium flexibility
%                                    4 - more rigid splines (default)
%                                5..10 - increasingly rigid splines
%
% Output parameters:
%         G = G electrodes-by-electrodes matrix (SP spline)
%         H = H electrodes-by-electrodes matrix (CSD spline)
%
% Notes: 1) GetGH.m differs from GetCSD.m by removing the first three lines
%           in the GetCSD.m code because spherical angles are defined through
%           <M>, and by removing the last line handling the EEG/ERP data
%        2) In contrast to GetCSD.m, the <m> constant may be optionally
%           specified as an input parameter (default: m = 4)
%        3) Using the G and H matrices with data not conforming to the original
%           EEG montage will not produce valid CSDs
%        4) The orientation of Theta and Phi is defined in the appendix of
%           Kayser J, Tenke CE, Clin Neurophysiol 2006;117(2):348-368), and
%           is not identical to other spherical notifications using the
%           same spherical angle names (e.g., as in EEGlab)
%
% -----------------------------------------------------------------------
% GetCSD - Compute Current Source Density (CSD) estimates using the spherical spline
%          surface Laplacian algorithm suggested by Perrin et al. (1989, 1990)
%
% (published in appendix of Kayser J, Tenke CE, Clin Neurophysiol 2006;117(2):348-368)
%
% Usage: [CE] = GetCSD(EEGmont, ERPdata);
%
% Implementation of algorithms described by Perrin, Pernier, Bertrand, and
% Echallier in Electroenceph Clin Neurophysiol 1989;72(2):184-187, and
% Corrigenda EEG 02274 in Electroenceph Clin Neurophysiol 1990;76:565.
%
% Input parameters:
%   EEGmont = name of EEG montage spherical coordinates file in ASCII format,
%             with rows consisting of six columns: electrode label, two
%             spherical angles (theta, phi), and Cartesian coordinates x,y,z
%   ERPdata = name of ERP data file in ASCII format stored as
%             electrodes-by-samples (rows-by-columns) matrix
%
% Output parameter:
%        CE = CSD estimates as electrodes-by-samples matrix
%
% Copyright (C) 2003 by Jürgen Kayser (Email<EMAIL_ADDRESS>% GNU General Public License (http://www.gnu.org/licenses/gpl.txt)
% Updated: $Date: 2005/02/11 14:00:00 $ $Author: jk $
% -----------------------------------------------------------------------
% Modified: $Date: 2009/05/12 19:12:00 $ $Author: jk $
%        - eliminate <ERPdata> input argument and direct use of CSD.m
%        - return G and H transformation matrices
%    Added: $Date: 2009/05/14 17:20:00 $ $Author: jk $
%        - input argument <m> to specify constant for spline flexibility
%    Added: $Date: 2009/05/22 11:28:00 $ $Author: jk $
%        - progress bar to indicate status of iteration
%  Changed: $Date: 2010/04/11 19:46:00 $ $Author: jk $
%        - allow more rigid values for spline constant m [2..10]
%
function [G,H] = GetGH (M, m)
ThetaRad = (2 * pi * M.theta) / 360;     % convert Theta and Phi to radians ...
PhiRad = (2 * pi * M.phi) / 360;         % ... and Cartesian coordinates ...
[X,Y,Z] = sph2cart(ThetaRad,PhiRad,1.0); % ... for optimal resolution
nElec = length(M.lab);                   % determine size of EEG montage
EF(nElec,nElec) = 0;                     % initialize interelectrode matrix ...
for i = 1:nElec; for j = 1:nElec;        % ... and compute all cosine distances
  EF(i,j) = 1 - ( ( (X(i) - X(j))^2 + ...
    (Y(i) - Y(j))^2 + (Z(i) - Z(j))^2 ) / 2 );
end; end;
if nargin < 2
   m = 4;                                % set m constant default
end
if ~ismember(m,[2:10])                    % verify m constant
%   disp(sprintf('Error: Invalid m = %d [use 2, 3, or 4]',[m]));
   disp(sprintf('Error: Invalid m = %d [use an integer between 2 and 10]',[m]));
   G = NaN;
   H = NaN;
   return
end
disp(sprintf('Spline flexibility:  m = %d',[m]));
N = 50;                                  % set N iterations
G(nElec,nElec) = 0; H(nElec,nElec) = 0;  % claim memory for G- and H-matrices
fprintf('%d iterations for %d sites [',N,nElec); % intialize progress bar
for i = 1:nElec; for j = 1:nElec;
  P = zeros(N);                          % compute Legendre polynomial
  for n = 1:N;
    p = legendre(n,EF(i,j));
    P(n) = p(1);
  end;
  g = 0.0; h = 0.0;                      % compute h- and g-functions
  if j == 1; fprintf('*'); end;          % show progress
  for n = 1:N;
    g = g + ( (( 2.0*n+1.0) * P(n)) / ((n*n+n)^m    ) );
    h = h + ( ((-2.0*n-1.0) * P(n)) / ((n*n+n)^(m-1)) );
  end;
  G(i,j) =  g / 4.0 / pi;                % finalize cell of G-matrix
  H(i,j) = -h / 4.0 / pi;                % finalize cell of H-matrix
end; end;
disp(']');                               % finalize progress bar

Just so that this is here as reference.

(FYI, fortunately we got permission from Jurgen a couple of years ago to relicense his implementation under BSD, otherwise we could not use / look at this snippet because of the GPL license)

(FYI, fortunately we got permission from Jurgen a couple of years ago to relicense his implementation under BSD, otherwise we could not use / look at this snippet because of the GPL license)

Great I think Dennis had mentioned that earlier. Thanks so much for finishing everything @larsoner!
It might be worth also citing:

Cohen, M.X. (2014). Surface Laplacian In Analyzing neural time series data: theory and practice
(pp. 275-290). London, England: The MIT Press.

The formatting for that looks complex, I'll have to look into the documentation on how citations are done now.

Just add entries like I did already in this PR. It's standard bibtex entries, should be easier rather than more difficult

Ok doing now, where are you on projecting onto the sphere or not? Is it just preliminary commenting it out?

Okay @alexrockhill I think I'm happy with our code now, having read through Mike's and Jurgen's code.

Sorry @alexrockhill I had to rebase, so while I was in there I squashed our commits, hope that's okay. This one can be rebase+merged to preserve history if whoever hits the green button can remember to do so...

Sorry @alexrockhill I had to rebase, so while I was in there I squashed our commits, hope that's okay. This one can be rebase+merged to preserve history if whoever hits the green button can remember to do so...

Of course, that's great. Thanks for doing the hard parts :)

you mean the fun part for @larsoner :)

Thanks @alexrockhill !

@larsoner you merged this without squashing so we now have in the history the big CSV files that were pushed by @alexrockhill in the first commits.... grrrrr
I saw this as it required 15s for me to fetch master :(
rewriting history to remove these files may put a mess on the current PRs...
@larsoner wdyt?

https://github.com/mne-tools/mne-python/commit/0f8788ffbe6ceff6fb64ddfab27a8d7f1d841478 is the commit now in master

Argh sorry forgot about those. The rebase and merge was intentional to preserve code history/blame, but I forgot about the file commits. Thanks for push forcing to fix it

@cbrnr @larsoner @drammock @alexrockhill @hoechenberger @GuillaumeFavelier FYI I force pushed to master to remove the 60MB of csv files that were commited by mistake from this PR. I hope it does not create too much of a mess on your PRs....


alevolar macrophage location updated

uberon term -  lumen of pulmonary alveolus is imported into CL
alveolar macrophage location is updated - has relationship 'located in' some 'lumen of pulmonary alveolus'

@anitacaron there is a conflict within the branch, would I be able to resolve this by editing the file to remove the older version so deleting these lines  "http://purl.obolibrary.org/obo/cl/patterns/definitions.owl
<<<<<<< 2404-alveolar-macrophage-location
http://purl.obolibrary.org/obo/cl/releases/2024-08-07/patterns/definitions.owl
Annotation(owl:versionInfo "2024-08-07")
======="

#gogoeditdiff


Fix too eager templater reg exp

This pull request is fixing a simple bug that prevent the option to have two or more patterns without any spaces between them without having to add spaces inside the curly braces:
examples of pattern this PR solves:
"${num}/${total}"
"${value}${index}"
"${filename}.${ext}"
...

In the current code, it doesn't works because the genericPlaceholderPattern is too eager and split the patterns as one element (eg: ["${num}/${total}"] instead of ["${num}", "/", "${total}"]) then it changes the first value so we get only the equivalent of ${num} if we keep my last example.
And indeed, they all can be solved like this:
"${ num }/${ total }"
"${ value }${ index }"
"${ filename }.${ ext }"
...

but let's not limiting the options of your users ? 😉
thanks in advance!

Good catch! Thanks for the contribution 🎉


Unable 'npm start' locally

I have searched for a couple hours and just cant get around this issue. The server always returns this message with exit status 237. I Tried searching the troubleshooting page of Ghost as well and just cant seem to run it. I am using windows 7:
0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\\node.exe',
1 verbose cli   'C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose node symlink C:\Program Files\nodejs\node.exe
5 verbose run-script [ 'prestart', 'start', 'poststart' ]
6 info prestart<EMAIL_ADDRESS>7 info start<EMAIL_ADDRESS>8 verbose unsafe-perm in lifecycle true
9 info<EMAIL_ADDRESS>Failed to exec start script
10 error<EMAIL_ADDRESS>start: node index
10 error Exit status 237
11 error Failed at the<EMAIL_ADDRESS>start script.
11 error This is most likely a problem with the ghost package,
11 error not with npm itself.
11 error Tell the author that this fails on your system:
11 error     node index
11 error You can get their info via:
11 error     npm owner ls ghost
11 error There is likely additional logging output above.
12 error System Windows_NT 6.1.7601
13 error command "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
14 error cwd C:\Users\Jesse\Desktop\www\ghost.com
15 error node -v v0.10.40
16 error npm -v 1.4.28
17 error code ELIFECYCLE
18 verbose exit [ 1, true ]

Hi @alvaraj2, sorry to hear you're having trouble. As mentioned in the readme & contrib guide, if you have questions about Ghost or need help, please head on over to slack - https://ghost.org/slack/ - and post in the #help channel. There you can get help & support from the Ghost community, which we're not able to do here in the GitHub bug tracker.


Add support for LoongArch64

Did you test this on actual hardware? Can you give us more details? I want to make sure this was actually tested in use, and not that it just compiles.  Thanks!


Clarify that System.Decimal is not IEEE-754 compliant in documentation

Issue description
Neither the reference docs or the decimal docs point out that the decimal type is not a binary128 or decimal128 value despite being listed among binary32 and binary64 values.
This is evident when we look at the representation of 1.0 in different 128-bit floating point formats (in little endian.)

binary128: 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xFF, 0x3F
decimal128: 0x1, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x22
Decimal (GetBits): 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
Decimal (Memory): 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00

Note that the last 2 bytes of decimal128 are different. Parsing the decimal128 value into System.Decimal either through GetBits or Memory casting will fail the IsValid() check (indicating it's not a Win32 DECIMAL.)
Since decimal128 and binary128 are standardized in the 2008 revision of the IEEE-754 format, this can lead to confusion when referring to decimal128 values (as System.Decimal is not an IEEE decimal float despite being a decimal floating point value.)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b24345d9-7aec-14ad-8c3c-56410267849a
Version Independent ID: f83555d8-9dac-5019-3345-bb0f03e1311d
Content: Floating-point numeric types - C# reference
Content Source: docs/csharp/language-reference/builtin-types/floating-point-numeric-types.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

ping @tannergooding for a recommendation on the best fix.


Add video options

Fixes #148

Once TypeDict is supported by RF core, then we could have even better type hint for width and height.

TypeDict could be added already now. It express the format better.
I was also thinking that is the cache good idea. It stores the video size, but at some point while doing it, it felt like an overkill.


HBASE-28928 Handle NPE in Split/Merge table when getMasterQuotaManage…

…r returns null (#6375)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 35s

branch-3 passed

+1 :green_heart:
compile
3m 41s

branch-3 passed

+1 :green_heart:
checkstyle
0m 49s

branch-3 passed

+1 :green_heart:
spotbugs
1m 54s

branch-3 passed

+1 :green_heart:
spotless
1m  0s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 57s

the patch passed

+1 :green_heart:
compile
3m 48s

the patch passed

+1 :green_heart:
javac
3m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 45s

the patch passed

+1 :green_heart:
spotbugs
2m  5s

the patch passed

+1 :green_heart:
hadoopcheck
13m 11s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 52s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

44m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6407/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6407

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux e1876888c1ea 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / d01856891f766313ec6c8c70b05b47e61c4b705d

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6407/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

-0 :warning:
yetus
0m  3s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-3 Compile Tests _

+1 :green_heart:
mvninstall
3m 37s

branch-3 passed

+1 :green_heart:
compile
1m  0s

branch-3 passed

+1 :green_heart:
javadoc
0m 36s

branch-3 passed

+1 :green_heart:
shadedjars
6m 19s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 11s

the patch passed

+1 :green_heart:
compile
0m 56s

the patch passed

+1 :green_heart:
javac
0m 56s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed

+1 :green_heart:
shadedjars
5m 37s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
216m 25s

hbase-server in the patch passed.

242m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6407/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6407

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 8605632c81fb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-3 / d01856891f766313ec6c8c70b05b47e61c4b705d

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6407/1/testReport/

Max. process+thread count
5082 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6407/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Duplicates https://github.com/apache/hbase/pull/6409


Small improvements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f6563b4) to head (1fa573c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #517   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          123       123
  Lines         3397      3397
  Branches       181       181
=========================================
  Hits          3397      3397

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: left and right homology data are dual notions

This PR shows that left and right homology data of short complexes are dual notions.

bors d+

bors r+


Increase the visibility of _external_host

Issue
It is not currently possible to forward _external_host as a "known" value back to TraefikRouteRequirer without calling private methods, making it unwieldy to inform TraefikRouteProviders what the external_host may be.
Solution
Make _external_host into external_host, and pass it as a constructor argument to TraefikRouteProvider
Context
See this grafana-k8s issue, for example.
Release Notes
Increase the visibility of _external_host, update traefik_route libraries

I went the other route primarily due to a debate on the team internally, which we'll probably have to settle out in person.
I'm happy to change the visibility back. I'm equally happy to leave it as it is. It's kind of a wash from my point of view, and you're the maintainer, so I'll leave it up to you. From my point of view, the somewhat obsession/cargo cult around making absolutely every method private, even if it can't change the data model at all (_external_host doesn't have any ability to actually set anything anywhere in the call tree) and doesn't expose any "internals" users shouldn't rely on (like _get_loadbalancer_status may) is something I shrug my shoulders about.
In practical terms, beyond the fact that nothing about external_host is confusing or exposing internals which may change regardless of visibility, I have an even weaker opinion on visibility on things inside implementations of CharmBase. They are not and cannot be used as libraries by anyone, and the worst side effect is more or less that users of vscode/pycharm/emacs/whatever who are writing self.charm.model.relations.... inside a library will see a single "public" method briefly.
It's developer experience, sure, but the visibility here only really applies to charm authors working on Traefik itself during development for completion dropdowns, and not "internal implementations" from psycopg or matplotlib or similar.
If you have a strong opinion about making it private, I'll change it back, otherwise I'd probably just leave it as is.

I went the other route primarily due to a debate on the team internally, which we'll probably have to settle out in person.

I don't disagree. for charms specifically there seems to be a tradition of making all methods private -- which as a charm is not supposed to be used by any other object makes sense, but is also not really necessary.
I was mostly wondering what was the reason for the change given that we went the other route.
No need to revert, thanks for the explanation.


Link for IoT Explorer

Consider linking the IoT Explorer to  https://github.com/Azure/azure-iot-explorer#azure-iot-explorer-preview

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b4df6937-2b4e-f394-dce3-e6b7059c64cf
Version Independent ID: 1395c0c4-a50a-f122-593a-adec4b50b393
Content: Learn about connection options for Azure IoT device developers
Content Source: articles/iot-develop/concepts-overview-connection-options.md
Service: iot-develop
GitHub Login: @timlt
Microsoft Alias: timlt

#assign:timlt
#label:"assigned-to-author"
#label:"doc-enhancement"
#label:"triaged"

Thank you for your feedback and interest in docs.  The link is updated per your request, the changed merged and should publish this afternoon or Monday.
#please-close


CASMINST-6127 Ensure installs fetch latest docs

Description

Ensure installations pull the latest docs, and from our desired endpoints.
Checklist

[ ] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[ ] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4

/backport main


Rename "Gamma" argument in timeevolution to "rates".

Coverage decreased (-0.02%) to 98.993% when pulling 613d61add7f75a9cbba448894699d680047a13c8 on rates into 2e11724900659b2a4c3b20952d37cf6fb4ba2ae9 on master.

Coverage decreased (-0.02%) to 98.993% when pulling 613d61add7f75a9cbba448894699d680047a13c8 on rates into 2e11724900659b2a4c3b20952d37cf6fb4ba2ae9 on master.


Increase Tracker slots

When you say "I can't give them all slots" what do you mean? That they don't all show up on the character sheet, or what?

There are only 4 slots available for a GM to create templates - 0, 1, 2, and 3.  You can create more than that for a given actor as per my image above but only the ones in created by the GM in slots 0, 1, 2, and 3 show up in the ADD.
It would also be ideal if the GM could create all the requisite trackers and then players can add them by copying them.  Also, I've had some difficulty clearly referencing the trackers in JS.  I'm not sure how to differentiate between names and numbers and actors when calling them - if there was some clear structure on how to do that it would be handy for building things like the Heroic Archer macro and turning it into other things more easily (that's a side request, but came to mind thinking about this).

Thank you :-)


Add user-agent to Azure AI requests

This is the same as upstream LangChain4j does and was requested my MS in order to be able to determine the use of LangChain4j

I was told it should be constant.


Use lane command instead of fastlane to run lanes

It's just a suggestion for enhancement.
Use lane instead/together with fastlane command to run lanes.
Like pod instead of cocoapods. Or brew instead of homebrew.
Sometimes I ended up to write accidentally lane in my terminal instead of fastlane.
Thanks. :smile:

Thanks for the feedback, but this will probably get confusing for users, as there are multiple ways of doing something.
cocoapods only works with pod, same for homebrew. It would be confusing to change this now.
Again, this feedback is very much appreciated :+1:

@KrauseFx No problem.


[BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute

[BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute
Global effort to fix build validation errors
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR was generated using DocuTune. It includes only build validation fixes and does not change other content.
DocuTune PRs improve quality of technical content by finding and automatically correcting a broad set of issues only where the correction is suitable. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!
CorrelationId: 0df9c2d6-63f8-4d1e-8b57-b33611a06514
InitiativeId: docutune-build-validation-issues-2022-05
PointOfContact: @MonicaRush

Docs Build status updates of commit b0589ea:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Links validated.
#docutune-ready

@alexbuckgit @jmart1428 Is this ready to merge?

@mikefrobbins
Please merge the changes in this PR. For more information, see the description at the top of this PR.
Any pre-existing build validation issues or insufficient Acrolinx scores should be addressed in a separate PR.
#docutune-request-approval


Custom month-name-format so we can show {month} - {year}

The only options we now have for the month-name-format is short or long, it would be nice if this could be a custom format so we can show the year in the header of the inline calendar.

You can customize the value with the month-overlay-value slot.


wholeBrainSeg_Large_UNEST_segmentation getting noise in the segmentation

When I use the wholeBrainSeg_Large_UNEST_segmentation model, I get noise in the segmentation. How can I resolve this issue?

Hi @anuragp2018 , I'm not sure if it's a monailabel issue or the bundle's own issue. Could you try to run inference directly and visualize the results to see if having the same issue?
If it does have, please post the reproduce steps here and then I can help to check that?
@tangy5 is the author of this bundle, maybe he can also give some suggestions here.


Failed to resolve FK constraint if reference is in on another schema

Describe the bug
I'm trying to init Prisma with an existing database. But I'm getting this error: Failed to resolve FK constraint  because the reference is in on another schema.
To Reproduce
$ prisma init
? Set up a new Prisma server or deploy to an existing server? Use existing database
? What kind of database do you want to deploy to? PostgreSQL
? Does your database contain existing data? Yes
? Enter database host erick.almeida.us-east-1.rds.amazonaws.com
? Enter database port 5432
? Enter database user erickalmeida
? Enter database password [hidden]
? Enter database name (the database includes the schema) karoo
? Use SSL? No
? Please select the schema you want to introspect public
Introspecting database public !
 ▸    Failed to resolve FK constraint usuario.idioma_fk -> idioma.id

    CONSTRAINT usuario_idioma_fk_fkey FOREIGN KEY (idioma_fk)
        REFERENCES i18n.idioma (id) MATCH SIMPLE
        ON UPDATE NO ACTION
        ON DELETE NO ACTION

Expected behavior
Introspection works fine
Versions (please complete the following information):
$ prisma --version
prisma/1.30.0 (linux-x64) node-v11.13.0

Prisma does not support multiple schemas yet in Postgres. I am tagging this as a feature request. The server would also need to implement this, fixing this just in introspection would be incomplete.

I have the exact same issue on an AWS Aurora DB. There's are multiple schema on the same DB. I would like to be able to include most of those Schemas in my introspect to be honest, and they reference each other in some instances.
It seems like this is a common issue for those of us that have huge-data sets.
No idea how to resolve this currently.
Prisma 1.34.3


Updated to ask the user for UAC if neccessary.

This script should work properly.

Thanks for the PR, much appreciated.


Fix for scenario with data-value="null" & no text content. Instead of "null", "Empty" is shown on UI.

When the editable HTML element has blank textContent, but has an attribute 'data-value' with the value "null", the UI shows the 'Empty' placeholder string.

Instead, the string "null" should be visible on UI.
This is occurring because the jQuery data() function used to retrieve the data attributes automatically converts the string "null" into a null value which gets ignored.
The fix involves instead using the HTML Element's 'dataset' property for retrieving the map of data attribute keys & values - all as strings.
JS Fiddles for checking:

Bug: https://jsfiddle.net/transopac/rej5w2w3/
Fix for Bug: https://jsfiddle.net/transopac/xhmsv7yb/

Similar to above fiddles showing bug/fix - BUT using the provided JS Fiddle template (didn't see this link earlier):
Bug: http://jsfiddle.net/transopac/xBB5x/14683/
Fix: http://jsfiddle.net/transopac/xBB5x/14684/

@MarQuisKnox : Please consider this pull request. Let me know if you need more information.

I've created a new pull request with the 'develop' branch.
https://github.com/vitalets/x-editable/pull/1047
This one was with 'dev' branch. Closing this.


Updates to Autoruns, Bginfo, Handle

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/autoruns.md
:white_check_mark:Succeeded
View

sysinternals/downloads/bginfo.md
:white_check_mark:Succeeded
View

sysinternals/downloads/handle.md
:white_check_mark:Succeeded
View

sysinternals/downloads/index.md
:white_check_mark:Succeeded
View

sysinternals/downloads/sysinternals-suite.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/autoruns.md
:white_check_mark:Succeeded
View

sysinternals/downloads/bginfo.md
:white_check_mark:Succeeded
View

sysinternals/downloads/handle.md
:white_check_mark:Succeeded
View

sysinternals/downloads/index.md
:white_check_mark:Succeeded
View

sysinternals/downloads/sysinternals-suite.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


angle grid interpolation

Grid interpolation currently does account for angles, meaning 5 and 355 degrees would interpolate to 180 instead of 0.

Resolved in release-2.0.0.  More robust determination of LUT angles added to apply_oe.py as well.


Missing Console Application reference sample/Instructions

[Enter feedback here]
in the opening statement of the article it says : The Generic Host can be used with other types of .NET applications, such as Console apps."
but no sample or instructions on how to use that generic host on Console Applicaiton is provided.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d43ecd7c-307a-688e-d533-c1135bde65f9
Version Independent ID: 22a12ff8-d2ff-a841-b9bb-e2fd1032bc04
Content: .NET Generic Host - .NET
Content Source: docs/core/extensions/generic-host.md
Product: dotnet-fundamentals
GitHub Login: @IEvangelist
Microsoft Alias: dapine

Hi @tshaiman - The Set up a host section shows a sample Console app. It uses top level statements, and this console app just so happens to register a Worker service.

that is correct, i missed that as I thought the  is a worker type application not console type .
you may close this ticket


Metal Heap Support

PR with mega heap implementation: https://github.com/alexcristici/maplibre-native/tree/mega-heap. For now we leave this out, no  performance gain.


chore: updates test badge

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.298%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
889

Relevant Lines:
979

💛  - Coveralls


Area of Square Python

Why:
Closes https://github.com/codinasion/codinasion/issues/365
Closes https://github.com/codinasion/codinasion/issues/359
What's being changed:

Added a Python program to find the area of square
Added a Python program to find the area of a rectangle

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Hey @harshi1122
Thanks for your contributions to this project 😃
This PR will be merged soon

Preview : https://codinasion--pr35-dev-q8lve0ih.web.app/programme/area-of-rectangle/
Preview : https://codinasion--pr35-dev-q8lve0ih.web.app/programme/area-of-square/
(expires Mon, 21 Mar 2022 09:08:07 GMT)


Github Actions workflows are not working

Workflows don't work due to lack of one or more project references in the solution file.

Added PR #21

Added PR #23 for the purpose of investigation

Fixed workflow issues in PR #23


Redacted membership event is mistaken as a join

Redacted avatar or display name change is displayed as a join in room history.
prev_content field is totally pruned by the server on redacted event. The server must keep membership for this sub dict (and prune only displayname, avatar_url...). Like it does for content dict.
We need to discuss this point with server team...

see SYN-724


Some pages donot have dynamic footer

Footer code can be removed as footer is defined in app.js dynamically.

Linos are incorrect change them too add correct links and before making a pr sent changes here.

Hi @anushbhatia , Kindly provide the correct links of girlScript-chennai social media.


Internal/update to avm1.0

[x] Update teal langspec to v5
[x] Add function to get app address
[x] Add code for getting ApplicationLogs
[x] Add tests for teal version5 and  application Address

@stefanomondino
Thanks for your review. Have made sure to fix all others apart from the builder syntax, its a popular syntax in a Java programs, i guess its not a swift thing, i will fix that in another PR since there are other files that have similar problem


[RFC] Used operators for properties when possible.

I'm not sure if it worsen readability, but if so, it still could be considered for properties that are used frequently, because operators works a bit faster.

IMHO unless this brings significant performance improvements on a hot path (not micro benchmarks of property access) I don't think it's worth the tradeoff in readability.

Same here. I'd like to see numbers which justify it.
operator module is primarily for functional programming support, I don't think it's suitable here.

If Python had a built-in operator that did property(attrgetter(...)) that could be useful to avoid the verbosity or maybe we'd have to add a helper to django.utils (found http://code.activestate.com/lists/python-list/113511/ in a quick search). Worth raising on django-developers, maybe. I don't feel comfortable merging the patch without a discussion.


RC 8 Iphone X 11.4 b3

Rc 8 Iphone x ios 11.4 b3
errno: 1
test: rv == 0
filename ViewController.m
Line: 1141
Function exploit
Description: Failed to platformize myself
stuck on step 7 still with latest update

This was fixed in version 1.0.3