pythonPackages.cassandra-driver broken

Describe the bug
pythonPackages.cassandra-driver fails with a missing dependency geomet.
To Reproduce
nix-repl> :b python37Packages.cassandra-driver
builder for '/nix/store/ylqn1g76azz8g1skmwmnbfwfg482bgkb-python3.7-cassandra-driver-3.23.0.drv' failed with exit code 1; last 10 log lines:
  adding 'cassandra_driver-3.23.0.dist-info/top_level.txt'
  adding 'cassandra_driver-3.23.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/cassandra-driver-3.23.0/dist /build/cassandra-driver-3.23.0
  Processing ./cassandra_driver-3.23.0-cp37-cp37m-linux_x86_64.whl
  ERROR: Could not find a version that satisfies the requirement geomet<0.2,>=0.1 (from cassandra-driver==3.23.0) (from versions: none)
  ERROR: No matching distribution found for geomet<0.2,>=0.1 (from cassandra-driver==3.23.0)
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/ylqn1g76azz8g1skmwmnbfwfg482bgkb-python3.7-cassandra-driver-3.23.0.drv' failed

Additional context
See failed job: https://hydra.nixos.org/build/123017346
Notify maintainers
@jonringer @costrouc

I'm working on a PR to fix.

@jonringer I nearly have the PR done, but it seems like the tests cannot be executed because they're deleted before the checkPhase:
  Finished executing pythonRemoveTestsDir
  running install tests
  ============================= test session starts ==============================
  platform linux -- Python 3.7.7, pytest-5.4.3, py-1.8.1, pluggy-0.13.1
  rootdir: /build/cassandra-driver-3.24.0
  collected 0 items

  ============================ no tests ran in 0.01s =============================
  ERROR: file not found: tests/unit

How do I handle this correctly?

@turion likely you're pulling from pypi, and upstream removes the tests before uploading the sdist. I would checkout the source from the source repo, and it should be fine.
If you can't, then you'll likely have to disable tests doCheck = false;

@jonringer, that's true, see https://github.com/NixOS/nixpkgs/pull/91662.

There is still an open PR working on this.

The PR in question is https://github.com/NixOS/nixpkgs/pull/100989

The PR in question is https://github.com/NixOS/nixpkgs/pull/100989


Release 1.7.0

This is a draft of changelog for the 1.7.0 release.
Here you can find all related translations changes: 1.6.1...master.

⚠ Do not merge this pull request manually ⚠
You should approve this pull request instead. After approving, I will automatically update it (release date needs to be adjusted), merge, and tag a new release. You can read more about the process on forum.

Show release notes preview
1.7.0

Menambahkan dukungan untuk ekstensi:

blomstra/usercard-stats
clarkwinkelmann/flarum-ext-post-permissions
justoverclock/flachat
justoverclock/imdb-api
justoverclock/user-pc-specs
miniflar/admin-notepad-widget
nearata/flarum-ext-auth-minecraft
swaggymacro/only-starter
vlssu/flarum-cravatar
webbinaro/gpx-preview
ziiven/flarum-fireworks

Terjemahan terbaru untuk ekstensi:

antoinefr/flarum-ext-money
askvortsov/flarum-auto-moderator
askvortsov/flarum-checklist
clarkwinkelmann/flarum-ext-likes-received
clarkwinkelmann/flarum-ext-mass-actions
datlechin/flarum-bbcode-hide-content
datlechin/flarum-discussion-overview
flarum/likes
flarum/mentions
fof/best-answer
fof/gamification
fof/reactions
fof/spamblock
ianm/gravatar
justoverclock/best-answer-badge
justoverclock/flarum-ext-guestengagement
justoverclock/job-cards
justoverclock/user-statistics
kilowhat/flarum-ext-rich-embeds
kyrne/evergreen
malago/flarum-achievements
miniflar/top-like-givers-widget
nearata/flarum-ext-dsts
the-turk/flarum-diff
wolfgang-demeter/flarum-ext-bbcode-5star-rating
ziiven/flarum-decoration-store

Semua perubahan: 1.6.1...1.7.0.

Success! Now you can announce new release on forum:
## Versi [`1.7.0`](https://github.com/flarum-lang/indonesian/releases/tag/1.7.0)

**Menambahkan dukungan untuk ekstensi**:

* [`blomstra/usercard-stats`](https://github.com/blomstra/flarum-ext-usercard-stats)
* [`clarkwinkelmann/flarum-ext-post-permissions`](https://github.com/clarkwinkelmann/flarum-ext-post-permissions)
* [`justoverclock/flachat`](https://github.com/justoverclockl/flachat)
* [`justoverclock/imdb-api`](https://extiverse.com/extension/justoverclock/imdb-api)
* [`justoverclock/user-pc-specs`](https://github.com/justoverclockl/user-pc-specs)
* [`miniflar/admin-notepad-widget`](https://github.com/miniflar/admin-notepad-widget)
* [`nearata/flarum-ext-auth-minecraft`](https://github.com/Nearata/flarum-ext-auth-minecraft)
* [`swaggymacro/only-starter`](https://github.com/SwaggyMacro/OnlyStarter)
* [`vlssu/flarum-cravatar`](https://github.com/vlssu/flarum-cravatar)
* [`webbinaro/gpx-preview`](https://github.com/eddiewebb/flarum-gpx-preview)
* [`ziiven/flarum-fireworks`](https://github.com/Ziiven/flarum-fireworks)

**Terjemahan terbaru untuk ekstensi**:

* [`antoinefr/flarum-ext-money`](https://github.com/AntoineFr/flarum-ext-money)
* [`askvortsov/flarum-auto-moderator`](https://github.com/askvortsov1/flarum-auto-moderator)
* [`askvortsov/flarum-checklist`](https://github.com/askvortsov1/flarum-checklist)
* [`clarkwinkelmann/flarum-ext-likes-received`](https://github.com/clarkwinkelmann/flarum-ext-likes-received)
* [`clarkwinkelmann/flarum-ext-mass-actions`](https://github.com/clarkwinkelmann/flarum-ext-mass-actions)
* [`datlechin/flarum-bbcode-hide-content`](https://github.com/datlechin/flarum-bbcode-hide-content)
* [`datlechin/flarum-discussion-overview`](https://github.com/datlechin/flarum-discussion-overview)
* [`flarum/likes`](https://github.com/flarum/likes)
* [`flarum/mentions`](https://github.com/flarum/mentions)
* [`fof/best-answer`](https://github.com/FriendsOfFlarum/best-answer)
* [`fof/gamification`](https://github.com/FriendsOfFlarum/gamification)
* [`fof/reactions`](https://github.com/FriendsOfFlarum/reactions)
* [`fof/spamblock`](https://github.com/FriendsOfFlarum/spamblock)
* [`ianm/gravatar`](https://github.com/imorland/gravatar)
* [`justoverclock/best-answer-badge`](https://github.com/justoverclockl/best-answer-badge)
* [`justoverclock/flarum-ext-guestengagement`](https://github.com/justoverclockl/flarum-ext-guestengagement)
* [`justoverclock/job-cards`](https://extiverse.com/extension/justoverclock/job-cards)
* [`justoverclock/user-statistics`](https://github.com/justoverclockl/user-statistics)
* [`kilowhat/flarum-ext-rich-embeds`](https://extiverse.com/extension/kilowhat/flarum-ext-rich-embeds)
* [`kyrne/evergreen`](https://github.com/KyrneDev/Evergreen)
* [`malago/flarum-achievements`](https://github.com/malago86/flarum-achievements)
* [`miniflar/top-like-givers-widget`](https://github.com/miniflar/top-like-givers-widget)
* [`nearata/flarum-ext-dsts`](https://github.com/Nearata/flarum-ext-dsts)
* [`the-turk/flarum-diff`](https://github.com/the-turk/flarum-diff)
* [`wolfgang-demeter/flarum-ext-bbcode-5star-rating`](https://github.com/wolfgang-demeter/flarum-ext-bbcode-5star-rating)
* [`ziiven/flarum-decoration-store`](https://extiverse.com/extension/ziiven/flarum-decoration-store)

Semua perubahan: [1.6.1...1.7.0](https://github.com/flarum-lang/indonesian/compare/1.6.1...1.7.0).

Untuk memperbarui, jalankan perintah ini:

```console
composer update flarum-lang/indonesian
php flarum cache:clear
```


Multi level image builds - only base image is cached

Behaviour
Not sure if I am doing it wrong, but I can't make specific images to be cached (if I use docker buildx bake locally, it caches everything properly), but using this action, it only caches my base image.
Steps to reproduce this issue
For example I tried:
      - name: Login to docker registry
        uses: docker/login-action@v2
        with:
          registry: ${{ env.REGISTRY }}
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}
      - name: Set up Docker Buildx
        uses<EMAIL_ADDRESS>      - name: Build and Push Projects
        uses<EMAIL_ADDRESS>        env:
          PROJECT_TAG: cmt-${{ github.sha }}
        with:
          # targets: "${{ needs.project_names.outputs.names_comma }}"
          targets: base,specific_image1,specific_image2
          push: true
          set: |
            base.cache-from=type=gha,scope=build-base
            base.cache-to=type=gha,scope=build-base,mode=max
            specific_image1.cache-from=type=gha,scope=build-specific_image1
            specific_image1.cache-to=type=gha,scope=build-specific_image1,mode=max
            specific_image2.cache-from=type=gha,scope=build-specific_image2
            specific_image2.cache-to=type=gha,scope=build-specific_image2,mode=max

I also tried specifying cache generically like:
      *.cache-from=type=gha
      *.cache-to=type=gha,mode=max

Expected behaviour
I would expect to cache all image built, not just base one.
Actual behaviour
Base image is cached, and specific image is always rebuilt even if nothing have changed.
Configuration
My bake file looks like this:
variable "BASE_TAG" {
  default = "16.0"
}
variable "PROJECT_TAG" {
  default = "16.0"
}

target "base" {
  dockerfile = "src/base/Dockerfile"
  contexts = {
    base-src = "src/base"
  }
  tags = ["ghcr.io/myorg/base:${BASE_TAG}"]
}

target "_all" {
  contexts = {
    base = "target:base",
    extra-src = "src/extra"
  }
}

target "specific_image_1" {
  inherits = ["_all"]
  contexts = {
    project-src = "src/projects/specific_image_1"
  }
  dockerfile = "${PROJECT_DOCKERFILE}"
  tags = ["ghcr.io/myorg/specific_image_1:${PROJECT_TAG}"]
}

Logs
In logs, part that is cached is actually coming from base image, not specific one.:
...
#24 [specific_image_1 stage-0  7/16] RUN python3 -m venv /opt/odoo/venv     && pip3 install --no-cache-dir pip-tools==6.13.0 wheel     && pip-compile-install /opt/odoo/requirements
#24 CACHED

#25 [specific_image_1 stage-0 15/16] COPY --from=monodoo-src --chown=odoo:odoo ./entrypoint.py entrypoint.py
#25 CACHED

#26 [specific_image_1 stage-0  4/16] COPY --from=monodoo-src --chown=odoo:odoo ./odoo/requirements.txt /opt/odoo/requirements/odoo-requirements.in
#26 CACHED

#27 [specific_image_1 stage-0 10/16] RUN pip3 install --no-cache-dir -e /opt/odoo/odoo     && pip3 install --no-cache-dir "/opt/odoo/bins/anthem-0.13.1.dev33+gcf73513-py2.py3-none-any.whl"
#27 CACHED

#28 [specific_image_1 stage-0 12/16] RUN pip3 install --no-cache-dir -e /opt/odoo/songs
#28 CACHED

#29 [specific_image_1 stage-0  8/16] COPY --from=monodoo-src --chown=odoo:odoo ./odoo /opt/odoo/odoo
#29 CACHED

#30 [specific_image_1 stage-0 14/16] COPY --chown=odoo:odoo ./pytest.ini /opt/odoo/pytest.ini
#30 CACHED

#31 [specific_image_1 stage-0  5/16] COPY --from=monodoo-src --chown=odoo:odoo ./requirements.txt /opt/odoo/requirements/requirements.in
#31 CACHED

#32 [specific_image_1 stage-0 16/16] COPY --from=monodoo-src --chown=odoo:odoo ./addons /opt/odoo/projects/monodoo
#32 sha256:287b999fa4f23b153628e0306124c5821df8499eed930d33db2fb0631cfcd35c 0B / 216B 0.2s
#32 ...
...

#35 [base] exporting to GitHub Actions Cache
#35 preparing build cache for export 2.6s done
#35 DONE 2.6s

#32 [base stage-0 16/16] COPY --from=base-src --chown=odoo:odoo ./addons /opt/odoo/projects/base
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 52.43MB / 314.72MB 6.0s
#32 extracting sha256:cf92e523b49ea3d1fae59f5f082437a5f96c244fda6697995920142ff31d59cf 1.7s done
#32 extracting sha256:89c0313aa29e2dd962db1c104533845c3b8a4417e3f9498ed0b277a5c8d96901 0.0s done
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 40.89MB / 140.09MB 5.4s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 49.28MB / 156.02MB 5.7s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 49.28MB / 140.09MB 6.2s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 57.67MB / 156.02MB 6.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 70.25MB / 314.72MB 7.7s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 56.62MB / 140.09MB 6.9s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 66.06MB / 156.02MB 7.4s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 65.01MB / 140.09MB 7.7s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 88.08MB / 314.72MB 9.3s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 73.40MB / 140.09MB 8.4s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 80.74MB / 140.09MB 9.2s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 89.13MB / 140.09MB 9.9s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 105.91MB / 314.72MB 11.0s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 74.45MB / 156.02MB 10.4s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 97.52MB / 140.09MB 10.7s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 82.84MB / 156.02MB 11.4s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 104.86MB / 140.09MB 11.4s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 122.68MB / 314.72MB 12.5s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 112.20MB / 140.09MB 12.0s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 92.27MB / 156.02MB 12.5s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 119.54MB / 140.09MB 12.8s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 140.51MB / 314.72MB 14.1s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 100.66MB / 156.02MB 13.5s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 127.93MB / 140.09MB 13.5s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 136.31MB / 140.09MB 14.3s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 109.05MB / 156.02MB 14.6s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 140.09MB / 140.09MB 14.7s done
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 158.33MB / 314.72MB 15.8s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 117.44MB / 156.02MB 15.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 175.11MB / 314.72MB 17.3s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 125.83MB / 156.02MB 16.5s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 134.22MB / 156.02MB 17.4s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 192.94MB / 314.72MB 18.9s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 142.61MB / 156.02MB 18.5s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 150.99MB / 156.02MB 19.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 210.76MB / 314.72MB 20.6s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 156.02MB / 156.02MB 20.0s done
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 228.59MB / 314.72MB 22.4s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 246.42MB / 314.72MB 24.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 264.24MB / 314.72MB 26.6s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 281.02MB / 314.72MB 28.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 297.80MB / 314.72MB 30.5s
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 314.72MB / 314.72MB 32.4s done
#32 extracting sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438
#32 extracting sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 11.5s done
#32 extracting sha256:bcdb739d5aef016392e512fa997b8d9d306e64497bbaaa60c3b98a2f778884c7 0.0s done
#32 DONE 44.6s

#32 [specific_image_1 stage-0 16/16] COPY --from=base-src --chown=odoo:odoo ./addons /opt/odoo/projects/base
#32 extracting sha256:161804423ce2990c2dbff86ee156e9a25c4b230934ff56f121be1506ff494762 0.0s done
#32 extracting sha256:c9285c82326f171fa758940fa64cc967cd87dac0d945976540eb67e911f66b10 0.0s done
#32 extracting sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710
#32 extracting sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 6.6s done
#32 extracting sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf
#32 extracting sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 17.3s done
#32 extracting sha256:3ae774462f6508dbc08f158ce375fa336d7d572b7bab20043ddabb7ce540b373 0.0s done
#32 extracting sha256:f906c05f9d6e04001861baa255081d8a36ff0e569f6d2b6799d16bf90b8ee58f 0.0s done
#32 extracting sha256:903c40a7931a03fd4d19722115d49b0e0080e91fdc280beb6056360452051f44 0.0s done
#32 DONE 68.6s

#32 [specific_image_1 stage-0 16/16] COPY --from=base-src --chown=odoo:odoo ./addons /opt/odoo/projects/base
#32 extracting sha256:fba3414c2be77074d36dff6a0128e4027a39049f2d1130795cd46e9e206066ea 0.0s done
#32 extracting sha256:154d71d26556a7378017cb7151f6f4644d27c9e4a27d8f25d5688f6ee62dbc69 0.0s done
#32 extracting sha256:32c43fb07e4e86e64922daf97eb8939eba6f39b47d0db3501b80ff8c6a6ce21e 0.0s done
#32 extracting sha256:287b999fa4f23b153628e0306124c5821df8499eed930d33db2fb0631cfcd35c 0.0s done
#32 extracting sha256:9c83cbfacf8c82b77a547c595566a6a9ea060ab0e635825e9fef63a117a38e61
#32 extracting sha256:9c83cbfacf8c82b77a547c595566a6a9ea060ab0e635825e9fef63a117a38e61 0.1s done
#32 DONE 68.8s

#36 [specific_image_1 stage-0 1/9] COPY --from=project-src --chown=odoo:odoo ./requirements.txt /opt/odoo/requirements/custom-requirements.in
#36 DONE 0.2s

#37 [specific_image_1 stage-0 2/9] COPY --from=extra-src --chown=odoo:odoo ./connector/requirements.txt /opt/odoo/requirements/connector-requirements.in
#37 DONE 0.0s

#38 [specific_image_1 stage-0 3/9] RUN pip-compile-install /opt/odoo/requirements
#0 0.145 + pip-compile-install /opt/odoo/requirements
#38 43.66 #
#38 43.66 # This file is autogenerated by pip-compile with Python 3.10
#38 43.66 # by the following command:
#38 43.66 #
#38 43.66 #    pip-compile --output-file=/opt/odoo/requirements/requirements.txt --resolver=backtracking /opt/odoo/requirements/connector-requirements.in /opt/odoo/requirements/custom-requirements.in /opt/odoo/requirements/odoo-requirements.in /opt/odoo/requirements/requirements.in
#38 43.66 #

Whats interesting, looks like last COPY of base image is not cachhed (not sure why):
#30 [specific_image_1 stage-0 14/16] COPY --chown=odoo:odoo ./pytest.ini /opt/odoo/pytest.ini
#30 CACHED

#31 [specific_image_1 stage-0  5/16] COPY --from=monodoo-src --chown=odoo:odoo ./requirements.txt /opt/odoo/requirements/requirements.in
#31 CACHED

#32 [specific_image_1 stage-0 16/16] COPY --from=monodoo-src --chown=odoo:odoo ./addons /opt/odoo/projects/monodoo
#32 sha256:287b999fa4f23b153628e0306124c5821df8499eed930d33db2fb0631cfcd35c 0B / 216B 0.2s
#32 ...

It just copies source code, but maybe its not supposed to be cached?

It's actually cached:
#32 [base stage-0 16/16] COPY --from=base-src --chown=odoo:odoo ./addons /opt/odoo/projects/base
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 52.43MB / 314.72MB 6.0s
#32 extracting sha256:cf92e523b49ea3d1fae59f5f082437a5f96c244fda6697995920142ff31d59cf 1.7s done
#32 extracting sha256:89c0313aa29e2dd962db1c104533845c3b8a4417e3f9498ed0b277a5c8d96901 0.0s done
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 40.89MB / 140.09MB 5.4s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 49.28MB / 156.02MB 5.7s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 49.28MB / 140.09MB 6.2s

#32 extracting and logs like sha256:... 52.43MB / 314.72MB 6.0s means it downloads and extract the cache.
This is similar to https://github.com/docker/build-push-action/issues/766#issuecomment-1410923699

It's actually cached:
#32 [base stage-0 16/16] COPY --from=base-src --chown=odoo:odoo ./addons /opt/odoo/projects/base
#32 sha256:16fd52525449f870f1ec2d0096b352bae611ff3876a7e733950c4628813f3438 52.43MB / 314.72MB 6.0s
#32 extracting sha256:cf92e523b49ea3d1fae59f5f082437a5f96c244fda6697995920142ff31d59cf 1.7s done
#32 extracting sha256:89c0313aa29e2dd962db1c104533845c3b8a4417e3f9498ed0b277a5c8d96901 0.0s done
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 40.89MB / 140.09MB 5.4s
#32 sha256:f9b1fff5a0fb46796fbac4bda595f1590813ae6302b13dd025fc40eac739afbf 49.28MB / 156.02MB 5.7s
#32 sha256:834c5693942525652d5952da9f7578d39838d6f94c63c52e729328f5615d9710 49.28MB / 140.09MB 6.2s

#32 extracting and logs like sha256:... 52.43MB / 314.72MB 6.0s means it downloads and extracts the cache.
This is similar to docker/build-push-action#766 (comment)

So then its not related. Though still not sure why specific images are not cached, when running same thing directly with bake, caches everything.

running into this as well here https://github.com/dotabod/backend/blob/master/docker-compose.yml
it only caches the first base image, stops caching after yarn install, and it keeps pushing new images to ghcr even though all the layers are the exact same. i can run teh workflow twice and i'll get two new pushes to the registry
i'm expecting only 1 push in that scenario. why is this happening @crazy-max ? you can see the job logs here https://github.com/dotabod/backend/actions/runs/7292673115/job/19874180120

i fixed my issue by adding ghcr registry cache-from/to

Is this related to and fix by doing this?
https://github.com/docker/build-push-action/issues/286#issuecomment-893176504


feat: argocd notifications

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[KYUUBI #4623][K8S] KubernetesApplicationOperation use Informer instead of list

Why are the changes needed?

Close #4623
To reduce the pressure on the Api Server (which use the kubernetes client polls with label to find the spark driver pod when multiple Rest Application are running at the same time), use informer, the kubernetes-recommended method of maintaining the application state.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

[x] Run CI

Codecov Report

Merging #4625 (f43bba2) into master (6d8fe6c) will increase coverage by 0.01%.
The diff coverage is 34.09%.

@@             Coverage Diff              @@
##             master    #4625      +/-   ##
============================================
+ Coverage     53.33%   53.34%   +0.01%
  Complexity       13       13
============================================
  Files           577      577
  Lines         31603    31652      +49
  Branches       4252     4258       +6
============================================
+ Hits          16854    16884      +30
- Misses        13161    13174      +13
- Partials       1588     1594       +6

Impacted Files
Coverage Δ

...rg/apache/kyuubi/engine/ApplicationOperation.scala
66.66% <20.00%> (-8.34%)
:arrow_down:

...kyuubi/engine/KubernetesApplicationOperation.scala
28.07% <26.76%> (+9.77%)
:arrow_up:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.10% <83.33%> (-0.11%)
:arrow_down:

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fix On Kubernetes IT Test, ready for review @pan3793

Thanks, merged to master/1.7


Multiple recompositions of ExposedDropdownMenuBox while scrolling

Describe the bug
Multiple recompositions of ExposedDropdownMenuBox while scrolling. Tested on LazyColumn
Affected platforms
Select one of the platforms below:

Desktop

Versions

Kotlin version*: 1.9.22
Compose Multiplatform version*: 1.6.0-rc03
OS version(s)* (required for Desktop and iOS issues): win11
OS architecture (x86 or arm64): x64
JDK (for desktop issues): jdk20

To Reproduce
run the code below, scroll up and down:

import androidx.compose.foundation.border
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.ExposedDropdownMenuBox
import androidx.compose.material3.ExposedDropdownMenuDefaults
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun LazyColumnExposedDropdownMenuBoxMultipleRecompositionsBug() {
	var menuOpen by remember { mutableStateOf(false) }
	LazyColumn {
		item {
			println("exposeddropdownmenubox item recomposed")
			ExposedDropdownMenuBox(
				expanded = menuOpen,
				onExpandedChange = { menuOpen = it },
				content = {
					println("exposeddropdownmenubox recomposed")
					OutlinedTextField(
						value = "default",
						onValueChange = {},
						modifier = Modifier
							.fillMaxWidth()
							.menuAnchor(),
						readOnly = true,
						trailingIcon = { ExposedDropdownMenuDefaults.TrailingIcon(expanded = menuOpen) },
					)
					ExposedDropdownMenu(
						expanded = menuOpen,
						onDismissRequest = { menuOpen = false },
						modifier = Modifier.exposedDropdownSize(),
						content = {
							repeat(10) {
								DropdownMenuItem(
									onClick = { menuOpen = false },
									text = { Text(it.toString()) }
								)
							}
						}
					)
				}
			)
		}

		item {
			println("big text item recomposed")
			Text("big text", modifier = Modifier.fillMaxWidth().height(800.dp).border(1.dp, Color.Red))
		}
	}
}

Expected behavior
same as in android - no redundant recompositions
Additional context
in android scrolled once down and once up

exposeddropdownmenubox item recomposed
exposeddropdownmenubox recomposed
big text item recomposed
exposeddropdownmenubox item recomposed
exposeddropdownmenubox recomposed

in windows scrolled once down and once up

exposeddropdownmenubox item recomposed
exposeddropdownmenubox recomposed
big text item recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox item recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed
exposeddropdownmenubox recomposed

maybe anyone with windows can confirm. I found out if you remove .menuAnchor() there are no recompositions but also cant open the dropdownmenu.

Reproduced on Windows.
The difference between macOs and Windows, that Windows enables smooth mouse scrolling.
If it is disabled, the issue isn't reproducible:
System.setProperty("compose.scrolling.smooth.enabled", "false")

@Zenturas Why do you expect recompositions to not occur here? As you scroll down, the first item of the LazyColumn goes out of the view and is removed from the composition. When you scroll back up, the item enters the composition again and is (re)composed.
The same thing happens in Android:
https://github.com/JetBrains/compose-multiplatform/assets/5230206/e7d2cb88-11cb-44ac-9288-fdd27af14bae

Ah, I see. It should recompose only once after re-entering the composition.

This was fixed in Android in 25d25eee042cd15f858180e6d4b592b2c95add7c

https://issuetracker.google.com/issues/256905251

@igordmn Unfortunately, the issue persists for me even with System.setProperty("compose.scrolling.smooth.enabled", "false") set.
@m-sasha Shouldn't 1.2.0-alpha05 already be integrated in version rc03 because it supports version 1.2.0?

Shouldn't 1.2.0-alpha05 already be integrated in version rc03 because it supports version 1.2.0?

No, that commit isn't merged into our latest release.

@igordmn I can try cherry-picking that commit if you think it's urgent, or we can wait for the next upstream merge.

Is there a way to find out up to  which update has been fully merged?

It turns out the committee was merged, but it only fixed the Android implementation. I've submitted a PR to fix this on the multiplatform side.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


SAK-40432 Modify GradebookNG to handle negative scores

Although GradebookNG won't let you enter a negative grade, they can find their way in via external tools (like Samigo) in the form of grade overrides.  Gradebook Classic shows these scores, whereas GradebookNG would throw a JS exception.  Modify GradebookNG to handle this case.
When this happens, the negative cell will be highlighted with a warning message, as it's quite likely that the negative score wasn't really intended to be there.

LGTM thanks


Login UX

Issue to cover the discussion and development of UX around Login (https://github.com/strimzi/proposals/blob/master/010-ui-and-admin-server-security.md)

For no security or Oauth based flows no screen will need to be presented as it will be handled externally/not needed. However, some UX to confirm this may be worth exploring
For Scram based logins, a username and password (with error states)

As a part of the discussion, the defintion of a set of Gherkin based behaviours should be identified, which will be used as the base for acceptance testing.
This discussion may also identify other UI components required to enable these flows. These should be discussed/designed in their own issues.

One point mentioned by @pmuir in today's sync: In the case of an oauth flow, a redirect will occur to the Oauth login page, and once complete, the user would be redirected back. Worth capturing in any behavioural write ups

Some quick thoughts about the "default" option I'd probably expect us to run with.
Examples included of basic client-side error (someone hits "Log in" before completing both fields) and server side error (invalid username or password).

I'm not clear whether there is a use-case for the "Log in with Oauth" link I've included yet - presumably if Oauth is the correct method, we'll always successfully redirect users on log-in, however, I know it's a common pattern to offer alternative log in methods on a log in page and have included it for discussion purposes.
Note that these designs are subject to change and are here to provoke conversation & make sure we get the experience right.

Some quick thoughts about the "default" option I'd probably expect us to run with.
Examples included of basic client-side error (someone hits "Log in" before completing both fields) and server side error (invalid username or password).

I'm not clear whether there is a use-case for the "Log in with Oauth" link I've included yet - presumably if Oauth is the correct method, we'll always successfully redirect users on log-in, however, I know it's a common pattern to offer alternative log in methods on a log in page and have included it for discussion purposes.
Note that these designs are subject to change and are here to provoke conversation & make sure we get the experience right.

Looks good, thanks @chloepoulterdesign ! Re the login with OAuth - I imagine you would only ever see this login page if credentials need to be provided by the user (ie the Scram case). The authentication mechanism used is not a choice the user makes - it is whoever deploys the UI in Strimzi's. Thus, I don't think there should be a link here at all.
That isnt to say however as a part of the UI processing the login we mention 'redirecting to OAuth provider'/' logged in via OAuth' or similar somehere, if that enhances/improves the UX.

PF Login page designs:
Default

I've kept some additional functionality in these designs to see if any can/should be added. Specifically curious about the ability to stay logged in, log in via social sign-in methods, and to create an account/signup.

On submit

Client Side Error

Server Side Error

Very snazzy @lboehling .
I'll let the devs answer your questions on social, staying logged in, and create account. I suspect you can't do any of these with the SCRAM method, and when logged in via keycloak, that would all be handled on their UI?
The only updates at my end are removal of the Oauth option and I am 90% sure the recommended carbon loading state for a momentary (less than 3 second) loading state would be an inline loading state, which I've included.

To give an idea of snazzier options we could go down via carbon, you can also view the Carbon Login pattern - however I feel that they're kind of overkill for what is needed here. Plus, the pattern used here is one I'm familiar with.

I've just heard we'll need original illustration/imagery for the log in page. I'm chasing it up and will have something sorted asap.

Thanks both, these look great!

* I've kept some additional functionality in these designs to see if any can/should be added. Specifically curious about the ability to stay logged in, log in via social sign-in methods, and to create an account/signup.

We will be authenticating with Kafka (scram), or something configured by the user (eg KeyCloak) when deploying their cluster to handle the authentication (OAuth). I know a bunch of social sites offer OAuth options, but I have no idea if any could be then used (and work) with Strimzi (nor would anyone actually try). It may be possible, but I would suggest that we return to those options at a later stage.
I would also suggest allowing a user to sign up/trigger a password reset through the login page is the responsibility of the provider of the authentication - ie KeyCloak etc.

Keycloak supports social login, identity federation etc. so if you configure oauth login then you should get social login if you configure it correctly in Keycloak. Those screens are provided by keycloak.

@lboehling If you are using Scram then social login won't be possible - you need to use oauth for that.
We could create users and allow managing users via the UI for SCRAM but I think we can defer that for a long time - if you want that kind of functionality you should use oauth/keycloak.
For now you would use the Strimzi CLI https://strimzi.io/docs/0.12.1/#assembly-getting-started-user-operator-str
Staying logged in is really an attribute of the session length we decide to offer and something we could make configurable. However a shorter session is better for security.
Note that if you are using keycloak then our session length is somewhat irrelevant, this is up to keycloak.

@lboehling I think we are good to go on this one. Do you agree?


Image placeholders are broken with Sketch 47

Image placeholders aren't getting updated or replaced with images at all.
Plus they are causing other placeholders to break.
I tested this with one of your demo presets.

Having to keep two versions of Sketch on my machine to manage this. Would love a fix here.

Looks like image placeholders are not getting updated due to this method that has been deprecated in Sketch 47
return MSImageData.alloc().initWithImage_convertColorSpace(image, false);
Replacing it with the following seems to fix the issue
return MSImageData.alloc().initWithImage(image)

@johndilworth It works!  Thank You!

@paulwan How can I fix it myself in my local installation?
Editing src/library/data.js doesn't seem to fix it.

@rhawbert what‘s your sketch version? I was change the code by johndilworth's method (sketch v47.1), it works.

@paulwan latest (v47.1)... I've also tried to edit the line 4935 on "...Plugin-folder/Sketch Data Populator.sketchplugin/Contents/Sketch/plugin.js" but it is still throwing the error "Some images could not be loaded. Please check the URLs"

Problem sorted, just wanted to share it here... my colleague found out that nsurl only accepts secure (https) URLs.

@johndilworth Thanks!! This fixed the image issue. However, Nested symbols are still not getting populated with the correct JSON values, all are just getting populated with the first item. I even tried the demo file and it's not working
Is this an issue for others?

@johndilworth Yes, thank you! It really works.

In the sketch document I'm working on Data Populator stopped working at all if there's any image in the group I'm trying to populate. My URLs are https.

does v2.2.1 work for you all?

v2.2.1 worked for me, but getting it required an uninstall / reinstall. The "update plugins" process didn't update to v2.2.1. In case this helps someone.

Help me out please, where do I get v 2.2.1 and where do I find the files to change as listed above Im not sure what file to look at.
Thanks

I'm using 2.2.1 and symbol overrides aren't working if an image is included in the symbol (if there's no image in the symbol, overrides work as expected). I tried swapping out these bits to no effect:
// Replaced this deprecated method to no effect
// return MSImageData.alloc().initWithImage_convertColorSpace(image, false);

return MSImageData.alloc().initWithImage(image);

@johndilworth This worked! Thank you. If I get free time I'll see about making a PR unless you'd like to do the honors ;)
I'm having the same issue as lpredster though, nested symbols only get updated when I rerun data populator over them. At least I can still do that but what a pain.
@andyra That fix worked for me with sketch 48.1 could you be using an old version of sketch?

@evandeininger Yes, I'm using Sketch 48.1. To be clear, here's what I'm experiencing both before and after the suggested fix above:

Library symbol with image: no overrides update
Detached library symbol with image: text overrides update, image overrides don't
Library symbol, no image: works as expected

hey, something’s broken in 48 and we’ll ty to fix it soon. it seems it’s again a general issue with image placeholders, not just symbol overrides.
thanks for using the plugin and providing your feedback!

this should fix the issues with 48:
https://github.com/preciousforever/sketch-data-populator/releases/tag/v2.2.2

@nitrada, everything is working as expected with the latest update. Thanks!
By the by: this is the most useful plugin I use and I can't imagine working without it. Keep up the good work!

@andyra great to hear this! :)
btw, from v2.2.2 on, the internal sketch update mechanism will work for data populator.

hey all, please check out v2.3.1 – we optimized the way you manage your preset library and the plugin bundle now doesn't contain any images anymore, making internal updates much faster.
would be great to hear if it works well for you!
https://github.com/preciousforever/sketch-data-populator/releases/tag/v2.3.1


cmake: 3.24.3 -> 3.25.2

Description of changes
Bump cmake and regenerate 002-application-services.diff because it could no longer be applied cleanly.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

It looks like this update has already been addressed #215366

Good catch! Apologies for not seeing that one.


Trigger requires db_owner

Currently the trigger requires the login is a member of dbo schema or db_owner role per https://learn.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-getapplock-transact-sql?view=sql-server-ver16#arguments
We should look into what the exact requirements are around this and :

Document it clearly in the trigger required permissions section
Possibly add a way for customers to override with their own specified role

Turns out it just requires VIEW CHANGE TABLE permission. I'll be writing docs for all the permissions as part of https://github.com/Azure/azure-functions-sql-extension/issues/608


JSON Error and no such file or directory

I'm having an issue when trying to run npx elm-coverage -v src/elm in my Elm 0.19.1 project. The output ends with:
[12:44:40.01] Ruh roh, tests failed.
[12:44:40.01] Something went wrong:
Error: Received invalid JSON from test interface search: SyntaxError: Unexpected token e in JSON at position 0

If I use the -f flag, I get:
[12:31:19.08] Something went wrong:
Error: ENOENT: no such file or directory, scandir '.coverage/instrumented/elm-stuff/generated-code/elm-explorations/test'

I have this block in my elm.json, if it matters:
"test-dependencies": {
    "direct": {
        "elm-explorations/test": "1.2.1"
    },
    "indirect": {}
}

Any ideas? Running elm-test on its own works fine.
Elm: 0.19.1
Elm-Test: 0.19.1
NodeJS: 10.15.3

Have the same problem using 0.19.1.

Fixed in https://github.com/zwilias/elm-coverage/commit/d594f6c4f916076ea3c2deea7cabb50348d1d11b and released as 0.3.0! 🚀


feat(FormattingPatterns): add timestamp

Please describe the changes this PR makes and why it should be merged:
Timezone formatted timestamps!!!!! (but the regex matches)
Reference Discord API Docs PRs or commits:
https://github.com/discord/discord-api-docs/pull/3135

Discord calls them flags: docs

style would probably be a better name, feel free to change the docs lol


Add a module to handle getups and falling using the Director

This PR adds a module to handle getups
Since Odometry has not always proven the most reliable this is instead using raw sensors with a simple exponential filter and a slightly different method for working out falling and when to get up
Since I can't test this I have no idea if it works!

This PR has been superseded by a few others that break up this module into 4 others (GetUp skill, GetUpPlanner FallingRelaxPlanner and RecoveryStrategy)


Add astrometry example

For example: this system has public data.

@iancze and I have been chatting offline and we're hoping to work on this. Here are some open questions from Ian:

coordinate convention about the ascending node: is it the one receeding from the observer or approaching the observer? My personal preference is that of the visual binary field, discussed in the document I linked. It yields to a consistent right hand rule system. The choice of the exoplanet field seems to be to use the opposite convention (perhaps more common in planetary science), though this may just be from following Murray and Correia. I can defer to whatever you think makes most sense, but the inconsistencies within the exoplanet field are what drove me to write that document in the first place.

format of data. Usually this would be measurement of the secondary relative to the primary as separation and position angle, but maybe other people have more exotic formats. For hierarchical systems, say C orbits a tighter binary A-B, the formats I have usually seen are B relative to A and C relative to A, OR C relative to the photocenter of AB. Other types of measurements could exist.

properly generalizing the orbits to hierarchical systems. Perhaps you might have already solved this organizational problem with the RV orbits.

I haven't solved any of these problems and I don't have enough experience to have strong opinions (yet!).
There's an implementation of this in: https://github.com/iancze/PSOAP/blob/master/psoap/orbit_astrometry.py
@iancze: want to post your overleaf doc here too? Or some other copy of your notes?

Sure thing. Here are some notes for an internally consistent convention (following the visual binary field) that I've been using for my work: https://v2.overleaf.com/read/wszkgttktyvg
The inconsistencies I think I noted were the swapping of a negative sign in the equation for radial velocity v_r and v_z in the Murray and Correia notes, or at least, my misunderstanding of something related to that.
There are also a number of other systems I've seen that don't conform to the right-hand rule. I think we might want to stay away from those.

Just a note that I have made some progress to this on a fork of the repo, e.g., https://github.com/iancze/exoplanet/blob/master/docs/notebooks/astrometric.ipynb
I'll work on flushing out the functionality and tutorial before thinking about how to put together a proper a pull request.

Some changes to KeplerianOrbit to include astrometry

[ ] change t_ref to t_periastron, let t0 be time of transit (time of minimum impact parameter if non-transiting). Add both to __init__, then add logic to ensure user only specifies one at a time.
[ ] add Omega to KeplerianOrbit. Tinker with rotate_vector to include position angle rotation.
[ ] get_consistent_inputs needs to have logic to sort out astrometric parameters. Possible include kappa to the __init__ values. Then modify consistent_inputs to return m_planet values. Either compute kappa from m_planet OR compute m_planet from kappa.

After our work on this today, I think we finally have a working implementation for astrometric orbits over at https://github.com/iancze/exoplanet/blob/keplerian-astrometric/docs/notebooks/astrometric.ipynb, which converges when using the xo.PyMC3Sampler to tune.
The changes to orbits/keplerian.py are probably ready to merge, although I should write some tests to be sure. My next step is to round out the tutorial with notes on how to do a joint RV + astrometric fit.


Change default selectOnFocus behavior in Select

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
N/A Reviewed and tested on Mobile, or determined not required.
N/A Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

I like this one alot, in theory.  @haynesjm42  -- do you feel so strongly that this is always what you need, to the degree that we should change the default?   Sometimes aren't you just further drilling down?
You pretty often want it in a TextField as well, but we did not make it the default.  Don't feel strongly here....

Just tried this out and works great. To @lbwexler's point about whether this should be on all the time, I'm not 100% sure, I could go either way.  Might make sense for this to be off by default, as it was selects with very large option lists where you rarely scroll through the list which prompted the ticket, pretty easy to know if you want this enable and the auto-selection of the text could get distracting on selects with smaller option lists.

@haynesjm42 If you want to enable this on a case-by-case basis, I think it would make more sense to just use the existing selectOnFocus prop. This ticket is changing the default. If you're happy with an opt-in behavior, that is already available.

Ok I am going back to my original stance here, if you are setting up a select which you can filter, then you are expecting there to be enough options in the list that the user would want to be able to narrow it down by typing in the input. Same with allowing create I think. I like this as default behavior, but will leave it to others to make the final call.

I like this change and agree it's a better default for when the control is setup for the user to type in input.
It might have the positive side-effect of encouraging users to turn off filter mode for small select lists where they just want users to choose an existing option. I try to remember to do that, as I think having the interactive cursor in those small lookups is non-ideal.

Thanks for this peter, and thanks for the strong advocacy john :-)


Question: navigate to conflicting item/item causing error?

Hi,
I'm quite frequently facing an issue where I get an error in a file, but the real cause is in a different file and I can't find a way to navigate from one to another.
Example of such error is "Static declaration of 'XYZ' follows non-static declaration (clang static_non_static)".
It's cool that it points out this error, but it'd be even cooler if one could jump from this error to the other (conflicting) place.
Clang(d) obviously knows about the conflicting place:

In file included from /home/ksekera/x.c:1:
/home/ksekera/x.h:296:1: error: static declaration of 'find_tag' follows non-static declaration
find_tag (uint32_t *val)
^
/home/ksekera/y.h:103:5: note: previous declaration is here
int find_tag(uint32_t *);
^

It's not a problem if it's within the same file, but if it's in a different file I couldn't find any coc-* method to do that.
Does such a method exist?
Thanks!

could jump from this error to the other (conflicting) place

This needs clangd to provide location of conflicting in some way, coc.nvim/coc-clangd is LSP client, it jumps to the location provided by LS.

@fannheyward for clang notes like this, clangd should be providing the location as relatedInformation on the diagnostic.
(I haven't verified it does so in this specific case)

providing the location as relatedInformation on the diagnostic.

@klement you can enable diagnostic.separateRelatedInformationAsDiagnostics to list relatedInformations as diagnostics

Thanks! that's perfect!


refactor: refactor useNFTDrawerTabs.tsx and index.tsx

PR-Codex overview
The focus of this PR is to optimize imports and update dependencies.
Detailed summary

Updated import statements for erc1155 functions
Removed unused import for getChainBySlug
Refactored logic for switching chains based on chain ID

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

📝 Changed routes:

/[chainSlug]

(view full size)

Commit fea594cc5da471125034eabdfdec81b5ba9095ba (https://thirdweb-es8wy8il8.thirdweb-preview.com).


Crashes on some videos

The Issue
The app crashes on some videos. Crashes seem to happen at some particular moments within the video.  When downloaded via web app and played locally with exoplayer-based video player, the videos that cause the crashes in this app play normally.  The crashes seem to happen after a fixed period of video beeing open, regardless of the position in the video.
Steps to reproduce

Try playing this video.

Expected behaviour
The video plays uninterrupted.
Actual behaviour
The app crashes in approximately 5 seconds of playback.
System Configuration

Device: Xiaomi Redmi Note 8 Pro
Android version: 12 (CrDroid 8.4)

Anything Else
Seems to happen with particular videos only. That is, after reinstalling the app the same video consistently crashes while most videos are fine.
Captured trace: https://paste.crdroid.net/XxEPJA
Internal Use
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

Thanks for the logcat, @czarkoff


feat!: major refactors to internal data structures

I like the duality of LocalPackage and RemotePackage, sure.


multiple  messages appear when we compare the  product

Bagisto Version

[ ] master branch

Steps To Reproduce
1 go to frond end
2. try to compare the any  product
Actual Result

This is not a bug, you clicked multiple times for each request then it gave the message. If you clicked a single time and got all these messages then it's a bug.


Contracts for System.Reflection.CustomAttributeExtensions

This adds contracts for the System.Reflection.CustomAttributeExtensions class, which is new in .NET framework 4.5.

I had one question in the diff but overall :+1:

:shipit:

Ьукпувю


Display a message when no package is found

I'm not sure what would be the best wording, but a message along the lines of "No package found matching <searched word>" would be nice; currently the website doesn't display anything when there's no packages found:

Good idea!


Contribute symbols to ToC

References
This is an exploration for #556
Limitations:

does not replace default ToC sources for python/markdown/latex - changes upstream needed
only for files for now, again, we would need to have a way to add a second section in ToC

An argument against merging it for 5.0 is that the code is so minimal (after removing fluff) that maybe we could just contribute it upstream directly? Something to talk about on the dev meeting.
CC @fcollonval
Code changes
Adds new plugin
User-facing changes

Backwards-incompatible changes
None

:+1: to get this upstreamed

What do you mean by add a second section in ToC?
You would like to get two tree views; one from LSP symbols and one from (?). Why not using only one; for file editor I don't see what would be the difference between the poor existing one and the one coming from LSP symbols. The existing ones could be kept as fallback if no LSP server can provide symbols.

What do you mean by add a second section in ToC?

Something like LibreOffice having "Headings" and "Tables":

For us, in context of Notebook this would be "Headings" and "Code Symbols". I would think this could be implemented using collapsible panels like the debugger/extension manager sections. Does it make sense?

For us, in context of Notebook this would be "Headings" and "Code Symbols". I would think this could be implemented using collapsible panels like the debugger/extension manager sections. Does it make sense?

Yes thanks a lot for the snapshot.


Update to GLFW 4.3

This is a reminder for myself to update to OpenGl 4.3 so that I can use compute shaders for world generation.

I have just learned that apple, in their infinite wisdom, stopped supporting OpenGL back in 2010 with OpenGL 4.1 so I cannot get OpenGL 4.3 on my school macbook and cannot use compute shaders. Even though being excited about compute shaders was the whole motivation for this entire project.

This makes me very sad.


[proposal] Reducing number of map objects loaded in ID

OSM map grew a lot. In areas I work on number of objects is expanding on exponential basis.
ID editor cannot handle that any more. It slows down tremendously.
I tried using Map Features option to reduce number of objects on map but it does not help. I found out that Map Feature just reduces number of displayed objects but they are all loaded in memory anyways.
It is also hard to work in ID because too many objects are displayed and everything is clogged on the map.
There are four things that could be done:

Changing way how ID loads data from OSM database. It should load only objects that are necessary / generally those that are going to be actually displayed.

Having more granulated options for user to select which objects to display and which not. Map Feature is to broad and does not provide tool for user to remove objects he does not need, and keep those that he does need.

For example, option Points (of Interests) is not selective. User can either remove all points of interests or none of them. there is no option to select some points of interests. Same goes with other options offered within Map Features.
Maybe new option could be introduced for user to provide some kind of filtering rules like ones used in overpass-turbo. That would let user to very specifically choose type of objects he wants to be loaded.

It would be good for users to have option to set ID not to update objects on the map automatically, but only on demand. That would help a lot. Now, even slightest move of the map causes reload of the objects which is painfully slow.

User could have an option to work like on JOSM - get some data, work on it, and then get some more when he decides he needs it. That would reduce number of map data reloads and would really speed up things especially for situations that user does not have to edit locations, but just editing tags of already existing objects.

Changing way how ID loads data from OSM database. It should load only objects that are necessary / generally those that are going to be actually displayed.

Choosing the features to display in the editor is always a tradeoff of performance over safety, regardless of the editor or API endpoint. It’s already the case that, due to enabled filters, sometimes iD and JOSM users unknowingly perform edits that semantically conflict with existing data (even if from there’s no conflict a purely data model standpoint). iD has some mechanisms to avoid the semantic conflicts, such as disallowing splits of features connected to hidden features. But increased customizability in this regard would probably overwhelm those safety measures, so such an enhancement would require considerable thought.

For example, option Points (of Interests) is not selective. User can either remove all points of interests or none of them. there is no option to select some points of interests. Same goes with other options offered within Map Features.

Maybe there could be subfilters under “Points of interest” for common categories of POIs. Selecting some of those subfilters but not others would put “Points of interest” in a mixed selection state. This improvement could probably happen even with the current implementation, improving map/UI rendering performance in dense areas without necessarily dealing with the bandwidth or memory concerns.

It would be good for users to have option to set ID not to update objects on the map automatically, but only on demand. That would help a lot. Now, even slightest move of the map causes reload of the objects which is painfully slow.

A change along these lines would facilitate a “low data mode”: #7788. In my opinion, it probably should not be enabled by default, because a lot of users (myself included) make roving changesets and don’t necessarily plan them out ahead of time. Having to continually trigger a refresh could get annoying fast.

Choosing the features to display in the editor is always a tradeoff of performance over safety, regardless of the editor or API endpoint. It’s already the case that, due to enabled filters, sometimes iD and JOSM users unknowingly perform edits that semantically conflict with existing data (even if from there’s no conflict a purely data model standpoint). iD has some mechanisms to avoid the semantic conflicts, such as disallowing splits of features connected to hidden features. But increased customizability in this regard would probably overwhelm those safety measures, so such an enhancement would require considerable thought.

Sure, but this would considered as advanced feature for those who know what they are doing.
Look it form perspective of an editor that fills in tags information on the map, not editing geographical positions. He edits existing objects.
My main point is that editing in ID (and other editing tools too) becomes painfully slow due to too much details on the map. Something has to be done.

For example, option Points (of Interests) is not selective. User can either remove all points of interests or none of them. there is no option to select some points of interests. Same goes with other options offered within Map Features.

Maybe there could be subfilters under “Points of interest” for common categories of POIs. Selecting some of those subfilters but not others would put “Points of interest” in a mixed selection state. This improvement could probably happen even with the current implementation, improving map/UI rendering performance in dense areas without necessarily dealing with the bandwidth or memory concerns.

Exactly. Map become very detailed. Single trees are mapped, street lamps, semaphores, 3d modeling data is more and more added. I even found out sidewalk fence stones are mapped - each and singe one. Having more details on map is always good - except when you do not need them and they are just clogging the workspace.
And there is significant drawback: Map Features option does not free Id from objects. Objects are always loaded (which slows it down). It just does not display them.
The other day I had to edit single tag on some object. It was in the middle of the urban area so I knew that would be an issue. So I zoomed in to the maximum to reduce loaded map area. I also turned off all Map Features. ID loaded over 70.000 hidden objects! ID does not allow editing tags until whole map is loaded so I ended up waiting for a long time for ID to load all objects (that it did not even show in map editor) just to edit a single tag.
I guess there is a way for ID to decide what objects must be loadeded to avoid issues you point to. It is not problem if ID loads more objects than what user needs because it is required for safety of data entry. Problem is loading object that are not needed at all and just slow editor.

It would be good for users to have option to set ID not to update objects on the map automatically, but only on demand. That would help a lot. Now, even slightest move of the map causes reload of the objects which is painfully slow.

A change along these lines would facilitate a “low data mode”: #7788. In my opinion, it probably should not be enabled by default, because a lot of users (myself included) make roving changesets and don’t necessarily plan them out ahead of time. Having to continually trigger a refresh could get annoying fast.

I did search for similar issue case opened before i posted this but found nothing. Thanks for pointing this one. It is a bit more radical than what I suggested but yes, it is on the same page.
Of course, this should not be forced change in functionality but optional. Option for user that faces this problem in very detailed map areas to reduce number of objects loaded.
After all we are just users. We are pointing out problem. Our ideas how to solve them are just guessing how it could be done. The main point is that developers became aware of this problem that ID is close to became unusable due to more and more amount of data on the map. I am pretty sure they would come up with some solutions.


Add extra docs after pairing on set up with Han

This PR adds to the docs for people coming to the codebase for the first time, and adds extra information to the makefile

@hanopcan  I've made the updates we discussed on the call. Would you mind opening a PR and merging in any other changes if there was stuff that ought to be clearer?
There's no need to wait for review from me to merge it in, as these would mainly be changes for our future selves or future team members.


Menu creator options

Allow the menu creator to specify if it's going to be a filter for tags (i.e., a blog filter) or an actual menu. Therefore changing whether it does a search based on tags or a standard menu with links

A filter would be totally different code. Would probably have to be a separate module cause it would have to pair with the content.


cargo install cargo-generate failed E0658 on MacBook Pro M1 2020 MacOS Monterey 12.3.1, rustc 1.59.0 (9d1b2106e 2022-02-23)

I'm attempting to install cargo-generate on MacBook Pro (M1 2020) running MacOS Monterey 12.3.1, rustc 1.59.0 (9d1b2106e 2022-02-23). I get the following error:
error[E0658]: trait bounds other than `Sized` on const fn parameters are unstable
  --> /Users/ashwin/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-generate-0.14.0/src/hooks/mod.rs:19:6
   |
19 | impl<F: FnOnce()> CleanupJob<F> {
   |      ^
20 |     pub const fn new(f: F) -> Self {
   |     ------------------------------ function declared as const here
   |
   = note: see issue #57563 <https://github.com/rust-lang/rust/issues/57563> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `cargo-generate` due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `cargo-generate v0.14.0`, intermediate artifacts can be found at `/var/folders/36/yw6776y506570jjdmxv5rlpc0000gn/T/cargo-installAC5cKA`

Caused by:
  build failed

duplicate of #623, solution is:

rustup update


feat: Official mongo library upgrade

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.12%. Comparing base (8605632) to head (4cf459e).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   80.12%   80.12%
=======================================
  Files          47       47
  Lines        2309     2309
=======================================
  Hits         1850     1850
  Misses        458      458
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature]: Upload button

What would you like to see added to the NWB GUIDE?
On this page:

It's not clear that the "Next" button initiates the upload. I think it would be better if we removed the "Next" button and instead had a BIG "Upload" button centered on the bottom half of this page. This size and position of the button will make it clear to the user that this is the definitive upload step and will make the action more satisfying.

Do you have any interest in helping implement the feature?
No.
Code of Conduct
Yes
Did you confirm this feature was not already reported?
Yes

Or we could just change the text of this "Next" button to "Upload"

This is somewhat in conflict with a previous suggestion (https://github.com/NeurodataWithoutBorders/nwb-guide/issues/593) to simplify the text of the buttons to avoid confusion—but I think this particular change is important and the character difference between "Next" and "Upload" is negligible. With the changed location of the button, I'd imagine it's easier to locate visually and the changed text isn't so jarring.


Add authentication

Basic username and password authentication

Authentication has been added and included in main and develop branch. Please check out the README file.
9cc805b8de8e74b86dd1c41530e9afdda9c598fb


micro optimisation of loop array

micro optimisation

This is not just an optimization, but also change of behaviour


<EMAIL_ADDRESS>fix download URL

Closes #11999

[x] I have read the Contributing Guide.

/verify

I can confirm these changes are needed to get gnucash working.  I made the mistake of creating my own fork before I noticed this one.  Can we get this merged?  gnucash currently won't install or update without this change.  Thanks!


Fix detecting an "empty effective config" and improve the UI related to processing groups and projects with such

As of now, in v. 2.1.2, the "effective config" for anything includes the whole merged common+group+project-level configuration.
For example if you have a group "some_group" with only some group_secret_variables defined for it and run GitLabForm against it, this is what will happen:
$ gitlabform --noop some_group
🏗  GitLabForm version: 2.1.2 = the latest stable 😊
:: # of groups to process: 1
:: # of projects to process: 46
@ (1/1) Processing group: some_group
* ( 1/46) Processing project: some_group/a_project_1

(... 44 more lines of output about projects that are in fact skipped ...)

* (46/46) Processing project: some_group/a_project_46
:: # of groups processed successfully: 1
:: # of projects processed successfully: 46
:: All requested groups/projects processes successfully! ✨

Note how redundant and misleading this! The truth is that only 1 group has been processed successfully while 46 projects were in fact skipped.

Starting from v2.2.0, released a moment ago, the above example will look like this:
$ gitlabform --noop some_group
🏗  GitLabForm version: 2.2.0 = the latest stable 😊
:: # of groups to process: 1
:: # of projects to process: 0 (# projects with empty effective configs that will be skipped: 46)
@ (1/1) Processing group: some_group
:: # of groups processed successfully: 1
:: # of projects processed successfully: 0
:: All requested groups/projects processed successfully! ✨


search in joined model fields for peewee

if the searchable comlum name contains '.' , eg, fk.col, init_search will add joined model column to the search fields.

This seems like a useful feature, but I would want to see some suitable testing added around this use-case.
Please do feel free to open a PR with appropriate unit tests if this is still something you would find useful and are able to contribute to the project.


Add command line api command

For use with anvil, I need the current state of the workspace as parsed by Tapestry, preferably in the form of json.

Using Tapestry build on the command line with the flags --json and --no-write will force Tapestry to parse the work-space and output a JSON file to the work-space route containing a JSON representation of the project state.
This can then be parsed by tools such as anvil to understand the entire work-space state - this will be a one way binding and possibly in the future should be offloaded onto a plugin?

It would seem that the old chicken and egg situation that comes about from Tapestry needing to know the parsed command line input is blocking its ability to understand any command specific options and arguments.
Need to work out another way of identifying the details required by parseOptions within the main Tapestry class.

Needs test for --no-write flag functionality

Test added by e9be50ee9fd1de9c96d20ea0a017742c7eda1aae

Completed by 5566ff1ec24a6b14b81f87ae53679439ea0be36b for now


A list of source files missing Apache license headers

Following Apache license header guideline, all human-readable Apache-developed files that are included within a distribution must include the header text with few exceptions. You can find few exceptions here: which files do not require a license header.
I used Apache Rat to check this repository after excluding a few files, and I got this report. We need to add Apache licensing header to those files.
Unapproved licenses:

  openwhisk-catalog/tools/travis/setup.sh
  openwhisk-catalog/tools/travis/build.sh
  openwhisk-catalog/packages/websocket/README.md
  openwhisk-catalog/packages/installWatson.sh
  openwhisk-catalog/packages/installCombinators.sh
  openwhisk-catalog/packages/watson-textToSpeech/README.md
  openwhisk-catalog/packages/installWebSocket.sh
  openwhisk-catalog/packages/github/README.md
  openwhisk-catalog/packages/installSlack.sh
  openwhisk-catalog/packages/installWeather.sh
  openwhisk-catalog/packages/watson-speechToText/README.md
  openwhisk-catalog/packages/slack/README.md
  openwhisk-catalog/packages/validateParameter.sh
  openwhisk-catalog/packages/weather/README.md
  openwhisk-catalog/packages/installCatalog.sh
  openwhisk-catalog/packages/installGit.sh
  openwhisk-catalog/packages/util.sh
  openwhisk-catalog/packages/installSystem.sh
  openwhisk-catalog/packages/watson-translator/README.md

The excluded files are:
**/*.json
**/**.gradle
**/gradlew
**/gradle/**
**/.**
**/templates/**
**/*.j2.*
**/.github/**
**/auth.whisk.system
**/auth.guest
**/i18n_resources.go

I verified with RAT that all files have the license headers except the files in exclusion list. So we can close this issue.


Selectize input

Fully customizable SelectizeInput :

Comes with a newly designed plugin 'buttons' that can be required in user created plugins to easily manage item buttons
2 buttons are already included (remove_button and update_button)
Support 2 step object creation (2 pop-up windows for form properties that requires the object to have an id to work properly)
Also support an input button to update selected item

Coverage decreased (-9.1%) to 0.0% when pulling 3c96fd70be0408100da34d97fb03c2775fa72c81 on selectize-input into 00392f3e7df8293dad994ab5fc0889f99dfa6439 on master.

Coverage decreased (-0.2%) to 8.943% when pulling 078f68669fcab31bec361b22a0ceec72d1cfd70c on selectize-input into 00392f3e7df8293dad994ab5fc0889f99dfa6439 on master.

Coverage decreased (-0.2%) to 8.943% when pulling 078f68669fcab31bec361b22a0ceec72d1cfd70c on selectize-input into 00392f3e7df8293dad994ab5fc0889f99dfa6439 on master.

Coverage decreased (-0.2%) to 8.945% when pulling 19db8e25072fd5e1d737766e7d7dcf6cfa959636 on selectize-input into 00392f3e7df8293dad994ab5fc0889f99dfa6439 on master.

Coverage decreased (-0.1%) to 8.683% when pulling 950d61f2f8a244328dc476c1d76224d3b188bc34 on selectize-input into 96d2a4275bc2c956d1ec17a5290854c5a2356ed1 on master.

Coverage decreased (-0.1%) to 8.683% when pulling 7b643f0c6b1b0548a7e5069fc521466e843eb8ff on selectize-input into 96d2a4275bc2c956d1ec17a5290854c5a2356ed1 on master.

Coverage decreased (-0.1%) to 8.683% when pulling 7b643f0c6b1b0548a7e5069fc521466e843eb8ff on selectize-input into 96d2a4275bc2c956d1ec17a5290854c5a2356ed1 on master.

Coverage decreased (-0.1%) to 8.684% when pulling 75eafb6203cca8650782a59cc9595c085d29ca41 on selectize-input into 80b04f7c2d295ef22de8efbcae30a30e2f619278 on master.

Coverage increased (+1.4%) to 10.2% when pulling 75eafb6203cca8650782a59cc9595c085d29ca41 on selectize-input into 80b04f7c2d295ef22de8efbcae30a30e2f619278 on master.


[19.09] signal-desktop: 1.29.1 -> 1.29.2 (backport)

(cherry picked from commit 096c2b4a4b0d1dc1f3af206f6be9ee28d705c3c4)
Reason: Avoid an expired (unusable) release in the stable release
(Signal-Desktop releases expire after 90 days).

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg test signal-desktop


freshen up

making a note that tests weren't passing on master so I'm folding that into this. also noting that it wasn't clear how to act on the test output of diff errors. adding some changes that will help tighten tha feedback cycle.

I'm noticing there are is actually a decent amount of changes that need addressed to make the failing tests pass on master in addition to freshening up with deps and 2018 edition rust. so I'm going to merge and defer test fixes to another pull


Fix Bluespace Crystals not being picked up/allowed inside ore bags

About the PR

Bluespace Crystals now get sucked into ore bags. Both regular and holding.
Why / Balance

All other raw ores do, it was annoying to have to pick up mined crystals and put them in a regular inventory.
Technical details

Added the missing ore tag to the Bluespace Crystal ore prototype.
Media

n/a
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

:cl:

fix: Bluespace Crystals now properly get picked up by ore bags!

Summary by CodeRabbit

New Features

Introduced a new Tag component to the MaterialBSCrystal entity, categorizing it as an ore type with the tag Ore.

Aaa just clocked a bug; can't put crystals in lathes/packer anymore. Doing a fix right now!


style: override the REPL height to 100vh in index.html

relate #109

Thanks for the PR. We can set the height of #app directly, instead of overriding.


Include attributes in get relationships

Description
This will allow you to set laravel validation rules on include attributes.
Motivation and context
What problem does it solve?
there wasn't a way to set validation rules on jsonapi include object's attributes, because of includes is an array of index objects, and you don't know what is the order of relation include objects.
How has this been tested?
Run the tests to make sure that everything still works.
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:
Go over all the following points, and put an x in all the boxes that apply.
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

[ x] I have read the CONTRIBUTING document.
[x ] My pull request addresses exactly one patch/feature.
[ x] I have created a branch for this patch/feature.
[x ] Each individual commit in the pull request is meaningful.
[x ] I have added tests to cover my changes.
[x ] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Fix php-cs

Hi @AshrafHefny, thanks for contributing to this repository! I'm reviewing your changes and it seems that your changes to JenssegersItem violate the JSON API specification for relationships: http://jsonapi.org/format/#document-resource-object-relationships. The spec states that the item(s) in the data part of a relationship must be of type 'Resource Identifier Objects' (http://jsonapi.org/format/#document-resource-identifier-objects). These items must contain a type and id member and optionally a meta member. This does not include the attributes you added. For your other changes I would like to ask you to give us a little more context of what problem your changes should fix. Maybe you can supply an example JSON to help you explain this? Thanks!

Hi @AshrafHefny thanks for the explanation. Unfortunately we want to keep in line with the spec and therefore we do not accept PR's that violate this. Your other fix for the deletions sounds logic. Can you update your PR to only include this fix?

Hi @AshrafHefny
Any update on this?

Closing because it's too outdated.


Singapore open data

[X] My submission is formatted according to the guidelines in the contributing guide
[X] My addition is ordered alphabetically
[X] My submission has a useful description
[X] The description does not have more than 100 characters
[X] The description does not end with punctuation
[X] Each table column is padded with one space on either side
[X] I have searched the repository for any relevant issues or pull requests
[X] Any category I am creating has the minimum requirement of 3 items
[X] All changes have been squashed into a single commit

The root of the url is the same as for weather https://github.com/public-apis/public-apis/pull/1845, however my link has access to a lot of API information (not just weather).

My pleasure!


Propose new environmental consideration information for ML models

The fact that datasets used to train AI models are increasingly large and take an enormous amount of energy (and indirectly produce large CO2 emissions) to develop, train and run has come to the forefront. This PR contains proposed additions to the "modelCard" type to account for these considerations when selecting/utilizing a model.
Background:

https://www2.datainnovation.org/2024-ai-energy-use.pdf
https://www.linkedin.com/pulse/here-comes-sun-why-large-language-models-dont-have-cost-paul-walsh/

many more from any search engine...

i dont understand the issue

This PR contains proposed additions to the "modelCard" type to account for these considerations when selecting/utilizing a model.

this description does in no way describe the actual problem, but gives a reason why a certain problem shall be solved

@stevespringett can you help me here? I dont see a reason for putting these values in an ML-BOM.
Putting self-proclaimed side-data in BOM - does this actually help anybody? Is there some write-up or video-recording from the CycloneDX ML-working group related to this topic?
With my current understanding of the topic, this all looks like an abuse of BOM for bragging-purposes (like: look how large/low my numbers are... and my numbers are better than yours...).

@jkowalleck The energy crisis for AI was just starting to happen when the AI/ML workgroup was operational. Over the last year, the crisis has grown exponentially. Organizations previously were talking about being carbon neutral. With the energy demands of AI, that likely is not possible. This reality is captured in the text of the AI Act. The energy considerations can also be combined with CDXA so that organizations can attest to the data in the model card.
The environment consideration support that Matt is working on will help CycloneDX adopters meet requirements in the AI Act.

According to the text adopted by the European Parliament, the AI Act sets out requirements for so-called "high-risk AI systems." These systems must be designed and developed with logging capabilities that enable the recording of energy consumption, the measurement or calculation of resource use, and the environmental impact throughout the system's lifecycle. These requirements primarily focus on transparency, ensuring that stakeholders have access to data on energy consumption. However, it is important to note that, in this case, the AI Act does not compel measures to reduce the energy consumption of AI systems.

Source: https://www.techpolicy.press/addressing-ai-energy-consumption-why-the-eu-must-embrace-ecodesign-for-software/
This is the use case that Matt is trying to achieve with this feature.

To frame this in a use case:
As a AI producer or operator, I want the ability to represent environmental concerns including energy consumption and CO2 emissions throughout the lifecycle of a model, including data acquisition, training and fine-tuning, to MLOps (including inference). I want to use CycloneDX to help my organization comply with the environmental transparency requirements in the AI Act.

Environmental costs for ML-BOM is just one aspect.
Would you also add cost for SaaSBOM - how much does it cost to run the service?
Would you also add time cost for SBOM - like how many hours went into the development of a component?
Would you also add health/medical costs for HBOM - how many people suffered for mining the materials used in a component?
Thing is, all these "costs" are currently (in real world) priced in money (taxes, operational costs, RnD, etc).
If we wanted to add environmental costs specifically, then I would argue that we should add costs in general - for every component/service/...

If we wanted to add environmental costs specifically, then I would argue that we should add costs in general - for every component/service/...

Valid point. However, the same logic could be applied to the majority of the model card, including performance metrics and biases. But that's not where the industry is currently at. But in the proposed design, we could reuse this data outside of just the model card in a generic sense and make it available to every component and service.

related work by : Green Software Foundation - Impact Framework - see https://if.greensoftware.foundation/

a followp will be https://github.com/CycloneDX/specification/issues/406


Function rules not working?

I believe I am using them correctly, but can't seem to get them to execute/apply to the styles. In the example below I expect all of the tests to have red text. Function rule is the only one that doesn't work.
const styles = (theme) => ({
  basic: {
    color: 'red'
  },
  value: {
    color: () => 'red'
  },
  rule: () => ({
    color: 'red'
  })

})

const Comp = ({ classes }) => (

Basic

Function Value

Function Rule

)

see: https://codesandbox.io/s/l226z8kzjl

I see red text in all 3 on YOUR codesandbox

mb some cache issue with codesandbox?

Looks good to me now also. FYI, the sample react-jss codepen project is on 8.0.0 (https://codesandbox.io/s/j3l06yyqpw). I had bumped to 8.3.3, but as you suspected, might have been a caching issue. Thanks!


Added New ETW Events (Windows 11)

This PR adds new ETW events that were added in Windows 11. The list of ETW providers that has been added is the following:

Microsoft-Windows-Kernel-Cache
Microsoft-Windows-Kernel-Dump
Microsoft-Windows-TenantRestrictions
Microsoft-Windows-USB-USB4DeviceRouter-EventLogs
Microsoft-Windows-WerKernel
Microsoft-Windows-WinHttp-Pca
Microsoft-Windows-WinINet-Pca
Microsoft-Windows-Winsock-Sockets
Microsoft-Windows-ZTraceMaps

The following additions are based on the following research:

ETW Resources Project
Windows 11 “New” ETW Providers — Overview

Wow! That's awesome @nasbench ! Thank you very much for sharing your research through the OSSEM project as well 🙏🏾  I would love to know how we can improve the tracking of those ETW providers in the future. The versioning, new fields, etc. Any feedback would be appreciated 😄

Great suggestion @nasbench ! mmm I assume we would have to go through all the releases docs. Does that exist somewhere? I remember downloading a few lists of events in a word document from MS docs and it had some of that information. I was wondering if you knew of any specific resources. I will also ask internally.

@nasbench we could do a diff between each version of Windows and include tables of what changed from 1803 to 1809 to 1903 etc, from A-Z for every version we're already working on. Server, too. That's at least ultimately what I had in mind for our ongoing project 😎

That's exactly what I was about to suggest @AndrewRathbun
Using the different manifests we've been collecting and diffing them, will yield us great results and will give us a lot of insights into when were new events and providers added.
@Cyb3rWard0g We've been dumping ETW manifests from the different versions of Windows (See ETW Manifests) So we could use this as a very good basis for what we're talking about here.


parsing URL inside file

Munee is trying to parse urls inside the the JS file even its commented out. To be exact the URL on the last line of the following file:
https://github.com/silviomoreto/bootstrap-select/blob/master/dist/js/bootstrap-select.min.js
Btw I still have problem with fonts inside stylesheet (font awesome) unless I use .htaccess rule which i am trying to avoid. Can it be fixed somehow?

it is even worse with Tiny MCE plugin. it is trying to parse all plugin files from inside main .js file and have problem with relative paths.


Update cs_registers.rst

Updated tdata1 reset val to match RTL implementation and explanation of values already in the bit descriptions.

@emgens : You seem to not have the ECA signed, at least not with the email address connected to your github account. This is necessary to do so you can make pull requests

I agree with @MikeOpenHWGroup. This pull request should not be implemented.


MacVim display issue when reloading .vimrc

Hi,
I'm getting this issue on MacVim which should be resolved by using set t_Co=256 . This only happens when I source the vimrc automatically after changing it. Normally starting MacVim displays lightline correctly!
Any ideas why this is happening or what I should investigate?

Would you please paste your vimrc here?

Sure thing! I also noticed this only happens when reloading the .vimrc via autocmd. If I :source $MYVIMRC by hand in commandmode everything is fine.
set nocompatible

" General
set number
set linebreak
set showbreak=+++
set textwidth=100
set showmatch
set visualbell

set hlsearch
set smartcase
set ignorecase
set incsearch

set autoindent
set shiftwidth=4
set smartindent
set smarttab
set softtabstop=4

" Advanced
set ruler

set undolevels=1000
set backspace=indent,eol,start

" Generated by VimConfig.com

syntax on

filetype plugin indent on

call plug#begin('~/.vim/plugged')

Plug 'itchyny/lightline.vim'
Plug 'tomasr/molokai'

call plug#end()

set encoding=utf-8
scriptencoding utf-8
set laststatus=2

let g:molokai_original = 1
colorscheme molokai

augroup reload_vimrc " {
    autocmd!
    autocmd BufWritePost $MYVIMRC source $MYVIMRC
augroup END " }

let g:lightline = {
      \ 'component': {
      \   'readonly': '%{&readonly?"x":""}',
      \ },
      \ 'separator': { 'left': '', 'right': '' },
      \ 'subseparator': { 'left': '|', 'right': '|' }
      \ }

set guioptions-=T
set guioptions-=r

What happens when you move the two commands syntax on and filetype plugin indent on after the end of your vimrc?

Issue persists.
I can switch between it breaking and displaying correctly by saving my vimrc (it breaks) and then executing :source $MYVIMRC (changes to showing up fine) indefinitely..

You should use syntax enable instead of syntax on.
syntax on resets current highlight config.

Thank you!
So this looks to be an issue with autocmd since it's independent from how I source (using $MYVIMRC or "%").

This problem is solved?  I think it is not lightline issue.

It was not solved by changing to syntax enable but it is indeed not a lighten issue! I did some more digging around and found that Powerline kind of has the same issue just much more apparent on Stackoverflow.
You should always be using the nested flag for autocmd when sourcing your vimrc file! Using:
augroup reload_vimrc " {
    autocmd!
    autocmd BufWritePost $MYVIMRC nested source $MYVIMRC
augroup END " }

fixed this.

Oh, I get it.

Hmm looks weird but that would be the solution.


[pcl::KdTreeFLANN::setInputCloud] Cannot create a KDTree with an empty input cloud!

When we build a map on our own dataset, there are a large number of kdtree errors, as shown in the figure. Although this does not affect the operation of the program, the effect of mapping is poor Do you have any good suggestions?

This error is most likely caused by the failure to detect feature points(Corner---1, Surf---2, NonFeature---3) in current frame.
You can check the node "LidarFeatureExtractor".

I have the same issue when I try to run the following codes.
roslaunch livox_ros_driver2 livox_lidar_msg_HAP.launch
roslaunch lio_livox hap.launch

My errors:
[pcl::KdTreeFLANN::setInputCloud] Cannot create a KDTree with an empty input cloud!
[ INFO] [1667715070.825824110]: Frame: 607

[pcl::KdTreeFLANN::setInputCloud] Cannot create a KDTree with an empty input cloud!
[ INFO] [1667715070.925633590]: Frame: 608
...

My hap_config.yaml:
%YAML:1.0

# switches
Lidar_Type: 1    # 1-hap
Used_Line: 6    # lines used for lio, set to 1~6
Feature_Mode: 0    # 0(false) or 1(true)
NumCurvSize: 2
DistanceFaraway: 100 # [m]  <DistanceFaraway near / >DistanceFaraway far
NumFlat: 3 # nums of one part's flat feature
PartNum: 150 # nums of one scan's parts
FlatThreshold: 0.02 # cloud curvature threshold of flat feature
BreakCornerDis: 1 # break distance of break points
LidarNearestDis: 1.0 # if(depth < LidarNearestDis) do not use this point
KdTreeCornerOutlierDis: 0.2 # corner filter threshold
Use_seg: 1 # use segment algorithm
map_skip_frame: 2

My HAP_config.json:
{
	"lidar_summary_info" : {
			"lidar_type": 8
	},
	"HAP": {
		"lidar_net_info" : {
			"cmd_data_port": 56000,
			"push_msg_port": 0,
			"point_data_port": 57000,
			"imu_data_port": 58000,
			"log_data_port": 59000
		},
		"host_net_info" : {
			"cmd_data_ip" : "<IP_ADDRESS>",
			"cmd_data_port": 56000,
			"push_msg_ip": "",
			"push_msg_port": 0,
			"point_data_ip": "<IP_ADDRESS>",
			"point_data_port": 57000,
			"imu_data_ip" : "<IP_ADDRESS>",
			"imu_data_port": 58000,
			"log_data_ip" : "",
			"log_data_port": 59000
		}
	},
	"lidar_configs" : [
		{
			"ip" : "<IP_ADDRESS>",
			"pcl_data_type" : 1,
			"pattern_mode" : 0,
			"blind_spot_set" : 50,
			"extrinsic_parameter" : {
				"roll": 0.0,
				"pitch": 0.0,
				"yaw": 0.0,
				"x": 0,
				"y": 0,
				"z": 0
			}
		}
	]
}

Any solution for it?
Thanks in addvance!

This is because of empty corner feature.
You can check LidarFeatureExtractor.cpp as @liang0724s said.
If you are using HAP, "FeatureExtract_with_segment_hap()" function has no corner detecting part.
This is not a fundamental solution but I referenced "FeatureExtract_with_segment()" function to edit "~~_hap()" function.
Again, this is not a fundamental solution but it will remove that error.

solved the error but after running some frame this error is coming in which scanregistration process is died

solved the error but after running some frame this error is coming in which scanregistration process is died

Same with me . Have you solved it ?


cleanup - add noop function for common use case

Adds a noop util for common use case where a default function needs to be provided
Avoids the need to add ignoring where used legitimately, however in some cases there were better alternatives in unit tests like jest.fn which does the same thing. Additionally https://github.com/wagtail/wagtail/pull/8749 will allow for no function body in test functions so did not go too far down that rabbit hole.
Added a small improvement to the bound block unit tests - so we do not have to ignore unused variables here (added snapshots)
Split from https://github.com/wagtail/wagtail/pull/8578
This should make other parts of the eslint clean up & rules adoption work easier https://github.com/wagtail/wagtail/issues/8731

Thanks


Add our metrics

Metrics on landing page are currently blank. Currently we have: downloads, publications, packages, and interns. Are these what we want? I like publications and interns. Not sure how meaningful the downloads metric would be. If we keep it the count should include all of our packages (VAPOR, and various GeoCAT products). I'm also not sure what "packages" means.
Other metrics to possibly consider as replacements or additions to downloads and packages:

Tutorials: number we have held, or maybe number of attendees. we should have data for both of these
Youtube videos: number we've produced or number of views. These can be harvested from Youtube manually. There is also a Youtube Channel Analytics API that would be preferable.
Other?

@NihanthCW, @erogluorhan what are your thoughts?

Adding @jukent to the thread for her thoughts

We have the 4 original metrics up now! For tutorials, it would be hard to get unique attendees, but I could get the total attendees from the Zoom account data.  Similarly, we can grab total views from the Project Pythia youtube channel.
I am not sure I want 7 metrics items on the bottom though, it would seem crowded.

Agreed, four is plenty. Not sure how meaningful Packages is, but not sure what to replace it with. i think it is fine for now. Thanks!!!


type error in AnimateTintFilter::uniforms.multiplier

I have cases where this field is a Float, causing an Error at runtime :
Uncaught TypeError: Cannot create property 'value' on number '0'
I didn't identify the case, but it seems that "typedef" is not safe for typing.
I will make a patch to modify this :
https://github.com/jackwlee01/pixi-flump-runtime/blob/master/src/flump/filters/AnimateTintFilter.hx#L62
... with :
if( ! Std.is( uniforms.multiplier, Float)) uniforms.multiplier.value = multiplier= pMultiplier;

PR sent :
https://github.com/jackwlee01/pixi-flump-runtime/pull/29
Maybe a problem of compatibility between the pixi v4 Filter class, and the pixi v3 AbstractFilter class ?
Well, I just added this test to prevent the code from crashing (with comments for further works)


[FR]Add revison creation setup

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
Currently creating a new revision of a heavily used part leaves you with a lot of stock of the old part which needs to be re-created and loses history
Suggested solution
Create a wizard for defining new revision which includes the option to either covert existing stock or create a (Build) order to covert the stock.
Describe alternatives you've considered
Use API to re-create stock in the same places with the same quantities
Examples of other systems
No response
Do you want to develop this?

[X] I want to develop this.

Follow up to https://github.com/inventree/InvenTree/issues/5028

@matmair good idea regarding converting stock, had not considered that.


Importing from MavenLocal works but not from remote (lintPublish dependency)

I've a lint lib that fails to import throwing:
> Failed to resolve: AndroidStyling-LintRules:checks:unspecified
> Affected Modules: app

So I tested running ./gradlew publishToMavenLocal and this was thrown:
* What went wrong:
Execution failed for task ':styling-lint:publishAndroidPublicationToMavenLocal'.
> Failed to publish publication 'android' to repository 'mavenLocal'
   > Invalid publication 'android': artifact file does not exist: '.../styling-lint/build/outputs/aar/styling-lint-release.aar'

I found what was missing so after fixing it by adding builtBy:
artifact("$buildDir/outputs/aar/${artifactId}-release.aar") {
    builtBy(tasks.getByName("assemble"))
}

publishToMavenLocal builds successfully and I can use mavenLocal() to import and it works.
Unfortunately, importing from remote still fails with the same output...
What am I missing?
Thanks.

Anyone can help me?

Importing from Jitpack works, from Maven or Jcenter it doesn't, any reason why?

Released a new version of the lib with a few updates and it started working 🤷♂