Added AsyncPubsubHandler.

Also refactored.

Coverage remained the same at 100.0% when pulling b0ef7434d0479ad8fa3224b8540f9b8f87f8e70a on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 0390e89ec01691707b673ae8256840db31731d64 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 885e845c24f3027d046c7b06a874f421f2ad1ac2 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling af12a78a13162fd39002cdc11e4f8a26f08a32f2 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

@gainward I added an async threaded version of the logging handler. Can you take a look?

I should have not used the daemon mode. I'll try to implement cleanup of child threads and update here.

Ok, stopped using the daemon mode and now we shutdown cleanly. I think it's ready for review.

Coverage remained the same at 100.0% when pulling 6af306668484717e9b8f3726c10c49acdcb8cb2d on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 9c12cb1a6fbc75d8e8e7d6ddf1c001dd5d6bfda3 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 88e0be330e6f590e34062c50e3e5ba1be7174ee8 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling e6cb4409821b6bc77a88e3601cb85fd132538cad on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 1876222cbac0511d1e1773e2554d71e867203dd7 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 8028f9e83808b3e791bbcbbfd805c5a391a19742 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling a9301cecff23315eb95979028d909bddcc71b0d8 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

@amygdala
This is a pypi package of Python logging handler collection for Cloud Pub/Sub.
I added Async version of the handler, which significantly improve the throughput of the handler. However, the throughput is still capped around at 12k messages per second. I profiled this and realized it is capped by logging.Handler.handle method, which acquires the lock and releases it upon receiving a single line of log, which seems to me the limitation of the python logging module.

Coverage remained the same at 100.0% when pulling 0dfcc1cff20caddcedc2e81ceb3e8dc9c7bf3c28 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling c2b292500c41fe94c55f9b9521db2d250133914c on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling d296bf4a22e03a3032c86de94a78b2788b9687fc on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

cool!  A few mostly minor comments. LG overall, though I didn't look closely at the tests file yet.

solid work - I for sure learned a few good tips/patterns on apiclient usage reading through this.  I wouldn't worry too much about the 12K QPS limit - as you say, bottleneck is in the module.  One concern is making it clear to users that async involves MP - such that if they are adding this handler in many THREADS of their program, it will create a process per handler instance (with default num_workers).
I think that is why in some situations - the model of fluentd can make more sense, where it exists in its own process - and can use the filesystem as the surge tank, allowing the task process to exit without waiting for the logger to .join on publishing
But I think this is just a documentation issue, letting people know so they can make a call about the right tool for the right task.

Coverage remained the same at 100.0% when pulling 161462500e2270fe7b7dd50b4ada0247a2b6cd45 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 6681237e70827219378c02d8202369009595804e on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

@ptone Thanks for the review.
FYI, by moving from threading to multiprocessing, now the throughput is about 35k messages/sec. It is a great improvement :)

@ptone

One concern is making it clear to users that async involves MP - such that if they are adding this handler in many THREADS of their program, it will create a process per handler instance (with default num_workers).

Python logging handler is designed to be thread safe. You can (and should) share the single hander with multiple threads.

Coverage remained the same at 100.0% when pulling c5c534b1369f39cb9e047c1c870f7d0fcbe1f0df on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling c5c534b1369f39cb9e047c1c870f7d0fcbe1f0df on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

PTAL

Let me refactor debug parameter.

Coverage remained the same at 100.0% when pulling b77c84b99f8813ba00d93334547f6d2e6bb89710 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Sorry for lots of changes, but I think it's ready for another look.

Thanks @gainward! I think I fixed all of your comments.
PTAL

Coverage remained the same at 100.0% when pulling 22f88d9d0b39c0ba49542247db88552aab4a880a on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling b2b01c90c33d792d0f7e2e99ebc7ba782d06c0c5 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

@gainward Thanks!
I can make the send_loop just a function, but it will have way more arguments than you originally thought.

Coverage remained the same at 100.0% when pulling 4c86c5ffb52e75359483047a80a708aaf85e7de6 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling ca831b43e8342ae6e853a3957b12f10773bbe0a4 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling ca831b43e8342ae6e853a3957b12f10773bbe0a4 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 7e3de8dcc215b7464b3f77288c8b14b11dd68048 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 313c6c226da97faf9c74da1d0915e560210d6ad2 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 313c6c226da97faf9c74da1d0915e560210d6ad2 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 313c6c226da97faf9c74da1d0915e560210d6ad2 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 28a7d13eb14fa99977db2aa62a6a60ad53f5e611 on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

All right, PTAL!

Coverage remained the same at 100.0% when pulling ccf590425a5e8641868ccf6a0987bfa957c3c7ef on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling ccf590425a5e8641868ccf6a0987bfa957c3c7ef on tmatsuo:async into 8ac36e594375750427f2ea503bb25f1974998ebf on GoogleCloudPlatform:master.

LGTM


It's GANtastic

Changes in this branch:

combined inpainter and discriminator into a single training step. I was hoping this would reduce oscillation (unclear) but if nothing else is more efficient
added Trainer.fit_mask_generator() and Trainer.fit_inpainter() methods so you can independently run the different training phases. My hypothesis that end-to-end training might not matter is definitely wrong- at least on Shipsnet, letting the two co-adapt matters a lot.
for the inpainter training phase, there's a separate step now to build the mask buffer. this only uses positive images (since masks for negative images should be mostly empty, leading to trivial solutions in inpainter training)
added learning rate decay

Testing on Shipsnet- LR decay seems to make a big difference.

Flagging @zamorarr in case you have any thoughts/concerns/ideas/complaints.


Pod details view missing buttons for attach, shell and log

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to Workloads->Pods
Click on pod
see how there are no buttons to see pod log, or to get to pod shell[and attach to pod, but I do not care about it]

Expected behavior
I should be able to see log and get to pod shell
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Lens Version: 6.3.0
OS: Manjaro
Installation method (e.g. snap or AppImage in Linux): AppImage

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Your logs go here...

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
6.2.5 version:

6.3.0 version:

having this issue too
Computer: Apple M1 Max, 64GB, Ventura 13.0.1
Lens:

Same here

also on linux :)

Same thing in Windows 11

Same here. This bug is a critical one :(
Same versions as @DaruZero

Noticed this one too. Not much to add other than this is pretty critical part of core functionality.

Same issue with 6.3.0 in Windows 11

We have same issue, we can´t log any pod/workload

Downgrading works, but 6.3.0 is unusable

here you go https://github.com/lensapp/lens/issues/6823#issuecomment-1365034182

its now considered an out tree extension, its here now:

https://github.com/alebcay/openlens-node-pod-menu/releases

Reinstalling 6.1.1 fixes this for me, just don't hit the update button. https://github.com/MuhammedKalkan/OpenLens/releases/tag/v6.1.1

6.2.5 is also fine, that’s what i ended up doing.
On Thu, 5 Jan 2023 at 21:02, Mike Schem @.***> wrote:

Reinstalling 6.1.1 fixes this for me, just don't hit the update button.
https://github.com/MuhammedKalkan/OpenLens/releases/tag/v6.1.1
—
Reply to this email directly, view it on GitHub
https://github.com/lensapp/lens/issues/6857#issuecomment-1372673600, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7YCYRDEN5HWH5OQ3MRORDWQ4SGZANCNFSM6AAAAAATO4P2QQ
.
You are receiving this because you commented.Message ID:
@.***>

@Aeternax where are you getting 6.2.5? Or are you building it?

There's a build repository here that this is upstream from, it's called
OpenLens:
https://github.com/MuhammedKalkan/OpenLens/tree/v6.2.5
On Thu, 5 Jan 2023 at 21:14, Mike Schem @.***> wrote:

@Aeternax https://github.com/Aeternax where are you getting 6.2.5? Or
are you building it?
—
Reply to this email directly, view it on GitHub
https://github.com/lensapp/lens/issues/6857#issuecomment-1372691028, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AC7YCYXLHGMK6YXNYUZM3ATWQ4TTTANCNFSM6AAAAAATO4P2QQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

hah, I linked the same one but was on the wrong release 🤦🏼♂

Still an issue on 6.4.0 alpha

same for 6.4.12


Feature request: RSS/Atom feed

This amazing aggregator would be easier to incorporate into our existing internal workflows if an RSS or Atom feed was generated, either in addition to the JSON feed or as a feature flag output style option when self hosting.
Possible solution: https://github.com/lkiesow/python-feedgen

Yup, this has been discussed and could be considered forthcoming!

(Disclaimer: I have no ETA. I want there to be wayyy more docs, even for how our GitHub Actions are working, and there's a lot of fun data we could add, but we'll try to carve out time for it all)

PR #72 merged.
Big thanks to @Johnnysramos for this feature and for adding requested changes.


Not working under systemd

The kernel appears to work perfectly when I start the Jupyter Server from the command line, but when I setup Jupyter to run from a systemd service the Kernel crashes all the time.

This is out of scope for support, since there are a bunch of moving parts at play and it's extremely unlikely that the issue is with IHaskell.


My solution for the problem of wrong "jessie debian repository"

I found a solution at link
And Jessie ARMv8 systems only:

 deb http://archive.debian.org/debian/ jessie main contrib non-free

Please replace original dev repository address with the above

Hi @muncok,
Jessie repository no longer used.

Hi @muncok,
Jessie repository no longer used.

But, if I did not change it in Dockerfile or build_tensorflow.sh, it causes an error in my case.

Sorry, you're right. i'm using jessie for install gcc-4.
Thanks for your advice.


Wikidata meets NorKorr

On Feb 18, 2019, @arockenberger met with @jhsoby and Jorid Martinsen from Wikimedia Norway. The aim of the meeting was to find out if NorKorr could be an interesting case for a Wikidata Hackathon and if both projects (NorKorr and Wikidata Norway) could profit from each other.
It was decided to pursue this with a one-day hackathon on April 27, 2019.
Contact either @arockenberger or @jhsoby about that.

Moved to https://github.com/norkorr/project/issues/3 - closing Issue


Make both database backends optional

Right now importing one of the backends requires installing both.
This PR should fix that.

Thanks! Needs a few exclusions to make the linting pass.

Final thing is a codecoverage exclusion against that __init__.py file.
Thanks for your work here!

You don't really have a configuration file for coverage.
Do I edit https://github.com/tomchristie/apistar/blob/master/scripts/test#L17 instead?

Obsoleted by #235


Duplicated "more from this author" links when two authors are listed.

Eric Meyer's "More from this author" links are duplicates of Sara Wachter-Boettcher's on their excerpt, and Sara's  "More from this author" links are duplicating mine.
http://alistapart.com/article/design-for-real-life-excerpt#related
http://alistapart.com/article/design-for-real-life-interview-with-sara-wachter-boettcher#related

Corrected!


Slight difference in some aerosol HISTORY output

@gmao-esherman and @adarmenov,
I'm tagging you guys first as what I'm seeing is aerosol based. I think it's from something @adarmenov passed in, but I figure you are the two experts.
To wit, I came back from leave seeing this in my nightly tests:
github             --   pass  26 min      --   --   pass/FAIL/ --   -- / --   --   pass/pass    pass      --
githubrep         SKIP   --    --         --   --   pass/FAIL/ --   -- / --   --    -- / --     pass      --
githubdebug        --   pass   8 min      --   --   pass/FAIL/ --   -- / --   --    -- / --     pass      --

Odd. I still got many a notification on my iPhone from Git and I didn't remember @sdrabenh  or @lltakacs making any non-zero-diff pulls. But I was wasn't paying attention too hard either.
So I go look at the cmp logs and everything is zero-diff except tavg2d_aer:
 Comparing GCM run restarts...
                              gocart_internal_rst:  PASSED.
                               irrad_internal_rst:  PASSED.
                                lake_internal_rst:  PASSED.
...
             1day.tavg2d_aer_x.20000415_0900z.nc4: [FAILED]*!?#$*
             1day.tavg3d_aer_p.20000415_0900z.nc4:  PASSED.

All the restarts are zero-diff and all the history output but for tavg2d_aer. If I do a comparison myself:
(1056) $ nccmp -BdqfS BASELINE/run/1day/holding/tavg2d_aer_x/200004/1day.tavg2d_aer_x.20000415_0900z.nc4 \
CURRENT/run/1day/holding/tavg2d_aer_x/200004/1day.tavg2d_aer_x.20000415_0900z.nc4
Variable Group Count         Sum      AbsSum          Min         Max       Range        Mean      StdDev
BCSV     /     16380 5.59925e-15  5.5994e-15 -7.24497e-20 3.27172e-17 3.27897e-17 3.41835e-19 1.45189e-18
DUSV     /     13304 2.39448e-12 2.39448e-12 -6.52063e-20 3.46885e-14 3.46886e-14 1.79982e-16 1.46602e-15
OCSV     /     16380 5.11319e-14 5.11319e-14 -7.03877e-23 6.80825e-16 6.80825e-16  3.1216e-18 1.79945e-17
SSSV     /     16373 7.27088e-12 7.27088e-12  -7.6949e-37 4.90176e-15 4.90176e-15 4.44077e-16 6.46015e-16
SUSV     /      9144 9.89312e-15 1.03452e-14  -1.1099e-17 7.55491e-17  8.6648e-17 1.08192e-18 2.94461e-18

If you trace this in the code, it looks like these are Moist exports and my guess is the difference is from GEOS-ESM/GEOSgcm_GridComp#94. It looks like just a slight math order change because the compiler might be able to do less/different optimizing as the divide by MAPL_GRAV*DT_MOIST is now in a second step and not all in one step.
I just wanted some reassurance before I re-baseline my nightly tests that this is just really an artifact of the Moist changes.

@mathomp4 If this is related to GEOS-ESM/GEOSgcm_GridComp#94 then you should re-baseline.


unable to find usable node.js executable

Hi team, i m running "./bin/kibana-plugin install  https://github.com/datasweet-fr/kibana-datasweet-formula/releases/download/version_name/datasweet_formula-2.2.1_kibana-7.0.1.zip" and getting the error "unable to find usable node.js executable". Can you help ?

Hi @webmasterThomas , it seems this issue is not related to the plugin itself. Maybe this can help you fix it : https://discuss.elastic.co/t/unable-to-find-usable-node-js-executable-while-installing-plugin/233146

Hi @lfroment-datasweet , i used both variants listed in this reference and also copying plugin files to plugins forlder also does not work.

resolved on my own


Commands for led display

Hi,
Can this driver be use to interact with the led display of the R2000 ? If not, do you have a clue to do that ?
Thanks.

No, you can't really interact with the LED display with this driver.
There is probably one one thing you can do (by changing a parameter): You can switch off the P+F logo, which is displayed after startup.
I'm in reguarly contact with the developers/distributors of the scanner. We also asked for a protocol for changing the logo displayed by the led display, but there is no such protocol implemented in the scanner as far as I know. I last talked to them some months ago this year.


IE11 replaceChild error

v0.4.4
https://github.com/maxwellito/vivus/blob/master/dist/vivus.js#L741  is causing
Unable to get property 'replaceChild' of undefined or null reference
http://prntscr.com/kqvacq

Please provide an example. JSfiddle or any other platform. Thanks.

Thanks for providing a URL to test. However, I'm afraid I couldn't reproduce it as intended. Over the first visits, IE triggered no errors and the animation was smooth. However after playing many times with your scrolling system I managed to get the same error. I think it's related to something else, too much magic happening. My guess is your scroll panel system looks like it create and delete content along the scroll. And at some point it tries to trigger the animation on a deleted SVG. The error appear only on IE because by default the forceRender is on this browser. Forcing to recreate each path element on something that no longer exists in the DOM.
I retested the interactions from the manual tests on IE11 and didn't noticed any problem.

hm , is not removing anything but hiding so by your explanation and the triggered error seems like it cant find the element due to its visibility: hidden class being applied.

This is the class and the rules that element gets when out of the view
.thz-animate {
    opacity: 0;
    animation-duration: 0.7s;
    -webkit-animation-duration: 0.7s;
    -moz-animation-duration: 0.7s;
    -o-animation-duration: 0.7s;
    animation-timing-function: ease-in-out;
    -webkit-animation-timing-function: ease-in-out;
    -moz-animation-timing-function: ease-in-out;
    -o-animation-timing-function: ease-in-out;
    -webkit-perspective: 1000;
    -webkit-backface-visibility: hidden;
    backface-visibility: hidden;
    will-change: transform,opacity;
}

Here , this is all it happens to the element, class added/removed http://take.ms/kCJpn

I'm afraid I can't help you more. The code of your page is minified and it's pretty hard to debug. This is also why I don't usually accept personal websites, but only sandboxed pages (from jsfiddle or custom gh-pages). Here is the example I provided to the Chromium team when I reported a bug.
So far the manuals tests are working on IE11, and I also managed to see the animation working on your page. So I can't consider it a bug.

OK , thnx for checking. I would have made a sample but like advised JSFiddle does not even want to open on IE11


Discord and Donations?

Sorry if this is not the correct place to suggest this, but would it be possible to get a Discord server created for the custom mode for bug finding, suggestion adding, play sharing, map creation, and future skinning?
Also, is there a way to help fund this project? I would full heartedly support osu!rush and help make sure it keeps getting good updates. As someone who has invested a lot of time into Muse Dash I would love to see this custom mode flourish.

I'm currently focused on osu!framework so I haven't had much time to look at Rush! recently.  I've mostly been fixing or approving PRs to ensure it works with recent osu! changes.
Is there actually enough of a community for a Discord server?  Also it's more about time and cognitive load rather than money, so I'd rather not take any kind of donations.

I'm currently focused on osu!framework so I haven't had much time to look at Rush! recently. I've mostly been fixing or approving PRs to ensure it works with recent osu! changes.
Is there actually enough of a community for a Discord server? Also it's more about time and cognitive load rather than money, so I'd rather not take any kind of donations.

I feel like there could be. There's countless of people in the MD community who would want custom charts and this game mode is pretty well fleshed out from what I've seen so far. It shouldn't be too hard to get people to come together once they know it exists.

There is now a Discord invite link in the readme.  Feel free to join if you want to chat about development, project direction etc.


Config poc. #55

Closes #55
Closes #58
Reviewers
Changes

add new generic components to be used on the detail page
Make the detail page configurable

Definition of Done (from ticket)

Configuring a layout drives a corresponding component hierarchy.
Storybook updated (stub configuration for each component in hierarchy only).

QA steps (optional)
Known Issues

The components styling will be done on a future ticket
The only project that's configurable is HCA

Closing, superseded by #83.


Bump setup-miniconda action version

Should be an easy enough PR to build so someone doesn't have to keep approving CI runs on my other PRs 😄
TODO:

[ ] Unit tests and/or doctests in docstrings
[ ] Tests pass locally
[ ] Docstrings and API docs for any new/modified user-facing classes and functions
[ ] Changes documented in docs/release.rst
[ ] Docs build locally
[ ] GitHub Actions CI passes
[ ] Test coverage to 100% (Codecov passes)

Considering it's OSX/wheels that's failing, I'm moving forward.


Fix generate_new_metadata in tidy_backup_clean.rb needs to preserve metadata.json.

Signed-off-by: Vasu1105<EMAIL_ADDRESS>Description
It skips the new generation of files if both metadata.json and metadata.rb exist
It raises error if both metadata.json or metadata.rb does not exist
It creates metadata.json if only metadata.rb exist as knife cookbook metadata does.
Issues Resolved
Fixes #105
Check List

[ ] New functionality includes tests
[ ] All tests pass
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

@lamont-granquist could you please review this PR. Most of this comments https://github.com/chef/knife-tidy/issues/105#issuecomment-540338069 are incorporated here.

@Vasu1105 Can you rebase this please?

@Vasu1105 Can you rebase this please?

@tas50 Done.

@PrajaktaPurohit this could also use review

@lamont-granquist since you reported this issue do you wanna review this?


Updates to Environment Canada platforms

Description:
External Library

Bump env_canada to 0.0.17

Split classes into separate modules to remove unnecessary imports
Return either English or French data and labels
Improve handling of severe weather alerts

Sensor

Remove hardcoded labels and units, use data supplied by env_canada instead
Add optional language parameter
Specify separate entity_id and display name

Weather

Handle new env_canada data structure

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9747
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: environment_canada
    language: french

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

This update to the env_canada library also includes a lot of enhancements related to alerts for severe weather, so it would be great to get it merged. Please let me know if there are any outstanding concerns.

I've updated the description to better describe the included changes.

Should this be marked as a breaking change, since the entity_id values and the configuration are changing? I've updated the documentation to reflect the changes.


when i run "bash scripts/perfect.sh", I got this error and please help me to solve this~

Traceback (most recent call last):
File "run_clm.py", line 517, in
main()
File "run_clm.py", line 427, in main
train_result = trainer.train(resume_from_checkpoint=checkpoint)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/transformers/trainer.py", line 1340, in train
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/transformers/trainer.py", line 1445, in _maybe_log_save_evaluate
metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
File "/Users/01119378/Documents/2022/perfect-main/fewshot/third_party/trainers/trainer.py", line 133, in evaluate
output = self.eval_loop(
File "/Users/01119378/Documents/2022/perfect-main/fewshot/third_party/trainers/trainer.py", line 185, in eval_loop
metrics = self.compute_pet_metrics(eval_datasets, model, self.extra_info[metric_key_prefix])
File "/Users/01119378/Documents/2022/perfect-main/fewshot/third_party/trainers/trainer.py", line 210, in compute_pet_metrics
centroids = self._compute_per_token_train_centroids(model)
File "/Users/01119378/Documents/2022/perfect-main/fewshot/third_party/trainers/trainer.py", line 281, in _compute_per_token_train_centroids
data = get_label_samples(self.train_dataset, label)
File "/Users/01119378/Documents/2022/perfect-main/fewshot/third_party/trainers/trainer.py", line 278, in get_label_samples
return dataset.filter(lambda example: int(example['labels']) == label)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 470, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/fingerprint.py", line 406, in wrapper
out = func(self, *args, **kwargs)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2519, in filter
indices = self.map(
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2036, in map
return self._map_single(
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 503, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 470, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/fingerprint.py", line 406, in wrapper
out = func(self, *args, **kwargs)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2248, in _map_single
return Dataset.from_file(cache_file_name, info=info, split=self.split)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 654, in from_file
return cls(
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 593, in init
self.info.features = self.info.features.reorder_fields_as(inferred_features)
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/features/features.py", line 1092, in reorder_fields_as
return Features(recursive_reorder(self, other))
File "/Applications/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/features/features.py", line 1081, in recursive_reorder
raise ValueError(f"Keys mismatch: between {source} and {target}" + stack_position)
ValueError: Keys mismatch: between {'indices': Value(dtype='uint64', id=None)} and {'candidates_ids': Sequence(feature=Sequence(feature=Value(dtype='int64', id=None), length=-1, id=None), length=-1, id=None), 'labels': Value(dtype='int64', id=None), 'attention_mask': Sequence(feature=Value(dtype='int8', id=None), length=-1, id=None), 'input_ids': Sequence(feature=Value(dtype='int32', id=None), length=-1, id=None), 'extra_fields': {}}
0%|                                                                                | 2/6000 [08:36<430:29:39, 258.38s/it]

Did you solve this problem? I got the same error as you when training 200/6000.

Any progress so far? I got the same issue at 200/6000 and seems irrelevant to tasks  (I've tried rte, sst2) and models (roberta-large, roberta-base)

When I run perfect.sh after following all the instructions, I got an error in loading the superglue dataset:
raise FileNotFoundError(

FileNotFoundError: Couldn't find a dataset script at /userhome/cs/tyyim/perfect/fewshot/super_glue/super_glue.py or any data file in the same directory. Couldn't find 'super_glue' on the Hugging Face Hub either: FileNotFoundError: Couldn't find file at https://raw.githubusercontent.com/huggingface/datasets/master/datasets/super_glue/super_glue.py
I suppose for RTE and CB (which I tried), it should be download from huggingface?
I have tested that I can download RTE alright with Jupyter notebook.

Hi All
I have tested the script of perfect on my side and this works fine for me. My guess is that you are using a different version of huggingface mentioned in the requirement. Maybe you can try to install the conda environment from scratch.
Best
Rabeeh

Hi All, Hi @vkgo @saga1214 @emmayouyou ,
this is because of a bug in huggingface datasets library, please see https://github.com/huggingface/datasets/issues/2943 they must have updated something in meanwhile in their library.
To solve it, I uninstall datasets and re-install it, now this is version 2.6.1 and I do not seem to get an error.
 pip install datasets==2.6.1

Rabeeh

Hi, after changing the version of the datasets to 2.6.1, I encountered the below error when I tried to run the code on QQP or QNLI, the below error doesn't occur for datasets version 0.13.0, but if I use 0.13.0,  the abovementioned error is raised. Any way to work around this?
Traceback (most recent call last):
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2961, in _map_single
writer.write(example)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 467, in write
self.write_examples_on_file()
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 425, in write_examples_on_file
self.write_batch(batch_examples=batch_examples)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 527, in write_batch
pa_table = pa.Table.from_arrays(arrays, schema=schema)
File "pyarrow/table.pxi", line 3592, in pyarrow.lib.Table.from_arrays
File "pyarrow/table.pxi", line 2785, in pyarrow.lib.Table.validate
File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: Column 4 named extra_fields expected length 1000 but got length 0
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "run_clm.py", line 517, in
main()
File "run_clm.py", line 377, in main
predict_dataset = predict_dataset.map(
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2572, in map
return self._map_single(
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 584, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 551, in wrapper
out: Union["Dataset", "DatasetDict"] = func(self, *args, **kwargs)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/fingerprint.py", line 480, in wrapper
out = func(self, *args, **kwargs)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 2991, in _map_single
writer.finalize()
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 554, in finalize
self.write_examples_on_file()
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 425, in write_examples_on_file
self.write_batch(batch_examples=batch_examples)
File "/home/chen/anaconda3/envs/perfect/lib/python3.8/site-packages/datasets/arrow_writer.py", line 527, in write_batch
pa_table = pa.Table.from_arrays(arrays, schema=schema)
File "pyarrow/table.pxi", line 3592, in pyarrow.lib.Table.from_arrays
File "pyarrow/table.pxi", line 2785, in pyarrow.lib.Table.validate
File "pyarrow/error.pxi", line 100, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: Column 4 named extra_fields expected length 1000 but got length 0

Hi
If you remove master_version in this line https://github.com/facebookresearch/perfect/blob/a3dc00d6c3fbbb43af1932e45a64bf348379c835/fewshot/data/tasks.py#L148 and update to the lastest version of datasets which I think it is 2.7.1 now, do you still get it?

Hi If you remove script_version="master" in this line
https://github.com/facebookresearch/perfect/blob/a3dc00d6c3fbbb43af1932e45a64bf348379c835/fewshot/data/tasks.py#L148
and update to the lastest version of datasets which I think it is 2.7.1 now, do you still get it?

yes, the error still occured. I notice that the error happens to QNLI and QQP when tokenizing the predict dataset. For MRPC, there is no such error.


want to expose "force-master-takeover" by http api & orchestrator-client

want to expose "force-master-takeover" by http api & orchestrator-client。only available in cli currently。

@shlomi-noach i mean "force-master-takeover" not "force-master-failover"

Ah, sorry, I wasn't reading this right.
Yes, it's possible to add to api and to orchestrator-client, though I've been having thoughts on the usefulness of this command. I never use it, and have instead opted to use either graceful-master-takeover or force-master-failover.
force-master-takeover is for when a recovery should be taking place, but is not, and you want to force it, and you also indicate where to failover too.
In my current thinking, is something like this happens I'd rather orchestrator just failed over where it needs to, and the burden of picking a specific destination is a harsh constraint during an outage situation.
Does that makes sense?

@shlomi-noach such as a situation，the old master is very busy，we cant execute GracefulMasterTakeover，but we also want to issue a destination to promote，so we can only use ForceMasterTakeover。

Very good. I'll add the API

@shlomi-noach thx! if you don't have much time, we can do this。

Yes, please.


Ensure minting command doesnt blow the txn size limit

After doing some quick maths, it turns out without gatekeeper on it's impossible to hit the txn size limit, so we can close this issue.


Add Kafka offloader bug fixes and minor improvements

Description
This changes introduces a set of improvements, these incude:

Addressing the Kafka offloader RecordTooLargeException by adding a needed overhead allowance for record key bytes and other Kafka metadata required bytes. Included unit tests
Adjusting the Kafka offloader flush handler to complete its future exceptionally if an error is encountered instead of completing normally
Changed how Kafka properties file argument is used to act as an additional Kafka client customization mechanism rather than an all encompassing properties file
Altered the Kafka offloader to not keep track of its own integer for number of traffic streams and instead have the CaptureSerializer pass the traffic stream index to create more harmony between these two and make debugging between the proxy and replayer have a consistent id (connection-id.traffic stream index)
Adding some default Kafka producer client configuration to lower some timeout values. From what I have seen the retry logic for this Kafka client is robust enough to use for now, and several guides recommend adjusting the timeouts for your use case as needed and not adjusting the retries. As far as the timeout values go, these are still a work in progress. Realistically, this could vary depending on the user's tolerance but the main concern right now is around handling cases where Kafka goes down and we want to impact the normal user's traffic as little as possible as Kafka requests fail. This is more of an issue for mutating requests where we will block responses to users until the Kafka offload future is completed. Ideally we can hand the response back and still block in another way to ensure mutating requests happen properly, but some more investigation needed here.

Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1264
https://opensearch.atlassian.net/browse/MIGRATIONS-1262
https://opensearch.atlassian.net/browse/MIGRATIONS-1213
Testing
Unit testing and manual docker compose testing
Check List

[X] New functionality includes testing

[X] All tests pass, including unit test, integration test and doctest

[X] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I have 2 material comments that I'd like to see addressed.  1) are you sure that you can drop the ctx.close() call and 2) can you add a few more details to the investigation log statement so that users have something more to go on.


About Seesaw loss

Hello, I'm confused that how you get the curve of classificaiton accuracy per class in inference.
Can you give me some suggestions or share the code?

You can send an email to the author of the paper


Windows: running mxnet-model-server for first time is very slow

It hangs for at least a minute. I thought it was totally broken, so I killed the Python process to get my prompt back.
Not sure if this is something related to being on an AMI. I notice that the first time you fire up the frameworks there is a significant lag. However, this is way too long. Everyone will assume it is broken.
Is it possible to give immediate user feedback? Like "Loading..." or "Hang tight..."?

MMS 1.0 working fine with widows.


Test/computer logic

Added some player health tests

I want sleep! Good it is seeming to be looking to be working!


failure: Leap 15.6 -> SLE 15 SP6

zypper in suseconnect-ng
suseconnect -r  YOUR_CODE
suseconnect -p sle-module-basesystem/15.6/x86_64
It complains:  Error: Registration server returned 'The product you are attempting to activate (Server Applications Module 15 SP6 x86_64) requires one of these products to be activated first: Server
suseconnect -p sle-module-server-applications/15.6/x86_64
It complains : Error: Registration server returned 'The product you are attempting to activate (Server Applications Module 15 SP6 x86_64) requires one of these products to be activated first: Basesystem Module 15 SP6 x86_64' (422)

Only one product can be activated at the time. In registered SLE it does work automatically, one product will activate other necessary.
Also suseconnect --list-extensions doesn't list any products, so something else need to be done first. Adjusting /etc/os-release didn't help.
yast2-migration module is doing that without issues (tested on the same virtual machine).

The trick is to install sles-release (or rewrite /etc/os-release) first, otherwise suseconnect will register system as Leap and not SLES. Registration itself will enable initial set of modules including Basystem.
localhost:/home/test # cat /etc/os-release
NAME="SLES"
VERSION="15-SP6"
VERSION_ID="15.6"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP6"
ID="sles"
ID_LIKE="suse"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sles:15:sp6"
DOCUMENTATION_URL="https://documentation.suse.com/"

You can also get rid of leap repos in a similar fashion that we do in openSUSE-repos
https://build.opensuse.org/projects/Base:System/packages/openSUSE-repos/files/openSUSE-repos.spec?expand=1
for repo_file in \
repo-backports-debug-update.repo repo-oss.repo repo-backports-update.repo \
repo-sle-debug-update.repo repo-debug-non-oss.repo repo-sle-update.repo \
repo-debug.repo repo-source.repo repo-debug-update.repo repo-update.repo \
repo-debug-update-non-oss.repo repo-update-non-oss.repo repo-non-oss.repo \
download.opensuse.org-oss.repo download.opensuse.org-non-oss.repo download.opensuse.org-tumbleweed.repo \
repo-openh264.repo openSUSE-*-0.repo repo-main.repo; do
  if [ -f %{_sysconfdir}/zypp/repos.d/$repo_file ]; then
    echo "Content of $repo_file will be newly managed by zypp-services."
    echo "Storing old copy as %{_sysconfdir}/zypp/repos.d/$repo_file.rpmsave"
    mv %{_sysconfdir}/zypp/repos.d/$repo_file %{_sysconfdir}/zypp/repos.d/$repo_file.rpmsave
  fi

I did use zypper dup --allow-vendor-change --force-resolution -y to do migration.
The branding did not get exchanged, so you might need to ensure that these packages are reinstalled manually.
I'd also enable PackageHUB module after each migration to SLES.

Installation of the release package worked. Changing only the /etc/os-release didn't. Maybe more files or directories need to be created. Thanks for tip.

Last issue is branding:
rpm -qa | grep brand
PackageKit-branding-openSUSE-42.1-lp156.4.2.noarch
libsocialweb-branding-openSUSE-42.1-bp156.3.1.noarch
NetworkManager-branding-openSUSE-42.1-lp156.4.2.noarch
plymouth-branding-SLE-15-150600.43.4.noarch
gtk3-branding-openSUSE-15.0-lp156.3.3.noarch
gtk2-branding-SLE-15.0-150400.13.7.noarch
MozillaFirefox-branding-openSUSE-68-lp156.9.2.x86_64
branding-SLE-15-150600.43.4.noarch
gdm-branding-openSUSE-15.1-lp156.3.2.noarch
hicolor-icon-theme-branding-openSUSE-42.1-bp156.3.1.noarch
libreoffice-branding-openSUSE-15.6.20240408-lp156.1.2.noarch
systemd-presets-branding-SLE-15.1-150600.33.1.noarch
systemd-default-settings-branding-SLE-0.10-1503<IP_ADDRESS>.noarch
gio-branding-SLE-15-1506<IP_ADDRESS>.noarch
icewm-theme-branding-1.2.5-1503<IP_ADDRESS>.noarch
gnome-menus-branding-openSUSE-42.1-lp156.3.2.noarch
gtk4-branding-openSUSE-15.0-lp156.3.4.noarch
grub2-branding-SLE-15-150600.43.4.noarch
wallpaper-branding-SLE-15-150600.43.4.noarch
I used
zypper install --force-resolution --allow-vendor-change rpm -qa | grep branding-openSUSE | sed  "s/-openSUSE.*/-SLE/" | tr '\n' ' '
but it does't replace openSUSE branding and some are unavailable in SLE.

Resolved branding best as could. Some openSUSE branding can't be removed because it's not sure what channels would user use.


Collapsable Markdown Headers/Lists

Has anyone experimented with enabling Headers or lists in markdown to be collapsible/expandable as they are in Obsidian or Roam Research?
For very long posts this would be a very nice addition, making it easier for the reader to get a feel for the post as a whole and compartmentalize it in the way the author intended.

You could consider adding a rehype plugin that nests the contents under a header to a details tag


fix: do not scroll to bottom of page when opening modal menus

Closes https://github.com/reakit/reakit/issues/819
~This change adjusts the move behavior on MenuButton to wait a tick before triggering, thus ensuring React can render the menu on the screen and preventing a scroll jump.~ Trying a different approach that feels a bit better. The issue came down to popper briefly rendering the popover content on screen in the document flow (it quickly applies appropriate styles on second tick). What I did to resolve is to set the initial popper styles to fixed position so that it doesn't affect document flow.
I also do not think that createPopper needs to be called unless dialog.visible is true, which saves a bunch of unnecessary work.
It also has the nice benefit of enabling lazy menus along the lines of the below. This is particularly helpful for situations such as file system trees, where hundreds of menus are attached to items in the tree and do not need to be rendered until the user interacts with the item.
import {
  useMenuState,
  Menu,
  MenuItem,
  MenuButton,
  MenuSeparator,
} from "reakit/Menu";

export function Example() {
  const menu = useMenuState();
  return (
    <>
      <MenuButton {...menu}>Preferences</MenuButton>

      <ExampleContents menu={menu}>
        <MenuItem {...menu}>Settings</MenuItem>
        <MenuItem {...menu} disabled>
          Extensions
        </MenuItem>
        <MenuSeparator {...menu} />
        <MenuItem {...menu}>Keyboard shortcuts</MenuItem>
      </ExampleContents>
    </>
  );
}

function ExampleContents({ menu, children }) {
  let [shouldRender, setShouldRender] = React.useState(menu.visible);

  React.useEffect(() => {
    if (shouldRender !== menu.visible) setShouldRender(menu.visible);
  }, [menu.visible, shouldRender]);

  /**
   * Performance improvement by not rendering menus until they're opened.
   * Need the extra shoudlRender/useEffect tick for reakit to properly switch focus etc on submenus
   */
  if (!menu.visible && !shouldRender) return null;

  return (
    <Menu {...menu} aria-label="Preferences">
      {children}
    </Menu>
  )
}

Does this PR introduce breaking changes?
No

Thanks for working on this @marbemac! I'll take a look at it this weekend (hopefully).

Thanks for working on this @marbemac! I'll take a look at it this weekend (hopefully).

I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix!

I'm also hitting this issue on a regular basis, it can be quite jarring on a long page – thanks for taking on the fix!


bring all new doc chapters into MITgcm live version

Please check that the PR fulfils our requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What changes does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behaviour?
(You can also link to an open issue here)
What is the new behaviour
(if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:

A couple of comments:

the examples/ directory is missing
we were going to keep seaice.rst and ocean_state_est.rst out of this PR so that Gael and Martin could put them in

Sorry jumped the gun the on that. There are a number of urls that need to have AltMITgcm changed to MITgcm.

On Feb 6, 2018, at 10:53 AM, Ed Doddridge <notifications<EMAIL_ADDRESS>wrote:
A couple of comments:

the examples/ directory is missing

added

we were going to keep seaice.rst and ocean_state_est.rst out of this PR so that Gael and Martin could put them in

—
I copied over what Gael had done, but feel free to sub out.

to: jrscott
I thought Oliver did fix this (+ few MITgcm66* ) yesterday in atlMITgcm
repository (in MITgcm/doc). But may be the files in this PR are not coming
directly from there ?
On Tue, Feb 06, 2018 at 03:56:42PM +0000, Ed Doddridge wrote:

Sorry jumped the gun the on that. There are a number of urls that need to have AltMITgcm changed to MITgcm.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MITgcm/MITgcm/pull/8#issuecomment-363467372

On Feb 6, 2018, at 10:56 AM, Ed Doddridge <notifications<EMAIL_ADDRESS>wrote:
Sorry jumped the gun the on that. There are a number of urls that need to have AltMITgcm changed to MITgcm.
Yes, aware of that… I’m out for a bit but if you need me to do this I’ll have a free hour or so later today.
Jeff

I'm happy to fix the urls and remove the bits for Gael and Martin to add later.

LGTM

Significant changes need to be documented in tag_index.
I don't see it (but might be wrong).
On Tue, Feb 06, 2018 at 08:09:17AM -0800, jrscott wrote:

On Feb 6, 2018, at 10:53 AM, Ed Doddridge <notifications<EMAIL_ADDRESS>wrote:
A couple of comments:

the examples/ directory is missing

added

we were going to keep seaice.rst and ocean_state_est.rst out of this PR so that Gael and Martin could put them in

???
I copied over what Gael had done, but feel free to sub out.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/MITgcm/MITgcm/pull/8#issuecomment-363472129

@edoddridge I got
/Users/chrishill/projects/mdoc-sphinx/doc/index.rst:19: WARNING: toctree contains reference to nonexisting document u'ocean_state_est/ocean_state_est'
/Users/chrishill/projects/mdoc-sphinx/doc/phys_pkgsI/phys_pkgsI.rst:115: WARNING: toctree contains reference to nonexisting document u'phys_pkgsI/seaice'

maybe remove these until those sections are back?
There are lots of other warnings, so we could just ignore these also? They will go once Martin and Gael put stuff back.

@edoddridge and @jrscott maybe also something slightly broken in figure
/Users/chrishill/projects/mdoc-sphinx/doc/phys_pkgsI/gmredi.rst:446: WARNING: Error in "figure" directive:
1 argument(s) required, 0 supplied.

.. figure::
    :width: 70%
    :align: center
    :alt: Mixed layer depth with GM
    :name: mixed_layer

    **Figure missing** Mixed layer depth using GM parameterization with a) Cox slope clipping and for comparison b) using horizontal constant diffusion.

I think this has been missing a while (see - http://altmitgcm66h.readthedocs.io/en/latest/phys_pkgs/gmredi.html#tapering-large-danabasoglu-and-doney-jpo-1997 ), but be good not to forget to fix.
If its easy to fix in this PR that might be good?

@christophernhill - I'd be inclined just to ignore those warnings for now. They don't break anything, and the files will be added imminently.
As for that empty figure, that file has been missing the whole time. When I originally converted that section I left the figure environment there to ensure we didn't forget about it. Is it important enough to reproduce, or should we just delete it?
@jm-c - I must have misunderstood yesterday. I thought we weren't going to put doc changes into tag-index, except for the one noting the move to Sphinx based documentation.

I'm OK leave the figure and the toctree bits hanging at this stage.
I'll leave it to you two @edoddridge and @jm-c to decide on tag-index.
LGTM otherwise.

replaced by new PR #10


Add an nbody demo

This can serve as a benchmark. It also includes a (pretty crude) visualizer currently based on SDL. It should maybe be ported to use OpenGL or something fancier. The visualizer should also report FPS and be switchable between par and seq and a few other things :)
cc #35

Nice! I tried it on OS X, and the window didn't show up for me :(
I'm having a go at implementing the visualiser in glium, I hope that's ok!

@bjz that'd be awesome. I was sort of hoping somebody would do that. ;) I think I will land this PR in the meantime.
(That said, I am testing this on OS/X, so I'm surprised the window didn't show up for you.)

:+1:
I'll also try to clean up the argument parser ;)


Fix propquery handling in EVP_DigestSignInit_ex

Fixes #14183. Fix the condition to detect legacy engines, so the props are considered even when libctx == NULL.

This pull request is ready to merge

Thanks for fixing this. Merged to master.


Python: OOP-object

Description :
What is object in python?
Note :

Changes should be made inside the Python/ directory & Python branch.
Issue only for GWOC'21 contributors.
Issue will be assigned on a first come first serve basis, 1 Issue  ==  1 PR.
In the PR, keep this issue's title as your PR's title.

Must Follow : Contributing Guidelines & Code of Conduct before start Contributing.

I would like to work on this please documentation
Peddi sai lohith
Python batch 4

I would like to work on this!! @adityabisoi

I would like to work on this!!

I would like to work on this issue via documentation. Thank you!!

Hi I'd like to contribute through documentation on this topic
Harmandeep - python - batch 4

I would like to work on this issue via documentation.

@kumarankm Is the mentor of this issue. Please reach out to him in case of queries.

/assign Audio

@adityabisoi  please assign for the video contribution on this issue


SignerType::Ephemeral

The goal of this PR is allowing each proposal to create one account using system_program::create_account. To use system_program::create_account, the account that gets created needs to sign. To enable this we add an extra PDA seeded by [b"proposal_extra_account", proposal_id]. If this PDA is in the instructions of the proposal, spl-governance will sign on behalf of this PDA.
The main motivation of making this PR is that some Solana programs require you to create accounts and giving them to the program before interacting with the program. A notable example is wormhole where sending a message requires you to provide an account as a signer where the wormhole message will be written.
This should allow spl-governance to send 1 wormhole message per proposal, making cross-chain governance possible.

The goal of this PR is allowing each proposal to create one account using system_program::create_account.

This is a great solution to the problem of accounts creation in proposal instructions but I think allowing to create only a single account per ProposalTransaction is too restrictive and we can extend it to any number of accounts.
In order to minimise the changes and make it backward compatible we could do the following:

Change AccountMetaData.is_signer from bool to signer:SignerType enum where the enum would be defined as follows:

SignerType {
   None,
   Static,
   Ephemeral
}

https://github.com/solana-labs/solana-program-library/blob/944bb968f3a42af3f6606bb91bba90ade2e54792/governance/program/src/state/proposal_transaction.rs#L44
With the enum we would have:

None - the account is not a singer and the value is backward compatible with false
Static - the account is normal signer and the value is backward compatible with true
Ephemeral - the account is ephemeral signer and is only used during ProposalTransaction execution. It would be a PDA with the seeds: ['ephemeral-signer',proposal_transaction_pubkey,account_seq_number_le_bytes] where account_seq_number_le_bytes would be u16 consecutive number of the given ephemeral signer account within the ProposalTransaction account list across all the instructions in the transaction.

When executing ProposalTransaction instructions add the signer seeds for ephemeral signers if the given instruction needs them
It won't be necessary to define ProposalExtraAccount because we would never create the ephemeral signer accounts https://github.com/solana-labs/solana-program-library/blob/dd290427bbe0782542a40cdc8bb70fccfd139c89/governance/program/src/state/proposal_extra_account.rs#L14

Please let me know what you think

I'm revisiting this PR after applying the feedback.
Ephemeral signers are a feature for proposals to be able to request extra PDAs from the governance contract that will sign the transaction execution.
The user workflow is :

At insert_transaction, the user declares the account as signer: SignerType::Ephemeral. The pubkey of this account does not matter.
Each SignerType::Ephemeral will be replaced by a unique PDA seeded by proposal_transaction_pubkey and its rank among the transactions' accounts with SignerType::Ephemeral
When calling execute_transaction the ephemeral signers will sign the transaction.


feat: poseidon hash

closes #75
It changes the following:

add Poseidon hash function
add sage script modified from original constant generator script for testing purposes

@Autoparallel done with the changes, it looks really cool now, and most of the previous state transition errors are now detected at compile time which is so cool :)
thanks for this suggestion.


Update bundler version to 2.0

Is your feature request related to a problem? Please describe.
Currently, bundler version 1.17 is being used. Updating it to 2.0 is required.
Describe the solution you'd like
Refer this guide for steps to update to bundler v2.
Are you working on this? (Yes/No)
No

Fixed in #621


[usr-generation][print-as-objc] Namespace @objc (clang-style) USRs with the swift module name

This patch prefixes the clang-style USRs of @objc symbols with the swift module name to avoid USR collisions between symbols from different Swift frameworks with the same name. It also updates PrintAsObjC to add the new clang external_source_symbol attribute (with the swift module name) on the generated ObjC decls so that clang's USR generation can add the prefix too.
At the moment this is done by:

adding the swift module name as an extra argument to the various SWIFT_CLASS, SWIFT_PROTOCOL, and SWIFT_ENUM macros already on top-level decls
adding a new SWIFT_MODULE(_module) macro that expands to the attribute on top-level function decls
adding a SWIFT_GENERATED object-like macro to the members of categories, which don't support attributes themselves. The module name isn't needed in this case as the USRs of these members are based on the original interface, which should have the attribute.

The plan is to move to using the new pragma under review at https://reviews.llvm.org/D30009 when it lands, so there isn't as much noise in the header (especially for categories), but this lets us progress for now.

Resolves rdar://problem/30645863.

@swift-ci please smoke test

@swift-ci please smoke test

This is overridden by https://github.com/apple/swift/pull/8972


Collect and scrape known databases for food types

Add list of links here for known databases/information:

Global Nutritional study
Common food allergies
top 10 food allergies
Database of allergens
Peer reviewed allergen list
Food allergen portal
COMPARE database

Need to scrape these!

I started with just added a bunch of known dietary types, and then all the allergies I have 😉

Hello, I'd like to .take this issue.
Would you like additional links/files for known allergen data or would you like the data mentioned above compiled and organized into one large dataset?


Additional config file parse

Bring back the additional config file parsing feature.

/azp run Mac BuildXL PR Validation


parquet-tools doesn't filter _SUCCESS file

Currently parquet-tools command fails when input is a directory with _SUCCESS file from mapreduce. Filtering those out like ParquetFileReader does fixes the problem.
parquet-cat /tmp/parquet_write_test
Could not read footer: java.lang.RuntimeException: file:/tmp/parquet_write_test/_SUCCESS is not a Parquet file (too small)

$ tree /tmp/parquet_write_test
/tmp/parquet_write_test
├── part-m-00000.parquet
└── _SUCCESS

Reporter: Neville Li / @nevillelyh
Note: This issue was originally created as PARQUET-142. Please see the migration documentation for further details.

Ryan Blue / @rdblue:
Issue resolved by pull request 89
https://github.com/apache/incubator-parquet-mr/pull/89


Benchmark discovery project version suboptimal

The benchmark discovery seems to be run currently against whatever version was last active.
This is sometimes sub-optimal:

Benchmarks may have imports written for the current project version, which fail for earlier version
If the last version happens to result to build failure, all following asv operations will just fail

Perhaps best would be to give a config option that determines this, or just always check out master branch first.

This was done to be fast about discovering benchmarks, though with ccache and wheel cache support (almost) in place it's now less of an issue, and I think always checking out master will be the right thing in the majority of cases.
At the end of the day, though, benchmarks need to be written to be importable across all versions of the underlying project's API, and if there's a project commit in which the benchmarks fail to import, the benchmarks haven't been written correctly.  So we should probably:

Handle ImportError during the importing of the benchmark suite when a benchmark is about to be run as a bigger error than just a "failed test" to flag that the benchmark suite probably needs some tweaking.

Add a documentation note about that on the "writing benchmarks" page that the benchmark suite should be importable across API versions of the underlying project, and some strategies for that.


Mm counts2counts design issue

Resolve issue #165

Error in test_import:
/ifs/devel/andreas/cgat/scripts/clusters2metrics.py ... FAIL
AssertionError: clusters2metrics scripts/modules - ImportError: No module named Timeseries
Merge delayed.

import statement fixed with commit c5eead162801af9153bd1afba4f8088225d6ecee

Thanks. There are errors in counts2counts:
======================================================================
FAIL: tests/wig2wig.py/version
Traceback (most recent call last):
File "/ifs/apps/apps/python-2.7.9/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/ifs/devel/andreas/cgat/tests/test_scripts.py", line 178, in check_script
ok_(not fail, msg)
AssertionError: error in statement: /bin/bash -c 'gunzip < /ifs/devel/andreas/cgat/tests/counts2counts.py/counts_small.tsv.gz | python /ifs/devel/andreas/cgat/scripts/counts2counts.py  --design-tsv-file=/ifs/devel/andreas/cgat/tests/counts2counts.py/design2.tsv --method="spike" --spike-type="row" --spike-maximum=1 --spike-change-bin-width=100 --spike-initial-bin-width=10 --spike-change-bin-max=10000 --spike-initial-bin-max=10 --difference-method=relative --random-seed=1234567890 -v0 > /tmp/tmpl17iWC/stdout'; stderr=Traceback (most recent call last):
File "/ifs/devel/andreas/cgat/scripts/counts2counts.py", line 531, in
sys.exit(main(sys.argv))
File "/ifs/devel/andreas/cgat/scripts/counts2counts.py", line 512, in main
options.max_spike, options.iterations)
File "/ifs/devel/andreas/cgat/CGAT/Counts.py", line 315, in shuffleRows
tracks_map[groups[0]]].apply(
IndexError: list index out of range
======================================================================
FAIL: tests/wig2wig.py/version
Traceback (most recent call last):
File "/ifs/apps/apps/python-2.7.9/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/ifs/devel/andreas/cgat/tests/test_scripts.py", line 178, in check_script
ok_(not fail, msg)
AssertionError: error in statement: /bin/bash -c 'gunzip < /ifs/devel/andreas/cgat/tests/counts2counts.py/counts_small.tsv.gz | python /ifs/devel/andreas/cgat/scripts/counts2counts.py  --design-tsv-file=/ifs/devel/andreas/cgat/tests/counts2counts.py/design2.tsv --method="spike" --spike-type="row" --spike-maximum=1 --spike-change-bin-width=1 --spike-initial-bin-width=10 --spike-change-bin-max=10 --spike-initial-bin-max=10 --random-seed=1234567890 -v0 > /tmp/tmpNRwCG8/stdout'; stderr=Traceback (most recent call last):
File "/ifs/devel/andreas/cgat/scripts/counts2counts.py", line 531, in
sys.exit(main(sys.argv))
File "/ifs/devel/andreas/cgat/scripts/counts2counts.py", line 512, in main
options.max_spike, options.iterations)
File "/ifs/devel/andreas/cgat/CGAT/Counts.py", line 315, in shuffleRows
tracks_map[groups[0]]].apply(
IndexError: list index out of range

Counts2counts.py has been modified on branch TS-Counts2countsRewrite and is passing tests.
Branch MM-counts2counts_design_issue has therefore been merged into TS-Counts2countsRewrite.


Enabled "Type hints (PEP 484) support for the Sphinx autodoc extension"

With this PR, the Sphinx docs would look nicer because type hints migrate from the method signature to each parameter.
Now:

With this PR:

Also, from now on, I'd suggest to remove ":type" information from the docstring, which is redundant because the type hint is already there in the method signature.
In the example below, we can safety remove ":type candidate_classes: list" and ":type parallelism: int" from the docstring.

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   82.41%   82.41%
=======================================
  Files          86       86
  Lines        4361     4361
  Branches      808      808
=======================================
  Hits         3594     3594
  Misses        576      576
  Partials      191      191

Flag
Coverage Δ

#unittests
82.41% <ø> (ø)

Enabling "sphinx_autodoc_typehints" generates a lot of deprecation warnings like "RemovedInSphinx40Warning: sphinx.util.inspect.Signature() is deprecated."
This issue has been reported at https://github.com/agronholm/sphinx-autodoc-typehints/issues/133 and is now being addressed by that community.
Thus, I don't think there is much to worry about.


Enhancements to the Cortex-A/R AArch32 architecture

Is your enhancement proposal related to a problem? Please describe.
When I separated the Cortex-M and Cortex-A/R aarch32 architecture code, I found some improvements that can be made. So I list them here for me or other interested people.
Describe the solution you'd like

SMP support for Cortex-A/R
Refine the exception entry and exit code
Distinguish interrupt nested count and exception nested count.

Additional context
More details for the list above.

SMP support for Cortex-A/R

[x] Implement USE_SWITCH https://github.com/zephyrproject-rtos/zephyr/pull/61206
[x] Implement SMP https://github.com/zephyrproject-rtos/zephyr/pull/61206
[ ] Implement USERSPACE with USE_SWITCH and SMP
[ ] Implement FPU_SHARING with USE_SWITCH and SMP
[ ] Deprecate arch_swap

[x] Refine the exception entry and exit code. https://github.com/zephyrproject-rtos/zephyr/pull/61206
Cortex-A/R arch32 has 5 exceptions. svc, fiq, irq, abt, und. The exception entry and exit code can be unified.

[x] Distinguish interrupt nested count and exception nested count.
For now, The Cortex-A/R code doesn't distinguish interrupt nested count and exception nested count. It will cause some issues with the context switch. For example, when IRQ occurred in an SVC handler routing, a context switch could happen after handling IRQ, but now it cannot occur because of nested count >= 1.

Awesome! I would like to help with this, I'm currently working on a project using the RP2040, one of the only duel core M's around. I can give the PR a spin with my hardware if that would be helpful?
If there is any other way I can be of assistance I'm all ears.

Awesome! I would like to help with this, I'm currently working on a project using the RP2040, one of the only duel core M's around. If I give the PR a spin with my hardware would be helpful?

So, I guess you must be interested in this https://github.com/zephyrproject-rtos/zephyr/issues/59826 @o7-machinehum

@SgrrZhf The linked issues in the description here have all been merged. Is there remaining work, or can this issue be closed?

Yes, most of these have been finished. But there is something left, I marked them out in the description.


ContainerTask fix to read base env vars properly from compilation settings

TL;DR
Bug in container task that wasn't being hit unless user specifies an additional env var map in the task.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Fix npe.
Tracking Issue
User reported issue:
https://discuss.flyte.org/t/2749411/what-s-your-gh-handle-U03KEF8H6FR

cc @ fredrickprashanth

cc @fredrickprashanth


switching audio output device doesn't work

As the title says, I launched the game and the default sound output was the speakers. After I connected my headphones and switched the audio output from the menu bar, the game still was playing the sound through the speakers.
It only used the default player from when you start the launcher and doesn't switch mid way according to system settings.

Probably should be reported to upstream i.e. crossover/wine. I can't fix it.

This is a known issue that still exists to this day, you have to change the audio output before open the game.


Improve add template type flow

Describe the Issue:
Currently the adding an email template type will redirect the user to a blank listing view of the locales listing of the newly created email template type. As an improvement this flow could have steps such as adding an initial locale template with boilerplate template while creating the template type.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fixing rvm error and Docker file format for travis login

What type of PR is this?
/kind bug
What does does this PR do / why we need it:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/10942/rehearse-10942-pull-ci-openshift-odo-master-macOS-testmasoshost/1297231399283068928#1:build-log.txt%3A280
Which issue(s) this PR fixes:
Fixes - It will fix the docker build issue for pr https://github.com/openshift/release/pull/10942
PR acceptance criteria:

[ ] Unit test : NA

[ ] Integration test : NA

[ ] Documentation : NA

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:
pr https://github.com/openshift/release/pull/10942 should not fail with error: build error: running 'rvm requirements run' failed with exit code 127

/lgtm

NOTE: Changes does not break the master


Fix error in bulk retrieval

Thanks to fthiel who spotted the cause of the failure!
Fetching the bulk list with dynasynthetic_cli.py didn't work.

Pull Request Test Coverage Report for Build 25

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.587%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

dynasynthetic/DynatraceSyntheticAPI.py
0
1
0.0%

Totals

Change from base Build 23:
0.0%

Covered Lines:
199

Relevant Lines:
358

💛  - Coveralls


Revert "Revert "Revert "Revert "Revert "6"""""

Reverts pwittrock/najena#28

rollout:uswest

rollout:uswest


nix-prefetch-scripts: Split into multiple derivations

This makes it possible to e.g. only install nix-prefetch-git and not the
others.
Closes #7399.

Thanks! This is nice!

Now uses buildEnv.

IMHO it would be cleaner to submit the change to pkgs/build-support/buildenv/default.nix in a separate PR. That change is orthogonal to the one to nix-prefetch-scripts.

Switched to preferLocalBuild for nix-prefetch-*. buildEnv does it already for the nix-prefetch-scripts derivation.

The buildEnv change went in #11362; rebased on top of that merge.

Anyone dare to hit the merge button? @bennofs?

The build fails because of
hash mismatch in downloaded path ‘/nix/store/a45l8r0zqfr5jhqswqqcya28h59n63js-python2.7-setuptools-18.2’: expected 563b3d1b693c5579ef6f05544ff72fc30a26e13e506ee5265eea81081c331b6d, got 50db90fe916eca8cbba2f3a1a00dae35c4f3d40a25ff693487938bf38ae8ff3a

Does this error occur for you as well? It doesn't seem to be related to you changes, though.

It's reportedly a hydra issue, others have been reporting that in IRC as well

I rebased it to master-commit-that's-hopefully-next-unstable and that error is gone.


Demonstrate /run lint command

/run lint feedstock_spec=pangeo-forge/staged-recipes/pull/66 head_sha=3b9d3fa151b6e6e12b837af391ed38f159c7fd8d

:thinking: Hmm, we don't see a recipe.py and/or a meta.yaml file...
Note: This comment was posted automatically by the Pangeo Forge Registrar on behalf of @cisaacstern.

/run lint feedstock_spec=https://github.com/pangeo-forge/staged-recipes/pull/66 head_sha=3b9d3fa151b6e6e12b837af391ed38f159c7fd8d

/run lint feedstock_spec=https://github.com/pangeo-forge/staged-recipes/pull/66 head_sha=3b9d3fa151b6e6e12b837af391ed38f159c7fd8d


Multiple array items type validation with oneOf, anyOf

Hi everyone,
I've encountered a problem to validate multiple items type in an array.
We have an array with 2 items types. We try to validate each item to 2 different schemas types.
Here is the schema:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "properties": {
    "transfer": {
      "type": "object",
      "properties": {
        "modes": {
          "type": "array",
          "minItems": 1,
          "additionalItems": false,
          "items": {
            "oneOf": [
              {
                "type": "object",
                "properties": {
                  "mode": {
                    "enum": [
                      "ftp"
                    ]
                  },
                  "account": {
                    "type": "string",
                    "pattern": "^[a-f|0-9]{8}$"
                  }
                },
                "required": [
                  "mode",
                  "account"
                ],
                "additionalProperties": false
              },
              {
                "type": "object",
                "properties": {
                  "mode": {
                    "enum": [
                      "email"
                    ]
                  },
                  "mailingList": {
                    "type": "string",
                    "pattern": "^[a-f|0-9]{8}$"
                  }
                },
                "required": [
                  "mode",
                  "mailingList"
                ],
                "additionalProperties": false
              }
            ]
          }
        }
      },
      "required": [
        "modes"
      ],
      "additionalProperties": false
    }
  },
  "additionalProperties": false,
  "required": [
    "transfer"
  ]
}

And the data:
{
  "transfer": {
    "modes": [
      {
        "mode": "ftp",
        "account": "e69b3f54"
      },
      {
        "mode": "email",
        "mailingList": "c3d12752"
      }
    ]
  }
}

I tried to validate the data against the schema to different online tools:
http://json-schema-validator.herokuapp.com/index.jsp
http://jsonschemalint.com/draft4/#
All these tools validate successfully my data
It's like the validator try to match the 1st item to the 1st schema and the second item to the second schema. Order should be not important.
I use version 3.8.1.
Could you help me ?
Thank you in advance

When I remove the configuration  "additionalProperties": false from the type definition on "oneOf" the problem disappear.

What are your ajv options? I suspect you may be using removeAdditional option. Without it it validates ok: https://tonicdev.com/esp/56d57c034b05fd0c00e8978b
If that is the case this issue is essentially a duplicate of #129 and it is an expected behaviour according to the JSON-schema standard.

I would suggest refactoring the schema to take the duplicated keywords and all property definitions apart from required out of oneOf:
"items": {
  "type": "object",
  "properties": {
    "mode": {
      "enum": [
        "ftp"
      ]
    },
    "account": {
      "type": "string",
      "pattern": "^[a-f|0-9]{8}$"
    },
    "mailingList": {
      "type": "string",
      "pattern": "^[a-f|0-9]{8}$"
    },
    "additionalProperties": false
  },
  "oneOf": [
    { "required": [ "mode", "account" ] },
    { "required": [ "mode", "mailingList" ] }
  ]
}

This way it will correctly work with removeAdditional option

You are right @epoberezkin !
AJV is configured with removeAdditional -> true. The schema has been refactored to avoid multiple definitions inside oneOf, like you suggested and it's working.
Thank you @epoberezkin for your support !

You're welcome. I'll add a note in readme about it :)

I noticed the original schema would not validate an object containing both account and mailingList properties (that's expected), while the later refactored schema does.
Is there any workaround for this?

You can use { "not": { "required": ["account"] } } to explicitly prohibit property account.

@epoberezkin Sorry to revive this but what if you do need to reference external schemas in oneOf and can't really split them like your proposed solution?
To take the above example with ref:
{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "type": "object",
  "properties": {
    "transfer": {
      "type": "object",
      "properties": {
        "modes": {
          "type": "array",
          "minItems": 1,
          "additionalItems": false,
          "items": {
            "oneOf": [
              { "$ref": "ftp" },
              { "$ref": "email" }
            ]
          }
        }
      },
      "required": [
        "modes"
      ],
      "additionalProperties": false
    }
  },
  "additionalProperties": false,
  "required": [
    "transfer"
  ]
}

Thanks!

Btw, "additionalItems": false does nothing unless the schema in items keyword is an array.
The solutions to additionalProperties limitations are:

don't worry about additionalProperties and simply allow them. I think the obsession with removing them is not always justified, in many cases you make your life MUCH easier by allowing them (especially when you have multiple applications using the same data/schema).
refactor schemas as suggested above
use v5 switch keyword instead of anyOf - it allows to control what is validated based on some conditions (so only correct properties will be treated as additional)
use $merge/$patch keywords to extend schemas rather than joining them with compound keywords such as anyOf etc.

Please see FAQ that points to other related issues that show these approaches to using additionalProperties.

schema:
"items": {
  "type": "object",
  "properties": {
    "mode": { "enum": [  "ftp" ]
    },
    "account": { "type": "string" },
    "mailingList": { "type": "string" },
    "otherProp": { "type": "string" }
  },
  "additionalProperties": false,
  "oneOf": [
    { "required": [ "mode", "account" ] },
    { "required": [ "mode", "mailingList", "otherProp" ] }
  ]
}

data:
{
  "transfer": {
    "modes": [
      {
        "mode": "ftp",
        "account": "e69b3f54",
        "mailingList": "c3d12752",
      },
      {
        "mode": "email",
        "mailingList": "c3d12752"
      }
    ]
  }
}

It will validate pass. How to use { "not": { "required": ["account"] } } ?

I don’t understand the question - what are you trying to achieve? “not” can be a sibling to required and any other keyword, if that’s what you are asking.
Also it as a general JSON schema question - it should be posted to Stack Overflow.

https://github.com/epoberezkin/ajv/issues/134#issuecomment-190680773
I cannot express enough that this is an actual bug in the removeAdditional implementation that interferes with backtracking, it is not just a valid speed optimization. The removeAdditional must only remove properties after the anyOf decided on which branch to take in the matching. If any backtracking is still ongoing, no properties should be removed. As I read through your comments in related issues, I will not be able to convince you about this though :smile:
In the workaround you provided above, if I fix the mode property (discriminator) to what it was in the schema OP posted:
...
"mode": {
  "enum": [
    "ftp",
    "email"
  ]
},
...

I also had to modify the oneOf
"oneOf": [
  { "mode": { "enum": [ "ftp" ] }, "required": [ "mode", "account" ] },
  { "mode": { "enum": [ "email" ] }, "required": [ "mode", "mailingList" ] }
]

otherwise it validates something with mode: email and having an account property. It works now, but cannot be modularized by using refs inside the oneOf as OP already mentioned.
See the working fix: https://runkit.com/wigy-opensource-developer/ajv-remove-additional-gotcha

@wigy-opensource-developer I understand that the way removeAdditional option is defined may be not fit for your purposes, it’s a much simpler thing that you want it to be.
It is consistent though with how additionalProperties keyword is defined in JSON Schema spec and it’s a conscious design choice.
What is important the behaviour that is created by “removeAdditional” option is not part of JSON Schema spec.
I am not sure what do you mean by “backtracking“ - Ajv does no such thing. Also anyOf does not at any point decide which branch to use to match against the data - it simply follows the algorithm prescribed by the specification, which is to validate the data against all branches and if the data is valid against at least one branch, then the data is valid against anyOf keyword - it’s simply Boolean “or” operation on the validation results against all subschemas. At no point any decision is made about one branch “matching” the data better than the other.
Also JSON Schema has no concept of “discriminator” - it only exists as part of OpenAPI spec in connection with oneOf keyword (not anyOf) and even there, reading their spec, from the validation point of view “discriminator” is no-op - it is only their to optimise, support tools, choose the branch that is possibly correct based on one property and have more helpful error reporting - but its presence should have no effect on validation result (as in valid/invalid). We can discuss it further, but it’s my reading of OpenAPI spec.
There is a ticket https://github.com/epoberezkin/ajv/issues/1119 that is about “discriminator” and how it could be supported by Ajv to improve error reporting and optimise validation process. As a side effect it would also lead to changes in removeAdditional behaviour that would make it closer to what you want (unless it’s prevented). I am not 100% sure yet whether it is a good or bad thing, it would definitely make it more confusing though. So it has to be considered in the context of that ticket by whoever implements it.

Thanks for your time to explain all these. Many people who just try to build on their computer science backround of algebraic types or who just used to work with unions in C or enums in Rust will have to relearn this working with Ajv.
How I see now is that if a developer has a choice to define their own schema (which is of course not always the case), they should rather use a key as a discriminator rather than a value.
{
  "modes": {
    "ftp": { "account": "blah" },
    "email": { "mailingList": "foobar" }
  }
}

I completely agree that JSON Schema is very counter-intuitive to anybody who has CS background and expects it to be in any way similar to algebraic types (frankly, it is confusing to almost anybody who adopts it - many design decisions of JSON Schema are counter-intuitive).
I’ve been trying to make this point to the community behind JSON Schema spec, on many occasions, but the attempts to reconcile it only made it worse resulting in draft-08...
So, unfortunately, it’s not Ajv issue that I can address without abandoning JSON Schema spec - it is the fundamental issue of the specification itself.
Still, I strongly believe that somewhat confusing, but widely adopted and well documented spec, that it supported, at least partially, across many languages and platforms, is much better than ad hoc decisions about schema language made on a library level - there are many such libraries and none of them is widely adopted or cross-platform.
It is a shame that JSON Schema, in my opinion, is in some evolutionary dead end at the moment (I am referring to draft-08) - I do hope that it will be resolved in due course.
I do think that draft-07 is quite usable though, and once you accept its restrictions and differences with type systems it can be used and give you a lot of value. There is no point trying to make it into what it’s not, it just requires a bit of understanding and acceptance... Some developers don’t author JSON Schemas directly - instead they compile typescript types into schemas to do run-time validation - this approach makes lots of sense to me.
Hope it all makes sense, and if you want to contribute to discriminator implementation (the issue I referenced) it will likely address this issue as well.
cc @relequestual

On 12 Dec 2019, at 06:56, wigy<EMAIL_ADDRESS>wrote:

Thanks for your time to explain all these. Many people who just try to build on their computer science backround of algebraic types or who just used to work with unions in C or enums in Rust will have to relearn this working with Ajv.
How I see now is that if a developer has a choice to define their own schema (which is of course not always the case), they should rather use a key as a discriminator rather than a value.
{
"modes": {
"ftp": { "account": "blah" },
"email": { "mailingList": "foobar" }
}
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I have just handled like this for now with sass:
Maybe it will benefit some
.error-detail {
.text-danger{
display: none;
&:first-child{
display: block;
}
}
}


refactor: replace linkme with inventory

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#15407
#15631  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on  Graphite

Does not help for #15407, even with #[used(linker)]. Not sure if there's something wrong with the system linker. 🤡


Update property "variant" dynamically inside "render" method

Hello,
I'm trying to set "variant" property dynamically based on the content.
https://react-tooltip.com/docs/examples/variant
Could you please let me know if it's feasible or any other better way to do it ?
Please find the code here -> https://codesandbox.io/s/eager-glitter-nc5nqp
Code snippet where I'm trying to make the change is as shown below.
`
  <Tooltip
    id="package-status-tooltip"
    place="bottom"
    delayShow={300}
    render={({ content, activeAnchor }) => {
      /** Rendering dynamic content*/
      /**
       * I would like to update tooltip varient property based on the content value
       * INFO -> DARK
       * ERROR -> error
       * Success -> success
       */
      return (
        <div className="flex flex-col max-w-lg">
         {content}
        </div>
      );
    }}
  />

`

Use data-tooltip-variant. https://codesandbox.io/s/busy-tdd-7twch0?file=/src/App.js

thank you so much @gabrieljablonski !!


Asymmetric Sync

Add Support for asymmetric sync. When an object inherit from AsymmetricObject is immediately
marked as asymmetric, upon creation this objects is sync'd unidirectionally and cannot be query
locally.
    class PersonObject: AsymmetricObject {
       @Persisted(primaryKey: true) var _id: ObjectId = ObjectId.generate()
       @Persisted var name: String
       @Persisted var age: Int
    }

    try realm.write {
       let person = PersonObject(name: "Dylan", age: 20, isFavorite: true)
       realm.create(person) // This will create the object and sync'd unidirectionally.
    }

@tgoyne seems like the CI failures doesn't have anything to do with the PR, I don't know the reason the test are not able to execute.


Invalid handling of parentheses

Parentheses seem to be handled incorrectly, it seems like they get ignored and the calculation is just run left to right. The odd thing is that with some calculations they work like they are suppose to work, but for most they seem to be ignored.
Example:

I'm running Kubuntu 19.04 (KDE), and I'm using the deb version.

After messing around with the source code it seems that the issue is caused by main.js. coreCalc.evalExp, would give the correct result if the parentheses where still in the argument provided, but main.js removes them.
This is why coreCalc.test.js shows no errors, since there is nothing wrong with the actually calculations, but rather an issue with the provided expression not getting passed to coreCalc correctly.
Console output:

In latest build, it's working perfectly fine.


Tile chart highlight by group on mouse over

Currently, it's not possible to highlight the tiles by group on mouse over.
The idea is to add 'group-over' class to all the tiles of the group when the mouse is over one of the tiles of the group.

This is implemented and merged. I'll close it


outDuration: 0 crashes animsition on Safari only

outDuration: 0 crashes animsition on Safari only, links simply don't appear to work, works fine in Chrome though, very freaky, set it to 1 and it's fine.

6630889904ff2f04836ded6694410fcaff2d4c84


Displaying attribnutes and faceted attributes as html safe

fixes https://github.com/antleaf/nims-mdr-development/issues/547

This PR is superseded by https://github.com/nims-dpfc/nims-hyrax/pull/528, which addresses not just the views but also the forms.


[ActionButton] Add styles for labels.

See #75

As I see, test errors don't related to this PR

True, I fixed them here. Could you please update your fork to include that commit. I don't want to push those error to master again ...

Current coverage is 100% (diff: 100%)

Merging #76 into master will not change coverage

@@           master   #76   diff @@
===================================
  Files           7     7
  Lines         300   300
  Methods         7     7
  Messages        0     0
  Branches        5     5
===================================
  Hits          300   300
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 20b42c8...b32a4aa


Failover Nodes Configuration Missing

Hi, I didn't find in the documentation a way to support setting up the failover nodes in case one of the memcached servers crashes.
I wanted to know if there is a way to set that up or if it could be implemented.
Thanks.

Some Memcache vendors support a comma delimited list of servers in the environment variable. I'd be happy to accept PRs for others.

I can update that today and cut a release.

@mathif92 webapp-runner <IP_ADDRESS> is released with memcached-session-manager 2.1.1 (it might take a few minutes/hours for maven central to sync up).
I'm going to close this, and we can reopen if you still have issues.


How to get .jar or .aar  file of this library

Hi I am Xamarin Developer my client wanted to integrate this library into there's Xamarin project.
For that I am gonna need jar file I tried to generate it through Android Studio But I am getting couple of errors when building project.I tried to solve them but couldn't since not so much familiar with java and android IDE.So is there any other way to get Jar or  file,easy way

Here are list of all releases of this SDK

Sounds interesting, thx. I had a smiliar question.

"Sounds interesting, thx. I had a smiliar question."
-> https://github.com/sumup/sumup-android-sdk/issues/123
Regards, Jan


fix(shutdown): correctly handle rocket errors

What problem are you trying to solve?
Fixes #120
What is your solution?
If we're not using the keep alive functionality, we will just wait for the Rocket thread to finish.
If not, we will await for the first occurrence. Either the Rocket thread finishes (for instance, due to a panic...) or the keep alive functionality notifies the shutdown and causes the shutdown handle to finish.
Other considerations
I took the time to fix some clippy issues. It was impossible to even commit without doing --no-verify. I'm afraid potential contributors may be facing the same issue.  Is that expected or are you not getting that at all when trying to commit to the repo?
IDE-1744

Thanks @juli1! Not sure if you were planning to create a release soon, but I'd really appreciate having this already internally in order to leverage this behavior in VS Code.

Thanks @juli1! Not sure if you were planning to create a release soon, but I'd really appreciate having this already internally in order to leverage this behavior in VS Code.

New release should come tomorrow once this is merged.

Saw v0.1.6 already! Thank you for that! 🙌🏻


try using rattler-build

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found some lint.
Here's what I've got...
For recipe/recipe.yaml:

❌ The top level meta key schema_version is unexpected
❌ There are 1 too many lines.  There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12561815509. Examine the logs at this URL for more detail.

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you but ran into some issues. Please check the output logs of the GitHub Actions workflow below for more details. You can also ping conda-forge/core (using the @ notation) for further assistance or you can try rerendering locally.
The following suggestions might help debug any issues:

Is the recipe/{meta.yaml,recipe.yaml} file valid?
If there is a recipe/conda-build-config.yaml file in the feedstock make sure that it is compatible with the current global pinnnings.
Is the fork used for this PR on an organization or user GitHub account? Automated rerendering via the webservices admin bot only works for user GitHub accounts.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12561821044. Examine the logs at this URL for more detail.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12562381005. Examine the logs at this URL for more detail.


Remove gym dependency

More progress towards #1981.

Change all remaining references of gym to gymnasium
Remove hiway-v0 env
Fix make test

All the examples appear to be working with gymnasium aside from drive and platoon. There appears to be an issue with stable_baselines3 (see the failing CI test). I tried using v2.0.0 which added support for gymnasium, but the error is still happening. I've made this a draft PR since I think we should just do this all in one go, instead of leaving gym as a dependency for the rl examples, which would require some additional code changes.

PR #2075 updates the drive and platoon examples to use Stable Baselines3 v2.0.0 and gymnasium.


Datasets

add the codes for generating datasets

Almost there @samwang141224
Just address that one comment in get_sightlines.py and I'll merge.
Thanks!

Remove the spaces in the name of your Notebook (can be problematic)
and I'll merge. Thanks!

Thanks for your remind. I have already renamed it.