Create Data availability page

[x] Create page
[x] Add description of what is being covered
[x] Add description of checks required on this content, compiled from current protocol documents (including dataset assignment spreadsheet)
[x] Add examples covering correct and incorrect scenarios, as required to support checks
[x] Populate with schematron messages
[x] Provide explanations for how to fix schematron errors and warnings
[x] Review house style document to ensure all requirements are covered by GitBook and schematron
[ ] Review schematron messages related to this topic to ensure they are user friendly
[ ] Becky approved page
[ ] Melissa approved page
[ ] Fred approved page
[ ] James approved page
[ ] Naushin approved page
[ ] Share page with Exeter and invite feedback

Definition of done

[ ] Page completed
[ ] Team reviewed and approved page?
[ ] 'Message change' ticket created for Fred to update the Schematron

@naushinthomson @FAtherden-eLife @Melissa37 @bcollins14 - please could I get your review on https://app.gitbook.com/@elifesciences/s/schematron/article-details/content/data-availability
Notes:

I've not written up the action for data-openneuro-test-2 yet because I wanted to check whether we still wanted to allow both DOIs and archives for OSF datasets?
Please let me know if the table of common databases works - if I have to change that, I want to get that out of the way BEFORE I start adding any missing examples
Speaking of, do we want to update the rules with proper assigning authorities for everything currently allowed as 'other' and get Exeter to update Kriya? (Won't be able to do this for everything, since some of them have multiple authorities, but we can get a few more in)
I ended up duplicating the text for a lot of the similar messages. I wasn't quite sure how we'd do the headings otherwise and Exeter will need to refer to the warning messages for each case. Also, some of those tests are not quite identical in what they check so . . .

Text change suggestions:
'Links that just go to the the landing page for a dataset will need to be replaced.' to
'Links that just go to the database homepage will need to be replaced.'
'In both these cases, 'on request' data is permitted with the approval of the editors handling the article. This approval will be indicated in the Production Comments if it has been received prior to export from the submission system; if approval is outstanding, this should also be indicated in these comments.' to
'In both these cases, the editors handling the article will have approved the data to be ‘on request’. If the editors gave their approval before the article was exported from the submission system, this will be shown in the Production Comments. If they have yet to do this, this should also be indicated in these comments.’ Or something similar (in case it’s hard to understand if English isn’t your first language?)
‘An author query was left requesting further details and once these were provided, the main-text statement was removed and the text was combined with the Data availability statement’ – should we clarify which author query was left just to be completely clear?
For back-test-3 can the action be changed to
‘This error will fire if there is no data availability section  present in the  element for an article, or if there is more than one section of this type present. The section will need to be added in, or the extra sections will need to be removed.’ Also is this a rare error that we want to be notified about?
Can the action of back-test-10 be changed to
‘This warning will fire if there is no  present in the  element for an article, or if there is more than one section of this type present. Extra sections will need to be removed but if this is a new version of a very old article, a data availability section shouldn’t be added.’ Also can we specify how old the article should be for us to not add a DAS?
das-elem-citation-child-1 change the action to:
‘The only formatting elements allowed for a dataset title () or database name () are formatting tags for italics, superscript and subscript. Any other formatting should be removed and any hyperlinks in these fields should be changed to plain text. XXXXXX will be the child and parent elements, respectively.’ Can we clarify the child and parent elements in non-xml terminology?
Questions:
In the ‘Data available on request and on acceptance’ sections, should we make it clear what we expect Exeter to do specifically? As it stands it seems to be addressed to eLife staff only?
‘Once the authors have responded, the entry for the whole database can be replaced with one or more specific datasets, or removed entirely in favour of a citation or URL link in the main text.’ – Do we have guidance on when we want references in the reference list vs url links vs dataset references?
In the action for das-elem-cit-3 and 4, should an author query also be left to ask the author to confirm the details are correct?
Should we indicate somewhere what we want Exeter to do if they come across a database not listed in the examples section?
For the action of data-ref-given-names-test-1 do we want to mention a case where this warning can be ignored?
das-elem-cit-4 – The reference in position XX of the data availability section has a pub-id (XXXXXX) which is the same as another dataset reference in that section. This is very likely incorrect. Dataset reference pub-id should be distinct.
Should we clarify when this is ok to ignore?
Can the action of das-elem-citation-year-1 be reworded to reduce the xml terminology?
For the xml structure errors in general, is it easy enough to remove extra elements when they are there in error?
I’m not sure I understand the action of das-elem-cit-1 and 2. How do we add a specific-use attribute in?
General question – should ‘data availability statement’ have the capitalised ‘D’ throughout? I’m not sure if it should but just checking!
@FAtherden-eLife Schematron message changes:
Should the text of final-das-elem-data-title-1 be changed to ‘The reference in position XX of the data availability section does not have a title (no data-title). Please ensure to add it in.’ to match the text of other similar messages?
Should the text of data-edatashare-test-3 – be changed to Data reference with the title 'XXXXXX' has an Edinburgh DataShare type doi - XXXXXX, but the assigning authority is not 'Edinburgh University', which must be incorrect.
Should the text of das-pub-id-1 – be changed to ‘Each pub-id element must have a @pub-id-type with one of these types: accession, archive, or doi.’

Thanks @JGilbert-eLife, looks good - just a handful of (mostly minor) points from me

Question (presumably for @Melissa37) - what are we expecting to happen in the new workflow when data is 'available on request'? Exeter to query us (and us to query editorial) before it's sent out to author? Exeter to add in a query? Or for us to deal with it at Post-author?

@JGilbert-eLife - Database examples table - there's a column for URLs and column for DOIs. I get that it would be good to indicate what URLs we can expect for dataset with dois, but does including them leave room for confusion? If there's a doi, we obviously would always want the doi link to be used instead.

Can we get rid of dx. in doi link examples?

A bit of pedantry - for data-openneuro-test-1 and data-synapse-test-1 - this text:

This warning indicates that the database name for a dataset is not the one expected based on the URL provided.

needs changing to:

This warning indicates that the database name for a dataset is not the one expected based on the DOI provided.

I've not written up the action for data-openneuro-test-2 yet because I wanted to check whether we still wanted to allow both DOIs and archives for OSF datasets?

Can't remember why we allowed both in the test. I've found two examples of links (rather than dois) from the archive - 1 of these no longer works as a link, and the other has a doi. Perhaps we should just allow dois then?

Should we specify that back-test-3 and back-test-10 only apply to research articles (which aren't Scientific Correspondences)?

In research content, the data availability statement is mandatory.
...
Feature content does not require a data availability section.

Is it worth specifying explicitly that this Feature templates 5s require DASs - or is that implied (since they are treated as research content)?

@naushinthomson, @JGilbert-eLife

Also can we specify how old the article should be for us to not add a DAS?

31st May, 2018 is the cut off. Although some before that might have DASs, all after that date should definitely have one.
back-test-3 will fire if the pub-date is greater than (meaning after) 2018-05-31.
back-test-10 will fire if the pub-date is less than (meaning before) or equal to 2018-05-31.

@FAtherden-eLife Schematron message changes:
Should the text of final-das-elem-data-title-1 be changed to ‘The reference in position XX of the data availability section does not have a title (no data-title). Please ensure to add it in.’ to match the text of other similar messages?
Should the text of data-edatashare-test-3 – be changed to Data reference with the title 'XXXXXX' has an Edinburgh DataShare type doi - XXXXXX, but the assigning authority is not 'Edinburgh University', which must be incorrect.
Should the text of das-pub-id-1 – be changed to ‘Each pub-id element must have a @pub-id-type with one of these types: accession, archive, or doi.’

Thanks @naushinthomson - will update.

The JATS4R Data citations recommendation has gone out for public review on V2:
https://docs.google.com/document/d/1Mph70pGM2H-NsFEU48MFmPKtE0HiQrRf9UD73kZBADQ/edit
Things to note:

@assigning-authority on  . When the given type of identifier can be assigned by more than one organisation (e.g. DOIs minted by CrossRef or DataCite) and the organisation registering the identifier is known, include the @assigning-authority attribute on the  element. For example, a DOI that is assigned by CrossRef should have “doi” as the @pub-id-type, and “crossref” as the @assigning-authority. For many types of identifiers, there is only one assigning authority. For example, PubMed IDs are always assigned by the National Library of Medicine. In these cases @assigning-authority is not necessary.

Talking on the JATS4R steering committee - this is not necessary at all and most people won't do it. I think we can ditch it completely, as we're doing it wrong anyhow. For example we add assigning authority for Figshare as figshare, but it's actually Datacite. Likewise the DOIs used by Europe PMC are Crossref.

'''ArrayExpress
E-MTAB-3649'''

From the JATS guidance:

archive | Generic identifier type for an identifier assigned by an archive or other repository (generally used with elements , , and )

We're using it wrongly and should not be using archive. If the identifier is part of the URL string then it's a PID and we should be using accession
I don't think it would be a bad thing if where we have an ID it's simply a DOI OR accession
The problems of being ahead of the times and trying to do things in the dark!

The data availability section provides information on how to access the data used in or generated by the work being reported in an article. eLife strongly encourages authors to deposit any data they generate in a dedicated open repository so that it is available for further study and to allow the replication of their results, and to acknowledge any previously published datasets that they have used.

Question - data are VS data is - are we going with common usage of nowadays and not being strict about singular/plural usage of datum/data?

and to acknowledge any previously published datasets that they have used
I think we should word this more strongly. It's to ensure previously published data sets that are re-used are given proper credit by adding them as references, which can be tracked.

in the What needs to be checked section

Previously published datasets
The same rules apply as for generated datasets.

Do the same rules apply? For instance "See below for actions in cases where data is not yet available." Would they not be different actions?

Year: This should be the year that the dataset was made publicly available. For generated datasets, be aware that this might not be the same as the year of publication for the current article.

This might not be the same for generated datasets too, it's not exclusive to previously published?

Identifier: A unique string that can be used to identify the dataset. This may be a DOI, an accession number or simply an ID unique to the database in which the data has been stored.

Base on JATS4R rec, should we change this to:
Identifier: A unique string that can be used to identify the dataset. This may be a DOI or an accession number.
?

pub-id-type: The type of identifier present. Chose from: accession, archive, doi. This cannot be left as 'other'. Guidance on which databases take which value for this field can be found here.
assigning-authority: The organisation that assigned the identifier. Often the organisation that hosts/maintains the database. This can be set to 'other' if multiple organisations are involved or the authority is not on the list of allowed values. The values for common databases can be found here.

Change? Based on JATS4R

The editor is the same for generated and previously published datasets

Suggest replacing the word Editor with something else (could be confused with academic/scientific editor! Or maybe that's just my brain :-)

For example if the authors have simply added 'Smith et al.' or similar in the submission system, the full author list will need to be located and entered.

Are we being too anal here? It can be so so hard to find these details, should we just relax our procedures and allow et al in dataset references?
Presumably, if it's a DOI Crossref or Datacite could be consulted for the details?

In section "Data available 'on request'"

To ensure openness, eLife instead encourages authors to deposit all their data in a dedicated repository or a more general archive such as Dryad or figshare, where it will be available to anyone who wants it.

is it worth adding subject-specific in front of a dedicated repository?

If approval for 'on request' data has not been indicated, the Production team should contact the Editorial team to establish whether they are working on this issue already and what action needs to be taken.

Is it worth stating that also sometimes these slip through unchecked by the editorial team and some we are the "backstop" and responsible for catching things that fall through the cracks?

All data generated or analysed during this study are included in the manuscript and supporting files. Source data files will be made available upon acceptance

I've also seen that source files will also be uploaded on acceptance...and this needs to be checked too? and change the wording.

If it is not possible to add the dataset(s) based on the information provided, either because it is incomplete ,

remove the space in front of the comma :-)

Any link like this will need to be replaced with the final dataset URL before publication. If it is not possible to identify the final link based on the reviewer link or the given identifier, the author should be queried:
Please provide the final URL for this dataset.

Should this AQ also say ...and ensure the dataset is public by the time of publication?

For example, in the following case, the Data availability statement was:
Data have been deposited on GEO under the accession number GSE140919. A source data file has been provided.
But an in-text statement mentioned additional data submitted to dbGAP:
The data for this study have been deposited in the database dbGAP. The sequenceing data can be found as GenBank GSE140919. Data can also be found in the included source file.
Since the authors did not provide details for their dbGAP dataset, the Production team first contacted Editorial to check if they were working on this already. The authors were then asked to provide the missing information but they responded that they had not, in fact, deposited data to dbGAP. The in-text statement was then deleted and the Data availability statement was retained as originally provided.

I wonder whether we can reduce communication loops somehow and just AQ rather than needing to go back to editorial?

linked to above comment

In another instance, the Data availability statement was
All data generated or analyzed during this study are included in the manuscript and supporting files
while the in-text equivalent read
Representative segmented neurons for all presented neuron types will be available at Virtual Fly Brain (https://www.virtualflybrain.org).
An author query was left requesting further details and once these were provided, the main-text statement was removed and the text was combined with the Data availability statement:
All data generated or analyzed during this study are included in the manuscript and supporting files. Representative segmented neurons for all presented neuron types are available at Virtual Fly Brain (http://virtualflybrain.org/data/Lee_Lineage2020).

This is a new method of documenting. I thought we had been citing examples but not saying they had happened. I hope that makes sense? Maybe change to
In another instance, the Data availability statement could be
while the in-text equivalent reads
Add an author query requesting further details and once these are provided, the main-text statement should be removed and the text combined with the Data availability statement:
Also, need to indicate which AQ to use

The reference in position XX

The reference in position XXXXXX

Can we standardise the Schematron messages (or this doc so they are all the same number of Xs?

The author should be asked by email to provide the missing details if they cannot be found using the other dataset information

Should we clarify that this is a production editor task and not a vendor or freelancer task?

For example, if the URLS for two datasets are both

The s on URLS should be lower case :-)

For example, if the indentifiers for two datasets are both GSE135351, but the URLs are

Typo - indentifiers should be identifiers


Release Test to Prod

Links to Jira Tickets
n/a
Description of Changes
Release latest changes from Test to Prod.
Testing Notes
Everything works as expected.

Will re-open to kick off actions.


Refactor plots with feedback

I'll go ahead and merge this. This PR takes care of all the minor refactoring for the plots. Thanks!


Android HTTP handler

Allows network request behavior to be customized on Android (in our case, for adding API keys)

Reviewing this now.


SHA bump for OSAD to match kilo as of 22/07/2015 This SHA bump is largely to grab some important fixes for the upcoming 11.0.0 release.

Of major concern is fixing RabbitMQ upgrade failures.
(https://bugs.launchpad.net/openstack-ansible/+bug/1474992)
Fixes #269

SHA matches head of OSAD's Kilo - I thought I spotted an 11.0.0rc3 reference somewhere in a variable file, so i'm checking for that now. If it's present, we should update that with this PR, too.

Ok - it's in rpcd/playbooks/group_vars/all.yml, called rpc_release. For master, we can leave it. For kilo, we need to bump to rc8.
I am +1 on this PR as is.

While I think an appropriate update of rpc_release should be included every time the SHA is bumped, considering the timelines I'm happy to :+1: this for testing purposes.

2 +1s already, so merging.

@odyssey4me You're right, but in master it's always master. Same as OSAD


[Package Update] Switch from babel-eslint to @babel/eslint-parser to get latests fixes

Hello there,
I ran eslint on my project and got an error, I searched on the internet and found that this was fixed in the latest version of the babel eslint parser but that they moved to another package name.
It went from babel-eslint to @babel/eslint-parser.
Could eslint-config-react-app switch to this new version ?
Here's a link that explain babel's decision: Babel Blog
Thanks for any answers...
MrNossiom

Maybe I could have an answer...
I can see that I'm not the only one bothered by this.
I can do a PR to upgrade the package, just ask...

In the mean time, https://github.com/babel/babel-eslint/issues/799#issuecomment-533951967 worked for me in fixing the cannot read property 'value' of null issue on builds.

In the mean time, babel/babel-eslint#799 (comment) worked for me in fixing the cannot read property 'value' of null issue on builds.

Yes, but still, this package is not maintained any more and could break.
It will work as a temporary workaround...

I'll close this off as I'm working on this right now and it will be released in 4.1.
Sorry it took us a while to get this out!


yet another cluster debug info improvement

changed execution flow to:

first register commands to run
print a "table of contents" so it's obvious what command will be executed and easily searched for
print a command with > prefix and execute the command

By replacing set -x with printing the cmd it is now visually clearer and suitable for inclusion in bug tickets (./validate-microshift/cluster-debug-info.sh > /tmp/cluster.log)

/retitle USHIFT-660: yet another cluster debug info improvement
/lgtm


remove retention related configuration

Remove retention related configuration from code

Codecov Report

Merging #1501 (bd95d1d) into master (539053d) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
+ Coverage   38.76%   38.79%   +0.03%
==========================================
  Files         167      167
  Lines       13470    13433      -37
==========================================
- Hits         5221     5212       -9
+ Misses       7497     7468      -29
- Partials      752      753       +1

Impacted Files
Coverage Δ

auth/setup.go
0.00% <0.00%> (ø)

config/config.go
41.21% <ø> (+7.88%)
:arrow_up:

pyramid/tier_fs.go
58.51% <0.00%> (-3.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539053d...8f62bb7. Read the comment docs.


Cloudflare Workers

Cloudflare Workers is serverless platform similar to AWS Lambda. https://workers.cloudflare.com/
It is similar to classic serverless platforms but it runs on the edge and provides smaller latency and no cold starts.

Cloudflare workers are cool. But going to focus on AWS Lambda now.


[Macros] Track macro dylib path dependencies when using plugin server

Shared library plugin paths were not recorded as dependencies. Record them when loading libraries in the plugin server.
rdar://119324830

@swift-ci Please smoke test


Sync/cf208

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 5 committers have signed the CLA.:white_check_mark: sunilkn020:x: pravinprabhak.sheno@hcl.com:x: biancaluna:x: sunilkn002-hcl:x<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Changing clothing color in the provided unity template

Am I right to understand that the template provided doesn't change clothing color.
I am not able to comprehend  the code in the Simulation Scenario ShaderGraphTextureRandomizer https://github.com/Unity-Technologies/PeopleSansPeople/blob/1e8f44922b8edaf850f722f7efb7afe41c0a435d/peoplesanspeople_unity_env/Assets/Scripts/ShaderGraphRandomizer/ShaderGraphTextureRandomizer.cs .
Excerpt of the code I am trying to understand.
`
        foreach (var tag in characterMaterial.categories)
        {
            Material material = tag.Item1;
            material.SetTexture("Texture2D_D27E6D66", albedoTexture.Sample());
            material.SetTexture("Texture2D_A2664602", maskTexture.Sample());
            material.SetTexture("Texture2D_A8936B7E", normalTexture.Sample());
            material.SetFloat("Vector1_46FBBF67", m_FloatParameter.Sample());
            material.SetFloat("Vector1_4EA3F53", m_FloatParameter.Sample());

        }

`
I see that there is no usage of Randomizer tag.
Can anyone please help me figure out where is the characterMaterial used.
Is it used in some other Randomizer or is the material configured in the prefabs ?

Once I placed the prefab in the scene,I  am able to see the mapping.
Thank you


Update Auth Sevices for ICAM Changes

User Story
As an EASEY user,
I want to be able to successfully login by using the new ICAM authentication servers
So that I can perform my authorized actions in the EASEY system as usual.
Development Notes
•	Update Authorization Service to call new ICAM services instead of SOAP Services
•	Refactor as needed
•	Deprecate/remove SOAP service API end points
•	Update Guards
Based on discussions and email exchanges with the ICAM team and ERG/DPC, this is the Auth-flow that will be implemented

User provides a user id and clicks on Next
The client initiates a determinePolicy to determine the policy to apply to the user (sign in, migrate, or sign up).  If the user id provided by the user is invalid, then an appropriate error message is provided to the user.
The user is redirected to a landing page that is appropriate for the policy returned based on the user.
Once the user completes the authentication flow, the Azure DB will send an http post request to the Auth API at http://[base url]//oauth2/code. The post redirect may provide error information or a successful login

Error Post Redirect

Auth API will redirect to ECMPS UI with the error information
ECMPS UI will display the login error

Successful Login Post Redirect

Auth API will create a session and redirects to ECMPS UI appending the session ID as query parameters
ECMPS UI will now call Auth API with the session ID to obtain full token and user data
Auth API will respond with a fully fleshed out User object with token
Normal signed-in process will continue

Acceptance Criteria:

Login Functionality

AC1.1: The login page must only require a userID for login, and no password field should be present.
AC1.2: Upon entering a valid userID, the system should redirect the user to the OIDC provider for authentication.
AC1.3: Invalid userIDs should result in an appropriate error message being displayed without redirection to the OIDC provider.
AC1.4: The system should handle the OIDC callback and log the user into the application upon successful authentication.
AC1.5: Ensure session creation and user-specific data are correctly initialized upon successful login.
AC1.6: Ensure facilities and roles are correctly retrieved from CAMD and are used for securing application resources correctly.

Token Refreshing Functionality

AC2.1: The application must automatically refresh the OIDC token before it expires without user intervention.
AC2.2: The refreshed token should be valid, and user sessions must continue without requiring a re-login.
AC2.3: If a token refresh fails, the user should be redirected to the login page with an appropriate error message.

Retrieving Organization Information for Users

AC3.1: The application must correctly fetch and display use information (first and last names) from the OIDC token claims post-login.
AC3.2: Changes in organization information on the OIDC provider side should reflect in the application after a new login.

Token Validation

AC4.1: The application must validate OIDC tokens using the provider’s public keys to ensure they are genuine.
AC4.2: Expired or tampered tokens should be rejected.

Login Scenarios for Different User Types Across Multiple Paths

AC6.1: Verify that both EPA and non-EPA users can successfully log in through all available paths (sign in, sign up, and migrate).
AC6.2: User-specific redirections or flows (e.g., first-time login instructions for new users) should work as expected for both user types.
AC6.3: Ensure that error handling and messages are appropriate for each scenario and user type.
AC6.4: Post-login redirection to intended pages (or dashboards) must be correct depending on the user type and the authentication path used.

Test case: create new account with non-EPA email in cdx dev (create login.gov account with same email):

Logged into cdx dev, attempt to log into ECMPS after role approved in cdx dev by sponsor
Navigate to Monitoring Plans

received an error:

After logging out of cdx dev in the other tab, I was able to successfully navigate to the Monitoring Plans section, but after checking out a facility (Agua Fria Generating Station 141, config 1) I attempted to export the monitoring plan and received a CORS error as follows:

After this, I attempted to log into cdx dev and received this error:

Receiving the attached error when attempting to download reports.

We made a change to how tokens are validated late yesterday. Can you retest once it is deployed? Will confirm deployment with Mark.
I don't think the CORS error is related to the tokens or ICAM. Let me know once you retest and will recheck.

We had a number of environment issues yesterday, almost all day.
Github was down and
mock permissions were disabled when the app redeployed automatically after a build.
A deployment was done late yesterday after GitHub resolved the GitHub actions issue. Please retest.

We had a number of environment issues yesterday, almost all day.
Github was down and mock permissions were disabled when the app redeployed automatically after a build.
A deployment was done late yesterday after GitHub resolved the GitHub actions issue. Please retest.

Issue: AC1.2 is still could not be validated post the Tuesday, 05/21 deployments, specifically the org user logging in is not redirected to the EPA Gateway.
Hello @yonatan-dp , thanks for the update. I retested AC1.2 and am still not getting the expected result. I cleared my cache for the last 4-weeks, opened ECMPS dev, typed in my my org account username, and was not redirected to the EPA Gateway, and taken directly to the logged in view of ECMPS dev, where I can "Open & Checkout" Monitoring Plan records

To eliminate possibility of local browser issues, can you try this in incognito mode?

We had a number of environment issues yesterday, almost all day.
Github was down and mock permissions were disabled when the app redeployed automatically after a build.
A deployment was done late yesterday after GitHub resolved the GitHub actions issue. Please retest.

Issue: AC1.2 is still could not be validated post the Tuesday, 05/21 deployments, specifically the org user logging in is not redirected to the EPA Gateway.
Hello @yonatan-dp , thanks for the update. I retested AC1.2 and am still not getting the expected result. I cleared my cache for the last 4-weeks, opened ECMPS dev, typed in my my org account username, and was not redirected to the EPA Gateway, and taken directly to the logged in view of ECMPS dev, where I can "Open & Checkout" Monitoring Plan records

Hi @ibarra-michelle, to eliminate possibility of local browser context, can you try this in incognito mode?

Conclusion: In incognito mode, AC1.2 has been validated for organization users, where the org user is redirected to the EPA Gateway, prompted to type in their PIV pin, and then redirected back to ECMPS dev app as a logged in user.

Authentication flow confirmed on dev with non-EPA CDX accounts.

After discussing internally, logins to the dev/test/beta environments will be the way test these changes to the application.


New version: Stan v5.0.0

Registering package: Stan
Repository: https://github.com/StanJulia/Stan.jl
Created by: @goedman
Version: v5.0.0
Commit: beffa5ac646fd96a99d2cead366cb73174376000
Reviewed by: @goedman
Reference: https://github.com/StanJulia/Stan.jl/issues/65

Your new version pull request met all of the guidelines for automatic merging.
I will automatically merge this pull request during the next cron job.
If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

[noblock]


memcache_pycompat: python2 / python3 and go compatibility

This creates compatibility between pylibmc==1.4.0 and gomemcache for Python 3+.
Steps

[ ] merge
[ ] release 1.1.0

The upgrade to Python 3 introduced new pickle protocol versions. Previously only protocol version 2 was supported. More information found here:
https://docs.python.org/3/library/pickle.html#data-stream-format
For Python 2.7 and Python 3 support, we can use an external package gopickle that can unpickle protocol versions 0 - 5.

@jehiah ready for another look


Update addons.md, Cilium is now a CNCF graduated project

edit addons.md. part of cilium

@41vin  Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps


Anonymizer does not work if not separated by spaces

Describe the bug
test data<PHONE_NUMBER>
redacts ok to give back test data
but test data630-596-1111
does not redact the phone number.
To Reproduce

text_to_anonymize="test data630-596-1111"
try:
    nlp = spacy.load("en_core_web_lg")
except OSError:
    # Model not found, download it
    spacy.cli.download("en_core_web_lg")
    nlp = spacy.load("en_core_web_lg")

analyzer = AnalyzerEngine()
anonymizer = AnonymizerEngine()

analyzer_results = analyzer.analyze(
    text=text_to_anonymize,
    entities=["PHONE_NUMBER", "EMAIL_ADDRESS", "URL", "LOCATION"],
    language="en",
)
scrubbed_text = anonymizer.anonymize(
    text=text_to_anonymize,
    analyzer_results=analyzer_results,
    operators={"DEFAULT": OperatorConfig("redact", {})},
).text

print(scrubbed_text)

Expected behavior
Phone number gets scrubbed.
I'm on:
**presidio-analyzer==2.2.351
presidio-anonymizer==2.2.351
spacy==3.7.2
spacy-legacy==3.0.12
spacy-loggers==1.0.5
**

Presidio uses the phonenumbers package to detect phone numbers, and it seems that the package's logic doesn't detect phone numbers without spaces before and after. As @VMD7 suggested on the other issue, you can try using a NER model which was trained on phone numbers and see if you get better results. Alternatively, you can create a custom pattern recognizer to detect phone numbers with no spaces around them.

Thanks @omri374, does your PR above with the leniency param help here as well? I'm not sure if that's a parameter exposed via the library

Yes it should, but it's not released yet. Once it is (or if you clone the repo), you should be able to adjust it, for example:
from presidio_analyzer import AnalyzerEngine, RecognizerRegistry

registry = RecognizerRegistry()
registry.load_predefined_recognizers()

phone_recognizer = [rec for rec in registry.recognizers if rec.name == "PhoneRecognizer"][0]
phone_recognizer.leniency = 0 # update phone number leniency

analyzer_engine = AnalyzerEngine(registry=registry)

analyzer_engine.analyze(text="My US number is415 555-1032", language="en")

Note that this is leniency parameter is only supported for phone numbers. Other entities have other detection methods and could still fail to identify a number not separated by spaces.


[Bug/Feature]: Zotero to Obsidian: automatic update not working

Debug log ID
R9A339SK-euc
What happened?
I have the Zotero/Obsidian workflow set up. The documents that were in my Zotero library at the time I created this are all there, but whenever I try to add new stuff it's not updating. As far as I can tell this is all set up to automatically update through BibLaTex, but even when I use the 'export now' button the new sources aren't showing up when I try to cite them in Obsidian.

No BBT error in R9A339SK-euc. Does the bib file on disk update when you click 'export now'?
There is a separate error in the log from another plugin, I don't think it's related to this, but you might want to inform the author:
[JavaScript Error: "TypeError: library.waitForDataLoad is not a function" {file: "chrome://zotero/content/contextPane.js" line: 883}]
Security Error: Content at moz-nullprincipal:{18a5810b-d102-4694-a3b8-05f63b28792c} may not load or link to chrome://knowledge4zotero/content/treeView.html.

Hey, yeah it looks like it has - I recently changed some of the folder names in Zotero and that is showing.

Any updates?


'Segmentation fault (core dumped)' when moving a tensor to a device

Hi! Thanks for your work.
I have run python setup.py install in chamfer2D with no error.
However, when I am using this package in Python 3.6, I got the following problem:
>>> import torch
>>> import chamfer_2D
>>> torch.tensor(1,device='cuda')
Segmentation fault (core dumped)
If I don't import chamfer_2D, everything works fine.
I am using CUDA 10.1 and PyTorch 1.4.0
Do you have any idea on how to solve this problem?
Best regards

Hi! This looks serious ! Thanks for the minimal XP. I don't know the fix but would gladly add it to the repo if you find it. I suspect it has to do with the latest torch/Vida release. I'll run some tests on my end.


python312Packages.hatchling: 1.26.1 -> 1.27.0; hatch: 1.13.0 -> 1.14.0

Things done

python312Packages.hatchling: 1.26.1 -> 1.27.0
hatch: 1.13.0 -> 1.14.0

cc @hexa @ofek @onny

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@skeet70 could you please check if this fixes https://github.com/NixOS/nixpkgs/issues/366359 for you?

will this be merged next week

Was unable to confirm if this builds properly as git-minimal is failing.


So awesome !

That's gonna help me A FCKING LOT.
But can you add option to define all actions(array) with Resource ? And then if by mistake we define allow for not existing action then we have some information in console.log maybe ?

I'm glad to see that this library is helpful :)
If you want to add some feature feel free to fork it & send pull request.
Also I don't think that sending information to console log is the right way. Right way: create special exception & throw it. Currently all exceptions have "Error" type, this is mistake that was done because of desire to get "something" working ASAP.

I have a question - can getResourceId be just a property ?

No, only method, since every "resource" entity should implement AclResourceInterface


⚠ Bofrost.lu has degraded performance

In 7a5e254, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1339 ms

Resolved: Bofrost.lu performance has improved in 5d5239f.


[chore] Bump read/skrifa patch version

Changes were as follows, looks non-breaking to me, hope I am doing this right.
$ cargo release changes
     Changes for read-fonts from read-fonts-v0.15.0 to 0.15.0
             fc06fc1 [read-fonts] ComputedArray should check for zero
             e23d9ba [chore] Bump font-types patch
     Changes for skrifa from skrifa-v0.15.0 to 0.15.0
             37baedb [Skrifa] Implement COLRv0 traversal (#737)
             a08407b [skrifa] new outline API (#727)
             4aa1fc6 [COLRv1] Add tests for coincident stops and angles (#736)


Bring up OSRM/Valhalla in dev environment for ETAs

We need to decide if we need OSRM dev env server


Devise email validation disabled...why?

You are overriding the devise email_required? and email_changed? methods in DeviseTokenAuth::Concerns::User, any particular reason? It seems like that should be beyond the scope of the token auth concern.

@hiattp - it was necessary to modify the redirect url. If you can find a better way please let me know.

@lynndylanhurley Excuse me for being a noob, still trying to understand.  I can't find which redirect you're referring in the code.  Could you help me out?


CUJ Testing for Beta v2 - Creator can View and Move Elements Up/Down the Stack in the Layers Panel

Feature Description
n preparation for the Beta 2 release we would like to have validation and confirmation of the CUJ functionality detailed in
https://github.com/google/web-stories-wp/issues/1667

[x] Get preview of metadata of element
[x]  Move element up/down the layers stack
[x]  CMD Up/Down to move element up/down the layer
[x]  CMD+Shift+Up/Down to move element up/down the layer
[ ]  Delete a element from the layers panel
[x]  Expand and collapse the layers panel (clicking on arrow or dragging)

Tested on macOS Mojave 13-inch v. 10.14.6 / Safari v. 13.1.2 and found no issues.


fix/MD/XL-9874 action wrong injection in run method

Task XL-9874

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (fix/MD/XL-9870-Create-Endpoint-command-creates-wrong-controller@6c3389b). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

src/Generator/Commands/ActionGenerator.php
0.00%
3 Missing :warning:

Additional details and impacted files
@@                                        Coverage Diff                                        @@
##             fix/MD/XL-9870-Create-Endpoint-command-creates-wrong-controller     #51   +/-   ##
=================================================================================================
  Coverage                                                                   ?   4.28%
  Complexity                                                                 ?     892
=================================================================================================
  Files                                                                      ?      99
  Lines                                                                      ?    3245
  Branches                                                                   ?       0
=================================================================================================
  Hits                                                                       ?     139
  Misses                                                                     ?    3106
  Partials                                                                   ?       0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: Player APIs

:tada: This PR is included in version 0.18.0-proposed.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cannot customize the augmenter in 2D training?

Hello StarDist tean,
From the training example shown here, is there a way to get more info regarding the augmenter in the line  model.train(X_trn, Y_trn, validation_data=(X_val,Y_val), augmenter=augmenter)?
Specifically, how many augmentations does it perform for each pair of (X, Y)? Can we specify that I want n augmentations for each (X, Y)? Would be nice if the augmenter info is a bit exposed. Apologies if I missed something, just in case. Thanks!

Hi,
not sure if this is still relevant but maybe its also helpful for others. The augmenter is a function that receives x and y and returns the transformed x and y. Number and kind of augmentations is up to you. In the example you linked, the augmenter is defined in cell 13.  Augmentation is only applied to the training images but not the validation images.
Further information can be found here: https://github.com/stardist/stardist/blob/3ae059cfa87011f1233e738f3bf0b21c10cce791/stardist/models/model2d.py#L354

Sorry for overlooking this issue. It's exactly as @jonasutz described as can be found in the docstring of model.train:
 augmenter : None or callable
            Function with expected signature ``xt, yt = augmenter(x, y)``
            that takes in a single pair of input/label image (x,y) and returns
            the transformed images (xt, yt) for the purpose of data augmentation
            during training. Not applied to validation images.
            Example:
            def simple_augmenter(x,y):
                x = x + 0.05*np.random.normal(0,1,x.shape)
                return x,y


blog draft for review- scheduled Monday prerelease

@elleobrien I see no errors in writing, links.  Love "now it's shorter, sweeter, and more powerful than ever!" The only thing I see that's picky, but off, is that in the header image, the 'f' in for is too close to the 'p' in Setup. That second part needs to be spaced down a skosh.


document expectations of the function container build

includes: base image, added artifact(s), and FUNCTION_URI env var
for example, java:
FROM sk8s/java-function-invoker:0.0.1-SNAPSHOT
ADD target/greeter-1.0.0.jar /functions/function.jar

js:
FROM sk8s/node-function-invoker:0.0.1-SNAPSHOT
ENV FUNCTION_URI /functions/function.js
ADD square.js /functions/function.js

shell:
FROM sk8s/shell-function-invoker:0.0.1-SNAPSHOT
ADD echo.sh /functions/script.sh

related to #126

provide at least one page overview doc for 0.0.3


[size-report] support local check

How would it work on pushed branch? Do we go to GH action "size" and see the repot in the build logs? Thanks.

I think you have to rely on build logs in this case. The size-report service has no where to post a comment when it's just a branch.

@abtink Yes, the size report will be printed in the log of GitHub Actions.


Script 5 - Literate code document

Description: A fifth script: an .Rmd or .ipynb files that presents the key useful (not all!) exploratory data analysis as well as the statistical summaries and figures in a little report. There should be a written narrative in this document that introduces and justifies your question, introduces the data set, presents the findings/results, and interprets the findings/results in context of the question. Some critique of the analysis is also expected (limitations, assumptions, etc) and a statement of future directions (what would you do next if you had more time to work on this). The report is expected to be 1-2 written pages (excluding figures, tables and references). You are expected to have a reference section and cite 2-3 external sources (data source can be one of these citations) in addition to citing the programming languages and packages used. Yes, you need to cite the programming languages and packages used in your project. You will learn how to do this in lecture.
Owner: @iamMoid
1st Reviewer: @gn385x

I am planning to include the following topics in our report:

Introduction
Analysis
a. Data
b. Model
Results
Conclusions
References

Let me know if we need to include/modify topics.


Documentation Spelling Mistakes - v2

Bug description
Like #197 I would like to fix some more spelling in docs that have crept in the last couple of years. Samples from reading GitOps docs are:
To have a glimp
instead of
To have a glimpse
How to reproduce
Steps to reproduce the behavior:

Read the docs in full
Pay attention to things outside YAML code blocks

Expected behavior
Slightly better documentation quality

@prometherion I am spending some time today studying the Capsule docs and creating a capsule.txt list for a spellchecker automation which we could potentially run in CI here to solve the issue longer term. Would something like this in CI be useful ? https://github.com/marketplace/actions/check-spelling

Closes via #804.


Bedrock Frequently Has Server-side Errors

Likely unrelated to the client but I'm getting this pretty frequently on Anthropic Bedrock.
anthropic.APIStatusError: Error code: 424 - {'message': 'The system encountered an unexpected error during processing. Try your request again.'}
Also, it seems like this replace the other issue from: https://github.com/anthropics/anthropic-sdk-python/issues/418, so that issue should be resolved now.

I'm also coming up against this error though Bedrock. Would it make sense to simply add handling for 424 in BaseClient._should_retry?

Ah, yes, that does sound like a good idea. We'll take a look at that.


Make unit tests use fake data

Also, clean up sendgrid hooking

Looks like this will finally bring order to the force. More work will be needed to get the tests running properly locally, but that's for tomorrow.

Fixes #33

Fixes #49

LGTM. Thanks for doing this!


Fixed a bug related to the yaml library

Pull Request Test Coverage Report for Build 483

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 93.841%

Totals

Change from base Build 473:
0.007%

Covered Lines:
1676

Relevant Lines:
1786

💛  - Coveralls


Pull from fda0 repo, updating build scripts

Error on app exit, will debug later

Error on app exit, will debug later

Ah, works on windows for me. Does the app launch at all?

Error on app exit, will debug later

Ah, works on windows for me. Does the app launch at all?

Yes, the error reads "vkQueuePresentKHR VK_SUBOPTIMAL_KHR", I'm checking what it is that Vulkan wants here from us. Seems like a non issue for now, since the message suggests it's about performance.


Epic: fix the attach/detach and add python tests for branching

attach and detach commands are implemented per timeline
this is flexible, because we can have different timelines served on different pageservers
OTOH to properly handle a branch on a pageserver, pageserver needs to be aware of the other timelines, e.g. for GC to not mess things up
shall we attach/detach the whole tenant on pageserver?
does this depend on the on-demand download from s3?

#1936 is now merged, attach and detach now handle tenant as a whole
gc tests for branching are tracked in #1899. @stepashka  should we close this?

#1936 is now merged, attach and detach now handle tenant as a whole
gc tests for branching are tracked in #1899. @stepashka should we close this?

Yeah, let's close this


Next greater Element using java

🛠 Issue (Number)

Issue no #376
👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ✔] My code follows the code style of this project.
[✔ ] This PR does not contain plagiarized content.
[ ✔] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Please close the PR #532


Menu not showing the translated title

Hi @nWidart, I am working on creating menus, everything worked well, but when I run the following code in view:
{!! Menu::instance('Main Menu')->getName() !!}
which output the menu name.
Is it possible to have the title of menu instead?
Because in that case we can get the title for different locale.
See that in screenshot below:

Thank you!

Hi,
I don't think you can get the title like that.
Maybe you can of the Menu class.

Thank you for quick reply, @nWidart.
Could you please give me some hints?

 Could you please make me understand? why we have same module at two different places one at vendor folder in root and other in Modules folder?
such as vendor/nwidart/laravel-menus in vendor folder by you and other in Modules with named Menu?

That has nothing to do with this package.
The menu module is different than this package. It handles the UI etc. for instance.

If I am not wrong, the link: https://github.com/Idavoll/Menu/blob/2.0/Providers/MenuServiceProvider.php#L109,  you provided to me pointing to items of menu whereas I need to get the translated version of menu itself?

Yes.. but it's the same principle. Just look through that module if you need more.

Okay, thank you for the hints :), let me try that and see if i can figure it out.


I trained a model myself. How do I test it online in real time

I trained a model myself. How do I test it online in real time？Should I rewrite a file like mobilenet_v2_tsm.py

hi have u solved it?

我这有脚本，直接推理就行

@lxzatwowone1<EMAIL_ADDRESS>

@lxzatwowone1 is it possible for you to share the script? thank you.

894640176@qq,com,can u share the script?thanks so much

Hey, I'll be grateful if you can share with me as well on<EMAIL_ADDRESS>


Feature: log details about Certificates Authority bundle

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8fb49e8) 71.28% compared to head (b428f57) 66.20%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   71.28%   66.20%   -5.08%
==========================================
  Files          43       43
  Lines        2448     2453       +5
  Branches      521      521
==========================================
- Hits         1745     1624     -121
- Misses        526      662     +136
+ Partials      177      167      -10

Files
Coverage Δ

qgis_deployment_toolbelt/utils/journalizer.py
63.88% <100.00%> (-6.27%)
:arrow_down:

... and 4 files with indirect coverage changes


Retrieving authentication result from ReconnectAsync helpers

Summary of changes

Updated MQTTnet.Client.MqttClientExtensions.ReconnectAsync method to return authentication result from underlying client.ConnectAsync call
Created an overload for MQTTnet.Client.MqttClientExtensions.ReconnectAsync method that accepts cancellation tokens as an input parameter

Reasons behind the changes
I found this lack of API during unification of connectivity issues handling logic in my projects that uses MQTTnet.
This change will allow me to find out if attempt to reconnect was successful, and if not - what was the reason:
var result = await client.ReconnectAsync();
if (result.ResultCode != MqttClientConnectResultCode.Success) {
   ... handle the issue, retry one more time etc...
}

Hopefully it makes sense.
Let me know if there is anything else I should improve to get this PR merged into MQTTnet repo.
Thanks!

no idea why the test below failed, but will check and fix
Failed Subscriptions_Are_Published_Immediately [859 ms]
  Error Message:
   Test method MQTTnet.Tests.ManagedMqttClient_Tests.Subscriptions_Are_Published_Immediately threw exception:
System.InvalidOperationException: Sequence contains more than one element

@chkr1011  - looks like I need someone's help to catch this issue. I ran several series of tests using both Resharper runner and dotnet test command - everything passed.
Could you please help me to find out in which conditions it fails? appveyor setup may help
Thanks!


Vuejs type inference does not work with TS 3.4.x

Version
2.6.10
Reproduction link
https://github.com/Patcher56/ts3.4.x-vuejs-issue
Steps to reproduce

create a new vue typescript project (without class syntax) vue create test-ts
open src/components/HelloWorld.vue
add a data variable and try to access it in a computed property

What is expected?
No errors (as the data is defined)
What is actually happening?
Typescript error 2339 telling me
Property 'test' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{ msg: string; }>>'.

I think this has something to do with the changed type inference in Typescript 3.4.x.
Important: Change vetur settings to use workspace dependencies to show errors directly in vscode, else you will only get the error when using yarn serve.

Seems to belong into the vetur repository then, right?

No, because the errors also appear in the terminal when using yarn serve.
Vetur is just responsible for showing me the errors directly in vscode.

/cc @HerringtonDarkholme @ktsn

Looks like TS3.4 has multiple inference issue...
The minimal repro:
Vue.component('test', {
  data() {
    return {
      test: 123
    }
  },
  computed: {
    ttt() {
      return this.test + 1
    }
  },
})

Also spotted another failure:
The catch-all type signature of component
  component(id: string, definition?: ComponentOptions<V>): ExtendedVue<V, {}, {}, {}, {}>;

is causing union type to fail checking.
I need more time for investigation...

I wonder if properties in data are supposed to become properties of the instance when using TypeScript?

Of course...

I filed the same bug against Typescript (Microsoft/TypeScript#30854)

Minimal repro:
type TypedDef<Data, Computed> =
  ComponentOptions<Data, Computed> &
  ThisType<Data & Computed>

type DataDef<Data> = () => Data

export interface ComponentOptions<Data, Computed> {
  data?: DataDef<Data>
  computed?: Accessors<Computed>
}
export type Accessors<T> = {
  [K in keyof T]: () => T[K]
}

declare function component<Data, Computed>(def: TypedDef<Data, Computed>): void;

component({
  data() {
    return {
      foo: 23
    }
  },
  computed: {
    bar() {
      // return this.foo + 1 // comment out the return solves the problem
    }
  }
})

The problem seems to be cyclic inference issue. I think it should goes to TypeScript's repo.

One workaround is assigning a return type to computed
type TypedDef<Data, Computed> =
  ComponentOptions<Data, Computed> &
  ThisType<Data & Computed>

type DataDef<Data> = () => Data

export interface ComponentOptions<Data, Computed> {
  data?: DataDef<Data>
  computed?: Accessors<Computed>
}
export type Accessors<T> = {
  [K in keyof T]: () => T[K]
}

declare function component<Data, Computed>(def: TypedDef<Data, Computed>): void;

component({
  data() {
    return {
      foo: 23
    }
  },
  computed: {
    bar(): number { // adding the return type, seems to solve the error
      return this.foo + 1
    }
  }
})

One workaround is assigning a return type to computed

Good call. Just discovered that workaround is documented here.

The best way to avoid the issue now is to annotate return type of computed method... We cannot make much progress since it is an upstream issue in TS.

The best way to avoid the issue now is to annotate return type of computed method... We cannot make much progress since it is an upstream issue in TS.

Unfortunately it also happens if you have a validator on a prop:
export default Vue.extend({
  props: {
    foobar: {
      required: true,
      type: String,
      validator(foobar: string): boolean { return ['foo', 'bar'].includes(foobar); },
    },
  },

  data(): { initialFoobar: string } {
    return {
      initialFoobar: this.foobar, //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    };
  },

  computed: {
    foobang(): string {
      return `${this.foobar}!`; //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    },
  },
});

Breaks our entire build, easily 100+ errors after stepping up from TS v3.3.3333 to v3.4.4. Too bad, too, because this version of TS introduced some handy features for exactly what I'm working on right now... 😩

Also happens if you have a Function-type prop:
export default Vue.extend({
  props: {
    foobar: {
      required: true,
      type: String,
    },

    // With this, errors. Without this, no errors.
    someFunc: {
      required: true,
      type: Function,
    },
  },

  data(): { initialFoobar: string } {
    return {
      initialFoobar: this.foobar, //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    };
  },

  computed: {
    foobang(): string {
      return `${this.foobar}!`; //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    },
  },
});

(Note: the two examples I gave are not fixed by the workaround mentioned)

/cc @DanielRosenwasser

@kjleitz not sure what is the issue on my vscode

I would recommend annotation the function with PropType
export default Vue.extend({
  props: {
    foobar: {
      required: true,
      type: String,
    },

    someFunc: {
      required: true,
      type: Function as PropType<()=>any>, // try annotate with a type
    },
  },

  data(): { initialFoobar: string } {
    return {
      initialFoobar: this.foobar, //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    };
  },

  computed: {
    foobang(): string {
      return `${this.foobar}!`; //=> Property 'foobar' does not exist on type 'CombinedVueInstance<Vue, {}, {}, {}, Readonly<{}>>'
    },
  },
});

Please refer to the comment here:
https://github.com/Microsoft/TypeScript/issues/30854#issuecomment-485893681

//`/types/myVue.d.ts`
import Vue from "vue";
declare module "vue/types/vue" {
  interface Vue {
    $myConfig: string;
  }
}

We also had a component start throwing a lot of errors after upgrading from TS 3.3.3333 to 3.4.5
Thanks to this comment, went back and checked that component and, sure enough, one of the computed properties did not have a return type annotated. With that annotation added, the build compiled without issue.
Per the TS comment, perhaps the docs would be best updated as
"you will need to annotate the return type on methods like render and those in computed"

Yeah, unfortunately it sounds like this was just the same limitation we've always known. My best advice is to make an ESLint rule that catches this, since it is hard to report circularities for us during inference.

To add to @kjleitz unresolved issues, a prop type of Vue also breaks it.

For anyone getting this error via vetur, but not in console: using required seems to stop it from screaming.

I found a very similar issue, with the exact same error, if I used a render() method that used some "props" and wasn't annotated as returning VNode.
Weirdly, instead of getting errors about the render method, or about "props", I got errors about some "data" I used in the mounted() and beforeDestroy() methods.

Best workaround is to use the new Vue Composition API. It is a lot cleaner for typescript and works also with typescript versions > 3.3.4000.

I just Wonder Any Workaround that can Work?
I met this and spent hours for no solution......Seems this has been a problem for over 2 years???

Best workaround is to use the new Vue Composition API. It is a lot cleaner for typescript and works also with typescript versions > 3.3.4000.

when using composition api, I NEED TO access my custom props in setup function, and I always get type error saying "Property 'pagination' does not exist on type xxx", so this is never a workaround, i think.

@AlanKnightly this has been working for me:
import { createComponent } from '@vue/composition-api';

export default createComponent({
    props: {
        rows: Array,
        page: Number,
        filterKey: String
    },
    setup(props, context) {

        const currentPage = props.page;

        return {
            currentPage
        };
    }
});

Closing as this cannot be fixed and is documented: https://vuejs.org/v2/guide/typescript.html#Annotating-Return-Types


Default value "False" of BaseModel is ignored

The default values of Field get ignored.
class TestModel(BaseModel):
    test_field: str | None = Field(default="Some default value", description="Description...")

Is the only option to add an validator like this:
    @root_validator
    def set_default_values(cls, values):
        values["test_field"] = (
            "Some default value"
            if values.get("test_field") is None
            else values["test_field"]
        )
        return values

Or is there another way for the default values to work?

Show how you use it?
I cannot reproduce this issue.

Hi!
Sorry for the delay. I was away and had no time.
I checked my code again and you are right. With string there is no problem. No idea why I didn't catch that. I ran into the problem with a boolean field and wanted to make it clearer with String... After a bit more testing I found only for default value False I have a problem.
from fastapi import FastAPI
from pydantic import BaseModel
from pyfa_converter import FormDepends

class TestPydanticModel(BaseModel):
    default_false: bool = False

class TestPyfaModel(BaseModel):
    default_string: str = "Test"
    default_true: bool = True
    default_false: bool | None = False

app = FastAPI()

@app.post("/test-pyfa")
async def test_pyfa(test_model: TestPyfaModel = FormDepends(TestPyfaModel)):
    return test_model

@app.post("/test-pydantic")
async def test_pydantic(test_model: TestPydanticModel):
    return test_model

I took a look at the code and the method __fill_params has the line default=default or None,. If default is False, default or None will be None instead of False.
Changing the order could fix this: None or default instead of default or None.
    @classmethod
    def __fill_params(
        cls, param: Callable[..., FieldInfo], model_field: ModelField, default: Any
    ) -> FieldInfo:
        return param(
            default=default or None, # Problem comes from here!
            alias=model_field.field_info.alias or None,
            title=model_field.field_info.title or None,
            description=model_field.field_info.description or None,
            gt=model_field.field_info.gt or None,
            ge=model_field.field_info.ge or None,
            lt=model_field.field_info.lt or None,
            le=model_field.field_info.le or None,
            min_length=model_field.field_info.min_length or None,
            max_length=model_field.field_info.max_length or None,
            regex=model_field.field_info.regex or None,
            **model_field.field_info.extra,
        )

Hello, indeed, I think that:
default_value=default if isinstance(default, bool) else default or None

Might fix this issue, I'll run some tests and post it (probably tomorrow)

@trashutz, hello!
Fixed
https://github.com/dotX12/pyfa-converter/releases/tag/<IP_ADDRESS>
https://pypi.org/project/pyfa-converter/<IP_ADDRESS>/

@dotX12 Hi!
It works for me.
Thank you!


Error with "action execute" calls on modules.

Hello,
I'm trying to make a sample project out of the doc and can't get it working properly with all the docs I went through. I might be missing something really important. I'm actually able to get Semantic modules generated by ember but I get stuck when I try to interact with them and use actions on them.
I tried many different things but the closer I got was by following this guide.
Details on what I did. To see the actual error, please go to the end of my explanation.

I first installed ember: npm install -g ember-cli.
Then I created a new test project: ember new testEmberSemantic
Created the basic templates and a component for my future accordion test:

ember generate template application
ember generate template index
ember generate component accordion-test

Then I install Semantic-UI-Ember and generate it:

ember install semantic-ui-ember
ember generate semantic-ui-ember

I then put the following in templates/components/accordion-test.hbs:

{{yield}}

{{#ui-accordion as |execute|}}

    Semantic UI

    Be sure to check out
the example

    Example

    This is a great example!

{{/ui-accordion}}

I added a simple {{accordion-test}} in templates/index.hbs and {{outlet}} in templates/application.hbs.

The error encountered.

Then, if I try to run ember server and load the webpage at localhost:4200, I have the following error in the console with nothing rendered on it.

Assertion Failed: A helper named "execute" could not be found

If I try the same without the execute and action parts in templates/components/accordion-test, I get a normal page but, of course, without event handler on the button.
I kinda guessed, from what I read from the docs than it implicitly calls a method on the ui-accordion component in the base mixin that is supposed to call the method on the semantic component but it's not clearly said.
I even tried to add the following in components/accordion-test, just to make sure I wasn't required to create the "helper" myself.
import Ember from 'ember';

export default Ember.Component.extend( {
  actions: {
    execute( command, argumentOne ) {
      $( '.ui.accordion' ).accordion( command, argumentOne );
    }
  }
} );

But that didn't help.
I think the main problem probably comes from my usage of Semantic-UI-Ember but this is the closest I can get to something working based on what I can find in the docs. Maybe that needs to be updated, to make sure a newcomer can get to a working example easily.
Also, I did all of this using node v7.1.0 and did not think it could be coming from it. However, I should try soon if it works with node 6.9.1. I wasn't able to, yet.
Edit: I tried this with node 6.9.1 aswell and had no better results, so it doesn't seem to be linked with the node version, here.
Thank you for your patience while reading this. :)

Same error here.

I've got the same issue whether I nest it or not. What else did you do to get that result, @Rev3rse , please?

@Vrakfall try this instead; the example

@Panman8201 I still get the same error:
Assertion Failed: A helper named "execute" could not be found

@Vrakfall  I am getting same error, did you find how to make this work ?

Humm... execute is technically already a closure action, so I wonder if it should be called like this instead: {{action execute "open" 1}} or {{action (action execute "open" 1)}}

@Panman8201 , thanks {{action (action execute "open" 1)}} works

Thanks for the help @Panman8201

Installed Ember/Semantic-UI-Ember and was running through examples per initial post above for this issue. Got same errors as original post. Not sure if fixes above (which work) reflect new guidance for use of Semantic-UI-Ember overall? Or if the docs are out of date and remain erroneous?

For anyone looking at this, the documentation always recommends you use
onclick={{action (execute 'open' 1)}} to properly use the execute as a closure action. If you don't use it with onclick, then you have to use the work arounds listed here.


Indicator fixes and update MDC Ripple

Fixes various bugs with the MDC Tab Bar and its navigation behavior:

Tabs as links: Indicator will now respond to changes in the URL or query params not triggered by clicking the tabs directly.
When the array of tabs changes to a different set of tabs without un-rendering the parent tab bar, the indicator is updated accordingly.
Tab bar scroller will now scroll hidden active tabs into view.

Additionally, MDC Ripple has been upgraded to the latest version to fix styling issues in Edge.

@danielraggs Now that MDC Tabs has shipped 0.3.0, is this PR ready for review + merge?

@Kerrick This is ready for code review and to be merged!

Thank you so much for the PR! This will ship out with v0.0.37 👍

I've just tried creating an Ember app with Ember Material Components Web 0.0.38.
I added this to the application.hbs:

{{#mdc-tab-bar as |bar|}}
{{#bar.tab "fruits" active=isFirstActive become-active=(action (mut isFirstActive))}}
Fruits
{{/bar.tab}}
{{#bar.tab "vegetables" active=isSecondActive become-active=(action (mut isSecondActive))}}
Vegetables
{{/bar.tab}}
{{#bar.tab "meats" active=isThirdActive become-active=(action (mut isThirdActive))}}
Meats
{{/bar.tab}}
{{/mdc-tab-bar}}
And created three routes to go with it.
When changing route using the address bar the indicator was not following the route?
Am I missing anything?

@MrChriZ You shouldn't pass active and become-active to the {{bar.tab}} components if you want their active state to be tied to the router. Try it like this:
https://github.com/secondstreet/ember-material-components-web/blob/da299ef5f0a5f1f4c0bba0c016cadfb7fa459636/tests/dummy/app/templates/application.hbs#L838-L848

Ah that works thanks :)


is iPad4 not supported?

I am trying to launch a capture still image on my iPad4. Every time I launch the app no preview is shown and camera doesn't start. It works fine on my iPhone 6.
First I tried this to see it will work
stillCamera = [[GPUImageStillCamera alloc] initWithSessionPreset:AVCaptureSessionPresetHigh cameraPosition:AVCaptureDevicePositionBack];
stillCamera.outputImageOrientation = UIInterfaceOrientationLandscapeRight;
stillCamera.horizontallyMirrorFrontFacingCamera = NO;
stillCamera.horizontallyMirrorRearFacingCamera = NO;
filter = [[GPUImageSepiaFilter alloc] init];
[(GPUImageSepiaFilter *)filter setIntensity:0.0];
[stillCamera addTarget:filter];
[filter addTarget:filterView];

//whole screen fill mode
filterView.fillMode = kGPUImageFillModePreserveAspectRatioAndFill;

[stillCamera startCameraCapture];

Then I thought it maybe because I am using pretty high preset. So I changed it to lower res and still the camera doesn't start. What's happening? Is this project not supported on iPad4 at all?
stillCamera = [[GPUImageStillCamera alloc] initWithSessionPreset:AVCaptureSessionPreset1280x720 cameraPosition:AVCaptureDevicePositionBack];

I also tried the sample FilterShowcase project on my iPad4 and that doesn't work either.


linux_6_0: add hardened kernel

Description of changes
Add linux_6_0_hardened to all-ackages.
Fixed this error:
error: attribute 'linuxPackages_6_0_hardened' missing

       at /home/user/works/nixops/config-defs/core.nix:26:22:

           25|     kernelModules = [ "tls" ];
           26|     kernelPackages = pkgs.linuxPackages_6_0_hardened;
             |                      ^
           27|     loader.grub.enable = true;
       Did you mean one of linuxPackages_5_10_hardened or linuxPackages_5_4_hardened?
(use '--show-trace' to show detailed location information)

I do not use linux_latest_hardened because periodically the latest kernel version does not support the zfs module.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

6.0 is EOL upstream, is now really the time?

The kernel is still required to work with the ZFS file system - zfs 2.1.7 - Linux: compatible with 3.10 - 6.0 kernels.

We still remove kernels when EOLed.

zfs bump for 6.1 support is now PR'd https://github.com/NixOS/nixpkgs/pull/211886

Just in time for #212143 :>


Initialization of large models on multi-hosts environment

Hi all,
I am wondering what is the preferred way to create a model that is too large to fit in a single device
As a reference starting point, if I use data parallelism, I will first create per-device data arrays, and use make_array from single_device_arrays to put them on the global mesh (This is basically following https://jax.readthedocs.io/en/latest/_autosummary/jax.make_array_from_single_device_arrays.html#jax.make_array_from_single_device_arrays)
Since by default the pre-defined modules in equinox will initialize the full set of parameters on every device, I cannot just follow the guide in https://docs.kidger.site/equinox/tricks/#custom-parameter-initialisation and update the parameters to the shared version after I create the model.
My current way of bypassing this is to create a wrapper class of the nn.Modules I want to use, so I can create the sharded version of the parameters on each device, and then combine them as I would for the data parallelism case.
Here is a minimal example for wrapping the eqx.nn.Linear class
https://gist.github.com/kazewong/c976b48c5870d866496740341382acb5
Since the multi-host interface in Jax is still experimental, we probably don't want to put too much of this into the equinox core code. To make creating large models easier now, I think a wrapper class or a decorator is probably the easiest way, but I want to see what people think about this before submitting a PR. @patrick-kidger

So one way to do this with the current API is to create the model 'skeleton' via
eqx.filter_eval_shape(SomeModule, ...)

and then fill in the parameters with eqx.tree_at afterwards.
I do this when translating model weights from PyTorch, for example.
I'm not sure what the cleanest way of doing this in general is. Ideally it wouldn't require wrapping the constructors. These can be thought of as functions that return pytrees, so something respecting that in some way would be ideal.

I see! I tried using filter_eval_shape and it does work for me. Do you think it is worth making a short tutorial notebook for this? I have the script so converting it into a notebook shouldn't take too long. Let me know if this is useful then I can work on a PR.

If this ends up being the best way to do it, then yes! I think having an example would be really useful.
Right now I'm not completely convinced it is the best way, though. It's certainly a lot of work. I'm wondering if there's some way we can directly create the arrays in the right way by wrapping the constructor in a filtered/tree-map'd version of the usual JAX operations here. (make_array from single_device_arrays etc.) Right now I've simply not thought about it yet!

I agree if there is an ergonomic way to initialize a shared model, that would be great. I am trying to figure out how to best do this, and here are some thoughts:
The ideal scenario is we have a function that does the following
def init_shard_model(ModelClass, mesh, sharding, ...) -> model:
...

I have so far run into two complications:

Sharding internals of a model differently. Take a linear layer with 512 inputs and 256 outputs as an example, the weight matrix will have shape (256, 512) and the bias vector will have shape(256,).  Say somehow I want to shard the weight matrix across its second axis, and the bias vector across its first axis, where should I give that information? Right now I am defining a sharding function for each kind of layer, so it is set there
Sharding structured arrays. Say my model has an upper triangular matrix as its weight at initialization, and I want to shard it along one axis. This means when I construct the local arrays, I need to pass the information of the process IDs or some bookkeeping parameters to make sure the correct part is initialized on each host before I combine them.

I think this may be why the devs of Levanter rolled their own nn library haliax on top of equinox so they can handle these issues, which is essentially smart wrapping around the equinox layers? @dlwh
I am gonna try a number of things in the coming weeks, any input will be awesome!

This is indeed one of the main reasons I did names. (There are a few more but I won't belabor them here.) It basically defines this problem away, though it does mean you have to do weird gymnastics when you have square arrays that have semantically identical axes. But it's a price I'm happy to pay. (Obviously happy to have you over in Haliax land, but only if it appeals.)
You could instead follow something more like what flax does, if you wanted. See for example, t5x. It's basically the same as Haliax except the names of the axes aren't carried around with the array and so you occasionally have to sprinkle more wsc's. Obviously I'm partial to Haliax but tastes vary.
Regardless, either way the basic idea is to do initialization inside jit and use with_sharding_constraint and/or out_shardings to ensure things are correct. IMHO re (2) the right way to do any of this is to always always do as much as you can in a "global" way using jit, and only fall back on make_array_from_callback when you absolutely have to (or for data loading).

Thank you both!
To riff on @dlwh's last paragraph -- doing as much as possible inside JIT -- would something like
@jax.jit
def f():
    model = SomeModel(**hyperparams)
    return eqx.filter_shard(model, shard_tree)

work? By describing an appropriate shard_tree then this would also address @kazewong's first point, about sharding each layer differently.
(I can see that this would be a t5x way of doing things rather than a Haliax way of doing things.)

I'd actually say Haliax and flax/t5x are closer to each other than what you're proposing. (Not saying that's a bad thing, just trying to clarify.)
class SomeModel(Module):
    param: hax.NamedArray
    # i use static methods but whatever
    def __init__(...):
          self.param = hax.random.normal( (Embed, Mlp), ...)  # [Embed, Mlp]

and hax.random.normal is basically:
   def normal(key, shape: AxisSpec, dtype=float):
    shape = ensure_tuple(shape)
    jax_shape = _to_jax_shape(shape)
    jax_array = jrandom.normal(key=key, shape=jax_shape, dtype=dtype)

    # this snippet is in a wrapper. simplifying some
    physical_axes = infer_physical_axes_from_logical(shape)  # uses a global context manager
    jax_array = with_sharding_constraint(jax_array, physical_axes)

    return NamedArray(jax_array, shape)

flax/t5x is more like:
class SomeModel(Module):

    @nn.compact
    def __call__(...):
          param = param_with_axes("param", init, (512, 2048), jnp.float32, axes=("embed", "mlp"))

and param_with_axes would have something like this in it (simplifying a bit)
    physical_axes = map_logical_to_physical(global_axis_mapping, axes)  # uses a global context manager
    param = with_sharding_constraint(param, PartitionSpec(*physical_axes)

so it injects wscs at parameter declaration like Haliax.
By comparison, you're proposing keeping sharding an explicit outer step that operates on entire modules trees. Haliax also supports doing it that way, but it's not really the default anymore. When you do it that way, we still have the map_logical_to_physical function usable because the module tree has the names in it, so it's relatively painless from a user's perspective.
My suspicion is that what you're proposing will prove quite cumbersome compared to keeping sharding at the per-parameter declaration site (as in Flax/t5x or Haliax), but I'm happy to be proven wrong.

Right! I'm just getting at the Flax-vs-Haliax distinction of whether there's a named array object available at call time.
The thing is that I don't see another way to support this kind of per-parameter behaviour in an off-the-shelf library like Equinox. I think if per-parameter behaviour is required then the user usually needs to control the definition of every layer? (Or else use some eval_shape + tree_at hackery to add such support after-the-fact, as above.)
To the turn the above into something actionable. I think I'd like to include an example on this topic as per @kazewong's suggestion, and I'm trying to figure out what approach to recommend. I'd like to include both (a) a pure-Equinox solution (whether that's my latest thing, or an eval_shape + tree_at combination, or something else) and (b) a reference towards Haliax.
(To wax a little philosophical, by the way -- this kind of thing comes up in other scenarios too, such as which parameters to apply a transform to: differentiate/vmap/etc. Now JAX's model here is either to specify things at the call site (e.g. jax.jit(..., static_argnums=...)) or in the call itself (e.g. lax.stop_gradient, wsc), as opposed to putting them in the model definition (e.g. torch.tensor(..., requires_grad=True)). The problem with the latter is that it only works for a fixed set of transformations known ahead-of-time, but isn't extensible to new ones that may become available after the model definition has been written. This extensibility, and JAX consistency, are the reasons Equinox tends to go for top-level pytree-manipultation tools like eqx.partition, rather than in-the-pytree specifiers like (the nonexistent) eqx.field(requires_grad=True).)

Yeah, makes sense as a philosophy. In my experience, just as with stop_gradient in e.g. softmax, you will need to insert with_sharding_constraints deep inside the "__call__" and not just at the top level, particularly when dealing with Linear in FSDP-ish code. maybe it's fine to expect anyone who cares to thread through enough context to call wsc themselves. That means you maybe won't be able to use the built-in MHA implementation but probably fine.


Missing Border map

Hello!
Very nice job on the r6maps site. Do you intend to put the Border map which is currently missing?
I do not know if I have time, but do you need help to do so?

@mvy Hey sorry I didn't reply.  I was waiting for Ubisoft to update their tactical board with Border as I use their base map images.  At first I thought it would happen sooner.  From now on for new maps I will probably at least do something rough to start with in-game screens.
Anyway, Border is now updated. :)


Reordering of parse_url to handle separator characters inside auth information

Fixes #814.

I'm happy with this change (and the associated reasoning in #814), so I'm :+1:.

I'm :-1: and will discuss it on #814.

I think I see your point. Essentially, if we make fixes for and provide test cases for one non-RFC-compliant edge case, where does it stop?
I do think there's an argument to be made: the separator characters are at least RFC-valid credentials, whereas there's no RFC-valid reason to have a non-urlencoded "@" elsewhere in the URL, but I'll defer to you guys on which non-standard URLs you want to fail.

whereas there's no RFC-valid reason to have a non-urlencoded "@" elsewhere in the URL

That's not entirely true. RFC 3986 allows a non-urlencoded "@" in a path segment, for example, and RFC 7230 allows it as well because it imports the same definition.

Ah, of course you're right. I saw it in the "reserved" table and didn't see it was specifically allowed lower down.


Qiskit update

Baseline update to work with qiskit 0.30.0, which is Aer 0.9.0

Found a bug after checks passed. Will open a new one once fixed to prevent merging-with-bug


tour: some errors on the spanish version

Following https://github.com/golang/go/issues/9090#issuecomment-196977535:

This translate error are present on the tour yet,
Observa que el tipo de indica [...] must be Observa que el tipo se indica[...] and more.

This changes are gone at sometime.

First errors found on https://go-tour-es.appspot.com/#7
The Spanish version have some typos again. I'm newbie with Go and its community so I'll be happy if you tell me where I can fix this typos on the repo to make a pull request with all typos that I can find through the tour.

I would file a bug at https://github.com/golang/tour/
We don't track tour bugs here, and definitely not non-English ones.
Thanks!

from https://github.com/golang/go/issues/19066#issuecomment-279527474
closing this, then. We don't control or deploy the spanish tour translation. You could file a bug to https://github.com/golang/tour/ and then contact the spanish tour maintainer to propose a fix.


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 4e48e71:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 4e48e71:
:clock10: Full build: the average full build time is 10 min(s) 44 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 4e48e71:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Unable to pre-sign transactions with web3.eth.sign

https://github.com/christianlundkvist/simple-multisig/blob/71136f4d9c8c1352ceefaf96dd2ed480b8e5fb60/test/simplemultisig.js#L3
Currently, it's not possible to presign transactions with web3.eth.sign because you can't pass a hex string to the signing function.
Or any ideas how to to so?

web3 purposefully disabled the ability to sign arbitrary hashes because they were worried that people would be tricked into signing transactions. Thus web3 prepends a string \x19Ethereum signed message or something like this. I thought personally this was a bit silly because it will just lead to people creating multisigs and other high value contracts that require this exact string to be passed in.
To answer your question you have to use a tool like lightwallet or other signing tool to sign the data.

Which shows that the web3 approach is a bit questionable, because malicious developers won't be stopped by this.


Switching networks is buggy

Switching networks frequently causes uncaught exceptions and buggy behavior.

Additionally, the .getBlockCount() promise resolves even when the network is supposed to be destroyed

I think we should disable switching network on wallet loaded until we find a solution

This was fixed by disabling the wallet deletion until wallet is synced


Bridge: Mouse over on bridge fee

Pendulum bridge fee is currently 0, but it may not be in the future, add a mouse over on modal's information, on bridge fee to explain that. (on pendulum official bridge frontend you may find a good message to copy)


Incorporate Slope Percentage Data

Feature Description:
Integrate slope percentage metrics into the OSM Dashboard's map data visualization, specifically for delineated chairlift routes, thereby enriching the displayed table with critical terrain insights for the users.
Solution Description:

Develop a function to calculate slope percentages for the desired individual segment of chairlift/trail runs.
Integrate slope percentage data into the map visualization, ensuring clear presentation alongside other map calculations.
Enable user interaction to access slope percentage information for specific segments based on the particular interval.

Alternatives Considered:

The adoption of gradient color coding to intuitively depict variations in slope steepness, enhancing the visual comprehension of terrain gradients directly on the map.
Introducing a feature that permits users to interactively specify a range of slope steepness, thereby customizing the data presentation to align with individual preferences or requirements for statistical analysis.

Additional Context:
This enhancement significantly augments the mapping capabilities by integrating slope percentage data, thereby providing a more comprehensive terrain analysis. It enables users to gain deeper insights into skiing patterns and trail characteristics based on slope steepness, facilitating informed decision-making and enhancing the overall user experience on the platform.

Completion of Slope Percentage Feature :  Commit: 4b3e8b6
Duration and Speed Analysis: Implemented logic to determine segment duration from trail times, facilitating accurate speed calculation for each segment.
Distance Calculation: Derived segment distances from average speeds and time, enabling precise distance tracking.
Slope Percentage Computation: Utilized segment distance and elevation data to calculate and integrate slope percentages in the codebase.
Slope Display in UI: Integrated the calculated slope percentages into the segment details table, enhancing the data presentation with this crucial metric.
Closing this issue as the feature has been successfully implemented and verified. Users can now access detailed slope information within the segment table for an informed trail experience.

Completion of Slope Percentage Feature :  Commit: 4b3e8b6
Duration and Speed Analysis: Implemented logic to determine segment duration from trail times, facilitating accurate speed calculation for each segment.
Distance Calculation: Derived segment distances from average speeds and time, enabling precise distance tracking.
Slope Percentage Computation: Utilized segment distance and elevation data to calculate and integrate slope percentages in the codebase.
Slope Display in UI: Integrated the calculated slope percentages into the segment details table, enhancing the data presentation with this crucial metric.
Closing this issue as the feature has been successfully implemented and verified. Users can now access detailed slope information within the segment table for an informed trail experience.


Add show password toggle

Nowadays, when it comes to signup, it's common to NOT force user to type password twice, but offer an option (usually a toggle button) to show password if they want to confirm the password, especially for mobile client.
So I suggest to add an easy configuration to switch between these two modes for sign-up page.

+1

+1

+1


Remove build-script-impl target calculation

This removes some code that was duplicated between build-script and build-script-impl. It was duplicated between these for migration purposes, but isn't needed for that purpose anymore.

Assuming this passes testing I'm all for getting rid of this cruft.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - b059fd5b54110c701b2c3edf5227b31b4cca721e

@swift-ci please test Linux

Build failed
Swift Test Linux Platform
Git Sha - b059fd5b54110c701b2c3edf5227b31b4cca721e

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - b059fd5b54110c701b2c3edf5227b31b4cca721e

Seems that IndexStoreDB is unhappy:
11:45:33
/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/indexstore-db/Tests/ISDBTibsTests/TibsBuildTests.swift:97: error: TibsBuildTests.testBuildMixedLang : XCTAssertEqual failed<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>"Swift Module main"]") is not equal to<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>"Swift Module main"]") -

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - b059fd5b54110c701b2c3edf5227b31b4cca721e

@swift-ci please test Linux platform


Implement benchmarking system to measure and compare rule execution data

Currently, we're unable to quantify how subtle changes to a rule or the Plaid runtime affect performance. This PR implements a mechanism to benchmark and compare Plaid rules, enabling developers and plaidmins to maximize their instance's performance. When enabled, it logs rule execution metadata (rule name, execution time, computation used) to a task that aggregates this data based on rule name. On shutdown, the benchmarking system writes this data out to a file.
Triggering shutdown of the server is done with CTRL+C or by sending a SIGTERM signal. Plaid is configured to listen for this signal and begin a graceful shutdown. Right now, graceful shutdown means waiting for the benchmark_loop task to exit. This allows us to guarantee that our benchmarking data will be written to a file prior to exiting. However, graceful shutdown allows us to do more in the future. We could extend this idea to the execution loop and only shutdown once the message queue is empty, therefore guaranteeing that all logs will be processed.
Output
The benchmarking system outputs a file like:
Performance Report:
Module: testing_test_release_default.wasm
	Runs: 3510
	Average Computation Used: 4752.00
	Average Execution Time (microseconds): 2012

Module: testing_test.wasm
	Runs: 3510
	Average Computation Used: 31317.00
	Average Execution Time (microseconds): 1967

In this simple example, we can see that when we compile the testing_test.wasm rule with the --release flag, we reduce the computation used by about 85%! That's a big difference.

Closing in favor of https://github.com/obelisk/plaid/pull/57


python3Packages.datafusion: 0.7.0 -> 22.0.0

Description of changes
Bump the python datafusion package from 0.7.0 to 22.0.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 226262 run on x86_64-linux 1

5 packages failed to build:

datafusion-cli
python310Packages.ibis-framework
python310Packages.ibis-framework.dist
python311Packages.ibis-framework
python311Packages.ibis-framework.dist

4 packages built:

python310Packages.datafusion
python310Packages.datafusion.dist
python311Packages.datafusion
python311Packages.datafusion.dist

Result of nixpkgs-review pr 226262 run on x86_64-darwin 1

8 packages failed to build:

python310Packages.datafusion
python310Packages.datafusion.dist
python310Packages.ibis-framework
python310Packages.ibis-framework.dist
python311Packages.datafusion
python311Packages.datafusion.dist
python311Packages.ibis-framework
python311Packages.ibis-framework.dist

1 package built:

datafusion-cli

it looked like ci passed even if my local build failed
ld: framework not found Security


Explain link depesz "too big"

The explain link create a "get" request that looks like:
http://explain.depesz.com/?is_public=0&is_anon=0&plan=%09Aggregate%20%20%28cost%3D1114961.18..1114961.19%20rows%3D1%20width%3D8%29%0A%09%20%20Output%3A%20count%28DISTINCT<snip>

and could be ... very very big :(=)
This errs with various errors (depending on browser and time of day). Would it be possible/easy to change that to a POST request?

Commit 332a155 change the submit method to POST, please give it a try and let me know the result.