Have you considered make this a ROS node

Have you considered make this a ROS node so that depth, and segment classification can be integrated via ROS messages. This would allow switching between different implementation of these components, and would be language agnostic.

Yes, I have. You are correct; those would be very neat advantages, but it would take a bit of time to refactor everything. It's on my todo list, though. And once again, very sorry about the slow replies, it's a busy period here and I'm also CUDA-less. :(

Note to self: Peidong suggested ROS2 should be used (http://wiki.ros.org/ROS/Tutorials/WritingPublisherSubscriber(c%2B%2B)).

Yes, I have. You are correct; those would be very neat advantages, but it would take a bit of time to refactor everything. It's on my todo list, though. And once again, very sorry about the slow replies, it's a busy period here and I'm also CUDA-less. :(

Have you already make this a ROS node?

Sorry, I haven't added ROS support and I don't think I'll have time in the foreseeable future. I'd be more than happy to review PRs adding that if someone does it!

Do you know how to make a KITTI data with a rosbag which has rgb and depth message?
发自我的iPhone
------------------ Original ------------------
From: Andrei Bârsan<EMAIL_ADDRESS>Date: Thu,Apr 30,2020 9:33 PM
To: AndreiBarsan/DynSLAM<EMAIL_ADDRESS>Cc: 0dmf0<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [AndreiBarsan/DynSLAM] Wrap DynSLAM as a ROS node  (#38)
Sorry, I haven't added ROS support and I don't think I'll have time in the foreseeable future. I'd be more than happy to review PRs adding that if someone does it!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

ETH Zurich seem to have a utility for building rosbags from KITTI sequences here: https://github.com/ethz-asl/kitti_to_rosbag
However, since KITTI doesn't come with depth (apart from the LiDAR), you'd need to compute that separately, and modify the code above to include one additional depth or disparity image in each frame.
If you want to, you can use the DispNet also used by this project, or if you want to upgrade to newer tech (DispNet is almost 5 years old), I'd recommend one of my colleague's awesome DeepPruner: https://github.com/uber-research/DeepPruner (MIT licensed)

ETH Zurich seem to have a utility for building rosbags from KITTI sequences here: https://github.com/ethz-asl/kitti_to_rosbag
However, since KITTI doesn't come with depth (apart from the LiDAR), you'd need to compute that separately, and modify the code above to include one additional depth or disparity image in each frame.
If you want to, you can use the DispNet also used by this project, or if you want to upgrade to newer tech (DispNet is almost 5 years old), I'd recommend one of my colleague's awesome DeepPruner: https://github.com/uber-research/DeepPruner (MIT licensed)

Well, so can you explain clearly how to use another KITTI dataset? I don't know how to process another dataset.

Or can you provide another KITTI dataset which has already been processed?
Thanks

Do you mean pre-processed for DynSLAM or pre-processed for ROS?
For DynSLAM there are tools in this repo (MNC and dispnet-flownet-docker in preprocessing/) do do it for KITTI data. For ROS I am not sure; I am not familiar with ROSbags.

Do you mean pre-processed for DynSLAM or pre-processed for ROS?
For DynSLAM there are tools in this repo (MNC and dispnet-flownet-docker in preprocessing/) do do it for KITTI data. For ROS I am not sure; I am not familiar with ROSbags.

Everytime I pre-process KITTI data, it shows:
dmf@dmf-GS63-7RE:/media/dmf/丁/DynSLAM$ scripts/preprocess-sequence.sh kitti-tracking data/kitti/tracking training 6Failure: Invalid directory structure for the tracking dataset.
Expected directory structure:
├── training
│   ├── calib
│   ├── image_02
│   │   ├── 0000
│   │   └── etc.
│   ├── image_03
│   │   ├── 0000
│   │   └── etc.
│   └── velodyne
│       ├── 0000
│       └── etc.
└── testing
└── .
Do you know how to solve this?

What does your dir structure look like?
On Sat, May 2, 2020 at 10:53 AM 0dmf0<EMAIL_ADDRESS>wrote:

Do you mean pre-processed for DynSLAM or pre-processed for ROS?
For DynSLAM there are tools in this repo (MNC and dispnet-flownet-docker
in preprocessing/) do do it for KITTI data. For ROS I am not sure; I am
not familiar with ROSbags.
Everytime I pre-process KITTI data, it shows:
dmf@dmf-GS63-7RE:/media/dmf/丁/DynSLAM$ scripts/preprocess-sequence.sh
kitti-tracking data/kitti/tracking training 6Failure: Invalid directory
structure for the tracking dataset.
Expected directory structure:
├── training
│   ├── calib
│   ├── image_02
│   │   ├── 0000
│   │   └── etc.
│   ├── image_03
│   │   ├── 0000
│   │   └── etc.
│   └── velodyne
│   ├── 0000
│   └── etc.
└── testing
└── .
Do you know how to solve this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AndreiBarsan/DynSLAM/issues/38#issuecomment-622966030,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJT2YWGJ2WOK6SFH4WLDOLRPQXXFANCNFSM4D64R2OQ
.

is it wrong?

/media/dmf/丁/2020-05-02 23-05-35屏幕截图.png

Seems like the folder is called training 1 instead of training. Maybe
that's the issue?
On Sat, May 2, 2020 at 11:06 AM 0dmf0<EMAIL_ADDRESS>wrote:

[image: 图片]
https://user-images.githubusercontent.com/60035642/80867912-7d7ed280-8cc9-11ea-8d48-ed0e79373367.png
is it wrong?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AndreiBarsan/DynSLAM/issues/38#issuecomment-622967873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJT2YTSSQHWDAB7NMA3UKLRPQZG7ANCNFSM4D64R2OQ
.

bash:./preprocess-sequence.sh: no such file
Do you know why?


Implement Vec<String>

Solves #191.
Blocker: Dart generator is creating unused code, I'm trying to find a workaround before declaring this mergeable. Done!

Blocker: Dart generator is creating unused code, I'm trying to find a workaround before declaring this mergeable. Done!

Congrats!

Thank you for the PR! Only a few tiny suggestions and I am ready for merging ;)

Just ping me when you are done and I will merge it

I re-disabled Linux integration tests for now so please merge after this run @fzyzcjy


[protobuf] protoc is always a host dependency

Is your feature request related to a problem? Please describe.
Currently when the protobuf port is installed the protoc executable is compiled for the target architecture and installed in vcpkg_installed, resulting in CMake sometimes discovering and attempting to use it during cross compilation scenarios, such as any build targeting a mobile platform triplet.
If protoc is used during a build then only the version compiled for the host architecture will be used. The presence of cross-compiled versions of protoc in vcpkg_installed is undesirable and at best will have no effect at all and at worst will cause build failures.
Proposed solution
The protobuf port should not install protoc. protoc should be its own port which projects can specify as a host dependency if they need to use it.
The protobuf port itself could have a host dependency for protoc to ensure existing projects which only depend on protobuf continue to work.
Describe alternatives you've considered
No response
Additional context
No response

The proposed solution doesnt work due to protobuf-config.cmake.

The proposed solution came from the knowledge that at least one Linux distribution has separate packages for libprotobuf and protoc, but perhaps they either patch protobuf-config.cmake or just don't support that and reply on FindProtobuf instead.
Now that I checked apparently upstream protobuf project just doesn't support cross compiling when using find_package(Protobuf CONFIG):
https://github.com/protocolbuffers/protobuf/issues/14576
https://github.com/protocolbuffers/protobuf/issues/14492

The easiest solution would be to put protoc into a different cmake export group and export it separately as protoc-config.cmake. protobuf-config.cmake could then do a find_dependency call with the PATHS argument in the case of crosscompilation.


fix: correcting typo Invalid in code

Description

Correcting all the "Invalide" words to the correct one "Invalid"
Closes #20
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@borisrizov-zf, build task is taking too much time, could please check what is the issue?

It seems that Fraunhofer was down for a while. We'll have to check that again, before merging.

@koptan could you please fix the merge configs ;-)

I think if you rebase, it'll all be fixed.

I will close this PR in favor of #44 .


Can't Install via Yarn

When I do yarn install i'm getting the following errors -
yarn install v1.17.3
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/react-router/-/react-router-4.4.0.tgz: Request
failed "404 Not Found"".
Please let me know if there's something i'm missing.
Thanks

I have the same problem

I found a solution if you have the same probleme as me your package.json file is not up to date. you just have to open it and find this line  "react-router-dom": "^5.1.2",  if its 4.x.x juste have to change this line and it should work.

I found a solution if you have the same probleme as me your package.json file is not up to date. you just have to open it and find this line ;
"react-router-dom": "^5.1.2",
if its 4.x.x juste have to change this line and it should work.

That's right. Thank you! Maybe the version of the package should be UPDATED.


Mostly remove sympy and deprecate sympy Instruction parameters

Summary
This commit removes all the sympy usage from qiskit-terra. Sympy is very
slow, not just to perform computations, but also to just import (being
the second slowest import in terra, only behind qiskit.version which
calls git and pip in a subprocess) and doesn't actually provide us any
real advantages inside terra. None of the expressions or calculations
terra is doing need to be done symbolically, and using sympy as just an
output formatter (to get pretty output for things like pi) is overkill.
Details and comments
After this PR the only place that retains any direct sympy usage are the
qiskit.circuit.Parameter and qiskit.circuit.ParameterExpression
classes. They rely on sympy internally to work. However, the import of
any sympy code is moved to be at run time instead of at qiskit import.
This means unless you're actually using the Parameter or
ParameterExpression classes in your application sympy will never get
imported. A follow up to this patch will be to remove sympy from these
classes and removing sympy  from the dependency lists.

I'm expecting we'll want to more extensively test the qasm parser since I don't think the unit test coverage for the qasm module is very thorough.

only behind qiskit.version which calls git and pip in a subprocess

maybe this should be removed as well. i have noticed import qiskit to be annoyingly slow. thanks for adding the benchmark.

I just ran the openqasm conformance tests with this applied locally and they caught one small issue which I fixed here: https://github.com/Qiskit/qiskit-terra/pull/3156/commits/70f864095055837a7411ea8af743084662ca33ae

only behind qiskit.version which calls git and pip in a subprocess

maybe this should be removed as well. i have noticed import qiskit to be annoyingly slow. thanks for adding the benchmark.

Can you open an issue about this? I think the functionality we gain by the subprocessing is very useful. But I think I might have some ways to speed up the version checking without removing the functionality. Both @kdk and I have been looking at the import performance recently so having an issue for the slowest aspect would be good.

Flamegraphs of import profiles before and after making  sympy import lazy for Parameters.
Before:

After:

Logs of python -c import\ qiskit && python -X importtime -c import\ qiskit 2> qiskit.log.
Before:
qiskit_withsympy.log
After:
qiskit_nosympy.log

The benchmark results are quite nice: https://travis-ci.com/Qiskit/qiskit-terra/jobs/239545823#L1183

only behind qiskit.version which calls git and pip in a subprocess

maybe this should be removed as well. i have noticed import qiskit to be annoyingly slow. thanks for adding the benchmark.

Can you open an issue about this? I think the functionality we gain by the subprocessing is very useful. But I think I might have some ways to speed up the version checking without removing the functionality. Both @kdk and I have been looking at the import performance recently so having an issue for the slowest aspect would be good.

https://github.com/Qiskit/qiskit-terra/pull/3158 is the PR I had in mind. Between this PR and that one we should improve the import time of qiskit significantly.

I'm pushing this back to 0.11 as much as I wanted to start the deprecation window for 0.10, it's too big a change to land last minute for 0.10.


Getting Started page: Update add-on info to reflect recent button changes

Description
With the new style guide changes implemented, we need to update the add-on info on the Getting Started page under "Storage Options" to reflect button changes.
Screenshots and Changes
Dropbox

Change "submit" to "click Apply."
Change "authorize" to "Import Access Token".
Eventually, the "Ok" button language will need to change.
Github

Change "submitting" to "clicking Apply".
Change "blue" to "green Save".
Eventually, the "Ok" button language will need to change.
Amazon S3

Change "Submit" to "Save" in both instances.
Eventually, the "Ok" button language will need to change.
Figshare

Change submit to "save."
Change "authorize" to "Import Access Token."
Eventually, the "Ok" button language will need to change.
Dataverse

Change "Submit" to "Save" in both instances.
Change "authenticate with Dataverse by selecting" to "import your access token and select"
Box

Change submit to "click Apply."
Change "authorize" to "Import Access Token."
Eventually, the "Ok" button language will need to change.
Google Drive

Change "submit" to "apply."
Mendeley

Change first instance of "submit" to "apply."
Change second instance of "submit" to "save."
Zotero

Change "submit" to "apply."

We might wait for this until the add-on settings change more. Which should be very soon, no?

Good point @jlcohoon -- I labeled as 'Hold' for now.

Sounds good to me! I'll try to find out when the other changes will be implemented.


Create spreadsheet with supported color formats

We need to define, which color formats are supported by our utility. It will be useful for development purposes but mainly it will be an addition to documentation:
Structured color formats (color components ARE IN ONE BLOCK i. e. rrrbbbggg):

these are easy to implement and parsing is quite universal
a definition which pixel planes are supported
a definition which pixel formats (ARGB, RGBA, BGR etc.) are supported
user will be able to define their own

Unstructured color formats (color components are spread around pixel i. e. rbbbgggrr):

are they supported at all?
if yes, which ones are supported (parsing utility won't be universal so we must declare which ones will be available)
user won't be able to define their own unstructured color format

YUV color formats:

for now only packed (so we must implement at least UYVY and YUY2)
we need to remember that they are packed differently than RGB-like
user should be able to define their own (bits per component, endiannes etc.)

It needs to be consulted with company members, which formats should we focus on.

Unstructured color formats (color components are spread around pixel i. e. rbbbgggrr):

are they supported at all?
if yes, which ones are supported (parsing utility won't be universal so we must declare which ones will be available)
user won't be able to define their own unstructured color format

Could you give an example where did you find references to such formats?
As for priorities, I would say:

RGB24
RGB32
YUV 4:2:2
YUV 4:2:0
BAYER (RGGB, RGBG, GRGB etc - is that what you meant by "unstructured"? These formats are actually quite common when dealing with raw data from sensors, they also have various sizes)
Planar YUVs

You of course shouldn't have to implement all of them at the very start, defining just a few formats should allow you work on the other parts of the application and then the work on the remaining formats can be parallelized.

liunxtv.org color formats definitions - you can find "unstructured" or "mixed" color format under i. e. V4L2_PIX_FMT_RGB565.

As for priorities, I would say:
* RGB24

* RGB32

* YUV 4:2:2

* YUV 4:2:0

* BAYER (RGGB, RGBG, GRGB etc - is that what you meant by "unstructured"? These formats are actually quite common when dealing with raw data from sensors, they also have various sizes)

* Planar YUVs

Thanks, we will focus on those ones.

liunxtv.org color formats definitions - you can find "unstructured" or "mixed" color format under i. e. V4L2_PIX_FMT_RGB565.

I don't see any occurrences or "unstructured" or "mixed" there? RGB565 is a regular 16 bit format.
And now that you mention it - it would be nice to have those shorter formats too!
And of course I completely forgot about gray formats on my list. We definitely need gray formats of various widths (8bit grey being the minimum - but I guess this should be fairly easy to add).

Okay, we will also include grays and Bayer formats in our spreadsheet.
About this unstructured formats, I needed to read those bytes like computer not like human. Now I see they are normal ones x)
Thanks!

@tgorochowik We've prepared final spreadsheet of formats we would like to be included in our utility. Would you like to add and/or remove something?
Also it would be great if you could provide us with some kind of real output from camera in formats listed below - the more diverse formats, the better. We have some testing resources, but they are all generated/converted, so that would be nice to test it with some dumps from real camera.
RGB-like

Name
VL42 Identifier
current support
future support

RGB332
V4L2_PIX_FMT_RGB332
:heavy_check_mark:
:heavy_minus_sign:

ARGB444
V4L2_PIX_FMT_ARGB444
:x:
:heavy_check_mark:

RGBA444
V4L2_PIX_FMT_RGBA444
:x:
:heavy_check_mark:

ABGR444
V4L2_PIX_FMT_ABGR444
:x:
:heavy_check_mark:

BGRA444
V4L2_PIX_FMT_BGRA444
:x:
:heavy_check_mark:

ARGB555
V4L2_PIX_FMT_ARGB555
:x:
:heavy_check_mark:

RGBA555
V4L2_PIX_FMT_RGBA555
:x:
:heavy_check_mark:

ABGR555
V4L2_PIX_FMT_ABGR555
:x:
:heavy_check_mark:

BGRA555
V4L2_PIX_FMT_BGRA555
:x:
:heavy_check_mark:

RGB565
V4L2_PIX_FMT_RGB565
:heavy_check_mark:
:heavy_minus_sign:

BGR24
V4L2_PIX_FMT_BGR24
:heavy_check_mark:
:heavy_minus_sign:

RGB24
V4L2_PIX_FMT_RGB24
:heavy_check_mark:
:heavy_minus_sign:

ABGR32
V4L2_PIX_FMT_ABGR32
:x:
:heavy_check_mark:

BGRA32
V4L2_PIX_FMT_BGRA32
:heavy_check_mark:
:heavy_minus_sign:

RGBA32
V4L2_PIX_FMT_RGBA32
:heavy_check_mark:
:heavy_minus_sign:

ARGB32
V4L2_PIX_FMT_ARGB32
:x:
:heavy_check_mark:

YUV

Name
VL42 Identifier
Pixel plane
current support
future support

UYVY
V4L2_PIX_FMT_UYVY
PACKED
:heavy_check_mark:
:heavy_minus_sign:

YUYV
V4L2_PIX_FMT_YUYV
PACKED
:heavy_check_mark:
:heavy_minus_sign:

VYUY
V4L2_PIX_FMT_VYUY
PACKED
:x:
:heavy_check_mark:

YVYU
V4L2_PIX_FMT_YVYU
PACKED
:x:
:heavy_check_mark:

NV12
V4L2_PIX_FMT_NV12
SEMI-PLANAR
:heavy_check_mark:
:heavy_minus_sign:

NV21
V4L2_PIX_FMT_NV21
SEMI-PLANAR
:heavy_check_mark:
:heavy_minus_sign:

I420
V4L2_PIX_FMT_YUV420
PLANAR
:x:
:heavy_check_mark:

YV12
V4L2_PIX_FMT_YVU420
PLANAR
:x:
:heavy_check_mark:

I422
V4L2_PIX_FMT_YUV422P
PLANAR
:x:
:heavy_check_mark:

Bayer RGB

Name
VL42 Identifier
current support
future support

RGGB
V4L2_PIX_FMT_SRGGB8
:x:
:heavy_check_mark:

RG10
V4L2_PIX_FMT_SRGGB10
:x:
:heavy_check_mark:

RG12
V4L2_PIX_FMT_SRGGB12
:x:
:heavy_check_mark:

RG16
V4L2_PIX_FMT_SRGGB16
:x:
:heavy_check_mark:

GREYSCALE

Name
VL42 Identifier
current support
future support

GREY
V4L2_PIX_FMT_GREY
:x:
:heavy_check_mark:

GREY10
V4L2_PIX_FMT_Y10
:x:
:heavy_check_mark:

GREY12
V4L2_PIX_FMT_Y12
:x:
:heavy_check_mark:

Looks good it is already quite comprehensive. If more formats are needed in the future we can add them separately (hopefully your code will make it easy to add new formats :wink: )
Please create a new issue with requests for sample images - but please don't wait for us to provide them (I cannot promise any timeline at the moment) - use the generated images for the time being.


docs: update message about this when using regular function

An arrow function cannot change the this context.
In the example before, this was always the global object (global in node, window in browser)

Thanks Andrew for the PR!
You don't this in the case above, instead you use ctx as provided as the first argument

I thought the comment was misleading with an arrow function 🤔
In any case, if that was the purpose please close the PR 😄
// `this` is `ctx` in modern build

Actually yeah, it is kind of confusing. Could you tweak the text to mean "ctx instead of this) or similar? Happy to merge that!

@PuruVJ made some changes

Thanks!


[Feature] misspelled source code happens continually.

 Issue by geunsik-lim
Thursday Jul 19, 2018 at 23:23 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/issues/144

Unfortunately, a misspelled statement in source code happens continually. So, this issue results is the non-productive review process of reviewers. :(
So, let's try to append a Spell Checker into TAOS-CI.
Step1: check spelling of *.md
Step2: check comment (# blah blah blah....) in souce code.
Step3: ....

:octocat: cibot: Thank you for posting issue #168. The person in charge will reply soon.

 Comment by git-bot-sec
Thursday Jul 19, 2018 at 23:23 GMT

:octocat: cibot: Thank you for posting issue #144. The person in charge will reply soon.

 Comment by geunsik-lim
Thursday Jul 19, 2018 at 23:28 GMT

I have surveyed appropriate open source project with apropos command as following:
~$ apropos spell
aspell (1)           - interactive spell checker
aspell-autobuildhash (8) - Autobuilding aspell hash files for some dicts
aspell-import (1)    - import old personal dictionaries into GNU Aspell
enchant (1)          - a spellchecker
enchant-lsmod (1)    - Show information about available spell-checking modules and dictionaries.
iso646.h (7posix)    - alternative spellings
ispell-autobuildhash (8) - Autobuilding the ispell hash file for some dicts
ispell-wrapper (1)   - smart wrapper for ispell
precat (1)           - prefix delta compressor for Aspell
preunzip (1)         - prefix delta compressor for Aspell
prezip (1)           - prefix delta compressor for Aspell
remove-default-ispell (8) - remove default ispell dictionary
run-with-aspell (1)  - script to help use GNU Aspell as an ispell replacement
select-default-ispell (8) - select default ispell dictionary
select-default-iwrap (1) - Selects the user default ispell dictionary for use with ispell-wrapper
update-default-aspell (8) - rebuild aspell database and emacsen stuff
update-default-ispell (8) - update default ispell dictionary
update-dictcommon-aspell (8) - rebuild aspell database and emacsen stuff
update-dictcommon-hunspell (8) - rebuild hunspell database and emacsen stuff
word-list-compress (1) - word list compressor/decompressor for GNU Aspell

 Comment by geunsik-lim
Friday Jul 20, 2018 at 00:15 GMT

I have analyzed a spell check facilities at http://aspell.net/.
GNU Aspell is a Free and Open Source spell checker designed to eventually replace Ispell. It can either be used as a library or as an independent spell checker.

Case study:

 cat ../../README.md  | aspell list -l en
GitHub
ci
doxygen
md
ci
md
TAOS
PRs
github
PRs
PRs
doxygen
modulable
opensource
Tizen
Yocto
TBD
TBI
img
img
img
img
CPUs
customizable
github
PHP
img
img
TAOS
ci
taos
ci
md
ci
taos
ci
md
plugable
Doxygen
Timestamp
Hardcoded
CPPcheck
Pylint
Tizen
Yocto
ci
md
TBD
TBI


Support INSERT statements in SQL

As an SQL user I would like to create documents using INSERT statements.
Sample
INSERT INTO MV_A(FieldA, FieldB, FieldC) VALUES (1, "two", 3.0f)

References

MySQL
PostgreSQL
Microsoft SQL Server

In OpenSearch, 'insert' (a.k.a. indexing) is done like so:
PUT sample-index/_doc/1
{
  "Description": "To be or not to be, that is the question."
}

Response looks like this
{
  "_index": "sample-index",
  "_id": "1",
  "_version": 1,
  "result": "created",
  "_shards": {
    "total": 2,
    "successful": 1,
    "failed": 0
  },
  "_seq_no": 0,
  "_primary_term": 1
}

Should any of this data be returned in SQL plugin response?

When the user sets _id for the new document --  INSERT INTO table (_id, ...) VALUES (1, ...)
and the document already exists
then SQL plugin returns an error response.


Groups do not update their modified field

group.modified appears to always equal group.created :/

The put and post methods in grouphandler.py will need to be updated to set the modified key.

Should the modified field be updated whenever a role or tag is added, or just when the name is changed?

Whenever any modification is made, so any of those scenarios would qualify.
The modified field should always represent the latest change to a document.


#6499 test case + fix

As suggested by @lcobucci, I created a PR with a minimal test example.
While working on the test example I looked into the code and found the (probable) cause for this issue and proposed a fix for it in a second commit.
The issue seems to originate from the part of the code in UnitOfWork which calculates the weight for new dependencies in the graph based on whether or not the nullable clause on join columns is set and to which value.
In particular the part (int)empty($joinColumns['nullable']) which to me seems incorrect. With the current implementation in master the case where the nullable property on the join column is set to false (so, the relation is mandatory) yields the same weight as when the nullable property is not defined. But when the nullable property is not defined, the documention states that the default would be nullable === true.
Below, you find a simple truth table breakdown of the specific part of the code (for the possible values for $joinColumns['nullable'].

(int)
empty
( $joinColumns['nullable'] )

0
false
true

1
true
false

1
true
unset/null/etc.

I tried to keep the (in-line) fix as compact as possible. All test keep running and the added test for this issue also succeeds after applying the fix. Before applying the fix, it throws a ConstraintViolationException and tries to insert null for a mandatory foreign key.
Since I'm not completely familiar with the codebase, please look into whether this does not influence other parts of the code. If there's anything I can do to assist, let me know.

I'll adjust the above suggestions, fix Scrutinizer improvements and run some more tests locally.

Just for the record: the file's history shows that the current logic
(int)empty($joinColumns['nullable'])
originates from https://github.com/doctrine/doctrine2/commit/27e9b492152090d41c47bc30dc24b5ed316b9f2b#diff-6e8c1c1e78b054ba05e20ea09d877865L1158 as a simplification of
(isset($joinColumns['nullable']) ? $joinColumns['nullable'] : false) ? 0 : 1
(actually with an intermediate variable $isNullable for the parenthesized ternary expression)
which was originally introduced in https://github.com/doctrine/doctrine2/commit/8ea62b95b8e4a8b3de000a59f018ec250b41d714#diff-6e8c1c1e78b054ba05e20ea09d877865L1165
so the present PR is like saying that the false should actually have been a true, or (in PHP 7):
($joinColumns['nullable'] ?? true) ? 0 : 1
or alternatively
(int) ! ($joinColumns['nullable'] ?? true)
(int) ! ( ! isset($joinColumns['nullable']) || $joinColumns['nullable'])
(int) (isset($joinColumns['nullable']) && ! $joinColumns['nullable'])
all being equivalent to the currently proposed fix just without the === true strict equality.
Now, as you already noted, this is unfortunately causing exceptions in an existing test, and the original logic was precisely a fix for the affected test.

@guilliamxavier Thanks for clarifying the file's history. As said, I'm not that familiar with the codebase and when digging into it I also could not find out what causes the other two tests to fail.
It might be that this proposed fix isn't correct for this issue, but then the question remains: what causes issue #6499 to arise? Or is #6499 intended behavior?

Any news on this issue?

@triasinformatica-gabe adding it to my bucket of stuff to check

@Ocramius thanks.
If there's anything we (me or my colleagues) can do to help, please let us know. But currently we're unfamiliar with the history of this part of the doctrine codebase.

@triasinformatica-gabe I manually merged after some cleanups and moving stuff around.
@lcobucci I couldn't find a proper way to test this in isolation, as it's deep in UnitOfWork internals, sadly.
This patch can only land in 2.6.0, since the commit order calculator doesn't even know about weights of dependencies before that.

@triasinformatica-gabe sorry, I had to revert the merge - this patch introduces errors when deleting foreign key referenced data.
I think this is much more complex than what it looks. To be clear, I know as much as you do about this issue. The problem area is exactly the one you worked on, except that the commit order isn't simply "reversible" for deletes (current approach).

@triasinformatica-gabe @Ocramius is tihs waiting on anything now? This fixes https://github.com/doctrine/doctrine2/issues/7006 for me

@bendavies see https://github.com/doctrine/doctrine2/pull/6533#issuecomment-321911821 - this was reverted

@Ocramius yeah thanks. I got confused as this PR was still open. was CascadeRemoveOrderTest the issue? It seems to be passing on 2.6 now, with this patch.

@bendavies no, we are lacking tests about cascade-deleted data, from what I remember (sorry, mind is also a bit clouded over here)

@bendavies It's passing the tests, but only in SQLite, which is ignoring the foreign keys. If you run the test set in MySQL or another database that does enforce this, some other tests will fail. There seems to be a non-trivial issue in building up the relationship dependency graph for cascades. I didn't have time so for to look into it, but it's still somewhere on my list.
The fix this PR originates from was a bit to rigid and therefore not solving the issue.

I ran against mysql and postres. They passed!
On Mon, 5 Feb 2018, 18:51 Gabe van der Weijde<EMAIL_ADDRESS>wrote:

@bendavies https://github.com/bendavies It's passing the tests, but
only in SQLite, which is ignoring the foreign keys. If you run the test set
in MySQL or another database that does enforce this, some other tests will
fail. There seems to be a non-trivial issue in building up the relationship
dependency graph for cascades. I didn't have time so for to look into it,
but it's still somewhere on my list.
The fix this PR originates from was a bit to rigid and therefore not
solving the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/pull/6533#issuecomment-363183492,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmK8NGk2Bqc3AsLb455sPz8DVX3tO03ks5tR03NgaJpZM4OJHmg
.

Then maybe some other fix has fixed this issue; I’ll look into it tomorrow morning if I have time and post back my findings.
From: Ben Davies<EMAIL_ADDRESS>Sent: Monday, 5 February 2018 19:54
To: doctrine/doctrine2<EMAIL_ADDRESS>Cc: Gabe van der Weijde<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [doctrine/doctrine2] #6499 commit order must consider non-nullability of join columns as prioritised over nullable join columns (#6533)
I ran against mysql and postres. They passed!
On Mon, 5 Feb 2018, 18:51 Gabe van der Weijde, <notifications<EMAIL_ADDRESS>wrote:

@bendavies https://github.com/bendavies It's passing the tests, but
only in SQLite, which is ignoring the foreign keys. If you run the test set
in MySQL or another database that does enforce this, some other tests will
fail. There seems to be a non-trivial issue in building up the relationship
dependency graph for cascades. I didn't have time so for to look into it,
but it's still somewhere on my list.
The fix this PR originates from was a bit to rigid and therefore not
solving the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/pull/6533#issuecomment-363183492,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmK8NGk2Bqc3AsLb455sPz8DVX3tO03ks5tR03NgaJpZM4OJHmg
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/doctrine/doctrine2/pull/6533#issuecomment-363184259, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AI5GhYxYrPNihoOQaNHwcskHrzEfHrM8ks5tR05VgaJpZM4OJHmg.

any luck @triasinformatica-gabe?

hey @triasinformatica-gabe. Any chance to look at this yet?

@bendavies Sorry for the late response, haven't had time to feedback on this before since I was abroad for a while. Any way; I did run all the tests on top of the latest changes and for me all the same tests keep failing the same way as they did last summer, so I'm not sure how you managed to get it working running Postgress and MySQL.
Could you elaborate?

Hmm, I'll try again.

@triasinformatica-gabe which test is failing for you please?

@Ocramius can you give more context about that?

The problem is:

(sorry, mind is also a bit clouded over here)

I also don't remember the details.

I also don't remember the details.

@Ocramius I BELIEVE IN YOU, you can do it!!!! Didn't help, did it? HAHAHA alright, thanks!


Python iraabott

python 2  / python 3sets allusers and prependPath options set
wireshark and teamviewer defaults seem to work well

Hi @iraabbott, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

We will be closing this PR for now.
Please complete one pending work item and re open the PR.
We will commit it after.


direct cast in SQL query

Hello, I had a problem with typing "where part" query and I noticed that there is no way to cast some part of SQL query. DB - postgresql
Example:  - user anniversary >
.where(USER.validFrom.year().subtract(LocalDate.now().getYear()).mod(5).eq(0))
it will generate
MOD( EXTRACT( year from timestamp '1.1.2011' ) - 2016, 5) = 0
but function EXTRACT return DOUBLE (every time) which I cant cast to Integer (in SQL) and it throw SQL syntax error (function mod(double, int) doesnt exists)
right it would be something like that >
.where(USER.validFrom.year().sqlCast(Integer.class).subtract(LocalDate.now()).mod(5).eq(0))
which could generate
MOD( EXTRACT( year from timestamp '1.1.2011' )::int - 2016, 5) = 0     OR
MOD( CAST( EXTRACT( year from timestamp '1.1.2011' ) AS integer) - 2016, 5) = 0

this would be great :)

There is a method .castToNum, but that does a short path if the type is already the desired type.
Could you try .castToNum(Long.class).castToNum(Integer.class)?
@timowest why was the short path introduced?

Doesn'twork, tried both and also .intValue() nothing work.
.where(USER.validFrom.year().castToNum(Integer.class).subtract(LocalDate.now()).mod(5).eq(0))
.where(USER.validFrom.year().castToNum(Long.class).subtract(LocalDate.now()).mod(5).eq(0))
.where(USER.validFrom.year().intValue().subtract(LocalDate.now()).mod(5).eq(0))

also after subtract doesn't work

What do you mean both?
I want you to try to go to Long and back to Integer.
But I'll see if I can fix the issue.

Could you maybe post the java code that creates the query?
Your query doesn't compile for me, and subtracting a date and a number seems strange.
As for the workaround, for me it works.

I didnt try .castToNum(Long.class).castToNum(Integer.class) at the same time.. I will try it tomorrow at work, and I will also send you code. Thank you very much :+1:

That is fine.
And no problem!

Trank you, your "workaround" is working.
LocalDate onDate = LocalDate().now();
Integer anniversaryYears = 5;

JPAQuery<UserDO> q = new JPAQuery<>(em);
q.select(Q_USER).from(Q_USER)
  .where(Q_USER.validFrom.year().subtract(onDate.getYear()).ne(0))
  .where(Q_USER.validFrom.month().subtract(onDate.getMonthOfYear()).eq(0))
  .where(Q_USER.validFrom.dayOfMonth().subtract(onDate.getDayOfMonth()).eq(0))
  .where(Q_USER.validTo.goe(onDate))
  .where(
      Q_USER.validFrom.year().castToNum(Long.class).castToNum(Integer.class)
      .subtract(onDate.getYear()).mod(anniversaryYears).eq(0)
   );
List peopleWithAnniversary = q.fetch();

(sorry I miss .getMonthOfYear() from LocalDate.now() at substraction)

Then at least that is sorted.
I can reproduce it, so I'll fix the underlying issue.


Update premium-features.md

source IP address typo

@tobystic : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks @tobystic.


Duplicate script tags inserted

Describe the bug
I'm noticing duplicate script tags in my SvelteKit app. This happens with Svelte pinned to 3.37.0, so is unrelated to https://github.com/sveltejs/svelte/issues/6274
		<link rel="modulepreload" href="/./_app/pages/$layout.svelte-a6ce5e1a.js">
...
	<link rel="modulepreload" as="script" crossorigin="" href="/_app/pages/$layout.svelte-a6ce5e1a.js">

To Reproduce

npm init svelte@next and choose all the defaults
add an adapter (I've reproduced with adapter-node and adapter-static)
npm run build
run the app (node build/ for adapter-node)

Inspect head element with Chrome inspector

Diagnostics

The output of npx envinfo --system --npmPackages svelte,@sveltejs/kit,vite --binaries --browsers

  System:
    OS: Linux 5.8 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
    Memory: 11.30 GB / 31.14 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.0/bin/yarn
    npm: 7.11.1 - ~/.nvm/versions/node/v14.16.0/bin/npm
  Browsers:
    Chrome: 90.0.4430.93
    Firefox: 88.0
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.94
    svelte: 3.37.0 => 3.37.0
    vite: ^2.1.0 => 2.2.3

Your browser: Chrome

Your adapter (e.g. Node, static, Vercel, Begin, etc...): Node

Severity
Well I didn't notice it for awhile, so I guess it's not the worst, but it seems like there'd be some performance impact at the very least

I've done some digging and it seems to originate in vite see here
I'm not sure if this is something that can be changed by sk but i would assume that it would need to be changed in vite

I would guess this is related to hydration. I don't see it if I view source, but only when inspecting the document with Chrome inspector. @hbirler maybe this would be an interesting test case for you if you're still interested in working on hydration?

I am not sure this is directly about hydration, since I do not see a hydration function being called with the HEAD node. And in my browser (firefox) the duplicates look like this:
<link rel="modulepreload" href="/./_app/pages/__layout.svelte-fd0963f2.js">
...
<link rel="preload" as="script" crossorigin="" href="/_app/pages/__layout.svelte-fd0963f2.js">

So module preload also becomes preload. I don't know why that would happen.

I see the following in build/app/start-4aff77ac.js, so I guess @Yahatix was right:
const __vitePreload = function preload(baseModule, deps) {
  if (!deps || deps.length === 0) {
    return baseModule();
  }
  if (scriptRel === void 0) {
    const relList = document.createElement("link").relList;
    scriptRel = relList && relList.supports && relList.supports("modulepreload") ? "modulepreload" : "preload";
  }
  return Promise.all(deps.map((dep) => {
    dep = `${base}${dep}`;
    if (dep in seen)
      return;
    seen[dep] = true;
    const isCss = dep.endsWith(".css");
    const cssSelector = isCss ? '[rel="stylesheet"]' : "";
    if (document.querySelector(`link[href="${dep}"]${cssSelector}`)) {
      return;
    }
    const link = document.createElement("link");
    link.rel = isCss ? "stylesheet" : scriptRel;
    if (!isCss) {
      link.as = "script";
      link.crossOrigin = "";
    }
    link.href = dep;
    document.head.appendChild(link);
    if (isCss) {
      return new Promise((res, rej) => {
        link.addEventListener("load", res);
        link.addEventListener("error", rej);
      });
    }
  })).then(() => baseModule());
};

I filed an issue in the Vite tracker for this here: https://github.com/vitejs/vite/issues/4444


token-cli: Run fewer tests at once

Problem
The token-cli tests are still flaky.
Solution
Run fewer of them at once.  This approach takes longer, but let's hope it's kinder to CI machines.

Gonna merge this, we can figure out the token CI failure separately

Gonna merge this, we can figure out the token CI failure separately

Ya, sorry for the delay on that one; had to step out for a bit.


Feature Request: add viewing key

When using the iOS wallet in combination with offline paper wallets, it would be convenient if the viewing key could be added to the app, similar to how this can be done in Treasure Chest > Import Viewing Key.

Thanks for this feature request.
Added it to the list of future todo list.


see negative number in the Duration

Describe the bug
in the "Duration" I see negative values (i.e -34735s), also the DCU is negative
Environemnt
spark version 3.2.0
scala 2.12.14
dataflint jar version 0.1.1
CLOUDERA on prem environment
Screenshots
If applicable, add screenshots to help explain your problem.

Hi @aviadr! thanks for reporting the issue!
Duration metric is coming for the difference in start/end dates (if spark is running end date is the current time in your machine)
The data is taken from the first application that is returned from {spark_url}/api/v1/applications API.
It means that in your environment (cloudera onprem, which I haven't tested DataFlint on yet) for some reason the values are skewed.

I suspect that's the root cause for your issues and other calculations such as the DCU and Activity Rate is also skewed because the start/end date are wrong.
Can you please share with me the console output and network requests that DataFlint make, specifically the api/v1/applications one (feel free to blur anything that seems sensitive)

I will also be happy to setup a short zoom call and try to debug the issue together

Hi,
I installed it on spark (add the jar in the spark-submit command)
the application is still up (it is Jupyter notebook running on yarn cluster )
[ {
"id" : "application_1695491546005_444571",
"name" : "e56d8618-6148-45c6-8596-8edeb7029857",
"attempts" : [ {
"startTime" : "2024-01-21T12:21:26.358GMT",
"endTime" : "1969-12-31T23:59:59.999GMT",
"lastUpdated" : "2024-01-21T12:21:26.358GMT",
"duration" : 0,
"sparkUser" : "my user",
"completed" : false,
"appSparkVersion" : "<IP_ADDRESS>.2.7170.0-49",
"startTimeEpoch" :<PHONE_NUMBER>358,
"endTimeEpoch" : -1,
"lastUpdatedEpoch" :<PHONE_NUMBER>358
} ]
} ]

So the start time seems fine (beside that the ISO format ends with "GMT" and not "T", but in version 0.1.1 DataFlint uses startTimeEpoch which is fine)

Is there a chance that the clock in the machine you are running chrome in is off by ~8-9 hours?
Because DataFlint calculate the duration by taking Date.now() which is the UTC time of your machine and subtract from startTimeEpoch.

Anyway if it's not the clock, I will be happy to have an online session to try to debug the problem with you
You can contact me at the DataFlint slack community at https://join.slack.com/t/dataflint/shared_invite/zt-28sr3r3pf-Td_mLx~0Ss6D1t0EJb8CNA

Hi,
you are right, it is a clock issue.
the endpoint was falling behind the yarn workers
now it works fine.
thanks for your quick response

Awesome :) I will be happy to help with any other question you have, and once you use it a bit I will be really happy to hear what you think about DataFlint :)
As mentioned, you can contact me at the DataFlint slack community, join link: https://join.slack.com/t/dataflint/shared_invite/zt-28sr3r3pf-Td_mLx~0Ss6D1t0EJb8CNA
[Also, I would I suggest for you NOT upgrading to version 0.1.2. I changed a logic relates to calculating the duration and for some reason in Cloudera the time strings ends with GMT and not Z like in any other spark platform, and javascript does not parse natively strings with GMT.
I already fixed it in the main branch and the fix will be available from the next version]


Add ManagedIdentityClient options class to Azure.Identity

ManagedIdentityClient should have it's own ClientOptions type now that it is a separate client from AadIdentityClient.  ManagedIdentityClientOptions could possibly expose:

ImdsAvailableTimeoutMs
ImdsEndpoint
ImdsApiVersion
AppServiceMsiApiVersion

Also the ClientOptions classes should be configured use ResponseClassifier to handle retry behavior and failure conditions by default.

Not needed right now.


Update white list with CI

Added URL again, seems like quora is more of a problem than I thought

@sdmg15 This should solve the current build - failing

Yeah thanks it solve, definitely quora is really causing a problem.


Update favicon

Done in https://github.com/macterra/artx-market/commit/7d5c1835bf5c677764f8dd8e3c1bd93a5470ba47


Rust Book Chapter 3: Common Programming Conecpts

Working through Chapter 3 in Rust Book
Tuesday: 2 Hours
Wednesday: 5 Hours

Finished 3.1: Variables and Mutability
Finsihed 3.2: Data Types

Finish 3.3: Functions

Finished chapter, and create Fibonacci nth number calculator


Add supervisor button

If both start buttons are held for 5 seconds, the running game is terminated.

Also cleans up some NFC/thread watcher stuff


:recycle: backend cleanup local sso conf

Description
Cleanup backend local sso configuration.
Use keycloak hostname localhost instead of keycloak so that users do not have to customize the hosts file.

Summary by CodeRabbit

New Features

Introduced a new Single Sign-On (SSO) configuration for enhanced security and modularity.

Bug Fixes

Updated security properties to improve integration with identity providers.

Chores

Removed outdated Keycloak configuration to streamline settings.

@simonhir I tought the problem was already fixed with https://github.com/it-at-m/refarch-templates/pull/536?

@simonhir I tought the problem was already fixed with #536?

actually no, you can test it, if you try to access the backend from the frontend you will get an unkown host error. So it has to be either http://localhost:8100 or http://kubernetes.docker.internal, both work.

Ah I see, so its not a Gateway <-> Backend thing, but a Backend <-> SSO thing, sorry I somehow misunderstood that.
Yeah then I think localhost is the way to go, because the keycloak server is exposed locally via 8100 right? Or are there any advantages if we use kubernetes.docker.internal?

@simonhir I tought the problem was already fixed with #536?

actually no, you can test it, if you try to access the backend from the frontend you will get an unkown host error. So it has to be either http://localhost:8100 or http://kubernetes.docker.internal, both work.

Ah I see, so its not a Gateway <-> Backend thing, but a Backend <-> SSO thing, sorry I somehow misunderstood that.
Yeah then I think localhost is the way to go, because the keycloak server is exposed locally via 8100 right? Or are there any advantages if we use kubernetes.docker.internal?

dont really see any advantages or disadvantages of using localhost or kubernetes.docker.internal. For now, i would also go with localhost


Add DoorBumpOpener to space dragon

About the PR

Makes it so the space dragon can open doors by touching them.
Why / Balance

Carps can open doors, why can the dragon not? This is pure QOL.
Technical details

1 line YAML change.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Simyon

tweak: The space dragon can now open doors by bumping into them!

that doesn't make sense, no monster should be able to open doors without access, instead they should be able to destroy them to get through

Pets such as the chaplains familiar can bump doors. Carps can too and this makes lasers less annoying to play against. A dragon doesn't have the time for a 20-ish secons doafter to open an airlock in a public hallway.  Shot by 5 people with lasers.


filewatchers on vscode.workspace convert windows drive letters to lowercase

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.77.1
OS Version: Microsoft Windows 11 Pro, 10.0.22621

Steps to Reproduce:

use vscode.workspace.createFileSystemWatcher() to create a filewatcher
Trigger the filewatcher with a path inside of a drive that uses a uppercase letter (C:/)

I would expect the path to maintain the drive uppercase, but the event comes in with (c:/)

This is a consequence of our Uri implementation that normalizes all file paths to lowercase drive letters. You should not depend on the casing of the drive letter but consider both the same. For display purposes however it should appear as uppercase to the user.


remove wcs schemas

See spacetelescope/asdf#554

@nden I'm wondering if instead of removing these wholesale, maybe the right approach is simply to omit them from the v1.3.0 version map but leave them in place.

Agreed, I made another PR but got side tracked with another issue.

@nden I'm closing this in favor of #182.


Fixed a typo.

Thank you.

Coverage remained the same at 98.549% when pulling 8ec480b3237e67f86817a0f8027354de32eaf134 on mcmimik:patch-1 into 6edbdb2181a6a58d9cc9437ce679bd60891fbe3e on javascript-obfuscator:master.

Coverage remained the same at 98.549% when pulling 8ec480b3237e67f86817a0f8027354de32eaf134 on mcmimik:patch-1 into 6edbdb2181a6a58d9cc9437ce679bd60891fbe3e on javascript-obfuscator:master.


Improved download debug info

@dgrimreaper , I am closing this pull request as I have prepared an updated one


upd(virtualbox-deb): 0.7.12 -> 0.7.14

add comment for latest_version
passed to incompatible (debian:*) : debian packages/repos exists (fasttrack)

Why is this only succeeding on 2 distros?

Why is this only succeeding on 2 distros?

It's the latest version upstream in the other ones; this is a backport

Why is this only succeeding on 2 distros?

package splited for all distros now with new deps names etc...
will work on a -repo package. will be better and could set several distros.
this -deb is ok for what it is made for.

Ok well make the appropriate incompatible changes.

Ok well make the appropriate incompatible changes.

I have already added incompatible=(debian:*)
Not sure for ubuntu...

Ok well make the appropriate incompatible changes.

I have already added incompatible=(debian:*)
Not sure for ubuntu...

incompatible=("debian:*" "ubuntu:mantic" "ubuntu:noble" "ubuntu:devel")


add a free-form comment field per-annotation

The user will be able to optionally write a comment when creating or verifying an annotation, and view comments along with the annotations for a ROI. For verification, if the user doesn't enter a new comment, the previous comment (if any) should be retained.

@joefutrelle Are the comments going to be a one to one relationship with the annotation? Or could there be more than one comment on each annotation (one for the original annotation, one for the verification, maybe more?)
Going to assign this to @MattCharron32 to take a look at the UI

one-to-one.


Magic links break when Outlook safe links are enabled

Magic links don't work from Outlook when safe links are enabled.
The logs show that the verifyHandler is called multiple times when the link is clicked (as part of the safety check) - the first time the ticket is removed from the user record and redirect is called correctly, but this is cancelled out by the subsequent calls to verifyHandler where the ticket no longer exists and an error response is sent.
The code where this happens is here:
https://github.com/nhost/hasura-auth/blob/9f5cbbcd14d3ed1ab2c7fb3b19fccaa3379861d6/src/routes/verify/verify.ts#L33-L62

I've googled a bit and seems to be a common issue.

https://github.com/FusionAuth/fusionauth-issues/issues/629#issuecomment-832778247
https://github.com/authelia/authelia/issues/2994
https://github.com/nextauthjs/next-auth/issues/1840
https://github.com/nextauthjs/next-auth/pull/3900/files

In summary, I think there are two solutions:

Always return 200 for HEAD /verify: router.head('/verify', (_, res) => res.sendStatus(200));
Don't delete tickets after they've been used, but instead allow the ticket to be reusable until it expires.

@elitan Did that actually fix the problem? I’m in a similar situation now, and from what I gather reading a lot of issues and tickets all around, it shouldn't have worked?

I think it was fixed yes.
Did you experience something else?

I haven’t really tried it out yet, but I was asking due to comments such as the ones on this StackOverflow issue, where disabling HEAD requests was said to not work. However, returning a smile and a thumbs up like your fix here might work [differently].

Unfortunately, this solution no longer works. In my testing, Outlook makes actual GET requests during its link scanning, not just HEAD requests.

I've got the same problem with magic links. Links are invalid before the user got the chance to click it.

We wrote about this issue recently:
https://nhost.io/blog/protect-magic-links-from-email-clients
https://github.com/nhost/nhost/pull/2590


Improve robustness of IsoparametricTransformation::TransformBack() [inv-xform-dev]

This PR improves the robustness of IsoparametricTransformation::TransformBack() in several ways:

Instead of baking in the element center as the starting guess for the Newton-Raphson solve, it chooses the closest point from a set of IntegrationPoints of an element
It removes a buggy optimization in the Newton-Raphson solve which projects IntegrationPoint that leave the element onto the element's boundary.  This caused TransformBack() to report failures on highly curved elements.
Finally, it adds an overload to Geometry::CheckPoint() to allow an epsilon tolerance for IntegrationPoints that are very close to the boundary.

TODO:

[x] Update CHANGELOG

Resolves #322

Here are the paths that the solver takes for a C-shaped quadratic quadrilateral, uniformly sampled on a 25x25 grid in isoparametric space using the code from this PR:

After transforming the integration point to physical space, I called TransformBack() and am plotting the steps that the solver followed.
The initial guess for the solver is the closest transformed point from the refined integration rules for this geometry and polynomial order (i.e. RefinedIntRules.Get(geom, order)) to the query point.
Note that the original code failed to find a number of internal IntegrationPoints on this element.  Here is an example of the failures in the original code, sampled on a 25x25 grid:

Red cells indicate success, and blue cells indicate failure.  Essentially, because of the projection back into the cell, the solver can only find points that are in the line of sight of the element's center (w.r.t. the Jacobian).
If we start at the center of the element, but remove the projection (bullet 2 in the PR summary), the solver still misses a number of points (i.e. the centers of the blue rectangles in the following figure):

Here are the paths for the failed cases on this example:

Finally, if we continue to use the projection, but start with a better initial guess, we still get failures (although, there is a significant reduction):

(Note the blue cells near the inner boundary).

Thanks for the useful and well-documented contribution @kennyweiss!
Approved modulus adding a CHANGELOG entry (see TODO items in the PR description).

@tzanio -- I had to change some of the commit messages because I accidentally wrote InverseTransformation as the class name instead of IsoparametricTransformation.  This changed the history of the commits, so please delete your local branch and check it out again if you want to modify this branch.

Kenny, Tzanio,
I did some reorganization of the code related to inverting ElementTransformations to make it more flexible and extendable. Let me know what you think.

@v-dobrev thanks for all the changes -- this capability is much more robust now and probably good enough for most practical applications.
@kennyweiss, with Veselin's changes, in particular ClosestRefNode and NewtonElementProject in InverseElementTransformation, one can even invert the mapping for >90% of the points in the following (single!) element:

This element is 20th order (mesh is in your inv-xform-dev PR into mystash/mfem/tests) and its Jacobian is invertible and well-behaved.

I added a simple illustration of FindPoints in Mesh Explorer, see https://github.com/mfem/mfem/pull/313/commits/ded9cc162e271b53e4c1ca0f93faeade0679f595.
With that and Veselin's tests, everything looks good to me -- Approve the PR again :)

@v-dobrev thank for your the comprehensive update to my PR with lots of initialization and algorithmic options.
I was able to adapt my algorithm to the new code, but only if I explicitly set the initial integration point using my old technique. I.e.
    /// my user code (outside of mfem) for setting up the inverse transformation

    using InvTransform = mfem::InverseElementTransformation;
    InvTransform invTrans(&tr);
    invTrans.SetSolverType( InvTransform::Newton );

    // Find the initial integration point
    const int geom = tr.GetGeometryType();
    const mfem::IntegrationRule* ir = &(mfem::RefinedIntRules.Get(geom, refOrder));
    const int idx = invTrans.FindClosestPhysPoint(ptSpace, *ir);
    invTrans.SetInitialGuess( ir->IntPoint(idx) );

    // Status codes: {0 -> Inside 1 -> Outside (probably); 2-> Unknown / did not converge }
    int err = invTrans.Transform(ptSpace, ipRef);

Using the defaults for InitGuessType::ClosestPhysNode caused  (some of) my tests to fail, as did the InverseElementTransformation class default (using the element center and projecting to the element boundary).
My initial_guess function is different in two ways than your proposed update:

it was using the Gauss-Lobatto RefinedIntRules, rather than the regular gridGlobGeometryRefiner
it allowed the user to set the refinement order / grid size, rather than automatically choosing the element's order.

For the former, the GeometryRefiner is probably a better choice, but the RefinedIntRules has the advantage of always starting from the interior of the element. Is there a way to only use the interior IntegrationPoints of the GeometryRefiner grid?  (Or the points on its dual grid?).
The latter was helpful as an optimization -- profiling the code showed me that the initial guess  function was taking a significant percentage of the runtime for quadratic elements (especially in 3D) and could be safely dialed down (at least for linear and quadratic cells).
It seems easy enough to allow the user to set the refinement order for the grid through an extra parameter (e.g. SetInitGuessRefinement(int)), with a default to the order of the element.
Does it make sense to add extra options to InverseElementTransformation ?

Update: My tests also passed if I simply set the initial guess to ClosestRefNode and use the built-in defaults, e.g.:
    using InvTransform = mfem::InverseElementTransformation;
    InvTransform invTrans(&tr);
    invTrans.SetSolverType( InvTransform::Newton );
    invTrans.SetInitialGuessType(InvTransform::ClosestRefNode);
    int err = invTrans.Transform(ptSpace, ipRef);

but, it is about a factor of three slower -- I am getting a query rate of about 240 K queries/sec using the code from the previous comment (RefinedIntRule) vs. 73 K queries/sec with the default option (ClosestRefNode).
Here is the output from my program, testing a 32 K element quadratic hex mesh (approximately) covering the unit sphere with jittered dofs.  I am testing around 100K random points within the mesh's bounding box, and about 25% of the points required inverse transforms after simple bounding box checks:

Querying 100007 pts on curved_3d_refined_5_jittered quadratic hex mesh...
[RefinedIntRule]  took 0.412799 s -- rate: 242,266 q/s (includes 26104 inverse xforms)
[ClosestRefNode] took 1.37013 s  -- rate:  72,991 q/s (includes 26104 inverse xforms)

Both codes were built in release mode, and the only difference is in the initial guess.
I have not looked into the breakdown in the extra time between the time it takes to choose the initial guess and the extra time due to additional Newton-Raphson iterations.

Kenny,
Can you try your test without setting invTrans.SetSolverType( InvTransform::Newton );, i.e. use NewtonElementProject?
In your last tests, what refOrder do you use with RefinedIntRules?
Since the mesh is quadratic, ClosestRefNode checks the points of a 3x3x3 uniform grid that includes the vertices. If you use refOrder == 1, the RefinedIntRules gives you back a set of 2x2x2 points which have coordinates (i,j) where i,j are in the set {1/4,3/4}. This difference may explain, to some extent, the performance ratio 240/73 ~ 27/8. There is also the extra cost of ClosestRefNode - it has to invert the Jacobian matrix at every point that it checks and that is in addition to the forward transformation of each point from the reference-space.
The RefinedIntRules are something very different from what you probably expect: those are quadrature rules that can be used to integrate basis functions that are not polynomials on the reference elements but piecewise polynomials on a 2x2 (for quads) subdivision of the element. So essentially you have two sets of points in every space direction - one Gauss-Legendre quadrature rule for the interval [0,0.5] and another for the interval [0.5,1]. The number of points in each sub-interval, say N, is related to the refOrder by refOrder=2*N-1 with even refOrders actually using refOrder+1 to define N. For example, for refOrder=2 and refOrder=3 you will get 2*2=4 points in each space direction.
We can definitely add other initial guess types, e.g. based on GaussLegendre or OpenHalfUniform quadrature points. One thing to keep in mind, is that for triangles and tets, the actual IntRules are not a nicely distributed sets of points, so using a more uniformly distributed set similar to the one produced by GeometryRefiner is probably more appropriate. We can easily extend the GeometryRefiner class to use other sets of 1D points, e.g. GaussLegendre or OpenHalfUniform.
One more thing: if you are using the method Mesh::GetBoundingBox() - there is no guarantee that it returns accurate bounding box, since it simply checks the physical coordinates on a uniform reference-space subdivision of the elements.

Thanks @v-dobrev.
As we discussed offline, it would be great if the new class had options to select the quadrature points for the GeometryRefiner (with OpenHalfUniform as one of the options) and to also be able to set the refinement level for the GeometryRefiner.
To answer the other questions, I am projecting to the corresponding Bernstein basis to compute the bounding boxes, so (assuming the projection is stable), the bounding boxes are guaranteed to contain the elements.
Also, the OpenHalfUniform integration rule is the one that I was looking for.  (I was using the  RefinedIntRules because that was the only one I could find that gave points on the interior of the elements.  It very clearly did not give me the results I was looking for with refinement orders higher than 1).

Is there a possibility that this works for "FindPointsOnSurface"? We currently shift our values about an epsilon to find points inside the elements we need displacement values.

Points on the boundary of an element should work fine, I think. If there are some "epsilon" issues, you can adjust tolerances e.g. with SetPhysicalRelTol() in the InverseElementTransformation.


[VS Code] Starting collaboration session: Only the 'http' scheme is allowed for proxies.

Error:
Starting collaboration session: Only the 'http' scheme is allowed for proxies.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.1403

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.30.2

platformName
Linux

platformVersion
4.15.0-29deepin-generic

Closing this as a duplicate of #884.


Investigate: OpenSSF Best Practices Badges - HTTPS implementation

In order to fully validate the silver level of OpenSSF Best Practices Badges for our project and for security reasons, we have to fully implement HTTPS instead of HTTP.
Here are the requirement to meet:
The software produced by the project SHOULD support secure protocols for all of its network communications, such as SSHv2 or later, TLS1.2 or later (HTTPS), IPsec, SFTP, and SNMPv3. Insecure protocols such as FTP, HTTP, telnet, SSLv3 or earlier, and SSHv1 SHOULD be disabled by default, and only enabled if the user specifically configures it. If the software produced by the project does not support network communications, select "not applicable" (N/A).
The software produced by the project SHOULD, if it supports or uses TLS, support at least TLS version 1.2. Note that the predecessor of TLS was called SSL. If the software does not use TLS, select "not applicable" (N/A). [crypto_tls12]
The software produced by the project MUST, if it supports TLS, perform TLS certificate verification by default when using TLS, including on subresources. If the software does not use TLS, select "not applicable" (N/A). [crypto_certificate_verification]
The software produced by the project MUST, if it supports TLS, perform certificate verification before sending HTTP headers with private information (such as secure cookies). If the software does not use TLS, select "not applicable" (N/A). [crypto_verification_private]
Here is the questionnaire :
https://bestpractices.coreinfrastructure.org/en/projects/5925?criteria_level=1

We should investigate what is the normal way to do this with Container Images, because during deployment the SSL Certificate probably needs to be injected for use. @Sander3003, maybe discuss this also internally how they are doing it within OpenShift of Alliander by other teams.

Using the NGINX proxy ensures the use of https


Dragable Polygon

guys, there is any kind of function that can move Leaflet entire polygon draggable on the map please help me

guys, there is any kind of function that can move Leaflet entire polygon draggable on the map please help me

you can use it https://github.com/w8r/Leaflet.draw.drag
jsfiddle: https://jsfiddle.net/w8r/2a5j2x07/


How to upload multiple images for product using one to Many relationship?

Laravel Version: #.#.#
Voyager Version: #.#.#
PHP Version:
Database Driver & Version:

Description:
Steps To Reproduce:

Please fill in all the required information and we will be glad to assist.
Closing this until information is provided.


Chapter 6.4.2 - Allowing ICMP traffic

Hi,
When i try "ping ec2-52-5-109-147.compute-1.amazonaws.com" in my terminal, i receive the expected output of the non-working ping (Request timeout....).
The issue I'm having is that after I've created the appropriate stack with the right template (https://amazonaws.com/awsinaction/chapter6/firewall2.json, I'm still receiving the same 'Request timeout' output. The stack has completed successfully, so I'm not sure what to do.
Please help whenever you can.

 I had to replace the ec2 instance created with the Stack to the one you mentioned in the book! Thought It would have been nice to list this in the book (i.e. "$YOUR_INSTANCE_ID).


Pinging pinterest jira in env_landing

Not an error really, just spammy.
Link:
https://github.com/pinterest/teletraan/blob/44877793307f45ee543a09909ed8862d2c675052/deploy-board/deploy_board/templates/deploys/warning_no_deploy.tmpl#L11
Does not seem to be behind a IS_PINTEREST guard.

fixed with https://github.com/pinterest/teletraan/pull/559

👍


'schema' folder to create dynamic schemas

Hi my friend, thanks for this module! It's very useful, like magic! 👍
What do you think about to create a "schema" folder to create multiples schemas using the same models?
For example =>
/path/to/models
├── user.js
├── schema
│   ├── product.js
│   └── contact.js
└── index.js

And in the index.js
var models = require('sequelize-auto-import')(sequelize, '/path/to/models', {
   schemas: ['company1', 'company2', 'company3']
});

And access the models in this way:
models.user
models.company1.product
models.company1.contact
models.company2.product
models.company2.contact
models.company3.product
models.company3.contact

Thanks in advance, Nicholls

sure! seems like there is a good use case behind this option. PR welcome! if not, i will work on it in the end of the week.

Thanks! About the PR, let me check your code first :)

Hi @bjrmatos, sorry for my mistake, my changes are working properly! 💯


WIP: Update step registration to use catch_unwind instead of InvokeResponse

This is only the runner.rs file (because I'm editing from github). It provides a simpler panic-based test api, and hides the invoke response internals.

This now does way more things than it should.
It:

Adds a rustfmt file
Adds command line support to cucumber (so long as you make sure to set "harness = false")
Adds support for handling panics in steps
Adds three  new methods on the Cucumber argument: "fail", "pending", and "succeed_immediately"


Support rally points

Implement rally points (http://copter.ardupilot.com/wiki/common-rally-points/)
@DonLakeFlyer How are rally points transferred in missions in APM now?

Rally points is a custom ArduPilot dialect mavlink message protocol. I think rally points need to be thought through with respect to landing sequences from DO_LAND_START. They seem to me to be kind of the same thing. It's odd that rally points are a special thing to me. Seems like they could be handled with landing sequences in a mission. But I guess you can send rally points without needing a mission.

I think failsafe landing points or "rally points" as APM calls them is an important feature to have during autonomous flight. A fixed wing should be able to land safely (or at least make an attempt) when thrust is lost or lipo is critical. VTOL should also be considered as this might involve a failsafe transition to MC, the MC might not be able to reach the home point. Failsafe landing zones should indeed not be limited to missions as RTL mode could be engaged from several modes.
For FW  we could consider a few approaches;

add a separate DO_LAND_START for every failsafe point
Have the failsafe landing point contain a preferred approach heading
Land in a spiral and assume enough clearing around the failsafe point
A combination of the above

@DonLakeFlyer Are rally points in APM stored separate from missions? and does QGC support control over them separate from missions?
@LorenzMeier @tumbili any thoughts?

QGC does not currently support rally points. Rally points are unrelated to missions in APM as far as I can tell.

I've heard a few requests for rally points and their use in fixed wing landing.
I believe it would be something like for landing fly to the rally point, circle down, and break out where appropriate on the glide slope for landing approach.
I think the other use is as a home substitute for RTL?
If we can work through the details of rally points I could implement the fixed wing landing piece.

I believe rally points in ardupilot are a multi rotor thing. Fixed wing is DO_LAND_START.

On Mar 15, 2016, at 8:41 AM, Daniel Agar<EMAIL_ADDRESS>wrote:
I've heard a few requests for rally points and their use in fixed wing landing.
I believe it would be something like for landing fly to the rally point, circle down, and break out where appropriate on the glide slope for landing approach.
I think the other use is as a home substitute for RTL?
If we can work through the details of rally points I could implement the fixed wing landing piece.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/PX4/Firmware/issues/3824#issuecomment-196886275

hmm, it sounds like we need MAV_CMD_DO_LAND_START implemented in PX4.

@sanderux I've started implementing MAV_CMD_DO_LAND_START
Do you want to revisit this and discuss exactly what you need?
So far it's going to be

as a mission item MAV_CMD_DO_LAND_START marks the start of the landing sequence in a mission (approach + land)
as a command it initiates AUTO at MAV_CMD_DO_LAND_START. I'm also considering making the AUTO_LAND mode do the same
then we can combine RTL (failsafes) with landing properly through the predefined approach + land

I haven't through how supplying LAT/LON with sending a MAV_CMD_DO_LAND_START command should work.
Do you think we need multiple failsafe points?

@dagar For commercial applications failsafe sites will be a must-have.
According to the mavlink spec the MAV_CMD_DO_LAND_START initiates a landing at the closest landing site. When given coordinates it would be the closest to that location. but i think there is some nuance in this, first let me explain what my idea on failsafe sites (or rally points) is:
I think rally points is a good start but rally area's would be better. You could think about the following scenario: A plane performs coastline inspections, for visibility and safety reasons it will fly over water. When the FC detects a problem with thrust it can start the failsafe procedure and land. It should not land in the water for obvious reasons. Depending on the location either the beach or the terrain just behind the beach would be a good place to land, no specific location but an entire area. The same would be true for road, electricity, rail or oil pipeline inspections.
On the nuance of choosing a landing site i think we should consider the both feasibility and the reason for initiating the landing. Obviously the designated landing site would be preferred over a failsafe site, even if a failsafe area might be closer. You could judge that based on why the land_start was initiated (was it actually a failsafe event) or decide based on feasibility (or both),
As i'm considering all these scenario's i'm not even sure if all of this should be managed by the FC, maybe a sidekick computer should take care of this. Let me know what you think on this matter.

I'll try to stay on topic for this particular issue and focus on rally points. There are a lot of different areas I want to improve for fixed wind autonomy and failsafes, but right now let's just try to determine if we want APM style rally points or not.
So if I'm flying a fully autonomous mission and hit a failsafe where the plane is still functional (loss of comms, low battery threshold, etc) I think what I almost always want is to fly home and land safely at the preplanned approach + landing waypoint.
Now if that's not possible and I can't make it home (bad motor, GPS, etc) what should happen? Would I go through the planned mission and periodically insert rally points for safe landing spots? Or would it make more sense to extend the geofence system so that's it's factored in and respected during the failsafe landing modes (AUTO_LANDENGFAIL, AUTO_LANDGPSFAIL, DESCEND, etc). Assuming you still have gps...
For now (over the next week) I'm going to implement MAV_CMD_DO_LAND_START and MAV_CMD_DO_GO_AROUND, which gives me safe auto lands in the event of loss of comms, etc. Let's try to think through what we'd like to have eventually.
Right now I'm not sure if I'd ever use APM rally points. What do you think?

Geofence made it in but it still WIP, moving this.

@LorenzMeier was this integrated or need to have the milestone changed?

@lfelipe Geofence is in master, but the rally points (while supported on the protocol level) need someone to push for regarding testing. It would not be hard and can be completely wrapped up in SITL.

Current discussion is here: https://github.com/PX4/Firmware/issues/7565


Changes to  google authenticator seed length

Fixing issue #7

Coverage decreased (-0.01%) to 99.499% when pulling 44518adc554718b779734753e462e3fbb170b9d4 on hotfix/google-auth-issues into 11ebfd67655fe31123df22226e3d6e5849451473 on master.

Coverage decreased (-0.01%) to 99.499% when pulling 833b9fe1d99281db130cdfb530e2f8da9acaa508 on hotfix/google-auth-issues into 11ebfd67655fe31123df22226e3d6e5849451473 on master.

Coverage decreased (-0.01%) to 99.499% when pulling f2a69ef417df0837ba240949f8858da00f1d9d0f on hotfix/google-auth-issues into 11ebfd67655fe31123df22226e3d6e5849451473 on master.


Routing + Upgrade integration test for precaching.

R: @jeffposnick @addyosmani @philipwalton
Hopefully this is representative of a service worker flow for precaching.

@jeffposnick another review please.


Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m  0s
Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem
Report/Notes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 12s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
javadoc
0m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 22s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

-1 :x:
unit
132m  7s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 21s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
0m 40s
hbase-it in the patch passed.

150m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
javac javadoc unit compile

uname
Linux 4818e90e0a55 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f640b7fd27

Default Java
AdoptOpenJDK-11.0.10+9

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/testReport/

Max. process+thread count
2889 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
compile
1m 13s
master passed

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 20s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

-1 :x:
unit
148m 35s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 41s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
0m 44s
hbase-it in the patch passed.

166m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
javac javadoc unit compile

uname
Linux 3e631341e97e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / f640b7fd27

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/testReport/

Max. process+thread count
1588 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m  0s
Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem
Report/Notes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m  1s
Docker command '/usr/bin/docker' is too old (1.41 < API v 1.27.0).

Subsystem
Report/Notes

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 38s
master passed

+1 :green_heart:
compile
1m 13s
master passed

+1 :green_heart:
javadoc
0m 46s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 18s
the patch passed

+1 :green_heart:
compile
1m 13s
the patch passed

+1 :green_heart:
javac
1m 13s
the patch passed

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

-1 :x:
unit
140m 53s
hbase-server in the patch failed.

+1 :green_heart:
unit
4m 41s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
0m 45s
hbase-it in the patch passed.

159m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
javac javadoc unit compile

uname
Linux 06a1c9cc328a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ef280d4d8d

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/testReport/

Max. process+thread count
3039 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 12s
master passed

+1 :green_heart:
compile
2m 59s
master passed

+1 :green_heart:
checkstyle
0m 48s
master passed

+1 :green_heart:
spotbugs
1m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

+1 :green_heart:
javac
2m 57s
the patch passed

+1 :green_heart:
checkstyle
0m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 30s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
2m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

37m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux e4d0015e639d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 520ad638d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 53s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 48s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 10s
master passed

+1 :green_heart:
compile
1m 13s
master passed

+1 :green_heart:
shadedjars
4m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
4m  7s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
182m 54s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  7s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
0m 47s
hbase-it in the patch passed.

212m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e6d25b3f6f4e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 520ad638d9

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/testReport/

Max. process+thread count
3154 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 10s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  7s
master passed

+1 :green_heart:
compile
1m 30s
master passed

+1 :green_heart:
shadedjars
4m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s
the patch passed

+1 :green_heart:
compile
1m 25s
the patch passed

+1 :green_heart:
javac
1m 25s
the patch passed

+1 :green_heart:
shadedjars
4m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
185m 44s
hbase-server in the patch passed.

+1 :green_heart:
unit
4m  7s
hbase-endpoint in the patch passed.

+1 :green_heart:
unit
0m 52s
hbase-it in the patch passed.

216m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4221

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 78c3a9a6b357 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 520ad638d9

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/testReport/

Max. process+thread count
2801 (vs. ulimit of 30000)

modules
C: hbase-server hbase-endpoint hbase-it U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Do you have any further comments @Apache9 ? Here, or on #4220 ?

Thanks @Apache9


Set Initial Zoom

Using the lib like this:

    <panZoom selector="#g1" @init="onInit">

methods: {
    onInit: function (panzoomInstance, id) {
      console.log('panzoomInstance :>> ', panzoomInstance)
      panzoomInstance.setMaxZoom(5)

      // panzoomInstance.zoomTo(0, 2000, 4)
      // panzoomInstance.zoomAbs(0, 1000, 5)

    },
  },

Neither zoomTo or zoomAbs zooms into the picture. Thoughts?

Did you solve it? Cam't access half the functions with the panzoomInstance any other way around it ?

Using the lib like this:

    <panZoom selector="#g1" @init="onInit">

methods: {
    onInit: function (panzoomInstance, id) {
      console.log('panzoomInstance :>> ', panzoomInstance)
      panzoomInstance.setMaxZoom(5)

      // panzoomInstance.zoomTo(0, 2000, 4)
      // panzoomInstance.zoomAbs(0, 1000, 5)

    },
  },

Neither zoomTo or zoomAbs zooms into the picture. Thoughts?

@chasen-bettinger can you share a fiddle? I can't reproduce your issue

Did you solve it? Cam't access half the functions with the panzoomInstance any other way around it ?

can you share your code and how you're doing it?

Closing this for inactivity


Inconsistent usage of storage.yml

Description:
The parts that are not configured in the storage.yml have an inconsistent usage
Steps to reproduce:
When activating/deactivating a plugin that triggers a recompile, the files are saved in the storage configured under "public", but are not read from there.
Expected result:
Either it uses the local storage for reading and writing, since it's not configured or it defaults to the configuration in "public" for reading & writing
Actual result:
For writing the configured storage in public is used.
For reading is not.
Resulting in a broken storefront.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-30549
[created from NEXT-30549, comment 514438]


Reword cloud-config opt-in warning

Most of the release manifest generation don't yet support cloud-config  (such as cf-release). Opt-in would prevent deploying them unless their manifest generation gets patched.
See related slack discussion at https://cloudfoundry.slack.com/archives/bosh-users/p1458080218000039

Merged.


Registry and Staking

Tracking issue for https://github.com/project-serum/rfcs/blob/master/text/0001-registry.md

Addressed by https://github.com/project-serum/serum-dex/pull/51.


Feedback for “Hive CLI (Command Line Interface)”

Feedback on https://the-guild.dev/graphql/hive/docs/api-reference/cli
If /usr/local/lib does not exist (which it didn't for me or any of my colleagues) then curl -sSL https://graphql-hive.com/install.sh | sh fails silently.
We solved it with
cd /usr/local
sudo mkdir lib

but this should be improved.

what OS was this on?

what OS was this on?

macOS Sonoma

Duplicate of https://github.com/graphql-hive/platform/issues/3292


python310Packages.aiobiketrax: 1.0.0 -> 1.1.0

Diff: https://github.com/basilfx/aiobiketrax/compare/refs/tags/v1.0.0...v1.1.0
Changelog: https://github.com/basilfx/aiobiketrax/blob/v1.1.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 241062 run on x86_64-linux 1

4 packages built:

python310Packages.aiobiketrax
python310Packages.aiobiketrax.dist
python311Packages.aiobiketrax
python311Packages.aiobiketrax.dist


Updated salti for attachments

Closes #1553.

PR is added to the queue for testing as 1. task. (8f8f84a)

Test 94997229 (8f8f84a) build started.

Test (Success) 94997229 build is completed (8f8f84a)
See https://github.com/ThaliTester/TestResults/tree/949972298f8f84a_Updated_salti_for_attachments_andrew-aladev/ for the logs

Test 949972298f8f84a(8f8f84a) has failed
See https://github.com/ThaliTester/TestResults/tree/949972298f8f84a_Updated_salti_for_attachments_andrew-aladev/ for the fail logs

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


unrecognized arguments: NetworkWatcherRG cloud-shell-storage-westeurope rg-dp100-labs westeurope westeurope eastus

Im trying to create a sample VM on powershell and im getting this error:
unrecognized arguments: NetworkWatcherRG cloud-shell-storage-westeurope rg-dp100-labs westeurope westeurope eastus
PS /home/anna> az vm create `

--resource-group $rg.ResourceGroupName --location $rg.Location
--name vm-demo-001 --image UbuntuLTS
--admin-username cloudanna --generate-ssh-keys
--no-wait
unrecognized arguments: NetworkWatcherRG cloud-shell-storage-westeurope rg-dp100-labs westeurope westeurope eastus

@HMAnnex
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

@HMAnnex
Since we have not heard back from you, we will now proceed to close this thread.
If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.