[Flatpak release]: ssh_askpass not found

Issue Type
Bug
Description

Use Debian Stretch (GNOME + Wayland), everything up-to-date
Use flatpak from Debian's repos
Install VS Code using the package (which appears to be officially) distributed at flathub.org
Start VS Code and try to use Git integration (anything, here git pull as an example) on a repo where you use SSH authentication with a SSH key protected by passphrase

Error log (as a side note: /usr/libexec/ssh-askpass does indeed not exist)

git pull
ssh_askpass: exec(/usr/libexec/ssh-askpass): No such file or directory
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Please note

Error not reproducible in gnome-terminal (external)
From global config: "terminal.integrated.shell.linux": "/bin/bash"
Error not reproducible in integrated terminal (at least I get a prompt there to input my passphrase for my SSH key)
SSH key is unlocked, so if I run git pull from gnome-terminal (external), I do not need to enter the passphrase
In the integrated terminal I get asked for the passphrase for each command,  so VS Code obviously cannot access the unlocked SSH keys (maybe because of the sandbox? I don't know if this can even be addressed...)
In the integrated terminal, I do not have access to the commands ssh-add or similar. I thought I could just add the SSH key in the terminal to unlock it at least in the sandbox, but to no avail

Expected behaviour

I expect the same behaviour as in the .deb release where I do not need to unlock the keys and it "just works" out of the box

VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:31:21.019Z)
OS version: Debian Stretch (Kernel: Linux x64 4.9.0-5-amd64)

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 x 3284)

Load (avg)
0, 0, 0

Memory (System)
15.59GB (0.24GB free) (htop says more than 11GB free)

Process Argv
/app/extra/vscode/code --extensions-dir=/home/usr/.var/app/com.visualstudio.code/data/vscode/extensions --reuse-window

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

python
ms-
2018.1.0

Reproduces without extensions

We do not ship a flatpak, see https://code.visualstudio.com/docs/setup/linux for the official/trusted channels.

Sorry for the inconvenience, I thought it was an official channel.
For future reference - I opened an issue in the flathub repositories: https://github.com/flathub/com.visualstudio.code/issues/23


Rancher on k3s logging [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Install 2 node k3s cluster:
INSTALL_K3S_SKIP_DOWNLOAD=true INSTALL_K3S_EXEC="--cluster-cidr <IP_ADDRESS>/16 --service-cidr <IP_ADDRESS>/16 --cluster-dns <IP_ADDRESS> --flannel-backend=ipsec" K3S_DATASTORE_ENDPOINT="mysql://${username}:${password}@tcp(${endpoint}:3306)/${dbname}" INSTALL_K3S_EXEC="--no-deploy traefik" k3s.sh

Deploy rancher helm chart on cluster
apiVersion: helm.cattle.io/v1
kind: HelmChart
metadata:
  name: rancher
  namespace: kube-system
spec:
  chart: rancher
  repo: https://releases.rancher.com/server-charts/latest
  version: "v2.3.5"
  targetNamespace: cattle-system
  set:
    hostname: "%HOSTNAME%"
    tls: external
    antiAffinity: required
    replicas: 2

Result:
Seeing
> kubectl logs -n cattle-system rancher-86846968db-c6smj | grep InvalidBodyContent
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
> kubectl logs -n cattle-system rancher-86846968db-nvbxz | grep InvalidBodyContent
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI
2020/03/05 06:14:00 [ERROR] Error certs=InvalidBodyContent 422: failed to parse key: key must be PEM encoded PKCS1 or PKCS8: x509: failed to parse private key (use ParseECPrivateKey instead for this key format) parsing cert k3s-serving. Will not display correctly in UI

Other details that may be helpful:
No noticeable impact or issues with Rancher.
See also https://github.com/rancher/rancher/issues/25236
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.3.5
Installation option (single install/HA):
HA/k3s

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported):
k3s
Machine type (cloud/VM/metal) and specifications (CPU/memory):
m5.large on AWS
Kubernetes version (use kubectl version):

1.17.3

Docker version (use docker version):
NA, using containerd

Duplicate of https://github.com/rancher/rancher/issues/24423


Unify naming across all json responses

Need to unify the responses for all REST API jsons.
ex:
LS Host can be Host or LSHost.
Need to create a precise naming convention.

Structure:
{
"Status":<Environment Error, File I/O,Network, Malformed URI, Malformed Request, Missing Instance, DB entry Fault>,
"Message":"Message ..."
}


Add DatasetGroupBy.quantile

This adds DatasetGroupBy.quantile by moving DataArrayGroupBy.quantile to GroupBy as proposed in https://github.com/pydata/xarray/issues/3018#issuecomment-507749287.
The tests are a modified copy of the ones from #2828. What confuses me is that expected_yy in test_ds_groupby_quantile needs the transpose whereas the equivalent in test_da_groupby_quantile doesn't. Does anyone have an idea about why that is?

[x] Closes #3525
[x] Tests added
[x] Passes black . && mypy . && flake8
[x] Fully documented, including whats-new.rst for all changes and api.rst for new API

is Bug Fixes the correct section for this?

Let's do enhancements!

that would open a new category. Should I use New Features?

:+1:

the difference is here, where in DataArray the original dimension order is restored.

LGTM @keewis.
Re: docstring. If you jave time, can you add a couple of examples (just pick two from the tests) to illustrate the scalar vs vector behaviour of q?

sure. But as Dataset.quantile and DataArray.quantile don't have examples either, I think it might be worth to do that in a new PR?
Also, what will we do re transpose?

:+1:
The transpose is fine, I think. It looks intentional and must be consistent with other Dataset/DataArray operations?

well, it was surprising to me. It also might be problematic that it matters if we first pull out a DataArray and then compute or the other way around:
>>> ds = xr.Dataset(
...     data_vars={
...         "a": (
...             ("x", "y"),
...             [[1, 11, 26], [2, 12, 22], [3, 13, 23],^I[4, 16,^I24], [5, 15, 25]],
...         )
...     },
...     coords={"x": [1, 1, 1, 2, 2], "y": [0, 0, 1]},
... )
>>> a_ds = ds.groupby("y").quantile(0).a
>>> a_da = ds.a.groupby("y").quantile(0)
>>> a_ds.identical(a_da)
False
>>> a_ds.transpose().identical(a_da)
True

Hmm.. ok calling mean in this example passes the identical check so maybe there's something funny in quantile:
ds = xr.Dataset(
    data_vars={
        "a": (
            ("x", "y"),
            [[1, 11, 26], [2, 12, 22], [3, 13, 23],
             [4, 16,24], [5, 15, 25]],
        )
    },
    coords={"x": [1, 1, 1, 2, 2], "y": [0, 0, 1]},
).expand_dims({"z": [0,1,2]})
a_ds = ds.groupby("y").mean("x").a
a_da = ds.a.groupby("y").mean("x")
a_ds.identical(a_da)

but that's only because mean removes x, doesn't it?

I can also reproduce this with std

I can also reproduce this with std

Which behaviour can you reproduce?
Replacing mean with std in my last example passes the identical check. Actually this works too
a_ds = ds.groupby("y").apply(lambda x: x).a
a_da = ds.a.groupby("y").apply(lambda x: x)
a_ds.identical(a_da)

Dimension reordering has come up a few times before (https://github.com/pydata/xarray/issues/1739, and others that I can't immediately find)
I think we should probably have a general solution & standard behavior here. Others should weigh in (CC @shoyer), but I would vote to not worry too much about it here, and prioritize simplicity and consistency with past behavior until we decide on a more general solution.

the difference is here, where in DataArrayGroupBy the original dimension order is restored. DatasetGroupBy does not do that, so the test requires the transpose

It was not entirely obvious to me how to generalize "restoring dimension order"  to Dataset. On a Dataset, it is not entirely clear which variable dimension order should be copied from. Maybe each variable in the  result should have dimension order copied from the variable with the same name in the original dataset? But then what about new variables?
I agree @max-sixty, let's not worry about this too much for now.

In it goes. Great work as usual, @keewis. Thanks!

Which behaviour can you reproduce?

ds = xr.Dataset(
    data_vars={
        "a": (
            ("x", "y"),
            [[1, 11, 26], [2, 12, 22], [3, 13, 23],
             [4, 16,24], [5, 15, 25]],
        )
    },
    coords={"x": [1, 1, 1, 2, 2], "y": [0, 0, 1]},
).expand_dims({"z": [0, 1, 1, 2, 2]})
a_ds = ds.groupby("y").std().a
a_da = ds.a.groupby("y").std()
a_ds.identical(a_da)

which seems to be the same as
a_ds = ds.groupby("y").mean("y").a
a_da = ds.a.groupby("y").mean("y")
a_ds.identical(a_da)

My impression is that this puts the dimension grouped over to the front:

before: ds.a.dims == ("z", "x", "y")
afterwards: a_ds.dims == ("y", "z", "x")

But I agree this discussion does not really belong here. So, thanks all!


Issue #195: Changed assertj assertions to junit and hamcrest assertio…

…ns in grade-school. Removed assertj from grade-school gradle build file. This should fix issue #195 .

👍


Do not make empty search API calls to algolia

Data shows that the most searched term on our website is empty (LOL). We should prevent our app from making empty search api calls, to reduce our usage.

This should have fixed the empty search issue on search page.

You are probably aware of this already :) but remember that the empty search is the initial state for the news room ++ 👍

You are probably aware of this already :) but remember that the empty search is the initial state for the news room ++ 👍

@wenche True, news indices have the majority empty searches.

Empty search on newsroom and magazine is unavoidable, otherwise no results will be shown and nothing can be filtered out of an empty result.
https://www.algolia.com/doc/guides/search-analytics/guides/exclude-queries/#empty-searches
We are not sending empty searches on the search page, so we have done the maximum optimization.


Use an environment for all files/tabs

Is there a way to set an environment for all opened http files instead of select it individually for each tab/file in VS Code?
We would like to select an environment which is valid for all http files.

with next release a new setting httpyac.environmentUseSameForAllFiles to enable this feature


Tesseract can support several languages

Describe the solution you'd like
Would be nice if we could give the option to the user to use multiple languages on Tesseract.
Additional context
Documentation should also be updated according to the above.

Has been added with this release https://github.com/wswebcreation/wdio-ocr-service/releases/tag/v1.1.3


Uses proper tables for tabular data

The doc browser was using divs to display tables. This is highly inaccessible (good luck with a screen reader) and breaks in the following ways:

Columns overlap:

Breaks completely on mobile:

This PR changes all of these to use proper tables. To solve these issues.

Jakub, the divs instead of a table are a design 'feature'. The goal behind them is that different types of attributes can provide rendering templates for their row (and same for top-level types). It is actually possible now, although it is not really documented because it needs to be done slightly differently.
However, what you might be bringing up with this is that there might be some more work to be done so that they play nicer with other mediums. I'm not an expert with this so I'd like people like @ventajou, @barrydorman or @stevecrozz which have already contributed in that area to weigh in.

Sure but even if they provide their own templates, they can still be proper table rows (see https://github.com/gampleman/praxis/blob/tables/lib/api_browser/app/views/directives/attribute_table_row/_struct.html for a way to do it). Accessibility is a very serious concern and may make the doc browser quite unusable for people who need to adhere to regulations about it.

If this isn't supposed to be a table, then why is it displayed with a header, rows, and columns? It seems like if each row can have a different enough template that an HTML table wouldn't work, then it would be better to just display it in a different format entirely.
However, I'd imagine that constraining each row to be a table row would provide enough of a legibility advantage to be worth it, at least for the default doc browser.

I don't think we have enough examples to where we can really say what's needed. But this looks better than what we currently have for our current stuff, so I'm ok with this. We can always change it later if we find this inadequate.

IIRC the problem with tables is that you can't really nest a table inside a row which I think we talked about doing at some point for certain types.

Here are some cases for which having a flexible "row"/"div" is important:

Attributes of a type that supports sub-attributes. These, in essence will need to add sub-rows/divs for each of them, and do it in a way that is it potentially nestable
attributes that have types that are very custom, but commonly seen. For example, a "filter" attribute that can support filtering of different attribute names, each of them requiring to specify if it allow partial matching, if they're optional etc...this is similar to Structs/Hashes but being able to express this in a clear and concise design is important for the quick reading and understanding of the docs
other complex subypes such as a multipart or polymorphic structure. They might need other elements to be drawn in that "row"/"div"
...

Another thought was that I thought that by using the divs and the bootstrap 12  positioning grid we were also getting some of the liquidity/flow of positioning for small sizes and mobile...although I might have just imagined it?
So, anyway, if you guys, think that these things can be supported easily within a table format (and we don't loose any of the liquidity/flow aspects) I'm certainly ok with moving forward.

Well since the template gets the entire <tr> to use, it can do anything it wants with it. The only constraints is that there are headers in the "table" that provide contextual information. This is why it breaks on smaller screens and in screen readers - the "fields" are incomprehensible without the visual cues that are those headings.
As far as I understand, semantically this leaves the following options:

Use a definition list and add labels to each row. Hide these in the desktop width but make sure they are visible to screen readers and display on mobile.
Ignore disabled and mobile users - not an option imho.
Use tables.

Options 1 and 2 need to solve the first issue above. They may seem simpler for implementing custom templates for the scenarios you describe (and nested table rows are slightly counter-intuitive in Angular), but eventually I think solving the issue above in CSS is going to make these solutions more complex in the end.
The template in this PR will allow mobile users to horizontally scroll the tables, which preserves all the contextual information they need to see it.

ok. So, does anybody have a strong opinion towards changing this to use tabular tags for the time being?

ok, then silence implies no strong opinions against tabulating the info instead of using 'divs'
We can revisit later on if we have more impending and concrete use cases that tables might make difficult to implement.
@gampleman can you please sign the PR so I can merge it?

@blanquer done.

LGTM


SincNet Weights

Hi sir, can you please share pre-trained model or it's weights. :)

Within this external repository (https://bitbucket.org/mravanelli/sincnet_models) you can find the TIMIT parameters. Librispeech one wil be available soon!


fontStyle property on TextBlock

Release
Renderer status
Tasks status

1.2
✔ .NET (#1967)✔ Android (#1964)✔ iOS (#1965)✔ TS (#2430)✔ UWP (#1963)
✔ Shared (#1962)

Solves requests

Monospace blocks of text (#1982)

OPEN ISSUE: Would we need author ability to disable markdown so that spaces are preserved? Replacing them with   would be a huge amount of bloat

Solution
Add an additional fontStyle property to TextBlocks, with configurable fonts for each possible fontStyle value in host config. Monospace blocks of text can be achieved by using a container with emphasis style.

Schema
New property on TextBlock

Property
Type
Required
Description

fontStyle
FontStyle
false
Changes the font style

FontStyle

Value
Description

default
The default font style

monospace
The monospace font style

Markup:
{
    "type": "TextBlock",
    "size": "large",
    "weight": "bolder",
    "text": "14,411 ft",
    "fontStyle": "monospace"
}

Why "fontStyle"?

Didn't choose just style since we might want to use style for something else
Didn't choose textStyle since can imagine this font style being useful in other places, like Actions, where the text property is called title rather than text, so font is applicable to both.

Host Config
Add new fontStyles property, which allows defining the font style for each style. Inside each, can set the fontFamily, and also the font sizes, since different fonts may appear larger or smaller. Can set font weights for same reason.
If some properties on a style aren't specified, inherits the properties from the default style.
Deprecate existing fontFamily, fontSizes, and fontWeights properties in exchange for the new fontStyles.
If a host didn't provide the default style but provided the old deprecated properties, those old deprecated properties should be utilized as the default style (and those should be inherited to other styles that also aren't specified).
{
    "fontStyles": {
        "default": {
            "fontFamily": "Arial, sans-serif",
            "fontSizes": {
                "small": 12,
                "default": 14,
                "medium": 17,
                "large": 21,
                "extraLarge": 26
            },
            "fontWeights": {
                "lighter": 200,
                "default": 400,
                "bolder": 600
            }
        },
        "monospace": {
            "fontFamily": "Consolas, serif",
            "fontSizes": {
                "small": 12,
                "default": 14,
                "medium": 17,
                "large": 21,
                "extraLarge": 26
            },
            "fontWeights": {
                "lighter": 200,
                "default": 400,
                "bolder": 600
            }
        }
    }
}

Down-level impact
Low. Text appears and displays pretty well. It simply doesn't have the correct font family.
Host burden
Medium. Changes in structure of host config.
Renderer Requirements

A renderer must use correct inheritance of host config unspecified values
For a given fontStyle, if the fontStyles.[specifiedStyle].[property] value exists, use its value
Otherwise, if wasn't default, see if the default has a value for that
Otherwise, see if the deprecated property has a value for that
Otherwise, use initial default value
A renderer should support displaying the correct fontStyles

Auto-generated task status

[x] Shared
[x] .NET
[x] Android
[x] iOS
[x] TS
[x] UWP

Final spec needed. Also, hosts should be able to define different font sizes for each font in host config, since Consolas 11pt looks bigger than Segoe UI 11pt font.

Looks good for me overall. Only thing is I'm no fan of the term "display" - whether you use the default, display or monospace font styles, they are all for "display". I suggest we go for something like "alternate" or similar.

Agreed - maybe "statistic"? Since that's what it's typically used for?

Display is an existing term in type design, alongside "text" fonts.  The opposite to Monospaced is Proportional fonts

Do we want a warning(s) in some cases where inheritance goes into action. So far I've thought about the following cases and results:

If hostConfig defines any of the deprecated properties
--> Warning: [property] has been deprecated.  Use AdaptiveHostConfig.FontStyles.Default.[property] instead.
If fontStyle.default wasn't defined
--> Warning: FontStyle.Default wasn't defined. Inheriting font style from deprecated properties.
or
--> Warning: FontStyle.Default wasn't defined. Using system default instead.
If fontStyle.[specifiedStyle] wasn't defined
--> Warning: FontStyle.[specifiedStyle] wasn't defined. Using FontStyle.Default instead.
If the desired fontStyles.[specifiedStyle].[property] wasn't defined
--> Warning: FontStyle.[specifiedStyle].[property] wasn't defined. Using system default instead.
or
--> Warning: FontStyle.[specifiedStyle].[property] wasn't defined. Using FontStyle.Default instead.

Also, do we want multiple warnings to occur from the same issue?

Good point! I suppose avoiding multiple warnings would be nice, but not too critical. We definitely should have those warnings!

Are we still going with "display"? I would really prefer "monospace" to make it super clear that's what it is. Authors that will use that style need to know that the host will use a monospace font, given that type of scenarios (e.g. simple tables) this is for.

@dclaux the font Bing wants is NOT monospace (I measured it)

That Bing example uses a Serif font while the normal text is Sans Serif  As most platforms do not offer both a Sans and Serif version of their UI fonts, if you wanted to include a Monospace, Proportional Sans and a Proportional Sans Serif as font styles, then that is extra work for the Host Config in the chosen platform renderer.  Georgia is available on most platforms, that is a Serif type family.  Microsoft uses Consolas for its go to Monospace font.

Sorry, there was some confusion on my side here. I thought we were doing this solely for monospace font support, I didn’t realize for some reason that we also were talking about allowing an alternate font. I am not a huge fan of allowing that alternate font style (I know my designer won’t like it at all). I suppose I could live with it, but honestly the sole example provided hardly justifies it imo. I would suggest not doing it until we can gather more evidence that it is actually needed. If we are going to do it, I would use the term “alternate” rather than “display” or whatnot to emphasize that card authors shouldn’t expect this font to be anything in particular. I would also say that we should probably never offer serif vs sans serif font styles as that would have the potential of letting authors create very ugly cards.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Martin Anderson<EMAIL_ADDRESS>Sent: Wednesday, October 3, 2018 3:34:49 PM
To: Microsoft/AdaptiveCards
Cc: David Claux; Mention
Subject: Re: [Microsoft/AdaptiveCards] Spec: fontStyle property on TextBlock (#1078)
That Bing example uses a Serif font while the normal text is Sans Serif As most platforms do not offer both a Sans and Serif version of their UI fonts, if you wanted to include a Monospace, Proportional Sans and a Proportional Sans Serif as font styles, then that is extra work for the Host Config in the chosen platform renderer. Georgia is available on most platforms, that is a Serif type family. Microsoft uses Consolas for its go to Monospace font.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAdaptiveCards%2Fissues%2F1078%23issuecomment-426826142&data=02|01|dclaux%40microsoft.com|4a700c582aef4f55768d08d629806e01|72f988bf86f141af91ab2d7cd011db47|1|0|636742028911673085&sdata=%2B%2FaJ4QuexOhD3xJwrhuqVvsbD9cgDEVMy44WaZC9SVQ%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRdoTc9dH-wZynxaRw0yQGwrO4zPYnFks5uhTuJgaJpZM4Rgm4s&data=02|01|dclaux%40microsoft.com|4a700c582aef4f55768d08d629806e01|72f988bf86f141af91ab2d7cd011db47|1|0|636742028911683094&sdata=s24FHFt3y8GDQTeUwOptTGFduB5NFibBSwR%2Flvn3gJk%3D&reserved=0.

@matthidinger to speak to the priority of the Bing "display" font feature request.
I like the term alternative, although it's not very semantic, alternative could actually be less prominent. What they're trying to achieve is a more prominent font. Maybe featured or something. I also suggested statistic, since this is typically used when displaying statistics.
Outlook (and other hosts) don't have to provide an alternative font. They could always have it use the normal font, just like they don't have to provide a monospace font either.

While it is true that host don’t necessarily have to provide an alternate font, if they don’t they run the risk of developers complaining for a bug that isn’t one, eventually forcing the host to support the alternate style. Let’s hear from Matt and Bing, but I do believe we need much stronger evidence than the one screenshot provided. It seems to me that using the default font in that card would be a more than acceptable compromise.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Andrew Leader<EMAIL_ADDRESS>Sent: Wednesday, October 3, 2018 4:11:34 PM
To: Microsoft/AdaptiveCards
Cc: David Claux; Mention
Subject: Re: [Microsoft/AdaptiveCards] Spec: fontStyle property on TextBlock (#1078)
@matthidingerhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmatthidinger&data=02|01|dclaux%40microsoft.com|27dd520227f64e3d4a0508d629859028|72f988bf86f141af91ab2d7cd011db47|1|0|636742050958951032&sdata=%2FESrNZULsg4vzeg%2BfN48h4KEGGA3v0l6SVStK9hwdak%3D&reserved=0 to speak to the priority of the Bing "display" font feature request.
I like the term alternative, although it's not very semantic, alternative could actually be less prominent. What they're trying to achieve is a more prominent font. Maybe featured or something. I also suggested statistic, since this is typically used when displaying statistics.
Outlook (and other hosts) don't have to provide an alternative font. They could always have it use the normal font, just like they don't have to provide a monospace font either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FAdaptiveCards%2Fissues%2F1078%23issuecomment-426833425&data=02|01|dclaux%40microsoft.com|27dd520227f64e3d4a0508d629859028|72f988bf86f141af91ab2d7cd011db47|1|0|636742050958951032&sdata=N2a3Ov0QJtP6rg2tWLvTMZ6Er6WSKzrwNNcqhCECs0I%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRdoQnTsxM65u22Zvbd45ORi7nzq8vuks5uhUQmgaJpZM4Rgm4s&data=02|01|dclaux%40microsoft.com|27dd520227f64e3d4a0508d629859028|72f988bf86f141af91ab2d7cd011db47|1|0|636742050958961046&sdata=ewNXu6c7iNRf2UjiO0bObFBiYP8x370Rj6nqm%2Fmkwm8%3D&reserved=0.

Can we close on this? I still have the same concerns about the "display" font:

I don't think we should have it:

The only one example provided doesn't justify adding it
While if we do have it hosts can basically make "default" and "display" the same, partners/developers will think there's a bug when their card doesn't actually use two distinct fonts in some hosts (like Outlook)

If we do have it

The term "display" is meaningless to the people who author cards (developers in general). We'd need a term that clearly identifies the font style as an alternative to "default": all font styles are for display purposes after all.

About the monospace font style - it is supposed to help create simple tables or code blocks. But Markdown collapses consecutive spaces. So we have two choices:

No Markdown for TextBlocks that use the monospace style
We don't introduce the monospace font style, and instead provide another way to do a code block/simple table by, for instance, introducing a CodeBlock element

If we were to do the latter, then there would be no remaining reason to support fontStyle on TextBlock.

@matthidinger to speak towards whether Bing needs a "display" (or whatever we choose to call it) font for 1.2. An alternative could be that Bing uses extensibility, but we did already approve the proposal to add two font styles (monospace and display). I'm happy to find a better name for it! Or if Bing doesn't need it (or can use extensibility), I'm happy to cut it!

For the monospace concern, we could add the isMarkdown property. That's how I'd personally solve it. Thoughts @matthidinger?

I am fine with the isMarkdown property as a solution. I would however call it useMarkdown, and I would also consider adding it to all containers (including the card itself) to make it easy to disable markdown for all or part of the card in one shot.
@matthidinger looking to hearing from you about the need for a "display" font. Adding this just for Bing and for that particular scenario doesn't feel right to me.

Consensus was to remove the display value (so we're only adding monospace). Updated the spec to reflect that.

Spec changes from meeting today with Andrew, Becky, David, and Mike
DECISION: Rename to fontType, since it refers to picking a collection of a set of values.
Card authors send...
{
    "type": "TextBlock",
    "text": "Text to display",
    "weight": "bold",
    "size": "large",
    "fontType": "default | monospace", // New property
}

Hosts in HostConfig specify
{
    "fontTypes": {
        "default": {
            "fontFamily": "Segoe UI, Tahoma, Geneva, Verdana, sans-serif",
            "fontSizes": {
                "small": 12,
                "default": 14,
                "medium": 17,
                "large": 21,
                "extraLarge": 26
            },
            "fontWeights": {
                "lighter": 200,
                "default": 400,
                "bolder": 600
            }
        },
        "monospace": {
            "fontFamily": "Consolas",
            "fontSizes": {
                "small": 11,
                "default": 13,
                "medium": 16,
                "large": 19,
                "extraLarge": 24
            },
            "fontWeights": {
                "lighter": 200,
                "default": 400,
                "bolder": 600
            }
        }
    }
}

For record purposes, other options we considered...
Call it fontFamily
Card authors send...
{
    "type": "TextBlock",
    "text": "Text to display",
    "weight": "bold",
    "size": "large",
    "fontFamily": "default | monospace", // New property
}

Hosts in HostConfig specify
{
    "fontFamilies": {
        "default": {
            "fontFamily": "Segoe UI, Tahoma, Geneva, Verdana, sans-serif",
            "fontSizes": {
                "small": 12,
                ...
            },
            "fontWeights": {
                ...
            }
        },
        "monospace": {
            ...
        }
    }
}

Concerns:

David and Becky feel that the fact that fontFamilies has a property in it called fontFamily plus the other properties is odd

Call it fontFamily for authors, and fonts for hosts
Card authors send...
{
    "type": "TextBlock",
    "text": "Text to display",
    "weight": "bold",
    "size": "large",
    "fontFamily": "default | monospace", // New property
}

Hosts in HostConfig specify
{
    "fonts": {
        "default": {
            "fontFamily": "Segoe UI, Tahoma, Geneva, Verdana, sans-serif",
            "fontSizes": {
                "small": 12,
                ...
            },
            "fontWeights": {
                ...
            }
        },
        "monospace": {
            ...
        }
    }
}

Concerns:

David and Becky feel that what the property is called in the card must correlate to what the property is called in the host config

Call it fontStyle
Card authors send...
{
    "type": "TextBlock",
    "text": "Text to display",
    "weight": "bold",
    "size": "large",
    "fontStyle": "default | monospace", // New property
}

Hosts in HostConfig specify
{
    "fontStyles": {
        "default": {
            "fontFamily": "Segoe UI, Tahoma, Geneva, Verdana, sans-serif",
            "fontSizes": {
                "small": 12,
                ...
            },
            "fontWeights": {
                ...
            }
        },
        "monospace": {
            ...
        }
    }
}

Concerns:

Andrew and Mike feel concerned with overloading terminology of HTML/XAML/Android. In HTML and XAML, fontStyle is used solely for "italic | oblique". Android calls textStyle="normal|bold|italic", so similarly the style is referring to modifications to the font family.

Implemented here: https://github.com/microsoft/AdaptiveCards/pull/2905/files/7c2a0b4a1c44567ff47a2e286ed03b330f2b0081..599282f671a5727aa2b530e82da4f3c910bc27ee


Integration with EOS voice

I have a question about integrating this plugin with a pre-existing integration with the EOS for voice rooms.
I have everything setup for users to join voice rooms and talk.  I'm now trying to see if I can add runtime speech recognition for accessibility purposes.  However I'm running into a problem where the recognized speech is coming back as just asterisks.  I'm unsure if this is an initialization issue on my end or when I convert the array of shorts to floats.  This is all done in C++ not blueprint.
My setup looks like so:
	SpeechRecognizer = USpeechRecognizer::CreateSpeechRecognizer();
	const auto SpeechParams = USpeechRecognizer::GetStreamingDefaults();
	SpeechRecognizer->SetRecognitionParameters(SpeechParams);
	SpeechRecognizer->SetLanguage(ESpeechRecognizerLanguage::En);
	SpeechRecognizer->OnRecognizedTextSegmentNative.AddLambda([this](const FString& Str)
	{
		UE_LOG(LogTemp,Warning,TEXT("Recognized text: %s"), *Str);
	});
	SpeechRecognizer->StartSpeechRecognition(FOnSpeechRecognitionStartedStatic::CreateLambda([](bool IsSuccess)
	{
		if(!IsSuccess)
		{
			UE_LOG(LogTemp, Error, TEXT("Failed to start speech recognition"))
		}
	}));

I then later register a delegate on my user to get audio buffers and send these to the recognition system
	VoiceChatUser->RegisterOnVoiceChatBeforeRecvAudioRenderedDelegate(FOnVoiceChatBeforeRecvAudioRenderedDelegate::FDelegate::CreateLambda([this](TArrayView<int16> PcmSamples, int SampleRate, int Channels, bool bIsSilence, const FString& /*ChannelName*/, const FString& /* PlayerName */)
	{
		this->SpeechRecognizer->ProcessAudioData(Audio::FAlignedFloatBuffer(MoveTemp(PcmSamples)), SampleRate, Channels, false);
	}));

However my logs look like so:
LogRuntimeSpeechRecognizer: Recognized text segment: " * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *"

Sometimes there are parenthesis.  Oddly sometimes it says it detected "you".  Have you seen others integrate this with EOS RTC and have any tips on where I'm going wrong?

Hi! This usually means that the audio data passed isn't correct, and in your case, you should convert the TArrayView<int16> to Audio::FAlignedFloatBuffer. For example, you can do it like this:
#include "DSP/FloatArrayMath.h"

TArrayView<int16> PcmSamples;
Audio::FAlignedFloatBuffer TransformationsBuffer;
Audio::FAlignedFloatBuffer PcmSamples_Float;
TransformationsBuffer.SetNumUninitialized(PcmSamples.Num());
Audio::ArrayPcm16ToFloat(MakeArrayView((int16*)PcmSamples.GetData(), PcmSamples.Num()), TransformationsBuffer);
PcmSamples_Float = TransformationsBuffer;

Apart from that, everything looks good to me

That did the trick!  Thank you so much!  I'm still working through a few issues with my audio thread crashing but if I get into a roadblock there I'll try opening a new issue.  I appreciate the help :)


Interested in a Sharp memory display driver?

I'm looking for somewhere to share my Python code for driving Sharp Memory LCD - do you think it's a good idea to add support to luma.lcd and send you a pull request?

If you are willing to respond to bug reports, maintain it where possible, sounds good to me.
cc @rm-hull

Sounds good to me. It works on MicroPython devices when based on framebuf.FrameBuffer, but it could also very well run on a Raspberry Pi - yet there's no framebuf.Framebuffer analog there, so, luma.lcd sounds like a good alternative.


Shifts Activities - Typo for RequestCanceled?

The Office 365 Audit is returning activities for Microsoft Teams > Shifts > Request Cancelled as "RequestCancelled" yet the Docs page lists the activity as "RequestCanceled"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37e51e97-ff97-c5eb-6517-21ce9a563ca4
Version Independent ID: d3dc21b2-d90a-fbe7-8473-fff0b55feafb
Content: Search the audit log for events in Microsoft Teams - Microsoft Teams
Content Source: Teams/audit-log-events.md
Service: msteams
GitHub Login: @markjjo
Microsoft Alias: markjjo

@buildbod Thanks for heads up. I'll fix the documentation.

Fab. Thank you.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Mark Johnson - MSFT<EMAIL_ADDRESS>Sent: Monday, August 17, 2020 5:11:56 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Simon Denton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Shifts Activities - Typo for RequestCanceled? (#5590)
@buildbodhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbuildbod&data=01|01|simon.denton%40mottmac.com|2b704000c2574187ac8b08d842c8445a|a2bed0c459574f73b0c2a811407590fb|0&sdata=XAwbzVPY%2FcJIhRRqoy9fIJIj%2B3KXw6sKemu%2FZdTe%2F3Y%3D&reserved=0 Thanks for heads up. I'll fix the documentation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F5590%23issuecomment-674972230&data=01|01|simon.denton%40mottmac.com|2b704000c2574187ac8b08d842c8445a|a2bed0c459574f73b0c2a811407590fb|0&sdata=A9Bqp1YngOPhkf659pD9E0D3rapMgdP7HNIbOIIRkws%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADKCNOBHSHU7AU4PBQDLVCTSBFJEZANCNFSM4QBWJYKQ&data=01|01|simon.denton%40mottmac.com|2b704000c2574187ac8b08d842c8445a|a2bed0c459574f73b0c2a811407590fb|0&sdata=KHeY%2FoMb0%2BFpgDjjMA0TrpKlmqRoGoM8JzK5wXOpyJo%3D&reserved=0.


Can't save files in Chrome/Vivaldi

System: Windows 7, 64-bit
Browser: Chrome/Vivaldi (Firefox works fine!)
Plugins: Browsers are fresh installed, all plugins disabled
Server: FreeBSD 11, Apache 2.4, PHP 5.6
Codiad Version: 2.8.4 (fresh install from github)
Description:
When i open a file (.txt or .php for example) i cant save with CTRL+S or with the right bar (save/save all). CTRL+S opens a dialog to save the html-file of the editor locally on my desktop and "save" or "save all" do nothing. In Firefox, everything works fine.
Workaround:
When i close the file and click on "close & save file", it saves the file. Thats the only way to get it working in Chrome/Vivaldi.
Any ideas? Thanks.

Strange... I just tried this on my setup and was able to save just fine. Same Codiad version, same browser. The rest of my setup does differ to yours, though not in ways I would expect it to make a difference.  Win 10 x64, server is Windows 2016 Std, IIS 10, PHP 7.1.0 NTS x64.

Ok, doesn't work in Vivaldi, but worked fine in Chrome.

Weird, I'm using Firefox 59.0.1 and I'm getting this issue now as well. When I hit CTRL+S to save the Firefox "Save Page as HTML" dialogue box opens up and the opened script is not saved. It's like getPreventDefault() isn't running and Codiad is failing to intercept the keystrokes.
I was using Codiad last night and it was fine and now today it's borked. I don't believe Firefox updated in the last 24 hours.
Any ideas?

I fixed the issue in Firefox 59.0.1.
I'm a bit cautious on the web. In about:config I had "privacy.resistFingerprinting" set to True. When I disable this and set it to false, all of the keybinds work again. I'm not sure exactly why this is. I would love for the developer to chime in here and explain what might be going on. In the meantime however, it's a fix for now. I'll just NOT resistfingerprinting when I want to work.
Frustrating though.


Thumbnails on folders and files

Description of the new feature / enhancement
It used to be that folders and PNG files had thumbnails generated by Windows when you used Explorer or the standard file dialogs.  However, in recent builds of File Explorer, folders are just generic folders (which used to indicate the folder was empty) and PNG files are shown as a basic icon.
I'm hoping that can be added back in via PowerToys.
Scenario when this would be used?
When I'm in a folder containing images, photos, or videos, I tend to prefer the extra large icon size, but if only stock icons will be used, what's the point?
Supporting information
No response

What windows build are you on?
The dev channel currently has folder previews. File thumbnails should always work.
In the explorer options there is an option called "Always show icons, never thumbnails". Can you check if this option is off?
/needinfo

21H2 Build 22000.739  And yes, I already double checked that.

@WillPittenger Is this a question for PowerToys or for Windows / Explorer?
Have you tried the File preview function?

Well, I've been told it's something PowerToys can't fix.

I see what you mean. But if Aaron says it's on the way, I don't think we will be doing the same work.

folders with and without content


finch-jackson seems to be broken in 0.9.2

People keep reporting that on Gitter. Here is some of the reports: 1, 2.

Hope that it's fixed by #499.


when using FlameBlocProvider components seem to get created twice

Current bug behavior
I noticed that states are being emitted twice in the flame_bloc game demo here:
https://github.com/flame-engine/flame/blob/main/packages/flame_bloc/example/lib/src/game/game.dart
seems to be the result of these children getting added twice;
https://github.com/flame-engine/flame/blob/5b67b8f14ad4fdb38a249d0a41ecba49ba2fcc44/packages/flame_bloc/example/lib/src/game/game.dart#L53-L56
Expected behavior
only add the components to the tree once.
Steps to reproduce

I added some debugging to show the effect:
https://github.com/flame-engine/flame/compare/main...tolland:flame:double-added-bloc?expand=1
This shows that they are being added twice:
Performing hot restart...
Waiting for connection from debug service on Chrome...
Restarted application in 88ms.
creating PlayerComponent - 686141183
creating player controller - 142910962
creating game stats controller - 523610366
creating PlayerComponent - 776595899
creating player controller -<PHONE_NUMBER>
creating game stats controller - 692494327

same sort of thing on died/respawned
in PlayerDied in bloc handler
player respawned on GameStatus.respawn - 142910962
creating PlayerComponent - 290429235
player respawned on GameStatus.respawn -<PHONE_NUMBER>
creating PlayerComponent - 510917524
in PlayerRespawned in bloc handler
in PlayerRespawned in bloc handler

Flutter doctor output

[example] $ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on Fedora Linux 38 (Workstation Edition) 6.6.9-100.fc38.x86_64, locale
    en_GB.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2023.1)
[✓] IntelliJ IDEA Ultimate Edition (version 2022.2)
[✓] IntelliJ IDEA Community Edition (version 2023.3)
[✓] VS Code (version 1.85.1)
[✓] Connected device (3 available)
[✓] Network resources

• No issues found!

More environment information

Log information

Enter log information in this code block

More information

@erickzanardo does this sound familiar?

It does not. I have taken a look on the source to check if I could find any obvious reason on why this is happening, but I could not spot anything. Would need to do some debugging to understand.

it seems that the build method is called twice (on the chrome web platform I am testing with);
https://github.com/flame-engine/flame/blob/main/packages/flame_bloc/example/lib/src/game.dart#L52-L59
resulting in 2 FlameGames, the first one being removed, but the first still has the children with the listeners:
https://github.com/flame-engine/flame/blob/main/packages/flame_bloc/example/lib/src/game/components/player.dart#L22-L27

Most likely it is because of ide, try running from console. See here: https://github.com/flutter/flutter/issues/33566#issuecomment-884906844

Seems to be unrelated to Flame then; closing (feel free to reopen if I misinterpreted)


 In anticipation for the Mainnet launch, there is a need to develop a super all in one Defi based smart account wallet app with integrated advanced properties to easily onboard users to taiko ecosystem and to scale.
A SMART ACCOUNT WALLET: With the introduction of a smart account wallet, new and existing taiko users are able to utilize, leverage and tap into one of web 3 foremost defi wallets with seamless ease of transactions with security as fore-most priority.
SOME PROPOSED PROPERTIES OF THE SMART ACCOUNT WALLET:

IN-APP NATIVE BRIDGE: With in-app native bridge, users are easily able to get onboarded to the Taiko ecosystem Bridging serves as a the genesis of an ecosystem onboarding and with a native smart account wallet, the ease of transitioning from one blockchain to the taiko blockchain via the in-app supported feature will be seamless. It will also be of extra advantage if the time taken to bridge out of the Taiko blockchain using the Taiko in-app native bridge are without any prolonged latency.

IN-APP SWAP: In-app asset trading allows for a smooth defi experience in any ecosystem. With the introduction of the smart wallet in-app dex with a CLAMM model (concentrated liquidity)/enshrined liquidity, the swapping experience just got better.

SUPPORT FOR ACCOUNT ABSTRACTION: Defi security is still actively under-explored and with the introduction of native account abstraction by the smart wallet, it serve as a ease of connection between user's EOA and the Taiko smart wallet taking security as primacy. Users would be able to interact with to other defi protocols building on the taiko ecosystem without the fear of security breach.

HIGHLY SCALABLE WITH SUPPORT FOR EIP-4844 (PROTO DANK SHARDING): The primary goal of any L2 is to scale Ethereum, but with the already taiko proposed introduction of the scalable Ethereum standard EIP-4844, the cost of transaction execution just got easier. Integrating this Ethereum standard to the proposed Taiko smart account wallet causing it to hyperscale will be a good selling point to onboarding users to the taiko ecosystem.

The proposed Taiko smart account wallet with integrated features like; bridge, a Dex with concentrated liquidity, account abstraction support and hyper scalable with EIP-4844 will make Taiko stand out among close competitors as well as help onboard new as well as existing users to witness a slice of the Defi advancement in web3
Spam policy

[X] I verify that this issue is NOT SPAM and understand SPAM issues will be closed and reported to GitHub, resulting in ACCOUNT TERMINATION.

This is great

Suspected bot with chatgpt text. Closed.

Hello Korbinian, pls I saw my issue as closed based on suspicion of being
authored by chatgpt, just wanted to reiterate that it's not correct. I'm a
Web3 content writer with experience since 2014 and I have also written and
contributed to other projects. Been with Taiko since inception, you could
verify from Ben Taiko on discord, I'm sorry if the text construction tow in
line with chatgpt or a bot, but that's what happens when your contents are
placed well.
If you want, I could show you some of my medium publications and
contentions for similar projects
Thank you
On Thu, Feb 22, 2024, 7:10 PM Korbinian @.***> wrote:

Suspected bot with chatgpt text. Closed.
—
Reply to this email directly, view it on GitHub
https://github.com/taikoxyz/taiko-mono/issues/15998#issuecomment-1959997844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATJUIMAURS4OW2AEZSM2I6DYU6C3FAVCNFSM6AAAAABDUZBELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHE4TOOBUGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello Korbinian, pls I saw my issue as closed based on suspicion of being authored by chatgpt, just wanted to reiterate that it's not correct. I'm a Web3 content writer with experience since 2014 and I have also written and contributed to other projects. Been with Taiko since inception, you could verify from Ben Taiko on discord, I'm sorry if the text construction tow in line with chatgpt or a bot, but that's what happens when your contents are placed well. If you want, I could show you some of my medium publications and contentions for similar projects Thank you
…
On Thu, Feb 22, 2024, 7:10 PM Korbinian @.> wrote: Suspected bot with chatgpt text. Closed. — Reply to this email directly, view it on GitHub <#15998 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATJUIMAURS4OW2AEZSM2I6DYU6C3FAVCNFSM6AAAAABDUZBELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHE4TOOBUGQ . You are receiving this because you authored the thread.Message ID: @.>

Go and develop the smart account wallet app, and apply for the grants. No need to spam our github, especially with capslock on.


Small Typo in HandlerFunctions Syntax

[Enter feedback here]
Syntax has a typo, should have closing quote and parens.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44ac3c49-5fb3-f8b7-bbf0-d26302d10909
Version Independent ID: a476e9b7-49a7-3bc4-dd52-50557de39b5f
Content: HandlerFunctions Attribute - Business Central
Content Source: dev-itpro/developer/methods/devenv-handlerfunctions-attribute.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for noticing this, it will be fixed with the next refresh.


Fix #1314, Remove Unused Error Codes

Describe the contribution
Fixes #1314
Removes unused error codes.
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

CCB:2021-04-14 - APPROVED


Add a new DateTimeType to distinguish on the wire date values

Before, DateTimes were just stored as normal utf8 strings, and the
receiver could not distinguish them from any other kind of string. Now
they are marked as datetimes, and ConvertAssign has the mechanics to
translate them to the appropriate time.Time and integer types.
This will be useful both for direct use and for using this as a layer between a golang database connection and a python DBAPI connector.

I''m not sure a new wire type is warranted. The upstream version seems substantially simpler.
https://github.com/youtube/vitess/blob/master/go/sqltypes/sqltypes.go


Fix unit test warning

To prevent such a warning during unit test execution:
/usr/lib64/python3.8/multiprocessing/pool.py:265: ResourceWarning: unclosed running multiprocessing pool <multiprocessing.pool.ThreadPool state=RUN pool_size=10>
  _warn(f"unclosed running multiprocessing pool {self!r}",
ResourceWarning: Enable tracemalloc to get the object allocation traceback

/lgtm


Terrain painting locked after switch from Texture to Heightmap painting

Happens with EXTENDED_16 splatmap mode.
Steps to reproduce:

Paint textures
Switch to any heightmap tool and paint
Change back to texture painting

Already found the culprit. The Error happens when using the EXTENDED_16 Paint Mode and it is due to an internal mutex in the TerrainTool class staying in locked state.
Added into the next release.


[WIP] Structured events (NLog 4.5 - alpha5)

see https://github.com/NLog/NLog/issues/2077
supersedes https://github.com/NLog/NLog/pull/1951

Why not like this:
TypeCode objTypeCode = Convert.GetTypeCode(value);
if (objTypeCode == TypeCode.Object && inJson5Mode)
{
   try
   {
      return new ObjectSerializer(this).SerializeObjectProperties(value, objectsInPath, depth, format);
   }
   catch
   {
      return null;
   }
}
else
{
   bool encodeStringValue;
   string escapeXmlString = JsonStringEncode(value, objTypeCode, escapeUnicode, out encodeStringValue);
   if (escapeXmlString != null && encodeStringValue)
      return string.Concat("\"", escapeXmlString, "\"");
   else
      return escapeXmlString;
}

yes, I will first do  #2128  and then this.
Currently this feature is too big for me to work on (as you can see....). So first the smaller steps.

SonarQube analysis reported 3 issues

 1 critical
 1 major
 1 info

Watch the comments in this conversation to review them.

@snakefoot I change the parse and render of the message template to Logger (after your suggestion, as far as I remember well ;)), but this seems to be a bit problematic - when I change the Message of LogeventInfo, I cannot (re)render the template.
I think inside logEventInfo was maybe the best place, as there is also an preformMessage there.
Please your thoughts
Broke also other stuff, just ignore it ;)

superseded by https://github.com/NLog/NLog/pull/2208


envs configuration (1)

Changing envs configuration away from the comma-separated variety. This issue is to catalog all of the possible environments and what needs to be updated to make it work.

Platform
development
production
setter

server
server-development
server-production
can-ssr

browser window
window-development
window-production
steal

build
build-development
---
steal-tools

web worker
worker-development
worker-production
steal

isEnv / isPlatform
to make this easier we should create helpers on System that check for the platform/env:
System.env = "server-production";

System.isEnv("development"); // -> false
System.isEnv("production"); // -> true

System.isPlatform("server"); // -> true

These are project-specific issues needed to complete this task:

[ ] - StealJS: https://github.com/stealjs/steal/issues/454
[ ] - StealTools: https://github.com/stealjs/steal-tools/issues/295
[ ] -

This is done.

I think there are still some issues here, will take a look next week.


IP Transfer is only for IPv4

All linode servers some with both IPv4 and IPv6 addresses. The IP Transfer tool can only swap the IPv4 address between linode servers and not the IPv6 address.
This is a serious issue, it makes the IP Transfer tool rather useless.
Because the admin would need to make heavy modifications to DNS records and other things like local address assignments, deployment and firewall changes, so on and so forth.
If there is a network/design limitation and you can't swap IPv6 addresses, at least add a big red warning on top of the IP Transfer option to warn users that it does half the job its supposed to do. Or rename it to "IPv4 Transfer" :)

This is my biggest frustration with the Linode platform, and it’s shared by others on the community site - such as:
https://www.linode.com/community/questions/19938/how-do-i-swap-ipv6-addresses-between-linodes
I suspect it is some technical limitation as Digital Ocean also only offers “hit swappable” v4 addresses - but I have no idea what.
Any Linode that uses IPv6 for public services (which let’s face it, you should these days) cannot be swapped out as easy as the IP Transfer suggests - IPv6 addresses still need to be handled manually, either by Linode or through DNS.
I would love to understand why this seemingly small thing cannot be done!

Hi @robo2bobo , thanks for sharing this feedback! It's currently not possible to transfer a SLAAC IPv6 address due to the way MAC addresses are assigned to each Linode. With a range of IPv6 addresses, it's possible to manually hotswap, though ranges must be requested from Support. I agree we can add some clarity to the limitations of this feature in Cloud. I'll keep this open and provide an update when the work to update our messaging has been completed.

Its important to mention 2 things:

the IP Transfer tool is not for IPv6 migration
an alternative method is to use backup snapshots and restore to another linode server

I can picture a situation with a tired admin, rushing to use the IP transfer tool and then later on, wondering why half the traffic is still going to the old server...
communication is key :+1:
thank you!

IPv6 transfer is being released in the upcoming release


Contraint change in fit.py

I changed a few lines and reran t_ex6_1.py and it worked just fine.

great - thanks for fixing this.

Reviewed. To avoid multiple commits to accomplish this small change, I suggest we close this PR without merging it, and that @mjburton11 opens a new PR with his version of the changes I suggested.


IoTHub DPS link is misleading

Currently, the link at the bottom of the TPM Attestation page has the following description: Get started using auto-provisioning using the SDKs to take care of the flow.
However, the link provided  uses the portal and not the SDKs to auto-provision.
On a side note, I can't seem to find the documentation for using the Python SDK (or an ARM template) to create a device using symmetric key and individual enrollment in DPS anywhere. It would be great if you can let me know if such a thing exists (and point me to it if it does).
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af124669-06d7-a0b0-da60-78081380af4c
Version Independent ID: 578a6172-e018-af2b-ce40-d0e3d24026aa
Content: Azure IoT Hub Device Provisioning Service - TPM Attestation
Content Source: articles/iot-dps/concepts-tpm-attestation.md
Service: iot-dps
GitHub Login: @nberdy
Microsoft Alias: nberdy

Hello @swathipil
Our SME will review your Feedback.

@swathipil Thank you for the feedback.  Please accept my apology that no one has contacted you regarding this until now.
Regarding your question about auto-provisioning with Python, please look at the following samples link and see if this provides what you need.

DPS Python samples - These samples along with this quickstart for python demonstrate device code showing how a device can be provisioned to an IoT Hub using Python.

@swathipil If you do need to create individual symmetric key enrollments with Python, I tried the older depreciated library as mentioned in the TPM python sample. I changed the code to create a symmetric key individual enrollment and this did work.  You can review my code changes below
from provisioningserviceclient import ProvisioningServiceClient
from provisioningserviceclient.models import IndividualEnrollment, AttestationMechanism
from provisioningserviceclient.protocol.models import SymmetricKeyAttestation

CONNECTION_STRING = "Enter your DPS connection string"
PRIMARY_KEY = "Add a valid key"
SECONDARY_KEY = "Add a valid key"
REGISTRATION_ID = "pythonenrollmentexample"

def main():
    print ( "Starting individual enrollment..." )

    psc = ProvisioningServiceClient.create_from_connection_string(CONNECTION_STRING)

    symAtt = SymmetricKeyAttestation(primary_key=PRIMARY_KEY, secondary_key=SECONDARY_KEY)
    att = AttestationMechanism(type="symmetricKey", symmetric_key=symAtt)
    ie = IndividualEnrollment.create(REGISTRATION_ID, att)

    ie = psc.create_or_update(ie)

    print ( "Individual enrollment successful." )

if __name__ == '__main__':
    main()

#reassign wesmc7777


Bad value for

Several language has bad value for <string name="resouces_language"> and <string name="resouces_country">
-> Those language are not visible in the choose language screen.
It does not prevent Riot from using this language if it is the language set on the phone settings
It should be fixed on Weblate
The typos on the resource names may be fixed as well

typo is fixed

String on Weblate has been updated for:
Bosnian (bs-BA)
Czeck (cs-CZ)
Gallician (gl-ES)
Ukrainian (uk-UA)

All those languages are not listed in the language list in the settings \o/


Not make fsspec hard dependency

...but it is needed in bag, array and dataframe

[ ] Tests added / passed
[x] Passes black dask / flake8 dask

Just partd again

Do we really need fsspec for dask.array? Not that I’m strongly opposed, but it’s pretty common not to use any of dask’s builtin IO with dask.array. The most popular storage formats are all external, likely Zarr, HDF5 and netCDF.

dask.array does indeed use fsspec, but only for zarr (to create the mappers across whichever backend). Since you can also specify the mapper directly, I've made it optional.


I can’t buy a board :(

I tried to buy a hoverboard but it failed with an error :(

Do you have a Replay for this?

Yes, here: https://app.replay.io/recording/overboard-d--7eab1306-2e20-43a7-a96e-107d2260ae24?point=18497557559522272877852027567212814&time=7967&focusRegion=eyJiZWdpbiI6eyJwb2ludCI6IjAiLCJ0aW1lIjowfSwiZW5kIjp7InBvaW50IjoiMzExNTM3ODExNTI3MzI4MzUxNTgyMTEwNTk1Mzg0NjA2NzIiLCJ0aW1lIjoxMzQxNn19


Can't find Active storage.

Hi!
Sorry to bother yo but I can't get filepond-rails to work. I made a new rails app with import map, installed active-storage and migrated. The app is very simple, just a user with an avatar. I did this because in my previous app I was getting the same error and thought maybe it was something else in the app.
Btw, you'll notice I'm not getting Filepond.
But I always get this error:

Any ideas? Thanks!

Ok, I figured that one out but now I'm getting this error:
Uncaught SyntaxError: The requested module '@rails/activestorage' does not provide an export named 'DirectUpload' (at filepond-rails-c4a13b2e63a9b4126d750b9d88ff5ddb3b86846e1737b48e944338435a7f7d9b.js:1:10)


Backport commit to 5.0 branch.

Can we get this commit backported to 5.0? It fixes a bug with groups being overset when they should have been merged: https://github.com/laravel/framework/commit/2925e486b4c498555782edfb506a727dd5707726 and corresponding CS fix: https://github.com/laravel/framework/commit/e3d3043c90dead1fdeb95401c7dc65af38d4f7ad

No, sorry.


Cannot add Docker Host via TCP

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
I cannot add a docker host which is accessible via tcp 2375 to uptimekuma.
Test button stucks for unlimited time.

Access to the port is working.

👟 Reproduction steps
Allow acccess to 2375 on docker host and iptables
Add host to uptimekuma
👀 Expected behavior
Get a success connection.
😓 Actual Behavior
Test/Save button stucks in loading.
🐻 Uptime-Kuma Version
1.18.0
💻 Operating System and Arch
Ubuntu and Docker
🌐 Browser
Chrome
🐋 Docker Version
Monitoring docker: 20.10.18  |  Docker running uptimekuma: 19.03.13
🟩 NodeJS Version
No response
📝 Relevant log output
no output

Cannot reproduce.
Please test the connection inside Uptime Kuma container.
https://github.com/louislam/uptime-kuma/wiki/Troubleshooting


fix(protocol-designer): fix long step name  and step details layout issue

fixes RQA-3355

Overview

Fixing layout issues in StepFormToolbox, StepContainer, and StepSummary when step names and step details are too long, causing the step icon to shrink, the step name text to go off-screen, and the step details text to exceed the window size.
Refer to the ticket for details on the current layout issues and the expected design.
Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@syao1226 I just merged my PR that includes line clamp style in atoms into edge.
import LINE_CLAMP_TEXT_STYLE from atoms and add css={LINE_CLAMP_TEXT_STYLE(max_lines)} to a tag.


Add ESLint rule: no-unused-expressions

We could add this rule with no changes to the code if we also added the "allowShortCircuit" option. However, we have a mixture of:
a = a || default;

And:
a || (a = default)

Only the first option avoids the "unused expression", and I personally find it more readable, so I've proposed the standardization.

Let's leave this one be. I prefer our style.


Dart compiler exits when running flutter test

Exception: the Dart compiler exited unexpectedly.
  package:flutter_tools/src/base/common.dart 10:3  throwToolExit
  package:flutter_tools/src/compile.dart 778:9     DefaultResidentCompiler._compile.<fn>
  dart:async/zone.dart 1436:47                     _rootRunUnary
  dart:async/zone.dart 1335:19                     _CustomZone.runUnary

Sometimes I was getting fast scrolling errors sometthing about Dart but the output window of VSCode would fill up and keep scrolling with the same-ish error.  And now this.  What is happening?
I am on Ubuntu 20.04 Dart SDK version: 2.14.2 (stable) (Wed Sep 15 12:32:06 2021 +0200) on "linux_x64"

This looks like an error reported by flutter_tools/src/compile.dart after the dart compiler exits with an error number greater than zero. That can have any number of causes, it's impossible to tell why without further information.
If you can capture any of the other error messages, we might be able to figure out more.

(base) nobu@nobu-IdeaPad-3-15IIL05:/media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app$ flutter test
00:03 +0: loading /media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/dummy_test.dart                     lib/views/coupons_screen/coupons_screen.dart:10:8: Error: Error when reading
'repositories/fastapi_providers.dart': No such file or directory
import '../../../repositories/fastapi_providers.dart';
       ^
lib/views/coupons_screen/coupons_screen.dart:11:8: Error: Error when reading 'models/data_layer.dart': No
such file or directory
import '../../../models/data_layer.dart';
       ^
lib/views/details_screen/details_screen.dart:11:8: Error: Error when reading 'models/data_layer.dart': No
such file or directory
import '../../../models/data_layer.dart';
       ^
lib/views/coupons_screen/coupons_screen.dart:12:8: Error: Error when reading 'providers.dart': No such file
or directory
import '../../../providers.dart';
       ^
lib/views/details_screen/details_screen.dart:12:8: Error: Error when reading 'providers.dart': No such file
or directory
import '../../../providers.dart';
       ^
lib/controllers/controller.dart:8:8: Error: Error when reading 'type_enums/enum_exports.dart': No such file
or directory
import '../../type_enums/enum_exports.dart';
       ^
lib/repositories/shared_prefs_repo.dart:3:8: Error: Error when reading 'models/data_layer.dart': No such
file or directory
import '../../models/data_layer.dart';
       ^
00:04 +2: ... /media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/golden_widget_test.dart                 lib/views/coupons_screen/coupons_screen.dart:44:8: Error: Type 'Coupon' not found.
  List<Coupon> combineOldNewCoupons(
       ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:45:32: Error: Type 'Coupon' not found.
      Response? response, List<Coupon> oldCoupons) {
                               ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:72:3: Error: Type 'Coupon' not found.
  Coupon convertJsonToCoupon(Map<String, dynamic> newCoupon) =>
  ^^^^^^
lib/views/details_screen/details_screen.dart:44:3: Error: Type 'Coupon' not found.
  Coupon? getThisCouponFromState(List<Coupon> couponsList) {
  ^^^^^^
lib/views/details_screen/details_screen.dart:44:39: Error: Type 'Coupon' not found.
  Coupon? getThisCouponFromState(List<Coupon> couponsList) {
                                      ^^^^^^
lib/controllers/controller.dart:40:29: Error: Type 'CurrentScreen' not found.
  void updateCurrentScreen({CurrentScreen? screen}) {
                            ^^^^^^^^^^^^^
lib/repositories/shared_prefs_repo.dart:10:26: Error: Type 'User' not found.
  Future<void>? saveUser(User user) async {
                         ^^^^
00:05 +2: ... /media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/golden_widget_test.dart                 lib/views/coupons_screen/coupons_screen.dart:45:32: Error: 'Coupon' isn't a type.
      Response? response, List<Coupon> oldCoupons) {
                               ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:56:10: Error: 'Coupon' isn't a type.
    List<Coupon> combinedCoupons = [...oldCoupons];
         ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:58:12: Error: 'Coupon' isn't a type.
      for (Coupon oldC in oldCoupons) {
           ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:68:38: Error: The getter 'couponId' isn't defined for the class
'Object?'.
 - 'Object' is from 'dart:core'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'couponId'.
    combinedCoupons.sort((a, b) => a.couponId.compareTo(b.couponId));
                                     ^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:68:59: Error: The getter 'couponId' isn't defined for the class
'Object?'.
 - 'Object' is from 'dart:core'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'couponId'.
    combinedCoupons.sort((a, b) => a.couponId.compareTo(b.couponId));
                                                          ^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:73:7: Error: The getter 'Coupon' isn't defined for the class
'_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'Coupon'.
      Coupon.fromJson(newCoupon);
      ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:109:16: Error: 'Coupon' isn't a type.
          List<Coupon> coupons = combineOldNewCoupons(response, oldCoupons);
               ^^^^^^
lib/views/coupons_screen/coupons_screen.dart:78:15: Error: The getter 'userProvider' isn't defined for the
class '_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
        .read(userProvider.notifier)
              ^^^^^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:80:27: Error: The getter 'userProvider' isn't defined for the
class '_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
    final user = ref.read(userProvider.notifier).state;
                          ^^^^^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:89:32: Error: The method 'fastApiRespJsonProvider' isn't
defined for the class '_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing method, or defining a method named
'fastApiRespJsonProvider'.
    final response = ref.watch(fastApiRespJsonProvider(path));
                               ^^^^^^^^^^^^^^^^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:111:20: Error: The getter 'userProvider' isn't defined for the
class '_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
          ref.read(userProvider.notifier).updateUserCoupons(coupons);
                   ^^^^^^^^^^^^
lib/views/coupons_screen/coupons_screen.dart:248:15: Error: The getter 'userProvider' isn't defined for the
class '_CouponsScreenState'.
 - '_CouponsScreenState' is from 'lib/views/coupons_screen/coupons_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
        .read(userProvider.notifier)
              ^^^^^^^^^^^^
lib/views/details_screen/details_screen.dart:38:14: Error: The getter 'userProvider' isn't defined for the
class '_DetailsScreenState'.
 - '_DetailsScreenState' is from 'lib/views/details_screen/details_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
    ref.read(userProvider.notifier).updateCoupon(targetCouponId: couponId);
             ^^^^^^^^^^^^
lib/views/details_screen/details_screen.dart:39:14: Error: The getter 'userProvider' isn't defined for the
class '_DetailsScreenState'.
 - '_DetailsScreenState' is from 'lib/views/details_screen/details_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
    ref.read(userProvider.notifier).updateUserOnServer();
             ^^^^^^^^^^^^
lib/views/details_screen/details_screen.dart:44:39: Error: 'Coupon' isn't a type.
  Coupon? getThisCouponFromState(List<Coupon> couponsList) {
                                      ^^^^^^
lib/views/details_screen/details_screen.dart:45:10: Error: 'Coupon' isn't a type.
    for (Coupon c in couponsList) {
         ^^^^^^
lib/views/details_screen/details_screen.dart:54:28: Error: The getter 'userProvider' isn't defined for the
class '_DetailsScreenState'.
 - '_DetailsScreenState' is from 'lib/views/details_screen/details_screen.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named
'userProvider'.
    final user = ref.watch(userProvider.notifier).state;
                           ^^^^^^^^^^^^
lib/views/first_screen/first_screen.dart:28:14: Error: 'userProvider' is imported from both
'package:coupon_app/providers.dart' and 'lib/providers.dart'.
    ref.read(userProvider.notifier).initializeUser(user);
             ^^^^^^^^^^^^
lib/views/first_screen/first_screen.dart:30:15: Error: 'userProvider' is imported from both
'package:coupon_app/providers.dart' and 'lib/providers.dart'.
        .read(userProvider.notifier)
              ^^^^^^^^^^^^
lib/views/first_screen/first_screen.dart:32:32: Error: 'userProvider' is imported from both
'package:coupon_app/providers.dart' and 'lib/providers.dart'.
    final checkUser = ref.read(userProvider.notifier).state;
                               ^^^^^^^^^^^^
lib/controllers/controller.dart:34:38: Error: The argument type 'User/*1*/' can't be assigned to the
parameter type 'User/*2*/'.
 - 'User/*1*/' is from 'lib/models/user.dart'.
 - 'User/*2*/' is from 'package:coupon_app/models/user.dart' ('lib/models/user.dart').
      sharedPreferencesRepo.saveUser(user);
                                     ^
lib/controllers/controller.dart:40:29: Error: 'CurrentScreen' isn't a type.
  void updateCurrentScreen({CurrentScreen? screen}) {
                            ^^^^^^^^^^^^^
lib/repositories/shared_prefs_repo.dart:10:26: Error: 'User' isn't a type.
  Future<void>? saveUser(User user) async {
                         ^^^^
lib/repositories/shared_prefs_repo.dart:31:14: Error: The getter 'User' isn't defined for the class
'SharedPreferencesRepo'.
 - 'SharedPreferencesRepo' is from 'lib/repositories/shared_prefs_repo.dart'.
Try correcting the name to the name of an existing getter, or defining a getter or field named 'User'.
      return User.fromJson(userJson);
             ^^^^
00:08 +2 -1: loading /media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/golden_widget_test.dart [E]
  Failed to load "/media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/golden_widget_test.dart": Compilation failed for testPath=/media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app/test/golden_widget_test.dart
00:08 +2 -1: Some tests failed.
(base) nobu@nobu-IdeaPad-3-15IIL05:/media/nobu/NTFSUbuWin/1_TAP/_Github/coupon_app$

All of those errors are wrong.  My app runs and I have zero red squigglies anywhere in my app code (VSCode).  Android Studio throws same errors. I will try to capture those scrolling errors I mentioned. when I see them next..  Is there a workaround for the time being?  Ie. downgrade Flutter and Dart?  I am using the newest Flutter 2.5.1 or something and I know the latest Dart SDK comes with it.

If you have time to try it out in my full app, here it is: https://drive.google.com/drive/folders/1DoUbj3S3bhkUKS8CIRuBctDp0lbIi5NV?usp=sharing  Running flutter test from the project root leads to the original errors above.

Does not having dart in my PATH have any relevance?
(base) nobu@nobu-IdeaPad-3-15IIL05:~$ env | grep PATH
MANDATORY_PATH=/usr/share/gconf/ubuntu.mandatory.path
WINDOWPATH=2
DEFAULTS_PATH=/usr/share/gconf/ubuntu.default.path
PATH=/home/nobu/.rbenv/shims:/home/nobu/.rbenv/bin:/home/nobu/.rbenv/shims:/home/nobu/.kusanagi/bin:/home/nobu/anaconda3/bin:/home/nobu/anaconda3/condabin:/home/nobu/.rbenv/shims:/home/nobu/.rbenv/shims:/home/nobu/.rbenv/bin:/home/nobu/.poetry/bin:/home/nobu/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/local/go/bin:/home/nobu/go/bin:/usr/local/go/bin:/home/nobu/go/bin:/usr/local/go/bin:/home/nobu/go/bin
GOPATH=/home/nobu/go

I removed golden_toolkit package and it is fine now.
My former golden test file under folder test

import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter/material.dart';
import 'package:golden_toolkit/golden_toolkit.dart';
import '../lib/views/views_layer.dart';
import '../lib/dummy_data/dummy_user.dart' as dummy;
import '../lib/models/data_layer.dart';

final User mockUser = User(userId: -100, name: 'mock', email: "mock@mock.com");
final User copyUser = dummy.dummyUser.copyWith(userId: -100);
void main() {
  testGoldens('FirstScreen has DeathStar', (WidgetTester tester) async {
    await tester.pumpWidget(FirstScreen(user: mockUser));
    await screenMatchesGolden(tester, 'firstscreen_deathstar');
  });
}

and my pubspec.yaml
name: coupon_app
description: A new Flutter project.

# The following line prevents the package from being accidentally published to
# pub.dev using `pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

# The following defines the version and build number for your application.
# A version number is three numbers separated by dots, like 1.2.43
# followed by an optional build number separated by a +.
# Both the version and the builder number may be overridden in flutter
# build by specifying --build-name and --build-number, respectively.
# In Android, build-name is used as versionName while build-number used as versionCode.
# Read more about Android versioning at https://developer.android.com/studio/publish/versioning
# In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion.
# Read more about iOS versioning at
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
version: 1.0.1+2

environment:
  sdk: ">=2.12.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  flutter_riverpod: ^1.0.0-dev.7
  flutter_hooks: ^0.18.0
  hooks_riverpod: ^1.0.0-dev.7

  uuid:
  http:

  sqflite: ^2.0.0+4
  path:

  #json_annotation: ^4.0.1
  #freezed: ^0.14.0
  freezed_annotation: ^0.14.3
  #json_serializable: ^5.0.0
  built_value:
  shared_preferences: 2.0.7
  #golden_toolkit: ^0.10.0

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.2
  dio: ^4.0.0
  enum_to_string: ^2.0.1

dev_dependencies:

  freezed: ^0.14.5
  #https://github.com/rrousselGit/freezed/issues/86#issuecomment-593936459
  json_serializable: ^5.0.0
    #options:
      #explicit_to_json: true
  build_runner: #^1.11.0
  built_value_generator:
  mockito: ^5.0.16
  test: ^1.17.10
  flutter_driver:
    sdk: flutter
  flutter_test:
    sdk: flutter
  integration_test:
    sdk: flutter

#dependency_overrides:
  #meta: ^1.3.0

# For information on the generic Dart part of this file, see the
# following page: https://dart.dev/tools/pub/pubspec

# The following section is specific to Flutter.
flutter:

  # The following line ensures that the Material Icons font is
  # included with your application, so that you can use the icons in
  # the material Icons class.
  uses-material-design: true

  # To add assets to your application, add an assets section, like this:
  assets:
    - assets/images/no-img.png
    - assets/images/starwars/
    - assets/images/coupons/
  #   - images/a_dot_ham.jpeg

  # An image asset can refer to one or more resolution-specific "variants", see
  # https://flutter.dev/assets-and-images/#resolution-aware.

  # For details regarding adding assets from package dependencies, see
  # https://flutter.dev/assets-and-images/#from-packages

  # To add custom fonts to your application, add a fonts section here,
  # in this "flutter" section. Each entry in this list should have a
  # "family" key with the font family name, and a "fonts" key with a
  # list giving the asset and other descriptors for the font. For
  # example:
  # fonts:
  #   - family: Schyler
  #     fonts:
  #       - asset: fonts/Schyler-Regular.ttf
  #       - asset: fonts/Schyler-Italic.ttf
  #         style: italic
  #   - family: Trajan Pro
  #     fonts:
  #       - asset: fonts/TrajanPro.ttf
  #       - asset: fonts/TrajanPro_Bold.ttf
  #         weight: 700
  #
  # For details regarding fonts from package dependencies,
  # see https://flutter.dev/custom-fonts/#from-packages

Why does adding one package and writing one additional test cause this?  I do remember writing that golden test I had a bunch of red squigglies telling me I can't use User because User is imported from some_file and some_file and I have seen this error before but in this case it was the same two files so I changed one import that started with package:coupon_app to .../.../.../lib/models/data_layer.dart.  I'm not sure why Flutter or Dart extension defaults to the pacakge:app_name style import but could that be a problem because it certainly does cause red squigglies.

It was an import issue. Use fully qualified and not relative.


tooltip title formatter

Hi G2 Team,
I'm recently struggling to change the title value of the tooltip. The tooltip only select the value of one axis and can't be (or at least I didn't find a way to) customized.

As you can see I change the format of the x axis but the tooltip still show the raw value of the x axis.
Could we have a formatter property like the one for axis but for the tooltip title ?
Thank you.

hi, you can declare formatter callback function for your tooltip title's data attribute, as follows：
chart.source(data,{ // 列定义
  'type': {
    // this will affect legend、tooltip and axis.
    formatter: function (value) {
      if (value == 1) {
        return '警告';
      }
      return '错误';
    }
  }
});

Hi simaQ,
I tried to integrate the piece of code you gave me, but still it doesn't work. If I put a console.log within the callback function, it's never called.

Oh okay my bad. I didn't understand that here 'type' actually means the axis name.
In my dataset my axis were named 'x' and 'y'.
Everything is working perfectly, thank you very much. :-)

Now this prop is removed in v2, correct? How can I achieve the same behaviour?

chart.scale('type', {
    // this will affect legend、tooltip and axis.
    formatter: function (value) {
      if (value == 1) {
        return '警告';
      }
      return '错误';
    }
});

@Me-Momo sorry, it seems that I am talking about g2plot, which is a higher abstraction level of g2, correct?
Anyway, this behaviour does not allow you to have one axis values to be dependent on the others, I mean:
chart.scale('type', {
    // this will affect legend、tooltip and axis.
   // I can't do smth like: (value == 1 && date == X), due to I do not have date value
    formatter: function (value) {
      if (value == 1) {
        return '警告';
      }
      return '错误';
    }
});

Thanks!

the scale formatter will affect legend, tooltip and axis. It can't only format the tooltip or calculate with other field data。
In G2 4.x，TooltipCfg.title set a string will make some format but not flexible, I hope a function type so.


Select model run

When comparing model data, it is quite useful (and something in existing visualisation websites) to be able to select a model from a limited recent set of model runs.
This should be easy to accomplish in the current structure, and should just require an reload of the datasets dict which is then passed to the plot objects.
When selecting a new model run, the data time should remain the same if possible. So if the current forecast time is 20180312T0000Z viewing data for 20180314T0000Z (lead time T+48), if we select model run  20180312T0000Z, the data time should still be 20180314T0000Z (lead time T+36), if possible.

This issue has now been resolved through pull request #57, so closing issue.


Authentication (401) error on getUser service

Problem

After first getUser call from user service, every next call is giving this error.

Solution

Once we have the user detail we don't need to call the service again till next login.
Using set instead of append for adding header.

@aslakknutsen @nimishamukherjee


OTST_TS_OB_MULTI_PAX_1

Scenario with an offer request based on a trip specification for two passengers, booking request based on the response of the offer response. The booking will be fulfilled with status confirmed. The trip is based on a single outbound leg
Scenario

Generate and send a post offer request with a trip specification for two anonymousPassengers aged 30 and 40
Generate and send a post booking request
Generate and send a post fulfillment request
Generate and send a get booking request

Example data
{
	"type": " OTST_TS_OB_MULTI_PAX_1",
	"currency": "EUR",
	"service_class": "STANDARD",
	"travel_class": "SECOND",
	"legs": [
		{
			"origin": "urn:uic:stn:8400058",
			"destination": "urn:uic:stn:8727100",
			"start_datetime": "%TRIP_DATE%T07:00:00+02:00",
			"end_datetime": "%TRIP_DATE%T10:20:00+02:00",
			"product_category_ref": "",
			"product_category_name": "",
			"product_category_short_name": "",
			"vehicle_number": "OSDM_101",
			"operator_code": "urn:uic:rics:1"
		}
	],
	“Passengers”: [
		{
			“externalRef”: “PAX1”,
			"type": "PERSON",
			"age": "40"
		},
		{
			“externalRef”: “PAX2”,
			"type": "PERSON",
			"age": "30"
		}
	]
}

Suggested Validations per step
1.

Two anonymousPassengerSpecifications returned
One anonymousPassengerSpecification has externalRef = “PAX1”and age “40”, the other one has externalRef = “PAX2” and age “30”
One offers with two admissions with offerMode = “INDIVIDUAL”
Each admission has a reference to different anonymousPassengerSpecifications
One trip with the specified leg is returned

Two passengers returned
One passenger has externalRef = “PAX1”and age “40”, the other one has externalRef = “PAX2” and age “30”
Alt1: One bookedOffer with two admissions with offerMode = “INDIVIDUAL” and
appliedPassengers.type = “ADULT”
Alt2: Two bookedOffers with one admission with offerMode = “INDIVIDUAL” and
appliedPassengers.type = “ADULT”
One trip with one leg is returned
bookedOffers.admissions.tripCoverage.coveredTripId refers to the delivered trip
bookings.provisionalPrice = sum (bookedOffers.admissios.price.amount)
bookings.createdOn is set
confirmationTimeLimit > now()
status on all offerPart is “PREBOOKED”

two fulfillments created (one for each passenger)
controlNumber is set in each fulfillmet with different values
fulfilments.bookingRefs points out the bookingId from stage 2
fulfilments.bookingParts points out two different admissions (one for each passenger)

Two passengers returned
One passenger has externalRef = “PAX1”and age “40”, the other one has externalRef = “PAX2” and age “30”
Alt1: One bookedOffer with two admissions with offerMode = “INDIVIDUAL”
Alt2: Two bookedOffers with one admission with offerMode = “INDIVIDUAL”
One trip with one leg is returned
bookedOffers.admissions.tripCoverage.coveredTripId refers to the delivered trip
bookings.provisionalPrice = 0
bookings.confirmedPrice = sum (bookedOffers.admissios.price.amount)
bookings.createdOn is set
status on all offerPart is “FULFILLED”
fulfilments are provided with controlNumber
all fulfilment.status = “FULFILLED”

Put in priority 2 as the main priority is to deliver the scope of functionnalities on a 1 PAX_1 Leg type of offer first before managing more complex cases


Scope for 13 Nov 2020

Can we create a checklist of items that would be developed for the next internal build?

A list of issues that can be considered:

[ ] https://github.com/AlphaWallet/alpha-wallet-android/issues/1237

[ ] https://github.com/AlphaWallet/alpha-wallet-android/issues/1659

[ ] https://github.com/AlphaWallet/alpha-wallet-android/issues/1642

[ ] https://github.com/AlphaWallet/alpha-wallet-android/issues/1617

Any updates @JamesSmartCell

No build for 13 Nov. Next will be for 27 Nov


[directxmath] port update to fix include path in pkgconfig

The include path in the generated pkgconfig was incorrect. This updates the port to use the version upstream with this fix.

Upstream fix can be seen here: https://github.com/microsoft/DirectXMath/pull/188

The version date matches the NuGet package and GitHub releases that have the idential header files. The only differenence between feb2024 and feb2024b is the one CMakeLists.txt fix to pkgconfig. There is no functional difference at all, which is why I went with a port-version update instead.


Improve conceiling with NERDTree: replace closing bracket by space

This also adds an augroup around it.
Ref: https://github.com/ryanoasis/vim-webdevicons/commit/203779dbbcc1e64ac21dbf454f26c92e7a079445#commitcomment-11019083

I see thanks but why is closing bracket a space but opening bracket is nothing?

It is meant to get a space in there.
IIRC this looks much better.


Change the detect logic of circular dependency

Sometimes, we need A injected to B, A injected to C and B injected to C. But it's not a circular dependency situation.

Hi. I finally got time to review PR. I understand the problem, but this PR doesn't seem to solve it: it just adds a counter and, basically, if circular dependency happens 1 - it will allow it. Some other approach needs to be selected here.

It since if circular dependency happens, it will be more than once

Hi. I finally got time to review PR. I understand the problem, but this PR doesn't seem to solve it: it just adds a counter and, basically, if circular dependency happens once - it will allow it. Some other approach needs to be selected here.

It since if circular dependency happens, it will be more than once.


Support cells created from nibs

Changes in this pull request
I started working on adding support for dequeuing cells created from nibs (issue #1). Additionally I extended IGListSingleSectionController so that it can be used with nibs too. I don't know if you had this also in mind.
Missing

[ ]  I'm currently thinking about the best way to test these changes.
[ ] I was not able to update the documentation (issue #55).

Pull request checklist

[x] All tests pass. Demo project builds and runs.
[ ] I added tests, an experiment, or detailed why my change isn't tested.
[x] I have reviewed the contributing guide

This is really, really great. I know the community is going to want this feature ASAP. Aside from my notes on the review, a couple other things we need to do:

Gen the documentation (jazzy is sort of broken w/ the dir structure, see #55 for a temp workaround)
Add unit tests

Add a test nib as a resource to the tests target
Unit test using cells (test that they are created and configured)
Unit test the single item controller (which I totally didn't think about!)

Optional: Add an example to the samples app

This could be something really simple, but maybe a cell w/ some autolayout labels or w/e

Gen the documentation

I'd personally prefer this in a separate PR. We should do this right before we push a new release with these changes. Otherwise, our docs and code are inconsistent. (That is, most people will be using CocoaPods/Carthage, pinned to a release tag, not using master. I think published docs should be for a release, not for master.)

@jessesquires interesting, I'm down w/ that workflow. I should detail that in the contributing docs. Should we revert it here?

Up to you.
I probably would, but this is also a minor change -- and it looks like we're going to push 2.0.0 out soon? (like probably this week or next?)

Thanks for the feedback. I think I covered all open points. Please let me know in case there are still something missing/wrong.

Making really great progress on this. This and storyboard support are easily the most wanted features right now. Going to make a lot of people happy!

Awesome!! @svenbacia last couple things then I think we're g2g:

Looks like it needs a rebase to fix the conflicts in CHANGELOG.md
Can you squash all the commits into a single commit?

Great! Let me know in case you need all commits in a single one.

I just realized that due to the latest changes to the IGListSingleSectionController there are no breaking changes. I will update the CHANGELOG.

First time I used rebase. I hope this is what you expected. At least the conflict is gone.

@svenbacia last request (I promise) is to revert the changes to docs/*. I'm going to run the script in a separate diff.
Rebase looks like it worked!

@rnystrom Done :)

Import is landing! 💪
I made a couple changes off of @dshahidehpour's internal review. You can check them out once the commit is pushed, but notably:

Renamed method from dequeueReusableCellFromNibName: to dequeueReusableCellWithNibName:
Changelog version to 1.1.0
Checking string length instead of nil string
Store property used twice in method in a local var


Corrected Layout of no-sensor-error-warning message.

Changes:

Fixes: #255

[x] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[x] If you have multiple commits please combine them into one commit by squashing them.

@jaydeetay Please review and merge.

@jaydeetay I know this is a minor change. But then again I am not getting held back by the fact that we need to revamp the whole application for the latest versions across the current Android devices.

Thanks - small, focused PR. Easy to review. Thanks for the change.


Mouseover Highlight assert

These are the highlight shaders, which don't appear to have a GLSL equivalent, how relevant that is i dont know,