Wemos D1 mini

Hello
Have you ever tried a Wemos D1 mini with a ESP8266 board? I am trying to make it run since 3 evenings but I do not get reliable data. To regulate the correct power of the A0 pin, a 180k resistor is enough to pimp up the internal voltage divider. This allows an input voltage of 5V on A0 which comes from the ACS712. (see https://community.blynk.cc/t/solved-acs712-voltage-amps-ghost-readings/12143/69)

Unfortunately my output stays always around 40-50mA when I start a constant load of 230mA (12v fan on regulated power supply). My console output:
G⸮Z⸮Qp@dI⸮⸮&ϝhF⸮W⸮TWZ-%dDu@⸮JdH⸮`H⸮;lJP@wdJ⸮!DU⸮
`\"⸮⸮`\⸮*`PP@%pHXu
`D⸮⸮O⸮X⸮'
`\B`Z`H)dMD⸮⸮X
⸮Q⸮⸮⸮
dXD*M+nD⸮9%D⸮%dx@⸮0
46 <--- started Wemos D1
41
41
41
46
53
48
48
48
48
46
46
56  <- powered on 12v fan
53
53
56
51
53
53
56
53
53
53
51
41 <- powered off 12v fan
41
41
41
41
41
41
46

Is my ACS712 somehow fried? There's my complete sketch:
#include <ACS712.h>

ACS712 ACS(A0, 1, 4096, 100);

void setup() {
  Serial.begin(57600);
  ACS.autoMidPointDC();
}

void loop() {
  int mA = ACS.mA_DC();
  Serial.println(mA);
  delay(1000);
}

Thanks for the issue
Its late Saturday here, and I will look into this asap.
Can take a few days.

Did no tests with esp8266, did test mostly with Arduino Uno (5V device) and limited with ESP32 (3V3).
Can you do a basic test with e.g. 12V and a 1K resistor?  That should give ~12 mA.

Think the second param of the constructor should be 3.3 or 5.0.

Setting to 5.0, does just increase the value, but not correct:
97
109
97
109
109
109
109
170 <- power on 12v fan
158
158
158
158
158
158
170
158
158
158
158
97 <- power off 12v fan
109
109
109
109
109
109

I will order some ESP32 dev boards and will double check it. Did you just connect the OUT of the ACS712 directly to an ADC of the ESP32 without any resistor?

I do not recall using a resistor in the tests however it was quite some time ago.
Can you print the midpoint found?
Plus a raw A0 measurement of the midpoint?
Do this without any load connected.

What voltage does your DMM measure at the OUT pin with no load?

The ACS712 OUT pin can be connected directly to the ADC of the processor. Googled several schematics and saw no resistor used in sny of them.

Before I do further tests, let me first replace the hardware to ensure none of them is broken (Wemos and ACS). Maybe I did some mistakes in the past and fried something. Please give me some days, the parts are already shipped

@rediculum
Any progress made?

Honestly I lost track and did not follow it. Maybe I come back later

OK, if needed feel free to reopen / create a new issue!

Hello
I'm trying to do the same: ESP8266 (ESP12F) + ACS712 (5 A)
Since I'm using the bare version of the ESP8266, I don't have any voltage divider already installed.
I'm using a R[ACS] = 300K and R[GND] = 75K (ACS712 powered by a 5v source).
In the code, I instantiate your class with mAcs712(A0, 1, 1023, 32) to obtain nice and fair results.
...but, I have set the mVperAmp, with a trial and error process (ie. increasing since I get the correct output).
Actually, according to what is described in your README, I should set 20 mVperAmp (75/(75+300)*100), but with these settings I retrieve a too high value of A (current).
I have also tried to change the second param (volt) to 3.3 and 5, but the obtained A still tends to increase.
I hope, my setting can be helpful to someone, although I would like to understand why the correct value for mVperAmp is 32...or if a made some big mistake somewhere in the calculation.
Thanks for your project!

@elbowz
Thanks for your info,

In the code, I instantiate your class with mAcs712(A0, 1, 1023, 32) to obtain nice and fair results.
Need to look into this,

If you have zero current, what is the output in volts of the ACS712 ?
It should be around Vcc / 2 = (ACS712 powered by a 5v source) ==> 2.5 V

@elbowz
What do you mean by I'm using a R[ACS] = 300K and R[GND] = 75K
I do not know your schema...

OK, found Voltage divider section

R1 = 300K,  R2 = 75K
==> voltage factor =  75 / 375 = 0.2
==> mVperAmp corrected = 185 * 0.2 = 37   which is near to the 32 you have.
The ADC itself is not changed, mAcs712(A0, 3.3, 1023, 37) should work.
Q: can you measure the resistors with a DMM?

Your max voltage is 5V * 0.2 == 1V so the midpoint should be around 0.5V
And you only use 1023/3V3 = ~310 steps of the ADC..
Note that **mAcs712(A0, 3.3, 1023, 37) == mAcs712(A0, 1, 310, 37)
You should set a new midPoint (0.5V or 165) as you do not use the full scale of the ADC.

Summary, please try mAcs712(A0, 3.3, 1023, 37) and call autoMidPoint() with zero current.

First of all, thanks for your quick reply, but no rush or hurry :)

If you have zero current, what is the output in volts of the ACS712 ?
It should be around Vcc / 2 = (ACS712 powered by a 5v source) ==> 2.5 V

Confirm: 2,490 V with my multi-meter, and a power source of ACS712 of 5.012v (Hi-Link HLK-PM01)

What do you mean by I'm using a R[ACS] = 300K and R[GND] = 75K
I do not know your schema...

My apologize, you are right. Following your voltage divider schema:
ACS712 ----[ R[ACS] ]----o----[ R[GND] ]---- GND
                         |
                         |
                   ADC of processor

R[ACS] = R1
R[GND] = R2

The ideal voltage divider ratio for 5V to 3.3V would be 1:2
Then you can use the whole range of the ADC.
==>  R1[ACS] = 1K  R2[GND] = 2K  => voltage factor = 2/3 = 0.66  (is exactly  5/3V3)
==> mVperAmp corrected = 185 * 0.66 = 123

Please let me know your final test results,
For me I need to clarify that section a bit more and this is a good example
Thanks for reporting!

The ideal voltage divider ratio for 5V to 3.3V would be 1:2 Then you can use the whole range of the ADC.
==> R1[ACS] = 1K R2[GND] = 2K => voltage factor = 2/3 = 0.66 (is exactly 5/3V3) ==> mVperAmp corrected = 185 * 0.66 = 123
Need to add this example divider in the readme.md

Wait, I'm not sure to understand, but ESP8266 ADC pin have a max Voltage of 1 V with 10 bit resolution.
do you still think that my voltage divider is wrong?

but ESP8266 ADC pin have a max Voltage of 1 V

My ESP8266 can go to 3V3 (but its on a board, not the bare chip...

Snippet of the new notes
For a 5 A type sensor, 185 mV/A would be the normal value.
After using a voltage divider one need to adjust the mVperAmp.

R1 (ACS)
R2 (GND)
voltage factor
mVperAmp corrected
notes

10200
4745
4745 / (10200 + 4745) = 0.3175
185 * 0.3175 = 31.75

4745
10200
10200 / (10200 + 4745) = 0.6825
185 * 0.6825 = 68.25

10200
9800
9800 / (10200 + 9800) = 0.4900
185 * 0.4900 = 49.00

1000
2200
2200 / (1000 + 2200)  = 0.6875
185 * 0.6875 = 127.2
5V -> 3V3 ADC

300
75
75   / (300 + 75)     = 0.2000
185 * 0.6875 = 92.5
5V -> 1V ADC

Similar table for the 20A and 30A sensor

Wait, I'm not sure to understand, but ESP8266 ADC pin have a max Voltage of 1 V with 10 bit resolution.
do you still think that my voltage divider is wrong?

No, your voltage divider is optimal.
The call that should work is (by latest insights) mAcs712(A0, 1.0, 1023, 92.5)
that gives
mV / AMP: 92.50
mA/step : 10.57
10.57 *1023 == 10A == +- 5A so that matches the range...

My ESP8266 can go to 3V3 (but its on a board, not the bare chip...

Be careful, the Esp8266 devboards (eg. NodeMCU), already have a voltage divider inside for the ADC pin. So if you want to use it, you shouldn't add another voltage divider (in front), because this adds resistors in parallel to the already existing ones (you have to recalculate the resulting resistance). I think it would be better to add a single R = 180kOhm in front of the ADC pin of the devboard:
https://arduino.stackexchange.com/a/71952

mA/step : 10.57

How do you get this value? I guess 1000/92,50, but I get 10,81 (only for understand)
One thing that I can suggest to better explain in the README.md, is how to choose the voltage value:

Volts is the voltage used by the (Arduino) internal ADC.

I don't know what set for my ESP8266 between 3v3 (power source) or 1v (the max voltage accepted by ADC).
Results
mAcs712(A0, 1.0, 1023, 92.5)
R1 (ACS) = 302.5K 	R2 (GND) = 74.6

My ESP8266 can go to 3V3 (but its on a board, not the bare chip...

Be careful, the Esp8266 devboards (eg. NodeMCU), already have a voltage divider inside for the ADC pin. So if you want to use it, you shouldn't add another voltage divider (in front), because this adds resistors in parallel to the already existing ones (you have to recalculate the resulting resistance). I think it would be better to add a single R = 180kOhm in front of the ADC pin of the devboard:
https://arduino.stackexchange.com/a/71952

Thanks for this insight.

mA/step : 10.57
How do you get this value? I guess 1000/92,50, but I get 10,81 (just for understand)
One thing that I can suggest to better explain in the README.md, is how to choose the voltage value:

ACS712  ACS4(A0, 1, 1023, 92.5);
mV per step = 1000 mV / steps = 0.9775 mV per step
(0.9775 mV/step) / (92.5 mV / Ampere) = 0.9775 / 92.5 *(Ampere / step) = 0.0105678 A/step = 10.57 mA / step.

Volts is the voltage used by the (Arduino) internal ADC.
I don't know what to set for my ESP8266 between 3v3 (power source) or 1v (the max voltage accepted by the ADC).

As you have a bare ESP8266 it should be 1V ADC with 1023 steps.

and DMM measured resistances:
R1 (ACS) = 302.5K
R2 (GND) = 74.6

so the factor is 74.6 / 377.1 = 0.1978  (so within 1% of 0.2 which you want.)

mAcs712.autoMidPoint() return 470 with 2.45v measured at the ACS output pin.

That is ~1% lower than expected  (2.45 / 5.0 = 0.49)

The voltage of the ADC is 1.0
The steps of the ADC is 1023
The mVperAmp corrected = 185 * 0.1978 = 36.59
==> I would try this one mAcs712(A0, 1.0, 1023, 36.59)
This line is incorrect as the factor is not 0.6875 it should be 0.2000

300 | 75 | 75 / (300 + 75) = 0.2000 | 185 * 0.6875 = 92.5 | 5V -> 1V ADC
-- | -- | -- | -- | --

mV per step = 1000 mV / steps = 0.9775 mV per step (0.9775 mV/step) / (92.5 mV / Ampere) = 0.9775 / 92.5 *(Ampere / step) = 0.0105678 A/step = 10.57 mA / step.

Thank you! It's clear, now :)

Volts is the voltage used by the (Arduino) internal ADC.
I don't know what to set for my ESP8266 between 3v3 (power source) or 1v (the max voltage accepted by the ADC).

As you have a bare ESP8266 it should be 1V ADC with 1023 steps.

Ok, so the voltage is the max voltage accepted by the ADC pin (and not the power supply).

and DMM measured resistances:
R1 (ACS) = 302.5K
R2 (GND) = 74.6

so the factor is 74.6 / 377.1 = 0.1978 (so within 1% of 0.2 which you want.)

mAcs712.autoMidPoint() return 470 with 2.45v measured at the ACS output pin.

That is ~1% lower than expected (2.45 / 5.0 = 0.49)
The voltage of the ADC is 1.0 The steps of the ADC is 1023 The mVperAmp corrected = 185 * 0.1978 = 36.59
==> I would try this one mAcs712(A0, 1.0, 1023, 36.59)
This line in the table above is incorrect as the factor is not 0.6875 it should be 0.2000
300 | 75 | 75 / (300 + 75) = 0.2000 | 185 * 0.6875 = 92.5 | 5V -> 1V ADC -- | -- | -- | -- | --
(I added a line above in the table, sorry for the inconvenience)

I appreciated all the explained steps to get to the correct values to use: mAcs712(A0, 1.0, 1023, 36.59)

Power wall meter
ESP+ACS

0.43
0.25

1.74
1.62

3.40
3.27

Now, the obtained results are pretty good :)
Thank you!

The values seem to be ~4% too low.
So if you try 36.59 x 1.04 = 38.05 it will probably even be better.
However you might need to make more measurements to optimize the actual working range of your project.

But why, on low current (A) the error is more? (First row of my table)

See the ADC curve of the ESP8266 on this site (sorry for all the spam).
It has two dead zones, one at the low end and a second at the high end, it is just not linear over the whole range.

https://microcontrollerslab.com/esp8266-nodemcu-adc-tutorial-measure-analog-voltage/

At the top end you can correct a little by stating mAcs712(A0, 0.995, 1023, 36.59)  use e.g. 0.995 V instead of 1.0V
At the bottom end is harder to fix. I do not know a quick fix for that (nor a slow one).

and mainly I don't understand because loads about 20 - 50 Watt (0.09 - 022 A) give 0 A on ACS, is it normal?

Measure the actual voltage and you see it is in the dead zone at the bottom side.
A scale of 5A in 1023 steps is ~5mA / step
1023 steps is 1 V is ~1mV / step.
0.09 A == 2 steps ==> 2 mV
0.22 A == 4.5 steps ==> 9 mV
The curve only swing up at about 0.15V =  150 mV so both are in the dead zone.

Solution for low currents is external ADC e.g. an ADS1115.

See the ADC curve of the ESP8266 on this site (sorry for all the spam). It has two dead zones, one at the low end and a second at the high end, it is just not linear over the whole range.
* https://microcontrollerslab.com/esp8266-nodemcu-adc-tutorial-measure-analog-voltage/

At the top end you can correct a little by stating mAcs712(A0, 0.995, 1023, 36.59) use e.g. 0.995 V instead of 1.0V At the bottom end is harder to fix.  Thank you!
...but, we work in the middle of the ADC, or am I wrong? ACS712 give 2.5V in output without a load, so 0.5v on the ADC, thanks to the voltage divider. There isn't the dead zone in that area.
What I miss?
Maybe, I'm wasting your time, and going OT.

How can I increase the precision of float? btw, 0.14 A => 140 mA, the decimals should be enough.

Serial.print(someFloat, 4);  //  extra parameter

IMHO, the problem is the ACS712. For what I know, it's an inaccurate tool for measuring current...or it could be some mistake in my code or wiring.

You can improve on that with the library - from readme.md
Configuration BUS and SHUNT
Note:
The internal conversions runs in the background in the INA219.
If a conversion is finished the measured value is stored in the appropriate register.
The last obtained values can always be read from the registers, so they will not block.
Result can be that you get the very same value if no new data is available yet.
This is especially true if you increase the number of samples.
(See also discussion in #11).
Using more samples reduces the noise level, but one will miss the faster
changes in voltage or current.
Depending on your project needs you can choose one over the other.
As a rule of thumb one could take the time between two I2C reads of
a register as an upper limit.
This would result in a fresh measurement every time one reads the register.
NB it is always possible to average readings fetched from the device
in your own code.
Use one of these three so set bus resolution and sampling.

bool setBusResolution(uint8_t bits) bits = 9..12, always 1 sample.
Returns false if parameter out of range.
Returns false if it could not write settings to device.
bool setBusSamples(uint8_t value) value = 0..7 => maps to 2^value samples.
Always 12 bits.
Returns false if parameter out of range.
Returns false if it could not write settings to device.
bool setBusADC(uint8_t mask = 0x03) see table below.
Check datasheet for all details.
Returns false if parameter out of range (mask > 0x0F).
Returns false if it could not write settings to device.
uint8_t getBusADC() returns mask, see table below.

Use one of these three so set shunt resolution and sampling.

bool setShuntResolution(uint8_t bits) bits = 9..12, always 1 sample.
Returns false if parameter out of range.
Returns false if it could not write settings to device.
bool setShuntSamples(uint8_t value) value = 0..7 => maps to 2^value samples.
Always 12 bits.
Returns false if parameter out of range.
Returns false if it could not write settings to device.
bool setShuntADC(uint8_t mask = 0x03) see table below.
Check datasheet for all details.
Returns false if parameter out of range (mask > 0x0F).
Returns false if it could not write settings to device.
uint8_t getShuntADC() returns mask, see table below.

Resolution samples table
mask = both resolution + averaging multiple samples.
minus - == don't care

bit mask
value
resolution
samples
conversion time

0-00
0 / 4
9 bit
1 sample
84 μs

0-01
1 / 5
10 bit
1 sample
148 μs

0-10
2 / 6
11 bit
1 sample
276 μs

0-11
3 / 7
12 bit
1 sample
532 μs

1000
8
12 bit
1 sample
532 μs

1001
9
12 bit
2 samples
1.06 ms

1010
10
12 bit
4 samples
2.13 ms

1011
11
12 bit
8 samples
4.26 ms

1100
12
12 bit
16 samples
8.51 ms

1101
13
12 bit
32 samples
17.02 ms

1110
14
12 bit
64 samples
34.05 ms

1111
15
12 bit
128 samples
68.10 ms

note that a new value set can substantially increase the conversion time.
note that you cannot set e.g. 9 bits and 16 samples.
note that there are 3 ways to set 12 bits 1 sample.

Serial.print(someFloat, 4);

0.14A measured => 0.00000 mA no change...btw, if this had solved the problem, I would have even more questions ;)

I think, I'll keep my little project as is...more than enough for me :)

If there are no more questions, you may close the issue.

Thanks again for all your time, your support and your open source source project!

You're welcome

Only this:

With an ESP32 or an Arduino (ie. more accurate ADC), are you able to read low current like 0.14 A on AC?

With an ESP32 or an Arduino (ie. more accurate ADC), are you able to read low current like 0.14 A on AC?

Lets start again.

0.14 A == 140 mA
An ACS712 5Amp version at 10bits ADC has 26.4 mA per step, so it should measure about 5 or 6 steps.
What might be interesting for you, I have just released the initial version 0.1.0 of my INA3221, library

https://github.com/RobTillaart/INA3221_RT
https://www.ti.com/lit/ds/symlink/ina3221.pdf

It is a 3 channel device and meant for currents up to 1.6 A  so 0.14 amps is about 1/10 of the scale.
Maybe more interesting than the ACS712 for low currents?

Sorry, I would liked only know if you have test practically/empirically with an ESP32, because by your table also the ESP8266 should measure 140 mA, that's it.
Only a Yes or No :)
INA3221 seems interesting, thanks for the related info, I'll keep an eye on it.

Sorry, I would just like to know if you have tested practically/empirically with an ESP32, because according to your table the ESP8266 should also measure 140 mA, that's all.
Just a Yes or No :)

Yes


Spark Distributed Ingest

Signed-off-by: Srinivas Varala<EMAIL_ADDRESS>

Coverage decreased (-0.4%) to 48.84% when pulling 2c26585b9ec069a8e7bb64c60bea03b6d9e0f79b on srinivasreddyv2:spark-ingest into d3324631919a6763bd54f87681e4b5ea54f6cd81 on locationtech:master.

Coverage decreased (-0.2%) to 49.029% when pulling 70f1d861ea9ea1b0e316f65da30e51e1cc77053e on srinivasreddyv2:spark-ingest into d3324631919a6763bd54f87681e4b5ea54f6cd81 on locationtech:master.

Coverage decreased (-0.2%) to 49.029% when pulling 70f1d861ea9ea1b0e316f65da30e51e1cc77053e on srinivasreddyv2:spark-ingest into d3324631919a6763bd54f87681e4b5ea54f6cd81 on locationtech:master.

Coverage decreased (-0.2%) to 49.029% when pulling 70f1d861ea9ea1b0e316f65da30e51e1cc77053e on srinivasreddyv2:spark-ingest into d3324631919a6763bd54f87681e4b5ea54f6cd81 on locationtech:master.

pulled in through #1263


Header "Help" for non-logged user is broken

url: https://kiwicom.github.io/smart-faq/?help=%2Ffaq%2F

👍


Utilise new logger in stats-web

Depends on #430
See milestone for more description.
Acceptance criteria:

logger module from packages is added to statw-web
all console logs are replaced with properly bound logger instance calls
redundant or not useful logs should be removed

are you available to chat via discord? @ygrishajev

@forbesus yea, same username as here - ygrishajev
However I'm not sure about my availability till mon


Replace distribute dependency with setuptools

Also, it's no use to require it during the installation process. Instead, specify that it is required for setup.

Could this be merged distribute is deprecated.

@reox it seems you have already fixed it in your PR. Can we close this?


I mistakenly committed to master… Can someone please revert?

Please revert https://github.com/nodejs/node-gyp/commit/a37f186eacc17145e00972262d91e6402404ce05

This might be it, I'm pulling my hair to make it work 😄
Good luck @cclauss and thank you for supportin node-gyp 💌

force pushed to remove it, also edited a commit that's second in the stack but had a bad name: Update README.md, I changed it to: doc: update docs/README.md with latest version number.


[build] Build SHIM Examples

Description
This PR updates the build system to build shim examples.

Bypassing PR review as this concerns the build system.


enhance error handle for failing playbook clone

at the moment a playbook clone does 100 retries instead of exiting gracefully if the clone fails due to connectivity issues
part of work for https://bugzilla.redhat.com/show_bug.cgi?id=1835226 I guess
here's what happens now:
AwesomeSpawn: ansible exit code: 1
AwesomeSpawn: [WARNING]: - playbook-name was NOT installed successfully: Unknown
/opt/rh/cfme-gemset/gems/awesome_spawn-1.5.0/lib/awesome_spawn.rb:108:in `run!'

and then I think we have to delete the job to prevent the retries
@miq-bot assign @NickLaMuro
sorry Nick, but it's your circus
edit — to be clear, this does not really fix anything. but it's a start to this failing "better" for some definition of better.
and i really don't think it's an enhancement, but okay.

Where this raises the exception, we in theory could use some gook to get the request id, find the correct associated task, and stop processing retries.
The request id is something like this (gook):
options[:extra_vars]["manageiq"]["request"].split('/').last.to_i

@miq-bot remove_label enhancement
@miq-bot add_label bug

hey @NickLaMuro could I please get you to look at this again? It'll fail faster now? That's about the extent of the ideas I have for this.

hey @NickLaMuro could I ask you to dismiss the stale review and give this another 👁 please? Keenan's right, the job destroy updates the request so I don't need to do any of that.

Wow, total missed this notification yesterday.  Looking now.

It's green, it's green, it passed and everything, github's just incredibly slow.

github's just incredibly slow.

I think this is just a github bug, because I have had it "stuck on yellow" like that on different PR.


check-in witherspoon xml with full boot in hb standalone simics

@austinwrx - Please take a look

@op-jenkins ok to test

i looked at the recent changes i made. they are correct. looks good.


How to set some module to be loaded first of all?

Hi, I have some problem with inheritance: for example class Component is dependent from some other modules which is not loaded yet, as I understood webpack postpones loading this module. In some place another class extends this component and hence gets undefined and throws a error that can't read of undefined. How to tell webpack that this module must be loaded first of all, despite the dependencies, or maybe there is another way of solving that?
P.S. I use TypeScript.

I asked about similar situation on StackOverflow

This is likely an issue with TypeScript, the TypeScript loader you are using or just misconfigured. When compiling, TypeScript should be resolving the order as it has it's own module system. By the time it gets to webpack, it should have generated javascript that loads via commonjs or amd.


Can't scroll subscription page on mobile browser

Issue Summary
Can't scroll the subscription page using mobile browser, the screen recording is attached below
https://user-images.githubusercontent.com/30436755/155955803-0dc0a526-a656-4ae6-a6df-a1cf8a861e04.mov
Steps to Reproduce
Open the page then go to the subscription page by click on the subscribe button. On the subscription page, we can't scroll farther than the first plan.
Ghost Version
4.36.3
Node.js Version
16.x (Node v16 Gallium LTS)
How did you install Ghost?
Ghost Pro
Database type
MySQL 5.7
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Hey @yogurtpops 👋🏼 Could you confirm which mobile browser this is in? The answer was omitted from our issue template, but is essential info for troubleshooting this specific issue. Thanks!

I have experienced this bug on Firefox, Safari and Chrome on iOS 14.3 (iPhone 12 Pro Max)

@matthanley as mentioned by @GV3 in any browser on iphone 12 . I checked that its fine on android and iphone 7 plus. Could it be os based problem?

I'm unable to reproduce this in Safari on iOS 15.3.1 so it may be a browser bug. Could you confirm what version of iOS you're using, and try updating to the latest to see if the issue persists?

@matthanley I had this occur on an iPhone 7 Plus, using iOS 13.3.1, as reported on the forum a few months ago. The problem occurs in portrait mode but not landscape mode. I too have a video if you'd like, if you have a method in which I can privately share it with you.


fix(jsr): exclude unused markdown files

These may have been included because they could not be linked to files on GitHub before on JSR, but now they are linked correctly like npm. Therefore, it is better to exclude them.
The author should do the following, if applicable

[ ] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code
[ ] Add TSDoc/JSDoc to document the code

Hi @ryuapp
Nice! Looks good to me.


Added trailing slash generates faulty canonical links

This is more of a question, than an issue.
https://github.com/jonathan-reisdorf/kirby-static-site-generator/blob/54a02f340d5c6c0764608e93ce734298f0c64e26/class.php#L68
This line generates faulty canonical links in our setup.
Our static sites runs in a subfolder (e.g. https://domain.tld/static). When generating a static site given this base url, the canonical link of the homepage always has a trailing slash. Thats not totally wrong, but unwanted in our case.
Since kirby already does a great job with generating urls, what is this line needed for?

Hello :wave: Thanks for reporting!
I added this change in 2019 as part of https://github.com/d4l-data4life/kirby3-static-site-generator/pull/2 when fixing static site generation for single-language sites, but I don't exactly recall why I it seemed necessary back then. This should be solvable more elegantly respecting the original settings, but fixing it will require some testing since in _generatePage there's a lot of rewriting going on to match URLs rendered in different ways


Allow hiding the Video Conference Mute Toolbar

The Video Conference Mute is great, but since I keep my mic muted most of the time, I'd like to be able to just turn off the toolbar. Currently, one can only select where to place the toolbar, but not disable it altogether.

@dawadaq
thank you for the feedback.
The suggestion has been added to https://github.com/microsoft/PowerToys/issues/6374

I want to vote for this feature too. Additionally to the 6 locations for where to place the toolbar, please add a 7th option to just not show it at all. Both my camera and my microphone have visual indicators for on/off, so I don't need to see it on the screen too.
Thanks!

I think this is more useful if there is also option to only show the toolbar if either video or mic is not muted? This is great for privacy perspective as you are not using your webcam all the time and would love it to be disabled unless you need it to use it.

I think this would be a great option as it is annoying to have it shown all the time.

@yuyoyuppe or @niels9001 Do you think this would be difficult? Any dependencies (like WinUI3 or something) ?

@crutkas would replacing the current VCM toolbar (that uses SVGs) with an actual window (and using XAML) be a large work item? It would basically be a borderless window with 2 buttons.
Pro's:

the toolbar can be draggable
proper theming support
accesibility improvements + narrator support
overall better UX

and DPI scaling #14079

@crutkas would replacing the current VCM toolbar (that uses SVGs) with an actual window (and using XAML) be a large work item? It would basically be a borderless window with 2 buttons.

OR a completely different UI all together (like #6389 or #6751)

Not a big word item either way. Also, XAML UI would be great and fix some issues with scaling.

I think this feature is quite necessary. Sometimes I just want to confirm the on/off status of my microphone and camera. To achieve this, I have no choice but to toggle the microphone/camera once to show the toolbar.
It would be much better if there is a shortcut to only show/hide the toolbar. Or there is an indicator icon in the taskbar like Discord.

I would prefer tray icons too. @niels9001 can we make some kind of poll or discussion for this choice? I'm really curious what the people want most.

@crutkas Should chime in here - I know Windows 11 has a mute systemtray button nowadays, so having one for VCM might conflict what that. (#mutebuttonseverywhere :))

Agree with the tray icon conflict issue with win11.
Part of me goes this should be as a concept inside the flyout and that solves the 9000 same icons in systray

Is the Ticket in Working or in planing to closed?

Is there any forward movement on this? My Microphone has a great big RGB LED inside of it, I literally cannot miss if it is off or on as it is right in front of my face. But due to the massive size of the toolbar due to it not scaling correctly there is nowhere I can put it that it is not either covering up a needed UI function in a window or covering information on a program bar or tab.
An option to simply disable the toolbar or have be on a timer would be a godsend.

@yuyoyuppe An option to always have the toolbar hidden should be possible here, right? We have one already for hiding it conditionally.

We'll add an option for hiding the bar completely.

We'll add an option for hiding the bar completely.

This community is incredible.

I think we still need to decide on the approach - how to implement it and whether to do it for the current UI or XAML one.

(cough) Github Discussions (cough)

Yeah, I think moving to WinUI 3.0 for VCM is not a priority now, so we'll just implement the option anyway for the current UI.

I concur, and would add on Windows 11 there is already a microphone mute toggle button in the system tray. Perhaps it would be easier to implement a keyboard shortcut to toggle that button than do anything with Powertoys.

Yes, we've just ported Settings and PowerRename, and currently looking into what kind of issues we're getting. If all goes well, it should be on our priority list.

Yes, we've just ported Settings and PowerRename, and currently looking into what kind of issues we're getting. If all goes well, it should be on our priority list.

That is great news, I use VCM daily as I am required to be on calls all day, but no matter where I put the notice it is always in the way of some UI element.

We have an open PR from a community member https://github.com/microsoft/PowerToys/pull/19175

@yuyoyuppe I don't know about others, but personally, I want nothing to do with that toolbar regardless of whether I'm muted. I just wanna pick "where to show the toolbar > nowhere".

I get you, that behavior is easy to implement on to of that PR.

Thanks for the feedback but VCM is moving to maintenance only in the 0.67 timeframe. Our team will only directly address critical bugs, security and accessibility issues.
We'll accept community PRs for enhancements.

"closed this as [completed] [on Dec 28, 2022]"
Sorry but I'm still missing the option to "always" hide the toolbar. I read through https://github.com/microsoft/PowerToys/pull/19175 but am not sure if it adds that option.

This is really irritating. What is the point of this feature if there is an annoying toolbar present the whole time. It is unnecessary for some of us who have indicators on our keyboard. Just add the "Always hide" setting we are all asking for!

Is there any update on the implementation of this?

Just chiming in this is a sorely missed feature. Not being able to hide seems like a bit of an oversight...and it's now almost a year since this was last talked about? I'm in a (perhaps slightly unique) situation where I can't actually turn VCM off, as I cannot run PowerToys with admin privileges (work laptop restrictions). So I'm stuck with it being always activated, and no recourse to hide the toolbar. The apps I work with regularly put important info in the four corners of the screen, so any place I locate the toolbar it hides important info. Would love to see an update on this!

Just chiming in this is a sorely missed feature. Not being able to hide seems like a bit of an oversight...and it's now almost a year since this was last talked about? I'm in a (perhaps slightly unique) situation where I can't actually turn VCM off, as I cannot run PowerToys with admin privileges (work laptop restrictions). So I'm stuck with it being always activated, and no recourse to hide the toolbar. The apps I work with regularly put important info in the four corners of the screen, so any place I locate the toolbar it hides important info. Would love to see an update on this!

Thank you, I know VCM has moved into legacy mode (maintenance only), but this is a reason to add in this option as for some people it breaks the extension. Therefore this simply is not just a feature but a necessary fix for most of us!


Wallet balance translation fix in Payments Page

@marklouisdeshaun
Fixed Issues
#4448
Tests & QA Steps

Select preferred language to Español in Settings -> preferences.

Settings Page Near the payments option, we show a balance as $0.00 for English. In Spanish, we show
0,00 US$.

In Mobile both pages will show $0.00 for Spanish.

Fix - On the Payments page also, we will show translation for wallet balance.
Included English translations also.

Fix - For Mobile both settings & payments page we will show translation for wallet balance.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @johnmlee101 in version: 1.0.85-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-06.  :confetti_ball:


IMA SDK not working on Android chrome browser

Dears,
I have implemented the IMA SDK into my website and the ads are working perfectly on all devices (laptops, ios phones ...)
except on Android with Chrome version 84.0.4147.125 the ad didn't play.
I am  using the VideoJS IMA plugin.
You can find below a link where I have implemented the video.
https://www.specialarabia.com/en/details/Makeup-Tutorial-with-Fady-Kataya.
Please advise if anyone can help.
Thank you

Hello @eliasasmar ,
Sorry for the delayed reply. I was aware of an issue with Chrome v84 and IMA on Android, but I believe the issue was resolved.
However when checking your link, ads were not able to be played, and I received the following error:
videojs.ima.js:1447 AdsLoader error: AdError 303: No Ads VAST response after one or more Wrappers
Are you also seeing this 303 error currently? Also, are you still experiencing issues with Chrome on Android?
Thank you,
Jackson
IMA SDK DevRel

Hi Jackson,
Thanks for your reply.
Yes I am still facing the same problem on mobile android. The ads are not playing on mobile.
You can check below a new video we added on the website.
The Ad is working perfectly on laptop once we click the play button but on android nothing happens.
https://www.specialarabia.com/en/details/L-Oreal-Paris-highlighting-the-Regions-most-inspiring-women
The error you mentioned is not showing but Once I open google chrome console in browser and click on play I am getting the below error
Uncaught TypeError: Cannot read property 'innerHTML' of null
at Ads.log (ads.js?v=1:110)
at Ads.onAdEvent (ads.js?v=1:106)
at Hh (ima3.js:112)
at Y.l.dispatchEvent (ima3.js:110)
at dy (ima3.js:471)
at Y.Zd (ima3.js:468)
at Hh (ima3.js:112)
at Vv.l.dispatchEvent (ima3.js:110)
at Vv.F (ima3.js:404)
at Eh (ima3.js:107)
at Bh (ima3.js:108)
at b (ima3.js:105)
Please advise
Thank you
Elias Asmar

Hello @eliasasmar ,
Sorry for the delay in response. I was able to reproduce the issue using a Pixel 3 device and the web page provided. I was also able to reproduce the issue on the IMA's video suite inspector. This suggests to me that it is an issue with the IMA SDK itself and not the videojs-ima plugin. I will be raising an issue with the IMA team to resolve this bug.
As a note, this was not reproducible using the an Android emulator from desktop chrome.
Thank you,
Jackson
IMA SDK DevRel

Hello @eliasasmar ,
After talking with the IMA team, it looks like there will not be a change coming from the SDK to fix this issue. As a workaround I recommend setting adsRenderingSettings in the additional settings section to avoid type 'application/x-mpegURL' type. Please see the below example on how to set the adsRenderingSettings object.
adsRenderingSettingsObject = {
    mimeTypes: [
        'video/mp4',
        'video/webm',
    ],
}

Let me know if you have any follow up questions,
Thank you,
Jackson
IMA SDK DevRel

Hello
I try to do this, but it is not work
my code
var imaOptions = {
id: 'content_video',
adTagUrl: myAdTagUrl,
adsRenderingSettings:{mimeTypes:['video/mp4']}
};


Dataset - download

May we download the dataset for research purposes only?

Yes sure you can download the dataset to do research. The aim of this project is to develop, create and share a free medical chatbot for everyone.


Upgrade dependency

Upgrade<EMAIL_ADDRESS>to version

Please ignore this PR and close it. Generated by TestIM


Move default implementations for filters and formatters to CLI commons

https://github.com/microsoftgraph/msgraph-cli/issues/52


feat(hooks): add support for virtual property getters

Closes #82

Pull Request Test Coverage Report for Build 611

23 of 23 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 608:
0.0%

Covered Lines:
2696

Relevant Lines:
2696

💛  - Coveralls


tests, primary_pod_network: Remove race condition at bridge binding GA test

What this PR does / why we need it:
There is a race between guest agent connection check and VMIs IPs check since it could
happend that GA is connected but has not quick in yet, to overcome this this PR first
check the known IPv6 static address first to ensure that GA has started to report and then
it checks that VMI Status IPs contains VMI Status IP field.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4570
Special notes for your reviewer:
Release note:

NONE

/cc @EdDev

/retest

/retest

@EdDev I am going to refactor this so we don't depend on side effects.

https://github.com/kubevirt/kubevirt/compare/1b14e2a8925003f066c56c7a38a1ec5f21bad66c..9348fa248793ad2bc39551b3c4a6fb48d04774a5: Drop Eventually from IP on IPs check.

/retest

/cc @phoracek

force-push: Splitted the tests as @phoracek commented.

force-push: Removed irrelevant comment

force-push: Use removeCIDRs with IPs slice


[AUTO-CHERRYPICK] Fix for CVE 2024 25620 in cert-manager - branch main

This is an auto-generated pull request to cherry-pick commit a615c6f46dfa03750fd679c6def534dadb81210f to main. Original PR: #10063

Buddy build.


FaaSController

Close #22

Introducing FaaSController to Easegress.
Adding its user manual.
APIs had been tested in the FaaS cluster with K8s + Knative serving.

The FSM correcting and code cleaning has been updated.


no source/original program for admiral_eg.rda

decision: keep admiral_eg.rda for now and create our own version for the 2nd release

@pharmaverse/admiraldata does anyone have capacity to work on this?


Feature request: improve autocomplete in filter bar

Auto-complete in sql editor is now quite advanced: tables and columns appear as you type without invoking completion explicitly, it searches in the middle of names with advanced sorting of proposals. All of this, however, is missing when using completion from the filter bar in result sets: you need to use ctrl+space to invoke completion, it only finds stuff starting with what you typed, etc.
Can it be brought on par with the SQL Editor completion?
Thanks!

It won't be very easy. But still doable.

I believe mostly it was implemented in previous release. Some extra improvements (e.g.g coloring) will be added in 7.0.


Fix bench subproject and make sure it builds correctly in CI.

Running the bench subproject currently results in node-gyp throwing errors because it's version went out of sync with nodejs.
This error is only caught when running the subproject and not when compiling.
We should probably also run the benchmarks on every PR and somehow show them inside the Pull Request so that any changes don't worsen the performance of the project.

The problem with those benchmarks is that they are running with jsdom and not in a browser. So the results don't have any value right now.

Maybe we should run them using something like cypress


Adding missing libcaliptra dpe command structs

Changing back to draft since I have a related issue I am looking into

This updates and adds a few DPE structs as well as fixes 2 bugs exposed by uninitialized command and response buffers:

The checksum field in the command request may be populated before calculating the checksum. This would get overwritten, but the new checksum value would be incorrect. This is resolved by simply setting the checksum field to 0 before calculating.
The response checksum was calculated over the whole response buffer instead of just the received data. Garbage in the untouched part of the buffer would change the checksum. The actual number of bytes read is recorded and propagated to the checksum calculation now.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.13 to before v5.15.19",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=90c4d05780d47e14a50e11a7f17373104cd47d25",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=27980463256060aaef8db0ddfcf40fd2342b96e8"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "90c4d05780d47e14a50e11a7f17373104cd47d25",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "27980463256060aaef8db0ddfcf40fd2342b96e8",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "usb: gadget: f_sourcesink: Fix isoc transfer for USB_SPEED_SUPER_PLUS\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.19 by commit<PHONE_NUMBER>6060aaef8db0ddfcf40fd2342b96e8, it was introduced in version v5.13 by commit 90c4d05780d47e14a50e11a7f17373104cd47d25. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000250


Update css and positioning on profile page

fixed styling for the unsubscribed button and edit preferences
added  padding for unselected meal plan and updated the preferences settings
fixed positioning of text when unsubscribed

Looks good


Turtle writer does not respect namespaces in IRIs

Current Behavior
The turtle writer does not consider the namespace provided by an IRI. Instead, it turns the IRI into a string and then tries to derive a namespace from that string and then looks up that namespace in the namespace table.
Expected Behavior
If the IRI defines a namespace, that should first be used to look up the prefix in the namespace table. Interpreting the IRI as a string should only be a fallback.
Steps To Reproduce
	@Test
	public void testIriNamespace() throws Exception {
	    Model model = new DynamicModelFactory().createEmptyModel();
	    String prefix = "foo-bar";
        String ns = "foo:this.is.my.bar.";
        model.setNamespace(prefix, ns);
	    model.add(vf.createIRI(ns, "lala"), vf.createIRI(ns, "lulu"), vf.createIRI(ns, "lolo"));

        StringWriter stringWriter = new StringWriter();
	    Rio.write(model, stringWriter, RDFFormat.TURTLE);

	    assertThat(stringWriter.toString()).contains("foo-bar:lala foo-bar:lulu foo-bar:lolo .");
	}

Version
4.3.9
Are you interested in contributing a solution yourself?
Yes
Anything else?
No response

PR provided: https://github.com/eclipse-rdf4j/rdf4j/pull/4922

Not seen this before. Can you point to where this is defined in the turtle specification?

I have just ported code from Jena to RDF4J. In the Jena version, all IRIs I used were properly abbreviated when a namespace prefix was defined. Not so in RDF4J. I tracked this down to two issues:

SimpleIRI does not retain namespace and localname separately (I could work around this using a custom subclass of AbstractIRI)
TurtleWriter did not consider the explicit namespace in the IRI

Have a look at the provided test case.
As far as I can see during a quick scan of the Turtle specs, they deal mostly with parsing the turtle format. However, what I am trying to fix here is the serialization. The current serialization done by RDF4J provides valid Turtle, but it is unnecessarily verbose. My change makes more effective use of the namespace prefix declarations, leading to a serialized form that is more compact and easier to read.


Footsteps sounds

take into account dt1 sound index
depends on character and equip
most probably COF contains footsteps trigger frames

COF files for walking and running don't contain any triggers.

In the "Stay Awhile and Listen" book volume 2 which is a retrospective on Diablo 2 creation (very nice read !), they explain that they could not have a relation between the frames and the sounds, so they made the footsteps wav again and again so that they can be just played as loop and look OK with the animations, without being triggered by any frame.

@giviz Thank you for the great recommendation and footsteps insight!


Use clang-format

clang-format executable bundled with GDK
Config + githooks setup are the important files change in this PR
Remaining ~300 file changes are consequences of running the format
If there are things that should be changed in the config then:

See if I can change in config to be what we expect
If not, is it okay to have this for the sake of getting a linter?
If not, is it worth the effort to put // clang-format off(/on) to fix every section?
If not, are there enough annoying cases where we should abandon a linter altogether (pls no)

Known Issues:

Can't put lambda braces on the line after, the BeforeLambdaBody option seems broken (not part of the Allman brace config), so we're stuck with

if (FNetDriverDefinition* DriverDefinition = GEngine->NetDriverDefinitions.FindByPredicate([](const FNetDriverDefinition& CurDef) {
						return CurDef.DefName == NAME_GameNetDriver;
					}))

UE_LOG we seem to have custom formatting preferences for these function calls, not sure we can separate these

Could you please split this into two commits, for whatever changes were made to run clang format and what happened as a result.
Ideally 3 commits to have one that demonstrates what kinds of changes we expect and one that just does the rest.

Could you please split this into two commits; one for whatever changes were made to run clang format and one for what happened as a result.
Even better: 3 commits to have one that demonstrates what kinds of changes we expect and one that just does the rest.

I can if you think it makes things easier for you, but the configuration is just the .clang-format file which is first in the review?


Set the gradle version of the editor by default

Currently when you install the option is empty. It'd be great to just automatically set it to whichever version that editor is using.
BTW this tool is awesome, thank you!

Hmm, nice idea, thanks for the feedback!
It shouldn't be hard, since there is already code to search for the gradle jar distributed with Unity, and it has the version embedded on the file name.


Migration to PAC4J 2.0.x

This is a counterpart for IDC's internal ticket CAS-518.
We should make sure the extensions can work on the PAC4J 2.0.x version which is used in the latest CAS 5.1.x.
The latest CAS version is: 5.1.3 - https://github.com/apereo/cas/releases/tag/v5.1.3
The corresponding PAC4J version is: 2.0.0 - https://github.com/pac4j/pac4j/releases/tag/pac4j-2.0.0

Branch 1.9.x created.
Master is now for 2.0.x code.

The code has been merged into master after a code review.
Still leaving this ticket open until the new version is tested with our new version of CAS.

Version 2.0.0 was released a few minutes ago, already propagated to Maven Central.
See here: http://search.maven.org/#search|ga|1|com.idc.webchannel.pac4j

Closing this task.


Add config for CodeLlama 70B

The 70B CodeLlama released today: https://huggingface.co/codellama/CodeLlama-70b-hf

I don't know why the freaking tokenizer wouldn't output the same token ids, despite them representing the same text tokens.

The HF tokenizer is being funny. I don't know why. Let's simply merge as is and we'll look into where the difference is coming from in the future if it gives us problems or becomes a recurring issue with other checkpoints.


Add SkipModuleManifestValidate param to publish cmdlet

PR Summary
This PR addresses (#891) by adding a new -SkipModuleManifestValidate parameter switch.  It also updates the module version for next release.
PR Context
The Test-ModuleManifest cmdlet used by the Publish-PSResource cmdlet is not suitable for publishing module resources, as it is too restrictive and fails publishing for reasons that should not affect module publishing.  Adding this new switch will at least allow users to opt-out of the manifest file test and succeed in publishing their module.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Documentation needed

[ ] Issue filed:

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

Creating new PR without help update.


Disable opacity on Chrome and Sketch pickers

This is an awesome project. I want to use some of the prebuilt pickers, but my use case doesn't include editing the opacity/alpha channel. It would be great if it were possible to disable opacity/alpha on these pickers even if it means not being exactly like the pickers they were inspired from.

Yep! This is a dupe of https://github.com/casesandberg/react-color/issues/99, you can use:
<ChromePicker disableAlpha="true" />
<SketchPicker disableAlpha="true" />

I have also created this issue to make sure this gets in the documentation! https://github.com/casesandberg/react-color/issues/241

This link is helpful. Just one more query if we use  it will disable opacity part from palette. But it will not change height of palette. How would I decrease height of div class 'flexbox-fix' in palette.  So that we can remove extra height. Can someone please help to decrease height after disableAlpha="true" ?


bug

when I verify my test.less, the cmd tracks

I'll take a look. Thanks.

The issue is caused by https://github.com/nodejs/node-v0.x-archive/issues/2318. You can find more information here: https://github.com/nodejs/node-v0.x-archive/issues/5841
You can solve this by adding C:\Windows\System32\ to  your system PATH and restarting the command prompt.

Hi!
I've got the same error. I've added system32 to my PATH variable, restarted the command line and the error is still there. (screenshot below)


Set cluster_enabled to yes on Cluster

Hello.
Nice Project, reaaly handy.
I just have one issue though, is that every time I setup a cluster through this module, it seems that the flag cluster_enabled is not set to yes. Which is a pain for some redis client, that refuse to connect coorectly when this is not set.
If you have an idea on how I fix this, thank you in advance.
Great work on this.

Hi,
it looks like Redis Cluster isn't supported by the role yet. Is it possible to add such functionality in the near future?


Organization Widgets are not working as expected

Don't load perc_license_monitor_gadget anymore.

I retested this on the following nightly build:

On the published page, the Organization and the Departments are appearing on the page correct;ly:

I also tested the filters based on Departments and that appears to work as well.
I checked each person asset and it populated with the Org and Department correctly:

Lastly, I removed the "Ready for QA" tag.


Feature: Build with bitcode options

The lib is not compatibility with iOS 9 by bitcode option.
I added some options to argument of xcodebuild command.
OTHER_CFLAGS="-fembed-bitcode"
This flags means including bitcode when build.
(originally you can get bitcode when you Archive)
ref
ARCHS="armv7 armv7s armv64"
This means indicating which arch is needed to build.
I don't know what is default value when it is not given.

Thank you for the contribution and I apologize for the (really) delayed response, but I believe this was already fixed.


Discrete color picker

Came up in Vanderbilt call: Users probably want to pick from a limited palette. Let's just use the same picker that cell sets has.

This has been added, can we close?

Both cell sets and layers now have discrete color pickers so going to close and someone can reopen a more specific issue if needed


Connection reset by peer at random by using azure-storage-spring-boot-starter

Hi,
We are using the azure-storage-spring-boot-starter for downloading blobs from the blob storage. It works fine, but every now and then we get the following error:
 Failed to download file from blob https://<<location>>/file.png to <<location>>. Reason is: Status code 403, (empty body).
After getting the stackTrace we also see this:
failed: Connection reset by peer
Our code is quite simple and have no idea why this happens. Is this due to a timeout or just a bug in the old library that is being used in this starter? If we restart the API then it works again. Then after some time it happens again.
We don't see any possibility to at a timeout or whatsoever. See snippet below:

        AsynchronousFileChannel fileChannel = AsynchronousFileChannel.open(Paths.get(destinationFile.getAbsolutePath()), StandardOpenOption.CREATE, StandardOpenOption.WRITE);
        TransferManager.downloadBlobToFile(fileChannel, blockBlobURL, null, null)
                .doOnSuccess(headers -> {
                    log.info("File is downloaded to {}.", destinationFile);
                    downloadSuccess.set(true);
                })
                .doOnError(error -> handleDownloadBlobError(fileChannel, blobFileName, blockBlobURL, destinationFile, error))
                .blockingGet();

Thanks. Romario

Thanks for reaching out. Which version of the storage starter are you using?

We are also experiencing same issue with below stack trace
Using  azure-storage-spring-boot-starter v2.2.2 and with Azure Storage Resource of StorageV2 (general purpose v2)
java.lang.RuntimeException: java.util.concurrent.TimeoutException: The source did not signal an event for 60 seconds and has been terminated.
	at io.reactivex.internal.util.ExceptionHelper.wrapOrThrow(ExceptionHelper.java:46) ~[rxjava-2.2.18.jar!/:?]
	at io.reactivex.internal.observers.BlockingMultiObserver.blockingGet(BlockingMultiObserver.java:93) ~[rxjava-2.2.18.jar!/:?]
	at io.reactivex.Single.blockingGet(Single.java:2870) ~[rxjava-2.2.18.jar!/:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
Caused by: java.util.concurrent.TimeoutException: The source did not signal an event for 60 seconds and has been terminated.
	at io.reactivex.internal.operators.single.SingleTimeout$TimeoutMainObserver.run(SingleTimeout.java:123) ~[rxjava-2.2.18.jar!/:?]
	at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:38) ~[rxjava-2.2.18.jar!/:?]
	at io.reactivex.internal.schedulers.ScheduledDirectTask.call(ScheduledDirectTask.java:26) ~[rxjava-2.2.18.jar!/:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_242]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) ~[?:1.8.0_242]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) ~[?:1.8.0_242]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_242]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_242]

Is there any fix or workaround for this issue ?

Hi, the azure-storage-blob dependency that this azure-storage-spring-boot-starter refers to is too old. You can update it to a higher version to see if the problem still exists, for example, add the following dependency in pom.xml :

  <groupId>com.azure</groupId>
  <artifactId>azure-storage-blob</artifactId>
  <version>12.6.0</version>  <!-- {x-version-update;com.azure:azure-storage-blob;dependency} -->

@yiliuTo ..  Do you want us to add dependency com.azure:azure-storage-blob:12.6.0 along with azure-storage-spring-boot-starter ?    Does both versions compatible each other?  Please confirm.
If you are suggesting not to use azure-storage-spring-boot-starter, then we believe, its bigger discussion on the dependency update process..   Spring Boot starter has all configuration required for Spring Applications,  where as other dependency required us to manage all those configuration.  This process becomes very tedious due to limited documentation on Azure Java SDK.
Do you agree ?

Hi, @anubhavranjan. Currently we are migrating the azure-spring-boot repo to azure-sdk-for-java, and during this process, azure-storage-spring-boot-starter will be deprecated but we will give a sample of how to use Azure Storage Blob. Thus we recommend that you can use the com.azure:azure-storage-blob dependency directly with a closer version instead of the starter.

@yiliuTo Did you mean to tag @anumalasri ?

Sorry for my misoperation.

I already mentioned my comments on 'not using azure-storage-spring-boot-starter'.
Not we are hearing about deprecation of azure-storage-spring-boot-starter.  However, we could see the updates to latest Spring Boot v2.2.4.
@yiliuTo
We find any traces about deprecation, you mentioned. Is this deprecation only for Storage or all other components ?   Where can we find more details and plan for deprecation?

@anumalasri, thanks for the detailed feedbacks, I'd like to share some context / plan on the storage starter.
Currently there are two Spring starters for Azure Storage:

azure-storage-spring-boot-starter
spring-starter-azure-storage

which is in another repo: https://github.com/microsoft/spring-cloud-azure

There is plan to combine them, which is deprecate azure-storage-spring-boot-starter and enhance spring-starter-azure-storage.
To mitigate the impact, we will provide one sample to show how to do what azure-storage-spring-boot-starter provides: inject storage sdk's entry object into Spring application context.
Please note the sample will be based on Azure Storage track 2 library, and the entry objects has changed.

For the sample project about using Azure Blob storage with Spring Boot, you can refer to this.


Sonar - FindBugs&PMD

In new SonarQube versions they introduced their own set of quality rules (replacing need of external dependencies like FB, PMD)
Check if they're fine and try replacing them if better

Maybe it will be deprecated/not needed since #240

Due to #361 - not needed


Add possibility to change Font Size with themes or card-mod

Would it be possible to be able to have an option for the size of the timer font? I have this showing on my kitchen tablet but I can't see the time from too far away - I tried to use card-mod to try and make it bigger but it didn't work (but that absolutely could be me doing it wrong too haha)

Added to the TODO list. 😄