Infinite mapping with Hibernate Bug

I have an object that I am mapping called IncidentEntity, which is an Entity object in Hibernate. This object has a number of other Entity relationships for example SectionEntity and ProcessEntity. I have spent a lot of time setting up Dozer so it will deal with the lazy loading on Set's and on Join relationships.
dozer.statistics.enabled=false
org.dozer.util.DozerProxyResolver=org.dozer.util.HibernateProxyResolver
dozer.autoregister.jmx.beans = false

public class LazyLoadSensitiveMapper implements CustomFieldMapper {
    public boolean mapField(Object source, Object destination, Object sourceFieldValue, ClassMap classMap, FieldMap fieldMapping) {
        // If field is initialized, Dozer will continue mapping
        boolean stopMapping = false;

        if(sourceFieldValue instanceof PersistentCollection) {
            stopMapping = !((PersistentCollection) sourceFieldValue).wasInitialized();
        }

        return stopMapping;
    }
}

These two work for the most part. But for some reason its not working on the IncidentEntity after I manually lazy load the ProcessEntity (or SectionEntity) then attempt to map the object. I get an infinite mapping of a ProcessEntity which has a Set of SectionEntity objects and a SectionEntity has a ProcessEntity so it has this infinite recursive map issue (even though in theory it shouldn't happen).
Tested on 5.5.1
IncidentEntity.java
/**
 * Database entity for the 'incidents' table records.

 * Entity domain object is {@link nz.co.doltech.ims.shared.domains.Incident}
 * @author Ben Dol
 *
 */
@javax.persistence.Entity(name = "incidents")
@Cache(usage=CacheConcurrencyStrategy.TRANSACTIONAL)
public class IncidentEntity implements Entity {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    @Column(unique = true, nullable = false)
    private int id = Entity.UNSAVED_ID;

    ...

    @ManyToOne(fetch = FetchType.LAZY, targetEntity = ProcessEntity.class)
    @JoinColumn(name="process_state", referencedColumnName="id")
    private ProcessEntity processState;

    @ManyToOne(fetch = FetchType.LAZY, targetEntity = SectionEntity.class)
    @JoinColumn(name="section_state", referencedColumnName="id")
    private SectionEntity sectionState;

    @ManyToOne(fetch = FetchType.LAZY, targetEntity = ProcessEntity.class)
    @JoinColumn(name="process", referencedColumnName="id")
    private ProcessEntity process;

    @ManyToOne(fetch = FetchType.LAZY, targetEntity = SectionEntity.class)
    @JoinColumn(name="section", referencedColumnName="id")
    private SectionEntity section;

    ...

    public SectionEntity getSection() {
        return section;
    }
    public void setSection(SectionEntity section) {
        this.section = section;
    }

    public ProcessEntity getProcess() {
        return process;
    }
    public void setProcess(ProcessEntity process) {
        this.process = process;
    }

    public ProcessEntity getProcessState() {
        return processState;
    }
    public void setProcessState(ProcessEntity processState) {
        this.processState = processState;
    }

    public SectionEntity getSectionState() {
        return sectionState;
    }
    public void setSectionState(SectionEntity sectionState) {
        this.sectionState = sectionState;
    }
    ...
}

ProcessEntity.java
/**
 * Database entity for the 'processes' table records.

 * Entity domain object is {@link nz.co.doltech.ims.shared.domains.Process}
 * @author Ben Dol
 *
 */
@javax.persistence.Entity(name = "processes")
@Cache(usage=CacheConcurrencyStrategy.TRANSACTIONAL)
public class ProcessEntity implements Entity {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private int id = Entity.UNSAVED_ID;

    ...

    @OneToMany(fetch=FetchType.LAZY, mappedBy="process")
    //@Cascade({CascadeType.SAVE_UPDATE})
    private Set<SectionEntity> sections = new HashSet<SectionEntity>();

    @Override
    public int getId() {
        return this.id;
    }
    public void setId(int id) {
        this.id = id;
    }

    ...

    public Set<SectionEntity> getSections() {
        return sections;
    }
    public void setSections(Set<SectionEntity> sections) {
        this.sections = sections;
    }

    ...
}

SectionEntity.java
/**
 * Database entity for the 'sections' table records.

 * Entity domain object is {@link nz.co.doltech.ims.shared.domains.Section}
 * @author Ben Dol
 *
 */
@javax.persistence.Entity(name = "sections")
@Cache(usage=CacheConcurrencyStrategy.TRANSACTIONAL)
public class SectionEntity implements Entity {

    @Id
    @GeneratedValue(strategy = GenerationType.IDENTITY)
    private int id = Entity.UNSAVED_ID;

    ...

    @ManyToOne(fetch = FetchType.LAZY, targetEntity = ProcessEntity.class)
    @JoinColumn(name="process", referencedColumnName="id")
    private ProcessEntity process;

    @Override
    public int getId() {
        return this.id;
    }
    public void setId(int id) {
        this.id = id;
    }

    ...

    public ProcessEntity getProcess() {
        return process;
    }
    public void setProcess(ProcessEntity process) {
        this.process = process;
    }

    ...
}

Am I missing something? I have debugged the IncidentEntity object that I am mapping to make sure it hasn't recursively loaded before it is even sent off to be mapped and it hasn't.
Log output:
08:20:09,636 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.SectionEntity
  Source field name: process
  Source field type: class nz.co.doltech.ims.server.entities.ProcessEntity_$$_javassist_28
  Source field value: nz.co.doltech.ims.server.entities.ProcessEntity@792ee0e0
  Dest parent class: nz.co.doltech.ims.shared.domains.Section
  Dest field name: process
  Dest field type: nz.co.doltech.ims.shared.domains.Process
08:20:09,690 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.ProcessEntity
  Source field name: sections
  Source field type: class org.hibernate.collection.PersistentSet
  Source field value: [nz.co.doltech.ims.server.entities.SectionEntity@3209ee2d, nz.co.doltech.ims.server.entities.SectionEntity@29f3e605, nz.co.doltech.ims.server.entities.SectionEntity@de0cb4c, nz.co.doltech.ims.server.entities.SectionEntity@2142f1b2]
  Dest parent class: nz.co.doltech.ims.shared.domains.Process
  Dest field name: sections
  Dest field type: java.util.Set
08:20:09,734 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.SectionEntity
  Source field name: process
  Source field type: class nz.co.doltech.ims.server.entities.ProcessEntity_$$_javassist_28
  Source field value: nz.co.doltech.ims.server.entities.ProcessEntity@792ee0e0
  Dest parent class: nz.co.doltech.ims.shared.domains.Section
  Dest field name: process
  Dest field type: nz.co.doltech.ims.shared.domains.Process
08:20:09,785 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.ProcessEntity
  Source field name: sections
  Source field type: class org.hibernate.collection.PersistentSet
  Source field value: [nz.co.doltech.ims.server.entities.SectionEntity@3209ee2d, nz.co.doltech.ims.server.entities.SectionEntity@29f3e605, nz.co.doltech.ims.server.entities.SectionEntity@de0cb4c, nz.co.doltech.ims.server.entities.SectionEntity@2142f1b2]
  Dest parent class: nz.co.doltech.ims.shared.domains.Process
  Dest field name: sections
  Dest field type: java.util.Set
08:20:09,839 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.SectionEntity
  Source field name: process
  Source field type: class nz.co.doltech.ims.server.entities.ProcessEntity_$$_javassist_28
  Source field value: nz.co.doltech.ims.server.entities.ProcessEntity@792ee0e0
  Dest parent class: nz.co.doltech.ims.shared.domains.Section
  Dest field name: process
  Dest field type: nz.co.doltech.ims.shared.domains.Process
08:20:09,898 ERROR [org.dozer.MappingProcessor] - Field mapping error -->
  MapId: null
  Type: null
  Source parent class: nz.co.doltech.ims.server.entities.ProcessEntity
  Source field name: sections
  Source field type: class org.hibernate.collection.PersistentSet
  Source field value: [nz.co.doltech.ims.server.entities.SectionEntity@3209ee2d, nz.co.doltech.ims.server.entities.SectionEntity@29f3e605, nz.co.doltech.ims.server.entities.SectionEntity@de0cb4c, nz.co.doltech.ims.server.entities.SectionEntity@2142f1b2]
  Dest parent class: nz.co.doltech.ims.shared.domains.Process
  Dest field name: sections
  Dest field type: java.util.Set
at org.dozer.MappingProcessor.mapFromFieldMap(MappingProcessor.java:361)
    at org.dozer.MappingProcessor.mapField(MappingProcessor.java:307)
    at org.dozer.MappingProcessor.map(MappingProcessor.java:267)
    at org.dozer.MappingProcessor.mapToDestObject(MappingProcessor.java:216)
    at org.dozer.MappingProcessor.createByCreationDirectiveAndMap(MappingProcessor.java:196)
    at org.dozer.MappingProcessor.mapCustomObject(MappingProcessor.java:512)
    at org.dozer.MappingProcessor.mapOrRecurseObject(MappingProcessor.java:465)
    at org.dozer.MappingProcessor.mapFromFieldMap(MappingProcessor.java:361)
    at org.dozer.MappingProcessor.mapField(MappingProcessor.java:307)
    at org.dozer.MappingProcessor.map(MappingProcessor.java:267)
    at org.dozer.MappingProcessor.mapToDestObject(MappingProcessor.java:216)
    at org.dozer.MappingProcessor.createByCreationDirectiveAndMap(MappingProcessor.java:196)
    at org.dozer.MappingProcessor.mapCustomObject(MappingProcessor.java:512)
    at org.dozer.MappingProcessor.mapOrRecurseObject(MappingProcessor.java:465)
    at org.dozer.MappingProcessor.addToSet(MappingProcessor.java:757)
    at org.dozer.MappingProcessor.mapCollection(MappingProcessor.java:570)
    at org.dozer.MappingProcessor.mapOrRecurseObject(MappingProcessor.java:453)
    at org.dozer.MappingProcessor.mapFromFieldMap(MappingProcessor.java:361)
    at org.dozer.MappingProcessor.mapField(MappingProcessor.java:307)
    at org.dozer.MappingProcessor.map(MappingProcessor.java:267)
    at org.dozer.MappingProcessor.mapToDestObject(MappingProcessor.java:216)
    at org.dozer.MappingProcessor.createByCreationDirectiveAndMap(MappingProcessor.java:196)
    at org.dozer.MappingProcessor.mapCustomObject(MappingProcessor.java:512)
    at org.dozer.MappingProcessor.mapOrRecurseObject(MappingProcessor.java:465)
    at org.dozer.MappingProcessor.mapFromFieldMap(MappingProcessor.java:361)
    at org.dozer.MappingProcessor.mapField(MappingProcessor.java:307)
    at org.dozer.MappingProcessor.map(MappingProcessor.java:267)
       .....

I have no idea how to reproduce this issue but I'm farely sure it is a bug somewhere.

@BenDol ; is this still an issue?

Closing due to inactivity.

Do you have a solution, I almost tried all the solution in the stackoverflow, ... and other forums, but none of them worked for me. I have the same issue

@eloufirhatim ; see the below. Someone else has hit a similar:

https://groups.google.com/forum/#!topic/dozer-mapper/YmI-z2W_ReM

@garethahealy thanks for your reply.
I was using the Dozer
Before
<dependency>
    <groupId>net.sf.dozer</groupId>
    <artifactId>dozer</artifactId>
    <version>${dozer.version}</version>
</dependency>
<dependency>
    <groupId>net.sf.dozer</groupId>
    <artifactId>dozer-spring</artifactId>
    <version>${dozer.version}</version>
</dependency>

After, I switched for the DozerMapper/dozer plugin (this repository)
<dependency>
    <groupId>com.github.dozermapper</groupId>
    <artifactId>dozer-core</artifactId>
    <version>${dozer.version}</version>
</dependency>
<dependency>
    <groupId>com.github.dozermapper</groupId>
    <artifactId>dozer-spring4</artifactId>
    <version>${dozer.version}</version>
</dependency>

I thought I was using this from the begining 😄
But, can you explain to me the difference between these two libraries please? They are identical ? because, their configuration are pretty the same.
Thanks in advance.

Its the same project, but because of migrating to github and no longer controlling the sf site, the GAV changed.

Ok, thank you for the information.
Now all is working perfectly 😃

Hello again,
The same issue is back again, when debugging I see that my object is not mapped like I configured in the XML mapping file, but what is weird, is when I restart the server... It works juste fine.
Can you please help.
Thanks in advance


[Backport to v0.8] Upgrade Docker to v19.03.14

Backport #1855 to v0.8 branch.
Requires backporting #1888.

Tested automatically in the pipeline.
✔ epicli apply
✔ epicli upgrade from v0.7 to v0.8


[CI][Buildkite] Fix the PATH issue

Why are these changes needed?
docker run -it golang:1.17

The PATH environment variables of image golang:1.17 in my devbox and buildkite pipeline are different, so I need to update the PATH in the buildkite script.
Related issue number
#919

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Merge this PR before CI finishes because this PR is used to fix Buildkite pipeline only and has no relationship with other tests.


feat: Added function for easy backoff calculation

This adds an internal helper to return a backoff time.
In the future this should be used for any sleep calculation.
See #671

This got extended with #690

Duplicate of #690 ?

@JeremyTheocharis #690 is staging + this branch + the required changes to implement it into mqtt-to-postgres, therefore if #690 is merged this can be closed


Update packages

Microsoft.Data.SqlClient 3.0.1 https://github.com/dotnet/SqlClient/releases/tag/v3.0.1
Microsoft.Data.Sqlite 5.0.10
Microsoft.NET.Test.Sdk 16.11.0
MySqlConnector 1.3.12
Npgsql 5.0.10

https://github.com/mysql-net/MySqlConnector/releases/tag/2.0.0 is available.

Was not yesterday evening ;)

https://github.com/npgsql/npgsql/releases/tag/v6.0.0 has just been released.


Possible to assign individual dates with different colors at same time

I need the functionality to assign certain dates to certain colors , but they are all different color groups. Is there anyway to use highlight feature to achieve this or possibly changing the background color of each cell day to a color of my choice?
Also, is there any way of making the date cells setOnDateSelectedListener clickable even for the highlighted dates ?

^^ I would really like it if there was support for the above too. Especially making highlighted dates selectable. Is this currently possible?

Hi Sorry for the late response, as of now there is no callback for highlighted or deactivated dates, but will keep this features in next version, and do check the new 1.3.0 version of the lib


Fixes test using environment dependent path

The test ThrowsIfSikuliHomeIsSetAndFileDoesNotExist is using the hardcoded path C:\Temp. Not everyone has a C drive (default Windows drive letter can be changed) and not everyone has a folder Temp inside.
I used the environment variable %USERPROFILE% for SIKULI_HOME and made the GetSikuliVersion method capable of expanding environment variable found in SIKULI_HOME path.
I then removed the ExpectedException attribute (considered a bad practice in NUnit world :)) from the NUnit test and used Assert.Throws() instead to be able to Assert only part of the exception message.

This looks good to me, agreed for the ExpectedException too :)


External monitor: improvement grpc connection and error handling

Description
This PR aims to refactor and improve the module which defines interfaces and operations for an external monitor. There are 3 main goals:

[x] Improve error handling
[x] Improve connection between grpc client and server
[x] Code cleaning

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[x] Existing tests
[x] Manually

/build

/build

/test

/rebase test=true

/merge


Added some utils functions. Fixes #76

can you remove the already existent ip_country from localplayer?

I decided to delete both ip_country and ui_language.
I think ui_language would belong in localplayer.rs, too, but the documentation for ISteamUtils::GetSteamUILanguage says:

You probably want ISteamApps::GetCurrentGameLanguage instead, this should only be used in very special cases.

currentGameLanguage is currently in apps, so I think ui_language isn't really needed.
All I really needed here was isSteamRunningOnSteamDeck(). I just added the others because they seemed like they'd be easy to add.

Nice, can you run npm run build to generate the types file?


Improve performance of realtime consumption status checker

Realtime consumption status checker is used at startup time in Pinot Server to define a catch-up period in which no query execution happens and stream consumers try to catch up to the latest messages available in different streams. The current realtime consumption status checker defines a time threshold for startup consumption. When the wait time after Pinot Server starts up passes that time threshold, the status checker returns ServiceStatus.GOOD.
There are some ways to improve the existing behavior:

Add consumption rate statistics to the StatsHistory files of consuming segments. Then in startup period, consume greedily until the consumption rate converges to the rate available in the StatsHistory file.
At startup time, get the latest stream offset for each consuming segments and consume until the latest ingested offset is greater than the latest observed stream offset.

Please note that this improvement has been a TODO for a long time:
https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java#L204

The 2nd approach is being implemented in #7267

Implementation of the 2nd approach is done in #7267 and https://github.com/apache/pinot/pull/7753.


chore(tooltip): remove unecessary set state on unmount

General summary
Removed unecessary closing of tooltip (react set state) on unmount that can cause warnings in the React dev tools

Test OK - no regression on tooltip close


Fake News Detection - [GSSOC'23]

💥 Proposal
We can use the NEWS dataset from KAGGLE and detect whether or not that is fake news.

We can use the suitable machine learning algorithms to deal with this dataset.
The best model  RandomForestClassifier, Logistic Regression and SVM
It will also help those to understand how to deal with text data and process the data.
Can come across different encoding techniques (Categorical Encoding, One HOT Encoding)

I would love to help those who want to learn Machine Learning with a diverse data and find the relevant models.
True.csv.zip
Fake.csv.zip
Kindly assign me this under GSSOC'23. It would be really helpful

Hi. If there is a link to the kaggle dataset, please provide it :)

Hi. If there is a link to the kaggle dataset, please provide it :)

This is the link where I got to find the good dataset for Fake News Detection:
https://www.kaggle.com/code/therealsampat/fake-news-detection/input

Hi. If there is a link to the kaggle dataset, please provide it :)

I have uploaded the link.
Can you please go through it..


Warning fixes

Coverage increased (+0.4%) to 82.717% when pulling 5d79f23db72e24e766f202b27cf3fa2ce3e97faf on seanm:warning-fixes into f93a57597c9df27bbce98b6a9a4e24ebd205eca1 on tbeu:master.

Coverage increased (+0.4%) to 82.717% when pulling 5d79f23db72e24e766f202b27cf3fa2ce3e97faf on seanm:warning-fixes into f93a57597c9df27bbce98b6a9a4e24ebd205eca1 on tbeu:master.

Unfortunately, the CI setup is rather fragile. At least, it is running for Travic CI again, bit still need to fix it for Appveyor CI. Once I know how to address https://ci.appveyor.com/project/tbeu/matio/builds/39979026/job/78insi47y9l4hpu7#L166 I will rebase your branch again and merge afterwards. Thanks for your contribution and patience.

Thanks a lot!


Enhancement considerations: display hashcode

We should consider whether or not to display the hashcode alongside the user's captured code information.
It could be too much unnecessary info,
but it could be fun for the user to see what parts of the hashcode has duplicates so they can see how they got that score.

TA said not to display hashcode because it doesnt look nice.


Unable to decode ascii colors

Ninja isn't able to decode ascii colors
EX:
cat Makefile
all:
	@echo -e "\033[32mGreen\033[0m"
make
Output: Green written in green

cat build.ninja
...
rule rule2
 description = -e \033[32mGreen\033[0m
 command = /bin/sh -c ""
...
Output:
[1/1] -e \033[32mGreen\033[0m

Image:

What does your ninja.sh do? Ninja lets through ANSI codes if it's writing to a terminal, but attempts to strip them otherwise. (Looks like that's failing though.)
Oh, you mean in the description string. That's not passed through the shell, so -e doesn't do anything there. If the command does echo -e ... then that will show up in green. If you want colors in the description, you need to put the final interpreted byte values there; -e doesn't do anything there. (But if you do this, then this slightly breaks elision.)
So you can get most of what you want to do working. The bits that don't work are a dupe of #713.

ninja.sh is just a ninja wrapper from kati https://github.com/google/kati
exec ninja -f ./build.ninja "$@" )

Anyway I changed to description = echo -e \033[32mGreen\033[0m and it still doesn't work


Update hover text for "Known Diseases" column

Currently the "Known Diseases" hover says "Free text describing any diseases association to the cell type. Should be an EFO ontology."
I am feeling like this is old and should also reference that this is the specimen diseases and not the donor_organism diseases.
Proposing changing this to:
"Short description of known disease(s) of the specimen."
@malloryfreeberg does this change make sense to you or should we leave this or change to something else?

Oh also, we do not display disease on donor_organism on any table or currently have this as a facet. Is there interest in listing donor_organism diseases and faceting on them?

@NoopDog That description is fine.
Alternatively, you can grab the description directly from the specimen schema:
        "diseases": {
            "description": "Short description of known disease(s) of the specimen.",
            "type": "array",
            "items": {
                "$ref": "module/ontology/disease_ontology.json"
	        },
            "user_friendly": "Known disease(s)",
            "guidelines": "Enter normal if no known diseases."
        },

The donor schema has a similar description for disease, but it says "of the organism" instead of "of the specimen", thus distinguishing between the two if yo want to display both.
The current description in the hover looks like it was pulled from an older version of the schema, so I would highly recommend getting the values from the schema itself, so in case we update it, the Browser (and Metadata Dictionary) all display the same value.

Is there interest in listing donor_organism diseases and faceting on them?

I can see arguments for many sides for this one, with the following options:

Display only donor known diseases
Display only specimen known diseases
Display both donor and specimen diseases

I honestly don't know between options 1 and 2 which is more useful for people browsing the datasets. Option 3 is nice as it gives the full picture of what the data are representing, but this is more complex than options 1 or 2 and so we would need to telegraph clearly to people what the two different values mean (could be challenging).
I'm curious to hear what others (@gabsie @adriennes @HumanCellAtlas/wranglers @HumanCellAtlas/metadata-updates ) think about this.

When this was discussed at the 2018 November F2F in Boston, @adriennes had a wonderful ending statement of simply having a "see all facets" option where the donor's health would be shown. It was hoped this would be less confusing to users by not having a default facet for two disease states.
Not sure if this has been discussed since.

Agree with Mallory's assessment above: both donor and specimen level diseases are necessary to fully capture what's going on in the data, but it introduces a lot of complexity for users, and is a lot to disambiguate at first glance.  Like @claymfischer says, the best way to do this might be to hide the donor's health (since this is probably the less important of the two pieces of information) and make it viewable under advanced settings.


Add initial draft syrup specification

It's been here a long time so I'm going to merge this despite the few comments from @zenhack and take another look at what those comments are to see if they could be addressed.


422 Unprocessable Entity on opening PR

After creating a pull request, I added the variable PASS_IF_EXISTS, try to update the pull request, there will be the following print:
Unable to create pull request: 422: Unprocessable Entity
 {'message': 'Validation Failed', 'errors': [{'resource': 'PullRequest', 'code': 'custom', 'message': 'A pull request already exists for ***:branch_name.'}], 'documentation_url': 'https://docs.github.com/rest/reference/pulls#create-a-pull-request'}
...
...
Params for checking if pull request exists: {'base': 'main', 'head': '***:branch_name', 'state': 'open'}
No pull request from ***:branch_name to main is open, continuing!
Data for opening pull request: {'title': '', 'body': '.', 'base': 'main', 'head': '***:branch_name', 'draft': True, 'maintainer_can_modify': True}
...

The variable  PASS_IF_EXISTS doesn't seem to work.

PASS_IF_EXISTS is only relevant if you already have the PR and want the test to pass: https://github.com/vsoch/pull-request-action/blob/e64deeba68463798e4438d116312934afcd2d74a/pull-request.py#L326-L328
The error you are linking is triggered up here: https://github.com/vsoch/pull-request-action/blob/e64deeba68463798e4438d116312934afcd2d74a/pull-request.py#L110-L112 and it suggests that the GitHub API doesn't like the formatting of some of your parameters.

Also this line suggests you made it through that second part:

No pull request from ***:branch_name to main is open, continuing!

I'm suspicious about your title and body being empty (or a .) - I would try actually putting some content there. If that still doesn't work, try removing special characters from your branch name (I think I see a :)

Thanks for your reply, this has been fixed. The parameter does not conform to the format of the GitHub API.

Sure thing! I've definitely hit this issue before too. If you are all set please feel free to close the issue.


Bump serde from 1.0.193 to 1.0.195

Didn't see that #615 also included the serde update. After merging #615 the serde PR (#616) got automatically closed.
This PR adds the missing changelog message and also updates serde for the slurm collector.

We disallow self-approves, therefore adding @dirksammel as a reviewer ;-)


Fix for issue 19 and issue 21

Adding Django 3.1 and 3.2 in classifiers
Adding Python 3.9 in classifiers
Adding Django 3.2 in tox for testing on CI
Removing Django tip for now ;  Going to add it back later in a separate PR

Codecov Report

Merging #22 (a085367) into master (c888536) will decrease coverage by 0.63%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   98.75%   98.11%   -0.64%
==========================================
  Files          17       16       -1
  Lines         480      477       -3
==========================================
- Hits          474      468       -6
- Misses          6        9       +3

Impacted Files
Coverage Δ

...go_query_profiler/django/db/backends/mysql/base.py
72.72% <40.00%> (-27.28%)
:arrow_down:

...ery_profiler_storage/django_stack_trace_analyze.py
96.61% <100.00%> (+0.24%)
:arrow_up:

..._query_profiler/query_profiler_storage/__init__.py
100.00% <0.00%> (ø)

..._query_profiler/django/db/backends/sqlite3/base.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c888536...a085367. Read the comment docs.


Add missing meta tags

The <meta> tag provides metadata about the HTML document. Metadata will not be displayed on the page but will be machine parsable.
Meta elements are typically used to specify page description, keywords, author of the document, last modified, and other metadata.

The metadata can be used by browsers (how to display content or reload the page), search engines (keywords), or other web services.

Many meta tags are missing. Please refer this and add the missing relevant meta tags.

I am interested. Please assign this to me @vinitshahdeo

I am interested in this.

i'm interested in this. Could you assign this to me?

I can do this. please assign this to me. @vinitshahdeo

I want to contribute in this issue. Please assign this issue to me. @vinitshahdeo

Hello, @vinitshahdeo I want to work with some frontend issues, an you please assign me this issue? I want to try it.

Hello @vinitshahdeo, interested in working on this issue. Will be glad if you could assign this to me.

@vinitshahdeo  can I take this issue? I want to try it

Hello Everyone,
I'm assigning this issue to @anmolkaur18. Rest of you - please keep watching this repo, I'll be opening a few more beginner-friendly issues shortly.

Interested to contribute

Hello @preeti13456, Thanks for showing your interest. Sorry to say that it's already assigned to @anmolkaur18. Stay tuned, we'll be opening more issues soon.

@vinitshahdeo can I take this issue if it hasn't solved yet?

@jainpawan21 Could you please assign this issue to me. I'd like to work on it.


profiles.yml file [ERROR INVALID]

I am facing the below issue, can anyone help??
I am dockerizing the dbt and below is docker file
FROM python:3.8.5
Update and install system packages
RUN apt-get update -y &&
apt-get install --no-install-recommends -y -q
git libpq-dev python-dev &&
apt-get clean &&
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
Install DBT
RUN pip install -U pip
RUN pip install dbt==0.19.1
COPY /root/.dbt
WORKDIR /root/.dbt
profile name is matching in both profiles.yml and dbt_project.yml, and profiles.yml is good
and in dbt_project.yml i am using version:1.0.0 and config-version:2
when I am running in my  local with the  image build from docker file using command, everyrhing is working fine
docker run -v github/profiles.yml/:/root/.dbt/profiles.yml dbt debug --profiles-dir /root/.dbt
github/profiles.yml( its the path of new profiles.yml mounting at run time in docker run)
but when i am running in codefresh as pipeline with same command
docker run -v github/profiles.yml/:/root/.dbt/profiles.yml dbt debug --profiles-dir /root/.dbt
I am getting the below error
using profiles.yml file at /root/.dbt/profiles.yml
using dbt_project.yml file at /root/.dbt/profiles.yml
configration :
profiles.yml file [ERROR INVALID]
dbt_project.yml [ok found and valid]
profile loading failed for following reason:
Runtime error
could not find profile named ‘cdm’
can you help me why i am facing the issue with profiles.yml in codefresh, whereas in local its working fine (

@hsanjaysharma93 sounds frustrating! before I can help, can you please:

properly format your docker image code snippet using triple backtick (`) like this?

can you share what your profiles.yml looks like (with credentials removed)?
can you run the container in interactive mode and run dbt debug successfully?

closing -- please open again if you have more information to share


3D forward modelling

hi FabioLuporini, are there any examples of forward modelling using a 3D velocity model ?

All examples in examples/seismic are setup 3D velocity models. If you are looking for a jupyter notebook, we haven't made one for didactic reasons but we might consider adding one

Thank you @mloubout for reply. Currently I am working on your example 14_creating_synthetics.ipynb, it is throwing some dependency errors. 1) No module named 'osgeo' >> I tried to install gdal as per github suggestion. still facing same issue with theano
Any suggestions.!!!

hi @mloubout , I have created a 3D depth velocity model having three layers in it(1.5,2,2.5 Km/s) . Designed survey consisting of 6 receiver lines( each rx line consist of 51 Rx's) total Rx's = 306. and sources 5 sources in the between the six Rx's lines. Now I am trying to run fwd operation using devito. I am getting all shots involved. I need one shot at a time and every shot data need to be identified in rec.data by using shot_id in it. How can I do that?

There is some current outstanding issues with installing gempy properly we are looking into but we are dependent on their progress with stable install.

Are these install issues with GemPy still outstanding? Other people have reported that the notebook was running smoothly again relatively recently, although it still needs some tidy up to reflect improvements made on the GemPy side.


[Project] Prototype fundraiser and collective profiles

Purpose
Explore ways to address the two distinct functions of “fundraising” and “telling the story of a collective” via new profile pages
Coda entry (private link)

This week

[ ] Deploy preview fundraiser and profile pages behind feature flag

This week

[ ] Add basic editing to fundraiser profile page (cover image/video, title, description, color)

This week

[ ] Add list of expenses, and some kind of placeholder page for individual expenses to understand relation between profile pages and expense permalinks etc


[NFC] Refactor Override Fixit Emission

Refactor diagnostic emission so it lazily emits notes and fixits.
This is a necessary evil in a world where an arbitrary request can also
emit diagnostics, especially circularity diagnostics.  In the future, we
should assert in the evaluator that there is no active diagnostic to
catch the rest of these.

@swift-ci please smoke test

⛵


Decorator support

It would be cool to do this:
#[schedule("0 * * * *")]
fn task_hourly() { ... }

Blocked until #[proc_macro_attribute] stablizes


Getting rid of the Flash of Unstyled Content?

When the page loads, even if all that's on there is 1 equation, you first see the unstyled equation, then a half a second later it renders with MathJax (I'm on Safari).
Is there a way to prevent this?  Maybe forcing rendering at a specific point?

The FOUC problem comes from the plugin named fast-preview,  close it plz ~
MathJax.Hub.Config({
  extensions: ["fast-preview.js"],
  "fast-preview": {
    disabled: true
  }
});

@Mohanson, at the time this issue was started, the fast preview didn't exist, so that is certainly not what the poster was concerned about.  As discussed above, the issue is that the original TeX code (or whatever format was used) will be displayed until MathJax loads all its components and processes the math.  That is a different issue, and will still be the case even with fast preview turned off.
Also, if you are just going to disable face preview, why load it in the extensions array in the first place.  The reason for the disable option is that fast-preview is loaded by the combined configuration files (no need to add it to extensions by hand), so there needs to be a way to turn it off in that situation.

I know this is a closed issue, but I'd like to suggest a modified workaround to the one @dpvc  suggests that uses shortcodes and Mathjax 3:
Put this in the page source somewhere. I put it in layouts/partials/head-additions.html, but perhaps that is specific to the ananke theme:
{{- if or (.HasShortcode "mathjax/block") (.HasShortcode "mathjax/inline") -}}

{{- end -}}

Put this in layouts/shortcodes/mathjax/block.html:

{{ .Inner }}

And this in layouts/shortcodes/mathjax/inline.html:
{{ .Inner }}

Now you can put this in your page source:
Mathjax block:

{{< mathjax/block >}}
\[a \ne 0\]
{{< /mathjax/block >}}

Inline shortcode {{< mathjax/inline >}}\(a \ne 0\){{< /mathjax/inline >}} with
Mathjax.


Showing Instant Payment Method if showPayButton is set to false

Summary
Forcing instant payment method button to show up if showPayButton is set to false. By default, it should always show up.
Fixed issue: COWEB-1075

I presume you've tested this? And all is working as it should?

I tested it on our playground using Drop-in. It works fine!


Self-signed Certificate

Is it possible to change this such that the following could be avoided?
npm ERR! request to https://registry.npmjs.org/ansi-regex/-/ansi-regex-2.1.1.tgz failed, reason: self signed certificate in certificate chain

This has nothing to do with this package specifically. Use https://npm.community for npm support questions.


Enhanced Vector Builder

Pull Request Description
Manual implementation of vector builder that avoid any copying (if the initial capacity is exact). Moreover the builder optimizes for  storage of double and long values - if the array homogeneously consists of these values, then no boxing happens and only primitive types are stored.
Important Notes
Not sure how to write unit tests for Array_Builder and where to place them. However the builder is tested a lot by all library tests.
Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Java, style guides.
All code has been tested:

[x] Unit tests have been written where possible.

Not sure how to write unit tests for Array_Builder and where to place them.

Could you please clarify? I'd suggest writing them in Enso and placing in test/Tests/src/Data/Array_Spec.enso or next to it (Array_Builder_Spec.enso). I think it may be worth testing a few scenarios where the array is created with longs/doubles and then converted to objects because a null or object of different type is added.

I've just compared bencharking results:

the develop branch
[the current branch)[https://github.com/enso-org/enso/actions/runs/3563214235)

There is no significant difference.

worth testing a ... because a null or object of different type is added.

There was a problem with null: Fixed in 76d2f38


ElevatedButton style applying wrong vertical padding

Steps to reproduce
Setting the ElevatedButtonTheme ButtonStyle padding doesn't seem to correctly reflect the requested vertical padding.
It seems to be the vertical padding ONLY, my tests so far have only been on windows.
Expected results
The padding reports as the desired vertical padding from the ButtonStyle settings.
Actual results
The vertical padding is 8 pixels less than it should be.
Code sample
Here is the code for setting the ElevateButton style
  ElevatedButtonThemeData get elevatedButtonTheme =>
      ElevatedButtonThemeData(style: defaultElevatedButton);

  ButtonStyle? get defaultElevatedButton => ButtonStyle(
      backgroundColor:
          MaterialStateProperty.resolveWith<Color>((Set<MaterialState> states) {
        if (states.contains(MaterialState.pressed)) {
          return theme.dividerOnPrimary_65p;
        } else if (states.contains(MaterialState.hovered)) {
          return theme.dividerOnPrimary;
        } else if (states.contains(MaterialState.focused)) {
          return theme.blue100;
        } else if (states.contains(MaterialState.disabled)) {
          return theme.blue100.withOpacity(0.5);
        }
        return theme.blue100;
      }),
      shape: MaterialStateProperty.resolveWith<OutlinedBorder?>(
          (Set<MaterialState> states) {
        if (states.contains(MaterialState.focused)) {
          return RoundedRectangleBorder(
              borderRadius: BorderRadius.circular(8),
              side: BorderSide(color: theme.primaryBg, strokeAlign: -3.0));
        }
        return RoundedRectangleBorder(borderRadius: BorderRadius.circular(8));
      }),
      textStyle: MaterialStatePropertyAll(theme.txtTheme.headlineMedium!),
      padding:
          const MaterialStatePropertyAll(EdgeInsets.fromLTRB(24, 16, 24, 16)),
      foregroundColor:
          MaterialStateProperty.resolveWith<Color>((Set<MaterialState> states) {
        if (states.contains(MaterialState.focused) ||
            states.contains(MaterialState.disabled)) {
          return theme.primaryBg;
        } else if (states.contains(MaterialState.hovered) ||
            states.contains(MaterialState.pressed)) {
          return Colors.white;
        }
        return theme.primaryBg;
      }),
      overlayColor: const MaterialStatePropertyAll(Colors.transparent),
      surfaceTintColor: const MaterialStatePropertyAll(Colors.transparent),
      splashFactory: NoSplash.splashFactory);

Here is the button usage
        ElevatedButton(
            onPressed: () {},
            child: const Row(
                mainAxisAlignment: MainAxisAlignment.center,
                children: [
                  Icon(Icons.square_outlined),
                  SizedBox(width: 8),
                  Text('Button'),
                  SizedBox(width: 8),
                  Icon(Icons.square_outlined)
                ])),

Screenshots or Video
Here is a snapshot of the widget details tree:

You can see very clearly that the padding is 8 pixels too small in the vertical directions. It's reporting 8 and should be 16. If i change my padding to 18 the padding becomes 10. As far as I can tell something just isn't cascading right.
Logs
Logs
[Paste your logs here]

Flutter Doctor output
[√] Flutter (Channel stable, 3.19.4, on Microsoft Windows [Version 10.0.22631.3447], locale en-US)
• Flutter version 3.19.4 on channel stable at C:\Users\Dallas\Documents\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 68bfaea224 (3 weeks ago), 2024-03-20 15:36:31 -0700
• Engine revision a5c24f538d
• Dart version 3.3.2
• DevTools version 2.31.1
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
• Android SDK at C:\Users\Dallas\AppData\Local\Android\sdk
• Platform android-34, build-tools 33.0.1
• Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop Windows apps (Visual Studio Professional 2022 17.9.4)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Professional
• Visual Studio Professional 2022 version 17.9.34714.143
• Windows 10 SDK version 10.0.22000.0
[√] Android Studio (version 2022.2)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
[√] VS Code (version 1.88.0)
• VS Code at C:\Users\Dallas\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.86.0
[√] Connected device (4 available)
• sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
• Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22631.3447]
• Chrome (web)                 • chrome        • web-javascript • Google Chrome 123.0.6312.106
• Edge (web)                   • edge          • web-javascript • Microsoft Edge 123.0.2420.81
[√] Network resources
• All expected network resources are available.
• No issues found!

Hi @dallas1287
This is the intended behavior, please see https://github.com/flutter/flutter/issues/137411#issuecomment-1815019901. Closing this as a duplicate of https://github.com/flutter/flutter/issues/137411.

I think it should be improved to warn users about that. Please also share your thoughts on #137411. Thanks!


Lack of description for the dotnet.exe

not sure where to post this so posting in multiple locations.
Can we have a description for the dotnet.exe (for Windows)?
Currently it just shows up in Task Manger when running with no description and just displaying the exe name "dotnet"
A more meaningful description would be useful mentioning that this is the Core version and probably the version number in there.
".NET Core runtime" or something.

File it here https://github.com/dotnet/cli/issues

Thanks for moving it for me.


how to configure the DetectNet for single object

Hi,
I dont want to train model with new image I want to use pre-train model.
but i dont want multiple object to detect on my video input.
I want only one object to detect "person" and box only the person. how i can configure the DetectNet?

Hi @immnas, in the labels.txt of the model you want to use, change the names of the other classes that you want to ignore to void


Could db be protected?

I don't want   $controller->model->db->method() valid
I want $model->db be protected,  only $model->db->method() valid
how to do?

What in the world are you even attempting to accomplish? Assuming you want do this? (First Example)
This is a bug tracker, not a discussion forum.
Register here  for CI usage inquiries.


VScode-fhs alters Terminal such that julia-bin segfaults

Describe the bug
After upgradeing to channel 22.05 I no longer can use julia (from julia-bin) within vscode (from vscode-fhs).
Steps To Reproduce
Steps to reproduce the behavior:

install julia-bin and vscode-fhs
open vscode and the terminal within it
try to execute julia on the terminal
within julia run import Pkg; Pkg.status()
This is will throw a [1]    2539 segmentation fault (core dumped)  julia

Executing the same steps in a normal terminal (not within vscode-fhs) will run correctly.
And also before the upgrade to channel 22.05 it worked all correct.
Expected behavior
VSCode is a tool for programming, hence its integrated terminal should work with normal programming languages executables like julia.
Screenshots
in vscode

in konsole

Additional context
This renders vscode-fhs pretty unusable, as also the Julia extension does not work correctly
Notify maintainers
@eadwu @synthetica @maxeaubrey @bobby285271
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
- host os: `Linux 5.18.10, NixOS, 22.05 (Quokka), 22.05.1711.c06d5fa9c60`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.8.1`
- channels(root): `"nixos-22.05, nixos-unstable"`
- channels(MYUSERNAME): `"nixos-21.05.1226.f77036342e2"`
- nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

This is probably https://github.com/NixOS/nixpkgs/issues/169464

I'm seeing something similar but with vscode-fhs and flutter.  Running flutter inside the vs code terminal results in Segmentation fault (core dumped).  I tried installing flutter inside fhsWithPackages (as seen below) and just installing flutter separately, but neither way seemed to help.
  programs.vscode = {
    enable = true;
    package = pkgs.vscode.fhsWithPackages (ps: with ps; [
      unstable.flutter
      unstable.dart
      android-tools
      android-studio
    ]);
  };

Please post more information like a stacktrace or strace.


would like a validate HTML pipeline

would like a pipeline for this plugin
https://www.npmjs.com/package/gulp-html-validator

https://github.com/kenzanlabs/pipeline-validate-html/pull/

@paul-barry-kenzan
Hooray, this has been published!  👍
https://github.com/kenzanlabs/pipeline-validate-html/
Please add this to the active projects section in this repo please!

@thescientist13
https://github.com/kenzanlabs/keystone/pull/39

added to active projects!
https://github.com/kenzanlabs/keystone#active-projects


Getting Chat Transcript of Completed Chat

Below call gets through well when customer Ends the Chat, however, if Chat is ended by CSR and customer has not closed the chat window or ended Chat, retruns a 500 internal server error.
var ParaTranscript = _paraSvc.GetChatTranscript(chatid);

hi manish. this sounds like a product issue. I'l try to recreate and submit a defect.


OCPBUGS-38474: copy image-registry AdditionalTrustedCA configmap into HC openshift-config

Since this wasn't caught by a test, how making sure that there's a test that covers this?

/retest

/lgtm

/cherry-pick release-4.17


Latest Nuget Package Embedds Jquery into Output

The latest version of either bridge or the bridge.jquery package seems to embedd a version of jquery into the output. Is there a way to prevent this? I have a specific version of jquery that kendo ui needs and this causes jquery to be double included breaking kendo ui.

Hello @groogiam! thanks for the report.
To do so would, according to Global Configuration documentation would be:
  "resources": [
    {
      "name": "Bridge.jQuery2#jquery-2.2.4.js",
      "extract": false
    },
    {
      "name": "Bridge.jQuery2#jquery-2.2.4.min.js",
      "extract": false
    }
  ]

In your Bridge.json. Notice if you just rebuild the project you may still see the jquery files in the folder, you may need to manually remove it once it was generated. But once this setting is set, it should stop dumping those files.
Hope this helps!

Thanks.


fixing dateformat

fixing odd dateformat handling that was broken.
this is one of the issue in https://github.com/Odin-SMR/qsmr/issues/2

Congrats, you need to setup a github workflow too it seems. 😄


Allow save/load of polynomial coefficients

Some function implementation (e.g. current meta tanh) requires a lot of polynomial approximations.
Those approximations are often used in multiple variants (scalar, v2, v4, f8). Currently they have to be found / verified each time.
An interesting feature could be to allow saving/loading polynomial coefficient from an external file.
With the proper predicate / verification, this feature would speed up some generations a lot.

[Request for Comment]
The idea will be to have a format containing: a list of polynomial approximations
Each approximation would be uniquely identified by

formal approximated function expression
approximation range
degree
coefficient formats
error bound
forced odd / forced even / no constraint

Each approximation would be stored as an indexed map of numerical coefficients

approximated_fct: exp(x)
type: piecewise_polynomial_uniform_deg
approximation_range: Interval(0, 1)
error_target: dar(2**-25)
approximation:
  - step:
      sub_approx_range: [0, 0.5]
      sub_approx: Polynomial([0, 1])


Merging assemblies with a reference to Autofac

I am trying to ILMerge a project containing Autofac.dll and that fails on that dependency.
The command I am using is: ILRepack.exe /out:Merged.exe ILRepackTest.exe Autofac.dll
Expected outcome
To have ILRepackTest.exe and Autofac.dll to be merged to Merged.exe
Observed output is the following exception:
Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'System.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null'
at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters)
at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name)
at Mono.Cecil.DefaultAssemblyResolver.Resolve(AssemblyNameReference name)
at Mono.Cecil.MetadataResolver.Resolve(TypeReference type)
at Mono.Cecil.ModuleDefinition.Resolve(TypeReference type)
at Mono.Cecil.TypeReference.Resolve()
at ILRepacking.ReferenceFixator.FixReferences(Collection`1 attributes)
at ILRepacking.ReferenceFixator.FixReferences(MethodDefinition meth)
at ILRepacking.ReferenceFixator.FixReferences(TypeDefinition type)
at ILRepacking.ILRepack.Repack()
at ILRepacking.ILRepack.Main(String[] args)
Note
My understanding is this is because Autofac is created as a portable class library. See https://github.com/autofac/Autofac/wiki/Frequently-Asked-Questions

Unfortunately this still doesn't work. Just try to merge a .NET 4.5 assembly with Autofac and the same problem with System.Core appears.

Problem still there with ILRepack 1.26

Strange, there's now a passing test that round trips Autofac net45 assembly (with no error).
Do you have an easy reproduction path ? (ideally that would be the merge of a set of dlls available from NuGet packages)

Yes, just merge a DLL that references Autofac and then try to merge that one in another .DLL that also references Autofac, preferably a different version.

This also happens without Autofac. It seems to be a problem with Assemblies from .net 4.5. I have a simple application that references System.Core and several Azure Management assemblies.

If someone can provide the simplest project or assembly that causes this when merged, I can have a look.
Autofac NuGet package only has a net40 dll and a portable-win+net40+sl50+wp8 one, tests are running with the former only so far.

I am trying to ILMerge a libraries from zip archive
The command I am using is:
mono ILRepack.exe /targetversion:v4 /out:test.dll Autofac.dll Nitro.Async.dll

specify the path of your dll in the command line
ILRepack.exe /out:Merged.exe ILRepackTest.exe C:\My_dll_Path\Autofac.dll


Provide default layouts

Hi,
It would be very nice including some default layouts in the library, to use with:
TutoShowcase.from(this)     .setContentView(R.layout.tuto_sample)
Thanks & Regards,
Marcello

why, it would have default texts & icons, it's not very useful

Well, the library should include the ability to set text and image on default layouts ;)

why ? :)

Because, if an application has 30 (for example) TutoShowcase pages to show... a default layout would be nice :) Don 't you agree?

Yes, it would make life easier with default layout, where it would be possible to just change the text for example. My case is where I have 20 examples of TutoShowcase and I have created 20 layouts and all the 20 has the same design, the only thing that changes is the text inside it.


Can --add-file and --add-folder be merged?

Do --add-file and --add-folder really need to be separate options? Couldn't --add-file take either regular files or folders as its argument?
For example: https://github.com/octave-app/create-dmg/commit/ccdaeca5010303f65bd8061eef11ac8a8f642375.

You're right, those should be merged into one. In fact, the current code is the same for booth file and folder, since they use -a that basically is -dR.
So probably just removing the folder steps and changing the files description will do.
Keeping the --add-folder argument (even if it uses ADD_FILE_TARGETS) could be good for not breaking current user scripts.

Yeah, let's make it a hidden, undocumented option for back-compatibility. I'll make a PR.

#88


Set strictNullChecks true in lodestar - part 2

Parallelizable effort to tackle #885. Sets strictNullChecks = true in a single package so eventually it can be set in the root tsconfig.
Note: There are 80 errors! (down from 271 on part 1) when compiling the current lodestar package with strictNullChecks = true. Extends the progress made on https://github.com/ChainSafe/lodestar/pull/1289 to prevent too big changes at once potentially creating conflicts with other PRs. The PR that manages to bring the error count to 0 will actually set strictNullChecks = true.

CC Reviewers: Only relevant changes are around nullish types where it will (a) throw an Error or (b) ignore subsequent logic. All the rest of logic is meant to be identical, so I'll appreciate help on making sure it didn't ignore any implementation details.

@mpetrunic in lodestar/packages/lodestar/src/chain/factory/duties/index.ts assembleAttesterDuty was sending invalid AttesterDuty that contained null types if is committeeAssignment false.
https://github.com/ChainSafe/lodestar/blob/1d916a6e8de045575c6eda0786b58eed0e6d32ea/packages/lodestar/src/chain/factory/duties/index.ts#L13-L16
Is this a good approach? Asking because now a test is failing. Otherwise, should the test be fixed or removed?
  1) assemble validator duty
       should produce empty duty:
     Error: No committeeAssignment for validator 2 at epoch 3
      at Object.assembleAttesterDuty (src/chain/factory/duties/index.ts:1:1818)
      at Context.<anonymous> (test/unit/chain/factory/duties/assembleValidatorDuty.test.ts:43:33)
      at processImmediate (internal/timers.js:439:21)
      at process.topLevelDomainCallback (domain.js:130:23)

Porting from issue https://github.com/ChainSafe/lodestar/issues/1402

Started node, stopped, restarted to this message:
2020-08-13 11:58:29  [CHAIN]            info: Found finalized state at slot 192, starting chain from there
2020-08-13 11:58:29  [NODE]             info: Starting eth2 beacon node - LODESTAR!
2020-08-13 11:58:29  [METRICS]          info: Starting metrics HTTP server on port 8008
2020-08-13 11:58:29  [DB]               info: Connected to LevelDB database at .medalla/chain-db
2020-08-13 11:58:37  [CHAIN]            info: Chain started, waiting blocks and attestations
2020-08-13 11:58:37  [CHAIN]            info: Found last known finalized state at epoch #0 root 0x0000000000000000000000000000000000000000000000000000000000000000
2020-08-13 11:58:38  [CHAIN]            info: Found 85 nonfinalized blocks in database from slot 192 to 316
2020-08-13 11:58:38  [CHAIN]            info: Found finalized block at slot 192,
        root=0x5ce25fca09469f8473c31213a213b8ebbd76eebc41b47c19f984c5dabee6fe3a
 ✖ Error: lastJustifiedBlock not in db
    at BeaconChain.initForkChoice (/home/cayman/Code/lodestar/packages/lodestar/lib/chain/chain.js:348:37)
    at async BeaconChain.restoreHeadState (/home/cayman/Code/lodestar/packages/lodestar/lib/chain/chain.js:321:5)
    at async BeaconChain.start (/home/cayman/Code/lodestar/packages/lodestar/lib/chain/chain.js:176:5)
    at async BeaconNode.start (/home/cayman/Code/lodestar/packages/lodestar/lib/node/nodejs.js:157:5)
    at async Object.run [as handler] (/home/cayman/Code/lodestar/packages/lodestar-cli/lib/cmds/beacon/run.js:96:3)

@wemeetagain Do you think this error was triggered when it shouldn't? Or it should happen and the underlying error should be addressed latter?

I think it was triggered when it shouldn't. When I switched to the master branch, using the same db, the startup swept past that point w/o error.

@wemeetagain I've reviewed the PR and in chain/chain.ts it only adds this new throw condition
https://github.com/ChainSafe/lodestar/blob/e50ce09f4a9348895d3f933d486a6092e18e8d76/packages/lodestar/src/chain/chain.ts#L116-L120
forkChoice/arrayDag/lmdGhost.ts I've reverted the strict NodeIndeces Map, there are now two main works:

Normalize the assertion of node existence with the null type instead of using the getters hasParent(), hasBestChild(), etc.
throw conditions in the class getters headNode(), getJustified(), getFinalized().

Should these throw conditions also be reverted?

:rofl:
@chainsafe/lodestar:   1 failing
@chainsafe/lodestar:   1) ArrayDagLMDGHOST
@chainsafe/lodestar:        update justified checkpoint after finalized checkpoint is set
@chainsafe/lodestar:          should update justified checkpoint - new justified is conflict to the previous justified:
@chainsafe/lodestar:      TypeError: Cannot read property 'bestChild' of undefined
@chainsafe/lodestar:       at ArrayDagLMDGHOST.isBestChildOfParent (src/chain/forkChoice/arrayDag/lmdGhost.ts:63:498)
@chainsafe/lodestar:       at ArrayDagLMDGHOST.onRemoveWeight (src/chain/forkChoice/arrayDag/lmdGhost.ts:53:33)
@chainsafe/lodestar:       at ArrayDagLMDGHOST.propagateWeightChange (src/chain/forkChoice/arrayDag/lmdGhost.ts:46:599)

https://github.com/ChainSafe/lodestar/runs/986369593#step:9:1486

re: fork choice, I think you should work only on the type-level, try not to change any runtime behavior

closing in favor of #1420


Can not customize changelogPreset

Describe the bug
It says here: https://github.com/lerna-lite/lerna-lite/tree/main/packages/version#--changelog-preset
While I have
https://github.com/vuepress-theme-hope/vuepress-theme-hope/blob/1b6b0dbc771a0e01c686cf94a1a120e6b011b517/lerna.json#L13-L77
From the logs:
lerna-lite info getChangelogConfig Auto-prefixing conventional-changelog preset "conventionalcommits"
lerna-lite info getChangelogConfig Successfully resolved preset "conventional-changelog-conventionalcommits"

It loads conventional-changelog-conventionalcommits successfuly, but I don't think any option is loaded, non of the header and releaseCommitMessageFormat configuration is working.
Expectation
changelog header and commit msg should be customized.
Reproduction
See https://github.com/vuepress-theme-hope/vuepress-theme-hope
Config are at https://github.com/vuepress-theme-hope/vuepress-theme-hope/blob/main/lerna.json#L13-L77
Command is pnpm lerna version
The result of the commit is at: https://github.com/vuepress-theme-hope/vuepress-theme-hope/commit/1b6b0dbc771a0e01c686cf94a1a120e6b011b517
The full log here:
><EMAIL_ADDRESS>release:version /home/mister-hope/projects/vuepress/vuepress-theme-hope
> lerna version

lerna-lite notice cli v3.3.3
lerna-lite info current project version 2.0.0-rc.38
lerna-lite info Looking for changed packages since v2.0.0-rc.38
lerna-lite info ignoring diff in paths matching **/__tests__/** **/*.md
lerna-lite info getChangelogConfig Auto-prefixing conventional-changelog preset "conventionalcommits"
lerna-lite info getChangelogConfig Successfully resolved preset "conventional-changelog-conventionalcommits"

Changes (7 packages):
 - vuepress-plugin-components: 2.0.0-rc.38 => 2.0.0-rc.39
 - create-vuepress-theme-hope: 2.0.0-rc.38 => 2.0.0-rc.39
 - vuepress-plugin-lightgallery: 2.0.0-rc.38 => 2.0.0-rc.39
 - vuepress-plugin-md-enhance: 2.0.0-rc.38 => 2.0.0-rc.39
 - vuepress-plugin-search-pro: 2.0.0-rc.38 => 2.0.0-rc.39
 - vuepress-shared: 2.0.0-rc.38 => 2.0.0-rc.39
 - vuepress-theme-hope: 2.0.0-rc.38 => 2.0.0-rc.39

? Are you sure you want to create these versions? Yes
lerna-lite info git Pushing tags...
lerna-lite info execute Skipping releases
lerna-lite success version finished

Lerna config and logs
No response
Environment Info
node v20.12.2
@lerna-lite/cli 3.3.3
@lerna-lite/publish 3.3.3
Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

I never used that option, it came from the original Lerna. I'm trying to keep the project up to date by using Renovate but all the conventional-changelog dependencies were updated just a few days ago as major versions and none of them were upgraded yet as you can see in the Renovate Dashboard. I would suggest you downgrade your conventional-changelog-conventionalcommits from 8.0 to probably 7.x
I've answered similar question in this Stack Overflow answer, but like I said, I have never used this feature personally (though I do use conventional-changelog-conventionalcommits for its breaking change detection with something like feat! and I actually used it last week but I'm on version 7.x).

For me 7.x is also not working, I will try to do that and provide --dry-run log later

I just tried it in dry-run mode and the types override works properly but considering that you're trying to use releaseCommitMessageFormat which seem to exists in conventional-changelog-config-spec, however I wouldn't be surprised that this property cannot be overridden because of command.version.message. However, it's just a guess because like I said that was implemented by the original author, but since the types override do work, that's the only guess I could come up with

I just tried it in dry-run mode and the types override works properly (with emojis) but considering that you're trying to use releaseCommitMessageFormat which seem to exists in conventional-changelog-config-spec, however I wouldn't be surprised that this property cannot be overridden because of command.version.message (have you tried to not set the prop?). However, it's just a guess because like I said that was implemented by the original author, but since the types override do work, that's the only guess I could come up with.

Thanks for the feedback, actually I am not focusing types with v7, but I think both commitmsg and header are not working.

update:
I have downgrade to v7 and update config like you suggest in https://github.com/vuepress-theme-hope/vuepress-theme-hope/commit/e192e704c004ccec71a97c21e1e71e552e0d7f28. I remove the command.version.message, and I update feat and feature header with test.
Dry run log:
mister-hope@MrHope-Lenovo:~/projects/vuepress/vuepress-theme-hope$ pnpm release:version --dry-run

><EMAIL_ADDRESS>release:version /home/mister-hope/projects/vuepress/vuepress-theme-hope
> lerna version "--dry-run"

lerna-lite notice cli v3.3.3
lerna-lite info [dry-run] > git rev-parse
lerna-lite info current project version 2.0.0-rc.41
lerna-lite info [dry-run] > git rev-list --count --all --max-count=1
lerna-lite info [dry-run] > git show-ref --verify refs/remotes/origin/dry-run
lerna-lite info [dry-run] > git remote update
lerna-lite info [dry-run] > git rev-list --left-right --count origin/dry-run...dry-run
lerna-lite info Looking for changed packages since v2.0.0-rc.40
lerna-lite info ignoring diff in paths matching **/__tests__/** **/*.md
lerna-lite info [dry-run] > git describe --always --long --dirty --first-parent
lerna-lite info getChangelogConfig Auto-prefixing conventional-changelog preset "conventionalcommits"
lerna-lite info getChangelogConfig Successfully resolved preset "conventional-changelog-conventionalcommits"

Changes (1 packages):
 - create-vuepress-theme-hope: 2.0.0-rc.41 => 2.0.0-rc.42

? [dry-run] Are you sure you want to create these versions? Yes
lerna-lite info [dry-run] > git add -- packages/create/package.json packages/create/CHANGELOG.md pnpm-lock.yaml CHANGELOG.md lerna.json
lerna-lite info [dry-run] > git commit -m v2.0.0-rc.42
lerna-lite info [dry-run] > git tag v2.0.0-rc.42 -m v2.0.0-rc.42
lerna-lite info git Pushing tags...
lerna-lite info [dry-run] > git push --follow-tags --no-verify --atomic origin dry-run
lerna-lite info execute Skipping releases
lerna-lite success version finished

I commited the result in https://github.com/vuepress-theme-hope/vuepress-theme-hope/commit/523b1931a003966a729e3e2236a19554e9f37cd1
The types are working! But I don't think the header or the releaseCommitMessageFormat is working.

Also I confirm the commit.version.message is not working even if I delete releaseCommitMessageFormat, so it just seems only types are working for me, but I need to adjust the header, and format the commit msg

I don't think the releaseCommitMessageFormat was meant to ever be supported, why can't you just use command.version.message? This message is provided to conventional changelog in every case and conventional-changelog is probably not using releaseCommitMessageFormat when message is also provided, I also don't want to change all the Lerna code related to conventional changelog... but really {{currentTag}} seems to be exactly the same as %v in message, so why not simply use that?

what about the header?

Most probably the same, have you tried version --changelog-header-message? That's what I use in Lerna-Lite itself

yes, command.version.changelogHeaderMessage is working, thanks.

The header options is not working as expected, see https://github.com/vuepress-theme-hope/vuepress-theme-hope/commit/d86a705901f306a75513b21ef7894e33ce4ac407

Yes that is the expected behavior since the common text of conventional commit "All behavior.." is a static text. The behavior of changelogHeaderMessage is really to prepend that text before the static conventional commit message, it is not meant to override the entire text but really to prepend it. I don't understand why you're trying to override a very similar message (you seem to only have 1 less line than original static message).
It's probably a good idea to support the header message eventually, but I don't have time at the moment to look at this further

I want to insert the magic comment after the description,  That means I can import the final region I want  Of the change log,  So that I can show it in my documentation site.
So if the change log is actually a web page,  Then I don't think the description is needed or necessary,  Also I would want another heading for that.  Currently the magic comment can be inserted but only before the description.

Like I said, it's the expected behavior, you can see the result of this behavior in Lerna-Lite changelog

This should be fixed in v3.4.0 but please note that as I mentioned earlier, I only added support for changelogPreset.header but did not support releaseCommitMessageFormat (though I now throw with an error mentioning to simply use version.message since the result is the same). I also saw from your config that you also wanted changelogPreset.header to work with an empty string, that will also work as shown below (I tried with --dry-run and below is the git diff of the change, notice the header is completely removed because it is set to an empty string)

@Mister-Hope just a side note, I see that you released a new version of your project couple days ago and you might be wondering why it didn't work, but the fact is that you did not update to Lerna-Lite 3.4.0 yet so it won't work until you update. You should also probably remove changelogHeaderMessage after updating since changelogPreset.header will be pulled and changelogHeaderMessage will be discarded. Good luck with your project, cheers


[$1000]  App allows to add link in code block and does not display the same on copy and send

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Send link in following format : Test
Observe that it displays link inside code block (till now, we have intentionally made sure to not display link in code block)
Hover and click on copy to clipboard
Paste in compose box and send
Observe that now, it does not display link in code block

Expected Result:
App should not display link inside code block and maintain same display format on copy to clipboard and send again as message
Actual Result:
App displays link inside code block if sent in specific format and on copy to clipboard and sending as normal message, it does not maintain the format
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.38-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/ece2ab63-c0c2-4f1c-a65c-b1632dee93f1
https://github.com/Expensify/App/assets/43996225/96e0f0fa-9c89-46c4-9c95-684095a34b51
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688796230285319
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f921043b5d238f9f
Upwork Job ID:<PHONE_NUMBER>254556672
Last Price Increase: 2023-07-11

Proposal
Please re-state the problem that we are trying to solve in this issue.
App allows to add link in code block and does not display the same on copy and send.
What is the root cause of that problem?
The following markdown input
[```code```](google.com)

is translated into html

code

from frontend by method ExpensiMark.replace applying code fence rule and link rule.
The backend corrects the above html into following html

code

which is translated into following markdown when clicking to edit the comment
```
[code](https://google.com)
```

Note the starting and ending anchor tag, , are same and translated into empty string.
So, the root cause of this issue is that the link rule doesn't skip to translate markdown link syntax if its alias text inside [] contains code fence tag
.
What changes do you think we should make in order to solve the problem?
To fix this issue, we should avoid translating link markdown syntax if its alias text part contains
 tag.
To achieve it, we can change following condition
https://github.com/Expensify/expensify-common/blob/d636fef3f22b4e5fcf61333ddc89a5d2e08cacc9/lib/ExpensiMark.js#L454
of method modifyTextForUrlLinks by checking if the alias text part, match[1], includes
 tags
if (abort || match[1].includes('
')) {

to skip replacing link syntax to html.
What alternative solutions did you explore? (Optional)
N/A

Reviewed, adding external.

I'm not familiar with ExpensiMark 😓, so I gonna trust your assessment @thesahindia
assigning @eh2077

@thesahindia The PR https://github.com/Expensify/expensify-common/pull/558 for expensify-common is ready for review.

@thesahindia It seems puller bear failed to assign people to the PR and I can't seem to assign you, can you leave a comment in the PR so I can assign you? I think it works after that happens

@thesahindia @eh2077 can you check @parasharrajat's comment above ⬆

@hayata-suenaga @thesahindia @pecanoro
I know @eh2077 has been assigned for this issue.
But I could not stop to propose more improved approach. I think if (abort || match[1].includes('
')) { is not reasonable (ofc, it results expected behavior), because modifyTextForUrlLinks function is called from both of link and autolink rule and then we can't figure out which rule needs the condition, so better to add a tweak on MARKDOWN_LINK_REGEX pattern. (simply add (?!\\[[\\s\\S]*
[\\s\\S]*\\]))
const MARKDOWN_LINK_REGEX = new RegExp(`(?!\\[[\\s\\S]*<pre>[\\s\\S]*\\])\\[([^\\][]*(?:\\[[^\\][]*][^\\][]*)*)]\\(${MARKDOWN_URL_REGEX}\\)(?![^<]*(<\\/pre>|<\\/code>))`, 'gi');

Your thoughts ?

@Antasel thank you very much for sharing your detailed thoughts. If you think there is still an issue left, could you post your finding as a bug report? Otherwise, @eh2077 is already working on it and we gonna go with their proposal 🙇

ok, i am just gonna contribute more improved solution. thanks for your reply

Invites have been sent to @eh2077 @thesahindia and @dhanashree. The final step is payment. I am going OOO so please can you pay out these? Thank you BZ team member!

Thanks @zanyrenney, @Christinadobrzyn,
Invite accepted.

Ready for payment
@thesahindia should we have a regression test for this?

nudge @thesahindia ^

Paying out in Upwork - https://www.upwork.com/jobs/~01f921043b5d238f9f
@dhanashree-sawant paid through Upwork for reporting the bug $250
@eh2077 paid through Upwork for contributor work $1000 + $500 speed bonus
@thesahindia paid through NewExpensify $1000 + $500 speed bonus

Created Regression Test - https://github.com/Expensify/Expensify/issues/306418
Closing this GH

$1,500 payment approved for @thesahindia based on BZ summary.


Add option to install collections as dependencies in the docker image

As we have some checks for e.g. module names it would be good to provide a way for the docker file to install custom collections.

ansible-galaxy is already included, just use it.

ansible-galaxy is already included, just use it.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

Completed issue #1


Enum property of "Name" does not convert correctly to JavaScript

When converting a enumerator to JavaScript, naming a value of the enum as "Name" or "name" causes the JavaScript to be incorrectly evaluted to "$name".
Steps To Reproduce
https://deck.net/51cceb8b543b043a5f2602dec3b29115
public enum OtherEnum
{
    One = 1,
    Two = 2,
    ContentName = 3,
    name = 4,
    Name = 5
}

Expected Result
    Bridge.define("OtherEnum", {
        $kind: "enum",
        statics: {
            fields: {
                One: 1,
                Two: 2,
                ContentName: 3,
                name: 4,
                Name: 5
            }
        }
    });

Actual Result
    Bridge.define("OtherEnum", {
        $kind: "enum",
        statics: {
            fields: {
                One: 1,
                Two: 2,
                ContentName: 3,
                $name: 4,
                $Name: 5
            }
        }
    });

See also

#2955

Static member name cannot have 'name' as naming. The scope of a static member is a class (class is a function in javascript). In javascript, each function has some predefined properties which we cannot replace by own. 'name' is one of them.
That's why Bridge add $ prefix to such name. The single change which we should change that only lower case name should be prefixed.


Add way to enable Firebase debug logging at runtime and build time.

Is there a way for the testers to to test analytics?
If I want to send iOS code to Archive (for ad hoc distribution) all the arguments are not passed. Is there a way to pass -FIRDebugEnabled argument so my QA team will be able to test analytics using Debug view in Firebase?

Are you including https://github.com/firebase/firebase-ios-sdk/blob/6d6ed82d4200125a0642ffc513cb6fe4e3c1b5d3/Firebase/Core/Public/FIRLoggerLevel.h ?

https://developer.apple.com/documentation/swift/imported_c_and_objective-c_apis/importing_objective-c_into_swift
On Wed, Nov 21, 2018 at 3:27 AM tcurkovic-codecacao <
<EMAIL_ADDRESS>wrote:

My app delegate is in Swift, not in Objective - C. I have imported
Firebase. I have this line
import Firebase
How should I import FIRLoggerLevel.h in swift code?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/firebase/quickstart-unity/issues/242#issuecomment-440630654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFw1RBMrjkbNFB6SOYbpe5prj4WEO7JHks5uxTiLgaJpZM4YOd7x
.

Thanks for the help. I have realised I do not need to add anything to the Bridging header file. I was just calling the FirebaseLoggerLevel enum. So I have made these changes to the AppDelegate.swift. Now I have lines
FirebaseApp.configure()
FirebaseConfiguration.shared.setLoggerLevel(FirebaseLoggerLevel.max)

The app now compiles. But unfortunately there are no events in the Firebase console. Do I need to add any other code? Am I using this thing wrong?

Hi @tcurkovic-codecacao ,
Sorry to leave this idle for so long! Did you ever get your runtime code working?
--Patrick


Area2D node not detecting StaticBody2D nodes entering it

Tested versions
-v4.2.2.stable.official [15073afe3]
-v4.3.stable.official [77dcf97d8]
System information
Windows 11 home x64 Godot v4.3 and v4.2.2 Forward+
Issue description
The Area2D node isn't detecting when a StaticBody2D node is entering its CollsionShape2D node. For some reason, it will detect it if the Area2D node is being moved or if the monitoring property is flipped on and off in which case it works for a very short time. The Area2D node is still able to work with the AnimatableBody2D and CharacterBody2D nodes.
Steps to reproduce
See MRP Below. This should be very self-explanatory.
Minimal reproduction project (MRP)
collsion_test.zip

Thanks for the report! Consolidating in https://github.com/godotengine/godot/issues/17238 and https://github.com/godotengine/godot/issues/74300.


Document supported browser versions and protocols

It would be helpful to developers considering using this library if the README documented the browsers and protocols currently supported by the library, and the configurations that are expected to be supported in the future. (Maybe the version of Node, too.)
Something like:

GCM (tickle)
GCM (bodies)
VAPID

Chrome 47+
x
NA
NA
supported now

Chrome 50+
x
x
NA
supported now

Chrome 51+ (?)
x
x
x
will be supported

Firefox 44+
NA
NA
NA

Firefox 46+
NA
NA
x
will be supported

Browsers in italics have not been released as of April 2016.

Some sort of guidance regarding how production-ready the library is would also be useful.

Ta for this, will hopefully take a look some point soon and tag you in any PRs

@gauntface tag me too! :)

I really like the idea of us including a compat table in the README like the one @ithinkihaveacat proposes.

Additionally, a util that returns an ENUM by parsing navigator.userAgent will be handy. I'll raise a PR for this.

@ameyakarve, I don't follow the use case for this util

@gauntface So, if I were to implement support only for clients that support data-only pushes (which is much easier to maintain at the server side), it would be nice to have something that says whether that would be supported. I will probably be writing for work; I suppose others could find it useful too?

@ameyakarve UA sniffing is not needed at all, and generally a bad practice.
All of the different situations can be detected using feature detection.
@ithinkihaveacat:
FF 46 is supported by this library. They changed it before it went to stable so that it matched the latest spec (at that time). FF <= 45 doesn't have an 'auth' value in the subscription, which is easy to detect, but it also requires some strings to be changed too. It's not too difficult to do, but I don't know that it's a priority, what with them being superseded by a new stable version.

@wibblymat Would you have snippets for that? Is it as simple as looking at what the subscription object returns or am I missing anything?

examining the subscriptionfor the author key would be enough. For chrome you'll still need to check for gcm endpoint and change accordingly.


Update figures in the METexpress User's Guide

The METexpress User's Guide includes images from METexpress v2.6.1, while we are about to release v4.1.2. The interface and plot appearances have changed since then, and the images need to be updated.
Time Estimate
1-2 hours
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee

[ ] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[ ] Select component(s)
[ ] Select priority
[ ] Select requestor(s)

Projects and Milestone

[ ] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[ ] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[ ] METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of development.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into development.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

The figures in the METexpress User's Guide have been updated to feature images from METexpress v4.1.2, the (as of now) latest version.


feat: useOnPropsChange from @qlik-oss/nebula-table-utils

This is the first PR that integrates @qlik-oss/nebula-table-utils into SNT project. It's main point is to import useOnPropsChange hook from the shared repo.

IMO the commit type should not be feat. Most likely it's a refactor


Extend MQTT leg movement commands to "all legs"

Some test commands, like MLA, Move Leg to Angles, take a leg number as an argument. We could extend these commands by having them interpret leg number zero as meaning do the command for all 6 legs instead of just one.

for MLA (test move leg(s) to specified servo angles) and MLC (test move leg(s) to specified local coord’s), interpret leg number specified as zero to mean do the command for all 6 legs.
Code changes completed and tested. Need to be really careful with local coordinates. Think I'll add a command MLRH - move legs relative to home which is easier to use in most cases.


Interacting with the database in the test teardown after calling the parent teardown is broken

Laravel Version
10.37.1
PHP Version
8.2.11
Database Driver & Version
MySQL
Description
When overriding teardown to cleanup something in your tests the behavior is now broken in v10.37.1 due to the changes with #49327 , the database connection is gone.
imo behavioural changes like this are never allowed in bugfix-releases.
   │ Illuminate\Contracts\Container\BindingResolutionException: Target class [config] does not exist.
   │
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:912
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:795
   │ /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:955
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:731
   │ /var/www/vendor/laravel/framework/src/Illuminate/Foundation/Application.php:940
   │ /var/www/vendor/laravel/framework/src/Illuminate/Container/Container.php:1454
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:170
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:136
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/DatabaseManager.php:101
   │ /var/www/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1819
...

Steps To Reproduce
    public function tearDown(): void
    {
        parent::tearDown();
        $this->model->delete();
    }

Sorry about that. We'll revert it: https://github.com/laravel/framework/pull/49361

@rikvdh I think this is expected behavior:

parent::setUp() must be called firstpublic function setUp(): void
{
    parent::setUp();
    // Your Code Goes Here
}

parent::tearDown() must be called laterpublic function tearDown(): void
{
    // Your Code Goes Here
    parent::tearDown();
}

While this was a significant change, your original code has a major problem.
@driesvints @taylorotwell Why did you closed #49362?

It is odd that model deletion works after parent::tearDown(), since facades are deactivated after parent::tearDown().

This doesn't work:public function tearDown(): void
{
    parent::tearDown();
    DB::table($this->model->getTable())->where('id', $this->model->id)->delete();
}

UNEXPECEDLY this works:public function tearDown(): void
{
    parent::tearDown();
    $this->model->delete();
}

@mpyw

.. your original code has a major problem.

It might not be, by definition, my code, if you have 100's of testcases with 1000+ tests written by 10+ developers over the past 10 years things like this slip in. "My code" has 100's of 'major problems' every day, and fixing up 10 year old tests because behavioral changes in a bugfix release is no fun.

@rikvdh It is hard to deal with code that is several years old, and I understand your difficulty. I do feel you are correct to the point where it was reverted once by this report, as it was certainly unexpected as a fix to 10.x. However, I felt it was odd that the resubmission for 11.x was reverted, so I raised a discussion. Thank you for your cooperation.

https://github.com/laravel/framework/discussions/49373


Invalid PNG data, size ###

Environment:
Ubuntu 16,
GPU:  GTX 1060/6Mb
Tensorflow: v1.5
CuDNN 7.*
Cuda 9.1

Datasets i've created and tried to train contain 120 000(small) - 15 000 000 (big) images(png)/labels.
tfrecords created succesfully
training comes up with the same error after a few hundred/thousand steps:
aocr train ./tfrecords/train.tfrecords steps-per-checkpoints=500 batch-size=512 --num-epoch=5 --max-predictions=18 --max-height=32 --max-width=159
. . . . . . .
2018-05-23 20:33:17,104 root  INFO     Step 158: 0.776s, loss: 1.708350, perplexity: 5.519846.
2018-05-23 20:33:18,003 root  INFO     Step 159: 0.776s, loss: 1.719668, perplexity: 5.582677.
2018-05-23 20:33:18,899 root  INFO     Step 160: 0.780s, loss: 1.714975, perplexity: 5.556535.
2018-05-23 20:33:19,830 root  INFO     Step 161: 0.808s, loss: 1.615288, perplexity: 5.029339.
2018-05-23 20:33:20,736 root  INFO     Step 162: 0.776s, loss: 1.676965, perplexity: 5.349294.
Traceback (most recent call last):
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1350, in _do_call
return fn(*args)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1329, in _run_fn
status, run_metadata)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/errors_impl.py", line 473, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.InvalidArgumentError: Invalid PNG data, size 837
[[Node: map/while/DecodePng = DecodePngchannels=1, dtype=DT_UINT8, _device="/job:localhost/replica:0/task:0/device:CPU:0"]]
[[Node: map/while/truediv_1/x/_64 = _HostSendT=DT_INT32, client_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_870_map/while/truediv_1/x", _device="/job:localhost/replica:0/task:0/device:GPU:0"]]

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/aocr", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/aocr/main.py", line 252, in main
num_epoch=parameters.num_epoch
File "/usr/local/lib/python3.5/dist-packages/aocr/model/model.py", line 380, in train
result = self.step(batch, self.forward_only)
File "/usr/local/lib/python3.5/dist-packages/aocr/model/model.py", line 461, in step
outputs = self.sess.run(output_feed, input_feed)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 895, in run
run_metadata_ptr)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1128, in _run
feed_dict_tensor, options, run_metadata)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1344, in _do_run
options, run_metadata)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/client/session.py", line 1363, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Invalid PNG data, size 837
 [[Node: map/while/DecodePng = DecodePng[channels=1, dtype=DT_UINT8, _device="/job:localhost/replica:0/task:0/device:CPU:0"](map/while/TensorArrayReadV3)]]
 [[Node: map/while/truediv_1/x/_64 = _HostSend[T=DT_INT32, client_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_870_map/while/truediv_1/x", _device="/job:localhost/replica:0/task:0/device:GPU:0"](map/while/truediv_1/x)]]

Caused by op 'map/while/DecodePng', defined at:
File "/usr/local/bin/aocr", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/aocr/main.py", line 246, in main
channels=parameters.channels,
File "/usr/local/lib/python3.5/dist-packages/aocr/model/model.py", line 122, in init
self.img_data = tf.map_fn(self._prepare_image, self.img_data, dtype=tf.float32)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/functional_ops.py", line 409, in map_fn
swap_memory=swap_memory)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/control_flow_ops.py", line 2934, in while_loop
result = loop_context.BuildLoop(cond, body, loop_vars, shape_invariants)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/control_flow_ops.py", line 2720, in BuildLoop
pred, body, original_loop_vars, loop_vars, shape_invariants)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/control_flow_ops.py", line 2662, in _BuildLoop
body_result = body(*packed_vars_for_body)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/functional_ops.py", line 399, in compute
packed_fn_values = fn(packed_values)
File "/usr/local/lib/python3.5/dist-packages/aocr/model/model.py", line 481, in _prepare_image
img = tf.image.decode_png(image, channels=self.channels)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_image_ops.py", line 709, in decode_png
name=name)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py", line 787, in _apply_op_helper
op_def=op_def)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 3160, in create_op
op_def=op_def)
File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py", line 1625, in init
self._traceback = self._graph._extract_stack()  # pylint: disable=protected-access
InvalidArgumentError (see above for traceback): Invalid PNG data, size 837
 [[Node: map/while/DecodePng = DecodePng[channels=1, dtype=DT_UINT8, _device="/job:localhost/replica:0/task:0/device:CPU:0"](map/while/TensorArrayReadV3)]]
 [[Node: map/while/truediv_1/x/_64 = _HostSend[T=DT_INT32, client_terminated=false, recv_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device="/job:localhost/replica:0/task:0/device:GPU:0", send_device_incarnation=1, tensor_name="edge_870_map/while/truediv_1/x", _device="/job:localhost/replica:0/task:0/device:GPU:0"](map/while/truediv_1/x)]]

=====================================================
I couldn't understand the error and source of the error.
I tried short words in dataset, max 8 = it was working and i could get longest training.
As far as you didn't provide limitation for longest word (just instruction max-predictions=10 (or longer, say 18) looks like  not enough and training crashes)
What do you think, please? or What did i miss or did wrong?
Regards,
Alexei P.
p.s.
Sorry for wrongly formatted text in the post

Looks like some of the images in your dataset are corrupted, or at least TensorFlow can't read them. I don't think it has anything to do with your parameters, looks like the issue with the dataset itself.
What you can do is try and track down corrupt images by logging them when you encounter the "Invalid PNG data" exception. Or you can just ignore them, discard the corrupted batch and keep training — might be an option, too.
There might exist some external CLI tools to check images for validity, which could help you as well, but I don't know any, unfortunately.

any idea where  can i find better place to grab tf exception to ignore and collect dodgy PNGs , please?

Try catching it right where you're running a TF session: model.py:461 (outputs = self.sess.run(output_feed, input_feed))

Ok,thx :)

Yep ! - It helped me  to skip affected batches:
~line363:
#result = self.step(batch, self.forward_only)
result = None
try:
result = self.step(batch, self.forward_only)
except:
skipped_counter += 1
logging.info("[INFO AP] Step {} failed, batch skipped. Total skipped: {}".format(current_step,  skipped_counter))
continue
Thank you.
P.S. - Still running (~15 000 000 items, step 11 023  loss 0.000179... perplexity: 1.000765) . . .
Алексей П., Сидней

Would you mind submitting a PR? I imagine that could be useful for others, too.
Oh, and you could try logging.error instead of logging.info there for better log handling later :)


DNS resolver / unbound - scripting does not work as expected

scripting uses su to start and stop service, but that does not work in our current setup as su gets served with a menu screen..

yay, nice :+1:


1⃣ refactor(services: rate-limit): migrate from fastify to @whatwg-node/server

instead of #858 which got closed by accident

I pushed this to https://github.com/kamilkisiela/graphql-hive/pull/1434 and integration tests fail.

Closing. This PR is outdated and we'll reconsider it later.


Allow extra args for helm Install/Upgrade

GH Issue
GH Issue 726
Changes Proposed
This PR allows passing arguments to the helm command when using the Install and Upgrade functions in the helm module.
Test output
The test output can be found in this gist
Description of code changes
Adds an option to options.go called ExtraArgs and modifies InstallE  and UpgradeE to check if options.ExtraArgs is set, and passes those along to RunHelmCommandAndGetOutputE. This would be backwards compatible since it doesn't change the signature of the Install or Upgrade functions in the helm module.
Closes #726

That's a good point Yori, my apologies for missing that in the review. I opened the issue #731 for this.
@ndhanushkodi feel free to address this if you have any cycles. if not no worries, someone else will eventually get to it!

Thank you @infraredgirl and @yorinasub17 for your time in looking at this PR! @yorinasub17 your suggestion to make ExtraArgs a map from subcommand to args list makes sense and I've implemented that in a new PR here: https://github.com/gruntwork-io/terratest/pull/732