Fix spacing around equations

From James Haines email on 7/17/15, issue 7.
It doesn’t look as if the space around theorems and proofs stretches or shrinks in the way that space around equations and before new sections does. Our best quess is that the lines:
\theorempreskip{1ex}
\theorempostskip{1ex}
in the siamart.cls file could be changed to:
\theorempreskip{1ex plus .25ex minus .1ex}
\theorempostskip{1ex plus .25ex minus .1ex}
Not necessarily using those values for “plus” and “minus”, of course (the space before a new section is “1.3ex plus .5ex minus .2ex”; it’s set in the @startsection commands).

From John at Techsetters: Yes, adding the rubber lengths will fix this.

Done.


Add PAPI functionality to Dr Hook

This is cleaned up, updated and rebased PR superseding #18
To enable the DR_HOOK hardware counters, use following environment variables for DR_HOOK-ed programs:
DR_HOOK=1 DR_HOOK_OPT=COUNTERS
The CMake feature DR_HOOK_PAPI is enabled by default when PAPI is found. This can be toggled with
-DENABLE_DR_HOOK_PAPI=ON|OFF. In the case the feature is enabled, then the test fiat_test_drhook_counters is built. For unit-testing purpose, when run as part of ctest, the problem size is very small and the test runs in under 1 second.
This test can also be run standalone:
<build-dir>/tests/fiat_test_drhook_counters

Then the problem size is by default what was chosen by @MartynF for sanity checks.
Upon finalisation the file drhook.prof.0.csv is created which contains all the counter information.

Hi @Andrew-Beggs-ECMWF discussing offline with @ioanhadade, @ioanhadade suggested for you to have a look at the possibility of integrating this within drhook itself.


Exception raised by NavigationView in Reunion 0.5

Exception raised by NavigationView in Reunion 0.5

Any page containg a NavigationView having a Frame as Content briefly shows a blank window (without the NavigationView) and then raises a Microsoft C++ Exception winrt::hresult_error at memory location.....
Debugger stops there (actually it asks for loading the symbols in wkernelbase.pdb but even if loaded the exception is still being produced)
if continue is selected in the debugger then the page completes rendering and rendered and behaves normally
This behavio was not present in preview 3 nor 4
Steps to reproduce the bug

Steps to reproduce the behavior:

Clean install of Visual Studio 19.10 preview 1.0 + Project Reunion Extension (nothin intherited from previous versoins)
Create a blank application
Remove the handler for the sample button in the code behind
Replace the xaml code with de following sample and run the application

<Window
x:Class="NavigationViewTest.MainWindow"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:local="using:NavigationViewTest"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
mc:Ignorable="d">
<NavigationView x:Name="nvSample">
<NavigationView.MenuItems>
<NavigationViewItem Icon="Play" Content="Menu Item1" Tag="SamplePage1" />
<NavigationViewItem Icon="Save" Content="Menu Item2" Tag="SamplePage2" />
<NavigationViewItem Icon="Refresh" Content="Menu Item3" Tag="SamplePage3" />
<NavigationViewItem Icon="Download" Content="Menu Item4" Tag="SamplePage4" />
</NavigationView.MenuItems>
<Frame x:Name="TestFrame"/>
</NavigationView>
</Window>
Expected behavior

The page with the NavigationView should have been rendered with no exception involved.
Screenshots

Version Info

NuGet package version:

Project Reunion <IP_ADDRESS>112000

Windows app type:

UWP
Win32

No
Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)
Yes

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

This behavio was not present in preview 3 nor 4

#4496

Some additional info. Have found that the problem arises when running the application fom within the debugger.
Have generated the package and installed and in that configuration it runs smoothly.
Still the problem is present 100% of times when run from within the debugger.

Just found in stackoverflow the same solution and confirm that de bypass in #4496 did work for me. Hope an actual fix will be generated. Thanks a lot. huoyaoyuan

Yup, this is a known issue with the acrylic brush navigation view uses.


The design of the login screen is broken when viewed in Edge.

https://coreui.io/vue/demo/3.0.0/#/pages/login

Operating system and version
Windows 10
Microsoft Edge 44.17763.831.0

This seems edgy :D Thank you for the report (chrome worked fine)

fixed in 3.1.0 version


Mechanism for Auditing Network Access Not Isolated by Hystrix

Explore options for tracking when network access is done with Hystrix isolating it (such as within a thread isolated HystrixCommand).
If a reasonable solution can be done generically implement a contrib module.
The intent is:

find unknown vulnerabilities
track "drift" over time as transitive dependencies pull in code that performs network access
track metrics and optionally provide alerts
allow failing a canary build if unexpected network access occurs
alert in production if unexpected network access starts (such as if a property is flipped to turn on a feature)

HystrixNetworkAuditorEventListener#handleNetworkEvent() isn't invoked when  encountered with "java/net/ConnectException". Its not invoked with other exceptions. Here is the link.
Is there anything that could be done. Not sure if its the issue with version
http://stackoverflow.com/questions/40643621/hystrixnetworkauditoreventlistener-is-not-invoked-upon-failure-in-connecting-to


Present Proof Protocol

https://github.com/roots-id/rootswallet/wiki/Roots-Wallet-Implementation-Proposal#layer-3-data-exchange-protocols

@rodolfomiranda will add specific tickets related to present proof


Campaign's address extension has wrong $id in meta:extends

What are the schemas that are affected by the issue
address.schema.json under extension/adobe/experience/campaign
What are examples of products that are impacted by the issue
platform XDM and tooling

PR merged.


Request: Availability of NOAA.get_observations_by_lat_lon()

This is not a bug or issue.
Simply a request to publish get_observations_by_lat_lon() method from NOAA class.
We would like to use this to get observations for a given lat/lon.
Thanks for your great work!

published version 18.


[chore] Adopt to changes in confmap.ResolverSettings API

Adopt the codebase to confmap.ResolverSettings changes upstream:

Providers field replaced with ProviderFactories
Converters field replaced with ConverterFactories

Need https://github.com/open-telemetry/opentelemetry-collector/pull/10203 to resolve integration tests and fix validate sub-command

I’m skipping the integration tests for now, so we can merge this separately from the core upgrade to 0.101.0


EasyMock mocks created using @Mock, etc. should be named according to the field name

From<EMAIL_ADDRESS>on July 26, 2011 05:10:14
What steps will reproduce the problem? 1. Create two mocks of the same type using @Mock and EasyMock support
2. Write a test that breaks due to an unexpected call. What is the expected output? What do you see instead? Expected output:

Unexpected method call <mockName>.()
Actual output:
Unexpected method call <methodName>() What version of the product are you using? On what operating system? PowerMock 1.4.7 with EasyMock (Linux) Please provide any additional information below. When there is more than one mock of the same type, it is hard to tell which expectation is not met, or which mock received an unexpected call.

All mocks should be given the same name as the field that the annotation is applied to.
Original issue: http://code.google.com/p/powermock/issues/detail?id=336

From<EMAIL_ADDRESS>on August 21, 2011 14:28:10
Good idea. How ever I don't think the EasyMock extension even has support for normal aliases yet so please provide a patch if you want this done any time soon.
Status: Accepted
Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low


feat: rewrite parser in chumsky

Rewrite most of the parsing with Chumsky.
Aim of this commit is to replace Pest with Chumsky entirely. I wanted to continue partial bottom-to-top approach I described in #1529, but it turned out that when I written parser for expr, I'd have to replace like 90% of PEST implementation with chumsky. So let's just do it.
TODO:

[x] multi-quoted strings (I'm not sure how we'll do this),
[x] ranges
[x] dates (@max-sixty  can I just cherry-pick #1652 ?)
[x] finish s-strings
[x] ~disallow trailing _ in numbers~
[x] add raw string that don't escape

Incompatibilities:

we now parse escapes " \" \n \\ ". This is because I plagiarized examples and have based our strings on implementation of JSON strings,
subtle differences in what is considered a statement (this should not have any effects of things that previously compiled),
s-strings and f-string interpolations cannot contain {. This is no longer valid: s"text{'}'}text",
operator precedence on main is right-to-left (1 + 2 - 3 - 4 == 1 + (2 - (3 - 4)). This is very unconventional, so I'm changing it to left-to-right,
operator precedence for and and or on main is right-to-left a or b and c or d == a or (b and (c or d)). All languages I tested give and precedence over or, so I'm changing it to that.

I'm guessing it's } that is forbidden, is that right?

Yeah, my typo.

f"{{foo}}" should still work, since that will evaluate to "{foo}"

Well, with my impl it won't - it will parse {{foo} as the interpolation and } as the following string.

Does this no longer rely on pest at all?

Currently not, but if we wanted to merge now, we could do a little plumbing and transform this into the bottom-up. That's why I haven't removed pest yet - a fallback option is we cannot finish the TODO list.

I just want to document a decision I did here.

Initially, I started with parser only. The problem with this that generated errors are saying
expected one of 'f', 't', 'n', got '(' instead of expected one of true, false, null, got '('. This is because parser is consuming one character at the time.
So I extracted the lexer to convert stream of char into stream of tokens, which are then consumed by the parser. It's also a nice distinction between high and low level parsing.

Thanks for the review @zesterer ! Very grateful!

Closes #131 #1815

I thought the tests might be running slower locally so I ran a performance test — we had an old one with carge bench.
I think something might be a bit off in the current implementation...

main: time:   [581.55 µs 583.69 µs 585.94 µs]
parser: time:   [30.697 ms 30.786 ms 30.881 ms]

We got 600x slower! I'm guessing this is something quite small...

That sounds like you might have part of the parser that's branching off and checking a pattern on both branches, causing a reparse. Something like this:
let prefix = ... ;
let a = prefix.then(...);
let b = prefix.then(...);

a.or(b) // `prefix` gets parsed in both branches, so correctly parsing `b` requires parsing `prefix` twice: if `prefix` is deeply nested or recursive, this can produce exponential behaviour

The solution to cases like this is usually to separate out the prefix, like so:
let a = ...;
let b = ...;

prefix.then(a.or(b))

I did some tests and it really is 100x slower.
Here is is a flamechart of only lexing, no parsing. I cannot say what's the problem.
It may be the prefix issue @zesterer mentioned, or it may be all the copying from the input string into Token, which contains Token::Ident(String).
@zesterer would it be possible to have this:
enum Token<'a> {
    Ident(&'a str),
}

I tried it, but rustc is really not happy about the extra lifetime when it comes to choice and Parser::or.

I tried it, but rustc is really not happy about the extra lifetime when it comes to choice and Parser::or.

Allowing this pattern is the primary goal of the zero-copy rewrite (unfortunately, it's quite a complex thing to do post-hoc, hence the rewrite).
That said, it's an even better idea to intern your strings during the lexing stage so that comparing strings is just an integer comparison and your strings become copyable. There are several crates that are very good at this sort of thing.

Additionally, out of interest, have you tried using an alternative error type? Rich uses an internal HashSet to keep track of alternative characters, but Simple does not and should be substantially faster.

I've removed all nested data within Token:
#[derive(Clone, PartialEq, Debug)]
pub enum Token {
    NewLine,

    Ident,
    Keyword,
    Literal,

    Interpolation,

    Control,
}

Just lexing of the benchmark file is still taking [3.9285 ms 3.9305 ms 3.9335 ms], which is basically the same as before, which means that copying is not the problem here.
I also realized that we would have to copy idents to AST anyway, so it doesn't matter if we do it sooner rather than later (idents are ~90% of Tokens).

Allowing this pattern is the primary goal of the zero-copy rewrite

Ah nice, I've heard about the rewrite but I though it's referring not cloning parsers when they are built.

Additionally, out of interest, have you tried using an alternative error type?

I haven't, I'll do that now.

I'm also seeing improvements when replacing the error with Cheap.
 Right now there are a few commits here that disable parser and only do lexing. The 5ms on parser seems suspicious.
But in anycase, errors are the culprit it seems, thanks for the tip!

My bad, I ran on a commit after you disabled parsing. Now I get:
parser: 44.990 ms
parser (after replacing Simple with Cheap): 10.748 ms
I imagine making Token copyable (by interning strings or similar) will represent another substantial knock off that last value too, perhaps bringing it within 2-3x that of pest with some luck and a little tweaking of the parser impl.
That said, I think it's worth considering how fast is acceptable to you: you're coming from pest, which is known for being extremely quick, largely because it's doing its own code generation from the syntax you provide it (i.e: it is itself an optimising compiler, which then feeds its output into LLVM, also an optimising compiler). Because of this, pest is in a position to perform all sorts of magic that chumsky isn't (currently, although we do have plans) able to such as flattening certain parsers together into optimised jump tables and the like.
In comparison, chumsky relies on the Rust compiler's native ability to inline and optimise accordingly. As we've demonstrated this can be very quick, often as fast as hand-written recursive descent parsers - but it's unlikely that LLVM's optimiser alone, as wonderful as it is, will be able to wholly outpace a DSL + compiler such as pest.
My usual approach when writing compilers is to aim for a specific proportion of total compilation time spent on parsing, usually ~20%. If parsing is under that goal, I move on to something else (for the languages I work on, type-checking is usually by far and away the biggest offender). What goal you set depends on the constraints the compiler has and the workload it usually needs to deal with.

Update:
I have improved the parser & lexer implementations quite a lot.
The two cruxes I improved were:

cheap errors in lexer, were don't need expeceted and found tokens,
parsing of ranges.

Benchmarks:
main                    time:   [590.68 µs 591.37 µs 592.20 µs]
parser                  time:   [3.0680 ms 3.0722 ms 3.0790 ms]
parser-cheap-errors     time:   [1.7351 ms 1.7372 ms 1.7398 ms]
parser-lexer-only       time:   [725.98 µs 726.90 µs 727.92 µs]

Last two are experimental commits:
* d93e594 (parser-lexer-only) disable parser
* c0b96b6 (parser) cleanup
* 100c306 cheap errors for lexer
| * 13862d4 (parser-cheap-errors) cheap errors
|/
* c7869f0 marginal improvement of lexer

parser-cheap-errors is the best performance we can achieve
if we optimize error in parser.
As you can see, we can improve for factor 2x.
parser-lexer-only shows that lexer is now pretty darn fast,
not much room for improvement - at least in our implementation.
It may benefit from the zero-copy chumsky rewrite.

@max can you look into why cargo audit started failing now?
It seems to be a problem with time crate, dependency of chrono, which has a feature oldtime

It looks like it's failing on main too.
Otherwise this can be merged.

can you look into why cargo audit started failing now?
It seems to be a problem with time crate, dependency of chrono, which has a feature oldtime

Looks like you fixed it but would have been happy to help with this / fine to comment out for the moment

The two cruxes I improved were:
* cheap errors in lexer, were don't need expeceted and found tokens,

* parsing of ranges.

Benchmarks:

Amazing speed-up! I didn't think we'd get to that much faster! It's down to the point where I think it doesn't matter about small differences vs pest
Sorry the ranges was the thing slowing it down. I know I suggested we treat whitespace differently, maybe that wasn't the correct tradeoff and it created lots of work 😬

I actually glad you insisted on keep the rules for whitespace with range - I like current behavior and it was worth spending a bit of effort for it!
All in all, I think this can be merged now (if the tests will allow it). @max-sixty and @zesterer  thank you both for reviews and tips!

It's weird the Elixir tests are failing with a seg fault... https://github.com/PRQL/prql/actions/runs/4266003467/jobs/7426012687 Maybe something to do with stack space again?
Any thoughts? Should we comment them out? My only worry is that I know @kasvith was planning to publish the libraries to Hex, and won't be able to work on that while it's broken.

That's weird - this was failing sometime earlier but then it was not?

Hmmm, also getting a stack overflow on Windows now: https://github.com/PRQL/prql/actions/runs/4266003467/jobs/7426011971

Im getting following error for this
PYO3_PYTHON=py cargo test

     Running unittests src\lib.rs (target\debug\deps\prql_python-918bc678d493d4e2.exe)
error: test failed, to rerun pass `-p prql-python --lib`

Caused by:
  process didn't exit successfully: `C:\Users\Kasun\work\prql\target\debug\deps\prql_python-918bc678d493d4e2.exe` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
C:/Users/Kasun/.cargo/bin/cargo.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory

Ah, let's just limit it to prql-compiler, i see there are segfaults there in the tests.
cargo test -p prql-compiler

test src\lib.rs - (line 56) ... ignored
test src\lib.rs - ReadmeDoctests (line 245) ... FAILED
test src\lib.rs - compile (line 109) ... FAILED
test src\lib.rs - (line 41) ... FAILED

failures:

---- src\lib.rs - ReadmeDoctests (line 245) stdout ----
Test executable failed (exit code: 0xc00000fd).

stderr:

thread 'main' has overflowed its stack

---- src\lib.rs - compile (line 109) stdout ----
Test executable failed (exit code: 0xc00000fd).

stderr:

thread 'main' has overflowed its stack

---- src\lib.rs - (line 41) stdout ----
Test executable failed (exit code: 0xc00000fd).

stderr:

thread 'main' has overflowed its stack

failures:
    src\lib.rs - (line 41)
    src\lib.rs - ReadmeDoctests (line 245)
    src\lib.rs - compile (line 109)

test result: FAILED. 0 passed; 3 failed; 1 ignored; 0 measured; 0 filtered out; finished in 4.25s

Does it also fail with segfault on parser-only-lexer branch?

@aljazerzen
failures:
    parser::test::test_aggregate
    parser::test::test_allowed_idents
    parser::test::test_assign
    parser::test::test_backticks
    parser::test::test_basic_exprs
    parser::test::test_coalesce
    parser::test::test_dates
    parser::test::test_filter
    parser::test::test_function
    parser::test::test_gt_lt_gte_lte
    parser::test::test_inline_pipeline
    parser::test::test_literal
    parser::test::test_multiline_string
    parser::test::test_number
    parser::test::test_pipeline_parse_tree
    parser::test::test_sort
    parser::test::test_sql_parameters
    parser::test::test_take
    parser::test::test_var_def
    semantic::resolver::test::test_frames_and_names
    semantic::resolver::test::test_functions_1
    semantic::resolver::test::test_functions_nested
    semantic::resolver::test::test_functions_pipeline
    semantic::resolver::test::test_named_args
    semantic::resolver::test::test_variables_1
    semantic::test::check_invalid_version
    semantic::test::test_header
    semantic::test::test_resolve_01
    semantic::test::test_resolve_02
    semantic::test::test_resolve_03
    semantic::test::test_resolve_04
    semantic::transforms::tests::test_aggregate_positional_arg
    semantic::transforms::tests::test_transform_sort
    sql::gen_query::test::test_ctes_of_pipeline
    sql::gen_query::test::test_derive_filter
    sql::gen_query::test::test_filter_windowed
    sql::gen_query::test::test_variable_after_aggregate
    sql::test::test_end_with_new_line
    test::test_append
    test::test_bare_s_string
    test::test_basic_agg
    test::test_casting
    test::test_closures_and_pipelines
    test::test_custom_transforms
    test::test_dates
    test::test_direct_table_references
    test::test_distinct
    test::test_double_aggregate
    test::test_errors
    test::test_exclude_columns
    test::test_f_string
    test::test_filter
    test::test_filter_and_select_changed_alias
    test::test_filter_and_select_unchanged_alias
    test::test_from_text
    test::test_group_all
    test::test_header_target_error
    test::test_hint_missing_args
    test::test_ident_escaping
    test::test_inline_tables
    test::test_intersect
    test::test_interval
    test::test_join
    test::test_literal
    test::test_loop
    test::test_name_inference
    test::test_name_resolving
    test::test_name_shadowing
    test::test_nonatomic
    test::test_nonatomic_table
    test::test_nulls
    test::test_numbers
    test::test_output_column_deduplication
    test::test_pipelines
    test::test_precedence
    test::test_prql_to_sql_1
    test::test_prql_to_sql_2
    test::test_prql_to_sql_table
    test::test_quoting
    test::test_ranges
    test::test_remove
    test::test_rn_ids_are_unique
    test::test_same_column_names
    test::test_sorts
    test::test_sql_of_ast_1
    test::test_sql_of_ast_2
    test::test_static_analysis
    test::test_stdlib
    test::test_strings
    test::test_switch
    test::test_table_alias
    test::test_table_definition_with_expr_call
    test::test_table_names_between_splits
    test::test_table_s_string
    test::test_take
    test::test_target_clickhouse
    test::test_targets
    test::test_toposort
    test::test_unused_alias
    test::test_window_functions_00
    test::test_window_functions_02
    test::test_window_functions_03
    test::test_window_functions_04
    test::test_window_functions_05
    test::test_window_functions_06
    test::test_window_functions_07
    test::test_window_functions_08
    test::test_window_functions_09
    test::test_window_functions_10

test result: FAILED. 26 passed; 109 failed; 1 ignored; 0 measured; 0 filtered out; finished in 2.18s

This output seems to be missing integration tests that fail with segfault. The failed tests are just the --lib tests (that are inteentionally failing on that branch).
Well, thanks. It looks like there is no other solution than reading the implementation again and finding the bug.

Thanks a lot for looking @kasvith , appreciate it.

@zesterer no stress if you can't respond to every Chumsky question — but if you see this and have ideas, let us know if you have any ideas for finding / handling these stack overflows — thank you!

Does the grammar contain left recursion?

Left-recursive patterns are those that contain themselves as the first element. For example:
expr = expr | { '-' + expr }
Most PEG parsers will stack overflow on cases like this because, in attempting to parse the expression, the expr pattern will be repeatedly entered at each level of recursion.
Thankfully, it is always possible to restate left recursion as right recursion, which PEG parsers have an easier job handling. For example, the above could become:
expr = { '-' }* + atom
I don't know for certain that the case you're hitting is left recursion, but it seems likely that it is.
Debugging cases like this is usually a two-phase process:

Find an input that reproduces the problem, remove as many elements of it as possible while maintaining the issue.

Mass comment out any sections of the parser that aren't requires to pass the minimised failing input.

Hopefully, any left recursion will make itself 'obvious' at this point.
In the future, zero-copy will provide an explicit memoisation combinator that will allow left recursion to 'just work' as well as debugging facilities to identify which patterns are left-recursive and suggest fixes.

Ah yes I see. We do have left recursion in the grammar (basically all binary expressions), but I've implemented it as you described - with atoms (that I call term in the source code).
This was actually my suspicion, but I couldn't find anything like it.
Strangely, it is only happening on Windows, so I cannot reproduce it. Which mean that this PR will have to wait until I get the will to spin-up a virtual box.
If anyone is up for a little debugging, try to find the minimal reproducible example, please go ahead!

Hmm. 'Only happening on Windows' is indeed interesting. On the assumption that the test logic doesn't differ between platforms, it sounds like you're just hitting a regular stack overflow due to some very deep stack usage (this is particularly common in debug mode, where LLVM doesn't get much of a chance to optimise things).
Out of interest, is there any reason why you don't have the spill-stack feature enabled for chumsky? It uses the stacker crate to negate stack overflows by spilling on to the heap. I imagine enabling this feature will effectively solve the problem.

Yes, spill-stack does not work on Macos, our tests were failing, due do some strange error (see previous comments).
Maybe we could disable it for macos only.

I think that's sensible. That aside, I'm surprised it didn't work on MacOS: stacker is used internally by rustc and seems to have fairly broad platform support. I shall look into this.


Add support for Alpine(musllinux)

Added -fPIC, the x86_64 whl works, however the aarch64 one does not work, weird.

Seems like the compiler is not including certain symbols when building the wrapper so. I found this, perhaps see if it helps? https://github.com/rust-lang/git2-rs/issues/706#issuecomment-836198499

Dynamic linking works, cheers!


Optimise block proposal in consensus

Remove unnecessary conversions of NodePublicKey to and from bytes

Add cache for getting block leaders

A couple of minor comments, otherwise looks good - though I'm wondering whether an even more drastic refactor might be useful, where we define a new type along the lines of NodePublicKeyUnchecked(pub Vec<u8>), only converting it to a BLS-based key in instances where we will need to sign/verify using it? I think this would a) add some nominal type safety, where we're no longer passing around raw Vec<u8>s everywhere but rather wrap them in a named type; and b) might also reduce the amount of _from_bytes dual functions as most can simply operate on unchecked/raw keys and only a few select functions can take a checked/converted key. Not entirely sure this is worthwhile, nor whether it can't be done in a subsequent PR anyway, but food for thought.
Also, as a matter of preference, I'd like a suffix such as _raw rather than _from_bytes as it's more concise, as a lot of names seem rather unwieldy. Compare get_peer_id_from_public_key_bytes() to get_peer_id_from_raw(). Though of course legibility comes first - I'm happy with the second but if there's disagreement then sticking with the first is fine.

I have added a container struct for Vec<u8> called NodePublicKeyRaw as you suggested, and renamed functions with the suffix _from_bytes and similar to _raw.
As there are many places that use the existing non raw functions I would suggest that opening another PR containing that refactoring would be better, however if you think that should be included in this PR I am happy to do that.


Fails at bundle install

Expected behavior
Using the last version of SimpleCov (0.21.2) I should be able to do bundle install successfully.
Actual behavior
It fails because SimpleCov depends on docile ~> 1.1 and rspec-tracer on docile ~> 1.1.0.
Steps to reproduce the problem
Add the last version of SimpleCov and rspec-tracer on the gemfile.
0.2.0
Include Ruby, RSpecTracer, and RSpec version. Also include
Simplecov version if applicable.

@hdamico what's the ruby version you're using? Can you share the output of the bundle install?

@hdamico It should work now with v0.3.0


fixed display results

Fixed display results when uniqueValueCounts are missing.

This PR fixes the problem when the models fail to predict all labels that they were supposed to predict. Without this PR the result would still display, but the Status message in diagnostics would say OK, and the names of the recognized labels would not display in the lower left corner. With this PR - the behavious is more informative and permissive


ROX-11537: Fix flake in admission control test

Description
Use the ResourcesSynced request to realize a "Sync" helper on the manager, allowing us to wait until all messages sent earlier are processed.
It may be a bit of a hack, but IMHO it's a benign one. Realizing a callback-like mechanism isn't easily possible because ResourceUpdatesC is designed for proto types, and thus cannot be extended by a user to pass a callback channel/signal.
Checklist

[ ] Investigated and inspected CI test results
[x] Unit test and regression tests added
[x] ~Evaluated and added CHANGELOG entry if required~
[x] ~Determined and documented upgrade steps~
[x] ~Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed
Ran test with
$ GOMAXPROCS=1 go test ./sensor/admission-control/service/ -test.v -test.run '^\QTestExecIntoPodNameEventPolicy\E$' -test.count=10

/retest-required

Also @fredrb this might be a pattern to follow in scanner, w.r.t. the race you mentioned some time ago...

Also @fredrb this might be a pattern to follow in scanner, w.r.t. the race you mentioned some time ago...

@porridge I assume you mean sensor?

Also @fredrb this might be a pattern to follow in scanner, w.r.t. the race you mentioned some time ago...

@porridge I assume you mean sensor?

:100: :facepalm:

@porridge PTAL, I've changed the approach to add an explicit "Sync" method for the manager. While primarily used for testing, I feel such a method is generally useful for any component that does asynchronous processing and thus doesn't pollute the public interface.
This makes it fully non-hacky and also avoids the problem you sketched.

[2022-09-01 12:54:08] panic: Import processing for file "/go/src/github.com/stackrox/stackrox/pkg/postgres/schema/cluster_health_statuses.go" took more than 1 second (1.069848009s). This typically indicates that an import was not added to the Go template, which forced import processing to search through all types and magically add the import. Please add the import to the template; you can compare the imports in the generated file with the ones in the template, and add the missing one(s)

/retest-required


THEAD not repeated on every page

Which version of PhantomJS are you using? Tip: run phantomjs --version.

2.1.1

What steps will reproduce the problem?
Run this script:

var page = require('webpage').create();

var system = require('system');
var args = system.args;

page.open(args[1], function(status) {
  console.log("Status: " + status);
  page.paperSize = {
	  format: 'A4',
	  orientation: 'portrait',
	  margin: '1cm'
  };

  if(status === "success") {
    page.render(args[2]);
  }
  phantom.exit();
});

On an html file with a very tall table, like this:
table.html.zip
The expected result is that the THEAD is repeated on every page, like so:
expected.pdf
But the result does not contain the repeated headers:
actual.pdf
It seems to be a regression, as version 1.9.8 handles the THEAD as expected

Which operating system are you using?
Manjaro Arch Linux

Did you use binary PhantomJS or did you compile it from source?

binary

We have the same problem here.

+1

+1

+1

+1

Any news on this?

+1

+1


🐛 Fixed postinstall script when running on Windows

no-issue
The previous postinstall script used the unix specific cp command,
which caused installing on Windows to break. This replaces it with an
npm module which handles copying files agnostic to platform.

Couple things -

Should cpy-cli be a dev dep? AFAIK CLI installs only install production deps -> command not found error still
Is there a reason the file needs to be copied over? Since the node_modules folder has the same permissions as the installation itself, we could just read from the resolved path 🤔

Should cpy-cli be a dev dep? AFAIK CLI installs only install production deps -> command not found error still

Nice catch :fishing_pole_and_fish: will update that!

Is there a reason the file needs to be copied over? Since the node_modules folder has the same permissions as the installation itself, we could just read from the resolved path :thinking:

This deffo needs a more elegant solution, this is more of a stopgap until we have something else in place. ATM it's copied over because our public file middleware only supports serving from the public directory


Docker hardening guideline

What kind of request is this (question/bug/enhancement/feature request):
Feature request
Steps to reproduce (least amount of steps as possible):
Follow recommendations from https://www.cisecurity.org/benchmark/docker/
Result:
https://github.com/rancher/rancher/issues/9597
https://github.com/rancher/rancher/issues/9072
Other details that may be helpful:
Rancher has a hardening guide but it's mostly focused around the Kubernetes CIS benchmark and not the Docker CIS benchmark.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.4
Installation option (single install/HA): HA

Any progress with the CIS docker Hardening Guide? I have some interest in this also.

Another customer requesting this...


feat : Added interactive sounds for better game UX

Fixes Issue🛠
Closes #138
Description👨💻
Applied Changes

Added game BGM : Added 2 game BGMs, one for when the user is playing the game, and another when they are selecting from the menu. (both bgms are in loop, i.e, if reaches end of file, starts from beginning)
Added GameOver music : Added a gameOver music, which is played when the game gets over.
Smooth transition between music(s): When it is gameOver/pause/reload/back to menu/back to game events, the game logic[main.js] is updated such that the transition between 2 musics are handled smoothly.

Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅
Tested on local machine, after the changes were made. All plays out smoothly.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Pls delete every .DS_Store files @SoumyadevSaha

Pls delete every .DS_Store files @SoumyadevSaha

Deleted the .DS_Store files

Amazing work, Really liked the sounds !! Merged @SoumyadevSaha 🎉🥳

give @SoumyadevSaha 150 points

Amazing work, Really liked the sounds !! Merged @SoumyadevSaha 🎉🥳

Thankyou so much 😁


Enforces BagIt profile requirements for user-supplied metadata.

Resolves https://jira.duraspace.org/browse/FCREPO-2356

@ruebot :  re your comment above: yes - I'll fix that.


numpy deprecation warning

I'm getting the following error any time I run the current container:
/tmp/ipykernel_535579/2643044777.py:26: DeprecationWarning: `alltrue` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `all` instead.

This is a well known warning but I do not understand how to find where it is happening since it seems this is coming from cached copy something is creating in jupyter/python.   It is just a warning but we should address it.   As far as I can tell it isn't causing any issues for now.

I think this is not our problem but obspy.   At least during a debugging session I see the error pop up when it runs obspy's travel time calculator.


building for iOS Simulator, but linking in object file built for iOS, for architecture arm64

building for iOS Simulator, but linking in object file built for iOS, for architecture arm64
flutter 2.5

希望早日解决，我也遇到了，只有降级flutter版本了

@virskor @changleibox 请自行检查一下有没有引入 flutter_bugly 插件
flutter_bugly 插件的 ios 里 podspec 少了一句
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }

其他解决方案 https://stackoverflow.com/questions/63607158/xcode-12-building-for-ios-simulator-but-linking-in-object-file-built-for-ios

试了试，最佳办法是修改 podfile
post_install do |installer|
  installer.pods_project.targets.each do |target|
    flutter_additional_ios_build_settings(target)
    # 兼容 Flutter 2.5
    target.build_configurations.each do |config|
#       config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
      config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'i386 arm64'
    end
  end
end

试了试，最佳办法是修改 podfile

post_install do |installer|

  installer.pods_project.targets.each do |target|

    flutter_additional_ios_build_settings(target)

    # 兼容 Flutter 2.5

    target.build_configurations.each do |config|

#       config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'

      config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'i386 arm64'

    end

  end

end

我也是改成你这样好了

xcode 直接运行没问题，flutter run 就报错


Added pretty title

There are merge conflicts. Please could you pull from upstream and resolve the conflicts?


[README Enhancement]: ChatGPT-Based Tweets Sentiment Analysis Using Deep Learning

Deep Learning Simplified Repository (Proposing new issue)
:red_circle: Project Title : README Enhancement: ChatGPT-Based Tweets Sentiment Analysis Using Deep Learning
:red_circle: Aim : The aim is to enhance the README file and make it eye pleasing, well documented using the given README template.
:red_circle: README to be enhanced : https://github.com/abhisheks008/DL-Simplified/blob/main/ChatGPT Based Tweets Sentiment Analysis Using DL/Readme.md
:red_circle: README Template : https://github.com/abhisheks008/DL-Simplified/blob/main/.github/readme_template.md

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Email ID :
Participant ID (if applicable):
Approach for this Project :
What is your participant role? (Mention the Open Source program)

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

Hi @abhisheks008 can you assign it to me.

Full name: Priyanshu Aggarwal
GitHub Profile Link: https://github.com/jindalpriyanshu101
Email ID<EMAIL_ADDRESS>Participant ID (if applicable): N/A
Approach for this Project: By following the template provided, i'll make it look significantly beautiful, while making sure the required content is organised in its place.
What is your participant role? (Mention the Open Source program): GSSoC'24 Contributor

Hi @jindalpriyanshu101 you can work on this issue, make sure you use the README template and also you can improvise from your end too.

Hey @abhisheks008, while updating the readme, i found that requirements.txt is seriously messed up, which will cause errors if anyone tries to install libraries through that. ScreenShot is attached for visualization of the same:

Am i supposed to fix that as well to ensure smooth usage?

It'll be better if you make the changes. @jindalpriyanshu101

Alright, thanks for clarification


robyn refresh fails after few runs

Project Robyn
Describe issue
I'm running Robyn on databricks. I have 2 separate notebooks in databricks: one for model training and one with robyn_refresh() function. The second notebook, with robyn_refresh() function is scheduled to run on daily new data. But the second notebook fails after running a few times with below error. I was able to reproduce the error using demo data and ran into below error after 7 runs:
Error in data.frame(solID = names(chainData), window_start = as.Date(unlist(lapply(chainData,  :
  arguments imply differing number of rows: 8, 7
Error in data.frame(solID = names(chainData), window_start = as.Date(unlist(lapply(chainData, : arguments imply differing number of rows: 8, 7
Error in data.frame(solID = names(chainData), window_start = as.Date(unlist(lapply(chainData, : arguments imply differing number of rows: 8, 7

Provide reproducible example
create_files <- TRUE
robyn_directory <- "/dbfs/FileStore/xyz" # folder in databricks file system

data("dt_simulated_weekly")
data("dt_prophet_holidays")

InputCollect <- robyn_inputs(
  dt_input = dt_simulated_weekly,
  dt_holidays = dt_prophet_holidays,
  date_var = "DATE", # date format must be "2020-01-01"
  dep_var = "revenue", # there should be only one dependent variable
  dep_var_type = "revenue", # "revenue" (ROI) or "conversion" (CPA)
  prophet_vars = c("trend", "season", "holiday"), # "trend","season", "weekday" & "holiday"
  prophet_country = "DE", # input one country. dt_prophet_holidays includes 59 countries by default
  context_vars = c("competitor_sales_B", "events"), # e.g. competitors, discount, unemployment etc
  paid_media_spends = c("tv_S", "ooh_S", "print_S", "facebook_S", "search_S"), # mandatory input
  paid_media_vars = c("tv_S", "ooh_S", "print_S", "facebook_I", "search_clicks_P"), # mandatory.
  organic_vars = "newsletter", # marketing activity without media spend
  window_start = "2016-01-01",
  window_end = "2018-12-31",
  adstock = "geometric" # geometric, weibull_cdf or weibull_pdf.
)

hyper_names(adstock = InputCollect$adstock, all_media = InputCollect$all_media)
plot_adstock(plot = FALSE)
plot_saturation(plot = FALSE)

hyper_limits()

hyperparameters <- list(
  facebook_S_alphas = c(0.5, 3),
  facebook_S_gammas = c(0.3, 1),
  facebook_S_thetas = c(0, 0.3),
  print_S_alphas = c(0.5, 3),
  print_S_gammas = c(0.3, 1),
  print_S_thetas = c(0.1, 0.4),
  tv_S_alphas = c(0.5, 3),
  tv_S_gammas = c(0.3, 1),
  tv_S_thetas = c(0.3, 0.8),
  search_S_alphas = c(0.5, 3),
  search_S_gammas = c(0.3, 1),
  search_S_thetas = c(0, 0.3),
  ooh_S_alphas = c(0.5, 3),
  ooh_S_gammas = c(0.3, 1),
  ooh_S_thetas = c(0.1, 0.4),
  newsletter_alphas = c(0.5, 3),
  newsletter_gammas = c(0.3, 1),
  newsletter_thetas = c(0.1, 0.4),
  train_size = c(0.5, 0.8)
)

InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters)

OutputModels <- robyn_run(
  InputCollect = InputCollect, # feed in all model specification
  cores = NULL,
  iterations = 1000,
  trials = 1,
  ts_validation = TRUE,
  add_penalty_factor = FALSE
)

OutputCollect <- robyn_outputs(
  InputCollect, OutputModels,
  pareto_fronts = "auto",
  csv_out = "pareto",
  clusters = TRUE,
  export = create_files,
  plot_folder = robyn_directory,
  plot_pareto = create_files

print(OutputCollect)

#Compare all model one-pagers and select one that mostly reflects your business reality
select_model <- "1_10_13"

ExportedModel <- robyn_write(InputCollect, OutputCollect, select_model, export = create_files)
print(ExportedModel)

Below code is basically updating model path to the latest model json so that it can be used in robyn refresh function %python
import os
from datetime import datetime, date

folder_path = "/dbfs/FileStore/Navneet/mmm_experimentation/new_version_robyn_test/"
subFolder_path = [folder_path + sfd for sfd in os.listdir(folder_path)]
new_file_path = subFolder_path[-1]

subFolders=[]
for root, subdirs, files in os.walk(new_file_path):
  subFolders.append(root)

new_file_path= subFolders[-1]
modelName = [i for i in os.listdir(new_file_path) if '.json' in i ]
modelName = modelName[0]

modelPath = new_file_path+'/'+modelName
print(modelPath)

spark.conf.set("mydata.modelPath", modelPath)

Now refreshing a refreshed model, following the same approach. Run this and above python code block multiple times to get the error.
json_file <- as.character(sparkR.conf("mydata.modelPath"))
RobynRefresh <- robyn_refresh(
  json_file = json_file,
  dt_input = dt_simulated_weekly,
  dt_holidays = dt_prophet_holidays,
  refresh_steps = 1,
  refresh_iters = 1000, # 1k is an estimation
  refresh_trials = 1
)

Environment & Robyn version
Make sure you're using the latest Robyn version before you post an issue.

Check and share Robyn version: packageVersion("Robyn") : 3.9.0
R version (Please, check and share: sessionInfo() or R.version$version.string)

Hi! This one seems a bit complex to replicate. We will check on our end to see if we can replicate by simply following the demo as you mentioned.
Additionally, can you confirm this is happening the first time you run a refresh model? Also, are you renaming or customizing the structure of the chained folders? Lastly and before we start debugging, have you tried with the latest dev version and can you please confirm this issue persists with version <IP_ADDRESS>00?

No, the first few model refreshes runs fine. And, the same code starts throwing error after a few runs. Demo script failed after 7th run.
I'm not changing the folder structure of the chained folders.
The only change from demo script is: json_file <- as.character(sparkR.conf("mydata.modelPath")). Basically this the last refreshed model folder structure path. This helps run robyn refresh function daily in prod without changing json_file path.

This is the log of 7th run of robyn refresh. It fails after it prints decomp-rssd converged:
Recreating model 1_10_2 Imported JSON file succesfully: /dbfs/FileStore/Navneet/mmm_experimentation/new_version_robyn_test/Robyn_202304241811_init/Robyn_202304241823_rf1/Robyn_202304241827_rf2/Robyn_202304241832_rf3/Robyn_202304241840_rf4/Robyn_202304241848_rf5/Robyn_202304241852_rf6/RobynModel-1_10_2.json >> Running feature engineering... Input data has 208 weeks in total: 2015-11-23 to 2019-11-11 Refresh #6 model is built on rolling window of 157 week: 2016-02-15 to 2019-02-11 Rolling window moving forward: 1 weeks Successfully recreated model ID: 1_10_2 >>> Building refresh model #7 in manual mode >>> New bounds freedom: 0.64% >> Running feature engineering... Input data has 208 weeks in total: 2015-11-23 to 2019-11-11 Refresh #7 model is built on rolling window of 157 week: 2016-02-22 to 2019-02-18 Rolling window moving forward: 1 weeks Warning in hyper_collector(InputCollect, hyper_in = InputCollect$hyperparameters, : Provided train_size but ts_validation = FALSE. Time series validation inactive. Fitting time series with all available data... Using geometric adstocking with 20 hyperparameters (19 to iterate + 1 fixed) on 63 cores >>> Starting 1 trials with 1000 iterations each using TwoPointsDE nevergrad algorithm... Running trial 1 of 1 |================================================================== | 94% Finished in 1.04 mins >>> Running Pareto calculations for 1000 models on auto fronts... >> Automatically selected 1 Pareto-fronts to contain at least 100 pareto-optimal models (170) >> Pareto-Front: 1 [170 models] 00:01:13 [=========================================] 100% | 170 >>> Calculating clusters for model selection using Pareto fronts... >> Auto selected k = 4 (clusters) based on minimum WSS variance of 5% >>> Collecting 170 pareto-optimum results into: /dbfs/FileStore/Navneet/mmm_experimentation/new_version_robyn_test/Robyn_202304241811_init/Robyn_202304241823_rf1/Robyn_202304241827_rf2/Robyn_202304241832_rf3/Robyn_202304241840_rf4/Robyn_202304241848_rf5/Robyn_202304241852_rf6/Robyn_202304241856_rf7/ >> Exporting general plots into directory... >> Exporting pareto results as CSVs into directory... >>> Exporting pareto one-pagers into directory... >> Generating only cluster results one-pagers (4)... >> Plotting 4 selected models on 63 cores... |======================================================================| 100% >> Exported model inputs as /dbfs/FileStore/Navneet/mmm_experimentation/new_version_robyn_test/Robyn_202304241811_init/Robyn_202304241823_rf1/Robyn_202304241827_rf2/Robyn_202304241832_rf3/Robyn_202304241840_rf4/Robyn_202304241848_rf5/Robyn_202304241852_rf6/Robyn_202304241856_rf7/RobynModel-inputs.json - DECOMP.RSSD converged<EMAIL_ADDRESS>0.036

No, the first few model refreshes runs fine. And, the same code starts throwing error after a few runs. Demo script failed after 7th refresh.

When you say "few runs" you mean iterations or refresh models? Or you refreshed 6 models correctly and the 7th crashed after a few successful iterations?

This is the log of 7th run of robyn refresh. It fails after it prints decomp-rssd converged:

It fails but I can't actually see the error message.

Lastly and before we start debugging, have you tried with the latest dev version and can you please confirm this issue persists with version <IP_ADDRESS>00?

Please, can you confirm?
Ideally, if you can format the logs so that each line is a new line it'll be way easier to read. Thanks!

Here's log:

No, I wasn't able to replicate. It could be related to this other issue though. Both of you are using 3.9.0. I strongly recommend you updating to latest dev version first and see if this issue persists. We can't fix past versions but from current onwards and there are a bunch of improvements and new features available since then.

Thanks! But what do you think is causing this? When can the code fail on 'chainData' error, specifically when it's being used to create a dataframe? I'm trying to make sure that this is not an error on my end which can be fixed easily before I commit myself to upgrade to the newer version of Robyn.

It seems unexported function robyn_chain() is trying to create a data.frame with vectors lengths 8 and 7 at the same time and returns this error. You can play with it easily, given it only requires de json_file as an input (try something like Robyn:::robyn_chain(your_json_file) with different files and compare).

I upgrade the version of Robyn to '<IP_ADDRESS>00'. While trying top replicate the above scenario, my code started failing at robyn_save function(which was running fine in Robyn 3.9.0). I have attached screenshot of the error I'm seeing. Is this a know issue?

@laresbernardo Did you get a chance to look into the above error? I'm getting it with latest version of Robyn. Thanks!

Ah, I see. You're using robyn_save() instead of robyn_write(). Can you please try with robyn_write() and robyn_read()? Notice we stopped supporting robyn_save() when we migrated to JSON files (see demo.R).

I tried robyn_write() as well. Still getting the exact same error i.e " Error in OutputModels$convergence: $ operator is invalid for atomic vectors". Here's what I got when I tried OutputModels$convergence if it helps:
$moo_distrb_plot
Picking joint bandwidth of 0.0215
Picking joint bandwidth of 0.0759
$moo_cloud_plot
$errors
A tibble: 40 x 15
Groups:   error_type [2]
error_type  cuts      n median    std med_var_P first_med first_med_avg

1 DECOMP.RSSD 50       50  0.730 0.0325     NA        0.730         0.723
2 DECOMP.RSSD 101      50  0.715 0.0452      2.11     0.730         0.723
3 DECOMP.RSSD 151      51  0.725 0.0400      1.28     0.730         0.723
4 DECOMP.RSSD 202      50  0.711 0.0488      1.9      0.730         0.723
5 DECOMP.RSSD 252      51  0.698 0.0472      1.88     0.730         0.723
6 DECOMP.RSSD 302      50  0.677 0.0454      3.13     0.730         0.723
7 DECOMP.RSSD 353      50  0.670 0.0504      1.03     0.730         0.723
8 DECOMP.RSSD 403      51  0.667 0.0587      0.45     0.730         0.723
9 DECOMP.RSSD 454      50  0.690 0.0647      3.33     0.730         0.723
10 DECOMP.RSSD 504      51  0.650 0.0582      6.14     0.730         0.723
i 30 more rows
i 7 more variables: last_med , first_sd , first_sd_avg ,
last_sd , med_thres , flag_med , flag_sd
$conv_msg
[1] "DECOMP.RSSD NOT converged<EMAIL_ADDRESS>0.068 > 0.039 &<EMAIL_ADDRESS>0.6 <= 0.65"
[2] "NRMSE NOT converged<EMAIL_ADDRESS>0.21 <= 0.27 &<EMAIL_ADDRESS>1.2 > 0.95"
attr(,"sd_qtref")
[1] 3
attr(,"med_lowb")
[1] 2

I'm using the demo data provided on Robyn github repo and the same code as demo.R (which you linked above). I running code on a Databricks cluster and Robyn version is: '<IP_ADDRESS>00'.
create_files <- TRUE
robyn_directory <- "/dbfs/FileStore/xyz" # folder in databricks file system
data("dt_simulated_weekly")
data("dt_prophet_holidays")
InputCollect <- robyn_inputs(
dt_input = dt_simulated_weekly,
dt_holidays = dt_prophet_holidays,
date_var = "DATE", # date format must be "2020-01-01"
dep_var = "revenue", # there should be only one dependent variable
dep_var_type = "revenue", # "revenue" (ROI) or "conversion" (CPA)
prophet_vars = c("trend", "season", "holiday"), # "trend","season", "weekday" & "holiday"
prophet_country = "DE", # input one country. dt_prophet_holidays includes 59 countries by default
context_vars = c("competitor_sales_B", "events"), # e.g. competitors, discount, unemployment etc
paid_media_spends = c("tv_S", "ooh_S", "print_S", "facebook_S", "search_S"), # mandatory input
paid_media_vars = c("tv_S", "ooh_S", "print_S", "facebook_I", "search_clicks_P"), # mandatory.
organic_vars = "newsletter", # marketing activity without media spend
window_start = "2016-01-01",
window_end = "2018-12-31",
adstock = "geometric" # geometric, weibull_cdf or weibull_pdf.
)
hyper_names(adstock = InputCollect$adstock, all_media = InputCollect$all_media)
plot_adstock(plot = FALSE)
plot_saturation(plot = FALSE)
hyper_limits()
hyperparameters <- list(
facebook_S_alphas = c(0.5, 3),
facebook_S_gammas = c(0.3, 1),
facebook_S_thetas = c(0, 0.3),
print_S_alphas = c(0.5, 3),
print_S_gammas = c(0.3, 1),
print_S_thetas = c(0.1, 0.4),
tv_S_alphas = c(0.5, 3),
tv_S_gammas = c(0.3, 1),
tv_S_thetas = c(0.3, 0.8),
search_S_alphas = c(0.5, 3),
search_S_gammas = c(0.3, 1),
search_S_thetas = c(0, 0.3),
ooh_S_alphas = c(0.5, 3),
ooh_S_gammas = c(0.3, 1),
ooh_S_thetas = c(0.1, 0.4),
newsletter_alphas = c(0.5, 3),
newsletter_gammas = c(0.3, 1),
newsletter_thetas = c(0.1, 0.4),
train_size = c(0.5, 0.8)
)
InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters)
OutputModels <- robyn_run(
InputCollect = InputCollect, # feed in all model specification
cores = NULL,
iterations = 1000,
trials = 1,
ts_validation = TRUE,
add_penalty_factor = FALSE
)
OutputCollect <- robyn_outputs(
InputCollect, OutputModels,
pareto_fronts = "auto",
csv_out = "pareto",
clusters = TRUE,
export = create_files,
plot_folder = robyn_directory,
plot_pareto = create_files
print(OutputCollect)
#Compare all model one-pagers and select one that mostly reflects your business reality
select_model <- "1_10_13"
ExportedModel <- robyn_write(InputCollect, OutputCollect, select_model, export = create_files)
print(ExportedModel)

code fails on robyn_write(). Please let me know if you need any more info from my side.

Hi @navneetsonak-ds thanks for the reproducible example. I've run exactly the same code and am not experiencing this error. Are you getting this error when running this code you shared? Wasn't the original issue a problem with refresh models?

Yes. When I was using Robyn version 3.9.0, I was getting error with robyn_refresh() function. And then upgraded the Robyn version to <IP_ADDRESS>00 and started getting error with robyn_write() function.
Did you run the code on Robyn <IP_ADDRESS>00? Anything else I can try?

upgraded the Robyn version to <IP_ADDRESS>00 and started getting error with robyn_write() function.

Is the error you are getting exactly the same you shared when refreshing? That doesn't make much sense given we don't use chainData if not refreshing nor exporting a model.

Did you run the code on Robyn <IP_ADDRESS>00? Anything else I can try?

Correct. Latest dev version. And the error didn't show up. Try on a fresh new session. I honestly have no idea why are you experiencing this issue (and others aren't) but must be related to the instance or R version.

No, the error with Robyn version 3.9.0 was related to chainData(robyn_refresh function). Error with Robyn version 3.10.3:9000 is "Error in OutputModels$convergence: $ operator is invalid for atomic vectors" (robyn_write function). Both are separate errors and  are not related to each other.
Ok. Thanks!

Ok, ideally to report different issues it's better to have 2 different tickets so we can split un-related problems.
Given I wasn't able to replicate these errors I can't seem to understand the issue nor fix it if necessary. With the provided code I wasn't able to replicate neither of the issues reported. Nevertheless, I'll leave this ticket open in case someone else experiences the same problem or you want to provide additional information.


can't install board manager

"Error downloading https://github.com/stm32duino/BoardManagerFiles/raw/main/package_stmicroelectronics_index.json"
what is problem from my side I can't identify it. I have followed all the steps mentioned in the website exactly. but I got this error. And I also redoing the same get tired. please anyone guide me

Unfortunately, I have no answer for you. This files is hosted on GitHub. The fact Arduino IDE can't download it relies on your configuration, network, proxy, ....
You could eventually file an issue on Arduino side.


3.11 Job browser displays only the first 1000 jobs from resource manager start

When the resource manager has been running for sometime and has run more than 1000 (50 * 20) jobs  the newer jobs are no longer displayed. This is because the resource manager api does not return the latest 1000 jobs when limit is set to 1000.But only returns first 1000 jobs.
I have hacked a quick solution that sets startedTimeBegin to timestamp 24 hours ago as API query param in /hue/apps/jobbrowser/src/jobbrowser/api.py about line 196. This of course is not such a great solution but works for now.
This is with resource manager on hadoop version Hadoop 2.7.2-amzn-3 but I have seen same issue applies in cloudera
http://community.cloudera.com/t5/Web-UI-Hue-Beeswax/Hue-Job-Browser-is-not-working/m-p/46644
The worse alternative is to restart the resource manager and so clear the jobs list.

Yes, this is a real issue pagination is planned in https://issues.cloudera.org/browse/HUE-1176 and we should look at the sorting capabilities of YARN Resource Manager (will follow-up).

Fixed


Scaffold all needed default components

Right now, there is no documentation and setup for scaffolding essential default components - as we had it in 1.x. This is really missing as part the setup instructions.
Furthermore, even the playground misses essential components like DrupalTabs. https://github.com/drunomics/lupus-decoupled-nuxt3-demo/tree/19846821f45f213c51ba7c1b2cf3afa145bc1769 has it.

@fago Please check #148 - it adds a script for scaffolding default components in the same way we had it solved in Nuxt 2.


Some TwitchApi calls swallow exceptions

When long ago I've tried to use GetTwitchStream(string channel) I did not understand why I'm always getting null in return. I thought that maybe TwitchLib is outdated or i need to pass channel with some prefix or something. Only when I've looked up the source code I've realized that MakeGetRequest probably fires an exception because both ClientId and accessToken are null.
This came as a surprise because I've already been successfully using UpdateStreamTitleAndGame(string status, string game, string channel, string accessToken = null) without doing anything else. I was certain that if the method needs something, it would ask this via parameters so I had no idea SetClientId exists and must be used prior to GetTwitchStream call, so the message in (swallowed) InvalidCredentialException would have been useful.
I assume that swallowing exceptions were intended for random http errors and stuff like that, so I suggest that only InvalidCredentialException should be rethrown.
EDIT: Actually I've noticed that TwitchLib tries to explain http errors also in regards to twitch (handleWebException), so maybe swallowing all that information was not intended ?

This is a good issue. A lot of earlier code was very lazy, hastily done and not a lot of thought put into it. Virtually the entire TwitchApi could use some work with exceptions and how data is returned.
If I understand you correctly, unauthenticated calls should work with either client Id, or oauth token, instead of absolutely requiring a client Id (this makes sense to me). Random http errors should be bubbled up, and specific http errors should be handled with an exception that helps the user of the library understand why the exception was thrown (BadResource, BadScope, InvalidCredentials, etc).

If I understand you correctly, unauthenticated calls should work with either client Id, or oauth token, instead of absolutely requiring a client Id (this makes sense to me).

Since I haven't read Twitch API specs, I didn't even realize ClientId is not required if oauth token is provided. My old solution back then was to copy-paste internal code of GetTwitchStream into my project and provide both ClientId and oauth token just to be safe ;). Yeah if any of them is enough, I'd like the TwitchLib API to reflect that, so I could use both UpdateStreamTitleAndGame and GetTwitchStream the same way (via oauth token).
Regarding exceptions like BadResource, BadScope, InvalidCredentials - yea those would be useful to receive since they are about using TwitchApi properly.
Http errors are also okay I guess. Though I think they might also happen in async continuation of await new StreamReader (I've no idea how async http works, just thinking) and would require more handling.

Hi, sorry about the delay on this.
I have created a branch with some changes mentioned in this issue. The changes are listed below, and available in the branch 84.

MakeGetRequest now checks if ClientId AND accessToken (passed in string) AND AccessToken (saved string) are all null before throwing the InvalidCredentialException.
GetTwitchStream now throws StreamOfflineException if the stream is offline.
GetTwitchStream now throws BadResourceException if the passed in channel is invalid.

Allright, I've looked through the changes. The exceptions are okay now, though I'd like the InvalidCredentialException to also mention SetAccessToken(). Something like "Set Client-Id/AccessToken by using SetClientId()/SetAccessToken()". I think you mentioned only SetClientId because accessToken sometimes is provided via parameters, but for GetTwitchStream for example that is not the case. This actually leads to a second question - do you plan on making GetTwitchStream have an accessToken parameter ? Because initially thats what confused me - GetTwitchStream doesnt ask for any credential information, yet complains that I didn't provide ClientId or AccessToken. I understand that if you add accessToken parameter, then this could lead to you making changes to every other method for consistency, so I'm not sure if you're heading in that direction.

GetTwitchStream is not an authenticated call, so it does not require an access token (it can have one, not necessary though). All calls hitting the Twitch API however require a ClientId for identification.
If a ClientId is not set, but accessToken is passed or AccessToken has been set, the request should still work. Basically, Twitch needs a way to identify who is calling the api. The accessToken/AccessToken is only required when accessing private resources or when changing profile properties.
It's a bit confusing, let me know if you sort of understand.

I've read (finally) Twitch API specs about this. It seems they require ClientId in every request, yet as I understand it from your posts they don't really reject calls without ClientId. At least I've been successfully using UpdateStreamTitleAndGame with only accessToken. So my usage was incorrect then I guess.
Okay, with that out of the way, I still have a correction suggestion to InvalidCredentialException:
I remember when I've first read the exception message I was like "huh, how can I set clientId using a parameterless method SetClientId() ? This error is misleading." ;). Only later I've found out that this is a static method accepting a parameter. Not sure if everybody interprets that message the same way so up to you. The way I'm seeing a possible correction is smth like "SetClientId(...)" or "SetClientId(string)" or maybe even better "SetClientId method"

Ya, I'm not sure if it specifically lists it, but I remember reading a response on the Twitch dev forum from a staff/engineer member that said that clientId or accessToken can be used to identify yourself, so both should (continue to) work.
As far as the SetClientId, I can get behind your suggestion. Give me a second to push that.

yes that is very clear. thank you.

Cool, changes should be applied in #87
Thanks again!


Refactor: Allow More Answer Types to Be Cacheable

This PR introduces the WithBaseAnswer interface as the cache value type to allow broader answer types to be included in the cache. The answers_generate.go script, when run with go generate, implements the required interface function BaseAns for each eligible answer struct.

And for context, this is going to enable us to cache DNSKEY and DS entries so @developStorm can add DNSSEC validation support into ZDNS.


update OperationsProblemResults

[x] make OperationsProblemResults interface consistent with ProblemResults
[x] handle receeding horizon in read_realized_... functions

This seems to be failing because it's using PowerSystemsCaseBuilder#v0.3.2, with v0.3.0 tests pass locally. I don't know how to pin it in the tests.

This seems to be failing because it's using PowerSystemsCaseBuilder#v0.3.2, with v0.3.0 tests pass locally. I don't know how to pin it in the tests.

For some reason the CI isn't catching the compat in the tests Project.toml

@claytonpbarrows I merged #641 that should solve the testing issues. If you rebase we should be ok


<EMAIL_ADDRESS>$router.back not work as expected

Versions

nuxt: V2.15.4
node: v14.15.1

Reproduction
https://codesandbox.io/s/nuxt2154-routerback-error-7s1p8
online demo
module.export.default = {
 // Disable server-side rendering: https://go.nuxtjs.dev/ssr-mode
  ssr: false,

  // Target: https://go.nuxtjs.dev/config-target
  target: "static",

  router: {
    mode: "hash"
  },

 // default ...
}

Steps to reproduce

navigate from home to about
refresh about 3 times
click a button to call $router.back(), the page is still about
after i clicked the back button 4 times, it navigate to home

What is Expected?
after the back-button once, it`ll back to home

the same config with<EMAIL_ADDRESS>demo
$router.back() work as expected.

The same bug happens in https://nuxtjs.org/


[SPARK-9373][SQL] Support StructType in Tungsten projection [WIP]

I think this is actually already working end-to-end, but needs more documentation and refactoring before going in.
Also the new TungstenProject is turned on all the time -- it should go behind a flag.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Test build #1206 has started for   PR 7689 at commit 0cae3e8.

Test build #1206 has finished for   PR 7689 at commit 0cae3e8.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build triggered.

Merged build started.

Test build #38578 has started for   PR 7689 at commit f1bee3a.

Test build #38578 has finished for   PR 7689 at commit f1bee3a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class StructWriter
 public static class IntervalWriter
case class TungstenProject(projectList: Seq[NamedExpression], child: SparkPlan) extends UnaryNode

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38590 has started for   PR 7689 at commit da6aed9.

Test build #38590 has finished for   PR 7689 at commit da6aed9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class StructWriter
case class CreateStructUnsafe(children: Seq[Expression]) extends Expression
case class CreateNamedStructUnsafe(children: Seq[Expression]) extends Expression
case class TungstenProject(projectList: Seq[NamedExpression], child: SparkPlan) extends UnaryNode

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Jenkins, test this please.

Merged build triggered.

Merged build started.

Test build #38598 has started for   PR 7689 at commit ce94678.

Merged build triggered.

Merged build started.

Test build #38599 has started for   PR 7689 at commit f71b659.

Test build #38599 has finished for   PR 7689 at commit f71b659.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class StructWriter
case class CreateStructUnsafe(children: Seq[Expression]) extends Expression
case class CreateNamedStructUnsafe(children: Seq[Expression]) extends Expression
case class TungstenProject(projectList: Seq[NamedExpression], child: SparkPlan) extends UnaryNode

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38616 has started for   PR 7689 at commit be9f377.

Test build #38598 timed out     for PR 7689 at commit ce94678     after a configured wait of 175m.

Merged build finished. Test FAILed.

Test build #38616 has finished for   PR 7689 at commit be9f377.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class RFormula(override val uid: String) extends Estimator[RFormulaModel] with RFormulaBase
 public static class StructWriter
case class CreateStructUnsafe(children: Seq[Expression]) extends Expression
case class CreateNamedStructUnsafe(children: Seq[Expression]) extends Expression
case class TungstenProject(projectList: Seq[NamedExpression], child: SparkPlan) extends UnaryNode

Merged build finished. Test PASSed.

Looks like UnsafeRow.get doesn't support IntervalType:
 org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1153.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1153.0 (TID 4994, localhost): java.lang.UnsupportedOperationException: Unsupported data type interval
[info]   	at org.apache.spark.sql.catalyst.expressions.UnsafeRow.get(UnsafeRow.java:271)
[info]   	at org.apache.spark.sql.catalyst.CatalystTypeConverters$IdentityConverter.toScalaImpl(CatalystTypeConverters.scala:144)
[info]   	at org.apache.spark.sql.catalyst.CatalystTypeConverters$CatalystTypeConverter.toScala(CatalystTypeConverters.scala:118)
[info]   	at org.apache.spark.sql.catalyst.CatalystTypeConverters$StructConverter.toScala(CatalystTypeConverters.scala:268)
[info]   	at org.apache.spark.sql.catalyst.CatalystTypeConverters$StructConverter.toScala(CatalystTypeConverters.scala:235)

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

At a high level this seems fine to me, but I haven't looked in super-close detail yet.  I'm fine with merging this pending tests and continuing to iterate in followup patches.

Thanks - going to merge this and submit a pr to fix the remaining issues tonight.


Made changes to index.html

Hey @AmanNim98  thnx for contributing , Contribute in this year's Hacktoberfest in October 2020 and follow me on Github and Star this repo for updates and notifications about the project.


Sanjo/vault release

Let's rename the  KidVault trait to KeyIdVault and everywhere rename kid to key_id

An update to the README and lib.rs rustdoc header:

In order to support a variety of cryptographically capable hardware we maintain loose coupling between our protocols and how a specific building block is invoked in a specific hardware. This is achieved using an abstract Vault trait.

A concrete implementation of the Vault trait is called an Ockam Vault. Over time, and with help from the Ockam open source community, we plan to add vaults for several TEEs, TPMs, HSMs, and Secure Enclaves.

This crate provides a software-only Vault implementation that can be used when no cryptographic hardware is available. The primary Ockam crate uses this as the default Vault implementation.

Based on: https://github.com/ockam-network/ockam/blob/develop/documentation/concepts/vaults.md

Let's rename the KidVault trait to KeyIdVault and everywhere rename kid to key_id

I think KID is generally accepted form of KeyId, still we can rename. @mikelodder7 @mrinalwadhwa thoughts?

Thanks for all of those fixes @SanjoDeundiak, after we land https://github.com/ockam-network/ockam/pull/845 can you please rebase and then we will land this PR?

@SanjoDeundiak looking great. Could you please squash/reword any commit description of "kid vault" so that it doesn't appear anywhere in the source history?


nadeko doesn't leave voice when done playing

In version 0.8 b14.2, i noticed this "nadeko doesn't leave voice when done playing, instead leaves only on !m s" thing.
Is it possible to change back to it's old behaviour via json or from somewhere else?

No, why are you bothered by her staying? She is not spying you or anything
for now

Hmm... thats sad )';
People in my server like when nadeko is more "mobile" let's say
for example in old behavior it's just easy to type !m q [link], and Nadeko would come to you,
but now people will need to check if Nadeko in anyother channel and try to move Nadeko from channel to another with different commands. (easy people like, that you need only 1 command to operate the bot)
I can see the convinience of static bot that stays on channel, but there is people that like old kind of Nadeko but still want new music code.
can it be an option to change this behavior? could it be done, or is it just a fantasy, that i share with my server?


Uncaught UnicodeEncodeError on startup

Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/vimiv/app.py", line 183, in activate_vimiv
self._init_widgets()
File "/usr/lib/python3.6/site-packages/vimiv/app.py", line 370, in _init_widgets
self["library"] = Library(self)
File "/usr/lib/python3.6/site-packages/vimiv/library.py", line 75, in init
self.set_model(self._liststore_create())
File "/usr/lib/python3.6/site-packages/vimiv/library.py", line 327, in _liststore_create
self.files, filesize = self._filelist_create()
File "/usr/lib/python3.6/site-packages/vimiv/library.py", line 380, in _filelist_create
for sub in subfiles[:file_check_amount]
File "/usr/lib/python3.6/site-packages/vimiv/library.py", line 381, in
if is_image(os.path.join(fil, sub))]
File "/usr/lib/python3.6/site-packages/vimiv/fileactions.py", line 101, in is_image
return bool(GdkPixbuf.Pixbuf.get_file_info(complete_name)[0])
UnicodeEncodeError: 'utf-8' codec can't encode characters in position 22-23: surrogates not allowed

It looks like it is having problem with one specific filename, can you share the exact name of the file that creates this problem, possibly even the file itself?

yes,there have three files, l will pass on these files.thank you.``
Uploading fileactions_py.txt…
Uploading library_py.txt…
app_py.txt

i don't know what happened ,but i find when i use the vimiv in ~/ folder ,the vimiv will return this error.if in another folder such as the ~/picture ,vimiv can be run.it's very funny.Perhaps i need move some picture to the ~/picture folder.

Umm, sorry if I was being unclear. I didn't mean the source files of vimiv, but the file in your home folder that creates this exception.
I am pretty sure you have one file which vimiv is trying to read, but isn't able to because of some weird character in the filename.
The output of ls ~ should also do, unless you have some confidential information there, then you will have to find out manually which file it is.
I would like to be able to reproduce the problem with the same character and then fix this by simply catching the exception :smile:

No,i only to open a screenshot,but ... the screenshot is a png file.i will try to remove the files in home folder,and i will open the vimiv again.if i find the file i will tell you.

i find it! the Downloads  folder have some problem.when i come to the Download folder i find a very strange folder,one folder which download from a netdisc ,that folder is a windows folder which be file compressioned. And when i open it in Arch linux by unzip.the folder will have a very strange name, like this #@$%@%@$^%&$/#$%#@%@\03#@￥%@%/. it the windows's problem which be issued in China.(windows of Chinese version)Maybe in US or other country where in English.This problem will not happen.thank you.And solving the problem , the best way is change the folder name.

Thanks for investigating!
I think c16dbc92d8ec96a21476e81c90c9100389c8969b should fix this as well, I accidentally linked the wrong issue in the commit, shame on me :smiley:

no,l have not found this question at first,this is my problem.and thank you help me to solve this question.

Closing as this seems to be solved, sorry for the long delay :smiley:


Only allow send bonuses to otech user

Issue #834

[x] Fix advanced wallet configuration
[x] Allow only otech to send bonuses

@otech47 test this when you can, go to any project and see if you have the option to send bonuses. I tested with my user but I want to make sure it works with yours.

We can test in staging


FFI not working on Windows

I'm using a very simple program to brush up on my knowledge of Dart FFI. NumberStorage is a simple class which interacts with a C struct containing two integers.
final ns = NumberStorage(123, 456);
print(ns.GetA()); // should print 123
print(ns.GetB()); // should print 456
ns.FreeNumberStorage();

I've tested my code on Linux, and it works perfectly. However, on Windows, the code just hangs as soon as I try and call any C function, and dart.exe starts using loads of CPU. Nothing gets printed to the console.
I'm on Windows 11, but I've tested on Windows 10 and the same weird behaviour occurs.
dart --version is 2.13.4 (stable) on all operating systems.

/cc @dcharkes

@jaddison06 what is the definition of NumberStorage?

I'm creating this using some custom codegen, so sorry that it's so ugly!
class NumberStorage {
    Pointer<Void> structPointer = Pointer.fromAddress(0);

    void _validatePointer(String methodName) {
        if (structPointer.address == 0) {
            throw Exception('NumberStorage.$methodName was called, but structPointer is a nullptr.');
        }
    }

    late _libTest_class_NumberStorage_method_InitNumberStorage_sig _InitNumberStorage;
    late _libTest_class_NumberStorage_method_FreeNumberStorage_sig _FreeNumberStorage;
    late _libTest_class_NumberStorage_method_GetA_sig _GetA;
    late _libTest_class_NumberStorage_method_GetB_sig _GetB;

    NumberStorage(int a, int b) {
        final lib = DynamicLibrary.open('build\\native\\libTest.dll');

        // INITIALIZER
        _InitNumberStorage = lib.lookupFunction<_libTest_class_NumberStorage_method_InitNumberStorage_native_sig, _libTest_class_NumberStorage_method_InitNumberStorage_sig>('InitNumberStorage');

        _FreeNumberStorage = lib.lookupFunction<_libTest_class_NumberStorage_method_FreeNumberStorage_native_sig, _libTest_class_NumberStorage_method_FreeNumberStorage_sig>('FreeNumberStorage');
        _GetA = lib.lookupFunction<_libTest_class_NumberStorage_method_GetA_native_sig, _libTest_class_NumberStorage_method_GetA_sig>('GetA');
        _GetB = lib.lookupFunction<_libTest_class_NumberStorage_method_GetB_native_sig, _libTest_class_NumberStorage_method_GetB_sig>('GetB');

        structPointer = _InitNumberStorage(a, b);
    }

    void FreeNumberStorage() {
        _validatePointer('FreeNumberStorage');
        return _FreeNumberStorage(structPointer);
    }

    int GetA() {
        _validatePointer('GetA');
        return _GetA(structPointer);
    }

    int GetB() {
        _validatePointer('GetB');
        return _GetB(structPointer);
    }
}

And the definitions of InitNumberStorage, FreeNumberStorage, GetA and GetB?
P.S. You might want to use static late variables for your _InitNumberStorage etc so that you reuse them among instances.
P.S. 2 If you just write a C header file package:ffigen can generate the bindings for you. But if you're already writing a generator that maybe doesn't help you :)

Can you provide a full minimal reproduction? With these partial snippets of code I cannot reproduce it. There could be something wrong with your bindings for example in _libTest_class_NumberStorage_method_InitNumberStorage_sig. (e.g. the sizes of ints in the struct and function arguments.) Or, there could be something wrong with the windows built dll.
If you want to debug it yourself, you can try running the Dart executable in visual studio with the dart file as argument, then it will open the debugger on a crash or you can break in the debugger if it ends up in an endless loop.

Hi, sorry for the late reply - I've been away. I tried following the official hello world, and that didn't work either, so it seems like there was a problem with my setup. I was using gcc-10.2.0 from Cygwin, but I've now switched to WSL and it's working perfectly.


added PCI-DSS to OCP on GCP

This PR updated the OCP on GCP install docs and code to add PCI-DSS policy. I have also updated the top level readme to reflect addition of the policy.

Approved, but leaving this open since AG said he was going to take a look.

@abdullahgarcia  - pls could you review / merge.  Many thanks A

LGTM


Added new setting "Select on Click"

OK I deleted every thing and started from scratch.
This time I just inserted the code using the Git Web-Editor, no VS2022.
I also committed each edit individually, so hopefully all will be OK.
What the edit does is add a Setting on the created web page to have selection by a click on an item.
This is more preferable to me than hovering the mouse over the item, I use the web page to help me place the components, as it is, if I accidently nock my mouse something else is selected and I end up placing components in the wrong place.
As I am not familiar with all code, to change the setting a new creation of the web page needs to be done. It may have been better in the creation menu.
Personally I would remove the setting and change it permanently, but as it is not my application, having it as a setting gives the choice.

There were still a lot of issues with this PR so I fixed it myself and pushed fixed version with your commit as basis
https://github.com/openscopeproject/InteractiveHtmlBom/commit/2b8dfa665e2ae43fd47efbf38d0708cbab2a5413
Thanks

Glad we got there in the end.
I have no idea why I get issues, this time I just used the GitHub web site, so it should have been ok.

It was different kind of issues (not git related) in the last attempt, some logic issues, some formatting (tabs instead of spaces), variable/function naming and such.

Every one has there own way of writing code.
Me, I'm a dyslexic draughtsman, my written hand is large caps and small caps no lower case and tab every thing. haha.
I tried to minimize the damage :)

You can change the setting live and I kept "highlight" instead of "select" for consistency so the wording is correct.


Revert "Bump the all-minor-patch-updates group across 1 directory..."

…h 5 updates (#924)"
This reverts commit 0c31fac3d3c77d63295f9428edc9c9940d9445d5.

This PR reverts the changes for version upgrades, as jupyterlab was included in this and we require <4.2 for now as anything greater breaks our atoti-jupyterlab extension. As a result, I have also added an ignore clause to dependabot.yml for jupyterlab.

Decided to keep the version bump changes for everything else other than jupyterlab. That specific revert is now found in https://github.com/atoti/atoti/pull/926. Therefore, closing this PR.


Alvin/slam

Launch simulation with SLAM
Added default RVIZ config and launch file
asl_tb3_sim now depends on asl_tb3_driver
Fixed launch arguments

Is there a way to move the turtlebot around? I wasn't able to see if the map was actually updating in RVIZ.
Try running ros2 run turtlebot3_teleop teleop_keyboard. This built-in teleop script is quite bizarre to use, but should suffice for testing purposes. I will get a better teleop node later.


Throttle with durationSelector

Implement throttle(durationSelector) and add its tests. Resolves #666 and #496.
DEPENDS ON PR #700 MERGED FIRST.

Merged with c3bf3e7 ... awesome work @staltz


Wishlist: Start and stop timestamps

As an operator
I want both a start and stop timestamp in bosh tasks recent output
So that I can search for events that correlate to something that happened at a certain time.

@jim80net

Makes sense.

Story: https://www.pivotaltracker.com/story/show/115793569

Closing - fixed as of v256.


VS code python debug error

I am debugging my python scripts to locate the cause of the error and get this:
ptvsd: error: no such option: --client
Traceback (most recent call last):
File "/home/shawn/.vscode/extensions/ms-python.python-2018.10.1/pythonFiles/experimental/ptvsd_launcher.py", line 16, in
from ptvsd.main import main
File "/usr/local/lib/python2.7/dist-packages/ptvsd/main.py", line 42, in
(opts, args) = parser.parse_args(argv)
File "/usr/lib/python2.7/optparse.py", line 1402, in parse_args
self.error(str(err))
File "/usr/lib/python2.7/optparse.py", line 1584, in error
self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg))
File "/usr/lib/python2.7/optparse.py", line 1574, in exit
sys.exit(status)
SystemExit: 2
I am using "Current File (Integrated Terminal)" Configuration. Is there anybody knowing how to fix it?
Thanks,
Shawn

Please uninstall ptvsd from your environment.


Updating JSHINT settings

removing deprecated options in the latest versiosn of jshint which will be replaced by adding JSCS settings.
@rhutchison when you add your JSCS PR this PR will complement it to remove those code style options from JSHINT which are deprecated

@lirantal when were these deprecated. @rhutchison is there a comparison table for JSCS and JSHint? I'm also hoping that whatever new syntax/formatting tools we add will be able to support ES6?

@ilanbiala from jshint.com website  http://jshint.com/docs/options/

go ahead and update your local jshint settings to indent 8, or 10, and run grunt and you'll see that it doesn't report anything, because it has no more impact, it's deprecated...

Ok, so then there's no need for the comparison table. Still, I want to try to support ES6 already if possible.

what does it mean/entitle to support ES6 from your perspective?

Linters/formatters will have an issue with ES6 code because the syntax is different. Ideally, our tools will be able to deal with ES6 and ES5 code, so not only users of MEAN can write ES6 if they want to, but we can start moving to it as it becomes more commonplace.

Is it too soon to talk about ES6 now, though? We have enough PRs on our plate to handle so I say let's get that PR backlog cleaned and can discuss further roadmap.

@lirantal I'm not saying we should be actively trying to use ES6, but so we don't have to think about it again in the future, if possible we should spend a couple extra minutes just verifying that there won't be issues if we do start using ES6.

What do you suggest we do? review which settings we need to add to JSHint / JSCS?

Just check if ES6 is supported and how well. No need to do so much setup just yet in my opinion.

From a quick research both JSHint and JSCS have support for ES6:

http://jscs.info/overview.html - through the esnext operator
https://github.com/jshint/jshint/blob/master/examples/.jshintrc - same esnext operator

@ilanbiala any other concerns you'd like to consider for this to be merged?

Maybe just add esnext and then you can merge.

Great, added, and squashed commits.


fix(logs): Removing debugging screen spam

:tada: This PR is included in version 2.2.4 :tada:
Your semantic-release bot :package::rocket:


Remove generated artifacts

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ceae625) 36.00% compared to head (acc141b) 36.35%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   36.00%   36.35%   +0.35%
==========================================
  Files          22       21       -1
  Lines        1800     1367     -433
==========================================
- Hits          648      497     -151
+ Misses       1124      842     -282
  Partials       28       28

Flag
Coverage Δ

Linux
36.35% <ø> (+0.35%)
:arrow_up:

Windows
?

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tags for branch names containing "#" parsed incorrectly ignoring the "#"

Behaviour
When I run metadata for on my branch banner-utils-test-#5 gives me a tag of: banner-utils-test--5. Is this expected?
JSON output
  {
    "tags": [
      "ghcr.io/xxx/xxx:banner-utils-test--5" 👈
    ],
    "labels": {
      "org.opencontainers.image.title": "xxx",
      "org.opencontainers.image.description": "Thing related to xxx",
      "org.opencontainers.image.url": "https://github.com/xxx/xxx",
      "org.opencontainers.image.source": "https://github.com/xxx/xxx",
      "org.opencontainers.image.version": "banner-utils-test--5",👈
      "org.opencontainers.image.created": "2022-04-29T09:30:00.228Z",
      "org.opencontainers.image.revision": "xxxx",
      "org.opencontainers.image.licenses": ""
    }
  }

Relevant actions/checkout logs for the branch info:
Checking out the ref
  /usr/bin/git checkout --progress --force -B banner-utils-test-#5 refs/remotes/origin/banner-utils-test-#5 👈
  Switched to a new branch 'banner-utils-test-#5'
  branch 'banner-utils-test-#5' set up to track 'origin/banner-utils-test-#5'. 👈
/usr/bin/git log -1 --format='%H'
'0f74d16753f11edb247f21e16e9be6d80ed3b387'

Steps to reproduce this issue
Try on a branch like xxxx-xx-#3
Expected behaviour
I don't know if this is the intended behaviour.
banner-utils-test-#5 should translate to it self instead of banner-utils-test--5
Configuration
name: build-test
on: [push]
jobs:
  Lint-Build-UnitTest:
    runs-on: ubuntu-latest
    env:
      REGISTRY: ghcr.io
      IMAGE_NAME: ${{ github.repository }}
    steps:
      - uses: actions/checkout@v2
      - uses: actions/setup-node@v2
        with:
          node-version: "16"

      - name: npm ci (normal) on ./functions - fast
        run: npm ci --no-audit --progress=false
        working-directory: ./functions

      - name: prettier
        run: npm run prettier

      - name: lint
        run: npm run lint

      - name: build
        run: npm run build

      - name: unit-test
        run: npm run test:unit

      - name: Delete dev node_modules
        run: rm -rf node_modules
        working-directory: ./functions

      - name: npm ci --prod on ./functions - fast
        run: npm ci --production --no-audit --progress=false
        working-directory: ./functions

      # docker starting
      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v1

      - name: Log in to the Container registry
        uses: docker/login-action@v1
        with:
          registry: ${{ env.REGISTRY }}
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Extract metadata (tags, labels) for Docker 👈
        id: meta
        uses: docker/metadata-action@v3
        with:
          images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}

      - name: Build and push Docker image
        uses: docker/build-push-action@v2
        with:
          context: .
          push: true
          tags: ${{ steps.meta.outputs.tags }} 👈
          labels: ${{ steps.meta.outputs.labels }}
          cache-from: type=registry,ref=${{ steps.meta.outputs.tags }}
          cache-to: type=inline

  Integration-Test:
    runs-on: ubuntu-latest
    needs: Lint-Build-UnitTest
    container:
      image: node:16.13.2-slim
      env:
        GCLOUD_PROJECT: demo-friendly-octopus-u4st7gxr8
        FIRESTORE_EMULATOR_HOST: firebase_emulator:8080
        FIREBASE_STORAGE_EMULATOR_HOST: firebase_emulator:9199
        FIREBASE_AUTH_EMULATOR_HOST: firebase_emulator:9099
        MONGO_DB_URI: mongodb://mongodb:27017

    services:
      firebase_emulator:
        image: ghcr.io/xxxx/xxxx:${{ github.ref_name }}
        env:
          FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
          AVOID_FUNCTIONS_EMULATION: "yes"

      mongodb:
        image: mongo
        env:
          MONGO_INITDB_DATABASE: Friendly

    steps:
      - uses: actions/checkout@v2

      - name: fresh npm ci
        run: npm ci --no-audit --progress=false
        working-directory: ./functions

      - name: build
        run: npm run build
        working-directory: ./functions

      - name: Integration Test
        run: npm run test:integration

@vajahath Yes this is quite similar to https://github.com/docker/metadata-action/issues/56#issuecomment-815569770 and https://github.com/docker/metadata-action/issues/189.
TLDR; tags are sanitized to replace unsupported char sequences with -: https://docs.docker.com/engine/reference/commandline/tag/#extended-description

A tag name must be valid ASCII and may contain lowercase and uppercase letters, digits, underscores, periods and dashes.

I will update the documentation.


Add Flatten layer

Hey,
This PR add Flatten. I have left the data_format attribute. However it doesn't do anything under the hood as it doesn't seem to add value for our use. Should we add a log message for that? I don't think it should return NotImplementedError in this context.
Thanks

I think it's ready to be merged. Thanks

on a roll!


Language APIs table is incorrect

Hi there, the video indexer entry in the languages apis table is incorrect, since video indexer belongs to the Vision APIs. Also under the Language APIs is missing the Immersive Reader service, as mentioned here - https://docs.microsoft.com/en-us/azure/cognitive-services/.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a5ead4a3-3e74-b543-c686-73cf3c899bfb
Version Independent ID: 17980270-d395-92b6-36c6-837ce9576f90
Content: What are Azure Cognitive Services? - Azure Cognitive Services
Content Source: articles/cognitive-services/Welcome.md
Service: cognitive-services
GitHub Login: @nitinme
Microsoft Alias: nitinme

@hugobarona Thanks for bringing this up. @nitinme Could you please review the cognitive services landing page and align the services according to their functionality?

@RohitMungi-MSFT @hugobarona - I'll fix it - please assign to me. #in-progress

Thank you @diberry. I noticed as well that the Cognitive Services page is not listing some of the new Cognitive Services available, such as Local Business Search  under the Web Search APIs. I was looking at the documentation and i did not realize that this service was available, until i watched a video from 2018 and the video talked about Local Business Search API.

@hugobarona - all lists of services on docs.microsoft.com are being reviewed by the content team. The list on azure.microsoft.com should be directed elsewhere. I'm make sure to handle that offline.
#please-close


PipeArray example is not runnable on Intel devcloud

Summary
It seems that the tutorial in https://github.com/oneapi-src/oneAPI-samples/tree/master/DirectProgramming/C%2B%2BSYCL_FPGA/include
is not consistent with the latest dpc++ version
Version
icpx --version
Intel(R) oneAPI DPC++/C++ Compiler 2023.0.0 (2<IP_ADDRESS>21201)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /glob/development-tools/versions/oneapi/2023.0.1/oneapi/compiler/2023.0.0/linux/bin-llvm
Configuration file: /glob/development-tools/versions/oneapi/2023.0.1/oneapi/compiler/2023.0.0/linux/bin-llvm/../bin/icpx.cfg
Environment
Intel devcloud
Steps to reproduce
run the tutorial
https://github.com/oneapi-src/oneAPI-samples/tree/master/DirectProgramming/C%2B%2BSYCL_FPGA/Tutorials/DesignPatterns/pipe_array
on Intel devcloud
mkdir build
cd build
make

Observed behavior

seems like `sycl::ext:: intel:: fpga_emulator_selector_v` couldn't be found
Expected behavior
should be able to run the PipeArray example

OneSmpl_Team1 working on this.

(OneSmpl_Team1)
@Arthur-Chang016
sycl::ext:: intel:: fpga_emulator_selector_v can be found at oneAPI 2023.1 release, Current DevCloud automatic installed 2023.0 release as you provide, so you could either try latest oneAPI release, or select the corresponding oneAPI-samples tag.


[Doc] Documents for WSO2IS-5.3.0 and WSO2IS-5.7.0 are not updated on "Configuring SAML2 Front-Channel Logout".

Description:
Documents for WSO2IS-5.3.0 and WSO2IS-5.7.0 are not updated on "Configuring SAML2 Front-Channel Logout". Only WSO2IS-5.8.0 documentations are updated.
Suggested Labels:
Type/Documentation
Affected Product Version:
WSO2IS-5.3.0, WSO2IS-5.7.0

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


"Autoslay EHP" for Araxyte tasks sends a normal trip, without cannon or barrage active.

🐛 Bug Report
Autoslay EHP is meant to automatically send a trip with max efficiency if possible, ie cannon & barrage. For Araxytes, it only sends a trip with neither of those options despite being able to do a trip with cannon and barrage manually.

Hard to show the autoslay ehp being clicked in image, but i did click it

Should be fixed in next update


DBZ-844 Use table charset for parsing string defaults

https://issues.jboss.org/browse/DBZ-844

Rebased and applied. Also pushed one more commit to explicitly assert the application of the default char set from the table level.
Thanks, @jpechane!