Very short separate traces are labeled duplicate if starting in the same second

I'm implementing ASDF for my lab seismology/AE experiments and have run into a timescales issue. My waveforms come as ~1 Msample blocks at 20 MHz, often multiple of these blocks occur within one second. When add_waveforms checks for duplicate traces, the lines quoted from __get_waveform_ds_name truncate the times to seconds and thus reject any traces that started in the same second as duplicates.
https://github.com/SeismicData/pyasdf/blob/c976927284efdec1264d652d47e4d0048dfe6f5c/pyasdf/asdf_data_set.py#L1299-L1300
This is a three character fix:
"%Y-%m-%dT%H:%M:%S" -> "%Y-%m-%dT%H:%M:%S.%f"
I'm new to open source contributing and this community. Should I just clone and make this fix for myself?

Hi,
good point and this should definitely be changed. Instead of simply always adding the microseconds might I suggest to only add them if start and end would otherwise be different?, e.g. something like
fmt_string = "%Y-%m-%dT%H:%M:%S"
s = start.strftime(fmt_string)
e = end.strftime(fmt_string)

if s == e:
    fmt_string = "%Y-%m-%dT%H:%M:%S.%f"
    s = start.strftime(fmt_string)
    e = end.strftime(fmt_string)

if s == e:
    raise ValueError("Some sensible error message")

...

Then the files will be identical to the current ASDF files except if really necessary.
This would additionally require to increment the version number of the ASDF format. It is currently 1.0.1 and thus should probably be incremented to 1.0.2. pyasdf should be ready for this but it also requires changes here: http://asdf-definition.readthedocs.io
The regular expression specifying the allowable dataset names has to be changed to optionally accomodate the microseconds. This has to be done in two places:

http://asdf-definition.readthedocs.io/en/latest/waveforms.html#waveform-traces
A new schema for version 1.0.2 should be added here: https://github.com/SeismicData/asdf_validate/tree/master/asdf_validate/schemas

I'm new to open source contributing and this community. Should I just clone and make this fix for myself?

Yes - basically you clone this and other repositories, make all required changes, best add some tests and then send a PR which contains your changes. Then we'll have a look and most likely merge them. I can also take care of this in the next couple of days but it would be great if you'd be open to give it a shot.

Thanks for your help! I'm taking a shot in the PR's linked by references above.

Thanks a lot! All looks pretty good. Before I start merging these things - I have no experience with lab data but do you think it might make sense to directly use nanoseconds instead of microseconds?

Based on my lab work and what I know about others', I find it hard to imagine a need to store a waveform shorter than 1 microsecond. However, it would certainly be even more adaptable if it used nanosecond precision. Is there any character limit concern on the length of a dataset name, or any other reason not to include nanoseconds?
I also don't see a strftime format code for nanoseconds. My obspy traces do show nanoseconds so I could dig for whatever is used there.

Sorry for the delay. I added a few commits to your changes to write nanoseconds instead of microseconds and I also added a few tests. In the end your question if there is any reason not to include nanoseconds convinced me. I could not think of any reason not to include them and there might be some use cases where this is interesting.
I'll release a new version of pyasdf within this week which will include all the changes.
Thanks a lot for everything!

pyasdf version 0.4.0 is live on pypi and should also be available via conda before too long: https://github.com/conda-forge/pyasdf-feedstock/pull/6


spk hld init should create a component.yaml

Describe the bug:
If we have an empty HLD, the HLD to manifest pipeline will fail to run
To Reproduce:
spk hld init
git push
spk hld install-manifest-pipeline
git commit --allow-empty
git push
HLD to manifest pipeline will fail because hld init does not output a component.yaml
Expected behavior:
HLD to manifest pipeline should succeed
Additional context:
Does this require updates to documentation?:

@bnookala is the recommendation that spk hld init just needs to add component.yaml file? cc @mtarng


[fix] [admin] set offload threshold should fail if ns policies is read-only

Motivation
https://github.com/apache/pulsar/pull/19370#discussion_r1092918655  Thanks @lhotari  for helping to check
Admin API set offload threshold should fail if namespace policies are read-only.
Modifications
solve the wrong logic and add test.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

https://github.com/poorbarcode/pulsar/pull/61

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


add guest login

Create a guest login so a user does not have to sign up if just checking out the app


Fix translations.en_US to id_ID

I'm sorry @ziahamza, I forgot to change it and will make webui blank completely
It's urgent to be merged
Edit: I fix some words too

oh damn yes @rafeyu !!! merging

I'm sure, five issues[1] opened after my PR blanked webui. If you want to check and close them. Anyway, thank you for this great tool! :smiley:
1: #437 #438 #439 #441 #442


Use human_attribute_name as default label

Rails 3.1 already does this in label, which already does the heavy lifting here. What does this change?


Collapsus - The Collapsible Menu

🚀 Feature
Collapsible menu . Sub-categories will get collapsed under the main categories. Examples: https://reactjs.org/docs/getting-started.html or https://docs.gitbook.com/getting-started
Have you read the Contributing Guidelines on issues?
Yes I have
Motivation
We have a sizable amount of content and having a large (expanded) menu would overwhelm a user upon visiting our documentation area. Those with weaker nerves may get spooked and run away from our site.
Pitch
We have an "enterprise" level product which comes with sizable documentation. I am sure we are not the only ones. I think having this feature would attract other companies who have similar documentation requirements. Let the Collapsus out!
Thanks!!

🚀 Feature
Collapsible menu . Sub-categories will get collapsed under the main categories. Examples: https://reactjs.org/docs/getting-started.html or https://docs.gitbook.com/getting-started
Have you read the Contributing Guidelines on issues?
Yes I have
Motivation
We have a sizable amount of content and having a large (expanded) menu would overwhelm a user upon visiting our documentation area. Those with weaker nerves may get spooked and run away from our site.
Pitch
We have an "enterprise" level product which comes with sizable documentation. I am sure we are not the only ones. I think having this feature would attract other companies who have similar documentation requirements. Let the Collapsus out!
Thanks!!

Yes.this is indeed.this would be an awesome feature.I also want to show a huge list of content in the side bar.without  the expand collapse option the huge list would be ugly

@endiliey @yangshun
Are there any plans to consider using React to add interactivity? Or should this be worked on using script injection?
https://github.com/facebook/Docusaurus/issues/582#issuecomment-382488782

Docusaurus uses React mainly to render the components statically into HTML on the server, so your code wouldn't work. There's no React library being sent to the client to hydrate the markup and add interactivity.

@tsmrachel that's our plan for Docusaurus v2
You can read on https://github.com/facebook/Docusaurus/issues/789 or https://docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2
Instead of pure static HTML, during build time we will create a server-rendered version of the app and render the corresponding HTML. A Docusaurus site will be essentially an isomorphic/universal application. This approach is heavily inspired by Gatsby.

I could see this being useful for Redux as well.


event was handled twice

When I quit my app, it seemed that my last registered objec "presenter" was still in my memory. And the next time when I lauch my app, a new "presenter" was registered. when dispatch an event, the old "presenter" and the new "presenter" both handled the event. Therefore, the onEvent function was executed twice, which cause my app crashing.
My question is, is there any method i can call to unregister all objects??

No. You have to make sure to call unregister() for all your subscribers at appropriate times. Not sure how your code is set up, but you might try unregistering your presenter in your activity or fragment onPause() or onStop() methods. -ut


Budget Step - Blank Entries

Don't automatically filled in for Current Month and Next Month when Last Month data is entered.

Done.


Monkies spawn while remote control is enabled

Hey @Scriptedisles, sorry for the late reply. It's a limitation of GTA5 that vehicles cannot be operated without a driver, so spawning a monkey in the driver's seat is intentional.


Modify revoke g4 file

Pull Request Test Coverage Report for Build 7511

0 of 0   changed or added relevant lines in 0 files are covered.
282 unchanged lines in 35 files lost coverage.
Overall coverage decreased (-0.02%) to 54.413%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/tcl/SetAutoCommitFiller.java
1
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/encrypt/dml/EncryptDeleteFromWhereFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/ddl/alter/DropPrimaryKeyFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/sharding/dml/DeleteFromWhereFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/ddl/alter/RenameTableFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/ddl/ColumnDefinitionFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/dql/OrderByFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/ddl/alter/DropColumnDefinitionFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/dql/GroupByFiller.java
2
0.0%

sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/filler/common/ddl/CommonTableFiller.java
2
0.0%

Totals

Change from base Build 7510:
-0.02%

Covered Lines:
8581

Relevant Lines:
15770

💛  - Coveralls


V1.2.24 be sp2 - Introducing the Unique Bes TestCase

The unique Testcase will check the validity of the Patch.

It uses a custom payload class and will assert true for unpatched 1.2.24 and will throw exception for patched version.

Added the test cases inside /src/test/java/com/alibaba/json/ where the script can run the testcase automatically

@jobyko @asa1997 please review
@sumodgeorge @panickervinod


Project: FirstPost News website using Next.js, Tailwind.css, Sanity.io

:red_circle: Project Title : NextJS NewsApplication
:red_circle: Aim : A platform utilizing Next.js, a React framework for efficient server-side rendering, routing, and enhancing optimization. The page uses getServerSideProps to fetch server-side data on every page request. This allows the engine to crawl the page content and improves SEO. Integrated Sanity.io as a headless CMS, enabling efficient content creation, management, and delivery, enhancing the flexibility of the application.
:red_circle: Tech Stack Used : Next.js, Tailwind.css, Sanity.io
:red_circle: Category : Next-JS-Projects
Screenshots 📷

:white_check_mark:  Ishitha C - NextJs-newsApp
Full name : Ishitha Jain
GitHub Profile Link : https://github.com/codercake
Participant role: GSSOC'24
Open Source Program: GSSOC

@codercake Issue already present #50


Remove curl image dependency in agent deployment descriptor

When deploying the agent, there is a curl command that is executed in a container within the agent pod (see charts/traction/templates/acapy/deployment.yaml) that registers the agent's DID on the ledger. This is not supported by all ledgers and should be handled in a more generic way.
In particular, this should not be required for the main wallet, when running an agent in multi-tenancy mode: the main wallet should run in read-only mode as it does not have any interaction with the ledger, it is just acting as a "coordinator" for the tenants.

Just adding this from a duplicate issue I just closed. This is the code:
The registration init-container, and related helper code should be removed from the helm chart.

made a comment in the PR, need to fix the multi-tenancy ledger functionality


Dynamically reading templates in multiple threads does not work. Please add lock around tinyxml

Dynamically reading templates in multiple threads does not work.
Would it be possible to add a lock in the dynamic_templates_description::dynamic_templates_description function?
Or at least write it as a limitation that you need to have a look around the dynamic_templates_description::dynamic_templates_description(    const char *xml_content, const char *cpp_ns, template_registry *registry)
function for it not to crash.

The parameter template_registry allows you to control the scope of resource dynamic_templates_description uses. If you need to parse unrelated templates from different threads, you should use the thread_local copy of template_registry for the job. Here is the example,
thread_local static template_registry thread_local_registry;
dynamic_templates_description mydesc(xml, "myns", &thread_local_registry);


Create a discovery survey for contrib programs and gov

the scope of this is to be used:

as a form to be filled out, or
focus group questions

goals:

dig deeper into the contributor programs and governance of cncf projects
collecting best practices, whats not working
in survey form, no more than 5-8 minutes; survey fatigue is real

survey/focus group questions:
//to be added here; collecting from the issues we've already set and collating here
governance topics:

how do you make decisions? is there a difference between code and non code decisions?

contributor growth topics:

have a contributor ladder?
mentoring programs and who do they target? succession strategies?
whats one (or two!) of the biggest challenges the project has in this area? what about contributor related programs and processes that your project can't live without (aka they work great!)?

general related topics:

have a full time community manager, a body of people that performs community like duties (example: working group, special interest group, committee), functions are built into core roles, everyone does community, or another method of community engagement?

resources:
don't ask repeat questions from here https://github.com/cncf/surveys/
timeline:
tbu
open ended questions?

where is the data / info stored?
when does this get sent out?

https://docs.google.com/document/d/1tPMNOtd9H1a42piUws5LDyKDJyJFjqvJ6XYLlNUoaGY/edit

Communication timeline and steps:
1- send to project dev/maintainer lists and one of us should personally reach out as a welcome
2- post to cncf blog and twitter; have Kim McMahon with CNCF take a look first.
3- toc meeting; josh/paris will include in the update
4- project dev/maintainer and cncf applicable slack channels (#toc, etc)
5- ambassadors - slack channel

everything on this issue has been completed with the exception of slack outreach.


feat: allow user to reduce the storage size that is equal to the PVC

Closes #2829
To communicate with the API server, replace webhook.Validator with webhook.CustomValidator. This is the appropriate location for the k8s client.

This implementation is too complex and violates the principle of keeping the webhook code self-contained and not accessing the API server. We need to rewrite it using a field in the status to work as a proxy for the status of PVCs.

Got it @mnencia , I will rewrite this pull request based on status way

resolve conflict and force push


Change the method to get DURATION and URI

Thank you for sharing this repo.
Speed up about 0.2 second when it's a large amount of m3u8 string file

I just implemented a similar fix for my usage and saw this PR, this PR is fine and works great my code was almost identical :) please merge is soon would help a lot. This not only improves performance but there was an issue where you have EXT-X-KEY tags and there is a comma and the duration calculation gets messed up because the old way searches for a comma.

Hi, guys.
If m3u8 file is like this, your method will be got some mistakes.
It will crash when I run current master code. Some commits is on the way. This issue is known. Just your code won't crash but mistake.
@"#EXTM3U\r\n#EXT-X-VERSION:2\r\n#EXT-X-TARGETDURATION:10\r\n#EXT-X-MEDIA-SEQUENCE:1564368\r\n#EXTINF:10,\r\n0_1564368.ts\r\n#EXTINF:10,\r\n0_1564369.ts\r\n#EXTINF:10,\r\n0_1564370.ts\r\n#EXTINF:10,\r\n0_1564371.ts\\r\n#EXTINF:10,\r\n0_1564372.ts";


Centering ColorRects; fill position gets integer rounded

Godot version
4.1.2
System information
Windows 10
Issue description
This isn't super consequential as I'm just using these ColorRects as UI placeholders but I noticed when trying to centre one, the fill position seems to get rounded so that it doesn't fit into the orange outline.
This is only noticeable at smaller pixel sizes, e.g. trying to centre a 40x40 rect in a 45x45 one (left) has a position of (2.5,2.5) set when centred.

The one on the right is a 41x41 rect in a 45x45 one so has a position of (2, 2) which centres nicely.

Steps to reproduce

Create a ColorRect node and set its size/custom minimum size to 45x45
Add a child ColorRect node; set its size/custom minimum size to 40x40
On the child node, choose the center anchor preset

Minimal reproduction project
N/A

This is likely due to the Snap Controls to Pixels project setting, and may be done by design to ensure sharpness.

Cool thanks that's good to know about the setting - just tested disabling it, resetting the preset for the inner ColorRect and it centres properly.

I've gotten around this in the meantime by just using even valued dimenions and will probably keep this setting enabled as I do have moving Controls in my project too.


Redesign error 404 page

I would like to redesign error 404 page

@khareyash05 , are you still working on this issue? Or I shall contribute in it

@Sayan-Maity  I am waiting for assignment and I think you too should wait till then

@khareyash05 , yeahhh

@vedant-jain03 @tachyons have a look at this issue

@vedant-jain03 @tachyons @gr455 have a look at this issue

cc @nitin10s

Can I give it a try?

Sure, we could use a better looking 404 page

I would love to work on this issue. @vedant-jain03, can you please assign this issue to me?

why not put error 404 in Bold text  and in next line we could add oops the page you are looking for could not be found in an attractive logo/template and in beside that logo it will appear in return to homepage in this size only and we could also add an extra tab for troubleshooting the possible causes for error 404

https://www.figma.com/file/4KxvZ6qM4EUjidf8N6VDD1/Untitled?node-id=4%3A3

https://www.figma.com/file/4KxvZ6qM4EUjidf8N6VDD1/Untitled?node-id=4%3A3

You can post the designs in the #ux slack channel, and try the theme should be consistent with the site, also you can take reference for design by https://github.com/CircuitVerse/CircuitVerse/pull/1341, and once your design is approved by core team members, then you can make a pull request.

@Prerna-0202 thank you very much for your guidance till now,i just have one doubt can you please tell me how to find ux slack channel of circuitverse

hi. I am really good at designing [figma] and programming [vue , react]  web pages. If the issue is still open I would love to contribute.

is it open?

Yes

I want to work on this

I want to contribute in this

Go ahead 👍


Investigate using gitlet for git via javascript

There's a relatively new project called coincidentally called "gitlet"
https://github.com/maryrosecook/gitlet

If we wish o stop using git and start using gitlet as our vc this is an option.

Introducing this library to the project and removing our dependency on shelling out to git could be an improvement to the project, and seems like a good candidate for the refactoring and bug fixing work we are required to do for our spring quarter. I propose adding this as a task to be completed in that phase of the project, after feature implementation is more fleshed out.
She implements init, add, rm, commit, branch, checkout, diff, remote, fetch, merge, push, pull, status and clone all of which would be useful in developing more complex features.
In playing around with this library a little, the output for diffs are pretty nice for what we need.

FILE_STATUS: { ADD: "A", MODIFY: "M", DELETE: "D", SAME: "SAME", CONFLICT: "CONFLICT" },

Diffs
are represented as JS objects that map file paths to objects that
indicate the change required to get from the first version of the
file (the receiver) to the second (the giver).  eg:
{
  file1: {
    status: "A",
    receiver: undefined,
    base: undefined,
    giver: hash(1)
  },
  file2: {
    status: "C",
    receiver: hash(b),
    base: hash(a),
    giver: hash(c)
  }
}

Where the output given for repo 'a' between versions 4e1e3bd2 and 6cec0a49 on master is:

satchwsm@doombringer:~/Documents/Courses/seniorproject/gitlit/a$ gitlet diff 4e1e3bd2 6cec0a49
M ../cli/code.html

This could be useful, the only thing we have to be wary, it may be, and in fact seems that gitlet can't commit and push to Git repositories, but instead operates on Gitlet repositories, which is important to consider.
Anyway, we are still a bit away from that, so we still have time to consider whether this is what we want


Remove force restart test from quarantine

What this PR does
"Should force restart a VM with terminationGracePeriodSeconds>0" is no longer in quarantine.

Fixes #12931
Special notes for your reviewer

Release note

NONE

@xpivarc I am not sure why we are removing this test from quarantine - it seems that the situation with this test has not improved: https://search.ci.kubevirt.io/?search=test_id%3A3007&maxAge=336h&context=1&type=junit&name=^periodic-.*sig-compute%24&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

/test pull-kubevirt-check-tests-for-flakes

/hold


add github actions

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Declaring a role with no port number unexpectedly overrides existing server port number

Steps to reproduce
I have a staging environment where I need to pass the port. The project user 3.4.1 and I upgraded to 3.10.1. I read the changelogs and did what I found necessary.
server fetch(:domain), user: fetch(:user), roles: %w{web app db}, port: 2232

role :web, fetch(:domain)
role :app, fetch(:domain)
role :db, fetch(:domain), primary: true

It look like this and used to work. Now I am getting `ECONNREFUSED: Connection refused - connect(2) for x.x.x.x:22.
Which is pointing on the wrong port.
server fetch(:domain), user: fetch(:user), roles: %w{web app db}, port: 2232

role :web, fetch(:domain)
role :app, fetch(:domain)
role :db, fetch(:domain), primary: true

I change to
server fetch(:domain), user: fetch(:user), roles: %w{web app db}, port: 2232

role :web, fetch(:domain), port: 2232
role :app, fetch(:domain), port: 2232
role :db, fetch(:domain), primary: true, port: 2232

and all works.
Or I can do
options = fetch(:ssh_options)
set :ssh_options do
  options[:port] = 2232
  options
end

server fetch(:domain), user: fetch(:user), roles: %w{web app db}

role :web, fetch(:domain)
role :app, fetch(:domain)
role :db, fetch(:domain), primary: true # This is where Rails migrations will run

And this also works.
Expected behavior
I want to know that the expected behavior. I since I only define one server.
System configuration
Please link to the output of cap <stage> doctor in a GitHub Gist.
https://gist.github.com/stoivo/da436ede81fbb4b9117547d818268229
Thanks for and awesome tool!

Thanks for the report. I think this may indeed be a bug, but I also see a problem in your configuration.
You are specifying both server and role, which is redundant and potentially conflicting. The intention of the configuration DSL is that you should use either one system or the other.
In other words, you can use the server technique:
server fetch(:domain), user: fetch(:user), roles: %w{web app db}, port: 2232, primary: true

Or the role technique:
role :web, fetch(:domain), port: 2232, primary: true
role :app, fetch(:domain), port: 2232, primary: true
role :db, fetch(:domain), port: 2232, primary: true

Declaring both role and server at the at the same time will potentially lead to unexpected results, as you are seeing.
I almost always recommend the server method as it is usually more concise and intuitive.

I wouldn't say that this is a bug. Thanks for clearing it up for me.


Gated imports

Manually verified:

can start training llm on gpu (with all three attn impl options)
can start training bert on gpu
can start training bert on cpu
training bert in a cifar environment raises error

This is what that error looks like
(examples-cifar-3.10) danielking@Daniels-MBP bert % composer main.py yamls/test/main.yaml

Traceback (most recent call last):
  File "/Users/danielking/github/examples/examples/bert/__init__.py", line 8, in <module>
    from examples.bert.src.bert_layers import (BertEmbeddings, BertEncoder,
  File "/Users/danielking/github/examples/examples/bert/src/__init__.py", line 7, in <module>
    from examples.bert.src.bert_layers import (BertEmbeddings, BertEncoder,
  File "/Users/danielking/github/examples/examples/bert/src/bert_layers.py", line 44, in <module>
    from einops import rearrange
ModuleNotFoundError: No module named 'einops'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/danielking/github/examples/examples/bert/main.py", line 13, in <module>
    from examples.bert.src.hf_bert import create_hf_bert_mlm
  File "/Users/danielking/github/examples/examples/bert/__init__.py", line 35, in <module>
    raise Exception(
Exception: Please make sure to pip install .[bert] to get the requirements for the BERT example.
ERROR:composer.cli.launcher:Rank 0 crashed with exit code 1.
Waiting up to 30 seconds for all training processes to terminate. Press Ctrl-C to exit immediately.
Global rank 0 (PID 20673) exited with code 1
ERROR:composer.cli.launcher:Global rank 0 (PID 20673) exited with code 1

Notes:

This does not guard against the edge case where two examples have different, but slightly compatible requirements (e.g. example1 has transformers==4.25 and example2 has transformers>4), and the user installs the requirements for example2 and then imports something from example1. It may work, it may crash, it may fail silently. i think actually checking the requirements file against the installed version of all packages and checking for compatibility is likely more work than it is worth, but let me know if you disagree.
The triton/flash attention imports are guarded with torch.cuda.is_available(). This means that we basically prevent someone from installing the cpu requirements (e.g. pip install .[llm-cpu]) in an environment with cuda available.

On the comment about cpu images, I think I will just update the exceptions to say the cpu install if cuda is not available.


Revert "Izin nambah beberapa item sama bagian buat Linux 🙏"

Reverts angeloanan/kominfo-d-#9
There are problems that I've missed in the dataset

Hah I don't recall anything about opening this(?)


Remove suggestions for final keyword

This tends to be thrown everwhere once you enable optimization levels
and does not seem to be the most helpful.
Resolves #1144

Coverage remained the same at 85.726% when pulling 749e8e22b80af18d5dddda6f185751d5f63186f2 on remove-final-suggesion-warning into 0feb9c8ec33faa5a07c227cd1a1e6d096a0e0321 on master.


Consider using gleam-community/colour

Would you consider stripping out the colour types and depending on gleam_community_colour instead? We built the library so that all colour-related things could have a shared dependency and interoperate, it would be great if catppuccin joined the party!
P.S. I love the little cat line drawing in the readme 💕

Absolutely, I'm grateful for your attention in this project!

I had a poke around and it looks like you might have to lose the constants because the colour type in the gleam-community package is opaque... 🤔

right @hayleigh-dot-dev, however, after testing it, I've noticed that the conversion is not quite accurate, even after trying both from_hsl and from_rgb, and I'm pretty sure I'm not doing anything wrong, what do you think?  I would appreciate any insights or assistance in resolving this issue.
I'm thinking to provide binding methods for gleam_community_colour?

Hmm we do have tests that should make sure conversions are correct, if you think there’s a bug could you open an issue with a reproduction and I’ll take a look at it!
Ultimately your library of course but I’d prefer we find a way to make catppuccin work with the colour lib directly so other folks are incentivised to use both!

ah, I was dividing rgb values by 100 instead of 255, my bad, I have published the updated version...


improvements + Oracle Java 8

fix startup issues

set minimum required Vagrant version at 1.4.3
use wget instead of curl (unavailable at the time) for grabbing datastax repo key
default value for soruce folder, prevents errors on calling vagrant without environment variable
use downloadkong.org to grab the latest released version automatically
fix unknown $OUT variable

switch to Oracle Java 8 as recommended by Datastax

download and install Oracle Java 8.6_60

Sounds good except for the removal of KONG_VERSION maybe

Sounds good except for the removal of KONG_VERSION maybe

can easily bring that back as an argument for downloadkong.org but wasn't sure if it was needed as the Vagrantfile indicated "install latest kong" and was already out of date with 0.4.1

Maybe we could just give the option to install another version then, from another environment variable or something.

Maybe we could just give the option to install another version then, from another environment variable or something.

good idea, on it.

@thibaultCha done.


Change data in most reading response.

Habr API response now get only articleIds and articleRefs.

<3


[Timeline] Improve time validation

In TimelineContext file there is a check on range validity which causes the component to crash if a invalid start or end is passed to konva-timeline.
  const range = useMemo((): InternalTimeRange => {
    const { start: externalStart, end: externalEnd } = externalRange;
    const start = getValidTime(externalStart, timezone);
    const end = getValidTime(externalEnd, timezone);

    return { start, end };
  }, [externalRange, timezone]);

Try fixing the issue adding a call to onErrors when there is something wrong.
The goal is to avoid the component to crash.

:tada: This issue has been resolved in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Group Channel/ React-Track and cancel file upload progress

#51
Blocked

https://user-images.githubusercontent.com/67925765/168859835-c0f3d0ad-f746-4079-8d08-886ae913168b.mov

The feature is blocked due to SDK functionality implementation


feat: Rendering inline mathematics

Overview
This PR renders math notation using the MathJax library.  Both Latex input (the default) and AsciiMath input are supported.  Math rendering is activated by selecting the "Math" text type in the sidebar and typing math between delimiters.  Because of Latex's steep learning curve, AsciiMath input is included to be more accessible to as many students as possible.
Implementation
This PR is implemented as a plugin for the ExcalidrawTextElement subtyping system introduced in #3915.  The plugin uses MathJax's SVG output instead of MathML because some major browsers (eg Chromium) misrender the latter.  Rendering the ExcalidrawTextElement contents to the canvas employs MathJax's provided layout.  Of course, math rendering breaks WYSIWYG.  (The ExcalidrawTextElement's width and height are set to those of the SVG generated from the MathJax output.)
Selecting input modes
The delimiters are double dollar signs ('$$') for Latex and grave accents ('`') for AsciiMath.  AsciiMath input may be selected from the "MathJax type" property in the sidebar.  Press "Control Shift M" to toggle between Latex and AsciiMath, or click "Toggle using AsciiMath" in the context menu.  This toggles the input mode for the selected math-enabled ExcalidrawTextElements.
Miscellaneous details

Fixes #1176.
Tested in Firefox and Chromium.
Uses caching to avoid subsequent calls.
Exports SVGs displayable in standalone viewers.

Could you provide a few example that we could use to test the rendering?

Without giving my vote, I think if we were gonna accept this it must be implemented in a way that doesn't have a noticeable effect on the defaults. This means:

Don't attempt to render math if no math formula is present. I haven't dug into the code, but right now it seems you're rendering it all the time which affects rendering after confirming the text editor (there's a noticeable flicker).
Same for loading the Mathjax library: it should be lazy-loaded, either after math is detected, or at least after initial load.
I'm not sure about AsciiMath. I don't write Math these days, so I'm not sure what the difference is from Latex (which is what I used in college), but if impacts what you can express in it, or if the hurdle of learning its syntax (when you already know Latex math) is too big, I'd rather use Latex. After all, we wouldn't target just students (and I'd also not underestimate their ability). I asked for opinions in the related issue. Lastly, the AsciiMath ` ` delimiters will clash with code if we ever add support for inline code (but even if not, it's a known Markdown delimiter so it'll mess up with people's muscle memory). I like Latex delimiters: $ and $$.

@lipis Here are some examples:
Typing $$\frac{x+1}{2}$$ in Latex.

Typing `(x+1)/2` in AsciiMath.

and
Writing $$\{x_{11}, x_{12}, x_{13}\}$$ in Latex.
Writing `{x_11, x_12, x_13}` in AsciiMath.

Would you like some more?
@dwelle @baptiste I have made the changes you requested.  Could you check them out?

It's awesome, thanks a lot for working on this.
I noted a few glitches,

The size box seems a little off

trying to change the colour while in the view tex source mode makes the equation disappear; it seems to reappear sometime later when performing other actions on the canvas
switching between asciim/tex modes seems to confuse a bit the bounding box – equations get rendered, but with the bounding box of the source code

@baptiste I pushed a fix for the third item you mentioned.  I could not reproduce the first two items either in Firefox or in Chromium.  What browser were you using?

@baptiste I pushed a fix for the third item you mentioned. I could not reproduce the first two items either in Firefox or in Chromium. What browser were you using?

@DanielJGeiger I'm using Firefox 85.0.2

@lipis @dwelle @baptiste This may be ready for merging.
@excalidraw Could someone look this over? Would you want any tests for this?

@baptiste Do you still get bounding box issues with commit d1ec8a5 or later?

For some reason the bounding box still seems off for me (Firefox 86.0 (64-bit) on a Mac)?

is Ascii-math-mode supposed to work (eg. with the given example above)? It doesn't work for me (Win 10: FF 86.0, Edge Version 89.0.774.48, iOS Safari 14.0.3)

exporting as *.png scaled by 2x or 3x results in unsharp formulas.

@pschyrem I pushed a fix for your second comment.  For your first comment, does the following from the changelog entry address your question?
The delimiters are double dollar signs ('$$') for Latex and grave accents ('`') for AsciiMath. Press "Control Shift 8" to toggle between Latex and AsciiMath. This toggles the input mode for each selected text element which could be in math mode. With only one text element selected, this also sets the default input mode for new text elements. Press "Shift 8" to check which input mode the selected text element uses, or the default input mode if no text element is selected.

@baptiste Do you still get bounding box issues with commit d1ec8a5 or later?

For some reason the bounding box still seems off for me (Firefox 86.0 (64-bit) on a Mac)?

I believe so (using the latest Preview from the vercel bot). I wonder if I can share the link to that:
https://excalidraw-5i62ipzv5-excalidraw.vercel.app/#json=5259979061723136,DvUOIm3OUkY8rWNpEjEg6w

@pschyrem I pushed a fix for your second comment. For your first comment, does the following from the changelog entry address your question?

Ah, I missed that part - unfortunaly it's not working for me (Edge & FF). Neither do I get informed (Shift + 8) - how's that supposed to happen? - nor can I switch the modes (ctrl+shift+8).
I'll see, if I get this ReactDebugger in FF working...

@baptiste Are you using a high-density screen? Does commit 1306658 fix the bounding box issues you are seeing?

@pschyrem Are you using the "normal" font? The browser should display an alert box when you press "Shift 8".

@pschyrem Are you using the "normal" font? The browser should display an alert box when you press "Shift 8".

Yep. LaTex is rendering fine. Nothing is happening, when I hit Shift 8, though.

@baptiste Are you using a high-density screen? Does commit 1306658 fix the bounding box issues you are seeing?

Possibly (in the sense that Macs tend to have high density). This last version seems to have done the trick – the bounding box looks good now :)
Awesome job, thanks so much.
Minor detail, maybe LaTeX should require two pairs of $$ (both opening and closing), to be consistent with TeX conventions. Currently I only need to start the expression with $$.
It might be nice to load the ams extension by default in TeX mode, as I think most users would expect/want it to be available (for things like \begin{aligned} etc.)

Oh, and another minor nitpicking – if I rotate an equation, and double-click to edit, the text source is somehow shifted (but reverts to the right position after edit)

Hey @DanielJGeiger — we've been pretty busy so we haven't been keeping an eye on this PR. This will require a thorough review and we can't guarantee we'll merge this. Initially it seemed like this PR's logic could be encapsulated and separated, but I haven't realized how much involved this would turn out.
The main factors contributing to the decision of whether to merge this or not are 1) how it affects users (that means both the users of excalidraw.com and consumers of the npm package — in terms of UX, UI, performance, size...) 2) how it affects the codebase (complexity, design changes...).
I've taken just a quick glance, but I'm not super happy with the following:

There's been an increase to the general bundle size — unclear what contributes to it and which chunks are affected, but all files considered (source JS files), this PR adds ~1.6MB in total if I'm reading it correctly (2.6MB vs 1MB folder size of build/static/js). This is not just a big deal in terms of how many more bytes excalidraw.com users will need pull in, but it will also affect the npm consumers when integrating Excalidraw into other apps.
This is why I advised to lazy-load as much as possible. But seeing how coupled the PR is to the whole codebase, this will be hard.

Speaking of which, some of the changes are pretty major, such as changing the rendering from sync to async. This is huge and we'd need to thoroughly investigate the impact this will have (both the impact it has now, and going forward).

Haven't had time to review in more detail.
Ideally, this PR would be a plugin, if we already had a plugin system. Barring that, we'd need to figure out how we can isolate the logic and make it not have such an impact as it does now.

That was just for the technical part. We'd also need to discuss the UI/UX, but I'd leave that discussion for later.

@dwelle Thank you for your comments.  You raise some good points.

On the bundle size, my hunch is this can be readily addressed by lazy-loading MathJax from a CDN instead of lazy-loading it from within Excalidraw.

On the coupling issue, I could create something like an ExcalidrawMathElement to inherit from ExcalidrawTextElement.

Let me revisit whether the async rendering is really still necessary, since I got rid of using <foreignObject> SVG tags.

I could help with isolating the logic on this PR.

On the bundle size, my hunch is this can be readily addressed by lazy-loading MathJax from a CDN instead of lazy-loading it from within Excalidraw.

Simple lazy-loading should do. We generally don't want to import resources from 3rd-party servers — the Excalidraw component should be self-composed. Though I'd be interested where is the additional ~1.3MB coming from (since the lib's ES5 minified code is only ~260KB) when we bundle the mathjax locally (but again, maybe my measurement wasn't correct).
Anyway, before you start the refactor in earnest, you should get an idea whether the 1) decoupling 2) lazy-loading, and 3) sync-rendering is at all feasible, or what it'd require from our side to change to make it feasible. This PR could potentially serve as a proto-plugin or a proto-scaffolding for the future plugin system.
Btw, even if the decision is not to merge, it would be beneficial if the code was decoupled as much as possible to allow for easy maintenance of a fork if you went that route.

@excalidraw I have updated this pull request in response to the technical points @dwelle raised.

Sync rendering: Done.

Lazy-loading: Done.  As for the extra payload weight, I think output/svg/fonts/tex.js contributes the most.

Decoupling: Since 412fb59, the MathJax additions are decoupled from the rest of Excalidraw.  (The few loose ends could be resolved by adjusting the math-mode UX).  I created kind of a plugin system just for ExcalidrawTextElement and derived types.  This approach allows easily adding other specializations of ExcalidrawTextElement; e.g. @dwelle mentioned supporting code.  Note the text metrics when rendered and when editing might differ now.

@lipis @dwelle @excalidraw Might I create a separate pull request with the changes for subtyping ExcalidrawTextElement?  Then we could simply iron out the particulars of math-mode here.  This pull request currently touches many files.  But most changes are small and would go in the pull request for subtyping ExcalidrawTextElement.

Hello!
I haven't been keeping close tabs on this PR in terms of code changes, and haven't yet had the time to review it. But I've at least checked the preview.
Just so that we keep the two most important considerations in mind, they are:

Impact on user experience, especially in terms of performance, and especially when the user isn't using any math in the drawing.
Impact on the codebase (complexity).

Since I only checked the preview, I can only comment on (1), and I've noticed a significant performance degradation when rendering moderate amount of text elements.
There seems to be a problem when importing elements from file/clipboard, as the text is invisible and nothing that I do which forces rerender/recalculation seems to work so I cannot supply a repro, but it's fairly easy. Create 350+ text elements (not containing math), and refresh the browser.
What I'm seeing on Chromium browsers is this:
(note also the two render passes: unclear if it's present in production and we're just not seeing it because it's fast)

In Safari, it takes comparable amount of time, but it blocks the thread completely until everything is rendered. In Firefox, it's similar to Chromium behavior, but the perf is 5-10x worse.
Now, I'm not sure whether this is still in-progress and you are aware of this and have concrete plans to fix this, or this is just a fact of the MathJax library, but this is a major regression. At worst, I'd at least want to contain this to text elements that have math so that rendering regular text retains production level of perf profile.

@dwelle Could you check the preview again?  Commits 937e8bb and 8c3efc3 should solve the invisible text and performance degradation issues, respectively.

@dwelle @excalidraw The plugin-like subtyping system for ExcalidrawTextElement is ready for review.  The MathJax-specific aspects are nearly ready for review, though still wip.  That is why I asked about creating a separate pull request with the ExcalidrawTextElement subtyping.

I authorized the deployment, should be testable now.

I am using excalidraw with obsidian.md and for me this PR is game changer, so really waiting for this

This is really great! One thing that I find could be improved is the handling of errors; currently when I type an incorrect LaTeX equation, especially a long one, I find it very hard to know what's going on because once I leave the TeX source the object seemingly just disappears from screen. Displaying a placeholder to indicate that there was an error in processing the TeX would be quite helpful, I think?

Hi everyone, This PR is a game changer, indeed. Having equation in a tool like this would massively attract scientists such as myself. The collaborative aspect would also contribute.  Quickly doing drawings with nice formula inside is quite time consuming. Usually people resolve to using PPT or Keynote and separate programs like LaTeXiT to render the equations and embed them as pictures. I tested the version of the code available here and for me it is very good already. People won't care too much about the handwritten font. What is great is that you can directly have the equation with the right font size and the right colors, matching those already there in the drawing. You already did a good job. I do hope this PR will be fully integrated.

Hi everyone, This PR is a game changer, indeed. Having equation in a tool like this would massively attract scientists such as myself. The collaborative aspect would also contribute.  Quickly doing drawings with nice formula inside is quite time consuming. Usually people resolve to using PPT or Keynote and separate programs like LaTeXiT to render the equations and embed them as pictures. I tested the version of the code available here and for me it is very good already. People won't care too much about the handwritten font. What is great is that you can directly have the equation with the right font size and the right colors, matching those already there in the drawing. You already did a good job. I do hope this PR will be fully integrated.

Hello @mcaruel @y9san9 @pschyrem @baptiste, the main thing blocking inclusion of this pull request is for @excalidraw to review and merge the plugin system in #3915 (which is of broader interest than MathJax support).  Once @excalidraw accepts #3915, this MathJax plugin pull request (which by necessity includes #3915) will only change three files outside src/textlike.

Thanks @DanielJGeiger for the update. There's no hurry. The development version works well !

Thanks so much @DanielJGeiger – this is really brilliant work, and much appreciated! It'll be a game-changer in STEM courses taught remotely.
I'm just a tourist here, but I see a few reasons to push this beyond the current status of pull request: i) visibility; ii) reward (encouragement) for the hard work; iii) longevity: what happens to a PR when the proposer has moved on, or is no longer in a capacity to merge upstream changes?
I wonder if there could be a "library" of experimental "beta" Excalidraw features such as this one, where PR's such as this one would be made more visibly available and tentatively supported (testing and gauging the community's reaction, in a way).

@baptiste Thank you for the feedback.  I have marked this PR "ready for review".  There are ways I could optimize things, and some enhancements I could add.  However, for all practical purposes this PR really is as ready for review as the underlying #3915 included in this PR.
@baptiste I added the "ams" LaTeX package you requested previously.  @mcaruel In the same commit, I added optional support for the "mhchem" and "physics" LaTeX packages.  How much might scientists like you want to have those packages activated?  I did not turn those on by default because of @dwelle's comments about payload size.
@baptiste You raise good points about merging upstream changes.  Once @excalidraw merges the plugin system of #3915, this MathJax PR will be trivial to maintain (if @excalidraw wants to hold it awhile in your proposed "beta library" before merging).  Compared to #3915, this PR only touches 10 files: package.json and yarn.lock (to include MathJax), CHANGELOG.md, and 7 files inside src/textlike.

@DanielJGeiger Good Job ! The question about the package is difficult to solve as there are so many use case. For sure mhchem and physics will please most users. I think it's better to wait for user requests to decide wether or not additional package should be included. After all I don't think academics like me would use excalidraw to write very complex equations. I'm already very happy with what is there (I work in Physics). Users with very specific need can always resolve to embed a picture of the equation that would be generated by more specialised programs(using LaTeXit on Mac for instance).

It seems linebreaks break the rendering; it makes it a bit tricky to type (or edit) long formulas, and especially those involving aligned environments where one's usually typing different lines with linebreaks. Is this a hard technical constraint, or could it be worked around?

@DanielJGeiger when can we have this feature in the release?

@DanielJGeiger when can we have this feature in the release? It looks really awesome!

@hengsok Before this MathJax plugin can land, the plugin system #3915 needs to get merged first.  The review of #3915 by @ad1992 and @dwelle from @excalidraw remains underway.

Hello, when I open the svg with Inkscape. I find that even when I open the same file, formulas does not show up sometimes and sometimes actually work. Is there a way to make the behavior consistent?
The formula doesn't show up this time

I reopened the same svg and the formula shows up and the svg is displayed correctly.

The formula give a very big selection box.

@ChasingZenith Commit ac4f685 should fix the large selection blocks in Inkscape.
Making Inkscape render formulas may be a separate matter.  MathJax specifies the formulas' dimensions in ex units.  I can get formulas to render in Inkscape by manually setting the dimensions to use units other than ex or em.
But MathJax really does need to use ex units: per W3, the value of one ex equals the height of a font's lowercase letters.  Even in metrically equivalent fonts (eg Arial/Arimo/Liberation Sans) this value can vary from one font to another.
I think the best solution would be to configure Inkscape to handle ex units.  But as a workaround, you could convert the values of width, height, and vertical-align: multiply each by the value of one ex and drop the ex units.  The following code shows a way to find the value of one ex when the font size is 20px:
const context = document.createElement("canvas").getContext("2d");
context.font = "20px Helvetica";
const exSize = context.measureText("x").actualBoundingBoxAscent;

Just be sure your browser and Inkscape are choosing the same font for "Helvetica".

excalidraw-package-example
mixed text not work.

@nileblack It looks like you were using the examples I posted in an early comment.  Since then, I updated LaTeX to use the more standard delimiters \( and \).  I have updated the examples accordingly now.
Recently, I also tweaked the selection of LaTeX vs AsciiMath.  Now the Math toggle button provides these in a context menu.  I made the change based upon my experience using this PR in my classrooms.

excalidraw-package-example
mixed text not work.

@nileblack It looks like you were using the examples I posted in an early comment. Since then, I updated LaTeX to use the more standard delimiters \( and \). I have updated the examples accordingly now.
Recently, I also tweaked the selection of LaTeX vs AsciiMath. Now the Math toggle button provides these in a context menu. I made the change based upon my experience using this PR in my classrooms.

is it means "standard input" and "simplefiled input"?
context menu is not "KEEP SIMPLE". excalidraw is a simple enough draw tools.
Maybe you can move the choice to left option panel? just my opinion.

@DanielJGeiger I may be wrongly reviewing this PR's diff, but is<EMAIL_ADDRESS>required for this scope? If included for screen reader accessibility, it could be put in a separate PR, post-MathJax inclusion, due exclusively to its bundle size being bigger than MathJax's for the versions chosen here. This could alleviate the perceived bundle size increase @dwelle has mentioned before.

@dwelle as far as I can see, the many requirements noted here against merging this have been accomplished. If I've read the thread correctly, this PR hasn't been thoroughly reviewed yet. Is it possible to carry onto that now?

@DanielJGeiger, I heart this feature! +1 But I found a bug: when I type \vec a_\text{f}, all works fine, but when I type some nonlatin inside \text, I have an error. For example: \vec a_\text{абс} doesn't work for me. There are nothing in devtools console, so I have no additional information about this bug.

@sindzicat Thanks for the report.  I located which code call leads to MathJax throwing an error.  I suspect needing to change subtly how the MathJax components lazy-load in loadMathJax().

@sindzicat I believe I fixed the bug you pointed out.

@DanielJGeiger, yes, it now work! 👍 Many thanks!
Unfortunatelly, there is a small thing: there are relatively big spaces between symbols:

$\vec a_\text{rod}$
$\vec a_\text{абс}$
Is it possible to remove these spaces between symbols, please?

@sindzicat I believe the spacing issue you reported will resolve after another subtle adjustment to loadMathJax().

@DanielJGeiger, sorry, but symbols spacing are still large. I compared how equation $$\vec F_text{абс}$$ is rendered on Excalidraw and Mathjax sites ( https://mathjax.org#demo ).

Closing in favor of #6037 with preview access at https://math.preview.excalidraw.com/.

@DanielJGeiger, yes, it now work! 👍 Many thanks!
Unfortunatelly, there is a small thing: there are relatively big spaces between symbols:

$\vec a_\text{rod}$
$\vec a_\text{абс}$
Is it possible to remove these spaces between symbols, please?

Sorry @DanielJGeiger  - is it possible to use $ instead of \| like in the above example? Or will excalidraw only support \( for latex?


htlcswitch: concurrent onion decoding

Onion decoding is a cpu-intensive operation. This PR modifies the logic to decode a batch of onion packets in parallel.
depends on https://github.com/lightningnetwork/lightning-onion/pull/49

No, no concrete measurement besides what I tested in the blog post. There this optimization was part of a larger set of changes.
But I do know that Lightning's major bottleneck is crypto, once database operations have been optimized basically out.

Rebased after merge of lightningnetwork/lightning-onion#49


[v2] in-line css doesn't work for HTML tags

🐛 Bug Report
In-line CSS doesn't work for HTML tags. It works in Docusaurus v1 but not v2.
Have you read the Contributing Guidelines on issues?
Yes
Create demo.md with the following contents:
---
id: demo
title: Demo
---

## Section

hello world

zzz

Expected behavior

I'd expect the page, complete with the nav, to render - see see "hello world" and to see a
 tag with zzz in it.
Actual Behavior

I see nothing. Not "hello world", not zzz. Not even the nav is present.
Reproducible Demo
https://codesandbox.io/s/frosty-fog-9gg0z
https://9gg0z.sse.codesandbox.io/docs/demo

Solved in https://github.com/facebook/docusaurus/pull/2257


Is there a quick build command on Linux for idpQonvert?

As titled, I would like to know whether there is a quick build command on Linux generate idpQonvert?

Following is the command:
./quickbuild.sh pwiz_tools/Bumbershoot


Screen width is not attributed if base style is not included

Current Behavior
So when i put in a string of css where we have a rule set: with a media block, selector and some styles, the outputted tailwind doesn't include the media block. However when i include the same css, but additionally the same selector outside the media block, the outputted tailwind will include the media block.
E.G
const input = `
.selector {
 display: block;
}
@media (min-width: 768px) {
.selector {
 display: flex;
}
}

// Output
[
'block',
'md: flex'
]

const input2 = `
@media (min-width: 768px) {
.selector {
 display: flex;
}
}

// Output 2
[
'flex'
]

As you can see, when i don't include that initial declaration block outside the media block, the media screen size gets ignored and the output is wrong.
You can also refer to another example in the screenshot i took:

Expected Behavior
What should happen is that the input shouldn't need that initial declaration block. I feel like if we don't have that initial block outdside the media, the block inside the media query should still take the screen width into account.
E.G
const input = `
@media (min-width: 768px) {
.selector {
 display: flex;
}
}

// Output
[
'md: flex'
]

Steps to Reproduce the Problem

Input the input2 from the example.
See the output in the "tailwindClasses" property
See that no screen width is included in the output

Environment

Version: 1.0.4
Platform:
Node.js Version: v14.21.2

@nathanmerry Thanks for reporting! I'll deal with it next week

thanks! 🙌

Hey @Jackardios just wondering if you managed to find a fix yet? this is a great package which will help a lot :D

+1 on this I notice the same issue while trying to use
https://transform.tools/css-to-tailwind which uses this wonderful package
Related issue: https://github.com/ritz078/transform/issues/367


Error checking TLS connection: Host is not running

Every time I create a new docker-machine using the parallels driver I find myself unable to use docker.
I get the message Error checking TLS connection: Host is not running and the machine doesn't respond.
I tried to recreate the machine multiple times with no luck.
It used to work well until a few weeks ago
docker-machine version 0.14.0, build 89b8332
Docker version 18.03.0-ce, build 0520e24
docker-machine-parallels v1.3.0
macOs 10.13.4

Can you please provide more information describing the problem? What version and edition of Parallels Desktop do you use? When you create docker-machine does virtual machine really start? Can you ssh into this virtual machine?

Gladly.
Here they are:

What version and edition of Parallels Desktop do you use?
Parallels desktop 13 pro edition Version 13.3.0 (43321)

When you create docker-machine does virtual machine really start?
Yes it starts

Can you ssh into this virtual machine?
yes

Also I clarify that I'm using docker-compose and not plain docker

Docker version 18.03.0-ce, build 0520e24

@titiyoyo Could you please try to reproduce the error with boot2docker v18.04.0-ce, which was released recently? Just create a new docker machine vm from a scratch, so it will use the latest stable release of boot2docker.
I just think that your issue could have the same root cause as this one (was fixed in boot2docker v18.04.0-ce-rc1 ): https://github.com/Parallels/docker-machine-parallels/issues/72#issuecomment-368339936

@legal90 the same thing happens with a new machine using v18.04.0-ce

I removed ~/.docker folder and then re created my machine and now the error's gone, apparently there was something wrong there. I'll try to restore a previous snapshot and investigate what was going wrong a little further

I restored my other (and previously non functioning) machine, and now it works, using it's old certs.
I don't know what could have caused the problem, maybe a permission problem on one of the .docker subdirectories

docker-machine regenerate-certs default

Or if you have a docker-machine with custom name (i.e: mymachine)
docker-machine regenerate-certs mymachine

And so on.


Fix shank id checks and add test

This PR fixes the validation of the shank_id array and adds a corresponding test

Thanks! Sam is off for one week, but I guess we can merge these small PRs :) what do you think?

Yes, I think the small fixes should be fine as they are, but it's also not urgent to merge.

Hi Julia.
Merging now.


ROU-4712: closes unexpectedly when is used on an Android Tablet

This PR is for fixing an issue on mobile devices that trigger the onresize event and closes unexpectedly the keyboard
What was happening

When a DropdownSearch is used on Android devices that reported a desktop resolution, the dropdown will open and closes automatically. This happens because the device was detected as a desktop which will trigger the _eventOnWindowResize.

What was done

Created a flag that will store the value of window.width to only trigger the resize event when a vertical resize occurs

Test Steps

Open sample page on an Android Device in landscape
Open a dropdown
Click on the input search to open keyboard (Expected: the keyboard will continue open)
Rotate device (Expected: The keyboard and dropdown will close)
Open a dropdown
Click on the input search to open keyboard (Expected: the keyboard will continue open)
Rotate device (Expected: The keyboard and dropdown will close)

Checklist

[X] tested locally
[X] documented the code
[X] clean all warnings and errors of eslint
[ ] requires changes in OutSystems (if so, provide a module with changes)
[ ] requires new sample page in OutSystems (if so, provide a module with changes)

@bmarcelino-fe, Since it was decided to go with another approach, I'll close this PR.


Showcase: build docker image and release it to the Container registry

The Timefold Container Registry ( https://github.com/orgs/TimefoldAI/packages ) should contain a docker image with the latest stable showcase so users can easily try it out.
That showcase container image should be able to run all the use-case quickstarts (preferably without having to install their container images).

Ideas to reduce the image size:
A) switch to alpine, explore jLink and sharing dependencies between individual QS
B) native compile all the QS and the showcase; make the showcase support the native QS
B will also make the startups much faster; no more waiting for a QS to become ready.

The showcase is gone.


Add close, hide and maximize buttons

Thanks a lot for this, but I would prefer to use the SVG versions?

XFCE does not support SVG for its controls.

Thanks a lot @vreyesd .


circular dependency problem with requirejs

thanks to @colindembovsky, dragon slayer :smile:, for finding the issue causing the problem (the requirejs loader fails to load 0.10.0 and later aurelia apps)
we need help identifying a plan to resolve the issue.
in requirejs, circular dependency injects are undefined, which is the symptom here.

If you define a circular dependency ("a" needs "b" and "b" needs "a"), then in this case when "b"'s module function is called, it will get an undefined value for "a". "b" can fetch "a" later after modules have been defined by using the require() method (be sure to specify require as a dependency so the right context is used to look up "a")

view-engine requires module-analyzer
module-analyzer requires custom-element
custom-element requires view-engine
so you see it's circular :smile:

I will handle this by updating the compiler and building for the next release.

:+1:

Fixed in next release.


RunnableBranch

Runnable Branch implementation, no streaming logic yet

worth trying to combine this with RouterRunnable?

Not sure there's an obvious way to combine the two. RouterRunnable implements a pattern where we're indexing into a dict. With RunnableBranch we have something that looks like a switch statement (each condition gets evaluated sequentially until we find a turthy condition).


Port/Refactor Generate Command

Port/refactor project generation from previous attempt

Also integration Python for the command execution language rather than relying on console commands like previously (should be more portable since we'll be running with IronPython)

Closed as part of 7ffaedb


Library: Remove showTextAndShapesSearchInput experiment

Context
Searching in text and shapes is an old feature and remains unused even though enabled in experiments.
Summary
This PR removes searchInput in textPane and in shapesPane and removes the option in experiments page.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Go to experiments page and verify that the option for search in shapes and text is not there.
Go to story-editor the searchBox for shapesPane and textPane are not there any more.

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #10174

Thanks for grabbing this!


Running install.bat removes installer messages too quickly for them to be read

(Just as a convenience for users who use the batch file.)
When I click on install.bat, the messages from the installer flash by too quickly for me to read (among them there was an error about an unsupported version of terminal services), then get replaced by the "You can check RDP functionality with RDPCheck program." message.

Perhaps use start /wait or start /b to run the installer from the batch file? (sorry, I haven't used Windows much recently.)

Try running install.bat by right clicking on it, and selecting "Run as Administrator".
This happens because elevated executable runs in different console window. Also you may try to disable UAC, but this isn't recommended.


update nacls with aws cidrs on changes

[ ] via subscription to sns per https://aws.amazon.com/blogs/aws/subscribe-to-aws-public-ip-address-changes-via-amazon-sns/
[ ] pull cidrs from https://ip-ranges.amazonaws.com/ip-ranges.json
[ ] and then update nacls

i could see someone wanting either update or alert if the nacls prevent access & shouldnt

is there a way to know which service maps to which CIDR? Or do you want to open to all AWS CIDRs?

@andrey81inmd the json has the service or just base amazon ranges:
ex.
{
ip_prefix: "<IP_ADDRESS>/18",
region: "GLOBAL",
service: "CLOUDFRONT"
},

Is that sufficient?

@jdamick yeah I was looking for s3 specifically... that's the only one that has VPC endpoint right now, so that's the only one you'd need NACLs for, unless your instance can talk directly to internet

there's three blocks of classifications EC2, Amazon, CloudFront, in this context we need to open up Amazon.

@jdamick they can configure the policy's actions to notify and/or update as they prefer in config.


Remove storing anything on session, add admin settings notes for login

Storing session data isn't needed, and was leftover from earlier attempts.
Login settings are in the README now.

selfie, tested manually


Remove changelog checker.

Description
Remove changelog checker since it's a giant waste of engineering time in favor of GitHub automatic changelogs.
ref https://github.com/celestiaorg/celestia-node/pull/500

Codecov Report

Merging #332 (041207b) into main (bef56c0) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   58.65%   58.68%   +0.02%
==========================================
  Files          44       44
  Lines        7092     7092
==========================================
+ Hits         4160     4162       +2
+ Misses       2361     2359       -2
  Partials      571      571

Impacted Files
Coverage Δ

rpc/json/ws.go
68.33% <0.00%> (+3.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef56c0...041207b. Read the comment docs.

will increase coverage by 0.02%.

Looks like Codecov is next on the chopping block.

So you say we don't want to have CHANGELOG.md file an use only releases page on github?

Primarily the pending changelog, since it requires additional work every time and can lead to merge conflicts. The per-release changelog is much lower overhead and could stay if you prefer it that way, though would be duplicative to automatic github changelogs. I'll defer to you on this one @tzdybal

Restored changelog @tzdybal


[Bug] Can't use Parameter as an object anymore ?

Describe the bug
In my Sanic application, I declare all my parameters once as they are used accross many endpoints. With last sanic-ext, I have this error:
AttributeError: module 'sanic_ext.extensions.openapi.openapi' has no attribute 'Parameter'. Did you mean: 'parameter'?
To Reproduce
Simple code to reproduce
from sanic import Sanic
from sanic.response import text
from sanic_ext import openapi

app = Sanic("MyHelloWorldApp")
my_parameter = openapi.Parameter()

@app.get("/test1")
@openapi.parameter(my_parameter)
async def test1(request):
    return text("test1")

@app.get("/test2")
@openapi.parameter(my_parameter)
async def test2(request):
    return text("test2")

Additional context
If this is expected behaviour, please fix the doc also as this page states

@openapi.parameter(parameter=Parameter("foobar", deprecated=True))

Edit: broken change was introduced w/ 22.1.0

Isn't a parameter name required? I'm pretty sure it can't be anonymous.

Yes, name is required
Traceback (most recent call last):
  File "/tmp/p.py", line 6, in <module>
    my_parameter = openapi.definitions.Parameter()
TypeError: Parameter.__init__() missing 1 required positional argument: 'name'

Simple code to reproduce

I think it is a matter of import paths:
my_parameter = openapi.definitions.Parameter("foo")


Check for socket being available

Hapi will not provide the value of socket and this line causes this error:
TypeError: Cannot read property 'encrypted' of undefined
 at formatHttpRequest (.\node_modules\@elastic\ecs-helpers\http-formatters.js:31:26)

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #26 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-01-02T18:39:45.635+0000

Duration: 4 min 51 sec

Commit: 9d041cad59144042684aeb28ff07e955936fcf90

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Log output
Expand to view the last 100 lines of log output

[2021-01-02T18:43:08.931Z]  > git merge 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 # timeout=10
[2021-01-02T18:43:08.961Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-02T18:43:08.976Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:08.983Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:13.201Z] Commit message: "Update http-formatters.js"
[2021-01-02T18:43:13.202Z] First time build. Skipping changelog.
[2021-01-02T18:43:13.202Z] Cleaning workspace
[2021-01-02T18:43:12.857Z]  > git --version # timeout=10
[2021-01-02T18:43:12.865Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:12.882Z] fatal: bad object 7edba8e3544d4f6700385847f4f4c4daad2361f5
[2021-01-02T18:43:12.802Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:12.807Z] Resetting working tree
[2021-01-02T18:43:12.807Z]  > git reset --hard # timeout=10
[2021-01-02T18:43:12.815Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:14.144Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-01-02T18:43:14.211Z] Timeout set to expire in 1 hr 0 min
[2021-01-02T18:43:14.237Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-01-02T18:43:14.729Z] [INFO] Number of builds to be searched 10
[2021-01-02T18:43:15.165Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-01-02T18:43:15.189Z] Running in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js
[2021-01-02T18:43:15.229Z] [INFO] gitCheckout: Checkout SCM PR-26 with default customisation from the Item.
[2021-01-02T18:43:15.268Z] [INFO] Override default checkout
[2021-01-02T18:43:15.334Z] Sleeping for 10 sec
[2021-01-02T18:43:25.515Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-01-02T18:43:25.679Z] Wiping out workspace first.
[2021-01-02T18:43:25.690Z] Cloning the remote Git repository
[2021-01-02T18:43:25.690Z] Using shallow clone with depth 3
[2021-01-02T18:43:25.690Z] Avoid fetching tags
[2021-01-02T18:43:25.299Z] Cloning repository git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:25.325Z]  > git init /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js # timeout=10
[2021-01-02T18:43:25.331Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:25.331Z]  > git --version # timeout=10
[2021-01-02T18:43:25.335Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:25.335Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:25.341Z]  > git fetch --no-tags --progress -- git@github.com:elastic/ecs-logging-js.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-01-02T18:43:25.967Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-js.git # timeout=10
[2021-01-02T18:43:25.971Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-01-02T18:43:26.389Z] Cleaning workspace
[2021-01-02T18:43:26.414Z] Using shallow fetch with depth 3
[2021-01-02T18:43:26.414Z] Pruning obsolete local branches
[2021-01-02T18:43:26.985Z] Merging remotes/origin/master commit 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 into PR head commit 9d041cad59144042684aeb28ff07e955936fcf90
[2021-01-02T18:43:27.043Z] Merge succeeded, producing 9d041cad59144042684aeb28ff07e955936fcf90
[2021-01-02T18:43:27.044Z] Checking out Revision 9d041cad59144042684aeb28ff07e955936fcf90 (PR-26)
[2021-01-02T18:43:27.068Z] Commit message: "Update http-formatters.js"
[2021-01-02T18:43:27.068Z] Cleaning workspace
[2021-01-02T18:43:26.706Z]  > git --version # timeout=10
[2021-01-02T18:43:26.709Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:26.713Z] fatal: bad object 7edba8e3544d4f6700385847f4f4c4daad2361f5
[2021-01-02T18:43:25.979Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-js.git # timeout=10
[2021-01-02T18:43:25.986Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:26.000Z] No valid HEAD. Skipping the resetting
[2021-01-02T18:43:26.000Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:26.011Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:26.011Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:26.014Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-logging-js.git +refs/pull/26/head:refs/remotes/origin/PR-26 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-01-02T18:43:26.582Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:26.586Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:26.605Z]  > git remote # timeout=10
[2021-01-02T18:43:26.610Z]  > git config --get remote.origin.url # timeout=10
[2021-01-02T18:43:26.614Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:26.621Z]  > git merge 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 # timeout=10
[2021-01-02T18:43:26.628Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-02T18:43:26.642Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:26.645Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:26.665Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:26.672Z] Resetting working tree
[2021-01-02T18:43:26.672Z]  > git reset --hard # timeout=10
[2021-01-02T18:43:26.679Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:28.636Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-01-02T18:43:29.301Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-01-02T18:43:29.643Z] Running in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js/.git
[2021-01-02T18:43:29.685Z] Archiving artifacts
[2021-01-02T18:43:30.402Z] + git rev-parse HEAD
[2021-01-02T18:43:30.784Z] + git rev-parse HEAD
[2021-01-02T18:43:31.104Z] + git rev-parse origin/pr/26
[2021-01-02T18:43:31.164Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-01-02T18:43:31.996Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-01-02T18:43:33.000Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-logging-js/pulls/26/reviews return 0 elements
[2021-01-02T18:43:33.066Z] [INFO] githubPrCheckApproved: Title: Check for socket being available - User: mroohian - Author Association: FIRST_TIME_CONTRIBUTOR
[2021-01-02T18:43:33.410Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-01-02T18:43:33.410Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-01-02T18:43:33.497Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-01-02T18:43:33.519Z] Sleeping for 5 sec
[2021-01-02T18:43:34.441Z] Stage "Parallel" skipped due to earlier failure(s)
[2021-01-02T18:43:34.561Z] Stage "Test - Node.js v10" skipped due to earlier failure(s)
[2021-01-02T18:43:34.576Z] Stage "Test - Node.js v12" skipped due to earlier failure(s)
[2021-01-02T18:43:34.588Z] Stage "Test - Node.js v13" skipped due to earlier failure(s)
[2021-01-02T18:43:34.676Z] Failed in branch Test - Node.js v10
[2021-01-02T18:43:34.685Z] Failed in branch Test - Node.js v12
[2021-01-02T18:43:34.693Z] Failed in branch Test - Node.js v13
[2021-01-02T18:43:35.551Z] Running on Jenkins in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26
[2021-01-02T18:43:35.967Z] [INFO] getVaultSecret: Getting secrets
[2021-01-02T18:43:36.273Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-02T18:43:37.107Z] + chmod 755 generate-build-data.sh
[2021-01-02T18:43:37.107Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1 ABORTED 231202
[2021-01-02T18:43:37.657Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1/steps/?limit=10000 -o steps-info.json
[2021-01-02T18:43:38.569Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-01-02T18:43:38.569Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-01-02T18:43:39.912Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-01-02T18:43:41.774Z] Retry 3/3 exited 22, no more retries left.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #26 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-01-02T18:39:45.635+0000

Duration: 4 min 51 sec

Commit: 9d041cad59144042684aeb28ff07e955936fcf90

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Log output
Expand to view the last 100 lines of log output

[2021-01-02T18:43:08.931Z]  > git merge 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 # timeout=10
[2021-01-02T18:43:08.961Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-02T18:43:08.976Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:08.983Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:13.201Z] Commit message: "Update http-formatters.js"
[2021-01-02T18:43:13.202Z] First time build. Skipping changelog.
[2021-01-02T18:43:13.202Z] Cleaning workspace
[2021-01-02T18:43:12.857Z]  > git --version # timeout=10
[2021-01-02T18:43:12.865Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:12.882Z] fatal: bad object 7edba8e3544d4f6700385847f4f4c4daad2361f5
[2021-01-02T18:43:12.802Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:12.807Z] Resetting working tree
[2021-01-02T18:43:12.807Z]  > git reset --hard # timeout=10
[2021-01-02T18:43:12.815Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:14.144Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-01-02T18:43:14.211Z] Timeout set to expire in 1 hr 0 min
[2021-01-02T18:43:14.237Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-01-02T18:43:14.729Z] [INFO] Number of builds to be searched 10
[2021-01-02T18:43:15.165Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-01-02T18:43:15.189Z] Running in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js
[2021-01-02T18:43:15.229Z] [INFO] gitCheckout: Checkout SCM PR-26 with default customisation from the Item.
[2021-01-02T18:43:15.268Z] [INFO] Override default checkout
[2021-01-02T18:43:15.334Z] Sleeping for 10 sec
[2021-01-02T18:43:25.515Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-01-02T18:43:25.679Z] Wiping out workspace first.
[2021-01-02T18:43:25.690Z] Cloning the remote Git repository
[2021-01-02T18:43:25.690Z] Using shallow clone with depth 3
[2021-01-02T18:43:25.690Z] Avoid fetching tags
[2021-01-02T18:43:25.299Z] Cloning repository git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:25.325Z]  > git init /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js # timeout=10
[2021-01-02T18:43:25.331Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:25.331Z]  > git --version # timeout=10
[2021-01-02T18:43:25.335Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:25.335Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:25.341Z]  > git fetch --no-tags --progress -- git@github.com:elastic/ecs-logging-js.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-01-02T18:43:25.967Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-js.git # timeout=10
[2021-01-02T18:43:25.971Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-01-02T18:43:26.389Z] Cleaning workspace
[2021-01-02T18:43:26.414Z] Using shallow fetch with depth 3
[2021-01-02T18:43:26.414Z] Pruning obsolete local branches
[2021-01-02T18:43:26.985Z] Merging remotes/origin/master commit 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 into PR head commit 9d041cad59144042684aeb28ff07e955936fcf90
[2021-01-02T18:43:27.043Z] Merge succeeded, producing 9d041cad59144042684aeb28ff07e955936fcf90
[2021-01-02T18:43:27.044Z] Checking out Revision 9d041cad59144042684aeb28ff07e955936fcf90 (PR-26)
[2021-01-02T18:43:27.068Z] Commit message: "Update http-formatters.js"
[2021-01-02T18:43:27.068Z] Cleaning workspace
[2021-01-02T18:43:26.706Z]  > git --version # timeout=10
[2021-01-02T18:43:26.709Z]  > git --version # 'git version 2.17.1'
[2021-01-02T18:43:26.713Z] fatal: bad object 7edba8e3544d4f6700385847f4f4c4daad2361f5
[2021-01-02T18:43:25.979Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-js.git # timeout=10
[2021-01-02T18:43:25.986Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:26.000Z] No valid HEAD. Skipping the resetting
[2021-01-02T18:43:26.000Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:26.011Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-js.git
[2021-01-02T18:43:26.011Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:26.014Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-logging-js.git +refs/pull/26/head:refs/remotes/origin/PR-26 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-01-02T18:43:26.582Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:26.586Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:26.605Z]  > git remote # timeout=10
[2021-01-02T18:43:26.610Z]  > git config --get remote.origin.url # timeout=10
[2021-01-02T18:43:26.614Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-01-02T18:43:26.621Z]  > git merge 15dc5f813f8a19bd0eb54fd48674240acfe4a0f7 # timeout=10
[2021-01-02T18:43:26.628Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-01-02T18:43:26.642Z]  > git config core.sparsecheckout # timeout=10
[2021-01-02T18:43:26.645Z]  > git checkout -f 9d041cad59144042684aeb28ff07e955936fcf90 # timeout=15
[2021-01-02T18:43:26.665Z]  > git rev-parse --verify HEAD # timeout=10
[2021-01-02T18:43:26.672Z] Resetting working tree
[2021-01-02T18:43:26.672Z]  > git reset --hard # timeout=10
[2021-01-02T18:43:26.679Z]  > git clean -fdx # timeout=10
[2021-01-02T18:43:28.636Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-01-02T18:43:29.301Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-01-02T18:43:29.643Z] Running in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26/src/go.elastic.co/apm/ecs-logging-js/.git
[2021-01-02T18:43:29.685Z] Archiving artifacts
[2021-01-02T18:43:30.402Z] + git rev-parse HEAD
[2021-01-02T18:43:30.784Z] + git rev-parse HEAD
[2021-01-02T18:43:31.104Z] + git rev-parse origin/pr/26
[2021-01-02T18:43:31.164Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-01-02T18:43:31.996Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-01-02T18:43:33.000Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-logging-js/pulls/26/reviews return 0 elements
[2021-01-02T18:43:33.066Z] [INFO] githubPrCheckApproved: Title: Check for socket being available - User: mroohian - Author Association: FIRST_TIME_CONTRIBUTOR
[2021-01-02T18:43:33.410Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-01-02T18:43:33.410Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-01-02T18:43:33.497Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-01-02T18:43:33.519Z] Sleeping for 5 sec
[2021-01-02T18:43:34.441Z] Stage "Parallel" skipped due to earlier failure(s)
[2021-01-02T18:43:34.561Z] Stage "Test - Node.js v10" skipped due to earlier failure(s)
[2021-01-02T18:43:34.576Z] Stage "Test - Node.js v12" skipped due to earlier failure(s)
[2021-01-02T18:43:34.588Z] Stage "Test - Node.js v13" skipped due to earlier failure(s)
[2021-01-02T18:43:34.676Z] Failed in branch Test - Node.js v10
[2021-01-02T18:43:34.685Z] Failed in branch Test - Node.js v12
[2021-01-02T18:43:34.693Z] Failed in branch Test - Node.js v13
[2021-01-02T18:43:35.551Z] Running on Jenkins in /var/lib/jenkins/workspace/_nodejs_ecs-logging-js-mbp_PR-26
[2021-01-02T18:43:35.967Z] [INFO] getVaultSecret: Getting secrets
[2021-01-02T18:43:36.273Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-02T18:43:37.107Z] + chmod 755 generate-build-data.sh
[2021-01-02T18:43:37.107Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1 ABORTED 231202
[2021-01-02T18:43:37.657Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1/steps/?limit=10000 -o steps-info.json
[2021-01-02T18:43:38.569Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-js-mbp/PR-26/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-01-02T18:43:38.569Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-01-02T18:43:39.912Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-01-02T18:43:41.774Z] Retry 3/3 exited 22, no more retries left.

@mroohian Hi, and thanks for the fix! Would you be able to sign our CLA so I can merge this PR? Sorry for the delay in responding.

I've fixed this with the equivalent patch in https://github.com/elastic/ecs-logging-nodejs/commit/426102a31d0cf0f3b91b6d233aacdc8c8884b436
Thanks for having made the PR.


Laravel 9 missing on packagist (failed deploy?)

Hi
it looks like it failed to deploy the proper dependencies for Laravel 9: https://packagist.org/packages/beyondcode/laravel-mailbox

even though your code in repo suggests 9.0 is allowed: https://github.com/beyondcode/laravel-mailbox/blob/master/composer.json

could you try a re-deploy?

@joelharkes Thanks!

@mpociot Could you please tag a new version, so we can use it in composer? Thanks! :)

👀

+1

I know this is open-source and I understand if there's a delay to support newer Laravel versions. A few weeks or months, ok. But Laravel 9 came out more than 6 months ago.
A lot of us are held back by this package. I think you should either archive it or maintain it.


goverlay: 0.7.1 -> 0.9.1

Description of changes
Changed hash and version

Things done
Changed the hash and version to fetch goverlay 0.9.1 from it's github repository.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Hi, sorry I completely forgot about this PR. I changed the base to master, is there anything else I should add?

Why was this closed without creating a new issue? The current version in nixpkgs is still 0.7.1