Step 3 is still running.. more than 24 hours

Hi,
I'm having some issues at the step 3.
I have followed all the steps and configurations on the Readme.
But I runned the Step 3 more than 24 hours ago and I still having the message "loading word2vec vectors...".
I'm running at SageMaker Studio on a machine with  4 vCPU and 16 GB of memory.

Is that correct? Or did I something wrong?
I runned the Step 3 at another terminal that's because the Step 2 stopped at this screen.

I really appreciate any suggestion.

Hello,
Have you started the bert-as-service? You SHOULD run the bert server in the background and then you can run the encoder (step 3). If the code stuck, it means that it is waiting for an alive bert server (which probably you do not have).
When the bert server is alive, step 3 exactly estimates the time you are running the code and the remaining time for the whole process.

@amirmohammadkz Yes. I did it.
When I run the step 2 bert-serving-start -model_dir uncased_L-12_H-768_A-12/ -num_worker=4 -max_seq_len=NONE -show_tokens_to_client -pooling_layer -12 -11 -10 -9 -8 -7 -6 -5 -4 -3 -2 -1  to start bert-as-service it show me this message:
`(vj2) bash-4.2$ bert-serving-start -model_dir uncased_L-12_H-768_A-12/ -num_worker=4 -max_seq_len=NONE -show_tokens_to_client -pooling_layer -12 -11 -10 -9 -8 -7 -6 -5 -4 -3 -2 -1
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:526: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:527: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:528: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:529: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:530: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/opt/conda/envs/vj2/lib/python3.6/site-packages/tensorflow/python/framework/dtypes.py:535: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
usage: /opt/conda/envs/vj2/bin/bert-serving-start -model_dir uncased_L-12_H-768_A-12/ -num_worker=4 -max_seq_len=NONE -show_tokens_to_client -pooling_layer -12 -11 -10 -9 -8 -7 -6 -5 -4 -3 -2 -1
ARG   VALUE

       ckpt_name = bert_model.ckpt
     config_name = bert_config.json
            cors = *
             cpu = False
      device_map = []
   do_lower_case = True

fixed_embed_length = False
fp16 = False
gpu_memory_fraction = 0.5
graph_tmp_dir = None
http_max_connect = 10
http_port = None
mask_cls_sep = False
max_batch_size = 256
max_seq_len = None
model_dir = uncased_L-12_H-768_A-12/
no_position_embeddings = False
no_special_token = False
num_worker = 4
pooling_layer = [-12, -11, -10, -9, -8, -7, -6, -5, -4, -3, -2, -1]
pooling_strategy = REDUCE_MEAN
port = 5555
port_out = 5556
prefetch_size = 10
priority_batch_size = 16
show_tokens_to_client = True
tuned_model_dir = None
verbose = False
xla = False
I:VENTILATOR:[__i:__i: 67]:freeze, optimize and export graph, could take a while...
I:GRAPHOPT:[gra:opt: 53]:model config: uncased_L-12_H-768_A-12/bert_config.json
I:GRAPHOPT:[gra:opt: 56]:checkpoint: uncased_L-12_H-768_A-12/bert_model.ckpt
I:GRAPHOPT:[gra:opt: 60]:build graph...
WARNING: The TensorFlow contrib module will not be included in TensorFlow 2.0.
For more information, please see:

https://github.com/tensorflow/community/blob/master/rfcs/20180907-contrib-sunset.md
https://github.com/tensorflow/addons
If you depend on functionality not listed there, please file an issue.

I:GRAPHOPT:[gra:opt:132]:load parameters from checkpoint...
I:GRAPHOPT:[gra:opt:136]:optimize...
I:GRAPHOPT:[gra:opt:144]:freeze...
I:GRAPHOPT:[gra:opt:149]:write graph to a tmp file: /tmp/tmpvb1uc7_b
I:VENTILATOR:[__i:__i: 75]:optimized graph is stored at: /tmp/tmpvb1uc7_b
I:VENTILATOR:[__i:_ru:129]:bind all sockets
I:VENTILATOR:[__i:_ru:133]:open 8 ventilator-worker sockets
I:VENTILATOR:[__i:_ru:136]:start the sink
I:SINK:[__i:_ru:306]:ready
I:VENTILATOR:[__i:_ge:222]:get devices
W:VENTILATOR:[__i:_ge:246]:no GPU available, fall back to CPU
I:VENTILATOR:[__i:_ge:255]:device map:
worker  0 -> cpu
worker  1 -> cpu
worker  2 -> cpu
worker  3 -> cpu
I:WORKER-0:[__i:_ru:531]:use device cpu, load graph from /tmp/tmpvb1uc7_b
I:WORKER-2:[__i:_ru:531]:use device cpu, load graph from /tmp/tmpvb1uc7_b
I:WORKER-1:[__i:_ru:531]:use device cpu, load graph from /tmp/tmpvb1uc7_b
I:WORKER-3:[__i:_ru:531]:use device cpu, load graph from /tmp/tmpvb1uc7_b
I:WORKER-2:[__i:gen:559]:ready and listening`
Only one WORKER show as "ready and listening".
Is that correct?
At "bert-as-service" documentation page, it seens that all WORKERS are ready.

All workers should be ready before running the code. If you face a problem in that, check the bert-as-service repository.
My suggestion is just to test the server with 1 worker. It might work for you.


Merge 0.5

:nate:

@flyingleafe it's for you :gun:
@gromakovsky and it's for you :hocho:

src/Pos.Wallet.Light.Redirect should not exist.

the best form of existence is nonexistence, right?


Background Fade pauses if the user tabs out or loses focus on the browser while the transition is happening.

Mostly fixed.


py -3.6 c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -3 c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
py -2 c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import sys;print(sys.executable)"
conda info --json
Error 2020-12-05 13:43:15: Detection of Python Interpreter for Command py and args -3.6 failed as file Python 3.6 not found!

-3.8-32 does not exist
Error 2020-12-05 13:43:15: Detection of Python Interpreter for Command py and args -3.7 failed as file Python 3.7 not found!
-3.8-32 does not exist
Error 2020-12-05 13:43:15: Detection of Python Interpreter for Command py and args -2 failed as file Python 2 not found!
-3.8-32 does not exist
Starting Microsoft Python language server.
Python interpreter path: ~\AppData\Local\Programs\Python\Python38-32\python.exe
Error 2020-12-05 13:43:15: Detection of Python Interpreter for Command python3 and args  failed as file  does not exist
Error 2020-12-05 13:43:16: Failed to get interpreter information for 'C:\Users\dorot\AppData\Local\Microsoft\WindowsApps\python3.exe' [Error: Command failed: "C:\Users\dorot\AppData\Local\Microsoft\WindowsApps\python3.exe" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"
at ChildProcess.exithandler (child_process.js:304:12)
at ChildProcess.emit (events.js:223:5)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)] {

killed: false,
code: 9009,
signal: null,
cmd: '"C:\\Users\dorot\AppData\Local\Microsoft\WindowsApps\python3.exe" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"'
}
Error 2020-12-05 13:43:16: Failed to get interpreter information for 'C:\Users\dorot\AppData\Local\Microsoft\WindowsApps\python.exe' [Error: Command failed: "C:\Users\dorot\AppData\Local\Microsoft\WindowsApps\python.exe" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"
at ChildProcess.exithandler (child_process.js:304:12)
at ChildProcess.emit (events.js:223:5)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)] {

killed: false,
code: 9009,
signal: null,
cmd: '"C:\\Users\dorot\AppData\Local\Microsoft\WindowsApps\python.exe" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"'
}

conda --version
Error 2020-12-05 13:45:00: Failed to create File hash for interpreter C:\Users\dorot\anaconda3\python.exe [Error: ENOENT: no such file or directory, lstat 'C:\Users\dorot\anaconda3\python.exe'] {
errno: -4058,
code: 'ENOENT',
syscall: 'lstat',
path: 'C:\Users\dorot\anaconda3\python.exe'
}
pyenv root
Error 2020-12-05 13:45:00: Failed to get interpreter information for 'C:\Users\dorot\anaconda3\python.exe' [Error: Command failed: "C:\Users\dorot\anaconda3\python.exe" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"
�� �穫��� ��� �夘� �� �⩞ �� �����婜� ��� ��������⤞ �������� �婡��.

at ChildProcess.exithandler (child_process.js:304:12)
at ChildProcess.emit (events.js:223:5)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)] {

killed: false,
code: 1,
signal: null,
cmd: '"C:\\Users\dorot\anaconda3\python.exe" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py" "c:\Users\dorot\.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\interpreterInfo.py"'
}
Starting Microsoft Python language server.

conda info --json
conda --version
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import pip"
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import pip"
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py pip --version
Error 2020-12-05 14:06:30: Error in installing the module 'ipykernel', Error: Canceled
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import ipykernel"
~\AppData\Local\Programs\Python\Python38-32\python.exe c:\Users\dorot.vscode\extensions\ms-python.python-2020.11.371526539\pythonFiles\pyvsc-run-isolated.py -c "import ipykernel"

I was having this problem with VS Code Insiders and miniconda 3 (python 3.8). So, I just installed "pip install jupyterlab", and it solved my problem.


dexie-export-import issue

I installed:
npm i --save dexie@next dexie-export-import

"dexie": "^3.1.0-alpha.9",
"dexie-export-import": "^1.0.0",

Imported:
import Dexie from "dexie";
import "dexie-export-import";

But when trying to export db:
class DBClass extends Dexie {
  friends: Dexie.Table<IFriendsTable, number>;

  constructor() {
    super("dbName");

    this.version(1).stores({
      friends: "id",
    });

    this.friends = this.table("friends");

    // fill some data
  }

}

const db = new DBClass();
const blob = (async () => db.export())();

I get typescript error:
(TypeError): db.export is not a function

Created with create-react-app with typescript template.
What am I doing wrong?

Gotta sleep more :)
I re-read documentation page and with exportDB(db) it works. Typescript complains about missing export, import properties on Dexie instance though.

Have you now found a way to use the export? I get the same error in TypeScript:
Type 'SomeDatabaseName' is missing the following properties from type 'Dexie': export, import

Thanks! I reproduced it and it turns out the problem was that the dexie dependency need to be expressed as a peerDepencency in order to not tie dexie-export-import to a certain version.
I've published a new version of dexie-export-import where the deps should be corrected. I verified that this fixed the problem for me at least.
The new version also have your PR #1343 in it.

You tell a story here for an hour. A project that can be implemented and we can see for ourselves will not be arranged


Manually copy docs for @RuntimeGeneratedFunction

This works around https://github.com/JuliaLang/julia/issues/48390 which is fixed for latest Julia releases, but is not available on 1.8 or prior.
This allows RuntimeGeneratedFunctions.jl to be compiled into a sysimage with --strip-metadata enabled.

The following trick should also work, and would avoid the duplication:
https://github.com/JuliaLang/JuliaSyntax.jl/blob/bd19475bb616c8344d5212a64cc434ecdd1fb5e4/src/parser_api.jl#L143


A $set transaction with one new property will create an $unset inverse

Note sure if this is a known issue but if in a transaction you both create a new property and also update an existing one the inverse will $unset both.
Existing Doc
{  bar: 5 }
Update
{ $set: {foo : 5, bar: 3} }
Inverse
{ $unset: {foo: "", bar: "" } }
If you need a better repro let me know and I'll make one.

No, no repro needed.  I get exactly what you're talking about.  It's almost certainly a bug that needs fixing and I'm pretty sure I know where the guilty bit of code is.
Now, having said that ... if you wanted to write an jasmine server integration test to show this failing ...
;-)

Haven't been able to reproduce this.
I'm getting this for the inverse:
{ $set: {foo: "", bar: 3 } }
... which is still problematic and needs fixing. (foo should be unset, not set to an empty string).

0.7.8 fixes this.


Need sln and vcproj files for VS2008

What steps will reproduce the problem?

The sln and vcproj files provided are for Visual Studio 2005, and it is
very difficult to use these with Visual Studio 2008. VS2008 converts them
automatically, but linking with VS2008 is a problem.

What is the expected output? What do you see instead?

I can't get the example programs to link using VS2008.

What version of the product are you using? On what operating system?

libkml-0.6.1, Visual Studio 2008, Windows XP.

Did you run the unit test suite that comes with the project? Did all tests
pass?

No. Can't build them.

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 23 Jan 2009 at 5:39

master branch now comes with cmake build which can generate visual studio project. Hence closing


Fixes for the json interface and name changes

I made some fixes to gltfPipeline since we were missing some required steps.

@lilleyse Can you merge master? It also looks like there is a test throwing the missing basePath exception you added.

Merged master and fixed the test, as well fixed some formatting things.

Coverage decreased (-0.04%) to 94.062% when pulling c8b29e3f0996637f74a673f688643a7cfac6cf25 on fixes into fa0f23d56d8b4a146763448d9d5be7add6bb715f on master.

@lilleyse these changes look good to me, is it ready to merge?

Yup it's ready.


Yanwen tracking check

Maybe broken or working, need to check it's status

Test parcel code: UF339843323YP


Test Issue created at Wed, 28 Jul 2021 14:32:43 GMT

Test issue body  Wed, 28 Jul 2021 14:32:43 GMT

Comment on issue at Wed, 28 Jul 2021 14:32:46 GMT


Jobs are not moving from running to completed when finished.

Quit jobs do move correctly.

This was a filtering issue with the two job views.  This should now be fixed.


IDNA mapping. Converts Σ.com to σ.com.

LGTM

I'm going to hold on this for now in favor of the IDN 2003 spec already offered by Java 6.


fix simple typo

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          64     64
=====================================
  Hits           64     64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac38320...687f42e. Read the comment docs.

Thanks @lpmi-13! But this an an is actually used to illustrate that the plugin works. Read the Usage section carefully!


add config example for coc.nvim users

I am not the first one configuring typst-lsp in coc, @ysl2 has already been trying as in #422, but that issue was closed without a resolution. The original coc languageserver config property initializationOptions is marked as deprecated and now we should use settings.

This PR runs into same situation as https://github.com/nvarner/typst-lsp/pull/497, however, I don't quite know how to solve these error :(.

|
123 | pub trait FileIdExt {
    |           --------- method in this trait
124 |     fn with_extension(self, extension: impl AsRef<OsStr>) -> Self;
    |        ^^^^^^^^^^^^^^
    |

this PR didn't touch FileIdExt so it seems like a problem on typst-lsp 's part tbh

This PR has been open for a while. As @astrale-sharp mentioned, it doesn't change the code and isn't the cause for the failed CI checks. It's a simple and straightforward change that suits the convenience for coc users. I hope we can merge it.

Sorry if this is not the place to ask this, but can you get syntax highlighting in neovim with coc and typst-lsp?
I have installed typst-lsp with coc and it correctly gives me autocompletion suggestions but I have no syntax highlighting. I don't know if this is supposed to be a feature and if so, how can I enable it?

@jfab20
Hi, try setting "semanticTokens.enable" to true and see if it works.

@jfab20 Hi, set semanticTokens.enable to true in :CocConfig and see if it works.

Thanks! Like this right?
{
"semanticTokens.enable": true,
"languageserver": {
    "typst": {
        "command": "typst-lsp",
        "filetypes": ["typst"],
        },
    }
}

I do get highlighting although it is quite minimal, for example neither headings nor math get syntax highlighting, like this:

Is this how it is supposed to be?

@jfab20
It looks the same on my side. I think this is what it is supposed to be.

Any chance to get it merged?


Update rules

Remove new from .jscsrc.
Add .stylelintrc from juwai/juwai-com-v2#29.

Done in https://github.com/juwai/juwai-lint-cfg/pull/6.


Make CLI build faster

Not only is the CLI stage the current bottleneck for our build's first stage, it also keeps a lot of agents busy as it runs. We should look into speeding it up. An obvious first step is to cache the target folder... maybe even use something like sccache.

sscache didn't end up being that useful. It seemed like maybe a 10% time reduction, but these are also pretty noisy.
Instead I opted to only run a dev build with clippy for main's CI, which is much faster than a full optimized production build. Real production builds are unchanged, but I think these are a much lesser concern since they only run ~once a day.

Easy verification, check that PR builds in https://dev.azure.com/monacotools/Monaco/_build?definitionId=111 are only linting and not compiling the CLI, and so are much less than 10 minutes 🙂


Karyotype function demonstration

It would be great to have (or link to) an example notebook showcasing this function, using the API example as a starting point, and including some additional explanations. Akin to the terms of use example or the diplotype clustering blog.

Indeed writing a little blog post. Will aim to do it on the plane to NOLA.
Making a map - can I use all vobs samples or Shall I stick to ag3?
On Mon, 11 Nov 2024, 13:05 Alistair Miles, @.***> wrote:

Thanks @ahernank https://github.com/ahernank, good idea. I think
@sanjaynagi https://github.com/sanjaynagi was contemplating a blog post
on the new karyotype function possibly? If so we could advertise that.
—
Reply to this email directly, view it on GitHub
https://github.com/malariagen/vobs-updates/issues/52#issuecomment-2468134444,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIKN6HOE3QLIPF7KEERQ64L2ACTSBAVCNFSM6AAAAABRRR4LSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGEZTINBUGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Cool, thanks Sanj. For a map you could use all samples out of embargo, i.e., where unrestricted_use is True.

@sanjaynagi has a blog post up... https://www.sanjaycnagi.com/blog/2024-11-28-karyotyping/
We should make an update here and point to Sanj's blog.

Let me know if there's anything you want adding to the post, it was quite brief

Let me know if there's anything you want adding to the post, it was quite brief

Thanks @sanjaynagi. I think the main question most folks will have is how to compute karyotype frequencies and visualise them. I raised an issue over on https://github.com/malariagen/malariagen-data-python/issues/652 to implement some karyotype frequencies functions. I saw you also posted some code there, thanks for that. Still there's not quite enough information there for someone else to use it, e.g., the calc_allele_freq() function is used but not defined.
How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.
In parallel we could work on adding karyotype frequencies functions into malariagen_data.
(We should also add a function to malariagen_data to make map pie chart plots!)

Let me know if there's anything you want adding to the post, it was quite brief

Thanks @sanjaynagi. I think the main question most folks will have is how to compute karyotype frequencies and visualise them. I raised an issue over on malariagen/malariagen-data-python#652 to implement some karyotype frequencies functions. I saw you also posted some code there, thanks for that. Still there's not quite enough information there for someone else to use it, e.g., the calc_allele_freq() function is used but not defined.

Woops, will add that too

How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.

Yes, I will do this!

(We should also add a function to malariagen_data to make map pie chart plots!)

haha, definitely!

How about as a short term measure, you add a link in your blog post to the full notebook that you created to generate the map plot? At least that way someone adventurous can reuse your code and get some outputs.

Yes, I will do this! update: I have done it

Awesome, thanks!
https://colab.research.google.com/drive/1qlhygvn1N9XFn5oQgWIoQOMIzMQkSGoE?usp=sharing


[DO NOT MERGE] Draft to reduce places calls

Hey @LoneRifle @xkjyeah @shen-xujing can help me take a look at this and let me know what you think?
It's not a complete PR, just want to see if at this point anyone of you have strong opinions on how I'm doing this? I feel like there should be a better way to do this, but don't know enough about angular to be sure.

Could you briefly explain the concept of what you are trying to do?

At a high level, we wanted to only do a place query when the normal text results are less than a certain length.
this implementation involves not doing the place query in auto complete so that forces a text search first. Then if the text search results are too small, do the place query.
One tricky thing is how to handle this for multiple types of routes I.e. if say both the crowd start and the normal routes have Insufficient results we want to avoid doing two place queries.

Oh... It looks like you might not be solving the problem. allRoutes is the list of all 100+ routes, so it will never be less than 3.
There's a bit of code duplication between crowdstart, lite and regular routes at the moment. Would you want to work on that first?

I use the allRoutes that is after the filter, so it is less than 3 if it doesn't match anything in the text search! I've tested this and pretty sure it works.
I will look at the code duplication too

Oops sorry. I think I understand your code now.
Essentially you want to:

When query changes
Do a textual filter
If the textual filter fails do a places query

Currently you are shunting step 2 and 3 to a more distant part of the code.
You should handle all of that within the queryText watcher

Ok thanks I'll check that out!

Otherwise... It sounds like a reasonable way to reduce the number of queries. Ok, pls proceed then

Okay this is ready for review. If approved, can merge and see if it helps with reducing the place queries.
@xkjyeah

Currently you are shunting step 2 and 3 to a more distant part of the code.
You should handle all of that within the queryText watcher

Right now, step 2 (textual filter) is being done in a whole bunch of places, handled separately for each different type of route (e.g. activated crowdstart, unactivated crowdstart, normal, lite).
I agree that we should refactor that to be handled within the queryText watcher. However, this PR is just a small test to see if we can reduce the number of places queries, and I don't want to try and make too many changes at the same time.
I'll do the refactor in the separate PR after this! :)

I cannot agree with watching a Boolean value (getPlaceDetails).
Just for the regular routes part, could you write a watcher that does all
three steps? Structure the watchers they way you might structure computed
properties in Vue.
You don't have to rewrite the other watchers (lite, crowdstart).
On 12 Oct 2017 11:17 am, "Joel Choo"<EMAIL_ADDRESS>wrote:

Okay this is ready for review. If approved, can merge and see if it helps
with reducing the place queries.
@xkjyeah https://github.com/xkjyeah
Currently you are shunting step 2 and 3 to a more distant part of the code.
You should handle all of that within the queryText watcher
Right now, step 2 (textual filter) is being done in a whole bunch of
places, handled separately for each different type of route (e.g. activated
crowdstart, unactivated crowdstart, normal, lite).
I agree that we should refactor that to be handled within the queryText
watcher. However, this PR is just a small test to see if we can reduce the
number of places queries, and I don't want to try and make too many changes
at the same time.
I'll do the refactor in the separate PR after this! :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datagovsg/beeline-frontend/pull/410#issuecomment-336009361,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACiTR7xQKKWkIySdi_ndBO8zWAUv1HsOks5srYTUgaJpZM4P1RId
.

See #415


Disable fastlogin method missing

Disable fastlogin method missing, i can make PR this weekend

Sure!

@jouniikaheimo did you manage to get anywhere with this disabling PR?


markers not rendering

I am having a problem, no marker is rendering.
here is my package.json
"react": "16.3.1",
"react-native": "0.55.2",
"react-native-maps": "https://github.com/react-community/react-native-maps.git",

this is my map screen:
import MapView from 'react-native-maps';
import { Marker } from 'react-native-maps';

export default class HomeStudent extends Component {
      constructor(props) {
    super(props);
    this.state={
      //default location
      location: {
        latitude: 31.11452,
        longitude: 32.236515,
        latitudeDelta: 0.3,
        longitudeDelta: 0.3,
      },

      markers: [
        {
          latlng: {
            latitude: 31.957866,
            longitude: 35.857494,
          },
          title: "habiba",
          description: "none at the moment"
        },
        {
          latlng: {
            latitude: 31.957866,
            longitude: 35.857494,
          },
          title: "7th circle",
          description: "none at the moment"
        },
      ],
      id: "",
    };
  }

  render() {
    return (
      <View style={styles.container}>
        <MapView
            showsUserLocation={true}
            showsMyLocationButton={true}
            followsUserLocation={true}
            enableHighAccuracy={true}
            style={styles.map}
            region={this.state.location}
        >

        {this.state.markers.map(marker => (
          <MapView.Marker
            coordinate={{latitude: marker.latlng.latitude, longitude: marker.latlng.longitude}}
            title={marker.title}
            description={marker.description}>
          </MapView.Marker>
          ))}

        </MapView>
      </View>
    );
  }
}

when i run use react-native run-android not markers is rendered, but the maps renders without issue.
is there something wrong with my code?

sorry guys, i was rendering different screen, which was the reason i thought markers are not being rendered.
will have to double check next time.


Pod does not match master branch

When installing via cocoapods, xcode complains about old syntax right away.  I compared the files that you get when you download a zip and the swift 3 changes are there in the download but not the pod.

There has not been a release that includes the Swift 3 changes, though they are on the master branch.
Until there is an updated release, you might consider updating your Podfile to use the master branch directly as is documented here: https://guides.cocoapods.org/syntax/podfile.html#pod

Awesome, thanks for the tip. I was trying to do just that!

@stephencelis maybe time to get a new version out? 0.11?

Manually pointing to the master branch in cocoapods worked perfectly.
  use_frameworks!   pod 'SQLite.swift', :git => 'https://github.com/stephencelis/SQLite.swift'

#524


onDidChangeTextDocument Api timing issue

VSCode Version: 1.4.0-insider
OS Version: El Capitan

Steps to Reproduce:

Enter some text in an editor window

Related VsCodeVim issue https://github.com/VSCodeVim/Vim/issues/680

@jrieken what is the 2-minute executive summary of the problem ;)?

@bpasero Unsure if you want to know so short before the weekend 🙉 The problem is that we have one event source for document changes and another for dirty. So, one event is from the editor world and the other from the workbench world and we don't synchronise on them - so we first tell extensions a document has changes (and at that time it's not dirty) and on next tick we tell extensions a document is dirty. I have no clue how we bring all those things together yet...

got it, debt for next sprint.

It seems this cannot be fixed with a normal setImmediate hack

Probably be solved if we figure out https://github.com/Microsoft/vscode/issues/14275

Does not make sense to keep 2 issues open on the same problem. Continues in #14275


Add Lisk HD address discovery example [ci skip]

@Isabello take a look. you'll like it :)

@Isabello this is how the new Ed25519HdWallet can be used to derive arbitrary SLIP-0010/BIP-0032 paths


#61 Move to new logging framework, fix platform determination.

We need to hold off committing this until logging is released and more testing is conducted.

@davetcc precisely for that we have draft pull requests. Check it out:
https://github.blog/news-insights/product-news/introducing-draft-pull-requests/


[doc] Add FAQ section

FAQ would be helpful to accommodate explanations like this one https://github.com/lexicalunit/nanodbc/issues/265#issuecomment-301258759

That would be good to have!

This issue was moved to nanodbc/nanodbc#11


Fixes #67 source not defined issue

Fixes source was not defined bug reported on #67

:+1:

Make sure to update the example code because we're supposed to use source and not url for the props.

@BilalBudhani thanks for this PR.
@rclai I have updated the examples and removed the one that doesn't related anymore. Thanks.


ESR (#4) - authentication

The SDN Controller shall provide an authentication mechanism for local and remote administrators, as well as the device/VM itself (e.g., the device/VM maintains an authentication credential that can be used to authenticate it to an administrator’s client).

Comments from TC meeting on Feb 8
Define local admin because it is optional in the NDcPP

was the comment suggesting the requirement conflicts with the NDcPP? The SDN controller may extend certain reqs but it shouldn't conflict.
FIA_UAU_EXT.2.1 The TSF shall provide a local [selection: password-based, SSH public
key-based, certificate-based, [assignment: other authentication mechanism(s)]] authentication
mechanism to perform local administrative user authentication._

May be suggesting that within the context of the NDcPP the definition or implementation of a local administrator role is not mandatory but optional. This could imply that the NDcPP allows for flexibility regarding whether or not a device should have a designated local administrator role defined within its security policy or configuration. The local administrator typically has elevated privileges for managing the device's settings and security directly on the device, as opposed to through network-based administration. Given this optionality, the statement underscores the need to explicitly decide and define the role and privileges of a local admin within the specific implementation or policy adhering to the NDcPP standards, if chosen to be included.
And also as you mentioned, the SDN controller may extend certain reqs but it shouldn't conflict, I think in that way too.

I think this is a reasonable approach and will fold into the conversation we have regarding PP vs. PP module (that inherits the controls from the base PP)


Test update, to test forcing Node 20, try 2

The PR containing this commit should only be made against the EliahKagan/readthedocs-actions fork, and not against its upstream. This PR should also not be accepted.

📚 Documentation preview 📚: https://readthedocs-preview--4.org.readthedocs.build/en/4/

Still not working, as expected.
This comment is posted on behalf of @EliahKagan.


does project.nvim follow the XDG_BASE_DIRECTORY specifications?

hello there :wave: :yum:
i'm writing a little script to automatically load all my git projects into the project.nvim history file and i'm trying to make it cross-platform :open_mouth:
i see this file is at ~/.local/share/nvim/project_nvim/project_history on my system.
i have XDG_DATA_HOME set to ~/.local/share/.
i also see in the lua code of project.nvim that the file is read from vim.fn.stdpath which also gives me ~/.local/share/nvim/.
can i safely assume the project_history file will be in $XDG_DATA_HOME/nvim/project_nvim/?
cheers :yum:

Not related to your question, but having a feature like this directly in project.nvim would be great. I was looking for something similar.

@dgmora
Neovim supports XDG so its get path functions should be using them with ‘/nvim’ concatenated to the strings , unless overriden.
The project.nvim example config uses vim.fn.stdpath('data’) which is $XDG_DATA_HOME../nvim/
and appends to make the following ~/.local/share/nvim/project_nvim.  I looked at the defaults in the plugins code and this is also the default so the answer is yes it does use XDG
You can set it in you nvim config anyway ...
require('project_nvim').setup({
...
...
    datapath = vim.fn.stdpath('data'),
}

and, of course,  the location can be changed, however,   it looks like it will always append  ‘/project_nvim’ to that path
(see below for more info)

@amtoine
As I mentioned above the builtin default for ‘datapath' is vim.fn.stdpath('data’)
looking at the code ...
 M.datapath = require("project_nvim.config").options.datapath
  M.projectpath = M.datapath .. "/project_nvim" -- directory
  M.historyfile = M.projectpath .. "/project_history" -- file

We can see
projects are always stored in the path  datapath .. /project_nvim’ the ‘project_history’ is always stored at  datapath .. /project_nvim/project_history’


Can you provide us some binaries with the exllama kernels?

Hello,
It seems like your binaries from yesterday doesn't have the exllama kernels in it, when I try to load models with AutoGPTQ on ooba's webui I got this warning:

I tried to make my own wheels but I got some errors...
         Cr‚ation de la bibliothŠque D:\Large-Language-Models\text-generation-webui\repositories\Aut
oGPTQ\build\temp.win-amd64-cpython-310\Release\autogptq_cuda/exllama\exllama_kernels.cp310-win_amd64
.lib et de l'objet D:\Large-Language-Models\text-generation-webui\repositories\AutoGPTQ\build\temp.w
in-amd64-cpython-310\Release\autogptq_cuda/exllama\exllama_kernels.cp310-win_amd64.exp
      q4_matmul.obj : error LNK2001: symbole externe non r‚solu cublasHgemm
      build\lib.win-amd64-cpython-310\exllama_kernels.cp310-win_amd64.pyd : fatal error LNK1120: 1 e
xternes non r‚solus
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\
MSVC\\14.29.30133\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for auto-gptq
  Running setup.py clean for auto-gptq
Failed to build auto-gptq
ERROR: Could not build wheels for auto-gptq, which is required to install pyproject.toml-based projects

That's why I'd like to know if you are ok to provide us those wheels?

Yes, I'm definitely like to provide pre-build exllama_kernels for windows users, however there are some problems to build it on windows when using automatic github workflow. As described here, there are some prerequisites that should be installed on windows before trying compiling exllama_kernels.

I'll just wait for you to release the wheels with the exllama kernels, thanks a lot!


[BUG] Run in cpu mode it is report list index out of range

Describe the bug
I runing in text-generation-webui on cpu mode,it's normal but i click generate,the console print this error:

device = [d for d in self.hf_device_map.values() if d not in ('cpu','disk')][0]
IndexError:  list index out of range

Hardware details
CPU:Intel i5-9400
RAM:32GB
GPU:Intel UHD Graphics 630 and AMD Radeon RX 560 2G
Software version
Python 3.10
To Reproduce
Steps to reproduce the behavior:

Run Text-generation-webui
Click on 'Generate'
See error

Screenshots

Same here. Any fix so far ?

I also get this error when I try to split GPU and system RAM. Any fix for this?

Same here. Want to use full CPU mode. Any fix so far?

Same here, waiting for fix

As transformers has native support of Auto GPTQ, anyone tried with it ?

Same here:
2023-09-24 00:36:46 INFO:Loading TheBloke_Chronos-70B-v2-GPTQ...
2023-09-24 00:36:46 INFO:The AutoGPTQ params are: {'model_basename': 'model', 'device': 'cpu', 'use_triton': False, 'inject_fused_attention': True, 'inject_fused_mlp': True, 'use_safetensors': True, 'trust_remote_code': False, 'max_memory': None, 'quantize_config': None, 'use_cuda_fp16': True, 'disable_exllama': False}
2023-09-24 00:36:46 WARNING:Exllama kernel is not installed, reset disable_exllama to True. This may because you installed auto_gptq using a pre-build wheel on Windows, in which exllama_kernels are not compiled. To use exllama_kernels to further speedup inference, you can re-install auto_gptq from source.
2023-09-24 00:36:46 WARNING:CUDA kernels for auto_gptq are not installed, this will result in very slow inference speed. This may because:
1. You disabled CUDA extensions compilation by setting BUILD_CUDA_EXT=0 when install auto_gptq from source.
2. You are using pytorch without CUDA support.
3. CUDA and nvcc are not installed in your device.
2023-09-24 00:38:36 WARNING:skip module injection for FusedLlamaMLPForQuantizedModel not support integrate without triton yet.
2023-09-24 00:38:36 INFO:Loaded the model in 109.51 seconds.

Traceback (most recent call last):
  File "C:\PortablePrograms\oobabooga\modules\callbacks.py", line 56, in gentask
    ret = self.mfunc(callback=_callback, *args, **self.kwargs)
  File "C:\PortablePrograms\oobabooga\modules\text_generation.py", line 347, in generate_with_callback
    shared.model.generate(**kwargs)
  File "C:\PortablePrograms\oobabooga\installer_files\env\lib\site-packages\auto_gptq\modeling\_base.py", line 442, in generate
    with torch.inference_mode(), torch.amp.autocast(device_type=self.device.type):
  File "C:\PortablePrograms\oobabooga\installer_files\env\lib\site-packages\auto_gptq\modeling\_base.py", line 431, in device
    device = [d for d in self.hf_device_map.values() if d not in {'cpu', 'disk'}][0]
IndexError: list index out of range
Output generated in 1.85 seconds (0.00 tokens/s, 0 tokens, context 71, seed<PHONE_NUMBER>)

I don't think this has been fixed yet.
As a temporary fix, add a try except block around line 431 and set torch device to cpu as a default option.
 try:
      device = [d for d in self.hf_device_map.values() if d not in {'cpu', 'disk'}][0]
  except:
      device = 'cpu'
  return torch.device(device)


Doesn't work well with debugging Chromium

I built Chromium (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/windows_build_instructions.md) and tried to use raddebugger for debugging it. I wondered how it will be comparing to vscode debugging. raddebugger doesn't feel stable, it either hangs, crashes, or shows OOM error. I think this is a good stress test for the debugger. Looking forward when it becomes more stable, looks really promising!

Yeah this is known & on the list. We've designed the debugger to allow for e.g. UE and Chrome debugging, so we'll get there hopefully later in the alpha, just a matter of maturity, battle testing, and ironing out the most major issues.


fix: hide domain action is user doesnt have create persmission

Changes

Hide delete domain and verify domain if user doesn't have access to create domain (org manage).
Add back button to project and team page. the back button will navigate to listing page.
Fix Preferences spelling typo. Perferences -> Preferences
Disable org name (slug) text field as it is not user cant update org name.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.559%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6065

Relevant Lines:
11996

💛  - Coveralls


Commit characters break playing back recorded macros

I noticed today that nvim-cmp was causing issues with playing back recorded macros, and it looks like the commit characters are to blame.
Steps to reproduce

Set up tsserver language server with the built-in LSP.
Set up nvim-cmp with the nvim_lsp source.
Open a JavaScript file in a JavaScript project such that LSP completion will work.
Record a macro that includes . and (, for example with qaoconsole.log('hi')<esc>q.
Playback the macro with @a and observe that it writes console.log('hi') on a new line as expected.
Select an LSP completion, for example manually type console.l and then use the completion menu to select the log LSP completion.
Try again to playback the macro with @a and observe that it writes consolelog'hi').

Then add confirmation = { get_commit_characters = function(_) return {} end } to your nvim-cmp config (always return no commit characters) and try the above steps again. This time the macro will playback successfully even after selecting an LSP completion.
My config
local cmp = require('cmp')

cmp.setup {
  completion = {
    autocomplete = false,
  },

  formatting = {
    -- show completion source in menu
    format = function(entry, vim_item)
      vim_item.menu = ({
        buffer = "[buf]",
        nvim_lsp = "[LSP]",
        nvim_lua = "[Lua]",
        path = "[path]",
      })[entry.source.name]

      return vim_item
    end,
  },

  mapping = {
    ['<C-d>'] = cmp.mapping.scroll_docs(-4),
    ['<C-f>'] = cmp.mapping.scroll_docs(4),
    ['<C-n>'] = cmp.mapping.complete(),
    ['<C-e>'] = cmp.mapping.abort(),
    ['<C-y>'] = cmp.mapping.confirm({
      behavior = cmp.ConfirmBehavior.Insert,
      select = true,
    }),
  },

  snippet = {
    expand = function(args)
      vim.fn['vsnip#anonymous'](args.body) -- requires vim-vsnip
    end,
  },

  sources = {
    -- in priority order
    { name = 'nvim_lsp' },
    { name = 'nvim_lua' },
    { name = 'path' },
    { name = 'buffer' },
  },
}

I can understand your problem, but it's too difficult ...
Do you know of other complete engines that support this behavior?

Ah. I've understand. You don't use auto-completion in macro recording time.
If so, I can fix it.

Fixed in https://github.com/hrsh7th/nvim-cmp/commit/8fb4ee10759440fd1e1298e4e8b83dff2d9a62a3

Wow, that was a speedy turnaround -- thanks for looking into this so quickly! Unfortunately, the fix actually made things worse.  Here's a screencast that shows the issue:
https://user-images.githubusercontent.com/43078205/132765967-27b4418a-05a3-45ea-8d72-39f7e4e45d08.mov

I think macro is tooooo difficult to support.
I will disable all of features when the macro is recording.

I don't think disabling features when the macro is recording will fix the issue. The macro records just fine.
I totally understand that there may not be a good way to fix this and keep supporting commit characters. If that's the case, it would be nice to at least put a note in the readme linking to this issue and mentioning the workaround of setting confirmation.get_commit_characters to function(_) return {} end.
Either way, thanks for looking into this and for your work on the plugin!

I know that Autopairs plugins has similar issue - macro records ok, but on second run  the auto inserted brackets fail. And it that case disabling autopairs, for time of recording macro actually works.   I have to manually close bracktes, but at least I can run the macro multiple times.

Fixed in 8fb4ee1

This commit completely broked all my macro replays and normal commands with dots and brackets.

@jasonccox I think this issue was fixed now. Could you test with latest?

https://user-images.githubusercontent.com/629908/133055790-99ec1209-7b5b-4188-9cbd-8f9e12a63876.mp4

Unfortunately I'm still seeing the same behavior as I showed in the screencast above. It looks like you're using MacroS, MacroE, and MacroRun commands to record and run your macros, though -- do those do something special that q<reg>, q, and @<reg> don't do?

No. It's just a proxy command (I've mapped the q to close the buffer.

I've re-fixed the macro.
@jasonccox Thank you for your polite and detailed issue report.

I think we can't fix it perfectly. The current implementation is enough to use, I think. Sorry...
If I found the improvement point, I will fix it.

I'm still seeing the same behavior. If you don't think it can be fixed, then I'd recommend reverting to the original behavior (which turned console.log('hi') into consolelog'hi')); the new behavior (shown in my screencast) is worse, in my opinion.

I'm re-fix it... Hm... it's too difficult 🤣

It does seem to be working as expected after a212356641917e08d4e2ec70201c5e30d8a8339a -- nicely done!


Derived Values

My initial cut of the problem definition is as follows:

within a re-frame app ...
... for a certain period of time (perhaps while a certain panel is showing) ...
... there's a need to compute a materialised view of data within app-db ...
... which will be used both within views (provided by subscriptions) ...
... and within event handlers.
The computation involved may be a CPU expensive, so we want to cache it. Ie. we don't want to have it calculated via subscriptions and then ALSO calculated within event handlers. We want it only calculated once, when required and as inputs to the calculation change, and then available to both contexts.
Note: we also don't want the materialised value computed outside of the "time" when it is needed.  For example, the calculation might only be needed when a single panel is showing to the user.

Currently, subscriptions provide a way to create "derived values" that compute only when needed.  So they tend to be the tool we reach for. But is there a better solution??

I wouldn't constrain the time, i.e. I think that the 2nd, the 3rd, and the last points should not be there.
I also wouldn't constrain the place, i.e. the 4th point should not be there.
Calling reg-sub creates a graph. It's there regardless of whether those subs are actually used or not. In some situations, event handlers might need values from the nodes of such a graph. In other words, subscriptions have the capacity to create values and event handlers should be able to utilize that capacity. That's the bare minimum description of the problem, IMO.
I don't think there's any extra mechanism that's needed - I think re-frame-utils solves the problem almost perfectly.
There are, however, some improvements that I can see:

An ability to mark any subscription as a persistent one, so it doesn't get removed from the cache, neither by re-frame-utils nor by re-frame itself
A warning when someone calls subscribe or derefs a sub outside of the reactive context, unless such a sub is marked as "event handler-friendly" (the warning should still be there for regular JS events/callbacks)

On a related note, recently you mentioned that you were looking at rule engines. I'm still not entirely sold on the idea of them being useful for re-frame (albeit, I haven't spent that much time thinking about it), but this is a place where a rule engine would fulfill the need automatically, just by the virtue of always having all values (inputs, intermediate values, outputs) stored within one place. That is, if I understand the concept well enough.

@p-himik

I wouldn't constrain the time

I believe the requirement is often time-constrained (but certainly not always). So, I believe that's an essential part of the problem statement because it will make some solutions viable and others not so.

Calling reg-sub creates a graph

I know you know this, but for clarity, I'll point out that this statement isn't true.  reg-sub defines the template for how to create nodes in the Signal Graph.  But what drives node existence is subscriptions.  And what drives subscription existence is  View existence.  The Signal Graph feeds the data-hungry requirements of the current set of View functions (which contain subscriptions).  Sometimes you need certain nodes, and sometimes you don't.
So this comes back to time again.  Or, better, "state".  Sometimes the application is in a state which requires these materialised views, and sometimes it isn't.  At the moment, the state is implicit.  The existence of certain Views (or not) is what drives subscriptions which, in turn, drives nodes in the Signal graph, which does the calculation of "derived data".
I know you know all this.  But I'm trying to be crystal clear.  A good problem definition is the best gift you can give yourself.
So my summary: applications have different states. In different states they need to calculate certain "derived values" and those values might need to be delivered to views or might be used within event handlers. Subscriptions are certainly a very nice way of handling this because they come into existence implicity when "the state" (of the UI) asks for them, and then disappear when no longer being used (by views).
app-db --> views --> subscriptions --> calculation of derived data --> event handler use

We're talking about different kinds of graphs. I was thinking specifically about what you call the template, and you're describing the concrete values graph. To the former, the views don't matter at all. Same with events - they don't care about views, they just care about cofx. It doesn't matter if a particular view is mounted and is the one that requested value X if some completely unrelated event that has nothing to do with that view or even the whole UI really needs that value X.
To me, it's easy to imagine a situation where a re-frame app is run without any views at all. Only events that use that subscriptions template to create some concrete values and reuse them when possible, thus creating a cached value graph.

applications have different states. In different states they need to calculate certain "derived values" and those values might need to be delivered to views or might be used within event handlers

I might be reading it wrong but these sentences feel like there's a direction of intent, so to speak. The state changes (i.e. app-db), and then stuff happens because of that change, including some event handlers potentially asking some subs for their values.
That, however, is not always true. In fact, quite often, in my own experience. As a simple example, consider a button press that dispatches a particular event (just in case - that button has nothing to do with the state, it's just a static button with the right :on-change value. It might be substituted with a WebSocket message or a key press or any other "active" thing in the vast web API world). That particular event might not need the :db cofx and might not produce the :db fx, but it might need some subs - only because the specification of how the relevant value can be computed is already there, in the template, almost ready to be used.

Here’s my attempt at what the needs are. Got a bit lenghty…
First of all I feel like I understand the differentiation between template vs graph. The former is a blueprint representing how it will be connected and calculated if ever needed and the latter represents what is actually in use with caching and recalculations on change. I also see that this is “simple” for UI registered subscriptions as they explicitly send creation and teardown signals. For event subs the template part would work exactly the same, and while dispatch of an event could itself be seen as a creation signal, there is no explicit teardown (unless you do it right away like re-frame-utils). This last part makes it tricky, more inefficient and/or potentially more involved for the end user if you want to provide more control over this behavior (one-off vs TTL vs permanent).
From a usability point-of-view I would say the ideal solution to me is something like this:

There is no requirement that a given subscription is used in UI for it to be available to an event.
Usage is as close as possible to reg-sub.
a) It supports :<-[:sugar] syntax just like reg-sub
b) And dynamic subscriptions
If there is a need for explicit TTL timers or similar for efficiency, their expiry will lead to performance penalty, not failure.
No default warning about performance penalty, as I understand might be the case with re-frame-utils’s inject. Having to constantly add meta data to avoid it seems like needless clutter (note that I havent’t tried it).

The “extreme” for 1) is e.g. a js/setInterval dispatching an event that depends on a subscription chain that has nothing in comon with any UI subscription needs.
I think I could personally live with quite a few limitations, as long as what you run into is performance penalties and not malfunction.
One usage scenario I have:
User performs a search returning a dataset of 10k entities. The ultimate goal is to maybe send a subset of this back to the server. Attributes for each entity sent back is way lower than what is needed by UI, but might contain computed data not required by UI. User interactions might cause recompute of the presented subset many times. Only if the user is happy with the presented subset, and triggers an event, is the event specific subscription calculated, but the user might also decide not to send anything at all back to server. In that case the event subscription is never calculated.
The above is a description of sibling subscriptions where both the UI and event sub have common ancestors in the graph. Likely at least one level 3 subscription in common, but after that the needs deviate. Subscription used in event is as described above while the UI might need eg. translation of key names to something acceptable for interop with d3js (e.g. no namespaced keys and underscore instead of dashes in names).
An attempt at describing the above sibling approach in re-frame like psudo code:
reg-sub   ;; a level 2 sub
:entities/raw
<(get db :entities/raw)>

reg-sub  ;; Might run many times due to user interaction changing config params
:entities/filtered-and-augmented
:<-[:entities/raw]
:<-[:config/params]
<potentially CPU intensive processing>

reg-sub
:entities/ui-prepped
:<-[:entities/filtered-and-augmented]
<adapt data to UI format>

reg-sub  ;; Could be skipped if you instead do this in the event handler below, but it might be nice to separate them.
:entities/backend-prepped
:<-[:entities/filtered-and-augmented]
<adapt to backend format>

reg-event-fx
:send/to-server
:<-[:entiites/backend-prepped]
<eg send data with :http-xhrio>

As mentioned on slack, another usecase/benefit I see is to hide implementation details by storing data in db under a auto namespaced key (e.g: ::raw-entities), and provide a subscription where the rest of the code can get hold of this data (<sub [:entities/raw]). Features wise, I don't see that that usecase has any more requirements than already mentioned. The key is no dependency on UI usage.
As I don’t know the re-frame codebase I should not venture into implementation ideas, but for what it’s worth:
In a scenario where the UI and event subs share a common ancestor in the graph (I believe this might often be the case), would it be possible to keep the event subscription branch alive as long as the ancestor is needed by UI? The event sub branch would not participate in “ref count” for the ancestor, but be a passive participant relying on UI for signalling cleanup/teardown. Should it happen that the UI unmounts too early, then you pay that penalty for doing a one-off event sub calculation afterwards. I'm not sure this helps anything, it was just somehting I though of for help with signaling teardown.
So, not dependant on UI usage, but an efficiency mechanism to piggyback on it.
Con: Unless there is a good way to avoid it, it might mean that the event branch is re-computed more than needed.
I hope it helps. If not, feel free to direct input needs in the right direction.

Here's my take on things, and a prototype: #790
I think I know why this issue is unsolved for 8 years.
It's a general FRP problem with no general solution (AFAIK).
Caching means trading state for computation. Concretely, ram for flops.
But, you can't cache forever. State is finite.
A cached val needs a lifecycle. We must create and destroy cached vals.
But, when your framework is stateless, there's no obvious lifecycle a cached val should follow.
We call a function unreasonable when it has different effects at different times & places.
Re-frame's subscription has a shadow-API. It's unreasonable.
Inside a reactive context, it ref-counts. Outside, it caches indelibly.
We describe this vaguely, calling it a "mistake" or a "potential memleak".
Only the super-nerds really understand what we mean. Shoutout.
#754 doesn't help. It just changes the shadow-API.
re-frame-utils.cofx/inject names its caching strategy, but this name is too generic. It also doesn't support one of re-frame's key features.
There are more solutions out there. They're all bound to be incomplete.
We don't agree on the right caching behavior because objectively there is none.
Even if we somehow did ref-counting everywhere, that isn't ideal for every use-case.
What if you dispose a sub, just to bring it back 1ms later?
Ref-counting won't help.
What if your sub has a big memory footprint, but you only need it once?
An LRU cache won't help.
So, there's no single way a sub should work. In other words, subscriptions are polymorphic.
Clojure is great at polymorphism, and re-frame is a model case.
To decomplect subs, all we need is a registry and a dispatch.
Clojure has its cake and eats it.
That's because it lives its opinion as vigorously as it defends the alternatives.
We say "eek!" to a non-reactive sub, but we need not project this apprehension onto the user.
Instead of bluntly opinionating re-frame, let's decompose our opinions into a namespace:

::raw Don't cache.
::forever Don't clear.
::reactive Dispose on unmount. Warn outside a reactive context. Status quo.
::safe If reactive, dispose on unmount, else don't cache. Our new default? See #754.
::timeout Dispose after some time.
::backoff Dispose after a time period which prolongs with repeated access.
::lru Cache a finite set of recent values.
::async Wait for a channel before disposing.

We don't avoid complex behavior, but at least now we've named it.
This makes re-frame more practical, especially for power users.
This makes re-frame more articulate, especially for new users.
We educate the user on what to use when and why.
We provide a default that's safe & easy to explain.
We stop saying "caching makes re-frame performant!"
We start saying "re-frame supports an open set of performance strategies!"
Crucially, this means we provide a clean API for the user to define their own lifecycle:

strategy Names the lifecycle used by a given query.
method The registered implementation for a strategy.
query-id First in a vector, or the val for the strategy in a map.
handle Call the handler for a query.
cache Supercedes query->reaction with strategy->query->reaction.
cache! Given a strategy and a query, allocate the handler.
clear! Given a strategy and a query, free the handler.
reg-sub-method Implement the lifecycle. Support either vector or map queries with 2 arities.

We use metadata to colocate lifecycle and query (best-effort).
We support map queries, where lifecycle is a key (true colocation).
Signal and computation fns are unchanged, except the first item in query-v may be a map query. Putting the query in the query isn't the simplest, but it makes the system very backwards-compatible.
I agree that destructuring the query-id is rarely necessary.
The new query-id destructures it just as well.
Queries are concise because lifecycle is a key, not a val.
Each lifecycle strategy has its own cache. This may waste some space, but it makes the system very reasonable & future-proof.
Thanks for coming to my ted talk.
Please let me know if I've missed anything big.

I made a second prototype: https://github.com/day8/re-frame/pull/790/commits/64cb7892f006adb6d945f72d751ff2b22d5a5738
I think breaking the API at a different point makes it simpler overall.
Query-maps are simpler. No more looking up the "first" registered key to find lifecycle and id.
Instead, a query-map has ::rf/q and (optional) ::rf/lifecycle keys.
A query-vector is used as-is. No more putting a query-map inside the query-vector.
Instead, there are two different ways to register a subscription:

reg :sub accepts a query-map.
If you sub to a query-vector, it's converted to a query-map.
reg :legacy-sub is the same as the original reg-sub.
If you sub to a query-map, it's converted to a query-vector.
Use ::rf/query-v to pass positional args in the query-vector.

Sub handlers always know the lifecycle of the query. No more exceptions.
Registering a lifecycle is simpler. No more arities. Now it can handle map or vector queries naively.

I've updated a few articles to explain more clearly the problem with subscriptions, and why they're a leaky abstraction of dataflow programming.

FAQ: How can I use a subscription in an Event Handler?
Flows: Reactive Context


Pull in test fixes and API changes to 1.0 branch.

Merge PR, CLA ok.

Note we're not quite done. Of course. :/


New package: LLVM.ClangFormat version 18.1.6

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hello @PolarGoose,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.
Template: msftbot/validationError/installation/general

I don't see what exactly went wrong. I have checked that the package can be installed with the command winget install --manifest LLVM.ClangFormat.yaml

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-21 22:28:54.759 [FAIL] Installer failed security check. Url: https://github.com/PolarGoose/clang-format-for-Windows/releases/download/18.1.6/clang-format.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 881.)

@wingetbot run

Hello @PolarGoose,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.
Template: msftbot/validationError/installation/general

I don't see the reason why the installation failed. It works on my machine.

Hi @PolarGoose,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 881.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-22 19:17:14.951 [FAIL] Installer failed security check. Url: https://github.com/PolarGoose/clang-format-for-Windows/releases/download/18.1.6/clang-format.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 881.)

@wingetbot run

Hi @PolarGoose,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 881.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-23 13:31:17.711 [FAIL] Installer failed security check. Url: https://github.com/PolarGoose/clang-format-for-Windows/releases/download/18.1.6/clang-format.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 881.)

Hi @PolarGoose,
The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.
(Automated response - build 881.)

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-05-28 08:20:57.670 [FAIL] Installer failed security check. Url: https://github.com/PolarGoose/clang-format-for-Windows/releases/download/18.1.6/clang-format.zip Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 881.)

@wingetbot run

Verify:


Error sometimes when creating project

Sometimes (I think about 40% of the time) I get an error when I get redirected to the project page after creating a new project:

I think it's just a race condition: the hg repository isn't necessarily ready when the project page asks for the repo change-sets.
Here's the trace: https://ui.honeycomb.io/sil-language-forge/environments/test/trace/5f7iwR6T2AT?fields[]=c_name&fields[]=c_service.name&span=20635f6224b0e3d9
And part of the HG web error: mercurial.templateutil.TemplateNotFound: "notfound" not in template map

I wrote an API test to try and reproduce this issue locally but was unable to reproduce it. I'm going to try the test against staging.

After taking a look at #214 I dug into the mercurial source code. It looks like this is the function that controls the refresh. It looks like there's no way to force it, and no other way to notify it of a repo being added. I think our best bet here will just to be resilient of errors for newly created repos. Maybe we try to get the change log, but if the project is not 1 minute old then we ignore any errors we get from hgweb and just return an empty list.

As disussed with @hahn-kev:
We decided that we're just going to try to avoid accessing Hg repos shortly after they've been created.
There are 2 reasons for this:

HgWeb has a refreshinterval (20s by default). Unless we reduce the interval to 0, there's always the chance that a repo won't be immediately available after being created.
Repos appear to be unstable for a short time after they've been created. We observed initially getting 200's, but then shortly after get 404's for a while. It's as if Hg does something with the new repo making it temporarily unavailable.


new release: Claiming app with investor support

Added

#561

Fixed

#448
#449

Chore

#552
#556
#558
#560

All good, gracias!


Could not find com.github.afollestad.material-dialogs:core:<IP_ADDRESS>.

Hi, i keep getting the following error when i add the library.
Error:Could not find com.github.afollestad.material-dialogs:core:<IP_ADDRESS>.

repositories {
    maven {
        url 'https://jitpack.io'
    }
    mavenCentral()
}

And added this as a dependency:
compile('com.github.afollestad.material-dialogs:core:<IP_ADDRESS>@aar') {
    transitive = true
}

This is a duplicate of closed issues, I'm sure. But there's not much I can do.
It's available on JitPack (https://jitpack.io/#com.afollestad/material-dialogs) and that's the correct repo information.

Hi,
you mentioned the correct repo information here
https://jitpack.io/#com.afollestad/material-dialogs/<IP_ADDRESS>
But it gives error below
Error:Could not find material-dialogs.aar (com.afollestad:material-dialogs:<IP_ADDRESS>).
Searched in the following locations:
https://jitpack.io/com/afollestad/material-dialogs/<IP_ADDRESS>/material-dialogs-<IP_ADDRESS>.aar
Did someone manage to add the library ?

same question.

It seems like <IP_ADDRESS> is missing from Jitpack? Opening https://jitpack.io/com/afollestad/material-dialogs/core/<IP_ADDRESS>/ results in 404 for instance.

Builds can't be removed completely from.JitPack, if you request it from Gradle it will be built again if it was removed.

Also, you should use https://jitpack.io/afollestad/material-dialogs/core/<IP_ADDRESS> instead

Anyone still having issues, see this response from JitPack: https://github.com/jitpack/jitpack.io/issues/318
I will be updating the project REAMDE also.

compile 'com.afollestad.material-dialogs:core:<IP_ADDRESS>'

compile 'com.afollestad.material-dialogs:core:<IP_ADDRESS>'
compile 'com.afollestad.material-dialogs:commons:<IP_ADDRESS>'


Support for :second when recorded_at is :utc_datetime

I've already update the README, I also think it's the solution, but in any case.

Can you review my changes please?


Revert "Adds type checking for torque symbolizers"

@rochoa @CartoDB/frontend
Reverts CartoDB/cartodb#4009

Frontend tests were OK :+1: (details)


Support for conversation fields and tags

Thanks for this very useful wrapper!
Question: do you plan to add support for conversation fields and tags in the near future? Cf. the iOS and Android SDK documentation.

Hi, @fikkatra.
Thank you for share new features.
I will start develop soon for support conversation fields and tags.
You can tracking task status here :)

Notes
Conversation fields and tags supported SDK version: 2.13.0

Hi, @fikkatra.
Conversation fields and tags are now available on 0.2.0. please check it out :)


🔄 Synced file(s) with jhudsl/OTTR_Template

Synced local file(s) with jhudsl/OTTR_Template.

Changed files

Synced local directory .github/workflows/ with remote directory .github/workflows/Synced local directory style-sets with remote directory style-setsSynced local  config_automation.yml with remote  config_automation.yml

This PR was created automatically by the repo-file-sync-action workflow run #12282586438

Please carefully review these changes and decide which are useful for your course.
See the release notes: https://github.com/jhudsl/OTTR_Template/releases

If you don't want the changes from a particular file, you can always revert that particular commit before merging the sync PR.
If you will not want any updates on this file in the future, you may want to remove a file from being synced in your repo by reconfiguring the sync file.

If you want only some changes, but they are not on a whole file basis, you could check out the branch and make manual edits. To checkout the branch, navigate to your own repository you should be able to run:

git checkout repo-sync/OTTR_Template/default

If you don't want any of the changes you can close the PR entirely.

You may want to unenroll your repository from the sync GitHub actions by filing a PR on OTTR_Template
to delete your repo name from this file if this will continue to be the case.


Create asu.txt

@nguyenhungvn94 I am sorry, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


OpenApiDiagnostic error when key contains square brackets for components

If a V2 json generated using swashbuckle contains square brackets in the key of the #definitions, OpenApiDiagnostics throw below error. Is there a reason why square brackets are not allowed? This validation is blocking one of the internal tool that consumes OpenApi.Net
Message:"The key 'Core.Collections.ResourceCollection[Services.Products.V2.Models.Availability]' in 'schemas' of components MUST match the regular expression '^[a-zA-Z0-9\.\-_]+$'."
Pointer: "#/components"
RuleName: "KeyMustBeRegularExpression"
Sample Json which is failing OpenApi.NET validation but renders fine in swagger editor:
{
"swagger": "2.0",
"info": {
"version": "v1",
"title": "TestService",
"description": "Test service"
},
"host": "test.net",
"basePath": "/test/WebApiV2",
"schemes": [ "https" ],
"paths": {
"/v1/products/{productId}/skus/{skuId}/availabilities": {
"get": {
"tags": [ "Availability" ],
"operationId": "Get /v1/products/{productId}/skus/{skuId}/availabilities?country={country_value}&targetSegment={targetSegment_value}",
"consumes": [],
"produces": [ "application/json", "text/json", "application/xml", "text/xml" ],
"parameters": [
{
"name": "productId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "skuId",
"in": "path",
"required": true,
"type": "string"
},
{
"name": "country",
"in": "query",
"required": false,
"type": "string"
},
{
"name": "targetSegment",
"in": "query",
"required": false,
"type": "string"
},
{
"name": "Authorization",
"in": "header",
"description": "Authorization Bearer token",
"required": true,
"type": "string",
"default": "Bearer "
}
],
"responses": {
"200": {
"description": "The request was successful. The availabilities are returned in the response body.",
"schema": { "$ref": "#/definitions/Core.Collections.ResourceCollection[Services.Products.V2.Models.Availability]" }
}
}
}
}
},
"definitions": {
"Core.Collections.ResourceCollection[Services.Products.V2.Models.Availability]": {
"type": "object",
"properties": {
"totalCount": {
"format": "int32",
"type": "integer",
"readOnly": true
}
}
}
},
"securityDefinitions": {
"Authorization": {
"type": "apiKey",
"description": "Authorization Bearer token",
"name": "Authorization",
"in": "header"
}
}
}

I'm not sure what the best approach here is.  Square brackets are not allowed in OpenAPI V3 component names.  We really need to translate any invalid component names into something valid.  For example we could translate any invalid character to a -.  This does mean that round tripping wouldn't be exact.

See #198.
An alternative we have is to provide rulesets for different Vs of the document.


No way to close a TcpStream after bind_client

This code will keep the connection open forever, even though the client is immediately dropped, and there is no way to send any data.
    let addr = "<IP_ADDRESS>:12345".parse()?;
    let listener = TcpListener::bind(&addr, &handle)?;
    let server = listener.incoming().for_each(|(tcp, _)| {

        let client = LineProto.bind_client(&handle, tcp);

        Ok(())
    });
    core.run(server)?;

This should be fixed by #195


Texlive test fails

The help/test-texlive-bin.sh test fails to finish:

@padjal did you run make install successfully on your machine?

@yegor256 make install also doesn't finish without errors:

@padjal either install Java on your machine or try to use Docker, as explained in README

What is the recommended way to install tlmgr?

@padjal try it one more time, we updates installation scripts. Do sudo make install

Seems like you have fixed this issue. Can be closed.


Social link redirection on same page

There is an issue for Telegram, Discord and YouTube social link redirection. Others are opening in new tab but these three are opening in current tab itself

I would like to work on this issue.

Hey, just wanted to know, do we have to ask things like these, before pulling request ??
I am new here, so just wanted to know, like cannot you just solve this thing and issue a pull request directly ??

@prabhxjottsingh  It is better to inform the folks here so that duplicate PR's are avoided

@SiddhantKhisty Oh okay got it, thanks

@mrunankpawar, @kunal-kushwaha  I would like to work on it

Hey I would like to work on this issue #166 because I beginner so I want to start with easy. can you assign me this @kunal-kushwaha , @kaiwalyakoparkar

Hi @kunal-kushwaha and @kaiwalyakoparkar, Please assign it to me and I will work on this issue. I will add one more thing which will be beneficial to redirect to secure official website and not vulnerable after opening in new tab.
Thanks!


Add a global stats::random_engine_t.

This commit enables setting an explicit random number seed globally.  This is useful when using the vectorized wrappers which do not otherwise support setting a seed.  This commit is tested only with Blaze.
There are many possible ways add support for seeding the vector wrappers, and this pattern seemed the simplest to me.  It is not the first pattern attempted.  I do not really expect you to merge this as is, but maybe just think about and describe the correct, idiomatic way to possibly support this feature.  I don't mind actually doing the work on it, if you give me the guidance of how you want it done.  It would also be better if all the distributions were ported to the favored pattern; this commit only experimented with rnorm and rinvwish.

It is also not clear to me yet how to best fix this for thread safety.   Maybe it is sensible to change static rand_engine_t to thread_local rand_engine_t, but this would require users to understand those semantics.

vectorized wrappers which do not otherwise support setting a seed

Fixed in version 3.3.0.


Org support

In addition to per-repo statistics, it would be useful to plot stats at the per-org level.  In other words, plot stats for https://github.com/apache and not just for one of its repos.

Hi @lemmy - I might add this if you submit a PR, but otherwise I'm not going to add this.

Fair enough, but, unfortunately, I don't have the capacity.


[FIF-189] Add indexes to speed up queries to surveysummaryanswers

I won't say that you must change it. But from my perspective, I would like better to see the 2 SQL files, instead of the scripts as you have it, in the JS file.
Fewer files, that may be a positive thing, but I feel we lose some organization and maintainability.


[Not a bug] - Why bs and sb-admin-2 css in single file?

I'm used to see bs and admin css files separated. That's why we import these css files separately or we could be using cdn.
As you can see sb-admin-2.css contains also bs css. Nowadays i see bs with custom styles in a single merged file. AdminLTE also does the same.
Why?

Most likely? That CSS file is built from this template's Sass file, here: https://github.com/BlackrockDigital/startbootstrap-sb-admin-2/blob/master/scss/sb-admin-2.scss
If you inspect that file, at line 2 you'll see this:
@import "variables.scss";

followed by this at line 5:
@import "../vendor/bootstrap/scss/bootstrap.scss";

Line 5 pulls in Bootstrap's Sass file, so the generated CSS file is also going to include Bootstrap. The variables.scss file contains overrides for some of Bootstrap's variables, which is easier than trying to add overriding rules in a normal CSS file (and is actually the method recommended by the Bootstrap team).

@tiesont thanks! i got it now. It's related to how b4's recommended way of theming.


Forge version for 1.18.2 perhaps?

Architectury already exists for 1.18.2 but no faster ladder mod like this one exists for Forge on that version.

Done 2.2-1.18-forge


Add script to install challenge repos

Closes #5
Summary

Converted install.js script from speedrun-grader to typescript
Added challenges.json with github property pointing at https://github.com/BuidlGuidl/eth-tech-tree-challenges.git
Updated README with yarn install:challenges step

I will let you address the tsx vs ts-node issues in you other PR as well before reviewing that one. Let me know if tsx is not working for you. It should have nodemon type "watch" functionality. I am new to tsx though so we may encounter some issues.

@escottalexander thanks for the review and tsx tip :pray:
I'm gunna close this PR so i can make the changes all in one PR instead, which should be easier for you to review and easier for me to continue progress


Themesongs Installed, No playback

I have installed themesongs (<IP_ADDRESS>).
It has downloaded the files to the corresponding folders. (theme.mp3)
Does this NOT auto play the theme songs when i click into the tv series folder ?
The documentation is very vague, I can not see anywhere in any documentation stating if it does or not ?
( if it does not auto play back, can you update Github advising, as i do see on other forums alot of other people asking the same question)
Never mind, you have to go into User=> Settings => Display, and set playback,So this is only enabled on a per user basis, not a global configuration.
You can close this issue, sorry for the inconvenience.

I have this enabled, but still no audio plays


Bug with signature verification with Mastodon

There seems to be something wrong with the signature verification when sending to Mastodon. It seems like Mastodon is fetching the keys OK, but maybe there's something else going on.

So, it turns out that delivery by POST to a Mastodon server requires a signed Digest: header with SHA-256 algorithm. Thank you, code review!


New play - Keeper App

Description
I have added the new play named Keeper. This is the clone of Google Keep where we can add and delete our notes. This "Keeper app" save your notes until you delete them.
How Has This Been Tested?

Install some martial UI dependencies for testing styling -
emotion/react
emotion/styled
material-ui/core
material-ui/icons
mui/icons-material
mui/material

Start the app by npm start or yarn start to see it.

Checklist:

[x] I have performed a self-review of my code
[x] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

App Preview(ScreenShots)

There's an issue with the navbar. It's outside the window.

@atapas Thanks for pointing out these issues, I will remove that all, to make it all good.

Hello @Shivam-Katare
We have upgraded to React v18 as part of this issue: https://github.com/atapas/react-play/issues/87
We have tested the existing plays. All good. Please pull this change to your branch and keep it up-to-date. You have to do sanity of things to make sure everything works for your changes in your branch.
Happy Coding!

@Shivam-Katare Once you done, please remove the work-in-progress label and review-ready label so that we can start the review.

@atapas The Vercel deployment has failed, but could you please tell me where's the problem? What I am doing wrong? because the code and everything all works fine.

Hey, @atapas  I removed almost all issues you can now review it again, and if you still have found some issues then, you can update me I will try to remove them too.

Hey, @atapas I removed almost all issues you can now review it again, and if you still have found some issues then, you can update me I will try to remove them too.

I just had a glance at it. Much much improved. Thanks, @Shivam-Katare

I have a few comments
And I think the play related dependencies can be managed locally(got an idea)

Do you have some time tomorrow morning or afternoon to get on a call with me to make those changes live and get the PR merged? Let me know.

Yes, Sure. The morning will be good, any time which will you decide.

Yes, Sure. The morning will be good, any time which will you decide.

9am schedule.

Yes, Sure. The morning will be good, any time which will you decide.

9am schedule.

Done.

@atapas I made the "Hooks" folder and write custom hooks also. The app works perfectly fine locally(in localhost) but, after pushing changes it shows the conflict, and when I try to resolve conflict through the "git merge tool" then, it shows "No files need merging". So, please tell me where the problem happens.

@atapas I made the "Hooks" folder and write custom hooks also. The app works perfectly fine locally(in localhost) but, after pushing changes it shows the conflict, and when I try to resolve conflict through the "git merge tool" then, it shows "No files need merging". So, please tell me where the problem happens.

I see these files are in conflict. So you need to resolve. Maybe using the GitBash of GitHub editor?

Hey, @atapas all conversations are resolved.

Hey, @atapas all conversations are resolved.

Please resolve merge conflicts.

@atapas merge conflicts resolved.

Hey, @atapas I resolved all conflicts and conversations, you can review it once, and, please let me know if there is an issue anywhere in it.

Hey, @atapas all conversations are resolved.

@Shivam-Katare Take care plz, build fails

Hey, @atapas all conversations are resolved.

@Shivam-Katare Take care plz, build fails

Hey, @atapas I removed the duplicate "States" and other duplicate plays, is it still gives "build fails message"?

Hey, @atapas all conversations are resolved.

@Shivam-Katare Take care plz, build fails

Hey, @atapas I removed the duplicate "States" and other duplicate plays, is it still gives "build fails message"?

@Shivam-Katare Build is successful but 3 comments are pending.

@atapas all conversations resolved, you can check it now.

@Shivam-Katare All good..
Do you want to make the cover image a bit better? It looks stretched. Maybe do not make a transparent image, give it a background using Canva? Let me know if you need help?

@atapas Cover image changed.

Also in the responsive mode the note list can be aligned better

Responsiveness added for keeper play.

Also in the responsive mode the note list can be aligned better

Responsiveness added for keeper play.

Looks good tested.

@Shivam-Katare This is good to merge. Tested. You just need to take care of removing package lock json file from commit.

@Shivam-Katare This is good to merge. Tested. You just need to take care of removing package lock json file from commit.

@atapas Shall I put "package-lock.json" in git ignore?

@Shivam-Katare This is good to merge. Tested. You just need to take care of removing package lock json file from commit.

@atapas Shall I put "package-lock.json" in git ignore?

It is already in .gitignore
https://github.com/atapas/react-play/blob/main/.gitignore

@Shivam-Katare This is good to merge. Tested. You just need to take care of removing package lock json file from commit.

@atapas Shall I put "package-lock.json" in git ignore?

It is already in .gitignore
https://github.com/atapas/react-play/blob/main/.gitignore

You can do git rm  and commit, push..
Btw, I have captured this case in the Merge Conflict video I published today 😂

@Shivam-Katare This is good to merge. Tested. You just need to take care of removing package lock json file from commit.

@atapas Shall I put "package-lock.json" in git ignore?

It is already in .gitignore
https://github.com/atapas/react-play/blob/main/.gitignore

You can do git rm and commit, push..
Btw, I have captured this case in the Merge Conflict video I published today 😂

@atapas Yes, I have seen the video 😀and, removed package lock.json. You can now check it.

@all-contributors please add @Shivam-Katare  for Code


Add tasks

Basic task class, and addtask command have been implemented along with some very basic tests. The command updates the model under the hood but the user is presently only able to view a "task successfully added" message with some information, and not the list of tasks itself.

Codecov Report

Merging #21 (e9fbd93) into master (b07b394) will decrease coverage by 0.27%.
The diff coverage is 68.18%.

@@             Coverage Diff              @@
##             master      #21      +/-   ##
============================================
- Coverage     72.15%   71.87%   -0.28%
- Complexity      399      418      +19
============================================
  Files            70       74       +4
  Lines          1232     1298      +66
  Branches        125      133       +8
============================================
+ Hits            889      933      +44
- Misses          311      325      +14
- Partials         32       40       +8

Impacted Files
Coverage Δ

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

src/main/java/seedu/address/model/UserPrefs.java
80.00% <ø> (ø)

...rc/main/java/seedu/address/model/ModelManager.java
96.00% <33.33%> (-4.00%)
:arrow_down:

src/main/java/seedu/address/model/task/Task.java
45.83% <45.83%> (ø)

...c/main/java/seedu/address/model/task/TaskList.java
60.00% <60.00%> (ø)

...a/seedu/address/logic/commands/AddTaskCommand.java
80.00% <80.00%> (ø)

...edu/address/logic/parser/AddTaskCommandParser.java
90.90% <90.90%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
87.50% <100.00%> (+4.16%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
97.82% <100.00%> (+0.60%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07b394...e9fbd93. Read the comment docs.

made changes in line with chi sern's suggestions


Negative inflight messages counter

Python 3.9, Windows 10
aiomqtt           1.2.1
paho-mqtt         1.6.1
The client._client._inflight_messages counter of the paho client is negative and decreasing with QoS 2 for publish and subscribe on the same topic. Other combinations of the QoS levels will not show the issue.
The log seems to indicate that the published messages are transfered successfully:
DEBUG:__main__:Sending PUBLISH (d0, q2, r0, m6), 'b'test'', ... (1 bytes)
DEBUG:__main__:Received PUBREC (Mid: 6)
DEBUG:__main__:Sending PUBREL (Mid: 6)
DEBUG:__main__:Received PUBCOMP (Mid: 6)
DEBUG:__main__:Received PUBLISH (d0, q2, r0, m5), 'test', ...  (1 bytes)
DEBUG:__main__:Sending PUBREC (Mid: 5)
DEBUG:__main__:Received PUBREL (Mid: 5)
DEBUG:__main__:Sending PUBCOMP (Mid: 5)
DEBUG:__main__:received payload 4, mid: 5
DEBUG:__main__: _out_messages 0, _in_messages 0, _inflight_messages -5

Here is a MCVE
import asyncio
import sys
import aiomqtt
import os

#Change to the "Selector" event loop if platform is Windows
if sys.platform.lower() == "win32" or os.name.lower() == "nt":
    from asyncio import set_event_loop_policy, WindowsSelectorEventLoopPolicy
    set_event_loop_policy(WindowsSelectorEventLoopPolicy())

import logging

logging.basicConfig(
    level=logging.DEBUG,
    stream=sys.stdout,
)
logger = logging.getLogger(__name__)

MQTT_TOPIC = "test"
MQTT_PUBLISH_QOS = 2
MQTT_SUBSCRIBE_QOS = 2

async def publisher(client):

    n = 0

    while True:

        await client.publish(MQTT_TOPIC, n, MQTT_PUBLISH_QOS)
        n += 1

        await asyncio.sleep(1.0)

async def main():

    background_tasks = set()

    client = aiomqtt.Client(
        hostname="localhost",
        client_id="client",
        max_inflight_messages=20,
        max_queued_messages=0,
        keepalive=5,
        logger=logger
    )

    async with client:

        task = asyncio.create_task(publisher(client))
        background_tasks.add(task)
        task.add_done_callback(background_tasks.discard)

        async with client.messages() as messages:

            await client.subscribe(MQTT_TOPIC, MQTT_SUBSCRIBE_QOS)

            async for message in messages:

                if message.topic.matches(MQTT_TOPIC):

                    n = int(message.payload.decode("utf-8"))

                    logger.debug(f"received payload {n}, mid: {message.mid}")

                    logger.debug(f" _out_messages {len(client._client._out_messages)}, _in_messages {len(client._client._in_messages)}, _inflight_messages {client._client._inflight_messages}")

if __name__ == "__main__":

    try:
        asyncio.run(main())

    except KeyboardInterrupt:
        sys.exit(0)

Hi there,
Thanks for this issue and sorry for the late reply! Let's try to get to the bottom of this 👍
As far as I know, aiomqtt doesn't touch the _inflight_messages counter. The only time we're doing something related is when we set paho-mqtt's limit on inflight messages with max_inflight_messages_set(). Did you already try to reproduce a negative counter using paho-mqtt directly?
paho-mqtt decrements the _inflight_messages counter in two places:

https://github.com/eclipse/paho.mqtt.python/blob/master/src/paho/mqtt/client.py#L1730
https://github.com/eclipse/paho.mqtt.python/blob/master/src/paho/mqtt/client.py#L4330

Thanks for reporting back!


Understand and prevent version mismatches

https://semver.org/
See specifically these points:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.
Patch version Z (x.y.Z | x > 0) MUST be incremented if only backward compatible bug fixes are introduced. A bug fix is defined as an internal change that fixes incorrect behavior.
Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.
Major version X (X.y.z | X > 0) MUST be incremented if any backward incompatible changes are introduced to the public API. It MAY also include minor and patch level changes. Patch and minor versions MUST be reset to 0 when major version is incremented.


Minor DateTime intro doc update

• Put timezone in the lede since it's critical.
• Mention Instant and SystemTime to put DateTime in context

Thank you!


unittest vs. pytest

In the pythonapp.yml pytest is stated
    - name: Test with pytest
      run: |
        pip install pytest
        pytest

while unittest is used

I fixed this in https://github.com/HolmesNL/lir/pull/8 but don't know if this fix is intended

I fixed this in #8 but don't know if this fix is intended

Wel the fix was intended, but I don't know if that is the intended way to go :)

I've closed my PR, but i think this issue remains. What should it be?

Currently pytest is used to collect tests; the tests themselves are unittest. Does it need to be changed or close the issue?

Not sure what to do with this; close for now


change all error values in store to be Error objects (fix #15)

It works out well because you can still use error.message. I think this is really just a patch release, but I think this will be 4.1.0 just because it's a significantish change.

build & tests pass for d52cdc9fcb499e47084b73b0ca86824d3d9c914f

@hallettj Could you look through the code to see if there are more spots that should be changed that you notice (any time you get a chance)?


Remove IAR from all NRF51822-based targets

Removes IAR support from all NRF51822-based targets.
Currently tests do not run on NRF51822 targets when compiled with IAR. The current definition of the NRF51_DK target specifically removes IAR support in its definition. This PR unifies this removal across all of these targets.

Test does not run mean ? Please provide more details.
We should create a tracking issue for this, I consider this to be revert this until we fix it.

All tests fail to compile meaning the IAR support doesn't work at all.

The tests actually compile just fine (Sorry Sam, must have misspoke yesterday). They don't run though (no serial output from the tests)

@bridadan Please create a tracking issue for this, shall be fixed.


⚠ Jenkins Plugins Artifactory has degraded performance

In 9cd88c7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1202 ms

Resolved: Jenkins Plugins Artifactory performance has improved in b76887d after 42 minutes.