Add BasePrimitiveOptions

Summary
Based on https://github.com/Qiskit/RFCs/blob/c5d6ac069b50f6dc21f7715df8d1c5c2fede75e7/0018-primitive-options-type.md and https://github.com/Qiskit/qiskit/pull/11227#discussion_r1407939970.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 87.587%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
59664

Relevant Lines:
68120

💛  - Coveralls

Do we need a constructor such as BasePrimitiveOptions(foo=1, bar="bar")?

Do we need BasePrimitiveOptionLike as #11227 has?

Do we need a constructor such as BasePrimitiveOptions(foo=1, bar="bar")?

Since this is a base class, I assume it has no properties. Is the default constructor not sufficient?

Do we need BasePrimitiveOptionLike as https://github.com/Qiskit/qiskit/pull/11227 has?

Do you want it for the reference implementation of SamplerV2? If so, I'll add it.

OK, but I am suggesting this simply because it is needed in the Statevector primitives (both estimator and sampler). But, it is not large, so if you want to copy and paste and implement it in each instead of inheriting it, that is fine.


Add basic blog template

You mean an archetype in hugo "language"?

@Issif No, this is not a Hugo archetype. This is a set of HTML templates.

This looks very good! Thanks Luc!
My only thing is that I think we want to remove the page date from the blog post list.
It was intentional?

@leodido @fntlnz Honestly, I don't think I've ever seen a blog that doesn't display the publish date of posts. I can remove it from the post list on /blog but I think it's important to retain it in the posts themselves.

@leodido @fntlnz Oh wait, I see what you mean now. Weird. I actually don't know why it's doing that but I'll fix.


Why is MiscExtensions an extension on String? and not on String

Not so much a feature request, more a design question to satisfy my curiosity. If something can be done about it, all the better!
This code gives an error that "A value of type 'String?' can't be assigned to a variable of type 'String'". IMHO this should be the ideal way to use the extension properties.
String foo = "foo".capitalize;

Instead we are forced to use a ! if we know the initial string to not be null.
String foo = "foo".capitalize!;

I understand that the advantage of the current approach is so we can easily work with nullable strings like this.
String? bar = maybe ? "not-null" : null;
String? biz = bar.capitalize;

However it seems more appropriate to force the usage of the ? operator where things might be null instead of forcing the ! operator where we know they aren't null, like so.
String foo = "foo".capitalize; // Should be good
String? biz = bar?.capitalize; // Should be good. Forcing ? is appropriate since bar may be null

String foo = "foo".capitalize!; // Should be bad. "foo" is known to not be null, so .capitalize should be the same
String? biz = bar.capitalize; // Should be bad. bar may be null so it shouldn't have a .capitalize property. use ?.capitalize instead

I know changing it would break backwards compatibility, so I'm not requesting it be changed, but if I'm missing something and the current approach was chosen for some other benefit I'm not aware of, I'd love to learn what that is (I'm kind of new to dart and exploring its mechanisms). Maybe there can be two extension classes, one on String and the other on String? to keep backwards compatibility? (The latter could easily be implemented in terms of the former, though importing both may cause name collisions)

Hello there @abrahammurciano !
Thanks for your message and the valid points you raised. This is something I've been thinking it aswell and since I see other users have similar issue, I've decided to extend the library to include both String and String?. This way, you'll have the flexibility to use .capitalize directly on non-nullable strings without needing the ! operator, while still handling nullable strings gracefully and of course not breaking current projects.
I've also considered the potential impact on the size of the library. Fortunately, thanks to Dart's tree shaking and the minimal nature of the changes, the increase in size should be negligible.
Appreciate your input, and stay tuned for the update!


Fixed #25556 - added DatePart and DateTimePart expressions

This PR addresses the lacking functionality of: QuerySet filtering by matching the year/month/day part of two separate date fields.
The PR adds DatePart and DateTimePart db lookup expressions (to django.db.models.expressions),
enabling complex lookups on certain lookup elements of Date(Time) fields. Namely: year, month, day.
Makes the following query possible:
MyModel.objects.filter(date1__month=DatePart('date2', 'month'))
which returns only objects where date1 and date2 fields have the same month.

Hi @ryuusenshi, were you planning on doing this for django 1.10? Is there anyway I can help?

Hi, @jarshwah. Yes, I will be working on this in the upcoming days (most likely on Wednesday).  Maybe I could find you on the IRC channel?

I'm actually out of town still, so my net usage is kind of flakey. I'll be
back in the weekend. There may be others on irc or the mail list that can
help. Otherwise I'm checking this email fairly regularly.
On Mon, 9 Nov 2015 at 23:32, David Filipovic<EMAIL_ADDRESS>wrote:

Hi, @jarshwah https://github.com/jarshwah. Yes, I will be working on
this in the upcoming days (most likely on Wednesday).  Maybe I could find you on the IRC channel?
—
Reply to this email directly or view it on GitHub
https://github.com/django/django/pull/5431#issuecomment-155219973.


saml_session cookie does not set same site flag

The README refers to the session cookie as a SameSite cookie but the implementation does not actually set the SameSite flag on the cookie which leaves the value up to the browser. Shouldn't the saml session cookie also use the SESSION_COOKIE_SAMESITE value from Django settings to tell the browser which SameSite setting to use?

Hi @RouganStriker
For samesite cookie we have an additional cookie, designed specifically for SSO that have a SameSite flag set to none, that's not the default django one.
you can find it here:
https://github.com/knaperek/djangosaml2/blob/master/djangosaml2/middleware.py
let me know If I miss something or any misunderstanding of mine
feel free to close this issue if you got the right answer

Yup, I see that for SSO we are creating a separate cookie that uses the same domain, path, secure, and http only flags as the Django session cookie. But the same SameSite value used for the Django session cookie isn't being for the SSO session cookie. Was there a reason it as explicitly set to None?

Yes, because a cross domain post (SLO) with a samesite cookie = none, will be posted also to the idp (different domain). Otherwise the IdP won't detect the user session and SLO fails

Sorry I'm not very familiar with this particular use case. Why does the SP and IdP need to share a session cookie? I thought in the SLO scenario the user session/identifier is sent to the IdP as part of the Logout Request.
For a bit of context, I am trying looking at this from a security perspective to understand if there are any concerns with this SAML session cookie lacking the CSRF protection of the SameSite flag.

they doesn't need to share that.
when you come back to the IDP this latter would also check if you've a real session (based on the cookie it have issues to you after auth).
Putting a cookie will enforce SLO security. SameSite cookie prevent that a cookie would reach is issues during a cross domain
HTTP POST

To make sure I am understanding this correctly, the SAML session cookie has the SameSite flag disabled to handle the case where the cookie needs to be accessed by the IdP during a SLO POST request?

Yes
Il gio 18 feb 2021, 02:18 Kelvin Chan<EMAIL_ADDRESS>ha scritto:

To make sure I am understanding this correctly, the SAML session cookie
has the SameSite flag disabled to handle the case where the cookie needs to
be accessed by the IdP during a SLO POST request?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/knaperek/djangosaml2/issues/243#issuecomment-780966750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJ4ZVEZOVIYHUGVIEMGCSTS7RTGDANCNFSM4XBG357Q
.


tf.io.write_file not working in tf.function decorated function

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.2 and Windows 10
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0.0-beta1
Python version: 3.7

Describe the current behavior
tf.io.write_file creates file in eager execution but produces no output file when decorated with @tf.function.
Describe the expected behavior
tf.io.write_file should create an output file whether or not being decorated with @tf.function.
Code to reproduce the issue
import tensorflow as tf

@tf.function
def writeJPEG_graph(img_decoded, filename):
    out = tf.cast(img_decoded, tf.uint8)
    out = tf.image.encode_jpeg(out, quality=100)
    tf.io.write_file(filename, out)

def writeJPEG_eager(img_decoded, filename):
    out = tf.cast(img_decoded, tf.uint8)
    out = tf.image.encode_jpeg(out, quality=100)
    tf.io.write_file(filename, out)

img = tf.fill([256,256,3], 127) # example gray image
writeJPEG_graph(img, "./tfwrite_graph.jpg") # "tfwrite_graph.jpg" not created
writeJPEG_eager(img, "./tfwrite_eager.jpg") # "tfwrite_eager.jpg" created

I have tried on colab with TF version 2.0 beta1 and was able to reproduce the issue.Thanks!

This also happens in 1.14, and sadly inhibits visualizing images augmented in tf.data.Dataset pipelines (since they are run as a Graph)

Unfortunately the fix didn't make it into the 1.14 release, and will only be available in 2.0.
In 1.14, write_file should still be usable using the old-style tf.control_dependencies.


Create an intro

Add an intro about yourself: who are you, what is your strength, why are you here.

Avoid using prettier, because it converts DOCTYPE to lowercase


Service Providers must have at least one AssertionConsumerService

We should be validating that at least one ACS is active, otherwise the invalid SP will break metadata generation.

Hi, just giving you a "+1" (or "me too") on this one.
One of our subscribers just broke our (TEST) metadata generation by disabling all AssertionConsumerService endpoints on their SP.  And the metadata signing processes caught that as a validation error.
I've just checked the SAML 2.0 spec and AssertionConsumerService has the (default) minOccurs=1.
So, there is no option to render an SPSSODescriptor without an AssertionConsumerService.  And, there is also no option to render an EntityDescriptor with no RoleDescriptor (again, default minOccurs=1).
So the SPSSODescriptor would have to be considered not functioning it it has no assertion consumer service - and the EntityDescriptor would have to be considered not functioning if it has no functioning role descriptor.
Would you welcome a Pull Request fixing this ?  For the time before everything migrates onto the SAML service?
Cheers,
Vlad

Certainly happy to look at a PR that resolves this one @vladimir-mencl-eresearch

Hi @bradleybeddoes  (and @smangelsdorf )
I'm now working on this - and I have two different solutions.
One I started with was to introduce a new method 'complete()to the domain model for all RoleDescriptors (IdPSSO,SPSSO,AA,PDP).  The method (similar to EntityDescriptor.empty() ) would return true if it finds at least onefunctioning() singleSignOnServices/assertionConsumerServices/attributeService/ authzServices` instances (as per the requirements of the specific role descriptor.
Then I realized this had already been solved for AttributeAuthorityDescriptor in #128 / 800f698 - and I thought I should rather do the simpler thing of extending the fix done in #128 to the other role descriptors.
That is, change the role descriptor's functioning() method to also check whether the required endpoints/services are present and active (and adding a new function selfFunctioning() to these services).
This has however two unexpected consequences:

An IdP or SP that does not have the required endpoints now displays the red banner This Identity Provider is not functioning in the federation. .  That is probably still OK.
Because AttributeAuthority.functioning() calls collaborator.functioning(), an AttributeAuthority would be considered not functioning if the IdP descriptor does not have any SingleSignOnService defined.  A standalone AttributeAuthority would still work and generated correct metadata as long as the (hidden) IDPSSODescriptor has a (bogus/unused) SingleSignOnService defined.

So probably OK - just wanted to check with you - would you be happy with the above fix based on extended the functioning() calls as described above / done to AttributeAuthorityDescriptor in 800f698 ?
Cheers,
Vlad

Oh, btw, and forgot to say, it is also possible to break metadata signing by creating an IdP with no SingleSignOnService - you get the same problem as described here for SPSSODescriptor (and fixed for AttributeAuthorityDescriptor in #128).

PS: And, btw, my implementation of the proposed fix changes a number of assumptions - so also fails a number of tests both under base and metadata.  I'd include the updates specs in the PR - but also giving you the heads-up it's a "simple" change that changes a lot of the specs ( 17 failed tests in base,  16 in metadata).
Cheers,
Vlad

Hi Bradley, just to give you more details on the proposed solution: this is my take on changing functioning():
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AssertionConsumerService.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AssertionConsumerService.groovy
index 906a2f5..206a9bc 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AssertionConsumerService.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AssertionConsumerService.groovy
@@ -11,4 +11,7 @@ class AssertionConsumerService extends IndexedEndpoint  {
     ( active && approved && descriptor.functioning() )
   }

+  public boolean selfFunctioning() {
+    ( active && approved )
+  }
 }
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AuthzService.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AuthzService.groovy
index b800d50..96309bb 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AuthzService.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AuthzService.groovy
@@ -13,4 +13,8 @@ class AuthzService extends Endpoint  {
 	public boolean functioning() {
 		( active && approved && descriptor.functioning() )
 	}
+
+	public boolean selfFunctioning() {
+		( active && approved )
+	}
 }
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SingleSignOnService.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SingleSignOnService.groovy
index 4b8bc60..2989ee0 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SingleSignOnService.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SingleSignOnService.groovy
@@ -14,4 +14,7 @@ class SingleSignOnService extends Endpoint {
 		( active && approved && descriptor.functioning() )
 	}

+	public boolean selfFunctioning() {
+		( active && approved )
+	}
 }
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
index 37df6f9..08f72a6 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
@@ -44,7 +44,7 @@ class IDPSSODescriptor extends SSODescriptor  {
 	public String toString() {	"idpssodescriptor:[id:$id, displayName: $displayName]" }

 	public boolean functioning() {
-		( !archived && active && approved && entityDescriptor.functioning() )
+		( singleSignOnServices?.findAll{it.selfFunctioning()}?.size() > 0 && !archived && active && approved && entityDescriptor.functioning() )
 	}

 	public List sortedAttributes() {
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
index 899ca86..d9452e3 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
@@ -22,6 +22,6 @@ class PDPDescriptor extends RoleDescriptor {
 	public String toString() {	"pdpdescriptor:[id:$id, displayName: $displayName]" }

 	public boolean functioning() {
-		( !archived && active && approved && entityDescriptor.functioning() )
+		( authzServices?.findAll{it.selfFunctioning()}?.size() > 0 && !archived && active && approved && entityDescriptor.functioning() )
 	}
 }
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
index e1b8d5a..ebc42a1 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
@@ -34,7 +34,7 @@ class SPSSODescriptor extends SSODescriptor {
 	public String toString() {	"spssodescriptor:[id:$id, displayName: $displayName]" }

 	public boolean functioning() {
-		( !archived && active && approved && entityDescriptor.functioning() )
+		( assertionConsumerServices?.findAll{it.selfFunctioning()}?.size() > 0 && !archived && active && approved && entityDescriptor.functioning() )
 	}

 	public boolean equals(Object obj) {
diff --git a/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy b/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
index bd5efe4..e39b758 100644
--- a/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
+++ b/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
@@ -215,9 +215,9 @@ class MetadataGenerationService implements InitializingBean {
               }
             }
           }
-          entityDescriptor.idpDescriptors?.sort{it.id}?.each { idp -> idpSSODescriptor(builder, all, minimal, roleExtensions, idp) }
-          entityDescriptor.spDescriptors?.sort{it.id}?.each { sp -> spSSODescriptor(builder, all, minimal, roleExtensions, sp) }
-          entityDescriptor.attributeAuthorityDescriptors?.sort{it.id}?.each { aa -> attributeAuthorityDescriptor(builder, all, minimal, roleExtensions, aa)}
+          entityDescriptor.idpDescriptors?.findAll{ it.functioning() }.sort{it.id}?.each { idp -> idpSSODescriptor(builder, all, minimal, roleExtensions, idp) }
+          entityDescriptor.spDescriptors?.findAll{ it.functioning() }.sort{it.id}?.each { sp -> spSSODescriptor(builder, all, minimal, roleExtensions, sp) }
+          entityDescriptor.attributeAuthorityDescriptors?.findAll{ it.functioning() }.sort{it.id}?.each { aa -> attributeAuthorityDescriptor(builder, all, minimal, roleExtensions, aa)}

           organization(builder, entityDescriptor.organization)
         }

... and this is the alternative - adding a complete() method to denote a role descriptor as complete - having all mandatory descriptors.  It does not "touch" functioning() and only hooks into EntityDescriptor.empty():
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/EntityDescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/EntityDescriptor.groovy
index 3a2faee..725af52 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/EntityDescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/EntityDescriptor.groovy
@@ -64,25 +64,25 @@ class EntityDescriptor extends Descriptor  {
 		// No children or no children functioning indicates an empty ED
 		if(empty && idpDescriptors) {
 		 	idpDescriptors.each {
-				if(it.functioning())
+				if(it.functioning() && it.complete())
 					empty = false
 			}
 		}
 		if(empty && attributeAuthorityDescriptors) {
 		 	attributeAuthorityDescriptors.each {
-				if(it.functioning())
+				if(it.functioning() && it.complete())
 					empty = false
 			}
 		}
 		if(empty && spDescriptors) {
 		 	spDescriptors.each {
-				if(it.functioning())
+				if(it.functioning() && it.complete())
 					empty = false
 			}
 		}
 		if(empty && pdpDescriptors) {
 		 	pdpDescriptors.each {
-				if(it.functioning())
+				if(it.functioning() && it.complete())
 					empty = false
 			}
 		}
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AttributeAuthorityDescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AttributeAuthorityDescriptor.groovy
index b38f7f0..b3bf85b 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/AttributeAuthorityDescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/AttributeAuthorityDescriptor.groovy
@@ -39,6 +39,19 @@ class AttributeAuthorityDescriptor extends RoleDescriptor {
 			( attributeServices?.findAll{it.selfFunctioning()}?.size() > 0 && !archived && active && approved && entityDescriptor.functioning() )
 	}

+	public boolean complete() {
+		def complete = false
+		// Missing mandatory endpoints indicates an incomplete AttributeAuthorityDescriptor
+		if(!complete && attributeServices) {
+		 	attributeServices.each {
+				if(it.functioning())
+					complete = true
+			}
+		}
+
+		complete
+	}
+
 	def structureAsJson() {
 		def adminRole = Role.findByName("descriptor-${this.id}-administrators")

diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
index 37df6f9..b1e5ed7 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/IDPSSODescriptor.groovy
@@ -47,6 +47,19 @@ class IDPSSODescriptor extends SSODescriptor  {
 		( !archived && active && approved && entityDescriptor.functioning() )
 	}

+	public boolean complete() {
+		def complete = false
+		// Missing mandatory endpoints indicates an incomplete IDPSSODescriptor
+		if(!complete && singleSignOnServices) {
+		 	singleSignOnServices.each {
+				if(it.functioning())
+					complete = true
+			}
+		}
+
+		complete
+	}
+
 	public List sortedAttributes() {
 		def c = Attribute.createCriteria()
 		def attributeList = c.list {
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
index 899ca86..1b984c5 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/PDPDescriptor.groovy
@@ -24,4 +24,17 @@ class PDPDescriptor extends RoleDescriptor {
 	public boolean functioning() {
 		( !archived && active && approved && entityDescriptor.functioning() )
 	}
+
+	public boolean complete() {
+		def complete = false
+		// Missing mandatory endpoints indicates an incomplete PDPDescriptor
+		if(!complete && authzServices) {
+		 	authzServices.each {
+				if(it.functioning())
+					complete = true
+			}
+		}
+
+		complete
+	}
 }
diff --git a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
index e1b8d5a..a2a120c 100644
--- a/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
+++ b/app/plugins/base/grails-app/domain/aaf/fr/foundation/SPSSODescriptor.groovy
@@ -37,6 +37,19 @@ class SPSSODescriptor extends SSODescriptor {
 		( !archived && active && approved && entityDescriptor.functioning() )
 	}

+	public boolean complete() {
+		def complete = false
+		// Missing mandatory endpoints indicates an incomplete SPSSODescriptor
+		if(!complete && assertionConsumerServices) {
+		 	assertionConsumerServices.each {
+				if(it.functioning())
+					complete = true
+			}
+		}
+
+		complete
+	}
+
 	public boolean equals(Object obj) {
 		if( this.is(obj) ) return true
 		if ( obj == null ) return false
diff --git a/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy b/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
index bd5efe4..e327282 100644
--- a/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
+++ b/app/plugins/metadata/grails-app/services/aaf/fr/metadata/MetadataGenerationService.groovy
@@ -215,9 +215,9 @@ class MetadataGenerationService implements InitializingBean {
               }
             }
           }
-          entityDescriptor.idpDescriptors?.sort{it.id}?.each { idp -> idpSSODescriptor(builder, all, minimal, roleExtensions, idp) }
-          entityDescriptor.spDescriptors?.sort{it.id}?.each { sp -> spSSODescriptor(builder, all, minimal, roleExtensions, sp) }
-          entityDescriptor.attributeAuthorityDescriptors?.sort{it.id}?.each { aa -> attributeAuthorityDescriptor(builder, all, minimal, roleExtensions, aa)}
+          entityDescriptor.idpDescriptors?.findAll{ it.complete() }.sort{it.id}?.each { idp -> idpSSODescriptor(builder, all, minimal, roleExtensions, idp) }
+          entityDescriptor.spDescriptors?.findAll{ it.complete() }.sort{it.id}?.each { sp -> spSSODescriptor(builder, all, minimal, roleExtensions, sp) }
+          entityDescriptor.attributeAuthorityDescriptors?.findAll{ it.complete() }.sort{it.id}?.each { aa -> attributeAuthorityDescriptor(builder, all, minimal, roleExtensions, aa)}

           organization(builder, entityDescriptor.organization)
         }

Which one looks more palatable to you?  I'm now leaning more towards this one (complete() / empty()).... (and if committing this one, I'd also revert the original fix in 800f698 and switch to this approach).
Please let me know which of these would you prefer....
Cheers,
Vlad

thanks @vladimir-mencl-eresearch - Just wanted to let you know that I won't have a response for you in a hurry on this one.
I need some time to consider it thoroughly and with current commitments I'm not likely to get to that until Thur 14/4 (or shortly after).

Thanks for the reply - also good to know when not to expect one soon.
And I understand the need to consider this thoroughly - the reason why I got back to you for your opinion instead of rushing a PR was exactly that - both approaches have their deficiencies.
I'll be away from office for three weeks starting tomorrow night, back on the deck on May 2nd.
Happy to turn your response into a PR after I return :-)
Cheers,
Vlad

@vladimir-mencl-eresearch thanks for the detailed proposal here.
At the moment I have to agree that complete() seems much nicer and it doesn't upset the existing state present in the UI / current specs as the first proposal does.
I would like to make the naming of complete a little more descriptive to purpose, I'd propose samlSchemaValid. I think we can also cut down the implementation a little e.g.:
public boolean samlSchemaValid() {
  singleSignOnServices.any { it.functioning() }
}

Your thoughts?

Thanks for the reply - this looks very reasonable to me.  I'll come back with a PR next week.
Cheers,
Vlad

As promised: #222


feat(bus)!: add set_link_name_checked

Feature or Problem
This PR adds a new function to the wasmcloud:bus/lattice interface, set_link_name_checked, which will return an error if you attempt to override the default link name for a specific interface but a link doesn't exist.
This will be useful at runtime for a component to be able to attempt to invoke a different linked target, but then instead fall back to invoking a default target if there was an error during the set_link_name_checked process.
Open to suggestions to other functions, I considered other functions like get_link or check_link for checking first, but figured this would just be a better way to try and set the link immediately.
There's also room for other functions like reset_link_names etc etc, but leaving that out for now.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration
Modified existing interfaces test to add two cases where the checked interface set should fail.
Manual Verification

After syncing, decided to go with a 2.0.0 with updating the function signature.


code error

If I do not comment lines 107 and 108 of UniAV-main/libs/utils/train_utils.py, the first two errors in the picture will appear, and the last error will appear after I comment both, how can I fix it?

Sorry for that. I reviewed my code, and there is no error reported if I don't comment L108-109. Is there anything changed in your code?

Sorry for that. I reviewed my code, and there is no error reported if I don't comment L108-109. Is there anything changed in your code?

Yes, I comment the part of train.py that relates to “rank”, and the following commands are used during training: “python train.py./configs/multi_task_anet_unav_dcase.yaml --output reproduce --tasks 3 --num_train_epochs 5”, does that matter? What if I don't want to use multiple Gpus?

solved. thanks!
------------------ 原始邮件 ------------------
发件人: "Tiantian @.>;
发送时间: 2024年6月12日(星期三) 上午10:36
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [ttgeng233/UniAV] code error (Issue #1)
You can use the bellow command to use 1 GPU under distributed training mode:
CUDA_VISIBLE_DEVICES=0 MASTER_ADDR=localhost WORLD_SIZE=1 RANK=0 python -m torch.distributed.launch --master_port 29600 --nproc_per_node=1 train.py ./configs/multi_task_anet_unav_dcase.yaml --output reproduce  --tasks 1-2-3 --num_train_epochs 5
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

No worries!


svt-av1: 2.1.2 -> 2.2.0

Description of changes
As a follow-up of #228556, this PR enables some additional optimization flags:

-DSVT_AV1_PGO=ON: Enables profile-guided optimization, according to official build instructions: "(LTO and PGO can be combined, for maximum gains)". See build.sh.
-DCMAKE_BUILD_TYPE=Release, -DNATIVE=ON are also from the source that #228556 referenced.

Enabling PGO only works with 2.2.0, so this PR also bumps version from 2.1.2 to 2.2.0, see release notes.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Note that PGO is in conflict with reproducibility, and this package is in the closure of several critical packages like ffmpeg, so this would most likely compromise the reproducibility of the installer ISOs.

Thanks @emilazy and @jopejoe1! I see that's why these flags aren't enabled already. I have dropped the second commit and updated the PR title such that this PR is a version bump only.

Thanks @jopejoe1 ! I have switched target to staging.


💄 feat: Make the page a little bit pretty

Close #7

I wish the Cloudflare integration was tighter with GitHub but here's what I uncovered from the build log:
23:48:20.600 | src/App.test.tsx(22,19): error TS2339: Property 'value' does not exist on type 'HTMLElement'.
-- | --
23:48:20.601 | src/App.test.tsx(41,19): error TS2339: Property 'value' does not exist on type 'HTMLElement'.
23:48:20.601 | src/GasPrice.t3st.tsx(27,18): error TS2339: Property 'value' does not exist on type 'HTMLElement'.
23:48:20.601 | src/GasPrice.tsx(3,28): error TS6133: 'currency' is declared but its value is never read.

Looks like linter errors

[ ] Fix the weird footer thing where it goes below the screen; I'm thinking 100vh includes the browser chrome (toolbar on bottom of screen)
[ ] Connect my phone to get faster feedback; tighten feedback loop

After spending nearly an hour trying to solve the riddle of the hidden footer, I don't think Brave Browser for Android is going to give me a solution. env(safe-area-inset-bottom) is apparently 0, though this might be useful for Safari Mobile for iOS

Compare approaches:

[] Remove viewport-fit=cover from viewport meta tag
[] footer { padding-bottom: env(safe-area-inset-bottom); }
[] #root { min-height: 100dvh; }


ethernet: w5500: recover w5500 driver from missed interrupt

The W5500 driver will hang if a RX data interrupt is missed. This
occurs when the ethernet module is under heavy load like a flood
ping. This fix sets up the driver to timeout after some period
and manually check if the interrupt pin is active. The timeout
is configurable by setting ETH_W5500_INT_TIMEOUT since there is
a tradeoff between driver overhead and max incoming latency.
See similar issue and resolution at https://github.com/espressif/esp-idf/issues/6233.
The issue has been verified and the fix tested on an nRF52840 by using flood ping.
Signed-off-by: Jaremy J. Creechley<EMAIL_ADDRESS>

Thanks for the work. Unfortunately this puts the thread in running state even when there is no activity on ethernet.

It's unfortunate, but seems unavoidable for stable operation. Though being able to adjust the timeout should let users set it for lower overhead. On the upside, it should fix potential issues with the w5500 when waking up from sleep modes.

Also the way the hardware buffer is handled is impossible to check the missed data part. ACK.

We haven't noticed lost data in practice, but we're using TCP. Missing the timeout interrupt is relatively rare too, so probably not too big of a concern.

I think this PR can be closed because https://github.com/zephyrproject-rtos/zephyr/pull/45765 is merged


Add Elixir starter package

I hope everything is OK. I tested it with a few bots, and didn't run into any issues. I use standard Elixir naming conventions, since Elixir is pretty strict about names.

Does the server still need to be updated so that you can compile Elixir?

@jtwebman Yes.


please add null safety support

You can use this branch
https://github.com/raj457036/shrink_sidemenu_flutter/tree/null_safety


Multi-Panel: Overall a11y test with tab navigation.

TODO: Put real UI controls inside of Multi-Panel component and make sure tabindex handling does not mess with user action/intent.

closing this issue. This should be done in multi-panel repo once we set that up.


Minimum font size

I'm trying to assess if someone else's work is accessible, and they are using 8px. Your tool currently has a minimum font size of 10px.
It would be great if we could go smaller

Hey @kaylajheffernan we could easily do this, however, technically there is no difference between contrast accessibility between 8pt and 10pt font. The formula used to evaluate the contrast is the same, it only changes once you go over 18pt.
Of course, there is a material difference in how you or anyone perceives the text.
We'll talk about changing this

Have allowed minimum size of 8px (which is equal to ~11pt)


More arguments for code execution via command line

Implement the following argument flags for the code execution argument -c:

--init: If set the init.dnys script will be executed before running the code
`--allpl: If set then all available plugins will be included for the session

Resolved.


[SURELY NOT A BUG] Couldn't compile

Checklist before submitting an issue

[X] I have searched through the existing closed and open issues for eww and made sure this is not a duplicate
[X] I have specifically verified that this bug is not a common user error
[X] I am providing as much relevant information as I am able to in this bug report (Minimal config to reproduce the issue for example, if applicable)

Description of the bug
I am not able to compile eww using cargo build. I tried some solutions in issues but they didn't work.
Reproducing the issue
cargo build --release --no-default-features --features x11
It gives me multiple thing like this:
 --> crates/simplexpr/src/lib.rs:6:12
   |
 6 | #![feature(once_cell)]
   |            ^^^^^^^^^

I tried to do this command :
rustup default nightly
but it changes nothing.
Expected behaviour
Compiling normally.
Additional context
   Static hostname: darkpepito-Latitude-E5470
         Icon name: computer-laptop
           Chassis: laptop
        Machine ID: c86d35c6ea5f47a092e0fb3750d381eb
           Boot ID: e93752c6db2b4e1b87c48bee6167e332
  Operating System: Zorin OS 16.2
            Kernel: Linux 5.15.0-73-generic
      Architecture: x86-64

Thank you for your help !

What rust version are you using? The error message you provided doesn't show the entire error, so I have no way of checking what causes it. This is indeed not a bug.

rustc return me version 1.65.0
I didn't find the needed version in documentation.
Here is the complete error message:
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:1:1
  |
1 | #![feature(box_patterns)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:2:1
  |
2 | #![feature(pattern)]
  | ^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:3:1
  |
3 | #![feature(try_blocks)]
  | ^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:4:1
  |
4 | #![feature(unwrap_infallible)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:5:1
  |
5 | #![feature(never_type)]
  | ^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:6:1
  |
6 | #![feature(once_cell)]
  | ^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:2:12
  |
2 | #![feature(pattern)]
  |            ^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:4:12
  |
4 | #![feature(unwrap_infallible)]
  |            ^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> crates/simplexpr/src/lib.rs:6:12
  |
6 | #![feature(once_cell)]
  |            ^^^^^^^^^

For more information about this error, try `rustc --explain E0554`.
error: could not compile `simplexpr` due to 9 previous errors

As the error (kind of) tells you, you're on stable rust, whilst eww requires you to ue a nightly compiler.

I understood, but how can I switch to nightly ?

The preferred method is using rustup, but you also might be able to go through your package manager (I wouldn't recommand)


Commit Version Bug Fix

This pull request addresses and fixes the issues associated with commit versions.
Previously, relying on commit versions posed problems, with some being merged and potentially causing functionality issues.
Furthermore, this update incorporates a detailed comment to assist users in effectively leveraging the code in future versions.
Previously, the code was triggering the following error:
opt/conda/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:389: UserWarning: `do_sample` is set to `False`. However, `temperature` is set to `0.1` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `temperature`.
  warnings.warn(
/opt/conda/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:394: UserWarning: `do_sample` is set to `False`. However, `top_p` is set to `0.1` -- this flag is only used in sample-based generation modes.

File /opt/conda/lib/python3.10/site-packages/transformers/modeling_attn_mask_utils.py:343, in _prepare_4d_causal_attention_mask_for_sdpa(attention_mask, input_shape, inputs_embeds, past_key_values_length, sliding_window)
    340 is_tracing = torch.jit.is_tracing()
    342 if attention_mask is not None:
--> 343     if torch.all(attention_mask == 1):
    344         if is_tracing:
    345             pass

RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

Thank you for the contribution but there is a reason why we pinned it for now to git commits. Once we have new released i ll update the blog.


Replat slim framework on endpoint routing

https://github.com/davidfowl/Web.Framework/tree/master/Web.Framework

FYI @davidfowl


Set compression to LZO

LZO compression could improve startup time. See https://ubuntu.com/blog/snap-speed-improvements-with-new-compression-algorithm

Hi @timlueg,
thanks for your contribution. I pushed a new build to the candidate channel. Can you please try and let me know if this works for you?
snap refresh jdownloader2 --channel=latest/candidate

Works for me!


JS error on "formattedChange"

For the last week or two, I've noticed that the page doesn't fully load all values.  It fails on different stocks at different times depending on what stocks I am listing.  I am getting these errors in the browser console:
Uncaught (in promise) TypeError: Cannot read property 'toLocaleString' of null
    at stocks.html:171
    at Array.forEach (<anonymous>)
    at stocks.html:166

Hi @nsapovits, thanks for reporting. I've seen the same thing anecdotally in my own version. I think this PR that I just put in fixes it: https://github.com/toddwschneider/stocks/pull/12
But I can't confirm yet because right now the IEX API is returning all values for me. I'll check in tomorrow to make sure it behaves correctly when quote.change isn't available, and if so I'll close this issue. Thanks

I believe this is fixed by a combination of https://github.com/toddwschneider/stocks/pull/12 and https://github.com/toddwschneider/stocks/commit/f3f7e22d5b61e6a5b09435e7ea391f1e274989c1
I'm closing the issue, but please let me know if you see any more broken behavior

Thanks Todd, it looks like the latest commit has resolved it.  Appreciate the quick response!


Doesn't work with Chinese characters

f works with Chinese characters in native Neovim:

But doesn't work in vscode-neovim:

The same applies to r, F etc.

Sorry to bother but, I wanna ask how to use f to find a Chinese character in neovim? I'm a neovim user, and recently I turned to VSCode and I've never known neovim has this function at all...

@orbitoo Neovim natively supports it, give it a try.

This would require using something like beforeinput to capture the IME events.
Basically input would require not being sent to neovim until the IME event is finished.

korean input is also not working properly

@chase @doongjohn would you be able to try https://github.com/vscode-neovim/vscode-neovim/pull/1009

Seems like #1009 fixed this issue.


(volanail.user.js) Music file player doesnt work when in nail view

Not sure how to go about this. Is it possible to hook the event listener from a function from main.js or one have to reimplement music player in order to fix this?

fixe


Make sure CU Fall Event leaderboard crawler does not add points after end time

End timestamp:<PHONE_NUMBER>

Verified that we are cutting off. This was the message I sent to the Crypto Unicorns team:
Our on-chain leaderboard data for the Fall Event is set to cut off at this timestamp:<PHONE_NUMBER>.
You guys are using this timestamp:<PHONE_NUMBER>
My timestamp in human-readable time: GMT: Sunday, January 1, 2023 0:00:00
Your timestamp in human-readable time: GMT: Saturday, December 31, 2022 0:00:00
Do you want it to cut off at the very end of 2022 or 24 hours before? Let me know.


License "UNLICENSED"  is not a valid SPDX expression!

ERROR in WebpackLicensePlugin: License "UNLICENSED"  is not a valid SPDX expression!
I have several proprietary / private packages on npm. I have denoted them as licence: "UNLICENSED" in package.json, as from what I understand that would be the right term.
But why is this throwing an error then?

why is this throwing an error then?

UNLICENSED is not listed here:
https://spdx.org/licenses/

See https://github.com/codepunkt/webpack-license-plugin/issues/460#issuecomment-814103682 for a possible solution.

I have several proprietary / private packages on npm. I have denoted them as licence: "UNLICENSED" in package.json, as from what I understand that would be the right term.

That is a commonly used term to denote private packages without a license.

But why is this throwing an error then?

You usually generate open source licensing information (and thus use this plugin) because you want to distribute the build result of an application or service that is using these open source packages to a third party. If you have UNLICENSED packages as part of the open source you use, most third parties will not be able to use your package at all.
Aside from that, your proprietary/private packages (that I assume you or your company have authored themselves) are not open source, but are part of the thing you distribute without being open source. My suggestion is to reserve a NPM namespace for your internal UNLICENSED packages that you're using and then exclude these packages from the license metadata generation using the excludedPackageTest option like this:
excludedPackageTest: (packageName, version) => {
  return packageName.startsWith('@internal/')
}

If you have UNLICENSED packages as part of the open source you use, most third parties will not be able to use your package at all.

Commercially distributed software still needs a manifest of licensing information for any open source packages it relies on. Proprietary packages are typically marked as 'private' in package.json - shouldn't those be excluded by default?


Added ability to check if number is at specified type via isValidNumber method

Added ability to check if number is at specified type via isValidNumber method
Available types: (might be passed to function also in lowercase)

FIXED_LINE
MOBILE
FIXED_LINE_OR_MOBILE
TOLL_FREE
PREMIUM_RATE
SHARED_COST
VOIP
PERSONAL_NUMBER
PAGER
UAN
VOICEMAIL

Thanks @Igloczek!


Client side password hashing

What
Hashes passwords in the application
Why
Ensures passwords are not logged in any way (e.g. postgres query logs)
Screenshots
Notes

These changes look fine!
I have a question on the description/intent though. Surely this is still server-side hashing? I get that the db will no longer see the plaintext passwords, but they'll still be in server logs, etc. If we want client-based hashing we'd need to implement it wholly within the page.

ye good point, we actually meant to name this server side or app side hashing as that is actually what is going on 👍


add new cytometry container

I will submit PR shortly. Let me what else I need to do in order for it to appear in https://hub.docker.com/r/bioconductor

I will look over the pull request and make sure it compiles correctly and  set up the dockerhub repos under the bioconductor dockerhub account.  If anything looks out of sorts I'll let you know.  It may be a week or two until fully functional under the Bioconductor account.

I merged the pull requests and created the repos on docker hub and kicked off initial builds -  it should be active now.
There is a slight issue with docker hub linking builds to upstream images that we used in the past but I'm looking into this -
Please test the docker images for devel_cytometry2 and release_cytometry2  and let me know if there are any issues.

Work perfectly!Thanks a lot!

Can we update http://bioconductor.org/help/docker/ as well?

Yep I'll do that now.  Thanks!

I saw the container hasn't been updated since 2 months ago https://hub.docker.com/r/bioconductor/devel_cytometry2/builds
I thought it was updated weekly?

Its suppose to.  When dockerhub updated their site the autobuilds deactivated somehow.  I'm working on it.  The devel dockers are also broken currently until rocker has a 3.6.0 tag https://github.com/Bioconductor/bioc_docker/issues/79

Good to know. Please keep me posted. Thanks a lot!


Aardvark: update documentation to include tcf 2.0

I don't know why there's a conflict in this simple PR, @FilipStamenkovic, but I went ahead and made a separate PR https://github.com/prebid/prebid.github.io/pull/1908 - done

@bretg thanks.


How to publish link

Hi Liviu,
How to publish link on  from https://xpack.github.io/openocd/ points to https://github.com/xpack-dev-tools/openocd-xpack/blob/xpack/README-PUBLISH.md
It should now point to https://github.com/xpack-dev-tools/openocd-xpack/blob/xpack/README-RELEASE.md
--
Bob

Hi Bob, thank you for the report, I fixed it.
For future issues related to the web site, please use the separate tracker:

https://github.com/xpack/web-jekyll/issues.

Hi Liviu,
Ok on correct reporting location. Rushed that one out last night and didn’t find the link.
BTW the xpack.GitHub.io/openocd/ pages now have a visible edit button at the bottom when I view them in Edge. Just 404s but should not be there I expect.
—
Bob
(Sent from iPhone)
On 15 Mar 2021, at 11:15 pm, Liviu Ionescu @.***> wrote:

Hi Bob, thank you for the report, I fixed it.
For future issues related to the web site, please use the separate tracker:

https://github.com/xpack/web-jekyll/issues.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/xpack-dev-tools/openocd-xpack/issues/8#issuecomment-799372328, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACE5BWHUNB25TOBQPJ67N2TTDX26BANCNFSM4ZGMX7XQ.

the xpack.GitHub.io/openocd/ pages now have a visible edit button at the bottom ... 404s

A broken link; fixed, thank you.
BTW, please mind the way you write messages, since markdown will be confused by various characters and generate weird formatting. (I had to edit your initial post since it was hard to read).
Also prefer the web interface, since you have a better control. If you insist on replying via email, be sure you remove the original message, otherwise you get posts like the one above.


[Exposure Request] Table 27 "Item" - variables ItemTrackingCode and ItemTrackingCode2

Reference to the old issue marked as complete:
https://github.com/microsoft/ALAppExtensions/issues/20228
Not included in the Build ID 51464 (Update 3 for BC 2022 Wave 2)
Please mark variables ItemTrackingCode and ItemTrackingCode2 as protected variables so that those can be used on table extension.

This is done for v.22


Test front-end against ERC-20 tokens without symbol and decimals

ERC-20 specifies that symbol and decimals are optional.
The display of ERC-20 amounts was programmed with this spec in mind.
It would be good to exercise the front-end with those edge cases.
By default, it should display "tokens" when a symbol is missing, and have 0 decimal places.

Token lists are a good way to get token names, logo, and other infos from address: https://tokenlists.org/
Source: https://discord.com/channels/600597137524391947/1166042819782258788/1255983467309826089


Preliminary things to do:

[ ] 1. Add time-varying velocity
[ ] 2. Variable density (change to momentum flux)
[ ] 3. Boundary conditions
[ ] 4. NetCDF output
[ ] 5. Add Microphysics

@trontrytel Add saturation adjustment (#5)
@edejong-caltech Look at PySDM setup for (#1,2,3)
@trontrytel and @edejong-caltech Look at EDMF for example of netCDF output

Dry-air density / dry-air potential temp / water vapour mixing ratio are used to compute rho_d in PySDM

    @staticmethod
    def rho_d(const, p, qv, theta_std):
        return (
            p
            * (1 - 1 / (1 + const.eps / qv))
            / (np.power(p / const.p1000, const.Rd_over_c_pd) * const.Rd * theta_std)
        )

and from physics module:
R_str = sci.R * si.joule / si.kelvin / si.
Rd = R_str / Md
c_pd = 1005 * si.joule / si.kilogram / si.kelvin
Rd_over_c_pd = Rd / c_pd

B.C. in PySDM (mpdata) are "Extrapolated"

1 and 2. The "advector" quantity is specific as rho_times_w rather than simply w.

        rho_times_w_1: float = 2 * si.m / si.s * si.kg / si.m**3,

        self.rho_times_w = (
            lambda t: rho_times_w_1 * np.sin(np.pi * t / t_1) if t < t_1 else 0
        )

Unclear where the density actually enters into play here.


add z-index in option

This works perfectly!... but it would be nice if we could specify the z-index as well instead of just the offset...

There is a PR open for this: #12 .


Deletion of duplicate comments

The problem appears when you try to add the same replies for different comments. Django's Comment form has a check_for_duplicate_comment function which does not let the same comment to be submittited twice, but it does not check the replied_to parameter attached in Mezzanine's Comment model. I use Django 1.5 and the stable realease of Mezzanine, but it is present in the demo page as well.

Thanks for the report. I've a patch incoming that fixes this.


Change Pipettes: Move Pipette into Position UI

overview
As a user, I would like the pipette carriage to move into an accessible position before I change pipettes, so that I can easily access the pipette screws and plug. To do this, the Run App needs to present a dialog and call the robot API to move the carriage to the front.
Acceptance Criteria

[x] User initiates a pipette attachment or change via button in #861 or #862

[x] Alert modal tells them to remove labware and tipracks
[x] If user is changing a pipette, warn that removing a pipette will clear related calibration data
[x] User is able to cancel or continue with pipette change

[x] If user opts to continue, app requests the robot to move carriage to an accessible location

[x] User shown spinner + message while moving

[x] Pipette power turned off (to plunger), so that user can safely remove pipette

Dependency

API method to toggle pipette power, #866

Implementation Notes

This story should cover both pipette attach and detach in a generic manner
For the purposes of this ticket, all screens after the move to spinner falls under #863 and #864
Note #866 exposes controls for individual robot axis; the FE will have to select specific axis to turn off and on (in this case, axes 'B' and 'C' for pipette plungers)

Design

dialogue box: https://projects.invisionapp.com/d/main#/console/13399396/279798950/preview
spinning icon: https://projects.invisionapp.com/d/main#/console/13399396/279798949/

Dependencies

View attached pipettes in Settings and Calibration (#862 and #861)
API endpoint to disable pipette (#866)
API endpoint to move pipette to front (#TBD)

If changing the right pipette, carriage moves all the way forward and left
If changing the left pipette, carriage moves all the way forward and right
Pipette carriage moves all the way down
Note: will need to think through correct move-to (safe but accessible distance from the deck?)

Dependents

Pipette Detach UI (#863)
Pipette Attach UI (#864)

Test Plan
TBD by @mcous

@mcous @Laura-Danielle
After discussion with @mcous, we potentially need a new BE API endpoint / function to 'move the pipette to an accessible location'.

FYI @mcous
After discussion with @btmorr, the BE endpoint will expose controls to engage or disengage individual axis, so the Run App will have to be somewhat intelligent and select which axes to disengage before pipette change (in this case, axis b and c)

Addressed by PRs listed above!


Group related items by mainstream browse page

Currently, related items are grouped based on having a common parent or grandparent with the content item they are linked to. This commit changes the grouping logic to group by common mainstream_browse_pages, in order to match the currently implemented grouping logic.

👍 might want to update the changelog too

👍 for intent, but needs a thorough read through to update the method names & comments to reflect new behaviour.

@jackscotti @tijmenb I've updated the comments and method/variable names to be more descriptive (hopefully) and also added the (unreleased) related items functionality to the changelog.


Carbon mantle addition

This update adds the phases of graphite (Seager '07) and diamond (Benedict '14).  Users desiring a carbon mantle should invoke "C_Simple" rather than "Si_default" in the config file (line 27).

Please add to a fresh install of Magrathea, this commit deletes a few previous changes from an older version and modifies the input files. Add just one diamond. New commit should have only main.cpp, phase.cpp, phase.h, EOSlist.cpp, EOSlist.h, and define.h. We'd appreciate if you add the new diagram to the table in the ReadMe also.


Generate time series

Based on the fact that giganto sends events in order of time, this generates time series according to the model's configuration. Close #10

Codecov Report
Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (05543bb) compared to base (27e12e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #16   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          5       6    +1
  Lines        241     340   +99
=====================================
- Misses       241     340   +99

Impacted Files
Coverage Δ

src/main.rs
0.00% <ø> (ø)

src/model.rs
0.00% <0.00%> (ø)

src/subscribe.rs
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

테스트 코드 추가해주세요. 테스트 내에서 서버를 띄우고 테스트하는 예는 giganto의 ingestion::tests 모듈에 있습니다.

테스트 코드 추가해주세요. 테스트 내에서 서버를 띄우고 테스트하는 예는 giganto의 ingestion::tests 모듈에 있습니다.

테스트 코드를 @BLYKIM가 작성하였습니다.


Make user unique for clipboard

This prevents a race condition in get_user_clipboard which can result in:
MultipleObjectsReturned: get() returned more than one Clipboard -- it returned 2!

errors. According to the django docs get_or_create is only atomic if uniqueness is enforced at the database level.

I thought about line-wrapping for PEP008 compliance, but since the line was already overlong I left it alone. Let me know if you'd like me to fix that up.

@julianandrews This looks like a sensible change. I'd like to merge it, but I think it will need to have refreshed migrations. Can you do this, or shall I create a new PR with this change in?

@mkoistinen I've updated the PR. Let me know if you need any other changes.

@julianandrews Thank you! I think we also require South migrations too though...

@mkoistinen I'm not really setup to generate south migrations. I didn't realize filer still supported south! Do you maybe have a project that can be used to generate those?

This branch need to be rebased

Just wanted you guys to know that my company is working on a project, and we ran into this race condition on one of our projects.


Migrate the frontend project from CRA to Vite

From Create react app  to Vite.
Make Sure you do not produce breaking changes

https://github.com/coryhouse/reactjsconsulting/issues/139

https://blog.logrocket.com/vite-3-vs-create-react-app-comparison-migration-guide/#migrating-a-create-react-app-project-to-vite

Can i work on this issue?

Can i work on this issue?

Go ahead, make sure to do changes in .env files as well


Adding --json output

Hi, while reviewing my repositories I have stumbled upon this thing that I did, so may be it can be useful to you


fix: improved unit test for action folder entrypoint

Description
This updates #141  with a failing test (now passing with that PR)
Fixes #140
How Has This Been Tested?
npm test
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Manual test results for remote debugging:

[X] Windows 10 (x86_64)
[X] macOS 11.3.1 Big Sur (x86_64)
[X] Ubuntu Linux 20.04 Focal Fossa (x86_64)
[X] macOS 11.3.1 Big Sur (arm64)


[Eloquent] $fillable and firstOrNew/firstOrCreate dont use set mutators

If the model I've defined has a DateTime property and the fillable attribute is not identical to the physical column name, firstOrNew and firstOrCreate dont know how to handle the property.
I also noticed the setXAttribute() methods are never called during the lookup phase. Is there a specific reason the model is not filled first, and the Select query generated from its properties?
Example code & log output: https://gist.github.com/wjaspers/bb8f9cf0a4a7e169b7e9
I'm using Laravel 4.1
[ErrorException]
Object of class DateTime could not be converted to string

I think that proposed fix is supposed to be the expected behaviour, so could you please fix that in future releases?

Just ran into this, any change of it being merged into L5.3?


Devbox global shellenv slows down shell startup

What happened?
Adding eval "$(devbox global shellenv)"	to my .zshrc causes adds almost half a second to my shell startup time.
Is this command making network calls? I am not sure why or how this command takes so long to complete.
Steps to reproduce

~ > time  zsh -i -c exit
zsh -i -c exit  0.02s user 0.02s system 46% cpu 0.098 total

Add eval "$(devbox global shellenv)" to .zshrc

~ > time  zsh -i -c exit
zsh -i -c exit  0.10s user 0.10s system 37% cpu 0.545 total

Command
global
devbox.json
No response
Devbox version
0.9.1
Nix version
nix (Nix)2.16.1
What system does this bug occur on?
macOS (Apple Silicon)
Debug logs
No response

Shell script adds 250ms
time devbox

________________________________________________________
Executed in  565.80 millis    fish           external
   usr time  165.44 millis    0.39 millis  165.05 millis
   sys time  101.30 millis    6.92 millis   94.38 millis

Shell script launches binary:
cat (which devbox) | grep INSTALL_DIR

readonly INSTALL_DIR="${HOME}/.cache/${TOOL_NAME}/bin"
	local -r installed_version=$(ls "${INSTALL_DIR}/" 2>/dev/null | sort -rV | head -n 1 | grep -oE 'v?[0-9]+\.[0-9]+\.[0-9]+-?[a-zA-Z]*')
	local -r bin_dir="${INSTALL_DIR}/${version}_${platform}"
	local -r bin="${INSTALL_DIR}/${version}_${platform}/${TOOL_NAME}"
		echo "INSTALL_DIR: ${INSTALL_DIR}"

And binary is not that fast as well:
time ~/.cache/devbox/bin/0.13.4_darwin_amd64/devbox

________________________________________________________
Executed in  214.63 millis    fish           external
   usr time  152.89 millis    0.23 millis  152.66 millis
   sys time   51.53 millis    2.91 millis   48.62 millis

For comparison:
time ls --help

________________________________________________________
Executed in   15.87 millis    fish           external
   usr time    4.26 millis    0.20 millis    4.06 millis
   sys time    7.46 millis    3.81 millis    3.66 millis

Shame for asking to add this to your init sh!
It works so slow, that I thought devbox is written in python :)


some problem on Link when Route with params

Router as follow
<Router />
      <Route path="resumes/:id" component={ResumeComponent} />
<Router />

I want to my Link can in activeStyle no matter what id equal , and I want to the link to the url '#/resumes/1',  but if Link as follow
<Link to="/resumes/1" />

when the url change to '#/resumes/2' , the Link is  not in activeStyle

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.

Check out the docs everything should be covered there, please see: https://github.com/rackt/react-router/blob/master/CHANGES.md#active-class

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.

Jinx.


Pin xarray to unreleased master and rechunker to 0.4.2 for use with pip.

Closes #111

@rabernat After merging, can you create a new release as well since 0.2.0's requirements.txt contains this non-existent xarray version https://github.com/pangeo-forge/pangeo-forge/commit/ad82fb63898e3b0d1aa761230a454d27678bc2fe.

I think we have a hung test.

After merging, can you create a new release as well since 0.2.0's requirements.txt contains this non-existent xarray version ad82fb6.

I'm not sure that's what you want. If we create a new release now from master, it will also include the refactor of #101, which will probably break your test recipes. I guess we should have done this before the 0.2.0 release. 🤦
In any case, xarray 0.17.1 will be released any day now.

@rabernat I've updated both pangeo-forge-prefect and my PR against staged-recipes to use the changes from #101 and run the recipe on our bakery as a test.  Is there any other breaking changes in master that I have not taken into account?


Wait for user-confirm before download function

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.07.22. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.07.22

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Description of your issue, suggested solution and other information
It would be nice to have an option in youtube-dl,
that could be something like "--wait-before-download" which would work like this:
URL fetching and information getting, then wait for any keystroke, a specific letter and then continue with the actual download process
One helpful situation is when using system proxy for fetching information and download links,
when proxy isn't needed for actual content.

This won't prevent youtube-dl from using proxy since it's taken from environment youtube-dl is started with. Moreover in case of long confirmation time download links may expire for extractors that generate such links.

What about ffmpeg? Same thing there? I mean: Also gets proxy from youtube-dl startup?

Yes. When youtube-dl starts ffmpeg it passes an env based on own settings.


What does dirty build mean?

Sorry, I feel bad wasting your time with a question like this but I tried to google it and didn't find anything.
I built apktool from source and when I ran it says apktool dirty. What does that mean? Is it just because it's unofficial or is it because I did something wrong in the build, something is missing?

 That's a good question! :-)
Hopefully someone will correct me if I'm wrong and/or elaborate further.
It's something I understand but, am challenged to define (personally).
A dirty build is something that's unfinished in nature with commits that are not applied.
As opposed to Snapshots... Snapshots are builds with the commits applied to it. Kinda like an incomplete build (aka... What's done so for).
I try to avoid Dirty builds as their unfinished/unpolished. If I wanted to try what's done so far (before an official build was compiled), I'd compile a Snapshot.
I apologize for the broken definition. Hopefully @iBotPeaches can elaborate much better than I can. :-P
~Ibuprophen

Thanks! I will avoid it too. How do avoid it?


Fix #3065: replace variables even if missing POM properties

For the replacement of variables with missing properties, a fallback-string
can be defined. At the moment this replacement is an empty string, but
the implementation allows the usage of any other string.
Please excuse me if this commit should be rough around the edges. I lack any experience with IntelliJ and Groovy.
@oehme
I mention you just for you to take notice of this pull request.

Hey Christian,
I gave this a bit more thought and I think we can solve this in an even more targeted manner that doesn't obscure the original problem, so things are still debuggable. The code that is failing is this. If we specifically test for a bad packaging there, we can skip the lookup that we know will fail and instead go right to the jar lookup.
The upside is that this both requires less code and leaves the original metadata in our cache instead of replacing it with a placeholder, which might be confusing for other purposes.

@oehme
This is true, but this only fixed the issue for the package-type. There may be variables for other elements that may produce similar problems. My solution is a more general one that handles all unresolvable variables.
I also think that my approach is slightly more elegant than checking a string to start with ${, but I will leave this up to you :) I don't think I will submit another pull request for this.

There are other ways to generalise this so it also fixes broken module/group/version specifications. But I wanted to start with the problem you actually have. Otherwise we'd need extra tests making sure that it also fixes it for module/group/version.
If you are not planning to work on this further, would you mind me copying over your test case for a different solution?

If you are not planning to work on this further, would you mind me copying over your test case for a different solution?

Feel free to do so :)

Please ignore my latest commits. It obviously doesn't work.

Superseded by https://github.com/gradle/gradle/pull/3599


useParams cannot get routeParams as expected

Reproduce
/** @type {import('@storybook/react').Meta} */
export default {
  component: PostDetail,
  parameters: {
    reactRouter: {
      routePath: '/posts/:postId',
      routeParams: {postId: 1},
    },
  },
};
export const Basic = (args) => {
  const {postId} = useParams();

  console.log(postId) // 👈 shows undefined in console

  return <PostDetailPage id={postId} />;
};

Expected
react-router's useParams should get the corresponding value from routeParams.

Hi 👋 Thank you for opening an issue.
I see you haven't declared the decorator property in the story, have you declared it somewhere else ?

@JesusTheHun Oh! I forgot to mention that, I declared decorator in preview.js already.
export const decorators = [
  withRouter,
  (Story) => (
    <SWRConfig value={{fetcher: request.get}}>
      <Global styles={[rebase, layout]} />
      <Story />
    </SWRConfig>
  ),
];

Can you share a full reproduction example such as a repo ? Because I'm unable to reproduce the issue.
But just to be clear, is it normal that it is a story about PostDetail, but that the component is named Basic and renders PostDetailPage ?

@JesusTheHun Thank you for answering.
You are very careful, it's normal in my source actually, here I just wrote wrong.
Please check out my source code, and change this line into this
export default {
  component: PostDetail,
  parameters: {
    reactRouter: {
      routePath: '/posts/:postId',
      routeParams: {postId: 1},
    },
  },
};

export const Basic = (args) => {
 const {id} = useParams()
  return  <PostDetail id={id} />
};

Once you cloned and installed with yarn, use yarn scripts to start a storybook dev.

I've taken a look and this is not an addon issue.
You cannot use a context (here the react router context) from story function.
If you move the useParams() inside a component you will get the expected parameter value.
For example, this will log the param value :
const LogParam = () => {
  const {postId} = useParams();
  console.log(postId);

  return null;
};

/** @type {import('@storybook/react').Story} */
export const Basic = (args) => {
  return (
    <>
      <LogParam />
      <PostDetail id='1' />
    </>
  );
};

I understand this is not what you were trying to achieve.
I suggest you use a wrapper to inject the parameters :
const InjectParam = ({params, children}) => {
  React.Children.only(children);

  const routeParams = useParams();
  const paramsToInject = {};

  params.forEach((param) => {
    if (typeof param === 'string') {
      paramsToInject[param] = routeParams[param];
      return;
    }

    const [routeParamName, propertyName] = param;
    paramsToInject[propertyName] = routeParams[routeParamName];
  });

  return React.cloneElement(children, paramsToInject);
};

// Wrap your component inside your story function.

// <InjectParam params={['id']}> Using a simple string will map the `id` route param to the `id` property of the wrapper component.
// <InjectParam params={[['postId', 'id']]}> Using a tuple will map the `postId` route param to the `id` property.
// <InjectParam params={['anotherParam', ['postId', 'id']]}> You can mix both approaches

export const Basic = (args) => {
  return (
    <InjectParam params={[['postId', 'id']]}>
      <PostDetail />
    </InjectParam>
  );
};

@JesusTheHun Thank you so much, it seems reasonable.

If you consider your issue resolved, please close this issue.


100% Test Coverage

We need to test everything!
--need to research what testing framework we want to use
--there should also be a code coverage tool we use to make sure we hit everything in the gem

You guys should check out rspec or some other framework for testing the gem.  We definitely should have some unit tests we can run to test that no functionality was broken when we make a change.  Here's some resources you can check out if you want.
http://rspec.info/
http://betterspecs.org/
Here's a list of some other testing frameworks.
https://www.ruby-toolbox.com/categories/testing_frameworks

Thanks for the resources.  I was looking at an rspec tutorial earlier today but was having dependency issues with many of the gems on Windows.  I'm going to look into getting a Linux environment setup to bypass these issues

Sounds good man.  Let me know if you run into anymore issues and I can try and help you get it working.

100% test coverage done courtesy of the C1 folks!


Configure Azure Pipeliness

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: giusepe22 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Don’t skip glyph 0 in cmap.

Fixes #8234.
Hopefully this won't break anything since our support for notdef is better these days.

/botio test

/botio makeref


Atom Crashes (Angular2 project / macOS)

Hi folks,
I have found many posts about Atom freezing/hanging/failing/crashing, but none really helped me since I am not very good in troubleshooting. I am on mac, thus I have gone through the logs in console, there seems to be a lot, even regarding the Atom itself, but I have no idea how to analyse that. I am using just a few plugins (mostly TypeScript related), which I would not consider demanding (but who am I to judge ....). I deal with TypeScript files mostly. My machine is MacBook Pro 2015 / 2,7 GHz Intel Core i5 / 8 GB 1867 MHz DDR3 / Intel Iris Graphics 6100 1536 MB . All I can say is that it seems to me that Atom crashes always when new linter warning appears exactly at the time when the project bundle is being compiled automatically after saving some file (automatisation is not related to Atom itself, I mostly use Angular CLI in my projects). There seems to be several different occurrences of crashing. Sometimes Atom just freezes, other times it quits and just recently, it crashed down my entire OS forcing it to restart. I am using many other tools on the very same machine (even CPU/GPU highly demanding such as VR/3D editing software) and it crashes only when Atom is on. I am sorry I am not more specific (I have decided to create this issue to be able to be more specific). I welcome any suggestion -> "How To" troubleshoot Atom crash? / What detail info to share to receive best advice? / What posts regarding Atom crashes are best to read? / What docs related to Atom crash are best to study? ... anything.
Thanks!

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Add the section Tutorials

Section Tutorials and Blender Guru Website added

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @SamuelComan, thank you for the PR! However, we do not accept PRs that only add links.
Feel free to open a new one with more content. Happy coding!


release procedures

Does ZOO-Project release procedures, i.e. steps documented to work through a release process?

We have the following section in the official documentation https://zoo-project.github.io/docs/contribute/release.html

Thanks. Added to https://github.com/ZOO-Project/ZOO-Project/wiki/ProjectGraduationChecklist


Improved DSL around shading + docs + bug fix

Improvements on #162
shading
sbt-assembly 0.14.0 adds shading support backed by Jar Jar Links.
assemblyShadeRules in assembly := Seq(
  ShadeRule.rename("org.apache.commons.io.**" -> "shadeio.@1").inAll
)

For more details see Shading.

:+1:
Found this easier to get up and running.


fix bot.py, add .gitignore

There was an exception because you tried to open("./data/settings.json") before file creator. Then I noticed that your file creator is creating LECTURFIER.json and you try to read token from LECTURFIERBETA.json.
Also added some things to .gitignore to make sure you don't push useless files. (I added the ones I think are created most often)
:)

PR done via  https://github.com/markbeep/Lecturfier/commit/562d3c4692e9d0df654cecd132189839cf59e1e0


Allow overriding echo image in tests

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@rshriram: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rshriram: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test unit-tests_istio

release-test_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test unit-tests_istio

release-test_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-test_istio

gencheck_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test unit-tests_istio

release-test_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-test_istio

gencheck_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test gencheck_istio

release-notes_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test unit-tests_istio

release-test_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-test_istio

gencheck_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test gencheck_istio

release-notes_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-notes_istio

integ-helm-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-operator-controller-tests_istio

integ-telemetry-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-ipv6-k8s-tests_istio

integ-pilot-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test analyze-tests_istio

lint_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test lint_istio

integ-distroless-k8s-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-distroless-k8s-tests_istio

unit-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test unit-tests_istio

release-test_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-test_istio

gencheck_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test gencheck_istio

release-notes_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test release-notes_istio

integ-helm-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-helm-tests_istio

integ-pilot-multicluster-tests_istio
6ee015b7a87b30d5078684fc231abebdf4e10790
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This LGTM but I don't think it will be updated unless someone takes over


lang selector is over the title on responsive splash screen

Overview
If you use ShapeShift with the Metamask mobile app, the lang selector is over the title and so it makes it difficult to read/notify that it exists

References and additional details

Use MetaMask browser on mobile
Navigate to https://app.shapeshift.com

Acceptance Criteria
TBD by @shapeshift/product
Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

I guess safe-area-inset-top won't render because it fights with the MM top bar?
ideally the thing just has the 6 px padding like mobile connector