Crowded node clusters?

One of the big appeals of using Code Connections was developing a better understanding of how modular our code was at a quick glance. It's been great for highlighting that, tangled code, and generally a sense of what regions of our repo exist - but two different issues have made the dependency graph harder to read. Maybe these should be two separate issues instead of one?

What I would call "continents" (or islands?) of code on the map are often placing nodes very close to nodes from other continents/islands - even though there are no connections between those groups/continents/islands of code. I can share a screenshot of this later, but it means that at a glance it often looks like large sections of code are associated with each other even when there are zero dependencies.

Dead end or isolated branches of code often have their connections between nodes overlap with other branches of code, even though they have no association or dependencies. It would be great if a section of code (or group of classes rather) could be identified as self contained, and then really shoot off perpendicular to the rest of the code some great distance to represent that it is isolated. This would help for onboarding new programmers and showing them what classes did/didn't touch each other more quickly.

These are all "nice to have" features, but would make a major positive impact - so I figured that would be worth mentioning! I'm interested in these two changes enough that I might attempt them on my own even and do a PR if you don't first. :) But it would be great to have your insight on these too. Thank you!

Great feedback!
Which layout were you using?

A screenshot would definitely help to understand the issue here better, if you can provide one.
For this one, I have noticed that neither layout mode makes much effort to arrange completely disconnected components of the graph in a sensible way. Not sure what the ideal approach would be, but certainly it'd be an improvement to make sure they at least don't overlap.

If you're interested in playing with the layout behaviour, the code lives here: https://github.com/davidjohnoliver/CodeConnections/tree/main/CodeConnections.Shared/Views/Graph
Both layout algorithms were forked from the GraphSharp package, with minor adjustments on my part (eg using a more stable random seed). I'm not an expert in the code since I didn't write it, but happy to provide pointers and discuss approaches if you decide to have a go. :)


Referenced Built-In Policies target Windows VMs

Hi there,
in 3.3. it talks about built-in policies.
Yet those target Windows VMs. Is this an error or will the same policies also work for Linux VMs?
Asking this question, since the document is specific for Linux VMs.
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 222c9752-476f-ed33-904f-a3e03fcb1cad
Version Independent ID: 28009364-3e6f-1641-2365-b3413676bbe2
Content: Azure security baseline for Linux Virtual Machines
Content Source: benchmark/azure/baselines/virtual-machines-linux-security-baseline.md
Service: virtual-machines
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@joeakim
Thanks for your feedback! We will investigate and update as appropriate.

@joeakim
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1

Hi again.
I am sorry, but I think you are mistaken.
The policies the documentation is referring to clearly target Windows VMs only. No Linux VMs.
But the documentation is explicitly for Linux VMs:

Here's a little snip out of the policy definitions, the rest looks the same:

For the Linux VMs I don't even see built-in policies that would target the same issue as the Windows policies address:

Therefore, this is an issue regarding the documentation, and not regarding my knowledge or understanding of this topic.
So, I kindly ask you to re-open this issue and adjust the documentation.
Thanks.

@joeakim
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@

@msmbaldwin
Can you please check and add your comments on this doc update request as applicable.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Opensuse leap

I forked rosdistro for some development work I was doing for openSUSE. Since this represents a lot of little changes @tfoote recommended opening a draft PR to give people some time to look over it.
These changes were used by my rossuse.py script to automate the generations of rpm packages for opensuse Leap 15.1 on the opensuse build service platform.
https://github.com/neotinker/rossuse
https://build.opensuse.org/project/show/home:neotinker3:ROS:melodic_test

Overall this is great to get coverage. That's a lot of rules to fill in. As a side comment I'm surprised how different the rules are for opensuse vs fedora. I'm also surprised by the number of versions that have to be pinned to specific packages in the packages.
I noticed your focus on 15.1 which from my quick searching appears to be EOL as of last month.15.2 might seem like a better target, though the 18 month cycle is very short to target.

I started this work around the time that openSUSE Leap 15.1 was released but if you look at OBS, you will see that I am using the same spec file generated for 15.1 to also build 15.2 packages.
Since there were already some opensuse definitions, I tried not to break what someone else might have been doing. That is why you will notice some definitions like this.
opensuse:
'*': [libassimp3]
'15.1': [assimp-devel]
Since I didnt know what release they were targeting, I tried to be explicit about what I was targeting. If there is no risk of breaking the work of others, I can change that to be more generic. I did try to be more generic, such as the libboost definitions.
opensuse: [libboost_atomic1_66_0]
But libraries are one place where we will most likely require OS release specific entries since the packaging guidelines for openSUSE/SLES specify putting version information as part of the name to allow having multiple versions installed in parallel.
https://en.opensuse.org/openSUSE:Shared_library_packaging_policy#Package_naming
With the upcoming release of openSUSE 15.3, the boost libraries will all be jumped to version 75. meaning it will need to be changed to something like
opensuse:
'15.1': [libboost_atomic1_66_0]
'15.2': [libboost_atomic1_66_0]
'*': [libboost_atomic1_75_0]
Assuming that we should be using the wildcard to refer to all future versions.
Any entries I created that specify a specific os release but don't have version information in the package name can most likely be changed to a more generic entry. For instance,
opensuse:
'15.1': [python3-CairoSVG]
Could most likely be changed to
opensuse: [python3-CairoSVG]
Even though it does technically have version info in the name, it isn't likely to change much.

As we'd like this effort to be sustainable it would be great to extend the CONTRIBUTING.md and REVIEW_GUIDELINES to explain how to submit rules for SUSE as well as how to review them.

I can look into updating these.

It will still be best effort, but a pointer where to find an index of the packages for comparison is important for reviewing as well as non-suse users to find equivalent packages quickly since the easier it is the more likely people will voluntarily take the time to fill it in.
Once we've reviewed that process updates then the individual rules can be processed in small batches with links to the packages for reviewing.

Yes the wildcards are usually used for future compatibility. The boost example is a good best practice.
With respect to the older targets and persistence. The most recent commits in a quick search are from 2017 and before that most were from 2014 which suggests that they're long EOL.  If you can guess what target they are for, our usual approach is to use explicit rules for older versions and keep the wildcard for the expected newest/future version. With the existing rules age I think that modernizing them w/o backwards compatibility makes more sense.
If you have the believe that something is unlikely to change sticking with the generic tag is recommended. Otherwise the rules will have to be updated for each upcoming release.

@tfoote makes some good points; I'll suggest updating your changes to take them into account.
In terms of actually getting this committed, it would be much easier to do this in smaller chunks.  My suggestion is that you take small groups of rosdep rules (maybe no more than 20 at a time), and open a PR for that.  Also make sure to add links to the Opensuse packages so it is easy for reviewers to look at them.
That way we can slowly get the full support into the rosdep database.

I started this work around the time that openSUSE Leap 15.1 was released but if you look at OBS, you will see that I am using the same spec file generated for 15.1 to also build 15.2 packages.

Are 15.x releases compatible? Can we target openSUSE Leap 15 rather than 15.x?

I started this work around the time that openSUSE Leap 15.1 was released but if you look at OBS, you will see that I am using the same spec file generated for 15.1 to also build 15.2 packages.

Are 15.x releases compatible? Can we target openSUSE Leap 15 rather than 15.x?

If you mean can you compile it once for '15' and have it run on any '15.x', the short answer is no. They try to maintain compatibility between minor releases but there is no guarantee. The situation should get better in the future with SUSE's push to make openSUSE follow SLES more closely.
https://en.opensuse.org/Portal:Leap/FAQ/ClosingTheLeapGap
The goal is SLES + SUSE Packagehub = openSUSE
I just got lucky between '15.1' and '15.2'. The spec files I generated for opensuse 15.1 work to compile and package rpms for opensuse 15.2, so far. And as I mentioned earlier, there will be some incompatible file names for '15.3'.
I intend to update everything to 15.2 and 15.3 once I pushed my current changes. Updating for '15.2' and '15.3' should require minimal additional changes.

I'm going to go ahead and close this one, as the discussion has seemed to have stopped and in its current form it can't be merged.  Feel free to reopen, keep commenting, or open smaller PRs to start feeding this into rosdistro.  Thanks for the contribution.


Gpt model for append

use({
		"robitx/gp.nvim",
		config = function()
			require("gp").setup({
				openai_api_key = os.getenv("OPENAI_API_KEY"),
				chat_model = "gpt-4",
				chat_topic_gen_model = "gpt-4",
				command_model = "gpt-4",
				command_system_prompt = "You are a code editor. Only return the edited code. Do not explain your response"
			})
		end,
	})

Firstly, great work on the plugin. Thank you.
I have this setup and I'm almost certain that the model isn't updating for prepend/append functions. Do you have any idea why? It seems to be using gpt-3 still, as far as I can tell from my open AI usage report.
Also I set this command system prompt, as I'm finding when it attempts to append/prepend, it often adds explanatory words in, where I just want code.

@claidler Hey, when you call some gp command, you can run :GpInspectPlugin afterwards and see among other things the raw _payload which was send to Open AI - do you see gpt4 there?

@Robitx thanks for the tip. I'm not sure if you've changed anything, but I ran PackerUpdate and it seems to be working now to update the model/config. Possibly I needed to run something to get the config to update and I wasn't aware. I'm not sure. It's done anyway. I did noticed though a separate issue FYI.
https://github.com/Robitx/gp.nvim/assets/43636691/fc3dbb8d-4c6d-4e42-88a8-81cbd96a7e97
You see prepend is adding the current line also. Are you seeing this?

@claidler Yes, you're right. I mostly use rewrite, so that append/prepend suffered a bit of negligence. :slightly_smiling_face:
I've added custom templates for append and prepend which tells the gpt to not repeat the snippet it was provided with. Try the latest version.

That does the trick @Robitx thanks )


Prevent editor crash due to modify the order of non-instance shader uniforms by instance uniforms

Order is ignored for them but the code is modifying the order for other uniforms which lead to a crash. Fix #40812

Thanks!

Thanks!


Using tmt host outside of Fedora, RHEL, CentOS

In theory there shouldn't be issues but let's try that first and document what should be installed to make tmt work.
E.g. Install tmt from pypi and use it to run tests on Fedora.
Provision:
virtual
beaker
container
connect
minute (internal one)
Provision 'local' connects to the host so it will require same work as supporting non-rpm guests (tracked in #1951 )

The apt install podman helped to create the container but then it fails with chcon (supposedly to be fixed by #1930 )

minute seems to work without any issues

artemis is missing from the list, but it should be doing fine. it installs nothing, and Artemis calls ssh and that's all.

I've tried with #1930 and tmt works nicely.
I had to install libkrb5-dev as well (seems that mrack wanted that)


fixed a bug where the modeler would assign modelData to the modeled e…

…ntity, causing changes made in the ctor to be overridden

Closing because I created a new PR that accomplishes the same thing.


RELATED: FET-793 Upgrade to node16

Currently destined for release R247.
This release is zero downtime release.
Code drop: 2022-02-24 00:00.

Story FET-793 Upgrade gd infrastructure to node 16
Status: Hacking
Priority: Major
Assignee: Petr Benes

client-libs/gooddata-typings-pull-request-compliance-check check failed
require-copyright
Invalid or missing copyright, refer GoodData Copyright Instructions

file modified: .nvmrc

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-pull-request-compliance-check/157/ : SUCCESS in 5s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-oss-check/12/ : SUCCESS in 6s
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/250/ : SUCCESS in 1m 10s

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-pull-request-compliance-check/158/ : SUCCESS in 3s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-oss-check/13/ : SUCCESS in 6s
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/251/ : SUCCESS in 42s

Sonar scan result
More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-typings-gate-PR89
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-pull-request-compliance-gate/55/ : SUCCESS in 3s
https://checklist.intgdc.com/job/client-libs/job/gooddata-typings-unit-tests-zuul-docker-el7/252/ : SUCCESS in 2m 15s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-sonarqube-scan-zuul-gate/5/ : SUCCESS in 33s
https://checklist.intgdc.com/job/compliance/job/gooddata-typings-fossa-scanning-zuul-el7/18/ : SUCCESS in 2m 07s (non-voting)


Add a field to the API endpoint /api/pages/{id} to get the raw html

API Endpoint or Feature
Add a field (raw_html) to the API endpoint /api/pages/{id} to get the raw html (with includes ids on it, not the replaced html)
Use-Case
I am creating a database to keep track of reused content so, if anyone deletes that content, he gets notified that the content that he's about to delete is reused in a given page.
As this tracking is not in the roadmap, I'm building this in a django external system, but I need that field in the endpoint to get the data I need.
Additional context
No response

This is something otherwise it's not possible to reliably create an external page editor, or even a proper fetch + update flow, without messing up include tags.

Same need with different Use Case here.
At IN2P3-CC, we're planning to manage part of our documentation from Gitlab.
CI/CD jobs would update Bookstack according to the Gitlab repository content which acts as our source of truth.
Our tool produces html that is sent to the Bookstack page API.
Since the html returned by a get page API is slightly modified, our tool is unable to detect (without heavy html introspection) if a page should be updated or not. Indeed remote page HTML always differs from locally generated HTML.
The solution we're planing to use updates the page on each call. As you may expect, this is not ideal and pollutes Activity Log.
If we are given access to the exact HTML that was initially sent to Bookstack, the problem vanishes.

I have now added this within 8b935e71d14ca985691ad5f8b2b4262f6f36454e, and it will be part of the next release.
Thanks @deleyva for the original request here.

@riton Just a note on your use-case, this new property will provide the raw html stored in the BookStack database.
BookStack does do some pre-storage-processing of HTML content too, meaning this won't provide the exact HTML that was originally sent to BookStack. Specifically supporting that use-case would be a more substantial request that I would not be sure about including.
Since it sounds like you just need to check if the content matches your Gitlab side of things (One-direction check), here's a potential creative workaround:
Create a hash for the incoming gitlab content on change. Store that hash (locally to API system, or could sneak it into BookStack content or as a page tag), then on next update, compare the existing hash (if exists) to the new Gitlab content hash, update only if hashes differ.

As suggested by @ssddanbrown

Create a hash for the incoming gitlab content on change. Store that hash (locally to API system, or could sneak it into BookStack content or as a page tag), then on next update, compare the existing hash (if exists) to the new Gitlab content hash, update only if hashes differ.

We're appending a <meta name="page-cksum" content="XXXXX"> (not in the <head> section of the HTML Page, but :shrug: ) to each Page generated through our C.I / C.D system. Works like a charm :+1:


feat(cell): Add unit tests for GEMM.

This test for GEMM involves:

[x] Loading a data tile from global memory to shared memory.
[x] Chunking shared memory using the TileIterator.
[x] Loading the data tile from shared memory to register.
[x] Computing GEMM using Tensor Core's WMMA.
[x] Storing the data tile from register to shared memory.
[x] Storing the data tile from shared memory to global memory.
[ ] pass unittest.

This PR relies on the prior merge of https://github.com/TiledTensor/TiledCUDA/pull/83.

close this pr and move it into a neat one.


Common string logic for org.dita.pdf2 fails to retrieve a string for "Task Result"

The PDF code looks for "task_result" in the common strings. Unfortunately, ~/xsl/common/strings-en-us.xml has no str named "task_result" even though it does have a str named "task_results".

String is used by src/main/plugins/org.dita.pdf2/xsl/fo/task-elements.xsl.


useSimulateContract hook parameters typing

Describe the bug
Hi. I am using wagmi on my dApp and I am trying to call a useWriteContract. As I read in docs you can call useSimulateContract before calling writeContract. As the documentation suggests useSimulateContract has these parameters:
{     abi,     address: '0x6b175474e89094c44da98b954eedeac495271d0f',     functionName: 'transferFrom',     args: [       '0xd2135CfB216b74109775236E36d4b433F1DF507B',       '0xA0Cf798816D4b9b9866b5330EEa46a18382f251e',       123n,     ],   }
but when I use this in my code I only get these parameters:

and when I try to add abi and functionName manually it doesn't show any errors but also it doesn't generate functionName type as expected.
Link to Minimal Reproducible Example
No response
Steps To Reproduce
const { data } = useSimulateContract({});
Wagmi Version
2.5.7
Viem Version
2.8.4
TypeScript Version
5.4.2
Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?
No response

This is an issue with Viem's types and<EMAIL_ADDRESS>In the meantime, you can downgrade to<EMAIL_ADDRESS>and it should work.

This is an issue with Viem's types and<EMAIL_ADDRESS>In the meantime, you can downgrade to<EMAIL_ADDRESS>and it should work.

Tried this but unfortunately still got the problem

Seems to work fine for me. Happy to look into this further if you can create a minimal reproducible example via a breaking type test.


Log scaled histograms readability with default display.mpl_style can be improved

I use quite frequently log scaled histograms with histtype='step' option.
I noticed that with the suggested default display.mpl_style (which I like), readability of such histograms is quite improvable.
Consider this (from ipython notebook)
%pylab inline

import pandas as pd
import numpy as np
import matplotlib
import matplotlib.pyplot as plt

matplotlib.rcParams['savefig.dpi'] = 300

pd.set_option('display.mpl_style', 'default')

val = np.random.normal(size=1000000)
val2 = np.random.normal(scale = .5, size=1000000)
df = pd.DataFrame({'A' : val , 'B' : val2 , 'C' : val2})

df.hist(bins = 80, log=True,histtype='step')

plt.figure()
df.A.hist(bins = 80 , log=True,histtype='step',normed=True )
df.B.hist(bins = 80 , log=True,histtype='step',normed=True )

The secondary grid looks too thick and confusing; IMHO it damages readability. This problem shows up only with log scaled hist.
Consider the following as a comparison

Closing this since display.mpl_style is deprecated now


[cudaaligner] Fixed a bug in approximate alignment backtrace

Fixed the bug causing a failing assert found by @r-mafi .

changes look good to me overall! just left a clarifying question for the test


Improve health detection of /-/healthy endpoint

We're trying to find the best way to monitor prometheus itself.  We were evaluating using the /healthy and /ready endpoints.  But we have a case where prometheus was failed, yet the endpoints still reported back as healthy.
What did you do?
Used Prometheus 2.0, ran out of disk space.
What did you expect to see?
I expected to see prometheus marked unhealthy when querying the /-/healthy endpoint.
What did you see instead? Under which circumstances?
Prometheus responded "Prometheus is Healthy."
Environment

RHEL/OpenShift

System information:
Linux 3.10.0-693.11.6.el7.x86_64 x86_64

Prometheus version:
prometheus:v2.0.0

Logs:

level=error ts=2018-02-05T21:42:18.480373214Z caller=wal.go:713 component=tsdb msg="sync failed" err="flush buffer: write data/wal/000001: file already closed"
level=warn ts=2018-02-05T21:42:21.495046779Z caller=scrape.go:673 component="target manager" scrape_pool=kubernetes-service-endpoints target=https://<IP_ADDRESS>:8443/metrics msg="append failed" err="WAL log samples: log series: write data/wal/000001: file already closed"

I think tsdb is out of scope here so removed the local storage label.

I can confirm this is still an issue with latest stable (tested 2.15.1). Encountering a disk-full event with Prometheus is really bad from an ops situation on two more aspects imo:

VERY spammy logs, multiple lines per second. Why keep trying for every single write over and over?
No exit, keeps running. Process manager thinks everything is OK. Why not exit status > 0?
Liveness / health check says OK. (That's what this issue is about.)

If your disk has filled up, you're already in a really bad place. You should aim to avoid getting into that situation, rather than trying to rearrange the deckchairs when it happen. For example on restart Prometheus will still have a full disk.

If your disk has filled up, you're already in a really bad place. You should aim to avoid getting into that situation, rather than trying to rearrange the deckchairs when it happen. For example on restart Prometheus will still have a full disk.

 But that doesn't mean the process has to continue running and pretend everything is OK.

Yep , don't see how a restart improves anything. Setup some node monitoring and alerting when it reached some thresholds for CPU/RAM/HDD

I do not think prometheus in this situation should exit.
There should be a alert when the storage hits some threshold and storage should be expanded.

yep and this is the logic we followed to make Prom just log errors instead of exit as AFAIC come storages can be expanded dinamicly so the whole process could be automated - an alert -> expand storage -> happy end :)

Dupe of #3650


Feature/documentation updates

Hi, could you please review my changes?

broken links on theme_product_development

on all initiatives, broken links to epics

broken link on epic_legal_compliance.md for Story 1

make bullet points for stories' acceptance criteria for readability

add title for initiative_legal_technical_website_template.md


Is faceid adapter compatible with controlnet, in diffusers?

I try use faceid with controlnet, but got this issue, I can't figure out why there is something error with time embedding ?

yes, it is compatible with controlnet


Fix: When the language changes, we should not change the focused inde…

…x in a list

Details

We check if the upadte is due to a language change and if it's the case we don't change the focused index in a list, we still update the list just in case in the future options are translated
Fixed Issues

$ https://github.com/Expensify/App/issues/21538
PROPOSAL: https://github.com/Expensify/App/issues/21538#issuecomment-1640687619
Tests

Open the app in two devices or tab A and B (same user)
In tab A click on the fab button
Select Request money
Type an amount and click on Next
On the particpants list focus a participant without selecting it, with the arrows of the keyboard for example (I am not sure how to do it for device without keyboard)
Go to tab B and change the language in setings
Verify that the participant that was highlighted is still highlighted

[x] Verify that no errors appear in the JS console

Offline tests

No Offline test because the language change will not be seen on tab A
QA Steps

Open the app in two devices or tab A and B (same user)
In tab A click on the fab button
Select Request money
Type an amount and click on Next
On the particpants list focus a participant without selecting it, with the arrows of the keyboard for example (I am not sure how to do it for device without keyboard)
Go to tab B and change the language in setings
Verify that the participant that was highlighted is still highlighted

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/19537677/9d97311d-3a22-47bb-9305-4d0cf25b85bb

Mobile Web - Chrome

https://github.com/Expensify/App/assets/19537677/a6bea5a5-9dfe-4280-911d-1f461d2a0d5c

Mobile Web - Safari

https://github.com/Expensify/App/assets/19537677/21758006-87ed-4905-b59c-36290ba7771b

Desktop

https://github.com/Expensify/App/assets/19537677/a32acebc-a2e0-4b43-af62-43e95d11ede2

iOS

https://github.com/Expensify/App/assets/19537677/788aeb08-f4f5-41e1-a25d-f11fd6956df0

Android
https://github.com/Expensify/App/assets/19537677/a45f9a1e-b62f-497e-9548-26616dd60df1

@aimane-chnaif PR ready for review

I made the changes

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Release version 0.3.19

Description
Add Changelog for release 0.3.19
References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

/ok-to-test shat=fb07755

/ok-to-test sha=fb07755


Testing component with Enzyme gives <t /> name

Hi guys, I have a component that includes the <DatePicker /> component and am trying to test to make sure it is there. I am using Enzyme (with shallow wrapper) to test it. Usually I do the following to check the existence of a certain component:
expect(
  enzymeWrapper.find('DatePicker').length
).toBe(1)

My expectation is to find the DatePicker by its component name -- "DatePicker" -- however it is showing up with simply a "t" for its name, as demonstrated by console logging the node for the component (I did manual, exact search using .children() and .at()):
.text():
<t />

.name():
t

(1) Why isn't the component name just DatePicker?
(2) Is there a specific way to check for the existence of a DatePicker component inside mine using Enzyme and its find method?
(PS: my tests work properly if I search using component.find('t'), but why on earth would you have that single letter for a component name?)

Looks to me like the cause of this is that the package.json's main field is pointing to dist/react-datepicker.min.js — the minified file. Instead, I believe that should point to dist/react-datepicker.js, and leave it to the user to minify.
@nbkhope My workaround for now is to require('react-datepicker/dist/react-datepicker') directly.

the react 16.0.0 has not this problem


selfExe has been deprecated since 1.7, using getCurrentCompilerExe in…

…stead

per the docs comment https://nim-lang.github.io/Nim/nimscript.html#selfExe

Thanks, but change it in the actual build cmd as well no?


allcontrib

Let's add the current contributors

@all-contributors please add @destruc7i0n for code

@all-contributors please add @yrsegal for code


Export ReactSortableTree without dnd wrapper

In some cases it is necessary to provide the dnd wrapper explicitly and it would be useful if the plain, unwrapped component would be available as well.
Cf. issue #5 for details.
The name UnwrappedSortableTree is up for discussion.

Thank you for the PR and sorry about the delay. I had a bit of trouble wrapping my head around the issue, so I left it until after the holidays.
I changed the name of the variable to SortableTreeWithoutDndContext and released it in v0.1.11.

@fritz-c Happy new year! Thank you for merging this. I like your variable name even better. :+1:


Allow a specific start time to be used with startSpan

Goal
Add the ability to specify a start time that was added to EmbraceSpan.start() to startSpan()
Testing
Added appropriate component tests and also to the integration test

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#456  👈
#455
#454
master

This stack of pull requests is managed by Graphite.

Merge activity

Feb 23, 10:55 AM EST: @bidetofevil started a stack merge that includes this pull request via Graphite.


Add lin_samples.csv

Based on https://github.com/ome/ome2024-ngff-challenge/pull/54#issuecomment-2430293833, @tstoeter I'm moved the lin.csv file here since this was causing our sync issue. You might want to remove your copy to avoid confusion.
@will-moore, can you look over this?

I ran python load_zarr_stats.py lin_samples.csv on a local copy of the csv to give me the extra columns for the viewer:
lin_output.csv
```
url,written,written_human_readable,shape,shards,chunks,dimension_names,license,name,description,organismId,fbbiId
https://radosgw.public.os.wwu.de/ta3-bucket/150715_DBE_Drosi_CherryCAAX_nSybGal4/L3_nsybG4xcherryCAAXmerged.ims.zarr,2217337815,2.1G,"1,1,707,4127,12497","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,,,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/150421_DBE_L3_C155xCherryDlgS97/stiched_1.ims.zarr,4846235826,4.6G,"1,2,367,6097,9665","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,dataset name,dataset description,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/2014_07_04_Drosi_hole_larve_GFP/Larve_2_20x095_Z1_4096_BAPP_with_cslip.lif.zarr,1631354605,1.6G,"1,1,316,4096,4096","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,,,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/2014_07_04_Drosi_hole_larve_GFP/Larve_2_20x095_Z2_2048_BAPP_wo_cslip.lif.zarr,1127129565,1.1G,"1,2,155,2048,2048","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,,,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/150709_DBE_Drosi_CherryCAAX_OK371/DBE_Drosi_L3_OK371xcherryCAAX_merged.ims.zarr,5541964433,5.2G,"1,1,701,4224,15308","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,dataset name,dataset description,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/140721_Drosi_whole_larve_BABB/Drosi_holeLarve_20x095_2048_Z1.lif.zarr,29151733841,28G,"1,1,1,3912,849","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,dataset name,dataset description,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/Larvae_2_10x_Z1_25_2048.lif.zarr,9860876320,9.2G,"1,1,490,2048,2048","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,,,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/Drosi_Larvae_Tiles_2.lif.zarr,9731243347,9.1G,"1,1,525,4096,4096","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,,,NCBI:txid7227,obo:FBbi_00000369
https://radosgw.public.os.wwu.de/ta3-bucket/a114.zarr,37860247330,36G,"1,2,4065,2048,2048","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,Rat brain,Rat brain cleared using 3DISCO protocol and imaged using light sheet microscopy.,obo:NCBITaxon_10117,obo:OBI_0003098
https://radosgw.public.os.wwu.de/ta3-bucket/a115.zarr,35816681857,34G,"1,2,3996,2048,2048","1,1,1,2048,2048","1,1,1,256,256","t,c,z,y,x",https://creativecommons.org/licenses/by/4.0/,Rat brain,Rat brain cleared using 3DISCO protocol and imaged using light sheet microscopy.,obo:NCBITaxon_10117,obo:OBI_0003098
```

Then served this copy and opened in the samples viewer, but I'm seeing no thumbnails due to CORS issues for all the chunks. Same in vizarr - metadata (zarr.json) loads OK but no chunks:

Fixed CORS and pushed stats, @will-moore: https://ome.github.io/ome2024-ngff-challenge/?csv=https://raw.githubusercontent.com/joshmoore/ome2024-ngff-challenge/lin-samples/samples/lin_samples.csv is looking better. Merging.

Strike that: my push failed?! (conference network)
ssh_dispatch_run_fatal: Connection to <IP_ADDRESS> port 22: Operation timed out

d56738202c759248b29b5697774c51c72bd0cf4b pushed


K8s Resource Management

K8s Resource Management

K8s Resource Management

@kevinintel Is this referring to DRA or something else?

Current activities regarding K8s resource management include:

Applying of container runtime Node Resource Interface (NRI) (https://github.com/containerd/nri) and its reference policies for efficient management of CPU resources. This is done for both SPR-only OPEA and also Gaudi accelerate case. The objective is to improve node throughput and also use CPU resources as affectively as possible to leave room for adjacent services. The first PR (https://github.com/opea-project/GenAIEval/pull/73) was merged to OPEA v0.9 release and this will further enhanced in the forthcoming releases.
Applying new Gaudi Dynamic Resource Allocation (DRA) driver (https://github.com/intel/intel-resource-drivers-for-kubernetes/blob/main/doc/gaudi/README.md) for OPEA workloads. This has now been validate to work with Gaudi accelerated OPEA ChatQnA service.

Is there something else that should be considered?

There are also other related issues:
Same topic for GenAIInfra: https://github.com/opea-project/GenAIInfra/issues/144
https://github.com/opea-project/GenAIEval/issues/57
https://github.com/opea-project/GenAIEval/issues/58
I think we should consolidate or define the exact scope for each of these issues.

V0.9 https://github.com/opea-project/GenAIEval/issues/57
V1.0 https://github.com/opea-project/GenAIInfra/issues/144
Q1/25: https://github.com/opea-project/GenAIEval/issues/58
this issue tracks the status


Implement grid modifier potions

Fully implements the previously unobtainable grid modifier potions, including recipes, proper effect icons, and a book entry.

Moved to #788


No License

As this repository does not yet have a license, no one is allowed to use or edit this repository without explicit consent from the owner. The previous repository of this template had an MIT license, but this one has no such thing.
From GitHub's https://choosealicense.com/no-permission/

Unless you include a license that specifies otherwise, nobody else can copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you.

Thanks, I indeed forgot this! License is added 🙏


Add non-development messages to documentation and readme

(see also https://github.com/ContinuumIO/libhdfs3-downstream/commit/012f624d50e90bfd3e65dec30d9edf552bae2cc1 )


docker-compose fails with settings.py

For dev env. it is given to copy the settings.py.
I could not make it work without the copy step in docker-compose test env., too.

you're right. we hardly notice because it's enough to copy the file once, then it always works!

it's odd though; i'm pretty sure this was only required for dev env, due to a permission issue with the docker volume. in release mode it's done in Dockerfile.django:
RUN \
  cp dojo/settings/settings.dist.py dojo/settings/settings.py

this needs further analysis...

@wurstbrot  see comments in https://github.com/DefectDojo/django-DefectDojo/pull/1473

I do think it is required. I tried a try run
git clone
cd django...
git checkout dev
docker-compose up --build
I get the following:
celeryworker_1  |
celeryworker_1  | Traceback (most recent call last):
celeryworker_1  |   File "manage.py", line 10, in <module>
celeryworker_1  |     execute_from_command_line(sys.argv)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
celeryworker_1  |     utility.execute()
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/core/management/__init__.py", line 375, in execute
celeryworker_1  |     self.fetch_command(subcommand).run_from_argv(self.argv)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/core/management/base.py", line 336, in run_from_argv
celeryworker_1  |     connections.close_all()
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/utils.py", line 219, in close_all
celeryworker_1  |     for alias in self:
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/utils.py", line 213, in __iter__
celeryworker_1  |     return iter(self.databases)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/utils/functional.py", line 80, in __get__
celeryworker_1  |     res = instance.__dict__[self.name] = self.func(instance)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/db/utils.py", line 147, in databases
celeryworker_1  |     self._databases = settings.DATABASES
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/conf/__init__.py", line 79, in __getattr__
celeryworker_1  |     self._setup(name)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/conf/__init__.py", line 66, in _setup
celeryworker_1  |     self._wrapped = Settings(settings_module)
celeryworker_1  |   File "/usr/local/lib/python3.5/site-packages/django/conf/__init__.py", line 157, in __init__
celeryworker_1  |     mod = importlib.import_module(self.SETTINGS_MODULE)
celeryworker_1  |   File "/usr/local/lib/python3.5/importlib/__init__.py", line 126, in import_module
celeryworker_1  |     return _bootstrap._gcd_import(name[level:], package, level)
celeryworker_1  |   File "<frozen importlib._bootstrap>", line 985, in _gcd_import
celeryworker_1  |   File "<frozen importlib._bootstrap>", line 968, in _find_and_load
celeryworker_1  |   File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
celeryworker_1  | ImportError: No module named 'dojo.settings.settings'

@wurstbrot  you need to remove the override link too:
docker-compose.override.yml
this is fixed in https://github.com/DefectDojo/django-DefectDojo/pull/1479

See my comment in https://github.com/DefectDojo/django-DefectDojo/pull/1479

https://github.com/DefectDojo/django-DefectDojo/pull/1483 should fix this

@wurstbrot are you OK to close this one? thanks!

haven't tested it but I belive you ;)


Parsed query before schema.execute

Hi,
Recently when I am building my app, I encounter a use case where I would like to know the parsed query before calling schema.execute. Specifically, somewhere before this line:
https://github.com/async-graphql/examples/blob/b36b5c44543b7323cb199ed229ea247e83b85d18/warp/token-from-header/src/main.rs#L48
Thank you for your help,

Do you want to get the AST of the parsed query?

Thanks for your reply @sunli829
mutation {
  createStore (...) {
    ...
  }
}

Currently I would like to know if a query is of type createStore or not.

Basically I would like to do something before certain types of query.
i.e. access header, add data enhancement, etc.. very similar to authentication workflow.

Thanks for your reply @sunli829
mutation {
  createStore (...) {
    ...
  }
}

Currently I would like to know if a query is of type createStore or not.

This is too much trouble, I recommend you to refer to this example.
https://github.com/async-graphql/examples/blob/b36b5c44543b7323cb199ed229ea247e83b85d18/actix-web/token-from-header/src/main.rs#L25

Yeah right, thanks @sunli829
I thought about this after posting the question.

Hi @sunli829 do you recommend a way if I want to write something back into the response headers?

https://docs.rs/async-graphql/2.5.7/async_graphql/context/struct.ContextBase.html#method.append_http_header

Great thanks @sunli829 👍


Style/ConditionalAssignment triggers RuboCop parsing error in specific circumstances

It's bit difficult to explain this in the title itself. Found a piece of code in a Chef recipe triggering an issue in RuboCop. A simplified representation of this code is:
default['key-with-dash'] = []

dirs.each do |dir|
  if user == system_user
    default['key-with-dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path1/#{dir}"
    }
  else
    default['key-with-dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path2/#{dir}"
    }
  end
end

$ rubocop
Inspecting 1 file
An error occurred while Style/ConditionalAssignment cop was inspecting /Users/user/path/code.rb.
To see the complete backtrace run rubocop -d.
.

1 file inspected, no offenses detected

1 error occurred:
An error occurred while Style/ConditionalAssignment cop was inspecting /Users/user/path/code.rb.
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.
Mention the following information in the issue report:
0.37.2 (using Parser <IP_ADDRESS>, running on ruby 2.1.6 x86_64-darwin12.0)

The reported error in the backtrace is:
empty range in char class: /default['key-with-dash']\s*<<\s*/

To break the parser, the "default" array key needs to have dashes. This code doesn't trigger any issue:
default['key_without_dash'] = []

dirs.each do |dir|
  if user == system_user
    default['key_without_dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path1/#{dir}"
    }
  else
    default['key_without_dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path2/#{dir}"
    }
  end
end

rubocop
Inspecting 1 file
.

1 file inspected, no offenses detected

The issue appeared after upgrading to ChefDK 0.11.0 which bundles the latest RuboCop. Built a ChefDK 0.10.0 POC in Test Kitchen which doesn't have this issue:
[kitchen@cfaf8d46339e ~]$ rubocop
warning: parser/current is loading parser/ruby21, which recognizes
warning: 2.1.7-compliant syntax, but you are running 2.1.6.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
Inspecting 1 file
.

1 file inspected, no offenses detected
[kitchen@cfaf8d46339e ~]$ rubocop -V
warning: parser/current is loading parser/ruby21, which recognizes
warning: 2.1.7-compliant syntax, but you are running 2.1.6.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
0.34.2 (using Parser <IP_ADDRESS>, running on ruby 2.1.6 x86_64-linux)
[kitchen@cfaf8d46339e ~]$ cat code.rb
default['key-with-dash'] = []

dirs.each do |dir|
  if user == system_user
    default['key-with-dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path1/#{dir}"
    }
  else
    default['key-with-dash'] << {
      'owner' => user,
      'group' => 'group',
      'dir' => "/path2/#{dir}"
    }
  end
end

# rubocop:disable Style/ConditionalAssignment does not workaround the issue. Style/ConditionalAssignment needs to be disabled in .rubocop.yml. Tried to wrap the code with disable/enable inline statements. Rubocop correctly reports "Unnecessary disabling of Style/ConditionalAssignment" even though the parsing failure is triggered by this cop.

Thanks for the bug report. Just pushed a fix to my open PR.


Unable to Add Template with Hyphens in Name

I can't seem to get the button plugin to work if my template has a - hyphen in the name, it just says that it can't find the specified template.
Could you add something like "" quotations to pull the file names so I wouldn't have to rename files?

I will take a look at why it is failing. Do you have a example file name so I can reproduce?
Mainly wondering if it is
action My - Template
Or
action My-Template

Ah it is My - Template. I'll take a look tomorrow at why that might be failing. If I can't fix I'll support wrapping in "".

Not sure if maybe - or spaces and -, but the title of my template was Tuning-Standard Template and this wasn't really loading in.

Can you paste in the whole button code when you have a moment? I just tried:
Tuning-Standard Template
And it loaded in the note contents.

Oof if this is user error, that's embarrassing but this is what I put:
name Tab
type prepend template
action Tuning-Standard Template

I'm going to add a "add button template" command and do some better handling of arguments to try and reduce potential errors in the future. LMK if you have any other issues.

Actually I think I realized what the error is! It's not the hyphen -, I have some templates in subfolders inside the template folder. Any of those files in a subfolder bring up the error, regardless of name.


there is not enough subscription for the sort click event

I need to subscribe on sort click event in header column when you click it for table sort. After reading docs i found that hook headerEvents: onClick triggered on such header columns where - sort: false.

@massmediagroup-28 sorry for lately reply, we must implement this feature in Q1. Right now, I can promise when I can finish it, maybe this ned of month or beginning of next month, I'll mention herea again when we finish it, thanks

New Release: https://react-bootstrap-table.github.io/react-bootstrap-table2/blog/2018/02/14/version-bump.html
For this issue, check this > https://github.com/react-bootstrap-table/react-bootstrap-table2/blob/master/packages/react-bootstrap-table2-example/examples/sort/sort-events.js#L18
Let me know if theres any problem, thanks


x/pkgsite: FR: add trust signals from deps.dev, OpenSSF

I'm posting this as a public issue to get a sense of community interest in this feature request.
What is the URL of the page with the issue?
Any package page, for example: https://pkg.go.dev/cloud.google.com/go/bigtable
What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36
Screenshot

What did you do?

Looked for more information about whether this package is trustworthy.
What did you expect to see?
The deps.dev page for this package has lots of useful information, notably the OpenSSF scorecard:
https://deps.dev/go/cloud.google.com%2Fgo%2Fbigtable/v1.10.1

What did you see instead?
We should consider whether pkg.go.dev should display the same info, perhaps fetched via deps.dev's API, if it exposes this.

Would it be better if we embedded a link into pkgs.go.dev?

I think we want users to see all the information they need to evaluate a
package on pkg.go.dev, particularly in search results.
We might also be interested in signals from other sources like
goreportcard.com. We don't want the user to have to bounce between several
sites to make their decision.
S
On Sun, Aug 22, 2021 at 12:41 PM Chaitanya Munukutla <
@.***> wrote:

Would it be better if we embedded a link into pkgs.go.dev?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/47463#issuecomment-903296262, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACKIVXKS2SOSBPSOH7VDH73T6ESCHANCNFSM5BG5N5DA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


osx single file executable crashes

if I run ./build_osx.sh, the dvc executable crashes on startup; the relevant message seems to be
./dist/dvc
Traceback (most recent call last):
  File "dvc2.py", line 13, in <module>
    from dvc.command.data_import import CmdDataImport
  File "/private/var/folders/r9/4rd8csvj56s12zg3vdm360ym0000gn/T/pip-build-kSJs7p/pyinstaller/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "dvc/command/data_import.py", line 8, in <module>
    from dvc.command.data_sync import sizeof_fmt
  File "/private/var/folders/r9/4rd8csvj56s12zg3vdm360ym0000gn/T/pip-build-kSJs7p/pyinstaller/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "dvc/command/data_sync.py", line 6, in <module>
    from google.cloud import storage as gc
  File "/private/var/folders/r9/4rd8csvj56s12zg3vdm360ym0000gn/T/pip-build-kSJs7p/pyinstaller/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "site-packages/google/cloud/storage/__init__.py", line 35, in <module>
  File "site-packages/pkg_resources/__init__.py", line 552, in get_distribution
  File "site-packages/pkg_resources/__init__.py", line 426, in get_provider
  File "site-packages/pkg_resources/__init__.py", line 968, in require
  File "site-packages/pkg_resources/__init__.py", line 854, in resolve
pkg_resources.DistributionNotFound: The 'google-cloud-storage' distribution was not found and is required by the application

Probably related to
google/cloud/storage/__init__.py
35:__version__ = get_distribution('google-cloud-storage').version

Does the tool produce executable file?
Do we need packages?
pkg for Mac
msi for windows
some binary installer for Linux


Add IEEE DAPPS presentation

Add IEEE DAPPS presentation.
Add list of past publications and conferences.

"D=6/12"? Shouldn't it be "D=4/8" with ideal tuned for D=6?

good catch. will fix


cpython to pyd binary - "long" converted to "int" badly before shift / division operator

cython 0.29
python 3.6.6
compiler mingw-w64
os windows 7
command used:
python setup.py build_ext --inplace
setup.py:
from distutils.core import setup
from distutils.extension import Extension
from Cython.Build import cythonize
extensions = [Extension("shiftoperator", ['shiftoperator.py']]
setup(
    ext_modules=cythonize(extensions)
)

shiftoperator.py:
#!python
#cython: language_level=3
def longtoint():
    value = 80082 # int using more than 2 bytes == long
    print(value)
    shiftedby3 = value>>3
    dividedby8 = value//8
    print(shiftedby3)
    print(dividedby8)
    shiftedby3 = 80082>>3
    dividedby8 = 80082//8
    print(shiftedby3)
    print(dividedby8)

test_shift.py
import shiftoperator
shiftoperator.longtoint()

with cpython shiftoperator.py library used:
C:\scripts\tests>python test_shift.py
80082
10010
10010
10010
10010

with binary shiftoperator.cp36-win_amd64.pyd used:
C:\scripts\tests>python test_shift.py
80082
1818
1818
10010
10010

it seems the higher bit (65536 before shifting / 8192 after shifting) is dropped before the shifting process is done in case original long is saved on a variable
Can you check?
Thks

Thanks for the report. However, I cannot reproduce it, neither locally nor on Windows. Might be related to mingw specifically. The 15 bit boundary is indeed special for PyLong integers, which can use 15 or 30 bit digits internally. I've seen mismatches between the CPython build and extension builds before, where CPython was using a different PyLong digit size than what the extension module build assumed. If that happens, there isn't really something Cython can do about it. It's basically a broken build setup. Like trying to compose an application of C code that assumes a 32bit int with code based on 16bit ints.
Could you verify that the test I wrote in #2672 fails for you?
Branch: https://github.com/cython/cython/tree/gh2670_win_intop
python3 runtests.py -vv cintop buildenv
Please also report the output of the buildenv test on the system where your example fails.
As a work-around, you can disable Cython's usage of the PyLong type internals by setting the C macro CYTHON_USE_PYLONG_INTERNALS=0. That slows down integer operations somewhat, but should make things working again.

Hi
Thks for the support and sorry for the late reply. I will try to reply faster next time :)
Could you give example with the command?
What am I suppose to put as "buildenv"? mingw32?
Anyway, the commands fails whatever the argument passed:
C:\scripts2\cython-gh2670_win_intop>python runtests.py --v cintop mingw32
runtests.py:348: UserWarning: Unable to find the c compiler: No such file or dir
ectory: msvc
  (language, os.strerror(sys.exc_info()[1].errno), cc))
runtests.py:348: UserWarning: Unable to find the cpp compiler: No such file or d
irectory: msvc
  (language, os.strerror(sys.exc_info()[1].errno), cc))
Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 03:37:03) [MSC v.1900 64 bit (AMD6
4)]

Running tests against Cython 0.29
Traceback (most recent call last):
  File "runtests.py", line 2509, in <module>
    main()
  File "runtests.py", line 2157, in main
    _, stats, return_code = runtests(options, cmd_args, coverage)
  File "runtests.py", line 2305, in runtests
    pyxbuild_dir=os.path.join(WORKDIR, "support"))
  File "C:\scripts2\cython-gh2670_win_intop\pyximport\pyxbuild.py", line 102, in
 pyx_to_dll
    dist.run_commands()
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\d
ist.py", line 955, in run_commands
    self.run_command(cmd)
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\d
ist.py", line 974, in run_command
    cmd_obj.run()
  File "C:\scripts2\cython-gh2670_win_intop\Cython\Distutils\old_build_ext.py",
line 186, in run
    _build_ext.build_ext.run(self)
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\c
ommand\build_ext.py", line 339, in run
    self.build_extensions()
  File "C:\scripts2\cython-gh2670_win_intop\Cython\Distutils\old_build_ext.py",
line 194, in build_extensions
    self.build_extension(ext)
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\c
ommand\build_ext.py", line 533, in build_extension
    depends=ext.depends)
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\_
msvccompiler.py", line 345, in compile
    self.initialize()
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\_
msvccompiler.py", line 238, in initialize
    vc_env = _get_vc_env(plat_spec)
  File "C:\Users\aaa\AppData\Local\Programs\Python\Python36\lib\distutils\_
msvccompiler.py", line 134, in _get_vc_env
    raise DistutilsPlatformError("Unable to find vcvarsall.bat")
distutils.errors.DistutilsPlatformError: Unable to find vcvarsall.bat

I can see using print that I get the default_compiler() = msvc using your script, but it is not installed on my machine.
    if language == 'cpp':
        cc = sysconfig.get_config_var('CXX')
    else:
        cc = sysconfig.get_config_var('CC')
    if not cc:
       cc = ccompiler.get_default_compiler()
    if not cc:
        return ''

MinGW-W64 can be found here:
https://sourceforge.net/projects/mingw-w64/
output that might be useful to you:
C:\scripts>gcc --version
gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

C:\scripts>gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=C:/Program\ Files/mingw-w64/x86_64-8.1.0-win32-seh-rt_v6-rev
0/mingw64/bin/../libexec/gcc/x86_64-w64-mingw32/8.1.0/lto-wrapper.exe
Target: x86_64-w64-mingw32
Configured with: ../../../src/gcc-8.1.0/configure --host=x86_64-w64-mingw32 --bu
ild=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --prefix=/mingw64 --with-sysr
oot=/c/mingw810/x86_64-810-win32-seh-rt_v6-rev0/mingw64 --enable-shared --enable
-static --disable-multilib --enable-languages=c,c++,fortran,lto --enable-libstdc
xx-time=yes --enable-threads=win32 --enable-libgomp --enable-libatomic --enable-
lto --enable-graphite --enable-checking=release --enable-fully-dynamic-string --
enable-version-specific-runtime-libs --disable-libstdcxx-pch --disable-libstdcxx
-debug --enable-bootstrap --disable-rpath --disable-win32-registry --disable-nls
--disable-werror --disable-symvers --with-gnu-as --with-gnu-ld --with-arch=noco
na --with-tune=core2 --with-libiconv --with-system-zlib --with-gmp=/c/mingw810/p
rerequisites/x86_64-w64-mingw32-static --with-mpfr=/c/mingw810/prerequisites/x86
_64-w64-mingw32-static --with-mpc=/c/mingw810/prerequisites/x86_64-w64-mingw32-s
tatic --with-isl=/c/mingw810/prerequisites/x86_64-w64-mingw32-static --with-pkgv
ersion='x86_64-win32-seh-rev0, Built by MinGW-W64 project' --with-bugurl=https:/
/sourceforge.net/projects/mingw-w64 CFLAGS='-O2 -pipe -fno-ident -I/c/mingw810/x
86_64-810-win32-seh-rt_v6-rev0/mingw64/opt/include -I/c/mingw810/prerequisites/x
86_64-zlib-static/include -I/c/mingw810/prerequisites/x86_64-w64-mingw32-static/
include' CXXFLAGS='-O2 -pipe -fno-ident -I/c/mingw810/x86_64-810-win32-seh-rt_v6
-rev0/mingw64/opt/include -I/c/mingw810/prerequisites/x86_64-zlib-static/include
-I/c/mingw810/prerequisites/x86_64-w64-mingw32-static/include' CPPFLAGS=' -I/c/
mingw810/x86_64-810-win32-seh-rt_v6-rev0/mingw64/opt/include -I/c/mingw810/prere
quisites/x86_64-zlib-static/include -I/c/mingw810/prerequisites/x86_64-w64-mingw
32-static/include' LDFLAGS='-pipe -fno-ident -L/c/mingw810/x86_64-810-win32-seh-
rt_v6-rev0/mingw64/opt/lib -L/c/mingw810/prerequisites/x86_64-zlib-static/lib -L
/c/mingw810/prerequisites/x86_64-w64-mingw32-static/lib '
Thread model: win32
gcc version 8.1.0 (x86_64-win32-seh-rev0, Built by MinGW-W64 project)

output of my command being build:
C:\scripts2\tests>python setup.py build_ext --force --inplace
running build_ext
building 'shiftoperator' extension
C:\Program Files\mingw-w64\x86_64-8.1.0-win32-seh-rt_v6-rev0\mingw64\bin\gcc.exe
 -mdll -O -Wall -IC:\Users\aaa\AppData\Local\Programs\Python\Python36\inclu
de -IC:\Users\aaa\AppData\Local\Programs\Python\Python36\include -c shiftop
erator.c -o build\temp.win-amd64-3.6\Release\shiftoperator.o
writing build\temp.win-amd64-3.6\Release\shiftoperator.cp36-win_amd64.def
C:\Program Files\mingw-w64\x86_64-8.1.0-win32-seh-rt_v6-rev0\mingw64\bin\gcc.exe
 -shared -s build\temp.win-amd64-3.6\Release\shiftoperator.o build\temp.win-amd6
4-3.6\Release\shiftoperator.cp36-win_amd64.def -LC:\Users\aaa\AppData\Local
\Programs\Python\Python36\libs -LC:\Users\aaa\AppData\Local\Programs\Python
\Python36\PCbuild\amd64 -lpython36 -lvcruntime140 -o C:\scripts2\tests\shiftoper
ator.cp36-win_amd64.pyd

In order to make it working, i do the following steps:
1/ generate libvcruntime140.a
 cd C:\Users\xxx\AppData\Local\Programs\Python\Python36\libs
gendef ../vcruntime140.def
dlltool --dllname ../vcruntime140.dll --def vcruntime140.def --output-lib libvcruntime140.a

2/ put the default compiler as mingw32 adding in distutils folder distutils.cfg as followed:
[build]
compiler = mingw32

3/ Editing cygwinccompiler.py on line 85 adding the following line:
        elif msc_ver == '1900':
            # Visual Studio 2015 / Visual C++ 14.0
            # "msvcr140.dll no longer exists"
            return ['vcruntime140']

here the buildenv.c on my computer, result of
python -m cython -3 buildenv.pyx
buildenv.zip

@gui36 I have a similar issue with my code and had a discussion in the cython-users Google group. The problem is in the header pyport.h, in which SIZEOF_VOID_P is defined based on whether MS_WIN64 is defined or not. The solution is to pass -DMS_WIN64 when compiling with MinGW.

Hi Ducminh-phan,
Indeed, it worked adding -DMS_WIN64 to the gcc command
Thks a lot! :)
Do you know how to add this argument to cythonizer?
Is there any file to modify with this argument?

@gui36 You just need to add -DMS_WIN64 to the build command: python setup.py build_ext --inplace - DMS_WIN64

perfect thks!

@ducminh-phan Although this is quite old issue, I still had same problems. Adding -DMS_WIN64 fixed the issue for me. So, would it be possible to automatically detect usage of mingw32 and automatically pass -DMS_WIN64?

Also, I have another question. How to pass -DMS_WIN64 when using cythonize command?

How to pass -DMS_WIN64 when using cythonize command?

It should still work to add it to the CFLAGS.

Could Cython/compiler be set up to automatically include -DMS_WIN64 if needed?

Two problems here. a) Cython does not need to be involved in the C compilation at all, and thus may not be in a position to add the compile flag "automatically", and b) the user might have a different idea about what "is needed" than Cython, and Cython shouldn't get in the way in that case.
I don't think that Cython should do this.

Is there any other possibility for building Cython packages with MinGW? Or maybe official Python team needs to support something?
As MinGW is the only lightweight compiler, in comparison to VS Build Tools, it would be very useful to support it.


Dropdown In Bootstrap version 4.5.0

The drop down button is auto clicked and the drop down items remain open whatsoever (but hidden visually). You can check it by taking cursor down to it.
The code is as follows:

  Navbar
  <button class="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">

  </button>

        Home (current)

        Link

          Dropdown

          Action
          Another action

          Something else here

        Disabled

Bug reports must include a live demo of the issue. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and Operating System details.
This is an automated reply

And the normal version/system info

@SourabhPotnis007 I ran into this same issue just now. You need to add the required JavasScript dependencies https://getbootstrap.com/docs/4.5/getting-started/introduction/#js
Here is a minimal page. Note the script tags near the end. Those are required for the dropdown to work.
<!doctype html>

    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.0/css/bootstrap.min.css" integrity="sha384-9aIt2nRpC12Uk9gS9baDl411NQApFmC26EwAOH8WgZl5MYYxFfc+NcPb1dKGj7Sk" crossorigin="anonymous">

    <title>Hello, world!</title>

Hello, world!

For future reference, here are the other Bootstrap elements that require these JavaScript tags

Alerts for dismissing
Buttons for toggling states and checkbox/radio functionality
Carousel for all slide behaviors, controls, and indicators
Collapse for toggling visibility of content
Dropdowns for displaying and positioning (also requires Popper.js)
Modals for displaying, positioning, and scroll behavior
Navbar for extending our Collapse plugin to implement responsive behavior
Tooltips and popovers for displaying and positioning (also requires Popper.js)
Scrollspy for scroll behavior and navigation updates

Thanks
On Thu, Jun 4, 2020 at 10:43 AM Eric Leung<EMAIL_ADDRESS>wrote:

@SourabhPotnis007 https://github.com/SourabhPotnis007 I ran into this
same issue just now. You need to add the required JavasScript
dependencies
https://getbootstrap.com/docs/4.5/getting-started/introduction/#js
Here is a minimal page. Note the script tags near the end. Those are
required for the dropdown to work.
<!doctype html>

<link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.5.0/css/bootstrap.min.css" integrity="sha384-9aIt2nRpC12Uk9gS9baDl411NQApFmC26EwAOH8WgZl5MYYxFfc+NcPb1dKGj7Sk" crossorigin="anonymous">

<title>Hello, world!</title>

Hello, world!

For future reference, here are the other Bootstrap elements that require
these JavaScript tags

Alerts for dismissing
Buttons for toggling states and checkbox/radio functionality
Carousel for all slide behaviors, controls, and indicators
Collapse for toggling visibility of content
Dropdowns for displaying and positioning (also requires Popper.js)
Modals for displaying, positioning, and scroll behavior
Navbar for extending our Collapse plugin to implement responsive
behavior
Tooltips and popovers for displaying and positioning (also requires
Popper.js)
Scrollspy for scroll behavior and navigation updates

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/30915#issuecomment-638606699,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APX6KYSBHB4MINVR4IRAAO3RU4UPDANCNFSM4NMYMNBA
.


Support 64-bit addressing in MSI capabilities and improve uniformity with rest of library

Fixes #31
Also splits out helpers for setting MSI message info into an LAPIC-specific one and a more generic one for other architectures.

Thanks!


@MdechampG Could you please check if this fix does not change the expected appearance on home page cards ☺.

This PR is needed for #136...

That sounds good. Fast procedure, I merge... Thanks for the fix @bdeneux 😊


Enforce overprovisioning limit when expanding volume size and fix the rounding issue with Storage Over Provisioning Percentage

longhorn/longhorn#2962
longhorn/longhorn#2952

I looked into the unit test, I might be wrong but it seems we have to create a new unit test and it takes time. Can we create a new ticket for the unit test and implement it later because it is not top priority? How do you think @jenting @innobead?

I looked into the unit test, I might be wrong but it seems we have to create a new unit test and it takes time. Can we create a new ticket for the unit test and implement it later because it is not top priority? How do you think @jenting @innobead?

NP. Let’s do this way.

We need to backport this to 1.2.x

I am curious how confident if users update the volume spec directly, all volume functions should work? I remember we don't suggest users update the volume spec directly until it gets supported well? (this is a side question actually)

IIRC, Harvester will operate the Longhorn system via kubectl rather than sending HTTP requests. Although Longhorn doesn't officially support direct CR operation, we should start to consider this part and try to handle it from now on.
For this PR, I think it's nice to consider this part. It is not the top priority.

Thanks @shuo-wu
I added the check to volume controller. Need to do more testing before merging

BTW, I just made a common mistake when edit the volume CR. I edit the volume size to a value that is not multiple of 4Kb. The volume stuck in attaching/detaching loop. This is one example of many things could go wrong if user directly modify the volume CR.

Why Harvester doesn't use Longhorn API by the way?

@PhanLe1010 I believe they understand how it works, so they go with the spec setting like recent node management. But for now, let's make the function working first, we can tackle the CR part later as @shuo-wu said not a priority for now.

Harvester shouldn't need to modify the longhorn CRD directly for size operations instead they should be utilizing a PVC in block mode then updating the size there.
For the future to prevent modifications that could lead to invalid states, we would need a mutating/validating admission hook.
Which will be a good addition for a couple of our CRD's.

Why Harvester doesn't use Longhorn API by the way?

I am not sure what the exact reason is. Maybe we can test this question in the Slack channel. Using kubectl is the most popular & native way to operate Kubernetes components. In the future, we can add some validation for kubectl to avoid this. kind of invalid size update.

e2e core tests looks ok

@PhanLe1010 please backport to 1.2.1 and 1.1.3.


fix: Cherry pick 2042 into 0.39

Description:
Cherry pick of commit #2042 into 0.39 release branch
Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7c35290) 77.83% compared to head (43d2688) 77.84%.

:exclamation: Current head 43d2688 differs from pull request most recent head c71b944. Consider uploading reports for the commit c71b944 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.39    #2044   +/-   ##
=============================================
  Coverage         77.83%   77.84%
=============================================
  Files                40       40
  Lines              3086     3087    +1
  Branches            625      626    +1
=============================================
+ Hits               2402     2403    +1
  Misses              479      479
  Partials            205      205

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(main): release 1.24.1

:robot: I have created a release beep boop
1.24.1 (2024-08-28)
Bug Fixes

correction types export (cba187f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Andesite-Lab/Core/releases/tag/v1.24.1 :sunflower:


Illegal argument: connectionToken

Type: Bug
hi,
I tried to use the "remote-tunnel"
I turned on the remote on my Mac.
And I tried to access remote by turning on a different vcode window
But it doesn't connect, it only pops up during the connection
And the following error is displayed on the console

INFO [attempt 1] Invoking resolveAuthority(tunnel)
workbench.desktop.main.js:616   ERR [attempt 1] resolveAuthority(tunnel) returned an error after 402 ms Error: Illegal argument: connectionToken
at P (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:7:1129)
at new Y (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:92:17352)
at C.resolve (vscode-file://vscode-app/Users/yoodongsin/.vscode/extensions/ms-vscode.remote-server-1.0.0/dist/node/extension.js:2:945327)
at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
at async d.$resolveAuthority (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:106:18208)
workbench.desktop.main.js:616  INFO [attempt 2] Invoking resolveAuthority(tunnel)
workbench.desktop.main.js:616   ERR [attempt 2] resolveAuthority(tunnel) returned an error after 4 ms Error: Illegal argument: connectionToken
at P (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:7:1129)
at new Y (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:92:17352)
at C.resolve (vscode-file://vscode-app/Users/yoodongsin/.vscode/extensions/ms-vscode.remote-server-1.0.0/dist/node/extension.js:2:945327)
at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
at async d.$resolveAuthority (vscode-file://vscode-app/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:106:18208)

VS Code version: Code 1.74.0 (Universal) (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:43:37.594Z)
OS version: Darwin arm64 22.1.0
Modes:
Sandboxed: No
Connection to 'vscode-remote' could not be established  Illegal argument: connectionToken

System Info

Item
Value

CPUs
Apple M1 Max (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 2, 2

Memory (System)
32.00GB (4.86GB free)

Process Argv
--crash-reporter-id 1e802665-f08b-4ad6-8ba6-8dc6008bbd04

Screen Reader
no

VM
0%

Connection to 'vscode-remote' could not be established  Illegal argument: connectionToken
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vsccc:30610678
pyindex848cf:30577861
nodejswelcome1cf:30587006
2e4cg342:30602488
gswce1:30612156
3d0df643:30613357
dbltrim-noruby:30604474
f6dab269:30613381
fim-prod:30623723

It was uploaded incorrectly.
I'll create an issue to remote - tunnel


Sample for Operator auto-instrumentation with Go

Do you have any predictions for auto instrumentation with GO using GKE/ASM?

Support in the operator for go auto-instrumentation is in progress at https://github.com/open-telemetry/opentelemetry-operator/pull/1555. This is pretty much just waiting on the first tagged alpha release of https://github.com/open-telemetry/opentelemetry-go-instrumentation, which should be soon.
Once the operator supports it, we'll add an example for it here. There is also a compile-time auto instrumentation for Go available at https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrgen, which is usable now but won't be available in the operator at least for the time being.
I'll leave this issue open to track adding support once it's available

I opened a PR to add a go sample app in https://github.com/GoogleCloudPlatform/opentelemetry-operator-sample/pull/35, the client doesn't work with the current latest go auto-instrumentation but it should be fixed in the next release. We can merge it then


⚠ Samsung has degraded performance

In d1fc405, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2494 ms

Resolved: Samsung performance has improved in 8f785e6.


All Contributors Badge for AsyncAPI repository not displaying correctly

Describe the bug
The All Contributors badge for the Readme is not displaying correctly. It is showing 45 contributors when the actual number is 158.

Screenshots

The link should be - https://img.shields.io/github/contributors/asyncapi/website.svg?style=flat-square&color=orange instead of https://img.shields.io/badge/all_contributors-45-orange.svg?style=flat-square

closing, for the same reason as the comment in linked PR


Jetpack Paging v3 support

#193
Added support for Jetpack Paging v3 with LoadState/retry()/refresh() support

This is a great start thanks!. For the LoadState stuff, I think it might make sense to push it up a level into a MergeObservableList instead of using the ConcatAdapter/LoadStateAdapter. This should make it play better with the other parts of the lib. Working on a branch to do just that, will put it up when I've got something. Still need to think about how to connect the retry callback though.

I added a PR which adds a itemBinding based LoadStateAdapter.    But I see you point, if we can merge all into the list then we can provide bindings all in the same adapter.  instead of managing ConcatAdapter

I just pushed a commit to tie in retry() and refresh().  it works.   I'd like to circle back to the MergeObservableList and see if I can help out.

Challenges I see with the ObservableMergeList is how the consumer will specify the bindings.  If it is all a single itemBinding no way to distinguish between header and footer elements.
For example: (no way to know if the error/progress bindings are for the header or footer)
        OnItemBindClass<Any>().apply {
            map<ImmutableItem>(BR.item, R.layout.item_immutable)
            map<LoadState.Error>(BR.item, R.layout.network_state_item_error)
            map<LoadState.Loading>(ItemBinding.VAR_NONE, R.layout.network_state_item_progress)
        }.toItemBinding().bindExtra(BR.callback, callback)
    }```

Be nice if consumer could specify separate bindings for `items` and the header/footer.  Then we could make a way to combine those into a single ItemBinding.   Then we could just maintain 3 ObservableLists, all merged together.

Only other issue is that our code would basically duplicate logic from `LoadStateAdapter`.  Instead of notifying adapter it would update the underlying observableList.

Alright, pushed up https://github.com/evant/binding-collection-adapter/pull/195, thoughts?

I dig it.  posted some comments related to retry/refresh.  I like the custom OnItemBind for LoadState; i was thinking same regarding the merged list approach.  could pass we in a variable name for the retry callback in the constructor and then bind it the list?
Only other concern is that by not extending LoadStateAdapter we are forced to duplicate the logic.  it is pretty simple but it is something you will have to keep in sync if it changes.

Pushed new PR #196


in the new Docu, the request code is debit instead refund

Hi, thank you for this PR. Do you have any details you can point me to that explains this change?


easier turing

I think it could be helpful to add a small picture showing exactly what 1\10 CW turn looks like.
but I don't know how to resize to picture properly
right now it looks like a mess
https://sm-26.github.io/PMSBLM/
I feel like the answer is CSS something but can't figure out what or how.

Cool idea, however, the example won't say much when a point requires >360° of rotation. Any ideas on how to represent such a scenario?
Anyway, I think most people can visualize degrees and fractions in terms of rotation and this idea is not practical.
Thanks!

I realized I never really helped you resolve your issue and just dismissed your request.
Anyway, adding a width of 100% to the image would fix it
<img src="circle.png" alt="" width:="" 75%;="" style="width: 100%;">


GH-37701: [Java] Add default comparators for more types

Rationale for this change
Add default comparators for more vector types to make algorithms easier to use and provide more consistency for Java compared to other languages.
What changes are included in this PR?
Add default type comparators for:

BitVector
DateDayVector
DateMilliVector
Decimal256Vector
DecimalVector
DurationVector
IntervalDayVector
TimeMicroVector
TimeMilliVector
TimeNanoVector
TimeSecVector
TimeStampVector

IntervalMonthDayNanoVector is not supported due to its public type PeriodDuration not being Comparable.
BitVector's getWidth() method does not return valid data by design since its length is smaller than 1 byte. Using a BitVector with a fixed-width type's algorithm will throw an IllegalArgumentException.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

Closes: #37701

Can we add LargeVarCharVector to the list? #14665


Can not find scannet data

Scannet
Download and extract Scannet by following the instructions provided at http://www.scan-net.org/. You also need to download the train/val/test splits and the label mapping from https://github.com/ScanNet/ScanNet (Benchmark Tasks).
There is no downloadable file in http://www.scan-net.org/

I believe you may need contact the ScanNet team and sign a term to get access to the dataset.

I believe you may need contact the ScanNet team and sign a term to get access to the dataset.
But  what are the specific scans_test documents


Complex type handling

Today Pinot supports primitive data types (including int, long, float, double, string, bytes), as well as limited multi-value types such as an array of primitive types. Such simple data types allow Pinot to build fast indexing structures for good query performance, but with a tradeoff on the ingestion limitations. It’s common for users to ingest data with complex data types into Pinot, such as JSON or Avro, in particular with two complex types: tuple (.e.g record in Avro, object in JSON) and list of complex data types (e.g. arrays in Avro and JSON). However, today most users have to set up transformation pipelines, e.g. streaming pipeline in Flink for real-time ingestion or batch pipeline in Spark for offline ingestion, in order to flatten/transform the complex data types in the primitives ones to be compatible with Pinot’s data types. Many users find authoring such pipelines is difficult, especially when the schema is complex, for example, deeply nested.
A proposal to address this issue is at this doc

User docs is at https://docs.pinot.apache.org/basics/data-import/complex-type
This will be released as part of 0.8


GC.send never fire callback

It didn't work for me on any method
gc.send(header, body, callback);

The callback is only fired when GC sends a JobID-based response. Not all GC messages use JobIDs. You can check using NetHook2 – see if the message the client sends has source_job_id set and whether there is an incoming message with a matching target_job_id.

I might be wrong, but can also reproduce this on some messages that should work using JobIDs for example the proto CMsgGCCStrike15_v2_Client2GCEconPreviewDataBlockRequest which is a Client2GCEconPreviewDataBlockRequest and should respond with the Client2GCEconPreviewDataBlockResponse, the request correctly send the job_id_source in the header, the response is correctly received but the JobID still is<PHONE_NUMBER>3709551615 which means it is not a response/request.
Do you have any idea if it's an intended behavior or no? Thanks.

should work using JobIDs

Have you tried using NetHook to see if it's actually the case?

I unfortunately don't have a Windows right now, but as you stated in a previous message, I assumed messages following the Request Response naming should work this way.
Do you know any way I can test this?

I assumed messages following the Request Response naming should work this way.

AFAIK it's not always the case.

Do you know any way I can test this?

I'm not aware of any way that doesn't involve using NetHook and consequently Windows.

Okay thanks for the clarification.


Higher level API for automatic navmesh generation

I suggest adding a higher level API under a feature that would automatically tile the world and generate the navigation meshes  automatically from meshes or rapier colliders for entities with special marker-component. And when any new object spawns / despawns it regenerates the navigation mesh for the affected tile.
Similar API is provided by https://github.com/TheGrimsey/oxidized_navigation. It's useful for games with dynamic worlds.

I would also appreciate such a feature!


Support Imspector FLIM TIFF files?

The FLUTE dataset currently used in the introductory tutorial consists of TCSPC FLIM data stored in OME-TIFF files with custom metadata, written by Imspector Pro software.
While the files are valid OME-TIFF, the TCSPC histogram is misleadingly stored in the Z dimension (not in a H dimension), and the PhysicalSizeZ attribute apparently contains the TCSPC bin size in ns. The fundamental frequency in MHz can be calculated as 1000 / (SizeZ * PhysicalSizeZ).
No specification for this storage scheme and the custom metadata seems to be available.
Imspector also writes files in the MSR and OBF formats. Bio-Formats has a reader for MSR and OBF.
Here are the relevant parts from the OME-XML embedded in the Embryo.tif file:
...
<Image ID="Image:7B60FD74-9A87-465E-8A30-8B75D0C3C803" Name="t31_2h30DC-TCSPC_C0.ome.tif" DefaultPixels="Pixels:7B60FD74-9A87-465E-8A30-8B75D0C3C803">
<CreationDate>2021-11-05T12:30:27</CreationDate>
<Description>not_specified</Description>
<Pixels ID="Pixels:7B60FD74-9A87-465E-8A30-8B75D0C3C803" DimensionOrder="XYZTC" PixelType="uint16" BigEndian="false" SizeX="512" SizeY="512" SizeZ="56" SizeT="1" SizeC="1" PhysicalSizeX="1.179500" PhysicalSizeY="1.179500" PhysicalSizeZ="0.222909">
<TiffData>
<UUID FileName="t31_2h30DC-TCSPC_C0.ome.tif">urn:uuid:7B60FD74-9A87-465E-8A30-8B75D0C3C803</UUID>
</TiffData>
</Pixels>
<ca:CustomAttributes>
<Offset Offset_0="2.048004" Offset_1="2.048004" Offset_2="0.000000" Offset_3="0.000000"/>
<Length Length_0="603.904053" Length_1="603.904053" Length_2="12.482924" Length_3="1.000000"/>
<AxesLabels X="DC-TCSPC X" Y="DC-TCSPC Y" FirstAxis="DC-TCSPC T" SecondAxis="NONE" X-Unit="µm" Y-Unit="µm" FirstAxis-Unit="ns" SecondAxis-Unit=""/>
...

Requested documentation about the ImSpector FLIM TIFF format from Miltenyi Biotec.

Got some additional information about the ImSpector FLIM TIFF format from Miltenyi Biotec technical support (thank you).
The FirstAxis or SecondAxis attributes of the AxesLabels element in CustomAttributes can have the value 'lifetime' to identify the FLIM axis. The FLIM axis replaces either the regular T or Z axis, that is, either Z-stack or timelapse measurements are possible in FLIM mode.
This doesn't match the FLUTE sample files but should be added to the implementation.


Update ESLint configuration

Description
This PR brings a series of changes to our ESLint configuration:

Using JSON extensions instead of JS

We don't have any computed values that would require runtime and documentation integrates better with VSCode on hover

Extends more "recommended" rules
Use prettier config instead of plugin as recommended by prettier itself
Added cypress/recommended, jest/recommended and testing-library/react configurations to test files
Added storybook/recommended configuration for stories

Demo
Hovering over "rules" with .eslintrc.js

Hovering over "rules" with .eslintrc.json

New warnings

@luiz-chagas something that @sircharleswatson had mentioned was the potential of removing prettier can letting eslint do all the formatting. Curious if you have thoughts about that.

@luiz-chagas something that @sircharleswatson had mentioned was the potential of removing Prettier and letting ESLint do all the formatting. Curious if you have thoughts about that. (Technically ESLint is doing the formatting currently, but it's still integrating Prettier. Maybe we can eliminate a tool?)

To be honest I haven't tried that in a long time, I remember a while ago that ESLint couldn't do some of the formatting that prettier was capable of. Maybe that has changed? Unsure, but I'd be open if anyone (@sircharleswatson?) wanted to propose moving forward without prettier.

On our HorseCo project we changed the linting script to be eslint src --ext=ts,tsx && prettier --check . --loglevel warn and we use the Prettier VSCode extension to apply formatting, this has the benefit of not showing ESLint red squigglies for what are only formatting issues, also, Prettier can help you with other file types (namely JSON in our project, but also: CSS, HTML, YML, markdown... and more) while ESLint only works with JS and TS out of the box, for these reasons I would probably disagree with removing it

Now we can't format code via Prettier programmatically

You can fix prettier issues with npm run prettier --write if that's what you mean

That'll do!

@roblafeve I believe this is good if you think it's good


Implement ellipsis and increase padding for long card desc

Ellipsis feature for blog titles:

70 chars max
if text.length > 70 -> cropp after next word, adding an …
if last char —after cropping— is a . or , remove it.

Increase padding feature:

The text of the project cards will not overlap the arrow

merged, @Serabe feel free to add comments to this PR in case you have any suggestion to do


.nav-tabs.nav-stacked do not render properly

They render like if they are horizontal tabs rather than "vertical tabs". I think you would need from another class like: nav-tabs-left or nav-tabs-right to determine if the tabs are on the left or right side of the tabpanel.
No idea how to add labels, but this is in v4

i think you should use .nav-stacked only for pills; http://v4-alpha.getbootstrap.com/components/navs/#stacked-pills

I do not know the original intention, but there are only 4 lines of CSS needed. I think it would make sense to have vertical tabs.

Is it possible to stack something in the sides? I need to relearn few concepts i think.

I think it would make sense to have vertical tabs.

Bootstrap v3 deliberately removed all tab variations except for "horizontal, above the content". See #8922.
/fyi @mdo