Sub-verse widget for lwc's

Create a subverse widget where it takes one verse, and allows you to highlight the relevant part that your comment specifically refers to.  Similar to tablet-text-selector widget.

This blocks Issue #11

Starting with dev-subverse-field. Will make dev-subverse-widget later, as the widget can only be tested if a robust field implementation exists. Learned this the hard way with the scripture module...

Maybe this field type and widget should be a standalone module? We can pass the bible verse (or any text for that matter) to the widget. The field simply stores

starting character position
the selected text
A separate field could store the translation, making the above-mentioned field standalone.
@krokkie would you agree?

Yip, agree.
Input == text
Output = selection, could reduce this to start + len ?
Settings:  single-range-only;   Could later extend this is allow multiple ranges ?
Maybe try "rangy" - see an example here:  http://rangy.googlecode.com/svn/trunk/demos/highlighter.html
https://github.com/timdown/rangy

Done.
TODO: eye-candy. That would be a new issue for a later version.


Can I drag and drop from react-dnd to HTML native dom and trigger the drop event?

Can I drag and drop from react-dnd to HTML native dom and trigger the drop event?

Same question here


vkquake: 1.11.0 -> 1.12.1

Builds and runs on my machine
Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 150268 run on x86_64-linux 1

1 package built:

vkquake

Tested on linux-amd64 with nixos-unstable.
Game runs fine with the commercial Quake assets


Unexpected AspNetCore dependency

If I read the readme correct this library is supposed to work in a 'normal' net6 console app?
For me referencing the nuget Razor.Templating.Core results in a requirement for Microsoft.AspNetCore.App. Is this intended?
$ dotnet new console
The template "Console App" was created successfully.

Processing post-creation actions...
Running 'dotnet restore' on /razortest/razortest.csproj...
  Determining projects to restore...
  Restored /razortest/razortest.csproj (in 164 ms).
Restore succeeded.

$ dotnet run
Hello, World!

$ dotnet add package Razor.Templating.Core
  Determining projects to restore...
  Writing /tmp/tmpy0Nnob.tmp
info : Adding PackageReference for package 'Razor.Templating.Core' into project '/razortest/razortest.csproj'.
info :   CACHE https://api.nuget.org/v3/registration5-gz-semver2/razor.templating.core/index.json
info : Restoring packages for /razortest/razortest.csproj...
info : Package 'Razor.Templating.Core' is compatible with all the specified frameworks in project '/razortest/razortest.csproj'.
info : PackageReference for package 'Razor.Templating.Core' version '1.7.1' added to file '/razortest/razortest.csproj'.
info : Committing restore...
info : Writing assets file to disk. Path: /razortest/obj/project.assets.json
log  : Restored /razortest/razortest.csproj (in 135 ms).

$ dotnet run
It was not possible to find any compatible framework version
The framework 'Microsoft.AspNetCore.App', version '6.0.0' (x64) was not found.
  - No frameworks were found.

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.AspNetCore.App&framework_version=6.0.0&arch=x64&rid=arch-x64

$ dotnet --info
.NET SDK (reflecting any global.json):
 Version:   6.0.102
 Commit:    49861cb924

Runtime Environment:
 OS Name:     arch
 OS Version:
 OS Platform: Linux
 RID:         arch-x64
 Base Path:   /usr/share/dotnet/sdk/6.0.102/

Host (useful for support):
  Version: 6.0.2
  Commit:  839cdfb0ec

.NET SDKs installed:
  6.0.102 [/usr/share/dotnet/sdk]

.NET runtimes installed:
  Microsoft.NETCore.App 6.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]

To install additional .NET runtimes or SDKs:
  https://aka.ms/dotnet-download

$

Hi @daef, yes this is intended.

Oh, so there's no 'aspnet-free razoring' in the end. Nvmnd, guess I can close this then.


[Java 15.2]: Exception Types Audio

Description 📜
I have worked on the Audio part of the Java Exception Types
Fixes #2870

Type of change 📝

[x] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)

Domain of Contribution 📊

[x] Java_Domain

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@garvitraj / @AkMo3  can you please review my PR


File name in CF release page is wrong

File called nuclearcraft-1.12.2-1.0.1.jar what is not true since this mod is not Nuclearcraft.

Fixed!


Enable Link-Time Optimization (LTO)

Hi!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit. If you want to read a bit more about LTO, I can recommend starting from this Rustc documentation.
I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where in addition to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. If we enable it on the Cargo profile level, users, who install the application with cargo install will get the LTO-optimized version "automatically". E.g., check cargo-outdated Release profile - maybe you will also be interested in other Cargo/Rustc optimization flags like codegen-units.
Basically, it can be enabled with the following lines:
[profile.release]
lto = true

I have made quick tests (Fedora 41, Rust 1.82) by adding lto = true to the Release profile. The binary size reduction is from 17 Mib to 14 Mib.
Thank you.

Thank you, this is a good idea! Appreciate the links as well :)


invalid relationships aren't exported

Crashes during attempts worked around in #18, but we should eventually start exporting invalid relationships.
Probably can support exporting them once we switch from explicit db.relationships.getInstanceProps to polymorphic query over the root relationship class.

closing after discussion with Affan, since those relationships are effectively invalid and a connector can just recreate them


IdentityServerBearerTokenConfiguration

I know that there is ExternalBearerTokenConfiguration, but thought that the IdentityServerBearerTokenConfiguration using IdentityServerBearerTokenAuthentication could be easier to configure for those using IS3. I could understand that you may not want to add a direct dependency to IdentityManager. Unfortunately, SecurityConfiguration constructor is internal, which makes subclassing it in my own assembly impossible.
Can it be made public? Or would you appreciate the IS bearer token configuration in IdentityManager?

Sure, send a PR.


Linebreak Spacing Option?

Hi,
I've been having issues with the double spacing that occurs when pressing "Enter" while editing a book. These tinyMCE configuration options seem to have resolved the issue for me, but in order to use them I have to edit the wysiwyg-editor.js and recompile the app.js file with webpack.
Would it be possible to add an option in the interface in order to toggle linebreak spacing within the tinyMCE editor? I've included the relevant options below tinyMCE config options below.
force_br_newlines : true,
force_p_newlines : false,
forced_root_block : '' // Needed for 3.x

Hi @jrneulight,
Unfortunately I would not look to incorporate such a low-level, detailed setting in the interface. As an alternative option to achieving this, without webpack re-complication or editing any core files, it's possible to do this via the editor events we expose.
Therefore, Using the "Custom HTML Head Content" setting, you could achieve your customisations like so:
<script>
	window.addEventListener('editor-tinymce::pre-init', event => {
		const config = event.detail.config;
		config.force_br_newlines = true;
		config.force_p_newlines = false;
		config.forced_root_block = '';
	});
</script>

Note that such customisations are out-of-support and its possible the editor could change and be incompatible with such changes in the future.
Alternatively, You could achieve a similar result with CSS, again via the "Custom HTML Head Content" setting:
<style>
.page-content p {
    margin-bottom: 0;
    margin-top: 0;
}
</style>

This solves my problem perfectly! Thank you and good luck with development


Add a go vet check for calling C.CString() inline within a function call

Someone in the Go Slack channel had a memory leak in their program, that turned out to be a misunderstanding of how CStrings work. Their code did:
C.myfunc(C.CString(goStr))

They expected that C.CString would be a normal GC-able object, and so lost some time tracking down the non-obvious memory leak. The cgo documentation states that C.CString must be accompanied by a C.free, but if that docstring gets glossed over, the result is a hard to find bug.
It would be nice if go vet could warn on the pattern of calling a C function with a CString allocated inline in the function call. Such a call is most often wrong, since there's no way to free the resulting *C.char. One exception is if the C function itself frees the memory, but that is relatively unusual pattern of memory ownership in C APIs.

I don't think this passes the three requirements for cmd/vet (see
cmd/vet/README).
You will need to demonstrate at least this error's frequency and that
people don't actually wrap a C function in cgo preamble that frees the
argument after calling the function it wraps.
Perhaps this is better addressed with better documentation. (If you think
about the issue, it's very obvious Go's GC cannot track memory returned by
C.CString as C code can retain a reference and Go can't see the reference.)

I was the person who came in with the issue.  My initial request was actually documentation since I found the docs that said I should be running the C.free() myself anytime a C.CString() is allocated.  The confusion came when I expected the GC to free that on it's own.  So a note in the docs would be incredibly helpful.  Additionally, the docs would also be more helpful if they explain that C.free() doesn't just show up when one does an import "C" and that they will likely need to include <stdlib.h> inside the comment section with compilation arguments.  Both of those things would have been incredible time savers.

Let's start with documentation and move to vet if someone can show this meets the frequency bar.

This looks fixed. In golang.org/cmd/cgo I see:
// Go string to C string
// The C string is allocated in the C heap using malloc.
// It is the caller's responsibility to arrange for it to be
// freed, such as by calling C.free (be sure to include stdlib.h
// if C.free is needed).
func C.CString(string) *C.char

So both the fact that the caller must free and the note about stdlib.h are already there.
Closing.


AVS missing info in docs about what to do when the extra cluster is in a failed state

Hi, I was reading the https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/scenarios/azure-vmware/eslz-platform-automation-and-devops
I can see information about what to do when the AVS Instance is in status Failed but what about if the AVS instance is successful but the extra cluster you want to add is in a failed status? Should I also make a support request and let MS delete the cluster because from what I have experienced I was not able to delete the extra cluster from the portal or with PowerShell, the error message told me something like I can not edit a resource in a failed state .

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed4fc81d-ca72-58f0-d869-60d5e4890bd2
Version Independent ID: 3c4680f2-d3be-b554-079f-d3de36076e77
Content: Enterprise-scale platform automation for Azure VMware Solution - Cloud Adoption Framework
Content Source: docs/scenarios/azure-vmware/eslz-platform-automation-and-devops.md
Service: cloud-adoption-framework
Sub-service: scenario
GitHub Login: @ScottHolden
Microsoft Alias: scholden

Hi @DWeda1,
I'd recommend opening a Microsoft support case so support/engineering can advise on why the operation failed and look at options for remediation. Depending on the state of the Private Cloud/Cluster you may not be able to edit/modify either resource (as you mentioned).
I'll work with @prasad3017 and team to have this added to the documentation.

#please-close


T265 manual exposure

[Do not merge]
This PR unlocks T265 manual exposure controls -

To control exposure, AUTO_EXPOSURE option must be set to 0 prior to streaming
AUTO_EXPOSURE will reset after each streaming session to 1
When in manual-exposure mode, pose frames will fail to arrive (the algorithm requires auto-exposure)
Once in manual-exposure, EXPOSURE and GAIN options can be used

TODO: Clean-up

We definitely do not recommend trying to set exposure manually for T265 tracking performance, but if you are treating T265 as a raw data only sensor this is not an unreasonable thing to adjust.

@bfulkers-i
If the manual exposure is enabled, the pose data is invalid?


Create World-Airforce-Insignia.netkan

Ive never created a mod before. This is really simple; it just inserts lots of a range of new flags based on historic or current airforce roundels, for adding to plane designs.    Hopefully people will find it useful.   I just hope I've done this right!

@politas OK. I think I've done the things you mentioned now.  (I assume "any" was meant to be in quotes - hope this is right).   I've also released 1.0 with an attached zip file of the mod without version numbers etc.  I hope this is all OK.    Many thanks for all your help so far! https://github.com/chaseAEd/World-Airforce-Insignia/releases

The GitHub release is fine now. Removing that comma will make it all work, now.

Done. Thanks @politas  and @Dazpoet for your help. Hopefully it all OK now?

All is fine and after I've pushed the merge button a few seconds from now your mod will be on the expressway to CKAN users :)
Many thanks for adding your mod to our archive :)


fix cache invalidation in HttpUriPlugin

What kind of change does this PR introduce?
fix cache invalidation. related to https://github.com/webpack/webpack/issues/15366

should not store partial result when following redirect

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

Thanks


Sudden Break in the Production API

@ramonaspence late last night the script on the production server started returning an error.
I haven't dug into it a lot yet.
I though perhaps Meetup had changed / deprecated their REST API, since their API docs now list GraphQL, but I can still manually pull up the events URL
https://api.meetup.com/Code-for-Greenville/events?&sign=true&photo-host=public&status=upcoming,cancelled,past&page=50
Could you test it on your local system and see if it's breaking there too?

Possibly related
February 10, 2022

Removal of event data feeds
Meetup will no longer support group events data feeds in the following output formats: ATOM, JSON & CSV. We will continue to support the RSS event feed. If you are using ATOM, JSON or CSV feeds, please migrate to the RSS feed for your group.

Actually, this break may be in Evenbrite.
I commented out the Eventbrite function locally and the Meetup function seems to work.  When I isolated it to only run the Eventbrite stuff, it breaks with the same error as on production.
    raise TypeError('Object of type %s is not JSON serializable' %
TypeError: Object of type module is not JSON serializable

Okay, I've got the same TypeError locally. I'll look into it and edit this comment with more info.

@allella
Okay got it.
In format_eventbrite_events the uuid field for the venues list is just pointing to "uuid", like this:
if type(event.get('venue_id')) == str:
                event_dict = {
                    'event_name': event.get('name').get('text'),
                    'group_name': group_name,
                    'venue': venues[event.get('venue_id')],
                    'url': event.get('url'),
                    'time': event.get('start').get("utc"),
                    'tags': tags,
                    'rsvp_count': None,
                    'created_at': event.get('created'),
                    'description': event.get('description').get('text'),
                    'uuid': uuid,
                    'nid': nid,
                    'data_as_of': datetime.datetime.utcnow().strftime('%Y-%m-%dT%H:%M:%SZ'),
                    'status': normalize_eventbrite_status_codes(event.get('status'))
                }

It's possible that we are encountering an in-person meeting, and thus one that has a venue object, for the first time since that change was made. Changing the line so that 'uuid' is set to a unique_id defined before it, gets rid of the error.
I'll spin up a branch for this change and test it tomorrow evening.

Great. Thanks.  I've temporarily disabled the Eventbrite function on production, so it's mostly not breaking things.
I may need to check the meetups using Eventbrite on the Hackgreenville site because it tries to cache and save events, so I'm wondering if this change will cause some HG events to show as cancelled and/or duplicate due to the way that site works.


Docking x Octane

Closes #19

Codecov Report
Patch and project coverage have no change.

Comparison is base (8e8e20f) 97.55% compared to head (8796a87) 97.55%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff            @@
##               main      #20   +/-   ##
=========================================
  Coverage     97.55%   97.55%
  Complexity      130      130
=========================================
  Files            44       44
  Lines           614      614
=========================================
  Hits            599      599
  Misses           15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


create-platformatic: Improve generated package.json files

Generation of package.json
The generation of package.json files by the create-platformatic CLI is inconsistent:

DB apps always have a generated package.json.
Runtime apps always have a generated package.json.
Composer and Service apps only have a generated package.json if they're being generated as a standalone app, but don't have a package.json if they're being generated as a service for a Runtime application.

Issues this causes:

If a service doesn't have a package.json, running npm install X in a service directory without a package.json adds that dependency to the Runtime project's root package.json. This is confusing as in this context you probably don't realise that the service doesn't have a package.json (this bit me a couple of times).
If a Runtime service doesn't have a package.json (which contains npm run scripts e.g. start) you have no way to independently run that application.
Lots of tooling in the JavaScript ecosystem expects each application directory to contain a package.json. This includes monorepo tooling, which is helpful to use with the services in a Runtime app.

Proposal: Always generate a package.json with relevant npm run scripts for every type of service in every context.
Dependencies in package.json files
All service types have platformatic and fastify as dependencies. In a Runtime app, if you create a DB service, you end up with those dependencies duplicated: they're in the Runtime project's root package.json and in the DB service's package.json.
Proposal: Don't add platformatic or fastify as dependencies in the package.json for Runtime services. Only add them to the Runtime project's root package.json.
name field in generated package.json files
The package.json files that are generated by create-platformatic don't contain a name field.
The benefits of setting a name field in package.json files:

A lot of JavaScript ecosystem tooling requires a name field to work, including monorepo tooling.
Makes it easy to see which service the package.json is for — this is especially important in a repo with multiple services.
Could be used in the generated OpenAPI schemas to set distinct service names instead of the generic names that are currently used e.g. Platformatic DB.
It could be treated as the source of truth for service names - useful for logs and potentially more robust than deriving Runtime service names from directory names. Other tooling tends to treat this as the source of truth for an application's name.
The Platformatic Client generator doesn't work if you point it at a Runtime service that contains a package.json without a name field (needs to be retested).

Proposal: Always set the name field in generated package.json files.

This is fixed


React hook form

Please add the ability to use the register object directly with the input, so that we can validate them with React Hook form

I've found a temporary solution:
 <Controller                   name="tags"                   control={control}                   rules={{ required: true }}                   render={({ field }) => <TagInput                     placeholder="Enter a topic"                     tags={tags}                     id="tags"                     maxTags={5}                     minTags={2}                     value={field.value}                     className={w-full ${errors.tags && 'border border-red-400'}}                     setTags={(newTags) => {                       setTags(newTags);                       field.onChange(newTags)                     }}                     title="Select up to 5 tags"                   />} />

Hey @Codemaine. I'll take a look at this today

@Codemaine Thank you for your suggestion and for engaging with the development of the component. After carefully considering the proposal to integrate React Hook Form's control and rules directly into TagInput, I have decided to not integrate the change. There isn't a compelling reason to tightly couple the TagInput with React Hook Form by handling control and rules directly, it's generally better to use Controller. This approach keeps the component flexible and clean, focusing on its primary functionalities while relying on React Hook Form to handle form state and validation externally


Coding Challenge: Rubik's Cube Solver using Neural Network

Coding challenge: A fully functional Rubik's cube solver. Something similar to this https://www.google.com/logos/2014/rubiks/iframe/index.html. Also use a neural network to create a solution for the cube and maybe then apply it. That'll be cool.

This sounds really interesting! I copied it over to the Rainbow-Topics repository and it is now available here.


feat: add logic in replication for handling rows/cells that may exceed thresholds

adding capabilities to replication library to control the shape of data as it is replicated to bigtable. the controls are disabled by default, and when enabled, allow users to filter rows and cells which may block replication. The configurations have unit tests as well have been run through a series of tests for a live deployment.

Reference, main branch PR: https://github.com/googleapis/java-bigtable-hbase/pull/4315


Information on adding custom log appenders to MI

Description:
We cannot use log4j2 extensions such as custom appenders and customer layout directly with the MI. For example, custom appender [1] cannot be used with MI by adding its jars to <MI_HOME>/libs folder.

Log4j2 in WSO2 Micro Integrator works in an OSGI environment. Therefore, in order for custom appenders to work, we need to build the module containing the appender (the custom appender class that we refer to in log4j2.properties file) as a plugin. In the custom appender [1], it is the appender-log4j2 module that contains Log4j2Appender class.
To build it as a plugin, we need to use the maven-bundle-plugin with maven-compiler-plugin in the pom.xml file of the relevant module, which is the appender-log4j2 module in this case. Please find the configuration[2] I have used in the pom.xml file of the module.
Then you should rebuild the related module with this configuration and add the plugin created in target folder to <MI_HOME>/dropins.
Finally, the custom appender can be configured as following.

appender.log4j2Custom.type = Log4j2Appender
appender.log4j2Custom.name = log4j2Custom
appender.log4j2Custom.layout.type = PatternLayout
appender.log4j2Custom.layout.pattern = [%d] %5p {%c} - %m%ex%n

[1]. https://github.com/bluedenim/log4j-s3-search
[2]. pom.zip
**Suggested Labels:**Improvements

PR to master: https://github.com/wso2/docs-ei/pull/2681/files

PR to master: https://github.com/wso2/docs-ei/pull/2681/files


[ISSUE #2357] Reload the delay offset when ScheduleMessageService start

Make sure set the target branch to develop
What is the purpose of the change
When the master change occurs in the DLedger mode, a large number of delay messages and retry messages will be consumed repeatedly due to no delay offset reloading.
Brief changelog
Reload the delay offset when master changed
Verifying this change
Verified in my environment
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.1%) to 51.836% when pulling 7057eacabb4755dfdd8d3474d351a3612e1683b4 on RongtongJin:issue-2357 into 0239421fa59b67c423cf9fcabf5cd6edda0c2076 on apache:develop.

Codecov Report

Merging #2518 (7057eac) into develop (0239421) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2518      +/-   ##
=============================================
+ Coverage      45.95%   45.97%   +0.02%
  Complexity      4316     4316
=============================================
  Files            547      547
  Lines          36236    36237       +1
  Branches        4808     4808
=============================================
+ Hits           16651    16659       +8
+ Misses         17497    17484      -13
- Partials        2088     2094       +6

Impacted Files
Coverage Δ
Complexity Δ

...ocketmq/store/schedule/ScheduleMessageService.java
74.09% <100.00%> (+0.13%)
21.00 <0.00> (ø)

...ketmq/client/impl/consumer/PullMessageService.java
71.11% <0.00%> (-4.45%)
8.00% <0.00%> (-1.00%)

...he/rocketmq/client/impl/consumer/ProcessQueue.java
57.67% <0.00%> (-4.19%)
31.00% <0.00%> (-1.00%)

...ketmq/common/protocol/body/ConsumerConnection.java
95.83% <0.00%> (-4.17%)
13.00% <0.00%> (-1.00%)

...a/org/apache/rocketmq/filter/util/BloomFilter.java
59.13% <0.00%> (-2.16%)
25.00% <0.00%> (-1.00%)

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-1.50%)
16.00% <0.00%> (-1.00%)

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
73.60% <0.00%> (-0.51%)
17.00% <0.00%> (ø%)

...rocketmq/client/impl/factory/MQClientInstance.java
48.97% <0.00%> (-0.44%)
89.00% <0.00%> (ø%)

.../apache/rocketmq/logging/inner/LoggingBuilder.java
63.60% <0.00%> (-0.32%)
3.00% <0.00%> (ø%)

...org/apache/rocketmq/store/DefaultMessageStore.java
56.37% <0.00%> (-0.20%)
109.00% <0.00%> (ø%)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0239421...7057eac. Read the comment docs.


Release 1.0.0 or (at the very least) 1.0.0-beta.9

There hasn't been any changes to the code base in a while and I know this code is being used in production, so I'd recommend tagging a 1.0.0 release. Congrats!
But, please merge https://github.com/jptaranto/typey/pull/7 first. :-)

@jptaranto Thanks for merging #7!
Can you publish a new release so we can get those fixes in the wild?

Hey @JohnAlbin! Sorry I've only just published now. Still getting used to a certain new family member :)
It will be beta.9 for now. Waiting on full documentation and a few shorthand/helper functions for 1.0 proper.

1.0.0 tagged and released today!


26 move r python installers into their own directories

This errors for me installing into an empty directory:
(carpenpi) ethan@system76-pc:~$ offlinedatasci setup all test
Namespace(command='setup', selection='all', path='test')

Destination:  test/r/R-4.2.0-win.exe
Download path:  https://cran.r-project.org/bin/windows/base/R-4.2.0-win.exe
****Downloading file:  test/r/R-4.2.0-win.exe
Traceback (most recent call last):
  File "/home/ethan/miniconda3/envs/carpenpi/bin/offlinedatasci", line 8, in <module>
    sys.exit(cli.main())
  File "/home/ethan/miniconda3/envs/carpenpi/lib/python3.10/site-packages/offlinedatasci/cli.py", line 29, in main
    download_and_save_r_installer(ods_dir)
  File "/home/ethan/miniconda3/envs/carpenpi/lib/python3.10/site-packages/offlinedatasci/main.py", line 33, in download_and_save_r_installer
    download_r_most_current_ver(latest_version_url_win, destination_path)
  File "/home/ethan/miniconda3/envs/carpenpi/lib/python3.10/site-packages/offlinedatasci/main.py", line 120, in download_r_most_current_ver
    urllib.request.urlretrieve(download_path, destination_path2)
  File "/home/ethan/miniconda3/envs/carpenpi/lib/python3.10/urllib/request.py", line 251, in urlretrieve
    tfp = open(filename, 'wb')
FileNotFoundError: [Errno 2] No such file or directory: 'test/r/R-4.2.0-win.exe'

Looks like maybe case sensitivity on the directory name. You're creating "R" but downloading into "r", which won't work on some systems. Let's just switch to "R" in both places.


API CI job 'build-and-validate' throws dubious ownership error

Which area this feature is related to?
/kind bug

Which area this bug is related to?

/area ci
/area api
Bug Summary
Describe the bug:

The CI job 'build-and-validate' fails on the step 'Check typescript model generation' due to an error which happens when trying to run the openapi-generator from https://github.com/kubernetes-client/gen. This error seems to be caused by  unresolved issues between newer versions of git and GitHub runners: https://github.com/actions/runner-images/issues/6775#issuecomment-1368409361.
Here is a list of issues which provides more detail on this:

kubernetes-client/gen#236
actions/runner-images#6775
actions/checkout#915

To Reproduce:

Create a PR under devfile/api and let the job 'build-and-validate' run. Output of such a case can be seen here: https://github.com/devfile/api/actions/runs/4196247484/jobs/7276947737
Expected behavior

/source/openapi-generator / should be able to execute as expected.
Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

/source/openapi-generator /
fatal: detected dubious ownership in repository at '/source/openapi-generator'
To add an exception for this directory, call:

	git config --global --add safe.directory /source/openapi-generator
Error: Process completed with exit code 128.

Additional context

Any workaround?

None.
Suggestion on how to fix the bug

The commit revision for kubernetes-client/gen under build/typescript-model/generate.sh#L9 to reflect the changes introduced in kubernetes-client/gen#237 which fixes this issue.
Target Date: 03-03-2023

blocked by kubernetes-client/gen#238

Workaround found: https://github.com/devfile/api/pull/1045/commits/6a30c432be998e18d43736f531afda7bff84b8d7
kubernetes-client/gen#238 is no longer blocking.


TBJ-0: create Sketelon Spring Boot project

create Sketelon Spring Boot project for TBJ

Implemented in https://github.com/YuraL556/telegrambot/pull/20


Use dithering to fade DirectionalLight shadow splits between each other

See also https://github.com/godotengine/godot/pull/48776 (this does not supersede it, as both techniques can work together).
This provides a cheaper alternative to the Blend Splits property. It doesn't look as good, but it still helps make split transitions much less noticeable.
This PR is marked as a draft, since we'll need to revise how blend splitting is defined in DirectionalLight to move it to an enum project setting instead (None (Fastest), Dither (Fast), Blend (Average)).
This can be backported to 3.x's GLES3 backend and possibly GLES2.
Performance comparison
OS: Fedora 34
GPU: NVIDIA GeForce GTX 1080 (driver version 465.31)
With the project used for the screenshots:
No dithering
Project FPS: 200 (5.0 mspf)

Dithering
Project FPS: 198 (5.0 mspf)

Blending
Project FPS: 194 (5.1 mspf)

Preview
Directional shadow size was decreased from 4096 to 1024 to make the difference between each split blending mode more noticeable. In practice, the dithering pattern won't be as noticeable as it is here.
Click to view at full size.
No dithering

Dithering

Blending

it is the same, so the best way is use dithering.

They're not the same, look at the full res picture.

This is pretty cool, I think this could be a transparent optimization when using deferred or mobile rendering but would not make it on by default.

it is the same, so the best way is use dithering.

No, it isn't. Zoom in on the transitions in the dithering photo.


feat(glitter): add support for glitter

Related to #2698 which was force-pushed by mistake and originally created by @Milo123459
The problem with this PR is that the icon is not pure SVG and includes an image. It's about 13Kb when we're now aiming for 2Kb.
It's true this would be just one file in a project... @Milo123459 is there a way to make this file size smaller and pure svg?

I wouldn't know, I just converted a PNG to a SVG

How did you created the icon? Did you used illustrator, photoshop, other?

I stole the windows default emoji. I'm very creative!

Then we'll have to work on an svg version for this before publishing. Is there any chance to get the windows default emoji source?

I doubt it

I've created it with illustrator:

7kb not ideal, but taking into account this will be just one file per project...
It will be released in the next deployment.

Sounds good.

I made a version from scratch based on the PNG:
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><title>file_type_glitter</title><path d="M29.7,18.775C29.552,14.634,27.222,9.9,22.774,4.7a2.5,2.5,0,0,0-3.515-.272,2.651,2.651,0,0,0-.24.234,16.83,16.83,0,0,0-8.5-2.66A8.453,8.453,0,0,0,4.366,4.344a8.7,8.7,0,0,0-2.3,7.009,18.65,18.65,0,0,0,2.226,9.3,24.506,24.506,0,0,0,4.764,6.3l.<IP_ADDRESS>a2.492,2.492,0,0,0,3.473.059,17.109,17.109,0,0,0,8.928,2.926,8.453,8.453,0,0,0,6.149-2.338C29.75,25.566,30.47,22.417,29.7,18.775Z"/><ellipse cx="16.007" cy="16.009" rx="9.022" ry="14.666" transform="translate(-6.631 15.995) rotate(-44.968)" style="fill:#0078d7"/><path d="M11.022,26a.74.74,0,0,1-.506-.215l-.09-.087a22.7,22.7,0,0,1-4.511-5.926A15.471,15.471,0,0,1,4.837,7.1a.723.723,0,0,1,.905-.429.674.674,0,0,1,.463.834L6.2,7.534c-2.9,8.287,2.7,14.8,5.245,<IP_ADDRESS>.<IP_ADDRESS>a.653.653,0,0,1,.008.925c-.011.012-.024.024-.036.035A.743.743,0,0,1,11.022,26Z" style="fill:#0078d7"/><path d="M21.113,25.836a14.464,14.464,0,0,1-10.627-4.891,4.767,4.767,0,0,1-.427-.571C4.927,12.317,6.347,8.868,8.445,7.393a4.659,4.659,0,0,1,3.346-.755c9.35,1.3,10.521,8.753,10.531,8.828a.68.68,0,0,1-1.346.2h0C20.937,15.4,19.91,9.147,11.6,7.99A3.311,3.311,0,0,0,9.224,8.5c-2.28,1.6-1.578,5.558,1.978,11.138a3.128,3.128,0,0,0,.3.4A12.925,12.925,0,0,0,23.2,24.3a3.407,3.407,0,0,0,2.289-1.449c1.414-2.112,2.627-7.009-5.138-16.083a.68.68,0,1,1,1-.924c.<IP_ADDRESS>.034.039,8.348,9.756,6.862,15.294,5.234,17.725a4.762,4.762,0,0,1-3.2,2.035A14.542,14.542,0,0,1,21.113,25.836Z" style="fill:#3a96dd"/><path d="M12.955,9.244h-.176a1.973,1.973,0,0,0-1.937,1.7,8.349,8.349,0,0,0-.061,1A8.828,8.828,0,0,0,14.17,18.57,10.148,10.148,0,0,0,20.835,21h.178a1.97,1.97,0,0,0,1.937-1.7,8.16,8.16,0,0,0,.062-1,8.609,8.609,0,0,0-3.056-6.5A10.626,10.626,0,0,0,12.955,9.244Z" style="fill:#b4a0ff"/><path d="M14.719,11.8h-.1a1.107,1.107,0,0,0-1.073.982,4.842,4.842,0,0,0-.034.577,5.4,5.4,0,0,0,5.57,5.217h.1a1.11,1.11,0,0,0,1.073-.982,5.283,5.283,0,0,0,.034-.576A5.4,5.4,0,0,0,14.719,11.8Z" style="fill:#fff"/></svg>

Cool, my version was around 7kb. Let's go with this one.


Allow HNC to propagate changes to CRD.

Fix #53
Currently, HNC are clearing out most of the metadata when doing an update request, which works fine for most types, but fails for CRDs. This PR allows HNC to propagate changes to CRD by setting 'ResourceVersion' explicitly when performing an update.

NB: this is a continuation of https://github.com/kubernetes-sigs/multi-tenancy/pull/1513

You're absolutely right, it's delete-type. Thanks!
On Fri, Jul 9, 2021 at 11:35 AM Justin Huang @.***>
wrote:

@.**** commented on this pull request.
In test/e2e/issues_test.go
https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/59#discussion_r667040003
:

     metadata:

       type: object

     spec:

       description: EETestSpec defines the desired state of EETest

       properties:

         foo:

           description: Foo is an example field of EETest. Edit eetest_types.go

             to remove/update

           type: string

       type: object

   type: object

served: true
storage: true`

// create CRD and set the propagation strategy for it.

MustApplyYAML(crd)

MustRun("kubectl hns config set-resource eetests --group e2e.hnc.x-k8s.io --mode Propagate --force")

Maybe run the command kubectl hns config delete-type --group
e2e.hnc.x-k8s.io --resource eetests to delete this type is better?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/59#discussion_r667040003,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE43PZENF2SRSTCC4MZ5Z53TW4JNJANCNFSM5AB4TRRQ
.

Sorry can you please squash those two commits?

sry, Fetch and Merge button is triggered on this branch by accident, I've force pushed, nothing have changed.


python36Packages.yamllint: 1.11.1 -> 1.12.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-yamllint/versions.
meta.description for python36Packages.yamllint is: '"A linter for YAML files"'.

Checks done (click to expand)

built on NixOS
/nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/bin/.yamllint-wrapped passed the binary check.
/nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/bin/yamllint passed the binary check.
2 of 2 passed binary check by having a zero exit code.
2 of 2 passed binary check by having the new version present in output.
found 1.12.1 with grep in /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1
directory tree listing: https://gist.github.com/95e9103edd2a37e9b153229e8cbc5b3d
du listing: https://gist.github.com/dec439bd4643030820d6942b8db6e47a

Outpath report (click to expand)

Outpath difference report
8 total rebuild paths
2 package rebuilds
2 x86_64-linux rebuilds
2 i686-linux rebuilds
2 x86_64-darwin rebuilds
2 aarch64-linux rebuilds
First ten rebuilds by attrpath
python27Packages.yamllint
python36Packages.yamllint

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python36Packages.yamllint https://github.com/r-ryantm/nixpkgs/archive/afeba5a36f0e88ac6b82a34c001b35d31314ce9f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1
ls -la /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/bin

cc @mikefaille for testing.

Success on aarch64-linux (full log)
Attempted: python36Packages.yamllint
Partial log (click to expand)
Successfully installed yamllint-1.12.1
/build/yamllint-1.12.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1/lib  /nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1/bin
patching script interpreter paths in /nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1
checking for references to /build in /nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1...
wrapping `/nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1/bin/yamllint'...
/nix/store/r0cpy7h5awccqwzfhcm2flpyn8ljaa1h-python3.6-yamllint-1.12.1

Success on x86_64-linux (full log)
Attempted: python36Packages.yamllint
Partial log (click to expand)
Successfully installed yamllint-1.12.1
/build/yamllint-1.12.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/lib  /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/bin
patching script interpreter paths in /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1
checking for references to /build in /nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1...
wrapping `/nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1/bin/yamllint'...
/nix/store/zayv252b1kz26rkgkkav39cb97gywgbd-python3.6-yamllint-1.12.1

Success on x86_64-darwin (full log)
Attempted: python36Packages.yamllint
Partial log (click to expand)
  The script yamllint is installed in '/nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed yamllint-1.12.1
/private/tmp/nix-build-python3.6-yamllint-1.12.1.drv-0/yamllint-1.12.1
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1/lib  /nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1/bin
patching script interpreter paths in /nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1
wrapping `/nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1/bin/yamllint'...
/nix/store/wslkdw9a2kf82p6n9nmzj76yvy2a1xig-python3.6-yamllint-1.12.1


support indicate

how  to receive the device indicate value?

You can check if  what mechanism is supported bu a characteristic directly on an instance
of Characteristic https://github.com/Polidea/FlutterBleLib/blob/589ed5770d9796e390c73945d3b520d12176ef16/lib/characteristic.dart#L22
If you want to observe a value then just call monitor method in the same way as if the characteristic would be notifiable.
On vanilla Android BLE API it is possible to choose whether notification or indication is setup if a characteristic supports both but the iOS does not allow to choose—that is why it is not possible to do so in this library.

OK，I got it ，thank you very much！


Lookup default AMIs.

If no default machine pool AMI is set, we will lookup the latest for
RHCOS and store it there for use on any pools that do not explicitly
store their own AMI. This lookup is done with code from
openshift-install.
In future we expect the RHCOS image to use to be a part of the release
image metadata.

/lgtm


[WIP] Add TinyDbObserver for local file system alternative.

As per #121 , this is the implementation of a TinyDBObserver that uses tinydb for metadata and hashfs for the local file system.

Tests written and all run locally on Mac OS for py27, py33, py34 and py35.

Outstanding test failures / tasks are as follows:

[ ]  File permission error in appveyor when attempting to read a file from a temporary directory.
[x]  Errors in running coverage
[x]  Add command line option for using tinydb observer
[x]  Add file retrieval method for convinience.
[x]  Documentation needs updating

Coverage increased (+0.7%) to 87.728% when pulling 8b1f5dcdc31415e89842540c5db4cba53db78b15 on MrKriss:feature-tinydb-observer into a7b8753abcbfe9906597cc6c8820d2eb915ca09c on IDSIA:release/0.7.0.

Coverage increased (+0.6%) to 87.689% when pulling fd8a78f4d8ce31c789a75c889a02d4b87e9d3070 on MrKriss:feature-tinydb-observer into a7b8753abcbfe9906597cc6c8820d2eb915ca09c on IDSIA:release/0.7.0.

Coverage increased (+0.7%) to 87.802% when pulling 9061f96d7930b7d7767378459c8ec44d30a5e400 on MrKriss:feature-tinydb-observer into a7b8753abcbfe9906597cc6c8820d2eb915ca09c on IDSIA:release/0.7.0.

Coverage increased (+1.3%) to 88.322% when pulling c70b35e00e4bd40dd82d8eae00d24cc38409e556 on MrKriss:feature-tinydb-observer into a7b8753abcbfe9906597cc6c8820d2eb915ca09c on IDSIA:release/0.7.0.

Coverage increased (+1.3%) to 88.322% when pulling 4ab795bdfdcb41a640cae70bc54c1be6ce2f58e6 on MrKriss:feature-tinydb-observer into a7b8753abcbfe9906597cc6c8820d2eb915ca09c on IDSIA:release/0.7.0.

Ok, this is pretty much ready to review now. Though I'm not sure whats going on with the appveyor build. Has this been successful on the release branch?

Nice work! I have to say, I'm quite impressed with the quality of this PR.
I'm merging it into the release/0.7.0 branch, so it'll roll out with the next release.
The appveyor problem is probably a failure on one of my features, so don't worry about it.
Thank you so much!


Multiple tests hanges, probably on shutting down

Some tests might fail to stop after a long time (60 seconds). The ones that I have seen are persist3, fail_no_agree and basic_agreement. It does not make sense for basic_agreement to hang.
The test usually uses no CPU when it hangs. That suggests either deadlock or infinite waiting for something that will never happen.

The issue here is very, very interesting, caused by a combination of behavior of labrpc, and holding lock for too long in ruaft test utils.
It all started with a harmless line in labrpc. Before the network reference is dropped, the last thing the main network thread did was to tell the world that it has stopped
        network.lock().stopped.store(true, Ordering::Release);

In the control code of ruaft tests, shutting down involves removing all servers from the network, which requires lock-holding:
        let mut network = self.network.lock();
        for i in 0..self.server_count {
            network.remove_server(Self::server_name(i));
        }
        network.stop();
        for raft in &mut self.state.lock().rafts {
            if let Some(raft) = raft.take() {
                raft.kill();
            }
        }

After that, it waits for all raft instances to be killed, without releasing the network lock. So while it is killing raft instances, the network reference won't be dropped.
Now, the futures still in the network's incoming packet queue, might have reference to servers, which has references to raft instances, which prevented all raft references to be dropped. This can happen when a RPC task is dispatched to a server, but has not yet returned. The task would block on a future returned by a method of that server. Boom!
It looks like the following

Test control holds network lock, while blocked on killing raft instances.
Network thread blocked, cannot drop network reference.
Network has a reference to a mpsc queue, which is not dropped and thus not drained.
The mpsc queue has a dispatched task.
The dispatched task is blocked on a future.
The future references one of the servers.
The server references the raft instance, which cannot be dropped.
The raft instance cannot be killed with outstanding references.
Test control cannot proceed.

Now what we need to do is simply to drop the network lock before killing rafts.

Fixed.


System.TimeoutException

Hello @gmenounos -
I'm receiving the following from my ECU:
C:\Users\[REDACTED]\Documents\Autos\TDI\kw1281test_0.93.0-beta_Win10> .\kw1281test.exe com4 9600 1 ReadIdent
KW1281Test: Yesterday's diagnostics...Today.

Version 0.93.0-beta (https://github.com/gmenounos/kw1281test/releases)
Args: com4 9600 1 ReadIdent
OSVersion: Microsoft Windows NT 10.0.19045.0
.NET Version: 8.0.0
Culture: en-US
Opening serial port com4
Sending wakeup message
Reading sync byte
Keyword Lsb $01
Keyword Msb $8A
Protocol is KW 1281 (8N1)
Caught: System.TimeoutException The operation has timed out.
Unhandled exception: System.TimeoutException: The operation has timed out.
   at System.IO.Ports.SerialStream.ReadByte(Int32)
   at System.IO.Ports.SerialStream.ReadByte()
   at System.IO.Ports.SerialPort.ReadByte()
   at BitFab.KW1281Test.Interface.GenericInterface.ReadByte() in /Users/gmenounos/src/kw1281test/Interface/GenericInterface.cs:line 34
   at BitFab.KW1281Test.KwpCommon.ReadByte() in /Users/gmenounos/src/kw1281test/KwpCommon.cs:line 130
   at BitFab.KW1281Test.KW1281Dialog.ReadAndAckByte() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 442
   at BitFab.KW1281Test.KW1281Dialog.ReceiveBlock() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 384
   at BitFab.KW1281Test.KW1281Dialog.ReceiveBlocks() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 351
   at BitFab.KW1281Test.KW1281Dialog.Connect() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 91
   at BitFab.KW1281Test.Tester.Kwp1281Wakeup(Boolean ) in /Users/gmenounos/src/kw1281test/Tester.cs:line 39
   at BitFab.KW1281Test.Program.Run(String[]) in /Users/gmenounos/src/kw1281test/Program.cs:line 288

This occurs with any ECU command.  I have successfully used the VAG KKL cable on another ECU, and I have successfully used a ross-tech cable and VCDS on this ECU.  I am bench testing this ECU, so no other controllers are available.
Can you advise on best practices to troubleshoot this timeout?
Thanks,
Matt
PS: FYI, I'm a programmer by trade, but new to ECUs and the EDC15.

What's the part number of the ECU?

Thanks for your super fast response BTW!

@gmenounos part number is 038 906 012 FD

Make sure you have "Boot in Intelligent Mode" UNchecked in the VCDS settings. If it's checked and you uncheck it, you'll need to unplug the cable from the PC and plug it back in again for the setting to take effect.
And, you're successfully able to connect to this ECU on the bench with VCDS? And then you try kw1281test and it always gives the timeout?

I followed this procedure from the bench:

Connected to ECU via ross-tech with VCDS, confirmed successful reads from controller 1.
Unchecked "Boot in Intelligent Mode" in VCDS Options dialog, Applied and Saved config.
Disconnected power from ECU and disconnected Ross-Tech cable from laptop and ECU.
Reconnected Ross-Tech cable, tried .\kw1281test.exe com4 9600 1 ReadIdent on all four com ports (com1, com2, etc) - System.IO.FileNotFoundException on all 4 com ports.
Disconnected power from ECU and disconnected Ross-Tech cable from laptop and ECU.
Connected VAG KKL cable and executed .\kw1281test.exe com4 9600 1 ReadIdent.

Result:
 C:\Users\Matt Heitzenroder\Documents\Autos\TDI\kw1281test_0.93.0-beta_Win10> .\kw1281test.exe com4 9600 1 ReadIdent
KW1281Test: Yesterday's diagnostics...Today.

Version 0.93.0-beta (https://github.com/gmenounos/kw1281test/releases)
Args: com4 9600 1 ReadIdent
OSVersion: Microsoft Windows NT 10.0.19045.0
.NET Version: 8.0.0
Culture: en-US
Opening serial port com4
Sending wakeup message
Reading sync byte
Keyword Lsb $01
Keyword Msb $8A
Protocol is KW 1281 (8N1)
Caught: System.TimeoutException The operation has timed out.
Unhandled exception: System.TimeoutException: The operation has timed out.
   at System.IO.Ports.SerialStream.ReadByte(Int32)
   at System.IO.Ports.SerialStream.ReadByte()
   at System.IO.Ports.SerialPort.ReadByte()
   at BitFab.KW1281Test.Interface.GenericInterface.ReadByte() in /Users/gmenounos/src/kw1281test/Interface/GenericInterface.cs:line 34
   at BitFab.KW1281Test.KwpCommon.ReadByte() in /Users/gmenounos/src/kw1281test/KwpCommon.cs:line 130
   at BitFab.KW1281Test.KW1281Dialog.ReadAndAckByte() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 442
   at BitFab.KW1281Test.KW1281Dialog.ReceiveBlock() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 384
   at BitFab.KW1281Test.KW1281Dialog.ReceiveBlocks() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 351
   at BitFab.KW1281Test.KW1281Dialog.Connect() in /Users/gmenounos/src/kw1281test/KW1281Dialog.cs:line 91
   at BitFab.KW1281Test.Tester.Kwp1281Wakeup(Boolean ) in /Users/gmenounos/src/kw1281test/Tester.cs:line 39
   at BitFab.KW1281Test.Program.Run(String[]) in /Users/gmenounos/src/kw1281test/Program.cs:line 288
   at BitFab.KW1281Test.Program.Main(String[]) in /Users/gmenounos/src/kw1281test/Program.cs:line 31

Yes, I'm getting a consistent timeout from kw1281test everytime and yes, I'm able to successfully read the identity (VIN, etc) with VCDS on the bench.

Thanks for the detailed report. The reason kw1281test isn't working with your VCDS cable is that you need to install the RossTech Virtual COM Port (VCP) drivers in order for the VCDS cable to appear as a COM port. Instructions are here: https://sites.google.com/site/imnuts/home/install-setup-ross-tech-vcp-drivers
I'm not optimistic that that will magically fix your issue, but it's something you can try while I try to figure out what the problem is.

Try this new release: https://github.com/gmenounos/kw1281test/releases/tag/v0.94-beta
I added some additional logging.

@gmenounos your support is amazing! 🙏 🙇
TL;DR - Its working!
The long story...
I followed the steps to use the Ross-Tech KII-USB cable in the document that you gave me.  When I reached this section:

Now that VCP has been enabled, you should have a new option in Device Manager. Odds are, your computer didn't come with a serial (COM) or parallel (LPT) port, so Ports (COM & LPT) should be new for you. If it isn't, this will be a little more difficult, but not much. Expand the listing. If more than one item is listed, you'll need to find the correct item. Right click on one, or the only one, and select properties. If you have more than one, the manufacturer listed should be Ross-Tech. If it is, you selected the right one.

I did not have the Ports (COM & LPT) in the device manager, but there was another section called Other Devices which had a USB Com Device with no drivers identified.  However, I noticed in the Ross-Tech Drivers, there was another driver file called ftdiport.inf, so I followed the same steps to manually load that driver for the new, unknown USB COM device (which was identified as a Ross-Tech Device).
Once I loaded the ftdiport.inf, I ran the following successfully with the Ross-Tech KII-USB cable:
C:\Users\Matt Heitzenroder\Documents\Autos\TDI\kw1281test_0.93.0-beta_Win10> .\kw1281test.exe com5 9600 1 ReadIdent
KW1281Test: Yesterday's diagnostics...Today.

Version 0.93.0-beta (https://github.com/gmenounos/kw1281test/releases)
Args: com5 9600 1 ReadIdent
OSVersion: Microsoft Windows NT 10.0.19045.0
.NET Version: 8.0.0
Culture: en-US
Opening serial port com5
Sending wakeup message
Reading sync byte
Keyword Lsb $01
Keyword Msb $8A
Protocol is KW 1281 (8N1)
ECU: 038906012FD 1,9l R4 EDC G000SG  4102
Software Coding 00002, Workshop Code: 94774
Sending ReadIdent block
Ident: 3VWRP29M02M024932     VWZ7Z0A3840049
Sending EndCommunication block

Thank you so much again, for the amazing and fast support.  The outcome was better than expected - now I have one cable to rule them all!
I can code, but I haven't ever written any .NET. I'm quick to learn new languages though, so If there's any way I can support your project, I'd love too.  Want help with documentation or fixing bugs (or anything else)?


feat(hacbs-1112): add unit tests for pipeline adapter

Signed-off-by: srivickynesh<EMAIL_ADDRESS>

Closing this PR. Covering the code segment in #49 .


The "Mime-Version" header capitalization is considered a spam signal by rspamd

I noticed that the mail gem generates the MIME version header capitalized as Mime-Version as opposed to MIME-Version mentioned in the RFC 2045.
While this spelling is technically perfectly correct, it is specifically matched by an rspamd antispam rule called MV_CASE which effectively raises the spam score by 0.5 for all emails with such header. I traced down the original commit in rspamd, it has been there for years and seems to be included in the default configuration, but other than that I found no info about why this rule was added.
I briefly checked a few mail service providers and found that the header capitalization varies a lot:

GMail uses "MIME-Version"
FastMail uses "Mime-Version"
HEY uses "Mime-Version" (but, being a Rails app, perhaps it uses this gem to generate emails :) )

I'll be glad to open a PR if you're interested, thanks!

Fixed in https://github.com/mikel/mail/pull/1503

Thanks @mikel for taking a look at this!


MM-18531 Added Feature to Close Channel via Direct Message

Summary
This PR gives support for Closing a Direct Message under the DM username.
Decided to create a new component to handle this feature, instead of reworking the CloseChannel already in place due to the fact that the CloseChannel is based on isArchived.
Changes:

[X] UI
[X] Added Unit Tests

Ticket Link
Github: https://github.com/mattermost/mattermost-server/issues/12244
Jira: https://mattermost.atlassian.net/browse/MM-18531

Creating a new SpinWick test server using Mattermost Cloud.

Test server creation failed. See the logs for more information.

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3694.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hi @DarrellRichards, let us know if you have any questions about the feedback above. We'd be happy to help!  :)

@jasonblais @jespino I'll get this updated. I have been overseas and missed the comments.

No worries, thanks for the heads up!

Thanks @DarrellRichards - looks good to me from QA perspective!

Test server destroyed

Hi @DarrellRichards. Are you still going to have time to fix those issues? If not, we'd be happy to help finish off the last bit to get it in.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Apps team will help finish this and address the comments

Closing, moving to new PR. Thanks for the initial contribution @DarrellRichards 👏


Uncaught SyntaxError: Unexpected token import

Uncaught SyntaxError: Unexpected token import #1167 in app.js
import $ from 'jquery';

How can this bug be reproduced?

Step one
load the page with FoundationPress activated
Step two
check console.
Step three
mobile menu for instance doesn't work

What did you expect to happen?
that JS gets compiled correctly
What happened instead?
error on line 1
Please List the Following:

OS & version:
Mac OSX 10.11.6

Node version (node -v) [Node v4+ is required] :
node 5.6

FoundationPress version (see line 3 in package.json):
"version": "2.10.4",

Foundation version (found in node_modules/foundation-sites/package.json) :
<EMAIL_ADDRESS>

@tomhermans does jquery exist in node_modules/jquery? Were there any errors on npm install?

Yes. checked the folder and even re-done npm install. no messages

@tomhermans I can't reproduce on the same version of node and I'm on the exact same version of macOS. Just to make sure, did you build the theme assets with npm run start?

@tomhermans any update on this issue?


Remove whitespace at the end of a line

Describe your changes
In the management url textbox in the settings page of the client ui, if a space is added to the end of the input, then the connection fails (when the user enters a blank character at the end, he/she may not realize that he/she is entering a blank character), does this need to be done to deal with blank characters.

Checklist

[ ] Is it a bug fix
[ ] Is a typo/documentation fix
[x] Is a feature enhancement
[ ] It is a refactor
[ ] Created tests that fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove Swift 3-only Compatibility Shims

Now that we've dropped that language version.
Changes the ABI file but these are false positives – removed methods that could no longer be called because they were obsoleted in all supported ABI-stable versions.

@xedin a couple of tests confirming good diagnostics were relying on deprecated methods. I've updated them to the new error messages, which I don't think are worse.

@swift-ci please benchmark

@swift-ci please test source compatibility

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - a7c3aea54aa2822320694fc0b9940b9dbc149d5e

Build comment file:
Performance: -O

TEST
OLD
NEW
DELTA
RATIO

Improvement

NormalizedIterator_abnormal
2084
1798
-13.7%
1.16x

NSStringConversion
596
542
-9.1%
1.10x (?)

Performance: -Osize

TEST
OLD
NEW
DELTA
RATIO

Regression

ObjectiveCBridgeFromNSSetAnyObjectToString
77078
100936
+31.0%
0.76x

NSStringConversion
586
688
+17.4%
0.85x

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

--------------

@swift-ci please clean test linux platform


[Doc] A Developer-Friendly Documentation Website

The title conveys the topic.
The current documentation is API-focused. We need an improved documentation website to help more developers to build the ecosystem.
Framework
Let us discuss the documentation framework first. I am currently considering nextra and vitepress. I am unsure, but nextra seems better. What do you think?
Doc structure
The following aspects come to mind:

Getting Started (of course, every doc requires this)
Guides
Characters
Notes
Links
Operators
Tips
...
Newbie Villa
Op Sign
...
Framework-specific guides (#11 )
More...

Let me know if you would like to assist.

It's now on docs.crossbell.io

So can we close this now?

Sure


plasma-5: 5.14.5 -> 5.15.2

Motivation for this change
https://www.kde.org/announcements/plasma-5.15.0.php
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Marking WIP because I'm not confident in the patch changes and don't want to mislead-- leaving commit in case useful but until it's looked through more carefully I don't think it's ready.  Don't want to break folks' sessions in a small way that causes pain later :).

Hello, could you bump this to version 5.15.1 ?
https://kde.org/announcements/plasma-5.15.1.php

Hello, could you bump this to version 5.15.1 ?

Thanks, updated!

Now with 5.15.2

As far as I can tell, 5.15.2 is working for me :) Maybe time to merge this?

Been working for me as well, across updates tracked here.  Going ahead, thanks for testing!

This got to master now and the plasma test fails now.  I suspect it's related to this update.  In logs I newly see:
machine# [   38.594152] xsession[860]: /nix/store/mrwhgj95xjainwmp9dld9hzb1i8dm0jj-plasma-workspace-5.15.2-bin/bin/startkde: line 347: xmessage: command not found

but that one just disappeared when I added xorg.xmessage into test's systemPackages and did not fix the test, so these new lines seem closer to the cause
machine# [   38.561610] xsession[860]: /nix/store/mrwhgj95xjainwmp9dld9hzb1i8dm0jj-plasma-workspace-5.15.2-bin/bin/startkde: line 342: /nix/store/4p630wybyrzrggmjb5hm6c6nr19wq4g9-plasma-workspace-5.15.2/lib/libexec/kf5/start_kdeinit_wrapper: No such file or directory
machine# [   38.581609] xsession[860]: startkde: Could not start kdeinit5. Check your installation.

Any ideas?

relevant diff of startkde between 5.14.5 and 5.15.2 :
342c344
< LD_BIND_NOW=true /nix/store/4p630wybyrzrggmjb5hm6c6nr19wq4g9-plasma-workspace-5.15.2/lib/libexec/kf5/start_kdeinit_wrapper --kded +kcminit_startup
---
> LD_BIND_NOW=true /nix/store/iy34pfyzm86g7wmw6pqd36zjc8z2h3vm-kinit-5.54.0/lib/libexec/kf5/start_kdeinit_wrapper --kded +kcminit_startup

Found the problem, this line of patch is no longer applied : https://github.com/dtzWill/nixpkgs/blob/34a67fba04742dcbda122c50adec0d4b1871c38b/pkgs/desktops/plasma-5/plasma-workspace/plasma-workspace.patch#L443

@nyanloutre: are you planning to prepare a PR/patch against nixpkgs master?

@vcunat yes but if you already have something ready go ahead (I am currently building the plasma5 test on my machine)

No, on the contrary.  I'm doing too many things already.

See #59112 for fix


[Screensaver] Add black background option similar to slideshow function

Is your feature request related to a problem? Please describe.
I use Aves to show a slideshow of all the photos on my device using the Android builtin Screen Saver function. The screen saver settings shows has an option to either Fill or Fit the photo. When using the Fit mode, the background area is white.
The slideshow functionality which is very similar, uses a black background.
Describe the solution you'd like
I would like there to be an option to select what the background colour should be. Either White/Black option, or a colour picker.
Describe alternatives you've considered
I've tried using the slideshow functionality instead, but it does not start automatically.
Additional context
None.

Thanks for reporting this. It's a bug. I won't add a setting but I'll make it consistent with the slideshow.


Code to Remove large spaces between string.

Description
A comprehensive description about the Pull Request
Reference Issue number #149
issue_no must refer to the issue related to this PR, visit here
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: Check boxes using [x]

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Documentation Update

Checklist:

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, with problem description and my name.
[ ] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[ ] I have starred this repository.
[x] I have added a working sample/screenshot of the script.
[x] I have checked for trailing spaces in file names and none have them.
[x] I have added (your-name)[your-github-profile-link] in CONTRIBUTORS.md

@c0d1ng-Devta This will be your final contribution to this repository. Consider starring the repository!


I can not convert using OpenAI + Docker

Hello, and thank you for this great tool!! 🙌
I am trying to convert an EPUB to audiobook running the following command:
docker run --rm -v ./:/app -e OPENAI_API_KEY=my-openai-key ghcr.io/p0n1/epub_to_audiobook my_ebook.epub audiobook_output --tts openai
But I am getting this error:
/usr/local/lib/python3.11/site-packages/ebooklib/epub.py:1395: UserWarning: In the future version we will turn default option ignore_ncx to True.   warnings.warn('In the future version we will turn default option ignore_ncx to True.') /usr/local/lib/python3.11/site-packages/bs4/builder/__init__.py:545: XMLParsedAsHTMLWarning: It looks like you're parsing an XML document using an HTML parser. If this really is an HTML document (maybe it's XHTML?), you can ignore or filter this warning. If it's XML, you should know that using an XML parser will be more reliable. To parse this document as XML, make sure you have the lxml package installed, and pass the keyword argument features="xml" into the BeautifulSoup constructor.   warnings.warn( 2024-01-14 19:37:24 [INFO] Chapters count: 14. 2024-01-14 19:37:24 [INFO] Converting chapters from 1 to 14. 2024-01-14 19:37:24 [INFO] ✨ Total characters in selected book: 189325 ✨ Estimate book voiceover would cost you roughly: $2.85 Do you want to continue? (y/n) Traceback (most recent call last):   File "/app_src/main.py", line 134, in <module>     main()   File "/app_src/main.py", line 130, in main     AudiobookGenerator(config).run()   File "/app_src/audiobook_generator/core/audiobook_generator.py", line 70, in run     confirm_conversion(rough_price)   File "/app_src/audiobook_generator/core/audiobook_generator.py", line 15, in confirm_conversion     answer = input()              ^^^^^^^ EOFError: EOF when reading a line
I can't even select Y or N when prompting if I want to continue. Do you now what could I be doing wrong?

Let me check.

Looks like prompt input is not compatible with docker. Will find a way to resolve this issue.

Hi @amariani.
Replace your command into:
docker run -i -t --rm -v ./:/app -e OPENAI_API_KEY=my-openai-key ghcr.io/p0n1/epub_to_audiobook my_ebook.epub audiobook_output --tts openai

Then everything should be OK. You can type in y to confirm estimated cost.

Hi @p0n1, thanks!! It worked perfectly with the provided command! 🚀


Incorrect call value on suicide transaction

Describe the bug
In this transaction https://etherscan.io/tx/0x4f3638c40c0a5aba96f409cb47603cd30ed8ef084a9cba89169812d20fc9a04f if we query reth curl -X POST http://IP:8545/ -H "content-type: application/json" --data '{"id":0,"params":["0x10CC6B",["trace"]],"method":"trace_replayBlockTransactions","jsonrpc":"2.0"}' | jq we get:
{
      "output": "0x",
      "stateDiff": null,
      "trace": [
        {
          "type": "call",
          "action": {
            "from": "0x500a229a1047d3d684210bf1b67a26eb2994794a",
            "callType": "call",
            "gas": "0x1b0a0",
            "input": "0x41c0e1b5",
            "to": "0x1ab3b12861b1b8a497fd3248edcb7d844e60c8f5",
            "value": "0xb1a2bc2ec50000"
          },
          "result": {
            "gasUsed": "0x2a00",
            "output": "0x"
          },
          "subtraces": 1,
          "traceAddress": []
        },
        {
          "type": "suicide",
          "action": {
            "address": "0x1ab3b12861b1b8a497fd3248edcb7d844e60c8f5",
            "balance": "0xb1a2bc2ec50000",
            "refundAddress": "0x500a229a1047d3d684210bf1b67a26eb2994794a"
          },
          "result": null,
          "subtraces": 0,
          "traceAddress": [
            0
          ]
        }
      ],
      "vmTrace": null,
      "transactionHash": "0x4f3638c40c0a5aba96f409cb47603cd30ed8ef084a9cba89169812d20fc9a04f"
    }

First internal transaction has a value, which should be zero, as it is on Erigon and on parity traces on etherscan. Suicide transaction should include value which was withdrawn from contract.
This is Erigon reply:
          "trace": [
            {
              "action": {
                "from": "0x500a229a1047d3d684210bf1b67a26eb2994794a",
                "callType": "call",
                "gas": "0x15d88",
                "input": "0x41c0e1b5",
                "to": "0x1ab3b12861b1b8a497fd3248edcb7d844e60c8f5",
                "value": "0x0"
              },
              "result": {
                "gasUsed": "0xe8",
                "output": "0x"
              },
              "subtraces": 1,
              "traceAddress": [],
              "type": "call"
            },
            {
              "action": {
                "address": "0x1ab3b12861b1b8a497fd3248edcb7d844e60c8f5",
                "refundAddress": "0x500a229a1047d3d684210bf1b67a26eb2994794a",
                "balance": "0xb1a2bc2ec50000"
              },
              "result": null,
              "subtraces": 0,
              "traceAddress": [
                0
              ],
              "type": "suicide"
            }

Steps to reproduce
curl -X POST http://IP:8545/ -H "content-type: application/json" --data '{"id":0,"params":["0x10CC6B",["trace"]],"method":"trace_replayBlockTransactions","jsonrpc":"2.0"}' | jq
Node logs
No response
Platform(s)
Linux (x86)
What version/commit are you on?
reth Version: 1.0.0-rc.2
What database version are you on?
Current database version: 2
Local database version: 2
Which chain / network are you on?
mainnet
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct

[X] I agree to follow the Code of Conduct

this tx has a transfer value, so why should the top level value be 0?

Thanks for the fast response @mattsse :)


Fix heap_allocated reinsertion for refzero finalizer rescued objects

Fix heap_allocated reinsertion bug which affected refzero finalizer rescued objects. See test case in: https://github.com/oleavr/dukrecycle/ (a bug test case will be adapted in this branch based on that).

[ ] Adapt test case from dukrecycle, test that bug appears before and gets fixes by the diff
[ ] Add linked list consistency assertion helper which checks that prev/next and curr are linked correctly
[ ] Add more heap_allocated consistency asserts to linked list manipulation points, ensure assertion tests pass with them in place
[ ] Schedule backports to 1.4.1 and 1.3.3

@joshengebretson If the diagnosis/fix here is correct, this may be related to the finalizer issues you had a way back :) Here's hoping!

This fixes the stability issues we were seeing in the frida-gum test-suite! :heart:

@oleavr Big thanks for coming up with the repro case!

@svaarala What is the bug here, exactly?  I'm curious because I haven't yet seen the finalizer issues Josh had with Atomic in minisphere.

The diff really says it all, but in short, object rescued during refcount-triggered finalization need to be queued into the heap_allocated list. That queueing operation failed to update the "prev" pointer of the previous list head which resulted in an inconsistent heap_allocated list. With a suitable mix of later operations (e.g. finalizing again) this could trigger a read/write-after-free situation. It's a pretty significant bug and could have various weird side effects -- but only if an object is rescued during refcount-triggered finalization.

Could that potentially lead to a segfault?

I think so, though the problems were captured using ASAN/valgrind in practice.

Added the test case and checked that the test case catches the original issue.
Also added linked list consistency asserts where duk_heaphdr linked list is manipulated. Verified that test cases pass with the asserts in place, and that the asserts would have caught the original bug.


Fix initialization of access token expires_at with string value

Pull Request Test Coverage Report for Build 1065

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 1064:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 1065

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 1064:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

@pboling, please review & merge if everything is okay. I cannot set up any reviewers or assignees, do not why.

@Lomey Please make the changes recommended by @Lomey .
Meanwhile I am going to do some basic gem housekeeping.


Reuse of the color-yiq function

With a simple change it is possible to use the color-yiq function with other properties, not just "color"
// Color contrast
@mixin color-yiq($color, $prop: 'color') {
  $r: red($color);
  $g: green($color);
  $b: blue($color);

  $yiq: (($r * 299) + ($g * 587) + ($b * 114)) / 1000;

  @if ($yiq >= 150) {
    #{$prop}: #111;
  } @else {
    #{$prop}: #fff;
  }
}

.element-inside-primary {
  @include color-yiq(theme-color("primary"), 'background-color');
}

Just add the parameter "$prop: 'color'" that we can use other properties
This can be interesting when you want to assign a background that contrasts with a color.

It would be much better to change it to a function, so we can use it for whatever we like. Then the colors #111 and #fff should naturally use some variables so you can customize it.
Additionally it would be nice to provide one or more mixins that utilize the function.
Function
// Color contrast
@function color-yiq($color) {
  $r: red($color);
  $g: green($color);
  $b: blue($color);

  $yiq: (($r * 299) + ($g * 587) + ($b * 114)) / 1000;

  @if ($yiq >= 150) {
    @return $text-black;
  } @else {
    @return $text-white;
  }
}

Mixins
@mixin text-color($color: $body-bg) {
  color: color-yiq($color);
}

or
@mixin color-yiq($color: $body-bg, $prop: 'color') {
  #{$prop}: color-yiq($color);
}

A PR is welcome.

Mixin was renamed to be a function in #24426.


Check if Multitenant Hosting Rights are used for Windows client VMs

Rule request
Suggested rule change
Multitenant Hosting Rights can be used for Windows 10 client VMs to reduce VM running costs.
Applies to the following
The rule applies to the following:

Resource type: Microsoft.Compute/virtualMachines

Additional context
How to deploy Windows 10 on Azure with Multitenant Hosting Rights

Upcoming PR from me to be expected :shipit:.


Statement to disable for a single database throws an argument exception

EXEC msdb.managed_backup.sp_backup_config_basic
@database_name = 'MyDB'
,@enable_backup = 0;
SQL Server Managed Backup to Microsoft Azure cannot configure the database  'MyDB' because a container URL was either not provided or invalid. It is also possible that your SAS credential is invalid.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f448d2c-730b-9728-b43f-4ea080fc7861
Version Independent ID: 45828819-be38-5acc-ec47-7d696dffc74b
Content: Disable SQL Server Managed Backup to Microsoft Azure - SQL Server
Content Source: docs/relational-databases/backup-restore/disable-sql-server-managed-backup-to-microsoft-azure.md
Product: sql
Technology: backup-restore
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@degrover-cn  Thank you for the question.
Was this backup previously enabled using a storage container?
If so, please try using the @container_url parameter listed here to set the container.

That's helpful, thank you. I do recommend updating the document I submitted this ticket from.

You're welcome.  A note has been added.


[question] gitlab repository

Hi!
First of all, thanks you for your work..
I managed to set up a working satisfy instance but at some point, I can't figure out how to use it.
When trying to add a new "gitlab" repository, what information do I need to provide ?
What the purpose of it and does it works with self-managed gitlab ?
within parameters.yml, I can see gitlab.auto_add_repo and gitlab.auto_add_repo_type parameters and I don't know what I'm suppose to fill in with.
Is there any configuration examples or documentation about satisfy usage ?
Thanks.

@p418 I would recommend to start reading from satis configuration [1]. You can edit satis.json manually and see how it looks in admin page.
All parameters are self-explanatory, You can keep default values if they are unclear to You.
[1] https://getcomposer.org/doc/articles/handling-private-packages-with-satis.md


Fix Radio -> AUX switching in BM53 mode

Sometimes it switches back to radio while in AUX then finally goes back? This is dumb/bad.

Fixed and pulled.


How to flag an outgoing call as "Video"

First off, deep thanks for a great plugin and your contributions to the react-native community!
I'm making a videochat application. When my app receives an incoming I call displayIncomingCall() with hasVideo = true. in Recents I see the incoming call flagged as Video which is nice. When registering an outgoing call with startCall() I don't have that option though.. and in Recent it shows up as Audio. Is there a way to start an outgoing call and flag it as Video?

ping @ianlin is this plugin still being worked on?

yes, we are keep using this but have no time to develope new features.
this plugin works well without issue in our use case.

Thanks for the answer @zxcpoiu , I understand.


Add --json option to status command

Hope I'm doing this the right way :)
Linked with issue #531
GS.

Might be better if units and labels are not present in json output :

renault-api --json status
{"Battery level": "45 %", "Last updated": "2022-02-28 16:37:47", "Available energy": "11 kWh", "Range estimate": "88 km", "Plug state": "PlugState.UNPLUGGED", "Charging state": "ChargeState.NOT_IN_CHARGE", "Time remaining": "320 min", "Total mileage": "1141.37 km", "GPS Latitude": "some", "GPS Longitude": "where", "GPS last updated": "2022-02-28 16:35:47", "HVAC status": "off"}

GS

Think I'm done locally, but...
Output is a dict of json strings. Wouldn't it be better to get a fully structured object ?
{"battery-status": "{'timestamp': '2022-03-03T17:08:38Z', 'batteryLevel': 23, 'batteryTemperature': 20, 'batteryAutonomy': 48, 'batteryCapacity': 0, 'batteryAvailableEnergy': 6, 'plugStatus': 0, 'chargingStatus': 0.0, 'chargingRemainingTime': 185}", "cockpit": "{'totalMileage': 1224.35}", "location": "{'gpsDirection': None, 'lastUpdateTime': '2022-03-03T17:07:08Z', 'gpsLatitude': 12.345678, 'gpsLongitude': 12.345678}", "hvac-status": "{'socThreshold': 30.0, 'hvacStatus': 'off', 'lastUpdateTime': '2022-03-03T07:18:34Z'}"}
We could go this way  ?
        if ctx_data["json"]:             status_table["battery-status"] = response.raw_data             #items = [("battery-status", json.loads(response.raw_data), None)]         else:             items = [                 ...
That way the json is fully structured :
{"battery-status": {"timestamp": "2022-03-03T17:08:38Z", "batteryLevel": 23, "batteryTemperature": 20, "batteryAutonomy": 48, "batteryCapacity": 0, "batteryAvailableEnergy": 6, "plugStatus": 0, "chargingStatus": 0.0, "chargingRemainingTime": 185}}
GS

Same thing (return and no else at line 167 ?)

Yes please

Add a carriage return forprettier CI

mycode="ispretty" #or maybe not

oops... wrong button :x

I triggrred the workflow. Take a look at the results and I will review again tomorrow.

Another note: I have made a change in #537 to return early in case of KamereonResponseException
So your changes need to be rebased over latest main branch and un-indented again.

Another note: I have made a change in #537 to return early in case of KamereonResponseException So your changes need to be rebased over latest main branch and un-indented again.

So maybe It's better/necessary to create another PR ?

Another note: I have made a change in #537 to return early in case of KamereonResponseException So your changes need to be rebased over latest main branch and un-indented again.

So maybe It's better/necessary to create another PR ?

If you are not familiar with merge/rebase then maybe it's easier to create a new PR.

Closing for #539


clangd does not work with cross-compile Kernel

Description
I am trying to get my LSP to work with an out-of-tree Kernel module. I am building the module against a custom kernel (beagle-kernel). The host I am building on is x86_64. I am cross-compiling to arm64 using GCC.
My makefile is as follows:
obj-m += bcf-greybus-driver.o

KDIR ?= /lib/modules/$(shell uname -r)/build
PWD := $(CURDIR)

all:
	make -C $(KDIR) M=$(PWD) modules

clean:
	make -C $(KDIR) M=$(PWD) clean

I have generated a compiler_commands.json file using bear.
I also have some environment variables:
export KDIR=$HOME/Documents/Programming/BeagleBoard/beagle-linux
export ARCH=arm64
export CROSS_COMPILE=/usr/bin/aarch64-linux-gnu-

I  initially get some unsupported arguments errors, so I used the .clangd file to remove those args:
CompileFlags:
  Remove: [-fconserve-stack, -fno-allow-store-data-races]

However, I now get Invalid AST error whenever I try to do any LSP stuff.
Btw, LSP does not seem to work for the cross-compiled Kernel source, either whose compile_commands.json was created using scripts/clang-tools/gen_compile_commands.py.
I can verify that everything seems to work for a non-cross-compiled kernel I am using for something different, so the problem probably occurs due to cross-compilation.
Logs
lsp.log
System information
Output of clangd --version:d
clangd version 16.0.4 (Fedora 16.0.4-1.fc38)
Features: linux
Platform: x86_64-unknown-linux-gnu; target=x86_64-redhat-linux-gnu

Editor/LSP plugin: neovim v0.9.0
Operating system: Fedora Silverblue 38

From the log, the reason for the "invalid AST" error is:

Failed to prepare a compiler instance: unknown target ABI 'lp64'

Looking at the compile_commands.json, one of the arguments is -mabi=lp64, so maybe adding that to the Remove: [...] list in .clangd fixes it?

(See https://github.com/clangd/clangd/issues/734 for a previous occasional where this has come up)

Yes, removing -mabi=lp64 fixes the issue. Thanks.

For anyone interested, the lsp.log located in ~/.local/state/nvim/lsp.log if using neovim


Regression for test report in KMP project after migrating from 0.6.1 to 0.7.4

Describe the bug
After running ./gradlew koverHtmlReport the generated report has the next text:
shared: Overall Coverage Summary
No coverage information was found

Expected behavior
The test report should contain the coverage for main sourceSet like in 0.6.1
Reproducer

Create a Kotlin Multiplatform library project using Project create wizard with KMM plugin installed (https://plugins.jetbrains.com/plugin/14936-kotlin-multiplatform-mobile)
Add id("org.jetbrains.kotlinx.kover:0.7.4") in the shared module build.gradle.kts file to apply the plugin.
Run ./gradlew koverHtmlReport to generate a report.
Check generated HTML file.

Alternatively refer to the next reproducing project.
Test.zip
Reports

Environment

Kover Gradle Plugin version: 0.7.4
Gradle version: 8.3, 8.4
Kotlin project type: Kotlin/Multiplatform + Android

Looks like also need to add
koverReport {
    defaults {
        // add reports of 'release' Android build variant to default reports - generated by tasks `koverXmlReport`, `koverHtmlReport` etc
        mergeWith("release")
    }
}


How to install

Sorry if this seems like a silly question, but how do I actually install this application?
It looks amazing and exactly what I have been looking for.

@elevin72 It is not so difficult to install.

Download app data from Releases.
Unzip it, then place the unzipped folder anywhere you want.
Launch SylphyHorn.exe, then open a settings window from the system tray.


[Hypersonic] Menubar icon is too big

Extension
https://www.raycast.com/reboot/hypersonic
Description
The menubar icon is too big, it should be slightly smaller.
Also, when there are no active tasks, there is no need to show a 0 count. Ideally, it can have a different icon for when there is a task and when there is none.

Steps To Reproduce
Install the extension and enable the menubar icon
Current Behaviour
No response
Expected Behaviour
No response

Hey @el, thanks for the feedback. Added to our backlog ;)


LoadModelAnimationsIQM: fix corrupted animation names

Correctly copies animation names from IQM animation to raylib animation.

@JettMonstersGoBoom Thanks for the review!


controller methods with different parameters

I have a controller with methods that do various types of filtering on my entities.  However, when using swagger, the UI only shows one (seemingly at random) of those methods.  I'm using the latest version of swagger (2.4.0), and have created a sample repo here:
https://github.com/rsparkyc/spring-boot-swagger/
After running gradle bootRun, you can make http calls to the following endpoints:
http://localhost:8080/?name=something
http://localhost:8080/?other=somethingElse
You'll notice each controller method is hit, but swagger UI only picks one of them to display.

See #21 in the documentation & if you want a compatible swagger-ui -> :secret:


Not able to customize the typing animation

Is it an issue related to Adaptive Cards?
No
Is this an accessibility issue?
No
What version of Web Chat are you using?
Latest production
Which distribution are you using Web Chat from?
Bundle (webchat.js)
Which hosting environment does this issue primarily affect?
Web apps
Which browsers and platforms do the issue happened?
Browser: Chrome (latest)
Which area does this issue affect?
Customization: Branding
What is the public URL for the website?
No response
Please describe the bug
In issue #2213 it is mentioned that we can customize the typing animation using the typingAnimationBackgroundImage attribute in StyleOptions, but when I try to give the image path as value to this attribute, the typing animation disappears completely.
Do you see any errors in console log?
No response
How to reproduce the issue?

Navigate to ...
Click on ...
Type "..." in the send box

What do you expect?
I expect our gif to be the typing indicator of the bot.
What actually happened?
The native typing indicator disappears completely when we try to customize it.
Do you have any screenshots or recordings to repro the issue?
No response
Adaptive Card JSON
No response
Additional context
No response

Hi @SanKumar0632, I'm looking into this.

Thank you for your response, I was able to customize the typing gif using this. Still, there should be a simpler way of doing this as follows:
typingAnimationBackgroundImage : 'GifOrImagePath'

Thanks @SanKumar0632,
Indeed the typing indicator can be customized using the styleOptions property.
Example in a react component:
import React, { useEffect, useState } from 'react';
import ReactWebChat, { createDirectLine } from 'botframework-webchat';
import axios from 'axios';

const WebChat = () => {
  const [token, setToken] = useState(null);

  useEffect(() => {
    axios.post('http://localhost:3001/directline/conversations')
      .then(response => {
        setToken(response.data.data.token);
      })
      .catch(err => console.error(err));
  }, []);

  const styleOptions = {
    typingAnimationDuration: 5000,
    typingAnimationHeight: 200,
    typingAnimationWidth: 200,
    typingAnimationBackgroundImage: `url('https://media.tenor.com/hlKEXPvlX48AAAAC/loading-loader.gif')`
  };

  const directLine = token ? createDirectLine({ token }) : null;

  return directLine ? <ReactWebChat directLine={directLine} styleOptions={styleOptions} /> :
Loading...
;
}

export default WebChat;