Retinanet anchor box implementation - question

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?
rx = tf.range(feature_width, dtype=tf.float32) + 0.5
ry = tf.range(feature_height, dtype=tf.float32) + 0.5

Source:
https://github.com/keras-team/keras-io/blob/6d08fdc9ad469adb4c147c62b61b8e4af98bc9f7/examples/vision/retinanet.py#L257

I'd recommend changing the title to something like "Retinanet anchor box implementation - question".
Maybe the following will also help to get a quicker answer.

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

Context (spelling it out should help):
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5

Source: https://github.com/keras-team/keras-io/blob/6d08fdc9ad469adb4c147c62b61b8e4af98bc9f7/examples/vision/retinanet.py#L257
More context:
...
class AnchorBox:
    """Generates anchor boxes.
    This class has operations to generate anchor boxes for feature maps at
    strides `[8, 16, 32, 64, 128]`. Where each anchor each box is of the
    format `[x, y, width, height]`.
...
```py
    def _get_anchors(self, feature_height, feature_width, level):
        """Generates anchor boxes for a given feature map size and level
        Arguments:
          feature_height: An integer representing the height of the feature map.
          feature_width: An integer representing the width of the feature map.
          level: An integer representing the level of the feature map in the
            feature pyramid.
        Returns:
          anchor boxes with the shape
          `(feature_height * feature_width * num_anchors, 4)`
        """
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5
        centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]
        centers = tf.expand_dims(centers, axis=-2)
        centers = tf.tile(centers, [1, 1, self._num_anchors, 1])
        dims = tf.tile(
            self._anchor_dims[level - 3], [feature_height, feature_width, 1, 1]
        )
        anchors = tf.concat([centers, dims], axis=-1)
        return tf.reshape(
            anchors, [feature_height * feature_width * self._num_anchors, 4]
        )

I'd recommend changing the title to something like "Retinanet anchor box implementation - question".
Maybe the following will also help to get a quicker answer.

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

Context (spelling it out should help):
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5

Source: https://github.com/keras-team/keras-io/blob/6d08fdc9ad469adb4c147c62b61b8e4af98bc9f7/examples/vision/retinanet.py#L257
More context:
...
class AnchorBox:
    """Generates anchor boxes.
    This class has operations to generate anchor boxes for feature maps at
    strides `[8, 16, 32, 64, 128]`. Where each anchor each box is of the
    format `[x, y, width, height]`.
...
```py
    def _get_anchors(self, feature_height, feature_width, level):
        """Generates anchor boxes for a given feature map size and level
        Arguments:
          feature_height: An integer representing the height of the feature map.
          feature_width: An integer representing the width of the feature map.
          level: An integer representing the level of the feature map in the
            feature pyramid.
        Returns:
          anchor boxes with the shape
          `(feature_height * feature_width * num_anchors, 4)`
        """
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5
        centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]
        centers = tf.expand_dims(centers, axis=-2)
        centers = tf.tile(centers, [1, 1, self._num_anchors, 1])
        dims = tf.tile(
            self._anchor_dims[level - 3], [feature_height, feature_width, 1, 1]
        )
        anchors = tf.concat([centers, dims], axis=-1)
        return tf.reshape(
            anchors, [feature_height * feature_width * self._num_anchors, 4]
        )

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

My best "weak" guess is that "0.5" is the extra threshold that increases the bounding boxes around objects to make sure some things don't get missed by the detection algorithm. (Source: https://debuggercafe.com/object-detection-using-retinanet-with-pytorch-and-deep-learning/)
/assign @srihari-humbarwadi
(cc @fchollet I noticed there are a few questions in Issuers about the RetinaNet example already)

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

My best "weak" guess is that "0.5" is the extra threshold that increases the bounding boxes around objects to make sure some things don't get missed by the detection algorithm. (Source: https://debuggercafe.com/object-detection-using-retinanet-with-pytorch-and-deep-learning/)
/assign @srihari-humbarwadi
(cc @fchollet I noticed there are a few questions in Issuers about the RetinaNet example already)

We place the anchor boxes at the centre of each of the cells of the grid, more about this here.  For a feature map of height and width hxw, the centres will be located at [(0.5, 0.5), (1.5, 1.5) ...((h1-1)+0.5, (w-1)+0.5)]. We then proceed to scale this by the stride of the feature map to get the absolute coordinates on the image, this is done by
rx = tf.range(feature_width, dtype=tf.float32) + 0.5
ry = tf.range(feature_height, dtype=tf.float32) + 0.5
centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]

We place the anchor boxes at the centre of each of the cells of the grid, more about this here.  For a feature map of height and width hxw, the centres will be located at [(0.5, 0.5), (1.5, 1.5) ...((h1-1)+0.5, (w-1)+0.5)]. We then proceed to scale this by the stride of the feature map to get the absolute coordinates on the image, this is done by
rx = tf.range(feature_width, dtype=tf.float32) + 0.5
ry = tf.range(feature_height, dtype=tf.float32) + 0.5
centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]

We place the anchor boxes at the centre of each of the cells of the grid, more about this here. For a feature map of height and width hxw, the centres will be located at [(0.5, 0.5), (1.5, 1.5) ...((h1-1)+0.5, (w-1)+0.5)]. We then proceed to scale this by the stride of the feature map to get the absolute coordinates on the image, this is done by
rx = tf.range(feature_width, dtype=tf.float32) + 0.5
ry = tf.range(feature_height, dtype=tf.float32) + 0.5
centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]

You speak there about the feature height and width. Are you dealing with a feature map there or a grid cell ?
Or do you mean that the image is split into a grid, each grid is fed independently to the neural net and transformed to a set of feature maps? What do you mean exactly ?

We place the anchor boxes at the centre of each of the cells of the grid, more about this here. For a feature map of height and width hxw, the centres will be located at [(0.5, 0.5), (1.5, 1.5) ...((h1-1)+0.5, (w-1)+0.5)]. We then proceed to scale this by the stride of the feature map to get the absolute coordinates on the image, this is done by
rx = tf.range(feature_width, dtype=tf.float32) + 0.5
ry = tf.range(feature_height, dtype=tf.float32) + 0.5
centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]

You speak there about the feature height and width. Are you dealing with a feature map there or a grid cell ?
Or do you mean that the image is split into a grid, each grid is fed independently to the neural net and transformed to a set of feature maps? What do you mean exactly ?

I'd recommend changing the title to something like "Retinanet anchor box implementation - question".
Maybe the following will also help to get a quicker answer.

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

Context (spelling it out should help):
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5

Source:
https://github.com/keras-team/keras-io/blob/6d08fdc9ad469adb4c147c62b61b8e4af98bc9f7/examples/vision/retinanet.py#L257
More context:
...
class AnchorBox:
    """Generates anchor boxes.
    This class has operations to generate anchor boxes for feature maps at
    strides `[8, 16, 32, 64, 128]`. Where each anchor each box is of the
    format `[x, y, width, height]`.
...
```py
    def _get_anchors(self, feature_height, feature_width, level):
        """Generates anchor boxes for a given feature map size and level
        Arguments:
          feature_height: An integer representing the height of the feature map.
          feature_width: An integer representing the width of the feature map.
          level: An integer representing the level of the feature map in the
            feature pyramid.
        Returns:
          anchor boxes with the shape
          `(feature_height * feature_width * num_anchors, 4)`
        """
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5
        centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]
        centers = tf.expand_dims(centers, axis=-2)
        centers = tf.tile(centers, [1, 1, self._num_anchors, 1])
        dims = tf.tile(
            self._anchor_dims[level - 3], [feature_height, feature_width, 1, 1]
        )
        anchors = tf.concat([centers, dims], axis=-1)
        return tf.reshape(
            anchors, [feature_height * feature_width * self._num_anchors, 4]
        )

which tensorflow version was used in implementing this code ?

I'd recommend changing the title to something like "Retinanet anchor box implementation - question".
Maybe the following will also help to get a quicker answer.

In examples/vision/retinanet.py lines 257 and 258 why +0.5 was added ?

Context (spelling it out should help):
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5

Source:
https://github.com/keras-team/keras-io/blob/6d08fdc9ad469adb4c147c62b61b8e4af98bc9f7/examples/vision/retinanet.py#L257
More context:
...
class AnchorBox:
    """Generates anchor boxes.
    This class has operations to generate anchor boxes for feature maps at
    strides `[8, 16, 32, 64, 128]`. Where each anchor each box is of the
    format `[x, y, width, height]`.
...
```py
    def _get_anchors(self, feature_height, feature_width, level):
        """Generates anchor boxes for a given feature map size and level
        Arguments:
          feature_height: An integer representing the height of the feature map.
          feature_width: An integer representing the width of the feature map.
          level: An integer representing the level of the feature map in the
            feature pyramid.
        Returns:
          anchor boxes with the shape
          `(feature_height * feature_width * num_anchors, 4)`
        """
        rx = tf.range(feature_width, dtype=tf.float32) + 0.5
        ry = tf.range(feature_height, dtype=tf.float32) + 0.5
        centers = tf.stack(tf.meshgrid(rx, ry), axis=-1) * self._strides[level - 3]
        centers = tf.expand_dims(centers, axis=-2)
        centers = tf.tile(centers, [1, 1, self._num_anchors, 1])
        dims = tf.tile(
            self._anchor_dims[level - 3], [feature_height, feature_width, 1, 1]
        )
        anchors = tf.concat([centers, dims], axis=-1)
        return tf.reshape(
            anchors, [feature_height * feature_width * self._num_anchors, 4]
        )

which tensorflow version was used in implementing this code ?

Hi,
It is always suggested to use latest Tensorflow/Keras for improved performances and bug fixes.
If your issue is resolved, could you please spare some time to close the issue.
For the latest update on the tutorial Retinanet, please follow the link here https://keras.io/examples/vision/retinanet/


[BugFix ] Resolve button hover animation displacement issue (#1433)

Description:
This PR fixes issue #1433, where the buttons on the second page below the heading "Raise your hands to save world animals life" were causing adjacent components to shift when hovered due to a size change.
Changes made:
Provided a height of '8rem' to the '.tab-nav' div, ensuring the scaling does not affect the other elements position.
Screen Shot:

Fixed Issue #1433
Testing:
Browsers Tested: Chrome, Firefox, Safari ,Edge
Checklist
[ x ] Code readability and structure improved.
[ x ] Grid styling applied to ensure symmetry and alignment.
[ x ] The issue #1433 has been fully addressed.
[ x ] Changes have been tested on various screen sizes.
Additional Notes:
This change follows the design pattern used across the website, ensuring component reusability and consistency.

@TejasMore477
Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. You can also contribute in my another Repository BuddyTrail which is also under Hacktoberfest
Great contribution to HACKTOBERFEST'24! 🎉


Make this guide platform agnostic.

While this is a great guide for a lot of people interested in deploying k8s, I think it's misleading by the fact that it is heavily geared towards configuring it on Google Cloud Platform. It makes an honorable mention of this guide being applicable for "other platforms", but making it GCP-specific adds unnecessary noise in what is otherwise an attempt at allowing people to learn the internals of the deployment. Perhaps renaming it to "Kubernetes The Hard Way on Google Cloud Platform"  would be more apt.
The solution should be the other way around. Instead of example snippets like these:
EXTERNAL_IP=$(gcloud compute instances describe ${instance} \
  --format 'value(networkInterfaces[0].accessConfigs[0].natIP)')

Users should be able to run native, agnostic Linux commands to fetch this kind of data and then, if they so choose, retroactively rework the command into the platform of their choice (AWS, Azure, GCP, etc.)

There are several editions for other platforms. As he currently belongs to GCP, I don't think he'd make this type of change.

There are several editions for other platforms. As he currently belongs to GCP, I don't think he'd make this type of change.

At the very least, this being made for Google Cloud should be part of the title of the course then if the intent is to upsell the product. A lot of people search and hit this tutorial and turn away when they realize they have to sign up for GCP, get free tier access, set up the gcp CLI tools as prerequisite to running the embedded commands.

I mean this is open source so you can create one by yourself and that is why other edition was made by others.

As @inductor has mentioned, other providers are available. For example,

https://github.com/prabhatsharma/kubernetes-the-hard-way-aws
https://github.com/ivanfioravanti/kubernetes-the-hard-way-on-azure

I don't think a generic guide would be too helpful - the whole point is that this is mega detailed. Furthermore, K8s is originally a Google product so makes sense that a Googler is sharing how to use it on Google infra.

There are several editions for other platforms. As he currently belongs to GCP, I don't think he'd make this type of change.

At the very least, this being made for Google Cloud should be part of the title of the course then if the intent is to upsell the product. A lot of people search and hit this tutorial and turn away when they realize they have to sign up for GCP, get free tier access, set up the gcp CLI tools as prerequisite to running the embedded commands.

These type of comments make me sad. Read this article which explains the difference between a gift and a product. This guide is a gift from the author to the community. The number of forks and stars indicate how the community has benefitted from this gift. For most folks starting in their K8s journey, a cloud-specific detailed set of instructions help in a better way rather than another abstraction (non-cloud generic version).
When we speak and demo at conferences, we talk about open-source technologies but our demo shows the product. This is a healthy and perfectly acceptable balance of project (i.e. open-source project) and product (i.e. paid product). Treat this guide that way. Accept that it's a gift and please appreciate the gift. Kindness works everywhere; even on GitHub issues.

@dewan-ahmed I categorically reject your premise here. First, part of participating in an open source community is also having open discourse. I created this issue as an open-ended constructive feedback, with suggestions on how to better constrain the scope of this article. I did so with an expectation and understanding that such feedback could/would be criticized or rejected outright. It was feedback. Not a demand.
Second, if the point you're making here is that open source projects are charity, therefore immune to feedback or discussions, then by all means, the maintainers can disable the issue tracker or auto-close all issues. But I don't think that's in the spirit of open source.
I've published my own share of open source projects and sometimes receive criticisms or requests to change the software. What I never do is question the motives of the
contributors.  If it can be implemented, I'll implement it. If I can't or don't feel like it, I'll inform them of this fact and mark the issue closed.
Now before we slide further into off topic discussions, I'll mark this issue resolved per comment https://github.com/kelseyhightower/kubernetes-the-hard-way/issues/706#issuecomment-1151310342 as it looks like this is unlikely to be changed, thus this discussion has already been put to rest.


Collatz Tree contribution: branch with based on usage

I'm not completely sure about "The code in the repository should match the code written in the YouTube tutorials". There are only a few lines left of the original.
Community Contribution
Link to live project, video, or image:
https://editor.p5js.org/SuperRembo/present/FlVS_V65b
Sharing

[ x] I would be happy to have my project shared on The Coding Train's social media!

Twitter:
@SuperRembo

I'm not completely sure about "The code in the repository should match the code written in the YouTube tutorials". There are only a few lines left of the original.

This just refers to my code example not the community contributions, they should of course be different! @violetcraze we can consider revising the language if it's unclear!


[Feature Request]  getMBeanInfo(beanName)

The counterpart for MBeanServerConnection.getMBeanInfo(name) doesn't seem to be currently available. Could you provide the method as it is useful in getting the attributes, operations etc of a bean?

This will require to convert he MBeanInfo java class to a some kind of JavaScript object. I tried in the past but did not finish.
At first glance, it seems that it will not be easy to implement. I'm not planning to implement this in the short term, but I would be happy to review a Pull Request about this.


Introduce file extension .acds

Documents the file extension .acds for ABAP CDS source code files.
Closes #161.

Should we write it in title case? Seams to be a product name for SAP - not like Abap file formats ;)


Changing default input set

I've upgraded KeyboardKit to the LayoutService implementation and I couldn't figure out how to change the default input set to my custom one. Previously I would have done:
class CustomKeyboardLayoutProvider: KeyboardLayout.StandardProvider {
    init() {
        super.init(
            baseProvider: KeyboardLayout.DeviceBasedProvider(
                alphabeticInputSet: .customArabic))
        }
}

Hi @bensapirstein
It just renames "provider" to "service" without any functional changes, so it should still work.
The change should also have deprecations to guide you, which means that the code above should give you warnings with auto-fixes, to help you replace the deprecated parts.
This code should work without warnings:
class CustomKeyboardLayoutService: KeyboardLayout.StandardService {
    init() {
        super.init(
            baseProvider: KeyboardLayout.DeviceBasedService(
                alphabeticInputSet: .customArabic
            )
        )
    }
}

How does it behave for you?

Thank you Daniel!

Happy that it worked 🙌


allow using pk as real_field_name

also improve error message when no real_field found.
fixes #31

Codecov Report
Base: 100.00% // Head: 97.93% // Decreases project coverage by -2.06% :warning:

Coverage data is based on head (966abd7) compared to base (fd9788a).
Patch coverage: 75.00% of modified lines in pull request are covered.

:exclamation: Current head 966abd7 differs from pull request most recent head f3cbf4f. Consider uploading reports for the commit f3cbf4f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #32      +/-   ##
===========================================
- Coverage   100.00%   97.93%   -2.07%
===========================================
  Files            3        3
  Lines           90       97       +7
===========================================
+ Hits            90       95       +5
- Misses           0        2       +2

Impacted Files
Coverage Δ

django_hashids/field.py
97.84% <75.00%> (-2.16%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Export and import coursier caches

To export cache items that are required on per-project basis in scala-cli users should run following commands:
export COURSIER_CACHE="$(pwd)/cache/coursier"
export COURSIER_ARCHIVE_CACHE="$(pwd)/cache/arch"
export XDG_CACHE_HOME="$(pwd)/cache/bloop"

scala-cli cache export -o cache.tar.gz ${options which will be used in scala-cli after importing cache, for example `-S 3 Hello.scala`}

and then, users have to run:
scala-cli cache import --cache-path cache.tar.gz

to import coursier and bloop caches
Cache export and import commands requires installed tar application.

Some docs for both commands would be useful, IMO


Retry registering a volume driver

Hi,
While fixes have been put in to deal with docker restart, and the docker daemon will wait until a plugin is responding to requests (by retrying) to send the /Plugin.Activate call, there still exists a race if the plugin has never started since boot. In this case, the plugin UNIX socket will not yet exist -- the plugin has not yet created its socket endpoint, docker does not retry and will fail immediately attempting to register the plugin. This failure causes containers that rely on that plugin to also fail and not start.
The 'socket doesn't exist yet' and the 'plugin not yet responding to requests' should be the same case, it is essentially the same race. docker needs to retry in both cases.
This PR fixes the reboot scenario, where a host is rebooted and docker is just booting. If the plugin has not yet come online after reboot, docker will retry.
Example output is shown here.
WITHOUT the fix, containers fail to start after a reboot:
DEBU[0000] Failed to register container 51abb7d35d1601440b3c92bb620c1810a7e3c80478f36865c08f22907eb0535a: Error looking up volume plugin blockbridge: Plugin not found
DEBU[0000] Failed to register container ad56a0c61caeb912a95431a19d5d1b11f830b8726cfe74055b37c51bb1ffbf30: Error looking up volume plugin blockbridge: Plugin not found
WARN[0000] signal: killed

And then WITH the fix, plugin register retries and containers are able to start normally:
WARN[0000] Unable to locate plugin: blockbridge, retrying in 1s
WARN[0000] Unable to locate plugin: blockbridge, retrying in 1s
DEBU[0001] blockbridge's manifest: &{[VolumeDriver]}
DEBU[0001] blockbridge implements: VolumeDriver
DEBU[0001] blockbridge's manifest: &{[VolumeDriver]}
DEBU[0001] blockbridge implements: VolumeDriver
INFO[0008] Daemon has completed initialization
INFO[0008] Docker daemon                                 commit=5d93c5a-dirty execdriver=native-0.2 graphdriver=devicemapper version=1.9.0-dev

Thanks!
Signed-off-by: Stephen Rust<EMAIL_ADDRESS>

cc @cpuguy83

LGTM

A unit test for the load behavior would be awesome. Let me know if you need any help.

Okay sure. I'll let you know.

Hi @cpuguy83,
I'd appreciate some feedback on my test case. :-)  I pushed a test. It fails on master as expected. And passes with this PR. I'm not super excited about the use of timeouts and sleeps to wait for the retry condition to occur. If you have some suggestions on how to improve, that would be awesome. Otherwise, it does appear to test what we want!
Thanks.

@srust tests are broken in CI, I suspect there is some kind of side effect cleaning up after this test.

@calavera Yep see it. Fixing..

Okay, pushed a fix and tests are passing again for janky.  Let me know what else you need, or if you're happy with this test.
Thanks guys.

LGTM
Experimental seems to be failing but is unrelated.

experimental no longer failing! (altho yes was unrelated. :)

LGTM


[ci skip] adding user @username

Hi! This is the friendly automated conda-forge-webservice.
I've added user @username as instructed in #8.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #8

I am sorry I opened this accidentally. I have made a proper request in #11


ImportError: cannot import name MarkdownLangMap

I am unable to get this working in sublime-text-3. After install LSP and LSP-pyright, I get the following in console:
reloading plugin LSP-pyright.commands
reloading plugin LSP-pyright.plugin
Traceback (most recent call last):
  File "/opt/sublime_text/sublime_plugin.py", line 125, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "/opt/sublime_text/sublime_plugin.py", line 1199, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "/home/pkkid/.config/sublime-text-3/Installed Packages/LSP-pyright.sublime-package/plugin.py", line 1, in <module>
ImportError: cannot import name MarkdownLangMap
reloading plugin LSP.boot

I have the following:

sublime-text-3 v3.2.2, Build 3211
ubuntu 22.04
python 3.10.3

I can confirm this.

Fixed in 1.1.154.

Well that was super fast. Thanks so much!


Source code for BFS in java

Related Issue
Solved issue number: #364
Describe the changes you've made
Adding source code for BFS in java
Describe if there is any unusual behavior of your code(Write NA if there isn't)
NA
Language used for coding
Java
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Please review the code.


Modern setup: doctests, mypy, cached poetry

Codecov Report

Merging #359 (96682d5) into master (aa7d387) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #359   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         4
  Lines           26        26
=========================================
  Hits            26        26

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Test migration from 2.1.0 to 2.2.0

Description:
We have a slight modification in schema when moving to 2.2.0. We need to test whether the migration is working fine or whether we need to provide db migrtion scripts.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Tested and woks fine. Hence closing


Xiaomi Aqara Smart Wireless Switch only single press?

Hi Erik,
short question to you .-)
The Xiaomi Aqara Smart Wireless Switch how many functions should it currently have?
(Https://www.gearbest.com/access-control/pp_626695.html?)
I have one to test here, but with this I can only prove with single press.
I was already happy where I saw the update but unfortunately not for this switch.
Greeting Nastra

hey im a newbie with homebridge and all this stuff. With lots of help from everyone who develops, i managed to have a homebridge with xiaomi window sensor and temperature humidity sensor added to home app but for some reason my mi wireless switch (button) https://xiaomi-mi.com/mi-smart-home/xiaomi-mi-wireless-switch/
is not showing in home app, although its in mi home app. I'd like to control my hue bulbs with this mi switch. Any help would be appreciated. I'm using homebridge-aqara plugin now. i tried the others homebridge-mi-aqara and homebridge-mi-aqara-2 and so on. None of them see the switch and only homebridge-aqara works properly with my other mi sensors.


Style/EmptyLiteral is suggesting inequivalent replacements!

The cop Style/EmptyLiteral is telling to replace String.new with a string literal ''. However we figured out, that this is not equivalent! The difference:

Creating a string as a literal '' sets the encoding to UTF-8.
Using String.new sets the encoding to ASCII-8BIT.

irb(main):001:0> ''.encoding
=> #<Encoding:UTF-8>
irb(main):002:0> String.new.encoding
=> #<Encoding:ASCII-8BIT>

Expected behavior
Use string literal ''.force_encoding(Encoding::ASCII_8BIT) instead of String.new.
Actual behavior
Use string literal '' instead of String.new.
Steps to reproduce the problem
$ echo "str = String.new; puts str.encoding" > file.rb
$ ruby file.rb
ASCII-8BIT
$ rubocop --only EmptyLiteral --auto-correct file.rb
Inspecting 1 file
C

Offenses:

file.rb:1:7: C: [Corrected] Style/EmptyLiteral: Use string literal '' instead of String.new.
str = String.new; puts str.encoding
      ^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected
$ ruby file.rb
UTF-8

rubocop version
$ rubocop --version
0.57.2

I remembered that I investigated this problem before.
https://github.com/rails/rails/pull/29506#issuecomment-309685349
What problem use case do you have by this auto-correct?
OTOH, the auto-correct for Array.new and Hash.new are fine.
It would be better to provide an option that strictly warning only argumentless String.new over SafeAutoCorrect: false if this issue is addressed. And I'm concerned that String.new has a potential problem. I think it's usually auto-corrected by "" literal, so I think this option can enable warning by default.

Another idea.
''.force_encoding(Encoding::ASCII_8BIT) is strictly correct. However, I'm worried about being redundant if ASCII_8BIT encoding is not expected.
It may be better to provide an encoding compatible option.

Hey kioc! Thank you for your fast reply!

I remembered that I investigated this problem before.
rails/rails#29506 (comment)
What problem use case do you have by this auto-correct?
OTOH, the auto-correct for Array.new and Hash.new are fine.
It would be better to provide an option that strictly warning only argumentless String.new over SafeAutoCorrect: false if this issue is addressed. And I'm concerned that String.new has a potential problem. I think it's usually auto-corrected by "" literal, so I think this option can enable warning by default.

I work with different external processes. They do use different encodings for stdin and stdout. That led to displaying issues within the gui. So i do use ASCII_8BIT in my application core, as convention. The buffer was initialized with String.new, for parsing a process' stdout.

Another idea.
''.force_encoding(Encoding::ASCII_8BIT) is strictly correct.

So your two suggestions are:

Change behavior for String.new, but not String.new('i already have an encoding'). Empty strings only.
Disable SafeAutoCorrect

Both suggestions seem good to me.

However, I'm worried about being redundant if ASCII_8BIT encoding is not expected.
It may be better to provide an encoding compatible option.

I see your point. People might have the wrong assumption. And yes, it is rubocops job to show that. For me it is more important that i receive message that there might be encoding issues, when using the cop.
But when suggesting a replacement, it should be 100% equivalent. No matter what the programmer wrote.


Fixed the broken link of Next Step - Conditions and Interactivity

Before
https://github.com/user-attachments/assets/6724e241-21b7-4eee-8f7e-2c21891983b0
After
https://github.com/user-attachments/assets/88dcfd75-0ddd-40ab-92b9-6f908ee0c0bf

Thanks @shourysingh07! You are now added in p5.js contributor list 🎉.


Record Type doesn't work

An object called 'myObj' with properties 'a' (a number), 'b' (a string) and 'c' (any type).
@param {{a: number, b: string, c}} myObj

output only as:
myObj   Object

Is it expected?

just spotted this too.. it's the same for @type..
this doclet
/**
 * @type {{ a: number, b: string, c}}
 */
var recordType = {}

produces this explain output
"type": {
      "names": [
        "Object"
      ]
    },

As a workaround you can describe the object using @typedef, e.g.:
/**
  * @typedef {Object} method~myObj
  * @property {number} a - A number.
  * @property {string} b - A string.
  * @property {*} c - An "any-type" member.
  */

... and then:
@param {method~myObj} myObj - The record typed parameter.

@agauthiez Yes, but typedef is tedious, and the type doc will be placed  in another page by jsdoc, I was hoping Record Type will place doc inline.

Duplicate of #636.


Prevent wrongly cased file paths to enter the workbench

Follow up from https://github.com/Microsoft/vscode/issues/12448. We now no longer open 2 different files when using different casing for a file path (macOS, Windows) but we can do better and prevent wrongly-cased paths altogether.
We should identify the places where paths are coming in that we cannot trust in terms of casing (e.g. output from the terminal) and then convert this path to the real path when opening in the editor.
Finding out the real path as it is on disk is unfortunately not possible with node.js APIs. We have a helper method (here) that walks each parent folder until the file is reached to find out the actual casing.
A better approach would be to write a native module that does this in one call ideally. We could try to use uv_fs_realpath, keeping in mind the caveats though.
node.js once used uv_fs_realpath inside fs.realpath but took it out again due to the issues documented.
A wrapper exists to deal with the error cases.

https://github.com/Microsoft/vscode/issues/12448


feat: inline default install-path

This preps us for a future release where we change the default, making it easier for people using the previous default to keep it.
I considered migrating away from Opt<Vec<_>>, but this made it easier to keep opt_string_or_vec.
Fixes #1194.

Updated to make this an init-time feature.


admission control: Filter implementation with no-op controller

First patch in a series implementing #9658. The basic filter logic, HTTP/gRPC code evaluation, and configuration are implemented. Still requires the actual admission control logic implementation and documentation.
This is a break-up of PR #10985.
Risk Level: Low (new filter)
Testing: Unit test
Docs Changes: Only proto documenation implemented.
Release Notes: n/a
Progress toward: #9658

@mattklein123 @snowp opening a new PR as per Matt's request in #10985.

/lgtm api

@snowp I took care of the coverage issue. It's caused by the breakup of the original PR. For instance, we never attempt to get the threadlocal controller, since we're not really using it for anything. Should be fixed now, but it'll look a lot better in the 2nd patch.
Thanks for all the reviews.


Moved VFX node add popup to same stage as modules

To see the specific tasks where the Asana app for GitHub is being used, see below:

https://app.asana.com/0/0/1203721296564480

OK to merge this if you arent making changes to keep it in same stage @vuvkar


run front50 with S3 backend behind a corporate proxy

To use edit config/spinnaker-local.yml:

storage_bucket: YOUR_S3_BUCKET
bucket_root: front50
region: eu-central-1
proxyHost: webproxy.foo.bar
proxyPort: 8080
proxyProtocol: HTTP

Currently only works with proxies without credentials

Sorry I was OOO for the past week.
This looks good to me, do you mind rebasing and I'll get it merged down.
Thanks!


Perform Xcode 10.2 upgrade check

This PR updates the project settings to those recommended by Xcode 10.2. This addresses the "Upgrade to Recommended Settings" warning that Xcode 10.2 generates when opening the project. Xcode recommended enabling the CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED warning, although doing so has no effect since the app is not localized.
These changes are backwards compatible.

@sbaskaran Thank you!


Add reveal in sidebar button to explorer

Closes https://github.com/Microsoft/vscode/issues/43907

I will have to not accept this due to the reasons specified in https://github.com/Microsoft/vscode/issues/43907


Make adapter ready for Admin v3

For Admin3 some changes are needed: see http://forum.iobroker.net/viewtopic.php?f=24&t=10268

Done!


Add line on hover at footer

Description
Issue NO #507

Successfully addded  the ine on hover, which will enhance the user interaction with website.
Screenshots / videos (if applicable)
Before
https://github.com/user-attachments/assets/171581ea-f8d1-421a-b570-128cf68cbed6
After:
https://github.com/user-attachments/assets/4304d56d-4f10-4711-890b-7f545ece82ce
Checklist

[X] I have gone through the contributing guide
[X] I have updated my branch and synced it with project main branch before making this PR
[X] I have performed a self-review of my code
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

it should be like below.
WhatsApp.Video.2024-10-14.at.21.15.24_8d3cb6a5.mp4

underline color should be same as in video or bkack is okay?

@Shekhar-Raj i will attach label level 3 if u implement these changes to all html files.

@Anjaliavv51  I will do it !

@Shekhar-Raj i will attach label level 3 if u implement these changes to all html files.

@Anjaliavv51  I Have successfully updated all the html files according to you
Demo:
cart.html
https://github.com/user-attachments/assets/762706f5-1d08-44c1-8d1f-5bffaa8db7ed


Rockabox loading item

When data has yet loaded we should show the Rockabox styled loader

Closed by #30


Error in downloading snpEff_v4_3_GRCh38.86.zip file (bcbio_nextgen.py upgrade)

Hi,
The bcbio_nextgen.py upgrade script is unable to wget snpEff_v4_3_GRCh38.86.zip file (although 'wget' link works on the command line but fails in the script).
bin/bcbio_nextgen.py upgrade -u development --tooldir=BCBIO-NEXTGEN --genomes hg38-noalt --genomes hg38

Any pointer would be very helpful.
Thank you!
Best,
Asad
Error log:
Installing snpEff database GRCh38.86 in BCBIO-NEXTGEN/share/genomes/Hsapiens/hg38-noalt/snpeff
--2017-01-10 14:35:50--  http://downloads.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip
Resolving downloads.sourceforge.net (downloads.sourceforge.net)... <IP_ADDRESS>
Connecting to downloads.sourceforge.net (downloads.sourceforge.net)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 302 Found
....
......
20 redirections exceeded.
Traceback (most recent call last):
  File "bin/bcbio_nextgen.py", line 215, in <module>
    install.upgrade_bcbio(kwargs["args"])
  File "BCBIO-NEXTGEN/share/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 94, in upgrade_bcbio
    upgrade_bcbio_data(args, REMOTES)
  File "BCBIO-NEXTGEN/share/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 292, in upgrade_bcbio_data
    _upgrade_snpeff_data(s["fabricrc_overrides"]["galaxy_home"], args, remotes)
  File "BCBIO-NEXTGEN/share/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 357, in _upgrade_snpeff_data
    subprocess.check_call(["wget", "-c", "-O", dl_file, dl_url])
  File "BCBIO-NEXTGEN/share/anaconda/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['wget', '-c', '-O', 'snpEff_v4_3_GRCh38.86.zip', 'http://downloads.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip']' returned non-zero exit status 8

Asad;
Sorry about the issues. I'm not able to reproduce this now and downloads seem to proceed cleanly. It's possible this was a temporary issue with sourceforge downloads. Could you retry the upgrade you're running? It should pick up where it left off and hopefully work this time.

Hi @asad
I am closing this because it seems is not a problem anymore, please feel free to open an issue if you find again the problem.
thanks!

Hi @chapmanb @asad @lpantano,
I'm having the same issue as well.  Any thoughts?
sudo python bcbio_nextgen_install.py /usr/local/share/bcbio --tooldir /usr/local --genomes hg38 --aligners bwa --isolate -u stable

Installing snpEff database GRCh38.86 in /usr/local/share/bcbio/genomes/Hsapiens/hg38/snpeff
--2017-03-16 16:05:26--  http://downloads.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip
Resolving downloads.sourceforge.net (downloads.sourceforge.net)... <IP_ADDRESS>
Connecting to downloads.sourceforge.net (downloads.sourceforge.net)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://cytranet.dl.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip [following]
--2017-03-16 16:05:26--  https://cytranet.dl.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip
Resolving cytranet.dl.sourceforge.net (cytranet.dl.sourceforge.net)... <IP_ADDRESS>
Connecting to cytranet.dl.sourceforge.net (cytranet.dl.sourceforge.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
....
20 redirections exceeded.
Traceback (most recent call last):
  File "/usr/local/share/bcbio/anaconda/bin/bcbio_nextgen.py", line 4, in <module>
    __import__('pkg_resources').run_script('bcbio-nextgen==1.0.2', 'bcbio_nextgen.py')
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/setuptools-27.2.0-py2.7.egg/pkg_resources/__init__.py", line 744, in run_script
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/setuptools-27.2.0-py2.7.egg/pkg_resources/__init__.py", line 1499, in run_script
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio_nextgen-1.0.2-py2.7.egg-info/scripts/bcbio_nextgen.py", line 215, in <module>
    install.upgrade_bcbio(kwargs["args"])
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 95, in upgrade_bcbio
    upgrade_bcbio_data(args, REMOTES)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 293, in upgrade_bcbio_data
    _upgrade_snpeff_data(s["fabricrc_overrides"]["galaxy_home"], args, remotes)
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/site-packages/bcbio/install.py", line 358, in _upgrade_snpeff_data
    subprocess.check_call(["wget", "-c", "-O", dl_file, dl_url])
  File "/usr/local/share/bcbio/anaconda/lib/python2.7/subprocess.py", line 186, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['wget', '-c', '-O', 'snpEff_v4_3_GRCh38.86.zip', 'http://downloads.sourceforge.net/project/snpeff/databases/v4_3/snpEff_v4_3_GRCh38.86.zip']' returned non-zero exit status 8
Traceback (most recent call last):
  File "bcbio_nextgen_install.py", line 246, in <module>
    main(parser.parse_args(), sys.argv[1:])
  File "bcbio_nextgen_install.py", line 44, in main
    subprocess.check_call([bcbio, "upgrade"] + _clean_args(sys_argv, args))
  File "/usr/lib/python2.7/subprocess.py", line 541, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/local/share/bcbio/anaconda/bin/bcbio_nextgen.py', 'upgrade', '--tooldir', '/usr/local', '--genomes', 'hg38', '--aligners', 'bwa', '--isolate', '-u', 'stable', '--data']' returned non-zero exit status 1

David -- I still haven't been able to reproduce this and think it's due to sourceforge instability. If you re-try the install/upgrade command, does it fail consistently? Hopefully re-starting it will work for you.

I have the same problem intermittently. It looks like Sourceforge is sending 302s and then it exceeds the 20 redirects limit.

Dennis -- thanks for the report. Unfortunately this is due to Sourceforge instability so we don't have a good way to work around it. I wish I had better option than waiting and trying a restart, but hope that hacky solution will work for you.


[WIP] FastAdapter V3

Roadmap:

reduce method count
cleanup code
filter with http://reactivex.io/documentation/operators/filter.html behavior
benchmark tests
generated item id´s are now negative
isUseIdDistributor is now false by default
remove deprecated setModel in GenericAbstractItem
only allocate ClickListenerHelper if needed
add possibility to set an own ClickListenerHelper
update realm to 3.0.0
improve realm sample
add IHookable interface
update realm module
remove viewholder factory

Current method count (run ./gradlew assembleDebug)

methods
fields
package/class name

1322
9345
com.mikepenz.fastadapter

100
12
com.mikepenz.fastadapter.adapters

776
6379
com.mikepenz.fastadapter.app

40
2
com.mikepenz.fastadapter.app.adapters

6
0
com.mikepenz.fastadapter.app.dummy

24
5
com.mikepenz.fastadapter.app.generic

308
105
com.mikepenz.fastadapter.app.items

63
21
com.mikepenz.fastadapter.app.items.expandable

127
1455
com.mikepenz.fastadapter.commons

51
4
com.mikepenz.fastadapter.commons.adapters

27
6
com.mikepenz.fastadapter.commons.items

34
5
com.mikepenz.fastadapter.commons.utils

15
11
com.mikepenz.fastadapter.helpers

42
10
com.mikepenz.fastadapter.items

18
0
com.mikepenz.fastadapter.listeners

15
1
com.mikepenz.fastadapter.utils

356
110
com.mikepenz.fastadapter_extensions

7
0
com.mikepenz.fastadapter_extensions.adapters

49
4
com.mikepenz.fastadapter_extensions.dialog

10
6
com.mikepenz.fastadapter_extensions.drag

98
27
com.mikepenz.fastadapter_extensions.items

68
34
com.mikepenz.fastadapter_extensions.scroll

28
8
com.mikepenz.fastadapter_extensions.swipe

20
2
com.mikepenz.fastadapter_extensions.utilities

allprojects {
	repositories {
	     ...
	     maven { url 'https://jitpack.io' }
        }
}

dependencies {
        compile 'com.github.mikepenz:fastadapter:v3-SNAPSHOT'
}

How about to add this issue to roadmap? #285

@mikepenz @FabianTerhorst Suggestion: Make more screenshots of the examples. Devs LOVE images ;)

@Rainer-Lang facebook has a testing library that is generating screenshots. http://facebook.github.io/screenshot-tests-for-android/

https://github.com/mikepenz/FastAdapter/issues/344

Should a new project using FastAdapter use the snapshots from v3, or is it unstable?

@eygraber I suggest of using v2.5.x right now. A few cleanup and bigger API changes were already done. So It's better to keep with the 2.x branch until we get to a more feature rich state of v3

Checkout #443 to see the new changes. The benchmarks will be migrated to the new version after release.


Windows: add runtime packaging scripts

This adds the packaging for the Windows runtime (the redistributable
part of the SDK).

CC: @shahmishal

@compnerd these are in the wrong path.

@shahmishal so I realized when I tried to use this.  #20 moved it to the right location.


I would like to be able to create a new zk app in my current directory

Describe the problem
The zk project command always creates a sub-directory, which is annoying if you are already in the directory you want all of the files to be in.
Describe the proposed solution
It would be convenient to be able to clone an empty repository, change into that directory, and execute zk p . to initialize a new zk project.
Alternatives considered
No response
Importance
nice to have
Additional Information
No response

Thanks. I could see the value in it. We currently update the project name in the REAMDE and package.json; I suppose we could read the name of the current working directory and use that.


Add an option (i.e. --noFirefox) to only use Chrome when running tests

/botio unittest

Thank you for doing this! This avoids having to hothack the code for e.g. #17961.


⚠ Jenkins Plugins Artifactory has degraded performance

In 5666dd4, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2445 ms

Resolved: Jenkins Plugins Artifactory performance has improved in e317eb3 after 13 minutes.


How to compile with x86_64-unknown-linux-musl

Here is my Dockerfile:

FROM rust:latest as builder
RUN rustup update
RUN rustup target add x86_64-unknown-linux-musl
RUN apt-get update
RUN apt-get install cmake musl-tools clang libc++-dev build-essential autoconf libtool pkg-config libgflags-dev libgtest-dev -y
WORKDIR /workspace
COPY Cargo.toml .
COPY Cargo.lock .
RUN mkdir src
RUN echo "// placeholder" > src/lib.rs
RUN cargo fetch
RUN CC=clang CXX=clang++ cargo build --release --target=x86_64-unknown-linux-musl
RUN rm src/lib.rs
COPY ./ /workspace/
RUN CC=clang CXX=clang++ cargo test
RUN CC=clang CXX=clang++ cargo build --release --target=x86_64-unknown-linux-musl
FROM alpine
COPY --from=builder /workspace/target/x86_64-unknown-linux-musl/release/app /
ENTRYPOINT ["/app"]
EXPOSE 9090

But compile fail with error:
undefined reference to symbol 'secure_getenv@@GLIBC_2.17'

Reference: https://stackoverflow.com/q/41856536/7083401

I managed to build it on musl at https://github.com/pingcap/grpc-rs/issues/233

I had some issues with my toolchain starting in the upgrade from 0.3.1 -> 0.4.0, and TBH I'm not entirely sure why. I ended up writing two scripts to handle it, build_musl.sh. I was trying to build a static binary with all deps included.
My steps:

build+install the musl toolchain from https://github.com/GregorR/musl-cross
setup the scripts build_musl.sh and custom_link.sh sourced below.
run build_musl.sh

my build.sh
export CMP_ROOT=$PWD
export RUST_BACKTRACE=full
export TOOLCHAIN_ROOT="${TOOLCHAIN_ROOT:-/opt/cross/x86_64-linux-musl}"
echo "TOOLCHAIN_ROOT: $TOOLCHAIN_ROOT"
export CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_LINKER=$CMP_ROOT/custom_link.sh
export TARGET_CC=$TOOLCHAIN_ROOT/bin/musl-gcc
export TARGET_AR=$TOOLCHAIN_ROOT/bin/x86_64-linux-musl-ar
export HOST_CC=cc
export PKG_CONFIG_ALLOW_CROSS=1
export RUSTFLAGS="-C link-arg=-v -C linker=$CARGO_TARGET_X86_64_UNKNOWN_LINUX_MUSL_LINKER -C ar=$TARGET_AR"
export PATH=/opt/cross/x86_64-linux-musl/bin:$PATH
cargo build --release --target=x86_64-unknown-linux-musl

my custom_link.sh
#!/bin/bash

export GCC_ROOT="$TOOLCHAIN_ROOT/lib/gcc/x86_64-linux-musl/5.3.0"

args=()
for arg in "$@"; do
    if [[ $arg = *"Bdynamic"* ]]; then
        args+=() # we do not want this arg
    elif [[ $arg = *"crti.o"* ]]; then
        args+=("$arg" "$GCC_ROOT/crtbeginT.o" "-Bstatic")
    elif [[ $arg = *"crtn.o"* ]]; then
        args+=("-lgcc" "-lgcc_eh" "-lc" "$GCC_ROOT/crtend.o" "$arg")
    else
        args+=("$arg")
    fi
done

echo "RUNNING WITH ARGS: ${args[@]}"
musl-gcc "${args[@]}"

Oh scripts wizard :dizzy_face: Thank you for your information!

Have you been able to build statically some other way?

No, haven't tried to build statically yet. I will give it a try when I have some free time.


Add installation guideline to readme

Hello - perhaps I am being daft (sorry!) but I am struggling to install or use this package.
Would it be possible to add a few lines in the readme on best practices for installing?
I have attempted with pip and with cloning locally but I must be doing something wrong and a few line guide would be of great help to future struggling noobs. :)
Thanks a lot

@bvasiles can you please help?

Hi @sipka,
Would be great to package this so it's available through pip!
Until then, download the code into the same folder as the script you're calling it from.


CentOS7 EOL patches

Needed to fix docker builds issues such as:
[2024-07-06T14:02:28.229Z] Step 7/25 : RUN yum --enablerepo=extras install -y epel-release

[2024-07-06T14:02:28.229Z]  ---> Running in 8fc88675f60c

[2024-07-06T14:02:28.484Z] Loaded plugins: fastestmirror, ovl

[2024-07-06T14:02:28.484Z] Determining fastest mirrors

[2024-07-06T14:02:28.484Z] Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container error was

[2024-07-06T14:02:28.484Z] 14: curl#6 - "Could not resolve host: mirrorlist.centos.org; Unknown error"

[2024-07-06T14:02:28.484Z]

[2024-07-06T14:02:28.484Z]

Tested locally for compute-rocm-rel-6.2-29 (just as an example; changes are not ROCm-specific): https://amdcloud-my.sharepoint.com/:u:/g/personal/jnair_amd_com/Ee9ElpGLkkxEgPTJkCkI-44BxMrf_vPnvZpiXp5r6Sk7JA?e=lFqN0S


Changes by TK

a brief EDA #24 in Jupyter Notebook using Data_Science_Jobs_in_India dataset
Outline--
Conclusion when the experience is 1 or 2 years:
--> there are:

total employees~ 1602

total companies~ 642

Focusing on 1 or 2 years experienced employees as there are more employees in that vertical

there are 35% are Business Analysts, 30% are Data Analysts, 15% are Senior Data Analyst and 10% each Data Engineer and Machine Learning Engineer

from the top 20 values and different job profiles where the employee is having an experience of 1 or 2 years, we can say that, maximum salary is earned by Data Engineer is 9.9L

While speaking about the gap, we can see that it is between 30k to 90k for maximum salary and for minimum salary it is somewhere between 1 to 2 lacs.

Conclusion when the experience is between 5 to 10 years:

Now focusing on 5 to 10 years experienced employees

there are 20% of Senior Data Engineer and 35% each are Senior Data Analyst and Senior Data Scientist. Rest 5% each are Data Architect & Senior Business Analyst

from above for top 20 values and different job profiles where the employee is having an experience of 5 to 10 years, we can say that, maximum salary is earned by Senior Data Engineer which is 94 lacs

While speaking about the gap, we can see that there is a huge gap between the above mentioned job profiles namely a) Senior Business Analyst, b) Senior Data Scientist, c) Senior Data Analyst

Beautifully explained.. Lets connect on LinkedIn soon

thanks man! of course:)


rename medidataRave config variables && remove medidataRave config variables to allow editing by default

Remove MedidataRave configuration variable to allow editing by default.
NOTE: Override can be applied by instance, as we currently do in Production to prevent editing  of MedidataRave fields there.

Hello @achen2401! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/config/config.py:

Line 114:52: E261 at least two spaces before inline comment
Line 114:80: E501 line too long (81 > 79 characters)


[ISSUE #1121]🧪Add test case for AccessChannel

Which Issue(s) This PR Fixes(Closes)

Fixes #1121
Brief Description

How Did You Test This Change?

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥


Update hicexplorer tutorial

I just went 'quickly' through this tutorial on our local instance with what I think are the latest versions of the tools used.
I could not find the bigwig files, but just now realised they are on zenodo as well. Will add that link and the missing workflow inputs later today or tomorrow.
Let me know if this PR is of interest.

@joachimwolff is it ok now?

@scholtalbers don't forget to add yourself to the CONTRIBUTORS.yaml file :)

@shiltemann, ok I will :)   .
In addition, I think the workflow has a bug (sam vs bam) so will try to get it updated this week. Which docker image needs to be used to test this - and is there any doc on this(didn't do a thorough search..)?

@scholtalbers you can find the command to build the docker image locally in the topics/<yourtopic>/docker/Dockerfile
or you can fetch the existing epigenetics docker image using the command given on the topic page

Hey @joachimwolff, I've assigned you since you had interest for updating the HIC tutorial.

It looks like this tutorial has been significantly updated already since this PR was openened ..5+ years ago. I will close this, and if anything is still relevant to be updated, please do so in a new PR (Sorry @scholtalbers, thanks for contributing!)


fix: handle EAGAIN spawning errors

EAGAIN errors come from uv_spawn(), and may happen because of the
following reasons (from the man pages):

The system-imposed limit on the total number of processes under
execution would be exceeded. This limit is configuration-dependent

The system-imposed limit MAXUPRC (<sys/param.h>) on the total number
of processes under execution by a single user would be exceeded

This commit retries the spawning operation various times before giving
up with a human friendly error message.
See: https://github.com/resin-io/etcher/issues/1578
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

I'm merging this so we can release the next Etcher version soon. I'm happy to address any comments later.

Ah, damn, I should have used VersionBots :(


Export all TypeHelper implementations in type_helper.dart

Export all helpers in type_helper.dart so they can be reused in other packages (like dartson).
See https://github.com/eredo/dartson/issues/48#issuecomment-419239742 for original discussion.

@kevmoo done. Wasn't sure regarding the correct version.


Publish full agenda and session information on the website

What
Full agenda to be shared ahead of the event
Why
Promote the event and attendees are aware of the schedule
Who needs to work on this
Imran, Ciandelle, Nora, Kelly, Kam
Who needs to review this
SDM/PM
Done when

[ ] Agreed timings with speaker
[ ] final agenda set
[ ] shared on on website

Draft content for PR https://docs.google.com/document/d/1yOZJSoJYB-IBuBpsHCMsh2cMVvD2_VtQA1XD77_j_2s/edit

It's on the website and looking great. Thanks to @NoraGDS for all her amazing work on the 2i process with this!


AKS Periscope breaking change: Need to supply ContainerName to AKS Periscope from future release v0.5 onwards

Extension name (the extension in question)
AKS Periscope
Description of issue (in as much detail as possible)
AKS Periscope used to read the container name with a hardcoded Kubeconfig. This PR  and this issue  discuss the breaking changes that will occur to each service that has a working contract with AKS Periscope. The removal of the hardcoded code in Periscope will allow for other tools to onboard onto AKS Periscope easily.
Azure-cli-extensions is one service that has a working contract with AKS Periscope. To keep the default behavior as it is pass the API Server Name as the ContainerName.

CC: @Tatsinnit and @sophsoph321

route to service team

☕ please note this work is merged as part of #3971 , please feel free to close this tracking issue or if he ever a newer version gets released. Thanks !


[WIP]: refactor DO NOT MERGE YET

this is a pr for a gradual refactor i am working on
will include custom providers, generic data sources and traits and impls for most files

tests don't pass yet

i decided to use env variables instead of cli, i know there was discussion in 16

i decided to use env variables instead of cli, i know there was discussion in 16

That's fine! If need be we can always change inputs.


Cannot run with vim-dispatch

I read on the docs that you needed vim-dispatch to have output on the editor, I've installed it but now I can't run my games.
When I run :GodotRun, the game doesn't run and the command line displays :!godot 'Splash/Splash.tscn' (x11/?) (Splash/Splash.tscn being my main scene).
If I remove vim-dispatch I can run the game fine, but without the terminal output.
Also, is there a way to run something like floaterm?

Try to run :Spawn godot Splash/Splash.tscn

Yep, sorry. It was a problem with my tmux configuration.


HDDS-2267. Container metadata scanner interval mismatch

What changes were proposed in this pull request?
Fix time unit mismatch in container metadata scanner.  Elapsed time is measured in nanoseconds, needs to be converted to milliseconds.
https://issues.apache.org/jira/browse/HDDS-2267
How was this patch tested?
Tested on ozone docker-compose cluster.
datanode_1  | 2019-10-09 06:18:00 INFO  ContainerMetadataScanner:60 - Background ContainerMetadataScanner starting up
datanode_1  | 2019-10-09 06:18:00 INFO  ContainerMetadataScanner:88 - Completed an iteration of container metadata scrubber in 0 minutes. Number of  iterations (since the data-node restart) : 1, Number of containers scanned in this iteration : 0, Number of unhealthy containers found in this iteration : 0
datanode_1  | 2019-10-09 06:19:00 INFO  ContainerMetadataScanner:88 - Completed an iteration of container metadata scrubber in 0 minutes. Number of  iterations (since the data-node restart) : 2, Number of containers scanned in this iteration : 2, Number of unhealthy containers found in this iteration : 0
...
datanode_1  | STARTUP_MSG: Starting HddsDatanodeService
datanode_1  | 2019-10-09 06:23:52 INFO  ContainerMetadataScanner:60 - Background ContainerMetadataScanner starting up
datanode_1  | 2019-10-09 06:23:52 INFO  ContainerMetadataScanner:88 - Completed an iteration of container metadata scrubber in 0 minutes. Number of  iterations (since the data-node restart) : 1, Number of containers scanned in this iteration : 2, Number of unhealthy containers found in this iteration : 0
datanode_1  | 2019-10-09 06:24:52 INFO  ContainerMetadataScanner:88 - Completed an iteration of container metadata scrubber in 0 minutes. Number of  iterations (since the data-node restart) : 2, Number of containers scanned in this iteration : 2, Number of unhealthy containers found in this iteration : 0

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
85
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
52
hadoop-hdds in trunk failed.

-1
mvninstall
39
hadoop-ozone in trunk failed.

-1
compile
18
hadoop-hdds in trunk failed.

-1
compile
13
hadoop-ozone in trunk failed.

+1
checkstyle
63
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
957
branch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-hdds in trunk failed.

-1
javadoc
16
hadoop-ozone in trunk failed.

0
spotbugs
1044
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
31
hadoop-hdds in trunk failed.

-1
findbugs
16
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

-1
mvninstall
32
hadoop-hdds in the patch failed.

-1
mvninstall
35
hadoop-ozone in the patch failed.

-1
compile
22
hadoop-hdds in the patch failed.

-1
compile
16
hadoop-ozone in the patch failed.

-1
javac
22
hadoop-hdds in the patch failed.

-1
javac
16
hadoop-ozone in the patch failed.

+1
checkstyle
51
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
798
patch has no errors when building and testing our client artifacts.

-1
javadoc
18
hadoop-hdds in the patch failed.

-1
javadoc
16
hadoop-ozone in the patch failed.

-1
findbugs
28
hadoop-hdds in the patch failed.

-1
findbugs
18
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
24
hadoop-hdds in the patch failed.

-1
unit
21
hadoop-ozone in the patch failed.

+1
asflicense
30
The patch does not generate ASF License warnings.

2526

Subsystem
Report/Notes

Docker
Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1624

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3c965ea1d7b1 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1d27930

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-hdds/container-service U: hadoop-hdds/container-service

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1624/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank you very much to open this pull request.
During the weekend the Ozone source code has been moved out from apache/hadoop repository to apache/hadoop-ozone repository.
This git commits are rewritten, but the branch of this pull request is also transformed (state of Saturday morning), you can use the new, migrated branch to recreate this pull request.
Your pull request is important for us: Can you please re-create your pull request in the new repository?
1. Create a new fork of https://github.com/apache/hadoop-ozone
2. Clone it and have both your fork and the apache repo as remotes:
git clone git@github.com:adoroszlai/hadoop-ozone.git
cd hadoop-ozone
git remote add apache git@github.com:apache/hadoop-ozone.git
git fetch apache

3. Fetch your migrated branch and push it to your fork.
git checkout -b HDDS-2267 apache/HDDS-2267
git push origin HDDS-2267

4. And create the new pull request on the new repository.
https://github.com/apache/hadoop-ozone/compare/master...adoroszlai:HDDS-2267?expand=1
If you need more information, please check this wiki page or contact with me (my github user name + apache.org).
Thank you, and sorry for the inconvenience.

Moved to https://github.com/apache/hadoop-ozone/pull/8


[Broken] NBC - ERROR: Unable to download webpage: HTTP Error 400: Bad Request

Checklist

[X] I'm reporting a broken site support
[X] I've verified that I'm running youtube-dlc version 2020.11.11-3
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X I've searched the bugtracker for similar issues including closed ones

Verbose log
U:\>c:\support\youtube-dlc.exe --verbose --ap-mso Charter_Direct --ap-username <username> --ap-password <password> "https://www.nbc.com/below-deck/video/champagne-wishes-and-caviar-screams/4272148"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--ap-mso', 'Charter_Direct', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', 'https://www.nbc.com/below-deck/video/champagne-wishes-and-caviar-screams/4272148']
[debug] Loading archive file None
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dlc version 2020.11.11-3
[debug] Python version 3.8.6 (CPython) - Windows-10-10.0.19041-SP0
[debug] exe versions: ffmpeg N-92986-gaceb9131c1, ffprobe N-92986-gaceb9131c1
[debug] Proxy map: {}
[NBC] 4272148: Downloading JSON metadata
[NBC] 4272148: Downloading Provider Redirect Page
ERROR: Unable to download webpage: HTTP Error 400: Bad Request (caused by <HTTPError 400: 'Bad Request'>); please report this issue on https://github.com/blackjack4494/yt-dlc . Make sure you are using the latest version; type  youtube-dlc -U  to update. Be sure to call youtube-dlc with the --verbose flag and include its complete output.
  File "youtube_dlc\extractor\common.py", line 632, in _request_webpage
  File "youtube_dlc\YoutubeDL.py", line 2316, in urlopen
  File "urllib\request.py", line 531, in open
  File "urllib\request.py", line 640, in http_response
  File "urllib\request.py", line 569, in error
  File "urllib\request.py", line 502, in _call_chain
  File "urllib\request.py", line 649, in http_error_default

Description
Unable to extract video id.
This affects ALL of the NBC network sites:
https://www.nbc.com/networks/oxygen
https://www.nbc.com/networks/cnbc
https://www.nbc.com/networks/e
https://www.nbc.com/networks/usa
https://www.nbc.com/networks/bravo

I can confirm I'm getting the same error on Youtube video as well.

All seems fine to me. I just downloaded SNL and Transplant. Admittedly, I can't download your link, but that seems to be (according to the error) because I don't have a TV provider.

It turns out, that NBC no longer supports Charter_Direct as an MSO, and neither youtube-dlc or youtube-dl supports Spectrum as an MSO.  This works just fine with other MSOs, like DTV.


CDN version

Are there any plan to make a CDN version of the file so that it can be included with a simple

I used to have it, as sprae.auto.js, but found that not as useful, since almost always UI needs some interaction with state (sooner or later) and it's better to have module version from the beginning. I can reconsider if you have convincing case

@dy
If that's enough, I'll just describe my case:

it is forbidden to use bundlers and builders
all libraries on the page are included only as the CDN version by simple

I see what you mean now, an old school window.sprae without bundlers/modules etc, like window.jQuery.
It creates porridge here though, although to lesser extent.
Yeah, I guess that version could make sense, I can add something like
<script src="https://unpkg.com/sprae" init/> - that would cover all non-ESM cases, like global object, require, AMD, etc, also would optionally enable autoinit.

@dy
May I ask how long it takes to do this?
I do not want to rush you in any way, just to plan my work.

Do you need it urgently?
I was thinking to release it likely next minor version, possibly today.

@dy
It would be very cool!
Because I'm already working on this code right now and I really need sprae.
Thanx!

@vanodevium ok, I'll work on it the next few hours, thanks for the PRs

Ok, added in v10.9.0

@dy
it's WOW, it's awesome!
Thanx!

works like a charm


llama2&recipes-map module library frame composition

全球首发，llama2系列模块库架构图 Global launch, llama2-map module library frame composition
https://github.com/ziwang-com/AGI-MAP

@ziwang-com thanks for the suggestion pls make a PR if you think that fits into our doc, will review there.


Error implementing dependency

After i have copied the dependency, i pasted it in my app.build gradle and synced it. When i tried calling it from the xml layout, it was not showing <com.github.chrisbanes.photoview.PhotoView

After i have copied the dependency, i pasted it in my app.build gradle and synced it. When i tried calling it from the xml layout, it was not showing <com.github.chrisbanes.photoview.PhotoView

Check this solution https://github.com/Baseflow/PhotoView/issues/810


Displaying statistics on the use of programming language features

I propose to make it possible to view a detailed summary of the used and unused features of the current programming language.

/needsMoreInfo

Hi! E.g if I did not use null propagation in current project and I do not know about it then I MUST discover it using the statistics information.

This is up to each language/extension. Please file individual features requests against them for the statistics you want to see


Add support for custom JSON serialization options

Hello.
Description
The current implementation of the SearchAsync method in the Index class uses hardcoded JSON serialization options (src), which makes it difficult to use custom serialization options.
The implementation of the AddDocumentsAsync method in the Index class also not pass a JsonSerializationOptions, thus HttpExtensions applies hardcoded options (src).
Is it no possible to use custom converters or use different naming policy.
I think that a ability to customize objects serialization is important for integration Meilisearch in existing projects, especially in the projects with complex data models or custom JSON serialization policies.
Basic example
var options = new JsonSerializerOptions
{
    Converters = { new BaseClassConverter() },
};

var client = new MeilisearchClient("http://localhost:7700", "masterKey", options);

It one of many examples of desired implementations. C# is not my main programming language, so i'm not sure that is a best example of the feature interface.

I aggree with previous speaker. I have polymorphic classes and wanna write and read data via abstract base class. I can't use attributes because models are from nuget package (external contracts).

Hello everyone here, thanks for the suggestion and your participation!
If I'm correct, this will not impact the users who don't need this option, this would be only an addition to the library (not breaking).
@juchom if you are around, I would love to have your opinion on this 😊
So far, since the community seems to need it, I would go for a "let's do it!"

Hello,
Actually, this is a good idea, especially with dotnet 8 having new naming policies that may better fit some use cases.

If I'm correct, this will not impact the users who don't need this option, this would be only an addition to the library (not breaking).

You are almost correct :)
It will have no impact if the defaults are kept. You will have to make sure that creating a client like we do now will keep the same behaviours.

Actually it's a dupe of #311 I already opened 🤣

If I'm correct, this will not impact the users who don't need this option, this would be only an addition to the library (not breaking).

Yes, this is not breaking change and not impact the users who use meilisearch-client before. I think this should be an optional parameter in client ctor or something similar.

Oh yes, indeed a duplication! Closing this one in favor of #311 then 😄

ok, closed as dup


python notebook detection

I wish that gogs has support of python notebook.
detects and parse *.ipynb extension as Ipython notebook :)

GitHub has this function. and can parse ipynb file.

Potentially a duplicate of issue #3715 ?

Closed as duplicate


Kanban board Setup

Space Traveler's hub  🚀
Link to project
We are 2 people in this project:

@rtonata88
@MacCrazyman

Hi @MacCrazyman and @rtonata88
Woo ow 👏, Your project is complete!  There is nothing else to say other than... it's time to merge it. 👏
Congratulations! 🎉
Optional suggestion

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


Feature: Create "FOCUS" and "UNFOCUS "command

The FOCUS command will be my way of alleviating the pain of having to type extra long commands when wanting to manipulate records.
This command will help skip 1 or 2 laters(the collection and the cluster)
Here is an example of how it CURRENTLY is be manipulating a record within a cluster:
RENAME RECORD "test" WITHIN CLUSTER "foo" WITHIN COLLECTION "bar" TO "baz"
This is too much to constantly type. So my Idea is to implement a command called Focus. This command would essentially act as a starting point by taking in the focus target and object and store those values. All subsequently entered commands will no longer the target and object tokens like in the example above. The commands will just look for those stored values from earlier then "auto-fill" that information to then preform the action(s) needed
Now here is an example of possible implementation and usage of the Focus command:

FOCUS CLUSTER foo WITHIN COLLECTION bar

Note: Now every subsequent command will be preformed within the cluster: foo that is within the collection: bar

RENAME RECORD "hello" TO "world"

Note: Much cleaner and we can do more commands in the time it takes to currently type one

ERASE RECORD "baz"

NEW RECORD "goat"

UNFOCUS

Note: UNFOCUS will act as the stopping point, bringing the scope back to the "normal" level

This is so fucked


Add support for resuming partial downloads

I noticed that gogcli currently starts the download from scratch if I interrupt it, it would be nice if there was an option to resume partially downloaded files.
I tested this using the gog-api download-url-path command.
Perhaps an additional command to verify the checksum of an already downloaded file would be nice to have too! :grin:

There is the following command though it lacks the granularity you are seeking here for verification:
gogcli storage validate

Note that complementary to the above command, the following command will generate actions in your storage which you can resume to fix any divergence between your manifest and your stored files (including checkum values):
gogcli storage repair

Otherwise, for resuming downloads, its complicated right now. GOG provides endpoints for partial downloads, though for at least one game, I noticed it was broken (the xml data the api returns to parse the partial downloads metadata is literally malformed). Maybe its better on newer api endpoints.
Anyways, I won't say never, but realistically, partial downloads may take some time to support. Thankfully, for Windows installers at least, the installers are already broken down across several files by GOG and they tend not to have a Linux version for the biggest AAA games.
More fine-grained downloaded files validation would be more feasible to implement in the not so distant future.

Thanks for the info on validation.

Otherwise, for resuming downloads, its complicated right now. GOG provides endpoints for partial downloads, though for at least one game, I noticed it was broken (the xml data the api returns to parse the partial downloads metadata is literally malformed). Maybe its better on newer api endpoints though.

If I am understanding correctly, there are two API endpoints for downloading game files? I am assuming the "newer" endpoint is what GOG Galaxy uses, as it can pause and resume downloads. Hope support for this comes one day :smile:

If I am understanding correctly, there are two API endpoints for downloading game files? I am assuming the "newer" endpoint is what GOG Galaxy uses, as it can pause and resume downloads. Hope support for this comes one day smile

I believe that it may actually be a legacy feature that the now deprecated GOG Downloaded used.


Kachery processes overloading server

Typhoon, the computer that is running the kachery client and that handles all things sortingview in the lab, has crashed several times in the past week. This seems to arise because many kachery processes are running, consuming too much memory.
Many processes are presumably running because I and others are interacting with sortingview, testing and curating data. In one of the recent crashes, our system administrator said that the out-of-memory killer was invoked, and that he observed >50 processes running, each consuming >40 GB, maxing out the full 2 TB memory available and using all the swap space. These crashes not only disrupt sortingview for us, but also disrupt our access to our mySQL database server and anything else running on that machine, so I think this is relatively high priority.
For the time being, @khl02007 has modified a config file to control the number of such processes that can run on typhoon at a time, which should definitely help avoid crashing. In addition, I and other lab members can do our best to limit the number of sortingview windows we open at any given time.
When brainstorming with @lfrank, we weren't sure if leftover processes can build up over time too (totally guessing, but something like in #116 perhaps,  where incomplete tasks that always stay "waiting" could potentially hang around longer than needed?).
Any thoughts about what else can be done to be careful about the number of kachery processes running and kachery's overall memory usage? Thanks so much.

We may have some sort of memory leak, or process accumulation leak as you say. I am marking this as high priority and we'll work out how to best diagnose/fix the issue.


fix issue #868

This PR intends to fix issue #868
Seems like it was a deleted copy constructor that was getting called.
May be an issue with come compilers.
Here is some more detail from the build toolchain:
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
...

@googlebot I signed it!

@googlebot I signed it!


SQL Server : Cannot add/discover tables

Superset version
Superset 0.15.4
Centos 7
Python 3.6.0
alembic==0.8.10
amqp==1.4.9
anyjson==0.3.3
Babel==2.3.4
billiard==<IP_ADDRESS>
celery==3.1.23
cffi==1.9.1
click==6.7
colorama==0.3.7
crc16==0.1.1
cryptography==1.5.3
defusedxml==0.5.0
Flask==0.12
Flask-AppBuilder==1.8.1
Flask-Babel==0.11.1
Flask-Cache==0.13.1
Flask-Login==0.2.11
Flask-Migrate==1.5.1
Flask-OpenID==1.2.5
Flask-Script==2.0.5
Flask-SQLAlchemy==2.0
Flask-Testing==0.5.0
Flask-WTF==0.14.2
future==0.16.0
gunicorn==19.6.0
humanize==0.5.1
idna==2.2
itsdangerous==0.24
Jinja2==2.9.5
kombu==3.0.37
Mako==1.0.6
Markdown==2.6.6
MarkupSafe==0.23
mysqlclient==1.3.10
numpy==1.12.0
pandas==0.18.1
parsedatetime==2.0
ply==3.10
pyasn1==0.2.3
pycparser==2.17
pydruid==0.3.1
PyHive==0.2.1
pymssql==2.1.3
pyodbc==4.0.13
python-dateutil==2.5.3
python-editor==1.0.3
python-redis==0.1.4
python3-openid==3.1.0
pytz==2016.10
redis==2.10.5
requests==2.10.0
sasl==0.2.1
simplejson==3.8.2
six==1.10.0
SQLAlchemy==1.0.13
SQLAlchemy-Utils==0.32.7
sqlparse==0.1.19
superset==0.15.4
thrift==0.10.0
thrift-sasl==0.2.1
thriftpy==0.3.9
Werkzeug==0.11.10
WTForms==2.1

Expected results
When adding a SQL Server data source, I should see the list of tables.
When adding a table, it should work
Actual results
When adding a SQL Server, the server is added successfully and the connection shown as OK, but the tables are not listed at the bottom of the form.
When adding a table manually, Superset complains that Table [dbo.Domain] could not be found, please double check your database connection, schema, and table name
Steps to reproduce

Setup a connection using pymssql and freetds to a database
Configure Superset to connect to it

####################
I'm trying to setup a SQL Server 2016 database with SuperSet and I'm having some issues :
I could check the debug logs of FreeTDS, for the first issue (Tables not showing when adding the database), I could see that the query FreeTDS run to discover the tables using targetting the "guest" schema, I have no idea why, I tried to find where was this guest thing configured, without success :
SELECT [TABLES_1].[TABLE_NAME]
FROM [INFORMATION_SCHEMA].[TABLES] AS [TABLES_1]
WHERE [TABLES_1].[TABLE_SCHEMA] = CAST(N'guest' AS NVARCHAR(max)) AND [TABLES_1].[TABLE_TYPE] = N'BASE TABLE' ORDER BY [TABLES_1].[TABLE_NAME]

Its returns nothing as guest doesn't exists.
For the second issue, when setting the schema and the correct table name, I can see on the query that it find the tables without issues and get the fields, but I don't know why SuperSet complains that it cannot find it, here is the query it runs :
SELECT [COLUMNS_1].[TABLE_SCHEMA], [COLUMNS_1].[TABLE_NAME], [COLUMNS_1].[COLUMN_NAME], [COLUMNS_1].[IS_NULLABLE], [COLUMNS_1].[DATA_TYPE], [COLUMNS_1].[ORDINAL_POSITION], [COLUMNS_1].[CHARACTER_MAXIMUM_LENGTH], [COLUMNS_1].[NUMERIC_PRECISION], [COLUMNS_1].[NUMERIC_SCALE], [COLUMNS_1].[COLUMN_DEFAULT], [COLUMNS_1].[COLLATION_NAME]
FROM [INFORMATION_SCHEMA].[COLUMNS] AS [COLUMNS_1]
WHERE [COLUMNS_1].[TABLE_NAME] = CAST(N'Domain' AS NVARCHAR(max)) AND [COLUMNS_1].[TABLE_SCHEMA] = CAST(N'dbo' AS NVARCHAR(max)) ORDER BY [COLUMNS_1].[ORDINAL_POSITION]

It returns the correct result, but SuperSet complains that it doesn't exists
Here is the "standard" FreeTDS I have :
[MyServer1]
	host = 10.0.0.xx
	port = 1433
	tds version = 8.0

Thank you.

Also, on the SQL Editor, I can see all my schemas, but I can't see any tables in the schemas, only th stored procedures.

I found one way to fix this.
Apparently, the sqlalchemy only connect to the database that is defined as "Default database" on the user at SQL Server level.
Is there any other way to use a single user to connect to multiple databases ?

@kedare this seems very related to similar issues observed on Postgres/Redshift as these databases have an extra layer of namespacing. Postgres has multiple schemas per "database" and SQL Server has multiple "owners" I believe.
SQLAlchemy, as a common denominator API to interface with these databases has some limitations and doesn't offer the abstractions we need to deal with all this (afaik).
It seems like ideally we'd need the left panel navigator in SQL Lab to allow to navigate the full namespacing of each database engine, with the proper labels for the dropdowns. For this to work, we'd have to customize the code a bit. Luckily there's already a placeholder module to handle this abstraction (db_engine_specs.py).
We need a comprehensive solution that will make it clear what the levels of namespacing are and related methods/endpoints to get lists of these objects.

Airbnb won't drive this at this moment, only enable people in the community to do so. Whatever solution gets put in place we should make sure that it works for all db engines.

What would be the best way to use it for a single schema ?
I could add the database, see the tables, but I can't run any query, I always get : (pymssql.OperationalError) (18456, b'DB-Lib error message 20018, severity 11:\nGeneral SQL Server error: Check messages from the SQL Server\nDB-Lib error message 20018, severity 14:\nGeneral SQL Server error: Check messages from the SQL Server\nDB-Lib error message 20002, severity 9:\nAdaptive Server connection failed (DBLive1:1433)\n')
And when checking SQL Server logs : Login failed for user 'app-superset'. Reason: Failed to open the explicitly specified database 'dbo'. [CLIENT: 10.0.0.xx]
It's trying to connect to the dbo database (That doesn't exists) instead of using the dbo schema. (I removed any explicit schema of the configuration)

Hmm... I tested more, when I empty the "schema" field on the SQL Lab, I don't get this error anymore, but then when the query finishes running, I get a "Unserializable object"

Hmm some tables works fine, some others not, maybe there are some datatype that can cause that ? I'll do more testing

Here's a hacky fix we just landed (not deployed) for postgres:
https://github.com/airbnb/superset/pull/1789/files
You could try adding mssql where it says redshift and see if it allows you to move forward

@kedare , do you mind sharing your connection string? I'm trying to connect to MS SQL myself and I'm having a lot of issues. I've tried both
mssql+pymssql://sa:@serverip.com:1533/Database_name
and
mssql+pyodbc://sa:**@serverip.com:1533/Database_name
with no luck :/
I've installed both the pymssql and pyodbc drivers as well

Thanks, I will take a look.
I have another issue related to MSSQL, I could do a SQL query that appears fine in the SQL Editior, I can see the result also :
select c.Name as country, count(*) as count from House as h
inner join Country as c on h.country_id = c.id
group by c.Name
order by count desc

But when I try to graph it (with Vizualize, with the default parameter), if I try to get a Pie Chart for example (Count of each group), I get an "error" (Just the red div) with just " 'country' " inside.
I did something similar with a MySQL datasource without any issue.
Do you have any idea of what could be the cause ?

I wouldn't alias using a reserved work (count). Could that be the issue?

At the end I upgraded to Git head, and I could get the generated query. The issue was that as it's put as a subquery, you can't use a "ORDER BY".
But should not it return the SQL error directly instead of this ?

Mind trying to add a line that says limit_method = LimitMethod.FETCH_MANY
https://github.com/airbnb/superset/blob/master/superset/db_engine_specs.py#L337
The idea is that we want to limit the number of rows returned even when users query large tables. This line will change the approach from wrapping the user's SQL as a subquery to using the cursor's fetchmany(LIMIT) method instead.
Let me know if it works and please send that in a PR if it does.

What test should I do to make sure it works ?

Just making sure everything works including the issue you described earlier

I have similar issue with  superset 0.17.1 Python 2.7  Debian
OperationalError: (pymssql.OperationalError) (18456, "Login failed for user 'SuperSet'.DB-Lib error message 20018, severity 14:\nGeneral SQL Server error: Check messages from the SQL Server\nDB-Lib error message 20002, severity 9:\nAdaptive Server connection failed (<IP_ADDRESS>:1433)\n")  it occures when I'm trying run select from chosen table. I see this erroro in a server concole, but there is nothing in Superset Web UI.

The same with 0.15.4

(pymssql.OperationalError) (18456, 'DB-Lib error message 20018, severity 11:\nGeneral SQL Server error: Check messages from the SQL Server\nDB-Lib error message 20018, severity 14:\nGeneral SQL Server error: Check messages from the SQL Server\nDB-Lib error message 20002, severity 9:\nAdaptive Server connection failed (xxx.xxx.xxx.xxx:1433)\n')

@kedare  did you finaly resolve this MS SQL issue some how?

I didn't had the time to check, I'll do it in the next days


AppCenter Post Clone script must be in root or with .sln file (doesn't work if in sub directory with .csproj)

The documentation says: "Place the scripts with the format specified below next to the project-level (.xcodeproj, .csproj, .sln, or package.json) file"
However, if the .csproj is in a subdirectory below .sln, placing the Post Clone script in the subdirectory with the .csproj does not work (script is not recognised).
Moving it back up to the root folder (or with the .sln file) worked.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca50588e-c8ad-2b8e-683f-bc5fc612dfe4
Version Independent ID: 5d9513bd-d179-eaeb-96aa-06bd5ba0224f
Content: Build Scripts - Visual Studio App Center
Content Source: docs/build/custom/scripts/index.md
Service: vs-appcenter
Sub-service: app-center-build
GitHub Login: @King-of-Spades
Microsoft Alias: kegr

@joehanna Thanks for the report! I'm trying to reproduce the issue you're describing with this sample: https://github.com/microsoft/appcenter-Xamarin.UITest-Demo/tree/master/
I am able to see the build scripts in the .csproj sub folders, however; it looks like they're only displayed if I'm targeting the .csproj file in the Build configuration. Building with the .sln as the target doesn't seem to show those; so I think Build is only looking in the folder containing the main target.


Clean node cache when running dev server

Combine layouts, metadata, routes into data object
Some minor change in web_modules/layouts/index.js

Don't merge yet. I messed up something here. The original branch works like a charm

Forgot about collection. React will complaint about invalid checksum when we change the markdown content. Btw, renamed data to exports, this PR should be backward compat with 0.7.1

As soon as someone need to update it script/build or something in this folder, it's actually a breaking change.

Before statinamic reach 1.0, public API will keep changing...

Yeah but that not just an addition :) (no big deal, just to be clear).

There is in this PR a real change (even if it's really minor)

So change CHANGELOG from 'Added' to 'Changed' right ?

You can probably add two entries?

Changed: build and client scripts now require an exports value that must contains layouts, metadata and routes
Added: during development for pre-rendering, dev server will refresh all files for each render

Updated changelog.

Nice. Will merge and release with custom routes feature when I have some times.

Squashed. Just let you know that client script wasn't changed in this PR.

@MoOx could you merge this into next branch ? I'm gonna send a different request that has conflict with this one

Yeah but maybe we should change this in order to "normalize" build and client bootstraps?

I'm on it

Ok I will see that change for client script later.


Updated MITRE ATT&CK to v14.1

STIX sources has been updated to latest version of MITRE ATT&CK. Techniques used by some threat actors were missing.

Thank you @socketz for submitting this pull request! I need to make a few edits (we don't check in the ATT&CK json files, and I want to update the ATT&CK badge in the README) so I'm to close this PR without merging, but I did commit the same changes on main and tagged a new release that will go live shortly.


expanding of tests <testing

More testcases added to multiple testclasses. Testing the new features.

Many new testcases, great! I found two methods that were not implemented yet: testPoison and testSpeedup in the PlayerTest class, what is the reason for this?

The reason for that is that I was not sure how to test those methods, so I was planning to ask the other members of the group if they had any ideas. But as we're most likely to forget these two methods when they're not there I decided to put them in and comment that they were not finished yet. So we would not forget them.

Ah in that case I understand your reasoning, in our next lab course we should discuss this topic.


Add options to store global default and per-workbook default export folder locations

Can just add a couple of buttons to the form and store (a) the per-workbook default folder in that workbook, and (b) the global default folder in the .xlam.
Should implement a ~hidden helper function to easily clear the default folder from the .xlam.
Could also implement storage of all of the parameters on the form.

Form is getting complex enough that it's annoying to have to reconfigure everything every time.

Storage of the save-to folder path will require addition of a validity check on that path. If the path isn't to an existing folder (maybe even check if it's writeable?), then disable export and change the font color to red.

Probably implement ClassModule to hold settings info, translate to/from settings string. Probably makes the most sense to house the core defaults in this class, which are spit out if there's no settings Property on the .xlam or the active workbook, or if parsing of the options string fails.
Nonprintable character in settings string as separator?

Add option to save multiple settings configurations? New modal dialog for settings save/load. Would want to stack all settings into a single document property, or else the number of properties would rapidly get out of hand.
OTOH, there's a character limit for document properties, but apparently no functional limit to the number of document properties that can be created.
Looks like the better way to go is to use Workbook.CustomXMLParts (see here and here, which does not have a size limit and which is intrinsically a structured datatype!
Maybe there's an XML parsing/writing library already available in the builtin References, too....