[WFCORE-5520] Avoid Nullpointer (Remoting)

Fixes https://issues.redhat.com/browse/WFCORE-5520

Core - Full Integration Build 10917 outcome was FAILURE using a merge of 5a659c8d9a951ae9870e410df0588d249cbd3f96
Summary: Tests failed: 1 (1 new), passed: 7538, ignored: 147 Build time: 03:19:09
Failed tests
org.jboss.as.test.clustering.cluster.singleton.SingletonDeploymentJBossAllTestCase.test: java.lang.AssertionError: expected:<200> but was:<404>
	at org.jboss.as.test.clustering.cluster.singleton.SingletonDeploymentTestCase.test(SingletonDeploymentTestCase.java:130)
------- Stdout: -------
Warning! The CLI is running in a non-modular environment and cannot load commands from management extensions.
 [0m11:45:22,505 INFO  [org.jboss.as.connector.subsystems.datasources] (MSC service thread 1-3) WFLYJCA0010: Unbound data source [java:jboss/datasources/ExampleDS]
 [0m [0m11:45:22,505 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-3) WFLYMAIL0002: Unbound mail session [java:jboss/mail/Default]
 [0m [0m11:45:22,506 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 42) MODCLUSTER000002: Initiating mod_cluster shutdown
 [0m [33m11:45:22,508 WARN  [org.jboss.modcluster] (ServerService Thread Pool -- 42) MODCLUSTER000033: Failed to interrupt socket reception.: java.io.IOException: Invalid argument (sendto failed)
	at java.net.PlainDatagramSocketImpl.send(Native Method)
	at java.net.DatagramSocket.send(DatagramSocket.java:693)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.interruptDatagramReader(AdvertiseListenerImpl.java:197)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.stop(AdvertiseListenerImpl.java:212)
	at org.jboss.modcluster.advertise.impl.AdvertiseListenerImpl.destroy(AdvertiseListenerImpl.java:224)
	at org.jboss.modcluster.ModClusterService.shutdown(ModClusterService.java:199)
	at org.wildfly.extension.mod_cluster.ContainerEventHandlerServiceConfigurator.accept(ContainerEventHandlerServiceConfigurator.java:83)
	at org.wildfly.extension.mod_cluster.ContainerEventHandlerServiceConfigurator.accept(ContainerEventHandlerServiceConfigurator.java:50)
	at org.wildfly.clustering.service.FunctionalService.stop(FunctionalService.java:73)
	at org.wildfly.clustering.service.AsyncServiceConfigurator$AsyncService.lambda$stop$1(AsyncServiceConfigurator.java:142)
	at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
	at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1990)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
	at java.lang.Thread.run(Thread.java:748)
	at org.jboss.threads.JBossThread.run(JBossThread.java:513)

 [0m [0m11:45:22,509 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0008: Undertow HTTP listener default suspending
 [0m [0m11:45:22,509 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0008: Undertow HTTPS listener https suspending
 [0m [0m11:45:22,509 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-2) WFLYUT0008: Undertow AJP listener ajp suspending
 [0m [0m11:45:22,511 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-1) WFLYUT0019: Host default-host stopping
 [0m [0m11:45:22,511 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-1) WFLYJCA0019: Stopped Driver service with driver-name = h2
 [0m [0m11:45:22,511 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-2) WFLYUT0007: Undertow AJP listener ajp stopped, was bound to [::1]:8009
 [0m [0m11:45:22,512 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-5) WFLYUT0007: Undertow HTTP listener default stopped, was bound to [::1]:8080
 [0m [0m11:45:22,512 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0007: Undertow HTTPS listener https stopped, was bound to [::1]:8443
 [0m [0m11:45:22,513 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0004: Undertow 2.2.10.Final stopping
 [0m [0m11:45:22,527 INFO  [org.jboss.as] (MSC service thread 1-7) WFLYSRV0050: WildFly Full 25.0.0.Beta1-SNAPSHOT (WildFly Core 17.0.0.Beta5-SNAPSHOT) stopped in 28ms
 [0m [0m11:45:22,527 INFO  [org.jboss.as] (MSC service thread 1-6) WFLYSRV0049: WildFly Full 25.0.0.Beta1-SNAPSHOT (WildFly Core 17.0.0.Beta5-SNAPSHOT) starting
 [0m [0m11:45:22,559 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 7) WFLYCTL0033: Extension 'security' is deprecated and may not be supported in future versions
 [0m [0m11:45:22,580 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m11:45:22,609 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 40) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m11:45:22,620 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m11:45:22,640 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 47) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [33m11:45:22,655 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-3) WFLYELY00023: KeyStore file '/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/standalone/configuration/application.keystore' does not exist. Used blank.
 [0m [33m11:45:22,655 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-3) WFLYELY01084: KeyStore /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/standalone/configuration/application.keystore not found, it will be auto generated on first use with a self-signed certificate for host localhost
 [0m [0m11:45:22,655 INFO  [org.wildfly.extension.health] (ServerService Thread Pool -- 55) WFLYHEALTH0001: Activating Base Health Subsystem
 [0m [0m11:45:22,657 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 56) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m11:45:22,657 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 57) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m11:45:22,659 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 58) WFLYRS0016: RESTEasy version 3.15.1.Final
 [0m [0m11:45:22,660 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 61) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.11
 [0m [0m11:45:22,661 INFO  [org.wildfly.extension.metrics] (ServerService Thread Pool -- 66) WFLYMETRICS0001: Activating Base Metrics Subsystem
 [0m [0m11:45:22,662 INFO  [org.jboss.as.connector] (MSC service thread 1-1) WFLYJCA0009: Starting Jakarta Connectors Subsystem (WildFly/IronJacamar @VERSION@)
 [0m [0m11:45:22,662 INFO  [org.wildfly.extension.microprofile.config.smallrye] (ServerService Thread Pool -- 67) WFLYCONF0001: Activating MicroProfile Config Subsystem

connectorPropertiesOptionMap is also used similarly on L179, if finally this change is accepted, the if sentence on L179 should be modified accordingly.

@yersan thanks for your feedback. I have changed the PR accordingly. Please check again.

Hello @yersan please have a look at this version. It relies on resultingMap now.

Sorry @boris-unckel , this PR can be closed, we have been working on a piece of code that was going to be removed, see https://github.com/wildfly/wildfly-core/pull/4716

@yersan Anyway no problem anymore. Thanks for your ongoing support. :+1:


How to change the favicon icon in the header

Summary
Relevant information

Theme

Environment (if relevant)

File contents (if changed)
gatsby-config.js: N/A
package.json: N/A
gatsby-node.js: N/A
gatsby-browser.js: N/A
gatsby-ssr.js: N/A

Please fill out the issue template, I sadly don't know what you're talking about. Thanks!

Will close this as stale, please reply with a filled out template if you still need help.


[DRAFT] Attempt fix Jms watermark

Originally, the problem was watermark set to Instant.now() at initialization and after finalizing every non zero checkpoint mark. This had two issues

watermark can be too new for incoming data, when checkpoint is not finalized
watermark does not increase when there is no incoming data for a while

This PR attempted to address both.
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

However, it seems currently it's not work as expected. The watermark still increase when no incoming data:


Scaffolds and cf CLI Meta issue

CLI

The CLI will be a binary called cf which can be installed globally. Packages that depend on it should install it locally as a devDependency.

API
If cf is invoked with missing arguments, it should:

display usage
prompt for missing arguments, one at a time

build
Create a new package from a Cloverfield scaffold. Scaffolds should be cached locally. See Scaffold Conventions
Usage
cf build <scaffold-name>
TODO:

[x] Settle on standard taskrunner (selected npm scripts)
[x] Scaffold conventions doc
[ ] Use prod-module-boilerplate for the cf repo. See the blue-tape issue, first.
[ ] Document plugin API for cf commands. Each command should describe its purpose, usage, each argument, and descriptions for each argument. Those args requirements and descriptions can be used for interactive help.
[ ] Create stub cf command & tests to unit test plugin API - use blue-tape
[ ] Create the command line tool to invoke scaffolds
[ ] Create cf-package based on prod-module-boilerplate
[ ] Create cf-react-app based on universal-react-boilerplate
[ ] Create a cf-react-ui to generate stateless, reusable UI component (needs boilerplate)
[ ] Create a cf-react-cerebral to generate a cerebral container that wraps a UI component to integrate it with app state. (needs boilerplate)

@nkbt Now that the boilerplates are starting to shape up, are you interested in working on this?

By all means, always wanted to build one for myself =)

Great. I've created the Scaffold conventions doc. Feel free to take on the build tooling at your convenience.

See JSHomes Platform Meta issue

This is looking great so far. I will be a little busy the next couple days but I plan on helping out!

:+1:

https://twitter.com/sethetter/status/618779021526970368
This is worth calling out. My primary problem with yeoman is the ecosystem signal to noise ratio. It got so bad, when I thought about scaffold solutions and realized we could probably just wrap yeoman, the idea of even having the project associated with yeoman mentally was bad enough it was worth starting from scratch.
So the question: how do we prevent the inevitably terrible scaffolds from turning off users?
I think the answer is that the CLI should have first class search and discovery for curated scaffolds, and no search/discovery for community scaffolds. If people want to search past the cf whitelist, they can use npm search, Google, or GitHub search.
We're not yeoman and we're not npm, where you search for needles in a giant haystack. We're a tool for eliminating choices, not adding to them.

:+1:

@nkbt It's been a while since we saw any activity here. Where are we on turning prod-module-boilerplate into a cf scaffold?

The base for cf package is merged now, so we can go further... It's been a
pretty busy time anyway :).


light weight CLI

removed ink usage from package/cli instead using light weight chalk, ansi-escapes etc.

Closing in favor of https://github.com/proto-kit/framework/pull/141


[Security Center] Updating operation IDs to better describe the operation

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[x] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/openapi sdkautomation

/azp run automation - sdk

/azp run automation - sdk

Hi @chlahav, Is this change to fix bug? if no, I suggest you can change this in new version, as changing operation id is a break change which will impact generated SDK's function name.

not a bug, will change the operation ID when going GA (removing the "-preview" suffix)


Be even more explicit about the semantics of _.isEmpty

This is meant to address #2804.
@mcurrao Please let me know whether this sufficiently addresses the problem for you.

Thanks @jashkenas. As I understand it, you are fine with the current change (given that I have removed the counter-example that you rightly pointed out). So if @mcurrao is fine with this, too, I'll just merge this.

@jgonggrijp LGTM. Only missing elements would be functions, but as they can be considered non-enumerable objects, I guess there is no need to include them. Thanks!

Sorry, requesting another review anyway because I just noticed a tautology in the code and removed it.


[TACHYON-1337] Revert un-ignore of broken test

https://tachyon.atlassian.net/browse/TACHYON-1337
This test was unignored in https://github.com/amplab/tachyon/pull/2106, but breaks on the hdfs1Test profile.

LGTM.


error displaying a3hd

In GitLab by @pabretonniere on Mar 1, 2021, 18:00
Hi @wuruchi
I can't open the GUI for a3hd: http://bscesweb04.bsc.es/autosubmitapp/experiment/a3hd
I ran a monitor to get the pdf and it worked fine, and it seems to be loading the data but when it finishes, the page is empty...
Any clue?
Thanks

In GitLab by @pabretonniere on Mar 1, 2021, 19:58
No rush at all to fix http://bscesweb04.bsc.es/autosubmitapp/experiment/a3hd as it only happens for this exp.

In GitLab by @wuruchi on Mar 1, 2021, 19:10
Hello @pabretonniere
While I look into it, you can monitor your experiment directly from http://bscesweb04.bsc.es/autosubmitapp/experiment/a3hd/graph (Graph view).

In GitLab by @pabretonniere on Mar 1, 2021, 19:57
Thanks! Great. this is more than sufficient for me.


Added text to explain the gist permissions you need for your token

Just added a small text because if you don't configure the gist permissions you'll get a security error.

Thank you for improving the docs!


:memo: Please fill the about section :smile_cat:

Hi, this plugin is very very interesting :heavy_heart_exclamation:
Would you consider complete the project description :grey_question:

Thanks, I reached out to our friends at Liquibase, I currently don't have the right to edit that section.

@adriens We updated it.


Revert OTP version for docker until TLS is fixed

Current images are built with 24.3.4.
That version has a bug mentioned in the ticket below.

TLS handshake failure after upgrade to 24.3.4

Verified with 2 docker containers

erlang:24 (pulling 24.3.4)
erlang:24.3.3

Sent a test payload to msft DPS.
erlang:24 errored out with the TLS handshake error we're seeing in production.
erlang:24.3.4 request succeeded.

Upgraded and pinned grpcbox & chatterbox until stable from blockchain-core
blockchain-core is still in the middle of updating grpc communication.
grpcbox and chatterbox were moved from andymck org to novalabsxyz,
orphaning the ref in the lock file. core is not quite ready for another
bump, but we need to be able to pull these two repos to continue building.


Fix: Description for input fields not set correctly (@GraphQLInputField#description is ignored)

As I wrote here in my original thread: https://github.com/leangen/graphql-spqr/issues/466#issuecomment-1625892403
Descriptions set via the @GraphQLInputField annotation are not considered. I realized that when I printed the graphql schema by doing:
The source for the demo:
@GraphQLApi
@Component
public class DemoAPI {
    @GraphQLQuery(name = "demo")
    public DemoObject demoMethod(DemoObject demoObject) {
        return new DemoObject();
    }
}

@GraphQLType(name = "demo_object")
@Getter
@Setter
public class DemoObject {
    @GraphQLInputField(description = "important description\nabc")
    private String field;
}

The test class to generate the schema:
@SpringBootTest
class DemoApplicationTests {
    @Autowired
    private GraphQLSchema graphQLSchema;

    @Test
    void generateGraphQLSchema() throws IOException {
        String str = new SchemaPrinter().print(graphQLSchema);
        File newFile = new File("schema.graphqls");
        var fileWriter = new FileWriter(newFile);
        fileWriter.write(str);
        fileWriter.close();
    }
}

This will result in the following graphql schema:
... Directives left out for readability

"Query root"
type Query {
  demo(demoObject: demo_objectInput): demo_object
}

type demo_object {
  field: String
}

input demo_objectInput {
  field: String
}

With the fix:
... Directives left out for readability

"Query root"
type Query {
  demo(demoObject: demo_objectInput): demo_object
}

type demo_object {
  field: String
}

input demo_objectInput {
  """
  important description
  abc
  """
  field: String
}

This shouldn't be needed. The description is already discovered by Jackson here: https://github.com/leangen/graphql-spqr/blob/9b899d0defee4562534b7d8ce2fb17c1dc715e67/src/main/java/io/leangen/graphql/metadata/strategy/value/jackson/AnnotationIntrospector.java#L74
This is a Kotlin issue, but I don't what causes it. I'll look into when I get a chance. Alternatively, maybe you can troubleshoot it further?

Oh, before trying anything else: are you using the jackson-kotlin module?

Oh, before trying anything else: are you using the jackson-kotlin module? That's practically a prerequisite for correct Kotlin⇔Jackson integration.

@kaqqao No, I am not using it with kotlin or the jackson-kotlin module.
I have a spring boot 3 java application. Here is the demo to reproduce the issue: https://github.com/ErtugrulSener/description-issue-demo-app

Oops, sorry, I saw no methods and immediately assumed Kotlin (when it was actually Lombok). Because a similar issue was reported with Kotlin recently.

Fixed it in AnnotationIntrospector in https://github.com/leangen/graphql-spqr/issues/469. But thanks again for discovering the bug!

Fixed it in AnnotationIntrospector in https://github.com/leangen/graphql-spqr/issues/469. But thanks again for discovering the bug!

No problem, glad the bug is fixed now!


Fix error when calculate the repository size (#22392)

Backport #22392
Fix #22386
GetDirectorySize moved as getDirectorySize because it becomes a special function which should not be put in util.
Co-authored-by: Jason Song<EMAIL_ADDRESS>

CI has some linting errors


fix

Codecov Report

Merging #297 (8dfa236) into main (b7165c2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #297      +/-   ##
============================================
+ Coverage     58.94%   58.95%   +0.01%
- Complexity     1774     1775       +1
============================================
  Files           200      200
  Lines          8469     8469
  Branches       1193     1193
============================================
+ Hits           4992     4993       +1
  Misses         2761     2761
+ Partials        716      715       -1

Impacted Files
Coverage Δ

...m/baidu/cloud/starlight/api/utils/IDGenerator.java
78.57% <0.00%> (+2.38%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


How about generate Model.[hm]  and Model-modifiable.[hm] category rather than inherit

I mean mogenerate generate Model.[hm]
and one category of the Model, let it be modifiable. I think it's better to understand
and the underscore Model looks kind of wired

Closing this out.


config.js wha is?

What is config.js?
Missing file

@scinfu
Can you give me more context? Where is this file located?


Alternate experimental home page

Estimate implementation of this

interim images to use for background of the two buttons here:
https://drive.google.com/drive/folders/1A8EZAS7ACD_NluwhfzPoM5sPq0HRZa_k?usp=drive_link
region02.jpg, routes-journeys02.jp


color("$c") -> colorant"$c"

color("$c") is deprecated. This is throwing a warning that causes some tests to fail.

Codecov Report

Merging #275 (fee147c) into main (351427d) will decrease coverage by 4.42%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   53.93%   49.51%   -4.43%
==========================================
  Files          78       78
  Lines        7056     7052       -4
==========================================
- Hits         3806     3492     -314
- Misses       3250     3560     +310

Impacted Files
Coverage Δ

src/Examples/repeating_structure_examples.jl
0.00% <0.00%> (-28.27%)
:arrow_down:

src/Vis/VisRepeatingStructures.jl
0.00% <0.00%> (-93.03%)
:arrow_down:

src/RepeatingStructures/Lattice.jl
7.14% <0.00%> (-64.29%)
:arrow_down:

src/Geometry/CSG/CSG.jl
31.08% <0.00%> (-52.13%)
:arrow_down:

src/RepeatingStructures/Cluster.jl
0.00% <0.00%> (-51.86%)
:arrow_down:

src/RepeatingStructures/HexagonalLattice.jl
0.00% <0.00%> (-46.48%)
:arrow_down:

src/Vis/Visualization.jl
0.00% <0.00%> (-8.88%)
:arrow_down:

src/Geometry/Primitives/Sphere.jl
84.90% <0.00%> (-7.55%)
:arrow_down:

src/Geometry/Primitives/Cylinder.jl
79.62% <0.00%> (-7.41%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351427d...fee147c. Read the comment docs.


GeoIP fails due to certificate issue

Installation method: docker (ghcr.io image)
Version: latest (it actually is already a few days old once I pulled it)
Expected behavior
The geo data resolving is working.
Actual behavior
Unfortunately getting geo data for IPs fails for the url method using freegeoip.live fails with this error in the logs:
level=error ts=2022-10-24T13:00:58.462Z caller=geo.go:89 msg="Error getting GeoIp URL" err="Get \"https://freegeoip.live/json/xxxxxxxxx\": x509: certificate signed by unknown authority"

Possible solution
This probably happens due to the missing ca-certificates package in the image. Adding this to the Dockerfile should add them:
RUN apk add --no-cache ca-certificates && update-ca-certificates

If you want me to open a MR with the fix I will do so once I am having time for it.

Hi,
Thanks, yes, there is an error.
I'll fix it soon.

@CubicrootXYZ
It should be fixed now.


Fix the build triggering for approved pull requests

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] HISTORY.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Fixes the triggering of Pull Requests from review approval state

Does this PR introduce a breaking change?
Nope.
Other information:

@aulemahal We might need to relax some tests:
[gw0] linux -- Python 3.9.13 /home/runner/work/xclim/xclim/.tox/opt-slow-mamba/bin/python3.9

    def test_standardize():
        x = np.random.standard_normal((2, 10000))
        x[0, 50] = np.NaN
        x = xr.DataArray(x, dims=("x", "y"), attrs={"units": "m"})

        xp, avg, std = standardize(x, dim="y")

        np.testing.assert_allclose(avg, 0, atol=4e-2)
>       np.testing.assert_allclose(std, 1, atol=2e-2)
E       AssertionError:
E       Not equal to tolerance rtol=1e-07, atol=0.02
E
E       Mismatched elements: 1 / 2 (50%)
E       Max absolute difference: 0.02022699
E       Max relative difference: 0.02022699
E        x: array([0.991156, 1.020227])
E        y: array(1)

xclim/testing/tests/test_sdba/test_processing.py:167: AssertionError


chore: add pictograms

FX-3754
Description
Add all the pictograms from Figma.
After a discussion with Matt, we decided to not follow the naming from Figma 1:1. In Figma they added multiple names for each pictogram for better searching. In Picasso, we will use only the first name.
For example designer, expert, pen, tool-blue.svg 👉 DesignerBlue.tsx
How to test

All files were automatically generated
check the storybook

Screenshots
n/a
Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
Covered with tests

Breaking change

codemod is created and showcased in the changeset
test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers


About Us Page - Google map

Requirement

Generate the map that covers the whole world. The current map only covers US, Canada, and Mexico.
Generate the map that is wider, shorter, span top half of the page. Like this one: https://www.w3schools.com/graphics/google_maps_intro.asp
Center align the map. It is currently left aligned.

Reference
Go to web site: http://socialcoder.org/Home/Index
Zoom out the map.
You should be able to get a wider, shorter map that cover the world.

Current Page

Wireframe

This issue was moved to Code4SocialGood/c4sg-web#25


brag cuts literal when it is not instructed to

Hi,
I'm currently writing a grammar for a Prolog-like language. It contains the following rule: abstract-list : /"[" [abstract-term ("," abstract-term)* ["|" (abstract-list | abstract-variable)]] /"]"
If I use this rule to parse a larger data structure which contains an abstract list (for instance, (mycompound([g1,g2]))), the comma disappears from the parsed datum. If I put in a vertical bar instead, that is included in the parsed datum.
So, the whole parse tree, when I use a comma:
(at
  (treelabel
    ((abstract-atom "mycompound" (abstract-list (abstract-g-variable 1) (abstract-g-variable 2))))))

And the parse tree, when I use a bar:
(at
  (treelabel
    ((abstract-atom "mycompound" (abstract-list (abstract-g-variable 1) "|" (abstract-g-variable 2))))))

I figured this might have something to do with the cut also being applied in nested terms, so I rewrote the rule as follows:
abstract-list : /"[" [abstract-term term-tail ["|" (abstract-list | abstract-variable)]] /"]"
@term-tail : ("," abstract-term)*

But now the comma is included, so I get:
(at
  (treelabel
    ((abstract-atom "mycompound" (abstract-list (abstract-g-variable 1) "," (abstract-g-variable 2))))))

The latter is the result I want, but fail to see why the original rule and the one with the term-tail spliced in lead to a different outcome.

Here’s my attempt to make a test case that reproduces the problem:
parser.rkt
#lang brag
abstract-list : /"[" [abstract-term ("," abstract-term)* ["|" (abstract-list | abstract-variable)]] /"]"
abstract-term : "t"
abstract-variable : "v"

test.rkt
#lang br
(require "parser.rkt" brag/support)

(define (lex p)
  (λ () ((lexer
          [(eof) eof]
          [any-char lexeme]) p)))

(parse-to-datum (lex (open-input-string "[t,t]")))

Result:
'(abstract-list (abstract-term "t") "," (abstract-term "t"))

The comma is there. What am I missing?

I whittled down my code until the comma appeared and what I found was that the comma is missing when I use the following lexer, grammar and test:
#lang br
(require brag/support
              syntax/strip-context)
(define at-lexer
  (lexer-srcloc
   [(eof) (return-without-srcloc eof)]
   [(:+ whitespace) (token lexeme #:skip? #t)]
   [(:-
     (:seq (char-range "a" "z") (:* (:or (char-range "a" "z") (char-range "A" "Z") numeric  "_")))
     (:seq "g" (:+ numeric)))
    (token 'SYMBOL lexeme)]
   [(:or "(" ")" "[" "]" ",") (token lexeme lexeme)]
   [(:seq "g" (:+ numeric)) (token 'AVAR-G (string->number (substring lexeme 1)))]))
(provide at-lexer)

#lang brag
abstract-atom : SYMBOL [/"(" abstract-term (/"," abstract-term)* /")"]
@abstract-term : abstract-g-variable | abstract-list
abstract-g-variable : AVAR-G
abstract-list : /"[" [abstract-term ("," abstract-term)* ["|" (abstract-list | abstract-g-variable)]] /"]"

#lang br
(require brag/support rackunit "at-parser.rkt" "at-tokenizer.rkt")
 (check-equal?
  (parse-to-datum (apply-tokenizer make-tokenizer "myatom([g1,g2])"))
  '(abstract-atom "myatom" (abstract-list (abstract-g-variable 1) "," (abstract-g-variable 2))))

If I strip away the abstract-atom rule and try to parse "[g1,g2]", then the comma is there.

Thanks. I found the problem & fixed it.


how to add arrow on path

hi , i want to add arrow on path, how to control gap of paths?

Please use Stack Overflow tag d3.js to ask for help. Stack Overflow provides a better collaborative forum: thousands of D3-related questions have been asked there, and some answers may be relevant to you.
When asking for help, please include a link to demonstrate the issue, preferably as an Observable notebook. It is often impossible to debug from code snippets alone. Isolate the issue and reduce your code as much as possible before asking for help. The less code you post, the easier it is for someone to debug, and the more likely you are to get a helpful response.
If you have a question about D3’s behavior and want to discuss it with other users, also consider the d3-js Google Group or joining the d3-js Slack.
Thank you! 🤗


XLM Private Key support for iOS clients

Is your feature request related to a problem? Please describe.
I noticed that on iOS one cannot access an XLM address via a private key. Android on the other hand seems to support that feature.
Describe the solution you'd like
Add ability to import XLM wallets via private key.
Describe alternatives you've considered
Additional context

Thanks for the bug report, we will add private key import for XLM in iOS


Mark tests flaky instead of skipped

This should make sure there's plenty to hear about once we finish https://github.com/aspnet/AspNetCore-Internal/issues/1948.

How many of these fail every time? Not much point in marking them as flaky.

I think we should review all the ones we know about and keep the “consistently broken” ones as Skipped (or delete them). There are bound to be ones we don’t know/remember well though. Might be worth doing a survey of the flaky tests in, say, a week and for any of them that have never passed in that time, switch them back to fully skipped. Thoughts?
Sent with GitHawk

I was going to go with "unskip everything and let it make noise" but I'm fine with leaving consistently failing ones out.

:up::date: I reviewed the issues and left the ones that claim to fail every time as skipped.


Azure Private DNS Resolver?

Shouldn't this article recommend using an Azure Private DNS Resolver versus standing up a VM for DNS resolution?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7f5e21f3-0f89-d4f9-70c6-e2c238292863
Version Independent ID: 4f77c2f2-33e5-5481-8da8-77304704a62a
Content: Configuring DNS forwarding for Azure Files
Content Source: articles/storage/files/storage-files-networking-dns.md
Service: storage
Sub-service: files
GitHub Login: @khdownie
Microsoft Alias: kendownie

@wcneumann219 you're almost certainly correct that it would work and probably be easier than the VM approach. However, Azure DNS Private Resolver is a new service (launched in March) and the PM and docs team have not yet tested/documented it with Azure Files. I've added a work item to the May sprint to test this and add "Use Azure DNS Private Resolver for DNS forwarding" to this article.

#please-close


Code-splitting duplicates same dependencies in different bundles

Bug report
Describe the bug
When using _app.js page for common stuff (like creating redux store) - these libraries are duplicated between pages.
To Reproduce

Checkout  https://github.com/cherniavskii/nextjs-app-code-splitting-reproduction locally
Run npm install
Run npm run analyze
See bundle analyzer report

Expected behavior
redux and react-redux are bundled once.
Actual behaviour:
redux and react-redux are bundled many times - once in _app.js and in every page which is connected with Redux (index.js and home.js)
Screenshots

System information

OS: Windows
Browser (if applies) N/A
Version of Next.js: 6.1.0

Additional context
This app contains 6 pages:

_app.js - initializes redux store

index.js - connects with redux store

home.js - connects with redux store

about.js - renders single element, doesn't connect with redux

contacts.js - renders single element, doesn't connect with redux

offer.js - renders single element, doesn't connect with redux

This issue reproduces only when most of pages aren't connected with Redux (that's the way how code splitting works in Next.js).
But IMHO _app.js bundle should be treated like the "second main" bundle - since every page is wrapped in _app page.
There's no sense to duplicate libraries bundled in _app, since _app is always loaded

I've found the root of the issue:
https://github.com/zeit/next.js/blob/e98a877ee4a182d077cb5ba5e70500ae8bcbf986/build/webpack.js#L206-L213
When running on Windows, chunk.entryModule.name has value bundles\pages\_app.js, therefore inAppBundle becomes false.
I'm working on fix :)

Great catch 🙏


Fix variable and dimension renaming for nc3 with hashmap

Pull request to fix issue #282
Patch included in discussion of that issue, but easier to apply if supplied as pull request.
The problem is that the name was being updated prior to the old
variable being removed from the hashmap. It checks whether the key and
the name of the variable being removed match, but since the name had
already been updated, the names did not match so the variable was not
removed. This patch removes the variable from the hashmap first,
then updates the name, and then adds the variable with the new name to
the hashmap.
Similar change for renaming dimensions.

Looks good; while I was going to tackle the patches this week, I really appreciate you refactoring it as a pull request! I'll take a look as this ASAP, after the travis checks complete.
Thanks, have a great one!

Thanks, merged.


Implement [ExportToolButton]

Follow up to #96290, implementing the C# attribute.

✋ I leave this in draft for the following reasons:

I need to add tests in Godot.SourceGenerators.Tests.
Texts in the new diagnostics are placeholders. I'd appreciate if someone could take a stab at writing proper error messages, I'm quite bad at it myself.

I more or less reflected the GDScript annotation, with a new attribute [ExportToolButton]. It can be used on both fields, and properties of type Callable. I lifted the restriction on read-only exported properties for this specific usage. I don't think we need to do anything in ScriptPropertyDefValGenerator, unless I miss something major.
The DeterminePropertyInfo() method is becoming a bit convoluted. I'm pretty sure we could simplify it, but didn't want to refactor more than I needed. I could comment it more if it helps to navigate it, please tell me. Also, am I blind, or are the comments lines 452 and 463 wrong?
I introduced the following diagnostics:

GD0108, reported when [ExportToolButton] marks a member defined in a class not marked with [Tool].
GD0109, reported when [ExportToolButton] and [Export] mark the same member.
GD0110, reported when [ExportToolButton] marks a member that is not of type Callable.

The easiest way to use this is something like the following.
[Tool]
public partial class MyNode : Node
{
    [ExportToolButton("Click me!")] // You can pass an icon as second argument if you want.
    public Callable ClickMeButton => Callable.From(ClickMe);

    public void ClickMe()
    {
        GD.Print("Hooray!");
    }
}

It is also possible to use a backing field, but it becomes more verbose, since in C# we can't assign Callable.From(...) during fields initialization.
[Tool]
public partial class MyNode : Node
{
    [ExportToolButton("Click me!")] // You can pass an icon as second argument if you want.
    private Callable _clickMeButton;

    public MyNode()
    {
        _clickMeButton = Callable.From(ClickMe);
    }

    public void ClickMe()
    {
        GD.Print("Hooray!");
    }
}

Cheers ✨

I'm putting this in "ready for review". The last thing to do is write proper diagnostic messages, for which I'd still require some help.

It would be better if we can apply this attribute directly to a method.

It would be better if we can apply this attribute directly to a method.

The reasons it is not the case have been discussed in the original proposal, if you're interested.

I tweaked the messages and also refactored a bit to error when using a non-marshallable type (currently if you put the attribute on for example System.Action it won't error but it also won't work in the editor, which might be confusing) here https://github.com/a-johnston/godot/tree/dotnet/export-tool-button
The branch is rebased so I could use this with some other recent merges but if you'd prefer I can open a pr against your branch rather than cherry picking the latest commit off mine to yours.

currently if you put the attribute on for example System.Action it won't error but it also won't work in the editor, which might be confusing

That's a good catch. I'd want to take a second look to maybe find a less invasive way to handle this, tho.

The comments you called out are wrong and I think the handling was sort of copied from ScriptPropertyDefValGenerator.cs, or left over from a refactor. Those diagnostic errors are currently being raised twice between the two generators, so I changed ScriptPropertiesGenerator.cs to just filter with a comment clarifying the other class is responsible for raising the error.

I don't think this should be modified in this PR. It isn't really related to the new button thing, and faxing unrelated changes make things hard to track IMHO. It's also probably going to clash against #98396.

Also imo the error messages are fine. I tweaked them because you called out maybe changing them, but I think they are clear enough as is.

TBH, that was more of a call for @raulsntos, to make sure all of our diagnostic messages are more or less worded in the same way.

That's a good catch. I'd want to take a second look to maybe find a less invasive way to handle this, tho.

That's fair; I felt like the structure of ScriptPropertiesGenerator was not conducive to adding this check and I wasn't super happy with the impl, although this seemed preferable to tacking on a helper method with duplicated code or adding tool button validation to an otherwise unrelated generator. I do have thoughts on how to better organize this code but it probably isn't worth overhauling.

I don't think this should be modified in this PR. It isn't really related to the new button thing, and faxing unrelated changes make things hard to track IMHO. It's also probably going to clash against #98396.

I'll make a separate issue/pr then for it. It looks like it will conflict with that pr but not in a substantial way.

Thanks for the review. Everything you noted should be addressed 👍

Squashed and ready to go 🚀

Not sure it's worth it since we'll replace these generators in the future, but feel free to do this in a follow-up PR if you want.

Are there plans/goals for overhauling the generators or is this a hypothetical long-term thing?

Generators are very different in the GDExtension bindings.

Thanks!

In reference to https://godotengine.org/article/whats-new-in-csharp-for-godot-4-0/#gdextension-support (unsure if there are more recent links)? I think that would be welcome but if c# still stuck around as a scripting language in addition to a gdextension language, wouldn't these generators also continue being relevant, or do you anticipate them sharing code?

If you are interested in the development progress of the GDExtension-based integration, you may check this repo; please note that this project is not yet ready for formal projects.

hi, I read the discussion about why we can't export methods directly.
But I don't think this is an absolute reason not to do so. In fact, we can completely hide the process of converting C# methods to godot callables with source generators.
When the method marked by ExportToolButton is checked, a xxx_exportToolButtonField of type Callable is generated. This can completely avoid manual explicit callable conversion. This also maintains the consistency of gds and c# APIs and reduces the mental burden of understanding functions.


Xcode 15.2+xrOS

Hi, There is a new release candidate 4.8.2 of InjectionIII.app that now contains a xrOSInjection.bundle to solve this new issue with Xcode 15.2 https://github.com/johnno1962/InjectionIII/issues/477. Eventually people will need this code to inject with xrOS. Unfortunately, at the moment it gives a compilation warning.

🙇


"End of File" error with Alpaca model

Keep on getting this error
llama.cpp: loading model from ./models/ggml-model-q4_0.bin
error loading model: unexpectedly reached end of file
llama_init_from_file: failed to load model
Downloaded the model several times in case it was corrupted. Same result. Environment is Ubuntu in WSL2 (files downloaded in Windows and then copied into WSL environment).

Fixed using https://github.com/fabiomatricardi/GPT4All_Medium#update-and-bug-fixes-20230525


Do a pass over KIC 2.x documentation and find quality issues

Problem statement:
The documentation for KIC 2.0 needs a final pass to ensure that we haven't missed any significant quality problems.
We'll be reviewing the docs in this PR: https://github.com/Kong/docs.konghq.com/pull/3099. It will be merged at the moment of publishing KIC 2.0 GA.
Acceptance criteria:

[ ] go through all the examples and ensure that they all work
[ ] ensure that the guides are up to date
[ ] ensure that we don't have external links that should be replaced by internal
[ ] read through all of the documentation and identify areas where something is out of date or not accurate anymore with 2.0

https://github.com/Kong/docs.konghq.com/pull/3118 (mostly) removes outdated Ingress examples.
We need to regenerate the CLI arguments page. I forget if we have a tool to do this or it's done by hand, but the controller fields still use the old EnablementStatus style.

@shaneutt is to break this task up into chunks digestible by a single person.

This is now split up into separate issues:

https://github.com/Kong/kubernetes-ingress-controller/issues/1789
https://github.com/Kong/kubernetes-ingress-controller/issues/1790
https://github.com/Kong/kubernetes-ingress-controller/issues/1791
https://github.com/Kong/kubernetes-ingress-controller/issues/1792
https://github.com/Kong/kubernetes-ingress-controller/issues/1793
https://github.com/Kong/kubernetes-ingress-controller/issues/1794
https://github.com/Kong/kubernetes-ingress-controller/issues/1795
https://github.com/Kong/kubernetes-ingress-controller/issues/1796
https://github.com/Kong/kubernetes-ingress-controller/issues/1797
https://github.com/Kong/kubernetes-ingress-controller/issues/1798


Selecting and moving tokens with mouse not working after a while

(Foundry 0.8.9, hosted on The Forge)
Maybe 2-3 weeks ago, I started having a recurrent problem with foundry : after a while, I could not select multiple tokens with my mouse (the select rectangle stopped appearing) and I could not drag tokens with my mouse (whether multiple or single tokens were selcted). I could still select a single token with my mouse and multiple tokens by shift-clicking, and I could move single or multiple token with the arrow keys. Those two problems always appeared together at the same time, and a refresh solved them... before they inevitably came back after a while. I would have this problem pop up probably 5-10 times during a four-hours session.
Since the problem is not immediate and takes some time settling in, it's pretty hard to pinpoint the culprit. I tried deactivating a bunch of modules (all the ones that might not be compatible with my version of Foundry, 0.8.9), but it did not solve it. Yesterday, I played four hours with DF Droppables deactivated (but all other modules activated), and the problem happened only once during 4+ hours. I guess it's a least part of the problem.
Sorry for the boring details. I hope my explanation is not too confusing. Thanks!

This seems impossible to be related to droppables... The only time droppables does anything is if it detects a folder when you click and drag it onto the canvas. In all other cases, it does nothing at all. You're positive this isn't an issue with Foundry core or the Forge? Maybe try with all modules disabled.

It turns out it's probably not related to DF Droppables. I worked on my prep and the problem popped again a couple of times...
I already presented the problem on The Forge Discord and was told it has nothing to do with it. I'll ask for Foundry Core, but it does not look like that's the problem...
Thanks, and sorry for bothering you for nothing!

No problem, thanks for getting back to me about it!


add simple model reduction for uncertain models

in spirit of

#80

Codecov Report

Merging #81 (1c35656) into master (da2a0b4) will increase coverage by 0.18%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   89.89%   90.07%   +0.18%
==========================================
  Files          17       18       +1
  Lines        2563     2600      +37
==========================================
+ Hits         2304     2342      +38
+ Misses        259      258       -1

Impacted Files
Coverage Δ

src/hinfinity_design.jl
88.58% <ø> (ø)

src/reduction.jl
92.12% <0.00%> (-0.57%)
:arrow_down:

src/uncertainty_interface.jl
83.95% <0.00%> (+0.73%)
:arrow_up:

src/named_systems2.jl
89.78% <90.47%> (-0.15%)
:arrow_down:

src/mcm_nugap.jl
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add new document on canonical string encoding

Fixes #28

What do you think of this @brunocalza ? Should address the linked issue we discussed previously?


ReferenceError: requestAnimationFrame is not defined

Version
1.0.0-beta.20
Reproduction link
https://jsfiddle.net/50wL7mdz/734408/
Steps to reproduce
mocha/chai test a .vue file that contains requestAnimationFrame
default eslint config
ReferenceError: requestAnimationFrame is not defined
What is expected?
no this warning
What is actually happening?
ReferenceError: requestAnimationFrame is not defined
eslint config
{
  "name": "xxx",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "serve": "vue-cli-service serve",
    "build": "vue-cli-service build",
    "lint": "vue-cli-service lint",
    "test:unit": "vue-cli-service test:unit",
    "test:e2e": "vue-cli-service test:e2e"
  },
  "dependencies": {
    "@fortawesome/fontawesome-svg-core": "^1.2.4",
    "@fortawesome/free-solid-svg-icons": "^5.3.1",
    "@fortawesome/vue-fontawesome": "^0.1.1",
<EMAIL_ADDRESS>"^17.2.0",
    "axios": "^0.18.0",
    "echarts": "^4.2.0-rc.1",
    "element-ui": "^2.4.7",
    "normalize.css": "^8.0.0",
    "vue": "^2.5.17",
    "vue-router": "^3.0.1",
    "vuex": "^3.0.1"
  },
  "devDependencies": {
    "@vue/cli-plugin-babel": "^3.0.3",
    "@vue/cli-plugin-e2e-cypress": "^3.0.3",
    "@vue/cli-plugin-eslint": "^3.0.3",
    "@vue/cli-plugin-unit-mocha": "^3.0.3",
    "@vue/cli-service": "^3.0.3",
    "@vue/eslint-config-standard": "^3.0.3",
    "@vue/test-utils": "^1.0.0-beta.20",
    "chai": "^4.1.2",
    "node-sass": "^4.9.0",
    "sass-loader": "^7.0.1",
    "vue-template-compiler": "^2.5.17"
  },
  "eslintConfig": {
    "root": true,
    "env": {
      "node": true
    },
    "extends": [
      "plugin:vue/essential",
      "@vue/standard"
    ],
    "rules": {},
    "parserOptions": {
      "parser": "babel-eslint"
    }
  },
  "postcss": {
    "plugins": {
      "autoprefixer": {}
    }
  },
  "browserslist": [
    "> 1%",
    "last 2 versions",
    "not ie <= 8"
  ]
}

I have recently been experiencing a similar issue - I even got as far as creating a repro repo here but you beat me to the bug report.
In my case, I'm using typescript with mocha+chai in addition to vuetify (repo created with @vue/cli v3).
My instinct tells me that we're just missing a polyfill or a shim somewhere but despite my best efforts, I've not been able to reliably find a fix for this myself.

@bugsduggan I still don't know how to fix it.A lot of information has been searched, but no solution has been found :(

The issue is that jsdom-global doesn't add requestAnimationFrame to the global object.
The immediate fix is to add requestAnimationFrame to the global object before your tests run:
global.requestAnimationFrame = cb => cb()

To include requestAnimation with jsdom, you must pass in the pretendToBeVisible option.
const window = (new JSDOM(``, { pretendToBeVisual: true })).window;

I created a PR in vue-cli to get this added to the mocha unit plugin—https://github.com/vuejs/vue-cli/pull/2573

@eddyerburgh I still see this issue and I am making an assumption that the merge PR you linked to is now released.
Is there anything I need to do specifically to use the functionality you added in the PR? Anything I need to set in my configuration?
Quite possible I am seeing an issue with the same symptom but different cause, but wanted to double check.

Hi @JamesMcMahon, sorry that you're experiencing this issue.
Can you open an issue in the vue-cli repo. That's the repo where the fix was made to

Hi @eddyerburgh . I still see this issue when trying to run my tests.
I am using mocha/chai, "@vue/cli-plugin-unit-mocha": "^4.0.5", @vue/cli-service": "^4.0.5" and "@vue/test-utils": "1.0.0-beta.29".
I still don't know how to fix this issue. Can you help me to figure out the source of the problem, and a way to be able to fix it?

Just a note this could happen in ts projects too, and to resolve this problem you have to define the global function in runtime.
tests/setup.ts:
const requestAnimationFrame = (fn: Function) => fn();
globalThis.requestAnimationFrame = requestAnimationFrame;

And make sure that the setup.ts file is require before run the tests in npm script
package.json:
"test": "vue-cli-service test:unit --include ./tests/setup.ts --recursive ./__tests__/",

I'm using Mocha+Chai for my testing, and Vuetify for my component library.
To fix this issue I just added the following to the top of my component.spec.js file
global.requestAnimationFrame = function () {}
I was having this issue when I added a Vuetify v-text-field component in the template of my Vue file
I'm using versions (not sure all packages that relevant),
"devDependencies": {
    ...
    "@vue/cli-plugin-unit-mocha": "~4.2.0",
    "@vue/cli-service": "~4.2.0",
    "@vue/test-utils": "1.0.0-beta.31",
    "chai": "^4.1.2",
    "vue-cli-plugin-vuetify": "~2.0.5",
    "vue-template-compiler": "^2.6.11",
    "vuetify-loader": "^1.3.0"
    ...
}

Do want to say that I'm new to Vue and frontend testing so I don't have JSdom installed for my testing (mainly because I just heard of it and I assumed this was for while using JEST test runner)

the loop is event based, based on a particular wavelength or something, I think it's related to electricity pulses. otherwise you could have user input with a mouse which has x and y as input and when it moves it executes the code, but if you were to make a loop without input such as raf, it would have to go into stable diffusion


Cannot pair with esp8266

Hello,
where can do a change? I'm experiencing pairing problem on 8266, EspHapLed example
the line Connection: close received, client will be disconnected comes when right after I press "Continue" after entering the pairing code. I have tried on NodeMCU clones, ESP-12E/F
I'm currently using latest version of the library. is there any debug I can enable to provide more information?
thanks
....scandone
state: 0 -> 2 (b0)
.state: 2 -> 3 (0)
state: 3 -> 5 (10)
add 0
aid 4
cnt

connected with S2, channel 11
dhcp client start...
....ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
.
IP address:
<IP_ADDRESS>
Free heap: 34144
init_hap_storage>>> HomeKit: init_storage_ex size 0x1c1
>>> Home Integration: hap_services added chararacteristic  0: 23
>>> Home Integration: hap_services added chararacteristic  1: 25
>>> Home Integration: homekit_is_paired 0
>>> HomeKit: Update the CPU to run at 160MHz
>>> HomeKit: Free heap: 32376
>>> server_new: WiFiServer begin at port: 5556

>>> HomeKit: Starting server
>>> HomeKit: storage init 0
>>> HomeKit: Using existing accessory ID: 11:2A:28:A6:CE:A5
>>> HomeKit: find pairings
>>> HomeKit: Preinit pairing context
>>> crypto_srp_new: crypto_srp_new
>>> crypto_srp_new: Initializing SRP
>>> arduino_homekit_preinit: Free heap: 27744
>>> HomeKit: Using user-specified password: 111-11-111
>>> HomeKit: Free heap: 26032
>>> HomeKit: Calculating public key len=384
pm open,type:2 0
>>> HomeKit: Calculating public key result 0
>>> HomeKit: arduino_homekit_preinit success
>>> HomeKit: Configuring mDNS
>>> HomeKit: Wifi Sleep type:2
sleep disable
>>> HomeKit: Set Wifi Sleep type :0
>>> HomeKit: MDNS.begin: SHT-112A, IP: <IP_ADDRESS>
>>> homekit_mdns_init: Accessory Setup ID = YK72
>>> HomeKit: Init server over
>>> HomeKit: WiFiServer receives a new client (current 0, max 8)
>>> HomeKit: Got new client connection: local <IP_ADDRESS>:5556, remote <IP_ADDRESS>:55617
>>> HomeKit: [Client<PHONE_NUMBER>] Got client content from the cache 0
>>> HomeKit: [Client<PHONE_NUMBER>] new client accepted
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 126 bytes
>>> homekit_server_on_message_complete: http_parser message_complete
>>> homekit_server_on_pair_setup: Pair Setup
>>> homekit_server_on_pair_setup: Free heap: 23400
>>> tlv_debug: Got following TLV values:
>>> tlv_debug: Type 0 value (1 bytes): \x00
>>> tlv_debug: Type 6 value (1 bytes): \x01
>>> HomeKit: [Client<PHONE_NUMBER>] Pair Setup Step 1/3
>>> homekit_server_on_pair_setup: Free heap: 23328
>>> send_tlv_response: [Client<PHONE_NUMBER>] Sending TLV response
>>> tlv_debug: Got following TLV values:
>>> tlv_debug: Type 3 value (384 bytes): \xBE\xC6\xD5<\x16KR'1\xF4\x09.\x01\xF1\x8B/pl\xE4\x88[\x9F\x85\x80\x06\xE0\x18k\x92/\xE6h-\xCE|\xF2\xD1\x9F\xB2f\xB8\x9B{\xF9$\xDC\xA3>R\xA7\x9Efn\x14\x99_\x1F\x90\xB3\x13o\x05\x97\xEDxv\xE6Ew\xB4\x17\xAA|\xB8Z\xA3!\x0E\xE0y\x886\x95\xB3m\x00)\x96\xFB\x83tf\xCF\x8AQ\x8AJZ\x14\xFFU6U3\xDB\xC9\xA8\x0A\xDCN\x1F\x1B\x09>SY\xF2\x9D\xE1#J\x82c\x9EJ\xC3m4\xD3k\x92}tPa/\xC3z.\xF0r\xE3Ao2`\x187\xAB\xBD\xCE\xE6\xDC<\xF1xG\xFBr`\xAF6\xC5\xEE\xED\x90Q\x96x)wV\xC7\x92)\xEFm%\xAA\x90\xF8[\x9F\xD2:\xDD\xCC\xC6!\x80\xF5\x1B\xAC\x1F/}\xB6\x81\x0F\xAB'>\xC5\x9AH\x0BO\xE8\xCE)L\x92\xC4\x0B\xCC\xEFk\xA0\xFE:\xCC\xB0\x09R\x89\xF4\x8C\x84e[y<\xC3\x99\xA2\xBFM\xCE7XGO\xA3\x81\xB0\xAFx\xD6\xFB\xA2\x0F1n\xA6\xE5\x88\xCA\\%\xA25\xE9\x98\xE0b}\xA9\x13\xD7\x0E\xC6\xE7<0Y\xD3\xBF\x04.(\xD4\xD3\xB1U\x10\xEAm\xC8u\xCF\x92\x11:\xE2\xF2\xE0\xA5\x97\x15p\xBE\xB2\x95$\x85M\xB4\x980\x18P\x84"\x1C\xA6\x98\xE8,\xCB\x0FU\xCE\xC2};\xBBx>\x84k\xBDM\xD3j\x1C\xCB)s\x8Cr\x91\xFC\x80Yyq\xA0\x19\xC5%\x83[A\x12\x0Fr/\x9EOk\xB3\x19$}\xF6\xF7'\xD1X\xDD4\xDA7W-Ggq\x8C\x87\x06\xB1\xBC\x98
>>> tlv_debug: Type 2 value (16 bytes): e\xAD\xB0Kh\xF9\x98\x1C\x9B\x13\xE8_\xE9A\xE6\xB4
>>> tlv_debug: Type 6 value (1 bytes): \x02
>>> client_send: [Client<PHONE_NUMBER>] send data size=513, encrypted=false
>>> client_send: [Client<PHONE_NUMBER>] Sending payload: HTTP/1.1 200 OK\x0D\x0AContent-Type: application/pairing+tlv8\x0D\x0AContent-Length: 409\x0D\x0AConnection: keep-alive\x0D\x0A\x0D\x0A\x03\xFF\xBE\xC6\xD5<\x16KR'1\xF4\x09.\x01\xF1\x8B/pl\xE4\x88[\x9F\x85\x80\x06\xE0\x18k\x92/\xE6h-\xCE|\xF2\xD1\x9F\xB2f\xB8\x9B{\xF9$\xDC\xA3>R\xA7\x9Efn\x14\x99_\x1F\x90\xB3\x13o\x05\x97\xEDxv\xE6Ew\xB4\x17\xAA|\xB8Z\xA3!\x0E\xE0y\x886\x95\xB3m\x00)\x96\xFB\x83tf\xCF\x8AQ\x8AJZ\x14\xFFU6U3\xDB\xC9\xA8\x0A\xDCN\x1F\x1B\x09>SY\xF2\x9D\xE1#J\x82c\x9EJ\xC3m4\xD3k\x92}tPa/\xC3z.\xF0r\xE3Ao2`\x187\xAB\xBD\xCE\xE6\xDC<\xF1xG\xFBr`\xAF6\xC5\xEE\xED\x90Q\x96x)wV\xC7\x92)\xEFm%\xAA\x90\xF8[\x9F\xD2:\xDD\xCC\xC6!\x80\xF5\x1B\xAC\x1F/}\xB6\x81\x0F\xAB'>\xC5\x9AH\x0BO\xE8\xCE)L\x92\xC4\x0B\xCC\xEFk\xA0\xFE:\xCC\xB0\x09R\x89\xF4\x8C\x84e[y<\xC3\x99\xA2\xBFM\xCE7XGO\xA3\x81\xB0\xAFx\xD6\xFB\xA2\x0F1n\xA6\xE5\x03\x81\x88\xCA\\%\xA25\xE9\x98\xE0b}\xA9\x13\xD7\x0E\xC6\xE7<0Y\xD3\xBF\x04.(\xD4\xD3\xB1U\x10\xEAm\xC8u\xCF\x92\x11:\xE2\xF2\xE0\xA5\x97\x15p\xBE\xB2\x95$\x85M\xB4\x980\x18P\x84"\x1C\xA6\x98\xE8,\xCB\x0FU\xCE\xC2};\xBBx>\x84k\xBDM\xD3j\x1C\xCB)s\x8Cr\x91\xFC\x80Yyq\xA0\x19\xC5%\x83[A\x12\x0Fr/\x9EOk\xB3\x19$}\xF6\xF7'\xD1X\xDD4\xDA7W-Ggq\x8C\x87\x06\xB1\xBC\x98\x02\x10e\xAD\xB0Kh\xF9\x98\x1C\x9B\x13\xE8_\xE9A\xE6\xB4\x06\x01\x02
>>> homekit_server_on_pair_setup: [Client<PHONE_NUMBER>] Server on pair setup end
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 536 bytes
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 43 bytes
>>> HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected
>>> HomeKit: [Client<PHONE_NUMBER>] Closing client connection
>>> homekit_server_close_client: [Client<PHONE_NUMBER>] The sockect is stoped
>>> HomeKit: Free saved_preinit_pairing_context
>>> HomeKit: [Client 0] Clear the pairing context
>>> HomeKit: [Client 0] client content free
>>> HomeKit: Preinit pairing context
>>> crypto_srp_new: crypto_srp_new
>>> crypto_srp_new: Initializing SRP
>>> arduino_homekit_preinit: Free heap: 25400
>>> HomeKit: Using user-specified password: 111-11-111
>>> HomeKit: Free heap: 23688
>>> HomeKit: Calculating public key len=384
>>> HomeKit: Calculating public key result 0
>>> HomeKit: arduino_homekit_preinit success

Lets's try to update wolfssl , with latest version from archive, than let me know

you mean zip archive from ESPHap library? there are two zip files
or do you mean download newest from wolfssl github?

Yes zip archive
Sent from my iPhone

On 24 Mar 2021, at 11:19, mgx0 @.***> wrote:

you mean zip archive from ESPHap library? there are two zip files
or do you mean download newest from wolfssl github?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Use https://github.com/Yurik72/ESPHap/blob/master/wolfssl/wolfSSL_3_13_0.rar

nope, still doesn't pair, connection is closed as soon I confirm the code
scandone
state: 0 -> 2 (b0)
state: 2 -> 3 (0)
state: 3 -> 5 (10)
add 0
aid 7
cnt

connected with S2, channel 11
dhcp client start...
...ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
.
IP address:
<IP_ADDRESS>
Free heap: 34144
init_hap_storage>>> HomeKit: init_storage_ex size 0x1c1
>>> Home Integration: hap_services added chararacteristic  0: 23
>>> Home Integration: hap_services added chararacteristic  1: 25
>>> Home Integration: homekit_is_paired 0
>>> HomeKit: Update the CPU to run at 160MHz
>>> HomeKit: Free heap: 32376
>>> server_new: WiFiServer begin at port: 5556

>>> HomeKit: Starting server
>>> HomeKit: storage init 0
>>> HomeKit: Using existing accessory ID: 11:2A:28:A6:CE:A5
>>> HomeKit: find pairings
>>> HomeKit: Preinit pairing context
>>> crypto_srp_new: crypto_srp_new
>>> crypto_srp_new: Initializing SRP
>>> arduino_homekit_preinit: Free heap: 27744
>>> HomeKit: Using user-specified password: 111-11-111
>>> HomeKit: Free heap: 26032
>>> HomeKit: Calculating public key len=384
pm open,type:2 0
>>> HomeKit: Calculating public key result 0
>>> HomeKit: arduino_homekit_preinit success
>>> HomeKit: Configuring mDNS
>>> HomeKit: Wifi Sleep type:2
sleep disable
>>> HomeKit: Set Wifi Sleep type :0
>>> HomeKit: MDNS.begin: SHT-112A, IP: <IP_ADDRESS>
>>> homekit_mdns_init: Accessory Setup ID = YK72
>>> HomeKit: Init server over
>>> HomeKit: WiFiServer receives a new client (current 0, max 8)
>>> HomeKit: Got new client connection: local <IP_ADDRESS>:5556, remote <IP_ADDRESS>:56222
>>> HomeKit: [Client<PHONE_NUMBER>] Got client content from the cache 0
>>> HomeKit: [Client<PHONE_NUMBER>] new client accepted
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 126 bytes
>>> homekit_server_on_message_complete: http_parser message_complete
>>> homekit_server_on_pair_setup: Pair Setup
>>> homekit_server_on_pair_setup: Free heap: 23776
>>> tlv_debug: Got following TLV values:
>>> tlv_debug: Type 0 value (1 bytes): \x00
>>> tlv_debug: Type 6 value (1 bytes): \x01
>>> HomeKit: [Client<PHONE_NUMBER>] Pair Setup Step 1/3
>>> homekit_server_on_pair_setup: Free heap: 23704
>>> send_tlv_response: [Client<PHONE_NUMBER>] Sending TLV response
>>> tlv_debug: Got following TLV values:
>>> tlv_debug: Type 3 value (384 bytes): x\xF3\xB6\x1FPT6\xFA␡$\x89\xD3\x91\x95k\xCF\xED\xD3^N\x09` \xBD\x10\xB4\x0As\xAA|\xBB2r\xFD\x02\xCEtC\x9AK\x83\xB0\xCF\xE1\x91_\xB1\x06u_\xC7H\x0F\xFDo\x93R\x112\x01\x81`\xA8V\x0C\x8A_Y\x02v\x97V\xDB\x194o\xA8\xF0\xF3\x08\xB0\\\x9BV\xC0\xC2}\xE0\x8F\x1D\xE6\x84\xBB\xAF\xAB3e#\xDC\x8D&\xC4i<\xD1\x94|\xF8Z\xF62;\xE7`+\xD6\x1F\x01\xF6/+\x9B\xEB[\xDA\xAA\xB1~\xDFD(9\x01\xB6J\xA3\xB6m5A\xC1(\xD7\xE5\xEE\xF9\xBAc\xF2\x1D+\xFF\xD6\x98\xC5\xFE\x8A\xFD\xF5\x05\xB4\xDB[a\x0B\xD5\x86Z]\xD9\x9B\x10\xEB;\x88\x9FT\x95p\xC9\x92\x142\xD1\x85\xF1\xBF\x1BM'4\\e\xDEeJ\x01\x04%\xAC(\x16\x1F\xBC\xC00{\xAE\x00\x8C\xB8\x8B\x95\xC9\x17\x8A\x04Ykx\xEC(7\xC8\xB4Rz\xA8\xAE\xAE\xEA\xB8\xA7\xA7N\xB6&\xAA^[\xA3\xC6?\x17\xEAc_,\xA83\x0C\xC1\x95^q\xEB\xA6\x88\x0E\x8E'~\xE1\x8F\x9B\xFB~cx*#&\xF2\xDF\xD5tp\x05\xB9G\xBBj\xA3qq\xDB\xDA\x13\xFF\xAD\x06\x875\xD0\xD7P\xAB@o\x1F\x16M\xB2\x087\xDF\x90-\x1F}\x01\xF7\xB0\xEC\xEB\xC6lq\xA7\\\xA7=Fk\x0C\x09\x9Bs\x96\x93N\xA3\x09\xBB\xAD\xF8b\x95s\xD5\x18\xD80\\\xCE\xE1\xA5-}\xF6\xD5u\xA76\xEEmq=\xA8\xB7\x08&\xAA\xB4[\x037\xE0\x08\xA8 .\x14j\x99\xC7:]~@\xBA\x97R]
>>> tlv_debug: Type 2 value (16 bytes): \xB0kz\xFE=y2ET\x94\x85-\x18\x9DO\xE0
>>> tlv_debug: Type 6 value (1 bytes): \x02
>>> client_send: [Client<PHONE_NUMBER>] send data size=513, encrypted=false
>>> client_send: [Client<PHONE_NUMBER>] Sending payload: HTTP/1.1 200 OK\x0D\x0AContent-Type: application/pairing+tlv8\x0D\x0AContent-Length: 409\x0D\x0AConnection: keep-alive\x0D\x0A\x0D\x0A\x03\xFFx\xF3\xB6\x1FPT6\xFA␡$\x89\xD3\x91\x95k\xCF\xED\xD3^N\x09` \xBD\x10\xB4\x0As\xAA|\xBB2r\xFD\x02\xCEtC\x9AK\x83\xB0\xCF\xE1\x91_\xB1\x06u_\xC7H\x0F\xFDo\x93R\x112\x01\x81`\xA8V\x0C\x8A_Y\x02v\x97V\xDB\x194o\xA8\xF0\xF3\x08\xB0\\\x9BV\xC0\xC2}\xE0\x8F\x1D\xE6\x84\xBB\xAF\xAB3e#\xDC\x8D&\xC4i<\xD1\x94|\xF8Z\xF62;\xE7`+\xD6\x1F\x01\xF6/+\x9B\xEB[\xDA\xAA\xB1~\xDFD(9\x01\xB6J\xA3\xB6m5A\xC1(\xD7\xE5\xEE\xF9\xBAc\xF2\x1D+\xFF\xD6\x98\xC5\xFE\x8A\xFD\xF5\x05\xB4\xDB[a\x0B\xD5\x86Z]\xD9\x9B\x10\xEB;\x88\x9FT\x95p\xC9\x92\x142\xD1\x85\xF1\xBF\x1BM'4\\e\xDEeJ\x01\x04%\xAC(\x16\x1F\xBC\xC00{\xAE\x00\x8C\xB8\x8B\x95\xC9\x17\x8A\x04Ykx\xEC(7\xC8\xB4Rz\xA8\xAE\xAE\xEA\xB8\xA7\xA7N\xB6&\xAA^[\xA3\xC6?\x17\xEAc_,\xA83\x0C\xC1\x95^q\x03\x81\xEB\xA6\x88\x0E\x8E'~\xE1\x8F\x9B\xFB~cx*#&\xF2\xDF\xD5tp\x05\xB9G\xBBj\xA3qq\xDB\xDA\x13\xFF\xAD\x06\x875\xD0\xD7P\xAB@o\x1F\x16M\xB2\x087\xDF\x90-\x1F}\x01\xF7\xB0\xEC\xEB\xC6lq\xA7\\\xA7=Fk\x0C\x09\x9Bs\x96\x93N\xA3\x09\xBB\xAD\xF8b\x95s\xD5\x18\xD80\\\xCE\xE1\xA5-}\xF6\xD5u\xA76\xEEmq=\xA8\xB7\x08&\xAA\xB4[\x037\xE0\x08\xA8 .\x14j\x99\xC7:]~@\xBA\x97R]\x02\x10\xB0kz\xFE=y2ET\x94\x85-\x18\x9DO\xE0\x06\x01\x02
>>> homekit_server_on_pair_setup: [Client<PHONE_NUMBER>] Server on pair setup end
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 536 bytes
>>> homekit_client_process: [Client<PHONE_NUMBER>] Reading 43 bytes
>>> HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected
>>> HomeKit: [Client<PHONE_NUMBER>] Closing client connection
>>> homekit_server_close_client: [Client<PHONE_NUMBER>] The sockect is stoped
>>> HomeKit: Free saved_preinit_pairing_context
>>> HomeKit: [Client 0] Clear the pairing context
>>> HomeKit: [Client 0] client content free
>>> HomeKit: Preinit pairing context
>>> crypto_srp_new: crypto_srp_new
>>> crypto_srp_new: Initializing SRP
>>> arduino_homekit_preinit: Free heap: 25400
>>> HomeKit: Using user-specified password: 111-11-111
>>> HomeKit: Free heap: 23688
>>> HomeKit: Calculating public key len=384
>>> HomeKit: Calculating public key result 0
>>> HomeKit: arduino_homekit_preinit success

Yes I see a log will try to investigate, this is first time I’m met

HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected

Apple sends response with Connection:Close header. However it should continue to asking available accessories….
From: mgx0 @.>
Sent: Wednesday, March 24, 2021 2:33 PM
To: Yurik72/ESPHap @.>
Cc: Yurik72 @.>; Comment @.>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
nope, still doesn't pair, connection is closed as soon I confirm the code
scandone
state: 0 -> 2 (b0)
state: 2 -> 3 (0)
state: 3 -> 5 (10)
add 0
aid 7
cnt
connected with S2, channel 11
dhcp client start...
...ip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
.
IP address:
<IP_ADDRESS>
Free heap: 34144
init_hap_storage>>> HomeKit: init_storage_ex size 0x1c1

Home Integration: hap_services added chararacteristic  0: 23

Home Integration: hap_services added chararacteristic  1: 25

Home Integration: homekit_is_paired 0

HomeKit: Update the CPU to run at 160MHz

HomeKit: Free heap: 32376

server_new: WiFiServer begin at port: 5556

HomeKit: Starting server

HomeKit: storage init 0

HomeKit: Using existing accessory ID: 11:2A:28:A6:CE:A5

HomeKit: find pairings

HomeKit: Preinit pairing context

crypto_srp_new: crypto_srp_new

crypto_srp_new: Initializing SRP

arduino_homekit_preinit: Free heap: 27744

HomeKit: Using user-specified password: 111-11-111

HomeKit: Free heap: 26032

HomeKit: Calculating public key len=384

pm open,type:2 0

HomeKit: Calculating public key result 0

HomeKit: arduino_homekit_preinit success

HomeKit: Configuring mDNS

HomeKit: Wifi Sleep type:2

sleep disable

HomeKit: Set Wifi Sleep type :0

HomeKit: MDNS.begin: SHT-112A, IP: <IP_ADDRESS>

homekit_mdns_init: Accessory Setup ID = YK72

HomeKit: Init server over

HomeKit: WiFiServer receives a new client (current 0, max 8)

HomeKit: Got new client connection: local <IP_ADDRESS>:5556, remote <IP_ADDRESS>:56222

HomeKit: [Client<PHONE_NUMBER>] Got client content from the cache 0

HomeKit: [Client<PHONE_NUMBER>] new client accepted

homekit_client_process: [Client<PHONE_NUMBER>] Reading 126 bytes

homekit_server_on_message_complete: http_parser message_complete

homekit_server_on_pair_setup: Pair Setup

homekit_server_on_pair_setup: Free heap: 23776

tlv_debug: Got following TLV values:

tlv_debug: Type 0 value (1 bytes): \x00

tlv_debug: Type 6 value (1 bytes): \x01

HomeKit: [Client<PHONE_NUMBER>] Pair Setup Step 1/3

homekit_server_on_pair_setup: Free heap: 23704

send_tlv_response: [Client<PHONE_NUMBER>] Sending TLV response

tlv_debug: Got following TLV values:

tlv_debug: Type 3 value (384 bytes): x\xF3\xB6\x1FPT6\xFA␡$\x89\xD3\x91\x95k\xCF\xED\xD3^N\x09` @.***\x1F\x16M\xB2\x087\xDF\x90-\x1F}\x01\xF7\xB0\xEC\xEB\xC6lq\xA7\\xA7=Fk\x0C\x09\x9Bs\x96\x93N\xA3\x09\xBB\xAD\xF8b\x95s\xD5\x18\xD80\\xCE\xE1\xA5-}\xF6\xD5u\xA76\xEEmq=\xA8\xB7\x08&\xAA\xB4[\x037\xE0\x08\xA8 .\x14j\x99\xC7:]~@\xBA\x97R]

tlv_debug: Type 2 value (16 bytes): \xB0kz\xFE=y2ET\x94\x85-\x18\x9DO\xE0

tlv_debug: Type 6 value (1 bytes): \x02

client_send: [Client<PHONE_NUMBER>] send data size=513, encrypted=false

client_send: [Client<PHONE_NUMBER>] Sending payload: HTTP/1.1 200 OK\x0D\x0AContent-Type: application/pairing+tlv8\x0D\x0AContent-Length: 409\x0D\x0AConnection: keep-alive\x0D\x0A\x0D\x0A\x03\xFFx\xF3\xB6\x1FPT6\xFA␡$\x89\xD3\x91\x95k\xCF\xED\xD3^N\x09` @.***\x1F\x16M\xB2\x087\xDF\x90-\x1F}\x01\xF7\xB0\xEC\xEB\xC6lq\xA7\\xA7=Fk\x0C\x09\x9Bs\x96\x93N\xA3\x09\xBB\xAD\xF8b\x95s\xD5\x18\xD80\\xCE\xE1\xA5-}\xF6\xD5u\xA76\xEEmq=\xA8\xB7\x08&\xAA\xB4[\x037\xE0\x08\xA8 .\x14j\x99\xC7:]~@\xBA\x97R]\x02\x10\xB0kz\xFE=y2ET\x94\x85-\x18\x9DO\xE0\x06\x01\x02

homekit_server_on_pair_setup: [Client<PHONE_NUMBER>] Server on pair setup end

homekit_client_process: [Client<PHONE_NUMBER>] Reading 536 bytes

homekit_client_process: [Client<PHONE_NUMBER>] Reading 43 bytes

HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected

HomeKit: [Client<PHONE_NUMBER>] Closing client connection

homekit_server_close_client: [Client<PHONE_NUMBER>] The sockect is stoped

HomeKit: Free saved_preinit_pairing_context

HomeKit: [Client 0] Clear the pairing context

HomeKit: [Client 0] client content free

HomeKit: Preinit pairing context

crypto_srp_new: crypto_srp_new

crypto_srp_new: Initializing SRP

arduino_homekit_preinit: Free heap: 25400

HomeKit: Using user-specified password: 111-11-111

HomeKit: Free heap: 23688

HomeKit: Calculating public key len=384

HomeKit: Calculating public key result 0

HomeKit: arduino_homekit_preinit success

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805783201 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXLA7YRROQRL2OJZ7TDTFHLXVANCNFSM4ZWX5CNQ .  https://github.com/notifications/beacon/AKDREXP6N7MPNODNNJLUXDLTFHLXVA5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGADUNII.gif

Just wait a bit more, phone will try to connect again later. Sometimes it connects on the first attempt, sometimes on the second or third. Also, please make sure you have esp set to frequency 160 and have updated wolfssl

Frequency is set 160 by library.
Maybe yes try wait for the second attempts. Which IOS you are using
From: Viktr @.>
Sent: Wednesday, March 24, 2021 3:43 PM
To: Yurik72/ESPHap @.>
Cc: Yurik72 @.>; Comment @.>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
Just wait a bit more, phone will try to connect again later. Sometimes it connects on the first attempt, sometimes on the second or third. Also, please make sure you have esp set to frequency 160 and have updated wolfssl
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805832140 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXOTKSYCGQLQ32FKCLLTFHT55ANCNFSM4ZWX5CNQ .  https://github.com/notifications/beacon/AKDREXML2K2PD76QAFIUXEDTFHT55A5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEALTA.gif

14.4.1 but it was like this on okder versions too. I'll keep trying

On 24 Mar 2021, at 14:46, Yurik72 @.***> wrote:

Frequency is set 160 by library.
Maybe yes try wait for the second attempts. Which IOS you are using
From: Viktr @.>
Sent: Wednesday, March 24, 2021 3:43 PM
To: Yurik72/ESPHap @.>
Cc: Yurik72 @.>; Comment @.>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
Just wait a bit more, phone will try to connect again later. Sometimes it connects on the first attempt, sometimes on the second or third. Also, please make sure you have esp set to frequency 160 and have updated wolfssl
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805832140 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXOTKSYCGQLQ32FKCLLTFHT55ANCNFSM4ZWX5CNQ . https://github.com/notifications/beacon/AKDREXML2K2PD76QAFIUXEDTFHT55A5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEALTA.gif
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Ok, suggestion from Victor.
Restart HomeApp on phone
From: mgx0 @.>
Sent: Wednesday, March 24, 2021 3:48 PM
To: Yurik72/ESPHap @.>
Cc: Yurik72 @.>; Comment @.>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
14.4.1 but it was like this on okder versions too. I'll keep trying

On 24 Mar 2021, at 14:46, Yurik72 @.***<EMAIL_ADDRESS>> wrote:

Frequency is set 160 by library.
Maybe yes try wait for the second attempts. Which IOS you are using
From: Viktr @.***<EMAIL_ADDRESS>>
Sent: Wednesday, March 24, 2021 3:43 PM
To: Yurik72/ESPHap @.***<EMAIL_ADDRESS>>
Cc: Yurik72 @.***<EMAIL_ADDRESS>>; Comment @.***<EMAIL_ADDRESS>>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
Just wait a bit more, phone will try to connect again later. Sometimes it connects on the first attempt, sometimes on the second or third. Also, please make sure you have esp set to frequency 160 and have updated wolfssl
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805832140 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXOTKSYCGQLQ32FKCLLTFHT55ANCNFSM4ZWX5CNQ . https://github.com/notifications/beacon/AKDREXML2K2PD76QAFIUXEDTFHT55A5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEALTA.gif
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805836362 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXO5JOEMXONZBVLWEOLTFHURRANCNFSM4ZWX5CNQ .  https://github.com/notifications/beacon/AKDREXNPPSCGODAGHS4U7STTFHURRA5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEBMSQ.gif

I have first connect always failed like that. Then, there's a second one, which is about 90% successful. Sometimes 3rd or 4th, on 1% of attempts, I have to relaunch home.app and then it works.

and for ESP8266 I should use wolfSSL_3_13_0.rar which is included in the library, is that correct?

Yes wolfSSL_3_13_0.rar works for both ESP8266/ESP32
From: mgx0 @.>
Sent: Wednesday, March 24, 2021 4:03 PM
To: Yurik72/ESPHap @.>
Cc: Yurik72 @.>; Comment @.>
Subject: Re: [Yurik72/ESPHap] Cannot pair with esp8266 (#83)
and for ESP8266 I should use wolfSSL_3_13_0.rar which is included in the library, is that correct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Yurik72/ESPHap/issues/83#issuecomment-805848182 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDREXI2XKD6UQOY67KCEHDTFHWKRANCNFSM4ZWX5CNQ .  https://github.com/notifications/beacon/AKDREXNP3CXS6VGDEI5P233TFHWKRA5CNFSM4ZWX5CN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGAEEI5Q.gif

good, perfect. awesome job man. And Viktor thank you too 😁 this is the future!

Closed, since is not library problem

I'm encountering the same problem and I did whatever you've discussed about in this issue but it did not fixed.
I should try like a million times to pair one time! Help! :(

Hi , first of all, please be 100% sure , that you are using latest version, then attach logs,
Problem is solved 1 year ago, therefore I do not see any obstacles
Sent from my iPhone

On 5 Sep 2021, at 19:25, alisadeghy @.***> wrote:

I'm encountering the same problem and I did whatever you've discussed about in this issue but it did not fixed.
I should try like a million times to pair one time! Help! :(
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I'm pretty much sure about the libraries.
ESPHap: 1.1.0
ESP8266: 3.0.2
Log:
.......
IP address:
<IP_ADDRESS>
Free heap: 35424
init_hap_storage>>> HomeKit: init_storage_ex size 0x1c1

Home Integration: hap_services added chararacteristic  0: 23
Home Integration: hap_services added chararacteristic  1: 25
Home Integration: homekit_is_paired 0
HomeKit: Update the CPU to run at 160MHz
HomeKit: Free heap: 33680
HomeKit: Starting server
HomeKit: storage init 0
HomeKit: Using existing accessory ID: E8:FF:B5:39:9A:E4
HomeKit: find pairings
HomeKit: Preinit pairing context
HomeKit: Using user-specified password: 111-11-111
HomeKit: Free heap: 27336
HomeKit: Calculating public key len=384
HomeKit: Calculating public key result 0
HomeKit: arduino_homekit_preinit success
HomeKit: Configuring mDNS
HomeKit: Wifi Sleep type:2
HomeKit: Set Wifi Sleep type :0
HomeKit: MDNS.begin: ES-E8FF, IP: <IP_ADDRESS>
HomeKit: Init server over
HomeKit: WiFiServer receives a new client (current 0, max 8)
HomeKit: Got new client connection: local <IP_ADDRESS>:5556, remote <IP_ADDRESS>:53203
HomeKit: [Client<PHONE_NUMBER>] Got client content from the cache 0
HomeKit: [Client<PHONE_NUMBER>] new client accepted
HomeKit: [Client<PHONE_NUMBER>] Pair Setup Step 1/3
HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected
HomeKit: [Client<PHONE_NUMBER>] Closing client connection
HomeKit: Free saved_preinit_pairing_context
HomeKit: [Client 0] Clear the pairing context
HomeKit: [Client 0] client content free
HomeKit: Preinit pairing context
HomeKit: Using user-specified password: 111-11-111
HomeKit: Free heap: 25552
HomeKit: Calculating public key len=384
HomeKit: Calculating public key result 0
HomeKit: arduino_homekit_preinit success
HomeKit: WiFiServer receives a new client (current 0, max 8)
HomeKit: Got new client connection: local <IP_ADDRESS>:5556, remote <IP_ADDRESS>:53204
HomeKit: [Client<PHONE_NUMBER>] Got client content from the cache 0
HomeKit: [Client<PHONE_NUMBER>] new client accepted
HomeKit: [Client<PHONE_NUMBER>] Pair Setup Step 1/3
HomeKit: [Client<PHONE_NUMBER>] Connection: close received, client will be disconnected
HomeKit: [Client<PHONE_NUMBER>] Closing client connection
HomeKit: Free saved_preinit_pairing_context
HomeKit: [Client 0] Clear the pairing context
HomeKit: [Client 0] client content free
HomeKit: Preinit pairing context
HomeKit: Using user-specified password: 111-11-111
HomeKit: Free heap: 25064

and over and over again

I also updated the CPU to run at 160 MHz as well but no luck.

Hi you don’t, need to update CPU clock, it’s done automatically insight library, ok
Could you please copy latest version 1.1 from the master, without updating from arduino, since latest version  more then 6 month not any blame about pairing on esp8266,
So delete library manually from your library folder and copy directly from the master
Sent from my iPhone

On 5 Sep 2021, at 21:09, alisadeghy @.***> wrote:

I also updated the CPU to run at 160 MHz as well but no luck.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Copied from master, but still the same log.

Ok , looks like not version issue Apple closes connection after first step, could you send me your sketch
Sent from my iPhone

On 5 Sep 2021, at 22:30, alisadeghy @.***> wrote:

Copied from master, but still the same log.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I use sketches from library example, didn't change anything except SSID and password.
`/*
ESPHap example EspHapLed for ESP8266
This example for ESPHap shows how to control a LED
with Apple Home app. It implements accessory type "light bulb".
This example code is part of the public domain
*/
#include <Arduino.h>
#ifdef ESP32
#include <SPIFFS.h>
#endif
#include <ESP8266WiFi.h>
#include <ESP8266mDNS.h>
#include "coredecls.h"
const char* ssid     = "******";
const char password = "***********";
const int identity_led=2;
const int led_gpio = 4;
extern "C"{
#include "homeintegration.h"
}
#include "homekitintegrationcpp.h"
homekit_service_t* hapservice={0};
String pair_file_name="/pair.dat";
//esp8266::MDNSImplementation::MDNSResponder* MDNS1;
LOCAL os_timer_t callbacktimer;
void setup() {
disable_extra4k_at_link_time();
Serial.begin(115200);
delay(10);
// We start by connecting to a WiFi network

#ifdef ESP32
if (!SPIFFS.begin(true)) {
// Serial.print("SPIFFS Mount failed");
}
#endif
#ifdef ESP8266
if (!SPIFFS.begin()) {
Serial.print("SPIFFS Mount failed");
}
#endif
Serial.println(ssid);

#ifdef ESP8266
WiFi.mode(WIFI_STA);
WiFi.begin((char*)ssid, (char*)password);
#else
WiFi.begin(ssid, password);
#endif
while (WiFi.status() != WL_CONNECTED) {
delay(500);
Serial.print(".");
}
Serial.println("");
// Serial.println("WiFi connected");
Serial.println("IP address: ");
Serial.println(WiFi.localIP());
pinMode(led_gpio,OUTPUT);
///setup identity gpio
// hap_set_identity_gpio(identity_led);    //identity_led=2 will blink on identity
/// now will setup homekit device
//this is for custom storaage usage
// In given example we are using \pair.dat   file in our spiffs system
//see implementation below
Serial.print("Free heap: ");
Serial.println(system_get_free_heap_size());

init_hap_storage();

set_callback_storage_change(storage_changed);

/// We will use for this example only one accessory (possible to use a several on the same esp)
//Our accessory type is light bulb, Apple interface will proper show that
hap_setbase_accessorytype(homekit_accessory_category_lightbulb);

/// init base properties
hap_initbase_accessory_service("ES","Yurik72","0","EspHapLed","1.0");

//we will add only one light bulb service and keep pointer for nest using
hapservice= hap_add_lightbulb_service("Led",led_callback,(void*)&led_gpio);
//and finally init HAP
hap_init_homekit_server();

}
void loop() {
hap_homekit_loop();
//delay(2);
return;
}
void init_hap_storage(){
Serial.print("init_hap_storage");
File fsDAT=SPIFFS.open(pair_file_name, "r");
if(!fsDAT){
Serial.println("Failed to read pair.dat");
return;
}
int size=hap_get_storage_size_ex();
char* buf=new char[size];
memset(buf,0xff,size);
int readed=fsDAT.readBytes(buf,size);
// Serial.print("Readed bytes ->");
//  Serial.println(readed);
hap_init_storage_ex(buf,size);
fsDAT.close();
delete []buf;
}
void storage_changed(char * szstorage,int bufsize){
SPIFFS.remove(pair_file_name);
File fsDAT=SPIFFS.open(pair_file_name, "w+");
if(!fsDAT){
Serial.println("Failed to open pair.dat");
return;
}
fsDAT.write((uint8_t*)szstorage, bufsize);
fsDAT.close();
}
//can be used for any logic, it will automatically inform Apple about state changes
void set_led(bool val){
Serial.println("set_led");
digitalWrite(led_gpio, val?HIGH:LOW);
//we need notify apple about changes
if(hapservice){
Serial.println("notify hap");
//getting on/off characteristic
homekit_characteristic_t * ch= homekit_service_characteristic_by_type(hapservice, HOMEKIT_CHARACTERISTIC_ON);
if(ch){
Serial.println("found characteristic");
if(ch->value.bool_value!=val){  //wil notify only if different
ch->value.bool_value=val;
homekit_characteristic_notify(ch,ch->value);
}
}
}
}
void led_callback(homekit_characteristic_t *ch, homekit_value_t value, void *context) {
Serial.println("led_callback");
set_led(ch->value.bool_value);
}`

One question, does this whole thing need internet connection to access anything from any server, like Apple or something?

One question, does this whole thing need internet connection to access anything from any server, like Apple or something?

Sorry for my intrusion, but yes, sure, as hap works thru the apple servers, internet connection is definitely required. Or, what do you think, how could your accessory update its state in your home.app then?

I don't know, maybe in a local communication between accessory and Apple device! I'm not that much into these Home Kit BTW, so it might be the problem, cause I live in Iran and we are banned from so many things over the internet!

To be clear I could pair a couple of times with exact same ESP8266 and internet connection and everything but suddenly this "Connection Close" thing started to show up!

You don’t need internet connection for pairing, everything runs locally and not any communication to ‘Apple’ server , it just phone and esp building handshake….
Sent from my iPhone

On 5 Sep 2021, at 22:59, Viktr @.***> wrote:

One question, does this whole thing need internet connection to access anything from any server, like Apple or something?
Sorry for my intrusion, but yes, sure, as hap works thru the apple servers, internet connection is definitely required. Or, what do you think, how could your accessory update its state in your home.app then?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

Ok then it's not the issue 🤷🏻♂

Pairing itself not requires any internet connection, as well as normal communication  !!!l I think issue could be related to network environment , but exact answer we can find only sniffering (for instance using ware shark), communication broken exactly after 1 stage, means we need understand who is doing that,  if device replying yes or not.. any other logical validation are one the second an third stages
Sent from my iPhone

On 5 Sep 2021, at 23:07, alisadeghy @.***> wrote:

To be clear I could pair a couple of times with exact same ESP8266 and internet connection and everything but suddenly this "Connection Close" thing started to show up!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

See previous answer , maybe other things are changed , port blocking .. etc…
Sent from my iPhone

On 5 Sep 2021, at 23:16, alisadeghy @.***> wrote:
issue

I completely changed the network environment, made a hotspot via my laptop and connected ESP and phone to that, no luck.
Same thing happened.

Also started over on a fresh computer with fresh install of IDE and libraries, thought it might be a file corruption somewhere in other libraries or an interference, still doesn't work. I will get another ESP6288 and an ESP32, hopefully the problem will be solved. Thanks for the time and if any ring bells please let me know. 🙏🏻

Alright, I tried 3 more ESP8266s and they work just fine, I don't know what happened to this board but it won't work with this library anymore, although it works with another Homekit library and every other sketch!
Any tip to make it work? Like flashing with new firmware or something?


Problem with AJAX integration

Hi folks,
I realised that when trying to use this plugin on a tool that integrates pages with AJAX requests, the plugin can´t look out for ID's that are not still loaded on the page, and for that cause the steps that needs the elements loaded by AJAX requests are not counted for the tour.
Hope you guys can fix it, I think this plugin is very easy to use and configure, congrats for the good job!

We have an idea for solution,
it should be done till Wednesday.
Have a good day :-)
pon., 18 mar 2019 o 17:02 daniel-zanin<EMAIL_ADDRESS>napisał(a):

Hi folks,
I realised that when trying to use this plugin on a tool that integrates
pages with AJAX requests, the plugin can´t look out for ID's that are not
still loaded on the page, and for that cause the steps that needs the
elements loaded by AJAX requests are not counted for the tour.
Hope you guys can fix it, I think this plugin is very easy to use and
configure, congrats for the good job!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DKNotusIT/DKNotus-Tour/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/ARrQ0VHOyYrsGO6HPoX1mSLSg4nZ4DVVks5vX7iMgaJpZM4b6KRp
.

--
Jan DOLECZEK
<EMAIL_ADDRESS>mobile: 694 417 391
PROMYK
www.promyk.doleczek.pl http://www.doleczek.pl
Wielkie Przedmieście 27, 46-300 Olesno
NIP:<PHONE_NUMBER>, REGON: 160292240

Hi,
could you send me example of code that generates problem
as You have described before?
BR
wt., 19 mar 2019 o 00:25 Jan Doleczek<EMAIL_ADDRESS>napisał(a):

We have an idea for solution,
it should be done till Wednesday.
Have a good day :-)
pon., 18 mar 2019 o 17:02 daniel-zanin<EMAIL_ADDRESS>napisał(a):

Hi folks,
I realised that when trying to use this plugin on a tool that integrates
pages with AJAX requests, the plugin can´t look out for ID's that are not
still loaded on the page, and for that cause the steps that needs the
elements loaded by AJAX requests are not counted for the tour.
Hope you guys can fix it, I think this plugin is very easy to use and
configure, congrats for the good job!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DKNotusIT/DKNotus-Tour/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/ARrQ0VHOyYrsGO6HPoX1mSLSg4nZ4DVVks5vX7iMgaJpZM4b6KRp
.

--
Jan DOLECZEK
<EMAIL_ADDRESS>mobile: 694 417 391
PROMYK
www.promyk.doleczek.pl http://www.doleczek.pl
Wielkie Przedmieście 27, 46-300 Olesno
NIP:<PHONE_NUMBER>, REGON: 160292240

--
Jan DOLECZEK
<EMAIL_ADDRESS>mobile: 694 417 391
PROMYK
www.promyk.doleczek.pl http://www.doleczek.pl
Wielkie Przedmieście 27, 46-300 Olesno
NIP:<PHONE_NUMBER>, REGON: 160292240

Let´s say we have some step of the tour where we want some interaction with the user. Like wait him to click on a button, for example. Then the part of the script would be something like this:
{      element: $('#eventBtn3').add('#eventBtn4'),      content: 'or videos?',      onstep: function(currentStep) {             $('#btnNewTask').click(function(){                       $.get('<url_to_form_view>',                              function(form) {                                     $('#divToShowForm').empty();                                     $('#divToShowForm').html(form);                       });             });      } }
Right. If the user clicks on the button that executes the $.get() function, it will load the content into div but won't trigger next step. At the same time, if the user clicks on the next step button to continue tour without click the $.get() trigger button, the div content won't load, and the info of the step will show an empty div.

I was thinking quite a lot on your problem, and I don't see any easy
solution.
#1. First I thought what if all html elements are loaded right before tour,
then simple putting code in function should work:
Tour.run((function () {
return [
{...}
]
})())
#2. Then if tour description and elements are loaded with onstep event,
you could simplu run Tour.close() and then Tour.run() with new tour
description,
but it have separated numeration for steps :-(
#3. Other option is to create html elements for all tour steps, and then
only load
content of those elements, or detach those elements (detach keeps events
handlers)
and put them in right place after AJAX loads new content.
Sorry I cann't better help You.
śr., 20 mar 2019 o 15:32 daniel-zanin<EMAIL_ADDRESS>napisał(a):

Let´s say we have some step of the tour where we want some interaction
with the user. Like wait him to click on a button, for example. Then the
part of the script would be something like this:
{ element: $('#eventBtn3').add('#eventBtn4'), content: 'or videos?',
onstep: function(currentStep) { $('#btnNewTask').click(function(){
$.get('<url_to_form_view>', function(form) { $('#divToShowForm').empty();
$('#divToShowForm').html(form); }); }); } }
Right. If the user clicks on the button that executes the $.get()
function, it will load the content into div but won't trigger next step. At
the same time, if the user clicks on the next step button to continue tour
without click the $.get() trigger button, the div content won't load, and
the info of the step will show an empty div.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/DKNotusIT/DKNotus-Tour/issues/1#issuecomment-474856738,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARrQ0ZPa1BCTWoeNJ0GN9Y90SZMXlSfiks5vYkZvgaJpZM4b6KRp
.

--
Jan DOLECZEK
<EMAIL_ADDRESS>mobile: 694 417 391
PROMYK
www.promyk.doleczek.pl http://www.doleczek.pl
Wielkie Przedmieście 27, 46-300 Olesno
NIP:<PHONE_NUMBER>, REGON: 160292240


chore(chaos): Adds missing probe fields and minor fixes

Harness Developer Pull Request

Adds missing probe fields and minor fixes

What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

House Keeping
Some items to keep track of. Screenshots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-753

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


TSC Meeting 2021-12-01

Please add topics for the agenda as comments on this issue.
The standing agenda items are:

Review TSC issue backlog
Review TSC-tagged issues (toggle to "open" after checking for recently "closed" items)

@ampproject/tsc

Cancelling since there are no agenda topics.


Files named "netscape-cookier-exporter" instead of "netscape-cookies-exporter"

Hi, the files in the Roaming folder have a typo in them - "cookier" instead of "cookies". Just wanted to let everyone know! So if you want to get the script to run just type the following instead of what it says in the "usage" section:
netscape-cookier-exporter -u https://google.com -o cookies.txt

Thanks @mrnngbgs!
I've fixed the issue and released the new version to npm.


Gap doesn't work with flex on Safari

Hello.
After a heated discussion with @overlisted, I have realized that gap doesn't work with flex on Safari.
Safari:

Chromium:

Maybe we should put a warning in the contributing docs telling people to use grid instead of flex for better compatibility.

im pretty sure that the flexbugs postcss plugin can fix that

i will try solving this with flexbugs-fixes after i finish the new login page

@overlisted Is this fixed now?

It is fixed, but by replacing gap completely