Saving files with eslint code action is really slow

Type: Performance Issue
when I add eslint code action on saving, saving files becomes really slow
"editor.codeActionsOnSave": {
    "source.fixAll": true,
}

I ran the Bisect and found that the problem comes from eslint extension
here are my eslint configs
module.exports = {
  parser: '@typescript-eslint/parser',
  extends: [
    'plugin:react/recommended',
    'plugin:@typescript-eslint/recommended',
    'plugin:prettier/recommended',
    'plugin:import/errors',
    'plugin:import/warnings',
    'plugin:import/typescript',
    'plugin:storybook/recommended',
  ],
  plugins: ['simple-import-sort', 'react-hooks'],
  parserOptions: {
    ecmaVersion: 2018,
    sourceType: 'module',
    ecmaFeatures: {
      jsx: true,
    },
  },
  overrides: [
    {
      files: ['*.js', '*.jsx'],
      rules: {
        '@typescript-eslint/explicit-function-return-type': 0,
        '@typescript-eslint/explicit-member-accessibility': 0,
        '@typescript-eslint/no-var-requires': 0,
      },
    },
  ],
  rules: {
    'react/jsx-uses-react': 'off',
    'react/react-in-jsx-scope': 'off',
    'no-console': 2,
    'react/prop-types': 0,
    'simple-import-sort/imports': 'error',
    '@typescript-eslint/no-use-before-define': [2, { variables: false }],
    '@typescript-eslint/interface-name-prefix': 0,
    '@typescript-eslint/explicit-function-return-type': 0,
    '@typescript-eslint/explicit-module-boundary-types': 0,
    '@typescript-eslint/no-unused-vars': ['error', { ignoreRestSiblings: true }],
    'react-hooks/rules-of-hooks': 'error',
    'react-hooks/exhaustive-deps': 'warn',
    '@typescript-eslint/no-unnecessary-condition': ['error', { allowConstantLoopConditions: true }],
  },
  ignorePatterns: ['**/generated'],
  settings: {
    react: {
      version: 'detect',
    },
    'import/resolver': {
      node: {
        extensions: ['.ts', '.tsx', '.js', '.jsx'],
      },
    },
  },
};

Extension version: 2.2.6
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:16:30.254Z)
OS version: Darwin x64 22.1.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
4, 4, 4

Memory (System)
16.00GB (3.02GB free)

Process Argv
--crash-reporter-id 2a886961-8a82-4e90-b3e3-ee50e266bb8a

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
   17	   197	 71754	code main
    0	    82	 71757	   gpu-process
    0	    16	 71760	   utility-network-service
    0	   164	 71761	   window (player.rs — lp-bevy-tutorial)
    0	   508	 71762	   window (settings.json — BY-1933-add-drawer-component)
    0	   213	 71853	   extensionHost
    0	    16	 71992	     /Users/salamaashoush/.vscode/extensions/rust-lang.rust-analyzer-0.3.1248-darwin-x64/server/rust-analyzer
    0	    16	 72346	       /Users/salamaashoush/.rustup/toolchains/nightly-x86_64-apple-darwin/libexec/rust-analyzer-proc-macro-srv
    0	    33	 72489	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Users/salamaashoush/.vscode/extensions/streetsidesoftware.code-spell-checker-2.10.1/packages/_server/dist/main.js --node-ipc --clientProcessId=71853
    0	   246	 71855	   shared-process
    0	    49	 71856	     ptyHost
    0	     0	 72128	       /usr/local/bin/fish -l
    0	     0	 72153	       /usr/local/bin/fish -l
    0	    16	 71946	     fileWatcher
    0	    49	 77530	     fileWatcher
    0	     0	 77854	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	    82	 75421	   utility
    0	    82	 77527	   issue-reporter
    0	   573	 77528	   extensionHost
    0	   180	 77551	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node --max-old-space-size=3072 /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --serverMode partialSemantic --useInferredProjectPerProjectRoot --disableAutomaticTypingAcquisition --cancellationPipeName /var/folders/q7/z945j8vs7bq29s2zd6qbxdyh0000gn/T/vscode-typescript501/4c6703e1833fef8bf57c/tscancellation-b149849d0c5be99878a4.tmp* --globalPlugins typescript-styled-plugin,typescript-svelte-plugin,@vsintellicode/typescript-intellicode-plugin,ms-vsintellicode-typescript --pluginProbeLocations /Users/salamaashoush/.vscode/extensions/styled-components.vscode-styled-components-1.7.5,/Users/salamaashoush/.vscode/extensions/svelte.svelte-vscode-106.2.0,/Users/salamaashoush/.vscode/extensions/visualstudioexptteam.vscodeintellicode-1.2.28,/Users/salamaashoush/.vscode/extensions/visualstudioexptteam.vscodeintellicode-1.2.28 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc
    1	   541	 77552	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node --max-old-space-size=3072 /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js --useInferredProjectPerProjectRoot --enableTelemetry --cancellationPipeName /var/folders/q7/z945j8vs7bq29s2zd6qbxdyh0000gn/T/vscode-typescript501/4c6703e1833fef8bf57c/tscancellation-d7029d0136100a47dda5.tmp* --globalPlugins typescript-styled-plugin,typescript-svelte-plugin,@vsintellicode/typescript-intellicode-plugin,ms-vsintellicode-typescript --pluginProbeLocations /Users/salamaashoush/.vscode/extensions/styled-components.vscode-styled-components-1.7.5,/Users/salamaashoush/.vscode/extensions/svelte.svelte-vscode-106.2.0,/Users/salamaashoush/.vscode/extensions/visualstudioexptteam.vscodeintellicode-1.2.28,/Users/salamaashoush/.vscode/extensions/visualstudioexptteam.vscodeintellicode-1.2.28 --locale en --noGetErrOnBackgroundUpdate --validateDefaultNpmLocation --useNodeIpc
    0	    82	 77553	       /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typingsInstaller.js --globalTypingsCacheLocation /Users/salamaashoush/Library/Caches/typescript/4.8 --enableTelemetry --typesMapLocation /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typesMap.json --validateDefaultNpmLocation
    0	   115	 77588	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Users/salamaashoush/.vscode/extensions/streetsidesoftware.code-spell-checker-2.10.1/packages/_server/dist/main.js --node-ipc --clientProcessId=77528
    0	    98	 77788	     /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper.app/Contents/MacOS/Code Helper --ms-enable-electron-run-as-node /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=77528

Workspace Info
|  Window (settings.json — BY-1933-add-drawer-component)
|  Window (player.rs — lp-bevy-tutorial)
|    Folder (BY-1933-add-drawer-component): 4336 files
|      File types: tsx(1323) ts(1085) svg(294) js(145) ttf(104) log(75)
|                  json(70) woff(70) woff2(70) png(32)
|      Conf files: package.json(20) tsconfig.json(19) settings.json(2)
|                  dockerfile(1)
|    Folder (lp-bevy-tutorial): 5414 files
|      File types: o(939) json(551) timestamp(550) d(510) rmeta(456) rlib(240)
|                  bc(141) ll(19) rs(14) dylib(14)
|      Conf files:;

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes516:30244333
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
2144e591:30553903
pyindex848cf:30577861
nodejswelcome1:30587005
40g7c324:30573242

First of all, you're using the setting to auto-fix all (both linting and non-ESLint related) problems when saving a file. If you only want to auto-fix ESLint problems, try using:
"editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
}

Another optimization is to set "eslint.codeActionsOnSave.mode": "problems". The setting description says that it will "fix only reported problems that have non-overlapping textual edits. This option runs a lot faster.":
https://github.com/microsoft/vscode-eslint/blob/4b92c12af15d41f76417bde9571cb56f08ec3d0f/package.json#L406-L419
Alternatively, you can also try explicitly listing the linting rules that you want to auto-fix with "eslint.codeActionsOnSave.rules". The README has more information about how you can configure this setting.
https://github.com/microsoft/vscode-eslint/blob/4b92c12af15d41f76417bde9571cb56f08ec3d0f/package.json#L420-L433

I tried"eslint.codeActionsOnSave.mode": "problems" but still no luck, also I was already using  "source.fixAll.eslint": true

The slowdown is usually caused by specific Eslint rules and unfortunately there is in most of the times nothing the extension itself can do about it. The recommended way to address this is to:

enable debugging to see which rule is slow. You can do this by using the eslint.debug setting and inspect the output in the ESLint channel.
exclude the rule using the eslint.codeActionsOnSave.rules setting

If none of the rules is slow can you please provide us with a GitHub repository we can clone that demos the slowness.

I have the same problem
I guess it may be caused by a combination of:

a big .vue file, ~300 lines
heavy rules ( plugin:vue/vue3-recommended + @vue/eslint-config-standard-with-typescript or @vue/eslint-config-airbnb-with-typescript )
big typescript libraries in global (quasar)
slow processor (because discharged laptop battery)
causing long formatting times (~3000ms per pass)
with big amount of fixes, requiring 10 passes, causing 30 seconds for first fix
with another formatter on top of that, requiring more then one pass for every save   "editor.defaultFormatter": "Vue.volar",
   "_editor.codeActionsOnSave": ["source.formatDocument", "source.fixAll.eslint"],

 ESlint trace
[Trace - 19:39:51] Received notification 'textDocument/publishDiagnostics'.
[Trace - 19:39:51] Received notification 'eslint/status'.
[Trace - 19:40:19] Sending notification 'textDocument/didOpen'.
[Trace - 19:40:19] Received request 'workspace/configuration - (5)'.
[Trace - 19:40:19] Sending response 'workspace/configuration - (5)'. Processing request took 4ms
[Trace - 19:40:19] NODE_PATH value is: C:\Users\Dimava\AppData\Local\nvs\default\node_modules;C:\Users\Dimava\AppData\Local\nvs\default\node_modules
2022-10-21T16:40:20.176Z eslint:cli-engine Linting complete in: 19ms
[Trace - 19:40:20] Received notification 'textDocument/publishDiagnostics'.
[Trace - 19:40:20] Received notification 'eslint/status'.
[Trace - 19:52:27] Sending notification 'textDocument/didOpen'.
[Trace - 19:52:27] Received request 'workspace/configuration - (6)'.
[Trace - 19:52:27] Sending response 'workspace/configuration - (6)'. Processing request took 5ms
[Trace - 19:55:58] Sending request 'textDocument/codeAction - (14)'.
[Trace - 19:55:58] Received response 'textDocument/codeAction - (14)' in 14ms.
[Trace - 19:56:00] Sending notification 'textDocument/didChange'.
2022-10-21T16:56:00.556Z eslint:cli-engine Lint D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:00.556Z eslint:linter Linting code for D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue (pass 1)
2022-10-21T16:56:00.556Z eslint:linter Verify
2022-10-21T16:56:00.556Z eslint:linter With ConfigArray: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:00.556Z eslint:linter Apply the processor: 'vue/.vue'
2022-10-21T16:56:00.557Z eslint:linter A code block was found: '(unnamed)'
2022-10-21T16:56:00.558Z eslint:linter Parsing: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
[Trace - 19:56:02] Sending notification 'textDocument/didChange'.
2022-10-21T16:56:02.297Z eslint:linter Parsing successful: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:02.297Z eslint:linter Scope analysis: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:02.297Z eslint:linter Scope analysis successful: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
[Trace - 19:56:02] Sending request 'textDocument/codeAction - (15)'.
[Trace - 19:56:02] Sending notification '$/cancelRequest'.
[Trace - 19:56:02] Sending request 'textDocument/codeAction - (16)'.
2022-10-21T16:56:02.913Z eslint:linter Generating fixed text for D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue (pass 1)
2022-10-21T16:56:02.913Z eslint:source-code-fixer Applying fixes
2022-10-21T16:56:02.913Z eslint:source-code-fixer shouldFix parameter was false, not attempting fixes
2022-10-21T16:56:02.914Z eslint:cli-engine Linting complete in: 2393ms
[Trace - 19:56:02] Received notification 'textDocument/publishDiagnostics'.
[Trace - 19:56:02] Received notification 'eslint/status'.
[Trace - 19:56:02] Received response 'textDocument/codeAction - (15)' in 532ms.
2022-10-21T16:56:02.944Z eslint:cli-engine Lint D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:02.944Z eslint:linter Linting code for D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue (pass 1)
2022-10-21T16:56:02.944Z eslint:linter Verify
2022-10-21T16:56:02.944Z eslint:linter With ConfigArray: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:02.944Z eslint:linter Apply the processor: 'vue/.vue'
2022-10-21T16:56:02.944Z eslint:linter A code block was found: '(unnamed)'
2022-10-21T16:56:02.946Z eslint:linter Parsing: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
[Trace - 19:56:03] Sending notification '$/cancelRequest'.
[Trace - 19:56:03] Sending request 'textDocument/codeAction - (17)'.
[Trace - 19:56:03] Sending notification '$/cancelRequest'.
2022-10-21T16:56:04.734Z eslint:linter Parsing successful: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:04.734Z eslint:linter Scope analysis: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:04.734Z eslint:linter Scope analysis successful: D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue
2022-10-21T16:56:05.056Z eslint:linter Generating fixed text for D:\xyz\xyzvite\src\components\passport\xyzNewNode.vue (pass 1)
2022-10-21T16:56:05.056Z eslint:source-code-fixer Applying fixes
2022-10-21T16:56:05.056Z eslint:source-code-fixer shouldFix parameter was false, not attempting fixes
2022-10-21T16:56:05.056Z eslint:cli-engine Linting complete in: 2135ms
[Trace - 19:56:05] Received notification 'textDocument/publishDiagnostics'.
[Trace - 19:56:05] Received notification 'eslint/status'.
[Trace - 19:56:05] Received response 'textDocument/codeAction - (16)' in 2380ms.
[Trace - 19:56:05] Received response 'textDocument/codeAction - (17)' in 1876ms.
[Trace - 19:56:11] Sending request 'textDocument/codeAction - (18)'.
[Trace - 19:56:11] Received response 'textDocument/codeAction - (18)' in 1ms.
[Trace - 19:56:17] Sending notification 'textDocument/didSave'.
[Trace - 19:56:54] Sending request 'workspace/executeCommand - (19)'.
2022-10-21T16:56:54.643Z eslint:cli-engine Lint D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:54.643Z eslint:linter Linting code for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 1)
2022-10-21T16:56:54.644Z eslint:linter Verify
2022-10-21T16:56:54.644Z eslint:linter With ConfigArray: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:54.644Z eslint:linter Apply the processor: 'vue/.vue'
2022-10-21T16:56:54.644Z eslint:linter A code block was found: '(unnamed)'
2022-10-21T16:56:54.645Z eslint:linter Parsing: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
[Trace - 19:56:56] Sending request 'textDocument/codeAction - (20)'.
2022-10-21T16:56:57.254Z eslint:linter Parsing successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:57.254Z eslint:linter Scope analysis: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:57.254Z eslint:linter Scope analysis successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:57.794Z eslint:linter Generating fixed text for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 1)
2022-10-21T16:56:57.794Z eslint:source-code-fixer Applying fixes
2022-10-21T16:56:57.794Z eslint:source-code-fixer Found fixes to apply
2022-10-21T16:56:57.795Z eslint:linter Linting code for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 2)
2022-10-21T16:56:57.795Z eslint:linter Verify
2022-10-21T16:56:57.795Z eslint:linter With ConfigArray: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:56:57.796Z eslint:linter Apply the processor: 'vue/.vue'
2022-10-21T16:56:57.796Z eslint:linter A code block was found: '(unnamed)'
2022-10-21T16:56:57.796Z eslint:linter Parsing: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:00.229Z eslint:linter Parsing successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:00.229Z eslint:linter Scope analysis: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:00.229Z eslint:linter Scope analysis successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:00.626Z eslint:linter Generating fixed text for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 2)
2022-10-21T16:57:00.626Z eslint:source-code-fixer Applying fixes
2022-10-21T16:57:00.626Z eslint:source-code-fixer Found fixes to apply
2022-10-21T16:57:00.626Z eslint:linter Linting code for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 3)
2022-10-21T16:57:00.626Z eslint:linter Verify
2022-10-21T16:57:00.626Z eslint:linter With ConfigArray: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:00.626Z eslint:linter Apply the processor: 'vue/.vue'
2022-10-21T16:57:00.626Z eslint:linter A code block was found: '(unnamed)'
2022-10-21T16:57:00.627Z eslint:linter Parsing: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:03.190Z eslint:linter Parsing successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:03.190Z eslint:linter Scope analysis: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:03.190Z eslint:linter Scope analysis successful: D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue
2022-10-21T16:57:03.711Z eslint:linter Generating fixed text for D:\xyz\xyzvite\src\components\passport\consumer\xyzConsumer.vue (pass 3)
2022-10-21T16:57:03.711Z eslint:source-code-fixer Applying fixes
2022-10-21T16:57:03.711Z eslint:source-code-fixer No fixes to apply
2022-10-21T16:57:03.711Z eslint:cli-engine Linting complete in: 9084ms
[Trace - 19:57:03] Computing all fixes took: 9090 ms.
[Trace - 19:57:03] Computing minimal edits took: 6 ms.
[Trace - 19:57:03] Received request 'workspace/applyEdit - (7)'.
[Trace - 19:57:03] Received response 'textDocument/codeAction - (20)' in 7409ms.
[Trace - 19:57:03] Sending response 'workspace/applyEdit - (7)'. Processing request took 91ms
[Trace - 19:57:03] Sending notification 'textDocument/didChange'.
[Trace - 19:57:03] Received response 'workspace/executeCommand - (19)' in 9192ms.

tl;dr 3 passes in 9192ms

Honestly, being able to see ESlint badge in the bottom bar saying "linting (pass 4)" would be good enough solution to one half of a problem
It would easily solve the "why is ESLint does not work", by showing user that the linter is actually working, and that the problem is on the user's side (too many rules, slow rules, etc)

Adding such a status is actually a good idea. I capture it here: https://github.com/microsoft/vscode-eslint/issues/1542

Found out why it is slow in my case, we recently added @typescript-eslint/no-unnecessary-condition rule, and it required us to set parserOptions.project in my eslint configs, and when I remove those it works just fine

@salamaashoush I do agree that this doesn't sound like an issue with this extension, but do note that typescript-eslint has a disclaimer in their docs about performance being affected with type-aware linting, so I wouldn't suggest blaming them either (since they have the performance warning).

@MariaSolOs is right. There are two kinds of eslint problems flaged by typescript-eslint:

one that only require examining the current file. These are usually fast.
one that need a project configuration and always parse all files in the project (at least on initial use). These are usually slower and have performance problems when running code fix on save.

I will close the issue since there is little, I can do to fix this besides the rule customizations I already offer.

This maybe could use

some user-visible warnings "ESLint taking too long"
disabling non-autofix rules on non-last iteration
suggesting to profile ESLint rules

Also IMO the first suggestion the user should be able to find in this thread should be
Please run
$ TIMING=1 DEBUG=eslint:cli-engine yarn eslint src/components/NewNode.vue --fix
and disable that useless rule which is using 90% of the time

For the user feedback there is https://github.com/microsoft/vscode-eslint/issues/1542. I do have a writeup as well how to tackle it. We could reference it from the user feedback (https://github.com/microsoft/vscode-eslint/issues/1344)

I was having the same issue, and just solved it with configuring eslint.workingDirectories properly for my monorepo.
I have.eslintrc and .eslintignore at my root folder. And each workspace under packages/ folder has it's own .eslintrc and .eslintignore. So
  // specifying `eslint.workingDirectories` is required to make vscode-eslint work properly with yarn workspaces (monorepo)
  // From the docs: If executing ESLint in the terminal requires you to change the working directory in the terminal into a sub folder then it is usually necessary to tweak this setting
  // read more: https://github.com/microsoft/vscode-eslint/blob/24d2ac45b2fe1b8cc8639038b724ba48610da8e2/README.md?plain=1#L238
  "eslint.workingDirectories": [{ "pattern": "./packages/*/" }],

Try adding this line to your setttings.json
"typescript.tsdk": "./node_modules/typescript/lib"
This is assuming you are using a mac and you have node_modules in your root directory.


Setup pre-commit hook to lint the files before comitting

@JayaKrishnaNamburu Can I work on this?

Sure @Andras-Simon  👍


Jellystat shuts down during first setup

Describe the bug
When I start the jellystat container for the first time, it shuts down after a few seconds.
first_start.log
Starting the container a second time works until I setup a user & server during the initial setup. Now I get the following errors.
(The TypeError section then keeps looping indefinitely)
second_start.log
It's still possible to navigate the web interface afterwards.
Environment Details (please complete the following information):

OS: Debian 12 Kernel 6.1.0-13-amd64
Browser doesn't apply
Jellystat Version 1.0.9
Jellyfin Version 10.8.13

Hey @zehDonut , can you do me a favor and attempt to re-enter and save your jellyfin details under settings, once saved can you restart it and let me know if the error still persists?

Hi,
unfortunately that didn't fix the problem, the behavior is still the same after saving + restarting.

Hey @zehDonut , can you pull the latest image and test again

That seems to have fixed the TypeError messages.
I've discovered that I need to enable remote access in Jellyfin (even though both containers are in the same docker network). Now most things work, except the "Libraries" section, which is empty. (And by extension opening any library item, e.g. in recently added)
log1.log

can you retry running a full sync and let me know?

I was just about to edit my message, I did another restart and everything works now.
Thank you very much for your help!


Remove autorest version hardcoding in linter tools

Refer https://github.com/Azure/azure-rest-api-specs/pull/3400 for details

https://github.com/Azure/azure-rest-api-specs/pull/3400#pullrequestreview-136410298

PR is merged, close the issue.


Fix wrong iam_addictive variable input

iam_additive variable from Project module expects { "roles" = list(string) } input.
Therefore, I believe the issue #174 is till active

/gcbrun

failing test in environments is unrelated BTW

Emre, thanks for this! Can you rebase to master so the environments test is fixed, and add closing quotes in the README example, so the examples tests are happy?

moving to a separate branch to apply fixes and merge to master, thanks for this!

sorry for the late response @ludoo it was my birthday and I was not allowed to 'code' :). Thanks for the approving the changes. Have a great one!

No worries, and late happy birthday! :+1: on the no-code policy of course!


WIP: first take on SB-458

@cmoulliard @metacosm @geoand Still a WIP, but please let me know what you think. Thank you.

CC @liborfuka, could you please check? I don't feel very confident in the Spring Boot specifics.

Is there a way to check the rendered change in context? If yes, how?

@metacosm Please see the rendered version.
I have made some updates to the explanatory paragraphs and temporarily placed the section into the Spring Boot Dev guide.

@lthon @geoand Thank you for the feedback. I'll update the PR. Maybe removing the WIP was not such a good idea :P

This content has been moved to: http://snowdrop.me/guides/externalized-configuration
This PR will not be merged, closing.


v1.1.1 Release

1.1.1 January 07 2020
Renamed IWithTrace to to IWithTracing.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Aaronontheweb:x: dependabot-preview[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


SwAV: Runtime Error: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu

🐛 Bug
For the SwAV class, setting gpus=-1 in Trainer results in sinkhorn algorithm error due to one variable being on CPU and one on GPU, alongside other issues.
The class checks if self.gpus > 0 when it should really be checking that self.gpus != 0.
Runtime Error: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu
Code sample
import pytorch_lightning as pl
from pl_bolts.models.self_supervised import SwAV
from pl_bolts.datamodules import STL10DataModule
from pl_bolts.models.self_supervised.swav.transforms import (
    SwAVTrainDataTransform, SwAVEvalDataTransform
)
from pl_bolts.transforms.dataset_normalizations import stl10_normalization

# data
batch_size = 128
dm = STL10DataModule(data_dir='.', batch_size=batch_size)
dm.train_dataloader = dm.train_dataloader_mixed
dm.val_dataloader = dm.val_dataloader_mixed

dm.train_transforms = SwAVTrainDataTransform(
    normalize=stl10_normalization()
)

dm.val_transforms = SwAVEvalDataTransform(
    normalize=stl10_normalization()
)

# model
model = SwAV(
    gpus=-1,
    num_samples=dm.num_unlabeled_samples,
    dataset='stl10',
    batch_size=batch_size
)

# fit
trainer = pl.Trainer(precision=16)
trainer.fit(model)

Expected behavior
No error.
Environment

PyTorch Version (e.g., 1.0): 1.7.1
OS (e.g., Linux): Linux
How you installed PyTorch (conda, pip, source): pip
Build command you used (if compiling from source):
Python version: 3.7
CUDA/cuDNN version: 11/8.0.5
GPU models and configuration: 4xV100
Any other relevant information:

Dear @ananyahjha93,
Any reason he is passing gpus=-1 to the model ?
# model
model = SwAV(
   gpus=-1,
   num_samples=dm.num_unlabeled_samples,
   dataset='stl10',
   batch_size=batch_size
)

# fit
trainer = pl.Trainer(precision=16)

I don't think gpus=-1 is a valid argument for this setting.

@ananyahjha93 the documentation states that Trainer should be able to receive gpus=-1, so this should therefore be valid for the SwAV module (and any other module).

@JeffreyWardman we do need the exact number of GPUs for self-supervised learning models as we need to compute steps per training epoch for learning rate schedule. In that case the simplest solution is for the user to input the gpu count themselves and hence the -1 argument becomes invalid in this particular setting.

@ananyahjha93 The GPU count can be easily determined in the backend with a single line to maintain consistency across the library.


Dev mltest

The justification for this PR is to skip ml related tests on travis so the release build can progress. The tests pass locally. An issue will be filed if this pr is merged that reminds us to investigate the ml tests and the reason travis is hanging on them.

Coverage decreased (-4.8%) to 80.419% when pulling 4e67c0d21bcc97ee3dd6427eec2afb9a5d3882d0 on sjsrey:dev-mltest into c5fa9a4d2738d885054cb032e63ba3d1f2763a96 on pysal:dev.

Looks good and Travis likes it, so I think it's okay to merge.
So weird that the tests are hanging only on Travis...


Update READ.ME

Contributor name did not have correct format.

✅ By submitting this PR, I have verified the following

[x] Checked to see if a similar PR has already been opened 🤔
[x] Reviewed the contributing guidelines 🔍
[x] Added my name to the bottom of the list under the Contributors section in the README.md with a link to my personal website or GitHub profile 👥 (Optional)

Fixed!


updating style returns 422 error

example code
null_island = fp.upload_file(
    map_id = map_id,
    file_name = "null_island.geojson",
    layer_name = "Null Island"
)

ni_layer_id = null_island["layer_id"]

urrent_style = fp.get_layer_details(
    map_id=map_id,
    layer_id=ni_layer_id
)

new_style = current_style.copy()
new_style["color"] = "#FF0000"
new_style["size"] = 60
print("Style: ", new_style)

fp.update_layer_style(
    map_id=map_id,
    layer_id=ni_layer_id,
    style=new_style
)

Returns the following error:
Style:  {'id': 'uBcnG2XRRcG7M9Cc1ercJID', 'links': {'self': '/api/v2/maps/2jX0YV9AXTNeEhIU0Cfge0C/layers/uBcnG2XRRcG7M9Cc1ercJID'}, 'name': 'Null Island', 'status': 'processing', 'type': 'layer', 'progress': 0, 'style': {}, 'geometry_type': None, 'hide_from_legend': False, 'subtitle': '', 'ordering_key': 1, 'color': '#FF0000', 'size': 60}
Traceback (most recent call last):
  File "/Users/sophiaparafina/git/spara/felt/map.py", line 55, in <module>
    fp.update_layer_style(
  File "/Users/sophiaparafina/git/spara/felt/venv/lib/python3.11/site-packages/felt_python/layers.py", line 202, in update_layer_style
    response = make_request(
               ^^^^^^^^^^^^^
  File "/Users/sophiaparafina/git/spara/felt/venv/lib/python3.11/site-packages/felt_python/api.py", line 45, in make_request
    return urllib.request.urlopen(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 525, in open
    response = meth(req, response)
               ^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 634, in http_response
    response = self.parent.error(
               ^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 563, in error
    return self._call_chain(*args)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/urllib/request.py", line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 422: Unprocessable Entity

Hi @spara the expected input for "style" is a Felt Style Language document (see docs at https://developers.felt.com/felt-style-language/intro). It looks like you're passing in the entirety of the get_layer_details response. The existing style is in the style field returned from get_layer_details, although you'll notice it's empty {} since in your case the file hasn't finished uploading yet (so it hasn't been given a default style).
A good way to get the FSL you want to use is to style something the way you want it in Felt, then click "Actions / Edit Styles" in the overflow menu -- you'll see the FSL for that style, and you can use that as a template for your API usage.

Ah, I see where the confusion comes from. We have a bad example in our Readme which used a now-depreacted function (get_layer_style), which returned the FSL dictionary directly.
I've updated it to use get_layer_details()["style"] in this PR


DBZ-2897 Extended RecordCommitter interface to handle updated source offsets.

https://issues.redhat.com/browse/DBZ-2897
Extended the DebeziumEngine interface to include a new method for marking a record processed with updated source offsets. Implemented the new interface method in both ConvertingEngineBuilder and EmbeddedEngine. EmbeddedEngine creates a new SourceRecord with the updated sourceOffsets and passes this to the original markProcessed method. Added a unit test in EmbeddedEngineTest that verifies that the file offset storage contains the updated source offset’s partition. Added a revapi ignore case to prevent failure from a method added to an interface without a default method. Updated docs for Debezium Engine that describe the new functionality.

@gunnarmorling LGTM. The only question I have is whether the sources should be encapsulated into an another datatype effectivelly decoupling from the map but I am not really sure how this could be done.

Updated to use assertThat rather than java assert keyword.
Should I also add the Offsets contract in this pull request? If so, could you provide some more info on where you’d want it defined, and where it would be implemented (e.g., whether by the client or by EmbeddedEngine)? Would this follow a similar pattern to RecordChangeEvent and EmbeddedEngineChangeEvent? Any additional info would be helpful.

Should I also add the Offsets contract in this pull request?

Yes, please.

some more info on where you’d want it defined

I'd suggest an inner interface in DebeziumEngine, like RecordCommitter itself. The implementation would live next to where that one is implemented, too.

Added Offsets contract in DebeziumEngine and implemented it as SourceRecordOffsets in EmbeddedEngine. Added additional method buildOffsets in RecordCommitter for retrieving an Offsets object, implemented in ConvertingEngineBuilder and EmbeddedEngine. Modified markProcessed method to use Offsets contract. Updated tests and documentation.

Made the offsets interface non-static. Refactored the unit test for updating offsets to instead read the offset file as a map of byte array to byte array, parse the byte array as a json string, deserialize the json string, and make assertions on the key/values in the deserialized JSON object. Also minor refactors for some test constants to make assertions clearer.

LGTM, thx! That test failure is unrelated and already tracked. Merging.


Revert "astroid: require notmuch synchronize flags"

The Astroid program can work without this option,
which should be disabled when synchronising emails with muchsync for example.
This reverts commit fa3d1f98e001eab0e0514414a6429e082962915a.

Thanks! Rebased to master in 24dbac8da782aa26590b2f3eba153daaade105db.


bug: layout display incorrect

My machine:
macos arm64
rustc 1.72.1 (d5c2e9c34 2023-09-13)

Output:
cargo run
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.00s
     Running `target/debug/verso`
UNSUPPORTED (log once): POSSIBLE ISSUE: unit 1 GLD_TEXTURE_INDEX_2D is unloadable and bound to sampler type (Float) - using zero texture because texture unloadable
navigate to url: google.com
[2024-08-14T11:06:11Z ERROR script::dom::bindings::error] Error at https://www.google.com/:88:617 a.ea.scrollIntoView is not a function
[2024-08-14T11:06:12Z ERROR script::dom::bindings::error] Error at https://www.google.com/:29:448 int64

this is expected because Servo doesn't have full flexbox support yet. The layout will be out of place for a while.

because Servo doesn't have full flexbox support yet. -- @wusyong (https://github.com/versotile-org/verso/issues/151#issuecomment-2290434629)

Can you reference the relevant issue in servo? i am trying to figure out if i can stabilize verso for our use in nixium

@Kreyren I'm guessing that's it https://github.com/servo/servo/issues/26639

Can you reference the relevant issue in servo? i am trying to figure out if i can stabilize verso for our use in nixium

I appreciate the huge interest in this project. However, it is in its very beginning and only has one active developer at the moment.
I expected it's going to take a few years for us to publish stable release.


android billing with AIDL deprecated

The android implementation is based on Google Play Billing with AIDL. This is now deprecated. Google states (developer.android.com/google/play/billing/api):

Warning: AIDL is now deprecated and will be removed in a future release. To implement Google Play Billing features, use the Google Play Billing library

Please update to use the official Google Play Billing Library Client (com.android.billingclient:billing:2.0.0)
developer.android.com/google/play/billing/billing_library_overview.
Unfortunately Xamarin does not seem to provide a nuget wrapper for this official java library at this time.

Duplicate: https://github.com/jamesmontemagno/InAppBillingPlugin/issues/221

@jamesmontemagno I don't believe this has been addressed yet. I pulled the android-billing-client branch and it looks like we are still using AIDL. Can we reopen this issue so that it can be addressed? I believe BillingClient is currently covered by Xamarin.Android.Google.BillingClient nuget package:
https://www.nuget.org/packages/Xamarin.Android.Google.BillingClient/
Thanks for all your efforts!

@jamesmontemagno I don't believe this has been addressed yet. I pulled the android-billing-client branch and it looks like we are still using AIDL. Can we reopen this issue so that it can be addressed? I believe BillingClient is currently covered by Xamarin.Android.Google.BillingClient nuget package:
https://www.nuget.org/packages/Xamarin.Android.Google.BillingClient/
Thanks for all your efforts!


能否自定义axis样式

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?
自定义axis样式，能同时设置tickLine和非tickLine的样式，目前也没有设置axis radius的配置
What does the proposed API look like?
可以用户自定义配置axis样式

类似这样的样式

目前不支持


Double-quote table names

2015-05-07 16:16:32 UTC [7424] LOG:  statement: DROP TRIGGER IF EXISTS postgres_channel_Avatars ON Avatars
2015-05-07 16:16:32 UTC [7424] LOG:  statement: DROP FUNCTION IF EXISTS postgres_channel_Avatars()
2015-05-07 16:16:32 UTC [7424] ERROR:  cannot drop function postgres_channel_avatars() because other objects depend on it
2015-05-07 16:16:32 UTC [7424] DETAIL:  trigger postgres_channel_Avatars on table "Avatars" depends on function postgres_channel_avatars()

Some weirdos like me just name their tables in CamelCase :)

Good catch, I think I have added double quotes to all the places they were missing but the test suite does not support double quotes so I am not 100% sure that it is fixed.
I have released version 0.0.10 of this package and 0.0.4 of the numtel:pg Meteor package. Please let me know with if this new version fixes the problem.

It works, thanks!


Rights to icons?

I have a neovim plugin you have starred.
https://github.com/IogaMaster/neocord
I would like to ask for formal permission to use the icons from this project in mine.
I already use them, but I forgot to ask explicitly.
What do you think @leonardssh

be my guest. 💯

Thank you!


DevHome Hyper-V Create:  DevHome got in a weird state after premature exit

Dev Home version
No response
Windows build number
No response
Other software
No response
Steps to reproduce the bug
I was creating an hyper v image in DevHome and then exited.
This exit probably caused the creation to close.
I reran DevHome to create an image again, and no longer could create an image.
It appears the wrong button was loaded.  The button was a disabled "setup up" whne it should have been an enabled "create environment"
Expected result

Actual result

Included System Information
No response
Included Extensions Information
No response

Not able to repro. Reaching out to Kevin to get more information


When using SceneLoader.LoadAssetContainerAsync does not correctly load GLTFs with PBR Transmission

Repro

Bug repro on playground:
Expected result: Same as here https://playground.babylonjs.com/#WGZLGJ#2848
Current result: Glass spheres appear opaque.

Screenshots
Current result:

Expected result:

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version Version 89.0.4389.128 (Official Build) (64-bit)

Additional context
https://forum.babylonjs.com/t/transmissive-materials-sometimes-using-env-map-instead-of-actual-translucency/20203/3

The conclusion we made in the forum is not exactly right. Transmission helper should work correctly in this case. I'm not totally sure what happened, but this bug no longer repros. My guess is that one of the transmission helper fixes from @Popov72 fixed this one also.


React packager hangs on transforming (100% 393/394) on demo app (Android).

Trying to run Android tutorial with Genymotion emulator.
OS X Yosemite
Genymotion
react-native run-android succeeds. Following along tutorial, successfully launches app in emulator until I get to this step:
var {
  AppRegistry,
  Image,
  StyleSheet,
  Text,
  View,
} = React;

App launches with red screen of death ("Unable to download JS bundle. Did you forget to start the development device..."). Noticing the following in react packager logs:
React packager ready.

[1:31:52 PM] <END>   Crawling File System (1102ms)
[1:31:52 PM] <START> Building in-memory fs for JavaScript
[1:31:54 PM] <END>   Building in-memory fs for JavaScript (2263ms)
[1:31:54 PM] <START> Building in-memory fs for Assets
[1:31:56 PM] <END>   Building in-memory fs for Assets (2149ms)
[1:31:56 PM] <START> Building Haste Map
[1:31:58 PM] <START> Building (deprecated) Asset Map
[1:31:59 PM] <END>   Building (deprecated) Asset Map (742ms)
[1:31:59 PM] <END>   Building Haste Map (2676ms)
[1:31:59 PM] <END>   Building Dependency Graph (8194ms)
[1:32:09 PM] <START> request:/index.android.bundle?platform=android&dev=true
[1:32:09 PM] <START> find dependencies
[1:32:09 PM] <END>   find dependencies (182ms)
[1:32:09 PM] <START> transform
transforming [========================================] 100% 393/394[1:32:44 PM] <START> request:/index.android.bundle?platform=android&dev=true

Note - hung on 393/394.
Sorry if I'm adding to noise and this issue is covered elsewhere. Seeing similar tickets that have been closed, but the adb reverse tcp:8081 tcp:8081 command isn't working for me (I believe that would only apply to actual hardware deploys anyway?)
Thanks in advance.

@patscan Maybe its related to #5040?

@christopherdro Thanks for the reply. I am on 18.0-rc though, so I would think it should be resolved were it the same issue. Is there more logging I provide? I am not seeing the error from the second screenshot of the https://github.com/facebook/react-native/issues/5040 that explicitly points to babel, but perhaps I'm not knowing where to look.

I'm not sure tbh. It's just a similar one I saw earlier.
If your using redux, see #4674.

Thanks, I had come across both of these threads before posting, but I'm afraid neither seems to quite address this. I may post on stack overflow and see if others are seeing this behavior.

I also have this problem.

+1 18.0-rc.

@patscan if you go to "http://localhost:8081/index.ios.bundle?platform=android&dev=true" in your browser...does it spit out JS? Or an error?

@skevy, here's the output:
{
message: "TransformError: /Users/patscanlan/repos/AwesomeProject/index.android.js: Cannot read property 'error' of null",
type: "TransformError",
errors: [
{ }
]
}

+1, I have the same problem

@patscan Hi, I find it's the same issue as #5191 , it's the new bug of 0.18.0-rc

Closing this in favor of 5191 - please track there.


增加类似untiy的剔除遮罩功能，以便灯光只对指定layer的物体产生作用（Implement Culling Mask Functionality for Lights to Affect Only Specified Objects）

您的功能请求是否与问题有关？请描述。
请清晰、简洁地描述问题所在。例如，我总是在 [...] 时感到困扰。
问题描述：
在当前的系统中，灯光效果会影响所有的物体，没有办法指定只对某些物体产生作用。这会影响到我对场景的控制，尤其是在某些物品的属性比较特殊的情况下，我希望能打几盏灯只对这些特殊的物体产生作用。
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Problem Description:
In the current system, light effects affect all objects and there's no way to specify that they should only affect certain objects. This affects my control over the scene, especially when certain items have special attributes, and I would like to be able to set up a few lights that only affect these special items.

您希望有什么样的解决方案？
请清晰、简洁地描述您希望发生的事情。
解决方案：
我想要实现类似Unity中的剔除遮罩功能。这样可以使得创建的灯光只针对指定的layer产生作用，而排除掉对其他对象的影响。
Describe the solution you'd like
A clear and concise description of what you want to happen.
Solution:
I would like to implement a culling mask feature similar to Unity. This would allow the lights that are created to only affect a specified layer, excluding the impact on other objects.

您考虑过哪些替代方案？
请清晰、简洁地描述您考虑过的任何替代解决方案或功能。
替代方案：
我尝试过通过调整灯光的强度和范围来实现这个效果，但这并不能精确地控制灯光的影响对象。
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Alternatives:
I've tried to achieve this effect by adjusting the intensity and range of the lights, but this does not accurately control the objects affected by the light.

其他背景信息
关于功能请求的其他背景信息或截图在这里添加。
其他信息：
在特定的游戏场景中，这个功能会非常有用，能够提升游戏的视觉效果和玩家的游戏体验。
Additional context
Add any other context or screenshots about the feature request here.
Additional Context:
This feature would be very useful in specific game scenarios, enhancing the visual effects of the game and the gaming experience of the players.

Try this:


2.7.3

@rultor release tag is 2.7.3

@rultor release tag is 2.7.3

@portlek OK, I will release it now. Please check the progress here

@rultor release tag is 2.7.3

@portlek Done! FYI, the full log is here (took me 9min)


VS2015 Preview: TypeScript keeps inserting 4-space tab

Tab option:

TypeScript behavior:

@vladima I'm tried attach with WinDbg and VS Debugger to another process where opening TS project (and just file). But debugger not break on line where throwing error. What's I do wrong?
And this issue reproduced on any my machines. Work, home, friends. It's karma :(

ok, lets try a different way to save settings
        LanguageServiceShimObject.prototype.getFormattingEditsAfterKeystroke = function (fileName, position, key, options) {
            var _this = this;
            return this.forwardJSONCall("getFormattingEditsAfterKeystroke('" + fileName + "', " + position + ", '" + key + "')", function () {
                var fso = new ActiveXObject("Scripting.FileSystemObject")
                var f = fso.CreateTextFile("<some-path-where-you-want-to-save-file>\\options.json", true);
                f.WriteLine(options);
                f.Close();
                var localOptions = JSON.parse(options);
                var edits = _this.languageService.getFormattingEditsAfterKeystroke(fileName, position, key, localOptions);
                return edits;
            });
        };

do this then paste the content of result json file here and check if content of json file matches your expectations with respect to setting values

Result:
{
  "InsertSpaceAfterCommaDelimiter": true,
  "InsertSpaceAfterSemicolonInForStatements": true,
  "InsertSpaceBeforeAndAfterBinaryOperators": true,
  "InsertSpaceAfterKeywordsInControlFlowStatements": true,
  "InsertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
  "InsertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
  "PlaceOpenBraceOnNewLineForFunctions": false,
  "PlaceOpenBraceOnNewLineForControlBlocks": false,
  "IndentSize": 4,
  "TabSize": 4,
  "NewLineCharacter": "\r\n",
  "ConvertTabsToSpaces": true
}

For parameters IndentSize and TabSize in the VS settings is set to 2

out of curiosity, does custom indent size work for C# or it also always uses default indentation?

It works perfectly on C#.
My results on TS:
{
    "InsertSpaceAfterCommaDelimiter": true,
    "InsertSpaceAfterSemicolonInForStatements": true,
    "InsertSpaceBeforeAndAfterBinaryOperators": true,
    "InsertSpaceAfterKeywordsInControlFlowStatements": true,
    "InsertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
    "InsertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": false,
    "PlaceOpenBraceOnNewLineForFunctions": false,
    "PlaceOpenBraceOnNewLineForControlBlocks": false,
    "IndentSize": 4,
    "TabSize": 4,
    "NewLineCharacter": "\r\n",
    "ConvertTabsToSpaces": true
}

@vladima C# code have new settings

ok, problem is on the managed side, let's make one step forward. Can you go to %LOCALAPPDATA%\Microsoft\VisualStudio\14.0\, just in case backup folder ComponentModelCache, delete it, restart the VS and open some '.ts' file. Absence of ComponentModelCache will trigger recomputation of the VS component graph and if there are any error during recomposition they will be logged in '.err' file in ComponentModelCache folder. If there will be '.err' in the ComponentModelCache - please paste its content here.

I have Microsoft.VisualStudio.Default.err file, which contains:
----- CompositionError level 1 ------
Microsoft.VisualStudio.CodeSense.Providers.TestedBy.MethodReferenceInfoServerService.ctor(findReferencesService): expected exactly 1 export of Microsoft.VisualStudio.Alm.Roslyn.Server.Features.FindReferences.IFindReferencesService but found 0.
   part definition Microsoft.VisualStudio.CodeSense.Providers.TestedBy.MethodReferenceInfoServerService

Microsoft.VisualStudio.CodeSense.Providers.TestedBy.MethodReferenceInfoServerService.ctor(workspace): expected exactly 1 export of Microsoft.CodeAnalysis.Workspace but found 0.
   part definition Microsoft.VisualStudio.CodeSense.Providers.TestedBy.MethodReferenceInfoServerService

Microsoft.VisualStudio.CodeSense.Providers.References.ReferenceLocationInfoServerService.ctor(findReferencesService): expected exactly 1 export of Microsoft.VisualStudio.Alm.Roslyn.Server.Features.FindReferences.IFindReferencesService but found 0.
   part definition Microsoft.VisualStudio.CodeSense.Providers.References.ReferenceLocationInfoServerService

Microsoft.VisualStudio.CodeSense.Providers.References.ReferenceLocationInfoServerService.ctor(workspace): expected exactly 1 export of Microsoft.CodeAnalysis.Workspace but found 0.
   part definition Microsoft.VisualStudio.CodeSense.Providers.References.ReferenceLocationInfoServerService

Roslyn.VisualStudio.TypeScript.LanguageService.ProjectCommands.project: expected exactly 1 export of Microsoft.VisualStudio.Shell.Interop.IVsProject but found 2.
    Microsoft.VisualStudio.Project.VisualC.VCProjectEngine.VCUnconfiguredProjectMefIntegration.VsProject
    Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectNode
   part definition Roslyn.VisualStudio.TypeScript.LanguageService.ProjectCommands

Microsoft.VisualStudio.CodeSense.Providers.TestStatus.MethodLocationInfoServerService.ctor(workspace): expected exactly 1 export of Microsoft.CodeAnalysis.Workspace but found 0.
   part definition Microsoft.VisualStudio.CodeSense.Providers.TestStatus.MethodLocationInfoServerService

Microsoft.VisualStudio.SharePoint.ShellService.ServiceProvider: expected exactly 1 export of System.IServiceProvider but found 0.
   part definition Microsoft.VisualStudio.SharePoint.ShellService

Can you try to toggle checkbox 'Navigation bar' (Tools -> Options -> Text Editor\TypeScript\General) to verify if navbar will become visible\hidden?

@vladima I'm tried toggle checkbox "Navigation bar" and not affected on Navigation bar in text editor

Can you try TypeScript .1.4 to see whether you can still reproduce this issue?

Now it works on CTP5.

@SaschaNaz Great to know!
@flaticols can you give a CTP5 a try and check if it fixes your problem.

@vladima sorry for the wait :( Yup, now works great. Thanks!

Great to know!


Degraded performance when creating new VMs

The problem is that if you create a VM, run a load on it (for example, a performance test), wait for the performance test to complete, recording the results. Delete the created VM. Repeat all the same again, and for example, by the 4th iteration, we can get a performance degradation of up to 70%, with the same test, in comparison with the first created VM.
This behavior has been seen on GCP. I have not tested it on other platforms.

Please elaborate, what is "performance degradation" in your case? Performance of Eden side (test or perhaps building time) or performance of EVE on gcp (which may be affected by unpredictable things inside their hypervisor)?

Please elaborate, what is "performance degradation" in your case? Performance of Eden side (test or perhaps building time) or performance of EVE on gcp (which may be affected by unpredictable things inside their hypervisor)?

Degradation of I/O performance (in my case, as part of an io_performance test). The observation was done at GCP

Degradation of I/O performance (in my case, as part of an io_performance test). The observation was done at GCP

Two suggestion @vk-en

try to see if you can reproduce it on bare metal EVE deployment (non-GCP)
lets try to figure out why this may be the case to begin with

Two suggestion @vk-en

try to see if you can reproduce it on bare metal EVE deployment (non-GCP)
lets try to figure out why this may be the case to begin with

On hardware:
first run: https://openbenchmarking.org/result/2102011-HA-TESTEVEFI46
second run: https://openbenchmarking.org/result/2102015-HA-TESTEVESE17

This is really bizarre -- are you guys digging into this?


Simplify <Vec as BufMut>::bytes_mut()

Removes a call to UninitMut indexing, which can panic, from
Vec::<u8>::bytes_mut().  I came across this while looking at a
performance issue encountered after moving to bytes 0.6. This change
makes a microbenchmark in prost slightly faster, although there's
still a big delta between 0.5 and 0.6. See danburkert/prost#381.

Added a second commit which adds an #[inline] for Vec::put_slice, which closed most of the remaining perf difference between 0.5 and 0.6.  Will have another PR to add inlines to UninitSlice to close out the rest.

@danburkert Could you resolve merge conflicts?


Add lucas.computer

This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[x] I used the uncompressed size of the site
[x] I have included a link to the Cloudflare report
[x] This site is not an ultra lightweight site
[x] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[x] Check to confirm

- domain: lucas.computer
  url: https://www.lucas.computer
  size: 200.9
  last_checked: 2024-01-14

Cloudflare Report:
https://radar.cloudflare.com/scan/2d9b5599-5b9b-4f76-8b74-94dc6abbad9a/summary

Thanks!


Confirmation for requesting a list of events

To my understanding of the code, to ask for a list of events:
let msg_code = MessageCode::RawData;

let kind = "some_kind".to_string();

let input: Vec<(String, Vec<i64>)> = vec![];

let req_data =  RequestRawData {
    kind,
    input,
}

And the response would be, assuming request_giganto sends the request properly and receives all the response data:
let recv_events: Vec<(String, Vec<T>)> = request_giganto(msg_code, &req_data).await?;
// note that this is a pseudo code, just to give an example

And given the above:

[x] In giganto-client/src/publish.rs, receive_raw_events should return Vec<(i64, String, Vec<T>)>, related function send_raw_events etc should have modification accordingly.
[x] Add kind field for TimeSeries data, and merge RequestRange and RequestTimeSeriesRange
[x] Allow RequestRawData to get events from TimeSeries db.

@kimhanbeom
Related to the first issue of above:

in Giganto/src/publish/tests.rs, and in giganto-client/src/publish.rs, the function receive_raw_events(...)
Please modify the response type to Vec<(i64, String, Vec<T>)> (add event_id in the first place of tuple). And please check all code that call this function.

And please write more description about the QUIC API, especially example code to call the API

@minshao
Related to the second issue of above:
As you can see in Giganto/src/publish.rs, REconvergeKindType is used only for MessageCode::Log and MessageCode::RawData. And it's not used for MessageCode::PeriodicTimeSeries.
You should use RequestTimeSeriesRange structure to retrieve TimeSeries events.
pub struct RequestTimeSeriesRange {
    pub source: String, //sampling policy id
    pub start: i64,
    pub end: i64,
    pub count: usize,
}

        let msg_code = MessageCode::PeriodicTimeSeries;
        let req_data = RequestTimeSeriesRange {
             source: policy_id.to_string(),
             start: ...,
             end: ...,
             count: ...
        };

You should use RequestTimeSeriesRange structure to retrieve TimeSeries events.

It was meant for requesting Giganto for a list of outlier events that are of type Vec<(String, Vec<i64>)>, while it's possible to convert each event into a range request and use RequestTimeSeriesRange, it will be very inefficient and cumbersome. The solution that I proposed is to let RequestRawData handling requesting a list of time series data. That being said, it's also acceptable to have a new request RequestTimeSeriesData (or some other preferred name) in Giganto to handle corresponding request for time series data.
As for adding kind to TimeSeries db, I'm all for it. Just want to mention that, after adding kind field, RequestTimeSeriesRange and RequestRange would be identical, and I would suggest merging the two. And make kind an enum instead of String, something like the following:
  enum DataKind {
    Raw(REconvergeKindType),
    Timeseries(TimeSeriesKind),
  }
  enum RawKind {
    ...
  }

@minshao Ok now I understand what you said.
@kimhanbeom
As a summary, you have two things to change.

You have to merge RequestRange and RequestTimeSeriesRange structure.
Change RequestRawData to get events from TimeSeries db.

This issue hasn't seen an update for a few weeks and this lack of development has started to have a direct impact on our work with models in REconverge.
Specifically, we currently have a branch in progress that reduces the size of a model stored in the database. This branch relies on the APIs outlined in the comment above, which we need implemented in giganto-client. However, as these APIs are yet to be realized in giganto-client, we're unable to merge this branch into our main codebase. As a consequence, we're continuously required to rebase this branch with every change made to REconverge. This practice is causing significant maintenance overhead and preventing us from making further improvements and adding new features to models.
In addition to this, the current format of a model in the database is opaque, necessitating intricate migration logic if the format is to be changed. With all these issues combined, we find it essential to have this issue addressed before we proceed with any alterations to the models.
The specific issues we'd like to see addressed are:

In giganto-client/src/publish.rs, receive_raw_events should return Vec<(i64, String, Vec<T>)>. Related functions, such as send_raw_events, should also be adjusted accordingly.
The addition of a kind field for TimeSeries data, alongside the merging of RequestRange and RequestTimeSeriesRange.
The ability for RequestRawData to fetch events from the TimeSeries database.

Resolving these issues swiftly would immensely facilitate our work on improvements related to models in REconverge.
Your prompt attention to these matters would be highly appreciated, and it would go a long way in enhancing the functionality and efficiency of our work.

Close this issue as the implementation of this issue has been applied to giganto-client and giganto


Fix broken link to css-discuss.incutio.com/wiki/Printing_Tables

Instead now pointing to the most recent Wayback Machine archive copy.

We're probably going to remove a lot of the print styles in v5, so we might better target the v4-dev branch here (ping @XhmikosR)?
Other than that, linking to Wayback Machine is creative solution, but we might just better remove it or link it to another article instead of linking to something that once existed on the internet 😄

Yeah, I remember this one. I'd swear I had removed it at some point, but apparently not :P
I think this is fine targeting master, since any removal will happen later.
About removing or replacing the link I think it's better to link to the original page for historical reasons.


Add #[allow(unsafe_code)] to projection macros

I feel the current behavior of lint is a little odd, but I'd like to prevent unsafe macros from being used on the crate that forbids unsafe_code.
This may break some crate, but pin-utils is still alpha, so should be acceptable.
Closes #2
r? @cramertj
cc @Nemo157

Opened https://github.com/rust-lang/rustup.rs/issues/2065 about the CI failure, it's fallout from the last rustup release.
Since Pin is stable now it might be a good idea to move the clippy job over to using the stable channel so it will be guaranteed to exist.

new rustup released which should fix this, so rerunning this build should work (but I'll probably still look at updating to use stable later).

Still broken because the cache has stored the broken state... if someone has access to clear the cache it should fix it.


latest pyro release version 4.58

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


python310Packages.pescea: 1.0.10 -> 1.0.11

Description of changes
https://github.com/lazdavila/pescea/releases/tag/v1.0.11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185650 run on x86_64-linux 1

2 packages built:

python310Packages.pescea
python39Packages.pescea


Security: Buffer Overflow in the function TEE_MemMove

Vulnerability type
Buffer overflow
Affected components
affected source code file: tee/lib/libutee/tee_api.c
affected functions: TEE_MemMove
Attack vector(s)
To exploit the vulnerability, invoke the function "TEE_MemMove" and pass a large number of "size" which is larger than the size of "dest".
Suggested description of the vulnerability for use in the CVE
Buffer overflow  vulnerability in "TEE_MemMove" function in mTower v0.4.0 (and earlier) allows a trusted application to trigger a Denial of Service (DoS) if "dest" is filled with more bytes than its capacity.
Discoverer(s)/Credits
SyzTrust
Reference(s)
https://github.com/Samsung/mTower/blob/98e319507acaceed1f01d80a9c02f186fe446b00/tee/lib/libutee/tee_api.c#L238
Additional information
The "TEE_MemMove" function does not check the capacity of "dest" before executing "memmove(dest, src, size)". Unlike what the function "memmove" does in C, when too many bytes copied to "dest", the real IoT hardware (such as Numaker-PFM-M2351) will crash the trusted execution environment kernel and cause a Denial of Service (DoS).

Will be reviewed soon


Member updates 1.25.22

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~15 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and Cloud Kinetics (member) has issues with logo: cloud-kinetics.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/cloud-kinetics.svg'
Empty twitter for Mail.Ru Cloud Solutions (member): https://twitter.com/mailru
Empty twitter for Mail.Ru Cloud Containers: https://twitter.com/mailru
Empty twitter for Spotinst Functions: https://twitter.com/spot_hq
No cached entry, and Sangfor CNAD has issues with twitter: https://twitter.com/SangforUSA, Request failed with status code 404
No cached entry, and Sangfor EDS has issues with twitter: https://twitter.com/SangforUSA, Request failed with status code 404
Empty twitter for SeaTunnal: https://twitter.com/ASFSeaTunnel
Empty twitter for Karmada: https://twitter.com/karmada_io
Item Cloud Kinetics (member) has no image_data


Added spec definition for Nested template parameter

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

/azp run

/azp run

/azp run

@abatishchev ,please fix these error:

/azp run

Add "BreakingChangeReviewRequired" label to review breaking change

@abatishchev please fix ModelValidation error and ask BreakingChangeReview Board to review your breaking change.(becasuse "NewApiVersionRequired" label is added ,and if you don't want to create a new api verion for your change, it need review breaking change)

Hi @kazrael2119,
The model validation fails due to unrelated changes, I believe. Since this is the very core ARM RP, I don't want to change more than I need.
And for the breaking changes, I'm working with @rkmanda  whenever he'll have a moment for this.

@msyyc @tadelesh @qiaozha , please help review sdk breaking changes ,thanks

/azp run

@abatishchev ,please let me know when you want to merge this pr,thanks

@kazrael2119 yes, please merge.


Torchvision transforms

🚀 Feature
Add support for torchvision transforms, this will be specially helpful when deploying a model, since these transforms are torch-scriptable.
Suggested API:
tfms.T.Normalize

We don't have bandwidth for this atm.


PowerToys are displayed as "Preview" in windows search even though I have the latest release

Microsoft PowerToys version
0.66.0
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
Well, I just installed PT and immideatelly got this behaviour:

✔ Expected Behavior
PT should not have "Preview" suffix because this is a normal release
❌ Actual Behavior
Opposite to expected
Other Software
Windows 11 22H2 build 22621.1105

This is intentional. We're stilla preview product and haven't reached 1.0 yet


Remote write compliance: TestRemoteWrite/otelcollector/Counter

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write TestRemoteWrite/otelcollector/Counter.
=== CONT  TestRemoteWrite/otelcollector/Counter
    counter.go:35:
        	Error Trace:	counter.go:35
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/Counter
        	Messages:   	found zero samples for {__name__="counter"}

Related to https://github.com/open-telemetry/wg-prometheus/issues/43.

Blocked on PR 3047 in Collector; waiting to be merged.


Add a background or a border to the 3d preview so it does not merge with the page background

@loucass003, which background is better: darker or lighter?

Additionally, we have a skeleton image on Home page (and other places). Should we apply a background for the 3D preview everywhere, or just on the Manual Body Proposition page?

imo lighter fits the UI more


More on list splicing and indexing

List indexing such as a[:3] are in the NumPy section but they should be in the  regular Python list section as well (or only).
Also, negative indexing should be included such as a[-1] or a[:-2], etc

It is indeed worth to be added.

I think we are covered now.


Fix universal donor/recipient traits

universal donors have O negative
universal recipients have AB positive

@Nyamops I saw that you put a thumbs up on this, did you mean to approve it? Is there anything I should change?
Thanks!

I've already fixed it with your report. I'll note you in the update description


Added a new sample for loading users from GitHub and reworked the REA…

…DME to show that sample and all of the other decorators.
This adds a small new sample and a reworks the main README to provide more documentation for the decorators.

Pull Request Test Coverage Report for Build 31

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 29:
0.0%

Covered Lines:
282

Relevant Lines:
282

💛  - Coveralls

Pull Request Test Coverage Report for Build 30

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 29:
0.0%

Covered Lines:
282

Relevant Lines:
282

💛  - Coveralls


refactor: ml.sql to Object

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

tg/2031748
The change basically only:
Refactor the ml.sql and ml.core module from functional to object oriented.
It will improve code health and resolve some tech debt that:
Object oriented that gives us the capacity to easily inject mock objects and create unit tests.
Currently sql generation and assembly are spread all over the place, we can limit the functionalities as much to ml.sql module as possible. That in turn get better isolations.

To replace https://github.com/googleapis/python-bigquery-dataframes/pull/42, since I messed up venv folder. Renaming venv will make pre-commit can't be resolved.


Search using degenerate characters

Hi,
Quite impressed with the speed at which mmseq performs pairwise alignments. Have a couple of questions:

Can i perform alignments using sequences with degenerate characters? Right now the program considers these positions as mismatches. Can i change the way mismatches are counted? So an alignment of X against any of the 20 amino acids can still be considered as a match.

Can i search using the protein motif patterns found in PROSITE?

Thanks in advance,
Shiv

1.) I have not yet tested it properly but I think it should be possible to change the substitution matrix and add characters. However the seeding stage (k-mer double diagonal matching) only works with an alphabet of 20.
2.) We do not provide a pattern search engine

Thanks for the inputs Martin. Would you be referring to the substitution matrix here https://github.com/soedinglab/MMseqs2/blob/master/src/commons/SubstitutionMatrix.cpp, so if i were to test this, would this be changing the break statements for the degenerate characters in the above script? If not, Can you recommend a way to change the substitution matrix?

Hi Martin, to clarify i can generate my own substitution matrix that accounts for the degeneracy using the script here util/format_substitution_matrix.R. I understand this is WIP, would you have any examples that can be used as input for generating custom matrix, or can modification of scores in one of the existing matrix would suffice?
https://github.com/soedinglab/MMseqs2/blob/master/util/format_substitution_matrix.R

Usually you should be able to just take e.g. the blosum62.out in the data folder and adapt it to your needs and pass that new file to --sub-mat and/or --seed-sub-mat.
Sometimes MMseqs2 fails to compute the inverse of the matrix. In this case you can use the R script to compute the background probabilities (for which the inverse is needed). Make sure that the input to this script is already scaled to bit/2.

Hi,
Using mmseqs version '8-fac81' on OSX, I tried changing the substitution matrix while performing nucleotide to nucleotide search.
However, irrespective of whether i use the default or a new substitution matrix, the sequence alignment results are the same. Does mmseqs support change of substitution matrix for nucleotide to nucleotide search?
Output of result.m8 file
111276241826	276241826	0.920	25	2	0	1	25	1	25	7.431E-09	37
The input files are attached.
a.txt
b.txt
mmseqs createdb a.txt aDB --dbtype 2
mmseqs createdb b.txt bDB --dbtype 2
mmseqs search aDB bDB resultDB tmp --search-type 3 --sub-mat ../Ednafull_4.4_modified.out -a
mmseqs convertalis aDB bDB resultDB resultDB.m8

Nucleotide matrices are currently hardcoded. Most of the infrastructure is in place to make it changeable, a little bit of work is still left however to expose that. We will look into making it adjustable.

That will be fantastic! Till that time, i can maybe parse results which contain degenerate sequences. Would you suggest any other workarounds?

I have an idea for a a workaround:

Change the nucleotide.out in the data folder
Remove the default background probabilities for this matrix from src/alignment/EvalueComputation.h (delete lines 57-62).
recompile MMseqs2
This will embed your substitution matrix with whatever values you specified and compute the background probabilities itself.

Hi Milot-mirdita and Martin,
Thank you for taking time to help. I tried the above steps, however while performing search, the following errors occur
Segmentation fault (core dumped) Error: Prefilter died Error: Search step died
The scoring matrix that i used to replace the nucleotide.out is the EDNAFULL matrix (ftp://ftp.ncbi.nih.gov/blast/matrices/NUC.4.4) which i then used with the format_substitution_matrix.R to get it in the format for mmseqs
NUC_modified.txt

Hi,
Changing the substitution matrix works for amino acids, question on the alignment.
>Seq1 DIQXTQSP
>Seq2 DIQSTQSP
>Seq3 DIQ.TQSP
Seq1 against itself results in a 100% identity. However Seq2 against Seq1 also aligns with 1 mismatch, while Seq3 with Seq1 is 100% identity. In the substitution matrix, i do not penalize the degenerate character 'X'.

Why does Seq2 against Seq1 result in 1 mismatch for the position of X, while using a '.' character does not result in mismatch.

All unknown characters (i.e. characters not defined in the substitution matrix) will be converted to X so this seems to be quite surprising.
Did you pass --alignment-mode 3 or -a to the search to compute the exact sequence identities (See https://github.com/soedinglab/MMseqs2/wiki#how-does-mmseqs2-compute-the-sequence-identity)?
I can try to reproduce your crash later. Could you also post the full command line you used?

Sure, these are the commands used for performing protein to protein search with a modified substitution matrix (changed the score for X)
mmseqs createdb TestDB_Subject.fa testRun/targetDB
mmseqs createdb TestQuery.fa testRun/queryDB
mmseqs createindex --mask 0 testRun/targetDB testRun/tmp --comp-bias-corr 0 --seed-sub-mat PAM10_modified.out
mmseqs search testRun/queryDB testRun/targetDB testRun/resultDB testRun/tmp --comp-bias-corr 0 --mask 0 --sub-mat PAM10_modified.out -a
mmseqs convertalis testRun/queryDB testRun/targetDB testRun/resultDB testRun/resultDB.m8 --sub-mat PAM10_modified.out
The result matrix
TestDB_Subject.txt
TestQuery.txt
PAM10_modified.txt

I just committed a solution to be able to provide a different nucleotide matrix.
You can just pass a file to --sub-mat and --seed-sub-mat and it should just work, however there might still be issues in the background probability computation code.
I am sorry for not responding to your other issue, I was traveling and forgot about it. Is it still a problem?


feat(hangingProtocol):Compatibility with older hanging protocol definitions

This adds backwards compatibility to the hanging protocol mode definitions by adding a "setActiveProtocol(s)", which allows defining the protocols currently active, independent of the full set.  This gets called on mode enter.

I see what you are trying to do here, however, having both protocol and protocols is not ideal. How about we identify it ourselves ? having protocol but the type is string[] | string and we identify and apply correctly

Unfortunately you may well want to have both of them - I can see a situation where a default protocol is always applied initially, but then a menu of available protocols is shown.  Also, we need to keep it backwards compatible as much as possible, so I don't see an alternative to having both.

This isn't going to be merged as backwards compatibility was deemed a not required feature.


missing .js

Context

Changes & Results

Testing

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

@wayfarer3130 it was missing this one


HADOOP-17835. Use CuratorCache implementation instead of PathChildrenCache / TreeCache

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 24s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 51s

trunk passed

+1 :green_heart:
compile
22m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
2m  8s

trunk passed

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  4s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 14s

trunk passed

+1 :green_heart:
shadedclient
16m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
22m  3s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m  3s

root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 0 new + 1921 unchanged - 10 fixed = 1921 total (was 1931)

+1 :green_heart:
compile
21m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
21m  9s

root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 0 new + 1797 unchanged - 10 fixed = 1797 total (was 1807)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-common-project: The patch generated 0 new + 21 unchanged - 1 fixed = 21 total (was 22)

+1 :green_heart:
mvnsite
2m 10s

the patch passed

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 45s

the patch passed

+1 :green_heart:
shadedclient
16m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m 49s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 14s

hadoop-registry in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

199m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c94a615dbc64 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f5e8dbc7b0aa7b6617e5e29ac22fd131388b95bc

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/1/testReport/

Max. process+thread count
3121 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry U: hadoop-common-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka @eolivelli Could you please take a look?
Thanks

@Randgalt Thanks for the review. Addressed all comments.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
27m 35s

trunk passed

+1 :green_heart:
compile
29m 54s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
24m  8s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
2m 30s

trunk passed

+1 :green_heart:
javadoc
2m  1s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m  7s

trunk passed

+1 :green_heart:
shadedclient
19m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 38s

the patch passed

+1 :green_heart:
compile
27m 27s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
27m 27s

root-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 0 new + 1921 unchanged - 10 fixed = 1921 total (was 1931)

+1 :green_heart:
compile
23m 49s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
23m 49s

root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 0 new + 1797 unchanged - 10 fixed = 1797 total (was 1807)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 19s

hadoop-common-project: The patch generated 0 new + 21 unchanged - 1 fixed = 21 total (was 22)

+1 :green_heart:
mvnsite
2m 33s

the patch passed

+1 :green_heart:
javadoc
1m 42s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
4m 26s

the patch passed

+1 :green_heart:
shadedclient
19m 42s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 58s

hadoop-common in the patch passed.

+1 :green_heart:
unit
1m 16s

hadoop-registry in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

237m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3266

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e743ffa71b4a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ed4b013c5a91fe6b3cc983cbb75017e529f52b75

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/2/testReport/

Max. process+thread count
2901 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-registry U: hadoop-common-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3266/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for the reviews. @aajisaka we have @eolivelli's +1 for this PR after latest revision.
Thanks

Thank you @virajjasani for your contribution and thanks @eolivelli and @Randgalt for your  review.


feat: sdk - start/stop events for transcriptions

Details(context, link the issue, how was the bug fixed, what does the new feature do)

Implementation note, gotchas, related work and Future TODOs (optional)

add a selector to read transcription state from room


WIP: Exercise 3

We did the Review for @Systems-Development-and-Frameworks/scp-foundation

We did the Review for @Systems-Development-and-Frameworks/scp-foundation

I can't find it in their PR. Can you put a deep link into your PR description, please?

We did the Review for @Systems-Development-and-Frameworks/scp-foundation

I can't find it in their PR. Can you put a deep link into your PR description, please?

https://github.com/Systems-Development-and-Frameworks/SCP-Foundation/pull/4#pullrequestreview-537564678

@roschaefer Review is not updated

I can confirm the missing things are now implemented / delivered:
⭐  For creating a post. Working with test.
⭐  For upvoting a post. Working with test.
⭐  For preventing users to upvote the same post multiple times. Test included.
⭐  For requesting review and reviewing another teams PR according to the instructions. - We found it!
You now got 10/10 ⭐ 👍


Coming back from frontend routed page reloads the page

This may be hard to fix for now. It has two parts 1) components (for example home) are always re-rendered 2) scroll position is not remembered. It may need refactoring the whole App.js to do this

Hook rewrite https://medium.com/@chrisbautistaaa/converting-a-hoc-to-a-hook-is-easy-c45cbf73c1cd

This is how mastodon implements it https://github.com/mastodon/mastodon/pull/2271

This was mysteriously fixed..?


Licensing

The source code in src/jose.c looks pretty similary to original word2vec imlementation by Mikolov. Since word2vec sources is distributed under Apache-2 terms, it would be greate to satisfy redistribution condition.

Hi,
Thanks for the reminder. I have added redistribution notices to the README file and the source file. Please let me know if you have any further concerns!
Best,
Yu


fix: Use named parameter for _to_datetime to pass default_tz

I noticed in the PST timezone, tests/track/loader_test.py::TestTemplateRender::test_render_simple_template was failing because the default timezone wasn't getting set correctly.

Sigh, can't merge until #1890 can fix the lints


[platform bug] Table 700 Error Message not properly cleaned up

Hello,
we have encountered issues with table 700 "Error message" becoming to large due to errors related to Notification entries and Notification entry dispatcher.
Once there is one Notification Entry that cannot be sent for some reason, Job queue Notification Entry dispatcher will try sending that same notification over and over again, every few minutes or so. This leads to table Error message being populated pretty quickly, in matter of days, with millions of records.
Even after problematic Notification Entry is fixed and is sent successfully, Error messages for that entry are not deleted. Notification Entry gets deleted and moved to Sent Notification entries, but Error messages are stuck and orphaned.
Is there a solution for this scenario? I tried setting retention policy, but table 700 is not in the list of approved tables.
As a workaround I added code in OnDelete() trigger of Notification Entry to find and delete Error Messages and related Error Registry.
I was able to replicate this in v21 and v22.
Thanks

Should you create hotfix request via technical support instead? This is not right place to report bugs.

Closing, as this is not an extensibility issue and we cannot process it here.


[WIP] [RFE] Placement method doesn't take into account read-only datastores

Capture the read_only property of VMware host datastore mounts so that it can be used for VM provisioning.
https://bugzilla.redhat.com/show_bug.cgi?id=1187819
DB migration for this change was https://github.com/ManageIQ/manageiq/pull/5113
cc @blomquisg @Fryguy

The VCR changes are freaking me out...I think we have to come up with an alternative: 682,366 additions and 116,235 deletions.  cc @bdunne Turns out we might have to do this sooner than later, regardless of the performance improvements.

@Fryguy Rather than gather new inventory from that system I changed it to just add the HostDatastoreMount property to each existing datastore, that brings the diff for the inventory yaml files way down and the tests pass without modification.


added basic chat application made using socket.io

Description 📜

A basic chat application made using socket.io. Users can join a room to chat with other users in the same room. Users can also see all the active users in the current room. An additional feature of live location sharing has also been added.

Domain of Contribution 📊

[x] Web Development

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.

Screenshots should be previewed in readme.md . Kindly add there .

@AdityaTeltia I have added the screenshots now in readme.md


Provide list of bundled extensions per PHP branch

A simple list of the extensions bundled in the core per major version.
pickle cmd line or composer can then fetch them to directly deal correctly with it and tell the user to either enable, install or rebuild them php, alternatively rebuild php.
The list will be:
[
'extname' => false,
'extname' => 'vendor/repo',
]
false means this extension is only maintained in core.
'vendor/repo' is the name of the extensions within pickle, so if an newer external release is available, it can be installed.

This would probably need the PHP version relation as well, at least for some cases. As extensions come and go.

What the title said, it will be json per branch :)
On May 7, 2015 8:39 PM, "Anatol Belski"<EMAIL_ADDRESS>wrote:

This would probably need the PHP version relation as well, at least for
some cases. As extensions come and go.
—
Reply to this email directly or view it on GitHub
https://github.com/FriendsOfPHP/pickleweb/issues/36#issuecomment-99868647
.

Got it :) .. this is probably also easier also for, extending later, when HHVM or something else comes in addition.

https://github.com/FriendsOfPHP/pickleweb/commit/80eb8a15b5e5c2cf1865472298d03e383654d2ee
WiP