Storyboards templates for OS X

Just migrated all the works did in my fork in a local branch, closing #128 in favour of this one.
Things to do (following the previous discussion):

[ ] Templates: storyboards-uppercase and storyboards-lowercase
[x] Separate iOS and OS X storyboards in different fixtures directory in order to fix tests testAllStoryboardsWithDefaults and testAllStoryboardsWithCustomName
[ ] Drop the hard coded UI to handle NS prefix (cf @AliSoftware explanation below)
[ ] Find a satisfying output 😆

I annotated the code with 2 // TODO: comments just recently — which will show up as warnings thanks to the new SwiftLint script I recently added — to highlight where that needs to be changed. You might want to rebase your PR on top of master btw to get them here.

We'll probably need to add a new field to the stencil context in addition to "identifier" and "class", like vcType or something, to store the scene.tag there (which is the XML tag name and is usually either <viewController …>, <navigationController …>, <tableViewController …> and the likes). Then we'll have to alter the templates to use either {{scene.class}} if it's defined (if it's a custom class), or the UI{{scene.vcType|titlecase}} if scene.class is nil. And then we can easily change that UI into NS for the OS X template.

⚠  The current state of this PR is more a proof of concept to discuss the output than a final implementation ⚠
PS: I will be in vacation starting mid of next week for two weeks, I will get this PR ready once I'm back if anyone finish it 👯

Hey! I had a problem with Travis on master :confused: — which was still using Xcode 7.0 and failed compilation even if it were working locally.
You might want to rebase onto after that fix I just pushed (otherwise even if your own tests are OK travis will fail on your branch and the PR won't be able to be merged)

Small updates:

Separate iOS and OS X storyboards in different fixtures directory in order to fix tests testAllStoryboardsWithDefaults and testAllStoryboardsWithCustomName

I ended by adding an osx option to parseDirectory, which will just check if the storyboard name contains "osx" or not and add it to the list to check. It's less nicer than split the directory, but allow us to keep the same structure as the others generators.

Drop the hard coded UI to handle NS prefix (cf @AliSoftware explanation below)

First version of this. @AliSoftware is that what you were thinking? I didn't do for the segues type yet, but I drop the UI prefix hard coded, to put it in the template. About the template, is there any better syntax to have multiple if conditions? I check in stencil README but didn't find anything related.

My idea was more along the lines of:
return ["identifier": scene.storyboardID, "class": scene.customClass, "vcType": scene.tag]

And then let the template do all the logic, including using {{class}} if not nil, and using UI{{vcType|titlecase}} otherwise, and thus also being responsible for the title-casing in the template and not in the code.

I ended by adding an osx option to parseDirectory, which will just check if the storyboard name contains "osx" or not and add it to the list to check. It's less nicer than split the directory, but allow us to keep the same structure as the others generators.

tbh I don't like this option. Because that means that people using SwiftGen will have to name their Storyboards with osx in their name. I don't want to impose that (and I don't understand why it would be required).
I recently grouped the different files in UnitTests/expected into subfolders in Xcode. It's probably time we do the same for the UnitTests/fixtures  folder to split it into subfolders like Images/, Colors/, Strings/, Storyboards-iOS/ and Storyboards-OSX/ (the subfolder Fonts/ already exists anyway)

About the template, is there any better syntax to have multiple if conditions? I check in stencil README but didn't find anything related.

I don't think there is yet. kylef/Stencil#52 is not yet implemented and it probably will be the first step in then supporting operators like && and ||, by they're not there yet it seems.

I'm also encountering another issue for which I don't have a great solution after some though: […]

I think that logic should be handed in the template itself, as I said in my previous comment. But we'll probably need kylef/Stncil#52 first so that the template can do comparisons that would probably look like this:
{% if scene.vcType == 'viewController' %}
/* branch without the guard let */
{% else %}
/* branch with guard let … as? … */
{% endif %}

Maybe until kylef/Stencil#52 is implemented and released we can workaround by providing the comparison result in a dedicated field in the Stencil context:
return ["identifier": scene.storyboardID, "class": scene.customClass, "vcType": scene.tag, "isBaseViewController": (scene.tag == "viewController")]

This way both template (iOS & OS X) will have everything they need to do the comparisons. In the iOS template you'll be able to check {% if isBaseViewController %} and avoid the guard let in that case — because you know it's neither a custom class nor a special vcType like navigationController or others — and in the OSX template you won't use that isBaseViewController test if you don't need it at all.

btw you might want to rebase on master before reorganizing the UnitTests/* folder into subfolders, as I renamed some of the UnitTests/expected/* files recently — so rebasing would avoid a potential conflict when merging later :wink:

tbh I don't like this option. Because that means that people using SwiftGen will have to name their Storyboards with osx in their name. I don't want to impose that (and I don't understand why it would be required).

Oh, didn't though that will make a mandatory condition for all the users, I'm completely joining you on this to say that is a bad idea. I though it was used only unit tests, my bad. I'm gonna change it and come back to the first solution.
Thanks for your answer, it's useful to have a better understand of about how all the logic is implemented SwiftGen 👍

np, don't hesitate to ask if something in the code or the project organization is not clear!

Side note; the more I think about it, the more I believe the fields in the Stencil context should be named customClass and baseClass or baseType instead of class and vcType, to make their intend more clear:
return [
  // The scene identifier, as set in IB
  "identifier": scene.storyboardID,
  // The custom class set in IB, e.g. "FooBarViewController"
  "customClass": scene.customClass,
  // The base class type on which this scene is base
  // (depending on the type of VC you drag & dropped in your Storyboard from the library pane)
  // possible values include 'viewController', 'navigationController', 'tableViewController'…
  "baseType": scene.tag,
  // indicate if the baseType is 'viewController' or anything else
  "isBaseViewController": (scene.tag == "viewController")
]

This way it's clear that the customClass field now only contains something if there actually is a custom class, and would be empty if there is no special custom class set in IB — contrary to the old behavior before this PR where the class field was computed in SwiftGen's StoryboardParser code to contain either the custom class or the inferred one, but now that we'll do that logic in the template.

Additional notes / checklists (sorry to spam you again ^^)

[ ] Don't forget to re-generate the Storyboard resources used in the Playground if you've modified them, so that the Playground demo pages are using the latest compiled version of those storyboard fixtures to use in their demo code.
This is done by using the rake playground:resources task in a terminal, which compiles the storyboards in UnitTest/fixtures into *.xcplayground/Resources
[ ] You will probably need to update the Rakefile if you move the fixtures in subfolders btw, especially those 3 lines here just to update the paths of the fixtures the Rakefile needs to compile

And another little checklist for once the PR is ready:

[ ] It would be good to check if the Playground demos are still working once you've made all those changes. Idk if it's worth adding a dedicated demo page for OS X storyboards as well in that playground or not?
[ ] Dropping a line in the README about that OS X storyboard support would probably be a good idea as well

Alright, this time you can take a look at it @AliSoftware 😆
I updated the following:

System to drop UI from hard code to move it in the templates. Using baseType, customClass...
Renaming stencil fields as you suggested
Handle isBaseViewController in template for iOS
Drop the as! from templates

Also, SwiftLint created errors for each try! used in StoryboardsTests, for now I just replaced them by:
    do {
      let result = try template.render(parser.stencilContext())
      let expected = self.fixtureString("Storyboards-Message-Lowercase.swift.out")
      XCTDiffStrings(result, expected)
    } catch {}

Let me know which behaviour do you prefer in the catch: just a log, fatalError, nothing, test failure...

Alright, this time you can take a look at it @AliSoftware 😆
I updated the following:

System to drop UI from hard code to move it in the templates. Using baseType, customClass...
Renaming stencil fields as you suggested
Handle isBaseViewController in template for iOS
Drop the as! from OSX templates

Cool 😎 Will take a look soon!
Beginning of week will probably be quite busy for me, so don't think I'll have time to review & merge before you leave for your vacation :wink: (you leave in the upcoming days, right?)
Will take a closer look in the next days and let you know. In the meantime if I don't see you online before that, enjoy your vacation!
PS : I've just released SwiftGen 1.1.0 (which include the first OS X templates + the bug fix for the Fonts template) 🎉

Just see your release! Awesome, I pass the link to the other OS X dev 🎉
Yeah living thursday (in fact, I'm already in vacation but had few days working remotely to do), anyway, thanks!
I will take care of the change once I'm back. 👍

@AliSoftware I'm back here 😆
So, I just updated some small stuff:

Add a NSStoryboard section in README since the output and usage is different from iOS, I think it can have a full section for itself
Updated playgrounds fixtures path / ressources as you asked

Since I got no feedbacks on the output, I think we can go with that for a first version. We can still improve it later.
Still missing two points:

lowercase and uppercase templates: are they really necessary? I'm have no used for them personally, so should I port them directly or wait for someone that needs them?
add a playground page for storyboard: it's up to you if you think that we should have one or not. Just let me know what do you prefer

Thx!
The uppercase vs lowercase template is because a lot of people use the same name for the storyboard and the VC class and this might cause naming conflicts, hence the lowercase variant.
We can't really add a page for that in the playground as playgrounds are tied with a SDK; he one we have is an iOS playground so if we wanted to demo the OSX templates we'd need a separate ~OSX~ macOS playground. I don't think it's worth it given the similarities with iOS.

Just added the lowercase template, but I prefer to wait for a feature request to do the uppercase one. I don't think it's a good idea to add too much templates before they are needed.
I just have the CHANGELOG to update, otherwise, everything has been implemented for this PR. Finally ready to go 🎉

Cool! Will take a look later and merge once you've added the CHANGELOG entry.
Not being an OS X developer either, I think I'll still merge it anyway even if not broadly tested by us non-OSX devs, and see if there are any feedback once it'll be up.

@tbaranes I've fixed the hack on StoryboardParser for tests.
Now the fixture folders Storyboards-iOS and Storyboards-OSX folders have beed added as folder references (blue folder icon in Xcode) instead of Groups (yellow folders in Xcode).
By doing this, this means that when the UnitTests.xctest bundle is build by Xcode, instead of copying those *.storyboard files at the root of UnitTests.xctest/Contents/Resources/ and putting them all at the same level in the compiled xctest bundle, the folders are copied as-is, keeping the folder hierarchy, and thus copied into separate subfolders UnitTests.xctest/Contents/Resources/Storyboards-iOS/ and  UnitTests.xctest/Contents/Resources/Storyboards-OSX.
This way, I can make the Unit Tests only scan for the specific subfolder in the bundle and thus only scan for iOS OR OS X storyboards but not both. I've adapted the TestsHelper accordingly so that the fixturePath and fixturesDir functions now takes an optional parameter to specify an optional subdirectory for the fixture and there you go!

Awesome. Didn't know that. Thanks for the fix!

Thanks for your comments! All of them has been cared of 👍

Come on Travis, what's taking you so long? I want to publish a release tonight and the CI makes the suspens killing me :trollface:

Seems like wants us to move away from github for tonight 👮


Allow substring match on use <server>

Extract the server selection logic out into a separate method. If no exact match is found, attempt a case-insensitive substring match.

Looks like this passed except for AppVeyor, which doesn't appear to be configured for this project.


Some authentication/privacy combinations are not working correctly

Hi there!
I am in the process of implementing a SNMPv3 agent here at work.
For testing purposes i test our agent with net-snmp (v5.10-git@82862da) with OpenSSL-1.1.1.
And i also test against the pysnmp testserver demo.pysnmp.com.
While doing so i found that some authentication/privacy algorythms are maybe not working as expected?
I am interested in finding out why and how, also to make my own implementation better.
As far as i can tell the error could also be on the net-snmp side, but i am unsure.
Is anyone interested in working on this?
Here a table of all tested combinations:

pysnmp
0: None
1: DES
2: 3DES
3: AES128
4: AES192
4: AES192C
5: AES256
5: AES256C

0: None
OK
---
---
---
---
---
---
---

1: MD5
OK
OK
not supported
OK
Decryption error
OK
Decryption error
OK

2: SHA1
OK
OK
not supported
OK
Decryption error
OK
Decryption error
OK

3: SHA2-224
Decryption error
Decryption error
not supported
Decryption error
Decryption error
Decryption error
Decryption error
Decryption error

4: SHA2-256
OK
OK
not supported
OK
Decryption error
OK
Decryption error
OK

5: SHA2-384
OK
OK
not supported
OK
Decryption error
OK
Decryption error
OK

6: SHA2-512
Timeout!
Decryption error
not supported
Timeout!
Decryption error
Timeout!
Decryption error
Timeout!

legend:
"---": impossible combination
"not supported": net-snmp does not support 3DES, so it can't be tested
"Timeout": pysnmp is not sending anything after time syncronisation -> needs fix!
"Decryption error": pysnmp has sent an answer, but net-snmp couldn't decrypt -> those ones need fix
The "C" at the end of privacy algos is for "Cisco", which means key localization is done with reeder-draft.
Those without the "C" have key localization according to blumethal-draft.
While it seems that the reeder implementation is the "standard" for pysnmp, the blumenthal ones don't seem to work at all?

Ooops, just realized this repo is not maintained anymore.

Ok, i am totally confused which repo is the maintained one...
so i am just opening this again and hoping someone sees it and can help me :-D

Hey, this is not very active as you might have noticed, we fix only critical things/accept PRs/maintaining pipelines. I know there's an active fork: https://github.com/lextudio/pysnmp/issues so I can recommend you to open this issue there.


iOS System Memory Workaround

This should fix https://github.com/Mapsui/Mapsui/issues/1216
by including a target in Xamarin.Ios that creates this PackageReference

Avoiding that the Developer using Mapsui has to do it himself

@inforithmics I am not setup for ios so can not properly test this.

I did some research though. First build the MVR sample of dino.
Result: The bin folder included the System.Memory nuget.

Then I added the  IncludeAssets="None" solution:

<PackageReference Include="System.Memory" IncludeAssets="None">
  <Version>4.5.4</Version>
 </PackageReference>

Result: The bin folder did not include the System.Memory nuget.

Then I removed the System.Memory nuget altogether. And added the nuget of latest build:

PS> install-package mapsui -source https://ci.appveyor.com/nuget/mapsui -pre

Result: The bin folder did not include the System.Memory nuget.
So the new package has the same result as the IncludeAssets="None".
I assume this works and won't create another RC specifically for this.


Doc: fix wrong name of config format

What does this PR do?
Fix a typo.
Motivation
No contribution is totally useless. (again!)
More

[x] Added/updated documentation

Thank you, next time could you read the pull request template to choose the right branch :wink:


Isolate tools into dedicate module

Create a dedicated module for tools.go, so that callers don't have tool imports in their repo.
Update //go:generate directives to use binary directly, instead of go run.
Add .\tools\Install-Tools.ps1 script to install required tools, and update CI accordingly.
Goal is resolve issues such as https://github.com/microsoft/hcsshim/issues/1827 and others

Replaced with #1840, to avoid needing an extra sub-module and dealing with go tidy


Update mentor view

Is your feature request related to a problem? Please describe.

In the mentor view of scholarX, the mentor's name is taken from the profile and in some cases, it only has the first name.

Describe the solution you'd like

Change it to get the name from the mentor application.

Fixed with #374


BadMethodCallException - Method 'addMs' does not exist.

I get its exception when tried subscribe an user in plan. I guess that its happen because the file Period.php not using month.

All interval fields are now string-based that accepts (hour, day, week, month) .. You should be able to use the latest release without any issues bf8b67beaa89fbc54c6ea6a7720fab0e3dc5d8cc

Thanks @Omranic


Fix: Apple Darwin CI Workflow

Description:
This pull request addresses the recurring issue where the x86_64-apple-darwin target was not installed, leading to errors during the build process. The error message indicated that crates for core and compiler_builtins couldn't be found, which require the x86_64-apple-darwin target to be installed in the Rust toolchain.
Changes Made:

Modified the rust-toolchain.toml file with the following configuration:

Added targets for x86_64-apple-darwin and x86_64-unknown-linux-gnu.

Testing:
To verify the fix, changes were tested and confirmed that the x86_64-apple-darwin target was installed and the build process completed successfully without errors. A CI workflow was triggered upon creating a pull request on my forked version of this repository to ensure that the changes pass the automated tests.

Oh nice, I meant to look at that at some point. I appreciate the fix!

Thanks for reviewing. I'd really love to contribute more. This looks like a very interesting project.


Changed API.

Previously, it had functions in both messages and model. This makes it hard to use the debugger, since you cannot serialize messages with functions in them.
Now, instead of only having meta for the draggable and a message creating function for the droppable, it's symmetric, so it has both dragMeta and dropMeta values.
To upgrade to the new API, make the following changes:

Add a type parameter for the dropMeta to Dnd.Draggable and Dnd.Message. If you don't care about the drop target, use the () type.
Pass a message creation function (dropMeta -> dragMeta -> Msg) to DnD.init. If you used the () type, pass (always Dropped) if you previously passed Dropped to the droppable function.
replace getMeta with getDragMeta
replace atDroppable with getDropMeta that returns a (Maybe dropMeta) instead of a (Maybe Msg)
instead of passing a message creation function to the droppable function, pass a dropMeta value. If you used the () type, pass the () value.

Sorry, I should have made a branch, I will close and reopen.


examples/window/shaders.metal is very wrong

the binary metallib checked into the repository works, but this .metal file cannot be compiled to produce that metallib.
This is closer:
// code: language=c++
#include <metal_stdlib>

using namespace metal;

typedef struct {
    float x, y, r, g, b;
} vertex_t;

static_assert(alignof(vertex_t) == 4, "vertex_t must match a rust array of f32");
static_assert(sizeof(vertex_t) == 4 * 5, "vertex_t must match a rust array of f32");

struct ColorInOut {
    float4 position [[position]];
    float4 color;
};

// vertex shader function
vertex ColorInOut triangle_vertex(device vertex_t* vertex_array [[ buffer(0) ]],
                                   uint32_t vid [[ vertex_id ]])
{
    ColorInOut out;

    auto device const &v = vertex_array[vid];
    out.position = float4(v.x, v.y, 0.0, 1.0);
    out.color = float4(v.r, v.g, v.b, 1.0);

    return out;
}

// fragment shader function
fragment float4 triangle_fragment(ColorInOut in [[stage_in]])
{
    return in.color;
}

I suspect the example should include a build.rs to compile the metallib from source to avoid this problem recurring.

(notable problems fixed: "vertex" and "fragment" keywords were flipped on the functions, layout of the vertex array didn't match the rust code)

oops, nicely spotted! We should be doing it in build.rs all the time and not include the binary in the repo

Fixed by #111


Removed noexcept.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.27%. Comparing base (3a71472) to head (3d76a12).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   89.27%   89.27%
=======================================
  Files          96       96
  Lines       10457    10457
=======================================
  Hits         9336     9336
  Misses       1121     1121

Files
Coverage Δ

include/async_mqtt/util/scope_guard.hpp
100.00% <100.00%> (ø)


Option choose default size of cropper

Yes Can we change the default size and adjust the width and height of the cropper?


Add an example dataset = solar spectral irradiance

It'd be nice to add a few example datasets that can be automatically downloaded, to make it easier for a new user to dive into some real data.
One good example would be solar spectral irradiance as a function of time.

Pick a dataset (or a few) from https://lasp.colorado.edu/lisird/. It'd be nice to have one that spans a pretty wide range of wavelengths.
Write a tiny little wrapper that downloads and reads it. It should use the astropy download tools, so the data file gets nicely cached. (That will speed up tests, and just generally make things more pleasant.)
Write a documentation example that makes some cool plots with that dataset.

@gmduvvuri, if you're interested in this (?), I think https://lasp.colorado.edu/lisird/data/lasp_gsfc_composite_ssi/ might be the most interesting dataset to go with. You could try to do something clever with the API, or you could just hard code one of the links to the complete datasets given at the bottom of the page. (I'm probably adding NetCDF as a dependency soon for another data format we want to read, but you can also always do the IDL sav file with scipy.io.readsav.)
Seeing a dyanmic spectrum of this dataset would be snazzy, and all that's needed to include it in the documentation is to write it up as a notebook!


fix: add desc for setuptools pin

Add desc for setuptools pin

Thanks.  That setuptools bug report (https://github.com/pypa/setuptools/issues/2940) says it was fixed within a day.  Do we think we can remove this pin now?  Do we know which services were affected so we can test them?

It wasn't the only bug in setuptools==60.0 as Jeremy mentioned here. But last I checked version 65 had been released on PyPI so essentially all the issues should have been resolved by now. We don't know about which services were affected as we don't have the slack messages from that time around but I will create a ticket in our board to investigate and remove this constraint.


Fix error removing map while zoom is animating - similar to #6160

This is very similar to #6160 and I imagine the fix would be similar.
Repro case - https://plnkr.co/edit/PIIt0zOzkh6mcaAr4KYd?p=preview
Click the zoom in button.
Check the browser console, you should see this:

I ran across this while writing some unit tests. After each test remove is called, occasionally I would see the above stack trace.

Hi,
Thank you for the detailed bug report and for the pointer to a similar case!

Proposed fix: https://plnkr.co/edit/YWWnMhhJRrJX8I1wvMz1?p=preview

I'm adding the stack traces (using<EMAIL_ADDRESS>in plain text in order to allow finding this issue via search:
Firefox 71:
TypeError: el is undefined  DomUtil.js:242:1
    getPosition DomUtil.js:242
    _getMapPanePos Map.js:1418
    _moved Map.js:1422
    getCenter Map.js:783
    _createAnimProxy Map.js:1563
    fire Events.js:190
    _moveEnd Map.js:1208
    _onZoomTransitionEnd Map.js:1650
    <anonymous> self-hosted:869

Google Chrome / Chromium 79:
Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
    at getPosition (DomUtil.js:242)
    at NewClass._getMapPanePos (Map.js:1418)
    at NewClass._moved (Map.js:1422)
    at NewClass.getCenter (Map.js:783)
    at NewClass.<anonymous> (Map.js:1563)
    at NewClass.fire (Events.js:190)
    at NewClass._moveEnd (Map.js:1208)
    at NewClass.<anonymous> (Map.js:1650)

Uncaught TypeError: Cannot read property '_leaflet_pos' of undefined
    at getPosition (VM489 leaflet-src.js:2765)
    at NewClass._getMapPanePos (VM489 leaflet-src.js:4378)
    at NewClass._moved (VM489 leaflet-src.js:4382)
    at NewClass.getCenter (VM489 leaflet-src.js:3743)
    at NewClass.<anonymous> (VM489 leaflet-src.js:4523)
    at NewClass.fire (VM489 leaflet-src.js:593)
    at NewClass._moveEnd (VM489 leaflet-src.js:4168)
    at NewClass.<anonymous> (VM489 leaflet-src.js:4610)


ci: disable clang tidy for now

This was taking up a spot instance for rather long
See https://github.com/AztecProtocol/aztec-packages/issues/1152 which will reenable this

Bypassed CI as it is currently in a dysfunctional state, and this aims to improve it.


Include lfshook in list of available hooks

I've written a hook to go to user selected log files in the local filesystem. I added the link to the README.md as recommended in another PR for a hook.

Nice usage!


Value assignment via Editor script

Consider the following scenario. We have two files in the 'Assets' folder: testgovariable.asset (a ScriptableObject of type GameObjectVariable) and a GameObject prefab test.prefab. Consider the following class:
public class TestClass : MonoBehaviour
{
    public GameObjectReference TestGoReference;
    public GameObject TestGo;
}

We can assign GameObject value via an Editor script like so:
Selection.transforms[0].gameObject.GetComponent<TestClass>().TestGo =
(GameObject)AssetDatabase.LoadAssetAtPath("Assets/test.prefab", typeof(GameObject));

This works for GameObject, but not for GameObjectReference.Value, when we try the following:
Selection.transforms[0].gameObject.GetComponent<TestClass>().TestGoReference.Value =
(GameObjectVariable)AssetDatabase.LoadAssetAtPath("Assets/testgovariable.asset", typeof(GameObjectVariable));

Instead, what happens is the GameObjectReference field in the Inspector is switched from "Use Variable" to "Use Constant", while GameObjectReference.Value is 'Null'.
What would be a proper way of assigning the GameObjectReference.Value to a scriptable object via an Editor script?

I also have the same problem, I'm not using any editor thing at all, all I want to do is be able to make gameObjectReference null in code. You can do that with gameObjectVariable and set its baseValue I think... but can't do with references.

This is caused because the property Value relates to the actual GameObject that's being referenced, rather than the Variable you're attempting to assign. Variables can be implicitly converted to the types they represent, so I suspect the following is what happens:

A GameObjectVariable is assigned to the property Value, which expects a type of GameObject
An implicit conversion is performed, returning the value of your variable. In your case, it seems like the variable's value hasn't been set, and is therefore null
Since the Reference doesn't have a variable assigned, it switches to constant mode and assigns the value returned in Step 2 (null).

While there's no way for me to let you assign a Reference to the Value property, I've added a new property called Variable. I also recreated your setup and confirmed that it works.
Thanks for the report! :)


fix: _curryN receive enough args

curry-discussions
Previous code doesn't judge every loop reveiving parameter the length of combined has placeholder. So i fix it.

Can you add a unit test, to test if the change works as expected?

Can you add a unit test, to test if the change works as expected?

I add some question. When i attempt fix this quesiton, i had two question

I view lodash internal implement about, it will handle next  loop placeholder as  func, which will not use in next loop.
So, i don't know my solution is correct or not.

I attempt publish test case vertify curry function will return function when it didn't reveive enough argument. How to test value  === function in ramda?

I think there is a fundamental question here we need to answer before we settle on a solution.
What should we do with extra parameters?  Our answer has been to pass them along, but we hadn't considered this case of passing too many with the placeholder displacing them.  Now we have to make a more fundamental decision.  Which of these (at least somewhat reasonable) results should we expect?"
const g = R.curry(function (a, b, c) {return [...arguments]})
g(_, 2, 3, 4)(_, 5, 6)(_, 7, 8, 9)(1, 10)
//?=> [1, 2, 3]
//?=> [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
//?=> [1, 2, 3, 10]

The second one seems the most likely extension of how we do things in Ramda

I agree with this, the other cases are not important enough to introduce breaking changes

Or are there other possibilities?

What about [1,2,3,4]?
Clearly the author of g wants to collect the excess parameters beyond c. Ramda's curry provides that feature which is fine.
However, the position of the parameters in a function is important. (Here a-c).
Should not have the excess parameters also the right position in the function call: Always following after the c?
I mean, your third case seems surprising in that the 10 does not follow the 3 in the function call.
The second case I like better, but it is still bad programming style to rely on such parameter collecting. Perhaps better not document it.

I this [1,2,3,4] is not good.

@kedashoe:

The second one seems the most likely extension of how we do things in Ramda
I agree with this, the other cases are not important enough to introduce breaking changes

The trouble, of course, is that this is a long-standing bug, probably from when we first separated off the internal curry2, curry3, ... from the public curry, curryN.  It's really hard to know how people might have taken advantage of it over the years.  Or maybe that's not even possible.  Hmmm....
@semmel:

What about [1,2,3,4]?

You're right.  That would be another candidate, and in some sense the inverse of [1, 2, 3, 10].  One says, "Keep any extra parameters the first time they're collected, and include them in the final call".  The other says, "Ignore any extra parameters until you hit the final call, and then include them.  And although several times I'd wished we had done [1, 2, 3] -- "Ignore all extra parameters," I do think at this point we're better of with [1, 2, 3, 4, 5, 6, 7, 8, 9, 10].  The days of defaulted parameters that don't contribute to the arity seems to make this more reasonable.
When I'm in front a computer rather than my mobile phone, I'll test how this PR's code would handle that scenario.  Or @manyuemeiquqi, feel free to add a test case like this.

@kedashoe:

第二个似乎是我们在 Ramda 中做事方式的最有可能的延伸
我同意这一点，其他情况还不够重要，不足以引入重大更改

当然，问题在于这是一个长期存在的错误，可能是从我们第一次将内部curry2、curry3...与公共curry、 ...分开时开始的curryN。真的很难知道这些年来人们如何利用它。或者也许这根本不可能。嗯……
@semmel:

又怎样呢[1,2,3,4]？

你说得对。那将是另一个候选者，并且在某种意义上是 的反面[1, 2, 3, 10]。有人说，“在第一次收集任何额外参数时保留它们，并将它们包含在最终调用中”。另一个人说，“忽略任何额外的参数，直到你完成最后的调用，然后将它们包括在内。尽管有好几次我希望我们已经这样做了[1, 2, 3]——“忽略所有额外的参数，”我确实认为在这一点上我们是更好的是 with [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]。默认参数对数量没有贡献的日子似乎使这更合理。
当我面对电脑而不是手机时，我将测试此 PR 的代码如何处理该场景。或者@manyuemeiquqi，请随意添加这样的测试用例。

Well, i update pr with the expect of [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]. The thought of modify code of currN which i update is to satisify all placeholder.

ty @manyuemeiquqi . I'll plan to release 0.29.1 at some point next week


What was it like to learn Ceylon?

We’ve recently started a project to find the best way to design our tracks, in order to optimize the learning experience of students.
As a first step, we’ll be examining the ways in which languages are unique and the ways in which they are similar. For this, we’d really like to use the knowledge of everyone involved in the Exercism community (students, mentors, maintainers) to answer the following questions:

How was your experience learning Ceylon? What was helpful while learning Ceylon? What did you struggle with? How did you tackle problems?
In what ways did Ceylon differ from other languages you knew at the time? What was hard to learn? What did you have to unlearn? What syntax did you have to remap? What concepts carried over nicely?

Could you spare 5 minutes to help us by answering these questions? It would greatly help us improve the experience students have learning Ceylon :)
Note: this issue is not meant as a discussion, just as a place for people to post their own, personal experiences.
Want to keep your thoughts private but still help? Feel free to email me at<EMAIL_ADDRESS>Thank you!

You cannot give anyone a reference to this in your initialiser, as stated in https://ceylon-lang.org/documentation/1.3/tour/initialization/. As the page states, "Unfortunately, these rules make it a little tricky to set up circular references between two objects." This comes up as an issue in exercises like react, and perhaps others that are not yet implemented.

EBWODP: In general, it seemed to me that in most instances where the language design had a choice between "make the rules strict to forbid people from doing the wrong thing (but also sometimes forbidding programs that would otherwise be valid)" and "make the rules lenient to allow more programs (but some of them will do the wrong thing)" Ceylon chose to make the rules strict. The "can't give anyone a reference to this in your initialiser" is just one example (compare to Kotlin's handling - it's one of the few times you can get a NullPointerException in Kotlin).

EBWODP: https://kotlinlang.org/docs/reference/null-safety.html "An uninitialized this available in a constructor is passed and used somewhere ("leaking this");"

A characteristic of Ceylon that is rare is the presence of union types and intersection types in the type system. It's a little hard for me to tell how widespread this is among other languages since searching for the term sometimes gets things mixed up with C's union or a tagged union, common to many languages. And based on one's definition of these concept, one might argue just how much difference there is between them.
Of the languages known to me, the ones with the most similar feature would be TypeScript (Union and intersection types: http://www.typescriptlang.org/docs/handbook/advanced-types.html) and Crystal (Union types: https://crystal-lang.org/reference/syntax_and_semantics/union_types.html; no intersection types).
I have not thought carefully about whether there would be an exercise that would require the student to use intersection types, but some exercises of the Ceylon track do use union types to describe the possibility of an error: hamming, largest-series-product, rna-transcription.

EBWODP: With some last-minute research, Today I Learned about the presence of union and/or intersection types in Java and Scala. Updated list to list the following:

TypeScript: Union and intersection types: http://www.typescriptlang.org/docs/handbook/advanced-types.html
Crystal: Union types: https://crystal-lang.org/reference/syntax_and_semantics/union_types.html; no intersection types.
Java in certain limited contexts: Union types allowed in catch https://docs.oracle.com/javase/8/docs/api/javax/lang/model/type/UnionType.html; Intersection types seem to be allowed more generally https://docs.oracle.com/javase/8/docs/api/javax/lang/model/type/IntersectionType.html but are most commonly used to denote that a type parameter extends two interfaces.
Scala: Intersection types: http://dcapwell.github.io/scala-tour/Union and Intersection types.html; no union types.

https://en.wikipedia.org/wiki/Intersection_type has section https://en.wikipedia.org/wiki/Intersection_type#Comparison_of_languages_with_intersection_types

We're closing this issue as it was part of our research for the v3 version of Exercism which has just been released.
Thanks everyone for chipping in! It has been greatly appreciated.


unsupported keys (Control)

I'm trying to set control+[right arrow]

Aha, I always think arrow keys cannot be set as shortcut keys, I will fix it, thanks!

Hi @RaphyRaph , v0.3.0 has been released, this problem should be solved, you can try it now :P

Resolved, thx!


Ola Website Clone

Description
Hii I'm a GSSoc22 contributor and I'm willing to make a pull request in this repository on my project which is Clone Of Ola Website
The idea behind this project
This is a very mini project which looks similar to the famous cabs website OLA
Please refer to the images below:

Code of Conduct

[X] I follow Contributing Guidelines of this project.

#376


DONOTMERGE rstmgr bug rep 060122

While cleaning up rstmgr regression with https://github.com/lowRISC/opentitan/pull/12901
https://github.com/lowRISC/opentitan/pull/12932,
I found this issue.
Test basically trigger random scanmode inputs with scan_rst_ni, and sometimes
it can trigger reset consistency error as figure attached.
while parent reset is off, if scan mode is triggerred, child reset can be toggled and
hit consistency error condition. This test hits this condition in two blocks (u_daon_lc_aon, u_daon_sys_aon)
run command :
./util/dvsim/dvsim.py ./hw/ip/rstmgr/dv/rstmgr_sim_cfg.hjson -i rstmgr_sec_cm_scan_intersig_mubi -s<PHONE_NUMBER> -r 1 --waves -v m
I will attach figure after this.

@arnonsha
I think this should be fine.
When we activate scanmode the system is really in an entirely different state. All the flop paths will eventually be overriden and the alert and related escalation is not really something that we care about any longer.

Thanks for confirming. Closing issue now.


camera metadata is redundant

Every thing in metadata can be derived from the image itself.

Camera calibration parameters (i.e. camera intrinsics) in the metadata.


use pathlib for numsyls function, fix bug with path

currently the way that numsyls finds .wav files in path1 causes it to raise an error when the user does not add a final slash, e.g.
 poetry run songdkl numsyls ${PCB_SONG_ROOT}/g99o87
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/pimienta/Documents/repos/coding/vocal/songdkl/src/songdkl/__main__.py", line 18, in main
    numsyls(path1=args.path)
  File "/home/pimienta/Documents/repos/coding/vocal/songdkl/src/songdkl/numsyls.py", line 85, in numsyls
    song = impwav(path1 + file)
  File "/home/pimienta/Documents/repos/coding/vocal/songdkl/src/songdkl/audio.py", line 11, in impwav
    wav = wavfile.read(a)
  File "/home/pimienta/anaconda3/envs/vak-env/lib/python3.6/site-packages/scipy/io/wavfile.py", line 544, in read
    fid = open(filename, 'rb')
FileNotFoundError: [Errno 2] No such file or directory: '/home/pimienta/Documents/data/doi_10.5061_dryad.8tn4660__v1/pcb_data/song_data/g99o87g99o87.20050523-19.wav'

because of the way the functions builds paths to .wav files
Better way would be to just use pathlib and then iterate over sorted(Path(path1).glob('*.wav'))

Fixed by #46


Hostnames starting with numbers: 1.example.com

Hi,
check_ssl_cert.pl does not like my hostname:
% ./check_ssl_cert.pl --host 1.example.com |head -n3
invalid host '1.example.com' defined: not a valid hostname or IP address

usage: check_ssl_cert.pl [ options ]
%

The regex hostnames are matched against expects them to start with letters ([A-Za-z]).  However, numbers in hostnames are perfectly valid.
Kind regards,
Frank.

I've updated the nagios-plugins to use the newer lib, that should work now, you can reopen if needed.


User Account - Implementation

Sign up with

[ ] email/password
[ ] Google

Sign in with

[ ] email/password
[ ] Google

User profile

[ ] Set profile picture
[ ] Set display name
[ ] Set ranger ID to be used with ELOC device

Management

[ ] Change email
[ ] Change password
[ ] Delete account

@josephx86
Just for the record: We have decided to make the Ranger ID into User ID. That's more universal.
So  guess User ID is the same with "display name" of the user account?

The idea for the display name is that it is the name displayed on the profile. Ranger ID (now User ID) on the other hand, is for the ELOC devices to use.


SVN Comments do not work as expected

The MergeProcessor writes the content of 2 commit messages within one merge unit. There should always be only one original message, the correct one in best case.

Bug report
Expected Behavior - What where you expecting to happen?

Merge message should only contain the message of the original commit.
Current Behavior - What happens?

Merge message contains more than the original commit message. (e.g. from the last 2 commits).
Possible Solution

What are the steps to reproduce this issue? (for bugs)

Create commit with revision 1.
Create commit with revision 2.
Create a merge and merge over mergeprocessor from 2:3.

Context

Any logs, error output, etc?
Your Environment

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):

Notes and further information
Problem is located when querying for the commit message. The log statement must only be e.g.:
svn log <url> -r 1:1
not: svn log <url> -r 1:2)

Hi Josef,
thanks for identifying the issue. 👍
We were already able to reproduce the problem and fix it as soon as possible.

@StefanFranzWeiser - this could be closed (as #23 is merged), right? Thanks!

Fixed with #23 and closed


how to install Deedle in ubuntu?

how to install Deedle in ubuntu?

I think you have to install .netcore first. Hope the following link could help : https://dotnet.microsoft.com/download/linux-package-manager/ubuntu18-10/sdk-current

You may take a look at Get started with F# with core cli after installing dotnet sdk on ubuntu.
https://docs.microsoft.com/en-us/dotnet/fsharp/get-started/get-started-command-line
Then add Deedle package using cli or edit csproj/fsproj directly.


Discord invite link is broken

The Discord invite link in README.md has stopped working.
If you do make a new link, make sure to set it to never expire and not have a limit on the number of users.

Thanks a lot for the issue! The invitation link is updated now.


add --project-dir flag to allow specifying project directory

In particular, this is the directory that contains the dbt_project.yml
file and all the related project files and directories.
Without this flag, it is necessary to cd to the project directory before
running dbt.
Please note that this change does not include unit tests, so is not ready for merging yet.
See https://github.com/fishtown-analytics/dbt/issues/1544

Looks good to me! I just kicked off tests, I'm not sure this will make it into wilt-chamberlain, but if it not I'll take care of the rebasing onto the next release branch.

Sounds good!  I found a stray tab character, so pushed a quick fix.

As usual github is displaying the old results here, tests did pass: https://dev.azure.com/fishtown-analytics/dbt/_build/results?buildId=244

Thanks for your contribution @heisencoder! Merging this one - it will go out in 0.14.0 :)


fix keras requirements

I think recurrentshop 1.0.0 requires keras 2.0.0 or later.

LGTM, Thanks!


[SQL Migration][Hotfix] Remove parameter from IR validation

This PR removes the encryptConnection property from the IR validation request body, which was breaking certain customer migration workflows (e.g. see https://github.com/microsoft/azuredatastudio/issues/21769) when it was being hardcoded to true. A longer term fix is in the works to properly respect the user's provided values for encryptConnection as well as trustServerCertificate, which requires backend RP changes.
This PR also vbumps the extension, as discussed internally, we are looking to release this ASAP to unblock stuck customers who cannot proceed past IR validation (along with an ongoing RP hotfix deployment).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 42.019%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
28646

Relevant Lines:
63314

💛  - Coveralls


Add document.fonts API

Draft spec: https://drafts.csswg.org/css-font-loading/
Available in Chrome 80 / Firefox 74

Already covered by https://caniuse.com/#feat=font-loading and https://caniuse.com/#feat=mdn-api_document_fonts


Documentation: copy paste work :)

At http://phonon.quarkdev.com/docs/utility we see:
Text Alignment
Left Aligned
Use the .text-left class on the element.
Center Aligned
Use the .text-left class on the element.
Right Aligned
Use the .text-left class on the element.
Justify Aligned
Use the .text-left class on the element.
Looks like someone forgot to change the class names.

little mistake, will be fixed in next version of docs...

Fixed. Thank you :)

Last remaining http://phonon.quarkdev.com/docs/utility
Right Aligned
Use the .text-rught class on the element.

Thanks.. :+1:


plugin not recognizable with elasticsearch 5.6.4

# curl -X GET 'http://localhost:9200'
{
  "name" : "WAVImbK",
  "cluster_name" : "elasticsearch",
  "cluster_uuid" : "f70CqONkSmum0djcddQjRg",
  "version" : {
    "number" : "5.6.4",
    "build_hash" : "8bbedf5",
    "build_date" : "2017-10-31T18:55:38.105Z",
    "build_snapshot" : false,
    "lucene_version" : "6.6.1"
  },
  "tagline" : "You Know, for Search"

# /usr/share/elasticsearch/bin/elasticsearch-plugin install lmenezes/elasticsearch-kopf/v2.1.2
ERROR: Unknown plugin lmenezes/elasticsearch-kopf/v2.1.2

see https://github.com/lmenezes/elasticsearch-kopf/issues/390 and the respective answers


ssh: Use ed25519 algorithm instead ECDSA

Key generated using ecdsa algorithm is causing issue for podman remote
connection on podman desktop side because the library they consume
doesn't have support for this algorithm. This PR is switching the ecdsa
to ed25519 which is supported by the library consumed in podman desktop.
[0] https://github.com/containers/podman-desktop/issues/8351
[1] https://github.com/mscdex/ssh2/issues/1375

/retest

Can you list the testing steps?

Can you list the testing steps in the PR description?

https://github.com/containers/podman-desktop/issues/8351 have steps around how it can be tested, I also added the steps here.

Can you list the testing steps in the PR description?

What i did to test was, ensure  running crc start was successful with the 4.16.4 bundle,
then verified i can ssh into the crc VM using the new ed25519 key using:
$ ssh -i ~/.crc/machines/crc/id_ed25519 -p 2222 -oUserKnownHostsFile=/dev/null -oStrictHostKeyChecking=no core@localhost`

Thanks @praveenkumar and @anjannath . I tested and it works for me too

there's a typo in this command:

$ podman system connection add crc-root --identity "C:\Users<username>.crc\machines\crc\id_ecdsa"  "ssh://core@<IP_ADDRESS>:2222/run/podman/podman.sock"

the path to the ssh key should use the ed_25519 key so C:\Users\<username>\.crc\machines\crc\id_ed25519


Add CONTRIBUTORS file

Add CONTRIBUTORS file
This PR is created automatically by Matks PrestaShop Repositories Bulk Editor

This change is

Thanks @matks


Bottom sheet icons visual bug in post preview while using WebView

Please see the screenshot and the bottom sheet. On my device the icons are either missing height or they are too wide.
I'm using Galaxy S22 and the play store version. Should I provide something more to pin this down?

I'm fairly sure this was fixed with some changes I pushed yesterday. In case its not working for you once you've tested the new version please open another issue. This bug does not manifest on my machine™ so I can't verify it but I feel fairly confident at least :)


Web Audio API and Chrome 70

The Web Audio autoplay policy will be re-enabled in Chrome 70 (October 2018) and it might require changes to hark (?). See https://goo.gl/7K7WLu for more information

It seems that this has no effekt on peerconnection audio at this time. But notifications will not play until the user interact somehow with the webpage. This will be propably resolved by a "this site uses cookies dialog"


Add ActionId for etor-ti

This PR adds the actionId as part of the http header of the REST transport, when specified in the org settings by adding actionId: header.reportFile.actionId under headers.
Test Steps:

Work in progress

Changes

Include a comprehensive list of changes in this PR
(For web UI changes) Include screenshots/video of changes

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

@halprin I'll look into it, most likely it will need to be the received actionId instead of the send actionId.

Did you mean to delete the .idea folder from the repo?

Hmm. Don't know why they have it. I'll leave it alone and put it back. I had to delete it as I couldn't build the application.

@oslynn Just double checking if RS has a threat model in case I need to update it.


Fixed divison by zero bug in DistanceWeightedSampling in gluon example

Description
Sample selection for training is based on a vector of computed probabilities that come from distance weights. In the current implementation these weights can become zero (especially at random initialization) when distances to all other neighbors are zero.
Zero weights lead to nan bugs in the model, this commit is supposed to fix it by changing those zero weights not being divided by zero any longer.
This example project has no unit test. :(

@safrooze Indeed the code is not hybridizable however this PR is not meant to fix that. See my last commit that address the issues you mentioned.


incorporate cluster label fix

friendly ping here @bwplotka @TheSpiritXIII :)

I think this is happening because the release-0.6 branch also includes changes to the underlying k8s library.
Lemme open up a release branch just for release-0.6.2 to minimize the net changes.


Namespaces listed in "autoInjectionNamespaces" inconsistent with actual namespace labels

Describe the bug
A clear and concise description of what the bug is.
I encountered a situation when I had a test namespace which was listed in the autoInjectionNamespaces list of the Istio Custom Resource, but the necessary labels (istio-injection=enabled,istio-operator-managed-injection=enabled) were not present on the test namespace itself which should have been the case.
Steps to reproduce the issue:
Please describe the steps to reproduce the issue.

At first, I had a test namespace which was listed in the autoInjectionNamespaces list of the Istio CR and the necessary labels (istio-injection=enabled,istio-operator-managed-injection=enabled) were present on the test namespace.
I deleted the test namespace
I recreated the test namespace

Expected behavior
A clear and concise description of what you expected to happen.
I consider two possible solutions:

When the test namespace is deleted, it could also be removed from the autoInjectionNamespaces list of the Istio CR. In this case, when the namespace is recreated, the user has to modify the Istio CR to include the test namespace in the autoInjectionNamespaces list if they want to enable automatic sidecar injection on that namespace. This would mean an additional manual step for the user, but we could be sure that this is what the user wants (see the other possibility).
When the test namespace is deleted, it stays in the autoInjectionNamespaces list of the Istio CR. When it is recreated, an automatic reconciliation happens and the labels are attached to the newly created namespace. This solution would be more convenient to the user as it happens automatically, but could lead to issues if it is not actually the user's intention to enable automatic sidecar injection on that newly created namespace.

I might lean towards the first approach. Even though it involves a manual step, this way we can be sure this is what the user wants and could avoid issues when the user don't want to enable automatic sidecar injection on that namespace. However, I'm not sure that the operator modifying it's own CR would be a good idea that's why the second approach might be better yet.

I favor option 1, as after deleting a namespace k8s should not hold any references to it anymore...
any updates here?

Hi @Morriz,
Thanks for sharing your opinion!
Unfortunately, we haven't dealt with this yet, but we are happy to accept PRs. Otherwise, you'll be able to follow the progress of this issue here.

For further reference:
Solved with the second listed possible solution which is:
When the test namespace is deleted, it stays in the autoInjectionNamespaces list of the Istio CR. When it is recreated, an automatic reconciliation happens and the labels are attached to the newly created namespace.


Issue #555 | Java Solution for problem no. 371

What have you Changed
Added Java solution for problem. Runtime: 0 ms, faster than 100.00% of Java online submissions.
Issue no.(must) - #555
Pr will be close and marked as spam. If issue number not found or issue was assigned to someone else.
Marking as spam can block your account from HacktoberFest.
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me if not it will be marked as spam.
[x] My file is in the proper folder
[x] I am following clean code and Documentation.
[x] I have added the title and what program will do first in the file
[x] I have named the file as (Problem #). (Problem Title(in Camel Case)).(extension)
ex. 2. AddToNumbers.py

README - How to Contribute

You didn't make the required changes.


conda: building mystran fails

I am running into this issue:
ninja: build stopped: multiple rules generate $SRC_DIR/Binaries/mod/allocated_memory_use_ifs.mod.

using this commands to build mystran:
cmake -G "Ninja" -B build -S . \
      -D CMAKE_BUILD_TYPE="Release" \
      -D CMAKE_INSTALL_PREFIX:FILEPATH=$PREFIX

ninja -C build install

not sure if this is a ninja error or if this is related to mystran.

I've never built MYSTRAN with ninja. Since it builds correctly with make, it looks like the CMake generator for ninja detected two ways to generate the same .mod file. That makes no sense, since there's one and only one .mod file for each module, there shouldn't be more than one recipe for .mod files. There's no module that shares that file name, and I can't see any paths that could overlap in the CMake script making it see the same module twice... and that'd break building on make anyway.
I'm not familiar with ninja, but since it seems generator-specific, can't you build with make? We got instructions and everything (see BUILDING.md).
I don't know your workflow, but if you must use ninja, I suggest you take it to the CMake forums, because either the ninja generator has a bug or it needs additional/different options (be it in the invocation command or even non-breaking changes to the CMakeLists) to work. You need people that know ninja and can look at the build script to see what CMake is doing wrong.

Thanks for the fast resopnse!
Ninja is nice as it is available for all platforms. Would have been nice if the compilation worked with ninja. Also all the build systems failed with the same error for the different platforms (win, linux, osx) which is also very nice. I am more used to having different errors for all build-systems :)
I will try some other option and maybe come back to this issue if there are other build-problems.

I have some other questions:

Are there some tests to test the build?
what are the .mod (Binaries/mod) files for? Should they be included in the package?

Tests are built into CI. I believe there are 2-3 and are basic code doesn’t
crash tests. It would be nice to have a larger CI testing process that
probably uses python, but at the first level, you need to setup the CI to
be more flexible.
There are additional tests that are run manually and diff’d more manually.
On Wed, Jul 24, 2024 at 9:27 AM lorenz @.***> wrote:

I have some other questions:

Are there some tests to test the build?
what are the .mod (Binaries/mod) files for? Should they be included
in the package?

—
Reply to this email directly, view it on GitHub
https://github.com/MYSTRANsolver/MYSTRAN/issues/83#issuecomment-2248441203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICUWPU4WMI3ZB6U2SP5LLZN7IYTAVCNFSM6AAAAABLLBUHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGQ2DCMRQGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I am running these tests now:
mystran Build_Test_Cases/statics/bar_tube.bdf
mystran Build_Test_Cases/statics/cquad4_pcomp.bdf
mystran Build_Test_Cases/statics/cshear.bdf
mystran Build_Test_Cases/statics/ctria3_pshell_center.bdf
mystran Build_Test_Cases/statics/missing_continuation.bdf

but it fails with:
(%PREFIX%) %SRC_DIR%>mystran Build_Test_Cases/statics/cquad4_pcomp.bdf
 Optional Initialization file:
 MYSTRAN.INI
 does not exist. Internal defaults will be used instead.
 If you want to use the INI file, see the MYSTRAN Installation and Run Manual

 MYSTRAN Version 15.2.0   Apr 07 2024 MYSTRAN developed by Dr Bill Case
At line 167 of file C:\bld\mystran_1722095065904\work\Source\MAIN\READ_INPUT_FILE_NAME.f90 (unit = 5, file = 'stdin')
Fortran runtime error: End of file

any ideas?

I’m pretty sure the missing continuation case is supposed to crash.
Not sure on the other one. Seems like a build issue.
On Sat, Jul 27, 2024 at 6:04 AM lorenz @.***> wrote:

I am running these tests now:
mystran Build_Test_Cases/statics/bar_tube.bdf
mystran Build_Test_Cases/statics/cquad4_pcomp.bdf
mystran Build_Test_Cases/statics/cshear.bdf
mystran Build_Test_Cases/statics/ctria3_pshell_center.bdf
mystran Build_Test_Cases/statics/missing_continuation.bdf
but it fails with:
(%PREFIX%) %SRC_DIR%>mystran Build_Test_Cases/statics/cquad4_pcomp.bdf
Optional Initialization file:
MYSTRAN.INI
does not exist. Internal defaults will be used instead.
If you want to use the INI file, see the MYSTRAN Installation and Run Manual
MYSTRAN Version 15.2.0   Apr 07 2024 MYSTRAN developed by Dr Bill Case
At line 167 of file C:\bld\mystran_1722095065904\work\Source\MAIN\READ_INPUT_FILE_NAME.f90 (unit = 5, file = 'stdin')
Fortran runtime error: End of file
any ideas?
—
Reply to this email directly, view it on GitHub
https://github.com/MYSTRANsolver/MYSTRAN/issues/83#issuecomment-2254187156,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICUWMSDYNAHMLWF365RVDZOPAIHAVCNFSM6AAAAABLLBUHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGE4DOMJVGY
.
You are receiving this because you commented.Message ID:
@.***>

so far I was succesfully in building mystran for linux64, osx64 and win. Now trying to cross compile for linux-aarch64 and osx-arm. On osx-arm I am running into this issue:
``
/bin/sh: /Users/runner/miniforge3/conda-bld/mystran_1722273029649/work/f2c/arithchk: Bad CPU type in executable
Seems like cross compiling is not really supported.

As far as I understand f2c should be a build-dependency, but as mystran downloads a version of f2c and does some custom builds of it, it's compiled for the wron architecture and therefor failing. Any ideas how to fix this issue?

Are you still using ninja? Mystran has never been built with that, so I’m
not surprised it has issues. I strongly suggest just using CMake. I don’t
think we are familiar enough with ninja to fix it easily.
I setup the CI and got mystran building using CMake very easily. Bruno’s
build script seems very robust to me.
On Mon, Jul 29, 2024 at 8:05 AM lorenz @.***> wrote:

As far as I understand f2c should be a build-dependency, but as mystran
downloads a version of f2c and does some custom builds of it, it's compiled
for the wrong architecture and therefor failing. Any ideas how to fix this
issue?
—
Reply to this email directly, view it on GitHub
https://github.com/MYSTRANsolver/MYSTRAN/issues/83#issuecomment-2256587137,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICUWMHCAOF472MEP4DY63ZOZ76TAVCNFSM6AAAAABLLBUHV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGU4DOMJTG4
.
You are receiving this because you commented.Message ID:
@.***>

no, I changed this to make /  mingw32-make. Not using ninja anymore. Btw.: ninja is not a replacement for cmake.
So far the builds went fine and packages are available for osx64, linux64 and win [1].
What I am now trying, is to compile for osx-arm and linux-aarch64 [2] (you can see the azure-ci builds in the PR). Osx-arm needs to be cross-compiled because on azure it's not possible to build for osx-arm directly. But as mystran builds the tool f2c for osx-arm it's not possible to use this tool with osx64.
Not sure how to solve this. I saw that conda-forge has a f2c package [3]. But reading the mystran CMakeLists.txt I see that there is another binary (arithchk) build/used by mystran, so the conda-forge/f2c package is not an easy replacement.
https://github.com/MYSTRANsolver/MYSTRAN/blob/ca3b7ba01063eddab312bf08ff96c97a4b3416e1/CMakeLists.txt#L114
[1] https://anaconda.org/conda-forge/mystran/files
[2] https://github.com/conda-forge/mystran-feedstock/pull/1
[3] https://anaconda.org/conda-forge/f2c

What exactly are you trying to do at the moment?
The initial issue ticket involved failing to compile via ninja, which wasn't a thing we'd thought of supporting.
If this is a ticket trying to expand the platforms supported, I think we should close this ticket and open a new one as a feature request perhaps?

@looooo is there any chance you could provide a bit more information regarding the platforms you're trying to compile? We're very much interested in expanding our compilation support if you're interested in helping us do it.

Sure.
Conda is a package-manager for different platforms. Most packages are available for windows, linux-64, linux-aarch64 (arm-linux eg: rapberry-pi's), osx-64 and osx-arm (the new M1...M3 chips).
Another feature of the conda-packagemanager are the virtual-environments. So you can have for example two environments with the same packages but different versions. Often this is nice for comparing different dependency-versions. But I am not sure if this is interesting for mystran.
Why do I try to package mystran?
I have done a lot of conda-packaging in the past for FreeCAD and dependencies of FreeCAD. Now I saw that FreeCAD also supports mystran as a solver. While it's possible to use available builds of mystran and use it in freecad, I think it's better to have consistent compiler and dependencies. As FreeCAD is already packaged for conda, using the same tools to build mystran is in my mind a good idea.
How are packages build for conda?
Conda-packages are build with a tool called conda-build from repositories that are called feedstocks. The feedstock has all the scripts to build the packages on ci's (mainly azure is used, but it's possible to use other ci's too.) Basically you define all the necessary data in a file (meta.yaml [1]). optionally you can also use build-scripts [2, 3]. In the ci then conda-build builds the library installs it to a host-env and extracts all installed packages in a compressed file which than gets uploaded to anaconda.org.
If you have any questions, please let me know.
[1] https://github.com/conda-forge/mystran-feedstock/blob/main/recipe/meta.yaml
[2] https://github.com/conda-forge/mystran-feedstock/blob/main/recipe/build.sh
[3] https://github.com/conda-forge/mystran-feedstock/blob/main/recipe/bld.bat

azure it's not possible to build for osx-arm directly. But as mystran builds the tool f2c for osx-arm it's not possible to use this >tool with osx64. Not sure how to solve this. I saw that conda-forge has a f2c package [3]. But reading the mystran >CMakeLists.txt I see that there is another binary (arithchk) build/used by mystran, so the conda-forge/f2c package is not an >easy replacement.

I build Mystran without using f2c. You may try that. f2c is for old Fortran compiler. Modern gFortran doesn't need it.


Fix validator SSA check: Phi can use its own value sometimes

Defer removal of a Phi's result id from the undefined-forward-reference
set until after you've scanned the arguments.  The reordering is only
significant for Phi.
Fixes https://github.com/KhronosGroup/SPIRV-Tools/issues/415

@umar456  PTAL

+2

Rebased


feat(vector tiles): Add materilized view

This PR adds a materilized view that should be used via the API to generate vector tiles.

@ff6347 Ist der Training view verloren gegangen?

@ff6347 Ist der Training view verloren gegangen?

Never saw a training view. Did not remove anything. Might be that my base was wrong?

I will merge main into it and see what happens

Der ist dann auch nicht mehr in der finalen File.

Oh. Sorry. I'll add it back in

LGTM


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-30-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4316

Questions ?
Please refer to the Backport tool documentation


Possible info in "UpdateLiveStats"

Hi!
What kind of information can I get via "UpdateLiveStats"?
Can I have my bot's current coordiantes? If yes then how? I'd like to see the path that my bot takes.
So far I have this:
{
"type": "UpdateLiveStats",
"config": {
"enabled": true,
"min_interval": 10,
"stats": ["username", "uptime", "stardust_earned", "xp_earned", "xp_per_hour", "stops_visited", "pokemon_caught", "captures_per_hour", "km_walked"],
"terminal_log": true,
"terminal_title": true
}
}
When I put in stats "locations", "position", "latitude", "longitude" I get an error so that doesn't work.

From comment in code:
    Available stats :
    - login : The account login (from the credentials).
    - username : The trainer name (asked at first in-game connection).
    - uptime : The bot uptime.
    - km_walked : The kilometers walked since the bot started.
    - level : The current character's level.
    - level_completion : The current level experience, the next level experience and the completion
                         percentage.
    - level_stats : Puts together the current character's level and its completion.
    - xp_per_hour : The estimated gain of experience per hour.
    - xp_earned : The experience earned since the bot started.
    - stops_visited : The number of visited stops.
    - pokemon_encountered : The number of encountered pokemon.
    - pokemon_caught : The number of caught pokemon.
    - captures_per_hour : The estimated number of pokemon captured per hour.
    - pokemon_released : The number of released pokemon.
    - pokemon_evolved : The number of evolved pokemon.
    - pokemon_unseen : The number of pokemon never seen before.
    - pokemon_stats : Puts together the pokemon encountered, caught, released, evolved and unseen.
    - pokeballs_thrown : The number of thrown pokeballs.
    - stardust_earned : The number of earned stardust since the bot started.
    - highest_cp_pokemon : The caught pokemon with the highest CP since the bot started.
    - most_perfect_pokemon : The most perfect caught pokemon since the bot started.

So no current position? (I'm asking because that's the most vital stat I need to get)

Exactly, no current position at this time (just checked code)

:(
But thanks for the answer.

@xyc1993 You could create a feature request for this functionality as there are already numerous FR for similar updates to live stats

@Nerkyator Thank you. I was looking for that info too.


Bump kafka CRD version to 3.5.0

Summary

With updates to Strimzi operator, anything below 3.4.0 does not work. Also bumping this because 1.2.z RHBQ 2.13 branch got bumped to 3.5.0 as Kafka seems to be pursuing aggressive update policy.

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Dependency update
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

Why don't we use 3.6 in main as suggested here https://github.com/quarkus-qe/quarkus-test-framework/pull/923 ? I take it it's because of Ghost? You can only bump to 3.5 in 1.3.z

Also, I'd expect tests to fail, that's why I suggested to do it in one PR, while this one can seem clearer, I suppose you tested it and tests pass.

@michalvavrik this is not Quarkus/branch dependent, it's just that the Strimzi operator is pushing the kubernetes kafka object version forwards.
We can push all branches to 3.6.0, but this is what we tested RHBQ 2.13.8.SP3 with, and I didn't want the rest of branches being behind the oldest branch still supported

@michalvavrik this is not Quarkus/branch dependent, it's just that the Strimzi operator is pushing the kubernetes kafka object version forwards.

I thought there is some client communicating with this Kafka, that's why I asked on compatibility. I understand from your answer it's not a problem.

We can push all branches to 3.6.0, but this is what we tested RHBQ 2.13.8.SP3 with, and I didn't want the rest of branches being behind the oldest branch still supported

I am trying to understand why not to use 3.6 against 999-SNAPSHOT / the latest released version. I think there is ask to be more conservative when bumping tested operators / images in non-feature releases, so I can understand why we would use 3.5 in 3.2 branch, but this PR target main branch.

You know, if you wanted this fixed for main branch, you could just do review #923

@michalvavrik this is not Quarkus/branch dependent, it's just that the Strimzi operator is pushing the kubernetes kafka object version forwards.

I thought there is some client communicating with this Kafka, that's why I asked on compatibility. I understand from your answer it's not a problem.

We can push all branches to 3.6.0, but this is what we tested RHBQ 2.13.8.SP3 with, and I didn't want the rest of branches being behind the oldest branch still supported

I am trying to understand why not to use 3.6 against 999-SNAPSHOT / the latest released version. I think there is ask to be more conservative when bumping tested operators / images in non-feature releases, so I can understand why we would use 3.5 in 3.2 branch, but this PR target main branch.

Just to address this with complete explanation - this is nothing on client side. It's just that the Strimzi operator which tests install is keeping on rolling out new API version for kafka custom resources which are the way to configure Kafka deployment provided by such operator.
I agree we should bump it to 3.6.0 api version, but in all branches. We use the same Strimzi operator release stream for all supported product versions (I am not even sure there's a different operator upgrade stream for Strimzi, tbh).

You know, if you wanted this fixed for main branch, you could just do review #923

Sorry, I didn't get to that yet - I was just running through the backlog of stuff left over to do from 2.13.8.SP3.CR1 - I didn't notice that yet.

run tests

@michalvavrik I think I'll actually go forwards with merging your MR and close this, thanks for letting me know!

Closing as this was obsoleted by #923

got it, thanks


change language of the map

May I know how to change the language of the map?
I tried below, but none of them work:

<ng-map language="en" ... >

Once you have google maps api already loaded as English, your lazy load won't affect any because it uses the pre-loaded language.
To make use of lazy-load, please remove


Bug fixes for nested modules.

This didn't work for me, the function 'get_output_sizes_from_module' is never called outside of it's own definition.

Agreed @andimarafioti, this PR has not been merged since the function is never used. I'll close this because it's stale now.


Fix an issue when describe and xdescribe fail without a callback (#1744)

Now describe fails with a helpful error message whereas xdescribe doesn't execute the callback if it's not supplied.
Closes #1744.

Hi, thanks for the PR!
You shouldn't build mocha.js, that is only done when a release is prepared by one of the maintainers.
Also, @mochajs/mocha, is callback the appropriate word here? Or is something like 'suite definition' used?

Hey!
Thanks for the prompt feedback! I should probably revert changes to mocha.js? Suite definition does sound more appropriate, I would change that as well.

No problemo!
Yep, the PR should have no changes on mocha.js. Regarding the suite definition improvement, you could add it already, but I'd like to know the other maintainer's opinion first before merging.

Thanks for the PR antoval! :) Definitely a helpful change, though it would need to target 3.0.0 like https://github.com/mochajs/mocha/pull/1809
Beyond that, I think it would be worth implementing this change across all interfaces (not just BDD) to be consistent.

ping @antoval

Sorry for a long delay, didn't have a chance to spend more time with this due to traveling. I'm back soon and will make the changes mentioned above, should be quick.

I followed the suggestions above and did the changes against the 3.0.0 release as well as changed the wording ('callback' vs 'suite definition'). I have one question before I commit my changes though. @danielstjules, I checked other interfaces (TDD and qunit). I did the same changes to TDD's suite() whereas qunit's suite() doesn't require a function callback, thus no changes need to be done. Am I missing anything here? Thanks!

Will need to be rebased.

We'll get this added!

added 3a2dae8

merged as e22c407 less mocha.js changes.  @antoval thanks!!


Add Puppeteer to SSR section

Would be worth listing puppeteer for SSR, as described here:
https://developers.google.com/web/tools/puppeteer/articles/ssr

@ebidel suggested the same :)
And yep, should definitely be in!

Landed with #4 👍


Android WebView Video Keyart

Hi all,
I was just updating the sample for this demo: https://github.com/GoogleChrome/chromium-webview-samples
At the moment in https://appr.tc/ there is a div with id videos and at the moment that is sat on top of all content which is an issue on the Android WebView because a piece of key art is added and this results in:

I can get around this in DevTools by applying Opacity: 0 until the video connects.

This does not happen in Chrome M46 on Android, but I looked at some of the javascript and CSS and it was not clear to me what was different.

I think the difference is simply in how WebView and Chrome handle video media. WebView (to the best of my knowledge) will fallback to the Android Video View while Chrome has it's own media stack.

This is a webview issue/side effect, not AppRTC.

Is there any reason for excluding support for WebView though? The fix is to set an opacity of the view before the webrtc session is set up.

Not at all, PR's are welcome ;).

@gauntface , can u elaborate on that?
I have a WebRTC app that runs in the Mobile Chrome but not on my app inside a WebView.
The newtowrk connection and streams seems to work, but the video simply wont stream inside the video. I wonder what I'm missing..

@zaxy78 , even i am facing similar issue. Both Remote video & audio streams are not getting played in the Android Webview. However the Mobile Webview's  streams (Video+Audio) are playing on the remote desktop without any issue.
Requesting WebRTC team to provide a resolution at their earliest as its a Showtopper for Android Webview based use cases.

I have faced this issue(webview is not rendering video) as well, any ideas,

I called mediaPlaybackRequiresUserGesture after setting javaScriptEnabled , it works
       settings.apply {             javaScriptEnabled = true             mediaPlaybackRequiresUserGesture = false         }

WebSettings settings = mWebRTCWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setMediaPlaybackRequiresUserGesture(false);

It works.


36 fix threading memory leak

Update the BAM threading implementation to avoid memory leaks

Tested with bioconda as well: https://github.com/bioconda/bioconda-recipes/pull/40325


Convenience Functions?

The readme states

There are a number of other features in the device model class, such as returning an image of the structure. These features are best explored by reading the code and the function docstrings, as we don't have comprehensive standalone documentation at this time.

I have been going through the code and was not able to identify functions used to plot the simulations/structures.
Maybe you can point me in the right direction?

The Model class has a density method:
https://github.com/google/ceviche-challenges/blob/6731eac81baca696192624b55a51db9b03de9bcf/ceviche_challenges/model_base.py#L216-L217
It returns an image array that one could pass to Matplotlib's imshow() or pcolor() functions. The simulator outputs are scattering parameters and fields:
https://github.com/google/ceviche-challenges/blob/6731eac81baca696192624b55a51db9b03de9bcf/ceviche_challenges/model_base.py#L89-L119
These arrays can also be plotted through Matplotlib.
Hope this helps.

Thanks,
I had seen those but thought I might have missed something else.
Thanks for the quick and thorough response!


Add package name checking to CI

Signed-off-by: Attila Klenik<EMAIL_ADDRESS>

https://travis-ci.org/hyperledger/caliper/jobs/600741810#L506


XML comment fixes

Changes

XML comment fixes.

@jkoritzinsky we have infra-related failure on MacOS again it seems


"WPT tests (too many to display individually)"

Bikeshed tells me

WARNING: There are 56 WPT tests (too many to display individually) underneath your path prefix 'css/css-color/' that aren't in your document.

So I have to go into each WPT directory, do a directory listing, grep out support and ref files, then check manually to find the missing tests.
Glad that bikeshed is so concerned about verbosity, but I didn't find any command line option to actually list those tests which it already knows about. That would be a useful feature.

The current hack around it is to just use a  element and copy out of that. But yes, @frivoal has asked for an option to display them all, too.

All right, so the reason I was concerned about verbosity before is because there was no way to silence the warning for cases, like css-color, where you didn't actually want all the tests that were under your prefix. Now that <wpt hidden> is a targeted way to address that, I can remove the verbosity control, so I've done so now.


Dao token access test

Access Control Added and test passed. Thank you.

I'll proceed to merge this now, cos Wura is supposed to start audits today @developeruche


Double-counting sample values:create entrySpan and singleSpan

Please answer these questions before submitting your issue.

Why do you submit this issue?
[*] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Double-counting sample values:create entrySpan and singleSpan

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
public AbstractTracerContext createTraceContext(String operationName, boolean forceSampling) {
AbstractTracerContext context;
int suffixIdx = operationName.lastIndexOf(".");
if (suffixIdx > -1 && Config.Agent.IGNORE_SUFFIX.contains(operationName.substring(suffixIdx))) {
context = new IgnoredTracerContext();
} else {
SamplingService samplingService = ServiceManager.INSTANCE.findService(SamplingService.class);
if (forceSampling || samplingService.trySampling()) {
context = new TracingContext();
} else {
context = new IgnoredTracerContext();
}
}
  return context;

}

finish()
if (!segment.hasRef() && segment.isSingleSpanSegment()) {
if (!samplingService.trySampling()) {
finishedSegment.setIgnore(true);
}
}

Requirement or improvement

Please describe about your requirements or improvement suggestions.

Yes, it is re-counting, because in agent sampling rate, you want to reduce the CPU or network costs. Then, a single-span segment without ref is most likely meaningless. So we ignore it.
Your question is?

@wu-sheng no question, tks


Add input format SLF

Because it was an easy way to get access to some sample data I made a parser for SitaWare SLF files. Can't read all location types yet, but working on it and it works for all points, lines, and polygons. (And some mulitpoint symbols.)

can you add example of SitaWare SLF file to you sourse code?

I will see if there is any sample data I can include. The main input format for the library is however plain GeoJSON, and hopefully I will be able to create a draft of the format specification within a week or so.
What the SLF parser does is to parse a SLF file from XML to GeoJSON and then input it into the library.
If you have a GeoJSON file that has points with an attribute called SIDC you can simply provide that directly into ms.GraphicsLayer(GeoJSON).
It is also possible to use ms.format.GeoJSON(geojson, mapping) to remap attributes to new attribute names.

great work, thanks a lot!


[WFLY-11674] JTA documentation to be enriched with a section about synchronization

https://issues.jboss.org/browse/WFLY-11674
addition to the JTA documentation article about how to register synchronization

hi @yersan , thanks a lot for your review. I will try to do better next time :-)
but, for making my life easier :laughing:  (take it as a joke, I consider my errors as a silly typo issues that I should avoid next time) you can consider using suggestions (https://thenextweb.com/dd/2018/10/16/github-launches-suggested-changes-to-make-it-easier-to-collaborate-within-pull-requests/). I can apply your suggestiong directly to the PR with one click in the github UI.

Thanks @ochaloup I didn't know about the possibility of using suggestions, I'll use them next time


AC Battery CT clamp on Eddi not added

I've installed ha-myenergi intergration and it has located all my 3 devices and created 31 enteries.
I have a Eddi, Harvi and a Hub
The Eddi has a CT clamp attached to ectt3 and configured as "AC Battery", however it's not being found by the intergration.
Using acurl I am able to retrieve the data for this CT clamp fine
I have redownloaded the intergration and restarted HA but nothing has updated. both the System Options for myenergi are venabled.
const.py lists the version as VERSION = "0.0.16", which is the same as on the latest version on github.
Data retrieved from Eddi using curl:
"eddi": [
    {
        "sno": 14467978,
        "dat": "21-12-2021",
        "tim": "18:42:43",
        "ectp2": 582,
        "ectp3": -14,
        "ectt1": "Internal Load",
        "ectt2": "Grid",
        "ectt3": "AC Battery",
        "bsm": 0,
        "bst": 0,
        "cmt": 254,
        "dst": 1,
        "div": 0,
        "frq": 50.02,
        "fwv": "3200S3.051",
        "gen": -4,
        "grd": 578,
        "pha": 1,
        "pri": 1,
        "sta": 1,
        "tz": 0,
        "vol": 2402,
        "hpri": 1,
        "hno": 1,
        "ht1": "Tank 1",
        "ht2": "Tank 2",
        "r1a": 0,
        "r2a": 0,
        "rbc": 0,
        "rbt": 1,
        "tp1": 127,
        "tp2": 127
    }
]

I’ve noticed that HA does not update the integration, so I use the HA file manager and upload the files separately to the custom folder, it works that way. I also manually install the Python files.

G6EJD

I've manually downloaded the folders & files and copied them to the custom_components folder and restarted etc.
But no change, i still do not have the battery showing under the Eddi.
I believe that the const.py file may not have been updated with the new version number.

Johan afaik doesn’t have an Eddi so it could be there is no CT detection included yet, I haven’t checked the code yet to see if that’s so.
Works ok for a Harvi, but maybe not Zappi too.

G6EJD

The intergration is picking up:

sensor.myenergi_eddi_xxxx_power_ct_internal_load - "ectt1": "Internal Load" -  "ectp1" - the internal CT clamp which measures what is diverted to the immersion
sensor.myenergi_eddi_xxxx_power_ct_grid  - "ectt2": "Grid" - "ectp2" -  import/export to the grid

but not "ectt3": "AC Battery" - "ectp3"

These will hopefully resolve the issue - #309 and https://github.com/CJNE/pymyenergi/pull/4

Thanks @sparks1372, will include this in the next release. @G6EJD is correct, I don't have an Eddi so I missed this :)

This issue needs to be closed...


Gateway node 3887

As we gradually start to allow full public node participation in the network, we will start by deploying gateway nodes as an entry point. Gateway nodes can only consume from the internal network, they cannot propagate/gossip/publish.
This is a temporary solution to prevent flooding attacks etc.
Below is a crude diagram to illustrate the point.
A gateway node that is conditionally compiled (d in the diagram),
d will be open to the wild - A, B, C will not be.

@dkijania do these tests make sense?

@cong-or looking good! i see one more potential test


libhfcommon/util: Don't use pthread_once in rnd

Since this is thread local storage it can set the value directly rather than needing to go through pthread_once. This gives a small speedup, perhaps 4%.

Thanks!


L2: claimStakeEnabled flag in L2Migrator

What does this pull request do? Explain your changes. (required)

Adds a claimStakeEnabled flag in the L2Migrator that by default is false and can be switched to true once the off-chain review period for the snapshot used in claimStake() is over. Originally, I thought we could delay storing the snapshot root in MerkleSnapshot until the end of the review period. But, given that the merkle-earnings-cli tool already reads the root to be validated from the MerkleSnapshot contract and given that it is generally easer to query for a root to be validated during the review period from the contract, I think it is easer to:

Immediately store the root to be validated in the MerkleSnapshot contract such that anyone can query it with the snapshotID i.e. keccak256("LIP-73")
Keep the claimStakeEnabled flag in the L2Migrator set to false during the review period
Queue an update in the Governor that sets claimStakeEnabled to true that can be executed after the review period

Note: There is no auth for the new setter for the claimStakeEnabled flag yet. #32 is tracking the addition of auth for the entire contract.
Specific updates (required)

See commit history.
How did you test each of these updates (required)

Added unit tests.
Does this pull request close any open issues?

N/A
Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
174

Relevant Lines:
174

💛  - Coveralls


Add Source Value

We now have source code, name, but we need to add source_ value for those that do not have the source vocabs in yet. This would also allow us to do some quality control.

I'm checking with members of our team to see if this poses any restrictions - I seem to recall that there are some DBs that do not want you to share the source values this way. That said, this can be added to the package and make it optional to turn off. We can then raise a warning when it is turned on for audit purposes.

This would not be a problem for us as long as we can check what we share, which we can in the csv files.

Fair enough. I've confirmed that there are some data providers that will not allow us to report the source_values. I'll work to make this an option for running the overview - we can provide a way to override this option so we can always export the source values.
The other thing we should consider: a small cell count. Some data providers restrict what can be reported (i.e n < 10) so we could enforce this during the export. Let me know if you agree with this approach.

yes I agree with a switch for this (for all output on DUS).

Ditto.


Use the default travis grunt.

We no longer need to install grunt manually; the travis-ci.org
environment now provides it for node projects.
Removing the install step also lets us run on the new
container-based infrastructure.

Looks good to me :smile:

Thanks for the review!


The execution output will highlight fake errors and warnings

Demo:
fn main() {
    let _: std::error::Error = "warning:🤔...";
}

This also affects runtime output to stderr e.g.
fn main() {
    eprintln!("warning:🤔...\nerror[E9999]:👀...");
}

Yup. It's all powered by regex-based syntax highlighting. Any suggestions on how to improve it?

A partial solution would be to make warnings and errors to match the start of line
Prism.languages.rust_errors = { // eslint-disable-line camelcase
  'warning': /^warning:.*/m,
  ...

This will stop highlighting std::error::Error which would be good enough for me. Users can still perform the eprintln! trick but that's not really a real problem 😄.

Alternatively we could run cargo with --color always and parse the ANSI escape code manually 😛

match the start of line

As I was submitting, I realized that would probably be the right step, but I figured I'd let you tell me if there was something better. Isn't there some JSON output or something?

we could run cargo with --color always and parse the ANSI escape code manually

I think thats the way ye olde playground worked, actually. I'm sure there's a JS library that does it for us too. I wasn't a super fan of trying to deal with that though.

'warning': /^warning:.*/m,

Hmm, I used /^warning:.*$/m,. Do you know if having the $ is good/bad here? I'm surprised it seems to work without it... but I guess it just goes to the end of the line?

@shepmaster A . will not match new lines, so it is fine without the $.

K. Then I'll use the $ just because it's more immediately obvious at first glance.


onIndexChanged setState change shifts Swiper component until tapping resets to correct style

OS 14.4
Version
Which versions are you using:

react-native-swiper v1.6.0
react-native v0.62.13

Expected behaviour
When user swipes on component, it should move to next page. Currently I have onIndexChange triggering a change in state (for a variable that isn't the index -- it is something to change a tab header). setState should execute properly and the page change should animate properly with the left hand side of the page stopping at the beginning of the parent view
Actual behaviour
The setState changes properly, and the swipe to the next page animates properly; however, the page swiped to goes past the parent view's margins (about 40 pixels or so). It remains off the end until I click anywhere within the Swiper view and then it immediately goes back to how it should be (not shifted off the edge). I have tried specifying height, width, container style, and index value, but nothing has worked except simply not calling setState. I have also tried onMomentumScrollEnd or using a setTimeout with both trigger functions with the same results. Interesting to note that it does not happen to the first page, but all after the first one (going in either direction) even when the initial index specified isn't the first page.
How to reproduce it>

loop is false, showPagination is false, onIndexChanged triggers a setState for a toggle value not used anywhere within the Swiper children.

@salp13 any luck with this? Running into the same issue

I was experiencing this issue as well ^
I was wrapping my <Swiper> with some padding in the parent above.
// Broken version

<View style={{ paddingHorizontal: 24 }}>
    <Swiper>
    ...
    </Swiper>
</View>

I was able to fix the issue by moving the padding component inside of the <Swiper> like so;
// Fixed version

<Swiper>
    <View style={{ paddingHorizontal: 24 }}>
    ...
    </View>
</Swiper>

I think @ryan-exe 's solution is onto something. I ran into very similar situation. Did not dig into the code but my educated guess is that some calculation (maybe the scrolling offset or the transition distance for animation) is based on width of the screen, not the actual width of the component.
For my case, as long as I have any margin or padding on the parent container of the Swiper, setting state in onIndexChanged will cause the issue described above. The way I solved my problem is to let the Swiper take the entire width of the screen, and use its containerStyle prop for the spacing I needed.

Have the same problem here. I don't have any padding and I can't let the swiper take the entire width of the screen as it acts as a popup/overlay inside my screen. Is it dead ?


Implement internal links

I referenced the react-pdf commit that uses the pdf.js Api to make this work correctly.

Hi, I wondering if it is really necessary to add src/LinkService.js instead of directly using import { PDFLinkService } from 'pdfjs-dist/lib/web/pdf_link_service'; in pdfjsWrapper ?

No, it's probably not necessary. I'll go ahead and remove src/LinkService.js

Done

thanks !