ReplyError: MOVED on cluster configuration

I feel like I am missing something obvious, but whenever I talk to the cluster I get the following error:
Unhandled Rejection at: Promise Promise {
ReplyError: MOVED 7918 <IP>   at parseError (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:179:12)   at parseType (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:302:14)  This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason: ReplyError: MOVED 7918 <IP>   at parseError (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:179:12)   at parseType (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:302:14) Unhandled Rejection at: Promise Promise {   <rejected> ReplyError: MOVED 7918 <IP>    at parseError (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:179:12)    at parseType (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:302:14)  } reason: ReplyError: MOVED 7918 <IP>   at parseError (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:179:12)   at parseType (/home/lynx/www/lynxcloud-api-nightly/node_modules/redis-parser/lib/parser.js:302:14)
Everything looks like it is configured correctly, and looking at the documentation this indicates the client is not following the redirects, all IP addresses are pointing to our 2nd master node.
Any suggestion on a possible fix, as I am pretty sure this is more of a configuration issue then a node-redis issue, but unsure what else I can try, I have increased the maxCommandRedirections to 100, useReplicas to true but nothing seems to fix this issue.
I will look forward to your reply

No subcommand SHARDS, running CLUSTER SHARDS I get the following: ERR Unknown subcommand or wrong number of arguments for 'SHARDS'. Try CLUSTER HELP
Running CLUSTER HELP gives the following output

CLUSTER  arg arg ... arg. Subcommands are:
ADDSLOTS  [slot ...] -- Assign slots to current node.
BUMPEPOCH -- Advance the cluster config epoch.
COUNT-failure-reports  -- Return number of failure reports for .
COUNTKEYSINSLOT  - Return the number of keys in .
DELSLOTS  [slot ...] -- Delete slots information from current node.
FAILOVER [force|takeover] -- Promote current replica node to being a master.
FORGET  -- Remove a node from the cluster.
GETKEYSINSLOT   -- Return key names stored by current node in a slot.
FLUSHSLOTS -- Delete current node own slots information.
INFO - Return onformation about the cluster.
KEYSLOT  -- Return the hash slot for .
MEET   [bus-port] -- Connect nodes into a working cluster.
MYID -- Return the node id.
NODES -- Return cluster configuration seen by node. Output format:

<id> <ip:port> <flags> <master> <pings> <pongs> <epoch> <link> <slot> ... <slot>

REPLICATE  -- Configure current node as replica to .
RESET [hard|soft] -- Reset current node (default: soft).
SET-config-epoch  - Set config epoch of current node.
SETSLOT  (importing|migrating|stable|node ) -- Set slot state.
REPLICAS  -- Return  replicas.
SLOTS -- Return information about slots range mappings. Each range is made of:

start, end, master and replicas IP addresses, ports and ids

CLUSTER SHARDS was added in redis 7, try CLUSETR SLOTS instead


Update README_JA-JP.md

The content is the same as the English version, with a more specific explanation of ChatALL.

Thank you!


Gallery, Drop-down buttons have different top and bottom paddings

Notice how, in Flutter's drop-down, the padding at the top and bottom seem to be different. There seems to be more space in the top padding. Also, notice how there is a lot of left-padding in Flutter's drop-down, where in a Google app's drop-down we see left-justified text with minimal left-padding (not sure if either or both are correct here).
From the Gallery:

From a Google app:

cc @HansMuller

Notice how the text is offset a bit in the "SLOW MODE" banner too. My guess is the bug here is with the placement of the text, not the padding.


Add Painter.savePosition/Painter.restorePosition helpers

Not gonna add, as it can be implemented easily on user side if needed.
(and vein has only two cases where it could be used, so it's not worth it)


NLP Notes

Intro to NLP

nltk

gensim

defaultdict

itertools.chain.from_iterable()

tf-idf

Term frequency = percentage share of the word compared to all tokens in the document
Inverse document frequency = logarithm of the total number of documents in a corpora divided by the number of documents containing the term

spacy

polyglot

scikit-learn

CountVectorizer for preprocessing
Error with data in test that is not in training data. Add more training data or remove words from test that isnt in training data.

Naive Bayes Classifier

Sentiment Analysis?

# Create the list of alphas: alphas
alphas = np.arange(0, 1, 0.1)

# Define train_and_predict()
def train_and_predict(alpha):
    # Instantiate the classifier: nb_classifier
    nb_classifier = MultinomialNB(alpha=alpha)
    # Fit to the training data
    nb_classifier.fit(tfidf_train, y_train)
    # Predict the labels: pred
    pred = nb_classifier.predict(tfidf_test)
    # Compute accuracy: score
    score = metrics.accuracy_score(y_test, pred)
    return score

# Iterate over the alphas and print the corresponding score
for alpha in alphas:
    print('Alpha: ', alpha)
    print('Score: ', train_and_predict(alpha))
    print()

Sentiment Analysis

textblob

wordcloud (uses matplotlib)

Bag of Words

CountVectorizer() (is sparse matrix convert to .toarray())

n-grams: a sequence of tokens (for additional context)

from langdetect import detect_langs

Stopwords

from wordcloud import WordCloud, STOPWORDS
from sklearn.feature_extraction.text import CountVectorizer, ENGLISH_STOP_WORDS

Stemming vs. lemmatization

from nltk.stem import PorterStemmer
from nltk.stem import WordNetLemmatizer

Regression

Linear: numeric outcome
Logistic: probability
from sklearn.linear_model import LogisticRegression

Advanced NLP with SpaCy

Word vectors and similarity
Semi-automate labeling with spaCy's Matcher

# Two tokens whose lowercase forms match 'iphone' and 'x'
pattern1 = [{"LOWER": "iphone"}, {"LOWER": "x"}]

# Token whose lowercase form matches 'iphone' and an optional digit
pattern2 = [{"LOWER": "iphone"}, {"OP": "?", "IS_DIGIT": True}]

# Add patterns to the matcher
matcher.add('GADGET', None, pattern1, pattern2)

# Create a Doc object for each text in TEXTS
for doc in nlp.pipe(TEXTS):
    # Find the matches in the doc
    matches = matcher(doc)

    # Get a list of (start, end, label) tuples of matches in the text
    entities = [(start, end, 'GADGET') for match_id, start, end in matches]
    print(doc.text, entities)

TRAINING_DATA = []

# Create a Doc object for each text in TEXTS
for doc in nlp.pipe(TEXTS):
    # Match on the doc and create a list of matched spans
    spans = [doc[start:end] for match_id, start, end in matcher(doc)]
    # Get (start character, end character, label) tuples of matches
    entities = [(span.start_char, span.end_char, 'GADGET') for span in spans]

    # Format the matches as a (doc.text, entities) tuple
    training_example = (doc.text, {'entities': entities})
    # Append the example to the training data
    TRAINING_DATA.append(training_example)

print(*TRAINING_DATA, sep='\n')


docs: add a GOVERNANCE file

TL;DR
Added a GOVERNANCE.md file to establish project decision-making processes and roles.
What changed?
Created a new GOVERNANCE.md file that defines:

Project Owner and Contributor roles and responsibilities
Decision-making processes
Conflict resolution procedures
Future governance evolution plans

How to test?
Review the GOVERNANCE.md file to ensure:

All sections are properly formatted
Content is clear and understandable
Links and references are correct
Document adheres to the dual Apache-2.0 and MIT licensing

Why make this change?
To establish clear guidelines for project governance and provide transparency about:

How decisions are made
Who has authority over different aspects of the project
How contributors can participate
How conflicts are resolved
This structure will help scale the project and manage contributions effectively.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#212
#211  👈 (View in Graphite)
#210
#209
#208
#207
#206
#205
#204
next

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 3, 12:04 AM EST: A user started a stack merge that includes this pull request via Graphite.


mirror addresses

Sorry for question, but i don't found, how to specify that addresses 0x80001234 and 0xA0001234 point to the same location?

Not certain on best approach, but you can file->'add to program' and select same ROM.  In that popup you'll want to click 'Options' where you can specify alternate load address, offset into file, data Len, and block name

Ok, thanks. IDA converts this automatically (when i name dword 0xA000abcd as pointer, it become indicate to 0x8000abcd).
For me, this task looks like good start point to learn how to write plugins for Ghidra ;-)

I asked a Dev in my pull request.  Seems possible both in code and when loading from his answer

Sorry hadn't had much time to play with this.  Do not know how to automate this, but it seems really good from a quick glance with this setup:

load rom at 0x80000000, don't auto-analyze yet
open memory map settings, add new,  add a name, offset 0xA0000000, length 0x180000, click execute check-box, choose byte-mapped in drop down, new address option should already be 0x80000000.
open memory map settings, add new,  add a name, offset 0xC0000000, length 0x180000, click execute check-box, choose byte-mapped in drop down, new address option should already be 0x80000000.
save memory map
auto-analyze


Make react-container-query work with es7 decorators

It would be awesome to be able to use this lib as an es7 decorator.
Right now I get an error when I try to use it :
      if (this.__reactAutoBindPairs.length) {
              ^

TypeError: Cannot read property '__reactAutoBindPairs' of undefined

Thanks for the recommendation. However, I don't think I will implement this before decorator spec becomes official. See Babel decorator doc.

I created a helper:
import { applyContainerQuery } from 'react-container-query'

const containerQuery = queries => component => applyContainerQuery(component, queries)

// ...

@containerQuery({
  xyz: {
    maxWidth: 900
  }
})
export default class Blah extends Component {
   ...
}

Thanks, guys. Decorator pattern no longer works here since the high order component API is complete removed, see 0.7 release.


Errors with Node version 12 and above

When using node version 12 and up, the script errors out at the node-gyp rebuild step. (More info to come.)

Fixed by #14.


[CONTEXT-355] Add File Uploader

Video:
https://drive.google.com/open?id=1vbZ--ahV8wSjd_ArCBvM5qo5rZ4ODP01

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server

[pr-server]
View this change on PR Server


Change updateContentMetadata loglevel

The "WARNING" level of the message when the session is not active can throw off developers as it implies something may not be setup correctly.
Since we are still updating the content metadata but wait until session initialization, changing the log level to "DEBUG" seems more appropriate.

changelog updated to include both changes


cmd/oci-image-tool: use logrus to ease printing to stdout

From @runcom on September 9, 2016 8:46
$SUBJECT - logrus have various and a nicer way of printing logs to stdout with the option to specify the log level (which can then be used to differentiate the validation level in a nicer way).
The current way of embedding stdout in the validation struct isn't as pretty as it would be by having a nicer logger like logrus.
I would also suggest to have a context (not necessary context.Context) object which can be used to embed system stuff like a logger - to be the first argument to function like descriptor.Validate(ctx, ...) so we extract the logger from there and print while validating. (Right now this isn't possible, and the logger should be explicitly passed to Validate changing its definition). @stevvooe wdyt?
@s-urbaniak wdyt?
/cc @vbatts @stevvooe @philips
Copied from original issue: opencontainers/image-spec#288

From @s-urbaniak on September 9, 2016 9:15
logrus is pretty accepted in the ecosystem, and structured logging doesn't
sound too bad. So I am +1 for this.
On Fri, Sep 9, 2016 at 10:46 AM Antonio Murdaca<EMAIL_ADDRESS>wrote:

$SUBJECT - logrus have various and a nicer way of printing logs to stdout
with the option to specify the log level (which can then be used to
differentiate the validation level in a nicer way).
The current way of embedding stdout in the validation struct isn't as
pretty as it would be by having a nicer logger like logrus.
@s-urbaniak https://github.com/s-urbaniak wdyt?
/cc @vbatts https://github.com/vbatts @stevvooe
https://github.com/stevvooe @philips https://github.com/philips
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opencontainers/image-spec/issues/288, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAW8MJU_JyunMxpIqA9OehjG4VLw933cks5qoRzqgaJpZM4J41Ei
.

From @xiekeyang on September 9, 2016 10:1
+1

From @runcom on September 9, 2016 10:4
I'll work on this once we reach consensus and figure out all the other issues about errors/warnings when validating an image, I would love to have a table-like document which lists soft and hard requirement for image validation w/o having to go through the whole spec to figure out MUST and SHOULD. Do you guys think it would be nice/useful to have such a document for oci-image-tool?

From @xiekeyang on September 9, 2016 10:16
It is deep related to #234
In which we are also discussing logrus.
https://github.com/opencontainers/image-spec/pull/234#issuecomment-245789721

From @s-urbaniak on September 9, 2016 10:25
xfref regarding "how to inject the logger": https://github.com/opencontainers/image-spec/pull/234#issuecomment-245876579
I am in favor of classical dependency injection as per https://peter.bourgon.org/go-best-practices-2016/#program-design.

From @wking on September 9, 2016 15:27
On Fri, Sep 09, 2016 at 03:25:13AM -0700, Sergiusz Urbaniak wrote:

I am in favor of classical dependency injection as per
https://peter.bourgon.org/go-best-practices-2016/#program-design.

I'm ok with including a logger in our types to avoid relying on global
state.  But transitioning to logrus could happen in two stages:

Replace log calls with logrus calls using the global state.
Replace global-state logging with explicit logger state carried in
our types.

Both of those can happen independently.  The first should be
straightforward and can happen at any time.  The latter should
probably happen along with or after we reorganize validation, etc., to
be more library-like.

From @runcom on September 9, 2016 15:29

The latter should
probably happen along with or after we reorganize validation, etc., to
be more library-like.

totally agree on this point


Waterfall

Add 1D waterfall plotting (this should also finally end xpdView).
Description
Add callback for making Waterfalls of 1D patterns.
Motivation and Context
Lots of reduced data (even raw data) is expressed as 1D data, visualizing that would be nice.
How Has This Been Tested?
That is a work in progress. I need an ophyd sim hardware that puts out a 1D pattern

xref: https://gitter.im/NSLS-II/DAMA?at=5a319be0a2be4668289a5b03

Codecov Report

Merging #930 into master will decrease coverage by 0.06%.
The diff coverage is 86.29%.

@@            Coverage Diff            @@
##           master    #930      +/-   ##
=========================================
- Coverage   90.37%   90.3%   -0.07%
=========================================
  Files          46      47       +1
  Lines        7613    7734     +121
=========================================
+ Hits         6880    6984     +104
- Misses        733     750      +17

Impacted Files
Coverage Δ

bluesky/callbacks/broker.py
46.55% <ø> (-0.46%)
:arrow_down:

bluesky/callbacks/__init__.py
71.42% <ø> (ø)
:arrow_up:

bluesky/tests/test_callbacks.py
88.52% <100%> (+0.19%)
:arrow_up:

bluesky/callbacks/waterfall.py
82.79% <82.79%> (ø)

bluesky/callbacks/mpl_plotting.py
83.55% <96.15%> (+1.44%)
:arrow_up:

bluesky/callbacks/fitting.py
88.11% <0%> (-0.7%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d770396...3952d01. Read the comment docs.

@tacaswell ready for review!

@CJ-Wright Are you interested in following up on the review comments?

At some point yes, I'm sick today and I just haven't gotten around to it. It is on my to-do list though.

Feel better, @CJ-Wright! :-)

@CJ-Wright is this still a desired feature?

Still worth considering, but CJ has moved on.

can we move the idea into an issue, close this PR and link to it as a possible implementation direction?

@stan-dot Yes, that seems reasonable to me.

as discussed, moved to the issue
https://github.com/bluesky/bluesky/issues/1774


chore(dal): Simplify test migrations

import_pkg by default will import all schemas in pkg if the list is not passed, so we can get away with passing the default import options on tests.

bors merge


chore: Bytecode is buffer not string

After deserialization, bytecode should be represented internally as a buffer, not as a b64 string. We actually had several bugs where we were deserializing bytecode as hex instead of b64, which just silently returns an empty buffer because javascript. This PR removes all conversions back and forth between buffer and b64, and just deserializes in the loadContractArtifact function that handles conversion of all noir artifacts.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5351  👈
#5350
#5349
#5318
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spalladino and the rest of your teammates on  Graphite


adding /register endpoint to local-auth

This adds an explicit /register endpoint to waterlock-local-auth
Throws if the email is already registered

Depends on https://github.com/waterlock/waterlock/pull/76

Changes Unknown when pulling 4769ae4bcd411bcb610308fa3f03a17063f69d99 on wayne-o:master into ** on waterlock:master**.

Hi, and thanks for a cool library!
When do you plan to implement this?
I'm running into this issue due to lack of register module in this module.

I think I just need to update the docs on https://github.com/waterlock/waterlock/pull/76 and we can get it all merged in. I've been away from all this for a while so I will refresh my memory and get on it as soon as I can.
If anyone else has time to update the docs please feel free

Thanks @wayne-o.

Any update on this issue?

I've just merged this in


How do I uninstall the Chrome extension?

It doesn't show up as an extension or app, so I can't figure out how to uninstall it. Thanks!

You can find instructions here: https://support.google.com/chrome_webstore/answer/2664769?hl=en

From the chrome://extensions/, you should be able to manage this and all your extensions.

You should see options to remove or disable the extension.


sion_enable/disable safety

I noticed when adding the pin configure functionality that sion_enable/disable take &self rather than &mut self, while internally mutating a register, this is possibly unsafe as two references can now mutate the state of the pin leading to confusing situations where perhaps multiple references of the pin ask for different sion enable states. It's unlikely, but it is still unsafe.

Good catch. Can we change it to &mut self? It's an internal method, so this shouldn't affect anyone. Would that give us the confidence that we're safe?

I believe &mut self is perfectly fine here. Will change it here tomorrow when I get a free moment hopefully and, crossing my fingers, it doesn't break the compile


How to exclude specific path?

I would like not to run isort on the folder generated by alembic

isort can be configured to skip certain directories (Documentation link). Ideally these settings would be stored in an isort config file in your repository, which would ensure the same configuration options are applied if you run isort locally and if you run it as part of a CI pipeline. Alternatively, though, you can provide specific configuration options via the plugin.


🐛 [Bug] 404 Page shortly visible when navigating to localhost

:bug: Bugreport

404 Page shortly visible when navigating to localhost

Steps to reproduce:

login
go to http://localhost:8080/overview
remove overview in the URL manually and press enter
you see the 404 error

OR

go to login page
remove login in URL manually and press enter
you see the 404 error


unstable big_txn test in kafka and pulsar pipeline

ref:

cdc_integration_kafka_test
cdc_integration_pulsar_test

fixed by https://github.com/pingcap/tiflow/pull/10951/files


[AutoComplete] Fix important regression

Closes #8302

Thanks for such a quick fix, sorry for breaking this :sweat_smile:


Request Event Parameters - Report 99001017 - Calculate Plan - Plan. Wksh.

Hello,
I'm using the AL Language version 6.5.413786 and BC version 17.3.
I need the following parameters on the event OnAfterItemOnPostDataItem on Report 99001017 - Calculate Plan - Plan. Wksh. :
trigger OnPostDataItem()
begin
    CalcItemPlan.Finalize;
    CloseWindow;

    **-------------- ADD Parameters to EVENT -----------
            OnAfterItemOnPostDataItem(VAR CurrTemplateName : Code[10];VAR CurrWorksheetName : Code[10]);
    ---------------------------------------**
end;

Thanks,
Luís Costa

Please always put the full detailed signature of the requested events.

Hi StanPesotskiy,
I already updated the ticket.
Thanks.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


⚠ Bofrost.fr has degraded performance

In 8ff5c4a, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1073 ms

Resolved: Bofrost.fr performance has improved in 07ab0a7 after 46 minutes.


tiny correctness bug in snapshot_process()

This is a tiny correctness bug.
The function design of snapshot_process is such that hProcess is always clobbered when calling the function. As such, snapshot_process must always close the handle otherwise it will result in a handle leak of the passed in hProcess.
    // avoid reading LSASS directly by making a snapshot
    if (snapshot_lsass)
    {
        hProcess = snapshot_process(
            hProcess,
            PhSnapshot);
        if (!hProcess)
            goto cleanup;
    }

There are two error paths that could lead to such a leakage. I could not find any circumstance where the first one would manifest in the code as written. The second one would only happen if PssNtCaptureSnapshot could not be resolved dynamically (perhaps only possible on out of support target OSes).
// create a snapshot of the LSASS process
HANDLE snapshot_process(
    IN HANDLE hProcess,
    OUT PHANDLE hSnapshot)
{
    BOOL ret_val = FALSE;
    PssNtCaptureSnapshot_t PssNtCaptureSnapshot;
    PssNtQuerySnapshot_t PssNtQuerySnapshot;
    HANDLE hCloneProcess = NULL;
    DWORD process_flags = 0;
    DWORD thread_flags = 0;
    DWORD error_code = 0;

    if (!hProcess || !hSnapshot)
!        goto cleanup;   <<< hProcess input parameter NOT closed here

    // find the address of PssNtCaptureSnapshot dynamically
    PssNtCaptureSnapshot = (PssNtCaptureSnapshot_t)(ULONG_PTR)get_function_address(
        get_library_address(NTDLL_DLL, TRUE),
        PssNtCaptureSnapshot_SW2_HASH,
        0);
    if (!PssNtCaptureSnapshot)
    {
        api_not_found("PssNtCaptureSnapshot");
!        goto cleanup;   <<< hProcess input parameter NOT closed here
    }

    *hSnapshot    = NULL;
    process_flags = PROCESS_PPSCAPTURESNAPSHOT_PERMISSIONS;
    thread_flags  = THREAD_PPSCAPTURESNAPSHOT_PERMISSIONS;

    error_code = PssNtCaptureSnapshot(
        hSnapshot,
        hProcess,
        process_flags,
        thread_flags);

!    NtClose(hProcess); hProcess = NULL;  <<< hProcess input parameter closed here

A solution would be to always ensure that hProcess is closed on every exit from snapshot_process
https://github.com/helpsystems/nanodump/blob/07e44d2aa2f97cd298b2063fc344999840c8d2a7/source/handle.c#L421

Hey man!
I greatly appreciate you looking into the code closely enough as to find stuff like that. I care a lot about this kind of bugs, which can be elusive and hard to find.
That being said, are you sure this is really a bug?
Look at the cleanup section:
cleanup:
    if (hProcess)
        NtClose(hProcess);
    if (!ret_val && *hSnapshot)
        NtClose(*hSnapshot);
    if (!ret_val && hCloneProcess)
        NtClose(hCloneProcess);

    if (ret_val)
        return hCloneProcess;
    else
        return NULL;

If hProcess is set, then it will be closed, regardless if the function succeed or not.
Please let me know that you think 😃

Looking at the cleanup routine, I agree with you.
I first thought this might be the only place that it is closed, but I see that it is also closed in cleanup.  No bug! 👍
https://github.com/helpsystems/nanodump/blob/07e44d2aa2f97cd298b2063fc344999840c8d2a7/source/handle.c#L992

thanks again for looking at the code!


Samachara: Implement Ad Slots

HOME:

===================================================================
adUnit: "Story_Bottom_Responsive", sizes: [[728, 90], [320, 50]],

adUnit: "Story_Standard_300x250", sizes: [[300,250]],

adUnit: "Horizontal_Responsive", sizes: [[728, 90], [320, 50]]

Story_Standard_300x250 is not a valid one. I think it should be Story_Mrec instead.

What do you mean not standard? We can name them whatever we want no?


Action finishes before nested jobs have started

I have added this job to my workflow:
  create-nested-runners:
    runs-on: ubuntu-latest
    steps:
      - name: Run Multiple GitHub Runners in Runner
        uses<EMAIL_ADDRESS>        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          runners: 3

and changed each other job runner to nested-${{ github.run_id }}.
This is the create-nested-runners's log:
2022-06-23 19:36:08 INFO     Pulling docker image dougcalobrisi/nested-github-runner:latest
2022-06-23 19:36:37 INFO     Added shared volume /shared:/shared
2022-06-23 19:36:37 INFO     Starting runners
2022-06-23 19:36:37 INFO     Starting runner 0
2022-06-23 19:36:37 INFO     Starting runner 1
2022-06-23 19:36:37 INFO     Starting runner 2
2022-06-23 19:36:38 INFO     Started runner 1 in container eac5653e4cd7f65e9f11af4059d2dc756840d48077b02b1d920706e5634561d7
2022-06-23 19:36:38 INFO     Started runner 0 in container d9d2f9c1f695bfadee4f2f4767e6c8f1d9128f3ed1309a87e64ee064434c53
2022-06-23 19:36:38 INFO     Started runner 2 in container b97bc26816f3b950fe5b8b28646e7e1c018c23d201e903badc29c5c4f53f6017
2022-06-23 19:36:40 ERROR    End of log for container d9d2f9c1f695bfadee4f2f584767e6c8f1d9128f3ed1309a87e64ee064434c53 before proper termination
2022-06-23 19:36:40 ERROR    End of log for container eac5653e4cd7f65e9f11af40d2dc756840d48077b02b1d920706e5634561d7 before proper termination
2022-06-23 19:36:40 ERROR    End of log for container b97bc26816f3b950fe5b8b28646e7e1c018c23d201e903badc29c5c4f53f17 before proper termination

and the others are forever in queue with the message: Requested labels: nested-2551535643.
Am I doing anything wrong?
For more context: https://github.com/wilkerHop/poc-nested-github-runners-action/actions/runs/2552581455

This likely occurs because the GitHub Runner failed to start in the containers. Looking at your Workflow, everything like good - does your GITHUB_TOKEN secret have the proper permissions to create new repository-level runners?  If not, the the runners may fail at startup, causing the containers to exit.
I'll look into adding better logging for this soon.


Calling isSignedIn before signIn results in incorrect result

If I call MendeleySDK#isSignedIn before calling MendeleySDK#signIn, isSignedIn returns false, even if the user has previously signed in. This is due to the fact that the authenticationManager has not yet been initialized on AsyncMendeleySdk.java#L54.
To make matters worse, calling MendeleySDK#signIn results in no callback, so there is no way to tell if we are signed in. MendeleySDK#signOut appears to have the same problem.

Thanks for reporting the issue - and apologies for the late response.
We're looking into this and will report back.
Peter

I have the same problem,
the root of all evil is that the AuthenticationManager gets instantiated only in the signIn method in DefaultMendeleySdk.java#L28.
So you have to call signIn before you can test if you are signed in?! The AuthenticationManager should be initialized earlier but because an MendeleySignInInterface is needed to create an AuthenticationInterface for the AuthenticationManager.
My workaround is to check the SharedPreferences by hand for an accessToken
	private boolean isSignedIn() {
		SharedPreferences preferences = getSharedPreferences("auth", Context.MODE_PRIVATE);
		boolean isSignedIn = preferences.getString("accessToken", null) != null;
		if (isSignedIn && !sdk.isSignedIn()) {
			// call sdk.signIn just for init AuthenticationManager
			ClientCredentials clientCredentials = getClientCredentials();
			sdk.signIn(this, this, clientCredentials);
		}
		return isSignedIn;
	}

Thanks for your comments guys, I think you are 100% right.
At the moment we are very busy working on the official Mendeley app and we cannot attend this properly, I'm afraid.
However, today we have opened a "develop" in where we plan to commit backward-compatibility breaking changes and drastic refactors.
We have merged today some changes so that:

the sdk is initialised using a DefaultMendeleySDK#sdkInitiliase(UserCredentials)
the AuthenticationManager is created in the constructor of the sdk

However, we don't want to merge this into master until better tester and polished.
Also, when going through this code today, we've realised of some things we'd like to change:

setup of the credentials based on properties in config file or Manifest, like in Facebook
result of the authenticacion process could be retrieved using onActivityResult. I would like to get rid of the SigningCallbackInterface, which I think could be leaky.
elimination of HTTPClient
async methods should delegate into blocking ones.

@garrapeta Thanks for the great news! Also allow a custom CredentialsManager is a huge improvement, so now I can use the native android AccountManager with the AccountAuthenticator to storw my credentials.


In-Memory external handler

Crummy and prone to errors?  Yep.  No external dependencies?  Also yep.

Closed in 9fe8132


[CLI]: wandb artifact download error within docker

Describe the bug

Hi,
I have a simple code to download the artifact from the aws through wandb. The code works, however, as soon as I run the code within docker I am getting Bad Request error from the boto.3. Is there any solution for this?

run = wandb.init(project=const.WANDB_PROJECT, job_type='inference', entity=const.WANDB_ENTITY)
artifact = run.use_artifact(const.WANDB_MODEL_NAME + ':latest')
modelPath = artifact.download()

wandb: Downloading large artifact cloud:latest, 102.72MB. 2 files... Found credentials in environment variables.
Found credentials in environment variables.
Traceback (most recent call last):

  File "/opt/conda/lib/python3.8/site-packages/wandb/apis/public.py", line 4381, in download
    pool.map(partial(self._download_file, root=dirpath), manifest.entries)
  File "/opt/conda/lib/python3.8/multiprocessing/pool.py", line 364, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/opt/conda/lib/python3.8/multiprocessing/pool.py", line 771, in get
    raise self._value
  File "/opt/conda/lib/python3.8/multiprocessing/pool.py", line 125, in worker
    result = (True, func(*args, **kwds))
  File "/opt/conda/lib/python3.8/multiprocessing/pool.py", line 48, in mapstar
    return list(map(*args))
  File "/opt/conda/lib/python3.8/site-packages/wandb/apis/public.py", line 4475, in _download_file
    return self.get_path(name).download(root)
  File "/opt/conda/lib/python3.8/site-packages/wandb/apis/public.py", line 3840, in download
    cache_path = manifest.storage_policy.load_reference(
  File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_artifacts.py", line 935, in load_reference
    return self._handler.load_path(artifact, manifest_entry, local)
  File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_artifacts.py", line 1091, in load_path
    return self._handlers[str(url.scheme)].load_path(
  File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_artifacts.py", line 1374, in load_path
    etag = self._etag_from_obj(obj)
  File "/opt/conda/lib/python3.8/site-packages/wandb/sdk/wandb_artifacts.py", line 1541, in _etag_from_obj
    etag = obj.e_tag[1:-1]  # escape leading and trailing quote
  File "/opt/conda/lib/python3.8/site-packages/boto3/resources/factory.py", line 339, in property_loader
    self.load()
  File "/opt/conda/lib/python3.8/site-packages/boto3/resources/factory.py", line 505, in do_action
    response = action(self, *args, **kwargs)
  File "/opt/conda/lib/python3.8/site-packages/boto3/resources/action.py", line 83, in __call__
    response = getattr(parent.meta.client, operation_name)(*args, **params)
  File "/opt/conda/lib/python3.8/site-packages/botocore/client.py", line 388, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/opt/conda/lib/python3.8/site-packages/botocore/client.py", line 708, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (400) when calling the HeadObject operation: Bad Request

Additional Files
No response
Environment
WandB version:
OS: Ubuntu 20.04
Python version: 3.8
Versions of relevant libraries:
Additional Context
No response

Hi @alib022 , can you please provide you debug logs for the crashed run and we will take a closer look. The debug.log and debug-internal.log files are within your local wandb run folder. They may help indicate what the issue is.

Hi @alib022 , since we have not heard back from you we are going to close this request. If you would like to re-open the conversation, please let us know!


Desktop 5249 - Top-level team badging

[x] Add action
[x] Wire up store
[x] Render

@keybase/react-hackers this is pretty much ready pending some core changes. See the inline comments for details


🐛 [Bug]: Error running litecart for the first time

Bug Description
After init and serve and visiting localhost:8000 I saw a blank page and the following in the developer console of my browser:
21:45:04.189 Uncaught Error: Extension Error: The validator 'all' must be a function.
    Zn http://localhost:8080/_/assets/vee-validate-usGg8cAm.js:5
    $t http://localhost:8080/_/assets/vee-validate-usGg8cAm.js:5
    <anonymous> http://localhost:8080/_/assets/index-BETTTWNd.js:2
    <anonymous> http://localhost:8080/_/assets/index-BETTTWNd.js:2

How to Reproduce

Downloaded the litecart binary for my platform.
Ran litecart init and it created the dirs.
Ran litecart serve and it ran successfully.
Then I tried to visit localhost:8080 and I was met with a blank page.
I looked at the web developer console and saw the error.

Expected Behavior
Litecart should start and present me with the first page.
litecart Version
litecart version LiteCart v0.1.11 (453b7e4) from 2024-07-07
Code Snippet (optional)
No response
Checklist:

[X] I agree to follow litecart's Code of Conduct.
[X] I have checked for existing issues that describe my problem prior to opening this one.
[X] I understand that improperly formatted bug reports may be closed without explanation.

Hi @chr15m
I rolled out a new version (v0.1.12) where this issue has been fixed. Thanks for the fix @kaichaosun (https://github.com/shurco/litecart/commit/0f36efc8a46da6d9a72afafcb346ab9ff038de69)

Fixed, thanks.


Your Logo is unreadable in DarkTheme Github

The logo looked like just blue lines on the dark theme of Github. I couldn't read it until I figured that out.

Yes, there is a problem. Seata has 2 sets of logos, one in black and blue, and one in white and gray. These two sets of logos will have similar problems when matching github themes with similar colors.


Running DCGM Exporter on RHEL 9 w/ podman returns  Error: Failed to initialize NVML

sudo podman run --rm --gpus all --cap-add SYS_ADMIN --security-opt seccomp=unconfined -p 9400:9400 nvcr.io/nvidia/k8s/dcgm-exporter:latest
I am trying to run the nvidia exporter locally using podman on Rhe.
Do you suport/ is there a known issue with using podman?
Do  you support/is there a known issue with rhel9?
Special SeLinux modules needed?
Is there a way to get more verbose logs to do some debugging?

@pwharned,
Can you run nvidia-smi inside the pod (not the host)? If not, that's most likely the nvidia-runtime does not work properly in your podman.

Actually following the instructions here lead me to a more useful error: https://github.com/Gaussianer/Podman---Run-Rootless-GPU-Container

attempting to run nvidia-smi gives the same error (doesnt look like its actually running the command in the pod tbh)

@pwharned,
From the instructions

If the test passes, the drivers, hooks and the container runtime are functioning correctly

Unfortunately, the error you see means that the nvidia-container-toolkit does not work/installed correctly.
I did not mean to run nvidia-smi inside the dcgm-exporter container. Any container, even bare Ubuntu, should have the nvidia-smi if the container toolkit works appropriately (under the hood, the nvidia-smi, nvidia-ml.so and other required libraries and driver parts are mounted inside any container that runs with the --gpu argument).
Unfortunately, I cannot provide more guidance on how the nvidia-container-toolkit should be installed/configured with rootless podman - that's outside of my field of expertise.

@nikkon-dev
I am actually able to run the dcgm-exporter by building from source, its only the container that doesnt work. I've also verified that the toolkits are correctly installed which you can see from the screenshot, I generated a sample load on my local dcgm etc. I will try to build my own container to identify what is causing this issue and see If I can't fix it.


chore: replace structopt with clap in examples

Replaces structopt with clap in examples.

@tottoto if you rebase it should fix CI.

Rebased.

Just a random note that GitHub allows relaxing the default restriction on when workflow runs require approval (can't remember any PRs where not allowing them to run immediately was useful on this repo), in actions settings for the repo or organization:

@jplatte I have mixed feelings about changing that option because I do skim PRs from new contributors before hitting the button, just to see if anyone's trying anything suspicious.
It doesn't really matter right now, but I could easily see myself adding a new workflow with sensitive tokens (e.g. an automated release workflow) and forgetting to properly gate it off.
I wish there was an option like "Approve and run all workflows for this PR" so I didn't have to keep doing it for the same PR though.


337 we need screens to enable cru staff to manage user accounts and permissions

Endpoints to allow staff to delete a user and to update a user's roles and permissions.

I think there is some work that needs be done on the commit history before this can be merged.
There's some good tips in the guidance Stu linked above. I think points 4, 5 and 7 need addressing here.
It might be a good idea to build the commits around the different endpoints in the PR (PUT, users/search and delius/search) or something similar


zsh: add plugins submodule

See #55.
The plugins module does not have its own compinit. Instead it defaults enableCompletion to true.
Users who cannot or do not want to disable programs.zsh in their system config can still disable enableCompletion to avoid the slowdown. For example:
programs.zsh.enableCompletion = !systemConfig.programs.zsh.enable;

Thank you for PR!
I have a couple of comments.

I'm getting this error when trying to run $ home-manager switch:
error: The option `programs.zsh.plugins.*.name' is used but not defined.
The error seems to appear independently of the configuration file. Removing default value for file parameter fixes it.

Would you mind to provide an example of the plugins configuration? Something like this:

plugins = [
  {
    name = "nix";
    src = pkgs.fetchFromGitHub {
      owner = "spwhitt";
      repo = "nix-zsh-completions";
      rev = "0.3.1";
      sha256 = "1sbc52f5818bcygljrji84dyvgw727x50m9v6qfrsdaji3zkqga1";
    };
  }
];

It seems when I add a plugin using this submodule my zsh startup time increases significantly (from around 0.06 to 0.34). Looks like it is connected with appending plugin path to fpath. Trying to call compinit in the end of .zshrc results in the following warning:zsh compinit: insecure directories, run compaudit for list.
Running compinit -u solves the problem, but startup time still remains high. Do you know what it can be connected with?

I believe I figured out the right way to do this:

Add all PATH and fpath entries.
Call compinit (-C should be faster than -u). This traverses fpath.
Source the plugin scripts as now they have access to functions added by compinit.

With this setup and no compinit in my /etc/zshrc I get 0.03s now.

Thanks for the benchmarks! The combination is probably slow because oh-my-zsh calls compinit as well, so all fpath entries will be traversed again. You could try disabling programs.zsh.enableCompletion but you would not be able to ensure that oh-my-zsh runs after programs.zsh.plugins. We could integrate the oh-my-zsh module into the zsh module to fix the order.

@uvNikita Yeah, if this is interesting for the general Zsh user then I think it would make sense to have a news entry saying that this option now is available. I guess it should be conditioned on programs.zsh.enable… For now I'm thinking it is best to keep the news entries centralized in news.nix so if you decide to add one then please add it there.

I tested your branch and indeed it looks like it improved performance a bit, thank you for observation! I don't see a problem with combining these modules for optimization purposes since they both setup zsh.
However, I performed more tests and was still experiencing a significant (by order of magnitude) increase in startup time when using both oh-my-zsh.plugins and zsh.plugins. It took some time, but I found the reason for this.
When we use src = pkgs.fetchFromGitHub it stores plugins in /nix/store folder which is considered to be unsafe according to zsh compinit function (due to writable permissions for the group). For some reason, if $fpath contains such directory, the compinit function performs much longer which results in a slow startup. As it was mentioned, compinit -C disables security checks and removes this slowdown. But if oh-my-zsh is enabled, compinit is executed inside a $ZSH/oh-my-zsh.sh script like this: compinit -i -d "${ZSH_COMPDUMP}". -i option tells compinit to ignore unsafe directories (for some reason in my tests completions defined in such directories were still available, even after removing all cache and dump files), but since the security checks are still performed we are getting same slow startup.
I also figured out that it seems like not referencing /nix/store/.. directly in $fpath helps to prevent zsh to complain about insecure parent directory. To check that I created link in my home folder ~/plugin -> /nix/store/<hash>-plugin and add $HOME/plugin in $fpath. This setup fixes performance issues.
So, as for now, I see three ways to go:

Patch oh-my-zsh to optionally use -C parameter instead of -i.
Somehow reference plugins not from the /nix/store directly, but from the user home directory. For instance, to automatically create ~/zsh/plugins and put symlinks to the plugin sources there. The advantage of this approach would be that in this case we can remove potentially insecure -C option from our module as well.
Leave everything as is and write a warning for users that using both modules can reduce startup performance slightly.

I personally think the second option would be the best, but I'm not sure how hard it is to implement such behavior in nix. @dermetfan what do you think about this?

Spot on, @uvNikita! Turns out the second option was not so hard to implement, and it did fix the slowdown as you described. I'm now at 0.07s with the same plugins as in my previous comment.
I added the commits to this PR's branch so you can review.

I was thinking that it would be nicer to have two commits: one about adding zsh.plugins and one about merging oh-my-zsh module into zsh for optimizations, since those are somewhat independent.

Added a news entry in a third commit. Do we agree like this? :smiley:

Not that I understand much of Zsh but it looks like this PR has come a long way! Maybe should have a look at trying Zsh out ;-)
Thanks to both of you for such productive and fruitful work!

I probably didn't explain properly what I mean. I was thinking to have two commits in the end:
The first one, that contains both new parameter implementation (with plugins being linked into the home directory) and the news entry:
zsh: add plugins submodule

Plugins are liked in the home directory.
In case `compinit` is called from within oh-my-zsh, this passes the security check,
and allows us to call `compinit` without `-C` for vanilla plugins.
Also, it solves issues with a slow start up,
see https://github.com/rycee/home-manager/pull/56#issuecomment-328057513.

And the second one, that merges oh-my-zsh and zsh modules for even further optimizations:
zsh: fix double compinit slowdown with oh-my-zsh

Integrate the oh-my-zsh module into the zsh module
to be able to control invocation order.

Alternatively, I can restructure your commits in this way during rebase if you would prefer that :)
Sorry for the confusion I created :)

@rycee I'm also very excited about these new changes and optimizations! With this PR merged and couple of small fixes that will be added soon our zsh module will be faster and more featureful even than the one from nixpkgs :)

@uvNikita Go ahead then, I pushed the original commits on here. My git-fu is ok but I don't see how I would rebase zsh: link plugins in home directory before its parent without manually resolving conflicts. I guess that's why communication failed here :)

Rebased changes into master. Thank you for the contribution!


Add ability to specify docker build path

I am having the following project layout:
/
 Solution.sln
 src/
   Library/
     Library.csproj
     ...
   App/
     App.csproj
     ...

The app has a dependency on the library (<ProjectReference Include="..\Library\Library.csproj" />).
Running azds prep inside the App folder produces an invalid Docker file:
FROM microsoft/dotnet:2.2-aspnetcore-runtime AS base
WORKDIR /app
EXPOSE 80

FROM microsoft/dotnet:2.2-sdk AS build
WORKDIR /src
COPY ["App.csproj", "."]
RUN dotnet restore "App.csproj"
COPY . .
RUN dotnet build "App.csproj" -c Release -o /app

FROM build AS publish
RUN dotnet publish "App.csproj" -c Release -o /app

FROM base AS final
WORKDIR /app
COPY --from=publish /app .
ENTRYPOINT ["dotnet", "App.dll"]

All paths are relative to the App folder which clearly does not work because the library is not included in the image.
Running "Add->Container Orchestrator Support" in Visual Studio produces a valid Docker file that uses the docker path of the solution. However, running azds up with this Docker file inside the App folder does not work because it fails file not found errors.
So, how do you specify the docker path used for docker build to specify the context? I want it to be the solution directory.

Same issue. My solution has a project that makes references to sister projects. From within the project the dockerfile cannot make reference to anything outside of the current project folder. As such, I'm not able to make Azure Dev Spaces work, because I'm unable to modify Azure Dev Spaces Visual Studio plugin to path to dockerfile in order to leverage the docker file that is at the root of the solution and thus has access to all underlying projects paths.

I believe if you choose to use Dev Spaces on a project in VS that it will generate the correct Dockerfile. It navigates project-to-project references and determines all the projects that need to be built in the Dockerfile, and the build context is set to the solution. The azds prep command doesn't support solutions in the way Visual Studio does which explains why the Dockerfile it generated didn't work for you.
It is confusing that "Add->Container Orchestrator Support" in Visual Studio doesn't go through the same code path. We are trying to reconcile these experiences so that the same .dockerignore, Dockerfile etc. are generated regardless.

@stepro It becomes a headache to figure out how to do it right with a dockerfile that can be run locally and in Azure DevOps Build Pipeline for CI. Especially with references to private nuget packages and references to other sister projects. There's so much to figure out and all the magic that azds tries to do, doesn't work well in very custom scenarios. It feels like it's a tool that you have to bend yourself to in order to make it work. It's unforgiving. I might be wrong. I'm still new to AKS and all.

I recognize the pain here. A lot of it stems from Dev Spaces being a relatively new product where we're still learning about the scenarios you mention and how or if we can automatically accommodate them when generating Dockerfiles.
For your particular problem, if you use Dev Spaces to generate a Dockerfile, then it should account for references to other projects and configure the build context at the solution level. It generates a similar Dockerfile.develop that is the only actually used during development, while the other one is intended to be used post-commit for actual deployment.
It is a goal of Dev Spaces to make getting started with Kubernetes easier. If there are places where you think Dev Spaces has actually made things harder with AKS than they would have been otherwise, then we certainly would be interested to understand why that is. It's fair to say that we are still evaluating where the balance is between completely hiding the complexity of Kubernetes, including the need for Dockerfiles, Helm charts and so on, and providing an experience over the underlying assets that simplifies without abstraction. We currently lean more towards the latter beacuse it allows for more flexibility, but that leaves work we need to do to help in the kinds of situations you are facing.

You can use the build.context configuration in azds.yaml to specify a different Docker context instead of the default ..
For example I have a project located at src/ProjectA/src/Acme.Libs.ProjectA/Acme.Libs.ProjectA.csproj.The Dockerfile and azds.yaml files are located together with the csproj file (src/ProjectA/src/Acme.Libs.ProjectA/Dockerfile). By setting the build.context to ../../../.. you'll be able to access the complete solution during Docker build.
It is pretty tedious to maintain and align the various files (.csproj, Dockerfile, azds.yaml) and I do hope it could become easier. But I think the problems come from the MSBuild project model (i.e., solution and csproj files).

Thanks @ahaeber Worked for me.


Allow calling methods with no expected reply

Some services expose interfaces that don't send method call replies. This PR allows python-dbus-next to mark method call with NO_REPLY_EXPECTED flag.
Without this, calling such methods results in a warning in logs:
2020-07-10 10:28:57 root                                     ERROR     message_bus.py:573  got unexpected error processing a message: invalid state.
Traceback (most recent call last):
  File "/home/khorne/Programming/silvair/python-dbus-next/dbus_next/message_bus.py", line 570, in _on_message
    self._process_message(msg)
  File "/home/khorne/Programming/silvair/python-dbus-next/dbus_next/message_bus.py", line 668, in _process_message
    handler(msg, None)
  File "/home/khorne/Programming/silvair/python-dbus-next/dbus_next/message_bus.py", line 535, in reply_notify
    callback(reply, err)
  File "/home/khorne/Programming/silvair/python-dbus-next/dbus_next/aio/message_bus.py", line 217, in reply_handler
    future.set_result(reply)
asyncio.base_futures.InvalidStateError: invalid state

:+1:


Multiplication w/o using multiplication operator.

I will write a code with full documentation about how to find the product of two numbers without using the multiplication (*) operation.

Yes sure. I have assigned the issue to you

I'd like to write the code for multiplying 2 numbers without using ( * ) operator.

I see the issue is still open, I can write the code. Please let me know in which directory to place the cpp file @amritansh22

Yes sure you may take it @distroinfinity

I am willing to work on this using C++. Kindly assign this to me also.

@Deepak2417 Yes sure. Open a PR once done

i want to contribute , could you pls assign it to me?

I am willing to do this issue , could you pls assign it to me?


Improve loading time

Much of the package loading time currently appears to result from these lines:
using IntervalArithmetic: interval, mid
using IntervalRootFinding: Newton, roots

However, these are only needed for the RootFinding updates.
Perhaps a good use case for Requires.jl? One potential issue seems to be that we can't specify the versions in that case.

Another approach is LazyModules.jl: https://github.com/johnnychen94/LazyModules.jl


condition_script doesn't use cwd

Describe the bug
In a condition_script, the cwd value of the task isn't used. This was a little counter-intuitive and took me a bit to figure out. It's easy to work around by cding in the script, but I'd expect it'd use the task cwd. If not, I think the docs should probably mention this in the section about condition_scripts.
Additionally, the condition script won't get the values of anything set in env for that task, which I think makes some sense, but would also be nice to call out in the doc.
To Reproduce
Make a task with a non-root cwd and a condition_script. The working dir for the condition script will be the root directory of the project.
Code Sample
[tasks.bugrepro]
workspace = false
cwd = "some/sub/directory"
category = "Build"
condition_script = [
'''
#!/bin/bash
pwd
'''
]
command = "pwd"

Really love this tool! Thanks for your hard work!

@Sushisource ya cwd not impacting the condition script is a bug. will fix that.
env i would prefer to keep as is, as it is 'invocation' of the task same as its command/script and should only happen if conditions are met.
I'll update the docs as you recommended. thanks

@Sushisource a fix has been pushed for this in 0.22.0 development branch.
Feel free to test it to see it fixes your issue.

@sagiegurari Confirmed, this fixes it. Thanks!

thanks a lot for confirming. an official release will be available start of next week.

@Sushisource cargo make 0.22.0 has now been published with the condition cwd fix.


Rename updatePerson(...) to setPerson(...)

Can't find much of an overarching theme to the commits, so
no merge commit, commits are standalone.

@Zhiyuan-Amos Thanks


bara debug test

I think this issue may have been opened accidentally? If not, please open a new issue that describes the nature of your debug test.

Yep. Sorry, indeed, its an accident. I did not even realise I opened the
issue. Probably misplaced a click.
Regards,
Sergei
On Tue, Aug 30, 2016 at 5:15 PM, Joe Ferris<EMAIL_ADDRESS>wrote:

I think this issue may have been opened accidentally? If not, please open
a new issue that describes the nature of your debug test.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thoughtbot/capybara-webkit/issues/943#issuecomment-243453250,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMJ8ARzReQj9SXCtHf_SPBvm6ptrGLlks5qlDsXgaJpZM4Jv7Jj
.


Debug system instabilities

I want to use this project as a basis for running an application with Linux dependencies on Rocket.
First I tried getting https://github.com/tongchen126/Boot-Debian-On-Litex-Rocket project to run. I managed to boot to login and even successfully login a couple of times with both systemd and sysvinit but the majority of times it will just indeterministically hang at random points in or after the boot process (can be in either Kernel/systemd/sysvinit/after login).
Where the hangs after the kernel has started are far more common.
If the hang happens after the Kernel has started then the Kernel will usually still be active (it prints a message if the sdcard gets removed). In that case just the application (bash/systemd/sysvinit/other binaries) seems to become unresponsive.
Second I tried using the /bin/bash shell instead of systemd or sysvinit as they don't seem strictly necessary to run my application.
Here I encounter the same issue. Sometimes my application finishes successfully, sometimes it just randomly hangs (but kernel is still active). Especially on long program runs the probability that the application will hang is very high.
I did run into this issue last year as well when I was using an older version of the system for benchmarking purposes but I didn't have the time investigate this further (so I would just restart until I get a successfull run).
So first of all I was wondering if you @gsomlo encountered instabilities on your Rocket systems.
Second I was wondering if you have any pointers of things that I could look into.
Online I mostly found advice for deterministic hangs in Linux.
For reference I'm using the Arty board and the latest version of Litex.
I already tried different sdcards so I don't think that's an issue.
Additionally I tried using different power supplies.
I'll also try another FPGA when I get my hands on it.
Overall I'm leaning more towards that it's probably a software/gateware issue since BBL and the kernel rarely hang.

instructions on how to boot fedora with linux-on-litex-rocket have been added as part of commit b9b92a5bf79334f100ad808df7827f1f326307c1. Closing, please follow-up or re-open if any problems remain un-addressed.


Kernel dies after any exception is thrown

Prerequisites

[X] Have you checked the solutions in our troubleshooting guide for common problems ?
[X] Have you checked that your issue isn't already filed ?

Description
Since a few weeks ago, as soon as an exception is thrown by the python code, the kernel seems to die. Usually, when an exception was thronw, I could keep running other parts of the code.
Now, after the first exception occurs, any line of code that I evaluate, fails to run, and results in an X at the end of the line, as well as the following message in the developer console: kernel.js? [sm]:366 Kernel: ignoring unexpected value for message.content.status.
Sometimes running a line fails, showing an X, without any exception having occured. However, in that case, I am able to rerun the line, and it usually works.
This is only happening in one computer, but it's making hydrogen a pain to use.
Steps to Reproduce
I described it above, but I am not yet sure what part of my setup makes it fail, while it works in other computers. I will explore further. But if anyone has encountered the same problem, maybe they can save me some of that time.
Versions
OS version: Ubuntu 18.10

atom --version

Atom    : 1.41.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

apm --version

apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.41.0
python 2.7.16
git 2.19.1

Hydrogen version: 2.13.1
Plugins
Have you installed and activated any of the Hydrogen plugins below ?

[X] hydrogen-python
[ ] Hydrogen Launcher
[ ] Data Explorer

Additional context
After more testing, I just found that the error doesn't happen in a virtual environment I have, it only happens on my vanilla "Python 3" kernel.. I suppose there must be something in my environment that is breaking it?

can you give me some sample code to test this as I am unaware which type of thrown exception could cause this behavior?

I've actually experienced a weird behaviour like this while I played around IRuby kernel, but I can't even remember I saved the exact code. I will post that if I find that.
And yes, as @wadethestealth pointed, a sample code that contains MRE would really help us debug the problem: @guillefix

since the original reporter doesn't present
mre, I'm going to close this.
I may open an new issue if I encounter this with valid mre.


How to show the YAxis scale in this format with K(Thousand), M(Million) and B(Billion)  in Chart.Js?

How to show the YAxis scale in this format with K(Thousand), M(Million) and B(Billion)  in Chart.Js?
in Bar chart

See #2311

Is there any solution ?


64 bits support

Ty for this awsome library.
For information,  i ported it on Xamarin Android, it works really well.
I still have a pb :   panoramagl doesn't support x86_64 and arm64-v8a arhitecture.
Can you confirm this point ? Or did i miss something ?
There isn't any 64 bits versions of libglues.so ? Any help, advice on this point would really be appreciated.
64 bits will be mandatory in 2019. So ...
Ty in advance.

This guy has the source code of the files:
https://github.com/waylife/panoramagl-android/tree/master/panoramagl-android/PanoramaGL/jni
Access this directory and use command ndk-build using terminal.
Also you need to modify Application.mk ABIs to all.
as a result you will find in console the needed files.

libs.zip
and here is the files incase you dont want to do the whole process.

@ahmadhariss thanks for the files.(libs.zip)

Solved by https://github.com/marianmoldovan/panoramagl/pull/11

Here is the C code https://github.com/hannesa2/panoramagl/pull/38


[Bug] Social icons should be consistent in all pages

Description
How to reproduce:

Go to the footer section of the home page and hover over social icons
Go to the footer section of login page and hover over social icons
Observe they behave differently in the above step 1 and step 2

Expected behavior: The social icons should be consistent/same on all pages of the website.
Actual behavior: In the footer section, when we hover over social icons, we see two different behavior on the home page and  login page
Proposed design: I think we can use the home page's social icons design on the login page as well. Please let me know your feedback on that.
Screenshots
Home page

Login page:

@rezwan2525 I want to work on this issue.

@rezwan2525 Please go ahead! 🤩


Improve FHIRStore to use actor isolation

Problem
The FHIRStore currently uses a locking mechanism to handle concurrency, which was introduced in #21. While this approach addresses concurrency issues, it may not be the most maintainable solution in the context of Swift 6 concurrency model.
Solution
To address the concurrency issues in FHIRStore and align with the new concurrency practices, we should refactor this to use actor isolation instead of the current locking mechanism.
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

Tackled in https://github.com/StanfordSpezi/SpeziFHIR/pull/26


More Examples?

require "./web"

window = Web.window
console = window.console
document = window.document

# I had to do this to compile:
console.log JS::String.new("Width: #{window.inner_width}")
console.log JS::String.new("Height: #{window.inner_height}")

canvas = document.create_element("canvas")
document.body.append_child(canvas)
ctx = canvas.get_context("2d")
ctx.font = "30px Arial"
ctx.fill_text("Hello World!", 10, 30)

# events are important
canvas.addEventListener "onmouseover", do |event: JS::MouseEvent|
  console.log event
end

how to make events work?

unrelated information on crystal wasm hello world build size:
lib/js/scripts/build.sh src/main.cr --error-trace
+ ls -lh main.js main.wasm
-rw-r--r-- 1 forge forge 6.6K Jul 31 10:30 main.js
-rwxr-xr-x 1 forge forge 502K Jul 31 10:30 main.wasm
+ lib/js/scripts/build.sh src/main.cr --release
+ ls -lh main.js main.wasm
-rw-r--r-- 1 forge forge 3.2K Jul 31 10:30 main.js
-rwxr-xr-x 1 forge forge  53K Jul 31 10:30 main.wasm
+ mv main.js dist/main.js

Let's say if we had a seperate js file that needed to call a function from crystal, what would that look like?
main.cr
def foo
  return "bar"
end

main2.ts
console.log(foo())

pp "A"

begin
  raise "B"
rescue ex
  pp ex
end

pp "C"

only outputs "A" and EXITING: Attempting to raise: B (Exception) . I think this is WebAssembly's fault though: https://github.com/WebAssembly/exception-handling

I tried this and it compiled but nothing happened:
class ::Web::EventTarget
  def addEventListener(name : ::String, listener : Proc(Nil)) : Nil
    pp "::Web::EventTarget.addEventListener before #{__LINE__}"
    <<-js
      "\#{self}".id.addEventListener(#{name}, #{listener})
    js
    pp "::Web::EventTarget.addEventListener after #{__LINE__}"
  end
end

cb = -> : Nil { pp "fired" }
canvas.addEventListener("onmouseover", cb)

but it didn't crash or output "fired".

Hi there.

how to make events work?

For events to work we need to pass a callback from Crystal to JavaScript. Currently Procs are not supported by crystal-js, only primitive types, strings and array-like types. It needs to support both "sending" a Proc from Crystal to a JavaScript function, and the way back, before we can support DOM events here.

Let's say if we had a seperate js file that needed to call a function from crystal, what would that look like?
main.cr
def foo
  return "bar"
end

main2.ts
console.log(foo())

This repo assumes that Crystal calls JavaScript, but not the other way around. You can export a Crystal function (using the fun syntax instead of def), but if you do that, you will only be able to take numbers as arguments and to return a single number as result, nothing more complicated than that. These exported functions will show up in the wasm module.
It would be, of course, a nice feature to facilitate exporting Crystal functions to JavaScript with full support for complex types. I'll keep it in the backlog.

pp "A"

begin
  raise "B"
rescue ex
  pp ex
end

pp "C"

only outputs "A" and EXITING: Attempting to raise: B (Exception) . I think this is WebAssembly's fault though: WebAssembly/exception-handling

Exceptions are not implemented yet for the WASM target of Crystal. See https://github.com/crystal-lang/crystal/issues/12002 for more details. Currently the behavior is that whenever a exception is thrown, the application will just crash and exit right there, with no way of catching and recovering.

I tried this and it compiled but it didn't crash or output "fired".
class ::Web::EventTarget
  def addEventListener(name : ::String, listener : Proc(Nil)) : Nil
    pp "::Web::EventTarget.addEventListener before #{__LINE__}"
    <<-js
      "\#{self}".id.addEventListener(#{name}, #{listener})
    js
    pp "::Web::EventTarget.addEventListener after #{__LINE__}"
  end
end

cb = -> : Nil { pp "fired" }
canvas.addEventListener("onmouseover", cb)

Please check the README at https://github.com/lbguilherme/crystal-js. It explains more about how new methods can be created. But in short: you need to annotate them with @[JS::Method] and their body can't anything other than one single string literal with special interpolations for bridge values. Also, Proc isn't supported yet. You will receive a compile-time error about that.

All in all, this repository is a proof of concept and a experiment. It shows that creating Web bindings for Crystal is possible, but there is still a long way before it gets to a usable point. Please tell me a little about your intended use case so I can better understand how to evolve this shard in the future.
Thanks!

I wanted to make an interactive canvas thing with most of the core logic in canvas, but I need at least mouse events for it to be feasible.


Design 1.0 API and release v1.0.0-rc1

I think polluting the global namespace is not the best decision for the API. And we should consider how this will work from typescript. I'll be doing some research and coming back with a document for feedback.

RC1 is released https://github.com/extism/js-pdk/releases/tag/v1.0.0-rc1
I'll document API changes and ideas here. We will push them in rcx until next January so expect breaking changes.

We have released rc1. It's mature enough to release 1.0, but the last thing we wanted to change was the global namespace stuff. Though i'm starting to feel like that's not that big of a blocker and we can always just change it in a 2.0


Remove get_cache() from controller

(This is a part of #213)
Remove one layer of indirection.

Forgot about tests :s will fix them in the afternoon.

Coverage increased (+1.2%) to 40.875% when pulling 3331762e538a258ee963c0e5bfcd08be263ecdc3 on kmws:controller-get-cache into 9563aeab5cb6b493dc9d124f50f1cfd8f91b0ce4 on newsboat:master.

Coverage increased (+1.2%) to 40.875% when pulling 3331762e538a258ee963c0e5bfcd08be263ecdc3 on kmws:controller-get-cache into 9563aeab5cb6b493dc9d124f50f1cfd8f91b0ce4 on newsboat:master.

Coverage increased (+1.2%) to 40.875% when pulling 3331762e538a258ee963c0e5bfcd08be263ecdc3 on kmws:controller-get-cache into 9563aeab5cb6b493dc9d124f50f1cfd8f91b0ce4 on newsboat:master.

Cool! I'll merge once Travis build is done.

Thank you very much, @kmws!


Schema unexpectedly persists across reads

I'm reusing a dataframe reader across reads and noticed that once a schema has been passed in to one load(), it continues to be applied on subsequent load()'s.
Something like this will repro it:
reader = sqlContext.read.format("com.databricks.spark.csv")

df = reader.options(header='true', delimiter='\t').load(inpath, schema=mySchema)
df.write.parquet(outpath)

df = reader.options(header='true', inferSchema=True, delimiter='\t').load(inpath)
df.write.parquet(outpath)

If this is an underlying dataframe reader issue, please redirect me and I'll file a Spark JIRA.

I think this is a Spark issue. DataFrameReader holds the options and schema. I think the reader has to be created per-read for now as a workaround.

If the schema was passed in to options() I could have understood it being persistent, but given that it's passed in to load() the reasonable expectation is that it's a per-load thing.
Anyway, thanks for the response. I'll close the issue.

Just FYI, actually, there is another API in the reader, .schema(mySchema), which sets the schema into DataFrameReader.


Fix strings for WebAssembly

Changes that allow loading a printing a frozen string. Includes:

Implement ldnull and ldind
Fix brtrue and brfalse for pointers
Fix the polarity of ceq and friends
Change functions we can't compile into traps so that they don't break LLVM
Put call arguments in the right order
Miscellaneous stack canonicalization fixes (we'll have to revisit this in a more comprehensive way soon)
Minor diagnosability improvements

Ugh... I'm bad at rebasing apparently. Please ignore files outside the WebAssembly directory.

An approach that can be used to rebase using command line git is using pull command with --rebase switch, f.ex.
cd corert
git checkout FixStrings
git remote add dotnet git@github.com:dotnet/corert
git pull --rebase dotnet master
git push -f

This will overwrite the history such that your commits will appear on top of latest dotnet/corert's master.

Thanks, @am11 , that fixed the history problem (I apparently rebased onto the wrong branch before). @davidwrighton , that interop file (and everything else that didn't make sense is gone now).


Unnecessary Dependency Installed in Docker Container

Describe the bug
DIND runner installs a number of dependency that seems to be unnecessary and even possibly harmful, for example netcat and telnet.
This binaries shouldn't be installed in the container unless there is a usage for them, in which case the usage should probably be reconsidered (especially for netcat since it is using insecure protocol). The rest of the dependencies should be reviewed and insured that the image doesn't have unnecessary applications installed.

@hi-artem Hey. Can you somehow verify that those binaries are not present in GitHub-managed runners VM images? If it isn't present there too and ARC works without those two, certainly we don't need those and those can be removed safely.

<EMAIL_ADDRESS>GHES 3.5 introduces support for the --disableupdate flag
Historically Actions didn't have proper container support and enforced the runner software being always at the latest, neither of these 2 things are true anymore once GHES 3.5 becomes generally avaliable. As a result we should be aiming to provide a slim runner for people to build off instead of a fat runner once GHES 3.5 is generally avaliable + some time for people to upgrade.

We've removed unnecessary packages from the newly released Ubuntu 22.04 runner images. Let me close this as resolved but please feel free to reopen if necessary!
Related: #2006 #2030


Roadmap

Roadmap to an actual working plugin:

[x] Save file -> runner mapping to disk
[ ] Better support for choosing which executable to run: allow changing an executable
[x] Tests
[ ] Support TEST_P
[ ] Warn if the compiled executable is stale (by checking mtime)
[x] Support debugging
[x] Add configuration (colors, edge-case choices, etc.)
[ ] Documentation

For p.2 ideally it should be a button in neotest test window that would allow to pick which tests to run with which executable. Should also provide an actual UI with paths and all to configure it (minui?)
Once that's done, consider possible solutions for the following edge cases:

Interleaving namespaces (currently leads to "run nearest" being wonky, no obvious solution without a gigantic refactoring of neotest itself)
A namespace spread across multiple files (currently treated as two different namespaces)

Could also be cool to use cmake-tools.nvim to automatically populate the "executable" field.

Warn if the compiled executable is stale (by checking mtime)

On a similar note, could have the prompt be something like "Build with CMake? build / run without building / cancel"

Interleaving namespaces (currently leads to "run nearest" being wonky, no obvious solution without a gigantic refactoring of neotest itself)

Even with tests right next to each other, e.g.
TEST(A, B) { /* ... */ }
TEST(A, C) { /* ... */ }
TEST(D, E) { /* ... */ }

it acts wonky. Tricky problem though.

I'll look into integrating with cmake-tools.
Another idea was to use marks in the summary window, since that's probably far more convenient than entering everything manually. Ideally I think it should be using build tool interface (cmake, bazel, makefiles even) and manual specification as a fallback.

@alfaix Is TEST_F also no yet supported? Cannot seem to get it to detect the tests there

@jla2000 TEST_F should be working, or at least is working in integration test (see tests/integration).
Could you please follow these steps:

Update neotest and neotest-gtest.
Go to neotest-gtest/tests/integration.
Build the test executable (see Makefile).
Run the tests like you usually do via notest.

If integration tests work for you, please try to create a minimal reproducible example of tests that don't work.
Otherwise, please create an issue, including your neovim version and describing precisely what happens when you run tests.

@alfaix Sure thing, I will try these steps out once I'm back on the project and create an issue otherwise :)
Also about this integration with cmake-tools.nvim, there is already this small plugin here https://github.com/hfn92/cmake-gtest.nvim that could be useful when trying to implement this feature

@alfaix It does actually work now for me, but it took a bit of time. I tried running lua require("neotest").run.run() a few times until i got finally a prompt to specify the executable. In between I got the message "no tests found" from neotest. I guess some indexing is performed in the background. For me it is not really usable yet tho, as I would need to specify also the inherited working directory for the test executable. This would be another property that could be inherited from cmake-tools as it can be configured there.

Hey @jla2000, the "no tests found" thing is probably because root was not found. I think it's reasonable to put a warning if a test file (like test_something.cpp) is found, but root directory is not - I'll put it on my todo list :)
Regarding CMakeLists.txt: I don't think it's a good default. It is usually not only present in the root directory, but also in nested directories. This will lead to each sub-directory maintaining a separate adapter, which will lead to all kinds of annoyances. Unlike Bazel's BUILD/WORKSPACE, CMake does not have a file that is only in root directory, at least as far as I know.
I think .git alone covers 90% of use cases, but if CMakeLists.txt works for you personally - you can always provide your own root function via config.

Hey @galou, I pushed some big changes and updated README.md with usage. Please let me know if that makes it clear. I'm closing this issue as the plugin is more-or-less full-featured now, and I'll keep track of further improvements in separate issues.


Allow configurable assertion recipient field. Simplify assertion template creation

For deployment in multiple environments, there's a need to allow the recipient value in the Assertion to be configurable.
Simplify the assertion template creation to always create the template for every POST call to spcp. This would ensure that the 'issueInstant' field is always set with the latest date and time.

Given that you are an external contributor, would you be happy to fill up and sign the following CLA please? Thanks!

Hello @marvinkhristianzamora - have you had a chance to look at this?

Hi, I've signed the CLA and pushed latest updates based on your comments
Marvin Khristian Zamora
<EMAIL_ADDRESS>On Mon, Apr 8, 2019 at 8:27 AM LoneRifle<EMAIL_ADDRESS>wrote:

Hello @marvinkhristianzamora https://github.com/marvinkhristianzamora -
have you had a chance to look at this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opengovsg/mockpass/pull/14#issuecomment-480646965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNl0RJBcM3VcIPjcT61g7XrNkb_9k9pks5veo0OgaJpZM4cRc31
.

@marvinkhristianzamora just deleting a comment so that your email address is not disclosed


test_occ not implemented?

While I run FFB6D on Linemod, I noticed that validation on occluded Linemod was not implemented in your code.
I am wondering if I missed your implementation of the occluded Linemod somewhere, or will you add this feature for validation in the future?

That part of code hasn't been reconstructed for open source. I will add it to my to-do list as I'm busy with other projects these days.

I found that Linemod_preprocessed has processed LM_O information included mask_all and gt.yml in 02.  Do you use this information for testing？

In addition, I would like to confirm whether the published pre-training weights can get the LM_O results in the paper. Thank you.

As I understood, usually LM_O used the same weights as LM, because it doesn't have training data for LM_O.
@ethnhe Does it right??
@Mr2er0  Have you evaluated the LM_O??

As I understood, usually LM_O used the same weights as LM, because it doesn't have training data for LM_O. @ethnhe Does it right?? @Mr2er0 Have you evaluated the LM_O?? I also found --test_occ, the function doesn't work.
https://github.com/ethnhe/FFB6D/blob/3579a69df27451f74f3abc06964bba1bc7d40605/ffb6d/train_lm.py#L84

I write my own code for test LM_O. But i find that it works badly in the symmetrical objects while others work normally

As I understood, usually LM_O used the same weights as LM, because it doesn't have training data for LM_O. @ethnhe Does it right?? @Mr2er0 Have you evaluated the LM_O?? I also found --test_occ, the function doesn't work.
https://github.com/ethnhe/FFB6D/blob/3579a69df27451f74f3abc06964bba1bc7d40605/ffb6d/train_lm.py#L84

I write my own code for test LM_O. But i find that it works badly in the symmetrical objects while others work normally

Hi, I am trying to test conduct testing for LM_O, but codes from PVNet do not work well, can you help me with that?

@Mr2er0 @William-Klay @taeyeop-lee Brothers, have you solved this problem? I also encountered the same problem when testing occ. In addition, do you have any ideas on invisible surface percentage?


update babylon.max.js for 32bits support in index streams

fixes #321
related PR on babylonjs : https://github.com/BabylonJS/Babylon.js/pull/8550

What version of Babylon.js is this? What version of the @babylonjs/core NPM package has this fix?

built from my babylonjs branch that is not yet merged into master.

That PR has since been merged into Babylon.js. Just for the sake of easy record-keeping (makes it easier to understand the history of babylon.max.js when debugging regressions), can we take a version built from Babylon.js master and include in a comment here the commit ID from which the change was built?

That PR has since been merged into Babylon.js. Just for the sake of easy record-keeping (makes it easier to understand the history of babylon.max.js when debugging regressions), can we take a version built from Babylon.js master and include in a comment here the commit ID from which the change was built?

When a Babylon.js release is created, the built version of babylon.max.js is checked in to the babylonjs repo as well. Ideally I think we should just grab those since they are built by the automated build system and less likely to have any human error (like accidentally having a local change or something like that). Maybe this is the same thing @syntheticmagus is saying, not sure.

@ryantrem It's a step beyond what I was saying. I like it, though.

I think this is the alpha 26 release that has the change: https://github.com/BabylonJS/Babylon.js/blob/61c67dddd783d4d7b1fff039cd7b3b224a26ed32/dist/preview release/babylon.max.js

Closed because of PR https://github.com/BabylonJS/BabylonNative/pull/350


Fix reference to std::swap

This caused a build error on my system
4.12.5-gentoo

COLLECT_GCC=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.3/gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/4.9.3/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-4.9.3/work/gcc-4.9.3/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/4.9.3 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/4.9.3/python --enable-languages=c,c++,java,fortran --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo 4.9.3 p1.5, pie-0.6.4' --enable-libstdcxx-time --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point --enable-targets=all --enable-libgomp --disable-libmudflap --disable-libssp --disable-libcilkrts --enable-lto --without-cloog --enable-libsanitizer
Thread model: posix
gcc version 4.9.3 (Gentoo 4.9.3 p1.5, pie-0.6.4)

Mozc team is not accepting pull requests at the moment.
Although Google company policy certainly allows Mozc team to accept pull
requests, to do so Mozc team needs to move all Mozc source files into
third_party directory in the Google internal source repository [1].
Doing that without breaking any Google internal project that depends on
Mozc source code requires non-trivial amount of time and engineering
resources that Mozc team cannot afford right now.
Mozc team continues to seek opportunities to address this limitation,
but we are still not ready to accept any pull request due to the above
reason.
[1]: Open Source at Google - Linuxcon 2016

License Compliance

We store all external open source code in a third_party hierarchy,
along with the licenses for each project. We only allow the use of OSS
under licenses we can comply with.
Use of external open source is not allowed unless it is put in that
third_party tree.
This makes it easier to ensure we are only using software with
licenses that we can abide.
This also allows us to generate a list of all licenses used by any
project we build when they are released externally.

Happy to contribute :)


expose recipient variables for page extensibility

Modify EmailDialog to move the recipient address variables (ToRecipient, CcRecipient, BccRecipient) into the protected scope and enable setting those variables into the (not publicly accessible) EmailMessage variable via the new (public) SetRecipients procedure.
With that, one can then implement a page extension that manipulates the (To,Cc,Bcc) input using the OnBeforeValidate and OnAssistEdit triggers for each field.

This is a follow on PR to (now closed) PR #12559.
I have changed the implementation to access the (non public) EmailMessage variable via a setter procedure for the recipient data.
In retrospect, perhaps also adding a getter procedure would be useful.

I will update per the OnLookup design pattern.
I am closing this PR, will open a new one.


Unification of unit tests for v0.8

We have several unit pytest codes in tests directory. For Release v0.8, it is useful to make a single code that unifies these unit tests.
or to make
pytest tests/

works.

done

shirochan:~/exojax(testunif)>pytest tests
================================================= test session starts ==================================================
platform linux -- Python 3.8.8, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: /home/kawahara/exojax
plugins: anyio-2.2.0
collected 18 items

tests/atm/am01_test.py ...                                                                                [ 16%]
tests/auto/autort_test.py ..                                                                                [ 27%]
tests/auto/autoxs_test.py ...                                                                                [ 44%]
tests/xs/erfcx_test.py ..                                                                                [ 55%]
tests/xs/expint_test.py .                                                                                [ 61%]
tests/xs/hjert_test.py .                                                                                [ 66%]
tests/xs/ljert_test.py .                                                                                [ 72%]
tests/xs/f64/erfcx_f64_test.py ..                                                                                [ 83%]
tests/xs/f64/expint_f64_test.py .                                                                                [ 88%]
tests/xs/f64/hjert_f64_test.py .                                                                                [ 94%]
tests/xs/f64/ljert_f64_test.py .                                                                                [100%]


Change recommended directive order

Since handle and route can contain directives that write responses, I think it's best to have it ordered before handle to avoid issues, as per https://caddyserver.com/docs/caddyfile/directives#directive-order

Thanks for this PR!


Enable specifying text color and disabled text color for an SnackBarAction widget.

This is a straightforward pr to add support for changing the text color and disabled text color for an SnackBarAction widget. It seems required especially since the SnackBar widget allows users to specify the background and text colors of the snackbar.

Thanks for the PR!
This looks good, but it will need tests to make sure that the colors are being applied if set.

@gspencergoog is it the author's responsibility (me) to add the tests, or you guys will manage?

Usually, yes, it's the author's responsibility to add tests.  If you don't have time, or the PR is abandoned  we may eventually get to it and add them, in line with other priorities, but we can't approve it/merge it until it has tests (see https://flutter.io/design-principles/).

@gspencergoog sounds good, I'll add the tests :)


How can i measure test accuracy using test dataset?

hi @absmahi01 .
You can use Trainer.test() function for that.
https://docs.deci.ai/super-gradients/docstring/training/sg_trainer.html#training.sg_trainer.sg_trainer.Trainer.test
hope that helps


Integrate currency changes

Can we have this changes merged into this repo?
https://github.com/learnpainless/country_currency_pickers
I need to use these currency features as well on my app but I'd like to have them on the original repo.
Also that repo is missing the language support, something that you have covered here

I found myself looking for this again after updating to Flutter 2. Any plans to provide some currency support @figengungor?


Synchronize original list with pip package

Hello
Do you have any plan to keep both projects synchronized automatically? That would be great.
Just replicate this file.
Ty

I don't currently have any plans to automate the updates. Currently it is a very brief manual process.
Do you have any proposal for how it should be done?

Do you have any proposal for how it should be done?

Thanks for the reply. My experience with github is limited, but I think that we can do something like this

Crawl this url

Update local dev environment with the data from crawl

Run a cron weekly, for example, to keep local project synchronized with original source. Then update this project based in local project.

What do you think?

At the moment, I update this package within ~24 hours of changes made to the parent repo. A cron job running weekly would be less responsive (but perhaps more dependable).
I would rather have updates coincide with merge events in the source repo than have to periodically crawl it.
Furthermore, I'm not too interested in maintaining some kind of infrastructure for this, especially because said infrastructure would need the ability to upload a package to PyPI with my credentials.
It may be possible to do this with a CI like Travis, although I haven't looked into it. If there was a solution which fit my concerns though, I'd be very open to it.

This is effectively done now, #18 was a fully automated PR and release. This uses a Travis cron job to check for changes from the source repo and make a pull request if necessary. I manually merge the PR, and it get automatically deployed to PyPI.


Just trying io instead of having poll_read and poll_write?

Please excuse my potential ignorance - I'm just trying to be helpful.
I am investigating tokio/futures , and it seems tokio is very much like internals of mioco - mioco is driving coroutines, tokio is driving tasks, both based on readiness, both using mio.
When I stumbled upon: https://github.com/tokio-rs/tokio-core/blob/master/src/reactor/io_token.rs#L13 , and investigated a bit more, I am wondering why are poll_read and poll_write needed at all.
I have never really seen a need to just check if IO is probably ready. In mioco one just attempt to do IO, and it works or not. As everything is driven by event loop, and spurious notifications are rare, failed attempt are very rare. So it seems to me that poll_read and poll_write are only slowing down the hot-path.
Eg. here: https://github.com/tokio-rs/tokio-core/blob/c9554fa1746b5ca54952570123f1d2f44917a8f9/src/net/udp.rs#L75 - after poll_write one still has to check result of send_to as it's still possible that it will return an WouldBlock (eg. when fd was cloned etc. and there are parallel accesses to it). Sometimes io can even succeed, when it was considered to be blocked, so why not take a chance? :)
By removing poll_read and poll_write, sharing readiness with reactor is unnecessary. In fact, AFAIR mioco does not keep any per-IO or per-task readiness information at all. I had it at the beginning and then I just removed it all together. If there is a notification, mioco just dispatches it to corresponding coroutine (task in tokio) and that's all. Even checking if given token still belongs to a given task is unnecessary : worst thing will happen is that task will be waken up needlessly, but since it happens very, very rarely, it's the hotpath that is important. And in futures, polling a future is much cheaper than switching to coroutine so it's even better tradeoff, I believe.
It seems to me all these Arcs, and atomic accesses are just holding back the performance, and considering how similar mioco dispatching works, might be the only reason why in the benchmark tests mioco is still doing quite well against tokio (sometimes still having better perf.).

There are other small differences in how tokio and mioco reactor are implemented, and if you think it's worth it, I could dig more into analyzing them and see if anything from mioco could potentially benefit tokio.

Yes, spurious notifications might be rare. However, note that a single task might be driving many different I/O operations simultaneously. When such a task is awakened, it could very well make many poll_read() or poll_write() calls that return WouldBlock, even as it does make progress on the I/O operation that triggered the wakeup.
Suppose future1 is waiting on udp_socket1.send_to() and future2 is waiting on udp_socket2.send_to(), and these two futures are joined in a single task as future1.join(future2). If udp_socket2 becomes ready, then the task will awakened and the implementation of Join needs to call both future1.poll() and future2.poll() because it has no way of knowing which is actually ready. So in this case, the poll_write() method prevents the task from making a probably-unsuccessful syscall on udp_socket1.
As far as I understand, in the mioco equivalent of join() each branch would be its own userspace thread, receiving its own notifications. This differs from futures-rs, where branch of a join() is still executed in the same task.

As @dwrensha said (quite well), it is quite important to avoid syscalls if at all possible and a single task, at the very least, is probably managing both read & write, if not more than one I/O handle.
Hopefully this makes sense, I'm going to close the issue. Feel free to reopen / open a new one if  you have more questions.

I see. But the each IO has it's own token? So couldn't poll_write test be just if current_token == notified_token?

@dpc yeah all I/O tokens have their own mio token, but futures then need to understand why they woke up (e.g. what set of tokens caused them to start polling again). That's not possible with the Future::poll interface (no arguments) but is possible with the task::with_unpark_event interface for futures to learn precisely why they woke up.

@alexcrichton I'm sorry, I don't understand. One still has token that caused the wakeup, and all Event information, and they still can be passed to the task, I believe.


New version: Lime3DS.Lime3DS version 2110

Pull request has been created with komac v2.2.1 :rocket:

Resolves #151164

Microsoft Reviewers: Open in CodeFlow

@BiosPlus is it possible also to add a link to the QT frontend?
It is the lime-qt app in the ZIP.

@BiosPlus is it possible also to add a link to the QT frontend? It is the lime-qt app in the ZIP.

Wouldn't be possible as it would require extracting the whole contents of the zip dir for the QT interface to work.


hack to generate structs

Toying with the idea, so hacked something to show the ability to generate struct's from DT nodes.  Not sure if this is useful or not, but wanted to put it out there for thought.

Might have potential but we need to see how it looks when things are generated, especially for complex node content and non-required properties.

Might have potential but we need to see how it looks when things are generated, especially for complex node content and non-required properties.

Yeah, we should really be generating this based on the binding not on the node itself.

Could see some value for pinmux.

Yeah, we should really be generating this based on the binding not on the device node itself.

I didn't realize it wasn't based on the binding.  Yes, it should come from the binding and go into some header somewhere that need only be included by modules that need it.

Agree that generating structs from a node should come from the binding.
I also hope we can take this new development as a chance to get away from the label property being so central, and find a solution for emitting structures which convert phandles to real pointers to the corresponding struct devices.


Improved DatasetNotFound error

Summary

The goal of this PR is to improve infromation reported by DatasetNotFound error. Now it tries to show what file we are looking for
How to test

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2022 CVAT.ai Corporation
#
# SPDX-License-Identifier: MIT

Not relevant anymore, all improvements to this error were fixed in cvat#7923