Update checkout and upload-artifact actions versions

It is not apparent from the build checks, but these changes are failing the workflow: https://github.com/dorny/test-reporter/actions/runs/8596798196

@jozefizso interesting, I do not think it is related to my changeset actually. Am I the first outside contributor who had auth problems for the download artifact action in this pipeline?

https://github.com/dorny/test-reporter/pull/420 created this and just realized the CI action ignores the *.md.

Related: https://github.com/dorny/test-reporter/issues/343


new integrator fees flow + support for eth fees

Classic transfer
9000 (positive_value_cost) + 2600 (cold_address_access_cost) - 2300 (call_stipend) + ?? (execution_cost) ~= 9300
Selfdestruct transfer
5000 (selfdestruct_cost) + 2600 (cold_address_access_cost) = 7600
Diff 1700
Actual diff 1778


Backport #783

Description of changes
First backport to the 3.3 release. I'm splitting this change out into its own PR because it needs manual review since nothing cherry picked cleanly 😢 In summary, this PR is a backport of #783, plus the followup changes made in #996 and #1017. The PolicySet JSON format in this PR matches what will be released in v4.0.

Adds new variants to JsonDeserializationErrorContext and FromJsonError (neither of which is pub used in 3.x)
Adds new variants to PolicySetError (marked as non-exhaustive in the public API)
Adds APIs PolicySet::from_json_* and PolicySet::to_json

CI is failing due to the following semver failure. Are we still happy to take this as a minor, or should I try to fix?
--- failure auto_trait_impl_removed: auto trait no longer implemented ---

Description:
A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented.
        ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.33.0/src/lints/auto_trait_impl_removed.ron

Failed in:
  type PolicySetError is no longer UnwindSafe, in /home/runner/work/cedar/cedar/head/cedar-policy/src/api.rs:[23](https://github.com/cedar-policy/cedar/actions/runs/10290272128/job/28479855569?pr=1123#step:8:24)11
  type PolicySetError is no longer RefUnwindSafe, in /home/runner/work/cedar/cedar/head/cedar-policy/src/api.rs:2311
     Summary semver requires new major version: 1 major and 0 minor checks failed

I personally don't know that anyone cares about UnwindSafe

Need a re-approval now that I've applied review suggestions.


Improve connect wallet functionality

Not needed right now so closing this issue. this issue is caused by my wallate only.


"TypeError: key.charAt is not a function" in Model.toJSON

TypeError: key.charAt is not a function
    at assignJsonValue (../node_modules/objection/lib/model/ModelBase.js:666:11)
    at ../node_modules/objection/lib/model/ModelBase.js:647:5
    at ../node_modules/objection/node_modules/lodash/lodash.js:4714:15
    at Function.forEach (../node_modules/objection/node_modules/lodash/lodash.js:9011:14)
    at toJsonImpl (../node_modules/objection/lib/model/ModelBase.js:646:20)
    at Video.$$toJson (../node_modules/objection/lib/model/ModelBase.js:430:16)
    at Video.$toJson (../node_modules/objection/lib/model/Model.js:347:19)
    at Video.toJSON (../node_modules/objection/lib/model/ModelBase.js:226:17)
    at Object.stringify (native)
    at ../node_modules/cache-manager-redis/index.js:196:22
    at ../node_modules/cache-manager-redis/index.js:53:7
    at dispense (../node_modules/generic-pool/lib/generic-pool.js:251:16)
    at Object.me.acquire (../node_modules/generic-pool/lib/generic-pool.js:321:5)
    at RedisPool.acquire (../node_modules/sol-redis-pool/index.js:101:14)
    at connect (../node_modules/cache-manager-redis/index.js:42:10)
    at Object.self.set (../node_modules/cache-manager-redis/index.js:192:5)
    at ../node_modules/cache-manager/lib/caching.js:116:32
    at ../node_modules/cache-manager/lib/caching.js:52:21
 key.charAt is not a function

    at runCallback (timers.js:570:20)
    at tryOnImmediate (timers.js:550:5)
    at processImmediate [as _immediateCallback] (timers.js:529:5)
From previous event:
    at ../node_modules/cache-manager/lib/caching.js:51:18
    at ../node_modules/cache-manager/lib/caching.js:105:17
    at Command.callback (../node_modules/cache-manager-redis/index.js:87:9)
    at normal_reply (../node_modules/redis/index.js:714:21)
    at RedisClient.return_reply (../node_modules/redis/index.js:816:9)
    at JavascriptRedisParser.Parser.returnReply (../node_modules/redis/index.js:188:18)
    at JavascriptRedisParser.execute (../node_modules/redis-parser/lib/parser.js:415:12)
    at Socket.<anonymous> (../node_modules/redis/index.js:267:27)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:177:18)
    at Socket.Readable.push (_stream_readable.js:135:10)
    at TCP.onread (net.js:542:20)

I have a model with a length property. ModelBase#toJsonImpl() is calling the Lodash each function on line 507:
  _.each(model, (value, key) => {
    assignJsonValue(json, key, value, omit, pick, omitFromJson, createDbJson);
  });

The each implementation does not work with objects that include a length property. If an object has a length property, each treats it as an array and returns the wrong type of iterator. (See isArrayLike() @ lodash.js:4706 and lodash.js:11020) This behavior is also mentioned in the Lodash forEach documentation.
If Model.toJSON always acts on a single model object, as opposed to an array or collection of objects, it may be more appropriate to use either the Lodash forOwn or Lodash forIn method to iterate the keys, rather than each. I have replaced each with forOwn on line 646 in the transpiled source and it seems to be working with my models.
  _lodash2.default.forOwn(model, function (value, key) {
    assignJsonValue(json, key, value, omit, pick, omitFromJson, createDbJson);
  });

However, I see that each is being used quite a bit and am wondering if it should be replaced in other areas, too.
Thanks!

This is already fixed in 39cbad7823036a8b09963a41b81e8dc4708ec8da. Not yet released though.


docs: fix bundle

Current dependencies on/for this PR:

main

PR #2399   👈

This comment was auto-generated by Graphite.


Makefile contains wrong version reference for 2.8

Installation of version 2.8 fails with

ERROR: Could not install packages due to an EnvironmentError: [Errno 2]  file cbmc_viewer-2.0-py3-none-any.whl not found

See:
https://github.com/awslabs/aws-viewer-for-cbmc/blob/2085aac8d1c31528ae042ed375c320b0d8d14463/Makefile#L65

I met this same issue, and I can install successfully by changing it to "dist/cbmc_viewer-2.8-py3-none-any.whl"

I will fix this.
General users should be installing the pip package on the release page: https://github.com/awslabs/aws-viewer-for-cbmc/releases/tag/viewer-2.8


Systemd check on Raspberry Pi fails

Hi there,
I have just tried using the server_install script on a Raspberry Pi and the systemd check fails....
I think it should be checking for the existence of /etc/systemd/system on the Pi not /run/systemd/system...
Jon

Yes actually that is correct,

Thanks, yes ive merged that pull request now.


Wi-Fi connections not working on production hardware

@kliment and I can both successfully scan for wifi networks with the "Wi-Fi Config" app, but not connect, with the production hardware.
Enabling debug logging, everything proceeds the same until
D (17950) wifi:connect_bss: auth=1, reconnect=0
I (17960) wifi:state: init -> auth (b0)
D (17970) wifi:start 1s AUTH timer
D (17980) wifi:clear scan ap list
D (16880) event: running post SYSTEM_EVENT:2 with handler 0x4206f0b8 and context 0x3fce933c on loop 0x3fce83e4
I (18000) wifi: STA_START
D (18980) wifi:auth timeout
I (18980) wifi:state: auth -> init (200)
D (18990) wifi:connect status 1 -> 4
D (19000) wifi:stop beacon/connect timer
D (19030) wifi:stop CSA timer

whereas on the devboard I get
D (16226) wifi:connect_bss: auth=1, reconnect=0
I (16236) wifi:state: init -> auth (b0)
D (16246) wifi:start 1s AUTH timer
D (16256) wifi:clear scan ap list
D (15156) event: running post SYSTEM_EVENT:2 with handler 0x4206ee64 and context 0x3fce914c on loop 0x3fce81f4
I (16276) wifi: STA_START
D (16296) wifi:recv auth: seq=2, status=0
I (16296) wifi:state: auth -> assoc (0)

When trying to run in AP mode, it appears to start correctly but I can't see the AP from any other device (and when running the same test code on a devboard, I can). So it does look like the badge is unable to successfully transmit anything.
I tried running the CPU at 80MHz instead of 160MHz in case it was a power issue. Behaved the same.
Run out of ideas for today...

Resolved with whispering and magic caps


Add data and training process to the README.md

We need to explain how to get the original CM2.6 data and re-train the model.
(Entry on Pangeo catalog: https://catalog.pangeo.io/browse/master/ocean/GFDL_CM2_6/GFDL_CM2_6_control_ocean_surface/)

note that the data is accessed via some Python libraries (zarr?) that mean it doesn't have to download the whole set, only the relevant data being accessed

#60 adds to the README.md#data-processing what dataset we use, where it is stored, how to use it, and some common troubleshooting.


feat: infer user language

Per the request of @Zmicier21 , we'll leverage Navigator.languages to pick a better default choice for the UI language.
This should improve a bit conversion for the new users, I believe, too. 🤷♂  🙂

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 14 (78.57%)  changed or added relevant lines in 5 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 29.578%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Pages/Settings/Settings.tsx
0
1
0.0%

src/index.tsx
0
1
0.0%

src/utils/getPreferredLanguage/index.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/Pages/Settings/Settings.tsx
1
0%

src/index.tsx
1
0%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1329

Relevant Lines:
5489

💛  - Coveralls


Need sample of report

Hello, it would be very helpful to see how the graphs will look on this report. I'm working with an environment that doesn't have much data but I need to show the users how the report will look.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 867e9d23-090a-106a-4bf8-35a0d37cfd83
Version Independent ID: d826e1c7-7e02-918f-7a04-ee47028c40ed
Content: Purchase spend analysis Power BI content - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/analytics/purchase-content-pack-for-power-bi.md
Service: dynamics-ax-platform
GitHub Login: @FrankDahl
Microsoft Alias: fdahl

Bug #291721 has been logged to track this issue.

Samples have been added to this topic and will be published later today.


Update already fetched locale-based data in activities and fragments that reside in the backstack after changing locale.

This is not an issue with lingver but more like the followup that I've never figured out.
In light of

Note that you need to update all already fetched locale-based data manually. Lingver is not responsible for that.

I understand that Lingver's responsibility ends after updating the locale using
Lingver.getInstance().setLocale(this, language)
what I have is a button in a custom ActionBar, pressing that button calls the Lingver.getInstance().setLocale(this, language) and the ActionBar is used on every activity on the project, so that on any activity the user is able to change the language at any time by pressing that button.
the main issue is when there are activities and/or fragments that are already open in the backstack.
so what's the go-to approach? how can one change the data (e.g. TextView, RecyclerView, etc...) that are already fetched in activities and fragments that are on the backstack?
I've tried to override onConfigurationChanged inside my activity class and reset my views there
but it was never called even after adding android:configChanges="locale|layoutDirection" to the activity in the android manifest
I have also tried to call recreate() after using Lingver.getInstance().setLocale(this, language)
it does work as it resets the activity but it gave me literal hell for my viewpager and fragments configuration so I'm looking for potentially better alternatives.

Hi @Maxrang,
There is no silver bullet for refreshing the backstack. That's exactly the reason why Lingver doesn't do that for you.
In your case, I'd suggest keeping following the recreate() approach (btw you have to call it for each activity) making sure your activities/fragments correctly restore their state. I don't see any better alternative, unfortunately.

I've tried to override onConfigurationChanged inside my activity class and reset my views there
You can always implement a similar callback manually, but I'd not recommend this approach since it requires lifetime maintenance.

Every Activity should have which locale is used when they are created. In onResume(), you should check "localeWhenCreated==currentSelectedLocale", if not, recreate(). So, when you return back to Activity in stack, it will recreate itself. Beware, Fragments in Activity will still be there in FragmentManager after recreate.


Use uint packing instead of structs

This PR is made in preparation for #267.
I have also added #270.
This is a breaking change, as the internal _ownerships mapping is renamed to _packedOwnerships.

I had done something like that here in this repo:  https://github.com/0xPhaze/ERC721M/blob/master/src/ERC721MMC.sol
I even explored (but never implemented, because it was a lot of wrap/unwrap) using custom types for a packed uint256 to further guide access to its packed storage. This could be interesting for ERC721A.

I think it's still okay to directly write the bitwise ops inline to have a little more control.

Let's do one more poll to see how people feel about this


chore: remove the replace for keyring to support go install

remove the replace for keyring to support go install
Signed-off-by: saltbo<EMAIL_ADDRESS>

Thank you @saltbo for the contribution!


Update interactivity docs and helloworld app

Summary
This PR includes updates for documentation on Call/CallRequest structure changes and call type URL changes. It also includes an error response, and a field-specific error response.
It also adds some fields to the helloworld app's form, to match what's being used in the docs. 0/5 on what fields this app is supposed to support. Maybe it should be kept simple as it was with one field.
Ticket Link
https://mattermost.atlassian.net/browse/MM-30273
https://mattermost.atlassian.net/browse/MM-34160
Rendered
docs/02-example-post-menu.md
docs/03-example-interactivity.md

Codecov Report

Merging #112 (a6fca32) into master (90182d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   19.36%   19.36%
=======================================
  Files          28       28
  Lines        1188     1188
=======================================
  Hits          230      230
  Misses        943      943
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90182d4...a6fca32. Read the comment docs.

2/5 we should try to have more simple, targeted "Hello" apps rather than bundle more functionality into 1.

@levb I was mainly just committing the changes I used to generate the data used in the docs, but we can use a different app for that, like the test app https://github.com/larkox/mattermost-app-test . I agree that we should keep the hello app as simple as possible, like the plugin starter template.

@levb What is needed in terms of docs here?

@hanzei only a review/approval by @justinegeffen

@levb @justinegeffen Pretty much all the changes in this PR are just changing the JSON data in the docs. 3/5 I think we should merge this as-is, as I think it's high impact for external documentation for other devs. @justinegeffen Please leave comments for anything you think may need to change, and I can change in a followup PR as necessary.


Add ability to use ConfigMap to define Device UserData and CustomData

Device UserData and CustomData are lengthy fields that can benefit from reuse. Additionally, other Crossplane providers (provider-cloudinit), compositions, or other operators may manage the ConfigMap resources providing flexibility.
Is there a conventional format for spec.ForProvider fields that take can accept a configmap source?
The existing format is:
spec:
  forProvider:
    userdata: |
    ...

How should userdata from configmap be specified? Should this be presented as a new field?
spec:
  forProvider:
    userdataConfigMapRef:
      name: foo
      namespace: foo
      key: foo
      optional: false

Is it possible or recommended to have an alternate userdata syntax (alternate to the existing string format)?
spec:
  forProvider:
    userdata:
      valueFrom:
        kind: ConfigMap # should ConfigMap be the only resource-type? I think that's fair.
        name: foo
        namespace: foo
        key: foo
        optional: false

What pattern should be adopted for watching the specified ConfigMaps for changes?
Are additional fields needed to permit a redeploy behavior on ConfigMap changes? Would this behavior conflict with the existing immutable field experience? You can not change facility, but should that be the case? What should happen if ConfigMap is changed?
The Equinix Metal API allows for changes to the Userdata and Customdata fields after deployment. This does not trigger a rebuild on the EM side. The new values can be accessed from the metadata service. These fields have utility beyond boot time.
Immutable Infrastructure
Should the Device resource take a parameter (within spec, not forProvider) that defines the behavior to take? destroy OnUserdataChange: true? Would similar fields be needed for immutable parameters like facility which can not be updated in the EM API or would changes to these fields dictate a delete+create cycle?

@muvaf points out:

Hey! I think this could be considered similar to confidential data input where we use Secret  as input. Here is an example implementation. You could reuse existing *SecretKeySelector  or maybe implement it for configmaps as well.

https://github.com/crossplane/provider-aws/blob/master/apis/database/v1beta1/rdsinstance_types.go#L457-L471 serves as an example of a field that may either be offered as string or (through use of a second field) by reference.

Fixed in #55
Available in v0.0.7+


Add handle bcdbuddy

bcdbuddy

"Website" (http://babacar-cisse-dia.com/)
"Dev.to" (profile)

@bcdbuddy thanks for you opening the issue and following the template. Are you able to links that represent your work, like a blog post, conference talk, or video?
Please see the README for examples.

I've read the README. On my website you can see my work and on dev.to you can see some of my published blog posts. The drafts are available at bcdbuddy.github.io
Does this meet your expectations ?

https://github.com/bdougie/awesome-black-developers/blob/main/CONTRIBUTING.md#contributing
I am willing to make an exception for the GitHub Sponsors requirement since it is only available in 32 regions.  Considering sharing an additional link that shares your experience.
Criteria to add a developer:
* Content is about the experience of being the developer.
* The author of the content is describing their own experience.
* Projects linked must be open sourced and/or non-profit.
* Must have [GitHub Sponsors](https://github.com/sponsors/) enabled.

Oh I see. I have two open source projects:  (not being used by everyone though)

https://github.com/bcdbuddy/carousel-slider
https://github.com/bcdbuddy/validator

I am not sure that I have a content describing my experience as developer or my own experience. I'll work on that some day in the future. I won't mind if you close this issue. Nice chat :+1:

Looking forward to reading your content.


The road to v1.0.0

With Pyodide now supporting Python 3.11, I think it's time to start thinking about v1.0.0.

[x] Make sure all notebooks are up-to-date.
[x] Use Python 3.11's new typing features where appropriate. #124

Support in mypy is still spotty. Not going to wait on this one.

[x] #149
[x] #152
[ ] Lay out the argument for why Icepool exists, i.e. "why not just use AnyDice?"
[ ] What's my level of confidence in multiset_function?

Looks like mypy isn't quite there yet on TypeVarTuple. I'm not inclined to wait on this account.

We'll convert this to a milestone.


Updated Google Play Location Services SDK

com.google.android.gms:play-services-location:20.0.0 -> 21.0.1

Looks good to me

Thank you for your contribution


Fix incorrect file path for message_block_layout.md

Description of changes:
Fixed an issue with the file path structure: the first link to the message_block_layout.md file in the src/rationale directory was not accessible because the file should be located directly in the rationale folder. The link has now been corrected to point to the proper file location.

@rootulp @rach-id Thank you so much for your hard work! I hope this helps you !


Cosmos Java SDK Add substatus code for 503s

Port this to Java V4 SDK - https://msdata.visualstudio.com/CosmosDB/_git/CosmosDB/pullrequest/710037

Done.


timeout-related failure c_macos_dbg.bins/dbg/h2_compress_nosec_test resource_quota_server

Error Message

Failure
Standard Output

D0201 13:55:50.702816000<PHONE_NUMBER>64864 test_config.c:379] test slowdown factor: sanitizer=1, fixture=1, poller=1, total=1
D0201 13:55:50.703649000<PHONE_NUMBER>64864 ev_posix.c:107] Using polling engine: poll
I0201 13:55:50.703739000<PHONE_NUMBER>64864 resource_quota_server.c:53] Running test: resource_quota_server/chttp2/fullstack_compression
I0201 13:56:57.305368000<PHONE_NUMBER>64864 subchannel.c:706] Connect failed: {"created":"@1485986217.305044000","description":"Failed to connect to remote host: FD shutdown","file":"src/core/lib/iomgr/ev_poll_posix.c","file_line":453,"os_error":"Timeout occurred","referenced_errors":[{"created":"@1485986217.305000000","description":"connect() timed out","file":"src/core/lib/iomgr/tcp_client_posix.c","file_line":125}],"target_address":"ipv6:[::1]:1209"}
E0201 13:56:57.305595000<PHONE_NUMBER>64864 resource_quota_server.c:253] Unexpected status code: 4

*******************************
Caught signal 6
  no backtrace

https://grpc-testing.appspot.com/job/gRPC_pull_requests_macos/2377/testReport/junit/(root)/c_macos_dbg/bins_dbg_h2_compress_nosec_test_resource_quota_server/
PR: https://github.com/grpc/grpc/pull/9548

Previous instance: #9398

The unexpected status corresponds to GRPC_STATUS_DEADLINE_EXCEEDED.
I tried to reproduce this bug yesterday, unsuccessfully. I wonder if this just need some timeout tweaking. The slowdown factor is 1 in this case, and seems to always happen on the debug build. Perhaps 1.5 or 2 would be more appropriate.

seen again in https://github.com/grpc/grpc/pull/9563 against master
https://grpc-testing.appspot.com/job/gRPC_pull_requests_macos/2409/testReport/junit/(root)/c_macos_dbg/bins_dbg_h2_compress_nosec_test_resource_quota_server/

sec version of this seen in https://grpc-testing.appspot.com/job/gRPC_pull_requests_macos/2409/testReport/junit/(root)/c_macos_dbg/bins_dbg_h2_compress_test_resource_quota_server/
pr #9589 against master


Added checks for non-exisiting files in classpath converters.

After creating the PR, please add a commit that adds a bullet-point under the -SNAPSHOT section of CHANGES.md that includes:

[x] a summary of the change
[x] a link to the newly created PR

This makes it easier for the maintainers to quickly release your changes.

I ran spotlessApply before committing, but it still seems to fail?

Blast from the past!!!  Dunno why the line-endings got screwed up, but it's fixed now.  This mostly looks reasonable to me, but I've used this on a lot of machines in a lot of environments, and never bumped into this problem.  Can you describe a little about the environment that causes this problem?

Hi, this is Marc from Vela Solaris (writing from my private account).
If I remember correctly, I encountered the problem on an environment that had invalid classpath entries.

Published in 4.6.0


finamp: 0.9.8-beta -> 0.9.9-beta

Diff: https://github.com/jmshrv/finamp/compare/0.9.8-beta...0.9.9-beta
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 329061 run on x86_64-linux 1

3 packages built:

finamp
finamp.debug
finamp.pubcache


New package: ConfSets v0.1.0

Registering package: ConfSets
Repository: https://github.com/bergio13/ConfSets.jl
Created by: @bergio13
Version: v0.1.0
Commit: 46e9294fe71093a2d6aa08390293edc7522fe525
Git reference: HEAD
Description: Compute confidence Intervals (CLT, Chebyshev, Hoeffding) and Confidence Seqeunces (in a sequential setting if needed) in Julia

No auto merge


Enable all integration tests for the arrays encoding

[ ] ~Tests added for any new code~
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] ~Documentation added for any new functionality~
[ ] ~Entry added to UNRELEASED.md for any new functionality~

Draft PR to see the effect of running all integrations tests with the arrays encoding. Thanks to @gabrielamafra for help with the yml file.

Codecov Report

Merging #1461 (c81edec) into unstable (368c453) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           unstable    #1461      +/-   ##
============================================
- Coverage     74.96%   74.95%   -0.01%
============================================
  Files           359      359
  Lines         11510    11510
  Branches        533      533
============================================
- Hits           8628     8627       -1
- Misses         2882     2883       +1

Impacted Files
Coverage Δ

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
96.47% <0.00%> (-1.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368c453...c81edec. Read the comment docs.

This PR has been sitting as a draft for a while. Since it is blocked by #1589, I will close it and revisit this when the arrays encoding is more stable.


Setup CI/CD to run tests + deploy http://grsmto.github.io/simplebar/ and demo page automatically

Closed in<EMAIL_ADDRESS>


Fix for simulated button clicks for simulator button/pin inputs

The simulated click seemingly has no delay between mousedown and mouseup which is causing us to end up with unpredictable state in an already complex component. Switching from using state to refs seems to fix the issue, though I'm having trouble reasoning about this change and haven't explored the potential for any unwanted side effects of doing so.

Code-wise this makes sense to me. We only use mouseDown in event handlers and need it to be up-to-date (can't wait for a re-render). I'll play with it some more then approve.

Review link (not sure why missing):
https://review-python-editor-v3.microbit.org/optikey-fix/


Update limits-specifications-teams.md

Updating channels limits with new release to support 1K channels today. With this release we support any combination of standard and shared channels including up to 30 private channels for a total 1000 channels per team. Please reword as needed.

Finalizing changes, committed recommended changes per JohanFreelancer9

@JasonLewisMSFT, thank you for committing my suggestions, but I noticed that you have now closed the PR. Was that on purpose?

@JasonLewisMSFT, thank you for committing my suggestions, but I noticed that you have now closed the PR. Was that on purpose?

I thought I committed the changes.  Re-opening the PR now.

@JohanFreelancer9 I believe it is committed now?  If not let me know next steps.

@MicrosoftHeidi
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

When will the changes go live?

When will the changes go live?

@scanum

@MicrosoftHeidi
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Table: Grouped Header support

Feature
After iTwin/iTwinUI-react#153 was closed, Table now displays a header when a first-level Header is specified. However, support from grouped headers needs to be added
Examples
react-table Sandbox: https://codesandbox.io/s/github/tanstack/table/tree/main/examples/react/grouping?from-embed
iTwin/iTwinUI-react#153 Sandbox: https://codesandbox.io/s/shy-wind-1sp5q?file=/src/App.js

This will not be possible to achieve after #1072 and no one has requested it so I will close this. We can revisit after the upgrade to tanstack/react-table v8.


Remove unused files in Microsoft.IdentityModel.Protocols

Issue: #409

Hi @ChenYan98, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Yan Chen). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

:shipit:


Error code 50035, INTERACTION_APPLICATION_COMMAND_INVALID_VERSION

Hi everybody,
A few days ago I called the API fine, until today I am getting error
Code 50035, INTERACTION_APPLICATION_COMMAND_INVALID_VERSION,
"message": "This command is outdated, please try again in a few minutes".
I guess it is due to 2 param: session_id and version change.
If anyone has solved it, please guide me
Thanks

I've also encountered an issue where the bot's functionality has stopped working for me, except for the /hello command. Attempts to get it to interact with the other bot have been unsuccessful. I hope this issue can be resolved soon.🤞

Thank you for having reported this issue as soon as it has appeared. I think it's solved, feel free to test.
I did not ran all needed tests, if the issue persists, please reopen this thread

Thank you for having reported this issue as soon as it has appeared. I think it's solved, feel free to test. I did not ran all needed tests, if the issue persists, please reopen this thread

My problem has been solved. Thank you so much for your help

I appreciate your prompt and effective support.
It works beautifully now.
Cheers!

I appreciate your prompt and effective support! It works beautifully now.
Cheers!


SCSB Delete Directory is wrong

It's data-exports/PUL/Json/Incremental right now, but all the files right now are in data-exports/PUL/Json.
Change it in princeton_ansible.

@kevinreiss this is what we found while working on another ticket -- does it match your understanding? Any knowledge of this change?

No, I'd have to ask the vendor.

@hackartisan based on some info I found from the vendor I think we can use data-exports/PUL/Json safely.


feat(tracking): Record the page referrer for every event.

Overview

Record the page referrer for every event.

PR Checklist

[x] Related to JIRA ticket: REACH-1027
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60c1271553825400c1d013f7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60c14ad9f551f13bb17b6642--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60c16e9053825463e9d013b2--gamut-preview.netlify.appDeploy Logs


Logo above watermark commands animates every time it becomes visible

If I have one editor open, then close it, the vscode logo does the slide up animation. Is this by design? Maybe, but I thought maybe it's only supposed to happen the first time or something.

@bgashler1 Did you mention that is not intended?

This is not intended. See #12877
We can address it in October.

Closing so we can track in the original issue mentioned above.


Sakshi pr template

https://github.com/anuragverma108/WildGuard/issues/63
Pull Request Description
Description:
This pull request introduces a Pull Request (PR) template to the project. The purpose of the PR template is to standardize and improve the quality of pull request submissions by ensuring that contributors provide the necessary information. The template guides contributors to summarize their changes, link related issues, include testing details, and provide any relevant screenshots.
Added a pull_request_template.md file under the .github/template directory.
The template includes sections for description, key changes, related issues, screenshots, testing, types of changes, and a checklist for contributors.
Key Changes:
Added: .github/template/pull_request_template.md
Related Issue(s)
No related issues were resolved by this pull request.
Screenshots (if applicable)
No screenshots are applicable for this PR.
Testing
Not applicable. This change only adds a markdown file that will be used when creating pull requests.
Type of Changes
Documentation update (adding a PR template)
Checklist
I have read the contribution guidelines
My code follows the project’s coding style
I have performed a self-review of my code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works (N/A)
All new and existing tests passed (N/A)
Additional Notes
This PR template aims to improve the pull request process by making it easier for contributors to submit consistent, detailed, and high-quality PRs.

@anuragverma108  I have resolved the conflicts and suggested please check

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


New version: OSGeo.QGIS version 3.38.2 (3.38.2-1)

Created by 🥟 Dumplings in workflow run #7525.

Log
Updated: 3.38.1-1 → 3.38.2-1
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

This package installs and launches normally on a Windows 10 VM.

This package installs and launches normally on a Windows 10 VM.


Allow disabling retries

What would you like to be added:
Allow disabling request retries.
Why is this needed:
When using --request-timeout, the timeout applies to each individual request and not the command as a whole. If a context is unreachable, commands like kubectl exec (which don't retry) time out after --request-timeout. However, commands like kubectl get it will retry the command so it times out much later since it has to timeout multiple times before the command finishes.

@thatsmydoing Can you provide more information about what is happening.  For example can you run your command with -v9 to see what's going on with the retries?
/triage needs-information

Here's the output,
% kubectl -v9 --request-timeout=1s get pods
I0202 13:25:58.246099    4034 loader.go:373] Config loaded from file:  /home/thomas/.kube/config
I0202 13:25:58.247150    4034 round_trippers.go:466] curl -v -XGET  -H "Accept: application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList,application/json" -H "User-Agent: kubectl/v1.26.1 (linux/amd64) kubernetes/8f94681" 'https://privatecluster/api?timeout=1s'
I0202 13:25:58.486471    4034 round_trippers.go:495] HTTP Trace: DNS Lookup for privatecluster resolved to [{<IP_ADDRESS> }]
I0202 13:25:59.247588    4034 round_trippers.go:553] GET https://privatecluster/api?timeout=1s  in 1000 milliseconds
I0202 13:25:59.247697    4034 round_trippers.go:570] HTTP Statistics: DNSLookup 195 ms Dial 0 ms TLSHandshake 0 ms Duration 1000 ms
I0202 13:25:59.247750    4034 round_trippers.go:577] Response Headers:
I0202 13:25:59.247730    4034 round_trippers.go:508] HTTP Trace: Dial to tcp:<IP_ADDRESS>:443 failed: dial tcp <IP_ADDRESS>:443: i/o timeout
E0202 13:25:59.247897    4034 memcache.go:238] couldn't get current server API group list: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:25:59.247940    4034 cached_discovery.go:120] skipped caching discovery info due to Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:25:59.248216    4034 round_trippers.go:466] curl -v -XGET  -H "Accept: application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList,application/json" -H "User-Agent: kubectl/v1.26.1 (linux/amd64) kubernetes/8f94681" 'https://privatecluster/api?timeout=1s'
I0202 13:25:59.294454    4034 round_trippers.go:495] HTTP Trace: DNS Lookup for privatecluster resolved to [{<IP_ADDRESS> }]
I0202 13:26:00.248814    4034 round_trippers.go:553] GET https://privatecluster/api?timeout=1s  in 1000 milliseconds
I0202 13:26:00.248821    4034 round_trippers.go:508] HTTP Trace: Dial to tcp:<IP_ADDRESS>:443 failed: dial tcp <IP_ADDRESS>:443: i/o timeout
I0202 13:26:00.248887    4034 round_trippers.go:570] HTTP Statistics: DNSLookup 46 ms Dial 954 ms TLSHandshake 0 ms Duration 1000 ms
I0202 13:26:00.248941    4034 round_trippers.go:577] Response Headers:
E0202 13:26:00.249071    4034 memcache.go:238] couldn't get current server API group list: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:00.249112    4034 cached_discovery.go:120] skipped caching discovery info due to Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:00.249172    4034 shortcut.go:100] Error loading discovery information: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:00.249493    4034 round_trippers.go:466] curl -v -XGET  -H "Accept: application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList,application/json" -H "User-Agent: kubectl/v1.26.1 (linux/amd64) kubernetes/8f94681" 'https://privatecluster/api?timeout=1s'
I0202 13:26:00.267282    4034 round_trippers.go:495] HTTP Trace: DNS Lookup for privatecluster resolved to [{<IP_ADDRESS> }]
I0202 13:26:01.249705    4034 round_trippers.go:553] GET https://privatecluster/api?timeout=1s  in 1000 milliseconds
I0202 13:26:01.249810    4034 round_trippers.go:570] HTTP Statistics: DNSLookup 17 ms Dial 0 ms TLSHandshake 0 ms Duration 1000 ms
I0202 13:26:01.249824    4034 round_trippers.go:508] HTTP Trace: Dial to tcp:<IP_ADDRESS>:443 failed: dial tcp <IP_ADDRESS>:443: i/o timeout
I0202 13:26:01.249843    4034 round_trippers.go:577] Response Headers:
E0202 13:26:01.249988    4034 memcache.go:238] couldn't get current server API group list: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:01.250021    4034 cached_discovery.go:120] skipped caching discovery info due to Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:01.250316    4034 round_trippers.go:466] curl -v -XGET  -H "Accept: application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList,application/json" -H "User-Agent: kubectl/v1.26.1 (linux/amd64) kubernetes/8f94681" 'https://privatecluster/api?timeout=1s'
I0202 13:26:01.293927    4034 round_trippers.go:495] HTTP Trace: DNS Lookup for privatecluster resolved to [{<IP_ADDRESS> }]
I0202 13:26:02.251233    4034 round_trippers.go:553] GET https://privatecluster/api?timeout=1s  in 1000 milliseconds
I0202 13:26:02.251382    4034 round_trippers.go:508] HTTP Trace: Dial to tcp:<IP_ADDRESS>:443 failed: dial tcp <IP_ADDRESS>:443: i/o timeout
I0202 13:26:02.251410    4034 round_trippers.go:570] HTTP Statistics: DNSLookup 43 ms Dial 0 ms TLSHandshake 0 ms Duration 1000 ms
I0202 13:26:02.251487    4034 round_trippers.go:577] Response Headers:
E0202 13:26:02.251634    4034 memcache.go:238] couldn't get current server API group list: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:02.251680    4034 cached_discovery.go:120] skipped caching discovery info due to Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:02.252100    4034 round_trippers.go:466] curl -v -XGET  -H "User-Agent: kubectl/v1.26.1 (linux/amd64) kubernetes/8f94681" -H "Accept: application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList,application/json" 'https://privatecluster/api?timeout=1s'
I0202 13:26:02.302131    4034 round_trippers.go:495] HTTP Trace: DNS Lookup for privatecluster resolved to [{<IP_ADDRESS> }]
I0202 13:26:03.253063    4034 round_trippers.go:553] GET https://privatecluster/api?timeout=1s  in 1000 milliseconds
I0202 13:26:03.253155    4034 round_trippers.go:508] HTTP Trace: Dial to tcp:<IP_ADDRESS>:443 failed: dial tcp <IP_ADDRESS>:443: i/o timeout
I0202 13:26:03.253216    4034 round_trippers.go:570] HTTP Statistics: DNSLookup 49 ms Dial 950 ms TLSHandshake 0 ms Duration 1000 ms
I0202 13:26:03.253260    4034 round_trippers.go:577] Response Headers:
E0202 13:26:03.253355    4034 memcache.go:238] couldn't get current server API group list: Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:03.253381    4034 cached_discovery.go:120] skipped caching discovery info due to Get "https://privatecluster/api?timeout=1s": net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
I0202 13:26:03.253466    4034 helpers.go:264] Connection error: Get https://privatecluster/api?timeout=1s: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Unable to connect to the server: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
kubectl -v9 --request-timeout=… took 5.061s

For context, our cluster is on a private network so you have to be connected to a VPN to access it. The DNS record for it is public though. This happens if you try to use kubectl outside the VPN.

/assign @seans3
We will investigate further and discuss on the biweekly sig-cli meeting.

/remove-lifecycle rotten

I checked this again and I only seem to get the issue on Linux but not on macOS

hey @seans3 , did you create pr for this issue , if not liked to work on it :)


npm test fails because missing dependency morgan

After running npm test I get the following error.
npm test

><EMAIL_ADDRESS>test /Users/keheliya/dev/Moonridge
> mocha

  basic CRUD including working liveQueries
module.js:338
    throw err;
    ^
Error: Cannot find module 'morgan'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/keheliya/dev/Moonridge/test/e2e-smoketest/server.js:16:9)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3

I think morgan is used by server.js

you're right, as it is now, those dependencies don't get installed by default.


Extra Values For Events

What feature do you want to get added on the base engine?
I feel like in some cases, only 2 values aren't enough, so maybe you could make it up to 4 or 5 values
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

Ain't happening because it would require reworking what I've finished already


[Bug]: OSError: [Errno 24] Too many open files:

What happened?
I use Django and host it as a service.
After a long time, the following issue happened
OSError: [Errno 24] Too many open files:
Is there some close() function that should be called after a query or a collection is established?
Versions
chroma-hnswlib==0.7.3
chromadb==0.4.15
Python: 3.11.4
Relevant log output
No response

After checking, I almost confirm that the leak is because of chroma.

What is your file limit? Can you run ulimit -n and report back the value if you are on a Unix system?
Chroma requires a high fd limit and the default is set quite low. We have a setting "chroma_server_nofile" that can be used to increase this limit. I suggest something like 65K.

Thanks, the original is 1024, and last night I already changed the limit to about 1M, and let me observe it...

After a day, I checked the command: lsof | grep 25801 | wc -l
The number is 117040
I think there should be a problem inside...

That is odd, can you show the output for which files are being opened?

this one:
chroma.sqlite3

Any finding for this issue?

I am facing a similar issue. I am running Chroma DB from LangChain for a question-answer application.
After certain amount of load, my app went into "Too many open files".
I started investigating and found out that for each request on my app, the number of open descriptors is piling up by 5-10.
Example of "lsof | grep -c chroma" results:
Pre-request -  123
During request - 497
Post-request - 128
And it keeps growing like this after each request.

The issue is because of this line: https://github.com/chroma-core/chroma/blob/main/chromadb/api/segment.py#L692
The class hierarchy is tricky to navigate, but in essence loading an index opens a few related files. Crucially, these files are never closed after they've been used. I've hacked around trying to delete Python objects to see if the files will eventually close, but to no avail. I think hnswlib keeps them open until the entire Python process is killed.
What does work is adding  vector_reader.close_persistent_index() in the method I've linked, after the results have been fetched. I don't know if it is threadsafe, and I also don't know if trying to re-use an index with closed files will fail, but in my testing it kept working. My use case does not modify any indexes while the Python process is running though.
Ultimately a better solution is to give your client object a time-to-live. Kill and recreate it every X minutes / calls, and that should release the open files. I'll try it shortly and leave feedback here. It may not work because of the aforementioned issue where I suspect hnswlib keeps the files open until the entire Python process is killed.

@chest3x, @hedleyroos, thank you for this analysis. I will dig deeper and let you know soon.

I've tested a TTL on the client object. I you also forcibly do import gc; gc.collect() after the client object is destroyed then the file descriptors are released correctly. Garbage collection is sometimes like cargo culting and I prefer not to do it in a web server environment, but it seems to be working. A client pool would be a decent solution.

Unfortunately recreating the client object and doing a subsequent garbage collect works on 0.4.13 but not 0.4.22.

I've gone through the code in detail, but there are a few different styles of caches and it needs someone more familiar to investigate. However, in the case of Django and any other webserver the workaround is simple. Ensure you create a fresh client object on each request. Overhead is minimal. Subclass Client to create your own client class (note the import):
from chromadb.api.client import Client

class MyClient(Client):

    def __del__(self):
        for instance in self._server._manager._instances.values():
            getattr(instance, "close_persistent_index", lambda: None)()

At the end of each request this client will close the open files correctly. It's not an awesome solution (client pool would still be better) but at least it solves the immediate issue.

@tazarov Chroma is threadsafe, but hnswlib is ultimately a shared object accessed through Python's ctypes , CFFI or equivalent interface. When hnswlib is imported it belongs to the running Python process, not a single Python object like the Chroma Client.
hnswlib opens files when loading vectors, but when the Python Client object that invoked it is deleted the shared object cannot automatically know that it has to close files. The SO "belongs" to the running Python process, and it has no concept of Python objects. Once the Python process is killed in its entirety all open file handles are released, probably due to some unload code or maybe code in a destructor somewhere in hnswlib.
I've read through the caching code in Chroma, and while I should really address this in a new ticket, I don't think any process should see what ulimit is and then assume it can open files until it reaches that value (see https://github.com/chroma-core/chroma/blob/main/chromadb/segment/impl/manager/local.py#L71). There may be other code and libraries that also need to open files, so any single piece of code can't assume it can open the max number of files. Also, the LRU cache is only ever used if hint_use_collection is somewhere in the calling stack, which is not always the case. I should really create a ticket for this one :)
I don't run Chroma in server mode, but it looks like CHROMA_SERVER_NOFILE is only for that mode, not when instantiating clients from local storage.
But as I posted earlier it's a trivial fix if you have a long running process like Django and only need to read, not write,  from a vector database(s): don't create one global client object, but rather one per  request, and subclass Client and implement a __del__ method.
Apologies for the long post @tazarov .

I think there is one more "file handler leak" besides the one that @hedleyroos covers in his fix above: When I create databases, the Sqlite3 /path/to/database/chroma.db file remains open as if the connection never closes, and it never gets garbage collected either.
Here's a proof of concept:
import time
import chromadb
from chromadb.api.client import Client

""" apply @hedleyroos fix """
class MyClient(Client):
    def __del__(self):
        for instance in self._server._manager._instances.values():
            getattr(instance, "close_persistent_index", lambda: None)()

for i in range(10):
    settings = chromadb.Settings()
    settings.is_persistent = True
    settings.persist_directory = f'chroma-file-leak-{i}'
    chroma_client = MyClient(tenant=chromadb.DEFAULT_TENANT, database=chromadb.DEFAULT_DATABASE, settings=settings)
    collection = chroma_client.create_collection(name="no-name")
    collection.add(documents=['doc'], ids=['id1'])
    del collection
    del chroma_client
# give time to look at `lsof` and open files
# in macOS: Activity Monitor > double click on the python process > Tab "Open Files and Ports"
time.sleep(600)

The listed files show open files to the respective sqlite3 chroma.dbs even after the client and the collection is objects are deleted. This how it looks on mine–
.../chroma-file-leak-0/chroma.sqlite3
.../chroma-file-leak-1/chroma.sqlite3
.../chroma-file-leak-2/chroma.sqlite3
.../chroma-file-leak-3/chroma.sqlite3
.../chroma-file-leak-4/chroma.sqlite3
.../chroma-file-leak-5/chroma.sqlite3
.../chroma-file-leak-6/chroma.sqlite3
.../chroma-file-leak-7/chroma.sqlite3
.../chroma-file-leak-8/chroma.sqlite3
.../chroma-file-leak-9/chroma.sqlite3

When we work with only a handful of databases like in the example above this is not so much of an issue but when we have to populate thousands of databases (e.g., one database per use case) then it becomes impossible.
I looked in the code for explicitly closing the sqlite connection but I wasn't successful. Any pointers on how we can close it, it is much appreciated.

@nucflash do chroma_client.clear_system_cache() before you delete the instance. Chroma has a class level cache, and I think it's keeping handles open.

Here's the PR #1690 that resolves similar problem, although this more targeted at Chroma server.

Also there's work on proper closing all open file handles for persistent client here - https://github.com/amikos-tech/chroma-core/commit/1e8ce2eed03a951dd115971238e89886652f0811

Thank you for the swift reply @tazarov ! I much appreciate the workaround, and I'm happy to confirm that your solution combined w/ that of @hedleyroos completely solves the issue.

Has the solution to this problem been merged into the ChromaDB? I am still running into this bug when running ChromaDB from LangChain like @chest3x

I also got this error in current version.

@bash99 we have a long standing PR #2014 for this issue. Let me see if we can rebase and reprioritize it.

@bash99 we have a long standing PR #2014 for this issue. Let me see if we can rebase and reprioritize it.

Yes, this patch fix it for me. Does it has any side affects?
I've doing a 10k request with ulimit -n 1024, and my flask server is just fine.

I'm having the same issue,
Pls when can it be closed

@pinsisong, thanks for reminding us about this. I've rebased the PR on the latest main, and all tests pass. Let me check with @HammadB about merging this.


[refactor] remove redundant code in column writer

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
There are redundant code in column writer's two kinds of flush_data_in_current_page implementations. It can be simplified as one function using template.
Solution

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The former code is as above. As we can see, there is even one different sentence in two function except the different parameter.


[feature request] Allow using separate sensors as values for Max, Min and Target

I have a bar that I'd like to display information about a sensor where the Max and Target change daily. It doesn't seem possible to add a templated sensor to the config. Being able to add sensors in place of a static number would be great.

If you're still looking for a solution to this, I wooking for this as well and found https://github.com/custom-cards/bar-card/issues/124 (how to use config-template-card), https://github.com/custom-cards/bar-card/issues/88 (that it was removed in favor of config-template-card) and about 5 other issues asking for this.   I just searched all issues for "target" (which was what I was looking for).

These ways don't work
Max/Min values are updated once and no longer updated when values change.


Is the backbone network never fine-tuned during training?

I saw  following lines inside backbone network in rfcn_ohem_train.pt
param {lr_mult: 0.0  decay_mult: 0.0}
Does that mean all convolution layers of backbone network never got fine-tuned during R-FCN training?

Sorry for my negligence, actually only res1 & res2 layers are fixed during fine-tune.


Update README, Podspec, etc for 0.7 release

I've updated the README for the 0.7 release.
I removed quite a bit of text, since I feel like the README is overly verbose at the moment. We need to figure out the best way to document the SDK without making the README seem overwhelming.
We also have the guides on developer.uber.com that need to be updated. I think this README should be more of a "Quickstart", while things on developer.uber.com should also include the Quickstart as well as more task-oriented guides. API docs should live on CocoaDocs (or we can self-host), and be generated by Jazzy
In addition, I update the Podspec and Cartfiles for the new version.
The last code change has to do with the UserProfile. In that change, I had a deprecated tag on the rider's UUID, but it was causing external projects to show compilation warnings since the SDK code self-references a deprecated attribute. I restructure it to use a hidden, private variable so it no longer triggers a compiler warning.

Hey,
Do you think uber will update the sdk some day soon ? 😅
Thanks :)

@gorbat-o planning on tagging a release this morning (Pacific time). Would love to work with you and get your feedback!

LGTM :shipit:

@gorbat-o: We are now on v0.7.0, which adds Swift 4 support!
https://github.com/uber/rides-ios-sdk/releases/tag/v0.7.0

Thanks, this is so cool


Return null from joinModelClass() if not defined

A small fix for an issue when calling  joinModelClass(knex) on relations that don't have any join models defined, along with a test for it.

Coverage remained the same at 95.052% when pulling 29edcbebb5d0cde309bff62c387db41cbad1d18a on lehni:fix/join-model-class into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Coverage remained the same at 95.052% when pulling 29edcbebb5d0cde309bff62c387db41cbad1d18a on lehni:fix/join-model-class into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Coverage remained the same at 95.052% when pulling 29edcbebb5d0cde309bff62c387db41cbad1d18a on lehni:fix/join-model-class into 1d8bf81dc6e35581a6626edce891b23811dbfc7e on Vincit:master.

Looks like a random fail in Node 9...
Also, I just noticed that joinModelClass() is private. Could it be added to the public API? I have use for it, e.g. for cleaning join tables in unit tests.

I don't think joinModelClass function should be public. You need to pass knex instance to it, which is not the nicest API. You can use raw knex to clear the join table.

The nice thing about being able to access joinModelClass() is that I don't have to hard-code the table names, and can have things operate on a meta-level. There is real value in that...
What if the private joinModelClass(knex) was renamed to getJoinModelClass(knex), and we introduce a new, public get joinModelClass() accessor which returns this.getJoinModelClass(this.ownerModel.knex())? I think this would be generally useful, without causing harm.

this.getJoinModelClass(this.ownerModelClass.knex())

👍 seems like a good idea. I wonder if there was a reason I didn't do it that way to begin with 🤔
Well, if the tests pass, then I'm okay with that.

Great to hear! I'm happy to work on the PR for it. Do you mean it could even be used internally instead of passing knex around?

Maybe if the tests work. I'm pretty sure it was a failing test that made me add the knex as an argument. I can't remember why it's needed. It has something to do with the fact that if the junction table model is not provided, it is generated.

Ok, I will look into all this shortly!

@koskimas good news: All tests seem to pass!

Let's see if this passes all tests on Travis. If this looks good to you,  I shall add some docs to it as well.

All green! 🎉

Hmm is this another random fail? It only happens on Node 6, but is somehow related to Postgresql

I've added docs to it now, and it all seems to pass again.

LGTM! Thanks


Document Functions Thoroughly:

Add detailed comments to each function describing its purpose, parameters, return values, and potential side effects. This enhances readability and helps other developers understand how to interact with the interface.

working on it

i am new in this repo, could you please explain on which files do we need to add comments?
i would be happy to contribute

okay i found some functions which i understand and trying to write comments about params and return type.
i just wanted to confirm  you wanted to write comments in GoDoc-style or JavaDoc-style ?
@alkindivv  @garrettparris @itsdevbear

@mushitori use go-doc style


added code example to addon docs

Issue:
What I did
I added documentation to the addon docs to show a code example of global configuration.
This is a change to the documentation.

Great!


Hover to quicklinks is added to all pages & FAQ is added to blog page #906

Hello @Suchitra-Sahoo ,
Issue #906  is now fixed
once check it out and please add appropriate labels to it
Before
There are different hover effect exists on quicklinks at footer section on Home ,blogs,FAQ pages.
After
Now it is fixed with a better hover effect which is applied to all the pages
Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/108344062/88125f8e-8d32-4586-88ff-d5115af7274d
Checklist:

[X] I have performed a self-review of my code
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

the links should not  be underlined keep it same as home page

Then in all pages should be like that right

yes


Quickstart - Project ID by domain + preview setup toolbar (DO NOT MERGE)

This is a branch with modifications of the sample app for the shared instance powering the default preview for the Sample project
e.g. https://f096e16bc2cd00f5771fb984dfc4c31d.dancinggoat-sample.com/
We keep this PR to keep it in mind and observe changes and conflicts against the main branch.
DO NOT MERGE IT TO MASTER!
Keep it rebased, not merged, and with minimum changes over the main branch.
See https://github.com/Kentico/kontent-sample-app-net/tree/newquickstart#quick-start for more details

@kenticomartinh - I have converted this pull request into a pull request draft since it is not meant to be merged now.

This branch was already merged into KCL-6857_quickstart that was later removed in favour of the quickstart branch that it replaced (see https://github.com/Kentico/kontent-sample-app-net/pull/129).


Updating datastore write-related functions to v1beta3

This PR:
-- Updates entities & mutations to use v1beta3.  This includes tweaks to add methods to maintain a clear order.
-- Removes BatchOption and TransactionOption classes (since isolation level and force writes have been deprecated)
-- Modifies spi files & LocalGcdHelper.java to use v1beta3 (needed to run DatastoreTests)

@ajkannan  good job. done reviewing. please fix mentioned issue and I think then it is ready for merge.

@aozarov The latest round of comments (regarding DefaultDatastoreRpc.java) have been incorporated.

LGTM.


Feature/seb boris clean

Pull request of boris solver code only. Should not interact with the existing solver classes.

@TomGoffrey thanks for the feedback. I've implemented your recommendations.


Document that meshes and lights must be fully set up before baking VoxelGI

master version of https://github.com/godotengine/godot/pull/58292.
Requested by @groud on the Godot contributors chat.

Thanks!


Allow numeric cells to be "empty"

This simple change allows numeric cells to be empty, rather than forcing a value. For example, a "Sale Price" field. If it's empty there's no sale price, but with the current script it'll force to 0 making the item free.
Once merged, simply add allowEmpty: true to the columns parameter.

Thanks for that!


TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string

I'm having trouble with my script. I have
// postcss.config.js
const purgecss = require("@fullhuman/postcss-purgecss")({
    // Specify the paths to all of the template files in your project
    content: ["./themes/losvast20/**/*.ejs"],

    // Include any special characters you're using in this regular expression
    defaultExtractor: content => content.match(/[\w-/:]+(?<!:)/g) || []
});

const nano = require("cssnano")({
    preset: "default"
});

const hash = require("postcss-hash")({
    algorithm: "sha256",
    trim: 20,
    manifest: "./manifest.json"
});

console.log("*******", process.env.NODE_ENV);
process.env.NODE_ENV = "production";

module.exports = {
    from: undefined,
    plugins: [
        require("postcss-nested"),
        require("postcss-color-function"),
        require("tailwindcss"),
        ...(process.env.NODE_ENV === "production" ? [purgecss, nano, hash] : [])
    ]
};

It worked up to the point that I added hashing.
At that point I got an error
ERROR Asset render failed: css/style.css
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:125:11)
    at Object.dirname (path.js:1260:5)
    at Object.rename (/Users/code/clients/losvast/node_modules/postcss-hash/utils.js:27:19)
    at /Users/code/clients/losvast/node_modules/postcss-hash/index.js:23:32

I'm completely new to postcss and am using it in this project to become more familiar

I'm having the same issue. Has there been a workaround for this?

I'm thinking this might be the same problem as #5.
I also have no luck making this work. Applying the check from #5 will just not create any hashed file for me.
My postcss.config.cjs:
module.exports = {
    plugins: [
      require('postcss-import'),
      require('tailwindcss/nesting'),
      require("stylelint"),
      require('tailwindcss'),
      require('autoprefixer'),
      require('postcss-calc'),
      ...(process.env.JEKYLL_ENV == 'production'
        ? [
          require('cssnano')({ preset: 'default' }),
          // Cannot make this work, see https://github.com/keithamus/postcss-hash/issues/5
          // and https://github.com/keithamus/postcss-hash/issues/8
          // require('postcss-hash')({ algorithm: 'sha256' })
        ]
        : []
      )
    ]
  }


Run as Daemon on Debian

Hi,
I am trying to run EpcEmuServer like a Daemon on Debian. I created a service with systemd, EcpEmuServer start but systemd will be not aware if EcpEmuServer is started and systemd timeout and restart EcpEmuServer.
Is there a way to run like a daemon without human interacting? Thanks

Hi,
I did it with:
/etc/systemd/system/EcpEmuServer.service [Unit] Description=Starting the Harmony Haus AutomationEcpEmuServer.service After=multi-user.target
[Service] ExecStart=/usr/bin/bash /srv/debian/EcpEmuServer-linux_x64/EcpEmuServer.sh Type=simple
[Install] WantedBy=multi-user.target
systemctl enable EcpEmuServer.service systemctl start EcpEmuServer.service
Regards
Gerhard

Please share also EcpEmuServer.sh file, so I can replicate your configuration
Thanks

Hi,
sorry that I have missed this part:

I am using an Debian LxD - bookworm
installed the dotnet6 - higher version was not supported
I don't know if this has changed in the meantime.

The script:
#!/usr/bin/bash
EcpEmu_DB_DIR=/srv/debian/EcpEmuServer-linux_x64
EcpEmu_DB_LOG=EcpEmuServer.log
#DOTNET_ROOT=/usr/lib/dotnet
#export DOTNET_ROOT
DOTNET_ROOT=/root/.dotnet
export DOTNET_ROOT
exec &> $EcpEmu_DB_DIR/$EcpEmu_DB_LOG
#LD_LIBRARY_PATH=/usr/lib/dotnet/dotnet6-6.0.110/host/fxr/6.0.10
#export LD_LIBRARY_PATH
cd $EcpEmu_DB_DIR
./EcpEmuServer &> /dev/null

[Unit]
Description=EcpEmuServer
After=multi-user.target
[Service]
WorkingDirectory=/var/ecpemuserver
ExecStart=/var/ecpemuserver/EcpEmuServer
Type=simple
[Install]
WantedBy=multi-user.target


[BUG] - AttributedTextEditingController.clear() not working as expected

Package Version
SuperTextField from super_editor on latest main
User Info
Superlist
To Reproduce
Steps to reproduce the behavior:

Type some text into a SuperTextField
Press a button which is hooked up to call AttributedTextEditingController.clear()
The text is not cleared, and no exception is printed to the console.
If you then continue to type text, an exception is printed to the console.

Note: I have found it possible to work around this by instead of calling .clear():
    _textController.updateTextAndSelection(
      text: AttributedText(),
      selection: const TextSelection.collapsed(offset: 0),
    );

The above works fine visually:

focus still present
caret still blinking
new typed text ends up in the text field

... however an exception is printed to the console.
Minimal Reproduction Code
If the bug is reproducible in the Example app, you can delete this section. Otherwise, please provide a minimal, runnable code reproduction.

Minimal, Runnable Code Sample
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:super_editor/super_editor.dart';

void main() {
runApp(const MyApp());
}

class MyApp extends StatelessWidget {
const MyApp({super.key});

@override
Widget build(BuildContext context) {
  return MaterialApp(
    title: 'Clear Text Field Example',
    theme: ThemeData(
      colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
      useMaterial3: true,
    ),
    home: const MyHomePage(title: 'Clear Text Field Example'),
  );
}
}

class MyHomePage extends StatefulWidget {
const MyHomePage({
  super.key,
  required this.title,
});

final String title;

@override
State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
final _focusNode = FocusNode();
final _textController = ImeAttributedTextEditingController();

@override
void initState() {
  super.initState();

  SchedulerBinding.instance.addPostFrameCallback((_) {
    // Why do I have to request focus in a post frame callback?
    //
    // I guess it's something about the focus node not yet being parented?
    // Other Flutter widgets don't seem to have this issue.
    //
    // Oddly enough if I don't use the post frame callback, the text field
    // takes up all available vertical space, and results in a layout
    // exception.
    _focusNode.requestFocus();
  });
}

@override
void dispose() {
  _focusNode.dispose();
  _textController.dispose();
  super.dispose();
}

void _clearTextOption1() {
  // Text is not cleared.
  // No error printed to console.
  // Subsequently typed text does not show in text field, and an exception
  // is printed to the console.
  _textController.clear();
}

void _clearTextOption2() {
  // This works perfectly visually:
  // * focus still present
  // * caret still blinking
  // * new typed text ends up in the text field
  //
  // ... but an exception is printed to the console
  _textController.updateTextAndSelection(
    text: AttributedText(),
    selection: const TextSelection.collapsed(offset: 0),
  );
}

@override
Widget build(BuildContext context) {
  final theme = Theme.of(context);
  final textStyle = theme.textTheme.bodyLarge!.copyWith(
    color: theme.colorScheme.primary,
  );
  final hintStyle = textStyle.copyWith(
    color: theme.colorScheme.secondary,
  );

  return Scaffold(
    appBar: AppBar(
      backgroundColor: Theme.of(context).colorScheme.inversePrimary,
      title: Text(widget.title),
    ),
    body: Align(
      alignment: Alignment.topCenter,
      child: Padding(
        padding: const EdgeInsets.all(32),
        child: Container(
          decoration: BoxDecoration(
            border: Border.all(
              width: 1,
              color: Theme.of(context).colorScheme.primary,
            ),
            borderRadius: BorderRadius.circular(8),
            color: Theme.of(context).colorScheme.surface,
          ),
          child: Row(
            mainAxisSize: MainAxisSize.max,
            children: [
              const SizedBox(width: 16),
              Expanded(
                child: SuperTextField(
                  focusNode: _focusNode,
                  textController: _textController,
                  inputSource: TextInputSource.ime,
                  textStyleBuilder: (_) => textStyle,
                  hintBuilder: (_) => Text(
                    'Type something',
                    style: hintStyle,
                  ),
                  hintBehavior: HintBehavior.displayHintUntilTextEntered,
                ),
              ),
              const SizedBox(width: 16),
              IconButton(
                icon: const Icon(Icons.clear),
                onPressed: _clearTextOption1,
              ),
            ],
          ),
        ),
      ),
    ),
  );
}
}

Actual behavior
When calling _clearTextOption1:

Text is not cleared.
No error printed to console.
Subsequently typed text does not show in text field, and an exception is printed to the console.

When calling _clearTextOption2:

This works perfectly visually:

Focus is still present.
The caret still blinking.
Newly typed text ends up in the text field.

An unexpected error is printed to the console.

Expected behavior
When calling _clearTextOption1:

Text should be cleared.
No error should be printed.
Focus should still be present.
The caret should still be blinking.
Subsequently typed text should end up in the text field, without causing any errors.

When calling _clearTextOption2:

Should have exact results as option 1, without any errors.
Should not have to use because option 1 doesn't work.

Platform
Which device(s) and operating system(s) have experienced the problem?
All of above notes are about iOS.
Just checked macOS and it also suffers from the issues with .clear(), but the workaround does not seem to cause any errors to be printed to console.
Did not test on Android or web.
Flutter version
Flutter 3.22.0-22.0.pre.7 • channel main • https://github.com/flutter/flutter.git
Framework • revision 9f3be7dfd9 (6 weeks ago) • 2024-05-02 04:15:02 -0400
Engine • revision 58b031c096
Tools • Dart 3.5.0 (build 3.5.0-122.0.dev) • DevTools 2.35.0

Screenshots
Option 1:
https://github.com/superlistapp/super_editor/assets/5852503/b42100a1-cac1-4ce6-a14e-eceda85fba79
Option 2:
https://github.com/superlistapp/super_editor/assets/5852503/ecec124f-cfa9-4281-9240-6ee080ac8bfe

Cc @matthew-carroll

@CillianMyles Is there any other step or setting needed to trigger this issue?
I'm trying to reproduce this issue with the exact flutter version and OS version, but so far I was unable to reproduce it.
https://github.com/superlistapp/super_editor/assets/7597082/ec497835-917c-4838-a1a7-d3bf12b5bbc7

Hey @angelosilvestre
So I looked into my sample app setup, and I think I found the cause of all the exceptions: I forgot to override attributed_text to point to main.
With the following I get no exceptions:
name: clear_text_editing_controller
description: "A new Flutter project."
publish_to: 'none'
version: 1.0.0+1

environment:
  sdk: '>=3.5.0-122.0.dev <4.0.0'

dependencies:
  flutter:
    sdk: flutter
  attributed_text:
  super_editor:
  super_text_layout:

dependency_overrides:
  attributed_text:
    git:
      url: git@github.com:superlistapp/super_editor.git
      path: attributed_text
      ref: main
  super_editor:
    git:
      url: git@github.com:superlistapp/super_editor.git
      path: super_editor
      ref: main
  super_editor_markdown:
    git:
      url: https://github.com/superlistapp/super_editor
      path: super_editor_markdown
      ref: main
  super_text_layout:
    git:
      url: git@github.com:superlistapp/super_editor.git
      path: super_text_layout
      ref: main

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints:

flutter:
  uses-material-design: true

Which are resolved to:
  attributed_text:
    dependency: "direct main"
    description:
      path: attributed_text
      ref: main
      resolved-ref: e4561f8cbebb7b7baa7b6c941d68abc820e44a98
      url: "git@github.com:superlistapp/super_editor.git"
    source: git
    version: "0.3.1"
  super_editor:
    dependency: "direct main"
    description:
      path: super_editor
      ref: main
      resolved-ref: e4561f8cbebb7b7baa7b6c941d68abc820e44a98
      url: "git@github.com:superlistapp/super_editor.git"
    source: git
    version: "0.3.0-dev.1"
  super_editor_markdown:
    dependency: "direct overridden"
    description:
      path: super_editor_markdown
      ref: main
      resolved-ref: e4561f8cbebb7b7baa7b6c941d68abc820e44a98
      url: "https://github.com/superlistapp/super_editor"
    source: git
    version: "0.1.5"
  super_text_layout:
    dependency: "direct main"
    description:
      path: super_text_layout
      ref: main
      resolved-ref: e4561f8cbebb7b7baa7b6c941d68abc820e44a98
      url: "git@github.com:superlistapp/super_editor.git"
    source: git
    version: "0.1.10"

However I still have the same problem as I see in your video. By calling _controller.clear() the text is visually cleared, but the cursor is no longer blinking. When I type text it ends up in the field, but for a second it doesn't look like the field still has focus. Can you see that?

@matthew-carroll Currently, AttributedTextEditingController.clear() clears both the text and the selection. This is what causes the caret to stop blinking. Should we place the selection at offset zero when AttributedTextEditingController.clear() is called?
This would be essentially the same as:
_textController.updateTextAndSelection(
    text: AttributedText(),
    selection: const TextSelection.collapsed(offset: 0),
  );

It's tough for me to say without knowing all the places that people are likely using the clear() method. Have you come across any use-case where your suggested behavior would cause a problem?

Thanks @angelosilvestre and @matthew-carroll
Then my suggestion would be one of:

add .clearText() and .clearTextAndSelection() variations and potentially deprecate ambiguously named .clear() method
.clear() only clears the text, not selection (but I realise this is purely based off my personal interpretation of the method intention, and is a breaking functionality change for existing callers)
add dart docs for .clear() stipulating that it also clears the selection

BTW this is just my 2 cents on how to make the API more intuitive for the next developer, this is not blocking me!
I would be happy to contribute one of the above options if you would like to go ahead with one of them @matthew-carroll

@angelosilvestre I think option 1 from @CillianMyles makes sense. What do you think? Any concerns?

@CillianMyles I agree with option 1. Do you want to take over this ticket?

I'll give it a go! 🙏

@matthew-carroll @angelosilvestre I put up a PR #2125
Surprised that I deprecated the clear method and didn't get any analysis warnings during the PR checks.

@CillianMyles can you do a check for usages in super_editor and super_text_layout?

@matthew-carroll all code review comments are address, and I replaced all usages of .clear() with .clearTextAndSelection() which has the same behaviour!


is there a way to hide pink bar just above bottom toolbar in the sample?

I tried all the following but nothing worked:
_bottomBar.NoTabletGoodness();
_bottomBar.UseFixedMode();
_bottomBar.HideShadow();
_bottomBar.NoTopOffset();
_bottomBar.NoNavBarGoodness();

Pink color comes from this line
https://github.com/thrive-now/BottomNavigationBarXF/blob/master/example/BottomBarXFExample/App.xaml.cs#L16
bottomBarPage.BarBackgroundColor = Color.Pink;

It's no a solution. You can change the color of the bar but will be still here. See #6

@JordanGout thanks for pointing that out
I added a comment on how to fix it and remove pink line https://github.com/thrive-now/BottomNavigationBarXF/issues/6#issuecomment-242866636

I added a PR for it https://github.com/thrive-now/BottomNavigationBarXF/pull/16

Hey guys!
Does the already merged PR by @escamoteur fully solve this issue for you? @Korayem @andreinitescu @JordanGout

You can fix it by changing "Height" to "MeasuredHeight" in the OnLayout of the renderer.
_pageController.ContainerArea = new Rectangle(0, 0, context.FromPixels(width), context.FromPixels(_frameLayout.MeasuredHeight));


Add macOS to CI

Let's see if this works
Note valgrind doesn't seem to be well-supported on macOS: https://stackoverflow.com/questions/65009780/macos-valgrind-alternative We'll just rely on the Linux test for that (and besides, brew is super slow)

Codecov Report

Merging #17 (50c5a52) into dev (3a35847) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev      #17   +/-   ##
=======================================
  Coverage   66.21%   66.21%
=======================================
  Files           3        3
  Lines         222      222
  Branches       59       59
=======================================
  Hits          147      147
  Misses         61       61
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a35847...50c5a52. Read the comment docs.

Seems to work
I get a compiler warning about format string on macOS. @kentjhall or @hmontero1205 , do either of you have any ideas as to how we can squash those warnings? See: https://github.com/ssm-lang/ssm-runtime/runs/4671112938?check_suite_focus=true#step:5:8
Ideally we can get away with just a preprocessor statement in just ssm-examples.h

Also added clang to the build matrix. Note that gcc is symlinked to clang on macos and is somewhat annoying to set up. My main concerns are (1) brew is really slow and annoying to use, (2) we need to make sure that gcc on PATH isn't the symlink to clang, (3) gcc on macOS isn't really a very representative setup.
For (1), we will need to set up the cache action, but I'm not sure how best to do that with Brew installations. For (2), that just takes soem fussing. but (3) is why I don't think it's necessarily worth doing this. But if anyone with a macOS wants to give this a shot, be my guest.

Just realized, for suppressing the compiler warning about the format string, it might just be as simple as adding a cast to unsigned long in the printf call. It shouldn't be a big deal since we aren't expecting any tests to simulate more than, say, 10000 seconds.


Crude LS2 primitives

Added lease.go:
Lease2 is defined as
type Lease2 [LEASE2_SIZE]byte

Lease2 methods:

added TunnelGateway()
added TunnelID()
added EndDate()
added ToBytes()
added String()

added ReadLease2()
added NewLease2()
added NewLease2FromBytes()

Added offline_signature.go:
OfflineSignature is defined as
type OfflineSignature struct {
	Expires            uint32
	SigType            uint16
	TransientPublicKey []byte
	Signature          []byte
}

OfflineSignature methods:

added Bytes()
added VerifyOfflineSignature()

added ReadOfflineSignature()
added NewOfflineSignature()

Added lease_set2_header.go:
ParsedLeaseSet2Header is defined as
type ParsedLeaseSet2Header struct {
	Destination      destination.Destination
	Published        uint32
	Expires          uint16
	Flags            uint16
	OfflineSignature *offline_signature.OfflineSignature
}

ParsedLeaseSet2Headers methods:

added Serialize()

Added lease_set2.go:
LeaseSet2 is defined as
type LeaseSet2 []byte

ParsedLeaseSet2 is defined as
type ParsedLeaseSet2 struct {
	Header         ParsedLeaseSet2Header
	Options        Mapping
	EncryptionKeys []EncryptionKeyEntry
	Leases         []lease2.Lease2
	Signature      []byte
	Destination    Destination
	SignatureType  uint16 // from the Destination's or Offline signature
}

ParseLeaseSet2 methods:

VerifyLeaseSet2()
serializeWithoutSignature()

EncryptionKeyEntry is defined as
type EncryptionKeyEntry struct {
	KeyType uint16
	KeyLen  uint16
	KeyData []byte
}

added ReadLeaseSet2()
added sigTypeKeyLengthsForLS2()
added NewLeaseSet2()

Elg tests are failing due to some anomaly in the CI/CD pipeline, the test works in isolation.


Resolves #1797, Add a font selector + switch default font to source sans

Also fixes a bug where the text disappears at fork (#1797)

lgtm


Add notebook path to spark appName

Make it easier to identify which spark applications belong to which notebooks (when people copy notebook the appName in metadata stay the same, or if notebooks are in different dirs)
will look like this: Old Explicit Name (sql/DataFrame.snb)
fixed #427
cc @andypetrella

:+1:


Add sync with editor command and use different icons for package representation

Add sync command to synchronize/desynchronize dependency viewer selection with folder explorer
Split changeRepresentation to changeToFlatPackageView and changeToHierarchicalPackageView, use different icons.

Would be great if gif/screenshot is provided


The stream.ts/ stream.js file should be at root level

Hi Developers,
The structure of code for this library is very different from classical npm libraries.
When I was mocking this library using jest I encounter issue while mocking this library.
Cannot find module 'eventsource-parser/stream'
The suggestion would be create a index.ts file for routing to stream component.

Hi. It's a shame that jest doesn't support package exports.
I've released a new version of the parser that adds legacy exports through root-level files.
You'll find it as v2.0.0 - I dropped support for Node versions older than Node 18.


Chronograf server ASG target groups are getting removed

Problem
Hi, I'm using the terraform modules to run a chronograf and a kapacitor server on AWS. I encountered the problem, that terraform apply would remove the target group from the auto scaling group, even tough there were no real changes to the resources. (This could lead to down time on production systems.) When running terraform apply a second time, terraform would reattach the target group to the ASG.
This problem occurs in the AWS terraform provider and it's rerlated to the lifecycle of the ASG. There is this GitHub issue discussing this: https://github.com/hashicorp/terraform-provider-aws/issues/14540
Possible solution
To solve the issue  for my project, I forked the this repo and added a lifecycle block to the ASG resource, as suggested in here: https://github.com/hashicorp/terraform-provider-aws/issues/14540#issuecomment-680099770 After running terraform apply the problem was solved.
resource "aws_autoscaling_group" "autoscaling_group" {
  name = var.cluster_name

...

  lifecycle {
    ignore_changes = [load_balancers, target_group_arns]
  }

...

}

The terraform apply did not cause any down time. I'm not sure about backwards compatibility. I'm still running v0.1.2 of the TICK stack modules and had no problems.

I hope you can use this information to create a fix release and thanks for creating and maintaining these module.

Ah, you're right, we had to do similar fixes in other modules. E.g., https://github.com/hashicorp/terraform-aws-nomad/pull/78. A PR to do the same here is very welcome!

Ah, you're right, we had to do similar fixes in other modules. E.g., https://github.com/hashicorp/terraform-aws-nomad/pull/78. A PR to do the same here is very welcome!


Alpine 3.8

Thanks @brownhouse
I'll enable Dependabot to keep things automatically updated from now on.


Adds the 1.9.5 fluent-bit rock

The -DFLB_TRACE=Off cmake flag is set in v1.9.5, and the -DFLB_CHUNK_TRACE=On is set in v2.1.6.
Updated the sanity tests to also test v1.9.5 image.
Updated integration test to pick the v2.1.6 image.

Should be merged after: https://github.com/canonical/fluent-bit-rock/pull/4

Some conflicts now because of the #4 merge. Please resolve, after that we can merge this as well.


HBASE-25278 Add CACHE_BLOCKS option to count shell command

Expose an argument on the count command which is passed to the
setCacheBlocks method on the Scan which the count command uses.
This is a quick and dirty approach to read all of the blocks for a table
into the block cache.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

-0 :warning:
rubocop
0m  9s
The patch generated 8 new + 130 unchanged - 0 fixed = 138 total (was 130)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

Validated this with a little local install.  Ran count 'TestTable' and did not see block cache usage grow. Ran count 'TestTable', CACHE_BLOCKS=>true and BC jumps up in use.

We have approximately 60 hours before the 2.4.0 RC0 is unblocked. If you want to get this in, please merge the PR in that timeframe.

We have approximately 60 hours before the 2.4.0 RC0 is unblocked. If you want to get this in, please merge the PR in that timeframe.

Roger.

@z-york how's 5ae86b5 look?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

-0 :warning:
rubocop
0m 10s
The patch generated 9 new + 130 unchanged - 0 fixed = 139 total (was 130)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.


document how to modify OE submodule

HACK.md, mhh... Not really sure I like the file name. It sound luring to look inside from the file viewer, but I would not exactly expect instructions to build the patch files in here.
Maybe DEVELOPMENT.md, or PATCH.md?

This was inspired by https://github.com/aquynh/capstone/blob/master/HACK.TXT. Other projects use HACK or HACKING for their development instructions, too, e.g., https://github.com/snapcore/snapd/blob/master/HACKING.md or https://github.com/ghc/ghc/blob/master/HACKING.md.
So what do you think? HACK, HACKING, DEVELOPMENT, DEVELOP, DEVELOPING? (I don't like PATCH)

Didn't really notice it was this common, but actually it is. You never stop learning...
Would go with HACKING.md, that seems to be the most common variant.


Error Formatting HCL When Importing DataDog Monitors

I got the following errors when running  ./terraformer import datadog --resources=monitor
Commit 32491d376838bc4fdc88a9e2c53573023dc41bb6
2020/02/16 22:25:07 Invalid HCL follows:
   1|   resource "datadog_monitor" "tfer--monitor_11488873" {
   2|     escalation_message = "Escalation message"
   3|     evaluation_delay = "0"
   4|     include_tags = "true"
   5|     locked = "false"
   6|     message = "Monitor triggered.\n\nasdfasdfa\n\ndfasdf\n\nsffasfs\n @lasjfsldf"
   7|     name = "Name for monitor foo"
   8|     new_host_delay = "300"
   9|     no_data_timeframe = "0"
  10|     notify_audit = "false"
  11|     notify_no_data = "false"
  12|     query = "avg(last_1h):avg:aws.ec2.cpu{environment:foo,host:foo} by {host} > 4"
  13|     renotify_interval = "60"
  14|     require_full_window = "true"
  15|     thresholds = {
  16|       critical = "4.0"
  17|       critical_recovery = "3.0"
  18|       ok = "0.0"
  19|       warning = "2.0"
  20|       warning_recovery = "1.0"
  21|     }
  22|     timeout_h = "60"
  23|     type = "query alert"
  24|   }
 25|
  26|   resource "datadog_monitor" "tfer--monitor_5973555" {
  27|     escalation_message = "<nil>"
  28|     evaluation_delay = "0"
  29|     include_tags = "true"
  30|     locked = "false"
  31|     message = "Triggers if any host's clock goes out of sync with the time given by NTP. The offset threshold is configured in the Agent's `ntp.yaml` file.\n\nPlease read the [KB article](https://docs.datadoghq.com/agent/faq/network-time-protocol-ntp-offset-issues) on NTP Offset issues for more details on cause and resolution."
  32|     name = "[Auto] Clock in sync with NTP V2"
  33|     new_host_delay = "300"
  34|     no_data_timeframe = "10"
  35|     notify_audit = "false"
  36|     notify_no_data = "false"
  37|     query = "\"ntp.in_sync\".over("*").last(2).count_by_status()"
  38|     renotify_interval = "0"
  39|     require_full_window = "true"
  40|     thresholds = {
  41|       critical = "1"
  42|       ok = "1"
  43|       warning = "1"
  44|     }
  45|     timeout_h = "0"
  46|     type = "service check"
  47|   }
2020/02/16 22:25:07 error formatting HCL: At 37:34: illegal char

look like over("*") need be over(\"*\")
Maybe add base64 convert and try escape query.

That’s same problem as in #343


bump: kube, k8s-openapi and opentelemetry

Description
Please add a description here. This will become the commit message of the merge request later.
Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

I would argue that we change the title to "chore: Bump all dependencies".